added events func in case of wrong optional cm data

Pull request checklist
Zenhub Tracker: Generate events for configmap parameter validation

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

In the current behavior, there are no feature to show CSO events whenever any wrong data comes in the optional configMap.

What is the new behavior?

In the new behavior, there will have functionality to show CSO events in case of any wrong data comes in the optional configMap.

How risky is this change?

[x] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

Below are the Events outputs:

Status:
Conditions:
Last Transition Time:  2023-08-17T07:12:42Z
Message:               The CSI driver resources have been created/updated successfully
Reason:                CSIConfigured
Status:                True
Type:                  Success
Versions:
Name:     ibm-spectrum-scale-csi
Version:  2.10.0
Events:
Type     Reason             Age                From              Message

Warning  ValidationWarning  79s                CSIScaleOperator  There are few entries [BADRI] with wrong key which will not be processed and there are few entries having wrong values map[VAR_DRIVER_NODEPUBLISH_METHOD:SYMLINks VAR_DRIVER_PERSISTENT_LOG:ENABLEDd] in the configmap ibm-spectrum-scale-csi-config, default values will be used
Normal   CSIConfigured      76s (x5 over 79s)  CSIScaleOperator  The CSI driver resources have been created/updated successfully

When only key is wrong in the configmap

Events:
Type     Reason             Age                  From              Message

Warning  ValidationWarning  2m46s                CSIScaleOperator  There are few entries [BADRI] with wrong key which will not be processed and there are few entries having wrong values map[VAR_DRIVER_NODEPUBLISH_METHOD:SYMLINks VAR_DRIVER_PERSISTENT_LOG:ENABLEDd] in the configmap ibm-spectrum-scale-csi-config, default values will be used
Warning  UpdateFailed       41s (x3 over 2m44s)  CSIScaleOperator  Failed to set defaults on the instance ibm-spectrum-scale-csi. Please check Operator logs
Normal   CSIConfigured      9s (x20 over 2m46s)  CSIScaleOperator  The CSI driver resources have been created/updated successfully
Warning  ValidationWarning  9s                   CSIScaleOperator  There are few entries [BADRI] with wrong key which will not be processed and there are few entries having wrong values map[] in the configmap ibm-spectrum-scale-csi-config, default values will be used

When only values of the keys are wrong in the configmap

Events:
Type     Reason             Age                     From              Message

Warning  ValidationWarning  7m31s                   CSIScaleOperator  There are few entries [BADRI] with wrong key which will not be processed and there are few entries having wrong values map[VAR_DRIVER_NODEPUBLISH_METHOD:SYMLINks VAR_DRIVER_PERSISTENT_LOG:ENABLEDd] in the configmap ibm-spectrum-scale-csi-config, default values will be used
Warning  UpdateFailed       5m26s (x3 over 7m29s)   CSIScaleOperator  Failed to set defaults on the instance ibm-spectrum-scale-csi. Please check Operator logs
Normal   CSIConfigured      4m54s (x20 over 7m31s)  CSIScaleOperator  The CSI driver resources have been created/updated successfully
Warning  ValidationWarning  4m54s                   CSIScaleOperator  There are few entries [BADRI] with wrong key which will not be processed and there are few entries having wrong values map[] in the configmap ibm-spectrum-scale-csi-config, default values will be used
Warning  ValidationWarning  43s                     CSIScaleOperator  There are few entries [] with wrong key which will not be processed and there are few entries having wrong values map[VAR_DRIVER_PERSISTENT_LOG:ENABLEDds] in the configmap ibm-spectrum-scale-csi-config, default values will be used

@saurabhwani5 This PR has been updated with latest changes. This can be good to go ahead for testing.

Regression passed


[Hub Generated] Review request for Route to add version preview/2023-10-01-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[x] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@JeffreyRichter I remove the "Not merge" tag and we can merge to main branch now. Thanks.


Provide better documenttion for protocols used between kubernetes nodes

I am setting up kubernetes cluster in AWS with security group allowing all tcp ports. Later I got to know to allow protocol 4 (IP-IP) for traffic between nodes. Then to get node port working I have to allow all traffic between nodes.
Not much information is provided as to what are the protocols used in calico. It would be better if the list is provided of protocols used rather than opening all traffic.
Environment:
AWS in VPC
Kubernetes

Thanks for raising. This requirements page covers some of what you're raising: https://docs.projectcalico.org/v3.2/getting-started/kubernetes/requirements

The following are the current settings of security group.
Outbound all traffic allowed.
Inbound all TCP allowed, custom protocol (4 for IP in IP) allowed
I am not using flannel. Still I enable UDP 4789.
The above setup should cover all the requirements provided in the link. But still the traffic to nodeport will get dropped, if the pods are not available in that particular node. If I allow all the incomming traffic between nodes, it is working as expected.
I am assuming the connections are being dropped by VPC in between nodes. But couldn't figure out what other traffic needs to be allowed for the nodeport to work correctly other than allowing all traffic. Maybe I am missing some other protocol that is used by calico other than IP-IP(4).

This thread has gone stale - please shout if you're still hitting issues.
I think this is likely a misconfig - the docs here show the set of required allows: https://docs.projectcalico.org/v3.3/getting-started/kubernetes/requirements
Things to consider:

Is a network policy dropping the traffic?
Do you have TCP 179 allowed between nodes if you're using BGP?


Allow redefinition of the sentence text object

Is your feature request related something that is currently hard to do?
Please describe

Currently, the definition of the sentence text object
cannot be changed.
This prevents users from doing several useful things:

Using sentence text objects with emoticons (e.g.  :-)) as
sentence-ending punctuation.  Note that while it is possible to require
users to add a “real” punctuation after the emoticon, some designers
recommend against it.  Example:

Hey there :-)  I hope you're all right.

Using sentence text object with emojis (e.g. ☺) as
sentence-ending punctuation.  Same as the above.  Example:

Hey there ☺  I hope you're all right.

Using additional punctuation provided in Unicode, e.g. the “interrobang”
mark (‽).  Example:

Did they really do that‽  I can't believe it!

Using American style of punctuation ordering with Unicode quotes.
Example:

“I don't like sand,” he said, “It gets everywhere.”  She didn't respond.

(A continuation of the pevious point.)  Using Unicode quotes in Russian
etc.  texts.  Example:

Я спросил: «Как дела?»  Он мне не ответил.

Using the Greek question mark in Greek texts.  Example:

Τι κάνεις;  Όλα καλά;

Describe the solution you'd like

An ability to redefine the sentence-ending markers would solve all these
issues.

Describe alternatives you've considered

One alternative would be creating your own text object and remapping
every sentence-related movement.  That sounds like an overkill to me,
although it is probably a working solution.

Another alternative would be adding all those cases as “corner cases”
into the still-non-redefinable sentence text object.  This sounds bad,
since it probably won't be a single change, but an ever-increasing
number of changes and complications.

Additional context

None, I guess?

Check out the existing plugins ... for a start:
https://github.com/kana/vim-textobj-user
and existing usages:
https://github.com/kana/vim-textobj-user/wiki

@Houl I'll take a look, thanks!

Another possible solution for my personal case is to either
redefine cpoptions=J or add a new compatible-option that
defines a sentence as “anything followed by two spaces”.  But that would
obviously not work for people who don't use the double sentence spacing
convention.

closing as this can be done using some plugins. The wiki also has some articles about creating custom text objects.

(don't know why this only stayed in mailing list but ...)
@ainar-g
you can define your own text objects even without a plugin: https://vimways.org/2018/transactions-pending/
for example:
let s:sentence_seps = [
\    ':-)', ':)',
\    ':-(', ':(',
\    '.',
\    '!',
\    ';',
\    '?'
\]

function! s:select_is()
    let l:pat = printf('\(%s\)', join(map(s:sentence_seps, { _,v -> escape(v, '\') }), '\|'))
    unsilent echom l:pat
    if !search(printf('\V%s%s', l:pat, '\_s\*\zs'), 'bWc')
        call search('^', 'bWc')
    endif
    normal! v
    call search(printf('\V%s%s', '\.\ze\_s\*', l:pat), 'Wc')
endfunction

augroup Sentences
    autocmd!
    autocmd filetype text xnoremap <buffer> <silent> is :<c-u>call <sid>select_is()<cr>
    autocmd filetype text onoremap <buffer> <silent> is :<c-u>call <sid>select_is()<cr>
augroup end

See this asciinema where I have used the above maps and used vis to do what you want: https://asciinema.org/a/98GVydvcGxJrTJTESqNCLskL6

@dylnmc This is amazing, thank you! Going to play with your script right now :-)

The definition of sentence affect more things than just text objects. Is there any way to redefine the marks `( as well?


A and AAAA records. Only ipv6 is getting updated. - Help please!

That is expected behaviour as the Porkbun v3 API's documentation is unclear about the response of their ping command (it will either return IPv4 or IPv6). However, there is a dedicated endpoint to request IPv4 specifically. Would you be willing to help me test that? My ISP does not provide IPv6 support and so I need someone to test for me. (It should not take me too long)

The fix is ready in the v1.1rc branch. If anyone is willing to test it, please report back.

thank you for this :)


Extend ASV tests with QASM3 dump

Summary
Inspired by the performance regression fixed in https://github.com/Qiskit/qiskit/pull/13327 , a benchmark test for QASM3 dumper.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 88.67%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
94.02%

crates/qasm2/src/lex.rs
4
92.48%

Totals

Change from base Build<PHONE_NUMBER>2:
0.01%

Covered Lines:
73195

Relevant Lines:
82548

💛  - Coveralls

Could you add an additional tests: one that defines a couple of entirely custom gates (at least one parametric and one non-parametric) and uses the same gate several times in the input circuit?

Done in 1443081c912739040ff9729682900e9495b5bd86


#159114881 Create and test new entry endpoint

What does this PR do?
Create and test new entry endpoint for MyDiary REST API
Description of Task to be completed?
Have this endpoint working:
POST /api/v1/entries/
How should this be manually tested?
After cloning the repo, cd into the directory. RUN 'npm install' to install dependencies.
RUN 'npm run test' to test the endpoint. This use mocha and chai
What are the relevant pivotal tracker stories?
#159114881

it works fine vic. Good one.


"supper" keyword with Arrow function methods

Code
class Base {
    public foo = () => { console.log("Hello world"); }
    // public foo() {     // No error if declare "foo" like this
    //     console.log("Hello world");
    // }
}

class Child extends Base {
    public bar() { super.foo(); };
}

Actual behavior:
ERROR
public bar() { super.foo(); };
                     ~~~
src/main.ts(9,26): error TS2340: Only public and protected methods of the base class are accessible via the 'super' keyword.

TypeScript: 2.0.3
OS: Windows 10 x64
Node: 6.3.0

super.foo() is trying to call Base.prototype.foo, which doesn't exist, because public foo = .. is a property, not a method (methods exist on the prototype, but properties don't).

This is actually per ES spec.

From MakeSuperPropertyReference:

If env.HasSuperBinding() is false, throw a ReferenceError exception.

https://tc39.github.io/ecma262/#sec-makesuperpropertyreference

From HasSuperBinding:

If envRec.[[ThisBindingStatus]] is "lexical", return false.

https://tc39.github.io/ecma262/2016/#sec-function-environment-records-hassuperbinding

From NewFunctionEnvironment:

If F.[[ThisMode]] is lexical, set envRec.[[ThisBindingStatus]] to "lexical".

https://tc39.github.io/ecma262/2016/#sec-newfunctionenvironment

From FunctionInitialize:

If kind is Arrow, set F.[[ThisMode]] to lexical.

https://tc39.github.io/ecma262/2016#sec-function-environment-records-hassuperbinding

I have a similar case but with getter/setter.
Getters and setters are on the prototype chain however.
This works fine when transpiling to ES2015 but not when transpiling to ES5.
Example from the playground:
class Foo {
    private _foobar: string;

    public get foobar(): string {
        return this._foobar;
    }

    public set foobar(value: string) {
        this._foobar = value;
    }
}

class Bar extends Foo {
    constructor() {
        super();
    }

    public set foobar(value: string) {
        super.foobar = `child-${value}`;
    }
}


Geo DNS Strategy

Adds a LoadBalancing section to the DNSPolcy spec allowing default weight and Geo code to be set.
LoadBalancing.Weighted.DefaultWeight is required (default 120), and if set will be used as the weight for a target clusters ednpoints if no other weight can be determined from cluster attributes.
LoadBalancing.Geo.DefaultGeo is optional, and when set indicates the default geo to use for target cluster endpoints if no other geo can be determined from cluster attributes.
The generated DNSRecord structure has been updated to accommodate Geo and Weighted only strategies using a combination of CNAMEs and A records.
see https://github.com/Kuadrant/multicluster-gateway-controller/pull/270

Is it ready for me to give a try?

Yes, this can be tested now, I'll add some notes to the description

/hold cancel
@maleck13 I'm happy that everything that needs done for this is now done. There are some improvements that can be made, but I'm going to create some follow on issues for those.


PL translation update

update 6.66 of pl translation (ok that's a joke)
but unlike this version number meaning the end of support for modern Doom games,this means i do continue updating this

im still waiting until this gets merged though


Don't try to download advice during CI runs.

When running clippy to test project specific advice do not try to download new advice on the CI build machine from https://scala-clippy.org/api/advices.

I'll take this ticket.


fix(semantic): incorrect resolve references for ExportSpecifier

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4320  👈
#4317
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


Merge master-dev branch to master

Huge changes here. Maybe merge the PR first and send PRs for new updates?

@pengzhisun are we going to merge this PR first? And I have renamed this project to container-service-for-azure-china

@feiskyer o, master-dev is the main branch now, we can go with master-dev branch from now. Just keep updating aks docs.

@pengzhisun branch master should be obsolete, right?


Adds standalone container image for v4 CLI

What does this PR do?
It adds support for a standalone cli4 container similar to conjurinc/cli5. (Instead, this one is called cyberark/conjur-cli4)
What is the context?
People doing POCs, demos, and tests for Conjur.org have enjoyed the ease of use that the conjurinc/cli5 container provides. This effort aims to provide the same for Conjur v4 (Enterprise)
Link to the build in Jenkins
https://jenkins.conjur.net/job/cyberark--conjur-cli/job/v4-standalone/

It would be nice to have an entry in the README, mentioning this new way of running the CLI. Ideally, it would have an example flow to initialize and use a .conjurrc and a .netrc entry.

Do we have an explainer elsewhere of how to set up .conjurrc and .netrc that we can link to? Otherwise I feel like the right thing to do is to create that, since it'll be useful in lots of docs.

We've got the intro to the CLI (such as it is) here: https://developer.conjur.net/cli .
The thing that's different here is that you're running in a container. So, unless you mount a directory, your configuration is going to be ephemeral.
We could suggest something like
$ docker run -it --rm -v $PWD:/root cyberark/conjur-cli conjur init


feat(router-store): Provide bindings to connect @angular/router

With the deprecation of @ngrx/router, this library will provide bindings to connect @angular/router to  @ngrx/store.
BREAKING CHANGES:
Router API has changed internally
BEFORE:
Use the routerReducer when providing Store:
import { provideStore } from '@ngrx/store';
import { routerReducer } from '@ngrx/router-store';

export const storeProvider = provideStore({
  // Your reducers go here,
  router: routerReducer
});

Install the bindings providers after you setup the router providers:
import { connectRouterToStore } from '@ngrx/router-store';

bootstrap(App, [
  storeProvider,
  provideRouter(routes),
  connectRouterToStore()
]);

AFTER:
Use the routerReducer when providing the StoreModule.provideStore and add the RouterStoreModule.connectRouter() to the @NgModule.imports:
import { StoreModule } from '@ngrx/store';
import { routerReducer, RouterStoreModule } from '@ngrx/router-store';

@NgModule({
  imports: [
    BrowserModule,
    StoreModule.provideStore({ router: routerReducer }),
    RouterStoreModule.connectRouter()
  ],
  bootstrap: [ AppComponent ]
})
export class AppModule {
}

BEFORE:
import {routerActions} from '@ngrx/store';

store.dispatch(routerActions.go('/path', 'query=string'));
store.dispatch(routerActions.replace('/path', 'query=string'));
store.dispatch(routerActions.search('query=string'));

AFTER:
import {routerActions} from '@ngrx/store';

store.dispatch(routerActions.go('/path', { query: 'string' ));
store.dispatch(routerActions.replace('/path', { query: 'string' ));
store.dispatch(routerActions.search({ query: 'string' ));

Closes #3

@MikeRyan52 ready for another review. Docs and tests have been updated.

LGTM. Will try to publish a beta tonight. Need to replace the current build infra with ngc.

Just a quick comment, but it would be very useful to store the entire router.snapshot (ActivatedRouteSnapshot) in the state as well as just the simple URL. This makes getting parameters, data, and resolves out of the router state much easier.

@mhodgson The router.snapshot has references to components, modules and many other things, so it could not serialized into json in a clean way.

Could you please drop a line here when a new package with this change is released? Or any other visible notification as well. Thanks a lot!

@BrainCrumbz It has been released as v1.0.0


[Removal]:Powerful Glass Kestrel

Hotspot Name
Powerful-Glass-Kestrel
Hotspot b58 Address
11cqiWn9aww3dv9LB1XTgAc3AhQ4AENFJkxZK2ATrdumvZVfTTZ
Discord Handle
Ashish_BGC-Fi Tech#4450
Hotspot Manufacturer
ClodPi Labs
Removal Reason
I was making some experiments with the placement & antenna options we can connect. .
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

Please help

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


npm install fails.  attempt to run fails.

Mac OS X 10.14.6
joel@simon: ~/dev/cypress/tutorials/cypress-tutorial-build-todo-starter (master) $ ls
LICENSE			db.json			package-lock.json	routes.json
webpack.config.js
README.md		json-server.json	package.json		src
joel@simon: ~/dev/cypress/tutorials/cypress-tutorial-build-todo-starter (master) $ npm install

<EMAIL_ADDRESS>install /Users/joel/dev/cypress/tutorials/cypress-tutorial-build-todo-starter/node_modules/fsevents
node install

node-pre-gyp ERR! Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v72-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v72 ABI) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Tried to download(undefined): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.1.2/fse-v1.1.2-node-v72-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v72 ABI) (falling back to source compile with node-gyp)
SOLINK_MODULE(target) Release/.node
SOLINK_MODULE(target) Release/.node
CXX(target) Release/obj.target/fse/fsevents.o
CXX(target) Release/obj.target/fse/fsevents.o
In file included from In file included from ../fsevents.cc../fsevents.cc::66:
. . . many pages of spewing later ...

<EMAIL_ADDRESS>postinstall /Users/joel/dev/cypress/tutorials/cypress-tutorial-build-todo-starter/node_modules/cypress
node index.js --exec install

Cypress 3.7.0 is installed in /Users/joel/Library/Caches/Cypress/3.7.0
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>install: node install
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1
added 868 packages from 652 contributors and audited 4779 packages in 16.568s
found 512 vulnerabilities (167 low, 15 moderate, 329 high, 1 critical)
run npm audit fix to fix them, or npm audit for details
Then, later, when I try to run it:
json-server requires at least version 4 of Node, please upgrade
[1] npm
[1] ERR! code ELIFECYCLE
[1] npm ERR! errno 1
[1] npm ERR!
[1]<EMAIL_ADDRESS>serve: json-server db.json
[1] npm ERR! Exit status 1
[1] npm ERR!
[1] npm ERR!
[1]  Failed at the<EMAIL_ADDRESS>serve script.
[1] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[1]
[1] npm
[1] ERR! A complete log of this run can be found in:
[1] npm ERR!     /Users/joel/.npm/_logs/2019-12-02T00_22_59_697Z-debug.log
but...
joel@simon: ~/dev/cypress/tutorials/cypress-tutorial-build-todo-starter (master) $ node --version
v12.12.0

Hi @joel-regen i think the issue results from the fact that the starter project was bootstrapped over 2 years ago, most of the dependencies have been upgraded. i have taken the time to update the dependencies with newer versions and this solved the problem for me. here is a snapshot of my present Package.json file. i hope this helps

you can also copy the json below and replace you dependencies and devdepenedencies section of your package.json
"dependencies": {
"axios": "^0.19.0",
"concurrently": "^5.0.2",
"json-server": "^0.15.1",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-router-dom": "^5.1.2",
"webpack-cli": "^3.3.10"
},
"devDependencies": {
"@babel/core": "^7.7.5",
"babel-loader": "^8.0.6",
"@babel/plugin-proposal-object-rest-spread": "^7.7.7",
"@babel/preset-env": "^7.7.7",
"@babel/preset-react": "^7.7.4",
"css-loader": "^3.4.1",
"cypress": "^3.8.1",
"html-webpack-plugin": "^3.2.0",
"style-loader": "^1.1.2",
"webpack": "^4.41.5"
}

this repo did not run from a direct clone.  The webserver did not start.  After running npm update, the webserver started.
Why not update packages in the repo rather than have a step not listed in the tutorial video?
I get this after running npm install
found 513 vulnerabilities (168 low, 15 moderate, 329 high, 1 critical)

I try remove package-lock.json then install and run success


Bump base image versions in Dockerfile

The current Docker image was relying on Node.js 14 and and older Debian Buster which were susceptible to multiple critical CVEs.
I have updated them to the latest stable Versions and tested them on our setup in Aachen.
There is an overview of the CVEs found by Trivy. with the new versions we could half the number of CVEs found in the image

thank you


Photoshop API page link 404

Upon clickingPhotoshop API page link in Different DOM access section, user is redirected to 404
Upon clicking this document link in What's Missing in UXP section, user is redirected to 404
Issue in /src/pages/guides/uxp_for_you/uxp_for_extendscript_devs/index.md

I found more 404 link will create single issue for all of them


处理反序列化枚举值中以 ‘"[{’等字符开头时失败导致结果为空的问题

What this PR does / why we need it?
当一个枚举值中包含带有 “[{” 的字符串时
enum class ObjectType(@JsonValue val value: String, val label: String) {
    COLLECTION("[]", "集合类型"),
    OBJECT("{}", "对象类型"),
}

反序列化会优先以字符串的方式处理，但是遇到特殊字符时，反序列化的处理的结果为空
Summary of your change

将枚举对象的反序列化提前到字符串处理之前
使枚举类型的判断中反序列化支持除int以为的更多类型

Please indicate you've done the following:

[x] Made sure tests are passing and test coverage is added if needed.
[x] Made sure commit message follow the rule of Conventional Commits specification.
[ ] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dhc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

We're currently processing your upload.  This comment will be updated when the results are available.


Longer IDs in deprecated constructs breaking existing installations

PR 315 increased the length of the id by seven characters ("-wrapped") when it launches implementation of the construct with a new name inside the shel with the old name.
Unfortunately both the shell and the internal construct can't use the same name, so we must alter the id in some way if we don't alter the actual id sent from the client. We will:

Change the added text to just "w" to reduce the number of implementations impacted
The fix for impacted implementations is to switch the new constructs. As they are functionally equivalent, this is very simple - merely npm install'ing the new construct and changing the type references in the code.

There are about 8 renamed constructs where this pattern needs to be addressed.
Reproduction Steps

See comment in PR 315
Error Log

Environment

CDK CLI Version      :
CDK Framework Version:
AWS Solutions Constructs Version     :
OS                   :
Language             :

Other

This is :bug: Bug Report

Shortening the wrapping would have worked in my case. Since it is often a good time to switch away from deprecated constructs I've switched (in my case aws-events-rule-sqs ->  aws-eventbridge-sqs) to the new constructs and that works also great as expected . Thanks

Glad to hear the transition to the new name went smoothly - we tried to ensure this but it still gives us some concern.


[chart/grafana-agent][REQUEST] support hashmod with Statefulset

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like

Add following values. Default should be hostname mode.

scrapingServiceMode:
  enabled: false

hashmod:
  enabled: false

hostname:
  enabled: true

Add Statefulset Manifest
Add PODNAME environment

            - name: PODNAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name

Add hashmod configuration in agent configs

            - action: hashmod
              source_labels: [__address__]
              modulus: {{ .Values.replicaCount }}
              target_label: __tmp_hashmod
            - action: keep
              source_labels: [__tmp_hashmod]
              regex: ^${PODNAME##*-}$ # to get index from pod name

Additional context
This is for some environments that cannot use Grafana Operator but want to use hashmod.
Should write how to configure hashmod in README file
Please let me know your opinion or better idea. I already customized it from our environment so it will be easy to add PR for me.

I still think my grafana agent chart has some merit but I really do need to update it. As such, I'm going to close this for now because option have significantly improved/changed and revisit after I complete the update.


Added before_move_page and after_move_page hooks to Editor page re-ordering (WIP)

I've been using wagtail only a tiny number of hours so I am not expecting this PR to be accepted. I add it here in case the solution is as simple as I think it might be.
Pull request https://github.com/wagtail/wagtail/pull/4924 added before_move_page and after_move_page hooks to the Editor workflow. It is my (newbie) view that these should also be called when re-ordering sibling pages, not just when moving up and down the tree. If you agree, does my PR do enough to fix the problem, please?
If what I suggest here somehow "pollutes" before_move_page and after_move_page, maybe adding something like before_reorder_page and after_reorder_page would be preferable? Advice gratefully accepted.

[x] Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
[x] Does the code comply with the style guide? (Run make lint from the Wagtail root)
[ ] For Python changes: Have you added tests to cover the new/fixed behaviour? I think existing tests already cover this. Happy to be wrong.
[ ] For front-end changes: Did you test on all of Wagtail’s supported browsers? No FE changes

Thank you for taking the time to write such a considered response.
My use case is simply to invalidate a cache item (you perhaps saw my question in the slack #support channel) and so a signal would clearly be better option for something as simple as that. I will look into how signals could be implemented here and likely open a new PR in due course. I'll leave you to close this ticket in case you want to add something new. Thanks again.

Closing this PR as @joncombe advised it can be closed, plus #5169 has since been created that supersedes this.


Show user's programming languages

Overview of user's most used programming languages, based on lines committed

This involves consuming the GitHub GraphQL API, see https://github.com/jstrieb/github-stats/blob/master/github_stats.py for an example


⚠ PrivateHD has degraded performance

In 92749db, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1987 ms

Resolved: PrivateHD performance has improved in 53cd6d0.


Created testimonial 12 white

Screenshots :

Resolves issue #1837

component smaller as in the social icons smaller?


BUG: Allow odd-length windows to be periodic ("DFT-even") too

Fixes https://github.com/scipy/scipy/issues/2190 and https://github.com/scipy/scipy/issues/4551 per the discussion on those pages.

Looks like this causes some failures
https://travis-ci.org/scipy/scipy/jobs/151387369

Yes, they're in signal.spectral.welch and signal.spectral.csd, tests created by @e-q and @ewmoore

test_integer_onesided_odd
test_real_onesided_odd
test_real_onesided_odd_32

I don't know welch/csd to know whether this is a real problem or not.  I'll try to look when I have time.

Those failing tests are tests against hardcoded values, so it doesn't surprise me that they would fail when changing the default behavior of odd length windows. I think it would be fine to either to update the hardcoded values or change these tests to explicitly use aperiodic odd length windows.

Failures look like PEP8 in test_windows.py and outdated values in a tutorial.

Yep, fixing those should make the CIs happy

Ok, fixed those.  I want to review all these PRs and finish all these things I started but I've been busy, sorry.  Feel free to fix my mistakes for me.  :D

Merging, thanks @endolith!


make bundle deprecated warnings

It requires some attention:
make bundle
...
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Hi @squakez,
May I fix this?

Thanks!


Loading Gif into memory from Web

Hi @bitbank2 thanks for providing us with an awesome library! Do you have any suggestions/examples on how I can pull down a GIF hosted from a server into memory and then pass that into the library to open() it?

What you're asking to do is pretty simple. What system do you need this to run on? I assume you're talking about ESP32. There are plenty of examples for ESP32 of downloading a file from a web server and once you have it in memory, just pass it to my library to decode. I'll ask the standard questions - what have you tried and what results did you get? The example sketches in this repo show you the code needed to decode an image from memory.

Thanks for getting back to me.
I ended up getting this to work by having the server return back a base_64 encoded gif and then using this decode library to to decode it into a C binary to then pass to the AnimatedGIF library.
https://github.com/Densaugeo/base64_arduino


socket unable to connect [err 905]

hello every one,
this is my first comment in GitHub so excuse me if I wrot in the wrong discussion or other my errors. I'm sorry for my english. I am blind so I think I could'not give you all necessary computer's output, if you need some specifics outputs could you teach me how to get them?
maybe this is the wrong discussion for this problem but I found similar issues here so I thought to write it here.
for a few months I connected my tuya devices to home assistant by local tuya personal component and them wark correctly, but at the begining of july one of them became unavailable and unreachable by local tuya and tinytuya. I surch the internet a lot but I didn't solve the problem, the device continue to be in the same status: unavailable and unreachable.
I have to say that my tuya devices are connected also with google home and alexa and them can see and control the devices, this confused me because I think that local control was harder then cloud control used by them.
when I try to do a tinytuya scan it write this:
TinyTuya (Tuya device scanner) [1.15.1]
[Loaded devices.json - 3 devices]
Scanning on UDP ports 6666 and 6667 and 7000 for devices for 18 seconds...
Scanning... | (18)
Scanning... / (17)
New Broadcast from App at <IP_ADDRESS> - {'from': 'app', 'ip': '<IP_ADDRESS>'}
Scanning... - (17)
...
Stufetta   Product ID = keyaqceqmgp343e7  [Valid Broadcast]:
Address = <IP_ADDRESS>   Device ID = bffe358be2d9b82cc9sc4o (len:22)  Local Key = redacted Version = 3.3  Type = default, MAC = 18:69:d8:90:70:a6
Status: {'1': False, '11': 0}
Scanning... - (12)
...
Scanning... | (5)
ventilatore   Product ID = keyjnuy4s3kre7m7  [Valid Broadcast]:
Address = <IP_ADDRESS>   Device ID = bfb86ec27d3bc50ee9ota1 (len:22)  Local Key = redacted Version = 3.3  Type = default, MAC = d4:a6:51:f9:e1:aa
Polling <IP_ADDRESS> Failed:
Scanning... / (4)
...
Scanning... / (0)
Scan completed in 18.0008 seconds
Scan Complete!  Found 2 devices.
Broadcasted: 2
Versions: 3.3: 2

Saving device snapshot data to snapshot.json

if I try to poll the device it respond this:
set_status() result {'Error': 'Network Error: Device Unreachable', 'Err': '905', 'Payload': None}
I found in this section of discussions this post https://github.com/jasonacox/tinytuya/issues/41, doing that advices in this post to get debugs:
here is the code: `
import tinytuya
import time
import random
tinytuya.set_debug(True)  # use tinytuya.set_debug(True,False) for non-ANSI color terminal
d = tinytuya.BulbDevice("bfb86ec27d3bc50ee9ota1", "<IP_ADDRESS>", localKey=redacted)
d.set_version(3.3)
Show status of device
data = d.status()
print('\nCurrent Status of Bulb: %r' % data)
Set to full brightness warm white
print('\nWarm White Test')
d.set_white()
time.sleep(1)
Power Control Test
print('\nPower Control Test')
print('    Turn off lamp')
d.turn_off()
time.sleep(1)
print('    Turn on lamp')
d.turn_on()
time.sleep(1)
`
I recived the output copied in this File.
debug.txt
thank everyone for the support.
I hope thes informations are sufficient, I  can give you othersif is  necessary.

Hi @LeoStrong23, have you tried removing all power from the device, waiting a few seconds, and then turning it back on?  I've seen devices get confused before and stop responding to local requests and usually a reboot fixes it.

hi @uzlonewolf, at the end I have fixed my problem. was appened that after a rutter  restart the smart switch changed his local key, so tiny tuya can't poll it using the saved local key. I tryed to lounch a new wizard to get news local key but I got a tuya server error saying that my free profile was expired, so I had to apply for an extension of the free tuya developer profile. at that moment I could run a new wizard with out errors and I saw that the local key of the device that had got problems was changed, I put all new informations into local tuya and now all work correctly. for this time I could fix it getting an extention of the tuya iot platform free profile, but I thinc that the nex time I won't apply for another extention period and I don't know how I'll can do it in a free modality.
Replying to you, I had trieh to do that you say but it not fixed anything, I even tried to delete and reconnect the device to the smart life app, but I thought that if is a problem of localkeys these solution can't work and not influence the local keys.
in any case thank you for the support and I hope that this post can help other people!

Thanks for posting this @LeoStrong23 - I suspect you will be able to get a free Tuya IOT account even in the future to get local keys, but if not, you can check out https://github.com/blakadder/tuya-uncover .

thank for the advice @jasonacox, I hope that and in case I won't be able to have a free account I'll use the tool  you suggested! thank everyone, I have had a useful beginning in the ghitHub forum!


Set seed from parent RNG

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 25 (88.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.0%) to 61.176%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/rng.jl
5
8
62.5%

Totals

Change from base Build<PHONE_NUMBER>:
1.0%

Covered Lines:
260

Relevant Lines:
425

💛  - Coveralls


Gamegenies codes for nes games on snes??

I know that it isn’t worth to convert the nes gamegenie rom into snes format since it works differently and since it also only uses letters,and since theres also no way to link it to a nes rom, but there might be a way to get around that despite the snes gamegenie does use both letters and number rather then only letters on the nes version,sothat while theres normally no way to use those codes on the snes,BUT i was thinking and do wonder what if those nes gamegenie codes can be translated into those corresponding codes for the snes version of the gamegenie sothat you can have infinitive lives or unlimited items in certain nes games on the snes because that would be awesome.
I know it’s easier said then done and it is something that should be done by a homebrewer to to translate those nes letters to those corresponding snes letters and numbers because for what i do know that for example letter Y on the nes game genie might be a mix of letter B and numer 0 on the snes game giene while letter E on nes gamegenie might be a mix of letter D and number 9 on snes gamegenie etc,,, just to make some random example guesses,but the fact is that those letters on the nes gamegenie are correspondible to those combined numbers and letters on the snes gamegenie,so it should be possible but  i can imagine that it will be a dounty task to do that but,
So while it is not your job for translating all nes gamegenie codes into snes gamegenie codes also since you are way to buzzy with nested 1,5, but i am sooo curious what you and others might think about this idea.

TL;DR. I only read the title.
Click the "Edit patches" at the top. Patches accept 3 different address formats. Use whichever one you prefer.
Here's how to decode NES Game Genie codes: https://doc.kodewerx.org/hacking_nes.html#gamegenie
The Game Genie code doesn't know the bank number but Project Nested does. An 8-character Game Genie code will contain the value expected at the given address but Project Nested doesn't. Use a hex editor like HxD to find the correct bank and that's your address. Don't forget to add 0x10 to the NES address when viewing it in a hex editor because the file contains a 16 bytes header.
You can read about mappers here: https://www.nesdev.org/wiki/Mapper
Make sure you understand how large a PRG ROM bank is for the given mapper. For example, MMC1 has 16KB banks so you'll need to make 16KB (16384 bytes) jumps in your search for the correct value.
Example: our code writes $00 to address $8123 if it's equal to $FF on MMC1 (16KB banks).

Transform our NES address to a file address (the address that you'll see on HxD). 16KB is $4000 bytes, subtract it by 1 ($3FFF) and use it as a bit mask for the address. $8123 AND $3FFF = $0123. This $0123 is going to be referred as our base address.
Add $10 to the base address because an iNES header is present. Base address is now $0133.
Read the value at each address from: Base_address + n * Bank_size (ie: $0133 + n * $4000). Where n is our attempt number. If the value matches what we're looking for ($FF in this case) then you have your address for Project Nested.

Good luck :D

Added for upcoming version. You will be able to add them where you edit patches.
The logic behind 6 character codes is very similar to how I handle patches while the 8 character codes are compatible to how I copy the PRG ROM data multiple times to fill 32KB. It didn't take long to get them working.


State Restoration doesn't work on iOS

I have a project which is a sort of demo for State Restoration. It works perfectly on Android, but doesn't work on iOS. Please let me know if there is something special that we need to do in order to run it on iOS, or am I missing something.
My code is publicly hosted here

Hi @wal33d006
Can you please provide your flutter doctor -v and update the sample, remove third-party packages from sample.
Thank you

Hi @TahaTesser
Thanks for your response, here is the updated sample repo link, I created a new branch for this.
And here is the output of flutter doctor -v
[✓] Flutter (Channel stable, 2.2.1, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 2.2.1 at /Users/waleedarshad/Developer/flutter
    • Framework revision 02c026b03c (8 weeks ago), 2021-05-27 12:24:44 -0700
    • Engine revision 0fdb562ac8
    • Dart version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/waleedarshad/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.164

• No issues found!

cc @goderbauer

Hi @wal33d006
Just tried your sample on the simulator on the latest stable channel, it is working as expected following the instructions
Preview
https://user-images.githubusercontent.com/48603081/126970019-dd1df410-01b7-4fc2-a9e2-108313df0c59.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 12.0 21A5284e darwin-x64, locale
    en-GB)
    • Flutter version 2.2.3 at /Users/tahatesser/Code/flutter_stable
    • Framework revision f4abaa0735 (4 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64
      • macOS 12.0 21A5284e darwin-x64
    • Chrome (web)           • chrome                               •
      web-javascript • Google Chrome 92.0.4515.107

• No issues found!

Can you please upgrade to the latest  stable and try again
Execute the following commands to upgrade
flutter channel stable
flutter upgrade --force
flutter doctor -v

@wal33d006 Did you follow the extra setup instructions under the "State Restoration on iOS" heading in https://master-api.flutter.dev/flutter/services/RestorationManager-class.html ?

Works like a charm now!
I missed one step with iOS, upgraded Flutter to latest. It works now.
Thanks @TahaTesser @goderbauer
Closing this now ✅


FQ: not in contains

First of all, thank you very much for this library. It was very easy to get going, and I already have tens of users (which, I find a bit humorous, but I digress).
One thing we're struggling with is to keep the complexity of the expressions down, and we're looking to use contains for wildcarding with an array to keep it nice and clean. We're using the in clause for absolute expressions, however expanding contains to in would promote that syntax greatly as opposed to the present forced boolean logic. Finally negating the clause entirely is also highly desirable for filtering down results.
Hopefully that made some sense, if not I'm happy to add additional colour.

Hi, please show an example of the expression
What about using all() predicates?

it still doesn't seem possible at this time.
name not in startsWith [ "cats", "dogs", "james" ]
nice new built-ins btw, replaces some but not all of my stuff.

[ "cats", "dogs", "james" ] | all(name not startsWith #)

You can use this instead.

nice! thank you very much


Update monocle-core, monocle-macro to 3.2.0

About this PR
📦 Updates

com.github.julien-truffaut:monocle-core
com.github.julien-truffaut:monocle-macro

from 2.1.0 to 3.2.0 ⚠
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.1.0).
You might want to review and update them manually.
project/Dependencies.scala

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.julien-truffaut" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.julien-truffaut" }
}]

labels: test-library-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

Superseded by #622.


FirebaseFirestoreSwift import issue on visionOS

Description
I'm currently using Firestore on visionOS by using a source Firestore distribution rather than the default binary distribution by running this command in the terminal to open my project open --env FIREBASE_SOURCE_FIRESTORE /path/to/project.xcodeproj
When i try to build the project i ran into import issues with FirebaseFirestoreSwift

Reproducing the issue
No response
Firebase SDK Version
10.19.1
Xcode Version
15.2
Installation Method
Swift Package Manager
Firebase Product(s)
Analytics, Authentication, Crashlytics, Firestore, Storage
Targeted Platforms
iOS, visionOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
No response
If using CocoaPods, the project's Podfile.lock
No response

Hi @michaeldadzie, could you double check that FirebaseFirestoreSwift is listed as a dependency in your target's general settings?

In any case though, because you are using 10.19.1, importing FirebaseFirestoreSwift is no longer necessary in Firebase 10.17.0+ (you'll see a warning when importing it). All of the API that used to live in the FirebaseFirestoreSwift namespace now also lives in the FirebaseFirestore namespace. So removing your FirebaseFirestoreSwift imports in favor of importing FirebaseFirestore is recommended ahead of the next breaking change.
I'd recommend trying to instead remove the problematic imports and instead import FirebaseFirestore.

Hello @ncooke3 I did remove the FirebaseFirestoreSwift imports in the project since you mentioned that all of that API now lives in FirebaseFirestore, ran into some issues with Auth and used the FirebaseAuth import instead of the regular Firebase import and i was able to build the project after making these changes. Thank you.


Lock Configuration Usage at Construction

Fixes #22578
There is a Specification available here.
Update: Public read access is still being set up for this design doc.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

@bot-gradle test this

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

Note we're in 8.1, and adding new deprecation warnings isn't an issue.  I need to update this PR to consider this next.

adding new deprecation warnings isn't an issue.

I would argue that's a point of view ;)

I would argue that's a point of view ;)

Well, "isn't as large of an issue" at least.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

I've triggered a build for you.

Pre-tested commit build failed.

There seems to be a performance regression: https://builds.gradle.org/repository/download/Gradle_Master_Check_PerformanceTestTestLinux_Trigger/60189173:id/performance-test-results.zip!/report/tests/assemble-loading-configuration-cache-state-with-cold-daemon---largeJavaMultiProjectNoBuildSrc---JavaConfigurationCachePerformanceTest.html?redirectSupported=false#result10355253

@bot-gradle test and merge

I've triggered a build for you.

Addresing performance regression here.

@bot-gradle test APT

@bot-gradle test APT

Sorry some internal error occurs, please contact the administrator @blindpirate

Sorry some internal error occurs, please contact the administrator @blindpirate


firmware: improve message when trying to switch to a not-yet-relesed business edition

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Once e.g. 23.1 comes out it will be linked to 23.4, which will obviously not be available for another 3 months. You can select the business edition but end up in a "no repository found" error.
Describe the solution you like
Be more clever about the requirement and what the latest business edition is at the moment to provide a more straightforward message about why it's not possible to switch yet.
On the other end a way to prevent mistakes with going to community version which subsequently offers an upgrade into a version that doesn't have a business version yet should be implemented, but no clear idea yet.
EDIT: Best to hide flavour and release type selection as advanced options. That concept is used all over the GUI. Also make sure "OpenSSL" doesn't have to be selected any longer for business edition. This ties into #4881 actually.
Describe alternatives you considered
Deal with this case by case. Make sure that people know a business image exist so they can reinstall even from a newer community release which is the best way to downgrade....
Additional context
N/A

Perhaps for business side clearing subscription to go to community version should make it clear that major upgrades over there bear the risk of not being able to switch back to a business edition afterwards. The message after the fact is clear now, but it might still be non-obvious to the user attempting the switch for "reasons".


initial commit for claude-light

Summary
This adds a small example ALab that uses https://claude-light.cheme.cmu.edu as a remote instrument.

Hi John! Thank you for creating the pull request! It seems there are some failed format checking. Do you mind remove the unused imports in devices/claude.py  and tasks/claude.py ? If you don't have time, I will do that after merging this pull request! Thanks again for your code!
examples/claude-light/claude_alab/devices/claude.py:1:8: F401 [*] `json` imported but unused
  |
1 | import json
  |        ^^^^ F401
2 | import requests
3 | from typing import ClassVar
  |
  = help: Remove unused import: `json`

examples/claude-light/claude_alab/tasks/claude.py:1:18: F401 [*] `bson.ObjectId` imported but unused
  |
1 | from bson import ObjectId  # type: ignore
  |                  ^^^^^^^^ F401
2 | from pydantic import BaseModel
  |
  = help: Remove unused import: `bson.ObjectId`

examples/claude-light/claude_alab/tasks/claude.py:2:[22](https://github.com/CederGroupHub/alabos/actions/runs/11246344866/job/31268030198?pr=86#step:9:23): F401 [*] `pydantic.BaseModel` imported but unused
  |
1 | from bson import ObjectId  # type: ignore
2 | from pydantic import BaseModel
  |                      ^^^^^^^^^ F401
3 |
4 | from alab_management.task_view.task import BaseTask
  |
  = help: Remove unused import: `pydantic.BaseModel`

examples/claude-light/claude_alab/tasks/claude.py:5:40: F401 [*] `claude_alab.devices.claude.ClaudeLight` imported but unused
  |
4 | from alab_management.task_view.task import BaseTask
5 | from claude_alab.devices.claude import ClaudeLight
  |                                        ^^^^^^^^^^^ F401
  |
  = help: Remove unused import: `claude_alab.devices.claude.ClaudeLight`

no problem. I did that in 18fee8f.

Thank you! Merging it right now!


Update hundred.md

FYI only. This doesn't get a lot of usage.
Updated the "Hundred Things" tutorial with the new format

Okay, no longer an FYI. I need at least one review to be able to merge.


📝 Update doc with depth estimation models, task/model parameters, and depth image example

Added additional information to the documentation regarding depth estimation models. You can now find a comprehensive list of various depth estimation models at this link.
Furthermore, added task and model parameter names to the code snippet for clarity and ease of understanding:
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large")

Additionally, included a depth image example in the documentation.
These updates provide users with more resources for exploring depth estimation models, improve the code example's readability, and visually showcase a depth estimation example.
Thanks! 🙌

@merveenoyan ,
Can you give feedback on the changes? If it's good, I'll edit other tasks as well. I want to open a separate pull request for each task.


turn off the cache for a directory

This rather is a support request. Can I disable the cache for a specific directories? Benefit is as follows. A program transmits big files over a network and stores hosts' metadata in the metadata file. It's better not to disable cache for the metadata file.

A more generic solution would be to introduce a method to either include (“whitelist”) or exclude (“blacklist”) certain glob patterns. The problem here is that the only way you can configure nocache’s behavior is by specifying environment variables, so this approach would mean you have to: think of two good variable names, parse their contents into an array or a list and then match every open() call against each expression. Feel free to implement this if you need it; I’ll take a look at it, but I currently don’t have the time to do it myself.

The problem here is that the only way you can configure nocache’s behavior is by specifying environment variables

Why so? There are commands which accept options and a command, for example, "nice", "sudo", "env", "time", "xargs".

True; but the functionality of nocache is achieved by the wrapper shell script setting the LD_PRELOAD env variable. The initializer of nocache.so is only called from the specified executable and has no access to command line arguments. See for example how the -n option is implemented.

A more generic solution would be to introduce a method to either include (“whitelist”) or exclude (“blacklist”) certain glob patterns.

A wildcard never matches the pathname separator, so how do I specify all descendants of a directory by a glob pattern?

Use fnmatch(3) without FNM_PATHNAME.
$ cat fnmatch.c
#include <fnmatch.h>
int main(int argc, char *argv[]) {
        return fnmatch("foo/*", argv[1], 0);
}
$ gcc -Wall -o fnmatch fnmatch.c
$ ./fnmatch foo/bar/baz && echo it matches
it matches

Well, I implemented this feature request in my fork. I decided to use POSIX Extended Regular Expressions because they are more straightforward and more powerful than glob patterns. What do you think?

Because the library remembers which pages (ie., 4K-blocks of the file) were already in file system cache when the file was opened, these will not be marked as "don't need", because other applications might need that, although they are not actively used (think: hot standby).

I don't understand this. Do you think that OS uses the last suggestion instead of joining suggestions from all processes?

I’ve added some comments to your commit https://github.com/beroal/nocache/commit/c3956d384d04837dc33dc1756dd7e73754aae919

Do you think that OS uses the last suggestion instead of joining suggestions from all processes?

The reality is a bit more complicated, but in principle, yes. If process A reads file X completely it’s in the FS cache; if B now maps X and does an fadvise with “don’t need” on the file descriptor, the contents are evicted from the cache; subsequent reads of A from X will require going back to the storage medium to retrieve data.
In other words: Without this mechanism, you might evict files that are in active use, thereby impacting other processes.

Regarding maybe_store_pageinfo. All my additions contain cond or pattern. I group code by keywords. Other suggestions are implemented.

Documentation. The cache is disabled for a file iff (I and not E) where I iff the file name satisfies the environment variable NOCACHE_PATTERN_INCLUDE (default: true), E iff the file name satisfies the environment variable NOCACHE_PATTERN_EXCLUDE (default: false). Both variables are treated as POSIX Extended Regular Expressions.

Yes, and you’re welcome to improve it. The code is in mm/fadvise.c. Beware though that good and robust cache invalidation is one of the harder problems in programming.

Documentation.

Can you please add command line options to the nocache shell wrapper and add documentation to the Readme?

I’d make explicit what you expect, i.e. if(regcomp(…) != NULL)

Look at the type of regcomp.

Can you please add command line options to the nocache shell wrapper and add documentation to the Readme?

Sorry, I don't know the Bash programming language and I'm happy with that. ;-)


Cannot create AKS with custom predefined VNet

Extension name (the extension in question)
aks-preview
Description of issue (in as much detail as possible)
When I am trying to create AKS with predefined custom VNet, following error is returned:
> az aks create --resource-group "wip-swarm" --name "wip-aks" --location "westeurope" --windows-admin-username "xxxxxx" --windows-admin-password "xxxxxxxx" --no-ssh-key --node-count "3" --network-plugin "azure" --kubernetes-version "1.14.0" --enable-addons "monitoring" --vnet-subnet-id "/subscriptions/c04fee73-7da3-4835-8ae1-6f373ee81794/resourceGroups/wip-swarm/providers/Microsoft.Network/virtualNetworks/wip-aks-vnet/subnets/default" --node-resource-group "wip-aks-pools" --enable-vmss --enable-cluster-autoscaler --min-count "1" --max-count "10"

WARNING: The behavior of this command has been altered by the following extension: aks-preview  AAD role propagation done[############################################]  100.0000%ERROR: Deployment failed. Correlation ID: 399ffa4a-1837-4973-a0bc-e46f93297bf1. VM has reported a failure when processing extension 'vmssCSE'. Error message: "Enable failed: failed to execute command: command terminated with exit status=50 [stdout]  [stderr] nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or
service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known nc: getaddrinfo: Name or service not known ".

Extension definition:
az extension show --name aks-preview
{
  "extensionType": "whl",
  "metadata": {
    "azext.isPreview": true,
    "azext.minCliCoreVersion": "2.0.49",
    "extensions": {
      "python.details": {
        "contacts": [
          {
            "email"<EMAIL_ADDRESS>            "name": "Microsoft Corporation",
            "role": "author"
          }
        ],
        "document_names": {
          "description": "DESCRIPTION.rst"
        },
        "project_urls": {
          "Home": "https://github.com/Azure/azure-cli-extensions/tree/master/src/aks-preview"
        }
      }
    },
    "generator": "bdist_wheel (0.30.0)",
    "license": "MIT",
    "metadata_version": "2.0",
    "name": "aks-preview",
    "summary": "Provides a preview for upcoming AKS features",
    "version": "0.4.2"
  },
  "name": "aks-preview",
  "version": "0.4.2"
}

VNet
Address space: <IP_ADDRESS>/8
Subnet: default - <IP_ADDRESS>/16
Few days ago functionality worked perfectly.

AKS

This should be supported now, if it continues to fail please open a new issue and we will take a look.


FIX: added new endpoint and handler for sql

Added new endpoint to request drillthrough for kpi sql and handler method for sql.
Corresponding issue https://github.com/intersystems-community/DeepSeeWeb/issues/291

The scope for sql injection is too large. Please rewrite to accept kpi name instead so that sql is calculated on a server.

@eduard93 I think for now we can use this solution similar to
ClassMethod WriteJSONfromMDX(MDX As %String, Timeout As %Integer = 0) As %Status
This MDX method is also can be injected.
But the main reason is how frontend works with filters.
It simply add string at the end with filters.
In SQL and MDX requests both.
And for now it cannot use filters another way.

I agree with @jakcpto . @eduard93 , WriteJSONfromMDX same inject unsafe. I suggest we implement now in "unsafe" mode, and add an issue to fix both MDX, MDXDrillthrough and SQLDrillthrough in the future.

No. MDX is "SELECT" only, limited to cubes. Plus access is still controlled by DeepSee engine/cube security. SQL offers a much larger attack vector. You can pass like this:
{
    "kpi": "kpi_name",
    "filters": [
        { "column": "abc", "operator": "EQUALS", "value": "Bob"},
        ...
    ]
}

Filters must be checked for being a valid column present in the kpi query and not a ; DROP TABLE .... Values must be passed as parameters.
Check RESTForms example.

Also added
FIX: display format data for meters in case of KPI source


Doesn't work with _app.js?

I'm exploring this further, but so far - nothing going.

please reopen with more info

Sorry about that. Confirmed here: https://github.com/morgs32/with-next-routes
Looks like url is not a prop anymore?
The two about pages don't work.


Option to normalize y-axis by current number of cases

I would like to request an option (maybe as a checkbox) to normalize the y-axis by the current number of cases.  That is to say, instead of the y-axis plotting the number of new cases in the past week, have it plot the number of new cases divided by the current number of cases.
The advantage of such a plot is that it makes it very easy to see the growth factor.  For example, a constant growth factor results in a constant horizontal line instead of a diagonal line like it is currently.
For example, below are mockups of the graph both unnormalized (like it is currently) and normalized (like I am suggesting).  (Covid Trends seems to be unable to load data at the moment, so I created these in a spreadsheet based on https://github.com/nytimes/covid-19-data/blob/master/us.csv.  Since this is just a mockup, I didn't bother with data smoothing.)
Note that the unnormalized graph makes it look like quarantine efforts have barely slowed growth at all, while the normalized graph shows that the growth rate has dropped from 20% to 3%.

I think Growth rate could be a good idea but plotted against time, rather than against Total Cases. However changing the X axis to being "days since X" would be confusing, similar to "everything else out there" and not consistent with the original view.
The original idea of plotting New Cases against Total Cases is IMO to visualise the rate of infection, and I think the growth rate you suggest isn't supposed to have any specific shape against Total Cases. therefore, comparing between countries will also be a bit of a mess...
An alternative solution to your issue of "the unnormalized graph makes it look like quarantine efforts have barely slowed growth at all", I believe, is similar to the solution proposed to the issue of the current view not being fit to show second waves of infection:
https://github.com/aatishb/covidtrends/issues/29#issuecomment-608078893
What do you think?


View FileUpload / Modeling / Text submission from Exercise Scores page

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] ~Server: I added multiple integration tests (Spring) related to the features~
[x] ~Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)~
[x] ~Server: I implemented the changes with a good performance and prevented too many database calls~
[x] ~Server: I documented the Java code using JavaDoc style.~
[x] ~Client: I added multiple integration tests (Jest) related to the features~
[x] ~Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)~
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all the newly inserted strings into German and English

Motivation and Context
This PR addresses issue #1120 which states that it is not possible to reach the submission itself for TextExercise and FileUploadExercise exercises from the scores or participations page (i.e. not reachable via any link or button, only by manually extracting the submission id and inserting it into a url pattern in the browser url bar). For programming exercises this is possible by clicking on the "Repository" button or link.
Description

Add button "Download file" to scores page for FileUploadExercise (opens the uploaded file of the latest submission in a new browser tab or downloads it, depending on the browser)
Add button "View Text Submission" to scores page for TextExercise (opens the assessment page for the latest text submission)
Add button "View Modeling Submission" to scores page for ModelingExercise (opens the assessment page for the latest modeling submission)

Steps for Testing

Log in to Artemis
Navigate to Course Administration
Click on "Exercises" for a course with a file upload, modeling and text exercise
Click on "Scores" for a file upload, modeling and text exercise
Check that the new button (either "Download file" or "View Text Submission" or "View Modeling Submission") is present and performs its function as described above

Screenshots

Thanks, I don't have any real issues. We might want to also open the assessment page for the file upload exercise in addition to downloading the file, just to be consistent with the other types. What do you think?

I thought about that as well and wasn't sure. It would be good for consistency but would increase the number of clicks needed to see the actual submission content by one. Let's maybe see what the other reviewers think.

During testing I noticed that for the case of Text exercises, after you click on "View Text Submission" the Back button is visible on the Assessment page:

If you click on it you are directed to the Tutor Dashboard of that exercise. I think thats pretty confusing and the Back button should be not visible, as it is on the Modeling Assessment page. Or is there any reason for it to be visible on the Text assessment, but not on the Modeling assessment page?
Everything else works as expected!

During testing I noticed that for the case of Text exercises, after you click on "View Text Submission" the Back button is visible on the Assessment page:

If you click on it you are directed to the Tutor Dashboard of that exercise. I think thats pretty confusing and the Back button should be not visible, as it is on the Modeling Assessment page. Or is there any reason for it to be visible on the Text assessment, but not on the Modeling assessment page?
Everything else works as expected!

We have the same behavior for other components. It's not pretty, but also nothing that got introduced with this PR. We already talked about this once (couple of weeks ago) if I remember correctly and were discussing whether we should remove this back button altogether.

We have the same behavior for other components. It's not pretty, but also nothing that got introduced with this PR. We already talked about this once (couple of weeks ago) if I remember correctly and were discussing whether we should remove this back button altogether.

Okay, makes sense, not in the scope of this PR then.

During testing I noticed that for the case of Text exercises, after you click on "View Text Submission" the Back button is visible on the Assessment page:

If you click on it you are directed to the Tutor Dashboard of that exercise. I think thats pretty confusing and the Back button should be not visible, as it is on the Modeling Assessment page. Or is there any reason for it to be visible on the Text assessment, but not on the Modeling assessment page?
Everything else works as expected!

Thanks for the feedback! Yes, the back button does unfortunately behave strangely in this case. For modeling exercise submissions a query param hideBackButton can be specified to achieve the desired behavior but this is the only exercise type where this is currently supported as far as I know.
As @ungaralex said, this can be tackled in another PR (either by removing the back button all together or making it optional when using the respective components).

Looks good to me! Maybe just update your PR description as it says now "view submission" for all exercise types

Thanks, I updated the description and added a note above the screenshots.

Nice work! Except for the weird back button behavior, I did not find problems.
I would suggest that we refactor and do not remove the back button functionality, but this is a discussion for another issue.

Thanks! Yes, we should discuss that in the corresponding issue.


Don't publish npm-shrinkwrap.json.

It's strongly discouraged for libraries and it looks like it forces dependents packages to install our own devDependencies

Coverage remained the same at 95.067% when pulling 395aadaafd963596e2ddbe9d15bab6719cba235b on bug/published-shrinkwrap into 6f3f29fc91f8b65ad49b18f7b51cf821c05a08e1 on develop.

Coverage remained the same at 95.067% when pulling 395aadaafd963596e2ddbe9d15bab6719cba235b on bug/published-shrinkwrap into 6f3f29fc91f8b65ad49b18f7b51cf821c05a08e1 on develop.


Look into improving the 'when called with' error message

expect(function add(a, b) {return a + b;}, 'when called with', [5, 8], 'to equal', 12);

The above produces this error:
expected function add(a, b) {return a + b;} when called with [ 5, 8 ] to equal 12

@gustavnikolaj remarked that it would be nice if the error could include the fact that add(5, 8) is 13, something like:
expected function add(a, b) {return a + b;} when called with [ 5, 8 ] to equal 12, but it was 13

It might be tricky to pull this off because when called with just computes the result, then delegates to another assertion.
On the other hand, it would be easier to get this by splicing this.args:
expected function add(a, b) {return a + b;} when called with [ 5, 8 ] (= 13) to equal 12, but it was 13

For strings etc. it's not as big a problem because you get a diff:
expect(function add(a, b) {return a + b;}, 'when called with', ['abc', 'def'], 'to equal', 'bcde');

expected function add(a, b) {return a + b;} when called with [ 'abc', 'def' ] to equal 'bcde'

-abcdef
+bcde

In my opinion it'd still be nice to have the result inspected separately, though.

Fixed by #102


Android devices being disconnected.

The LuCi inteno(client) constantly disconnects android devices, have tried on sony xperia z2, LG G5(H850), and several others, if it's android, your connection does not last long until disconnect.
Powered by LuCi Trunk (inteno-1.1.19) and Barrier Breaker (r45951)

LuCI has no role in Wifi connectivity. It is only a GUI. All wifi connectivity is handled by the core Openwrt.
Additionally, inteno-1.1.19 sounds quite strange.
Ps. Barrier Breaker is not actively supported any more. You should use Chaos Calmer 15.05.1 (or newer).


Bug Fix: UI layout changes as you switch between tabs

Resolves https://github.com/OpenDevin/OpenDevin/issues/52

Thanks!

Nice, thanks @yimothysu! 👏


Make EntityNotFoundException extend GraphQLException

Actually we need to think about this since this is only used in the New Relic middleware. It might make sense to make the list of exceptions not to report explicit (i.e. a constructor parameter), that way we could remove this exception completely (it's a relic from the project we factored this out from).


	} ()
}

Please be more explicit with your issue reports. I have no idea what you're getting at.

I think he meant that vet should check for this error:
https://golang.org/doc/faq#closures_and_goroutines