TSan failure in TaskWaitTest.IssueTimeout

I'm seeing what I think is a flaky TSan failure in TaskWaitTest.IssueTimeout. This is in testing a new runner configuration, so I suppose it's possible that this is somehow caused by being run on a tmpfs, but that doesn't seem likely
2022-09-08T17:52:44.5302912Z [ RUN      ] TaskWaitTest.IssueTimeout
2022-09-08T17:52:44.5303215Z ThreadSanitizer:DEADLYSIGNAL
2022-09-08T17:52:44.5303642Z ==150956==ERROR: ThreadSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000002e99b2 bp 0x00008000021f sp 0x7ffe13c500c0 T150956)
2022-09-08T17:52:44.5304049Z ==150956==The signal is caused by a WRITE memory access.
2022-09-08T17:52:44.5304382Z ==150956==Hint: address points to the zero page.
2022-09-08T17:52:44.5322270Z     #0 __tsan::MetaMap::GetAndLock(__tsan::ThreadState*, unsigned long, unsigned long, bool, bool) <null> (task_tests+0x2e99b1)
2022-09-08T17:52:44.5322760Z     #1 __tsan_atomic32_fetch_sub <null> (task_tests+0x2c84bd)
2022-09-08T17:52:44.5323161Z     #2 iree_task_executor_release /work/runtime/src/iree/task/executor.c:224:19 (task_tests+0x322994)
2022-09-08T17:52:44.5323653Z     #3 TaskTest::TearDown() /work/runtime/src/iree/task/testing/task_test.h:40:5 (task_tests+0x310e68)
2022-09-08T17:52:44.5324355Z     #4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /work/third_party/googletest/googletest/src/gtest.cc:2607:10 (task_tests+0x37a48c)
2022-09-08T17:52:44.5325356Z     #5 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /work/third_party/googletest/googletest/src/gtest.cc:2643:14 (task_tests+0x37a48c)
2022-09-08T17:52:44.5326024Z     #6 testing::Test::Run() /work/third_party/googletest/googletest/src/gtest.cc:2690:3 (task_tests+0x3404ca)
2022-09-08T17:52:44.5326502Z     #7 testing::TestInfo::Run() /work/third_party/googletest/googletest/src/gtest.cc:2861:11 (task_tests+0x34202a)
2022-09-08T17:52:44.5327011Z     #8 testing::TestSuite::Run() /work/third_party/googletest/googletest/src/gtest.cc:3015:28 (task_tests+0x342f16)
2022-09-08T17:52:44.5327556Z     #9 testing::internal::UnitTestImpl::RunAllTests() /work/third_party/googletest/googletest/src/gtest.cc:5855:44 (task_tests+0x35b84b)
2022-09-08T17:52:44.5328362Z     #10 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /work/third_party/googletest/googletest/src/gtest.cc:2607:10 (task_tests+0x37b4bc)
2022-09-08T17:52:44.5329362Z     #11 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /work/third_party/googletest/googletest/src/gtest.cc:2643:14 (task_tests+0x37b4bc)
2022-09-08T17:52:44.5330098Z     #12 testing::UnitTest::Run() /work/third_party/googletest/googletest/src/gtest.cc:5438:10 (task_tests+0x35aee0)
2022-09-08T17:52:44.5330576Z     #13 RUN_ALL_TESTS() /work/third_party/googletest/googletest/include/gtest/gtest.h:2490:46 (task_tests+0x329fdb)
2022-09-08T17:52:44.5331107Z     #14 main /work/runtime/src/iree/testing/gtest_main.cc:17:10 (task_tests+0x329fdb)
2022-09-08T17:52:44.5331482Z     #15 __libc_start_main <null> (libc.so.6+0x21c86)
2022-09-08T17:52:44.5331861Z     #16 _start <null> (task_tests+0x274029)
2022-09-08T17:52:44.5332025Z
2022-09-08T17:52:44.5332191Z ThreadSanitizer can not provide additional info.
2022-09-08T17:52:44.5333177Z SUMMARY: ThreadSanitizer: SEGV (/work/build-tsan/runtime/src/iree/task/task_tests+0x2e99b1) in __tsan::MetaMap::GetAndLock(__tsan::ThreadState*, unsigned long, unsigned long, bool, bool)
2022-09-08T17:52:44.5333650Z ==150956==ABORTING

From https://github.com/iree-org/iree/runs/8254955976

Interesting! Note, even though it happens to be reported by TSan, it's a plain null-deref crash (SEGV on unknown address 0x000000000000) not (a priori) a threading-related issue --- in other words, for all we know at this point, this looks like a general crash that might as well have occured in any non-TSan config.

Stack frame 2 is: https://github.com/iree-org/iree/blob/90bed7e145d7edf8496ba79745989a76ffe0443a/runtime/src/iree/task/executor.c#L224
But stack frame 1 says that iree_atomic_ref_count_dec was given a null pointer - meaning that executor->ref_count is NULL. A look at executor_impl.h shows that ref_count is at offset 0 in executor so that's equivalent to saying that executor is NULL.
But the code at stack frame 2 is checking that executor is not NULL before proceeding:
if (executor && iree_atomic_ref_count_dec(&executor->ref_count) == 1) {

So how can this null deref happen? One can guess that some other thread wrote NULL to executor after the first part of the above if and before the second part. In normal (non-TSan), optimized code, that would never happen, because the pointer value executor would be read once from memory into a register used by both parts of that if condition, so any data race would be papered over. I guess that the way that TSan helps uncover the issue here is that it prevents optimizing away memory accesses, allowing for the two parts of that if to get inconsistent values for executor.
If that theory is correct, TSan should have reported a data race on executor instead of continuing into the null deref.  (I checked the full log, it really didn't catch the data race per se). Don't know why it didn't, but TSan is notoriously a "best effort" sanitizer. Good, anyway, that it allowed the data race to cause inconsistent accesses, allowing us to catch the bug nonetheless.

I feel like this might be the same crash I had a few days ago (and I didn't have time to report yet...)
https://github.com/iree-org/iree/runs/8106730809
[ RUN      ] TaskWaitTest.WaitAllTimeout
ThreadSanitizer:DEADLYSIGNAL
==114970==ERROR: ThreadSanitizer: SEGV on unknown address 0x60225fed0000 (pc 0x0000002d35b8 bp 0x60225fed0000 sp 0x7ffe615f60b0 T114970)
==114970==The signal is caused by a WRITE memory access.
    #0 __tsan::Mutex::ReadLock() <null> (task_tests+0x2d35b7)
    #1 __tsan::RestoreStack(int, unsigned long long, __tsan::VarSizeStackTrace*, __tsan::MutexSet*, unsigned long*) <null> (task_tests+0x2e506f)
    #2 __tsan::ReportRace(__tsan::ThreadState*) <null> (task_tests+0x2e6409)
    #3 <null> <null> (task_tests+0x2eb459)
    #4 __tsan_write8 <null> (task_tests+0x2dc373)
    #5 iree_task_list_pop_front /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/list.c:82:19 (task_tests+0x3233e7)
    #6 iree_task_list_discard /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/list.c:32:25 (task_tests+0x3233e7)
    #7 iree_task_poller_deinitialize /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/poller.c:146:3 (task_tests+0x3245d2)
    #8 iree_task_executor_destroy /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/executor.c:206:3 (task_tests+0x322814)
    #9 iree_task_executor_release /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/executor.c:225:5 (task_tests+0x3228f1)
    #10 TaskTest::TearDown() /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/task/testing/task_test.h:39:5 (task_tests+0x310e48)
    #11 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2607:10 (task_tests+0x37a1fc)
    #12 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2643:14 (task_tests+0x37a1fc)
    #13 testing::Test::Run() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2690:3 (task_tests+0x34023a)
    #14 testing::TestInfo::Run() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2861:11 (task_tests+0x341d9a)
    #15 testing::TestSuite::Run() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:3015:28 (task_tests+0x342c86)
    #16 testing::internal::UnitTestImpl::RunAllTests() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:5855:44 (task_tests+0x35b5bb)
    #17 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2607:10 (task_tests+0x37b22c)
    #18 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:2643:14 (task_tests+0x37b22c)
    #19 testing::UnitTest::Run() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/src/gtest.cc:5438:10 (task_tests+0x35ac50)
    #20 RUN_ALL_TESTS() /home/runner/actions-runner/_work/iree/iree/third_party/googletest/googletest/include/gtest/gtest.h:2490:46 (task_tests+0x32a03b)
    #21 main /home/runner/actions-runner/_work/iree/iree/runtime/src/iree/testing/gtest_main.cc:17:10 (task_tests+0x32a03b)
    #22 __libc_start_main <null> (libc.so.6+0x21c86)
    #23 _start <null> (task_tests+0x274029)

ThreadSanitizer can not provide additional info.
SUMMARY: ThreadSanitizer: SEGV (/home/runner/actions-runner/_work/iree/iree/build-tsan/runtime/src/iree/task/task_tests+0x2d35b7) in __tsan::Mutex::ReadLock()
==114970==ABORTING

Thanks @pzread , that's great additional context to have to try to make sense of that.

Note: both of your above logs show that this is only hit in the second part of the TSan tests where we rerun only iree/base and iree/task tests 32 times to catch flaky tests (#10132). So this is showing this to be catching bugs in practice -- good!

@GMNGeoffrey @pzread have you encountered this failure again since Sep 22 (merging of the above tentative fix) ?

I'd be very curious!

Just FYI, not sure if it's related, but I encountered an ASan failure in task tests #11317 last week.

I'm still curious. Is it feasible to check past actions to investigate this? I remember playing with the script you had shared and coming away from it with an impression that GitHub didn't expose the structured CI data that I needed to answer a question like "did TSan CI failure rate or noisiness change significantly at this point in the past" let alone something per stack trace filter. Do you see a way? @GMNGeoffrey  . Else, we might as well close this.

Nothing very sophisticated. You could find failed tsan jobs and look at the rate of that. YOu could also fetch the logs, and grep them for the relevant failure message. Not necessarily worth it though


Browser support?

Do you plan to generate a javascript bundle distribution file to embed without the need to compile it?  Thanks, cool project.

Do you plan to generate a javascript bundle distribution file to embed without the need to compile it? Thanks, cool project.

sorry, this component based on vue.


guarded relevance test

Do not merge, but here's a first cut at guarded relevance for testing

It might not be complete, but this looks quite good. Going to merge it in.


Docs: Improve guidance to developers on reflecting record failures

What were you searching in the docs?
I was specifically looking for guidance in the docs on what the record_handler function should return to reflect a record (batch item) could not be handled successfully.
Is this related to an existing documentation section?
https://docs.powertools.aws.dev/lambda/python/latest/utilities/batch/#partial-failure-mechanics
How can we improve?
My recommendation is to specifically state that developers should raise an Exception (in python, for example) for any record that could not be processed successfully, and explicitly state the the "partial_process_response" object will handle any exceptions thrown by the record handler.
By looking at the "sample response" section, it implies that the "batchItemFailures" dictionary is returned, but it doesn't explicitly state how that response gets generated and what is required of the developer.
Got a suggestion in mind?
Responsibility of the developer/engineer implementing the record_handler method:

Allow Exceptions to be propagated to the partial_process_response object, and/or
Explicitly raise an Exception in the record handler

Either way, an Exception is used to notify the partial_process_response object that record handling was not successful.
From that point forward, the partial_process_response object will take care of formatting the "batchItemFailures" dictionary back to SQS.
Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

Thank you so much for taking the time to report on Discord and create a beautifully detailed issue @94Sip - we'll ping once we have a draft for review.
Thanks!

Took the liberty to improve other areas in the Batch documentation (diagrams!!), so I'll send the complete PR tomorrow.
Here's the initial draft for this specific section. I used code annotations (works on mobile too) to hide details of exception propagation besides what's written upfront. I'll also create a sequence diagram under Mechanics section to it can be referenced to more easily (like Idempotency).

PR is now up with all changes: https://github.com/aws-powertools/powertools-lambda-python/pull/2857

Closing manually as automation seems to have failed upon release: https://docs.powertools.aws.dev/lambda/python/latest/utilities/batch/#error-handling


ngRepeat

Is it possible to use ng-repeat to define an array of sliders all together using ngRepeat?
http://jsfiddle.net/eb548nyw/

Yes

Thanks for your kind reply, would you please show me with example or kindly update this:
http://jsfiddle.net/eb548nyw/

Sorry for not being funny but your slider doesn't show much and is bit even valid JavaScript I think (I'm on the phone right now so can't look at the console...)
Then using in ng-repeat is definitely possible but depends on what you are trying to achieve. If you want dynamic model values or options or both...

Sorry for ambiguity, and thanks for your help, kindly find an updated version:
http://jsfiddle.net/eb548nyw/4/
I would like to have both values and options changing dynamically.

The way you instantiate your sliders is correct but your data structure isn't. You should start by simply du

The simple ones are working fine with me, only the ones with ngRepeat that have the problem.

Yes but from what I can see , you are not using ng-repeat correctly: in your dictionary, you have twice the same key.
You rather use an array like:
[
{value:50, options: {floor: 0, ceil:100}},
{value:100, options: {floor: 0, ceil:200}}
]

Sorry for that, kindly review this:
http://jsfiddle.net/eb548nyw/8/

Got it to work, thanks:
http://jsfiddle.net/eb548nyw/9/


fix(widget-v2):  skip showing drawer for fast wallet connecting

Need a review by @Ikari-Shinji-re


Allow placing animation sets in a different file

Make it possible to place all the animations in a separate file and that each animation worked separately, the sections in the headers and footers used for the lines (not for animation). Because prescribe everything at once in one place it is unrealistically difficult to do and think through all the animations ahead of a huge text.
config.yml
headers:
  default:
    - "%animation:Welcome%"

footers:
  default:
    - "%animation:MyAnimation1%"

animations.yml
Welcome:
  change-interval: 400
  texts:
  - '&7&lW_'
  - '&7&lW_'
  - '&7&lWe_'
  - '&7&lWel_'
  - '&7&lWelc_'
  - '&7&lWelco_'
  - '&7&lWelcom_'
  - '&7&lWelcome_'
  - '&7&lWelcome_'
  - '&7&lWelcome_'
  - '&7&lWelcome_'
  - '&7&lWelcom_'
  - '&7&lWelco_'
  - '&7&lWelc_'
  - '&7&lWel_'
  - '&7&lWe_'
  - '&7&lW_'
  - '&7&lW_'
MyAnimation1:
  change-interval: 100
  texts:
    - '&d-&3--------------'
    - '&3-&d-&3-------------'
    - '&3--&d-&3------------'
    - '&3---&d-&3-----------'
    - '&3----&d-&3----------'
    - '&3-----&d-&3---------'
    - '&3------&d-&3--------'
    - '&3-------&d-&3-------'
    - '&3--------&d-&3------'
    - '&3---------&d-&3-----'
    - '&3----------&d-&3----'
    - '&3-----------&d-&3---'
    - '&3------------&d-&3--'
    - '&3-------------&d-&3-'
    - '&3--------------&d-'
    - '&3-------------&d-&3-'
    - '&3------------&d-&3--'
    - '&3-----------&d-&3---'
    - '&3----------&d-&3----'
    - '&3---------&d-&3-----'
    - '&3--------&d-&3------'
    - '&3-------&d-&3-------'
    - '&3------&d-&3--------'
    - '&3-----&d-&3---------'
    - '&3----&d-&3----------'
    - '&3---&d-&3-----------'
    - '&3--&d-&3------------'
    - '&3-&d-&3-------------'
    - '&d-&3--------------'

While not exactly as requested, Velocitab 1.6 moves TAB list groups into their own file - so I'm considering this request solved :)


Changes to HoloToolkit menu for setting project / scene defaults

Create a log of changes to display to user. Allow other menu options to
add to scene or project to use these new changes. Add additional checks
for unchecked/missing holographic options using API (rather than file
processing). Don't reload for quality level changes (Unity picks up
change in file).  Don't set quality if the option is already set
(therefore don't reload when not necessary)

Hi @adamtuliper, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

Really glad to see that Unity is adding an API to enable VR support for individual platforms! I think this part of the change is awesome! I also like avoiding the reload in any cases that were unnecessary.
Looking through most of the changes though I'm a little concerned we're adding a lot of code and branching for not much gain - what if we just always applied the changes and printed what we did to the console? I think it'd help to keep this code a lot simpler, but still add some nice output.
In general the flow for changes should be to create an issue, discuss a solution, make the changes, create a pull request. In this case I'm unsure of what specific issues you were trying to solve with the output changes.

The project changes are a black box. Most developers I've encountered on
this have no idea what the changes are. This tells them exactly what
changes and tells what's been updated in the project (as I've also seen
folks fix their projects with this same code base I've tested in the field
at the recent HoloLens hackathons). I'm a fan of telling the user what's
been changed. Sure, console output is great as it outlives a dialog, but I
think the dialog is important.
The issues this solves are

Existing black box behavior - telling the user exactly what has changed
in their project. Great when you've altered a single setting in your
project too and this tells you what was fixed. Helps prevent you making
this change in the future (as now you know what happened)
Limits project reload for the VR support and Quality.
Detects scenario when Windows Holographic isn't present (you could have
checked or VR Supported and Windows Holographic is removed - saw this
happen once in the field as well).
Applying all changes at once

On Sun, Jul 24, 2016 at 11:45 AM, Josh Wittner<EMAIL_ADDRESS>wrote:

Really glad to see that Unity is adding an API to enable VR support for
individual platforms! I think this part of the change is awesome! I also
like avoiding the reload in any cases that were unnecessary.
Looking through most of the changes though I'm a little concerned we're
adding a lot of code and branching for not much gain - what if we just
always applied the changes and printed what we did to the console? I think
it'd help to keep this code a lot simpler, but still add some nice output.
In general the flow for changes should be to create an issue, discuss a
solution, make the changes, create a pull request. In this case I'm unsure
of what specific issues you were trying to solve with the output changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/HoloToolkit-Unity/pull/134#issuecomment-234794362,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABqPDfs7whn8whtBAH6JrCBWulU6XEw_ks5qY7KxgaJpZM4JTeQs
.

I like informing them about the changes, but I don't like complicating the code with string building and lots of branches to do so. The console seems like an adequate solution and keeps the code significantly cleaner and easier to maintain.
I'm a big fan of the fact that your code is solving 2 and 3 above! If that's all it was doing, this code would have probably breezed through the PR process. I'm hoping you might break this down into multiple PRs solving the individual problems so that the hyper valuable pieces can get in sooner and not be bogged down with comments/concerns on the logging, cameras, and unified application changes.

Please make smaller PRs addressing each concern separately. Definitely recommend making some issues with the current behavior.


unable to parse AndroidManifest having unicode characters

If the AndroidManifest file is not properly formed and cannot be parsed; (but the apk is generated), the exception is raised. Need to handle such errors.
self.xml[i] = minidom.parseString((self.axml[i].get_buff())) <-- exception in this line
app to test : https://play.google.com/store/apps/details?id=com.jpmorgan
Below is the stacktrace:
Error
Traceback (most recent call last):
File "/Users/ranjeet/Downloads/DT_home/DT_projects/androguard/tests/test_apk.py", line 18, in testAPK
1)
File "/Users/ranjeet/Downloads/DT_home/DT_projects/androguard/androguard/core/bytecodes/apk.py", line 204, in init
self.xml[i] = minidom.parseString((self.axml[i].get_buff()))
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/minidom.py", line 1928, in parseString
return expatbuilder.parseString(string)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/expatbuilder.py", line 940, in parseString
return builder.parseString(string)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/expatbuilder.py", line 223, in parseString
parser.Parse(string, True)
ExpatError: not well-formed (invalid token): line 52, column 0

See #140 for a solution

Or better, #148

understood, on further analysis, I found that there are some apks for which the AndroidManifest file is not properly formatted i.e. it cannot be parsed using xml parsers but still the apk is generated. One such app is  https://play.google.com/store/apps/details?id=com.jpmorgan. So, an exception is raised and APK object is not initialised.

I can't check it currently, but it may be something I fixed in a pull request https://github.com/androguard/androguard/pull/155

Something similar issue I am getting it for below app as well
[https://play.google.com/store/apps/details?id=com.nanoo.darksword&hl=en]
The AndroidManifest.xml is not getting parsed using minidom parser. However, if I use lxml it works perfectly fine. Please have a look.

@ranjeetsinha13 this manifest is especially nasty... It uses an empty namespace, which gives me an error when using lxml:
In [25]: etree.fromstring(axml.get_buff())
  File "<string>", line 3
XMLSyntaxError: xmlns:Liapp_Empty_00: Empty XML namespace is not allowed, line 3, column 24

how did you opended it? Did you applied the patches in the PR's?
there are now several PR's for the same thing:
#155 #159 so we need to really consolidate things there...

@reox will try to test this out

Run into this issue now again.
It looks like the Liapp Packer uses an empty namespace to fool XML parsers.
The AXML file iteself is read fine.
But the attribute of the Namespace tag resolves to an empty string... I'm not sure how to deal with that. We could just add a fake URI, so the parser is happy.

Please reopen new tickets if something fails with the AXML Parser, so we can keep track of it more easily.


Can't access Discord server

When creating a new GitHub issue your Community Chat link takes me to https://discord.gg/2K7RXHm but that link seems to be broken: Discord tells me This invite may be expired, or you might not have permission to join..

Fixed! https://discord.gg/WrRKjPJ
On Jun 17, 2020, 2:50 AM -0600, Romuald Brillout<EMAIL_ADDRESS>wrote:

When creating a new GitHub issue your Community Chat link takes me to https://discord.gg/2K7RXHm but that link seems to be broken: Discord tells me This invite may be expired, or you might not have permission to join..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

:tada: This issue has been resolved in version 7.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: support Lake for building Lean core oleans

This is from a pairtriple programming session with @tydeu and @mhuisi.
It does not yet allow Lake to be used to build the Lean binaries, but it will allow Lake to be used for working interactively with the Lean source. In our preliminary experiments, this allowed updates to Init.Data.Nat to be noticed automatically when reloading downstream files, rather than requiring a full manual compiler rebuild. This will make it easier to work on the system.
As part of this change, Lake is added to stage 0. This allows Lake to function in src, which uses the stage 0 toolchain.

The lakefile.toml will have to be generated by CMake to correctly heed LEAN_MAKE_OPTS/LEANC_OPTS/...

@Kha Right now, this is just for interactive editing, not for building the binaries or shared libraries, so we do not need those options at the moment.

Okay, I would not have expected that to be a desirable intermediate state if it forces me to redo the build in cmake whenever I want to actually run and test Lean. It also begs the question of how to opt into the current workflow when the lakefile.toml always exists.

@Kha

Okay, I would not have expected that to be a desirable intermediate state if it forces me to redo the build in cmake whenever I want to actually run and test Lean.

While it does require an additional run of CMake to run/test Lean, it does not require redoing work, as make can successfully make use of elaboration results (as there are no relevant LEAN_OPTS to standard dev builds).

I am flummoxed by the linker errors in the CMake build of stage0 Lake. It builds successfully on my machine.

I added a -DUSE_LAKE=ON CMake flag to opt into the new behavior and to fix the hard-coded path so if that looks good and the stage0 update is removed to be redone on master, I think this PR is ready to be merged.
It wasn't clear to me why the additional lakefile.tomls in the root and in tests/ are necessary, so I've removed them for now.

@Kha

It wasn't clear to me why the additional lakefile.tomls in the root and in tests/ are necessary, so I've removed them for now.

They are necessary for the multiple roots of the VS Code workspace. Each root needs to have a lakefile for the server to make use of Lake at that root. Without them, Lake will not be used for Lean files in the root (outside src/) or in tests/.

@Kha

Why is that relevant? tests/ is not a Lake project, even running the full build from src/ in it does not help as it will not actually build the executables.

It is not for building. It is for interactively editing the tests using the modules built from src.

!bench

@Kha What are you attempting to benchmark? Without the stage0 update, this PR has no actual effect.

@tydeu The update-stage0 size increase but I noticed we don't actually have a benchmark for that :) . Do you know how much it was?


Default Shortcuts remaping

Description of the new feature / enhancement
For people who has to work with other languages keyboards It will be very nice to have an option to get all default shortcuts remaped in batch to english shortcuts instead of the localized ones. Also in reverse.
I'm used to English shortcuts and when I need to use the Spanish keyboard it is a real mesh as the English shortcuts don't work
Scenario when this would be used?
When you need to use different languages keyboards.
Supporting information
No response

Please:

Indicate an affected version
Provide an example of what you want
Title this ticket as an issue report


Add props to the pool world

This straightforward pull request imports props and places them in the pool. Feedback on the folder structure etc. is welcomed

Commits properly squashed and merged :D


Element.dataset allows wrong names

According to the Element.dataset documentation

Allows access to all custom data attributes (data-*) set on this element.
The keys for the map must follow these rules:
The name must not begin with 'xml'.
The name cannot contain a semi-colon (';').
The name cannot contain any capital letters.
Any keys from markup will be converted to camel-cased keys in the map.
For example, HTML specified as:

Would be accessed in Dart as:
var value = element.dataset['myRandomValue'];

But, in fact, name xml is allowed
import "dart:html";

class NullTreeSanitizer implements NodeTreeSanitizer {
  void sanitizeTree(Node node) {}
}
main() {
  var x = new Element.html('

',
      treeSanitizer: new NullTreeSanitizer());
  print(x.dataset); // {xml: 0}
}

Tested with
Chrome 84.0.4147.135
Dart SDK version: 2.10.0-59.0.dev (dev) (Tue Aug 25 18:05:44 2020 -0700) on "windows_x64"

Updated the documentation to match the MDN Element.dataset documentation, removing the strict requirement on disallowing xml in the name for the property keys. It's still probably recommended not to have xml in the name since that is a requirement for the HTML attributes, so I left a link to the MDN data-* documentation with those restrictions in the "See also" section.


Add screenshot

Hi @nobbynguyen , could you move the first screenshot under S3 bucket towards the end of notebook? When we save the csv file using python, after that?
Also, one more change, in the first set of screenshots, IP addresses are visible for Cici, Gautham and yours, in the instance screenshot, could you hide/mask them? As in the instructions, it is mentioned that no IP should be visible.

Gotcha and fixed.

@nobbynguyen  for question 2, we have to add all our screenshots. Only for question 1, it's ok to have one I think.


Drop remaining 5.9 support.

This PR updates the package manifest to require Swift 5.10 or newer. We previously had a tools version of 5.9 so that content from the package would be indexed by Swift Package Index, but they have updated their systems to use 5.10 so this is no longer required.
As a reminder, Swift 5.10 support is temporary for the benefit of developers who cannot rely on a nightly main-branch toolchain. Swift 5.10 support will be removed in a future update.
Checklist:

[ ] Code and documentation should follow the style of the Style Guide.
[ ] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


allow to add space between radio buttons

add CustomListViewSpacing.dart so we can add custom space between radio buttons, change Column to ListView in example app to avoid OVERFLOWED Widgets

@devomar615  Nice work and thanks, I'll publish this, after testing it


Reference: information about AWS clusters without cost attribution enabled.

The following clusters were created without 2i2c.org/cluster-name tag applied to node groups, or other less relevant resources like EKS plugins.

[x] catalystproject-africa
[x] earthscope
[x] gridsst
[x] jupyter-health
[x] jupyter-meets-the-earth
[x] kitware
[x] nasa-cryo
[x] nasa-ghg
[x] nasa-veda
[x] openscapes
[x] opensci
[x] projectpythia
[x] smithsonian
[x] ubc-eoas
[x] victor

This issue is referenced by documentation being written in #4873, where we can check off clusters over time, and should be able to close with the completion of #4878.

While doing #4878 @consideRatio and I discovered that clusters running on k8s 1.29 don't have the 2i2c.org/cluster-name applied to nodegroups, so they qualified for recreating their nodegroups in order for the tag to be picked up (per step 3 of https://infrastructure.2i2c.org/howto/cost-attribution/aws/#practical-steps).
However, k8s 1.29 does set other tags that are also being picked up by our cost allocation dashboard, namely alpha.eksctl.io/cluster-name and kubernetes.io/cluster/{CLUSTER_NAME}
https://github.com/2i2c-org/infrastructure/blob/2aa8c917fd399733b042928418b394a22a340c6a/helm-charts/aws-ce-grafana-backend/mounted-files/const.py#L54-L75
This means that the nodegroups weren't recreated this time, so they don't have the 2i2c.org/cluster-name tag, which is fine from a cost attribution point of view because of the other two that are present. As far as we know currently we're not assuming this tag is present on the nodegroups, so this issue can be closed.
Note that once we'll upgrade the k8s version and recreate the nodegroups anyway, the 2i2c.org/cluster-name will be automatically added. So no specific action needs to be taken at this moment. Closing the issue.


Debug with GDB and see RustPython objects and traces

Get the equivalent of libpython.py into gdb for RustPython.

Will be very helpful to debug #5 .


Ability to Execute Clang-Tidy Workloads without Applying .clang-tidy Configuration

We have an .clang-tidy file in our repository root, which specifies some Checks, CheckOptions,  FormatStyle, as well as WarningsAsErrors: '*', and is currently only used in the IDE via Resharper (not in any CI / refactoring manner, yet).
For a large refactoring, I might want to execute a tidy(-fix) workload focusing on a single check, and maybe configure some CheckOptions differently than in the .clang-tidy file. As far as I can tell however, the flags passed to tidy or tidy-fix only affect the -checks passed to clang-tidy.exe.  Therefore, calling clang-build.ps1 -tidy "-*,readability-braces-around-statements" still takes into account the other options from the .clang-tidy file mentioned above.
Question: Is there a way to either ignore the .clang-tidy file completely, or override additional clang-tidy options besides just the checks? The way I noticed this is that the script aborts due to the checks being emitted as warnings. The parameter description in the powershell script suggests that the .clang-tidy file is only considered when passing ".clang-tidy" to the workload.
I am not sure if my use cases [^1] [^2] are valid, maybe we can discuss. In any case, thanks for the great work!
[^1]: Regarding WarningsAsErrors: In our case, we can actually remove the option from our .clang-tidy file, since it serves no other purpose (yet). But I think there might be other cases where one needs to have this enabled? The -continue option does not solve this issue either, if I understand correctly.
[^2]: Regarding the other use case of overriding the CheckOptions, one might ask why this is necessary, since normally you would want to execute a refactoring with the same options that are used elsewhere for the check. The only "use case" here is experimenting locally with some checks and not having to edit the working copy of .clang-tidy.

Hi @lursyy,
Here you can find more information about clang-build.ps1 parameters.
However, we do not control the .clang-tidy search criteria (it is detected automatically). A workaround that we use is to move .clang-tidy (with needed checks) in %temp% and specify the path of .clang-tidy.
Custom config file: e.g. --config-file=/some/path/myTidyConfigFile. In this case clang-tidy is forced to use custom path.
If you want to use this workaround, do not forget about .clang-tidy format, you ca use Clang Power Tools UI from Visual Studio to export the file.

Kind regards,
Marina

A workaround that we use is to move .clang-tidy (with needed checks) in %temp% and specify .clang-tidy temp path.

Ah, I did not think of that. Good enough for me :) thanks!


Update ToDoController to return DTO

In refrence to issue: #77
Not sure if this was what was needed since im quite new to .NET Core but hopefullly its the right change.

Thanks!


Move binary build into dockerfile

As stated in #154, the binary is currently build against glibc, and deployed in a musl image. This PR fixes this, by moving the build into the Dockerfile.
I tried to take care to not alter the resulting image too much.

Coverage remained the same at 91.423% when pulling 4c49a72343dc133005880219b0140c4a3dd46dbe on kernle32dll:build-in-docker into 72f342f3f4a3468579ccf0aee996db5925bad2e1 on tarent:master.


Unable to sign in on Mac - Error code: la3/sGb4/2WBt7ZiVy+EEv.14

I am unable to sign in when using the latest build on Mac OS.
I can click the sign in once, enter my email and password, then I get this screen and I can no longer click on Sign in, its just plain text.

This was an iCloud issue. See #508


add support for additional platforms

Overhaul makefile to build additional binaries and raspberry-pi compatible docker images.

Add automatic building and uploading of binaries during releases.
Add tagged releases triggering a github release.
Add optional support for binary packing.
Bump golang version to 1.15.
Strip local path names from binaries.

The Makefile was rewritten to help with automatic building of artifacts for github releases. For this reason, some new commands were added:
make all      # will create all available artifacts
make binaries # will create all supported binaries
make pack     # compresses the binaries to be much smaller (requires UPX installation)
make docker   # will create docker images for amd64 armv7 and arm64
make images   # will stores created images as artifacts
make clean    # will delete all artifacts

make dockerhub DOCKER_TAG=v1.0.0 # will tag a multi-arch image with the selected tag and upload it
                                 # to the dockerhub.

👑


Update namespace creation logic to not include node-selector label

This is a temporary fix that can be removed in favor of a plugin once upstream refactors namespace creation to use the regular item creation/plugin infrastructure, but for now we'll have to handle this as an openshift-specific special case in our fork.

This is a temporary fix that can be removed in favor of a plugin once upstream refactors namespace creation to use the regular item creation/plugin infrastructure, but for now we'll have to handle this as an openshift-specific special case in our fork.

we are holding off on merging this

we are holding off on merging this


Runner deploy failing trying to get-object from not-yet-created bucket

Hello, this setup looks very cool. I'm trying to try it out but am getting an error deploying with Terraform, and am not familiar enough with Terraform to easily debug.
There is a step that is attempting to pull a zip from an s3 bucket that has yet to be created that is erroring out.
Any guidance appreciated!
╷
│ Error: local-exec provisioner error
│
│   with module.lambda_webhook_pull.null_resource.lambda_github_webhook_pull_zip,
│   on webhook_module/main.tf line 2, in resource "null_resource" "lambda_github_webhook_pull_zip":
│    2:     provisioner "local-exec" {
│
│ Error running command 'mkdir -p ../files && aws s3api get-object --bucket lambda-github-webhook --key lambda-github-webhook-function.zip --request-payer true ../files/lambda-github-webhook-function.zip': exit status 254. Output:
│ An error occurred (AccessDenied) when calling the GetObject operation: Access Denied```

I believe this means your IAM role doesn't have permission to something.  It will need to get an object from S3 and it getting an "AccessDenied"
Can you confirm your IAM Policy that is used while running terraform?

I can confirm that the AWS account has full S3 GetObject permissions.
I think the issue is lack of permissions to retrieve lambda-github-webhook-function.zip from a bucket you own.

Hmm, let me investigate that.

I changed the objects, ACLs, let me know if that works!

I'm also still getting the same permission denied issue. Tested with both a restricted role and administrator access.

can confirm this is a permissions issue. i manually compiled and created lambda-github-webhook-function.zip and put it an s3 bucket accessible to me. i then updated webhook_module/main.tf to point to my bucket, and the was able to successfully complete terraform apply

A solution to this problem is to change deploy/webook_module/main.tf to compile the webhook code locally, rather than pulling it from S3:
resource "null_resource" "lambda_github_webhook_pull_zip" {
    provisioner "local-exec" {
        command = "mkdir -p ${var.file_destination} && cd ${var.file_destination}/../src/lambda-github-webhook && GOOS=linux go build -o ../../main && cd ../.. && zip ${abspath(var.file_destination)}/lambda-github-webhook-function.zip main"
    }
}

A solution to this problem is to change deploy/webook_module/main.tf to compile the webhook code locally, rather than pulling it from S3:
resource "null_resource" "lambda_github_webhook_pull_zip" {
    provisioner "local-exec" {
        command = "mkdir -p ${var.file_destination} && cd ${var.file_destination}/../src/lambda-github-webhook && GOOS=linux go build -o ../../main && cd ../.. && zip ${abspath(var.file_destination)}/lambda-github-webhook-function.zip main"
    }
}

This worked for me, thank you!


[v4.6.0] bug: svg file is not found when use baseHref

Bug Report
Ionic version:

[x] 4.6
Current behavior:

all of ionic icon svg file is not found (404)
Expected behavior:

Steps to reproduce:

Related code:

https://github.com/Jimmysh/ionic-4.6.0-bug
angular.json
{
  "$schema"<EMAIL_ADDRESS>  "version": 1,
  "defaultProject": "app",
  "newProjectRoot": "projects",
  "projects": {
    "app": {
      "root": "",
      "sourceRoot": "src",
      "projectType": "application",
      "prefix": "app",
      "schematics": {},
      "architect": {
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "www",
            "index": "src/index.html",
            "main": "src/main.ts",
            "baseHref": "/en/",   --- use baseHref

Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 5.0.0-beta.2 (/Users/jimmy/.config/yarn/global/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.6.0
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Utility:

   cordova-res : 0.3.0
   native-run  : not installed

System:

   NodeJS : v10.16.0 (/Users/jimmy/.nvm/versions/node/v10.16.0/bin/node)
   npm    : 6.9.0
   OS     : macOS

Thanks for the issue. It looks like you are trying to modify the baseHref of your application. Certain things like ionicons need to be served from the root in order to work properly.
If you would like to change your app's routing structure, we recommend using the Angular Router to accomplish this, not a project/build configuration file.
Thanks!

@liamdebeasi   basehref is always supported until v4.6 release.

Thanks! I think I may have misunderstood the original issue, so I am going to reopen this. We are investigating now and I will update this thread when there is more to share.
Thanks! 🙂

the build with the --base-href ng build --base-href /path-web-server/ --prod is not working with the svg ionicons

Is this fixed or just closed?

This was fixed in 4.6.1.


HTTPError removed from Python-mqtt documentation

Ready for review

@gopika-na looks great, thank you for fixing!


Is there a function to combine audio and video upon completion?

Is there a function to combine audio and video upon completion? Downloaded a m3u8 and mpd file.

not supported yet

Ok thanks

I'm using for disney+
@ echo off
set path=C:\Users\Administrator\Desktop\Downloader-Decrypt
echo.
set /p folder= Video Name to be Saved as (No spaces - use underscore between words '-'):
echo.
mkdir C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%
set /p stream=Input MPD from stream detector:
N_m3u8DL-CLI_v2.9.7.exe "%stream%" --workDir C:\Users\Administrator\Desktop\Downloader-Decrypt%folder% --saveName "stream" --enableDelAfterDone --enableMuxFastStart
ren C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\stream(Audio).*
ren C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\stream.* stream.mp4
echo.
set /p key=enter key:
echo.
set /p kid=enter kid:
echo Video being created.........
mp4decrypt.exe --key %kid%:%key% C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\stream(Audio).eac3 C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\decrypted-audio.eac3
mp4decrypt.exe --key %kid%:%key% C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\stream.mp4 C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\decrypted-video.mp4
mkvmerge.exe -o C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%.mkv C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\decrypted-video.mp4 C:\Users\Administrator\Desktop\Downloader-Decrypt%folder%\decrypted-audio.eac3
cls
Change C:\Users\Administrator\Desktop\Downloader-Decrypt to your location
You need FMPEG.exe, mkvmerge.exe, N_m3u8DL-CLI_v2.9.7.exe, mp4decrypt.exe,
(On Disney+ search for ctr-all in network tap and use that m3u3 link) it will give you 5.1 audio i dont now if you can download more than one audio track at a time but i don't think so might be a limitation with N_m3u8DL-CLI (nilavoda can confirm or deny that)


Fix bundling issue in WASM

Now that krml is capable of gracefully handling many non-WASM idioms (such as vector types), we don't need to "disable" as many files with bundling.
This simply removes wasm-specific bundling flags, thus fixing #692. This comes at the expense of a few possibly-not-really-helpful wasm files in dist/wasm... but it's not a big deal because clients can choose to only load a subset of the files. (See examples in bindings/js).

There still seem to be a large number of wasm-specific bundles in the Makefile. Are there plans to clean them up as well?

yes, very soon


Compiling deps for Epyc

I have an Epyc 7502 machine and I would like to use ANS.
When I run install_deps.sh, I get:
Start to generate librte_ans.a/librte_anssock.a/librte_anscli.a for -mnative.
Your native march is znver1.
Your native march is none of westmere/sandybridge/ivybridge/haswell/broadwell/knl.
You may generate librte_ans.a/librte_anssock.a based on your -mnative by manual,
Or ask help from ANS develop team

Hi Team,
Even I am facing the same issue. Could you please let us know how librte_ans.so to be created for znver1.
Thanks in advance.


Add CineList to pwa.rocks

CineList is a PWA that allows people to search for and view UK cinema times.

Late reply on this, but the geolocation feature doesn't work for me. Tried in Chrome and Opera for android.

That's odd. I've never had an issue - Does it show a red error message, or does it hang indefinitely (with the spinner)?


give ScalaTest's 3.1.x branch a try

I'm curious to see what goes wrong

queued:
https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/4219/

queued: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/4222/

status so far: 103 green projects, scalatest green, scalatest-tests red
top blocker is discipline
[discipline] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.16/project-builds/discipline-31853e1517fb8f5d7d2e781a808f6ae3bc8212b5/shared/src/main/scala/scalatest/Discipline.scala:7:8: object Checkers is not a member of package org.scalatest.prop
[discipline] [error] import org.scalatest.prop.Checkers
[discipline] [error]        ^

so we need to add scalatest's scalacheck support which is now in a separate repo I believe

I can no longer remember what my motivation was for this. It doesn't seem likely I'll return to it until 3.1 starts having users


Haxelib Lime 2.4.4 broken?

When installing Lime 2.4.4 using haxelib, only a few classes are installed, and the haxelib title/version is unknown 1.0.0

This might be your copy of haxelib, some recent versions fail to unzip all the way :cry:

Can you try haxelib selfupdate?

Hm, having thee selfupdate problem - on 14.04... https://github.com/HaxeFoundation/haxelib/issues/189

Does that trick work?
cp /usr/lib/haxe/haxelib /usr/lib/haxe/haxelib2 /usr/lib/haxe/haxelib2 selfupdate rm /usr/lib/haxe/haxelib2

Strangely the same (unknown 1.0.0) happened on my win machine. After selfupdate - saying that I already have the latest version - it relaunces, and after that haxelib lime update works...
Now on to the mac..!

Same pattern on the mac, unknown 1.0.0. It doesn't allow me to selfupdate though, not even after the copy trick...

After manually replacing haxe binaries to latest haxe.org-downloadable version (haxelib 3.2.0-rc.3), updating lime to 2.4.4 works on my Elementary OS (Ubuntu 14.04). The same (updating binaries to haxelib 3.2.0-rc.3) doesn't work on my mac though - it still gives the unknown 1.0.0 version,

[!http://i.imgur.com/fcQmia5.jpg]

can be this the problem? the absense of lib1-mesa-dev? sudo apt-get install libgl1-mesa-dev


Summarization example

❓ Questions and Help
Hi, in the summarization example, I want to try other graph neural networks (replacing GCN with GraphSAGE, GAT, ...)
How can I do it with minimal change to the original code?

You just need to modify the parameters in the configure file.
For example, GCN --> GAT.
You first need to modify L2: "gat". Then you need to modify graph_embedding_args in L40-L54. You can refer to the default GAT parameters in this file.

We plan to make it more clear in the documentation.

This is great, Thanks a lot.

I have one more question, for using other graph embeddings which currently aren't included in the graph_embedding directory such as GTN (Graph Transformer Networks), how can I do it?
Is there any priority between using DGL or PyG libraries?

You can implement it. Since our backend is DGL, the most straightforward way is to convert the GraphData to DGLGraph and do the GNN by calling DGL's implementation. Then you can convert the computation results to GraphData and do the downstream tasks.
Notes: You can refer to the GAT implementation (code).

@AlanSwift  Thank you very much.

@AlanSwift
I changed the config file, but after running the model this error occurred:

Here I tried to use gat. The config yaml file changed like this:
gatconf.txt

I think you should set allow_zero_in_degree to be True.

This solution worked and the model was run completely.
But about the other recommended solution (adding self-loop to nodes), may I ask how can do that?

The self-loop is missed during the migration. We will fix it now.
Currently, you can add the self-loop by adding the following code in this Line:
dgl_graph = dgl.add_self_loop(dgl_graph)

The problem is solved. Thanks again.


Hide tabbar when scrolling down on events screen

Sorry, could not make the gif, so did a demo video. The idea was to hide the tabbar when scrolling down on the events screen. When scrolling back up, it is shown again.
With animation there are problems, it is not so smooth now. Maybe someone knows why? Also need to check at it on iOS. I will be grateful for any help, thank you!

Cool! Really like the idea to hide the tabbar when scrolling.

Looks nice!
This is the render on iOS:

As you can see, the tabbar disappear sometimes with no reason... I have no idea why...
FYI: I use this tool https://ezgif.com/video-to-gif to convert video to gif (and also to optimize it, when too large) : I recommend it.

Hmm... Interesting. I think this has the potential to look really good, but also be pretty annoying.
Personally, I like the tab bar always being there. It feels more native to me allows me to navigate somewhere else without any extra hassle. The only other iOS app that I know does this is Safari, and even then the bar at the bottom of Safari has a much different use case and is used much less frequently than this bar. Our navigation here is a lot more like the navigation in the Twitter, Instagram, Facebook and Reddit apps, all of which have a static tab bar. In a way, a dynamic bar kinda feels more webapp-like, similar to when the header disappears as you start to scroll - not sure how much I like that.

The bottom line is to focus on content, events in this case. You've probably seen how the site hides a header, when scrolling down to free up more space, and then reappears when you scroll up.
@Antoine38660 cool, thanks for the animated screenshot! Well, to understand why this is happening :disappointed:
@andrewda We can put this in the settings, for example. By default, it will be enabled, but it will be possible to set the tabbar never to hide, how do you do it?

I agree with @andrewda in that having the tabbar disappearing on any screen on scroll down could be more of a problem then something useful. However, if it's only limited to the events screen and works fluidly I'm okay with that.
Will take a look at the code soon and let you know if I can spot why that issue is happening @lex111  (and will also try on my device 👍 )

@lex111 Sure that sounds good! Though I'd vouch for not hiding by default because it's the more standard style.

Agreed we could have a check option in the auth user settings screen to turn it on. Do you think it would be worthwhile to have three options: None, Events Screen only and Everywhere?

Bah we really need to allow comment editing 😭. Wanted to tag both you @andrewda @lex111 to get your opinion on that ^.

Hiding the tabbar was supposed only on the screen of events, on other screens, I think it is not necessary. Therefore, in the settings, I would just leave only two options: None and Events Screen. More precisely, then, the title is "Hide tabbar when scrolling down on events screen" - and options: Yes and No (default)
It would be good to solve the problem described by @Antoine38660, I hope for your help :sos:

I think the TabBar should not be hidden. It is good as it is now :)

@alejandronanez yes, you're right, it's still WIP, so there are imperfections, but there is a problem with smooth animation (see comment), can you help? Thank you!


Link in description redirects to learnrelay.com

https://www.learnrelay.org/ works just fine; leave off the "www", and it redirects to a .com that doesn't resolve.

Thanks for the heads up. This is fixed now.


feat: add toggle for smell checks

Closes #49
Currently implemented as checking everything by default, and as a white-list if at least one smell is referenced.
Example usage added in the README

TODO:

[ ] Merge after #48 , then add the toggle for code signature checks here


add a minimal beam model

After discussing with @grzanka. Fitting will be more robust if there is some initial width of the beam.
Propose:

4 mm FWHM for all beams
60 cm exit-window to isocenter distance
2 meters from last quadrupole to isocenter
add air as material
add exit window material
add energy spread 1 %
add divergence 3 mrad

The 4mm FWHM - do you mean a spot size at the beam source ?
If yes, I'd mention it explicitely. Very often spot size is used as measured in water at some depth or at isocenter


Issue #265

@suyashdb could you test this?

This PR didn't trigger the CI tests for some reason. I thought it could be related to originating from a fork, but there's plenty of fork based PRs in the history that triggered tests. I'm looking into it.

@chrisfilo - its is still generating error
`
login1.ls5(26)$ bids-validator/bin/bids-validator /corral-repl/utexas/poldracklab/openfmri/inprocess/dsmarcel_plank_institute/copy_inprocess_MP/
/home1/04275/suyashdb/node_modules/async/dist/async.js:825
return i < len ? { value: obj[key], key: key } : null;
^
RangeError: Maximum call stack size exceeded
at next (/home1/04275/suyashdb/node_modules/async/dist/async.js:825:26)
at replenish (/home1/04275/suyashdb/node_modules/async/dist/async.js:872:28)
at iterateeCallback (/home1/04275/suyashdb/node_modules/async/dist/async.js:866:17)
at /home1/04275/suyashdb/node_modules/async/dist/async.js:843:16
at NIFTI.async.forEachOf.issues.push.Issue.file (/home1/04275/suyashdb/bids-validator/validators/nii.js:217:21)
at replenish (/home1/04275/suyashdb/node_modules/async/dist/async.js:881:17)
at iterateeCallback (/home1/04275/suyashdb/node_modules/async/dist/async.js:866:17)
at /home1/04275/suyashdb/node_modules/async/dist/async.js:843:16
at NIFTI.async.forEachOf.issues.push.Issue.file (/home1/04275/suyashdb/bids-validator/validators/nii.js:217:21)
at replenish (/home1/04275/suyashdb/node_modules/async/dist/async.js:881:17)
`

@suyashdb Your stacktrace indicates the use of async.forEachOf at bids-validator/validators/nii.js:217. This PR switches to eachOfLimit. Are you sure you are testing the code from this PR?

@chrisfilo i was able to run validator in same dataset without any errors.


⚠ Fortnite has degraded performance

In ffcb2ac, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1573 ms

Resolved: Fortnite performance has improved in 3bbe92e.


scan1D liveplot not updating points

Hi all!
I'm new using qtt and while measuring with "scan1D" function I realized that the live plot does not work as expected.
I can see how the Y-axis updates, but the points are not shown. I took a look into the code but I didn't find the problem.
This is some dummy code that I wrote to show the problem:
import sys, os, tempfile
import numpy as np
%matplotlib inline
%gui qt
import matplotlib.pyplot as plt
import qcodes
from qcodes.plots.qcmatplotlib import MatPlot
from qcodes.plots.pyqtgraph import QtPlot
from qcodes.data.data_set import DataSet
from qtt.measurements.scans import scanjob_t
import qtt
from qtt.instrument_drivers.gates import VirtualDAC
from qcodes.tests.instrument_mocks import DummyInstrument, DummyInstrumentWithMeasurement

# set data directory
path_save = r'K:\Jaime\Testing_qtt'
datadir = os.path.join(path_save, 'Test')
DataSet.default_io = qcodes.data.io.DiskIO(datadir)

dac = DummyInstrument('dac', gates=['ch1', 'ch2'])
dmm = DummyInstrumentWithMeasurement(name='dmm', setter_instr=dac)

station = qcodes.Station(dac, dmm)
mwindows = qtt.gui.live_plotting.setupMeasurementWindows(station, create_parameter_widget=False)
plotQ = mwindows['plotwindow']

# Checking the sensor
scanjob = scanjob_t({'sweepdata': dict({'param': station.dac.ch1,
                                        'start': 0.0, 'end': 30.0, 'step':1.0,
                                        'wait_time': 0.1}),
                                        'minstrument': [station.dmm.v1],
                                        'dataset_label': 'Test1D_liveplot'})

data1d = qtt.measurements.scans.scan1D(station, scanjob, liveplotwindow= None,location=None, verbose=0)

Using "scan2D" the updating works without problem, then it is something really particular for the 1D plot.
Could someone help me to solve this issue?
Thanks!
Jaime

Hi,
thanks for the reply. My problem is that it does not update the plot point by point (what I expected that the code would do), it just shows all the points when the measurements are finished. Was this also the case for you?
I ran the code in Windows 10, I don't know if that could be a problem.
Jaime

@jsaez8
Hi,
In my case it did update point for point. Do you run the example from a jupyter notebook, because I didn't. Maybe that matters. I run qtt 1.2.4 on python 3.7.5.
Fer

Hi, it seems that the problem was running it in a jupyter notebook. Thank you!
Jaime


closes #251 Project node title validation

Hugo I am very impressed with your hard work! You are one of the best students ever. I am very proud of you. Thank you for your hard work and dedication to this team.

:)


[WIP] Update embulk gem's version in Gemfile of bundle directory template to 0.9.0

Writing no any version here may work well with the gem-embedded embulk.jar? It'd be better if it works. Would check...

Just gem 'embulk' would work, and it would be better than gem 'embulk', '~> 0.9.0'. Closing this PR.


python 3.6 in testing

It looks like python 3.6 is passing, and since it is becoming much more standard, the testing could enforce that properties passes on 3.6 as well.

Thanks, this is great, I hadn't checked on the 3.6 build in months.


Trending up color green, trending down red Feature request

All is in the title, when up arrow should be green and when down should be red.
Thanks!

Icons are monotonic; you can add colors by customization in the card. There are many ways to achieve this and I personally use this appraoch (https://github.com/iprak/yahoofinance/issues/14#issuecomment-743485687).

OK, I thought it was like light on (yellow) , light off. Will try that, thanks


How to enable longClick functionality?

I need my DocumentView to be handle long click by user. I tried to set in xml
android:longClickable="true"

and
docView.setLongClickable(true);

Still no result. OnTouchListener works fine. Am I missing something?

So, DocumentView is extending ScrollView which is also doesn't catch onLongClockListener. But. there is workaround which is works fine
GestureDetector.OnGestureListener gestureOnDocListener = new GestureDetector.SimpleOnGestureListener()
{
    @Override
    public void onLongPress(MotionEvent e)
    {
        Toast.makeText(getActivity(), "LongClick", Toast.LENGTH_SHORT).show();
    }
};

...

 @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
        setRetainInstance(true);
...
final GestureDetector gestureDetector = new GestureDetector(getActivity(), gestureOnDocListener);
documentView.setOnTouchListener(new View.OnTouchListener()
{
    @Override
    public boolean onTouch(View v, MotionEvent event)
    {
        return gestureDetector.onTouchEvent(event);
    }
});

If you can make a PR and a test case, I will be happy to merge it.

I'll make PR this weekend


Fix arbitrary query limit not being applied

See https://github.com/opendatakit/androidcommon/pull/5


Badged control Badge property throws Exception with PropertyChanged

When I bind a property from a ViewModel to the Badge property of the Badged Control, it will throw an expection on the PropertyChanged Event.
<materialDesign:Badged Badge="{Binding EnqueuedDownloads}" />

Example binding property with Prism BindableBase
public int EnqueuedDownloads
{
    get { return _enqueuedDownloads; }
    set { SetProperty(ref _enqueuedDownloads, value); } <-- Crashes here
}

EnqueuedDownloads++; or EnqueuedDownloads += 1;

System.InvalidOperationException:
The name "BadgeScaleTransform" cannot be found in the namespace of "System.Windows.Controls.ControlTemplate"

Should be fixed by #660


identityserver integration

Can saturn work with identityserver? If can, is there some demos?

There's no reason why it can't, Saturn is just a wrapper over ASP .NET. However, it could be nice to have a sample application showing a basic identity server example. Most of the time you can use the service_config command inside application to add custom middleware etc.

Hello everybody, can please someone provide sample solution with identity server integration? :) THX

If this is still relevant, here's the solution:

Add IdentityServer4.AccessTokenValidation NuGet to your entry point project.

Write a function that adds identity server authentication capabilities to your application builder:
let identityServer (services:IServiceCollection) = let auth (options:IdentityServerAuthenticationOptions) =     options.Authority <- "yourIdentyServerURL"     options.ApiName <- "yourApiName"     options.ApiSecret <- "yourApiSecret"     () let authBuilder = services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme) authBuilder.AddIdentityServerAuthentication(auth) |> ignore services.AddAuthorization()

Write a function that adds the authentication feature to the application builder:
let authentication (app:IApplicationBuilder) = app.UseAuthentication()

Add a pipe_through operation into any router where you wish to authorize the role of the request sender:
let appRouter = router { pipe_through (Auth.requireRole JWT "yourRoleName") }

And finally, configure your application computation expression like this:
`let app = application {
service_config identityServer
app_config authentication
use_router appRouter
}

[]
let main _ =
run app
0
`

@yurotor thanks for this guide. ❤


Bluetooth: hci_uart: Use interrupt to trigger TX data

This triggers h4_send only on uart_irq_tx_ready and in case that not all
the data can be transmitted keep the buffer so it is send in the next
time the interrupt is triggered.
Fixes #2955
Signed-off-by: Luiz Augusto von Dentz<EMAIL_ADDRESS>

So, of the 2 commits:
Bluetooth: hci_raw: Fix pushing H4 headers in bt_buf_get_rx fixes the issue
Bluetooth: hci_uart: Use interrupt to trigger TX data makes hci_uart not even respond to the first command.
Seeing how we are close to release, I would suggest dropping Bluetooth: hci_uart: Use interrupt to trigger TX data from this PR.
@jhedberg @Vudentz @joerchan thoughts?

Sure, the first one was just a tentive to fix the later.


select query was garbled. (#13825)

System information:
Operating system (distribution) and version
windows10
DBeaver version
dbeaver-ce-21.0.2-win32.win32.x86_64
dbeaver.ini file add line
Dfile.encoding=UTF-8
Additional extensions
Connection specification:
Database name and version
mariadb 10.1.13
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)?
Describe the problem you're observing:
Steps to reproduce, if exist:
When I search by query, it doesn't come out in the language I want, but in another language.
The same goes for changing the character set.
The first 200row(default Result-set fetch size) are correct, but if you scroll and want a lot of data, it doesn't come out in the desired language.

Sorry to my mistake closed an issue
issue : #13825
What happens when you change max fetch size?
-> If you change the petch size, the changed row is output correctly, but if you scroll down and output the data after that, the same phenomenon occurs.
Does it happen when you manually perform select?
-> It doesn't happen when you do it passively.
For example, if you set the fetch size to 300 and scroll down to row 300, data is normally output, but when rows 301 and later are selected, the result that exposes existing 1~300+ rows is also changed.
Data comes out normally in other databases, but strangely in the database I want.
Is there anything I need to change settings?

I will reopen an original issue.


Question regarding observations when using AE2/Mek8/ThaumicEnergistics (not really a bug report)

Hello I have been tinkering with the three mods that have been in question a for a few days now (ie. AE2, Mek8, and ThaumicEnergistics) and I only get the crash report (that has been reported numerous times already) with ThaumicEnergistics in with Mek8. I tried it without Mek8 and with the latest AE2 (r14) and it works but with Mek8 in it decides to crash. The question I have is how exactly is it a AE2 issue when i can load ThaumicEnergistics with the latest build of AE2 and it doesn't crash? is ti just a weird interaction between AE2 and Mek8 that doesn't kick in until you add in ThaumicEnergistics? This behavior seems strange (to me at least). any addition input far as clarification regarding this is appreciated. ;)

This is referenced a few times in reports (ie #2347).
Basically, AE2 needs to update the mek api. From what I can gather, right now some recipes and things are changed when AE loads the outdated mek api and thaumic energistics is looking for those. I believe there is a patch in the dev builds of mekanism to avoid this but its an ae2 issue at its root.


Arctic?

http://en.wikipedia.org/wiki/Arctic_tern

The Arctic tern is famous for its migration; it flies from its Arctic breeding grounds to the Antarctic and back again each year, the shortest distance between these areas being 19,000 km (12,000 mi).

No personal attachment to it, was just hunting for something pronounceable and available on npm.


Gatekeeper (single process)

This is the same implementation as #236, except it runs in the main Torus process, instead of as a co-process.

This pull requests add a Gatekeeper implementation that is able to bootstrap machine registration without manual intervention and prompting. This is useful in a continuous integration environment where servers may scale in or out automatically.
This pull requests contains code for bootstrapping AWS machines, based on their Instance Metadata and their Instance Identity Docs. AWS  provides signed metadata information, which can be used for instance verification.
The Gatekeeper listens on "<IP_ADDRESS>:8200" by default.
Gatekeeper Commands
torus gatekeeper start -- start the Gatekeeper listener
Bootstrapping Commands:
torus machines bootstrap -- bootstrap a machine into the Gatekeeper listener.
The torus machines bootstrap command must be run as root, since it writes to /etc/torus
bootstrap takes additional arguments:
--url (required): Gatekeeper URL
--auth (requied): Gatekeeper authentication type to use (valid: aws)
--org (optional): Organization to bootstrap to
--role (optional): Team/Role to bootstrap to
--machine (optional): Machine name to provision
Future Work
There is an opportunity for future work here, particularly around other cloud providers. For AWS, some additional verification that the server is running, and a comparison on instance running in a provided AWS environment would help Torus ensure the server actually exists. Additionally, SSL on the Gatekeeper may be worthwhile since it passes a machine secret to the server.
Added Dependency
Added the dependency github.com/fullsailor/pkcs7 which is used for signature validation from AWS.

Before we merge this up, can we get an issue (or many?) created for tracking what we'd need to do to take this from a prototype into a beta form.  For example, supporting role retrieval based on aws instance tags, documentation, getting started guide, etc.
Looks great 💯

Good to go! Can you rebase on master, and squash down the commits, and then we can merge it.


Investigate multi-NSF support

There's no reason why the back-end couldn't work with many NSFs, either using NSF paths in the SFTP path or by directing to a given NSF based on user name.
Either way, this would likely involve creating a configuration DB separate from the file stores, to house routing info or lists of DBs.

The filesystem layer already supports this by way of the generated URIs, so it would be more about the SSHD/webapp side.

I think it will make most sense to switch to a mechanism where there's a single "config" NSF that then points to other NSFs. That would tie in to https://github.com/IKSG/nsf-file-server/issues/10 , where the actual NSFFileSystem objects would have a prefix that they would ignore for internal storage, and there'd be another virtual layer on top of them that would list the actual data store NSFs configured in the central one.


fix: revert to prior behavior where hidden pages are indexable

Reverts changes introduced in https://github.com/fern-api/fern-platform/pull/1547 where hidden pages were removed from indexing, and adds comments explaining why.
To clarify:
unlike the behavior set by other docs providers, hidden pages in fern docs ARE indexable, and DO show up in the sitemap. Indexing must be explicitly disabled using noindex=true in the frontmatter. This is so that fern docs makes fewer assumptions about how SEO is handled, and rely on the docs maintainer to be explicit.

@abvthecity im not sure hidden pages should be indexed by default; seems less intuitive + safer than not indexing and forcing customers to mark index as true


Scroll Restore on Route path change

Scroll Restore on Route Path change when page is longer then viewport
Fix Link error on SearchPage
Fix Modal Transaction Effect

Before

After

Looks good!  Thanks for fixing this!


[Bug][Doc]Update database init instruction docs (#9598)

Purpose of the pull request

Update database initialization instructions in docs
This PR closes: #9598

Brief change log

Add instructions on how to create db, user and grant permissions for dolphin users who use latest versions of mysql.
Update instructions on how to init db since related directory structure has changed.

Verify this pull request

Verified by manual test.

May be we should modifiy this docs too. Because init script and upgrade script are similar. @EricGao888
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/upgrade.md

May be we should modifiy this docs too. Because init script and upgrade script are similar. @EricGao888
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/upgrade.md

Sure, I will update it.

I find out keyword create-dolphinscheduler.sh also in https://raw.githubusercontent.com/apache/dolphinscheduler/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/docs/en/architecture/configuration.md . and the binary package structure already changed, I think you could change it too. But you could also just delete <create|upgarde>-dolphinscheduler.sh in this PR too

I find out keyword create-dolphinscheduler.sh also in https://raw.githubusercontent.com/apache/dolphinscheduler/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/docs/en/architecture/configuration.md . and the binary package structure already changed, I think you could change it too. But you could also just delete <create|upgarde>-dolphinscheduler.sh in this PR too

@zhongjiajie Sure. I just figured out there's also a bug in upgrade-schema.sh caused by incorrect file path. I will also fix it in this PR. https://github.com/apache/dolphinscheduler/blob/1de7f154a38566f4d7989c8c7ebe8bda16a8dc6e/dolphinscheduler-tools/src/main/bin/upgrade-schema.sh#L22-27

Codecov Report

Merging #9659 (1de7f15) into dev (7b1c316) will increase coverage by 0.08%.
The diff coverage is 51.11%.

:exclamation: Current head 1de7f15 differs from pull request most recent head 52c22f8. Consider uploading reports for the commit 52c22f8 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9659      +/-   ##
============================================
+ Coverage     39.92%   40.01%   +0.08%
- Complexity     4463     4475      +12
============================================
  Files           835      835
  Lines         33541    33549       +8
  Branches       3707     3709       +2
============================================
+ Hits          13391    13424      +33
+ Misses        18906    18877      -29
- Partials       1244     1248       +4

Impacted Files
Coverage Δ

...hinscheduler/common/config/StoreConfiguration.java
0.00% <ø> (ø)

...che/dolphinscheduler/common/utils/HadoopUtils.java
30.39% <ø> (ø)

...e/dolphinscheduler/common/utils/PropertyUtils.java
37.34% <0.00%> (+1.20%)
:arrow_up:

.../apache/dolphinscheduler/common/utils/S3Utils.java
0.00% <ø> (ø)

...duler/plugin/task/api/AbstractCommandExecutor.java
0.00% <0.00%> (ø)

...olphinscheduler/plugin/task/api/TaskConstants.java
0.00% <ø> (ø)

.../server/worker/processor/TaskExecuteProcessor.java
0.00% <0.00%> (ø)

...heduler/api/service/impl/ResourcesServiceImpl.java
52.68% <20.00%> (-0.09%)
:arrow_down:

...eduler/server/worker/runner/TaskExecuteThread.java
12.58% <44.44%> (+12.58%)
:arrow_up:

...exception/StorageOperateNoConfiguredException.java
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1c316...52c22f8. Read the comment docs.

I find out keyword create-dolphinscheduler.sh also in https://raw.githubusercontent.com/apache/dolphinscheduler/9f84dbbda00956d5bf198ce7eb4c47f2ea335173/docs/docs/en/architecture/configuration.md . and the binary package structure already changed, I think you could change it too. But you could also just delete <create|upgarde>-dolphinscheduler.sh in this PR too

@SbloodyS @zhongjiajie  I've fixed upgrade-schema.sh and updated db upgrade related docs. I just checked the configuration.md, it seems that we need to update the whole Directory Structure section. I will submit a new PR to this issue: #9670


Adds defineStep method

As a step could be used with different keywords, like Given and When for example, defineStep will allow to create a step without linking it to a unique keyword in the code.
Related to https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/issues/172.

Should I add documentation somewhere ?

@josselinbuils thanks for the work!. I think is a common use case.

@josselinbuils documentation would be great, but lets merge this for now and if you could open another PR with a docs that would be very appreciated.
Thanks!

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: remove fdb from shell.nix on macos

Fixes RVT-4153

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1424  👈 (View in Graphite)
#1388 : 1 other dependent PR (#1411 )
#1386
#1385
#1380
#1379
#1378
#1376
#1375
#1364
#1362
#1356
#1355
#1354
#1349
#1326
#1325
#1324
#1391
#1304
#1382
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Wall operations 5.27, groups and newsfeed API

wall posts VK API 5.27 (with all attachments support)
groups API
basic newsfeed API

That's great. Thank you!


Cool Tools

My new pwa added to list.

Cool app! Could you email me at<EMAIL_ADDRESS>I would like to chat


[MAPLv3] Remove functions from  submodule files

Types of change(s)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[x] Ran the Unit Tests (make tests)

Description
Move "simple" get_ and set_ functions from submodule files into "parent" module files.
Related Issue

That CMakeLists conflict is above my knowledge. Perhaps @tclune had changes that came in while you were doing this change.
@JulesKouatchou You might need to try and figure it out...

I only removed .F90 file names in generic3g/CMakeLists.txt. I will try to check why there is a conflict.

@mathomp4 and @tclune : the new file generic3g/CMakeLists.txt is fine.


CosmosDB documents won't load

Connect to any CosmosDB database in Azure, then try to open/view any document.
Displays a error flyup:
"cannot open azureDatabases:/...-cosmos-document.json?id%3D%2FcosmosDBAttachedAccounts%2Fwest2-crp-nonprod-preference-dev-cosmosdb.documents.azure.com%3A443%2FPreferences%2FPhone%2F%24Documents%2Fi%2BUhAPEfvNACAAAAAAAAAA%3D%3D. Detail: Unable to read file 'azureDatabases:/...-cosmos-document.json?id=/cosmosDBAttachedAccounts/west2-crp-nonprod-preference-dev-cosmosdb.documents.azure.com:443/Preferences/Phone/$Documents/i+UhAPEfvNACAAAAAAAAAA==' (Error: Unable to resolve nonexistent file 'azureDatabases:/...-cosmos-document.json?id=/cosmosDBAttachedAccounts/west2-crp-nonprod-preference-dev-cosmosdb.documents.azure.com:443/Preferences/Phone/$Documents/i+UhAPEfvNACAAAAAAAAAA==')"

Could you please file an issue in the extension's repository? Thank you.


Typo in URL

You may want to change the link in the phrase
"but please use other repos like privateGPT."

Thanks for the feedback, has been resolved


Update README with VM initialise instructions

Upon installing docker for the first time I found init was also needed.

Looks good to me! :+1:


Vulnerability roundup 114: radare2-5.6.8: 4 advisories [7.1]

search, files

[ ] CVE-2022-1437 CVSSv3=7.1 (nixos-unstable)
[ ] CVE-2022-1451 CVSSv3=7.1 (nixos-unstable)
[ ] CVE-2022-1452 CVSSv3=7.1 (nixos-unstable)
[ ] CVE-2022-1444 CVSSv3=5.5 (nixos-unstable)

CVE details
CVE-2022-1437
Heap-based Buffer Overflow in GitHub repository radareorg/radare2 prior to 5.7.0. The bug causes the program reads data past the end of the intented buffer. Typically, this can allow attackers to read sensitive information from other memory locations or cause a crash.
CVE-2022-1451
Out-of-bounds Read in r_bin_java_constant_value_attr_new function in GitHub repository radareorg/radare2 prior to 5.7.0. The bug causes the program reads data past the end 2f the intented buffer. Typically, this can allow attackers to read sensitive information from other memory locations or cause a crash. More details see CWE-125: Out-of-bounds read.
CVE-2022-1452
Out-of-bounds Read in r_bin_java_bootstrap_methods_attr_new function in GitHub repository radareorg/radare2 prior to 5.7.0. The bug causes the program reads data past the end 2f the intented buffer. Typically, this can allow attackers to read sensitive information from other memory locations or cause a crash. More details see CWE-125: Out-of-bounds read.
CVE-2022-1444
heap-use-after-free in GitHub repository radareorg/radare2 prior to 5.7.0. This vulnerability is capable of inducing denial of service.

Scanned versions: nixos-unstable: f419dc5763c.
Cc @7c6f434c
Cc @arkivm
Cc @makefu
Cc @mic92

Still waiting for a release https://github.com/radareorg/radare2/releases

NB: 5.7.0 is here! 🎉
https://github.com/NixOS/nixpkgs/commit/f2454a4502e9eef1fa2e9e8ba0f869e7a4b7fc95
> nix search nixpkgs#radare2
* legacyPackages.x86_64-linux.radare2 (5.7.0)
  unix-like reverse engineering framework and commandline tools

✅


How to determine if a transaction is a Runes transaction

May I ask how to determine if a transaction is a Runes transaction? Is there a corresponding index ledger? The ord node did not find the corresponding interface

Hi Sayplaydiv,
There are a few ways depending on what interface you are utilizing to view the tx.  On mempool.space, for example, this is the tx for the etching of the SATOSHI.NAKAMOTO rune.  When you view the tx on ordinals.com, you can see that it is a rune etching tx because it shows the etching with the inscription genesis for inscription 70279601.
ord has the ability to index runes by using the ord --index-runes flag.
In the future, I'd encourage you to post questions like these to the Ordicord instead of GitHub.  Mods and trusted tech help are usually much more available to answer these sorts of inquiries much quicker than you'll find here.


Added Network Discovery(Python)

Fixes issue #107
Description
Added network scanner using python. This tool allows us to scan our wifi.
Type of change

[x] New project (non-breaking change which adds functionality)

How Has This Been Tested?
Tested on Ubuntu
Checklist:

[Yes] My code follows the style guidelines of this project
[Yes] I have performed a self-review of my own code
[Yes] I have commented my code, particularly in hard-to-understand areas
[Yes] I have included a README.md file
[Yes] My project follows this structure: Domain Folder/ Project Name Folder/ Project files and Readme.md files
[No] I have added demonstration in the form of GIF/video file
[Yes] I am a GSSoC'22 Participant

Hey @rajdip-b, everything looks good but add a working video too.

Yes I was about to get to that. Creating a video would mean recording sensitive information about devices on my network that's why i thought not to make one.

Hey @rajdip-b, everything looks good but add a working video too.

Yes I was about to get to that. Creating a video would mean recording sensitive information about devices on my network that's why i thought not to make one.

@rajdip-b okay rather than demo could explain the working of code in a video and attach
This would help others visiting the project like which module is doing which task and stuff

@rajdip-b Any Update??

@rajdip-b any updates buddy ???

yeah extremely sorry was busy with a personal project. Ill try to upload the images by tomorrow night.

@rajdip-b any updates ?????

@rajdip-b any updates ????

Since there were no updates, so I'll be closing this issue.
@rajdip-b if you still want to continue with this project then ping us here or in the discord.


Unclear installation instructions

Clear and concise description of the problem
I am trying to follow the docs https://evite.netlify.app/guide/, I hoped tgat npm i electron-vite -D would do all the magic, but it just add some files. Next command npm create @quick-start/electron creates subfolder and it is not clear what is happening, now I have two package.json files, nothing works, and where do I put "electron-vite dev" etc?
error during preview electron app:
Error: Cannot find module 'electron/package.json'

Suggested solution
Please provide more clear step by step instructions.
Alternative
No response
Additional context
No response
Validations

[X] Follow the Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

If your project already exists, you can install electron-vite and follow the documentation to configure it.
npm create @quick-start/electron  used to create a complete project for quick development.

@alex8088 But what does If your project already exists mean? Do I have to install electron before electron-vite?

@Andrew-web-coder, I'm getting a bit of a "I need 101 tutorial in Electron/TypeScript" sense here and honestly such questions are beyond this projects scope, like adding a detailed explanation "what is Vite and how it works?". This plugin has a very clearly defined scope, goal and features at the beginning of the Readme. I might as well add that I've rarely seen such a beautifully documented 3rd party plugin (kudos to @alex8088 and all the contributors). A PR for doc improvements of course is always welcome if it's within the scope of the project (for ex. explaining how npm scripts work is a bit of an overkill).

@TheWashiba All I am asking is a list of commands that I have to execute in order to get fully functional setup. Right now, following the docs results in confusing, non-working setup.

I took a look again at the docs. Scaffolding section (which means exactly that we want the automatically working boilerplate, no manual wiring), so as followed:
npm create @quick-start/electron

Then as follows, the CLI output:
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
✔ Project name: … example-electron-project
✔ Select a framework: › react
✔ Add TypeScript? … No / Yes
✔ Add Electron updater plugin? … No / Yes
✔ Enable Electron download mirror proxy? … No / Yes

Scaffolding project in /home/user/Documents/projects/example-electron-project...

Done. Now run:

  cd example-electron-project
  npm install
  npm run dev

I ran the commands and the following I've got is this:

How could this be improved, because this already looks dead simple?

Wait a minute, is that all? So, the command npm i electron-vite -D is not needed? It is stated here - https://evite.netlify.app/guide/#installation And this one is not needed, too - https://evite.netlify.app/guide/#command-line-interface ?

It's written just right next https://evite.netlify.app/guide/#command-line-interface, that it's a binary that you install here, so it provides some common functionality, but of course the binary needs a config electron.vite.config.js for it to know "where is the main entrypoint, renderer, preload script and etc".
However, if you don't want to do the whole manual hassle as it's quite the usual for Electron apps, to wire up things on your own (like, Webpack config, electron-builder config, TypeScript config and etc.), instead you can jump right next to the scaffolding section. I don't know how much you're familiar with Electron, Vite or whatever, but in projects like these, you can assume, that there's the manual way and the "scaffold me some boilerplate" way of doing things.
It's nothing specific to this project, you would go the same pathways by choosing any other Vite, Webpack and etc. tooling. This plugin however, is the most advanced and user friendliest so far from what I've found, since Forge Vite Plugin still doesn't provide out of the box TS support (for the configs and some manual touching is needed for the app code albeit minimal) and some other features.
If you still think there's some better way of writing the Readme, I think the project author would appreciate any suggestions or a PR.

@TheWashiba Thank you so much for the explanation! I think you should just add part of your last comment right here - https://evite.netlify.app/guide/#scaffolding-your-first-electron-vite-project - and then everything would be clear.


Report a better error message when retrieving target info from the frontend fails

This should help make it a bit clearer what's going on when using the driver with an incompatible toolchain or configuring SWIFT_DRIVER_SWIFT_FRONTEND_EXEC incorrectly

@swift-ci test

@swift-ci test macOS

It looks like the 8/7 snapshot CI is using has some kind of code signing issue. I filed https://bugs.swift.org/browse/SR-13370 in case it doesn't resolve itself on its own tomorrow

@swift-ci test macOS

Hmm, still having trouble:


Remove ViewFactory from Spring module

It doesn't add any value IMO. The sample looks just as
nice and it easier to understand.

Removed the javadoc links.
If you want to showcase templateImplements we could move ViewFactory to the sample. IMO there's no need for it in the library.


Adding support for Order as an integer property.

Should resolve #987.
Signed off by: Bryan Boettcher<EMAIL_ADDRESS>

I am still interested in trying to solve this.


temperature, humidity and pressure

I'd like to integrate your work into a plugin for the Webthings Gateway smart home controller. Specifically, I'd like to merge it into the zigbee2mqtt addon. The idea is that simple Zigbee temperature, humidity and pressure sensors could gain an extra property: weather forecast. Having this ability would make for a very privacy friendly weather prediction, since no connection to a "free" cloud service needs to be made.
Skimming through your code I noticed that other factors can be taken into account, such as temperature and wind direction.
If you don't mind I'd like to ask a few quick questions just to quickly get a hang of things.

Since I have temperature values available, is there any value in also incorporating the temperature? How does that influence the forecast?
More of a suggestion, but since it's available in these types of devices (probably based on the BME280), could changes in humidity be a useful factor in the calculations?
I don't have wind direction data. I noticed in the code that it looks at 'quadrants' if there is no wind data? Does that mean it looks at 4 quadrants of the globe somehow, and use average wind direction?
How important is it for a user to state their elevation above sea level? What are the benefits of users adding their elevation? (and would something like "I live on a plain/hill/mountain" already be a useful thing to ask users? I'm assuming most of them won't know their exact elevation, so I'm wondering how they may easily provide somewhat useful data.
Does the pressure input have to be at a precise cadence? (say, every minute?) Or can the input be at random intervals?
Do you have some simple minimal example code?

Hope your questions were answered ! 👍

Yes, thanks. I'll have to look into this asap.


@apply error for own classname

I am using vitesse template.
the css is working but there is a error for that.

it seems like it has mentioned in the readme
but we can just disable the css validate instead of a proper handling of the conflict?


Throwing errors on Resolved findings

When validating policy with CFN template, I see that it still throws errors on resolved findings.
{
            "findingType": "SECURITY_WARNING",
            "code": "EXTERNAL_PRINCIPAL",
            "message": "Resource policy allows access from external principals.",
            "resourceName": "iconnector-logs",
            "policyName": "BucketPolicy",
            "details": {
                "action": [
                    "s3:PutObject",
                    "s3:PutObjectAcl"
                ],
                "changeType": "UNCHANGED",
                "condition": {
                    "aws:PrincipalArn": "arn:aws:iam::123456789:role/eksctl-*"
                },
                "createdAt": "2022-03-10T12:00:07+00:00",
                "existingFindingId": "2b601f5e-10c5-4728-8550-xxxxxx",
                "existingFindingStatus": "RESOLVED",
                "id": "e4e000fd-e87e-4b76-9239-7xxxxxxx",
                "isPublic": false,
                "principal": {
                    "AWS": "*"
                },
                "resource": "arn:aws:s3:::connector-logs",
                "resourceOwnerAccount": "123456789",
                "resourceType": "AWS::S3::Bucket",
                "sources": [
                    {
                        "type": "POLICY"
                    }
                ],
                "status": "RESOLVED"
            }
        }

Its resolved but it return exist status 2.

Hi - thanks for opening this issue.  I agree that only active findings should be returned in this case.  I'll add this to the backlog to be updated.

This should be resolved in release 0.0.12: https://github.com/awslabs/aws-cloudformation-iam-policy-validator/releases/tag/v0.0.12
Please let me know if that doesn't resolve your issue and I'll reopen.