Alamofire crashes only when running archived app

I am having an issue with my HTTP request using Alamofire. When I try to reproduce the issue with the XCode debugger it does not crashes but when I archive the app and run the .ipa file on my iPad with ios 10.0.2 I always get a crash.
This is an example of a call that crashes when running the arhived app:
#static func loginOnServerUrl(serverURL: String, user: String, password: String,
        successCallback: ((JSON) -> Void)? = nil, failureCallback: ((Error) -> Void)? = nil){

            let params = [
                ApiParams.ACTION : "login",
                ApiParams.LoginParams.USER : user,
                ApiParams.LoginParams.PASSWORD : password,
            ]

        Alamofire.request("http://\(serverURL)/AppSrv", method: .get, parameters: params).responseJSON { response in
                switch response.result {
                case .success(let value):
                    //JSON raiz
                    let json = JSON(value)

                    for (key, value) in json.acceptingSigleValueAsArray {
                        log("\(key) : \(value)")
                    }

                     if let successCallback = successCallback {
                         successCallback(json)
                     }

                case .failure(let error):
                    log(error.localizedDescription)
                    if let failureCallback = failureCallback {
                        failureCallback(error)
                    }
                }
            }
    }

This is one of the crash logs I am getting:
Incident Identifier: ****
CrashReporter Key:   *****
Hardware Model:      iPad5,2
Process:             ****
Path:                ****
Identifier:         ****
Version:             1.42 (1.2.3a)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           ****

Date/Time:           2016-10-21 10:16:08.9811 +0200
Launch Time:         2016-10-21 10:16:06.2504 +0200
OS Version:          iPhone OS 10.0.2 (14A456)
Report Version:      104

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x000000059480bec8
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]
Triggered by Thread:  0

Filtered syslog:
None found

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   libswiftCore.dylib              0x0000000100e19b6c 0x100c38000 + 1973100
1   myapp                           0x00000001000c4d88 static ServerManager.(pingOnServerUrl(serverUrl : String, successCallback : (Int64) -> ()?, failureCallback : (Error) -> ()?) -> ()).(closure #1) (ServerManager.swift:0)
2   Alamofire                       0x00000001003aca84 specialized DataRequest.(response<A where ...> (queue : DispatchQueue?, responseSerializer : A, completionHandler : (DataResponse<A.SerializedObject>) -> ()) -> Self).(closure #1).(closure #1) (ResponseSerialization.swift:0)
3   libdispatch.dylib               0x00000001889f1200 _dispatch_call_block_and_release + 24
4   libdispatch.dylib               0x00000001889f11c0 _dispatch_client_callout + 16
5   libdispatch.dylib               0x00000001889f5d6c _dispatch_main_queue_callback_4CF + 1000
6   CoreFoundation                  0x0000000189b15f2c __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
7   CoreFoundation                  0x0000000189b13b18 __CFRunLoopRun + 1660
8   CoreFoundation                  0x0000000189a42048 CFRunLoopRunSpecific + 444
9   GraphicsServices                0x000000018b4c5198 GSEventRunModal + 180
10  UIKit                           0x000000018fa15628 -[UIApplication _run] + 684
11  UIKit                           0x000000018fa10360 UIApplicationMain + 208
12  myapp                           0x00000001000bf024 main (AppDelegate.swift:16)
13  libdyld.dylib                   0x0000000188a245b8 start + 4

Thread 1:
0   libsystem_kernel.dylib          0x0000000188b36a88 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x0000000188bf936c _pthread_wqthread + 1452
2   libsystem_pthread.dylib         0x0000000188bf8db4 start_wqthread + 4

Thread 2:
0   libsystem_kernel.dylib          0x0000000188b36a88 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x0000000188bf936c _pthread_wqthread + 1452
2   libsystem_pthread.dylib         0x0000000188bf8db4 start_wqthread + 4

Thread 3:
0   libsystem_pthread.dylib         0x0000000188bf8db0 start_wqthread + 0

Thread 4:
0   libsystem_pthread.dylib         0x0000000188bf8db0 start_wqthread + 0

Thread 5:
0   libsystem_kernel.dylib          0x0000000188b36a88 __workq_kernreturn + 8
1   libsystem_pthread.dylib         0x0000000188bf936c _pthread_wqthread + 1452
2   libsystem_pthread.dylib         0x0000000188bf8db4 start_wqthread + 4

Thread 6 name:  com.apple.uikit.eventfetch-thread
Thread 6:
0   libsystem_kernel.dylib          0x0000000188b1816c mach_msg_trap + 8
1   libsystem_kernel.dylib          0x0000000188b17fdc mach_msg + 72
2   CoreFoundation                  0x0000000189b15cec __CFRunLoopServiceMachPort + 192
3   CoreFoundation                  0x0000000189b13908 __CFRunLoopRun + 1132
4   CoreFoundation                  0x0000000189a42048 CFRunLoopRunSpecific + 444
5   Foundation                      0x000000018a550b1c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 304
6   Foundation                      0x000000018a57160c -[NSRunLoop(NSRunLoop) runUntilDate:] + 96
7   UIKit                           0x000000019038ac7c -[UIEventFetcher threadMain] + 136
8   Foundation                      0x000000018a64e50c __NSThread__start__ + 1024
9   libsystem_pthread.dylib         0x0000000188bfb860 _pthread_body + 240
10  libsystem_pthread.dylib         0x0000000188bfb770 _pthread_body + 0
11  libsystem_pthread.dylib         0x0000000188bf8dbc thread_start + 4

Thread 7 name:  com.apple.NSURLConnectionLoader
Thread 7:
0   libsystem_kernel.dylib          0x0000000188b1816c mach_msg_trap + 8
1   libsystem_kernel.dylib          0x0000000188b17fdc mach_msg + 72
2   CoreFoundation                  0x0000000189b15cec __CFRunLoopServiceMachPort + 192
3   CoreFoundation                  0x0000000189b13908 __CFRunLoopRun + 1132
4   CoreFoundation                  0x0000000189a42048 CFRunLoopRunSpecific + 444
5   CFNetwork                       0x000000018a22fcec +[NSURLConnection(Loader) _resourceLoadLoop:] + 336
6   Foundation                      0x000000018a64e50c __NSThread__start__ + 1024
7   libsystem_pthread.dylib         0x0000000188bfb860 _pthread_body + 240
8   libsystem_pthread.dylib         0x0000000188bfb770 _pthread_body + 0
9   libsystem_pthread.dylib         0x0000000188bf8dbc thread_start + 4

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x0000000170246c30   x1: 0x0000000170246c30   x2: 0x0000000000000008   x3: 0x0000000188b7c250
    x4: 0x0000000100e099a4   x5: 0x0000000100df14f8   x6: 0x0000000000000065   x7: 0x0000000170287c78
    x8: 0x000000059480bea8   x9: 0x0000000ffffffff8  x10: 0x0000000000000001  x11: 0xbaddc0dedeadbead
   x12: 0x0000000000000177  x13: 0x0000000000000177  x14: 0x0000000100be6a30  x15: 0x0000000000000000
   x16: 0x0000000100e19b54  x17: 0xb000000000000003  x18: 0x0000000000000000  x19: 0x0000000000000000
   x20: 0x0000000100e94060  x21: 0x00000001ae195ef8  x22: 0x000000017046cf40  x23: 0xb000000000000003
   x24: 0x0000000000000000  x25: 0x0000000000000000  x26: 0x0000000000000004  x27: 0x0000000100be6a30
   x28: 0x0000000170246c30   fp: 0x000000016fd46b60   lr: 0x00000001000c4d88
    sp: 0x000000016fd46870   pc: 0x0000000100e19b6c cpsr: 0x20000000

I am getting EXC_BAD_ACCESS(code=1, address=...) in ResponseSerialization.swift (line 159)
           (queue ?? DispatchQueue.main).async { completionHandler(dataResponse) }

same as
https://github.com/Alamofire/Alamofire/issues/1637

By default, frameworks integrated using CocoaPods get an optimization level of -O, whereas Swift apps now default to -O -whole-module-optimization. Perhaps this mismatch is causing issue? I make all of my pods have whole module optimization by using this post install hook:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      if config.name != 'Debug'
        config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Owholemodule'
      else
        config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Onone'
      end
    end
  end
end

Let us know if this fixes the issue for you.

Finally was same of https://github.com/Alamofire/Alamofire/issues/1637
I solved it by setting the Release optimization level to same as the main target (Fast, Single-File Optimization)

Hi @adrimarti I think I have the same issue. Where do you set the Release optimization level? Thanks

Hi @Tindi
Inside XCode>project settings>Build Settings. Try to find the keyword 'optimization'.
Then change the value for key 'Optimization Level'>'Release'. You have to put the same level in your project target and in the module Alamofire.
For testing that it works correctly run your app with 'Release' scheme (same as when it is uploaded to AppStore).

I am experiencing the same issue but only with a really small % of mu app users. Tested setting the optimizatiob level to the same as main target to Fast, Single-File and Whole module optimization without any success. Any other workaround?

Hi @adrimarti seems to be working for me. Thanks!

We are experiencing this issue too, in Objective-C project. Changing Optimization Level didn't worked for us.

This did not work for us either.


test(network): add db executor tests

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

Current dependencies on/for this PR:

main

PR #1653   👈

This stack of pull requests is managed by Graphite.


Linux

It is possible to make the user chose the path for elden ring? It will permits to steamdeck users to use your launcher (and maybe if you can, make the launcher chose the elden ring's linux folder automatically like on windows)

Hi, I have just uploaded the 1.1.0-alpha release which features a settings page where you can manual specify your elden ring and mod engine 2 paths if you want.
If you decide to give it a try can you let me know how it goes, thanks.

I tried installing this on SteamDeck but I did not manage to start the game with launcher.
Installation went without issues using Steam compatibility on MSI file.
I was able to start the launcher and configure the Elden Ring patch including ModEngine2:

There is a slight issue on "/" and "\" only for ModEngine2 patch.
After that I was able to install the mod:

And I also was able to create Profile with the mod:

After this point whenever I tried to run the game, I would get an error that EldenRing directory was missing in Roaming.
Knowing that there is a Roaming directory only that Launcher was searching in the wrong place, I created a Link to the EldenRing:
/home/deck/.steam/steam/steamapps/compatdata/3367110768/pfx/drive_c/users/steamuser/AppData/Roaming/EldenRing LINK TO /run/media/mmcblk0p1/SteamLibrary/steamapps/compatdata/1245620/pfx/drive_c/users/steamuser/AppData/Roaming/EldenRing
3367110768 is the Metis Mod Launcher id.
1245620 is the Elden Ring id.
This bypassed the missing EldenRing in Roaming error.
Now whenever I try to run the game with the Launcher by pressing Play in Profile, the Launcher immediately pops up a window telling me that it is waiting for Elden Ring to exit and after 1 second that popup window disappears.
Not sure what else I can do here...
I even tried to create a direct shortcut to the Profile in SteamLibrary:

But starting this it is telling me that the Profile does not exist which is obviously wrong message:

Profile ID:

I managed to start Elden Ring Reforged directly with ModEngine2 with this https://github.com/Cloudef/ModEngine2/releases
Even Steam Cloud works normally.

I expect this issue is due to the SteamDeck having a very specific AppData setup in Windows.
I would really like to get this working but I don't own a steam deck so it's almost impossible to test.
I will add an option to specify the Elden Ring Roaming Saves folder and another folder where you want to store profile data if you can't use appdata (like steam deck).
But unfortunately I won't be able to test it so I can't promise it will work.

If you have time, you could replicate this with any Linux OS that supports Steam and Proton. Steam Deck is not specifically needed.

I will add an option to specify the Elden Ring Roaming Saves folder and another folder where you want to store profile data if you can't use appdata (like steam deck).

That sounds great! Lets see if that will help us.
So the MML saves the profiles in AppData on Windows? Where exactly? Maybe I could create another temporary symbolic Link until you throw out a new release.

%localappdata%\Metis Mod Launcher
It's where the app stores anything it needs like temp files, imported mods and save games.


Program crash, probably parsing issue

Hi, so I am getting this errors. It seems to be some parsing error, so maybe you need  more error checking but I might be wrong.  I used llama2 13b gguf

start_game("London, 1660")
You are in your room in the Lamb and Flag Inn. Behind you is a window. Ahead of you is a door to the hallway. To your left is a desk and the bed. On the desk is your rapier. To your right is a dresser and the fireplace.
Scene('lamb_and_flag_room_1', behind=[WallFeature('window', width=1)], ahead=[WallFeature('door', width=1)], left=[Feature('desk', dist_from_wall=1, width_along_wall=2, depth=1), Item('rapier', on='desk'), Feature('bed', dist_from_wall=0, width_along_wall=3, depth=2)], right=[Feature('dresser', dist_from_wall=0, width_along_wall=2, depth=1), WallFeature('fireplace', width=2)])
inventory
Inventory([(Item('pence'), 2)])
take('rapier')
You pick up your rapier.
InventoryChange([(Item('rapier'), 1)])
go('door', 'ahead')
You are in the hallway of the Lamb and Flag Inn. Behind is the door to your room. To your left is a door leading to the tavern. In front of you is the entrance to the dining room.  On the right are the stairs leading down to the basement. There is another guest here.
Scene('lamb_and_flag_hallway', behind=[WallFeature('door', width=1)], left=[WallFeature('door', width=1)], ahead=[WallFeature('staircase_up', width=1), WallFeature('hallway_door', width=1)], right=[Feature('stairs_down', dist_from_wall=0, width_along_wall=1, depth=3), Person('gentleman', at='stairs_down')])
say('Good morrow to you, sir', to='gentleman')
"And a good morrow to you as well, my dear sir."
go('door', 'left')
You are in the Lamb and Flag Inn's tavern. Behind you is the door to the hallway. To your right are two large tables with people playing cards at them. In front of you, across from the tables, is a bar with a sign that says "Bar." To your left is the door to the street and another table of men playing cards and talking. Behind the bar is a fireplace.
Scene('tavern', behind=[WallFeature('door', width=1)], right=[Feature('table1', dist_from_wall=2, width_along_wall=4, depth=2), Item('cards', on='table1'), People(3, 'adult male', at='table1'), Feature('table2', dist_from_wall=2, width_along_wall=4, depth=2), Item('cards', on='table2'), People(3, 'adult male', at='table2')], ahead=[WallFeature('fireplace', width=2), Feature('bar', dist_from_wall=2, in_front_of='fireplace', width_along_wall=4, depth=1), Person('bartender', at='bar'), Item('sign', on='bar')], left=[WallFeature('door', width=1), Feature('table3', dist_from_wall=1, width_along_wall=7, depth=3), Item('cards', on='table3'), People(3, 'adult male', at='table3')])

Traceback (most recent call last):
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1232, in
main()
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1228, in main
curses.wrapper(lambda stdscr: curses_main(stdscr, inference_proc))
File "/usr/lib/python3.10/curses/init.py", line 94, in wrapper
return func(stdscr, *args, **kwds)
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1228, in
curses.wrapper(lambda stdscr: curses_main(stdscr, inference_proc))
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 1191, in curses_main
state.handle(inference_proc.get_last_object(), '\n'.join(inference_proc.get_last_messages()))
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 810, in get_last_object
return next(self.get_last_objects(), *default_arg)
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 803, in get_last_objects
obj = self._eval(lines[i])
File "/giant/APPS/AI/textadventure/llama-journey/game.py", line 748, in _eval
return eval(code, {'builtins': {}, **self._eval_globals})
File "", line 1, in
TypeError: Feature.init() got an unexpected keyword argument 'at'

Yes, I could see that. It looks like this occurred when you moved through a door or something? Do you mind trying again and seeing if this happens consistently? The model should generally be constrained to valid outputs, but it's not perfect and I do see the occasional crash. The catch-all would be a retry mechanism but I haven't implemented that yet.


Add indexing to kinm

We have found that field selectors don't work very well when there are a lot of objects. We list all the objects from the database and process them in code. Based on the number of objects, this can hurt performance.
Based on an "offline" conversation:
Each field selector should be a column in the database. This column should be a nullable string. The WHERE clause should return objects who column value is NULL as well as those that match the string. This is for migration purposes: the code will still filter out any objects that don't have this column set and whose field selector value doesn't match.
Don't index these columns by default. The WHERE clause on the column may be enough to get the performance increase we need.
We use an interface to do field selectors. Add a method to this interface to indicate which columns should be indexed. Then the indexes can be added when the database is migrated on startup.

@ibuildthecloud said he was going to do this. Maybe he delegated it to you donnie, but I think my convo with him was more recent than this issue.


Options for a failure trial

Short summary about the issue/question:
Extend options for a failure trail during tuning.
Brief what process you are following:
Possible options:

retry_on_failure (currently behavior);
skip_on_failure: ignore this point and never retry this point again if it fails;
default_value_on_failure=xxx: report xxx (as default value) to nni once a trial point fails. (Different with case 2 because case 2 doesn't report result on a failure point to nni)

If case 3 is not easy to express in config.yaml, this style using_default_on_failure can be also recommended:
[config.yaml]
..
  on_failure: [ using_default_on_failure | skip_on_failure | retry_on_failure ]
..

[program.py]
import nni
nni.set_default_failure_result(0.0)

..

NNI itself does not have retry mechanism for now. However some underlying training services (especially OpenPAI) may do it silently, and we don't always have a way to configure their behaviour.
In next release (v1.2) we will support "add customized trial" or "clone trial", so you can retry a failed trial manually.

Looking forward to this feature

Another workaround design:
params = nni.get_next_parameter(default_result=<object>);

libso.run_cpp('int *K = NULL; *K = 0; /* segfault ... */');

This feature request will be included in v1.4

Another workaround design:
params = nni.get_next_parameter(default_result=<object>);

libso.run_cpp('int *K = NULL; *K = 0; /* segfault ... */');

Closing the issue as the "clone" feature is  in the latest release, may you try and feedback us? Feel free to reopen if it does not match your expections, thanks a lot. @ghostplant

Closing the issue as the "clone" feature is in the latest release, may you try and feedback us

What is the currently recommended approach to achieve skip_on_failure? It seems that currently if a trial fails then the tuner receives no feedback and it may feel the need to keep trying the same hyperparmeters again and again. If the failure is deterministic then this can lead to an infinite loop where the tuner will keep trying the same parameters and failing indefinitely. Should we wrap the entry-point in a try-except that reports +/- inf depending on whether we're min/max'ing, respectively?

@arvoelke in the previous release, we supported clone and add customized trial which could deal with temporary failures (can be easily fixed by retry). As you pointed out, some failures are induced by the trial itself (e.g., out of memory, shape mismatch). In this case, it may be better to provide two options to users: using pre-configured default value, fail silently (the current behavior), as suggested by @ghostplant .


Added more sample data

Added 5 questions relating to CS2103T

Pull Request Test Coverage Report for Build 1002

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 87.409%

Totals

Change from base Build 998:
0.04%

Covered Lines:
2770

Relevant Lines:
3169

💛  - Coveralls


Fixes issue #9

output file is created but its empty(0.0Kb)
-Add WRITE_EXTERNAL_STORAGE permission
-Rename video file at time of video stopping with current timestamp and verifies it exists
https://github.com/googlesamples/android-Camera2Video/issues/9

Signed the CLA

This sample has been migrated to a new location (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Repackaging Box

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Will raise a new PR for the same


If-Match Header / ETAG Support for Weak Comparison

We currently use HAPI FHIR RestClient. Our server sends ETAGs in the form W/"123" so according to https://tools.ietf.org/html/rfc7232#section-3.1 a Weak Comparison should be used. The (HAPI)client always sends an If-Match Header without the leading W/ so the comparison never succeds. We solved the problem with an custom interceptor, but it would be nice to have support for this directly build into HAPI.

This behavior is also relevant to us. Contrary to what the docs say, the If-Match header that is being sent by the HAPI BaseClient is a strong ETag. In my opinion, it should be sending a weak ETag (starting with W/).

For those that are facing the same issue: Here is an example Client Interceptor that prefixes the ETag with W/. Don't forget to register this interceptor using something like client.registerInterceptor(new ETagWeakifyingInterceptor());!
@Interceptor
public class ETagWeakifyingInterceptor {

    private static final String IF_MATCH_KEY = "If-Match";

    /**
     * Prefixes the If-Match header value with `W/`
     *
     */
    @Hook(Pointcut.CLIENT_REQUEST)
    public void outgoingRequestModifier(IHttpRequest theRequest) {
        List<String> headerValues = theRequest.getAllHeaders().get(IF_MATCH_KEY);
        if (null == headerValues) {
            // nothing to add -> return
            return;
        }
        String ifMatchHeaderValue = headerValues.get(0);

        if (!ifMatchHeaderValue.startsWith("W/")) {
            ifMatchHeaderValue = "W/" + ifMatchHeaderValue;
            theRequest.removeHeaders(IF_MATCH_KEY);
            theRequest.addHeader(IF_MATCH_KEY, ifMatchHeaderValue);
        }
    }
}


draft 1: videomoderation support

update(dependencies): Deps for Aws S3 (aws-sdk)
update(dependencies): Deps for Aws Rekognition (aws-sdk)
update(config): Config updated to include params for Aws Video Moderation
feature(database): Jobs Table for queued moderation jobs
feature(db): Proxy can internally ADD/DEL jobs or update/query their status
feature(aws): Support for Video moderation via Rekognition
feature(aws): Exponential back off for rechecking job completion status
feature(aws): Concurrent Queues via semaphores for AWS S3 and Rekognition jobs
feature(aws/messages): Labels and confidence extracted from Video moderation output
feature(aws/errors): All AWS errors are handled with granularity in one place
feature(aws/errors): AWS errors will signal remote or local issues
feature(storage): Generic storage provider
feature(s3): Storage provider for AWS S3 implemented
feature(document): detection for document type : video/image
feature(moderation): picks up AWS Video moderation configuration if provided
feature(rpc): Makes the decision to queue a Video job and add it to db
feature(rpc): Handles requests for jobs completed or in progress
feature(rpc/responses): Responses have failed and pending statuses added

Codecov Report

Merging #71 (1d1a0cd) into main (678f860) will increase coverage by 63.24%.
The diff coverage is 77.90%.

@@            Coverage Diff            @@
##           main      #71       +/-   ##
=========================================
+ Coverage      0   63.24%   +63.24%
=========================================
  Files         0        5        +5
  Lines         0      517      +517
  Branches      0      127      +127
=========================================
+ Hits          0      327      +327
- Misses        0       73       +73
- Partials      0      117      +117

Impacted Files
Coverage Δ

src/main.rs
2.85% <ø> (ø)

src/queue2/mod.rs
77.90% <77.90%> (ø)

src/cache/memory_cache.rs
56.50% <0.00%> (ø)

src/http/filters/private_network.rs
74.57% <0.00%> (ø)

src/dns.rs
78.94% <0.00%> (ø)

@SiddharthV1 - This is a good starting point. Please review the comments. The next step would be remove all unnecessary code from this branch. We can then meet and talk about full integration.

Closing as this feature is being redone as per a new roadmap, will revisit if required.


Lag

This server works, but there's some lag though. When i point to the right with my mouse it takes about a second to go right for the cell (I live in europe). It's just like when you are in an asian agario server, while you live in europe.

It's surely something to do with the packet handler.

What's the problem exactly?

I have no idea.
Try moving this line to run before everything else in the process function, it might do something

If you have wrote loads of new codes, this could make lag.

How big was everyone and what max cells were they?
What do you use to host the server?
Check internet download mbps?

Even default servers give lag. Any server.

I was alone on the server. It's not the bots, because even without bots it lags, the bots spawn with 132 mass. I myself start with 180 mass.
Maybe this could be the problem, i use codeanywhere.com, that site itself is also laggy as hell.
Internet Mbps is fine just as Upload speed & ms.

@ShRules Codeanywhere isn't a very good host

Try using the server on your pc.

@ShRules Get a better server. But multiogar-edited is also not very optimized. And @Luka967 is right that the packets are not very optimal.  The sizes of the packets should be precalculated, currently, it uses a dynamic buffer (https://github.com/Barbosik/MultiOgar/blob/master/src/packet/BinaryWriter.js). My system pre calculates the size and so is over twice as efficient. (https://github.com/AJS-development/OpenAgar/blob/master/source/modules/FastBuffers.js)

@ShRules Use something other than codeanywhere to host. For me the server works just fine when hosting from my pc, I never experience any delay

@Megabyte918 worked! But how can i use skins? I can only see other players their skins. When i use  (for example) it doesn't work.

@ShRules Miniclip has patched skins on private servers through their client months ago.

Unfortunately


WIP: Update knative 1.2

Updating to the new Knative 1.2 version (backed by the Serverless Operator 1.23)
I guess I have no JIRA, but I can create on.

Updates to Eventing Core, from 1.1 to 1.2 but just core (no IMC /MT Broker)
Updates to KnativeKafka from 1.1 to 1.2
Make use of the proper external.topic annotation in the code

Are you somewhere pointing to the midstream branch of the serverless operator? If so, that should change to point to the 1.23 branch

Are you somewhere pointing to the midstream branch of the serverless operator? If so, that should change to point to the 1.23 branch

We install the serverless operator on the dev and stable cluster manually

Currently the "Knative Manifests" are manually copied over. Do you plan to at least get some "download" script that downloads the bits and places them to the knative/resources folder?

IMO this PR gives an impression on how to move forward

@matzew I think we are good to go with this, wdyt?


Utf8 valid arm64 neon

Successfully implemented ARM optimization analogous to AVX2 vectorization, following the methodology outlined in the research paper (arxiv.org/pdf/2010.03090)

Validation: All test suites executed successfully
Performance Metrics: Achieved up to 9x performance improvement in optimal scenarios

Benchmark Results
Environment

OS: darwin
Architecture: arm64
Package: github.com/segmentio/asm/utf8
CPU: Apple M1 Pro

Results Table

Test Case
Implementation
Operations
Time (ns/op)
Throughput (MB/s)

1kValid
NEON
10,070,200
106.4
9,626.33

1kValid
Stdlib
1,334,408
902.9
1,134.08

1MValid
Stdlib
1,298
919,417
1,140.48

1MValid
NEON
10,000
103,341
10,146.78

10ASCII
NEON
239,135,683
5.061
1,975.71

10ASCII
Stdlib
316,728,998
3.795
2,634.98

10Japan
NEON
36,628,311
32.49
923.25

10Japan
Stdlib
41,826,722
28.29
1,060.37

small0
NEON
272,401,705
4.407
-

small0
Stdlib
545,493,081
2.196
-

small4
NEON
180,697,672
6.591
606.89

small4
Stdlib
346,882,966
3.473
1,151.63

small8
Stdlib
195,698,066
6.160
1,298.67

small8
NEON
131,638,969
9.150
874.36

This is fantastic!
Unfortunately I don't have permissions to merge on this repository anymore, but maybe @kevinburkesegment can give a hand?

@achille-roussel
Thank you, I would like to help the project.
But I need to refactor my code. Also, I don't know which license I should specify. This is my first experience in open source

The project is published under MIT license, so your contributions to it will be licensed the same way, there are no other actions needed on your end.

@kalamay
I made the changes. Do I need to do anything else?
Also, I could make more optimizations if there are any suggestions.

Hi @AndreyyTs, I'm trying to set aside some time to figure out why this is impacting our builds on the amd64 targets, but I just haven't quite had a free moment! I'll get to take a more detailed look this week.

@kalamay Hi, did you manage to watch it?

So I've dug into a bit more, and it looks like the issue is with the use of go version 1.18 as a minimum version. It seems to lack definitions for some of the NEON instructions you are using. In this case, the first instruction that is unrecognized looks to be ADR in utf8/valid_arm64.s on line 112. To be clear, this isn't that the code is wrong, it's that the go compiler version doesn't recognize it. This has been an issue we've hit in the past, especially when targeting ARM.
You can see a few more details here: https://github.com/segmentio/asm/actions/runs/11741614998/job/33625198406?pr=87
There's generally two ways around this. We can bump up the minimum version, but we need to figure out which version to target. This also needs to be considered, as this does then have downstream affects on minimum versions. Do you have an idea what version you were using when developing this?
The second way around this is to directly encode the instructions as binary instead of using assembly mnemonics. For example, I've does this in our base64 here: https://github.com/segmentio/asm/blob/main/base64/encode_arm64.s#L59

@kalamay
Hello I used Go version 1.23


Fix for crash if connection lost during synchronize

Apparently this is actually just a NullPointerException the client should recover from fine.
But this should make the output less frightening.


@conda-forge-admin, please re-render

@conda-forge-admin, please re-render.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/scine-utilities-python-feedstock#9.


Error when subtracting with double number

issue when two double number are subtracted

That's just how floating point arithmetic works (and that's why you should never use floating point for storing something like amount of money). See https://floating-point-gui.de/ for more detailed explanations.

oh... i got it, because decimal decimals cannot be perfectly converted into binary


streamline script outputs

Issue
Users run into unfriendly messages from the cli interface such as in issue #353.
Cause
When the user enters unexpected commands or parameters, there is no code to handle those cases.
Solution
Add code to handle exceptions and introduce helpful error messages.

Let's pay attention to whether this gives 'doubling up'/debug output on the ""⏲ This could take a minute or so." message.

Tested the scripts and errors locally, nice

This is a weird one, though. From warcli cluster teardown:
W0820 10:27:24.114029   79378 main.go:291] Unable to resolve the current Docker CLI context "default": context "default": context not found: open /Users/matthewzipkin/.docker/contexts/meta/37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f/meta.json: no such file or directory

This is a weird one, though. From warcli cluster teardown:

I'd like to punt on this and open an issue.

YAML fixes this.


Confirm median is being correctly calculated

I believe these commits fix the median issue:
dc9a3c3c703f66270a683ef7a6faa00b771aca59
1b001b09e2d8fc1b9872df896e7f3e6c662d1119
8f82c1fa862e091ce52466224769f93875c84c3d
And this commit in bq2geojson fixed a  bug where the start and end dates for any given month were slightly off, causing Piecewise to return incorrect data and median values were duplicated:
m-lab/bq2geojson@f0af66040a1152a2ad73ea90d5aeeb711176b6ec

@nkinkade have these commits been merged into master? if not, let's issue a pull request and merge them in.

Yes, all those commits are in master.  Since I've been the only person working on piecewise, I've been working directly on master.


[+] Added document metadata to the summary node dictionary.

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #11672
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

Please fix ASAP, this would save so much time


Upgrade datadog-ci to v1.16.0, Release v0.7.0

Release version 0.7.0.
This version upgrades datadog-ci from v1.11.0 to v1.16.0 (see releases and changes).
I also replaced utils.parseConfigFile with utils.resolveConfigFromFile as the former was deprecated 3 months ago.
No docs changes.

I'm going to merge this PR as nothing has changed on the Documentation side 😉 feel free to tell me if some changes are required, I'll open another PR for it.


Simple method for changing sub-window title font

The first image below appears to me at least to have a title font that is far to large (I am using Ubuntu 24.04).
The second image shows a reduced font size but still doesn't look great to me. The code for reducing the font size for the second case is below.
A simple method call for setting the font properties would be very helpful.

let mut style: egui::Style = (*ctx.style()).clone();

style.text_styles.insert(
    egui::TextStyle::Heading,
    FontId::new(14.0, egui::FontFamily::Proportional), // Set the font size to 14.0
);

// Apply the new style
ctx.set_style(style);

egui::Window::new("THE TITLE").show(ctx, |ui| {
    ui.label("This window has a custom title font size.");
    ui.label(egui::RichText::new("I'm a heading").heading());
});

Hi!
Since the Window::new() function needs a Into<WidgetText> as an argument, you can actually pass in a RichText so you can directly modify the header's style.
Example
egui::Window::new(RichText::from("Cool window").size(20.)).show(ctx, |ui| {});

You're right. Thanks for pointing that out. Very helpful.


update policy for k3s hardened cluster

Issue:
Update policy.yaml needed with the move of the servicelb controller.

Still testing. Not ready for review.

This needs the following NetworkPolicies as well and then it seems to work:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-all-svclbtraefik-ingress
  namespace: kube-system
spec:
  ingress:
  - {}
  podSelector:
    matchLabels:
      svccontroller.k3s.cattle.io/svcname: traefik
  policyTypes:
  - Ingress
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-all-metrics-server
  namespace: kube-system
spec:
  podSelector:
    matchLabels:
      k8s-app: metrics-server
  ingress:
  - {}
  policyTypes:
  - Ingress
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: default-network-dns-policy
  namespace: kube-system
spec:
  ingress:
  - ports:
    - port: 53
      protocol: TCP
    - port: 53
      protocol: UDP
  podSelector:
    matchLabels:
      k8s-app: kube-dns
  policyTypes:
  - Ingress

The only thing that doesn't work in this case are NodePort Services and some Ingress workloads. However, those are easy to make work using NetworkPolicies like the following. I'm not opposed to adding these to the default namespace in our automation, but in our docs we should mention that these should only be applied as needed.
# For NodePorts, apply to the namespace and with the port being exposed (example with port 8080)
kind: NetworkPolicy
apiVersion: networking.k8s.io/v1
metadata:
  name: allow-external-8080
spec:
  podSelector: {}
  ingress:
  - from: []
    ports:
    - port: 8080
# For Ingress, apply to the namespace where the Ingress was receiving "Bad Gateway" error
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: ingress-to-backends
spec:
  podSelector: {}
  ingress:
  - from:
    - namespaceSelector:
        matchLabels:
          kubernetes.io/metadata.name: kube-system
      podSelector:
        matchLabels:
          app.kubernetes.io/name: traefik
  policyTypes:
  - Ingress

It would be nice to keep the hardening steps in sync across CI/QA/Docs. I would propose that the QA tests use the policies and test pods added for the hardened cluster test in https://github.com/k3s-io/k3s/pull/6320 (for 1.25; another PR will be opened soon for 1.24 and earlier). I am going to update the K3s docs to match these soon.


Remove test that checks wildly varying system-dependent value

What does this PR (Pull Request) do?

[x] This PR is not related to any Issue

This PR removes a test from Traffic Monitor that was checking that the machine running the tests was using more than 1MiB of memory - as that was fairly unreliable (particularly when running in GitHub Actions).
Which Traffic Control components are affected by this PR?

Traffic Monitor
CI tests (indirectly)

What is the best way to verify this PR?
Notice that the tests all pass in GHA checks
The following criteria are ALL met by this PR

[x] This PR includes tests
[x] Documentation is unnecessary
[x] An update to CHANGELOG.md is not necessary
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ezelkow1 Since you authored this test, do you have any thoughts on removing it?

@ezelkow1 Since you authored this test, do you have any thoughts on removing it?

@ezelkow1 Since you authored this test, do you have any thoughts on removing it?

I did not author this test, I would ask @rob05c

@ezelkow1 Since you authored this test, do you have any thoughts on removing it?

I did not author this test, I would ask @rob05c

Ah, gotcha. My mistake, I misremembered.

Ah, gotcha. My mistake, I misremembered.

Yeah, I requested his review, which should (hopefully) get his attention

Yeah, I requested his review, which should (hopefully) get his attention

It's been a while, but I think this was just added to make sure the code to get system data worked. I don't think there was a bigger reason or issue than that.
I won't object to its removal.
Though I do disagree with the characterization of "system has more than a megabyte of memory" as "wildly varying system-dependent"

It's been a while, but I think this was just added to make sure the code to get system data worked. I don't think there was a bigger reason or issue than that.
I won't object to its removal.
Though I do disagree with the characterization of "system has more than a megabyte of memory" as "wildly varying system-dependent"

Well the value is wildly varying, but whether or not it varies above 1MiB is not very wild at all, to be sure.

Well the value is wildly varying, but whether or not it varies above 1MiB is not very wild at all, to be sure.


[CI]Fix worker set offline

Why is this PR needed?
During the upgrade test, the worker is rebooted to update the operating system. In some cases, this causes the worker to be set ofline and the job to fail.
Fixes https://github.com/SUSE/avant-garde/issues/2004
What does this PR do
Waits for the jenkins client service to become ready after the reboot.
Anything else a reviewer needs to know?
Tested in this job https://ci.suse.de/view/CaaSP/view/v4.5 Dashboard/job/caasp-jobs/job/e2e/job/v4.5/job/vmware/job/upgrade-from-4-2-daily/64/
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

I rebased in on top of master once #1388 was merged


ISPN-14787 Remove Spring5 and Spring Boot 2 support

https://issues.redhat.com/browse/ISPN-14787

Merged, thanks


no way to connect to database

How do i include the name of the databse because otherwise it cant connect to it
thanks

In config.php file, you have use your database information. There is also a demo Database which you need to import in your database using phpMyadmin or others program.


Expose logging to user (dev feature?)

Allow user to view and export logs. If app does not have much built in logging- make that

Not planned? Not even for dev feature?  Choosing not to implement something like this means the community has a harder time reporting bugs and doing troubleshooting.  Remember the app is open source.  It's difficult to participate in an open source effort if one can't see logs


Enable velocity control and write calibrations as pbs

This is a two part commit.

Switches the calibration storage system to use protobufs
Finishes off velocity control with gains for small motors

This PR should resolve #31 save for the testing/validation.


Unknown video renderer value:  opengl

Fatal Error
Unknown video renderer value:  opengl
The game won't lunch because of this bug, tried finding solutions but found nothing.
Windows 10
Home Edition (unactivated)
64bit

Try a reboot or switching the options in /save/preferences.ini VideoRenderers=

Try a reboot or switching the options in /save/preferences.ini VideoRenderers=

Tried rebooting and switching the options including installing the newest version of the game and the error is still appearing.

Under normal conditions this error occurs when d3d or RageDisplay in general cannot initialize the device. Other than that, this could mean that you are missing drivers for opengl for some odd reason.
You could try an older version of the game to see if there is any difference.

You could try an older version of the game to see if there is any difference.

Which older version pacifically (I cant spell sometimes)￼ like the multiplayer releases or one of the pre-releases.

anything older than like .69 https://github.com/etternagame/etterna/releases

okay installed .69 and it still crashes, but now it crashes with a crash log
Etterna0.69.0 crash report (build )
Crash reason: Access Violation
Thread: Main thread
RageFileDriverDirectHelpers.cpp:165 F:/Games/Etterna/Save/Keymaps.ini
RageFileDriverDirectHelpers.cpp:165 F:/Games/Etterna/Logs/log.txt
RageFileDriverDirectHelpers.cpp:165 F:/Games/Etterna/Logs/info.txt
RageFileDriverDirectHelpers.cpp:165 F:/Games/Etterna/Logs/userlog.txt
RageFileDriverDirectHelpers.cpp:165 F:/Games/Etterna/Logs/timelog.txt
debug resource file 'F:\Games\Etterna\Program\Etterna.vdi': CreateFile failed (The system cannot find the file specified.).
Static log:
Etterna0.69.0
(build )
Log starting 2021-04-25 09:58:52
Verbosity: 1
Windows 6.2 (Win8) build 9200 []
WARNING: RegOpenKeyEx(80000002,HARDWARE\DEVICEMAP\Scsi) error (The system cannot find the file specified.)
WARNING: Selected theme '_fallback' not found.  Trying Theme preference default value '_fallback'.
WARNING: Theme preference defaults to '_fallback', which cannot be used.  Trying DefaultTheme preference 'Til Death'.
Attempting to connect to: multi.etternaonline.com, Port: 8765
Server Version: 0
Video renderers: 'd3d, opengl'
Current renderer: Direct3D
Current renderer: Direct3D
Partial log:
00:03.588: Video card has changed from  to NVIDIA GeForce GT 710.  Applying new defaults.
00:03.588: Video renderers: 'd3d, opengl'
00:03.589: RageDisplay_D3D::RageDisplay_D3D()
00:03.674: RageDisplay_D3D::~RageDisplay()
00:03.690:
00:03.690: //////////////////////////////////////////////////////
00:03.690: Exception: Unknown video renderer value:  opengl
00:03.690: //////////////////////////////////////////////////////
00:03.690:
00:03.826: Current renderer: Direct3D
-- End of report

Oh and I forgot to say that I updated my graphics drivers because they were 6 months out of date

Hello?

At this time I do not have a solution. It appears your graphics card may somehow be too out of date, which doesn't make sense given this game is from 2002

@nootnoot6989 We've updated to 0.70.4 since this issue was created. I've installed it on Windows myself had have had no issues. Please download the latest version and let us know if you still have this issue. I'm going to close this issue, but if you continue to have trouble, please reopen it and @ mention me.

It's all good now I upgraded to a new computer and everything is working fine.
Thanks for the help though.


Collapse Context into Command

What type of PR is this?
(REQUIRED)

bug
cleanup
documentation
feature

What this PR does / why we need it:
(REQUIRED)

Which issue(s) this PR fixes:
Closes #1587
Closes #1780
Special notes for your reviewer:
(fill-in or delete this section)

Testing
(fill-in or delete this section)

Release Notes
(REQUIRED)

Quick thought: What if rather than passing (ctx.Context, cmd) to Action, Before, and After, pass a context.WithValue?  Then for example rather than calling ctx.String("<flag>") you'd use <import>.String(ctx, "<flag>").  Although this would simply be flipping storing context within the urfave/cli's context to storing package context within context.Context and may complicate unit testing.
Also, will command be passed to flag Action?  Action func(context.Context, cmd, T) error

Quick thought: What if rather than passing (ctx.Context, cmd) to Action, Before, and After, pass a context.WithValue? Then for example rather than calling ctx.String("<flag>") you'd use <import>.String(ctx, "<flag>"). Although this would simply be flipping storing context within the urfave/cli's context to storing package context within context.Context and may complicate unit testing.

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

Yeah that's what I meant.

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

Yeah that's what I meant.

Yeeeeahh I'd like to avoid that if possible 😅 I feel nervous enough about using a context.Context to track the internal relationship between a *Command and it's potential parent *Command.


fix: [P2P Distance] Split - Participants amount displayed 0.00 briefly on confirmation screen.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/47100
PROPOSAL: https://github.com/Expensify/App/issues/47100#issuecomment-2276798050
Tests

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

[x] Verify that no errors appear in the JS console

Offline tests

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

QA Steps

Open a group chat
Tap + > Split expense > Distance
Enter the start and finish viewpoints
Verify correct participants amounts are displayed without any delay

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/63f10a2f-627c-43cc-a9b7-5d5b27731de3

Android: mWeb Chrome
https://github.com/user-attachments/assets/c41bc2c1-6fdb-4ec1-8b33-789a36a9d882

iOS: Native
https://github.com/user-attachments/assets/2fafde93-03ed-411d-a9bf-8f86b8593988

iOS: mWeb Safari
https://github.com/user-attachments/assets/e661ee61-fa54-45df-a12c-1488c79e7ed2

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/480e9c2f-8a63-4be4-98b8-aa5d2d57048f

MacOS: Desktop
https://github.com/user-attachments/assets/a8522e3e-c09b-4a1c-a98c-ea83cde6f94c

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

I've created an un-revert PR.


Coverage utils

:100: % coverage utils

This is great, thank you Guilherme 👍👏 I think this is your first contribution to Hoodie, right? Are you on twitter by chance? We like giving shoutouts to new contributors :)
And regarding coverage: while we have 100% on line coverage now, some branches are not yet covered. What you can do to check it locally is to run tests and then coverage with the lcov reporter
npm test
node_modules/.bin/nyc report --reporter=lcov

then open coverage/lcov-report/index.html in your browser, it will look like this:

You can click on serialise-account.js & serialise-session.js to find out what branches are not covered. Would be great if you could get these covered, too :)

Great, I'm sorry. I did thinking only in percent. I'm doing here.

I created changes in other branch, after don't see need, closed.

Great work Guilherme 🙌 Are you on twitter?

Yep, @gpaixao. tks for the opportunity, love help.


Also allowedPaths are blocked when trying to impersonate nonpermitted users

This issue tracks a corner case for which the request coming from an user who is trying to impersonate a user/groups that cannot impersonate due to missing privileges, is denied also for paths that don't require authentication and access control.
In example they are the allowedPaths (/api, /apis, /version).
As the response is not expected (e.g. discovery clients do not) projects that use client-go may behave unexpectedly as they often call those APIs to generate cache or RESTmappers.
A possible fix as discussed with @prometherion is to proxy pass when the allowed paths are called, instead of calling the impersonation handler (here and here):
diff --git a/internal/webserver/webserver.go b/internal/webserver/webserver.go
index b28fe54..577f0d2 100644
--- a/internal/webserver/webserver.go
+++ b/internal/webserver/webserver.go
@@ -204,6 +204,9 @@ func (n kubeFilter) impersonateHandler(writer http.ResponseWriter, request *http
 	}
 }

+func (n kubeFilter) proxyPass(writer http.ResponseWriter, request *http.Request) {
+}
+
 func (n kubeFilter) registerModules(ctx context.Context, root *mux.Router) {
 	modList := []modules.Module{
 		namespace.List(n.roleBindingsReflector),
@@ -231,7 +234,7 @@ func (n kubeFilter) registerModules(ctx context.Context, root *mux.Router) {

 		sr := rp.Subrouter()
 		sr.Use(
-			middleware.CheckPaths(n.client, n.log, n.allowedPaths, n.impersonateHandler),
+			middleware.CheckPaths(n.client, n.log, n.allowedPaths, n.proxyPass),
 			middleware.CheckAuthorization(n.client, n.log, n.serverOptions.IsListeningTLS()),
 			middleware.CheckJWTMiddleware(n.client, n.log),
 			middleware.CheckUserInIgnoredGroupMiddleware(n.client, n.log, n.usernameClaimField, n.ignoredUserGroups, n.impersonateHandler),
@@ -279,7 +282,7 @@ func (n kubeFilter) Start(ctx context.Context) error {
 	n.registerModules(ctx, root)
 	root.Use(
 		n.reverseProxyMiddleware,
-		middleware.CheckPaths(n.client, n.log, n.allowedPaths, n.impersonateHandler),
+		middleware.CheckPaths(n.client, n.log, n.allowedPaths, n.proxyPass),
 		middleware.CheckAuthorization(n.client, n.log, n.serverOptions.IsListeningTLS()),
 		middleware.CheckJWTMiddleware(n.client, n.log),
 	)

As discussed this is a corner case and the fix is open for possible vulnerabilities. Not applying for now.
/cc @prometherion


Long Running Migrations | Additional Load on Cluster during Upgrade

As noted in our release notes for 21.1, there might be additional internal load in the cluster, and that the process to SET CLUSTER SETTING might take time in proportion to the amount of data in the system.
Given how sensitive customers are about the upgrade process, it may be worth calling out in our docs of this additional load during the upgrade. This may cause alarms in their systems, as operations, such as changing cluster settings, will take longer.
cc @irfansharif

@johnrk Thanks for filing. Could you also link the release note where @irfansharif described this change?

From https://github.com/cockroachdb/cockroach/commit/89781b1cd41e7913a08ba459fe63b237a90a4d6e:
    Release note (general change): Cluster version upgrades, as initiated by
    SET CLUSTER SETTING version = <major>-<minor>, now perform internal
    maintenance duties that will delay how long it takes for the command to
    complete. The delay is proportional to the amount of data currently
    stored in the cluster. The cluster will also experience a small amount
    of additional load during this period while the upgrade is being
    finalized.

@taroface, I'll take this as well since I'm working on 21.1 upgrade docs.


Correction for raw affiliation CIRAD, UMR ABSys, 34398, Montpellier, France

Correction needed for raw affiliation CIRAD, UMR ABSys, 34398, Montpellier, France
raw_affiliation_name: CIRAD, UMR ABSys, 34398, Montpellier, France
new_rors: 05kpkpg04;00n2c0309
previous_rors: 05kpkpg04
works_examples: W4210643400;W4399662915
contact: 9bd27024bca39d68d1f1e91524214a77:e04dfb42000cd0038572fa80a06d9dc63af0 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Add TestKit#getSnapshot [ECR-3216]

Overview
Add TestKit#getSnapshot, replace TestKit#withSnapshot with TestKit#applySnapshot and make TestKit#withSnapshot accept Consumer<Snapshot> snapshotFunction as a parameter.

See: https://jira.bf.local/browse/ECR-3216
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage decreased (-0.02%) to 85.377% when pulling e0e419c6978cd57a5a26f4b0884f1e5f7295b1a3 on ECR-3216 into 6096a0b6bb349c5d2c96a7ac4ba6108b524b6755 on master.


Not actually a wiki

Docs is a more accurate word

Oh, I'm not sure if the name will get picked up where it's being referenced (sidebar, top nav) by the # or if that requires a separate change somewhere.

From a quick scan through the search results it looks like config/navigation.txt and pages/introduction.md might need to be updated in concert?

@sonyagreen @lurch
In this particular case I went ahead and fixed the mentioned issue (won't normally push onto other people's PR, but here it felt appropriate to fix up the uncovered errors, let me know if I'm wrong!

pages/introduction.md updated
in the navigation.txt one can just remove the page name (see change), and then it will be pulled from the actual markdown file. For most pages that should be the default, unless we want to prevent overflow in the navigation.

LGTM


Click on Static Modal Backdrop Scaling up the Modal Content and Adding Scrollbar to Backdrop

Using Bootstrap 4.4.1, I am facing an issue on clicking outside of static backdrop modal. As you can see in attached image when clicking outside of modal it is scaling up the size of Modal Content and eventually adding scrollbar to the backdrop. I have test this on Chrome and Firefox and same issue is happening. Can you please let me know how to stop this?
Here is the image link

`

  <button type="button" class="btn btn-primary" data-toggle="modal" data-
    target="#staticBackdrop">
   Launch static backdrop modal
  </button>

Modal title

    <button type="button" class="close" data-dismiss="modal" aria-label="Close">
      ×
    </button>

    ...

    <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
    <button type="button" class="btn btn-primary">Understood</button>

`

I find a fix on Stackoverflow which is working
   .modal.modal-static .modal-dialog {      -webkit-transform: none !important;      transform: none !important;     }

demo: https://codepen.io/fellows3/pen/gOpRebZ


Request textDocument/documentHighlight failed.

Extension Version:0.4.5
VS Code Version:1.15.0
OS Version:win10  15063.540
Node.js Version (result of command node -v):8.3.0
NPM Version (result of command npm -v):5.3.0

Steps to Reproduce:
when i type ctrl+shift+p  then  pick color
Log (All lines):
(Click menu of VS Code "Help > Toggle Developer Tools", and click "Console" tab)
Not a Valid CSS selector
e.onUnexpectedError @ workbench.main.js:29
(anonymous) @ workbench.main.js:29
e.onUnexpectedExternalError @ workbench.main.js:28
t.onUnexpectedExternalError @ workbench.main.js:28
(anonymous) @ workbench.main.js:28
v @ workbench.main.js:28
enter @ workbench.main.js:28
_run @ workbench.main.js:28
_error @ workbench.main.js:28
v @ workbench.main.js:28
enter @ workbench.main.js:28
_run @ workbench.main.js:28
_error @ workbench.main.js:28
(anonymous) @ workbench.main.js:28
done @ workbench.main.js:28
v @ workbench.main.js:28
enter @ workbench.main.js:28
_run @ workbench.main.js:28
_error @ workbench.main.js:28
e.resolveErr @ workbench.main.js:28
f @ workbench.main.js:28
_combinedTickCallback @ internal/process/next_tick.js:67
_tickCallback @ internal/process/next_tick.js:98
workbench.main.js:29 [Extension Host] Start child process...
workbench.main.js:29 [Extension Host] Check version of: electron-prebuilt
workbench.main.js:29 [Extension Host] Check version of: comma-separated-values
workbench.main.js:29 [Extension Host] Check version of: js-yaml
workbench.main.js:29 [Extension Host] Check version of: process-bridge
workbench.main.js:29 [Extension Host] Try to send IPC message: 3
workbench.main.js:29 [Extension Host] Try to send IPC message: 4
workbench.main.js:29 [Extension Host] Child process disconnected
workbench.main.js:29 [Extension Host] Child process exited with code: 0

Hi @imgwho, thank you for the report.
That error "Request textDocument/documentHighlight failed" is not a message by this Color Picker extension.
That seems to be related to TS bug.
https://github.com/Microsoft/vscode/issues?q=is%3Aissue "Request textDocument"
Irrespective of the error message, if the Color Picker dialog box is not shown, your GPU driver might have a problem.
Try to specify 1 for colorHelper.disableGpu option.

@anseki  oh you are awesome !
i use this setting "colorHelper.disableGpu=1"  and it success
but i have a little another problem: can i modify shortcuts alt + c p?
because it is conflict of this extension:Git Lens
anyway  thx  a lot again~~

Yes, of course you can change the key bindings.
See:
https://code.visualstudio.com/docs/getstarted/keybindings

No reply came but I guessed that the issue was already solved, and I close this issue.


Remove text about refundable shares

I have a few simplification proposal in the text about the share so that it can also fit with lamule choices.

At lamule.ch, we do not refund the first share (but we do refund the other ones). The text that is removed can easily be part of the custom section below.
We think that the use of share is for coopérative, so we change the name from association to coopérative on this text.
We do not have a different number of share to take for the different offer, so we would like also to remove the text related to that. Again, it can easily be specified in the custom text section just below.

Let me know :-)

Thanks, I think that makes sense and remains compatible with the other ACPs using shares. 👌🏻


Feature Request: Total Energy

First of all, thank you for this wonderful API which makes life so much easier. For some implementations like eg. HA energy board a total amount of injected energy in kWh and total PV energy generated would make the implementation of the API much easier.
I guess these values are available as they are used in the SolMate App as far as I understand.

would agree that cumulative values of energy levels would be easyer and more stable for getting right energy levels via api.
(now a i'm summing energy levels with power levels via riemann sum)

total energy inject kWh

total energy solar kWh

total energy battery in kWh

total energy battery out kWh

daily energy battery in kWh

daily energy battery out kWh

Backing this request - but this should not be part of the solmate-sdk but part of the Solmates firmware and queryable by the endpoint.


Issue not reproducible on go playground.
https://go.dev/play/p/NfEhKnRBFuv
// You can edit this code!
// Click here and start typing.
package main

import (
	"bytes"
	"context"
	"encoding/json"
	"errors"
	"fmt"
	"net/http"
	"time"
)

func main() {
	client := http.Client{
		Timeout: 1 * time.Millisecond,
	}
	b, err := json.Marshal(&struct{}{})
	if err != nil {
		panic(err)
	}
	_, err = client.Post("http://google.com", "application/json; charset=UTF-8", bytes.NewBuffer(b))
	if err != nil {
		switch {
		case errors.Is(err, context.DeadlineExceeded):
			fmt.Println("server took too long!") // Expected output
			return
		}
		panic("unexpected:" + err.Error())
	}
	fmt.Println("all good :)")
}

What did you expect to see?
server took too long!

What did you see instead?
panic: unexpected:Post "http://google.com": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

goroutine 1 [running]:
main.main()
        /home/pato/src/test/main.go:29 +0x1ac
exit status 2

This is because the errors are wrapped like this:
(type:*url.Error):Post "http://google.com": context deadline exceeded (Client.Timeout exceeded while awaiting headers)(type:*http.httpError):context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Second error could easily wrap context.DeadlineExceeded

CC @neild

Reopen. CL reverted.


Add quickcheck tests to cover various ways of feeding the streaming h…

…ashers
Continuation of #7

Thanks
Please do not format my code.... next time.
I'll revert these changes myself a bit later

It was unintentional, I must have ran rustfmt from the terminal. Let me revert that.

Ok thanks

@DoumanAsh I think it was xxh64.

ah that explains why they claim it is faster


Tests are not working in Xcode 6.1 (Passed : 0/0 cases)

Well, the plugin is working as expected in the file creation (code, sample-data, description), but for some reason when I try to run the code file it outputs this:
ColorfulRabbits OR whatever name (250 Points) also tried different problems 146, 499, ... with no luck
Passed : 0/0 cases
Time   : 0 minutes 30 secs
Score  : 171.06 points
Program ended with exit code: 0
I debugged the main function's code and it seems that the argc = 1 and argv[1] = /.../Topcoder/build/TopCoder/Build/Products/Debug/TopCoder"	0x00007fff5fbffa80
so the code never enters
    for (int i = 1; i < argc; ++i) cases.insert(atoi(argv[i]));

EDIT:
tried c++11 with same results
Please, any help would be really appreciated. Thanks :)

I solved it, the problem was that Xcode is building the executable in another directory so it can't read the .sample file. If i used absolute path in the ifstream initialization line the test data will load normally.


Take Flavio dG/dq2 distribution instead of implementing our own (check if we can also use other distributions)

perhaps also in the variable w which most experimentalists use

The problem is, that in flavio this particular observable is not implemented (see observables) since dG/dq2 is the differential 3-fold 5-body differential decay rate which is quite a complicated expression given in eq. (51) of 1602.07671.
Actually I checked the whole implementation back then done by Alejandro, and we both implemented the of (A5)-(A13) individually and got the same results.

Since

one has in the notation of 1602.07671

I'm gonna close this, implementing w will be easy.


Cannot watch TypeError

After following the set-up process and adding watch-client.js to the code base, I'm unable to use /watch. I call watcher() at the end of my game loop.
Below you can find the console output from executing /watch status _.keys(Game.creeps).length with some additional information:
*** Connecting to (https://screeps.com:443/) ...
*** Now showing Screeps console. Type /help for help.
*** Cannot watch: TypeError: Cannot read property 'expressions' of undefined
        at multimeter.api.memory.get.then.val (C:\Users\XATEV\AppData\Roaming\npm\node_modules\screeps-multimeter\plugins\watch.js:40:72)
        at processTicksAndRejections (internal/process/next_tick.js:81:5)
<<< JSON.stringify(Memory.watch)
>>> {"expressions":{},"values":{}}
<<< typeof Memory.watch
>>> object
<<< typeof Memory.watch.expressions
>>> object
*** This is Multimeter 1.8.3, which is the latest version.
<<< watcher = require("./watch-client")
>>> function() {
      if (typeof Memory.watch !== "object") {
        Memory.watch = {};
      }
      if (typeof Memory.watch.expressions !== "object") {
        Memory.watch.expressions = {};
      }
      if (typeof Memory.watch.values !== "object") {
        Memory.watch.values = {};
      }
      _.each(Memory.watch.expressions, (expr, name) => {
        if (typeof expr !== "string") return;
        let result;
        try {
          result = eval(expr);
        } catch (ex) {
          result = "Error: " + ex.message;
        }
        if (name == "console") {
          if (typeof result !== "undefined") console.log(result);
        } else {
          Memory.watch.values[name] =
            typeof result !== "undefined" ? result.toString() : result;
        }
      });
    }

It seems to be working for me on my private server (tested linux and windows), however I see the same issue if I try connecting to PTR (not currently spawned on mmo main).

Tested Linux and Windows, both seem to fail when connecting to main (shard 3).

Resolved by #26

Watch plugin only appears to work with shard0 at the moment - see #32.


Clear Aromatic Flags for init_from_rdkit_mol

Related Issues: #396
Requested Reviewers: @lukasturcani, @andrewtarzia, @annabelbasford
This attempts to fix the issue when loading molecules with aromatic flags from RDKit. By removing aromatic flags, the aromatic bonds in the molecule (with bond order 1.5) are returned to alternating single and double bonds (orders 1 and 2 respectively).
Risks are that if the Kekulization method fails for a molecule, an error will be thrown by RDKit - though I think this is highly unlikely to occur in general use.

src/stk/molecular/building_block.py:.BuildingBlock._init_from_rdkit_mol(): The Kekulization method was added to the first line of this function.

Visually inspected molecule for changes. For an example, see the following code before and after the PR:
benzene = rdkit.MolFromSmiles('c1ccccc1')
rdkit.EmbedMolecule(benzene)
stk.BuildingBlock.init_from_rdkit_mol(benzene).to_rdkit_mol()

I am happy with a solution to this. Can I suggest adding some test molecules for this init function that test the issue?
I.e. defined with and without aromaticity?

I think this will incur a performance penalty, and is why this as committed. Is a warning in the docstring not enough? I'm not sure it should be the responsibility of this function to sanitize user input, especially if it comes with performance penalty.

I'm not sure a warning in the docstring is sufficient alone for this issue. At the least, I think a warning should be issued to the user that their molecular structure has changed after calling this function. It's additionally confusing because initialising the building block directly from SMILES using stk.BuildingBlock('c1ccccc1)` yields a molecule with the correct bonding.

At the least, I think a warning should be issued to the user that their molecular structure has changed after calling this function

Hmm, molecular structure should not change be changed by stk. The user should never pass a non-kekulized molecule to stk, and this should be made clear in the docstring. Therefore stk does not change molecular structure, because the user should pass in a structure that is valid. The user should Kekulize their rdkit molecule if they use stk, and the docs should be edited to make that super clear, imo.

I would argue that molecular structure is changed by stk using this function. If an aromatic molecule is loaded, you would expect that bonding to be maintained. I believe the rdkit.KekulizeFunction (with default arguments) sets the bonds orders to 1.5, so a non-kekulized molecule should be passed to this function.

But if the user loaded in an aromatic molecule, they made a mistake. If the user made a mistake, I would expect things to go wrong.
I think Kekulize sets bond orders to integers -> think the Kekule structure of benzene, it's switching between two sets of structures, each of which has integer bonds. Pretty confident, but am willing to eat my words if you send me a code snippet that proves me wrong on that count.

You're completely right about Kekulization, sorry I got it the wrong way round!
I got confused because RDKit sanitizes molecules when loading from SMILES as a default argument so all SMILES will be kekulized by default.
I think this is also the case in stk when loading a BB directly from SMILES (line 252 in building_blocks.py molecule = rdkit.AddHs(rdkit.MolFromSmiles(smiles)))

Closing this PR as made a new one in #414 with docstring edits.


Add typst

A successor to *TeX written in Rust.

Typst does look super cool (I've skimmed the homepage before), but I don't think it qualifies as a command-line utility/tool -- it's more of a "system" or even (programming) language -- and thus I'm hesitant to add it to list. Is that fair?

 Yes, of course, though it has a document generating cli. I thought it would be a good fit since it allows one to easily write papers and documents in a professional manner.
So really no worries if you think is no good fit. 😄


[Feature Request] Make detected links tappable

This is brilliant, thanks for making it.
The only small thing I'm missing vs Apple's (inferior!) native markdown support is having links detected in the text (that aren't marked up) tappable.
For example it would be great in this image if the image URL was tappable.
Thanks!

Hi @mralexhay,
Sorry for the late response. That feature is part of the GitHub Flavored Markdown Spec, and MarkdownUI supports the CommonMark Spec. That is a major change and, at the moment, I have no plans to do it.

Solved in MarkdownUI 2:
https://github.com/gonzalezreal/swift-markdown-ui/releases/tag/2.0


base_dirs are ignored after removal

Hello. Thank you for a nice extention.
I have the following config:
require("telescope").setup {
  defaults = {
    ...
  },
  extensions = {
    project = {
      base_dirs = {
        "~/dotfiles",
        "~/fzf",
        "~/neovim",
      },
    },
  },
}

require("telescope").load_extension "project"

First time I ran :Telescope project I was there three projects but after I removed them via c-d binding they are not shown after nvim restart anymore.
I can manually add them by cd'ing to every project dir, opening nvim add pressing c-a.
But how to make it respect config settings and always show every project mentioned?

It is by design (https://github.com/nvim-telescope/telescope-project.nvim/blob/master/lua/telescope/_extensions/project/actions.lua#L81=)
If you want to rebuild telescope-projects.txt, you can delete the file and on next restart of neovim telescope-projects.txt will be created using your config.

Ah, it's in $HOME/.local/share/nvim/telescope-projects.txt. Ok, thank you.


Move GetFirstBeforeTime/GetFirstAfterTime to TimerData

And add unit-tests for them
Test: build, run ClientDataTests

Only a comment. ThreadTracks has queries inside the ScopeTree, so they would work differently. Do we agree on that?


Allow overriding of CMakePresets cache variables and arguments

This change addresses item #1836.
This changes the behavior of the settings provided by the CMake extension for arguments and environments.
The following changes are proposed:

Allow various fields that modify configuration, build, and testing, to override CMakePresets environments and arguments.
Specifically, this includes the following fields that are now supported when using presets, while doing various actions

cmake.environment (any cmake command)
cmake.configureArgs (configure)
cmake.configureEnvironment (configure)
cmake.buildArgs (build)
cmake.buildEnvironment (build)
cmake.buildToolsArgs (build, but specific to the build tool)
cmake.ctestArgs (test)
cmake.testEnvironment (test)

With the above changes, we added UI notifications to ensure users are aware of when any of the above settings are possibly overriding settings from their Preset. In general, the UI will appear if they have any setting (from the above list) affecting their configurations.
Also, we added log statements that will appear in the output that will notify the user as well.

The purpose of this change
The general purpose is to allow for the settings we provide via VS Code, to be used during CMake Presets so that people can temporarily override various settings and cache variables in order to test and investigate their configuration and project set-up.
Screenshots of various functionality.
Project status view:
If there are settings set in any of the above list, the affected configuration will have a UI string to notify the user:

When there are settings that are affecting the configuration, a setting icon will appear that will open the settings to the possible settings that may be affecting the configuration:
.
This will open the settings as such:
.
Additionally, if the settings are removed, then the "override settings applied" text will be removed from the UI.
Status bar:

An * is added to the status bar if the configure preset, build preset, or test preset icons are visible and there are settings (from the above list) set.
Output pane:
There will be a simple text output that indicates that there are settings defined that may affect or override your preset configuration. This will happen for things like configure, build, test, launch, etc.
Here is an example:

@snehara99 @benmcmorran @lukka Ping for review. I'd especially like review on the various strings I've modified and added and whether the wording is good, or if I should rework some of them. This includes the strings for tooltips for the command I added, the output text in the output pane, and the text in the project status view.
Other than that, it should be a normal PR review. Thanks!


Reducing size of query subscription names

We've discussed this in person but I thought I'd make a proper proposal.
Consider the following case:
ds.record.getRecord(`search?${JSON.stringify(bigQuery)}`)

The subscription name in this case can become very large with negative impact on performance.
One way to resolve this is to replace the {JSON} part with a {HASH(JSON))} and send the JSON as a payload, somehow and on the receiving end, i.e. providers reverse it. It's possible already to implement this in user land, but it's not pretty.

This is implemented in the new search provider by using an RPC that returns a hashed value to get the record with. Not as pretty as before but it works https://deepstream.io/guides/realtime-search/doing-a-realtime-search/


Dynamic configuration of the slave IP address

i want have the function that i can config the ip or something else by myself,i think it's meaningful ,because the server can be change by oneself,so if have this function ,it will be conveniently

Hi,
Sorry, but you have to explain more in detail. The config nodes are to find under configuration tab of Node-RED.

Please htnk about that:
a) What is the problem?
b) In which case it will be conveniently?
c) Is there a real Use Case?
d) describe it in detail (Where, What, Why): "i want have the function that i can config the ip or something else by myself"

Please, reopen if you need more.

Just as flex-getter can use msg to configure address, why not allow the slave's ip address to be configured using msg?
In the actual production, some companies do cloud platform convergence equipment need to set the ip from the station to read the information, but these IP is not necessarily static, the company may change the slave IP or add a new from Station, if it is written in HTML config, each time you need to change the configuration once again ip address, this is a very troublesome thing. But if the node can read information from the file, and then use its IP and other information for dynamic configuration of this is quite comfortable, then why not let IP address can be dynamically configured?
There is a problem in your project to see the existence of the client, but ask what is not the actual node?

try v1.2.0


Put link to main download page on top of the installation guide

URL
https://qgis.github.io/QGIS-Hugo/resources/installation-guide/
On what type of device(s) did you see this bug?
No response
On which browser(s) are you seeing the problem?
No response
Other Browser
No response
Summary
Put link to https://qgis.github.io/QGIS-Hugo/download/ at the top where it's easily found

Please find the proposed fix for this at #239.
Regards.


About the result

Thanks for your nice code
Noice that the result contants two kinds of flow. One names 'bw' and the other names 'fw'.What does this mean? Which one is better?
Thank you.

'fw' is forward flow from frame t to frame t+1, 'bw' is backward flow from frame t to frame t-1


audit tags / npm versions

make sure there is a tag for every npm version

npm versions:
[ '0.0.1', '0.0.2', '0.0.3', '1.0.0', '1.0.1', '1.0.2', '1.1.0', '1.2.0', '1.3.0', '1.3.1', '1.4.0', '1.5.0', '1.5.1']
tags:
v1.0.0 v1.0.1 v1.0.2 v1.1.0 v1.2.0 v1.3.0 v1.3.1 v1.4.0 v1.5.0 v1.5.1
missing tags: v0.0.1, v0.0.2, v0.0.3

Closing since this repo is being merged into VictoryChart


Aubess_16A_MiniSmartSwitch - v1.3.10

Aubess_16A_MiniSmartSwitch_Stock_Firmware_WiFi.bin.zip

1.3.10 is already on the known patched list, serial flashing will remain the only option for this device.


[sc-9263]cloudtruth-configure-action-has-out-of-date

Updated workflow actions and fixed "GitHub Actions: Deprecating save-state and set-output commands warning"

superseded by #381


:0: error: no such file or directory: 'Rome'

I've got Carthage installed but I haven't used it enough to know what this is referring to in particular.

Fixed in change b0f08d0e978ef41ed574959680d5307823d2d5cd. Version 0.1.2 has this fixed. Thanks and sorry about that.

:+1:


Connection refused for pgsql

Sail Version:^1.0.1
Laravel Version: ^8.1
PHP Version:^8.1
Host operating system: macOS Monterey Apple M1

Description:
 SQLSTATE[08006] [7] connection to server at "pgsql" (<IP_ADDRESS>), port 5434 failed: Connection refused 	Is the server running on that host and accepting TCP/IP connections? (SQL: select * from information_schema.tables where table_catalog = example_app and table_schema = public and table_name = migrations and table_type = 'BASE TABLE')
I am getting above error when I try to migrate command (sail artisan migrate)
First, my existing project is using pgsql.. so I tried to use sail for the project.. after trying several times, I failed.
That's why I tried to setup fresh laravel with sail for pgsql.. but still getting the same error.
Steps To Reproduce:
curl -s "https://laravel.build/example-app?with= pgsql,redis" | bash
./vendor/bin/sail up
sail artisan migrate
Did I do something wrong? I tried to get solution from internet. But I didn't find any article for laravel sail pgsql

Sail Version:^1.0.1

This is a very old Sail version. I suggest you upgrade and try again.

As you said, Sail version is very old though I used latest laravel version. So, it's a pretty confusing.


Documentation on PlumbIKEv2TSAsRoutes option?

The document currently shows the PlumbIKEv2TSAsRoutes option in the tree at the top of the article but there's no explanation below on what this option actually sets on the VPN client.  Can we get more details added to the document on the PlumbIKEv2TSAsRoutes option?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c8b1b81d-3c35-0315-d149-f10af3a409b2
Version Independent ID: c34e7acb-ece7-d76f-fb41-470e19119ee0
Content: VPNv2 CSP - Windows Client Management
Content Source: windows/client-management/mdm/vpnv2-csp.md
Product: w10
Technology: windows
GitHub Login: @ManikaDhiman
Microsoft Alias: dansimp

I tried searching the entire docs.microsoft.com site for at least some information about "PlumbIKEv2TSAsRoutes", but came up with nothing:

https://docs.microsoft.com/en-us/search/?terms=PlumbIKEv2TSAsRoutes

(Sorry for making it look like a meme, but "Wow, such empty." comes to mind.)

Closing via #9468
Thank you


[Monitor]az monitor app-insights component

Fix #1154 support setting cap
Fix #1269 fix for --subscription

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/MyronFanQiu/azure-cli-extensions.git@fix-1154-1269-support-daily-cap-and-fix-sub#subdirectory=src/$EXT&egg=$EXT"


Cannot destructure a Readonly Tuple

TypeScript Version:  2.4.0
Code
// This is OK
type Tuple = [string, number]
const t : Tuple = ['string', 2]
const [s,n] = t

// This errors
// [ts] Type 'Readonly<[string, number]>' is not an array type.
// const rs: string
type ReadonlyTuple = Readonly<[string, number]>
const rt : ReadonlyTuple = ['string', 2]
const [rs,rn] = rt

Expected behavior:
No errors
Actual behavior:
Error as above

This is probably a limitation of the Readonly<> that causes it to lose the "array-ness" of the tuple type.  You can work around it as follows:
type ReadonlyTuple = Readonly<[string, number]> & [string, number];
const rt: ReadonlyTuple = ['string', 2]
rt[0] = 'zero'; // error as expected, still read-only
const [rs,rn] = rt // no error, accepts as array type

ReadonlyTuple is mapped type, destructing requires array like type.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


ProductiveRage's Optimized enumerable (when type is the same thru list)

This implements ProductiveRage's pull request #59 and adds a few cosmetic/formatting changes to the code.
fwiw, ProductiveRage's commits are being preserved unchanged in commit history.

I hope you don't mind we merging it already, but we'll keep the branch up for a few days in case you want to review.

No problem by me!

Alright, thanks for the feedback, the branch is gone now! :)


fix: Added individual sdk openrpc to the doc specification

:tada: This PR is included in version 1.4.0-next.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


onLongCLick called twice in RecyclerSwipeAdapter

when i set longclicklistener to imageview in viewholder and simple log long clicks, i noticed that onLongClick was called 2 times. In usual recycleradapter it seems fine

#106 this PR resolved issue


Added a Visual Basic book.

What does this PR do?
Add Resource
Description
It's a book about VIsual Basic.
Why is this valuable (or not)?
It's free.
How do we know it's really free?
It is hosted by the publisher itself.
For book lists, is it a book? For course lists, is it a course? etc.
It's a book.
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

please see #4898 and do that

Seems that I've fixed this.


Multiple property sources?

I am trying to use Consul to get Kev/Value pairs during the bootstrap process of my application.
The folder structure on Consul looks like:
public/service-name
private/service-name
Note that there is no config folder anywhere over here.
I can manage to get my resources as :
config/public/service-name and
config/private/service-name
But that's not what I want.
I want the prefix to be empty. It is a  nonEmpty value today. I can't override it to empty string and if I don't set it, it defaults to "config".
I am overriding defaultContext from "applications" to "public/service-name" but it prepends the prefix to it and ends up as config/public/service-name.
Is there any way to work around this problem?
My bootstrap looks like this and am trying to find workarounds to call private/service-name and public/service-name at bootstrap time.
spring:
    cloud:
        consul:
           enabled: true
           host: http://<IP_ADDRESS>
           port: 8500
           config:
                prefix: ""
                name: private/service-name
                acl-token: xxx
                defaultContext: public/service-name

Thanks
Amrish

Please learn how to properly format code and logs.

Sure. Will do. Thanks for looking into this.
So there is no workaround for specifying multiple source folders for consul today in spring-cloud-consul. Correct?

Not currently

duplicate of #303?

Would you mind if I submit a pull request for this?
Thanks,
Amrish

Anything new here?
For example prefix is config, application name is testApp
I want to get configurations from:
config/common/application.yml
config/security/application-cloud.yml
config/apps/testApp.yml
Is it possible?

Nothing new. PRs welcome