Company Communicator

We got the failed error below when trying to set up Company Communicator in our test tenant
.
There was a conflict. Conflict with existing ScmType: ExternalGit (Target: /subscriptions/08e746cf-1e01-453a-8bf1-6e3369d8a8e2/resourceGroups/CompanyCommunicatorRG/providers/Microsoft.Resources/deployments/Microsoft.Template-20230920150920)

Actually have the same issue but came one step further in deleteting the webapp and redeploying it --> I have left the rest untouched and the app deployed without any issue now BUT i have now a different issue which seems solveable in generating new GUIDs but have to test it with enother deployment run now

i had to delete the web app + change the servicebus web / storage web guid (changing the last character to a different one) and now the deployment is complete

Hi @cholman1 ,
Thank you for logging the issue. Please let us know if anything is required from our side otherwise we can make it to closure.

Ah, ok.  Can you show a example of (change the servicebus web / storage web guid (changing the last character to a different one)
From: Khiron91 @.>
Sent: Friday, September 22, 2023 4:29 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Author @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
i had to delete the web app + change the servicebus web / storage web guid (changing the last character to a different one) and now the deployment is complete
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1731108679__;Iw!!D8DunMSJ4IdR!5RiMP1gPv06yj7DhBD_bTU7dR2LMyBwkxksZqQZ2OjQfq9_MrP2bTSFd8gI9vrS9k22T97ELaNyF29pK0uCZU-bPoMnAoCNMJg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWSUSIILGJEJX2KYV7DX3VK6ZANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!5RiMP1gPv06yj7DhBD_bTU7dR2LMyBwkxksZqQZ2OjQfq9_MrP2bTSFd8gI9vrS9k22T97ELaNyF29pK0uCZU-bPoMleITjNqQ$.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

First as written you have to deleted the faulty web app
Then, select the resource group where you made your deployment and click on redeploy to your last deployment (see screenshot)

You will get some fields to get re-filled like the 3 AppIDs (User, Author, Graph) + on the bottom the GUIDs. Here you have to change the listed Storage + Service Bus Web GUIDs. it is written in HEX so i have raised the last character one letter: b-->c 1--2

after this changes my re-deployment suceeded

Hi @cholman1 ,
Since you went for re-deployment, the default GUID's has already been used for 1st deployment. When we go for re-deploy it is mandatory to change the 7 GUID's as shown above to avoid the role assignment issues. And changing a alphabet or a numeric may or may not guarantee the GUID to be valid. It is always better to choose valid generator GUID tool . Here is the reference
Please let us if you have any queries.

Hello Khiron91,
I am trying to delete the faulty web app, not sure if I did, where do I go to delete it?
Also, where can I find the second screen shot, the Guid to make the last character change?
I am learning this and this would be great if you can point that out.
From: Khiron91 @.>
Sent: Monday, September 25, 2023 12:50 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
First as written you have to deleted the faulty web app
Then, select the resource group where you made your deployment and click on redeploy to your last deployment (see screenshot)
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/124042836/270239351-42422d49-32f7-44d7-a4d2-50f1e60854ac.png__;!!D8DunMSJ4IdR!-Pa6D5tSyI4NT2-eAbPOXWiaQVl1eBT53LKKnf3W_A_6DRQ4jL7kdwDJhjAQJvZQ-bG2NizZLP_1XqK4iCnIXlANvelQ_G6kJw$
You will get some fields to get re-filled like the 3 AppIDs (User, Author, Graph) + on the bottom the GUIDs. Here you have to change the listed Storage + Service Bus Web GUIDs. it is written in HEX so i have raised the last character one letter: b-->c 1--2
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/124042836/270239708-6b16c068-1ffb-407a-b481-938b13ec2fa5.png__;!!D8DunMSJ4IdR!-Pa6D5tSyI4NT2-eAbPOXWiaQVl1eBT53LKKnf3W_A_6DRQ4jL7kdwDJhjAQJvZQ-bG2NizZLP_1XqK4iCnIXlANven5kL7pog$
after this changes my re-deployment suceeded
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1732962447__;Iw!!D8DunMSJ4IdR!-Pa6D5tSyI4NT2-eAbPOXWiaQVl1eBT53LKKnf3W_A_6DRQ4jL7kdwDJhjAQJvZQ-bG2NizZLP_1XqK4iCnIXlANvemkZG_QgQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWVT7A4B6OK22QUG37TX4ELPBANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!-Pa6D5tSyI4NT2-eAbPOXWiaQVl1eBT53LKKnf3W_A_6DRQ4jL7kdwDJhjAQJvZQ-bG2NizZLP_1XqK4iCnIXlANvelwZpdOCQ$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

On your first screenshot you have made a screenshot of the deployment center within the problematic app. This is the web app which you have to delete. The Delete Option should be available when you click in the Navigation to Overview or within the Resource Group View.
After you have deleted the web app you have to click on your Resource Group where all your stuff is in and in the Resource Group you have in the Navigation "Deployments" where you should see your Initial deployment + you have the option there on the top to re-deploy. --> this is the screenshot which i posted. after you click on re-deploy you will get the ID´s and all things.

Thank you, it has been resolved.
From: Khiron91 @.>
Sent: Wednesday, September 27, 2023 1:27 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
On your first screenshot you have made a screenshot of the deployment center within the problematic app. This is the web app which you have to delete. The Delete Option should be available when you click in the Navigation to Overview or within the Resource Group View.
After you have deleted the web app you have to click on your Resource Group where all your stuff is in and in the Resource Group you have in the Navigation "Deployments" where you should see your Initial deployment + you have the option there on the top to re-deploy. --> this is the screenshot which i posted. after you click on re-deploy you will get the ID´s and all things.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1736778439__;Iw!!D8DunMSJ4IdR!8PRAqiPiggqyGEgLN28TTkavoYJ5o3Kiyjr7CGQw8UMIPa7oY40yvnoV_dQ0m3YNGJOhEfC2Uqe1SNVbKKYWLc7a5Gexw2GUKw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWRDVRRZ4WWECM6XDU3X4PBL7ANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!8PRAqiPiggqyGEgLN28TTkavoYJ5o3Kiyjr7CGQw8UMIPa7oY40yvnoV_dQ0m3YNGJOhEfC2Uqe1SNVbKKYWLc7a5Gejd5ry4g$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

I was successful, but now adding the app to Teams I am getting the below for the Author but Users is ok. :
@.***
From: Khiron91 @.>
Sent: Wednesday, September 27, 2023 1:27 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
On your first screenshot you have made a screenshot of the deployment center within the problematic app. This is the web app which you have to delete. The Delete Option should be available when you click in the Navigation to Overview or within the Resource Group View.
After you have deleted the web app you have to click on your Resource Group where all your stuff is in and in the Resource Group you have in the Navigation "Deployments" where you should see your Initial deployment + you have the option there on the top to re-deploy. --> this is the screenshot which i posted. after you click on re-deploy you will get the ID´s and all things.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1736778439__;Iw!!D8DunMSJ4IdR!8PRAqiPiggqyGEgLN28TTkavoYJ5o3Kiyjr7CGQw8UMIPa7oY40yvnoV_dQ0m3YNGJOhEfC2Uqe1SNVbKKYWLc7a5Gexw2GUKw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWRDVRRZ4WWECM6XDU3X4PBL7ANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!8PRAqiPiggqyGEgLN28TTkavoYJ5o3Kiyjr7CGQw8UMIPa7oY40yvnoV_dQ0m3YNGJOhEfC2Uqe1SNVbKKYWLc7a5Gejd5ry4g$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @cholman1 ,
We are not able to see the issue screenshots as they are in masked state. We request you to share them here directly.

After uploading.
@.***
From: Sai Venkat @.>
Sent: Thursday, September 28, 2023 1:25 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!_580A7Bu8u60WxBeKTiDX5UxXnYPhIiJPdhvwID8n9JBmya6Bfv95gmHyexCeRzUkDMgHUQeh4U10dPQhcl2QMTfhad08t5z9Q$ ,
We are not able to see the issue screenshots as they are in masked state. We request you to share them here directly.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1738540682__;Iw!!D8DunMSJ4IdR!_580A7Bu8u60WxBeKTiDX5UxXnYPhIiJPdhvwID8n9JBmya6Bfv95gmHyexCeRzUkDMgHUQeh4U10dPQhcl2QMTfhaeC0REMxg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWQUMHQ4PTIPGP2TIJ3X4UJ5LANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!_580A7Bu8u60WxBeKTiDX5UxXnYPhIiJPdhvwID8n9JBmya6Bfv95gmHyexCeRzUkDMgHUQeh4U10dPQhcl2QMTfhae4qthHRg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @cholman1 ,
The screenshot is appearing like this. Please share it directly here

I get the first image for a quick second and then get the second one with the error.
First Screen shot:
@.***
Second Screen Shot:
@.***
From: Sai Venkat @.>
Sent: Friday, September 29, 2023 12:50 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS898_uR_w$ ,
The screenshot is appearing like this. Please share it directly here
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/98143492/271481646-bd6d8300-767d-40a5-9aec-3bedcd9d86dc.png__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS_C8Y2aSQ$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1740346742__;Iw!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS8gd5sbUw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWTPDVIBOFQJHVYPRPTX4ZOO5ANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS-RgysfNg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Ok, looks like it works in the local Client Teams but not in the Cloud Teams, does it not work for the Cloud Teams?  I was able to tested messages on the local client to a group but it failed to send to a Teams group, see below.   Any thoughts??
@.***
From: Clifford Holman @.>
Sent: Friday, September 29, 2023 11:23 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>; OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Mention @.>
Subject: RE: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
I get the first image for a quick second and then get the second one with the error.
First Screen shot:
@.***
Second Screen Shot:
@.***
From: Sai Venkat<EMAIL_ADDRESS>Sent: Friday, September 29, 2023 12:50 AM
To: OfficeDev/microsoft-teams-apps-company-communicator<EMAIL_ADDRESS>Cc: Clifford Holman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS898_uR_w$ ,
The screenshot is appearing like this. Please share it directly here
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/98143492/271481646-bd6d8300-767d-40a5-9aec-3bedcd9d86dc.png__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS_C8Y2aSQ$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1740346742__;Iw!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS8gd5sbUw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWTPDVIBOFQJHVYPRPTX4ZOO5ANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS-RgysfNg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

I am getting the below message when trying to send a message to a team.  Please see second screen shot on error received.
@.***
@.***
From: Clifford Holman
Sent: Friday, September 29, 2023 1:02 PM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>; OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Mention @.***>
Subject: RE: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
Ok, looks like it works in the local Client Teams but not in the Cloud Teams, does it not work for the Cloud Teams?  I was able to tested messages on the local client to a group but it failed to send to a Teams group, see below.   Any thoughts??
@.***
From: Clifford Holman<EMAIL_ADDRESS>Sent: Friday, September 29, 2023 11:23 AM
To: OfficeDev/microsoft-teams-apps-company-communicator<EMAIL_ADDRESS>OfficeDev/microsoft-teams-apps-company-communicator<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>Subject: RE: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
I get the first image for a quick second and then get the second one with the error.
First Screen shot:
@.***
Second Screen Shot:
@.***
From: Sai Venkat<EMAIL_ADDRESS>Sent: Friday, September 29, 2023 12:50 AM
To: OfficeDev/microsoft-teams-apps-company-communicator<EMAIL_ADDRESS>Cc: Clifford Holman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS898_uR_w$ ,
The screenshot is appearing like this. Please share it directly here
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/98143492/271481646-bd6d8300-767d-40a5-9aec-3bedcd9d86dc.png__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS_C8Y2aSQ$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1740346742__;Iw!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS8gd5sbUw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWTPDVIBOFQJHVYPRPTX4ZOO5ANCNFSM6AAAAAA5B2OZY4__;!!D8DunMSJ4IdR!9nvvS0FFVqGYUt1FZWA8eJPruTCjU-ur6hABYMUBL2CGyeL9RNe7_KtEU5l0OdtrqFOnsXj78ydqpESHu8POa-KbPS-RgysfNg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @cholman1 ,
Still the screenshots are in masked state. We recommend you to share the screenshots directly here.

Here is the images attached in this comment, unable to complete a send of a message from Company Communicator, it failes going to the Teams Group.

Just recent a attachment through the Githup open case.
From: Sai Venkat @.>
Sent: Thursday, October 5, 2023 1:08 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!6EdNXeg6xHpvDPWBpNONeb_D7pvF1qxTEwWGM8znXoCRH4E7qiPcRO3TzKmUNfEQZ_TCX7NydbzHwxjKm90UM3acWF7NFqc_pw$ ,
Still the screenshots are in masked state. We recommend you to share the screenshots directly here.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1748143510__;Iw!!D8DunMSJ4IdR!6EdNXeg6xHpvDPWBpNONeb_D7pvF1qxTEwWGM8znXoCRH4E7qiPcRO3TzKmUNfEQZ_TCX7NydbzHwxjKm90UM3acWF6R4NMvNQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWSRPEHGU3CUVLVTCATX5ZFD3AVCNFSM6AAAAAA5B2OZY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGE2DGNJRGA__;!!D8DunMSJ4IdR!6EdNXeg6xHpvDPWBpNONeb_D7pvF1qxTEwWGM8znXoCRH4E7qiPcRO3TzKmUNfEQZ_TCX7NydbzHwxjKm90UM3acWF5t1IAb7Q$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @cholman1 ,

How about other sending options?
-Please check you tenant id within the deployment section. It seems incorrect. Here is the reference.

And make sure to grant admin consent within the Graph app- API permissions.

The other sending options will not let me choose and group etc., it is not searchable.
I have verified the Tenant ID and it is correct.
From: Sai Venkat @.>
Sent: Monday, October 9, 2023 12:40 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: Clifford Holman @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Company Communicator (Issue #1149)
[EXTERNAL EMAIL]
Hi @cholman1https://urldefense.com/v3/__https:/github.com/cholman1__;!!D8DunMSJ4IdR!-PxfSJpe03-W4mnlVPXIU53CzR4Iqrq3EFUXqqbEh3sHvQMy9UsH1ZyU11A-hR7h_nLfLCnN1180IYYq_Bq7ZdqfnXw1Bc7rfQ$ ,

How about other sending options?
-Please check you tenant id within the deployment section. It seems incorrect. Here is the reference.
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/98143492/273503973-6ce0decb-3c09-4fdb-91d6-c1824d34145a.png__;!!D8DunMSJ4IdR!-PxfSJpe03-W4mnlVPXIU53CzR4Iqrq3EFUXqqbEh3sHvQMy9UsH1ZyU11A-hR7h_nLfLCnN1180IYYq_Bq7ZdqfnXxuQ-mjuQ$

And make sure to grant admin consent within the Graph app- API permissions.

—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/OfficeDev/microsoft-teams-apps-company-communicator/issues/1149*issuecomment-1752374351__;Iw!!D8DunMSJ4IdR!-PxfSJpe03-W4mnlVPXIU53CzR4Iqrq3EFUXqqbEh3sHvQMy9UsH1ZyU11A-hR7h_nLfLCnN1180IYYq_Bq7ZdqfnXwBYDViLQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BCXTOWRG366ODCNQFUIHL5DX6OE3JAVCNFSM6AAAAAA5B2OZY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGM3TIMZVGE__;!!D8DunMSJ4IdR!-PxfSJpe03-W4mnlVPXIU53CzR4Iqrq3EFUXqqbEh3sHvQMy9UsH1ZyU11A-hR7h_nLfLCnN1180IYYq_Bq7ZdqfnXx27hYGjg$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @cholman1,
Please share the mail id(outlook id) so that we can discuss the issue internally


Chapter 4: Add pixelsperscanline property for framebuffer node

pixelsperscanline defines the number of pixel elements per video memory line. For performance reasons, or due to hardware restrictions, scan lines may be padded to an amount of memory alignment. These padding pixel elements are outside the area covered by HorizontalResolution and are not visible.
For direct frame buffer access, this number is used as a span between starts of pixel lines in video memory. Based on the size of an individual pixel element and PixelsPerScanline , the offset in video memory from pixel element (x, y) to pixel element (x, y+1) has to be calculated as “sizeof( PixelElement ) * PixelsPerScanLine”,
not “sizeof( PixelElement ) * HorizontalResolution”, though in many cases those values can coincide.
This value can depend on video hardware and mode resolution. GOP implementation is responsible for providing accurate value for this field.

Do we have a real use case which pixelsperscanline is not equal to width?
we still like to align with common framebuffer binding which does not have pixelsperscanline currently.
https://www.kernel.org/doc/Documentation/devicetree/bindings/display/simple-framebuffer.txt

Do we have a real use case which pixelsperscanline is not equal to width? we still like to align with common framebuffer binding which does not have pixelsperscanline currently.
https://www.kernel.org/doc/Documentation/devicetree/bindings/display/simple-framebuffer.txt

Get you. If community decides to align with simple-framebuffer, then let me drop this PR.
Let me create other PR in TianoCore EDK2 community to set pixelsperscanline property align with HorizontalResolution.

PR in UPL EDK2 created, please help review when you are available. Thanks.
https://github.com/tianocore/edk2/pull/10564


How to use "-b" flag?

Dear developers,
I have read all discussion/issues related to "BX:Z" and tried to generate new fastq files by adding the -b flag to my "ema preproc" run:
-b: output BX:Z-formatted FASTQs [off]
However, as far as I can tell it does not actually print new fastq files anywhere in the file system. I get my 500 bins and downstream alignment works just fine but despite inspecting the source code, I simply can't figure out how the "-b" flag works.
Does it take any extra parameters or is it simply a boolean on/off?
Is it supposed to print to STDOUT or a new file?
Grateful for feedback on this!
Cheers!

Hi,
Could you post some lines from one of the bins? Are these not BX:Z-formatted after using -b?

Hi!
I deleted the bins and reran the exact same commands. It has now printed the expected fastq-formatted output, with the BX:Z tag in the headers. Not sure what went wrong before. Sorry for the confusion.


Update nalgebra/ncollide to 0.12

No changes were required.  Should we open the version bounds to include 0.11?

Seeing as the current release targets 0.13, I think this can be closed.


[Bug]: The Testcontainers overwritten wait strategy indicate readiness to early

Hi 👋, I noticed you're using Testcontainers in your demo project. I noticed a flaw in your configuration that I'd like to address to prevent potential issues with flakiness. Overriding the module's wait strategy is not recommended since modules are pre-configured. Typically, there's no need to override pre-configurations (except for database, username or password). Overwriting the wait strategy might lead to flakiness because ports are available earlier than the actual service.
https://github.com/egil/ApiTestingAZ/blob/91d3fba4c62a4eced1bcf17cd2ba5ca2abe7687d/TodoApi.Tests/AblaExtensions/TestContainersDatabaseAlbaExtension.cs#L47
The current configuration might indicate readiness too early. My suggestion is to stick to the module's default configuration.
BTW: Your configuration is equivalent to:
_ = new MsSqlBuilder()
    .WithImage("mcr.microsoft.com/mssql/server:2022-latest")
    .WithPassword(SQLPASSWORD)
    .Build();

Hey, thanks, I am no test container expert, just using it on a few projects, and the .WithWaitStrategy(Wait.ForUnixContainer().UntilPortIsAvailable(SQLPORT)) seem to work.
What is the default strategy and what is the difference? Would love to learn more!

The wait strategy essentially informs Testcontainers when the container is ready for use. This is when StartAsync() completes and your tests begin to run. If the wait strategy indicates readiness too early, your tests may fail, for instance, because the database is not yet fully operational.
The MSSQL default wait strategy waits until it establishes a database connection and successfully executes a query. The wait strategy can be as simple as waiting for a log message or very complex, as in this configuration.

Ahh, that makes complete sense to use that as a wait strategy. I was just googling and found some examples that used .WithWaitStrategy(Wait.ForUnixContainer().UntilPortIsAvailable(SQLPORT)) so that's what I went with. I guess it may be an old suggestion that has been superseded by the select 1 version.

Thanks for bringing this to my attention and thanks for the awesome work with testcontainers

I was just googling and found some examples that used .WithWaitStrategy(Wait.ForUnixContainer().UntilPortIsAvailable(SQLPORT)) so that's what I went with.

I know there are a few less-than-ideal examples out there, partly due to legacy implementations of the library. Whenever I come across them, I try to address them to prevent developers from running into issues (probably I should add the information to the best practices too).

Thanks for bringing this to my attention and thanks for the awesome work with testcontainers

Happy to help 🙏 Thanks.


mystery padding in mj-column in the editor

It looks like there is about 10px of top/bottom padding showing up in mj-column items that only seems to be there in the editor, if I override it manually with a custom block with  it's still there in the editor, but when emailing the exported HTML code it looks fine and has no padding.
Is there any way to get rid of that in the editor? We want it to look as accurate as possible when editing. It also looks like mj-column has padding parameters available in the MJML spec but they're not exposed which might help resolve the issue.
(also, is there a reason the latest releases don't have the /dist folder anymore?)

never mind, just saw the columnsPadding option


Make chooser convert external to internal links

This PR adds the ability for the external link chooser to detect when a url entered matches a page. As internal links are more stable than external (they won't break when pages are moved or renamed), any identical matches are converted to internal links automatically.
However, currently we don't have any way of appending query, fragment links, or routable page parameters to urls. If a link matches a page but not exactly - ie with extra information - the conversion is confirmed explicitly with the user.
(In the future, it would be good if we could include this information directly in an internal link rather than needing to keep these sorts as external, but that change will need more discussion as to how exactly we do this, and expose this functionality in the internal chooser - ie an extra field for query parameters?)

I like this idea a lot, although with any feature where the computer 'second-guesses' what the user intended to do, I think we need to take extra care that it doesn't backfire. At risk of invoking https://xkcd.com/1172/, this feels like the kind of change that could break existing workflows... perhaps someone has customised the rendering of external links and needs "just this one page link" to follow the same behaviour, or some data export requires full URLs to be present in the database. I can only think of obscure hypothetical scenarios like this, which is a good sign that it's a worthwhile change to make globally, but I think it could still be worth having a plan for letting people revert to the old behaviour if those scenarios do come up. That doesn't necessarily mean a settings flag - I'm no fan of those, and I'd actually be quite happy for it to require jumping through a hoop like writing a hook function or custom link handler or something - but this isn't a very 'hookable' piece of code, so a setting may be the way to go after all.
I'm less sure about the non-exact match that requires user confirmation - this shouldn't be a detail that ordinary editors have to care about, and interrupting their workflow to ask "would you like me to do this thing that you didn't know about up to now and didn't ask for" feels a bit obnoxious in a Microsoft Clippy kind of way. :-) I'd be inclined to err on the side of caution and just not convert the link in this case - unless you have reason to believe that pasting Wagtail page links with redundant URL parameters (Google Analytics tracking codes, maybe?) is a common thing.

I like this idea a lot, although with any feature where the computer 'second-guesses' what the user intended to do, I think we need to take extra care that it doesn't backfire. At risk of invoking https://xkcd.com/1172/, this feels like the kind of change that could break existing workflows... perhaps someone has customised the rendering of external links and needs "just this one page link" to follow the same behaviour, or some data export requires full URLs to be present in the database. I can only think of obscure hypothetical scenarios like this, which is a good sign that it's a worthwhile change to make globally, but I think it could still be worth having a plan for letting people revert to the old behaviour if those scenarios do come up. That doesn't necessarily mean a settings flag - I'm no fan of those, and I'd actually be quite happy for it to require jumping through a hoop like writing a hook function or custom link handler or something - but this isn't a very 'hookable' piece of code, so a setting may be the way to go after all.
I'm less sure about the non-exact match that requires user confirmation - this shouldn't be a detail that ordinary editors have to care about, and interrupting their workflow to ask "would you like me to do this thing that you didn't know about up to now and didn't ask for" feels a bit obnoxious in a Microsoft Clippy kind of way. :-) I'd be inclined to err on the side of caution and just not convert the link in this case - unless you have reason to believe that pasting Wagtail page links with redundant URL parameters (Google Analytics tracking codes, maybe?) is a common thing.

Thanks! Yep, I couldn't think of anything non-obscure either, but I think you're right - a setting probably is the way to go here just because I don't think we want to make the external chooser hookable just for this (particularly if we could be changing it in the near future with @ababic's new designs).
Haha, obviously my goal is for Wagtail to reinvent Clippy ;-). More seriously though, I added this because personally I think it's a pretty common thing - particularly with fragment links from eg a heading halfway down the page, or yes, tracking codes. Originally I intended it to just drop the conversion behind the scenes if the url wasn't a direct match, but TMF preferred the confirmation step, and on reflection, I think I agree with that - it should be pretty rare indeed to see this message on sites that don't use these things, but on sites where tracking codes/fragment links are heavily used, it could prevent accidentally creating a load of really fragile links while thinking they're using it as a shortcut to internal links just because of a meaningless query parameter. That said, I could see the annoyance in certain cases... maybe if we're already adding a setting, we could make it address this as well? Say a WAGTAILADMIN_EXTERNAL_LINK_CONVERSION that could be 'all' or 'unambiguous' (which just drops instead of confirming), or none for disabling it?

[...] That said, I could see the annoyance in certain cases... maybe if we're already adding a setting, we could make it address this as well? Say a WAGTAILADMIN_EXTERNAL_LINK_CONVERSION that could be 'all' or 'unambiguous' (which just drops instead of confirming), or none for disabling it?

Would this be a bad place to start the unified settings implementation? The more new single settings we're adding, the more we have to support them (yay 2 version deprecation process!)
or, in other words... when do we draw the line on new single settings?

I think I'm missing some context here, sorry! Unified settings
implementation?
On Thu, 29 Jul 2021, 14:52 Dan Braghis, @.***> wrote:

[...] That said, I could see the annoyance in certain cases... maybe if
we're already adding a setting, we could make it address this as well? Say
a WAGTAILADMIN_EXTERNAL_LINK_CONVERSION that could be 'all' or
'unambiguous' (which just drops instead of confirming), or none for
disabling it?
Would this be a bad place to start the unified settings implementation?
The more new single settings we're adding, the more we have to support them
(yay 2 version deprecation process!)
or, in other words... when do we draw the line on new single settings?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wagtail/wagtail/pull/7376#issuecomment-889162706, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANEVGMMGZBRJZHK3E5ORZ23T2FMJ3ANCNFSM5BCBGBFA
.

We discussed at a core meeting that we'd consolidate the various settings under a single scope settings dict (or similar).
See #1546 to be more exact.
Thinking more, we should do it in a separate PR. Worth bringing this up every time there's talk about a new setting though :)

maybe if we're already adding a setting, we could make it address this as well? Say a WAGTAILADMIN_EXTERNAL_LINK_CONVERSION that could be 'all' or 'unambiguous' (which just drops instead of confirming), or none for disabling it?

Sounds good to me!

I don't want perfection to be the enemy of progress here, but is this the best experience for users?
In the designs @benenright developed, we had the idea of a 'quick paste URL' option that would be offered to the user as a secondary option before the main pop-up even appears, and would convert ANY pasted URL to the correct type. The idea here is to save editors time when:

They want to link to the same page in multiple places without having to use the chooser each time
They are mass-populating the site with the front-end open in another tab, and copying and pasting URLs from the address bar is easier for them.

The usefulness of such a feature really hangs on our ability to support fragment and querystring specification for page URLs though.
I'll try to re-ignite progress on that stream of work, as the designs were 90% of the way there! I just lost @benenright to other things before we got something ready to share.

Hi @ababic. To me, those sound like great (but higher effort) improvements for the future - I don't see them as being contradicted by this PR, if anything this PR is a step towards them.

We add the ability to include fragments and query parameters in page urls? Great! We add that into this code, and convert in more circumstances.
We add a quick url entry from Draftail? Great, we can reuse a lot of this code for detecting whether it should become an internal or external link.
However, both of them require a bit more thought, design, or effort. In the meantime, this first step towards converting external urls solves an existing problem users are having, while helping out when we finally settle on designs and have the time to write the Draftail quick entry url interactions.

@jacobtoppm coolio, I agree with all of that. Just thought it would be worth a mentioning, as it's very much related.

@ababic Great! Yes, definitely worth mentioning, and would definitely be interested in helping with the future improvements

@jacobtoppm Don't forget the changelog entry / release note for this!


Investigate declare public removed in this scenario

I’ll investigate this tomorrow. Might be an swc issue because I feel like dprint’s code should handle this.
From https://discord.com/channels/684898665143206084/684911491035430919/736188533693480962

deno fmt is removing declare public
in

class extends (Ogone.classes.extends(klass)) {
    declare public type: string;
    declare public setActualRouterTemplate: Function;
    declare public renderRouter: Function;
    declare public renderStore: Function;
    declare public renderAsync: Function;
    declare public setNodeAsyncContext: Function;
    declare public triggerLoad: Function;
}

Opened https://github.com/swc-project/swc/issues/894


[PYTHON ]A SBERT Based Flask Web APP for Aautomatic Text Summarization

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[ ] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #7139

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

@BrianaNzivu

plagiarism check done ✔

Closing now
I'll take some time before I push some more commits

Thanks @srishilesh

Your article doesn't dive deep into the technical concepts, instead gives a quick summary of how it can be implemented. Moreover, the code snippets were not very explanatory and had many typo errors. Also, the image paths were incorrect.
Ping me when you're done with the changes.
Thanks.

@srishilesh - this seems like it should have been closed at that point. (not sure how extensive the required improvements were).
But IF any more edits are needed (be it grammatical or code) we will be closing the PR 👍

Hey @FranciscaNg ,
Thanks for making the changes.
Make sure to go through the changes I've made.
Moving for the final review.
Thanks.

I will. Thanks


Release 2.3 Beta 2

Merry Christmas to all Symphonians. That's the goal and with 2.3 Beta 2 it should be a relatively UI complete release that users can play with during their Christmas break.

Closed the wrong issue from the merge. Probably a sign I should be in bed instead!

@eKoeS and I will meet online next weekend to clean-up and complete the styles. We'll go through all related issues so keep on posting.

Thanks very much @eKoeS and @nilshoerrmann. Much appreciated :)

Brendan, Simone and I have been discussing the next steps to clean-up and finish the 2.3. styles. There is quite a lot work left especially related to column management.
I just saw that beta2 is due in 7 days – we won't be able to meet that deadline.
Would it be possible to either postpone beta2 or finalise the UI around new year in a beta3?

With "column management" I meant the system how our multicolumn layouts are setup. We have been using negative margins a lot and that was causing problems - we are now switching to a simpler solution that won't result in that many unwanted side effects.

Good idea :)

Released.
Have set up a Beta 3 milestone, which will hopefully be the last before an RC.
Merry Christmas to all :)


ImportError: cannot import name 'url_quote' from 'werkzeug.urls'

Exercise URL
vscode ➜ /workspaces/mslearn-python-products (main) $ python app.py
Traceback (most recent call last):
  File "/workspaces/mslearn-python-products/app.py", line 1, in <module>
    from flask import Flask
  File "/home/vscode/.local/lib/python3.11/site-packages/flask/__init__.py", line 7, in <module>
    from .app import Flask as Flask
  File "/home/vscode/.local/lib/python3.11/site-packages/flask/app.py", line 28, in <module>
    from . import cli
  File "/home/vscode/.local/lib/python3.11/site-packages/flask/cli.py", line 18, in <module>
    from .helpers import get_debug_flag
  File "/home/vscode/.local/lib/python3.11/site-packages/flask/helpers.py", line 16, in <module>
    from werkzeug.urls import url_quote
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/vscode/.local/lib/python3.11/site-packages/werkzeug/urls.py)

@PioneerWxy  Thank you for this hint. With your hint it works!


[WFRP4e System]  wfrp4e & Multilevel Tokens

I am seeing several exceptions (see attached log) relating to missing data on the cloned tokens produced by Multilevel Tokens (v1.4.1)From: stevenevans1966wfrp4e: 3.5.1wfrp4e-core: 1.3.3wfrp4e-dotr: 1.0.0wfrp4e-eis: 1.2.2wfrp4e-rnhd: 1.4.1wfrp4e-starter-set: 1.4.3wfrp4e-ua1: 1.0.2

I sent the report via the vtt grievance button so could not attach the file.  i also realized the report did not state how to duplicate the error.

create a source and target token clone area
place a token the source area
target the token in the clone target area.
4)click weapon to attack.

vtt_log-1620211108862.log


Track unhandled errors with source mapped stacktraces

Chrome Devtools exceptions shows mapped stacktraces.
Would be great if puppeteer could do that too. It's very common for devs to use webpack to bundle files.
Could be even a helper function to convert bundled stacktrace to source mapped stack trace.
We do this in vscode console : https://github.com/Microsoft/vscode-chrome-debug-core/pull/190 and its been a super helpful feature.

Closing as a dupe of #985


[Feature] Open student submission in online editor

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I added multiple integration tests (Spring) related to the features
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[ ] Client: I added multiple integration tests (Jest) related to the features
[x] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context

Make it possible for tutors and instructors to review the code directly into Artemis instead of downloading the repo or checking it out via bitbucket.
Description

Use assessment-layout component for labouring
Add code-editor container with individual nabber
Reuse layout and functionality of dialog/modal component (which is now removed)

Steps for Testing

Log in to Artemis
Navigate to Course Administration
Create programming exercise and participate in programming exercise (also exam mode)
Assess programming exercise (via tutorDashboard, exercise-score, examTutorDashboard)
4.1 Try out all buttons and check if something strange happens
Complain about assessment
Assess complaint
6.1 Try out all buttons and check if something strange happens

Screenshots

New layout for the assessment of programming exercises:

Complaints:

Tested it on the testserver, nothing strange happened.

Also joined in testing, could only find two things:
As a suggestion for the UI: Add some margin there, so that the elements do not touch each other:

Also when I override my assessment, the ui is not updated and I need to reload, see screenshot:

other than that, I did not find any issue.  I will also do a code review tomorrow


Add support for custom dialer in canal and binlog syncer

Allow custom dialers in canal in binlog syncer. This change introduces some minor copy&paste code mainly in order to set the timeout context at 10 seconds to mimic the behavior of client.Connect

OK, this is now ready for review

Hi, kindly remind that you may encounter this issue
https://github.com/go-mysql-org/go-mysql/pull/718

Hi, kindly remind that you may encounter this issue
#718

Oh, thank you!


Default Location type selected for GKEv2 is different for a hosted vs imported cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

For hosted GKEv2 cluster, while creating, Location Type: Zonal is selected by default
For an imported GKEv2 cluster, while creating, Location Type: Regional is selected by default

Expected Result:
Can we have the default values for these two type of cluster provisioning the same? i.e: Zonal
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.8-rc12
Installation option (single install/HA): single

On 2.5-head commit id: 42f722b79
By default "Zonal" is selected for import and hosted gkve2 clusters during cluster. creation.


LocustBadStatusCode without url param in fasthttp

a new function _verify_status was created and a LocustBadStatusCode class is sent as a response to the function which removes the url leaving only the code.

👍 just add a test case to test_fasthttpuser (or add some validation it to some existing one) and format using ruff and I’ll merge.

Hmm... looks like every Python version failed, that's a bit worrying, but may still be irrelevant.
Can you write the test this way instead? https://github.com/locustio/locust/blob/a1b0a047338dbd55db06f047ad4b85f60f3a2125/locust/test/test_http.py#L112

No I didnt mean the name, I meant the way of testing :)


Remove deprecated version property from bower.json

From https://github.com/bower/spec/blob/master/json.md#version:

Deprecated
Use git or svn tags instead. This field is ignored by Bower.

Please remove this pull request. It is up to the author to update the bower package


Ensure returned mime type returned is not obsolete

The mime-types gem sorts (via priority_compare) obsolete types first in the return Array, so using the last element ensures that if an active type is present, it is returned here.
An example usage of where this showed up incorrect was the csv format, which incorrectly returned the obsolete value text/comma-separated-values.

It still would be nice to have a method that did the expected thing here. We'll drop the mime-types monkey patch, but it'd be great to have a comparison method that could actually return the appropriate thing for csv, for example.

Sorry, long time away, closing now as I guess its old!


⚠ NCAA has degraded performance

In 5631e42, NCAA (https://www.ncaa.com) experienced degraded performance:

HTTP code: 200
Response time: 575 ms

Resolved: NCAA performance has improved in 04f8c58.


Add icon to data explorer link

This PR adds a download icon to Data Download link on tools-nav
Pivotal task

Looks great :+1:  should the icon be visible in the responsive menu too?

Not sure, it probably makes sense. @faustoperez ? ☝
Also I've noticed that we have My Climate Watch link twice

Please remove the MY CW and DATA EXPLORER items from the blue list and put them at the bottom besides the share icon. Thanks! 💐

And yes, @kfilip94 please add the icon in the responsive version too :)

Taking care of this

☝ ready to review again

Looks great on mobiles now :+1:
But I noticed that for mobile view, after clicking  on MY CW or DATA EXPLORER, the menu is still visible instead disappear, what can be confusing, because we don't see if one of these pages is loaded or not :confused:  Could you fix it in this PR?

@kfilip94 added closing menu functionality ☝


fix: GetDirectories returns relative paths if applicable

This should fix #815
If the path orginally given is relative, we return relative paths as well.
For instance in a folder structure like:
.
./foo
./foo/bar

where current directory is /foobar
Initially, the underlying method returns absolute paths i.e. calling GetFilesInternal("/foobar/foo") returns /foobar/foo/bar.
We then compute the last component of the full path i.e. bar, which we combine with the path originally requested:

foo -> foo/bar
./foo -> ./foo/bar
../foobar/foo -> ../foobar/foo/bar

This works better than trying to get the absolute path relative to the current directory
Also, we add a new relevant test and adapt an existing incorrect test:
It verifies that the returned paths are absolute, even though the path given is relative:
MockDirectory_GetDirectories_RelativeDirectory_WithChildren_ShouldReturnChildDirectories(string relativeDirPath)
That test was added by #258 for #169

Seriously, please check the way I built back the relative paths: I used a substring but if you see a better way, please let me know.

Sorry @tuan-tu-tran, I forgot about this PR. Will have a look by next week!

Sure! No worries!
On Fri, 11 Mar 2022 at 16:58, Florian Greinacher @.***>
wrote:

Sorry @tuan-tu-tran https://github.com/tuan-tu-tran, I forgot about
this PR. Will have a look by next week!
—
Reply to this email directly, view it on GitHub
https://github.com/TestableIO/System.IO.Abstractions/pull/816#issuecomment-1065245085,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQKIHD4MTCQOH6GQPNJOOTU7NUSNANCNFSM5PGAJL4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

https://github.com/TestableIO/System.IO.Abstractions/issues/815 has been resolved, so I assume we can close this. Feel free to reopen if needed.


Save user agent that sent each submission

It'd be useful to indicate the user agent that sent each submission. @yanokwa writes on Slack:

[I]f you know there is a bug in Collect that affected the data collection, then you could adjust your analysis.

@lognaturel writes:

For Collect [the user agent] includes Collect version, Android version and device, all of which can have impact on behavior.

and:

I believe Enketo populates all the things it should but if not we can make it do so.

This feature would entail saving the user agent that sent the submission, probably similar to what's done for device ID. The user agent would then be exported in the CSV and over OData. (I just checked, and it looks like we export device ID in both places.) We could also consider surfacing the user agent in Frontend, probably on the submission details page.

Related forum conversation

Closed by getodk/central-backend#432.


Provided json file has no train/val/test split

The json file you provided in google drive has no train/val/test split. All 10000 videos belong to train split. Could someone help provide a correct one? Thanks in advance.

I have the same question

do you get the correct json?

believe you can find answers from this code : the https://github.com/oddguan/Audio-Visual-Video-Caption

I have the same question


Error in read.spc() with R 4.2.0

The original issue was https://github.com/r-hyperspec/hyperSpec/issues/80
Some aspects still are not solved.
Essence:
#> Warning in file(con, "rb"): file("") only supports open = "w+" and open = "w+b":
#> using the former
#> Error in readBin(filename, "raw", file.info(filename)$size, 1): can only read from a binary connection

``` r
library(hySpc.read.spc)
#> Loading required package: hyperSpec
#> Loading required package: lattice
#> Loading required package: grid
#> Loading required package: ggplot2
#>
#>
#> Package hyperSpec (version <IP_ADDRESS>00)
#>
#> To get started, try:
#>    vignette("hyperSpec", package = "hyperSpec")
#>    package?hyperSpec
#>    browseVignettes(package = "hyperSpec")
#>    vignette(package = "hyperSpec")
#>
#> If you use this package, please cite it appropriately.
#> The correct reference is given by:
#>    citation("hyperSpec")
#>
#> The project's website:
#>    https://r-hyperspec.github.io/hyperSpec
#>
#> IMPORTANT!
#> Existing users of 'hyperSpec' will find that many functions either have been renamed in favor of more consistent names or moved to other packages. To help you update your workflows, the list of the renamed and moved functions resides in the NEWS file of hyperSpec's documentation:
#>
#> help(package = "hyperSpec")
#>
#> Attaching package: 'hySpc.read.spc'
#> The following objects are masked from 'package:hyperSpec':
#>
#>     read.spc, read.spc.Kaiser, read.spc.KaiserLowHigh,
#>     read.spc.KaiserMap
x <-
  hySpc.read.spc::read.spc(
    filename = system.file("extdata/1.spc", package = "ir"),
    log.txt = TRUE,
    log.bin = TRUE,
    log.disk = TRUE,
    keys.hdr2data = TRUE,
    keys.log2data = TRUE,
    no.object = FALSE
  )
#> Warning in file(con, "rb"): file("") only supports open = "w+" and open = "w+b":
#> using the former
#> Error in readBin(filename, "raw", file.info(filename)$size, 1): can only read from a binary connection
```
Created on 2022-07-14 by the reprex package (v2.0.1)

@cbeleites, do you know how to solve this?

The error is due to empty input as ir package was not installed on my PC. The filename must not be empty and give a meaningful error message in case of wrong input.


Test nll master nbest rescoring

Codecov Report

Merging #33 (81fb256) into master (31de8f2) will decrease coverage by 0.85%.
The diff coverage is 91.03%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   56.53%   55.68%   -0.86%
==========================================
  Files         741      754      +13
  Lines       64483    66064    +1581
==========================================
+ Hits        36457    36788     +331
- Misses      28026    29276    +1250

Impacted Files
Coverage Δ

espnet2/fst/lm_rescore.py
72.46% <72.46%> (ø)

espnet/nets/pytorch_backend/nets_utils.py
85.15% <100.00%> (+0.35%)
:arrow_up:

espnet2/asr/decoder/transformer_decoder.py
96.63% <100.00%> (ø)

espnet2/asr/espnet_model.py
91.19% <100.00%> (-0.22%)
:arrow_down:

espnet2/bin/asr_inference_k2.py
94.20% <100.00%> (ø)

espnet2/lm/espnet_model.py
100.00% <100.00%> (ø)

espnet2/asr/ctc.py
62.12% <0.00%> (-21.22%)
:arrow_down:

espnet/nets/pytorch_backend/ctc.py
51.93% <0.00%> (-12.41%)
:arrow_down:

espnet2/layers/stft.py
85.89% <0.00%> (-6.42%)
:arrow_down:

tools/fairseq/fairseq/tasks/speech_to_text.py
35.89% <0.00%> (-3.81%)
:arrow_down:

... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31de8f2...81fb256. Read the comment docs.


add support for gpt4o

Is your feature request related to a problem? Please describe.
新功能是否与解决某个问题相关, 请描述
add support for gpt4o
Describe the solution you'd like
你期望的新功能实现方案
add support for gpt4o
Additional context
其他
Add any other context or screenshots about the feature request here.

there are 2 open PRs for this change. Hope they get integrated soon.

https://github.com/josStorer/chatGPTBox/releases/tag/v2.5.5

Hi

Error:
OpenAI security check required
Please open https://chatgpt.com
Then click the Retry button in the top right corner
Consider creating an API key at https://platform.openai.com/account/api-keys


Feature/max date updates

Codecov Report
Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (9810634) 88.45% compared to head (963ff5f) 92.32%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   88.45%   92.32%   +3.86%
==========================================
  Files          91       94       +3
  Lines        1421     1771     +350
==========================================
+ Hits         1257     1635     +378
+ Misses        164      136      -28

Files
Coverage Δ

hdx_hapi/db/dao/admin1_view_dao.py
88.00% <100.00%> (+17.62%)
:arrow_up:

hdx_hapi/db/dao/admin2_view_dao.py
89.65% <100.00%> (+19.28%)
:arrow_up:

hdx_hapi/db/dao/age_range_view_dao.py
84.21% <100.00%> (+10.29%)
:arrow_up:

hdx_hapi/db/dao/location_view_dao.py
85.00% <100.00%> (+13.00%)
:arrow_up:

hdx_hapi/db/dao/operational_presence_view_dao.py
93.18% <100.00%> (+31.81%)
:arrow_up:

hdx_hapi/db/dao/org_view_dao.py
86.36% <100.00%> (+14.36%)
:arrow_up:

hdx_hapi/db/dao/population_view_dao.py
94.73% <100.00%> (+34.21%)
:arrow_up:

hdx_hapi/db/dao/resource_view_dao.py
90.62% <100.00%> (+28.12%)
:arrow_up:

hdx_hapi/db/dao/sector_view_dao.py
85.71% <100.00%> (+13.71%)
:arrow_up:

hdx_hapi/db/models/views/db_admin1_view.py
100.00% <100.00%> (ø)

... and 44 more

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added Raspi Project Book 2

Added the MagPi Magazine's Raspberry Pi Projects Book 2 from November of 2016.
What does this PR do?
Adds a resource
For resources
Description
Why is this valuable (or not)?
This PR adds the Raspberry Pi Project Book 2 e-book from the MagPi Magazine.
How do we know it's really free?
There is a free download link, no email required. It downloads in PDF format.
For book lists, is it a book? For course lists, is it a course? etc.
This is a book.
Checklist:

[X] Read our contributing guidelines.
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction).
[X] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


Favorites Group is always folded-in on every startup of the SKIF app

Favorites Group is always folded-in on every startup of the SKIF app

This is by design. The only category that will be expanded upon launch is the one that has the last selected game (requires that setting to be enabled, see Settings -> Library -> Remember the last selected game).
If you want a game to always be easily accessible regardless of the last selected game, right click the game and click on Manage -> Favorite (pinned; max 5) as this will pin it in a separate "pinned favorites" area above the rest of the list of games.

I can mention that long-term SKIF will probably be able to track and remember the collapse state of categories between sessions

This was implemented recently and should be available in the latest version of SKIF.


feat(connect): make connect cluster resources configurable

Description
Tested with diff on rendered templates via
$ helm template gcp -f example-values/gcp-values.yaml > ../template-after.yaml

$ diff ../template-before.yaml ../template-after.yaml                                                                                datacater-cloud-staging
519c519
<     requests:
---
>     limits:
522c522
<     limits:
---
>     requests:

💯 LGTM


AdonisJS migration Error on PostgreSQL : withSchema is not a function

From @bendo01 on December 20, 2017 21:7
I want to create a DB under non-public Schema in PostgreSQL. In knexjs document :
knex.schema.withSchema('public').createTable('users', function (table){
  table.increments();
})

My migration code is:
this.withSchema('myschema').create('users', table => {
  table.increments()
})

But migration:run returns this error:
TypeError: this.withSchema is not a function

How can I create DB under custom schema?
same question is asking here
Copied from original issue: adonisjs/adonis-framework#749

Identified bug, going to fix it

Fixed in 5703a7c6fa0f240bfe209ef9a188402471db160c

How does one indicate a Model belongs to a specific schema?


Sample: multistack sample resets to Red on rotation

Thanks for the bug report
This is now fixed on master 🎉
New release coming over the weekend!


volctl: 0.8.0 -> 0.8.2

Motivation for this change
Update package
Things done
Update version, hash, build and run locally

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122858 run on x86_64-linux 1

1 package built:

volctl

It builds and it runs, LGTM