Undefined array key in Generic.WhiteSpace.ScopeIndent

Describe the bug
When checking a specific file (see minimal code sample), phpcs throws an undefined array key error.
Code sample
<?php

match (true) {
    default => [
        'unrelated' => '',
        'example' => array_filter(
            array_map(
                function () {
                    return null;
                },
                []
            )
        )
    ]
};

(Yes, i know the code is very convoluted, it's very much an edge-case)
Interestingly enough, the unrelated array key is relevant, if removed then the error doesn't occur anymore.
Custom ruleset
No custom ruleset defined.
To reproduce
Steps to reproduce the behavior:

Create a file called test.php with the code sample above...
Run phpcs test.php
See error message displayed

----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | An error occurred during processing; checking has been aborted. The error message was: Undefined array key 68 in /app/vendor/squizlabs/php_codesniffer/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php on line 1481
|       | The error originated in the Generic.WhiteSpace.ScopeIndent sniff on line 1481. (Internal.Exception)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Expected behavior
Show an understandable/fixable error, instead of a generic error coming from inside of phpcs.
Versions

Operating System
Linux 6.6 (in docker)

PHP version
8.1 & 8.3

PHP_CodeSniffer version
3.8.1 & 3.9.1

Standard
whatever the default is (PEAR?)

Install type
composer

Please confirm:

[x] I have searched the issue list and am not opening a duplicate issue.
[x] I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
[x] I have verified the issue still exists in the master branch of PHP_CodeSniffer.

I can confirm this is reproducible on the current master branch (commit b0ecdf10fa5a15bbf341b6dd75d1b23bd803aaaf).
The line causing the error can be seen at
https://github.com/DannyvdSluijs/PHP_CodeSniffer_Continuation/blob/master/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php#L1481
At frist glance there is no obvious culprit and the same issue can be reproduced using version 3.7.1, 3.6.2. Using git bisect it seems that 97f78982711bdf122200dc37be6f33dfbd4aa4dd is causing the issue which was aimed to solve https://github.com/squizlabs/PHP_CodeSniffer/issues/3287

I've been digging into this one and it looks like it is a pretty complex bug in the File::findStartOfStatement() method related to the handling of match expressions, which is causing this behaviour.
Currently working on fixing that bug. Once that bug is fixed, I'll have to see if reported issue can still be reproduced and if there is anything within the ScopeIndent sniff, which would still need fixing.

Pff.. this was complex one. PR #502 should fix it though. Testing appreciated.


Test tunnel configuration button cut off

System information:

Ubuntu 20.10 64-bit Gnome 3.38.3 X11
DBeaver 21.0.1

Describe the problem you're observing:
When creating a MariaDB connection using SSH Tunnel the button Test tunnel configuration is not visible because the default height of the window is to small. You can resize the window but that isn't obvious for the user and the window should have a different height by default.

thanks for the report


Ripple effect leeks in android

On android the ripple effect is a square that leeks out rounded buttons.
It should be solved simply by adding a borderlessRipple={ true } somewhere.

Is there a fix for this yet? I am also facing the same issue.

Please see issue #146
I will try your suggestion once I have more time. Alternatively, the solution is really that easy, maybe someone can send a PR?!

ok same issue as #146 sorry
I didn't look into your code but something like that should do the trick :
<View style={ roundedButton }>
     <TouchableNativeFeedback
          onPress={ onPressAction }
          background={ TouchableNativeFeedback.Ripple(rippleColor, TRUE) }
      >
          <Ico source={ source } style={ icoStyle }/>
       </TouchableNativeFeedback>
</View>

There might be more views inside to help align elements but the background={ TouchableNativeFeedback.Ripple(rippleColor, TRUE) } should do the trick

I was thinking, when patching this issue it would be nice to add a rippleColor property for each button.

holy shit, i just tried this solution, but the result looks horrible. Try it out yourself, then you'll see what i mean.

This issue is not fixed, the ripple effect look like a square, not a circle

I pushed a Pull Request to fix this, (and a few other issues I had trouble with),
the idea is to pass the fixNativeFeedbackRadius prop, and the Ripple should no longer leak.

merged. see v2.7.0

Hello, the ripple leak still exists in v2.7.1.
Could you please help fix it, thanks.

@likeconan have you set fixNativeFeedbackRadius to true?

@SudoPlz I tried and there is another problem like below:

@likeconan that's not a problem, it's just shadows not working the same way on Android as they do on iOS.
Set hideShadow={false} and you should be good to go.

@SudoPlz hideShadow={true} fixes the problem. But now you don't have shadow.

@vitorfox Yeeep, true, that's a compromise of restricting the Ripple. Not sure if there's a work around for that. Perhaps try using elevation on Android? (for iOS you can keep using shadows).


Scroll issue in horizontal flatlist in android (react native version 0.73.5)

Description
I am facing an issue in the scroll of the horizontal flatlist on android devices and simulators. Even if there is a single item in the flatlist, the user is able to scroll and the image remains on the right side after scroll until the user taps on it.
I started facing this issue after updating react native from version 0.70 to 0.73.5.
The code that is have written is:
<FlatList
horizontal={true}
data={props.data}
showsHorizontalScrollIndicator={false}
showsVerticalScrollIndicator={false}
keyExtractor={(item, index) => index.toString()}
renderItem={({ item, index }) => renderImageList(item, index)}
/>
Please refer to the below recording to understand my issue better.
https://github.com/facebook/react-native/assets/53793610/fbc3bca7-6f70-4fc5-a9b7-b44b70ae4c1d
Any help on this will be highly appreciated.
Steps to reproduce
<FlatList
horizontal={true}
data={props.data}
showsHorizontalScrollIndicator={false}
showsVerticalScrollIndicator={false}
keyExtractor={(item, index) => index.toString()}
renderItem={({ item, index }) => renderImageList(item, index)}
/>
React Native Version
0.73.5
Affected Platforms
Runtime - Android
Output of npx react-native info
System:
  OS: macOS 14.1.1
  CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Memory: 161.58 MB / 16.00 GB
  Shell:
    version: 3.2.57
    path: /bin/bash
Binaries:
  Node:
    version: 18.14.2
    path: /usr/local/bin/node
  Yarn:
    version: 1.22.10
    path: ~/.npm-global/bin/yarn
  npm:
    version: 9.6.0
    path: ~/.npm-global/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /Users/nehabhandari/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10227.8.2321.11479570
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.7.5
    path: /Users/nehabhandari/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.5
    wanted: 0.73.5
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

info React Native v0.73.6 is now available (your project is running on v0.73.5).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.73.6
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.73.6
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos"

Stacktrace or Logs
-```

### Reproducer

-
### Screenshots and Videos

_No response_

I've encountered a similar problem with the horizontal ScrollView. While I haven't experienced it on my Android 11 device, on later OS it seems to happen.

Hey i just ran into this issue my self on version 0.73.4, i gave the contentContainerStyle of the flat list a min width of "100%" and it seems to get the job done.

@jo7475 It seems to work. Thank you!!

I think this is the same issue as #41492 and #36617. I've been able to reproduce it in an Android emulator, but not in a Snack unfortunately.

@jo7475 Hey Jo, thanks for the suggestion. However this does seem to disable the scroll entirely and if the items' size change dynamically, the user will not be able to scroll through the horizontal list.

flexGrow: 1 solved.


Validate multiple maps with "basekeys"

First of, thanks for this nice tool!
I have the following schema:
vehicles: list(include("car"), include("ship"))
other_irrelevant_stuff: str(required=False)
---
Base:
  name: str()
  type: enum("car", "ship")
---
car:
  base: include("Base")
  cargo: list(include("car_cargo"))
  wheels: list(include("car_wheel"))
car_cargo:
  passengers: int()
  animals: int(required=False)
car_wheel:
  total: int()
  powered: int()
---
ship:
  base: include("Base")
  cargo: list(include("ship_cargo"))
  engine_count: num()
ship_cargo:
  passengers: int()
  crew: int()
  animals: int()

which validates eg:
vehicles:
  - base:
      name: Company Car
      type: car
    cargo:
      - passengers: 4
        animals: 1
      - passengers: 2
        animals: 2
    wheels:
      - total: 4
        powered: 4
      - total: 4
        powered: 2
  - base:
      name: Private Car
      type: car
    cargo:
      - passengers: 2
    wheels:
      - total: 4
        powered: 2
  - base:
      name: Ferry
      type: ship
    cargo:
      - passengers: 250
        crew: 6
        animals: 20
      - passengers: 250
        crew: 6
        animals: 20
    engine_count: 3

Yet, what I would rather want to have is the following:
vehicles: list(include("car"), include("ship"))
other_irrelevant_stuff: str(required=False)
---
Base:
  name: str()
  type: enum("car", "ship")
---
car:
  include("Base")  # Include those key-val-pairs on same level as "cargo" and "wheels"
  cargo: list(include("car_cargo"))
  wheels: list(include("car_wheel"))
car_cargo:
  passengers: int()
  animals: int(required=False)
car_wheel:
  total: int()
  powered: int()
---
ship:
  include("Base")  # Include those key-val-pairs on same level as "cargo", "engine_count"
  cargo: list(include("ship_cargo"))
  engine_count: num()
ship_cargo:
  passengers: int()
  crew: int()
  animals: int()

where the Base map is merged with its including map to validate the data in this format:
vehicles:
  - name: Company Car
    type: car
    cargo:
      - passengers: 4
        animals: 1
      - passengers: 2
        animals: 2
    wheels:
      - total: 4
        powered: 4
      - total: 4
        powered: 2
  - name: Private Car
    type: car
    cargo:
      - passengers: 2
    wheels:
      - total: 4
        powered: 2
  - name: Ferry
    type: ship
    cargo:
      - passengers: 250
        crew: 6
        animals: 20
      - passengers: 250
        crew: 6
        animals: 20
    engine_count: 3

Of course this does not work, because the include("Base") statements are missing their key.
Is there a clever way to achieve this, or is it not doable at the moment? (I could not deduce a solution from the documentation)

Hi, thanks for using Yamale!
There's no way to "inherit" from a "base schema" using Yamale constructs. However, YAML has a way you can do this with anchors:
vehicles: list(include("car"), include("ship"))
other_irrelevant_stuff: str(required=False)
---
Base: &Base
  name: str()
  type: enum("car", "ship")
car:
  <<: *Base
  cargo: list(include("car_cargo"))
  wheels: list(include("car_wheel"))
car_cargo:
  passengers: int()
  animals: int(required=False)
car_wheel:
  total: int()
  powered: int()
ship:
  <<: *Base
  cargo: list(include("ship_cargo"))
  engine_count: num()
ship_cargo:
  passengers: int()
  crew: int()
  animals: int()

You just have to ensure that the references to the anchors are in the same document as the anchor itself. You'll notice I collapsed your last three documents into one. Hope that works for you.

Exactly what I needed! Thank you for the quick reply and solution. 🙌
My schema is in a quite early stage, so the collapsed document should not be a problem I think. Currently the splitting was basically used for formatting reasons only.
PS: As a newbie to YAML schemata I have to say that I found Yamale far more intuitive than eg JSON Schema. Very much appreciated.


SLSA metadata populated incorrectly

Expected Behavior
The SLSA metadata for the attched pipeline.yaml and pipeline_run.yaml which generates the provenance provenance.txt should have a metadata
"metadata": {
"buildStartedOn": "start_time"
"buildFinishedOn": "end_time"
"completeness": {
"parameters": true,
"environment": false,
"materials": true
},
"reproducible": false
}
Actual Behavior
The materials and parameters is not set to true.
Steps to Reproduce the Problem

Run the pipeline_run.yaml
Check for the provenance.

Additional Info

Kubernetes version:
Output of kubectl version:

Kubernetes version:
Output of kubectl version:
Client Version: v1.24.1
Kustomize Version: v4.5.4
Server Version: v1.24.7-gke.900

Tekton Pipeline version:

Built from head

pipeline.yaml
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
name: slsa-demo-pipeline
spec:
description: |
This pipeline clones a git repo, builds a Docker image with Kaniko and
pushes it to a registry
params:

name: repo-url
type: string
name: image-reference
type: string
results:
name: image-ARTIFACT_INPUTS
description: Source code used to build the artifact.
value:
uri: $(tasks.fetch-source.results.url)
digest: sha1:$(tasks.fetch-source.results.commit)
name: image-ARTIFACT_OUTPUTS
description: The artifact that has been built.
value:
uri: $(tasks.build.results.IMAGE_URL)
digest: $(tasks.build.results.IMAGE_DIGEST)
workspaces:
name: shared-data
tasks:
name: fetch-source
taskRef:
resolver: git
params:
- name: url
value: https://github.com/tektoncd/catalog.git
- name: pathInRepo
value: /task/git-clone/0.6/git-clone.yaml
- name: revision
value: main
workspaces:

name: output
workspace: shared-data
params:
name: url
value: $(params.repo-url)

name: build
runAfter: ["fetch-source"]
taskRef:
resolver: git
params:
- name: url
value: https://github.com/tektoncd/catalog.git
- name: pathInRepo
value: /task/kaniko/0.6/kaniko.yaml
- name: revision
value: main
workspaces:

name: source
workspace: shared-data
params:
name: IMAGE
value: $(params.image-reference)

pipeline_run.yaml
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
generateName: demo-pipelinerun-
spec:
serviceAccountName: jp-ksa
pipelineRef:
resolver: git
params:
- name: url
value: https://github.com/jagathprakash/tekton_slsa_demo.git
- name: pathInRepo
value: pipeline.yaml
- name: revision
value: main
workspaces:

name: shared-data
volumeClaimTemplate:
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 1Mi
params:
name: repo-url
value: https://github.com/bendory/mini-true.git
name: image-reference
value: us-docker.pkg.dev/${PROJECT_ID}/${CLOUD_REPO}/${CLUSTER_NAME}

provenance.txt

snippet
...
predicate: {
"parameters": {
"image-reference": "us-docker.pkg.dev/jagathprakash-test/jp-repo/tekton-slsa-demo",
"repo-url": "https://github.com/bendory/mini-true.git"
}
....
}

"metadata": {
  "buildStartedOn": "2022-12-16T22:27:31Z",
  "buildFinishedOn": "2022-12-16T22:28:36Z",
  "completeness": {
    "parameters": false,
    "environment": false,
    "materials": false
  },
  "reproducible": false
},
"materials": [
  {
    "uri": "git+https://github.com/bendory/mini-true.git.git",
    "digest": {
      "sha1": "93c56eeba9ec70f74c9bfd297d9516642d366cb5"
    }
  }
]

}
}

/assign jagathprakash


chore(circuits): Remove obsolete comments in native private kernel circuit

Clean up comments
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[x] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[x] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

I think this is fine, but I would still have some comment saying "this is where a real circuit would perform recursive verification of the previous kernel proof and private call proof".

@dbanks12 I have pushed this change and added this comment on both init and inner PKC.


Bug when using estimator with tf.data.Dataset.from_tensor_slices

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Windows 10
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):1.5.0-dev20171026
Python version: 3.6.3

Describe the problem
When I use tf.data and from_tensor_slices with estimator to build dataset from ndarray, tf.estimator will use much memory(peak 6900MB, final 4600MB with simple mnist cnn) and create very huge event files：
events.out.tfevents 1.28GB
graph.pbtxt: 1.20GB
model.ckpt-1.meta: 370MB
Then I use cifar10 input pipeline from resnet as input_fn, everything back to normal.
Source code / logs
replace code in notebook cell 6 with code below.
def ndarray_iters(datas,
                batch_size):
    dataset = tf.data.Dataset.from_tensor_slices(tuple(datas))
    batched_dataset = dataset.batch(batch_size)
    iterator = batched_dataset.make_one_shot_iterator()
    next_iters = list(iterator.get_next())
    return next_iters
def train_input_fn():
    imgs, labels = ndarray_iters([mnist.train.images, mnist.train.labels], 128)
    return {'images': imgs}, labels
model.train(train_input_fn, steps=1000)

@jsimsa : Mind taking a look? Thanks.

@traveller59 the problem is rooted in the fact that from_tensor_slices will create a constant-value tensor that has the raw data, which will be recorded in GraphDef.
An alternative approach to achieve the behavior you are hoping for is to use tf.data.from_generator:
...
def make_generator(images, labels):

  def _generator():
    for image, label in zip(images, labels):
      yield image, label

  return _generator

def train_input_fn():
  mnist = input_data.read_data_sets('/tmp/data/', one_hot=False)
  dataset = tf.data.Dataset.from_generator(
      make_generator(mnist.train.images, mnist.train.labels),
      (tf.float32, tf.float32))
  batched_dataset = dataset.batch(batch_size)
  iterator = batched_dataset.make_one_shot_iterator()
  imgs, labels = list(iterator.get_next())
  return {'images': imgs}, labels
...

Thanks, it seems that from_tensor_slices should be deprecated.


Fix UPM package generation issues for UWP

Fixes issue #397
Fixes issue #404
Fixes Issue #405

It would be great to get a new release out if/when this gets merged since the current UPM package in the releases is not usable for UWP without the asmdef files and proper DLLs

FYI, it looks like even with the changes above, the GLTFSerialization DLLs still don't seem to be getting created by the msbuild step of the Travis build. My current guess is that the Travis build is working with an OSX image which might be missing UWP DLLs? I only have a Windows machine and the msbuild step works fine there. What doesn't make sense is that the net35 and netstandard13 dlls get built properly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: AdamMitchell-ms:white_check_mark: rferrese:white_check_mark: ei2kpi-ptc:white_check_mark: admachina:x: sbtronYou have signed the CLA already but the status is still pending? Let us recheck it.

@AdamMitchell-ms this PR should now be ready to be merged.
I still need to chat with someone about enabling Azure Pipelines. I have it working in my fork. (See release: https://github.com/ei2kpi-ptc/UnityGLTF/releases/tag/v1.0.2)


NavLink fails on urls with special characters in them.

Appears to impact react-router versions 4 and above.
Test Case
https://codepen.io/thecodeviking/pen/KogaJR
Steps to reproduce

Create a <NavLink />.
Set the to to a value that includes (*).
Notice that things don't render as expected.

Expected Behavior
To see a nice, shiny <NavLink />!
Actual Behavior
An exception is thrown:
react-router-dom.js:4100 Uncaught SyntaxError: Invalid regular expression: /^\/paper\/Extended-Symptom-Code-((?:*))-the-Extended-Sympto\/1(?:\/(?=$))?(?=\/|$)/: Nothing to repeat
    at new RegExp (<anonymous>)
    at tokensToRegExp (VM3961 react-router-dom.js:4100)
    at stringToRegexp (VM3961 react-router-dom.js:4028)
    at pathToRegexp (VM3961 react-router-dom.js:4131)
    at compilePath (VM3961 react-router-dom.js:4150)
    at matchPath (VM3961 react-router-dom.js:4179)
    at Route.computeMatch (VM3961 react-router-dom.js:4285)
    at new Route (VM3961 react-router-dom.js:4254)
    at constructClassInstance (VM3960 react-dom.development.js:6897)
    at updateClassComponent (VM3960 react-dom.development.js:8381)

Already fixed in #5596


Delay when blurring textareas on the demo

https://jsfiddle.net/1v03Lqnu/
I have like a half second delay when I unfocus out of every textarea.
Is there a way to not have this?
Thanks for reading.

Using which browser?
Cannot reproduce using Chrome with all extensions disabled.

Chrome Version 59.0.3071.115
Ubuntu 16.04.2 LTS
here's a gif (I click the instant the mouse stops moving on every textarea)
https://imgur.com/a/RseBH

I have added debugging info which outputs the focus and blur time for each emojiOneArea
See https://jsfiddle.net/1v03Lqnu/768/
Please recreate your GIF with this jsfiddle (including the console.log output in the recording)

Here's my results, now trying on chrome with no extensions on MacBook Pro 2011. My previous machine is from 2012. I still consider them ok enough, but it makes a lot of sense that you're getting less delay.
https://i.imgur.com/NdoJ1F0.png
But still, why are these delays happening? What work is being done when you blur a textarea? Is there a way to turn that off or reuse a textarea?

it makes a lot of sense that you're getting less delay.

I'm working on a 2017 iMac, but I'm not sure I am seeing a lower delay than you.
Based on your output, we are both seeing roughly a 120ms between blurring one emojieoneArea and fully focusing the next (including OSX painting the blue focus rect)
This delay has not been an issue for me if Im honest, although I am now curious as to what's causing it
Below is the performance audit from Chrome
It does confirm the 120ms timeframe, but also suggests the 120ms is split equally in jQuery.trigger() and emojioneArea.trigger()
https://i.imgur.com/Spe9kTk.png
I'm not familiar enough with the codebase to know what might be causing this, but it's possible it could be improved. I'll try to dig into it over the next few days.

Is there a way to turn that off or reuse a textarea?

Bear in mind though, that when you create an emojioneArea, you are no longer using a native textarea.
It sets the source input element to display:none, and then appends a set of divs
It cannot ever be as responsive as a native textarea, but thats not to say there isn't also a performance bottleneck in emojioneArea somewhere

Caused because of triggering search.keypress event after each focus and blur event
As a quick solution set search option to false
Example: https://jsfiddle.net/mervick/1v03Lqnu/772/

@mervick yup, genius :)
This is a recent change I think....
https://github.com/mervick/emojionearea/commit/fe2cc23fc5322523f9e1b46ac31bcfda0477e6b3

@carpii no, it's not that place

@mervick oh okay :)

Fixed in the latest release v3.2.6
example https://jsfiddle.net/mervick/1v03Lqnu/776/

@carpii @mervick Thanks a lot for responding this, cheers.


Compara update

A few updates to be compatible with the latest Compara API

I don't know if this script is used but if it is, it needs the changes I'm proposing. If it's not used, you may consider dropping it ;)

We don't use it anymore, we use the one from production. Thanks for fixing it


Frida console: typing Swift. crashes the app process

Observed on iOS 14.2. Just typing on the Frida console: Swift. crashes the app. It happens on any pre-installed app that belongs to iOS (Messages, App Store, ...).
      Connected to Apple iPhone (id=00008020-0001695C2EC3002E)

[Apple iPhone::Messages ]-> Swift.Process crashed: SIGABRT

***
Incident Identifier: 38CF3D02-0417-4456-9147-3B47BE1AAEEE
CrashReporter Key:   595f1e4e8d21aa3eadc5f578b8a3de5870f9ef0f
Hardware Model:      iPhone11,8
Process:             MobileSMS [2174]
Path:                /Applications/MobileSMS.app/MobileSMS
Identifier:          com.apple.MobileSMS
Version:             6000 (14.0)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           com.apple.MobileSMS [1038]

Date/Time:           2023-02-24 12:04:47.4189 +0100
Launch Time:         2023-02-24 12:04:24.1619 +0100
OS Version:          iPhone OS 14.2 (18B92)
Release Type:        User
Baseband Version:    3.01.01
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Triggered by Thread:  10

I tried to understand what is going wrong by identifying the code that makes the app crash. Therefore I checked out and built this project as described. Then  tried to add console.log statements to the code to narrow down the problematic code part.
Unfortunately this Typescript project seems to be configured rather strange as there is no console.log available and I am not familiar with such projects to make it work :(

This is due to using Module.unsureInitialized("CoreFoundation"), if there is no CoreFoundation loaded gum throws an error which crashes the app. This should probably be replaced with non-crashing code and at least make Swift.available return false.

Same issue happens on Android. Process terminated once typing Java or Java.available.
But this only happens to one specific apk, maybe there is some anti-frida/debugger machenism included(this apk has one .so file and used o-llvm, so it's hard to follow init_proc function which o-llvmed)

Also happening to me

Still happening to me with Frida 16.5.2 on iOS 16.7.10 rootless jailbroken with palera1n. Did anyone find a solution/workaround?


B905's autofix sets strict=False, but the suggested fix is strict=True

The docs for B905 state the suggested fix is to use strict=True, but the autofix introduced here autofixes with strict=False.
Either the docs or the autofix should be updated to match the other.
I would argue that the autofix should be changed to strict=True, since that is the option less likely to cause unexpected runtime behavior for users. It might cause runtime exceptions to be raised, but I personally would prefer those to silently continuing with potentially unintended behavior.

Keywords: B905, zip-without-explicit-strict
Current ruff version: 0.6.6
Minimal snippet:
zip(a, b)

Command invoked:
ruff check example.py --target-version=py311 --select=B905
Output:
example.py:1:1: B905 [*] `zip()` without an explicit `strict=` parameter
  |
1 | zip(a, b)
  | ^^^^^^^^^ B905
  |
  = help: Add explicit `strict=False`

Found 1 error.
[*] 1 fixable with the `--fix` option.

Expected output:
...
  = help: Add explicit `strict=True`
...

I wonder if we use strict=False to avoid changing the semantics / behavior of the code? I think this is probably correct, but we should recommend adding strict not necessarily strict=False in the message?

That also works! Just removing the autofix altogether and letting the user decide what they want. Based on personal experience I'd almost always want strict=True, but I see the counter-argument that it changes behavior, so it might not be a desirable autofix.

I don't think we should remove the autofix entirely though, just change the message.


No CLRF at the end of data

Hi,
I run into this issue:
exception 'Pheanstalk_Exception_ClientException' with message 'Expected 2 bytes of CRLF after 566 bytes of data' in /data/www/myproject/library/pheanstalk/classes/Pheanstalk/Connection.php:104
I understand that is caused by incorrectly writtne data, but have no idea, why data was written incorrectly. It's looks like rare case, but it leads to more problems.
My consumer tries to consume this job every loop with no luck, until I run out of memory because of other jobs increasing queue.
It's looks like it is not possible to delete this job, because I can't get its ID without rising an exception. Now I'm deleting incorect job manually, bu how can I do that using Pheanstlak?
I'm using beanstlkd ver. 1.10 and Pheanstalk ver 2.1.0

I'm also having this issue (beanstalkd 1.9, Pheanstalk 2.1.0).
Inspection shows that on occasions, jobs only containing NULL bytes are added. I don't know if this is caused by my application, Pheanstalk, or beanstalkd itself, but it does occur and it makes my consumer stuck due to the exception.
$ beanstool peek --state ready
id: 8574620, length: 6, priority: 1024, delay: 0, age: 90268, ttr: 1200
reserves: 46, releases: 0, buries: 0, kicks: 0, timeouts: 0
body:
"\x00\x00\x00\x00\x00\x00

For anyone in the future who hits this problem; the only way I could solve it was to telnet to the beanstalk instance, and call delete on the job. e.g.
telnet server 11300
Trying <IP_ADDRESS>......
Connected to <IP_ADDRESS>.
Escape character is '^]'.
use the_tube
USING the_tube
peek-ready
FOUND<PHONE_NUMBER> 284
{ json that's randomly terminated and not valid
delete<PHONE_NUMBER>
DELETED
peek-ready
FOUND 12345678 287
{ valid json ... }

Where FOUND<PHONE_NUMBER> 284 is [JOBID] [BYTE SIZE] .. so DELETE<PHONE_NUMBER> removes it.

This is the same as #111 .


Remove asl

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Partially fixes #48.

Packages shouldn't be vendored, new feedstocks should be produced and
dependencies setup.
ASL is under a custom license (not EPL) and may not be able to be
included here.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

This is the license found in one of the ASL files:
Copyright (C) 1997, 1998, 2000 Lucent Technologies
All Rights Reserved

Permission to use, copy, modify, and distribute this software and
its documentation for any purpose and without fee is hereby
granted, provided that the above copyright notice appear in all
copies and that both that the copyright notice and this
permission notice and warranty disclaimer appear in supporting
documentation, and that the name of Lucent or any of its entities
not be used in advertising or publicity pertaining to
distribution of the software without specific, written prior
permission.

IN NO EVENT SHALL LUCENT OR ANY OF ITS ENTITIES BE LIABLE FOR ANY
SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
THIS SOFTWARE.

It opens with the same sentence as MIT, but the rest doesn't match. Seems like a custom license maybe?

IPOPT downloads the ASL files from here: https://coin-or-tools.github.io/ThirdParty-ASL/

It looks like the test relies on AMPL/ASL. IPOPT comes with some examples, e.g. https://github.com/coin-or/Ipopt/tree/master/examples/hs071_cpp. We just need to run that instead.

I think we can probably build against ampl-mp if I can figure out the header and linker flags with ipopt 3.13.3.

The last commit worked locally. So I think we just remove ASL and depend on ampl-mp, which was the original setup.


Add column length config prop

This might be a rather lengthy change, but it would be great to have a line length property that would reformat sections of code that go over the limit.
Currently if my Ruler in sublime is set to 78, and I do a declaration like this:
    const {
      index, label, connectDropTarget, isOver, canDrop, onClick
    } = this.props

The formatter will break reformat the code to something that goes over my ruler setting:
    const {index, label, connectDropTarget, isOver, canDrop, onClick} = this.props

I would love to see this feature implemented.. but I'll leave it to a plugin, similar to esformatter-collapse-objects
adding this feature directly to esformatter would increase the complexity drastically and I'm trying to limit the scope of the project.
I updated the wish list on the wiki to include a link to this issue: https://github.com/millermedeiros/esformatter/wiki/Plugins#wish-list

PS: setting options to -1 will keep the existing line breaks; so you can set lineBreak.after.ObjectPatternComma = -1, lineBreak.after.ObjectPatternOpeningBrace = -1 and lineBreak.before.ObjectPatternClosingBrace = -1 to bypass the automatic line break removal...

FYI, I've written a plugin that should take care of this. It still a very early piece of work, but it handles the cases that I needed it to. Check it out: https://github.com/pgelinas/esformatter-auto-wrap


Joining collaboration session: The host's network conditions are poor or they are no longer connected to the Live Share cloud relay. Ask them to check their network conditions, restart the collaboration session, and try again

Describe what happened:
What was your system configuration?
Product and Version [VS/VSCode]:
OS Version[macOS/Windows]:
Live Share Extension Version:
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Please attach logs to this issue:
You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
Screenshots
If applicable, add screenshots to help explain your problem.

Hey @Lzinoo , are you sure this error message was inaccurate?

Apologies for the delay here. As is, this issue doesn’t have enough information to be reproduced. Please reopen if the issue persists with additional details. Thank you.


Excess field shown in INTERFACE

Suppose I have a field in an interface
CONTEXT IssuePrototype110

RELATION usedAt[Thing*Location]
 = [ ("o1", "L1")
   , ("o1", "L2")
   , ("o1", "L3")
   ]

INTERFACE Things : "_SESSION"[SESSION];V[SESSION*Thing] BOX
   [ things : I ]

INTERFACE Ifc FOR User: I[Thing] BOX
   [ "used at " : usedAt[Thing*Location] cRUd
   ]

ENDCONTEXT

In this example, the user cannot create new locations (c is lowercase) and the relation usedAt supports multiple locations per Thing (usedAt is not univalent).
In my browser, this is what I see in INTERFACE Ifc:

Feature request
I would like to see the "Add Location" field only if there is something to add. In this example, there is nothing to add and the empty box unjustly suggests that I can add a location.
So, in case the CRUD of a field forbids creation and allows update, and the population shown contains all elements of the concept, do NOT display a field to add an atom.

@Michiel-s did you do the check? Can we close this?

It is implemented, but there is a bug I think. The ngIf for hiding the dropdown box uses a different options list compared to the filtered list for the options.
So currently the options don't show the items that are already included in the relation (that is good), but the dropdown is not hidden is there are no options.


Issue integrating with Better Uptime

Hi, I'm working on integrating with Better Uptime, which delivers a pretty simple JSON payload such as:
{
  "data": {
    "id": "269291285",
    "type": "incident",
    "attributes": {
      "name": "test10122.com",
      "url": "https://test10122.com",
      "http_method": "get",
      "cause": "DNS lookup failure",
      "started_at": "2020-10-21T10:51:28.151Z",
      "acknowledged_at": "",
      "resolved_at": "2020-02-25T17:38:45.768Z",
      "response_content": "",
      "response_url": "",
      "screenshot_url": ""
    }
  }
}

I've configured a new source and the event handler is successfully publishing messages. However, once the betteruptime-parser picks up the message, it fails to enter the data into BigQuery:
{
  "severity": "WARNING",
  "msg": "Data not saved to BigQuery",
  "errors": "Expecting ':' delimiter: line 5 column 21 (char 85)",
  "json_payload": {
    "message": {
      "attributes": {
        "headers": "{\"Host\": \"event-handler-xrnfncty5q-uc.a.run.app\", \"Accept\": \"*/*\", \"User-Agent\": \"Better Uptime Bot Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36\", \"Content-Type\": \"application/json\", \"X-Betteruptime-Token\": \"484f82f66680403e2918068268b5b0dad665011c\", \"Content-Length\": \"498\", \"X-Cloud-Trace-Context\": \"c346b684b4a02ba7667827a4c28c2c66/6849582948624458081;o=1\", \"Traceparent\": \"00-c346b684b4a02ba7667827a4c28c2c66-5f0e9b66b0556161-01\", \"X-Forwarded-For\": \"2a01:4f8:251:53df:0:242:ac11:a\", \"X-Forwarded-Proto\": \"https\", \"Forwarded\": \"for=\\\"[2a01:4f8:251:53df:0:242:ac11:a]\\\";proto=https\"}"
      },
      "data": "ew0KICAiZGF0YSI6IHsNCiAgICAiaWQiOiAiMjY5MzczODQ2IiwNCiAgICAidHlwZSI6ICJpbmNpZGVudCIsDQogICAgImV2ZW50X3N0YXR1czogInJlc29sdmVkIiwNCiAgICAiYXR0cmlidXRlcyI6IHsNCiAgICAgICJuYW1lIjogInBsZWFzZWlnbm9yZTEwMTAxMDEuY29tIiwNCiAgICAgICJ1cmwiOiAiaHR0cHM6Ly9wbGVhc2VpZ25vcmUxMDEwMTAxLmNvbSIsDQogICAgICAiaHR0cF9tZXRob2QiOiAiZ2V0IiwNCiAgICAgICJjYXVzZSI6ICJETlMgbG9va3VwIGZhaWx1cmUiLA0KICAgICAgInN0YXJ0ZWRfYXQiOiAiMjAyMi0wOC0yN1QyMjoyOTozMFoiLA0KICAgICAgImFja25vd2xlZGdlZF9hdCI6ICIiLA0KICAgICAgInJlc29sdmVkX2F0IjogIjIwMjItMDgtMjdUMjI6MzA6MjJaIiwNCiAgICAgICJyZXNwb25zZV9jb250ZW50IjogIiIsDQogICAgICAicmVzcG9uc2VfdXJsIjogIiIsDQogICAgICAic2NyZWVuc2hvdF91cmwiOiAiIg0KICAgIH0NCiAgfQ0KfQ0K",
      "messageId": "5465397931554304",
      "message_id": "5465397931554304",
      "publishTime": "2022-08-27T22:30:23.447Z",
      "publish_time": "2022-08-27T22:30:23.447Z"
    },
    "subscription": "projects/a21-dora-metrics-360722/subscriptions/betteruptime-subscription"
  }
}

Here's where I am with my parser function:
def process_betteruptime_event(msg):
    signature = shared.create_unique_id(msg)
    metadata = json.loads(base64.b64decode(msg["data"]).decode("utf-8").strip())

    event_id = metadata["data"]["id"]
    event_type = metadata["data"]["type"]

    # most up to date timestamp for the incident
    time_created = (metadata["data"]["attributes"]["started_at"] or
                    metadata["data"]["attributes"]["acknowledged_at"] or
                    metadata["data"]["attributes"]["resolved_at"])

    betteruptime_event = {
        "event_type": event_type,
        "id": event_id,
        "metadata": json.dumps(metadata),
        "time_created": time_created,
        "signature": signature,
        "msg_id": msg['message_id'],
        "source": "betteruptime",
    }

    print(betteruptime_event)
    return betteruptime_event

Please let me know if anyone has any thoughts on what I'm missing. Thanks!

Turns out Better Uptime was sending corrupt JSON data. I was able to get this sorted out so this can be closed!

Hi @encausticcello
Feel free to open up a PR with your Better Uptime integration, we'd love to have a look!
Thanks!


[BugFix][Build] ubuntu aarch64 use conda aarch64.sh #5053

#5053

I just registered a personal account on Code Facebook

PTAL


Fix concurrent next middleware request handlers and recurse next request handlers

This PR fixes concurrently calling the next middleware request handler multiple times. Admittedly, while allowed, this is a rather uncommon situation.
Also, while I'm at it, this PR also avoids wrapping the return value from the request handler in another promise. The request handler will either return a promise or a value that can be consumed directly. When running example 99 with included benchmarking instructions, this simple change improves performance from ~2500 req/s to ~2600 req/s on my local machine. Also, running the (very synthetic) tests/benchmark-middleware-runner.php improved from ~12s to ~2s on my local machine.
Promise cancellation for pending middleware handlers was previously untested, but I did not encounter any issues here. I've added related tests to achieve 100% test coverage for this class.
Builds on top of #292

@clue Test failing for 5.3

Updated to use $that reference :shipit:

:+1:


Add my first file

I have created a new branch, creted a file, and made a commit

dando los primeros pasos


Suggestion. Add whitelist dimensions.

I think will be very useful to add whitelist dimensions. For example, I have ancient warfare. This mod is nice, but works bad with traverse generation, so, I am going to a special dimension, where I am going to use default generation, without traverse. But I do not see the way to do so.

It would be up to the mod that adds the dimension to control what biomes spawn in it.


Opening Atom on MacOS from Desktop results in High CPU usage

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode

^ ~Have not done this as it doesn't fit my case.~ Ran: /Applications/Atom.app/Contents/MacOS/Atom --safe instead of atom --safe, issue persists.

Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom

^ Closed: #13317, #13084.

Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

^ Not applicable

Description
Similar issue to the closed issues of #13317 and #13084.
I believe it is the same problem, however, I am not using Linux but MacOS.
Steps to Reproduce

Open Atom from Desktop mode on a Mac. (Click any file that would be opened by Atom, or click the app itself. )
do ps aux | grep zsh and observed the dangling /bin/zsh -ilc command env processes.

Quote from #13084:

Expected behavior: 'What a nice normal text-editing experience this is'
Actual behavior: WOOOOOOOOSSHHHH goes the laptop fan

Additionally, atom does not respond ~if clicked on the following buttons: About Atom, View License~
to any operation that involves opening a file.
I have not test all buttons so there may be more.
Reproduces how often:
Only if I launch atom from Desktop mode, it works perfectly fine if launched from terminal.
For my use case I rarely does this so I did not notice the issue until now, it could have been there for a while.
Versions

Atom    : 1.57.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

MacOS: 11.4（20F71）
SHELL: zsh 5.8 (x86_64-apple-darwin20.0)
Additional Information

Since I rarely launch atom from Desktop, it does not affect me much.
Hence the current workaround is to launch atom from a shell.
As stated in the closed issue of #13084, it is likely due to the shell out process.
The reason that it does not affect Atom started from a shell is because ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT=true is set in atom.sh.
Launching Atom from shell via /Applications/Atom.app/Contents/MacOS/Atom --safe will trigger the same issue, as that is the executable that will be ran if launched in Desktop mode.  ( This is how MacOS Applications works. )

I found the cause for the bug, in my .zshrc file I did:
# make zsh appears to load faster.
precmd
print -Prn $PROMPT

I made zsh's interactive command prompt prints stuff on startup to make it appears to load up quicker ( inspired by powerlevel10k ), and that upsets the Atom app in which it doesn't terminate.
I tried printing to /dev/stderr  instead of /dev/stdout but it did not solve the problem without removing the text printing commands in .zshrc.
I don't think that it is not acceptable to print stuff to stdout in .zshrc, since it is supposed to be sourced for interactive prompt only.
I think an App or script should be running /bin/zsh -lc command env instead of /bin/zsh -ilc command env, or perhaps allowing one to disable the shelling out behaviour as an option.  ( I know about the command line variable of ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT, but I am not sure I can config it for Desktop mode. )
Is that not possible to allow such options for the use case of Atom?

I wrote this so I will just quote it.
from: https://github.com/desktop/desktop/issues/12320#issuecomment-855270118

...
Interesting.  Well I tested my precmd and it seems that this is keeping zsh alive:
# Took from: https://superuser.com/questions/357107/zsh-right-justify-in-ps1
prompt-length() {
   emulate -L zsh
   local -i COLUMNS=${2:-COLUMNS}
   local -i x y=${#1} m #MAX_acc=1000 acc=1
   if (( y )); then
       while (( ${${(%):-$1%$y(l.1.0)}[-1]} )); do
           x=y
           (( y *= 2 ))
#          (( acc += 1 ))
       done
#      unset acc;
#      local -i acc=1;
       while (( y > x + 1 )); do
           (( m = x + (y - x) / 2 ))
           (( ${${(%):-$1%$m(l.x.y)}[-1]} = m ))
#          (( acc += 1 ))
       done
   fi
   print "$x"
}

The function is used to allow one to create a multi-lined left and right aligned PROMPT.
The logic of cryptic lines like: ${${(%):-$1%$y(l.1.0)}[-1]} is to first do PROMPT expansion ( like colours, etc. ) for $1, then
see if its length is less then the integer in $y, append '1' to $1, else append '0'.  [-1] extract the trailing 0 or 1.
The rest should be fairly readable.
The code is basically a binary search to determine the length of the interpolated string.
I had tried to make sure the loop terminates by setting a maximum amount of iteration, but they do nothing so I commented them out / removed them.  The loop should always terminate regardless, which it does, as a matter of fact I am using it daily with no issues.  For some reason the behaviour is different when the shell is spawned by child_process.
I am puzzled with this.
At the moment, bypassing this function on startup seems to have stopped the issue from happening.

Doesn't seem Atom-specific...

I've been experiencing the same. It has been hogging CPU with the app shut:


Refactor tests to use proptest

First refactors the test suite to test the lower-level function that takes ABI types, in addition to the user trait method.
Then, refactors those tests to use proptest to search a wide variety of inputs. For now, we only search for inputs that are valid (neither the lower function nor the user trait should throw an error).

Since, as you mentioned offline, are busy with other stuff for the moment, I hope you won't mind if I merge this PR in. If you feel I've missed something, etc., please feel free to reopen or submit an issue, etc. :-)


Sweep: Github oauth app - callback url? / constantly redirecting

Details
I just tried setting up OpenPipe as per the documentation, I created the Github oauth app but wasn't sure what to put in the callback URL - should this just be your local install base URL?
I suspect this is what is causing my instance to load -> redirect to github (and auth fine) -> redirect back to my app -> redirect back to github etc... over and over forever.

Yes, the callback URL should point to your local install: http://localhost:3000/api/auth/callback/github.
Would you mind updating the README to reflect that as well? Definitely an oversight on our part!

@corbt May I make changes to README File for above ?

Ah, great thanks! also - https://github.com/OpenPipe/OpenPipe/pull/228


Ping command

add ping command

add ping command

What do you mean by a "ping" command?

add ping command

What do you mean by a "ping" command?

checks latency. It is important for a discord bot

Not important for an IsleWard bot though


testcontainers gradle plugin - integration tests

Need some help with gradle java plugin. Anyone here has experiance with gradle sourceset?
https://github.com/gadieichhorn/gradle-java-multimodule/tree/master/buildSrc

./gradlew clean build e2e

still getting some exceptions with missing dependencies.
...

/home/geichhorn/Develop/github/gradle-java-multimodule/deploy/rest/src/integration/java/com/rds/example/gradle/deploy/DeployTest.java:16: error: cannot find symbol
    private static GenericContainer main = new GenericContainer("com.rds.example.gradle/rest:latest")
                                               ^
  symbol:   class GenericContainer
  location: class DeployTest

...

happy to contribute this plugin to the project :)

have a seperated sourcestet for integration tests (with testcontainers)
seperate gradel task for running these tests ('e2e')

Hey @gadieichhorn,
sorry I have no experience in writing Gradle plugins.
What's the actual use case of the plugin? We are using the same approach using https://github.com/unbroken-dome/gradle-testsets-plugin, which works quite fine.

Thanks @kiview on wich project are you using it?
My use case is to seperate my testcontainers integration tests from all other build/test cycle. Integration tests depends on the docker build so it must run after it.

We are using it like this at work.
Check out the plugin, it should fit your usecase 100%, no need to write a custom plugin then.

I close this issue, hope the plugin solved your problem @gadieichhorn.


dynatrace_key_user_action timing issue

Describe the bug
When creating a KUA through the new dynatrace_key_user_action resource and then using the new resources to configure SLOs, we occasionally obtain the error:
09:22:52  │ Error: User action is not subscribed: APPLICATION_METHOD-2E43715FFF2ED6AC
09:22:52  │
09:22:52  │   with module.Application_test-de-base.dynatrace_web_app_key_performance_load.kua_apdex_load["Loading of page /test/transaction2"],
09:22:52  │   on ../../src/modules/blueprints/Application/main.tf line 239, in resource "dynatrace_web_app_key_performance_load" "kua_apdex_load":
09:22:52  │  239: resource "dynatrace_web_app_key_performance_load" "kua_apdex_load" {

This issue was fixed when KUAs were configured directly in the Web Application resource. This seems to be a regression, where the provider is not waiting to verify that the KUA is fully created in Dynatrace.
Code sample from our modules:
resource "dynatrace_key_user_action" "kua_with_apdex" {
  for_each = local.kua_with_apdex

  application_id = dynatrace_web_application.application.id
  domain         = each.value[0].domain
  name           = each.key
  type           = "Load"
}

resource "dynatrace_web_app_key_performance_load" "kua_apdex_load" {
  for_each = dynatrace_key_user_action.kua_with_apdex

  kpm   = "VISUALLY_COMPLETE"
  scope = each.value.id

  thresholds {
    frustrating_threshold_seconds = local.kua_with_apdex[each.value.name][0].apdex.seuil_frustrant
    tolerated_threshold_seconds   = local.kua_with_apdex[each.value.name][0].apdex.seuil_tolerable
  }
  fallback_thresholds {
    frustrating_fallback_threshold_seconds = local.kua_with_apdex[each.value.name][0].apdex.seuil_frustrant
    tolerated_fallback_threshold_seconds   = local.kua_with_apdex[each.value.name][0].apdex.seuil_tolerable
  }
}

Expected behavior
Newly created KUAs should be usable in the same Apply run in a deterministic fashion.
Additional context
Provider version 1.45.0

Hello @mattBaumBeneva, I am pretty sure that this is a side effect of #345.
As explained on the other ticket, I am hoping to provide a proper solution early next week.

Closing this issue, because I am pretty sure that it's a side effect of #345. Fix already commited.


Full lifecycle management of the project

Motivation
As we know, LCM (life-cycle management) of one project SHOULD contain these stages below: design, coding, building, testing, deployment and releasing. From this point, opensds controller project is far away from being ready for producibility. Inside these stages, we still did poor work in building, testing, deployment and releasing these four stages.
What should we do?
Building
As for building work, currently we use go build tool to manage the whole project. Although it works well now, but IMO there will be more problems as this project grows.
So I suggest we add more building options (make, shell scripts and so forth) for system scalability and availability.
Testing
A productive testing framework should contain unit test, integration test and e2e test. Right now we are trying to work on unit test, but never forget those two others. Considering there are so many mature testing frameworks, it would be a good choice if we build our integration and e2e test on popular opensource project (ginkgo etc).
Deployment
With the development of IaaS and PaaS, automatic deployment and installation become more and more important in a distributed system cluster. As a cloud-native storage system, opensds controller project MUST support (at least one of) automatic deployment as shown below:

Scripts
Automatic tools (such as ansible)
Containerization (docker, helm, bosh etc)

Releasing
To be ready for productization, publishing a release is the necessary but complex work. Here are some references from some other popular projects (service catalog, osba) for better understanding.
Lastly, please notice that it is just some initial thoughts from my side about what a formal project should be, so more suggestions or comments are welcomed.

Good news for this issue is that we have finished the initial development of first three parts. But I suggest we should speed it up since there is not time left.

Here I'm execited to tell you we almost finish the famework of full project! Thanks everyone for contributing in and supporting this project!

good job!


besm4e

Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

I don't know why those other files changed, I never even looked at them. And I don't know how to change this to a draft.


 (GitHub actions all turns green)
[x] CLA has been signed

Description

please describe the changes that you are making, with the related issue number.

Good catch! Thank you very much for the fix!


combine #'depth-range & #'depth-clamp ?

Isn't depth-clamp just how you enable using the depth range?

Nope! just checked with top men and I was wrong:

glDepthRange applies a transform to the depth coordinate during viewport-mapping.
GL_DEPTH_CLAMP clamps the fragment depth coordinate instead of clipping to the near/far-planes


How to simulate failure scenario ?

The source code that I am creating unit tests has a lot of try catch block. How do I simulate failure scenario, so I can cover those catch blocks ? Is there I way we can customize the response or reply code of the different SFTP commands ?

Can you give an example of such a failure scenario?

Can you give an example of such a failure scenario?

Let"s say there is a network communication failure.

For simulating network failures I suggest to use a proxy that can simulate network errors. For network errors you usually don't get an answer from the SFTP server at all and therefore this behaviour is not something I would like tom implement in the SFTP server.


Revert libVer changing and change the ext ver

Fix libver changing to ext ver changing

Fixes #348 lib ver not updating


Export Amplify backends to Python CDK not working

Initial environment of AWS
Admin:~/environment $ cdk --version
2.3.0 (build beaa5b2)
Admin:~/environment $ amplify --version
bash: amplify: command not found
Admin:~/environment $ npm list
ec2-user@ /home/ec2-user
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Admin:~/environment $ python --version
Python 3.7.10
Admin:~/environment $ pip freeze
astroid==2.3.0
aws-cfn-bootstrap==2.0
backcall==0.2.0
botocore==1.23.27
decorator==5.1.0
Django==2.0.2
docutils==0.14
git-remote-codecommit==1.16
ikp3db==1.4.1
importlib-metadata==4.10.0
ipython==7.30.1
isort==4.3.21
jedi==0.18.1
jmespath==0.10.0
lazy-object-proxy==1.7.1
lockfile==0.11.0
matplotlib-inline==0.1.3
mccabe==0.6.1
parso==0.8.3
pbr==5.8.0
pexpect==4.8.0
pickleshare==0.7.5
prompt-toolkit==3.0.24
ptyprocess==0.7.0
Pygments==2.11.1
pylint==2.4.4
pylint-django==2.3.0
pylint-flask==0.6
pylint-plugin-utils==0.7
pystache==0.5.4
python-daemon==2.2.3
python-dateutil==2.8.2
pytz==2021.3
simplejson==3.2.0
six==1.16.0
stevedore==3.5.0
traitlets==5.1.1
typed-ast==1.5.1
typing-extensions==4.0.1
urllib3==1.26.7
virtualenv==16.2.0
virtualenv-clone==0.5.7
virtualenvwrapper==4.8.4
wcwidth==0.2.5
wrapt==1.13.3
zipp==3.7.0
Admin:~/environment $ node -v
v16.13.1

install amplify
Admin:~/environment $ npm install -g @aws-amplify/cli
Admin:~/environment $ npm list
ec2-user@ /home/ec2-user
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Admin:~/environment $ npm list -g
/home/ec2-user/.nvm/versions/node/v16.13.1/lib
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
setup amplify project
Admin:~/environment $ mkdir amplify-proj && cd amplify-proj
Admin:~/environment/amplify-proj $ amplify init -y
Admin:~/environment/amplify-proj $ amplify add api && amplify push
Admin:~/environment/amplify-proj $ amplify add api

? Select from one of the below mentioned services: GraphQL
? Here is the GraphQL API that we will create. Select a setting to edit or continue Continue
? Choose a schema template: Single object with fields (e.g., “Todo” with ID, name, description)

⚠  WARNING: your GraphQL API currently allows public create, read, update, and delete access to all models via an API Key. To configure PRODUCTION-READY authorization rules, review: https://docs.amplify.aws/cli/graphql/authorization-rules

GraphQL schema compiled successfully.

Edit your schema at /home/ec2-user/environment/amplify-proj/amplify/backend/api/amplifyproj/schema.graphql or place .graphql files in a directory at /home/ec2-user/environment/amplify-proj/amplify/backend/api/amplifyproj/schema
? Choose your default editor: Visual Studio Code
Couldn’t find selected code editor (vscode) on your machine.
? Try opening with system-default editor instead? Yes
✅ Successfully added resource amplifyproj locally

✅ Some next steps:
"amplify push" will build all your local backend resources and provision it in the cloud
"amplify publish" will build all your local backend and frontend resources (if you have hosting category added) and provision it in the cloud

change directory
Admin:~/environment/amplify-proj $ cd ../
downgrade CDK
Admin:~/environment $ npm uninstall cdk -g
Admin:~/environment $ npm i<EMAIL_ADDRESS>-g

setup CDK project
Admin:~/environment $ mkdir cdk-proj && cd cdk-proj
Admin:~/environment/cdk-proj $ cdk init sample-app --language python
Admin:~/environment/cdk-proj (master) $ python -m venv .venv
Admin:~/environment/cdk-proj (master) $ source .venv/bin/activate
(.venv) Admin:~/environment/cdk-proj (master) $ pip install --upgrade pip
(.venv) Admin:~/environment/cdk-proj (master) $ pip install -r requirements.txt
(.venv) Admin:~/environment/cdk-proj (master) $ cdk bootstrap
(.venv) Admin:~/environment/cdk-proj (master) $ cdk deploy
Do you wish to deploy these changes (y/n)? y
# cdk deployment succeed　if there's not amplify exported backend

export amplify backend
(.venv) Admin:~/environment/cdk-proj (master) $ cd ../amplify-proj/
(.venv) Admin:~/environment/amplify-proj $ amplify export --out ../cdk-proj/

install python library
(.venv) Admin:~/environment/cdk-proj (master) $ cd ../cdk-proj/
(.venv) Admin:~/environment/cdk-proj (master) $ pip install aws-amplify.cdk.exported-backend

modify cdk-proj/cdk_proj/cdk_proj_stack.py
from aws_cdk import (
    aws_iam as iam,
    aws_sqs as sqs,
    aws_sns as sns,
    aws_sns_subscriptions as subs,
    core
)
from aws_amplify.cdk.exported_backend import AmplifyExportedBackend

class CdkProjStack(core.Stack):

    def __init__(self, scope: core.Construct, construct_id: str, **kwargs) -> None:
        super().__init__(scope, construct_id, **kwargs)

        queue = sqs.Queue(
            self, "CdkProjQueue",
            visibility_timeout=core.Duration.seconds(300),
        )

        topic = sns.Topic(
            self, "CdkProjTopic"
        )

        topic.add_subscription(subs.SqsSubscription(queue))

        AmplifyExportedBackend(self, id="AmplifyExportedBackend",
        path="amplify-export-amplifyproj", amplify_environment="dev")

(FAILURE) CDK DIFF
(.venv) Admin:~/environment/cdk-proj (master) $ cdk diff
jsii.errors.JavaScriptError:
  TypeError: _.get is not a function
      at AmplifyExportAssetHandler.referenceDeploymentBucket (/tmp/jsii-kernel-MYu61N/node_modules/@aws-amplify/cdk-exported-backend/lib/export-backend-asset-handler/index.js:29:40)
      at new AmplifyExportAssetHandler (/tmp/jsii-kernel-MYu61N/node_modules/@aws-amplify/cdk-exported-backend/lib/export-backend-asset-handler/index.js:25:38)
      at new AmplifyExportedBackend (/tmp/jsii-kernel-MYu61N/node_modules/@aws-amplify/cdk-exported-backend/lib/export-backend.js:33:38)
      at /tmp/tmp6hjkb0zd/lib/program.js:8432:58
      at Kernel._wrapSandboxCode (/tmp/tmp6hjkb0zd/lib/program.js:8860:24)
      at Kernel._create (/tmp/tmp6hjkb0zd/lib/program.js:8432:34)
      at Kernel.create (/tmp/tmp6hjkb0zd/lib/program.js:8173:29)
      at KernelHost.processRequest (/tmp/tmp6hjkb0zd/lib/program.js:9757:36)
      at KernelHost.run (/tmp/tmp6hjkb0zd/lib/program.js:9720:22)
      at Immediate._onImmediate (/tmp/tmp6hjkb0zd/lib/program.js:9721:46)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "app.py", line 9, in <module>
    CdkProjStack(app, "cdk-proj")
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/jsii/_runtime.py", line 86, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/home/ec2-user/environment/cdk-proj/cdk_proj/cdk_proj_stack.py", line 28, in __init__
    path="amplify-export-amplifyproj", amplify_environment="dev")
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/jsii/_runtime.py", line 86, in __call__
    inst = super().__call__(*args, **kwargs)
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/aws_amplify/cdk/exported_backend/__init__.py", line 286, in __init__
    jsii.create(self.__class__, self, [scope, id, props])
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/jsii/_kernel/__init__.py", line 297, in create
    for iface in getattr(klass, "__jsii_ifaces__", [])
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/jsii/_kernel/providers/process.py", line 344, in create
    return self._process.send(request, CreateResponse)
  File "/home/ec2-user/environment/cdk-proj/.venv/lib64/python3.7/site-packages/jsii/_kernel/providers/process.py", line 326, in send
    raise JSIIError(resp.error) from JavaScriptError(resp.stack)
jsii.errors.JSIIError: _.get is not a function
Subprocess exited with error 1

Closing as a duplicate of https://github.com/aws-amplify/amplify-cli/issues/12447


Startup script parses python 3.10 as 3.1

The [:3] to parse python version fails to account for versions like 3.10 and parses them as 3.1; search path is set to /usr/lib/python3.1/site-packages instead of /usr/lib/python3.10/site-packages leading to ERROR: wxglade.py not found!
https://github.com/wxGlade/wxGlade/blob/70d8d037998730dc350ae4345df7fd039ed0d63c/wxglade#L41

Was just about to report this.

Sorry for the long delay. Somehow I missed this one....
A fix is in the repository for both master and REV_1.0 branches.

revision 1.0.5 about to be released


put common auth logic into func

Hi,
This is a PR in a serie of 6 PRs, as it was asked to split https://github.com/freifunkMUC/wg-access-server/pull/294 up into multiple PRs.
Serie:

feature/bring-your-own-public-key
feature/remove-all-devices-for-user
feature/purge-inactive-devices
feature/health-check
(THIS PR) hygiene/put-common-auth-logic-into-func
feature/pre-shared-keys

Code Hygiene:
There are no new features but some cleanups:

hardcoded checks are outsourced in a function
login related code is moved to the authnz package
a failed login gives reasonable status codes
the node version for building the proto stubs is updated

@fbuetler can you rebase your changes again? After that we can merge your PR

I think the linting errors have to be resolved on the master branch as they were not introduced by this branch. I guess these errors appreared after a linter update.
See:
https://github.com/freifunkMUC/wg-access-server/commit/4766783771c231f6243389c70e82761b4b8c9be1
https://github.com/freifunkMUC/wg-access-server/pull/305


Android 2.2 could not use it.

I used Android 2.2, with kernel <IP_ADDRESS>-g66cfb7a and baseband is 12.28b.60.140u_<IP_ADDRESS>.
unforturnately, I can not use application when I login...
Any solutions? Thanks so much.

Android 2.2 is no longer supported, as the app now targets a minimum SDK version of 15.


Change documentation resources?

I found it easier to consult the Node.JS Driver Documentation rather than the documentation on MongoDB.com, which is what learnyoumongo currently uses.

I think this makes total sense. In the PR, references to syntax now point to the Node.js driver, but I left the links which point to general MongoDB concepts for some topics.


rFOX not showing in Earn page in release

Overview
Currently in release, rFOX balances are not displaying in the earn page and thus are not calculated in net worth.
References and additional details
Test wallet balance in release:
test wallet balance in production:
Acceptance Criteria
rFOX balances show up in the earn page and are calculated in the 'My wallet' dashboard.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

No longer able to recreate.


MQTT is not delivering the system properties: correlation_id and message_id

OS and version used: Debian 8.9

Python runtime used: Python 2.7.9

SDK version used: 1.0.37

Description of the issue:
MQTT is not delivering the system properties: correlation_id and message_id
After correlation_id and message_id were set in IoTHubMessage, the reply message delivered to IoTHub does not contain correlation_id and message_id properties.  Please, see the example below,

Code sample exhibiting the issue:
info_json = "{ 'channel' : 'httpResp', 'status' : 'HTTP/1.1 200 OK', 'headers' : { "'Server' : 'nginx/1.11.4', 'Content-type' : 'application/json', 'Transfer-Encoding' : 'chunked' , 'Connection' : 'keep-alive' }, 'body' :  { 'data' } "
msg = IoTHubMessage(bytearray(info_json, 'utf8'))
Method 1
msg.correlation_id = 'value1'
msg.message_id = 'value2'
Method 2
msg_prop = msg.properties()
msg.pop.add('correlationId','value1')
msg.pop.add('messageId','value2')
client.send_event_async(msg, send_confirmation_callback, message_counter)
None of these methods work, the message sent does not contains the properties: correlation_id and message_id.
NOTE: For method 2, I used other possibilities of keys like: correlation_id, correlationId, CorrelationId, CorrelationIds
For our application is required and mandatory reply the correlation_id and message_id
Please, what can be done in order to fix this issue?

Console log of the issue:

No errors, the message is sent correctly, but, correlation_id and message_id are not delivered in the message

@neutronzz - This should have been fixed as of release 1.1.16. Can you please update your version to the latest and try again and let us know if still having any issues. Thanks.

Hi @tameraw
Thanks for your prompt reply. I updated my IoTHub client and now it is working fine.
The correlation_id and message_id are sent correctly.
I'm using IoT Hub SDK for C, version 1.1.20


How to get query's length ?

In mongodb I can use:
db.transaction.find().length()
As long as I can tell I can't use the length() function in mongojs

@mdennyh if you are interested in the number of documents that matches your query consider using count instead if find: db.collection.count(query)
Does this answer your question?

Ah You're right, It answers my question, Thank you. I used to query all the document I have to count its length


[Suggestion] Make content download asynchronnous

Waiting for linear GET requests takes a lot of time.

Will work on threading when I rewrite dash parsing and change how intermediary files are saved because currently I'm just taking segment downloads and appending them to a single ts file... And remux that to a single mp4 file.

Download was made asynchronous in rewrite version (#13) and in old version (#6)... closing.


Toyota: remove bad FW

Similar to https://github.com/commaai/openpilot/pull/28526
Added in https://github.com/commaai/openpilot/commit/bfa2d030d2927cb9cfdb01f8f1e614d3790d134b as part of a FW dump, likely a mistake. This FW should only be on the TSS-P Corolla.
Noticed when looking at shared part numbers, not having the length code (which usually means it's from the KWP query) is not common for TSS2 vehicles.

There's some EPS FW versions that don't have a length code in TSS2 vehicles, but looks those those are real, and EPS parts are shared across model years.


Embed new MI 1.2.0 into Integration Studio

Description:
Embed latest MI 1.2.0 into Integration studio.

Fixed with the following PRs.
https://github.com/wso2/devstudio-tooling-platform/pull/261
https://github.com/wso2/devstudio-tooling-platform/pull/262
https://github.com/wso2/devstudio-tooling-esb/pull/1124
https://github.com/wso2/devstudio-tooling-ei/pull/1002


[joss] Use ABC and abstractmethod rather than NotImplementedError

NotImplementedError has slightly different semantics and effects than using ABC and abstractmethod - ABC classes can't be instantiated without satisfying all their abstractmethods, vs. raising an error which might not be obvious until the class is actually used. This also allows for static analysis tools to warn you when you haven't completed all the abstractmethods :)
part of: https://github.com/openjournals/joss-reviews/issues/5266

Refer to rebased version -> #179


Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases.

I installed all the requirement as given once run the it shows (Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases.) this type of error please explain it sir

I haven't tested on Windows. Probably, try to use Linux on windows or Emulator. This will help a lot also in the dependency installation.

sir thank you for this response


Instance crd is updated in the cluster but not on BTP side

We are using BTP operator to manage the saas-registry instance. After updating the parameters secret and applying the service instance crd referencing updated parameters secret  - the instance parameters on BTP side didn't get updated.

bindings are not updated, create a new binding.

If bindings are immutable the btp-service-operator should prevent changes and enforce immutability?

It does enforce it, but you updated the instance and not the binding, instance update does not affect existing bindings.


Fix on publishBuildArtifacts task

Due to refactoring in vsotask.ts (https://github.com/Microsoft/vso-task-lib/blob/ac9584460d19f52b359e6af0cee19c6df9b90606/node/lib/vsotask.ts) the command function was removed and replaced with writeCommand.
My changes fix the publishbuildartifacts task.

Hi @ptoonen, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@ptoonen, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Thanks for finding this.  Let me dig in to understand (not clear whether fix is to task or patching vso-task-lib).  will follow up shortly

I instead fixed from the vso-task-lib side
https://github.com/Microsoft/vso-task-lib/commit/0568eb93376124390b45eac8794f3df0bfa62e6d
From latest agent installed dir (0.2.22), you can do:
npm update vso-task-lib
will update task lib with the compat fix


Verification Parameters

Description
More bullet spread/recoil increase parameters
Configuration
Zooming: <amount> or <amount>%
Zooming_Sneaking: <amount> or <amount>%
Zooming_Standing: <amount> or <amount>%
Zooming_Walking: <amount> or <amount>%
Zooming_Riding: <amount> or <amount>%
Zooming_Sprinting: <amount> or <amount>%
Zooming_Dual_Wielding: <amount> or <amount>%
Zooming_In_Midair: <amount> or <amount>%
Zooming_Gliding: <amount> or <amount>%
Sneaking: <amount> or <amount>%
Standing: <amount> or <amount>%
Walking: <amount> or <amount>%
Riding: <amount> or <amount>%
Sprinting: <amount> or <amount>%
Dual_Wielding: <amount> or <amount>%
Swimming: <amount> or <amount>%
In_Midair: <amount> or <amount>%
Gliding: <amount> or <amount>%

### Payment (optional)

- [X] I'm willing to pay for this feature

They stack with eachother, not sure why this would be required?

nah, it doesn't work

Они складываются друг с другом, не зная, зачем это нужно?

https://youtu.be/lbtRTSMrkAk

What is the config for that weapon?

What is the config for that weapon?

I'll send you to discord now

Issue in configs


Define a year range

Hi! I'm currently experiencing perfomance issues and i suspect it is because the calendar renders all years from 1800 to 2200, so i would like to know if there is a way to set a range to the calendar years

In the next version which will be released this evening you can!


chore: Release v1.9.37

This is a promotion branch for the release v1.9.37

/ok-to-test sha=bf9dd8a

/ok-to-test sha=7481ab2

/ok-to-test sha=da6332a

/ok-to-test sha=da6332a


Spelling mistakes

Fix the spelling mistakes in comments.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:FreedomWangLi/swarm.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM thanks @FreedomWangLi!

LGTM


Duplicate self.mark

Sometimes self.mark is duplicate.
In https://github.com/zchee/deoplete-jedi/blob/master/tests/test.py.

Maybe, buffer cached module will be duplicate.
If set
let g:deoplete#sources#jedi#enable_cache = 0

does not occur.
I will debug later.
/cc @tweekmonster

Strange.  The old cache should be completely replaced, not updated.  I can't reproduce your example, but I also noticed that it sometimes doesn't add [jedi] for some completions until I try completing again.

@tweekmonster
I was type
c - <BS> - s - <BS> - t
Maybe reproduced it.
I debbuging now.

@tweekmonster
I found the regularity.
This seems more likely to occur in Python builtins.
but, Sometimes it occurs even otherwise :(

Hmm.  Does deoplete.nvim modify the results dict?  If so, that may be the problem.
https://github.com/zchee/deoplete-jedi/blob/master/rplugin/python3/deoplete/sources/deoplete_jedi.py#L183
On L183, try changing it to:
out = cached.get('completions', [])[:]

To return a copy of the cache.

@tweekmonster Yes! I have found the cause.
If menu is empty, deoplete.nvim will be add self.mark to menu.
https://github.com/Shougo/deoplete.nvim/blob/master/rplugin/python3/deoplete/deoplete.py#L215-L221
It's not a bug. specification of deoplete.nvim.
So, We need a
            out.append({
                '$type': _type,
                'word': word,
                'abbr': abbr,
                'kind': self.format_description(c.description),
                'info': docstring,
                # this line
                'menu': self.mark,
                'dup': 1,
            })

The problem does not occur.

@zchee Great!  Seems strange that it was accumulating marks though.  Maybe that accumulation is a bug itself.  If deoplete.nvim was adding it, that means it was no longer empty and shouldn't add it again.

@tweekmonster Hmm...
Is that regex wrong?
re.match(r'\[.*\]', context['candidates'][0].get('menu', ''))):

@zchee It's not wrong.  The only issue I see with it is re.match() vs re.search() which may have unintended results.  https://docs.python.org/3.4/library/re.html#search-vs-match
For example, if Base.mark is set to ' [jedi]' it won't match.
The issue I see is here:  https://github.com/Shougo/deoplete.nvim/blob/master/rplugin/python3/deoplete/deoplete.py#L215
On that line, it only checks the first completion.  If there are multiple sources mixed in the results, and the first one doesn't have menu defined, all of them are updated even if other results already have the menu key:
candidate['menu'] = source.mark + ' ' + candidate.get('menu', '')

@tweekmonster OK. I understand.
and, Thanks for good reference :)
but, If fix deoplete.nvim behavior to check all candidates['menu'] in context['candidates'] list, will reduce performance.
So, I think a better way is only to add 'menu': self.mark, for now.
WDYT?

@zchee That will work, but only for this case.  If another source comes before Jedi, I think duplicates will happen again.  I might be wrong since I don't know deoplete.nvim as well as you do.
For performance concerns, I think deoplete.nvim should not do the menu update on L215.  It should do it in merge_results() since there is already a loop occurring there: https://github.com/Shougo/deoplete.nvim/blob/master/rplugin/python3/deoplete/deoplete.py#L248 (and it might need to happen on L238, too)
Actually I read over deoplete.py again, and I think I'm getting the indent scopes mixed up.  Are the results from multiple sources combined before L215?

@tweekmonster Yes, only for this case. I was known.
but, but... Now deoplete-jedi master branch will occur self.mark duplicate.
It will increase the other issue thread.
So, add 'menu': self.mark, for now.
But, If I or you or Shougo resolved this problem someday, will revert (remove) 'menu': self.mark,.
It's tentative workaround.
How would you like it? 🙏

@tweekmonster I also read deoplete.nvim sources.
I will do my best to resolve.

How would you like it? 🙏

あなたが上司です  :ok_hand:

@tweekmonster lol.
Committed: https://github.com/zchee/deoplete-jedi/commit/a5b10f6ef4b3c17d721702dee6dffeafa3f70675
To avoid misunderstanding of the other users, close once.
but, We should remember this matter.


New GO Term: protein localization to axon

Hello! My name is Kayla Brown and I'm with the Texas A&M CACAO class. I'm requesting a new term for protein localization to axon. It would be a child term of GO:0008104 protein localization and a parent term for GO:0002175 protein localization to paranode region of axon. The paper I am annotating is PMID: 26157139. Thank you!

Added:

(Apologies for the delay,  slipped through the cracks. Hope the term is still useful.

David)


733 implement cc4 avatars

There have already been suggestions for improvements to minimise the blocks of assignments. I have annotated this with TODOs.
The UMA components and packages still need to be removed.
I tested the multiplayer only locally with the Unity Editor and the Build Version.
The CC4 avatars/materials in ‘\Assets\Resources\Materials\CC4’ should be stored in the LFS, as well as \Assets\Plugins\CC_Unity_Tools.
New avatars can be found in this directory: "\Assets\Resources\Prefabs\Players\CC4"
There is a base avatar from which the male1-3 and female1-3 avatars derive.

Please test the assistant and voice input. It just didn't work for me on my computer.

other suggestions for improvement:

Improve walking Animation in VR
Further improve Hand and Headset position in XRRig
Improve Laser position and direction
Mouth of Assistant is slightly open
I added support for the htc eye tracker to the cc4 avatars

need to adapt #712

I tested the assistant and the voice chat. Both worked for me.

I opened a new issue #765 for the suggested improvement "Mouth of Assistant is slightly open". For the remaining ones, I do not have enough details.

Improve walking Animation in VR
Further improve Hand and Headset position in XRRig
Improve Laser position and direction

@Yvo02 If those points of improvements are still relevant, please file an issue with more details. Thanks!


OVN: analyze and document possible approaches

Work in progress here:
https://docs.google.com/document/d/1mwK_rJFN2hcI5_o1yI5ek7aprGlEc8MXTVxdOnx4VTw/edit#

https://github.com/submariner-io/enhancements/pull/11


Allow joining CloudPath with strings representing absolute paths

I added test cases that check path appending with / for S3 paths and them modified __truediv__ to handle appending absolute paths to CloudPath values.
@pjbull Should I add similar tests to test_gs_specific.py and test_azure_specific.py, or is there a single test file that could be used to check it for all providers at once?
Closes #344

Hello @pjbull and @jayqi! What do you think? Does this change make sense?

Closing per discussion in #344


feat: port Topology.Category.Compactum

What's left:

[ ] computability issues (see porting notes)
[ ] Failing to synthesize instance  TopologicalSpace X.A for Compactum X (and a few consequences of that)
[ ] Manual naming, i.e. continuous_of_hom should probably be continuousOfHom and names in comments

https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.233872.20Topology.2ECategory.2ECompactum

bors r+