Track external android format

The external format from android must be tracked, because in GetImageResourceSizesOptimal we create temporary images from the same format to calculate the resource size
If format is VK_FORMAT_UNDEFINED and the external android format is not provided it will crash on android

CI gfxreconstruct build queued with queue ID 245923.

CI gfxreconstruct build queued with queue ID 245925.

CI gfxreconstruct build # 4725 running.

CI gfxreconstruct build # 4725 passed.

CI gfxreconstruct build queued with queue ID 246259.

Looks good to me except possibly using the convenience function if it fits.
What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

CI gfxreconstruct build # 4729 running.

CI gfxreconstruct build # 4729 passed.

Looks good to me except possibly using the convenience function if it fits.
What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

Do we have a capture we could put in CI that replicates this or could you quickly write a program to replicate this?

Looks good to me except possibly using the convenience function if it fits.
What would a minimal test program for this case look like?

A minimal test program would have to create an AHardwareBuffer and then create an image with an external android format, and allocate device memory with the AHardwareBuffer and bind it to the image. And I think this only happens in a trimmed capture. This should reproduce it, but not 100% sure.

Do we have a capture we could put in CI that replicates this or could you quickly write a program to replicate this?

I do have a capture, but I've realized this fix is not enough. There is another problem later in the capture, that I thought was unrelated, but it seems that it is.

Can this be merged or is it part of a later PR?

Can this be merged or is it part of a later PR?

I might close this and open a different PR, because this only fixes a small part of the issue.


PSVita 1000 and 2000 don't work

I install under *main and reboot but not working with my 2 Vita Strange I don't know why

What's your FW version?
Double check it's in the right path

my 2 firmware is 3.60 and installed under *main

Double check your file path in the config, make sure you're using the newest version

USBDisable V3.02 installed under *main at the first place
# henkaku.skprx is hard-coded to load and is not listed here
*main
ur0:tai/henkaku.suprx
ur0:tai/PluginsU/USBDisable.suprx
ur0:tai/PluginsU/QuickMenuReborn.suprx
ur0:tai/PluginsU/custom_warning.suprx
ur0:tai/PluginsU/shellsecbat.suprx
ur0:tai/PluginsU/download_enabler.suprx
#ur0:tai/PluginsU/nolockscreen.suprx
ur0:tai/PluginsU/pngshot.suprx
ur0:tai/PluginsU/fruitpeel.suprx
ur0:tai/PluginsU/PasteUnlock.suprx
ur0:tai/PluginsU/quickmenuplus.suprx
ur0:tai/PluginsU/PSVshellPlus_Shell.suprx

Check your boot logs to see if this log is output
Also confirm that you're on retail fw? Have you done something like CEX2REX or CEX2DEX?

I couldn't find a boot log, I don't know where it is. No, none of that, just VitaRW to have the debugging utility

By boot log I meant to look at your printf logs with something like Cat(a)log or PSMLogUSB
If you're truly on plain CEX 3.60 fw and you really do have it set up properly then it should be working fine.

By boot log I meant to look at your printf logs with something like Cat(a)log or PSMLogUSB If you're truly on plain CEX 3.60 fw and you really do have it set up properly then it should be working fine.

yes you are right I installed a modified shell so I am no longer in CEX... I will try to see if I can find the offset

I tried for find offset ... I decrypted shell but I have some problems ... I have several SceShell which one to choose ?? And what function should I look for ?


Fix/Change translated patterns

Actually this is somehow more a question, than a real issue, although it's based on an issue.
The German translation of MinkContext is somehow messy, because it is translated 1:1 from English into German and now it sounds like Yoda is speaking to you. However, I see, that I cannot simply change the patterns, because that will break anyones testsuites, which makes use of them. Is theres a workflow on how to fix translated patterns?

:+1: i would too to know that

@everzet any idea how to deal with this ?

Do not use out-of-the-box stepdefs?

@everzet Yeah, would be a solution, but they are so convenient -_-

@everzet this does not answer about how we should handle the maintenance of these stepdefs

@stof same way we would handle any other BC-prone code, I guess - do not touch it until the new major. We can introduce separate "fixed" version of translation and advise people to use it on their own risk between majors.


Remove unnecessary activities

Each content page is its own activity.   Could update this so that all content pages are a single activity with some configuration so that the right content displayed and the right statements were sent.  Better for code reuse and readability.

After looking into this, I think the design of the app would need to be drastically changed to remove the specific activity classes for a general activity class.


Airflowcodecov

WHAT DOES THIS PR DO?

Jira cards

GitHub issues

Closes #

HOW DO I TEST OUT THIS PR?
WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:
IS THERE ANY JENKINS CONSOLE LINK FOR CODE COVERAGE AND BUILD INFO?
ARE THERE ANY RELATED PRs?

Codecov Report

:exclamation: No coverage uploaded for pull request base (Codecov@eb7e92d). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             Codecov     #2058   +/-   ##
===========================================
  Coverage           ?   100.00%
===========================================
  Files              ?         1
  Lines              ?         4
  Branches           ?         0
===========================================
  Hits               ?         4
  Misses             ?         0
  Partials           ?         0


feat: Implement a modern footer

Fix https://github.com/ietf-tools/www/issues/377

Move social media links from the header to the footer, in line with the existing links (which are now aligned to the right).
Add snippet type "Footer Column". The columns are displayed above social links and the old footer links.
On mobile, the columns are collapsed, and the headings are tagged with accessibility markup, to make them useful for screen readers.
A bit of code is shared with the test coverage branch (https://github.com/ietf-tools/www/pull/395) but it should be easy to merge.

@SharmaineLim thanks! I'll mark the PR as "Ready for review" so that IETF have time to review it too.


[Candidate 4v4 Battle Between Them ZH v5] At least 4 of 8 bunkers self destruct when soldiers shoot out of them

Observed behavior
At least 4 of 8 bunkers self destruct when soldiers shoot out of them.
Expected behavior
Houses take no damage when soldiers shoot out of it.
Screenshots

Likely can be fixed by raising bunkers.

Was this addressed?
It still is possible to damage bunkers when shooting.  More time spent with testing can reveal more errors.


MOSEK support

I don't see a suggestive branch name but has there been any preliminary work to support the MOSEK Python API? Otherwise I figure there's no better way for me to get to know the optlang interface than implementing one myself :slightly_smiling_face:

No it doesn't look like it. Feel free to start implementing it :) Let me know if you encounter any problems.

I think I've started once but didn't get very far. Would be nice to have.


feat: upgrade all dependencies 2

Description
fixes #911
Demo

Checklist:

[ ] I have read and followed the Contributing Guide
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@Liubov-crypto wait with the review, i need a fix few things after rebase


Implement an Error monad

After reading http://www.zohaib.me/monads-in-elixir-2/#error, I thought I'd give this a go.

This is the same as Monad.Result.


Faster CI caching images

Fixes #64
Please squash when merging (the merge button is a dropdown).
This CI workflow requires these secrets to be set:

DOCKERHUB_USERNAME: (not really a secret)
DOCKERHUB_TOKEN: any token Docker Hub gives, helps with their rate limiting.

@fenollp Is this PR to be removed in favour of the other one?


second party users should not see webtop

second party users should not see webtop in the main navigation bar

Webtop icon is now gone.

Passed on 2PI and Staging.


Can fallback data types have fallbacks?

The spec currently allows fallback data types to either be core or extension data types, but disallows the "fallback" field in an extension data type object. If fallbacks are not limited to core types, why not allow further fallbacks?

The spec does say that fallback may be a list of data types:
https://github.com/zarr-developers/zarr-specs/blob/cdf97c94d9e6f13dc820a0cd604cc8f9b0d61d03/docs/v3/core/v3.0.rst?plain=1#L494
Note though, that in regard to fallback data types, there is an outstanding issue of how to deal with the fill value:
https://github.com/zarr-developers/zarr-specs/pull/236#issuecomment-1539188066

Ah, my fault for missing that! I suppose it's just an API decision of a single recursive API or vs iteration


FPS drop on rx 470 4gb

System

Motherboard: China 2011 PlexHd x79
CPU: Xeon 2689 (Sandy Bridge)
BIOS Version: -
GPU: RX 470 4GB
CSM is turned off.
4G decoding is disable. Black screen when 4G decoding is on, tried to make a patch, but didn't figure out how to edit DSDT correctly.
[Y] I have read Common issues (and fixes)

Description
BAR Size is 1gb, when I turn on rebar, the frame rate becomes lower.
Cyberpunk off: 32 fps
Cyberpunk on: 31 fps
RDR2 on: 50 fps (2.6 gb vram use)
RDR2 off: 59 fps (3.2 gb vram use)

As far as I know, RDR2 has issues managing high BAR sizes, probably why the Nvidia drivers limit the usable BAR size for the game.
As for cyberpunk, well that's not enough information to truly tell if this is a ReBar issue, since a one frame difference seems to be within margin of error and not all games benefit from ReBAR unless they're being bottlenecked by the GPU's memory and BAR size limitations.

New test:
Far Cry 5 off: 41 fps
Far Cry 5 on: 41 fps
Cyberpunk off: 51.07 fps
Cyberpunk on: 50.80 fps
Half Life 2 off: 262 fps
Half Life 2 on: 264 fps
Maybe it's because of the 1GB buffer, I can't put more, but I couldn't find a game where there would be at least some increase. Fps is either the same or worse.
I would like to see the results of other users with 4 GB cards and a buffer of 1-2 GB.


 component requires 2 clicks on the back button

It looks like that with commit e34df30ecce786578523bec8abe7576dfde842b1 the behavior of the back button broke.
Can be reproduced in the latest master. Just Follow a Link element and afterwards it requires 2 clicks on the native back button to get back to the previous page.

Interesting, will take a look.

Submitted https://github.com/davezuko/react-redux-starter-kit/commit/e7d67d33512c5266e269e9d250ab80a942d5995f, does this fix it for you as well? If not we can always use a <base> tag.

Yes, thank you. This fixed the back button behavior in our project (and I guess also in the counter example)

:tada:


Highlight buttons when they are focused

Currently it's not indicated that button is focused. It would be nice if one could see that the button has focus when you have tabbed to it.
Related #1933

Implemented in #1933


Fix Fix null map issue in parquet reader.

Proposed changes
Fix null map issue in parquet reader which cause result incorrect such as min(), max().
In order to share null map between parquet converted src column and dst column to avoid copying. It is very tricky that will call mutable function doris_nullable_column->get_null_map_column_ptr() which will set _need_update_has_null = true. Because some operations such as agg will call has_null() to set _need_update_has_null = false.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


fwupd: 1.9.11 -> 1.9.12

Description of changes
The fwupd daemon refuses to start when there is an uefi_capsule key without any values in the config file, so I modified the module to only include this key when there are actually values that go inside.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Builds and tests pass, will also test the module before merging. Thanks, this release fixes an irritating bug with the security report!


dep ensure generates "Unknown field in manifest: prune"

when I use this version of the operator-sdk operator-sdk version 0.0.6+git and next issue a dep ensure, this warning message is reported
dep: WARNING: Unknown field in manifest: prune

gopkg.tml generated is

# Force dep to vendor the code generators, which aren't imported just used at dev time.
# Picking a subpackage with Go code won't be necessary once https://github.com/golang/dep/pull/1545 is merged.
required = [
  "k8s.io/code-generator/cmd/defaulter-gen",
  "k8s.io/code-generator/cmd/deepcopy-gen",
  "k8s.io/code-generator/cmd/conversion-gen",
  "k8s.io/code-generator/cmd/client-gen",
  "k8s.io/code-generator/cmd/lister-gen",
  "k8s.io/code-generator/cmd/informer-gen",
  "k8s.io/code-generator/cmd/openapi-gen",
  "k8s.io/gengo/args",
]

[[override]]
  name = "k8s.io/code-generator"
  # revision for tag "kubernetes-1.11.2"
  revision = "6702109cc68eb6fe6350b83e14407c8d7309fd1a"

[[override]]
  name = "k8s.io/api"
  # revision for tag "kubernetes-1.11.2"
  revision = "2d6f90ab1293a1fb871cf149423ebb72aa7423aa"

[[override]]
  name = "k8s.io/apiextensions-apiserver"
  # revision for tag "kubernetes-1.11.2"
  revision = "408db4a50408e2149acbd657bceb2480c13cb0a4"

[[override]]
  name = "k8s.io/apimachinery"
  # revision for tag "kubernetes-1.11.2"
  revision = "103fd098999dc9c0c88536f5c9ad2e5da39373ae"

[[override]]
  name = "k8s.io/client-go"
  # revision for tag "kubernetes-1.11.2"
  revision = "1f13a808da65775f22cbf47862c4e5898d8f4ca1"

[[override]]
  name="github.com/openshift/client-go"
  branch="release-3.11"

[[override]]
  name="github.com/openshift/api"
  branch="release-3.11"

[[override]]
  name = "sigs.k8s.io/controller-runtime"
  version = "v0.1.3"

[prune]
  go-tests = true
  non-go = true
  unused-packages = true

[[prune.project]]
  name = "k8s.io/code-generator"
  non-go = false
  unused-packages = false

[[constraint]]
  name = "github.com/operator-framework/operator-sdk"
  # The version rule is used for a specific release and the master branch for in between releases.
  branch = "master"
  # version = "=v0.0.6"

[[override]]
  name="github.com/sirupsen/logrus"
  version="v1.0.5"

[[override]]
  name="github.com/spf13/cobra"
  version="0.0.3"

@cmoulliard What is the dep version you are using? Think you need to update to later dep version.

I dont' have this warning message anymore using dep 0.5.0. Should we document the version to be used ?

@cmoulliard Glad to hear it works now! 👍  It's already documented here. Closing this as it's resolved.


CUDA 10.2

I tried running the examples/convnet using tags='cuda'  I got this error:
Failed to execute instruction >= true    [GPU(0)7 GPU(0)6]       GPU(0)8 true    false   true: Happened while attempting to use CUDA to execute >= true   [GPU(0)7 GPU(0)6]       GPU(0)8 true    false   true. Node is e. Register was 8: Unable to perform GteScalar(). The tensor engine does not have the function "elembinop.gte_vs_f64"

And tried running examples/convnet_cuda using tags='cuda' and got this error:
# gorgonia.org/gorgonia/ops/nn
../../go/pkg/mod/gorgonia.org/gorgonia@v0.9.4/ops/nn/batchnorm_cuda.go:203:41: cannot use alpha (type float64) as type cudnn.Memory in argument to ctx.BatchNormalizationBackward:
        float64 does not implement cudnn.Memory (missing IsNativelyAccessible method)

I know from issue #253 CUDA 10 should works.  Any thoughts on what I'm doing wrong?

Oh right - you have to run the command cudagen - first you need to go install gorgonia.org/gorgonia/cmd/cudagen which generates all the correct "stdlib" for Gorgonia's CUDA integration

OH wow, your response was super polite. I read the whole readme and remembered the tags bit but totally blanked on the rest... thank you for your patience, I appreciate it! I'll give cudagen a go.

Yea, not ideal. But this is the best way we know of to handle different compute capabillities. A go:generate directive might also be useful but we're not sure.

I'm not sure go:generate would be much better. I will say, go.mod for this project worked great until including cuda, then modules kinda broke down. I love modules but the generate phase doesn't work well with them. Too bad nvidia doesn't have a pure go cuda version!
In other news in case others have the same issue. In addition, to the LD_LIBRARY_PATH exports nvidia discussed in post-installation actions, I had to add the following (not mentioned):  export C_INCLUDE_PATH=${CUDA_HOME}/include:${C_INCLUDE_PATH} where CUDA_HOME was /usr/local/cuda-<version> in order to get gorgonia/cu to find cuda.h on Ubuntu. Apparently, the deb install doesn't set it up.


When the window is maximized, the sidebar should be pinned open

It's annoying to have to repeatedly open the sidebar each time I want to change modes. Save me a click and take advantage of the extra screen estate when maximized!

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

Instead of just maximized, there could be a snap point in which the sidebar is automatically opened and pinned.

This is standard common behaviour for UWP apps using NavigationView, but Calculator is more A-typical by using the collapsed overlay mode, because of the common option for keeping the window small.
But when the window is larger, it makes sense to keep it visible.


Trim hidden packages from (root) PackageTrees

What does this do / why do we need it?
This deals with a few interrelated issues:

The count of "transitively valid" packages in -v output is including packages that aren't actually being considered, which is misleading.
#1017 introduced a regression by causing conflicting import comments to result in pkgtree.ListPackages() aborting entirely.
dep has been erroneously complaining about errors in its own testdata dirs for a while now.
There appears to be some drift in the way that dep status invokes PackageTree.ToReachMap(), vs. dep init and dep ensure.

This doesn't quite fully fix the fourth item, but it gets us close.
The crux of the fix here is the introduction of PackageTree.TrimHiddenPackages(), which generates a new PackageTree that has hidden, unreachable and optionally ignored packages removed from it. This is not the most efficient way of doing it, as it means ListPackages() is still doing analysis of directories that we may end up throwing away - but it's much cleaner to bolt on top this way, and this isn't mutually exclusive with adding that logic later anyway.
It may also be appropriate to move the checkErrors() function currently in cmd/dep/ensure.go over into the pkgtree package, as its behavior is sufficiently general.
What should your reviewer look out for in this PR?
nothing in particular
Which issue(s) does this PR fix?
Honestly, it's kinda amazing our CI works right now - dep can't run on itself.

i think this is just down to needing some tests specifically for TrimHiddenPackages(), now.

i went back and forth on a keepIgnored parameter for PackageTree.TrimHiddenPackages() - with some of the present ambiguity (https://github.com/golang/dep/issues/1264#issuecomment-336559825) around whether "ignored" eliminates a node, or merely the node's out-edges, i wasn't feeling confident about whether or not to include it.
however, going some fairly exhaustive combinatorial input tests tests demonstrated that there are semi-absurd edge cases where it would be impossible to keepIgnored without needing to avoid PackageTree.ToReachMap() and instead write an entirely new preprocessing routine for wmToReach(). This struck me as a strong enough indicator that it was a model-breaking concept that I dropped the parameter.


add modal/dialog

Why are you passing a prop based function?

Yes. I'm confused on why this wouldn't use an event model that would pass the class to it to be called in the React code?

I am not entirely certain if we should have separate blocks for CSS. So far we've tried to use CSS-in-JS for the most part, but I know there are very valid reasons to use normal CSS in some places instead. Maybe we should update the snippet template to that and bring other up to standard? One very important issue with that is that CSS classes defined like so might conflict with other definitions, so we should probably name them something like 30react_className.

@Chalarangelo the modal is going to be a monster regardless because of the delegation model of the actual code itself. It will ALWAYS be a pain because you need the position, styling, and floating type of functionality in place no matter what which will require some sort of logical binding or message passing

@skatcat31 the amount of CSS is not the issue here, honestly - the format is. If we are doing separate blocks for CSS, which I am not against at all, we should update other snippets (like the star rating), to take advantage of this. 😉

Yes. I'm confused on why this wouldn't use an event model that would pass the class to it to be called in the React code and then just use a standard close button?

@skatcat31 React is a Single-Direction data flow framework.If I dont use close prop,I cannot change the visible state of its parent.But I need the visible in sync with the visible state of dialog.Dialog Component in famous React UI Library ant-design also realized via this approach.See code:rc-dialog
I'm not very clear about the event model U say.

Yes. I'm confused on why this wouldn't use an event model that would pass the class to it to be called in the React code and then just use a standard close button?

@skatcat31 React is a Single-Direction data flow framework.If I dont use close prop,I cannot change the visible state of its parent.But I need the visible in sync with the visible state of dialog.Dialog Component in famous React UI Library ant-design also realized via this approach.See code:rc-dialog
I'm not very clear about the event model U say.

@skatcat31 the amount of CSS is not the issue here, honestly - the format is. If we are doing separate blocks for CSS, which I am not against at all, we should update other snippets (like the star rating), to take advantage of this. 😉

@Chalarangelo I should modify my code,extract my css code from .css to .js.OK?

@zhongdeming428 No need, keep it as-is and you can update it (or leave as-is) when the template is finalized.

@Chalarangelo That's OK.If there is anything else need to be modified,please tell me.

@zhongdeming428 having a root modal element inside of your react code that binds to this element, and have it register an event listener for a specific event type on the global and then push a state change. Then use a function to close the event and bind it to the 'visibility overlay'(the slightly transparent layer) and a close button as a click handler.
By using that global event and binding the event listener to have a context that pushes back to the class, you can fire the modal using events that have been passed data and render functions to render the modal content. I can give a more in depth explanation later when I'm done with moving for the day.

@skatcat31 I dont understand why I cant use the function prop.

ho would I call this from anywhere else in the application? Would I always need to import the modal class or can I use a single instance on a page?

Single instance is not supported due to the function prop...but single instance dialog is not common use.In most cases,we use Tips or Messages class to show some simple info,just like:
Messages.warn('Something...');

Shall I close this pr?

Right, and if we instead triggered a custom event listener that calls the modal to open we instead just
constructor(props) {
  ...
  this.listener = event => this.setState({open: true, data: event.data, render: event.render});
}

render(){
  return <div
    // put closing onClick handler and shading and such here
    >
      {this.state.render(this.state.data)} // the content
    </div>
}

// in mounting life cycle
document.addEventListener('modal', this.listener)

//in unmounting life cycle
document.removeEventListener('modal', this.listener)

//calling the modal with an event
document.dispatchEvent(new CustomEvent('modal', { data, render: /*jsx function here*/ }))

of course there's many ways to do the render passing and what not, but this allows for a single instance, event based(universally callable) modal whose content is controlled by the passed render function.
I'm pretty sure we'll also want to make that event listener capture the event and prevent propagation but it's already at a document level so it should be safe.

@skatcat31 Thx for ur teaching, this solution is much better~
I have rewrited my code and created a demo on stackblitz, Plz go for a watch and give me more suggestions.
By the way, stackblitz is fxxking useful, works like a charm!

Nice use of the static method. Makes it easy to find, and now the handler that shows the modal controls how the modal renders.
There is obviously some improvements that can be made, but for an initial version I think this is pretty darn close to how it wants to be. The only thing I can think of is the problem of trying to get it to do anything stateful, but for those you would have custom modals that would access a data store, or possibly expand on this example to allow rendering functions that will handle that logic.
Otherwise unless anyone can think of any other improvements this is at least good enough for an initial.

sadly it is now 1 AM where I live so I'll be reviewing this again in the morning...

@skatcat31 We are not simultaneous,so sad~When u committed ur review,I had changed the whole description.So I am sorry to say u must review again.Hope to see ur suggestions tomorrow.

There we go... Now it will close on click if told to, and can be changed. If not provided it defaults to false with my suggestions.
It should also clear the content so you can't accidentally show outdated data if it gets called in error.

@skatcat31 U have made a pretty improvement on this pr:thumbsup:,good job~ Is there anything else required changes?

Not really. I've just been super busy. Sorry it took so long to approve

@skatcat31 @zhongdeming428 Shouldn't this be done in a more react-ive way rather than using vanilla? By what I know by my experience by far, using this component in a real world application where ci tests have been setup, this would break them.
Instead if we use the react way of doing things, then it will ensure that it works and doesn't break ci build as well. I don't have the write access to the repository otherwise I would have updated the code for this caveat.

@skatcat31 @zhongdeming428 Shouldn't this be done in a more react-ive way rather than using vanilla? By what I know with my experience by far, using this component in a real world application where ci tests have been setup, this would break them.
Instead if we use the react way of doing things, then it will ensure that it works and doesn't break ci build as well. I don't have the write access to the repository otherwise I would have updated the code for this caveat.

@rishichawda can you clarify what you mean by

Shouldn't this be done in a more react-ive way rather than using vanilla?

report from a thread on a comment on a source line(99)

As of React 16 portals were introduced for exactly this use case among others apparently.
I'd say we either want to move to that, or keep the event version(testing it in jest is very straightforward and easy, just mock the APIs you'll be calling with jest)
@rishichawda I have an issue with the version you've suggested in that it destroys the DOM tree with styling, which could cause a HUGE render gap either by styling shoving things in weird places, or unforeseen performance due to crawl. It also requires the parent to cascade the function down and means there is developer debt in remembering to pass a function from parent to child to child to child to child...
By nesting at a "root" level in the app(near the top, as close to the body root as possible) we can avoid styling shoving elements around and don't have to worry about style collisions due to inheritance other than on the body. It's not that it's a bad thing, it's that it is a dangerous thing to nest your modals. It's why the 'portals' idea was adopted by MANY people, and our event model basically is our portal without requiring React 16(I've used this model since 14).
So I'd say at this point there are three options:

Event based modal
React child based modal
Portal based modal

I'm leaning towards 1 or 3 since 2 requires extra logic beyond just "display modal"(even if it's possibly as small as 'pass firing function') and more developer debt beyond 'import, call static' or 'render portal'.
I like the event based model though because of an above point: It doesn't require the latest(and is compatible with many versions) and doesn't incur massive developer debt. We might just want to help people with their testing since this seems to be a point of contest.

Now that this is in the main PR we should continue the discussion here. Either way it's a good discussion and on that needs to happen as this is such a useful snippet it's pretty much the corner stone of most React UI apps: How easy are the models to use?

After weighing it for awhile I think we want to go with the Event based modal which is a basic implementation of a portal using the event loop instead of breaking encapsulation. This is also compatible with more versions of React, but we should mention portals as a note to those using React 16(which for SOME reason isn't as many people as possible... React 14 is still stupidly common...), and as such the Portals concept should be used, but in such a way that more people can use it.
This also allows the modal to still be mounted at the root of the App without having to remember passing a function to EVERY SINGLE CHILD that would need to pass it to another child, and so forth so that the eventual child can launch the modal. With this we keep developer debt at a minimum:

mount Modal at top level to avoid styling collision
import Modal class and fire event

We might be able to improve on the Modal a bit more with giving each modal the option of responding to different events, but that should be easy enough of a stretch that it shouldn't matter.
With the complexity of React and how this is most likely an advanced repo, do we want an expansion section that has ideas on how you could adapt these concepts to wider applications if applicable(like the idea for MapTable and MapList discussion)? That would be best server in it's own issue if we decide to pursue that avenue.

When can this PR merge into master branch? @zhongdeming428 If this PR is not suit,I'll close it~

@zhongdeming428 ussually at seven days and no discourse from an ask for it I merge. Thanks for checking in though! It's a great snippet

@zhongdeming428 Sorry for the long wait, I have sort of taken a break for a bit, that's why many PRs have been in the queue for a while. Hopefully, I'll review this and the others first thing tomorrow and we should be able to merge this asap, as there has already been a lot of feedback for it.
@skatcat31 Can you give me the rundown of any major things that need addressing in this one specifically? I will check wording, grammar etc as usual, but my React skills are not stellar and this seems like a reasonably delicate example.

Modal's are always a delicate matter because of CSS, and as such they can be delicate in implementation. The only thing I think we need to mention is that this example is more for compatibility and more updated versions should use portals(react 16+), and some of the gotcha's that come with Modals like how cascading styles kill them and this is why you want to use a close to root level div as possible and use a message/portal system to pass and trigger rendering.

Modals and their styles are dangerous because of the Cascading nature of CSS and thus you should instead use some sort of root level system to let modals be safe in their own world

A more up to date method that is less compatible would be to use React Portals(React 16+)

Thx for ur hardworking~ @skatcat31 @Chalarangelo


Allow Arrow API to read file contents from inputStream instead of only Path

Describe the enhancement requested
Currently, only uri is allowed as interface if we wish to read any file format
public FileSystemDatasetFactory(BufferAllocator allocator, NativeMemoryPool memoryPool, FileFormat format, String uri) {
        super(allocator, memoryPool, createNative(format, uri));
    }

I have a usecase where in I would want to pass an inputstream and based on it I wished to read and convert to the target fileformat.
Could someone from the community help me with this requirement, as this would help me go away from ParquetReader library or even AvroReader library and use Arrow instead
Component(s)
Integration

@kou Can you pls route this to appropriate personnel for clarification ?

On top of my head what I could suggest as a workaround is probably write a util. Let me check this. Need some time though.

Because this involves the JNI binding, we would have to somehow pass a file descriptor over to the C++ API, or otherwise bridge a Java InputStream into an Arrow stream. Also, in general, Dataset isn't made for that kind of use case: note that even the Python bindings only accept URIs, not file objects: https://arrow.apache.org/docs/python/generated/pyarrow.dataset.dataset.html


feat: Automatic Inflation Distribution

ref #3

smh I bet I need x/mint instead

messy going a different route


Bad argument #2 to 'join'

On MS Windows when open Neovim always shows this error message:

Any idea about what can be?
Thanks in advance.

@adelarsq thanks for reporting this. That line is now empty in the current main commit, can you update the plugin and repost what error you are seeing.

It was a problem on the plugin manager that was stuck on the update. Thanks @akinsho


AB-12 Added strokeprop event to fix replay stroke style bug

It seemed to me that some of the neccessary preparation for having strokeprops handled as an event was already done, and it appears no work well.
First time touching Drawify, so its likely great room for improvement 🐤

I think this isn't completely right for some reasons I will try to explain. Just to define some things first that can be a little confusing for anyone who hasn't worked on this code before:
IEvent: Events do not by itself have any inherit meaning and so IEvent always have to be translated to an IAction based on the state of the Dispatcher. A general rule is that most events will come from Javascript event listeners.
IAction: Actions are the objects that get stored and replayed at a later point. They are basically the "frames" of the recording. Thinking about this, IAction should probably be renamed to IFrame or something like that as it's more descriptive. An IAction should be independent of all other IActions recorded (which is not really the case at the moment). This is why we want stroke props included in the IAction object, since right now IAction depend on the stroke props state in Board.
IUserAction: IUserAction modifies the board states that do not change how IActions are created. For example starting, pausing, restarting, etc. This is where stroke properties are placed now, but should be moved out of.
IModifier: IModifier modifies state changes that affect how IActions are created, for example PAN_ON/PAN_OFF. A mouse move IEvent gets converted to either a stroke or pan IAction, depending on whether pan is on or off. This is where I think stroke props probably belong, since the stroke props have to be applied to the IAction before they get stored by the Dispatcher.
Hope that wasn't too confusing...

So basically:

Take stroke props state out of BoardController and move to Dispatcher
Make changes so that stroke props are added directly to the IAction and modify the BoardController to read those stroke props from the IAction
Change Service/Dispatcher so that stroke props are IModifier objects and the they modify the Dispatcher state

Or if you have any good ideas on how to do it in an even better way, feel free to share your suggestions :)

I will take your reviews and comments into account and update the PR, I had a feeling I had made a significant structural misunderstanding, and I think your comments should go a long way to helping correct it.
I'm sure I'll also have some more detailed questions as I go about realizing the change.
Thanks for the feedback 👍 will fix when I find the time

The recent commit is not yet ready for merge. Pushed it to fish for some feedback.
I'm having issues with replaying seemlingly overwriting the strokeProps assigned to Actions, and can't exactly see where or why this should occur.
But I am beginning to understand the structure a lot better, so theres that :D

This looks good! You're definitely on the right track now :) It looks like the example application is modifying values directly in the strokeProps object rather than creating a new copy on change. This results in all actions pointing to the same strokeProps object, which I'm guessing is the cause of the issue you're having.

And if you can add a couple of tests, that would great (might be harder than I think it is...)

Your recommended adjustments worked perfectly, nice! Manually testing shows decent behaviour.
Next I'll try writing some tests, although I expect this to be relatively hard.

Looks good :)


GL backend: transient buffer update stalls the pipeline

https://github.com/bkaradzic/bgfx/blob/1fa80e7478a118b5d537e823dab75cd3157edb6d/src/renderer_gl.cpp#L5386
On some android devices ( I have tested 9 devices, 3 have performance problems, two with mali400 gpu and one with an adreno 320) this update stalls the rendering pipeline. Update takes 15-30 ms with almost zero update size.
I have tried orphaning the buffer (suggested here: http://gamedev.stackexchange.com/questions/87074/for-vertex-buffer-steaming-multiple-glbuffersubdata-vs-orphaning) this solved the problem. Time went down to 0.1ms. But I don't know if this is a robust solution.
Docs suggest using multiple buffer objects to avoid stalling.
https://www.khronos.org/opengles/sdk/docs/man/xhtml/glBufferSubData.xml

I've been planning to make all updates completely asynchronous. I'll see how to patch this so it's not bottleneck, but ultimate goal is fully async.

Our engine has bgfx-like api.
We solve such problems this way finally:
For textures, add CreateTextureAsync(), UpdateTextureAsync() api, in another thread: it memcpy pixel data to linear aligned staging texture, then copy into optimal tiling format target texture.
For buffers, users must use a ring of buffers explicitly.


Thanos downsample not downsampling resolution to 1h

I starting downsample. Thanos downsample resolution to 5 minets, but not downsample to 1h. May be i should use any way flag? But in help not information about this.
thanos version:
thanos, version 0.3.2 (branch: HEAD, revision: 4b7320c0e45e3f48a437bd19294f569785bafb02)
build user:       root@e9a9c28f966a
build date:       20190304-17:11:05
go version:       go1.11.5
Output thanos downsample:

thanos downsample --objstore.config-file=/path/to/minio/config --data-dir=/path/to/data/dir
level=info ts=2019-03-14T13:05:46.647603834Z caller=factory.go:39 msg="loading bucket configuration"
level=info ts=2019-03-14T13:05:46.649020404Z caller=downsample.go:92 msg="starting downsample node"
level=info ts=2019-03-14T13:05:46.649108995Z caller=downsample.go:74 msg="start first pass of downsampling"
level=info ts=2019-03-14T13:05:46.89370969Z caller=downsample.go:80 msg="start second pass of downsampling"
level=info ts=2019-03-14T13:05:47.101386741Z caller=main.go:184 msg=exiting

Output thanos bucket inspect:

thanos bucket inspect --objstore.config-file=/path/to/minio/config
level=info ts=2019-03-14T13:07:22.085343918Z caller=factory.go:39 msg="loading bucket configuration"
|            ULID            |        FROM         |        UNTIL        |  RANGE  | UNTIL-COMP |  #SERIES  |    #SAMPLES    |   #CHUNKS   | COMP-LEVEL | COMP-FAILED |       LABELS       | RESOLUTION |  SOURCE   |
|----------------------------|---------------------|---------------------|---------|------------|-----------|----------------|-------------|------------|-------------|--------------------|------------|-----------|
| 01D5TT428K9PBS02GQGW3BFQ82 | 07-02-2019 03:00:00 | 09-02-2019 03:00:00 | 48h0m0s | -8h0m0s    | 2,294,800 | 20,161,066,783 | 164,023,160 | 3          | false       | monitor=prometheus | 0s         | compactor |
| 01D5TWAVK7W8BFDZ2TN44N4FMD | 07-02-2019 03:00:00 | 09-02-2019 03:00:00 | 48h0m0s | 192h0m0s   | 2,294,348 | 1,078,509,471  | 9,634,535   | 3          | false       | monitor=prometheus | 5m0s       | compactor |
| 01D5TTP2N17SGD1FR7NMA2TW5P | 09-02-2019 03:00:00 | 11-02-2019 03:00:00 | 48h0m0s | -8h0m0s    | 2,418,815 | 18,901,952,349 | 160,489,685 | 3          | false       | monitor=prometheus | 0s         | compactor |
| 01D5TXPPKCKZQ10NQCV9H2AAWY | 09-02-2019 03:00:00 | 11-02-2019 03:00:00 | 48h0m0s | 192h0m0s   | 2,418,363 | 1,069,558,134  | 9,317,763   | 3          | false       | monitor=prometheus | 5m0s       | compactor |
| 01D5VBMV995K3YA9RQ0V04KC2A | 11-02-2019 03:00:00 | 13-02-2019 03:00:00 | 48h0m0s | -8h0m0s    | 2,575,738 | 17,077,310,868 | 139,090,874 | 3          | false       | monitor=prometheus | 0s         | compactor |
| 01D5XHR0D8F5VKM3TE4CAT4RRP | 11-02-2019 03:00:00 | 13-02-2019 03:00:00 | 48h0m0s | 192h0m0s   | 2,575,738 | 934,589,507    | 8,439,227   | 3          | false       | monitor=prometheus | 5m0s       | compactor |
| 01D5VC50Z93TJTCZMD462J4FG8 | 13-02-2019 03:00:00 | 15-02-2019 03:00:00 | 48h0m0s | -8h0m0s    | 1,847,274 | 14,184,596,453 | 118,286,627 | 3          | false       | monitor=prometheus | 0s         | compactor |
| 01D5XJXDK4M6XJT3TZD921P4S8 | 13-02-2019 03:00:00 | 15-02-2019 03:00:00 | 48h0m0s | 192h0m0s   | 1,846,821 | 766,919,703    | 7,110,071   | 3          | false       | monitor=prometheus | 5m0s       | compactor |
level=info ts=2019-03-14T13:07:22.362321406Z caller=main.go:184 msg=exiting

Environment:

OS (e.g. from /etc/os-release): Centos 7

PS: Can you help? We collect many metric, but cannot display because thanos storage down if i call data of the 4 weeek.

Hi, downsampling to 1h blocks happens only for blocks older than 10 days
According to the output of bucket inspect you have to wait few days.


Connections from the pool are not reused when using async methods in parallel

Whem I'm using async methods (like FirstOrDefaultAsync) to get a result from the Database inside a Parallel.For, the connections are not correctly reused from the connection pool.
The connections will rise to the configured Max Pool Size and after some time (around 1-2 minutes on my machine using localdb), exceptions will be thrown.
Using either async methods and a normal for-loop or non-async methods an a Parallel.For-loop, the connections are properly reused and I can observe that a normal for-loop uses 1 connection and a Parallel.For-loop uses 4 connections which corresponds to MaxDegreeOfParallelism.
Exception message:
System.InvalidOperationException occurred
  HResult=0x80131509
  Message=Timeout expired.  The timeout period elapsed prior to obtaining a connection from the pool.  This may have occurred because all pooled connections were in use and max pool size was reached.
Stack trace:
   at System.Data.Common.ADP.ExceptionWithStackTrace(Exception e)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.<OpenAsync>d__31.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncQueryingEnumerable.AsyncEnumerator.<BufferlessMoveNext>d__9.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.<ExecuteImplementationAsync>d__33`2.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.<ExecuteImplementationAsync>d__33`2.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncQueryingEnumerable.AsyncEnumerator.<MoveNext>d__8.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.SelectAsyncEnumerable`2.SelectAsyncEnumerator.<MoveNext>d__4.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.<_FirstOrDefault>d__82`1.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.SelectAsyncEnumerable`2.SelectAsyncEnumerator.<MoveNext>d__4.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.EntityFrameworkCore.Query.Internal.AsyncLinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.<MoveNext>d__5.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
   at EfPoolingTest.UnitTest1.<>c.<NormalContextParallel>b__4_0(Int32 i) in C:\Users\xxx\documents\visual studio 2017\Projects\EfPoolingTest\EfPoolingTest\UnitTest1.cs:line 70
   at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`1.<ForWorker>b__1(RangeWorker& currentWorker, Int32 timeout, Boolean& replicationDelegateYieldedBeforeCompletion)

Steps to reproduce

Clone https://github.com/wertzui/EfPoolingTest and open the project
Run the "ViewConnections.sql" script to see that there are no connections open (beside the 2 used for the script)
Run the test "NormalContextParallelAsyncConfigureAwaitFalse" (I suggest running in Debug mode, so you can see the output)
Run the "ViewConnections.sql" script multiple times to see the connections increase.
After some time you will also get an exception
Run the other tests and observe the connection count

Further technical details
EF Core version: 2.0.0 (also tested with 1.1.3)
Database Provider: Microsoft.EntityFrameworkCore.SqlServer/localdb
Operating system: Windows 10 FCU
IDE: Visual Studio 2017 15.4.1

I think, this is the same as #6357 but with repro code.

Hello @wertzui ,
By default SQL comes with the Maximum Connection Pool that is 100, which is occurring is Pool overflow, you can resolve this by disabling the Pool or Increasing to a greater Value.
using Microsoft.EntityFrameworkCore;
using System.Data.SqlClient;
namespace EfCoreLongStringTest
{
    public class MyContext : DbContext
    {
        public DbSet<MyTable> MyTable { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            if (!optionsBuilder.IsConfigured)
            {
                var conn = new SqlConnectionStringBuilder("Server=(localdb)\\mssqllocaldb;Initial Catalog=EfCorePoolingTest;Integrated Security=true;")
                {
                    ConnectRetryCount = 5,
                    Pooling=false
                };
                optionsBuilder.UseSqlServer(conn.ToString(),
                    options => options.EnableRetryOnFailure());
            }
            base.OnConfiguring(optionsBuilder);
        }
    }
}

or
using Microsoft.EntityFrameworkCore;
using System.Data.SqlClient;
namespace EfCoreLongStringTest
{
    public class MyContext : DbContext
    {
        public DbSet<MyTable> MyTable { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            if (!optionsBuilder.IsConfigured)
            {
                var conn = new SqlConnectionStringBuilder("Server=(localdb)\\mssqllocaldb;Initial Catalog=EfCorePoolingTest;Integrated Security=true;")
                {
                    ConnectRetryCount = 5,
                    ConnectRetryInterval = 2,
                    MaxPoolSize = 600,
                    MinPoolSize = 5
                };
                optionsBuilder.UseSqlServer(conn.ToString(),
                    options => options.EnableRetryOnFailure());
            }
            base.OnConfiguring(optionsBuilder);
        }
    }
}

That's just a small example!

Hi @ralmsdeveloper The problem is, that these 100 connections from the pool are sleeping according to the Database and not actively used.
And then there is still the question why this only when using async and parallel queries, not when using either one of them.

I understand, as I said, it was just a suggestion to solve this case.
More in fact what is happening is that internally it is not closing the connection.
If we use the example below we will realize that everything will go well!
[TestMethod]
public void NormalContextParallelAsyncConfigureAwaitFalse()
{
   // Connection count max = 100 - MaxPoolSize
   // Throws System.InvalidOperationException Timeout expired.
   Parallel.For(1, count + 1, i =>
   {
       using (var context = new MyContext())
       {
           var myTable = context.Set<MyTable>().FirstOrDefaultAsync(m => m.Id == i).ConfigureAwait(false).GetAwaiter().GetResult();
           Debug.WriteLine("NormalContextParallelAsyncConfigureAwaitFalse " + myTable.MyColumn);
           context.Database.CloseConnection();
       }
   });
}

I tried your example and the behavior does not change (100 connections and exception after some time). Afaik calling context.Database.CloseConnection() does not really close the connection, but returns it to the pool.

I'm not sure if EF really would have to discard these connections if there are still requests.
I think @ajcvickers  can help us.

Hello @wertzui,
Seeing better, I made this little change in the Context and it was more satisfying, until it reaches 100, but then reduce!
using Microsoft.EntityFrameworkCore;
using System.Data.SqlClient;

namespace EfCoreLongStringTest
{
    public class MyContext : DbContext
    {
        public DbSet<MyTable> MyTable { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            if (!optionsBuilder.IsConfigured)
            {
                optionsBuilder.UseSqlServer("Server=(localdb)\\mssqllocaldb;Initial Catalog=EfCorePoolingTest;Integrated Security=true;",
                    options => options.EnableRetryOnFailure());
            }
            base.OnConfiguring(optionsBuilder);
        }

        public override void Dispose()
        {
            SqlConnection.ClearPool((SqlConnection)Database.GetDbConnection());
            base.Dispose();
        }
    }
}

If you can take a look at this it would be good, because the EF team would have a better direction!

This will get rid of the Exception, but effectively disable connection pooling and therefor cripple the performance.
I did some tests on my machine and these are the requests per second that i came up with for the different methods:

Test
without ClearPool
with ClearPool

NormalContext
257/s
44/s

NormalContextAsync
279/s
26/s

NormalContextParallelAsyncConfigureAwaitFalse
61/s
43/s

NormalContextParallel
289/s
125/s

I understand, in tests I used ClearAllPools to mark the connections to be discarded and it was faster, what I am thinking is that this can not be something in EF Core, but in Sysmte.Data.SqlClient.

@wertzui I ran your code and verified that EF is closing the connections correctly. Therefore, it looks like if there is an issue, then it is with the underlying ADO.NET code in SQLClient. I will move this issue to the appropriate repo.


Unable to npm run dev successfully

Describe the bug
Unable to npm run dev successfully as per Getting started guide mentioned in https://github.com/vuesion/vuesion.
To Reproduce
Steps to reproduce the behavior:

Download or clone (git clone https://github.com/vuesion/vuesion) the repository
Change directory cd vuesion
Install dependencies: npm install
Run npm run dev

Expected behavior
Build and run project successfully.
Logs
jerrychong [14:41:56] [~/Desktop/vue-vuesion] [dev *]
-> % npm run dev

><EMAIL_ADDRESS>dev /Users/jerry/Desktop/vue-vuesion
> vuesion dev -o

Start development mode...
Exit with error code: 1

Trace:
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>dev: `vuesion dev -o`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/jerry/.npm/_logs/2020-05-02T06_51_15_129Z-debug.log

jerrychong [14:51:15] [~/Desktop/vue-vuesion] [dev *]
-> % vuesion dev --debug .
zsh: command not found: vuesion

Desktop (please complete the following information):

OS: macOS v10.14.6
Browser: Firefox v75.0

Smartphone (please complete the following information):
N/A
Additional context
Add any other context about the problem here.

Similar issue mentioned in https://github.com/vuesion/vuesion/issues/497

hey @jerrychong25,
sorry for the late reply. Which version of node and npm do you use?
The current master only seems to work with node 10, not 12 or 13 (if you use npx @vuesion/create my-app --next you're able to use node 12+)

Hi @devCrossNet ,
node version: v12.13.0
npm version: v6.14.4

@jerrychong25 did you try to downgrade node to version 10 with a package like nor nvm? Or did you try @vuesion/create my-app --next?

@devCrossNet
Yes, npx @vuesion/create my-app --next command is working for Node 12+ in my case.
Thanks for your help.


Make performance test executable

Test executable should use GPUFIT and CPUFIT to run fits on randomized gaussian test data.  Initial guesses should also be randomized.  Performance should be reported in terms of fit precision (X coordinate only), number of fits per second, and mean number of iterations.  The code should automatically run a series of tests with varying numbers of fits from 1 to 10^6.

There is one now. Is it already in the final state?

Nobody commented and it looks good to me.


allowing for multiple xsd files

adding in functionality to have class xsd files loaded up with core xsd
file
example call would be
-schema=xsdDir/class1.xsd|xsdDir/class2.xsd|xsdDir/class3.xsd|xsdDir/main.xsd

Sorry for the late response.
Please add a test case if you'd like this to still get merged.

Closing this due to inactivity.


Add docs for integral-numbers concept

The integral-numbers concept is listed in the config.json's concepts key, but doesn't have its corresponding files in the concepts/integral-numbers directory.

Caused by #199 which removed the integral-numbers concept files and fixed by #208 which dropped it from config.json


SPARKC-527-b2.0

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with success


Finish implementing role/org system

Closed by https://github.com/Promptly-Technologies-LLC/fastapi-jinja2-postgres-webapp/pull/53


[BUG] JSQLParser 4.4 : PostgreSQL : the word 'RS' is a reserved keyword? sql sentence contained 'RS' can't be parsed.

Always check against the Latest SNAPSHOT of JSQLParser and the Syntax Diagram
Failing SQL Feature:

Brief description of the failing SQL feature
Example: RS can't be parsed

SQL Example:

Simplified Query Example, focusing on the failing featureselect rs from table1

Software Information:

JSqlParser 4.4
Database (PostgreSQL )

###Parse Error Msg:
net.sf.jsqlparser.JSQLParserException: Encountered unexpected token: "rs" <K_ISOLATION>
at line 1, column 8.
Was expecting one of:
"*"
"STRAIGHT_JOIN"

Tips:
Please write in English and avoid Screenshots (as we can't copy and paste content from it).
Try your example online with the latest JSQLParser and share the link in the error report.
Do provide Links or References to the specific Grammar and Syntax you are trying to use.

Greetings,
please try with JSQLParser-4.6 which has a better Keyword handling.
It works with JSQLParser 4.6.


Unify the dist data modeling section by talking about the hierarchical model

Communication goals (e.g. detailed howto vs orientation)
Both MT and RT are actually instances of a hierarchical database model. The MT model uses an id from the top of the hierarchy and RT uses an id lower down. Neither is truly relational.
Good locations for content in docs structure
Partially rewrite this part to unify it:
https://docs.citusdata.com/en/latest/sharding/data_modeling.html#determining-the-data-model
How does this work? (devs)
Example sql
We won't get into raw SQL, but we should discuss this example hierarchy:
Company -> User -> Session -> Page -> Event
Which levels would we consider MT and which RT?
Corner cases, gotchas
Are there relevant blog posts or outside documentation about the concept/feature?
Link to relevant commits and regression tests if applicable

This theoretical nicety didn't end up being so useful, since people think of citus more in terms of their use case than in terms of unifying themes of distributed modeling.


Push page transition could destroy and recreate whole component again

My application needs to keep all screens in the stack mounted.  MainContainer is my main component (embedded with a list). Click any list item will refresh and show another list within this component.  I wrapped with Stack like below and found each time I click any item, it has to unmount MainContainer first then create/mount again, rather than state change and re-rendering.
I notice you say:

"Many stack navigators keep all screens in the stack mounted when you push new screens onto the stack. This library is different, in that it unmounts the previous route's screen when a new one is pushed on. If you have state that needs to be maintained even after a screen unmounts, you will need to store that state in a parent component that contains the stack or possibly use another state management solution such as AsyncStorage, Redux, or MobX."

How can I do the way of "you will need to store that state in a parent component that contains the stack ", could you give some code snippets here?
      <Provider store={store}>
        <APIServiceProvider baseUrl={apiEndPoint}>
          <NativeRouter>
            <Stack>
              <Switch>
                <Route
                    path="/(aa)/:bb/"
                    render={(routeProps: any) => (
                      <MainContainer
                        {...routeProps}
                      />
                    )}
                  />
              </Switch>
            </Stack>
          </NativeRouter>
        </APIServiceProvider>
      </Provider>

Thanks

GitHub Issues is not a support forum. Opening four consecutive issues without any intention of submitting patches is unhelpful for everybody.

Hi @wangbourne, something to keep in mind is that the Stack component works almost exactly like react-router's Switch component.  The only thing the Stack component does differently is add a transition animation. I notice in your code example you have a Switch nested inside your Stack, that shouldn't be necessary.  The un-mounting and re-mounting behavior you're seeing is the exact same behavior you would get if you just used a plain Switch component for react router.
There a many potential ways you could refactor, for example rather than putting your MainContainer in the Switch, you could put the Switch inside the render method of your MainContainer.  Unfortunately I won't be able to help debug or refactor every potential situation, the best I can do is give some high level advice.
What I'm hoping to do is create more example applications in the examples/ folder of this repository to demonstrate more advanced patterns.


Refine acceptance tests to display user-facing CLI commands

Find a way to have acceptance tests as close as possible to commands/experience that end-users would see, similar to https://github.com/Orange-OpenSource/static-creds-broker/blob/master/README.md#usage-overview
Should include:

deployment
registration
update of service definition
unregistration and removal

Currently, the procedure to deploy the broker is not in sync with the acceptance tests executed:

https://github.com/Orange-OpenSource/static-creds-broker/blob/master/README.md#usage-overview suggests a "cf push"
while https://github.com/Orange-OpenSource/static-creds-broker/blob/master/acceptance/1_service_broker_lifecycle.robot#L13-L15 displays "deploy broker" and actual test implementation in https://github.com/Orange-OpenSource/static-creds-broker/blob/master/acceptance/Keywords.robot#L31 performs a cf p ${BROKER_APP_NAME} -f ${MANIFEST_PATH} -p ${BINARY_PATH}

Would be great to remove such inconsistencies by directly pointing users to the acceptance tests results, acting as a "living documentation"
/CC @s-bortolussi


Unity 2019.2.9 GlobalTagManager

When running UtinyRipper on an Empty Project build of 2019.2.9f1, I get an error with the Globaltagmanager:
Output log:
Import: Game file 'globalgamemanagers' has been found
Import: Game file 'level0' has been found
Import: PC game structure has been found at 'C:\Data\Documents\Unity\KnowledgeBase\Empty2019.2\Builds\EmptyWindows'
Import: Assembly 'UnityEngine.IMGUIModule' has been loaded
Import: Assembly 'UnityEngine.CoreModule' has been loaded
Import: Assembly 'UnityEngine.TextRenderingModule' has been loaded
Import: Assembly 'mscorlib' has been loaded
Import: SerializedFileException: v:2019.2.9f1 n:globalgamemanagers p:C:\Data\Documents\Unity\KnowledgeBase\Empty2019.2\Builds\EmptyWindows\Empty2019.2_Data\globalgamemanagers
Message: Read 606 but expected 607 for asset type GraphicsSettings
StackTrace:    at uTinyRipper.SerializedFiles.SerializedFile.ReadAsset(AssetReader reader, AssetInfo assetInfo, Int64 offset, Int32 size)
   at uTinyRipper.SerializedFiles.SerializedFile.ReadAsset(AssetReader reader, AssetEntry info)
   at uTinyRipper.SerializedFiles.SerializedFile.ReadAssets(EndianReader reader)
   at uTinyRipper.SerializedFiles.SerializedFileScheme.ReadFile(IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.FileList.AddFile(FileScheme scheme, IFileCollection collection, IAssemblyManager manager)
   at uTinyRipper.GameStructure.Processor.ProcessFile(String fileName, String filePath)
   at uTinyRipper.GameStructure.ProcessGameStructure(Processor processor, PlatformGameStructure structure)
   at uTinyRipper.GameStructure.Load(List`1 pathes)
   at uTinyRipper.GameStructure.Load(IEnumerable`1 pathes)
   at uTinyRipperGUI.MainWindow.LoadFiles(Object data)

Here is the Globaltagmanager File:
globalgamemanagers.zip
I guess the important part here is Message: Read 606 but expected 607 for asset type GraphicsSettings. Seems like there was a slight change in the file stucture?

This version is not yet supported

Thanks for the quick response, sorrry to file a bug for a version that is not yet supported. Maybe an entry of the supported versions in the readme would be a nice addition to avoid such problems.
e.g. AssetStudio:

Support version:

2.5 - 2019.1

It's ok to file such bug reports. They help me find out that the problem exists.

fixed in 25d02beb060a5509f099dcb2784e2f18e55adf30

Can confirm, that the problem does not appear anymore for 2019.2.9f1 👍


[DRAFT] use reload4j

What is this PR for?

reload4j does not prevent us moving to log4jv2 later
reload4j fixes some security issues in log4j
it doesn't feel great for an ASF project to still be using insecure logging frameworks like log4j v1

What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
Please leave your type of PR only
Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
Put link here, and add [ZEPPELIN-Jira number] in PR title, eg. [ZEPPELIN-533]

How should this be tested?

Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)
Questions:

Does the license files need to update?
Is there breaking changes for older versions?
Does this needs documentation?

@jongyoul is this something that could be merged?

I built zeppelin-distribution/target/zeppelin-0.11.0-SNAPSHOT.tar.gz locally with these changes and log4j jar was not in the dist.

@jongyoul @pan3793 @Reamer could this PR be merged? The ASF is suffering damage to our reputation by having project's who won't use secure libraries - in particular old versions of log4j attract make us look really bad.


Fix dimension parsing problem with KiCad 6.0.4

The GetShapes member in KiCad 6.0.4 is declared as:
    def GetShapes(self) -> "std::vector< std::shared_ptr< SHAPE >,std::allocator< std::shared_ptr< SHAPE > > > const &":
        r"""GetShapes(PCB_DIMENSION_BASE self) -> std::vector< std::shared_ptr< SHAPE >,std::allocator< std::shared_ptr< SHAPE > > > const &"""
        return _pcbnew.PCB_DIMENSION_BASE_GetShapes(self)

So we can't use it from Python. Trying to use it generates TypeError. So this patch skips the dimensions when we get the exception.

Thanks for the fix!


TestApp: The book is not browsable

Bug Report
The book is not browsable in any way
What happened?
The book is opened, the first page with the cover is displayed, but:

the pages counter is not displayed at the bottom of the screen
it is not possible to change page or jump to a specific chapter.

Expected behavior
Change page or jump to a specific chapter.
How to reproduce?
Open the attached sample book
Environment

Readium version: 2.6.0

Development environment

MacOS 14.0
Xcode 15.0.1

Testing device

iPhone13 iOS17

Additional context
bc40f3213719eae78585313877e66a9e4e3678.epub.zip

Are you willing to fix the problem and contribute a pull request? No

This is caused by the same issue I described on Slack for the Kotlin toolkit: https://readium.slack.com/archives/C703MSTQU/p1698229085820339?thread_ts=1698225175.649879&cid=C703MSTQU

The issue is that the book contains commented-out  tags:
<?xml version="1.0" encoding="utf-8"?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<!--
<!DOCTYPE html>
-->

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="it" >

<!--
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="it" dir="ltr">
-->

But when we inject our own styles and scripts, we do it with regexes to locate the <html tags, so you get false positives in this case. Ideally we would use a proper HTML parser, but we decided to stay as close to the original source as possible when we modify it.
This is unlikely the core maintainers will tackle this fringe issue, but we would welcome a contribution to fix it. Maybe with a more complex regex you could handle that.
It's located here, if you want to give it a go: https://github.com/readium/kotlin-toolkit/blob/482ab0c2d759b4484762b0b823a953cc66661259/readium/navigator/src/main/java/org/readium/r2/navigator/epub/css/ReadiumCss.kt#L239

With the Swift toolkit, the regex is located here: https://github.com/readium/swift-toolkit/blob/7c04a9892b951bb13f7099b4ab74064b43557e00/Sources/Navigator/Toolkit/HTMLInjection.swift#L65
I'll keep the issue opened but like I said, it's unlikely I will tackle this anytime soon. So a contribution is most welcome!


[BUG] Get-PnPTenant is returning an Experimental Feature error

Reporting an Issue or Missing Feature
Please confirm what it is that your reporting
I am Reporting an Issue
Expected behavior
Please describe what output you expect to see from the PnP PowerShell Cmdlets
Output of Tenant settings of the tenant
Actual behavior
Please describe what you see instead. Please provide samples of output or screenshots.
Returns following error
Get-PnPTenant: The requested operation is part of an experimental feature that is not supported in the current environment.

Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists

Login to PnPOnline using Connect-PnPOnline -Url "https:\\{tenant}-admin.sharepoint.com/"
Run Get-PnPTenant

What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
2.4.0 on PowerShell 7.4.2
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Hi,
We are running PnP 1.12 version and we have the same problem with this command and with the New-PnPTenant.
Our SPO version is <IP_ADDRESS>10, but in other tenants withe the SPO version <IP_ADDRESS>03 it's working properly

@IzzyBizzy45 - I've just tested on version 2.4.0 and I have no issue getting the results. It must have been at a point in time, please try again.

Hi veronicageek,
Looks like it's still happening for me but as it's working for you, I'll reach out to Microsoft to resolve

(time is in AEST)

Why was this closed?
We are also actively experiencing this issue:
PS C:\Windows\system32> get-command get-pnptenant

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Get-PnPTenant                                      1.12.0     PnP.PowerShell

PS C:\Windows\system32> Connect-M365Tenant -Workload PnP -ApplicationId xxxxxx-xxxx-xxxx-xxxx-xxxxxxxxx -TenantId amazon.onmicrosoft.com -CertificateThumbprint xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
PS C:\Windows\system32> Get-PnPTenant
Get-PnPTenant : The requested operation is part of an experimental feature that is not supported in the current environment.
At line:1 char:1
+ Get-PnPTenant
+ ~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Get-PnPTenant], PSInvalidOperationException
    + FullyQualifiedErrorId : InvalidOperation,PnP.PowerShell.Commands.Admin.GetTenant

A service side change in SharePoint is rolling out which has introduced a regression in the Get-SPO tenant cmdlet. This regression is currently impacting a subset of customers and is in the process of being addressed.

A service side change in SharePoint is rolling out which has introduced a regression in the Get-SPOTenant cmdlet. This regression is currently impacting a subset of customers and is in the process of being addressed.

Will addressing it return back to the previous working instance or require a change to PnP for the function to work again? Several of us are still on PS5.1 and can't upgrade due to script engine requirements. We're seeing this issue across at least half of our partner tenants so far.

@IzzyBizzy45 - I've just tested on version 2.4.0 and I have no issue getting the results. It must have been at a point in time, please try again.

Out of a sample set of a few thousand tenants, roughly 50% of them are still affected, so this is very much an active issue.

There is no notice on the Service Health Dashboards notifying of this.  Perhaps this issue shouldn't have been closed?  Possibly related to https://github.com/pnp/powershell/issues/3910


{"error_code":10,"error_message":"Farmer with launcher_id 0xfed8bf943a121bd251d4828c9ea4678c35afe92eb240eb91e71a8f5cea166e08 unknown."}

when i want to use Pool Login Link
it shows this message:
{"error_code":10,"error_message":"Farmer with launcher_id 0xfed8bf943a121bd251d4828c9ea4678c35afe92eb240eb91e71a8f5cea166e08 unknown."}
also i cant see my dashboard in pool.space. however i have 3 plot for about 2 days with the new pool protocol there is no detail for my luncher id :
Unable to find details for this farm in Space Pool.
If a farmer recently started submitting partials for this farm successfully, it can take a few mins to start seeing details.

same issue

Same issue here. Plz somebody help.
0 perent successful point with 300 point found. Help plz. Tnx

You should be getting a POST message from the farmer. Is this not happenning?

You should be getting a POST message from the farmer. Is this not happenning?

idk. how can i check it?
all i now is that i get error in my log file and i dont know how to fix it.
here's my log file text:
2021-07-13T11:28:52.553 farmer chia.farmer.farmer         : ERROR    Error in GET /farmer https://asia1.pool.space, 403
2021-07-13T11:28:54.223 full_node chia.full_node.full_node: INFO     Duplicate compact proof. Height: 137075. Header hash: f386b6965cdff7b71a305c95338a64d94063c5a303633ec959ecfe10d694f853.
2021-07-13T11:28:54.393 full_node chia.full_node.full_node: INFO     Duplicate compact proof. Height: 137075. Header hash: f386b6965cdff7b71a305c95338a64d94063c5a303633ec959ecfe10d694f853.
2021-07-13T04:20:06.916 farmer chia.farmer.farmer         : INFO     Pool response: {'error_code': 10, 'error_message': 'Farmer with launcher_id 0x4bb7673d963a04f89d87a3e0000ca332df25fbe5236ab6b6f212e1805916dfdf unknown.'}
2021-07-13T04:20:06.916 farmer chia.farmer.farmer         : ERROR    Error in pooling: (10, 'Farmer with launcher_id 0x4bb7673d963a04f89d87a3e0000ca332df25fbe5236ab6b6f212e1805916dfdf unknown.')

You should be getting a POST message from the farmer. Is this not happenning?

yes, I check the request log, after we switch pool, the farmer process not call POST /farmer, so there is no record in the store and then cause the unknown error

I also get this error, and I tried connecting to two different pools. 1.2.0

This might be a space pool issue. Try other pools please.

The pool received this payload for POST /farmer:
"payout_instructions": "xch1euuj...

This should be the hex encoded payout address?

Yes indeed: this was happening because I had set payout_instructions to the address of my cold wallet, rather than to the puzzle hash of my cold wallet.

I have encountered the same problem. Have you solved it？

Have you changed the payout_instructions field in your chia config? Perhaps so that the pool pays out to a different wallet?

Yes indeed: this was happening because I had set payout_instructions to the address of my cold wallet, rather than to the puzzle hash of my cold wallet.

this was fixed by #266


Marathon Dockerfile insecure download

Hi, I was just looking at the Marathon Dockerfile.
I'm not sure which Dockerfile is actually used to build the image, whether it's this one:
https://hub.docker.com/r/mesosphere/marathon/~/dockerfile/
Or this one:
https://github.com/mesosphere/marathon/blob/master/Dockerfile
(or why the two are different), but in both cases they seem to install sbt by downloading from an http URL and without checking signatures or checksums.
This means that no guarantees can be given about what is in this image; sbt may have been tampered with either in transit or on the download site, and there is no way of telling.
It would be great if you started validating checksums or at least used an https URL. For examples of how to do this see the official images e.g. https://github.com/docker-library/redis/blob/37efc31242c8415d4f2e6d84255af0c7b97567c5/3.0/32bit/Dockerfile

Hi @amouat, thanks, good point!
Could you provide a patch for that? We are accepting pull requests.
https://mesosphere.github.io/marathon/docs/contributing.html

Could do, but is this really the correct Dockerfile: https://github.com/mesosphere/marathon/blob/master/Dockerfile ?
It doesn't actually build.

If you can get someone to fix the build issue, I'm happy to help fix the insecure download.
Looks like I'll be at mesoscon next week if that helps.

Apologies for my previous comment, I've now figured out what's going on with the Hub builds (I'm not having a good day). You can click on the build ids to get the details.
I'll come up with some suggestions next week if I can. I'd also suggest cleaning up the builds if possible. For instance, what is the difference between 0.9.1 and v0.9.1? A latest tag that points to the newest stable version would be very useful for newcomers.

As a quick fix that makes things a lot better (but still not great) - just change the URL from http to https. It would still be much better to use checksums, but I'll need sometime to sit down with this. It's probably worth re-working things into two separate Dockerfiles, one of which is minimal image based on the JRE and only includes the jar file rather than all the sources and build tools.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3093. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3093. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Update to API 23 and transition to Volley

Provided native support for API 23 and deprecated our previous NetworkHelper in favor of a Volley wrapper.

:+1: go ahead and merge this @Revenaunt


Closes: #1 Fixes validation.py script

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.

It's a good idea to open an issue first for discussion.

[x] Tests pass
[ ] Appropriate changes to README are included in PR

Looks good


⚠ Bofrost.at has degraded performance

In 933c471, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1139 ms

Resolved: Bofrost.at performance has improved in f067fa5 after 13 minutes.


Add accordion-style sidebar

This PR adds an accordion sidebar to the documentation and a bit of JS to keep the same tab group open on refresh.

Oops, I accidentally wiped out my fork repo. Closing this for now but will re-open soon.


Cross-compiling for Windows: "x86_64-w64-mingw32-gcc": executable file not found in $PATH

marchello@markon:~/Desktop/sharik/sharik$ hover build windows
hover: Cleaning the build directory
hover: Building flutter bundle
hover: Using engine from cache
hover: Compiling 'go-flutter' and plugins
runtime/cgo
# runtime/cgo
exec: "x86_64-w64-mingw32-gcc": executable file not found in $PATH
hover: Go build failed: exit status 2

Hover v0.41.2
hover.yaml:
license: "MIT"
target: lib/main_desktop.dart
branch: ""
docker: true
engine-version: ""

I've run sudo apt install mingw-w64 and now everything works.
Isn't cross-compiling supposed to be runned inside Docker?

Yes, but you have to add the --docker flag to run in the docker container. There is a PR for adding better error messages about missing tools: https://github.com/go-flutter-desktop/hover/pull/109

From go-flutter-desktop/hover#109:

@jld3103
we also need to check if the crosscompilers are installed

I'm not sure if we should add checks or let Go do that.  If we add checks, then we need to keep the list of possible cross compilers up-to-date with whatever Go can use. I'm not sure if that's something we should do.

@GeertJohan My idea would be to add a list of supported compilers and a flag to use a custom compiler which isn't in the list currently and then print a suggestion to open a PR to add it to the list of supported compilers. What do you think?

I would prefer to only do the tool detection once Go failed and the Go output indicates that it may have to do with cross-compilation. Because if we deny the user to cross-compile because our logic thinks it's not possible, even though it is possible, that's very painful. So after Go cross-compile failed, we may do some detection so we can advise the user on possible missing tools or to use --docker.
I don't think this should have very high prio at this moment. The README explains to the user that cross-compilation tools must be installed. And if the user searches for the Go error, they will find that it's missing cross compilation tools fairly quickly (like @marchellodev did)

@jld3103 is this fixed?

No yet. I think I will work on it soon


TmpFile must have ext for tsv or more.

Requirements
Please take note of our contributing guidelines: https://laravel-excel-docs.dev/docs/3.0/getting-started/contributing
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Mark the following tasks as done:

[x] Checked the codebase to ensure that your feature doesn't already exist.
[x] Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
[ ] Adjusted the Documentation.
[ ] Added tests to ensure against regression.

Description of the Change
Why Should This Be Added?
I am not good at English. Please understand.
I Want to import tsv file 'title.akas.tsv' on imdb sample data
But tsv is processing like csv, so tsv extension file can't passing.
'title.akas.tsv' mime type detected as 'application/octet-stream'. maybe this file contains 'utf-8' chareset string and multi country language.
in 'vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Csv.php', 'canRead' function is incorrent at sometime. 'mime_content_type' in 'canRead' is unsafe.
so. tmpfile must have extension.
Benefits
tsv or csv extension file import is very well.
Possible Drawbacks
It looks absent.
Verification Process
None
Applicable Issues

Hi @yupmin Thanks for your pull request.
Could you have a look at the CI, as it's currently failing?

@GlennM is it right?

@yupmin please also provide a Test for this.

@yupmin changes are not needed. You only have to use WithCustomCsvSettings concern to specify the delimiter. See example: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/tests/ExcelTest.php#L252

Changes are required. The mime type of my CSV (download automatically by a script) is reported as "text/x-Algol68" (which is not a supported mime type). The delimiter is comma (,). But when I try to import it, the mime type is wrongly guessed because the 'TmpFile' doesn't have any extension.

@topclaudy just make sure to pass the reader type explicitly: https://laravel-excel.maatwebsite.nl/3.1/imports/basics.html#specifying-a-reader-type

Still happening (I tried \Maatwebsite\Excel\Excel::CSV). The exception message is "File could not be read". The problem is with the phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Csv:canRead function which return false on the mime type check.

Not sure what we can do about that @topclaudy here , as that's a PhpSpreadsheet method. You can better open an issue over there, I think :)

More details... the error spawns from your ReaderFactory
Maatwebsite\Excel\Exceptions\UnreadableFileException {#1844
#message: "File could not be read"
#code: 0
#file: "./vendor/maatwebsite/excel/src/Factories/ReaderFactory.php"
#line: 22
trace: {
./vendor/maatwebsite/excel/src/Factories/ReaderFactory.php:22 { …}
./vendor/maatwebsite/excel/src/Reader.php:273 { …}
./vendor/maatwebsite/excel/src/Reader.php:80 { …}
./vendor/maatwebsite/excel/src/Excel.php:129 { …}
./vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:223 { …}
./app/Quotes/Importer/CAShortSale.php:28 {
›
›     Excel::import($this, $filename, 'local', \Maatwebsite\Excel\Excel::CSV);
› }
arguments: {
$method: "import"
$args: array:4 [ …4]
}
}
./app/Console/Commands/Quotes/ImportShortSale.php:47 { …}
App\Console\Commands\Quotes\ImportShortSale->handle() {}
./vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29 { …}
./vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:87 { …}
./vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:31 { …}
./vendor/laravel/framework/src/Illuminate/Container/Container.php:572 { …}
./vendor/laravel/framework/src/Illuminate/Console/Command.php:183 { …}
./vendor/symfony/console/Command/Command.php:255 { …}
./vendor/laravel/framework/src/Illuminate/Console/Command.php:170 { …}
./vendor/symfony/console/Application.php:886 { …}
./vendor/symfony/console/Application.php:262 { …}
./vendor/symfony/console/Application.php:145 { …}
./vendor/laravel/framework/src/Illuminate/Console/Application.php:89 { …}
./vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:122 { …}
./artisan:35 { …}
}
}

Already reported here https://github.com/PHPOffice/PhpSpreadsheet/issues/429

The issue could be solved by accepting the PR for the correction extension in the temp file.

I'll have another look at it soon.

https://github.com/PHPOffice/PhpSpreadsheet/issues/429#issuecomment-439578963
And laravel-excel package should be changed in this way.
    protected function getTmpFile($filePath): string
    {
        $ext = strtolower(pathinfo($filePath, PATHINFO_EXTENSION));

         return $this->tmpPath . DIRECTORY_SEPARATOR . str_random(16) . $ext;
    }

@patrickbrouwers is it released yet? And if so, how is it fixed?

@patrickbrouwers is it released yet? And if so, how is it fixed?

I think this been released in version 3.1.6. A test was added to tests/ExcelTest.php:
    /**
     * @test
     */
    public function can_store_tsv_export_with_default_settings()
    {
        $export = new EmptyExport;
        $response = $this->SUT->store($export, 'filename.tsv');
        $this->assertTrue($response);
        $this->assertFileExists(__DIR__ . '/Data/Disks/Local/filename.tsv');
    }


Fixes #1477 Add customPropertiesExtractor to receiver options docs

Summary
Fixes #1477 Add customPropertiesExtractor to receiver options docs
Slightly rearranges existing Custom receiver concepts section to include an example of using customPropertiesExtractor.
Details
This may be over the top relative to what you all had in mind. It seemed nice to include a usage example, and I couldn't think where else to put it.
I worried that it might be confusing to include this example in the section on writing a custom receiver, so I tried to edit it to make it clear. I left the writing a custom receiver section first because the main example on the side demonstrates writing your own custom receiver.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

@seratch @filmaj thanks for your feedback, sorry got busy at work but I will try to address the feedback this week

@seratch @filmaj thanks for your feedback, sorry got busy at work but I will try to address the feedback this week

Updated in response to feedback. I worry its gotten a little wordy now, but let me know what you think!

meant to turn off my formatter to avoid those whitespace changes and then forgot, i can remove them if it's an issue

Thanks so much for your contribution!


Verify SMTP ERROR with UI TEST

Hi,
I want to verify in my UI TEST that there is an smtp exception with status code or with a message that is presented in view page : Unable to connect to the remote server
Can you help me!

You could search the page content to see if the text you are looking for is present?

On 2 Aug 2016, at 6:25 PM, wijdench<EMAIL_ADDRESS>wrote:
Hi,
I want to verify in my UI TEST that ther is an smtp exception with status code or with the message that is presented in view page : Unable to connect to the remote server
Can you help me!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

i know but is  there any other way to get the exception message from the server?
Thanks

Not really sorry. Selenium is running a web browser - that has absolutely no connection to the web server apart from the connection to port 80/443.
--
Rob Moore | Readify Principal Consultant, Technical Specialist (Microsoft Azure) | m +61 400 777 763 | e<EMAIL_ADDRESS>| w readify.net

On 3 Aug 2016, at 1:35 AM, wijdench<EMAIL_ADDRESS>wrote:
i know but is there any other way to get the exception message from the server?
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

ok
Thanks for your response


Spinner a

Expected behavior
I added a spinner to the layout. I want to run validate function on the spinner. If the user doesn't select any item from the spinner, he should see a error message.
Actual behavior
seterror() method doesn't work for spinner.
can't figure the return statement for validate function for spinner.
Steps to reproduce the issue

please use setitemselection listener for spinner


Refactor

fix typo
separate snowflake-related code in snowsql/connector.go
support set log level and log file

to be tested


[FEATURE] Gemini 1.5 Pro

Describe the feature you'd like
Google just released a public review of their new model, Gemini 1.5 Pro. It can handle up to 1 million token input capacity. It would really very sweet to test it out before a paid version goes live, on May 2 (I think).

Additional context
Also, they released a new embedding model text-embedding-004

Source: https://developers.googleblog.com/2024/04/gemini-15-pro-in-public-preview-with-new-features.html

[packages/components/nodes/embeddings/GoogleGenerativeAIEmbedding/GoogleGenerativeAIEmbedding.ts]
I would guess the proper code is something like this
// ... existing code ...
async listModels(): Promise<INodeOptionsValue[]> {
const models = await getModels(MODEL_TYPE.EMBEDDING, 'googleGenerativeAiEmbeddings')
// Add the new model name to the list
models.push({ label: 'Gemini 1.5', name: 'gemini-1.5' })
return models
}
// ... rest of the code ...

waiitng for the new google/genai version - https://github.com/google/generative-ai-js/pull/96


Version Packages (beta)

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.
⚠⚠⚠⚠⚠⚠
beta is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on beta.
⚠⚠⚠⚠⚠⚠
Releases
<EMAIL_ADDRESS>Minor Changes

#355 783a200 Thanks @mrcjhicks! - Updated tokens according to updated token spec for Spectrum 2, including new and deprecated tokens
Design Motivation
Change 1: Updated terminology to align with t-shirt sizes
Previously in S1, the breadcrumb variants were default, compact, and multiline. However, in S2, we have aligned breadcrumb to t-shirt sizes, resulting in the following changes:

Breadcrumbs (default) -> Breadcrumbs (L)
Breadcrumbs (compact) -> Breadcrumbs (M)
Breadcrumbs (multiline) -> Breadcrumbs (multiline)

Change 2: Updated truncated menu button sizes and spacing
Other structural changes

In S1 all variants used M sized action button – now we use S, M, L sized action buttons for respective sizes.
In S1 all variants had same spacing 8px around chevron, now we use different spacings for all the three variants

Token Diff
Tokens added (11):

breadcrumbs-separator-to-bottom-text-multiline
breadcrumbs-start-edge-to-text-large
breadcrumbs-start-edge-to-text-medium
breadcrumbs-start-edge-to-text-multiline
breadcrumbs-top-to-separator-large
breadcrumbs-top-to-separator-medium
breadcrumbs-top-to-separator-multiline
breadcrumbs-truncated-menu-to-separator
breadcrumbs-text-to-separator-large
breadcrumbs-text-to-separator-medium
breadcrumbs-text-to-separator-multiline

Newly deprecated tokens (13):

breadcrumbs-height
breadcrumbs-height-compact
breadcrumbs-top-to-text
breadcrumbs-top-to-text-compact
breadcrumbs-bottom-to-text
breadcrumbs-bottom-to-text-compact
breadcrumbs-start-edge-to-text
breadcrumbs-top-to-separator-icon
breadcrumbs-top-to-separator-icon-compact
breadcrumbs-top-to-separator-icon-multiline
breadcrumbs-separator-icon-to-bottom-text-multiline
breadcrumbs-truncated-menu-to-separator-icon
breadcrumbs-top-to-truncated-menu-compact

Token values updated (20):

breadcrumbs-top-to-separator-icon-multiline
breadcrumbs-top-to-text-multiline
breadcrumbs-bottom-to-text-multiline
breadcrumbs-height-multiline
breadcrumbs-top-to-separator-icon-multiline
breadcrumbs-top-to-text-multiline
breadcrumbs-height
breadcrumbs-height-compact
breadcrumbs-truncated-menu-to-separator-icon
breadcrumbs-truncated-menu-to-bottom-text
breadcrumbs-bottom-to-text
breadcrumbs-bottom-to-text-compact
breadcrumbs-separator-icon-to-bottom-text-multiline
breadcrumbs-start-edge-to-text
breadcrumbs-top-to-separator-icon
breadcrumbs-top-to-separator-icon-compact
breadcrumbs-top-to-text
breadcrumbs-top-to-text-compact
breadcrumbs-top-to-truncated-menu
breadcrumbs-top-to-truncated-menu-compact

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [783a200]:

<EMAIL_ADDRESS>

Run report for 19cd8aec
Total time: 27.8s | Comparison time: 27.2s | Estimated loss: 613.4ms (2.2% slower)

Action
Time
Status
Info

🟩
SyncWorkspace
0ms
Passed

⬛
SetupNodeTool(~20.12)
1.3s
Skipped

🟩
InstallNodeDeps(~20.12)
6.4s
Passed

🟩
SyncNodeProject(tokens)
0.3ms
Passed

🟩
SyncNodeProject(root)
0.2ms
Passed

🟩
SyncNodeProject(csvGenerator)
0.3ms
Passed

🟩
RunTask(tokens:buildTokens)
17.9s
Passed

🟩
RunTask(tokens:buildManifest)
247ms
Passed

🟩
RunTask(root:test)
1.3s
Passed

🟩
RunTask(csvGenerator:generateCSV)
216.9ms
Passed

🟩
RunTask(csvGenerator:test)
1.1s
Passed

🟩
RunTask(tokens:build)
28.5ms
Passed

🟩
RunTask(tokens:generateDiffResult)
2.2s
Passed

Touched files
.changeset/pre.json
packages/tokens/CHANGELOG.md
packages/tokens/package.json
tools/token-csv-generator/CHANGELOG.md
tools/token-csv-generator/package.json


Feature/metrics/stable metrics

Introduce permutation stable version of the retrieval metrics. The idea is to sort gt_tops for which distances are the same, i.e. if distances_tops and gt_tops are
distances_tops = [1, 2, 2, 2, 3]
gt_tops = [0, 1, 0, 1, 0]

then we need to obtain
gt_tops = [0, 0, 1, 1, 0]
#             -------
#             sort gt_tops where there are multiple
#             distances of the same value

The code for the retrieval metrics itself doesn't change.

In the failed test called test_metrics_is_similar_in_ddp it is said that

Metrics shouldn't be equal, but very similar

If I change the atol for the test from 5e-3 to 8e-3 the test passes. Is this workaround ok?

@dapladoc changing tolerance is okay

@AlekseySh @DaloroAT hey guys. It looks like this PR is ready to be reviewed.
As I described above the main idea is to sort gt_tops values corresponding to the same distance values. In order to do it properly, first we need to find new value of max_k such that torch.any(distances[:, max_k] == distances[:, max_k + 1] is False (function _estimate_suitable_max_k). Next, we need to make the sorting (function _sort_gt_tops). And all the steps for getting the gt_tops is now encapsulated in function _get_gt_tops.

@DaloroAT What do you think? Does bringing the additional logic worth the benefits of metrics' stability?
PS. Initially, I thought that the required extra logic would be smaller and simpler...

@dapladoc let's implement what we've decided offline:

measure overhead
introduce a flag for this functionality available for developers only (so, we don't expose is to config)
depends on the first step, set this flag as True or False by default

@dapladoc hey! just a reminder :)

Let me close it for now due to inactivity. Metrics code has also been significantly modified. So, anyway, the PR has to be reworked.