Valid imports fail in one specific component

Environment

Operating System: Windows_NT
Node Version:     v18.16.0
Nuxt Version:     3.7.0
CLI Version:      3.7.0
Nitro Version:    2.6.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      css, runtimeConfig, modules, components, API_URL
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://codesandbox.io/p/github/s1kebeats/s1kebeats_client/issue
Describe the bug
AppLogo component  import works in form.vue, but doesn't work in AppHeader. Imports are absolutely identical.
Error:
[Vue warn]: Failed to resolve component: AppLogo
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

Search component import in AppHeader doesn't work too.
Error:
[Vue warn]: Failed to resolve component: Search
[1] If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

You can visit /register route to see the import working in form.vue and visit / route to see the import not working in AppHeader.
Additional context
I also have this in logs:
[Vue Router warn]: No match found for location with path "/_nuxt/node_modules/.cache/vite/client/deps/"
Logs
[Vue Router warn]: No match found for location with path "/_nuxt/node_modules/.cache/vite/client/deps/"
[Vue warn]: Failed to resolve component: AppLogo
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
[Vue warn]: Failed to resolve component: Search
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

It needs to be <script setup> rather than <script>. Merely importing something into a <script> block doesn't make it available to your template - you would still need to have export default defineComponent({ components: { AppLogo } }) or equivalent.

Thank you, didn't see that somehow. Sorry for taking your time

No problem at all. Glad I was able to help.


⚠ Bofrost.es has degraded performance

In 66dad12, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1941 ms

Resolved: Bofrost.es performance has improved in ee9b95c after 6 minutes.


cleanup(bigtable): make filter samples consistent with Python samples

Fixes: #6868

This change is

/gcbrun

/gcbrun

kokoro:run


Updated it translations

Updated Italian translations.
Description

Fixed minor errors (missing or extra periods), unified terms and added missing translations for both example and two_factor.
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I see this is managed through transifex. How would that work? Would it be something like: get them reviewed, get permission to tx-push?

I see this is managed through transifex. How would that work? Would it be something like: get them reviewed, get permission to tx-push?

Indeed, you should translate on Transifex, and translations will get integrated on next release.

Indeed, you should translate on Transifex, and translations will get integrated on next release.

Thanks for the prompt reply! Transifex newbie here.
Would it be possible for me to tx-push?
I would like to avoid going through the point and click interface, translating things one by one.
Or perhaps there's a third option I've yet to discover?

Thanks for the prompt reply! Transifex newbie here.
Would it be possible for me to tx-push?
I would like to avoid going through the point and click interface, translating things one by one.
Or perhaps there's a third option I've yet to discover?

Oh, silly me!
I understood the problem now and tx-pushed.
Thanks again.

Oh, silly me!
I understood the problem now and tx-pushed.
Thanks again.


Compilation Failure

Thanos, Prometheus and Golang version used

Thanos version: 0.1.0-rc.2

go version
go version go1.10.1 darwin/amd64

What happened
Compilation Failed
What you expected to happen
Successful compilation
How to reproduce it (as minimally and precisely as possible):
Run make
Full logs to relevant components
Logs

make

formatting code
errchecking the code
/Users/dbarman/Work/Go/bin/errcheck -verbose -exclude .errcheck_excludes.txt ./cmd/... ./pkg/... ./test/...
Excluding (github.com/improbable-eng/thanos/vendor/github.com/go-kit/kit/log.Logger).Log
Excluding fmt.Fprintln
Excluding fmt.Fprint
/Users/dbarman/Work/Go/src/github.com/improbable-eng/thanos/pkg/objstore/objstore.go:235:3: cannot use b.opsDuration.WithLabelValues(op) (value of type github.com/prometheus/client_golang/prometheus.Observer) as github.com/prometheus/client_golang/prometheus.Histogram value in argument to newTimingReadCloser: missing method Collect
/Users/dbarman/Work/Go/src/github.com/improbable-eng/thanos/pkg/objstore/objstore.go:250:3: cannot use b.opsDuration.WithLabelValues(op) (value of type github.com/prometheus/client_golang/prometheus.Observer) as github.com/prometheus/client_golang/prometheus.Histogram value in argument to newTimingReadCloser: missing method Collect
/Users/dbarman/Work/Go/src/github.com/improbable-eng/thanos/pkg/store/cache.go:85:2: invalid operation: evicted.WithLabelValues(cacheTypePostings) (value of type github.com/prometheus/client_golang/prometheus.Counter) has no field or method Set
/Users/dbarman/Work/Go/src/github.com/improbable-eng/thanos/pkg/store/cache.go:86:2: invalid operation: evicted.WithLabelValues(cacheTypeSeries) (value of type github.com/prometheus/client_golang/prometheus.Counter) has no field or method Set
error: failed to check packages: could not type check: couldn't load packages due to errors: github.com/improbable-eng/thanos/pkg/store, github.com/improbable-eng/thanos/pkg/objstore
make: *** [errcheck] Error 2

Anything else we need to know
Environment:

OS (e.g. from /etc/os-release):

Kernel (e.g. uname -a):
Darwin dbarman-Mac 17.6.0 Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64

Others:

I found that Prometheus/client_golang has been removed function Set() at v0.9.0-pre1. #247 to see the detail.  So you should make sure your Prometheus/client_golang version is 0.8.0.

Interesting, will double check, Thanks for reporting

I could successfully build thanos. So, you may close the ticket.


RFC:  Make Client accessible from ClusterAdmin

The Client should be accessible from ClusterAdmin.
The ClusterAdmin interface should either expose a Client() *Client function or the ClusterAdmin should compose the Client interface. A third option would be create a NewClusterAdminFromClient(client *Client) (*ClusterAdmin, error) function which would allow the user to reuse the existing Client
I have written an application that requires me to get all topics from the cluster and differentiate internal from "normal" topics. 95% of all my needs are filled by the Client, but getting Topic Metadata is only accomplished by the ClusterAdmin. It doesn't make a ton of sense for me to open two clients: one that I can use and the internal one opened by the ClusterAdmin.

Does this work for you -> https://github.com/Shopify/sarama/pull/1415 ?

Looks Good!
Thanks, I’ll pull latest now.

On Aug 8, 2019, at 12:41, Varun<EMAIL_ADDRESS>wrote:
Does this work for you -> #1415 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


S2U-46: New features

Added start and end synchronization dates. This will affect the "Run synchronization" process.
In "New Site" hook, now we can filter sites by site property.
Synchronization Job now has some configuration options
New hook "Site Unpublished": Will remove all users from related Teams when a site is unpublished

Maven tests are failing due to mailsender errors in not related tools.

We need a successfull CI build, I'll re-launch it.


Change kafka deploy resources

Please see commits, but generally here is what I did:

delete 0.8.2 content (no longer needed)
removed 0.9.0 file, since that is not an actual released file, it had devel labels, instead of released version labels.
Adding actual released bits from "release" section of https://github.com/knative/eventing-contrib/releases/tag/v0.9.0

In particular using:

https://github.com/knative/eventing-contrib/releases/download/v0.9.0/kafka-channel.yaml
https://github.com/knative/eventing-contrib/releases/download/v0.9.0/kafka-source.yaml

and giving it version names

/assign @alanconway

@alanconway if you are happy with this: please merge
afterwards, on the updated master, please run the hack/release.sh script
If that gives troubles, lets capture those ... :smile:

Worked a treat.


Assimp: Fix compilation with GCC 12 and update to v5.2.4

Since assimp compiles with -Werror, a GCC update breaks the compilation.
See https://github.com/assimp/assimp/issues/4433

Can this PR be merged? I need it to fix MinGW compilation on my CI.

Thanks!


npm version problem

The version in package.json of electronic-QQ is 0.1, which cause a invalid version warn while running npm install and an error while running npm start.

I encountered the same problem. /(ㄒoㄒ)/~~

@dumplingsMing  @Desgard  sorry for that, dude. But I really toooo busy these days and get stuck on AngularJS. I am a back-end progremar with C/C++/Go and never write any JS before....LOL
We scheduled this issue TODO when I finished the Angular...
This project is because I used to work on Linux and the author of electronic-WeChat said he will never write a wechat in nodejs because he just don't use QQ !!!.So I with my friend wanna to do this based on the electronic-wechat code.
If you two have any idea about this just email me , let's do it together!

@dumplingsMing  @Desgard  sorry for that, dude. But I really toooo busy these days and get stuck on AngularJS. I am a back-end progremar with C/C++/Go and never write any JS before....LOL
We scheduled this issue TODO when I finished the Angular...
This project is because I used to work on Linux and the author of electronic-WeChat said he will never write a wechat in nodejs because he just don't use QQ !!!.So I with my friend wanna to do this based on the electronic-wechat code.
If you two have any idea about this just email me , let's do it together!

@dumplingsMing  @Desgard  as for the version problem . don't care about it. because it can not work even you get the correct npm version !!!
really sorry for that. I have scheduled this in 2017 TODO list!!!

@dumplingsMing  @Desgard  as for the version problem . don't care about it. because it can not work even you get the correct npm version !!!
really sorry for that. I have scheduled this in 2017 TODO list!!!

This issue can be fixed by just change the version in package.json from
  "version": "0.1",

to
  "version": "0.1.0"

However still many issues after doing that wwwwwwwwww.
This is a wonderful project since many people including me are facing the same problem while working in Ubuntu. I'm now using Windows Remote Desktop for qq (:з」∠).
Hope we can help you more on this project next year with some pull requests :)
Anyway, Happy New Year.

This issue can be fixed by just change the version in package.json from
  "version": "0.1",

to
  "version": "0.1.0"

However still many issues after doing that wwwwwwwwww.
This is a wonderful project since many people including me are facing the same problem while working in Ubuntu. I'm now using Windows Remote Desktop for qq (:з」∠).
Hope we can help you more on this project next year with some pull requests :)
Anyway, Happy New Year.

@dumplingsMing thx a lot dude.You too

@dumplingsMing thx a lot dude.You too

And I'm a green hand in front-end, too. I'm a iOS dev. and want to try the PC client. I used the electronic wechat, it's so cool. So I have a plan to develop a QQ client for every system environment, and I can learn the Electron in the same time. 😂
I'll continue pay attention to this repo, and donate the contributions if i can.
Thx. 👍

And I'm a green hand in front-end, too. I'm a iOS dev. and want to try the PC client. I used the electronic wechat, it's so cool. So I have a plan to develop a QQ client for every system environment, and I can learn the Electron in the same time. 😂
I'll continue pay attention to this repo, and donate the contributions if i can.
Thx. 👍


Update for Halogen 5

What does this pull request do?
Addresses #38.
This PR updates Select to be Halogen 5 compatible and makes a number of improvements to the component's extensibility without adding more boilerplate or removing any features. It doesn't change the behavior of the component internally, but the component should now be used differently.
A summary of changes:

The component and examples are now Halogen 5 compatible.

There is no longer any need to wrap Select in another component to make a selection interface. You can create typeaheads, dropdowns, date pickers, etc. simply by extending the component's state, queries, actions, input, and messages and by hooking into when messages are emitted, the component is initialized or finalized, or when the component receives input.

There is, accordingly, no need to provide any parent state or parent queries to the component. Users who were previously doing this can recover the old behavior by extending Select with a parent query or action and a message that re-raises it, instead of or in addition to creating a few more actions meant specifically for Select. There's no loss of functionality.

There is no longer a QueryF or free query pattern; now that you can easily extend actions without boilerplate there's less reason to build complex chains of binds in HTML, and now that queries are not allowed in HTML there's no way to take the result of a query and pass it to the next. Removing this machinery makes things quite a bit simpler.

The component no longer outputs any messages if you don't want it to. You can choose to emit nothing; to emit some new custom messages only; to emit custom messages and Select messages; or to emit only Select messages and no new custom ones. This lets you customize the component and decide what messages are relevant to users of the customized component. Maybe they don't need to know about searches because you've already handled it.

There is now a Spec type, similar to the ComponentSpec type used to make a Halogen component, which comes with a defaultSpec implementation. This type lets you provide handlers for the ways you've extended the component. If you added new actions, you'd want to add a handleAction function to handle them. You can override defaultSpec with only the fields you need; for example, if you've got a simple component with just a new render function, you can do Select.component $ Select.defaultSpec { render = render }.

While the Spec type has a lot of type variables, the individual pieces no longer do. In general, Select types are just a standard type synonym + a type parameter describing how it has been extended. So, for example, you have Action extraAction, Query extraQuery childSlots, State extraState, Input extraState, etc. Even better, if you are implementing a new Spec, you can just implement all your extensions local to the body of that function, so you don't even have to specify the types of anything except for the Spec itself and the Query type (to tell the compiler where the a comes from).

There is no longer any need for the Store comonad and the StateStore type, nor any need for Renderless as a library. The comonad was needed so that you could pass the render function via Input but not keep it in state and not introduce any wrapping types or wrapping HTML. You had to pass the render function via Input because the way to extend Select's state was by embedding parent state. And if parent state is embedded, then you need for parent state changes to cause state changes in Select, and that only happens via Input. Now that you can extend Select's state freely, you don't need to embed parent state and you don't need to pass the render function via Input and you don't need StateStore or Renderless.

There is now a default.nix file that allows anyone with the Nix package manager to have all dependencies (including mkdocs) to work on the repository by running nix-shell.

Previous summary of changes
This will be a little stream of consciousness as I have just a few minutes, but more specifically:

Updates the component and examples to be Halogen 5 compatible
Replaces the existing 'free query' implementation with an extensible variant for actions (queries are no longer permitted in HTML, and actions are not functors, so no free monad available; this could be worked around by wrapping all actions in a query). This also removes the Raise and Emit pattern; you can simply embed your actions from the parent and trigger them from the render function. See the typeahead for an example.
Replaces the existing messages with an extensible variant; this enables users to now trigger and handle their own custom messages from the component as they see fit.
In keeping with Halogen 5, Select now supports embedding further child components into a selection interface. This makes it possible to put, say, a text component inside a dropdown (helps with issues like #36). No example here, but see the Renderless updates for how this is done. You can also send queries through Select to the child component like you can in Formless.
Preserves only the queries that return responses. The query algebra isn't extensible, so if you want to add an action and then call it from a parent you can do that with the PerformAction query.
Introduces a Simple module which provides type synonyms for the core Select types for when you don't need to extend with any additional messages, actions, or child components. Not sure if this is worth keeping around or not.

This PR also updates the documentation and examples as far as the code goes; I haven't updated documentation describing the library and how it works.
Main Issues

The biggest change here is the switch to extensible variants for messages and actions. As I worked on Renderless it seemed significantly cleaner to allow a user to extend the actions and messages with additional ones to their heart's delight -- and provide a handler for the new actions -- than to require them to add new behaviors to a parent component and then wrap them in a Raise query and handle them in their own eval when the Emit message showed up. This keeps the extensibility contained in Select without leaking out to the parent. I think this is definitely the right move to make.

One decision I didn't make was to make State extensible. This is possible, too -- it would allow us to do things like make a date picker that maintains extra information without that info leaking out and having to be managed by the parent. Or imagine a typeahead that manages the items for itself but is just a simple extension to Select. It might be worth looking into, but I didn't explore it yet.

I don't know if it is possible to make the query algebra extensible. Maybe with some funky VariantF manipulation, but I don't know how to make the a type parameters unify. Maybe it would be better to make the query algebra extensible, instead of the action type, and then provide an action type that can evaluate a Query Unit so they can still be used in HTML. That would let us get our free query pattern back. But I don't know how to do this atm. Maybe @MonoidMusician has ideas?

The documentation is going to need a serious update to accommodate these changes. I'm going back into a busy period, so I won't be able to put a ton of time into this for a while.

Select is still deficient in a few ways -- never fixed the accessibility issues, you can move the highlight beyond the edge of the container and it doesn't scroll you down, etc. -- and I'd like to at least address some of them as part of a new breaking release. Might as well not have to make two breaking releases. If you have any ideas for what has been deficient in CitizenNet usage so far (some queries never used? some clunky? could have used some new ones? not enough information in state?)

Major updates in the last couple of commits:

I ended up implementing extensible state after all. It has a huge benefit: if state is extensible, then you don't need to embed values from parent state into the render function. If you don't need to embed parent state into Select then you don't need to pass the render function via the Input type (it doesn't need to be updated on parent re-render). If you don't need to pass the render function via Input, then you can dramatically simplify the type signatures involved and you can remove the Store comonad (and the Renderless dependency altogether), even while making the component much more extensible than it was before. Doing this incurs two new requirements: any extended fields in State have to be passed via Input (the compiler will check this for you); for any fields that are present in State but not in Input and therefore are going to be inserted (for example, lastIndex is created in the initialState function, but is not part of the Input record) we incur a Row.Lacks constraint to ensure the extended fields do not contain any of the fields we're going to insert. Both of these are pretty common sense requirements, however.

I removed Variant altogether for simplicity's sake. Now, the Message, Query, Action, etc. types are standard ADT's just as you would see in ordinary Halogen. This means that you have to do a little more wrapping and unwrapping, but because there is still no Raise / Emit pattern, this is much less tedious than it was before. If you take a look at the examples you can see that the wrapping is occasionally annoying, but compared to the mental effort required by people fairly new to PureScript in understanding how variants work, I thought it was worth it. I do like the elegance of Variant, but I'm just not sure the benefit is strong enough in this case.

I did discover how to make Query extensible after all, and so I've switched from an extensible Action type to an extensible Query type. I thought this was quite a bit nicer because it allows the Action type to remain internal and because queries are more powerful. Now that you can extend the query algebra you can do both action-style extensions and query-style extensions that return information about the component (like GetCurrentSelections in a typeahead). In my opinion this is much better than just extending actions. Since you can't use queries in HTML anymore, there's a RunQuery constructor that can be used to wrap action-style queries for use in HTML.

The last thing preventing these components from being extensible without making a wrapper component was to figure out odd cases like when an item is selected or when a search is performed. You can't just extend the query algebra and trigger some custom handler when a search action happens, for example, because the whole point there is that the search is debounced before any further work is done. Messages are currently the solution; they exist to signify some important event has occurred and let something else run a handler based on that event (the parent component). So I've changed Select to run a custom handler in addition to raising any message that it sends out. That way you can 'subscribe' to these messages from within the component itself; in a typeahead, you can now listen for a search to filter the list of visible items, without introducing a wrapping component. That function is called handleMessage and is another pretty simple one.

I simplified the examples. Take a look at the dropdown and typeahead and notice how you can get a working version of both components without ever introducing another component apart from Select itself.

Extensibility could go even farther but I might be willing to draw the line here. For example, in some components you might want to be able to hook in to the initializer and run something at that point, or whatever. That's the biggest drawback right now: you cannot hook in and modify any existing logic in the component, like handlers for particular actions, unless you replace the action with your own, copy the code out, and modify it yourself. Then again, this is always the case in functions, which are opaque, so it's not really an unexpected issue.
Curious to hear what y'all think of the changes. Maybe someone could try adapting the Ocelot typeahead to this branch of Select and see how it goes?

@davezuch @crcornwell @foresttoney I am prepared to merge these changes early next week (Tuesday?) into Select's master branch in preparation for the Halogen 5 release. Let me know if you see anything worrying in the meantime.
There are more changes necessary before Select will be ready for a new release. Specifically:

We have a lot of documentation to update to this new style. As part of that effort, I would like to add a little new documentation explaining how to recover the old behavior of Select (extending parent queries and emitting them as messages) for folks who were relying on that behavior before (@rnons, for example). Otherwise, we should be able to trim down the overall docs.

I haven't updated the actual module documentation yet, which will also need to happen. I haven't updated it because I'm planning another set of changes to Select's internals that will make it more usable in more scenarios (like component-in-component, which is currently useless because we maintain visibility based on focused state). Those will be coming in a separate PR which can be reviewed on its own.

Please consider messing around with the new styled examples by building the documentation site and going to the examples page. You should see that they still work as before, except better: the typeahead is asynchronous and the dropdown actually filters out selected items. If you have Nix installed you can use these commands to get that running right away:
nix-shell
yarn && yarn watch-docs

Looking forward to any feedback y'all have, and if there is none, then I'll merge this and keep going on improvements in another branch.

I'm interested to see these changes. Any progress on them yet?


More crypto currencies

For every crypto currencies level1 is assigned
For 2 level2 is assigned
For 3 or more level3 will be assigned

Hello! Can I be assigned to this?, How many crypto currencies do I have to add?

Hello! Can I be assigned to this?, How many crypto currencies do I have to add?

As many as you want
Based upon the number of additions the level will be added

Pls assign it to me, I'll be happy to contribute.

please could you add a milestone to my PR, because its not showing in issues as other PR

please close this issue, As the PR for the issue is already merged.


[BUG] When hovered on footer links the cursor shape is different on some links

Describe the bug
In the footer when hovered over
About
Services
Community
Contribute
the cursor is set to auto So

appears while in other links the cursor is set to Pointer
To Reproduce
It is an easy fix

Go to 'TheCyberHUB\src\components\Homepage\Footer\FooterElements.jsx'
Scroll down to const FooterScrollLink
Add CSS line cursor: pointer;

The issue is fixed
Expected Behavior
After applying the fix
Now when we hover on
About
Services
Community
Contribute
The pointer cursor will be showed

Now it will be uniform
Screenshot/ Video
https://github.com/thecyberworld/TheCyberHUB/assets/75574622/e0452f0e-f979-46ce-815a-a1e7aa3477cf
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I can create a Pull Request if the issue or the bug is valid


Not working on windows

What OS are you using (uname -a, or Windows version)?
windows11
What programming language are you using (C/C++/Go/Rust)?
go version
go version go1.18.2 windows/amd64

gcc --version
gcc.exe (Rev1, Built by MSYS2 project) 11.3.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

What did you expect to see and what you saw instead?
go run .
# github.com/webview/webview
D:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lwebview: No such file or directory
D:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lWebView2Loader: No such file or directory
collect2.exe: error: ld returned 1 exit status

Building on Windows is done with the build script (script/build.bat). Currently this breaks using go get or embedding it with the URL directly. We're working on a plan to fix it.
This is a duplicate of #706 (see more discussion there).

@qianniancn run build.bat to generate DLLs and then run that command again. It's mentioned in the readme, but easy to miss. Let me know if that doesn't work.


Simplify

Simplify starting basecoin:

remove --in-proc, add --without-tendermint
use BCHOME and remove data/ (https://github.com/tendermint/basecoin/issues/49)
add init and unsafe_reset_all commands (https://github.com/tendermint/basecoin/issues/48)
consolidate genesis.json files into one where basecoin goes under app_options and has well structured fields, plus a new plugin_options for the amorphous array of key/value pairs for SetOption

Fix up docs and guides

Very nice.  I especially like the merging of genesis files, consolidation to one chain id, and the special format for accounts, to make that more clear, as that is the most common usage of the basecoin config.
I wonder if we should make BCHOME required?  Without the default to ~/.basecoin.  I think I remember a conversation on slack to that effect, but I'm fine with having the default as well.
This whole refactor really makes basecoin much more of a stand-alone app, and great intro.  Now, I just need to get that light-client and a UI working nicely with it...

Thanks frey. I think we should keep the default rather than forcing users to set it just to get started. Seems even Go adopted a default GOPATH :)


iOS simulator displays only "Test Interstitial"

Hi,
I am using cordova-admob-pro for my app and whenever I run the app on iphone 6 simulator (with ios 8) even with "isTesting=false", I am getting a Test Interstitial. Here is the code snippet I am using
if (window.AdMob){
              window.AdMob.prepareInterstitial( {
                  isTesting: false, // receiving test to
                  adId:ad_units.ios.interstitial,
                  autoShow:false
                }
              );
          }

Is it a problem with latest Google SDK for iOS 8 ?

Did you test it on a real device?

Yes. I have tested on a real device too. Is there any special configuration required for this ?

Same here but I can't test on real device...
Il 05/mag/2015 11:21, "keenkiran"<EMAIL_ADDRESS>ha scritto:

Yes. I have tested on a real device too. Is there any special
configuration required for this ?
—
Reply to this email directly or view it on GitHub
https://github.com/floatinghotpot/cordova-admob-pro/issues/122#issuecomment-99006450
.

I think you need set your adId when calling prepareInterstitial().


Feature/photoshop with websocket

What's changed?
WIP reiplementaion of Photoshop integration with websocket server and RPC, without com objects (eg. multiplatform).

Fully implemented, available for testing.


[FEATUER] Expose user interface configuration as a prop;

This PR adds support for User Interface Configuration for the Flowplayer component. It hides the complexity of using bitmask and instead allows the user to set the uiConfig prop with a object syntax.
Example:
<Flowplayer
        src={demoSrc}
        token={DEMO_TOKEN}
        uiConfig={{
              noFullscreen: false,
              usePlay3: true,
              noMute: true
         }}
/>

Disclaimer:
I did not know where to put the global types so I created a new directory called types and added them to flowplayer-ui.d.ts.

Note that I also need to add new props for setting the brand color. But that needs to be a PR on it's own as it will bring in much more complexity.


Question: DHCP range in network resource ?

Is it possible to define DHCP range in network resource ?
resource "libvirt_network" "kube_network" {
  name = "k8s-net"
  mode = "nat"
  addresses = [ "<IP_ADDRESS>/24" ]
  dhcp {
    enabled = true
  }
  dns {
    enabled = true
    local_only = true
  }
}

Somethin that will give eg:
    <dhcp>
      <range start='<IP_ADDRESS>' end='<IP_ADDRESS>'/>
    </dhcp>

@magsoftware hi. afaik we don't have it implemented upstream, unless i'm wrong.
but with the xslt feature you add it,
https://github.com/dmacvicar/terraform-provider-libvirt/blob/50a5506f6b29518f64ca74a9f22cd245be0c1fee/website/docs/r/network.markdown#altering-libvirts-generated-network-xml-definition
see : https://github.com/dmacvicar/terraform-provider-libvirt/blob/19c23424ccfdecf6dfcbdd87783bf835ba5f585e/examples/v0.12/xslt/main.tf#L5

other examples:
https://github.com/SUSE/ha-sap-terraform-deployments/blob/0ed22a718e76fac577eb5749de9a71fe5d9ad4e1/libvirt/modules/shared_disk/main.tf#L7
https://github.com/SUSE/ha-sap-terraform-deployments/blob/dc58fb1c0a702903aa66808f1b44d5fba2023a62/libvirt/modules/shared_disk/raw.xsl

@magsoftware hi. afaik we don't have it implemented upstream, unless i'm wrong.
but with the xslt feature you add it,
https://github.com/dmacvicar/terraform-provider-libvirt/blob/50a5506f6b29518f64ca74a9f22cd245be0c1fee/website/docs/r/network.markdown#altering-libvirts-generated-network-xml-definition
see :
https://github.com/dmacvicar/terraform-provider-libvirt/blob/19c23424ccfdecf6dfcbdd87783bf835ba5f585e/examples/v0.12/xslt/main.tf#L5

Thanks. I did it with ansible. xslt is worse than assembler ;-)

OK closing. thx!


Return HTTP response as second return value from typed API client functions

Description
I'm refactoring the functions of the typed clients to return the HTTP response as second value.
Issues Resolved
Closes #619
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Big breaking change :(
If data, response, err was flipped as data, err, response, would it be easier to migrate to? Does go allow to specify the first 2 objects and omit the third?

No, it doesn’t. Even though it’s a breaking change, it’s quite easy to track it and solve it as the project will not compile until the new returned value is either ignored or handled, and find and replace in most cases might be all a user needs to do if he never bothers about the response. Considering that this change is targeting the next major version, where this kind of things are expected to happen when updating, I don’t see big downsides.


Async Support | Search Tools

Feature request
None of the search tools have async support.
Motivation
Async calls are being used langchain setup with FastAPI. Not having async support for these tools blocks there use.
Your contribution
Happy to help out where needed.

I faced the same problem and created a custom tool to handle it. here's the code for your reference.
import os
from langchain.agents import Tool
from dotenv import load_dotenv
import aiohttp

async def search_bing(query):
    subscription_key = str(os.getenv("BING_SUBSCRIPTION_KEY"))
    endpoint = str(os.getenv("BING_SEARCH_URL"))
    headers = {"Ocp-Apim-Subscription-Key": subscription_key}
    params = {"q": query, "count": 3}
    async with aiohttp.ClientSession() as session:
        async with session.get(endpoint, headers=headers, params=params) as response:
            response.raise_for_status()
            return await response.json()

a_bing_tool = Tool(
        name = "search",
        func=search_bing,
        description="useful for when you need to answer questions about current events",
        coroutine=search_bing
    )

I think a more general purpose solution available to make any tool async (not fully native async but does the purpose) Use asyncer library to convert a sync function to async. For example DuckDuckGo search tool doesn't have a _arun function
but it is pretty easy to implement one
from asyncer import asyncify

class DuckDuckGoSearchRun(BaseTool):
    """Tool that queries the DuckDuckGo search API."""

    name = "duckduckgo_search"
    description = ("...")
    )

    ...

    def _run(...)

    def _arun(self, *args: Any, **kwargs: Any) -> Any:
        """Async version of the tool"""
        return asyncify(self._run, cancellable=True)(*args, **kwargs)

Please disregard as this has been addressed in https://github.com/langchain-ai/langchain/pull/10058 recently. No need anymore

Please disregard as this has been addressed in #10058 recently. No need anymore

Is there an example of how to use this async tool? I have used the arun and run but still it is calling run though I run this tool with the agent using await

I have the same problem. My agent chain needs to call the function several times for different parameters, and it doesn't seem to perform that asynchronously. I'm using llm_agent.ainvoke function, and defined my tool function to have _run and _arun properly. Doesn't seem to work. It is still calling tool sequencially


[FEATURE] Add MobileOne

It's Apple's new model for mobiles https://github.com/apple/ml-mobileone

duplicate of #1305


Only 'tcp://' or 'unix://' supported.

Hello,
I'm always getting the following error, no matter where I place the config files.
19:15:08 [WARNING] Exception encountered when loading plugin: DockerizedCraft
com.github.dockerjava.api.exception.DockerClientException: Unsupported protocol scheme found: ''. Only 'tcp://' or 'unix://' supported.
Configs places in plugins/DockerizedCraft/

@Xeroxxx Are you on Linux?

Yes


1.18 improvement apiserver - object serialization optimization & using index in filters

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/approve

/approve

/lgtm

/lgtm


Not found luci openwrt 19.07 mt76×8

Not found luci openwrt 19.07
`  * opkg_download: Failed to download http://downloads.openwrt.org/releases/19.07.1/packages/mipsel_24kc/luci/luci_git-20.166.52937-b894a3b-1_all.ipk, wget returned 8.

opkg_install_pkg: Failed to download luci. Perhaps you need to run 'opkg update'?
opkg_install_cmd: Cannot install package luci.
Makefile:153: recipe for target 'package_install' failed
make[2]: *** [package_install] Error 255
Makefile:112: recipe for target '_call_image' failed
make[1]: *** [_call_image] Error 2
Makefile:196: recipe for target 'image' failed
make: *** [image] Error 2    `

You need to update your feeds.
There is now luci_git-20.167.61968-87da00a-1_all.ipk
(Buildbot rebuilds packages also in 19.07, so your package lists get stale.)

I use imagebuilder


certain channels do not show all their videos

spee.ch/@Lunduke does not show any video.
spee.ch/@EEVblog only shows 5 videos.

After talking with Tom, I think that spee.ch is resolving the content for channels correctly, but it is showing the incorrect channel (not choosing the expected channel as the 'winner') due to how spee.ch it is deciding the winner (using effective amount).

I am closing this issue because I think the real problem is that the incorrect channel is being returned, as described in https://github.com/lbryio/spee.ch/issues/163


Subscriptions page does not show newly subscribed content / Or nothing loads

The Issue
Not sure exactly how to reproduce this one yet, but sometimes when you subscribe to content and then go to the subscriptions page, it does not show. It shows after refreshing the app.
The other common scenario is that you go to the subscriptions page and nothing loads, including the loading bar.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Still occurring on newly added subscriptions. Removing release blocker for now.


[1.0][rc][mapping template] 4 get order by id - set 2 subsidiary properties of "state" property when its value is "completed"

a/c:

for 4 get order by id, in response mapping, regarding "state" property
- when value is "completed", then return the following properties, otherwise not
- completionDate
- productOrderItem[0].completionDate

pass


execute statement does not support qualified name

Describe the bug
This code errors out: net.sf.jsqlparser.parser.CCJSqlParserUtil.parse("EXEC sch.proc 'p0'") Because Execute statement does not support qualified name, e.g. schema.proc. In Execute.java, name is only a string instead of a Table object.
To Reproduce
Steps to reproduce the behavior:

Execute this Java code. net.sf.jsqlparser.parser.CCJSqlParserUtil.parse("EXEC sch.proc 'p0'")
Exception: net.sf.jsqlparser.parser.ParseException: Encountered " "." ". "" at line 1, column 9.

Expected behavior
Execute should support qualified names.
System

SQL
1.8
latest

This is fixed since #684. I think this should be working at least with version 3.0 of JSqlParser. So which version do you use? I tested this with JSqlParser 4.0-SNAPSHOT and it worked.

So could we close this issue?

I vote close @wumpz


Automatic testing

Implement automatic testing for clustering methods and extreme value selection.

I am thinking about the following case and was wondering if you have run into something similar with CapacityExpansion automatic testing, @YoungFaithful ?
When we do run_clust with kmeans or kmedoids, it will always initialize randomly. there is always a chance that even with large number of initializations, we do not get the same clusters in the end.
Do you use kmeans or kmedoids as a base step for CapacityExpansion testing, or only hierarchical?

note for future: Potentially use https://github.com/JuliaPlots/VisualRegressionTests.jl

I am keeping a running list of tests that still need to be implemented. If possible, these tests should be without loading any data, but rather test the functionality based on simple examples (see z_normalization tests).

entire intraperiod segmentation file

@YoungFaithful:  What was the issue in CapacityExpansion with the number of significant digits? Where did it show up, was it a small error in the optimization when you were running your tests, or something more significant?
Somehow kmeans + centroid does not perform reliably, if we use the ] test ClustForOpt, it fails, and I guess it is because of some rounding/ machine error, or alternatively due to random initializations.


Reorganize Code

Critical Changes
Changes
Issues Closed

Re-opening, the branch should no t have been deleted.

@ceiroa this is ready to review when you have time.


[sailfish-crypto] Add CSPRNG functionality. Contributes to JB#40058

Updated and rebased, let me know if you're happy for me to merge this one

@chriadam Could you comment "Probably it would also be good to add generateRandomNumber method which accept limits." please?

Added TODO comment, and rebased.  Will merge now.  Thanks!


Schemas are parsed in spinal case instead of camel case when using path references

Hello,
When using path reference,
  '/users/{userId}':
    $ref: ./apis/user.v1.yaml#/paths/~1users~1{userId}

The schemas used by the referenced path are parsed in spinal-case,
public class user {
For schemas whose name is in several parts, like UserSearch, the parser writes a hyphen (user-search) and stops because the syntax of java doesn't support that.
Because it's a bit complicated to exlain I've attached the full example
openapi-bug.zip

Fixed it. Both examples produce proper code now.  :-)
That was a nasty one, but my original code wasn't so bad at all. The swagger parser is doing something very similar internally. :-)
Release will follow in the next days.

Nice ! So quick !
I have no doubts about the quality of the code.
This is one of the reasons that pushes me to use it.
Thank you :smiley:

published 2021.3, fixing this one.


why cannot use GLSurfaceView on Android?

now i am trying to build filament to my own project. The problem is caused by that my project is based on GLSurfaceView.  I hope the obj model can be draw in my own scene.
I found that the screen turns back if i use
private SurfaceView mSurfaceView;
mSurfaceView = new GLSurfaceView(this);
to replace initial
private SurfaceView mSurfaceView;
mSurfaceView = new SurfaceView(this);
（it works well before the replacement）
I wonder how to let filament draw on a GLSurfaceView? or How to add the model to my own GLSurfaceView in which has set EGL Context.

GLSurfaceView is a SurfaceView but it creates its own render thread and OpenGL context, which will conflict with Filament. Since Filament takes care of all the rendering you do not need a GLSurfaceView.

got it! can i have some way to let filament drawn in my OpenGL context?

GLSurfaceView is a SurfaceView but it creates its own render thread and OpenGL context, which will conflict with Filament. Since Filament takes care of all the rendering you do not need a GLSurfaceView.

got it! can i have some way to let filament drawn in my OpenGL context?

Unfortunately no, Filament needs to own the GL context (if only to do state tracking). You can however use external textures to have Filament or your renderer render into a texture and then use that texture in the other renderer.

Unfortunately no, Filament needs to own the GL context (if only to do state tracking). You can however use external textures to have Filament or your renderer render into a texture and then use that texture in the other renderer.

I wonder is any possible that i can transfer my context to filament when i create the engine, because i note that the author leaves a entrance for a shared context in
Engine::create(Backend backend, Platform* platform, void* sharedGLContext)
but it seems that this parameter doesn't be used during the creating process.
I am confused with the author's intention to design such a parameter.

The shared EGL context is used to share textures with an existing context. It is not meant for public use currently.

The shared EGL context is used to share textures with an existing context. It is not meant for public use currently.

I have another question. As you said before, it's possible to have Filament render into a texture and then use that texture in the other renderer. So can I understand it like that... Supposing I constructed a scene where filament could do render job, then It could return an output texture that could be used in my own renderer


[Impeller] Code paths that end up in *FilterContents and supply a geometry that's larger than the max allowable RT size or subpass size fail to render anything and produce no warnings/errors.

This test fails to render antyhing and produces no helpful error output in the wild, but validation errors in a unit test:
TEST_P(EntityTest, ColorFilterContentsWithLargeGeometry) {
  Entity entity;
  entity.SetTransformation(Matrix::MakeScale(GetContentScale()));
  auto src_contents = std::make_shared<SolidColorContents>();
  src_contents->SetGeometry(
      Geometry::MakeRect(Rect::MakeLTRB(-300, -500, 30000, 50000)));
  src_contents->SetColor(Color::Red());

  auto dst_contents = std::make_shared<SolidColorContents>();
  dst_contents->SetGeometry(
      Geometry::MakeRect(Rect::MakeLTRB(300, 500, 20000, 30000)));
  dst_contents->SetColor(Color::Blue());

  auto contents = ColorFilterContents::MakeBlend(
      BlendMode::kSourceOver, {FilterInput::Make(dst_contents, false),
                               FilterInput::Make(src_contents, false)});
  entity.SetContents(std::move(contents));
  ASSERT_TRUE(OpenPlaygroundHere(entity));
}

We can hit this code path in a few ways:

Certain usages of drawVertices
Setting invertColors to true on Paint.
I think we can hit it via some kind of mask blur but I'm not sure.

I'd recommend adding support for the coverage hint to the remaining filters to solve this problem. So far we've only landed it for the GaussianBlur, but it should be supported by every filter. The coverage hint is fed to every single entity just before rendering.
Aside from solving this fidelity problem, doing so will also be a great performance win in general.


Required version of cocaine too low in gemspec

With cocaine 0.5.4, I get: undefined method `empty?' for #<Pathname>. I'm receiving this error when the system first attempts to launch ember build --watch
It is tangentially related to this PR: https://github.com/thoughtbot/ember-cli-rails/pull/86 where Pathnames are not strings.
Upgrading to cocaine 0.5.8 makes the problem go away, so there needs to either be a readme note or a gemspec required version bump.

Thanks for bringing this to our attention.
Would you mind trying out https://github.com/thoughtbot/ember-cli-rails/pull/338?

Tried. It selects the expected version of cocaine, doesn't throw errors.


feat(git): improve the set commit range error

Description
Before:
>_ orhun ζ git cliff test
 ERROR git_cliff > Git error: `unable to parse OID - contains invalid characters; class=Invalid (3)`

After:
>_ orhun ζ git cliff test
 ERROR git_cliff > Failed to set the commit range: unable to parse OID - contains invalid characters; class=Invalid (3)
"test" is not a valid commit range. Did you provide the correct arguments?

Motivation and Context
see #986
How Has This Been Tested?
Locally.
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[ ] Other

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report
Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.82%. Comparing base (e85888f) to head (e9066ce).

Files with missing lines
Patch %
Lines

git-cliff-core/src/repo.rs
66.67%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   42.85%   42.82%   -0.03%
==========================================
  Files          21       21
  Lines        1734     1740       +6
==========================================
+ Hits          743      745       +2
- Misses        991      995       +4

Flag
Coverage Δ

unit-tests
42.82% <66.67%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


oauth:expired is fired twice when refreshing the token

We refresh the token every time oauth:expired is fired. In the code that refreshes the token we call AccessToken.setTokenFromString(tokenStr). However, AccessToken sets the $interval twice:
-First time it is set with an old value of token.expires_at, causing time to be negative and triggering oauth:expired immediately.
-Second time it is set with an updated(correct) value of token.expires_at, triggering oauth:expired before the token really expires.
Checking if(time && time > 0) in setExpiresAtEvent function can quickly fix the issue. Although, you may consider a better solution. Probably cleaning old token values before setting the new ones; or refactoring a bit AccessToken, so you don't have to call setToken twice in the setTokenFromString method.

Thanks @pavel-r for the suggestion. I think your solution can fix the issue for now, if you can please submit a PR, otherwise I'm gonna implement that in the next release.
We need to think a better long term solution then and refactoring that service is a good starting point.


[FEATURE] Issue template bug

As a contributor, I want to choose between pre-made templates to create an issue for the repository.
Acceptance Criteria (AC)

[ ] in the .github folder create a folder called ISSUE_TEMPLATE
[ ] in the folder ISSUE_TEMPLATE create a file called bug.yml
[ ] for the name use: 🐛 Bug
[ ] for the description use: Report an issue to help improve the project.
[ ] for the labels use: ["🛠 goal: fix"]
[ ] in the body, add three type textarea
[ ] each of these textarea has an unique id, description, screenshots and extrainfo
[ ] each type has 2 attributes: a label and a description. Come up with own text Hint look in other repositories which uses issue templates to get inspiration what to write
[ ] each type has a validations, set to true for the description and false to screenshots and extrainfo

Useful link
Official docs on how to create a template
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

Hi @YuriDevAT, can I work on this issue? Thanks

Happy to have to as a contributor, @ehammes 😄

Hi @ehammes are you working on this? As mentioned in the contribution guide contributors get unassigned after two weeks when nothing happens to give other contributors the chance to work on it.

@YuriDevAT Yes, apologies on the delay, I'll get it completed this weekend

@YuriDevAT PR #46 ready for review


[Feature Request] add an option to disable  wrap for converted text

Currently, converted text is wrapped in a <mark> Element:
<mark>like this</mark>

This will add a yellow background (aka highlight).
However, this could contradict the UI style/theme of some websites, and it will drag users' attention to converted texts.
So, IMO it would be nice if users can disable the yellow highlight.
Thanks!

That‘s a good idea. I'll improve this feature


el-patch-validate-all fails with "apply: Cannot open load file: No such file or directory"

This is similar to #46.
When el-patch-validate-all is called, if I don't have the particular package installed in emacs, el-patch-validate-all fails with
apply: Cannot open load file: No such file or directory ...
I think it would be more helpful to ignore that particular patch and report it at the end. Below is an example:
(el-patch-feature outdated-package)
(with-eval-after-load 'outdated-package
  (el-patch-defun foo () ))

Fair enough. I suppose this can be done by demoting errors to warnings while running the hook.

This is fixed in the above commit, let me know what you think.

Just tested this fix. Works like a charm! Thanks.


Features for v0.8.0 Release

For tracking progress on v0.8.0. Should be released end-Summer. The issues I'd like to cover:
Note: This is currently taken hot from the PHP version and needs sifting through, and further planning for .NET version

[x] support razor for templates (#33)
[ ] make razor template and data parsing more robust (hyphen and keyword parsing)
[x] search the whole of source\ for css to use in MQ toolbar
[ ] custom header and footers for top-level patterns
[ ] add multi-site support
[x] add starter kit support
[ ] add snapshots (#20)
[ ] leave comments on annotations
[x] listItem customization
[ ] add lineages to "list view"
[x] allow for chunking of _data.json and using YAML
[ ] move annotations and support Markdown
[ ] add support for _docs
[x] multiple classes for style modifier
[ ] handle upgrade from v0.7.*
[ ] update embedded resources from PHP version

For launch:

[ ] update documentation
[ ] update CHANGELOG
[ ] update README
[ ] cut a release-0.8.0 branch
[ ] merge with master
[ ] tag master with v0.8.0
[ ] update Releases

Closing this feature list in light of the structural changes to the PHP version


add categories

Perhaps another addition we could make for consistency is only referencing components one way.
For example in several files, some components are accessed via:

gf.c.component_name
from gdsfactory.components import component_name
from gdsfactory.components.component_group import component_name
from gdsfactory.components.component_group.component_name import component_name

Personally, i think:
from gdsfactory.components.component_group.component_name import component_name

is the best option.
from gdsfactory.components.component_group import component_name

will cause mypy issues the same way as before,
from gdsfactory.components import component_name

could cause circular imports, and the same for
gf.c.component_name

This is ready to review


Avoid digest cycles by not watching ng-drag-data

This patch removes the $watch on the ng-drag-data attribute and replaces it by a one-time call when dragging starts. This avoids unnecessary digest cycles when ng-drag-data changes, which can have a big performance impact when there are lots of draggable elements.

Hi, can you tested all the demos still work with this modified behaviour?

Hey,
I just tried all the tests, and it seems to work without problems.


Preserve conditioned expressions with yield statements

The problem is that I can't create a ConditionalEdge from SemanticsBinder. I'd somehow have to communicate the intend to make these statements conditioned(*) from SB to BuilderVisitor which would - IMO - be even worse than current solution.
(*) In a way that doesn't slow down / increase memory footprint for non-conditioned statements which constitute the majority of bound statements.

A way to do it would be to make BoundConditionedStatement only a shell (without .Emit, ...) and then loop trough all retrieved PreBoundStatements in BuilderVisitor and construct ConditionalEdge for found BoundConditionedStatement. That would, however, be way more work and frankly doesn't feel that clean either.
Also, there might be a problem with creating new edges inside certain constructs (didn't really think about that all that much, so can't say for sure).


Workspace - The workspace deleted in the newly created account reappears

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
In the email field, enter a gmail email address for a new account -> Press continue
Validate new account and login
Create New Workspace
Delete nearly created workspace

Expected Result:
The workspace is removed without any problems
Actual Result:

The deleted workspace reappears
An error appears when trying to delete the workspace again

Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/204636203-c169511a-8675-4bda-a5c8-3c0a63bf1606.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Unable to reproduce this locally at the moment, and can't reproduce either on staging - though the site is having issues right now, I'll try again later.

Hey @francoisl , feel free to close the issue if you still can't reproduce it this week. Thanks!

Yeah still can't reproduce today, closing!


Uncaught ReferenceError: echarts is not defined。

I practiced 5 minutes to get started with the example of echarts3, Uncaught ReferenceError: echarts is not defined。(http://echarts.baidu.com/tutorial.html#5 分钟上手 ECharts).
when I switched to echarts 2.2.7,is ok, I do not know why?
Using the electron0.36.5, win10-64

Electron's environment is a bit different from normal browser because of the Node.js integration, you can probably follow the FAQ to disable Node integration, or seek help in the repo of charts .


Move to PySide2

PySide2 was officially released without the Technical Preview tag, in December 2018 for Qt 5.12.

Note that PySide is not included any more as a package in openSUSE 15.3 and newer. So upgrading to PySide2 (or another Qt 5 based Python package) becomes urgent.


Added new example: deep copy list

Hey @satwikkansal , @OrangeChannel made it clear that PR is not relevant and the only thing that could be done - new snippet with copy vs deepcopy demo (and even this snippet is probably extra).


[DOCFIX] Update alluxio.io URLs to use https

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4840/
Test PASSed.

cherry-picked the PR in master branch to 2.0 branch. close this one now


matchit and julia-vim causes sporadic behaviour with mouse

I've been using julia-vim for quite a while with no problems, but recently enabled matchit so I could do some more efficient browsing.
runtime macros/matchit.vim
I have mouse support enabled in vim. After enabling matchit, my mouse causes all sorts of problems. After a few click-and-drags, the mouse starts randomly inserting characters and preforming commands. It seems like the mouse is inputting directly to the editor.

The behaviour goes away as soon as I disable matchit
matchit itself seems to work correctly. That is, browsing using commands such as [[ works as expected.
The mouse does not cause problems in other file types with matchit enabled, leading me to believe this is a julia-vim issue.

Thanks for the detailed report. This is puzzling, I'm using matchit and the mouse myself, with no problems, and I don't see how they would interact.
I'll try to investigate. In the meanwhile, can you provide some additional detail, e.g. operating system, vim version, if using vim in a terminal or vim-gnome etc.?

Can you try commenting this line and see if the problems persist?

Sure. I didn't know how much detail to give since I didn't know if it was as simple as matchit + julia-vim ...

OS: Ubuntu 14.04
VIM: Vi IMproved 7.4
Use case: Running vim from command-line in a tmux pane, in gnome-terminal locally

https://github.com/JuliaLang/julia-vim/issues/60#issuecomment-148083070
That seems to have fixed it. At what cost?

That seems to have fixed it. At what cost?

Good to know, thanks. That line tries to make the behaviour of the julia-blocks related functionality consistent, such that when selecting a block (vaj), then exiting Visual mode, then selecting a block again, the selection procedure will start from scratch.
So the cost is not terrible, just annoying.
I'll need to figure out a way to do this by other means, if possible (as per the comment above that line, what would really be needed is an autocommand associated to the "exit from visual mode" event, which is currently unavailable in Vim).

Thanks.
Let me know if you need anything else tested, or further details to reproduce.


Image resizer not in context menu

When installing Powertoys 19.0. the Resize Pictures option doesn't appear in the Explorer right-click context menu.
Also when updating with 19.0 from 18.2, the context menu option disappears.
When rolling  back to 18.2 from 19.0, the Resize pictures option is present again.
Environment
Windows build number:  10.0.18363.900
PowerToys version: 19.0
PowerToy module for which you are reporting the bug (if applicable): Image resizer

Steps to reproduce
Install version 19.0. Right click on a picture in File explorer.
Expected behavior
With v 18.2

Actual behavior
After updating to v 19.0

This is going to sound obvious, but have you tried turning if off and then on, in the Settings?

I tried all the obvious, turning off/on, reboot, clean install.

@enricogior / @ryanbodrug-microsoft anything with the tweaks that could have caused this?  PowerRename shows up from the screenshot.

@StolkB latest version is 0.19.2 (and .20 is on its way) does this bug still happen if you use this version?

I'm not aware of any change to ImageResizer that cold cause this problem.

@StolkB latest version is 0.19.2 (and .20 is on its way) does this bug still happen if you use this version?

I just installed 0.19.2 and this still happens: no entry in the context menu for Image Resizer. When I install 0.18.2 the context menu works as expected; with the entry appearing/disappearing when turning Image Resizer on/off.
Is there any setting file or registry entry I can modify manually?

Just updated 0.18.2 to 0.20.0: Image Resizer context menu entry is gone.

No Image Resizer in context menu with 0.20.1. Re-appears when installing version 0.18.2.

Based on talking to Enrico, we had this as user and now it is system.  this could be the root cause.  Maybe we should see if there could be a conflict if the user key is still present?

@StolkB
are you still having this issue with 0.23.2?
If yes can you:

uninstall 0.23.2
install 0.18.2
uninstall 0.18.2 (this is an important step, you need to uninstall it and not upgrade to 0.23.2)
install 0.23.2

Thanks.

@enricogior
I'm still having this issue unfortunately. I was still running on 0.18.2. Uninstalled, reboot windows, and installed 0.23.2. Image Resizer doesn't show up in the right-click menu.

@enricogior I did a complete clean install of Windows10 + updates to Windows10 build 1909: which seems to have solved the issue. Powertoys 0.25 works as expected and Image Resizer shows up in the context menu.
Previously  I went back several times to a backup that was made before any installation of Powertoys,
Only thing I can think of is that this backup has a much longer 'history' with various programs and Windows updates installed.
I suppose there was already a fault present in this backup which caused problems with Powertoys 0.19.2 and later, w.r.t. to the Image Resizer context menu?

@StolkB
thank you for the follow up.
I close the issue.
Thanks


Switch redpanda-operator container image instead of configurator

Configurator container image can be replaced with redpanda-operator as binary within redpanda-operator can achieve multiple purposes.

Do we need to updating anything in the operator ahead of doing this? I'm specifically thinking that either command or args might need to be updated.
It may also be good to update the defaults in the operator so there's no dangling references to configurator

Do we need to updating anything in the operator ahead of doing this? I'm specifically thinking that either command or args might need to be updated.

Right, https://github.com/redpanda-data/redpanda-operator/pull/345 is necessary.


feat: fast_exp

Time spent on this PR:
Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Resolves #700
What is the new behavior?

I think we could try to uncomment some of the exponentiation tests from the ef-tests with this


Mechanize: search in page body force an encoding exception

I have following pretty simple code
require 'rubygems'
require 'mechanize'

URL = 'http://yandex.ru'

agent = Mechanize.new
page = agent.get(URL)

# page.encoding => UTF-8
# page.body.encoding => ASCII-8BIT

page.body.include?("Карты") # cyrillic

And on the last line of that code ruby yield an error:
in `include?': incompatible character encodings: ASCII-8BIT and UTF-8 (Encoding::CompatibilityError)

I consider that behavior as a bug.
Solutions from that question don't help.

You're comparing the page encoding with a different encoding. Try forcing your encoding first:
page.body.include?("Карты".force_encoding("ascii-8bit")) #=> true


update-flake-lock github action lacks permission to post PRs

This github action has been broken for a few weeks now. (Possibly caused by @mrain refactoring of this repo into many Rust packages?)
Example failed action: https://github.com/EspressoSystems/jellyfish/actions/runs/10335498879

GitHub Actions is not permitted to create or approve pull requests.

The admin gods have bestowed the necessary permissions on the necessary actors. And lo, the problem is solved. 🙏


Selected Item object - field update

On the Selected Item object, the 2nd field down on the page layout is labeled GGW and should be updated to GCK before submitting for Security review.

Verified removal


Fix doc link

Description
Fix doc link typo in blog release in #47248
Issue
N/A

Explicit hold until this PR only covers one language
(Ok to unhold once that's done)
/hold

@dipesh-rawat I do understand the typical rule, as I'm also an owner of localization. This time I made this PR combined as the author of both articles appeared to be the same. Should I still separate the PRs? 🤔

Please @kohei; partly because precedents can have long term costs, and partly because a single commit should try not to touch multiple localizations, especially not English + a downstream localization.

Keeping them separate allows localization teams to revert if required without getting approval from another localization.

/remove-language zh

/unhold

@sftim done

/lgtm
thanks


Webpack 5 polyfills when implementing useDiff

When implementing useDiff(schema1Path, schema2Path)  in a Docusaurus app I receive a page full of polyfill needed errors.

import { getDiff } from '@graphql-markdown/diff';

const load = async () => {

    const schema1Path = 'proposed-order-schema1.graphql';
    const schema2Path = 'proposed-order-schema2.graphql';

    const result = getDiff(schema1Path, schema2Path);
}

I receive the following errors for many different modules:
Module not found: Error:
Can't resolve 'module' in 'C:\Code\Documentation\developer-portal\node_modules@graphql-tools\load\esm\utils'
Module not found: Error: Can't resolve 'path' in 'C:\Code\node_modules@graphql-tools\load\esm\utils'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
I do not see access to the Webpack config in a Docusaurus implementation
node version 20.8.1
typescript version 5.2.2
@docusaurus/core 3.3.2
@docusaurus-markdown/diff 1.1.5
@docusaurus/core 1.10.1

The error is related to a third party package @graphql-tools/load as mentioned in the error message.
You might want to look at the Docusaurus API documentation for Webpack custom config: https://docusaurus.io/docs/api/plugin-methods/lifecycle-apis#configureWebpack


Default SCSS only colors up to "o" in a series (disappearing bars)

Was having a lot of trouble figuring out why certain bars in my chart weren't showing up. Found out it was because the CSS for a one dimensional series only colors up to the generated "o" series name.

// Series names and colors. This can be extended or customized as desired. Just add more series and colors.
$ct-series-names: (a, b, c, d, e, f, g, h, i, j, k, l, m, n, o) !default;
$ct-series-colors: (
#d70206,
#f05b4f,
#f4c63d,
#d17905,
#453d3f,
#59922b,
#0544d3,
#6b0392,
#f05b4f,
#dda458,
#eacf7d,
#86797d,
#b2c326,
#6188e2,
#a748ca
) !default;

I realize there's a comment specifying that it can be modified, but this caused me a good deal of troubleshooting as my bar chart had values which weren't getting a stroke, hence invisible.  At the very least, the default series should extend to 'z'.

Hi there, I'm not sure if chartist is made for such large count of series. However, I agree that we should include proper default colours so at least we're getting visible series. Anyway, we're going to refactor the series names to be numeric and with this change probably also re-evaluate how we're generating colours. I'd like to include an option to automatically create series colours based on scales and colour spaces like LAB https://en.wikipedia.org/wiki/Lab_color_space

Parts of this we're keeping track in #183, I'll close this issue in favor of the series renaming and keep a reference to it.

Thanks. For what it's worth, after re-styling them to have colors, I think Chartist works really well with a large count of series, especially when making use of vertical space.


Null pointer read exception reboot loop with use of a ESP32 Board

I got reboot loop crashes with the use of this library on a ESP32 board...
I managed to solve this by adding two null pointer - if's checks after the two strtok's in the souce code...
Now it's working fine...
label = strtok(line, "\t");
// Null pointer check, ESP32 Crashed without this
if (label)
{
value_str = strtok(0, "\t");
// Null pointer check, ESP32 Crashed without this
if (value_str)
{
Thanks for this great library !!!

Many thanks! Would you like to pull a copy and push the fix back to the code base? Or I can add it in. Let me know.

Has this issue been merged / resolved yet? I was having the same issue until i stumbled across this but am not sure where the } should go

You can add it in, I adjusted the VEDirect::read code like this to work on the ESP32:
int32_t VEDirect::read(uint8_t target) {
	// Read VE.Direct lines from the serial port
	// Search for the label specified by enum target
	// Extract and return the corresponding value
	// If value is "ON" return 1. If "OFF" return 0;

	uint16_t loops = VED_MAX_READ_LOOPS;
	uint8_t lines = VED_MAX_READ_LINES;
	int32_t ret = 0;					// The value to be returned
	char line[VED_LINE_SIZE] = "\0";	// Line buffer
	uint8_t idx = 0;					// Line buffer index
	char* label;
	char* value_str;
	int8_t b;							// byte read from the stream

	VESerial.begin(VED_BAUD_RATE);

	while (lines > 0) {
		if (VESerial.available()) {
			while (loops > 0) {
				b = VESerial.read();
				if ((b == -1) || (b == '\r')) { 	// Ignore '\r' and empty reads
					loops--;
				} else {
					if (b == '\n') { 				// EOL
						break;
					} else {
						if (idx < VED_LINE_SIZE) {
							line[idx++] = b;		// Add it to the buffer
						} else {
							return 0;				// Buffer overrun
						}
					}
				}
			}
			line[idx] = '\0';						// Terminate the string

			// Line in buffer
			if (target == VE_DUMP) {
				// Diagnostic routine - just print to Serial0;
				Serial.println(line);
				// Continue on rather than break to reset for next line
			}

			label = strtok(line, "\t");

			// Null pointer check, ESP32 Crashed without this
			if (label)
			{
				if (strcmp_P(label, ved_labels[target]) == 0) {
					value_str = strtok(0, "\t");

					// Null pointer check, ESP32 Crashed without this
					if (value_str)
					{
						if (value_str[0] == 'O') { 		//ON OFF type
							if (value_str[1] == 'N') {
								ret = 1;	// ON
								break;
							}
							else {
								ret = 0;	// OFF
								break;
							}
						}
						else {
							sscanf(value_str, "%ld", &ret);
							break;
						}
					}
				}
				else {			// Line not of interest
					lines--;
					loops = VED_MAX_READ_LOOPS;
					line[0] = '\0';
					idx = 0;
				}
			}
		}
	}
	return ret;
}

I only have a crashing ESP32 now still when Serial is not connected to a VE Direct device, i will try to solve this problem soon...

Did you manage to solve the issue with the disconnected device? Thx.


figure out interface structure for the battery (asset)

now I think am almost done with basic interval and Stream data types.
the question is how to format the Asset and/or Battery.
I want to Strip it off so it does not care about  what Usecase it is applied.

// okay here we would like to group several properties based on the interval index,
// but at the same time there is concern that this could (?) make the
// ingestion of interval-indexed-values ( a list in a json or dataframe) a bit harder.
// so one idea here is to cater for both options.

message Quantity{
//  this message is meant to be a type that could have dual use;
//  as a basic-quantity or a interval-quantity (same content, but not same format).
//  (i was not sure also that should IntervalQuantity be independent of quantity or not; hence this is
//  in fact another way of showing interval-quantity)
//  this is one way to mimic I guess the inheritance concept,
//  though inheritance is not supported in protobuf and trying it is not recommended.
//  so at this point not sure if this approach is a good idea to use or not.
//  the benefit could be having less/cleaner message types and extennding the usage of types (as done for Span)
//  there are some drawbacks of course;
//  not strict typeing (when using these types in other types, not clear which Specific Sub class -> quantity or interval-quantity)
//  sometimes you refer them in another class; but you actually cannot have all the fields; so we actually need BasicQ
//  how these "read between the lines" type characters that are not reflected in the proto would be transfered to users.
//  needs a more complex data-parser in the server side.

what should I do about the BatteryInterval?  all the goodies that actually define the internal model of the battery?
should it be exposed as interface at all?
should I put it as output section in the interface?
what about the economics?

okay so one thing that is still remians a design question is to choose between QuantityGroup and IntervalQuantityGroup as two different ways of defining the same  group of objects.
also related to this is adding an Uncertainty type to the Quantity or defining a separate group of types to have that included.
finally a design decision here at this point, is to place the EnergySource within the asset or in AssetGroup. I am changing now from the first into the second

for the interval type and the cases that a Type can be defined in multiple ways, maybe a good addition would be to add an Enum to define different possible ways to define it; and then on the Server side I could match to a specific enum type and respond!.

a bit confused on the usage and compiling of the google types as a separate package in the protobufs.
looks like that for python those are imported from the  grpciotool or something not from the compile of the protos.
not even sure if they are compiled correctly now.
I guess I could test that out later.
but if I had not had this library installed, then how to properly compile a package which has sub packages, which seems independent package as well is an open question, I think i came across this before, and saw some stuff but still not clear.

okay so now  were are we after all this types?
For the Resource/Asset; I have separate Expense and Service objects, instead of putting them under AssetEconomy/CostReveneues,
well one thing is that I have some sort of ResourceEconomy under the AssetGroup; that should be the main place to define the cost and revenues of assets.
but what if I had a series of objects all economics related?
the economy modeling is still not quite how I like it


Don't drop leading zeroes when performing generic ecdsa signing (#357)

call ret.FillBytes() instead of ret.Bytes() to preserve leading zeroes that may have been dropped when converting the digest to an integer
Cherry-picked from https://github.com/google/go-attestation/pull/357

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat. ADD mini_project_customer_LJH.ipynb

+Datafile (need to use same xlsx name file.)
Need to collect all team member's code.

good!


Should fix #33. Shouldn't have to expose the php port on docker-compose

As you can see here (https://github.com/maxpou/docker-symfony/blob/master/php7-fpm/Dockerfile) you are configuring xdebug to run under 9001 instead of the default-port 9000 which is used by PHP-FPM. So if xdebug worked before, this should not change everything as only 9000-9000 was exposed.

Thank you @SebTM & @leroy0211

You are welcome @maxpou :)


Zero available balance UX

A big topic we discussed many times. I personally think we should never present available balance 0 when it's very likely not a zero or we don't know the value yet. This topic goes even beyond this and one of other things that will greatly improve the UX is to show some spinner/progress in the UI. Even with Available balance 0, if the spinner is tight to this field, users would get some information. It's like
"ok, I see 0 which scares me a bit but on the other hand I see a spinner so it must be doing something and hopefully I'll see my balance again once this processing is done".
And it will.
There are also discussions if we get rid of the whole component, at least on an Account page. Another discussion was about renaming it to spendable balance or similar formats.

@LukasKorba I tracked an issue for this on Friday where I referenced the conversation on Slack we had: https://github.com/Electric-Coin-Company/zashi-ios/issues/1043 Should we continue our conversation on this inside that issue and mark this one as a duplicate?

Alternatively, I can copy the information I tracked into this one.

@LukasKorba I tracked an issue for this on Friday where I referenced the conversation on Slack we had: #1043 Should we continue our conversation on this inside that issue and mark this one as a duplicate?

Closing as duplicate then


strict boolean expressions compilerOption

Search Terms
require strict boolean
Suggestion
add yet another --strict check into compilerOptions, to only allow expressions that evaluate to Boolean for all conditional branching - if, for, while, ?: ternary operator, etc
basically this TSLint rule, built into TS compiler
https://palantir.github.io/tslint/rules/strict-boolean-expressions/
Use Cases
often people check the existence of function, before calling it:
if (somFunc) someFunc()
or they think that function is actualy a property, and hence dont call it
if (someVal)... . where it should have been if (someVal()) ...
if if required a strict boolean expression, both of the above would have been errors.
Examples
instead above examples would be written:
if (!!someFunc) someFunc()
and for someValue():boolean
if (someValue())..
Checklist
My suggestion meets these guidelines:

[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

TypeScript 3.7 already added uncalled function checks. Is that what you're asking for?

@DanielRosenwasser  not necessarily uncalled
I refer to
if (condition) ..
while (confition)...
(condition) ? .. : ..

condition to be checked to be strictly boolean, not just truthy / falsy

As a strict consumer, I don't think I would want this functionality, and so I wouldn't want it to be under the main --strict flag.

@DanielRosenwasser  With respect to uncalled function checks, you’re right about support for conditional statements:
if (uncalledFunction) { return 1; } else { return 0; }
//  ^ ts2774 "This condition will always return true …"

but I don’t see the same thing with the ternary expression:
return (uncalledFunction) ? 1 : 0;
//      ^ no error

Do you mean this ESlint / TSLint rule ?
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/strict-boolean-expressions.md
https://palantir.github.io/tslint/rules/strict-boolean-expressions/

@chharvey it should work with ternaries in 3.9
@NN--- I think so
#7746 seems to be the canonical-ish issue for this. We discussed pedantic-mode flags in https://github.com/microsoft/TypeScript/issues/38905.

I suggest that the bang operator should also be strict (only work on bools). So the alternative writing would be Boolean(any) instead of !!any, this makes the coercion more explicit


Add Code Scanning security severity to CSV, improve error handling

Code Scanning alerts were missing the security severity value, this fixes that. Also deals with situations where a feature is requested but not enabled without erroring the whole run.

Thank you @ctcampbell , merged! ❤


Add system tests into CI

Hello @Yadunund ,
I've made some work to integrate system tests like test_rclcpp . But i have a bunch of question.

While running colcon test --packages-select test_rclcpp inside rclcpp_integration.test.py file, we have to set the current working directory of subprocess as workspace directory. I've solved by using launch arguments. I'm ready to hear some better ideas from you.
I couldn't add some packages like test_rclcpp, launch_ros to package.xml due to the fact that CI crash in command colcon list --paths-only --packages-up-to rmw_zenoh_cpp zenoh_c_vendor by throwing out [1.821s] ERROR:colcon:colcon list: Unable to order packages topologically: Do you have any idea?
I'm ready to review.

Hello @Yadunund ,
I've made some work to integrate system tests like test_rclcpp . But i have a bunch of question.

While running colcon test --packages-select test_rclcpp inside rclcpp_integration.test.py file, we have to set the current working directory of subprocess as workspace directory. Otherwise colcon cannot find the workspace automatically. I've solved by using launch arguments. I'm ready to hear some better ideas from you.
I couldn't add some packages like test_rclcpp, launch_ros to package.xml due to the fact that CI fails in command colcon list --paths-only --packages-up-to rmw_zenoh_cpp zenoh_c_vendor by throwing out [1.821s] ERROR:colcon:colcon list: Unable to order packages topologically: Do you have any idea?
This time CI takes ~30 minutes for rolling source build and tests. I am yet to be able to decrease CI time. Are there some alternatives like osrf/ros2::nightly you know?
Should we add tests for jazzy and iron?

I'm ready to get some review.

Related to question:

I assume this is happening when using debs, test_rclcpp should not be available in the workspace that's why you see this error.

Compiling up to test_rclcpp requires to compile many packages and the resources of the workers are not high. I think it's a resonable time. Using osrf/ros2:nighly will require to release a package to get the changes, while compiling from source it's just when we merge PRs. I think we should keep this behaviour. What do you think @Yadunund  ?

Yes, we should do the same with jazzy and iron. We might include some behavioral changes and we should be able to detect them

Yeah you can ignore first qustion in https://github.com/ros2/rmw_zenoh/pull/271#issuecomment-2316195584 . More quetions:

Do you want to run test in only source builds, or you also want to run tests for binary builds ?
Which test packages do you wanna run (test_rclcpp, rcl, test_communication and so on)?
Which files should be uploaded via upload artifact?

Hi @CihatAltiparmak,
Sorry for the delay in my review.

Do you want to run test in only source builds, or you also want to run tests for binary builds ?

We need to build system_tests from source as the binaries are not available. Since we already have a job that builds Rolling from source, we can just run the tests in the same workflow.
I wonder if we should not run the source job on pull request. Instead we can have it run nightly. We can add a Rolling binary job to the on pull request workflow.

Which test packages do you wanna run (test_rclcpp, rcl, test_communication and so on)?

imo  test_rclcpp and test_communication would be good ones to run (we should include the -DSKIP_MULTI_RMW_TESTS=On cmake arg to the build command) but there is a known issue there https://github.com/ros2/rmw_zenoh/issues/275

Which files should be uploaded via upload artifact?

colcon test should generate a test artifact (.gtest.xml) which you can find in the logs.

Hi @CihatAltiparmak,
Sorry for the delay in my review.

Do you want to run test in only source builds, or you also want to run tests for binary builds ?

We need to build system_tests from source as the binaries are not available. Since we already have a job that builds Rolling from source, we can just run the tests in the same workflow.
I wonder if we should not run the source job on pull request. Instead we can have it run nightly. We can add a Rolling binary job to the on pull request workflow.

Which test packages do you wanna run (test_rclcpp, rcl, test_communication and so on)?

imo test_rclcpp and test_communication would be good ones to run (we should include the -DSKIP_MULTI_RMW_TESTS=On cmake arg to the build command) but there is a known issue there #275

Which files should be uploaded via upload artifact?

colcon test should generate a test artifact (.gtest.xml) which you can find in the logs.

Don't worry.  At the moment, we can add only binary builds to matrix when github.event_name is not scheduled. I've also added other suggestions like -DSKIP_MULTI_RMW_TESTS=On . The selected_system_tests arg can be passed to rmw_zenoh_integration.test.py It's okay for review after i pass the env.RMW_MIDDLEWARE_TEST_PACKAGES to selected_system_tests

Hello @Yadunund , would you take a look at latest changes here? In latest version of this PR, we can run system test by giving argument to launch file and then load artifacts for each ros distro. Don't merge at the moment but it's ready.
https://github.com/CihatAltiparmak/rmw_zenoh/blob/c326da645f83f859e0b723a26bcca41ccbcf29b8/.github/workflows/build.yaml#L22
After testing source based builds, we can modify this contidion. I'm aware of this change and it's temporary.

@CihatAltiparmak the changes here looks great to me!

@CihatAltiparmak the changes here looks great to me!

Cool, i'm leaving to you which systems tests it will be run.

@clalancette and @Yadunund any other package that we should include?

I'm honestly not sure whether we should do this at all.
The goal here is to integrate rmw_zenoh into the main ros2.repos.  Once we do that, the nightly jobs on https://ci.ros2.org will automatically be building and testing rmw_zenoh overnight.  Is it worth it to also have this in a GitHub action?  I'm not sure.

@ahcorde Could you show which tests are skipped so that i can investigate this issue easier? Seems you already have merged PR that skips test_event related tests : https://github.com/ros2/rcl/pull/1180 and i see that all of skipped tests are related to this PR. But i will also run rcl tests in my computer and i will give feedback asap. If you decide to add this CI, i will add your suggestions. You can also add it, allow maintainers to edit option is ON.
@clalancette

Once we do that, the nightly jobs on https://ci.ros2.org/ will automatically be building and testing rmw_zenoh overnight.

The default configuration of rmw_zenoh needs  zenoh router to run separately. So i implemented rmw_zenoh_integration.test.py as well. to only run colcon test command doesn't work for the default configuration of rmw_zenoh. If you don't think this CI is not necessary, it can be deleted build.yaml file completely. I don't know how  https://ci.ros2.org/ runs. Btw this changes are temporary as @Yadunund states here.
Now i come up with new option: workflow_call. You add to your ros2.repos url and the branch you wanna test thanks to this option.


Application Only OAuth

I would like to have a user-less context with an installed app. Application Only OAuth looks like the best way to do that. The relevant grant_types are here: https://github.com/reddit-archive/reddit/wiki/OAuth2#application-only-oauth
The following request:
POST /api/v1/access_token HTTP/1.1
Host: www.reddit.com
Content-Type: application/x-www-form-urlencoded
Authorization: Basic <client_id>
Cache-Control: no-cache

grant_type=https%3A%2F%2Foauth.reddit.com%2Fgrants%2Finstalled_client&\
device_id=DO_NOT_TRACK_THIS_DEVICE

responds with
{
    "access_token": "<access_token>",
    "token_type": "bearer",
    "device_id": "DO_NOT_TRACK_THIS_DEVICE",
    "expires_in": 3600,
    "scope": "*"
}

Is this currently possible with snoowrap? If not, do you foresee any difficulties/API breaking if this were implemented?
Thanks for creating and maintaining this awesome library! 😃

Hi, thanks for creating an issue. This isn't currently possible with snoowrap, although I would accept a pull request to add it if you're interested in working on it.
I'm imagining it as a static method on snoowrap that would accept a client ID/device ID/user agent as parameters, and return a Promise for a snoowrap instance (similar to how the fromAuthCode method works).

Sounds good. Although I think the changes will extend to updateAccessToken etc.

@not-an-aardvark  I have a nodejs server that wants to pull recent reddit posts from several subreddits, which doesn't need links to a user account at all. I think it is related to this issue, but when I do the following:
const r = new snoowrap({
        userAgent: userAgent,
        clientId: clientId,
        clientSecret: secret,
        refreshToken: refreshToken
    });
    r.getHot().map(post => post.title).then(console.log);

I get this error: Unhandled rejection StatusCodeError: 400 - {"message":"Bad Request","error":400}
How come I can't just pass in my clientId / secret that I got form https://www.reddit.com/prefs/apps/, and start making calls?

@napindc Thanks for your comment, but I don't think your problem is related to this issue. Can you please open a new issue?

(sorry, hit the wrong button and temporarily closed this issue)

Fixed in #207


Relocate Char::Reader comments for documentation

Char::Reader struct comments were placed at top level (Char) instead
of the proper, inner structure, Reader.
Because of this, generated documentation missed to collect them and
include in the output.
This change, while doesn't introduce any new documentation, ensures
at least this comment is not lost.
Thank you.
:heart: :heart: :heart:

Ah my bad, thank you!


Set up and test tracking for Hard Graft guides

Ensure usage/engagement of new exhibition guides can be tracked.

[x] Add campaign parameters to QR code urls and provide to Exhibitions team
[ ] Update formulas in URLinator spreadsheet for future guides
[x] HotJar tracking on exhibition guides
[ ] Update Gitbook guidance on setting up urls for tracking

Urls for the QR codes here with GA campaign tracking:
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=1&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop1
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=2&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop2
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=3&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop3
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=4&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop4
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=5&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop5
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=6&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop6
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=7&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop7
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=8&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop8
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=9&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop9
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=10&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop10
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=11&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop11
https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=12&utm_source=Gallery1&utm_medium=QRCode&utm_id=HardGraftGuides&utm_content=Stop12

Need to check on Monday but think I need to switch campaign ID with campaign name for utm tracking to get the existing report to work eg. https://wellcomecollection.org/guides/exhibitions/ZsdFlRIAACIAqKGB?usingQRCode=true&stopNumber=12&utm_source=Gallery1&utm_medium=QRCode&utm_campaign=HardGraftGuides&utm_content=Stop12

Wahoo - utm campaign tracking working

Now just need to update Gitbook and the spreadsheets so future exhibition guides can be set up without our help.

All done!


Lenient parsing of default values

Based on X.690 DER restrictions (section 11.5), when encoding a set or sequence, any field that is equal to its default value shall not be included in the encoding. Nevertheless, ZLint’s parser does not adhere to this requirement and reports errors for specific fields that have default values, such as the CA flag of the Basic Constraint extension, the critical flag of extensions, and the Version.

I think this is a duplicate of https://github.com/zmap/zlint/issues/639.


ESD is offline / Google Docs encountered an error

Describe the bug
When opening ESD sidebar, continually getting error from Google: "Google Docs encountered an error. Please try reloading this page, or coming back to it in a few minutes."
To Reproduce

Open a new spreadsheet
Extensions > Export Sheet Data > Open Sidebar
See error

Expected behavior
Would expect sidebar to open. Occasionally it does open, but any attempt to export the JSON results in the same error
Screenshots
Screenshots attached
Info (please complete the following information):

Chrome Version 122.0.6261.69 (Official Build) (arm64)
MacBook 2021 M1 pro, Ventura 13.3.1 (22E261)
Multiple accounts have profiles on this laptop

Additional context

Attempted to reinstall - failed
Cleared cache - failed
Tried on multiple different laptops (Mac and PC) - failed

Sorry, I now see this is a known issue linked to having multiple accounts signed in. I've found a workaround

Sorry Google's support for multiple accounts is so buggy. I have never found a good work around for the issue unfortunately.