Fixes for compilation errors on GCC 5 / 6

Fixes for compilation errors on GCC 5 and 6:
use of auto before deduction of auto
From the error it seems that the implementation of begin() and end() can't find appropriate functions for the std::vector:
[…]/pipes/tests/override.cpp:28:57: error: use of ‘auto {anonymous}::MyCollectionNamespace::begin({anonymous}::MyCollectionNamespace::MyCollection&)’ before deduction of ‘auto’
         auto begin(MyCollection& myCollection) { return begin(myCollection.data_); }
                                                         ^~~~~

converting from initializer list would use explicit constructor
This fails on GCC 5 only. I guess later versions have fixed the defect report N4387.
[…]/pipes/tests/unzip.cpp:15:100: error: converting to ‘std::tuple<int, int, int>’ from initializer list would use explicit constructor ‘constexpr std::tuple< <template-parameter-1-1> >::tuple(_UElements&& ...) [with _UElements = {int, int, int}; <template-parameter-2-2> = void; _Elements = {int, int, int}]’
 uple<int, int, int>> lines = { {1, 2, 3}, {4, 5, 6}, {7, 8, 9}, {10, 11, 12} };
                                                                              ^

GCC 5 and 6 CI builds
I have added CI builds to cover both compiler versions.

Thanks for the PR!


Background-image incorrectly added in sap.m.Image (background mode) leading to no image

OpenUI5 version: 1.34.13 and 1.38.3
Browser/version (+device/version): independent of browser
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible):
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Use background image option in sap.m.Image

What is the expected result?
Image should appear, and background-image CSS  url should contain image
What happens instead?
Image will render as None (background-image CSS url is empty)
Any other information? (attach screenshot if possible)
Simple fix in current source of sap.m.Image:
https://github.com/SAP/openui5/blob/master/src/sap.m/src/sap/m/Image.js#L186
Line is:
$DomNode.css("background-image", "url(" + this._oImage.src + ")");
It should be something like (note the additional quotes):
$DomNode.css('background-image', 'url("' + this._oImage.src + '")'	);

Thanks Mattie for pointing out this issue, i will let the code owner of the image control know about your suggestion so that we can make a fix. He will get back to you here soon.
Internally tracked as:<PHONE_NUMBER>
Kind Regards,
Michael

Hi mattieharding,
I'm currently testing a sample with background image - the source in latest version is the same at this line.
The url is there and only the width and height need to be set for it to be visible,
Where do you manage to reproduce the issue?
Regards, Mihail.

Hi Mihail,
I came across the issue when adjusting the image in the Employee Lookup
Fiori app to use background images so that the image would not be
distorted, and tracked it down to the line in question. I'll see if I can
get a jsbin or equivalent together sometime to get it (not) working.
Possibly it's only an issue with bound URL's as I didn't test it with a
fixed image.
Cheers,
Matt
On 14 July 2016 at 21:25, myordanov<EMAIL_ADDRESS>wrote:

Hi mattieharding,
I'm currently testing a sample with background image - the source in
latest version is the same at this line.
The url is there and only the width and height need to be set for it to be
visible,
Where do you manage to reproduce the issue?
Regards, Mihail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SAP/openui5/issues/1060#issuecomment-232638456, or mute
the thread
https://github.com/notifications/unsubscribe/AB4DYV4APQq7w1ZSgLjJ8vcEowCiBJ_nks5qVhyrgaJpZM4JHvZy
.

Hi Mattie,
i am using this feature a lot (because i have requested it formerly and introduced the code  ;-)
see:
http://openui5.blogspot.com/2015/01/image-vs-backgroundimage.html
Did you see the info from Mihail?
Regular Images without width|height will fit to image size, but background images need a hard sized container instead.
When i use such kind of background images inside flex box layouts, in some situations i need to add a custom class to address the underlying flex item and give a sice like height: 60%.
If you run in such issues, the best way is to use chrome dev tools element inspector and see, if the image container has a zero width or height!
Thx again to UI5 Team for implementing this former feature request.
Regards
Holger

Hi Matt,
As Mihail told you previously there's no issue here. The quotes here make no difference at all. If you manage to reproduce the issue and demonstrate it in some fashion, open another issue, but as it can be seen in this sample, the Image works fine.
Thanks and Regards,
Dimo


If the obscene word is at the beginning the censoring is not recovered

Expected behavior
Typing "fu" censors the word into "**" but continuing on to typing "funtastic" yields a "ntastic". It's similar to "as" filtering to "" but having "assembly" yields "**sembly".
Actual behavior
**ntastic
Minimal reproducible example
No response
Steps to reproduce
No response
Additional context
No response
Node.js version
v20.11.1
Obscenity version
v0.3.1
Priority

[ ] Low
[ ] Medium
[X] High

Terms

[X] I agree to follow the project's Code of Conduct.
[X] I have searched existing issues for similar reports.

Thanks for the report, but it's not at all clear what the actual issue is from your description. Can you provide a minimal reproducible example and explicitly identify the actual versus expected output?
Note that with the default datatest, neither of the strings funtastic nor assembly contain any matches.

Per my previous comment, this issue is not actionable as is. Given the lack of response, I am closing off this issue for now but would be happy to reopen and investigate further if more detail is provided. Thanks.


Install 3 replicas of temporal services

Install 3 replicas of each of temporal's services (except web).

leaving the default of 1. our test scenarios that require other configuration are addressed by passing the appropriate replica count to helm install ... --set ...


Android TimeSpan objects like 'Position' or 'Duration' retrieve wrong info.

I'm playing a mp4 Video (tried with several). It seems like each second gets multiplied by 1000. Doesnt matter if I get the TotalSeconds or the TimeSpan itself. The numbers are way too high.

Got any repro steps or project? Seems a bit of an big effort to setup, to find the bug, if there are any at all.

You can use the Xamarin.Forms Sample App. If you set a break point to PlayingChanged Event you can have a look at the e.Position.TotalSeconds Property.

I think I found the issue and created a pull request. #334

Found the issue after having encountered the very same problem.
As a workaround, I'm doing this:
.Select(@event =><EMAIL_ADDRESS>/ 1000))

Thanks for the PR @NicoKno, I hope it could be merged quickly.

Can I please know when will be the next release?
Because, I'm getting crazy values for e.Duration.ToString(@"mm\:ss") & e.Position.ToString(@"mm\:ss")
Or any simple workaround to use these?
Thanks in advance! :)

You can make a nuget yourself if you run the cake script :)

@mhdshbk You should read the thread... I proposed a workaround above. Take the seconds in the original event, and create a new TimeSpan with FromMilliseconds.
My current workaround:
// @todo Remove this fix when next version of XamarinMediaManager is released.
// (Workaround a MediaManager bug on Android)
// https://github.com/martijn00/XamarinMediaManager/issues/331
TimeSpan FixTimeSpan(TimeSpan ts) =>
    Device.RuntimePlatform == Device.Android ? TimeSpan.FromMilliseconds(ts.TotalSeconds) : ts;

var mediaDurationObs = mediaTimingObs
    .Select(@event => FixTimeSpan(@event.Duration))
    .StartWith(requestedMedia.Duration);

var mediaPositionObs = mediaTimingObs
    .Select(@event => FixTimeSpan(@event.Position))
    .StartWith(TimeSpan.Zero);

Thanks for reporting this, just used to fix my App too


Add PrefixSet.PrefixSeq and PrefixSet.PrefixCompactSeq

Closes #12.

Thanks for this!
I looked for examples of iterators being added to existing packages with respect to naming, and didn't find anything.
I'm considering just using All() and AllCompact(), or even your original suggestion of repurposing Prefixes() and PrefixesCompact()` since this package doesn't have many users yet.

I looked for examples of iterators being added to existing packages with respect to naming, and didn't find anything.

There's one in the standard library: golang/go#61901. They went with Lines, Bytes for new functions, and SplitSeq, FieldsSeq for iterator forms of existing functions, with the rationale being:

If we were writing the library from scratch, we might use the names Split, Fields, and Runes for the iterator-returning versions, and code that wanted the full slice could use slices.Collect. But that's not an option here, so we add a distinguishing Seq suffix. We do not expect that new functions will use the Seq suffix. For example the function above is Lines, not LinesSeq.

I'm considering just using All() and AllCompact(), or even your original suggestion of repurposing Prefixes() and PrefixesCompact() since this package doesn't have many users yet.

Both options look good to me. I'll update the PR when you make a decision.

Both options look good to me. I'll update the PR when you make a decision.

Thanks for the examples. Since PrefixSet says what kind of element it stores right there in the name, I've decided to go with All and AllCompact.
This lets us keep parity with netipx's API for now, while moving forward with conventional names for iterators. It also nicely telegraphs names for PrefixMap iterators: All, Keys, and Values (plus respective *Compact versions).

@database64128 would you like to update the commit message with the name changes before I merge?

would you like to update the commit message with the name changes before I merge?

Oops, missed that. Done.

Looks good!


Missing tracepoints and code sections will cause runtime panic

A slightly modified version of the timers example:
programs:
  - name: timers
    metrics:
      counters:
        - name: timer_start_total
          help: Timers fired in the kernel
          table: counts
          labels:
            - name: function
              size: 8
              decoders:
                - name: ksym
    # tracepoints:
    #   timer:timer_start: tracepoint__timer__timer_start
    # code: |
    #   BPF_HASH(counts, u64);

    #   // Generates function tracepoint__timer__timer_start
    #   TRACEPOINT_PROBE(timer, timer_start) {
    #       counts.increment((u64) args->function);
    #       return 0;
    #   }

Will cause a panic: runtime error: index out of range [0] with length 0 when run.

Full output

panic: runtime error: index out of range [0] with length 0
goroutine 29 [running]:
github.com/iovisor/gobpf/bcc.(*TableIterator).Next(0xc0001c0eb0, 0xc0001c0eb0)
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/vendor/github.com/iovisor/gobpf/bcc/table.go:283 +0x3e5
github.com/cloudflare/ebpf_exporter/exporter.(*Exporter).tableValues(0xc0001c0a50, 0xc0001dcc00, 0xc0001baf18, 0x6, 0xc000230bd0, 0x1, 0x1, 0x7f3121bcd190, 0xaf, 0x7f3123544900, ...)
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/exporter/exporter.go:242 +0xfa
github.com/cloudflare/ebpf_exporter/exporter.(*Exporter).collectCounters(0xc0001c0a50, 0xc0001bf380)
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/exporter/exporter.go:151 +0x1b2
github.com/cloudflare/ebpf_exporter/exporter.(*Exporter).Collect(0xc0001c0a50, 0xc0001bf380)
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/exporter/exporter.go:143 +0x398
github.com/prometheus/client_golang/prometheus.(*Registry).Gather.func1()
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/vendor/github.com/prometheus/client_golang/prometheus/registry.go:443 +0x12b
created by github.com/prometheus/client_golang/prometheus.(*Registry).Gather
/cfsetup_build/prometheus-ebpf-exporter/tmp/build/cloudflare-ebpf_exporter-cf86dcc/vendor/github.com/prometheus/client_golang/prometheus/registry.go:454 +0x5ce

This is clearly bad input so it's not a huge deal but it might be nice to surface a warning if the code section is missing.

For a more realistic example of this happening: this came up because I messed up some indentation which caused the code and tracepoints sections of the config to not get generated correctly.

Fixed in #104, thanks!


Does not connect the phpbrew bin path when $PHPBREW_BIN is blank

Hi,
when I was started terminal and I just run echo $PATH.
The PATH is displayed as follows.
/Users/kurotaky/.phpbrew/php/php-5.6.3/bin::/Users/kurotaky/.plenv/shims:/Users/kurotaky/.rbenv/shims:/Users/kurotaky/.rbenv/shims:/usr/local/Cellar/emacs/HEAD/bin:/Users/kurotaky/.rbenv/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/Users/kurotaky/bin

Although there is no assigned path to $PHPBREW_BIN, that is connected.
but the empty pathname( like ::) referred to the current directory in POSIX.
so I fixed problem, the phpbrew bin path is not connected when $PHPBREW_BIN is blank.

Looks good! Thanks!

Thank you for checking and merge : )


iOS: Page able to be dragged horizontally

Best reproduce case I've found so far is at http://ionicframework.com/demos/collection-repeat.
Drag the header left or right.
Mentioned in #1157

I can still reproduce this issue with Beta 14 on iOS. An overflow shift would automatically happen when a select was triggered on device/simulator. You could see a white 1px line on the right side.
It's specifically .bar .title + .buttons { right: 5px; } that is causing the issue. Changing to right: 6px;` does solve the issue.
The best/simplest fix I could find was just adding .bar { overflow: hidden; } to my project. I have not seen any negative impact because of that added rule, so it might be worth adding it to _bar.scss.

Can you provide a simple codepen that can replicate this?


Request: MTS-ESP

MTS-ESP is a new method of re-tuning software instruments. It has two advantages over older workflows.
1: All (compatible) software instruments are retuned simultaneously by one master plugin. This saves a lot of repetitive work loading scale files into each instance.
2: Tuning can change dynamically during playback. This is truly wonderful for working in Just Intonation especially, where we oftentimes want to subtly tune individual notes up or down depending on the chord being played. It also enables many other cool things, like gradually gliding from one tuning to another.
It is my perception that the microtuning-community nowadays feels that fully adequate tuning support means enabling both of the methods, scl/kbm files, and MTS-ESP. The latter is superior in the aforementioned ways, but many folks have years of experience with the former. Hence the request for both.
I understand there are some challenges to implementing this in a sampler. They would be the same ones as mentioned in issue #329, where I also just commented. If the issues of key ranges can be resolved, then it'd be wonderful to have MTS-ESP support as well. :)
Implementation is very similar to the Surge Tuning Library, instructions are found here: https://github.com/ODDSound/MTS-ESP
All the best!

Please note the core lib for MTS-ESP is not opensource.
This is an issue when building things together with GPL components.

Hi!
You keep saying that and as you know I am sure you are wrong. But that's a tedious argument.
So rather than argue that you are wrong, I decided to just make your statement false.
https://github.com/baconpaul/mts-dylib-reference
there is a fully open source implementation of the MTS intermediating dynamic library. Using it, I was able to make Surge XT tune using MTS ESP when using
https://github.com/baconpaul/simple-mts-main
which is a fully open source implementation of the MTS "Master" (namely a tuning provider).
Best

Well that is a new development that you made.
According to MTS authors in https://github.com/ODDSound/MTS-ESP/issues/6 the official library is closed-source.

Yeah but that is dynamically loaded and can be subbed out with another. So after chatting with them I just made an open reference implementation.
it’s not as good as the closed source one, but surge isn’t as good as diva and we load diva in open source vst hosts.
I think practically most folks will use the closed source one but nothing stopping an enterprising developer competing around the open api if they want to improve it!
best

But most importantly it is now entirely possible to get a retuned synth using MTS esp with only GPL or mit software in both your compiled and dynamically loaded path. That’s really the point.

That is a grey are still at best. making a dummy/stub DLL and linking a GPL program to it, then replacing the DLL with a proprietary one.
In Germany we would say this goes "against the spirit of the law", as to say it is clearly made as a way to avoid what GPL requires, basically a loophole.
It isn't pretty and not everyone agrees this is a good approach.

So if I load diva into Carla is that a GPL problem?

if you create a copycat of Diva that does no sound, integrate it in carla as official feature, and then replace the early dummy copycat with a proprietary version - yes.

Anyway the argument is tedious. You can get an entire MTS esp experience with fully open source software today and the software is all linked here. If you don’t like it that’s fine, but if you think it is false then you are just not reading the code in front of your face!

if you create a copycat of Diva that does no sound, integrate it in carla as official feature, and then replace the early dummy copycat with a proprietary version - yes.

I mean you are just making up stuff now. Which section of the license says that?

I dont see any implementation details in https://github.com/baconpaul/mts-dylib-reference/blob/main/src/mts-dylib-reference.cpp, it is all stubs.
am I missing something?

It’s not all stubs. It implements tuning!

MTS just shares a bool, an int and either one or 16 128 double arrays between plugins. That’s it.

I see, so that part is nice. Still won't work in bitwig and a few other scenarios because of plugin bridging.
IPC is not particularly hard, but it is tedious, synchronization is the tricky bit..

if you create a copycat of Diva that does no sound, integrate it in carla as official feature, and then replace the early dummy copycat with a proprietary version - yes.

I mean you are just making up stuff now. Which section of the license says that?

I mean if we just mimic proprietary APIs as open with the intention of replacing such bits again with proprietary things... that is running circles around the GPL no? It is all just a dance to not have to deal with opensourcing a little bit of code.
As I said, not everyone agrees this is a good approach. It is clearly made as a way to get around GPL, is it not?
The MTS stuff should have been open in the first place.
We cant package it on Linux distributions at the moment, for those running mostly opensource software it makes such integrations unwanted until the situation improves.

It’s an open api. The client and master api are fully open source which is why I could implement a client a master and an intermediate.
Should isn’t that useful a comment I don’t think here. Although I think I would probably have Mae the intermediate lib open also if I was running the project, which I wasn’t. I was just trying to once and for all close the salient the question about whether you have a GPL problem when you can get a fully functioning system with all the code available under a GPL or more permissive license. And gave a worked solution of that to put that particular matter to rest

It’s an open api.

APIs are not copyrightable, we can reimplement them, so calling it "open api" is meaningless.

The client and master api are fully open source which is why I could implement a client a master and an intermediate.

this is a bit misleading. the end points that connect to the middleware are open yes, but the middleware (was) not.

Should isn’t that useful a comment I don’t think here. Although I think I would probably have Mae the intermediate lib open also if I was running the project, which I wasn’t. I was just trying to once and for all close the salient question about whether you have a GPL problem when you can get a fully functioning system with all the code available under a GPL or more permissive license. And gave a worked solution of that to put that particular matter to rest

your efforts are appreciated of course.
sorry for being harsh here, but it really pains me seeing opensource projects trying to quickly jump into integrations for things that were not as clearly opensource. there is a question of ethics here.
sfizz being an opensource project should target the opensource variant (you made) for MTS, disregarding the proprietary one. though of course it is not my call to make.

For sfizz there is zero difference. The plugins don’t compile in the library.

MTS-ESP uses a BSD Zero Clause License
I asked ChatGPT "are GPL licenses compatible with a BSD Zero Clause License"
The answer:

Yes, the GPL licenses and the BSD Zero Clause License are generally considered compatible.
The BSD Zero Clause License (also known as the "0BSD" or "FreeBSD License") is a very permissive open-source license that allows for free use, modification, and redistribution of the software without any restriction. The license essentially puts the software in the public domain.
The GPL licenses, on the other hand, are a family of copyleft licenses that require derivative works to be licensed under the same terms as the original work. This means that if you use or modify software that is licensed under the GPL, you must also license your derivative work under the GPL.
Because the BSD Zero Clause License is so permissive, it does not impose any additional restrictions on the software, which means it is compatible with the GPL licenses. This means that you can include BSD Zero Clause licensed code in a larger project that is licensed under the GPL, without violating either license. However, it's important to note that if you modify the BSD Zero Clause licensed code, you must still comply with the GPL requirements for any derivative works you create.

err since when is ChatGPT a lawyer or expert on any specific field? ChatGPT tends to give quite some B-tier replies, if not worse sometimes

AI apparently doesn't use logical fallacies
your response however contains an Appeal to Authority and an Ad Hominem
is the reply to the question asked of ChatGPT accurate or not?

Recentering the thread a bit: thanks for the info, I remember we talked about this before and I'll look into it if I find some time! I'll evaluate the licensing situation since I definitely don't want to taint the library, but I haven't looked deeply into it yet.
Thanks all for your arguments!


FEATURE: Do you have any plan for get user's highlights?

Do you have any plan for get user's highlights?

I'm starting implement Highlights.
And I created a pull request.

[x] Add model
[x] Add example
[x] Implement getHighlights() method
[x] Add test
[ ] Implement get media stories of a highlight

Regarding the last one, which is to implement taking story medias of highlight, for the best implementation, I need advice.
There is now getStories that can be expanded it or a new function can be created, such as getHighlightStories.
Both stories and highlights are available in the shared $jsonResponse['data'] ['reels_media'].
And in the output of each we have:
STORY: user AND owner (currently in getStories the user is used, which of course can be changed based on owner)
HIGHLIGHT: owner
Also the submitted send parameters needed of each:
STORY: reel_ids
HIGHLIGHT: highlight_reel_ids
URLs:
STORY:
https://www.instagram.com/graphql/query/?query_hash=90709b530ea0969f002c86a89b4f2b8d&variables={"reel_ids":["1097615892"],"tag_names":[],"location_ids":[],"highlight_reel_ids":[],"precomposed_overlay":false,"show_story_viewer_list":true,"story_viewer_fetch_count":50,"story_viewer_cursor":"","stories_video_dash_manifest":false}
HIGHLIGHT:
https://www.instagram.com/graphql/query/?query_hash=90709b530ea0969f002c86a89b4f2b8d&variables={"reel_ids":[],"tag_names":[],"location_ids":[],"highlight_reel_ids":["17947844917345377","17850034517139791","17931385762360834"],"precomposed_overlay":false,"show_story_viewer_list":true,"story_viewer_fetch_count":50,"story_viewer_cursor":"","stories_video_dash_manifest":false}
The differences between story and highlight are obvious. It remains to be seen what the best execution mode will be, whether everyone will focus on getStories or write a new function to do so.
Given that important note, both type are Media entity class.

@raiym
I did not receive a comment on the previous issue I raised. So I went ahead with my ideas.
About get stories of highlight, I think it would have been better to use the same getStories function as the output material of both stories. But the following problems caused me to use a separate function:

It was not possible to identify reel_id type, whether it is a user id or highlights id.
Adding a second argument to the function was not interesting for the reel_id type.
reel_id profile numbers are often much smaller than the number of highlights, but one cannot be sure that the numbers less than a certain value are necessarily related to the profile and more than that to the highlights based on which the operation was separated.
So for now it is preferable to use a standalone function called getHighlightStories which I executed and registered a pull request.

@raiym
I did not receive a comment on the previous issue I raised. So I went ahead with my ideas.
About get stories of highlight, I think it would have been better to use the same getStories function as the output material of both stories. But the following problems caused me to use a separate function:

It was not possible to identify reel_id type, whether it is a user id or highlights id.
Adding a second argument to the function was not interesting for the reel_id type.
reel_id profile numbers are often much smaller than the number of highlights, but one cannot be sure that the numbers less than a certain value are necessarily related to the profile and more than that to the highlights based on which the operation was separated.
So for now it is preferable to use a standalone function called getHighlightStories which I executed and registered a pull request.

I tested the implementation, it didn't work for me. So I tried a different instagram query_hash:
const HIGHLIGHT_STORIES = 'https://www.instagram.com/graphql/query/?query_hash=45246d3fe16ccc6577e0bd297a5db1ab';
with variables:
$variables = [
'highlight_reel_ids'=> $highlight_reel_ids,
'reel_ids'=> [],
'location_ids'=> [],
'precomposed_overlay'=> False,
];
This works good for me, so I changed the query_hash in your function and made another pull request

I tested the implementation, it didn't work for me. So I tried a different instagram query_hash:
const HIGHLIGHT_STORIES = 'https://www.instagram.com/graphql/query/?query_hash=45246d3fe16ccc6577e0bd297a5db1ab';
with variables:
$variables = [
'highlight_reel_ids'=> $highlight_reel_ids,
'reel_ids'=> [],
'location_ids'=> [],
'precomposed_overlay'=> False,
];
This works good for me, so I changed the query_hash in your function and made another pull request

You can use this query_hash for both Stories and HighlightStories, but with different variables
('highlight_reel_ids' and 'reel_ids'). If it is better to put it in one function (with two arguments) please let me now. I will then create a getStories function with 3 arguments, to also include 'location_ids'.

You can use this query_hash for both Stories and HighlightStories, but with different variables
('highlight_reel_ids' and 'reel_ids'). If it is better to put it in one function (with two arguments) please let me now. I will then create a getStories function with 3 arguments, to also include 'location_ids'.

Shame for delay.
That query_hash still works for me, however I changed it to what you said. Although I'm not sure it works for everyone.
In terms of how to implement with 3 arguments, it may not be a bad way right now, but according to Clean Code principles, a function should not have more than 3 arguments. Maybe in the future you need to add other parameters, which then will not be interesting code.
For example, in the current situation, in order to extract only the highlight stories, I have to set null for the first argument:
getStories (null, $highlight_reel_ids);

I think you agree with me that it does not seem like a very interesting method.
Another solution is to create and use a general function, such as a executeQuery($params), which is get an array or object that contains the parameters needed to extract the data.
$param can take values as follows:
$params = [
'reel_ids'=> [111],
];

$params = [
'highlight_reel_ids'=> [222, 333, 444],
];

$params = [
'location_ids'=> [555],
];

$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
];

$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
'location_ids'=> [555],
'foo'=> ['bar'],
];

//And other combinations with more parameters

OR:
$params = new PARAMS_STRUCTURED_CLASS();
//The methods ex.: highlight_reel_ids, reel_ids, location_ids,...Any other number of parameters.

Of course, research may still be needed.

Shame for delay.
That query_hash still works for me, however I changed it to what you said. Although I'm not sure it works for everyone.
In terms of how to implement with 3 arguments, it may not be a bad way right now, but according to Clean Code principles, a function should not have more than 3 arguments. Maybe in the future you need to add other parameters, which then will not be interesting code.
For example, in the current situation, in order to extract only the highlight stories, I have to set null for the first argument:
getStories (null, $highlight_reel_ids);

I think you agree with me that it does not seem like a very interesting method.
Another solution is to create and use a general function, such as a executeQuery($params), which is get an array or object that contains the parameters needed to extract the data.
$param can take values as follows:
$params = [
'reel_ids'=> [111],
];

$params = [
'highlight_reel_ids'=> [222, 333, 444],
];

$params = [
'location_ids'=> [555],
];

$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
];

$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
'location_ids'=> [555],
'foo'=> ['bar'],
];

//And other combinations with more parameters

OR:
$params = new PARAMS_STRUCTURED_CLASS();
//The methods ex.: highlight_reel_ids, reel_ids, location_ids,...Any other number of parameters.

Of course, research may still be needed.

I like the solution with the $params. However that will not be backwards compatible with the current implementation of getStories. For backwards compatibility a new function should be created, that will be called by getStories and e.g. getHighlightStories.
I would like more discussion next time.
However I did  create the getStories variant with 3 parameters and a getHighlightStories function (with 1 parameter) that calls the first function and are accepted and now in the code. If we still want to change it, that’s ok for me.
Verstuurd vanaf mijn iPad

Op 23 jan. 2021 om 00:52 heeft Nabi KaramAliZadeh<EMAIL_ADDRESS>het volgende geschreven:

Shame for delay.
That query_hash still works for me, however I changed it to what you said. Although I'm not sure it works for everyone.
In terms of how to implement with 3 arguments, it may not be a bad way right now, but according to Clean Code principles, a function should not have more than 3 arguments. Maybe in the future you need to add other parameters, which then will not be interesting code.
For example, in the current situation, in order to extract only the highlight stories, I have to set null for the first argument:
getStories (null, $highlight_reel_ids);
I think you agree with me that it does not seem like a very interesting method.
Another solution is to create and use a general function, such as a executeQuery($params), which is get an array or object that contains the parameters needed to extract the data.
$param can take values as follows:
$params = [
'reel_ids'=> [111],
];
$params = [
'highlight_reel_ids'=> [222, 333, 444],
];
$params = [
'location_ids'=> [555],
];
$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
];
$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
'location_ids'=> [555],
'foo'=> ['bar'],
];
//And other combinations with more parameters
OR:
$params = new PARAMS_STRUCTURED_CLASS();
//The methods ex.: highlight_reel_ids, reel_ids, location_ids,...Any other number of parameters.
Of course, research may still be needed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I like the solution with the $params. However that will not be backwards compatible with the current implementation of getStories. For backwards compatibility a new function should be created, that will be called by getStories and e.g. getHighlightStories.
I would like more discussion next time.
However I did  create the getStories variant with 3 parameters and a getHighlightStories function (with 1 parameter) that calls the first function and are accepted and now in the code. If we still want to change it, that’s ok for me.
Verstuurd vanaf mijn iPad

Op 23 jan. 2021 om 00:52 heeft Nabi KaramAliZadeh<EMAIL_ADDRESS>het volgende geschreven:

Shame for delay.
That query_hash still works for me, however I changed it to what you said. Although I'm not sure it works for everyone.
In terms of how to implement with 3 arguments, it may not be a bad way right now, but according to Clean Code principles, a function should not have more than 3 arguments. Maybe in the future you need to add other parameters, which then will not be interesting code.
For example, in the current situation, in order to extract only the highlight stories, I have to set null for the first argument:
getStories (null, $highlight_reel_ids);
I think you agree with me that it does not seem like a very interesting method.
Another solution is to create and use a general function, such as a executeQuery($params), which is get an array or object that contains the parameters needed to extract the data.
$param can take values as follows:
$params = [
'reel_ids'=> [111],
];
$params = [
'highlight_reel_ids'=> [222, 333, 444],
];
$params = [
'location_ids'=> [555],
];
$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
];
$params = [
'reel_ids'=> [111],
'highlight_reel_ids'=> [222, 333, 444],
'location_ids'=> [555],
'foo'=> ['bar'],
];
//And other combinations with more parameters
OR:
$params = new PARAMS_STRUCTURED_CLASS();
//The methods ex.: highlight_reel_ids, reel_ids, location_ids,...Any other number of parameters.
Of course, research may still be needed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


conty wine seems ... broken?

No way to run any exe (32bit btw)
error:
bwrap: execvp XXXX.exe: No such file or directory
[on debian 12]

darn.. error! works


Failed to decode downloaded font

Hi,
I cannot use fontello font on my project. I get this error on Chrome:
Failed to decode downloaded font: file:///tmp/site/font/icon.woff?74494834
Failed to decode downloaded font: file:///tmp/site/font/icon.ttf?74494834

And these error on Firefox:
downloadable font: cmap: out of order start range (59392 <= 59392) (font-family: "icon" style:normal weight:normal stretch:normal src index:1) source: file:///tmp/site/font/icon.woff?74494834 demo.html:230:12
downloadable font: cmap: Failed to parse format 4 cmap subtable 0 (font-family: "icon" style:normal weight:normal stretch:normal src index:1) source: file:///tmp/site/font/icon.woff?74494834 demo.html:230:12
downloadable font: cmap: failed to parse table (font-family: "icon" style:normal weight:normal stretch:normal src index:1) source: file:///tmp/site/font/icon.woff?74494834 demo.html:230:12
downloadable font: rejected by sanitizer (font-family: "icon" style:normal weight:normal stretch:normal src index:1) source: file:///tmp/site/font/icon.woff?74494834 demo.html:230:12
downloadable font: cmap: out of order start range (59392 <= 59392) (font-family: "icon" style:normal weight:normal stretch:normal src index:2) source: file:///tmp/site/font/icon.ttf?74494834 demo.html:230:12
downloadable font: cmap: Failed to parse format 4 cmap subtable 0 (font-family: "icon" style:normal weight:normal stretch:normal src index:2) source: file:///tmp/site/font/icon.ttf?74494834 demo.html:230:12
downloadable font: cmap: failed to parse table (font-family: "icon" style:normal weight:normal stretch:normal src index:2) source: file:///tmp/site/font/icon.ttf?74494834 demo.html:230:12
downloadable font: rejected by sanitizer (font-family: "icon" style:normal weight:normal stretch:normal src index:2) source: file:///tmp/site/font/icon.ttf?74494834

I checked each of fontello genered font (eot, ttf, woff) with http://www.fontsquirrel.com/tools/webfont-generator and the website told me that fonts was corrupted.
When I opened the demo.html file with old browser like Konqueror, there are no errors.
I'm using Ubuntu 15.04 and Chrome Version 43.0.2357.124 (64-bit).
I used Fontello API to download a zip file.
But after I imported config.json file to fontello and downloaded manually, it works.
How to fix the problem for API downloading?
fontello.zip

I guess, problem is somewhere in your script.
https://github.com/fontello/fontello/blob/master/Makefile#L104-L135 - i've checked now fontello's script, it works without problems.

My Makefile:
# Edit here - set path to you directory with config.json & fonts

FONT_DIR      ?= /tmp/fontello

### Don't edit below ###

FONTELLO_HOST ?= http://fontello.com

fontopen:
	@if test ! `which curl` ; then \
		echo 'Install curl first.' >&2 ; \
		exit 128 ; \
	fi
	curl --silent --show-error --fail --output .fontello \
		--form<EMAIL_ADDRESS>\
		${FONTELLO_HOST}
	curl --silent --show-error --fail ${FONTELLO_HOST}/`cat .fontello`

fontsave:
	@if test ! `which unzip` ; then \
		echo 'Install unzip first.' >&2 ; \
		exit 128 ; \
	fi
	@if test ! -e .fontello ; then \
		echo 'Run `make fontopen` first.' >&2 ; \
		exit 128 ; \
	fi
	cd ${FONT_DIR}
	rm -rf .fontello.src .fontello.zip css font
	curl --silent --show-error --fail --output .fontello.zip \
		${FONTELLO_HOST}/`cat .fontello`/get
	unzip .fontello.zip -d .fontello.src
	rm -rf ${FONT_DIR}/fontello-*
	mv -f `find ./.fontello.src -maxdepth 1 -name 'fontello-*'` ${FONT_DIR}
	mv -f ./fontello-*/* .
	rm -rf .fontello.src .fontello.zip ./fontello-*

Please, create a repo with minimal possible set of nesessary files and instruction how to reprocude. Not enougth info to decide anything. As i said, api works with my data.

I was just about to post about this issue, and while copy-pasting the error log, I noticed the include path were wrong (my fault though).
I created a less file which makes working with the font more flexible in my project. But when creating it, I kept the same path as the css file... Changed the paths and now it works.
@demsking Make sure the path "file:///tmp/site/font/icon.woff?74494834" doesn't yeild a 404 and/or is not requested from a http/s protocol.
Hope this helps!

Thank you @mystadio for your reply.
But, I don't get any 404 errors. The Chrome's errors are cleary:
Failed to decode downloaded font: file:///tmp/site/font/icon.woff?74494834
Failed to decode downloaded font: file:///tmp/site/font/icon.ttf?74494834

Files has been correctly downloaded, but decoding failed !
But I don't have this problem in the older browsers like Konqueror on PC or on Android with the default browser.
So, what is the problem?

I had the exact same error messages. Chrome might be trying to parse nothing, which will fail.
Also, are you sure you can load fonts from the 'file' protocol? If you say the demo provided in the downloaded zip works, then the font files are properly encoded.
Good luck!

I tried to open ttf file with my system font program, and its work correctly. I can see all my icons's glyphs.
I also tried to open fonts from the 'file' protocol, and Chrome opening the download dialog.
file:///tmp/fontello-a184edfc/font/icon.ttf?94078742

But when I'm trying to open the same file with the Chrome's console, it don't show me the icons's glyphs, but the glyphs of alpha chars.

My problem was resoluted. My config.json was incorect.
Thanks for your help.

fyi, rake assets:clobber seemed to help me

we're facing the same issue with electron 0.36.4 when packaging the contents of the app as asar package. The web-font is part of the asar package. The strange thing is that it works sometimes and sometimes not. it's not easy to reproduce.
2 of 4 builds were fine. Loading the font works on both OSX and Windows. A few minutes later, another build (no changes made just package the app once again) generates an electron app that isn't able to decode the downloaded font. And to add another condition, it's not bound to a platform sometimes it breaks on windows and sometimes on OSX.
We ended up in deactivating asar packaging for the app and all the problems were gone.

same here, how can i fix it?

Still getting this error.


fix #316 and #323 bug

fix #316 and #323 bug

Sorry for the late. Let's try with your suggestion! thank you for your help.


Add Cairo backend (ports/cairo) and testCairo.

cmake/FindCairo.cmake is not written by myself, it is taken from WebKit.

Checked, the BSD code can be added. No problem.

Great Thank you for prompt & detailed review, please let me spend 2 weeks to respond your comments!

Just I've updated my changeset. There is a point to be discussed, how we can "save" the clipping rule (winding/even-odd). In cairo, we cannot set the clipping rule and filling rule separately. The rule set by cairo_set_fill_rule() is used for both of clipping and filling.
If we set the clipping rule as the default rule and overwrite-fill-restore for filling, it could be working? At present, I don't have nice SVG to test the behaviour.

Just I've updated my working branch ( https://github.com/mpsuzuki/svg-native-viewer/tree/PR-ports-cairo-history ). I found one of my FIXME homework could be resolved ( https://github.com/mpsuzuki/svg-native-viewer/commit/0f5101277070d426466ef3284d5e4e7f161cd998 ). Please let me check...

The grayscale JPEG issue is fixed. Just I've updated PR-ports-cairo.


Merge pull request #1 from DennisMerritt/master

separate main

pulled DM -> PCD

sigh, how do I sync these?


[Autocomplete] fix ar translation Typo

Q
A

Bug fix?
no

New feature?
no

Tickets

License
MIT

Change يوجد by توجد in Autocomplete translation

Thanks Aziz!


Allow for multiple sprites

Addresses #30

changed property spriteName -> spriteNames to allow for multiple sprites
updated tests

(most of the files are generated assets from the test, use filter: https://github.com/linkedinlabs/icon-magic/pull/104/files?file-filters[]=.ts to see relevant changes)

Great to see travis running, by the way!


attributes api is not working for inheritance

there are two tests broken right now, that if pass, would fix this bug.
the long/short of it is this. the BaseComposer class has class method attributes that will eventually use the define_method api to take methods from a model and define them on the BaseComposer class or any child classes that inherit from BaseComposer.
I would like to follow the "Rails Pattern" of allowing multiple inheritence that implement the attributes method and merge the array of symbols. this would, in turn, define all the methods in this merged array of symbols on the upmost child object.
a look a the code:
class BaseThing < BaseComposer
  attributes :title, :reddit
end

class ChildThing1 < BaseThing
end

class ChildThing2 < BaseThing
  attributes :id
end
# a model that responds to title, reddit and id
model = Model.new(title: "a title", id: 1, reddit: "a reddit post")
ChildThing1.new(model: model).title #=> "a title"
ChildThing1.new(model: model).reddit #=> "a reddit post"
ChildThing1.new(model: model).id #=> undefined method exeption

ChildThing2.new(model: model).title #=> "a title"
ChildThing2.new(model: model).reddit #=> "a reddit post"
ChildThing2.new(model: model).id #=> 1

hopefully this makes sense, and these examples are ok.

this was taken care of in this commit https://github.com/koryteg/view-composer/commit/daa993f07d9ca382d617335c67275f69bcedd40d


When parameters are provided to the Run Scheduled Workflow, they aren't resolved.

When the Run Scheduled Workflow system task executes and creates a schedule, the Workflow Parameters that are passed through for the chosen Workflow are not resolved

With thanks to @marcusdroy for the property resolution fix.

Verified as fixed.


Referencing netstandard1.6 package in .NET 4.6.1

This issue is about a reference resolution/loading error.  It seemed to me that it's not cli related because I'm not using the .NET Core tools, not corefx related because it doesn't relate to a particular API, and not coreclr because that seems too low-level.. but I'm not sure so please educate me if I'm in the wrong place - thanks :)
dotnet version  1.2.0-beta-001297-00
VS 2017 version 15.3.0 preview 3.0 (i.e. has .NET Standard 2.0 tooling)
I have (maintain, build, publish) a NuGet package which targets only netstandard1.6.
I have a .NET 4.6.1 web application which references it.
I get the IIS error:
Could not load file or assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
The NuGet package's deps.json file lists only System.Runtime 4.3, no references to 4.1.  However, the assembly itself does reference <IP_ADDRESS> (checking via ILSpy).  I don't know why - the project file is straightforward, targets just netstandard1.6, some 1.1.1 versions of Microsoft.AspNetCore.* and Microsoft.Extensions.Options packages and doesn't have any other magic.  It does however reference 3 other NuGet packages in my little system.
One of those NuGet package projects also targets netstandard1.6 but also net451 (and conditionally uses the Microsoft.TargetingPack.NETFramework.v4.5.1 for the net451 build).  The net451 build also conditionally has an (unversioned) reference to System.Runtime (not a package or project reference).  I have no idea if this is relevant, however.
I'd just like to know what the recommended approach or next steps for tracking down the problem here would be - or how can I educate myself about this further?  I get the concept of .NET Standard as an "interface", but don't grasp the entire bigger ecosystem picture in terms of these additional references. Other (.NET Core) consumers of the main NuGet package work just fine.
(note: as per https://github.com/dotnet/standard/issues/295, I do have a reference to NETStandard.Library 1.6.1 on my net461 consumer project)

The. Net Core 2.0 sdk is what delivers the msbuild tasks that enable netstandard 2.0 to work correctly in .net framework projects. Can you try installing that?

I certainly can, although I'm not using .NET Core 2.0 or netstandard2.0.  Will report back in a moment, thank you

Thanks for the suggestion, unfortunately I get the same error.  Any advice around how to approach this would be very much appreciated.

@ericstj

Ah, interesting.  Targeting .netstandard1.6 on a new, blank NuGet package, with no references, it too references System.Runtime, <IP_ADDRESS> according to ILSpy.  So I guess the issue isn't with the NuGet package, but the way I'm consuming it.. ?

NET461 used to be netstandard1.4 but the latest version of NuGet remapped that to netstandard2.0.  It looks like you're using that new version of NuGet with the old packages.
The older packages (like the System.Runtime 4.3.0 package) have a mismatch when installed on .NET 4.6.1.  This is because they have a version of their library for net461 that matches the version that was in the netstandard1.4 folder, but now that NuGet allows netstandard1.6 libraries to install they are broken.
We aren't shipping new versions of these packages, the intent is for folks to get the latest facades from the tooling.
Can you try the following:

set DependsOnNETStandard in your project and see if it fixes it.
If not, then reference the latest NETStandard.Library.NETFramework package in your net461 project.

Adding that project property fixed that issue, thanks.  This may not be the same issue, but I do now also get:
Could not load file or assembly 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
(via [TypeInitializationException: The type initializer for 'System.Web.Http.GlobalConfiguration' threw an exception.])
To give some background, this was a copy-pasted version of an old project which I updated to 4.6.1/VS2017 from 4.5/VS2015.
Note that in this case, there's an assembly binding redirect:
      <dependentAssembly>
        <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
      </dependentAssembly>

and in packages.config:
 <package id="System.Net.Http" version="4.3.0" targetFramework="net461" />
..there's also a build warning:
2>  Consider app.config remapping of assembly "System.Net.Http, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" from Version "<IP_ADDRESS>" [C:\git\kierenj\some-referenced-project-here\bin\Debug\System.Net.Http.dll] to Version "<IP_ADDRESS>" [C:\Program Files (x86)\Microsoft Visual Studio\Preview\Professional\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\\net461\ref\System.Net.Http.dll] to solve conflict and get rid of warning.
The other project (in some-referenced-project-here) is .NET 4.5.1 and has no nuget references, but does reference System.Net.Http <IP_ADDRESS>.
And finally, the reference (on the main project) has a yellow warning icon in VS.

On this new one, is it this - https://github.com/dotnet/corefx/issues/9846 - that I'm hitting?  I'm not sure what the appropriate workaround would be if so, can anyone advise please?

@ericstj please forgive me for being forward, but this is blocking me for a big new project and has eaten a fair amount of my time.  I realise there's no SLA or anything here, but if you are able to recommend any course of action at all - even something time-consuming - I'd be very grateful indeed.

@ericstj isn't available right now. @terrajobst or @weshaggard may have some insight to give before @ericstj is back online.
I know System.net.http has been a challenge.

Thanks, since then I've had the idea to recreate the project from scratch (since it was initially a copy-paste job into VS2017, then I updated VS2017, then fiddled with the above), so I'm trying that in the meantime.

I've been rebuilding the project from scratch.  Still a very similar mix of problems.  I've added the project property not NETStandard.Library.NETFramework package resolved.
I added a binding redirect for Http, which solved that error this time (no roslyn compiler issue) - but am finally left with the System.Runtime error again,  I then double-clicked the build warning around multiple reference version conflicts, which introduced a manifest-not-matching assembly exception for System.ComponentModel.Annotations.
Do let me know if there's anything else I can try / do to diagnose or assist.

@dsplaisted also in case he has any ideas.

I've now made all of the nuget packages under my control target net451 too (as well as netstandard1.6).  I get the same error - currently Could not load file or assembly 'System.ComponentModel.Annotations' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040), with Calling assembly : (Unknown). with a stack trace including System.Web.Configuration.CompilationSection.LoadAllAssembliesFromAppDomainBinDirectory().
In my scenario, will referencing a net451-and-netstandard16 package result in net451 being picked?
What else can I try?  I figured this would fix it!  Thanks again.

Sorry for the comment spam.  It's moved on and I can be more specific:
I'm using Windsor for DI in the .NET project and it's reflecting over the NuGet package's classes.
 System.Reflection.RuntimeAssembly.GetExportedTypes(RuntimeAssembly assembly, ObjectHandleOnStack retTypes) +0 in the stack trace is throwing Could not load file or assembly 'System.ComponentModel.Annotations, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040).
As I say, the NuGet package now targets both net451 and netstandard1.6.  The consuming project is .NET 4.6.1, and references System.ComponentModel (as well as .Primitives and .TypeConverter) 4.3.0.  Via VS build warnings, there are redirects as follows:

				<assemblyIdentity name="System.ComponentModel" publicKeyToken="B03F5F7F11D50A3A" culture="neutral" />
				<bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
			</dependentAssembly>

			<dependentAssembly>
				<assemblyIdentity name="System.ComponentModel.TypeConverter" publicKeyToken="B03F5F7F11D50A3A" culture="neutral" />
				<bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
			</dependentAssembly>
			<dependentAssembly>
				<assemblyIdentity name="System.ComponentModel.Primitives" publicKeyToken="B03F5F7F11D50A3A" culture="neutral" />
				<bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
			</dependentAssembly>

The nuget package, when targeting netstandard1.6, has no specific references in this area.  For net451, there's a <Reference Include="System.ComponentModel" /> which comes into play.

@kierenj there is a lot of issues called out in this thread so it is kind of hard to follow. Can you post a sample project demonstrating your issue somewhere and I will help diagnose it and get to the bottom of the issue.

@weshaggard thanks, I'd like to help get to the bottom of this. It's tricky because the code is confidential.   I guess a repro would involve creating two solutions and publishing a public NuGet package from one, setting up the same references in the other.  It might take me a while to find the time for that, but of course I understand the value of it.
The only issue I'm currently experiencing is the final one, which I think is described entirely by my previous comment.  While I see if I can get a repro together, is there nothing in there that might be a clue?

There are a lot of moving parts so it is hard to say what the real issue is just from your description.
[BadImageFormatException: Could not load file or assembly 'System.ComponentModel.Annotations' or one of its dependencies. Reference assemblies should not be loaded for execution. They can only be loaded in the Reflection-only loader context. (Exception from HRESULT: 0x80131058)

That to me says you are deploying the wrong version of this library. It looks like it is deploying the reference assembly instead of the implementation assembly. That assembly should not even need to be deployed as it ships inbox on .NET Framework.  If I were to guess the issue with System.ComponentModel.Annotations has nothing to do with the other System.ComponentModel.* assemblies as it is pretty isolated from them.

As I say, the NuGet package now targets both net451 and netstandard1.6.

You seem to be consuming a locally built nuget package does this issue still occur if you directly consume the binary?
If you can get a repro that you can share with your scenario then I can hunt this down but right now I'm still at a loss as to how to help because there are too many moving pieces.

Ok I understand, thanks.  The package is not locally built, it's built on travis-ci (linux/.net core/mono) and pushed to a private MyGet feed.  Looking in the nuget package and nuspec, neither target directly references System.ComponentModel at all, there's no mention of it and no binaries in the package.  (Only) the netstandard16 dll itself references System.ComponentModel <IP_ADDRESS>.  I don't understand why but the repro may help with that.
I was going to give up on .NET Standard stuff with this multi-targeting, but VS keeps using the netstandard16 version and not the net45 binary.  If I can beg one more question while I get a repro together - is there anyway to override/stop that behaviour?  A precedence to target selection?  Any docs for that?  Just trying to kick my project off before I get medieval on the repro :)

Yipee, I found a fairly minimal-case repro!
https://github.com/kierenj/dotnet-core-issue-730-repro
The folder structure is a little funky - I created a solution called whatever.sln and of course that created a subfolder called whatever.sln.  Either way, the case should be solid.
A breakdown:

NuGet package, targeting netstandard1.6
References <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.1.2" /> and uses RequiredAttribute (via using  System.ComponentModel.DataAnnotations;)
This causes the assembly to reference System.ComponentModel.Annotations <IP_ADDRESS>
NuGet package then published, and referenced by a .NET 4.6.1 project (MVC / Web API if that makes any difference)
Using reflection to get type/attribute info causes a TypeLoadException, that System.ComponentModel.Annotations cannot be found

The repro repo doesn't have a gitignore, in case looking at the packages folder would be useful.  Each commit documents the process, the errors I encountered on the way.
https://github.com/kierenj/dotnet-core-issue-730-repro/commits/master

In your web project install the "System.ComponentModel.Annotations" "4.3.0" nuget package, which should automatically cause your web.config to update to add the following binding redirect.
      <dependentAssembly>
        <assemblyIdentity name="System.ComponentModel.Annotations" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
      </dependentAssembly>

And also cause System.ComponentModel.Annotations.dll to be copied to your bin folder. Once that happens your web project works.
Let me know if that didn't fix your main project.

Thanks, that fixed it!  I'm unblocked and very happy, gives me a couple of days to pull a demo together for our client on Friday. :)
Should either the tooling or I added that as an explicit dependency on NuGet?

Should either the tooling or me have added that as an explicit dependency to the nuget project?

I think somewhere along the lines when if you installed the nuget packages via the UI it should have pulled this dependency, if you manually edited the packages.config file that might be why it didn't show up.
Future tooling will help flow these dependencies better. If you are able to it would be good to switch away from packages.config based projects and instead use the newer PackageReference items and that will help flow these dependent packages.
I'm going to close this issue now but feel free to ask further questions.

Thanks.  Just to make sure we're not missing a bug - I didn't edit packages.config, I used the VS2017 UI.
It's also a .NET 4.6.1 consuming project - not .NET standard/dotnet tooling.
With that in mind, should it have happened automatically?

Honestly I'm not entirely sure.
@emgarten any ideas why System.ComponentModel.Annotations package isn't correctly installed when installing https://www.nuget.org/packages/Repro110717.MainPackage/ into a net461 packages.config based project? It is in the package closure from https://www.nuget.org/packages/Microsoft.AspNetCore.Mvc.DataAnnotations/1.1.2. Perhaps there is some issue around the install picking the net451 dependencies instead of the netstandard1.6 dependencies but later we pick up the netstandard1.6 asset which is then missing this dependency.

HERE IS ONE SOLUTION:
If you get this message (like many other weird messages something can't be loaded or not found) during debugging in Visual Studio, so restart Visual Studio with Administrator privilegies - message will be gone. So it must be a bug somewhere.

i'm seeing this error in a 4.7.2 project.
[BadImageFormatException: Could not load file or assembly 'System.ComponentModel.Annotations' or one of its dependencies. Reference assemblies should not be loaded for execution.  They can only be loaded in the Reflection-only loader context. (Exception from HRESULT: 0x80131058)]

@Spongman it seems you are trying to load reference assembly at runtime. Reference assemblies contain only shape of types, but not code, that's why it fails.
Usually this is a result of some forceful copying of reference assemblies into project output.
Best option is to stop doing that.
If you think it is a bug in tooling, please create simple repro steps (ideally starting from new project) and we can route it further. Please create a new issue in such case. Thanks!


What is the difference between this sdk and the appengine sdk

I am sorry, but I don't seems to be able to find the answer anywhere on the internet.
But what is the difference between this sdk and the com.google.appengine.api.datastore sdk.
And which one is recommended to be used?
Best.

This is not an SDK at all. You may be asking in the wrong repo.


AttributeError: module 'tomotopy' has no attribute 'LDAModel'

Hi!
When I import Tomotopy and then try the print(tp.isa), I get an attribute error: "AttributeError: module 'tomotopy' has no attribute 'isa'"
I also get an attribute error when I try to run the model:  AttributeError: module 'tomotopy' has no attribute 'LDAModel'
I've unimported and reimported the package, but I'm not sure what else to do.
Thanks for your help!

Hello @AnnieKArmstrong,
It seems that tomotopy wasn't installed properly in your environment.
Could you share your os, python version, and command line you used to install tomotopy?


Is this supposed to read "React"?

This passage in the readme file has me a bit confused:

Usage with Inferno (through inferno-compat)
You can use Inferno components with create-inferno-app. All you have is to do is install inferno-compat (npm install --save inferno-compat) and Inferno and InfernoDOM will be already aliased to inferno-compat. After installing it you can import any Inferno dependent library or use any code that imports Inferno and that should work fine.

Why wouldn't create-inferno-app work with Inferno out of the box, and isn't inferno-compat meant for React?
Is this the result of an overzealous find/replace or am I missing something?

Is this the result of an overzealous find/replace or am I missing something?

Yeah, I think its just documentation error.

I almost skipped this library because of that statement.  'inferno-compat'? I thought.  'Won't that slow down the app?'

I fixed the doc.


Feature: add app extension so Textinator can be used on existing images

An app extension would allow Textinator to be used on existing images using the right-click context menu. Alternatively, Textinator could register a Service for use from Services menu.

I've implemented this as a Services menu so you can right click on one or more images in  Finder and select "Services > Detect text with Textinator".  Will release once I finish testing.

This is working well but notifications do not get triggered when the service provider class runs.  I'll need to look into this some more but it may be an issue with RUMPS.


switch from NettyChannelBuilder to ManagedChannelBuilder (#208)

Use ManagedChannelBuilder to replace NettyChannelBuilder, since the later is experimental. The ManagedChannelBuilder at runtime will load NettyChannelBuilder on all platforms except for Android, in which case OkHttpChannelBuilder will be used.

Codecov Report

Merging #215 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #215      +/-   ##
============================================
+ Coverage     70.25%   70.27%   +0.02%
  Complexity      483      483
============================================
  Files            67       67
  Lines          2538     2537       -1
  Branches        266      266
============================================
  Hits           1783     1783
+ Misses          657      656       -1
  Partials         98       98

Impacted Files
Coverage Δ
Complexity Δ

...gle/api/gax/grpc/InstantiatingChannelProvider.java
55.43% <0%> (+0.59%)
11 <0> (ø)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2e656...7f23198. Read the comment docs.

Have you run the tests in api-client-staging with this change?

@neozwu To run the staging tests with PR:

Locally build and install gax-java: ./gradlew clean install
Go to api-client-staging and switch the gax dependency to the local SNAPSHOT version:
https://github.com/googleapis/api-client-staging/blob/master/generated/java/build.gradle#L34
Run tests: ./gradlew test

Hope this helps! Please let me know if anything does not work for you.

@garrettjonesgoogle Testing against api-client-staging all passed. PTAL

LGTM


Skip autobumping helm if package contains RC

Signed-off-by: Itxaka<EMAIL_ADDRESS>

Doesn't affect CI, let's merge it


Protect DP keys with Key Vault

Fixes #5439
@blowdart Would you like to supply notes on which key storage strategy is best to use when? ... or is the goal here (for now anyway) to merely surface KV for DP key storage?

Just surface

Ok ... this is ready for :eyes: then.

Hi @guardrex thanks for working on this doco,
I've added the following code to my 2.1 RC1 project in the ConfigureServices function in my Startup.cs file and have an existing AKV resource in Azure with the appropriate keys in the config file (temporary measure);
services.AddDataProtection().SetApplicationName( "SomeAppName" + AppEnvironment ).ProtectKeysWithAzureKeyVault( "KeyName-KeyEncryption", Configuration["AzureKeyVault:ApplicationClientId"], Configuration["AzureKeyVault:AccountKey"] );
Not sure if it makes a difference, but I've included below my web host builder for Program.cs);
IWebHost host = WebHost.CreateDefaultBuilder( args )                                        .UseKestrel( options => {                                            options.AddServerHeader = false;                                            options.Listen( IPAddress.Loopback, 5000 );                                            options.Listen( IPAddress.Any, 5001, listenOptions => {                                                                listenOptions.UseHttps( "dev-cert.pfx",                                                                                "dev-cert-password");                                                            } );                                        } )                                        .UseConfiguration( config )                                        .UseContentRoot( Directory.GetCurrentDirectory() )                                        .UseIISIntegration()                                        .CaptureStartupErrors( true )                                        .UseSetting( "detailedErrors", "true" )                                        .UseStartup< Startup >()                                        .UseSetting( WebHostDefaults.ApplicationKey,                                                     "WebApp" )                                        .Build();                 host.Run();
But, upon starting the application, I've received the following error message on app startup;
Application startup exception: System.InvalidOperationException: The 'IXmlRepository' instance could not be found. When an 'IXmlEncryptor' instance is set, a corresponding 'IXmlRepository' instance must also be set.    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager..ctor(IOptions'1 keyManagementOptions, IActivator activator, ILoggerFactory loggerFactory) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType)    at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)    at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)    at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication() crit: Microsoft.AspNetCore.Hosting.Internal.WebHost[6]       Application startup exception System.InvalidOperationException: The 'IXmlRepository' instance could not be found. When an 'IXmlEncryptor' instance is set, a corresponding 'IXmlRepository' instance must also be set.    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager..ctor(IOptions 1 keyManagementOptions, IActivator activator, ILoggerFactory loggerFactory) --- End of stack trace from previous location where exception was thrown ---    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitSingleton(SingletonCallSite singletonCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor 2.VisitCallSite(IServiceCallSite callSite, TArgument argument)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)    at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType)    at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)    at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetService[T](IServiceProvider provider)    at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
Checking back over the current example in DataProtection/samples/AzureKeyVault/Program.cs, I added the .PersistKeysToFileSystem(new DirectoryInfo(".")) to the line which now is;
services.AddDataProtection().SetApplicationName( "SomeAppName" + AppEnvironment ).PersistKeysToFileSystem(new DirectoryInfo(".")).ProtectKeysWithAzureKeyVault( "KeyName-KeyEncryption", Configuration["AzureKeyVault:ApplicationClientId"], Configuration["AzureKeyVault:AccountKey"] );
I receive the following error message,
fail: Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider[48]       An error occurred while reading the key ring. System.UriFormatException: Invalid URI: The format of the URI could not be determined.    at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)    at System.Uri..ctor(String uriString, UriKind uriKind)    at Microsoft.Azure.KeyVault.ObjectIdentifier..ctor(String collection, String identifier)    at Microsoft.Azure.KeyVault.KeyVaultClientExtensions.WrapKeyAsync(IKeyVaultClient operations, String keyIdentifier, String algorithm, Byte[] key, CancellationToken cancellationToken)    at Microsoft.AspNetCore.DataProtection.AzureKeyVault.AzureKeyVaultXmlEncryptor.EncryptAsync(XElement plaintextElement)    at Microsoft.AspNetCore.DataProtection.AzureKeyVault.AzureKeyVaultXmlEncryptor.Encrypt(XElement plaintextElement)    at Microsoft.AspNetCore.DataProtection.XmlEncryption.XmlEncryptionExtensions.EncryptIfNecessary(IXmlEncryptor encryptor, XElement element)    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.IInternalXmlKeyManager.CreateNewKey(Guid keyId, DateTimeOffset creationDate, DateTimeOffset activationDate, DateTimeOffset expirationDate)    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.CreateNewKey(DateTimeOffset activationDate, DateTimeOffset expirationDate)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.CreateCacheableKeyRingCore(DateTimeOffset now, IKey keyJustAdded)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.ICacheableKeyRingProvider.GetCacheableKeyRing(DateTimeOffset now)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.GetCurrentKeyRingCore(DateTime utcNow) info: Microsoft.AspNetCore.DataProtection.Internal.DataProtectionStartupFilter[0]       Key ring failed to load during application startup. System.UriFormatException: Invalid URI: The format of the URI could not be determined.    at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)    at System.Uri..ctor(String uriString, UriKind uriKind)    at Microsoft.Azure.KeyVault.ObjectIdentifier..ctor(String collection, String identifier)    at Microsoft.Azure.KeyVault.KeyVaultClientExtensions.WrapKeyAsync(IKeyVaultClient operations, String keyIdentifier, String algorithm, Byte[] key, CancellationToken cancellationToken)    at Microsoft.AspNetCore.DataProtection.AzureKeyVault.AzureKeyVaultXmlEncryptor.EncryptAsync(XElement plaintextElement)    at Microsoft.AspNetCore.DataProtection.AzureKeyVault.AzureKeyVaultXmlEncryptor.Encrypt(XElement plaintextElement)    at Microsoft.AspNetCore.DataProtection.XmlEncryption.XmlEncryptionExtensions.EncryptIfNecessary(IXmlEncryptor encryptor, XElement element)    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.IInternalXmlKeyManager.CreateNewKey(Guid keyId, DateTimeOffset creationDate, DateTimeOffset activationDate, DateTimeOffset expirationDate)    at Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager.CreateNewKey(DateTimeOffset activationDate, DateTimeOffset expirationDate)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.CreateCacheableKeyRingCore(DateTimeOffset now, IKey keyJustAdded)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.Microsoft.AspNetCore.DataProtection.KeyManagement.Internal.ICacheableKeyRingProvider.GetCacheableKeyRing(DateTimeOffset now)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.GetCurrentKeyRingCore(DateTime utcNow)    at Microsoft.AspNetCore.DataProtection.KeyManagement.KeyRingProvider.GetCurrentKeyRing()    at Microsoft.AspNetCore.DataProtection.Internal.DataProtectionStartupFilter.Configure(Action 1 next)
Thanks for any help, Boz.

@pakrym @blowdart Can u help @aaron-bozit :point_up: ... and I'll react with a doc update if needed.

In ProtectKeysWithAzureKeyVault KeyId is the full key URI like in https://pakrymkeyvault.vault.azure.net/keys/dataprotection/

Thanks @pakrym ... I'll update the PR to reflect that requirement.

Yes, you need to set location because setting encryptor disables automatic data protection settings entirely.
I think For keyvault it would be more appropriate to show blob as persistence location.
@blowdart, what do you think ?

... or Redis I suppose. https://docs.microsoft.com/aspnet/core/security/data-protection/implementation/key-storage-providers#azure-and-redis

Try the latest update, which surfaces the additional information.

May as well go for blob storage, as least it's persistent with no additional work :)

Do I need anything else here?

@scottaddie ty ... got 'um. :+1:

Anything else from engineering on this one?

Bueller? ... Bueller? .............. Bueller? - Economics Teacher (Ben Stein)
Ferris Bueller's Day Off Copyright 1986 Paramount Pictures

Just want to say, I haven't forgotten the help, just been busy with some study.
Thanks all, it seems to be working well, just a quick question (though might belong elsewhere) is there a behavior with this functionality to automatically create a key in the key vault if none exists?
And, I can see that if the key expires and a new key's in the vault it pulls that key 👍
Thanks again.


Incorrect syntax highlighting for bash

VSCode Version:
OS Version:

Steps to Reproduce:

Paste below code

#!/bin/bash -e
export VAR=`python - <<EOF
print("aaaa")
EOF`

echo "test"

Select language mode to "Shell Script (Bash)"

Bug:
echo "test" has incorrect syntax highlighting

This issue was moved to atom/language-shellscript#89


supoprt weight?

Still reading the paper and I'm wondering how does weights work with this algorithm, for two reasons:

The data in HEP has weights (so I assume the paper address it some how)
I want to use this algorithm for re-binning rather than just binning on raw data

elaborate the point 2 a bit, often the raw data is >> RAM, the best I can do is to first make a really fine-binning histogram, then re-bin it

https://github.com/scikit-hep/hepstats/blob/master/src/hepstats/modeling/bayesian_blocks.py

this https://github.com/francescoalemanno/BayesHistogram.jl/commit/8dedd5cbaec126bb915f17b76b20e70b879c700a should solve it :)

@Moelf let me know if the version with weights works out for you

I wonder if we should import tests from scikit hepstats, or did you already run these numbers over there and that's how you obtained the reference?

The ref are self-generated, they are there to allow easy refactoring of code.
Importing tests from scikit-hepstats is an excellent idea, but unfortunately I cannot do it myself at this time...
Would you do it? I would gladly review/accept any PR

yeah I can do it, the idea is simple, run our numbers there and see if we get back the same results.
I surely don't want to import npy object...

Ty Jerry!
maybe the only obstacle is the fact that BayesHistogram.jl has a resolution parameter and a mincounts parameter while Scikit-hep does not it seems...

closing this issue, since weights are now supported.
@Moelf : by the way, it would be quite easy to write a small wrapper within FHist to use the function within this package and return a type which is coherent with FHist API.


Warning in install.packages (R version 3.1.2)

install.packages("readxl")
Warning in install.packages :
package ‘readxl’ is not available (for R version 3.1.2)

The mac cran builder is a bit slow, so you might have to wait a couple of days.


Update version of firely SDK for R4 standard

Hi all,
I've just noticed that the version used for the FHIR R4 standard is relatively old, version 3.4.0 released nearly a year ago. I'm wondering if it would be beneficial to look into updating this version? Since release, quite a few issues have been closed, so it might be beneficial to update this.
An initial check I've run is to update the version to the most recent v.4.0.0 and running the R4.Core.UnitTests and R4.Core.FunctionalTests tests. The following tests fail:

Several AttributeValidatorTests in the R4.Core.UnitTests fail due to updated firely error messages.
GivenAStu3OnlyResource_WhenAnonymizing_ExceptionShouldBeThrown(testFile: "Stu3OnlyResource/ProcessResponse.json", ResourceName: "ProcessResponse") fails due to a failure to throw an exception. I assume the Firely SDK now handles the previous situation that caused an exception.
GivenAStu3OnlyResource_WhenAnonymizing_ExceptionShouldBeThrown(testFile: "Stu3OnlyResource/ProcessRequest.json", ResourceName: "ProcessRequest") fails due to a failure to throw an exception. I assume the Firely SDK now handles the previous situation that caused an exception.

The test failure due to changed error messages is a relatively quick fix. The GivenAStu3OnlyResource_WhenAnonymizing_ExceptionShouldBeThrown failures would have to be research to understand how the Stu3OnlyResource is handled in the updated firely SDK.
What do you think? If this is a benefit, I could create a PR for it. Seems like relatively little work to get the latest/greatest.

Just an update: after looking further into it, the trickier of the failing unit tests is 2. and 3. in the list of failing tests in my original post. It seems that no exceptions are thrown on type casting the Stu3 resources ProcessResponse and ProcessRequest when parsing the json to TypedElement within the AnonymizeJson method of the AnonymizerEngine.
I don't know how this can be, as the R4 standard continues to not contain definitions for these resources, as far as I can tell. Interestingly, the test passes for the DeviceComponent.json file, meaning that the library cannot parse this json into an appropriate class object. Perhaps in the newest release, definitions for these resources have somehow landed in the R4 standard, when technically they are not defined. I'll continue to look into this, but any help or suggestions would be appreciated!

Further Update:
I've asked the firely devs in the git repo about this topic. Hopefully there will be an answer sooner than later!
https://github.com/FirelyTeam/firely-net-sdk/issues/2147


Set up coveralls

I want to set up coveralls for this repo.
Currently at https://coveralls.io/repos/new it has been saying "synching repos with Github" for over an hour ... will try again some time in the future...

@ejeschke @bmorris3 @jberlanga We now have Coveralls activated for the astroplan repo.
The way this works is that travis-ci runs python setup.py test --coverage and then posts the html coverage report to Coveralls:
https://travis-ci.org/astroplanners/astroplan/jobs/60377593#L492
https://coveralls.io/builds/2479267
The coverage in % is mentioned on a badge in the README and you can click on it to see the latest coverage report:
https://github.com/astroplanners/astroplan
Coveralls also comments on pull requests (PRs), with a link to the coverage report for that PR.
Now this can be a bit annoying, but I'd like us to give it at least a try and if we don't like it we can turn that off.
Now all that line coverage does is show which lines are executed at least once by the tests. I.e. it's a quick way to find if / else clauses or whole functions or files that are completely untested. Not more, not less.


Debugging support for multi-memory Wasm (DWARF)

Wasmtime currently generate native DWARF based on the assumption that Wasm module has at most one memory. Beside support of multi-memory addressing in the WebAssemby DWARF spec itself, we need to fix the translation for native DWARF:

[ ] Spec for multi-memory address location
[ ] Fix DWARF translation

[ ] in debug_builtins (see #1482)
[ ] in utils.rs add_internal_types to generate proper WasmtimeVMContext

Try to spec at https://github.com/yurydelendik/webassembly-dwarf/issues/10


[BUG] Multi-Agent Swarm for Logistics

In colab, without an image file uploaded.
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:56.107112+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.554826+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.967989+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:56.976875+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:57.433397+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:57.854453+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:58.353338+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:58.362766+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:59.192636+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:59.678470+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:11:00.045673+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:11:00.053300+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

In colab, without an image file uploaded.
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:56.107112+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.554826+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.967989+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:56.976875+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:57.433397+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:57.854453+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:58.353338+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:58.362766+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:59.192636+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:59.678470+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:11:00.045673+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:11:00.053300+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

We updated the OpenAI API in the logistics example to use gpt-4o-mini and accept an image URL as input instead of relying on the deprecated VisionAPI or local image uploads. With this change, the logistics example now works as expected.
However, there is a caveat: some agents in the flow occasionally fail to process the image URL, despite the overall setup being consistent. A potential solution is to increase the max_loops value for each agent to allow additional attempts at processing the input, which may improve reliability and reduce the occurrence of these random failures.

In colab, without an image file uploaded.
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:56.107112+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.554826+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:56.967989+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:56.976875+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:57.433397+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:57.854453+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:58.353338+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:10:58.362766+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Image file not found: factory_image1.jpg
2024-06-25T01:10:59.192636+0000 Attempt 1: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:10:59.678470+0000 Attempt 2: Error generating response: 'choices'
Error with the request: 'choices'
Image file not found: factory_image1.jpg
2024-06-25T01:11:00.045673+0000 Attempt 3: Error generating response: 'choices'
2024-06-25T01:11:00.053300+0000 Failed to generate a valid response after retry attempts.
Error with the request: 'choices'
Initializing Autonomous Agent swarm-worker-01...
Autonomous Agent Activated.
All systems operational. Executing task...

Loop 1 of 1

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

I updated the OpenAI API in the logistics example to use gpt-4o-mini and accept an image URL as input instead of relying on the deprecated VisionAPI or local image uploads. With this change, the logistics example now works as expected.
However, there is a caveat: some agents in the flow occasionally fail to process the image URL, despite the overall setup being consistent. A potential solution is to increase the max_loops value for each agent to allow additional attempts at processing the input, which may improve reliability and reduce the occurrence of these random failures.


[cairo] Add pkgconfig file

[cairo] Add pkgconfig file

What does your PR fix? Fixes add .pc file

Which triplets are supported/not supported? Have you updated the CI baseline?

x86-windows, x64-windows, x64-linux-dynamic

Does your PR follow the maintainer guide?

LGTM now, thanks for your PR @kwiechen.

can be closed. Cairo with #13100 uses its native build system and install PC files

Thanks for your information @Neumann-A.


Is there a side effect if I remove the formlySelectOptions from the select component?

Question
I'm using the kendo select and multiselect, but I want the select to store the complete object from the options observable, I have scenarios where I use other properties from the object, for example I have an object with Id, Description and Price, and when I select it should show the price in another field.
<kendo-dropdownlist       [class.k-state-invalid]="showError"       [formControl]="formControl"       [formlyAttributes]="field"       [data]="to.options | async"       [textField]="to.labelProp"       [valueField]="to.ValueProp"       [valuePrimitive]="to.primitive"       (valueChange)="to.change && to.change(field, $event)"     >     </kendo-dropdownlist>
What side effects should I expect by doing this?
I already use the kendo in other projects both to primitive and not primitive value, and I never had problem.

No side effects, it a helper that simplifies dealing with options in your template (an observable or an array of items) by transforming them into the following signature Observable<ISelectOption[]>.
interface ISelectOption {
  label: string;
  disabled?: boolean;
  value?: any;
  group?: ISelectOption[];
}

Thanks