macaddrsetup: fix build on Android 7

Android 7's build system doesn't contain math_gt_or_eq, thus any
reference to it returns false. Replace the use of it with a simple
filter for API level 25 - 28.

In that case I'd consider submitting the change against the n-mr1 branch and not master.

It's pretty funky that the
ifneq ($(call math_gt_or_eq, $(PLATFORM_SDK_VERSION), 29),)

above wasn't replaced either.
Since we have branches specific to every Android version already I suggest to just remove this abomination and ask @jerpelea to reorder the commits in such a way that 9654012 is gone and b10cfba is only reachable for Q and R/master.
If we intend to use master on all Android versions instead (like it is now, all branches point to the same commit) these version-specific branches should be removed. Then one might as well specify:
on property:ro.wifi.addr_path=*
    setprop ro.vendor.wifi.addr_path ${ro.wifi.addr_path}

Though I don't know if future Android versions will disallow vendor initrc scripts from touching "unknown" non-vendored properties entirely.

@MarijnS95 The use of math_gt_or_eq above isn't replaced because it rightly fails on Android 7, and correctly return false on Android 8, 8.1, 9.
Any update on this?


Separator with long text doesn't wrap text

react-native, react and native-base version
react-native 0.55.4
react 16.0.0
native-base 2.4.4
Expected behaviour
In a  with long text inside, the text should wrap and show in multiple lines
Actual behaviour
In a  with long text inside, the text doesn't wrap
Code
 <Separator  style={{flex:1}} bordered>
      <Text style={{flex:1}}>{this.props.title.toUpperCase()}</Text>
 </Separator>

(I tried with and without styles)

@nbastoWM Did you try?

It worked! Thank you.


cmake: support find_package(psimd)

Adds a CMake configuration file to make it possible for CMake-based projects to use find_package to consume this library.

@Maratyszcza if you have the time, would you mind reviewing this?


Unmanaged Solution (Zip file)

[Enter feedback here]
When following the link to the releases, the unmanaged solution download link presents the unmanaged solution wrapped in an additional zip file - this is confusing (and unnecessary?) - I tried to install the outer zip file (which isn't a valid solution) - you could just link the unmanaged solution zip file directly (as you do for the manged solution) to be consistent and avoid confusing us all.
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ee63401b-aa17-8a86-89f5-12c297570e2b
Version Independent ID: ee63401b-aa17-8a86-89f5-12c297570e2b
Content: Setup of the business approvals kit - Power Automate
Content Source: articles/guidance/business-approvals-templates/setup.md
Service: power-automate
Sub-service: guidance
GitHub Login: @Grant-Archibald-MS
Microsoft Alias: grarchib

Thanks @iddycol for reporting the issue. I will add this as an issue for us to track so that we can update the next release so that the unmanaged solution can be revise to make the import process easier.

Added in https://github.com/microsoft/powercat-business-approvals-kit/issues/139 for tracking


What is this meaning?

When I running 'fairseq-score', returning
BLEU4 = 76.27  90.4/80.8/72.1/64.3 (BP=1.000, ratio=1.000, syslen=52927, reflen=52942)
I understand BLEU4 is bleu score, what is '90.4/80.8/72.1/64.3' this meaning?
It is True Positive? or some else?

and how to get precision, recall, f1score?

and how to get precision, recall, f1score?

You can find details about each metric here

You can find details about each metric here


New exercise: High Scores

This is part of the rearrangement of the track.
One of the things missing is an easy exercise with an array as a list and some list manipulations.
The Problem Specification PR is here:  https://github.com/exercism/problem-specifications/pull/1378
This High Scores exercise is meant to be a core exercise
TwoFer -> Acronym ->  Isogram -> High Scores  -> Matrix -> ...
As we want to test drive, it's added here as a side exercise first.
This exercise is also going to be the first core in the track where the students have to instantiate a class and work with multiple methods. We paid extra attention to the sequence of the tests, so the code is building up nicely, and at the end there should be some nice mentoring opportunities left.
Thanks to @pgaspar, who took care of the implementation.  🙇

OK, I've left some feedback, most of it is fairly minor and this is certainly mergeable as is :star:
Also see my comments in the https://github.com/exercism/problem-specifications/pull/1378 PR.
Do you want to get this PR merged ASAP or are you happy to wait a week or so for the problem-specifications PR to go through?

@Insti heads up that I'm planning on squashing these commits before we merge.

YAY!

And after merging I found this in the docs:

Reference the PR in problem-specifications if it hasn't been merged yet, this must not be merged until the exercism/problem-specifications PR is merged.

Should I reverse the merge?  @Insti, do you know?
cc @pgaspar

@F3PiX I saw that before too but forgot to ask @Insti about it.
From my limited testing we should be good. It just means that anyone trying to generate the tests for the whole track will see this at the end of the output:
Broken generators: (Run these individually to see the error raised.)

high-scores

It doesn't block the other generators from running and it doesn't change our existing tests. @Insti will know better though.

@pgaspar that sounds about right.
I'm trying to remember if there was some other reason but I think It's mostly so the generator works correctly and will have the correct version information.
I think it's not going to be a problem in this case.

Thanks for your work on this @F3PiX and @pgaspar :heart:

Thanks for your support @Insti :-)) Much appreciated.


We should study how other pages do mobile footers, sketch out some of our own ideas, and then prototype!

This is what we were talking about in today's ML meeting @higherdefender.

Thanks for doing this. I certainly did not intend for us to only look at academic websites to inform our designs--indeed, I think it's best to look outwards at professionally designed sites for guidance. I do want a footer.
Can you find ~10 more examples from professional sites. Maybe try etsy.com, dribbble.com, and other design'y sites.

On it.
On Wed, Oct 17, 2018 at 10:28 AM Jon Froehlich<EMAIL_ADDRESS>wrote:

Thanks for doing this. I certainly did not intend for us to only look at
academic websites to inform our designs--indeed, I think it's best to look
outwards at professionally designed sites for guidance. I do want a footer.
Can you find ~10 more examples from professional sites. Maybe try etsy.com,
dribbble.com, and other design'y sites.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jonfroehlich/makeabilitylabwebsite/issues/571#issuecomment-430717325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALGPLxRRWyzYs9j-GEX00fPlWH_pAAxWks5ul2iigaJpZM4WCPQr
.

I explored this a bit today. Of the sites I visited, I like the UW CSE footer the best. I'll try to design a mockup soon.

Here are two mocks. Any opinions? I cut the Recent News part (available on full screen views) as I think it unnecessary for smartphone footer. @EdigaHe, any thoughts? @higherdefender, can you implement this? I like the one on the left best.

Oops, accidentally closed.

@higherdefender has been working on this.

@higherdefender did a nice job on this in https://github.com/jonfroehlich/makeabilitylabwebsite/pull/690. Here's the animated gif of the final solution. Note that the affiliation bar on the bottom (black banner) still needs to be fixed.


HWKBTM-292 Upgrade to hawkular accounts 2.0.11.Final using feature pa…

…cks, and parent 33

Thanks for the help on this, Juca.


Respect XDG Base Directory Specification

Please do not write to ~/.quint: https://github.com/informalsystems/quint/blob/d3c5f476808cbe87eeffa2d31a76e27ab7b9ea34/quint/src/quintVerifier.ts#L52-L54
That should be $XDG_CONFIG_HOME/.quint. Refer to https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
There's probably a library you can use...

This is a good pointer, and I agree we should strive to be good citizens on this kind of thing. Thanks for raising the issue!

We can look at

https://www.npmjs.com/package/xdg-portable
https://github.com/sindresorhus/xdg-basedir

We should fix this, but we don't need it to close our milestone.


Fix PR#11

fix unsafe problem on #11 .
Note: i did try cargo test on my macbook pro.

BTW: would you want/like/mind being included in a list of contributors to the project?

I don't mind this :)


Mobile Gathering Doesn't Appear to Work

DarkCodex 1.5.23
Kineticist [Psychokineticist] Level 7; Infusion Specialization 2 + Mobile Gathering
Steps to Reproduce:

Click Mobile Gathering [Move] ability
The screen flashes black for a second, but then shows the kineticist with swirling energy around her as if she gathered
Move up to before point where it would use the standard action
Enabled Empowered Metakinesis
Both regular and extended range show a cost of 1 as if I hadn't gathered power
Click to use blast, shows accepting 1 Burn (and increments burn count)

I tested it. No black flash and the cost is calculated correctly. Either your setup is more complex or you have both "Patch: True Gather Power Level" disabled AND not set your gather power level toggle to whatever you want.


Add RK3 unit test

Hopefully Appeveyor will work out of the box now.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9b6adbd). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master    #14   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      2
  Lines             ?      4
  Branches          ?      0
=======================================
  Hits              ?      4
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ

src/JULES.jl
100% <ø> (ø)

src/time_steppers.jl
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6adbd...963bcd2. Read the comment docs.

💯 code coverage for the first time in my life

Good point. I went with test_time_steppers.jl which seems pretty clear.
Unfortunately @RaphaelRR has been committing to master so we've lost our 100% coverage lol.


Use Rc instead of String

Fixes #39

Okay, I've looked through the changes, all looks reasonable. Do you think for code clarity we should maybe have
type Name = Rc<str>

in term.rs? afaict we're really just using ref-counted strings to track immutable names in the parser and checker and having name: Name seems slightly better than name: Rc<str> everywhere.

Sure, I can make that change.


Keep having to run . ./export.sh (IDFGH-3133)

System: macOS Catalina 10.15.1
Shell: zsh
Issue: I get this:
zsh: command not found: idf.py
Unless I cd to ~/esp/esp-idf and . ./export.sh every new terminal session.
My ~/.zprofile contains export IDF_PATH=~/esp/esp-idf

@sambilbow This looks like expected behavior: export.sh needs to be sourced into every terminal session where you intend to use IDF. One option to make this easier is to create an alias in your .zprofile file, e.g. alias get_idf=". $HOME/esp/esp-idf/export.sh". Then you can type get_idf in the new terminal session instead of typing the full path.

Brilliant, thanks Ivan


Improvement:  minio (aws s3 alternative) Support

minio is alternative AWS s3.
we can use minio via aws-sdk(growi is using)
https://github.com/minio/cookbook/blob/master/docs/aws-sdk-for-javascript-with-minio.md
but some parameter design is not compatible with minio.
so I offer to support file upload function with minio.
Environment
Host

item
version

OS
ubuntu 16.04

GROWI
3.2.4

node.js
x.y.z

npm
x.y.z

Using Docker
yes

Using growi-docker-compose
yes

(Accessing https://{GROWI_HOST}/admin helps you to fill in above versions)
Client

item
version

OS
Windows

browser
Chrome 71.0

How to reproduce? (再現手順)

launch minio server
edit docker-compose.yml environment like minio page

What happens? (症状)

endpoint parameter not supported

What is the expected result? (期待される動作)

add endpoint parameter
remove region parameter

Note

@ktakeuchi Thank you for your suggestion.
We'll consider it, but I do not have much demand for it, the priority may be low.

I would like to suggest Google Cloud Storage (GCS) support.

fixed by #1138


fix: Detailed History disabled by default. Set version to 2.3.0

Detailed History no longer loaded by default.
The detailed History, shown on hover, has been replaced with a version that doesn't need any additional request.
Detailed history can be re-enabled with the 'enableDetailedHistory' key set to true.
Update version to 2.3.0

Issue solved


Add --sync to gitpod and dev docs

Otherwise, ./tea fails with
error: pantry not found: /home/gitpod/.tea/tea.xyz/var/pantry/projects

tea syncs itself for no pantry in most situations (this is very new behavior, so maybe you have an older tea?)
What command were you running that didn't work?

@mxcl just opened the project in Gitpod.
.deno/bin/deno task compile
./tea node --version

maybe I screwed up the code to do this, let me check.

this is fixed with 0.39.5, --sync should occur automatically if the pantry is absent.


Manage Owner of groups through Az CLI

Would be really convenient for Az CLI or Linux users to implement this feature request.
Same feature that could be done through the PowerShell module « azuread version <IP_ADDRESS>», associated « how to » is available here : https://docs.microsoft.com/en-us/azure/active-directory/users-groups-roles/groups-settings-v2-cmdlets#manage-owners-of-groups

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c659a298-8897-6d50-c1d9-c14a3b0e6364
Version Independent ID: 2d2bec5b-ef92-f65f-bfd0-ccdabda52a41
Content: az ad group member
Content Source: src/command_modules/azure-cli-role/azure/cli/command_modules/role/_help.py
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Not sure that it’s the good place, I have also added a feature request on the Azure Voice here : https://feedback.azure.com/forums/169401-azure-active-directory/suggestions/34835497-manage-owner-of-groups-through-az-cli

Just adding 2 cent context. This would be very useful for one of my client where we build apps environment As Code where AD group access are created and assigned to AzureRm roles on our resources.
When this is done we set manually an owner of the group (this is the painfull action part) and this person just have to add it’s team members to groups to inherit to the assigned privileges of this group.

@yugangw-msft are you familiar with these PS commands?

Yes, I know the PS cmdlet. Ownership management is the area with good amount of user voices, and we have discussed with AAD graph team for a while to have this gap filled. This work would have to start from swagger spec
Closing this, as #5651 was opened for the same ask.


fix: removed state logic from issue table, issues change is now handl…

Hello 🍉
In this PR I changed the handling of issue states from the useState to a simple http request that will re-fetch the issues already sorted from the database after Patching the modified one.
Also while removing and moving different states between component I moved the one that handles the open or closed state of the select status, this way after changing an issue status the popover will close.
Please review before I merge :)

Good 👍🏻


AWS::ApplicationAutoScaling::ScalingPolicy.PredefinedMetricSpecification.PredefinedMetricType AllowedValues expansion

https://github.com/aws-cloudformation/cfn-python-lint/issues/50
AWS::ApplicationAutoScaling::ScalingPolicy.PredefinedMetricSpecification.PredefinedMetricType
reviewing all AllowedValues lists with 6 or more values and expanding ones that look like they might be missing values

wasn't sure why there were so many other AllowedValues not in the documentation, so I figured I'd leave them to be safe

wasn't sure why there were so many other AllowedValues not in the documentation, so I figured I'd leave them to be safe

mixed up AWS::AutoScaling::ScalingPolicy.PredefinedMetricSpecification.PredefinedMetricType and AWS::ApplicationAutoScaling::ScalingPolicy.PredefinedMetricSpecification.PredefinedMetricType


Limechain/16xx

Description
Small fixes to  few issues described in the sections below.
Related issues

Fixes #1601, #1602, #1605, #1606

Please include any additional tickets you've addressed in the PR description


Footer Section Issue in fonts and space

Watch the video:

Awesome GitHub Profile READMEs - Google Chrome - 8 October 2024 - Watch Video

Can I work on this issue?

can you assign me this


Use custom neutral spawners for CH3

The entire current logic can be removed when we use our own neutral spawners, so I wouldn't want to merge this yet. (Since we are the ones detecting whether a successful stack happened, we don't need any neutral detection anymore and we can get rid of all the special logic too).

The current system works and gets data from the reliable spawning system, I don't think it's worth it remake it again. At least that was my idea

The point of using CreateUnit was to get rid of the old system. Then we can get rid of unreliable hacks like these and many more.


Avoid to persist datasource implementation YAML in registry center

Fixes #1395.
Changes proposed in this pull request:

[x] Remove DataSourceParameter from orchestration module.
[x] Make sharding and masterSlave stored consistently in orchestration.
[x] Make jdbc and proxy stored consistently in orchestration.
[x] Delete YamlRuleConfiguration.
[x] Delete ProxyDisabledStateEventBusEvent.
[x] Fix the bug that authentication configuration is not watched.
[x] Fix the bug that when read configuration from registry, orchestrationFacade can not be initialized well.
[x] Fix the bug that when update one certain schema, proxy will clear all schemas.
[x] Revoke the API of meta for shardingSchema

Pull Request Test Coverage Report for Build 5483

26 of 77 (33.77%)  changed or added relevant lines in 12 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.7%) to 67.833%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-jdbc/sharding-jdbc-orchestration/src/main/java/io/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationMasterSlaveDataSource.java
8
9
88.89%

sharding-jdbc/sharding-jdbc-orchestration/src/main/java/io/shardingsphere/shardingjdbc/orchestration/internal/datasource/OrchestrationShardingDataSource.java
6
7
85.71%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/rule/OrchestrationMasterSlaveRule.java
0
1
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/state/datasource/DataSourceService.java
0
3
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/config/ConfigurationListenerManager.java
0
4
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/listener/ListenerFactory.java
0
4
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/OrchestrationFacade.java
0
7
0.0%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/Bootstrap.java
0
8
0.0%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/runtime/ShardingSchema.java
0
8
0.0%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/runtime/GlobalRegistry.java
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/runtime/ShardingSchema.java
1
0.0%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/config/ConfigurationListenerManager.java
1
0.0%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/runtime/GlobalRegistry.java
1
10.77%

sharding-orchestration/sharding-orchestration-core/src/main/java/io/shardingsphere/orchestration/internal/listener/ListenerFactory.java
1
0.0%

Totals

Change from base Build 5481:
0.7%

Covered Lines:
7579

Relevant Lines:
11173

💛  - Coveralls


Missing $_GET['q']

This is required by code that needs the path before full bootstrap. Code that runs after full bootstrap can use current_path() instead.

This was auto-closed by #112 but we should ensure the global is set as well.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #11.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #11

@conda-forge-admin, please re-render.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks!

Interestingly, the merge created no CI run. Should be fine though...

Yeah this seems to happen sometimes ( https://github.com/conda-forge/conda-forge.github.io/issues/1082 ). Not sure why though


feat: add graph for historical data

Adds a graph on each PR comment displaying historical data for each metric.

We can consider using an external dependency for drawing the Graph, but not a blocker.
I found https://github.com/kroitor/asciichart and https://github.com/stephan83/babar but haven't tried any of them.

I did look at a bunch of libraries, but none of them did exactly what I wanted, so I ended up building my own. 🤓
Happy to revisit though, or to extract this logic into its own package once we're happy with what it's doing.


Messages.po not filled by bash ./i18n.sh

index.php
<html>
<body>
<h1>_('Hello World')</h1>
</body>
</html>

Structure:

index.php
locale
-- en
--- LC_MESSAGES
---- messages.po
-- nl
--- LC_MESSAGES
---- messages.po
-- fr
--- LC_MESSAGES
---- messages.po

➜  testlocales ls
composer.json composer.lock index.php     locale        vendor
➜  testlocales cd vendor/delight-im/i18n
➜  i18n bash ./i18n.sh NL
Extracting and updating translations
sed: 1: "locale/messages.pot": extra characters at the end of l command

I might be misinterpreting the functionality, but I was expecting 'hello world' to appear in the NL messages.po.

Thanks for your question and the perfect description of the problem!
The cause of this issue is that i18n.sh must be at the root of your project, at the same level as, or higher than, all your PHP source files. I see that this is not documented.
In order to solve the issue, you would thus have to replace your regular
cd vendor/delight-im/i18n

with a one-time
cp vendor/delight-im/i18n/i18n.sh .

to copy the script to your project’s root folder. But I understand that this may be undesirable, because it duplicates code and may force you to include the script in your project’s .gitignore – which would also force you to repeat the step of copying the script on every new machine.
Does that help?
Apart from that quick fix, the script certainly needs a parameter to specify which directory it should operate on.

Yes, progress.
I now see new text variables defined in index.php appear in a new locale/messages.pot file.
It doesn't make a difference if I do ./18n.sh nl-BEor ./18n.sh nl.

I found the fix (for me). I removed the double quotes on lines 18, 23, 28, 46, 53

Had to fix some more stuff. This is the script I ended up with.

Notice removal of double qoutes around variables with strings
Notice the explicit sed expression '' (see above)
Notice mkdir -p (--parent doesn't exist on macOS)
Notice commented lines for sed replace - I don't know how to fix this.
sed: 1: "0,/\"Content-Type: text ...": bad flag in substitute command: '}'

Thanks for looking into this!

Regarding the sed problem, the issue is that GNU sed (Linux) only supports sed -i and sed -i'', while BSD sed (macOS) only supports sed -i ''. There’s no way to make the syntax compatible with both standards.
What we could do is use sed -i.bak and then remove the unneeded backup file, either after every call or once at the end.
Another solution would be using sed on "$file" without the -i argument, redirecting the output to "$file.temp" every time, and renaming "$file.temp" to "$file" after every call, as with mv -- "$file.new" "$file".

As for the “bad flag in substitute command” error, that’s because the syntax sed '0,/foo/{s/foo/bar/}' (to replace the first occurrence only) is specific to GNU sed as well. We would need a replacement that works on both systems.

As for the removal of double qoutes around variables with strings, is that really necessary? Did you verify that it does not work without that (and only with the other solutions)?

Replacing mkdir -p with mkdir --parents – sure, that would be fine.

An alternative solution for (1) and (2) would be to install GNU sed on macOS, e.g. via Homebrew (brew install gnu-sed).

1+2: Completely OK with gnu-sed.
3: Just tested again after installing gnu-sed, no issues.
4. Yey!


Enhance apm-webapp log

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[x] Feature or performance improvement

Requirement or improvement

Enhance apm-webapp log. Redirect log to a rotating file.

I hope this feature could be a part of #843


feat(@jest/environment): allow jest.mock and jest.doMock to take a type argument

Summary
Similar to #13253. Type arguments could be passed to jest.mock and jest.doMock as well. This helps to keep the module factory typed.
Test plan
Type tests are added.

https://github.com/facebook/jest/releases/tag/v29.1.0


Introduce Optimistic updates for mutations

The problem: in most cases the result of mutations are well known even before waiting for server response. The idea behind optimistic updates are pretty straight forward, to be able specify optimisticResponse for mutation operation that will be temporary saved into memory cache before network response arrives.
Proposal: introduce the layer that is basically separate instance of ApolloStore for optimistic updates only and that based on mem cache. Any queries that try to read response from cache will first hit ApolloStore with optimistic updates and if it can't resolve cache response then  will hit regular ApolloStore with normalized cache. The rollback mechanism for optimistic updates should remove them in case if mutation succeed or failed.
http://dev.apollodata.com/react/mutations.html#optimistic-ui
https://dev-blog.apollodata.com/mutations-and-optimistic-ui-in-apollo-client-517eacee8fb0

@BenSchwab @digitalbuddha @martijnwalraven I'm going to start working on this feature so if you have any thoughts, comments pls share

I was thinking of a similar approach! Sgtm


Error on compile

I am getting error on compile app with great_list_view.
[+8433 ms] ../../.pub-cache/hosted/pub.dartlang.org/great_list_view-0.1.4/lib/src/dispatcher.dart:160:32: Error: Expected 6 type arguments.
[        ]       _cancelable = Executor().execute<T, T, AnimatedListDiffBaseComparator<T>,
[        ]                                ^
[+2765 ms] ../../.pub-cache/hosted/pub.dartlang.org/great_list_view-0.1.4/lib/src/dispatcher.dart:160:32: Error: Expected 6 type arguments.
[        ]       _cancelable = Executor().execute<T, T, AnimatedListDiffBaseComparator<T>,
[        ]                                ^

flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.3, on Ubuntu 22.04.1 LTS 5.15.0-48-generic, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2021.3)
[✓] VS Code
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

Seems related to new work_manager package.

I have the exact same problem.
Here is the workaround I use for the moment (thanks @rupinderjeet) :
In pubspec.yaml, here is what I do:
dependencies:
  great_list_view:
    git:
      url: https://github.com/rupinderjeet/great_list_view.git
      ref: fix/widgetsbindinginstance

try the new version 0.2.0

It works now. Thanks!


Milestone 1 To-Do List

[x] README.md - Yeji
[x] Team Work Contract - Celine
[x] Setup repo - Brian & Yeji
[x] CODE_OF_CONDUCT.md - Brian
[x] CONTRIBUTING.md - Yeji
[x] data/ - Anna
[x] heart_disease_predictor_report.ipynb - everyone
[x] EDA - Celine
[x] Model - Anna
[x] environment.yml - Brian
[x] conda-lock.yml - Brian
[x] LICENSE.md - Brian
[x] GH Pages Deployment - Brian
[x] Release -  Brian

Com


Configure Travis CI for API and portal testing

Added command aliases (eg. verify-api, verify-portal) to simplify build scripts
Implement caching
Adopt build stages for parallel tasks to run normal tests for API and both normal and func tests for portal

Partially takes care of https://github.com/vinyldns/vinyldns/issues/5.
Outstanding tasks include dynamic port assignment via docker compose to get API functional and integration tests working and integrating code coverage.

"normal" tests are unit tests right?


Remove DataValidation from the entity-system

Although many classes inherit from DataValidationBase, the data validation has not been used so far.
I've come to the conclusion that we need other approaches to data validation so this class is obsolete.

Done: https://github.com/inexorgame/entity-system/commit/4604c6969abc939dfd54c6eb4b88ad3ba25d8009.


NCDA - Aggregated Scorecard: view Demographics pane data [3h]

Task:  View rows using data generated at #708

NCDA is on live for few months. Closing.


cilium-health status: fix endpoint reachability in succinct view

This PR fixes the reporting of cilium-health status --succinct, and specifically of the endpoints reachability column in succinct view. The issue was caused by the GetAllEndpointAddresses function returning only secondary addresses, causing the status to be reported as reachable in case of failures associated with the primary address (or if this was the only one present).
Signed-off-by: Marco Iorio<EMAIL_ADDRESS>
Fixes: #issue-number
cilium-health status: fix endpoint reachability in succinct view

Travis CI hit https://github.com/cilium/cilium/issues/23314

k8s-1.16-kernel-4.9 and k8s-1.26-kernel-net-next hit https://github.com/cilium/cilium/issues/22056

/test-1.16-4.9

/test-1.26-net-next

/test-1.26-net-next

/test-1.16-4.9

/test-1.16-4.9

/test-1.26-net-next

It seems that the above tests are failing pretty consistently, although modifications should be completely unrelated. Retrying after rebasing the PR.

/test

ConformanceIngress tests hit https://github.com/cilium/cilium/issues/23179


added hierarchical methods

Adds two hierarchical methods to the XDataSet, and a unit test to cover them.
Also introduces protected meta key RAVEN_HierLevel, although I'm not sure if it's really necessary as it's the same thing as len(data['prefix'].split('_')).
To get the prefixes of realizations that are path endings, call _getPathEndings.  To get the paths for any one ending, call _reconstructPath.

This is ready for review now, @alfoa.


remove codecov integration

Coverage decreased (-0.3%) to 65.228% when pulling 6acc2da6678cdb859e17c8032674b8fa498e8f10 on feature/coveralls into 1d15b066c626730bcdf41db3b661d2cfd0e55e2c on master.


Fix SQLiteDatabaseLockedException

Task/Issue URL: https://app.asana.com/0/488551667048375/1206738751021077/f
Description
Fix SQLiteDatabaseLockedException crash that happens because vpn process unnecessarily warms in memory cache for something that is not use in vpn process. Causing it to race with main process
Related to https://github.com/duckduckgo/Android/pull/4189
Steps to test this PR
Code review and smoke test the app
Make sure the dbs involved load data normally when opening the browser

#4232  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Exc. 82

$\mathbb{G}_1$ and $\mathbb{G}_2$ turn out to be equal because $k=1$ in this case? Is our solution correct?

Also, full 2-torsion group is expected to contain 2^2=4 elements, but we only see 2 elements?

Suggestion by @skaunov was to use a torsion group of a curve from extended field, since beyond the powers of embedding degree, the torsion groups are equal. However, I still want to find the correct group using the embedding degree itself, without going beyond it.
His original solution used k=4 and it does return 4 elements:

F13 = GF(13)
TJJ_F13 = EllipticCurve(F13, [8, 8])
for point in TJJ_F13.points():
    if point.order() == 2:
        print(point)

L_TJJ_T2 = []
for i in range(1, 3):
    L_TJJ_T2.append(i * TJJ_F13([4, 0]))
TJJ_T2 = Set(L_TJJ_T2)
print(TJJ_T2)
# {(4 : 0 : 1), (0 : 1 : 0)}
F13t.<t> = F13[]
P_MOD_4 = F13t(t^4 + 2) # see previous exercises with this curve
F13_4.<t> = GF(13^4, name='t', modulus=P_MOD_4)

TJJ_F13_4 = EllipticCurve(F13_4, [8, 8])
# There's a dozen of elements of order $2^2$!
# for point in TJJ_F13_4.points():
#     if point.order() == 4:
#         print(point)
# So let's fall back to the approach from the page #103.
TJJF13_4_2 = Set(TJJ_F13_4(0).division_points(2))
TJJF13_4_2
# {(4 : 0 : 1), (7*t^2 + 11 : 0 : 1), (6*t^2 + 11 : 0 : 1), (0 : 1 : 0)}

# $\mathbb{G}_{1}[2]$ equals 2-torsion group
TJJ_G1 = Set([TJJ_F13_4(point) for point in TJJ_T2])
TJJ_G1

Let's look more closely at TJJF13_4_2. It contains (0 : 1 : 0) and three more points. We know that there's $r +1$ r-torsion subgroups, and we have $r = 2$, so each of this three points would suit; remember that zero-degree (4, 0) gives us $\mathbb{G}_1[2]$, so $\mathbb{G}_2[2]$ is equally good to generate with either one of two other points from TJJF13_4_2. The second element will be inevitable $(0 : 1 : 0)$.

Just for the sake of discussion: I found it quite hard and unproductive to think about such minimal pairing groups. Funny edge case ofc. but still. My best guess is that authors really wanted to have "book-through" examples, and TJJ yields only two possible variants better of which went into the text example, and with the other we're dealing here as an exercise, lol.

In the code below, we can see the difference between using the base field vs extended field.
# curve parameters for TJJ_13
p = 13
a, b = 8, 8

F13 = GF(p)      # field
F13t.<t> = FP[]  # polynomial ring
r = 2            # prime factor

def pairings(E, E_tor):
    print(E)

    # frobenius
    def fro_pi(P):
        if P != E(0):
            (x, y) = P.xy()
            return E(x^p, y^p)
        else:
            return P

    G1 = [P for P in E_tor if fro_pi(P) == P]
    print("G1:", G1)
    # {(4 : 0 : 1), (0 : 1 : 0)}

    G2 = [P for P in E_tor if fro_pi(P) == p*P]
    print("G2:", G1)

# curve over the base field
TJJ = EllipticCurve(F13, [a, b])
assert TJJ.order() % r == 0

# r-torsion group over base curve
TJJ_tor = TJJ(0).division_points(r)
print("2-torsion over p^1 (full)\n\t", TJJ_tor)
pairings(TJJ, TJJ_tor)

# curve over extension field of 4
F13_4 = GF(p^4, name='t', modulus=F13t.irreducible_element(4))
TJJ_4 = EllipticCurve(F13_4, [a, b])

# r-torsion group over extended curve
TJJ_4_tor = TJJ_4(0).division_points(r)
print("2-torsion over p^4\n\t", TJJ_4_tor)
pairings(TJJ_4, TJJ_4_tor)

copy-pasting my message to ZKHACK study group:
to find a full r-torsion group, we must find the r-torsion group of the curve over an extended field of F_{p^k(r)} where k(r) is the embedding degree for r
as also shown in an exmaple, when r=2, we immediately find k=1 for a prime base field order. so our "extended" field is actually the base field itself F_{p^1}
when I find the torsion group this way, I only find 2 elements that satisfy 2*P = INF
the book states that a full r-torsion group should have r^2 elements, so thats a problem
furthermore, when I find the 2-torsion group for F_{p^4} I actually get 4 elements for the first time, the torsion groups up to this point all have 2 elements and from this point on we have 4 elements. based on eq (5.4.4) this should indicate 4 to be the embedding degree, but that contradicts the stuff we did at the start

Added more comments to the solution, see PR #22


Update containerd to handle invalid container state directories on restore

The following PR: https://github.com/docker/containerd/pull/410 need to be cherry-picked in the containerd branch used by 17.03.1 to allow it to successfully restore itself when a container state directory gets incomplete

Fixed in 17.03.1 through https://github.com/docker/docker/pull/31662


Added $(interpolation) documentation

Subject
$
Description
Add the work done in this PR to the documentation site.
Are you willing to participate in creating this documentation page and create a pull request?
Yes

Fixed #2654


exception  java.net.SocketTimeoutException randomly occurs at pool.getResource()

I have multiple Java workers which collect data from a database, create a new thread, and puts the data on redis cache.
My issue is that, on a specific worker, I randomly get a JedisConnectionException when try to obtain a resource from pool.
I'm kinda confused with this, because since all my workers share the same code regarding Redis and receive the same amount of data, it is weird that the exception only triggers in one of them.
I'm running Jedis client 2.7.2.
My redis-related code is the following:
    Redis.java
      public Redis(){
        JedisPoolConfig config = new JedisPoolConfig();
        config.setMaxTotal(9999);
        config.setTestOnBorrow(true);
        this.clientPool = new JedisPool(config,
              Constants.Redis.IP,
              Constants.Redis.PORT,
              Constants.Redis.TIMEOUT, // timeout set to 999999
              Constants.Redis.PASSWORD);
      }

      public Jedis getClient(){
         try{
           return clientPool.getResource();
         }
         catch(){
           return null;
         }
      }

    WorkerThread.java
     Thread(){
       Jedis redisClient = cacheClient.getClient();
       if (redisClient == null){ return error; }
       else{
           // ...
           redisClient.close();
        }
      }

The exception is triggered randomly when clientPool.getResource() is called.
    redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool
        at redis.clients.util.Pool.getResource(Pool.java:50)
        at redis.clients.jedis.JedisPool.getResource(JedisPool.java:88)
        at services.Redis.getClient(Redis.java:79)
        at worker$WorkerThread.run(Worker.java:260)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
    Caused by: redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: connect timed out
        at redis.clients.jedis.Connection.connect(Connection.java:148)
        at redis.clients.jedis.BinaryClient.connect(BinaryClient.java:75)
        at redis.clients.jedis.BinaryJedis.connect(BinaryJedis.java:1572)
        at redis.clients.jedis.JedisFactory.makeObject(JedisFactory.java:69)
        at org.apache.commons.pool2.impl.GenericObjectPool.create(GenericObjectPool.java:819)
        at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:429)
        at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:360)
        at redis.clients.util.Pool.getResource(Pool.java:48)
        ... 6 more
    Caused by: java.net.SocketTimeoutException: connect timed out
        at java.net.PlainSocketImpl.socketConnect(Native Method)
        at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345)
        at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
        at java.net.Socket.connect(Socket.java:589)
        at redis.clients.jedis.Connection.connect(Connection.java:142)
        ... 13 more

Any help on this would be very appreciated.
Thanks and regards.

@guilhermecl at a first glance I see that your pool configuration seems to be very inefficient. The idea of a pool is to have a pre-configured amount of re-usable objects so you can handle workloads accordingly.
According to your configuration having a number of 9999 doesn't seem very efficient in terms of TCP connections or memory footprint.
Now, specifically about the timeout issue, you need to make sure that your server can handle 9999 open connections. If you're running redis in a *nix system it's likely that you're running out of file descriptors as the default open files is usually way lower than that.
What I presume it's happening is that the OS is holding the connect call because all the other connections are taken and eventually you hit the 999999 timeout. Does it take a while for the application to start throwing that exception or it does it as soon as you start it?

@marcosnils  thanks for your response.
You mean, my pool configuration is inefficient because of the settings config.setMaxTotal(9999) and Timeout 99999 ?
I just set these for testing purposes, since I wasn't expecting to reach these amount of connections right now. I will set it to a real-world value and see how it'll work, thanks for the tip.
About the timeout issue, it is really weird because I use the same settings in three different workers, and it only occurs in one of them.
Sometimes as soon as the application starts it throws exceptions, but the most commom scenario is to take a while, throw a few exceptions, works normally for a while, throw a few exceptions again, and so on.
I'll start with setting the pool configuration with decent values and see how the application behaves.
Thanks again for your attetion.
Regards.

@guilhermecl if only one of the workers is having problems then I believe the first to look into is the things around that specific worker like CPU / memory / iowait / steal time / etc. Remember that anything that makes the application hang will probably cause a Socketconnection exception.

@marcosnils yes, I'll do that. Since the VM share the same settings, I'll focus on the slightly differences between the workers. The processes are pretty much equal, but I'll profile it and see if I can find something.
I'll let you know when I find the root cause and solution.
Thanks for the help

Closing. Please re-open if you find anything that leads the problem to Jedis


FreeBSD arm64/aarch64 support

Feature
Add FreeBSD support on arm64/aarch64
Implementation
Add to https://github.com/bytecodealliance/wasmtime/blob/main/crates/runtime/src/traphandlers/unix.rs
 } else if #[cfg(all(target_os = "freebsd", target_arch = "aarch64"))] {
                    pc = context.uc_mcontext.mc_gpregs.gp_elr as usize;
                    sp = context.uc_mcontext.mc_gpregs.gp_sp as usize;

I take this code from https://github.com/wasmerio/wasmer/blob/dcfdea76999a/lib/vm/src/trap/traphandlers.rs#L302-L304 but don't know if some change needs to be made.
0.2.5 build log:
https://pkg-status.freebsd.org/ampere3/data/131arm64-default/b02e58aec16f/logs/lapce-0.2.5_1.log

This is not currently a supported platform but if you'd like to send a PR to update the code it would be appreciated!

@alexcrichton
Nice I will do that. Soon I will have arm64 hardware to further tests instead on relying on freebsd build servers.
Thanks

We probably also need to update the wasmtime-jit-icache-coherence crate.
I looked into this a little bit in https://github.com/bytecodealliance/wasmtime/pull/5323 but it looks like FreeBSD doesn't yet support the membarrier interface. But perhaps there is something else that we can use?
I had a look at what other JIT's are doing:

V8 emits its own icache maintenance instructions.
Spidermonkey uses membarriers
Mono also emits their own icache maintenance instructions

Maybe FreeBSD has some other syscall that we can use? I'm not too familiar with it.
CC: #3310

Just to add something, for latest relase (6.0.0), small change is need to make it compile:
} else if #[cfg(all(target_os = "freebsd", target_arch = "aarch64"))] {
    let cx = &*(cx as *const libc::mcontext_t);
    (
        cx.mc_gpregs.gp_elr as *const u8,
        cx.mc_gpregs.gp_x[29] as usize,
    )

around https://github.com/bytecodealliance/wasmtime/blob/main/crates/runtime/src/traphandlers/unix.rs#L220
This make it compile, but running tests is not possible becuase of https://github.com/denoland/rusty_v8/issues/1094

@sec
Thanks for testing it. I still waiting for arm64 hardware so I can't test it.
I will apply your patch and try to find someone that build and run test for me.

👋 Hey, I've tested the above patch in FreeBSD 14.0-CURRENT
freebsd@generic:~ % uname -a
FreeBSD generic 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n259967-11b5b9e8a520: Sat Jan  7 18:30:37 UTC 2023     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/arm64.aarch64/sys/GENERIC arm64

cargo build and cargo run work.
freebsd@generic:~/git/wasmtime % cargo run ./examples/gcd.wat --invoke gcd 8 8
    Finished dev [unoptimized + debuginfo] target(s) in 2.21s
     Running `target/debug/wasmtime ./examples/gcd.wat --invoke gcd 8 8`
warning: using `--invoke` with a function that takes arguments is experimental and may break in the future
warning: using `--invoke` with a function that returns values is experimental and may break in the future
8

I was able to run cargo test, but the tests fail with illegal instruction
     Running unittests src/lib.rs (target/debug/deps/wasmtime_cli-f9e37a0a7433af84)

running 2 tests
test commands::compile::test::test_aarch64_flags_compile ... ok
test commands::compile::test::test_successful_compile ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.57s

     Running unittests src/bin/wasmtime.rs (target/debug/deps/wasmtime-27a7f646c50db093)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/all/main.rs (target/debug/deps/all-619db9ec6a9e4647)

running 819 tests
test async_functions::async_with_pooling_stacks ... ok
test async_functions::cancel_during_run ... ok
test async_functions::async_host_func_with_pooling_stacks ... ok
test async_functions::fuel_eventually_finishes ... ok
error: test failed, to rerun pass `--test all`

Caused by:
  process didn't exit successfully: `/home/freebsd/git/wasmtime/target/debug/deps/all-619db9ec6a9e4647` (signal: 4, SIGILL: illegal instruction)

@afonso360
Thanks for do further tests.
I'm working on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268929 and if it succeeds, then I can start testing other ports that depends on this crate.

Just to add something, for latest relase (6.0.0), small change is need to make it compile:
} else if #[cfg(all(target_os = "freebsd", target_arch = "aarch64"))] {
    let cx = &*(cx as *const libc::mcontext_t);
    (
        cx.mc_gpregs.gp_elr as *const u8,
        cx.mc_gpregs.gp_x[29] as usize,
    )

around https://github.com/bytecodealliance/wasmtime/blob/main/crates/runtime/src/traphandlers/unix.rs#L220
This make it compile, but running tests is not possible becuase of denoland/rusty_v8#1094

Hello @sec,
I have results that it builds on aarch64 and I committed your patch at https://cgit.freebsd.org/ports/commit/?id=75a1d429216aa977d1bf6b1f4a9c5eb4eb474ac8
Should a upstream change be made with this patch?
( Build fails on armv7 FreeBSD 13.1:
error[E0308]: mismatched types
   --> /wrkdirs/usr/ports/editors/lapce/work/lapce-0.2.5/cargo-crates/rustix-0.35.10/src/backend/libc/net/syscalls.rs:565:21
    |
565 |                     tv_sec,
    |                     ^^^^^^ expected `i64`, found `i32`
    |                                                                                help: you can convert an `i32` to an `i64`
    |
565 |                     tv_sec: tv_sec.into(),
    |                     +++++++       +++++++

[num-traits 0.2.15] cargo:rustc-cfg=has_leading_trailing_ones
[num-traits 0.2.15] cargo:rustc-cfg=has_int_assignop_ref
For more information about this error, try `rustc --explain E0308`.
error: could not compile `rustix` due to previous error

This is due to time_t not being a long on armv7. )

I have a fix for that armv7 FreeBSD bug here; I'll do a point release of rustix and update Wasmtime.

Looked into this a bit more, this branch also does the icache clearing. However I'm still getting the same error.
I'll try to track this down when I get a chance.


Updated skipped tests for painting directory.

Part of #86396.
Updated the skip tests in the 'painting' directory. Turned some tests back on, marked some as intentional in a comment or added issues where missing.

Gold has detected about 5 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/87546


App Router Support without the need for unstable_noStore

Use a noStore for env access opts App Router out from the full request cache. This is problematic for static pages that can benefit from edge caching and is a blocker to adopting this library.
There is an experimental next build feature that allows splitting the build step from the generation step:
next build --experimental-build-mode compile/generate. https://github.com/vercel/next.js/discussions/46544
Where the compile step can execute in CI and the generate step can execute in the runtime.
Support for this build approach would allow for this library to support static ahead of time generation with a runtime env and get closer to Vercel Nextjs.

Are you considering supporting SSG in the future?


Add go1.10 build constraint

This prevents netns from being used on older Go runtimes on which it's not safe to perform any state manipulations of a scheduling thread (https://github.com/golang/go/issues/20676).
Partially fixes #17.

LGTM


Make reference group more predictable

I just noticed that the reference group for the decomposition is determined by which group has the larger mean DV:
https://github.com/sinanpl/OaxacaBlinder/blob/de7e7ac03666fe15f80ecbabadf41a55002a2629/R/oaxaca.R#L35
There are a couple things to note about this:

The code comment notes that the group with the higher mean DV will be the reference group, when in fact (I'm pretty sure) the lower mean DV will be the reference group.  (As Jann (2008:455) puts it, when group B is subtracted from group A, the decomposition is "formulated from the viewpoint of group B".)  This is a minor point of course, but I suppose the comment should be clarified.
This shares the same problem as #4 and #5 in that the calculation of DV means does not take into account NAs the same way the lm() calls will, and so in theory (though probably rarely) could set the reference group in a different way than would be calculated after na.action.

More seriously though, I think setting the reference group like this, while convenient in many cases, could lead to results that might be confusing and easy to misinterpret.  At the very least it should be documented, but I think it would be best to add an option (or two, perhaps) to OaxacaBlinderDecomp() to change how the reference group is set.
I think the current auto-magic behavior would need an on/off switch, leaving the question of what to do when it's turned off.  I think we could either require the group variable to be a logical and to always use one value as the reference (FALSE seems intuitive to me, but I think Jann and Hlavac both use TRUE), or to take a second option (which is ignored if the auto-magic behavior is turned on) to determine the reference group.
I think it'd be better to have the user supply the reference value since it doesn't require the variable to be set up as a dummy?  But I'm happy to be overrruled.  (Note that if we go this route we should probably accept any value here and match it to the label if the group variable is a factor and the reference option is a character.)

(Note that if we go this route we should probably accept any value here and match it to the label if the group variable is a factor and the reference option is a character.)

Whoops, never mind, I forgot that R will (always?) match characters to factor levels.  So I think we shouldn't mess with this and instead let R do what R normally does.

also related... something I discovered while writing tests... the unexplained_A / B coefs are differing compared to the oaxaca package. So this might be something that will / should be improved.
# fit several models in both packages
formula = real_wage ~ age | male
dataset = OaxacaBlinder::chicago_long

modv1_twofold_neumark = OaxacaBlinder::OaxacaBlinderDecomp(
  formula=formula,
  data = dataset,
  type = 'twofold',
  pooled = 'neumark',
  baseline_invariant = FALSE,
  n_bootstraps = NULL
)

modv2 = oaxaca::oaxaca(formula = formula, data = dataset, R=NULL)
#> oaxaca: oaxaca() performing analysis. Please wait.

modv1_twofold_neumark$overall
#> $explained
#> [1] 0.204005
#>
#> $unexplained
#> [1] 3.630331
#>
#> $unexplained_a
#> [1] 1.569873
#>
#> $unexplained_b
#> [1] 2.060458
modv2$twofold$overall[5, ]
#>        group.weight     coef(explained)       se(explained)   coef(unexplained)
#>           -1.000000           -0.204005                  NA           -3.630331
#>     se(unexplained) coef(unexplained A)   se(unexplained A) coef(unexplained B)
#>                  NA           -2.060458                  NA           -1.569873
#>   se(unexplained B)
#>                  NA

Created on 2024-03-17 with reprex v2.0.2

in addition, this is currently not the case whn type = 'jann'
# fit several models in both packages
formula = real_wage ~ age | male
dataset = OaxacaBlinder::chicago_long

modv1_twofold = OaxacaBlinder::OaxacaBlinderDecomp(
    formula=formula,
    data = dataset,
    type = 'twofold',
    pooled = 'jann',
    baseline_invariant = FALSE,
    n_bootstraps = NULL
)

modv2 = oaxaca::oaxaca(formula = formula, data = dataset, R=NULL)
#> oaxaca: oaxaca() performing analysis. Please wait.

modv1_twofold$overall
#> $explained
#> [1] 0.1918078
#>
#> $unexplained
#> [1] 3.642528
#>
#> $unexplained_a
#> [1] 2.517431e-14
#>
#> $unexplained_b
#> [1] 3.642528
modv2$twofold$overall[6, ]
#>        group.weight     coef(explained)       se(explained)   coef(unexplained)
#>       -2.000000e+00       -1.918078e-01                  NA       -3.642528e+00
#>     se(unexplained) coef(unexplained A)   se(unexplained A) coef(unexplained B)
#>                  NA       -1.940510e-14                  NA       -3.642528e+00
#>   se(unexplained B)
#>                  NA

Created on 2024-03-17 with reprex v2.0.2

Good catches!  I've almost exclusively been focusing on the threefold decomposition (which I understand better at this point), so I'm glad you're checking the twofold side...

Update on this: I think this should get fixed by #18 once it's in shape, and I suspect that the differences with oaxaca might get fixed by that too (though frankly 1. we should check and make sure, and 2. I'm becoming less confident in oaxaca anyway and I think it's probably better to run tests against Jann's Stata command instead).


-Wconversion warning

I'm receiving a -Wconversion warning when including and compiling the latest release of the library. I read https://github.com/nlohmann/json/issues/239 but the errors showed are different (although it's the same flag that sends the warning), also the links present there are down.
Here is the complete output:
In file included from .../foo.cpp:3:0:
.../json.hpp: In instantiation of ‘nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::escape_string(const
string_t&) [with ObjectType = std::map; ArrayType = std::vector; StringType =
std::basic_string<char>; BooleanType = bool; NumberInteger
Type = long int; NumberFloatType = double; AllocatorType = std::allocator;
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::string_t = std::basic_string<char>]::__lambda3’:
.../json.hpp:5455:40:   required from ‘struct nlohmann::basic_json<ObjectType, ArrayType,
StringType, BooleanType, NumberIntegerType, NumberFloatType,
AllocatorType>::escape_string(const string_t&) [with ObjectType = std::map; ArrayType =
std::vector; StringType = std::basic_string<char>; BooleanType = bool; NumberIntegerType = long
int; NumberFloatType = double; AllocatorType = std::allocator; nlohmann::basic_json<ObjectType,
ArrayType, StringType, BooleanType, NumberIntegerType, NumberFloatType,
AllocatorType>::string_t = std::basic_string<char>]::__lambda3’
.../json.hpp:5458:25:   required from ‘static nlohmann::basic_json<ObjectType, ArrayType,
StringType, BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::string_t
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::escape_string(const string_t&) [with ObjectType = std::map;
ArrayType = std::vector; StringType = std::basic_string<char>; BooleanType = bool;
NumberIntegerType = long int; NumberFloatType = double; AllocatorType = std::allocator;
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::string_t = std::basic_string<char>]’
.../json.hpp:5536:48:   required from ‘void nlohmann::basic_json<ObjectType, ArrayType,
StringType, BooleanType, NumberIntegerType, NumberFloatType,
AllocatorType>::dump(std::ostream&, bool, unsigned int, unsigned int) const [with ObjectType =
std::map; ArrayType = std::vector; StringType = std::basic_string<char>; BooleanType = bool;
NumberIntegerType = long int; NumberFloatType = double; AllocatorType = std::allocator;
std::ostream = std::basic_ostream<char>]’
.../json.hpp:1892:61:   required from ‘nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::string_t
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::dump(int) const [with ObjectType = std::map; ArrayType =
std::vector; StringType = std::basic_string<char>; BooleanType = bool; NumberIntegerType = long
int; NumberFloatType = double; AllocatorType =
 std::allocator; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType,
NumberIntegerType, NumberFloatType, AllocatorType>::string_t = std::basic_string<char>]’
.../json.hpp:8209:25:   required from here
.../json.hpp:5457:72: error: conversion to ‘char’ from ‘int’ may alter its value [-Werror=conversion]
                             return (v < 10) ? ('0' + v) : ('a' + v - 10);
                                                                        ^
.../json.hpp:5457:72: error: conversion to ‘char’ from ‘int’ may alter its value [-Werror=conversion]
.../json.hpp: In instantiation of ‘static nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::string_t
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::escape_string(const
 string_t&) [with ObjectType = std::map; ArrayType = std::vector; StringType =
std::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberFloatType =
double; AllocatorType = std::allocator; nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::string_t = std::basic
_string<char>]’:
.../json.hpp:5536:48:   required from ‘void nlohmann::basic_json<ObjectType, ArrayType,
StringType, BooleanType, NumberIntegerType, NumberFloatType,
AllocatorType>::dump(std::ostream&, bool, unsigned int, unsigned int) const [with ObjectType =
std::map; ArrayType = std::vector; StringType = std::basic_string<char>; BooleanType = bool;
NumberIntegerType = long int; NumberFloatType = double; AllocatorType = std::allocator;
std::ostream = std::basic_ostream<char>]’
.../json.hpp:1892:61:   required from ‘nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberFloatType, AllocatorType>::string_t
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberFloatType, AllocatorType>::dump(int) const [with ObjectType = std::map; ArrayType =
std::vector; StringType = std::basic_string<char>; BooleanType = bool; NumberIntegerType = long
int; NumberFloatType = double; AllocatorType =
 std::allocator; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType,
NumberIntegerType, NumberFloatType, AllocatorType>::string_t = std::basic_string<char>]’
.../json.hpp:8209:25:   required from here
.../json.hpp:5462:51: error: conversion to ‘char’ from ‘int’ may alter its value [-Werror=conversion]
                     { 'u', '0', '0', hexify(c >> 4), hexify(c & 0x0f)
                                                   ^
cc1plus: all warnings being treated as errors

gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
Compile flags: -std=c++11 -Wall -Werror -Wconversion -Wno-unused-parameter -Wextra -Wtype-limits -pedantic -pedantic-errors

Could you please try the latest version in the develop branch? I remember fixing some conversion warnings there.

I tried with the develop version, but now I receive an error that didn't appear with the release library.
In file included from .../foo.cpp:6:0:
.../json.hpp: In instantiation of
‘nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberUnsignedType, NumberFloatType, AllocatorType>::value_type&
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberUnsignedType, NumberFloatType, AllocatorType>::operator[]
(nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberUnsignedType, NumberFloatType, AllocatorType>::size_type) [with ObjectType = std::map;
ArrayType = std::vector; StringType = std::basic_string<char>; BooleanType = bool;
NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType =
double; AllocatorType = std::allocator; nlohmann::basic_json<ObjectType, ArrayType, StringType,
BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType,
AllocatorType>::reference = nlohmann::basic_json<>&; nlohmann::basic_json<ObjectType,
ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType,
NumberFloatType, AllocatorType>::value_type = nlohmann::basic_json<>;
nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType,
NumberUnsignedType, NumberFloatType, AllocatorType>::size_type = long unsigned int]’:
.../foo.cpp:21:49:   required from here
.../json.hpp:1062:5: error: conversion from
‘nlohmann::basic_json<>::value_t’ to non-scalar type ‘nlohmann::basic_json<>::type_data_t’
requested
     basic_json() = default;
     ^
.../json.hpp:3307:17: note: synthesized method ‘nlohmann::basic_json<ObjectType, ArrayType,
StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType,
AllocatorType>::basic_json() [with ObjectType = std::map; ArrayType = std::vector; StringType =
std::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType
= long unsigned int; NumberFloatType = double; AllocatorType = std::allocator]’ first required here
                 m_value.array->push_back(basic_json());
                 ^

This is a known error of GCC 4.8 which is therefore not supported by the library, see https://github.com/nlohmann/json#supported-compilers. Can you try with a more recent compiler?

I had another look at your first output. These warnings have been fixed with #239 (see commit https://github.com/nlohmann/json/commit/db5c9ec9bad63e7f439b72aa63350b089a5f1700). (The links are down, because the feature branch has been merged and deleted since.)

Ok, thanks for your help!

Hi, I'm running into the same issue, but with commit 15a314a.
I'm using Clang 3.4.2 for Linux

This is very strange. Can you please provide the concrete warning output?

here's the build output.
the error is at the point of instantiation of a class with an nlohmann::json member.

[ 91%] Building CXX object common/CMakeFiles/common.dir/config.cpp.o
In file included from /home/centos/shared/src_master_origin/common/config.h:8:0,
from /home/centos/shared/src_master_origin/common/config.cpp:1:
/home/centos/shared/src_master_origin/common/../3rdparty/json/src/json.hpp: In instantiation of 'nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType> nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::parser::parse() [with ObjectType = std::map; ArrayType = std::vector; StringType = std::basic_string; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator]':
/home/centos/shared/src_master_origin/common/../3rdparty/json/src/json.hpp:5722:36:   required from 'static nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType> nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::parse(const string_t&, nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::parser_callback_t) [with ObjectType = std::map; ArrayType = std::vector; StringType = std::basic_string; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::string_t = std::basic_string; nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::parser_callback_t = std::function<bool(int, nlohmann::basic_json<>::parse_event_t, nlohmann::basic_json<>&)>]'
/home/centos/shared/src_master_origin/common/../3rdparty/json/src/json.hpp:8920:98:   required from here
/home/centos/shared/src_master_origin/common/../3rdparty/json/src/json.hpp:1060:5: error: conversion from 'nlohmann::basic_json<>::value_t' to non-scalar type 'nlohmann::basic_json<>::type_data_t' requested
basic_json() = default;
^
/home/centos/shared/src_master_origin/common/../3rdparty/json/src/json.hpp:8611:42: note: synthesized method 'nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType>::basic_json() [with ObjectType = std::map; ArrayType = std::vector; StringType = std::basic_string; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator]' first required here
return result.is_discarded() ? basic_json() : result;
^
make[2]: *** [common/CMakeFiles/common.dir/config.cpp.o] Error 1

Hi @guygman, thanks for providing more information. It seems as if Clang is choking on an implicit conversion from type_data_t to basic_json. In fact, I am planning to remove type_data_t altogether - could you please try to compile your example with this branch?

Hi,
compiling with that branch worked much better! there was no conversion error.

That branch has now been merge with develop, see f86fe57 .


tests for git commands

https://github.com/deis/workflow-e2e/issues/205

https://github.com/deis/workflow-e2e/issues/193 could be included in that or as part of the apps tests - up to the implemenator

This issue was moved to teamhephy/workflow-cli#16


TensorRT INT8 Calibration Table is Missing

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below): v1.13.0-rc1-0-g54c5616308
Python version:3.5.2
CUDA/cuDNN version: CUDA 10
GPU model and memory: Tesla V100 16GB

Describe the current behavior
TFTRT failed to collect calibration info and cannot create the INT8 inference graph.
Code to reproduce the issue
Here is the model link.
def run_calibration(calib_graph, dataset):
    tf.reset_default_graph()
    tf_config = tf.ConfigProto()
    tf_config.gpu_options.allow_growth = True
    x = np.random.randint(0,10000,(1,40))
    with tf.Graph().as_default() as g:
        input, output = tf.import_graph_def(graph_def=calib_graph, return_elements=["X", "model/dense/BiasAdd"],
                                            name='')
        input = input.outputs[0]
        output = output.outputs[0]
        sess = tf.Session(config=tf_config, graph=g)

        for i in range(10):
            val = sess.run(output, {input: x})
        return calib_graph

def int8quant():
    with tf.Session() as sess:
        saver = tf.train.import_meta_graph("/workspace/exps/ptb/ptb_rnn_128/ptb_rnn_128-72600.meta")
        saver.restore(sess, "/workspace/exps/ptb/ptb_rnn_128/ptb_rnn_128-72600")
        your_outputs = ['model/dense/BiasAdd']
        frozen_graph = tf.graph_util.convert_variables_to_constants(
            sess,
            tf.get_default_graph().as_graph_def(),
            output_node_names=your_outputs)
        trt_graph = trt.create_inference_graph(
            input_graph_def=frozen_graph,
            outputs=your_outputs,
            max_batch_size=10,
            max_workspace_size_bytes=2 << 30,
            precision_mode='INT8',
            minimum_segment_size=2  # minimum number of nodes in an engine
       )
    int8graph = run_calibration(trt_graph, None)
    int8_graph = trt.calib_graph_to_infer_graph(int8graph)

Other info / logs
Here is the trace logs.
2019-07-19 03:47:34.167937: E tensorflow/contrib/tensorrt/log/trt_logger.cc:38] DefaultLogger Tensor TensorRTOutputPH_0cannot be both input and output
2019-07-19 03:47:34.167960: E tensorflow/contrib/tensorrt/log/trt_logger.cc:38] DefaultLogger Network must have at least one output
2019-07-19 03:47:38.553760: E tensorflow/contrib/tensorrt/log/trt_logger.cc:38] DefaultLogger Tensor (Unnamed ITensor* 3) is uniformly zero; network calibration failed.
2019-07-19 03:47:38.578654: E tensorflow/contrib/tensorrt/convert/convert_graph.cc:220] Calibration table is empty
Traceback (most recent call last):
  File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/workspace/code/rnnquant/trt/convert.py", line 99, in <module>
    main()
  File "/workspace/code/rnnquant/trt/convert.py", line 95, in main
    int8quant()
  File "/workspace/code/rnnquant/trt/convert.py", line 89, in int8quant
    int8_graph = trt.calib_graph_to_infer_graph(int8graph)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/tensorrt/python/trt_convert.py", line 416, in calib_graph_to_infer_graph
    int(msg[0]))
tensorflow.python.framework.errors_impl.UnknownError: Calibration table is missing. This shouldn't have happened!

@jiarongqiu Did you check whether the issue persists with latest versions (TF1.14, or nightly builds) of TF? Thanks!

@jiarongqiu Did you check whether the issue persists with latest versions (TF1.14, or nightly builds) of TF? Thanks!

I haven't checked the other versions yet. I will check with TF 1.14.

@jiarongqiu Did you check whether the issue persists with latest versions (TF1.14, or nightly builds) of TF? Thanks!

I just tested on TF1.14 version following trt_convert_test.py. I succeedd in converting the graph but found a problem here.
I tested the converted graph with both calibration dataset and random data but got same result during the inference. I guessed my current conversion did not collection any info from the calibration dataset.
Is there somewhere that I could check the cache and the threshold T TensorRT chose for activations and weights?

@jiarongqiu there is a problem in 1.14.0 and we're fixing that. Meanwhile, can you try with tf-nightly-gpu and follow these instructions to see if it works?
Thanks.

This is my current code. I import the graph through GraphDef.
    with tf.Session() as sess:
        saver = tf.train.import_meta_graph("/workspace/exps/ptb/ptb_rnn_128/ptb_rnn_128-72600.meta")
        saver.restore(sess, "/workspace/exps/ptb/ptb_rnn_128/ptb_rnn_128-72600")
        outputs = ['model/dense/BiasAdd']
        frozen_graph = tf.graph_util.convert_variables_to_constants(
            sess,
            tf.get_default_graph().as_graph_def(),
            output_node_names=outputs)
        converter = trt_convert.TrtGraphConverter(
            input_graph_def=frozen_graph,
            nodes_blacklist=outputs,
            precision_mode=trt_convert.TrtPrecisionMode.INT8,
        )

        class CalibrationData(object):

            def __init__(self,dataset=None):
                self.dataset = dataset

            def next(self):
                X =  np.random.randint(0, 10000, (1, 40))
                return {"X:0": X}

        calib_graph = converter.convert()
        calib_graph = converter.calibrate(
            fetch_names=["model/dense/BiasAdd:0"],
            num_runs=10,
            feed_dict_fn=CalibrationData().next)
        tf.train.write_graph(calib_graph, "/workspace/exps/ptb/ptb_rnn_128", "trt_model_int8.pb", as_text=False)

And, I tested it on the tf-nightly-gpu but got some errors during the conversion.
2019-07-24 06:16:59.855323: E tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:41] DefaultLogger Tensor (Unnamed ITensor* 3) is uniformly zero; network calibration failed.
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1352, in _do_call
    return fn(*args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1337, in _run_fn
    target_list, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1430, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
  (0) Unknown: Calibration table is empty.
         [[{{node GetCalibrationDataOp}}]]
  (1) Unknown: Calibration table is empty.
         [[{{node GetCalibrationDataOp}}]]
         [[GetCalibrationDataOp/_7]]
0 successful operations.
0 derived errors ignored.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/workspace/code/rnnquant/trt/convert.py", line 142, in <module>
    main()
  File "/workspace/code/rnnquant/trt/convert.py", line 138, in main
    int8quantv2()
  File "/workspace/code/rnnquant/trt/convert.py", line 128, in int8quantv2
    feed_dict_fn=CalibrationData().next)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/compiler/tensorrt/trt_convert.py", line 643, in calibrate
    resource_name_input: _get_canonical_engine_name(node.name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 945, in run
    run_metadata_ptr)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1168, in _run
    feed_dict_tensor, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1346, in _do_run
    run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1371, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
  (0) Unknown: Calibration table is empty.
         [[node GetCalibrationDataOp (defined at usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py:1657) ]]
  (1) Unknown: Calibration table is empty.
         [[node GetCalibrationDataOp (defined at usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py:1657) ]]
         [[GetCalibrationDataOp/_7]]
0 successful operations.
0 derived errors ignored.

Original stack trace for 'GetCalibrationDataOp':
  File "usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "workspace/code/rnnquant/trt/convert.py", line 142, in <module>
    main()
  File "workspace/code/rnnquant/trt/convert.py", line 138, in main
    int8quantv2()
  File "workspace/code/rnnquant/trt/convert.py", line 128, in int8quantv2
    feed_dict_fn=CalibrationData().next)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/compiler/tensorrt/trt_convert.py", line 635, in calibrate
    gen_trt_ops.get_calibration_data_op(resource_name_input))
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/compiler/tf2tensorrt/ops/gen_trt_ops.py", line 265, in get_calibration_data_op
    "GetCalibrationDataOp", resource_name=resource_name, name=name)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/op_def_library.py", line 793, in _apply_op_helper
    op_def=op_def)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/util/deprecation.py", line 507, in new_func
    return func(*args, **kwargs)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py", line 3261, in create_op
    attrs, op_def, compute_device)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py", line 3330, in _create_op_internal
    op_def=op_def)
  File "usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py", line 1657, in __init__
    self._traceback = tf_stack.extract_stack()

@jiarongqiu this is what I got when running calibration:
2019-10-09 08:08:48.328837: W tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:37] DefaultLogger Tensor (Unnamed Layer* 2) [Constant]_output is uniformly zero; network calibration failed.

I'm running this with the latest TF r1.15.0rc3. It seems that the TRT portion of your model always output 0 regardless of the input. Can you double check the model and see if it's correct?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


🎨  unique constraint for permission and role name

no issue
I saw tests adding permissions and roles twice. (see screenshots)

That happened because the setup in the test was mis-used and there is no restriction for static resources to create duplicates. We also have a unique constraint for settings keys.
With this PR i suggest to make name unique.

This PR needs a review before #7495


Branch 2.1

hello，I am wondering how to look for your latest thesis。In the Web of Science, what key words should be typed. Is there a list about your thesis about Spark?

Can one of the admins verify this patch?

Close this @forceto


The property 'call' can't be accessed on '*' in a constant expression.

hello,
running this code

sample
typedef Foo = Future<void> Function();

class FooDelegate {
  const FooDelegate();
  Future<void> call() => Future.sync(() {});
}

class Bar {
  final Foo foo;
  const Bar({this.foo = const FooDelegate()});

  void call() async {
    await foo();
    // ignore: avoid_print
    print('ok');
  }
}

void main() {
  final bar = Bar();
  bar();
}

the analyzer comes clean
flutter analyze
Analyzing const_issue...
No issues found! (ran in 0.9s)

but then the compiler throws
 Context: The property 'call' can't be accessed on '*' in a constant expression.

is this behavior intended?
if so shouldn't be given a warning?
thank you

doctor
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-x64, locale en-EE)
    • Flutter version 2.8.1 at /Users/francesco/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (6 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/francesco/Library/Android/sdk
    • Platform android-31, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (3 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • macOS (desktop)                    • macos         • darwin-x64     • macOS 12.1 21C52 darwin-x64
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 97.0.4692.99

• No issues found!

The behavior is correct, but tricky.
We have the following code:
typedef Foo = Future<void> Function();

class FooDelegate {
  const FooDelegate();
  Future<void> call() => Future.sync(() {});
}

class Bar {
  final Foo foo;
  const Bar({this.foo = const FooDelegate()});

The default value const FooDelegate() has type FooDelegate, a callable class type. The variable it's assigned to has the function type Foo.
In order to do that assignment, the const FooDelegate() is silently converted into const FooDelegate().call, in order to have a function to assign to the function type.
However, that expression is not a compile-time constant, so it's not valid as a default value. Hence the error.

Right, the analyzer fails to report that the given default value is not a constant expression (after .call insertion). Adjusted the labels and status accordingly.
In fact, the common front end message isn't exactly as stated above in the current tool chain (commit 4b26ea0dad260fb6500b83a8960950d4cc6e5e04):
n019.dart:10:31: Error: Constant evaluation error:
  const Bar({this.foo = const FooDelegate()});
                              ^
n019.dart:10:31: Context: The property 'call' can't be accessed on 'FooDelegate {}' in a constant expression.
 - 'FooDelegate' is from 'n019.dart'.
  const Bar({this.foo = const FooDelegate()});
                              ^
n019.dart:10:19: Context: While analyzing:
  const Bar({this.foo = const FooDelegate()});
                  ^

The bleeding edge analyzer reports an error here, I suspect that @srawlins fixed it.


Refactor default handling

make default presets relative to now() (solves #66)
add this month only for default presets (solves #65)
do not include default/custom presets that have a "negative" range

@tyvdh Can you merge this soon, because I really want to use the newer version, but that won't do with this extra entry in the presets

@tiljanssen It's not working for me atm. Did you build and test at all?

Apparently I tested it with a newer version of moment. isAfter is available in moment 2.0.0 and later.


Consider adding babel-plugin-react-require

In my project I use awesome babel-plugin-react-require.
Initially, I was surprised why I need to import React into module with my component even if I don't use this directly. Especially in module with functional component.
export default function MyComponent() {
  return
MyComponent
;
}

This plugin solves that, it adds React import into any file with JSX expression, which makes your code more seamless.
Would you like to enable this plugin here as well?

Thanks for the suggestion!
We won’t use it for this reason: https://github.com/facebookincubator/create-react-app/pull/603#issuecomment-245525977.


Android Image Marker issue

Is this a bug report?
YES
Have you read the Installation Instructions?
YES
Environment
react-native => 0.55.0
react => 16.3.1
react-native-maps => 0.16.4
Target Platform:  Android
Expected Behavior
the image has to be rendered as a marker
Actual Behavior
the image is rendered  along with the default red  marker
Reproducible Demo
  <MapView.Marker
      identifier="Marker"
      image={ markerImg}
      coordinate={coords}
      centerOffset={{ x: -42, y: -60 }}
      anchor={{ x: 0.84, y: 1 }}
      opacity={0.6}
    >

I have a similar issue. From version 0.22.0 on, suddenly the image={} of MapView.Marker does not render the image. If I start changing images of markers or removing and adding markers, it does work, but the initial render shows the default red pins as markers.

I am also experiencing this issue


Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparision

Scenario
Fluent TPI
Fabric TPI
Ratio
Iterations
Ticks

Button.Fluent
1.16
0.12
9.67:1
5000
5782

Checkbox.Fluent
1.3
0.22
5.91:1
5000
6514

Icon.Fluent
0.24
0.03
8:1
5000
1198

Slider.Fluent
1.7
0.25
6.8:1
5000
8515

  Generated by :no_entry_sign: dangerJS


Ui of button and input field improvement

Description

I would like to improve the ui of the button in light and dark mode, Also i would  like to improve the ui of the input field.
Please assign it to me under gssoc'23. I want to work upon this issue.
Steps to reproduce

Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Yes surely

@narayan954 please check  https://github.com/narayan954/dummygram/pull/821


Update overview.md

Docs Build status updates of commit b070c69:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 772e2a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/post-publish/overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


fix(language-core): loose props check on generic components without strictTemplates

fix #4972

See https://github.com/vuejs/language-tools/issues/4972#issuecomment-2557750343


there may have some problem about tokenizer.py

I meet a problem when I use tensor2tensor train a translate model, and decode some sentence.
The Error is ' IndexError: string index out of range'
so I debug the error sentence,  and find it generate a subword '\' in the sentence end.  '\' is a special char, so it unescaped a empty word, and length is 0, when run in tokenizer.py -> decode function, there have a code is: ' token_is_alnum = [t[0] in _ALPHANUMERIC_CHAR_SET for t in tokens] '
and when t's length is 0, it will error, but I don't know why '\' will be create in the sentence end.

@drockser Does still problem still exists in the latest version of tensor2tensor?

@stefan-it I don't using the latest version of tensor2tensor,  however, I read the code the latest tokenizer.py,  the code 'token_is_alnum = [t[0] in _ALPHANUMERIC_CHAR_SET for t in tokens]' is still in it , so I think the problem also exits in the lastest version.


[RFC]: improve README examples of math/tools namespace

Description
This RFC proposes to improve the README examples of the math/tools namespace package. Currently, namespace package READMEs only include minimal examples which are not particularly informative and do not showcase namespace functionality.
Historically, namespace examples were not given much effort due to the rapidly changing nature of the project; however, now that development and organization has settled, it would be good to revisit these packages and add proper examples to better communicate to users how to use namespace contents.
For those wanting to contribute to this issue, you can use the following steps:

Browse through the contents of the math/tools namespace and identify interesting functions and packages to showcase.
Update the example code block in the "Examples" section of the README for the math/tools namespace and open a PR.
When updating the README, examples should follow existing project conventions (e.g., ES5).
Examples may require functionality from other packages to help make examples more interesting.

Related Issues
None.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

hey @Planeshifter I want to work on this repo


Resolve "unmet peer dependency" warnings

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/999
Originally created by @DouweM on 2019-09-17 16:51:01

warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^4.0.0".

View 3 previous comments from the original issue on GitLab


Option to ignore textures at export

I need to export the geometry + materials but with no textures, since the textures are added back later on in the pipeline. The problem is some of the materials come with textures assigned to them, which means I have to constantly go into the shader view and delete the textures in all materials in order to avoid exporting them.
Describe the solution you'd like
My proposal is to either add a new Images option below the Materials option or to add a None option in the Images enum menu.

This way it would be easy to export geo with material groups but making sure no image data is packed in.

I think this option would be very useful, because lots of people use .basis compressed textures in web apps nowadays. Since the exporter doesn't support image copression, users have to either bloat the file size (and uncompressed textures increase it by A LOT) or manually remove all the image nodes from every material before export.

Another issue is if a mesh has multiple materials on it, the exporter creates one geometry (primitive) per material, but then doesn't associate any material information with it, so you can't re-create it in a downstream consumer.
There apparently was a PR made to do just this about a year ago: https://github.com/KhronosGroup/glTF-Blender-IO/pull/453
@yoanlcq I don't suppose you ever ended up revisiting that PR, did you?

the exporter creates one geometry (primitive) per material, but then doesn't associate any material information with it, so you can't re-create it in a downstream consumer.

I don't think I understand this part... each primitive will still have materials associated. If that's not what you're seeing you may have a separate bug?

My PR (#453) isn't really a solution for OP, but rather for the "texture sharing" case described by @DolphinIQ , which IMHO would need a separate ticket, given how simple OP's request is.
Indeed I have not kept up with the latest changes, so I suspect it could not be merged today without major changes; I'm still using the feature in my personal project though, and it works great for my purposes.
"texture sharing" was suggested as a post-processing step, but IMO this is too late in the pipeline to do it (you'd need to work out which texture files are "equal" after exporting your multiple GLTFs), especially since all file paths are readily available in Blender, along with whether or not they are relative or absolute. At the very least, they could be provided in JSON via extras.
... And, while we're at it, we could choose not to export the textures, and just leave them where they are, assuming the application would use the provided file path.
All of that would make sense to me, as options in the exporter, as long as they don't replace the defaults; they would just be there for those who need it.
If that sounds good, then I might try to unearth my PR, but in any case, this might need a separate ticket as I mentioned. :)

Ignoring textures on export is very much needed. These days gltf is the recommended exchange format for godot. But this automatic packing increases the size of these exchange files drastically (indirectly even creating duplicates) and unecessarily as game engines have their own means of managing texture resources.

I think we'd like to support this feature request, but no one is able to work on it at the moment. The only immediate question I see is whether the option should be in the "Include" section or under the "Images" dropdown:

For a moment I thought the new Placeholder Material feature was related to this request. But when I checked the JSON I saw that there is no material block at all and of course no material name. Shame because I thought it was so close! Is the placeholder feature designed for a very different use case?

Is this feature still being considered or are the contributors focused on getting Basis/KTX support first?

From my perspective, https://github.com/KhronosGroup/glTF-Blender-IO/issues/770#issuecomment-705294497 still holds. I'd support this feature being added to the exporter, but do not have plans to work on it.

In my workflow I only want to export the custom properties saved to extras on each material. Since the extras are only exported when doing a full export, I added a new type to the export_materials:EnumProperty called ONLY_EXTRA. If anyone needs this before a proper solution is in place, let me know.

Closing, this is now fixed in master (will be in  Blender 3.1)


Thanks for making this!

I was using https://github.com/jctaoo/elecrun in my project, but the documentation is really bad and half in chinese, so i had to go off of a few examples and only barely got it working.
Is this project a replacement for https://github.com/jctaoo/elecrun? if not, which features would you say are missing?
Thanks.

Thanks! Didn't know about elecrun till now, but I think this plugin should cover most of what it does. Anything you need in particular?


[DNM] Logging all errors

We need to log more info when the app returns an error (limits types, errors in JSONP, ...)
Following the current way, we think to use the log4js and adding a new header with the errors info.

I have followed the same structure and we will need to refactor it in https://github.com/CartoDB/Windshaft-cartodb/pull/789
The final log:
[2017-11-27 16:06:58.172] [INFO] [default] - undefined HEAD localhost:6081/ 200 2 ms -> text/html; charset=utf-8 ({}) !!!{}

or

[2017-11-27 17:14:22.726] [INFO] [default] - undefined GET cdb.localhost.lan:8181/api/v1/map/6a38d0caaf7d53af1cfa09252d603e76:1509970291768/1/2/2/0.grid.json?api_key=7c0df56a8759a42fd1306019d4de7c5a9e784d7a&callback=grid 200 108 ms -> text/javascript; charset=utf-8 ({"authorizedByAPIKey":2,"authorize":3,"req2params":1,"getTileOrGrid":98,"getRenderer":50,"render-grid-json":48,"render":47,"encode":0,"total":6}) !!!{"statusCode":429,"message":"You are over platform's limits. Please contact us to know more details","name":"Error","type":"limit","subtype":"datasource","moreErrors":[]}

It is ready for CR


⚠ Samsung has degraded performance

In 40d6678, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2591 ms

Resolved: Samsung performance has improved in eeed7d2.


Show message when there is no activity matching the search (listview)  #1561

@llaske #1561 TODO.md

It's nice but the icon and the message appears during 1 second before loading the activity.
Would be nice to avoid it.

@llaske review the changes.

That's nice but because Sugarizer is use by children and some of them can't read, it's always better to avoid text.
I suggest to replace it by the spinner-light.gif already in the repo.

@llaske  there is no image folder in v2, so I've called the gif from outside, but there should be one isn't it ?

Yes

@llaske
so can I copy one to v2 ?

Yes copy it instead of referencing the original, the v1 directory is supposed to be removed at end

@llaske You can check the changes now.

Nice but please add only the spinner-light.gif from now

@llaske  yeah adding other assets will be make it messy for now !!!!

Good job. Thanks.


temporaly restore person-reidentification-retail models in index

lack of this model in index makes false positives in docs build,
like here https://github.com/opencv/open_model_zoo/pull/1184

I'm afraid you'll have to restore the doc pages themselves too, else there'll be broken links.

I'm afraid you'll have to restore the doc pages themselves too, else there'll be broken links.

yes, I also return back them