Shuffle data in iterative_train_test_split beforehand (with solution)

Hello I've successfully forked the scikit-multilearn repo, branched off of master, and completed this issue but I was unable to make a pull request. Could I please be given write access or someone with write access can implement my solution.
The iterative_train_test_split function does not have a shuffle parameter and therefore does not shuffle the data ahead of time. I understand that the underlying IterativeStratification object does have a shuffle property which is set to True if a random_state is provided. But that doesn't shuffle because the underlying _iter_test_indices doesn't perform shuffling unlike the sibling class KFold which extends the same _BaseKFold parent class. The consequences of this are that when calling iterative_train_test_split across several cross-fold iterations, the instance-inclusion is not remotely normally distributed. Using an example dataset with ground truth including 12 labels (and about 6,000 instances), here's a plot of the instance-inclusion for the test set (20%test_size) distribution across 100 CV iterations:

What this plot means is that across the CV iterations, there were several of the test set instances that were included every iteration (all 100 of them). This means that the CV folds were not balanced enough because several of the instances were included every single time and the other instances hardly at all. This means that when splitting the test dataset, we're mostly testing on the same instances over and over again rather than getting a balance of different instances in each fold. The converse being that we're also training on the same instances over and over again rather than training on a balance of the instances from the complete dataset. After shuffling using my solution, the instance-inclusion distribution is much more normal:

My solution additionally makes the deviation of label proportions in each fold from the original label proportions much smaller, improving the performance of the iterative stratification. Without shuffling, the test set proportions deviated by less than 5%
      "Label 1": 3.9850468575761893,
      "Label 2": 4.194394462998466,
      "Label 3": 4.462827268806928,
      "Label 4": 4.098111373194331,
      "Label 5": 3.7208254441759623,
      ...

But after shuffling the test set proportions deviated by less than 3%
      "Label 1": 2.1211386224760536,
      "Label 2": 2.0732622302730945,
      "Label 3": 2.0317471358023833,
      "Label 4": 2.8221312795976012,
      "Label 5": 2.370255420932089,
      ...

Here's my solution. Again I could just make a pull request since I already have the solution implemented but I need write access to this repo.
Change the function signature from this:
def iterative_train_test_split(X, y, test_size, random_state=None):

to this:
def iterative_train_test_split(X, y, test_size, random_state=None, shuffle=False):

Add a docstring description for the new parameter:
    shuffle : bool
        Whether to shuffle the data before splitting into batches. Note that the samples within each split
        will not be shuffled.

Add this code to the function before calling next:
    if shuffle:
        indices = list(y.index)
        check_random_state(random_state).shuffle(indices)
        X = X.loc[indices]
        y = y.loc[indices]

I haven't heard a response for a while. @ChristianSch I see you're a recent contributor. Are you able to either implement my solution or perhaps it'd be easier for you to give me write access so I can make a pull request?

Hi! Thank you for making us aware. I didn't see the issue. You should be able to make a pull request without access. Do you get an error?

@ChristianSch Yes I do get this error when I try to create a new branch:
fatal: unable to access 'https://github.com/scikit-multilearn/scikit-multilearn.git/': The requested URL returned error: 403

I called the branch shuffle locally and the command I used was git push origin shuffle. I've never contributed to a repository that I wasn't an explicit member of with write access so I don't have experience with making a pull request as a non-member. Is there an additional step I'm missing? I know I can make a pull request. But I don't seem to be able to create a new remote branch in this repo. And I need to create the branch before I can make the pull request.

Okay, got it. I think GitHub should present you with a big green button in your repo to create a PR. Otherwise you could try and see if GitHub knows about your branch anyhow on the pull requests page!
https://docs.github.com/articles/creating-a-pull-request-from-a-fork
Sent from Proton Mail for iOS
Am Donnerstag, 20. April 2023 um 05:20, Erik Huckvale @.***> schrieb:

@.***(https://github.com/ChristianSch) Yes I do get this error when I try to create a new branch:
fatal: unable to access 'https://github.com/scikit-multilearn/scikit-multilearn.git/': The requested URL returned error: 403
I called the branch shuffle locally and the command I used was git push origin shuffle. I've never contributed to a repository that I wasn't an explicit member of with write access so I don't have experience with making a pull request as a non-member. Is there an additional step I'm missing? I know I can make a pull request. But I don't seem to be able to create a new remote branch in this repo. And I need to create the branch before I can make the pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@ChristianSch As seen in the page you linked, it says I need write access in order to make a pull request:

Are you able to give me write access?

I could make you a contributor, but for the moment I would prefer not to to be honest. You need to create a pull request via the UI, not via the command line. We've had a multitude of pull requests from non-contributors so I'm a bit confused as to why you can't. Did you try via the UI?
You need to fork the project via the button, clone that forked repo, commit your changes there and then you should be able to create a pull request in the UI!

@ChristianSch Yes I have tried via the UI. My branch is not there. The name of my local branch is "shuffle" and as you can see, it's not an available branch

It's because I can't push my changes. I'm not trying to create a pull request via the commandline. I already know that I can create a pull request via the UI. But I need a remote branch first. I'm only attempting to create my remote branch via the commandlne.
I used git clone on the commandline to fork the repo, I created a local branch via git branch shuffle, and then I made the necessary changes on the local branch and committed them via git commit. It's creating a remote branch that's the problem. I get the error message above when I do git push origin shuffle. I cannot create a pull request if my branch does not show up in the UI. You saw in the very documentation that you linked that it said write permissions are necessary to make a pull request. Unless you know of some other way.

I think the problem is that you haven't properly forked the repo, as I don't see it in your repo list. You shouldn't clone this repo but your fork, that's what I meant ;) The button is on the top right.


admin: fix field mask parameter

Signed-off-by: Paul Gallagher<EMAIL_ADDRESS>
Commit Message: admin: fix field mask parameter
Additional Description: PR #16979 caused a regression where providing field masks without providing a resource did not work. This change makes it so that providing a bad field mask fails silently when a resource is not provided.
Risk Level: low
Testing: unit test added to detect regression so that it will be caught in the future.

@jmarantz could you take a look at this fix?


v0.3.0 fails to build on nightly

This doesnt happen on main - only nightly v0.3.0 which is the latest release.
   Compiling darwin-v7 v0.3.0 (/home/jayvdb/git-workspaces/github/franklin-ai/darwin-v7)
warning: the item `serde_yaml` is imported redundantly
 --> src/config.rs:3:5
  |
3 | use serde_yaml;
  |     ^^^^^^^^^^ the item `serde_yaml` is already defined by prelude
  |
  = note: `#[warn(unused_imports)]` on by default

warning: the item `Team` is imported redundantly
   --> src/client.rs:244:9
    |
243 |     use super::*;
    |         -------- the item `Team` is already imported here
244 |     use crate::team::Team;
    |         ^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: the item `serde_yaml` is imported redundantly
 --> src/config.rs:3:5
  |
3 | use serde_yaml;
  |     ^^^^^^^^^^ the item `serde_yaml` is already defined by prelude

warning: the item `Fake` is imported redundantly
   --> src/datasets.rs:869:16
    |
867 |     use super::*;
    |         -------- the item `Fake` is already imported here
868 |     use crate::client::V7Client;
869 |     use fake::{Fake, Faker};
    |                ^^^^

error: future cannot be sent between threads safely
  --> src/comment.rs:79:40
   |
79 |       ) -> Result<CommentThreadResponse> {
   |  ________________________________________^
80 | |         let response = client
81 | |             .post(
82 | |                 &format!("v2/teams/{}/items/{}/comment_threads", team_slug, self.id),
...  |
86 | |         expect_http_ok!(response, CommentThreadResponse)
87 | |     }
   | |_____^ future created by async block is not `Send`
   |
   = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/comment.rs:79:40: 87:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
  --> src/utils.rs:8:27
   |
6  |                 "Invalid status code {} {}",
   |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7  |                 $x.status(),
8  |                 $x.text().await?
   |                           ^^^^^ await occurs here, with `{}` maybe used later
   |
  ::: src/comment.rs:86:9
   |
86 |         expect_http_ok!(response, CommentThreadResponse)
   |         ------------------------------------------------ in this macro invocation
   = note: required for the cast from `Pin<Box<{async block@src/comment.rs:79:40: 87:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<CommentThreadResponse, anyhow::Error>> + std::marker::Send>>`
   = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:486:68
    |
486 |       async fn archive_dataset(&self, client: &C) -> Result<Dataset> {
    |  ____________________________________________________________________^
487 | |         let response = client
488 | |             .put::<String>(&format!("datasets/{}/archive", &self.id), None)
489 | |             .await?;
490 | |
491 | |         expect_http_ok!(response, Dataset)
492 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:486:68: 492:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:491:9
    |
491 |         expect_http_ok!(response, Dataset)
    |         ---------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:486:68: 492:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<datasets::Dataset, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:543:39
    |
543 |       ) -> Result<AddDataItemsResponse> {
    |  _______________________________________^
544 | |         let api_payload = AddDataItemsPayload {
545 | |             items: data,
546 | |             storage_name: external_storage,
...   |
559 | |         expect_http_ok!(response, AddDataItemsResponse)
560 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:543:39: 560:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:559:9
    |
559 |         expect_http_ok!(response, AddDataItemsResponse)
    |         ----------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:543:39: 560:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<AddDataItemsResponse, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:568:47
    |
568 |       ) -> Result<RegisterExistingItemResponse> {
    |  _______________________________________________^
569 | |         let api_payload = RegisterExistingItemPayload {
570 | |             dataset_slug: self.slug.to_string(),
571 | |             storage_slug: external_storage_slug,
...   |
582 | |         expect_http_ok!(response, RegisterExistingItemResponse)
583 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:568:47: 583:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:582:9
    |
582 |         expect_http_ok!(response, RegisterExistingItemResponse)
    |         ------------------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:568:47: 583:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<RegisterExistingItemResponse, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:616:21
    |
616 |       ) -> Result<()> {
    |  _____________________^
617 | |         let endpoint = format!(
618 | |             "v2/teams/{}/datasets/{}/exports",
619 | |             self.team_slug.as_ref().context("Missing team slug")?,
...   |
641 | |         Ok(())
642 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:616:21: 642:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/datasets.rs:637:33
    |
635 |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
636 |                 response.status(),
637 |                 response.text().await?
    |                                 ^^^^^ await occurs here, with `{}` maybe used later
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:616:21: 642:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<(), anyhow::Error>> + std::marker::Send>>`

error: future cannot be sent between threads safely
   --> src/datasets.rs:644:69
    |
644 |       async fn list_exports(&self, client: &C) -> Result<Vec<Export>> {
    |  _____________________________________________________________________^
645 | |         let endpoint = format!(
646 | |             "v2/teams/{}/datasets/{}/exports",
647 | |             self.team_slug.as_ref().context("Missing team slug")?,
...   |
653 | |         expect_http_ok!(response, Vec<Export>)
654 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:644:69: 654:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:653:9
    |
653 |         expect_http_ok!(response, Vec<Export>)
    |         -------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:644:69: 654:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<Export>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:662:64
    |
662 |       async fn list_datasets(client: &C) -> Result<Vec<Dataset>> {
    |  ________________________________________________________________^
663 | |         let response = client.get("datasets").await?;
664 | |
665 | |         expect_http_ok!(response, Vec<Dataset>)
666 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:662:64: 666:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:665:9
    |
665 |         expect_http_ok!(response, Vec<Dataset>)
    |         --------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:662:64: 666:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<datasets::Dataset>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:668:80
    |
668 |       async fn list_dataset_items(&self, client: &C) -> Result<Vec<DatasetItem>> {
    |  ________________________________________________________________________________^
669 | |         let response = client.get(&format!("datasets/{}/items", self.id)).await?;
670 | |
671 | |         expect_http_ok!(response, Vec<DatasetItem>)
672 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:668:80: 672:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:671:9
    |
671 |         expect_http_ok!(response, Vec<DatasetItem>)
    |         ------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:668:80: 672:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<DatasetItem>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:674:71
    |
674 |       async fn list_dataset_items_v2(&self, client: &C) -> Result<Item> {
    |  _______________________________________________________________________^
675 | |         let response = client
676 | |             .get(&format!(
677 | |                 "v2/teams/{}/items?dataset_ids={}",
...   |
683 | |         expect_http_ok!(response, Item)
684 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:674:71: 684:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:683:9
    |
683 |         expect_http_ok!(response, Item)
    |         ------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:674:71: 684:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<item::Item, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:686:68
    |
686 |       async fn show_dataset(client: &C, id: &u32) -> Result<Dataset> {
    |  ____________________________________________________________________^
687 | |         let response = client.get(&format!("datasets/{}", id)).await?;
688 | |
689 | |         expect_http_ok!(response, Dataset)
690 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:686:68: 690:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:689:9
    |
689 |         expect_http_ok!(response, Dataset)
    |         ---------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:686:68: 690:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<datasets::Dataset, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:744:35
    |
744 |       ) -> Result<WorkflowTemplate> {
    |  ___________________________________^
745 | |         let response = client
746 | |             .post(
747 | |                 &format!("datasets/{}/workflow_templates", self.id),
...   |
752 | |         expect_http_ok!(response, WorkflowTemplate)
753 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:744:35: 753:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:752:9
    |
752 |         expect_http_ok!(response, WorkflowTemplate)
    |         ------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:744:35: 753:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<WorkflowTemplate, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:770:26
    |
770 |       ) -> Result<Dataset> {
    |  __________________________^
771 | |         let workflow_id = workflow.id.as_ref().context("Workflow id not provided")?;
772 | |
773 | |         let endpoint = format!(
...   |
780 | |         expect_http_ok!(response, Dataset)
781 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:770:26: 781:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:780:9
    |
780 |         expect_http_ok!(response, Dataset)
    |         ---------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:770:26: 781:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<datasets::Dataset, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/datasets.rs:807:35
    |
807 |       ) -> Result<SetStageResponse> {
    |  ___________________________________^
808 | |         let filters = if filters.is_none() {
809 | |             SetStageFilter {
810 | |                 dataset_ids: vec![self.id],
...   |
826 | |         expect_http_ok!(response, SetStageResponse)
827 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:807:35: 827:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:826:9
    |
826 |         expect_http_ok!(response, SetStageResponse)
    |         ------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:807:35: 827:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<SetStageResponse, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/team.rs:131:70
    |
131 |       async fn list_memberships(client: &C) -> Result<Vec<TeamMember>> {
    |  ______________________________________________________________________^
132 | |         let response = client.get("memberships").await?;
133 | |
134 | |         expect_http_ok!(response, Vec<TeamMember>)
135 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/team.rs:131:70: 135:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/team.rs:134:9
    |
134 |         expect_http_ok!(response, Vec<TeamMember>)
    |         ------------------------------------------ in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/team.rs:131:70: 135:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<TeamMember>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/team.rs:138:90
    |
138 |       async fn list_annotation_classes(&self, client: &C) -> Result<TeamAnnotationClasses> {
    |  __________________________________________________________________________________________^
139 | |         // TODO: add query params
140 | |         let endpoint = format!("teams/{}/annotation_classes", self.slug);
141 | |         let response = client.get(&endpoint).await?;
142 | |
143 | |         expect_http_ok!(response, TeamAnnotationClasses)
144 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/team.rs:138:90: 144:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/team.rs:143:9
    |
143 |         expect_http_ok!(response, TeamAnnotationClasses)
    |         ------------------------------------------------ in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/team.rs:138:90: 144:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<TeamAnnotationClasses, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/team.rs:165:5
    |
165 | /     {
166 | |         let endpoint = format!("teams/{}/annotation_classes", self.slug);
167 | |         let response = client.post(&endpoint, class).await?;
168 | |
169 | |         expect_http_ok!(response, AnnotationClass)
170 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/team.rs:165:5: 170:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/team.rs:169:9
    |
169 |         expect_http_ok!(response, AnnotationClass)
    |         ------------------------------------------ in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/team.rs:165:5: 170:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<AnnotationClass, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/workflow.rs:303:5
    |
303 | /     {
304 | |         let response = if let Some(filter) = contains_str {
305 | |             client
306 | |                 .get(&format!(
...   |
317 | |         expect_http_ok!(response, Vec<WorkflowV2>)
318 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/workflow.rs:303:5: 318:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/workflow.rs:317:9
    |
317 |         expect_http_ok!(response, Vec<WorkflowV2>)
    |         ------------------------------------------ in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/workflow.rs:303:5: 318:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<WorkflowV2>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/workflow.rs:320:95
    |
320 |       async fn assign_items(client: &C, data: &AssignItemPayload) -> Result<AssignItemResponse> {
    |  _______________________________________________________________________________________________^
321 | |         let response = client
322 | |             .post(&format!("v2/teams/{}/items/assign", client.team()), &data)
323 | |             .await?;
324 | |         expect_http_ok!(response, AssignItemResponse)
325 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/workflow.rs:320:95: 325:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/workflow.rs:324:9
    |
324 |         expect_http_ok!(response, AssignItemResponse)
    |         --------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/workflow.rs:320:95: 325:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<AssignItemResponse, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/workflow.rs:327:67
    |
327 |       async fn get_workflows(client: &C) -> Result<Vec<WorkflowV2>> {
    |  ___________________________________________________________________^
328 | |         let response = client
329 | |             .get(&format!("v2/teams/{}/workflows", client.team()))
330 | |             .await?;
331 | |         expect_http_ok!(response, Vec<WorkflowV2>)
332 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/workflow.rs:327:67: 332:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/workflow.rs:331:9
    |
331 |         expect_http_ok!(response, Vec<WorkflowV2>)
    |         ------------------------------------------ in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/workflow.rs:327:67: 332:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<WorkflowV2>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

error: future cannot be sent between threads safely
   --> src/workflow.rs:338:29
    |
338 |       ) -> Result<WorkflowV2> {
    |  _____________________________^
339 | |         let response = client
340 | |             .put(
341 | |                 &format!("v2/teams/{}/workflows/{}", client.team(), self.id),
...   |
345 | |         expect_http_ok!(response, WorkflowV2)
346 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/workflow.rs:338:29: 346:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/workflow.rs:345:9
    |
345 |         expect_http_ok!(response, WorkflowV2)
    |         ------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/workflow.rs:338:29: 346:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<WorkflowV2, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `darwin-v7` (lib) generated 1 warning
error: could not compile `darwin-v7` (lib) due to 20 previous errors; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
error: future cannot be sent between threads safely
   --> src/datasets.rs:668:80
    |
668 |       async fn list_dataset_items(&self, client: &C) -> Result<Vec<DatasetItem>> {
    |  ________________________________________________________________________________^
669 | |         let response = client.get(&format!("datasets/{}/items", self.id)).await?;
670 | |
671 | |         expect_http_ok!(response, Vec<DatasetItem>)
672 | |     }
    | |_____^ future created by async block is not `Send`
    |
    = help: the trait `Sync` is not implemented for `core::fmt::rt::Opaque`, which is required by `{async block@src/datasets.rs:668:80: 672:6}: std::marker::Send`
note: future is not `Send` as this value is used across an await
   --> src/utils.rs:8:27
    |
6   |                 "Invalid status code {} {}",
    |                                      -- has type `core::fmt::rt::Argument<'_>` which is not `Send`
7   |                 $x.status(),
8   |                 $x.text().await?
    |                           ^^^^^ await occurs here, with `{}` maybe used later
    |
   ::: src/datasets.rs:671:9
    |
671 |         expect_http_ok!(response, Vec<DatasetItem>)
    |         ------------------------------------------- in this macro invocation
    = note: required for the cast from `Pin<Box<{async block@src/datasets.rs:668:80: 672:6}>>` to `Pin<Box<dyn futures::Future<Output = Result<Vec<item::DatasetItem>, anyhow::Error>> + std::marker::Send>>`
    = note: this error originates in the macro `expect_http_ok` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `darwin-v7` (lib test) generated 3 warnings
error: could not compile `darwin-v7` (lib test) due to 20 previous errors; 3 warnings emitted

This has now been fixed on main


Enable calling Database.Migrate upon model configuration completion

Hi,
Where is the right place to call Database.Migrate post model configuration?
I tried calling it in the OnConfiguring method but an InvalidOperationException is thrown, saying:

An attempt was made to use the context while it is being configured. A DbContext instance cannot be used inside OnConfiguring since it is still being configured at this point. This can happen if a second operation is started on this context before a previous operation completed. Any instance members are not guaranteed to be thread safe.

I'm working on a multi-tenant project where each tenant has a dedicated DB and connection string (provided dynamically by an external DI-provided service from an external DB).
Here's what my DbContext looks like:
public class AppDbContext : IdentityDbContext<User, Role, int>
{
  readonly IAppConnectionStringProvider _ConnStringProvider;

  public AppDbContext(DbContextOptions<AppDbContext> options) : base(options)
  {
  }

  public AppDbContext(DbContextOptions<AppDbContext> options, IAppConnectionStringProvider connStringProvider) : this(options)
  {
    _ConnStringProvider = connStringProvider;
  }

  protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
  {
    //TODO might be redundant
    if (optionsBuilder.IsConfigured)
      return;

    optionsBuilder.UseSqlServer(_ConnStringProvider.ConnectionString);

    Database.Migrate();
  }
}

In reference to @bricelam's comment, I'm requesting guidance on where to call Database.Migrate.
Further technical details
EF Core version: 2.2.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer

It should go in your application startup logic.

@smitpatel
How so? The connection string isn't known yet.

@bricelam may have better idea.
I put following in Configure method inside startup.cs and it initialized the database before running the app. You can achieve similar by putting in Program.Main method too.
using (var scope = app.ApplicationServices.CreateScope())
            {
                using (var db = scope.ServiceProvider.GetService<ApplicationDbContext>())
                {
                    db.Database.Migrate();
                }
            }

Program.Main() is a better place than Startup.Configure(). BUT we discourage using Migrate() at all during startup. It's typically part of deployment, not startup. Creating an admin page to create/update the database after deployment is another good option.
Be careful with database permissions. Most users SHOULDN'T be able to drop tables, etc.

@smitpatel
Either Main or Startup won't work for me, because the Tenant is not known yet, and additionally, there may be new tenants added.
@bricelam

Creating an admin page to create/update the database after deployment is another good option.

Sounds like what I'm gonna do. Gonna migrate/generate the tenant DBs on demand, as they're created by admin.
Thank you both!


typecasting isActive to boolean

#Request Template Witsml Explorer
Fixes type casting in # 232
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
This pull request does typecast of isActive property to boolean instead of string
...
Type of change
Put an x in the boxes that apply. You can also fill these out after creating the PR.

[ ] Bugfix
[ ] New feature (non-breaking change which adds functionality)
[x ] Enhancement of existing functionality
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Impacted Areas in Application
List general components of the application that this PR will affect:

Wellbore service - proper typecasting to isActive property

Checklist:
Put an x in the boxes that are fulfilled.

[ ] PR is related to an issue
[ ] I have added tests that prove my fix is effective or that my feature works
[ x] New and existing unit tests pass locally with my changes
[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[x ] I have used descriptive naming on components, functions and variables to avoid additional explanatory comments in the code
[ ] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Tested on my machine, works well.
Good change. The same should be done in #272, so I will update my pull request once this is merged.


Improved index handling

Codecov Report
Patch coverage: 40.00% and project coverage change: +0.71% :tada:

Comparison is base (93f6b2a) 40.61% compared to head (6955f44) 41.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   40.61%   41.33%   +0.71%
==========================================
  Files          18       18
  Lines        1492     1500       +8
==========================================
+ Hits          606      620      +14
+ Misses        886      880       -6

Flag
Coverage Δ

unittests
41.33% <40.00%> (+0.71%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

ocean_model_skill_assessor/accessor.py
34.14% <ø> (ø)

ocean_model_skill_assessor/main.py
19.41% <0.00%> (-0.08%)
:arrow_down:

ocean_model_skill_assessor/plot/line.py
39.13% <ø> (ø)

ocean_model_skill_assessor/stats.py
57.64% <57.14%> (+6.42%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Rename Extraction to Jobs and remove unused menu items

In the menu and buttons, change 'Add extraction' to 'New Job'.
In the 'New Extraction' form, change 'Extraction' to 'Job', and 'Extraction and Annotation' to 'Human in the Loop'.
Rename 'ML Pipeline' to 'Pipeline'.
Change 'Dashboard' to 'My Tasks'.

Remove the following menu items:

'ML Management'
Move 'ML Management -> Categories' and 'ML Management -> Reports' to the top level.
So, the menu items should be: 'Documents', 'My tasks', 'Dashboard', 'Categories', 'Reports'.

https://github.com/epam/badgerdoc/pull/856


[Feature] #40 added optional executable path

#40 Resolved

Codecov Report

Merging #46 (7918cf5) into main (8d05268) will decrease coverage by 0.04%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   74.38%   74.33%   -0.05%
==========================================
  Files           5        5
  Lines         203      226      +23
==========================================
+ Hits          151      168      +17
- Misses         52       58       +6

Impacted Files
Coverage Δ

s_tool/driver.py
87.50% <70.58%> (-5.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05268...7918cf5. Read the comment docs.


[Ast] Implement ascii, chr function in ast

Resolve : https://github.com/gluesql/gluesql/issues/798

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

140 of 144 (97.22%)  changed or added relevant lines in 7 files are covered.
19 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 98.263%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/executor/evaluate/function.rs
22
24
91.67%

core/src/executor/evaluate/stateless.rs
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

test-suite/src/tester/mod.rs
19
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
37856

Relevant Lines:
38525

💛  - Coveralls


Add base_latency and output_latency

Fixes #138
In the same vein, there is getOutputTimestamp (https://webaudio.github.io/web-audio-api/#dom-audiocontext-getoutputtimestamp), maybe I can have a shot in this PR as you prefer

note that I moved the methods from BaseAudioContext to AudioContext

Perhaps we can then find a real world example that utilizes the outputTimestamp, port it to Rust and see where that takes us?

Yup you're right, seems more reasonable to do like that. Though I have no idea of where to actually find such example.
I handled your comments, everything lives only in the AudioContext now!


Create Finding-Open-Source-Projects.md

#958
What does this PR do?
Added finding open source projects into tips folder

Duplicate with #958. Should be closed.
Thank you for the contribution 👍🏻

Duplicate with #973. Should be closed.
Thank you for the contribution 👍🏻

Ok

Ah yes the file was already created https://github.com/EddieHubCommunity/support/blob/main/tips/finding-open-source-projects.md
Thank you though 👍 and you still get the 🟩

Ah yes the file was already created https://github.com/EddieHubCommunity/support/blob/main/tips/finding-open-source-projects.md
Thank you though 👍 and you still get the 🟩

Eddie I feel any issue that has been solved should be closed immediately!

Every contribution adds value 👍🏻 And in opensource may happen that multiple people to work on a single issue. Than it's up to the maintainer to choose which PR to merge. That on the other hand depends on the amount of value added in the PR itself (description, title, etc)
As Eddie said - you still get the 🟩 for submitting the PR and it doesn't go away when said PR is closed


Update generic structures for topology graphs using single atom representations.

Related Issues: #431
Requested Reviewers: @lukasturcani
This PR aims to improve the representation of topology graphs by removing artificial chemistry and focussing on the assignment and connectivity of vertices. Hopefully this improves website load times and accessibility to users. All changes are made in the doc strings, and small changes to readability are also attempted for all topology graphs.

[ ] Add UNICODE colour maps between vertices and text.
[ ] Finish cages
[ ] Do for COFs
[ ] Do for examples of macrocycles, host_guests, complexes and polymers.

do you think it is preferable to have the linkers straight?

Other than that -- barring the change from COLOR1 and COLOR2 into some kind of color unicode square (if possible) -- LGTM

do you think it is preferable to have the linkers straight?

So, the vertices are a single bead, which means that if there is a 'bend' it is because of the geometry of the input topology graph.
This is actually most clear in the M24L48 topology graph, where I clearly did not get the math right on the vertex positions. A negligible effect when the building blocks are full chemical structures though.

Interesting -- i guess leave it then? I assume we dont wanna mess with the topology graph vertices

Also -- for me -- i do like the fact  that there was a non-abstract example of a real cage. It kind of felt more "real" to me. Do you think having both a real and an abstract example is worthwhile? Is it worth checking with other peeps which representation they would find most useful?

Interesting -- i guess leave it then? I assume we don't wanna mess with the topology graph vertices
I actually intend to fix this in the future, because ultimately, these small changes will not effect people's work because geometry optimisations should be done after. But future versions should have more symmetrical inputs, it just makes more sense to me.

Also -- for me -- i do like the fact that there was a non-abstract example of a real cage. It kind of felt more "real" to me. Do you think having both a real and an abstract example is worthwhile? Is it worth checking with other peeps which representation they would find most useful?

I think both have their place, but having both may be too much.  Perhaps we ask the discord, and maybe you can ask people in the Jelfs group?

Also, I think the ball and stick mode reminds users that they are not limited to any particular chemistry.

Yeah -- go ahead and ask on discord and I will press people in person when I see them

Based on discussions with others, and difficulty in making useful maps between vertex number and atom colours, I have decided to close this PR and issue.


Fix crash with empty map

When working on an uninitialized map (non created), avoid crash on close/show/hide and rejects to add a marker.

Nicely done! Thanks for your contribution @dragermrb

Thanks @hemangsk
I have others fix/changes in mind, but some of them are on v2 from @tafelnl (https://github.com/DutchConcepts/capacitor-google-maps/tree/next) and I'm not sure if you want to apply on v1.

Unified api
Marker icons (android and ios)
Api doc


[auto-bump] dependency by coffeegoddd

:coffee: An Automated Dependency Version Bump PR :crown:
Initial Changes
The initial changes contained in this PR were produced by `go get`ing the dependency.
```
$ cd ./go
$ go get github.com/dolthub//go@
$ go mod tidy
```
Before Merging
This PR must have passing CI and a review before merging.
After Merging
An automatic PR will be opened against the LD repo that bumps the bounties version there.

This PR has been superseded by https://github.com/dolthub/bounties/pull/2591

This PR has been superseded by https://github.com/dolthub/bounties/pull/2592


[Feature] Set default route via default_route with label_router

Is your feature request related to a problem? Please describe.
Currently the label router sends each log message to all routes that matches. Which results in duplicate logs in our Opensearch which is unneeded.
I want one global default route where all logs go that don't match with any route, so that I can save logs of some pods in a different Opensearch Index where they also get parsed without also having them in my default index.
Describe the solution you'd like
The label router plugin provides the default_route key. It sends all logs that did not match any route to the default route.
The more complex way would be to add a defaultOutputSelector and defaultFilterSelector to the fluentdConfig.
A simpler but more dirty way would be to match on output.fluentd or filter.fluentd if the name is default.
Additional context
Currently the operator creates this:
<match **>
  @id  main
  @type  label_router
  <route>
    @label  @db681e4cb763ca5b7cdbf9ab76f67bbe
    <match>
    </match>
  </route>
  <route>
    @label  @e92676ab47aeb48cfb39913e4291ba27
    <match>
      namespaces  traefik
    </match>
  </route>
</match>

But I want this:
<match **>
  @id  main
  @type  label_router
  default_route @db681e4cb763ca5b7cdbf9ab76f67bbe
  <route>
    @label  @e92676ab47aeb48cfb39913e4291ba27
    <match>
      namespaces  traefik
    </match>
  </route>
</match>

I am digging through the code and found where all the router stuff is managed. Afaik using (Cluster)FluentdConfig is not a good solution as each config gets its own route label. We would need to prevent different configs to overwrite the default output each time. Therefor my idea would be to add a DefaultOutputSelector and DefaultFilterSelector  to the FluentdSpec. This can then be used to match on ClusterOutput and ClusterFilter.


process method missing from dist?

In the source you have the very useful (and needed by me) method process which can be used to process the raw JSON received:
            self.json = self.process ? self.process(json) : json;

https://github.com/BosNaufal/vue2-autocomplete/blob/master/src/js/components/vue-autocomplete.vue#L293
Yet this method, and the call to it above seems to be nowhere to be found in the dist version of the code. Did something not get checked in properly, perhaps?
Also the version listed in the github package.json is 0.0.3 but the version I'm seeing when I install it is 0.0.4 -- is something perhaps out of sync here?

This PR fixes it: https://github.com/BosNaufal/vue2-autocomplete/pull/16

I noticed it was missing too, si I at least added it to my PR on a other topic: #17
Is it something else that is missing from the README?

Hi guys! @khalwat @madr
Thanks for giving me an issue~
That's all my bad~ but now you can use the proccess method from the package...~


Installation on Fedora 15

Hi there,
The README provides installation assistance for Ubuntu. I thought you might want feedback for other distros. Installation on Fedora 15 requires the installation of the qt-webkit-devel package:
yum install qt-webkit-devel

Thereafter, your awesome gem installs perfectly.
Thanks,
Sheldon.

I don't know if this is a known issue or not, but on Fedora 16 (I'm not sure of other versions) qmake is named qmake-qt4.
So in addition to installing the qt webkit development package you may also have to run:
sudo ln -s /usr/bin/qmake-qt4 /usr/bin/qmake

User symlinks in /usr/bin are very much a work-around. Perhaps the capybara-webkit build could be taught to use qmake-qt4 if present. But that's probably best requested as a separate issue?


feat: dagstore recovery when shard mounts cannot be found locally

The only case we have seen so far for dagstore corruption is when the index contains shards whose mounts cannot be found on disk. These heights are clearly unrecoverable until we resample over them. Because other components of the node assume these heights have already been sampled, there is currently no mechanism to "audit" the dagstore's indexes to ensure that we can retrieve all shards we think we have. Since we have the datahash for these shards, we can possibly use shrex as some sort of remote mount as a fallback when we cannot find them locally (but this is just a quick idea, needs research).

will be irrelevant after shwap


circle-ci keys

@conda-forge-admin, please update circle

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I updated the circle-ci deploy key and followed the project.


Pb to download container image from https://quay.io

Hi,
I have this Mc Afee message when i try to download the container image (docker pull quay.io/purestorage/pure-fa-om-exporter)
Current Rule Name: Allow File Size
Error Message: (10065) Maximum compression ratio limit reached.
Mac Afee seems take it for a zip bomb. (https://en.wikipedia.org/wiki/Zip_bomb)
Could you please re deploy a docker image without this problem

Hi @ligerard, it looks like the build trigger in quay did not handle the latest tag properly. Now the tag is properly referencing the latest build of the image, therefore you should be able to pull the image even without specifying the version tag.

Hi @genegr,
Thanks for your answer but i still have the problem. I send you the log when i try to replicate the  in our registry:
Most layers are copied sucessfully, but one of them fails with the error mentionned above.
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:125]: client for source registry [type: quay, URL: https://quay.io, insecure: true] created
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:135]: client for destination registry [type: harbor, URL: http://core:8080, insecure: true] created
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:168]: copying purestorage/pure-fa-om-exporter:[latest](source registry) to purestorage/pure-fa-om-exporter:[latest](destination registry)...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:196]: copying purestorage/pure-fa-om-exporter:latest(source registry) to purestorage/pure-fa-om-exporter:latest(destination registry)...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:343]: pulling the manifest of artifact purestorage/pure-fa-om-exporter:latest ...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:349]: the manifest of artifact purestorage/pure-fa-om-exporter:latest pulled
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:270]: copying the blob sha256:bdb74f431b025c77ce5d058c9d9aa7081480812bf7caba1eaa6f3aa2fa899fa9(the 1th running)...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:296]: the blob sha256:bdb74f431b025c77ce5d058c9d9aa7081480812bf7caba1eaa6f3aa2fa899fa9 already exists on the destination registry, skip
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:272]: copy the blob sha256:bdb74f431b025c77ce5d058c9d9aa7081480812bf7caba1eaa6f3aa2fa899fa9 completed
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:270]: copying the blob sha256:ca7dd9ec2225f2385955c43b2379305acd51543c28cf1d4e94522b3d94cce3ce(the 1th running)...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:296]: the blob sha256:ca7dd9ec2225f2385955c43b2379305acd51543c28cf1d4e94522b3d94cce3ce already exists on the destination registry, skip
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:272]: copy the blob sha256:ca7dd9ec2225f2385955c43b2379305acd51543c28cf1d4e94522b3d94cce3ce completed
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:270]: copying the blob sha256:c41ae7ad2b39813485dabd88ae2e5ddce71b71a47d19af1377b0251055edf373(the 1th running)...
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:296]: the blob sha256:c41ae7ad2b39813485dabd88ae2e5ddce71b71a47d19af1377b0251055edf373 already exists on the destination registry, skip
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:272]: copy the blob sha256:c41ae7ad2b39813485dabd88ae2e5ddce71b71a47d19af1377b0251055edf373 completed
2023-01-10T10:16:20Z [INFO] [/controller/replication/transfer/image/transfer.go:270]: copying the blob sha256:15b491bbc2fee14d5914da432332ef2992302d2895ae90466c778c259e643fe0(the 1th running)...
2023-01-10T10:16:29Z [ERROR] [/controller/replication/transfer/image/transfer.go:332]: failed to pushing the blob sha256:15b491bbc2fee14d5914da432332ef2992302d2895ae90466c778c259e643fe0, size 122654844: Put "http://core:8080/v2/purestorage/pure-fa-om-exporter/blobs/uploads/1dbfcfca-fcd2-4032-9ff7-d6924f8a2dc4?_state=c-

The following issue: "smaller image #25", should solve your issue.


Transparent Flutter background

Transparent Flutter background

Was done here: https://github.com/flutter/engine/pull/6172
Still need to add splash color support

FYI @dnfield

Possible gpu related issue?

Possible gpu related issue?

I don't know, I will try to test with iphone 6, 7.

Can you share the code you're using to present the FlutterViewController?

Can you share the code you're using to present the FlutterViewController?
I have a main view controller as image.
And I override viewDidLoad of that main view controller.  I add View of FlutterViewController into Map View.
On simulator, It is perfect.

`override func viewDidLoad() {
super.viewDidLoad()
    mapView.isExclusiveTouch = false
    mapView.touchDelegate = self
    initFlutterViewController()`

`func initFlutterViewController() {
flutterViewController = storyboard!.instantiateViewController(withIdentifier: "flutterview") as? FlutterViewController
addChildViewController(flutterViewController)
flutterViewController.view.translatesAutoresizingMaskIntoConstraints = false
mapView.addSubview(flutterViewController.view)
    let horConstraint = NSLayoutConstraint(item: flutterViewController.view, attribute: .centerX, relatedBy: .equal,
                                           toItem: mapView, attribute: .centerX,
                                           multiplier: 1.0, constant: 0.0)
    let verConstraint = NSLayoutConstraint(item: flutterViewController.view, attribute: .centerY, relatedBy: .equal,
                                           toItem: mapView, attribute: .centerY,
                                           multiplier: 1.0, constant: 0.0)
    let widConstraint = NSLayoutConstraint(item: flutterViewController.view, attribute: .width, relatedBy: .equal,
                                           toItem: mapView, attribute: .width,
                                           multiplier: 1.0, constant: 0.0)
    let heiConstraint = NSLayoutConstraint(item: flutterViewController.view, attribute: .height, relatedBy: .equal,
                                           toItem: mapView, attribute: .height,
                                           multiplier: 1.0, constant: 0.0)

    mapView.addConstraints([horConstraint, verConstraint, widConstraint, heiConstraint])

    flutterViewController?.view.isOpaque = false
    flutterViewController?.view.isExclusiveTouch = false
    flutterViewController?.view.backgroundColor = UIColor.clear
    flutterViewController?.view.layer.backgroundColor = UIColor.clear.cgColor
    flutterViewController?.view.subviews.forEach{
        $0.isOpaque = false
        $0.backgroundColor = UIColor.clear
        $0.layer.backgroundColor = UIColor.clear.cgColor
    }

    flutterViewController?.splashScreenView.isOpaque = false
    flutterViewController?.splashScreenView.backgroundColor = UIColor.clear
    flutterViewController?.splashScreenView.layer.backgroundColor = UIColor.clear.cgColor
    GeneratedPluginRegistrant.register(with: flutterViewController!)
}`

// Main View Controller.

//Simulator iOS (iphone 5s 10.0)

Possible gpu related issue?
I had same this problem with iphone 6.

I can reproduce this, continuing to look into it.

Culprit is here: https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Source/FlutterView.mm#L48
This is done per Apple recommendation for performance reasons.  It may be nice to make it user configurable - I don't think there's a good way that even an add to app user could change this today.  Looking into that.

I'm proposing adding a property to FlutterViewController called viewIsOpaque to address this in the linked PR.

I'm proposing adding a property to FlutterViewController called viewIsOpaque to address this in the linked PR.
The reason your existing code doesn't work is that we repeatedly set this property to YES in layoutSubviews, which would override what you're trying to set in your code.

Oh, I understand the reason, thanks you. If I can adjust it then better.

The key for me in getting a transparent FlutterView to work and get rid of the black background is adding the following line to the ViewController.
flutterViewController.modalPresentationStyle = UIModalPresentationStyle.overCurrentContext
Hope this helps!

Thank you @searchy2 save my day.


[Question] How to clean a form inside the modal when closing

Hi guys,
I have a Modal and a form inside it, if the user closes the modal I would like to clean / reset the form inside Modal in the 'onClose' function, how do I do this?

onClose: modal => {
  modal.querySelector('form').reset();
},

onClose: modal => {
  modal.querySelector('form').reset();
},

Thank you friend. It helped me a lot.


Normalize token values used for composite parameters per 1366 schema design

Currently tokens associated with composite parameters use the legacy design, leading to less-than-ideal storage efficiency, and performance impacts for ingestion from the extra indexes on the row_id column.
Migrate composites to use the normalized schema design from issue #1366 (common_token_values and TOKEN_VALUES_V) . This requires some careful planning, because additions to common_token_values must be combined with the inserts required for the non-composite parameters so that they can be sorted prior to insertion to avoid deadlock issues when processing bundles in parallel.
The new design must collect all the composite values and attach to the transaction-data object (see new token-value storage from 1366). This will also greatly improve performance by reducing the number of individual database operations.

Stretch goal for 4.6.0


:ambulance: fixed: fixed Iconoir v7.0.0+ update error

fix V7.0.0+ update error for new Icon Style
update README.md for new Icon Style

@sammarks  @mkaulfers  Hi, guys , any ideas ?

@sammarks @mkaulfers Hi, guys , any ideas ?

Can you specify what you're asking?

@sammarks @mkaulfers Hi, guys , any ideas ?

Give me just a minute to have a look at this.

@YoRolling thanks for the contribution! I'll get a new release up ASAP.

🎉 Thank you so much.


Uninstall the Windows agent leaves services installed and running

Step 3a: Uninstall the Windows agent
Both of the following methods remove the agent, but they do not remove the C:\Program Files\AzureConnectedMachineAgent folder on the machine.

It leaves services installed and running
PS C:\> get-service himds

Status   Name               DisplayName
------   ----               -----------
Running  himds              Azure Hybrid Instance Metadata Service

PS C:\> get-service ExtensionService

Status   Name               DisplayName
------   ----               -----------
Running  ExtensionService   Guest Configuration Extension Service

PS C:\> get-service GCArcService

Status   Name               DisplayName
------   ----               -----------
Running  GCArcService       Guest Configuration Arc Service

That's truly, unbelievably bad. How can it be called 'Uninstall the Windows agent', when that's not actually what happens!!!
I...

reinstalled Azure Connected Machine Agent

stopped these three services

uninstalled Azure Connected Machine Agent
This

removed the services

removed C:\Program Files\AzureConnectedMachineAgent folder

I suspect manually stopping these services before uninstalling is the correct procedure.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7fa48880-0b59-48c1-8f28-ae479e7be559
Version Independent ID: 8f513f59-0396-8d02-ee44-ef28a6ae67e3
Content: Managing the Azure Arc-enabled servers agent - Azure Arc
Content Source: articles/azure-arc/servers/manage-agent.md
Service: azure-arc
Sub-service: azure-arc-servers
GitHub Login: @johnmarco
Microsoft Alias: johnmarc

@anwarmahmood1
Thanks for your feedback! We will investigate and update as appropriate.

Hello @anwarmahmood1 . We are unable to reproduce this issue. Please file a support ticket to have them address it. Thank you. We will now close this issue.
#please-close


aws[patch]: support ChatBedrock(max_tokens, temperature)

does the standard params standard unit test still fail? Could we un-xfail it after this?

which test


dbl has no attribute client

Can anyone solve this
When I run the cog
The error is dbl has no attribute client

Refer to dblpy docs and see what the actual class for dblpy client is.


Venafi TPP Support for OAuth when authenticating with a username and password

Cert-manager's Venafi TPP issuer do not seem to support OAuth mechanism for authenticating. With TPP 22.4, the API key authentication method was deprecated in favor of OAuth. when authenticating with a username and password, you will see the following error on the Issuer:
conditions:
- message: 'Failed to setup Venafi issuer: error building client: error creating
    Venafi client: vcert error: your data contains problems: auth error: unexpected
    status code on TPP Authorize. Status: 401 API keys are deprecated. Instead,
    you should be using an API integration and a vedauth/Authorize endpoint. See
    the getting a token help topic.'

This error was reproduced with both cert-manager 1.9.1 and 1.11.0.
cert-manager should use the /vedauth/authorize/oauth endpoint:
POST https://tpp.venafi.example/vedauth/authorize/oauth
{
   "client_id":"MyApp",
   "username":"userid",
   "password":"xxxx",
   "scope":"certificate:manage"
}

Response
HTTP/1.1 200 OK
{
   "access_token":"example-access-token",
   "expires":1565028229,
   "identity":"local:{198c2d48-9e79-4f10-b871-e2f109476032}",
   "refresh_token":"example-refresh-token",
   "scope":"certificate:manage",
   "token_type":"Bearer"
}

/kind feature

Any update if this feature is currently available or future enhancement?

We have the same problem.

It has come to my attention that the username and password authentication in cert-manager will start breaking for people using TPP 22.2, and we need to quickly figure out a way to migrate from the old "API key" method to the OAuth method ASAP.
Technically, it is totally feasible to start using the OAuth method (i.e., authenticating with a username and password with /vedauth/authorize/oauth) instead of the deprecated "API key" method (i.e., authenticating with a username and password with /vedsdk/authorize). Although vcert doesn't make it easy (as raised in https://github.com/Venafi/vcert/issues/265), it is still possible to use the newer OAuth authentication with a username and password:
c, _ := tpp.NewConnector("https://tpp.example.local", "\VED\Policy\Certs", false, nil)
auth := endpoint.Authentication{
		Scope:       "manage:certificates",
		ClientID:          "vcert-sdk",
		User:     os.Getenv("TPP_USER"),
		Password: os.Getenv("TPP_PASSWORD")},
})
resp, _ := c.GetRefreshToken(&auth)
auth.AccessToken = resp.Access_token
_ := c.Authenticate(auth)

My main concern is that migrating from the "API key" method to the OAuth method will break people: unlike with the "API key" method, OAuth requires a client ID and a scope, and requires that an API Integration is associated to the given username.

/remove-lifecycle stale

Hi Everyone.
Has there been any progress made on the authentication via the new endpoints by specifying username, password etc, instead of having to specify the bearer token upfront?
We were previously using the username and password route, which went via the old endpoints.
We have now updated the tpp-secret manually to remove username and password and to add the bearer token.
However,  our TPP instance gives us a token with a 90 day expiry. So we are going to have to update the tpp-secret every 80-90 days to ensure that there is no downtime. Ideally we would like to stay away from manual processes.

Different options.  First one, increase in venafi, the validity time of your token.  It will give you time but you will have to renew it anyway.  Do some code, by using venafi api or vcert (venafi cli) to automate your token renewal.  It's something that can be pretty easy with vcert.  Other solution, if the budget allows.  See the offer of Jestack for commercial license.

/reopen

/remove-lifecycle rotten

A beta-release is now available which contains the fix for this issue. Please test and feedback if you have time.

https://github.com/cert-manager/cert-manager/releases/tag/v1.16.0-beta.0

Will do. Thank you!
On Thu, Sep 26, 2024 at 4:05 PM Richard Wall @.***>
wrote:

A beta-release is now available which contains the fix for this issue.
Please test and feedback if you have time.

https://github.com/cert-manager/cert-manager/releases/tag/v1.16.0-beta.0
—
Reply to this email directly, view it on GitHub
https://github.com/cert-manager/cert-manager/issues/4653#issuecomment-2377833896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AETUUGDJAGBLAQ2KP7OLWMLZYRSJZAVCNFSM6AAAAABJQKNSZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXHAZTGOBZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

A beta-release is now available which contains the fix for this issue. Please test and feedback if you have time.

https://github.com/cert-manager/cert-manager/releases/tag/v1.16.0-beta.0

confirmed, username/password now works with oauth

i'm testing v1.16.2 with username/password and i'm getting the following error:
"Failed to setup Venafi issuer: error building client: tppClient.GetRefreshToken: unexpected status code on TPP Authorize. Status: 400 Bad Request"

I tested with a token generated from the same username/password and it works correcltly

I have some doubts that client-id is causing the issue, how can i specify which client-id to be used ( default is cert-manager) based on the documentation


Automatic Autoload creation

As per title, adds automatic Autoload creation for Transitions.gd and FancyFade.gd.
Thank you for your work!

@nightblade9 sorry, I've realized only now that I forgot to remove the Autoload addition part from the usage section in readme. I suggest to delete that part to not confuse the users

Done, thank you for the reminder!


cni enabled: InitContainer fails pod security policy with readOnlyRootFilesystem=false

Bug description
Fresh install of kubernetes on GKE with pod security policies enabled. Installed Istio 1.5.1 with cni enabled as per instructions (including platform setup firewall change):-
istioctl manifest apply --set values.cni.cniBinDir=/home/kubernetes/bin
--set components.cni.enabled=true
--set components.cni.namespace=kube-system
My pod security policy for app pods has restriction of readOnlyRootFilesystem=true.
Deployed app fails to start with..
pods "load-68b699c7bb-" is forbidden: unable to validate against any pod security policy: [spec.initContainers[0].securityContext.readOnlyRootFilesystem: Invalid value: false: ReadOnlyRootFilesystem must be set to true]
On face of it, looks like istio-validation initcontainer has readOnlyRootFilesystem: false.
Expected behavior
With cni enabled, I expected the initcontainer not to require elevated permissions.
Steps to reproduce the bug
See above
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl...
client version: 1.5.1
control plane version: 1.5.1
data plane version: 1.5.1 (2 proxies)
kubectl...
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:16:51Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-gke.27", GitCommit:"145f9e21a4515947d6fb10819e5a336aff1b6959", GitTreeState:"clean", BuildDate:"2020-02-21T18:01:40Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}
How was Istio installed?
istioctl 1.5.1 on Windows 10 in powershell window. Also tried in GKE CloudShell.
Environment where bug was observed (cloud vendor, OS, etc)
Client: Windows 10 and GKE CloudShell. against GKE

cc @lambdai I think you were working on a similar issue? Or @rlenglet

@wandrar can you please post a comment with the pod spec of one failing pod?

The istio-proxy always had readOnlyRootFilesystem: false.
But the istio-init container was never set with that setting.
The change to inject istio-init when Istio CNI is enabled is a recent change to work around Istio CNI not being ready sometimes when a pod starts.
So the fix would be to add readOnlyRootFilesystem: false to istio-init, at least when Istio CNI is enabled since the container does very little in that case, and doesn't need to write into the filesystem.

Hmmm that's weird. In the release-1.5 branch, this is already OK: https://github.com/istio/istio/blob/release-1.5/manifests/istio-control/istio-discovery/files/injection-template.yaml#L68

Keeping this issue open until the cherrypick into release-1.5 is merged: https://github.com/istio/istio/pull/22736.


Does the API blur location before display?

@Steven-Eardley is passing the location data precisely - so the API needs to blur it.

This issue was moved to OAButton/backend#151


Bug on Chrome 59, the pagination is active without pushing any buttons and doesn't scroll the slides

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: EXACT RELEASE VERSION OR COMMIT HASH, HERE.

Chrome's version 59.0.3071.109 (Build) (a 64 bit) on linux
What you did
EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE.
Expected Behavior
EXPLAIN WHAT IS TO BE EXPECTED, HERE.
Actual Behavior
EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE.
go to your demos page and move the mouse on the second carousel "Responsive / Fullscreen + Pagination" also in others with more visible slides and pagination
the slide will follow the mouse without scroll the slide to the next or previous one and without pushing on any buttons
http://idangero.us/swiper/demos
bye

I'm trying more tests
now in some demos it is ok but on "Slides Per View / Carousel Mode" I get this problem
try to do some drag tests on the first carousels then go down and you will see that the scrolling will have more problems then it will stop to work

on firefox all work well

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue

Hi
I've tested now and I get the same problem on chrome 62
go here
http://idangero.us/swiper/demos/
and check the demo "Centered Slides" or "Auto Slides Per View / Carousel Mode"
push the left button of your mouse over the carousel and move the mouse left and right, then stop to push the button and continue to move the mouse left and right, the slides will continue to following the mouse direction left and right.
In some case all is ok in others I get often this problem
however I can easily reproduce it on your site

It is because the demo runs in iframe

ok thanks
so you can close this topic
bye


wavpack: disabled asm for Darwin

@codyopel
The current version of WavPack is not compatible with clang. This commit works around it by disabling asm and a small patch.
https://github.com/dbry/WavPack/issues/3
Tested on OX 10.10.5.

@taku0
If it is an issue with clang use stdenv.cc.isClang, not isDarwin

@codyopel
Thanks. Updated.


dsize doesn't seem to be registering

See screenshot. Dont know if I'm doing something wrong but changing dsize doesn't seem to make a difference. In the last release increasing dsize did seem to increase resolution.

output from the processor seems to also be restricted to 512x512. Just curious if this is a limitation of the model or if its a fault in the code. As I said the previous version of your release did seem to accept higher size values.

I admit I never fully understood that one, all it does is set the size for the cropper's affine transform functions, definitely not my area of expertise.
The network image input has always been just 256x256 which seems what it's trained at, so the image itself always gets resized to that anyway. It's possible that before there was code that resized it back or something, which isn't very useful anymore, as the compositor node uses the original image to composite on now anyway.

So am I correct in assuming the resolution of the output face animation is locked at 512x512? regardless if the input video is 1080p. It still outputs a 1080p video but the facial area is low resolution. This is most apparent with a close up shot.
https://github.com/user-attachments/assets/ee55d8c3-299e-4e7a-aef1-c3815781d588

Hi yeas I'm also trying to work with two 1024x1024 sources and am trying to find out exactly how that LivePortrait Cropper now works. I currently have 'scale' on arbitrary 1.8 to minimize the offset but still have some offset. I zeroed the ratios. I have dsize on 1024 but like described here its seems 'LivePortrait Process' is limited to 512?
Is the 'LivePortrait Cropper' a node that's added by this repo or is the parameters from the main model repo?

Same here. I've tried everything, cant seem to output higher than 512x512 for the face patch.


Remove introspection endpoint and add MTLS role checks

Fixes #44
Fixes #43

remove introspection endpoint
implement signature and certificate binding checks in resource api

The certificate handling is spread across many files, when it's turned into a library it should be encapsulated in a single class, but I think this works for now.

Possibly, we'll see when we get to it. I prefer functions to classes unless they're needed, makes for simpler code

The certificate handling is spread across many files, when it's turned into a library it should be encapsulated in a single class, but I think this works for now.

Possibly, we'll see when we get to it. I prefer functions to classes unless they're needed, makes for simpler code

The code has evolved over time, and certificates are decoded in auth.py, extension ASN.1 structures encoding in certificate_extensions, OID constants repeated in a few files, and the tests construct certs with extensions. I just meant it should be brought together in a single python module?


Using Qt instead of boost

Hello,
the labplot team is thinking about supporting mdf files in their application. Labplot is using Qt and we would like to get an additional dependency like boost and so the idea would be to replace boost by Qt equivalents. In this case I would create a library interface (source, header file) for boost and qt and in the cmake file the correct files will be selected. So that means your mdf lib depend only on that library interface files and anymore directly on boost.
Mostly locale and endian have to be replaced.
The current comparsion and alternative Qt function selection is done here: https://invent.kde.org/education/labplot/-/issues/293
What do you think about this? I will do the implementation of this procedure.

Hello
The MDFLIB repository includes a library and a sub-project MdfViewer (wxWidgets). The viewer application can easily be moved to its own repository.
The library is dependent on 3:rd party libraries as boost, expat, utillib and zlib.
The boost library solve the big/little endian byte order issues. Instead of involving Qt, I suggest that the byte order stuffing is replaced by plain C code instead. This will solve the main boost dependency.
The UtilLib constains a lot of XML (expat) and time conversion routines. It also include error logging functions. The time and logging functions can be included (copied) into the library.
Remains from the UtilLib is the XML (expat) dependency. XML is heavily used in the MDF4 Meta data block (MD block).
The ZLIB is used for compressing/decompressing the MDF4 data blocks. I don't see that this dependecy can be removed.
Conclusion
I can do the above changes removing dependecies of the utillib and boost library. Remain dependency of expat and zlib.
Is this an acceptable solution?

FYI
I have started to remove dependecies. Boost and utilib is OK. Some problems with XML and Expat. I'm 1-2 days left.

Hello. Thank you very much for the changes! I think boost is the biggest dependency which might be great to get rid of it. Zlib is used also for hdf5 so it is already a dependency of labplot so it should not be any problem. I think you don't have to move the viewer out, because when building without the viewer then wxwidgets and so on is not needed, which makes it fine.
If I can help you with something I would be happy to do. I will let you know tomorrow about the changes for building on linux

Are you using any codestyle template like clang-format?

I have removed the utillib dependency in mdflib. UtilLib uses boost. MdfLib should only depend on EXPAT and ZLIB.
I'm using the JetBrain CLION (Editor) and TeamCity (CI) with local agents. The latter due to the unit tests require local MDF files that cannot be exposed for external users.
I'm using the Google C++ coding standard. The Editor has built-in clang which is good enough so far

I have removed the utillib dependency in mdflib. UtilLib uses boost. MdfLib should only depend on EXPAT and ZLIB. I'm using the JetBrain CLION (Editor) and TeamCity (CI) with local agents. The latter due to the unit tests require local MDF files that cannot be exposed for external users.
I'm using the Google C++ coding standard. The Editor has built-in clang which is good enough so far

Did you push the changes?

No. I'm removing the boost dependency as well.

Ah ok thanks. Thank you for your work and helping to get mdflib cross compiled

I have checked in the changes that should remove the boost and utillib dependencies. We need to merge in the changes from you. I have added you as collaborator.
Best Regards
Ingemar Hedvall

Thank you for your effort! I can close this one now


[Feature]: Fix the subject of invitation email

What is the feature?
The subject of the user invitation email contains an extra '}'.
I want to make it a correct subject line.
invite.blade.php line 1
subject = "Invitation to access {{ $site_name }}}"
Version
3.0.6

Thanks a lot for opening this issue! Would you like to submit a PR for this?

Sorry, this issue wasn't about the user extension, but about the Tasty Igniter itself.
I will submit the issue again.


update file to set the virtual box

the file include:

pipfile
2)pipfile.lock
3)folder of beyond_tutorial withe python seting
file f
5)manage.py
6)setup.sh

up:
Adding a Django development environment

Setup [Pipenv][1] to install and manage Django and other Python
dependencies
Bootstrapped an empty [Django][2] application
Setup Vagrant to automatically bring our application up as well as
make it accessible from a web browser
After running vagrant up the application can be accessed at:

http://<IP_ADDRESS>:8000/
Note: Most changes had been auto-generated, only Vagrantfile and
steup.sh had been edited manually.
[1]: https://github.com/pypa/pipenv
[2]: https://www.djangoproject.com/


Introduce usage reporting signature and its components

PR and description WIP
Addressing @glasser 's comment https://github.com/apollographql/federation/issues/1841#issuecomment-1122744610
Related: https://github.com/apollographql/federation/issues/1841
cc @o0Ignition0o
TODO:

[x] Fill out READMEs
[x] Ensure compatibility between AS and router versions (these are copied from AS)
[x] Ensure completeness. Do we need to incorporate this comment as well? https://github.com/apollographql/federation-rs/blob/572120fdbf957a0640cb946958b9fe52207584ac/federation-2/router-bridge/js-src/plan.ts#L141
[ ] ~Consider switching to stripIgnoredCharacters now. This affects tests (spacing, commas). @glasser maybe you can help me understand the downstream impact w.r.t. Studio that this would have.~

Consider switching to stripIgnoredCharacters now. This affects tests (spacing, commas). @glasser maybe you can help me understand the downstream impact w.r.t. Studio that this would have.

I spoke with @timbotnik and @zionts about this. We should still plan on pairing this with other changes that affect the signature, of which they have one (not stripping the contents of lists and objects) planned for the next few months hopefully. So no need to do this today.

This looks great! 🎉
I tried to depend on it to see if the router bridge tests still pass, and I m hitting this error:
npm i<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>npm ERR! code E404
npm ERR! 404 Not Found - GET<EMAIL_ADDRESS>npm ERR! 404
npm ERR! 404<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404 This package name is not valid, because
npm ERR! 404  1. name can only contain URL-friendly characters
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR!      /Users/ignition/.npm/_logs/2022-05-17T10_14_22_476Z-debug-0.log

Happy to pair with you so we can try to wire the bridge against this changeset, if the router-bridge tests pass, we should be good!

@trevor-scheer I just did, it looks super neat!


Echo is undeclared type

Solution for me was to go to the file containing Echo, then making the class public.

You can download the source code and paste it into the project.


Backend for prl-950, 968, 924

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-950
https://tools.hmcts.net/jira/browse/PRL-968
https://tools.hmcts.net/jira/browse/PRL-924
Change description
Backend deployment for CCD changes
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing, will be merged as part of https://github.com/hmcts/prl-cos-api/pull/225


Waymo dataset Pillar version?

Thanks to the author for open sourcing TransFusion, but for the Waymo dataset I only found the Voxel version. Can you share the train configuration file related to the pillar version on the Waymo dataset? Thank you very much!

Sorry I haven't try pillar-backbone on waymo.

Thanks to the author for open sourcing TransFusion, but for the Waymo dataset I only found the Voxel version. Can you share the train configuration file related to the pillar version on the Waymo dataset? Thank you very much!

Hi, Have you ever tried the pillar version on waymo, in my experiment, the result of pillar version on waymo is so bad


topic_list: Fix search box not focused in expanded state.

We only check topic_search_focused_before_build if the
search box is visible.
I checked:

Search focused on clicking more topics
Search remains focused when new topic is created and search is focused while topic list is expanded.
Compose remains focused when new topic is created and compose is focused while topic list is expanded.

Merged, thanks @amanagr!


Approvals / authentication urls not showing on mobile

While on mobile, i can't see the approvals and sign in / sign out buttons.

I don't use mobile so this isn't a priority to me. @gemantzu you can tackle this one or we can close it. I'm not going to invest time in improving admin.

@gemantzu @doomspork I'll have a look a this one!

You're the best @tajchumber!

Thank you @tajchumber , you are awesome!

@gemantzu can you give more details or a few screenshots of what's missing? and where?


Adds the member geometry type to the label of non-downloaded relation members

With #5396 merged, users can now manually download individual members. The issue is that that it is difficult to tell what the member is before it is downloaded. While the member's role is shown in the input field and its index is indicated by its list order, its geometry type is available but hidden. This PR adds the type (node, way, or relation) to the non-downloaded member's label. This should make it slightly easier for users to determine what members to try downloading, as well as surface potential mistakes such as node members with north or south roles.
A potential drawback is that novice users may be confused by the node/way terminology since iD hides it behind points, lines, and areas, but I don't think that novice users will be editing complex relations anyway.

A potential drawback is that novice users may be confused by the node/way terminology since iD hides it behind points, lines, and areas, but I don't think that novice users will be editing complex relations anyway.

I'm ok with this - we use the Node/Way terminology in a few other places that are more intended for advanced users.