Ability to index documents incrementally

This patch provides the ability to add documents incrementally by using a new add method in conjunction with an identifyItem function. It does this by keeping track of the item ids in the indexmap dictionary where the values are the position into the index of where the item lives.
0001-Provide-the-ability-to-incrementally-add-to-the-inde.patch.zip
Additionally, this patch moves grunt into devDependencies instead of as a dependency.
0002-Make-grunt-a-devDependency.patch.zip

I'm reading it, it look good at first.
I have a few concern about two scenario.
A) Completely swap list of item for a different one (say swap between books or movies). I see you remove overwrite option in favor of a merge mode.
B) Support for a source that is simply a list of string. In that case the native item won't have an id. The cached item may have one. But that will be the whole string.

However I see good use of merging say if server provide additional items as result are typed. So it's definitively a good direction.

Ok so if I understand the patch

_prepSource now always overwrite. This is done by clearing the collection then calling add on each items. Part of the prep source loop is now moved to a _prepItem.

add method is added. Which call _prepItem then act as a update-or delete operator.

Out of those:
I think the 3rd argument nb_indexed off add is a bit unfortunate. It prevent using the method easily and could be computed in the indexmap[itemId] === undefinedcase.
I think options.identifyItem could have a default value of null.
In which case add is now append only. That would provide maximum backward compatibility because we did not request that items have an id field.

Thanks for taking a look at this @jeancroy!
Your assessment above is correct, except that add will never delete, it will only either append or replace.
I have addressed your two comments in the attached patch here. I have removed the nb_indexed parameter from the add method, since it is easily computed inside the add method. Also, identifyItem is null by default, which means that all calls to add will just be appended to the end of the index and no duplicate item detection will take place.
0001-Provide-the-ability-to-incrementally-add-to-the-inde.patch.zip

Opened a PR for clarity: https://github.com/jeancroy/FuzzySearch/pull/6

Thank you for this contribution !
Is there other aspect you think this project could improve ?

Thanks for getting this merged @jeancroy ! We are using this library in a few projects, and may have more suggestions in the future. For now, it is working very well for us.

This PR apparently has backwards incompatible changes. FuzzySearch stopped working on my project with:
Uncaught TypeError: Cannot read property 'fields' of undefined

This is also happening on the demo.

@mrkishi really sorry I should have tested better.
I'll investigate & fix tomorow

Hi @mrkishi thanks for your report !
I think it is now fixed.
We preallocated the array in _prepSource but then pushed to the end of the array in add.
So the whole preallocated space is undefined, which cause error when reading in loop
I've added a counter for item that are actually in use.

That was way too fast, thanks! 💯
Took me days to notice it in the first place (since we don't usually update git-based dependencies).
In any case, it's on me for not pinning on a specific commit.


Throttling meter size?

The docs say the rate limit on Direct Methods 160KB/sec/unit for a "4KB throttling meter size".
What is a "throttling meter size"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec6fc6a5-9bf6-889e-075d-b5b009e67d1f
Version Independent ID: f3d6fa56-a494-fec8-50e3-f8682c90ac42
Content: Understand Azure IoT Hub quotas and throttling
Content Source: articles/iot-hub/iot-hub-devguide-quotas-throttling.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

@cocowalla Thank you for your feedback! We will review and provide an update as appropriate.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

the meter size determines at what increments your throttling limit is consumed. For example if your direct call's payload is 4KB or less you can make up-to 40 calls per second per unit before hitting the limit of 160KB/sec/unit.
Similarly, if your payload is between 4KB and 8KB, each call accounts for 8KB and you can make up-to 20 calls per second per unit before hitting the max limit.
Finally, if your payload size is between 156KB-160KB, you'll be able to make only 1 call per second per unit in your hub before hitting the limit of 160KB/sec/unit.

So, what I'm taking from this is that the limit is only 160KB/sec/unit, and the text about a "throttling meter size" is irrelevant?

As I mentioned, the 4KB meter size is the increments by which you consume your 160KB/sec/unit, which makes it in fact very relevant!
See my earlier response for few examples.

Well, yes, but you also used other sizes in your examples, which surely means the relevant part is the 160KB/s limit?
Maybe I'm missing something, but the "meter size" appears to be completely arbitrary (rather than something predefined by Azure) and simply means "the size of a any given message"? Or does Azure have a 4KB minimum, such that a 100 byte message will still count as 4KB towards the limit?
I really think the docs need some clarification here :smile:

Or does Azure have a 4KB minimum, such that a 100 byte message will still count as 4KB towards the limit?

Yes, this is correct.

Ah, OK - this is what I was missing! If possible, it would be nice to update the docs to mention that documents are counted in blocks of 4K, and that ergo the maximum number of messages/sec/unit is 40.
As an aside as some product feedback, I'm really finding some of the IoT Hub limits, well, limiting :smile: Especially around cloud-to-device messaging and digital twins - it almost feels like the limits are there to discourage you from using any form of cloud-to-device messaging at all :man_shrugging:
IoT Hub seems great for ingesting data from devices, but is a real PITA in the other direction (e.g. command and control).

@cocowalla The article has been updated with this info as well as more about throttling. Let me know if your questions have been answered and we can close this.

@robinsh I find this to be much clearer now, thanks!


protected and mix-ins don’t work together

If you implement (so not extend) a class that has protected methods, you always get an error (typically used for a mix-in like pattern)
Either you implement the method, but then the compiler complaints that you are not actually a subclass and therefor cannot implement a protected method. If you however omit the method and than the compiler complaints you are missing a method.
Quick sample to illustrate:
class A {
	 protected hello() {}
 }

class B implements A {
	// protected hello() {}
}

One possible solution would be the compiler should ignore protected (and private) properties when implementing a class, only seeing the public properties as part of the externally exposed interface of a class.

Related to issue #3854 which suggests allowing implementing protected methods and properties when implementing a class interface.


NuGet package should not treat contentfiles as private

I have ten .NET 6 web applications, they have a NuGet package shared between them that sets up a lot of common stuff. One of the things it sets up is Application Insights.
If I add Microsoft.ApplicationInsights.Profiler.AspNetCore to my common NuGet package and enable profiling in one of the projects that references the common NuGet package (but not Microsoft...Profiler.AspNetCore directly), it will fail with:

Uploader can't be located.

The problem seems to be that NuGet treats contentfiles (where TraceUpload.zip comes from) as private.
You can see some documentation here and a GitHub issue about it here.
Instead of...
<PackageReference Include="Microsoft.ApplicationInsights.Profiler.AspNetCore" Version="2.3.1" />

...I replaced it with...
<PackageReference Include="Microsoft.ApplicationInsights.Profiler.AspNetCore" Version="2.3.1">
  <!-- Default is contentfiles;analyzers;build as per: -->
  <!-- https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets -->
  <PrivateAssets>analyzers;build</PrivateAssets>
</PackageReference>

...and it worked.
I believe the NuGet package you produce can override PrivateAssets to be analyzers;build so to make it automatically copy the TraceUpload.zip file in projects that don't depend on Microsoft...Profiler.AspNetCore directly.

Hey @taspeotis, I looked into the documentation and learned from it. Here's my current understanding:

You are doing it correct by setting <PrivateAssets>analyzers;build</PrivateAssets> for Profiler.ASPNETCore in your shared projects so that the contentFiles will flow into the header projects, which reference the shared.

As package owner, I don't think we can overwrite the behavior of contentFiles

Otherwise, imaging various package owners setting various values, it beat up the purpose of the default behavior
Or I could totally be wrong. And if there's anyone find out a solution and I will be more than glad to take it.

That said, I think this is very good scenario for real world projects. I think we should come up with a walk-though / guidance on how to do it.
What do you think?

Tag one more related issue: https://github.com/NuGet/Home/issues/6091

Thanks for looking into it. I don't have a good solution. Some thoughts:

I didn't realise the .nuspec didn't give you the flexibility to edit this. I had assumed there was a way to do it, because when you add a package like EF Core Tools or the ASP.NET Integration Testing their entries in the .csproj set PrivateAssets and ExcludeAssets. This may be a behaviour of NuGet though and not their packages.

Solving it with documentation might be okay? At least making it clear to users what they should expect to do if they do not install the package directly.

I recall that NuGet supports (or used to support) post install scripts that might be useful to edit the .csproj it is installed into. Install scripts seem to be outdated though.

Have you considered shipping TraceUpload.zip as an embedded resource rather than a contentFile? The .zip contents would have to be extracted out of the assembly as a stream, and decompressed into the user's temporary folder. But I don't see this as substantially different from shipping the .zip side by side the assembly; it has to get unzipped anyway.

Again, thanks for your work on this feature.

@taspeotis Thank you so much for the suggestions. We probably going to update the document as a short term mitigation for this issue and we will need to look into various ways for shipping the uploader, and having it as embedded resource will be considered :-). Thanks again for the input!
On the record, this could be combined with a related issue to making uploader workable with in self-contained app #170 .

Hi @taspeotis What do you think about a document like this: Reuse Profiler NuGet Package.

Thank you for writing that page, it describes how to solve the problem for anyone who uses the NuGet package "indirectly" like I do.
You're welcome to close this issue since the behaviour is documented, and my original request ("package should not treat contentfiles as private") I understand is actually to impossible to solve as requested, since the .nuspec doesn't have any provision for it.

Thanks for the report @taspeotis. It really helps clear up the use case for short term. In the long run, I think we are opening for adopting ways to make it easier for the users. Constantly seeking for opportunities.
I'll close this issue once the change is merged.


Downloads no longer working

Github Rate limiting is the issue gonna need to find a new way of hosting the files


Not able to access cyphon using the public domain

Hi,
I have installed cyphondock in AWS instance. But i am not able to access the Cyphone page using the public DNS.
Its showing the 502 BAd Gateway error.
502 Bad Gateway
nginx/1.13.5
docker-compose logs -f nginx
nginx_1          | 2017/10/23 23:31:48 [warn] 8#8: *119 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/"
nginx_1          | <IP_ADDRESS> - - [23/Oct/2017:23:31:48 +0000] "GET / HTTP/1.0" 502 173 "-" "Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0"
nginx_1          | 2017/10/24 00:01:03 [error] 8#8: *122 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/"
nginx_1          | 2017/10/24 00:01:03 [warn] 8#8: *122 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/"
nginx_1          | 2017/10/24 00:01:03 [error] 8#8: *122 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/"
nginx_1          | 2017/10/24 00:01:03 [warn] 8#8: *122 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:00:01:03 +0000] "GET / HTTP/1.0" 502 173 "-" "sysscan/1.0 (https://github.com/robertdavidgraham/sysscan)"
nginx_1          | 2017/10/24 06:21:57 [error] 8#8: *125 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "<IP_ADDRESS>"
nginx_1          | 2017/10/24 06:21:57 [warn] 8#8: *125 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "<IP_ADDRESS>"
nginx_1          | 2017/10/24 06:21:57 [error] 8#8: *125 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "<IP_ADDRESS>"
nginx_1          | 2017/10/24 06:21:57 [warn] 8#8: *125 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "<IP_ADDRESS>"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:06:21:57 +0000] "GET / HTTP/1.1" 502 575 "-" "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36"
nginx_1          | 2017/10/24 08:35:17 [error] 8#8: *128 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "ec2-52-91-99-166.compute-1.amazonaws.com"
nginx_1          | 2017/10/24 08:35:17 [warn] 8#8: *128 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "ec2-52-91-99-166.compute-1.amazonaws.com"
nginx_1          | 2017/10/24 08:35:17 [error] 8#8: *128 connect() failed (111: Connection refused) while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "ec2-52-91-99-166.compute-1.amazonaws.com"
nginx_1          | 2017/10/24 08:35:17 [warn] 8#8: *128 upstream server temporarily disabled while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:8000/", host: "ec2-52-91-99-166.compute-1.amazonaws.com"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:08:35:17 +0000] "GET / HTTP/1.1" 502 575 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36"
nginx_1          | 2017/10/24 08:35:18 [error] 8#8: *128 no live upstreams while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET /favicon.ico HTTP/1.1", upstream: "http://localhost/favicon.ico", host: "ec2-52-91-99-166.compute-1.amazonaws.com", referrer: "http://ec2-52-91-99-166.compute-1.amazonaws.com/"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:08:35:18 +0000] "GET /favicon.ico HTTP/1.1" 502 575 "http://ec2-52-91-99-166.compute-1.amazonaws.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36"
nginx_1          | 2017/10/24 08:35:20 [error] 8#8: *128 no live upstreams while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET / HTTP/1.1", upstream: "http://localhost/", host: "ec2-52-91-99-166.compute-1.amazonaws.com"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:08:35:20 +0000] "GET / HTTP/1.1" 502 575 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36"
nginx_1          | 2017/10/24 08:35:20 [error] 8#8: *128 no live upstreams while connecting to upstream, client: <IP_ADDRESS>, server: ec2-52-91-99-166.compute-1.amazonaws.com, request: "GET /favicon.ico HTTP/1.1", upstream: "http://localhost/favicon.ico", host: "ec2-52-91-99-166.compute-1.amazonaws.com", referrer: "http://ec2-52-91-99-166.compute-1.amazonaws.com/"
nginx_1          | <IP_ADDRESS> - - [24/Oct/2017:08:35:20 +0000] "GET /favicon.ico HTTP/1.1" 502 575 "http://ec2-52-91-99-166.compute-1.amazonaws.com/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36"

See https://github.com/dunbarcyber/cyphondock/issues/38.


For #406: adding ssh installation to image

For #406: adding ssh installation to image

Job gh:yegor256/jpeek#429 is not assigned, can't get performer


█ Always on Top  ➜ Modifier key + Various clicks

Description of the new feature / enhancement
●Separate software Enables assignment of modifier key + right click, left click, middle click (and other 4th and 5th buttons)
(Windows can be moved by mouse dragging, so modifier key + click could be a good match)
Scenario when this would be used?
Fix windows intuitively using modifier keys and the mouse.
You can intuitively pin a window with the modifier keys while resizing or clicking on the window.
This is similar to the functionality of AltDrug.
There are various other functions, such as making the window transparent when used with the wheel.
※Sorry if this content already exists, is known, or is under development.
Supporting information
https://stefansundin.github.io/altdrag/

Probably a duplicate of #269
/needinfo


Find replace puts JSON from related links into another property

When I use this tool and the term I'm searching for is in a related links link, it puts the JSON of the related links property into another property on the same page that has nothing to do with the related links:

I'm using Umbraco version 7.6.5 assembly: 1.0.6428.37121

This wasn't just a bug from the related links data type, it had to do with the search term being found in two properties on the same page.  I submitted a pull request with the fix.

Fixed in #3. #h5yr @motohead400 !


require dryRun to check syntax

dryRun parse the code , and run the []ast.Stmt with env, but not really exec.
In simple cases, it is possible to store a set of already defined variables/functions. If there are no variables/functions appearing in the code, there is an error.

@Chyroc
Any thoughts on the PR?

emmmm....have no idea..

@Chyroc ,
So we can close this?


Fix overlapping elements

An element was overlapping over CodelabExercisePlaygroundComponent
because it didn't have styles for its host element.
This closes #1105

Awesome, thanks


xpack.uptime.enabled & xpack.maps.enabled missing

Currently in kibana-docker v6.x the following settings are missing:

xpack.uptime.enabled
xpack.maps.enabled

Those settings are pending official documentation but work fine per https://github.com/elastic/kibana/issues/36156
As a result, environment variable "XPACK_UPTIME_ENABLED=false" and "XPACK_MAPS_ENABLED=false" have no effect in 6.7.x or 6.8.0 (also up to current 7.1.1)
Workaround : Adding "xpack.uptime.enabled: false" and "xpack.maps.enabled: false" in kibana.yml works as expected (removing the options from the menu)

Thanks @jguay, migrating this over to https://github.com/elastic/kibana/issues/39592.


Adding support for Anthropic, Cohere, TogetherAI, Aleph Alpha, Huggingface Inference Endpoints, etc.

Hi @neubig
Thanks for your comment on another PR. I came across prompt2model and would love to help out if possible using LiteLLM (https://github.com/BerriAI/litellm).
I added support for the providers listed above by replacing the chatcompletion w/ completion and chatcompletion.acreate with acompletion. The code is pretty similar to the OpenAI class - as litellm follows the same pattern as the openai-python sdk.
Would love to know if this helps.
Happy to add additional tests / update documentation, if the initial PR looks good to you.

Tagging @saum7800 who is currently working on this as well!

Thank you for the PR @krrishdholakia ! Excited to see contribution from you. Feel free to join discord and the open-source-llms channel where we are discussing how to make this change. A few more things to consider in addition to what @neubig mentioned:

Your current changes would be from the ChatGPT agent, whereas we should probably have a unified interface from which the generation for specified model can happen.

The instruction parser, model_retriever, and dataset_generator files are also handling exceptions specific to OpenAI. I am not sure how your code changes might react to error codes from different base LLMs.

Hey @saum7800,
Thanks for the feedback.

I only see the openai provider file. are there others? If not, can we treat that as the main one?
We map the exceptions to their openai types - https://github.com/BerriAI/litellm/blob/a42c197e5a6de56ea576c73715e6c7c6b19fa249/litellm/utils.py#L1217

Happy to make any changes, increase coverage on our end as required.

Hey @saum7800 / @neubig
How long is this part supposed to take? I'm trying to do some testing and been stuck on this for the last 10 minutes

Can confirm this works for openai. Will run through testing on other models/providers now.

Tested on anthropic, can confirm this works when you set 'ANTHROPIC_API_KEY' in the .env

Regarding Errors:
We currently provide support for 3 exceptions across all providers (here's our implementation logic - https://github.com/BerriAI/litellm/blob/cc4be8dd73497b02f4a9443b12c514737a657cae/litellm/utils.py#L1420)

InvalidRequestError
RateLimitError
ServiceUnavailableError

I'll add coverage for the remaining 3, tomorrow:

APIConnectionError
Timeout
APIError

After reviewing the relevant http status codes + docs, as well as running testing on our end.

@neubig There is no change in the way API keys need to be set, unless I'm missing something?
However, it would make sense to add documentation explaining how users can use different providers. I'm happy to add that too.

Yes, could you please add just a brief mention and possibly a link to the litellm doc regarding API keys? No need to list all of them on prompt2model

Hi @saum7800  @neubig,
Support for all openai exceptions is now added (if we don't have an exact match, it defaults to the OpenAI APIError type).
I've also updated the readme with a link to the list of supported providers.
Please let me know if there's anything else required for this PR

Awesome, thank you for the contribution @krrishdholakia !


Assume role error while working with multiple accounts

Hi, I'm trying to create a private host zone which needs to have a vpc associated from different account. But I'm getting the
Error: error configuring Terraform AWS Provider: IAM Role (arn:aws:iam::{account-2-id}:role/myrole) cannot be assumed
and
Error: NoCredentialProviders: no valid providers in chain. Deprecated
There are two providers being used for two different aws accounts.
Default aws provider is picked from the terragrunt config along with the iam_role in the terragrunt config which looks like this
generate "provider" {
  path      = "provider.tf"
  contents  = <<EOF
     provider "aws" {
             region = "${local.aws_region}"
            }
         EOF
  }

iam_role = "arn:aws:iam::${local.account_id}:role/${local.role_name}"

The source terraform module has one additional aws provider to associate the vpc from different account (account-2) to the private host zone.
provider "aws" {
  alias = "remote_account"
  region = "ap-southeast-2"
  assume_role {
    role_arn = "arn:aws:iam::${var.remote_account_id}:role/myrole"
  }
}

This provider config is being used to associate the vpc of different account in aws_route53_zone_association resource.
Rest of the resources i.e. aws_route53_zone , aws_route53_vpc_association_authorization , and aws_route53_record are using the provider that is set in terragrunt config.
I tried doing the same thing directly in terraform, by putting both the provider configs to assume their respective roles, and that worked. But similar thing is not working in terragrunt.
Terraform version
14.2
Terragrunt Version
26.7
Logs:
INFO] TGENV_VERSION is 0.26.7
[terragrunt] [account-1/route53-hosted-zone] 2020/12/10 15:03:37 Running command: terraform --version
[terragrunt] 2020/12/10 15:03:38 Terraform version: 0.14.2
[terragrunt] 2020/12/10 15:03:38 Reading Terragrunt config file at account-1/route53-hosted-zone/terragrunt.hcl
[terragrunt] 2020/12/10 15:03:38 Assuming IAM role arn:aws:iam::{account-1-id}:role/myrole
[terragrunt] 2020/12/10 15:03:39 WARNING: no double-slash (//) found in source URL private-repo-souce-url.git. Relative paths in downloaded Terraform code may not work.
[terragrunt] 2020/12/10 15:03:39 Terraform files in account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6 are up to date. Will not download again.
[terragrunt] 2020/12/10 15:03:39 Copying files from account-1/route53-hosted-zone into account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6
[terragrunt] 2020/12/10 15:03:39 Setting working directory to account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6
[terragrunt] 2020/12/10 15:03:39 The file path account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6/provider.tf already exists, but was a previously generated file by terragrunt. Since if_exists for code generation is set to "overwrite_terragrunt", regenerating file.
[terragrunt] 2020/12/10 15:03:39 Generated file account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6/provider.tf.
[terragrunt] 2020/12/10 15:03:39 The file path account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6/backend.tf already exists, but was a previously generated file by terragrunt. Since if_exists for code generation is set to "overwrite_terragrunt", regenerating file.
[terragrunt] 2020/12/10 15:03:39 Generated file account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6/backend.tf.
[terragrunt] 2020/12/10 15:03:39 Debug mode requested: generating debug file terragrunt-debug.tfvars.json in working dir account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6
[terragrunt] 2020/12/10 15:03:39 Variables passed to terraform are located in "account-1/route53-hosted-zone/terragrunt-debug.tfvars.json"
[terragrunt] 2020/12/10 15:03:39 Run this command to replicate how terraform was invoked:
[terragrunt] 2020/12/10 15:03:39 	terraform plan -var-file="account-1/route53-hosted-zone/terragrunt-debug.tfvars.json" "account-1/route53-hosted-zone/.terragrunt-cache/k8s7dtviykgbcyk8vhkfjIHIKDS&U/tfsdf6sd5f6776sd6f5rcs6dg6gcs6"
[terragrunt] [account-1/route53-hosted-zone] 2020/12/10 15:03:40 Running command: terraform init

Initializing the backend...

Initializing provider plugins...
- Reusing previous version of hashicorp/aws from the dependency lock file
- Installing hashicorp/aws v3.20.0...
- Installed hashicorp/aws v3.20.0 (signed by HashiCorp)

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
[terragrunt] 2020/12/10 15:03:50 Running command: terraform plan

Error: error configuring Terraform AWS Provider: IAM Role (arn:aws:iam::{account-2-id}:role/myrole) cannot be assumed.

There are a number of possible causes of this - the most common are:
  * The credentials used in order to assume the role are invalid
  * The credentials do not have appropriate permission to assume the role
  * The role ARN is not valid

Error: NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors

[terragrunt] 2020/12/10 15:03:58 Hit multiple errors:
exit status 1

Based on your configuration, the assume role chain is:
CURRENT_CREDS_IN_SHELL
===assume role====> arn:aws:iam::${local.account_id}:role/${local.role_name} (this configures `provider.aws`)
    ====assume role====> arn:aws:iam::${var.remote_account_id}:role/myrole

Does your role local.role_name have the necessary permissions to do the assume role call to myrole?
If not and you want to assume the role from CURRENT_CREDS_IN_SHELL, then you will want to have terraform assume the local.role_name role in the provider, as opposed to managing that assume in terragrunt with iam_role attribute.

Roles and Accounts:
role A - account A ( all assumes initiates from here)
role B - account B
    CURRENT_CREDS_IN_SHELL
B   ===assume role====> arn:aws:iam::${account-B}:role/role-B (this configures `provider.aws`)
A      ====assume role====> arn:aws:iam::${account-A}:role/myrole-A

role A and role B, both roles have administrator access.
role A is in the source authentication account (account A) of the credentials and all assume roles to all other accounts happen from this one account.

In other words:
I'm a user in account-A and there is a role in account-A, role-A. I can assume this role.
I can assume role-B in account-B using account-A's credentials as well.
role A can assume role B but vice-versa not possible (we want to manage all roles one account).
Both the roles, role-A and role-B, have Administrator access.

My opinion:
I think what's happening that terragrunt starts with assuming A and then A assumes B, which works because A is in the source account . But when it starts with B and B assumes A, it won't work because it is not allowed otherwise it will create a loop.
I would expect it to create the AWS resources by assuming their corresponding roles through their respective providers, such as, my user assume role B to create resources which use the default provider.tf.
And for the resources attached with the alternative (secondary) provider, again my user should assume role A to create them.
And I think terraform works the same way as well, that's why I don't face this issue in terraform.
Terraform Code (this works)
# Default provider
provider "aws"{
  region = "ap-southeast-2"
  assume_role {
  role_arn = "arn:aws:iam::{account-B}:role/{role-B}"
  }
}

# secondary account provider
provider "aws" {
  alias = "secondary_account"
  region = "ap-southeast-2"
  assume_role {
  role_arn = "arn:aws:iam::${account-A}:role/{role-A}"
  }
}

# Private hosted zone
resource "aws_route53_zone" "hosted_zone" {
    name = var.zone_name
    dynamic "vpc" {
      for_each = var.vpc
      content {
        vpc_id     = vpc.value["vpc_id"]
        vpc_region = vpc.value["region"]
      }
    }
  }

# Authorise cross-account vpcs to be associated with this hosted zone
resource "aws_route53_vpc_association_authorization" "vpc_association_authorization" {
  count   = length(var.secondary_vpc_id)
  vpc_id  = var.secondary_vpc_id[count.index]
  zone_id = aws_route53_zone.hosted_zone.zone_id
  depends_on = [ aws_route53_zone.hosted_zone ]
}

# Association of the secondary_vpc to private hosted zone
resource "aws_route53_zone_association" "zone_association" {

  provider = aws.secondary_account

  count   = length(var.secondary_vpc_id)
  vpc_id  = var.secondary_vpc_id[count.index]
  zone_id = aws_route53_zone.hosted_zone.zone_id
  vpc_region = var.region
  depends_on = [ aws_route53_vpc_association_authorization.vpc_association_authorization ]
}

I think what's happening that terragrunt starts with assuming A and then A assumes B, which works because A is in the source account . But when it starts with B and B assumes A, it won't work because it is not allowed otherwise it will create a loop.

This is happening because you have the iam_role attribute configured in your terragrunt configuration. It will work exactly like terraform if you get rid of that.
I am assuming you have this because you want terragrunt to assume a role during state bucket creation. You can avoid that by adding the relevant parameter to the remote_state config (https://terragrunt.gruntwork.io/docs/reference/config-blocks-and-attributes/#remote_state).

@abhinav10kaushik not sure if this is still relevant but anyway
It seems that I was able to find a solution to this problem. I used this as a reference
Why did I receive an "AccessDenied" or "Invalid information" error trying to assume a cross-account IAM role?
First step
role A config - account A
You would need to create a policy that will allow a role to assume the target role, like role B
policy config that needs to be assigned to role A in the account A
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "PermissionToAssumeRoleB",
      "Effect": "Allow",
      "Action": "sts:AssumeRole",
      "Resource": "arn:aws:iam::AWS_ACCOUNT_B:role/ROLE_TO_ASSUME"
    }
  ]
}

role B config - account B
Assign a policy to this role that you need and add a Trust relationships config
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Principal": {
                "AWS": [
                    "arn:aws:iam::AWS_ACCOUNT_A:role/role_A"
                ]
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

Now you should be able to do something like this
It will use the default role that you exported for Terragrunt
export TERRAGRUNT_IAM_ROLE="arn:aws:iam::AWS_ACCOUNT_A:role/role_A"
resource "aws_organizations_account" "this" {
  name                       = var.name
  email                      = var.email
  iam_user_access_to_billing = var.iam_user_access_to_billing

  tags      = var.tags
  parent_id = var.parent_id
}

This will assume a role from the account B and creates some stuff in that account B
provider "aws" {
  alias  = "admin"
  region = var.region
  assume_role {
    role_arn = "arn:aws:iam::AWS_ACCOUNT_B:role/ROLE_TO_ASSUME"
  }
}

module "aws_config" {
  providers = { aws = aws.admin }
  source    = "lacework/config/aws"
  version   = "~> 0.7.1"

  use_existing_iam_role = true
}


OA Workflow CronJob

We'll need a cronjob that runs fairly regularly (as often as possible without overlapping), that will trigger next steps in the workflow.
We are no longer going to try to build this workflow linearly, with each step triggering the next after completion.  Since there are too many cases where data could be changed elsewhere in RMD (knocking things out of place in the workflow), it makes more sense to have a regular process that looks for criteria (or scopes) to trigger next steps (jobs) for publications in this workflow.
Initially, we'll set this up to handle the DOI check, since it is the first one we have completed.  We'll need separate tickets to implement to other steps of the workflow.

Also, we do not want more that one job for the same publication to run at the same time.  We'll have to store some state information to prevent this.


added git clone command in readme

this time i used an indent bullet following the current style of the readme

Thank you.


Write a PHP program to find largest number in an array

Description
Write a PHP program to find largest number in an array
Input  : [1, 2, 3, 4, 5]
Output : 5

How to contribute

Save the solution in program/find_largest_number_in_an_array.php file
Add find_largest_number_in_an_array.php file in find-largest-number-in-an-array folder

!assign

Hey @abrahamventura95,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


[Feature] Better Custom Camera Support

Please, before submitting a new issue verify and check:

[x] I tested it on latest raylib version from master branch
[X] I checked there is no similar issue already reported
[x] My code has no errors or misuse of raylib

Issue description
Hi, i worked with the Camera3D and saw it is very hard todo a custom camera, like get the rotation...
My idea is to do a abstract class so we can do our own Cameras, or maybe you can improve the camera that we has right now...
What ever i hope you can improve them a bit :)

Camera was already completely redesigned for raylib 4.5. UpdateCameraPro() was added for advance users. raylib-extras provides several custom camera examples.


Does_babylon.gui.image, url or path input works?

I checked https://forum.babylonjs.com/search?q=image button
Found,https://forum.babylonjs.com/t/button-image-examples-not-working/16281
states that it worked in the past..however it does not seems to work now.
i used a few references

//https://playground.babylonjs.com/#XCPP9Y#3
//https://doc.babylonjs.com/divingDeeper/gui/gui
however none of it seems to work.
What I need is just a image that acts like a button.
Which you probably will ask did the example in docs worked.sadly no.
in fact,i do not think the example even work.I copied the code and change the string to point to my image.
it sadly does not seems to work.
you may use https://playground.babylonjs.com/#XCPP9Y#3 and replace the var button contructor with the image link to test.
you may also try comment out the button.background and button.color
eg,"textures/grass.png" to "https://avatars.discourse-cdn.com/v4/letter/j/e68b1a/240.png"
Expected result,a picture that acts like a button.
current result,a transparent button that works

eg

As the template is mentionning it would be great to start the discussion in the babylon forum as we tend to keep github for validated issues.
In your case it seems to be a cors issue for your picture


Factor out RLBase defaults

Create generic methods for RLBase API written for AbstractGridWorld.
Most of these default implementations can be reused in several environments.

Codecov Report

Merging #74 (e1d306b) into master (92efd25) will decrease coverage by 1.31%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   71.86%   70.55%   -1.32%
==========================================
  Files          14       14
  Lines         519      489      -30
==========================================
- Hits          373      345      -28
+ Misses        146      144       -2

Impacted Files
Coverage Δ

src/envs/collectgems.jl
100.00% <ø> (ø)

src/envs/doorkey.jl
96.29% <ø> (-3.71%)
:arrow_down:

src/envs/dynamicobstacles.jl
100.00% <ø> (ø)

src/envs/emptygridworld.jl
100.00% <ø> (ø)

src/envs/fourrooms.jl
100.00% <ø> (ø)

src/envs/gotodoor.jl
100.00% <ø> (ø)

src/abstract_grid_world.jl
87.50% <90.00%> (+19.31%)
:arrow_up:

src/GridWorlds.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92efd25...e1d306b. Read the comment docs.


Make the Dockerfile suitable for Docker Hub automatic builds

Replaces #27. This PR makes the Dockerfile suitable for using Docker Hub Automated Builds.
Fixes #13

Thanks!

Looks like that worked.


SIG Reviewer Nomination: Jan Hanca

Nomination Guidelines
Reviewer Nomination Requirements

6+ contributions successfully submitted to O3DE
100+ lines of code changed across all contributions submitted to O3DE
2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer
Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month

Maintainer Nomination Requirements

Has been a Reviewer for 2+ months
8+ reviewed Pull Requests in the previous 2 months
200+ lines of code changed across all reviewed Pull Request
2+ O3DE Maintainers that support the promotion from Reviewer to Maintainer
Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month

Reviewer/Maintainer Nomination

I would like to nominate: jhanca-robotecai, to become a Reviewer on behalf of sig-simulation. I verify that they have fulfilled the prerequisites for this role.

Nominee's GitHub Profile [https://github.com/jhanca-robotecai)
PRs contributed (to o3de-extras)

Reviewers & Maintainers that support this nomination should comment in this issue.

I support this nomination.

I support this nomination.

I support this nomination

Nomination accepted during the triage meeting.


Fix Godot exiting with unexpected failure code

The exit code is initialized as EXIT_FAILURE to indicate failures during startup. Closing the Game window via the window manager does not change the exit code, so the program exits with EXIT_FAILURE.
This PR sets the exit code to EXIT_SUCCESS when initialization was successful just before starting the main loop.
resolve #62898

Thanks!

I think this might have been the wrong fix, and #83479 might be the better approach. At least, fixing this only for Linux was wrong, as shown in #81518.
We need to decide whether the default expectation is to fail (and thus we should mark success before any successful exit) or the other way around.

If there is a better way for fixing the problem, then please revert this PR.
I am rather in favor of making success the default expectation, because in failure cases some additional handling is necessary anyway.

I'm not sure yet what's the right solution, I would need to look more into it. #81518 would add feature parity with the approach from this PR in Windows and macOS (but not other platforms, if it matters).

as mentioned here, I'm not sure this is the right solution ;-)


Kubernetes Deploy: Build Container Images in Parallel

We have more and more services in the demo that are instrumented with Sentry, and since we build all images in Argo sequentially, the build/deploy times also jumped up.
We should build the service images in parallel, which will cut down deploy times, and also will help with localizing the failed service faster.

This is done.


pulumi new and other ways to set up besom project / submodule

solved via pulumi new https://github.com/VirtusLab/besom/tree/beta-release/template/default


Precision-recall curves

Dear community,
I would like to extract Precision-Recall curves from CellPose (or do this externally with a script of my own) in order to compare my results to earlier works, but I am having difficulty in doing so. I do not see any direct way to do this within CellPose currently, and to do it with a self-written script, I believe that I would need to use a score per mask. That is, not a score per pixel within a mask (like the cell probability score), but per full mask, in order to calculate based on a varying threshold value for the mask score, a different precision and recall value.
If I am correct, the model match threshold/score (see GUI, in the scripts referred to as flows threshold/score) is related to what I would need for this.
Ideally, I would extract a single score per full mask from CellPose, in order to do my own calculations with it. Does anyone have ideas on how to extract this? The _seg.npy file only contains pixel-level scores (cell probability), not full mask-level scores (as far as I could find).
The flows threshold is passed from the main to models.CellPoseModel.eval, to dynamics.get_masks and dynamics.bad_flow_masks. But I am not managing to figure out how to rewrite the script there in order to extract the flow scores per mask.
Are there any people who already did this and are willing to share their scripts? Or that have a script to calculate the Precision-Recall curves within CellPose or have ideas on how to do this?
All help is appreciated. Thanks in advance.

I think @carsen-stringer might have scripts to share that were used to do the quantitative comparisons in the paper - that what I understand from your comment about 'earlier works'. But otherwise it sounds like you are really just probing the cellpose output itself. You could do this by first running the labels_to_flows function on the cellpose output, and then loop over all the predicted labels and do a mean-square-error comparison of the generated flow to the predicted flow (for just that label region). Almost exactly this is implemented within cellpose already with the additional functionality of throwing out regions with a MSE that is too high. So you could adapt that code and save the MSE per mask as it goes along. But maybe you already did all this, it has been a couple weeks since you posted!

indeed we have several metrics functions here: https://github.com/MouseLand/cellpose/blob/master/cellpose/metrics.py
I'm guessing you have the ground-truth labels for your images, in which case you use those as masks_true and the cellpose masks as masks_pred


Cannot Add Connect behind Proxy

We got this from slack:
https://positpbc.slack.com/archives/C05K993PVEV/p1721156669455599
It appears when Connect is behind a proxy we cannot add the server.
When you add the palm url (https://pub.palm.ptd.posit.it/) the following error is thrown:

Based on the logs, it looks like we're having trouble parsing the response:

time=2024-07-16T15:11:34.781-04:00 level=INFO msg="Testing authentication" method="Connect API key" url=https://pub.palm.ptd.posit.it/connect/
time=2024-07-16T15:11:35.654-04:00 level=DEBUG msg="API request" method=GET path=/api/v1/user body="" response="\n\n\n\n\n<html lang="en">\n\n    <meta charset="UTF-8">\n\n    <script type="text/javascript" nonce="32Zh1d1fB6Icnylb6KyWqA">if (typeof module === 'object') {window.module = module; module = undefined;}<style type="text/css" nonce="32Zh1d1fB6Icnylb6KyWqA">\n
...

When we can successfully add a Server we hit (dogfood for reference):

time=2024-07-16T15:18:37.180-04:00 level=INFO msg="Testing authentication" method="Connect API key" url=https://rsc.radixu.com
time=2024-07-16T15:18:39.521-04:00 level=DEBUG msg="API request" method=GET path=/api/v1/user body="" response="" error="unexpected response from the server (401)"
time=2024-07-16T15:18:39.521-04:00 level=INFO msg="Connect server connectivity check failed" url=https://rsc.radixu.com
time=2024-07-16T15:18:39.521-04:00 level=INFO msg="Access Log" method=POST url=/api/test-credentials elapsed_ms=2340 status=200 req_size=32 resp_size=27 client_addr=<IP_ADDRESS>:64776 req.url=https://rsc.radixu.com

I think we expect a 401 response and we're surprised to hit the proxy.
This URL works with both RStudio IDE (rsconnect) and rsconnect-python
From @colearendt

We let certain things through (from history): X-Auth-Token header is present (for IDE access), or Authorization: Key * header for API requests.
https://github.com/rstudio/ptd/blob/e72d358f58120144db25cf3cf8aa50690a8bd50a/ptd/src/ptd/pulumi_resources/traefik_forward_auth.py#L153-L154
Relevant Connect docs:
https://docs.posit.co/connect/admin/authentication/proxied/#ide-deployment

There is some kind of validation in the IDE - we could potentially look to see how the IDE validates to catch the same edge cases here. The error message isn't great, but we can look at the implementation:

Also remove trailing connect/ if present.


Folder Collection pages not displaying

Describe the bug
I have a folder collection defined, but no existing content seems to be displaying in the collection.
Expected behavior
When adding a folder collection, any existing content in the defined folder should be displayed as an item in the collection.
Screenshots
This is the view when I load the Event collection in CMS.

Applicable Versions:

Netlify CMS version: 2.9.7
Git provider: GitHub
OS: Windows 10
Browser version Chrome 77

CMS configuration
https://github.com/ManitowocMarineBand/mmbWebsite/blob/master/static/admin/config.yml
Specifically, the issue is with the events collection.
Additional context
This is very similar to the issue reported in #1411, however the fix noted there (to specify an extension) does not seem to address the issue I am running into.
I am able to add new items to the collection, but even after publishing it, it still does not show in the list.

Try updating your slug:
slug: "{{fields.startDate}}-{{slug}}"

That does seem to have fixed it for new entries at least. So the slug property is not only used to generate the filename, but also determine which content to be read for a collection?
I'll see what I can do about re-working my existing filenames and slugs to work with those constraints. Thanks!


Updated imports to pass CI checks

What changes were proposed in this pull request?
In our internal CI we have a goimports check which fails the build in case imports are not optimized.
This PR updates import by running: goimports -d -w .
How were these changes tested?

by running go test ./... from the root of this repo (find output below)

go test ./...
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io/v1alpha1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io/v1beta1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io/v1beta2	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/batchscheduler	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/batchscheduler/interface	[no test files]
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/batchscheduler/volcano	0.051s
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1alpha1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1alpha1/fake	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1beta1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1beta1/fake	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1beta2	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/clientset/versioned/typed/sparkoperator.k8s.io/v1beta2/fake	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/sparkoperator.k8s.io	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/sparkoperator.k8s.io/v1alpha1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/sparkoperator.k8s.io/v1beta1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/informers/externalversions/sparkoperator.k8s.io/v1beta2	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/listers/sparkoperator.k8s.io/v1alpha1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/listers/sparkoperator.k8s.io/v1beta1	[no test files]
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/client/listers/sparkoperator.k8s.io/v1beta2	[no test files]
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/config	0.036s
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/controller	[no test files]
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/controller/scheduledsparkapplication	0.039s
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/controller/sparkapplication	0.323s
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/util	0.042s
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/webhook	0.049s
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/webhook/resourceusage	0.035s
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/sparkctl	[no test files]
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/sparkctl/cmd	0.047s
ok  	github.com/GoogleCloudPlatform/spark-on-k8s-operator/test/e2e	0.024s
?   	github.com/GoogleCloudPlatform/spark-on-k8s-operator/test/e2e/framework	[no test files]

This doesn't seem like the right idea to run goimports on a fork of the upstream repo to conform to our internal CI requirements. Of course, nothing prevents us from reformatting the code but as the upstream repo doesn't do that, every merge will become time-consuming due to conflicts. Technically, we don't own this code and can't enforce the upstream to onboard this practice.
Closing it for now. Will reopen in case we can't relax our CI contract.


Example fails when configured single threaded.

Is the example code expected to be able to run single-threaded?
Because if I configure with BGFX_CONFIG_MULTITHREADED=0 and run the cubes demo, it aborts on the fatal error:
"This call only makes sense if used with multi-threaded renderer."
Where this call referring to renderFrame() called from entry_windows.cpp file.
(This is when using the vulkan back-end on windows, btw.)

Example harness is setup that it expect multithreading to be enabled. But GLFW for example runs in single threaded mode. So you should try that.


Information on my team

On this team, we have two persons @DuaneDave and @samiullah997
her is a link to the project https://github.com/DuaneDave/Capstone-Kanban/projects/1

Hi Team👋,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Status: Invalid Code Review Request

You have submitted a project, that does not include a project kanban board link.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Pls i don't understand, what link am i supposed to add @brytebee

Hi team @DuaneDave, @samiullah997 🙋♀,
Great work so far! 💯
You still need to work on some issues to set up your kanban board according to the requirements. You are almost there! 💪🏾
Required Changes ♻

[ ] Please assign each team member to each task equally. One team member is Student A and the other is Student B. Group tasks can be allocated to both team members.

Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@KDlamini  Do you mean I should share the group tasks amongst ourselves?

@KDlamini Do you mean I should share the group tasks amongst ourselves?

@DuaneDave How you allocate the group tasks is completed is up to you as a group. My suggestion is allocating both teamates to each group task since you are supposed to do it together. However, how you do the group tasks is completely up to you.

Hi Team👋,
Good job so far coming so far with the progress you've made! 💪💪
Highlights
You have done amazing in the following:

Team number provided.✔
Link provide.✔
Cards are assigned to team members fairly.✔

However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

The link should open to the Kanban board and not the repository.
Kindly update your README with the relevant section using the Microverse Template
Check the comments under the review.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Please, remember to tag me in your question so I can receive the notification.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Can't get instance to work

I'm currently migrating from zod to valibot but haven't been able to get instance to work.
Here is the original Zod code:
pictures: z
.instanceof(File, { message: 'Please upload a file.' })
.array()
.refine((files) => files.length !== 0, 'At least one image is required')
.refine(
	(files) => files.length <= MAX_NUM_PICTURES,
	`Maximum number of pictures is ${MAX_NUM_PICTURES}`
)
.refine(
	(files) => files.every((f) => sizeInMB(f.size) <= MAX_IMAGE_SIZE),
	'Max 4MB upload size.'
)
.refine(
	(files) => files.every((f) => ACCEPTED_IMAGE_TYPES.includes(f.type)),
	'Unsupported file type.'
)

And here is my attempted translation to Valibot:
pictures: array(
	instance(File, '', [
		mimeType(ACCEPTED_IMAGE_TYPES, 'Unsupported file type.'),
		custom((file) => sizeInMB(file.size) <= MAX_IMAGE_SIZE, 'Max 4MB upload size.')
	]),
	[
		custom((files) => files.length !== 0, 'At least one image is required'),
		custom(
			(files) => files.length <= MAX_NUM_PICTURES,
			`Maximum number of pictures is ${MAX_NUM_PICTURES}`
		)
	]
)

I get the following error
Error: Unsupported valibot schema: instance
    at assert (file:///C:/Users/mario/Escritorio/Unihouse/node_modules/@gcornut/valibot-json-schema/dist/index.mjs:21:11)
    at converter (file:///C:/Users/mario/Escritorio/Unihouse/node_modules/@gcornut/valibot-json-schema/dist/index.mjs:226:5)
    at object (file:///C:/Users/mario/Escritorio/Unihouse/node_modules/@gcornut/valibot-json-schema/dist/index.mjs:124:29)
    at converter (file:///C:/Users/mario/Escritorio/Unihouse/node_modules/@gcornut/valibot-json-schema/dist/index.mjs:227:23)
    at Module.toJSONSchema (file:///C:/Users/mario/Escritorio/Unihouse/node_modules/@gcornut/valibot-json-schema/dist/index.mjs:248:35)
    at valibotToJSONSchema (C:\Users\mario\Escritorio\Unihouse\node_modules\sveltekit-superforms\dist\adapters\valibot.js:13:12)
    at _valibot (C:\Users\mario\Escritorio\Unihouse\node_modules\sveltekit-superforms\dist\adapters\valibot.js:36:44)
    at Module.memoized (C:\Users\mario\Escritorio\Unihouse\node_modules\memoize-weak\lib\memoize.js:79:20)
    at load (C:\Users\mario\Escritorio\Unihouse\src\routes\(app)\publish\new\+page.server.js:12:29)
    at Module.load_server_data (C:\Users\mario\Escritorio\Unihouse\node_modules\@sveltejs\kit\src\runtime\server\page\load_data.js:61:41)

I've also tried a simpler test directly from the Valibot documentation:
pictures: instance(File, [
  mimeType(['image/jpeg', 'image/png']),
  maxSize(1024 * 1024 * 10),
]);

However, all attempts result in the same error. I even tried using just instance(File).
I'd appreciate any insights or assistance in resolving this issue. Thank you!

Thank you creating this issue. It seems that this error is not related to Valibot. It is related to valibot-json-schema. Please create an issue there. Feel free to link me.


Adding a license?

Hi there, this codebase is currently unlicensed, meaning by default it falls under this set of restrictions meaning (quote from that link):

you have no permission from the creators of the software to use, modify, or share the software. Although a code host such as GitHub may allow you to view and fork the code, this does not imply that you are permitted to use, modify, or share the software for any purpose.

Is this intentional? Asking because the README implies that it's available to use with citation, but the current lack of license doesn't allow that. If it's not intentional, could you please add a license? Given that it extends code from huggingface, their license choice may be appropriate here too? Thank you!

Noting additionally that the Apache license is currently specified in setup.py


Train a model to reproduce domain-shift results

Hi, when I want to evaluate Domain shift (Table 2. in paper), it is needed to provide an appropriate pre-trained model (for example "checkpoints/mini2cub/softmax/resnet18") but, if we want to train the appropriate model from scratch, how it is possible to train it for the cross domain?
I did not find the script.

Hi,
Actually there is no need to have a specific mini2cub folder, as the model in this folder is really just a copy of the one trained on mini. So if you want to train from scratch, you can simply train on mini directly, and then set ckpt_path="checkpoints/mini/softmax/resnet18" in mini2cub.sh. I will update the script, thanks for notifying me.
Best

Thank you for your response.


update dependencies

 Update Backend

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 11 (90.91%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.007%) to 85.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

services/src/util/config.rs
10
11
90.91%

Files with Coverage Reduction
New Missed Lines
%

services/src/util/config.rs
1
77.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
31021

Relevant Lines:
36425

💛  - Coveralls


App crash on API 19

We have been experiencing an issue with API Level 19 on our Beta (using new CSDK ImageEditor) on API Level 19 (4.4.x), where it doesn't include all the files in the build.
E/AndroidRuntime( 6574): java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.genericapp.app/com.genericapp.app.MainActivity}: java.lang.ClassNotFoundException: Didn't find class "com.genericapp.app.MainActivity" on path: DexPathList[[zip file "/data/app/com.genericapp.app-71.apk"],nativeLibraryDirectories=[/data/app-lib/com.genericapp.app-71, /vendor/lib, /system/lib]]
We have determine this is due to the following line:
public class AdobeAuthCredentialsApp extends Application implements IAdobeAuthClientCredentials {
On API Level 19, it appears that MultiDex is not available when extending the regular Application, so we needed to change it to the following:
public class AdobeAuthCredentialsApp extends MultiDexApplication implements IAdobeAuthClientCredentials {
And everything appeared to work on my device (4.4.x and latest 7.0) without any crashes at the start.
I also had to add the following the defaultConfig in the gradle file, but Im not sure if this is required.
multiDexEnabled true

Closing as I opened on the wrong repo.


Add Additional Timelines

Adds the Additional Timelines 1.0.1 release

you need 4 digits, so <IP_ADDRESS> probably for you.


DWARFImporterDelegate: Support enums.

Also includes a tiny improvement to SwiftOptionSetSummaryProvider to
avoid printing the zero-case of an option set.

@swift-ci test and merge


Support for ExpandableListView

Hi,
Great library, it would be really great if you can also provide an ObservableExpandableListView

+1

It is indeed necessary. +1

+1

+1

+1

+1


Add StringUtils.startsWithIgnoreCase

As the name of the method says: This method is the same as String.startsWith except that it is case insensitive.

I am not a fan of adding more and more "ignore case" versions of APIs.
For 4.0, we could consider a new StringUtils class that has two default instances, one that is case-sensitive, the other not, which you would use like:
StringUtils.DEFAULT.theApiYouWant(...); // case-sensitive
StringUtils.NAME_CASE_SENSITIVE.theApiYouWant(...);
StringUtils.NAME_CASE_INSENSITIVE.theApiYouWant(...);

The alternative for now might be to override the existing API with a boolean or maybe an enum that says what kind of case-sensitivity you want.
Any thoughts from the community?

Yes, that's a very good suggestion. I wonder why I wrote equalsIgnoreCase several times instead of ignoreCase.

I have overlooked the fact that such a method already exists. Therefore I close this pull request.


Task command decorations don't work when task echo: false

works in OSS

also works for me in insider's

It's because of this:
  "presentation": {
    "echo": false,
  }

should still work. investigating https://github.com/microsoft/vscode/blob/5812177e290151fe77eb7e8dedb8e803ce2d0a40/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts#L1134-L1139

This works but it adds an extra line because of initialText so it doesn't look quite right:
Before:

After:


How to figure out what collision geometry is used

Hi!
Thanks a lot for providing python-sdformat, I think it will help me a lot!
My problem with it is that a collision geometry has all parameter set (empty, box, mesh, polyline, sphere, cylinder...).
So how do I figure out what is actually used? I for now I convert the data to dict and see if "geometry/mesh", "geometry/box"... are set but that seems like an ugly hack. Is there a better way to check the type?

Hello, thank you for creating such a useful library that enables easy manipulation of models using Python.
Following the topic raised in the current issue, I wonder which way is the preferred way to define a Geometry. Reading the codes, I can come up with three different approaches:

The first one uses the fact that Geometry.sphere is a descriptor whose __get__ method will instantiate Geometry.Sphere and add to the invoking instance's children method and that Geometry.Sphere.radius is a data descriptor.g = Geometry()
g.sphere.radius = 0.1

The second approach explicitly instantiates a Sphere instance. (I personally prefer this approach since the implicit creation of a Sphere appears a little bit weird IMO.)sphere = Geometry.Sphere()
sphere.radius = 0.1
g = Geometry(sphere)

The third approach can create Geometry in one line.Geometry(Geometry.Sphere(Geometry.Sphere.Radius(text=0.1)))

but it uses the dynamically created type Radius (therefore IDE will complains it and thus might lead to typos) and manually sets the text attribute which cannot be validated.

@huweiATgithub The short answer is that you can use either of these approaches.
The slightly longer answer is that SDF heavily relies on tags to configure attributes, e.g.. world.gravity or scene.background. Each tag in SDF is represented by a python class in python-sdformat (standard behavior for bindings), and it would be awkward UX to have to create and assign them one-by-one:
scene = Scene()
scene.sky.clouds.speed = 0.6

#  vs.
scene = Scene()
scene,sky = Scene.Sky()
scene.sky.clouds = Scene.Sky.Clouds()
clouds.speed = 0.6  # Speed is a tag, too, but can't have children, so we cant instantiate it

The latter is perhaps more familiar from a software engineering background and preferred when engineering. However, it is also more verbose and doesn't offer much gain over writing SDF directly:
<scene>
    <sky>
        <clouds>
            <speed>0.6</speed>
        </clouds>
    </sky>
</scene>

My goal with python-sdformat was to make it faster to work with (and/or generate) SDF. SDF is essentially a (complex) config file format, so I am okay with it creating the necessary config (be that objects or tags) under the hood when I say:
scene = Scene()
scene.sky.clouds.speed = 0.6

Regarding auto-completion for dynamic types this is an unfortunate limitation of the project. I used this project to create a faster (and type-hint-guided) way to interact with SDF, but I didn't discover that you can separate definitions (.py files) and type annotations (.pyi files) until much later. If you were to create a .pyi file for the project, you could add type annotations for Radius and other dynamically generated types. I'd be happy to review and merge a contribution on this!

@FirefoxMetzger Thanks for your reply. I now understand the design. SDF relies heavily on nesting tags. I will take a look at the pyi generation and try to add the annotations.


Apply systemd restrictions to echobot

These options are suggested by
systemd-analyze security echobot.service

cmdeploy/src/cmdeploy/tests/online/test_2_deltachat.py::test_echobot and cmdeploy/src/cmdeploy/tests/test_cmdeploy.py::TestCmdline::test_parser  seem to be timeouting?

it seems<EMAIL_ADDRESS>doesn't exist:
550 5.1.1<EMAIL_ADDRESS>User doesn't exist<EMAIL_ADDRESS>(in reply to RCPT TO command)

cmdeploy/src/cmdeploy/tests/test_cmdeploy.py::TestCmdline::test_parser works locally at least.


Reduce sleep times in system_tests_http2

Do this so the test executes faster

This is being handled in the TLS commit


Feature request [ want to be able to run the page from script or command or api  so we can do moving pixel art or gifs ]

Hi , I could not open Feature request .
Basically the aim is to run the same page multiple times to get something like moving pixel art  or gifs .
A command line or url that would accept the wled ip , image . and then send the api would be nice ,
One other option is to be able to save the api directly from the page to preset or a file under wled-ip/edit .
Again this is a feature request but over all great tool , i wish to see you more on wled discord as this tool is used by a lot of people and you are the hidden soldier in that.  . Thank you

I agree... That is the next natural evolution, isn't it 😁
There are quite a few snags to get that working though and the most user friendly way to implement it is perhaps not clear to me, yet. Lots of thoughts and tests done allready though. I would presume it would be preffered to have an arcitechture discoussion within the WLED dev forum.
Adding the functionality to POC is not a big issue, once a way to implement it into WLED effectively.
I'll leave this FR here and hit you up on Discord instead

Check new beta

My guess is that the JSON library/handling/format is the issue. In new PAC much larger images is uploaded and run and JSON is bypassed alltogether. I would guess the limit here would be the compute of the ESP32 and then 64x64 should at least be possible (4X32X32 on four separate pins f.ex.) Goal is to make the animations/pixel art completetely self sufficient on the WLED device so you can simply call a preset over the API. I have that working on my DEV ESP32 just fine. Need to find the time to stitch it together into some sort of beta. I'd be happy if you would be able to test it and contribute feedback then.

I think as is at the moment we have a working pixel art  so you could take your time with enhancement . Still I will  test anything you have in mind

Hi werkstrom,
Jumping into the discussion, is there somewhere I could read what you've done for animations? like a branch or something?
You mentionned you did it directly on the ESP32 so I guess it's part of the WLED repository on one of your branch?
I'm very interested into implementing this as well, also willing to work on some POV display options but wondering which way is the one to go.
I was thinking of using your very nice Flow editor and add another option to "Matrix/Serpentine/POV" with some options.
Best,

@Liliputech Due to lifes unexpected (or expected) turns, I have quite litterally zero time to put nto this at the moment. Which is a bit unfortunate really, since the code actually works really vell apart from a "bug" where the reading of the data from file on the ESP32 some how stops for a fraction of a second. Some sort of issue with that piece of code nog getting priority on the ESP32 is my guess. UI is updated to use encoding of animated gifs with super-minimal footprint on the ESP32 device. So if that issue could be figured out, I would guess you would have what you need. What we probably would need is someone who knows the C-part of this and the more inner workings of the ESP32. I've managed to get the logic correct and (IMHO) rather efficient, but I know way to little about the ESP32 to troubleshoot the stuttering efficiently.


Serial sample -> No keyboard input on RPI2

Don't know if more people are experiencing this behavior, but using the serial sample I succeeded in using an USB to UART Bridge Controller based upon CP2102 and send/receive some bytes forth and back using xbees but I couldn't type in text in the write box when running the app on an RPI2 although the track pad mouse does work. Keyboard used is a Logitech K400r.

Thank you for reporting this problem. We are currently investigating.

Hello pwi1263,
This behavior has been improved, and the resolving changes are available in current releases.  Keyboard input should be functional in the scenario you describe with the latest content. You can get the latest content from the following link: http://go.microsoft.com/fwlink/?LinkID=625104

Fixed


Split acceptable docs combinations - Eng

New partial showing acceptable documents for properties in England (non-pilot) area. Should be rendered in has_other_documents.govspeak.erb.
From: https://www.pivotaltracker.com/story/show/110973118

This PR has been superseded by #2232


The value of input is changed... Weird

When I execute a model like this:
modelRK4SolverOnSIRDemoMultiConcerns
	"self new modelRK4SolverOnSIRDemoMultiConcerns"
	| model|
        model := KEModel new population: (KEPopulation size: 10000).
	model attributes: {(#status->#(#S #I #R))}.

	model atParameter: #gamma assignValue: #(#(5 1)).

	model atParameter: #beta assignValue: #(#(4 4)) .

	model atParameter: #mu assignValue: #(#(1  2)).

         model atCompartment: {#status->#S}
             put: #(#(4975 4975)).
          model atCompartment: {#status->#I}
             put: #(#(25 25)).
          model atCompartment: {#status->#R}
             put: #(#(0 0)).

	model
     atParameter: #i assignValue: (1 to: 2).
	^model.

The input of this statement:
model atParameter: #gamma assignValue: #(#(5 1)).
Always be changed from #(#(5 1)) to #(#(80 16)).
Is it a bug of Pharo? :(

I could not replicate your problem because when I run your model, I have an error ...
I think this is not a Pharo problem, but a problem from your code :-)

I run my model and dont have any error :)
But the value of parameter named "gamma" is not expected.
Can you send me your error?

Error: Instance of Array does not understand #ifTrue:
Try to use same version than me : 614

i cannot reproduce the bug either.
Note that the value of a compartment should be a number. When an user
specify a value for a compartment, Kendrick will check if the input number
is greater than the population size (if true ==> report a warning to users).
So in the script, I have error with the method KEModel>>atCompartment:put
when the input value is an array as you did.
When I just check the parameters of the model (after commenting all
specifications of compartments), i see that the model and its parameters
work as expected.
On Tue, Jul 25, 2017 at 8:34 PM nguyentienthanh812<EMAIL_ADDRESS>wrote:

I run my model and dont have any error :)
But the value of parameter named "gamma" is not expected.
Can you send me your error?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/UMMISCO/kendrick/issues/46#issuecomment-317737844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABP4hceEMS8aH6H5uKiC-6Xl8PNEsW7iks5sRe4PgaJpZM4Oig0M
.

I found it. My Pharo is out of date (too old) T.T
I have updated Pharo and edited the mode. It run correctly :-)

which version of Pharo you use ?
So we can close this issue ?

When I check System>About, it says Pharo 6.0, with the latest update: #60510. But I downloaded Pharo6.1-win.zip from the website.
There is still no Pharo version 6.1 64bit but iOS and Linux. My laptop is Windows 10 and 64 bit.

Sorry, something still wrong. Can you let me check this issue again? :(

Still happened. My model now is:
modelRK4SolverOnSIRDemoMultiConcerns
"self new modelRK4SolverOnSIRDemoMultiConcerns"
| model|
model := KEModel new population: (KEPopulation size: 10000).
model attributes: { #status->#(S I R). #species->#(human bird) }.
model atParameter: #gamma assignValue: #(5 1).

model atParameter: #beta assignValue: #(4 4) .

model atParameter: #mu assignValue: #(1  2).

"model atCompartment: {#status->#S}
put: #(4975 4975).
model atCompartment: {#status->#I}
put: #(25 25).
model atCompartment: {#status->#R}
put: #(0 0)."
model atCompartment: { #status->#S. #species->#human } put: 4975.
model atCompartment: { #status->#I. #species->#human } put: 25.
model atCompartment: { #status->#R. #species->#human } put: 0.
model atCompartment: { #status->#S. #species->#bird } put: 4975.
model atCompartment: { #status->#I. #species->#bird } put: 25.
model atCompartment: { #status->#R. #species->#bird } put: 0.

model
 atParameter: #i assignValue: (1 to: 2).
^model.

==================================
When I debug, I see:

I still see a lot of deleted class in your commit ... Can you fix that ?

Yes, let me fix it.

Now the issue 41 is fixed. It happens because I don't install Moose correctly and, additional, there is a bug in my code as well.
I fix. However, whenever I save a method, Moose automatically edits it, changes all temporary variables and deletes all comments. T.T >"<

Awesome, I fix.
"Moose automatically edits method, renames all temporary variables and deletes all comments. "
=> Because I dont copy Pharov60.sources. After copied, its fine.
We can close this issue! ^^

Ok don't forget to put the ready label and tell me the version to integrate.

Done, tests are green. Integrated in Kendrick-SergeStinckwich.629


why can't we see 4.0.0-RC2 on search.maven.org？

Thanks

Not release yet, you can see https://github.com/apache/incubator-shardingsphere/releases to find release info

Still could not find 4.0.0-RC2 on search.maven.org

@terrymanu Still could not find 4.0.0-RC2 on search.maven.org

Still not release, please focus on  sharding sphere releases, or watch sharding sphere on gitlab.

Does it's no means 4.0.0-RC2 relase alreay ?

Oh, it's only a tag. That's confuse me at first.

But I found some tags also publish to maven repository.

So when will a version be published to the maven repository?


fix(client): extensions backwards compatibility

closes https://github.com/prisma/team-orm/issues/212

It's published in our patch-dev for version 4.16.1-dev.9 and up.
Note for users: do not use in production, wait for the official 4.16.1 patch.


Notice of Copyright Violation

This is an official notice of Copyright violation against the PIVX developers in which this project has been forked from. The MIT copyright license, and subsequent copyright headers in source files have been modified to explicitly exclude the PIVX developers from all copyrights.
You are hereby notified of an intention to pursue further action if this issue is not acknowledged and formally addressed with a resolution timeframe commitment wherein. Failure to acknowledge and correct the violation will result in a formal DMCA takedown notice filed with GitHub Proper after no less than five business days from the date of this notice.
Explicit acknowledgement and referencing progress to maintain compliance MUST be noted in this issue's comments or referred to in any subsequent pull requests to this repository
File in question:
  securecloudcoin/LICENSE

we do not tolerate at all this kind of FUD.
the file you mentioned is not part of PIVX repository, not present at all.
As you can see we have not removed one of PIVX brand or logo, in order to be compliant with copyright and we also have added a link to PIVX project in our first page of the repository: the readme.
We started our project from RUPX and not PIVX, that have the file LICENCE that is identical of our file:
take a look here:
https://github.com/rupaya-project/rupaya/blob/master/LICENSE, rupaya is the committer of this file and PIVX is not mentioned at all.
As you can see in all files of our repository we leave the pivx copyright as is (and it is i think correct, and not just "necessary"), and also in the COPYING file (that as opposite of LICENSE file that is not commited, this is committed into your repository)
https://github.com/SecureCloudCoin/securecloudcoin/blob/master/COPYING
However just to close the discussion, since it's not a secret that we adopt several features of PIVX, nor something to hide (and we have nothing to hide at all in our project), please notice me how can we fix this problem and what do you expect to find inside that file (even if not present into PIVX repository), there will be no rush to change it to give to PIVX the expected evidence in that file.
By the way please navigate 99% of existing masternode coins and add the same comment you added to our repository. They all suffer of the same issue.
Thanks in advance for you response, I'm waiting for any further indication, to fix this issue

removed file as suggested by you and updated

  securecloudcoin/COPYING

If no more pending issues on copyright I'll close this issue in some days :)

Everything seems in order. We'll double check a few more of your source files and confirm your compliance.

Everything seems in order, thanks for the collaboration.
The PIVX team will be paying closer attention for copyright violations, which will then allow healthier and mutual relationships with our various forks. We have plans of forming a network we can all mutually benefit from. I would love to keep you in the loop about such progress.


Add formatting checks

Add a section that

performs formatting checks for fasta & fastq (check if the sequence has non-ACTG character & ID is incorrect format) & stop
potentially add --force option to bypass checks and --repair option to repair sequences that are not formatted correctly
if adding --repair option, should create a .repaired.fastq file and a .summary file with statistics explaining what was done

addressed in https://github.com/AuslanderLab/kmermaid/commit/87375908be1b87182c0b389486746a5728682daa


Modernise type hints

python-typing-update is created by HA maintainers to update type hints to the new PEP 585 style.
Old ones will be deprecated in Python 3.9 and eventually removed few year later. Before that they can be used with:
from __future__ import annotations

The advantage is that they don't need to be imported and python authors don't need to maintain parallel type definitions in typing module. Basically this is the future of python.
This tool can be run with:
poetry run pre-commit run --hook-stage manual python-typing-update --all-files

It can only run on committed files, because of that we can't add it to default pre-commit workflow.  But can add it to linting job.

A couple of questions:

Will this require us to run poetry run pre-commit run --hook-stage manual python-typing-update --all-files before every commit?
Is this just another syntax for using typing?

You don't have to as long you don't forget to use these modern syntax. Otherwise CI will catch it.
Yes, it's added by PEP 585.

Right, thanks clarifying.
It seems cleaner to use the new type hints then 😃

The only limitation of this new syntax is that it can only be used for type hints but can't be used in the code itself (e.g. for isinstance, cast or type aliases like JsonDict) before Python 3.9 is the default. HA is planning to switch to 3.9 in the end of this year.

Right, so we will stil need to use the old syntax in the code?
If above is the case, then I think it will become confusing for people if we use two different syntax's for typing.

In very limited cases. I think right now JsonDict is the only place where it's needed. This is the style I'm trying to adopt from HA Core codebase.

HA core does not use type annotations in the code itself. There by not having the same problem as us.
What does @leikoilja think?

HA core does not use type annotations in the code itself.
That's not true. Open any file here for example.
https://github.com/home-assistant/core/tree/dev/homeassistant/helpers

I think I misunderstood what you meant with can't be used in the code itself.

I mean code which is executed by python interpreter.
For example type hints are not executed, only mypy uses them.
But on the other hand isinstance(List[str], my_list) is code which is executed by interpreter.

Thanks for clarifying, I understand it now. 😄
This sounds great!


Set zPosition to show separator and indicator on top

The separator was not showing because it was below the collection view. Setting zPosition on the layer fixes the issue.

Seems like the same thing happened with the indicator, so I fixed that as well 😁

@zenangst 👍

@zenangst just a question, bringSubviewToFront does not work here?

@onmyway133 depends on when it gets added to the hierarchy, that only works if you call that method when all views have been added. I thought this was a more feasible solution as zPosition defaults to 0, which would guarantee the order regardless of when the views are added.


Performance issue.

My experience is that you can make your  program much faster if you do not use the .slice method for defining a pixel.
So replace (in your program two times):
arr.slice(i, i + n_channels) by [ arr[i+0], arr[i+1], arr[i+2], arr[i+4] ]
(if n_channels == 4)
It is a bit annoying to implement it for a general number of n_channels.

Hi @akalverboer,
Thanks for letting me know about this optimization.
I have implemented a similar approach (without fixing the number of channels).
This reduces the run time by about 75% for the large image I tested on (16 million pixels).
The run time was not affected notably for the small image I tested on (600,000 pixels).
I only switched away from using slice in one out of the two times it was used. When it's used outside the k-means algorithm (for constructing the initial dataset), there was not a meaningful impact on performance. Since the slice approach is more readable, I left that.


telemetry.enableTelemetry does not display "false" when set to false

VSCode Version: 1.18.1
OS Version: Windows 10 Latest Build

Steps to Reproduce:

File -> Preferences -> Settings -> Telemetry set to False

These settings are after a restart of VSCode.
I'm not sure if it is intended behavior for the GUI to display both "true" and "false" to the user, but I personally find it visually confusing and misleading as to whether the setting is actually turned off or not.

Reproduces without extensions: Yes

@cwillhelm In the settings editor, Left hand side are default settings and the right hand side are settings you override. Since the default value for the setting is true LSH shows true.
If you have any suggestions, please provide here


[JSX] Eating comments in JSX

Input:
const View = ({}) => {
  return (

    	{/* comment */}

  )
}

Output:
const View = ({}) => {
  return (

      {}

  );
};

url: https://jlongster.github.io/prettier/#{"content"%3A"const View %3D ({}) %3D> {\n  return (\n
\n    \t{%2F* comment *%2F}\n    <%2Fdiv>\n  )\n}"%2C"options"%3A{"printWidth"%3A80%2C"tabWidth"%3A2%2C"singleQuote"%3Atrue%2C"trailingComma"%3Atrue%2C"bracketSpacing"%3Atrue}}

https://github.com/jlongster/prettier/issues/20 sorry duplicate of this


Option to use custom Right Click menu, custom shell and administrator copy

What feature or improvement do you think would benefit Files?
I am using ExplorerPatcher to change my Windows 11 Right Click menu to use the Windows 10 one, because I like it more. WHen using files, I find that it forces its own Right Click menu.
Is there an option, inside the app or in registry, to be able to use these custom Right Click menus?
I want to have it like this:

But Files forces it like this

Also, is there a way to use Windows' shell instead of Files custom, soz, for example, use Teracopy's copy dialog?
Also, is there a way to have a pop.-up ask for administrator priviledges when copying to admin protected folders (Like C:/ProgramFiles). I have to use Windows Explorer to copy as admin because Files doesn't let me.
Requirements
-Proposal to use custom Right Click menus and bypass the custom Files shell.
-Hability to use custom context menus when copy pasting, such as Teracopy
Files Version
<IP_ADDRESS>
Windows Version
Windows 11 22H2 (SO 22621.1635)
Comments
No response

It isn't possible to use the Windows 10 style context menu as Files doesn't have the code or access for it at all.

What are your reasons to want to use the old style?

I find it more useful, having every option at plain sight, without having to go to any submenus (I know the option of having the submenus on the main right click menu is there, but even after trying that, I find myself going back to the Windows 10 style. I don't know, I find it faster overall and more useful (I'm referring to Windows 10 to Windows 11, without refering to the Files one)


Implement RadioGroup.enableCell()

Thanks! Little doc string maybe? Also, I would rename the cell_index argument to index (like elsewhere in the code).

Sure! Is the term "cell" easy to understand in this context though? Cells is what these are called internally, while vanilla calls the NSMatrix "RadioGroup" and the cells "radio buttons".
What could be a better name for the method: "enableRadioButton", "enableOption", ...?

Oh, good question! I vote for enableRadioButton(index).

OK, done!

Thank you, Jens!


Consider removing a wild println from Server.start

One of the Server.start methods have what I guess is some local development logging that reached productive code:
https://github.com/dream11/zio-http/blob/a50397fc11743b32ed95ec350178437da8405ce1/zio-http/src/main/scala/zhttp/service/Server.scala#L218
As one peer suggested, it has the following issues:

Having that log only for a very specific overloaded method of Server.start
Using println
Not considering that println is an effect, and could eventually throw => Task

Please, consider removing it 🙏🏽

It's a valid concern. Would you be willing to open a pr?


Support Gettext 0.14

Hi there!
I really like this package a lot! However, after starting a new greenfield Phoenix application with Gettext 0.14, I got this error:
$ mix deps.get
Resolving Hex dependencies...

Failed to use "gettext" (version 0.14.0) because
  set_locale (version 0.2.4) requires ~> 0.13.1
  mix.lock specifies 0.14.0

I just bumped the gettext version string, and now I'm able to use set_locale again. According to gettext's changelog, there's a new per-process locale, but I'm not sure if that would produce any pollution for the plug. Haven't seen anything so far.

How about ~> 0.13 instead of ~> 0.14.0? I have the same conflict on `gettext 0.15.0'.

Have the same issue.
Is using the override: true flag recommended in this case ?
{:gettext, "~> 0.15.0", override: true},

Sorry, I have been snowed under lately, processing all pull requests now. this is solved in #14. Thanks for your time though :) will update the package in about an hour.


Enabling HDR crashes on launch

Plugin crashes when HDR is enabled on a camera. I wanted to use a combination of HDR and this lighting to do some interesting effects, however seems I can't use HDR at the same time
2024-06-14T02:58:52.023829Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default
thread '<unnamed>' panicked at /src/index.crates.io-6f17d22bba15001f/wgpu-0.19.4/src/backend/wgpu_core.rs:3006:5:
wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1, Metal)>`
    In a set_pipeline command
      note: render pipeline = `lighting_pipeline`
    Render pipeline targets are incompatible with render pass
    Incompatible color attachments at indices [0]: the RenderPass uses textures with formats [Some(Rgba16Float)] but the RenderPipeline uses attachments with formats [Some(Rgba8UnormSrgb)]

Thanks for the report!
I will take a peek next time I'm able.

Looks like to support HDR we need to have a conditional texture format based on the camera. Should be doable; lots of Bevy's internal pipelines do it. Will have a PR hopefully soon.


Error messages (26)

Previously this code
{
   "index"     : 1,
   "indexList" : [0,1,2],
   "param2"    : "${indexList}[${indexList}[[${index}]]"
}

caused
'Invalid expression found: '${indexList}[${indexList}[[${index}]]'.'
That is completely fine. The expression contains an additional opened square bracket. No chance to detect the meaning of this.
Therefore the expression is simply "invalid".
With latest changes of the JsonPreprocessor the error message changed to:
'Invalid parameter format: $${indexList}[$${indexList}[[1]] - The double quotes are missing!!!'
This is misleading and wrong. The error message contains double '$$' and there are no double quotes missing.
Or in other words: Out of this invalid expression it cannot be concluded that double quotes are missing.
The previous error message should be restored.

Hello Holger,
I fixed and pushed the change to stabi branch.
Thank you,
Son

Retest successful. Issue can be closed.

Hi Son,
the issue is back. Most probably caused by fix of
https://github.com/test-fullautomation/python-jsonpreprocessor/issues/347
(because not seen in RobotFramework_AIO_setup_<IP_ADDRESS>_extended.exe).

Hello Holger,
This ticket is back due to I updated the pattern of regex regarding to the suggestion from code scanning https://github.com/test-fullautomation/python-jsonpreprocessor/security/code-scanning
I changed it back via a commit 3d1c159d660
Thank you,
Son

Hi Son,
OK, but what does this mean? Is it not possible now to solve the code scanning issue or do you plan to work on an alternative solution?

Hello Holger,
Code scanning just gives a warning not an issue regarding to the regex pattern, in this case I define the pattern:
if re.match(r'^\${[^}]+}+(\[.+\])*\s*$', sInput)
and Code scanning gives the warning about \[.+\] that This part of the regular expression may cause exponential backtracking on strings starting with '$${a}[' and containing many repetitions of ']['.
In the case we have nested parameters inside the nested parameter, then there are many repetitions of ']['.
This case I already mentioned to Thomas in our meeting.
Thank you,
Son

Hi Son,
this does not answer my question.

Hello Holger,
We have 4 warnings from Code scanning that Thomas sent me before.
I solved 2 warnings and the other two I do not solve because of the reason I mentioned in above comment.
In this case, the regex's pattern warning from Code scanning could be ignored, it means we do not plan to work on it.
Thank you,
Son

OK, clear to me now.


Release Google.Cloud.Security.PublicCA.V1 version 1.0.0

Changes in this release:
No API surface changes; just dependency updates and promotion to GA.

Created release for Google.Cloud.Security.PublicCA.V1-1.0.0


Check code during compile?

This is a:

[x] Question

Which concerns:

[x] babel-plugin-flow-runtime

Is there a way to make this plugin check code in compile time and throw exception? Something like this:

No, we don't want to replicate Flow itself, so we don't really do any static analysis.


Various improvements to Android module

Follows Android/Java code conventions
Higher quality resize
Moves resizing to its own AsyncTask to prevent blocking UI thread
Improves error handling
Uses native Promise interface so iOS and Android JS can be identical
Better handling of resources that need to have close called on them
Replace OS included ExifInterface with support library ExifInterface

 Resize images for inspections client side