Improve UI

Is your feature request related to a problem? Please describe.

The tables UI in the homepage lessons section for mobile devices are not responsive.

Describe the solution you'd like

What about show in row format 😀
But it going to take too much space on the page so I don't know if it is a good idea or not 🥲

📝 example:-
Project Name:   Getting Started
Concepts Taught:   Introduction to Programming and Tools of the Trade
Learning Objectives:   Learn the basic underpinnings behind most programming languages and about software that helps professional developers do their jobs
Linked Lesson:   Intro to Programming Languages and Tools of the Trade
Author:   Jasmine
And so one...

Additional context

I would like to work on this issue.

@saragibby can you review this issues
It good to go?

We will need to update the CSS of the tables UI to make it responsive for mobile devices. We can use the @media queries in our CSS to target the mobile devices and make the tables UI look better. Additionally, we can also use JavaScript to modify the elements and make them more responsive.

@Jainex17 are you gonna work on this issue?

@Jainex17 are you gonna work on this issue?

isn't we need to ask for approval or something?

Like we need to get it assigned to work on it

Hi, I'll also like to work on this issue

Hi, I'll also like to work on this issue

Open PR and reference this issue

Can you assign me this issue i would like to work on it!

.take


Readline and reads can now be interwoven

Also:

readline now includes terminator

...but readline is much slower now, relying only on libhdfs3's internal buffer.
Could contemplate doing full internal buffering like in s3fs.
Possible replacement for #116
Fixes #88

@aabadie , does this serve your purposes? For many short lines, performance is certainly worse.

I tested your branch and it seems to fix the problem. Thanks a lot.
Regarding performances, they are probably degraded with compressed data: seeking in compressed streams is costly. This is the case that comes to my mind first, maybe there are others.
pinging @ogrisel that could be also interested in the discussion.

The performance issue with readline() could be solved by making the HDFS file class a RawIOBase implementation and then wrapping it in a BufferedRandom.
See SocketIO for a RawIOBase example: https://github.com/python/cpython/blob/master/Lib/socket.py#L543
Also see the docs of the standard io module: https://docs.python.org/3.6/library/io.html#module-io

Will merge for now; if there is pushback later, can consider managing the buffer either using the suggestion above, or bytes blocks as done elsewhere.


Bump etcdadm-bootstrap-provider to v1.0.15

Description of changes:
Bump etcdadm-bootstrap-provider to v1.0.15
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://github.com/aws/eks-anywhere-build-tooling/blob/main/projects/aws/etcdadm-bootstrap-provider/ATTRIBUTION.txt#L2
Can you update the version in the attribution file here?

/cherry-pick release-0.21

/cherry-pick release-0.20

Merged in #3989 instead
/close


Add a feature to see the all nodes

Allow the user to see the all nodes to allow him to have a perpective of everything. I am having this issue where I can't zoom out more.

Released 0.6.1 to fix the problem.

What should I change for this to happen? @nabil6391

See the updated example from TreeViewPage.dart


add -fS to curl so it fails clearly

missing part of #3231

How quiet was it before, and how much messaging would you like to see?  I'm partly asking as part of the review, but also considering how much messaging I should put in if go is just used to perform the download (the very tail part of https://github.com/istio/istio/compare/master...mattdelco:master20?expand=1 where the go implementation in the last diff is shorter than the bin/init.sh script to use curl or wget).

ty!

@ldemailly: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I don't know what's wrong with curl other than it looks to me like someone felt the need to enhance bin/init.sh to try to cope with cases where only curl is installed (or where curl lacks https support) or only wget is installed.  So, rather than pick favorites or debate on which one of the two should be supported it seemed like an option was to not rely on either and just leverage another existing build requirement (i.e., golang).

I objected to that change (curl vs wget etc...) too :-)
but if we want to use something in go, let's use
fortio curl --stdclient https://storage.googleapis.com/istio-build/proxy/envoy-debug-54077a0c8486b6db7b2fc5d10619b6813bb40767.tar.gz | ...

/retest
it seems we have ingress delays on prow at the moment (takes more than 70s for the ingress to showup)

Where does fortio come from?  I'm not a fan of home brewing an app but it does take less than a second to compile (assuming 1.10's caching isn't exaggerating) and there's be something ironic about downloading a binary to download a binary.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
1a6b89719192e18615f85b1c6a8501752aa0e722
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fortio is in vendor/ already and comes from me (istio/fortio)

@mattdelco btw fortio takes less than 4s to compile the first time and is used by some test script so needed anyway later:
ldemailly-macbookpro:istio ldemailly$ cd vendor/istio.io/fortio/
ldemailly-macbookpro:fortio ldemailly$ rm  ~/go/bin/fortio
ldemailly-macbookpro:fortio ldemailly$ time go install .

real	0m3.918s
user	0m7.364s
sys	0m2.198s
ldemailly-macbookpro:fortio ldemailly$ time go install .

real	0m0.286s
user	0m0.273s
sys	0m0.276s


issue under recurring invoice

[x] popup window is missing for create invoice manually option

issue fixed !


OxfordComma missing support for multiword items

The current regex for detecting missing Oxford Commas seems to only detect sentences where the last item in the list before the "and"/"or" consists of one single word.
For example:
"Save your file to a hard drive, an external drive or OneDrive." Vale seems to not detect the missing comma after 'drive' (example from https://docs.microsoft.com/en-us/style-guide/punctuation/commas). However, if the sentence is "Save your file to a hard drive, OneDrive or an external drive", Vale will correctly detect the missing comma.

I would suggest adding whitespaces (\s) to the regex: '(?:[\w\s]+,){1,}\s[\w\s]+\s(and|or)\s'. Does that make sense? If so, I'd be happy to open a pull request with this ammendment!
in: '(?:[\w\s]+,){1,}\s[\w\s]+\s(and|or)\s'
out: '(?:[^,]+,){1,}\s\w+\s(and|or)'
(This would already include changes from #29.)

While it's true that we currently only check for a specific case, the problem with trying to be more generic is that you'll get a lot of false positives.
I ran your suggested pattern on this file and saw these (among other) results:

This explicitness on your part, which is up to you to maintain with discipline, will save you lots of refactor headaches and footguns down the line.

Remember: one of the most important roles for source code is to communicate clearly, not only to you, but your future self and other code collaborators, what your intent is.

But again, other than our intuitions and sensibilities, there doesn't appear to be objective and clear measure of what constitutes "accidents" or prevention thereof.

This isn't to say that the rule can't be improved, but I think adding \s is too generic.

I see your point, this regex could certainly use some more work. Are there any regex-experts on this project? I'll also keep tweaking and testing some more.


error TS2300: Duplicate identifier 'export='.

I used lodash and sequelize in my project and install @types/lodash and @types/sequelize,i get below error when compile.
error TS2300: Duplicate identifier 'export='.
i think @types/sequelize already include @types/lodash in subdirectory,so it has two @types/sequelize  in my project,so i want know how to  solve the problem?

i think @types/sequelize already include @types/lodash in subdirectory

Precisely.

i want know how to solve the problem?

The quick fix is to install a version of @types/sequelize that is semver compatible with that specified by @types/lodash and then npm 3 + won't install it twice (you will need to delete what is there first).

Or you can uninstall your version of @types/sequelize.

specify "compilerOptions"."types" with an array containing exactly the typings you are using and no others.

This is a longstanding problem. npm resolves all semver conflicts this way. It is terrible behavior.

@aluanhaddad  thanks reply!
The quick fix is to install a version of @types/sequelize that is semver compatible with that specified by @types/lodash and then npm 3 + won't install it twice (you will need to delete what is there first).
my npm version is 2.15.9
Or you can uninstall your version of @types/sequelize.
i realy want use sequelize with typescript
specify "compilerOptions"."types" with an array containing exactly the typings you are using and no others.
i already try ,but no effect.
finally,i back to typings :disappointed:

@keyiis

i realy want use sequelize with typescript

Sorry, I mispoke. You need to uninstall @types/lodash. Since sequelize comes with @types/lodash, TypeScript will automatically, and in my view unfortunately, include it as if you had installed it yourself except you will not be able to control the version.
You could also try running npm dedupe in npm 2 but it is not likely to help much. If you have to use npm 2 you are probably going to be 😢

npm dedupe would be the recommendation here.

@mhegazy Just to check, does this mean TypeScript can't handle sub-dependencies with the same name properly right? If there's a minor version mismatch in types that will result in the same named definition at two levels, but they aren't the same. If so, it'd be nice to fix this as it's a pretty common scenario to run into (sometimes people pin dependencies which would not dedupe, sometimes we legitimately have two major versions in different dependencies which also does not dedupe). I'd be happy to look at doing a PR if it's an issue.

@mhegazy Just to check, does this mean TypeScript can't handle sub-dependencies with the same name properly right?

That is not accurate. my recommendation to use npm dedupe is more of a general remedy. but here are the details..
The core issue for this problem with @types\lodash is https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12773. This change added "global" declarations to lodash, previously it was a "module". I am planning on reverting this, but need to chat with @andy-ms about it first to get more information on the original issue that this change was trying to fix.
A "module" is a file with at least one top-level import or export statement. modules have their own scope and do not pollute the global namespace.
A "global" script is a file that is not a module. these pollute the global scope.
By definition you can have multiple copies of the same module (possibly different versions) in the same compilation with no issues, since each has its own object at runtime and the scopes are isolated. You can not do that with global for instance, one of the multiple definitions will override the other, and result in an unspecified behavior. this is why you get the error "duplicate declaration".
lodash is a module at runtime (since it is a node module), so that is not the issue. the issue is the declaration file in @types\lodash\index.d.ts makes it look to the compiler as if it was a global. So these issues are all definition file authoring bugs. we have tried to fix them as we go, but it is hard to fix them all, hence my general remedy above.
In an ideal world, all declaration files on DefinitelyTyped, except @types\node (and a few others) would be authored as modules (UMD for things that are global as well as modules, e.g. ng/$); but we are not there at the moment.
Hope that clarifies the issue.

@mhegazy Thanks for the clarification, I missed that the DefinitelyTyped version had been turned into a global declaration and it makes sense. Is there a way to improve the error message when there's duplicate @types resolved and both contain globals? If the issue doesn't exist with external modules, there's nothing for me to worry about (again, I was concerned because I missed the global references, I wanted to make sure the submodule can with externals do work).
Would it help to add a step to DefinitelyTyped PR process to deny future changes to global unless a specific flag is set in the directory (e.g. for node)?

Is there a way to improve the error message when there's duplicate @types resolved and both contain globals

that is the only way to get this error anyways from an @types package. we could add an elaboration of sorts. suggestions welcomed.

Would it help to add a step to DefinitelyTyped PR process to deny future changes to global unless a specific flag is set in the directory (e.g. for node)?

Totally agree. I spoke to @andy-ms about this a few weeks ago. will follow up on that.

we could add an elaboration of sorts. suggestions welcomed.

I'll need to review the algorithm for the best action, but if it's complicated or there's multiple solutions you could link to a page on the TypeScript handbook. Something like this, perhaps:

Found a duplicate type for lodash. You will need to resolve this manually using typeRoots or specifying compilerOptions.types.

The resolve is probably too unclear, so a link might be best.

we could say, if we have duplicate definition error, and all declarations are coming from files under the @types (e.g. node_modules\@types), and the folder/files have the same name (e.g. lodash\modules.d.ts in this case), we could recommend using "path" : {  "lodash": ["<location of one of the files>"] } }

@mhegazy
The core issue for this problem with @types\lodash is DefinitelyTyped/DefinitelyTyped#12773. This change added "global" declarations to lodash
Many package d.ts may have similar problems,ex: @types\ckeditor

@mhegazy Thank you for the details. They are roughly what I understood to be the case.
Sorry this post is rather long.
TLDR: npm manages JS packages decently enough, but Node's require is what loads them. Unfortunately Node doesn't even respect package.json. It simply assumes that everything is laid out correctly and naively resolves based on a recursive tree walk that is semver ignorant. I think this is fundamentally unsound as even nested directories containing distinct "projects" are not bound to get their correct versions. Since these are TypeScript declaration packages, and not even Node modules, npm cannot resolve this. TypeScript is not at fault but simply resolving dependencies from the file system (by default) is bad. I think TypeScript should not use the file system as its source of truth.

When I say that multiple versions are not handled by TypeScript, or that multiple versions are handled poorly, what I mean to say that is that they are handled in the handled in the NodeJS way.
The reason I consider this a problem is that the NodeRequire function does not have any notion of a set of root packages or sibling packages, npm 3 helps in terms of laying out packages in the right way for NodeRequire to usually get things correct but the problem is that, from my limited understanding (please correct me if I am in error ❤), there is no notion of an npm package that NodeJS understands. The file system is the source of truth.
I don't generally write fully fledged NodeJS applications, but as a TS/JS user I of course write scripts and I've dabbled in CLI tools with some success (all in TS, because well, why wouldn't I use TS 😉).
Before get to browser related grievences, I want to say that the node based projects usually work fine for me, but I have a fundamental, issue with how dependencies are resolved, the package.json does not imply a limitation on NodeRequire. It is an 'NTFS' | 'HFSJ' | 'FAT' | ...' tree walker that walks directives which npm has cleverly lays down for it to make it work correctly.
My opinion is that is unsound behavior on the part of NodeJS because it looks for a file in a directory, and picks the first one it finds (matching by name not version).
Even in a NodeJS project, source control mistakes, or people forgetting to run npm install on checkout, which is a pain, can lead to bugs.
This is why I like JSPM so much. It provides the closest thing JavaScript has to Strongly Named dependencies. It does this by using manifests (package.json and jspm.config.js) to determine what to load, what a project actually is. It goes further determining which dependencies need to be duplicated do to semver conflicts, in a way which is sound.

we could say, if we have duplicate definition error, and all declarations are coming from files under the @types (e.g. node_modules@types), and the folder/files have the same name (e.g. lodash\modules.d.ts in this case), we could recommend using "path" : { "lodash": [""] } }

This is a great idea! Would it be at least feasible to do something similar as a quick fix (or even better automatically on installation)? That would make tsconfig.json more like a project root, explicitly mapping dependencies to where they reside.

lodash is a module at runtime (since it is a node module), so that is not the issue. the issue is the declaration file in @types\lodash\index.d.ts makes it look to the compiler as if it was a global. So these issues are all definition file authoring bugs. we have tried to fix them as we go, but it is hard to fix them all, hence my general remedy above.

I think TypeScript should understand and auto resolve this scenario. Since, as you say, lodash is a node module, it will not be loaded twice, but since it declaration file is not, and since that is definitely not something npm will handle, I think this is reasonable.

OP should be fixed by https://github.com/DefinitelyTyped/DefinitelyTyped/pull/13051

Having to fix the actual typings package can be a pain. Seems like there should be a way to exclude type dependencies somehow?


Guitar Player Produces Random error

I entered a midi file and then tried to close and re open guitar player and got this error: Unhandled standard exception of type "class std::system_error" with message "No mapping for the Unicode character exists in the target multi-byte code page."; terminating the application.

Download the most recent release, this should be fixed.


Date-time with formatMinimum throws TypeError on validate

const Ajv = require('ajv/dist/2019').default;
const AjvFormats = require('ajv-formats');

// Instance
const ajv = new Ajv();
AjvFormats(ajv);

const schema = {
  type: 'string',
  format: 'date-time',
  formatMinimum: '2020-01-01T00:00:00.000Z'
};

const validate = ajv.compile(schema);
console.log(validate('2020-01-01T00:00:00.000Z')); // Throws TypeError

// Works fine without formatMinimum
const schema2 = {
  type: 'string',
  format: 'date-time'
};
const validate2 = ajv.compile(schema2);
console.log(validate2('2020-01-01T00:00:00.000Z'));

I am also facing the same issue

I does look like it was the same issue as #13
I can reproduce in runkit with 1.5.1, but it works with 1.6.0 that has ajv as peerDependency
https://runkit.com/esp/605ef277f6c771001a349664

Resubmit if you can reproduce with the latest version

For anyone who would have the same issue:
I had it too with the latest version, but NPM was warning that I had to install the peer dependency myself.
Uninstalling all ajv-* modules and reinstalling<EMAIL_ADDRESS>first before reinstalling ajv-formats did the trick.


nit(elixir): replace comment of Elixir recipe

Changed the comment of the Elixir recipe.
The current comment might annoy some Erlang developers and therefor
was removed from an Elixir forum thread. As Elixir is standing on the shoulders
of Erlang, let's not offend those who feed it.

This has already been changed to an elegant language for a more civilized age in the rewrite-docs branch (see the #+subtitle: line), so this isn't necessary.
The lines in init.example.el will be generated from #+subtitle lines in their respective modules' readme once that branch is merged.


Add more options/templates to create new reejs app

I would like to see some of these libraries added to reejs/packit support (either via packit plugin, or via create-reejs-app):

vuejs
svelte
electron apps
tauri apps
shadcn official support?
tamagui (would really love it!)

If anyone is interested in anyone of the following above, please create a pr!
Packit's code lies in src/cli/cmds/packit.js and src/cli/cmds/utils/Packit.js and create reejs app at src/create

Hi Can you please explain what to do . I am new to open source and willing to learn

Hi @GD0910 ! Welcome to oss world! I assume you have the nodejs & javascript basics learnt. Try jumping into src/create/index.js and modify it to suit your needs. Although, before that, I would suggest installing the latest version of reejs globally so you can modify and run it easily. npm i -g reejs@latest.
To keep things simple, start by reading the mentioned file and tinkering here and there to test stuff out. You can test changes by running reejs x ./<path to>/index.js and it should run normally.
Let me know if you come across anything hard 🙂

ok will try
btw your discord link has expired
can you share your discord link

https://discord.rovelstars.com/server

https://discord.gg/k2eTWv7Yxn

https://discord.gg/k2eTWv7Yxn

unable to join can u add me Govind Nair#1904


Any version compatible with 10.11 ?

My laptop is getting old now ;)
Any version of Hidden compatible with 10.11 ?
Thanks :)

the minimum support version is 10.12


Promisify library

Can this library be promisified?
I am trying to read the XL workbook in Async but apparently i am not able to get it working.
Thanks

Reading a workbook would normally be a synchronous operation. If you're trying to avoid tying up the UI, you can pass the read operation off to a web worker (where supported), then it would become asynchronous.

@acicali hit the nail on the head. You'd have to read the whole file in order to process certain formats:

XLSX is really a ZIP container with a bunch of sub files. You have to read a few subfiles before you can process individual worksheets, and those files can be scattered anywhere within the ZIP container. Some writers put the manifest files at the end of the ZIP

XLS uses a simple FAT-like structure and you need to find and read the directory sectors first. Of course, some writers put the directory sectors at the end of the file so you would have to read the whole file first

So with the exception of a few uncommon formats, you really gain nothing from an asynchronous interface.
The aforementioned suggestion of web workers is employed in the web demo http://oss.sheetjs.com/js-xlsx so in the browser that's the best approach. In node, you can use something like concat-stream to accumulate a buffer and then send the whole thing at the end.


Update documentation for mqtt current activity commands.

The implementation was updated, just the README.md was left behind.

Oh ok, cool. boom.


Feature Request: Support Displaying Videos in Sidebar for Custom Extensions

Issue Type: Feature Request
Please add support in the Extension API to allow videos (mp4) to be displayed in the sidebar. I want to build a VSCode extension called "CodeTube" which allows developers to document their code with video. A developer would record their video through VSCode, explaining different code functions/files/folders. The "CodeTube" extension would then process the video and divide it into bite-sized video clips.
When a new developer joins the team, they can click through different files in the codebase and see the most relevant video clips show up in the VSCode sidebar. This would allow for a great onboarding experience. Video allows us to capture richer explanations than plaintext comments in the code. It's also faster to do than writing several paragraphs of comments.
Right now, the VSCode Extension API doesn't allow for a way to display videos in the sidebar (View Container). It would be really great if you could add this feature!

This should already be supported using  webviews: https://code.visualstudio.com/updates/v1_71#_ffmpeg-codecs-support
Make sure you are using a supported codec though


Add Qixxit

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[x] Company name
[x] Company description
[x] Company location
[x] GitHub link
[x] How Elixir is used
[x] Sorted alphabetically

Thank you @kimquy!  You're in the know 😁


How Do I Specify the Library for Arangodb Running?

ArangoDB Version:       <IP_ADDRESS>

Storage Engine:             RocksDB

Deployment Mode:      Cluster

Deployment Strategy:   Manual Start

Configuration:                Three services are deployed on each host. agency primary coordinator

Infrastructure:

Operating System:        Linux host

Total RAM in your machine:       16G

Disks in use:

Used Package:

Problem:
How Do I Specify the Library for Arangodb Running?
For example: libssl.so.1.1      libcrypto.so.1.1
Because the version of the library I use conflicts with that of the OS process.
By the way, are there any problems with my deployment strategy?
how much memory size is required.？ 16 GB memory overflows after the service is started.
thanks for help~

Hi,
the ArangoDB executeables are statically linked, you can't replace the linked in openssl library.
It also won't pick libraries from the OS.
Instead of the GLIBC libmusl is used.
Please note that you should always upgrade to the latest patch version of minor releases - 3.6.5 at the time being in your case.

Hi,
the ArangoDB executeables are statically linked, you can't replace the linked in openssl library.
It also won't pick libraries from the OS.
Instead of the GLIBC libmusl is used.
Please note that you should always upgrade to the latest patch version of minor releases - 3.6.8 at the time being in your case.

But when I run the service, it will reference the OS library file.

The binary tool arangod I used was compiled by myself. this is my CMake order:
cmake -DUSE_BACKTRACE=Off -DOPENSSL_ROOT_DIR=$PROJECT_DIR/build/$OPENSSL -DOPENSSL_CRYPTO_LIBRARIES=$PROJECT_DIR/build/$OPENSSL -DUSE_OPTIMIZE_FOR_ARCHITECTURE=On -DASM_OPTIMIZATIONS=0 -DUSE_FAILURE_TESTS=Off -DUSE_JEMALLOC=Off -DBASE_C_FLAGS="-mtune=generic -fstack-protector-all -fPIE -pie" -DBASE_CXX_FLAGS="-mtune=generic -fstack-protector-all -fPIE -pie" -DBASE_LD_FLAGS="-Wl,-z,now" -DVERBOSE=On ..
by the way, What problems can be solved by upgrading to 3.6.8?

if you don't use static linking, your build-host needs to be the same operating system as the target host.
https://github.com/arangodb/arangodb/blob/3.6/CHANGELOG has the list of the problems solved.
the scripts we use to build the static binaries can be found in: https://github.com/arangodb/oskar/
Dynamic linked binaries may use LD_LIBRARY_PATH to modify the library path they're run from - see https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html for details.
May I ask for the reason you compile arangodb on your own?

Because it's the company's request~
I have another question.  Is 16 GB memory not enough?
I'm going to expand memory now, but I'm still confused.

for compiling? depends on your parallelity -j - linking C++ is quiet memory intense - switching to the GOLD linker may improve the situation.

for compiling? depends on your parallelity -j - linking C++ is quiet memory intense - switching to the GOLD linker may improve the situation.

Not compile but running.

please have a look at https://www.arangodb.com/docs/stable/tutorials-reduce-memory-footprint.html - it explains how to reduce this, and what the actual tradeoffs are.

I expanded the memory to 32 gigabytes.  the operating system still overflowed.
After the primary process is started, all the memory is occupied in less than one minute.
Does any module in there apply for unlimited memory?

do you meanwhile run the latest 3.6 series?

No, I'm getting ready to upgrade now

thanks for your help
After the upgrade to 3.6.9, the memory overflow problem does not occur.


How to get device token when using VOIP push?

Expected Behaviour
pushObject.on('registration') returns the device token when using VOIP push.
Actual Behaviour
The callback is never called.
Reproduce Scenario (including but not limited to)
const pushObject: PushObject = this.push.init({ios: {
  voip: true
}});

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
iOS 12
Cordova CLI version and cordova platform version
cordova --version             8.0.0                       # e.g. 6.0.0

@BorntraegerMarc we haven't done any work on iOS 12. Support will be in a future release.

It's not an issue with iOS 12 I believe. Also get the same behavior with iOS 11. Should the tokens be passed in the callback of "registration" event?

Because this is the only output I'm seeing from my terminal:
2018-06-26 16:18:59.961830+0200 Komed Health[418:26737] subscribe from topic: my-topic
2018-06-26 16:19:00.011608+0200 Komed Health[418:26737] Successfully subscribe to topic my-topic
2018-06-26 16:19:00.011685+0200 Komed Health[418:26737] THREAD WARNING: ['PushNotification'] took '49.866211' ms. Plugin should use a background thread.
2018-06-26 16:19:00.011819+0200 Komed Health[418:26846] 4.13.0 - [Firebase/Messaging][I-FCM002010] Cannot subscribe to topic: my-topic with token: (null)
2018-06-26 16:19:00.012499+0200 Komed Health[418:26846] Push Plugin VoIP set to true
2018-06-26 16:19:00.014723+0200 Komed Health[418:26737] XXX success

@BorntraegerMarc wait are you trying to do VoIP and FCM at the same time?

@BorntraegerMarc I'm just realizing you are using typescript and I don't think the voip option is in our types definition.

@macdonst Even though you're right on that, it would cause a totally different issue unrelated to registration not being triggered.

Yeah. I'm not typing the init function so the normal JS method is executed. (But the types should be updated ;) )


chore: Replacing "Edition" with "Plan" for business and enterprise edition references

Description
Replacing "Edition" with "Plan" for business and enterprise edition references.
Fixes #1415
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

/build-deploy-preview skip-tests=true


CreateGroup() returns INVALID_ARGUMENT if the parent is empty; the description can be empty.

Harshit, I think this is what was intended, but I suppose it is possible that you mean to require both fields be non-empty.

Hi.
Right now, both the descriptions and the parent have to be non-empty. I realise this wasn't correctly documented. Sorry for that.
The description is needed since the group id is server side allocated and it seemed wanted to have a way of creating keyed groups at each level of the heirarchy (for a single parent).
We could rename description to name and document this uniqueness requirement OR get rid of it altogether.

ok, I do not understand what you mean about 'keyed'.  I expected that the group name + the organization the user belongs to (ie: the root group) are the key.
But, I only care that it is documented correctly.  cheers.

Ah, I see my confusion now.  You are correct.  Sorry.


Enable mlflow system metrics logging

What does this PR do?
enable mlflow system metrics logging
What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Closing as this was done in https://github.com/mosaicml/composer/pull/2775


Fix for Missing Backpack Icons

With some of the UI changes in Dragonflight, the Backpack button's icon was removed. In order to remedy this, skins have to add the icon back, like so (pulled from Hex AmtoftEU):
	Icon = {
		Texture = [[Interface\Icons\INV_Misc_Bag_08]], -- Manually specify the icon
		Width = 36,
		Height = 36,
		TexCoords = {0.07,0.93,0.07,0.93},
		Mask = [[Interface\AddOns\masque-hex\Textures\hex_mask]],
		--TexCoords = {0.02, 0.98, 0.02, 0.98},
		--DrawLayer = "BACKGROUND",
		--DrawLevel = 0,
		--Width = 36,
		--Height = 36,
		--Point = "CENTER",
		--RelPoint = "CENTER",
		--OffsetX = 0,
		--OffsetY = 0,
		-- SetAllPoints = nil,
	},
	SlotIcon = "Icon", -- SlotIcon refers to the Dragonflight Backpack icon. SlotIcon = Icon tells Masque to use the Icon settings for the SlotIcon region.

This commit fixes issue #1 for all skins. Additionally, for future reference, any layer that uses the same exact settings as a another layer can reference the string name of that layer to save on memory. A prime example of this is ContextOverlay which uses the same settings as SearchOverlay. We can optimize this by changing:
	SearchOverlay = {
		-- Texture = nil,
		-- TexCoords = {0, 1, 0, 1},
		Color = {0, 0, 0, 0.7},
		BlendMode = "BLEND",
		DrawLayer = "OVERLAY",
		DrawLevel = 4,
		Width = 36,
		Height = 36,
		Point = "CENTER",
		RelPoint = "CENTER",
		OffsetX = 0,
		OffsetY = 0,
		UseColor = true,
		-- SetAllPoints = true,
	},
	ContextOverlay = {
		-- Texture = nil,
		-- TexCoords = {0, 1, 0, 1},
		Color = {0, 0, 0, 0.7},
		BlendMode = "BLEND",
		DrawLayer = "OVERLAY",
		DrawLevel = 4,
		Width = 36,
		Height = 36,
		Point = "CENTER",
		RelPoint = "CENTER",
		OffsetX = 0,
		OffsetY = 0,
		UseColor = true,
		-- SetAllPoints = true,
	},

To:
	SearchOverlay = {
		-- Texture = nil,
		-- TexCoords = {0, 1, 0, 1},
		Color = {0, 0, 0, 0.7},
		BlendMode = "BLEND",
		DrawLayer = "OVERLAY",
		DrawLevel = 4,
		Width = 36,
		Height = 36,
		Point = "CENTER",
		RelPoint = "CENTER",
		OffsetX = 0,
		OffsetY = 0,
		UseColor = true,
		-- SetAllPoints = true,
	},
	ContextOverlay = "SearchOverlay",

Add a few more changes:

Added support for the new AutoCast animations.
Added support for Masque's new spell alert styles.
Bumped the version.
Updated the API version.


Free text capture with RegexEntityRecognizer example

One of the things I'd like to process from the text input is a free form section of text. I assume I can do this via the RegexEntityRecognizer, but without any examples, I assume it's pretty inflexible. Illustrate my goal with an example:
console.log(nlp.test("I'd like some pasta"));
// { intent: "order_food", entitiesIndex: { food_type: { value: "pasta" } } }
console.log(nlp.test("I'd like some pasta with meatballs and cheese"));
// { intent: "order_food", entitiesIndex: { food_type: { value: "pasta" }, toppings: { value: "meatballs and cheese"}  } }
console.log(nlp.test("I'd like some pasta with meatballs and cheese on top"));
// { intent: "order_food", entitiesIndex: { food_type: { value: "pasta" }, toppings: { value: "meatballs and cheese"}  } }

I orginally found bravey as an alternative to a very regex-enumeration heavy text parsing solution, but I'm not sure if there are any better options to get this data then to dive back into Regex land. Suggestions?

You can give a try to FreeTextEntityRecognizer...
var nlp=new Bravey.Nlp.Sequential("getdescription",{stemmer:Bravey.Language.EN.Stemmer});
nlp.addEntity(new Bravey.Language.EN.FreeTextEntityRecognizer("topping"));
var food = new Bravey.StringEntityRecognizer("food");
food.addMatch("pasta", "pasta");
food.addMatch("pizza", "pizza");
food.addMatch("pizza", "pizzas");
nlp.addEntity(food);
nlp.addDocument("I want {food}", "food", { fromTaggedSentence: true, expandIntent: true });
nlp.addDocument("I want {food} with {topping}", "food", { fromTaggedSentence: true, expandIntent: true });
console.log(nlp.test("Want few pizzas, please"));
// Intent: food, Entities: [food="pizza"] ["topping"=""]
console.log(nlp.test("I'd like some pasta"));
// Intent: food, Entities: [food="pasta"] ["topping"=""]
console.log(nlp.test("I'd like some pasta with meatballs and cheese"));
// Intent: food, Entities: [food="pasta"] ["topping"="with meatballs and cheese"]
console.log(nlp.test("I'd like some pasta with meatballs and cheese on top"));
// Intent: food, Entities: [food="pasta"] ["topping"="with meatballs and cheese on top"]
console.log(nlp.test("I'd like some pasta having meatballs and cheese on top please"));
// Intent: food, Entities: [food="pasta"] ["topping"="having meatballs and cheese on top"]

...but, as other entity recognizers in Bravey, it's mostly based on regular expressions. English version of the entity recognizer (Bravey.Language.EN.FreeTextEntityRecognize) is a vanilla one pre-configured with few common text delimiters. (https://github.com/BraveyJS/Bravey/blob/master/src/languages/en.js#L801)
More delimiters can be added with addPrefix and addConjunction.

hi,
there is an example for using some FreeTextEntityRecognize without StringEntityRecognizer? when i try to use only FreeTextEntityRecognize i get alway false on test the sequential nlp

Okay!
var nlp=new Bravey.Nlp.Sequential("getdescription",{stemmer:Bravey.Language.EN.Stemmer});
nlp.addEntity(new Bravey.Language.EN.FreeTextEntityRecognizer("topping"));
nlp.addDocument("I want {topping} thanks", "food", { fromTaggedSentence: true, expandIntent: true });
nlp.addDocument("Just {topping}", "food", { fromTaggedSentence: true, expandIntent: true });
console.log(nlp.test("I need meatball and cheese, please"));
// Intent: food, Entities: ["topping"="i need meatball and cheese"]
console.log(nlp.test("meatball and cheese thanks"));
// Intent: food, Entities: ["topping"="meatball and cheese"]

FreeTextEntityRecognize is quite beta and experimental. It works well when surrounded with other entities, since it works mostly like a spring that tries to match everything in the middle - and that's why it works only with Sequential NLP. You can create non-meaningful entities in order to help the recognizer.
var nlp=new Bravey.Nlp.Sequential("getdescription",{stemmer:Bravey.Language.EN.Stemmer});
nlp.addEntity(new Bravey.Language.EN.FreeTextEntityRecognizer("topping"));
var splitter = new Bravey.StringEntityRecognizer("splitter");
splitter.addMatch("none", "with");
splitter.addMatch("none", "having");
splitter.addMatch("none", "need");
splitter.addMatch("none", "just");
nlp.addEntity(splitter);
nlp.addDocument("I {splitter} {topping} thanks", "food", { fromTaggedSentence: true, expandIntent: true });
nlp.addDocument("{topping} thanks", "food", { fromTaggedSentence: true, expandIntent: true });
console.log(nlp.test("I need meatball and cheese, please"));
// Intent: food, Entities: ["topping"="meatball and cheese"]
console.log(nlp.test("Something with meatball and cheese thanks"));
// Intent: food, Entities: ["topping"="meatball and cheese"]
console.log(nlp.test("I need meatball and cheese, please"));
// Intent: food, Entities: ["topping"="meatball and cheese"]
console.log(nlp.test("meatball and cheese thanks"));
// Intent: food, Entities: ["topping"="meatball and cheese"]

thanks i will try

Yes, we're following the project very closely and it's a really interesting one! It uses a more deterministic approach, that gives very good results on free text entity recognizers but probably needs more training for intent matching. Bravey instead uses a mix of Bayesian filters and regexps, which needs less training but gives more statistical results.
const ecolect = require('ecolect');
const en = require('ecolect/language/en');
const Bravey = require("bravey");

// --- Ecolect

const intents = ecolect.intents(en)
	.intent('lights:on')
		.add('turn lights on')
		.done().build();

intents.match('turn lights on').then(results => {
	if(results.best) console.log('(ECOLECT) Intent:', results.best.intent);
	else console.log("(ECOLECT) No match");
});
// = (ECOLECT) Intent: lights:on

intents.match('turn the lights on').then(results => {
	if(results.best) console.log('(ECOLECT) Intent:', results.best.intent);
	else console.log("(ECOLECT) No match");
});
// = (ECOLECT) No match

// --- Bravey

const nlp = new Bravey.Nlp.Fuzzy();
nlp.addDocument('turn lights on', 'lights:on', { fromFullSentence: true, expandIntent: true });

console.log("(BRAVEY) Intent:",nlp.test('turn lights on').intent);
// = Intent: (BRAVEY) lights:on

console.log("(BRAVEY) Intent:",nlp.test('turn the lights on').intent);
// = Intent: (BRAVEY) lights:on

There probably isn't a true silver bullet on NLU for chatbots and you've to choose the one that suits your needs, in terms of performances and purposes.

yes i have see that bravey can recognize better some phrases. why you don't present bravey at milano chatbot meetup?


why do you need uicache extracted if it is from bin pack

you should remove the uicache you extracted, you are using the one from binpack not the one you manually extracted.

The one from the BinPack64 lacks proper entitlements and will fail to do it.


Remove database schema

This is handled by https://github.com/opscode/pushy-server-schema now

This was taken care of here: https://github.com/chef/opscode-pushy-server/pull/124


Refactor AbstractTestBinder to interact with actual interceptors instead of relying on test channels

As a developer, I'd like to refactor the binder tests to use the actual interceptors, so we can validate the real functional abilities as opposed to merely relying on test channels for the message in/out.

This issue was moved to spring-cloud/spring-cloud-stream#1111


fixing search for Inline snapshot after a skip.

The InLine FilePatcher wasn't finding the correct snapshot (or even finding it at all) after a previous "skip".
I don't think the line number check is sufficient.
If you want some unit tests: try mine  https://bitbucket.org/athaliana/typescript-definitions/src/master/tests/typescript.rs

BTW: Awesome software guys!

This looks good, thanks!


Broken filter after updating outbound NAT mapping

I'm trying to use the API on our pfSense (22.05) to update an existing NAT outbound mapping. The mapping is quite specific: it's for all outbound UDP traffic from a range of ports on a specific IP address.
pfSense seems a little strange for outbound rules in that, using the normal UI, the port range needs to be specified as port1:port2, rather than the more common port1-port2

So I sent this PUT request to /api/v1/firewall/nat/outbound/mapping

{
  "apply": false,
  "descr": "Outbound rule",
  "src": "<IP_ADDRESS>/32",
  "srcport": "30000:50000",
  "dst": "any",
  "dstport": "any",
  "target": "<IP_ADDRESS>",
  "id": "1",
  "protocol": "udp",
  "top": false,
  "type": "pass"
}

This is accepted; however, if I then do a GET to re-read the rules, the filter has been changed to
 {
            "source": {
                "network": "<IP_ADDRESS>/32"
            },
            "sourceport": "30000-50000",

... the sourceport has been changed from 30000:50000 to 30000-50000. Therefore, applying the rules (either via the API or via the UI) causes an error with the filter reload
There were error(s) loading the rules: /tmp/rules.debug:59: unknown port 30000-50000 - The line in question reads [59]: nat on $WAN inet proto udp from <IP_ADDRESS>/32 port 30000-50000 to any -> <IP_ADDRESS>/32  static-port # Outbound rule
How do I sent the update to pfSense via the API, without the : being changed to a - ?

Hey!
Thanks for reporting this issue. This looks to be a bug. The context which replaces - with : is reversed in the code here which is what is causing this issue:
https://github.com/jaredhendrickson13/pfsense-api/blob/0fea7a6d1d296bfd7f460ce5cab0a97e0d2236d9/pfSense-pkg-API/files/etc/inc/api/models/APIFirewallNATOutboundMappingCreate.inc#L226
I'll have a fix for this in the next patch.
Thanks!


Consider adding the ability to pass non-standard custom html elements in the tag property

Consider adding the ability to pass non-standard custom html elements in the tag property

components: All components which have a tag property
reactstrap version latest

What is happening?
Presently if you pass a non-standard custom html element value like
<Badge color="primary" pill tag="my-custom-element" />
then you would have to manually pass the bootstrap class names of "badge badge-primary badge-pill" in the className property
What should be happening?
the rendering of the custom element in Reactstrap could be made to check to see if the tag property contains a dash (as all custom non-standard elements must contain a dash) and then render the tag with a class property instead of the className property
Code
I believe something like this could work in most Reactstrap components:
if (Tag.includes('-')) {
  return <Tag {...attributes} class={classes} ref={innerRef}>{children}</Tag>;
}
return <Tag {...attributes} className={classes} ref={innerRef}>{children}</Tag>;

This feature request is really only relevant if you are interested in supporting very semantic html through non-standard custom html element names.  If not feel free to close.

Probably should support this... but that looks bad. There has to be a better way than duplicating the line and changing className to class.

Could make a Tag component which does this so we only have to look at the bad code once :)

This could work.  When false for className property, the property is set to null and ignored:
return (
  <Tag
    {...attributes}
    class={Tag.includes('-') && classes}
    className={!Tag.includes('-') ? classes : null}
    ref={innerRef}
  >
    {this.props.children}
  </Tag>
);


Fix pdPath parameter to point to an executable file

PdPath points to a folder not an executable right now.

Is this why all actions are failing?

@adrianriobo it fixes just Podman Desktop E2E Podman Installation step in one workflow that used locally built executable.
Job I tried to run after adjusting the pde2e-builder image: https://github.com/containers/podman-desktop-e2e/actions/runs/6948326419. The steps is now again passing. Although there are other failures, not related to this. So the fix is at place, now I need to address other problems.

The fix was to pass an executable path rather then folder with executable. We fixed this here, I forgot to update it in the image.

fixed by https://github.com/odockal/pde2e-builder/commit/ea1ca8c96e6da1e36d7fbd070cbfbf670b4e159f.


fix: memoryCache.get should return copy

Thanks.  I think this should use a flag similar to shouldCloneBeforeSet (we could call it shouldCloneAfterGet) and would need a couple tests.

It clearly looks like a bug and shouldn't use flag. Because of that memory cache has different behaviour than other adapters. When you push object A into the cache and then modify it, it's going to change the cached instance without settting it again through the cache interface. That's uncommon for the caches and I would never expect such a behaviour.

It's not really a bug.  If this is a bug, then the bug also exists in the LRU-cache library.  It's arguably not a good practice to be storing javascript objects in cache anyway, but if you are going to store them, you may actually want to be able to modify the object while it's in cache. I wouldn't do it, but someone might.
I think the default behavior of the set method (like the get method) should be not modifying the objects -- that is, the cache is a transparent wrapper around the underlying store, so users can expect the same behavior as if they used the LRU-cache library directly.
In any case, we already have shouldCloneAfterGet, so we should be consistent and use a flag for the set method as well.

See also: https://github.com/BryanDonovan/node-cache-manager/pull/103 and https://github.com/BryanDonovan/node-cache-manager/issues/137

Closed by refactor #203


feat: Allow excluding a user agent in a fetch request by setting it's header to null.

Closes #704
Signed-off-by: Richie Bendall<EMAIL_ADDRESS>

This PR was never merged into the master branch for some reason 🤷♂


Ping pong support

This is my cut at adding ping/pong support. It is straightforward if put directly on the receive() method and has the advantage of being able to set different values for different endpoints within the one app. I can also see the value in just having ping/pong always enabled, it is in the spec and clients must support it but I guess having as an option would allow for dealing with broken clients if they appear. I'm going to have a look at the tests but I got myself confused on with those to start with, need to understand what is going on with mock sockets.

@sock.route("/echo")
def echo(ws):
    while True:
        data = ws.receive(ping_interval=5)
        ws.send(data)

Unfortunately this isn't a general solution that can be used by this package.
Also as a side note, I believe you haven't tested your solution well. Consider, for example an application that calls receive(timeout=1, ping_interval=25) in a loop. This would never send any pings, as far as I can see.

Oh definitely the mix of timeout and ping interval means one or the other if both are specified, that is understood with this, it's certainly not a fundamental issue with sending pings in a receive loop as it would just require maintaining a timer rather than the flag.
For an app that never has a receive loop you'd need to have another loop waiting on a timeout to send the ping. This is the biggest complication being on a thread rather than an event loop.


[Feature Request]:  Maximum height value

Contact Details
<EMAIL_ADDRESS>Is your feature request related to a problem? Please describe.
I am using Expandable Carousel. I want to set the maximum height. Thanks
Describe the solution you'd like
Maxheight:
Describe alternatives you've considered
I think easy solution
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I'm not sure if wrapping the Expanded widgets inside a ConstrainedBox will work since Expanded calculates it dynamically, would you be able to share a sample of code?

ConstrainedBox worked. Thanks


Add support for ACE arsenal on red lockers

Also regroup with BI arsenal action in a common "arsenal" parent ACE ineteraction (similar to #4)

It seems that ACE arsenal cannot be under a parent action (see https://github.com/acemod/ACE3/blob/master/addons/arsenal/functions/fnc_initBox.sqf)

Alternative idea : create the ACE arsenal the default way, then try to "move" the action by manually modifying the action path. Currently trying to achieve this

Nevermind, found a wayyyy cleaner workaround : https://github.com/acemod/ACE3/blob/master/addons/arsenal/functions/fnc_openBox.sqf

Do you have a fix commit sha to provide before closing ?

It is closed, automatically from commit https://github.com/team-gsri/GSRI-Opex/commit/c44da7c80af3f62bb2b15e29e1a3445158b90c85, see above

Perhaps I should sleep instead of reviewing projects at night ^^


.gitignore

All node modules are in the repo, making it huge. Think there should be a git ignore of the node_modules folder

Fixed in c397ef9


feat: allow math functions to parse input from Utf8

Is your feature request related to a problem or challenge?
log10('-Infinity');
log2('-Infinity');
power('Infinity',2)
As above, using the + infinity function in some math functions will report an error in arrow-datafusion, but mysql and posgtres will not report an error. I think the + infinity parameter is meaningful in mathematics.
--postgres
postgres=# select power('Infinity', -2);
 power
-------
     0
(1 row)postgres=# select log('Infinity', 2);
 log
-----
   0
(1 row)postgres=# select log10('Infinity');
  log10
----------
 Infinity
(1 row)postgres=# select power('Infinity', 2);
  power
----------
 Infinity
(1 row)

--mysql
mysql> select log10('+Infinity');
+--------------------+
| log10('+Infinity') |
+--------------------+
| NULL |
+--------------------+
1 row in set, 2 warnings (0.00 sec)mysql> select power('Infinity', 2);
+----------------------+
| power('Infinity', 2) |
+----------------------+
| 0 |
+----------------------+
1 row in set, 1 warning (0.00 sec)mysql> select power('-Infinity', 2);
+-----------------------+
| power('-Infinity', 2) |
+-----------------------+
| 0 |
+-----------------------+
1 row in set, 1 warning (0.00 sec)mysql> select log10('-Infinity');
+--------------------+
| log10('-Infinity') |
+--------------------+
| NULL |
+--------------------+
1 row in set, 2 warnings (0.00 sec)

Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response

@alamb Maybe I need some opinions from you. In my opinion, this is also a complicated issue.

Datafusion does actually support this it seems:
❯ select log(arrow_cast('+Infinity', 'Float32'));
+------------------------+
| log(Utf8("+Infinity")) |
+------------------------+
| inf                    |
+------------------------+
1 row in set. Query took 0.002 seconds.

❯ select log(arrow_cast('-Infinity', 'Float32'));
+------------------------+
| log(Utf8("-Infinity")) |
+------------------------+
| NaN                    |
+------------------------+
1 row in set. Query took 0.002 seconds.

❯

Could you elaborate on which math functions are throwing error in cases of infinity input?

Datafusion does actually support this it seems:
❯ select log(arrow_cast('+Infinity', 'Float32'));
+------------------------+
| log(Utf8("+Infinity")) |
+------------------------+
| inf                    |
+------------------------+
1 row in set. Query took 0.002 seconds.

❯ select log(arrow_cast('-Infinity', 'Float32'));
+------------------------+
| log(Utf8("-Infinity")) |
+------------------------+
| NaN                    |
+------------------------+
1 row in set. Query took 0.002 seconds.

❯

Could you elaborate on which math functions are throwing error in cases of infinity input?

Thank you for your reply. It seems that you need to do some cast conversion. Can't you log2('-Infinity') directly?

Yeah that would seem reasonable. I guess it would involve changing the signatures of the math functions to also accept Utf8 data type, then try parse into float (or something like that)

I've updated the issue title to better reflect this :+1:
(Since less of an issue with infinity, and more just a general data type issue with math functions)

I've updated the issue title to better reflect this 👍
(Since less of an issue with infinity, and more just a general data type issue with math functions)

Very happy to see the way arrow-datafusion handles this, it's a way I would like to see, I think doing a cast is a very rigorous behavior

@Jefffrey But I think this cast should be an implicit conversion. If not, maybe we should indicate this in the tests and documentation.

Yes, I think this is what I was trying to convey, that we should allow log('100.0') to be implicitly converted to log(100.0) since we can already cast from Utf8 to Float. I just might be wrong on the exact implementation details as I'm not as familiar with the internals of the function related code :slightly_smiling_face:

@Jefffrey But I think this cast should be an implicit conversion. If not, maybe we should indicate this in the tests and documentation.

Yes, I think this is what I was trying to convey, that we should allow log('100.0') to be implicitly converted to log(100.0) since we can already cast from Utf8 to Float. I just might be wrong on the exact implementation details as I'm not as familiar with the internals of the function related code 🙂

Maybe I want to try it, but I'm not sure I can pull it off

@Jefffrey I will try to add some tests first and then find the problem. At present, the math function should have some negative tests that need to be improved.

@Jefffrey But I think this cast should be an implicit conversion. If not, maybe we should indicate this in the tests and documentation.

Yes, I think this is what I was trying to convey, that we should allow log('100.0') to be implicitly converted to log(100.0) since we can already cast from Utf8 to Float. I just might be wrong on the exact implementation details as I'm not as familiar with the internals of the function related code 🙂

I think this process is called "coercion" in the datafusion codebase.
So we  would need to add a coercion from DataType::Utf8 to float perhaps

I think this process is called "coercion" in the datafusion codebase.
So we would need to add a coercion from DataType::Utf8 to float perhaps

double or float?

So we would need to add a coercion from DataType::Utf8 to float perhaps

double or float?

I think we would probably need the coercion for both Float32 and Float64

@alamb I have some ideas about type conversion. I am trying out my ideas on calcite. If it makes sense, I will transplant it to arrow-datafusion. This may take some time.

@alamb I have some ideas about type conversion. I am trying out my ideas on calcite. If it makes sense, I will transplant it to arrow-datafusion. This may take some time.

Thanks @caicancai  -- BTW I find following the example of existing systems is helpful in cases like this (there is no need to reinvent different coercion rules)
For example, postgres appears to happily coerce UTF8 -> float:
postgres=# select sqrt('1.4');
        sqrt
--------------------
 1.1832159566199232
(1 row)


Runtime applying for data

text and mermaid file for Luke to review

Much of this was already covered in a previous PR, so merged and revised most of this into the other text.


[RODE-76] Add ListResourcesRequest

Adds a ListResources rpc call to enable resource search. Currently it's modeled after ListOccurrences so it exposes a filter and pagination options; however, only filtering is enabled, pagination is not implemented. Filtering happens against the underlying occurrences resource, since there isn't a resource entity to query against.
Example call:
curl http://localhost:50052/v1alpha1/resources

{
  "resources": [
    {
      "name": "",
      "uri": "https://docker.io/library/alpine@sha256:08d6ca16c60fe7490c03d10dc339d9fd8ea67c6466dea8d558526b1330a85930",
      "contentHash": null
    },
    {
      "name": "",
      "uri": "https://docker.io/library/alpine@sha256:foo",
      "contentHash": null
    },
    {
      "name": "",
      "uri": "https://docker.io/library/alpine@sha256:bar",
      "contentHash": null
    }
  ],
  "nextPageToken": ""
}

With a filter on the matched occurrences:
http://localhost:50052/v1alpha1/resources?filter=%22resource.uri%22%20%3D%3D%20%22https%3A%2F%2Fdocker.io%2Flibrary%2Falpine%40sha256%3Afoo%22

{
  "resources": [
    {
      "name": "",
      "uri": "https://docker.io/library/alpine@sha256:foo",
      "contentHash": null
    }
  ],
  "nextPageToken": ""
}

@mrparkers Yeah the filter here is really against the occurrences, since there isn't a separate document for the resource. That does allow for interesting queries like "give me all resources that have been deployed (have a deployment occurrence)", but it's not a resource filter.
We could use the nested query syntax, but that looks to still need the full path.

Gotcha, yeah I guess as long as we document how it works, that's probably the best we can do.

Codecov Report

Merging #24 (7e8a7b0) into main (1385ec7) will decrease coverage by 3.54%.
The diff coverage is 77.35%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   92.81%   89.27%   -3.55%
==========================================
  Files           6        6
  Lines         181      233      +52
==========================================
+ Hits          168      208      +40
- Misses         11       18       +7
- Partials        2        7       +5

Impacted Files
Coverage Δ

server/server.go
82.55% <73.91%> (-9.95%)
:arrow_down:

config/config.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1385ec7...7e8a7b0. Read the comment docs.


Tree shaking keeps SPI/I2C even if not used

This program should have the same devs disasm regardless if the import is present or not
import { startBME680 } from "@devicescript/drivers"
console.log(Buffer.alloc)

branch: https://github.com/microsoft/devicescript/tree/var-when-used branch  - but this requires some work with cell assignment in the compiler


Allow aliases of variants in ABI

Change Description
This resolves #7254
We had a redundant validation that attempted to prevent aliasing to an unknown type however, this was done before variants were loaded so, it would reject an alias of a variant.  ::validate will perform this validation after all types are known so, this assert was not needed
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

We may want to backport this to supported versions as it is preventing tooling based on those versions from accepting well-formed ABI's from CDT


Filters out the search button

Everything is working great with this plugin except for the fact that it also filters out my submit button at the bottom of the table. Is there a way to make sure the submit button always stays after the filter?

Your data should sit inside <tbody> tags.
http://www.w3schools.com/tags/tag_tbody.asp
It sounds like your submit button should sit inside <tfoot> tags.
http://www.w3schools.com/tags/tag_tfoot.asp
By default, jquery-sieve only filters rows inside <tbody>.


Question regarding timer

I know it has been awhile since you've look at this repo but I had a question regarding your comment about using a timer instead of a delay.
When you say a timer should be used instead, do you mean driving the STEP pin high/low via a timer interrupt?
If not, what did you mean by the comment?

Yes, it's exactly what I meant


Quests start/end event bug

Quests version 3.7.3
stages:
  ordered:
    '1':
      npc-ids-to-talk-to:
      - 4
      start-event: start1
      finish-event: end1
    '2':
      npc-ids-to-talk-to:
      - 4
      start-event: start2
      finish-event: end2

As you can see, there are 4 events: start1, end1, start2, end2
but when you do it, event start1 is executed when receiving quests, after completing stage 1 it will execute end1 and add once start1, after completing stage 2 it will execute end2, not appearing start2 in here.
so start1 appears twice and start2 does not appear once.
Is that a bug?
Sorry for my english

I had the same bug


Helmify

As a developer, I would like a Helm chart so that I can easily deploy this app to Kubernetes with helm install.

@bookjunkie93 - how we going on this? Let me know if you want an orientation or some ideas!


Dynamically passing json to channelData

I have store Generic template json in property and I was trying to assign that property value to ChannelData inorder to render the gengeric tempale in facebook channel but it not getting rendered.
@vishwacsena  can you look into it.

@KoradaRajesh  Maybe you can reference following ?
https://github.com/microsoft/BotFramework-Composer/issues/2549#issuecomment-611442549

@hibrenda , here the value to be added in to ChannelData is being sent from a function app.
The JSON is assigned to a variable and we are trying to render the template in the following way where dactivity is the response content we got back from the action.
dactivity()

'${dialog.response.content}'

bfdactivity-387808()
[Activity
ChannelData=${json(dactivity())}
]
Is there anything we are missing or doing wrong?

@hibrenda I'm able to render facebook templates by assaigning the json value to channel data in activity by staticaly but i want to pass an Action response to that channel data for this scenario I have tried the folowing..
[Activity
ChannelData=${json(dialog.result.content)}
]
[Activity
ChannelData=${dialog.result.content}
]
#dactivity()
-'${dialog.response.content}'
#bfdactivity-387808()
[Activity
ChannelData=${json(dactivity())}
]

hi, @KoradaRajesh I may could answer this issue
-'${dialog.response.content}' would be evaluated to a string like '{jsonbody}', I guess what you expect to get is just the string format of {jsonbody}, the way use ' to transfer the json result into string is not correct, the right way is use string convert function, try this one:
#dactivity()
-${string(dialog.response.content)}

#bfdactivity_387808() // LG does not support '-' in the latest version
[Activity
ChannelData=${json(dactivity())}
]

it supposed to work. Thanks.

@Danieladu i tried that but it's not rendering the template is there any other solution to achieve this.
#TemplateJson()
-${dialog.response.content}
DisplayTemplate
[Activity
ChannelData=${TemplateJson()}
]

@KoradaRajesh what is the value of "dialog.result.content"?

{
"attachment":{
"type":"template",
"payload":{
"template_type":"button",
"text":"What do you want to do next?",
"buttons":[
{
"type":"web_url",
"url":"https://www.messenger.com",
"title":"Visit Messenger"
}
]
}
}
}

@KoradaRajesh WOW, this sample is the same with #2618, you can have a reference.
If finally still can not achieve the expected result, please check the code into a specific branch, and we can repro this issue. Thanks.

@Danieladu In this #2618 they gave data statically in LG but In my scenario, I'm storing JSON value in a property and trying to send it to the ChannelData but it's not working but if I store soon value in LG property and send it to the ChannelData it's working fine. What would be the issue here?
This is the property I'm storing json  dialog.response.content
This is the process I'm passing JSON to the ChannelData
#bfdactivity_387808()
[Activity
ChannelData=${dialog.response.content}
]
#bfdactivity_387808()
[Activity
ChannelData=${josn(dialog.response.content)}
]

@Danieladu In this #2618 they gave data statically in LG but In my scenario, I'm storing JSON value in a property and trying to send it to the ChannelData, It's not working but if I store JSON value in LG property and send it to the ChannelData it's working fine. What would be the issue here?
This is the property I'm storing json  dialog.response.content
This is the process I'm passing JSON to the ChannelData
Below scenarios I have tried.
#bfdactivity_387808()
[Activity
ChannelData=${dialog.response.content}
]

#bfdactivity_387808()
[Activity
ChannelData=${josn(dialog.response.content)}
]

#TemplateJson()
-${dialog.response.content}
#DisplayTemplate
[Activity
ChannelData=${TemplateJson()}
]

#TemplateJson()
-${json(dialog.response.content)}
#DisplayTemplate
[Activity
ChannelData=${TemplateJson()}
]

#TemplateJson()
-${dialog.response.content}
#DisplayTemplate
[Activity
ChannelData=${json(TemplateJson())}
]

@Danieladu can you create a sample bot that picking channel data from memory, and display it via LG to make sure this step is validated in @KoradaRajesh side. if it's working in KoradaRajesh's side, then the problem will be in memory value perhaps not correectly set.
Also @KoradaRajesh can you attach your bot here? so @Danieladu  can help debug directly probabaly?

hi @KoradaRajesh  I have test the dynamic assignment with composer, and it works. Here is the bot project:
EmptyBot-0.zip
The output result is as same as the static assignment.
Maybe you can try it and look forward to your reply

@Danieladu It's working but the template is not rendering without activity text is this possible to render templates without text. I have tried it but it's not rendering.
[Activity
ChannelData=${dialog.response.content}
]

hi @KoradaRajesh  It's a bug in SDK. I have filed an issue to track this one. link is here :
https://github.com/microsoft/botbuilder-dotnet/issues/4001
The workaround is add a text property in activity structure. Thanks!

Thanks @Danieladu I will track that Issue

Close this in favor of microsoft/botbuilder-dotnet#4001


cmd/go,cmd/trace: document the trace command

go help testflag does not mention the -trace flag
The output of go tool trace -help is unhelpful:
Usage of 'go tool trace':
Given a trace file produced by 'go test':
go test -trace=trace.out pkg
Open a web browser displaying trace:
go tool trace [flags] pkg.test trace.out
Flags:
-http=addr: HTTP service address (e.g., ':6060')
Also, shortly after the 1.5 release, there should be a blog post about the feature.

go help testflag does mention the -trace flag
I've tried to describe -trace everywhere where cpu and memory profiles are described.
go tool trace -help is roughly the same as to tool cover -help, except that trace has fewer flags than cover.
Is there anything else to fix?

I think it's all good now.

Is there still plans to do a blog post on the trace tool? There's not much documentation on how to read the output from go tool trace.

@prashantv Do you mean the generated HTMLs?
There are still plans to write the blog, not nobody is actively working on this ATM.

Yes, the generated HTML / SVGs. Hope to see the blog post soon!


Check if device update is available

Hi,
How/where can I see if a device update is available via FGM API or this PowerShell Module?
I have tried loking everywhere within this repo but cannot find the information?
TIA

Hi @JimBobUKII
You want known if there is new firmware for the firewall ?
i need to check if there is a API available on monitoring URI...

Hi @alagoutte
Yes, want known if there is new firmware for the firewall ?
I cannot seem to find one on the rest api but could be wrong!
TIA

Hi Jim,
you can use
(Invoke-FGTRestMethod -uri api/v2/monitor/system/firmware).results

There is 2 fields current and available
(Invoke-FGTRestMethod -uri api/v2/monitor/system/firmware).results.current

name         : FortiOS
id           : current
version      : v6.4.1
major        : 6
minor        : 4
patch        : 1
build        : 1637
branch-point : 1637
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.4.1-release-notes/download
source       : current
platform-id  : FGT2KE

(Invoke-FGTRestMethod -uri api/v2/monitor/system/firmware).results.available

name         : FortiOS
id           : 06004000FIMG0018304002
version      : v6.4.2
major        : 6
minor        : 4
patch        : 2
build        : 1723
branch-point : 1723
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.4.2-release-notes/download
source       : fortiguard

name         : FortiOS
id           : 06004000FIMG0018304000
version      : v6.4.0
major        : 6
minor        : 4
patch        : 0
build        : 1579
branch-point : 1579
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.4.0-release-notes/download
source       : fortiguard

name         : FortiOS
id           : 06002000FIMG0018302005
version      : v6.2.5
major        : 6
minor        : 2
patch        : 5
build        : 1142
branch-point : 1142
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.2.5-release-notes/download
source       : fortiguard

name         : FortiOS
id           : 06002000FIMG0018302004
version      : v6.2.4
major        : 6
minor        : 2
patch        : 4
build        : 1112
branch-point : 1112
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.2.4-release-notes/download
source       : fortiguard

name         : FortiOS
id           : 06002000FIMG0018302003
version      : v6.2.3
major        : 6
minor        : 2
patch        : 3
build        : 1066
branch-point : 1066
release-type : GA
notes        : http://docs.fortinet.com/d/fortios-6.2.3-release-notes/download
source       : fortiguard

it is good ?

@alagoutte where in your script is this?
I would like to use similar in mine
TIA

@alagoutte where in your script is this?
I would like to use similar in mine
TIA

You need to use the Invoke-FGTRestMethod....

I've tested this (on 6.2.x) and works fine, thanks @alagoutte !

hi @JimBobUKII it is good ? i can close the issue ?


Update index-state to 2020-10-01

@newhoggy I'm curious why you are pushing this change. cardano-node already uses the new index-state. Is it just for consistency?
It's just that it's not ideal when people unrelated to the repo or dependency, update a dependency that might cause lots of breaking changes (see the CI failures). I'm currently working on a dependency update of cardano-ledger-specs in #2679, but first three more PRs (https://github.com/input-output-hk/cardano-ledger-specs/pull/1922, https://github.com/input-output-hk/cardano-ledger-specs/pull/1902, https://github.com/input-output-hk/cardano-ledger-specs/pull/1923) need to be merged in cardano-ledger-specs.
Unless you can drop the dependency bump of cardano-ledger-specs, this PR will have to wait until the four PRs I mentioned are merged.

Thanks for your advice.  Fortunately, I the earlier decision to make the new version of cardano-prelude backwards compatible means I ought to be able to do as you suggest and not bump cardano-ledger-spec.  I'll try that now and see how it goes.

bors merge


More specific error messages when a problem is encountered with the configuration [vol2]

Is your feature request related to a problem? Please describe.
This has already been solved by https://github.com/dotansimha/graphql-code-generator/issues/6355 but it kind of seems like the problem is still there.
Describe the solution you'd like
I'm running codegen and getting
✖ Invalid Codegen Configuration!
◼ Generate outputs

I don't know whats wrong. I'd like a stacktrace or some more concrete message.
Describe alternatives you've considered
VERBOSE=1 DEBUG=1
Additional context
    "@graphql-codegen/add": "^3.2.1",
    "@graphql-codegen/cli": "^2.12.2",
    "@graphql-codegen/fragment-matcher": "^3.3.1",
    "@graphql-codegen/typescript": "^2.7.3",
    "@graphql-codegen/typescript-document-nodes": "^2.3.3",
    "@graphql-codegen/typescript-operations": "^2.5.3",
    "@graphql-codegen/typescript-react-apollo": "^3.3.3",

+1 really difficult to debug when there's an unknown issue like
[FAILED] Cannot read property 'type' of undefined

For my issue, we ended up finding out that our backend using https://github.com/strawberry-graphql/strawberry with django and the https://github.com/blb-ventures/strawberry-django-plus library, was causing the schema to expect a query that's laid out in a fragment like below:
mutation createContacts($new: ContactInput!) {
  createContacts(data: $new) {
    ...on ContactNode {
      id
      name
      email
    }
  }
}

The codegen tried to generate code based off our written mutation that's in a no-fragment format like:
mutation createContact($new: ContactInput!) {
  createContact(data: $new) {
    id
    name
    email
  }
}

Maybe this info is targeted enough to address the debuggability here?


REI being funky with the Akashic Record recipe

when viewing the Akashic Record recipe in REI for 1.19.2 it shows this weird tree view

My gut feeling is that because it can't find a normal recipe for it, it's just displaying the entire tag view.
Does something similar happen for other items without recipes? (Like bedrock)

it appears to be happening to all items (even craftable ones like wooden planks)
i dont know why it is showing all the tags though

Do you know if this bug is still present in the latest 1.20.1 prereleases?


getOrCreateProgressForAchiever ignores achiever?

Problem:
Only for user A a database record was created in the "achievement_progress" table.
$progress = AchievementProgress::where('achiever_type', $className)
->where('achievement_id', $achievementId)
->where('achiever_id', $achiever->id) // i think you forgot this line?
->first();

Absolutely! Thanks for noticing. Fixed on 0.0.3.


Not sure how to instantiate a macawview class

Like in this issue: https://github.com/exyte/Macaw/issues/140, I really don't understand how to do this. When I try
class EasingView: MacawView {
    override init(frame: CGRect) {
        let text = Text(text: "Hello, World!", place: .move(dx: 145, dy: 100))
        super.init(node: text, frame: frame)
    }

    @objc required convenience init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}

it says that I can call only designated initializer. How do I do this all in all or where I can read smth and understand anything?

Hi, @m8dotpie, yea, init(node: Node, frame: CGRect) convenience initializer. In subclass, you can't call convenience initializer of your superclass, only designated. You can find info about initializers in swift here.
So, for your case, you can do the following:
class EasingView: MacawView {
    override init(frame: CGRect) {
        super.init(frame: frame)
        let text = Text(text: "Hello, World!", place: .move(dx: 145, dy: 100))
        node = text
    }

    @objc required convenience init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}


feat(): support Arconnect signer

Add InjectedArweaveSigner function for support Arconnect signer

yes our demo website https://demo.web3infra.dev has support arconnect sig data to bundle item


As an admin, I want to see when an item was added to the archive and when it was last modified so that I can see which materials were added and changed and when.

[x] modify import script to only update db/solr records when they have changed

Not properly ready for testing because only when added works but updated is in progress.

I've modified the script so it will now only update previously imported/indexed content if the hathi materials have changed since the local record was last modified (based on the lastUpdate field in the bibliographic API data for that specific copy of the work) or when the person running the script explicitly requests an update (--update).  I've been puzzling over how to make this testable for you, and here's what I've come up with.
Here's some output from running the script.  This is after a previous import, and I'm not requesting updates, so records should only be updated if the hathi record has changed:
 python manage.py hathi_import --progress -v 0

100% (5007 of 5007) |###################################################################################################| Elapsed Time: 0:22:16 ETA:  0:00:00
Processed 5,007 items for import.
Added 0; updated 0; skipped 5,007; indexed 0 pages.

For convenience (mine), I've also added an option to index specific records by htid, so I also ran the script on a few records with the update option requested:
python manage.py hathi_import yale.39002004065844 yale.39002004911344 wu.89000721803 chi.79279237 chi.79213384 --update
You should be able to see them in the admin list view
What you can't directly test is whether my logic for honoring hathi's lastUpdate date is working correctly - so please

This logic makes sense to me, and I can sort when an item was added vs. when it was modified which is why I would want this admin capability in the first place (scenario: we did a bulk import on Dec. 7, but we corrected the metadata for a view items on Dec. 11 but we made a mistake and need to go back into those files). My own question is what if a file was updated multiple times. Is there a way to track not just the most recent updates, but all? That seems to be outside the parameters of this story's wording and I don't think it's something we need to absolutely have, I'm just wondering whether that is already being tracked as you've built this and if there is a way for us to see it.

@meagan1019 good question! Django admin has a built in log / history function.  If you click in to an individual record, you should see a "history" button on the top right (make sure you have clicked "Ok" on the test banner).  By default, this will only track edits made through the admin site - try changing a record and then look at the history again.
We can add logic to generate those log entries from the import script - it sounds like that might be valuable and something we should add now, so that we will have a full record of when and how things were added.  What do you think?

Yes, I think if it's an easy thing to do and is already being tracked in Django let's add it. One issue: I did try to edit yale.39002004065844. I was just going to correct the comma in the publisher. BUT: I get an error when I try to save: It won't let me save without adding "Enumeration/Chronology." It says "This field is required." Most books don't have this field so it shouldn't be required to add on editing.

@meagan1019 good catch! agreed, that field should be optional.  I'll correct that.

@meagan1019 enumcron field is now optional.  I see now you marked this as "tested needs attention", but I'm not clear on what is needed for you to be able to accept it.

Sorry - I put that because of the enumeration thing. Changed to accepted! Amazing work!


Vec! is resolved as type

Highlighting is incorrect:

Documentation is shown for Vec.
Go to definition finds Vec definition, etc.
rust-analyzer: 823e9193

Well, Vec is the type, and vec! is the macro (note the casing), so it looks like "expected" behavior on otherwise erroneous code.

Yes, there is Vec in scope, but it can't be used as macro. So rust-analyzer should return error ("unknown macro Vec") instead of false-positive.

Rust-analyzer is still a work in progress, so many things that should be
reported as semantic errors are not implemented yet.
If you use the in-server cargo watch functionality you will get the error
you expect, when you save the file.
On Tue, 31 Dec 2019, 21:23 Mikail Bagishov<EMAIL_ADDRESS>wrote:

Yes, there is Vec in scope, but it can't be used as macro. So
rust-analyzer should return error ("unknown macro Vec") instead of
false-positive.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/2686?email_source=notifications&email_token=AABTDKNC4M4UVC4WBKJMT23Q3OS4JA5CNFSM4KBMUBC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH4UUXA#issuecomment-569985628,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABTDKNFJYJS2SSSRGV3RYDQ3OS4JANCNFSM4KBMUBCQ
.

Yeah, we don't display errors for name resolution at the moment, because there are some false positives. So this is just an instance of a bigger high-level problem, and doesn't need to be tracked as a separate issue.


JS actions to compileAsHtml templates

so the ask is this, you want to add an ng-click, or a popover or ANYthing to an info status card row item
the problem is this, not doable because of the way trustashtml was not meant to build directives
so the solution is this, (well inspired by this) a directive that watches the template and recompiles it when necessary https://docs.angularjs.org/api/ng/service/$compile#example

@jeff-phillips-18 can ya fill me up with labels and assign to meeeee ? ❤ 🙇♀

Hmm...only issue is that we are trying to stay away from $compile because it is not supported in angular 2+

SNAP, good headsup @dtaylor113  didn't know, i saw it used in heatmap and thought it was ok....

@dtaylor113 ya think that makes this ask doa?

yeah, heatmap is the only remaining component with $compile, just because we haven't had time to investigate how to get it working without a $compile.

Ok gonna close this, will hand role the thing in the app.   Thanks for the eyes @dtaylor113 🙇♀


Function _implements is missing when create a new object

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):debian10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):2.7.0
Python version:3.9.0
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
_implements is missing in new objects.
Describe the expected behavior
_implements exists.
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf

experimental_implements = " ".join(['name: "addons:MaxUnpooling2D"'])
@tf.function(input_signature=[tf.TensorSpec(shape=[], dtype=tf.float32), tf.TensorSpec(shape=[], dtype=tf.float32)], experimental_implements = experimental_implements)
def test(a, b):
    return a+b

class Test(tf.Module):
    @tf.function(input_signature=[tf.TensorSpec(shape=[], dtype=tf.float32), tf.TensorSpec(shape=[], dtype=tf.float32)], experimental_implements = experimental_implements)
    def test(self, a, b):
        return a+b

model = Test()
model2 = Test()
model.test = test
assert model.test._implements == test._implements
assert model2.test._implements == Test.test._implements

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Hi @Saduf2019! Could you please look into this issue? It is replicating in TF 2.6, 2.7 and Nightly .

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Add value_sat and value_msat to Payment

This PR is following PR https://github.com/lightningnetwork/lnd/pull/1855
In addition to that change in invoice response I believe the same convention is needed in outgoing payments to remove confusion and for consistency.
This PR also maintains backward compatibility by leaving and deprecating the current "Value" field.

Done!

The two proto changes should be squashed together (and regenerated), otherwise LGTM!

Squashed.

Needs a rebase to remove the merge branch master commit.

Removed

Needs a rebase to fix the proto conflict.

Yep changes look good to me, rebase should be the last step

Rebased

fixed typo


Preview time frame code could be 00:00 by default

A good compromise between implementing complex features for the app preview frame, would be to set it to 00:00 by default , so that designers/motion designers can export videos with the poster frame as the first (or first few) frame(s) of the video. WDYT?

Specifically I was trying to do this by changing L624 of api.py to
"attributes": {"fileName": file_name, "fileSize": file_size, "previewFrameTimeCode": "00:00"}

(Linking to the docs for reference)
https://developer.apple.com/documentation/appstoreconnectapi/apppreviewcreaterequest/data/attributes
Since the previewFrameTimeCode is optional, I had left it empty for now.  I assumed (perhaps incorrectly?) that the appstore would use a reasonable default value.
My tentative plan was to specify the frameTime in a text file along-side the preview video.

If you're using AppPreviews extensively, then you might be able to test it more than I have up until now, so I appreciate any info/feedback to make it more useful :)

Specifically I was trying to do this by changing L624 of api.py to
"attributes": {"fileName": file_name, "fileSize": file_size, "previewFrameTimeCode": "00:00"}

Yeah, next step could be:

add frameTimeCode as a param (with default value) to both create_preview and update_preview
update publish_previews to look for the optional config file aside the preview video and load the frameTimeCode from it's contents.

Absolutely. Unfortunately apple picks a random point in the video for the preview by default, so even 00:00 it's quite useful as it makes it deterministic.

Unfortunately it looks like setting this to "00:00" still wont help as apple will simply ignore it 🤔 - investigating the best way to make this work

Is it possible to set it via the appstore connect web interface? Is only the api value ignored, or is the feature not available in general?

looks like I managed to make it work by waiting for the status of the upload to be complete, instead of upload_complete. however, I was thinking that having text files might not make a lot of sense for preview frame times (what if you have multiple previews?)

(what if you have multiple previews?)

One settings file per preview.  The name would match the name of the video file, and sit next to it in the previews directory.

https://github.com/bennord/appstore-tools/pull/16 has implemented this via a json attributes file.


Z3 version check breaks if Z3 prints deprecation warnings

Hi!
I'm posting this in reference to this slack channel discussion thread.
When building FStar (also through Opam), the version of Z3 is checked here. This check simply takes the output of z3 -version and if the output starts with the correct string, the check passes.
However, if Z3 prints anything else before the version number (such as deprecation warnings), this check fails. For example, when using the OpenMP library provided by LLVM version 15 (version 13 does not print this warning; I haven't checked version 14), this deprecation warning is printed: OMP: Info #270: omp_set_nested routine deprecated, please use omp_set_max_active_levels instead. Because this warning is printed before Z3's normal output (even though it is correct), the version check fails and the build breaks.
Replacing the version check from BU.starts_with to BU.contains should likely fix this issue (defined in this module).
Kindly,
Johannes

Hi Johannes, thanks for the report!
The Z3 version check should really just raise a warning. Is the build breaking because of that, or during the Z3 test that F* does on startup?
If it's the latter, changing that line won't help, but maybe the solution is just to not put Z3's stderr into the same pipe as its stdout. (I imagine this warning goes to stderr... I'm building clang to check but maybe you can easily confirm too.)

Hi Johannes. This should now work, even with the warning, with the above PR merged. We are however working on upgrading a newer Z3 version (4.12), but that will take some time.


Fix: Fix the music recommender layouts issue

Fix an issue with the 2 music recommender layouts shown

@yashika51 This fix is urgent and can be merged


Add hardcoded country/country code to addresses

When using the StringFormatter class to format addresses returned by this provider, the country is empty. Since this provider only works with Belgian addresses, we should add the country hardcoded to every address so it can be used when formatting.

Hello @DieterHolvoet ,
Thank you for your contribution!
Even though I get your point, we never change data coming from a provider in Geocoder PHP.
If, for any reason and pretty unlikely, Geopunt decides to extend outside Belgium, doing such change would return a false result.
That logic will have to be handled at your application level (instead of Geocoder PHP level).
You can of course add that information yourself to the Geocoder PHP result in your application.

You can of course add that information yourself to the Geocoder PHP result in your application.

That's the problem: you can't. Geocoder\Model\Address doesn't have setters, so there's no way to add the country to the geocoding result before passing it to the StringFormatter.
If they ever decide to expand outside of Belgium and pass a Country field to their responses, we would have to update the package anyway. Why not set it to Belgium until then?

That's the problem: you can't. Geocoder\Model\Address doesn't have setters, so there's no way to add the country to the geocoding result before passing it to the StringFormatter.

Sorry, I just checked and you're indeed right.

If they ever decide to expand outside of Belgium and pass a Country field to their responses, we would have to update the package anyway. Why not set it to Belgium until then?

Because I don't want to change anything coming from Geopunt.
It's not the goal of Geocoder PHP, the goal is only to return a common interface.


Dev

Hi @lidup, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

Hi

I assume this was sent in error.


Update manifest-schema.md

Added supportedchanneltypes example

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
92
27
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/resources/schema/manifest-schema.md
92
26
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Untraslated string

I found two untranslated strings in the admin:

The most strange thing is that i translated them in Transifex.
Technical details

Python 3.6.5
Django Version: 2.0.5.
Wagtail Version: 2.1.
Browser version: https://whatsmybrowser.org/b/QLWTTEV

Already fixed in https://github.com/wagtail/wagtail/commit/03d361b055eca1b7e799a0e2075bcd935986abc0.


When I try to open OpenBullet2 it immediatelly closes.

When I try to open OpenBullet2 it immediatelly closes. What can I do to prevent this?

Did you follow this guide
https://discourse.openbullet.dev/t/openbullet-2-installation/329

Launch it using the console command instead of double clicking the exe and you will see the error (usually you miss the runtime).

Iv'e got same probs...
Failed to load the dll from [C:\Add\OpenBullet2\hostfxr.dll], HRESULT: 0x800700C1
The library hostfxr.dll was found, but loading it from C:\Add\OpenBullet2\hostfxr.dll failed

Installing .NET prerequisites might help resolve this problem.
https://go.microsoft.com/fwlink/?linkid=798306

You need the ASP.NET runtime, not the normal .NET runtime.


Add "check -mapped"

For iCE40 and ECP5 flows the contract with the PnR tool allows $_TBUF_ cells in the mapped netlist. Although longer term we might want to look for a better solution, how about an extra -allow-tbuf option?

how about an extra -allow-tbuf option?

Good point. Added in 3e27b28.


Multiple Scopes in Client Configuration

Hi
I'm not sure if I'm missing something but it looks like its only possible to specify a single scope in the Configuration object. I have a requirement to get products and manage orders in the same project and would prefer to not have to make multiple clients.
Is there something I'm missing?
Thanks,
Henry

I just merged a fix for this issue. Please see https://github.com/commercetools/commercetools-dotnet-sdk/blob/master/commercetools.NET.Tests/ProjectScopeTest.cs for details how to define multiple scopes