fix(tds-modal): don't close when show prop is provided

Describe pull-request
Describe what the pull-request is about
Issue Linking:
Choose one of the following options

Jira: Add ticket number after CDEP-: CDEP-
GitHub: Include issue link
No issue: Describe the problem being solved.

How to test
Provide detailed steps for testing, including any necessary setup.

Go to...
Check in...
Run ...

Checklist before submission

[ ] I have added unit tests for my changes (if applicable)
[x] All existing tests pass
[ ] I have updated the documentation (if applicable)

Suggested test steps

[ ] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Interactive elements have labels.
[ ] Storybook controls
[ ] Design/controls/props is aligned with other components
[ ] Dark/light mode and variants
[ ] Input fields – values should be displayed properly
[ ] Events

Screenshots
Include before/after screenshots for UI changes.
Additional context
Add any other context or feedback requests about the pull-request here.

Using this issue to learn the work flow. I dont have access to Jira yet so cant reference connected jira issue.
Assign myself to related issue: https://github.com/scania-digital-design-system/tegel/issues/614

@nathalielindqvist Maybe we should ignore the interaction with the reference element altogether if the show prop is provided, giving full control of show/hide to implementation? or am i miss understanding?

@nathalielindqvist Maybe we should ignore the interaction with the reference element altogether if the show prop is provided, giving full control of show/hide to implementation? or am i miss understanding?

@Lunkan89 I think we have used the reference element to make it super clear how the component can be implemented in an actual application and not just rely on the Storybook controls. Since we have our demo pages in both Reach and Angular we could probably remove the reference element from our Storybook example. However, I still think the close button in the Modal itself should change the 'show' prop and the Modal should be hidden. Otherwise the Modals behavior might be misinterpreted, maybe?

This maybe a non-issue and the answer to https://github.com/scania-digital-design-system/tegel/issues/614 should just be to use closeable = false if desired behavior is to not be able to close modal on show = true.
This PR maybe obsolete?

@nathalielindqvist This maybe a non-issue and the answer to #614 should just be to use closeable = false if desired behavior is to not be able to close modal on show = true. This PR maybe obsolete?

Well the closeable prop controls whether the close button is displayed. However, it does not inherently prevent the modal from closing through other interactions, like clicking the overlay (unless the prevent prop is set to true).


[AutoRelease] t2-resource-2024-05-06-89974(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/2048
Recording test success
BuildTargetingString
azure-mgmt-resource
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/2048


Trigger eslint and flow on .flow files too

r @keybase/react-hackers?

Do all flow files currently pass lint?

Sorry, I should have run lint first! They don't, so I reverted that part. flow works, though.


bighn.user.js does not affect comments

It seems like there may have been a update recently which has broken the bighn.user.js script, causing the font size of comments to not be increased.

Thank you for creating this issue. Yes, I noted this problem recently too. Fixed in commit 1b54b6f.


[CELEBORN] Upgrade celeborn to 0.4.1 to support scala 2.13-based compilation

What changes were proposed in this pull request?
Upgrade celeborn to 0.4.1 to support scala 2.13-based compilation
How was this patch tested?
CI

Run Gluten Clickhouse CI

@zzcclp cc


batch process

it's great tool for me . I really hope add batch process and support output text file in the future.

Great! Glad you can use it. I removed the batch shell script because bmp2hex now supports multiple files for input. This works better than the shell script did (you can process all of the bmp files in a directory with one bmp2hex command as shown in the current readme). And, output to a text file is easily accomplished by redirecting standard output (you can see this in Example 3).


Helm Chart broken

Followed the instructions, yet the helm chart throws an error.
Error: INSTALLATION FAILED: template: kubetail/templates/deployment.yaml:33:28: executing "kubetail/templates/deployment.yaml" at <include "kubetail.config" .>: error calling include: template: kubetail/templates/_helpers.tpl:110:10: executing "kubetail.config" at <.>: wrong type for value; expected chartutil.Values; got string
Do KUBETAIL_CSRF_SECRET and KUBETAIL_SESSION_SECRET need to be set before attempting a deployment?

Hmm… are you using a custom value for kubetail.config? If you have a custom values.yaml file, it would help to see it so I can debug.
If the secret values are null, they will be autogenerated, stored in a Secret, then reused on subsequent deployments.

I just tried installing again from scratch using the latest helm chart and I didn't see this error. Let me know more details about your setup and I'll dig into this further.

I just added it and attempted to deploy from the instructions provided, no custom values file etc. copy and pasted exactly from command line.
 ➜ helm install kubetail kubetail/kubetail --namespace kubetail --create-namespace
Error: INSTALLATION FAILED: template: kubetail/templates/deployment.yaml:33:28: executing "kubetail/templates/deployment.yaml" at <include "kubetail.config" .>: error calling include: template: kubetail/templates/_helpers.tpl:110:10: executing "kubetail.config" at <.>: wrong type for value; expected chartutil.Values; got string
➜

Figured it out, line 110 _helpers.tpl
{{- tpl . . | nindent 0 }}

should be:
{{- tpl . $ | nindent 0 }}

Works without error once this change is applied.
helm version.BuildInfo{Version:"v3.13.3", GitCommit:"c8b948945e52abba22ff885446a1486cb5fd3474", GitTreeState:"clean", GoVersion:"go1.20.11"}

Thanks for the bugfix! It would have taken me a while to figure that out. I fixed it and pushed a new version (v0.4.3).
Here's my helm version:
version.BuildInfo{Version:"v3.14.0", GitCommit:"3fc9f4b2638e76f26739cd77c7017139be81d0ea", GitTreeState:"clean", GoVersion:"go1.21.5"}

I also tried with v3.14.4 and didn't see the error. Any idea why we're seeing different behavior? Have you modified your helm installation at all?


Package paths without quotes

Is it possible to make it optional to use in import, export quotes around what is being imported or loaded. The quotes can only be left out when there are spaces in the path. And in the IDE, you can highlight the paths with a special color somehow.

Does this cover what you want? https://github.com/dart-lang/language/blob/master/working/0649 - Import shorthand/proposal.md

I skimmed through the document for suggestions about quotes. There https://github.com/dart-lang/language/blob/master/working/0649 - Import shorthand/proposal.md#design this topic is covered and it is possible to specify the path without quotes. If I understand correctly, it also says that paths with spaces cannot be used. It seems to me that this solution will not be very flexible. You must also allow quoted paths if required. This will also ensure backward compatibility with older versions of dart.

This is a language request, and https://github.com/dart-lang/language/issues/649 is the existing request for shorter imports.


SFZ wave files in Pizzicato

What is the recommendation to load 88 wave files that use with SFZ format, contains wave files of 1MB+ each and good enough to run on Pizzicato?
What is the maximum channels we can play from wave file?

I'm not aware of a full fledged tool/library to use sfz format with web audio, nonetheless, if you just want to load the wave files and play them, you can try creating individual Pz.Sound objects.
var c5 = new Pz.Sound('./audio/c5.wav');

It wouldn't surprise me to see some performance issues with 88 objects that have a 1MB+ size each, but given that this is uncharted territories, I am pretty interested in the outcome - after which we can think how we can optimize.


[WIP] Initial distributions of permanent income and mNrm

(This revives #922, which was merged accidentally and reverted)
#592 asks for "a plausible calibration of distributions at age of workforce entry of: -Permanent income -Assets". In discussions with @llorracc, we determined the best place to get such a calibration would be the SCF. This PR works on adding calibrations of these two distributions coming ---as directly and transparently as possible--- from the SCF.
An issue is that we clearly do not want to have the full SCF in the toolbox. The solution that I propose here is:

Keep only a relatively light table with all (most of?) the summary statistics we will possibly need: WealthIncomeStats.csv. It currently contains survey-weighted means and standard deviations at multiple age-year-education combinations. I can easily expand it to contain, e.g., deciles in case one wants to avoid lognormality.
Link to a public repo that produces the table directly from raw SCF files.
Have functions that parse the contents of the table to produce the exact parameters that HARK's models need.

Please ensure your pull request adheres to the following guidelines:

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[ ] Update CHANGELOG.md with major/minor changes.

@llorracc requested that the repo where the table comes from be able to download all the data to produce the table. I've done this now.
If one clones that repo and runs do_all.R it should download and compute everything from 0.

@llorracc requested that the repo where the table comes from be able to download all the data to produce the table. I've done this now.
If one clones that repo and runs do_all.R it should download and compute everything from 0.

This is marked [WIP] only because it relies on #930, so that should ideally be merged in first.

This is marked [WIP] only because it relies on #930, so that should ideally be merged in first.


Extendable gas costs

Gas costs are currently constants in the Code that can not be changed without forking. For example https://github.com/CosmWasm/wasmd/blob/master/x/wasm/keeper/keeper.go#L41
We should not enforce the same costs on every chain that is using this module. Some options are

Params (create extra gas costs)
Overwrite via compile time flag on a var
Abstract provider interface that returns the value

Important to allow this customization.

Overwrite via compile time flag on a var

I would support this as an easy first step. You could override when compiling wasmd, or in the app.go of any chain importing x/wasm. These need to be able to be tuned, but I do not think very often.

Params (create extra gas costs)

This is an important one for any gas costs or limits that need to be adjusted "quickly" with a governance vote without redeploying a new binary. I would reflect carefully on what fields to add to params if it would really be useful (and just use public var for the rest)


OCR box should crop out the box border

Pretty self-explanatory, the blue border around the capture image should be removed:

Fixed by moving the changes from https://github.com/Xyresic/Kaku/pull/7 to 8871270dbb08057eaf7e2ea6b893975bb6d2382e.


fix: tests with aiohttp >= 3.10.0

aiohttp 3.10.0 removed the ability to create aiohttp.ClientSession instances without a running event loop (see
https://github.com/aio-libs/aiohttp/pull/8583), but one of yalexs's tests relied on that.

Thanks @cjwatson


Issue deploying VM using CLI - az vm create

Hello,
Trying to deploy a VM using pre-existing components as the user has a custom role that denies him from creating any new components (NIC, VNet, Subnet)
We've attempted the deployment from the portal and manually chose preexisting NIC/VNet/Subnet, and the deployment was successful
When we tried to deploy using cloudshell with specifying all the needed flags, we're getting the below error although we've specified all the required pre-existing components parameters in the command
Command:
az vm create --name VMName --resource-group RGName --attach-os-disk OSDiskName --nsg NSGName --os-type linux --vnet-name VNetName --public-ip-address "" --subnet SUBNETNAME
Error:
{"error":{"code":"InvalidTemplateDeployment","message":"Deployment failed with multiple errors: 'Authorization failed for template resource 'VNETNAME' of type 'Microsoft.Network/virtualNetworks'. The client 'USERNAME' with object id 'OBJECTID' does not have permission to perform action 'Microsoft.Network/virtualNetworks/write' at scope '/subscriptions/SUBID/resourceGroups/RGNAME/providers/Microsoft.Network/virtualNetworks/VNETNAME'.:Authorization failed for template resource 'NSGNAME' of type 'Microsoft.Network/networkSecurityGroups'. The client 'USERNAME' with object id 'OBJECTID' does not have permission to perform action 'Microsoft.Network/networkSecurityGroups/write' at scope '/subscriptions/SUBID/resourceGroups/RGNAME/providers/Microsoft.Network/networkSecurityGroups/NSGNAME'.'"}}
As a workaround, we've tried to use an existing NIC, and it worked, using below command:
az vm create --resource-group "RGNAME" --name VMName --nics NICNAME --attach-os-disk OSDiskName --os-type linux --size Standard_B2ms
So, we've tried to create a NIC serparately using pre-existing network components, and it worked just fine.
az network nic create --name NICNAME --resource-group RGNAME --vnet-name VNETName --subnet SubnetName --network-security-group NSGNAME --location eastus --public-ip-address ""
The question here, is why the deployment is succeeding when using a pre-defined NIC, but returning an authorization error (write) when using each networking component separately, noting that we are not creating(writing) any new components, we are using pre-existing ones?
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 152b549b-d4b3-13e5-081c-c604b6e4d89e
Version Independent ID: 3f79be78-ce75-ad31-304b-bad7d475ec9e
Content: az vm
Content Source: latest/docs-ref-autogen/vm.yml
Service: virtual-machines
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Compute

@aalmowaled Apologies for the delay, can you please give the complete debug trace for us to troubleshoot the issue?

Hi We are having the same issue.
We are wondering why we are needing Microsoft.Network/virtualNetworks/write when done with CLI versus the portal clicks do not require the same permission.
Any help on this would be awesome

@RakeshMohanMSFT  would you please be able to help with this or should i create a new issue


WhereIn Typings

Before update, the query above is correctly, but now whereIn expect a query based on Event this is not right because I can do a subquery in another table.

Typescript error:
Argument of type 'QueryBuilder<EventDate>' is not assignable to parameter of type 'QueryBuilder<Event>'.
  Type 'EventDate' is not assignable to type 'Event'.
    Property 'id' is missing in type 'EventDate'.

Fixed in 5e33cbc


Grafana queries on InfluxDB are very slow for larger history

Bug description
Querying the milestone sync time over the last 7 days currently takes 20 seconds, for example. We should adapt our Grafana queries where possible to better counter this. The analytics queries are also subject to this.

This seems to be solved with the new dashboard and the changes to InfluxDB, I can investigate large parts of the Shimmer history in Grafana without any problems.


Optimize VNC screen update to reduce delays

Previously, the VNC renderer fed the damaged region to the buffer line by line, resulting in significant rendering delays due to frequent buffer updates.
The implementation has been optimized to aggregate all updates during the current screen refresh cycle. The buffer is now updated once per refresh with the complete damaged region, reducing rendering delays and preventing screen tearing.
Previously
https://github.com/user-attachments/assets/2397db3d-a4c4-4cd6-818c-03435c5f0d89
After optimizing
https://github.com/user-attachments/assets/d6619129-8d06-4f99-8337-46776247206f
Comparing
The table compares the performance of screen updating measuring with GIFs with significant vertical variations(Selected to better illustrate the delay caused by line-by-line buffer updates) ,  before and after optimization, measured in average execution time (ms). Numbers in parentheses represent the standard deviation (std).

GIF size
Before
After

128x128
4.049ms(3.363ms)
1.928ms(1.424 ms)

256x256
15.797ms(11.030ms)
2.196ms(1.064 ms)

512x512
52.259ms(30.524 ms)
2.379ms(1.138 ms)

Close #81

Thank @ndsl7109256 for contributing!

I am curious whether the experimental data in Comparing was generated with the assistance of other tools.

I first used gprof to check the hotspot of the VNC backend and found that _twin_vnc_work takes a significant amount of time.
  %   cumulative   self              self     total
time   seconds   seconds    calls   s/call   s/call  name
18.83      0.84     0.84 197545969     0.00     0.00  _twin_run_timeout
17.04      1.60     0.76 395091937     0.00     0.00  _twin_queue_review_order
12.33      2.15     0.55 197545969     0.00     0.00  _twin_vnc_work

Then, I measure how long _twin_vnc_work takes directly using 10-second samples.
+ clock_t start = clock();
twin_screen_t *screen = SCREEN(closure);
if (twin_screen_damaged(screen))
    twin_screen_update(screen);
+ clock_t end = clock();

I first used gprof to check the hotspot of the VNC backend and found that _twin_vnc_work takes a significant amount of time. Then, I measure how long _twin_vnc_work takes directly using 10-second samples.

uftrace is useful, tool.


Add GitHub Actions workflow to update chains and flex index files

Closes #742 by creating a daily running GitHub Action workflow that builds the site and index files, then creates a PR if the files have changed. Also this relates to #745 in that now the chains should no longer need manual updating.

@dcroote So it is no longer needed to build the indexes before pushing a branch to the repo? It looks like this is a fall back in case a local build was not done.

@wkande Apologies but I don't really follow your comment. The steps build upon one another- therefore changes in the Refresh step will be present for the PR step if there are any.

So this runs on the main branch in case someone merged a previous PR that did not include running the scripts to refresh the files. Either way it looks very beneficial.

I agree this is good to keep the branch updated. It can also be triggered manually through the UI so doesn't require a previous merge

After this discussion I realized it makes sense to have this run both on a push to main and on a schedule. The former for having the index files be up-to-date with the live site and the latter for regular updates to the chains list.

Update: it works - https://github.com/api3dao/vitepress-docs/pull/749


Pack whole directory with Dockerfile to send to daemon.

This was how I resolved the inability to process the ADD or COPY commands from a Dockerfile.

Thanks! I will update the doc & test.


Ensure that copying page correctly picks up the latest revision

Fixes #10393
Ensure that CopyPageAction correctly sets the latest_revision field on the copied page before saving the additional revision - failing to do this means that the additional revision will be based on whatever is in the real database table instead.
Please check the following:

[ ] Do the tests still pass?
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?

@laymonage Updated - should hopefully now set draft_title etc correctly. In the end the fix was pretty simple - pass an update_fields to the final page_copy.save to avoid overwriting the fields set by the save_revision call.
The page_copy.latest_revision = latest_revision_as_page_revision line is probably unnecessary now, but it seems that a couple of the tests are a bit sloppy and check the return value of copy rather than the in-database version, and given that this will be going into patch releases I'd rather not risk any further changes to the external behaviour, however minor they might seem.

main a29c5c883ec85b065aecc15f67a2f500107c516a
stable/5.0.x a67e683489b8c4d57c51e941fc7edfce752fddcd
stable/4.2.x e0e10b7fd34599a08108550a4421e9572bbeff9b
stable/4.1.x 70989c50db1a662f72006ac5b2a343163348d319


Documentation how to decompress memory images compressed with avml

The README shows how to compress a memory dump but not how to decompress it. Is there a tool available to decompress it?

One will be available soon.

avml-convert was added in v0.1.2
To write a compressed file:
avml-convert --compress ./input.lime ./output.lime
To write a decompressed file:
avml-convert ./input.lime ./output.lime


TelemetryClient.Context.Operation.Id returns null

I am trying to retrieve the OperationId. I am successfully able to retrieve it with Request.Headers["traceparent"]. I was also hoping that the TelemetryClient's Context would also know of the OperationId. However, when I use TelemetryClient.Context.Operation.Id, the Context knows nothing about the Operation and returns null.
My environment is

SDK version: 2.14.0-beta5
.NET runtime version (.NET or .NET Core, TargetFramework in the .csproj file): Standard 2.0
Hosting Info (IIS/Azure WebApps/etc): IIS
Platform and OS version: Windows 10

TelemetryClient's context won't have operation id. OperationID changes per operation and  it'll be populated on individual ITelemetry items only.

What do you mean by OperationId changes per operation, if this request was triggered by another process, shouldn't this request all be under the same operation, and sharing the same operationID?

OperationID changes per operation - i meant for a single operation, all telemetry will have same id. Every new operation gets a new id.

Suppose the client or a microservice wants to send a particular operation ID (say some GUID with custom naming convention), when I try to set it using Operation ID and expect it to appear in AI with the Custom operation, it is showing differently. Operation ID is multiple IDs. Any ideas on how to achieve this?

Suppose the client or a microservice wants to send a particular operation ID (say some GUID with custom naming convention), when I try to set it using Operation ID (telemetry.Context.Operation.Id) and expect it to appear in AI with the Custom operation, it is showing differently. Operation ID is multiple IDs. Any ideas on how to achieve this?

I am not clear on what you are trying to achieve. For most customers, operation id is set automatically on telemetry based on the Activity.Current. If you give more specifics on what you are trying to achieve, we can try to help.

sorry, let me be clear.
Yes, I agree that Operation ID is set automatically. For example, Operation ID: 73943f90118e894cbe14e66bf7bc8ad0. This is an ID and all related traces, requests, exceptions are grouped under this in AI, which the PROD support teams can see. No issues with that.
My questions is how about if an app wants to set a custom operation ID? For example, "password_reset_GUID" on click of a button "Reset Password" button. where GUID is a unique random identifier. I would like to track all the telemetry related to this with a user-friendly operation ID.  This is to help PROD support teams to quickly troubleshoot if any issues. So, I tried to use Itelemetry and set it using Context.Operation.Id with a custom initializer implementation for ITelemetryInitializer. I am not successful yet sending this Custom operation ID. Hope, I am clear on this.

Most likely you are better off leaving it to application insights to populate operationid, and manually set operationname to "passwordreset".
But that doesn't mean you cannot set your own ids, and it should work.  Please describe the exact steps you did, and what was the expected outcome and actual outcome. I'd suggest to open a new issue, as this issue was about TelemetryClient not having operationid populated.

Closing as the original question is answered - parsed correlationids are stamped on to individual ITelemetry items, and not on TelemetryClient. TelemetryClient is used to track any number of telemetry, each with separate or same operationid

@cijothomas Ok but how to get to these ITelemetry items through TelemetryClient.
I too have problem when I want to log operationId I get null.

@Duke4848 Can you open a new issue describing your question? (with some example snippets, so its easier to understand what you are trying to achieve)


Release 1.6.5

Fixes https://github.com/conda-forge/pylint-feedstock/issues/4
cc @lexual

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[BUG] makeInMemoryStore

/storage/emulated/0/Download/bot/node_modules/@whiskeysockets/baileys/lib/Store/make-in-memory-store.js:157
Object.assign(contacts[update.id], contact);
^
TypeError: Cannot convert undefined or null to object
at Function.assign ()
at EventEmitter. (/storage/emulated/0/Download/bot/node_modules/@whiskeysockets/baileys/lib/Store/make-in-memory-store.js:157:24)
Node.js v20.11.1
I use the latest version v6.7.0

sock.ev.process(async (update) => {
    const obj = {};
    for(const contact of update) {
        obj[contact.id] = obj[contact.id] || {}; // Ensures that the property exists
        Object.assign(obj[contact.id], contact); // Merges contact data into the property
    }
});

To troubleshoot this issue, you should check the context in which update.id is used and ensure that it always points to a valid object in your code. It's likely that update.id is undefined or null at some point during the execution of your program, causing the TypeError when trying to assign properties to it using Object.assign.


Remove ZCPU/GPU/SPU

Unfortunately the developer hasn't been active for the past decade or so, and they've been causing a lot more harm than good recently.
Hardly anyone uses them already.
For those of you that do use it, currently trying to plan a new chip, or a rewrite at the very least, to replace it.

Fine example of the wiremod project

Oh, curses, there goes my childhood.
You got a branch or link to where this planned replacement is being developed? Zyelios was far from perfect (even if it was fun), and I'm hoping some of its mistakes can inform future decisions.

sorry i forgot to leave a comment in the 3 minute period between the PR submission and merge into master

don't forget that y'all literally didn't test this, since it disabled gpulib, which multiple screens from wire & others rely on??

why didn't they test every wire entity before merging?? 😭😭

Oh, curses, there goes my childhood.
You got a branch or link to where this planned replacement is being developed? Zyelios was far from perfect (even if it was fun), and I'm hoping some of its mistakes can inform future decisions.

Not yet, no, It's still just barely being planned, I'm not the one working on it since I don't have any clue about this area of programming. So it could even just not happen entirely, maybe someone picks up development on the CPU and it thrives as a separate addon. You can still find the CPU/GPU/SPU at https://github.com/wiremod/wire-cpu.
My idea was always a webassembly / wasi chip, but I don't think that'd apply to the same audience.

My idea was always a webassembly / wasi chip, but I don't think that'd apply to the same audience.

WASI's not bad, but always intended to be an application interface; it intentionally omits complexity deemed suitable for a "supervisor"--the details of handling open file descriptions and memory, among other things.
I'm admitting bias in being fond of RISC-V--which has a similar base spec, but a "privileged" spec that details one way of going about low-level interfaces. Since this was practically the raison d'être for HiSpeed, a low-level, MMIO-based approach (over FDs and assumptions of virtual memory) seems apropos. The ol' ZCPU, if I recall, saw its development heyday in implementing an old pluggable game console, for which BP put together a BIOS--that's my presumed target audience. (More dogmatically: if you want a scripting environment, use E2 :)
I was kinda hoping someone would have a Lua RISC-V emulator sitting around, but I'm not seeing one yet, especially not one that implements the privileged extensions. Oh well, I'll keep looking.

There are webassembly to lua compilers out there, if there's a riscv emulator that can compile to webassembly then could try and use it.
https://github.com/Rerumu/Wasynth
This is the cleanest implementation, however the luajit output needs the ffi library, unfortunately. Maybe could fork and tweak the Luau output.

There are webassembly to lua compilers out there, if there's a riscv emulator that can compile to webassembly then could try and use it.

I can't really recommend direct synthesis unless it includes a way to preempt it; Lua, on its own, does not implement preemption, and that's a really easy DoS vector for anything, real-time execution (in a game server thread) in particular. Zyelios did something of this ilk in its "microcode" bits, but only "JITed" a fixed number of instructions (up to 8) into a chunk at a time, stopping early at any branch, thus allowing a driver routine to pause execution (in order to keep up with the tickrate, e.g.). Hardware designs where an RTL is already well-defined lend themselves to this naturally; WASM is technically not an exception, but--having looked into it for yet another game a year or two ago--support for preemption in modern runtimes is lacking in preference to performance.


particles seem to accumulate while you're in other tabs

play nodekick for at least one life
die
while dead, go to a different program or browser tab
wait a minute or two
tab back to nodekick

result: MASSIVE PARTICLE EXPLOSION

I see nothing wrong with this. XD

I mean it is hilarious. I think it'd be no problem if the potential memory leak with dead players / particles was fixed.


Add XPT2046

Hello,
AliExpress vendors often fail to correctly describe (datasheets) the products they sell. That is very annoying ;) Anyway,
common small TFT like this :
https://www.aliexpress.com/item/1005006042124570.html
say ILI9341 or ST7735, good, supported by the lib.
But they say nothing about the Touchscreen driver !
On some HiRes photo, I can see XPT2046 :
https://www.buydisplay.com/download/ic/XPT2046.pdf
This one is not clearly listed as a driver.
Can you add it ?
Maybe it can be an alias for one of  CST816S, FT5x06 , GT911, GT1151 or  TT21100 touch driver ?
Apparently, it is a known chip from Espressif :
https://github.com/espressif/esp-iot-solution/blob/272ec0e4122d2f74f66a2d93467acc9f9f4b811b/components/display/touch_panel/xpt2046/xpt2046.c

Hi @Franck78,
Sure, I can add it in next week. It's not a big work since we already have the component esp_lcd_touch_xpt2046.

I have the touche screen. Next step is building the intended device around it.
I confirm prod is still with XPT2046.

Hi @Franck78, I am working on it. Please wait a minute.

oh, no hurry, I don't have pcb  and probably won't do a breakboard test ;)

oh, no hurry, I don't have pcb and probably won't do a breakboard test ;)

Sure, if your hardware is ready, please help me test the functionality of the XPT2046. Thank you.

ok, started the project, under arduino IDE
I had to add four variables (from Kconfig.projbuild)
to build it.
file esp_lcd_touch_xpt2046.h:
#define ESP_PANEL_TOUCH_XPT2046_Z_THRESHOLD (400)
#define ESP_PANEL_TOUCH_XPT2046_INTERRUPT_MODE (false)
#define ESP_PANEL_TOUCH_XPT2046_XPT2046_VREF_ON_MODE (false)
#define ESP_PANEL_TOUCH_XPT2046_CONVERT_ADC_TO_COORDS (true)

#define CONFIG_XPT2046_Z_THRESHOLD              (ESP_PANEL_TOUCH_XPT2046_Z_THRESHOLD)
#define CONFIG_XPT2046_INTERRUPT_MODE           (ESP_PANEL_TOUCH_XPT2046_INTERRUPT_MODE)
#define CONFIG_XPT2046_VREF_ON_MODE             (ESP_PANEL_TOUCH_XPT2046_XPT2046_VREF_ON_MODE)
#define CONFIG_XPT2046_CONVERT_ADC_TO_COORDS    (ESP_PANEL_TOUCH_XPT2046_CONVERT_ADC_TO_COORDS)

Okay... I also added these configurations in the file ESP_Panel_Conf.h of the library.

oh, I just updated the library and did not check more than that. I have ESP_Panel_Conf.h in my app directory and didn't check it.

So, did the XTP2046 driver work well for you?

So, did the XTP2046 driver work well for you?

good question ! I'm lost. I'm questioning the purpose of this (esp32_display_panel) !!!
My unique goal is drawing or writing things on the LCD.
Apparently, there is no such a thing here. A quick look at  "arduino GFX lib" seems to have its own 'driver' for the LCD, the touch and says nothing about binding on your (optimized) driver !!!!!!!!!


Allow PR tests to run in CI

Hey there
Following on from the conversation on #94, I took a look at the different options for running the tests in CI.
There are a few different ways we could take it:

Rewrite the current tests to mock S3 completely.
In this situation the tests would still look like integration tests but wouldn't actually be testing the storage backend.

Create new unit tests which mock s3, keep the existing integration tests.
note: the integration tests would still not be able to run on CI because they would require the decrypted secrets. If we believe there is value in keeping the integration tests (I do personally) this doesn't get us anywhere unless we introduce a dependency on the maintainers to test PRs.

The plus side of this is we'd get unit tests - but it would require a decent amount of work to add them and doesn't seem strictly related to this problem (would be nice to have regardless)

Don't test S3 on pull requests, where secrets are unavailable, but do run all the other tests.
In this scenario there would be a dependency on the maintainers to run the full suite of tests. This could be done locally or by moving the branch to jdxcode/npm-register where secrets would be decryptable by circle CI

The solution I've included for now is number 3. It's the simplest and unblocks the CI pipeline. Authors of PRs get some feedback on their PR and we are not in a less safe place than we are currently where none of the tests can run.
Would love to get your thoughts on the above @dgautsch @jdxcode

Hey Ian, I like the approach you've taken and I agree we will need to figure out the S3 tests for integration in the future. Right now @jdxcode is the only who can run these. For now I think we should move forward. What do you think JD?

fwiw anyone can run the integration tests locally (if you set up your own s3 bucket). I've been running them to make sure i didn't break anything.
My assumption was also that they would work in CI on master because circleci will be able to decrypt the secrets there?

@jdxcode Any thoughts on this?


build apps with engine provided frontend snapshot

Resolve https://github.com/meta-flutter/meta-flutter/issues/575

closing due to lack of response


net/zerotier: used address changes all the time

I have a virtual IP of type "IP alias" bound to my WAN interface.
Zerotier seems to jump between the interface IP and the virtual IP. zerotier-cli listpeers called in a loop on another device shows this:
200 listpeers 5e96a8e284 78.47.80.xxx/54437;2074;872;1.00 62 1.2.4 LEAF
200 listpeers 5e96a8e284 - 63 1.2.4 LEAF
200 listpeers 5e96a8e284 78.47.80.xxx/54437;92;92;0.98 86 1.2.4 LEAF
200 listpeers 5e96a8e284 144.76.20.yyy/54437;30;30;1.00 79 1.2.4 LEAF
200 listpeers 5e96a8e284 144.76.20.yyy/54437;30;0;1.00 79 1.2.4 LEAF
200 listpeers 5e96a8e284 78.47.80.xxx/9993;32;32;1.00 62 1.2.4 LEAF

Note also the changed ports. This leads to a very unstable ZeroTier connection to the network behind the OPNsense box. Is there any way to nail the ZeroTier plugin to the interface's primary address? In the ZT local.conf I can only add interface prefixes, not IP addresses.

I added the virtual IP's network as a blacklist in the ZT local.conf. That seems to have done the trick so far.

Nope, it has not. Damn.

I don't think that was my issue exactly. I'm talking about IP addresses, not ZT addresses. And the flapping occurs randomly several times a day when the box is running, not only on reboots.
Also that setting has never been enabled on my system:

I've never seen this happen for me, but I'll keep observing to see if it occurs.
When I have zerotier enabled on my router, the IP address is solid and remains so for weeks (in fact, I've never seen it change). I have ensured that the "Do Not Auto-Assign IPs" is ticked for the router node (on the zerotier portal) and self-assigned a static IP on the router to the interface.
-=david=-

It's not the IP address on the ZT interface. That remains static.
It's the external IP ZeroTier uses to connect to its peers and that is shown on my.zerotier.com or zerotier-cli listpeers


Route changes state before unmounting the previous component

Reproduction
https://stackblitz.com/edit/vitejs-vite-rbabc7?file=src%2FApp.vue
Steps to reproduce the bug

Click on Page A.
Note that current tab on Page A is "tab 1" and that meta.title says "Component A".
Click on Page B.
Note that, while loading Page B, current tab on Page A is unknown (empty) and that meta.title says "Component B".

Expected behavior
Route state is retained for Page A until unmounted/loaded other route.
Actual behavior
Route state changes for Page A before unmounting/loading other route resulting in discrepancy (route params becoming empty, meta changing to other route's meta etc.)
Additional information
No response

Unfortunately this is inherent to how suspense still renders and updates the previous node while awaiting the new node which happens only once the navigation has finished which is why you see the other meta property
To address this, I started https://github.com/vuejs/rfcs/discussions/460 and feedback is more than welcome!

Thank you for the reply!
While I like your proposal, it would still be nice if this behavior was somehow corrected without users depending on additional functionalities. Correct me if I'm wrong, but data loaders RFC seems orthogonal to fixing this behavior - they can exist with or without this fix.
You probably have more insight into this - is there any way to actually fix this?
Would having two components mounted during load be sufficient solution? With one component having "old" route and the loaded one having "newer" route. This is contradictory to what I requested, but could fix the issues above.

Would having two components mounted during load be sufficient solution?

Supporting Suspense + RouterView is something I have explored in the past. It's not enough. You can check Nuxt source code to create your custom RouterView and see a working version but it gets quite complex to workaround all the edge cases and still have issues (you can check existing issues in Nuxt).
The current direction is more towards data loaders as they don't create edge cases because they integrate within the navigation flow rather than the component mounting flow. This is crucial because both are decoupled.


fix Customize the authentication token in Windows artifact (#69)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


START FROM LAST LAYOUT

It's possible to configure this app to start from last saved layout or to select from which layout to start.

This feature is planned.

Added here: 33a818c027fe0afeecb8ec2cd5495f8b837dcd2e, here: 7e589a30c00b0566d360efd38867eae255a22005, and here: 42847f7803cf5f5d934e2152a0375a7cfc64be86.
No option to start from last layout, but you can start from a favorite or customize a few things with how it starts. Seems to work well. Available now in v1.3.15.


Make Level 10 (The Femur Breaker) a secret level

Is your feature request related to a problem? Please describe.
Level 10 (The Femur Breaker) is too much of a difficulty spike compared to the rest of the game.
Describe the solution you'd like
It should be moved to the secret levels section.
Describe alternatives you've considered
It could also be nerfed or removed.
Implementation
If the level is moved, all the code using level IDs after 10 would need to be decremented by one, except for the ones using the maximum level value (18.)
Line 867:
Before
if lvl_id~=15 then --summit level id
After
if lvl_id~=14 then --summit level id
Line 903:
Before
if lvl_id<15then
After
if lvl_id<14then
Line 960:
Before
if lvl_id>15then --summit level id
After
if lvl_id>14then --summit level id
Line 1261:
Before
if lvl_id==15 then global"max_djump,stopcounting,time_ticking=1,false,true" end --summit level id
After
if lvl_id==14 then global"max_djump,stopcounting,time_ticking=1,false,true" end --summit level id
Line 1409:
Before
if lvl_id>15then --summit level id
After
if lvl_id>14then --summit level id
Line 1471:
Before
if lvl_id==15 then --summit level id
After
if lvl_id==14 then --summit level id
Line 1529:
Before
if lvl_id==6 or lvl_id==8 or lvl_id==12 or lvl_id==18 then
After
if lvl_id==6 or lvl_id==8 or lvl_id==11 or lvl_id==18 then

Fixed in latest commit


labels I added before have disappeared

Carettab became unavailable two days ago
Until it was just updated
But all the 20 + URL labels I added before have disappeared
What should I do?

The update should have provided you a way to recover the links after it was updated. If you had clicked past without doing that then you will need to re-add your links manually.


Added: Feature - Scale -> Ticks -> beginAtZero

This adds the possibility to begin the scale at zero instead of at the minimum attribute value

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
added an attribute which is quite important for me: beginAtZero -> to make the scale bein at zero

What is the current behavior? (You can also link to an open issue here)
scale always begins at the minimum value in the provided datasets

What is the new behavior (if this is a feature change)?
developer has the opportunity to make the scale start at 0

Other information:
Tested -> if it is not set, default behavior will be kept the same

Hi,
requesting feedback for the change if anyting is up to it.
But is a small change and well tested. The change is very important for me.
Best, Simon

And could you tell how long it might take until is ready for next maven dependency version?
Best, Simon from Germany

Hi there @rudiejd,
have you got any comment on the request?
Best, Simon

@simonspdb merged, I will publish a minor version to the vaadin marketplace when I get off of work

Thank you very much for responding I appreciate it - and great work eighter way for the extension of the code - thank you very much -

@simonspdb merged, I will publish a minor version to the vaadin marketplace when I get off of work

Hi,
think of you may have had no time to update vaadin marketplace.
If you've got the time, please reply, so I can be sure, I haven't overlooked it.
Best, Simon

Hi @simonspdb ! I'm trying to upload this to the vaadin directory, but it seems like there's an issue on their end - I see it in the directory after the upload, but I don't see it when I refresh the page :/
let me know if you know of a better way to deploy here! I haven't used Vaadin directory in quite some time

Hi,
never uploaded something over there.
If you don't mind, we can try together - can create google meet link quickly.
mail<EMAIL_ADDRESS>

@simonspdb  figured out that issue, https://github.com/rudiejd/vaadin-chartjs/issues/14#issuecomment-1857926194
The new version should be published now 👯♂

Ah nice! thanks!!

Is online. I'll intregrate it in a minute.

Ah excuse me - thank you very much, works well!


the question of training basicvsr or basicvsr++

i use the default config and model, the psnr much lower than the data of the table. who knows the solution, please help!

Hello,
Please upload your training log (under the working directory) for us to analyze.

Closing due to inactivity, please reopen if there are any further problems.


Show results even if build failed

Here we're showing results even if build cancelled or failed.
Enum added to give more semantic to build results
Fix added, when timer was continiously running even after processing finished which caused empty table showing

@PaulTaykalo Nice one. Thanks.


Add Validators as Comma-Separated for Django Models

validators are defined individually for each field in our Django models. To improve readability and maintainability, it is proposed that validators be specified as a comma-separated list. The addition of multiple validators to a single field will be streamlined, resulting in a cleaner codebase.

Thank you @sepehr-akbarzadeh  for raising this issue. To better understand and address the problem, could you please provide more details

I'll handle it on my own. I just wanted to make a note of the issue for future reference.


action:clean cache after branch closes

Caches have branch scope restrictions in place, which means some caches have limited usage options. We should clean cache after branch closes.
See https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries.

Once a repository has reached its maximum cache storage, the cache eviction policy will create space by deleting the oldest caches in the repository

Are we seeing any issues with this behavior? IOW, the description is not clear why we need to clean up caches instead of letting GH handle it.

Once a repository has reached its maximum cache storage, the cache eviction policy will create space by deleting the oldest caches in the repository

Are we seeing any issues with this behavior? IOW, the description is not clear why we need to clean up caches instead of letting GH handle it.

In our repo, the cache approach total cache storage limit always happened.   The reson is pr changed the depences, such as go.sum or Cargo. toml, created new cache.   After pr merged, GH will created new cache, the cache created by pr branch is still exited.
If we let GH handle it, GH will choose cache by time.  Absolutely, the cache we deleted will never used again.  So we can use this workflow to prevent cache thrashing. I think it just a optional solution, I'm not sure whther it can resolve the problem that cache approach total cache storage limit.

Once a repository has reached its maximum cache storage, the cache eviction policy will create space by deleting the oldest caches in the repository

Are we seeing any issues with this behavior? IOW, the description is not clear why we need to clean up caches instead of letting GH handle it.

In our repo, the cache approach total cache storage limit always happened. The reson is pr changed the depences, such as go.sum or Cargo. toml, created new cache. After pr merged, GH will created new cache, the cache created by pr branch is still exited. If we let GH handle it, GH will choose cache by time. Absolutely, the cache we deleted will never used again. So we can use this workflow to prevent cache thrashing. I think it just a optional solution, I'm not sure whther it can resolve the problem that cache approach total cache storage limit.

The specific scenario is that the cache I saved in benchmark is deleted by GH once. Since benchmark doesn't run every day, the last cache might be replaced by the one generated by pr. I'm just trying to reduce the possibility of this happening.


i18n - Compile Error when try to render html content with {{{ $t('mytranslation')}}}

I am using    vue-i18n (version 4.10.0) for internationalization support and it works well with SSR also.
In my content I have few html phrass tags(   etc..)..
As per the documentation to format html content I am binding the language translation function using {{{
}}}.
https://kazupon.github.io/vue-i18n/formatting.html
I get the following error during compilation.
ERROR in ./~/vue-loader/lib/template-compiler.js?id=data-v-24d04d10!./~/vue-loader/lib/selector.js?type=template&index=0!./pages/trading/markets/forex.vue
template syntax error - invalid expression:  {{{$t('mytranslation')}}}
@ ./pages/trading/markets/forex.vue 11:23-145
@ ./.nuxt/router.js
@ ./.nuxt/index.js
@ ./.nuxt/client.js
@ multi webpack-hot-middleware/client?reload=true ./.nuxt/client.js
Please help me to resolve this

I found a way to fix this.

The language tranlation works without any issue.. but is it a right way to do?

Hi @muthukumarsp
Actually, vue-i18n does not work yet with SSR since it updates the Vue object which is shared across all requests: https://github.com/kazupon/vue-i18n/issues/62#issuecomment-261705767
Example: https://github.com/nuxt/nuxt.js/tree/master/examples/i18n
Demo: http://i18n.nuxtjs.org/


Split large .stan test models

This splits large test files in two, to fix a part of https://github.com/stan-dev/math/issues/2178
This was done with a script, so if anyone feels its easier to review the script, the script is here: https://gist.github.com/rok-cesnovar/70db1bfc69233b2a334208d4f34f7808
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Rok Češnovar, Uni. of Ljubljana
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Do we have any volunteers for this PR? Merging it might help your PRs pass faster so go go go.


Made attempts for connection safer through the client

Added connect connectSafely method to ConnectionDelegate
Added StreamSubscription _socketChannelSubs to WebSocketChannelConnectionDelegate
Deciding whether to reconnect while firing onDone of WebSocketChannelConnectionDelegate with _shouldReconnectOnDone

@nicobritos I summed up previous PRs regarding leaks of repetitive connections. I prevented sequential connections with connectSafely() method of ConnectionDelegate. Now the client uses it instead of connect():
/// From [ConnectionDelegate]
 Future<void> connectSafely() async => canConnect ? connect() : reconnect();
/// From [WebSocketChannelConnectionDelegate]
 @override
  bool get canConnect => _socketChannel == null;

Overcomplicated things


upgrading to sway in manjaro i3

Hi there.
I know it's probably not the right place to ask this question, but I'm trying to see how I can install sway in my existing manjaro i3 installation ( don't want to install everything from scratch until I test sway )
I got the new nvidia drivers, 495.
And I installed sway-git.
But, in the lightdm greeter screen, when I select "sway" and try to log in, it goes blank and then takes me back to the lightdm greeter screen.
Not sure how to fix it. Any ideas on what might be wrong?
Also, can I install manjaro-sway and keep all my existing .config, etc? Or do I have to go for a clean installation?
Thank you :pray:

There is a package called manjaro-i3-settings, a package like manjaro-sway-settings can be provided.
I'm guessing sway edition is not ready yet, and manjaro-sway iso is just for testing?

we have got such a package, but those packages name a conflict with others. I am not sure we should change that though.


UI display issues

The image shows that one of my scans in the list is already done. But then the ones after it in the list also are displayed as done, where they clearly are not.
So this is a display issue, a bug.
Regards,
Patrick

Same for me

the server ui for the webinterface should be improved in the next releases i hope.
great tool.

Same for me

A fresh installation should resolve the issue and make it work properly now.


Incorrect Channel default specified in README file and wiki

Describe the bug
According to the README file and wiki Configuration page websockets should be the default communication method. However, browsing the RemotingServer and RemotingClient classes reveals that TcpServerChannel and TcpClientChannel, respectively, are used as defaults.
Expected behavior
Documentation in README and wiki should match the implementation.
Additional notes
Thank you for a very good package, it makes our transition to higher .NET versions so much easier!

Good catch, thanks!


[FLINK-19417][python] Fix the bug of the method from_data_stream in table_environement

What is the purpose of the change
The parameter of method from_data_stream in StreamTableEnvironment fields should be str or expression, not the current list [str]. And the table_env object passed to the Table object should be Python's TableEnvironment, not Java's TableEnvironment.
Brief change log

Modify the parameter type of method from_data_stream in StreamTableEnvironment fields to str or expression .

Verifying this change

Add the test case in test_from_data_stream in TableEnvironmentTest for the case that verifies the creation of data stream by from_data_stream with expression.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@HuangXingBo @dianfu  I have already followed up with your comments. Please review this again.

@SteNicholas Thanks for the update. LGTM. There are check style issues. Could you take a look at?

@SteNicholas Thanks a lot for the update. LGTM.


Add Utilization Chart directive with ng-docs and unit tests.

Adding a Utilization Chart directive with its ng-docs and unit tests.
I needed to update the donut-pct-chart directive to allow the center label to use 2-way binding and fixed an issue where the percent shown was not being rounded off in all instances.

LGTM

I'm unsure how atomic y'all want your PRs to be but the changes to donut-pct-chart-directive.js seem a little out of place in a PR that is described as being about adding a new utilization chart feature.

I'm unsure how atomic y'all want your PRs to be but the changes to donut-pct-chart-directive.js seem a little out of place in a PR that is described as being about adding a new utilization chart feature.

Upon further inspection it appears as if perhaps those changes were necessary for this PR so disregard this comment/


401 Error and Missing Flows After Server Restart

Bug Description
401 error after restarting the server and navigating back to Langflow. Upon refreshing the home page, none of the flows were available. The flows only became visible after logging out and logging in again.
Reproduction

Restart the server.
Navigate back to Langflow.
Encounter error 401.
Refresh the home page.
Observe that none of the flows are available.
Log out and log in again.
Observe that the flows are now visible.

Expected behavior
After restarting the server and navigating back to Langflow, the user should not encounter a 401 error, and all flows should be available without needing to log out and log in again.
Who can help?
No response
Operating System
Ubuntu Linux 22.04
Langflow Version
main
Python Version
3.10
Screenshot
No response
Flow File
https://jam.dev/c/1e57645d-4f3e-4503-937b-a35749a43832

on it


Inverted/Flipped Text Using HT1632.drawText() function

Hello,
While Draw Image function works well but drawText() function is printing Inverted/flipped text
on the display.
I am using 24x16 single Module.
Any help ?

Update  :  Apparently both Images & Text appears flipped  on the Display.

in my case, it works fine, try to check ur wirings


enclave-cc: Bump to v0.3.1 release

Signed-off-by: Fabiano Fidêncio<EMAIL_ADDRESS>

/test

/test

/test

Merging now as this is not related to enclave-cc, and this has passed before.


get flow checkpoints endpoint v2: 233

Implementing get flow checkpoint endpoint.

Notes:

This PR implement endpoint to get flow using flow ID.


YARN-10459. containerLaunchedOnNode method not need to hold scheduler…

…Apptemt lock
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 41s

trunk passed

+1 :green_heart:
compile
1m  6s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 58s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 19s

trunk passed

+1 :green_heart:
shadedclient
17m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
compile
0m 52s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 52s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 40s

the patch passed

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 17s

the patch passed

+1 :green_heart:
shadedclient
17m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m 25s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

185m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3195

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 2b4d190fbc31 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fd61e90198f119c67716ea5402243bb5084ef6e9

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/testReport/

Max. process+thread count
890 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 36s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 42s

trunk passed

+1 :green_heart:
shadedclient
25m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
1m 35s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 35s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 44s

the patch passed

+1 :green_heart:
shadedclient
23m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
9m 53s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+0 :ok:
asflicense
0m 26s

ASF License check generated no output?

119m 57s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.TestContainerResourceUsage

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3195

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6aab5bd94c6b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fd61e90198f119c67716ea5402243bb5084ef6e9

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/testReport/

Max. process+thread count
804 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 54s

trunk passed

+1 :green_heart:
compile
1m  5s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 41s

the patch passed

+1 :green_heart:
mvnsite
0m 53s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m  1s

the patch passed

+1 :green_heart:
shadedclient
23m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
108m  5s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

206m 14s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3195

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6f73f436a206 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f14a00e03d0f89699ed63bac9f6ec2c732c36a4e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/2/testReport/

Max. process+thread count
937 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3195/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Docker commands hang indefinitely without output

Issue
I have installed dlite (1.1.5) via Homebrew and it used to work fine on my machine. Recently (I'm unable to pinpoint it, probably after the 10.11.5 update), it stopped working for me. Running any docker command like docker info results in an indefinite hang until I abort.
Installing the HEAD version via Homebrew results in error, downloading the 2.0.0-beta5 and replacing the Homebrew-installed binary works but does not change the behavior. I have also completely uninstalled dlite and reinstalled it, without any luck.
Environment
❯ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.5
BuildVersion:	15F3

❯ dlite version
2.0.0-beta5

❯ docker version
...hangs...

Hi @nlf! Is there any news on this or are you currently not actively working on dlite?

i'm still working on dlite, but i do so after i work a full time job so it's not exactly a fast pace most weeks. i have made a bit of progress lately, but after making a mess of my own code i had to slow down and think more about how i want the pieces to fit together.
i promise a new version is coming, i can't promise when it's coming though. hopefully soon.

No worries! I know that work takes a major chunk of ones' time and energy. I'm looking forward to see what you come up with on your time. Thanks for taking the time to respond and for creating dlite in the first place!

@herrbischoff I ran into this recently when I had my local firewall set to block all incoming connections. Unsetting that option made things work again. Can't guarantee that's what's happening to you, but the system logs (from the Console app) may help pinpoint the problem.

Try running sudo dlite daemon (after dlite stopping it). I was also having this but it didn't start working until I manually saw the daemon boot back up. dlite start correctly brought up the daemon for me and it was working again.
FWIW, I am running 1.1.5 but with a newer image (dlite install -v 2.3.0). In my case, installing a newer version of the image took the error from a client version mismatch to the hanging. I think I must have had an old VM that didn't shut down properly or something else that was preventing the new one from booting and being available.
Hope that helps in some fashion until @herrbischoff has a more permanent solution with his current WIP...

Thanks everyone for your suggestions. Since the official Docker for Mac is far more integrated into macOS (still an ugly spelling...), I stopped using dlite altogether and switched full-time to Docker.app.

Aww... too bad. dlite is such a nicer solution IMO, but I understand not wanting to duplicate efforts.
May I suggest updating the README on the default branch so that others can find that info quickly?

i promise a new version is coming, i've been short on time lately but i am working on it.

Currently docker for mac is not useable https://forums.docker.com/t/file-access-in-mounted-volumes-extremely-slow-cpu-bound/8076/142

I only got it to work without restarting my machine with a combination of "sudo dlite daemon" and using "brew install homebrew/versions/docker110" docker 1.11 or dlite start didn't work with dlite install -v 2.3.0

apparently that linux image has docker 1.10 inside it, not 1.11 as is the default on hombrew right now

https://github.com/nlf/dlite/releases/tag/2.0.0-beta7 new beta, remove your old versions before trying it!


Workflows

Code Coverage Continuous Integration added to the project. When Pull Request is made, it will reply with the code coverage.

Approved, minor CI change.


Use an address from the Address Book during checkout

User Story

As a registered shopper, I want to select an address from my address book during checkout.
Description & Motivation

During the checkout experience, a registered shopper must be able to select an address from the address book as the shipping or billing address
Deliverables

A dropdown has to be added to the shipping and billing address steps of the checkout experience
The values in the dropdown should be the street names
The dropdown and the address form should be pre-filled with the default address

Acceptance Criteria

In the "Shipping Address" section I have the form pre-filled with my default address. I also have a dropdown that lists the addresses (street names) that I can choose another address from.
In the "Billing address" section - if I deselect the "Same as shipping address" option I get the address form and a dropdown from which I can select a different address

Verification Steps

Resolved with https://github.com/adobe/aem-core-cif-components/pull/375 .


Ignores username when using ssh-ed25519

When I try to login with my ed25519 key I get

unknown user authorized

Since the key is still valid it works, but only for machines that are available for everyone.

I'll close this since the initial issue is solved.


Allow base distributions which lack context

This allows one to use flow base distributions which lack a context keyword argument, like anything in torch.distributions.Independent, which is used for BoxUniform. It basically just checks at initialization if context is an available keyword argument to self._distribution.log_prob, and uses that to decide whether to pass context or not. Otherwise such distributions will give an error.
@arturbekasov @imurray
This also fixes #17
Cheers,
Miles

edit: I just fixed sampling for context-less base distributions. I think the default behaviour is that it should still use the shape of the context to figure out the number of samples to create. Before the latest change it was only using num_samples.

A bit hacky, but nice in that we could use more PyTorch distributions out-of-the-box, without having to create wrappers.

Thanks @MilesCranmer @arturbekasov this is a nice addition, but I cannot get sampling to work. Maybe you see a quick fix?
from nflows import transforms, distributions, flows
import torch

# Define an invertible transformation.
transform = transforms.CompositeTransform([
    transforms.MaskedAffineAutoregressiveTransform(features=2, hidden_features=4),
    transforms.RandomPermutation(features=2)
])

# Define a base distribution.
base_distribution = torch.distributions.Independent(torch.distributions.Uniform(torch.zeros(2), torch.ones(2)), 1)

# Combine into a flow.
flow = flows.Flow(transform=transform, distribution=base_distribution)
flow.sample(1)

gives error message:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/nflows/distributions/base.py", line 70, in sample
    return self._sample(num_samples, context)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/nflows/flows/base.py", line 56, in _sample
    repeat_noise = self._distribution.sample(num_samples*embedded_context.shape[0])
AttributeError: 'NoneType' object has no attribute 'shape'


Load partial ensemble

Fixes https://github.com/RasaHQ/rasa/issues/7303.
Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

Thanks for submitting a pull request 🚀 @joejuzl will take a look at it as soon as possible ✨

Currently fails at test_policy_loading_load_returns_none. Do you think this approach is appropriate to handle train/load incongruity described in https://github.com/RasaHQ/rasa/issues/7303, or is it better to make training fail instead? Personally I think it's weird that a lack of stories should make training of an ML fail.

This looks sensible to me.
I think it should be ok to update test_policy_loading_load_returns_none to match the new expected behaviour.

@joejuzl Just updated test!

Pinging @joejuzl in case...


New new module: cp-apic-instance

Related User Story
https://github.ibm.com/gsi-labs/industry-cloud-planning/issues/634
Type of module
gitops
If requesting a terraform module, what is the target cloud platform?
ibm, aws, azure, etc
What is the purpose of the module?
Create IBM Cloud Pak for APIC instance
What is the category of the module?
Middleware

/displayName Api Connect Instance

/softwareProvider ibm-cp

/group api-management

Renaming the existing gitops-cp-apic to gitops-cp-apic-operator module before creating this one as gitops-cp-apic


Convert API to use GAPIC

Continuing from Bigtable Convert grpc APIs to use GAPIC, Bigtable is the only API left to complete these steps:

[ ] Bigtable

[ ] Generated files are in repo
[ ] Handwritten API is using generated API
[ ] Passing through gaxOptions is available on all requests
[x] Automatic projectId insertion works

@kolodny I'm happy to do this conversion effort whenever the time is right, so it follows the patterns of our other APIs that have converted (there are some gotchas, like pre-processing requests and streams for {{projectId}} placeholders, and allowing GAX's callOptions parameter through). Updating to GAPIC shouldn't have any breaking changes, but before going GA, I'll do a quick run-through of the API to confirm.
I believe we started talking about the conversion after this request: https://github.com/GoogleCloudPlatform/google-cloud-node/issues/2763-- have you found a workaround or otherwise demoted that issue in terms of priority? As it stands, request interceptors are not available with either the GrpcService class or GAPIC/gax.

@alexander-fenster, what's the story with admin?

In progress. Changes will likely be published to googleapis/googleapis
today and then I'll generate the code.
On Tue, Feb 6, 2018 at 11:24 AM, Solomon Duskis<EMAIL_ADDRESS>wrote:

@alexander-fenster https://github.com/alexander-fenster, what's the
story with admin?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/nodejs-bigtable/issues/23#issuecomment-363535832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD1GvyPJ2yFehxTO8KmigXeLhreBcj3Nks5tSKbYgaJpZM4RHV7Y
.


Add utility function for save_as_dot

This patch simply adds a method to save_as_dot if given a root node Prob\DeltaNode instead of a Vector Prob\Delta.

Codecov Report

Merging #13 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   67.26%   67.11%   -0.16%
==========================================
  Files          20       20
  Lines        1326     1329       +3
==========================================
  Hits          892      892
- Misses        434      437       +3

Impacted Files
Coverage Δ

src/IO/CircuitSaver.jl
82.00% <0.00%> (-2.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fb9e2...5401ddd. Read the comment docs.


As of <IP_ADDRESS>, setup fails, field "data" has invalid value / object has no len

System Health details
System Information

version
core-2024.10.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.31-haos-raspi

arch
aarch64

timezone
Asia/Jerusalem

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
5000

Installed Version
2.0.1

Stage
running

Available Repositories
1461

Downloaded Repositories
10

AccuWeather

can_reach_server
ok

remaining_requests
28

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 13.2

update_channel
stable

supervisor_version
supervisor-2024.10.3

agent_version
1.6.0

docker_version
27.2.0

disk_total
916.9 GB

disk_used
16.5 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
yellow

supervisor_api
ok

version_api
ok

installed_addons
Mosquitto broker (6.4.1), Studio Code Server (5.17.2), Advanced SSH & Web Terminal (19.0.0), ESPHome (2024.10.2), WireGuard (0.10.2), File editor (5.8.0), Scrypted (v0.120.0-jammy-full), chrony (4.0.1), Hikvision Doorbell (3.0.16)

Dashboards

dashboards
7

resources
11

views
5

mode
storage

Recorder

oldest_recorder_run
October 27, 2024 at 15:26

current_recorder_run
November 6, 2024 at 13:10

estimated_db_size
290.93 MiB

database_engine
sqlite

database_version
3.45.3

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
Integration worked well until now. As of upgrade to <IP_ADDRESS> (via HACS), would not initialize. Received:
Failed setup, will retry: Field "data" of type Optional[GetInvoicesBody] in ResponseWithDescriptor has invalid value ('property':{'areaId':'0903','districtId':9} ...
After many failures, deleted integration altogether, restarted HA, added integration. Now:
Failed setup, will retry: object of type 'NoneType' has no len()
Reproduction steps
1.update to <IP_ADDRESS> via HACS
2.
3.
...
Debug logs
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 354, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/iec/coordinator.py", line 389, in _async_update_data
    kva_tariff = await self._get_kva_tariff()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/iec/coordinator.py", line 189, in _get_kva_tariff
    self._kva_tariff = await self.api.get_kva_tariff()
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/iec_api/iec_client.py", line 511, in get_kva_tariff
    return await static_data.get_kva_tariff(self._session)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/iec_api/static_data.py", line 93, in get_kva_tariff
    await _get_tariffs(session)
  File "/usr/local/lib/python3.12/site-packages/iec_api/static_data.py", line 42, in _get_tariffs
    response = await commons.send_get_request(session=session, url=GET_KWH_TARIFF_URL)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/iec_api/commons.py", line 125, in send_get_request
    parse_error_response(resp, json_resp)
  File "/usr/local/lib/python3.12/site-packages/iec_api/commons.py", line 92, in parse_error_response
    if len(json_resp) > 0:
       ^^^^^^^^^^^^^^
TypeError: object of type 'NoneType' has no len()

Diagnostics dump
No response

Try with <IP_ADDRESS>

Should be fixed with 0.0.40+

Should be fixed with 0.0.40+

Installed <IP_ADDRESS>, deleted entry, restarted HA (to start clean), added new entry. Same behavior as the first time.

@doron1 - please open a separate ticket for that; and add logs

@doron1 - please open a separate ticket for that; and add logs

Not sure why sep ticket for same issue? However, As You Wish

Is this the same issue?

If using (iec_api = 0.0.46) - you shouldn't be seeing the same log since:
https://github.com/GuyKh/py-iec-api/blob/main/iec_api/commons.py#L93
the line is:
    if json_resp and len(json_resp) > 0:

Is this the same issue?

Looks pretty much the same as the first one mentioned above. I can see the confusion - as described in the issue desc, once I removed the entry completely, restarted HA and added the entry again, the issue changed (to "no len")  and the included log was from this subsequent instance.
However, my initial issue right after installing <IP_ADDRESS> looked the same as #212 .


[SPARK-28745][SQL] Add benchmarks for extract()

What changes were proposed in this pull request?
Added new benchmark ExtractBenchmark for the EXTRACT(field FROM source) function. It was executed on all currently supported values of the field argument:  MILLENNIUM, CENTURY, DECADE, YEAR, ISOYEAR, QUARTER, MONTH, WEEK, DAY, DAYOFWEEK, HOUR, MINUTE, SECOND, MILLISECONDS, MICROSECONDS, EPOCH. The cast(id as timestamp) was taken as the source argument.
How was this patch tested?
By running the benchmark via:
$ SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.ExtractBenchmark"

@dongjoon-hyun Please, take a look at the benchmarks.

Thank you for pinging me, @MaxGekk . Sure!

Hi, @MaxGekk .
I regenerated the result on EC2 and made a PR to you. Could you review and merge that?

https://github.com/MaxGekk/spark/pull/19