Add support for iOS UndoManager

This PR is modifies the framework to allow the Undo/Redo support added by _TextEditingHistory to interact with the iOS UndoManager. That should enable 3-finger/shake gestures to undo/redo text editing and enable undo/redo from the iPad keyboard.
I don't love this approach, since it feels a little bit hacky and requires a breaking change to the TextInputClient interface. It's possible #98280 could enable a better way of doing this.
I haven't had a chance to test this out – still waiting for the engine to compile, but wanted to plant the flag on this and possibly feedback on the approach.
Related to #34749 and #77614
Engine PR: https://github.com/flutter/engine/pull/31415
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I believe this is a reasonable approach – I think it may make sense to swap over to something along the lines of setUndoManagerState, though, similar to updateEditingState, where the engine can just set up the undoManager as needed, rather than having the framework manage it through three separate calls.

@justinmc I'd like to get your thoughts on the framework side of things – right now I'm adding a method to TextInputClient, which will make this a breaking change. I'm wondering if it would be better to add a property to the TextInputConnection for some kind of new UndoDelegate, and have the TextEditingHistory widget set itself as the current undo delegate on the connection when it receives focus. That way we could avoid that breaking change. Does that make sense?

Thinking about this more, I really like the idea of separating this out from the text editing details. That way a drawing app could make use of it. I haven't had a chance to work on it this week (in the middle of moving), but I'm hoping to be back at it next week.
Does it make sense to still use a FocusNode to know which undo client should receive messages or should that be something left up to the implementers? I think FocusNodes make sense for text editing, but I'm not sure about drawing. I think it still could, but maybe best left to others to decide.
My initial thought is it would make sense to have some kind of UndoActions widget (not sure on the name) that takes an UndoController or some such that provides methods like canUndo, canRedo, undo() and redo(). That's where the question about focus nodes comes in...should UndoActions take a focusNode in order to automatically manage focus, or would it make more sense to have a method on UndoController to become the receiver of undo messages?

I converted this back to draft status for now, since this is a work in progress.
I added a new widget, UndoHistory, and a new service, UndoManager to handle the separate communication and make this more generic.
I haven't updated EditableText to use it yet, but here's an example app that I used to mock up an Undo/Redo UI around a TextField:

lib/main.dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final TextEditingController _controller = TextEditingController();
  final FocusNode _focusNode = FocusNode();
  final GlobalKey<UndoHistoryState> _undoKey = GlobalKey<UndoHistoryState>();

  TextStyle? get enabledStyle => Theme.of(context).textTheme.bodyMedium;
  TextStyle? get disabledStyle => Theme.of(context).textTheme.bodyMedium?.copyWith(color: Colors.grey);

  bool _canUndo = false, _canRedo = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            UndoHistory<TextEditingValue>(
              key: _undoKey,
              value: _controller,
              onTriggered: (value) {
                _controller.value = _controller.value.copyWith(text: value.text, selection: value.selection);
              },
              focusNode: _focusNode,
              shouldChangeUndoStack: (TextEditingValue? oldValue, TextEditingValue newValue) {
                if (oldValue == null) {
                  return true;
                }

                if (newValue == TextEditingValue.empty) {
                  return false;
                }

                return oldValue.text != newValue.text;
              },
              onUndoStackChanged: () => setState(() {
                _canUndo = _undoKey.currentState?.canUndo ?? false;
                _canRedo = _undoKey.currentState?.canRedo ?? false;
              }),
              child: TextField(
                maxLines: 4,
                controller: _controller,
                focusNode: _focusNode,
              ),
            ),
            Row(
              children: [
                TextButton(
                    child: Text('Undo', style: _canUndo ? enabledStyle : disabledStyle),
                    onPressed: () {
                      _undoKey.currentState?.undo();
                    }),
                TextButton(
                    child: Text('Redo', style: _canRedo ? enabledStyle : disabledStyle),
                    onPressed: () {
                      _undoKey.currentState?.redo();
                    }),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

I like that approach, looks really reusable.  Would that replace _TextEditingHistory or is it separate?

Cool, yes, I actually was able to get to the point of replacing _TextEditingHistory on Friday: https://github.com/flutter/flutter/pull/98294/files#diff-f5f93c879cef9a102adbf148583de9f3d9a05f9678fdcad7bde106f62200bb34R3193
There are a couple of things I don't love about the implementation right now, so let me know if you have thoughts on them:

I put the API to access the undo state on UndoHistoryState, but it's not very elegant to access from a TextField(key: _key) right now:  (_key.currentState as TextSelectionGestureDetectorBuilderDelegate).editableTextKey.currentState?.undoHistory?.redo(). I'm wondering if providing more direct access and/or adding another interface on to _TextFieldState might make that simpler. UndoHistoryDelegate or something like that.
To provide software undo/redo buttons, I have to manually call setState after changes, so that might be something that either the UndoHistoryDelegate could provide a stream for, or there could be a stream at another level – maybe even on the UndoManager itself.

All right, I swapped this over to use a controller and I think it's a lot cleaner: https://github.com/flutter/flutter/pull/98294/files#diff-0dd319c779a725fd887d8a664e656ce5cf92b62934a821cf2f3815750c630245R56
Let me know how that looks!

CC @LongCatIsLooong who is probably also interested in this.  We talked about the 3 finger swipe gesture, etc. before.

Gold has detected about 1 new digest(s) on patchset 24.
View them at https://flutter-gold.skia.org/cl/github/98294

Gold has detected about 1 new digest(s) on patchset 25.
View them at https://flutter-gold.skia.org/cl/github/98294

@fbcouch Are you still available to get this PR ready to merge? Sorry for the hiatus while I figured out some platform channel stuff.

Yes! I'd love to get this merged in – I think it's the only thing left in the custom flutter version that we run at the moment 😄

@justinmc @chunhtai I believe this is ready for another look. It looks like there's some infrastructure problem with that docs_test. Also, I tried to incorporate the changes from https://github.com/flutter/flutter/pull/108765 to make sure we don't have a regression there.

@fbcouch Can you update this branch by merging in master?  GitHub is saying there is a conflict, though it doesn't say what the conflict is...
Otherwise I think we need to merge this!

Thanks for sticking with this for so long, @fbcouch!

I spoke a little too soon, we should make sure that this comment thread is resolved.  I just left a comment explaining the composing text behavior.

@justinmc @chunhtai I merged main into this branch again, trying to preserve relevant changes to the old TextEditingHistory from https://github.com/flutter/flutter/pull/120889, https://github.com/flutter/flutter/pull/120062, and https://github.com/flutter/flutter/pull/119028
I think we should have everything wrapped up here (see: https://github.com/flutter/flutter/pull/98294/files#r1080613858 )


drop remain in dom after closing

after closing the drop it stil remains in the dom and
drop.on('close', function (event) {
drop.destroy();
});
wil raise an error.

If you set remove: true in the options when you construct the Drop, it will automatically be removed from the DOM when it is closed, and added back into the DOM when it is opened. For example:
      var dropInstance = new Drop({
        target: targetDOMElement,
        content: "blah blah",
        position: 'top center',
        openOn: 'click',
        classes: "drop-theme-arrows",
        remove: true, //causes it to be removed from DOM when it is closed, then added agaain when it is opened
      });


Menu broke after changing target key from htmlFor to data-mdl-for

Menu component no longer works with IconButton with the change from htmlFor to data-mdl-for
https://github.com/tleunen/react-mdl/commit/a4211e61f80ea78525939f4ea72680b7e4dd4fd2#diff-e359c93bc52c848fbef7e3bdc25527db
Suggestion:
Switch it back or temporarily have both?

temporary solution for anyone who is experiencing is to pass in the htmlFor={target} in the  component itself.

Not an issue.  Bug was because of using old version of MDL v1.0.6, instead of v1.1.1


Create 74-Search-a-2D-Matrix.js

JavaScript solution for 74. Search a 2D Matrix
Successful submission

Solution already exists. Thanks for your submission.


Various HIP cleanup tasks

Fixes #426

HCC has been deprecated for a while now. To my knowledge, no one uses this.

Fixes #536

I removed the one broken host-config (cce@12) which I could not get to compile and verified the other 3 worked with<EMAIL_ADDRESS>

I made sure removing all this didn't somehow break HIP support.


asset_tracker_v2 (v1.7.1) disconnects on FOTA job request with v1.6.x

[00:00:14.219,116] <dbg> aws_iot.aws_iot_cloud_poll: AWS IoT broker connection request sent
[00:00:14.419,433] <dbg> aws_jobs.reg_topic: Subscribe: $aws/things/352656106120200/jobs/notify-next
[00:00:14.430,023] <dbg> aws_jobs.reg_topic: Subscribe: $aws/things/352656106120200/jobs/$next/get/#
[00:00:14.440,399] <dbg> aws_iot.mqtt_evt_handler: MQTT client connected!
[00:00:14.447,540] <dbg> aws_iot_integration.aws_iot_event_handler: AWS_IOT_EVT_CONNECTED
[00:00:14.456,176] <dbg> aws_iot.topic_subscribe: Subscribing to application topic: $aws/things/352656106120200/shadow/get/accepted/desired/cfg
[00:00:14.469,512] <dbg> aws_iot.topic_subscribe: Subscribing to application topic:<PHONE_NUMBER>20200/agps
[00:00:14.479,431] <dbg> aws_iot.topic_subscribe: Subscribing to application topic:<PHONE_NUMBER>20200/pgps
[00:00:14.490,173] <dbg> aws_iot.topic_subscribe: Subscribing to AWS shadow topic: $aws/things/352656106120200/shadow/get/rejected
[00:00:14.502,319] <dbg> aws_iot.topic_subscribe: Subscribing to AWS shadow topic: $aws/things/352656106120200/shadow/update/delta
[00:00:14.583,343] <dbg> aws_fota.on_suback_evt: Subscribed to notify-next topic
[00:00:14.591,186] <dbg> aws_jobs.publish: Publish topic: $aws/things/352656106120200/jobs/$next/get
[00:00:14.600,677] <dbg> aws_jobs.publish: Publish payload {"clientToken": ""}
[00:00:14.609,252] <dbg> aws_iot.mqtt_evt_handler: MQTT_EVT_SUBACK: id = 2112 result = 0
[00:00:14.850,982] <dbg> aws_iot.mqtt_evt_handler: MQTT_EVT_DISCONNECT: result = -128
[00:00:14.859,222] <dbg> aws_iot_integration.aws_iot_event_handler: AWS_IOT_EVT_DISCONNECTED
[00:00:14.868,103] <dbg> cloud_module.cloud_wrap_event_handler: CLOUD_WRAP_EVT_DISCONNECTED
[00:00:14.876,953] <inf> event_manager: CLOUD_EVT_DISCONNECTED

Reported by Tech Support. Unfortunately the docs link to 1.6.x which might be incompatible with the latest NCS version, or there is a bug in asset_tracker_v2 from 1.7.1.

Test NCS1.6.1 version of asset_tracker_v2, it works without this issue.

Fixed via 08cd2243980eceb5b722cb375a52b99a94c954ab
We introduced nRF Connect for Cloud A-GPS and P-GPS support in NCS 1.7, and the device now subscribes to the topics <deviceId>/agps and <deviceId>/pgps, which the existing IoT policy did not allow. This caused the disconnect.
Please update your installation by pulling this change and deploying it:
git pull
npx tsc
npx cdk deploy ${STACK_NAME}

A new policy will be created, and the old one deleted.
Afterwards, re-attach the ${STACK_NAME}-thingPolicy-... to the ${STACK_NAME} thing group in the AWS IoT console.


Conda updates

Updated versions of conda tooling
Install newer miniconda - This fixes the failing appveyor build on master.
Removed python 3.4 builds

Coverage remained the same at 87.232% when pulling c86ab293693471aea65dad11cb739b25005427e7 on conda-updates into b21cb4d3434787c1b5c540ec988126d599ac32b8 on master.

After reading through the responses, LGTM 👍


Is your feature request related to a problem? Please describe.
看到pilot目录下有个finetune的工具，这个目前已经可以用了吗？可以直接用来对vicuna-13b做微调训练吗？
Describe the solution you'd like*
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

不是，那个是alpaca ft的示例代码～


[Continuous Delivery] Adding Git repository fails when path contains uppercase characters

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a Git repository
Add the following directory to the root of the repository: "SubFolder"
Create a GitRepo resource in Rancher Continous Delivery referencing the Git repository URL and specifying /SubFolder  in the Path field.

Result:
The GitRepo resource enters a permanent error state

time="2021-01-12T13:20:49Z" level=fatal msg="Bundle.fleet.cattle.io "isitbrokenornot-SubFolder" is invalid: metadata.name: Invalid value: "isitbrokenornot-SubFolder": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(\.a-z0-9?)*')"

Other details that may be helpful:
Rancher 2.5.3

See also https://github.com/rancher/fleet/issues/198 which may be a duplicate or related issue.

See also https://github.com/rancher/fleet/issues/198 which may be a duplicate or related issue.


Update what-is-artsy.md

Hi, I was just taking a look through your values and noticed a typo. Cheers!

Thank you!

Thanks @dgolant!!


Obtain internal IP address of ARC devices

Is your feature request related to a problem? Please describe.
We would like to have the ability to extract internal IP address of ARC devices via an API call. This is currently not available. With this feature in place, it will allow security devices such as firewalls to dynamically update firewall rules. This will minimize operation overhead while maintaining security posture.
Check Point currently has this ability to obtain internal ip address of hosts giving a tag value in public azure workloads. We would like to extend this feature to any ARC enabled devices.

Hi @chkp-jguo -- can you submit this as an idea on the Azure Feedback site? This will ensure it gets triaged and considered for future feature development.


Fix 'Standard install' link

Description
This PR will fix incorrect 'Standard install' link in 'Calico on Windows' section.

Deploy preview for calico ready!
Built with commit e7cf8efb11585d2a4c64a1583abcaecd33d00e6a
https://deploy-preview-3999--calico.netlify.app


📰Poster - Improving Multi-turn Dialogue Modelling with Utterance ReWriter

AMC Seminar Sign Up

Link to previous seminar meeting minutes comments issue:

#426
1. Oral / Poster Selection

Select one of the following selections for Oral or Poster:

Oral should be prepared for 15 - 30 minutes, and no more than 45 minutes, including Q/A.
Posters should be prepared for 5 - 10 minutes, and no more than 15 minutes, including Q/A.

[ ] 🗣 Oral (15 MIN)
[x] 📰 Poster (5 MIN)

2. Paper Information

Please fill the follow table and provide all the information as many as possible, for sharing with others better. (delete the rows that you did not fill)

Paper
Information

Name
Improving Multi-turn Dialogue Modelling with Utterance ReWriter

Recommendation
rewriting the human utterance as a pre-process to help multi-turn dialgoue modelling

Prior Knowledge
NLP

Year
2019

Publish
ACL

Author
Hui Su, et. al.

GitHub
https://github.com/chin-gyou/dialogue-utterance-rewriter

Arxiv
https://arxiv.org/abs/1906.07004

3. After Party 🍻

Everyone will be welcome. You can join or not join as you want (not required by the AMC), and change your mind at any time.

After Party will be started right after all the meeting agenda had been fulfilled.
We will find a bar and drink beers and talk whatever we want. (we can expect that it will be related to meeting topics of the day)
The bill will be paid AA

[x] 🍻 YES! I'll definitely join the After Party!
[ ] 🤔 Maybe. I'd like to decide later.
[ ] 🛌 No, I'm afraid not this time.

4. New Friend

Whether you have a new friend comes with you to the club.

[ ] 👥 I'll bring a new friend
[x] 👤 There's no new friend from me

Please fill the following table for the new friend sign up(if any), or delete it.

Artificial Intelligence & Machine Learning CLUB, 2018 - 2019 AI ML Club - AMC Member Manual

Good catch! I have moved those two from Oral to Poster list. Thanks for noticing!

Thank you very much!


"dropdown menu" in "top-bar" suffers background override

Hi,
This sort of thing will leave dropdown menu inheriting top-bar background colour, which is undesireable as it renders the menu content illegible.

Site Title

        One

One

Two

Three

Two

Three

<input type="search" placeholder="Search">

<button type="button" class="button">Search</button>

I believe this was deliberate, but I don't remember the reasoning and it definitely seems less than optimal.
cc @IamManchanda @rafibomb @brettsmason do you have thoughts & recommendations on the best way to handle this?
Recommendations for @u

This is like this:
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_top-bar.scss#L47-L57
Here are the variables:
https://github.com/zurb/foundation-sites/blob/develop/scss/components/_top-bar.scss#L13-L19
I think we need to add another variables? Thoughts ?

Also
https://github.com/zurb/foundation-sites/pull/10056#issuecomment-305307281


ues ref on dom element will not trigger watch or watchEffect

Version
3.0.2
Reproduction link
https://jsfiddle.net/h8k7rp45/1/
Steps to reproduce
just click the text Hello Vuejs, then look at the console, it will output undefined once, then after 1 second, output hehe0. If I remove the setTimeout, the hehe0 will never output
What is expected?
output hehe0 when CompA mounted
What is actually happening?
not output hehe0 when CompA mounted

it mainly because watch & watchEffect push preJobs, and ref.value = element worked at queue jobs (the middle), when push preJobs, it's still flushing, so it will not flush again. And after postEffects, no queue jobs and postEffects add, it won't run preJobs again.

is there any side effects if we flushJobs when pendingPreFlushCbs.length > 0
if (queue.length || pendingPostFlushCbs.length || pendingPreFlushCbs.length) {
      flushJobs(seen)
    }

Do this:
watchEffect(() => ..., { flush: 'post' })

Do this:
watchEffect(() => ..., { flush: 'post' })

Yeah, I know, but the implemention is confusing so it still need to talk if this is as expected or not.

You can find more info in existing issues like https://github.com/vuejs/vue-next/issues/1706
https://github.com/vuejs/vue-next/issues?q=is%3Aissue+sort%3Aupdated-desc+watch+post+is%3Aclosed

I did not find one issue that exactly match mine, besides, can you just give me an answer?
Is this by design?
So it mean if I want to use ref to attach dom element I have to use flush: post to watch it right?
I don't quite understand why you guys so eager to close issues.


Identifying categorical values in private data method

I'm trying to use the method for identifying counterfactuals without access to the training data. I have defined my feature dictionary containing the min/max numerical values and expected categorical values. However, I'm getting errors with numerical columns where the values are floats instead of integers.
I can see in the private_data_interface.py code that columns are classed as categorical columns if they are not integers, but it makes sense to also include float values in the accepted numerical type?
for feature in features_dict:
            if type(features_dict[feature][0]) is int:  # continuous feature
                self.continuous_feature_names.append(feature)
                self.permitted_range[feature] = features_dict[feature]
            else:
                self.categorical_feature_names.append(feature)
                self.categorical_levels[feature] = features_dict[feature]

Thanks for suggesting this. Fixed in #330


🐞 Editing the horizontal bar under actions/bonus actions/ reactions

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior
Could you make the horizontal bar format customizable to allow straight horizontal bars for Actions/bonus actions/reactions.
Current behaviour
With the most recent updates, The curls at the end of the line crowds the titles for the action/bonus action/ reaction. Could you create a setting to make it just a straight horizontal bar like it was in the previous versions.
Reproduction
Render a statblock.
Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version Check
1.5.12
Plugin Version
4.1.4
Confirmation

[X] I have disabled all other plugins and the issue still persists.

Possible solution
No response

Never mind. It had something to do with my ITS theme setting that I was using. No issues with the fantasy stat block plugin


Song duration stuck at 1:58

For every song that I play the duration is set to 2:00 and after one or two seconds the progress stops. This happens with firefox, chrome and safari.

Actually, it's stuck at -1:58. When looking at updateTransportState() the duration is correctly set but it seems the GUI doesn't get the event to update the progressbar?

I have fixed this now, it broke because of a pull request that was supposed to fix radio information. pull the latest version and run npm install which would probably update sonos-discovery to 0.15.3, otherwise remove the node_modules folder and run npm install again.

Thanks, but could you please tag 0.15.3 too then?

Gah, forgot that it doesn't push tags with a regular push. Fixed now, sorry about that.

Hi Jishi,
It seems that this issue of songs are continuing to play. Play button sticks without the possibility to get to pause.
Running windows 10 with Chrome version 76.0.3809.100.
Node version 8.11.3
Thx
OL


[Feature] Set values for cloud_RoleName cloud_RoleInstance to Application Insights

See https://docs.microsoft.com/en-us/azure/azure-monitor/app/app-map#nodejs for details and usecase.
For a regular ASP web app as well as a function app, "ai.cloud.role" and "ai.cloud.roleInstance" are by default set to the Azure resource name and the machine/vm id respectively. I'm thinking that good Auth0 equivalents would be tenant domain name and application/client name (or alternatively id, but I'd prefer to have something humanly recognisable)

Well, mr. bot, it would be nice to have a person look at it...

 But this'll be the last time I refresh it. It's been a year. Neither me nor the maintainers have time to address it.

Hi, @MHHenriksen. I'm terribly sorry for the horrendous delay on this. That is on me.
Unfortunately we won't be making new additions to this extension, only bugfixes.
We have a new Log Streaming system that we are migrating toward to better support exporting logs to systems like Application Insights.
All that being said, I will be recording this into our product backlog so that this use case is known for additions in the Log Streaming system.

Thanks, appreciate the reply and closure :) I'll take a look at the log streaming.


Satisfy preflight requests

:v:
/cc @zendesk/vegemite
Description
Browsers turn out to be draconian when it comes to getting anything else than an images or a javascript file.
Turns out 2 headers were added which makes this a CORS request with a preflight where we need to allow those headers
This PR satisfies all that, so i can load a .txt or .json file from my assets folder.
References

JIRA:

Risks

👍 s anybody???

+1

Actually, your implementation is similar, and lighter than the cross_origin gem.  And that gem doesn't handle OPTIONS preflight requests properly, so...
👍


Create cmdlet to get the Octopus dashboard

It'll only show the data retrieved from the /api/dashboard. Here's an example of what you can get from that call JSON example

What columns you'd like to see on the output of the cmdlet?
Which Parameters/filters you'd like to see? The cmdlet will always bring the whole dashboard JSON, as there's no way to filter that down from the API. So any filtering/massaging will be applied locally in PS

Hmm would like to see filtering by Environment Name?
ie.. show me the apps that are currently installed in "UAT" environment?
But yeah the Dashboard does return a lot of stuff so its hard to know for sure what columns to add that are not already there?

I have since noticed that the call to Get-OctopusEnvironment already returns a lot of stuff that is found on the Dashboard (provided you don't provide the -ResourceOnly parameter). I would assume the priority for this is not high unless many others are asking for it?


Including passing parameter the interceptor

It will be nice to include information on how to pass parameters the the interceptor.
For example, I know we can specify parameters during the AddServiceOptions() call, but how do we "pass on that value" to AddTransient() or AddSingleton() call.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf211766-acfe-e599-8286-a5b1d8a071f1
Version Independent ID: cf211766-acfe-e599-8286-a5b1d8a071f1
Content: gRPC interceptors on .NET
Content Source: aspnetcore/grpc/interceptors.md
Product: aspnet-core
Technology: aspnetcore-grpc
GitHub Login: @erni27
Microsoft Alias: jamesnk

Closing.  If you feel this issue should be reopened, feel free to do so.


File request and your SMTP could be down

Hi Leon,
I tried to send a mail to your youtube mail, the mail got a delivery error at your smtp server.
So here is my mail:
Would it be possible that you can please send mir your Fusion Project or the files as steps?
I want to print the hole ring in one part beacause m Printer is so big ^^
Greeting from Germany ^^

Hi,
I've added a complete ring for you to print in the STL files. Also added a segment with thicker walls as someone else requested.
Greetings from the Netherlands :-)
Leon


[BUG] Discord webhook formatting is broken

As per https://github.com/goryn-clade/pathfinder-containers/issues/50 the discord webhook creates an embed with broken formatting. This is most likely due to changes in how webhooks are handled on discord's side and may need some adjustment in PF.

I'm not aware of any changes to Discord's webhooks that would cause this.


Right to Left Support

Why not to think of adding "right to left" support, I think this will be a great feature to bootstrap.

There is at least one other issue open for this right now, so I'll close this out as a duplicate.
If anyone wants to take a crack at it, you're more than welcome to try. We've still got some other things on our plate that trumps this for now.


Dark Mode because Usher Syndrome

Hi, thanks for raising this - I'd really like to do this too though it's quite a bit of work, and I've been focusing on fixing the high priority bugs first before I start working on new features.
In saying that there are already 2 bugs raised for this at #397 and #316 - so I'll close and mark as duplicate to make scheduling this easier.
Thanks!

Gooooooooooooooooooooooooood. Also I am full deaf and need have notification while app is close.
Sent from my iPad Pro 12.9” by Kent Davis

On Dec 12, 2018, at 2:35 PM, Jerrold Poh<EMAIL_ADDRESS>wrote:
Hi, thanks for raising this - I'd really like to do this too though it's quite a bit of work, and I've been focusing on fixing the high priority bugs first before I start working on new features.
In saying that there are already 2 bugs raised for this at #397 and #316 - so I'll close and mark as duplicate to make scheduling this easier.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Add a JSON file for SQA-supported-projects

Reason for PR-ing:
This contains the list of projects we now currently support in SQA. This will counter-check if new projects were added to the RC sent to us by Stefan and his team.
Signed-off-by: Hannah Rosete<EMAIL_ADDRESS>

Lint issues are on network.py, not in the file I'm pushing.

This will counter-check if new projects were added to the RC sent to us by Stefan and his team.

Does this mean checking for changes in contents of the kuiper image? How will this file be used for it exactly? Is kuiper.json not enough for it?

Closing as not needed anymore


Handles versioning for ORCID publications.

Please note that this development has been funded by Lyrasis Organization.

DSpace 8_x version here: #9723
DSpace 7_x version here: #9722
References

Fixes #8662

Description
This PR adds improvements to the ORCID synchronization feature.
Whenever an item is versioned, and is queued for synchronization, its reference will be updated in order to have an updated publication on the ORCID side.
Whenever an item is versioned, but its already published, it will be updated.
Instructions for Reviewers
Just try to create a new publication, and leave it inside the ORCID synchronization queue.
Now try to create a new version of it, and check that the pending publication is updated with the new version (you can check it inside the orcid_queue table).
In the same way you should publish the update to the ORCID servers and then try to versionate it again. In this case you should check that the entry inside the orcid_history table has been updated correctly.
List of changes in this PR:
The changes will introduce the followings:
Consumer

orcid queue will be populated only by latest version of items
Versioning
Items in orcid queue that are related to an older version will be deleted
Older items' version in the orcid history will be updated with the last one in order to have only one entry per-item.

Checklist

[x] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[x] My PR passes Checkstyle validation based on the Code Style Guide.
[x] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[x] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[x] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
[x] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[x] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

For the funding acknowledgement for this PR and any others that are part of the DSpace/ORCID grant via Lyrasis, please use the following language: "Please note that this development has been funded by the ORCID Global Participation Fund.


Test MauveSingleThreadLoadTest_OpenJ9_0 failing on test-ibmcloud-ubuntu1604-x64-1

Test MauveSingleThreadLoadTest_OpenJ9_0 is failing on test-ibmcloud-ubuntu1604-x64-1 with the output below.  The test was with jdk15 but I'm assuming that's not relevant - the test is passing on other machines and releases.

22:54:14  LT  >>> Captured test output >>>
22:54:14  LT  FAIL: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 0 Should not throw Exception here (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 1 No wildcard address returned (number 0)
22:54:14  LT  FAIL: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 2 Unexpected Exception here (number 0)
22:54:14  LT  FAIL: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 1)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 2)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 3)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 4)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 3 Unexpected Exception here (number 5)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Basics failed - 1 Returned wrong port number (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Basics failed - 2 Returned wrong host name (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Basics failed - 3 Returned wrong InetAdress object (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Basics failed - 4 Unresolveable hostname got resolved (number 0)
22:54:14  LT  PASS: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Basics failed - 5 Resolveable hostname got not resolved (number 0)
22:54:14  LT  <<<
22:54:14  LT
22:54:15  LT  22:54:15.496 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:15  LT  22:54:15.496 - suite.isCreateDump() : false
22:54:15  LT  22:54:15.496 - Test failed. Details recorded in execution log.
22:54:16  LT  22:54:16.283 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:16  LT  22:54:16.283 - suite.isCreateDump() : false
22:54:16  LT  22:54:16.283 - Test failed. Details recorded in execution log.
22:54:17  LT  22:54:16.750 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:17  LT  22:54:16.750 - suite.isCreateDump() : false
22:54:17  LT  22:54:16.750 - Test failed. Details recorded in execution log.
22:54:17  LT  22:54:17.167 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:17  LT  22:54:17.168 - suite.isCreateDump() : false
22:54:17  LT  22:54:17.168 - Test failed. Details recorded in execution log.
22:54:17  LT  22:54:17.548 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:17  LT  22:54:17.548 - suite.isCreateDump() : false
22:54:17  LT  22:54:17.548 - Test failed. Details recorded in execution log.
22:54:18  LT  22:54:17.919 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:18  LT  22:54:17.919 - suite.isCreateDump() : false
22:54:18  LT  22:54:17.919 - Test failed. Details recorded in execution log.
22:54:18  LT  22:54:18.284 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:18  LT  22:54:18.284 - suite.isCreateDump() : false
22:54:18  LT  22:54:18.284 - Test failed. Details recorded in execution log.
22:54:19  LT  22:54:18.639 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:19  LT  22:54:18.639 - suite.isCreateDump() : false
22:54:19  LT  22:54:18.639 - Test failed. Details recorded in execution log.
22:54:19  LT  22:54:18.981 - suite.getInventory().getInventoryFileRef(): openjdk.test.load/config/inventories/mauve/mauve_all.xml
22:54:19  LT  22:54:18.982 - suite.isCreateDump() : false
22:54:19  LT  22:54:18.982 - Test failed. Details recorded in execution log.
22:54:19  LT  22:54:18.982 - Number of test failures has reached 'AbortAtFailureLimit' (10). Terminating load test
22:54:19  LT  22:54:18.982 - Thread completed. Suite=0 thread=0
22:54:19  LT  22:54:19.005 - Load test completed
22:54:19  LT  22:54:19.006 -   Ran     : 27661
22:54:19  LT  22:54:19.006 -   Passed  : 27651
22:54:19  LT  22:54:19.006 -   Failed  : 10
22:54:19  LT  22:54:19.006 -   Result  : FAILED
22:54:19  LT  22:54:19.007 - Note that only the first 1 failures have been reported
22:54:19  STF 22:54:19.065 - **FAILED** Process LT  ended with exit code (1) and not the expected exit code/s (0)
22:54:19  STF 22:54:19.065 - Monitoring Report Summary:
22:54:19  STF 22:54:19.065 -   o Process LT  ended with exit code (1) and not the expected exit code/s (0)
22:54:19  STF 22:54:19.065 - Killing processes: LT
22:54:19  STF 22:54:19.065 -   o Process LT  is not running
22:54:19  **FAILED** at step 1 (Run Mauve load test). Expected return value=0 Actual=1 at /home/jenkins/workspace/Test_openjdk15_j9_sanity.system_x86-64_linux_xl/openjdk-tests/TKG/../TKG/test_output_16047839739634/MauveSingleThreadLoadTest_OpenJ9_0/20201107-225400-MauveSingleThreadLoadTest/execute.pl line 94.
22:54:19  STF 22:54:19.226 - **FAILED** execute script failed. Expected return value=0 Actual=1
22:54:19  STF 22:54:19.226 -
22:54:19  STF 22:54:19.226 - ====================   T E A R D O W N   ====================
22:54:19  STF 22:54:19.226 - Running teardown: perl /home/jenkins/workspace/Test_openjdk15_j9_sanity.system_x86-64_linux_xl/openjdk-tests/TKG/../TKG/test_output_16047839739634/MauveSingleThreadLoadTest_OpenJ9_0/20201107-225400-MauveSingleThreadLoadTest/tearDown.pl
22:54:19  STF 22:54:19.276 - TEARDOWN stage completed
22:54:19  STF 22:54:19.283 -
22:54:19  STF 22:54:19.283 - =====================   R E S U L T S   =====================
22:54:19  STF 22:54:19.283 - Stage results:
22:54:19  STF 22:54:19.283 -   setUp:     pass
22:54:19  STF 22:54:19.283 -   execute:  *fail*
22:54:19  STF 22:54:19.283 -   teardown:  pass
22:54:19  STF 22:54:19.283 -
22:54:19  STF 22:54:19.283 - Overall result: **FAILED**
22:54:19
22:54:19  MauveSingleThreadLoadTest_OpenJ9_0_FAILED

The first failure:
22:54:14  LT  FAIL: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest: Error : test_Constructors failed - 0 Should not throw Exception here (number 0)

suggests that this small test case will throw an exception.
import java.net.*;

public class TestInetSocketAddress {

	public static void main(String[] args) {
		InetSocketAddress socketAddress = null;
		try {
			socketAddress = new InetSocketAddress (InetAddress.getLocalHost(), 1234);
		}
		catch (Exception e) {
			e.printStackTrace();
			System.out.println(e);
			System.exit(1);
		}
		System.exit(0);
	}
}

Note: This is part of https://ci.adoptopenjdk.net/job/Test_openjdk15_j9_sanity.system_x86-64_linux
It also is definitely not specific to 15 as it failed here with 11

Passed on job 95 so I believe this is now fixed (although I'm not 100% sure what I did yesterday as I don't seem to have updated any of the entries in /etc)


feat: add is valid phone number

Fixed Issues
$ https://github.com/Expensify/App/issues/41078
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

Go to https://staging.new.expensify.com
Tap on a room report
Enter @+91 and send the message
Verify that: not consider @+91 is a valid mention.

Unassigned myself, will review once @hungvu193 approves. Its important for some Expensify-specific automations that the internal engineer is auto-assigned, so hopefully once @hungvu193 approves I'll be auto-assigned back to the review. If that doesn't happen just ping me.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16502320/d74fcf71-c577-4529-8e01-4e9efa70bb3a

MacOS: Desktop

All yours @blimpich

Yeah, we will have a PR to upgrade expensify-common and probably another PR to upgrade expensify-common version of react-native-live-markdown as well

@blimpich Can we merge this now?

Merge freeze/slush isn't over yet, hopefully will merge tomorrow 🙂

Just got the all clear. Lets merge 🎉


Drop down menu in Feed using Android mobile devices

Steps to create:
-Login with valid email id,Password.
-Go to feed.
-Select location drop down.
-It has to show results  related to location.(similarly if we choose provider or type.it has to show the respective results only)
-But it shows drop down menu again.

Yeah this is something I have previously brought up, I mentioned that we should have a button called Filters on top, and then open this modal when that button is pressed, similar to what we have in Desktop Version. @ppagarawal Any thoughts?

Same on IOS (I tested using Iphone 6S).

@idjevm this was supposed to be changed when @adisen would rework on the changes he merged. It is from the same 'pull request'. Reach out to me for more information.

@ppagarawal so no actually, this is not in the scope of what Israel is doing, @adisen is just working to get the formatting back to how it was, which is this ->

but besides that, as @dabartlett mentioned, it makes no sense to have the filters as shown in this image, and then again ask the user to kinda select the filter they want. I think ideally we would want to have a button that say Filters like on the feed desktop view. and when the user clicks, then the menu is displayed.
Something like this ->

But centered.

Take a look at this gif -> it will make more sense @ppagarawal, a valid point that makes no sense to have these dropdowns, we should just have a Filter by button or text Filter by and then a button called Filters and that will open up the menu...

https://share.getcloudapp.com/7KumzmGg

@idjevm Please go ahead with the changes. It certainly makes no sense to have the user select the filters twice. I recommend that the implementation be as below but must open up the exact filter option when the modal window appears.
This is to let the user know what filters he can apply to.

This will require some code refactoring/logic thinking, If you look at the filters from the feed in the Desktop View, the user has the option to click on the "Filters" button and then the filters are displayed. Why not implement something like that?

Like here, the user must click on filters first before the filters are shown

as a user, what if I want to apply more filters, then I will have to click on a different filter, then view results, and then again and again and again. I think using the implementation like the feed desktop is much better, where the user clicks on the filters button and is able to see all the filters available, then the user can choose all the desired filters before applying, once the user is done choosing all the desired filters, the user can click on show results :) and this will apply all the filters selected in the filters menu. Much better implementation rather than having to apply one filter by one (can become annoying VERY fast)

@idjevm I understand your point. But for now, lets stick to the design and I will work with the design to make any changes required in the future releases.
Also, selecting the filter criteria must directly open the criteria in the modal.
Please find the diagram below:

Then based on this design, there doesn't need to be changes done, or do you want to just have pop up all the filters as it is right now but the section clicked extended?

@ppagarawal @idjevm Hey guys, what's the status of this ticket?

This needs to be changed as discussed to provide better user experience. @idjevm can you or someone please take this up?

Then based on this design, there doesn't need to be changes done, or do you want to just have pop up all the filters as it is right now but the section clicked extended?

The section click has to be extended


Corrected Order in Readme

Fixed the order and hierarchy level for the bullets

Thanks, but it's actually wrong in a different way.

Okey it's your repo so you know better than me.
But if we add an 2nd level of the List the in the file it should reflect. i.e it shows the deep level in case of Helpful Tools and Services.


[sdk] Create a NuklaiVM Javascript SDK that frontend apps can interact with

We need to abstract away most of the mundane things for developers so they can just integrate with the SDK to build various applications on NuklaiVM

This is done: https://github.com/Nuklai/nuklai-js-sdk


Current Status Of Protocol

I was wondering what the current status of this project is. I see that there is a beta specification here, but I don't see activity after Aug-Sept 2018. Is work still ongoing? Are there any reference implementations?

fr33domlover posted an update just today to the ActivityPub forum - and
also suggested starting a similar web forum on that same host
https://socialhub.network/t/forgefed-project-hosting-federation/341

Great, thanks!

ill re-open for a few days in case others want to add something in response without signing up for that other website

Maybe at this to README

ForgeFed Community Forum
In order to consolidate development and community discussions, there is now a public web forum on the socialhub.network website. Everyone is invited to use that forum instead of this GitHub repo or the mailing list.
Thanks to SocialHub and FeNeAs for making that possible.
Web Forum: https://socialhub.network/c/forgefed
ForgeFed in the Fediverse
There is also a user on the Mastodon network to which you can subscribe for progress updates.
Fediverse<EMAIL_ADDRESS>(https://floss.social/@forgefed)
ForgeFed Repository
This GitHub repo has not been updated in some time, and it is unclear at the moment whether or not @yookoala still wants to maintain it. The NotABug repo contains the most recent documentation and reference source code, all currently under the maximally permissive CC0 license.
Repository: https://notabug.org/peers/forgefed

ad least add the new repo to the github repo description

-> https://codeberg.org/ForgeFed/forgefed/issues/101#issuecomment-458010
-> https://notabug.org/peers/forgefed/pulls/103

more:
https://todon.nl/@fr33domlover/107579920154669382
https://chaos.social/web/@6543/108222466960369092

ad least add the new repo to the github repo description

it is not possible - the only thing that anyone can do is to moderate the issues

@bill-auger: All people in the workgroup has write permission to this repository. I believe you can change the README to this repository. If not, please let me know how better to setup the permission. Thanks.

@yookoala IIRC we tried to modify the VCS it was not possible - someone opened a pull request and it still open, because no one could accept it
wow glad yer back though :) - thanks - there are still many links floating around the web that point here; and it always the same confusion, trying to tell people why nothing can change
this would be the simplest thing you could to do:
go to https://github.com/orgs/forgefed/people
you will see all "people" are "member"; and only you are "owner" - members can only moderate the tickets, and create new repos, not much else
press the gear icon beneath the "Role" column for each person and press "Change Role", then select "Owner" - there is also "Admin" - owner has the most privileges - im not sure what is the difference - if you do not plan to be around, it would be best to make a few people "Owner", to be sure that someone has the maximum abilities

@bill-auger Sorry. Didn't realize that.
Add you with Admin permission. Please check.

i was able to push to the VCS - thanks - it would be nice to have the organization logo too

yes - that did the trick - i was able to set the organization's description, and the "invite members" button is available - thanks again :)

@bill-auger: Thanks for the effort. Should have done this earlier.

@bill-auger https://codeberg.org/ForgeFed/ForgeFed/issues/95#issuecomment-469635
I would like to make this repo as a push mirror (same as what NAB repo is now)

done - now it get synced every 2h


Support standalone database resource

The rediscloud_subscription resource is responsible for both the subscription and database definitions.  It would be useful to be able to specify a database outside of the rediscloud_subscription resource.  This would make the provider closer match the REST API resources and the rediscloud data Terraform resources.  This also supports workflows where different teams are responsible for managing the subscription and the databases.
Affected Resource(s)
Please list the resources as a list, for example:

rediscloud_subscription

Hi @atsui-bay1,
Thanks for raising this issue. This has been requested in the past, and rightfully so. However, the terraform provider is dependent on our APIs, and at this point we are unable to support this request. We do aim to make this change, but there is no timetable for that currently.

Hello @nir-redis
given the fact you can create a database on an already existing subscription via the REST API
https://docs.redis.com/latest/rc/api/examples/create-database/
It should be possible to make a data request to get the subscription's info and use it in a database resource creation
Am I missing something ?
The lifecycle of both resources (subscription, database) are clearly not the same subscription are mostly organisation level, and database are project/environement level....
I'm sure I could prototype something using https://github.com/Mastercard/terraform-provider-restapi
It would be cleaner to have a well structured official TF provider.
Fred

Hi @fmasion, I'm sorry for the very late response.
Some of the issues in the registry were missed.
I'm closing this issue as we have introduced the rediscloud_subscription_database as part of version 1.0.0.
Let me know if something needs to be added.
Thanks, and sorry again for the delay.


systemd jingo wiki

Can someone help me with Jingo + systemd ?
[Service]
ExecStart=/root/.nvm/versions/node/v5.2.0/lib/node_modules/jingo/jingo -c /root/jingo/config.yaml
Restart=always
StandardOutput=syslog
StandardError=syslog
SyslogIdentifier=jingo
User=root
Group=root
Environment=NODE_ENV=production
[Install]
WantedBy=multi-user.target
root@testing:/etc/systemd/system# systemctl status jingo
● jingo.service
Loaded: loaded (/etc/systemd/system/jingo.service; disabled)
Active: failed (Result: start-limit) since Sat 2015-12-12 12:26:42 EST; 5s ago
Process: 29518 ExecStart=/root/.nvm/versions/node/v5.2.0/lib/node_modules/jingo/jingo -c /root/jingo/config.yaml (code=exited, status=127)
Main PID: 29518 (code=exited, status=127)
Dec 12 12:26:41 testing systemd[1]: jingo.service: main process exited, code=exited, status=127/n/a
Dec 12 12:26:41 testing systemd[1]: Unit jingo.service entered failed state.
Dec 12 12:26:42 testing systemd[1]: jingo.service start request repeated too quickly, refusing to start.
Dec 12 12:26:42 testing systemd[1]: Failed to start jingo.service.
Dec 12 12:26:42 testing systemd[1]: Unit jingo.service entered failed state.

127 usually indicates the binary wasn't found. Double check your path?

You're right. It is because of environment path. Thanks!
Here's my new systemd service with Environment=PATH.
nano /etc/systemd/system/jingo.service
[Unit]
Description=Jingo
[Service]
ExecStart=/root/.nvm/versions/node/v5.2.0/bin/jingo -c /root/config.yaml
Restart=always
User=root
Group=root
Environment=PATH=/root/.nvm/versions/node/v5.2.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
Environment=NODE_ENV=production
[Install]
WantedBy=multi-user.target


How to tie maxConcurrent with timeframe

Hey great repo, really useful. I have a use case that I'm not sure how to achieve though: I want to send n requests but only at x per minute.
So in real life, I need to call an API 250 times to get all my pages of data, but the API only allows 25 requests per minute. So I need to make 25 requests, wait a minute, make 25 more, etc.
Ideally the scheduler would do this for me, but all I can figure out how to do is to say maxConcurrent = 25 and minTime = 2400 which would run 25 requests a minute, but with 2.4 seconds in between each call. So if I only had to make 25 requests, it would still take a minute instead of just calling them all at once.
This is probably fine for my use case, but I wanted to see if this was already covered and I'm just missing it, or if you think this sort of feature could be useful to add.
Thanks!

OK so if the reservoir hits zero, any jobs not running will wait indefinitely (assuming no expiration)? I wasn't sure if they'd be ignored, but if their queued then that works. I'll try it out, thanks!
Why couldn't you introduce a few options to at least meet this use case? Something like reservoirRefreshInterval (defaulted to 0) and reservoirRefreshAmount (defaulted to reservoir). I guess you'd also need to introduce methods to clear the interval, stop and restart it. Still, that would meet this use case pretty well.
What other use cases are you trying to solve?

Sorry for the delayed response.

OK so if the reservoir hits zero, any jobs not running will wait indefinitely (assuming no expiration)? I wasn't sure if they'd be ignored, but if they're queued then that works. I'll try it out, thanks!

Yup!
And about your suggestion: I like it a lot. It's not a top priority at the moment, but it will probably be the next new feature.


toggle [enable and cancel] button

Describe the solution you'd like
toggle [enable and cancel] button

support in version v1.1.1


clean-up OVS integration test

Introduce helper functions to the module and streamline its format.
This will be helpful in a follow-up patch introducing OVS bonding.
Signed-off-by: Petr Horacek<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling e188e1c0d5791f364ed1875a86c19426027ee9ad on phoracek:ovs_integration_test_refactoring into 34ee4efc751816a8a6ec1f806f802c61ff1c5199 on nmstate:master.

@EdDev @maiqueb @cathay4t could you please take a look? I wanted to do some clean-up before jumping to OVS bonding implementation.

Failed on unrelated tests.

ci test please

@maiqueb fixed. Could you please take another look? Thanks!

@EdDev please take another look.

ci test please

@cathay4t would you please take a look while @EdDev is gone?

@EdDev please take another look, master, I tried my very best.

@EdDev done.

Thank you!


electron: update

Motivation for this change

https://github.com/electron/electron/releases/tag/v16.0.10
https://github.com/electron/electron/releases/tag/v17.1.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

electron_17 does not need a backport. electron_15 recently received an update if you want to include it.

Please split each change into an individual commit. Also please include change for updating electron_15 to 15.4.0.

Thanks!

Backport to 21.11 in https://github.com/NixOS/nixpkgs/pull/162399


Add Android release binaries to CI

This commit is inspired by #6480 and historical asks for Android binaries. This does the bare minimum necessary to configure C compilers such that we can produce binaries but I'll admit that I'm no Android developer myself so I have no idea if these are actually suitable for use anywhere. Otherwise though this build subsumes the preexisting check in CI that the build works for Android, so that part is removed too.
This additionally changes how the NDK is managed from before. Previously a GitHub Action was used to download Java and the NDK and additionally used the cargo ndk subcommand. That's all removed now in favor of configuring C compilers directly with a pre-installed version of the NDK which should help reduce the CI dependencies a bit.

True! I've also updated the tier listing to explicitly say that this is tier 3, like riscv64.
Part of my own motivation here is that I get the impression folks will glance at the release binaries and determine our platform support without digging much further, so this might help give the impression that Wasmtime isn't ONLY windows/mac/linux, perhaps. There's only so much we can do with that level of review from a prospective user though.


Adding CIs

After the initial PR, we should probably add CIs.

Do you think https://github.com/substrait-io/substrait-python/pull/5 is enough to close this issue?

Yes

Though maybe lets make a follow-up issue for linters / formatters (which are not part of #5 if I understand)

Added #6!


Get rid of beamSpan and tupletSpan

As mentioned at the end if issue https://github.com/music-encoding/music-encoding/issues/755, it would be good to get rid of beamSpan and tupletSpan.  Instead something like beamSpan@sameas should be implemented that merges two or more <beam> groups into a single beam.  Likewise, tupletSpan@sameas should be implemented to merge two or more <tuplet> groups into a single tuplet that crosses the tree hierarchy.
Both beamSpan and tupletSpan promote notes/rests that are independent children of <layer> into a meta tuplet or beam that crosses the <measure>/<staff>/<layer> hierarchy.  And knowledge of this promotion is delayed for notes in a layer until all of the floating elements have been parsed for a measure.  Placing the elements that will be spanned into groups that will be linked into a meta group seems more aligned with the MEI aesthetic without the use of promotions.   This system should also work when tuplets/beams cross each others hierarchies (you can provide counter examples to prove otherwise :-).
tupletSpan is particularly offensive because the actual duration of a layer cannot be known until parsing all floating elements at the measures level.  This greatly complicates calculating layout positions for generating graphical music notation, since notes within a tuplet span are useless for such layout until the tupletSpans have been applied to them.  It also greatly complicates computational analysis of such data for the same reason.

I can certainly see the point, especially for tupletSpan that does allow for simple (on-pass) data analysis when durations are involved.
Maybe there are some less drastic options than getting rid of them, though. One idea that came to my mind and that - I think - works out of the box without any changes in MEI is it use beamSpan to regroup beam elements. There seem to be no assumption in the MEI Schema that a beamSpan needs to point to notes, chords or rest. It seems to me that it would make perfectly sense to make it point to beams (parts) that are meant to be grouped as a single one.
 It also have the advantage that an application that would be ignoring the beamSpan would still preserve the underlying beam parts, which could be better than nothing in many cases.
I think the same approach would work equally well with tupletSpan, even though dealing with tuplet number display might require additional thoughts.

I can certainly see the point, especially for tupletSpan that does allow for simple (on-pass) data analysis when durations are involved.
Maybe there are some less drastic options than getting rid of them, though. One idea that came to my mind and that - I think - works out of the box without any changes in MEI is it use beamSpan to regroup beam elements. There seem to be no assumption in the MEI Schema that a beamSpan needs to point to notes, chords or rest. It seems to me that it would make perfectly sense to make it point to beams (parts) that are meant to be grouped as a single one.
 It also have the advantage that an application that would be ignoring the beamSpan would still preserve the underlying beam parts, which could be better than nothing in many cases.
I think the same approach would work equally well with tupletSpan, even though dealing with tuplet number display might require additional thoughts.

Yes, that is good since it organizes the elements to be spanned into more manageable groups.  And the role of the span is diminished to linking elements rather than also grouping sibling elements before doing that.
One consideration would be how to beamSpan more than two such beams together, such as when the beam goes across multiple measures?  Probably with beamSpan@plist?

Yes, that is good since it organizes the elements to be spanned into more manageable groups.  And the role of the span is diminished to linking elements rather than also grouping sibling elements before doing that.
One consideration would be how to beamSpan more than two such beams together, such as when the beam goes across multiple measures?  Probably with beamSpan@plist?

One consideration would be how to beamSpan more than two such beams together, such as when the beam goes across multiple measures? Probably with beamSpan@plist?

Yes, I think that would work.

One consideration would be how to beamSpan more than two such beams together, such as when the beam goes across multiple measures? Probably with beamSpan@plist?

Yes, I think that would work.

There will still be cases where the current beamSpan is needed, but I am still trying to think of a case where the traditional tupletSpan is necessary...

There will still be cases where the current beamSpan is needed, but I am still trying to think of a case where the traditional tupletSpan is necessary...


Consider adding an entry to Zig’s third-party tracking wiki

See here: https://github.com/ziglang/zig/issues/17144

@expikr The upstream zig discussion is closed. Any suggestions?

I have added a link at the end with https://github.com/ziglang/zig/wiki/Third-Party-Tracking-Issues-(what-is-important-to-other-people%3F)

https://github.com/libriscv/godot-sandbox Has zig support but the interop doesn't seem deep.
@fwsGonzo https://github.com/libriscv/godot-sandbox/blob/main/program/zig/api/api.zig

As far as I understand, the wiki page links to "wishlists" of what would be valuable for the Zig toolchain to prioritize for the benefit of other projects.
Other entries for example list upstream (Zig) bugs or proposals that would unblock / improve maintainability of these dependent projects.
The entry currently linking here reads "Add example of third party integration of zig in a sandbox with Godot Engine".
To me that reads as a task that a maintainer of Godot, or this sandbox, could do, not something that the maintainers of the Zig toolchain should (need to) get involved with.

I will suggest closing this issue then because it is unclear @expikr.


how to track changes in the project boilerplate generated by cookiecutter-django

What is the recommended procedure for tracking changes in the project boilerplate generated by cookiecutter-django? Let's say on Feb 1 I create a project based on cookiecutter-django and then I check back a few months later. How do I integrate the subsequent changes? So far, I've been keeping a clean version of the generated project and reviewing diffs. Is there a well-defined set of guidelines for where I can make changes for my app and what I should leave alone?

@highpost, see #1047.

Thanks.


Refactor: integrations v4 naming

Simply renaming files and vars so they are more easy to grasp.

Pull Request Test Coverage Report for Build 264709240

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 58.417%

Files with Coverage Reduction
New Missed Lines
%

internal/agent/event_sender_vortex.go
1
73.21%

pkg/metrics/sampler/sampler_routine.go
2
94.74%

Totals

Change from base Build 259396931:
0.0%

Covered Lines:
11084

Relevant Lines:
18974

💛  - Coveralls


Concentrate Module LifeCycle in one place

Currently the life cycle and state machine is spread across different components, even with some redundancies. This complicates refactorings and debugging, as well as unnecessary code.

Combine with refactoring from #24


Personality Prediction Project

Imagine how interesting it would be to read the posts written by people online and be able to understand their overall personality?
The axis ranges from Introversion (I) to Extroversion (E), Intuition (N) to Sensing (S), Thinking (T) to Feeling (F), and Judging (J) to Perceiving (P).

HI @Niketkumardheeryan
Please let me work on this feature. I am a GSSOC'22 participant. I can really learn a lot from this work.

HI @Niketkumardheeryan Please let me work on this feature. I am a GSSOC'22 participant. I can really learn a lot from this work.

YOU can work on this issue now @Diishasing . You have 5 days to make a PR.

Hii,
I am GSSOC 22 contributer
@Diishasing can you please assign me this

I would like to contribute on this issue. Please assign this issue to me.

Hi @Niketkumardheeryan, would you like to assign this issue to me? I want to contribute through GSSOC 2024
Here's how I plan to approach the project:

I'll start by collecting data from open-source sites, focusing on the Twitter MBTI Personality Detection dataset.
Next, I'll conduct exploratory data analysis (EDA) and preprocessing to prepare the data for modeling.
I'm considering using Transformer Models such as BERT and TweetBERT to extract embeddings for model selection. Additionally, traditional ML classifiers and NNs to see which best fits our needs.

Hi @Niketkumardheeryan , I would like to work for this issue. I am a GSSOC'24 contributor.


SendMessage don't Work. File: WAPI.js

Hey, guys. When trying to send messages to unsaved contacts (and who have no conversation history), the message will not go. The following message appears:
VM10531:300 Uncaught TypeError: Cannot read property 'sendMessage' of undefined
at Object.window.WAPI.getChat (:300:32)
at Object.window.WAPI.sendMessage (:780:21)
at :1:6

Same issue here...

Also Not send on New number..it is working only if chat with that number exist.

Close that, has been already answered, to replace FindChat functions and to to use internal constructor for new chat.


Environment versions

Please, provide exact versions of python and python packages you used
Thank you

Thanks for your friendly reminder. The exact version of Python is 3.10. The relevant dependencies are listed in my updated requirements.txt file. Some of them may be redundant, but they should not affect reproducibility.


Make sure this tool doesn't already exist elsewhere.

I did a brief search/check that it didn't exist before forking/creating it, but... if someone else can double check, that'd be better.
(So we can avoid an issue like https://github.com/sourcegraph/htmlclean/issues/1. :P)

That is done now. \o/


FirebaseAuthError: There is no user record corresponding to the provided identifier. It was working in Node 18.12 but not working in 20.11.0

[READ] Step 1: Are you in the right place?

For issues related to the code in this repository file a Github issue.
If the issue pertains to Cloud Firestore, read the instructions in the "Firestore issue"
template.
For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: Windows 10_____
Firebase SDK version: 13.1.0_____
Firebase Product: auth_____ (auth, database, storage, etc)
Node.js version: 20.11.0_____
NPM version: _____

[REQUIRED] Step 3: Describe the problem
FirebaseAuthError: There is no user record corresponding to the provided identifier. It was working in Node 18.12 but not working in 20.11.0 I have double checked its working fine on 18.12.1 simply without any change but its breaking with error on 20.11.0
There is no user record corresponding to the provided identifier.
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

Relevant Code:

// TODO(you): code here to reproduce the problem

i am getting tehsame error currently runnig same node version how did you solve this error

I am also experiencing the same error currently running node v20.10.0 and i get the same challemge with firebase thought i am using graphql . I'm creating a document in firestore when that contains a token hash .The token hash will be used in  tandem with the email and password to create a user account

I don't see any integration test failures on this API. Are you still facing this issue? It would help if you can provide us with a minimal repro


'help us translate' badge link is breaking the layout on mobile/smaller screens

Describe the bug
The link to the i18n contribution docs is breaking the layout on mobile/smaller screens.
To Reproduce
Steps to reproduce the behavior (Try this on a mobile device or change your window viewport to a smaller one):

Go to https://www.freecodecamp.org/espanol/learn/javascript-algorithms-and-data-structures/
Scroll down to 'Cursos'
See how 'Ayúdanos a traducir' link is breaking the layout

Expected behavior
It shouldn't break the layout. In that breakpoint the usual thing is that each element remains on a different line.
Screenshots

Thanks for reporting this issue:
An easy way to tackle this would be to remove the no-wrap to add the followings:
.block-cta-wrapper {
  /* white-space: nowrap;*/
  flex-grow: 2;
  flex-basis: 0;
  font-size: 0.8rem;
  text-align: center;
}

.block-title-wrapper .block-link {
   flex-grow: 3;
   flex-basis: 0;
}


Default constructors

Breaking change: constructor now uses encryption manager and auth manager instances instead of options
Will add docs once PR is approved :)

Codecov Report

Merging #55 (64183ee) into refactor-encryption-manager (0d2cf68) will decrease coverage by 0.61%.
The diff coverage is 95.83%.

@@                       Coverage Diff                       @@
##           refactor-encryption-manager      #55      +/-   ##
===============================================================
- Coverage                        84.96%   84.35%   -0.62%
===============================================================
  Files                               18       18
  Lines                              379      377       -2
  Branches                            53       49       -4
===============================================================
- Hits                               322      318       -4
- Misses                              57       59       +2

Impacted Files
Coverage Δ

.../ipfs-cpinner-client/src/auth-manager/constants.ts
100.00% <ø> (ø)

...ules/ipfs-cpinner-client/src/auth-manager/store.ts
33.33% <33.33%> (ø)

...ules/ipfs-cpinner-client/src/auth-manager/index.ts
100.00% <100.00%> (ø)

...pfs-cpinner-client/src/encryption-manager/index.ts
100.00% <100.00%> (ø)

modules/ipfs-cpinner-client/src/index.ts
78.43% <100.00%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2cf68...64183ee. Read the comment docs.


String based node access + Performance App

Describe your changes
Drafts an SDK extension allowing string-based search for data points (with the downside making the model "non-constant")
Sketches the Performance Test App:

Current commit: App is not using any vehicle model ("pure string-based")
One commit back: App is "partially" using the vehicle model

Open topics:

Read json file w/ data points
Fix the output - esp. the timestamp
Output for arrays missing

Issue ticket number and link

Checklist - Manual tasks

[ ] Examples are executing successfully

[ ] Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.

[ ] Created/updated integration tests.

[ ] Devcontainer can be opened successfully

[ ] Devcontainer can be opened successfully behind a corporate proxy

[ ] Devcontainer can be re-built successfully

[ ] Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas Docs)

We decided not to follow the approach of querying the model for data points addressed by their string representation.
Therefore closing this PR.
New PR for the performance test app: #95


Segfault using result of FieldValue_v1.String()

While trying to implement https://github.com/NVIDIA/dcgm-exporter/issues/72 I've encountered a segfault when trying to use DCGM_FI_DRIVER_VERSION; specifically if I try to format the result of FieldValue_v1.String().
I've only written a few hundred lines of Go in my life, but this looks suspicious: it's directly casting a C NUL-terminated string to a Go string, rather than using C.GoString.

Hi @bmerry,
Thank you for the report!
Yes, you are right, that's a bug. As you could see from several lines below, the strings are should be handled differently.

Fixed with MR#19


Add default parameter value for block tag

Hello! You state that blockTag parameter on the function call is optional but do not actually set the default value.
That was the reason the library wasn't detecting the proxy for me but just returning null, as I mentioned here.
Please feel free to make adjustments in case I missed anything. Thanks for a useful lib ;)

Looks good! Thank you. Do the tests pass?

Do the tests pass?

Yes, all good with tests!


List of AML Pip Packages out of date

In a CI I created today, the AML Pip packages installed are:
azureml-accel-models
azureml-automl-core
azureml-automl-runtime
azureml-contrib-interpret
azureml-contrib-notebook
azureml-contrib-pipeline-steps
azureml-contrib-reinforcementlearning
azureml-contrib-server
azureml-contrib-services
azureml-core
azureml-dataprep
azureml-dataprep-native
azureml-defaults
azureml-explain-model
azureml-interpret
azureml-mlflow
azureml-model-management-sdk
azureml-opendatasets
azureml-pipeline
azureml-pipeline-core
azureml-pipeline-steps
azureml-samples
azureml-sdk
azureml-telemetry
azureml-tensorboard
azureml-train
azureml-train-automl
azureml-train-automl-client
azureml-train-automl-runtime
azureml-train-core
azureml-train-restclients-hyperdrive
azureml-widgets

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5431c3cc-af53-d7d5-4241-cf3d23d8689e
Version Independent ID: 1b7eedd5-e934-aa15-d5c7-32ad82e45bbf
Content: What is an Azure Machine Learning compute instance? - Azure Machine Learning
Content Source: articles/machine-learning/concept-compute-instance.md
Service: machine-learning
Sub-service: core
GitHub Login: @sdgilley
Microsoft Alias: sgilley

@ezwiefel we will review your feedback and get back to you shortly. Thanks.

#assign:@sdgilley

@ezwiefel, thanks for your feedback.  I've opened a work item and will be discussing this with the engineers to find a better way to keep this list updated and accurate.  I don't have a specific timeline yet, hopefully in the next week or so.  This issue is linked to the work item so will be updated when a PR has merged.
#please-close


Catch runAllSteps errors and repost them to the main thread.

Needs UI support to show the appropriate error in flashing lights somewhere.

@LTLA

LGTm


Improve BrowserDOMElement.getAttributes

We expect getting the HTML or XML attributes here. However, this method is used in a special way internally and has different semantics.
We should move the component specific code somewhere else and let getAttributes behave as expected.
https://github.com/substance/substance/blob/master/ui/BrowserDOMElement.js#L65

This is ok now.


v1.6.0: [ERR_INVALID_ARG_TYPE] when using preprocess

Hi there,
I was just setting up a new project with TS and have gotten a complex error on starting the test (see below). After fiddling a bit, I tried Version 1.5.0 didn't have the issue. Since I could reproduce the issue on 2 machines, I'm quite sure, the cause lies in v1.6.0 of svelte-jester.
These were my steps:

update node form version 14.13.0 to version 14.17.0 (LTS) > same error code from the title, but different "details"
test on another machine (node v14.15.4) > same error as first machine before update
downgrade of svelte-jester to version 1.5.0 > no error, tests work fine on both machines

I created a repo with which the error should be reproducible: https://github.com/Jak-Ch-ll/svelte-jester-error

Error on first machine (Windows 10, node v14.17.0, svelte-jster v1.6.0)
internal/process/promises.js:213
        triggerUncaughtException(err, true /* fromPromise */);
        ^

TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received
an instance of NodeError
    at Socket.Writable.write (internal/streams/writable.js:285:13)
    at file:///D:/data/learning/udemy/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
  code: 'ERR_INVALID_ARG_TYPE'
}
 FAIL  src/pages/SignUpPage.spec.ts
  ● Test suite failed to run

    Command failed: node --unhandled-rejections=strict --abort-on-uncaught-exception D:\data\learning\udemy\svelte-tdd\node_modules\svelte-jester\src\preprocess.js
    internal/process/promises.js:213
            triggerUncaughtException(err, true /* fromPromise */);
            ^

    TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of NodeError
        at Socket.Writable.write (internal/streams/writable.js:285:13)
        at file:///D:/data/learning/udemy/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
      code: 'ERR_INVALID_ARG_TYPE'
    }

      at Socket.Writable.write (internal/streams/writable.js:285:13)
      at file:/D:/data/learning/udemy/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
        code: 'ERR_INVALID_ARG_TYPE'
      }
      at Object.process (node_modules/svelte-jester/src/transformer.cjs:17:28)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

Error on second machine (Windows 10, node v14.15.4, svelte-jster v1.6.0)
internal/process/promises.js:213
        triggerUncaughtException(err, true /* fromPromise */);
        ^

TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of NodeError
    at Socket.Writable.write (internal/streams/writable.js:285:13)
    at file:///C:/Users/J.c/Documents/learning/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
  code: 'ERR_INVALID_ARG_TYPE'
}
 1: 00007FF7BCC8058F napi_wrap+109311
 2: 00007FF7BCC252B6 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfElementsOffset+33302
 3: 00007FF7BCC27BB9 node::OnFatalError+7257
 4: 00007FF7BD49E72F v8::internal::Builtins::builtin_handle+321471
 5: 00007FF7BD49DCC4 v8::internal::Builtins::builtin_handle+318804
 6: 00007FF7BD49DFB7 v8::internal::Builtins::builtin_handle+319559
 7: 00007FF7BD49DE03 v8::internal::Builtins::builtin_handle+319123
 8: 00007FF7BD579F9D v8::internal::SetupIsolateDelegate::SetupHeap+464173
 9: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
10: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
11: 00007FF7BD51055E v8::internal::SetupIsolateDelegate::SetupHeap+31470
12: 00007FF7BD51014C v8::internal::SetupIsolateDelegate::SetupHeap+30428
13: 00007FF7BD3E0631 v8::internal::Execution::CallWasm+1649
14: 00007FF7BD3DFE9F v8::internal::Execution::Call+191
15: 00007FF7BD4CB7E7 v8::Function::Call+615
16: 00007FF7BCCA42DD node::CallbackScope::~CallbackScope+861
17: 00007FF7BCCA3FEE node::CallbackScope::~CallbackScope+110
18: 00007FF7BCC0EA38 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+199704
19: 00007FF7BCCD8017 uv_timer_stop+775
20: 00007FF7BCCD484B uv_async_send+331
21: 00007FF7BCCD3FDC uv_loop_init+1292
22: 00007FF7BCCD417A uv_run+202
23: 00007FF7BCBE02B5 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+9365
24: 00007FF7BCC53A17 node::Start+311
25: 00007FF7BCAB686C RC4_options+339820
26: 00007FF7BDA5604C v8::internal::compiler::RepresentationChanger::Uint32OverflowOperatorFor+153532
27: 00007FFE42997034 BaseThreadInitThunk+20
28: 00007FFE447E2651 RtlUserThreadStart+33
 FAIL  src/pages/SignUpPage.spec.ts
  ● Test suite failed to run

    Command failed: node --unhandled-rejections=strict --abort-on-uncaught-exception C:\Users\J.c\Documents\learning\svelte-tdd\node_modules\svelte-jester\src\preprocess.js
    internal/process/promises.js:213
            triggerUncaughtException(err, true /* fromPromise */);
            ^

    TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of NodeError
        at Socket.Writable.write (internal/streams/writable.js:285:13)
        at file:///C:/Users/J.c/Documents/learning/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
      code: 'ERR_INVALID_ARG_TYPE'
    }
     1: 00007FF7BCC8058F napi_wrap+109311
     2: 00007FF7BCC252B6 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfElementsOffset+33302
     3: 00007FF7BCC27BB9 node::OnFatalError+7257
     4: 00007FF7BD49E72F v8::internal::Builtins::builtin_handle+321471
     5: 00007FF7BD49DCC4 v8::internal::Builtins::builtin_handle+318804
     6: 00007FF7BD49DFB7 v8::internal::Builtins::builtin_handle+319559
     7: 00007FF7BD49DE03 v8::internal::Builtins::builtin_handle+319123
     8: 00007FF7BD579F9D v8::internal::SetupIsolateDelegate::SetupHeap+464173
     9: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
    10: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
    11: 00007FF7BD51055E v8::internal::SetupIsolateDelegate::SetupHeap+31470
    12: 00007FF7BD51014C v8::internal::SetupIsolateDelegate::SetupHeap+30428
    13: 00007FF7BD3E0631 v8::internal::Execution::CallWasm+1649
    14: 00007FF7BD3DFE9F v8::internal::Execution::Call+191
    15: 00007FF7BD4CB7E7 v8::Function::Call+615
    16: 00007FF7BCCA42DD node::CallbackScope::~CallbackScope+861
    17: 00007FF7BCCA3FEE node::CallbackScope::~CallbackScope+110
    18: 00007FF7BCC0EA38 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+199704
    19: 00007FF7BCCD8017 uv_timer_stop+775
    20: 00007FF7BCCD484B uv_async_send+331
    21: 00007FF7BCCD3FDC uv_loop_init+1292
    22: 00007FF7BCCD417A uv_run+202
    23: 00007FF7BCBE02B5 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+9365
    24: 00007FF7BCC53A17 node::Start+311
    25: 00007FF7BCAB686C RC4_options+339820
    26: 00007FF7BDA5604C v8::internal::compiler::RepresentationChanger::Uint32OverflowOperatorFor+153532
    27: 00007FFE42997034 BaseThreadInitThunk+20
    28: 00007FFE447E2651 RtlUserThreadStart+33

      at Socket.Writable.write (internal/streams/writable.js:285:13)
      at file:/C:/Users/J.c/Documents/learning/svelte-tdd/node_modules/svelte-jester/src/preprocess.js:11:32 {
        code: 'ERR_INVALID_ARG_TYPE'
      }
       1: 00007FF7BCC8058F napi_wrap+109311
       2: 00007FF7BCC252B6 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfElementsOffset+33302
       3: 00007FF7BCC27BB9 node::OnFatalError+7257
       4: 00007FF7BD49E72F v8::internal::Builtins::builtin_handle+321471
       5: 00007FF7BD49DCC4 v8::internal::Builtins::builtin_handle+318804
       6: 00007FF7BD49DFB7 v8::internal::Builtins::builtin_handle+319559
       7: 00007FF7BD49DE03 v8::internal::Builtins::builtin_handle+319123
      8: 00007FF7BD579F9D v8::internal::SetupIsolateDelegate::SetupHeap+464173
      9: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
      10: 00007FF7BD5128A2 v8::internal::SetupIsolateDelegate::SetupHeap+40498
      11: 00007FF7BD51055E v8::internal::SetupIsolateDelegate::SetupHeap+31470
      12: 00007FF7BD51014C v8::internal::SetupIsolateDelegate::SetupHeap+30428
      13: 00007FF7BD3E0631 v8::internal::Execution::CallWasm+1649
      14: 00007FF7BD3DFE9F v8::internal::Execution::Call+191
      15: 00007FF7BD4CB7E7 v8::Function::Call+615
      16: 00007FF7BCCA42DD node::CallbackScope::~CallbackScope+861
      17: 00007FF7BCCA3FEE node::CallbackScope::~CallbackScope+110
      18: 00007FF7BCC0EA38 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+199704
      19: 00007FF7BCCD8017 uv_timer_stop+775
      20: 00007FF7BCCD484B uv_async_send+331
      21: 00007FF7BCCD3FDC uv_loop_init+1292
      22: 00007FF7BCCD417A uv_run+202
      23: 00007FF7BCBE02B5 v8::internal::OrderedHashTable<v8::internal::OrderedHashSet,1>::NumberOfBucketsOffset+9365
      24: 00007FF7BCC53A17 node::Start+311
      25: 00007FF7BCAB686C RC4_options+339820
      26: 00007FF7BDA5604C v8::internal::compiler::RepresentationChanger::Uint32OverflowOperatorFor+153532
      27: 00007FFE42997034 BaseThreadInitThunk+20
      28: 00007FFE447E2651 RtlUserThreadStart+33
      at Object.process (node_modules/svelte-jester/src/transformer.cjs:17:28)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:612:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:758:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:815:19)

Is there another error messaage at the top? Like
> jest --watch "--no-watch" "--ci" "--no-cache"

(node:30785) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/process/promises:227
        triggerUncaughtException(err, true /* fromPromise */);
        ^

Could you downgrade jest and ts-jest to 26.* ? It seems we are not compatible to v27 yet.

With Jest v27 I can't get it to work. Even if I downgrade svelte-jester to 1.5.0
I get this:
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){export default function slash(path) {
                                                                                ^^^^^^

    SyntaxError: Unexpected token 'export'

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1479:14)

It's the same error for me with Jest v26.6.3 and ts-jest 26.5.4

Regarding your questions:
1. No there is no more error above what I copied, only the command I used, which was `jest --watch`

2. It's the same error for me with Jest v26.6.3 and ts-jest 26.5.4.

3. I did download my git and tested with that and it still works. Not sure why you are getting a completely different error

Thats because I did run it on OSX. I used another machine with windows and fixed the error. Should be released soon.

Hello,
I have the same error running on OSX with Jest v26.6.3, ts-jest 26.5.6 and svelte-jester 1.7.0. Is the fix already released?

Hello,
I have the same error running on OSX with Jest v26.6.3, ts-jest 26.5.6 and svelte-jester 1.7.0. Is the fix already released?

Yes, it should be fixed. Can you provide a repo, where we can test your code?

Can you provide a repo, where we can test your code?

Sure,
I have isolated the problem here: https://www.dropbox.com/s/5dt8wd92bzj7ftl/test-project.zip?dl=0 (after npm install you can run the tests with npm run test:unit).
Don't know if it changes anything, but my node version is 16.3.0.

Can you provide a repo, where we can test your code?

Sure,
I have isolated the problem here: https://www.dropbox.com/s/5dt8wd92bzj7ftl/test-project.zip?dl=0 (after npm install you can run the tests with npm run test:unit).
Don't know if it changes anything, but my node version is 16.3.0.

Thanks. Got it! The real error is swallowed. Node complains about mixing commonJS and ESM. You can fix, if you rename your svelte.test.config.js to svelte.test.config.mjs. You need to adjust the path to the file in jest.config.js too.
I will fix the lib to not swallow the error.