[Details Revamp] Allow Editing Report Title from Details Page

Details

Moved the option to rename the money report title field from the report view into the new report details.
Fixed Issues

$ https://github.com/Expensify/App/issues/44149
PROPOSAL:
Tests

Create a workspace.
Submit two separate expenses for said workspace.
Go into the money report view of those workspace expenses.
Confirm that the title editable field is gone and is instead modifiable when pressing on the report header (Only members, approvers and admins should be able to edit it, invitees should not have that option).

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/88325488/2ae2a13f-dbb4-40ba-bf78-d6ab009b63d6

Android: mWeb Chrome
https://github.com/Expensify/App/assets/88325488/e0a1c568-712d-4d70-977b-91e3b0a371a6

iOS: Native
https://github.com/Expensify/App/assets/88325488/0928e7c2-de04-4bc5-8ace-28213df23c61

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88325488/ef479fc6-dd26-4d0f-8fba-ec1414dde814

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88325488/b2318fed-7d2a-4b5d-a0eb-38fcea962018

MacOS: Desktop
https://github.com/Expensify/App/assets/88325488/d548c87c-75b2-465d-b8db-da2b62f2e692

I believe "Invitee" being referenced here is just a random user that might be @-mentioned on an expense report and then has the report shared with them. It doesn't mean the submitter of the expense report. The submitter should be able to edit the title of their expense report (so long as default report titles aren't enforced on the workspace, in which case nobody can edit the titles).

I'm fairly sure that user B should still be able to change the title, you can check the requirements here.
The direct quote is here:

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

Haha, jinx.

I believe "Invitee" being referenced here is just a random user that might be @-mentioned on an expense report and then has the report shared with them.

For such user, The title seems missing is this a bug ?

It is a bug, I'll let you know when I fix it.

@ishpaul777 I've pushed a fix, let me know if it works for all cases (member, admin, invitee).

@cdOut let me know when you're ready for a new build

@grgia should be ready for a new build now.

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.5-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.5-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Create LICENSE file

Would you please consider creating a LICENSE file containing your copyright information and the text of the MIT license?  The MIT license specifically states that the text of the license must accompany the source code.  (It also makes life easier for people like me who like to package up software like yours for LInux distributions.)
Thanks!

Done! https://github.com/schollz/sdees/commit/ddfb13e8b3987d242e9f4dcad19350b1cd67559c


Add Clarendon filter.

Continuation of https://github.com/una/CSSgram/pull/104

Awesome :) thanks for this :+1:

It was mostly you, @una! :cactus:


[Question] Build in local machine

Can we build it locally and upload it to the server?

Hi, The build process is based on OS and libraries are linked and loaded dynamically, basically there is not just a single binary file to publish it to all users, each build is different based on OS and ..., AFAIK there are no pre-built binaries either.

Ok, thanks for the quick reply.


Getting TypeError: undefined is not an object

I created fresh new project using create-react-native-app AwesomeProject command. then i installed the plugin and copy all the code and paste it in app.js
after that i run it into expo, and getting the following errors:
TypeError: undefined is not an object (evaluating '_reactNativeGetSmsAndroid2.default.list')

This error is located at:
    in example (at registerRootComponent.js:35)
    in RootErrorBoundary (at registerRootComponent.js:34)
    in ExpoRootComponent (at renderApplication.js:35)
    in RCTView (at View.js:78)
    in View (at AppContainer.js:102)
    in RCTView (at View.js:78)
    in View (at AppContainer.js:122)
    in AppContainer (at renderApplication.js:34)
* App.js:33:15 in listSMS
* App.js:24:4 in example
- node_modules/react-proxy/modules/createClassProxy.js:98:23 in <unknown>
- node_modules/react-proxy/modules/createClassProxy.js:96:6 in instantiate
- ... 26 more stack frames from framework internals

Hi, @rassemdev. Currently, the npm module doesn't work with Expo. You can try running it using react-native start on an emulator.

@briankabiro  thanks for you reply, I changed the process. I created new app using react-native init my-project command. then i cd into my project and install the plugin using npm install react-native-get-sms-android --save this command and copy all the example code paste it in app.js. After that i run the project using react-native run-android. Still I'm getting those errors:
The development server returned response error code: 500

URL: http://localhost:8081/index.delta?platform=android&dev=true&minify=false

Body:
{"type":"InternalError","errors":[],"message":"Metro Bundler has encountered an internal error, please check your terminal error output for more details"}
processBundleResult
    BundleDownloader.java:266
access$200
    BundleDownloader.java:35
onResponse
    BundleDownloader.java:153
execute
    RealCall.java:135
run
    NamedRunnable.java:32
runWorker
    ThreadPoolExecutor.java:1113
run
    ThreadPoolExecutor.java:588
run
    Thread.java:818

killall node -9
solved the errors.. Thanks.. you can close this issue now. It is working


[Feature] Suggestion: add InstallWhenNeeded to make installation easier

Hi,
I'm trying to get Playwright working in multiple teams. But different setup/code bases makes the installation a bit of a headache.
And then I had an idea, why don't we just make it easy? For example, add an option, like InstallWhenNeeded  to BrowserTypeLaunchOptions that installs the browser when needed. This should work, as this is currently my work around to make things super easy:
private static async Task<IBrowser> CreateChromiumBrowser(IPlaywright playwright, BrowserTypeLaunchOptions options)
{
    IBrowser browser;
    try
    {
        browser = await playwright.Chromium.LaunchAsync(options);
    }
    catch (PlaywrightException e) when (e.Message.Contains("Executable doesn't exist"))
    {
        Program.Main(new[] { "install", "chromium" });
        browser = await playwright.Chromium.LaunchAsync(options);
    }
    return browser;
}

And yes, it make the first test slow. But if that's an issue, you could still install it manually like before.

Calling Program.Main(new[] { "install", "chromium" }); is essentially "install if needed". It will do internally check if the corresponding browser of the Playwright version is installed.

Calling Program.Main(new[] { "install", "chromium" });

I'm already calling that?
Or do you mean:
private static async Task<IBrowser> CreateBrowser(IBrowserType browserType, BrowserTypeLaunchOptions options)
{
  Program.Main(new[] { "install", browserType.Name });
  return await browserType.LaunchAsync(options);
}


npm install fails due to missing version in package.json

Using npm v2.12.1:
➜  client git:(amokify) ✗ npm install --save-dev caspervonb/amokify
npm ERR! addLocal Could not install /var/folders/rs/k1q260bx1q73kcqyy8t2vq080000gn/T/npm-83810-8d0bb289/git-cache-4788f2bb8499/b39e148d46c3222a42b10f4852389c66f2f7d566
npm ERR! addLocal Could not install /var/folders/rs/k1q260bx1q73kcqyy8t2vq080000gn/T/npm-83810-8d0bb289/git-cache-4b788ae02feb/b39e148d46c3222a42b10f4852389c66f2f7d566
npm ERR! addLocal Could not install /var/folders/rs/k1q260bx1q73kcqyy8t2vq080000gn/T/npm-83810-8d0bb289/git-cache-de9f87484014/b39e148d46c3222a42b10f4852389c66f2f7d566
npm ERR! Darwin 14.5.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.7
npm ERR! npm  v2.12.1

npm ERR! No version provided in package.json
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/kshipley/Programming/rms/client/npm-debug.log

I also tried adding it directly to package.json with a branch name / SHA and that failed too.
(It's possible that npm 3 is more lenient on this, but don't have it handy on this machine.)

Looks like other people are on it! Just saw #5.
Feel free to close, or maybe keep this open until you add a version just to avoid dupes?

Keep it open for now.
Will a version of 0.0.0 satisfy npm?

I'll try with a branch later and git install it. Works with file install but so does no version.

I got the same issue even do I added a version to the package.json in my local module

@acarlstein Workspaces in Chrome developer tools now do most of what amok did, unmaintained for quite a while.


Broken link "[how to send and receive text messages]"

https://docs.microsoft.com/en-us/azure/bot-service/directline-speech-bot?view=azure-bot-service-4.0

stale

stale


Implement AuthN via App Service Module

Description
As a developer, I'd like to enable EasyAuth on my App Service, so that I can authenticate users.
Acceptance Criteria

[ ] Should configure EasyAuth using auth_settings code block in TF docs in existing App Service Module
[ ] Should use AAD Application ID in auth_settings code block

Also, here are a few points that need to be addressed:

Current App Service Module will need to be changed to support auth_settings
We're only focusing on Web Applications not native applications for the AAD Application type.
This user story does not include creating AAD Application through Service Principal module.

Resources
Technical Design Doc
Terraform App Service Auth Docs
Terraform AzureAD App Docs
Tasks
App Service Module

Create auth_settings code block that contains active_directory code block.
Test deployment with an existing AAD application ID

Integration Test

Test by using a "throw away" Template that creates an AAD Application and then references this to configure Easy Auth in App Service. Verify in the portal.

Doesn't need to be in an existing template... Just create a template to test and take a screenshot.

@TechnicallyWilliams please add the t-shirt sized estimation label for this user story.


HADOOP-18093: Better exception handling for testFileStatusOnMountLink

Description of PR
Use @Test(expected = FileNotFoundException.class) to indicate we are expecting a FileNotFound exception. This makes it consistent with how similar exceptions are handled in this class as well.
How was this patch tested?
mvn test -Dtest=TestViewFsLocalFs

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 49s

trunk passed

+1 :green_heart:
compile
30m 57s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
26m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 53s

trunk passed

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 54s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
30m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
32m 35s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
32m 35s

the patch passed

+1 :green_heart:
compile
20m 41s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

hadoop-common-project/hadoop-common: The patch generated 0 new + 82 unchanged - 1 fixed = 82 total (was 83)

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 38s

the patch passed

+1 :green_heart:
shadedclient
25m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 32s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

244m 55s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3918

JIRA Issue
HADOOP-18093

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux bfe9b4da88db 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ac45e08706fc4695eb7ea2e0d6e660b9186e8e98

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/testReport/

Max. process+thread count
2319 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3918/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

this test failure seems to happen on trunk without my change as well. Are we good to merge this pull request?
"TestIPC.testIOEOnListenerAccept:652 Expected an EOFException to have been thrown"

Yeps, we are. TestIPC is flaky and is being tracked seperately.
Will merge this by tomorrow if no further comments..

Awesome! thanks @ayushtkn!

Thanx @xinglin for the contribution!!!

@ayushtkn Can you approve and commit my other pull requests to get this change merged into lower supported versions? I should have mentioned targeted version in my jira issue.

@xinglin Done. Thanx for the contribution!!!


Ensure columns on schedule page have same width as columns on rooms page

The schedule page has different column widths to the rooms page. Please change the width of the column pages and ensure it matches the design of the rooms page.

@mariobehling
I saw the source code of both the pages and they seemed to be using the same width of the columns. The date row was given 2 columns and the session titles were given 10 columns in both the pages. Can you please specify what specific changes in the width are we aiming for? Thanks.

Please compare sample page:
http://fossasia.github.io/open-event-webapp/schedule.html and http://fossasia.github.io/open-event-webapp/rooms.html
Width of left side and middle column are different.

@mariobehling
How is this?

Comparing with rooms page

Very good. Thank you.

closed via #854 :)


Hotfix/issue-284

This change is

Current coverage is 58.67% (diff: 93.61%)

Merging #353 into master will decrease coverage by 0.02%

@@             master       #353   diff @@
==========================================
  Files          1911       1911
  Lines         97620      97628     +8
  Methods           0          0
  Messages          0          0
  Branches      12130      12139     +9
==========================================
- Hits          57303      57282    -21
- Misses        37302      37331    +29
  Partials       3015       3015

Powered by Codecov. Last update 6860d75...077e902

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

oscm-portal/WebContent/operator/manageConfiguration.xhtml, line 46 at r1 (raw file):

                <f:validator validatorId="confValue"/>
              </h:inputText>
              <h:outputText value="#{rowItem.value}" styleClass="label" rendered="#{rowItem.informationId.readonly and rowItem.informationId.type != 'password'}"/>

The read-only password values will not be rendered?

Comments from Reviewable

Please check how the new code behave with old database (settings imported with old code)

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Swift style enhancements

This commits incorporates mostly stylistic Swift enhancements
Updated the callback mechanism to use associated type vs optionals for result and error
Removed some "withXXX" to suffix of some methods
Builders now return optional ViewController
Still missing proper service orchestration in WeatherListDefaultInteractor

For me is all right!


pac paportal and pac powerpages not working for newly created power pages sites

Hi,
I have followed the steps in the various articles, but I end up with the below message. Please help
Information:
Be careful when you're updating public sites. The changes you make are visible to anyone immediately. To check site visibility go to https://make.powerpages.microsoft.com/.
To get additional information, please visit https://go.microsoft.com/fwlink/?linkid=2204350
Started downloading website WEBSITEID
Connected to... UAT Enivronment
Connected as admin
Microsoft PowerPlatform CLI
Version: 1.28.3+g4ba7dfd
Online documentation: https://aka.ms/PowerPlatformCLI
Feedback, Suggestions, Issues: https://github.com/microsoft/powerplatform-build-tools/discussions
Error: Power Pages entities aren't available on this org, please install Power Pages package on the org.

Hi,
Thank you. I figured out that including -mv in the command will download the site.

Hi,
Thank you. I figured out that including -mv in the command will download the site.

Hi can you please tell me exactly where you entered -mv because placing it at end gives me an error
/Sorry, the app encountered a non recoverable error and will need to terminate. The exception details have been captured and will be forwarded to the development team, if telemetry has been enabled. Exception Id: bd5ac722-8361-47f8-a595-1593d923ccc2, Exception Type: System.NullReferenceException The diagnostic logs can be found at: C:\Users\AryanSharma\AppData\Local\Microsoft\PowerAppsCli\Microsoft.PowerApps.CLI.1.30.4\tools\logs\pac-log.txt
this log file also don't contain any useful data

If your downloading from "Portal Managment" then
pac paportal download --path [PATH] --webSiteId [WEBSITEID] -mv 1
If your downloading from "Power Pages Management" then
pac paportal download --path [PATH] --webSiteId [WEBSITEID] -mv 2
Make sure you connected to the right environment while downloading and uploading.

pac paportal download --path [PATH] --webSiteId [WEBSITEID] -mv 1

Thanks mv 2 worked for me, but i'm still confused how do i know if I'm downloading from portal management or power pages management?
because

pac auth create --name [name] --url [environment url]
i connected to environment using

pac auth list
Then to get my ev

pac auth select --index 1
to select my ev

pac paportal list
to get my all sites id

pac paportal download --path [path] --webSiteId [website id]
download site data

In the home of https://make.powerpages.microsoft.com/...
click on the ellipses(...) of the targeted sites by you. It will contain Portal Management or Power Pages Management


Displaying Images With Fresco Library In Android

Displaying Images With Fresco Library In Android
Introduction paragraph (2-3 paragraphs):
Fresco is a powerful system for displaying images in Android applications.
Fresco takes care of image loading and displaying, so you don't have to worry about the logic on how the image is loaded. It will load images from:

Network
Local storage
Local resources
and display a placeholder until the image has arrived. It has two levels of cache; one in memory and another in internal storage.
In this article we will see how to setup Fresco in an android application.

Key takeaways:

What is Fresco
How is Fresco different from other image processing libraries (Glide and Picasso)
Unique features of Fresco
How to setup fresco in android

References:

https://frescolib.org/

@brandy-kay
Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

Hi @brandy-kay
This sounds like a really interesting topic in Android. I however think there is more about fresco you could talk about. Stuff like streaming images and animations. You could add these to provide an in-depth overview of the library as the normal images loading libraries have addressed them. There are articles already on section on coil and glide and adding more specific features of fresco would help your article stand out.
Otherwise, article approved :rocket:


[v2] Things to improve

Hi Vladimir, I sent you here some things to improve. I have to copy them from project to project and some maybe would be useful for other people. Maybe you can add them to v2
Preloader
In material.css is missing the background-image of .preloader
In ios.css it has it.
Side Panels + Infinite scroll + pull to refresh
It would be useful, if we can use this components to the side panels
We use it for  notification's panel
Handler for Backbutton in Android
Maybe you could add this function to include in onDeviceready call.
If you don't use push state = true and you're in index page, you want to exit the app when the user press backbutton.
This function handles that:

onBackButton: function (e) {

          if(mainView.activePage.name == "index" ){
              e.preventDefault();

              myApp.confirm("Te gustaría cerrar la aplicación?",
                config.app_name,
                function () {
                            navigator.app.clearHistory();
                            if (navigator.app && navigator.app.exitApp) {
                              navigator.app.exitApp();
                            } else if (navigator.device && navigator.device.exitApp) {
                              navigator.device.exitApp();
                            }
                },
                function () {
                  //myApp.alert('You clicked Cancel button');
                }
              );
          }else{
             mainView.router.back();
          }
    },

Back HOME
If you open many pages and you want in the last one to goback to home and reset the history, maybe you could add this function.
 index_forzar_back : function () {

                    $$('.navbar-on-left').remove();
                    $$('.page-on-left').remove();

                    // RESET THE HISTORY
                    var index   = mainView.history[0];
                    var actual  = mainView.activePage.url;
                    mainView.history = [];

                   // ADD THE ACTUAL
                    mainView.history.push(index);
                    mainView.history.push( actual );

                   // GO BACK
                    mainView.router.back({ignoreCache:true,force:true});
        },

INFINITE SCROLL - PAGE COUNT LOADING
It happens that if you have multiples pages open and you want to keep in memory the pages that you look at each one, you need to have a var like this
var infinitscroll = {
   esta_cargando : false,
   paginas:        [],    // aca guarda la pagina y por que nro va, para evitar los historys
                          // ej:  ["index"] = 1
                          //     infinitscroll.paginas[ "page-name" ] = XX
}

So when you enter  into the on('infinite you can handle the page that you've fetched  last time.
Maybe this could be added to the myApp var
    // INFINITE SCROLL

    $$('.infinite-scroll').on('infinite', function () {

      // Exit, if loading in progress
      if (infinitscroll.esta_cargando)  return;

      // Set loading flag
      infinitscroll.esta_cargando = true;

      // Emulate 1s loading
      setTimeout(function () {

            infinitscroll.esta_cargando = true;
            $$(".page-name .infinite-scroll-preloader").show();

            load_data( function(){
                        infinitscroll.esta_cargando = false;
                       infinitscroll.paginas[ helpers.infinite_scroll_page_name() ]++;

                       $$(".page-name .infinite-scroll-preloader").hide();
           });

        }, 1000);
    });

And for pull-to-refresh method, you should initialize that var to 0
infinitscroll.paginas[ helpers.infinite_scroll_page_name() ] = 0 ;

Wow great list!
I hope @nolimits4web can consider this.

Thanks guys, I will consider it of course. Just trying to release first beta this week. And then I’ll go deeper for improvements

@nolimits4web
Amazing!!!!!!
Thank you soooo much for your hard work!!!

Issue is closed because of outdated/irrelevant/not actual
If this issue is still actual and reproducible for latest version of Framework7, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Add House Robber 3 Problem and rename  0213_House_robber.py -> 0213_House_robber2.py

IMPORTANT: Please do not create a Pull Request without an issue.
Issue No. :- #508
All Submissions:

[ ] I have read the CONTRIBUTING document.
[ ] My code is written in Python3 and is ending with .py
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have checked that my submission does pass the test on LeetCode.com
[ ] Does your filename follow the naming Conventions?
[ ] Have you linked your PR to an Issue?

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

closes #508


Notfication registering breaking when relation editor is installed

The releation editor register an action with Letter "R". "R" is already registered by umbraco "Permissions" action.
This raises an duplicated id execption when you will change the notifcation on a folder which has the relation action enabled
Problem testet with Umbraco 7.2.1

Fixed in upcoming release. Now use 0x1337 and 0x7331 for letters. :)


Close to tray - does not reopen - Win x64

winx64 latest release.
With "Close to tray" selected, close the app.  When clicking on the system tray icon to restore the app, yakyak rapidly fills the task bar with processes before it disappears completely.  The app does not become visible.
If you right click the tray icon and click "toggle window show/hide" it appears normally.

Could you open yakyak through cmd and post the output here? I'm unable to reproduce this issue using the latest release, so I'm not sure what might be going on.

Command prompt does not show anything exciting while the bug is occurring.  Is there a flag for higher verbosity?
C:\Program Files\yakyak-win32-x64>
Starting Yakyak v<IP_ADDRESS>...
using hangupsjs v1.3.11
syncrecentconversations: Asking hangouts to sync recent conversations
hangupsjs:: connecting
reconnecting 0
resolving proxy http://plus.google.com
resolving proxy https://plus.google.com
resolved proxy DIRECT
resolved proxy DIRECT
connected 0
Goodbye
The window closes and restores normally as long as the first conversation is selected.  If I leave an older conversation selected the bug occurs.  If I use the menu option to restore window, select the first conversation again, the bug goes away.
I'm also unable to hide the window by clicking the tray icon with an older conversation selected.
Occurs on both my systems.   Win7 x64 and Win 10 x64.  Tested i386, did not help.
I did not experience this with previous versions.  Unfortunately I can't recall my last version, I only upgrade when things break.
It seems the beta is not affected, I will run that.  Let me know if you need any other information.

Thanks for the additional info! It's fixed by this commit in the beta, which is why you're not seeing it there: https://github.com/yakyak/yakyak/commit/c105351eb91f004facc9f2ad511dffb777f49a52 It basically happens because the click listener for the tray is added multiple times which causes it to toggle the window visibility as many times as it's been added. That commit fixes it by ensuring the click listener is only added once.
I'll backport that and release a new stable version today.

I've released <IP_ADDRESS> which fixes this, please let me know if it works!

Confirmed resolved!  Thank you!


Test failures while running test-cmd-pref-config test suite on ppc64le

I have made changes to the scripts/openshiftci-presubmit-all-tests.sh and scripts/configure-installer-tests-cluster.sh for Power on the lines of the Z changes.
Also done the setup required like creating the secret to pull redhat registry images. Currently I am trying to run the scripts/openshiftci-presubmit-all-tests.sh and seeing the below issues for test-cmd-pref-config test suite:
Summarizing 1 Failure:

[Fail] odo preference and config command tests when using --now with config command [It] should successfully set and unset variables
/usr/local/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

Ran 15 of 177 Specs in 130.070 seconds
FAIL! -- 14 Passed | 1 Failed | 0 Pending | 162 Skipped

Ginkgo ran 1 suite in 2m14.896996829s
Test Suite Failed
make: *** [Makefile:189: test-cmd-pref-config] Error 1

Attaching detailed test run and some post failure investigation steps -
odo_test-cmd-pref-config_failures_ppc64le.txt

cc:- @amitkrout ^^

/area system-pz

seems should not related to p/z arch ? looks like a config set failed?

[odo]  •  Waiting for component to start  ...
[odo] I0707 01:47:33.480309   58445 occlient.go:1926] Status of nodejs-app-1-zlgls pod is Pending
[odo]  ✗  Waiting for component to start [2m]
[odo]  ⚠  Watch channel was closed
[odo]  ✗  watch channel was closed

@jichenjc I am sure config set is correct. it looks similar to https://github.com/openshift/odo/issues/3454.

@amitkrout do you want me to check anything wrt config set?

@amitkrout do you want me to check anything wrt config set?

@sarveshtamba Not required. From the log output i do not see anything weird w.r.t. config set.

/kind test

Successfully executed ODO test suite 'test-cmd-pref-config' on Openshift 4.4 Cluster.
odo_test-cmd-pref-config_ppc64le_ocp4.4.txt

@amitkrout Facing the following issues in test-cmd-pref-config test suite:-
Summarizing 1 Failure:

[Fail] odo preference and config command tests when using --now with config command [It] should successfully set and unset variables
/usr/local/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

Ran 15 of 184 Specs in 91.605 seconds
FAIL! -- 14 Passed | 1 Failed | 0 Pending | 169 Skipped

Ginkgo ran 1 suite in 1m36.748016712s
Test Suite Failed
make: *** [Makefile:202: test-cmd-pref-config] Error 1

Attaching the detailed spec failure log -
odo_test-cmd-pref-config_failures_ppc64le_1.txt

Its again the same issue that has been reported with test-cmd-app https://github.com/openshift/odo/issues/3530#issuecomment-681098317

Same issue we have been hitting in prow CI too - https://github.com/openshift/odo/issues/3754

https://github.com/openshift/odo/pull/3851 should make it easy to see the reason for this failure

Will track this common issue in #3454 .


Add an example with double backprop

This repository (under examples) and chainer/models repository has no example with double backprop.

Example:
https://github.com/pfnet-research/chainer-gan-lib/blob/master/progressive/updater.py

Either reference that one above or add a minimal WGAN-GP?


App freezing while uploading a Image.

Hey,
I am using the example described in the Readme and using a trial account to test image upload. When I select an image from my image picker in ios and pass it to transload it the app freezes and I get back the control only after I get the response from transload it. Can you please let me know how to fix this?
{"ok":"BORED_INSTANCE_FOUND","host":"gigha.transloadit.com","api2_host":"gigha.transloadit.com"}

Hi, there,
I saw the same behaviour and went with calling transloadit on a background thread, processing the response and then calling the completion block on the main thread:
`dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), {() -> Void in
let response = transloadit?.invokeAssembly(assemblyBuilder, withError: error)
// do something with the response
// update your UI on the main thread
dispatch_async(dispatch_get_main_queue(), {() -> Void in
    // update
})

});`

Hey @Asbat @kpavankotesh, I'll be taking a look shortly! Have you used any other SDK with your accounts before?

Hey,
By with your accounts you mean Transloadit account? Answer: None
I am using Facebook SDK in my application.

Yeah that is not an error. My uploads are going through. I just pasted the logs for reference. Do let me know when you release the fix. thanks for the quick response.

@MMasterson I have one more doubt regarding how to read the error message in swift? I am not able to pass an NSError instance to the invokeAssembly(self.assembly, withError: nil) method, for now I am passing nil.
Can you please share a sample code or something so that I can read the error in case it occurs?

@kpavankotesh of course! You should always be to read errors, i'll patch it up for you.


Thank you for your suggestion. In order to speed up the ball query operation, I think it can be achieved by searching neighbour points in the 3d nearby region in ball query module.

Thank you for your suggestion. In order to speed up the ball query operation, I think it can be achieved by searching neighbour points in the 3d nearby region in ball query module.
In detail, using a hash table to store the valid points coordinates (which can get from SpcovTensor.indices), perform O(1) query for each keypoints to check whether there are some valid voxels in the neighbourhood. In this way, O(n) query can be avoid.
What do you think about this idea?
Originally posted by @Chunchunyoyo in https://github.com/open-mmlab/OpenPCDet/issues/208#issuecomment-669049817

Close it due to repeat issue.


Cisco 1142N not reporting negotiation speed correctly

Cisco 1142N:
INFO: Running testScoutGetSpeed()...
 loopback not set
  Keepalive not set
  Full DuplexMbps

Cisco 3602i:
INFO: Running testScoutGetSpeed()...
 100Mbps

https://github.com/cardinal-dev/scout/blob/main/scout/info.py#L52

Configuring 802.1q on gi0 adds encapsulation info when show int gi0 is executed. Another comma (,) is added, which pushes the elements up by 1 (i.e. split(","))
When 802.1q encapsulation isn't configured:
>>> info.scoutGetSpeed("<IP_ADDRESS>", "Cisco", "Cisco")
> /home/user/Development/scout/scout/info.py(54)scoutGetSpeed()
-> sshBandwidth = sshOut.decode('ascii').strip("\n").split(",")
(Pdb) locals()['sshOut'].decode('utf-8').strip("\n").split(",")[9]
' 100Mbps'

It's possible another scout operation is leaving something behind.

I think https://github.com/cardinal-dev/scout/pull/16 should resolve this. Closing this out for now.


Sciter update

Any chance to update this repo for Sciter 4.x?

Sorry, I abandoned programming in D.
So consider this as abandonware, in the hope someone can assume this port!


enhancement in app or readme update

Hi @PorePranav Can you assign this issue to me with Hactoberfest tag, or you can assign any other relevant issue?

Hi @sunny7899.
Could you please elaborate on what changes you wish to propose in the app or README section? It would be helpful for me to understand your ideas better. Also, please take a moment to review Contributing Guidelines to get more context.

I Can do formatting on readme file like this @PorePranav

Thanks for the suggestion, but I don't think I currently need that in README of the repository. If you have any specific issue, feature request or wish to contribute to any specific module, please open a new issue. I will be closing this one.


Autocomplete breaks after one property for an array generic

🔎 Search Terms
array generic
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about generics

⏯ Playground Link
https://www.typescriptlang.org/play?ts=5.4.2#code/C4TwDgpgBAsg9gEwgGwMLIIYFcDOEA8AKgHxQC8UA3gFBR1QDyASgPwBcsiK62eRxAbQC6Ablr0AggDkAIu05I0mXARLCxAXygAyKAAUMAJ2ABLDMn5jqoSFABCGPAEUsEQyCJQIAD2AQAdgg4UDjAhib+AOYANFAAql6+AUFQcABGAFYQAMbApBQ09FAAtlzIHIRiRQCOru7y8Io8KvhxxJpWNtBxeIYubiDk9o4Q-e74AEQ9bhOxlFD+GMUQHKHhUSJQGJErC1jFaW5QGu3W4NB6cKE4Y4MUDs51HhOX17NUUKbAyLtrEZGbbJwfx+EGrML-Y6nM62W5DaZ9J5QAA++iuwBuTysADMsP5ciZgZ8IKF-p4fKCUrdiAAKWoDCrCACUVHEdCB-hwcB+ADpkHBInSnkzNNRqLj8aYiX5SVEAEzkpKBYK3YS0+nuCoswr0Dlc3n8wUakAi6gaMUy0xRGkCNmsopFUqKDhTXqzO01J4cHUOh2LZYuy3u32+gD0oaghHAkO20AAFm5oAB3EzIZBbLDAOBA4pgH5+D0h2McACMAAZC3QNNE7dXqEJTdYSVbInKbXafQ6nSgXQjgyHjd7K36lrsJkGayGHeHI+5PtGolsdlAE4YILETMAoEngQByLfYLM5vMQAtTutFOsNsRAA
💻 Code
type ModelClause<T> = {
    OR?: ModelClause<T>[];
    AND?: ModelClause<T>[];
} & Partial<T>;

type BaseQuery<T extends string, U extends object> = {
    model: T;
    query?: ModelClause<U>;
};

type UserQuery = BaseQuery<"User", { name: string; age: number }>;
type PostsQuery = BaseQuery<"Posts", { title: string; content: string }>;

type Query = UserQuery | PostsQuery;

function testing<T extends Query>(query: T[]) {
    console.log(query);
}

function testing2<T extends Query[]>(query: T) {
    console.log(query);
}

testing([
    {
        model: "User",
        query: {
            name: "test",
            // Typing age here will autocomplete
            age: 10
        },
    },
]);

testing2([
    {
        model: "User",
        query: {
            name: "test",
            // Try typing age here, it won't autocomplete
        },
    },
]);

🙁 Actual behavior
For the testing function, you correctly get suggested fields when filling in the query property.

However, for testing2, the suggestion works for your first property, whichever one you try.

However, once the first one is provided, it will stop autocompleting.

Once one has been provided, you can also list any key, regardless of if it's part of the model.

🙂 Expected behavior
It should correctly suggest all properties and typecheck additional properties and not stop working after the first one.
Additional information about the issue
Some extra context why I'm using the testing2 approach, here's a playground link that shows what I'm trying to achieve.
Basically, I want to make sure that the return value of my function adheres to what was passed in. I haven't found a way to do it with testing, so I went for testing2, which is a decrease in DX since it'll only autocomplete one query parameter.
But the return value is exactly what I want

(for reference for others who would stumble upon this issue, the last as const is important to ensure it returns the correct order, else it will have a type of const returnValue: (UserModel | PostModel)[])

If you don't need to infer queries then this works reasonably well: TS playground

Amazing, this works super smooth! Notice for further readers: the correct typing of the tuple will only work on TypeScript >5.4.
If you would have some spare time, could you explain the differences and why your approach is better?

With a small adjustment you can also make it work with TS 5.3: TS playground

If you would have some spare time, could you explain the differences and why your approach is better?

I think it's better because it gives you a clear way of relating "positional inferences". The query type depends on its own sibling model - you don't even have to create a discriminated union to achieve this. So it's more flexible because you can introduce such dependencies with unknown constraints.
I don't know why the autocompletes work in this particular way on your two first examples. This might be worth investigating or something. I know though that often autocompletes in objects for optional properties etc might stop working in inference contexts. The problem is that the inferred type (like even {}) is already valid at a particular position and TS sees that type there and not the original constraint based on which it was inferred. So there is no source from which those properties could be obtained. There are some internal ways to query those types with different flags so the constraint can actually often be obtained in such positions but not every call site is querying completions from both types (with inference enabled and with inference blocked on the source location).


move tooltip to top left of cursor

Changed some values to move the Tooltip to the top left of the cursor for better visibility

Looks good, thanks


Microsoft Dependency Agent is missing

I don't see Microsoft Dependency Agent in my tenant but it is shown in the first image of the document.
How can I get that option?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 069802b7-9db6-f5d6-b1aa-52ebc42e96f8
Version Independent ID: 7b011f8a-0a1c-5066-5d20-3cedcdfc7403
Content: Auto-deploy agents for Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/enable-data-collection.md
Service: defender-for-cloud
GitHub Login: @memildin
Microsoft Alias: v-ekrieg

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign:ElazarK

Hi @amanmcse . Good that you pointed this issue out! Dependency agent was deprecated from Microsoft Defender for Cloud, as is noted in our latest release notes.
PR #190764 removes references to that product from our docs.

The PR was merged into the docs to remove references to Dependency agent.
#please-close


Spec-compiant ACES workflow for Post-processing

What problem does this solve or what need does it fill?
Currently Bevy has has an sRGB-dependent visually sub-optimal look, this is a barrier to implementation of HDR display support and makes images rendered in bevy look like they are viewed through an old crappy digital camera. There is an ongoing effort at addressing this issue in #6677, however it proposes a very limited approximation of a well known color grading workflow which has visual artifacts and does not completely succeed at creating the desired filmic look.
What solution would you like?
I would like to see an implementation of the ACES workflow in Bevy's tonemapping / post-procesing / rendering system because it solves both problems outlined in this issue using a combination of an intermediary-color space, display-specific transformations and a look modifier that creates the desired filmic effect.
"ACES is a free, open, device-independent color management and image interchange system that can be applied to almost any current or future workflow. It was developed by hundreds of the industry’s top scientists, engineers and end users, working together under the auspices of the Academy of Motion Picture Arts and Sciences" (AMPAS, n.d).
ACES solves Bevy's sRGB dependence with its intermediary ACES 2065-1 color-sapce (also known as ACES AP0). All inputs (in our case just the camera render target) are converted to ACES 2065-1, processed to suit artistic needs, and displayed to the user using an Output Device Transform (ODT) that corresponds to their display type. This step allows any developer / artist to work on any kind of display and be sure that the end user result is going to be perceptually similar to ther artistic intention no matter if they are viewing it on a CRT display or an HDR-enabled TV (as long as the correct ODT is selected).
The filmic look is created by another component of ACES, the Reference Rendering Transform (RRT). The main function of RRT is to adapt the ACES 2065-1 color-space to human eyes for critical color evaluation (AMPAS, 2013, p. 8). Coincidentally, this is achieved by mapping the colors in a way that emulates how the image would have looked had it been captured on film and creates a really pleasant look. RRT is highly regarded in the games industry and is applied by default in Unreal Engine (Brackeys, 2017). Admittedly, RRT is not without criticism (e.g Stout, 2022; Meeting Summaries, 2023), however RRT remains the standard proposed by AMPAS.
#6677 is already proposing an approximation of the look usually achieved by the ACES workflow, however, it does not solve dependence on sRGB, and (subjectively) fails to recreate the famous ACES look.
I would like a solution that implements a transformation to the ACES 2065-1 color-space, optionally (and by default) followed by the RRT, followed by a user / developer selected ODT. That way there are no hard-coded assumptions of an output display type, which opens up possibilities to handle HDR displays and / or unexpected use-cases like VFX rendering for movies, and the desired filmic look is faithfully recreated.
AMPAS offers a reference implementation of most steps outlined above.
What alternative(s) have you considered?

#6677 makes a step in the right direction but it implements an bad approximation of the ACES look and does not implement the ACES workflow in any capacity.
Baking Lab's ACES tonemapper has been proposed by @CptPotato, but it is also an approximation of the ACES look and does not implement the ACES workflow.

This is a solid writeup. I like that there's a clear spec to follow and link to. Your proposals around configurability are good too.

@StarLederer For reference, this is what Baking Lab's implementation looks like with fully saturated colors:

screenshot

GLSL code to generate the test gradient
vec3 hsv2rgb(float hue, float sat, float val) {
    vec3 rgb = clamp(abs(mod(hue * 6.0 + vec3(0.0, 4.0, 2.0), 6.0) - 3.0) - 1.0, 0.0, 1.0);
    return val * mix(vec3(1.0), rgb, sat);
}

vec3 color_test(vec2 uv) {
    const float GREY_SIZE = 1.0 / 10.0;
    const float COL_STEPS = 18.0;
    const float EV_MIN = -6.0;
    const float EV_MAX = 4.0;
    const float EV_DELTA = EV_MAX - EV_MIN;
    const float BLACK = pow(2.0, EV_MIN);

    float hsv_y = uv.y / (1.0 - GREY_SIZE);

    float h = floor(uv.x * COL_STEPS) / COL_STEPS;
    float s = 1.0;
    float v = max(pow(2.0, EV_MIN + hsv_y * EV_DELTA) - BLACK, 0.0);

    vec3 col = hsv2rgb(h, s, v);
    float g = max(pow(2.0, EV_MIN + uv.x * EV_DELTA) - BLACK, 0.0);

    return (uv.y > (1.0 - GREY_SIZE)) ? vec3(g) : col;
}

I`m here to mentioned that it should already be implemented at render time so that the calculations can happen in ACESCG for more accurate results.

I suspect it might be a myth that simply working in ACESCG gives more accurate results though I remember seeing some youtube video that claimed that it did in some rendering software. We should be just limited to the accuracy of floating-point numbers, it shouldn't matter what wavelengths you consider to be your 3 primaries internally, especially when you don't know how well they match with the output device.
The main benefit of my proposal, in my opinion, is effortless HDR support (developers should be able to build supporting graphics without even realizing it), as well as support for future display technology advances.
I must apologize to @CptPotato because I missed that reply from 2023. That implementation looks pretty good, I never said otherwise, but I believe the actual transform developed by AMPAS can be even better because it was developed by collaborating industry experts, however I agree that this is probably not critical. What I do think is critical is that the BakingLab transform assumes an sRGB output device and will look really bad simply stretched onto an HDR display. I tried finding a source but I am unable to, there was a 3kliksphillip video about CS2, when it just came out, that mentioned that it supported HDR but, when enabled, looked so bad that he could not imagine anyone playing with it. I cannot claim that this is because of any specific mistake in internal logic as we don't have access to the source (haha, pun), but this is definitely an example of how the user feels when HDR is not done properly.


Implement test case and CI

Implement a test case for each example and setup on CI

Include linting, black etc


RFC/PREP: Allow a load-balancer address for k8s API

Extends the RancherKubernetesEngineConfig (cluster.yml) type to support the configuration of an API load-balancer.
This is a pre-requisite for an upcoming PR to extend RKE to support such a configuration.
to-do:

[ ] update and document design in accordance w/ feedback from #1348

--
This optional string is to replace the hostname used by other nodes and
configurations when attempting contacting the k8s API service.
It is expected to be the hostname of a layer-4 (TCP) load-balancer which
will be externally configured by the organisation to direct traffic to
an appropriate selection of the cluster's ControlPlane nodes on the same
port as it arrived; i.e. TCP/6443 for kube-apiserver.
Any TLS configuration and healthchecks on the load-balancer host are
also expected to be managed by the organisation.

The design for a solution for this has been posted at https://github.com/rancher/rke/pull/1348#issuecomment-527900505 and will be put in a final design soon that can be worked on. Is this taken into account or is this an implementation that you thought of? And is that design described somewhere?

Need to regenerate the built code but the build seems to be failing here due to our intercepting proxy; will continue from home.

@superseb I didn't see that PR in my search, this is based on our current need

I like most of the suggested design there, I'll adapt and extend and update this PR.

There is now accepted design yet, I just opened https://github.com/rancher/rke/issues/1682, will have it reviewed and we can work from there.


Trying to render an HTML file inside the Frame component

Hey,
I have tried this component and it works very well with YouTube links but I am trying to embed an HTML file that contains animation inside React using this component but it doesn't work as expected. Does anyone have any recommendations to overcome it?

Hi, I have the same question here

Same issues here. I'm trying to render html banners inside react components as iFrames, but it just renders the actual react app instead.

Аналогичная проблема

I am encountering the same problem right now

+1 :(

Hey. I'm sorry, I did not see your comment. If I can help you write me an
email. I will be happy to help you.
PS I found a solution to the problem.
чт, 10 окт. 2019 г. в 19:55, Lee-Roy King<EMAIL_ADDRESS>
+1 :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/svenanders/react-iframe/issues/55?email_source=notifications&email_token=AJOL564G2UO2XNV5P244F73QN5NARA5CNFSM4HN5QHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5BLDQ#issuecomment-540677518,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJOL564PKVXBKUHBE3VULJ3QN5NARANCNFSM4HN5QHSA
.


Dark to Light Theme Issue

Overview
When switching from Dark to Light theme or vice versa, there are elements of the page that flash the opposite color that the page is changing to. For example, if you're going from Dark to Light mode, parts of the page will flash black.
References and additional details

go to app.shapeshift.com
go in with your wallet of choice.
click on the settings tab in the bottom left hand corner of the page.
within the settings widget, toggle the page from dark to light or light to dark.
observe the flashes of color when switching themes.

Acceptance Criteria
The page shouldn't flash colors when switching themes. It should be a smooth dissolve from dark to light theme or vice versa.
Need By Date
No response
Screenshots/Mockups
https://user-images.githubusercontent.com/99363597/162019597-bedba4a4-5fcc-46d3-9ca6-53720b0979ff.mp4
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

This is not necessarily a bug. The browser needs to re-render the screen so it will appear to flash.

as per product i'm closing this as wont fix


Is there a way to use the i18n in server-side for example  in getServerSideProps

Hi, we can use the t function after wrapping with withTranslation inside react components.
I want to take some translations from the server side in my use case in the funciton
export const getServerSideProps: GetServerSideProps<ServerProps> = withSession(async ({ locale, req, query }) => {
// I can get the translations props as documented in line below but don't know if can use or how with i18n (TFunction) here
const translations = await serverSideTranslations(locale || DEFAULT_LOCALE, tNamespaces);
// here i want to do something like t('someTranslationKey')

return {
...translations,
magicObject: {
   superTitle: t('key', { name: 'tony'}),
}
}
}

I checked briefly the source code of this lib and see it exports only hooks, and inside uses import createClient from './createClient'  then creates the instance.
Would be great to be possible use the translation mechanisms anywhere not just inside react components (with hooks).
You have a nice system already with translations and client interface can benefit in server work as well while preparing the props, static html etc. Main reason is that we want to avoid injecting in window nextdata object data we don't need and reduce returned html size.
So to achieve that can translate in server side and prune the returned props to the react component
Trying to summarize shortly, I would like to get a t instance somehow by initializing it through the result of await serverSideTranslations(locale || DEFAULT_LOCALE, tNamespaces);
then use the t function as we use it inside the react components.

I am trying something like this without success
somenextpage.tsx

export const getServerSideProps: GetServerSideProps<ServerProps> = withSession(async ({ locale, req, query }) => {

const translations = await serverSideTranslations(locale || DEFAULT_LOCALE, tNamespaces);

const internalConfig = createConfig(translations._nextI18Next.userConfig!);
const t = await createClient(internalConfig).initPromise();

return {
      ...translations,
      magicObject: {
         superTitle: t('key', { name: 'tony'}),
      }
 }

}

This already exists:
import { i18n } from 'next-i18next'

// Anywhere you want
i18n.t('my-key')

I tried that initially and was getting
TypeError: Cannot read property 't' of null

so in my getServerSideProps
i18n} from 'next-i18next';
is null

I hacked some super ugly code that seem to work but of course want to use the official best practice solution for this lib.
This works
getServerSideT.ts
import { CreateClientReturn, SSRConfig } from 'next-i18next';
// @ts-ignore
import { createConfig } from 'next-i18next/dist/commonjs/config/createConfig';
// @ts-ignore
import { default as createClient } from 'next-i18next/dist/commonjs/createClient/node';
import { TFunction } from 'i18next';

export default async function getServerSideT(config: SSRConfig): Promise<TFunction> {
    const internalConfig = createConfig({
        ...config._nextI18Next.userConfig,
        lng: config._nextI18Next.initialLocale,
    });
    const r: CreateClientReturn = await createClient(internalConfig);
    // @ts-ignore
    return await r.i18n.init(r.initPromise);
}

then in mypage.tsx
export const getServerSideProps: GetServerSideProps<ServerProps> = withSession(async ({ locale, req, query }) => {
    const i18nSSRConfig = await serverSideTranslations(locale || DEFAULT_LOCALE,['common', 'mypage']);
    // @ts-ignore
    const t = await getServerSideT(i18nSSRConfig);

    const title = t('mypage:title');

    return {
         ......i18nSSRConfig,
        magicData: {
            title
        }
    }
}

@kristijorgji The global i18n instance is not initialised until serverSideTranslations is invoked. If you want to use it during SSR, you do indeed need to await the initPromise.
Not sure I understand what you are trying to achieve here. Why go to all this trouble to just manually pass the exact same data as props?

Yes sure I can try to explain again hopefully clearer this time with a fictional example to tell the point.
Let us assume we have 512 blog posts rendered at once.
Normally nextjs injects into the returned html document, somewhere under __NEXT_DATA the props for the react hydration.
Then some values inside a particular prop for every post are used to prepare translations based on locale (maybe category name or something else).
So one category object might have id name and more stuff inside.
Idea is if we translate in server side and return as props to react only fields that will be rendered to html, we reduced actually amount of returned html size by 40% which is fantastic as we don't inject props that are not needed for hydration.
(we tested by hardcoding the translations initially in server side to make the poc)
That is the idea in general, we can prepare data in server because props we return in getserversideprops or getstaticprops will be hydrated and inejcted in html so need be careful what we return there, need prepare only exactly what is needed to keep the file size lower

ps:
atm the solution i wrote above is working great tested wtih different languages managed to achieve the desired result of translating from server side.
Will try one more time the public api
i18n.t('my-key')

after initialising
const i18nSSRConfig = await serverSideTranslations(locale || DEFAULT_LOCALE,['common', 'mypage']);

Just want to make sure that on new versions of this library prev code works fine and am not missing something

Got it, makes sense. The global i18n instance is specifically exposed for these type of use cases, so yes, I would recommend using it if possible.
There do seem to be more and more cases where users want to consume createClient manually, so perhaps we can also consider exporting that for first-class usage.

@kristijorgji I have used your solution. Thanks for that!
I was wondering if you found a better way?
Thanks!

@isaachinman Could you have another look at this?

@kristijorgji The global i18n instance is not initialised until serverSideTranslations is invoked. If you want to use it during SSR, you do indeed need to await the initPromise.

This doesn't seem to be the case. Even after awaiting the serverSideTranslations method, the global i18n instance is still null. Since serverSideTranslations internally already creates an i18n instance, I think that instance should either get assigned to the global one or exported separately.
The workaround from @kristijorgji does work, but it feels very hacky and creates a second instance, which would not be needed if we could access the instance from serverSideTranslations.
(I needed to get SEO related texts in getServerSideProps, and as I see it, the only way to get them is using the aforementioned workaround)

@isaachinman Does next-i18next support translations in /api routes or is it recommended use another ´i18nextclient for api? Runningawait serverSideTranslationsbeforei18n only works if a react page (_app.jsx`) has been visited first.

i18n?.t('my-key') || ''
i18n?.t('my-key') || 'defaultValue'

Hello, there's an update. I would like to catch translations from the GQL server and then insert them directly into the i18n instance, but there may be a situation where it is null?


Slow builds for larger resources embedded in code

Description
As suggested in the PR, Resource.embedInCode(_:) appears to be inefficient for larger resources.
For a minimal .executableTarget with a 165 KB resource to be embedded, the debug build takes some 200 seconds on my machine. 19 seconds for the release build.
Expected behavior
No response
Actual behavior
No response
Steps to reproduce
No response
Swift Package Manager version/commit hash
No response
Swift & OS version (output of swift --version ; uname -a)
No response

I read somewhere that clang implemented the C #embed using a special builtin instead of generating files with huge arrays.
Could Swift also do the same thing? Turning a 9 MB resource into a 30 MB generated file that then needs to be parsed and type-checked doesn't seem ideal.

Rather than introduce a new language extension, the compiler could just flag during parsing "I have seen that all of these are byte constants" as an annotation, and proceed without the type resolver.

Is there any progress on this? I keep trying to use this feature only to find out it's basically unusable. I really want to use this!


Adding a Graph of New Entities

After a cursory look at the open issues, it does not look like this one has been submitted.
I have a simple model consisting of Book and Author objects.  There is a many-to-many relationship between these objects.  Author objects contain a collection of Book objects and properties for Id, FirstName, and LastName, all of which are required.
I am attempting to add a graph consisting of one Book (book1) object and two associated Author objects (author1 and author2) that are all new entities.
If I issue the commands:
context.UpdateGraph(book1, m => m.OwnedCollection(e => e.Authors));
context.SaveChanges();
...then no errors are generated and the resultant records are what I would expect.
The problem is that my understanding is that I should use AssociatedCollection instead of OwnedCollection as the relationship is many-to-many.
If I issue the commands:
context.UpdateGraph(book1, m => m.AssociatedCollection(e => e.Authors));
context.SaveChanges();
...then validation exceptions are thrown stating that the values for the properties FirstName and LastName (of the Author objects) are invalid (they are null).  I can verify that this is true by inspecting the entities in the change tracker of the context.
Is this really an issue or is this expected behavior?  If the latter, why do I need to use OwnedCollection instead of AssociatedCollection when my understanding was that I needed to or should use the latter?
Lastly, I have a sample project demonstrating this issue that I can package up and send if need be.

This would be a very useful feature! (And is actually just what I assumed would happen by default)
I'm currently building a web scraper and can't know the order entities will be scraped. Thus I would like to be able to call UpdateGraph without having to worry about if an entity already exists or not.
Side note, the AssociatedCollection functionally mentioned here ("GraphDiff simply assumes that the associated entity already exists and does not attempt to manage its contents.") doesn't seem to be documented anywhere besides here.


Update chromium-chronicle-1.md

What's changed, or what was fixed?
Replacing ScopedTaskEnvironment with its new name, TaskEnvironment.
Also updating the hyper-link on "RunUntilIdle() with care"
What's changed, or what was fixed?
Target Live Date: 2019-09-24

[ ] This has been reviewed and approved by (NAME)
[ ] I have run npm test locally and all tests pass.
[ ] I have added the appropriate type-something label.
[ ] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2019/04/chromium-chronicle-1.md#L5 - WF Tag 'wf_updated_on' must be within the last 7 days.

:+1:

:tada: This has been pushed live to https://developers.google.com/web/


[FR] Selectionmarks

Includes additions to:

As type in FormField
As a list on FormPage
As an element type on FieldData/FormTableCell - requires parsing the json pointer
Mocking
Tests
Samples
Documentation

Fixes: https://github.com/Azure/azure-sdk-for-net/issues/14816
Making it draft until I get green light to share the files for training/test selection mark
Test are disabled until we can upload the file here. I created issue https://github.com/Azure/azure-sdk-for-net/issues/15495 to track that

/azp run net - formrecognizer - tests

/azp run net - formrecognizer - tests


Error description message in Marketo plugin

I notice that the description message in Marketo configuration shows an example with "https"
However the backend code also append a https to the front.

Thanks @DavidAtWorking! I'll fix this one up quick unless you have a PR ready :-D


[Runtime] Fix Can't "query_imports" Bug of VM Executable

This "LOG(FATAL)" will error out when the function isn't found in “executable”, so it will prevent the recursive query the function in the imported modules of "executable".
For example, if the module hierarchy is something like below.
executable
|---LLVMModuleNode
|___NPUModuleNode
This bug will cause we can't get the function in NPUModuleNode by the call "executalbe.get_function("npu_func1", query_imports=True)".
From Arm China.

@junrushao @Hzfengsy @tqchen Please help to review, this is so little bug fix, thanks.

The PR looks good to me. Retriggering CI


[Other packages] Upgrade 3rd party dependencies

Upgraded 3rd party dependencies for:

create-sitecore-jss
sitecore-jss-cli
sitecore-jss-forms
sitecore-jss-dev-tools
sitecore-jss-proxy
sitecore-jss-rendering-host

Description / Motivation

Testing Details

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Good work on upgrades! Please, see my comments below And I wanna ask you to provide reasons (add them to the description of PR) why some primary and vulnerable dependencies were not upgraded, like:

[sitecore-jss-rendering-host] webpack-dev-server
etc. if something else is skipped

Most of the packages which are not upgraded or not upgraded to the latest version is because they migrated to ESM and don't support CJS or were incompatible with other dependency versions some of them are chalk, inquirer url-join`.
For http-proxy-middleware it was incompatibility with its types dependency @types/http-proxy-middleware'. I got various build errors in the definition files. Similarly for web-dev-serverafter upgrading it to latest it doesn't adjust well with the way ourdevServer.ts file is setup for e.g the here WebpackDevMiddleware.Options complains that it requires 2 arguments but typescript doesn't like it when provided the asked arguments.(Also refer to the comment above that line)


I would like to know about the parameters during training.

About video_resolution_buckets.
It defaults to 49x512x768, but I think the order is frames, height, width.
Is there an upper limit for frames, height, and width?
https://huggingface.co/Lightricks/LTX-Video
The LTX formula says num_frames=161,fps=24.
In this case, frames is up to 161, but I think I could specify fps when using factory, but internally, 1 second is trained as 24 fps?
I know that each model has a different input dimension.
It's a long story, but I only have one question.
How do I know how far I can set the value of video_resolution_buckets as an upper limit in training HunyuanVideo or LTX-VIDEO?
Translated with DeepL.com (free version)

I don't think we have a validation method to check for that. Perhaps, we could add some guidelines about how to set that parameter in the README. Would that help? Cc: @a-r-r-o-w

Is there an upper limit for frames, height, and width?

Yes, it is the same as the original repository: 257 frames, 720 height, 1280 width. But Diffusers does not yet have framewise encoding/decoding supported in the VAE, so I doubt if one could reach upto 257 frames for finetuning even on an 80GB card. I will look into this soon.

In this case, frames is up to 161, but I think I could specify fps when using factory, but internally, 1 second is trained as 24 fps?

We don't actually support training with the frame_rate parameter yet. I've hardcoded this to 24 for the moment. It should be easy enough to support, but it would help to have a training run where this works as expected and doesn't cause terrible results. I will try and work on it this weekend.

How do I know how far I can set the value of video_resolution_buckets as an upper limit in training HunyuanVideo or LTX-VIDEO?

Whatever the upper limit is specified in the original repository, the same is supported here because we rely on the Diffusers implementations (which are exact matches numerically to the original code). However, we are still working on optimizing memory requirements so it will take some more time before < 24 GB for higher resolution training is possible

Thank you. I roughly understand.
As sayakpaul mentioned, video_resolution_buckets can be complex, so I think having user guidelines would make it easier to understand.


Migrate disclosure docs

Migrate disclosure docs ➕ ➖

A side thing that is not related to the code. Personally, I wonder if there is a way to visually distinguish or separate the example disclosure (Filter) from the code disclosures (HTML code, ERB code) as they are the same component:

Probably a question for James.

A side thing that is not related to the code. Personally, I wonder if there is a way to visually distinguish or separate the example disclosure (Filter) from the code disclosures (HTML code, ERB code) as they are the same component:

Yeah we should ask James. I originally added borders around the controls but we removed those in https://github.com/citizensadvice/design-system/pull/2153 to match the original designs, but we should revisit that as it does look weird here.

This is what I had originally for context:


install.sh: fix $QUIET + add $FLD_TRG check

fix $QUIET value: bash doesn't have booleans;
add additional safety-check for $FLD_TRG;

sorry for the late reply. I will merge this, thank you. But i am currently creating a new installition method with make that will also install the man pages, and make it easier to distribute i3ass as a package. But this old install.sh can still be nice to have for those who want to keep stuff local.


Fix KeyError when using OpenAPI v3 specification

In v3, the parameters doesn't have a 'type' resulting in this error:
File "sphinxcontrib/openapi.py", line 94, in _httpresource
yield indent + ':param {type} {name}:'.format(**param)
KeyError: 'type'
This change adds partial OpenAPI v3 support by adding a default
'string' type in the _normalize_spec function.

@TristanCacqueray thanks for the PR! I'm not sure that this is the best way to support v3 as there might be other issues. I'll take a look at changes done in OpenAPI v3 once I got some time.

hi! thanks for this project. looks super cool and I'm keen to try it out. How much work would be involved in supporting openAPI v3? I'd be happy to look into this, if it's something you are still interested in

@amn41 sorry for the later reply. I'm sorry I cannot find enough time to implement OpenAPI v3 support  right now. If someone can take a look and implement v3 support, this would be super cool!

In v3, the parameters has a 'type', it is in schema key.
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#parameter-object-examples
When I try sphinxcontrib-openapi I will adapt it for my openapi.yml file. And I didn't check if a MR already exists. I also create a pull request: https://github.com/ikalnytskyi/sphinxcontrib-openapi/pull/19

Closed in favour of #22.

@TristanCacqueray I plan to cut a new release over a weekend. Just want to make more tests first. :)

Thanks, that's appreciated :-)


Using MathJax with TinyMCE to render formulas

TinyMCE is blocking MathJax rendering function. Passing formulas from TinyMCE saved content to iFrame these are transformed in plain text

RAJE now can render SVG based formulas (formulas need to be stored in MathML anyway)


Plugin enters crash loop when String light is auto discovered

Describe The Bug:
When a Lifx String Light is present on the network and auto discovery is turned on, the plugin (running in a child bridge) enters a crash loop.
When auto discovery is turned off, the crash loop stops.
Even once auto discovery is turned off, the plugin is now not able to control my existing bulbs that were working prior to adding the string lights. This happens even when removing the new lights from the accessory cache.
To Reproduce:
Set up one of the new string lights on the network
Expected behavior:
Even if not able to control the string light, it shouldn't crash
Logs:
[homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Manufacturer': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info.
[homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Model': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info.
TypeError: Cannot read properties of undefined (reading 'color')
    at Bulb.hasColors (/usr/lib/node_modules/homebridge-lifx-plugin/src/bulb.ts:60:47)
    at LifxPlatformAccessory.bindFunctions (/usr/lib/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:70:19)
    at /usr/lib/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:25:12
    at /usr/lib/node_modules/homebridge-lifx-plugin/src/bulb.ts:29:11
    at /usr/lib/node_modules/homebridge-lifx-plugin/src/bulb.ts:90:7
    at /usr/lib/node_modules/homebridge-lifx-plugin/src/bulb.ts:125:7
    at Client.<anonymous> (/usr/lib/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/light.js:218:5)
    at Client.<anonymous> (/usr/lib/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:428:26)
    at Array.forEach (<anonymous>)
    at Client.processMessageHandlers (/usr/lib/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:414:24)
[Lifx Plugin] Child bridge process ended
[Lifx Plugin] Process Ended. Code: 1, Signal: null

Plugin Config:
        {
            "name": "Lifx Plugin",
            "duration": 0,
            "brightnessDuration": 300,
            "colorDuration": 300,
            "default": "<IP_ADDRESS>",
            "broadcast": "<IP_ADDRESS>",
            "lightOfflineTolerance": 3,
            "messageHandlerTimeout": 45000,
            "resendPacketDelay": 150,
            "resendMaxTimes": 3,
            "updates": true,
            "debug": false,
            "autoDiscover": false,
            "_bridge": {
                "username": "...",
                "port": 37047
            },
            "platform": "LifxPlugin"
        },

Environment:

Plugin Version: v0.3.0
Homebridge Version: 1.7.0
Node.js Version: 18.6.0
NPM Version: 9.5.1
Operating System: Raspbian

I am also experiencing the same bug, causing the plugin to enter a crash loop. But I am experiencing it regardless of whether auto-discover is on or off. I am also not sure if it is the String light that causes it, because I added my string light to the exclusion list and it still crashes.
Log
[5/19/2024, 11:13:06 AM] [homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Manufacturer': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info. [5/19/2024, 11:13:06 AM] [homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Model': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info. [5/19/2024, 11:13:07 AM] TypeError: Cannot read properties of undefined (reading 'color')     at Bulb.hasColors (/homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:60:47)     at LifxPlatformAccessory.bindFunctions (/homebridge/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:70:19)     at /homebridge/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:25:12     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:29:11     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:90:7     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:125:7     at Client.<anonymous> (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/light.js:218:5)     at Client.<anonymous> (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:428:26)     at Array.forEach (<anonymous>)     at Client.processMessageHandlers (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:414:24) [5/19/2024, 11:13:07 AM] [homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Manufacturer': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info. [5/19/2024, 11:13:07 AM] [homebridge-lifx-plugin] This plugin generated a warning from the characteristic 'Model': characteristic value expected string and received undefined. See https://homebridge.io/w/JtMGR for more info. [5/19/2024, 11:13:07 AM] TypeError: Cannot read properties of undefined (reading 'color')     at Bulb.hasColors (/homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:60:47)     at LifxPlatformAccessory.bindFunctions (/homebridge/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:70:19)     at /homebridge/node_modules/homebridge-lifx-plugin/src/platformAccessory.ts:25:12     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:29:11     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:90:7     at /homebridge/node_modules/homebridge-lifx-plugin/src/bulb.ts:125:7     at Client.<anonymous> (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/light.js:218:5)     at Client.<anonymous> (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:428:26)     at Array.forEach (<anonymous>)     at Client.processMessageHandlers (/homebridge/node_modules/homebridge-lifx-plugin/node_modules/lifx-lan-client/src/lifx/client.js:414:24) [5/19/2024, 11:13:07 AM] Got SIGTERM, shutting down Homebridge...
Plugin Config
{     "name": "LIFX",     "duration": 0,     "brightnessDuration": 300,     "colorDuration": 300,     "default": "<IP_ADDRESS>",     "broadcast": "<IP_ADDRESS>",     "lightOfflineTolerance": 3,     "messageHandlerTimeout": 45000,     "resendPacketDelay": 150,     "resendMaxTimes": 3,     "updates": true,     "debug": false,     "autoDiscover": false,     "bulbs": [         {             "name": "LIFX Mini Bed",             "address": "xxx.xxx.xx.29"         },         {             "name": "LIFX Mini 2 Bed",             "address": "xxx.xxx.xx.38"         },         {             "name": "Study North",             "address": "xxx.xxx.xx.40"         },         {             "name": "Study South",             "address": "xxx.xxx.xx.47"         },         {             "name": "Living Room LIFX",             "address": "xxx.xxx.xx.21"         }     ],     "excludes": [         {             "name": "LIFX Bedhead",             "address": "xxx.xxx.xx.20",             "id": "xxxREDACTEDxxx"         }     ],     "platform": "LifxPlugin" }
Environment:
Plugin Version: v0.3.0
Homebridge Version: 1.8.2
Node.js Version: v20.12.2

I've experienced the same problem on a new A21 Bulb (with matter). I think these new lights have a different color setting which is causing the plugin to crash. It'll probably need updating to support the new lights.

Same issue here, first time trying to use the plugin (after 90% of my lights stopped working natively with HomeKit). We have around 50 DL plus a couple Clean bulb and 8 switches. Each of these don’t appear to have native support at this stage. Any help on this would be appreciated, keen to get Home back working again, also with Adaptive Lighting ;-)
Probably also the DLs being the culprit, I excluded the switches but didn’t solve that.. with 50 DLs probably too time consuming to exclude them all to also rule out the Clean bulbs.

In the meantime, got the crashing to stop by turning off auto-discover. Then, got the rest of the bulbs working by manually adding them one by one by IP address. That hadn't worked previously, but a full reset and re-add of the bulbs seems to have fixed the older bulbs.
Will likely take a plugin update to stop crashing with the new color options for the new bulbs, though.


Changes no-unused-expressions lint from warning to error

Build crashes whenever JSX is not returned as proposed here: #2303.
The build crashes whenever JSX isn't returned, as opposed to just giving a warning.

To test:
Create a stateless component without a return clause.
For example:
 import React from 'react';
export default function Logo(){

Welcome to React

}

I’m going to come back to this after we’re ready to cut over to 2.0 (with some other breaking changes). Thanks!

It'd be great if you considered adding allowTaggedTemplates: true if accepting this PR. See motivation in https://github.com/eslint/eslint/issues/7632.
Without allowTaggedTemplates: true, things like this will cause an error, which is definitely not wanted:
import { injectGlobal } from 'styled-components';

injectGlobal`
  body {
    background: #f00,
  }
`;


Command card action alignment ( UI / MUI )

Describe the bug
Command cards do not have the same size which causes card actions ( buttons ) in a row not to be aligned with other card actions
To Reproduce
Steps to reproduce the behavior:

Go to the main page
Click on sidebar
Click on commands

Expected behavior
Card actions should align themselves to the end of the command card component
Screenshots
Current UI :

Excepted UI :

[ x ] I will fix this issue and create a PR

@gbowne1 Hi assign this to me, I have already completed this task. I will wait for your assignment and then create a pull request, thanks , skyDe

@Sky-De
Ok.


adding gchid, a useful shorthand to change user.name and user.email

I did this because I have this issue with multiple git identities on many projects between work, personal life and side projects so I needed this shorthand. I think this would be useful to someone else. So.

I think this is a good start, but not ready enough for widespread use as an identity management system. It's perfectly fine for personal use though, but I'd like a more automated process before considering merging this.
I'm talking about some sort of git profile management system where you specify which user.name and user.email corresponds to a given profile (like work or personal or whatever), and then call a function to set that profile (e.g. gchid work).
Another option would be to wrap the git commit command or alias such that you can easily use it with the --author argument set to whatever you like:

--author=
Override the commit author. Specify an explicit author using the standard A U Thor<EMAIL_ADDRESS>format. Otherwise <author> is assumed to be a pattern and is used to search for an existing commit by that author (i.e. rev-list --all -i --author=<author>); the commit author is then copied from the first such commit found.

Some other methods could be some sort of git-hook system like in this post, or setting up different .gitconfig files and managing those.
I think there is some hidden potential that we can tap into for a more straightforward way to switch identities, which possibly would become an entirely new plugin. I understand if you don't want to take on that much work, but as is now I'm not very inclined to pull this in. Thanks!

@mcornella this is how a PR should be commented, thanks :+1:
I totally agree. To be honest, I was already thinking about expanding this with a complete identity management framework; I'm writing a bit of this in these days, let's see if I can put together some proper code :D


Typo in folder when downloading from HB appstore

You forgot the n in wiiu/environments/aroma/plugins/GiveMiiYouTube.wps

Should be fixed now, thank you! (Also for future notice, this kind of issue fits more on the hb-appstore repo).


Document .env

Also document quirks in the .env implementation, like spaces not being supported in unquoted env vars: https://github.com/foundry-rs/foundry/issues/2610

Hi, maintainer of the dotenvy crate here, the maintained fork of the dotenv crate.
Feel free to document quirks and open issues over there!

Opened up an issue here: https://github.com/allan2/dotenvy/issues/11


[Operator] unravel_index and ravel_multi_index

As requested by @fhieber, we should consider to support unravel_index and it's inverse function ravel_multi_index in numpy. This feature is recently added to TF (https://github.com/tensorflow/tensorflow/pull/14895).

working on it


How can I extract the model checkpoints?

I am currently using:
import sys
import os
import pkgutil
import pkg_resources

egg_path = '/path/to/downloaded/checkpoint.egg'
sys.path.insert(0, egg_path)
try:
    import checkpoint
    print(dir(checkpoint))
    print(checkpoint.__path__)

    # Iterate through all modules in the checkpoint package
    for importer, modname, ispkg in pkgutil.iter_modules(checkpoint.__path__):
        print(f"Module: {modname}, Is Package: {ispkg}")

    # Directly list the directory content using os.listdir
    for path in checkpoint.__path__:
        print(f"Contents of {path}:")
        subdirectories = os.listdir(path)
        print(subdirectories)

        # Iterate over each subdirectory and list its contents
        for subdirectory in subdirectories:
            sub_path = os.path.join(path, subdirectory)
            if os.path.isdir(sub_path):
                print(f"Contents of {sub_path}:")
                print(os.listdir(sub_path))
            else:
                print(f"{sub_path} is not a directory.")

except ImportError as e:
    print(f"Error importing from egg: {e}")

Above code gives me:
  import pkg_resources
['__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__']
_NamespacePath(['meta-transformer-amc/checkpoint'])
Contents of meta-transformer-amc/checkpoint:
['unseen', 'learning', 'size']
Contents of meta-transformer-amc/checkpoint/unseen:
[]
Contents of meta-transformer-amc/checkpoint/learning:
[]
Contents of meta-transformer-amc/checkpoint/size:
[]

I cannot see any content?

Have the issues been resolved? If not, I recommend re-downloading the dataset and adding code to check if the .tar files exist within each directory to verify their presence.


what is the adc-api-optional attribute in x-airr for the extension fields in ADC API?

The extension fields in ADC API has adc-api-optional attribute in x-airr. This attribute is not defined in the AIRR extension properties in the documentation. Is it new? What does it mean?

adc-api-optional seems entirely redundant with adc-query_support as they always appear in pairs as:

adc-api-optional was intended to capture fields that are part of the ADC API and not part of the spec. See those fun discussions back when...
https://github.com/airr-community/airr-standards/issues/258
I have fixed the:

Also, the field should be adc-query-support (no underscores).
problem.

If we want to revisit the adc-api-optional use and its existence, that would definitely be a 2.0 issue. It certainly can't be resolved in the next two weeks.

With that said, it looks to me like in airr-schema.yaml, we have a bunch of fields in the Cell object that has a mix of  adc-api-optional = true and adc-query-support=false which seems odd to me.
adc-query_support marks fields that the ADC requires repositories to provide a search capability. The fields in Cell that have adc-api-optional = true are not ADC API optional, they are not required to be searchable.

I suspect that adc-api-optional=true was added to the spec for Cell and Receptor fields by mistake, these should have been adc-query-support=true
I have made a commit that makes these changes @bussec can you have a look.
https://github.com/airr-community/airr-standards/commit/7e763ff301b397332ce659cd270de27bae4393ef
This seems to make more sense to me, and with these changes there are no longer any adc-api-optional fields in the AIRR spec files, only the ADC API files.

@bussec I think if you are OK with the changes to Cell and Receptor objects then we can move this to the ADC v2.0 milestone.

adc-api-optional was intended to capture fields that are part of the ADC API and not part of the spec. See those fun discussions back when...

Ah, okay, adding a entry with what you say in the extension table in the docs should be sufficient to close this issue then.

Docs updated...

Moving this to v2.0 - consider whether we need the adc-api-optional attribute still

@bcorrie I am ok with moving the changes to v2.0, but I am a bit confused, as they now seem to be part of PR #700 with is a v1.5 Milestone (or at least #699 is)...

Moving the adc-api-optional to the ADC spec, and changing all adc-api-optional fields to adc-query-support I think we want to be v1.5. I think most of these were incorrect use of adc-api-optional when the Cell and Receptor objects were created.
The discussion that we will have in v2.0 is around getting rid of adc-api-optional all together.

Ahh... ok, fine with me!

Ahh... ok, fine with me!


💬 comment replies are shown, indented, nested, and counted

[ ] for now, the reply button should spawn a random reply comment
[ ] each "level" of reply comments should be indented deeper
[ ] the root-comments should show a count of all child comments, direct and indirect

enhanced this ticket to include the actual rendering of child comments

mislicked the close button -- reopening