serial communication error in master-slave configuration

My 2 SmartEVSEs are configured in a Master-Slave configuration with a sensorbox connected on the bus.
When the slave charger is in negotiation with the car just after connecting the charging cable both SmartEVSE start flashing "ERROR NO SERIAL COMM CHECK WIRING" and both chargers stop. complete power cycle of both is needed to restore the fuctionality: sometimes it takes 2-3 times before it works again. So far this only happened while connecting slave one, connecting master one seems to work OK.
I am suspecting that slave evse is trying to communicate with sensorbox directly instead of getting data from master which could be causing the problem (in the past I ran in a kind of similar problem while trying to change mode directly on slave via API or connected button to set it to a different one that master: apparently in master-slave mode this should be done on master only - which then sets same mode on slave )
Not sure how can I debug this further ? (the http://smartevse/settings only shows "Communications error", error number: 2)
This started happening with 1.6.5 release (previously I was using 1.4.6 for a long time ... so not sure when the problem really could have started ?):

Upgrade to latest version before posting bug reports
If you flash firmware.debug.bin you can telnet to your smartevse device to see what is going on on your modbus.

EDIT:
Your first post mentioned version 1.5.6, now it says 1.6.5?

Yes, made a typo it is 1.6.5

Ok, try to makea telnet log and post that here, since I only have 1 SmartEVSE I cannot reproduce your problem.
Are you sure none of the SmartEVSE's are configured to EM_API?
A structured method is to pick a release, test if it has the problem, go up or down a few releases, until you localized the release that introduces the problem.

OK, thanks for info, will do that (will take some time .. need to discharge cars in mean time :-))

Here is what I see when the communications error occur:
on master:
D) (ModbusSend8)(C0) Sent packet(ModbusDecode)(C0) Received packet(ModbusDecode)(C0) Invalid modbus FC=04 packet
(D) (Timer100ms)(C0) ModbusRequest 3: Request MainsMeter Measurement
(D) (ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(MBhandleError)(C0) Error response: E0 - Timeout, address: 0a, function: 04, reg: 0000.
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Response
(D) (ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(Timer100ms)(C0) ModbusRequest 22: Request MainsMeter Import Active Energy Measurement
(D) (ModbusSend8)(C0) Sent packet(ModbusDecode)(C0) Received packet(ModbusDecode)(C0) Invalid modbus FC=04 packet
(D) (Timer100ms)(C0) ModbusRequest 3: Request MainsMeter Measurement
(D) (ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(MBhandleError)(C0) Error response: E0 - Timeout, address: 0a, function: 04, reg: 0000.
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Response
(D) (ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(ModbusSend8)(C0) Sent packet(Timer100ms)(C0) ModbusRequest 22: Request MainsMeter Import Active Energy Measurement

on slave:
loop)(C1) 0 clients running.
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Response
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Response
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0) Invalid modbus FC=04 packet
(D) (ModbusDecode)(C0) Received packet(ModbusDecode)(C0)  Request

I am not sure if this  "FC=04 packet" message is correlated to the error, it also appears when no communication errors are reported .. the difference being that master reports while no errors this:
MBhandleError)(C0) Error response: E0 - Timeout, address: 09, function: 10, reg: 0020.

Looks like in error state the reply from Sensorbox for 'ModbusRequest 3: Request MainsMeter Measurement' is not received or processed ?
logs are from 1.6.5, I have tried <IP_ADDRESS> / 1.6.3 and 1.6.4 versions - all show this error.
Sometimes the communication error goes away by itself after few minutes, but few times I had to reboot both evses to get it cleared.
EV meter is set to disabled on both (and I think it should not appear in menu on the slave: MainsMeter is hidden when evse is set to slave as all settings are imposed by master).
I will try 1.5.5 next.

Ok great work; anxious to learn what release introduces the problem!

1.5.5 seems to work correctly for me, I havent seen the error after multiple car (dis)connects, mode changes .. etc.
therefore - would that be introduction of the TCP Modbus bridge which is causing the problem ?
( just looking at: https://github.com/serkri/SmartEVSE-3/blob/master/SmartEVSE-3/src/evse.cpp#L2679 - the 100ms timeout would be too short for processing master-slave comms after adding the bridge ? ... of course this is just guessing .. but: would it be possible to implement bridge setup as selectable on/off menu option, as for other features ?)

It would surprise me if thats that problem; it was introduced in 1.6.3, so then <IP_ADDRESS> would work fine. Could you try 1.6.0 and 1.6.1 too?  Upgrading of the libraries might be the problem.
Please focus on the error on the LCD screen, since the logging of errors on the modbus were introduced in v1.6.3; before that they were just ignored.. it doesnt mean they werent there!

Ok, so: 1.6.0 works fine, 1.6.1 ends up with communications error after few minutes at max: not sure if this enough info ?
(BTW: apparently the problem can also occur with only master powered on, while communicating with sensorbox, slave off at the time. so looks like modbus related ?)

Ok there is one minor change in there that affects modbus traffic, it is commit a40885c65.
Are you able to compile yourself to test before/after this commit?

Yes, I shall be able to, but please allow few days (I'm away from chargers until the weekend..) .. and I have seen the error with 1.6.0 once too (but this may have been effect of my actions...) : so I will run with 1.6.0 for few days to confirm first that this one works for me.

Yes although I think it is nearly impossible to brick your device when you stick to commits in the repo, I have been known to disable the webserver in the past, so OTA flashing stopped working :-(
In that case it is very easy to upload a new version, to the right of the top connections there is a USB-C connector, if you edit platformio.ini to your device (e.g. /dev/ttyUSB0) you can run "pio run -t upload" from the command line. VScode must have some icon for that...

I can confirm that this is indeed the offending change (https://github.com/serkri/SmartEVSE-3/commit/a40885c65b2dc3451b77c495731123ab2d89d0c5) : I reverted it in 1.6.5 and the problem seems to be gone, no more communication errors. Thanks for explanation about recovering the firmware (.. while not sticking to commits in the repo ...


Migrate to Nunjucks

While working on the new templates, I realized that we were very limited by Handlebars functionality and was hard to write even simple comparisons or simply call a function. Therefore, I decided to investigate other templating languages and found Nunjucks (from Mozilla) and it's incredibly easier to write templates compared to Handlebars.
This PR makes the necessary changes to use Nunjucks instead of Handlebars and migrates all the templates.

I'm moving forward and gonna merge this PR. Please, if you see something wrong, missing, or just don't agree with the changes, don't hesitate to leave a comment after it's merged. I'll be happy to address these questions afterward.


Track latest typescript in master (#474)

createScanner's signature changed, updated everything that called it
to reflect that.
Also had to add createScanner to our typings for some reason.
Note that we're still going to want to bump the typescript version manually
All currently existing tests work, but this won't work with new features in
1.6. Yet.

Looks like we have a few options on how to track the latest compiler:

Only track the next distribution tag (try npm view typescript in your console to see what I mean). Any time a dev runs npm install or our CI tests run, it picks up the latest compiler and any breaks will show in tests. This will require us to follow the latest compiler more closely. tslint users will always have the latest compiler bundled with the linter (this shouldn't be a problem since the syntax is backwards-compatible and we haven't given users the option to use a different compiler version anyway).
Track the next distribution tag on a separate branch (like develop) and publish two npm distributions, just like TypeScript does. This creates more overhead for us since we have to maintain two branches & distributions.

I'm leaning towards option 1. Thoughts @ashwinr ?

Does option 1 mean that tslint won't publish new versions to npm? Will we expect users to specify the tslint repo as their url in package.json?

No, we will still publish new versions, they will just bundle in the latest nightly compiler.

How will downstream users know that a new version gets them an unstable compiler version?

Actually, it's not that much overhead to support option 2. We don't need 2 branches.
Our master branch will use typescript@next and we can tag releases that use this compiler with -beta (for example, v2.5.0-beta.1, ...). We can attach the same dist-tag that TS uses (next) to this line of releases. When TS 1.6 is out, we'll remove the -beta.
I doubt there will be more releases on the TS 1.5.x line. If there are, we can start a branch from our v2.4.0 release and make any changes / releases needed on that line.
For tslint users this means:

tslint@latest gives them v2.4.0, which uses the latest stable compiler
tslint@next gives them v2.5.0-beta.*, which uses the latest nightly compiler

If that all sounds good, send a +1 and I'll merge this PR.

Thanks for the clear explanation Adi. I'm in agreement with most things, except that it'll be published on the same npm dist. This means we can't publish 2.6.0 of tslint until typescript releases 1.6. I fear this means we're beholden to typescript's release schedule for tslint releases. Tslint usually has multiple releases for each typescript release.

@ashwinr I'm not sure how this prevents us from releasing multiple times for any one typescript release. We should be able to publish to latest multiple times without difficulty -- if there's anything we need to fix in 2.4 we just branch off of our release, fix it, and publish to latest. We don't need to wait on typescript here, unless I'm missing something?

Ok -- after discussion, we're going to track latest (the stable releases) on master, since that's where most people will make pull requests to, and track next (future release of typescript) on a branch called "next". Closing this pull request, will recreate it shortly.


Add web-dev getting started guide + getting started guide template

Added a basic web-dev getting started guide, along with a general structure for writing Getting Started guides.
Let me know if you have any ideas for the structure of these guides, and that can be reflected in the template.
As for the opinions section, I found it to be an important addition to make contributions more accessible. There is a lot less pressure to be 100% correct and impartial when it is explicitly your opinion.

Didn't realize the wiki had MDX support. I wonder if it'd be worth looking into some custom formatting for these guides.


Arnej/common backticks

@mpolden please review

note: this is mostly useful when rewriting shell scripts that use
`foo 2>/dev/null`
`bar 2>&1`
`baz`

and we want or need to preserve the exact behavior.


Update IMS handling table to include INM

Ha. That's useful. I don't know we have such table. Should we put this in a doc as well?

Hmm, this clearly shouldn't fail ... you might have to rebase with current master, but lets try another build [approve ci].

Ha. That's useful. I don't know we have such table. Should we put this in a doc as well?

Sure -- want to suggest a location for it?

perhaps a section under here ? https://docs.trafficserver.apache.org/en/latest/admin-guide/storage/index.en.html

@shukitchan updated.

[approve ci docs]

cherry-picked to 7.1.x


I think there is a BodyText Field Enum?

As far as I can see the bodyText field is not included in the fields enum. It seems undocumented on the Guardian side, but it also seems very useful.
See for example: https://content.guardianapis.com/search?show-fields=bodyText&page-size=1&api-key=test

Thanks for flagging this @invokermain!
Version 0.1.3 addresses this - bumping the library version should allow you to use Field::BodyText.


Making emails populate

Signed-off-by: Nadia Bahrami<EMAIL_ADDRESS>

This is already fixed in PR #907


Youtube atom tests are missing props

Currently the tests throw a number of errors in tsc, these don't block CI but should be fixed


Vertex PaLM support as LLM

I would like to know if Google Cloud Vertex PaLM will be added to the LLMs section. Happy to contribute knowing where I should edit apart from Config.yml and create a PR.

I also am very interested in this and willing to help.

wondering if/when we maybe able to expect any progress here in using GCP VertexAI LLM models and services within LangFlow, like we already can in LangChain?

Implemented this feature in the latest langflow. Thanks to @ogabrielluiz for his consistent support. I've tested this and it works except for chat models. It works both for text and codey models.


Cannot specify relevant address range for AzureFirewallSubnet

Module: Configure secure access to workloads with Azure virtual networking services
Lab/Demo: Provide a shared services hub virtual network with isolation and segmentation
Task: Create hub and spoke virtual networks and subnets
Step: 5
Description of issue
AzureFirewallSubnet does not accept /24
This also applies to
Lab: Protect the web application from malicious traffic and block unauthorized access
Task:  Create Azure Firewall subnet in our existing virtual network
Step: 5
Repro steps:

Name the subnet AzureFirewallSubnet
You will get the error: Please select 'Azure Firewall' in Subnet purpose dropdown to use the name 'AzureFirewallSubnet'.
Select Azure Firewall in Subnet Purpose.
You cannot select a size, /26 by default

Subnet has been updated to /26


I got an error message 'This request operation sent to net.tcp://localhost:7045/NAV/HealthService did not receive a reply within the configured timeout (00:01:00).  ...'

Hi All,
I downloaded Business Central's Spring Release 19 and run it on docker container. But when I debug AL code, it always freezes debugger. And then I executed 'Get-NavContainerEventLog' command and got following error. I guess this error maybe caused me to be unable to debug code. Does any one know how to resolve this error? I'll very appreciated if any one can help me to resolve it.
AL version: 3.0.126610
Business Central Version: 14.0.29537.31808
The description for Event ID 0 from source MicrosoftDynamicsNAVClientWebClient cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.
If the event originated on another computer, the display information had to be saved with the event.
The following information was included with the event:
Error accessing Website
Type: System.TimeoutException
Message: This request operation sent to net.tcp://localhost:7045/NAV/HealthService did not receive a reply within the configured timeout (00:01:00).  The time allotted to this operation may have been a portion of a longer timeout.  This may be because the service is still processing the operation or because the service was unable to send a reply message.  Please consider increasing the operation timeout (by casting the channel/proxy to IContextChannel and setting the OperationTimeout property) and ensure that the service is able to connect to the client.
StackTrace:
Server stack trace:
at System.ServiceModel.Dispatcher.DuplexChannelBinder.Request(Message message, TimeSpan timeout)
at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
at System.ServiceModel.Channels.ServiceChannelProxy.InvokeService(IMethodCallMessage methodCall, ProxyOperationRuntime operation)
at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(IMessage message)
Exception rethrown at [0]:
at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)
at System.Runtime.Remoting.Proxies.RealProxy.PrivateInvoke(MessageData& msgData, Int32 type)
at Microsoft.Dynamics.Nav.Types.IHealthService.IsSystemHealthy()
at Microsoft.Dynamics.Nav.Client.Web.SimpleServerOperation.ExecuteCore[TResult,TChannel](RequestContext requestContext, ConnectionOptions serverConnectionOptions, Func2 operation, Func3 operationWithContext, Func`2 localExceptionHandler, Int32 retryCount) in s:\repo\src\platform\client\web\Prod.Client.WebCommon\Security\SimpleServerOperation.cs:line 302
Source: mscorlib

got the same errors

try to create your container with -additionalParameters @('--cpu-count 4')
https://freddysblog.com/2019/06/03/debugging-hangs-in-business-central-spring-2019-rtm-and-cu1/
(with a different workaround as well)

Hi @monchangg ! Did the solution provided by Freddy work for you? Are you still facing this issue?

@shashiBssi @atoader  Thank you very much. That can resolve my issue.


Errors in Blob path UI and Regex Validation

From @mathewc on February 11, 2017 17:42
2 issues. First, our blob path regex is overly restrictive. Second, the actual help text isn't resolving. Path expressions can contain an arbitrary number of path segements, and each supports {} binding expressions. Note also that %% expressions are also supported (binding from app settings, e.g. %MY_CONTAINER%/{Foo}/{Bar}). We should review all our regexes and make sure they're correct in this regard.

Copied from original issue: projectkudu/AzureFunctionsPortal#911

From @mathewc on February 11, 2017 17:45
@soninaren

Fixing the regex so that it accept the following inputs, Fixing regex for storage bindings, opening a new issue to review all other regexs
con/a
{container}/{a}
%abc%/{a}/{ab}/a
%abc%/%a%/{abc}/a
{Container}/{first}
con/{a}

Also for blob trigger it accept the following as well
con
{Container}
{container}
%abc%


using cmake RESOURCE_INSTALL_DIR causes failure

In CMakeLists.txt in examples and the root dir, CMAKE_INSTALL_BINDIR isn't deifned.
Changing it to RESOURCE_INSTALL_DIR gets it to gen properly.  Using cmake 3.7.2.  From a quick google search, you may need include(GNUInstallDirs) at the top of the root CMakeLists.txt.  Or evaluate if this is the intended usage of the bin dir.
Also, if RESOURCE_INSTALL_DIR isn't defined, we use a local path for VK_EXAMPLE_DATA_DIR, which makes it not runnable over the network for remote debugging (or copyable to a new machine).  Not sure if the solution is to leave this undefined so the code will default to a relative path or if this is intentional.

Not sure if this is still an issue or not, but when using the cmake gui, it
allows you to change the path for the resource install dir.  On Windows, I
was changing this to be a relative path so it could find it w/o having it
being hardcoded.  When you do this, the build will fail because some
defines don't seem to line up.  You should be able to repro this (unless it
was fixed) by changing the path in the cmake gui to something else.  I was
able to fix this by adding that include.  Could be a Windows only thing,
not sure what your default platform is or if you have some libraries
installed on Windows that make it work.
The second comment was to ask about whether or not the resource path could
be relative by default.  At work, I sometimes run the samples using visual
studios remote debugging and the hardcoded path doesn't work in that
instance.
On Sat, Mar 24, 2018 at 1:23 AM, Sascha Willems<EMAIL_ADDRESS>wrote:

Sorry for the late reply, but can you elaborate on this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SaschaWillems/Vulkan/issues/417#issuecomment-375855729,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYT896mpD1xYQ92PfL-dO4IqvPliSDN3ks5thgKdgaJpZM4RxUSy
.


Neuroml export

@salvadord this wasn't quite ready to be merged into master yet... Some more testing required... I'll hopefully get to this this week.

@pgleeson - ah sorry about that, will release new version when tested; and will check with you next time before merging onto master

Ok, thanks. Have you changed the way seeds etc. are handled in the recent changes on development? I'm getting different 3D positions for the same netpyne script (see here: https://github.com/OpenSourceBrain/NetPyNEShowcase/blob/master/NetPyNE/HHSmall/HHSmall.py) which sets:
  simConfig.seeds = {'conn': 1, 'stim': 1, 'loc': 1}

This is also generating strange values for delays, try https://github.com/OpenSourceBrain/NetPyNEShowcase/blob/master/NetPyNE/HHSmall/HH_export.py:
        <connectionWD id="0" preCellId="../PYR/1/CELL_HH_PYR" postCellId="../PYR/0/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>
        <connectionWD id="1" preCellId="../PYR/2/CELL_HH_PYR" postCellId="../PYR/0/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>
        <connectionWD id="2" preCellId="../PYR/0/CELL_HH_PYR" postCellId="../PYR/1/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>
        <connectionWD id="3" preCellId="../PYR/2/CELL_HH_PYR" postCellId="../PYR/1/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>
        <connectionWD id="4" preCellId="../PYR/0/CELL_HH_PYR" postCellId="../PYR/2/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>
        <connectionWD id="5" preCellId="../PYR/1/CELL_HH_PYR" postCellId="../PYR/2/CELL_HH_PYR" weight="0.005" delay="14.5184015666 ms"/>

@pgleeson - ah sorry, made small change in sim.id32() func while debugging and forgot to change back :(  -- will release with fix

thanks for pointing this out, should work ok now -- let me know if still have any issues

Great. That fix worked!


Comparison with Dense Surfel Mapping

Dear authors @hlx1996 @USTfgaoaa ,
Thanks for your open-source code. Great work!
I noticed in your TRR project, you use Dense Surfel Mapping(DSM) for global mapping while FIESTA for local mapping. After I separately test the two mapping modules, I found something interesting.
FIESTA has 3D probabilistic representation and ESDF, but seems has more error than DSM when VINS is used. See below pics for an illustration. The first picture is from FIESTA. Vins-mono is launched. The map with height color is from FIESTA, while the white pointcloud is from an RGBD camera (that you could think as a groundtruth pointcloud). The camera pose from VINS is good but there is an obvious discrepancy between the two pointclouds. The second pic is from DSM. From there you can see DSM does a really good job.

Also, it seems FIESTA does not integrate pose-graph from VINS side, leading to an accumulation of the mapping error, which may cause bad issues for map global consistency.
I am wondering if you guys have ever encountered those problems in your experiments.
Regarding to DSM, although it is more accurate, it seems DSM only has 3D deterministic surfel representation of the environment but no probabilistic property and ESDF available. So I am also wondering if you have plans to integrate the two mapping modules together to make a more robust, scalable, and accurate 3D mapping module.
Thanks!

@ArlenCHEN

Because of FIESTA's underlying structure, it can't support deformable wrapping to incorporate a global pose graph.
I don't think FIESTA has such an "ERROR". You may check your own testing code. Since FIESTA and Dense Surfel Mapping are just mapping modules, their core algorithms are about how to fuse several observations into a unified map, how to reject outliers, how to generate the correct values (like ESDF or Surfels) you want to use, right? Apart from the above, they just project points according to the camera model, there are no differences. So if you find can't align the simulated map with the ground truth, I think probably it's because of intrinsic parameters of the camera or just some functional errors in your testing code. We have tested FIESTA on our drones many time and it successfully supports collision avoidance and onboard mapping.
If you want a more direct mapping module to use directly, please go to Fast-Planner and use its map, which is just a probabilistic occupancy grid map with local ESDF batch generation.

@ArlenCHEN Fast-Planner: https://github.com/HKUST-Aerial-Robotics/Fast-Planner

@USTfgaoaa Thanks for your explanation. Very helpful! I will check my testing code.


animationeEnd is broken for pie chart

Hi
in 3.15.6 there's a fix regarding animation.
Not sure if related but animationEnd does not trigger anymore for pie chart.
chart: {
   events: {
      animationEnd: (ctx) => {
         ctx.toggleDataPointSelection(0);
         }
      }
   }
}

Setting a breakpoint inside animationEnd event does not stop and there is no animation at all.
Updating to 3.16.1 didn't fix it as well.

Just checked it. Works on my side.

On my end I don't see the animation at all
totalsOptions: function() {
            return {
                animations: {
                    enabled: true,
                    easing: 'easeinout',
                    speed: 800,
                    animateGradually: {
                        enabled: true,
                        delay: 150
                    },
                    dynamicAnimation: {
                        enabled: true,
                        speed: 350
                    }
                }
}

How did you define the animations on your side?

chart: {
  animations: {
    enabled: true
  }
}


Creating new folder and then scrolling up messes directory tree

Version 0.10.8
Steps to reproduce:

You shall have many folders so that scroll appears;
Click parent folder with right mouse button -> New Folder;
Don't do anything, just scroll up with mouse wheel;

Directory tree starts to behave strangely when scrolling up, items mess up.

Can you maybe provide a video recording of what you are seeing?
LICEcap is a useful tool for this.

Here

Very COOL. Thanks for the recording!


Formly Material Autocomplete Reset: Style not resetting (.mat-selected) / Initial style not applied

Style not resetting
When an an autocomplete control is reset, the material style does not reset accordingly.
I have adapted the autocomplete sample and added a reset button for demonstration purposes:
https://github.com/FloppyNotFound/ngx-formly-autocomplete-style-issue

Open the autocomplete
Select an entry
Click reset
Open the autocomplete again

=> the previously selected item still has the class .mat-selected set, which causes the style to display the red background color.
Expected behavior:
the .mat-selected class is gone, no background is set.
Actual behavior:
the .mat-selected class is still set, the item has a red background.
Note: this seems to be only an issue with the styles, the component works as expected otherwise.
Initial style not applied
There also is a probably connected issue:
when you set the selected value programmatically, or if you set an initial value, the style is not applied initially.
Reproduce:
Use the same link as above (https://github.com/FloppyNotFound/ngx-formly-autocomplete-style-issue) and replace
model = { };
with
model = { state: "Alabama" };
Expected behavior:
the .mat-selected class is applied, the selected item has a red background
Actual behavior:
the .mat-selected class is not applied, the selected item looks just like the others and has a white background.

unfortunately, the stackblitz project seems broken, I'm gonna create a new one

That's material issue, I've opened an issue there https://github.com/angular/components/issues/20878, thanks!

What about the second point, that the initial style is not applied? Is this a material issue too?

Is this a material issue too?

I think so, you may add a comment in the issue https://github.com/angular/components/issues/20878 for the second point.


feat: Add beforeSendTransaction hook

beforeSendTransaction works similarly to beforeSend, but it is applied only to transaction events.
Closes #500.
Docs:

[ ] Basic Options page: https://github.com/getsentry/sentry-docs/pull/6039
[ ] Other pages: TODO

Added an example and updated the changelog.
Docs are pending for now, as described in https://github.com/getsentry/sentry-docs/pull/6039


More wasting of developers time

I followed your instructions line by line and the first surprise was again, this is a React template (I should have known) and when I tried to build it, first got a alert box saying "Do you want to save the changes you made to launch.json" and the second after it completed, I received the error:
Uncaught SyntaxError SyntaxError: Invalid or unexpected token
at (program) (https://statics.teams.cdn.office.net/hashedjs-launcher/launcher.83a2bdf97607d16ed719.js:1:1)
I have done no coding. Now do I debug your app or do I start all over... the time spent thus far was simply wasted. Where's just a plain example of how to build these applications instead of the influencer and sell jobs? This is why you need a "code of conduct" reminder for these developers because your work is frustrating us. I've already attempted to strip code out of here and add to another application, and right now I'm busy debugging that. So in the meantime, I try to start all over with this and I';m right back  in the same place. Its been 3 days of nothing but getting an app published on Teams and still it hasn't happened and I've followed every video and doc I could find, wasting hours watching videos where 90% of the instruction has nothing to do with what I'm trying to resolve and I remain in the same position. My company is very interested in integrating with Teams, but you're making it very difficult to recommend it as a viable solution for any developers except your partners.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e473e1f3-69f5-bcfa-bcab-54b098b59c80
Version Independent ID: e473e1f3-69f5-bcfa-bcab-54b098b59c80
Content: Hello World with JavaScript - Teams
Content Source: msteams-platform/sbs-gs-javascript.yml
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@crtjr64 - We will try to setup this sample and let you know the updates.

@crtjr64 - We have tried this. Followed the steps in document. It was working fine at our end.

I'm well past this. It did not work for me until I made some changes to the Manifest file and the code to use Teams SDK 2.0. That's why it failed for me. I'm dealing with another error. Is it possible that I cannot publish to teams with this website? https://tunstallsoftwarellc.azurewebsites.net because it's domain is azurewebsites.net?

@crtjr64 - Have you added domain of website in validomain list in manifest?
FYI Browsers same-origin policy restriction prevents webpages from making requests to different domains than the served web page. So, you can redirect the configuration or content page to another domain or subdomain. Your cross-domain navigation logic needs to allow the Teams client to validate the origin against a static validDomains list in the app manifest when loading or communicating with the tab.

@crtjr64 - Hope you are doing well !!
Please let us know whether your issue has resolved or still need any help here ?


join-key expressions are too fussy

The join-key expressions currently work on each side's respective table.  You should be able to refer to either side on either side of the join expression.  The cut-expressions will continue to come from the dimension-side of the join.  This is easy to fix by first trying the preferred side for the key's expression and if it is MISSING, try the other side.  This would be preferred over doing the work to creating a new joined record only to throw it out in a common case.

The Zed docs published in #2836 cited this issue as a current limitation. When this issue is addressed, the docs should be updated.


Redesign Activity Screen

https://www.figma.com/file/x07XtWRI573FfO8duPMIEz/3.4.0?node-id=1%3A121

Start with top half of the UI:

[ ] New send/receive icons
[ ] Show DC, HST balance, show staked HNT balance, show liquid balance.
[ ] introduce filters: All | Pending | Mining Rewards | Payments | Hotspot | Validators

For Mining Rewards: hotspot and validator rewards
For Payments: payment v1, v2, burn
For Hotspot: add, assert, transfer
For Validators: stake, unstake, transfer


Policy adjustment

Do we have a script that would right size an existing tenant to match a new tenant policies?
I believe new tenants are deployed with policies that match the All-All policy descriptor.

I think so:
https://github.com/PaloAltoNetworks/prismacloud-api-python/blob/main/scripts/pcs_policy_set_status.py
It has params for what policies to enable/disable, but note that each type of param is independent. That is you cannot specify policy_severity and and compliance_standard and have it enable/disable the intersection (but it could PR welcome).


Nominating Robert Sipka (@robertsipka) to become a JerryScript committer

I would like to nominate Robert Sipka to become a committer. He already has 39 patches:
#1317 Add missing jerry-libm include path to jerry-core target.
#1291 Remove unused JERRY_ENABLE_PRETTY_PRINTER from the build system.
#1263 Remove unused ecma-helpers functions
#1259 Remove needless toolchain files and variable settings.
#1238 Remove compact profile.
#1231 Complete the getting-started documentation after the build-system update.
#1230 Comment fixes which are left behind after the API update.
#1229 Change the CONFIG_ECMA_NUMBER_TYPE default value to CONFIG_ECMA_NUMBER_FLOAT64.
#1228 Build fix for RIOT target after the modifications of the build system
#1192 Re-thinking the build system to bring it more into line with the conventions.
#1159 Build fix for ALL_IN_ONE and COMPILER_DEFAULT_LIBC
#1133 Rename 'jerry_api_' prefix to 'jerry_' in the main-riotos.c file
#1130 Added target to compile RIOT-OS against jerryscript
#1115 Insert parameters between the pair of parentheses in the JERRY_MIN and JERRY_MAX definitions.
#1114 Use 'ecma_get_float_from_value' instead of 'ecma_get_number_from_value' in the ToString operation.
#1098 Optimising the ToString operation
#1066 Unify the condition form within the asserts
#1043 Initialize the timeval struct fields, because the gettimeofday() may not fill these.
#1040 Unified the commenting form of the internal properties and removed the unused types.
#1036 Improve the string descriptor.
#1033 Check whether the aligned pointers value of the internal properties can be stored directly
#1026 Store aligned pointers directly in ecma_value_t if it is possible.
#1020 Don't use pointer compression where the ecma_value can store pointer value directly.
#1014 Use 'ECMA_VALUE_CAN_STORE_UINTPTR_VALUE_DIRECTLY' instead of comparision with 'sizeof'
#1010 Set the correct pointer value in 'ecma_copy_ecma_string' function.
#1007 Remove the unused LIT_STRING_HASH_LAST_BYTES_COUNT define macro
#938 Warning fixes.
#935 Build fix for mbedk64f target
#921 Warning fix for ALL_IN_ONE.
#916 Add another argument for the JERRY_STATIC_ASSERT with the description of the assert statement.
#885 Warning fixes.
#876 Eliminate cpp featureset
#863 Use 'static inline' for function definitions that are in header files.
#862 Use simple types instead of reference types.
#861 Use type cast to avoid conversation error with C99 standard.
#860 Add forward declaration for mem_pool_chunk struct.
#859 Merge the js-parser and parser files
#851 Remove unnecessary variable length arrays.
#838 Fix the correct number of command line arguments check.

+1

+1

+1

+1

+1

+1

+1

Congratulations!


handle empty sketches

this is to address #7486

Could you add a test for this please? (It seems like the kind of thing that's likely to get missed if the code is ever refactored, so a test is good to protect against that.)

Could you point me to the best example of a test for such a purpose? Should it be a micro-test (minimalistic unit test) or some sort of an integration test similar to what we do now in DoublesSketchAggregatorTest where we construct a json query and run it using the AggregationTestHelper?

@AlexanderSaydakov I am not intimately familiar with the code, but I'd guess that a minimalistic unit test would be best. In general I prefer unit tests when feasible.

I don't understand what happened with the inspection:
Java HotSpot(TM) 64-Bit Server VM warning: Insufficient space for shared memory file:
[22:26:11]   30896

TeamCity inspection report doesn't show any new errors in the files affected by this patch, merging


Add an optional minimum-ddev-version in .ddev/config.yaml

Is your feature request related to a problem? Please describe.
While working on a project together with a team, ddev was setup in latest stable version, but one of the team member is using older ddev version and getting into issues that wouldn't be there if they would use the version ddev was setup with.
Describe the solution you'd like
Add an optional minimum-ddev-version in .ddev/config.yaml
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

The easiest way to accomplish this is to add a pre-start exec-host hook that runs ddev debug capabilities | grep <capability-youwant> That way you can warn about the situation. If you want it to be really aggressive, your config.yaml can include fail_on_hook_fail: true (the default is false).
Since there's an easy way to do this, I'm going to close this for now.


Documentation issue (CMake)

In README.md you state

Note: this assumes you have created empty files for ${META_GENERATED_HEADER} and ${META_GENERATED_SOURCE} and added it to the list of sources when calling add_executable( ). Otherwise, CMake will complain about the files not existing initially.

The recommended approach is not to create empty files for generated files (especially as you will be tempted to put them in the source directory instead of the build directory). Instead you should set the GENERATED on the corresponding sources:
set_source_files_properties(
    ${META_GENERATED_HEADER} ${META_GENERATED_SOURCE}
    PROPERTIES
    GENERATED ON
)

Furthermore you use a PRE_BUILD TARGET add_custom_command which only works on Visual Studio. Using a non-TARGET add_custom_command might be better (and also sets the GENERATED property automatically).

This is fantastic! I was unaware of the GENERATED source files property.
I was also unaware that add_custom_command(TARGET ...) only works in Visual Studio, but this makes sense.

(and also sets the GENERATED property automatically)

Can you explain what you mean by this? Sets the GENERATED property for what exactly?

It's not the add_custom_command(TARGET ...) form per se that only works on VS, but the PRE_BUILD mode of that command. In any case, I believe the add_custom_command(OUTPUT ...) form is a better fit.

Using add_custom_command(OUTPUT ...), how can I ensure the command is run before a specific target is built? (aka the PRE_BUILD stage of a specific target in Visual Studio).
I tested this method, and it works, however I don't understand the MAIN_DEPENDENCY, DEPENDS, and IMPLICIT_DEPENDS options.

Just include the outputs in the target's add_library or add_executable command, and they will be generated before the target is built.
MAIN_DEPENDENCY is just to make the Makefile itself look nice. DEPENDS is a list of files that should be monitored for changes (the files are generated only if they don't exist or one of the dependencies changes), basically this should be all your (other) header and source files. IMPLICIT_DEPENDS would actually be the ideal solution as it would trigger the dependency determination also used for building cpp/c files (all .h files, even system headers and libraries would be pulled in). However, it only works for unix makefiles.
There are hacks to get pre-build like behavior with all generators, but that gets real ugly, real quick, see, e.g., http://stackoverflow.com/questions/3780667/use-cmake-to-get-build-time-svn-revision

I just realized your solution is actually much more desirable than a pre-build step. Only project header files effect the generated reflection files. Therefore, it makes sense to use just header files in the DEPENDS option of the add_custom_command(OUTPUT ...).
With a pre-build step, the reflection files will be regenerated even if only a source file is changed, which is not desired.
I'll update the readme to reflect these changes! Thanks again.


Project activity needs

I've been really interested in this project. Do you need help with development? More so than the occasional pr? Looking to help if this isn't looking too slow down in the near future.

I dont really use angular , but I was looking at code to think to add filter options and search options for plex user library. That would be cool. as a new user


Newbie question: Does linuxbrew use the same formula as mac os x brew?

Hi folks, linux brew is very cool - one newbie question I couldn't find a quick answer, is that whether linux brew uses the same formula as homebrew. If not, then we are just another package manager? (perhaps source code manager/compiler etc.)
Thanks,
Isaac

Yes, Linuxbrew uses the same formulae as Homebrew, with some patches. Homebrew/core is merged into Linuxbrew/core daily.


Token validator fails with no read:project permission even if full project permission is given.

Description
The below error is appearing..

When below permission is given, validator fails. (if only read:project, validator works)

How to replicate the issue + URL
NOTE: Only occurs on my private repositories (SAML required Organization)

https://github.com/refined-github/refined-github/pulls

Also, pr-approvals-count, the css only feature is not works on above pulls page, on my private repositories (SAML required also)
In this case; It seems not refined-github's bug, just GitHub not supplies hint for this feature. Just FYI

Extension version
24.2.8
Browser(s) used
Chrome 120.0.6099.234 (arm64)

Sigh 🥹
This check needs to be adjusted further:

https://github.com/refined-github/refined-github/pull/6728


Changing channels sometimes hangs

Using the up and down to change channels between live channels, sometimes hangs with the logo on screen, spinning circle and "The channel will be available soon." text.  This never seems to show the channel, unless you back out of the Live Channels app and go back into it.

I'll look into this. Can you say what device you're using and what operating system version you're running? What other live channel apps do you have? I've run into some live channel issues as well that I've run into occasionally. I think it could be due to the platform itself.

Only Cumulus TV is installed.
Asus Nexus Player, running Android 6.0 Build MRA58N.

I might chalk this up to a bug within Live Channels or an Internet connection issue.

This is a tuning timeout issue. It'll be fixed soon as it's fixed in ChannelSurfer 0.2.8


Check if rerun-if-changed points to a directory.

This changes it so that if a build script emits cargo:rerun-if-changed pointing to a directory, then Cargo will scan the entire directory for changes (instead of just looking at the mtime of the directory itself).  I think this is more useful, as otherwise build scripts have to recreate this logic.
I've tried to make it semi-intelligent in the face of symbolic links.  It checks the mtime of the link and its target, and follows the link if it points to a directory.
There are a few other edge cases. For example, if it doesn't have permission for a directory, it will skip it.  I think this is relatively reasonable, though it's hard to say for sure.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

Basically looks good to me. I worry about the performance of scanning large folder trees on widows, but the correctness is probably worth it.

@bors: r+

:pushpin: Commit 4c68a4ad793142cdc321aa8e6ff687ff9c927a97 has been approved by alexcrichton

:hourglass: Testing commit 4c68a4ad793142cdc321aa8e6ff687ff9c927a97 with merge a3c2627fbc2f5391c65ba45ab53b81bf71fa323c...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing a3c2627fbc2f5391c65ba45ab53b81bf71fa323c to master...

This kind of thing makes it more urgent that we have some way to declare a minimum Cargo version for a crate. If a crate uses this with an older version of Cargo, it'll just silently not rebuild.
What's the most minimal mechanism we could use to enforce a minimum Cargo version in a crate? Would it be unreasonable to just add a min-cargo-version field, just as we've been talking about a min-rust-version field or similar?

I don't think we'd want to do that as a PR given all the past conversations about minimum versions, personally, so if we'd want to pursue that I think we'd want to go the RFC route.

@alexcrichton I wasn't suggesting it could be done without an RFC; I was asking how minimal that RFC might be able to be.


Refs: #AR-5583 opensource MIT license update as suggested by GitHub s…

…o a repo gets marked as open source

@makylfang merging.  C u pls ensure it gets merged to the main in the next adkg binary update? Thank you.


Bump actions/download-artifact from 3 to 4

Bumps actions/download-artifact from 3 to 4.

Release notes
Commits

updated-dependencies:

dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ...

This is a benchmark review for experiment review_of_reviews_20240326.
Run ID: 2024-04-02T15-54-56/v1.16.0-43-g6b42d863f-dirty/f12378.
This pull request was cloned from https://github.com/Remi-Gau/giga_connectome/pull/4. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)


Using feature_fraction and forced splits together can cause training failures

Description
Using forced splits together with feature_fraction can lead to the following error

[LightGBM] [Fatal] Check failed: (best_split_info.left_count) > (0) at treelearner/serial_tree_learner.cpp, line 653 .

I've found that this error:

does not occur if using feature_fraction=1.0 (the default)
occurs randomly (even with a fixed dataset and setting random_state and feature_fraction_seed)
tends to less often with more verbose logging (i.e. occurs less frequently with verbose = -10 and least frequently with verbose = 10
occurs even for datasets where the number of samples is well below bin_construct_sample_cnt

Reproducible example
R example (click me)
The code below using the built-in Chickweight dataset can be used to reproduce this issue.
Trying different combinations of settings for parameters VERBOSITY, FEATURE_FRACTION and USE_FORCED_SPLITS, I found the following results.
different settings of verbose
---- forced_splits=TRUE, feature_fraction=0.600000, verbose=10---
5 out of 10 succeeded
6 out of 10 succeeded
4 out of 10 succeeded
7 out of 10 succeeded
7 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.600000, verbose=1 ---
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
1 out of 10 succeeded
0 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.600000, verbose=0 ---
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
2 out of 10 succeeded
0 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.600000, verbose=-10 ---
0 out of 10 succeeded
1 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded

different settings of feature fraction (NOTE: this dataset only has 3 features)
---- forced_splits=TRUE, feature_fraction=0.400000, verbose=10 ---
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.600000, verbose=10 ---
8 out of 10 succeeded
6 out of 10 succeeded
6 out of 10 succeeded
4 out of 10 succeeded
6 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.800000, verbose=10 ---
5 out of 10 succeeded
9 out of 10 succeeded
8 out of 10 succeeded
8 out of 10 succeeded
8 out of 10 succeeded

---- forced_splits=TRUE, feature_fraction=0.800000, verbose=10 ---
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded

library(data.table)
library(lightgbm)

set.seed(321)

VERBOSITY <- 10L
FEATURE_FRACTION <- 0.6
USE_FORCED_SPLITS <- TRUE

data(ChickWeight)
trainDT <- data.table::as.data.table(ChickWeight)
target <- trainDT[["weight"]]
X <- data.matrix(trainDT[, .(Time, Chick, Diet)])

string = paste0('{
  "feature": 0,
  "threshold": 10.0,
  "right": {
    "feature": 0,
    "threshold": 16.0
  }
}')

write(string, file = "forced_split.json")

string = paste0('[
    {
        "feature": 0,
        "bin_upper_bound": [ 10.0, 16.0]
    }
]')

write(string, file = "forcedbins.json")

train_ds <- lgb.Dataset(
    data = X
    , label = target
    , params = list(
        forcedbins_filename = "forcedbins.json"
        , min_data_in_leaf = 1
    )
)

params <- list(
    objective = "regression"
    , feature_fraction = FEATURE_FRACTION
    , num_iterations = 10
    , num_leaves = 8
    , random_state = 708
    , feature_fraction_seed = 708
)

if (USE_FORCED_SPLITS) {
    params[["forcedsplits_filename"]] <- "forced_split.json"
}

# fails randomly, even setting random_state and feature_fraction_seed
results <- sapply(
    X = seq_len(10L)
    , FUN = function(...) {
        try({
            fit <- lgb.train(
                params = params
                , data = train_ds
                , verbose = VERBOSITY
            )
            return(1)
        })
        return(0)
    }
)
num_successes <- sum(results)
num_attempts <- length(results)
print("")
print(sprintf(
    "---- forced_splits=%s, feature_fraction=%f, verbose=%i---"
    , USE_FORCED_SPLITS
    , FEATURE_FRACTION
    , VERBOSITY
))
print(paste0(num_successes, " out of ", num_attempts, " succeeded"))

whether or not feature_fraction is used (using settings of other params which led to the most errors)
---- forced_splits=TRUE, feature_fraction=0.400000, verbose=-1---
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded
0 out of 10 succeeded

---- forced_splits=FALSE, feature_fraction=0.400000, verbose=-1---
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded
10 out of 10 succeeded

I haven't been able to reproduce this issue in the Python package yet, although I'm not sure if it's R-specific.
Python example code (click me)
My attempt to replicate the R example in Python. For a variety of settings of VERBOSITY and FEATURE_FRACTION, I have not been able to replicate the errors observed in R.
Maybe there is some dataset-specific characteristic that's significant. One way to try to make this an even tighter comparison would be to write the ChickWeight data from the R package out to a CSV file and read that data into Python.
import json
import lightgbm as lgb
import pandas as pd
import numpy as np

from sklearn.datasets import make_regression

VERBOSITY = -10
FEATURE_FRACTION = 0.2
USE_FORCED_SPLITS = True

X, target = make_regression(
    n_samples=1_000,
    n_features=3,
    n_informative=1,
    random_state=321
)

threshold1 = np.percentile(X[:, 0], 0.4)
threshold2 = np.percentile(X[:, 0], 0.9)

forced_split = {
    "feature": 0,
    "threshold": threshold1,
    "right": {
        "feature": 0,
        "threshold": threshold2
    }
}
with open("forced_split.json", "w") as f:
    f.write(json.dumps(forced_split))

forced_bins = [
    {
        "feature": 0,
        "bin_upper_bound": [threshold1, threshold2]
    }
]
with open("forcedbins.json", "w") as f:
    f.write(json.dumps(forced_bins))

train_ds = lgb.Dataset(
    data=X,
    label=target,
    params={
        "forcedbins_filename": "forcedbins.json",
        "min_data_in_leaf": 1
    }
)

params = {
    "objective": "regression",
    "feature_fraction": FEATURE_FRACTION,
    "num_iterations": 10,
    "num_leaves": 8,
    "random_state": 708,
    "feature_fraction_seed": 708,
    "verbose": VERBOSITY
}

if USE_FORCED_SPLITS:
    params["forcedsplits_filename"] = "forced_split.json"

successes = 0
attempts = 0
for i in range(10):
    attempts += 1
    try:
        bst = lgb.train(
            params=params,
            train_set=train_ds,
        )
        successes += 1
    except Exception as err:
        print(err)

print(f"---- forced_splits={USE_FORCED_SPLITS}, feature_fraction={round(FEATURE_FRACTION, 6)}, verbose={VERBOSITY} ---")
print(f"{successes} out of {attempts} succeeded")

Environment info
LightGBM version or commit hash: latest master (https://github.com/microsoft/LightGBM/commit/64f15005040aafa528bbec7f873364d94b7e36a4)
Command(s) you used to install LightGBM
# R
sh build-cran-package.sh
R CMD INSTALL lightgbm_<IP_ADDRESS>.tar.gz

# python
cd python-package
python setup.py install

output of R sessionInfo() (click me)
R version 4.1.0 (2021-05-18)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Mojave 10.14.6

Matrix products: default
BLAS:   /Library/Frameworks/R.framework/Versions/4.1/Resources/lib/libRblas.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/4.1/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

loaded via a namespace (and not attached):
[1] compiler_4.1.0

output of 'conda info' (click me)
     active environment : None
       user config file : /Users/jlamb/.condarc
 populated config files : /Users/jlamb/.condarc
          conda version : 4.10.3
    conda-build version : not installed
         python version : 3.8.8.final.0
       virtual packages : __osx=10.14.6=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /Users/jlamb/miniconda3  (writable)
      conda av data dir : /Users/jlamb/miniconda3/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/osx-64
                          https://conda.anaconda.org/conda-forge/noarch
                          https://repo.anaconda.com/pkgs/main/osx-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/osx-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /Users/jlamb/miniconda3/pkgs
                          /Users/jlamb/.conda/pkgs
       envs directories : /Users/jlamb/miniconda3/envs
                          /Users/jlamb/.conda/envs
               platform : osx-64
             user-agent : conda/4.10.3 requests/2.25.1 CPython/3.8.8 Darwin/18.7.0 OSX/10.14.6
                UID:GID : 501:20
             netrc file : None
           offline mode : False

Additional Comments
Created based on the example code provided in https://github.com/microsoft/LightGBM/issues/4591#issuecomment-914688417.
The fact that more verbose logging leads to this error occurring less often is very surprising to me. The only explanations I can think of for this are:
a. there is a race condition somewhere in LightGBM and adding more logging slows LightGBM down enough to reduce the risk of hitting it
b. something else about the logging code causes a sync-up in otherwise asynchronous code
It would probably be useful to investigate this race condition idea further by running the reproducible examples above under different values of num_threads.

Hi James, thank you for extracting that from #4591, and for further narrowing down the problem. I'll take a look into this.


[v6]: Export RouteContext so we can forward it when using a Slot/Fill approach

What is the new or updated feature that you are suggesting?
Hello!
I want RouteContext to be exposed so I can use it to forward the routing context when using a Slot/Fill approach.
Why should this feature be included?
Right now when sending a component containing routing (like a Link) into a distant parent component, it totally loses its routing context, as it's rendered in a different branch of the react component tree. So we lose all the benefits of relative routing.
In order to "fix" that, I need to send a replica of the current routing context as well. I was able to do it with a "trick", relying on basename as explained here and here.
It's not perfect because once the basename bug is resolved, I won't be able to use absolute paths in these components as they will be prepended with the basename. Also the basename is more a workaround than a proper fix.
In order to do it correctly, I need to access the RouteContext directly, consuming its current value (like this) and passing it to a new RouteContext.Provider (like this).
So please, could you expose the RouteContext? 🙏

This was already addressed in the last issue: https://github.com/ReactTraining/react-router/issues/7164#issuecomment-617562970

Yes, sorry I realized a bit late that the issue was already tracked. At least, I don't think my use case was previously mentioned so this isn't totally lost. 😄
Have a great week-end Tim!

@timdorr Sorry for spamming, but I just noticed you pointed me to the createPortal comment.
Actually this isn't a custom portal issue here, createPortal won't fix anything because the RouteContexts are declared as children of the component where the subcomponents will be sent  (the Layout), so they aren't both children of the RouteContexts from a component tree structure.
Here is an example illustrating what I'm saying : https://codesandbox.io/s/vigorous-easley-q661i?file=/src/App.tsx
In this example I used the @wordpress/component flavour of the Slot/Fill pattern, which is using createPortal in its implementation.

Getting access to RouteContext won't fix that. The instance of <Routes> you have under your Screen component will redefine the context value, so you would still get the ancestor value (which is the default coming from BrowserRouter). That's just how React context works, so this isn't something we can fix. You have to get your rendered components at least under the element prop of your Routes.

I'm not sure I follow. By exposing RouteContext I will be able to create a copy of the current context as you said, then it's just of matter of wrapping the inserted components like this :
<CopyOfRoutes>
  <Route path="*" element={props.tabs} />
</CopyOfRoutes>

This is exactly what I'm currently doing and it works. My only issue is that I can't make a true CopyOfRoutes right now and have to rely on basename.


After an improvement is built in a city, switch to the city menu in order to change building order

Basically now after you build an improvement the game alerts you, shows you the city view but does not give you the option to change building order in the city menu.

That is a known issue, and there's no simple fix for it. I will need to rewrite some code in order to get this working. Not sure if I'll pick that up before this version is finished.


Events for toolbar buttons.

Hello! This would be very useful if there were these events for actions: ['finish', 'removeLastVertex', 'cancel']
As an example:
map.on('pm:CircleMarckerCancel', (e) => {});
map.on('pm:CutFinish', (e) => {});
and other.
Thank you!!

great suggestion, thank you! Marked as a feature request 👍

Is implemented in Version 2.8.0


Bug with Escape char(0x1B) in text files

Type: Bug
I have noticed that when a text file contains the "<Escape char(0x1B)>[0m" more than about 5000 times, VSCode is unable to show the line numbers properly.
I tested the issue with all extensions disabled, but the problem still occurred.
VS Code version: Code 1.78.0 (252e5463d60e63238250799aef7375787f68b4ee, 2023-05-03T20:09:00.748Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: Yes
Remote OS version: Linux x64 5.13.0-44-generic
Remote OS version: Linux x64 5.13.0-44-generic
Remote OS version: Linux x64 5.13.0-44-generic
Remote OS version: Linux x64 5.13.0-44-generic
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
pyind779:30671433
89544117:30613380
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30730054
vsctsb:30705553
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30731395
pythonclientmv:30725892
fixshowwlkth:30730052

This is the file I tested: test.txt
And this is a screenshot:

If I delete 2000+ lines, it works properly

I think this is fixed now.


[DSIP-25][Remote Logging] Split remote logging configuration

Purpose of the pull request
resolve: https://github.com/apache/dolphinscheduler/issues/15774
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 39.67%. Comparing base (446f6ba) to head (082009a).
 Consider uploading reports for the commit c723337 to get more accurate results

Files
Patch %
Lines

...scheduler/common/config/ImmutableYamlDelegate.java
61.53%
10 Missing :warning:

...mmon/config/ImmutablePriorityPropertyDelegate.java
81.25%
3 Missing :warning:

...duler/common/config/ImmutablePropertyDelegate.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15826      +/-   ##
============================================
+ Coverage     39.65%   39.67%   +0.01%
- Complexity     5012     5018       +6
============================================
  Files          1349     1350       +1
  Lines         45613    45613
  Branches       4891     4869      -22
============================================
+ Hits          18090    18098       +8
+ Misses        25607    25599       -8
  Partials       1916     1916

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No decode deligate

Hi! i'm new to ubuntu and have been using ubuntu 20.04, with i3 on zsh. I use the gnome terminal. It'sworked perfectly fine up until about a week ago, I have zero clue what could have gone wrong, anyone have any ideas? This is the output i get whenever
I try to run the 'wal -i' command.
[I] image: Using image hotline-miami.jpeg.
[I] colors: Generating a colorscheme.
[I] colors: Using wal backend.
convert: no decode delegate for this image format JPEG' @ error/constitute.c/ReadImage/562. convert: no images defined txt:-' @ error/convert.c/ConvertImageCommand/3285.
Traceback (most recent call last):
File "/home/codemeatloaf/.local/bin//wal", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/pywal/main.py", line 208, in main
parse_args(parser)
File "/usr/local/lib/python3.8/dist-packages/pywal/main.py", line 163, in parse_args
colors_plain = colors.get(image_file, args.l, args.backend,
File "/usr/local/lib/python3.8/dist-packages/pywal/colors.py", line 144, in get
colors = getattr(backend, "get")(img, light)
File "/usr/local/lib/python3.8/dist-packages/pywal/backends/wal.py", line 86, in get
colors = gen_colors(img)
File "/usr/local/lib/python3.8/dist-packages/pywal/backends/wal.py", line 41, in gen_colors
raw_colors = imagemagick(16 + i, img, magick_command)
File "/usr/local/lib/python3.8/dist-packages/pywal/backends/wal.py", line 19, in imagemagick
return subprocess.check_output([*magick_command, img, *flags]).splitlines()
File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['magick', 'convert', '/home/codemeatloaf/pictures/Wallpapers/hotline-miami.jpeg[0]', '-resize', '25%', '-colors', '16', '-unique-colors', 'txt:-']' returned non-zero exit status 1.

I am on windows 10 64bit PC.
Below is the similar kind of issue I am facing.


Ability to customize arrow icon in SubmenuButton

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Currently, there's no easy way to override default arrow icon in SubmenuButton. The leadingIcon and trailingIcon are custom widgets that can be added before and after content of this button, but the arrow icon will always be there.

In menu_anchor.dart we can see that this arrow icon will be always be visible if the orientation is vertical(showDecoration and hasSubmenu will be true)
        if (showDecoration && hasSubmenu)
          Padding(
            padding: EdgeInsetsDirectional.only(start: horizontalPadding),
            child: const Icon(
              Icons.arrow_right, // Automatically switches with text direction.
              size: _kDefaultSubmenuIconSize,
            ),
          ),

As a workaround I had to wrap SubmenuButton in Stack, pass SubmenuButton.styleFrom(iconColor: Colors.transparent) to SubmenuButton's style and position my own icon in place of the arrow icon.
Proposal
It would be really nice to have a way of customising this arrow icon. My proposition is to have an optional builder in SubmenuButton.
preferredSize would be the _kDefaultSubmenuIconSize to know the size of the default icon.
preferredColor would be added for convienience and will indicate the color that the default arrow icon would have(from theme data)
To determine other things like directionality we could get it through context
SubmenuButton(
  customArrowIconBuilder: (BuildContext context, double preferredSize, Color preferredColor) {
      return MyCustomArrowIcon(preferredSize, preferredColor);
  },
   ...
)

There is a partial patch in https://github.com/flutter/flutter/pull/132899 that somebody could take over to implement this.

I would like to take this up!

any update


RateLimiting – send request headers upstream

Title: Rate Limiting Server can send HTTP request headers upstream
Description:
Envoy issue #3555 1 added support in the Rate Limiting Service's proto for sending Response HTTP Headers to the invoking client (similar to, say, Twitter's API of x-rate-limit-limit: 100).
The intention of this issue is to have similar support in the Envoy rls.proto except specify a list of headers which Envoy will send to the Upstream server.
Why is this useful?
Sending request headers to the upstream server is useful when adding Rate Limiting to a system which already has its own Rate Limiting implementation.  To gradually move out of the old rate limiting system to the new, the upstream service can be configured to switch off its rate limiting when it receives a request header from Envoy's RLS.  A request that goes through Envoy's RLS would send a request header, say, x-rls-rate-limited: true, which Envoy would forward to the upstream server.  The upstream server would not do its own internal rate limiting when this header is present.
[optional Relevant Links:]

Similar in spirit to #3555.
request to raise this as an issue was discussed in the envoy-users list.  Link

I would like to take this up, can we reopen this ?

@nandu-vinodan done. Please send the PR when it is ready. Good luck!

@alyssawilk this issue may be closed.  it was fixed by #8565.


View About the Instructors page

Acceptance Criteria:
I can:
-Navigate to this page according to the site map url
-See that the page looks like the mockup
-View the page at different resolutions and the content is laid out logically


Add thumbStyle & trackStyle

Describe the Feature
Add support for thumbStyle to allow customizing the thumb shape, colour and size. Relying on an image per style can be quite limiting for simple changes. If implemented, this could make thumbTintColor obsolete.

The thumb size for android is tiny. Do we have any workaround?

Yes, please

+1

This feature is really important as Android a a very small thumbsize compare to iOS. With this, we will be able to resolve this.

I would advice to switch to a full RN implementation instead of fighting to maintain 3 implementations... There is this project that does it, but if you really want to keep this project and maintain it, you can check the source code.

Hello again, @Sharcoux!
Luckily I'm totally happy with maintaining not three, but four different implementations. I consider it not only an opportunity to keep on learning and solving problems, but what's most important as something we (me and all amazing contributors who made their commits so far) do for users and the community.
The beauty of Open Source is the free choice you can make, considering all pros and cons of each library out there, or you can make a contribution to this library if you see areas that can be improved.
But I will ask you to stop disputing this library, or disputing a reasoning behind it's implementation.

Hi @BartoszKlonowski
If the development is back on, I'll be more than happy to help, and I can update the web implementation. The issue with the current lib is that it is benefitting from the name "react-native-community", giving a false "official" impression to the newcomers, while its maintainance was a bit too light compared to the amount of users it dragged. I don't see the point of effort multiplication and my only goal is that React Native gets a good slider component that serves as reference, whoever maintains it, because it's a basic component and the popularity of a technology depends on its ability to be easy to use for new devs joining the party
Also, while the current issue is not addressed, provided the amount of people that asked for it, I think that it's important to, at least, propose them an alternative, until it is available here.

@Sharcoux The development of this library continues, please look at the commits made to this repository before posting statements that can be considered offending by owner, maintainers or all contributors who put their time into this library.
Again: I ask you to stop. Contributions and development proposals and ideas are most welcome. False accusations (about false formality, lack of development) and criticism is not.

I checked the commits, and I saw fixes on the web and windows versions, versions bumps, doc and types fixes, some very small fixes on Android and iOS, and I see some issues opened 4 years ago, rated by 80 people (and many others on the other issues that you closed), that are not addressed or being worked on. So, on my definition, the android and ios parts don't look actively maintained. This is why I suggested abandoning them. If I'm wrong, then I don't understand how an issue like this one can be opened for 4 years. This is not a criticism, because you owe nothing to no one, and that's totally fine. You guys give the time you can to the project and that's already great.
Now, I would not react like that to any other project, but this specific project presents a problem because of the name "react-native-community" it is published under. It is not maintained by the react-native-community group of GitHub, that contains 60 maintainers, and you made yourself quite clear in this thread that you were the one taking the decisions here.
These are just facts. I'm not complaining or asking you to do anything. The only thing is that, as a lot of newcomers are coming here because of the name the project is published under, then the projects inherits a part of responsibility toward the React Native ecosystem itself, that goes beyond this project. And I think that it's fair and important to advise those newcomers on how to solve the problem they meet.
Don't forget that one of the key value of Open Source is also attribution, and the current project presents an attribution problem that I don't blame you for, but that needs to be considered.

Look, I don't get why you seem to take as a personal offense what I'm pointing out.

There are some important issues like this one opened for 4 years
The package is incorrectly published under react-native-community namespace for history reasons

Those are facts and there is nothing personal or aggressive about that. There is no criticism either. I'm not looking for a fight with you.
Maybe an alternative solution should be to deprecate the @react-native-community/slider package and publish it under the callstack namespace?

This feature is really important as Android have a very small thumbsize compare to iOS. With this, we will be able to resolve this.

For programmers who don't know UI design, use thumbImage as an alternative, too ugly. 😭

This feature is really important as Android have a very small thumbsize compare to iOS. With this, we will be able to resolve this.

I think so too

any update on this?

any update?

any update the thumb is barely visible on Android?

please

More people are interested here 🥺

+1

+1

这么久了为何 还没有添加，预览的时候Android 上面显示的不正常，只有打包后才能显示正确的尺寸，iOS预览和打包后都是一致的，作者是开发iOS的？

Hello any updates

help

help


FE: Support for Gravatar images for sender/from field

Requirementes

Display Gravatar images for first from e-mail address

https://en.gravatar.com/site/implement/images/
Relates to:

#230


ra_lsp_server thread '' panicked at 'internal error cycle detected'

full output:
thread '<unnamed>' panicked at 'Internal error, cycle detected:

__SalsaDatabaseKey { kind: DefDatabaseStorage(compute_crate_def_map(CrateId(167))) }
', <::std::macros::panic macros>:5:6
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:77
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1057
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1426
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:204
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:224
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:472
  11: rust_begin_unwind
             at src/libstd/panicking.rs:380
  12: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:334
  13: ra_hir_def::db::crate_def_map
  14: ra_hir_def::nameres::collector::collect_defs
  15: ra_hir_def::nameres::CrateDefMap::compute_crate_def_map_query
  16: salsa::runtime::Runtime<DB>::execute_query_implementation
  17: salsa::derived::slot::Slot<DB,Q,MP>::read_upgrade
  18: salsa::derived::slot::Slot<DB,Q,MP>::read
  19: <salsa::derived::DerivedStorage<DB,Q,MP> as salsa::plumbing::QueryStorageOps<DB,Q>>::try_fetch
  20: ra_hir_def::db::crate_def_map
  21: ra_hir_def::nameres::collector::collect_defs
  22: ra_hir_def::nameres::CrateDefMap::compute_crate_def_map_query
  23: salsa::runtime::Runtime<DB>::execute_query_implementation
  24: salsa::derived::slot::Slot<DB,Q,MP>::read_upgrade
  25: salsa::derived::slot::Slot<DB,Q,MP>::read
  26: <salsa::derived::DerivedStorage<DB,Q,MP> as salsa::plumbing::QueryStorageOps<DB,Q>>::try_fetch
  27: ra_hir_def::db::crate_def_map
  28: ra_hir::source_binder::SourceBinder<DB>::to_module_def
  29: ra_hir::source_binder::SourceBinder<DB>::find_container
  30: <T as ra_hir::source_binder::ToId>::to_id
  31: ra_hir::source_binder::SourceBinder<DB>::find_container
  32: ra_hir::source_binder::SourceBinder<DB>::analyze
  33: <once_cell::unsync::Lazy<T,F> as core::ops::deref::Deref>::deref
  34: ra_ide::inlay_hints::inlay_hints
  35: std::panicking::try::do_call
  36: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:86
  37: ra_db::CheckCanceled::catch_canceled
  38: ra_ide::Analysis::inlay_hints
  39: ra_lsp_server::main_loop::handlers::handle_inlay_hints
  40: <F as threadpool::FnBox>::call_box
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

branch: master
toolchain: nightly-x86_64-unknown-linux-gnu
rustc: rustc 1.42.0-nightly (689fca01c 2020-01-17)

@matklad sorry for the late, the example in question is the following crate:
https://github.com/alex179ohm/nsq-rust/tree/consumer
just change the Cargo.toml with the following:
[package]
name = "nsq-rust"
version = "0.1.0"
authors = ["Alessandro Cresto Miseroglio<EMAIL_ADDRESS>edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
async-std = "1.4.0"
async-tls = "0.6.0"
futures = "0.3"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
hostname = "0.2"
byteorder = "1.3.2"
bytes = "0.5.3"
log = "0.4.8"
rustls = "0.16"

[dev-dependencies]
femme = "1.3.0"
nsq-rust = { path = "./" }

and the rust-analyzer crash.
btw, the example I've posted in the previous comment seems working as expected to me too, I wrongly supposed that just adding the same crate to the dev-dependencies should crashing rust-analyzer, but seems not the case. sorry :)

@alex179ohm  the linked repo is now gone, do you think you could check if this still happens and maybe prepare a test case?
(Marking S-actionable, if you look at this in the future and the OP hasn't answered, ping me so we can close it).

@alex179ohm  the linked repo is now gone, do you think you could check if this still happens and maybe prepare a test case?
(Marking S-actionable, if you look at this in the future and the OP hasn't answered, ping me so we can close it).

No update, so closing

The repo seems to be back now (?). It doesn't build, but we don't seem to panic, only:
[ERROR project_model::workspace] cyclic deps: nsq_rust(CrateId(303)) -> nsq_rust(CrateId(303))


Edit Location?

How to edit GameObject Location

I assume you're talking about GameObject transform position? The easiest way to do this is to click view data on the gameobject, open the first component (which is always transform), right click on Transform Base and click Visit Asset.

Then back in the info window, click export dump, save it somewhere, edit the position with a text editor, and import dump.

Then save like normal and it should have moved the GameObject's position.

Awesome! Thanks! 🙏


Master

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jithulvinod sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


scripts cleanup

OPS Build status updates of commit 2f0ecf5:
:clock10: Preparing: average preparing time is 1 min(s) 3 sec(s)

OPS Build status updates of commit 2f0ecf5:
:clock10: Incremental building: average incremental building time is 33 sec(s)

OPS Build status updates of commit 2f0ecf5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/scripts/concepts/best-practices.md
:white_check_mark:Succeeded

BingAds/scripts/concepts/iterators.md
:white_check_mark:Succeeded

BingAds/scripts/concepts/selectors.md
:white_check_mark:Succeeded

BingAds/scripts/examples/adgroups.md
:white_check_mark:Succeeded

BingAds/scripts/examples/ads.md
:white_check_mark:Succeeded

BingAds/scripts/examples/budgets.md
:white_check_mark:Succeeded

BingAds/scripts/examples/campaigns.md
:white_check_mark:Succeeded

BingAds/scripts/examples/keywords.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupBuilder.md
:white_check_mark:Succeeded

BingAds/scripts/reference/AdGroupSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/BingAdsAccountStats.md
:white_check_mark:Succeeded

BingAds/scripts/reference/BudgetSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/CampaignSelector.md
:white_check_mark:Succeeded

BingAds/scripts/reference/Stats.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


132 documentation users to members migration

Motivation
Which issue does this fix?
Fixes #132
Added documentation includes

supported package version update to 26.0.1
instructions related to live site user migration to xbk members

FYI: my local VS code autofixed some markdown formatting, polluting the changeset slightly. I marked relevant added stuff with comments.
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[X] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

Reivew notes:
General - fix spacing in bullet lists (caused by the VS code autofix)
Migration.Toolkit.CLI/Readme.md

Migration details for specific object types > Members

"MemberIncludeUserSystemFields setting" > "MemberIncludeUserSystemFields setting configuration option" ? That's the terminology I used for this in other locations
"--custom-modues" typo

Configuration

broken configuration option table after 'MemberIncludeUserSystemFields' ! (malformed markdown?)
MemberIncludeUserSystemFields - "You exclude specific fields from the migration, by removing them from the setting." > "Exclude specific fields from the migration by removing them from this configuration option."
I think it would be good to add MemberIncludeUserSystemFields to the Example code

@DavidBKentico Fixed all review issues (you can check the individual commits)

Thanks, everything looks good now. Closing (I hope).


Fix intermittent build failures

Description
This PR fixes intermittent build failures which happen due to parallel test runs. As of now port 9399 is being used in NetworkerClientTest & VeeamClientTest. This PR updates the port in NetworkerClientTest from 9399 to 9400.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[x] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

Could we somehow use random/available ports, there has to be a way to do that @vishesh92 ?

Can you create a common util similar to the following to find a free port:
try (ServerSocket socket = new ServerSocket(0)) {
            socket.setReuseAddress(true);
            return socket.getLocalPort();
        }

Can you create a common util similar to the following to find a free port:
try (ServerSocket socket = new ServerSocket(0)) {
            socket.setReuseAddress(true);
            return socket.getLocalPort();
        }

+1
btw, can we specify a port range ?

@vishesh92 will you be adding suggested changes in this PR or can it be done as a separate PR?

@shwstppr Let me make the change in this PR itself.

@kishankavala @shwstppr @DaanHoogland I have made the changes to randomly select a port.

Can you create a common util similar to the following to find a free port:
try (ServerSocket socket = new ServerSocket(0)) {
            socket.setReuseAddress(true);
            return socket.getLocalPort();
        }

+1
btw, can we specify a port range ?

There are options to specify a range, but didn't look efficient to me.
org.springframework.util.SocketUtils#findAvailableTcpPort(int, int)
Its deprecated as well.

@vishesh92 cc @DaanHoogland @kishankavala @weizhouapache I propose we move forward with this for now to address build failure and maybe create an issue or PR with more holistic changes to make a common util class to fetch an available port for different tests (in some range). Does that work?

@vishesh92 cc @DaanHoogland @kishankavala @weizhouapache I propose we move forward with this for now to address build failure and maybe create an issue or PR with more holistic changes to make a common util class to fetch an available port for different tests (in some range). Does that work?

fine with me . let's use port 9400 for now.
if the port is used in a day in the future, we can use another port, it is not an issue.


Flag storage that is not available under private mode

When the user is running in private mode then it can be tricky to choose the right storage tool to use.
For example

In IE10+ & edge you don't have the global indexedDB context
In Firefox you can't use indexedDB bugzilla #781982
In Blink you can't use either persistent or temporary filesystem
In Safari you can't use any client side storage except for cookie

I think it would be useful to mention this under Notes. in most cases you can use localStorage except from safari

comments like +1 me too will be deleted▼Vote with reaction▼

+1

+1

+1

Importing from #2944:
IndexedDB is available in private/incognito mode in both Chrome and (soon) Firefox. I would like to indicate the lack of support in older versions as well as Edge and Safari.
I personally would prefer to switch everything to partial support along with a note tag. Is this the preferred way to go or should I just add a note tag? I'm also worried about adding a note tag to virtually every browser/version combo....

@jimmywarting I think this needs to be broken into tickets for each storage type.

Move IndexedDB to #3004?

For localStorage, I think you are basically proposing moving many of the "known issues" to a flag....


Require named arguments for java defined annotations

Closes #20554

It seems that this is breaking some code (as expected), but should we make it a warning in 3.6.x and an error in >= 3.7.0 ?


Default style to appear even without any data

Hi demarchisd
I want that the default style to appear even without any data, i.e. the date and time header and the description should appear even if the is no data:
My code:
var newData = [
{
description: '',
activities: traveldata
},
	{
		description: '',
		activities: staydata
	},

	{
		description: '',
		activities: activitydata
	},
];

	var options={
      data: newData,
      style: {
      months: ['Jan','Feb','Mar','April','May','Jun','Jul','Aug','Sept','Oct','Nov','Dec'],
      activityStyle: {
        'Activity': { color: "rgb(238, 129, 0)", height: "26px" },
         'Travel': { color: "rgb(32, 65, 149)", height: "26px" },
        'Stay': { color: "rgb(165, 39, 20)" , height: "26px" }
      },
      showDateOnHeader: true,
      dateHeaderFormat: function(date)
      {
        var days = ['Sun','Mon','Tues','Wed','Thur','Fri','Sat'];
        var months = ['Jan','Feb','Mar','April','May','Jun','Jul','Aug','Sept','Oct','Nov','Dec'];

        return days[date.getDay()] + ", " + date.getDate()  + months[date.getMonth()] +  date.getFullYear();
      },
	  hourWidth: 35
      //thresholdHeight: "15px",
      //thresholdColor: "#000000"
    }

  };
  $('#chart').stackedGantt(options);

The Gantt chart should appear with date and description even if traveldata, staydata, activitydata have no data in them.
Thanks and Regards,
Vaibhav
+91<PHONE_NUMBER> (India)

Hello Vaibhav!
I'm glad you're using the StackedGantt :)
I fixed the bug and pushed the changes to the master branch. Please try using the new version. Also, take a look at the new properties defaultBeginDate and defaultEndDate in style option (they're not mandatory, but you could customize it if you'd like to).
Best regards

Thanks Demarchisd,
This is working wonderfull for me and all the issues for now are resolved.
Thanks for all your support all this while.
regards,
Vaibhav.

Thanks!


Consolidating node operations

Hello,
Right now DOM-related operations are scattered all over: in ./node.js, ./element.js, ./api/node.js, ./api/children.js and sometimes in core plugins (think unwrap, insertAfter, hasContent, etc.). Plus ./api/node.js defines a class with a link to a DOM node: this can be a source of memory leaks if objects are never released (in closures for instance).
I could survey the code, make an inventory of all DOM-related operations and put everything into a single AMD module (./node.js). This would increase consistency, remove redundant code, which means more optimized code and an overall happier browser :-)
How does that sound?

Sounds good to me!

@hmgibson23 great! I'm on it.

This is going to be a biggie, I'll split this into multiple PRs for everyone's sake :-)

Are we okay to close this one now?

Yes of course.


Fix back mock

Description

Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[ ] I've read the CODE_OF_CONDUCT.md document.
[ ] I've read the CONTRIBUTING.md guide.
[ ] I've updated the code style using make codestyle.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.

btw, @Hartorn I think using pytests monkeypatch  would be more convenient because you don't have to specify a patched element as a string, but as a module, so in case of module renaming we could've spotted issues earlier


OpenTelemetry Support

As a user of Dynatrace, I would like that krakend-ce to support OpenTelemetry exporter integration so we can instrument, generate, collect, and export telemetry data (metrics, logs, and traces) to Dynatrace (or other OpenTelemetry supported platform).
It will also be nice if, where possible out-of-the-box instrumentation libraries will be supported (see https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation).

we are waiting for the project to be stable, complete and mature before switching from opencensus to opentelemetry, but it's in our roadmap.
I'm keeping this open until we switch
cheers!

Opentelemetry is stable now right ?

It is for traces (which is why I'm looking into it)

Unfortunately, traces are a third of the requirements of this issue. This component will likely require much effort, and I don't see it implemented in CE in the short term, as OpenCensus is already providing all the functionality (and is stable). Expanding the library to onboard more providers is not a priority of the open-source product.

Hi @alombarte , according to https://opentelemetry.io/blog/2023/sunsetting-opencensus/
Make sense to add OTEL support for these project.
Do you have any plans for it now?

@alombarte @kpacha Is open-telemetry support in this year's roadmap or has any work started? If not, I can start working on adding Opentelemetry support to this project.

Hi @Harnoor7, any help is welcome.
This year's roadmap has only two months left, so there won't be OpenTelemetry in 2023. We are about to release KrakenD 2.5, and there won't be an eventual KrakenD 2.6 until 2024.
The deprecation of OpenCensus, while OTEL does not provide (even close) the same level of stable functionality, is something I personally don't understand, but it is what it is, and we will write a new component for OTEL.
I am reopening this task for reference, but the development will continue here: https://github.com/krakend/krakend-otel
Thank you

Currently, the opentelemetry otelhttp package library which is equivalent to the opencensus ochttp library (used in Krakend) does not expose client-side metrics which is used in Krakend here. I was working on replacing ochttp with otelhttp but now will have to wait until client-side metric capture support is added as part of this PR.

@Harnoor7 , there is work in progress to support instrumenting the client with opentelemetry. That support will be added in a separate library, so it can be used not only in krakend-ce but also in other projects. That code will be hosted in this repo: https://github.com/krakend/krakend-otel . So, I would advice you to not move forward on adding that support until we have some basic stable implementation in that repo. You can star / watch the repo, so you get notified when we have some working implementation there.

@dhontecillas Thanks for the update. I also did some implementation for Opentelemetry integration, Will wait for your implementation to complete then. If you don't mind, Possible to share a rough timeline as to when we can have a working implementation?

@Harnoor7 we are actively working on it, but given that the end of the year holidays are so close, I would say that the PR in this repo will be ready by the first half of January. And it might get merged, and used in KrakenD Community in the next release.

Thanks, This helps!

Thanks, this helps!

Hello @yaronp,
With the last release, you should be able to integrate Dynatrace on KrakenD. Here are the docs: https://www.krakend.io/docs/telemetry/opentelemetry/
Please share any follow-up snippets of code, recommendations, or guidance you have once you implement it. I am closing this task.
Thank you!