fix: allow import of node builtins in routes

this adds polyfills for native node modules for the browser. These don't end up being shipped in the bundle if you don't use them outside your loaders / actions, but it prevents nasty failures at runtime caused by esbuild not knowing it can tree shake out those imports.

Prevents errors such as: https://github.com/remix-run/remix/issues/1618

Two things:

I believe this will prevent people from using their own path shims in browser builds because instead of looking in node_modules for the shim this plugin will use an empty module instead
I believe what we really want instead of ignoring builtin modules is to mark them as sideEffects: false so that esbuild is able to remove their imports

Also, are we already using this plugin on the server build? I couldn't figure out why this PR didn't include an import for the new plugin.

Two things:

I believe this will prevent people from using their own path shims in browser builds because instead of looking in node_modules for the shim this plugin will use an empty module instead
I believe what we really want instead of ignoring builtin modules is to mark them as sideEffects: false so that esbuild is able to remove their imports

Also, are we already using this plugin on the server build? I couldn't figure out why this PR didn't include an import for the new plugin.

It's only for cloudflare. It's to better support that ecosystem as many packages will run there with these shims that can't currently. Looking at things the community is doing like using prisma on CF, they're having to add either this plugin or switching to rollup / webpack for the second build step to add this behavior. Since we are trying to eliminate that second build step we need a solution for utilizing packages like that out of the box.
I don't think we have a way for people to provide a path shim in the browser as of now do we? Even so, this could just provide it for them. It ultimately uses rollup-plugin-node-polyfills under the hood.

Closed in favor of https://github.com/remix-run/remix/pull/1764 that has tests.


Custom html template

Hello,
I need to use a custom html template for serving the pages, is this possible?

What makes it custom?

It is a very large template that comes from a CMS and it needs to be fetched on every request.

The only possibility to use a custom template is through the html.head, html.bodyStart and html.bodyEnd parameters (see the README)

You should consider this option

No, I guess I won't

and your bad attitude :)

Oh and you could stop judging people by your own standards as well. Or do you think the world must be the way you want it to be just because you want it to?


On VS-Table not rendered expanded slot

MacOS Big Sur
Node.js 14.8.0
Vuesax 3.12.2
Browser Firefox Developer edition 84.0b7
npm 6.14.8

Expandable Data is not rendered in my project and to in your documentations.
Content of expanded slot after expand is empty - see on image...
Please check component vs-table ... expandable TR .. thanx

I'm having the same problem.

Yep. Me too

me too

same problem here.
Is this related to new mac version of MacOS Big Sur?

got the same issue

got the same issue

Same issue, while rolling back to 3.11.17 vs-tooltip and select boxes are not working properly

same here

is it solved?


🚀 Feature: Hydration should try npm and git config for email

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Right now, when running the hydration script, if an email address isn't provided with --email, a fallback from the existing package.json "author" is tried:
https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/6a0d42d7f07e3a70c7b0dd239c7431c58f43bd69/src/hydrate/values/getHydrationDefaults.ts#L29-L32
However, not all packages include an email in their author. Some just provide it as a string like "author": "Josh Goldberg".
In this case, it'd be nice to try, in order:

The user's npm account (re-using logic from getNpmAuthor.ts
The user's Git config (git config --get user.email)

Additional Info
Hydration is explained here: https://github.com/JoshuaKGoldberg/template-typescript-node-package/tree/6a0d42d7f07e3a70c7b0dd239c7431c58f43bd69#repository-hydration

On it


Fix Format On Save

I often get issues with vscode 'format on save' messing up my code like in the screenshot:

I suspect that this is usually the case when somewhere in the file I have a method with incorrect and/or commented out code. The latter gets reformatted multiple times to a point where it's so garbled I just remove it. But then during build I notice a line like re; and can't get rid of it anymore (removing everything, saving, undoing, and then saving again sometimes helps).
Cc: @IwanKaramazow @ulrikstrid

Another issue that is exclusively related to format-on-save:
Start with this file:
type t = unit;

/* lll} */
let f = () => ();

Then enter an additional newline above the comment like this:
type t = unit;

/* lll} */

let f = () => ();

Then save to trigger a reformat. Repeat over and over again. You'll notice at one point the file becomes "corrupt" in a sense. It will reformat to:
type t = unit;

/* lll} */

let f = () => ();

And it will get stuck like this. Even if you delete the newline between the comment and the let f, it will be retained on reformatting.
This only happens with format on save. @freebroccolo do you have any pointers about where to look to fix this issue? What's different about format on save that doesn't happen when I explicitly format then save (two separate invocations) which doesn't have this issue?
Is there at least a way to disable format on save in the vscode plugin until we figure this one out?

@jordwalke it is possible to disable format on save globally: just open the vscode settings page and type "format" and it should show up as one of the first few options. I think that setting can be made local to a language mode too but I haven't tried it.
As for what is causing this behavior I'm not sure. It is probably something going wrong with the way the Synchronizer component (https://github.com/freebroccolo/ocaml-language-server/blob/master/src/bin/server/session/synchronizer.ts).

Thanks. I’ve disabled format on save but I would like to disable it entirely at the language server level because we don’t have a good way to ensure it’s disabled and people just assume the entire lsp is fragile when it’s mostly just this one feature.


Error loading syntax file

A couple of days ago the package does not work anymore I get this error message:

Error loading syntax file 'Packages/Laravel Blade Highlighter/blade.sublime-syntax': Apparent recursion within a with_prototype action: 25000 context sanity limit hit

I have found that the last working build of the dev version of Sublime Text is 3154, released November 11th, 2017. The current version, as of this comment, is build 3160.

I have the same problem. Is there any fix?

I also have this problem and just started recently as well.

I uninstalled, might have to find a fix ourselves..

seems this won't be fixed until next sublime stable release :( uninstalled

This the first time I have seen an error without any reason it was working why it stopped working I mean the package didn't get updated for a long time and sublime text didn't get updated also. is it possible that another package causing this problem??

Removing CSS3 package fixed the problem #143

Had the same problem after upgrading ST to build 3170.
Disabling the CSS3 package fixed the problem.

Fix problem but not highlighter after an inline style attribute


[BugFix] Fix pending queryeis when group.concurrency_limit is null

Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:disappointed: fail : 0 / 2 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/scheduler/slot/SlotRequestQueue.java
0
2
00.00%
[145, 146]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Why rboot need up to addr 0x2000?

Hello Raburton,
Why have you specify that rboot is placed between addr 0x00000 and 0x2000?
Ok for addr 0x0000 but the bootloader and the structure fo rboot config don't really need of all that?

rBoot needs about half a sector. The config needs very little space, but
needs to be in a separate sector so when it is rewritten there is no risk
of losing the bootloader itself.
On 26 Apr 2017 9:03 am, "daffysub"<EMAIL_ADDRESS>wrote:

Hello Raburton,
Why have you specify that rboot is placed between addr 0x00000 and 0x2000?
The bootloader and the structure fo rboot config don't really need of all
that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/raburton/rboot/issues/34, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAadh85ky1kSQ2qXnPST9JbAhS06m1utks5rzvpCgaJpZM4NIgJl
.

OK Thank you for your response.


does hive work with flutter web in edge?

I added hive to my flutter web app, but now it seems that edge has trouble loading the app.
has anyone ever tried hive with flutter web in the edge browser?

I just ran a couple of tests, and it seems that hive breaks flutter web with edge, when I run
await Hive.openBox('claimq');
my app will not load in edge


travis-ci.org will be completely closed by December 31, 2020, so you need to move to travis-ci.com

@Qmando
travis-ci.org will be completely closed by December 31, 2020, so you need to move to travis-ci.com.
Travis CI will continue to offer a free tier for public or open-source repositories on travis-ci.com and will not be affected by the migration.
Migrating repositories to travis-ci.com
https://docs.travis-ci.com/user/migrate/open-source-repository-migration
There are six notes below.

Build number is reset to 0
Builds on travis-ci.com start with a clean build history (= build history is not inherited)
History on travis-ci.org remains on travis-ci.org
Environment variables are not migrated
Environment variables need to be reset (at travis-ci.com), and if the encrypted variables are written in .travis.yml, they are re-encrypted (created on travis-ci.com) Need to be fixed to the reset variable)
The repository settings enabled push, pull builds, auto-cancellation, etc. are not migrated.

@Qmando
Currently, the Travis CI job is running and testing is running at the time of the pull request, but it seems that the job is not completed normally. When I contacted Travis CI support, I got the following answer:

If we see a job stuck in a queue for more than 16 hours, we will review this on a case by case basis and possibly cancel the job to ensure resources are not being reduced across the platform. You may want to consider migrating across to .com sooner rather than later, or consider building at a quieter time of the day if remaining on .org for a while longer.

@Qmando
Are you ignoring me?
Or are you considering a response?


[New Sheet] Pirate Borg

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: Pirate Borg

The publisher of this game is: Free League

The name of this game system/family is: Pirate Borg

[x] I have followed the Character Sheets Standards when building this sheet.

[x] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Character Sheet Info Roll20 Internal Use only.

Hello @sneat!
This looks good to be merged however we noticed that in your sheet.json the css file name is pirateborgsheet.css but in the sheet.json you refer to it as pirateborgstyle.css.  Once you get that fixed, we can get this merged. Thanks!

Updated, thanks @kfroll20


feat: add code action for the ParenthesesOnZeroArityDefs check

https://github.com/elixir-tools/credo-language-server/assets/929818/b471c264-6644-4ba9-9ad4-4c64d349117b

I have that one comment that I think needs addressed, and I pushed up some superficial changes that weren't worth leaving comments for

no problem with changes, I just followed the way it was coded for the ModuleDocFalse.


Migrate README.md to Wiki

Not needed right now. README.md and ~/docs folder will work fine for our purposes.


Performance issue

Since 92fa70c the freshplayerplugin turns very heavy and slow, the performance goes down very notoriously. i guess it has something to do with the new plugin weight, from 4.7MB in a16f3bf to a 18.xMB in the 2415749.

Size increased because ANGLE source was added. I use shader translator to convert shaders from OpenGL ES 2.0 to desktop OpenGL 2.0. Maybe that's overkill, but rather than inventing own translator, it's better to take ANGLE, which was certified for OpenGL ES 2.0 support.
First commit you mentioned (92fa70c7ce8db21b2d4a11910e205585c9ee6d77) is source code itself, it's not yet linked at that point. But later patches do add changes to 3d-related code.
Does it really slows down? As far as I know, Flash doesn't use too many shaders, so overhead should be negligible. What video adapter do you have, again? (I need to write it down; always forget to do it).

i have an ATI 5670.
and the performance issue i notice it mostly in flash games, and HD videos too.

I've disabled ANGLE in 6d347a40e7f464ee889c0fa513b42de3bc0c8dc4. It doesn't solve issue with nVidia cards, so there's no reason to keep it enabled. (It still can be enabled by configuring with -DWITH_GLES2=0)

thank u (Y)

After I tried fgrlx, I need to ask. Do you have working 3d acceleration in freshplayerplugin on fglrx? Looks like my setup is missing GLX_ARB_create_context, GLX_ARB_create_context_profile, and GLX_EXT_create_context_es2_profile. If native GLES2 is used, all those GLX extensions are essential, 3d context won't be created if any of them is missing.

how can i test that?

how can i test that?

Launch browser from terminal. You'll see warning about missing GLX_EXT_create_context_es2_profile if it's really missing. Also running glxinfo will print all available GLX extensions.

i'd launch the firefox from terminal, i run some facebook games, videos on youtube normal and HD, and the only message that i get from the beggining was this:

and im not sure if this is related to freshplayer or to my gtk theme.

console.warn: Ignoring preferences-branch (not a valid branch name)
>>> installPolicy shouldProcess() ...
NOT SANDBOXED
[fresh  4484] not implemented: PPB_OpenGLES2DrawBuffers(Dev);1.0
>>> installPolicy shouldProcess() ...
>>> installPolicy shouldProcess() ...
[fresh] [warning] ppb_var_var_to_utf8, 'var' is not a string, (0)
>>> installPolicy shouldProcess() ...
>>> installPolicy shouldProcess() ...
>>> installPolicy shouldProcess() ...
[fresh] [warning] ppb_var_var_to_utf8, 'var' is not a string, (0)
>>> installPolicy shouldProcess() ...
>>> installPolicy shouldProcess() ...
[fresh] [warning] ppb_graphics3d_create, some of GLX_ARB_create_context, GLX_ARB_create_context_profile, GLX_EXT_create_context_es2_profile missing

that is what i get from console.

ppb_graphics3d_create, some of GLX_ARB_create_context, GLX_ARB_create_context_profile, GLX_EXT_create_context_es2_profile missing

That line in output means, no 3d context is created, so all drawing including scaling, is done in software mode.

As long as shader translator is used, those extensions are not required. I tried to do so, and surprisingly, performance become worser than with software rendering (Radeon HD 7730M). Of course, CPU load is lower, about 60-80% versus 300-400% for software rendering, but it noticeably lags. I think it's about 10-15 fps. And 60-80% is still twice higher than with integrated intel videoadapter, which easily gives 60 fps.
I wish I know what's going on.


Schema for a com.twitter/lzo_raw_array

Name needs tweaking - but I'm talking about the Protocol Buffer array of Bytes. I think I've seen the Protocol Buffers IDL embedded in some Twitter code somewhere...

I think this was the embedded IDL you saw: https://github.com/twitter/elephant-bird/blob/94aa4a7dd250457bf231fdac6ab5e12a987263c0/core/src/main/java/com/twitter/elephantbird/mapreduce/io/SerializedBlock.java#L19-L23

That's the one!

Can we call Protocol Buffers ".../protobuf/..." similar to how Google do it https://github.com/google/protobuf


HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

Description of PR
TestFsDatasetImpl#testDnRestartWithHardLink is flapper:
[ERROR] testDnRestartWithHardLink(org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl)  Time elapsed: 7.768 s  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl.testDnRestartWithHardLink(TestFsDatasetImpl.java:1344)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

How was this patch tested?
Unit testing. The current flaky behaviour is easy to reproduce by running the test code twice as part of same test.
The resolution is to disable the detection as well as deletion of duplicate finalized replica by BlockPoolSlice instance.
When Datanode comes up, BPServiceActors handshakes to Namenode and tries to initialize Block pool and in the process, it tries to get VolumeMap using BlockPoolSlice instance. While doing so, reading replicas from cache fails and hence, the thread tries to add Finalized and RBW replicas to addReplicaThreadPool fork-join pool in order to build the map. This process also tries to identify if there exists any duplicate replica. For this particular test, sometimes this process can detect duplicate replica on /data2 while processing finalized replica of /data1. Hence, before we can confirm newReplicaInfo.getBlockURI() exists, finalized replica on /data2 might get deleted (rare and flaky case). Although the probability for the thread processing the identification and deletion of duplicate finalized replica to be faster than main thread is less, it cannot be avoided. Hence, we disable adding Finalized and RBW replicas to addReplicaThreadPool in BlockPoolSlice here and re-enable it only after we confirm the existence of newReplicaInfo on "/data2" ARCHIVE storage.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 45s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
16m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 11s

the patch passed

+1 :green_heart:
shadedclient
16m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
231m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

315m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 67947e04a1b9 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae4fbd19d641d748971f976aa6c3a7773d10902d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/1/testReport/

Max. process+thread count
3110 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  5s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
18m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 24s

the patch passed

+1 :green_heart:
shadedclient
18m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
318m 38s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

410m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux a4c0da14ca37 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae4fbd19d641d748971f976aa6c3a7773d10902d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/5/testReport/

Max. process+thread count
2698 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 28s

trunk passed

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 37s

trunk passed

+1 :green_heart:
shadedclient
19m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 49s

the patch passed

+1 :green_heart:
shadedclient
19m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
400m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

498m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.web.TestWebHdfsFileSystemContract

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestHDFSFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 36891b3c852a 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae4fbd19d641d748971f976aa6c3a7773d10902d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/4/testReport/

Max. process+thread count
2133 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 14s

trunk passed

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
19m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 45s

the patch passed

+1 :green_heart:
shadedclient
19m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
404m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

501m 40s

Reason
Tests

Failed junit tests
hadoop.hdfs.web.TestWebHdfsFileSystemContract

hadoop.hdfs.TestLeaseRecovery

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4849c85c7f25 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae4fbd19d641d748971f976aa6c3a7773d10902d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/3/testReport/

Max. process+thread count
1784 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 26s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
16m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
17m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
462m 11s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

550m 26s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.TestHDFSFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 15d85754f4af 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae4fbd19d641d748971f976aa6c3a7773d10902d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/2/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka @ayushtkn @jojochuang @tasanuma could you please take a look? Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 56s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  8s

trunk passed

+1 :green_heart:
shadedclient
16m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 241 unchanged - 3 fixed = 241 total (was 244)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  8s

the patch passed

+1 :green_heart:
shadedclient
16m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
248m 51s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

333m 27s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux de7642c3d999 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 65c59d6601a9946d87cd49675516123ccc1a4a80

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/6/testReport/

Max. process+thread count
3319 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani Thanks for contribution. I didn't reproduce it by running some times.
Could you please introduce to make TestFsDatasetImpl#testDnRestartWithHardLink fail by changing simple codes?
I want to dig it

@ferhui did you run test code twice as part of same test? I can reproduce this failure just by running
  @Test
  public void t1() throws Exception {
    testDnRestartWithHardLink();
    testDnRestartWithHardLink();
  }

Ideally, based on how the test is written, the test code is supposed to be idempotent but it is not because of the replica processing done by addReplicaThreadPool.

Also, in debug mode, I was able to reproduce the same flaky behaviour in single run (only one time). FYI @ferhui
Thanks

Thanx @virajjasani for the PR. I too tried to repro this by running twice couple of days back, but It didn't repro for me as well. Some OS specific? I am on MacOs, can try on Ubuntu if you say so.
Just to know, does the Jenkins also complains about this? Since you said it reproduces by re-runing the test. Again just asking is there a test-only fix possible, without going to Prod files,
I think this is from some recent code, can you loop in the original developer & the reviewer as well.

Thanks @ayushtkn.

Just to know, does the Jenkins also complains about this?

Yes, Jenkins does report this e.g https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
And I also tried to repro on Mac only. It was reproduced one time with single test run (debug mode) but simple rerun is always failing with the same issue.

Again just asking is there a test-only fix possible, without going to Prod files,

Sure thing, would be happy to fix this by tests only but given how replicas are built up by BlockPoolSlice instance after Datanode is restarted, I think it might be tough to achieve it.
FYI @LeonGao91, if you could also review, it would be great. Thanks

The only way we could avoid making changes in source code is by avoiding restart of Datanode as part of this test, however, confirmation of test results after Datanode restart is the primary purpose of this test, hence we can't even avoid restarting Datanode in the test IMHO.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 25s

trunk passed

+1 :green_heart:
compile
2m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 49s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
2m  4s

trunk passed

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 40s

trunk passed

+1 :green_heart:
shadedclient
24m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
1m 33s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 33s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 45s

the patch passed

+1 :green_heart:
shadedclient
25m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
391m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

511m 12s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestBlockTokenWrappingQOP

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy

hadoop.hdfs.tools.TestECAdmin

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.TestWriteConfigurationToDFS

hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 889f73ecc5d5 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 763f43cb14cf3385538e37f40cecc763c7450fa5

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/7/testReport/

Max. process+thread count
2495 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @virajjasani for reporting this issue!
Seems like this happens consistently when running the same test multiple times, but doesn't fail when running it the first time (happy case), like you mentioned, this can reproduce it consistently:
@Test
public void t1() throws Exception {
testDnRestartWithHardLink();
testDnRestartWithHardLink();
}
Based on this I am not sure if the root cause is the rare race condition you mentioned. I suspect it is due to the cache behavior when rerun the same code the replica loading changed a little bit.
I can spend some more time investigating in the next few days. Let's try to fix this in the unit test itself

Thanks for spending some time @LeonGao91. Although I understand we can repro it only when we run twice locally but Jenkins does report this as failure sometimes.
Please check:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Two additional recent flaky instances of this failure:

@virajjasani Yes, I just did some more research. Depends on the sequence of loading cache and constructing volume map, sometimes hardlink will just be removed by datanode restart. So the corner case that needs to be tested here is not guaranteed.
I think a less disrupting way to fix this is by controlling "deleteDuplicateReplicas" value in the BlockPoolSlice. We can disable this until the DirectoryScanner kicks in. Therefore we only need to add a VisibleForTesting method in BlockPoolSlice
  @VisibleForTesting
  void setDeleteDuplicateReplicasForTesting(boolean value) {
    deleteDuplicateReplicas = value;
  }

And in the test, we can do this
// In the beginning
        conf.setBoolean(
            DFSConfigKeys.DFS_DATANODE_DUPLICATE_REPLICA_DELETION,
            false);
...
// When testing DirectoryScanner should clean up the hardlink
        DirectoryScanner scanner = new DirectoryScanner(
            cluster.getDataNodes().get(0).getFSDataset(), conf);
        FsVolumeImpl volume = (FsVolumeImpl) cluster.getDataNodes().get(0).getFSDataset().getFsVolumeReferences().get(0);
        volume.getBlockPoolSlice(volume.getBlockPoolList()[0]).setDeleteDuplicateReplicasForTesting(true);
        scanner.start();
        scanner.run();

What do you think?

I see, yes this seems finer-grained control over the target we want to achieve, let me spend some more time with this and will make changes accordingly after verifying. Thanks @LeonGao91 for providing your viewpoint on this!

Depends on the sequence of loading cache and constructing volume map, sometimes hardlink will just be removed by datanode restart.

Exactly 👍

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 56s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 10s

trunk passed

+1 :green_heart:
shadedclient
16m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 14s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  6s

the patch passed

+1 :green_heart:
shadedclient
16m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
231m  9s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

316m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux eb4ed62f2b49 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 31cd896568bcd3f95e3cd6741dc2d4563ea8ab85

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/8/testReport/

Max. process+thread count
3081 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 41s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  5s

trunk passed

+1 :green_heart:
shadedclient
16m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  7s

the patch passed

+1 :green_heart:
shadedclient
15m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
231m 33s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

316m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 935d6934fa36 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf7dc937fb00691f74ca7a54292735d87dd8b7af

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/9/testReport/

Max. process+thread count
2938 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 17s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
18m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
19m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
350m 48s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

443m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9757ee312e51 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cf7dc937fb00691f74ca7a54292735d87dd8b7af

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/11/testReport/

Max. process+thread count
2140 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

thanks @virajjasani , looks good to me. Just leaving few nit comments.
@ferhui @ayushtkn Could you please take a second look.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 19s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 12s

trunk passed

+1 :green_heart:
shadedclient
16m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
16m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
229m 10s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

315m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f91c3af3b149 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8e1eab0b1cd4dddbddc9cea02a657c87bab2b9bb

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/12/testReport/

Max. process+thread count
3406 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m  7s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
17m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 50s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
16m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
243m 49s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

330m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e29d417400b5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f1f832b5116f6d356f83436f788f1080cdd0790a

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/13/testReport/

Max. process+thread count
3616 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

thanks @virajjasani , looks good to me. Just leaving few nit comments.
@ferhui @ayushtkn Could you please take a second look.

Thanks for the review @LeonGao91.
@ayushtkn @ferhui could you please take a look if you have some bandwidth? Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 33s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  4s

trunk passed

+1 :green_heart:
shadedclient
30m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 11s

the patch passed

+1 :green_heart:
shadedclient
30m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
435m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

550m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/14/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 206b96093af2 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8fcce65ab54f61a8d97adace65ea847df4d69bb0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/14/testReport/

Max. process+thread count
2575 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/14/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 38s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  7s

trunk passed

+1 :green_heart:
shadedclient
30m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

-1 :x:
javadoc
0m 20s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javadoc
0m 15s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
spotbugs
0m 15s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
5m 33s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 16s

ASF License check generated no output?

83m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/16/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 883a454c538e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8fcce65ab54f61a8d97adace65ea847df4d69bb0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/16/testReport/

Max. process+thread count
713 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/16/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 15s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 33s

trunk passed

+1 :green_heart:
shadedclient
37m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 43s

the patch passed

+1 :green_heart:
shadedclient
38m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
361m 57s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

497m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.TestHDFSFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/17/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 543350b07c13 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8fcce65ab54f61a8d97adace65ea847df4d69bb0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/17/testReport/

Max. process+thread count
2072 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/17/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  2s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 27s

trunk passed

+1 :green_heart:
shadedclient
34m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
34m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
517m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

640m  4s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.TestViewDistributedFileSystemWithMountLinks

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux be13ef196036 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8fcce65ab54f61a8d97adace65ea847df4d69bb0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/15/testReport/

Max. process+thread count
2855 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/15/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Recent QA failures are not relevant and majority are facing timeout issues, will take a look as part of separate Jira.

Thanks for the reviews @aajisaka @LeonGao91

Just to confirm, is this good to go?

+1 thanks Viraj

BTW, @virajjasani could you please change this PR title as the same as the title of HDFS-16213 ? Thanks

Sorry for late response, I'm too busy recently.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 13s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  6s

trunk passed

+1 :green_heart:
shadedclient
21m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 240 unchanged - 3 fixed = 240 total (was 243)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
21m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
229m 50s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

336m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/19/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3386

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d0aa77e16202 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6bfbb3071f187242989ba9631f65929b0d9d9553

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/19/testReport/

Max. process+thread count
3178 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/19/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Merged. Thank you @virajjasani @jojochuang @ferhui @LeonGao91


Bug report: Test Coverage not 100% with the latest code | when showSpinner is false

Priority
(Low) Something is a little off
Description
When running the test with the latest code, we are getting only 98% coverage. This happens only when you have your showSpinner as false.
Here is the result.

Steps to reproduce

Get the latest code
Run m365 cli config set --key showSpinner --value false
Run npm run build and npm run test
You will get only 98% coverage

Expected results
Expected to get 100% code coverage
Actual results
Here is the result after npm run test
Here is the result.

Diagnostics
N/A
CLI for Microsoft 365 version
v7.5.0 (Running from latest code base)
nodejs version
20.0.0
Operating system (environment)
macOS
Shell
zsh
cli doctor
➜ m365 cli doctor
authMode       : DeviceCode
cliAadAppId    : 31359c7f-bd7e-475c-86db-fdb8c937548e
cliAadAppTenant: common
cliConfig      : {"showHelpOnFailure":true,"helpMode":"options","prompt":true,"output":"text","autoOpenLinksInBrowser":false,"copyDeviceCodeToClipboard":true,"printErrorsAsPlainText":true,"showSpinner":false}
cliEnvironment :
cliVersion     : 7.5.0
nodeVersion    : v20.0.0
os             : {"platform":"darwin","version":"Darwin Kernel Version 23.2.0: Wed Nov 15 21:59:33 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T8112","release":"23.2.0"}
roles          : []
scopes         : {"https://graph.microsoft.com":["AllSites.FullControl","AppCatalog.ReadWrite.All","AuditLog.Read.All","Bookings.Read.All","ChannelMember.ReadWrite.All","ChannelMessage.Read.All","ChannelMessage.Send","ChannelSettings.ReadWrite.All","Chat.Read","Chat.ReadWrite","Directory.AccessAsUser.All","Directory.ReadWrite.All","ExternalConnection.ReadWrite.All","Group.ReadWrite.All","IdentityProvider.ReadWrite.All","Mail.Read.Shared","Mail.ReadWrite","Mail.Send","Notes.Read.All","Place.Read.All","Policy.Read.All","Reports.Read.All","SecurityEvents.Read.All","ServiceHealth.Read.All","ServiceMessage.Read.All","ServiceMessageViewpoint.Write","Tasks.ReadWrite","Team.Create","TeamMember.ReadWrite.All","TeamsAppInstallation.ReadWriteForUser","TeamSettings.ReadWrite.All","TeamsTab.ReadWrite.All","TermStore.ReadWrite.All","User.Invite.All","User.ReadWrite.All","profile","openid","email"],"https://aum365.sharepoint.com":["AllSites.FullControl","AppCatalog.ReadWrite.All","AuditLog.Read.All","Bookings.Read.All","ChannelMember.ReadWrite.All","ChannelMessage.Read.All","ChannelMessage.Send","ChannelSettings.ReadWrite.All","Chat.Read","Chat.ReadWrite","Directory.AccessAsUser.All","Directory.ReadWrite.All","ExternalConnection.ReadWrite.All","Group.ReadWrite.All","IdentityProvider.ReadWrite.All","Mail.Read.Shared","Mail.ReadWrite","Mail.Send","Notes.Read.All","Place.Read.All","Policy.Read.All","Reports.Read.All","SecurityEvents.Read.All","ServiceHealth.Read.All","ServiceMessage.Read.All","ServiceMessageViewpoint.Write","Tasks.ReadWrite","Team.Create","TeamMember.ReadWrite.All","TeamsAppInstallation.ReadWriteForUser","TeamSettings.ReadWrite.All","TeamsTab.ReadWrite.All","TermStore.ReadWrite.All","User.Invite.All","User.ReadWrite.All"]}
Additional Info
N/A

seems like something is not mocked properly 👍
thanks @arjunumenon for bringing it up 👍

Is this only the case for the config key showSpinner? I've had this problem in the past as well, but it seemed quite logical to restore the config to the default values before getting the code coverage.
I'm mainly wondering if this is something we should mock. If I remember correctly, I had a few scenarios where I configured m365 setup --scripting and afterward did some reviewing, and the tests broke completely. A worse score than the 99.98%.
Maybe another approach could be that we ensure during the tests that we do the tests with the default config.

Is this only the case for the config key showSpinner? I've had this problem in the past as well, but it seemed quite logical to restore the config to the default values before getting the code coverage.
I'm mainly wondering if this is something we should mock. If I remember correctly, I had a few scenarios where I configured m365 setup --scripting and afterward did some reviewing, and the tests broke completely. A worse score than the 99.98%.
Maybe another approach could be that we ensure during the tests that we do the tests with the default config.

Yes, this is something we've been trying to do for a long time. It's part of this issue https://github.com/pnp/cli-microsoft365/issues/4901 to centralize test logic.
It's something that will be fixed, eventually when we find the time.

Yes, this is something we've been trying to do for a long time. It's part of this issue #4901 to centralize test logic. It's something that will be fixed, eventually when we find the time.

Good point. If #4901 is going to fix this, then can we probably close this bug since we're already working on it?

Thanks @milanholemans, @Jwaegebaert the further insights on the past. Like you guys said, it is not super critical and we can very well live it with this.
For a fix, my thought process was to use c8 ignore since that has been used for the variable already here and I thought it would make sense to use at the initialization where we are having the coverage issue as well since we are not using the variable anyways.
But again like you said since we have already have plans to stub for default values, that would fix any of these issues in future.
Shall we keep this on hold till we have a fix for #4901 and then close this one together?

Closing this bug since this would be closed along with the #4901 since there are plans to stub the config with default values during the test.


Integrate with cardano-addresses 3.2.0 and add golden for script hashes for different simple script versions

Issue Number

https://jira.iohk.io/browse/ADP-673
Overview

[x] I have added the first test for RequireSignatureOf of Script for both SimpleScriptV1 and SimpleScriptV2
[x] I have added more golden for Script
[x] I have added golden for Script extended by StartSlot ExpireSlot
[x] Rest code aligning when cardano-addresses 3.2.0 is released

Comments

added also golden tests for preimage and worked on better reuse

added also golden tests for preimage and worked on better reuse

bors r+

bors r+
Please

bors r+