Add ignore for AMQP no route to host warning

I doubt that is an error we want to ignore. And also we should at best ignore warns, not errors

@okurz honestly, it pollutes our log reports and does not show a real problem, does it? Even if the AMQP connection would die permanently and this message appears I would probably ignore it since it appears this often in our logs.
However - we need to improve the log output here (maybe with the same change, @mudler did for other messages -> compress them into one message per hour at max?) or/and fix the network issues we have there. Until then we've a #poo to track it - In my understanding the exact workflow we used to follow with this script.
Besides that, this is a warning not an error ;)


Add prompts for build and send-signed

Closes #410
Description
Adds prompt for the sendsigned and build commands.
Currently auto accepts for the send command, as this is currently used in ways that make upgrading it less convenient and would require other work in additional repos. It's also less important, as it's a single step process so it should be "easier" to know what is being sent. Still would be good to have, but i think is a bigger lift for a smaller gain, so better to just tackle to two higher value commands first.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report

Merging #432 (3b5d7c0) into master (22bb301) will decrease coverage by 0.12%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   55.50%   55.38%   -0.13%
==========================================
  Files          36       36
  Lines        1906     1914       +8
==========================================
+ Hits         1058     1060       +2
- Misses        711      716       +5
- Partials      137      138       +1

Flag
Coverage Δ

unittests
55.38% <33.33%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/flowkit/services/transactions.go
60.83% <33.33%> (-2.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bb301...3b5d7c0. Read the comment docs.

Thank you this is great. We just need to be careful to update LS accordingly as it uses this API. I can make a PR on top of that.
The lining error is a nasty one, I was doing an update of dependencies and I will need to make a PR on Go SDK to stop using deprecated functionality, so as long as this is the only listing error I think we can merge until I fix that with PR, I plan to do that as soon as I get the time.


Create a new 6.5.2 and 6.5.2-bundle image

Feature Request
New new images with latest service pack.

done


cc2531 router firmware not up to date

Hi,
the firmware in your repo (https://github.com/Koenkk/Z-Stack-firmware/tree/master/router/CC2531/bin) is not up to date. ptvo released a newer version in february 2019. It is a little bit confusing (wordpress url structure), but here you'll find the current ptvo firmware from 2019/02 for cc2531:
http://ptvo.info/wp-content/uploads/2018/09/cc2531_1.2.2a.44539_firmware.zip
Maybe you can update your repo?
Regards
Arne

Done!


Add First Responders to MailChimp list

make a unique segment

and send them the blog post recap

Made a separate list in MailChimp, updated the attendance in the spreadsheet in GDrive and send along a link to the Google Doc and blog post to the broader group


Rui/score bar

Demo

Needs more discuss regarding severity ranges CC:@peterslany

https://www.loom.com/share/fbbe0f2cea764a8a9fe7760b205a04d4
This is the latest approach


MD038 Should catch code spans that start AND end with spaces

MD038 - Spaces inside code span elements
Example code:
caught: ` text`

caught: `text `

missed: ` text `

valid: `text`

Should work similar to MD039 - Spaces inside link text
[ caught](https://github.com)

[caught ](https://github.com)

[ caught ](https://github.com)

[valid](https://github.com)

Reproduction:

https://dlaa.me/markdownlint

Also, this worked in version 0.22.0 and stopped working in 0.23.0+.

https://github.com/DavidAnson/markdownlint/compare/v0.22.0...v0.23.0

Sorry about that! To be clear, I just released version 0.25.0 last night, but you are saying this broke two versions before that? Just coincidental timing, I guess?

Oops, the version numbers are actually from markdownlint-cli

https://github.com/igorshubovych/markdownlint-cli/compare/v0.22.0...v0.23.0

Which changed from ~0.19.0 to ~0.20.2 in it's deps.

I couldn't figure out how I would've missed this for so long. It turns out, it's deliberate!
Here's the commit that allows it: https://github.com/DavidAnson/markdownlint/commit/bdc0246b34040c0e75b0acdd3a92ea4539f7d52b
The second bullet point here explains why: https://spec.commonmark.org/0.30/#code-spans


Spanish is not included in the list of valid languages for acute-accented characters

https://github.com/pemistahl/lingua/blob/12456542fb7f1375a4d7254dbe93ca5174582fe6/src/main/kotlin/com/github/pemistahl/lingua/api/LanguageDetector.kt#L479
Currently "Como estas" returns SPANISH while "Cómo estás" returns PORTUGUESE. Digging further I realized that Spanish was missing from the set of allowed languages for many of the Spanish accented characters:
á = ‘ + a
é = ‘ + e
í = ‘ + i
ó = ‘ + o
ú = ‘ + u
ñ = ~ + n (this one is ok)
ü = ” + u

Hi @joeporter, thanks for reporting this issue. Indeed, somehow I missed to consider Spanish for these accented characters. That was probably because these accents are only used if the default stress rules cannot be applied to a Spanish word. Therefore these accents are somewhat rare in Spanish, so I forgot to add them. I will fix that.


Creating bower.json

Adding main in bower.json
The main files are important to use in wiredep.
Wiredep is used to inject files into index.html or another files.

@dalelotts Could you please merge this PR. It's really important to use main block with wiredep module

Thanks for the PR, however I have dropped support for bower as it does not allow for semantic-release. see #238.

Even if bower support is drop. The repo is tagged, so bower is still with us.

bower install angular-bootstrap-datetimepicker#1.0.1

use wiredep overrides to wire the module.
    "wiredep": {
      "app": {
        "src": ["<%= yeoman.app %>/index.html"],
        "cwd": "",
        "ignorePath": "..",
        "overrides": {
          "angular-bootstrap-datetimepicker": {
            "main": [
              "src/css/datetimepicker.css",
              "src/js/datetimepicker.js",
              "src/js/datetimepicker.templates.js"
            ]
          }
        }

@fabiohbarbosa "src/js/datetimepicker.templates.js" is needed in you bower.json (just in case PR is merged)


[Docs Bug 🐞 report]:  Github handle link of alequetzalli is not working

Describe the bug you found in AsyncAPI Docs.
In the Docs category in concepts page overview section link provided to the github handle alequetzalli is not working, github showing error page not found
Attach any resources that can help us understand the issue.
Here's the link to the page: https://www.asyncapi.com/docs/concepts

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey can I work on this?

@btwshivam Yeah, you can work on this. Please make sure that you update it all places in the docs.

@btwshivam Apologies, Shivam—I didn't realize you were already working on this. I had asked Ace to start on it earlier today (at noon).

@btwshivam Apologies, Shivam—I didn't realize you were already working on this. I had asked Ace to start on it earlier today (at noon).

No problem go further

@akshatnema @derberg please can you help a bit.
I'm trying to contribute didn't know the commit conventions before because of which the Lint PR title workflow failed, then I updated my commit message but the workflow again failed (maybe because there is no code change, so it is unable to compare).
And can you please review PR #3185 #3191

@lucky29-git friend you just need to change PR title, it's seems to be docs update pr so it will goes like this docs: updated handle link of an quetzalli

Okay, thanks for the help @DhairyaMajmudar
Will change it.

Please Assign this issue to me

@anshgoyalevil should we make changes in md files also?

@sambhavgupta0705
Ideally, we shouldn't make changes to the files exported from other repos


setup up files --

Hey guys,
I would like to add this to the Blackarch Linux release. Would it be possible to add a setup.py or pyproject.toml ? I've already generated the package but it does complain on installation about the missing file.
It's great tool. I used it on my last engagement. Well done.
Let me know.
Thank you !
Sincerely,

Hey @dualfade
Really glad to hear you're enjoying CrackQL! I'll set aside sometime to add a setup script.
P.S: If you're into GraphQL hacking check this out (https://nostarch.com/black-hat-graphql)

ah awesome !! Congrats on that as well. I will definitely get a copy ( once available ). Yeah please let me know and I'll re push the package.
Thank you !!
Sincerely

But as both setup.py and requirements.txt are deprecated now, I suggest following PEP 517, PEP 518, 621, 660 and move to the modern pyproject.toml.
Using pyproject.toml would allow the user or distro packager to either use setuptools, pip, poetry, flit, etc.

Thank you all very much. Once that is reviewed and merged I will re push my commits to blackarch.
Appreciate it !

Afternoon,
Let me know when you push the pyproject.toml to master and I will re push this package.
Appreciate it !
Sincerely,

@dualfade ✅ merged

Fantastic ! Just re pushed.
Thank you !


Submit module to Packagist

Hi,
when running composer require dynamic/dynamic-elements (on clean SilverStripe 4 installation) I'm getting an error:
Problem 1:  the requested package dynamic/dynamic-elements could not be found in any version, there may be a typo on package name.
I have tried to search module on Packagist, and didn't find any results.
What did work for me is adding a repositories line to my project composer.json file like so:
"repositories": [{
    "type": "git",
    "url": "https://github.com/dynamic/dynamic-elements/"
}],
"require": {
    "php": ">=5.6.0",
    "silverstripe/recipe-cms": "1.0.0@stable",
    "dynamic/dynamic-elements": "2.0.x-dev"
}

Hi @jsirish @muskie9 do you guys have any comments or thoughts on my issue?

Hi @hdpero
Thanks for submitting an issue. We’re actively working towards an alpha release, at which point we’ll add the module to packagist. In the meantime, the method you’re using is the same way we’re pulling it in.
We’ll close this issue once it’s in packagist.
Thanks!


Add an acquire-lock command. Fixes #19.

This command can be used to acquire long-term locks.

@josh-padnick To continue making progress, I'm going to merge this one too.


Internet explorer is officially deprecated and as Shopware we need to advice users to switch to another browser

Please describe the feature you would like to see implemented.
Hi all
Now that Internet Explorer is finally been put to the grave, it's time that Shopware acknowledges this and advices Internet explorer users to switch to another browser.
This can be done in a similar way as the JS notification.

We dropped the support on our site years ago :-)
We have discontinued support for Internet Explorer.
It is no longer state-of-the-art in terms of security and technology. To be able to use our online service to full extent and for your protection, we recommend switching to a more up-to-date and safer web browser.
If you have any questions, please contact your administrator.

Great message, should be taken as an example ;-)

This will be already done in next major. We won't add such message in any patch version.


Warning: The tag  is unrecognized in this browser. If you meant to render a React component, start its name with an uppercase letter.

https://i.imgur.com/YZ70GOC.png

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
no warnings when rendering component
Current Behavior
In dev, react outputs warning related to   because its first letter is lowercase (expecting title-cased)
Steps to Reproduce
              <CardHeader
                avatar={(<GroupAdd className={classes.icon} />)}
                title="Referrals"
                titleTypographyProps={{ variant: 'subtitle1' }}
              />

Your Environment

Tech
Version

Material-UI
v3.5.1

React
16.6.3

Browser
Chrome 68.0.3440.106 (Official Build) (64-bit)

Works perfectly fine for me: https://codesandbox.io/s/040j0y09xw
I think what you're actually doing is
- titleTypographyProps={{ variant: 'subtitle1' }}
+ titleTypographyProps={{ component: 'subtitle1' }}

which would produce the error message you linked.
Please provide the complete code if you're sure that you're actually using variant and not component.

lmfao nice catch!!


fixing prompt template of chatml by removal of linebreak

reference to discord chat:
"""
hi <@208256080092856321> , went through the code step-by-step and found that there's an extra linebreak ('\n') in the separator of ChatML so the separator will end up having two linebreaks . You can see it here: https://github.com/OpenAccess-AI-Collective/axolotl/blob/a581e9f8f66e14c22ec914ee792dd4fe073e62f6/src/axolotl/prompt_strategies/sharegpt.py#L16  and https://github.com/OpenAccess-AI-Collective/axolotl/blob/a48dbf6561cc74c275a48070f397334a2c367dd5/src/axolotl/monkeypatch/fastchat_conversation_turns.py#L117 . A typical silent killer of prompt template for those not aware but the model is most probably robust enough to still reply coherently since it's just a linebreak.
"""

Could you provide an example with before and after using python -m axolotl.cli.preprocess your_config.yml --debug? Just curious to see the actual difference on a per-token level to verify that this is the case.

Could you provide an example with before and after using python -m axolotl.cli.preprocess your_config.yml --debug? Just curious to see the actual difference on a per-token level to verify that this is the case.

here's the current main, definitely something buggy

Oh that's really bad. Essentially you are putting in a sample with just noise with <0x0A><0x0A>?

@winglian
just notice this, for the last few tokens (ending):
<|im_end|>(32000, 32000) (28705, 28705) <0x0A>(13, 13) <|im_end|>(32000, 32000)

why is there a token id 28705 there? Any clues?

The following change seems to fix the double EOS token:
register_conv_template(
Conversation(
name="chatml",
system_template="<|im_start|>system\n{system_message}",
system_message="You are a helpful assistant.",
roles=["<|im_start|>user", "<|im_start|>assistant"],
#sep_style=SeparatorStyle.CHATML,
sep="<|im_end|>",
stop_str="<|im_end|>",
)
)

@noobmaster29 what happen to your PR?

Someone on Discord mentioned that the change did not solve the issue of double EOS tokens. I have not had time to replicate it yet but I will try to look at it tomorrow.

Someone on Discord mentioned that the change did not solve the issue of double EOS tokens. I have not had time to replicate it yet but I will try to look at it tomorrow.

It may be caused by dataset cache. Though the code is changed to  <|im_end|>\n, the cached dataset may remain <|im_end|>\n\n and is directly loaded for train.

Could you try a fresh process and see if it still produces double EOS and new line characters?


🐞[Bug] log.Progress does not work.

Calling log.Progress has no effect on the progress bar in Task Queue.
https://docs.stashapp.cc/in-app-manual/plugins/embeddedplugins/#javascript-api

Sorry, this was an error in my part.
It does work.


Linker section alignment does maybe not work

https://github.com/hermitcore/rusty-loader/blob/master/src/arch/x86_64/link.ld
In edu-OS I found that the sections are not aligned to page boundaries. And as the linker script is almost the same,  I guess the linker script here does have the same flaw.

Why is this a problem for the loader?


Error message for incompatible extensions should suggest next steps

Is your feature request related to a problem? Please describe.
If a user attempts to add a private preview extension to the Azure CLI, and the extension requires a base version greater than what they have currently installed, the resulting error message isn't very helpful. It doesn't tell them the extension name or how to install a compatible CLI core version.

Describe the solution you'd like
The error message should say which extension is attempting to be installed, and should point users to a link showing up to upgrade their installation of the Azure CLI.
Describe alternatives you've considered
I can't think of any alternativs.
Additional context
Motivated by: https://github.com/Azure/azureml-v2-preview/issues/130

hi @fengzhou-msft could you pls help to look at is this related with package unsync in index.json?

hi @fengzhou-msft could you pls help to look at is this related with package unsync in index.json?


update/2 -> increment/2

Increment the count subsection of Phoenix 1.7 reading material

resolved in resolved in #941


Connecting to Amazon MQ

Hey,
I'm trying to use this package for consuming RabbitMQ streams that exist in Amazon MQ service.
I'm using the following code (as shown in the examples):
	stream.SetLevelInfo(logs.DEBUG)
	_, err := stream.NewEnvironment(stream.NewEnvironmentOptions().SetHost(host).SetPort(port).SetUser(user).SetPassword(pass).IsTLS(true).SetTLSConfig(&tls.Config{InsecureSkipVerify: true}))
	if err != nil {
		fmt.Errorf("Failed to create environment: %s", err)
	}

And the output is:
2022/06/07 12:52:57 [warn] - Command not implemented 0 buff:0
2022/06/07 12:52:57 [debug] - Read connection failed: EOF
2022/06/07 12:52:57 [debug] - error removing heartbeat: Response #{id} not found
2022/06/07 12:52:57 [warn] - error during send client close write tcp <IP_ADDRESS>:65069->xxxx:5671: write: broken pipe
2022/06/07 12:52:57 [warn] - error during close socket: tls: failed to send closeNotify alert (but connection was closed anyway): write tcp <IP_ADDRESS>:65069->xxxx:5671: write: broken pipe
2022/06/07 12:53:07 [error] - timeout<PHONE_NUMBER>0 ms - waiting Code, operation: commandPeerProperties
2022/06/07 12:53:07 [error] - Can't set the peer-properties. Check if the stream server is running/reachable

On the other hand, connecting using the official ampq pacakge, I can connect successfully:
	conn, err := amqp.Dial(fmt.Sprintf("amqps://%s:%s@%s:%d", user, pass, host, port))
	if err != nil {
		fmt.Errorf("Failed to dial: %s", err)
	}
	defer conn.Close()

	ch, err := conn.Channel()
	if err != nil {
		fmt.Errorf("Failed to open a channel: %s", err)
	}
	defer ch.Close()

	_, err = ch.QueueDeclare("hello", false, false, false, false, nil)
	if err != nil {
		fmt.Errorf("Failed to declare a queue: %s", err)
	}

I also made sure that the stream feature is enabled in Amazon MQ (stream_queue: Enabled):

Any idea what am I doing wrong?

I'm using 5671, as the endpoint Amazon MQ provides me is: amqps://b-xxx.mq.us-east-1.amazonaws.com:5671

5671 is the AMQP port.
Stream plugin protocol uses different ports: 5552 and 5551 for tls
Please see this gist  to see the different between AMQP and Stream Protocol


Add support to create repodata

Usage:

Create .input directory in platforms/Linux/shared/RPM/createrepo/ and copy in .rpm file.
Build Docker image docker-compose -f platforms/Linux/shared/RPM/createrepo/docker-compose.yaml build
Create repodata docker-compose -f platforms/Linux/shared/RPM/createrepo/docker-compose.yaml run build
.output directory will contain the createrepo-output.log and the repodata

Overall idea:
Build swift rpm package -> Code sign the rpm package -> Create repodata ->  upload to swift.org

another approach to consider is adding a docker compose task for each one of the variants (ie. al2, centos 7, centos 8, etc) called "createrepo" (or something like that) that will do this work


Make wheel construction part of release instructions

Refs #71

Sorry, I cannot review this PR. I have no idea what it has accomplished or how to evaluate this.

To review you could make a release to test.pypi.io and check whether a howfairis*whl file was uploaded besides the howfairis*.tar.gz file.


Break Modules into Separate CSS Files

Some people might want to just cherry pick the grid, or typography from Foundation. So long as there are not inter dependencies, Type, Reset, and the Grid should be broken into separate stylesheets.
If people are really concerns about too many http requests, they can bundle the assets at deploy time.

My concern here is that breaking it up into a LOT of files is counter-productive on mobile devices where separate requests create additional latency. Right now it's a spit between a) totally optimized into one file and b) split logically so people can use what they want. If you think it's better to rely on people to do the right thing at deploy than it is to set them up that way initially, there's no real interdependencies.

I'd like to +1 this request. This pattern is similar to what the YUI project uses for their CSS framework which makes it easy to mix-n-match modules to meet your needs.

+1 on counter-productive, on the default install you are already loading 7 stylesheets that probably 3 too much... Devs/ Designers can drop a style below these and reset the features they don't want to use....

@smileyj68 / @shawnsandy I was looking at this from the Ruby Gem version of Foundation where the Rails Asset Pipeline can bundle up all the individual styles into one file. I could see how trying to maintain a separate file structure for just the Gem would be a pain though.

Hmm... I'm mixed on this. I'm +1 for making it easier to cherry pick, so long as developers who use Foundation realize they should also merge stylesheets in a production environment.
I'm using Foundation with an ASP.NET MVC website, built using Visual Studio 2010. I'm using a VS add-in called Chirpy to manage the merging/minification of stylesheets and javascript. I'd imagine other platforms have something similar.

Maybe we should do the same thing that the jQuery project does.
Split all the CSS files up in the Git repo, but package them all into a single (uncompressed) css file when we create the ZIP file that is linked up on foundation.zurb.com.
If you are looking at Foundation on GitHub, then we can assume you know how to package the files when you deploy them. If you are just downloading the ZIP files, then we make it a single http request assuming you will just be coping and deploying.

The CSS has been split out, adding typography.css and grid.css (41e7d9276f3babea9d1e589b49bba959b74c6773). Like Matt said we'll create a build script to generate the .zip archive for download with a single (readable) CSS file, and leave Github as the home of the split versions.

Very basic Ruby build script was added to create the ZIP file for the marketing site. It pull in the required files and combines the CSS and JS files so we don't have excessive http requests. The next time we release the code on Git to foundation.zurb.com, we will use the script to combine the CSS and JS files.
98721494640af04c4e52da0c1d2bbfa464f5cdcb


about softbound

It is mentioned that ASAP can work for  SoftBound in the paper (http://dx.doi.org/10.1109/SP.2015.58), and there is a small piece of relevant codes in the project, but I don't know how to enable it.
Is there any instructions on how to work for SoftBound?

Indeed, ASAP works with SoftBound. However, setting everything up correctly
will be tricky.
The code in this repository is the newest version of ASAP, which we have
upgraded for LLVM 3.7.  The SoftBound experiments were done with an earlier
version, because SoftBound (at the time of our research) was based on LLVM
3.4. That earlier version used the SoftBound code from
https://github.com/santoshn/softboundcets-34 .
If you want to use ASAP and SoftBound together, you would need to port both
to a common LLVM version. Probably the easiest target would be LLVM 3.9.
There is a version of SoftBound for that (
https://github.com/santoshn/SoftBoundCETS-3.9), and I suspect that you
could add ASAP onto this code with only minor changes. Once this is done,
ASAP should "just work" if you add -fsoftboundcets to the compilation
options.
Hope this gets you started! Let me know how it goes -- I'd be happy to
update the documentation for ASAP.
On Sun, Nov 7, 2021 at 12:13 PM zyy0721 @.***> wrote:

It is mentioned that ASAP can work for SoftBound in the paper (
http://dx.doi.org/10.1109/SP.2015.58), and there is a small piece of
relevant codes in the project, but I don't know how to enable it.
Is there any instructions on how to work for SoftBound?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dslab-epfl/asap/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARS66AL2BBK5DOD4MWNODUKZNLZANCNFSM5HQWLGDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Disabling Retries by setting attemps=0 on egress virtual service is not reflected in istio proxy config

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Description
In order to disable default retry, we followed  the guide at https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRetry and set the value of attempts=0.
The retries block was added as below
retries:
   attempts: 0

The issue is that the above block added into the virtual service attached to the ingerss  gateway works just fine as expected and showing the config change reflected in Istio Envoy Proxy Routes configuration.
The proxy configuration was checked by running istioctl pc routes <istio-ingressgateway-pod> -o json. As expected, disabling the retries removes the policy block from the envoy routes config.
However, when the same configuration applied to the virtual service attached to the egress gateway is not behaving as expected. The retry block mentioned above had to be added at both the routes (within-mesh, outgoing) to achieve the effect.
The configuration in virtual service and resulting enovy route config was inconsistent in below different scenarios.
1.  Below config DOES NOT disable the retries and always shows the default retry policy with attempts-2 in Proxy Routes config
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: direct-external-through-egress-gateway
  namespace: default
spec:
  gateways:
  - dev-egress-gateway
  - mesh
  hosts:
  - dev.xyz.com
  http:
  - match:
    - gateways:
      - mesh
      port: 80
    name: nonprod-mesh
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        port:
          number: 443
        subset: dev
      weight: 100
  - match:
    - gateways:
      - dev-egress-gateway
      port: 443
    name: nonprod-egress
    _retries:
       attempts: 0_
    route:
    - destination:
        host: dev.xyz.com
        port:
          number: 443
      weight: 100

2.  Below config disables the retries but doesn't show the same in Istio Proxy Routes config
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: direct-external-through-egress-gateway
  namespace: default
spec:
  gateways:
  - dev-egress-gateway
  - mesh
  hosts:
  - dev.xyz.com
  http:
  - match:
    - gateways:
      - mesh
      port: 80
    name: nonprod-mesh
    _retries:
       attempts: 0_
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        port:
          number: 443
        subset: dev
      weight: 100
  - match:
    - gateways:
      - dev-egress-gateway
      port: 443
    name: nonprod-egress
    route:
    - destination:
        host: dev.xyz.com
        port:
          number: 443
      weight: 100

3. Below config disables the retries and shows the policy block removed in Istio Proxy Route config also
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: direct-external-through-egress-gateway
  namespace: default
spec:
  gateways:
  - dev-egress-gateway
  - mesh
  hosts:
  - dev.xyz.com
  http:
  - match:
    - gateways:
      - mesh
      port: 80
    name: nonprod-mesh
    _retries:
       attempts: 0_
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        port:
          number: 443
        subset: dev
      weight: 100
  - match:
    - gateways:
      - dev-egress-gateway
      port: 443
    name: nonprod-egress
    _retries:
       attempts: 0_
    route:
    - destination:
        host: dev.xyz.com
        port:
          number: 443
      weight: 100

4. However, the expected configuration should be as below and at the same time this should show the Retry Policy block removed in Istio Envoy Proxy Routes configuration
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: direct-external-through-egress-gateway
  namespace: default
spec:
  gateways:
  - dev-egress-gateway
  - mesh
  hosts:
  - dev.xyz.com
  http:
  - match:
    - gateways:
      - mesh
      port: 80
    name: nonprod-mesh
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        port:
          number: 443
        subset: dev
      weight: 100
  - match:
    - gateways:
      - dev-egress-gateway
      port: 443
    name: nonprod-egress
    _retries:
       attempts: 0_
    route:
    - destination:
        host: dev.xyz.com
        port:
          number: 443
      weight: 100

[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Setting attempts = 0, for the in-mesh routes achieves the behavior of disabling the retries, but that should also get reflected in Istio Proxy Envoy routes configuration. As mentioned in the 4th scenario;
The expected configuration should be as below and at the same time this should show the Retry Policy block removed in Istio Envoy Proxy Routes configuration
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: direct-external-through-egress-gateway
  namespace: default
spec:
  gateways:
  - dev-egress-gateway
  - mesh
  hosts:
  - dev.xyz.com
  http:
  - match:
    - gateways:
      - mesh
      port: 80
    name: nonprod-mesh
    route:
    - destination:
        host: istio-egressgateway.istio-system.svc.cluster.local
        port:
          number: 443
        subset: dev
      weight: 100
  - match:
    - gateways:
      - dev-egress-gateway
      port: 443
    name: nonprod-egress
    _retries:
       attempts: 0_
    route:
    - destination:
        host: dev.xyz.com
        port:
          number: 443
      weight: 100

Steps to reproduce the bug

Use above 4 use case configuration to disable  the Retries by adding it in Egress virtual service
Observe the effect of this configuration by running the command istioctl pc routes <istio-egressgateway-pod> -o json. You should not see any block called retriesPolicy.

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
Istio 1.8.2
K8s 1.17
How was Istio installed?
Using IstioOperator
Environment where the bug was observed (cloud vendor, OS, etc)
AWS Cloud, Centos 7
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

achieves the behavior of disabling the retries, but that should also get reflected in Istio Proxy Envoy routes configuration

Not sure I understand. How can it achieve the behavior but not appear in the envoy config?

out of two routes defined in virtual service for egress..... it achieves behavior of disabling retry when added to 1st route (within mesh) but does not gets reflected in envoy config it seems..... on the other hand if we define retry to 2nd route (going outside via egressgateway) it is getting reflected in envoy config but the default retries are still happening it seems....
so it looks like some bug where in it requires retry config at both routes, one to achieve behavior and another to get it reflected in envoy config.  Go through those 4 scenario to understand it better.

@ChenglongGao327

test the above config i find :
1st config, route config has retryPolicy
2nd config, route config has no retryPolicy
3th config, route config has no retryPolicy
4th config, route config has retryPolicy


Failure to create publicID; directory; or file, doesn't allow retry.

Using: Stable Droplet Network and the Demo App 0.2.3 for that.
I was tempted to file this under the Launcher, because it was the trigger that caused the issues below. However, I suspect it's not for the Launcher to accommodate or to fix the consequence of its being unavailable - these issues I wonder are beyond just the Demo App. I'll file now under Demo App, in case it's possible the Demo App can accommodate all these experiences more cleanly.. but note that perhaps it's possible the network itself can do more to keep the user's experience and assets tidy.
So, problems below appear in the experience of the Demo App but follow from the Launcher failure, not being properly accommodated. If the launcher becomes unavailable for whatever reason, then errors follow in the reporting of state of publicID; directories; and files. I suspect it might be more correctly the same issues follow from the loss of network connection, at the time some instruction is being communicated to create a publicID; directory; or file.
Wondering why I'd seen instances that upload was refused because directory couldn't be created, I tried a number of tests as below.
#StepA - Issue1
Action: Close or crash out of launcher midway through register publicID
Result: Next attempt suggests no publicID already and yet publicID is already taken - why if that publicID exists, does the owner=creator of it not see that or any fragment of it that would allow it to be completed and confirmed. In what state does that publicID exist now, if the owner is not the owner?
#StepB - Issue2
Action: Close or crash out of launcher midway through an upload of directory to create new service
Result: Next attempt suggests "Upload failed - failed to create directory", though again no suggestion the service exists. Create a service step doesn't stop the user and note that directory exists or cannot be uploaded against because of a previous attempt. So user is teased with Upload some web content where that will never succeed.
#StepC
Action: Upload a folder containing an index.html allowing service to be created successfully.
#StepD - Issue3
Action: Close or crash out of launcher while uploading a relatively large file.
Result: The failed upload showed a 0byte file on return that could be deleted - tempting a retry. The retry then fails with a vague message: "upload failed - failed to create [file]". Yet, the file is listed in the directory as if it was successful. So, I tried accessing it - since I can't seem to do that directly, I deleted the index.html and put another that addressed that 'failed' file, only to find that it had uploaded ok.
On another occasion, having deleted the successful file and tried to find any other issue by stopping the re-upload midway, I couldn't find a problem; and then tried to upload successfully one last time, only to get an error:
ERROR 08:45:19.156332780 [safe_core::ffi mod.rs:302]

 --------------------------------------------------
| FfiError::NfsError -> NfsError::FileAlreadyExistsWithSameName
 --------------------------------------------------

but if that was the case, why was it not declared as a broken file in the directory.. perhaps that's just beyond the Demo apps capability. Still at odds with the experience of seeing a 0 byte file where it had failed previously.
I note that while the Launcher appears to be simple to close midway through creating a publicID or service, the launcher is unresponsive to a request to close[x] while uploading a (large) file. Forced close with a number of bad user Ctrl-C doesn't kill the process - perhaps that's a normal result of multiple Ctrl-C.
--- Summary ---
So, the major issue for user experience I want to suggest is the apparent dust that can be created by failure which then prevents a user fixing any fragments of failed creation of accounts or upload, for which they truly are owner.
My impression as user then would be:

Delete, where it's an option, appears to work well.
Read doesn't always make the reality apparent - publicIDs not completed and directories not completed, do not appear yet get in the way of trying again.
Write sometimes can't then upload against dust and my reaction is to wonder that dust should be apparent to the user; or cleaned up automatically where it's encountered by the network or the launcher on the users behalf. Better perhaps that such detail that can trigger errors, is reported so the user can make sense of their experience of a failure - then clean up - then opportunity to retry.

Same problem I think
https://ipfs.pics/QmfGcoGAA56aNmt4aswWG3v3UWRXmHUNq7PS1bH6pJg9CM


"_500.tsx" Not Rendering in Dev Mode

I had some trouble setting up a custom error page for my app. I found that the _500.tsx page only seems to show up when I run the app in preview mode. Is there a way I can make it appear in dev mode? In dev mode, the error message is quite descriptive, but I'm wondering if it's possible to show the custom _500.tsx page instead of the default dev error page.
I have a handler intentionally throwing an error:
export const handler: Handlers<Props> = {
  async GET(_req, ctx) {
    throw new Error('Some error inside the handler');
  }
};

When I run in dev mode using deno run -A --watch=static/,routes/ dev.ts, I see this screen:

When running in preview mode with deno run -A main.ts, this is the screen that appears (my _500.tsx component):

These are my dev.ts and main.ts files:
dev.ts
#!/usr/bin/env -S deno run -A --watch=static/,routes/

import dev from 'fresh/dev.ts';
import config from './fresh.config.ts';

import '$std/dotenv/load.ts';

await dev(import.meta.url, './main.ts', config);

main.ts
/// <reference no-default-lib='true' />
/// <reference lib='dom' />
/// <reference lib='dom.iterable' />
/// <reference lib='dom.asynciterable' />
/// <reference lib='deno.ns' />

import '$std/dotenv/load.ts';

import { start } from 'fresh/server.ts';
import manifest from './fresh.gen.ts';
import config from './fresh.config.ts';

await start(manifest, config);

Fresh version: 1.5.2
Deno version: 1.37.2
Thanks in advance :)

Here we check if we're in dev mode and shove in the DefaultErrorHandler which has the code box you're seeing.
This command gets invoked from your main.ts. So you can see dev being set to false and then we don't use the DefaultErrorHandler.
And finally in dev mode the flag is set to true.
Sadly I don't see any easy way to opt out of this behavior, although you'd have to wait for @marvinhagemeister to have a definitive answer.

Thanks for the clarification! That would be a nice feature to have if it's not too difficult to implement. In the meantime, it might be a good idea to update the Fresh documentation to inform developers that the custom 500 page won't appear in dev mode.
Something like:

500: Internal Server Error
The 500 page can be customized by creating a _500.tsx file in the routes/
folder. The file must have a default export that is a regular Preact component.
A props object of type ErrorPageProps is passed in as an argument.
Please note that while in dev mode, the custom _500.tsx page won't be displayed.
Instead, the default Fresh error page, containing error details, will be shown. You
can view the custom _500.tsx page in preview mode and when the app is deployed.
import { ErrorPageProps } from "$fresh/server.ts";

export default function Error500Page({ error }: ErrorPageProps) {
  return
500 internal error: {(error as Error).message}
;
}

Do you think this is valid? I'm looking forward to contributing to open-source projects. If the suggestion is valid, should I create a PR to update that part of the documentation?

Yeah, I agree the "Error pages" page could be more clear about this. I'm sure a PR to improve this page would be appreciated.

Thank you, @deer ! I've just created PR #1983 to update the documentation. I'll dive into the Fresh codebase and attempt to implement some logic that allows developers to decide whether they want to view the 500 error page in dev mode or not.

I'm not a fan of adding workarounds of bugs in the documentation. We should just fix the bug.

What is the bug exactly? I thought the desired functionality was to show the error frame in dev mode.

Yeah it's desired that we show the error frame, but we should load it in an  and add a close button like other frameworks do. That way you can still see the underlying 500 error page from the user.


Question about licensing

In order to properly license the " all up sign-in activity report." does one need ALL users licensed with an Azure p1 license or just the administrator viewing the report.  The use of the phrase "Your tenant must have an Azure AD Premium license associated with it to see the all up sign-in activity report. " is confusing.  My users don't care about this activity report.  Only I do.  But do I need a p1 for all users to be licensed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1558e7c0-eaaf-d081-30c3-5c13e0876071
Version Independent ID: 1106c01b-1e4c-5b04-be84-432f99ec4d8f
Content: Sign-in activity reports in the Azure Active Directory portal
Content Source: articles/active-directory/reports-monitoring/concept-sign-ins.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

The license (P1) is applied at the Tenant level and not to a particular user.

Hi @SusanBradley , you're right that there's no reason for the P1 to apply to all of those users when you're just viewing the activity report. As Sujay said, this just applies to the tenant so you only need one P1 license at the tenant level.
I'm closing this out but if you think this could be more clear in the documentation feel free to make a pull request or suggestion.

Yes please because that's not what I've interpreted from other locations.  We are in the SMB space, and  I'm seeing conflicting info.  Example - https://docs.microsoft.com/en-us/office365/servicedescriptions/microsoft-365-service-descriptions/microsoft-365-tenantlevel-services-licensing-guidance/microsoft-365-security-compliance-licensing-guidance in the closed feedback section read the "unclear requirements regarding Azure AD p2 features"   The question was:  There are multiple claims online that you can legally license a single administrative user to access the tenancy-wide "risky sign in" feature, including statements from VARs and "licensing experts". I don't feel this document is explicit enough in clarifying this one way or the other. There is an argument that it is only that administrative user who "benefits" or "uses" this report, and indeed there is a paragraph that starts with "SecOps analysts and security professionals benefit ....". A firm statement on this would be appreciated.
The answer came back:  " I heard back from the product team and here's their response: The sentence after the one referred to states that end users benefit by having their data monitored. Therefore, they would need to license any user whose data is monitored (in addition to the analysts using the reports)."
I interpret that that I need a p1 for each user that rolls up into azure AD logging.  Please be clearer as to when we cross the line and need a p1 or p2 for EVERY user and when we can just purchase a single one for the admin and that's good enough.

P.S. actually I assigned the P1 license to my admin, so I am "assigning" that P1 not to my tenant, but to a specific user.  Once I did the azure AD user logging report opened up.


Roadmap to stable release

This issue is meant to be a planning/dumping ground for tasks that have to be done prior to the first stable release of furo.

[x] Write the documentation for this theme

[x] Finalize skeleton structure.
[x] Write the content!

[x] Deploy the documentation w/ GitHub Pages
[x] Stylize API documentation
[x] Stylize captions
[x] Stylize field lists (low priority)
[x] Stylize the remaining permalinks
[x] Switch to em for typography, instead of using rem everywhere
[x] Tweak spacing for headings & paragraphs -- they might have a little too much margin?
[x] Fix page's height on mobile, where 100%-100vh is not 0. -.-
[x] Fix z-index levels for overlay (the toctree overlay needs to be above the sidebar and vice-versa).
[x] Skeleton + styling for index pages (#50)
[x] ~Add JS-based buttons to copy code blocks~
[x] ~Create a good looking landing page for the documentation~

https://github.com/tholman/github-corners is amazing and we should have that at least on the landing page for this theme's documentation (if not available on all pages).

I suspect you're already aware, but if not,

Even though I'm a collaborator on executablebooks, I didn't know about this. Thanks for the link! ^>^

Actually, that doesn't need to be done here, or be critical path for the release. :)

No, but it doesn’t work now because for some reason the DOCUMENTATION_OPTIONS object is not being set. I’m not at my computer now but I think it seemed like base.html was not being used? Although the “basic” theme also sets it so I’m not sure why it didn’t work. I can take a closer look tomorrow.
On Sep 14, 2020, 7:23 PM +0800, Pradyun Gedam<EMAIL_ADDRESS>wrote:

Actually, that doesn't need to be done here, or be critical path for the release. :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@goodmami Yea, I was trying to reduce the number of assets that are loaded on each page. Turns out, a lot of stuff out there assumes how Sphinx works, and it's likely easier to just mimic it rather than trying to optimize things -- this was fixed in bea26d963c4c9fe1025bc734d04bc85cd52b1886.

Oops, my fault. I was using the version from PyPI which doesn't have that commit. I withdraw my statements above about it not working.
I appreciate your goal to cut out the extra stuff. I hope the situation with Sphinx improves such that it can be realized.

Okay, so there's lots of documentation to write now!

@pradyunsg Just wanted to quickly ask if there's a chance for a beta20 release in the next couple of days. Is there anything that needs to be done first? The last release was 10 days ago and there have been some bugfixes since then which I'd like to have included in my docs builds. Thank you!
Btw, is there no release deploy/publish CI config?

https://github.com/pradyunsg/furo/blob/b6c7c76bc1a5aa8f513eafbc5bd87b655a8e801f/.github/workflows/deploy.yml#L4
https://github.com/pradyunsg/furo/blob/b6c7c76bc1a5aa8f513eafbc5bd87b655a8e801f/noxfile.py#L113

Beta 20 has been uploaded.
@bastimeyer https://pradyunsg.me/furo/contributing/workflow/#release-process

Just #50 is left. And, with that, I think I can move out of betas! :)

I'll mark the releases I make starting next month as stable. :)

Any chance of supporting Sphinx v4 with the next release?

Yup, that's the rough plan. I just need to test it out, since I know that there have been some changes around the HTML output that themes have to work with.
https://github.com/pradyunsg/furo/discussions/148#discussioncomment-739767

Yup, that's the rough plan. I just need to test it out, since I know that there have been some changes around the HTML output that themes have to work with.
#148 (comment)

Missed that discussion, thanks!

Okay, with Sphinx 4 settled down, we're basically there.
I have known for a while that I should write down a "policy document", describing the promises that this theme makes to the users; clarifying the versioning policy, change management policy and support policy. I've been procrastinating on that, but that should probably stay a blocker for "going stable".

Annd... done!
https://pradyunsg.me/furo/stability/
https://pradyunsg.me/furo/changelog/#aspiring-avocado
:)


fix: fleuent Select

🐛 Bug Report
In the documentation for the multiple select it has the below code, this has a containing div so that all the options show, change the height value and items start covering information in the page below. This feels like this shouldn't be necessary as you may not know until runtime how many items are in the list.
💻 Repro or Code Sample
<div style="display: block; height: 300px;">
    <FluentSelect Items=@stringOptions2
                  TOption="Option<string>"
                  Multiple=true
                  OptionText="@(i => i.Text)"
                  OptionValue="@(i => i.Value)"
                  OptionSelected="@(i => i.Selected)"
                  OptionDisabled="@(i => int.Parse(i.Value!) > 6)"
                  @bind-SelectedOptions="@selectedStrings" />
</div>

🤔 Expected Behavior
This doesn't feel right that we have to know the height of the containing div before creating the select with multiple options? It should handle this itself within the css.
😯 Current Behavior
Without the parent div the multiple select box covers anything below.

You don't need to know the height in advance. How it is done here in the demo is just so things align better. What you can do to make sure everything displays correctly in your site is to use the Height parameter of the FluentSelect  component itself. Then if the list is longer than what fits, a scroll bar will be shown:

Here I set the Height parameter to 200px; and left everything else as-is.
P.S. with the <fluent-select> web component, the list is always expanded when multiple is set so this is also true for the Blazor component


Question: [How are app sound notifications handled on WinUI 3?]

As a current Windows Mobile 10 user, I have experienced the ability to customize the app's notifications in Settings. Over the years, I have noticed that same feature hasn't translated over to Windows 10. I figured that this would be hard implement with Win32 programs. They weren't designed to change an program's notification sound other than the antiquated "Sounds" menu. I have also noticed the inability to change UWP notifications in Windows 10 as well.
My question is, is this ability built into Windows 10 UWP apps like they were in Windows 10 Mobile apps? Will this ability be added to WinUI 3 which will allow for app developer to use an api to set their notification sounds and allow for the OS to change those sounds to a custom one if perfered?
Thanks.

@Austin-Lamb or @codendone do either of you know where we could route this?

@shaheedmalik As far I'm aware, on desktop you can only change the notification sound in the app itself and not via the OS. In other words, currently, if you want to change the notification sound, you can only do that on a per-app basis and only if the developer supports this feature and it further depends on how they implemented it (providing a set of sounds packaged via the app to pick from/enable the user to pick a sound file on their file system).
See https://docs.microsoft.com/en-us/windows/uwp/design/shell/tiles-and-notifications/custom-audio-on-toasts for API details.


Push notifications on android not received when app is swipe closed

This is sort of a cross post from here:
https://github.com/Azure/azure-notificationhubs-xamarin/issues/57
I have the very same problem: I can receive notifications with app open, in background but not when is swiped out.
Environment:

Windows 10
Visual Studio 2019 16.11.0

Relevant NuGet packages on Android project:

Xamarin.Azure.NotificationHubs.Android <IP_ADDRESS>
Xamarin.GooglePlayServices.Base 117.6.0

Steps to reproduce:

Create a new Xamarin Forms (blank app) solution
Update every nuget Package to the latest version
Add the 2 nuget packages above
Add nuget package Xamarin.Google.Dagger 2.37.0
Here's my update OnCreate method in MainActivity:

protected override void OnCreate(Bundle savedInstanceState)
        {
 base.OnCreate(savedInstanceState);

            const string CONNECTION_STRING = "********";
            const string HUB_NAME = "*******";

            FirebaseApp.InitializeApp(Application.Context);

            NotificationHub.SetListener(new NotificationListener());
            NotificationHub.Start(Application, HUB_NAME, CONNECTION_STRING);
            NotificationHub.AddTag("TESTPUSH4");

            Xamarin.Essentials.Platform.Init(this, savedInstanceState);
            global::Xamarin.Forms.Forms.Init(this, savedInstanceState);
            LoadApplication(new App());
}

Here's my NotificationListener class:

public partial class NotificationListener : Java.Lang.Object, INotificationListener
    {
        async void INotificationListener.OnPushNotificationReceived(Context context, INotificationMessage message)
        {
            //Push Notification arrived - print out the keys/values
            var data = message.Data;
            if (data != null)
            {
                foreach (var entity in data)
                {
                    Android.Util.Log.Debug("AZURE-NOTIFICATION-HUBS", "Key: {0}, Value: {1}", entity.Key, entity.Value);
                }
            }
        }
    }

Tried with and without the async prefix.
I can confirm it's not a device problem, because the behavior is consistent between devices, and using old deprecated firebase messaging services the notification are received.
Thanks in advance.

Ok, found it.... The notification does not work with the app closed only if the app is deployed in debug configuration, once it's deployed in release mode the notifications are correctly managed.
I think this may worth a few words on the docs.


scons: *** [build\addons\ffmpeg\win64\avcodec-60.dll] The system cannot find the file specified.

系统找不到指定文件（The system cannot find the file specified）

There is nothing under EIRTeam.FFmpeg\thirdparty\ffmpeg\bin

I will rework how obtaining the ffmpeg binary works, since it's a bit unreliable, sorry for the delays, I've been a bit busy with another project.

Is this already updated?

Is this already updated?

Sorry once again for the delays, i'm extremely busy with a massive release for Project Heartbeat, i'll get back into it ASAP.


Chore: update NodeJS version used to develop and build the frontend

Update NodeJS from 20.7 to 22.4, the current LTS.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-80.4%) to 0.0%

Totals

Change from base Build c2933ecfc91add058cd978dc53d7ab30afa46191:
-80.4%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Minor spelling fixes

Proposed changes
I found minor spelling mistakes while reading the documentation.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[x] spelling errors in documentation
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments

I have read the CLA Document and I hereby sign the CLA


[REQUEST] Determine order to process gtfs entities

Is your feature request related to a problem? Please describe.
Before implementing GTFS validation rules, the order in which gtfs entities should be handled must be determined based on "conditionaly required" and ID fields.
This information is available at http://gtfs.org/reference/static

Suggestion:

feed_info.txt
agency.txt
fare_rules.txt
routes.txt
calendar.txt
calendar_dates.txt
routes.txt
shapes.txt
trips.txt
attributions.txt
frequencies
levels.txt
stops.txt
transfers.txt
pathways.txt
fare_attributes.txt
stop_times.txt
translations.txt

Note:  feed_info.txt is optional but required if translations.txt is provided. Therefore, one must check the existence of translations.txt in the first place, then proceeed to semantic validation.

This issue is to ease or formalize the order to process entities @maximearmstrong

This GTFS data model (from TransitWiki) may help with the IDs:

@lionel-nj From a quick scan the above list mostly looks good! One change - fare_attributes.txt needs to be before fare_rules.txt.

Oh, and frequencies.txt needs to be before trips.txt.

Oh, and frequencies.txt needs to be before trips.txt.

Actually, frequencies.txt has a field trip_id that refers to trips.txt, so I think that it should be after trips.txt

@lionel-nj Ah, sorry, you're right - got that one backwards.


Confusing error when creating a "Page" collection

Description
I tried to create a Page collection, but got the error blow - and the only thing i found after a while of searching is this Japanese forum site telling me it's already an internal collection
Steps to reproduce

add the collection:

templates: {
  Page: '/:title',
},

Run gridsome develop

I think it's obvious, but if you want I can make a repo if you want.
Expected result

it should work
or i should throw a clear error message.
and it should be mentioned in the docs

Actual result
I got this error:

Error: Cannot get field 'id' from type 'Page'. Field does not exist.

Environment
Paste the information here as shown by gridsome info
  System:
    OS: Linux 5.8 Pop!_OS 20.04 LTS
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
  Binaries:
    Node: 12.20.1 - /tmp/yarn--1611241092687-0.4657089396725618/node
    Yarn: 1.22.5 - /tmp/yarn--1611241092687-0.4657089396725618/yarn
    npm: 6.14.10 - /usr/bin/npm
  Browsers:
    Firefox: 84.0.2
  npmPackages:
    @gridsome/plugin-google-analytics: ^0.1.0 => 0.1.1
    @gridsome/remark-prismjs: ^0.2.0 => 0.2.0
    @gridsome/source-filesystem: ^0.6.2 => 0.6.2
    @gridsome/transformer-remark: ^0.6.4 => 0.6.4
    gridsome: ^0.7.23 => 0.7.23
    gridsome-plugin-netlify-cms: ^1.0.9 => 1.0.9
    gridsome-plugin-tailwindcss: ^3.0.1 => 3.0.1

Yeah I just ran into that myself. It took a bunch of troubleshooting before I realized Page must be an internally used name. It'd be great if there was an error message that let me know that right off the bat.

Yeah I just ran into that myself. It took a bunch of troubleshooting before I realized Page must be an internally used name. It'd be great if there was an error message that let me know that right off the bat.

Page and Node are reserved type names in gridsome.
Reference: https://github.com/gridsome/gridsome/blob/f9cfa4b3a4c5156c55001320b8771504438df479/gridsome/lib/graphql/utils.js#L19

Page and Node are reserved type names in gridsome.
Reference: https://github.com/gridsome/gridsome/blob/f9cfa4b3a4c5156c55001320b8771504438df479/gridsome/lib/graphql/utils.js#L19

@noxify Yeah thanks, but this issue is not about that. I have figured out the underlying issue.
Don't you care about developer experience?
No offense if you don't have time for these details, I can understand if that is the case. But otherwise... :tipping_hand_man:

@noxify Yeah thanks, but this issue is not about that. I have figured out the underlying issue.
Don't you care about developer experience?
No offense if you don't have time for these details, I can understand if that is the case. But otherwise... :tipping_hand_man:

You're right 🙈
Have seen just the keywords for Page and does not work in the next - not the error below.
Sorry for that.

You're right 🙈
Have seen just the keywords for Page and does not work in the next - not the error below.
Sorry for that.

or i should throw a clear error message.

Alternative, we could print a warning and exclude the templates definition.
throw and warn could be added somewhere here:
https://github.com/gridsome/gridsome/blob/888317662d84995a2da622845b7c6bbe622d2254/gridsome/lib/plugins/TemplatesPlugin.js#L134

and it should be mentioned in the docs
Where would you suggest the changes?

For both points - If you want, feel free to create a PR with a fix ✌

or i should throw a clear error message.

Alternative, we could print a warning and exclude the templates definition.
throw and warn could be added somewhere here:
https://github.com/gridsome/gridsome/blob/888317662d84995a2da622845b7c6bbe622d2254/gridsome/lib/plugins/TemplatesPlugin.js#L134

and it should be mentioned in the docs
Where would you suggest the changes?

For both points - If you want, feel free to create a PR with a fix ✌

Yes! I like it!
I want to take responsibility for open source projects I use.
I put it on my to-do list for next week. Let's see what happens :p

Yes! I like it!
I want to take responsibility for open source projects I use.
I put it on my to-do list for next week. Let's see what happens :p

I'd lean toward throwing an error rather than warning and ignoring. Having an entire collection fail is a pretty big issue that probably needs an immediate fix. And if the error message is clear, it should be a straightforward fix.

I'd lean toward throwing an error rather than warning and ignoring. Having an entire collection fail is a pretty big issue that probably needs an immediate fix. And if the error message is clear, it should be a straightforward fix.


onLangChange not working

Hi,
Is there more detailed documentation on onLangChange event, i.e. how to use it in different components?

It's an observable, so you can use it just like any observable.
I use it in the TranslatePipe if you want to see an implementation: https://github.com/ocombe/ng2-translate/blob/master/src/translate.pipe.ts#L115-L117

thanks! got it working!


Where is the google.apis.jobs.v3 NuGet package?

Hi,
I am trying to install the package google.apis.jobs.v3 into my project, however this is not findable on NuGet as per the documentation?
https://www.nuget.org/packages?q=google.apis.jobs
https://cloud.google.com/talent-solution/job-search/docs/libraries

Hi @Asadlerpwcom,
Sorry we didn't reply to this before. Normally the library would have been created automatically, but there's been a problem with the build recently. @chrisdunelm is keeping track of the situation, and can probably comment further.
(I note that the previous version was actually called Google.Apis.JobService.v2 - it's possible that the v3 will be Google.Apis.JobService.v3 rather than Google.Apis.Jobs.v3. If that's the case, we'll try to get the web page updated.)

@Asadlerpwcom jobs v3 has been renamed Google.Apis.CloudTalentSolution.v3 and is now available on nuget.

And I've submitted an internal change request for the incorrect documentation. Not sure how quickly that'll get updated though!

Brilliant!
Thanks guys :)

https://cloud.google.com/talent-solution/job-search/docs/libraries was updated a while ago. Closing.


Add Selection Based support for Java

Platform: win32

Selection Based runner not available for Java.
If it should exist, add an issue on GitHub, or send your own pull request.
^C


parser: develop unit tests to map onto individual methods in parser module

parser: develop unit tests to map onto parser

See this original generalized ticket for some ideas on unit testing: #95 .

Completed and merged!


gulp.watch stops working when all tests pass

I have following gulp tasks
const test = (files) => {
  return gulp.src(files)
    .pipe(ava())
}

gulp.task('test', () => test('./test/**/*.js'))
gulp.task('test:watch', () => gulp.watch(['./test/**/*.js', './app/scripts/**/*.js'], ['test']))

When I start test:watch task, change some file, some tests fail and watch will keep watching. When all tests pass and I change some file, nothing is happening
cmd output
gulp test:watch
[11:48:00] Using gulpfile C:\test\gulpfile.js
[11:48:00] Starting 'test:watch'...
[11:48:00] Finished 'test:watch' after 26 ms

# I change file, test task starts

[11:48:04] Starting 'test'...
[11:48:07] 'test' errored after 2.51 s
[11:48:07] Error in plugin 'gulp-ava'
Message:
  4 passed  1 failed

  1. add cell

  t.same(game.addCell([], 0, 1), [[0, 0]])
              |
              [#Array#]

  AssertionError: [ [ 0, 1 ] ] === [ [ 0, 0 ] ]
    Test.fn (test/world.test.js:27:5)

# I fix failing test, test task starts

[11:48:12] Starting 'test'...
[11:48:15] gulp-ava:
  5 passed

# All tests passed, I change file again and nothing is happening

OS: win10

Ditto. Task stops if all asserts are OK. Same on Win7 and MacOS. Running gulp-watch version 0.8.0.

I tried updating to latest version and as #10 claims, problem seems to be fixed.


[DROOLS-1353] temporarily remove examples from distribution assembly

I guess it would be good to add a comment saying why the stuff is commented out.
Also, should we at least include the other binaries? With most of the assembly file commented out, the resulting zip will just contain sh|bat scripts, for examples, which are not there. I think we should either completely disable the distribution or at least add back the other binaries. WDYT?


Rotala - Example in Python

Add examples folder
Add standalone Python project with UistV1 interface, thin broker, and moving average strategy.
Add README.md explaining usage
This should use a Binance source

Closed with - acf5470e749e2fd45668e862c3fa62ad057f3b46 - couldn't do Binance because backend isn't setup.


no coordination between AFK kick and disconnect re-add of users

if a user is kicked from the queue for AFK greater than 60 min and then disconnects, beavis still has them marked to be re-added to their previous position, despite them still being in AFK status.
some of the users have noted this behavior and take advantage to regain their spot after being kicked for AFK. once they regain their previous queue position, they chat to reset AFK
29 Jan 15:46:12 [WARNING]  [Bot]      [IDLE] 5. rzaleu last active 67 minutes ago
29 Jan 15:46:12 [WARNING]  [Bot]      [IDLE] rzaleu was last warned 4 minutes ago
29 Jan 15:46:13 [INFO]     [Bot]      [CHAT] BeavisBot: @rzaleu Everyone is welcome to listen to the music while AFK but we ask that if you wish to DJ you be able to respond to an @ mention in chat.
29 Jan 15:49:22 [INFO]     [Bot]      [JOIN] rzaleu last seen 3 minutes ago
29 Jan 15:49:28 [INFO]     [Bot]      [CHAT] BeavisBot: /me put @rzaleu back in line :thumbsup:
29 Jan 15:46:25 [INFO]     [Bot]      [LEAVE] User left: rzaleu
29 Jan 15:50:27 [INFO]     [Bot]      [CHAT] FoBoT: .afk
29 Jan 15:50:27 [INFO]     [Bot]      [ACTIVE] 1. chanty last active 50 minutes ago
29 Jan 15:50:27 [INFO]     [Bot]      [ACTIVE] 2. aeroplanist last active 47 minutes ago
29 Jan 15:50:27 [INFO]     [Bot]      [ACTIVE] 3. Eduardo_NBA last active 25 minutes ago
29 Jan 15:50:27 [INFO]     [Bot]      [ACTIVE] 4. MarsjMellow. last active 42 minutes ago
29 Jan 15:50:27 [WARNING]  [Bot]      [IDLE] 5. rzaleu last active 72 minutes ago
29 Jan 15:50:27 [INFO]     [Bot]      [CHAT] BeavisBot: Currently idle: rzaleu
29 Jan 15:50:37 [WARNING]  [Bot]      [IDLE] 4. rzaleu last active 72 minutes ago
29 Jan 15:50:37 [WARNING]  [Bot]      [IDLE] rzaleu was last warned 8 minutes ago
29 Jan 15:50:38 [INFO]     [Bot]      [CHAT] BeavisBot: @rzaleu Everyone is welcome to listen to the music while AFK but we ask that if you wish to DJ you be able to respond to an @ mention in chat.
29 Jan 15:50:48 [INFO]     [Bot]      [CHAT] FoBoT: @rzaleu  you can't disconnect to defeat the afk requirements, you need to chat before rejoining the queue
29 Jan 15:50:52 [INFO]     [Bot]      [LEAVE] User left: {DON}
29 Jan 15:51:21 [INFO]     [Bot]      [LEAVE] User left: rzaleu
29 Jan 15:51:48 [INFO]     [Bot]      [JOIN] rzaleu last seen a few seconds ago
29 Jan 15:51:53 [INFO]     [Bot]      [CHAT] BeavisBot: /me put @rzaleu back in line :thumbsup:
29 Jan 15:52:15 [INFO]     [Bot]      [CHAT] FoBoT: @rzaleu  i am going to temp ban you if you don't chat and stop dc'ing to get back on queue
29 Jan 15:52:18 [INFO]     [Bot]      [CHAT] AvatarKava: @FoBoT can you grab that couple lines of chat log with this and open a ticket here?
29 Jan 15:52:22 [INFO]     [Bot]      [CHAT] rzaleu: lel
29 Jan 15:52:24 [INFO]     [Bot]      [CHAT] rzaleu: its my net
29 Jan 15:52:28 [INFO]     [Bot]      [CHAT] rzaleu: shitting today]

Should be fixed as of this last commit.


Semantics: appWasMade

I think we should reword function appWasMade to isInApplication or isBeingReviewed or something else to better describe the stage/timing of the domain's current state. Since items in listingMap are deleted during resetListing, it could be confusing if appWasMade correctly returns false for an application that i definitely made, but is completed and already whitelisted.

agreed, isInApplication is better imo

Just so we have it here to look at: https://github.com/AdChain/AdChainRegistry/blob/cf0d0f5e666ada661ee24269b8650b2ce944faaf/contracts/Registry.sol#L306-L309

Actually, I take this back. items in listingMap only get deleted by resetListing if and only if:

a challenge succeeds
the applicant invokes exit
the listing struct's unstakedDeposit is for some reason less that the minimumDeposit

So appWasMade returns true (as expected) for white-listed applications.
My apologies for this misunderstanding. I was definitely confused.

If a domain applies and either is or is not listed, we don't care, then it is true forever that that domain did apply. Semantically. So maybe this needs to be named isInApplicationOrIsListed?

domainIsActive
domainWasInitialized

I'm not afraid of long method names.

Right on! Let's go with domainIsInApplicationOrIsListed then since it's the most specific.


Create test artifacts for windows arm64

PR Summary
We need to build the test artifacts for testing on Windows ARM64. This is required so that the co-ordinated build will generate the test artifacts for release automation.
A test build was run to verify that the package is created.
PR Context

PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

/backport to release/v7.2.9


Rename RimOutline so there's only one 'Mixed Reality Toolkit' item in the Shader list.

Overview
Renamed the path for the shader so it fell under the same folder.
Changes
Previously:

Now:

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run


"Enable allLogs category group resource logging for supported resources to Log Analytics" creates duplicate logs for Application Insights already using a Log Analytics Workspace

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

module: 6.0.0
Description
Describe the bug
I already have an Application Insights resource which is using a Log Analytics workspace configured via the WORKSPACE config option (actually configured via azurerm_application_insights/workspace_id).  This sends all logs to the Log Analytics workspace.   I believe this configuration can not be removed.
If I remediate the policy "Enable allLogs category group resource logging for supported resources to Log Analytics" it creates a Diagnostic Setting "setByPolicy-LogAnalytics" for the Application Insights resource which also sends all logs to the Log Analytics workspace.  Hence duplicate logs are stored in the Log Analytics workspace.

Hi djbark, I looked at the documentation for the azurerm_application_insights resource and the workspace_id is optional (I didn't do any testing, but I believe you can comment on this parameter and see how the plan behaves).
Or if you want to control it through the resource, I believe another option is to add an exemption to this policy/resource and remove the setbypolicy that it will not create again.

@diegosrp It is optional, but once added it cannot be removed (at least not without deleting and re-creating the resource).  Furthermore my understanding is that the recommendation is to migrate to workspace-based Application Insights resources so would seem a backwards step.
I would rather not do exemptions to individual policies that are part of an initiative provided as part of the CAF, but maybe that is the only option.

I understood.
In my view, I see CAF as the best practices/recommendations, however it is not suitable for all businesses, sometimes we have a compliance requirement or something that will not meet our needs and we need to adjust.
Regarding exemption, you can put it in the specific resource_id, meaning it will not only apply to the specific resource.

Also, Microsoft seems to have updated their documentation recently.   The blurb in the red caution shown above seems to have been made less prominent, no longer in red and no longer a caution.  The information presented is similar though: https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/diagnostic-settings#diagnostic-logs-for-application-insights


Stopped building other services for integ tests

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   41.05%   41.05%
=======================================
  Files           8        8
  Lines         380      380
=======================================
  Hits          156      156
  Misses        216      216
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fab66...e9ca514. Read the comment docs.


Inherited resource fails to load into Array[]

Godot version
4.1
System information
v4.1.stable.official [970459615]
Issue description
See Steps to reproduce.
Steps to reproduce

Create a resource called CardFunction.gd inherited from Resource, which has class_name CardFunction
Create a script that inherits CardFunction called test_card_func.gd;
Create a Node2D which exports variable like this: @export var card_functions: Array[CardFunction]
Assign test_card_func.gd to Node2D exported variable card_functions in the editor.
Run the game to find the variable card_functions is empty.
Changing definition from Array[CardFunction] to Array[Resource] successfully loads the test_card_func.gd resource, but when I transfer items of Array[Resource] into another defined variable Array[CardFunction] in my code, the items are lost.

Minimal reproduction project
Not needed.

Closing this issue, not a bug, my mistake. Just confused gdscript with custom resource. Sorry for the inconvenience.
Assigning gdscript to Array[CardFunction] item is actually not allowed in the editor, assigning to Array[Resource] works but GDScript is not CardFunction so the item gets lost.
Should create an resource with the a script on it, not assigning the script directly to a custom resource slot ...


feat: add ni-redirect initial implementation

Describe your changes
https://pins-ds.atlassian.net/browse/BOAS-1426
Added a new package, which is a Cloudflare Worker, for handling NI redirects.
Ticket + ACs need refining before we merge/finalise.
Useful information to review or test

Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

Tested new pipeline here:
https://dev.azure.com/planninginspectorate/applications-service/_build?definitionId=176&_a=summary
Will recreate once on main.

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Filenames containing special characters renamed to HTML encoded variant

For example, file named helloworld#1.jpg in perforce is renamed to helloworld%231.jpg in git.
File named helloworld%1.png in perforce is renamed to helloworld%251.png.
# = %23
% = %25
I assume that somewhere where files is being requested you simply use end of url as file name

I assume that somewhere where files is being requested you simply use end of url as file name

We do take the file name that we get back as is, but apparently there is some HTML encoding taking place which shouldn't actually be there.

I can patch it, got any pointers where to look?

@ppavacic Thank you for looking! Probably could start here by seeing how BranchedFileGroups is handling file paths, because that's what in the end goes to the GitAPI like so

@twarit-waikar  not sure which url-decode library should I add? Do you have any suggestions?


Error: uv_os_get_passwd returned ENOENT

Applies To

[X] Notebooks (.ipynb files)
[X] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
Hello,
when opening a python file, vs code reports
"Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information.
Source: Jupyter (Extension).".
Unfortunately, the extension can not be used.
One thing that might be of interest: My user is not listed in /etc/passwd as we use LDAP. VS Code and every file etc. is local.
Thanks in advance!
VS Code Version
Version: 1.80.1 Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771 Date: 2023-07-12T17:22:25.257Z Electron: 22.3.14 ElectronBuildId: 21893604 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: <IP_ADDRESS>-electron.0 OS: Linux x64 5.19.0-46-generic snap
Jupyter Extension Version
v2023.6.1101941928
Jupyter logs
Command 'Jupyter:Schow Output' resulted in an error
command 'jupyter.viewOutput' not found

From the Developer Tools:

notificationsAlerts.ts:42 Extension activation failed, run the 'Developer: Toggle Developer Tools' command for more information.
c @ notificationsAlerts.ts:42
log.ts:441   ERR [Extension Host] extension activation failed Error: No matching bindings found for serviceIdentifier: Symbol(IExtensions)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534020
	at b (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534309)
	at w (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534396)
	at t.plan (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:535475)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519947
	at e._get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519466)
	at e._getButThrowIfAsync (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519526)
	at e.get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:515221)
	at gb.get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:231680)
	at ks (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:1739411)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622600
	at yP (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622650)
	at Tn.eb (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13743)
	at Tn.db (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13456)
	at /snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:11577
	at async w.n (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6194)
	at async w.m (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6157)
	at async w.l (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:5614)
console.ts:137 [Extension Host] extension activation failed Error: No matching bindings found for serviceIdentifier: Symbol(IExtensions)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534020
	at b (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534309)
	at w (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:534396)
	at t.plan (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:535475)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519947
	at e._get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519466)
	at e._getButThrowIfAsync (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:519526)
	at e.get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:515221)
	at gb.get (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:231680)
	at ks (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:2:1739411)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622600
	at yP (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622650)
	at Tn.eb (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13743)
	at Tn.db (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13456)
	at /snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:11577
	at async w.n (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6194)
	at async w.m (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6157)
	at async w.l (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:5614)
v @ console.ts:137
console.ts:137 [Extension Host] rejected promise not handled within 1 second: SystemError [ERR_SYSTEM_ERROR]: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)
v @ console.ts:137
console.ts:137 [Extension Host] stack trace: SystemError: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)
	at new SystemError (node:internal/errors:238:5)
	at new NodeError (node:internal/errors:349:7)
	at userInfo (node:os:347:11)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:615981
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:617204
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622532
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622540
	at yP (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622650)
	at Tn.eb (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13743)
	at Tn.db (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13456)
	at /snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:11577
	at async w.n (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6194)
	at async w.m (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6157)
	at async w.l (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:5614)
v @ console.ts:137
mainThreadExtensionService.ts:81 [ms-toolsai.jupyter]A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:81
mainThreadExtensionService.ts:82 SystemError: A system error occurred: uv_os_get_passwd returned ENOENT (no such file or directory)
	at new SystemError (node:internal/errors:238:5)
	at new NodeError (node:internal/errors:349:7)
	at userInfo (node:os:347:11)
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:615981
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:617204
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622532
	at /home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622540
	at yP (/home/USER/.vscode/extensions/ms-toolsai.jupyter-2023.6.1101941928-linux-x64/out/extension.node.js:24:622650)
	at Tn.eb (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13743)
	at Tn.db (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:13456)
	at /snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:113:11577
	at async w.n (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6194)
	at async w.m (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:6157)
	at async w.l (/snap/code/134/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:99:5614)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:82
log.ts:421

Coding Language and Runtime Version
Python 3.10.6
Language Extension Version (if applicable)
v2023.12.0
Anaconda Version (if applicable)
N/A
Running Jupyter locally or remotely?
Local

Hopefully that change fixes the issue, should be available in the pre-release version of the extension tomorrow, or you can try installing the built visx directly:
ms-toolsai-jupyter-insiders.vsix (11).zip

Thank you very much!


Feature Request: Add support for Multiplexed accounts as an experimental feature

What problem does your feature solve?
Multiplexed Accounts (CAP27) were added to protocol 13. As an efforts to promote adoption JS and GO SDKs are being updated to support these. We should provide a way for developers to test multiplexed accounts in the Lab. Until this is fully rolled out, make sure the UI notes this is experimental.
What would you like to see?

[ ] Ability to create muxxed accounts addresses from an account and extra info
[ ] Parse info based on a muxxed address
[ ] Upgrade the SDK and turn on the muxxed accounts feature flag

Figma file here.
Keeping this behind an "Experimental Tab" for now.

I have some comments about the following two pages in the Figma file.

It looks like the inputs to creating a multiplexed account from an account is only the G strkey. The user should also need to input a uint64 value that we refer to as the ID. The account and ID will be combined to form the multiplexed account M strkey.

The page 3 below also shows an XDR Object. What's the use case for that? I doubt there would be value in providing that. The M strkey is the value developers will use. We don't offer XDR objects base64 encoded for other components, even though provide decoding of them on the View XDR page.

The introduction needs tweaking because an M address doesn't resolve a single G address to many different IDs, an M address resolves to a G address and an ID. The term resolves here has some other meaning that doesn't read to me like what I think we're intending. I suggest rewording this to:

A muxed account is an account that multiplexes a single Stellar account by encoding an identifier in the address alongside the Stellar account. A muxed account is an M address that encodes a G address and an identifier.

Create Multiplexed Account

I think in most places we are surfacing these new addresses in code we are calling them Muxed Accounts. Could we use only that terminology to create a single ubiquitous term for these accounts?

Create subaccount from existing G account address

I think we should reword this to match the terminology used on the Create Account page and refer to the G account address as the Public Key, so that the language we use is consistent and ubiquitous.
I also think the term subaccount implies that there will be an account on the network. The term used in CAP-27, "virtual account," implies that the account does not exist on network.
Can we get away without this text? The heading immediately above Created Multiplexed Account probably says all we need here?

Figma File Page 2:

Figma File Page 3:

Keeping this behind an "Experimental Tab" for now.

What's the motivation for putting this under an experimental tab?

@leighmcculloch Thanks for reviewing this! I'll address each here.

I was initially looking at createSubAccount in the Account class but I understand we want to use the MuxedAccount instead. I'll create a field for the string input.

| The page 3 below also shows an XDR Object. What's the use case for that?
If this isn't useful we can strike it. I was providing output for properties of the MuxedAccount returned in the parse. Although I did leave out the base account and sequence number properties as I thought they were redundant.

| The introduction needs tweaking
I'll change the wording to what you provided. The current text was lifted right off the SDK and was placeholder to expand on.

RE: Multiplexed vs Muxed Account terminology: The SEP and CAP refer to MuxedAccount when referencing code but not "Muxed Account", otherwise they are Multiplexed Accounts. I can see where in this instance we can use MuxedAccount, but in the intro I would refer to them as Multiplexed Accounts.

I think what would work better here would be to remove the heading "Create Multiplexed Account" with something else. The two actions on the page are to create an account and parse the account. I'll change "Create subaccount from existing G account address" to Create MuxedAccount from Public key". I'll also change the wording "Get MuxedAccount from M address" to "Get MuxedAccount from M Address"

| What's the motivation for putting this under an experimental tab?
We aren't advocating for mass adoption of Multiplexed Accounts until we do education/outreach and see wallet support. Given that, it's a good idea to add this disclaimer in the intro.

createSubAccount in the Account class

Ah, interesting. We probably shouldn't have used the 'subaccount' terminology there either. MuxedAccounts may be virtual accounts, but that is just one use case, they can also be invoices and other things. I opened an issue to fix that: https://github.com/stellar/js-stellar-base/issues/433.

4. The SEP and CAP refer to MuxedAccount when referencing code but not "Muxed Account", otherwise they are Multiplexed Accounts.

What value do we get out of using Multiplexed as the noun for this in some places and Muxed in others? I think it's fine if we use the term multiplexed to describe what a Muxed Account is, but I think we need to weigh the value in using multiple different names/nouns for a concept. Building a ubiquitous language is really helpful for developers and reduces the overall complexity of building on Stellar. Every time we add a new feature to Stellar it gets more complex. Every time we use multiple terms for that new thing we multiply the complexity and the ambiguity. It's not just code, but the Horizon API refers to these accounts as muxed, and it will be likely that explorers will follow suit since explorers typically use the terms our SDKs use.

6. | What's the motivation for putting this under an experimental tab?
We aren't advocating for mass adoption of Multiplexed Accounts until we do education/outreach and see wallet support. Given that, it's a good idea to add this disclaimer in the intro.

Got it. Did we consider placing these tools where we'd expect them to go long term, with a label/description that indicates they are experimental? A disadvantage of placing tools on an experimental tab is that they are likely to move when they are no longer experimental. This will create more work when it comes time to make them not experimental, and will require folks using the tool to rediscover the tool once it moves.

The SEP and CAP refer to MuxedAccount when referencing code but not "Muxed Account", otherwise they are Multiplexed Accounts.
Sorry I wasn't clear. I'm advocating to only use either "Multiplexed Account" or "MuxedAccount" in Lab or any future tool we add support to. This would follow convention already established in code and SEP/CAP.
Are you advocating to use "Muxed Account" in any reference materials or tools we create?

RE: Putting this behind the Experimental tab:
Those are good points you make about visibility and having to rediscover them again. The 2 changes would be: Create Account tab would now show the ability to create a MuxedAccount, and "Getting MuxedAccount from M address" could be achieved using the Account endpoint. I'll have another look at the UI and get some more feedback. I'm not too worried about the work to wrap these back into regular UI although @quietbits may have a different opinion :)

Are you advocating to use "Muxed Account" in any reference materials or tools we create?

Yup, because SDKs and APIs already use this term. It would be very difficult at this point to change those things to use the term multiplexed.

I like the idea of putting these features where they will end up in the future. It wouldn't be that much work for us to move them but it will be much easier for users to find them (not wonder where they went later on).

updated figma file

@quietbits as turning on the muxxed accounts feature flag will turn on support in operations and transactions, please add validation in form input fields where M accounts could be provided. This should be anywhere a G address is valid.

@quietbits please also update the "Experimental" syntax in the Create Muxed Account tab.

@shanzzam Will do! Sorry I missed the updated Figma design. 😬

Will review 6/22

Review passed. @quietbits  Ready for merge.