Why does the browser open for so long?

Here is a simple project: https://github.com/andreirogal/selene-experiments
2 tests pass in 32 seconds!
The first start is quick but after very slow.
On a native Selenium WebDriver all launches are fast.

@andreirogal today i tried to reproduce your issue with pyproject.toml configuration.
I have the result in 15.35 seconds total for selene tests - both failing.
I saw @yashaka video on youtube and I've noticed that google.com opens instantly, but page loading takes a time and it's waiting much longer on the video than I see now on today's executions.
Here are today's logs from your project execution.

pytest --tb=short tests/test_selene.py 15.35s
test_selene.log
pytest --tb=short tests/test_native_selenium.py 22.44s
test_native_selenium.log

P.S. I saw that in selene you use 2 sec default timeout and in selenium 5 sec default timeout, i think that's why your selene tests today are faster than selenium.
So I think it was something with connection or browser/webdriver version or google.com site because I don't see any problem with 2.0.0a21 selene version. 🙂

@aleksandr-kotlyar now the tests pass in 36s for Selene 2.0.0a21 and 28s for Selenium.

poetry run pytest --tb=short .\tests\test_selene.py
test_selene_28_03_2021.log
session ~36s

poetry run pytest --tb=short .\tests\test_native_selenium.py > test_native_selenium.log
test_native_selenium.log
session ~28s

P.S. It's hard for me to tell if it's fast or slow for Selene. :)

@andreirogal It is very interesting. Let's try again with new kind of logs https://github.com/andreirogal/selene-experiments/pull/2 and now with option --tb=no to clean unnecessary stacktraces.
poetry run pytest tests/test_selene.py --tb=no
test_selene.log
poetry run pytest tests/test_native_selenium.py --tb=no
test_native_selenium.log

@aleksandr-kotlyar here are the results after the merge:

poetry run pytest tests/test_selene.py --tb=no
test_selene
~36s

poetry run pytest tests/test_native_selenium.py --tb=no
test_native_selenium
~26s

Thank you @andreirogal . Interesting thing I see... retry in six times with 2 second pause in your logs:
https://github.com/andreirogal/selene-experiments/blob/1f1d69fbdc2c3c542410703eaa3a2a9cda109daf/logs/test_selene_28_03_2021_2.log#L24-L30
and in my logs - no pause between retries - only 3 seconds after the last one:
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d607b90>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903/title (connectionpool.py: 745)
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d5cadd0>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903/title (connectionpool.py: 745)
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d61cc10>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903/title (connectionpool.py: 745)
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d5e3f90>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903 (connectionpool.py: 745)
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d6a3150>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903 (connectionpool.py: 745)
2021-03-28 14:35:10 [WARNING ] Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x10d6d9350>: Failed to establish a new connection: [Errno 61] Connection refused')': /session/571e3b8f5ba6b19b27dc03db0b11b903 (connectionpool.py: 745)
2021-03-28 14:35:13 [INFO    ] browser start duration: 3.5950987339019775 seconds (test_selene.py:  26)

retry in six times with 2 second pause in your logs:

@aleksandr-kotlyar Yes, I noticed that too. But I can't understand what this is related to.

@andreirogal I think CI will judge our tests: i have MacOS and you have Windows.
On my MacOS machine both selene and selenium are fast: 15s selene and 18s selenium.
On @andreirogal Windows machine test execution time is slow: 36s selene and 28s selenium.
On GitHub Actions Ubuntu test execution time is: 21s selene and 28s selenium - [details|https://github.com/aleksandr-kotlyar/selene-experiments/runs/2212876480?check_suite_focus=true] but difference from run to run: sometimes 15s selene and 27.75s selenium details

On GitHub Actions Ubuntu test execution time is: 21s selene and 28s selenium - details but difference from run to run: sometimes 15s selene and 27.75s selenium details

The must be some feature of the Windows environment... I think we can close this issue.

On GitHub Actions Ubuntu test execution time is: 21s selene and 28s selenium - details but difference from run to run: sometimes 15s selene and 27.75s selenium details

The must be some feature of the Windows environment... I think we can close this issue.

It's still interesting - may be hardware config is different.
@andreirogal Do you have HDD or SSD disk and what processor / memory characteristics do you have on the machine where execute these tests?
I run these tests on i7 2.2 GHz 16 GB Memory and SSD disk.

@aleksandr-kotlyar I run these tests on i7-9750H CPU 2.60GHz, 16 GB Memory, SSD disk and Windows 10 Home v.20H2 OS Build 19042.867

@aleksandr-kotlyar I run these tests on i7-9750H CPU 2.60GHz, 16 GB Memory, SSD disk and Windows 10 Home v.20H2 OS Build 19042.867

Hardware is good. Then it can be an antivirus/firewall (if not custom - then default MS Defender os something like that).

@aleksandr-kotlyar I run these tests on i7-9750H CPU 2.60GHz, 16 GB Memory, SSD disk and Windows 10 Home v.20H2 OS Build 19042.867

Hardware is good. Then it can be an antivirus/firewall (if not custom - then default MS Defender os something like that).

Not sure that it's antivirus. I have analysed logs again https://github.com/andreirogal/selene-experiments/blob/master/logs/test_selene_28_03_2021_2.log and came to conclusion that there is no "gap" between the end of the first test and beginning of the second test. The only one time-spending gap - is when retry's are happening.
2021-03-28 15:43:57 [INFO    ] before start browser: 0.0 seconds (test_selene.py:  24)
2021-03-28 15:43:59 [WARNING ] Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x03FA2170>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11/title (connectionpool.py: 745)
2021-03-28 15:44:01 [WARNING ] Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0445C3F0>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11/title (connectionpool.py: 745)
2021-03-28 15:44:03 [WARNING ] Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0445C890>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11/title (connectionpool.py: 745)
2021-03-28 15:44:07 [WARNING ] Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0445C4D0>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11 (connectionpool.py: 745)
2021-03-28 15:44:09 [WARNING ] Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0445CBB0>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11 (connectionpool.py: 745)
2021-03-28 15:44:11 [WARNING ] Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x0445CCF0>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it')': /session/4cc042bbbd815aeac156822e94427a11 (connectionpool.py: 745)
2021-03-28 15:44:17 [INFO    ] browser start duration: 19.854556560516357 seconds (test_selene.py:  26)

15:43:57-15:44:17 - looks like it takes 20 seconds more than could be! But... there is a time between "before start browser" and "browser start duration" if we look at the first test it's about 3.5 seconds:
2021-03-28 15:43:47 [INFO    ] before start browser: 0.0 seconds (test_selene.py:  13)
2021-03-28 15:43:50 [INFO    ] browser start duration: 3.642312526702881 seconds (test_selene.py:  15)

20 seconds - 3.5 seconds = 16.5 seconds slower test. And it slows only on windows OS. Ubuntu and MacOS doesn't wait between retries.
So,
@yashaka I think we should figure out why these retries are happening in selene and fix them. Also it's very interesting why there is a pause between retries on WindowsOS but it's more to urllib3 and WinOS question.

@aleksandr-kotlyar Then I reopen this issue. It's very interesting how it will be resolved)


awk warning on both files

running the scripts from centos 7 bash (GNU Awk 4.0.2)  the following warning is displayed
awk: warning: escape sequence \ ' treated as plain  '

ok, thanks for letting me know. Will look into this when time permits:)
One question, is the script failing or does it produce a report but you're just getting the explained output on the console?
thanks

The script seems working but you got a lot of random messages on the screen. As example
00  6322    0  6322    0     0  50205      0 --:--:-- --:--:-- --:--:-- 50576
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  734k    0  734k    0     0  2769k      0 --:--:-- --:--:-- --:--:-- 2761k
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100 24548    0 24520  100    28  51972     59 --:--:-- --:--:-- --:--:-- 52059
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  1396    0  1396    0     0  10189      0 --:--:-- --:--:-- --:--:-- 10264
awk: warning: escape sequence \ ' treated as plain  '
awk: warning: escape sequence \ ' treated as plain  '
awk: warning: escape sequence \ ' treated as plain  '
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  9753    0  9753    0     0  82065      0 --:--:-- --:--:-- --:--:-- 82652
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100  3298  100  3298    0     0  14630      0 --:--:-- --:--:-- --:--:-- 14657
awk: warning: escape sequence \ ' treated as plain  '
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed

ok great.
the output , apart from "awk: warning: escape sequence \ ' treated as plain '" is expected since it runs a lot of curl commands.

You can avoid all the awk output using curl -s (...the resrt of the command...) and display instead something like a dot, the vm name that you are processin, and so on...
But is just a point of view :D


Power Rename Option to Stay Open

I would love the ability to keep power rename open after it renames some files.

Duplicate of https://github.com/microsoft/PowerToys/issues/628

Duplicate of https://github.com/microsoft/PowerToys/issues/628


js_logs: find logs inside filesystem not only redis [development_logalert2]

Logs in redis are limited to 1000 log only, need to do find inside file system.

redis and filesystem searches should be available

Commit: https://github.com/threefoldtech/jumpscaleX_core/commit/bd9e2c13d91253278ab13cf21db1ca1420241929
Changelog

Added search in fs

Updated docs at https://github.com/threefoldtech/jumpscaleX_core/blob/bd9e2c13d91253278ab13cf21db1ca1420241929/docs/logger/README.md#js_logs

some fixes for handling errors when redis is not available

Example:

js_logs -a threebotserver find_fs --message "index"

verified.


Configuration options should allow to be configured via connection string

Currently the only supported method of configuring Bunny or MarchHare is by a configuration parameters and not by a connection string.

Are you thinking we parse the connection string with the URI module and then set the corresponding settings in the configuration parameters? That seems like a pretty simple addition.

      def connection_string
        AMQ::Settings.parse_amqp_url(::ActionSubscriber.configuration.connection_string)
      end

I'm for it!

We don't have AMQ available to us, in this project. That is the eventmachine based implementation isn't it?

Bunny has a dependency on amq-protocol-2.0.0.   This is found in that gem.
bunny (2.2.0)
amq-protocol (>= 2.0.0)

Nice. Sorry for the confusion.
Instead of checking for the connection_string when we are about to use the configuration, what if we just exploded the connection string and set the corresponding settings during the configuration step?
module ActionSubscriber
  class Configuration
    ...
    def connection_string=(url)
      settings = ::AMQ::Settings.parse_amqp_url(url)
      settings.each do |key, value|
        send("#{key}=", value)
      end
    end
    ...
  end
end

:+1: I like it.

Closed by #45.


Detected trojan

pepegas

my browser isn't even letting me download it

yeah idk pretty sketchy

read closed issues

he says read closed Issues  but he says that to all issues.....
so where's the answer?

i found it and basically says that its false positive and that its open source so u can compile it urself if ur scared

or you can just allow it on your system

how does that fix the concerns about virus? just allowing it?  XD

you opened the issue about trojan, do u have brain dmg? lol

kkkkkkkkk tu é um nerdola do crlh msm


DASM?

not sure what I am missing.
I unzipped the code, ran the exe under windows with the source and output but i get this error
** ERROR ** There has been an error while trying to execute DASM, please see the bellow message.
Tried to execute: "dasm.exe" "C:\Users\xxxxxxxxxxxxxxxxxx\AppData\Local\Temp\xcbtmp_F943EED8.asm" -o"comp.prg" -sC:\Users\xxxxxxxxxxxxxxxxxx\AppData\Local\Temp\xcbtmp_F943EED8.sym
'"dasm.exe"' is not recognized as an internal or external command,
operable program or batch file.
I don't see and DASM or anything referencing this file?

It looks like your system can't find dasm.exe. Is it installed and added to the PATH?
Note: if you have downloaded dasm but you don't want to add it to the PATH environment variable, you have to specify the full path to dasm.exe like this for example:
xcbasic3.exe --dasm="C:\path\to\dasm.exe" infile.bas outfile.prg

Awesome, works great.
Is there a supporting IDE for XC-Basic you can recommend?
thanks!
Sent with Proton Mail secure email.
On Sunday, December 24th, 2023 at 3:13 AM, Csaba Fekete @.***> wrote:

It looks like your system can't find dasm.exe. Is it installed and added to the PATH?
Note: if you have downloaded dasm but you don't want to add it to the PATH environment variable, you have to specify the full path to dasm.exe like this for example:
xcbasic3.exe --dasm="C:\path\to\dasm.exe" infile.bas outfile.prg
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

There's a Visual Code plugin for XC=BASIC: https://marketplace.visualstudio.com/items?itemName=RealOrlof.orlof-xcbasic3
Or you can use any text editor. The ones I personally use are Geany and Textadept because they're easy to configure. They highlight BASIC source code very well and it is easy to add one-click compile commands.


Update for newer Data menu histories_transfer_entire_histories_from_o…

Updated Data menu navigation

More FAQs need this. I'll try to get to them this week. But push this out first since link is posted in some important places.


Base Score - Wrong scale

First of all, thank you for providing such an exciting utility.
In the code, the base score is assumed to be in the logit scale (for example, when defining tree_leafs in XGBScorecardConstructor.construct_scorecard). However, the following MRE shows that the base score seems to be instead in the probability scale:
import xgboost as xgb
from sklearn.datasets import load_breast_cancer
from xgboost import DMatrix
from xbooster.constructor import XGBScorecardConstructor

import numpy as np
from scipy.special import expit

data = load_breast_cancer()
X, y = data.data, data.target

# Build and fit classifier with only two trees
model = xgb.XGBClassifier(n_estimators=2, eval_metric='logloss')
model.fit(X, y)

# Retrieve base score using constructor class
scorecard_constructor = XGBScorecardConstructor(
    model, X, y
)
bscore = scorecard_constructor.base_score

# Return scores using individual trees
individual_preds = [tree.predict(DMatrix(X), output_margin=True) for tree in model.get_booster()]
# hacky way to get base score
# base_score_matrix = (base score + score_T1)+ (base_score + score_T2) - (base_score + score_T1 + score_T2) = base_score
# NOTE: this must be in the logit scale
base_score_matrix = sum(individual_preds) - model.predict(X, output_margin=True)
# Transform into probability scale
base_score_matrix = expit(base_score_matrix)

# Assertion
check_arr = np.isclose(base_score_matrix, bscore)
assert np.all(check_arr), "Base score not in probability scale"

The trick is to use two trees only to have the base score repeated twice in their individual predictions, and then substract the actual prediction in the raw score scale (logit) to identify the actual raw score being used, again in the logit scale. Then I compare it against the base score used in the XGBScorecardConstructor class. They only match after transforming the former into the probability scale, that is why the assertion does not fail. I would advise to add this idea as a test to the test suite at some point.
Happy to help if this indeed needs some fixing 😄

Further evidence that the base score is in the probability scale, in this demo the base score is defined as 0.5.


Add CC_FOR_BUILD and CXX_FOR_BUILD

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Should we put together a repo or something with cross-compilation tests?

What did you have in mind?

Well we could extract some of the tests code for FORTRAN etc, build on Linux 64 with qemu or somethjng and then run the recipe tests.

Right now iiuic we'd have to test actual cross compiled code by hand. It might be good to have something automated.


Question: does the kissbom-spec meet NTIA standards for Baseline Attributes

Please refer to Section 2.2 Baseline Attributes of the document
ntia_sbom_framing_2nd_edition_20211021.pdf
which can be downloaded from
https://www.ntia.gov/SBOM
using the first link under the section "Understanding SBOM".
Note that the success (widespread adoption) of any proposed SBOM format will need to meet the minimum standards described in that document.
At first glance, the kissbom can probably do the job, but I think it would be important to document exactly how that works.

In https://www.ntia.gov/files/ntia/publications/ntia_sbom_framing_2nd_edition_20211021.pdf the core elements are listed in the 2.2 Baseline Attributes section.  Based on this, we could have this mapping in a kissbom:

2.2.1 and 2.2.2 can be encoded in the kissbom filename using a  convention TBD
2.2.3, 2.2.4, 2.2.5, 2.2.6 and 2.2.7: all are encoded/encodable in the Package URL
2.2.8 defaults to includes and this the relationship supported in kissbom.

And in particular:

NTIA field
NTIA definition
kissbom mapping

2.2.1 Author Name:
author of the SBOM.
encoded in the kissbom filename

2.2.2 Timestamp:
date and time when the SBOM was last updated.
encoded in the kissbom filename

2.2.3 Supplier Name:
name or other identifier of the supplier of a component in an SBOM entry.
implied in the Package URL type:name/namespace

2.2.4 Component Name:
name or other identifier of a component.
Package URL type:name/namespace

2.2.5 Version String:
version of a component.
Package URL version

2.2.6 Component Hash:
cryptographic hash of a component.
Package URL checksum qualifier

2.2.7 Unique Identifier:
additional information to help uniquely define a component.
Package URL

2.2.8 Relationship:
association between SBOM component.
defaults to includes and this the relationship supported in kissbom.

extra details for 2.2.7:

A unique identifier can be generated relative to some globally unique hierarchy or namespace or reference an existing global coordinate system. Some systems that could be used as unique identifiers include Common Platform Enumeration (CPE),Package URL (PURL),Universal1415Unique Identifier (UUID) (also known as Globally Unique Identifier [GUID]),and Software16Heritage ID (SWHID).Component Hash (Section 2.2.6)may effectively function as a Unique17Identifier.

extra details for 2.2.8

The relationship between components is inherent in the design of the SBOM model. The default relationship type is includes.

So the spec could stand as it is.

And wrt. 2.2.8 Relationship

A relationship type of primary is used when a component has no upstream dependencies identified in the SBOM. The primary component defines the subject of the SBOM [...], including cases where the SBOM only includes one component.

For this the first entry in the kissbom becomes naturally the primary one.

@pombredanne   thanks for the detailed response -- looks like the various requirements are being addressed

Adding the NTIA docs for reference:

ntia_sbom_framing_2nd_edition_20211021.pdf

ntia_sbom_software_identity-2021mar30.pdf


Disable safecrlf when running git-diff

@Shatur95, can you give this a go?

Yes, worked for me. Tested with core. autocrlf true (and happens on main).

Thanks 🙂


feat: Add append support for azdfs

Azdfs support append but we didn't implement it yet.

I'd like to try on this issue when https://github.com/apache/incubator-opendal/issues/2965 is done

I'm going to work on this issue this weekend.

Hi @Xuanwo, sorry I'm busy with my work recently, you can unassign me & give the opportunity for community. Sorry again.


fix(docs): remove unnecessary object destructuring

Unless it's a new trend to destructure an object to pass multiple props to a component, I think we should avoid it :)

I somewhat agree with you, but this is actually what Tanner likes doing and recommends. There was a whole tweet thread about it a couple years ago.

I somewhat agree with you, but this is actually what Tanner likes doing and recommends. There was a whole tweet thread about it a couple years ago.

Ok. I didn't know about that. So I'm gonna close it.


Implement << operator

Add support for << operator to append a child node.
For example:
e = html.ul()
e << html.li("one")
e << html.li("two")
e << html.li("three")

This makes the code a lot more readable and easy to write.

Done.


fix: bug issue #69

Fixed the href to go to barplot.html before it was blank.
Edit: There are also other hrefs there that are just blank for some reason not sure where those should lead.

Thank you!


Use assertThatThrownBy in TestSetSessionTask

Fixes #6082
The old PR is https://github.com/prestosql/presto/pull/6128

@cla-bot check

@cla-bot check

Hi is this merged yet?

@cla-bot check

@somayaj thanks for contribution. DId you submit your CLA already?

yes I did
On Thu, Dec 10, 2020 at 3:29 PM Łukasz Osipiuk<EMAIL_ADDRESS>wrote:

@somayaj https://github.com/somayaj thanks for contribution. DId you
submit your CLA already?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prestosql/presto/pull/6130#issuecomment-742811626,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRAZGMF5HS7YMEJOV4IYMTSUE4UTANCNFSM4UFRMOEQ
.

@somayaj thanks for contribution. DId you submit your CLA already?

yes I did

@martint can you take a look? The CLA bot seems to have other opinion on that  :)

@cla-bot check

Merged, thanks!


New feature: import oligos from spreadsheet or database

The basic idea:
I think it might be useful to allow users to upload a spreadsheet with oligos they have already designed. Cloning strategies can have multiple steps, with many oligos being used, and entering by hand can be cumbersome and lead to mistakes.
The crazy idea:
Labs that have large collections of oligos may find it useful to import all of them and design their strategies within ShareYourCloning. This is a bigger change that may not align with your idea of use of SYC, or that should be implemented later within Genestorian. I imagine importing all oligos directly to the "Primers" page is not ideal, as they will be saved as items in the data model. The alternative I can think of would be to add a new tab section "lab collection" where users import their whole database which SYC saves in the users' browser. Then, in the "Primers" page, we could add a button like "Add from collection", which looks for an ID and imports it.
The even crazier idea:
Some repositories (e.g. AddGene) or companies (e.g. IDT, Eurofins) have lists of commonly used primers. We could save a copy of these and add them as a "Standard primers" collection (like explained above). Otherwise, we could parse them upon request (I haven't found an API, so we would have to scrape the HTML, which is not ideal).
What do you think @manulera ? If you think some of the above is useful and we come up with the best implementation, I can work on it!

Hi @dgruano I have been thinking about something like this for a while as well. I have considered adding a feature of "import from csv" or "import from spreadsheet". I thought within the primers tab you can have two sub-tabs "session primers" (what is there now) and "collection primers" (whatever you updated). For the collection, you would not want the full list displayed, so some pagination would be needed. I think it should not be too hard to do with MUI. I agree it's necessary to be able to access from a collection in one way or another.
It would be great to allow users to have a way to access a permanent collection as you propose. The only issue with the browser storage is that it will not be in-sync with the actual primer list, so they will have to update it every now and then (admittedly not too often, but probably you want to be cloning with the primers you just bought). But that's already much better than uploading the primer list every time you want to clone as a csv or if you refresh the page, so probably it would be a good first step.
Long term, we could also think of integrating with google spreadsheets / oneDrive excel sheet. A master student has developed an integration to read and write sequences to google drive, but it's trickier than I thought. Hopefully there will be a PR soon. The way we did it, you cannot just authenticate to google and read your files. Essentially, all the accounts that would use the website to access drive files need to be added to a list in a google APIs interface, so it's just not very practical.
In summary, I am happy if you want to give a go to the browser storage, but knowing that it's likely a temporary solution until we figure out something that can be in-sync with what they use as primer storage.
The commonly used primers however is a great idea, and probably would stay there long term (they could be on a separate sub-tab "Standard primers" with name , sequence and maybe a reference to where they come from (url or similar). For this, I would make a separate repository that does the scraping and saves primers to a tsv file. The scripts can be run weekly/daily with a cron github action directly from github, I don't know if you have done it before, but it's easy, I can share an example. For scraping with python if you need to click on things, you can use playwright. Here is an example that I am using to download a full list of plasmids from an addgene kit (you have to click on a select element to display the full list, so simply scraping the initial document is not enough)

Great to hear you have also thought about it! I guess we can wait for the PR with the Drive integration as it is much more useful to always have access to the last version of the collection. By the way, have you done a small survey to know what people use for strains, plasmids and oligo collections? Maybe some of these could be easily integrated.
I'll start with the standard primers then! One question though: do you think that primers used for sequencing, genotyping by PCR (and not for cloning) are useful within ShareYourCloning? I wonder if they can be added to the data model to not only share how you made a construct, but also how you check it! Happy to see what you think and try to integrate it in the way I implement the "Standard primers" feature (most primers I came across are used for sequencing and not cloning, hence the question).
Thanks for the resources on scraping, I've used html parsers and Selenium before. Once I have figured this out, it would be great to learn about the cron github action!

What do you use in your lab? If they use something else (Benchling, some other ELN), I am not sure it would be easy.

It makes sense to me that some labs use online spreadsheets as they are simple and easily shareable. Both labs I've worked with use FileMaker databases. These are easily exported as spreadsheets though. Regarding Benchling, I have used it for my own work but not as a database, so I agree it might not be easy!

Quick thought about a possible workaround to interact with Google Drive: maybe a Google Collab notebook can read the spreadsheet from the user's Drive and send a request to SYC ? Very vague idea...

Done with #302


New-DrsVMtoVMHostRule setting affinity correctly?

For New-DrsVMtoVMHostRule the -AffineHostGroupName switch seems to set a new rule to be anti-affinity and -AntiAffineHostGroupName is setting it to be affinity?
e.g.
New-DrsVMToVMHostRule -Name licencing_windows_vmhostrule -Cluster $cluster -VMGroupName licencing_windows_vmgroup -AntiAffineHostGroupName licencing_windows_hostgroup -whatif
What if: Performing the operation "Create AffineVMToVMHost DRS rule 'licencing_windows_vmhostrule'" on target "cluster1".
vs
New-DrsVMToVMHostRule -Name licencing_windows_vmhostrule -Cluster $cluster -VMGroupName licencing_windows_vmgroup -AffineHostGroupName licencing_windows_hostgroup -whatif
What if: Performing the operation "Create AntiAffineVMToVMHost DRS rule
licencing_windows_vmhostrule'" on target "cluster1".

Appears to only effect whatif results. In practice the command behaves as expected.

Thanks, @rcooper3, for reporting this issue in the WhatIf and Verbose output. I just made commit 8ace2dcea58272d3bc57e8ef11fd64ba70188c23 that addressed the issue. Next release will include this fix.
Cheers,
Matt


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 435

Questions ?
Please refer to the Backport tool documentation


[SPARK-17639][build] Add jce.jar to buildclasspath when building.

This was missing, preventing code that uses javax.crypto to properly
compile in Spark.

Test build #65794 has started for PR 15204 at commit d11ad14.

Test build #65794 has finished for PR 15204 at commit d11ad14.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65794/
Test FAILed.

Merged build finished. Test FAILed.

Test build #65802 has started for PR 15204 at commit d0136f5.

If tests pass I'll merge this to unblock #15172.

Test build #65808 has started for PR 15204 at commit 33fed28.

Test build #65802 has finished for PR 15204 at commit d0136f5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65802/
Test PASSed.

Test build #65808 has finished for PR 15204 at commit 33fed28.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65808/
Test PASSed.

Merging to master.


Empty blocks cache during synchronisation

This is related to parallel blocks processing. Before this feature SDK downloaded all the blocks and then processed them. When parallel processing is introduced then batch of blocks is downloaded and processed and this happens in loop until synching is done. In this case SDK can remove already processed blocks from cache and it won't need so much disk space for sync

This is part of https://github.com/zcash/ZcashLightClientKit/pull/583


feat: update to CRA 2 and Storybook 5

Updates to Create React App 2 and Storybook 5.
Closes https://github.com/ipfs-shipyard/ipfs-webui/issues/888 and https://github.com/ipfs-shipyard/ipfs-webui/issues/986.

We should probably still have a lint command, but that could run eslint as it's already available.

💯 agree.

We should document that this project uses prettier, and encourage people to use an editor plugin for it. Having it format on save is pretty helpful.

I'd prefer to unburden the developers and make prettier optional.

Should we run prettier before commit? I find any pre-commit hook quite annoying, so maybe not. But then we should double down on having folks run prettier in their editors. Same goes for eslint warning.

True, maybe we should remove prettier altogether and just use eslint.
Quick and easy, what do you think?

@fsdiogo can ya update from master pls

Synced with master @olizilla.

package-lock got funky.
I can't start the app in local dev mode from an npm ci. am investigate.
./node_modules/create-hmac/browser.js
Module not found: Can't resolve 'create-hash/md5' in '/Users/oli/Code/ipfs-shipyard/ipfs-webui/node_modules/create-hmac'

I used npm-merge-driver to automatically solve the package-lock.json conflicts.
You are right, doing npm ci is breaking the dev mode.

@fsdiogo you did the right thing, but it did not do the right thing! Is working now.

Nice! Want to shed some light of how you solved it please?

@fsdiogo The error showed that create-hmac depends on create-hash/md5 but looking at the files in my local node_modules/create-hash showed no md5.js which explained the error... looking at the other files in there it turned out that the entire dep was the wrong thing. create-hash was being resolved to a totally different dep:es-to-primitive... I did this:
$ cat node_modules/create-hash/package.json
{
    "name": "es-to-primitive",
    "version": "1.2.0",
    "author": "Jordan Harband",
    "description": "ECMAScript "ToPrimitive" algorithm. Provides ES5 and ES2015 versions.",

so then i was all like whuuuuuuut!? so i checked the package-lock.json and found this weird nugget
"create-hash": {
     "version": "1.2.0",
     "resolved": "https://registry.npmjs.org/es-to-primitive/-/es-to-primitive-1.2.0.tgz",

sooo, that's weird, but it at least explains why npm was dropping es-to-primitve in where create-hash should be.
the solution, well, no magic here...
$ rm -rf node_module package-lock.json
$ npm i

🎉
...previously we had to be careful to preserve our package-lock.json when we were depending on an older version of ipld and a specific arrangement of ipld deps, but since we upgraded that, we're safe to re-build the package-lock when things get weird.

Thanks @olizilla!


fix: reverse sort on HSP list

Codecov Report

Merging #25 into master will decrease coverage by 36.58%.
The diff coverage is 41.84%.

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
- Coverage   91.37%   54.79%   -36.59%
===========================================
  Files           6        9        +3
  Lines         116      219      +103
===========================================
+ Hits          106      120       +14
- Misses         10       99       +89

Impacted Files
Coverage Δ

historical_system_profiles/listener_logging.py
0.00% <0.00%> (ø)

historical_system_profiles/models.py
43.47% <25.00%> (-56.53%)
:arrow_down:

historical_system_profiles/db_interface.py
27.77% <27.77%> (ø)

historical_system_profiles/views/v0.py
35.29% <30.23%> (-32.45%)
:arrow_down:

historical_system_profiles/config.py
92.85% <92.85%> (ø)

historical_system_profiles/app.py
100.00% <100.00%> (ø)

historical_system_profiles/metrics.py
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cbb07...5f70791. Read the comment docs.


Should SkipExtension be named SkipExtension?

#9 got me thinking and it looks like "Skip" part in SkipExtension might be misleading, as defined features aren't skipped during testing, but excluded from the test suite.
I propose something like ExcludeExtension, although it is still not as specific as I would like it to be (what about ExcludeFeaturesExtension?).
Should we rename it?

ExcludeFeaturesExtension is not bad, but after adding support for Behat CLI syntax (already working on this) we will be able to skip also specific scenarios, rather than features 😄  So then this name will be misleading... hmm...

Some rabbis say yes, and some rabbis say no

Behat uses the "specification" term, so ExcludeSpecificationsExtension may be appropriate.


Idea: Add unit test for react prop types

While working on #319, I noticed that it would be useful to have a unit test that checks for correct prop types in order to find out if components are receiving the correct props. Otherwise, the developer needs to click through each component in the storybook.
What do you think?

See also https://daveceddia.com/testing-for-proptypes-errors/


2.1: Purpose

The wording of the first sentence is a bit ambiguous as to what you're 'specifying' (though, we obviously know). I think you're specifying the "requirements" of the software, not necessarily the software itself (which might allude to the design of the software).

Whoops! thanks, good catch.


Fixes #49 and #48

After changing the paths loading the two js modules, annotation works well.
Fix #48 #49

Hi, @Xinyi2016, thanks to your PR. The file source and the js version you changed are not different from the original one. Could you confirm whether these links works? If it works, could you update the js path to these links? We will merge your PR.


CON-2631 updated documentation

Coverage remained the same at 21.308% when pulling f6802110cf89690e8b048fc189f5bee9186dd7ee on CON-2631-update-documentation into 73cdae46ae6c05546f05e5a2b386cd036cfc066e on master.

Coverage remained the same at 21.308% when pulling 308af4c93f333bdc18ef798061a41054e33b31db on CON-2631-update-documentation into 73cdae46ae6c05546f05e5a2b386cd036cfc066e on master.

Coverage remained the same at 21.308% when pulling 058d50d9d29875b6a491ad3b3ebe9c98a196a504 on CON-2631-update-documentation into 73cdae46ae6c05546f05e5a2b386cd036cfc066e on master.


Add missing Readme markdown file to IotOnboarding sample.

@jslobodzian,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


limit in JPA subqueries

While searching for limiting JPA subqueries, I found issue #421.
However, I am currently using QueryDSL 4.1.0 and there is UnsupportedOperationException anymore.
Has it been removed by intention or due I observe a regression bug?

There is no distinction between query and subquery types anymore in Querydsl 4, that's why this has changed.

Ah ok. Thanks.

Just ran into this as well ... Way too much hours of debugging later (in my opinion) I finally discover that github issue. Any way to make the error easier to spot ?


Add support for dind - docker in docker - using priviliged mode

Currently, the simulated job has as it seems a hard-coded docker run statement.
For a "dind" (docker in docker) type of job where you build images and run containers, you need the --privileged flag. Would be great to have an option for that!

Can you provide an as small as possible .gitlab-ci.yml I can use as test case? @synergiator

And wouldn't it make sense, to let "privileged" be default, and have people opt out via an local only rc file and "--no-priviliged" option?

hi there - I'd say that leaving non-privileged as default is in terms of security a more careful choice, given that you have chances to pickup Docker images with evil code, they would be able to do anything with you environment in the scope of your user permissions.
Sample job (from here):
image: docker:git
services:
- docker:dind

build:
  script:
  - docker build -t my-image .
  - docker push my-image

Or, without services, just use the docker:dind image.

services ain't supported yet.
Lets make the the tool able to understand --priviligied and/or read option from a .gcl file

https://github.com/firecow/gitlab-ci-local/pull/82 Added privileged option.
Also GCL_* environment vars are now used if specified.

#82 is is master, closing

Wonderful tool :smile:
@firecow would you mind provide an example of a job that would work ? I did not find any way even with the dummiest job...

@bcouetil I'm not sure I know a use case, where you would only use privileged mode.
What we need is the services: field implemented, that way a docker build routine could be implemented purely in docker-executor mode.

Thanks. If and when my main blockers are resolved (I created some new feature requests), I'll replace Docker with Kaniko as a workaround :smile:

@firecow @synergiator I managed to build images using Img : https://github.com/genuinetools/img
Same commands as Docker, but no service required. It still needs --priviledged, don't know why, but it works :tada:


tcpdrop: use socket enricher WIP

Follow-up to #1469
Thanks to the socket enricher, we get the container and process enrichment from the process that created the initial socket instead of the process from the current context.
In the last two lines, the socket enricher didn't work because the socket was already released (see tcp state FIN_*). In that case, it falls back to the previous container and process enrichment, which might be wrong or empty.
In a future PR, we could update the socket enricher to release entries in the sockets map after a timeout in order to get the enrichment to work.
$ go run -exec sudo ./cmd/ig/... trace tcpdrop -o columns=container,pid,comm,saddr,daddr,sport,dport,state,tcpflags,reason,netns,mntns
CONTAINER      PID        COMM             SADDR       DADDR       SPORT DPORT STATE        TCPFLAGS REASON          NETNS          MNTNS
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     43952 80    ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   ESTABLISHED  ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>
netem          2468194    wget             <IP_ADDRESS>  <IP_ADDRESS>     54854 443   FIN_WAIT1    FIN|ACK  QDISC_DROP<PHONE_NUMBER>     0
netem          1007       irq/130-iwlwifi  <IP_ADDRESS>  <IP_ADDRESS>     54854 443   FIN_WAIT2    ACK      QDISC_DROP<PHONE_NUMBER><PHONE_NUMBER>

[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

I would like to get kubeipresolver to add more info about the IP addresses, in a similar way to what we do in the trace network gadget:
$ kubectl gadget trace tcpdrop
NODE            NAMESPACE POD   CONTAINER PID    COMM IP SADDR      DADDR     SENDPOINT         DENDPOINT               SPORT DPORT STATE    TCPFLAGS REASON
minikube-docker default   shell shell     509033 curl 4  <IP_ADDRESS> <IP_ADDRESS> pod default/shell svc kube-system/default 42520 443   SYN_SENT SYN      QDISC_DROP

For this, kubeipresolver needs to be refactored because the IP to resolve is no longer one IP for the remote endpoint (with GetRemoteIP()) but two IPs (saddr & daddr). I will give it a try.
cc @burak-ok

According to https://github.com/inspektor-gadget/inspektor-gadget/commit/ef661cf69c75267573283d6844b507df10c07773#commitcomment-108638739, the performances of tcpdrop dropped by x4.5. This seems logical because the socket enricher has several eBPF program to start...
We should make it optional.

Rebased and updated with virtual columns:
$ kubectl gadget trace tcpdrop
NODE             NAMESPACE  POD    CONTAINER  PID      COMM  IP SRC                    DST                        STATE        TCPFLAGS  REASON
minikube-docker  default    shell  shell      4131842  curl  4  p/default/shell:33168  o/<IP_ADDRESS>:80               ESTABLISHED  ACK       QDISC_DROP
minikube-docker  default    shell  shell      4132451  curl  4  p/default/shell:45722  s/default/nginx:80         ESTABLISHED  ACK       QDISC_DROP
minikube-docker  default    shell  shell      4132704  curl  4  p/default/shell:37418  p/default/nginx-8f458dc5b- ESTABLISHED  ACK       QDISC_DROP

Output in yaml:
$ kubectl gadget trace tcpdrop -o yaml
---
comm: curl
container: shell
daddr: <IP_ADDRESS>
dport: 80
dstKind: pod
dstName: nginx-8f458dc5b-vrfb4
dstNamespace: default
ipversion: 4
mountnsid:<PHONE_NUMBER>
namespace: default
netnsid:<PHONE_NUMBER>
node: minikube-docker
pid: 4136671
pod: shell
reason: QDISC_DROP
saddr: <IP_ADDRESS>
sport: 38232
srcKind: pod
srcName: shell
srcNamespace: default
state: ESTABLISHED
tcpflags: ACK
timestamp:<PHONE_NUMBER>758053896
type: normal


[Function Request] Table 37 - AutoReserve

Dear Microsoft Team,
please add a new boolean parameter to function AutoReserve, to manage the manual reservation, as you did before for the same function in table 5902.
I don't know exactly how it looks like, because it is only available in the SaaS version.

I am afraid we would need a few more details. Either acquire an insider build or retrieve the latest cumulative update for Business Central to get insights into our implementation and suggest which change you'd like us to make.

We don't know how Microsoft exactly does it in case of Service Line, because it is available in sandbox environment only. The on-prem CU3 cumulative update dose not contain it.
Our expectation is a new parameter (e.g SkipManualReservation) for function AutoReserve() to manage the manual reservations.
//  IF (NOT FullAutoReservation) AND (NOT SalesSetup."Skip Manual Reservation") THEN BEGIN // OLD CODE
IF (NOT FullAutoReservation) AND (NOT SalesSetup."Skip Manual Reservation") AND (NOT SkipManualReservation) THEN BEGIN // NEW CODE
COMMIT;
IF CONFIRM(ManualReserveQst,TRUE) THEN BEGIN
ShowReservation;
FIND;
END;
END;

I am afraid I cannot find what you are explaining. I just looked at table 5902 and found the following signature: [External] AutoReserve(). There is no parameter to be found. As a matter of fact, I cannot find a single AutoReserve function with that parameter! Are you using a local version?

I have attached a screenshot from our sandbox environment. As you can see, the standard AutoReserve function in table 5902, has a parameter with name ShowReservationForm. It is works as expected, and we would like to have the sames for AutoReserve function in table 37 (Sales Line)

Ah, got it! This is in the NA/US version only. I will look into it!

Could you please put in all NAV version (W1 and all localization) in case of sales and service as well?

Currently we cannot change parameters for external method [External] AutoReserve(). It may be possible later after conversion to AL.


Update to egui 0.16

Follow up to https://github.com/hasenbanck/egui_wgpu_backend/pull/52

LGTM

LGTM


Update packages doc

The rendered message looks like below

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.12


lein template compilation issue on Windows due to git symlinks

When I build and install lein-template on Windows and attempt to generate any project locally, version information for libraries is empty for any kit library in deps.edn file.
It appears that behaviour is broken due to introduction of symlinked versions.edn in 1bb1fbcebc8172831dbbd16e545288d4d9b7b4d9
Apparently git on Windows doesn't support symlinks, instead it generates a file which contains a path to the original file.
There are few possible solutions:

move versions.edn to lein-template project. Reference that file from the main build.clj script.
keep two duplicate versions of versions.edn in project root directory and in libs/lein-template
update build script for lein-template to include versions.edn from the root folder when building jar.

I would prefer solution 1. since 2. adds duplication and 3 is ugly.

The problem is that the file is used by all the libraries, so solution 3 would probably be the right way to go to make it build on windows.

I found the only reference in build.clj where it’s used during the build itself, no runtime reference.
After applying the referenced pull request I was able to build all libs and project got generated properly.

We might be ok then, if everything looks good to @nikolap I'm ok get the PR merged in.

Yeah this is okay if build somehow works on Windows with it


focus on click goes to body, but should remain on current tab element

When I click on a tab element in this component, the focus is always going to . I don't think this is what you intended.
It's my understanding that when a tab element is clicked, the focus should remain on that element. This is how Heydon's tabs work. According to MDN,

Tabs do not act as anchor links to individual panels — and upon activation, keyboard focus should remain on the current tab element and not automatically move to the newly displayed tabpanel.

To accomplish this, all you might have to do is add tabindex="-1" to each tab element. e.g.,

Projects

Profile

[another tab]

[another tab]

Hello,
thank you for the report, version 1.3.3 has been released which fixes this issue.


MAINT: Forward-fill fx rates past file end.

If an FX rate query requests a date that's greater than the last date in the fx
rate file, forward-fill from the last value in the file rather than raising an
error.
We do this for a few reasons:

We'd like to gracefully handle the possibility of an FX rates file that's
older than another input file.

Relative to other non-erroring behaviors, forward-filling is the simplest
thing to implement. Specifically, it's what the implementation prior to this
change would do naturally if there weren't an explicit check to prevent it.

For an FX rates file containing prices on a 24/5 calendar, some amount of
forward-filling is required to handle any market with a non-weekday date.

Coverage decreased (-0.07%) to 88.21% when pulling 2546708d0ea980271bc9b9304cf72a714ba74c82 on ffill-past-fx-end into 7c654eff7b634bbbe20fa88d93149c90b60f0ac4 on master.


conditional css reruns css for whole component tree in development mode.

I have a component where i am setting visibility and opacity conditionally in styled.ul, something like -
const DropDownList = styled.ul`
    list-style: none;
    position: absolute;
    right: 0;
    z-index: 5;
    transition-duration: 0.5s;
    border: 1px solid #e6e8eb;
    border-radius: 4px;
    box-shadow: 0 14px 20px rgba(0,0,0,0.1);
    padding: 14px 20px;
    background-color: white;
    &:hover {
        visibility: visible;
        opacity: 1;
    }

    ${Button}:hover ~ & {
        visibility: visible;
        opacity: 1;
    }

    visibility: ${props => props.visible ? 'visible' : 'hidden'};
    opacity: ${props => props.visible ? '1' : 0}
`

But when I'm changing visible prop, it is reloading an background image of one of parent component.
Is it a bug or intentional feature?  This issue do not appears in production build.
Thank you.

Same question, very interested in what for such behavior in development mode?

Faced the same issue. Are there any updates?

This is an issue in Chromium actually, and it's been filed, but until then we can't really do much about it. https://bugs.chromium.org/p/chromium/issues/detail?id=1216451
In general, although we're using the CSSOM API, Chromium will mostly reevaluate all rules of a given style element, if a new rule is inserted. This isn't the intended behaviour of the CSSOM API and inconsistent with other browsers. That said, in terms of images and fonts, this can be worked around by having a proper Cache-Control header present on them in production, which is how many sites actually don't experience this issue without realising.


Fix: Validate composer.json and composer.lock on Travis

This PR

[x] validates composer.json and composer.lock on Travis
[x] updates the lock file

Follows https://github.com/composer/composer/pull/4219.

:+1:

Thank you, @Ocramius!


Add assertion to refactor_factored_attn_matrices

Description
You can't refactor_factored_attn_matrices with rotary models so error here.
Type of change
Please delete options that are not relevant.

[ x ] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ x ] I have commented my code, particularly in hard-to-understand areas
[ x ] I have made corresponding changes to the documentation
[ x ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have not rewritten tests relating to key interfaces which would affect backward compatibility

I don't think we need a test for this because that would require loading in a pythia-70m which seems an annoying increase to test speed, so this is ready for review

Looks good, thanks!


How about targetting diagrams library too?

The diagrams library uses GraphViz and seems to support flowchart notion too, no need to mess with JavaScript

Thanks for sharing. It seems great. Maybe I can make some experiments to evaluate it later.


Druid 3.3.3 distribution with HDP 3.1.4 dependicies.

Is your feature request related to a problem? Please describe.
No way to use Hadoop ingestion with Druid build for Hadoop 2.7 dep.
Describe the solution you'd like
Last Druid release was builded with both dependicies.
i.e.
https://www.google.com/url?q=https%3A%2F%2Fsktmetatronkrsouthshared.blob.core.windows.net%2Fmetatron-public%2Fdiscovery-dist%2Flatest%2Fdruid-metatron-3.2.6-hadoop-3.1.1.tar.gz&sa=D&sntz=1&usg=AFQjCNEj_RbUeJ58LVj1LcxplFZjwSFf_Q
Describe alternatives you've considered
No alternatives.
Additional context

Anybody?
Please help with this question.
There is no customized druid sources, and Hadoop 3.1.1 build.
Without it, Hadoop ingestion no working, and it is a critical issue, because on really huge data load it is so slow... (in our case it take a days)

Anybody?
Please help...


Upgrade/python37

broken when tested until 2.7, will require more refactoring than I'm ready to implement, will submit a new issue


Updated jsf

Removed license from xhtml, xml pages as JSF app was not working with it and comments about method description.

LGTM


Correct Spelling of Tor

From the Tor FAQ:

Note: even though it originally came from an acronym, Tor is not spelled "TOR". Only the first letter is capitalized. In fact, we can usually spot people who haven't read any of our website (and have instead learned everything they know about Tor from news articles) by the fact that they spell it wrong.

That's not us, right? :wink:

This should be fine, I'm just not sure if this overlaps with Bitcoin code. @psolstice ? Non-cosmetic changes where bitcoin core code is affected are to be left as-is for now

@riordant I know as much about Bitcoin code as the next goat but didn't we put that there? Should be fine


Standalone CRL command

Since CRLs expire after (by default) 30 days, it is occasionally necessary to generate them without revoking any certificates. The new command performs this task.

Sorry, this PR accidentally included all of my previous, unrelated changes.


plugins use features of c++17

Portion of build log:
In file included from /usr/include/gazebo-11/gazebo/physics/physics.hh:9:
/usr/include/gazebo-11/gazebo/physics/Collision.hh:205:28: error: ‘optional’ in namespace ‘std’ does not name a template type
  205 |       public: virtual std::optional<sdf::SemanticPose> SDFSemanticPose()
      |                            ^~~~~~~~
/usr/include/gazebo-11/gazebo/physics/Collision.hh:205:23: note: ‘std::optional’ is only available from C++17 onwards
  205 |       public: virtual std::optional<sdf::SemanticPose> SDFSemanticPose()
      |                       ^~~
In file included from /usr/include/gazebo-11/gazebo/physics/physics.hh:26:
/usr/include/gazebo-11/gazebo/physics/Light.hh:78:20: error: ‘optional’ in namespace ‘std’ does not name a template type
   78 |       public: std::optional<sdf::SemanticPose> SDFSemanticPose() const override;
      |                    ^~~~~~~~
/usr/include/gazebo-11/gazebo/physics/Light.hh:78:15: note: ‘std::optional’ is only available from C++17 onwards
   78 |       public: std::optional<sdf::SemanticPose> SDFSemanticPose() const override;
      |               ^~~
In file included from /usr/include/gazebo-11/gazebo/physics/physics.hh:28:
/usr/include/gazebo-11/gazebo/physics/Link.hh:617:20: error: ‘optional’ in namespace ‘std’ does not name a template type
  617 |       public: std::optional<sdf::SemanticPose> SDFSemanticPose() const override;
      |                    ^~~~~~~~
/usr/include/gazebo-11/gazebo/physics/Link.hh:617:15: note: ‘std::optional’ is only available from C++17 onwards
  617 |       public: std::optional<sdf::SemanticPose> SDFSemanticPose() const override;
      |               ^~~
In file included from /usr/include/gazebo-11/gazebo/physics/physics.hh:36:
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh: In static member function ‘static T gazebo::physics::PhysicsEngine::any_cast(const boost::any&)’:
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:274:45: error: ‘any’ is not a member of ‘std’
  274 |           auto value = boost::any_cast<std::any>(_value);
      |                                             ^~~
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:274:45: note: ‘std::any’ is only available from C++17 onwards
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:274:45: error: ‘any’ is not a member of ‘std’
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:274:45: note: ‘std::any’ is only available from C++17 onwards
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:275:23: error: ‘any_cast’ is not a member of ‘std’
  275 |           return std::any_cast<T>(value);
      |                       ^~~~~~~~
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:275:23: note: ‘std::any_cast’ is only available from C++17 onwards
/usr/include/gazebo-11/gazebo/physics/PhysicsEngine.hh:275:33: error: expected primary-expression before ‘>’ token
  275 |           return std::any_cast<T>(value);
      |                                 ^
make[2]: *** [CMakeFiles/Hydrodynamics.dir/build.make:132: CMakeFiles/Hydrodynamics.dir/src/Utilities.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/Hydrodynamics.dir/build.make:146: CMakeFiles/Hydrodynamics.dir/src/Wavefield.cc.o] Error 1
make[2]: *** [CMakeFiles/Hydrodynamics.dir/build.make:160: CMakeFiles/Hydrodynamics.dir/src/WavefieldEntity.cc.o] Error 1
In file included from /usr/include/ignition/transport8/ignition/transport/Node.hh:42,
                 from /usr/include/gazebo-11/gazebo/rendering/Projector.hh:26,
                 from /usr/include/gazebo-11/gazebo/rendering/rendering.hh:34,
                 from /home/acxz/vcs/git/github/nswc-pcd-heron-stochastic-control/vrx_ws/src/vrx/wave_gazebo_plugins/src/Gazebo.cc:25:
/usr/include/ignition/transport8/ignition/transport/NodeShared.hh:298: error: ‘optional’ in namespace ‘std’ does not name a template type
  298 |       public: std::optional<TopicStatistics> TopicStats(
      |
/usr/include/ignition/transport8/ignition/transport/NodeShared.hh:298: note: ‘std::optional’ is only available from C++17 onwards
/usr/include/ignition/transport8/ignition/transport/Node.hh:740: error: ‘optional’ in namespace ‘std’ does not name a template type
  740 |       public: std::optional<TopicStatistics> TopicStats(
      |
/usr/include/ignition/transport8/ignition/transport/Node.hh:740: note: ‘std::optional’ is only available from C++17 onwards
make[2]: *** [CMakeFiles/Hydrodynamics.dir/build.make:76: CMakeFiles/Hydrodynamics.dir/src/Gazebo.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2103: CMakeFiles/Hydrodynamics.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
cd /home/acxz/vcs/git/github/nswc-pcd-heron-stochastic-control/vrx_ws/build/wave_gazebo_plugins; catkin build --get-env wave_gazebo_plugins | catkin env -si  /usr/bin/make --jobserver-auth=3,4; cd -

Hi, thanks for submitting an issue! In addition to the output you've posted, would you mind writing up a short narrative summary? It's helpful to include:

The behavior you expect to see.
The behavior you are getting.
Steps to reproduce.

Thank you!

Sure!

The behavior you expect to see.

Successful compilation

The behavior you are getting.

Unsuccessful compilation

Steps to reproduce.

catkin build vrx_gazebo
Let me know if you need more information. Compiler is gcc 12.1.0.

Thanks. In my opinion, the key to reproducing this issue is to update gcc to a version that will give an error instead of a warning. Running catkin build vrx_gazebo will not produce this output if you've followed our installation instructions and are using a fresh installation of Ubuntu 20.04.
Consequently, I would describe this issue as follows:

Currently, some plugins require features of C++17, but flags set in CMakeLists.txt for usv_gazebo_plugins and wave_gazebo_plugins indicate C++17 is not required.
This causes compilation to fail when using the latest version of gcc (e.g. 12.1.0).

Of course, it's totally reasonable to fix this, but slightly less urgent than it would be if compilation failed when following our installation instructions.
Are you using Ubuntu 22 or did you install gcc 12 from source?

My OS is Archlinux, where gcc 12 is available in the package repos.

OK, thanks. This is not supported, so in the future please be sure to note in any issues that you are using a non-standard set up that we may not be able to reproduce. If you'd like to use a supported setup, you can follow the installation instructions available on our Wiki: https://github.com/osrf/vrx/wiki/system_setup_tutorials
Of course, since you have already forked the repository, there's no problem with adding support for whatever configuration you want to your fork.
Again, this is not to say that we can't resolve this particular issue, which looks very reasonable. But since you have been relatively active lately it seems like a good idea to get on the same page.


Mac/Linux file separator

Describe the bug
A clear and concise description of what the bug is.
In mac and linux, this extension cannot find _config.yaml file.
As you know in checkConfigAndGetPort use \ as file separator.
But linux and mac use /. So you need to check double or check os.
To Reproduce
Steps to reproduce the behavior:

In the mac or linux, run extenstion

Thanks for finding out this issue. Working on a fix

:tada: This issue has been resolved in version 1.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] Unable to build dependencies because of type mismatch

Describe the bug
Hello!
The readme says to build the extension with npm run build. When I do that on the current main branch, I get a bunch of type errors. Some are missing from @types/nova-editor-node that I addressed in #44 but one ('LanguageClient' is not assignable to parameter of type 'Disposable') is not.
To Reproduce
Steps to reproduce the behavior:

Follow the readme and run npm build
See the following errors:

src/rust-lang-server.ts:66:33 - error TS2345: Argument of type 'LanguageClient' is not assignable to parameter of type 'Disposable'.
  Property 'dispose' is missing in type 'LanguageClient' but required in type 'Disposable'.

66       nova.subscriptions.remove(this.languageClient)
                                   ~~~~~~~~~~~~~~~~~~~

  node_modules/@types/nova-editor-node/index.d.ts:341:5
    341     dispose(): void;
            ~~~~~~~
    'dispose' is declared here.

src/rust-lang-server.ts:76:33 - error TS2345: Argument of type 'LanguageClient' is not assignable to parameter of type 'Disposable'.

76       nova.subscriptions.remove(this.languageClient)
                                   ~~~~~~~~~~~~~~~~~~~

src/rust-lang-server.ts:146:30 - error TS2345: Argument of type 'LanguageClient' is not assignable to parameter of type 'Disposable'.

146       nova.subscriptions.add(client)
                                 ~~~~~~

src/rust-lang-server.ts:164:33 - error TS2345: Argument of type 'LanguageClient' is not assignable to parameter of type 'Disposable'.

164       nova.subscriptions.remove(this.languageClient)
                                    ~~~~~~~~~~~~~~~~~~~

Found 4 errors in the same file, starting at: src/rust-lang-server.ts:66

Expected behavior
The app build successfully.
Versions (please complete the following information):

macOS: Ventura 13.4
Processor: Apple Silicon
Nova 11
Extension Version 2.3.2

Additional context
Looking through the Nova docs on subscriptions (which is a CompositeDisposable) the add method requires an object that has a dispose() method. The docs for LanguageClient don't specify that method.
So one question I'm asking myself is: should the extension be subscribing to the LanguageClient? Also, how did you compile this?

It's been a while, so I can't comment on why I believed the client was disposable 😅. Thanks for scouring the docs for this issue! I'll work on fixing this error.

Also, how did you compile this?

Are you asking how I was able to work around compiler errors, or are you asking for improvements to the documentation? If the former, I edited the type files locally and never got around to upstreaming the changes to Definitely Typed. If the latter, please let me know what's unclear or if I missed documenting something. Thanks!

If the former, I edited the type files locally and never got around to upstreaming the changes to Definitely Typed.

Ah ha, thanks. That's what I was after.
Thanks for looking at the bug. Let me know if I can help with the types or the extension. I've got bandwidth here and there.


[FEAT] Force fill column widths

The ability to determine if the total column widths are < than the width of the grid, it would be nice to fill the columns to equal the grid width.  http://www.screencast.com/t/DLuA5bQWzhO
Ember table supports this:
http://addepar.github.io/ember-table/#/ember-table/documentation
So does my grid:
https://github.com/Swimlane/angular-table/blob/master/src/table.js#L96
The tricky part is dealing with when a user resizes a column after a force fill but then resizes the table to be greater than the widths again ;)

Agreed a feature to put in. Btw - check out the 'no scrolls' option. This
achieves something similar.
On 8 March 2015 at 02:28, Austin<EMAIL_ADDRESS>wrote:

The ability to determine if the total column widths are < than the width
of the grid, it would be nice to fill the columns to equal the grid width.
http://www.screencast.com/t/DLuA5bQWzhO
Ember table supports this:
http://addepar.github.io/ember-table/#/ember-table/documentation
So does my grid:
https://github.com/Swimlane/angular-table/blob/master/src/table.js#L96
The tricky part is dealing with when a user resizes a column after a force
fill but then resizes the table to be greater than the widths again ;)
—
Reply to this email directly or view it on GitHub
https://github.com/ceolter/angular-grid/issues/7.

--
The information transmitted is intended only for the person or entity to
which it is addressed and may contain confidential and/or privileged
material. Statements and opinions expressed in this e-mail may not
represent those of the sender. Any review, retransmission, dissemination or
other use of, or taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is prohibited. If you
received this in error, please contact the sender immediately and delete
the material from any computer.

Just checked your screencast now - coincidentally I updated the sample table earlier with my 'no scrolls' feature - take a look at my updated website! - if only a few rows, the 'no scrolls' works very well.

I implemted this last week :)

Where  is the "No Scroll" option.

@dvrakas, I think its was called dontUseScrolls and after 2.0 it is called forPrint

@dvrakas, may be its was called dontUseScrolls and after 2.0 it is called forPrint
http://rawgit.com/S-YOU/ag-docs/master/1.10.0/angular-grid-no-scrolls/index.php.html


RTCPeerConnection::close no longer returns a Send future

I am not sure if this change was on purpose, but in the latest release, the RTCPeerConnection::close function returns a future that is no longer Send which effectively makes this unusable with most executors that send tasks between worker threads.
See https://github.com/libp2p/rust-libp2p/actions/runs/4280630599/jobs/7453106193 for an example compile output.
The underlying issue seems to be that RTCRtpTransceiver::stop holds a mutex lock across an await point. Is that Mutex even necessary? None of the functions within RTCRtpTransceiver take &mut self so you should be fine without the Mutex?

Maybe this is related to this issue https://github.com/webrtc-rs/webrtc/issues/422

Maybe this is related to this issue #422

It seems related yes. #422 was closed though. Did a fix land in master for this?

Maybe this is related to this issue #422

It seems related yes. #422 was closed though. Did a fix land in master for this?

No, it's still in progress, now I've reopened it.

To avoid this in the future, it might be worth looking at activating the following clippy lint: https://rust-lang.github.io/rust-clippy/master/#future_not_send

Fixed by https://github.com/webrtc-rs/webrtc/pull/429.


Generate email from table

Generate Email html and plan/text format with attachments (.xlsx, .csv)

Summary

How did you test this change?

[ ] Test(s) added
[ ] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

/easycla


release 2.1.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: regex<2022.0.0,>=2021.7.6 must contain a space between the name and the pin, i.e. regex <2022.0.0,>=2021.7.6
requirements: run: atpublic<3,>=2.3 must contain a space between the name and the pin, i.e. atpublic <3,>=2.3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


RGB order of the pwc net!!!!!

wonderful job!!!!Here is my question:
https://github.com/NVlabs/PWC-Net/tree/master/PyTorch
the origin nvlab pwc-net reverse RGB channel  to BGR, while when I'm reading your code ,the img get from  imread by scipy.ndimage is RGB order , you use the RGB order img directly, so the pth from your project site is trained with RGB order ? or the RGB or BGR order doesn't have much effect on  flow estimation .
and the megadepth net is also the same?
Thank you

Yes, we have a mistake here, but according to our later test, the order sequence does not affect too much for optical flow accuracy, as well as interpolation accuracy.
Megadepth has no such problem.


Add new connection type: OpenShift

Description
Add a new connection type, named OpenShiftConnection that allows to connect to OpenShift (serverless) endpoints.
All Promptflow Contribution checklist:

[ ] The pull request does not introduce [breaking changes].
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.
[ ] I confirm that all new dependencies are compatible with the MIT license.
[ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

@microsoft-github-policy-service agree company="Red Hat, Inc"


Rake task to setup databases

Coverage remained the same at 100.0% when pulling e17d5bae3dde929fa8ac8faf72aa44626bc559bc on rake-task-to-setup-databases into 8f3d5f511405777f87d4dc065c3c41f3ec894e34 on master.


channel default volume is unusual

I was surprised that the channel default volume is 64.  In audio designs, usually channel volume is attenuation only.  So I'd expect the default to be the maximum (255).
Otherwise, the master volume doesn't really mean the "maximum volume", and some channels may have a volume equivalent to a master volume of 1024...
https://github.com/m5stack/M5Unified/blob/42717f09c24e5af3f8edeef097c2755fdc36b571/src/utility/Speaker_Class.hpp#L234

@belm0
Thank you for your important input.
I apologize for any inconvenience caused by my ignorance of standard audio designs thinking.
I will review the volume settings in the next version and set the default channel volume to 255.
By the way, the volume value is calculated internally as a square ( volume ^ 2 ) . In other words, the output varies quadratically.
Both master volume and channel volume.
Do you have any opinions or generalizations about this process?

By the way, the volume value is calculated internally as a square ( volume ^ 2 )

I was going to say something about this requiring a 64-bit intermediate value for each sample unless some optimizations are done, but then I realized that the code is using a float buffer.  I'm a little surprised because float is not very fast on ESP32, so I guess this is a luxury sound library 😉

@belm0
Oh.. yes, I was reluctant to use floats, but I couldn't think of a better way.
In fact, I've been racking my brains because I later realized that the float operation is even slower in ESP32C3…😨

I have no doubt that multi-channel, 16-bit sound can be handled well within fixed-point, 32-bit operations.  (The PlayStation or early consoles and computers had no floating point hardware, etc.)
To start, 32-bit dynamic range is really not needed for volume.


eufy security cam

I have set up stream assist. But no wakeword works for me on my eufy security camera.
could it be that the eufy cameras are not supported?
thank you

I don't have this cameras. Don't know how to helps you.


Service worker issue

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.29.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.4.4
Public or Confidential Client?
Public
Description
Hi,
Is it possible to bypass the service worker when calling login.microsoftonline* urls in a PWA context with this library? I have CORS issues when such queries are handled with service worker, whereas everything is fine without it. With Angular service worker implementation, there is a specific way of doing such bypass by passing  a "ngsw-bypass" parameter in query header or as get parameter, this is usually done with an interceptor. I tried this solution, but for some reason the interceptor gets ignored by this library client. Any help appreciated.
Thanks
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
No response
Source
External (Customer)

@hmsuchier Thank you for your patience.
When you say you have tried the solution of adding ngsw-bypass in the query header as get parameter, but the interceptor gets ignored, are you using an additional interceptor as well as the MsalInterceptor?
Have you tried adding ngsw-bypass as an extraQueryParameter or tokenQueryParameter? These fields can be added as part of the authRequest for MsalInterceptor configurations, see docs here.


Refactor accept and combine methods to better handle overflow.

Codecov Report

Merging #53 (8cfe719) into master (71f61ca) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     99.80%   99.80%
  Complexity     1603     1603
=========================================
  Files            64       64
  Lines          4039     4039
  Branches        727      727
=========================================
  Hits           4031     4031
  Misses            4        4
  Partials          4        4

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Upgrade/dependencies

"<Provider> does not support changing store on the fly. It is most likely that you see this error because you updated to Redux 2.x and React Redux 2.x which no longer hot reload reducers automatically. See https://github.com/rackt/react-redux/releases/tag/v2.0.0 for the migration instructions."

I got this error from the start, so probably source code for reducers also should be updated


Refactor: Close #21 - Modularized the code by creating a new component and breaking down the home component into two parts.

Proposed Changes
The first thing I thought when I looked at the code was that the Home component was too long and it is hard to read something of that size. So, in order to raise the maintainability and scalability of the code in the future, I have broken it down into smaller parts and more components which is easier for contributors to understand. Trust me, it doesn't break the code.

Checklist (Check all applicable boxes)

[x] My code adheres to the project's coding style.
[ ] My changes require updates to the project's documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests have passed successfully.
[x] This PR does not contain any plagiarized content.
[x] The title of my pull request provides a brief description of the requested changes.

[ ] I am contributing independently.
[x] I am contributing for Hacktoberfest 2023.

Potential Impact on Existing Code
This change has no impact on the application. It makes the code a lot easier to maintain and more organized by creating a new component and breaking down the Home component which was massive before.
Screenshots
As mentioned earlier, there are no changes in the app.
Reviewer Notes
N / A

@AryanK1511 do add video the changes you made(no audio req) just to check if the changes are working in browser or not after modification.

https://github.com/ManishaSwain8/ReactToWeather/assets/101019909/41aad5a9-052b-42f8-9572-5d3439a1ebd8

Cool ! looks good ...will review it soon

Thankyou for your contribution @AryanK1511  !
In open source it is good practice to add issue first then if assigned then work on it .Because already people are working on issues if PR is done directly there will be conflict and the PR will not be merged .
Looking forward to more issues and collaborations.
If you learnt something from this repo make sure to ⭐ this repo.
Thankyou ,Happy coding !🚀


firestore security rule don't apply when the document contains a '+' char

Hi,
I am trying to match request.auth.token.phone_number == phone.
/users/+33612345678 --> forbiden
/users/_33612345678 --> allowed
I have no issues creating documents with '+' char, but issue to have a matching rule on them.
Is this supposed to be the expected behaviour ?
thx !

wrong place sorry


Respond to isFirstResponder

This allows clients to determine if the inputTextField is the first responder without having to dive into the inner workings of the VENTokenField.
I wasn't 100% sure whether we should call [super isFirstResponder] before asking the inputTextField so I left that out, though for completeness (future proofing?) we may want to ask super first. Nevertheless, this diff allows VENTokenField clients to determine the most common case, whether the text field is currently the first responder.

Thanks for the PR!


[DO] Licensing API

Related to https://github.com/CartoDB/data-observatory/issues/144, https://github.com/CartoDB/data-observatory/issues/212, https://github.com/CartoDB/cartoframes/issues/1079

Renamed /do/datasets to /do/subscriptions
Added GET /do/subscription_info to get metadata from a dataset
Added POST /do/subscriptions to enable a subscription in case of delivery time = 0 (in another case we should send an email, but we do nothing for now)
Refactored licensing logic to a service (used now from the data_observatory.rake and the new POST endpoint)
The new endpoints require the feature flag do-licensing

GET /do/subscriptions
Params

type: 'dataset' / 'geography' (optional)
order: 'project' / 'dataset' / 'table' / 'id' / 'type' (optional)
order_direction: 'asc' / 'desc' (optional)

Response
{
 "subscriptions": [
   {
     "project": "carto",
     "dataset": "bbva",
     "table": "financial_spain_2019",
     "id": "carto.bbva.financial_spain_2019",
     "type": "dataset"
   },
   ...
 ]
}

GET /do/subscription_info
Params

id: string
type: 'dataset' / 'geography'

Response
   {
     "id": "",
     "estimated_delivery_days": 0,
     "subscription_list_price": 0,
     "tos": "",
     "tos_link": "",
     "licenses": "",
     "licenses_link": "",
     "rights": ""
   }

POST /do/subscriptions
Params

id: string
type: 'dataset' / 'geography'

Response
   {
     "id": "",
     "estimated_delivery_days": 0,
     "subscription_list_price": 0,
     "tos": "",
     "tos_link": "",
     "licenses": "",
     "licenses_link": "",
     "rights": ""
   }

retest this please

retest this please

Acceptance 🍏

It does not work without feature flag
It does not work without service account set up in central
Returns dataset and geography subscription info
It licenses a dataset if delivery time == 0 and creates the view
It "licenses" a dataset if delivery time > 0 and does not create the view
It lists the licensed datasets

We actually need to send the e-mail (we need it to gather metrics). I'm adding a separate issue for that.


RemoteApp gives me only a black screen (RemoteDesktop works fine)

Hey there, I am on Arch Linux running a Windows 7 Ultimate VM in QEMU/KVM.
FreeRDP version: https://www.archlinux.org/packages/community/x86_64/freerdp/
I can connect to it with the following command just fine:
sudo xfreerdp /u:Vbox /p:pw_here /admin /cert-ignore +clipboard /v:<IP_ADDRESS>
But this gives me only a big black screen:
sudo xfreerdp /u:Vbox /p:pw_here /admin /cert-ignore +clipboard /app:||calc /v:<IP_ADDRESS>
I also tried creating the registry "fAllowUnlistedRemotePrograms" but still no luck.
Any ideas? :/ Thanks

@Utini2000 may I ask why you are using sudo? I'd also suggest to use ' (single quotes) around the app like /app:'||calc'
Also could you add what version of xfreerdp you are using?

You are right, I shouldn't use sudo and don't even know why I used it. Thanks !
Version: freerdp 1:1.2.0_beta1+android9-1 ... from: https://www.archlinux.org/packages/community/x86_64/freerdp/
Running: xfreerdp /u:Vbox /p:lala /admin /cert-ignore +clipboard /app:'||calc' /v:<IP_ADDRESS>
Still gives me the same problem.
I made a video showing what is happening: http://files.bestmail.ws/simplescreenrecord1.mp4

@bmiklautz nothing? :(

Oh und liebe grüße aus wien 22 ;P

@Utini2000 I did a similar test against windows 7 with the latest nightly (the machine runs in Hyper-V but that shouldn't actually matter):
xfreerdp /u:user /p:password /admin /cert-ignore +clipboard /app:'calc.exe' /v:win7-test

Worked for me as expected.

@bmiklautz well I tried it again today:
xfreerdp /u:Vbox /p:lala /admin /cert-ignore +clipboard /app:'calc.exe' /v:<IP_ADDRESS>
gives me just a big black screen... did you set/change anything in windows 7 itself ?
Thanks !

@Utini2000 no stock windows 7. No change at all. But as said I've tested with the latest nightly build that  I guess is more recent than the 1.2.x in arch.

@bmiklautz  Hmm I asked the arch package maintainer to update the package.. maybe he will do it. Anything else I can try or help troubleshooting ? :/ Thanks again !

@Utini2000 unfortunately we don't have any nightly packages for Arch. But you could try to compile yourself and test if the latest master fixes the problem for you.

@Utini2000 What desktop environment are you using? I am using the same set up as you, and can repeat this issue if I use MATE - other desktop environments work for me. See: https://github.com/FreeRDP/FreeRDP/issues/3000

@admiralakber oh please let this be the key to this problem... I am on Arch + GNOME.. Is GNOME causing the troubles? :(

Today there was an update for freerdp on Archlinux... it fixed the problem ! :)

@Utini2000 would you add the version that fixes this problem for you on Archlinux (xfreerdp --version)?
This means the issue can be closed?

Version: freerdp 1:1.2.0_20160107-2
Link: https://www.archlinux.org/packages/community/x86_64/freerdp/
Yes this issue can be closed ! I am glad that it finally works ;)

I'm having a similar issue, it seems to be https://serverfault.com/questions/220437/remote-desktop-connection-screen-is-totally-black-but-server-is-working-perfectl, not unique to freerdp. -bitmap-cache fixes it for me

I had a similar issue (black screen) with KDE, freerdp 2.2.0.
My observation: Sometimes it takes a few minutes(!) until the black screen is replaced with the expected content and everything works fine after this delay.

I had a similar issue (black screen) with KDE, freerdp 2.2.0.
My observation: Sometimes it takes a few minutes(!) until the black screen is replaced with the expected content and everything works fine after this delay.


Introducing the transaction manager leads to conflict with the tcc-transaction framework

Which version of ShardingSphere did you use?
3.1.0
Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
Actual behavior
The introduction of the transaction manager leads to a conflict with the tcc-transaction framework, because after the exception occurs, the jdbc transaction of tcc-transaction is managed by the shardingsphere, and from a business perspective, the business transaction and the log transaction should be separated. This will cause my tcc transaction log to be lost during the try phase, because I have an abnormal behavior during the try phase. Since shardingsphere is a distributed component, I hope that shardingsphere can be compatible with more middleware.
Example codes for reproduce this issue (such as a github link).
java Code
@Transactional(value = "dataSourceTransactionManager", rollbackFor = Exception.class)
    @Compensable(confirmMethod = "confirmIssue", cancelMethod = "cancelIssue")
public void issue(@UniqueIdentity String transactionXid, String test){
/ / The following is pseudo code
//My business code
/ / Start throwing an exception
}
public void confirmIssue( String transactionXid, String test){
}
public void cancelIssue( String transactionXid, String test){
}

  <!--sharing-jdbc start-->
     <dependency>
         <groupId>io.shardingsphere</groupId>
         <artifactId>sharding-jdbc-spring-boot-starter</artifactId>
     </dependency>
     <dependency>
         <groupId>io.shardingsphere</groupId>
         <artifactId>sharding-jdbc-spring-namespace</artifactId>
     </dependency>
     <dependency>
         <groupId>io.shardingsphere</groupId>
         <artifactId>sharding-transaction-spring-boot-starter</artifactId>
     </dependency>
     <!--sharing-jdbc end-->

You do some customized development, so can you put all of your code to github and provide the link here?
We may do not have enough time to Integrate with all frameworks, so is anyone interested with this issue?

Closed without reason with issue owner, I just set it as invalid


-find returns unexpected results

Using -find with for example **\cl.exe returns in my case the expected multiple results, like Hostx64\x64\cl.exe and Hostx86\x64\cl.exe.
Additionally, it returns an unexpected result: Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\Git\usr\bin\getfacl.exe.
Based on the description (option: -h) I expect only cl.exe in any directory to be returned with **\cl.exe as the argument to -find. getfacl.exe does not fit this criterion.
**\*\cl.exe seems to be a workaround, but it quadruples the runtime of vswhere (from ~1 second to ~4 seconds).
Full Output on my specific setup:
> & $vswhere -find **\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\Git\usr\bin\getfacl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\arm\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\arm64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\x64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\x86\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\arm\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\arm64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\x64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\x86\cl.exe

> & $vswhere -find **\*\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\arm\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\arm64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\x64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx64\x86\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\arm\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\arm64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\x64\cl.exe
C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.36.32532\bin\Hostx86\x86\cl.exe

$vswhere holds the full path as string to vswhere.exe as part of the VS Installer.
I found this issue first with the vswhere.exe shipped with Visual Studio Installer (3.1.1) and tested again with the latest version available in this repository (3.1.4). Both are affected.

@matcav @tydunkel this may not be a straight-forward fix. The current glob implementation uses C++ regex and builds a pattern that has a trailing, optional backslash so that it can match files in the root (which globstars are supposed to). We can't make that backslash required without breaking existing, common patterns. Also, C++ 11 regex uses ECMA-262 grammar (though this implementation doesn't use the full ECMAScript version because it doesn't need it) so grammar is limited. For example, lookahead assertions are supported, but not lookbehind (which is what I think is needed here). A full glob implementation may actually be necessary.