MSD Liver

Can you share the code of MSD Liver
I want to reproduce the experimental results

Similar with BTCV dataset, you only need to modify some code.

I modify the BTCV dataset training code to train on MSD Liver.
But I just got 0.51 Best Dice Score.


Regression comments should be linked to the job_id and task_id where the regression is found

In the current NotifyAdo Logic.
when processing a regression, the job_id and task_id is set to the original report not the regression. This can lead to confusion when investigating new issues. on a bug.
the job_id and task_id should come from the regression report
AB#164707

Wrong reading of the code. The regression processing does the correct thing


OTG causes significant lag in forge server

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[x] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[x] 1.12.2_v8_r1
[ ] 1.12.2_v7_DEV_r26
[ ] 1.12.2-v6
[ ] 1.12.2-v5
[ ] 1.11.2-v8
[ ] 1.11.2-v9
[ ] 1.10.2-v21
[ ] Other - specify here

Forge or Spigot Versions
[The full Spigot Server or Forge versions that you are running]
forge<IP_ADDRESS>38
What other plugins are you running?
[List of your Mods or Plugins installed, ideally with versions]
spongeforge-1.12.2-7.1.10
Description
[What is happening? - Explain what happens and what steps should be done to reproduce the issue. Ideally with pictures;)]
Sadly I am not able to explain this issue clearly because English is not my native language. But I will try my best.
I installed newest OTG on my spongeforge server by follwing wiki, and everything seems to be right. But lags occur when '[OTG]: Compressing structure-cache and pre-generator data' appears in console. This only happens when the server is making backup after chunks are being loaded and unloaded, and causes lag continued for few seconds. And it seems that the larger the region folder, the longer the lag.
I noticed this issue because my server is VERY powerful and I optimized my server so there is no other things could cause such a significant lag. I wish I could know what happens then and how to fix this issue.
By the way, OTG is a excellent plugin and thank you for your work.
[What did you expect to happen? - Explain what you expected to happen after performing the previously described steps]
Stop the lag
[Can you provide a Minimal, Reproducible Example? See here for details: https://stackoverflow.com/help/minimal-reproducible-example]
[And Delete the lines in square brackets!]

[18:13:10] [Server thread/INFO] [OTG]: Compressing structure-cache and pre-generator data
[18:13:10] [Server thread/INFO] [OTG]: Removed 0 cached chunks
[18:13:10] [File IO Thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (FarFromHome): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (FarFromHome): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-31): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-30): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-29): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-28): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM-6): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM2): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (DIM7): All chunks are saved
[18:13:10] [File IO Thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (LOST): All chunks are saved
[18:13:10] [Server thread/INFO] [minecraft/AnvilChunkLoader]: ThreadedAnvilChunkStorage (LOST): All chunks are saved
[18:13:11] [Server thread/WARN] [minecraft/MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 6476ms behind, skipping 129 tick(s)
[18:13:11] [pool-3-thread-430/INFO] [CONSOLE]: [⚡] Tick #13446 lasted 6476.78 ms. (12855.56% increase from avg)

I've also performed some tests with OTG and Biome Bundle preset. It lags quite a bit when exploring the area. here is the .log file
2020-05-23-4.log.gz
And here is the debug profiler files(and clean forge installation one for comparison) 11 vs 20 tps
forge.txt
only_otg.txt

I've also performed some tests with OTG and Biome Bundle preset. It lags quite a bit when exploring the area. here is the .log file
2020-05-23-4.log.gz
And here is the debug profiler files(and clean forge installation one for comparison) 11 vs 20 tps
forge.txt
only_otg.txt

I believe that your situation was different from what I am taking about. Your log file appears to be generated by a client. No doubt that the lag in my server was generated by 'world saving' rather than 'world generating'. It happens intermittently at few minutes interval, yet the TPS is still 20. When it happens, a single tick lasts more than 5 seconds, as if time stopped. Besides there is no ticks last more than 500 milliseconds. Unfortunately I still don't know what happens then.
As for your trouble, I'd recommend using world pre-generation which was integrated in 'O' menu.

Hey @Dong-Tu , please try the latest v9 OTG dev builds from the OTG Discord at https://discord.gg/UXzdVTH, we've done a lot for performance improvements. For pregenerated areas, there is still a bug where lighting is not calculated during pregeneration but only when the player first explores the area, we're still looking at a solution for that.


Frame refresh

While fixing https://github.com/LycheeOrg/Lychee-Laravel/issues/390 I noticed that the refresh of the image would often flicker, with new image being rendered too late. I'm not sure if I fixed it 100% but I sure made it better...
I also cleaned up the code a bit in the process, including fixing the case when full-size images are disabled.

Tested.


Fix bridge-led support in limitlessled.py

Addressing #6382 . Feedback from github & forums is the bridge_led feature never worked and defining the bridge LED as another group+bulb type is the right way to do this in the limitlessled component.
Description:
Removes bridge_led configuration and adds bridge-led as a type parameter
Related issue (if applicable): fixes #6382
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @quadportnick,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Configuration not changing anything

Hi,
I've used the frontail log of openHAB on my Raspberry Pi 3B+ for a while, which always looked like this:

Now as I completely renewed the Raspberry software and reinstalled the frontail log, it looks like this...

and no matter what I change in the configuration file, nothing changes.
What's the reason for this?

Ok, it was not the issue of frontail, rather the OS did not configure frontail the right way.
For more information see here:
https://community.openhab.org/t/frontail-log-not-configurable-weird-looking-design/104904/4


Add storage stuff

All the basic stuff

All the tests fail, pls merge only when you gonna fix them asap

Fixed all failing tests so can be merged now.


Weblate alert of too many outgoing commits

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
Problem
Just recived an alert email saying

The VCS repository has many changes compared to the upstream. Please merge the changes manually or set up push to automate this.

Also ⚠ appears on the Component and on all the language in it, which is so annoying.
As I checked that there are no conflict, I did a manully push, and the alert disappered.
Reason
After searching weblate docs, I figured out that alert emails would be send when outgoing (or missing) commits is great than set value(REPOSITORY_ALERT_THRESHOLD, default to 25). Which make sence as #2713 has 29 commits.
Solutions
Following method may solve the problem.

merge language file changes frequently on github
improve the REPOSITORY_ALERT_THRESHOLD
change the Merge style of vcs to merge (I personally dislike that, as rebase give us a clean commit tree)
set smaller push interval, but Merge style required to be merge, as rebase will lead to force-push
other solutions? idk

🐻 Uptime-Kuma Version
latest
💻 Operating System and Arch
latest
🌐 Browser
latest
🐋 Docker Version
latest
🟩 NodeJS Version
latest

But as our previous experience, those env vars are not working for Docker?

I except REPOSITORY_ALERT_THRESHOLD to work with docker, as there is no related settings of it in docker setting code. Just search in that file for REPOSITORY_ALERT_THRESHOLD with no result.

But as our previous experience, those env vars are not working for Docker?

I except REPOSITORY_ALERT_THRESHOLD to work with docker, as there is no related settings of it in docker setting code. Just search in that file for REPOSITORY_ALERT_THRESHOLD with no result.

Have set a large number, hope this works.

Have set a large number, hope this works.

Oh no, it alert me again🤔

Not have so much free time recently to learn about weblate's code logic, so not sure the reason why it doesn't work.
To save our time, just change the Merge style to merge on weblate vcs setting would be an easy solution.
Though I have the permission on weblate, I expect your approval of doing such operation, or you can just do it yourself.

Have set a large number, hope this works.

Oh no, it alert me again🤔

Yes... those env vars are not usable in the docker container, just like the GITHUB_CREDENTIALS. Only env vars listed here could be used: https://docs.weblate.org/en/latest/admin/install/docker.html
Will try to use merge method

Yes... those env vars are not usable in the docker container, just like the GITHUB_CREDENTIALS. Only env vars listed here could be used: https://docs.weblate.org/en/latest/admin/install/docker.html

It's possible to edit configuration beyond environment variables by overriding settings from the data volume

It's possible to edit configuration beyond environment variables by overriding settings from the data volume

Have you tried this method to setup REPOSITORY_ALERT_THRESHOLD? I receive those alert email  basically everyday, which is so annoying.


Run trim on each comma separated included files in page object yaml

Something seems to be wrong with the build related to sonar analysis, so this can't be merged in yet. Not an issue with your code, to my eyes. I'll contact @dougnoel to get it fixed. Otherwise this looks great. Thanks for contributing!

@AMehtaSL Okay so the build is failing because you are trying to merge from your forked repo. That is unsupported. Please make the same changes in a branch in the original repo and we'll be able to merge your code then. Thanks!


Update/Add zsh shell

Tool name
zsh Shell Support in Ubuntu 20.04/latest
Tool license
GNU General Public Licence
Add or update?

[X] Add
[ ] Update

Desired version
Whatever the latest is.
Approximate size
878288 bytes
Brief description of tool
zsh is a now-common shell that is the default on many dev machines (Catalina or later MacOS). It has differences in implementation from bash, the default shell in the current Ubuntu runner. This situation adds a layer of complexity for writing scripts, since they need to know which shell they're writing against.
This issue arose with the MacOS environment as well.
URL for tool's homepage
https://zsh.sourceforge.io/
Provide a basic test case to validate the tool's functionality.
#!/usr/bin/env zsh

if [[ $(command -v zsh) ]]; then
  echo "ZSH exists."
else
  echo "ZSH isn't found."
  exit 1
fi

if [[ "$ZSH_NAME" == "zsh" ]]; then
  echo "ZSH seems to be being used as this shell."
  exit 0
else
  echo "ZSH is (probably) not the shell being used."
  exit 1
fi

Virtual environments affected

[X] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Can this tool be installed during the build?
Running a build with the following stanza should install and make zsh executable:

jobs:
  test-zsh-install:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Install zsh
        run: sudo apt-get update; sudo apt-get install zsh
      - name: Zsh-huh
        run: |
          which zsh || echo "No which zsh"
          command -v zsh || echo "No command zsh"
          ls -la /usr/bin/zsh || echo "No zsh at /usr/bin"
          ls -la /bin/zsh || echo "No zsh at /bin/zsh"
      - name: Run a zsh script as proof
        run: .github/bin/zsh_proof.sh
        shell: /usr/bin/zsh{0}

### Tool installation time in runtime

~15-20 seconds on every job.

### Are you willing to submit a PR?

Potentially, yes.

@Madhavan @.***>
We will take a look at this
On Mon, Jan 10, 2022 at 4:52 AM Nathaniel Ford @.***>
wrote:

Tool name
zsh Shell Support in Ubuntu 20.04/latest
Tool license
GNU General Public Licence
Add or update?

Add
Update

Desired version
Whatever the latest is.
Approximate size
878288 bytes
Brief description of tool
zsh https://zsh.sourceforge.io/ is a now-common shell that is the
default on many dev machines (Catalina or later MacOS). It has differences
in implementation from bash, the default shell in the current Ubuntu
runner. This situation adds a layer of complexity for writing scripts,
since they need to know which shell they're writing against.
This issue arose with the MacOS environment
https://github.com/actions/virtual-environments/issues/264 as well.
URL for tool's homepage
https://zsh.sourceforge.io/
Provide a basic test case to validate the tool's functionality.
#!/usr/bin/env zsh
if [[ $(command -v zsh) ]]; then
echo "ZSH exists."else
echo "ZSH isn't found."
exit 1fi
if [[ "$ZSH_NAME" == "zsh" ]]; then
echo "ZSH seems to be being used as this shell."
exit 0else
echo "ZSH is (probably) not the shell being used."
exit 1fi
Virtual environments affected

Ubuntu 18.04
Ubuntu 20.04
macOS 10.15
macOS 11
Windows Server 2016
Windows Server 2019
Windows Server 2022

Can this tool be installed during the build?
Running a build with the following stanza should install and make zsh executable:
jobs:
test-zsh-install:
runs-on: ubuntu-latest
steps:
- uses: @.***
- name: Install zsh
run: sudo apt-get update; sudo apt-get install zsh
- name: Zsh-huh
run: |
which zsh || echo "No which zsh"
command -v zsh || echo "No command zsh"
ls -la /usr/bin/zsh || echo "No zsh at /usr/bin"
ls -la /bin/zsh || echo "No zsh at /bin/zsh"
- name: Run a zsh script as proof
run: .github/bin/zsh_proof.sh
shell: /usr/bin/zsh{0}
Tool installation time in runtime
~15 seconds on every job.
Are you willing to submit a PR?
Potentially, yes.
—
Reply to this email directly, view it on GitHub
https://github.com/actions/virtual-environments/issues/4849, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AXFGVRAK7C2OGBWSW3F7V23UVIKEHANCNFSM5LSM6MKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@nathanielford Hi!
We wouldn't like to pre-install zsh to the image and keep only the default ubuntu shell (bash). There was an issue regarding this already https://github.com/actions/virtual-environments/issues/264
I'm going to close the issue. Please feel free to contact us if you have any concerns.
Thank you!

I got a error on this while i ran the code again
On Mon, Jan 10, 2022 at 7:30 PM Mikhail Timofeev @.***>
wrote:

Closed #4849 https://github.com/actions/virtual-environments/issues/4849
.
—
Reply to this email directly, view it on GitHub
https://github.com/actions/virtual-environments/issues/4849#event-5866198519,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXFGVRGPFR3FONHMDRLNZETUVLQ7RANCNFSM5LSM6MKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***
com>

nvm
On Thu, Jan 13, 2022 at 4:37 PM Freddy Fazbear @.***> wrote:

I got a error on this while i ran the code again
On Mon, Jan 10, 2022 at 7:30 PM Mikhail Timofeev @.***>
wrote:

Closed #4849
https://github.com/actions/virtual-environments/issues/4849.
—
Reply to this email directly, view it on GitHub
https://github.com/actions/virtual-environments/issues/4849#event-5866198519,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXFGVRGPFR3FONHMDRLNZETUVLQ7RANCNFSM5LSM6MKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***
com>

The issue you cite, #264 explicitly indicated we should open a separate ticket for Ubuntu support. I think because it deals only with the MacOS virtualenvironment support of zsh?
In any case, would it be possible for you to provide a reasoning for not including zsh as a shell option? Note that this request is simply to add the zsh shell, not to make it the default shell. You provide a perfectly reasonable method for changing the shell a script runs in, but having to re-install zsh on every job in order to use it is cumbersome for a <1MB binary, and you include a raft of other similar language-specific binaries. I ask this because, as a cicd dev, I get that there are a lot of concerns (additional upkeep on your end, an incompatibility somewhere in your build stack that would prevent you from delivering the same guarantees you do now, specific security issues) that might result in a 'no' answer - but should something change in the ecosystem that alleviated those concerns, I'd like to keep an eye on this so I could re-request it at an appropriate time.
Thank you for your attention to this request!

@nathanielford the main reason is maintenance concerns. We would like to support and install only those shells that are mentioned in the docs https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
If there is support for zsh in the actions workflows then we will definitely add it to the images.


feat(factories): add overrideProps

Refence: #1424

@levithomason I've added overrideProps to handle situations like with Menu. It would be great to receive your initial feedback there.

I'd like to think about this one a bit.

@levithomason It will be great receive some feedback from you. Of course, when you will have enough time

Whoops, forgot about this thanks!  I'm working on the Tabs ATM and also need this feature.  Looking now...

I'll rebase it, complete TODOs and update code with your suggestion tomorrow

I'd like to try and simplify the factories as we also add more features.  There is only one component that currently requires usages of defaultProps as a function (others use a function but do not need to):
Input.js
    const actionElement = Button.create(action, elProps => ({
      className: cx(
        // all action components should have the button className
        !_.includes(elProps.className, 'button') && 'button',
      ),
    }))

This is ensuring the button className is added, but not duplicated.  Currently, the factory merges className but does not check for duplicates, it could check first.  Then, we can reduce the defaultProps back to a simple object.  If we need a function, there is always overrideProps for all other use cases.
I think we should then also remove the option for defaultProps to be a function and instead use a simple object.  Then, we update the current merge className logic to only merge unique classNames.
Thoughts?

Codecov Report

Merging #1428 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%
==========================================
  Files         141      141
  Lines        2384     2353      -31
==========================================
- Hits         2378     2347      -31
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Modal/Modal.js
100% <ø> (ø)
:arrow_up:

src/addons/Confirm/Confirm.js
100% <ø> (ø)
:arrow_up:

src/collections/Menu/Menu.js
100% <ø> (ø)
:arrow_up:

src/elements/Label/Label.js
100% <100%> (ø)
:arrow_up:

src/collections/Breadcrumb/BreadcrumbDivider.js
100% <100%> (ø)
:arrow_up:

src/collections/Form/FormField.js
100% <0%> (ø)
:arrow_up:

src/elements/Button/ButtonOr.js
100% <0%> (ø)
:arrow_up:

src/elements/Button/Button.js
100% <0%> (ø)
:arrow_up:

src/modules/Search/SearchCategory.js
100% <0%> (ø)
:arrow_up:

src/modules/Accordion/Accordion.js
100% <0%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768eb0c...8e75259. Read the comment docs.

Just ran into an issue over at https://github.com/Semantic-Org/Semantic-UI-React/pull/1508/files#r108559120.  We currently only enable support for keys if a create method is instantiated with generateKey set to true.
Although we know which components we need keys for, consumers can also use create in their own code.  We should enable key support in all factories so that any user can map over any create method and have support for keys.  Otherwise, some factories will be impossible to use in a map.

Heads up, I'm gonna push a few changes here.

Heads up, I've got more pushing coming.

I've pushed some updates, so only 28 tests failed now :+1:

✔ 7118 tests completed
✖ 6 tests failed
Seems we may have an issue with the BreadcrumbDivider test.  The common test for a shorthand prop expects the rendered element to contain the shorthand element.  However, the breadcrumb divider uses it's icon props to return an icon with the divider class added.

I'll leave this PR alone for now and come back when I can.  I also think we'll need to still make overrideProps a function.  It would received the merged defaultProps and usersProps.  This way, we can wrap an event handler and also still call the user's original event handler.

✔ 7124 tests completed 👍
TODO

[ ] make overrideProps a function
[ ] update event handlers where we use overrideProps
[ ] update tests, add tests for overrideProps

this looks good, I'm just going to revert the removal of generated keys for BreadcrumbDividers to prevent a breaking change, see https://github.com/Semantic-Org/Semantic-UI-React/pull/1428/files#r109309892.
We've got #1533 to remove all manually generated keys.  This way we can consolidate our breaking changes for key into one release.

Rebased to master, fixed breadcrumb divider keys.  Also tossed in a fix the for "show HTML" button in examples.
Will merge on pass.


cmd/go: misleading error message with repeated folder name

What version of Go are you using (go version)?

$ go version
go version go1.17.1 linux/amd64

Does this issue reproduce with the latest release?
Yes with 1.17.6
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.6"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/server/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1185892953=/tmp/go-build -gno-record-gcc-switches"

What did you do?
We have

a private repo at github.com/MyAccount/my-repo

containing a file server/go.mod starting with the line module github.com/MyAccount/my-repo/server
having the semver git tag server/v0.0.2

a distinct "client" project, having its own go.mod containing the lines

require (
	github.com/MyAccount/my-repo/server v0.0.2
)

Inside the "client" project, we launched
go build

(Sorry, can't give the full reproducible details of our private repo!)
What did you expect to see?
...
go: downloading github.com/MyAccount/my-repo/server v0.0.2
cmd/client/main.go:4:2: reading github.com/MyAccount/my-repo/server/go.mod at revision server/v0.0.2: git ls-remote -q origin in /go/pkg/mod/cache/vcs/f685fe342419a0c5eddd96688c386faf8f7622fa76c707a9c1c7c68bc353b5fe: exit status 128:
      Host key verification failed.
      fatal: Could not read from remote repository.

What did you see instead?
...
go: downloading github.com/MyAccount/my-repo/server v0.0.2
cmd/client/main.go:4:2: reading github.com/MyAccount/my-repo/server/server/go.mod at revision server/v0.0.2: git ls-remote -q origin in /go/pkg/mod/cache/vcs/f685fe342419a0c5eddd96688c386faf8f7622fa76c707a9c1c7c68bc353b5fe: exit status 128:
      Host key verification failed.
      fatal: Could not read from remote repository.

Note that the only unexpected bit is the repeated word at server/server.
This seems misleading: when seeing this error message, we thought that the "wrong" path github.com/MyAccount/my-repo/server/server/go.mod was the cause of the build failure. Did we make a mistake somewhere in the repo name/module name/package name/folder name?
We then realized that the root cause was only due to authentication difficulties with the go command using HTTPS or SSH to download the private repo.
After discussing this surprising error message with some Gophers, we now think the error message should not repeat the word "server" in the printed path.

@rsc I'll see if I can pinpoint a relevant line in the code source.
If it helps, I may create sample repos to reproduce the error message (probably in a Docker container).

The relevant method in go internals is (*codeRepo).findDir .


Refactored the PipelineParser/PipelineConfiguration to use the PipelineDataFlowModel

Description
Prior to this PR, Data Prepper had split approaches for serializing configuration YAML from deserializing YAML. The PipelineDataFlowModel is currently being used for serialization. And deserialization is handled by the PipelineParser and PipelineConfiguration classes. This PR fixes this split-brain issue. Deserialization now uses PipelineDataFlowModel as well. This helps ensure that deserialization is consistent with serialization.
This change also starts to remove the legacy prepper: configuration in YAML. I wasn't intending to do this, but it would be harder to keep that behavior and we plan to remove it in #619.
This change is important for supporting conditional routing of sinks.
Issues Resolved
None, but contributes toward #619 and #1337
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1680 (879f4ef) into main (fabbb17) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1680      +/-   ##
============================================
+ Coverage     93.54%   93.58%   +0.04%
+ Complexity     1313     1307       -6
============================================
  Files           172      172
  Lines          3826     3820       -6
  Branches        303      301       -2
============================================
- Hits           3579     3575       -4
+ Misses          177      175       -2
  Partials         70       70

Impacted Files
Coverage Δ

.../opensearch/dataprepper/parser/PipelineParser.java
88.88% <100.00%> (+0.31%)
:arrow_up:

...ataprepper/parser/model/PipelineConfiguration.java
97.95% <100.00%> (-2.05%)
:arrow_down:

...prepper/parser/PipelineConfigurationValidator.java
71.18% <0.00%> (+1.69%)
:arrow_up:

...rwarder/discovery/AwsCloudMapPeerListProvider.java
95.12% <0.00%> (+2.43%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


CRC 1.33.1  Discussion on configuring

General information

OS: Linux / macOS / Windows
Hypervisor: KVM / Hyper-V / hyperkit
Did you run crc setup before starting it (Yes/No)?
Running CRC on: Laptop / Baremetal-Server / VM

CRC version
# Put `crc version` output here

CRC status
# Put `crc status --log-level debug` output here

CRC config
# Put `crc config view` output here

Host Operating System
# Put the output of `cat /etc/os-release` in case of Linux
# put the output of `sw_vers` in case of Mac
# Put the output of `systeminfo` in case of Windows

Steps to reproduce

Expected
Actual
Logs
Before gather the logs try following if that fix your issue
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

Please consider posting the output of crc start --log-level debug  on http://gist.github.com/ and post the link in the issue.

Hi,
Please can you suggest, how can we configure the /etc/resolv.conf
We need to have below setting in the file, which is not happening
ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) sudo sed -i '/search/s/$/" corp.amdocs.com"/' /etc/resolv.conf
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip)
Red Hat Enterprise Linux CoreOS 48.84.202109100857-0
Part of OpenShift 4.8, RHCOS is a Kubernetes native operating system
managed by the Machine Config Operator (clusteroperator/machine-config).
WARNING: Direct SSH access to machines is not recommended; instead,
make configuration changes via machineconfig objects:
https://docs.openshift.com/container-platform/4.8/architecture/architecture-rhcos.html

Last login: Mon Oct  4 11:37:04 2021 from <IP_ADDRESS>
[core@crc-scmfr-master-0 ~]$ ping ilvpbg1943
ping: ilvpbg1943: Name or service not known
Thanks

This is a generic OpenShift question, not something specific to crc, so this really is not a great place to discuss this. And it's also not clear why you need to do this, can't you use full hostnames, or deal with it differently?

Hi,
No we cannot use the full name.
In older version of CRC , we is to fix this and so we were able to ping the server.
So i was not able to configure this on the new crc 1.33.1
Can please suggest.

Agree this is not crc specific but around openshift side (check with docs ) or better to use full hostname like ilvpbg1943.corp.amdocs.com

In older version of CRC , we is to fix this and so we were able to ping the server.

For what it's worth, direct changes to the node configuration through ssh is unsupported both by us and by OpenShift.

Hi,
Again , do we have other different configuration for this CRC.
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) sudo sed -i '/search/s/$/" corp.amdocs.com"/' /etc/resolv.conf
[crc@eaas-crc ~]$
[crc@eaas-crc ~]$
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) sudo cat /etc/resolv.conf
Generated by NetworkManager
nameserver <IP_ADDRESS>
Please check older crc version, it was able to do modification.
[crc@eaas-crc ~]$ crc version
WARN A new version (1.33.1) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/1.33.1/crc-linux-amd64.tar.xz
CodeReady Containers version: 1.29.1+bc5f4409
OpenShift version: 4.7.18 (embedded in executable)
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) sudo cat /etc/resolv.conf
Generated by CRC
search crc.testing corp.amdocs.com
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

HI,
[crc@eaas-crc ~]$ crc version
WARN A new version (1.33.1) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/1.33.1/crc-linux-amd64.tar.xz
CodeReady Containers version: 1.29.1+bc5f4409
OpenShift version: 4.7.18 (embedded in executable)
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) sudo cat /etc/resolv.conf
Generated by CRC
search crc.testing corp.amdocs.com
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
[crc@eaas-crc ~]$
[crc@eaas-crc ~]$
[crc@eaas-crc ~]$ ssh -i ~/.crc/machines/crc/id_ecdsa -o StrictHostKeyChecking=no core@$(crc ip) ping ilvpbg1943
PING ilvpbg1943.corp.amdocs.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from ilvpbg1943.corp.amdocs.com (<IP_ADDRESS>): icmp_seq=1 ttl=61 time=1.10 ms
64 bytes from ilvpbg1943.corp.amdocs.com (<IP_ADDRESS>): icmp_seq=2 ttl=61 time=1.24 ms
64 bytes from ilvpbg1943.corp.amdocs.com (<IP_ADDRESS>): icmp_seq=3 ttl=61 time=1.37 ms
Killed by signal 2.

Hi,
How can we configure in this new CRC 1.33.1 , Do we have changes made in it ?
So please let us know, we will configure it.
Thanks

Once again, this was never a supported change to be done in the VM. Since it's unsupported, it could have broken at any time, which apparently finally happened with OpenShift 4.8. How to deal with this really is outside of crc's scope, especially if you don't give details regarding why you need to do this. Just one note, the resolv.conf content that you pasted has no search line, so I think it's expected your sed comment does not make any changes. And this is totally unrelated to crc/OpenShift/..., just basic shell usage.

Hi,
We do not have the server name will full name , it has been name like "ilvpbg1943"  with different name.
Also in pervious version the /etc/resolv.conf look like below :
cat /etc/resolv.conf
Generated by CRC
search crc.testing corp.amdocs.com
nameserver <IP_ADDRESS>
And now the new crc 1.33.1 looks to be different ?
[core@crc-scmfr-master-0 ~]$ sudo cat /etc/resolv.conf
Generated by NetworkManager
nameserver <IP_ADDRESS>

Once again, system files on the VM file system are a private implementation detail, they can change at any time. Any modifications you make to them is unsupported. It's normal you need to rework these modifications after a major OpenShift upgrade.

This is really an issue with openshift side https://bugzilla.redhat.com/show_bug.cgi?id=1944805 and not CRC specific. It worked before because we didn't enabled the MCO and with MCO enabled we are much more closer to real openshift cluster.

Unrelated to CRC. These are DNS and environment specific settings.
use FQDN instead of just the hostnames.


hotfix for isort/poetry incompatibility

precommit could fail because of isort bug:
https://levelup.gitconnected.com/fix-runtimeerror-poetry-isort-5db7c67b60ff

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/119


The React WalletProvider is now compatible with the Solana Mobile Stack Mobile Wallet Adapter by default

Preamble: How to review this PR
Click on the ‘commits’ tab and treat each commit as though it were its own PR. Every commit in this PR represents one feature/change, is tested when relevant, and can be landed independent of the ones that come after it.

Problem
The goal of this PR is to make a change to @solana/wallet-adapter-react such that we can make the following claim to existing Solana web application developers: “make no changes to your app, other than upgrading to vX.Y.Z, and your web app will be able to connect to any mobile wallet that supports the SMS mobile wallet adapter protocol.”
Proposed solution
Detect whether the app is running on a compatible mobile device. If it is, automatically construct and select a mobile wallet adapter, so that the users first interaction with the ‘connect’ button will trigger a mobile wallet adapter association request.

Implementation details
In this PR, you will encounter solutions that attempt to bridge the gap between how browser wallet extensions and mobile wallet apps work.

Browser wallet adapter plugins represent exactly one wallet brand. The mobile wallet adapter plugin represents the MWA protocol, which can connect to any wallet brand that supports it.
Browser wallets impose the concept of connecting/disconnecting – a step that is done on every load of the site. Mobile wallet adapter imposes the concept of authorize/deauthorize – steps that need only be taken once. ‘Disconnecting’ a mobile wallet in this PR has been implemented as ‘willfully forgetting a prior authorization.’
Autoconnect is not possible with mobile wallet adapter, because the OS enforces that an MWA association has to start with a user gesture (tap, swipe, etc). Autoconnect in this PR is implemented as ‘remembering and loading in your cached authorization, if you have one.’
MWA doesn't work at all in WebViews, because WebViews lack the privileges to open WebSocket connections on localhost. We disable MWA when running in a WebView, by user-agent detection.
We want to keep letting wallets control their own in-app browsers. There's no good way to detect whether we're running inside a browser's in-app browser, since most wallets haven't customized the user-agent of their webviews. Instead, what we've done is to disable the MWA injection whenever we detect that one of the configured wallet adapter plugins is in the Installed ready-state.
The ‘connect’ UI has always been unsafe for server-side rendering (SSR) since it's always been impossible for the server to know what wallets the client has, and how the button should render. This code – through its use of auto-selection of the mobile wallet adapter – makes SSR mismatches much more likely. People using SSR on their sites are going to need to mark their connect buttons as dynamic, at the very least.
The MWA plugin that we auto-instantiate infers the cluster from the RPC endpoint URL provided by the ConnectionProvider, and configures the AppIdentity using the hostname of the website alone. Folks who want or need to customize this further can supply their own instance of SolanaMobileWalletAdapter in the wallets array, and this code will choose theirs in lieu of creating a default one.

Test plan
Connecting and disconnecting a wallet on mobile web
The MWA gets selected automatically. Tapping connect starts an association with a mobile wallet. Tapping disconnect ‘forgets’ the cached authorization.
https://user-images.githubusercontent.com/13243/194161385-5f3b4288-a340-4cab-9f0f-95bc4167394d.mp4
Connecting and disconnecting a wallet inside a wallet's in-app browser
If we're in a wallet app's in-app browser and their wallet gets detected, we disable the MWA. Tapping connect starts an association with the host's adapter. Tapping disconnect disconnects the host adapter.
https://user-images.githubusercontent.com/13243/194161758-e612ab87-4405-4bf9-b5ba-c9c6c3da8133.mp4
Auto-connect enabled
Refreshing the page with autoConnect set to true results in the MWA ‘remembering’ the prior authorization and reloading that into state. At no point does it make contact with the mobile wallet.
https://user-images.githubusercontent.com/13243/194162400-e586cafe-afc5-4a27-ae61-1b9a040fc7a2.mp4
Auto-connect disabled
When auto-connect is not enabled, the wallet still loads by default but the user must initiate the connect feature to take the next step. The MWA simply ‘remembers’ the prior authorization and reloads that into state. At no point does it make contact with the mobile wallet.
https://user-images.githubusercontent.com/13243/194162823-dc698f34-3ead-4d56-846f-fc56008bf42d.mp4
Full test case
A mobile application using this new adapter code with no other changes.
https://user-images.githubusercontent.com/13243/194164711-b86103f3-5047-4998-914c-c40470cf04c4.mp4

Looks great! I reviewed each commit in order, I'll now review the whole change together.

Looks great. Mostly just have nonblocking clarifying questions/comments. This should definitely be merged without squashing to preserve the excellent commit history though!

@jordansexton: Changes since your review: https://github.com/solana-labs/wallet-adapter/compare/4f033c16ee2cbff207acd26faae40b769888419d..9cd5afe715d30461a06be4d07acfb52d5dc22b7b.


Remove redundant WaitForVBlank from d3d9 renderer

In D3D9 the wait for vertical sync is implicitly handled inside the device->Present and SwapChain->Present calls based on the value of PresentationInterval field of D3DPRESENT_PARAMTERS, so there is no need to explicitly call WaitForVBlank on flip.
P.S.: If the PresentationInterval field of D3DPRESENT_PARAMTERS is set correctly according to BGFX_RESET_VSYNC (i.e. to   D3DPRESENT_INTERVAL_ONE) which is already done in d3d9 renderer, then there is no need to call WaitForVBlank.
Test/Proof: If you set the reset flag to BGFX_RESET_NONE on bgfx::init, for the d3d9 backend it will still keep syncing with monitor vsync which is not expected behavior, it should be unlocked from vsync like other gfx backends, this patch will fix this issue for BGFX_RESET_NONE on d3d9.

Cleanup your branch first to not have merge commits. Just change you're making.


Any plan to update to version 4

As the Google API documentation says, the v3 version is deprecated.
Version v4 of the Google Sheets API is now available! This migration guide shows how to update applications to use v4.

Did you already plan to migrate to v4?

need to do it now. because it is not working for the lower versions now..

we need this v4 api now...

If I remember correctly, when I looked at the newer API, they did not support the same type of interface. Specifically the "row based" calls no longer exist - which is really a bummer and has held me back from wanting to update.
The v3 api is still functioning properly, no?

I just received an email from Google officially putting an end-of-life date on v3: "As part of the migration to the Sheets v4 API, we will shut down the Sheets v3 API on March 3, 2020." That will be here before you know it.

Just saw this as well :(
I’ll start working on it!
On Wed, Oct 2, 2019 at 7:43 PM Victor Aprea<EMAIL_ADDRESS>wrote:

I just received an email from Google officially putting an end-of-life
date on v3: "As part of the migration to the Sheets v4 API, we will shut
down the Sheets v3 API on March 3, 2020." That will be here before you know
it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theoephraim/node-google-spreadsheet/issues/193?email_source=notifications&email_token=AAI26LDWIEPUOFFZXXOIMD3QMUW2JA5CNFSM4ENIDBN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAGQYUY#issuecomment-537726035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI26LAG7TGBMWOFR6UQNRLQMUW2JANCNFSM4ENIDBNQ
.

--
Theo Ephraim
*514.998.8436 | *theoephraim.com

Any update on this?
I appreciate the work you do on this package :)

Has there been any progress on this?
March is quickly approaching! If the update doesn't seem possible, it would be nice to know sooner rather than later so I can find a new solution.

Just wanted to give a quick update - I'm working on it!
My schedule has also recently opened up so hopefully should have something done within the next couple weeks. Will keep you all posted here.

🚀 Ok folks - it's shipped!
There are unfortunately lots of breaking changes since google completely changed their api, but I promise the new interface is quite easy to use. It's definitely better than before.
Plus much better docs - https://theoephraim.github.io/node-google-spreadsheet/#/
Please let me know if anyone runs into any problems or you find the docs lacking.

Is there a migration guide to switch from v2 to v3?

I ended up writing a drop-in replacement for v2 that wraps v3 so old code doesn't need to be changed much.
Maybe it is useful for someone else as well. Comes with a few limitations though.
https://github.com/CherryDT/google-spreadsheet-v2v3-wrapper/


sanity.external_thorntail: Failed to resolve POM for io.thorntail:bom...

testcase gradle dependency error I think...
jdk8u232-b07_openj9-0.17.0-m2
https://ci.adoptopenjdk.net/job/Test_openjdk8_j9_sanity.external_thorntail-mp-tck_x86-64_linux/155/console
16:18:00  [ERROR] arquillianBeforeClass(org.eclipse.microprofile.health.tck.DelegateHealthSuccessfulTest)  Time elapsed: 7.731 s  <<< FAILURE!
16:18:00  org.jboss.arquillian.container.spi.client.container.DeploymentException:
16:18:00  Found 1 problems while building POM model from /thorntail/testsuite/microprofile-tcks/health/pom.xml
16:18:00  1/ [ERROR] Non-resolvable import POM: Failed to resolve POM for io.thorntail:bom:2.5.1.Final-SNAPSHOT due to Could not transfer artifact io.thorntail:bom:pom:2.5.1.Final-SNAPSHOT from/to gradle (https://repo.gradle.org/gradle/libs-releases-local): Error transferring file: Server returned HTTP response code: 409 for URL: https://repo.gradle.org/gradle/libs-releases-local/io/thorntail/bom/2.5.1.Final-SNAPSHOT/bom-2.5.1.Final-SNAPSHOT.pom from https://repo.gradle.org/gradle/libs-releases-local/io/thorntail/bom/2.5.1.Final-SNAPSHOT/bom-2.5.1.Final-SNAPSHOT.pom @ io.thorntail.testsuite:thorntail-microprofile-tck-health:2.5.1.Final-SNAPSHOT, /thorntail/testsuite/microprofile-tcks/health/pom.xml
16:18:00
16:18:00  	at org.wildfly.swarm.arquillian.adapter.WildFlySwarmContainer.deploy(WildFlySwarmContainer.java:95)

this is a dup of #1161
looks like an issue with thorntail pom (and subsequently missing artifacts at the repo it pulls from), will need to reach out to that community to fix or to get work around

Identified as a dup, but did not close for some reason, closing now.


[Bug]: Pub/Sub sources incompatible with Python MapToFields

What happened?
ReadFromPubSub is incompatible with Python MapToFields (or at least I cannot see how to resolve the type errors). A minimal example:
pipeline:
  transforms:
    - type: ReadFromPubSub
      name: Source
      config:
        topic: projects/${PROJECT}/topics/${TOPIC_NAME}
        format: json
        schema:
          type: object
          properties:
            foo: {type: string}
    - type: MapToFields
      name: Transform
      config:
        language: python
        append: true
        fields:
          bar:
            expression: "'baz'"
            output_type: string
      input: Source
    - type: WriteToBigQuery
      name: Sink
      config:
        table: ${PROJECT}:${DATASET}.${TABLE}
        numStreams: 1
      input: Transform

This fails with
Failed to decode Schema due to an error decoding Field proto:

name: "foo"
type {
  nullable: true
  logical_type {
    urn: "beam:logical:pythonsdk_any:v1"
  }
}

despite the fact that foo's type is provided in the Pub/Sub schema
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[X] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[X] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take-issue


Error: The directory name is invalid. (os error 267)

Been having an issue where everytime i boot the manager it displays this error. now other text. just informs me to press q to quit, then when i try to start it again it says the same error. Very confused as it was working perfectly on first use

Assuming you're on Windows, please follow this guide and add an environment variable called RUST_BACKTRACE and set it to 1. Then, please launch the mod manager again and send the result so I can examine it.

Thanks for the quick response! Yes I'm on Windows 11, sorry forgot to mention that. I've followed your steps and added an environment variable as a System Variable. After launching the mod manager, it gave me this information:
Failed: The directory name is invalid. (os error 267)
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13: BaseThreadInitThunk
14: RtlUserThreadStart

(I edited your comment to fix that <unknown> issue, on GitHub you can put three backticks at the beginning and end of text to create a code block ;) )

It's a bit strange how little information it actually has, I'll try and see if I can reproduce this when I get home.

Okay, I've made a debug build. This should hopefully give more information about the error, if it still happens on this build. Please download and run it, and let me know what happens. (You shouldn't have to re-login or anything, it uses the same app data.)
bonelab_mod_manager-Windows-debug.zip

<<<Okay, I ran the debug build, and it again gave me an error:
Error: The directory name is invalid. (os error 267)
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24: BaseThreadInitThunk
25: RtlUserThreadStart>>>

Also, I'm away for a couple of days so won't be able to respond till Sunday the 22nd

Okay, I'll probably send some questions here since the debug build still didn't give any useful info lol, but feel free to respond to them at your convenience :>

I have another debug build! I've added a bunch of logging, so I can get at least a general idea of where things are going wrong. Please try this when you have the time :>
bonelab_mod_manager-Windows-debug.zip

Hi there, ran the new debug build, this was the result:
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager] env_logger initialized
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager] entering try_main()
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::authentication] got password
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager] platform chosen
[2023-10-22T19:15:57Z DEBUG reqwest::connect] starting new connection: https://api.mod.io/
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager] got subscribed mods
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
Error: The directory name is invalid. (os error 267)
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24: BaseThreadInitThunk
25: RtlUserThreadStart
[2023-10-22T19:15:57Z DEBUG bonelab_mod_manager] waiting to quit
Press q to quit

It looks like it's failing while attempting to remove an unsubscribed mod. I've got another build that gives more specific debugging on each mod it attempts to remove. Sorry to make you keep redownloading builds- 😅 I'll be keeping all the debugging code I have, so if I need someone to send me debugging info in the future my hope is that I won't need to send people new versions. Per usual now, please run this and send the result: bonelab_mod_manager-Windows-debug.zip

No worries! I'm more than happpy to help from my end. I've run the new build, here's the result:
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager] env_logger initialized
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager] entering try_main()
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::authentication] got password
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-22T21:24:29Z DEBUG bonelab_mod_manager] platform chosen
[2023-10-22T21:24:29Z DEBUG reqwest::connect] starting new connection: https://api.mod.io/
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] got subscribed mods
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] removing installed mod with id 2407911 and folder "eemil.Lightsaber"
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] removing installed mod with id 2588556 and folder "ChuckSharts.RiflesoftheBear"
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] removing installed mod with id 2375550 and folder "Bezbro.IronGiant"
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] removing installed mod with id 2980064 and folder "FieldInjector.dll"
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
Error: The directory name is invalid. (os error 267)
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24: BaseThreadInitThunk
25: RtlUserThreadStart
[2023-10-22T21:24:30Z DEBUG bonelab_mod_manager] waiting to quit
Press q to quit

I now know exactly what the problem is: the mod manager installed a code mod you were subscribed to (apparently successfully, even though I never accounted for code mods lol) and then you unsubscribed from that mod so it attempted to remove it. However, the mod manager does this by attempting to remove the mod's directory, and code mods do not have their own directory, just a .dll file. I've made it so that it now detects if a mod is a code mod (by checking if it's a .dll file instead of a folder) and correctly removes it. I'm pleased to say that this should be the very last debug build for you to test!
bonelab_mod_manager-Windows-debug.zip

Ran the new debug. This is the result:
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager] env_logger initialized
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager] entering try_main()
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::authentication] got password
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] getting app data path
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] getting app data dir path
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] deserialized app data
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager::app_data] read app data
[2023-10-23T10:32:37Z DEBUG bonelab_mod_manager] platform chosen
[2023-10-23T10:32:37Z DEBUG reqwest::connect] starting new connection: https://api.mod.io/
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] got subscribed mods
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2943956 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\BaBaCorp.IronChub"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2375550 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Bezbro.IronGiant"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2415856 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\ChuckSharts.M1911A1"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2931615 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Q10isarobot.QualityOfLifeGadgets"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2401436 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Squash.42BoxesOfAmmo"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2590499 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Clabu.Karambit"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 3182926 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Draxolan.HomelanderPack"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 3282632 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\CarrionAndOn.TheInventions"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2588556 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\ChuckSharts.RiflesoftheBear"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2407911 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\eemil.Lightsaber"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2690252 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\Kepler.ColtPython"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2497890 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\cvrnage.Anzio20mm"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager::app_data] getting mods dir path
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] removing installed mod with id 2980064 and folder "C:\Users\joker\AppData\Locallow/Stress Level Zero/Bonelab/Mods\FieldInjector.dll"
[2023-10-23T10:32:38Z DEBUG bonelab_mod_manager] mod is probably not a code mod
Error: The directory name is invalid. (os error 267)
0:
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24: BaseThreadInitThunk
25: RtlUserThreadStart

Oh heck, spoke too soon- how about now?
bonelab_mod_manager-Windows-debug.zip

The mod manager worked! No errors

Fantastic! Next time I'm at my computer, I'll bump up the version number and make a full release (debug messages hidden by default) :)


“error while loading shared libraries: libnvinfer.so.7: cannot open shared object file: No such file or directory” when running sample

I'm trying to run the sample code. I've installed TRTorch according to the official TRTorch instruction.
When the sample code is run (with the below command from this link) the given error arise:

sudo bazel run //cpp/trtorchexec -- $(realpath /home/TRTorch/tests/modules/alexnet_scripted.jit.pt) "(1,3,228,228)"

error while loading shared libraries: libnvinfer.so.7: cannot open shared object file: No such file or directory

Also, the LD_LIBRARY_PATH is set correctly.

export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/TensorRT/TensorRT-<IP_ADDRESS>/lib

More info:

TRTorch: latest version (python package and binary)
TensorRT: <IP_ADDRESS>
Pytorch: 1.5.1
CUDA: 10.2
Python: 3.6

My guess is that when you run with sudo that you will no longer have the LD_LIBRARY_PATH variable set. I believe you can do sudo LD_LIBRARY_PATH=$LD_LIBRARY_PATH bazel ... to share this enviorment variable with the root user. We also are recommending people to use trtorchc which has a better more stable CLI interface btw.

@narendasan Thanks for your quick reply. That works for me but another error arises.

/home/.cache/bazel/_bazel_root/17c3b8408025104c1d1937cf0328cb01/execroot/TRTorch/bazel-out/k8-fastbuild/bin/cpp/trtorchc/trtorchc: error while loading shared libraries: libnvToolsExt-3965bdd0.so.1: cannot open shared object file: No such file or directory

Also, I set the CUDA and TensorRT path according to your instruction.

Do you have the libtorch libraries in your LD_LIBRARY_PATH?

Thank you for your answer. I added libtorch and It works. The samples are running correctly and the models are converted.
Now, I want to load the converted model in qt using:

module = torch::jit::load("Resnet50.jit.pt");
module.to(torch::kCUDA);
std::cout << "loading the model ok\n";
auto in = torch::randn({1,3, 224, 224}, {torch::kCUDA});
auto trt_mod = CompileGraph(module, std::vectorExtraInfo::InputRange{{in.sizes()}});
auto out = trt_mod.forward({in});

But the given error arise:

error: undefined reference to trtorch::ExtraInfo::InputRange::InputRange(c10::ArrayRef<long>)' <br/> error: undefined reference to trtorch::CompileGraph(torch::jit::Module const&, trtorch::ExtraInfo)'

The cmake file is:

set(Torch_DIR "../pytorch/torch/share/cmake/Torch")
set(TRTorch_DIR "../TRTorch")
include_directories("../TRTorch/cpp/api/include")
include_directories("../TRTorch/bazel-TRTorch")
include_directories("../TRTorch/bazel-TRTorch/core")
include_directories("../TRTorch/bazel-TRTorch/cpp")

Also, there is no folder named "lib" and "include" in root dir (TRTorch folder).
Thanks!

Its better when building with libtrtorch to build the tarball and move outside the bazel workspace. Bazel-bin targets may not always be there based on the last command run.

Thank you. I add the "libtrtorch.so" in my Cmakelist.txt but I got this errors:
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `caffe2::detail::TypeMetaData const* caffe2::TypeMeta::_typeMetaDataInstance<std::complex<float> >()'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `getPluginRegistry'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `torch::registerCustomClassMethod(std::shared_ptr<torch::jit::Function>)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `at::getLegacyDeviceTypeInit()'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::getCustomClassTypeMap[abi:cxx11]()'
TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::Dispatcher::reportError(c10::DispatchTable const&, c10::DispatchKey)'
TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `createInferBuilder_INTERNAL'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::Error::Error(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, void const*)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `createInferRuntime_INTERNAL'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `torch::jit::freeze_module(torch::jit::Module const&)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `caffe2::detail::TypeMetaData const* caffe2::TypeMeta::_typeMetaDataInstance<c10::ComplexHalf>()'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::Warning::warn(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `c10::ClassType::addAttribute(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<c10::Type> const&, bool)'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `at::detail::computeStorageSize(c10::ArrayRef<long>, c10::ArrayRef<long>)'
TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `at::globalLegacyTypeDispatch()'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `caffe2::detail::TypeMetaData const* caffe2::TypeMeta::_typeMetaDataInstance<std::complex<double> >()'
/TRTorch/bazel_cpp/libtrtorch/trtorch/lib/libtrtorch.so: undefined reference to `torch::jit::SubgraphRewriter::runOnGraph(std::shared_ptr<torch::jit::Graph>&, std::function<bool (torch::jit::Match const&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, torch::jit::Value*, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, torch::jit::Value*> > > const&)> const&)'
collect2: error: ld returned 1 exit status

did you also add the libtorch libraries to you CMakefile.txt as well?

yep, I've set the libtorch path as the set(Libtorch_DIR "TRTorch/bazel-TRTorch/external/libtorch") in CMakefile.txt , but CMake  can not find it.  :(

sudo sudo运行 LD_LIBRARY_PATH运行_ _sudo LD_LIBRARY_PATH=$LD_LIBRARY_PATH bazel ...``trtorchc

Thanks for your reply. I make the tensorRT in myself environment , so, it can't work in sudo!!
Thank you


Dial socket paths (for sandbox support)

Supports dialing multiple paths.
On go side, separates GetSocketFile into GetSocketBindFile (where service binds to) and GetSocketDialFiles (list of files to try to connect to).
I guess we need to change https://github.com/keybase/node-framed-msgpack-rpc/ to support multiple paths before I can turn it on for Electron client (@maxtaco).

@keybase/react-hackers

Is possible to stat both files out of the library and then just dial the file that's there in the library?

Sure

So there is a possible race where the file may not exist but it will exist, e.g. the UI may try to connect before service is up (socket file exists).
We don't really need to dial multiple socket paths for the UI since it exists in the mono-repo we can flip to container/sandboxed path in a single commit.
The dialing multiple paths on go side I think still makes sense though.

This is ready for review.

In order to fix tests that use a long tmp dir path on macOS, and handle the case where the unix socket file is >= 108 chars, I use Chdir to change directory and then use the file path when binding or dialing (as suggested by @maxtaco). I put a comment block there and link to github issue.
The socket path is a little bit longer but still if using a standard user path we are ok...
/Users//Library/Group Containers/keybase/Library/Caches/Keybase/keybased.sock is 81 chars.
On macOS, username max is 20 chars, so 81 + 1 + 20 = 102, and we're still below limit.
The Chdir workaround will kick in if this is not the case (as it does with test env).

Made some cmoments....

I was thinking, instead of this Chdir workaround, maybe we should throw an error if bind/dial path is >= 108 chars and then change the test code to use a shorter path. Seems maybe not ideal to use a Chdir workaround only for the tests?

I guess changing the socket dir just for test env would be equally uncomfortable too, so maybe this is ok.

@maxtaco I think this is ready again for review


Roles 0.1.0 add generated proposal title

@mudrila  / @Da-Colon  - ran through some of the tests listed above
Multisig batch new roels
Azorious batch 1 new roles and two edit roles
Re; 1 - the proposal passed ... but the roles page got stuck on loading. See in thread for video (toaster says - 'hats tree ID is not valid'. Also I can't add any roles nor can the children safes (proposal won't submit for the vote).
Re;3 - the proposal passed  .. the roles page still loads ... but the changes aren't registered here. The two roles unedited are there only. Also if I now try and add any roles it doesn't work as proposal won't execute
note - Part of it may have been my fault as I had to move to desktop for parts where the lack of scroll blocked me.
Let me know once scroll is fixed @mudrila and I'll tackle this all again on new safes fully mobile


not able to login into account Auth token not generated by hotmail account

login screen is open but login is not successful error is "We're unable to complete your request"

I was getting the same.  I fixed it by updating the callback URI in my app registration to match the redirect_uri being sent to login.microsoftonline.com: https://localhost:3000/login.
After that I got an error about the token format, which I resolved by setting client_secret (yikes) in the config that's passed to the AzureInstance ctor.
There's a useful walkthrough here: https://medium.com/seed-digital/using-microsoft-azure-identity-with-firebase-in-a-react-native-app-c9eef0fd0af8


MGMT-10912 - Remove user_name from cluster object

Remove user_name from cluster object (elastic)
Set unique user_id using FNV-1a 128bit algorithm instead (not reversible)

/cc @rccrdpccl

/test ci/prow/integration-test

/test integration-test

/hold

Let's configure the schema in all environments before unholding

Integration and staging mapping have been set, we can unhold this PR whenever.

/unhold


Strange tx,ty,tw,th values?

In data_generators.py, the values for tx,ty,tw,th  which are passed to y_rpn_regr are negative for most of the cases.   Those are for the box dimensions scaled to feature map size so they should not be negative. Or am I missing something?

According to this example: https://www.analyticsvidhya.com/blog/2018/11/implementation-faster-r-cnn-python-object-detection/
The values do not contain width and hight. They do contain the minimal and maximum point of the rectangle instead.


Video Output Fails After Minimizing App in OpenGL ExoPlayer Demo

Version
Media3 main branch
More version details
I am encountering an issue with the OpenGL ExoPlayer demo that renders the player output into a GLSurfaceView. After minimizing the app and reopening it, the video stops displaying and only a black screen appears. The issue can sometimes be reproduced more easily by minimizing the app, starting a YouTube video, and then returning to the OpenGL demo app.
Steps to Reproduce:
Run the OpenGL ExoPlayer demo that renders into a GLSurfaceView.
Minimize the app.
Reopen the app – at this point, the video fails to display, showing only a black screen.
Additional Information:
The issue does not occur in the older ExoPlayer repository, so it might be a recent problem introduced in media3.
The bug is intermittent but seems to happen more frequently after switching between the demo app and another video-playing app like YouTube.
Could you please investigate this issue and provide any guidance on how to resolve or work around it?
Devices that reproduce the issue
Pixel 8 PRO
Samsung Fold 4
Pixel 7 PRO
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
Run the OpenGL ExoPlayer demo that renders into a GLSurfaceView.
Minimize the app.
Reopen the app – at this point, the video fails to display, showing only a black screen.
Additional Information:
Expected result
The media plays
Actual result
Black screen
Media

Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

any updates?

I was unable to reproduce this issue with demos/gl/src/main/java/androidx/media3/demo/gl/MainActivity.java
Can you please reproduce the issue again, record an adb bugreport zip and email it to<EMAIL_ADDRESS>?
See instructions in the github issue template


Intellij Idea freezes

When transferring XYZ ASA from Bob to Alice (near 45:07 in the getting started video), my Intellij freezes and I need to kill the Intellij process on my Mackbook.
Intellij version 2021.1.1
Using Sandbox private network (./sandbox up)

Are you able to reproduce this behavior always ? I have seen this in the Transfer screen few times but was not able to reproduce it.
If you are able to reproduce it consistently, can you please provide the exact step ? (Like after selecting account from account chooser button ..)
Are you trying it on MacBook Intel or M1 ? Also, are you using it in a dual-monitor setup ?
The actual reason is that there is an invisible modal dialog which prevents the IDE to close. Somehow this issue is getting triggered for the Transfer screen. The exact steps will help to debug the problem.

Strange, I tried after a day and it works as expected. The sandbox env was running from yesterday. I am not able to reproduce the error now. I will let you know if I can reproduce the error in the future.
My Macbook has the Intel chip and I use dual monitors.
Let me close this ticket for now. I will create a new one if necessary.


retry will cause unnecessary wait on the last times

      go func() {
		defer close(attemptCh)
		for i := 0; i < maxRetry; i++ {
			select {
			case attemptCh <- i + 1:
			case <-ctx.Done():
				return
			}
			select {
			case <-time.After(exponentialBackoffWait(i)):
			case <-ctx.Done():
				return
			}
		}
	}()

This code  in retry.go will wait until the time.After(exponentialBackoffWait(i)) timeout when outside context does not cancel at the last retry.
Maybe it should be waiting before the next retry, rather than waiting after the retry

@magictour not correct. Try the following code:
package main

import (
        "context"
        "fmt"
        "time"
)

func main() {
        ctx, cancel := context.WithCancel(context.Background())

        cancel()

        select {
        case <-time.After(100 * time.Hour):
        case <-ctx.Done():
        }

        select {
        case <-time.After(100 * time.Hour):
        case <-ctx.Done():
        }

        fmt.Println("Finished")

}

It will quit immediately after printing "Finished"

@magictour not correct. Try the following code:
package main

import (
        "context"
        "fmt"
        "time"
)

func main() {
        ctx, cancel := context.WithCancel(context.Background())

        cancel()

        select {
        case <-time.After(100 * time.Hour):
        case <-ctx.Done():
        }

        select {
        case <-time.After(100 * time.Hour):
        case <-ctx.Done():
        }

        fmt.Println("Finished")

}

It will quit immediately after printing "Finished"

I think @magictour your understanding is not correct, can you explain what issue you are talking about?

This happened when outside context does not call the cancel() function immediately.
The code can be found in the file api.go -> executeMethod

	// Create cancel context to control 'newRetryTimer' go routine.
	retryCtx, cancel := context.WithCancel(ctx)

	// Indicate to our routine to exit cleanly upon return.
	defer cancel()

	// Blank indentifier is kept here on purpose since 'range' without
	// blank identifiers is only supported since go1.4
	// https://golang.org/doc/go1.4#forrange.
	for range c.newRetryTimer(retryCtx, reqRetry, DefaultRetryUnit, DefaultRetryCap, MaxJitter) {
                // ignore some code

		// Verify if error response code is retryable.
		if isS3CodeRetryable(errResponse.Code) {
			continue // Retry.
		}

		// Verify if http status code is retryable.
		if isHTTPStatusRetryable(res.StatusCode) {
			continue // Retry.
		}

		// For all other cases break out of the retry loop.
		break
	}

when should be retry, the function cancel() can not be called, the for loop will block.
@vadmeste @harshavardhana

This happened when outside context does not call the cancel() function immediately.
The code can be found in the file api.go -> executeMethod

	// Create cancel context to control 'newRetryTimer' go routine.
	retryCtx, cancel := context.WithCancel(ctx)

	// Indicate to our routine to exit cleanly upon return.
	defer cancel()

	// Blank indentifier is kept here on purpose since 'range' without
	// blank identifiers is only supported since go1.4
	// https://golang.org/doc/go1.4#forrange.
	for range c.newRetryTimer(retryCtx, reqRetry, DefaultRetryUnit, DefaultRetryCap, MaxJitter) {
                // ignore some code

		// Verify if error response code is retryable.
		if isS3CodeRetryable(errResponse.Code) {
			continue // Retry.
		}

		// Verify if http status code is retryable.
		if isHTTPStatusRetryable(res.StatusCode) {
			continue // Retry.
		}

		// For all other cases break out of the retry loop.
		break
	}

when should be retry, the function cancel() can not be called, the for loop will block.
@vadmeste @harshavardhana

The context is passed by caller too, once that is canceled the request is canceled.
Let's avoid anecdotal observations use it in a code and show us a reproducer.

I just tested by printing and using with mc by making simple changes
mc mirror --json -a /usr/sbin play/testbucket >/dev/null
minio-go: Context done: timer
minio-go: Context done: timer
^Cminio-go: Context done: first
minio-go: Context done: timer
minio-go: Context done: first
minio-go: Context done: first
minio-go: Context done: first
minio-go: Context done: first
minio-go: Context done: first
minio-go: Context done: timer

 git diff
diff --git a/retry.go b/retry.go
index 6e2826f..b7f7e2a 100644
--- a/retry.go
+++ b/retry.go
@@ -19,7 +19,9 @@ package minio

 import (
        "context"
+       "fmt"
        "net/http"
+       "os"
        "time"
 )

@@ -71,15 +73,17 @@ func (c Client) newRetryTimer(ctx context.Context, maxRetry int, unit time.Durat
                defer close(attemptCh)
                for i := 0; i < maxRetry; i++ {
                        select {
-                       case attemptCh <- i + 1:
                        case <-ctx.Done():
+                               fmt.Fprint(os.Stderr, "minio-go: Context done: first\n")
                                return
+                       case attemptCh <- i + 1:
                        }

                        select {
-                       case <-time.After(exponentialBackoffWait(i)):
                        case <-ctx.Done():
+                               fmt.Fprint(os.Stderr, "minio-go: Context done: timer\n")
                                return
+                       case <-time.After(exponentialBackoffWait(i)):
                        }
                }
        }()

package main

import (
        "context"
        "fmt"
        "time"
)

func main() {
        ctx, cancel := context.WithCancel(context.Background())

        defer cancel()

        attemptCh := make(chan int)
        go func() {
            defer close(attemptCh)
            select {
            case attemptCh <- 1:
            case <-ctx.Done():
            }

            select {
            case <-time.After(100 * time.Hour):
            case <-ctx.Done():
            }
        }()

        for range attemptCh {

        }

        fmt.Printf("Finished with err: %v\n", ctx.Err())
}

This happened when outside context does not call the cancel() function immediately.
The code can be found in the file api.go -> executeMethod

	// Create cancel context to control 'newRetryTimer' go routine.
	retryCtx, cancel := context.WithCancel(ctx)

	// Indicate to our routine to exit cleanly upon return.
	defer cancel()

	// Blank indentifier is kept here on purpose since 'range' without
	// blank identifiers is only supported since go1.4
	// https://golang.org/doc/go1.4#forrange.
	for range c.newRetryTimer(retryCtx, reqRetry, DefaultRetryUnit, DefaultRetryCap, MaxJitter) {
                // ignore some code

		// Verify if error response code is retryable.
		if isS3CodeRetryable(errResponse.Code) {
			continue // Retry.
		}

		// Verify if http status code is retryable.
		if isHTTPStatusRetryable(res.StatusCode) {
			continue // Retry.
		}

		// For all other cases break out of the retry loop.
		break
	}

when should be retry, the function cancel() can not be called, the for loop will block.
@vadmeste @harshavardhana

The context is passed by caller too, once that is canceled the request is canceled.
Let's avoid anecdotal observations use it in a code and show us a reproducer.

The function executeMethod work like this, it will be blocked until 100 hours:
package main

import (
        "context"
        "fmt"
        "time"
)

func main() {
        ctx, cancel := context.WithCancel(context.Background())

        defer cancel()

        attemptCh := make(chan int)
        go func() {
            defer close(attemptCh)
            select {
            case attemptCh <- 1:
            case <-ctx.Done():
            }

            select {
            case <-time.After(100 * time.Hour):
            case <-ctx.Done():
            }
        }()

        for range attemptCh {

        }

        fmt.Printf("Finished with err: %v\n", ctx.Err())
}

I already showed you it won't @magictour


Support getting function name & path params details from environment API

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #39783
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Lets write some tests with separate PR.

Tests are added with https://github.com/ballerina-platform/ballerina-lang/pull/39843.


Disable Dropdown menu search during keyboard navigation

fixes https://github.com/flutter/flutter/issues/152375
PR https://github.com/flutter/flutter/pull/147294 fix keyboard navigation issue https://github.com/flutter/flutter/issues/147253 by prioritising current selection in default search.
This revert PR https://github.com/flutter/flutter/pull/147294 and fix the issue by disabling DropdownMenu search during keyboard navigation instead.
also fixes https://github.com/flutter/flutter/issues/151878 as it is a regression caused by PR https://github.com/flutter/flutter/pull/147294.
Reason for reverting https://github.com/flutter/flutter/pull/147294 : it doesn't fix the keyboard navigation issue if a custom searchCallback(Issue https://github.com/flutter/flutter/issues/152375) is provided, and "prioritising current selection" is ambiguous for a custom searchCallback, so it would be tricky to have searchCallback behave the same way as the default search. Additionally the original search function was agnostic about the state of DropdownMenu other than the entry value type, might be good to keep it that way unless needed.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Solving merge conflict. I closed it by mistake.


Can we remove the framework of iAd and switch to AdService?

Can we remove the framework of iAd and switch to AdService? The method of iAd has been removed by Apple and there is a risk of being taken down

Version 1.0.0 has removed iAd. I apologize for the delayed response.


Fix v-model behaviour in Input and Select styled components

The current implementation shows a weird behaviour when one or more inputs are pointing to the same data attribute via v-model. A concrete example is when there's a native <input> and a styled Input pointing to the same data using v-model, the native input is always in sync with the expression inside v-model, but the StyledComponent loses track of it, meaning it gets out of sync. It also fixes the problem of a styled select not having an initial option selected.
Here is an example of said behaviour: https://codesandbox.io/s/wnj07wwvw5, by changing the select value, the 2nd input (native one) gets updated, while the 1st input (styled) gets out of sync. However, by editing the value of the 2nd input, they all get back in sync again.
Based on bootstrap-vue project, this commit implements a similar (but lighter) solution which maintains a localValue and emits events when the localValue changes (https://github.com/bootstrap-vue/bootstrap-vue/blob/dev/src/components/form-select/form-select.js). It also doesn't require implementing yet another event for change.
This is not a complete solution since checkboxes and radio buttons haven't been tested and they most likely don't work with v-model, it's also emitting as many events as components exist above the inputs, which makes it quite difficult to have any real usage in production.
Going forward, I suspect the best way to handle different styled elements is by creating different render functions for each, and deciding when to emit certain events depending on the component.
Fixes #53

I think we have to cover cleverly all the situation if we want to keep v-model working in this way...
Let me do a check for that. Sorry for late reply I was too busy.

Do we have any update on the same @liqueflies as I am also facing the same issue, and this commit would really fix this issue.
If you can prioritize this stuff, would be really helpful.

Would like to see this get merged soon as well.

Works like a charm, thanks @fsodano

Thanks for the PR,
I take you code and added into #88
Sorry but the branch was too much different.
THANK YOU SO MUCH ❤


Stop raising FormDataRoutingRedirect

https://github.com/pallets/werkzeug/pull/1342 sets the status code for RequestRedirect to 308, so the request body (form data) will be preserved. We no longer need to fail with FormDataRoutingRedirect. @pgjones

Hey can I work on this? As I can see here:
https://github.com/pallets/flask/blob/20f6040ed7680c86543f9cd4f01ca6dcc6eaf27e/flask/app.py#L1775-L1776
We only dispatch this on debug mode so we can safely remove. Is that OK?

Yeah, go for it! Can't completely remove it because we'd have to bump the minimum Werkzeug version to 0.15, which hasn't been released yet. For now it should check if the status code is 307 or 308 and not raise in that case.

I think in debug mode we should still fail. Triggering a slashes-related redirect on form submission likely indicates a bug or bad code (e.g. not using url_for)

Hmm, yeah. Probably best to leave it as people should really fix the URL. Although what about alias rules?


Addressing some stylelint complaints (#49)

Addressing some stylelint issues

Here's a link to the css-lint errors: https://travis-ci.org/tessa3/uxgraph/builds/171714887

👍

LGTM

LGTM


Poor network upload / download speeds after update

Please fill out the below information:

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [Version 10.0.19041.208]

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

Extremely slow network speed:
$>speedtest-cli Retrieving speedtest.net configuration... Testing from Three (<IP_ADDRESS>)... Retrieving speedtest.net server list... Selecting best server based on ping... Hosted by Structured Communications (London) [2.56 km]: 54.77 ms Testing download speed................................................................................ Download: 2.82 Mbit/s Testing upload speed...................................................................................................... Upload: 3.66 Mbit/s

What's wrong / what should be happening instead:

Should look more like:
$> speedtest-cli Retrieving speedtest.net configuration... Testing from Three (<IP_ADDRESS>)... Retrieving speedtest.net server list... Selecting best server based on ping... Hosted by Mauritius Telecom Ltd (London) [2.56 km]: 43.587 ms Testing download speed................................................................................ Download: 47.14 Mbit/s Testing upload speed...................................................................................................... Upload: 23.33 Mbit/s

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please collect detailed logs.

After rolling back to 10.0.19041.207, the problem for download is resolved but not upload in Ubuntu 18.04. Although, it might be the case that I have never noticed poor upload speeds (may not be a new issue). Interestingly, 20.04 performs as expected for both upload and download.

See if with the following command you get better results:
curl -s https://raw.githubusercontent.com/sivel/speedtest-cli/master/speedtest.py | python -
I think is an issue with speedtest

@therealninot I tried that first and went with speedtest-cli as a second opinion, both results were the same, unfortunately.


GPU does not run with Ollama

Hi everyone,
I am running a Windows 10 computer with GTX950 and Intel(R) Core(TM) i5-3475S, 32 GB RAM,
I downloaded the new Windows-version of Ollama and the llama2-uncensored and also the tinyllama LLM.
Good: Everything works.
Bad: Ollama only makes use of the CPU and ignores the GPU.
As far as I can tell, Ollama should support my graphics card and the CPU supports AVX.
From the server-log:
time=2024-03-18T23:06:15.263+01:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-18T23:06:15.263+01:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library nvml.dll"
time=2024-03-18T23:06:15.297+01:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: [c:\Windows\System32\nvml.dll C:\Windows\system32\nvml.dll]"
time=2024-03-18T23:06:15.377+01:00 level=INFO source=gpu.go:82 msg="Nvidia GPU detected"
time=2024-03-18T23:06:15.377+01:00 level=INFO source=cpu_common.go:15 msg="CPU has AVX"
time=2024-03-18T23:06:15.395+01:00 level=INFO source=gpu.go:119 msg="CUDA Compute Capability detected: 5.2"
time=2024-03-18T23:06:15.396+01:00 level=INFO source=cpu_common.go:15 msg="CPU has AVX"
time=2024-03-18T23:06:15.396+01:00 level=INFO source=gpu.go:119 msg="CUDA Compute Capability detected: 5.2"
time=2024-03-18T23:06:15.396+01:00 level=INFO source=cpu_common.go:15 msg="CPU has AVX"
time=2024-03-18T23:06:15.396+01:00 level=INFO source=assets.go:63 msg="Updating PATH to ...
time=2024-03-18T23:06:15.472+01:00 level=INFO source=dyn_ext_server.go:150 msg="Initializing llama server"
ggml_init_cublas: GGML_CUDA_FORCE_MMQ:   no
ggml_init_cublas: CUDA_USE_TENSOR_CORES: yes
ggml_init_cublas: found 1 CUDA devices:
Device 0: NVIDIA GeForce GTX 950, compute capability 5.2, VMM: yes
I would be glad if someone could tell me what to do to activate GPU-usage.
Thanks
Chris

Hi Chris,
Create a new environment variable OLLAMA_DEBUG with value 1 to get more information about what is going wrong.
Ensure that you are using minimum driver version 452.39
You might want to make sure you have CUDA installed too

I believe your GPU is a 2G card.  This means most models will not fit entirely into the VRAM of the GPU.  The layers of the model that wont fit are then processed by the CPU, and the GPU will have to wait for the CPU to keep up.
You mention you tried tinyllama which I would have expected to mostly fit into your VRAM and perform reasonably well.  On a GTX 750 2G card, I'm seeing ~15 tokens per second.  What sort of token rate are you seeing?  You can also try tinydolphin.
You can also check the server log for a line like this to see how many layers are actually loaded into VRAM.
llm_load_tensors: offloaded 19/23 layers to GPU

We're working on improvements to our memory prediction algorithm which will allow us to more fully utilize VRAM without hitting out-of-memory crashes in an upcoming release.

If you're seeing significantly slower behavior than what I described above, please let us know and share your server log so we can further investigate.


feat: support minimum height of month view

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description
If no css height of container element, the month view and week time grid have 0px height. I add minimum height in this case. The Calendar's default height is set to 600px.
And I add the related guide.
Fit the calendar size for parent element
TOAST UI Calendar's default height is 600px. If you want this calendar to fit to parent element, write container element's css like this.
#calendar {
    position: absolute;
    left: 0;
    right: 0;
    bottom: 5px;
    top: 64px;
}

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jungeun-cho Review this please.

[07/16] 리뷰완료합니다.