add commit on ContainsString

Ⅰ. Describe what this PR does
add commit on “ContainsString” function
Ⅱ. Does this pull request fix one issue?

Fix #460
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
add commit
Ⅴ. Special notes for reviews

Codecov Report

Merging #462 (7bd7157) into master (15e8c50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   19.92%   19.92%
=======================================
  Files          56       56
  Lines        2098     2098
=======================================
  Hits          418      418
  Misses       1635     1635
  Partials       45       45

Impacted Files
Coverage Δ

pkg/utils/crtl_utils.go
39.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15e8c50...7bd7157. Read the comment docs.


PowerToys Run plugin is set to disabled after every reboot

Microsoft PowerToys version
0.37.2
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

Enable PowerToys Run
Reboot computer

✔ Expected Behavior
PowerToys should still keep the same settings.
❌ Actual Behavior
Settings are updated and Run is disabled.
Other Software
No response

Adding some info, every other plugin keeps it's settings. Like explorer addon is still running when I boot up and color picker is disabled like I want it. It's just Run that will reset itself to off every time.

@omgmajk
Right-click on the PowerToys icon in the tray menu and select Report Bug

Drag and drop report into a GitHub comment.

Looks same as https://github.com/microsoft/PowerToys/issues/11159

PowerToysReport_2021-05-27-18-26-37.zip

@omgmajk
Thank you for following up. Try to run PowerToy not elevated.

And let us know if the issue still persists.

I need to run it as admin for it to work in certain apps that I need my keybindings from kb manager, but I can try it out for a few boots later.

same issue, every restart of the system powertoys run disables itself
PowerToysReport_2021-06-08-17-22-05.zip

[2021-06-08 09:49:52.125445] [p-7820] [t-7824] [trace] Starting PowerToys Run from elevated process
[2021-06-08 09:49:52.125487] [p-7820] [t-7824] [error] Failed to start PowerToys Run

From PowerToysReport_2021-06-08-17-22-05.zip

@casvanluijtelaar
Does this happens always? If yes, would you be able to install the private unsigned build to help us troubleshoot the issue?

Every time so far, and sure I'll help troubleshoot. Walk me through it!

@casvanluijtelaar

Uninstall PowerToys from the Control Panel
Download https://github.com/mykhailopylyp/PowerToys/blob/0.39-private-build/PowerToysSetup-0.0.1-x64.exe and install it
Reproduce the issue
Upload the bug report. Can be generated from the tray menu

to reproduce:

install powertoys
make sure powertoys run is enabled
restart computer
attempt to open powertoys run with shortcut (doesn't work)
open powertoys see that the run toggle is disabled

PowerToysReport_2021-06-08-19-02-40.zip

From PowerToysReport_2021-06-08-19-02-40.zip
[2021-06-08 19:01:08.090161] [p-7672] [t-7676] [error] GetShellWindow() failed. The operation completed successfully.
[2021-06-08 19:01:08.090163] [p-7672] [t-7676] [error] Failed to start PowerToys Run

GetShellWindow() fails on windows startup every time

Think https://github.com/microsoft/PowerToys/issues/10195 is same issue

Same here. Powertoys Run Plugin disables after hibernate. It is already set to run as Administrator.

Was fixed in 0.41

@omgmajk
Feel free to reopen it if it still happens

@omgmajk
Feel free to reopen it if it still happens

Seems to be fixed since update, thank you!

I've had the same issue for a few updates now. It still hasn't been fixed. I'm currently on V0.58.0

this issue is still not fixed.
I am using it in win11. the restart on startup toggle works fine in when logged in to user with administrator type account, but resets on othet standard user accounts. not just the run on startup toggle l, but all the toggles on the general page.

This is still happening with me as well

This happens to me as well.  Quite annoying having to re-enable PowerShell components e.g. PowerToys Run after a Shutdown / Start


Wrap inline begin transaction error and fix test

This appears to have been fixed or caused by a misunderstanding of how the spanner client handles errors, going to close for now.
https://github.com/googleapis/google-cloud-go/issues/7903#issuecomment-1883603976


When building a securetree model, if the user in the Party A don't have the data in the Party B, what will the model inference?

Hi,I am confused about when we built a securetree model, if the user in the Party A don't have the data in the Party B, what will the model inference for him/her?
Will the model makes a auto-completion for him/her by some strategy? or just filter it and do nothing? Thanks for answering!

Now Fate's secureboost does not support missing value now. It will support it in later version.

long time no reply, close this issue


[TESTS] Refactor tests to run on either the GPU or CPU

Much of the time spent in testing is duplicated work between CPU and GPU test nodes. The main reason is that there is no way to control which TVM devices are enabled at runtime, so tests that use LLVM will run on both GPU and CPU nodes.
This patch adds an environment variable, TVM_TEST_DEVICES, which controls which TVM devices should be used by tests. Devices not in TVM_TEST_DEVICES can still be used, so tests must be careful to check that the desired device is enabled with tvm.testing.device_enabled or by enumerating all devices with tvm.testing.enabled_devices. All tests have been retrofitted with these checks.
This patch also provides the decorator @tvm.testing.gpu to mark a test as possibly using the gpu. Tests that require the gpu can use @tvm.testing.requires_gpu. Tests without these flags will not be run on GPU nodes.

cc @zhiics @yzhliu @junrushao1994 @merrymercy @ajtulloch @kparzysz-quic

It might also be helpful to send a quick RFC given that the change of test infra will affect quite a lot of people

I agree that an RFC could be useful, but maybe I could just add information to the docs instead?

@kparzysz-quic I agree that using strings for targets here is pretty awkward. Is there a better way to check which device a target requires? I see that #6315 makes targets more structured, but I don't see a way to take a target string and get the associated device.

Currently there is no good way to switch away from str here, but the question is how much work would it take to allow, for example, two different 'cuda' devices to be available.  I haven't analyzed the code well enough to see, but if you could outline somewhere what changes would be necessary, it would help the future transition.

@tqchen I think I've addressed all issues. Do I need to do something to have Jenkins use the new Jenkinsfile?

@tkonolige because uses the old Jenkinsfile (before it get merged). Please try to send another PR to add gpuonly_test that redirects to the normal integration test first, then we can tweak the scripts once that PR get merged

@tqchen I'm getting a couple errors with CUDA initialization failing. I'm really sure of the cause, but it seems like it might have to do with forking.

@tqchen All tests are passing now... can we merge?

Thanks @tkonolige !


tests: settings: functional: nvs: adding native_posix target

Added native_posix target to the functional tests of NVS.
Signed-off-by: Kamil Piszczek<EMAIL_ADDRESS>

@kapi-no can you rebase?
@vanwinkeljan can you take another look?

@kapi-no can you rebase?

done

@kapi-no, I overlooked the sector size multiplier, this seems very high.

@Laczen, the NVS settings backend assumes that DT_FLASH_ERASE_BLOCK_SIZE (1 for native_posix) and the page size fetched from the Flash API (8192 for native_posix) are the same. The sector size is validated against page size during the NVS initialization.
I used the multiplier to align these values in the test, because I didn't want to touch native_posix DTS.

OK, thanks for the clarification.
@vanwinkeljan, any reason why DT_FLASH_ERASE_BLOCK_SIZE and page size (from flash API) are different ?

@vanwinkeljan, any reason why DT_FLASH_ERASE_BLOCK_SIZE and page size (from flash API) are different ?

@Laczen The native posix flash erase function does not check if the erase is a multiple of the sector size as such it is set to 1.


Add prometheus metrics for block authorship

closes https://github.com/paritytech/polkadot/issues/4327
New metrics:

proposer_block_proposal_time: Time to create a block for proposal. This is a superset of both proposer_block_constructed and create_inherents_time.
proposer_create_inherents_time:  Time to create the inherents for the block that is about to be constructed. This is a subset of proposer_block_proposal_time but does not overlap with proposer_block_constructed.

Existing metrics:

proposer_block_constructed: Time to construct a block for proposal. This is a subset of proposer_block_proposal_time and does not overlap with propser_create_inherents_time
block_verification_time: Time to verify a block (takes place directly prior to importing)
block_verification_and_import_time: Time to verify a block and then import a block. A superset of block_verification_time

bot merge


New code to publish to hex

It would be greatly appreciated if a new version with the new gleam and dependency updates could be published to hex.

Have just done, as 0.4.1
Haven't had much time lately, but was keen to add examples using the library in the repo as docs. Would be great if you were keen to contribute anything around that.

I will create some examples while building it out on my end.


[!] CocoaPods could not find compatible versions for pod "sound_generator"

ref: https://github.com/mertguner/sound_generator/issues/8
I installed sound_generator to a almost vanilla setup (Visual Studio Code, Flutter, MacOS) using:
flutter pub add sound_generator
Everything worked like described in the example, after I restarted the iOS simulator, I received the following error message
      Preparing
    Analyzing dependencies
    Inspecting targets to integrate
      Using `ARCHS` setting to build architectures of target `Pods-Runner`: (``)
    Fetching external sources
    -> Fetching podspec for `Flutter` from `Flutter`
    Resolving dependencies of `Podfile`
      CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only performed in repo update
    [!] CocoaPods could not find compatible versions for pod "sound_generator":
      In Podfile:
        sound_generator (from `.symlinks/plugins/sound_generator/ios`)
    Specs satisfying the `sound_generator (from `.symlinks/plugins/sound_generator/ios`)` dependency were found, but they required a higher minimum deployment target.
[...]
    [!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.

Note:
neither the "sound_generator.podspec" fix works, nor the "pod install --repo-update" or "pod 'AudioKit', '4.11.2' " in the podfile.

(I tried a couple of things right now, none worked:

removed pod lock file and pod folder
flutter clean
flutter pub get
pod update
pod install

Found the error by myself, the podfile changed, the deployment target was commented out, I had to remove that, I also added those lines to the end:
`post_install do |installer|
installer.pods_project.targets.each do |target|
flutter_additional_ios_build_settings(target)
target.build_configurations.each do |config|
config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
end
end
end
`
According to this SO https://stackoverflow.com/a/51416359/2360229 this helps, apparently it's a brute force method to remove deployment target requirements from the pods. Handle with care, brute force is never the best way ;)


D2IQ-61004: Adding etcd metrics on telegraf

High-level description
Adds the etcd metrics endpoint as one of the scraping sources on telegraf.
Corresponding DC/OS tickets (required)

D2IQ-61004 Include etcd in the dc/os monitoring, add dashboards.

Related tickets (optional)
(none)
Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot sync

Adding the ship it label without waiting for CI as test were green and the last changes only corrected typos in comments and added a change-log entry. @mesosphere-mergebot label [Ship It]

@mesosphere-mergebot label ship-it

@mesosphere-mergebot label ship-it


[YUNIKORN-2761] Explain preemption storm in usage doc

What is this PR for?
Added a new section to explain the redistribution of quota for same priority workloads and preemption storm.
What type of PR is it?

[ ] - Improvement

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2761
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Based on the description, the child queue without guaranteed resource could be preempted even though it's parent is under starving.
Could I say the best practice is  always set child guarantee if the parent guarantee is set?
If yes, maybe we could take the example in "Redistribution of Quota" is an anti-pattern?

Based on the description, the child queue without guaranteed resource could be preempted even though it's parent is under starving.
Could I say the best practice is always set child guarantee if the parent guarantee is set? If yes, maybe we could take the example in "Redistribution of Quota" as an anti-pattern?

Setting up guaranteed resource for the queues located at higher levels in the queue hierarchy definitely helps in Redistribution of Quota for two different groups in a organisation using simple configuration. We cannot say it as an anti-pattern even though it has side effect of creating preemption storm. Yes, by defining guaranteed resource for the queues at lower level can alleviate this storm issue. It is more of tradeoff one can make based on their requirements.


RBAC filter with conditions CEL

It would be really helpful to have more information on authoring conditions for RBAC filter policy. How would one approach this requirement: check equality between a filter state XYZ and desired string value "checked"? I know it is simplistic. Just I could not seem to have sufficient documentation to go on.

[2022-08-21 17:14:28.598][999666][debug][rbac] [source/extensions/filters/http/rbac/rbac_filter.cc:114] checking request: requestedServerName: , sourceIP: <IP_ADDRESS>:35036, directRemoteIP: <IP_ADDRESS>:35036, remoteIP: <IP_ADDRESS>:35036,localAddress: <IP_ADDRESS>:8083, ssl: none, headers: ':authority', 'localhost:8083'
':path', '/'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.68.0'
'accept', '/'
'x-forwarded-proto', 'http'
'x-request-id', 'b286b0db-3f9e-44e5-8cf9-3548f1463808'
, dynamicMetadata:
RBAC filter does not seem to check filter state at all?


Added Turntable animation exporter

Please review and test and let me know what you think, so after that i can post a tutorial on Twitter and also improve the standard image render export to also include support for background color and watermark.

Arrrr merge conflict, i knew this might happen, will fix

Also I get interesting transparency issues. Somehow black is made transparent for some reason in the animated gif?

Well it depends on how many files are being exported.

I like the idea of image size / resolution but i dont like the idea of setting the camera's view position before the shot, i wanted to implement it but i realize that it's going to give users less freedom and they won't be able to render from whatever angle they like, so i dropped it.

I kinda like the render with the bounding box, users should disabled the bounding box before render if they don't like it. But if you insist on disabling it before render or adding an option to disable it in the exporter, it ok.

About the transpareny issue, can you please explain more and tell me how to replicate it.

Most issues can only be looked into when you are done with travis

Regarding transparency issue: Here is a sample export http://i.imgur.com/locIHtR.gif

(1) Animation even with the slowest setting it takes 30 seconds and this computer is FAST. If we allow to define the view port size that can be improved by setting it smaller default. It's pretty large currently.
(2) I'm not sure I understand? They get the same freedom? With the improvement that they don't accidentally cut of the head. It's gonna be especially nice when we show the camera angles in the main view port.
(3) I think it should be an option in the exporter then.

I'm pretty much done with the heavy file changes for travis. You can branch off of the ci-prep branch and continue working!

Another issue I just noticed: The file doesn't get closed after the export completes. This needs to be fixed!

Unfortunately i can't view the video but i think i also experience a similar issue just now (all black are transparent) and i think the problem is coming from the fact that if no background color is set then black will be used as the transpareny color therefore all black pixels are rendered transparent by the gif encoder. There can be a workaround but am assuming it to be "dirty" or we just go with a semi transparent background (which won't be nice).

Well Gif Doesnt Support Alpha Transparency. So The Workaround should Be Easy. Find Color Not In Image, set transparent Pixels To That and Use That for Transparency. Can You Set What The Gif Encoder uses?

Ideally you should be able to tell it to use transparency...

Gif supports transparency, that why i said it dirty, it will require me to go pixel by pixel to check which color is in the image

Yeah i can set what color the gif encoder uses.

How were you able to know the file is not getting close?

Alpha transparency != transparency

I couldn't delete it :)

About the animation speed, it can be improved but i dont currently have any ideas, gifs take some time even with ImageMagick.

We seriously need to fixed the issue of head getting cut off (not showing full image), will look into that.

You mean Alpha transparency like png? Unfortunately gif does support that, My mistake.

No I don't think it does? Reference?

Typo,  i mean to type "doesn't"  :D

The Animation exporter needs improvement, the best things to avoid are are loops that will worsen performance. So i think we should remove gif transparency background support since it's not really alpha transparency and set black as the default background color instead. What did you think.

How are things going here? It looks really promising, but needs more work. Need help?

No, thanks. I will improve it.


soc: nxp: convert all NXP SOCs to use CMSIS SystemInit

Convert all NXP SOCs to use CMSIS SystemInit. This will enable NXP SOCs to align with the SDK startup flow, and to receive any fixes for errata that may be applied in this function. This change also allows some code to be removed from SOC initialization, as it is present in the CMSIS SystemInit call for the SOC.
In particular, the following SOCs have changes made to their startup flow:

KE1xf series: watchdog init moved to SystemInit, Code cache is now disabled conditionally, as SystemInit enables it unconditionally
K2x series: watchdog init moved to SystemInit
K6x series: watchdog init moved to SystemInit
K8x series: watchdog init moved to SystemInit
KL2x series: watchdog init moved to SystemInit
KV5x series: watchdog init moved to SystemInit
LPC54xxx series: enables RAM banks that may be powered off at reset
LPC55xxx series: enables RAM banks that may be powered off at reset
IMXRT11xxx series: enables ICache, disabled watchdog and systick
IMXRT6xx series: enables cache access

The attached CSV details testing for this change, with samples/hello_world
cmsis_system_init_report_file.csv

@danieldegrasse, HAL PR has merged. Please help update.

@danieldegrasse, HAL PR has merged. Please help update.

Updated, thank you

@henrikbrixandersen Based off your points about the watchdog reconfiguration, I went ahead and reexamined all SystemInit calls in NXP's SOC line. I've provided Kconfigs to bypass functionality wherever possible. As it stands, the KE18F should be able to boot without it's watchdog being disabled, and other Kinetis SOCs should be capable of the same thing provided the user provides a hook to setup the watchdog using z_arm_watchdog_init
Here's a summary of the SOC settings applied by each SystemInit call, and the Kconfig bypasses available:
KE1xf:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

Code cache enabled

Can disable code cache in SOC init with CONFIG_KINETIS_KE1XF_ENABLE_CODE_CACHE=n

K2x:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

K6x:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

K8x:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

KL2x:

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

KV5x:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

ICACHE enabled

Can be disabled at SOC init with CONFIG_KINETIS_KV5X_ENABLE_CODE_CACHE=n

DCACHE enabled

Can be disabled at SOC init with CONFIG_KINETIS_KV5X_ENABLE_DATA_CACHE=n

KW2x:

Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

KW4x:

Clock setup is possible, but disabled by default
Watchdog disabled

Can be bypassed by setting preprocessor define DISABLE_WDOG=0, set via Kconfig CONFIG_WDOG_ENABLE_AT_BOOT

LPC11u6x:

No HAL, so systemInit is not enabled

LPC51u68:

sets VTOR. Zephyr already does this, so this has no effect

LPC54xxx:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

SRAM2 bank clock enabled

This can be skipped by setting CONFIG_LPC54XXX_SRAM2_CLOCK=n

sets VTOR. Zephyr already does this, so this has no effect

LPC55xxx:

sets VTOR. Zephyr already does this, so this has no effect
FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Enables access to PowerQUAD

Currently, no Kconfig setting to disable this functionality

Enables the trace clock, for SWO output

Will be disabled at SOC init unless CONFIG_LOG_BACKEND_SWO is set

All SRAM bank clocks enabled

This can be skipped by setting CONFIG_LPC55XXX_SRAM_CLOCKS=n

IMXRT10xx:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Disables watchdog

Watchdog is already disabled out of reset

Disables watchdog power down counter

Currently, no Kconfig setting to disable this functionality

Disables Systick

Will be reenabled by Zephyr timer driver for Cortex-M Systick

Enables Code cache

Can be disabled at SOC init using CONFIG_IMXRT1XXX_CODE_CACHE=n

IMXRT11xx:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Disables watchdog

Watchdog is already disabled out of reset

Disables Systick

Will be reenabled by Zephyr timer driver for Cortex-M Systick

Enables Code cache

Can be disabled at SOC init using CONFIG_IMXRT1XXX_CODE_CACHE=n

Disables USB caching (which might be enabled by ROM)
Clears reset reason (functionality is disabled by default)
Enables fault when divide by zero (already enabled by Zephyr)

IMXRT6xx:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Enables access to PowerQUAD

Currently, no Kconfig setting to disable this functionality

Halts DSP core

Currently, no Kconfig setting to disable this functionality

Enables CACHE64 controller for flexSPI region

Can be disabled at SOC init using CONFIG_IMXRT6XX_CODE_CACHE=n

IMXRT5xx:

FPU Access enabled

Cleared at entry to z_arm_floating_point_init
By default this code block is ifdef'ed out

Enables access to PowerQUAD

Currently, no Kconfig setting to disable this functionality

Halts DSP core

Currently, no Kconfig setting to disable this functionality

Enables CACHE64 controller for flexSPI region

Can be disabled at SOC init using CONFIG_IMXRT5XX_CODE_CACHE=n

@henrikbrixandersen Based off your points about the watchdog reconfiguration, I went ahead and reexamined all SystemInit calls in NXP's SOC line. I've provided Kconfigs to bypass functionality wherever possible. As it stands, the KE18F should be able to boot without it's watchdog being disabled, and other Kinetis SOCs should be capable of the same thing provided the user provides a hook to setup the watchdog using z_arm_watchdog_init
Here's a summary of the SOC settings applied by each SystemInit call, and the Kconfig bypasses available:

Thank you, @danieldegrasse! This sounds like a much better solution from my perspective.

@hakehuang Could you run CI against this PR? I want to make sure all boards still function correctly with this change to startup flow.

@hakehuang Could you run CI against this PR? I want to make sure all boards still function correctly with this change to startup flow.

@danieldegrasse , I will update result once ready.


Trouble getting it running on mac – proposed change from volume bind to docker volumes

Due to an issue of ownership of the postgres_data directory (the postgres image didn't have permission to chown it and setting ownership to 999:999 didn't work) I wasn't able to get it running on my mac using the volume bind and had to use docker volumes instead. I think these are preferable as well as per the docker documentation: https://docs.docker.com/engine/storage/volumes/.
Creating a docker volume did get it working, and will work the same for both linux and mac.
When defining volumes in the compose.yml it will automatically create the volume the first time the compose is setup, and then reuse the volume.
The documentation for solving the migration issue would be required to be updated.mainly that instead of deleting the postgres_data folder, the docker volume should be removed with docker compose down --volumes or by finding and removing the postgres container using docker ps -a and docker rm [id], after which docker volume rm backend_postgres_data can be run. This might be preferable as docker compose down --volumes also will remove the backend-server container which might contain changed files depending on how development is performed.
backend/compose.yml

@@ -15,7 +15,7 @@ services:
   postgres:
     image: postgres
     volumes:
-      - ./postgres-data:/var/lib/postgresql/data
+      - postgres_data:/var/lib/postgresql/data
     environment:
       POSTGRES_DB: bittan_db
       POSTGRES_USER: postgres
@@ -28,3 +28,6 @@ services:
       interval: 1s
       timeout: 5s
       retries: 10
+
+volumes:
+  postgres_data:

Can create a PR if you think it is a preferable option. It's such as small diff that I felt it was easier to add it in the description.

This looks good.
Just to be clear, this would change the process of removing the postgres_data directory from:
 Shutting down the container $\to$ removing the postgres-data directory $\to$ starting the container.
to:
 Shutting down and removing the container $\to$ removing the postgres_data volume $\to$ restarting the container.
If I understood correctly this should be one method of achieving this without the need to access the container id. This should also not interfere with the backend-server.
docker compose stop postgres
docker compose rm postgres
docker volume rm backend_postgres_data
docker compose up -d postgres

Is this equivalent to your method or am I missing something?

Yes, you are complete right, that workflow is much nicer for replacing only the postgres container. Since django depends on postgres I thought it would block the removal of if, but I made that rule up 😁

I thought the wiki was part of the github project, but it seems it must be edited separately or in a local git repository. Weird decision on GH part 🤔


Can not start kibana step

Step 5 : RUN kibana plugin --install elastic/sense
---> Running in 0fec22fee790
ERROR  unknown command plugin
Usage: bin/kibana [command=serve] [options]
Kibana is an open source (Apache Licensed), browser based analytics and search dashboard for Elasticsearch.
Commands:
serve  [options]  Run the kibana server
help     Get the help for a specific command
"serve" Options:
-h, --help                 output usage information
-e, --elasticsearch <uri>  Elasticsearch instance
-c, --config <path>        Path to the config file, can be changed with the CONFIG_PATH environment variable as well. Use mulitple --config args to include multiple config files.
-p, --port <port>          The port to bind to
-q, --quiet                Prevent all logging except errors
-Q, --silent               Prevent all logging
--verbose                  Turns on verbose logging
-H, --host <host>          The host to bind to
-l, --log-file <path>      The file to log to
--plugin-dir <path>        A path to scan for plugins, this can be specified multiple times to specify multiple directories
--plugin-path <path>       A path to a plugin which should be included by the server, this can be specified multiple times to specify multiple paths
--plugins <path>           an alias for --plugin-dir

ERROR: Service 'kibana' failed to build: The command '/bin/sh -c kibana plugin --install elastic/sense' returned a non-zero code: 64

I run: docker-compose up (docker version 1.12.3)

@Van-Tien which branch are you using?

Oh ! That's it, Elastic just released the 5.0.0 !! Awesome :)
That means that the repository is broken for now, please switch on to the x-pack branch: https://github.com/deviantony/docker-elk/tree/x-pack
This branch will become the default soon.

This branch will become the default soon.
@deviantony any estimates?

I'll work on it this week-end :)

cool 😎

Just ran into this issue as well and was glad to see that it had already been posted. Thanks for the info @deviantony

IMO it would be better to choose a fixed version of kibana within the Dockerfile. Instead of FROM kibana:latest it could be FROM kibana:4.6.2 or later FROM kibana:5.0.0`.
see https://hub.docker.com/_/kibana/

+1

The repository has been updated !
master is now using :5 images.
You also have access to the following branches:

ELK 5 with X-Pack support: https://github.com/deviantony/docker-elk/tree/x-pack
ELK 5 in Vagrant: https://github.com/deviantony/docker-elk/tree/vagrant


Upgrades without a reboot

Not sure if this would be possible with RancherOS running as PID 1 but consider upgrading the OS without the need of rebooting the server.
With VMs this is not a big issue but with physical servers each reboot takes a while and has a small chance that it may not power back on.

we added ros os upgrade --kexec a while back - it seems to work, so I'm closing this


Avoid entity creation from single component with BuiltEntity methods

Closes #208

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.06 :warning:

Comparison is base (7c7ee80) 100.00% compared to head (41ce7c9) 99.94%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #221      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%
===========================================
  Files          131      131
  Lines         8728     8736       +8
===========================================
+ Hits          8728     8731       +3
- Misses           0        5       +5

Impacted Files
Coverage Δ

crates/modor/src/system_params/entity_mut.rs
100.00% <ø> (ø)

crates/modor/src/app.rs
100.00% <100.00%> (ø)

crates/modor/src/entity_builders/child_entities.rs
100.00% <100.00%> (ø)

crates/modor/src/entity_builders/child_entity.rs
73.68% <100.00%> (-26.32%)
:arrow_down:

crates/modor/src/entity_builders/mod.rs
100.00% <100.00%> (ø)

crates/modor/src/system_params/world.rs
100.00% <100.00%> (ø)

crates/modor_graphics/src/entities/module.rs
100.00% <100.00%> (ø)

crates/modor_input/src/entities/module.rs
100.00% <100.00%> (ø)

crates/modor_physics/src/entities/module.rs
100.00% <100.00%> (ø)

crates/modor_text/src/entities/module.rs
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cant set price

Hi,
when i want to set a price. i press ctrl d open the item and i click on as an example 1chaos on the graph or the listing.
Then he wont set the instead he opens the chat (pressing enter)
How to fix this ?

Hello! It seems, that you need a premium tab to set prices on items.
If @Kyusung4698 don't mind, I can make module for trading from any tab (via forum)

Hello! It seems, that you need a premium tab to set prices on items.

That's true. Only on premium tab the item has a extra menu to set the price. As this does not exist on none premium tabs the enter to set the price opens the chat instead.

If @Kyusung4698 don't mind, I can make module for trading from any tab (via forum).
Same as Acquisition, but using features of poe-overlay

That'd be awesome. If never used the forum tho. Could you explain a bit further how this would work? Thanks!

Could you explain a bit further how this would work? Thanks!

Firstly, we should know POESESSID - a token to login from the user's account.
Secondly, we should know an id of a forum thread in the trading part.
This is all requirements.
For all requests, POESESSID should be used as a cookie. We edit thread, URL of which will be like this: https://ru.pathofexile.com/forum/edit-thread/{id}/, forming list of items as [linkItem location="Stash name" league="..." x="..." y="..."]


Do not allow users to update some fields of themselves.

At the moment any user can update himself and then change more than just his name. We have to restrict this. See #2973.

Coupled with issue #1871 . Is this possible to fix for 2.1?

As discussed with @normanjaeckel
Normal user should be allowed to update username and about me only.
@normanjaeckel Please add your commit to #3001.

Done with #3001


Adapt TOC and make scroll interaction work again

Rename TOC.js > TOCProvider.js
Rename TOCPanel.js > TOC.js

Done.


In the deck editing view, there is a button on each card that directs the user to a card editing view, where values of the card are presented

closed by https://github.com/sopra-fs22-group-10/client/commit/60e320fc9c0839e7fe7579a9c0e37563e0aa9527


Website down...

I use this tool all the time :( Why is it down?

I was not able to renew the domain, now is 63 USD to renew it! :(
I guess I'll put it with another domain asap

Oh no! You could use Heroku... (free hosting/sub domain)

http://css2stylus.herokuapp.com is available

You could access it here for now http://dciccale.github.io/css2stylus.js/

Yay great!


Bug Report: when you open the mod the story mod, freeplay page has no background

and when I load into ANY song it just crashes

might I add, this is for the windows build from the sourcecode

I probably forgot to add some images to the repository


Update unicode-transact-sql.md

the original author meant length, not datalength. As written, the code will return several NULL rows.

@BrianCMeredith : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@BrianCMeredith Thanks for this correction. I just tested the original sample and your change, and your correction was a needed fix. We'll get this published!


fix a null check that caused the app to not compile

This works on my app.

in addition, I added a topMargin parameter.
This should be non-breaking


Walkthrough Videos

Walkthrough video is live! https://www.youtube.com/watch?v=_7U03GVD4a8&feature=youtu.be


Destroying a KSQLdb cluster leaves a topic behind

If I create a ksqlDB with Terraform it automatically creates a topic for me with a name like "pksqlc-xx123xx-processing-log".
If I then destroy this cluster with terraform the ksqldb gets removed as expected but it leaves the topic behind.
Ideally for us this topic would also be removed when the ksqlDB cluster is removed but if that doesn't suit everyone maybe there is an in-between option:
Would it be possible to change the provider to allow for us to define the topic ourselves separately and then point the ksqlDB cluster to use this topic.
Then we get the choice whether we want to keep it or not if we delete ksqlDB

Thanks for creating the issue @martinrw!
This issue seems to be similar to https://github.com/confluentinc/terraform-provider-confluent/issues/41.


⚠ ClamAV has degraded performance

In f64f07c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in d85aaee.


Unable to maintain model relationships

Version: 2.2.4
Framework: .Net Core 2.1
Steps to Reproduce:
   public class Blog
    {
        public int BlogId { get; set; }
        public string Url { get; set; }

        public List<Post> Posts { get; set; }
    }

    public class Post
    {
        public int PostId { get; set; }
        public string Title { get; set; }
        public string Content { get; set; }

        public int BlogId { get; set; }
        public Blog Blog { get; set; }
    }

So my model is technically the same with the Getting Started example.
When I save a Blog object, I would able to access the Post from the Blog object but when I restart my application it will become null.
When I look to Database, I can see in Post table the BlogId filled out but on Blog table it is not recorded.
So my question is, do I also need to add PostId on Blog Table? If yes, how would I achieve a List of Post in the table.
Thanks

The problem was not the database but how it is setup in the Project. Aside from the code-first model, need to declare the type of loading: docs.microsoft.com/en-us/ef/core/querying/related-data.


Is there a way to change which side the check box is on when using FormBuilderCheckBox?

Instead of it being on the right side can I put it on the left?

Hi @sjeanph,
To change the side on which the checkbox shows, kindly toggle the leadingInput attribute.

thanks!


Adding dropdowns

What's this PR do?
This PR implements Dropdown Menus
What are the important parts of the code?
Mainly with the dropdowns is keeping children 100% legit.
How should this be tested by the reviewer?
There is a working example in the codebase already in index.js
Is any other information necessary to understand this?
Really none, the main thing to remember is that any child of  can be turned into a menu item by using className="mdl-menu__item".   We keep "className" open propType's for this reason.  There is no fall back method yet for linking menulist to menu id.  I will pursue this in the future
What are the relevant tickets? (Please add closes, refs, etc)
Screenshots (if appropriate)

I have made all the requested changes as far as I can see.  I was able to do a lot of defaulting in the destructuring, and it worked like a charm.  I also implemented cloneelement as requested.  I also tested using an anchor with the class name instead, it works just fine.  In the future we could maybe drop a , but I think for now this will suffice just fine.


Measure and show the goal metric on the dashboard

Let's show the number of "onboarded" projects (= at least one sync release merged or one Koji build created by Packit or one Bodhi update created)  packages.
For the merged sync releases, we can either use Pagure API or @xsuchy has suggested searching for Packit commits via Sourcegraph.

It can but does not need to use Packit Service API or database but not need to.


Market > Select New Trading Pair > Trades Section not updating correctly

please see attached image…

Fixed in v0.15.21
Thanks for the heads up!


Stop sorting dicts (at least by default)?

Traditionally, pprint has sorted dict keys, because dict order was arbitrary so we might as well arbitrarily pick a nice order. But starting in 3.6 unofficially, and 3.7 officially, all dicts are effectively OrderedDicts (modulo some details about how == works and a few extra methods that OrderedDict has). So probably the printer should show this order.

Agreed. Further, if people start leaning heavily on the ordered property of dicts, sorting the keys could be actively misleading. Like you mentioned, users may want to override this when using a dict as a real dictionary, e.g. when printing a mapping of 100+ hostnames to IP addresses.
Thinking about a easy interface to do that... We could let the user control that in prettyprinter.prettyprinter.PrettyContext, an instance of which is passed to every pretty printer definition. As an example, if they have a DNSLookupDict class that wraps a native dict mapping hostnames to IP addresses that they want to sort when pretty printing, they could use ctx.set(DictOrdering, DictOrdering.SORTED) in their pretty printer definition. Something like this:
# In the prettyprinter module...
class DictOrdering(enum.Enum):
    INSERTION = 0
    SORTED = 1

# user-land
from prettyprinter import DictOrdering, register_pretty, pretty_call

class DNSLookupDict:
    ...

@register_pretty(DNSLookupDict)
def pretty_dnslookupdict(d, ctx):
    return pretty_call(
        ctx.set(DictOrdering, DictOrdering.SORTED),
        DNSLookupDict,
        dict(d)
    )

To get an output like
DNSLookupDict({
    'a.com': '<IP_ADDRESS>',
    'b.com': '<IP_ADDRESS>',
    'c.com': '<IP_ADDRESS>',
    'd.com': '<IP_ADDRESS>',
})

It could also be first class in PrettyContext, e.g.
ctx.sort_dicts(True)

but I feel like sticking to the simple ctx.set(k, v) would keep the API surface smaller, even if the user needs to additionally import DictOrdering. I'm considering adding a public verbosity context setting in the future, similar to what I do in the Django definitions, which would also work like ctx.set(Verbosity, Verbosity.MINIMAL)
Overriding the context is not as straightforward at the top level calls though, e.g. prettyprinter.cpprint, because the initial PrettyContext instance is created based on the arguments to that function. An additional keyword-only argument such as sort_dicts: bool could work, so that users may do cpprint(my_dict, sort_dicts=True) without having to import anything additional. It's not very consistent with the ctx.set(DictOrdering, DictOrdering.SORTED) interface, though.
Unless anyone chimes in with better ideas, I'll take some time during the weekend to implement this using the ctx.set(DictOrdering, DictOrdering.SORTED) interface and default it to DictOrdering.INSERTION.

do you want a mutator (set), or something that returns a copy of the of the context with different settings?

Oh, then I clicked through to the definition of PrettyContext, and discovered that set is already a return-a-copy interface, not a mutator interface. Well, I guess that's a vote for thinking about renaming it :-)

Yep, PrettyContext is fully immutable except for the visited attribute, which is a mutable set tracking visited values to prevent recursion. Having that mutable is just a performance optimization. So PrettyContext.set is indeed misleading; perhaps replace would be Pythonic as used in the immutable APIs for datetime.datetime and namedtuple._replace.

This is fixed in 0.8.0 that I just released on PyPi. Dict key sorting can be controlled in the printing functions pprint, cpprint, and pformat with the sort_dict_keys keyword argument. A global default can be set with prettyprinter.set_default_config(sort_dict_keys=True). It can also be controlled from PrettyContext, though the API for that uses the not-explicitly-public _replace method. The class needs more documentation and thought to make it fully public.

awesome :-)
On Sun, Dec 31, 2017 at 2:16 PM, Tommi Kaikkonen<EMAIL_ADDRESS>wrote:

Closed #5 https://github.com/tommikaikkonen/prettyprinter/issues/5.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tommikaikkonen/prettyprinter/issues/5#event-1405422629,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlOaBg8yCUfthjN2jv_CK_eY_ShEaaeks5tGAe1gaJpZM4RO0G7
.

--
Nathaniel J. Smith -- https://vorpus.org http://vorpus.org


Bulk import if data already exists

Hello,
I used bulk import for uploading quantity data for once, but I found it doesn't work if some data already exist.
{ [ArangoError: cannot create document, unique constraint violated]
  message: 'cannot create document, unique constraint violated',
  errorNum: 1210,
  code: 409,
  stack: 'ArangoError: cannot create document, unique constraint violated\n    at new ArangoError (/Invend/server_arango/node_modules/arangojs/lib/error.js:12:13)\n    at Request._callback (/Invend/server_arango/node_modules/arangojs/lib/connection.js:75:25)\n    at Request.self.callback (/Invend/server_arango/node_modules/request/request.js:360:22)\n    at Request.emit (events.js:110:17)\n    at Request.<anonymous> (/Invend/server_arango/node_modules/request/request.js:1202:14)\n    at Request.emit (events.js:129:20)\n    at IncomingMessage.<anonymous> (/Invend/server_arango/node_modules/request/request.js:1150:12)\n    at IncomingMessage.emit (events.js:129:20)\n    at _stream_readable.js:908:16\n    at process._tickCallback (node.js:355:11)' }

I believe this bulk import method should use your new upsert method as well, shouldn't it? #1280
Or the bulk import is only designed for creating, not for updating?
Bg,
Kevin

Yes, bulk imports are actually performing inserts, and they will fail when there are unique constraint violations. Currently bulk imports are not meant for updating existing documents, or, insert or update depending on whether a document already exists.

Is this feature possible in the future? Or any other methods? I'd like to insert or update bulk data.

What do you exactly mean with "this feature"? Currently, if you have a document with
"_key": "xyz"
(say) in the collection and then import another one with the same _key, you always get a unique constraint violation. What we could offer relatively easily is that in that case the old revision is replaced or even updated with the newly imported document. If this is what you need we could implement an additional switch for arangoimp.
If you do not specify _key in your documents to import, then the new documents have to count as new documents and get new unique _key entries automatically generated. Should they now violate a unique constraint defined by a secondary (user defined) index, then there is no sensible thing the imported could possibly do. Therefore this would be a case in which we cannot really help.

Hello,
well I mean import document with given _key. Suppose a bulk of data which have definite _key in the json file. I'd like to create or update them all together.
Do you think whether this case is possible?
I believe the second one you mentioned is completely correct. DB should always throws error for case of unique constraint.
Best regards,
Kevin

OK, I will see what we can do, this is a reasonable request and should not be a very difficult feature. I leave this one open for now.

See also
http://stackoverflow.com/questions/29105660/arangodb-aql-update-single-object-in
-embedded-array/29124327#29124327
(just for reference).

The feature has been implemented in devel.
This change extends the HTTP REST API for bulk imports as follows:
When documents are imported and the _key attribute is specified for them, the import can be used for inserting and updating/replacing documents. Previously, the import could be used for inserting new documents only, and re-inserting a document with an existing would have failed with a unique key constraint violated error.
The above behavior is still the default. However, the API now allows controlling the behavior in case of a unique key constraint error via the optional URL parameter onDuplicate.
This parameter can have one of the following values:

error: when a unique key constraint error occurs, do not import or update the document but report an error. This is the default.
update: when a unique key constraint error occurs, try to (partially) update the existing document with the data specified in the import. This may still fail if the document would violate secondary unique indexes. Only the attributes present in the import data will be updated and other attributes already present will be preserved. The number of updated documents will be reported in the updated attribute of the HTTP API result.
replace: when a unique key constraint error occurs, try to fully replace the existing document with the data specified in the import. This may still fail if the document would violate secondary unique indexes. The number of replaced documents will be reported in the updated attribute of the HTTP API result.
ignore: when a unique key constraint error occurs, ignore this error. There will be no insert, update or replace for the particular document. Ignored documents will be reported separately in the ignored attribute of the HTTP API result.

The result of the HTTP import API will now contain the attributes ignored and updated, which contain the number of ignored and updated documents respectively. These attributes will contain a value of zero unless the onDuplicate URL parameter is set to either update or replace (in this case the updated attribute may contain non-zero values) or ignore (in this case the ignored attribute may contain a non-zero value).
In the devel branch, arangoimp also has a command-line option --on-duplicate which can have one of the values error, update, replace, ignore. The default value is error.


Coinmarketcap api v2 support

Coverage increased (+5.4%) to 96.875% when pulling 8ac179ec1de2690067f16474ba85445e08dc4aa3 on coinmarketcap_api_v2 into 429230e12e750d2a1563988f60539a735fe1d2c1 on master.


feat: tech analysis of scope of rights.

A technical analysis of US113
Have a look at the rendered version
To validate:

[ ] Naming
[ ] Process
[ ] Storage

logion-network/logion-internal#596

Internal doc moved to https://github.com/logion-network/logion-internal/blob/main/doc/ScopeOfRights.md


Make the processing of batches atomic

Describe the bug
Currently, when meilisearch processes the tasks, there is three phases:

Find the tasks you need to process in your batch
Actually, process the batch, for example, index documents
Write the results in the task queue and delete the associated update files.

We just realized that there was a bug in step 3⃣:
4. We take a write transaction on the task store
5. Loop over all the processed tasks
6. For each task: Write its new status and delete its associated update file
7. Commit the content of the task store
Here, if a crash/restart happens during the loop of 6⃣, Meilisearch will restart, recreate a batch that contains at least the same tasks, and in step 2⃣ realize that some of the update files have been deleted.
=> We just lost some data.
To Reproduce
Steps to reproduce the behavior:

Index a ton of thing
Restart meilisearch in the middle of step 6⃣

Expected behavior
We don't lose any tasks
Meilisearch version:
Everything above and including v0.30.0

Fixed by #4435, will be release in v1.7.0-rc.2


Polymorphic function

Mb I'm missing something, but it seems docs says nothing about this. Suppose I'm using elm-html and elm-svg. I cannot do it like this:
import Html exposing (..)
import Html.Attributes exposing (..)
import Svg exposing (..)
import Svg.Attributes exposing (..)

view =
  div [ class "foo" ]
    [ svg [ class "bar" ] []
    ]

As I can understand class is definitely the same for Html and Svg but compiler doesnt understand that and gives me error. Its very annoying to use it in a way Html.Attributes.class and Svg.Attributes.class. The same issue with Html.svg and Svg.svg. Maybe there is a common good looking solution for this?

Html.Attributes.class and Svg.Attributes.class are really different functions.
They have different return types (Html.Attribute vs. Svg.Attribute) and different implementations. Namely, essentially:
Html.Attributes.class string = VirtualDom.property "className" (Json.string string)

vs.
Svg.Attributes.class string = VirtualDom.attribute "class" string

So, it's not the same function at all. It just has, minus the module qualifiers, the same name. Now, one might want to have overloading here, so that it becomes indeed calls to the "same" function in some sense. But that would require language features that Elm currently does not have.

@jvoigtlaender Thank you for clarifications. Here may be considered another example with adding toString method for custom type like I did in https://github.com/evancz/elm-html/pull/85 which cause probably the same problem.
May we somehow rename this and consider as a feature request?

The feature request would be "Add type classes like in Haskell, or an equivalent language feature". I'm pretty sure that Evan doesn't need a reminder about this through a GitHub issue, since it has come up so often.
Generally, language design discussions like this are better suited (in the Elm community at least) for the mailing list.
Concerning the "overloaded polymorphism" topic specifically, you might want to search that mailing list for the words "type class". Probably you will find many discussions that relate to your wishes expressed here and in https://github.com/evancz/elm-html/pull/85, and probably also some indication about why this is not something that is going to be added very soon on the language level.

@jvoigtlaender Would you think it has to be closed?

Generally I know that Evan wants issues in the Elm repos to be "actionable" in some sense. So if there is nothing concrete that can be done about this here (apart from further discussion, which might better happen elsewhere), yes, I think it should be closed.


add Pillow installation into Dockerfile for fixing scipy.misc.imread …

@caisq this is a new PR related to PR #5693 install Pillow in Dockerfile and PR #5711 add Pillow into docker build file. 2 changes are incorprated:

add Pillow installation into tensorflow/tools/docker/Dockerfile
add Pillow installation into tensorflow/tools/docker/Dockerfile.gpu

the following information for image size comparison:
gpu version image size drops, i guess latest-gpu tagged image is too old.

REPOSITORY                     TAG                 IMAGE ID            CREATED             SIZE
gcr.io/tensorflow/tensorflow   gpu                 8ca00ec56643        8 minutes ago       2.658 GB
gcr.io/tensorflow/tensorflow   latest-gpu          dd645f420f1d        10 days ago         2.713 GB

cpu version image size increases about 22MB < 2.5% up

REPOSITORY                     TAG                 IMAGE ID            CREATED             SIZE
gcr.io/tensorflow/tensorflow   Pillow              dff6ac3189bd        17 hours ago        981.6 MB
gcr.io/tensorflow/tensorflow   latest              5547120ff897        10 days ago         959.6 MB

Hao

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

Thanks for doing this again, @foreverfaint

PR merged. Thank you, @foreverfaint

:)


Storing port names of signature ports in main and primitive components.

Currently all original information about the physical program (names for ports, invokes, components, etc, and locations in the program they are bound) is stored in Info structs, and because Info is meant to be a struct that should technically be removable without breaking compilation, we need to store the true signature port names for a component somewhere to be used during compilation.
This is necessary because verilog blackbox externals need the right port names in order to properly connect, and similarly the main component should keep this information in order for the user to be able to properly interface with the program.
This information could be discarded for other user-defined components, instead relying only on port IDs to generate names (#211) so the question becomes how this information should be stored in the component.

Could add an optional boxed datastructure storing all the original necessary information for the external interface (signature port names, etc) and have the existence of this datastructure be equivalent to a flag for whether to preserve this information on compile, necessary for toplevel components and externals.

This is now done in the ir::Component right @UnsignedByte?

This was resolved by #186 which added InterfaceSrc.


Added support for iterable objects in {{#each}} helper

Currently {{#each}} helper supports either arrays, or objects,
however nowadays you can define custom iterable objects by overriding
a special method called Symbol.iterator, which results in empty result
being rendered.

[x] Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
[x] Maintain the existing code style
[x] Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
[x] Have good commit messages
[x] Have tests
[x] Have the typings (lib/handlebars.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
[x] Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
[x] Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

Looks interesting. I was under the impression that generator-functions were only used for asynchronous javascript (which Handlebars does not support).
I would like to wait for @wycats approval to merge this, because he wanted no new features until we have spec.
I don't know if that applies here, because this is just a helper being adapted a little, and other programming languages don't have iterators. But still...

Actually iterator doesn't have to be a generator function, it must comply to the iterator protocol. Inside it can be a normal class, ES5 function, etc...
Here's an example of implementing an iterable object without using generators, in two ways: by creating an array with iterable [...iterable] and iterating manually:
class MyIterator {
    constructor(arr) {
        this.arr = arr;
        this.index = 0;
    }
    next() {
        const value = this.arr[this.index];
        const done = this.index === this.arr.length;
        if (!done) {
          this.index++;
        }
        return { value, done };
    }
}

class MyIterable {
    constructor(arr) {
        this.arr = arr;
    }
    [Symbol.iterator]() {
        return new MyIterator(this.arr);
    }
}

const my = new MyIterable(['a', 'b', 'c']);

// using the iterator with ES6
console.log([...my]);

// using the iterator manually
const it = my[Symbol.iterator]();
for (let current = it.next(); !current.done; current = it.next()) {
    console.log(current.value);
}

I've been thinking about this PR, and it is probably save to merge this. But your tests will fail in saucelabs with IE11, because "Symbol.iterator" is not supported there, and we currently do not transpile the tests.
So either we build babel into the tests as well (see #1512) or you rewrite the test such that "yield" and "Symbole.iterator" is not used.
I would prefer the first solution, and I have thought about refactoring the whole test mechanism (to use jest and babel), but this might take some time. So the second option is probably the only viable one for the near future.

Thanks, didn't know tests are not transpiled. But the code is transpiled I believe, right? Or should I also rewrite the code in ES5? It's using [...context] now.
Do you have a way to run tests in IE? I've pushed a fix, but I don't have IE to try it out.
// eslint config in tests should be probably adjusted to point out that they're not transpiled

Yes, the code is transpiled, but most likely we don't want to include the polyfill into the runtime just because of this one helper. So, I've rewritten it in ES5 as well 😉

when the build is run in a local branch, it will be run in Saucelabs in a variety of browsers.
I'll have to do that manually later.
Oh, and please remind me again, if I haven't done so by next Monday. I have forgotten about some PRs in the past and I don't want this lying around for months.

released in 4.4.0

Thanks a lot!


[Discussion] Should this be converted to a django module?

Would it make sense to make it like a Django extension?

We could keep track of app-related files, collect them and possibly even load a new template
We could also create more generic views for general models registered and provide tags/snippets for templates

If we would I guess it would be best to incorporate the following functionalities:
Create a startapp command extension which shall allow the user to do the following while creating a new app:

specify a template for the application
chose not to load a template for the all
specify overall templates directory for the project
specify the static directory

Keeping in mind the above inputs the library should:

move all the required static files to the static directory of provided under the apps name, else move it to the standard location
repeat the step above for the templates after djangifying them.


aktualizr-auto-prov-creds: remove API Gateway URL if it exists.

It will only be used by garage-sign.
See https://github.com/advancedtelematic/ota-plus-server/pull/1913.

Passes oe-selftest and has been manually tested to verify that the URL gets removed if present and nothing happens if it is not present.


I have problem to get build in my flutter app

When i want to get build i got this Error on terminal:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugJavaResource'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > D:\flutter\Projects\goyan\goyan\build\app\intermediates\merged_java_res\debug\out.jar: The process cannot access the file because it is being used by another process.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 24s
Exception: Gradle task assembleDebug failed with exit code 1

my flutter doctor
[√] Flutter (Channel unknown, v1.16.1, on Microsoft Windows [Version 10.0.17134.1425], locale en-US)
    • Flutter version 1.16.1 at D:\flutter\flutter
    • Framework revision e6b0f5f238 (7 weeks ago), 2020-03-18 21:56:02 -0400
    • Engine revision 216c420a2c
    • Dart version 2.8.0 (build 2.8.0-dev.15.0 96cf889e6b)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\user\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = C:\Users\user\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[!] VS Code, 64-bit edition (version 1.43.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (3 available)
    • Android SDK built for x86 • emulator-5554 • android-x86    • Android 8.0.0 (API 26) (emulator)
    • Chrome                    • chrome        • web-javascript • Google Chrome 81.0.4044.138
    • Web Server                • web-server    • web-javascript • Flutter Tools

! Doctor found issues in 1 category.
Process finished with exit code 0

i try flutter clean and android studio invalid cache/ restart and i repair flutter pub cache but none of them worked

remove .dart_tool/ from your project and this will be fixed.

Hi @onyxtm
I'm not sure if with your last message
you mean that the issue has been solved,
if this isn't the case could you please run
flutter channel stable
flutter upgrade --force

and provide your flutter doctor -v ,
your flutter run --verbose
and a reproducible minimal code sample.
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Won't enable on MacBook

"Failed to load plugin" - Since I initially installed this on iPad, and put API there... do I have to install separately on MacBook? Or different API on different device? If I uninstall, does it mess up anything I've already done? One reason I broke down and bought an old MacBook is because the package manager wouldn't load on iPad. Now I can't access even the plugin here on the laptop. Would just like to know safe next step. Please :)

anyone?

Could you try testing the plugin in a new vault ?


Create a list of request types for Platform Admins

As the CPF Team is working in replacing manual processes with automation, we need to have a better understanding of what types of requests are currently implemented manually by Platform Admins.
Additional Context
The information about the current requests that product teams submit to the Platform Admins on the CPF team can be found in the #aws-tenant-requests channel in Rocketchat and in the cloud.pathfinder mailbox and by asking other team members
Acceptance Criteria

[x] document a list of different requests types that product teams submit to the CPF in this ticket
[x] have the list reviewed by Max and Warren
[x] present to the CPF Team

Please add the list of the requests to this ticket.

Meeting to be scheduled by Marisa to list request types


Multiplayer functional. Opponent username added to game page. Lobby automatically updates

See my messages on slack
On Mon, Nov 18, 2019 at 10:39 AM Daouda Gueye<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/xzhu0706/chess-variant/pull/68
Commit Summary

MISC
MISC
update
commit
Create game dialog
lobby is live
allow users to create games anonymously without being signed in
users who create games while being logged in will see their
usernames on the lobby
clicking on a game in the lobby loads the game component and passes
it data about that particular game
more work on multiplayer feature
implemented app sync subscriptions
players who join a game are taken to the game page with proper board
positioning. Meanwhile, the player who created the game is also
automatically taken to the game page with proper board positioning
closer to completing multiplayer. Constants used throughout the app
are
game component reimplemented. WithMoveValidation is no longer needed.
multiplayer now functional. I still have to handle game ending
situations
joined games are automatically removed from lobby
fixed create game dialog. clicking around it closes it if it's open
fixed merge conflicts
fixed merge conflicts missed in the previous commit
opponent username and whose turn it is now displayed on the game page
users can't join games they've created. In other words, they can't
play
sign in button now more responsive to window size

File Changes

A .eslintrc.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-0 (24)
M .graphqlconfig.yml
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-1 (2)
M amplify/.config/project-config.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-2 (2)
D amplify/backend/api/ChessVariantsAPI/parameters.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-3 (11)
D amplify/backend/api/ChessVariantsAPI/schema.graphql
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-4 (16)
D amplify/backend/api/chessvariant/schema.graphql
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-5 (13)
D amplify/backend/api/chessvariant/stacks/CustomResources.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-6 (61)
D amplify/backend/api/chessvariant/transform.conf.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-7 (3)
R amplify/backend/api/chessvariants/parameters.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-8 (2)
A amplify/backend/api/chessvariants/schema.graphql
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-9 (19)
R amplify/backend/api/chessvariants/stacks/CustomResources.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-10 (0)
R amplify/backend/api/chessvariants/transform.conf.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-11 (0)
R
amplify/backend/auth/chessvariants34a8e197/chessvariants34a8e197-cloudformation-template.yml
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-12 (18)
R amplify/backend/auth/chessvariants34a8e197/parameters.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-13 (10)
M amplify/backend/backend-config.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-14 (13)
D amplify/backend/hosting/S3AndCloudFront/parameters.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-15 (3)
D amplify/backend/hosting/S3AndCloudFront/template.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-16
(113)
M amplify/team-provider-info.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-17 (34)
A package-lock.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-18
(17346)
M package.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-19 (6)
M src/App.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-20 (4)
A src/Constants/Colors.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-21 (5)
A src/Constants/GameComponentConstants.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-22 (3)
M src/GameData.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-23 (2)
M src/WithMoveValidation.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-24
(111)
M src/chess/chess.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-25
(1060)
A src/components/AntiChess.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-26 (91)
M src/components/ChatInput.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-27 (20)
M src/components/ChatMessages.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-28 (57)
M src/components/NavBar.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-29 (2)
M src/graphql/mutations.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-30 (75)
M src/graphql/queries.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-31 (50)
M src/graphql/schema.json
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-32
(482)
M src/graphql/subscriptions.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-33 (75)
M src/pages/Account.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-34
(148)
M src/pages/CreateGameDialog.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-35
(129)
M src/pages/Game.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-36
(253)
M src/pages/Home.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-37 (58)
M src/pages/Lobby.js
https://github.com/xzhu0706/chess-variant/pull/68/files#diff-38
(443)

Patch Links:

https://github.com/xzhu0706/chess-variant/pull/68.patch
https://github.com/xzhu0706/chess-variant/pull/68.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xzhu0706/chess-variant/pull/68?email_source=notifications&email_token=AJXDIGH2F7KAMRYJP6RYO4DQUKZMLA5CNFSM4JOVMC2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2CNVNA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJXDIGEQ53OGO2ISMJDF6BDQUKZMLANCNFSM4JOVMC2A
.


Fix Django requirements.

Nomination won't work with Django 1.9.0 or 1.9.1, but works fine after that. Closes #7

Current coverage is 70.52%

Merging #60 into master will not affect coverage as of f9fe30c

Powered by Codecov. Updated on successful CI builds.

ping @damonkelley

:tada: WOOT WOOT :tada:
:+1:


Release 1.10.2 has only Source code files

Hi, @takahi-i !
I'd like to use latest Redpen, but unlike other releases, there are only Source code files in Release 1.10.2.
Why not there?

Thank you very much for the report @chie8842. I will look into the problem.

Same issue with 1.10.3: https://github.com/redpen-cc/redpen/releases/tag/redpen-1.10.3

@bfontaine  I uploaded the zipped file as the previous release. https://github.com/redpen-cc/redpen/releases/tag/redpen-1.10.3. Hopefully this works for you.


Unable to manually compile Infer in a Linux laptop

Hello,
I try to manually compile Infer in my 3-year Linux laptop, which running Linux Mint 18.1, CPU Core i5-4210U (4 cores) and 12 GB of RAM, 40GB of the spare hard drive. The compilation always fails at building the facebook-clang-plugin. It happens to me 4, 5 times and below is the error message of the latest attempt. When it fails, I checked that there are still 14GB of the spare hard drive.
Could you please advise what is wrong? It often takes about 2 hours to compile facebook-clang-plugin before it fails like described. The commands I used are ./autogen.sh; ./configure; make
However, this problem doesn't occur when I compile Infer in a Virtualbox machine, in the other PC
Thank you!
[100%] Linking CXX shared library ../../../../lib/libclang.so
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
[100%] Built target opt
make[3]: Entering directory '/tmp/clang-setup.SBjcpY/build'
Scanning dependencies of target arcmt-test
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
make[3]: Entering directory '/tmp/clang-setup.SBjcpY/build'
[100%] Building CXX object tools/clang/tools/arcmt-test/CMakeFiles/arcmt-test.dir/arcmt-test.cpp.o
[100%] Linking CXX executable ../../../../bin/arcmt-test
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
[100%] Built target arcmt-test
make[3]: Entering directory '/tmp/clang-setup.SBjcpY/build'
Scanning dependencies of target clang-check
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
make[3]: Entering directory '/tmp/clang-setup.SBjcpY/build'
[100%] Building CXX object tools/clang/tools/clang-check/CMakeFiles/clang-check.dir/ClangCheck.cpp.o
[100%] Linking CXX executable ../../../../bin/clang-check
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
[100%] Built target llvm-dwp
collect2: fatal error: ld terminated with signal 9 [Killed]
compilation terminated.
tools/clang/tools/driver/CMakeFiles/clang.dir/build.make:311: recipe for target 'bin/clang-4.0' failed
make[3]: *** [bin/clang-4.0] Error 1
make[3]: *** Deleting file 'bin/clang-4.0'
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
CMakeFiles/Makefile2:27048: recipe for target 'tools/clang/tools/driver/CMakeFiles/clang.dir/all' failed
make[2]: *** [tools/clang/tools/driver/CMakeFiles/clang.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
[100%] Built target libclang
make[3]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
[100%] Built target clang-check
make[2]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
Makefile:149: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/tmp/clang-setup.SBjcpY/build'
Makefile:150: recipe for target 'clang_setup' failed
make: *** [clang_setup] Error 2

Looks like ld get OOM-killed:

collect2: fatal error: ld terminated with signal 9 [Killed]

That's a bit odd given your 12GB of RAM, but not impossible. Try using fewer cores. One way is to edit facebook-clang-plugins/clang/setup.sh and change line 132 to JOBS=1 (instead of JOBS="$(getconf ...)") (sorry, GitHub is acting up and I cannot link directly to the line at the moment).
A faster way if you still have the temp dir lying around is to attempt to finish the installation by hand:
cd /tmp/clang-setup.SBjcpY/build
make -j 1 install
cd /path/to/infer/facebook-clang-plugins/clang
# strip binaries to save space
find install/{bin,lib} -type f -exec strip -x \{\} \+
# record that the installation was successful
./setup.sh --only-record-install

Let me know if this helps.

Thank you so much for your suggestion. I am able to build both facebook-clang-plugins and infer from the scratch by changing the number of JOBS to 1 as you suggested.
The compilation took really a long time though, more or less 3 hours.

Please reopen if there's still an issue here.


Mitigate memory leaks in jest-environment-node

Summary
This PR attempts to drastically mitigate memory leaks in jest-environment-node, raised by multiple issues:

https://github.com/jestjs/jest/issues/11956
https://github.com/jestjs/jest/issues/7874
https://github.com/jestjs/jest/issues/6694
https://github.com/jestjs/jest/issues/6814
https://github.com/jestjs/jest/issues/9980

The leaks are likely caused by the Jest/NodeJS sandbox (vm context) not being fully cleaned up between test suites.
This PR introduces 3 orthogonal mitigations, all made during env teardown.
The mitigations do not eliminate the leak entirely, but they drastically reduce it (at least in my testing).
The mitigations (each in its own commit):
1.  Global cleanup
In my testing, the biggest memory leak was caused by custom objects on global that keep references to source-code strings.
This change deletes all properties of all the objects in the environment's global; i.e:
// pseudo code
for (value in global) {
  for (key in value) {
    delete value[key];
  }
}

The exceptions are:

Objects set on the global in the environment constructor
Objects protected by a new "shreder" API in jest-utils (setNotShreddable)

For example, jest-circus's state is leaking, so it should be deleted; however, some of the properties are still used after teardown -- for instance, unhandledErrors and unhandledRejectionErrorByPromise.

The performance property (hack)

react-native comes with a preset that overrides this property on env-setup and never reverts it. Then, react-test-renderer attempts to access performance (via scheduler) after the env has already been torn down. A fix needs to be made to react-native to either (a) revert the performance property at teardown or (b) protect the custom performance object with the new shredder API.

The PR requires an update to the official docs, so users would know about this behavior, and how to avoid it if the need arises.
2. Event listeners cleanup
Another memory leak came from event listeners on the env process and node:cluster module, so these are removed at env teardown.
3. source-map-support cleanup
Although some cleanup of source-map-support exists in Jest, it's not enough. This module overrides Error.prepareStackTrace with an implementation that holds a cache that contains (memory-heavy) source code.
The mitigation here is to override Error.prepareStackTrace back to a no-op method at env teardown.
Stacked of nested (cause) errors were harmed by this change, so a better assurance of stack generation was added to jest-runner.
Test plan
I have been using one of our private repositories that are suffering from heavy memory leaks.
All of them use some version of NodeJS (18.x), Jest (27/29) and Typescript (4.x). They also make use of sequelize, lodash, moment, log4js, AWS SDK (v3) and many more packages.
Method

Clone Jest.
Modify runTest.ts in jest-runner to run with the local jest environment (/path/to/jest/packages/jest-environment-node/build/index.js) instead of the test repo.
Build the project.
Add .nvmrc with 20.14.0.
Run jest with this script in jest-cli:

// package.json
"scripts": {
  "jest": "NODE_OPTIONS='--no-experimental-fetch' node --inpsect-brk ./bin/jest.js -c /path/to/repo/test/unit/jest.config.js --detectOpenHandles --runInBand --forceExit --logHeapUsage"
}

(we use --no-experimental-fetch due to our use of nock for mocking HTTP)

Attach to the process via Chrome devtools, and let it run.

Capture a full heap snapshot soon after letting the process run.

Capture a second full heap snapshot after letting the process run a while and the heap grow.

Examined the objects that were allocated between the snapshots, targeting objects with highest shallow size.

Steps
1. Original code
With Jest's original code, we can see the following:

A huge chunk of memory is lodash's source code replicated by references to it from a custom matcher:
import _ from 'lodash';

expect.extend({ satisfies(...) {
  // code using lodash
}});

However, the vast majority of memory is probably held by jest-circus state (symbol JEST_STATE_SYMBOL):

In this snapshot we can see that just one state (of one test file) is leaking ~25MB in memory.
2. With global cleanup
This is after applying the first mitigation:

The leak has been reduced dramatically.
What we see now is (again) references to lodash's source code, but from a custom log4js we use:
import log4js from 'log4js';
import _ from 'lodash';

log4js.addLayout('json', () => {
  // code using lodash
});

Turns out that log4js adds the layout function to node:cluster module as an event listener.
3. With global cleanup + event listeners cleanup
Next, after adding the event-listeners cleanup as well, we see this:

This time, it seems that sequelize's source (map) code is being duplicated in memory.
In our version of seqeulize, it creates a new Error() on each query (this was replaced in https://github.com/sequelize/sequelize/pull/15559). This error is somehow captured and persisted in memory, keeping a custom prepareStackTrace (from source-map-support) that keeps the source code.
4. With all mitigations
After all mitigations in this PR applied:

We see that there's still some leaking source code, but that's for another PR :)

Thank you so much for working on this!
My main feedback would be to split up the changes here (already in atomic commits, which is nice!) into separate PRs so they can be merged independently of each other.
Some quick feedback on each of these

This seems a bit much to me at first glance, but I'll need to dig deeper
Unless those listeners are added by Jest, I don't think we should clean them up. All the node core modules share a cache (it's impossible to load node core modules within vm: https://github.com/nodejs/node/issues/31852). This needs to be done by users (if log4js has global side effects it should also expose a way of cleaning that up)
This seems reasonable, but could we do this in the teardown of the test env rather than the environment? I.e. after https://github.com/jestjs/jest/blob/213c3b2770a3278fe47267c1ace250251954fe4f/packages/jest-runner/src/runTest.ts#L381 (which I thought was supposed to solve exactly the issue you highlight 🤔)

@SimenB Thanks for the reply!

My main feedback would be to split up the changes here

Agreed. I wanted 1 PR mostly for the tests and the "dev journey". I'll keep the first method (global cleanup) here and move the others to separate PRs.

This seems a bit much to me at first glance, but I'll need to dig deeper

Waiting on your thoughts :) This is the bulk of the PR and the thing that reduces memory leak the most (by far).

All the node core modules share a cache

Yep. I missed that. At first I tried to clean listeners directly on node:cluster (without VM) and it didn't remove log4js's listeners; however, that was likely due to webpack replacing require.
This code illustrates how the listeners are indeed shared:
import vm from 'node:vm';
import cluster from 'node:cluster';

console.log(cluster.listenerCount('foo')); // 0
cluster.on('foo', () => {});
console.log(cluster.listenerCount('foo')); // 1

const context = vm.createContext();
vm.runInContext(`
  const cluster = require('node:cluster');
  cluster.removeAllListeners();
`, Object.assign(context, { require, console }));

console.log(cluster.listenerCount('foo')); // 0

I could potentially use the same technique I did with global but with cluster's listeners, but I feel like it's not worth it.

could we do this in the teardown of the test env rather than the environment?

Sure, I'll do it in a separate PR.

(which I thought was supposed to solve exactly the issue you highlight 🤔)

It only cleans custom handlers, but it doesn't clean fileContentsCache.

(which I thought was supposed to solve exactly the issue you highlight 🤔)

It only cleans custom handlers, but it doesn't clean fileContentsCache.

Mind opening a PR upstream with that? It was my PR some years ago that added the cleanup, seems I missed some 😀
https://github.com/evanw/node-source-map-support/pull/215

@SimenB

Mind opening a PR upstream with that? It was my PR some years ago that added the cleanup, seems I missed some 😀

Tried my best (without tests):
https://github.com/evanw/node-source-map-support/pull/339


rpc: add support for unix sockets

Currently, we only support binding to TCP interfaces for both RPC servers. We can easily add support for unix sockets as well. This would entail being able to recognize, parse, and then bind to the specified unix socket.

[ ] A good starting point would this this comment that more or less outlines the parsing and binding process.

Cool, I'll try to implement that.

@guggero Any success? I've started playing with this code.

Yes, I have a working solution ready. It just needs some tidying up then I'll create the Pull Request. Should probably have time to do so tomorrow.

@guggero :+1:


raftstore: use force_send to send ApplyRes

Signed-off-by: 5kbpers<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #13160
What's Changed:

Use force_send to send ApplyRes

Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test

Side effects

Performance regression

Consumes more MEM

Release note
Fix a bug that regions may be overlapped if raftstore is too busy

/merge


Error while attempting to approve smart contract (after adding second org)

This is a scenario for two organizations in two separate consoles.
Console1 has Orderer and Org1
Console2 has Org2
Console1:
Channel 1 is created and the peer is joined to the channel
Smart Contract 1 is proposed and committed on Org1
Add Org2 to channel
Console2:
Orderer from Console1 is imported into Console2
Org2 is joined to Channel1
Clicking on the "Begin approval process" button causes a black screen on the browser.

https://github.com/hyperledger-labs/fabric-operations-console/pull/94


Improving maintainability: TypeScript

Hello.
This pull request is part of #188.
Includes changes from #196.
Done:

[x] Use TypeScript (with right tsconfig.json for comfort debugging).
[x] Convert all codebase from *.js to *.ts.
[x] Typization.

@eirslett, @IanVS
Best wishes,
Sergey.

What if we set indent_size = 4 in .editorconfig? That's the current code style of the project (I think... even if it's different in some places?) and might lead to fewer lines changed in the commit diff.

indent_size = 4

@eirslett It feels like PHP for me, so I changed it to the Prettier.

...  and might lead to fewer lines changed in the commit diff.

@eirslett In the Files changed tab, please, check the Hide whitespace option and then click to the Apply and Reload button.

@eirslett, @IanVS
I converted the storybook-builder-vite code from JavaScript to TypeScript with strict flag enabled and fixed found bugs.
Also I made a small optimization to remove a duplicated code in the 7e73d0b commit.
It's inspired by #182 pull request, but as far I know there is no breaking changes.
This pull requests includes #193 and #196, so you need merge them first.
If you want to see diffs between them, you can use these links:

#193

https://github.com/eirslett/storybook-builder-vite/pull/193/files?diff=split&w=1

#196

Run lint on all codebase.
https://github.com/eirslett/storybook-builder-vite/pull/196/files/fdd592ef8e8b7843bd8756e0356c3df949b83fd6..929215d73c66dbec669ff3dd964c01530ed36286?diff=split&w=1
Fix code inspection warnings from a JetBrains IDE for the packages/storybook-builder-vite directory.
https://github.com/eirslett/storybook-builder-vite/pull/196/files/929215d73c66dbec669ff3dd964c01530ed36286..a8a5be0ca607fdea5051054ff9cdcec1213b668d?diff=split&w=1

#195

Convert all codebase from *.js to *.ts.
https://github.com/eirslett/storybook-builder-vite/pull/195/files/a81127990c1b1153b3e8a0db636a15706d1d2ee6..e3f404510a552cedf10c9281dec9f5c211fb83e1
Typization.
https://github.com/eirslett/storybook-builder-vite/pull/195/files/e3f404510a552cedf10c9281dec9f5c211fb83e1..7e73d0be7dfe61e76ff9b3f638c9ab33edfd7e56

Rebased onto #196.

Looks like it's in a conflict state after merging #196 ...

Looks like it's in a conflict state after merging #196 ...

@eirslett Fixed it.
This is most likely caused by squash merging.
If we have multiple branches on top of each other then it is better to use the Rebase and merge method.

Super, thanks a lot! Now we're in TypeScript land!


Aborting a chunked upload does not revert

Describe the bug
When using chunked uploads and aborting an upload no revert is sent and the patch files are left on the server.
As can be seen in the screenshot below the client does not send any request after canceling the current chunk.
The client definitely knows the file id already.
Logs

To Reproduce
My setup is based on filepond-boilerplate-php.
I configured FilePond as follows:
// Set default FilePond options
FilePond.setOptions({
        // upload to this server end point
        server: './api',
        chunkUploads: true
});

// Turn a file input into a file pond
var pond = FilePond.create(document.querySelector('input[type="file"]'));

Removing already finished uploads works correctly.
Expected behavior
After canceling the currently uploading chunk request I would expect FilePond to send a revert request in order to remove the already uploaded chunk files.
Information about your project:

Your browser and the version: Chromium Version 92.0.4515.131 (Official Build) Arch Linux (64-bit)
Your operating system: Arch Linux
FilePond version 4.28.2

I think this is a duplicate of https://github.com/pqina/filepond/issues/433
will close for now

Oh, right.
Sorry, I got a bit confused because sometimes it was mentioned that it affects downloads which failed after some chunks.
But if it also addresses still running uploads then this is a duplicate.

No worries :) I'm trying to keep things organised but I'm super busy so if you feel it's a separate thing then let me know and I'll re-open. All good.
About PR: Would super appreciate that, I believe I unfortunately couldn't merge it because I had to revert another change.


Please add support installation via composer

It's very helpful if BBii2 can be installed via Composer instead of hard-copying the source file into 'modules' folder.

This is top on our list actually, branch 2.0.0-dev is the current iteration of this feature (not done yet but soon(tm)).

I'm a fan of Yii and I like your BBii very much. I have used BBii1 in several projects.
Now I wish I could use it in Yii 2.0.
I tried this repo but it has some bugs. How a bout the status now?
Thanks in advanced

Sadly we are currently backed up with clients so getting back to this will take a bit of time. Sorry for the delay.

Composer support added via https://github.com/sourcetoad/bbii2/releases/tag/2.0.0 release.

Hi @davidjeddy,
I see in packagist two public packages:
sourcetoad/yii2-bbii2 at https://packagist.org/packages/sourcetoad/yii2-bbii2
sourcetoad/bbii2 at https://packagist.org/packages/sourcetoad/bbii2
Which one is correct?

We recommend https://packagist.org/packages/sourcetoad/bbii2


SharePoint.Search.QueryTool Bug

After selecting Result Source ID, the url does not change.

When you select, and move the mouse out it should change in the URL. Just tested. @hasankoroglu can you provide a screenshot or steps on how to reproduce?

Thanks for interest.
https://1drv.ms/v/s!Aj-2PjPharvQg-8_BMYpgLNf9RcHXg

Hmm.. weird. When I pick and then select another field, the value is replaced with the guid and all updates. What happens if you type the below in the field, does it update?
SPSite|My Site Collection Source

Nothing happens. https://1drv.ms/v/s!Aj-2PjPharvQg-9BlDb44zUxDvLylQ

Weird. Can you try on another machine? What OS are you running? If you have Visual Studio you could try compile yourself and see if it bugs somewhere. Also, try v2.6 and see if you get the same error.

@hasankoroglu Do you have any more information on reproduction of this, if not I will close it for now.