Mismatch on detecting existing bookmarks

Hi,
I started using linkding not an hour ago. I love it! Especially the injector add-on.
I bookmarked this URL with two tags (iOS, bookmark): https://github.com/sissbruecker/linkding/blob/master/docs/how-to.md
Now if I go back to the main project page https://github.com/sissbruecker/linkding/ and want to bookmark the project page, potentially with different tags, the extension actually pulls the two tags of the how-to URL and the description.
If I edit the new bookmark (deleted the unrelated tags, change the description) I end up with 2 bookmarks.
This can give a false impression that specific URL is already bookmarked while it's not.
Is this by design? Or something I can configure (just like bitwarden, host matching rules, full URL matching, etc.)
Thanks!

So if I try to bookmark https://github.com it also pulls a completely unrelated tag.
I checked the bookmark/check endpoint and this looks like the most accurate (but more expensive) approach.

Right, the other issue with that endpoint is that it additionally scrapes the website metadata, which takes longer. Maybe this could be combined to show the scraped metadata in the input fields like the bookmarklet does. The current solution only shows the title from the tab, but then uses the scraped metadata anyway which can be misleading.


[TC-DISHM- 1.1, 3.1, 3.3] Yaml Manual Script has to be updated

Description:
Yaml Manual Script has to be updated as per Test plan for below test cases

[x] TC-DISHM-1.1

In Steps 3, 4 comment has to be updated as per Verification Step document.

[x] TC-DISHM-3.1

PICS has to be updated as per Test plan for all Steps.

High level PICS has to be updated as per Test Plan.

[x] TC-DISHM-3.3

In Step 8 PICS has to be updated as per Test Plan.

High level PICS has to be updated as per Test Plan.

Steps to reproduce:

TC-DISHM-3.1 - All Steps
TC-DISHM-3.3 - Step 8

Yaml References:

https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_DISHM_3_1.yaml
https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_DISHM_3_3.yaml

Test Plan References:

https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/mode_dishwasher.adoc

Addressed in PR
https://github.com/project-chip/connectedhomeip/pull/32116


Can I use open source model in topicGPT, like llama3?

Can I use open source model in topicGPT, like llama3?

Would be great if we are able to use other models as well!


Update libjpeg-turbo to 2.0.0

This is a new release, see https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.0.0
I've updated the patch for disabling execs, docs and headers and will try to get it upstreamed.

Thanks for the PR!
This seems to cause regressions across the board that we'll need to fix before merging:

[ ] Fails to build on x64-linux (regression)
[ ] Fails to build on arm-uwp (regression)
[ ] Fails to build on x64-windows-static (regression)
[ ] Regresses freeimage:x64-windows
[ ] Regresses fltk:x64-windows
[ ] Regresses dlib:x64-windows
[ ] Regresses butteraugli:x64-windows
[ ] Regresses graphicsmagick:x64-windows
[ ] Regresses libgeotiff:x64-windows
[ ] Regresses qt5-base:x64-windows
[ ] Regresses wxwidgets:x64-windows

Superceeded by #4635. Thanks for the PR!


fix: iOS app crashes on call to presentFullScreenPlayer #2808

Fixes iOS app crashes on call to presentFullScreenPlayer. Closes https://github.com/react-native-video/react-native-video/issues/2808

With this change, I am getting a build error in XCode 14.2:
RCTVideo.swift:300:26 Value of optional type 'AVPlayer?' must be unwrapped to refer to member 'replaceCurrentItem' of wrapped base type 'AVPlayer'

@adambutler Oh, sorry, I think I opened a PR to the wrong branch


EDA - create pair plots for numerical values against state

Use pair plots on numerical features against target variable state
Also numerical features that have been transformed from categorical features using technique Label Encoding.

@tobiaskaemmerling
If we use label encoding I can only do the useful pair plots for transformed categorical variables which are ordinal data:
Launched
Deadline
not for the nominal categorical data: category, subcategory, country.
Alternatively we can use one-hot-encoding


Scan test

Improved scanning routine and fixed some minor bugs. In some cases, redundant arguments were removed. Further solver optimizations were added.

Committed your suggestion, bug should be fixed.


Reliable segfaults in tests (I think the module does not work at all)

See the output on all rakudo releases:
https://gist.github.com/Whateverable/1786e70fbce5223fdb2c48cb05265ec6
So it's not a regression and my best guess is that the module is simply broken.

It sort of worked (compiled at least) on systems that have 32-bit time handling, but that's not the case on many systems anymore. I'm changing it now so that it will work regardless of whether time_t is 32-bit or 64-bit and regardless of what size of fields struct tm looks like on the host system, as such things are only vaguely defined by the relevant standards. I hadn't realized it at the time of first writing.
I also seem to have been in a hurry as there were several other typos in the tests an META6 that would have prevented it from installing and working correctly anyway. :(
I hope all of that will be fixed shortly. The compile issue, at least, is fixed.


Add functional tests for cFE Access Table Content APIs

Is your feature request related to a problem? Please describe.
Need open source functional tests for certifiability
Describe the solution you'd like
Add functional tests for cFE Access Table Content APIs
CFE_TBL_GetAddress - Obtain the current address of the contents of the specified table.
CFE_TBL_GetAddresses - Obtain the current addresses of an array of specified tables.
CFE_TBL_ReleaseAddress - Release previously obtained pointer to the contents of the specified table.
CFE_TBL_ReleaseAddresses - Release the addresses of an array of specified tables.
Describe alternatives you've considered
N/A
Additional context
N/A
Requester Info
Alex Campbell GSFC

I'll start working on this.


Failing when converting to pdf

Hi, I was just giving the project a try but its failing at the last step of converting html to pdf. Logs:
info: Saving Ebook at [/Users/shubhammalik/utils/notion-to-pdf/session_files/output/merged/prime_book.pdf]
/Users/shubhammalik/utils/notion-to-pdf/node_modules/@subhamx/notion-to-ebook/bin/wkhtmltopdf/wkhtmltopdf: /Users/shubhammalik/utils/notion-to-pdf/node_modules/@subhamx/notion-to-ebook/bin/wkhtmltopdf/wkhtmltopdf: cannot execute binary file
error: main: Error: Command failed: /Users/shubhammalik/utils/notion-to-pdf/node_modules/@subhamx/notion-to-ebook/bin/wkhtmltopdf/wkhtmltopdf --enable-local-file-access --margin-bottom 10 --margin-top 15 --header-spacing 5 --header-html<EMAIL_ADDRESS>cover<EMAIL_ADDRESS>toc --xsl-style-sheet<EMAIL_ADDRESS>/Users/shubhammalik/utils/notion-to-pdf/session_files/tmp/tmp.html /Users/shubhammalik/utils/notion-to-pdf/session_files/output/merged/prime_book.pdf
/Users/shubhammalik/utils/notion-to-pdf/node_modules/@subhamx/notion-to-ebook/bin/wkhtmltopdf/wkhtmltopdf: /Users/shubhammalik/utils/notion-to-pdf/node_modules/@subhamx/notion-to-ebook/bin/wkhtmltopdf/wkhtmltopdf: cannot execute binary file

Hi, @malikshubham827; thank you for reporting the issue. Could you please share the operating system you are using? So far, I have tested it only on Linux. I had planned to include the executable of wkhtmltopdf for windows and mac, but then dropped the plan to keep the bundle size small (it's already 40+ MB 😰).
Let me explore some ways to tackle this problem of os dependent dependencies (after end-sem 😅)! So far, I can only think of having a post-install script to fetch the right binary files based on OS! (But this isn't a good practice). In the worst case, we shall include all the binaries! (let's hope not!🤞)
If you find any solution feel free to share it or post a PR.

The same thing on Windows 10. Last step fails and no pdf. No conversion tool wkhtmltopdf  obviously.
$ node index.js
info: Starting operation
info: Removing all files in session Files Dir!!!
info: Creating directories in session Files Dir!!!
info: Starting Html Export Subroutine
info: Task Id: c21b1ca8-c332-43d1-b55b-26ed6790577a
info: Current Task status: success
info: Got the S3 download URL
info: Starting file download
info: File download successful
info: Removing all non dot files and folders from C:\Users\neupo\develop\ebook\session_files\input
info: Files removal success
info: Starting file extraction
info: File extracted successfully
info: Saving the output file as HTML at tmp location
info: Exporting the HTML To Ebook
info: Saving Ebook at [C:\Users\neupo\develop\ebook\session_files\output\merged\prime_book.pdf]
error: main: Error: spawnSync C:\Users\neupo\develop\ebook\node_modules\@subhamx\notion-to-ebook\bin\wkhtmltopdf\wkhtmltopdf ENOENT
Done in 7.81s.

@mikolasan It makes sense. Let me give another try to fix the issue with conditional check on the type of OS and then downloading the relevant binary from upstream. If not we will go with the logic you mentioned above.

Unfortunately, I couldn't find a simple way of installing wkhtmltopdf  by getting the hardware architectures, OS distributions, and their version. And even if I could build a post-build script there is no way for me to test it on all of these permutations. 😥
So finally went with the approach as suggested by @mikolasan and left the wkhtmltopdf installation part to users. Additional check to ensure that wkhtmltopdf is present in PATH is also included.
Closing this issue for now! Thank you @mikolasan and @malikshubham827 for your valuable inputs 😃. (And my apologies for the late actions).


(NOT FOR SUBMISSION) Proof of concept of Storage conformance tests

test.proto describes the expected format of all JSON files
signing.json is an example of some Signing V4 tests
validation is a small amount of code to validate that all the JSON files are valid
.travis.yml runs the validation code

This is a quick and dirty way of doing the validation; other languages may well be more suitable.

Question: What is the experience for a failure (bad type or bad JSON format) and is it easy to debug based on test logs?

I've just added a commit with an invalid piece of JSON. Here's the relevant part of the Travis log
$ dotnet run -p storage/v1/validation -- storage/v1/*.json
Validating storage/v1/signing.json
Error: InvalidProtocolBufferException: Unknown field: desription
The command "dotnet run -p storage/v1/validation -- storage/v1/*.json" exited with 1.

(If there are multiple files, it will validate all of them even if there's an error in the first one - but it'll only show the first error per file.)

This is now a PR in its own repo.


Document how to use the Twitch CLI to test EventSub

It's a bit tricky to send testing payloads to the Twurple EventSub listener or middleware:

The internal subscription ID is part of the URL
The internal subscription ID is part of the secret, but might be cut off since the maximum length of a secret is 100
With strictHostCheck on, you can't use localhost for mock events - you need to use your public host name (can we fix that?)

All of this should be documented properly on a new page of the documentation.

Example of Twitch CLI usage:
twitch event trigger subscribe \
-F https://example.com/event/channel.subscribe.42 \
-s channel.subscribe.42.yoursecret

Where channel.subscribe.42 is the id of the EventSubSubscription returned by any subscribeTo... function.
And yoursecret is the secret passed at EventSubListener creation.
Example:
const secret = "yourSecret"
const listener = new EventSubListener({
  // ...
  secret,
})
const subscribeSubscription = await listener.subscribeToChannelSubscriptionEvents(channelId, e => {
	console.log(`new sub!`)
})

// Generate twitch CLI test command
console.log(
  'twitch event trigger subscribe',
  `-F https://example.com/event/${subscribeSubscription.id}`,
  `-s ${subscribeSubscription.id}.${secret}`.substring(0, 100)
)

Hope I'm right and helping other dev around :)


Set private key in pass template before producing pass buffers

Hello, I faced a fix when a "createPass" attempt shows this message:
"INFO ReferenceError: Set private key in pass template before producing pass buffers
at Pass.asBuffer (/var/task/node_modules/@walletpass/pass-js/dist/pass.js:53:19)
at createTemplate (/var/task/customers/customerAddWallet.js:67:28)"
How do I fix it?
Please any insight.

You need to obtain your certificate from Apple first, then set it to Template as described in documentation - i.e, either Template.load or Template.setPrivateKey

I am doing the next steps:

I am create template the way manually, like you mention
Then "loadCertificate"
Then add image to template, logo and icon.
Then create Pass
Then, asBuffer()

Are you sure your certificate contains private key encrypted with buchos password? Did you created it according to documentation?

Thanks for the help!.
Finally, I did it.
I was wrong doing  bad conversions ".p12" to ".pem", then I fixed this and the process worked.
Regards

Could you please tell me the correct way or commands to create .pem from .p12? I'm having the same issue.

Same problem here. using "loadCertificate" i get the error "Set private key in pass template before producing pass buffers".
I've downloaded from Apple Identifier the certificate, open it in my keychan and then exported it as .p12.
Then i run the passkit-key command as described. It ends up creating two files: wwdr.pem and cert.pem (cert is the name of the .p12 file as well).
It's not clear which one of the file should be loaded as Certificate. And what about "private key"?

@pvsantosh i finally managed it.
The pem file must be converted with the key or it will ask for the privateKey.
I used this command inside the key folder:
$ openssl pkcs12 -in <cert-name>.p12 -clcerts -out signerCert.pem -passin pass:<your-password>
Note:  is the password you typed when you exported the certificate from the KeyChain. This command will ask you to set another password you will use later.
And then i was able to load the certificate this way:
await template.loadCertificate('<path>/signerCert.pem', <password>);
Here you will use the password generated while converting the cert from p12 to pem.
It took me 3 different repos documentation to get this 🤦

@anija thanks for posting this. I got it to work with your openssl command.


Switch accounts

I have multiple accounts under one ITC login, seems switching these accounts doesn’t work 🤔

Thanks for reporting. Will take a look.

Implemented in #29

Thank you!
Sent with GitHawk


Serving static files with add_static() breaks event loop on windows

Long story short
Serving big static file makes impossible to process new requests at this time. Event loop does not pass execution to other coroutines.
If client stops to receive file in the middle of transfer then server becomes broken - it cannot receive/process new requests.
Expected behaviour
Other requests can be processed while file is served.
Actual behaviour
Server hangs for some time or becomes broken forever.
Steps to reproduce
Server:
from aiohttp import web

def index(request):
    return web.Response(text='hello world')

app = web.Application()
app.router.add_get('/', index)
app.router.add_static('/static/', path=str('./test/'))
web.run_app(app)

Client:
import asyncio
from aiohttp import ClientSession

async def download(file):
    async with ClientSession() as session:
        async with session.get(file) as resp:
            while True:
                data = await resp.content.read(1000)
                if not data:
                    break
                await asyncio.sleep(1)

loop = asyncio.get_event_loop()
loop.run_until_complete(download('http://<IP_ADDRESS>:8080/static/1.mkv'))
loop.close()

Copy your favourite movie to test/1.mkv
Run server
Try to fetch page http://<IP_ADDRESS>:8080/
Run client
Try to fetch page http://<IP_ADDRESS>:8080/ one more time

Your environment
aiohttp (1.1.3)
Python 3.5.2 (v3.5.2:4def2a2901a5, Jun 25 2016, 22:18:55) [MSC v.1900 64 bit (AMD64)] on win32
Win10

Well, sendfile should use aiofiles in fallback code.
sendfile already works in async manner.

After small print-debugging session I found the issue
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/file_sender.py#L132
Instead of
                count = count - chunk_size
                if count <= 0:
                    break
                chunk = fobj.read(count)

there should be
                count = count - chunk_size
                if count <= 0:
                    break
                chunk = fobj.read(chunk_size)

Could you please include the fix in next release.

Excellent catch!
Fixed by aiohttp 1.1.5


kvclient(cdc): make TiCDC available during rolling upgrade

What problem does this PR solve?
Issue Number: close #9660
What is changed and how it works?
Make TiCDC work fine with TiKVs which don't support stream-multiplexing.
This generally happens when rolling upgrade a TiCDC cluster.
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/ok-to-test

/ok-to-test

/retest-required

/retest

/test cdc-integration-mysql-test
/test cdc-integration-storage-test
/test cdc-integration-kafka-test

/test cdc-integration-mysql-test

/test cdc-integration-storage-test

/test cdc-integration-mysql-test

/test cdc-integration-storage-test

/test cdc-integration-kafka-test

/retest

/retest

/test cdc-integration-pulsar-test

/retest

/test cdc-integration-mysql-test

/retest

/test cdc-integration-pulsar-test

/test verify

/test cdc-integration-storage-test

/retest


Add cool license badge

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Combo-boxes on disabled pages are not disabled

E.g.  When looking at a validation you don't have access to, all controls should be disabled, but the change to the power select control (from basic select) seems to have broken this and all combo-boxes are still editable.

For completion this appears in pluto ver 1.0.11.  We will await 1.0.12 for the fix to this particular issue.


move IntoPy::type_output to IntoPyObject::type_output

Part of #4618
This moves IntoPy::type_output to IntoPyObject::type_output. This is a breaking change, but this is an experimantel feature and the ergonomics of duplicating the API is pretty bad, because it would need fully qualified syntax on the callsite to determine the trait to use.

Not really sure why MSRV needs the additional lifetime bounds, but they should be implied anyway, so spelling them out should not really be a problem either.


No data legend on choropleth map

No data not displayed in the legend of choropleth maps.
It worked in<EMAIL_ADDRESS>https://observablehq.com/@neocartocnrs/bertin-js-chropoleth?collection=@neocartocnrs/bertin

Fixed in<EMAIL_ADDRESS>


Referencing other parameters results in out of order rendering

I use the ability to reference other parameters in conjunction with defining unique parameters. This works great for documenting inheritance chains. However, I've noticed that when doing this, the unique parameters are always rendered first in the documentation. I assume this is probably because of how you lookup the #see references and fill those in during another pass. Nothing serious but a little confusing because the parameter list doesn't match the method definition.
Steps to reproduce
class MyYard
  # @param value [String] The string
  def base(value); end
  # @param value (see #base)
  # @param value2 [String] The other string
  def base2(value, value2); end
end

Actual Output

Expected Output
Expected value to come before value2 in the parameter list.
Environment details:

OS: [Windows 7]
Ruby version 2.2.3
YARD version 0.9.5

I have read the [Contributing Guide][contrib].
[contrib]: https://github.com/lsegal/yard/blob/master/CONTRIBUTING.md

We could probably sort the params by their placement in the method signature, if provided. Patches accepted for this.

Opened PR #1065


refactoring to use variadic modules

Coverage increased (+0.1%) to 81.429% when pulling e1fb08659e64b7b52f4053858322426c778f8aa8 on refactor/variadic-modules into 60a20b2f26795f6e2d58c049800967e4741e1d77 on master.


exclude binary files from git grep

Scanning binary files like images doesn't make too much sense. So I excluded all binary files. What do you think?

👍


Consider removing certain hyper-specific buttons from public API

All of the overhead of maintaining an API for a very specific set of button defaults seems to me a little screwy and brittle.
(Looking at you RestoreDefaultsButton and LaunchAdminButton 😉 )

As trivial as it is, we did see a use-case for the launch admin button in an app where we were not using the standard AppBar (another customer header was installed) but still wanted to have some standardized controls in an app toolbar.   I think they button up just enough "micro consistency" to be worthwhile in cases such as this one where we land "default" buttons in non-default places.

Happy to close this.  We can certainly revisit if they become too much of a maintenance burden)


Use dedicated storage pool for live tests.

/azp run java - storage - tests

seems to be working

/azp run java - storage - tests

/check-enforcer override

Failures in live tests are not related to this change.


added confirmation dialog

I rule and have completed some work on Case Manager that's ready for review!
When removing a patient from the call list we now ask for confirmation. If that is what the user wants through a pop up dialogue. It looks like this:

It relates to the following issue #s:
https://github.com/colinxfleming/dcaf_case_management/issues/656
@colinxfleming

Current coverage is 98.51% (diff: 100%)

Merging #664 into master will decrease coverage by <.01%

@@             master       #664   diff @@
==========================================
  Files            27         25     -2
  Lines           540        537     -3
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            532        529     -3
  Misses            8          8
  Partials          0          0

Powered by Codecov. Last update f9d0ec4...2bbd10f

Can we add "...from your call list:" to the end of the phrase? So it doesn't sound like you're removing them from the system.

My dude @itsWill ! Thanks so much for making this enhancement, and for following up on @mebates ' feedback so quickly! Really appreciate your work on this front -- this is going to save our users a lot of headache, I think.
Was able to recreate and confirm behavior -- merging.


Unexpected OK error code with HTTP status code of 401. code=INTERNAL

Using gcloud-0.3.0, java environment.
I am deploying a webapp in the appengine flex environment and using gcloud datastore to store http session information.  I receive the error in the title of this issue when I try to execute a projection query (to check if indexes are present) and when I do an Entity query.
I do not receive these errors if I run my webapp locally and talk to gcloud datastore remotely.
I also do not receive these errors if I do a gcloud:deploy after having run my app locally and inserted an entity into the datastore.
Note that in both cases, the indexes are actually always present.

I'm attaching screen dumps from the appengine logs to show the problem.
The query to check if indexes are present is:
Query query = Query.projectionEntityQueryBuilder()
.kind("GCloudSession")
.projection("expiry")
.filter(PropertyFilter.eq("id", "-"))
.build();
The query to check for expired sessions via Entity query is:
Query query = Query.entityQueryBuilder()
.kind("GCloudSession")
.filter(CompositeFilter.and(PropertyFilter.gt("expiry", 0), PropertyFilter.le("expiry", System.currentTimeMillis())))
.limit(100)
.build();

A little more information:
I also get the same "Unexpected OK error ..." when I try to insert an entity into the datastore from my webapp in flex unless there is already an entity present (previously inserted by my webapp running locally).
Attaching another screen shot of the log trace.

Were you using Flex Vanilla or Flex Compat?

@aozarov  I was using vm:true.  I also did briefly try env:flex, but there were errors accessing the memcached service so I backed off to just vm:true (which I'm guessing is compat?)

I mean, where you using "runtime: custom" and a non-compat Docker?

app.yaml:
runtime: custom
vm: true
docker:
built off GoogleCloudPlatform/jetty-runtime

@aozarov note that the jetty inside that docker has jetty-gcloud session management enabled, which means that jetty has the gcloud-0.3.0 jars and all their dependencies on its classpath.

@janbartel do you still have this issue if you use this dependency?
    <dependency>
      <groupId>com.google.cloud</groupId>
      <artifactId>gcloud-java-datastore</artifactId>
      <version>0.2.7</version>
      <scope>compile</scope>
    </dependency>

@meltsufin  I cannot reproduce this error today with a freshly deployed app.
Niether can I reproduce it with a previously deployed app that I restarted, and it was failing yesterday!
If I make any headway on this, I'll comment here.

My coworkers starting to use our project are having this issue too. They use Windows by the way. And the 401 error tells this is pretty much a non-authorised error. Is there global variable probably missing for the library to use the Google Cloud Platform as a proxy to the system? It seems they are authenticated inside gcloud but the application is doing unauthorised queries.

I solved it by running
gcloud auth application-default login

It creates %HOME%\AppData\Roaming\gcloud\application_default_credentials.json which seems the credentials used by the library.


add ssl options for install

Description
Allows haproxy_install to support ssl_lib and ssl_inc options.
Issues Resolved
None
Contribution Check List

[X] All tests pass.
[X] New functionality includes testing.
[X] New functionality has been documented in the README if applicable

          1 Warning

:warning:
This is a big Pull Request.

  Generated by :no_entry_sign: Danger

Hey @derekgroh can you move your change log entry to underneath the Unreleased heading please?


Test with 2.085 and pin DMD to 2.086.0

https://issues.dlang.org/show_bug.cgi?id=20022

Updated to LDC-1.15 >.>

Yeah I gave up on older LDCs


Removed document and composer from SuperEditor widget property list (Resolves #2160)

Removed document and composer from SuperEditor widget property list (Resolves #2160)
It's been confusing for a while that SuperEditor requires an Editor, Document, and DocumentComposer, despite the fact that the Document and DocumentComposer both exist within the Editor. This PR deprecates the document and composer properties on SuperEditor in favor of just an Editor.

@angelosilvestre I'm gonna merge. Feel free to follow up with comments.


Support a reliable way to get a parameter type

Currently, to get the parameter type, we need to do something like:
methodParameterInfo.method().parameters().get(methodParameterInfo.position())

The issue with this is that parameters() includes the synthetic parameters (confirmed by @FroMage ) whereas they are not counted in the result of position(), leading to incorrect results if we have synthetic parameters.
@FroMage implemented a nice user friendly API to get the parameter name. We should do the same for the parameter type.

For backwards compat I can't change the behaviour of parameters(), but I can find another solution.

Well, actually, parameter annotations will tell us the number of non-synthetic params. Parameter names (if present in the bytecode) will also tell us. But if you method has no annotation and no parameter name it has no info on synthetic params. And also, javac and ECJ generate different synthetic params for enums. So it's not that easy.

    /**
     * Returns the nesting type of this class, which could either be a standard top level class, an inner class,
     * an anonymous class, or a local class.
     *
     *
For historical reasons, static nested classes are returned as INNER. You can differentiate
     * between a non-static nested class (inner class) and a static nested class by calling
     * {@link java.lang.reflect.Modifier#isStatic(int)} on the return of {@link #flags()}

     *
     * @return the nesting type of this class
     */
    public NestingType nestingType() {
...

This is lying at least with ECJ, the ACC_STATIC flag is missing in the bytecode.

Actually it works and javap is just hiding it.

OK, so:

I can get it to work for toplevel and inner classes.
For local classes it requires an Index parameter to look up the declaring method's class to see if it's static.
For anonymous classes it doesn't look like Jandex actually supports them (I can't find any instance of an anonymous class that responds anything else than TOPLEVEL).
For enums I can't figure out how to make it work. ECJ produces the following bytecode:

  private org.jboss.jandex.test.BasicTestCase$Enum(java.lang.String, int, byte);
    descriptor: (Ljava/lang/String;IB)V

Where the String, int are synthetic and the byte is real, but javac produces this:
  private org.jboss.jandex.test.BasicTestCase$Enum(byte);
    descriptor: (Ljava/lang/String;IB)V

Notice that the signatures are different, and jandex does respect the signature when you look up the method, but the descriptor contains additional parameters. So I can't actually support this by looking at the bytecode.

Lets rewind a bit @gsmet: we only get synthetic params for constructors of non-static inner classes (including local/anon) and enums. Is there any use-case where you would actually look at the type of those constructors's params? In most usages I would ignore those because you can't easily invoke them. But perhaps your use-case is different?

Enums shouldn't be an issue for sure. My concern was more about non-static inner classes and constructor validation.
But I suppose for now, we can ignore this. It was more to be thorough and avoid unexpected array out of bound exceptions.

So what are you going to do with those non-static inner classses?

Is #48 OK for you?

For anonymous classes it doesn't look like Jandex actually supports them (I can't find any instance of an anonymous class that responds anything else than TOPLEVEL).

Are you sure that's the case? That's the whole reason the value exists?

I added some tests for nesting type which appear to work:
https://github.com/wildfly/jandex/commit/a8b6a213de7c19915018a941c408c370e07be2f2

For local classes it requires an Index parameter to look up the declaring method's class to see if it's static.

This shouldn't be needed, a local class can't be static.

So I think what needs to research this a little more. My current thinking is that everything the class file spec references the real absolute descriptor positions (so including synthetic) and its only the generic info which does not have synthetic data. So we should check the annotation attribute values to verify that understanding. I'm 99.9999% positive its at least the case with LocalVariableTable, since the descriptor is how the JVM operates with opcodes. Assuming that is the case the we need to be more intelligent about the applySignature step in the indexing process. If we have parameter name info we can easily merge that by skipping over the synthetic params. If we don't we are SOL and probably have to drop the generic info if there is a count mismatch.

Looking at the javap output parameter annotations does indeed correspond with signature (no synethic info) LocalVariable table has slots that correspond with real parameters (as expected), synthetic params are committed.

Are you sure that's the case? That's the whole reason the value exists?

Damn, I have to recheck then.

This shouldn't be needed, a local class can't be static.

They can, if they are in a static block or method, which depends on the enclosing method.

Ok so after thinking about this for awhile I am starting to think that synthetic parameters have zero value and we should just exclude them

On the one hand I agree, they have no value. On the other they are also a good indicator that you won't be able to use reflection to call the annotated method/constructor if they are there. The easiest case is an inner type which requires the outer instance, but you still have to get it. All other cases, such as enums, anonymous types or local types, it's hard to conceive of a reason to instantiate them, let alone get all the required synthetic values to satisfy the synthetic params.
Given that most use-cases I've seen so far of indexing methods are about collecting info about the method, but ultimately to be able to invoke it, I think all these cases are degenerate and non-useful for indexing. So perhaps not worth spending too much time on?
Examples of synthetic params that I've come across:

non-static types: pointer to the outer instance, always as the first param
enums: in some cases, String and int
local types: any final captured variable value (can combine with the outer instance too), almost always after real params

@n1hility so here's my test which fails for anonymous types: https://github.com/wildfly/jandex/commit/995766435d73f26f3a8961a0c2a831c2863f3596
I'm testing anonymous types inside static init and normal init blocks. Perhaps that's the only cases where it fails? I did plan on testing inside constructors and then static/normal methods after that.

@FroMage ah yep, that's a bug, fix is in 6da4d88db0389f19bf2cacdc84335c886c230b89

@FroMage ok the invocation case is convincing but for sure we can't correlate the signature with the true descriptor UNLESS method parameter info is included  (LocalVariableTable could probably also work using the slot info). If we can't correlate we will have to store two parameter arrays, and also return some sort of sentinel in APIs that no longer works (for example when looking up an annotation targeted to a MethodParameterInfo it would return -1 for descriptorPos). Unfortunately alot of code will fall into the scenario. Luckily synthetic parameters are uncommon, so we only need the two arrays when we don't have info and the descriptor length doesn't match the signature length.

@FroMage @gsmet I have started to address this with type annotations related to other fixes/improvements. In the type annotation case there was virtually no compatibility impact, so this was already applied in the latest bug fix release. However, I suspect calling code exists for standard parameter annotations that does deal with adjusting the position, so I am thinking behavioral changes relating to this need to be done in the next minor at least.
The changes I plan to make is to auto adjust annotation parameter indexes for non-static inner classes (local, anon, and nested). In this way you can reliably use the index.
For enums I need to do a little more research.

@FroMage @gsmet I have started to address this with type annotations related to other fixes/improvements. In the type annotation case there was virtually no compatibility impact, so this was already applied in the latest bug fix release. However, I suspect calling code exists for standard parameter annotations that does deal with adjusting the position, so I am thinking behavioral changes relating to this need to be done in the next minor at least.
The changes I plan to make is to auto adjust annotation parameter indexes for non-static inner classes (local, anon, and nested). In this way you can reliably use the index.
For enums I need to do a little more research.

Done in #192.


RFC: termination_by syntax: less wiggle-room with variables

Status quo
Currently (assuming #2921), the termination_by syntax expect a list, possibly empty, of identifiers (or _), then =>, and then the body.
The semantics is that the names in the list override any variable names from the back. Examples:
def foo (n : Nat) : Nat := foo (n-1)
termination_by n => n

works but equivalently
def foo (n : Nat) : Nat := foo (n-1)
termination_by => n

or
def foo (n : Nat) : Nat := foo (n-1)
termination_by m => m

This is a bit silly: Why would the user not want to use the variable name given in the header? Is there ever a compelling reason?
Of course, the list of variables do have their justification: When the function arguments are not in the header, but bound by a lambda or by match equations:
def foo : Nat → Nat := fun n => foo (n-1)
termination_by n => n

or
def foo : Nat → Nat
 | 0 => 0
 | n => foo (n-1)
termination_by n => n

If there are variables both in the header and in the lambda/matches, the list is applied from the right:
def foo (a b : Nat) : Nat → Nat → Nat
 | 0, 0 => 0
 | c, d => foo (a-1) (b - 1) (c - 1) (d-1)
termination_by _ x y z => x -- termination goal: b - 1 < b

and you can wildly mix overriding variable names and referring to the original name using _:
termination_by x _  _ y => x + b + y -- termination goal: (a - 1) + (b - 1) + (d - 1) < a + b + d

Oddities
This works, and knowing the implementation it’s not surprised it behaves like this, but it is a bit odd:

When no variable needs to be introduced, the arrow in termination_by => n looks odd.
The right-to-left rule is probably not intuitive.
Usually it is easy to predict how many parameters “after the :” lean considers, but maybe not always.
I find hard to justify why the user even can change a to x here.

Proposed change
I wonder if our users are not better served with a more rigid syntax:

The number of variables mentioned must match the number of “unnamed” variables  (lambda after the := or discriminants in matches equations). No fewer and not more.
If there are no such variables, the => must be omitted.

So above the valid variants would be:
def foo (n : Nat) : Nat := foo (n-1)
termination_by n

def foo : Nat → Nat := fun n => foo (n-1)
termination_by n => n

def foo : Nat → Nat
 | 0 => 0
 | n => foo (n-1)
termination_by n => n

def foo (a b : Nat) : Nat → Nat → Nat
 | 0, 0 => 0
 | c, d => foo (a-1) (b - 1) (c - 1) (d-1)
termination_by _ y => a + b + y -- termination goal: (a - 1) + (b - 1) + (d - 1) < a + b + d

If the system requires the user to get the number of variables right, the effect will more likely match the user’s intention than the more liberal “override from left to right”.
Impact
As we are changing the syntax anyways in #3040, the pain of having to touch this code would be mostly alleviated.
The implementation would probably have to carry around a bit of extra book keeping to remember which variables were originally bound before the : and which were afterwards. (This is maybe the reason it’s not already like this). But maybe worth for the extra guard rails.
Maybe there is an good compelling reason to allow users to rename variables? I don't see one yet.
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

When no variable needs to be introduced, the arrow in termination_by => n looks odd.
The right-to-left rule is probably not intuitive.

Not necessarily contradicting you here but note that this is the same behavior as case and similar tactics.
Would it be too weird to force the user to write
termination_by fun n => n

in the unnamed case?

When no variable needs to be introduced, the arrow in termination_by => n looks odd.
The right-to-left rule is probably not intuitive.

Not necessarily contradicting you here but note that this is the same behavior as case and similar tactics.

Yeah, I'm somewhat on the fence over this change overall.
Also, omitting the => when the list of variables is empty means the parser has to backtrack/look ahead, not sure how desirable that is

Another alternative for "less wiggle room" would be to require naming all the variables!
I think more important than the actual requirement is what the error messages are when it is not fulfilled.

Yes, that's a possible alternative. I think “all variables” can be confusing, though, or at least counter intuitive, as it would involve variable variables, or variables closed over by lifting out a letrec. Also unnecessary verbose.
(The last bit makes me wonder what happens if only the termination_by clause in a local letrec mentions a parameter of the enclosing function, if that gets correctly added to the lifted function's parameters. Probably not, and probably not a relevant corner case, but I should at least open an issue and create a test.)

I started to implement that on top of #3040 in https://github.com/leanprover/lean4/pull/3099.
The change I have to make to user code “feel right”, changes like
@@ -468,7 +468,7 @@ theorem State.join_le_left (σ₁ σ₂ : State) : σ₁.join σ₂ ≼ σ₁ :=
       next => apply cons_le_cons; apply le_trans ih (erase_le _)
       next => apply le_trans ih (erase_le_cons (le_refl _))
     next h => apply le_trans ih (erase_le_cons (le_refl _))
-termination_by σ₁ _ => σ₁.length
+termination_by σ₁.length

So worth persuing.
I am hitting a slight snag in the interaction with GuessLex, which infers a termination order, and wants to use parameters that come before the :, but are not named (e.g. type class parameters, autoImplicit parameters, shadowed parameters). From the user we’d expect to name them before using them, but we can't do that in GuessLex.
At least currently, GuessLex goes through the same interface at the user. The new check is applied before, so only applies to user-written code, but it still means we can’t have all of these:

GuessLex finds termination orders that use implicit parameters.
The termination argument found (and printed on demand) by GuessLex adheres to the syntax requirements we have for users, and can thus pasted directly.

A pragmatic way forward may be to suggest termination_by clauses that may not work right away, but may require the user to first name/rename some parameters, or trim the list of variables. I’ll see what I can do.

Done as per #3040


Fixing typos & grammar

🚀 Deployed on https://673718569293af58942fce75--cozy-fox-0defec.netlify.app


fix: iframe rendering

By default, DOMPurify removes the content of iframe, but I think iframe is a commonly used tag

Thanks for this fix, just ran into the bug and was wondering why I couldn't see the issue on main's code!


Question: will also support the FT232RL? RS485 USB

Great! Do you think this driver will also support the FT232RL ( http://wiki.in-circuit.de/images/d/da/610000191A.pdf ) that I have already? I'm searching for the difference between drivers -- if any -- but don't see anything yet.

I don't see why not, looking at the page where I got the driver from: http://www.ftdichip.com/Drivers/D2XX.htm it doesn't look like it specifically excludes certain devices.
You might have to add the vid/pid for the FT232RL to this file though: https://github.com/Jark/FTDISample/blob/master/src/FTDISample/Package.appxmanifest
Let me know how you get on.

Thanks. I'll try it!

Progress! The device is now active on the Windows IoT core precisely as your tutorial describes. Very nice. However, in my program (based on http://ms-iot.github.io/content/en-US/win10/samples/SerialSample.htm ) I don't get the device recognized off the bat. I assume the following?

I'll need to put the .winmd and XML files that you mention into the obj/ARM/Debug/Core/WinMetadata folder of my project? Or where? there is no "lib" folder.
add the dev capabilities you mention to the package.appxmanifest.

Any other suggestions? Thanks again!

Glad that it was useful to you :) Hopefully eventually they'll make it work natively without having to use any different drivers or different apis.


Update style.css to use terminal-container

The .terminal class was messing around xterm.js CSS rules, resulting in the cursor never being in a focused state.
Also, update Xterm.js CSS to the latest version, fixing minor wrapping issues.

Thanks @marcosnils 😄

thanks to you and happy new year! @akalipetis  :tada:


Add a step which merges together our OpenAPI references

Issue

closes Woosmap/woosmap#1196
Describe your changes

Made it so openapi-smusher.sh is ran after the OpenAPI is generated.
This script installs openapi-smusher a Golang binary and then runs it.
The binary combines the OpenAPI of https://api.woosmap.com/what3words/openapi.json with the generated one into a file called merged-woosmap-openapi3.json.
How to test

The CI runs the script and the dist folder contains the generated JSON file
https://developers.woosmap.com/api-reference/?ref=https://raw.githubusercontent.com/Woosmap/openapi-specification/dev/openapi_smusher/dist/merged-woosmap-openapi3.json#tag/Woosmap-for-what3words-API
Checklist:

[x] My code follows the style guidelines for this repo
[x] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings/errors
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I don't require ops changes for this PR to go to prod
[x] This change does not include a migration

Comments

There's a long string example which indue a style issue.
I will update and amend the style in redoc.js to break words.


Linux: Check available executables at precompile time

Does this make sense? What if I run the function, install a program, as per the instructions in the error and then run the function again, in the same Julia session. It wouldn't work in that case right? What is the motivation for doing it at compile time? alert() doesn't have to be fast, I don't think... the only reason I did the @static for the os's is that I don't what to load PyCall unless I need it, since it's a pretty heavy package.


Feature/validation

This is an extension to the previous pull request #17

I'll pull these two PRs apart so they don't depend on each other.

@mindsers I've cleaned up this PR to have it stand on its own as well.

@mindsers I've rebased the changes you did from the merges on your master branch into this branch.

@aroemen Can you rebase again the changes please?

@aroemen Can you rebase again the changes please?

@mindsers I've rebased this branch now.

@aroemen Thank you so much for this huge bunch of work you did here. ❤
I still have some thoughts/questions about it:

I think this is a great feature to have but I don't want it to be a breaking change. So I would rather making it optional. My idea is: current default behavior is to read and make available the content of the CHANGELOG file (often needed on a CD pipelines where we don't want things to break) and for other use cases (like CI pipelines where we expect things to break) we can ask for validation and then the action acts like a CHANGELOG linter
Can I ask you why the validation_depth is needed? I got what it does but do we want to validate only some entries?
If we tend to act like a linter and since a lot of GitHub repo have multiple CHANGELOG, should we be able to read, parse and lint several files?

@mindsers I agree that having validation is more of a CI process for the most part and that this change shouldn't break the reading side of itself. Setting the validation depth property to 0 (which is the default value) prevents any validation from happening. So by default, this will not be a breaking change as the consumer would have to set this property in their workflow manually.
My thought behind the idea of the validation_depth property was to help people if they needed to transition to the KeepAChangelog format and for performance. Rather than forcing them to update their entire changelog, they could just start by updating a few entries and go from there. Also, I was worried that long changelogs could exponentially extend build times. Setting this property to a set value will prevent validation from occurring unnecessarily.
Reading and parsing multiple changelog files brings on another level of challenges. I don't see this as a necessary feature though at this time. Why would a build need to go way back in time to get release details of an old build? Also if a consumer wanted to parse/validate multiple changelogs, they could execute the action multiple times for each file.

Reading and parsing multiple changelog files brings on another level of challenges. I don't see this as a necessary feature though at this time. Why would a build need to go way back in time to get release details of an old build? Also if a consumer wanted to parse/validate multiple changelogs, they could execute the action multiple times for each file.

Totally agree with you. Having a build step for each file is a better solution.

I agree that having validation is more of a CI process for the most part and that this change shouldn't break the reading side of itself. Setting the validation depth property to 0 (which is the default value) prevents any validation from happening. So by default, this will not be a breaking change as the consumer would have to set this property in their workflow manually.
My thought behind the idea of the validation_depth property was to help people if they needed to transition to the KeepAChangelog format and for performance. Rather than forcing them to update their entire changelog, they could just start by updating a few entries and go from there. Also, I was worried that long changelogs could exponentially extend build times. Setting this property to a set value will prevent validation from occurring unnecessarily.

OK I understand why validation_depth is needed and that it already allows to NOT break existing build (thanks to its default value). But maybe we could think of an improved API. I mean, an API where the user ask explicitly for validation (for example a validation or check or lint boolean property). Then we could let validation_depth at a reasonable default value like 5 or 10, so user don't have to overthink what's a good value for it.

Another question I have is what's about return value or logging message of a failed validation? Breaking a build saying "your changelog isn't valid" or breaking it saying " your changelog isn't valid because you put a breaking change in a minor release" is definitely not the same for the end user.
So, I think we should display better human readable error messages when the validation failed. What o you think?

@mindsers I guess that is your call if you want an additional property or not. I didn't do it originally because I felt it was unnecessary to have additional properties. If you do add an additional property and the user wants to change how deep or shallow to validate, the consumers would now have to set multiple properties. Not the end of the world, but I'm always in the camp of less is more.
As for the error messaging, I think that can be added after the fact as an enhancement. While their really was no scope initially defined for this feature, this is additional development work on a PR that is already getting lengthy.


Use PEP 517 build system

This includes pyproject.toml file and declarative setup.cfg config.

Thanks for the PR @CyberTailor!
Can you comment in #5 on what this brings to the library users and to myself (as a maintainer)?

Sorry but I'm going to put this aside for now. setup.cfg isn't required anymore since a month or so, so this PR is already outdated. My point is that the Python packaging world is still evolving a lot and I don't want to spend time on packaging until it's settled on something more stable. I know you don't want to hear this but I feel that setup.py is still is the defacto standard, and I don't want to be the one smoothing out the rough edges. I'll consider this again in a year or two. :)


Still a WIP...

hoping to get loading the zipped files to go faster, haven't tested the shiny app in a few days.

OK, not so much WIP anymore.
Fixes #64


Setup and building on macos with visual studio code

I'm currently setting up this project and thought it may be useful for future users to document my setup process. I'm using MacOS and Visual Studio Code.

Install the JDK from here (https://www.oracle.com/technetwork/java/javase/downloads/jdk11-downloads-5066655.html)
Install java8 with homebrew: brew cask install homebrew/cask-versions/java8
Install gradle 2.14 with homebrew: brew install<EMAIL_ADDRESS>

Note: newer versions of gradle may not work

Open the delverengine folder in Code
Open the terminal in Code and run sh build.sh to build

You can now run Delver by navigating to the DungeoneerDesktop/ directory and running gradle run

Should this info live in the wiki? I can see documenting various dev setups being useful.

tasks.json for vs code, tasks for building, and running both editor and game.
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "build",
            "type": "shell",
            "command": "sh build.sh",
            "problemMatcher": [],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        },
        {
            "label": "run game",
            "type": "shell",
            "command": "gradle",
            "args": ["run"],
            "group": {
                "kind": "test",
                "isDefault": true
            },
            "options": {"cwd" : "DungeoneerDesktop"}
        },
        {
            "label": "run editor",
            "type": "shell",
            "command": "gradle",
            "args": ["run"],
            "group": {
                "kind": "test",
                "isDefault": true
            },
            "options": {"cwd" : "DelvEdit"}
        }
    ]
}

@joshuaskelly Yeah I'd be happy to add this if/when the wiki gets started

I've added basic build instructions to the wiki (thanks for the help):
https://github.com/Interrupt/delverengine/wiki/Build-Instructions
We can add sub-pages for specific build environments. Depends on what folks feel up to doing. :)

@jmickle66666666 Hey, just wondering - could you also set up the debugger in VS Code? I have some issues with that. And I'm using that Java extension by RedHat.

Nevermind. Got it working with #74.


Error thrown with invalid byte for encoding in router model

Laravel Version: 5.3.30
PHP Version: 7.1.0
Database Driver & Version: Postgres

Description:
I have the following error : SQLSTATE[22021]: Character not in repertoire: 7 ERROR:  invalid byte sequence for encoding "UTF8": 0xab (SQL: select * from "pages" where "slug" = ? and "pages"."deleted_at" is null limit 1)
Steps To Reproduce:

Make a router model for slug database field
Test URL like this : www.example.com/�

I know, there is not really an issue but only an exception on invalid byte in a specific encoding. Maybe check the encoding before query the db or catch the exact error code from DB and throw the NotFound exception can fix this issue ? Have you got any other way to do that ?

Closing for lack of activity.

The issue still not fixed.
Le 18 mai 2017 2:35 PM, "Mohamed Said"<EMAIL_ADDRESS>a écrit :

Closing for lack of activity.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/17822#issuecomment-302390710,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACoyNhg9LdtebRcQBTRdyny1SVRuBtG3ks5r7DsYgaJpZM4L6uit
.


Browserify 8

Another day another version :)

Cannot merge yet, watchify still requires browserify ^7.0.0.

Cannot merge yet, watchify still requires browserify ^7.0.0.

Never mind, everything seems to be a.o.k.

Never mind, everything seems to be a.o.k.


Failure to apply a new cluster

I had a cluster running.
It became overloaded and the single agent instance became unresponsive to kubectl commands.
In addition, the load balancer disappeared from Hetzner CP
I manual destroyed all modules
rechecked out this repo
copied over my terraform.tfvars
scaled up to two agent servers
re ran init and apply
Now I get this error every apply I make:
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-1"].hcloud_server.server: Creation complete after 3m56s [id=18846796]
module.agents["agent-large-1"].hcloud_server_network.server: Creating...
module.agents["agent-large-1"].hcloud_server_network.server: Creation complete after 1s [id=18846796-1471925]
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:170
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4195
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:153
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4185
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:171
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4196
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:158
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4186
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:168
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4193
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:149
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4126
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:169
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4187
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:154
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4188
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:155
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4189
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:157
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4191
null_resource.first_control_plane (remote-exec): Found conflicting filecon rules
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/400/k3s/cil:156
null_resource.first_control_plane (remote-exec):   at /var/lib/selinux/targeted/tmp/modules/200/container/cil:4190
null_resource.first_control_plane (remote-exec): Problems processing filecon rules
null_resource.first_control_plane (remote-exec): Failed post db handling
null_resource.first_control_plane (remote-exec): Post process failed
module.agents["agent-large-0"].hcloud_server.server: Still creating... [4m0s elapsed]
null_resource.first_control_plane (remote-exec): /sbin/semodule:  Failed!
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-0"].hcloud_server.server: Still creating... [4m10s elapsed]
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-0"].hcloud_server.server (local-exec): Waiting for MicroOS to reboot and become available...
module.agents["agent-large-0"].hcloud_server.server: Creation complete after 4m18s [id=18846791]
module.agents["agent-large-0"].hcloud_server_network.server: Creating...
module.agents["agent-large-0"].hcloud_server_network.server: Creation complete after 2s [id=18846791-1471925]
╷
│ Error: remote-exec provisioner error
│
│   with null_resource.first_control_plane,
│   on init.tf line 28, in resource "null_resource" "first_control_plane":
│   28:   provisioner "remote-exec" {
│
│ error executing "/tmp/terraform_846799582.sh": Process exited with status 1
╵

I should add I've tried to deploy with both master branch and the 0.1.0 tag

With the current master, you could create another cluster in the same project, and slowly but surely drain the nodes, ssh into the nodes, change the /etc/rancher/k3s/config.yaml file to point to the old control plane node, also manually join it to the "old" network. basically let it "absorb" your current cluster on the new nodes, then drain the old ones, and reconnect to the new network... etc. It's hacky, involves manually back and forth, but theoretically, it should work!

@mysticaltech Shall I close this issue, given I found a solution that suited me or does anyone want to investigate further? I can try and replicate it again with a new cluster and provide more detailed logs if required.

Thanks for the info BTW!

Yes, my pleasure! Closing it.

Hello, I also encountered the same issue with k3s-selinux (it was working the previous day).
Some info from working nodes
working-node $ zypper info k3s-selinux
Loading repository data...
Reading installed packages...

Information for package k3s-selinux:
------------------------------------
Repository     : openSUSE-Tumbleweed-Oss
Name           : k3s-selinux
Version        : 1.1.stable.1-1.1
Arch           : noarch
Vendor         : openSUSE
Installed Size : 95.6 KiB
Installed      : Yes
Status         : out-of-date (version 0.5.latest.1-1.1 installed)
Source package : k3s-selinux-1.1.stable.1-1.1.src

working-node $ zypper search -s k3s-selinux
Loading repository data...
Reading installed packages...

S  | Name        | Type    | Version          | Arch   | Repository
---+-------------+---------+------------------+--------+------------------------
i+ | k3s-selinux | package | 0.5.latest.1-1.1 | noarch | (System Packages)
v  | k3s-selinux | package | 1.1.stable.1-1.1 | noarch | openSUSE-Tumbleweed-Oss

and from the failing node
failing-node $ zypper info k3s-selinux
Loading repository data...
Reading installed packages...

Information for package k3s-selinux:
------------------------------------
Repository     : openSUSE-Tumbleweed-Oss
Name           : k3s-selinux
Version        : 1.1.stable.1-1.1
Arch           : noarch
Vendor         : openSUSE
Installed Size : 95.6 KiB
Installed      : Yes
Status         : up-to-date
Source package : k3s-selinux-1.1.stable.1-1.1.src

failing-node $ zypper search -s k3s-selinux
Loading repository data...
Reading installed packages...

S  | Name        | Type    | Version          | Arch   | Repository
---+-------------+---------+------------------+--------+------------------------
i+ | k3s-selinux | package | 1.1.stable.1-1.1 | noarch | openSUSE-Tumbleweed-Oss

The source is from master branch. Thank You.

Ah, seems like installing the pinned version will will fix the issue
file: modules/host/main.tf
Before
provisioner "remote-exec" {
  inline = [
    "set -ex",
    "transactional-update pkg install -y k3s-selinux"
  ]
}

After
provisioner "remote-exec" {
  inline = [
    "set -ex",
    "transactional-update shell <<< 'rpm --import https://rpm.rancher.io/public.key;zypper install -y https://github.com/k3s-io/k3s-selinux/releases/download/v0.5.stable.1/k3s-selinux-0.5-1.sle.noarch.rpm'"
  ]
}

ps: version+gpg url still hardcoded 🙈 . seems like this will fix https://github.com/kube-hetzner/kube-hetzner/issues/134 as well

That indeed worked for #134, thank you!

Thanks @jodhi, please quick PR 🙏

Thanks, @jodhi, applied your fix 🙏

Hi, I'm unfortunately not that experienced with terraform. I pulled the newest version but I'm still encountering that issue from above:
│ Error: remote-exec provisioner error │  │   with null_resource.control_planes[0], │   on control_planes.tf line 68, in resource "null_resource" "control_planes": │   68:   provisioner "remote-exec" { │  │ error executing "/tmp/terraform_1373315807.sh": Process exited with status 124
Is there something I'm missing out on? Thanks for the help 😃

@hycmedia Delete everything and just follow that tutorial https://www.youtube.com/watch?v=jwtrEcgzQBs


[ENHANCEMENT] Only show or visualize major updates based on semver

Please confirm these before moving forward

[X] I have searched for my feature proposal and not found a work-in-progress/duplicate/resolved/discarded issue.
[X] This improvements refers to an existing feature. If you want to suggest a new feature, please use this template
[X] This improvements is not a bug. If you want to report a bug, please use this template

Describe the improvement
Currently all updates are shown. Lot of package managers however allow to only show major update or resp. show them visually different if the version is a minor or major upgrade.
e.g. show 6.0.1 -> 7.2.4 in red but 6.0.1 -> 6.2.1 in white.

Describe how this improvement could help users.
the reason behind this is that i have a lot of updates and don't necessarly want to update all of them esp. as some software already has updated itself via some internal auto updated. so i only want to get notified about major updates.

i found a similar issue i think ;) https://github.com/marticliment/WingetUI/issues/1110

in order to "parse" the version one could either use semver libraries or have a look how this lib is doing it:
https://github.com/dylang/npm-check
https://cloud.githubusercontent.com/assets/51505/9569917/96947fea-4f48-11e5-9783-2d78077256f2.png

They are related, but not actually the same

Actually, I would like to be able to configure the according behavior per package. Here's an example: On my machine, I have installed Python 2 for some reason. Now, WingetUI keeps suggesting to update this to Python 3, which is not an option for me. If I now would be able to tell WingetUI that for this package, I only want minor updates to be offered, then I would not have to ignore the Python package (which I have to do now because I don't want to accidentally upgrade to Python 3).

It would be nice to have two options to configure:

semver pattern to show
semver pattern to autoupgrade


 We will add the instructions in the follow up PR since we want to have version control on this initial code commit.

Modified api docker build to use go modules
Moved all the Argo specific API to Tekton specific API (Still need to implement it with polymorphism or abstracted function as the ideal solution)
go.mod is updated to match with the Tekton dependencies.
go.sum is updated for dependency version control.
Commented out Argo specific tests to skip type check errors.

The Travis test is for the python SDK and it's funky since it sometimes passes the tests.
/retest

/approve


QIR: Consider avoiding variadic functions in the runtime

As far as I can tell, there is no platform-agnostic way to implement variadic functions at the IR level and it's also error-prone, which creates a burden on the runtime implementers.
Instead of requiring:
%Array* __quantum__rt__array_create(i32, i32, ...)
i8* __quantum__rt__array_get_element_ptr(%Array*, ...)

consider similar to 1D specialization for 2D arrays (the arguments will be still passed via registers) and a generic buffer-based signature for larger arrays:
%Array* __quantum__rt__array_create_2d(i32, i64, i64)
i8* __quantum__rt__array_get_element_ptr_2d(%Array*, i64, i64)
%Array* __quantum__rt__array_create(i32, i32 %buffer_length, i64* %buffer)
i8* __quantum__rt__array_get_element_ptr(%Array*, i32 %buffer_length, i64* %buffer)

Notes:

even though the buffer size should match dimensionality of the array, it makes the signatures more consistent/safe to provide it explicitly in array_get_element_ptr;
for the size-specific functions a 3d one will also still fit into registers (in the common C calling conventions)

LLVM does specify a way to do this using intrinsics, but I agree, it's awkward in C/C++. Unfortunately the i64* approach is also awkward on the LLVM side; I think the idea of adding 2d specialized versions ameliorates that, because I suspect that manipulating arrays of more than 2 dimensions will be rare.

LLVM does specify a way to do this using intrinsics

This is the intrinsics I'm using in the bridge (https://github.com/microsoft/qsharp-runtime/blob/main/src/QirRuntime/lib/QIR/bridge-rt.ll) and am still having issues on Linux. Is it possible that different platforms must set up differently for the call? If so, we still have cross-platform compatibility issue.

LLVM does specify a way to do this using intrinsics

This is the intrinsics I'm using in the bridge (https://github.com/microsoft/qsharp-runtime/blob/main/src/QirRuntime/lib/QIR/bridge-rt.ll) and am still having issues on Linux. Is it possible that different platforms must set up differently for the call? If so, we still have cross-platform compatibility issue.

Agreed. In the PR (#55) I went with your suggestion.


New Command - Invoke-DbaSqlCmd

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[x] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
This PR tries to introduce a new command that allows executing sql commands against instances, but also behaves consistently to how our other commands handle.
Approach
Rather than reinventing the wheel, this is a wrapper around Invoke-Sqlcmd2, allowing us to keep updating it from source without having to reapply changes or
Example
Get-DbaRegisteredServer -SqlInstance sql2014 | Invoke-DbaSqlcmd -Query 'SELECT 1 AS foo'

Breaking Change
This change is a major breaking change. We may want to make an announcement that the old alias is being replaced and may break code before putting this into a release.

test comment for slack integration test

thanks fred! I'll make a test for this soon


adding docstrings to all functions

Adding docstrings to all the functions
Fixes #3

LGTM, thank you!


Failed Foundry installation on OSX catalina

Component
Foundryup
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
foundryup
Operating System
macOS (Intel)
Describe the bug
On OSX Catalina 10.15.2. Let me know if you need more info than this screenshot

Upgrading to Sonoma 14.4 this this


Start storage pool if volume was not found

libvirt storage pools are not necessarily started by the time you call terraform plan.
In case they are not, you get this slightly misleading error:
Error refreshing state: 1 error(s) occurred:

* libvirt_volume.data_disk: Can't retrieve volume <STORAGE_PATH>/<VOLUME_NAME>

Fact that volume can't be retrieved is just because the pool has not been started yet.
Currently you would have to connect to the libvirt host via virt-manager or virsh, lookup the correct pool name and start it.
With this patch the provider will attempt to do that automatically, which improves UI/UX.

The code LGTM. I would have preferred to have the new code wrapped up into a dedicated function, but that's something we can do later one once we do a refactoring of the whole project.


Add ProtoGenesis

I tested this in a sandbox that starts with ProtoGenesis, injects Carthage and then bakes a few Blocks,
Initailly i got this error:
Unknown protocol: ProtoGenesisGenesisGenesisGenesisGenesisGenesk612im

just adding the Protocol to the symlins in protocols.go fixes this, however then i got the following error:
2020/05/18 21:14:15 [Info] [tplusnet] Creating indexer object...
2020/05/18 21:14:15 [Info] Elasticsearch Server: 7.5.1
2020/05/18 21:14:15 [Info] [tplusnet] Current indexer state: 5
2020/05/18 21:14:15 [Info] [tplusnet] Current network protocol: PsCARTHAGazKbHtnKfLzQg3kms52kSRpgnDY982a9oYsSXRLQEb
2020/05/18 21:14:15 [Info] [tplusnet] Getting network constants...
2020/05/18 21:14:15 [Info] [tplusnet] Data will be updated every 0 seconds
2020/05/18 21:14:15 [Info] [tplusnet] Current node state: 5
2020/05/18 21:14:15 [Info] [tplusnet] Current indexer state: 5
2020/05/18 21:14:15 [Error] Same level
panic: non-positive interval for NewTicker

goroutine 50 [running]:
time.NewTicker(0x0, 0xc00041a7c0)
        /home/johann/go/go1.14.1/src/time/tick.go:23 +0x147
github.com/baking-bad/bcdhub/cmd/indexer/indexer.(*BoostIndexer).Sync(0xc00040a160, 0xc000094020, 0x0, 0x0)
        /home/johann/Projects/bakingbad/bcdhub/cmd/indexer/indexer/boost.go:180 +0x117
created by main.main
        /home/johann/Projects/bakingbad/bcdhub/cmd/indexer/main.go:49 +0x2f1
exit status 2

second commit adds a check for this

small comment: before the fix, when it threw this panic the interval was 0s


I can´t using it in pay Google Colab and ngrok token

It shows this:
Traceback (most recent call last):
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 28, in
from modules import extra_networks, ui_extra_networks_checkpoints
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/ui_extra_networks_checkpoints.py", line 5, in
from modules import shared, ui_extra_networks, sd_models
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/shared.py", line 665, in
opts.load(config_filename)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/shared.py", line 602, in load
self.data = json.load(file)
File "/usr/lib/python3.10/json/init.py", line 293, in load
return loads(fp.read(),
File "/usr/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

You have to delete the SD folder and start from the beginning. I know it's annoying because you have to reload your models and everything, but it's the only way. I waited for days for it to be fixed, and it wasn't until today when I deleted everything that it got resolved.

You have to delete the SD folder and start from the beginning. I know it's annoying because you have to reload your models and everything, but it's the only way. I waited for days for it to be fixed, and it wasn't until today when I deleted everything that it got resolved.

hello, I already did that but almost same problem:
Calculating sha256 for /content/gdrive/MyDrive/sd/stable-diffusion-webui/models/Stable-diffusion/model.ckpt: 43c90409bd4493ea9f4734a166fc6180913f97cef4f69a2b7883edf700779693
Loading weights [43c90409bd] from /content/gdrive/MyDrive/sd/stable-diffusion-webui/models/Stable-diffusion/model.ckpt
Creating model from config: /content/gdrive/MyDrive/sd/stablediffusion/configs/stable-diffusion/v2-inference-v.yaml
LatentDiffusion: Running in v-prediction mode
DiffusionWrapper has 865.91 M params.
Applying scaled dot product cross attention optimization.
Textual inversion embeddings loaded(0):
Model loaded in 56.5s (calculate hash: 11.4s, load weights from disk: 35.1s, find config: 4.4s, create model: 0.3s, apply weights to model: 2.7s, apply half(): 1.6s, move model to device: 1.1s).
Traceback (most recent call last):
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 337, in
webui()
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 240, in webui
shared.demo = modules.ui.create_ui();shared.demo.queue(concurrency_count=999999,status_update_rate=0.1)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/ui.py", line 461, in create_ui
txt2img_prompt, txt2img_prompt_styles, txt2img_negative_prompt, submit, _, _, txt2img_prompt_style_apply, txt2img_save_style, txt2img_paste, extra_networks_button, token_counter, token_button, negative_token_counter, negative_token_button = create_toprow(is_img2img=False)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/ui.py", line 284, in create_toprow
with gr.Row(elem_id=f"{id_part}_toprow", variant="compact"):
File "/usr/local/lib/python3.10/dist-packages/gradio/layouts.py", line 44, in init
super().init(visible=visible, elem_id=elem_id, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 274, in init
super().init(visible=visible, render=render, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 79, in init
self.render()
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 94, in render
if isinstance(self, components.TempFileManager):
AttributeError: module 'gradio.components' has no attribute 'TempFileManager'


analyze segfaults on the Tiger install DVD

% impluse-hfs analyze /dev/disk36s3
Space where Driver Descriptor Block might've been is empty; could still be an Apple Partition Map
Space where partition map entry should be is not an Apple Partition Map entry
Found HFS+ volume
Catalog file logical length: 0x600000 bytes (6.3 MB)
Catalog extent #0: start block #1,089, length 1,536 blocks
Extents overflow file logical length: 0x400000 bytes (4.2 MB)
Extents overflow extent #0: start block #65, length 1,024 blocks
*READING*: Volume start:	0x0
zsh: segmentation fault   analyze /dev/disk36s3

Doesn't fare any better analyzing disk36 and getting to s3 via the partition map.

list also fails.

… Apparently I had a stale build of something broken than what's actually in the current source somehow? I hit ⌘R in Xcode and it worked fine. And then running it from Terminal worked fine as well.


Open recent file option

I would like to see an "Open recent file" (within folder/project).
I got used to use the Git tab for this, but just until commit, after commit, I'm sold.
After commit and close all opened files, if I need to make a quick fix, I got remember the files I was messing with. If we had an "Open recent file" or "Recent Activity" that would be very handy.

There is File > Open Recent. Does that not address your case?

"File > Open Recent" opens a project folder. I was thinking more like an "Open Recent Tab". Something like browsers reopen recent closed tab feature, so I can reopen recently edited files.
The git tab kind of give me this, the recent edited files, but after commit, it's gone, so a more permanent menu under File, that tracks the last opened/edited files inside a project folder would be awesome.

The list includes recent files outside of any opened folder, but not recent files within an opened folder. We'll track this as a feature request for that. Thanks.

@EthraZa there is File > Open Recent > Reopen Closed Editor to restore one by one and then there is the global history of editors every opened which might come in more handy for you (Cmd+P):

I believe this should cover that request, closing.


ImageNet training results

Thank you for sharing your work. Could you also provide the evaluation results from the ImageNet training?

Hi! ImageNet pre-training was mostly done by a colleague of mine. However, I remember that we used this repo.
And I also found some old logs with some results:
MN10: 'top_1': 0.7186, 'top_5': 0.9076
DyMN10: 'top_1': 0.7320, 'top_5': 0.9119
However, these results might not exactly match the checkpoints uploaded to this repo. But the results should be somewhat similar if you need them for a sanity check.

Thanks for the quick reply.


ValueTracker must support increment also using +=

Just what the title says. Here's an example
class Test(Scene):
    def construct(self):
        tracker = ValueTracker(0.0)
        tracker.set_value(2.0)
        print(tracker.get_value()) # -> 2.000
        tracker.increment_value(3.0)
        print(tracker.get_value()) # -> 5.000
        tracker += 4.0 # NEW proposed feature
        print(tracker.get_value()) # -> 9.000

Very good idea. I would love to see a PR :) #

Hey, @huguesdevimeux I can take this if it's still open.

Hi @SamMinkowicz,
We all appreciate your willingness to help the Manim Community out, but unfortunately I already started working on it and just opened a PR a minute ago before seeing your comment. You can still help us out by maybe giving suggestions on that PR :)

@naveen521kk Please please assign yourself when you're working on an issue.

Yeah @huguesdevimeux , I forgot, my bad. Will keep it in mind now.

@naveen521kk Please please assign yourself when you're working on an issue

I'm not working on this. I think you have pinged me wrongly.


Issue with user_agent error when creating a CohereReRank object in LangChain

System Info
last version of langchain and cohere
Who can help?
@@agola11
I am encountering an error related to the user_agent when attempting to create a CohererRank object in the LangChain p. I have verified that I am passing a valid cohere_api_key and can successfully use the rerank function from Cohere directly. However, when trying to utilize it through the LangChain project, I encounter this specific issue related to the user_agent.
/usr/local/lib/python3.10/dist-packages/langchain/retrievers/document_compressors/cohere_rerank.py in validate_environment(cls, values)
53             values, "cohere_api_key", "COHERE_API_KEY"
54         )
---> 55         client_name = values["user_agent"]
56         values["client"] = cohere.Client(cohere_api_key, client_name=client_name)
57         return values
KeyError: 'user_agent'
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
import os
import getpass
os.environ["COHERE_API_KEY"] = getpass.getpass("Cohere API Key:")
from langchain.llms import OpenAI
from langchain.retrievers import ContextualCompressionRetriever
from langchain.retrievers.document_compressors import CohereRerank
compressor = CohereRerank()
Expected behavior
i want to create an object of CohereReRank.

Please close. This is a duplicate of https://github.com/langchain-ai/langchain/issues/12899


Ublock makes it crash

Hello,
when Ublock is on Iron router crashes. I am on version 2.0.0 is there any fix ?
Thanks

@Antoine-O We cannot reproduce this issue. When uBlock is enabled the plugin will be blocked from sending analytics data. But iron-router is not crashing.
Could you provide a minimal working reproduction of the bug for us to take a look at?

We will close this issue for now until we can reproduce it.

@Antoine-O I think your issue may be because you aren't using the --production tag when running meteor. You need to use this for the analytics plugin to work correctly.

^ https://github.com/okgrow/analytics#ad-blocker

Go on beta.quickcontest.com with ublock enabled it will certainly crash
Le sam. 29 oct. 2016 00:13, Aryan Goharzad<EMAIL_ADDRESS>a
écrit :

^ https://github.com/okgrow/analytics#ad-blocker
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/okgrow/analytics/issues/138#issuecomment-257041421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJBBLZBXxehqQBO5IOCAUz-Xf9PA8Lp8ks5q4nNzgaJpZM4KVHk7
.

I am.using a docker image abd i am not using meteor directly as it is 'exported' as a nide.js application. This may cause the problem ?

Fyi i am using https://github.com/CyCoreSystems/docker-meteor

@Antoine-O The issue is that your code is not minified in the production deployment on the website you linked above. If you look inside the resources you can see all the individual files, this includes the name of the files. UBlock will block any files with the word analytics in the name and that is what is causing the crash. The --production tag minifies / bundles the codebase and fixes this issue. I'm not sure why the files aren't minified in production but this must be something to do with Docker. You need to change your production environment to bundle the code, this will probably be something in Docker that you need to configure.

you nailed it! I don't know why but "minified" packages were removed from the project :'(.
I'll give a try and close the issue if it is ok !


Double length of time for HTCondor integration test to detect job queue

Submission Checklist

[x] Have you installed and run this change against pre-commit? (pre-commit install)
[x] Are all tests passing? (make tests)
[x] Have you written unit tests to cover this change?
[ ] Is unit test coverage still above 80%?
[x] Have you updated all applicable documentation?
[x] Have you followed the guidelines in our Contributing document?

The SCHEDD_INTERVAL we configure is 30s (well below the default of 300s) which is only giving the current 6*10=60s roughly 2 intervals of time for the SCHEDD to advertise itself to the collector. This PR doubles that time.


Troubles with override of internal properties

The behaviour in my game was strange, after checking the IL code it seems like the virtual get property name was "e" while the override get property was "H".

This happened with the 2.23 packaged on nuget (2.10 depicted the same behaviour). Using the source-code i get an exception as the new version seems to have problems with colliding names during post-processing phase.

Peeking inside the source code it seems like the names of nested types were colliding with the names of generated types, at least in the post-processing phase with the nuget code.


Makefile fixes

Fixes to keep .o files out of the src folder. Also contains changes for efficiency, cleanliness, and clarity.

Fascinating. GitHub shows the above commits ordered by date, rather than commit order. I used rebase to get a more logical flow, with no broken intermediate steps, and related changes squashed together. It resulted in out of order commit dates, and shows an impossible ordering of changes above. Everything looks fine and logical in git log.


Proguard settings

Can you please share your proguard settings for this package ? I've just installed it and it does not build when proguard is on.
Thank you.

@xtrecoolx proguard settings for

Branch-3.0.3_core.jar

no settings

BranchAndroidWrapper.jar

proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
proguard-rules.pro is empty

@antonargunov I am sorry I did not quite get it. I mean what should I type in the settings text file.
Maybe something like:
# Keep all classes in Unity Services package -keep class com.unity3d.services.** {    *; }

@xtrecoolx how did you enable proguard?

Well in my Unity game I have proguard enabled at the build settings. I wanted to integrate Branch.io SDK for deep links but the build fails due to proguard. The proguard settings are enabled at the player settings in Unity if that's what you are looking for and it reads proguard-user.txt file for settings.

ok, understood, let me check

@xtrecoolx I enabled proguard in our testbed, all works.

it does not build when proguard is on.

does it build when proguard is off?
can you send me error log?
which version of Unity3d do you use?
can you reproduce this in empty project + Branch SDK?

@antonargunov Here are my answers:

Well I did try to build it without proguard and it failed. It looks like its conflicting with Firebase SDK.
I get errors like:

UnityEditor.BuildPlayerWindow+BuildMethodException: 2 errors Execution failed for task ':transformDexArchiveWithExternalLibsDexMergerForRelease'.
/mygame/Temp/gradleOut/libs/Branch-3.0.3_core.jar: D8: Type com.google.firebase.appindexing.FirebaseUserActionswas not found, it is required for default or static interface methods desugaring ofvoid io.branch.indexing.AppIndexingHelper$1.run()``

I am running Unity 2018.3.0f2 on MacOS. The project contains Facebook SDK, Firebase SDK (Firebase Auth, Analytics, DynamicLinks, Storage, Messaging), Admob and Admob Mediation SDKs.

I also see errors such as
Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.Thing Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.Thing$Builder Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.Action Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.Action$Builder Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.AppIndex Note: io.branch.indexing.AppIndexingHelper: can't find dynamically referenced class com.google.android.gms.appindexing.AppIndexApi

@xtrecoolx try to add in plugins/android folder this .arr file:
https://mvnrepository.com/artifact/com.google.firebase/firebase-appindexing/17.1.0

@xtrecoolx Are you still experiencing this issue?

Due to the age and inactivity of this issue, I am closing this now. If you are encountering this problem still, please reach out to our support team (support.branch.io) or open a new github issue and we would be happy to help you out!


Fix a few other travis complains

https://travis-ci.org/CreaturePhil/Showdown-Boilerplate/

@CreaturePhil check this


Delete Topic when Model is removed

Traffic Control will delete the topic on deleteModel event.

needs master merging in

Should probably use a logical deletion flag in the model. This is because kafka-store (or the model client) has known issues where it shows partial or empty state. If deleting happens when the model is gone, this could lead to a lot of real roads being deleted in cases where kafka-store goes stale.
I suggest using a delete flag in the road model, and if delete = true the agent can safely go ahead with the road deletion.


Remove telemetry from ansible

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix

/kind cleanup

/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Remove the deprecated Telemetry service installation and uninstallation from the SODA installer
Which issue(s) this PR fixes:

Fixes  sodafoundation/documentation#118
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED

/kind NOT-TESTED
Test Report:

Special notes for your reviewer:
SODACODE 2022

@UtkarshShah0 PTAL. The CI is failing. The telemetry installation files have variables that are referenced in other files. You will have to remove all the references to telemetry files and the variables used.

Ok, I will give it a shot.


Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

ec-tasks is failing because the image used by EC is gone... This should fix it: https://github.com/redhat-appstudio/infra-deployments/pull/3282

/retest

I think it was because the other PRs were from branches that were behind. That's my guess anyways.


python3Packages.textnets: 0.8.8 -> 0.9.3

Description of changes
Changelog: https://textnets.readthedocs.io/en/stable/history.html
This version depends on pandas 2.0, so we will have to wait for #225662 before we can merge this. It also depends on spacy-lookups-data so we also have to wait for #242842.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build python310Packages.textnets

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2602


Multiuse invitations and Qualified DIDs

Affected versions: 0.12.1, 1.0.0rc4, nightly-2024-07-19
There seems to be an issue in determining the correct inbound connection when using multi-use invitations and didexchange 1.1 with qualified DIDs.
Reproducible example can be found here: https://github.com/Indicio-tech/acapy-minimal-example/blob/test/multiuse-oob/examples/multiuse-oob/example.py
Small amount of context: ACA-Py uses a connection record to represent multi-use invitations.
If a connection is made with a multi-use invitation and then a message is sent to the resulting connection, the response to that message will be handled as though it had been sent by the multi-use invitation connection. In the example, this is demonstrated by sending a feature discovery message; ACA-Py's handler for the disclose message checks the connection_ready condition on the context and finds it as false, which is accurate because the multi-use invitation conn record is still in state invitation. The connection record as extracted from the logs of the call to the DiscloseHandler:
ConnRecord
(_id='1cd87e77-9a4a-49c7-93d0-3d972a0f1849', _last_state='invitation', _new_with_id=False, state='invitation', created_at='2024-07-19T16:27:10.277265Z', updated_at='2024-07-19T16:27:10.27726
5Z', my_did=None, their_did=None, their_label=None, their_role='invitee', invitation_key='De2YsJc9m3Lr9XeErdbjjMCSGFk9YwRBmw9V8q1Md3nd', invitation_msg_id='d39fca16-eaaa-40e7-b447-b56d8c085d
12', request_id=None, error_msg=None, inbound_connection_id=None, accept='manual', invitation_mode='multi', alias=None, their_public_did=None, connection_protocol='didexchange/1.1')

In the minimum example you posted it's using the discovery v1 protocol. I did just add the connection_ready check on this handler. So this might be why this test started failing.
However, I made some observations. I'm not very confident about my knowledge in some of these areas.

I can replicate this with the discovery v2 protocol which already had the connection_ready check. So, I think the problem already existed. Adding the check to the discovery v1 protocol just allowed this to get caught by your test.
I don't see a difference between unqualified vs. qualified did's. Both seem to behave the same.
Only the did-exchange/1.1 protocol has this issue. did-exchange/1.0 passes the connection_ready check with both discovery protocols.
Oddly, If I restart the agent which created the multi-use invitation, then the connection is now in a connection_ready state and the discovery protocols succeed without issue.

Not sure if this helps at all? Seems like there's definitely an existing issue with the connection_ready status and multi-use invitations that already existed, and adding this check recently got it caught by this test.

This lines up with what I was finding on Friday, thanks for your additional observations! I think I've narrowed down what's going on. In didex 1.1 when using did:peer:4, we shorten the DID to its short form in a few spots, particularly in inbound connection resolution in the base connection manager. However, the DID stored on the connection record isn't shortened until response/complete phase. So when we are receiving a connection complete response, we fail to look up the connection record by DID and instead it falls through and gets looked up by invitation message ID (parent thread ID) and we end up with the connection record for the multiuse invitation.


Popper init folder

Hi,
I just read the "Popper Convention" paper and wanted to see what is under the hood. Nice work! I plan on using it for my next papers. In the meanwhile, here are some patches.
Regards,
Cristian

thanks a lot for these patches! Looking forward to getting your feedback on how we can improve popper.


Send logging messages to console also for Code Engine LogDNA

Currently, logging messages for cfc_app and users are only directed to files.  This is convenient for local testing, but makes it difficult to debug when running on Code engine.  Add "console" to handlers.

Updated settings.py to add LOGHANDLE constant that will allow either ['console', 'file'] or just ['file'] as needed.
(Legit-Info) [Yoga Legit-Info]$ ./stage1
Using SQLite3
Using SQLite3
Watching for file changes with StatReloader
05-26 19:40:34 autoreload:run_with_reloader [INFO] Watching for file changes with StatReloader
Performing system checks...
System check identified no issues (0 silenced).
May 26, 2021 - 19:40:34
Django version 3.1.6, using settings 'cfc_project.settings'
Starting development server at http://localhost:3000/
Quit the server with CONTROL-C.
05-26 19:40:48 views:index [INFO] 195: username=
[26/May/2021 19:40:48] "GET / HTTP/1.1" 200 3924
[26/May/2021 19:40:49] "GET /static/favicon/favicon.ico HTTP/1.1" 200 1150
[26/May/2021 19:40:49] "GET /static/favicon/favicon.ico HTTP/1.1" 304 0
[26/May/2021 19:40:55] "GET /users/login/ HTTP/1.1" 200 3538
[26/May/2021 19:41:03] "POST /users/login/ HTTP/1.1" 302 0
05-26 19:41:03 views:index [INFO] 195: username=cfcadmin
[26/May/2021 19:41:03] "GET / HTTP/1.1" 200 3836