async_generator: not available for python35

Issue description
The derivation python35Packages.async_generator is available but cannot be built. I get the following error :
No matching distribution found for async-generator>=1.3; python_version == "3.5" (from pytest-asyncio==0.9.0)

I get the original package to work in a nix-shell with the following derivation:
with python35Packages;

...

  async_generator = buildPythonPackage rec {
    pname = "async_generator";
    version = "1.10";
    name = "${pname}-${version}";
    src =  fetchPypi {
        inherit pname version;
        sha256 = "6ebb3d106c12920aaae42ccb6f787ef5eefdcdd166ea3d628fa8476abe712144";
    };
    doCheck = false;
    prePatch = "touch README.rst";
  };

...

Steps to reproduce
nix run nixpkgs.python35Packages.async_generator

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.69, NixOS, 18.09beta302.9fa6a261fb2 (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1.1`
 - channels(etienne): `""`
 - channels(root): `"nixos-18.09.1228.a4c4cbb613c, nixpkgs-19.03pre158005.32340793aaf"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I commented in the PR to address this issue. It is due to a circular dependency that pytest-asyncio and async_generator have on each other for testing. You may run into more similar issues since python 35 it not heavily tested in the community right now. If you can use 36 or 37. 37 will be the default soon.

Thanks!


Mistral provider support for URL and API key envar

Fixes #567
This adds support for overriding the default URL and api key environment variable in the Mistral provider. I just duplicated the existing OpenAPI behavior.

Great change!  Thanks @jvert


Structured Logging for Operator

Can the operator be configured such that it logs in a structured (JSON) format?

Good question. We're trying to set this up too.


Vk pixel history: support various texture formats

Just realized there is a problem here where ConvertComponent does not handle A component in B8G8R8A8 correctly. I am going to fix that.

So, as far as I understand, the A component should not be processed with the SRGB lookup table, but with my current code it would be because compType is UNormSRGB.
Am I missing something?

I think I fixed it for pixel history use of ConvertComponent, but I do wonder if it should be fixed for general case inside ConvertComponent. I think it would need an extra parameter to figure out which component it is though.
Let me know if I am missing something though, I am less familiar with that code.

Ah yes you're definitely right, I just didn't realise what you meant originally.
Indeed this should be fixed everywhere. Looking at it, currently ConvertComponent is always called in a loop over compCount, so I think it'd be better to change the function to return a FloatVector and convert all components at once. Either you or I can do that in a follow-up though, this is fine to merge as-is once CI is green.


Sending notifications through an externally executed scheduled task

Product-IS need to have a recommend a way for sending notifications to users as discussed in mail thread [1] through an externally executed scheduled task.
For example, the following features may necessitate sending notifications to users within the organization:

Password expiry feature [1]: Sending notifications to users whose passwords have expired.
Idle account identification [2]: Sending notifications to users who have been inactive for a specified duration.

[1]. https://github.com/wso2-enterprise/iam-engineering/issues/647
[2]. https://github.com/wso2-enterprise/iam-engineering/issues/650

The API capability for below tasks are already in the product-is 7.0.

API to get password expired users.
API to get users whose account is idle for configured time.

We need to provide a sample/documentation for the integration with the Azure scheduler for this requirement.


Document new option of OpenMetrics-based integrations

What does this PR do?
Documents the new use_process_start_time option of OpenMetrics-based integrations and adds it to config models.
Motivation
See https://github.com/DataDog/integrations-core/pull/10463
Additional Notes
This PR is a split from https://github.com/DataDog/integrations-core/pull/10463, only including the config model/example yaml changes of that PR to avoid CI timeouts. Completes https://github.com/DataDog/integrations-core/pull/10589 which only included the base check code changes.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Hi 👋 , looks like some of the config is out of sync. Can you run ddev validate models azure_iot_edge -s and ddev validate models cilium -s?

@yzhan289 Thanks, should be fixed now, could you have another look?

Hey @olivielpeau, there are a couple other openmetrics checks that also need documenting, like vault and the other kube checks. I can make a PR to update those too, unless you have reason for them not to use the new option.

@fanny-jiang Yes they should be documented as well, if you could open a PR that'd be great thanks 🙇


Node.js 12 actions are deprecated

I'm getting this error when trying to deploy
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b4cbd10e-57b8-de97-b84f-6e46f865c662
Version Independent ID: 533b11b0-5ada-f9c6-65f1-5966df142fa8
Content: Build configuration for Azure Static Web Apps
Content Source: articles/static-web-apps/build-configuration.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@leonid57
Thanks for your feedback! We will investigate and update as appropriate.

Hi @leonid57 what version of node.js are you running? how did you deploy your app?

hi @Grace-MacJones-MSFT if you're not able to reproduce this or you're not getting the same issue from others, then you can chalk this up to user error.


code-server: 4.8.3 -> 4.12.0

Description of changes
Fixes CVE-2023-26114.
Changelogs:
https://github.com/coder/code-server/blob/v4.12.0/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Verified and works. LGTM :+1:

Result of nixpkgs-review pr 228365 run on aarch64-darwin 1


Refresh CLI docs given updated generator.

Staging: https://geeknoid.github.io/istio.github.io/docs/reference/commands/

much nicer, thanks ! (modulo the pre existing #913)

Ordering the different entries would require us to be able to introduce some form of metadata in the Cobra state. We could introduce an IstioCmd which is an extended version of a cobra.Command which holds this kind of info.


Captured parameters appears to be double url decoded before capture

Having a route like /foo/{bar} and calling it with either /foo/1+2 or /foo/1%2B1 both result in {bar} capturing a value of 1 1 when only the first request should do that.. the second one is decoded one time too many
Need to investigate is this is host specific of a general bug

This is a small, but still potential, breaking change that might affect you. We stripped the URL decoding code that was in the default route pattern matcher. The responsibility for making sure that the requested URL is URL decoded is pushed out to the individual hosts, so ensure we get a consistent behavior across all hosts


Verify that the Bing API is called only once per each header

It is unfortunately called once per row, or even cell.


No named parameter with the name 'child'

/C:/Flutter/flutter/.pub-cache/hosted/pub.dartlang.org/intl_phone_field-1.4.2/lib/intl_phone_field.dart:192:7: Error: No named parameter with the name 'child'.
child: StatefulBuilder(
^^^^

go inside 'package:intl_phone_field/intl_phone_field.dart'; and change line 192 child to builder:(context) =>

Fixed


[GIT PULL] Man improvements

Several fixes and improvements to the man pages:

fixed buf ring registration flags,
fixed title headings,
improved IORING_REGISTER_BUFFERS2 description.

git request-pull output:
The following changes since commit 9032c80cdc7e64bf146ec801fa8917bed6493075:

  man/io_uring_register_sync_cancel.3: update io_uring_sync_cancel_reg (2024-11-29 09:14:14 -0700)

are available in the Git repository at:

  https://github.com/wlukowicz/liburing man-fixes

for you to fetch changes up to 416d96ce5a4bb0ffb366b93a3c7333842cc290d8:

  man/io_uring_register.2: improve IORING_REGISTER_BUFFERS2 description (2024-12-01 15:44:56 +0000)

----------------------------------------------------------------
Wojciech Łukowicz (3):
      man: fix buf ring registration flags
      man: fix title headings
      man/io_uring_register.2: improve IORING_REGISTER_BUFFERS2 description

 man/io_uring.7                     |  6 +++---
 man/io_uring_prep_msg_ring_fd.3    |  2 +-
 man/io_uring_prep_read_fixed.3     |  2 +-
 man/io_uring_prep_timeout.3        |  2 +-
 man/io_uring_prep_timeout_update.3 |  2 +-
 man/io_uring_prep_write_fixed.3    |  2 +-
 man/io_uring_register.2            | 31 +++++++++++++++++++++++--------
 man/io_uring_register_buf_ring.3   | 10 +++++-----
 man/io_uring_setup_buf_ring.3      | 12 ++++++------
 man/io_uring_sq_space_left.3       |  2 +-
 10 files changed, 43 insertions(+), 28 deletions(-)

Click to show/hide pull request guidelines
Pull Request Guidelines

To make everyone easily filter pull request from the email
notification, use [GIT PULL] as a prefix in your PR title.

[GIT PULL] Your Pull Request Title

Follow the commit message format rules below.
Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

The first line is title (don't be more than 72 chars if possible).
Then an empty line.
Then a description (may be omitted for truly trivial changes).
Then an empty line again (if it has a description).
Then a Signed-off-by tag with your real name and email. For example:

Signed-off-by: Foo Bar<EMAIL_ADDRESS>
The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).
Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.
Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.
If the commit is a fix for an issue, add a Fixes tag with the issue
URL.
Don't use GitHub anonymous email like this as the commit author:
<EMAIL_ADDRESS>
Use a real email address!
Commit message example:
src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe<EMAIL_ADDRESS>

By submitting this pull request, I acknowledge that:

I have followed the above pull request guidelines.
I have the rights to submit this work under the same license.
I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

Looks good, thanks.


Update Preview Banner

Issue #298
https://github.com/bcgov/met-public/issues/298
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #799 (0c79a79) into main (fc6e7ee) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   72.99%   72.97%   -0.02%
==========================================
  Files         169      169
  Lines        4254     4255       +1
  Branches      264      263       -1
==========================================
  Hits         3105     3105
- Misses       1116     1117       +1
  Partials       33       33

Flag
Coverage Δ

metweb
66.64% <30.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/components/engagement/banner/BannerWithImage.tsx
52.63% <0.00%> (ø)

...omponents/engagement/banner/BannerWithoutImage.tsx
62.50% <0.00%> (ø)

...b/src/components/engagement/view/PreviewBanner.tsx
68.42% <50.00%> (-1.85%)
:arrow_down:

met-api/src/met_api/services/engagement_service.py
55.05% <0.00%> (ø)


Add an .mli to the Exec module

Depends on #6
In an effort to clean up the duniverse repo I started adding .mli files for the duniverse internal library. Exec is the first in that series but I'm planning on doing so for the remaining modules.
I exposed the functions that were used outside the module and added a bit of documentation.
I took the liberty of getting rid of the unused values. Some of them were commented as so so I'm guessing that we're planning on using them at some point in the future. I removed them but I'm happy ot open an issue to document that soon to be feature if you feel like it's useful!

I adressed your suggestions in the relevant PR: #6

Some of them were commented as so so I'm guessing that we're planning on using them at some point in the future.

The opposite -- the automatic git management just didn't work that well, so they were on their way out. Thanks for the cleanup!


Rebuild latest docker container

I was wondering if it would be possible to rebuild the latest docker container for every master pipeline. Currently the newest image is 12 days old
I also noticed a rather annoying typo in the readme:
getenvoy/extention-tingyo-builder:wasi-dev
Should be:
getenvoy/extension-tingyo-builder:wasi-dev
Might be nice to add an example of building filters using the docker file in the REAMDE as well!

thanks @wimspaargaren for reporting this. I just resolved this in #82


Global canopy

@zmoon @angehung5 Starting a draft PR for this. Do you want to add the CLI for the script?

@zmoon @angehung5 I have moved this to an active PR.  Do you want to convert back to draft for a CLI in the script, or should we move forward?

Let me try it quickly tomorrow, or I'll review otherwise.

Can always add CLI later

Thanks Zach, agreed.  This is good as we can move forward with the tutorial highlighting this capability.


Bitmaps?

I'm interested in loading a bitmap in to a NumSharp array. I realize that isn't written yet but I'm concerned that if I write and contribute that method it will be way too slow to do anything with. What are your thoughts on speed?
Thanks,
Darren

@fdncred There is a sample for loading MNIST image dataset into NDArray. 10K image data, works very well.

@Oceania2018 Thanks for the info but there aren't a lot of 10k images that need processing. For instance, one I'm working now is 2531 x 2081 x 3 bpp, which makes for > 15.8 million bytes, in a 3 dimensional array. Obviously, anything big like that would be slower but I'm not sure if I want to find out how much slower. I may have to code it up just to see.

@fdncred Hi, I havn't test that large dataset. There is definitely way to optimize it. Like use yield keyword. Read image one by one and feed into neural network.

@Oceania2018 I experimented with Bitmaps and it just crashes visual studio when I try to inspect the np variable. I take that to mean that the arrays are so large that NumSharp can't handle it or I've constructed the numpy array incorrectly. I suspect I'm not using NumSharp correctly. Any ideas?
My system is pretty beefy - 16GB Ram, 12-CPUs.
This is what I did.

Make your project multitargeting following this guide.
Build the net472 version of numsharp and include the assembly in my other project.
Add this code and the image below and set a break  point at the end so I can inspect the np variable.

Note: If you uncomment the byteImage code, my code creates a 3 dimensional byte array. I use this in other places and works great. This code was meant for testing and only really handles 32-bpp and 24-bpp images.
The intent of the code was to create a 2d array of image data by following the example of Array2Dim TestMethod. I know it's not right since np[0] only has two values where it should have 3. I'd like to create a 3d array like with byteImage but I'm not sure how to do that with NumSharp.
private void BitmapToArray(string notes1a)
{
    var bmp = (System.Drawing.Bitmap)System.Drawing.Image.FromFile(notes1a);
    var bmpd = bmp.LockBits(new System.Drawing.Rectangle(0, 0, bmp.Width, bmp.Height), System.Drawing.Imaging.ImageLockMode.ReadWrite, bmp.PixelFormat);
    var dataSize = bmpd.Stride * bmpd.Height;
    byte[] data = new byte[dataSize];
    Marshal.Copy(bmpd.Scan0, data, 0, data.Length);
    bmp.UnlockBits(bmpd);

    var includeAlpha = false;
    var stride = bmpd.Stride;
    //var byteImage = new byte[bmpd.Height][][];
    var w = bmpd.Width;
    var dataLen = data.Length / 4;

    var np = new NumSharp.NDArray<List<int>>();
    var list = new List<List<int>>();

    for (int i = 0; i < dataLen; i++)
    {
        var x = i % w;
        var y = i / w;
        //if (x == 0)
        //    byteImage[y] = new byte[w][];
        var o = (y * stride + x * 4);
        if (includeAlpha)
        {
            //byteImage[y][x] = new byte[] { data[o], data[o + 3], data[o + 2], data[o + 1] };
            list.Add(new List<int>() { data[o], data[o + 3], data[o + 2], data[o + 1] });
        }
        else // FYI - Data is in BGR layout
        {
            //byteImage[y][x] = new byte[] { data[o + 3], data[o + 2], data[o + 1] };
            list.Add(new List<int>() { data[o + 3], data[o + 2], data[o + 1] });
        }
    }
    np = np.Array(list);
}

@fdncred hm I will check your code on Visual Studio Code, Windows, .NET Core 2.1 and maybe I try to use NDArray<double[]> .... somehow. I am not 100% sure if the List is best data type .... we use it in tests often because the lists (arrays) are small in tests. but it is possible to use double[]- so C# arrays instead. they have much better performance.

@fdncred not sure if it is important. But what operating system you use? normal Windows?

Windows 10 1809 Build 17763.55 64-bit

This may be closer but still not right because the shape is wrong.
private void BitmapToArray(string notes1a)
{
    var bmp = (System.Drawing.Bitmap)System.Drawing.Image.FromFile(notes1a);
    var bmpd = bmp.LockBits(new System.Drawing.Rectangle(0, 0, bmp.Width, bmp.Height), System.Drawing.Imaging.ImageLockMode.ReadWrite, bmp.PixelFormat);
    var dataSize = bmpd.Stride * bmpd.Height;
    byte[] data = new byte[dataSize];
    Marshal.Copy(bmpd.Scan0, data, 0, data.Length);
    bmp.UnlockBits(bmpd);

    var includeAlpha = false;
    var stride = bmpd.Stride;
    //var byteImage = new byte[bmpd.Height][][];
    var w = bmpd.Width;
    var h = bmpd.Height;
    var dataLen = data.Length / 4;

    var arr = new NumSharp.NDArray<NumSharp.NDArray<NumSharp.NDArray<byte>>>();
    arr.Data = new NumSharp.NDArray<NumSharp.NDArray<byte>>[h];
    for (int i = 0; i < dataLen; i++)
    {
        var x = i % w;
        var y = i / w;
        if (x == 0)
        {
            //byteImage[y] = new byte[w][];
            arr[y] = new NumSharp.NDArray<NumSharp.NDArray<byte>>();
            arr[y].Data = new NumSharp.NDArray<byte>[w];
        }
        var o = (y * stride + x * 4);
        if (includeAlpha)
        {
            //byteImage[y][x] = new byte[] { data[o], data[o + 3], data[o + 2], data[o + 1] };
            arr[y][x] = new NumSharp.NDArray<byte>();
            arr[y][x].Data = new byte[4];
            arr[y][x].Data[0] = data[o];
            arr[y][x].Data[1] = data[o + 3];
            arr[y][x].Data[2] = data[o + 2];
            arr[y][x].Data[3] = data[o + 1];
        }
        else // FYI - Data is in BGR layout
        {
            //byteImage[y][x] = new byte[] { data[o + 3], data[o + 2], data[o + 1] };
            arr[y][x] = new NumSharp.NDArray<byte>();
            arr[y][x].Data = new byte[3];
            arr[y][x].Data[0] = data[o + 3];
            arr[y][x].Data[1] = data[o + 2];
            arr[y][x].Data[2] = data[o + 1];
        }
    }
}

I'm trying to match the array from this python code. Which is shape(2531, 2081, 3).
pil_img = Image.open(filename)
img = np.array(pil_img)

Understand. When at home maybe will try to extend array method for this. By the way. Thanks for show us the python code. It is important that we really match the APIs as well as possible.

@fdncred u use the code from github and builit or u take the nuget package? Just to know how to support ur case best

I downloaded and compiled the code from Github.

Ah yes. Lol sorry my fault. Ok will test it at home.

No worries, thanks for your help.

@dotChris90 Do you think we should refactor NDArray class to every specific generic type? separate NDArray to NDArray<double[]> or NDArray  where T is limited to value type, and change
public IList<TData> Data { get; set; }

to
public T[] Data { get; set; }

For 3 Dim will be
public class NDArray3<T>
{
    public T[,,] Data { get; set; }
}

I thought this will definitly get the best performance.

An alternate approach is to compile the numpy source code into a c++ dll and then p/invoke calls out of it. This is kind of what python does. Numpy isn't written in python, just the wrapper is. Then you'd have all the speed of numpy and one would have to figure out how to marshal data back and forth.

But I did find this. Looks like it could be helpful.

@dotChris90 I like the jagged array.
var A = new NDArray<double[][]>()

@Oceania2018 ok - if you do not mind I would do a totally restructure at Friday and weekend (have some holidays). I suggest just one of us (so me) do this because it also include changing the unit Tests etc.

I have another idea. What about create new class named NumSharp, it will be equivalent np when you do bar np = new NumSharp(). then np.arange(10).

NumSharp will hide the mass of NDArray. I agree with you. You will do the restructuring. Appreciate.

@fdncred interesting. Seems NumSharp is not the only project try to reconstruct numpy lol Thanks for post. I just think that in .NET Core 3.X the .NET system will bring a lot more stuff for machine learning, array performance and so on. That is the reason I avoid using C. AT the moment. But if we find out in 2019 that .NET Core 3.0 does not bring us what we wish we will go with C maybe. And about the Numpy project. I think at moment they use their internal mechanism by including the Python.h in their files. If we want to integrate this into .NET it feels a little bit too much wrapping and we still have to implement the classes. I really would like to see if the numpy team would writing their stuff in C and compile to shared object and linking their python object code to this shared object. Anyway maybe we can have a look on their Github repo :D

@Oceania2018 honestly the  np = new NumSharp(). is a fantastic idea. lol this makes all stuff look more like numpy. We could try to use .NET script or Powershell and make some examples. after restructure the array stuff.

@dotChris90 Sounds great, let's do it. I will add a NumSharp class, you do the NDArray restructing.
Another advantage of NumSharp is making our API more stable for high level usage. Just change NDArray implementation, better encapsulation of OOP.
var np = new NumSharp();
np.arrange(10);

@fdncred Are you interested joining this project?

@dotChris90 I posted that C++ link in order to help port to C#. For me, at least, it's easier to read C/C++ and turn it into C# than it is for me to ready python and turn it into C#.  Here's another C++ port of the NumPy functionality with help. Again, may just be useful seeing how other people reinterpret numpy.

@fdncred I made Testmethod for your case to try and play around with this use case of byte[][][]. In Visual Studio Code the debugger for this image working fine - slow but fine. but not for our NDArray - i just tried at moment for byte[][][].
I would suggest I will do the restructure of our NDArray this week and extend Array method. I will let you know when finish. Honestly until now we did not think about Tensor types like byte[][][]. Maybe that was the reason the Shaping method does not work proper. When finish the restructure will let you know. And You can try than sth like
var myArray = new NDArray<byte[][][]>().Array(new Bitmap("pathToImage"));
For now - if you want to play around with the code now - Maybe you could try to make :
var myArray = NDArray<byte[][]>(); // so a NDArray of byte array of byte array - but it looks like matrix thats why want to restructure

@fdncred sure. Honestly the link was interesting. and totally agree with you. C++ and C# are much closer to each others than Python. Even python is a nice language but ... lot of things are missing. Generics - just as example. Maybe will have a look deeper in this C++ projects

@fdncred just question of curiosity. What API you suggest to implement for byte[][][]? In other words - what would be good to see for images?

@fdncred @Oceania2018 I checked your link https://xtensor.readthedocs.io/en/latest/numpy.html amazing! but I asked myself - It is not possible to have an array<double,2> generic - am I right? Because this looks extreme nice for users. But I never saw this in C# or in general .NET world.

@dotChris90 I just disucssed with someone else. We have an other solution. Please hold on. Don't do any change.

@Oceania2018 ok will do nothing for today. But what was discussing about the NDArray<double[][]> , the Bitmap or np = new Numsharp? :D

I pushed code. Please refer NDArrayOptimized. All data should be persist in a one dimension array. NDArrayOptimized will parse the 1d array to any dim array only when data is used.

@dotChris90 I don't understand your question about what API for byte[][][]. Sorry. Having an image in a byte[][] or byte[][][] is only useful as it relates to numpy's algorithms.  If you look at this python project you'll see how they're using it. This python project is where I got the idea to use NumSharp when I converted it to C#.

@fdncred I think we would do it like this:
var np = new NDArrayOptimized<byte>();
np.reshape(n1, n2, n3);
// load image bytes into np

@Oceania2018 That seems intuitive to me as long as it returns np[height][width][byte[3]]. I think that's what python is doing but maybe it's returning tuples - I can never tell with imaging on python.

@fdncred the project page is enough. Before usual always working with time series. not too much with images. :D So I dont know well which functions are used mostly. Just was looking for some inspiration or use cases.

@fdncred I created a 1M bytes, cost 0.5s.

@Oceania2018 Do I really understand you well? So you want store everything (1D,2D,3D,...ND) in a single array? The properties like Shape decide the dimension? Do not get me wrong but this will leads to some ... problems I think.
1 ) our methods will get longer and not so well structured. Until now we can have "MethodName(NDArray)" and "MethodName(NDArray<double[]>" to differ between vector and matrix. Since polymorphism we can have 2 different methods with the same name but different parameters. If our objects are always NDArray you can not make this but instead always have to do a huge "if else" structure. If method see it is vector do this, if matrix this. So this leads to less files but also increase the danger of "people have to work on 1 file at the same time".
2 ) It is not totally OOP in my opinion. In OOP we say "This is a matrix and it has this methods and properties" and this is a vector with properties and methods. But here we say it is an array - It can be anything. That is dynamic interpreter style not compiler. It is python - not C#.
3 ) Performance. Sorry I say but I am not sure if a huge array brings better performance. We should do some tests to find out best but I am very sure jagged arrays are faster than 1 huge array and you have to search the elements first with every access.
4 ) Do you really, really want to rewrite all the operations and methods? It will be hard because on Stackoverflow you will find code examples with double[][] and so on but never a example with double[] for a matrix.
5 ) Why you want to create your own Array? .NET world already has very fine and optimised ways for arrays. Python not so they developed from scratch. So we should always stay with this array type system.
So please give me some reason why NDArray matrix = new NDArray().Array(...) is better than NDArray<double[][]> matrix = new NDArray<double[][]>().Array() ?
I know the QuantStack do it and I find little bit weird  since I CAN NOT SEE FROM MY CODE WHAT Numeric TYPE I HAVE. Have a look again :
var matrix = new NDArray<double[][]>() // I can see 100% it must be a matrix
var matrix = new NDArray()     // Is it a vector, a matrix? no! it is something we do not know -.-

@Oceania2018 will open an other issue to discuss this. Bitmap it not the best name for this ;)

@fdncred I pushed an array method to NumSharp which accepts a bitmap object as input parameter. You can try and play. :)
With the new 1D array strategy we could simple take the byte array of this Marshal. Copy method and put into NDArray Data property. Just need to set the shape as height wideth 3.
Only thing I don't understand is that the order of rgb vector is different now in numpy and Marshall. Copy. Shall we correct this?

@fdncred took your image and example code for the method and unit test.
Hope u don't mind :)

@dotChris90 I'll take a look at it. I have no problem with you using any of the code I've pushed or put in issues, so feel free to use it without question.
The thing about dotnet bitmaps is they're stored in BGR format. So that may be why the vector is different. So, typically there's a byte swap of R & B to get them aligned properly.
I see some things I'd change but this is definitely a good start. We just have to figure how what BPP we will support and be able to handle those flavors of bitmap.
For speed purposes we could also use unsafe calls on bmp.Scan0 instead of marshaling. Marshaling isn't exactly fast, but we can decide that later.

@fdncred totally agree. First let make a nice start for NumSharp.
:)


typo

Pull Request Test Coverage Report for Build 5370

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 63.491%

Totals

Change from base Build 5367:
0.02%

Covered Lines:
8010

Relevant Lines:
12616

💛  - Coveralls


Update splice to 2.2.5-201702161914

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask's name and version.

Thank you for the contribution. It was merged directly as e63db19f2dd4fce75ae9f91282ea04531a17a9de to keep commit history cleaner. Your contribution is still credited to you.


access denied

Doesn't seem to work I have an URL which is returned and when I go to the URL I get access denied.

Make sure your key has permissions to create the signed URL and that the file does indeed exist in S3.  I just ran a test to be sure nothing has broken and all appears to be well.


Languageserver: Encode url, otherwise funny paths wouldn't be rendered correctly

also fixes innocuous XSS

As I was saying on the other PR, this PRs will have no effect on the new version since I'm not handling files via HTTP server. VSCode now has a great support and extensible api for the webview, so I'll be closing it, ok?
Thank you again @berdario !


Initial implementation of Extract Constant

[First, I propose standardizing on the terminology "extract function" and "extract constant", which, I argue, are more accurate than "extract method" and "extract local".  This has no impact on the user-facing strings.]
This change generalizes the Extract Function refactoring (formerly, "Extract Method") to Extract Symbol and has it return both function and constant extractions.  This required adding consideration for additional scopes into which it's sensible to insert constants but not functions.  For Extract Function, the new scopes are immediately marked with errors.
This change also switches the tests to use the "public" API so that the two families of extractions can be distinguished.  The baselines have been updated accordingly.
Outstanding work:

Rename the extractMethod baselines for consistency.  I didn't want the diff to be even worse.
Improve the insertion locations of locals in function scopes.  Right now, they are only inserted at the root level, which is frequently invalidated by the lack of access to variables from nested scopes.

Testcase we were looking at
/*!
* MIT APACHE
*/
"use strict";
"use module";

namespace Y { }

namespace X {
    namespace Y {
        export const j = 10;
        namespace Z {
            export const y = j * j;
        }
    }
}

as well as
/// <reference ...

and
x = y; // Extract the whole thing

I can repro the assert in a unit test.  This looks relevant: https://github.com/Microsoft/TypeScript/pull/18484/files#diff-20a9fa4d3e9d09f60c275a3dda245867

@RyanCavanaugh The problem we were seeing (in our case, an assert about token spans) will occur any time a substitution is applied more than once.  Since the same issue affects Extract Function, I'm going to handle it in a separate PR.

@RyanCavanaugh I believe all outstanding issues can be addressed in subsequent PRs.

Many fixes to follow. 😄


Please merge these VM revisions into 1.11

@ricowind @whesse @kasperl @crelier

If this is a request to merge to stable please change the MergeToDev label to MergeToStable
In the new setup it is not apparent to me whether 1.11 is on stable or dev so I set both labels.

This includes an implementation of "int modInverse(int modulus)" similar to "int modPow(int exponent, int modulus)". This fixes issue 23502.
CLs and corresponding hashes:
https://codereview.chromium.org/1174513004/
https://codereview.chromium.org/1177873002/
https://codereview.chromium.org/1177063002/
https://codereview.chromium.org/1188843004/
f6f338ce67eb8801b350417baacf6d3681b26002
90315a1694a40ba738a5197295b0c1a7b9d03c5f
9edc6e5a6d31ec926be7743c06f500f125a04b54
16bb52b88ded9da50508d72bf86825b243ad8258
Prevent a potential conflict between observatory data collection and concurrent sweeping. This can cause mark bits being changed prematurely while the concurrent sweeper is running. Fixes issue 21620.
CLs and corresponding hashes:
https://codereview.chromium.org//1181943002
https://codereview.chromium.org//1179973005
1009d587de88ec04a66cd60409aba3a281e21f64
3ce2b95070a26d7aa5173673095d49e0494c4151

Fixed in ec79b1622479c2b21d176aa9fa1e05b30eb4c676


Divide by Zero error for request tiles on Itinerary Event page

When there are no requests the display on the tiles exhibits a divide by zero error.

@tonysurma - I'm working on this - please assign to me.


Get-AzureADMSPrivilegedResource -ProviderId AzureResource no longer lists Subscription Object

cmdlet Get-AzureADMSPrivilegedResource -ProviderId AzureResources no longer lists the Subscription as a type.
e.g. $Subscription = Get-AzureADMSPrivilegedResource -ProviderId AzureResources | Where-Object {$_.DisplayName -eq $SubscriptionName}
This was quite useful for me, as I would use the resource ID to configure all the role settings in line with the business requirements e.g. approvals, activation limits etc.
Get the script user to supply the Azure Subscription name
$SubscriptionName = Read-Host "Please enter the subscription display name"
$Subscription = Get-AzureADMSPrivilegedResource -ProviderId AzureResources | Where-Object {$_.DisplayName -eq $SubscriptionName}
Get the role resource and role settings
$RoleName = $RoleToConfigure.Name
$Role = Get-AzureADMSPrivilegedRoleDefinition -providerid AzureResources -ResourceId $Subscription.Id  | Where-Object {$_.DisplayName -eq $RoleName}
$RoleSettings = Get-AzureADMSPrivilegedRoleSetting -ProviderId 'AzureResources' -Filter "ResourceId eq '$($Subscription.Id)'" | Where-Object {$_.RoleDefinitionId -eq $Role.Id}

This is the same for me, I wrote a load of scripts sometime ago and was wondering why they suddenly stopped working

@frazhamid - Apologies that we have not gotten back to you with a solution to this issue. Due to the planned deprecation of this module, all investments are in the Microsoft Graph PowerShell module. I recommend that you try Get-MgPrivilegedAccessResource which is the alternative cmdlet in Microsoft Graph.
If you require further support on this issue, you can try one of the following links for additional help.
Microsoft Support: https://support.microsoft.com/
Azure AD forums: https://social.technet.microsoft.com/Forums/en-US/home?forum=windowsazureaditpro
Stackoverflow: https://stackoverflow.com/
I will proceed to close this issue. Feel free to open follow-up doc-related issues here.


Fixing incorrect buffer in WideCharToMultiByte call in wc2mb (charset.cpp)

I noticed that form.icon() did not work properly under MinGW - long story short, turns out that the WideCharToMultiByte call got an incorrect cbMultiByte parameter - thus returned an ERROR_INSUFFICIENT_BUFFER error.

mbstr.resize(bytes - 1); is correct - that is counted without the terminating zero.
cbMultiByte, however is "Size, in bytes, of the buffer indicated by lpMultiByteStr." so the terminating zero must be counted too.

I am not sure how to proceed with adding checks for all return values of all of the Stringapiset.h calls here, so I'll leave that for later. Ideally wc2mb should have failed though.

Thank you for fixing this issue!


Zoom bug

Describe the bug
The zoom out wider than from around county level on the map using screen touch doesn't stay zoomed out, pops back in when touch is released.
To Reproduce
Steps to reproduce the behavior:

zoom out wider than from around county level on the map using screen touch
Release touch
Zoom does not persist,but pops back in.

Expected behavior
???
Screenshots
N/A
Smartphone (please complete the following information):

samsung note 4,
android 6.0.1
Browser Unknown
Version Unknown

Additional context
N/A

This behaviour is intended, though clearly that could be better signalled.
We found that if we allowed a wide zoom folk would use it to examine toilet provision across the county, pacing an expensive strain on our infrastructure. We have plans to address this one day, but... You know.. Time..
In the meantime if you'd like to see a higher level overview we have an experimental chloropleth map at: https://www.toiletmap.org.uk/explorer/map

It'd be nice to think of a way to signal this. Perhaps we could detect the overzoom and pop a banner? "Looking to see all the loos? Use our overview map and save the planet!"


Bump version number to v11.0.0

What does this PR do?
Bump version numbers to v11.0.0
Motivation
New release for ddprof
Additional Notes
NA
How to test the change?
NA

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.21%. Comparing base (a2757e9) to head (b95139f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   70.21%   70.21%
=======================================
  Files         206      206
  Lines       27815    27815
=======================================
  Hits        19530    19530
  Misses       8285     8285

Components
Coverage Δ

crashtracker
16.86% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
51.15% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.41% <ø> (ø)

ddcommon-ffi
75.31% <ø> (ø)

ddtelemetry
59.02% <ø> (ø)

ipc
84.13% <ø> (ø)

profiling
78.68% <ø> (ø)

profiling-ffi
58.26% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
35.64% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
70.93% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
89.91% <ø> (ø)


New deployment does not have authors parameters coming up in the task module of "new message"

We have done a new deployment, everything is successful, however, task module for new message is blank when author is trying to draft one.

Hello @chandni-agarwal ,
Thanks for reaching out to us!
As this issue is being discussed internally, we are closing it here.


fixing nightly unit test failure

Changes
Unless service account is explicitly set in taskrun spec, by default, service account is set to "default".
Scott's error capture says:
* failed to create task run pod "test-taskrun-run-success": translating TaskSpec to Pod: serviceaccounts "default" not found. Maybe missing or invalid Task foo/test-task

test-taskrun-run-success taskrun has no service account set. Later in the config map, default-service-account is set to pipelines. But if service account is not specified in the taskrun spec, task run controller sets the service account to default which is clear from the error message where controller is looking for service account default instead of pipelines.
It can also mean that the config map settings/updates done in the unit test are not visible to taskrun controller which needs fix.
This error is intermittent and time plays role here since the other unit tests in taskrun_test.go are creating default service account (and never deleted). If this unit test TestReconcile_ExplicitDefaultSA is the first one to start, we are missing default service account and fails with this kind of error.
Fixes #2815
/cc @bobcatfish @sbwsg
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Fixed nightly build failure due to unit test failure

@afrittoli we could also look into configMap settings to see why default-service-account is not getting set to pipelines instead its set to default.

I want to dig into this a little bit:

I don't quite understand why "default" wouldn't exist - afaik there is always a "default" serviceaccount in every namespace (i think?)
The error says "default" was not found, but the change in the PR changes the test to use "default" instead of "pipelines"

I think this makes sense if the problem was that that "pipelines" service account didnt existing, but the error above looks like it's the other way around - could you explain a bit more?

default service account would exist in a running instance 😜  Here, the validation or check is being done against the test asset (specifically, fake clients) and that's reason this unit test has to create/register the service account in that client.
This unit test creates pipelines service account and sets pipelines as default service account through config map but taskrun controller fails to read that change done in config map. Without any config map changes, for taskrun controller, default service account is default and thats why test is complaining that default does not exist in the fake client (my brain is fried at this point 😆 )

I also don't totally understand how this could have ever worked since I don't see anything creating the "pipelines" service account either 🤔

The unit test is creating pipelines service account. The test is checking if spec has set any service account which is not true in this case and results in saName to be empty. When saName is empty, its set to defaultSAName which is pipelines in this particular case.

No worries @bobcatfish yup I can understand it being so tricky and appreciate you following the entire analysis. This screen shot from Scott's error capture might be useful understanding and feel free to hold this unless you are sure.
Even when the config-defaults ConfigMap has default set to pipelines and no service account specified in the taskrun spec, taskrun controller is looking for default:

Since I am not able to reproduce this, I am feeding off of this error capture and changing it to default. I have opened another PR # 3168 related to the findings from this effort. That PR is implementing changes to
set service account in taskrun spec if neither specified in the spec nor in config-defaults ConfigMap compared to what we have today setting service account in taskrun spec if not specified in the spec but exists in config-defaults ConfigMap.

Thanks @vdemeester I am closing this for now assuming this is fixed with PR #3189 🙏


ID tool pulling P corni when no results should appear

No Quercus species are currently mapped to Alberta. However, selecting both quercus and alberta in the ID tool incorrectly yields one result: P corni.

Poking at this a bit it seems that if you select any combination of genus and place that should yield zero results it returns P corni. Very strange. I will look at it.

Here is what is happening:

A genus is selected, say 'Nyssa'
All galls for Nyssa are fetched from the back end
A Place filter is applied, say 'Alberta'
The set of galls (already fetched from the back end) is filtered in the browser based on the list of Places that the Gall occurs in (which was formed in step 2 by looking at all of the hosts for the gall and pulling all of the places and and aggregating into a single list)
P corni will appear even though Nyssa does not occur in Alberta

P corni shows up because it occurs on Nyssa AND it occurs on other hosts, e.g. Acer, that do appear in Alberta. Since the list of Galls and the Places was generated by fetching data from the DB it is not possible to filter P corni out for this combination as the Host-Place data is not available (it is not passed down from the database as to do so would make the ID tool very slow since so much data would have to be passed).
This can be fixed but it will require a re-think of how the ID page works under the hood.
Options:

Have the Place field, when changed, re-fetch data from the back end.
Pass the host genus info down with the results so that it can be filtered correctly on the client side
Re-implement the page to not pre-fetch ANY data and instead have it all happen in real-time

Options 1 and 2 are much easier than 3. Option 2 may have performance impacts since we will have to pass down a lot more data (every gall returned will have to have a list of Hosts attached to them). Option 1 will require a slight re-think of the UI since the Place field will behave more like the Host/Genus(Section) fields then any of the other filter fields.
As I have mentioned in the past, I think that the ID tool needs a total re-think. It is at the heart of the User's experience when using the site and I built it with only a partial understanding of how it might be used (as all software is built!). Now that I have a better handle on it, using it a lot myself, I have a lot of ideas on how to make it much better. The problem is that it is a lot of work to do this and I have limited time and we have no one else doing any tech work.
I think that for now we should go with Option 1 above. I may run into other issues with this approach because of assumptions about the clear separation between selecting a Host and all of the Filter properties that currently exists.

P corni shows up because it occurs on Nyssa AND it occurs on other hosts, e.g. Acer, that do appear in Alberta

I think I get what you're saying, but if so, it seems like this would cause issues more frequently than I've noticed. Maybe it has fetched "wrong" answers I haven't noticed at other times, but I guess if it's always within the genus then they wouldn't strike me as odd. Anyway, whichever solution you decide makes sense works for me--or honestly, if you want to wait and just leave this issue until you redo the ID page in general I don't think that's a huge problem.

I think that since most galls do not cross genera this issue does not show up frequently. e.g.,
https://www.gallformers.org/id?hostOrTaxon=Cornus&type=genus&detachable=&alignment=&cells=&color=&locations=&season=&shape=&textures=&walls=&form=&undescribed=false&place=Quebec
In addition to P coni, Pulvinaria acericola and Neopulvinaria innumerabilis shoudl not be here. They both occur on Cornus florida but C florida does not occur on Quebec.

Yes, though those P corni examples are probably a case where the mistake corrects for an inappropriate narrowness of our data. It's likely that P corni is found on Cornus in Quebec even if it's not P corni.


Set Theory - Formatting/Spelling Errors

On the left menu of the Set Theory section, "supplemental" is misspelled as "supplimental":

On "Set Builder Notation", "whose" is misspelled as "whos", and "Lets" is missing an apostrophe:

On the example problem for $A\cup B$ in "Simple Set Operations", it looks like you meant to write $A \cup B= \lbrace 1,2,3,4,5,6,7 \rbrace$ in LaTeX, but it came out in plaintext instead:

In the definition of $A \cap B$ in "Simple Set Operations", I assume you meant to write $A \cap B$ but used $\cup$ by mistake:

In the definition of $A \triangle B$ in "Simple Set Operations", it looks like you meant to write $A\triangle B = (A-B)\cup (B-A) = (A\cup B) - (A\cap B)$ in LaTeX but it came out in plaintext instead:

On "Advanced Set Operations", "unique" is misspelled as "unqiue":

In the second footnote of "Advanced Set Operations", I assume you meant to write "it" instead of "its":

On the Standard Induction Theorem in "Inductive Method", I assume you meant to write $\lim_{j\rightarrow\infty}A_j = \mathbb{N}$ in LaTeX but it came out in plaintext instead:

In "Inductive Method", "Lets" is missing an apostrophe and the LaTeX equation $\lim_{j\rightarrow\infty}A_j = \mathbb{N}$ came out in plaintext:

The example problem at the end of "Inductive Method" also appears to have a LaTeX expression $\lim_{j\rightarrow\infty} A_j=\mathbb{N}$ in plaintext:

On "What is a Function?", "according" is misspelled as "accoridng":

On "What is a Function?", "the" is repeated twice as shown in the screenshot below. Did you mean to write "to"?

Fixed


Add a k/v store for indexing deferred "Grant Assigned" emails to a digest

DOD: Terraform provisions a new DynamoDB table that can be accessed by API ECS tasks.
Implementation details:

In the terraform/modules/gost_api module, provision a "Pending Grant Notifications" DynamoDB table with the following settings:

Billing mode: On-demand (PAY_PER_REQUEST)
CloudWatch contributor insights enabled
Point-in-time recovery enabled
Table class: Standard
Encryption at-rest using the Amazon DynamoDB-owned encryption key (not a KMS key in the account)
Key schema:

Partition (hash) key: Recipient (string)
(No sort key)

TTL: Enabled, attribute name: ExpireAfter
No stream enabled

Add a new environment variable, PENDING_GRANT_NOTIFICATIONS_DDB_TABLE to the module.api_container_definition configuration (defined in terraform/modules/gost_api/task.tf), where the value of the environment variable is the name of the new DynamoDB table.
In the terraform/modules/gost_api module, define a new IAM policy document (using the "cloudposse/iam-policy/aws" module) that allows the following actions for the new DynamoDB table resource:

dynamodb:DeleteItem
dynamodb:DescribeTable
dynamodb:GetItem
dynamodb:PutItem
dynamodb:Scan
dynamodb:UpdateItem

Add the new IAM policy to the aws_iam_role_policy.task resource defined in terraform/modules/gost_api/task.tf so that API tasks are able to access the table.

Subtask of:

#934

Blocks:

#1228
#1233

**Raise up for collab group - we may need to assess if Share should be set up in a way that makes it possible for them to be included in a digest

@TylerHendrickson as we're anticipating replacing the assign feature with Sharing, my understanding is that this issue, #1228, and #1233 are no longer needed. I'm going to move them to icebox for now, but before I close them, wanted to check if the content from any of these issues would be helpful to keep in documentation of for future digest work.


Datetimepicker not working inside table-responsive

Datetimepicker not working inside table-responsive.
Look: https://jsfiddle.net/0Ltv25o8/1886/
Remove class table-responsive from div and working how it must. The version 3.1.3 in Opencart 2.1 is working OK with table-responsive.

Hey. I am not having the same issue. It continues to bother you?

Having the same issue.

yes, I am also having same issue with table-responsive.

@nikunj24u Could you, please, upload an image of what is happening? And a part of your code, if possible.
Thanks.

@emersonmellado, Please find screenshots as attachments.
In table-responsive class, I have changed override the overflow:auto to overflow:visible, which solve the issue and DateTimePicker dialog gets visible properly in large screens i.e. for laptop and desktop (Screenshot 1). But because of overflow:visible table-responsive looses the scrollbar in small and medium screens(screenshot 2). Now in firebug if I disable overflow:visible, table-responsive gets the scrollbar in small screen(screenshot 3).

Thank you.

@emersonmellado, I believe, the issue is DateTimePicker dialog is created just under its creator textbox. So both, textbox and created DateTimePicker are inside table-responsive class. If DateTimePicker can be created just before body tags ends and set its top-left according to its creator textbox top-left, this type issue can be solved. As I do not know how the jquery is written, I can not say much about the soluiton, just take it as a suggestion only.

As I am running little tight on time, I will appreciate if you provide any solution or workaround.
Thank you,
Nikunj Patel

Appears to me that the issue is not exactly the "table-responsive" class behavior. On the second image you've sent there is a horizontal scroll bar, right?
I'd try, as a workaround, to hide columns on this table by media query. for example:
@media only screen and (max-device-width: 480px){     //for header     and    for td to hide      tr th:nth-child(2), tr td:nth-child(2),     tr th:nth-child(3), tr td:nth-child(3),     tr th:nth-child(4), tr td:nth-child(4),     {         display: none;     }
It's not the solution, but I believe that if you scroll the table right you'll be able to see the data selection field. That make sense to you?

On third image horizontal scrollbar gets visible if I disable overflow:visible in table-responsive class.
See, there two things,
First, to solve DateTimePicker issue with table-responsive class, need to have overflow:visible.
Second, to have a scrollbar on talbe-responsive class in the small/medium grid, need to have overflow:auto/scroll. In that case, DateTimePicker dialog will not appear properly.
So, DateTimePicker dialog appear logic should be changed.
Thank you for the workaround but that will not work in my case as I must show all the columns.
Please do the needful.

I'm having the same issue.  The table inside div with classes "row table-responsive". On showing date picker it creates scrollbars around the table.

Any solution ? the widgetParent does not seem to be working great.

Any solution? I also have this problem

Currently this doesn't have an easy fix but for now:
this is the dirty-workaround:
let $picker = $('.date');
$picker.datetimepicker({});

$picker.datetimepicker().on('dp.show', function() {
  $(this).closest('.table-responsive').removeClass('table-responsive').addClass('temp');
}).on('dp.hide', function() {
  $(this).closest('.temp').addClass('table-responsive').removeClass('temp')
});

I have solved the issue by adding position:relative; rule to .bootstrap-datetimepicker-widget class in bootstrap-datetimepicker.min.js.

To any one that has @aman-subscriptions problem (capture 2), you must add this class to your th, td containers.
.backgrid th,
.backgrid td {
  display: table-cell;
  position: relative;
  overflow: visible;
}

I use it within an backbone/backgrid project and it works perfect.

This Script work for me with bootstrap 4

tempusdominus-bootstrap-4.txt


feat(chat): add a 'Shared with me' section to the file manager modal (Issues #1283, #1982, #1987)

Description:

Added a 'Shared with me' section to the file manager modal.
Implemented ability to add shared files to the App state.
Fixed possibility to download published files from the 'Manage attachments' screen.
Fixed usage of the published and shared files in the conversations.
Fixed download files from publish and unpublish forms.

Issues:

Issue #1283
Issue #1982
Issue #1987

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review


Eagle 0.5 ingestion + alert engine preview

Good fix. To become a high-quality project, we should at least try to make sure cleaning all compiling warning if possible.

building eagle-topology-assembly failed because eagle-security-hdfs-securitylog and eagle-security-hbase-securitylog are renamed, and eagle-security-userprofile are removed.
As a high-quality project,  it is better passing build before submitting.

Sorry about that, this change impacts develop branch only, 0.4 branch is stable brach and soon be out.
I am checking develop branch to make sure it passes build.
By the way, develop branch has many changes regarding code structure because of introducing new alert engine and metadata change, to build successfully with develop branch, it is better to clean your local repo one time

it is fixed now, sorry again for the inconvenience.

Thanks for response!
Would you please give me some backgrounds(or link) about   new alter engine?

Sure, will get back to you soon!

@baibaichen can you send to me your email, I can respond to you the background of new alert engine, today we don't have design doc ready, and that will be announced 4 weeks later . My email is<EMAIL_ADDRESS>


Fish Segmentation

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Fish Segmentation
:red_circle: Aim : Create a ML model which will classify and identify the fishes.
:red_circle: Dataset : https://www.kaggle.com/crowww/a-large-scale-fish-dataset
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Issue assigned to you @HeetRaichura12

Issue has been un-assigned from you due to inactivity.
@HeetRaichura12

Hello I would like to work on this project. Please assign it to me
Full name : Evan Joshy Chittilappilly
GitHub Profile Link : https://github.com/TheDarkParalda
Participant ID (If not, then put NA) : NA
Approach for this Project : CNNs, different models
What is your participant role? - Participant

Issue assigned to you @TheDarkParalda


Staging fails for SICF Nodes

When a SICF node is part of the Packgage to be staged, the eclipse plugin fails with:
"Access using a 'ZERO' object reference is not possible."

Debugged into the code and the isssues seems to be that zcl_abapgit_res_repo_stage->get the lines
 ls_obj_wbtype = get_object_wb_type(
                iv_obj_name = <ls_repo_items>-obj_name
                iv_obj_type = <ls_repo_items>-obj_type ).
              ls_object-wbkey = cl_wb_object_type=>get_global_id_from_global_type( p_global_type = ls_obj_wbtype ).

Do not determine something for obj_type SICF .
In abapGit itself it can be staged only ADT_Backend crashes.
Worked around it with a continue if ls_obj_wbtype is initial. But of course the SICF cannot be commited or pushed then.
Replication can be easily done with a CDS View and OData publish.


Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

Hi,
I have a CMakeFiles.txt for a project I'm currently working on. And among the lines I have this one:
find_package(PkgConfig REQUIRED)

Which makes crash when I try to run CMake with the following error:
CMake Error at C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/CMake/share/cmake-3.17/Modules/FindPkgConfig.cmake:45 (find_package_handle_standard_args)
  C:/Projects/vcpkg/scripts/buildsystems/vcpkg.cmake:329 (_find_package)
  CMakeLists.txt:29 (find_package)

So I thought I had to install FindPackage and closest thing I came across that look to me like a procedure is this one:
https://stackoverflow.com/questions/1710922/how-to-install-pkg-config-in-windows
But I can't figure how this would apply to vcpkg
Could you help please?

Related issue: #11088


Create tests for all the API endpoints

There should be tests created for all the API routes.
Some resources for it:
Testing ExpressJS REST API with Mocha and Chai | Medium
How to Test Nodejs Code and RESTful API | CodeForGeek
Testing NodeJs/Express API with Jest and Supertest | Dev.to
Mocking ExpressJS Request and Response objects | ITNEXT

I'd like to pick this up.

Hey,
thank you for taking an interest, your help would be much appreciated :)

No problem, I hope to be helpful :)

One thing I'd like to note as I'm not sure if it obvious from the code itself is that almost all routes expect the guid to be sent and not the numerical id as a parameter for the request.
Some routes such as those for the city and/or country use the numerical ID.

I'm having a problem trying to run migrations. I have setup the MySQL DB, but every time I try to run the db-migrate up, it returns me this error:
received data: CREATE TABLE user` (
id INT NOT NULL AUTO_INCREMENT PRIMARY KEY,
name VARCHAR(100) NOT NULL ,
email VARCHAR(100) NOT NULL UNIQUE,
username VARCHAR(50) NOT NULL UNIQUE,
password VARCHAR(255) NOT NULL,
active ENUM('0','1') NOT NULL DEFAULT '0',
created_at DATE DEFAULT CURRENT_DATE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
INSERT INTO user
(name, email, username, password, active)
VALUES
('Igor Ilić'<EMAIL_ADDRESS>'gac', 'fac5b2c9d9fe1d6cc567798868a6e02124a50f4d3d4330ea96a95ddb62e9673b', '1');
[ERROR] AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'CURRENT_DATE
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
INSERT INTO user
(n' at line 8
at Query.Sequence._packetToError (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/sequences/Sequence.js:47:14)
at Query.ErrorPacket (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/sequences/Query.js:79:18)
at Protocol._parsePacket (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/Protocol.js:291:23)
at Parser._parsePacket (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/Parser.js:433:10)
at Parser.write (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/Parser.js:43:10)
at Protocol.write (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/Protocol.js:38:16)
at Socket. (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/Connection.js:88:28)
at Socket. (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/Connection.js:526:10)
at Socket.emit (events.js:315:20)
at addChunk (_stream_readable.js:295:12)
at readableAddChunk (_stream_readable.js:271:9)
at Socket.Readable.push (_stream_readable.js:212:10)
at TCP.onStreamRead (internal/stream_base_commons.js:186:23)
--------------------
at Protocol._enqueue (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/protocol/Protocol.js:144:48)
at Connection.query (/home/thiago/Code/good-food-tracker-api/node_modules/mysql/lib/Connection.js:198:25)
at /home/thiago/Code/good-food-tracker-api/node_modules/db-migrate-mysql/index.js:450:29
at Promise._execute (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/debuggability.js:384:9)
at Promise._resolveFromExecutor (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:518:18)
at new Promise (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:103:10)
at Object.runSql (/home/thiago/Code/good-food-tracker-api/node_modules/db-migrate-mysql/index.js:445:12)
at /home/thiago/Code/good-food-tracker-api/migrations/20200829180451-user.js:32:15
at tryCatcher (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:547:31)
at Promise._settlePromise (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:604:18)
at Promise._settlePromise0 (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:649:10)
at Promise._settlePromises (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/promise.js:729:18)
at _drainQueueStep (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/async.js:93:12)
at _drainQueue (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/async.js:86:9)
at Async._drainQueues (/home/thiago/Code/good-food-tracker-api/node_modules/bluebird/js/release/async.js:102:5)`
What am I doing wrong?

I've noticed that issue my self when using older versions of MariaDB database < 10.4.6.
So if you have a MariaDB version above 10.4.6 it should work. But I'll try and create an sql version of the import file that supports older versions. Because older versions of MariaDB don't support some of the syntax in those queries.
I've successfully imported migrations on versions 10.4.6 and 10.5.5.

I've merged the new version of migrations into the main branch which should allow you to run all the migrations without any issues. Do let me know if there are any problems with it.

We you able to run the migrations since the new update?

Hi, Igor. Sorry about the delay, these days were exhausting. I've tried to run them after your update, but no luck. Some of the tables didn't update. I'll try another run later today and let you know if I succeed, and if doesn't work, I'll share the output with you.

Hey, no worries. I think you will need to delete all the tables first and than run the migrations as I didn't create new ones but rather rewrote the old ones. So it needs to be a clean database for it to succeed.
I tested it on 10.4.1 without any issues, so now it should be good.
When you have the time, try and just let me know. If it still throws errors I'll try and update it more.


An error in appendix A

The last eg in section "16-Bit Floating-Point Number" of appendix A :
0    10100<PHONE_NUMBER>    = 54.375
does it should be 53.3125 not 54.375 ?

Yes, good catch.  2^5 * ( 1 + 682/1024) = 53.3125.  Thanks.


feat(behavior_velocity): find occlusion more efficiently

Description
Occupancy Grid is divided to (free space+occupied space) image & occlusion image(eroded with custom 2 by 2 kernel)
this can

remove redundant grid map occlusion size search
remove sensing noise

Related links
Tests performed
by

planning simulator
scenario simulator

https://user-images.githubusercontent.com/65527974/167342928-54b82c05-128a-45ec-888a-d624500a07da.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

https://user-images.githubusercontent.com/65527974/167342950-c4b9f65e-dfe3-4ec3-a89a-9149bebad4b7.mp4


Detekt complains about line length... about a url... in a kdoc comment

Expected Behavior
Don't complain
Observed Behavior
Complains about a url in a kdoc comment
Your Environment
Using latest stable detekt and gradle. on macOS.

Could you please provide more information such as the rule in violation, your configuration and some example code.

Hi @marschwar, I think @ColtonIdle is referring to the below code
val a = 9 // This is a long comment with the URL at the end https://github.com/detekt/detekt/issues/6209

The above code will give the violation but we can't break the URL

I suppose the rule is MaxLineLength.
We should ignore the lines that contain https:// or http:// as they're generally harder to split.

The reason I was asking for more information is, that MaxLineLength already ignores lines that end on urls.

The reason I was asking for more information is, that MaxLineLength already ignores lines that end on urls.

Yup you're right, I see you have an URL Regex matcher.
@ColtonIdle can you provide a snippet?

Let me try to repro the issue in my project and I'll come back with a snippet!

Hi @marschwar / @cortinico in the code only the URLs at the end place are ignored. @ColtonIdle in your case is the URL coming in between the comments?

Yes. I found the place where I had the issue. Essentially I have
/**
 * This is a problem I'm having which was filed [here]()https://issuetracker.google.com/issues/223217998)
 * and the problem is still occurring so I'm now creating this one off component to handle this
 * issue.
 */

Yes. I found the place where I had the issue. Essentially I have
/**
 * This is a problem I'm having which was filed [here]()https://issuetracker.google.com/issues/223217998)
 * and the problem is still occurring so I'm now creating this one off component to handle this
 * issue.
 */

Yup that's a valid scenario and needs some tweaking

Hi @ColtonIdle I think [here]()https://issuetracker.google.com/issues/223217998) is not valid markdown syntax can you try with [here](https://issuetracker.google.com/issues/223217998) instead and see if the issue is coming or not?

This was addressed in https://github.com/detekt/detekt/issues/5493 and merged in https://github.com/detekt/detekt/pull/5683

@ColtonIdle can you try your snippet again in 1.23.1?

that worked! amazing


Add support for encoding RGB color images

@Who8MyLunch have you had the change to look at this merge request?


Making react-native-animatable a peer dependency

As the title suggest, in my opinion it is better to have react-native-animatable as a peer dependency instead.
I think it is reasonable enough as react-native-animatable is a frequently used library in my experience. The motivation is of course to eliminate unnecessary duplications and move the control over to the user of this library. react-native-animatable changes quite infrequently (judging by the releases on github), so it is very likely that both users' local version and react-native-modal's version will semantically match and it won't cause any pains.
Let me know what you think. Cheers!

Hey @sradevski thanks for starting the discussione!
I think that react-native-animatable should live in the peerDependencies as well but at the same time I'd like to keep the install process super easy and not requiring to install react-native-animatable separately  🤔
Let's keep the issue open an see what everyone else think 👍

Closing for inactivity.


Not found flutter plugin

I installed Android Studio from jet brain toolbox . After that , I install flutter from Stable channel . When I run flutter doctor command in command prompt, flutter cannot found flutter plugin even after installing plugin in Android Studio.
**[√] Flutter (Channel stable, 1.22.6, on Microsoft Windows [Version 10.0.18363.1139], locale en-US)
• Flutter version 1.22.6 at C:\Flutter\flutter
• Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
• Engine revision 2f0af37152
• Dart version 2.10.5
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\Lenovo\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: C:\Users\Lenovo\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7042882\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[!] Android Studio (version 4.1.0)
• Android Studio at C:\Users\Lenovo\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7042882
X Flutter plugin not installed; this adds Flutter specific functionality.
X Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[!] Connected device
! No devices available
! Doctor found issues in 2 categories.**

duplicate of https://github.com/flutter/flutter/issues/75918

I had the same error but when I switching to beta channel all ok.

@elbeicktalat
Seems your issue is resolved. For further reference, check out this comment.
Closing as resolved.


Launch at login

Have an option to launch the app automatically at a new login

I started on #50 but life happened and I dropped the ball.
In the time since, electron added built-in support for launching at login using app.setLoginItemSettings. One drawback is that it only works for macOS and Windows at the moment, whereas the auto-launch npm package works on Linux too.

:sparkles: shipped in 2.3.2


Landing page

Figma link

[ ] Header

[ ] Contact Us -><EMAIL_ADDRESS>[ ] Explore Treasury

Preview

[ ] Hero

[ ] Show the number of treasuries
[ ] Show the total of treasury assets
[ ] Show the bubble chart

[ ] The size of the bubble is determined by the proportion of the treasury amount

Preview

[ ] Dotsama eco

[ ] Bar chart

[ ] Show the treasury fiat money and assets

[ ] Pie chart

[ ] Show the proportion of all treasuries in dotsama eco

Preview

[ ] Dotsama treasury overview

[ ] Show the treasury overview data

[ ] Avaliable assets, spend Period, total income, total output, block height
[ ] Total stacked chart (all time)
[ ] Income and output distribution
[ ] Top beneficiaries

[ ] Supports switching between polkadot and kusama

Preview

[ ] Moblile layout

Figma link
Preview

bubble code, keyword bubble-project
https://github.com/Koniverse/DotInsights/blob/master/src/assets/scss/blocks/_bubbles.scss

Treasury icons
Files
treasury icons.zip

UI review


Redesigned header / footer integration copied from project site.

Description
Integrates the header and footer from the project site for design parity.
The grey bar beneath the navigation header with the "Documentation" header, and the search field has been removed. The search field has been relocated into the header itself.
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@astephanus - Should we close this one in lieu of the one in which you're fixing the spacing?

@astephanus - Should we close this one in lieu of the one in which you're fixing the spacing?

@hdhalter - The spacing fix is included in this PR as well as the PR into 1.3.


[BUG] getgroupmemberlist bug

OpenIM Server Version
3.8.1
Operating System and CPU Architecture
Windows (AMD)
Deployment Method
Source Code Deployment
Bug Description and Steps to Reproduce

Screenshots Link
No response

假如我切换到最新的3.8.2会出现切换账号很卡的bug。而且控制台还有报错说id重复啥的

假如我切换到最新的3.8.2会出现切换账号很卡的bug。而且控制台还有报错说id重复啥的

Does it mean logging out and then logging in with another account? You can collect more complete logs. Logging out requires synchronously waiting for the logout call to complete. At the same time, please ensure that both your server version and client SDK version are the latest.


[SPARK-24542] [SQL] UDF series UDFXPathXXXX allow users to pass carefully crafted XML to access arbitrary files

What changes were proposed in this pull request?
UDF series UDFXPathXXXX allow users to pass carefully crafted XML to access arbitrary files. Spark does not have built-in access control. When users use the external access control library, users might bypass them and access the file contents.
This PR basically patches the Hive fix to Apache Spark. https://issues.apache.org/jira/browse/HIVE-18879
How was this patch tested?
A unit test case

cc @petermaxlee @rxin @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3968/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/78/
Test PASSed.

Test build #91749 has started for PR 21549 at commit 07f71d3.

Test build #91749 has finished for PR 21549 at commit 07f71d3.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91749/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3990/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/99/
Test PASSed.

Test build #91784 has started for PR 21549 at commit 52e706b.

Test build #91784 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91784/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3991/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/100/
Test PASSed.

Merged build finished. Test PASSed.

Test build #91786 has started for PR 21549 at commit 52e706b.

Test build #91786 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91786/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/101/
Test PASSed.

Test build #91787 has started for PR 21549 at commit 52e706b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3992/
Test PASSed.

Test build #91787 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91787/
Test FAILed.

retest this please

Test build #91943 has started for PR 21549 at commit 52e706b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4109/
Test PASSed.

Merged build finished. Test PASSed.

Test build #91943 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91943/
Test FAILed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4114/
Test PASSed.

Merged build finished. Test PASSed.

Test build #91948 has started for PR 21549 at commit 52e706b.

Test build #91948 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91948/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/218/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4119/
Test PASSed.

Test build #91952 has started for PR 21549 at commit 52e706b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/225/
Test PASSed.

Merged build finished. Test PASSed.

retest this please

Test build #91960 has started for PR 21549 at commit 52e706b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/231/
Test PASSed.

Test build #91960 has finished for PR 21549 at commit 52e706b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91960/
Test FAILed.

@HyukjinKwon is it possible that the constant build failure is caused by the java style checker? Other PRs that don't touch java files are fine.

@cloud-fan, I will take a look tonight (singapore timezone). Please feel free to disable it for now to unblock other PRs if you think so. From a very quick look (it's mobile), I think it needs some time.

you can commwnt this line https://github.com/HyukjinKwon/spark/blob/master/dev/run-tests.py#L577 and add pass instead.

If you think it's not super urgent, please give me few days. I have some speculations about it. Will test it and try a fix tomorrow as soon as we can access to Jenkins results.

retest this please

Test build #92021 has started for PR 21549 at commit 52e706b.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4167/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/273/
Test PASSed.

Test build #92021 has finished for PR 21549 at commit 52e706b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92021/
Test FAILed.

Test build #92033 has started for PR 21549 at commit f9a9f68.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4176/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/282/
Test PASSed.

Test build #92033 has finished for PR 21549 at commit f9a9f68.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92033/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/287/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4181/
Test PASSed.

Test build #92042 has started for PR 21549 at commit f9a9f68.

Test build #92042 has finished for PR 21549 at commit f9a9f68.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92042/
Test FAILed.

retest this please

Test build #92053 has started for PR 21549 at commit f9a9f68.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4192/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/298/
Test PASSed.

Test build #92053 has finished for PR 21549 at commit f9a9f68.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92053/
Test PASSed.

thanks, merging to master/2.3!


Separation of model agnostic forcing preparation from other modelling files

I suggest separating the modeling files and forcing manipulation into two separate folders or steps. For example, the subfolders of folder 03-model-specific can be like this:

03-model-specific:

MESH:
- Forcing
- File
HYPE:
- Forcing
- File
MESH:
- Forcing
- File

The user then can set up a model without any specific forcing in hand. We can also centralize the Forcing manipulation in a more centralized way that can be easier called (actually then it would be kind of model agnostic).
The model agnostic part can also follow the same logic. I understand currently it is possible, but it would be cleaner to separate the data tool and remap call and the gistool separately.

The current agnostic workflow appears to be functioning effectively across multiple applications I have encountered thus far, and making modifications would require more time than I can presently allocate to this project.
I trust that there may be another individual available who can adeptly refine the workflow in alignment with your vision.


News on PH

still can't get new from Philippines
i tried
news_country_code = 'en_PH'  &  'PH'
and
news_country_code ='us'
they're the same, USA news.
can you help me?

use en_ph

https://news.google.com/news?ned=en_ph&output=rss


CRLP: Rollup Grouping Refactor to fix bug with YearsAgo rollup not working

Refactor the CRLP_Rollup class and more specifically the grouping logic to:

Fix a bug with how Rollup records were grouped especially when DaysAgo, YearsBack or Count operations are involved; especially with Single Result operations (First/Last/Largest/Smallest).
Reduce the heap size used by CRLP_Rollup instances

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-030691

Tracking W-030691

Included in beta release 3.156 (Beta 13)


feat: add a seed value to test runs

Summary
Context from this conversation.
jest will now generate a seed value when running via the CLI. This seed can be accessed in the runtime via jest.getSeed().
You can also manually specify the seed with --seed=1234.

Test plan

https://user-images.githubusercontent.com/81541956/194540773-e9ffcc3a-75b5-4f6f-b06a-9aef4b296393.mov

@mrazauskas any other comments? If not, I'll merge 🙂

Thanks! Looks like all is done.

https://github.com/facebook/jest/releases/tag/v29.2.0


N15 ggez

Trying to sneak this in at the last moment, if you don't mind.
Supercedes #343
Part of #320 ("Newsletter 15")

Merged, thanks for the PR!


healthCheck fail when externalTrafficPolicy is set to Local on a loadBalancer service with NLB

What happened:
I tried to set up a service with an NLB with the property externalTrafficPolicy set to Local in order to keep the sourceIP so I followed this blog post:
https://aws.amazon.com/fr/blogs/opensource/network-load-balancer-support-in-kubernetes-1-9/
All Instances are declared unhealthy by the NLB and it should not.
What you expected to happen:
According to the post, at least one node should be  healthy and the traffic should be correctly routed to the pod on the healthy node.
How to reproduce it (as minimally and precisely as possible):

Create an EKS cluster using the version 1.19.eks3 with two node

Deploy the nginx pod:
kubectl run nginx --image=nginx --port=80 --labels app=nginx

Deploy the nginx service

kind: Service
metadata:
  name: nginx
  namespace: default
  labels:
    app: nginx
  annotations:
    service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
spec:
  externalTrafficPolicy: Local
  ports:
  - name: http
    port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app: nginx
  type: LoadBalancer

Anything else we need to know?:
We tested this on a native kubernetes cluster deployed on EC2 with the same version (1.19.8) and it works.
Environment:

EKS Distro Release: 1.19.8 (1.19.eks3)

Thank you for opening this issue.
How did you create the EKS-D cluster? Can you also confirm if the version used was v1.19.6-eks-1-19-3?

That article you linked is for Kubernetes 1.9 an we are only supporting 1.18 and 1.19 right now, so it could be the source for your information is out of date.

Thank you for opening this issue.
How did you create the EKS-D cluster? Can you also confirm if the version used was v1.19.6-eks-1-19-3?

I used terragrunt and AWS CLI to deploy a cluster on Amazon EKS. According to the AWS doc, the distro version is 1.19.eks.3.
https://docs.aws.amazon.com/eks/latest/userguide/platform-versions.html

That article you linked is for Kubernetes 1.9 an we are only supporting 1.18 and 1.19 right now, so it could be the source for your information is out of date.

Indeed it's an article for Kubernetes 1.9 announcing the support of the NLB on AWS. But since Kubernetes 1.9 is older than the 1.19 version, I'm sure all the feature from Kubernetes 1.9 are supported on AWS. Except the one that were deleted during the release between both.
However, like I said in my issue: using an EKS cluster with the kubernetes version 1.19.8 this doesn't work. Using a kubernetes cluster deployed on my own with the same version, this is working.

it normally happens when your nodeName is different from your hostName. e.g. you have a custom DHCP options.
if that's the case, please patch your kube-proxy daemonset as https://gist.github.com/M00nF1sh/84d380b4e08017a5bc958658f7010914

it normally happens when your nodeName is different from your hostName. e.g. you have a custom DHCP options.
if that's the case, please patch your kube-proxy daemonset as https://gist.github.com/M00nF1sh/84d380b4e08017a5bc958658f7010914

Thanks for your help, but how can I patch the kube daemonset on EKS ?
Or how to avoid having a nodeName different from the hostName ?


Setup a comment system

Please don't use disqus.com. It's a privacy nightmare.
muut.com would be an alternative but they don't allow deleting messages and possibly the expected amount of comments would exceed their free plan.
If rebuilding the site often is o.k., this might be a solution: https://vectronic.io/posts/self-hosted-comments-on-a-hugo-website/


Structure the theme Page

structure the theme page so that every developer can understand that.

assign it to me