why /apps/prapp/reviews path ?

https://github.com/Shopify/product-reviews-sample-app/blob/ab5e5f09e76d83b950e02f4ae8b649455a0a694c/theme-app-extension/assets/product-reviews-form.js#L26

As far as I know this act as app proxy such that the user cannot directly call your api backend routes for better security.
so its actually calling /api/reviews in your backend. apps as prefix and prapp as subpath as mentioned in DOC.

what / where is the file that handles this request?

This example uses an app-proxy to ensure a user cannot call the API directly. This is, as @tommy921092 pointed out, for improved security. There's plenty of info about app proxies on shopify.dev
The way it works in this repository is the theme extension calls out to the proxy /apps/prapp/reviews:
https://github.com/Shopify/product-reviews-sample-app/blob/435ebf4b1b2d30c0372f11c42a41ae4ad5c96b10/theme-app-extension/assets/product-reviews-form.js#L26
And the main application serves the API /api/reviews
https://github.com/Shopify/product-reviews-sample-app/blob/435ebf4b1b2d30c0372f11c42a41ae4ad5c96b10/server/server.js#L217-L224
The documentation calls out that if you're using this example you should be adding a /apps/prapp app proxy (see Step 7). So, effectively, calls to /apps/prapp/reviews are going to /api/reviews
https://github.com/Shopify/product-reviews-sample-app/blob/main/docs/getting-started.md#7-set-up-the-app-proxy-extension
Hope this clears things up!


Target: pass through "background_page" types

Related to https://github.com/GoogleChrome/puppeteer/issues/2438.
The lighthouse chrome extension tests check a private target._targetInfo property to verify the target is the LH background page:
const targets = await browser.targets();
const extensionTarget = targets.find(({_targetInfo}) => {
  return _targetInfo.title === 'Lighthouse' && _targetInfo.type === 'background_page';
});

We should pass through this type through so target.type() works as expected. We currently mark it as "other":
https://github.com/GoogleChrome/puppeteer/blob/e9dc3ae74fc01a99d1d5b66ffe716b4de4aa39e8/lib/Target.js#L58-L63

This is fixed by https://github.com/GoogleChrome/puppeteer/pull/2493.


Some more cargo orders plus sliceable cabbages

Description
Adds in a couple of new orders you can make at the cargo request terminal. Also make cabbages sliceable.
Cabbage leaves are obtainable from cutting cabbages. The leaves are unusable in cooking though, so they're only good for raw eating.

Exotic meats crate: $2500
contains a random assortment and quantity of some more exotic meats to cook and use. Requires kitchen access to open.

Fox crate: $1200
contains two foxes.

Cabbage crate: $500
contains 12 cabbages.

Science materials crate: $3000
contains a stack of plasma, plasteel and plastic. Requires science access to open.

APE crate: $2000
contains an APE unit and an anomaly scanner. Intended to be bought if the starting APE has been destroyed and anomaly tech is not researched or is impossible to get. Requires science access to open.

Media
Changelog
:cl: SomeCabbage

add: Added a few new cargo orders to the request terminal. Includes the Fox crate, Exotic meats, and more.
add: Cabbages can now be cut into leaves (request by Pspritechologist)

hold on the crate isnt actually getting kitchen access for some reason

fixed it by making a dedicated secure freezer

oh shoot I didnt check the prices

oh shoot I didnt check the prices

if only tests worked..

changed the values again to be even more appropriate. The meat crate will stay at 2.5k due to it being a gamble

that actually sounds like a decent idea


Mysql DB connection not working

Hi ,
when i try to connect to Mysql DB it throws an error as General Error <class 'sqlalchemy.exc.StatementError'>"
Please let us know
thanks
Mohan

My SQL connection is working fine for me. Could you include a stack trace
for the error you're receiving?
On Wed, 18 May 2016 12:56 Mohan Guruswamy<EMAIL_ADDRESS>wrote:

Hi ,
when i try to connect to Mysql DB it throws an error as General Error "
Please let us know
thanks
Mohan
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/airbnb/caravel/issues/482

--

Alan Cruickshank
E<EMAIL_ADDRESS>T: +44<PHONE_NUMBER>

3  months without reporter feedback, closing


UCP: hot region schedulr supports store weight

Description
Currently, PD's schedulers cannot handle the heterogeneous problem, we use <leader_weight>, <region_weight>  to identify the processing power of the machine. but the hot region scheduler cannot consider it very well, we need to let the hot region to aware weight.
Score

1294

Recommended Skills

Golang

/pick-up-challenge

/give-up-challenge

Sorry, I have been relatively busy recently, and I hope others can continue this optimization.

@mantuliu  thank you.


v0.0.17

Two small changes plus a version bump:

You can now call scipiper:::get_dependency_status('targetname') without writing all the code to get a remake_object. This is still an internal function but has been proving its worth for debugging recently.

In task plans, objects with complex names (e.g., 'nhdhr_23094-019867') were giving trouble in the combiner call, where remake failed to parse them. This PR adds tick quotes (`) around objects in the combiner calls by default. You might want to skip this change for current built task plans, in which case you can specify tickquote_combinee_objects = FALSE in the call to create_task_makefile so that your task plan stays unchanged. If you do this, you'll get a warning about this argument being deprecated (already, even though this PR introduces it) because in the long run I think we'll be better off with always tickquoting.

@jread-usgs Since you've already looked, do you mind reviewing/approving/merging this PR?


Docker compose configuration

Hello, congrats for the cool project.
I thought spinning up cartography together with a Neo4j database in docker would be nice for people curious to use cartography without having to install Neo4j to their computers.
This is a simple bare-bones configuration for docker-compose.
Cheers!

Sorry, forgot to sign the CLA, just did it.

@dggc Tks for making the first contribution to the project. Will review/test and approve this week.

Applied the pull request to my local git repo, but was unable to get it working:
cartography_1  | INFO:cartography.sync:Starting sync with update tag '1554236889'
cartography_1  | INFO:cartography.sync:Starting sync stage 'create-indexes'
cartography_1  | INFO:cartography.intel.create_indexes:Creating indexes for cartography node types.
cartography_1  | INFO:cartography.sync:Finishing sync stage 'create-indexes'
cartography_1  | INFO:cartography.sync:Starting sync stage 'aws'
cartography_1  | ERROR:cartography.sync:Unhandled exception during sync stage 'aws'
cartography_1  | Traceback (most recent call last):
cartography_1  |   File "/usr/local/lib/python3.7/site-packages/botocore/auth.py", line 357, in add_auth
cartography_1  |     raise NoCredentialsError
cartography_1  | botocore.exceptions.NoCredentialsError: Unable to locate credentials
docker_cartography_1 exited with code 1

$ cat ~/.aws/config
[default]
region = us-east-1

$ cat ~/.aws/credentials
[user1]
aws_access_key_id = <redacted>
aws_secret_access_key = <redacted>
aws_session_token = <redacted>

[user2]
aws_access_key_id = <redacted>
aws_secret_access_key = <redacted>
aws_session_token = <redacted>

@heydonovan I tested this on Ubuntu 16.04, using Bash as my shell. I've referenced the environment variable $HOME as a way to reference the home directory. Maybe the issue is there? Do you have any suggestions on how to make this more system agnostic, if this is the case?

@heydonovan You can also try running docker-compose run cartography ls -al /root/.aws to check if your credential files got copied over to docker correctly.
Another thing you can try is removing --aws-sync-all-profiles to see if it will work with just one profile.

Closing this as we are not accepting deployment/containerization configuration changes. See #159 for further discussion on this topic.


Fix v1-engine-changed label event

The workflow build.yml was not triggered at PR updated.
The workflow integration-tests.yml was triggered no matter what label name because the syntax was wrong.

I tried the on.pull_request.types: synchronize, edited does not work. Pending this issue #578 in the future.


Click & tracking service getting 404 error

Can be relationated with #914
When we create one click & tracking subdomain, with or without SSL configuration, all URLs get 404 error.
One example of error log:
<IP_ADDRESS> - - [05/Nov/2019:21:48:04 +0000] "GET /404 HTTP/1.0" 404 1564 0.2122

When I access
https://click.notifications.xxxxxxx.com/ctqu6f/H0zoVR7I
Clearly HTTP server not find the file, so I interpret that are some misconfiguration about how to interpret the URL or something is broking at "cick & tracking" service.
I uses "quick install guide" that execute a shell script. And I double checked every configuration reading full install guide from documentation.

I am using Ubuntu 16.04
I am using latest Postal version (confirmed when I do postal auto-upgrade command).
All configurations asked to do in https://github.com/atech/postal/wiki/Domains-&-DNS-Configuration are done.

Is there a way to set some debug mode to troubleshoot this?

track.subdomain.domain.com point to dedicated IP on postal server configured postal.yml. And all click & tracking subdomains are cname to track.subdomain.domain.com, and I checked the dns lookups and they get same IP address on server.

If you access http://click.notifications.xxxxxxx.com then you should see a Hello. from the fast server. If you don't see that then you could use netstat -lnp on the server and postal status to be sure that the fast server is running and is listening on ports 80 and 443 on the IP address that matches what you think it should be.

If you access http://click.notifications.xxxxxxx.com then you should see a Hello. from the fast server. If you don't see that then you could use netstat -lnp on the server and postal status to be sure that the fast server is running and is listening on ports 80 and 443 on the IP address that matches what you think it should be.

Fast server is not running. I configured zabbix server with postal template today and I saw that. Then you sent this message then. I will try to fix that.

There are no logs about fast_server when I restart postal service. If the fast_server IP is configured on IP Pool (even without use), it can block fast_server to start?
I will try to check that.

I tried with IP added on IP pool and without on IP pool (postal web interface) and in both cases did not work. I read the postal fast_server ruby code about bind this IP and I not found any kind of test if the IP is or not is added on IP pool.

https://github.com/atech/postal/blob/master/lib/postal/fast_server/server.rb

There are no logs in "/opt/postal/logs" about fast_server or relationated about.

I tried to declare all possible vars on fast_server config on postal.yml, but no success to get some log.
fast_server:
  # This can be enabled to enable click & open tracking on emails. It is disabled by
  # default as it requires a separate static IP address on your server.
  enabled: true
  bind_address: x.y.z.w
  port: 80
  ssl_port: 443
  proxy_protocol: false
  default_private_key_path: /opt/postal/config/fast_server.key
  default_tls_certificate_path: /opt/postal/config/fast_server.cert

And cert permissions are ok:
-rw-r--r-- 1 postal postal 1931 Nov  6 17:44 fast_server.cert
-rw-r--r-- 1 postal postal 1704 Nov  6 17:44 fast_server.key

If I did not see any error about bind IP address fail in https://github.com/atech/postal/blob/master/lib/postal/fast_server/server.rb , I think the server is not be executed for someone.
Befora I try do some debug on code, I left
  bind_address:

empty and tried restart the server. Finally I get a file called "fast_server.log" with some messages:
^[[34m[fast.1:8789]^[[0m [2019-11-12T16:11:19.779] INFO -- : Cannot start fast server because no bind address has been specified

Then I configured the IP again and the log file is not updated anymore.
The IP is working and is dedicated to this feature. I can ping and access ssh from this IP, so it is working (only to help understand the scenario, because I know the application not test this).

Then I configured the IP again and the log file is not updated anymore.

I saw in
https://github.com/atech/postal/blob/634d3af59d392e84bdcd2b843b427f3a79d3ff4c/lib/postal/fast_server/server.rb#L20
If bind fail, there are no logs about bind fail.

in this situation, I would use postal status to see what the command to run the fast_server is and then run that command myself to see what the output from it is

postal status result
 * fast.1 is not running (Failed)

|| fast
|| Quantity            1
|| Command             bundle exec rake postal:fast_server
|| Respawning          5 every 3600 seconds
|| Restart mode        term-start
|| Log path            none specified
|| Address/Port        none
|| => fast.1           Failed       16:12        pid:9066     respawns:5      port:-        tag:-

If you haven't already, run bundle exec rake postal:fast_server to see what the problem might be

I did:
postal@s54797:~/app/bin$ bundle exec rake postal:fast_server
(in /opt/postal/app)
rake aborted!
Errno::EADDRINUSE: Address already in use - bind(2) for "x.y.z.w" port 80
/opt/postal/app/lib/postal/fast_server/server.rb:21:in `initialize'
/opt/postal/app/lib/postal/fast_server/server.rb:21:in `new'
/opt/postal/app/lib/postal/fast_server/server.rb:21:in `block in run'
/opt/postal/app/lib/postal/fast_server/server.rb:20:in `each'
/opt/postal/app/lib/postal/fast_server/server.rb:20:in `each_with_object'
/opt/postal/app/lib/postal/fast_server/server.rb:20:in `run'
/opt/postal/app/lib/tasks/postal.rake:33:in `block (2 levels) in <top (required)>'
rake:4:in `<top (required)>'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:74:in `load'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:74:in `kernel_load'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli/exec.rb:28:in `run'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli.rb:465:in `exec'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli.rb:27:in `dispatch'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/cli.rb:18:in `start'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/exe/bundle:30:in `block in <top (required)>'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
/var/lib/gems/2.3.0/gems/bundler-2.0.2/exe/bundle:22:in `<top (required)>'
/usr/local/bin/bundle:22:in `load'
/usr/local/bin/bundle:22:in `<main>'
Tasks: TOP => postal:fast_server
(See full trace by running task with --trace)

Then I verified the nginx default configuration of postal service and I saw default config files listening <IP_ADDRESS> on 80 port. Then I changed to IP:80 (nginx /etc/nginx/sites-enabled/default file) and started Postal service. Now it works.
|| fast
|| Quantity            1
|| Command             bundle exec rake postal:fast_server
|| Respawning          5 every 3600 seconds
|| Restart mode        term-start
|| Log path            none specified
|| Address/Port        none
|| => fast.1           Running      00:39        pid:16770    respawns:0      port:-        tag:-

So I recommend update the manual guide to show this information and change the quick install script to avoid "<IP_ADDRESS>" configuration, because it will block fast server to start if <IP_ADDRESS> is used in nginx.
Thank you for all help.

Glad you got it sorted.
Using a different IP address can't really be automated without a lot of work to detect IP addresses on the system and replacing them in the files. Also some server configurations will be different so blindly replacing IP addresses in files wouldn't be good for everyone.
Admittedly it is easily missed, I seem to remember doing the same initially, but it is in the documentation already https://github.com/postalhq/postal/wiki/Click-&-Open-Tracking#enable-the-fast-server


Stylua

add stylua.toml for formatting

would need to format the whole repo first so i suggest merging #137 and related PRs first


Implement a join-with-separator block

Many languages have a join function that can join elements of an array using a given separator. For example, in Javascript:
['a', 'b', 'c'].join(',') === 'a,b,c'

will be true. Right now, one needs to implement their own version of this function in App Inventor because the join operator we provide only joins one or more given string values provided via the block mutator. It would be convenient to have a block that provides similar functionality. Given that this block would only be applicable to lists, I think we should put it under the list block category, and I propose the text be join items using separator %1  list %2

If you make this block, look at how test split is done with a dropdown that
allows people to have split and splitAtFirst as variants of the same basic
block.
so join and join-with-separator could be similar variants
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Fri, Feb 22, 2019 at 5:47 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

Many languages have a join function that can join elements of an array
using a given separator. For example, in Javascript:
['a', 'b', 'c'].join(',') === 'a,b,c'
will be true. Right now, one needs to implement their own version of this
function in App Inventor because the join operator we provide only joins
one or more given string values provided via the block mutator. It would be
convenient to have a block that provides similar functionality. Given that
this block would only be applicable to lists, I think we should put it
under the list block category, and I propose the text be join items using
separator %1 list %2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1577, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAwLtynu5XxqZ3o4z90gOmmK8F7YnLXiks5vQHNogaJpZM4bLu2E
.

@halatmit My concern with that approach (although I can’t verify at the moment on mobile) is that the split block variants have the same arity, argument types, and return type. The join and join-with-separator blocks would have different arity and input types, so switching between the two would immediately need to disconnect any connected blocks.
Sent from my iPhone

On Feb 22, 2019, at 18:49, hal<EMAIL_ADDRESS>wrote:
If you make this block, look at how test split is done with a dropdown that
allows people to have split and splitAtFirst as variants of the same basic
block.
so join and join-with-separator could be similar variants
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Fri, Feb 22, 2019 at 5:47 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

Many languages have a join function that can join elements of an array
using a given separator. For example, in Javascript:
['a', 'b', 'c'].join(',') === 'a,b,c'
will be true. Right now, one needs to implement their own version of this
function in App Inventor because the join operator we provide only joins
one or more given string values provided via the block mutator. It would be
convenient to have a block that provides similar functionality. Given that
this block would only be applicable to lists, I think we should put it
under the list block category, and I propose the text be join items using
separator %1 list %2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1577, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAwLtynu5XxqZ3o4z90gOmmK8F7YnLXiks5vQHNogaJpZM4bLu2E
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I realze that the arity would change, but maybe there's a way to make it
work - but I haven't tried doing that.   another idea is to alway include
the separator argument and default it to empty.
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Fri, Feb 22, 2019 at 7:05 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

@halatmit My concern with that approach (although I can’t verify at the
moment on mobile) is that the split block variants have the same arity,
argument types, and return type. The join and join-with-separator blocks
would have different arity and input types, so switching between the two
would immediately need to disconnect any connected blocks.
Sent from my iPhone

On Feb 22, 2019, at 18:49, hal<EMAIL_ADDRESS>wrote:
If you make this block, look at how test split is done with a dropdown
that
allows people to have split and splitAtFirst as variants of the same
basic
block.
so join and join-with-separator could be similar variants
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Fri, Feb 22, 2019 at 5:47 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

Many languages have a join function that can join elements of an array
using a given separator. For example, in Javascript:
['a', 'b', 'c'].join(',') === 'a,b,c'
will be true. Right now, one needs to implement their own version of
this
function in App Inventor because the join operator we provide only
joins
one or more given string values provided via the block mutator. It
would be
convenient to have a block that provides similar functionality. Given
that
this block would only be applicable to lists, I think we should put it
under the list block category, and I propose the text be join items
using
separator %1 list %2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1577, or mute
the
thread
<
https://github.com/notifications/unsubscribe-auth/AAwLtynu5XxqZ3o4z90gOmmK8F7YnLXiks5vQHNogaJpZM4bLu2E

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1577#issuecomment-466590493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwLt6SsrTJhYiidy2Nvf0jLZgbsV5TJks5vQIW7gaJpZM4bLu2E
.

I would like to help out on this issue!
I believe that choosing the option proposed by @ewpatton would be more suitable for implementing this block, and as mentioned above, setting the separator to the "" could be the default, which would act as joining multiple strings together (except the types would not necessarily be text)
Before working on the issue (if, of course, it's still available to work on), I would like to know if this approach is correct to adding the block:
1.Modifying appinventor\blocklyeditor\src\blocks\lists.js by adding a new element to Blockly.Blocks and setting up all the relevant properties
2.Modifying appinventor\blocklyeditor\src\generators\yail\lists.js by adding the relevant functionality which will handle taking a list & separator arguments and constructing a new String (text object) with the specified parameters
3.Modifying _messages.js in appinventor-sources\appinventor\blocklyeditor\src\msg to include the new block messages. Should a placeholder be used for other languages than English, or simply not modified at all? (Also, these messages should be included in step 1's edit)
4.Writing tests, proper documentation, making sure these are all committed on my own fork & branch, and then making the final pull request with the changes
Is there anything else that would be required to carry out this issue? So far I have played around with steps 1 & 2 and have managed to add a block with it's own functionality, I feel like that should be sufficient?

For this block, my vision was for it to take two arguments, the separator and the list, making it semantically equivalent to the JavaScript join function as I presented it above. The current join block would then be equivalent to join-with-string(separator: "", list: make-a-list(...))

@ewpatton So if I understood this correctly, the block should look something like this:

And the result of this should be the text object: '1-2-5-9'
Is that correct? In which case, in my eyes, I believe this would be the suitable way to proceed with this idea. I would love to work further with this issue and  look into implementing the actual block functionality if this approach is well-suited for adding this block.

@lightingft Yes this matches what I have in my head. If you want to implement this one, it's yours.

@ewpatton I would definitely like to implement this block. Feel free to assign me to the issue!

+1
== Hal
Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
On Mon, Mar 4, 2019 at 3:36 PM Evan W. Patton<EMAIL_ADDRESS>wrote:

For this block, my vision was for it to take two arguments, the separator
and the list, making it semantically equivalent to the JavaScript join
function as I presented it above. The current join block would then be
equivalent to join-with-string(separator: "", list: make-a-list(...))
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mit-cml/appinventor-sources/issues/1577#issuecomment-469411612,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwLt_Dro3Dglb5N8fFWJDLlz5zYES_mks5vTYOcgaJpZM4bLu2E
.

@lightingft I invited you to join our external collaborators group. Once you do so I can assign you the issue.

Resolved by ceb27bf233d93e61ef741e9255149e1bb3e8ff8c


feat: add gRPC 1.65.0RC2 release

update gRPC with release 1.65.0RC2

:tada: This issue has been resolved in version 1.323.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update text for adding repository secret

The text in the button that you are required to press did not match the instructions. Below is a screenshot of what I see...

Thanks! I've added this to #276

Thanks. Would be nice to get a merge/commit next time to acknowledge the effort to open the PR.


Review/Update Terms and Conditions

FEATURE REQUEST
What do you want to happen
The linked terms and conditions mention Hack UPC -- we need to get these reviewed and personalized for us
Anything else we need to know?

Marking this as medium as it involves legalese and I'm not prelaw


Support Image Sitemap's

Google's documentation on SiteMap support highlights some anomalies with
regards to the above SiteMap type.
We should consider supporting such functionality.

https://support.google.com/webmasters/answer/178636?hl=en&ref_topic=4581190

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 11 Apr 2014 at 7:21

More generally this is about how to handle extensions of the basic sitemap protocol. Google seem to have developed a whole range of them for news etc...  A source of inspiration could be how ROME  [http://rometools.github.io/rome/] deals with extensions of the feeds, see ForeignMarkup in  [https://github.com/rometools/rome/blob/master/src/main/java/com/rometools/rome/feed/WireFeed.java#L234]

Rome handles this by returning a list of DOM elements (actual JDOM2 elements), so that it's able to handle pretty much anything that could be found as "extras". If we did the same, we'd be coercing whatever additional data we found in a sitemap into a DOM structure...does that seem OK?


Disable nested cons eval

A couple more tests in clvm:develop break without this change.

Oh shoot, it breaks the benchmarks. @arvidn I can help you with these later if you need it.

Basically, replace ((c PROG ARGS)) with (a PROG ARGS) and (a ATOM ARGS) with (ATOM ARG1 ARG2 ...) (quoting ARGn individually if necessary).

Probably easiest just to recompile everything.


#2 - Improving README, vitest settings and added vitest ui

resolve #2

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6d22d37). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   77.27%
=========================================
  Files             ?        3
  Lines             ?       22
  Branches          ?        5
=========================================
  Hits              ?       17
  Misses            ?        0
  Partials          ?        5

Flag
Coverage Δ

unittests
77.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


WSL segfault

Reported at https://forum.spinalcordmri.org/t/segmentation-fault-core-dumped/660/: something is causing a segfault when running
sct_maths -i [linmin.nii.gz](https://osf.io/download/uxtm6) -mean t -o dmri_mean.nii.gz

There is so far very little to go on here. My best clue is that this is WSL (which we don't test very thoroughly), which you can see in the OS line:

OS: linux (Linux-4.4.0-19041-Microsoft-x86_64-with-debian-buster-sid)

I tried to reproduce it with WSL (and in the process make such reproductions themselves more reliable: https://github.com/neuropoly/internal_tools/issues/14 -- still working on this) but failed, like jcohenadad did on macOS.
I noticed that the Debian Microsoft provides at https://aka.ms/wsl-debian-gnulinux is not the one listed by the user. When I tried to repro I got:

OS: linux (Linux-4.4.0-18362-Microsoft-x86_64-with-debian-10.8)

Also their's said:

Using bundled python 3.6.13 | packaged by conda-forge | (default, Feb 19 2021, 05:36:01)
[GCC 9.3.0] at /home/forest/sct/python/envs/venv_sct/bin/python

but mine said

Using bundled python 3.6.13 |Anaconda, Inc.| (default, Feb 23 2021, 21:15:04)
[GCC 7.3.0] at /home/user/sct/python/envs/venv_sct/bin/python

which is..weird isn't it? If they installed sct using our installer shouldn't they be using anaconda python? Not conda-forge python? Maybe they're hitting this bug: https://github.com/neuropoly/spinalcordtoolbox/issues/3029. But we fixed that, didn't we? Plus the path is right: /home/forest/sct/python/.
So I don't know how they got '-buster-sid' there. Or actually why it would say "buster-sid". A key point is that "sid" is Debian's synonym for "testing"; and also, unlike the rest of Debian, it's a rolling-release distro. According to https://www.debian.org/releases/ 'buster' was 'sid' a while ago, but now 'bullseye' == 'sid', so I don't know what 'buster-sid' is supposed to mean; maybe their system is both stuck in the past and the future at the same time?
In their history you can see:
   19  sudo cp /etc/apt/sources.list /etc/apt/sources.list.20210305
   20  sudo vim sources.list

So I suspect they followed a guide like this to upgrade their WSL image to a newer one, but that they did that months ago. Plus they don't seem to have ever run apt-get dist-upgrade, just apt-get upgrade which doesn't do the same thing (shakes fist at apt). So I bet they have some unusual mixture of libraries that's not helping things.
Still a segfault is a segfault and if there's a way to segfault our code it means there's probably a bug. Just because the particular versions we test against don't crash doesn't mean there's not a problem lurking. Maybe this user is a canary, testing newer libraries than we test against, and we should thank them for the early warning.

The entire other avenue is: they reported the segfault went away by changing some file permissions: https://forum.spinalcordmri.org/t/segmentation-fault-core-dumped/660/14. Which just makes very little sense to me but I've seen stranger things.
I'm hoping to get some more details from them tomorrow.

I'm also upgrading Windows to match them. But the only one available to me is 19042 not 19041; hopefully that's close enough:

Since the issue is solved on the user end of things, and because this is a hard-to-pin-down isolated incident, do you think we could close this issue for now, @kousu ?


Fix compilation on OS X with GCC 7

Compilation failed with
In file included from src/tree/tree_updater.cc:6:0:
include/xgboost/tree_updater.h:75:46: error: 'function' is not a member of 'std'
                                         std::function<TreeUpdater* ()> > {

caused by a missing <functional> include.

Thanks. I also faced this error while using gcc-7 to compile.
Also, '/src/data/sparse_batch_page.h',need the same modified.

Also, '/src/data/sparse_batch_page.h',need the same modified.

Hm, I didn't have any issues with it. Is it the same header?

I downloaded the fixes on both tree_updater.h and sparse_batch_page.h. I still can not compile it. I have Windows 10 Professional, Python 3.6 and mingw-w64 version 7.1. It did get rid the error messages mentioned by superbobry and ClimberPG.   Do i need to reboot my machine before the latest build attempt after I downloaded the two new files? Below is the error message I got at the end.
Makefile:117: recipe for target 'build/tree/updater_fast_hist.o' failed
mingw32-make: *** [build/tree/updater_fast_hist.o] Error 1
mingw32-make: *** Waiting for unfinished jobs....
I also have a lot of warning messages such as:
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_refresh.cc:8:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'dmlc::optional::~                                                      optional() [with T = int]':
dmlc-core/include/dmlc/./parameter.h:513:7:   required from here
dmlc-core/include/dmlc/././optional.h:60:7: warning: dereferencing type-punned p                                                      ointer will break strict-aliasing rules [-Wstrict-aliasing]

Could you add the whole build output?

Sure, superbobry. I followed the steps from below link which you also followed:
https://www.ibm.com/developerworks/community/blogs/jfp/entry/Installing_XGBoost_For_Anaconda_on_Windows?lang=ru
$ cd dmlc-core
$ make -j4
$ cd ../rabit
$ make lib/librabit_empty.a -j4
$ cd ..
$ cp make/mingw64.mk config.mk
$ make -j4
The issue appears to be with the last step only. Below is the full build output.
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/tree_updater.cc:6:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'dmlc::optional::~optional() [with T = int]':
dmlc-core/include/dmlc/./parameter.h:513:7:   required from here
dmlc-core/include/dmlc/././optional.h:60:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
reinterpret_cast<T*>(&val)->~T();
^~~~~~~~~~~~~~~~
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::value() const [with T = int]':
dmlc-core/include/dmlc/./parameter.h:872:9:   required from here
dmlc-core/include/dmlc/././optional.h:106:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/registry.h:13:0,
from include/xgboost/tree_updater.h:11,
from src/tree/tree_updater.cc:6:
dmlc-core/include/dmlc/./logging.h: In instantiation of 'dmlc::LogCheckError dmlc::LogCheck_GT(const X&, const Y&) [with X = long long unsigned int; Y = int]':
include/xgboost/./tree_model.h:591:3:   required from here
dmlc-core/include/dmlc/./logging.h:91:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
dmlc-core/include/dmlc/./logging.h:76:9:
if (x op y) return LogCheckError();
~~~~~~
dmlc-core/include/dmlc/./logging.h:91:24:
DEFINE_CHECK_FUNC(_GT, >)
dmlc-core/include/dmlc/./logging.h:76:11: note: in definition of macro 'DEFINE_CHECK_FUNC'
if (x op y) return LogCheckError();
^~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/tree_updater.cc:6:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::operator*() const [with T = int]':
dmlc-core/include/dmlc/././optional.h:134:11:   required from 'std::ostream& dmlc::operator<<(std::ostream&, const dmlc::optional&) [with T = int; std::ostream = std::basic_ostream]'
dmlc-core/include/dmlc/./parameter.h:877:13:   required from here
dmlc-core/include/dmlc/././optional.h:97:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_prune.cc:8:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'dmlc::optional::~optional() [with T = int]':
dmlc-core/include/dmlc/./parameter.h:513:7:   required from here
dmlc-core/include/dmlc/././optional.h:60:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
reinterpret_cast<T*>(&val)->~T();
^~~~~~~~~~~~~~~~
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::value() const [with T = int]':
dmlc-core/include/dmlc/./parameter.h:872:9:   required from here
dmlc-core/include/dmlc/././optional.h:106:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/registry.h:13:0,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_prune.cc:8:
dmlc-core/include/dmlc/./logging.h: In instantiation of 'dmlc::LogCheckError dmlc::LogCheck_GT(const X&, const Y&) [with X = long long unsigned int; Y = int]':
include/xgboost/./tree_model.h:591:3:   required from here
dmlc-core/include/dmlc/./logging.h:91:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
dmlc-core/include/dmlc/./logging.h:76:9:
if (x op y) return LogCheckError();
~~~~~~
dmlc-core/include/dmlc/./logging.h:91:24:
DEFINE_CHECK_FUNC(_GT, >)
dmlc-core/include/dmlc/./logging.h:76:11: note: in definition of macro 'DEFINE_CHECK_FUNC'
if (x op y) return LogCheckError();
^~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_prune.cc:8:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::operator*() const [with T = int]':
dmlc-core/include/dmlc/././optional.h:134:11:   required from 'std::ostream& dmlc::operator<<(std::ostream&, const dmlc::optional&) [with T = int; std::ostream = std::basic_ostream]'
dmlc-core/include/dmlc/./parameter.h:877:13:   required from here
dmlc-core/include/dmlc/././optional.h:97:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/./gbm.h:11,
from include/xgboost/learner.h:16,
from src/cli_main.cc:12:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'dmlc::optional::~optional() [with T = int]':
dmlc-core/include/dmlc/./parameter.h:513:7:   required from here
dmlc-core/include/dmlc/././optional.h:60:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
reinterpret_cast<T*>(&val)->~T();
^~~~~~~~~~~~~~~~
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::value() const [with T = int]':
dmlc-core/include/dmlc/./parameter.h:872:9:   required from here
dmlc-core/include/dmlc/././optional.h:106:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tree/updater_fast_hist.cc: In instantiation of 'class xgboost::tree::FastHistMaker<xgboost::tree::GradStats, xgboost::tree::NoConstraint>':
src/tree/updater_fast_hist.cc:933:55:   required from here
src/tree/updater_fast_hist.cc:82:8: error: 'bool xgboost::tree::FastHistMaker<TStats, TConstraint>::UpdatePredictionCache(const xgboost::DMatrix*, std::vector) [with TStats = xgboost::tree::GradStats; TConstraint = xgboost::tree::NoConstraint]' marked 'override', but does not override
bool UpdatePredictionCache(const DMatrix data,
^~~~~~~~~~~~~~~~~~~~~
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::operator*() const [with T = int]':
dmlc-core/include/dmlc/././optional.h:134:11:   required from 'std::ostream& dmlc::operator<<(std::ostream&, const dmlc::optional&) [with T = int; std::ostream = std::basic_ostream]'
dmlc-core/include/dmlc/./parameter.h:877:13:   required from here
dmlc-core/include/dmlc/././optional.h:97:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_fast_hist.cc:8:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'dmlc::optional::~optional() [with T = int]':
dmlc-core/include/dmlc/./parameter.h:513:7:   required from here
dmlc-core/include/dmlc/././optional.h:60:7: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
reinterpret_cast<T*>(&val)->~T();
^~~~~~~~~~~~~~~~
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::value() const [with T = int]':
dmlc-core/include/dmlc/./parameter.h:872:9:   required from here
dmlc-core/include/dmlc/././optional.h:106:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from dmlc-core/include/dmlc/timer.h:21:0,
from src/tree/updater_fast_hist.cc:7:
dmlc-core/include/dmlc/./logging.h: In instantiation of 'dmlc::LogCheckError dmlc::LogCheck_GT(const X&, const Y&) [with X = long long unsigned int; Y = int]':
include/xgboost/./tree_model.h:591:3:   required from here
dmlc-core/include/dmlc/./logging.h:91:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
dmlc-core/include/dmlc/./logging.h:76:9:
if (x op y) return LogCheckError();
~~~~~~
dmlc-core/include/dmlc/./logging.h:91:24:
DEFINE_CHECK_FUNC(_GT, >)
dmlc-core/include/dmlc/./logging.h:76:11: note: in definition of macro 'DEFINE_CHECK_FUNC'
if (x op y) return LogCheckError();
^~
In file included from dmlc-core/include/dmlc/./parameter.h:25:0,
from dmlc-core/include/dmlc/registry.h:14,
from include/xgboost/tree_updater.h:11,
from src/tree/updater_fast_hist.cc:8:
dmlc-core/include/dmlc/././optional.h: In instantiation of 'const T& dmlc::optional::operator*() const [with T = int]':
dmlc-core/include/dmlc/././optional.h:134:11:   required from 'std::ostream& dmlc::operator<<(std::ostream&, const dmlc::optional&) [with T = int; std::ostream = std::basic_ostream]'
dmlc-core/include/dmlc/./parameter.h:877:13:   required from here
dmlc-core/include/dmlc/././optional.h:97:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
return reinterpret_cast<const T>(&val);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mingw32-make: *** [build/tree/updater_fast_hist.o] Error 1
mingw32-make: *** Waiting for unfinished jobs....

I think you error is unrelated to this PR. Please create a separate issue
src/tree/updater_fast_hist.cc:82:8: error: 'bool xgboost::tree::FastHistMaker<TStats, TConstraint>::UpdatePredictionCache(const xgboost::DMatrix*, std::vector) [with TStats = xgboost::tree::GradStats; TConstraint = xgboost::tree::NoConstraint]' marked 'override', but does not override
bool UpdatePredictionCache(const DMatrix data,
^~~~~~~~~~~~~~~~~~~~~


LCSSMatcher forward and reverse merge simplifying

The forward_merge and reverse_merge functions share the same core code but just reversed. The reverse_merge function could be done by reversing the inputted list and call the forward_merge function and then reverse the results.
Also there is a small issue in the forward merge see the following:
forward_merge([5, 4, 3, 2, 1], lambda x: x < 3) returns [5, 4, 3, 3]
but if there were merges already done in the list like:
forward_merge([1, 2, 3, 4, 5, 4, 3, 2, 1], lambda x: x < 3) return [6, 4, 5, 4, 3, 2, 1]
This can be fixed by running the _flatten command when there are items to merge.

Well actually after looking into it more, the reverse function ensures the order of the list stays the same. If you were to call the forward_merge with a reversed list the trajectory segment traces will get out of order.


Upgrading enzyme (required for react 16 update)

Here are some issues I had running tests after upgrading enzyme:
     TypeError: Cannot read property '_instance' of undefined
      at unwrapReduxComponent (test/lib.js:10:3)

     Error:
        Attempted to access ReactWrapper::node, which was previously a private property on
        Enzyme ReactWrapper instances, but is no longer and should not be relied upon.
        Consider using the getElement() method instead.

      at ReactWrapper.get (node_modules/enzyme/build/ReactWrapper.js:1689:15)
      at Context.<anonymous> (test/pages/forgot-password.js:30:5)

     Warning: <stateValidationError /> is using incorrect casing. Use PascalCase for React components, or
     lowercase for HTML elements.
     [... Many of these]

You can see the branch here, which also includes updating to React 16 and MoNav use context https://github.com/MoveOnOrg/mop-frontend/compare/monav-context

Probably very possible to fix them all, I just didn't want to spend too much time on it right now. Let me know if you want me to take it up.

Figured it out in #509


Fix coverage in PR

A required step according to:
https://about.codecov.io/blog/python-code-coverage-using-github-actions-and-codecov/

One great feature that Codecov offers is the ability to add coverage reports right in your github pull requests. All you need to do is add a codecov.yml file in the root of your project. The file can be empty, it just needs to exist. Now, next time you make a PR a coverage report will appear that looks something like this.

This attempt did not work: try this next?
https://www.curtiscode.dev/post/tools/codecov-monorepo/

https://github.com/G-Research/armada/blob/master/.github/workflows/python-client.yml#L3 I think not running it in master is giving us the main problem we have.
https://www.curtiscode.dev/post/tools/codecov-monorepo/ Ideas from this can make our coverage look cleaner (i.e per-project)


Erroneous publication date

Type: Incorrect
Summary:
Erroneous publication date
Details:
Orekit 9.3.1 was published in March, 16th 2019, not in 2000.
Resolution:
Publication date updated
Affected definitions:

orekit 9.3.1

@sdinot Thank you for your contribution!


fix: quick-start readme corrected pem file path

This PR resolved this issue https://github.com/xline-kv/Xline/issues/693
Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Documentation change for quick-start

what changes does this pull request make?
Correct the quick-start DOC path to copy private and public pem file to scripts

are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
NO

@Phoenix500526 Please review.

@iGxnon please review


Error when running demo in Chrome OSX

Clicking on the Demo button using Chrome version 49.0.2623.0 canary (64-bit) under OSX only gives an error in the bottom of the app window.
TypeError: Cannot read property 'length' of undefined

this appears to be related to the deprecation of the SVGPathSeg APIs:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/EDC3cBg9mCU
unfortunately the "new and improved" APIs don't appear to have been implemented yet, so I'll have to look at the polyfill for it to work with Canary.

added polyfill and updated svgnest.com
chrome 47+ should be ok now

Awesome... it works just fine now.
This for sure beats hand-placing a lot of parts before cutting!
:+1:


Allow wt.exe to close tabs via command line argument

Description of the new feature/enhancement
Currently, we can open new tabs in using wt newtab.
However, we cannot close existing tabs via the command line.
Can such a command line argument be provided?

Hi @bzm3r. We're hesitant to add this kind of functionality because it could be used maliciously. Curious though, why do you want this feature?

Hi @bzm3r. We're hesitant to add this kind of functionality because it could be used maliciously. Curious though, why do you want this feature?

Just because it's cleaner than killing a window, and re-opening it? I'm not sure I understand why this is a maliciousness issue, when it is possible to kill a terminal window quite easily, and/or any shells that are running in tabs (e.g. PowerShell's Stop-Process)?


Round DKP display values to only three decimal places

The default float values used can end up with very long numbers that are
awkward to read in the UI, this patch rounds to just three decimal places
to make the DKP list more readable.

@lantisnt you were working on something as well right?
If that's a while out we could merge this as a temporary fix.
@bhthompson thanks! In our final solution we don't want to round in the UI only, that'll cause unpredictable behavior for end users. They might see they have the same DKP while in reality they do not; that said, I'm open to merging this as a temporary fix seeing as we're all busy...
@lantisnt up to you.

Glad to help!
If two users have the same DKP value today is there logic for breaking the tie somewhere that this might violate?
I was thinking that if the rest of the precision of the DKP value was hidden that users would not really mind, and that if two users had the same visible value this would still award the slightly higher DKP holder behind the scenes. I am interested in how this might be handled without making a compromise.
Perhaps the right solution would be a UI element to set a precision and tie breaking policy, but that is beyond my bandwidth to figure out at the moment.

There is sorting in the ML screen which is sort of a tie breaker (still manual).
But there are more concerns. If you look at your DKP today, and you know tomorrow decay will happen, you should be able to tell what your DKP will be tomorrow. With rounding only in the display you will have edge cases where you don't.
I think the goal is to have a setting to choose decimals which is then used in actual calculations as well. So mathematically we will lose a tiny bit of precision in the long run, in exchange for more intuitive and predictable behavior in smaller time scales

Thank you for this contribution! This is valuable for us!
I've decided to discard it as the code for rounding the data on update was added as mentioned by samm.


Refactor双层循环没必要，单层就可以解决问题

双层循环没必要，单层就可以解决问题

Types of changes

[ ] New feature
[ ] Bug fix
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

Solution

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

测试挂了


Vocals Starting Points of the Songs

Vocals Starting Points of the Songs
A big problem is to detect when the vocals part in each song happens.
More particulary, when the first verse starts (and not be mistaken by vocals FX in the start of the song).

Trying to fix it by detect when the vocals start, using simple analizing  of the vocal's dBs values.
There are still problems, for example, if the vocal at the start is just an effect, or a pre-verse, the program thinks that the vocal is starting at the first verse.
I came to the conclusion that this program will not be able to fully do what it supposed to do, and for the main reason: Art .
Art, in it very special and diverse areas, have a main principle and that's subjectivity.
Every single song is so different from the other.
What I'm trying to say is that if you want the program to perform at it fullest, give it ordinary songs and not indie and wierd ones.
If you want to mashup special or weird songs, I strongly recommend you to extract the vocals and instruments using vocal-remover, the module that I used in MashupMaker.
Hope I will have time to build a UI-friendly website for it, as a kind gesture for this amazing open-source module.


Campaign Titles on Homepage: IE 8

Issue Summary: Campaign titles on homepage appear with black behind them

Browser/Operating System: Windows 7 / IE 8

This is expected behavior. IE 8 does not support CSS Gradients, which we use to add that gradient effect on tiles, so we use a transparent black container to make the text readable.


⚠ Jenkins Plugins Artifactory has degraded performance

In a52d277, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1268 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 71f94ef after 1 hour, 4 minutes.


Fix vulns

These are coming from pinot-tools dependency

@aaron-steinfeld moved aircompressor to constraints and updated netty-bom version.


Add mouth

Each team must be deliver their burgers to their respective mouth objects
If the player delivers the correct order to the mouth, they should receive points

Will we give one point or it depends on the complexity of the burger?

Yeah that's a good question. I haven't thought about it. Let's try complexity of the burger.
I was also trying think if there are bonus points we could add somehow, but starting off with burger complexity is good.


Implemented allowedDomains option

This will allow one to define an array with allowed domains in hrefs

Started working on allowedDomains per tag name, please don't merge yet (if you intend to 😄 )

Done 😄

Thanks for this code!
I believe it is necessary to configure both www.youtube.com and youtube.com if we want to allow both, correct? I am not suggesting that we should try to figure that out automatically, but I do think that the option should be called allowedHostnames instead so people are not confused and don't expect it to detect that automatically.
Also, please add documentation (or if you prefer I can add it to the README).

If you add youtube.com it will allow youtube.com and all it's subdomains, including www. I had all the "allow" spec variants that I removed thinking they would be redundant. Maybe I should add them back ... (https://github.com/punkave/sanitize-html/pull/138/commits/b3f0a3f46263e4e2db9c7b62c8659db8227eab52)
I could rename the option if you think it will be clearer for the user.

OK, so I put back the deleted tests as I realize they can be useful both for making sure the functionality works as intended in the future and also for documentation purposes.
Considering that the option does allow both www.youtube.com and youtube.com if only youtube.com is specified do you still consider we should rename the option ?

Is this PR still of interest ?

Closing for inactivity.


Fix QQ checkver fail.

Fix QQ checkver fail, and upgrade QQ URL.

[x] I have read the Contributing Guide.

/verify

/verify

/verify

/verify

Please create separate PRs for the manifests.


msal.PublicClientApplication not working

I am not sure whether this actually is an issue with this library. If it is not I hope someone here might know the issue.
I am trying to setup a public client application for internal use, using our aad. Authorization using the /docs page works fine, however a sign-in using the msal.PublicClientApplication fails wit the following:
2021-06-01 12:08:58,760 - 918bd735a7944622ac7d2ba14c50629c - AADTokenValidator - DEBUG - Processed Key: b'-----BEGIN RSA PUBLIC KEY-----\nMIIBC...IDAQAB\n-----END RSA PUBLIC KEY-----\n'
2021-06-01 12:08:58,760 - 918bd735a7944622ac7d2ba14c50629c - AADTokenValidator - ERROR - Unable to parse error
Traceback (most recent call last):
  File "python3.9/site-packages/fastapi_aad_auth/providers/aad.py", line 202, in _decode_token
    claims = jwt.decode(
  File "python3.9/site-packages/authlib/jose/rfc7519/jwt.py", line 99, in decode
    data = self._jws.deserialize_compact(s, load_key, decode_payload)
  File "python3.9/site-packages/authlib/jose/rfc7515/jws.py", line 105, in deserialize_compact
    raise BadSignatureError(rv)
authlib.jose.errors.BadSignatureError: bad_signature:
2021-06-01 12:08:58,760 - 918bd735a7944622ac7d2ba14c50629c - AADTokenValidator - ERROR - Error authenticating via token
Traceback (most recent call last):
  File "python3.9/site-packages/fastapi_aad_auth/providers/aad.py", line 202, in _decode_token
    claims = jwt.decode(
  File "python3.9/site-packages/authlib/jose/rfc7519/jwt.py", line 99, in decode
    data = self._jws.deserialize_compact(s, load_key, decode_payload)
  File "python3.9/site-packages/authlib/jose/rfc7515/jws.py", line 105, in deserialize_compact
    raise BadSignatureError(rv)
authlib.jose.errors.BadSignatureError: bad_signature:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "python3.9/site-packages/fastapi_aad_auth/_base/validators/token.py", line 52, in check
    claims = self.validate_token(token)
  File "python3.9/site-packages/fastapi_aad_auth/_base/validators/token.py", line 109, in validate_token
    claims = self._decode_token(token)
  File "python3.9/site-packages/fastapi_aad_auth/providers/aad.py", line 208, in _decode_token
    raise AuthenticationError("Unable to parse authentication token")
starlette.authentication.AuthenticationError: Unable to parse authentication token

I have verified the arguments to jwt.decode(token, key) and both are set, I did notice the token is much longer than when used through the /docs endpoint.
To replicate this, the client looks like:
import msal
from pprint import pprint
import requests

client_id = ''
tenant_id = ''

if __name__ == '__main__':
    client = msal.PublicClientApplication(
        client_id=client_id,
        authority=f'https://login.microsoftonline.com/{tenant_id}'
    )
    response = client.acquire_token_interactive([client_id])
    pprint(response)

    try:
        token = response['access_token']
    except KeyError:
        pprint(response)
    else:
        user_response = requests.get('https://graph.microsoft.com/v1.0/me', headers={
            'Authorization': f'Bearer {token}'
        })
        pprint(user_response.json())

        my_api_response = requests.get('http://localhost:8000/customers', headers={
            'Authorization': f'Bearer {token}'
        })
        pprint(my_api_response.json())

The "graph" endpoint works and I can see the signed in user. My_api however doesn't and produces the error above.
In AAD I have added under "Authentication"->"Mobile and Desktop Applications" the callback url "http://localhost".
Further is ofcourse the "Allow public client flows" option set to Yes.
Could this be an issue with the way this library processes the token or is something else wrong?

Hi @Yzoni - I will try and have a proper look at this this evening - I think that it is likely you are currently requesting/authenticating with incorrect scopes/app config -
https://djpugh.github.io/fastapi_aad_auth/usage.html#configuring-the-azure-active-directory-app-registration and
https://djpugh.github.io/fastapi_aad_auth/usage.html#authenticating-a-client may help,
If you have exposed the api, the scope should default to something like api://{client_id}/.default (it will depend on your app config), and you are getting either an MS nonce in there (it will raise the error for that), or an incorrect scope - if you can get the token, you can look at e.g. https://jwt.io/ (please note I don't vouch for the security of that site, and suggest using a dev token with limited credentials etc.) to see what comes out on the token. IIRC BadSignature tended to come when the token was authenticated against the graph rather than the app.

The error is occurring on line https://github.com/djpugh/fastapi_aad_auth/blob/de2f1e359e468f32a10f1b45267af3c2faa60b3c/src/fastapi_aad_auth/providers/aad.py#L202
which is using authlib.jose.jwt - I think therefore it is likely a config error rather than a code error (as that only takes the token and the MS jwk key, which was parsed correctly

Hi, thank you very much for your help. I just tried it again, and it indeed it looks like the issue was with the configuration. I'm not sure what I did wrong last time. I did try to put the client ID as the scope previously, however then I got an error like:
AADSTS90009: Application '' is requesting a token for itself. This scenario is supported only if resource is specified using the GUID based App Identifier.

However, I am unable to reproduce this now.
Anyway my issue is solved. I just want to say thank you for making this great package!

For anyone running into the AADSTS90009 issue mentioned above, arriving here through google. The problem was that the scope given in acquire_token_interactive() had the prefix api://. For some reason it sometimes works, and sometimes doesn't. It seems to always work when removing this prefix and using f'{client_id}/.default'.

I will add this to the docs


Error: Redefinition of 'RCTMethodInfo'. Proposed Solution.

Using newer React Native version, we get the xcode compile error saying Redefinition of 'RCTMethodInfo'.
Proposed Solution:
In the DeviceAngles.h, please change #import "RCTBridgeModule.h" to #import <React/RCTBridgeModule.h> and it worked for me.
Although in some forums following is also suggested (but not tried):
#if __has_include(<React/RCTBridgeModule.h>)
  #import <React/RCTBridgeModule.h>
#else
  #import "RCTBridgeModule.h"
#endif

thanks @necixy ! have not been using xCode for a while now, will give it a try when possible
let's leave your post open so others can see the solution, cheers!


feat(RouteNavigate): nav(-1) history support

add support for history for easy back button

LGTM 🙌


Moving a folder in the Tree View does not close the corresponding file buffers.

When dragging a file in the Tree View into a different folder, any buffers of this file are closed. I guess, this is desired behaviour. (Alternatively, the buffer could stay open and internally change the file it is referring to, but this is another topic.)
However, the behaviour is different when instead of a file a whole folder is moved (via drag and drop) in the Tree View: Buffers of files in the folder stay open, and upon closing them manually, a dialogue "file.xyz has changes, do you want to save them?" is triggered. This is certainly not good behaviour. The buffers should be closed instead.
Furthermore, if the file is not yet added to git, it is marked green in the Tree View, along with all higher level folders. If now a folder with such a new file is moved, the green marking does not update properly for the higher level folders.
Using:
atom 1.2.4
tree-view 0.195.0
ubuntu 14.04

Just found a new bug: Something similar happens when renaming a folder in the Tree View while files of that folder are opened: The files stay open, but are marked as unsaved. When saving them, the old folder name is created again, with the file in it. So then there are two copies of that file, one in the renamed folder and one in the folder with the old name that was just created again.

I am able to repro this when I am moving folders, when I save the files that are open it recreates the old folder in old location.
This is kind of related to https://github.com/atom/tree-view/issues/948


Show number of comments in memo list

Describe the solution you'd like
Show number of comments in each memo card in the memo list page.
Type of feature
User Interface (UI)
Additional context
No response

Duplicated with https://github.com/usememos/memos/issues/3014


Add note about ImageID to the config section of manifest.md

The config digest is used by a number of popular runtimes/orchestrators as an identifier for an image with an amount of assumed uniqueness.

If I understood correctly, this requirement for Container images is related to making sure that the configuration in mediaType.config applied matches the layers that were set up in the for the container on the file system exactly. Otherwise you could potentially apply the wrong configuration to the wrong image and _do bad things_tm.

The bad things people worry about are runtimes improperly deduping images. So you may have a config for v1.2 of a WASM image being deployed by a WASM capable runtime, and try to upgrade it to v1.3 and the runtime would respond that it already has that image id and keep running the v1.2 WASM application.
That could also be used maliciously by those that want to poison the cache and potentially access data they shouldn't have access to, by creating a WASM app with a configuration matching a well known trusted image. If the malicious image is pulled first, for testing in an untrusted sandbox, and the trusted image is later requested to run with secure data, the malicious image would be run with access to the secure data.

Thanks! Two follow up questions:

Since this could be a security concern and the current runtimes do in fact rely on this should this be a MUST instead of recommendation?
My understand was that this was a leftover from earlier days before the config was content addressable.  Should this be encoded in the spec for backwards compatibility or is there a better way to represent the unique image that the spec should point to so that newer runtimes don't need to use the config as the unique Image ID?

Hah, https://github.com/opencontainers/image-spec/issues/743 is very related 🚀


Task Field of Individual Events not Correctly Set

Explicitly set task field of the returned event template based on the EventHeader.
Closes #1928

@sgrottel, this is a good find.  I was hoping to scope this fix slightly to just DynamicTraceEventData, but the path that I followed to start writing down what the fix would look like led me to more questions.  In the case of your repro app, you're using TraceLogging, which I would have expected to result in use of the TdhParser: https://github.com/microsoft/perfview/blob/main/src/TraceEvent/RegisteredTraceEventParser.cs#L657.  Do you know where the instance of DynamicTraceEventData that you're using is being created?  If it gets created here, I would have expected the TaskID to be set properly already.

Thanks @brianrob for your quick reply :+1:
You are absolutely right, that is the spot where the event object is created for the very first occurrence of the event.
The issue is that our analysis tool only logically groups specific event instances with task numbers, e.g. events related to a specific piece of data. The task value of the first event parsed is stored in the event template (ExternalTraceEventParser.OnNewEventDefintion :L1294). Later events of the exact same type might have different task values, which is not updated from the template. And then, this issue is triggered.

I can think of one alternative implementation:

Make the TraceEvent.Task property virtual
override DynamicTraceEventData.Task to not use the task field, but to fetch the value directly from eventRecord->EventHeader.Task

Then the task field would be orphaned for DynamicTraceEventData and might run into inconsistencies. That's why I decided for the fix I prepared here.
If you prefer that way, or if you have another solution in mind, please, tell me.
I happily update/replace the change in this PR.

@sgrottel, to confirm my understanding of your setup, are you saying that for a specific event (provider id / event name) you vary the TaskID?  Or am I mis-understanding?

Yes, you understand correctly.
You can have a look at the example etl file I attached to the Issue #1928 in WPA.
There are events of Provider "EtlProviderApp" with Event Name "WriteEventInts" and one of them set "Task" to 1, while all other have "Task" on 0.

Thanks @sgrottel.  Can you tell me a bit more about why you are varying the task value?  The reason I ask is that I spoke with some folks on the ETW team, and while this is technically possible to do, it's not really expected behavior.  Perhaps we can recommend a different approach that would work with the existing tooling.  As you've seen, TraceLoggingProvider.h doesn't allow you to set the Task, so you have to build all of the metadata on your own in order to do this.

Replaced by #1977


Update prettier rules

Changelog

Turned on formatOnSave in VS Code settings
Added required packages "eslint-config-prettier" and "eslint-plugin-prettier" to integrate Prettier into ESLint
Removed ESLint rules that dealt with code formatting. This is now only handled by the rules defined in the Prettier config file.
Changed .prettierrc to .prettierrc.js and updated the formatting rules

I wanted be able to comment the Prettier config file with links to the documentation, so I chose a file extension that allowed that.

View Proposed Changes

Checkout this branch jazhen/235-update-prettier-rules
Run the script: npm run lint:fix:js
View the changes. I used VS Code to easily view the diff side-by-side.

Should we just deploy this lint in its own build next week onto prod after vector tiles and after all the details are hashed out?

Sure, let's just do it next week so we can discuss the the changes and address any specific concerns as a team.


DefaultProps modules should return functions as well

To be consistent with function definitions, override modules should also return functions.

closed in #14, I botched the commit message


Fix(eos_designs): Allow reuse of cross-device BGP peer ip

Change Summary
Currently if a given BGP peer IP is used on device A and reused on device B, validation fails. However, although not a recommended design, this is a valid config. This PR will relax the BGP peer ip reuse.
Related Issue(s)
Fixes #3914
Component(s) name
arista.avd.eos_designs
Proposed changes
Today, if a given bgp peer IP is used on device A and reused on device B, validation fails.
[WARNING]: [SJC13EXTLF01-A]: 'Validation Error: Marr-Managed-WAN[0].vrfs[0].bgp_peers': Values of Primary key 'ip_address'
are not unique as required.
[WARNING]: [SJC13EXTLF01-B]: 'Validation Error: Marr-Managed-WAN[0].vrfs[0].bgp_peers': Values of Primary key 'ip_address'

However, although not a recommended design, this is a valid config.
Currently, validation has to be run set to 'warning' and the user just ignores those messages increasing margin for errors.
Allow IP reuse for BGP peerings across different devices.
How to test

Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Review docs on Read the Docs
To test this pull request:
# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4050
# Activate the virtual environment
source test-avd-pr-4050/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@bgp_peer_ip_use_validation#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,bgp_peer_ip_use_validation --force
# Optional: Install AVD examples
cd test-avd-pr-4050
ansible-playbook arista.avd.install_examples

Feedback - it should be "python3" instead of "python"

I've tested it and it does not warn anymore for when we have repeated IPs across devices. It builds correctly.
However, shouldn't it warn on this? In my testing it didn't warn at all:
        bgp_peers:
          - ip_address: <IP_ADDRESS>
            nodes: [EXTLF01-B]
          - ip_address: <IP_ADDRESS>
            nodes: [EXTLF01-B]

That's IP reuse on the same VRF and on the same device, not sure that's a valid config that we should warn or not.

This code should not allow duplicates. Have you tested?

This code should not allow duplicates. Have you tested? Your example above had the same exact info twice. Such duplication is silently ignored. Only one peering will be added to the structured config. Please confirm. @pmprado

Yes I did test. Indeed it was an exact duplicate, to simulate a typo on a situation where we have 2 peers that are basically identical except for the IP. Do you mean that if they are not exact  duplicates they won't be silently ignored? Still, shouldn't any duplicate be warned about?

This code should not allow duplicates. Have you tested? Your example above had the same exact info twice. Such duplication is silently ignored. Only one peering will be added to the structured config. Please confirm. @pmprado

Yes I did test. Indeed it was an exact duplicate, to simulate a typo on a situation where we have 2 peers that are basically identical except for the IP. Do you mean that if they are not exact duplicates they won't be silently ignored?
Correct

Still, shouldn't any duplicate be warned about?
No, since you may have situations where you define the VRF in multiple tenants, and they get merged, possibly leading to the same peers being repeated (it is a very complicated corner case). There is no reason to error out when there is no conflict.


some folders miss after react-web init

Happen time: just near the time I submit this issue
only node_modules, package.json and web in the project folder, the below files or folders miss:
├── README.md
├── android/
├── index.android.js
├── index.ios.js
├── ios/
environmental info:
OS: Ubuntu 16.04
$ react-web -v
react-web-cli: 0.0.3
react-web: 0.3.2

Not tested on ubuntu system, could u find what’s make the problem？

@leonardgithub ,react-web init worked well on my Ubuntu 16.04.
By the way, what's your projectName spell?

@flyskywhy just a placeholder for my project name

@leonardgithub , as you can see in https://github.com/soliury/noder-react-native/commit/21c4a20fbab67f1b4102f6f8899b45258bf9b091 , because - is illegal in react-native init or react-web init, I npm install -g react-web-cli; cd ..; mv noder-react-native noder; react-web init noder; mv noder noder-react-native and all worked well, so maybe this issue #148 was caused by your project name?

leonard@leonard-g400:~/test$ react-web init myproject
This will walk you through creating a new React Web project in /home/leonard/test/myproject
Installing react-web package from npm...
Setting up new React Web app in /home/leonard/test/myproject
npm ERR! Linux 4.4.0-38-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "" "--save-dev"<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>"babel-preset-es2015@undefined" "babel-preset-react@undefined" <EMAIL_ADDRESS>npm ERR! node v6.2.2
npm ERR! npm  v3.9.5
npm ERR! No compatible version found: babel-preset-react@undefined
npm ERR! Valid install targets:
npm ERR! 6.16.0, 6.11.1, 6.11.0, 6.5.0, 6.5.0-1, 6.3.13, 6.2.4, 6.1.18, 6.1.17, 6.1.4, 6.1.2, 6.0.15, 6.0.14, 6.0.12, 6.0.2
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     /home/leonard/test/myproject/npm-debug.log
npm install failed
leonard@leonard-g400:~/test$ react-web -v
react-web-cli: 0.0.3
react-web: n/a - not inside a React Web project directory

@leonardgithub , babel-preset-react@undefined error was solved in bca8e6f3c6e6be0244d12e69b13fde9f4e4a1b63 at 2016-10-09 just after you report this issue, and the latest react-web 0.4.3 contain this commit, so you just need react-web init myproject again to get the latest react-web.
plus: react-web -v should invoked in ~/test/myproject/ not ~/test/
btw: Is this issue some folders miss after react-web init solved?

@flyskywhy OK, I will try. It's so kind of you.


Add storage format enum to file metadata in archive manifest

Description
Right now we always assume the underlying storage format is blob. This allows us to migrate to with other storage formats in the future without needing to migrate older data to newer format. We would be able to just add a new enum value and start writing newer checkpoints with newer storage format.
Test Plan
Existing tests

Please 🙏 help,   very good project


Error get Cookies

Steps to reproduce
Tell us about your environment:

Puppeteer version<EMAIL_ADDRESS>Platform / OS version: Ubuntu 16.04 LTS
Node.js version: 8.9.4

I'm trying to run code
const puppeteer = require('puppeteer')
const devices = require('puppeteer/DeviceDescriptors');
const cookies = [
    {
        name: 'k1',
        value: 'v1',
        domain: 'e1.ru',
        path: '/',
        expires: 0,
        size: 4,
        httpOnly: false,
        secure: false,
        session: true,
    },
    {
        name: 'k2',
        value: 'v2',
        domain: 'httpbin.org',
        path: '/',
        expires: 0,
        size: 4,
        httpOnly: false,
        secure: false,
        session: true,
    },
];

(async () => {
  const browser = await puppeteer.launch();
  const page = await browser.newPage()
  await page.emulate(devices['iPhone 6'])
  await page.setCookie(...cookies);
  await page.goto('http://e1.ru/')
  await console.log(page.getCookies())
  await page.screenshot({path: 'full.png', fullPage: true})
console.log(await page.title())
  await browser.close()
})()

to line   await console.log(page.getCookies())
getting an error:

(node:4545) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: page.getCookies is not a function
(node:4545) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm doing something wrong or is it a bug?

Shit, I made my IDE and I did not notice, the question is settled, sorry for the trouble.


lato webfont

We need an update or the files from https://github.com/betsol/lato-font and we can remove old font files, see https://github.com/betsol/lato-font/issues/7

Why was this closed? I see no changes in https://github.com/designmodo/Flat-UI/tree/master/dist/fonts/lato

Good question. Seems like all issues were closed before the Bootstrap 4 update: Maybe consider to open a new one.


Unban Command

Pull request

[x] I have read and agreed to the CODE OF CONDUCT.
[x] What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our trello.
[ ] I have tested all of my changes.
[ ] I have followed the style of the rest of the project.

Feature
Unban Command

 Unban command

 Unban command


[New game]: CHESS Multiplayer

🎮 Game Request
Game logic and basic description
Game logic and basic description
when clicking on a particular piece of the chessboard, It shows you all the possible routes that a particular piece can take and later moves the pieces. it also prevents selecting multiple elements.
If black or white wins the game then the alert appears saying black wins!!.
Point down the features
Game points
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Enhancer18 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @Enhancer18!
We are already having a similar game request in #421 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @Enhancer18 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Parse valid datetimes

Resolves #6
Major Changes

All valid combinations of TZID:<global_tzid> and inputted datestrings are now handled. The following table is from test/ex_ical_date_format_test.ex. It shows the input formats and expected output both without the calendar-wide TZID property and when TZID:America/Chicago:

[
#---------------------------------------------+---------------+----------------------------------+
#                               DTSTART input |   Parsed Date |  Timezone with Global TZID = ?   |
#                                             |               |            nil | America/Chicago |
#---------------------------------------------+---------------+----------------+-----------------+
{                           "DTSTART:19690620",     date_match,  local_tzmatch,   local_tzmatch,},
{                          "DTSTART:19690620Z",     date_match,    utc_tzmatch,     utc_tzmatch,},
{                    "DTSTART:19690620T201804", datetime_match,  local_tzmatch, chicago_tzmatch,},
{                   "DTSTART:19690620T201804Z", datetime_match,    utc_tzmatch,     utc_tzmatch,},
{ "DTSTART;TZID=Europe/Berlin:19690620T201804", datetime_match, berlin_tzmatch,  berlin_tzmatch,},
{"DTSTART;TZID=Europe/Berlin:19690620T201804Z", datetime_match,    utc_tzmatch,     utc_tzmatch,},
]
- Add documentation (`@moduledoc` and `@doc`) to `ExIcal.DateParser`
- Add basic test files (with `doctest`) for all app modules
- Misc. refactoring and bugfixes

### Questions/Decisions

- As it is, the library can parse several formats that are invalid by the iCal spec:

- `DTSTART:<YYYYMMDD>Z`
- `DTSTART;TZID=<tzid>:<YYYYMMDD>Z`
- `DTSTART;TZID=<tzid>:<YYYYMMDD>T<HHMMSS>Z`

I think we treat these cases in reasonable ways, and that by handling them, we make the library more flexible. Maybe we should stay with the spec though? Thoughts?

- Since `%Timex.DateTime{}` can't handle floating dates (especially if we're sorting through them by range), we can't parse `<YYYYMMDD>T<HHMMSS>`-formatted dates ([Form 1] by the docs) without a timezone. At the moment, I have them parse to `:local` time. It makes sense for some applications, but it may be a problem if the app using `ExIcal` is in a different timezone than the user.

[Form 1]: http://www.kanzaki.com/docs/ical/dateTime.html

We may prefer to use `:utc` (the default for `%Timex.DateTime{}`. We may also want to add some sort of indicator (a `floating: true` property on the struct, for example) that it was imported as a floating local datetime. So, `:local` or `:utc`? Is an indicator of floating local dates worth it?

Actually, I think :utc makes more sense than :local. That takes all ambiguity out of user versus server locations and will lead to more expected behavior. I'll update that in the code.

Thank you for this great PR.

Sure thing! I've got a bit of a selfish motivation–I want to use an iCal parsing package in my project, so I'd love to see this hit 1.0! :smile:
What are your other feature goals before reaching v1.0?

BTW Just added credo to project, and automatic PR analysis. It will be nice to fix credo warrnings also. Thanks once again.


Improve Notification Support

Describe the changes you have made in this PR -

Move the notification code from the event_handler_api file to the notification_controller file.
Introduce two new notification keys for stop and cancel.
Apply the cancel notification when torrent download is paused and the stop notification when a torrent is downloading.
Receive notifications regarding any errors occurring during the download process.
Incorporate support for multiple languages in the notification dialogue.

Screenshots of the changes -

@amitamrutiya2210  the new notification changes looks buggy. Some of the bugs I noticed are:

Not getting paused on pausing.
Other torrent getting paused on pausing some other torrent.
Cannot clearly understand the usage of STOP button and CANCEL BUTTON.

https://github.com/CCExtractor/Flood_Mobile/assets/73401649/56f8c30d-4668-4633-8cb8-7ddeb66bc270

The first two errors occur because of the implemented sorting by features (I will resolve this as soon as possible).

The "Cancel" button is used to remove a selected notification. If a user doesn't want to see a particular notification, they can use the cancel button to dismiss it. Additionally, a "Stop" button will pause a torrent and dismiss the selected notification.

I added new required changes, now you can review this PR.


fix: allow services to indicate their depdencies

Some services depend on others, for example circuit relay v2 and kad-dht don't really work without identify so we need a way to prompt the user to configure these dependencies.
The change is to allow extending the components a service requires with a service map of the dependencies.
The components type in the Libp2pInit type is extended by the ServiceMap generic type so when the user configures a node without the required dependencies, TypeScript will fail to compile as the components being passed to the factory function don't have type overlap with the required components.

Super cool!
This does feel like it gets close to the line where TypeScript stops being fun anymore... once you start playing the generics game it's hard to stop. Personally I love going crazy with types but it can start to slow people down; it's up to you to weigh those tradeoffs.
Just a thought: if the idea is that "we have some components that get passed around, which always include certain built-in components, ", then would changing everything to take a Components extends BuiltInComponents parameter make more sense than passing around the "service map" just to pass it back into Components<ServiceMap> = BuiltInComponents & ServiceMap? Might be a lot of refactoring but it could eliminate the extra "service map" type concept.

then would changing everything to take a Components extends BuiltInComponents parameter make more sense than passing around the "service map" just to pass it back into Components = BuiltInComponents & ServiceMap? Might be a lot of refactoring but it could eliminate the extra "service map" type concept.

That's a good point @joeltg , the original impetus to even have these optional  services was to reduce Libp2p surface area in consumers and also to improve extendability through custom modules. I think at the time we went with the ServiceMap  because we were unsure how could have an interface that could facilitate them being accessed from a services key.
I think having the DefaultComponents extend the BuiltInComponents and also having that configuration validated would solve this issue without a large refactor.

Edit: I guess the other question hanging over this is that the services refactor kinda suggests that people can name their services anything they want now, but in reality dependent services still rely on specific names. Maybe make sure this is communicated in the docs somewhere?

Whilst we do now support custom modules I agree the docs should reflect those limitation, perhaps we could have a section in the configuration doc where we indicate that some services require others e.g. setup with relay requires identify

Discussion: https://github.com/libp2p/js-libp2p/discussions/2135

I'm going to close this in favour of the solution proposed in https://github.com/libp2p/js-libp2p/discussions/2135


how to swipe Right to Left pages?

how to swipe Right to Left pages?

This video will show you how: https://www.youtube.com/watch?v=OlAugnH3jFY&feature=youtu.be


Incorrect information in ROS Documentation

While going through the documentation on timed_roslaunch I noticed that there is an error in the Installation section, it incorrectly points to a another github repository instead of the timed_roslaunch.
ROS Documentation link
Incorrect Repository
Actual Repository

@DaPineappleDude
Thank you for your comment and sorry for late reply.
I updated wiki documentation as you mentioned.

Now, you can install timed_roslaunch via apt. Here you go!
https://github.com/MoriKen254/timed_roslaunch/blob/kinetic-devel/README.md

ok, resolved.


User should be able to see ETH balance as part of their account summary / total funds

[x] In the top bar, the "Total Funds" section should NOT include ETH held in the signer (for fees), but on hover it should have a tooltip (with the circle+question mark @Chwy5 ) that says "Your total funds does not include those funds Reserved for fees".
[x] In the account menu, add in the ETH balance of the Signer as a row, with the label "ETH (Reserved) -- with the (?) + tooltip. The tooltip should use the final text that is displayed during the modal in #7084

This issue is currently blocked by #7084 -- but once the final text has been decided we can remove that blocker.

looks good - closing


HADOOP-17002. ABFS: Adding config to determine if the account is HNS enabled or not

Each time an FS instance is created a Getacl call is made. If the call fails with 400 Bad request, the account is determined to be a non-HNS account.
Recommendation is to create a config and be able to avoid store calls to determine account HNS status,
If config is available, use that to determine account HNS status. If config is not present in core-site, default behaviour will be calling getAcl.
Driver test results using accounts in Central India
mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify
Account with HNS Support
[INFO] Tests run: 56, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 421, Failures: 0, Errors: 0, Skipped: 66
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 24
Account without HNS support
[INFO] Tests run: 56, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 421, Failures: 0, Errors: 0, Skipped: 240
[WARNING] Tests run: 206, Failures: 0, Errors: 0, Skipped: 24

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 24s
trunk passed

+1 :green_heart:
compile
0m 27s
trunk passed

+1 :green_heart:
checkstyle
0m 19s
trunk passed

+1 :green_heart:
mvnsite
0m 29s
trunk passed

+1 :green_heart:
shadedclient
16m 16s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
trunk passed

+0 :ok:
spotbugs
0m 50s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 48s
trunk passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
hadoop-azure in the patch failed.

-1 :x:
compile
0m 22s
hadoop-azure in the patch failed.

-1 :x:
javac
0m 22s
hadoop-azure in the patch failed.

+1 :green_heart:
checkstyle
0m 14s
the patch passed

-1 :x:
mvnsite
0m 23s
hadoop-azure in the patch failed.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 46s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s
the patch passed

-1 :x:
findbugs
0m 25s
hadoop-azure in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 26s
hadoop-azure in the patch failed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

61m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1975

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux 56700cb0b1ff 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 459eb2a

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-azure.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-compile-hadoop-tools_hadoop-azure.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-compile-hadoop-tools_hadoop-azure.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-mvnsite-hadoop-tools_hadoop-azure.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-azure.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/artifact/out/patch-unit-hadoop-tools_hadoop-azure.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/testReport/

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
markdownlint
0m  0s
markdownlint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
24m  3s
trunk passed

+1 :green_heart:
compile
0m 30s
trunk passed

+1 :green_heart:
checkstyle
0m 21s
trunk passed

+1 :green_heart:
mvnsite
0m 36s
trunk passed

+1 :green_heart:
shadedclient
16m 49s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s
trunk passed

+0 :ok:
spotbugs
0m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 55s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 16s
the patch passed

+1 :green_heart:
mvnsite
0m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 45s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 18s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

67m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1975

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint

uname
Linux c34fc51f8fb1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 459eb2a

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/2/testReport/

Max. process+thread count
308 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1975/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I see the comments in the old PR  has been resolved.
LGTM, +1.
@bilaharith please close the old one to avoid confusion.

Done.