[cli] thorough cleanup on datasource deletion

Currently deleting a datasource through the cli doesn't clean up data in QDrant. Which is different behaviour than when deleting a datasource through poke.
References:

https://github.com/dust-tt/dust/issues/6194

Should we keep the CLI here?

Yes let's just remove the cli functions in favor of poke
Moving to eng runner

See comment here: https://github.com/dust-tt/dust/issues/6194#issuecomment-2302267564


Inconsistent error messages - "lgrNotFound" and "ledgerNotFound"

An RPC command could return two different error messages meaning the same thing, either ledgerNotFound or lgrNotFound. There are also some unit tests that care about these values. In addition, it seems that the improved ledger_request response switched from "ledgerNotFound" to "lgrNotFound".  We should consolidate these to use the same error.
Here are some examples of inconsistency:
https://github.com/ripple/rippled/blob/0b4e34b03b72196510998375fd28622c8b63aaa7/src/ripple/protocol/impl/ErrorCodes.cpp#L83
https://github.com/ripple/rippled/blob/0b4e34b03b72196510998375fd28622c8b63aaa7/src/ripple/rpc/handlers/CanDelete.cpp#L83
Exported from RIPD-1080

This may be something to clean up in Clio


[runtime] Backwards-deployment support for class_getImageName

Follow-up to #17910. On Apple OSs that don't have the new Objective-C runtime function objc_setHook_getImageName, override the system definition of class_getImageName by literally rewriting symbol tables at run time.
Yes, you read that correctly.
The low-level part of this patch was written by @gparker42, then simplified and tweaked by me to fit the Swift coding style. Don't try this at home; it comes with all sorts of caveats and won't actually work on this year's iOS. (Fortunately we don't need it there, because that will have the new ObjC entry point.)
The rest of the patch is pretty straightforward: the replacement implementation calls the code that supports Swift objects (the same code we use on newer OSs), which then chains back to the original system implementation of class_getImageName. May we never have to touch this again.
SR-1917 / rdar://problem/41535552

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - c4f6f3187f69e62a87bd625af26082bf669b97bb

Full macOS tests here. I just failed to account for the new files getting compiled on Linux too.
@swift-ci Please smoke test


Lazysizes with RICG approach doens't work

First of all, great plugin and thanks.
I think it will be useful if we could use a native responsive approach instead of with a polyfill option. Now, if I try to set a fallback for a browser that don't read srcset image without an additional load it doesn't work:

It should render:

Any idea on how to implement it? Maybe I missed something?

Actually, I also think this is useful and I have a test, that makes sure, that this markup is rendered, if
a) the browser does not support responsive images
and
b) no polyfill is detected
So are you sure, that there is no data-src -> src transformation. Note: You should not check in Chrome!

Yep @aFarkas, it works, my fault, I saw the img break icon while loading and I supposed that it doesn't work, I used data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw== in the src and it works all fine now, thanks!


Android Annotations: CollisionGroup

Android annotations API proposal implementation issue as a part of https://github.com/maplibre/maplibre-native/issues/1491

Add the CollisionGroup object as specified in the proposal.

CollisionGroup should be implemented.

This ticket is in scope of the Modernization bounty direction. https://github.com/maplibre/maplibre/issues/270

@louwers Of course I will work on this issue as well, after the other ones.


Proposal:  useToast position prop

Feature request 🚀

[ ] I will create Pull Request
[x] It's just a suggestion

Expected

useToast should accept "position" (or similar) prop for displaying it on top-left, top-right, bottom-right (default), bottom-left, top-center, bottom-center

I was reading useToast hook but cannot understand it at all, otherwise I would sent a PR
Examples
<div onClick={() => setToast({ text: 'You´ve clicked the image', type: 'success', position: 'top-left' })} >
                { /* ... */ }
 </div>

Programme (Optional)
Others (Optional)

duplicate of #315


Warning text icon clipped in Firefox v73+ when using high contrast mode or overriding colours

In the warning text icon, we use a 3px border (which is usually visually indistinct from the background) in order to better support users who use High Contrast Mode or override colours:

https://github.com/alphagov/govuk-frontend/blob/36edb2f5eb9447a82e195bbbc0ee31c2f6ee7bff/src/govuk/components/warning-text/_index.scss#L29-L31
Firefox 73 introduced a new 'readability backplate' feature:

Many users with low vision rely on Windows' High Contrast Mode to make websites more readable. Traditionally, to increase the readability of text, Firefox has disabled background images when High Contrast Mode is enabled. With today’s release of Firefox 73, we introduce a “readability backplate” solution which places a block of background color between the text and background image. Now, websites in High Contrast Mode are more readable without disabling background images.

The new solid 'block' of background colour causes a clipping effect around the warning text icon in Firefox 73+.

We could consider using an SVG for the icon.

After #2186 is merged, this should be fixed as and when / if Firefox implements the forced-color-adjust property – for which there are positive signals.

Firefox 89 introduces support for the forced-colors CSS media, but seemingly not forced-color-adjust.
Looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1591210 is the bug to watch for that property being implemented.

Fixed in Firefox 113 Beta:

The forced-color-adjust property is now supported, allowing authors to opt an element out of color changes in Forced Color Mode for improved readability where the automatically-picked contrasting colors are not ideal.

https://www.mozilla.org/en-US/firefox/113.0beta/releasenotes/

Firefox 113 should be released on May 9.

I'm going to close this as – other than waiting for Firefox 113 to be released – the issue has been resolved and there's nothing for us to do.


View primary room (XS)

🥦 User story
As a user, I want to be able to view the primary room so that I can send and receive messages.
🍇 Acceptance criteria
🫒 Notes:

a11y = accessibility

Acc
Given that ...
When ...
Then ensure ...

1
I am using a desktop computer, tablet, or smartphone
I view this feature
- The feature is tailored to my device- The feature follows a11y standards

2
I am on the sign in screen
I sign in
I am redirected to the primary room

3
My session is already signed in
I end up on the sign in screen
I am redirected to the primary room

4
I have not signed in
I end up in the primary room
I am redirected to the sign in screen

5
I am signed in
I end up in the primary room
The primary room transitions from the previous screen smoothly.I see any relevant attributions in the screen's footer.I can see:- A place where messages will go- A way to type a message- A way to send a message

🍍 Acceptance tests
🥕 Diagrams

Wireframe

📝 Notes

Done -- I'll rebase now so I have an easier time rebasing later.


sklearn transform_feature_names with ColumnTransformer of Pipelines

From https://stackoverflow.com/q/60949339/10495893
If an sklearn ColumnTransformer has a Pipeline as one of its transformers, then transform_feature_names fails.
I outlined one possible solution in an answer to the SO post.  I'm not too happy with it since it basically copies and edits ColumnTransformer.get_feature_names and makes that the dispatch for transform_feature_names.  I'm also not sure how to deal with conflicting in_names and
_df_columns.  An alternative, or suggested modifications?

I'd give preference to df_columns when available and in_names is None.
Your solution is reasonable, though it uses a lot of private sklearn API.
In Scikit-learn 0.23 you can use the n_features_in attribute instead of
the private equivalent, but the other private attributes there don't really
have public equivalents.
I think it would be a good idea to contribute something like this to
eli5... though we are working, very slowly, on trying to fix these
limitations in Scikit-learn. It turns out to be a hard problem to solve.


C-Binding for contantine library

create C binding for verkle in https://github.com/mratsim/constantine and try to integrate it into Besu.
This library seems to be promising regarding performance they have. We also want to do some benchmark between rust-verkle and constantine when it will be integrated into besu.
update : this C-binding should be implemented in https://github.com/hyperledger/besu-native (see the rust-verkle implementation here https://github.com/hyperledger/besu-native/tree/main/ipa-multipoint)
when it will be implemented in besu-native we need to integrate it into besu (see https://github.com/hyperledger/besu/tree/verkle/ethereum/verkletrie/src/main/java/org/hyperledger/besu/ethereum/verkletrie)
tag @agnxsh

Hey @matkt can I pick this ticket?

This should probably be in besu-native repo, since what we are looking for is a jni implementation of constantine for verkle.
@NickSneo it would be helpful to coordinate on discord

@NickSneo could you ask your question again in besu-verkle channel in the hyperledger besu discord ?  like that we will be able to coordinate https://discord.com/channels/905194001349627914/1207729310534737920

I think we can transfer this issue to besu-native
PR is already drafted


Hover states

It would be nice to have hover data on PC and touch tooltips on mobile.

@gionkunz: Would you reconsider adding hover and tool tips to Chartist out of the box? I think it's an essential feature for charts displayed in the browser. I really like the approach you took using inline SVG and CSS and you've done a great job with the documentation (the live-edit code examples are something I will most definitely steal ;)
The only fly in the ointment is that tool tips on hover are not included. I think this might as well be the most popular chart library on GitHub otherwise.
Anyway just my two Rappen. Cool project either way.

Did you check the chartist tooltip plugin?

Yes, I followed the link to the docs example but it seems broken:

Third-party plugins don't invoke a lot of trust and present an extra hurdle when getting started. That's why I would provide this functionality by default. Nothing against the plugin-approach for the more outlandish features. It keeps the code from bloating.


Korean characters are being printed when Arabic CodePages are specified

Printer: Yujin Thermal Printer
Windows
Tests done: Printed arabic using Notepad / wordpad/ msword, prints perfect.
Printed Arabic characters without codepage, prints question marks.
Thanks.
Code:
          var e = new EPSON();
            Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
            Encoding enc = Encoding.GetEncoding(1256);

            var bytes = ByteSplicer.Combine(
                    e.CodePage(CodePage.WPC1256_ARABIC),
                    e.CenterAlign(),
                    e.PrintLine(" Test Page See the Arabic text Below WPC1256_ARABIC"),
                    enc.GetBytes("طباعة صفحة إختبار "),
                    e.PrintLine("\x1D\x56\x42\x00"),
                    e.CodePage(CodePage.WPC1256_ARABIC),
                    e.CenterAlign(),
                    e.PrintLine(" Test Page See the Arabic text Below WPC1256_ARABIC"),
                    enc.GetBytes("طباعة صفحة إختبار "),
                    e.PrintLine("\x1D\x56\x42\x00"),
                    e.CodePage(CodePage.PC720_ARABIC),
                    e.CenterAlign(),
                    e.PrintLine(" Test Page See the Arabic text Below PC720_ARABIC"),
                    enc.GetBytes("طباعة صفحة إختبار "),
                    e.PrintLine("\x1D\x56\x42\x00"),
                    e.CodePage(CodePage.PC720_ARABIC),
                    e.CenterAlign(),
                    e.PrintLine(" Test Page See the Arabic text Below PC720_ARABIC"),
                    enc.GetBytes("طباعة صفحة إختبار "),
                    e.PrintLine("\x1D\x56\x42\x00"),
                    e.CodePage(CodePage.PC864_ARABIC),
                    e.CenterAlign(),
                    e.PrintLine(" Test Page See the Arabic text Below PC864_ARABIC"),
                    enc.GetBytes("طباعة صفحة إختبار "),
                    e.PrintLine("\x1D\x56\x42\x00")
            );`

(ignore the paper cuts) Korean Characters are "핸 턱한"

this is the method I send it to the printer. I don't think I'm loosing any byte data:
    public static bool SendBytesToPrinter(string szPrinterName, byte[] data)
    {
        var pUnmanagedBytes = Marshal.AllocCoTaskMem(data.Length); // Allocate unmanaged memory
        Marshal.Copy(data, 0, pUnmanagedBytes, data.Length); // copy bytes into unmanaged memory
        var retval = SendBytesToPrinter(szPrinterName, pUnmanagedBytes, data.Length);
        Marshal.FreeCoTaskMem(pUnmanagedBytes); // Free the allocated unmanaged memory

        return retval;
    }

same problem ....

you cant arabic text draw in canvas object and then you can pass canvas bitmap object to printer. it will be print as a image.

you cant arabic text draw in canvas object and then you can pass canvas bitmap object to printer. it will be print as a image.

Hey Savindu bro - thanks for the reply. I was able to print arabic using a similar gimmick for now, but there are issues like font anti aliasing is not smooth. That's why I wanted to find the issue with the library method. SendBytesToPrinter

also me , faced that issue.

see, image is not smoot, you are correct. these days I am also trying to fix that one.


Set "Turbolinks-Location" header when redirecting from routes

So that turbolinks in the browser updates the url.
https://github.com/turbolinks/turbolinks/issues/169

merge?

@rafaelfranca look at this please

@rafaelfranca merge?

Can confirm in 6.0.0

Is this supposed to be merged or is there other ways to solve this now?

@sstephenson merge?

Is this going to be merged at some point?


Update http4s-blaze-client, ... to 0.21.7

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl
org.http4s:http4s-twirl

from 0.21.4 to 0.21.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Applied Migrations

dependency:v0_21@org.http4s:http4s-scalafix:0.21.5

Documentation:

https://github.com/http4s/http4s/releases/tag/v0.21.5

labels: library-update, semver-patch, scalafix-migrations

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   12.96%   12.96%
=======================================
  Files          54       54
  Lines        2168     2168
  Branches       28       28
=======================================
  Hits          281      281
  Misses       1887     1887

Impacted Files
Coverage Δ

...src/main/scala/es/weso/server/DataWebService.scala
0.00% <0.00%> (ø)

...rc/main/scala/es/weso/server/WikidataService.scala
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c1b5d...a48f52d. Read the comment docs.


Need to specify pip version

The default recipe used to install pip 1.4.1. After the upstream released 1.5 on 1/1
http://www.pip-installer.org/en/latest/news.html#id1
our new nodes don't converge because that requires a newer version of setuptools. I don't see any way in the cookbook to specify the pip version.
Can you add that, or show me what I'm missing?  Thanks, P.

Couldn't you just use the new version of pip to install a previous version?
python_pip 'pip' do
    version '1.4.1'
end

I think this can be closed.


feat: add option to only parse versions from tags matching a tag-version-prefix (monorepo enablement)

This feature request was inspired by my question in #576
Description
Similar to #509, this feature request proposes to enable use of PSR with monorepos by constraining parsing of versions from tags based on the presence of a tag version prefix.  For example: projectA-v1.0.0.
Use cases
This feature would primarily be useful for monorepos that host multiple projects requiring individual version lineages.
Note that this feature would only be useful for repos that adopt the convention of tag prefixes.
Note that I believe this would also only be useful for projects with version_source="tag", which I believe is aligned with the intended trajectory of this project anyway, per #424.
Possible implementation
Implementation would introduce a new configuration option, perhaps called tag_prefix (or something similar ; see below).  The value of this option would be a string that is rendered into the pattern {tag_prefix}{version}.  It may be smart to either implicitly or explicitly require that the tag_prefix ends with either a - or _ character.
The tag_prefix value would then be used to match tags with matching prefix.
Questions / Challenges
What would be the best name for the proposed configuration option?  Some ideas:

tag_prefix
tag_source_prefix
tag_version_prefix
version_prefix
other?

How would this feature interplay with the tag_format option that is used for formatting the writing of versions?  I imagine these concepts should be 1) mutually exclusive, 2) well distinguished, and 3) guard-railed against clobbering each other.  Maybe this isn't a significant issue, but it's the only main potential complication I can think of, so worth a thought or two.

Hey @andrewcstewart :wave:,
Thanks for raising this separate issue, it's a good place to discuss.
I think it's a bit more involved than just the tag formats - for example even if you just use tags to understand the current version of each project, you still have to use commits to figure out the next version - I'll touch on that a bit below.
Monorepo support is definitely on the radar - together with multi-branch release strategies those are probably the longest-standing feature requests. It's also popular by demand!
The way I see it (happy to be challenged), to be able to state that we "support" monorepos I would want the following features:

git tag formats to be configurable per-project (e.g. {project}-v{version})
configuration on a per-project basis (maybe with some global options; see later)
a commit changing only one project to release only that project
a commit in one project to not affect how another project's version is calculated on its next release
the ability to write a changelog per-project and/or maintain an aggregated changelog at the project root
the ability to make a GitHub/equivalent Release + assets etc for each project
the ability to run semantic-release from the top-level of the repo to achieve this, either by targeting one project (semantic-release --project foo) or by releasing all changed projects (semantic-release). As a quality-of-life thing I think it should also be possible to run semantic-release inside a project instead of at the repo root, and release just that one project.

That doesn't mean I'd frown at PRs with less than all those things - what I'd rather avoid is halfway-steps that might need to be undone in order to fully support the above.
The main challenges I can anticipate are:

defining a good configuration format to support all the features
ensuring we don't pollute the version of one project with another's. Say projectA releases a feature and projectB releases a fix. Commits all go into the same git history, so without care PSR would run a release for projectB, see a feature commit and give it a minor version bump, when really it should only have had a patch version. You can argue this scenario isn't so bad, but if it was a major version in projectA you wouldn't want every project releasing major new versions.
adapting the current changelog to put commits under sections relevant to their projects.
handling building assets from each project (potentially python here, js there, etc) and managing how they're published/attached to GitHub release

I have been thinking this over for a while as a future feature, implementation-wise I think there's three options:

adapt PSR to also handle monorepos
create a new tool to handle monorepos, which can reuse a lot of PSR functionality - off the back of v8 this would probably be a different CLI and a couple of other differences
take more of the Node semantic-release, approach implement a plugin system and then write a plugin (that's also a feature request).

What are your thoughts on that? I personally haven't worked with many monorepos in past, so if I've missed anything that you think would also be a good feature please throw it out there too 😊

Thanks for the thorough reply @bernardcooke53 !
I think my conclusion is that I should move away from monorepos 🤣. I'm not personally a big fan of monrepos myself either but for historical reasons I'm often stuck with them.  I tend to find them more complex than should be necessary when it comes to things like CI/CD and related tooling.
As for PSR strategy - imho if there isn't a really obvious and relatively simple solution for monorepo support then I'd probably guess the plugin system idea is the best bet; especially if it appears that there are many different 'styles' of monorepo support that could potentially even conflict with each other.

In my monorepo I have a package that exports a script to run semantic release. It configures the options appropriately for the environment it's run in.
I have tag_format set to my-package-v{version}. This works to set the tag correctly.
 This seems to calculate the correct new version, as long as the latest tag matching vX.Y.Z is for the package being released.
I think this solution would completely fit my needs if get_current{_release}_version_by_tag matched the tag_format string rather than just the X.Y.Z version:
def get_pattern_with_tag_format(pattern):
    escaped_tag_format = re.escape(config.get("tag_format"))
    return escaped_tag_format.replace(r"\{version\}", pattern)

def get_version_pattern():
    prerelease_pattern = get_prerelease_pattern()
    return get_pattern_with_tag_format(rf"(\d+\.\d+\.\d+({prerelease_pattern})?)")

def get_release_version_pattern():
    prerelease_pattern = get_prerelease_pattern()
    return get_pattern_with_tag_format(rf"v?(\d+\.\d+\.\d+(?!.*{prerelease_pattern}))")

I know this would be a breaking change, but I'm not sure when a user would want the current behavior (get_current_version_by_tag to search over all version tags, and yet write tags acccording to the format).

Still in backlog, no movement as of yet.


union and union_all appear to ignore column names on sparklyr

Union order issue
spark and local data fames seem to have different union and union_all semantics (spark appears to use column indexes, and local seems to use column names).  Please see below for  a short example (and long documentation of environment).
library('dplyr')
 #
 #  Attaching package: 'dplyr'
 #  The following objects are masked from 'package:stats':
 #
 #      filter, lag
 #  The following objects are masked from 'package:base':
 #
 #      intersect, setdiff, setequal, union
library('sparklyr')
R.Version()$version.string
 #  [1] "R version 3.3.2 (2016-10-31)"
packageVersion('dplyr')
 #  [1] '0.5.0'
packageVersion('sparklyr')
 #  [1] '0.5.2'
my_db <- sparklyr::spark_connect(version='2.0.0', master = "local")
class(my_db)
 #  [1] "spark_connection"       "spark_shell_connection" "DBIConnection"
my_db$spark_home
 #  [1] "/Users/johnmount/Library/Caches/spark/spark-2.0.0-bin-hadoop2.7"
print(my_db)
 #  $master
 #  [1] "local[4]"
 #
 #  $method
 #  [1] "shell"
 #
 #  $app_name
 #  [1] "sparklyr"
 #
 #  $config
 #  $config$sparklyr.cores.local
 #  [1] 4
 #
 #  $config$spark.sql.shuffle.partitions.local
 #  [1] 4
 #
 #  $config$spark.env.SPARK_LOCAL_IP.local
 #  [1] "<IP_ADDRESS>"
 #
 #  $config$sparklyr.csv.embedded
 #  [1] "^1.*"
 #
 #  $config$`sparklyr.shell.driver-class-path`
 #  [1] ""
 #
 #  attr(,"config")
 #  [1] "default"
 #  attr(,"file")
 #  [1] "/Library/Frameworks/R.framework/Versions/3.3/Resources/library/sparklyr/conf/config-template.yml"
 #
 #  $spark_home
 #  [1] "/Users/johnmount/Library/Caches/spark/spark-2.0.0-bin-hadoop2.7"
 #
 #  $backend
 #          description               class                mode                text              opened
 #  "->localhost:53247"          "sockconn"                "wb"            "binary"            "opened"
 #             can read           can write
 #                "yes"               "yes"
 #
 #  $monitor
 #         description              class               mode               text             opened
 #  "->localhost:8880"         "sockconn"               "rb"           "binary"           "opened"
 #            can read          can write
 #               "yes"              "yes"
 #
 #  $output_file
 #  [1] "/var/folders/7q/h_jp2vj131g5799gfnpzhdp80000gn/T//Rtmpz5ZYCx/file126507d7ca72e_spark.log"
 #
 #  $spark_context
 #  <jobj[5]>
 #    class org.apache.spark.SparkContext
 #    org.apache.spark.SparkContext@8dbf495
 #
 #  $java_context
 #  <jobj[6]>
 #    class org.apache.spark.api.java.JavaSparkContext
 #    org.apache.spark.api.java.JavaSparkContext@a7cdca2
 #
 #  $hive_context
 #  <jobj[9]>
 #    class org.apache.spark.sql.SparkSession
 #    org.apache.spark.sql.SparkSession@56ebcf45
 #
 #  attr(,"class")
 #  [1] "spark_connection"       "spark_shell_connection" "DBIConnection"

Expected outcome: dplyr::union and dplyr::union_all should match columns.
Observed outcome: matches columns on local data frames, matches positions on spark2.0.0.

d1 <- data.frame(year=2005:2010,
                 name='a',
                 stringsAsFactors = FALSE)
d2 <- data.frame(name='b',
                 year=2005:2010,
                 stringsAsFactors = FALSE)

# local frames: uses names on union
dplyr::union(d1, d2)
 #     year name
 #  1  2010    b
 #  2  2009    b
 #  3  2008    b
 #  4  2007    b
 #  5  2006    b
 #  6  2005    b
 #  7  2010    a
 #  8  2009    a
 #  9  2008    a
 #  10 2007    a
 #  11 2006    a
 #  12 2005    a
dplyr::union_all(d1, d2)
 #     year name
 #  1  2005    a
 #  2  2006    a
 #  3  2007    a
 #  4  2008    a
 #  5  2009    a
 #  6  2010    a
 #  7  2005    b
 #  8  2006    b
 #  9  2007    b
 #  10 2008    b
 #  11 2009    b
 #  12 2010    b

s1 <- copy_to(my_db, d1, 's1')
s2 <- copy_to(my_db, d2, 's2')

# remore frames: uses position, co-mingline different types
dplyr::union(s1,s2)
 #  Source:   query [12 x 2]
 #  Database: spark connection master=local[4] app=sparklyr local=TRUE
 #
 #      year  name
 #     <chr> <chr>
 #  1   2007     a
 #  2      b  2008
 #  3      b  2010
 #  4   2006     a
 #  5   2008     a
 #  6      b  2006
 #  7   2009     a
 #  8   2010     a
 #  9   2005     a
 #  10     b  2005
 #  11     b  2007
 #  12     b  2009
dplyr::union_all(s1,s2)
 #  Source:   query [12 x 2]
 #  Database: spark connection master=local[4] app=sparklyr local=TRUE
 #
 #      year  name
 #     <chr> <chr>
 #  1   2005     a
 #  2   2006     a
 #  3   2007     a
 #  4   2008     a
 #  5   2009     a
 #  6   2010     a
 #  7      b  2005
 #  8      b  2006
 #  9      b  2007
 #  10     b  2008
 #  11     b  2009
 #  12     b  2010

version
 #                 _
 #  platform       x86_64-apple-darwin13.4.0
 #  arch           x86_64
 #  os             darwin13.4.0
 #  system         x86_64, darwin13.4.0
 #  status
 #  major          3
 #  minor          3.2
 #  year           2016
 #  month          10
 #  day            31
 #  svn rev        71607
 #  language       R
 #  version.string R version 3.3.2 (2016-10-31)
 #  nickname       Sincere Pumpkin Patch

Thanks for the reproducible example! It looks like the SQL generated here is as so:
> query <- dplyr::union(s1, s2)
> rendered <- sql_render(query)
> as.character(rendered)
[1] "SELECT *\nFROM `s1`\nUNION\nSELECT *\nFROM `s2`"

It seems like the problem here occurs because the columns in s1 and s2 aren't in the same order, which makes me think this must be a bug in Spark (surely the column order shouldn't matter?)

http://stackoverflow.com/questions/32705056/what-is-going-wrong-with-unionall-of-spark-dataframe
R seems to treat this a bit differently than standard SQL, but perhaps we should tweak the behavior in sparklyr or at least throw a warning?

Would it be acceptable to just transform y such that is has the same column order as x, or would this be surprising / unwarranted to users with more experience with SQL?
(How often do users perform a SQL UNION with the intention of union-ing columns based on order, rather than names? Is it common for users to manually re-order the tables before joining?)

Probably should leave this as is, if anything maybe include something in the dplyr code warning users about the discrepancy. See https://github.com/hadley/dplyr/issues/1045.

Part of the issue is there does not appear to be a bind_rows for sparklyr- so one is forced to make due with union.  An R user is going to expect some adaption and R-like semantics through a "dplyr interface."

Right, I think this comes down to the lack of bind_rows, and we should be good when that's implemented, which isn't possible until https://github.com/hadley/dplyr/issues/2457 has been resolved.

Given that you almost certainly want to match columns by names, I think that this is an issue with dplyr's implementation of UNION and UNION ALL (and probably intersect() and setdiff() too). Can someone please file an issue on dplyr with a minimal reprex created using memdb_frame()?
I see someone did mention that on the closed dplyr issue, but commenting on closed issues is an extremely bad way to get my attention.
@kevinushey I think you can close this issue since it's not a sparklyr problem

I think the issue comes down to not having bind_rows() in sparklyr. For consistency with SQL I wouldn't change the behavior of union() and union_all(). Perhaps we should close this and re-open https://github.com/rstudio/sparklyr/issues/505?

I think the behaviour of union() and union_all() is currently extremely dangerous, and I don't think we need to be consistent with SQL here.
There's currently no point in trying to build anything on top of bind_rows() because it doesn't do any dispatch.

Before closing this we need to file the bug with minimal repro that Hadley requested.

Was going to open a dplyr bug but seems to me this is already fixed. Closing.
> dplyr::union(s1,s2)
# Source:   lazy query [?? x 2]
# Database: spark_connection
    year  name
   <int> <chr>
 1  2010     a
 2  2005     b
 3  2007     b
 4  2006     a
 5  2005     a
 6  2009     a
 7  2006     b
 8  2008     b
 9  2010     b
10  2007     a
11  2008     a
12  2009     b
> dplyr::union_all(s1,s2)
# Source:   lazy query [?? x 2]
# Database: spark_connection
    year  name
   <int> <chr>
 1  2005     a
 2  2006     a
 3  2007     a
 4  2008     a
 5  2009     a
 6  2010     a
 7  2005     b
 8  2006     b
 9  2007     b
10  2008     b
11  2009     b
12  2010     b


Drag and drop of items only works from vehicles to characters, not characters to characters

You can drag stuff from a ship to a person, but not from a person to a person.
I'm mostly filing so I don't forget to look into it, but any thoughts anyone else has would be awesome.

I will check, person to person should be available as long as the player dragging has owner rights to both objects.  Technically if it works Ship to Person and Person to Ship it is still actor to actor transfers.  Its definitely possible at some point it got broken.

I will check, person to person should be available as long as the player dragging has owner rights to both objects.  Technically if it works Ship to Person and Person to Ship it is still actor to actor transfers.  Its definitely possible at some point it got broken.


Set privacy settings for Firefox

Not all will be a good fit, some might be dependent on other settings (smart card, client certificates, etc)
Refs:

https://privacytools.io/browsers/#about_config

Completed with 8eef5ee


Task: Fix your model

@rafj58 build fails with
Error: /home/runner/work/Chirp/Chirp/src/Chirp.Infrastructure/DbInitializer.cs(125,43): error CS0029: Cannot implicitly convert type 'int' to 'System.Guid' [/home/runner/work/Chirp/Chirp/src/Chirp.Infrastructure/Chirp.Infrastructure.csproj]
we need to update the database seeding if we use guids


luci-base: fix a typo in Russian translation

Signed-off-by: Anton Kikin<EMAIL_ADDRESS>

Thank you


[[Power-Fx]] Localization hand-back [CTAS - RunID=20240410-211903-d2w1kr1s86]

Translation handback check-in (PR Created by automation).

✅ No public API change.

Do as well


Updated Spatial Awareness System

XRTK - Mixed Reality Toolkit Pull Request
Overview

Updated lumin submodule with latest changes and fixes.
Updated LuminBuildTools to check if devices are available before trying to install.

Breaking Changes

Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile
Updated SpatialAwarenessMeshLevelOfDetail to be more consistent

Submodule changes

https://github.com/XRTK/Examples/pull/20
https://github.com/XRTK/SDK/pull/206
https://github.com/XRTK/Lumin/pull/90
https://github.com/XRTK/WindowsMixedReality/pull/105

Blocked, needs 2019.4 LTS

I'd like to see LuminPlayerBuildTools moved to the Lumin module but there is probably a reason for it to be in Core.

Agreed but that work is slated for 0.3


Doesn't work in Chrome

Function does not work in Chrome v. 72.0.3626.81 .  No error message thrown, it simply doesn't show the file picker.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 236899f1-c924-5f19-c9d4-d86ef281e32f
Version Independent ID: 93767572-6979-c655-8561-1bc51961f0c6
Content: pickFile
Content Source: ce/developer/clientapi/reference/Xrm-Device/pickFile.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

Thanks for your feedback.

To report issues with the product, pls visit: https://experience.dynamics.com/ideas/
For support-related issues, pls visit https://docs.microsoft.com/en-us/dynamics365/get-started/support/
Closing the issue.


[1.10.2] Crash when using mod Chisel

I have posted this on Chisels issue tracker and they said it was a Minetweaker problem.
https://github.com/Chisel-Team/Chisel/issues/289

Wrong repo.
https://github.com/jaredlll08/ModTweaker

Well I'm not using Modtweaker, I'm using Crafttweaker. My Crash Report says MInetweaker, and the list of mods shows Crafttweaker. :(

try with this version please
http://blamejared.com:8080/job/CraftTweaker/50/

The version you had me download, along with the newest version of Chisel works! Thanks a bunch for getting whatever was causing it figured out.

This is fixed now


Title: Polynomial Long Division Calculator

Is your feature request related to a problem? Please describe.
This application performs the long division of polynomials.
Describe the solution you'd like.

To divide a polynomial by another one:

Enter each polynomial in terms of x or X, without spaces between each term.
Use the power symbol (^) for terms with order more than one.

Click on (Divide) button.
To perform another division operation click on (Clear) button.

I am a GSSoC'22 participant. Please assign it to me.
Describe alternatives you've considered.
--
Add any other context or screenshots about the feature request here.
I have uploaded it on GitHub which URL is given below:
(https://github.com/Salma-Hamed/Polynomial-Long-Division-Calculator).

@swapnilsparsh why did you close this issue

Try to be more innovative with your project idea as we already have many projects like this.


python312Packages.rasterio: 1.4.2 -> 1.4.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.rasterio is: Python package to read and write geospatial raster data
meta.homepage for python312Packages.rasterio is: https://rasterio.readthedocs.io/
meta.changelog for python312Packages.rasterio is: https://github.com/rasterio/rasterio/blob/1.4.3/CHANGES.txt
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.4.3 with grep in /nix/store/z6bqwlhrf5a8kf5g1fjvqs0fnzg723xa-python3.12-rasterio-1.4.3
found 1.4.3 in filename of file in /nix/store/z6bqwlhrf5a8kf5g1fjvqs0fnzg723xa-python3.12-rasterio-1.4.3

Rebuild report (if merged into master) (click to expand)

11 total rebuild path(s)

11 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.morecantile
python311Packages.osmnx
python311Packages.rasterio
python311Packages.rio-tiler
python311Packages.rioxarray
python312Packages.morecantile
python312Packages.osmnx
python312Packages.rasterio
python312Packages.rio-tiler
python312Packages.rioxarray

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z6bqwlhrf5a8kf5g1fjvqs0fnzg723xa-python3.12-rasterio-1.4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.rasterio https://github.com/r-ryantm/nixpkgs/archive/a333cf53c7c33eaf3fff2454f5617d601efc211c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a333cf53c7c33eaf3fff2454f5617d601efc211c#python312Packages.rasterio

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z6bqwlhrf5a8kf5g1fjvqs0fnzg723xa-python3.12-rasterio-1.4.3
ls -la /nix/store/z6bqwlhrf5a8kf5g1fjvqs0fnzg723xa-python3.12-rasterio-1.4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:fast_forward: 4 packages marked as broken and skipped:

python311Packages.rio-tiler
python311Packages.rio-tiler.dist
python312Packages.rio-tiler
python312Packages.rio-tiler.dist

:x: 4 packages failed to build:

python311Packages.rioxarray
python311Packages.rioxarray.dist
python312Packages.rioxarray
python312Packages.rioxarray.dist

:white_check_mark: 12 packages built:

python311Packages.morecantile
python311Packages.morecantile.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.rasterio
python311Packages.rasterio.dist
python312Packages.morecantile
python312Packages.morecantile.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.rasterio
python312Packages.rasterio.dist

Maintainer pings
cc @autra @imincik @l0b0 @nh2 @nialov @sikmir @willcohen for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

This PR is breaking rioxarray (it is building fine with master).
$ nix-build -A python3Packages.rioxarray

...

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED test/integration/test_integration__io.py::test_rasterio_environment - Failed: DID NOT RAISE <class 'Exception'>
FAILED test/integration/test_integration_merge.py::test_merge__different_crs[True] - AssertionError:
FAILED test/integration/test_integration_merge.py::test_merge__different_crs[False] - AssertionError:
= 3 failed, 459 passed, 17 skipped, 8 deselected, 2 xfailed, 2 xpassed, 419 warnings in 7.45s =
error: build of '/nix/store/5q8bxayw0qlli4h20i2pvy9b6f6pksxn-python3.12-rioxarray-0.18.1.drv' on 'ssh-ng://im-builder.tail6adb8.ts.net' failed: builder for '/nix/store/5q8bxayw0qlli4h20i2pvy9b6f6pksxn-python3.12-rioxarray-0.18.1.drv' failed with exit code 1;
       last 10 log lines:
       >
       > test/integration/test_integration_xarray_plugin.py::test_open_multiple_resolution
       >   <frozen _collections_abc>:868: RuntimeWarning: deallocating CachingFileManager(<function open at 0x7ffee13b0040>, 'HDF4_EOS:EOS_GRID:/build/source/test/test_data/input/MOD09GA.A2008296.h14v17.006.2015181011753.hdf:MODIS_Grid_500m_2D:num_observations_500m', mode='r', kwargs={'sharing': False}, manager_id='9b01d24c-019c-4c4e-976a-29a7be5fff32'), but file is not already closed.

Result of nixpkgs-review pr 362893 run on x86_64-linux 1

4 packages marked as broken and skipped:

python311Packages.rio-tiler
python311Packages.rio-tiler.dist
python312Packages.rio-tiler
python312Packages.rio-tiler.dist

16 packages built:

python311Packages.morecantile
python311Packages.morecantile.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.rasterio
python311Packages.rasterio.dist
python311Packages.rioxarray
python311Packages.rioxarray.dist
python312Packages.morecantile
python312Packages.morecantile.dist
python312Packages.osmnx
python312Packages.osmnx.dist
python312Packages.rasterio
python312Packages.rasterio.dist
python312Packages.rioxarray
python312Packages.rioxarray.dist


Destroy trigger fired before confirmation

I defined a destroy trigger like this:
    config.trigger.before :destroy, :stdout => true, :stderr => true do
        run_remote "/vagrant/cleanup.sh"
    end

This leads to cleanup.sh being called right before confirmation.
Do you see any way to get the trigger called only if confirmation is given or --force is used?

How do I understand this bug is not resolved?


Port to Godot 4

[ ] Try 3-4 converter

Still hadn't the chance to test Godot 4. Is there any auto-converter or it should be done by hand?


Scores are smaller

Hey. I converted Pytorch model to ONNX with this: https://github.com/ultralytics/ultralytics :
model.export(format="onnx").
Is it because.

I need to change something in my code when using inference with your tool?
I need to change something the code of your tool?
It's the result of the conversion to ONNX?

Could you please help? (:
Some comparison:
ONNX (first image):
[['bear', 0.7407247424125671],
 ['apple', 0.5914568901062012],
 ['apple', 0.5120987892150879]]

Torch (first image):
[['bear', 0.8472723364830017],
 ['apple', 0.6253159046173096],
 ['apple', 0.6134308576583862]]

(second image)
ONNX: 0,6926791071891785
Torch: 0,8411726951599121
Also ONNX model on conversion is for some reason way bigger than Torch's...

Fixed: https://github.com/ibaiGorordo/ONNX-YOLOv8-Object-Detection/issues/8#issuecomment-1595629369


The 'bin' icons do not work - i cannot delete items from character sheet

Describe the bug
The 'bin' icons do not work - i cannot delete items from character sheet
To Reproduce
Steps to reproduce the behavior:

Go to the equipment page of the Actor sheet for Expanse AGE
Click on drag a weapon (eg, únarmed combat'from Expanse AGE quickstart)
Scroll down to item
clicking the bin does not remove the item
Expected behavior
A clear and concise description of what you expected to happen.
the item to be removed from Actor sheet when the bin is closed
None of the bins icon work, ie the bins next to talents in the talent & specialisation tab do not work either
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: windows 11
Browser Chrome
97.0.4692.71

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@MinkGoblin what version of Foundry are you using?

Foundry version 9 build 242
Expanse RPG (AGE) 0.7.2

Foundry version 9 build 242 Expanse RPG (AGE) 0.7.2

Updating the Expanse system to 0.8.1 should fix that issue

fixed, tyvm


add back GCM cipher

we originally removed GCM from the cipher chain due to vulnerabilities in OpenSSH. We are adding it back, since any sensible implementation will have had enough time to fix or backport. On top of that, GCM is generally a preferred algorithm. Let's get it back now.
Signed-off-by: Dominik Richter<EMAIL_ADDRESS>

Coverage remained the same when pulling 32f14ac15469c47a3edccbf0989307e79d79432a on gcm into dcfc0a89079d4ebfca1620e4c932b61846f2542f on master.

great work @arlimus


Dislocated video and stream buttons

When you lack the permission to stream into a voice channel, the video and stream buttons are dislocated.

Fixed


Overall Data Model Definition [5]

Description
As a developer, I want to understand the overall data model of the system on a detailed level.
Functional Acceptance Criteria

There is a definition for the data model at large that defines the entities in the system and the relationships between them on a detailed level, including the type and cardinality of relationships.

Note: the definition must not be complete and describe the system in it's final form. The resulting model will be iterated over later. It must contain anything that we can currently have to deal with and anything that might be involved with it. Part of this story is to make sure we have an iterable model that contains everything that we need now and that can be iterated over later without breaking the whole system or creating lots of throwaways. So this story requires some foresight and some discipline in drawing out a "current needed state" of the model.
Note: this is a "technical userstory" that is not recommended in a Scrum process, but in reality very common. It provides means of doing technical groundwork that is not directly covered by user experiences. The "story" is needed to integrate the work entity into the existing process.
Non-functional Acceptance Criteria

The resulting artifacts are one or more documents and/or a diagrams in devdocs.
The resulting artifacts are considered a architecture/definition that includes all above FACs.

minor nit, I added a plural on the docs/diagrams.

Working version here: https://www.lucidchart.com/invitations/accept/962892d5-4cbf-4d06-bba3-63720e2df979

Open questions:

is an Epic a work item type, an iteration "type" or a seperate entity?
why is there no "IterationType"?

Epic is a WorkItemType

Todd commented on this yesterday:

Epic is a Work Item Type instance, or in other words, part of the scheme, no seperate entity.
For the first step, it is sufficient to just let the user create epics by creating a WI with the selected type epic. So no extra UI for it.

Done. Demoed in review.


Remove the v1 API

Remove the v1 API
No longer rely on tastypie

Open questions

The embed API is still under /api/v1/embed/. This does not remove that. Perhaps that endpoint should be moved or mirrored under /api/v2? The embed API does not use tastypie. Update: Moved to /api/v2/embed/...

Shouldn't we at least left the docs page with a warning explaining that v1 was completely removed? Maybe linking to the post or redirect to v2/v3?

The embed API is still under /api/v1/embed/. This does not remove that. Perhaps that endpoint should be moved or mirrored under /api/v2? The embed API does not use tastypie.

There are some discussions about that in https://github.com/rtfd/readthedocs.org/issues/5207 and https://github.com/rtfd/readthedocs.org/issues/2667#issuecomment-442248352

Shouldn't we at least left the docs page with a warning explaining that v1 was completely removed? Maybe linking to the post or redirect to v2/v3?

I'm not opposed to leaving the v1 doc and putting a large note there that it has been removed. It also should not be in the toctree.

At the same time, I'm not sure the v1 docs are that useful. After this PR, they won't work at all.

I do wonder about rolling this out slowly, if we can. Perhaps doing a brownout of these API's at the Nginx level for a day, then a week; similar to what GH did for webhooks. That would give anyone still depending on it time to migrate before we totally kill it.

I think this is a good idea.

I think it's worth keeping the v1.rst around with a note that it's been removed. We don't need the old content, but it shouldn't just "disappear".

I re-added the page although it's blank except for noting that the API has been removed. I think that's good in case people have links to the API or whatnot but I think the content of the page ceases to have value once the API is turned off.

Also, the embed API has now been mirrored to https://readthedocs.org/api/v2/embed/.

Looks like we can remove more dependencies here
https://github.com/rtfd/readthedocs.org/pull/5389/files#r262275644

And guessing that we can remove some dependencies from the installation guide
https://github.com/rtfd/readthedocs.org/blob/master/docs/install.rst#L41-L42

We've been returning failures for API v1 for over a week and I haven't heard anything. I think this is ok to go. I'll see if I can remove those deps.

I'll see if I can remove those deps.

lxml is required by pyquery but I'll update the comments and move it to a more appropriate spot in the requirements file.

I should also add that while defusedxml is not strictly required, I think that we should install defusedxml as long as lxml is used. DefusedXML is a library that attempts to mitigate or remove XML parsing vulnerabilities and in many cases it monkeypatches other libraries.


completions create: support stream?

see: https://beta.openai.com/docs/api-reference/completions/create#completions/create-stream
should we support stream response?

I'm very interested in the stream response functionality, so I'm voting for it to be implemented.

+1 - This would be a great addition.

@gehrisandro What would this represent in terms of code changes?

I added today to @orhanerday/open-ai You can copy it from my repo :)

@nunomaduro I added today to @orhanerday/open-ai You can copy it from my repo :)

In the current draft we trying to save the same CreateResponse object which allows to iterate over himself when stream response was requested.

I switch this package instead https://github.com/orhanerday/open-ai#stream-example

@nunomaduro some news on this functionality (Streaming)


READONLYCODE build option/flag needed

These are mandated C standard globals. These have been moved from the RESLIB GCCLIB to the stub code of the client program. But of course for BREXX that also needs not to have these globals!
/* Stdlib Public Global Variables */
FILE stdin;               / predefined stream for standard input: we map it to console */
FILE stdout;              / predefined stream for standard output: we map it to console */
FILE stderr;              / predefined stream for error output: we map it to console /
int errno = 0;             / Std error number */
In cmsrtstb.c
Anyway - we need to add a READONLYCODE build option/flag - that will instead make these available as macros for client programs like BREXX that are targeting a shared segment.

Note that in the standards the stderr, stdin, or stdout need not be modifiable lvalues to which the value returned by the fopen function may be assigned. So can me macro for everyone.

So we are moving everything to read-only code segments - this will be the only option for GCCLIB


Fix Linux build

Set V4L2 and pulse CFLAGS/LIBS from system pkg-config
Fix missing LIBS from openwebrtc-daemon LDADD
Fix ordering of GStreamer libraries (libgst-1.0 moved to earlier in the list)

Agreed - it's not pretty, but should be good enough to tide us over until we move to Cerbero.

Seems ok to me too, let's merge?

This was fixed in the cerbero build last week.


Add new FiniteCycle type as the return type of Collection.cycled(times:)

This PR aims to fix #99. I have also split up some relevant tests into separate methods for empty collections and changed some tests for FiniteCycle. I have also added tuple labels to Product2 when using the Iterator.next() method and also in the subscript method. This is a cosmetic improvement, but I felt it may read better.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

Thanks for taking this on @LemonSpike, this is a great start! Your FiniteCycle correctly delegates all of the work to an underlying Product2<Range<Int>, Base>. However, the real benefit will come from being able to efficiently implement all of the Collection methods that Product2 already implements. By forwarding all public Collection and BidirectionalCollection methods to an underlying Product2 collection, FiniteCycle will have all the same performance characteristics as Product2. Want to have a go at that?

Thanks for the feedback @timvermeulen! I have tried to add the Collection protocol conformances this time by forwarding to an underlying Product2 collection. Are these what you had in mind? Thanks.

This is indeed what I had in mind, great work! The Collection conformance looks good, it implements all the relevant methods. There are just a few things left to do:

We can get rid of the Sequence conformance entirely — normally it's needed in case the base type is only a Sequence and Collection cannot be implemented, but in the case of FiniteCycle we already require that Base: Collection, so it's no longer needed. In the same vein, the type needs LazyCollectionProtocol conformance rather than LazySequenceProtocol.
FiniteCycle is still missing some conformances that Product2 does have, implemented here.
Most public methods are missing @inlinable annotations.
The Cycle.md guide needs a slight tweak to reflect that cycled(times:) now has a new return type.

Hi @timvermeulen, thanks for the feedback. Re: your points, I tried to implement your suggestions as follows:

I removed the Sequence conformance entirely. To conform to LazyCollectionProtocol I had to conform to LazySequenceProtocol and LazyCollectionProtocol together where Base: LazyCollectionProtocol, because I couldn't inherit LazySequenceProtocol conformance automatically.
Managed to add these as suggested, but because the FiniteCycle.Index is a typealias for Product2.Index, the Index Hashable conformance was already synthesized.
Added @inlinable to all public methods, by making the let product public.
Markdown file edited but reworded without despite its name since the name no longer includes Sequence.

Let me know your thoughts. Thanks.

Apologies for the delay, @LemonSpike!

I removed the Sequence conformance entirely. To conform to LazyCollectionProtocol I had to conform to LazySequenceProtocol and LazyCollectionProtocol together where Base: LazyCollectionProtocol, because I couldn't inherit LazySequenceProtocol conformance automatically.

We can get rid of the Iterator type and makeIterator method entirely. The typechecker did get confused about what the Element type is after I tried doing this, so you might need to add typealias Element = Base.Element to the Collection conformance.

Managed to add these as suggested, but because the FiniteCycle.Index is a typealias for Product2.Index, the Index Hashable conformance was already synthesized.

Great point! Let's for now give FiniteCycle its own Index type that wraps a Product2.Index, just so in the future we have the freedom to change the internals if the need ever arises.

Added @inlinable to all public methods, by making the let product public.

While we make all public and internal methods @inlinable, for stored properties @usableFromInline suffices, so there's no need to make the property public.

Markdown file edited but reworded without despite its name since the name no longer includes Sequence.

That looks good, could you also have it mention the conditional LazyCollectionProtocol conformance, similar to the Cycle description? And there's a note a bit higher up about cycled(times:) being a combination of two existing standard library functions which we can probably get rid of altogether.

I changed some @usableFromInline internal methods to @inlinable because of #109.

💯

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

Looks great, @LemonSpike — thanks for this addition! 🎉


Trying to run cargo kani on firecracker/vm-memory results in goto-cc crash

Running cargo kani on on the vm-memory module of firecracker (even without adding any #[kani::proof] attributes to the code)
unexpected end of input stream
Error: goto-cc exited with status exit status: 70

I tried this code:
https://github.com/firecracker-microvm/firecracker/
using the following command line invocation:
Inside the firecracker repository (assuming a firecracker development environment has been set up), enter the docker container via ./tools/devtool shell -p and install kani in there. Then navigate to src/vm-memory and run cargo kani -p<EMAIL_ADDRESS>with Kani version: cargo-kani 0.12.0
I expected to see this happen: kani to not crash
Instead, this happened: kani crashes

This seems to be a spurious error fixed by running cargo clean (see #1591)


Stack Creation Time Exceeded the Specified Timeout for "ElasticsearchStack"

If your issue relates to the Discovery Process, please first follow the steps described in the implementation guide Debugging the Discovery Component

Describe the bug
Every stack completes except for the "ElasticsearchStack."
To Reproduce
Simply deploying AWS Perspective reproduces this problem.
Expected behavior
Stack creation should complete
Screenshots

Browser (please complete the following information):

Name: Firefox
Version: 78.8.0esr

Additional context
None

Please create a new issue tagged with v1.1.0 if you are still experiencing this issue.


Async evaluation

It'd be nice if Project.run had an async interface. Right now evaluations freeze the entire JS thread.
There are problems with this (wrapping stuff in promises and passing continuations around is not easy) and we might solve the same issue with web workers. But I'm filing this here for future reference and discussions.

I think we have to go for web workers and shared memory. And we should not bother to support environments where shared memory is not available.

I still think we need all of:

async evaluation (e.g. for reporting progress, that won't be possible with synchronous execution)
web workers (for performance)
persistent results (#1198 includes arguments for those)

I tried to implement async squiggle code evaluation.
It's not hard technically, but the performance turned out to be prohibitive; it's 20x slower than the sync version for the basic List.upTo(1, n) -> map({|x| x}) benchmark.
There's some potential for optimizations (for example, not all function registry definitions have to be async, only those that take lambdas as a parameter), but I don't expect it to help enough for async to be viable.
Also, supporting both sync and async version would be a pain, we'd have to keep duplicate copy-pasted versions for half of our codebase.

I don't think this is possible anymore.
We should start using Web Workers instead.


Dialogue between personas

Make it possible for multiple personas to have a discussion between each other. The number of personas can be unlimited.
Ideally we would spin up one agent per persona and have the messages go back and forth between the agents.
All the conversations should be part of a unique session for each agent.
If an agent budget is consumed, they will stop participating in the discussion.

This is achievable by having 2 agents running on separate servers and connecting them with each other.
What we need now is to initialize a conversation that makes the agents communicate with one another.
Using a task such as Simple and adapting it to send a request to another agent would be a good way to get this task started.


Patch v0.16.6 compatibility

v0.18 purports to be backwards-compatible with v0.16.6 datasets. However, this is not currently the case because it does not appropriately handle missing app_configs.
fiftyone zoo datasets load quickstart
fiftyone migrate -v 0.16.6 -n quickstart
export FIFTYONE_DATABASE_ADMIN=false

import fiftyone as fo
import fiftyone.core.odm as foo

dataset = fo.load_dataset("quickstart")
db = foo.get_db_conn()

# Scenario 1: entire `app_config` is missing

assert "app_config" not in db.datasets.find_one({"name": "quickstart"})
assert dataset.version == "0.16.6"
assert dataset.app_config is not None  # previously failed; now doesn't

session = fo.launch_app(dataset)  # TODO: fix this

# Scenario 2: any part(s) of `app_config` are missing

dataset.app_config.grid_media_field = "foo"  # force mongoengine to detect a change
dataset.app_config.grid_media_field = "filepath"
dataset.save()

print(db.datasets.find_one({"name": "quickstart"})["app_config"])  # None
# {'grid_media_field': 'filepath'}

session = fo.launch_app(dataset)  # TODO: fix this

unset FIFTYONE_DATABASE_ADMIN

@benjaminpkane can you help resolve the App-side TODOs here?

Media fields are now optional. The first to do was already working for me. LMK if I missed this something.

LGTM, thanks @benjaminpkane! Can you approve? 😄


ROI Testing

I tested master ROI commands usiung master QGC. The attached plan has two ROIs set in it. The vehicle seems to respond correctly to the first ROI but ignores the second ROI. I tested both with MIS_MNT_YAW_CTL enabled and disabled. Both modes didn't correctly handle the second ROI.
ROITesting.plan.zip

Just tried again and it seems to be working now. I say "seems" because I swear even one time this test cycle it didn't do the second ROI correctly. But I couldn't reproduce, so I'm assuming I was seeing things incorrectly that one time.


Fix RSVP module reference

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Fixes https://github.com/ciena-blueplanet/ember-cli-visual-acceptance/issues/103
Fix RSVP reference and switch to var Promise = require('es6-promise').Promise

@ro0gr I assume this causes no problems right? I don't know why utils.js has the promise require while the other commands don't.  I assume its just an mistake to include one and not the others or if the utils.js isn't necessary. Eithier way this quick fix should do the trick.

Visual Acceptance tests:
No changes

@EWhite613 - Your updates fixed the issue I reported.

Looks like rsvp had been originally used in runCommand  https://github.com/EWhite613/ember-cli-visual-acceptance/commit/a81f308d1b474d95509c5c36b710526f36b0958c
I think it can be safely replaced with a project wide es6-promise.

@EWhite613 ^


Add test coverage to start_tracing code paths

Description
This change adds test coverage to the code paths invoked by the start_tracing() function (which is how we tell users to set up tracing). It also extracts, encapsulates, and injects environment variable i/o.
Addresses #324
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Add tests

How Has This Been Tested?

[ ] Tested manually
[x] Added automated tests

Checklist:

[ ] Changelogs have been updated
[x] Unit tests have been added/updated
[ ] Documentation has been updated

My only concern is that if we mock out env vars, we never test the code path taken by the users (via OSEnvVars).

That's a great point. I happen to have tested it end-to-end manually, but we might need additional integration tests as well.

There are two great (and long due) things we need that are a part of this pull request: separation of the env variable logic and the tests.
The refactor itself I believe is a bit premature: it will require reworking the rest of the code to conform to the same style, including the work we have in progress for profiling and metrics. For now we should be following the existing repo style for tests.
We can either close this pull and then restart the conversation and reopen once the release for metrics and profiling has been completed, or rework the existing changes to conform to the repo style first. Let me know what you want to do.


[ISSUE] Messagebox should auto capitalize

Hi,
I notice that SpeakGPT is among the rare apps where typing in the textbox does not capitalize the first letter of a sentence. Given that natural text input is expected inside, I think it should be.
Have a nice day!

I disabled this function in all my apps as it annoying me.

Oh okay. My keyboard has the autocapitalization option. Maybe yours does too? If you turned it off that might be better for you. I'm using simple keyboard, it's on fdroid.

Should be fixed in 2.37

Thanks! I don't know if it is intentional but the autocapitalization was enabled in the chats but not in the assistant chat I think. Just in case I prefered to tell you


Step 0: ping pong in the localhost

This is the first experiment, with a basic ping pong scenario working.
The are two programs: the directory (mcdir) and the node (mcnode).
First you need a directory running; you can do that by running mcdir.
Then you can start a couple of nodes, by running mcnode (you need to pass the directory handle printed by mcdir).
Each node exports a RESTful clinet API; it currently supports two methods:

/id which prints the peer id
/ping/peer-id which lookups peer-id in the directory and pings the node (returns OK if the ping was successful.

A small example illustrating usage:
shell0 $ mcdir
2016/09/09 21:20:02 Generating key pair
2016/09/09 21:20:02 ID: QmbF87NnyoN3msnmifXhCMUpCRK6C8uXxqAgr93QVa67xS
2016/09/09 21:20:02 I am /ip4/<IP_ADDRESS>/tcp/9000/QmbF87NnyoN3msnmifXhCMUpCRK6C8uXxqAgr93QVa67xS`
...

shell1 $ mcnode /ip4/<IP_ADDRESS>/tcp/9000/QmbF87NnyoN3msnmifXhCMUpCRK6C8uXxqAgr93QVa67xS
2016/09/09 21:20:30 Generating key pair
2016/09/09 21:20:30 ID: QmXdkCFvS4EzuSF3XeaWAS5HxM2uPC9TKWcTZGoiBERobU
2016/09/09 21:20:30 I am /ip4/<IP_ADDRESS>/tcp/9001/QmXdkCFvS4EzuSF3XeaWAS5HxM2uPC9TKWcTZGoiBERobU
2016/09/09 21:20:30 Serving client interface at <IP_ADDRESS>:9002
2016/09/09 21:20:30 Registering with directory
...

shell2 $ mcnode -l 9003 -c 9004 /ip4/<IP_ADDRESS>/tcp/9000/QmbF87NnyoN3msnmifXhCMUpCRK6C8uXxqAgr93QVa67xS
2016/09/09 21:21:13 Generating key pair
2016/09/09 21:21:13 ID: QmQg6PiJ6ouBK6pEukZ9rsVRJC7gnt8gvp78gp7XtippJ6
2016/09/09 21:21:13 I am /ip4/<IP_ADDRESS>/tcp/9003/QmQg6PiJ6ouBK6pEukZ9rsVRJC7gnt8gvp78gp7XtippJ6
2016/09/09 21:21:13 Serving client interface at <IP_ADDRESS>:9004
2016/09/09 21:21:13 Registering with directory
...

shell3 $ curl http://<IP_ADDRESS>:9002/ping/QmQg6PiJ6ouBK6pEukZ9rsVRJC7gnt8gvp78gp7XtippJ6
OK

Got this working locally, but had to do a gx install to get all the deps first.  Works as advertised 👍

I think a setup script that install the dependencies might be in order.

I can run setup successfully but both build and install give me
[vyzo-ping-pong¹//concat]% ./install.sh                                             (arkadiy@molybdenum:~/mine/concat/)
mc/util.go:4:2: cannot find package "context" in any of:
	/usr/local/Cellar/go/1.6.3/libexec/src/context (from $GOROOT)
	/Users/arkadiy/go/src/context (from $GOPATH)
mc/message.go:4:2: cannot find package "github.com/mediachain/concat/proto" in any of:
	/usr/local/Cellar/go/1.6.3/libexec/src/github.com/mediachain/concat/proto (from $GOROOT)
	/Users/arkadiy/go/src/github.com/mediachain/concat/proto (from $GOPATH)
progs/mcdir/main.go:6:2: cannot find package "github.com/mediachain/concat/mc" in any of:
	/usr/local/Cellar/go/1.6.3/libexec/src/github.com/mediachain/concat/mc (from $GOROOT)
	/Users/arkadiy/go/src/github.com/mediachain/concat/mc (from $GOPATH)

also these rewrites are really not git-friendly, hmm

oh, I think you need go 1.7 - they moved context into the standard lib from a google contrib repo or something

lgtm, let's merge


Typo label detected on food_1, to check on other columns for all raters on all aspects

ACTIONS

by using ipython, load labelled_data_table as ldt
ldt = catalog.load("labelled_data_table")
count values:
ldt['food_1'].value_counts()
or search unique values:
ld['food_1'].unique()

RESULT
In [8]:  ld['food_1'].value_counts()
Out[8]:
positive    2939
unknown      504
negative     421
negtive        1
Name: food_1, dtype: int64

EXPECTATION
label 'negtive' should be mapped to 'negative'

Fix included in #15


Audio PR4 - Adding support for file list reader

@SundarRajan28 Please add example of how to use this file list reader

@SundarRajan28
As discussed, Please see if label_file_list_reader can be replaced with TextMetadataReader since both are reading the image name and labels from the file

@SundarRajan28
As discussed, Please see if label_file_list_reader can be replaced with TextMetadataReader since both are reading the image name and labels from the file

@swetha097 @SundarRajan28
This PR introduces a new Reader and a new MetadataReader, please check if it can be handled with existing setup itself

The TextMetadataReader also reads file names and labels from the text file, instead of new Metadata reader maybe we can use that
The FileSourceReader can be modified to read from text file, i.e if a folder is passed we can use the existing code, if a text file is being passed we can detect than and read the files from the text file and use the same FileSourceReader itself, instead of new Reader
In future if we have text file for images case then this would help us as well
Ensure the path is set correctly as audio required the folder path and text file path to be set in the reader config

This will avoid redundant readers

@SundarRajan28 , Please merge all previous PR's
Add the file changes as discussed, I think it is not pushed yet
Will review once these changes are done and tested


Merge bradfitz's tcpproxy code.

This codebase is more capable, and exposes an API rather than just a binary. It'll be the basis of future development.

Note that github seems to lose its mind over pull requests that merge unrelated histories, so there' s a decent chance we'll end up with a double-merge in the history when we apply this. I tried to help github be more reasonable, but failed. My plan if we end up with multiple merges is I'll just tidy up the history and push -f once to destructively tidy stuff up.

LGTM.


Nested Enums?

We're great fans of serde, great fans of YAML — thank you very much for the library.
Is there any workaround to the Error("serializing nested enums in YAML is not supported yet")? We're tried removing nested enums from our AST, but aren't able to do this fully (https://github.com/PRQL/prql/pull/2172#issuecomment-1478275290). We'd really like to represent our AST in something less verbose than JSON for human readability.
I've tried various incarnations of https://serde.rs/enum-representations.html, but not yet successfully.
Thanks a lot...

You could try using https://docs.rs/serde_yaml/0.9/serde_yaml/with/singleton_map which does not have that limitation.
use serde::{Serialize, Serializer};

#[derive(Serialize)]
#[serde(remote = "Self")]
pub enum ExprKind {
    ...
}

impl Serialize for ExprKind {
    fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
        struct ExternallyTaggedExprKind<'a>(&'a ExprKind);
        impl<'a> Serialize for ExternallyTaggedExprKind<'a> {
            fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
                ExprKind::serialize(self.0, serializer)
            }
        }
        serde_yaml::with::singleton_map::serialize(&ExternallyTaggedExprKind(self), serializer)
    }
}

Thank you very much! I did this in https://github.com/PRQL/prql/pull/2277 (I used just the derive approach from the docs, which seems to work well)
Fine to close!

Not trying to open up old questions but when you're here and you are looking for this just as I just did (for the second or third time lol):
Check out the recursive version that allows Enums in HashMap, Vec etc. etc.:
https://docs.rs/serde_yaml/latest/serde_yaml/with/singleton_map_recursive/index.html
I'll just leave that here with greeting to future people (and me) who are googling a similar thing and finding this exact issue.


DDG-171: Added support for storing the Preservica type and id.

This change adds support for storing the Preservica type and id.
@terenceingram @scoen @JonathanShaw

Looks ok to me


Lab 24: Hyperlink incorrect

Lab/Demo: 24
Description of issue
Hyperlink on rule 51 is incorrect.
Sign in to [https:portal.azure.com] (https:portal.azure.com).
It should be:
Sign in to https://portal.azure.com.

Fixed - thank you for finding this and submitting!


Provide test coverage for pull requests in summary comment

I think it would be useful to have a test coverage report for pull requests.
It could be a bitcoin/bitcoin cirrus job that generates the report and sends it back to DrahtBot with a webhook to display it in the summary comment.

Currently it is not trivially possible to generate the coverage from tests and fuzzing. Maybe it is sufficient to just run non-fuzz tests? (See https://github.com/MarcoFalke/DrahtBot/blob/main/scripts/coverage.py and https://github.com/MarcoFalke/DrahtBot/blob/main/scripts/coverage_fuzz.py)
It will also require hosting the report somewhere, so it might as well be triggered directly on that server without cirrus?
Finally, it might be good to have another report that only highlights the coverage in the diff. I think vasild implemented this already.

Only when I run it manually, see e.g. https://github.com/bitcoin/bitcoin/pull/26631#issuecomment-1336306841

I managed to make vasild's code work (slightly modified). I run the coverage job on cirrus and upload the results on an S3 bucket.
build: https://cirrus-ci.com/build/4855920894148608
results: https://btc-coverage.s3.eu-west-1.amazonaws.com/PR-26728/modified_and_not_covered.html
We could either add a new job to the bitcoin/bitcoin's .cirrus.yml (simplest probably) that generates the report and uploads it to an S3 bucket. Then add a line to the DrahtBot summary comment such as:

The test coverage for this pull request can be found here.

Or make DrahtBot trigger a job on Cirrus with the API after every push / open PR event.
Note that S3 is very cheap.

Concept ACK
Imo having comments like https://github.com/bitcoin/bitcoin/pull/26631#issuecomment-1336306841 on every PR would be very helpful.
For fuzz coverage we could bite the bullet and integrate ClusterFuzzLite. That should provide coverage for new targets that we don't have a corpus for yet. (Not sure how much work that would be, because it doesn't look like that supports cirrus out of the box)

Any new target should be run by the dev writing it, and at least some of the reviewers. So not sure what the use case would be.

Sure but I think in practice it would still make sense to do this as a type of sanity check. e.g. Maybe some people don't run with all the sanitizers (e.g. MSan is harder to setup). Also, the same logic could be used to argue that we shouldn't run any tests in the CI, devs should run them anyway right?
I mostly suggested it because it automatically gives us coverage reports, even for new targets. I haven't seen coverage reports being generated/posted by anyone besides you on PRs. It is quite painful to setup locally and takes a while to run (for all targets at least), which is probably why almost no one does it.

Ideally someone could point to at least one real world example where it would have helped, before adding the feature.

https://github.com/bitcoin/bitcoin/pull/27877#issuecomment-1598451117
https://github.com/bitcoin/bitcoin/pull/27647#issuecomment-1597142820
https://github.com/bitcoin/bitcoin/pull/27902#issuecomment-1597205344
https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1416044406

These are all instances where it seems like the authors didn't run their own fuzz tests (or maybe just not with sanitizers).

Yeah, I was thinking to just set in CI the libfuzzer max time to 10 seconds, which will, in combination with runs=1 run for 10 seconds or over the full fuzz input folder, whichever is higher, IIRC?

Just tested -runs=1 -max_total_time=10 which for an empty corpus will only generate 1 input and not run for 10 seconds.
Maybe we add an option to the fuzz test runner that tells it to generate for 10 seconds if the corpus is empty (which would indicate a new target)?

This would have caught the 27647 issue, but not sure about the others. How long did you run 27877 and 27021 before finding the issue?

Iirc it would have caught the miniminer one (that only took a couple seconds), the coin grinder one took longer.


[Bug]: Crash in some tasks.

Apache Hop version?
2.9.0 and 2.10.0
Java version?
openjdk 21.0.5 2024-10-15 LTS
Operating system
Linux
What happened?
When I try to open the Apache Hop actions window, the message in the attached image appears, and my Apache Hop does not open the window to "view output." Could you help me solve this issue? Thank you for your attention.
I use SO Debian Bookworm with KDE Plasm and Wayland.

Issue Priority
Priority: 3
Issue Component
Component: Hop Gui

Try using java 11 for hop 2.9 or java 17 for hop 2.10

I do this...

can you try on X.org instead of Wayland and see if you still have the same issue?

can you try on X.org instead of Wayland and see if you still have the same issue?

Solved, the problem is in incompatibility with Wayland. thank you my friends!!

can you try on X.org instead of Wayland and see if you still have the same issue?

Solved, the problem is in incompatibility with Wayland. thank you my friends!!


Scripted interface : problems with boolean in fields

When implementing a Java interface with a bsh script, boolean primitive fields values are not retained for several invocations of the scripted interface methods (although they are retained for int primitive fields, or even Boolean fields).
For example, if we have a Java interface called IFoo :
package foo;
public interface IFoo {
    public void run();
}

We can define a script which implement this interface:
import foo;
boolean fieldBool = false;
int fieldInt = 0;
Boolean fieldBool2 = false;
void run() {
    fieldBool = ! fieldBool;
    fieldBool2 = ! fieldBool2;
    fieldInt++;
    print("fieldBool: "+fieldBool);
    print("fieldBool2: "+fieldBool2);
    print("fieldInt: "+fieldInt);
}

An then evaluate the bsh script to get the Java interface implementation:
Interpreter bsh = new Interpreter();
bsh.eval(script);
IFoo script = bsh.getInterface(IFoo.class);

When calling script.run(), the value of fieldBool is always false, although the valule of fieldBool2 swtich from false to true as expected.
Reported by: *anonymous
Original Ticket: "beanshell/bugs/318":https://sourceforge.net/p/beanshell/bugs/318

Closed by commit


Add Kojib custom domain

Added KOJIB
Hi! What is your PR about?

[x] Add or edit a skin
[x] Add a custom domain for your space
[ ] Add an alias to migrate your space

there is an issue with this it worked and hosted for about 30 minutes but now it says too many redirects dont know what the issue is tried fixing with dns but theres nothing I can do it should work .


peer dependency postgres and drizzle

#155  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


fix: rename semgrep action

This commit renames semgrep action used due to a change upstream.
Testing here: https://github.com/splunk/splunk-add-on-for-amazon-web-services/pull/1098

:tada: This PR is included in version 4.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Flashes are not persisting across redirects

When calling the following the code, it does not show the LaraFlash data:
LaraFlash::success('Success message...');
return redirect(route('index'));

Hence, the redirect is clearing the flash.

Fix:
LaraFlash::keep();

Yep. I need to document this feature. But this package uses the same core flash session underneath it as the basic laravel session management. So just like the normal flash sessions in Laravel, flashed data only lasts for 1 request. When you do a redirect within a controller you are actually creating another request which is why you have to use LaraFlash::keep() in order to persist it for another request.

Sorry again, I only closed this issue because I saw your tweet resolving someone else's case.
I am trying to get this working with my implementation, but just can't!
LaraFlash::success('Successfully created a new profile! (' . $profile->name . ')')->keep();
return redirect(route('profile.show', $profile->link));

LaraFlash::success('Successfully created a new profile! (' . $profile->name . ')');
LaraFlash::keep();
return redirect(route('profile.show', $profile->link));

Both code samples above fail to persist the flash through two requests.

any solution for this issues ?

Same problem here. LaraFlash::keep (); does not seem to do anything when dealing with redirections (unless I'm using it wrong). Has anyone managed to successfully use keep () with redieections? Please share how this can be implemented?

is there any solution ::keep() didn't work for me.

it only works if i did return view('') when i redirect nothing happens.

Until @jacurtis or anybody address this issue, I propose the following - Using default Laravel flash message. In your method do it as usual with slightly different approach within the message itself:
return redirect()->back()->with('status', 'success|Your message');

Notice that the flash message contains the pipe "|" which basically "divides" the type of the notification and text.
To use this feature then you can create a VueJS component alternating the code @jacurtis provided for the frontend side. I registered the component as toasty-notification. Alternated part looks like this:
props: {
            text: {
                type: String,
                default: null
            }
        },
        data: function() {
            return {
                session: this.text,
                validMethods: ['general', 'primary', 'success', 'info', 'warning', 'danger', 'snackbar']
            }
        },
        mounted: function() {

            let vm = this;

            this.$nextTick(function() {
                if ( vm.session !== '' )
                {
                    let res = vm.session.split('|');

                    if (_.includes(vm.validMethods, res[0].toLowerCase())) {
                        vm[res[0].toLowerCase()](res[1]);
                    } else {
                        vm.general(res[1]);
                    }
                }
            })
        },
// the rest of the methods.

And finally place this component in your blade view like this:
<toasty-notification text="{{ session('status') }}"></toasty-notification>

So this is the quick hack :)

Common @jacurtis , please man!
Work on a fix for its issue! The @gorankrgovic hack is good, but need to be on every single blade view!

+1

I've found a pretty easy workaround. If you redirect to an action instead of a route you can place your LaraFlash object it the action code. Create a 'redirected' variable and include it in the request.
Code example for UserController
public function update(Request $request, $id)
{
    return redirect()->action(
      'UserController@show', ['id' => $id, 'redirected' => 'true']
    );
}

public function show(Request $request, $id)
{
  $user = User::findOrFail($id);
  if($request->redirected) LaraFlash::new()->content('User Updated')->title('Success')->type('success');
  return view('manage.users.show')->withUser($user);
}

I've found easiest solution for this LaraFlash on redirected route issue. No need to check the redirected request or action route or add keep() method or no need to make new Vue component.
Make changes in your code with below code. Hope it will solve the issue. But priority or any ordering things won't work. Thanks.
Add this below piece of code above the notification Vue object code written. And then pass this $session variable to notification Vue object data.
@php
  $sessions = array();
  $laraflashes = session()->get('laraflash');
  if (!is_null($laraflashes)) {
    $sessions = $laraflashes->toArray();
  }
  session()->forget('laraflash');
@endphp

data: {
      session: {!!json_encode($sessions)!!},
      validMethods: ['general', 'primary', 'success', 'info', 'warning', 'danger', 'snackbar']
},

@shahnotes I didn't go deep into your solution, but it works! Thx!
Any ideas how to get it working with original functionality?


Make Proxy support optional

Instead of making Proxy support a requirement, it could check if Proxy is available, and if not, fall back to a get() method. For example, properties could be accessed like r.get(2) instead of r[2] (where r is a PythonRange object).

Implemented in 3800e631787ae6aebf913fecb335c2a9af492b0e and b5f9087bab7bf19cb0cd3ea6133c590e7ae259fc.


connection just hangs

Hi I am trying to follow this approach but the connection just hangs.
I started investigating, and I am not able to query the metrics from inside the any container. Outside the container it works fine. I have tried with  docker0  and docker_gwbridge.
Here is one example with docker0
daemon.json
{
  "experimental" : true,
  "bip": "<IP_ADDRESS>/16",
  "metrics-addr" : "<IP_ADDRESS>:4999"
}

run test container in shared network
docker network create curlme
docker run --name socat --rm --network curlme alpine/socat -d -d TCP-L:4998,fork TCP:<IP_ADDRESS>:4999
docker run --rm --network curlme curlimages/curl -I socat:4998/metrics

2021/04/02 22:25:39 socat[1] W ioctl(5, IOCTL_VM_SOCKETS_GET_LOCAL_CID, ...):  In that case I am using the address of the docker_gwbrige. I create the bridge myself with fixed CIDR before joining the swarm.
docker network create \
--subnet <IP_ADDRESS>/16 \
--opt com.docker.network.bridge.name=docker_gwbridge \
--opt com.docker.network.bridge.enable_icc=false \
--opt com.docker.network.bridge.enable_ip_masquerade=true \
docker_gwbridge

Then In the compose file for the stack deployment I run the image like so
  dockerd-exporter:
    image: alpine/socat
    networks:
      - monitoring
    command: -d -d TCP-L:4999,fork TCP:<IP_ADDRESS>:4999
    deploy:
      mode: global

And in Prometheus config
  - job_name: 'dockerd-exporter'
    dns_sd_configs:
    - names: [ tasks.dockerd-exporter ]
      port: 4999
      type: A

But Prometheus also gets timeout error for these targets. They are discovered, but metrics request times out.
Can you please give me a hint why this isn't working?
This is the full project I am working on  https://github.com/bluebrown/linode-swarm

Issue was docker0 and docker_bwbridge were blocked in the input chain of iptables.


Support for multiple inverter and JBD bms

Hi!
Will there be any option for paralell inverter monitoring and support for JBD bms?
Reagrds Žiga

most likely not by me as i don't have the hardware to test with.
if someone from the community wants to have a crack at it, i will gladly accept a PR.


[NG] Fix toggleAll selection tracking

Moved select and deselect into private methods to keep current and
selection in sync.
toggleAll calls select and deselect when adding or removing items.
closes #2083
Signed-off-by: Marc Viger<EMAIL_ADDRESS>

This is my first attempt at a PR in GitHub.  I apologize profusely if I've screwed something up, or messed up some etiquette.  I've tried to follow as closely as possible all the contribution guidelines.

Thanks for the contribution @mviger! We will take a look and get back to you soon.

I initially ran clang:check in my environment, saw there were errors, ran clang:format to fix everything and then re-ran clang:check.  Everything passed and I updated the PR.  I see the build CI has failed again on clang:check, but in my environment it is passing.  I'm not sure how to resolve the remaining issues currently.
Sorry for the trouble.

It might be a Travis CI clutch issue. I have restarted the failed job. Let's see if it passes or not.

@mviger: Could you also try running npm run tslint:fix?

@adityarb88 tslint:fix resulted in no changes on my machine.  I've also tried to run clang:format again, but no changes with that either.  I'm running on a Windows box currently, don't think that should matter though.   Potentially line break issue?


SubViewports do not take inputs

Operating system or device - Godot version:
Windows 10, Godot 3.0.alpha1
Issue description:
A subviewport that i made, as a child of a viewport container wont take any inputs at all.
Steps to reproduce:
Make a viewportcontainer, make a viewport as a child of it. try to make inputs happen on any node in the viewport or the viewport itself. _input(event) is not ran. not even set_process_input(true) fixes it.

Is it happening in 2.1.3 too?

You have to enable input manually
On Jul 28, 2017 11:52 PM, "Marc"<EMAIL_ADDRESS>wrote:

Is it happening in 2.1.3 too?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9950#issuecomment-318798844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z218KF0omWWYkNIjTB_R6kjSPbnDLks5sSp5wgaJpZM4OmvdS
.

I read elsewhere it was automatic but this is fine too, not a big deal.

The rationale is that it's better that viewports don't process input by
default, as a lot of use cases don't need it. It's better that you manually
have to enable it, that (due to ignorance) a lot of viewports are left to
process input uneccesarily
On Sat, Jul 29, 2017 at 8:05 AM, Flavo<EMAIL_ADDRESS>wrote:

I read elsewhere it was automatic but this is fine too, not a big deal.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9950#issuecomment-318821689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z288dA7mwdUxKDxPdsUj7ts3Np5Tfks5sSxICgaJpZM4OmvdS
.

Documentation says that "subviewports" (i.e. viewports that are child of a control) receive automatic input, while "render targets" does not.

I think this problem persists in a way please see my post here: https://www.reddit.com/r/godot/comments/bewxc7/viewports_with_input_events/

I'm experiencing this in 3.2.beta4.
Sample project:
ViewportCamera.zip
A workaround is to use signals from outside the viewport, to trigger actions inside the viewport.

Seems fixed in 3.5.
The above project is unrelated, the viewport isn't rendered anywhere, so it won't receive input. The issue is about ViewportContainer.


Updated Twitter logo to X

Description

Updated the Twitter logo on the GetNighthawk.dev website from the old logo to the new X logo.
This change aligns with the desired state of the website and ensures consistency with branding.

This PR fixes #325
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Hey @abhijeetgauravm , actually I have created separate branches as you can see

this issue is from icon branch
custom scrollbar issue from customscrollbar branch
margin issue from addspacing branch.

hey @akhilender-bongirwar
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

Hey @abhijeetgauravm , could you please review this PR : )

@akhilender-bongirwar Can you revert the index.scss changes ? Everything else looks fine.

@akhilender-bongirwar
the current on-hover effect (color) on  X logo isn't ideal.
Refer to the meshery.io socials in footer and implement the same for X logo here.

@vishalvivekm , could you please review this ?

@akhilender-bongirwar
The hover effect isn't working for X, Calendar and youtube icons

@akhilender-bongirwar hover effect doesn't work and and no twitter handle is linked


[EM] Multi-level quantile sketching for GPU.

This helps reduce memory usage when handling multiple batches. This is a variant of the CPU implementation. The basic idea is that when the stream size cannot be known in advance, we store the sketches in multiple levels, with each level growing in exponential size.
No new test since there are already multiple existing tests.

Fix and old error in the quantile data iterator demo.

cc @rongou .


Create a Hindi translation of the 404 error page

Based on the English version of the 404 error page (https://github.com/devadvance/terminalcheatsheet/blob/staging/404.html), create a Hindi translation in https://github.com/devadvance/terminalcheatsheet/blob/staging/i18n/fr/404.html.
Look for TODO in the file for suggested places for translations.

Hi, could you please assign me to this issue?

Assigned and will review the PR shortly.

Translations are in, thanks!


zig_0_9: refactor

set env.ZIG_GLOBAL_CACHE_DIR instead of preBuild
use installCheckPhase instead of checkPhase

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build colorstorm

just a quick note that this is already included in #247259, in case you didn't see https://github.com/NixOS/nixpkgs/pull/247259#issuecomment-1666520904

TRASH!

just a quick note that this is already included in #247259, in case you didn't see #247259 (comment)

I would prefer it in a dedicated commit. Sometimes people complain about huge, hidden refactors.


tests_l2: Update gpu readme for hwinfo

Added hwinfo readme details
based on https://github.com/intel/intel-technology-enabling-for-openshift/pull/155
Signed-off-by: vbedida79<EMAIL_ADDRESS>

It looks good to me. Thanks!


Possible memory leak/hang on the electron side

The line let img = document.createElement("img"); creates a new img every time an image is loaded. As far as I can tell, in the current version of MM, the page is never fully reloaded, so those elements just grow and grow. In my experience, WallberryTheme on an rpi3 (I'm using magicmirroros) will stop updating images after several hours at the fastest image update rate (50/hr limited by Unsplash API). I've verified that it's not API limits, and restarting the container (which restarts electron) always fixes it.
(I was using WallberryTheme/Unsplash as a placeholder while working on my own background plugin and I can hang the browser much faster doing the same thing because I have no rate limit. I fixed it by creating one img as this.img and re-using it.)

Awesome, thanks for the report

I had so many problems because of this. If I get some free time, I might try to address this issue.
Thanks for the specific report.

Fixed by @samusaran in PR #28 (4e1324b3b152536dbc58a050b287670a0c87d967).


ValidationException: Malformed input request when using Cohere embedding with Bedrock provider

I have the following configuration:
defaultTest:
  options:
    provider:
      text:
        id: bedrock:anthropic.claude-3-haiku-20240307-v1:0
        config:
          region: eu-central-1
      embedding:
        id: bedrock:embeddings:cohere.embed-english-v3
        config:
          region: eu-central-1

...
tests:
    - type: answer-relevance
      threshold: 0.9

I get the following error when running promptfoo eval:
API call error: ValidationException: Malformed input request: #: required key [texts] not found#: required key [input_type] not found#: extraneous key [inputText] is not permitted, please reformat your input and try again.

This error disappears when I'm using another Bedrock vector model such as amazon.titan-embed-text-v1 so I assume the error doesn't come from my configuration

Thanks for flagging.  The cohere embeddings request and response are different from Titan, unfortunately.  #924 should address this case based on the AWS docs.

This should be solved as of 0.64.0.  Please let me know if you run into any issues!

Hey @typpo, I'm still getting this error using 0.65.2 😔

I'm on 0.75.2 and I'm getting
API call error: ValidationException: Malformed input request: #: required key [input_type] not found, please reformat your input and try again.

As per the docs the field is mandatory.