Milk Sugar should be treated like unfermentable

I was playing with the app and like most of the apps, Biermacht treats lactose like a fermentable while calculating FG. This will mess with ABV estimation while designing a Milk Stout. I looked in to the code and it appears like only Malto Dextrine malts are treated as a special case.
Can you consider adding Lactose too? Here is the diff.
diff --git a/src/com/biermacht/brews/utils/BrewCalculator.java b/src/com/biermacht/brews/utils/BrewCalculator.java
index bb52011..c76c7c3 100644
--- a/src/com/biermacht/brews/utils/BrewCalculator.java
+++ b/src/com/biermacht/brews/utils/BrewCalculator.java
@@ -176,7 +176,8 @@ public class BrewCalculator {
// Returns the number of non fermentable gravity points for the given ingredient
public static double NonFermentableGravityPoints(Recipe r, Ingredient i) {

if (i.getName().equalsIgnoreCase("Malto-Dextrine") || i.getName().equalsIgnoreCase("Dextrine Malt")) {

if (i.getName().equalsIgnoreCase("Malto-Dextrine") || i.getName().equalsIgnoreCase("Dextrine Malt")

       || i.getName().equalsIgnoreCase("Milk Sugar (Lactose)")) {
 return Units.kilosToPounds(i.getBeerXmlStandardAmount()) * 40 / Units.litersToGallons(r.getBeerXmlStandardBatchSize());

}

When I testing this, I found another bug. Dextrin malts which are calculated as non-fermentables are also calculated in fermentables. As a result if I use Dextrin malt in a all-grain recipe, its gravity points are added twice in OG. The same was observed for lactose. So we would need another fix. Something like this:
else if (f.getFermentableType().equals(Fermentable.TYPE_SUGAR)) {
        if (i.getName().equalsIgnoreCase("Milk Sugar (Lactose)")) {
          pts = 5 * Units.kilosToPounds(f.getBeerXmlStandardAmount())
/Units.litersToGallons(r.getBeerXmlStandardBatchSize());
        } else {
          pts = Units.kilosToPounds(f.getBeerXmlStandardAmount()) * f.getPpg() /
Units.litersToGallons(r.getBeerXmlStandardBatchSize());
        }
      }

And
else {

          if (i.getName().equalsIgnoreCase("Malto-Dextrine") ||
                  i.getName().equalsIgnoreCase("Dextrine Malt")) {
            pts = 5 * Units.kilosToPounds(f.getBeerXmlStandardAmount())
                    / Units.litersToGallons(r.getBeerXmlStandardBatchSize());
          } else {
            // Either a partial mash or all grain recipe
            pts = r.getEfficiency() * Units.kilosToPounds(f.getBeerXmlStandardAmount()) * f.getPpg() / Units.litersToGallons(r.getBeerXmlStandardBatchSize()) / 100;
          }

Lastly, we would need to handle Carapils malt as well.

I have created a pull request for this. It is not a perfect fix, but an estimate which works for me. Pull it if you like or feel free to modify.

@sharathcshekhar thanks! I've merged the PR as is.  I'll take a look at the values it gives and get it out in a release this week.

Cool. Will wait for the official update! Thanks again for the wonderful app!


Upgrade ember

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[ ] #patch# - backwards-compatible bug fix
[x] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG
Upgrade Ember-cli to 2.12.3

These modifications need to be made to the package.json file:
change these packages to these values
"ember-cli-htmlbars-inline-precompile": "^0.3.6"
"ember-cli-inject-live-reload": "^1.4.1"
"ember-export-application-global": "^1.0.5"
"ember-load-initializers": "^0.6.0"
add these packages
"ember-cli-shims": "^1.0.2"
"ember-source": "~2.12.0"
remove these packages
"ember-disable-proxy-controllers": "^1.0.1"

Url in .gitignore should be
-# See http://help.github.com/ignore-files/ for more about ignoring files.
+# See https://help.github.com/ignore-files/ for more about ignoring files.

Changes Unknown when pulling d9acc3e279b43999fe0f95b499020f13bace1dac on helloWorldCindy:upgradeEmber into ** on ciena-blueplanet:master**.

👍

Approved.


Modified project to add .NET Core 3.0 support

Modified project to build .NET Core 3.0 and .NET Framework 4.5 compatible DLL.

Commit message should read v141, my apologies. Still appears to support .NET Core 3.0 without issues.

Hey Kevin, I've looked at your PR great work figuring out the .net core 3.0. I'm still thinking how the best way to accomplish the integration of this PR
Here are couple things that we need to take care of:

I'm ok on the change but until we can get CI/CD working it's going to be tough to build release version. Our CI/CD is using AppVeyor, I haven't checked if they have a build agent that support .Net core 3.0 just yet. Also we may have to tweak the nuget package .nupkg itself. If your work require it right now, just go ahead make a private version and incorporate them in your project, and as soon as we get the pipeline running and publish to nuget.org correctly, you can refactor to use the official one.

I saw your PR has a lot of intermediate commit. Part of my goal, master branch should be as clean as possible as far as git history is concerned, we want to always be vigilant about this from early on. So please squash things that is irrelevant for the PR. What I find helpful before working making code change on any OSS, I started with syncing my repo using rebase command. Don't just do merges, this will yield to non linear history. I think I may have a rule in the master to only allow fast forward, so unless it's linear github will reject PR during the merge process. During the commit if someone else push something in the upstream, I will rebase mine again with that and update my PR.
Great work man. Thank you for your contribution.
Regards,Surya
On Saturday, November 30, 2019, 11:28:01 PM EST, Kevin M. Kelly<EMAIL_ADDRESS>wrote:

Commit message should read v141, my apologies. Still appears to support .NET Core 3.0 without issues.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Okay, I will refork and recommit my changes to the fork then submit a new
pull request! My work doesn't require the .NET Core version yet, but I
tested it with a basic console application and it seems to work. Thanks
again for the opportunity to contribute.
--Kevin
On Sun, Dec 1, 2019, 7:50 PM Surya Suluh<EMAIL_ADDRESS>wrote:

Hey Kevin, I've looked at your PR great work figuring out the .net core
3.0. I'm still thinking how the best way to accomplish the integration of
this PR
Here are couple things that we need to take care of:

I'm ok on the change but until we can get CI/CD working it's going to
be tough to build release version. Our CI/CD is using AppVeyor, I haven't
checked if they have a build agent that support .Net core 3.0 just yet.
Also we may have to tweak the nuget package .nupkg itself. If your work
require it right now, just go ahead make a private version and incorporate
them in your project, and as soon as we get the pipeline running and
publish to nuget.org correctly, you can refactor to use the official one.

I saw your PR has a lot of intermediate commit. Part of my goal, master
branch should be as clean as possible as far as git history is concerned,
we want to always be vigilant about this from early on. So please squash
things that is irrelevant for the PR. What I find helpful before working
making code change on any OSS, I started with syncing my repo using rebase
command. Don't just do merges, this will yield to non linear history. I
think I may have a rule in the master to only allow fast forward, so unless
it's linear github will reject PR during the merge process. During the
commit if someone else push something in the upstream, I will rebase mine
again with that and update my PR.
Great work man. Thank you for your contribution.
Regards,Surya
On Saturday, November 30, 2019, 11:28:01 PM EST, Kevin M. Kelly <
<EMAIL_ADDRESS>wrote:

Commit message should read v141, my apologies. Still appears to support
.NET Core 3.0 without issues.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ssuluh/osrmnet/pull/67?email_source=notifications&email_token=AAW5BLL5WQNREZTC4EKEFZDQWSAZBA5CNFSM4JTJWHJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSDZMA#issuecomment-560217264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW5BLMF2BKVQWJ7PPMTPYTQWSAZBANCNFSM4JTJWHJA
.

Look at git rebase interactive etc. If u use git kraken or sourcetree u can tidy up your commit in the UI very easy.On Dec 2, 2019 12:12 AM, "Kevin M. Kelly"<EMAIL_ADDRESS>wrote:Okay, I will refork and recommit my changes to the fork then submit a new
pull request! My work doesn't require the .NET Core version yet, but I
tested it with a basic console application and it seems to work. Thanks
again for the opportunity to contribute.
--Kevin
On Sun, Dec 1, 2019, 7:50 PM Surya Suluh<EMAIL_ADDRESS>wrote:

Hey Kevin, I've looked at your PR great work figuring out the .net core

3.0. I'm still thinking how the best way to accomplish the integration of

this PR

Here are couple things that we need to take care of:

I'm ok on the change but until we can get CI/CD working it's going to

be tough to build release version. Our CI/CD is using AppVeyor, I haven't

checked if they have a build agent that support .Net core 3.0 just yet.

Also we may have to tweak the nuget package .nupkg itself. If your work

require it right now, just go ahead make a private version and incorporate

them in your project, and as soon as we get the pipeline running and

publish to nuget.org correctly, you can refactor to use the official one.

I saw your PR has a lot of intermediate commit. Part of my goal, master

branch should be as clean as possible as far as git history is concerned,

we want to always be vigilant about this from early on. So please squash

things that is irrelevant for the PR. What I find helpful before working

making code change on any OSS, I started with syncing my repo using rebase

command. Don't just do merges, this will yield to non linear history. I

think I may have a rule in the master to only allow fast forward, so unless

it's linear github will reject PR during the merge process. During the

commit if someone else push something in the upstream, I will rebase mine

again with that and update my PR.

Great work man. Thank you for your contribution.

Regards,Surya

On Saturday, November 30, 2019, 11:28:01 PM EST, Kevin M. Kelly <

<EMAIL_ADDRESS>wrote:

Commit message should read v141, my apologies. Still appears to support

.NET Core 3.0 without issues.

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or unsubscribe.

—

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

https://github.com/ssuluh/osrmnet/pull/67?email_source=notifications&email_token=AAW5BLL5WQNREZTC4EKEFZDQWSAZBA5CNFSM4JTJWHJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSDZMA#issuecomment-560217264,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AAW5BLMF2BKVQWJ7PPMTPYTQWSAZBANCNFSM4JTJWHJA

.

—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.


Create a standard GitHub action for Lean projects

We should create a GitHub action that users can add to their .github/workflows/ci.yml file (and indeed, lake init can create such).
It should automatically:

setup elan
if downstream of Mathlib, run lake exe cache get
lake build
lake test
if downstream of Std, run Std's linter framework

Probably also, but certainly with an easy mechanism to opt-out (that is explained on failure)

check if the project is eligible for inclusion in Reservoir
run lean4checker on the project (make it easy to run in a cron job, as this can slow down CI)

It could also:

provide a cron job that tries lake update && lake build, and reports (either via emails, notifications, or opening PRs) the result.

Based on these requirements, GitHub recommends we put the custom action in it's own repository. This would allow lean projects to use the action by adding,
- uses: leanprovercommunity/lean-action@{version-number-tag}

to their continuous integration workflow config.
To give an idea, I created a draft action here with elan -> cache -> build -> test -> lint capabilities. Currently the action is configured by three inputs:

test : Bool (defaults to true)

when test = true, include step to run lake test (this only works on versions of lean after lake test was introduced)

mathlib-cache : Bool (defaults to false)

when mathlib-cache = true, run lake exe cache get before other build steps

lint-module: String (defaults to empty string)

if the lint-module input is a non empty string, include step to run lake exe runLinter {lint-module}

Here are two repos to demonstrate usage:

A package with a Mathlib dependency with mathlib-cache and lint-module inputs and test = false

link to ci.yml
link to ci run which uses the action

A package with no dependencies using nightly toolchain (required for lake test) which runs tests but doesn't use mathlib cache or linting. This is the default configuration if you don't provide any inputs to the action

link to ci.yml
link to ci run which uses the action

Does this seems like the right approach?
If so I can expand this to,

optionally include Reservoir and lean4checker
automatically choosing the right input parameters (currently you need to manually set the mathlib-cache and lint-module inputs)

Yes, this is the right approach, and I'm really happy to see this!
It would be fantastic if we could provide a good default for mathlib-cache, that just tries to check for Mathlib in the dependencies (a very simple test is "does .lake/packages/mathlib exist", although perhaps that doesn't exist in a fresh repository until some lake command has run).

I thought it would be nice to include caching the .lake directory in the CI. Would this not contribute to increased speeds?

I thought it would be nice to include caching the .lake directory in the CI. Would this not contribute to increased speeds?

@Seasawher We could potentially cache some of the build files using the cache action. It takes a list of paths to cache and a key to match caches on, usually a hash of a lock file. Potentially we could use .lake for the directories and hash lake-manifest.json for the key?

It would be fantastic if we could provide a good default for mathlib-cache, that just tries to check for Mathlib in the dependencies (a very simple test is "does .lake/packages/mathlib exist", although perhaps that doesn't exist in a fresh repository until some lake command has run).

@semorrison I think you are right that the existence of .lake would be an issue
I put together another potential solution. I updated the action with a grep "require mathlib" lakefile.lean step.
Updated usage examples:

Now we get the cache without setting the mathlib-cache input in the mathlib test repo (link to pipeline)
The other test package without a  Mathlib logs "Mathlib dependency not found. Skipping Mathlib cache." and proceeds (link to pipeline).

The grep solution is still somewhat brittle if the dependency is not declared in lakefile.lean. For instance, if a package uses a lakefile.toml or if Mathlib is a transitive dependency.
Does lake have something similar to cargo tree which would give a more reliable graph of the dependencies? If not, grep "require mathlib" could be good for now. We could always update how this is checked in future versions.

hash lake-manifest.json for the key?

That would mean new build results are not cached as long as that file is unchanged. You should instead make sure that each unique build generates a unique key but also can fall back to previous caches using restore-keys, see e.g. https://github.com/leanprover/lean4/blob/master/.github/workflows/ci.yml#L303-L310

Ah, okay. Thanks for the tip @Kha.
I have added the cache action before running any lake commands with the following configuration:
    - uses: actions/cache@v4
      with:
        path: .lake
        key: ${{ runner.os }}-lake-${{ github.sha }}
        # if no cache hit, fall back to the (latest) previous cache
        restore-keys: ${{ runner.os }}-lake-

One area for improvement is that the github cache will cache the Mathlib cache generated by lake exe cache get which seems redundant and takes up significant space in the github cache. I will look into improving this after implementing the rest of the requirements listed in the initial issue.

The action now includes an optional step to check reservoir eligibility using the inclusion criteria. It verifies the repository,

is not private
contains a lake-manifest.json file
contains a GitHub-recognized OSI-approved license
has two or more stars

Nice! Another possibility useful tweak is to save the cache even upon build or test failures:
https://stackoverflow.com/a/75961093/946226
This way when you fix a build failure, the build will continue from there. Very useful if otherwise you'd be watching it compile std over and over again :-)

Thanks for the suggestion, @nomeata. I've added a step to preserve the cache after lake build but before lake test. This ensures that even if any tests fail and halt the CI pipeline, the cache remains intact. Currently, I haven't found a way to save the cache using actions/cache if lake build fails. The save-always parameter seemed like a potential solution, but it's currently not functioning as expected. However, as long as lake build was successfully cached in a different commit, the restore-keys should restore that cache and you wouldn't have to wait for dependencies to compile.

Regarding lean4checker and lake update && lake build: Integrating tasks which should be scheduled with a cron job while maintaining user-friendly defaults presents a challenge. It appears that users would need to invoke the action twice: once for pushes/PRs and another with a cron job.
To support both use cases, we could modify the inputs to resemble action-python, where users specify the exact steps to run. However, this may complicate the user interface more than it adds value.
As an alternative, we could create a separate action in the same repo for these tasks, perhaps named lean-periodic or lean-cron, specifically designed to be scheduled with a cron job, rather than being triggered by pushes/PRs.

Maybe a cron-based job isn't great for the fits-80%-solution anyways? It is annoying with forks, and with low activity repositories GitHub after a while sends annoying mails about disabling the cron job. Maybe to keep it simple make running lean4checker optional and leave it at that?

Yes, thinking about it again let's keep lean4checker as a push-triggered event. For small repositories it runs fast enough it shouldn't be a problem.

I'm really excited to see this work: don't hesitate to ping me if I can help with next steps. I would suggest we create a repository under the leanprover organization to host this action, maybe even just leanprover/action. If that sounds good, I can create it.

@semorrison A repository under leanprover sounds great! For naming, what about leanprover/lean-action? Forks will be more clear: austinletson/lean-action instead of austinletson/action.
I an create a README.md and make an initial PR so development can continue in that repository.

@austinletson, I have created leanprover/lean-action, and added you as a maintainer.

Great to see this functionality being made more accessible as an action.
I worry that lean-action is very generic as a name, particularly when it is likely there will be other lean actions. How about a name that describes what it does? lean-check-action? lean-test-action? This leaves the possibility for lean-update-action and many other possibilities.

Why not include lean update actions in this as well?

I believe standard use would be that some workflow tasks need to run on commits and PRs whilst others need to be run periodically. Consequently they must be separate actions. Also separate actions allow more per repo customization and better feedback when something fails.

I was technically inaccurate writing "must be separate actions", the comment above explains a style of having one action with multiple functionality where different functionality is selected using input variables. I believe above it was decided to opt for the style of separate actions.
In this use case I believe separate actions will be more comfortable for the majority of people who use it. However my experience of lean is much less than my experience with github actions so it is for others with more lean experience to decide!

@austinletson, I have created leanprover/lean-action, and added you as a maintainer.

Thanks! I will move over the current version and update documentation to reflect the change.

I worry that lean-action is very generic as a name, particularly when it is likely there will be other lean actions. How about a name that describes what it does? lean-check-action? lean-test-action? This leaves the possibility for lean-update-action and many other things.

@oliver-butterley this is a good point. If the vision is to have multiple action repos for the periodic and push/PR actions, lean-action is probably not specific enough.

My understanding is that leanprover/action will just be the main repository for holding all leanprover github actions, and the actual different behaviors will either be exposed as subfolders or options in a single multi-personality action.

Alright, thanks for the context.
@semorrison I have moved the work which was done for this issue to leanprover/lean-action and created a few initial issues there from todos in this issue, including one to track an initial beta release.
Additionally, I did an initial test of  uses: leanprover/lean-action@main on my fork of lean4-cli (link to job) which worked as expected.

Given that lean-action has had a v1 release, I think we can close this! Thank you very much, @austinletson!


Coma in template.

Laravel Version: 6.8.0
PHP Version: 7.3.2
Laravel-admin: 1.7

Description:
After rendering view i see coma.
Screenshot #1
Screenshot #2 (View)
Steps To Reproduce:
Only this:
My Controller

Can't reproduce your problem

Can't reproduce your problem

Hmm. Code below for me. P.S. HomeController:
public function index(Content $content)     {         return $content             ->title(__('admin.index_page'))             ->view('admin.pages.index');     }

Update to the latest version, this issue has been fixed


Phase tracing rather than phase lists

Right now you have a hardcoded list of phases to declare what is planned to happen. But that isn't the only way to get the phase plan. You could have something like a tracer bullet that sends the events through the system in a dry run (no side effects), but only puts together the list of phases that will run.
It would make the runtime simpler because we could have the event handlers be specific about the context of the status event they expect without cringing that we are declaring the phase order in multiple places that have to be consistent (the list of phases would not be necessary). We currently get a lot of event handlers triggered because they are listening for very general subscriptions (like any successful status).
It gives us more capabilities than just a linear set of phases. They could be much more dynamic with looping, conditional, and parallel phases.
It gives us traceability through the system. It could be useful for more than just the dry run that records the plan. We could use it to test at the level of event handler orchestration. This is something we don't currently have a good answer for.
Thoughts?

Makes sense. Would be good to consider how the present PhraseCreator would differ in that case. Phases are presently computed dynamically on a push. There's no support yet for parallel phases, although I think we could defer that.

After thinking about it a bit more, we are basically building a crude workflow engine on top of the Atomist platform. I have some reservations about that.
Of course, what we are doing with phases can be improved (by using custom events rather than GitHub statuses, maybe making the planned execution dynamic rather than a list as mentioned above, among other things...). But the current use of phases seems a bit egregious in places. It makes sense to have an event round trip to kick off another event handler that is in a different automation. Maybe it is even reasonable in the same automation when you plan to break one event handler out on its own or want to ensure extreme decoupling like we do in parts of the sdm. But using so many phases, granular event handlers with general subscriptions and guard cases, and string manipulation doesn't seem like the ideal default way to structure an automation. It is difficult to reason about and modify.
I'm not suggesting all the usages of phases in the sdm are bad, but I think they should all serve a purpose. There are places where we intercept status events from other systems just to update a different internal phase status for use within the sdm. If we had a dedicated phase event and consistent usage when integrating with another system and decoupling internal components things start to make more sense. Even then, a lot of the local logic flow could be done with promises or a real workflow lib.

One blind spot we have is the orchestration of multiple event handlers. It would be nice to write a unit test with several event handlers that work together. You could initialize the event handlers, mock side effects, add them all to a registry, kick one off, and then make assertions about the event trace through them.
This would be pretty easy to do if we had a local in-memory version of the routing capabilities in the Atomist server API. I'd like to be able to start this up in my event handler unit tests, add data (instead of sending to a webhook) and run graphql queries on it. I looked around a bit to see if anything like this exists and came up with nothing. There are graphql mocking libraries and local caches for use with clients. But they stop short of actually running a query on the data. I looked more closely at how we do this in the client only to find out that all the important event routing is handled on the server.

@jessitron work on goals etc should have addressed this


Tinkerpop 968:Add first class support for an optional traversal

https://issues.apache.org/jira/browse/TINKERPOP-968
Added optional(Traversal) to GraphTraversal. Optional semantics is implemented via the choose step.
Added OptionalTest.java
Added Optional-step documentation.

@pietermartin -- From just a code review, everything looks really clean and consistent with the conventions thus far. You added to traversal.asciidoc, you created a GroovyOptionalTest and an OptionalTest. Your test cases good. Finally, you were smart about adding __.optional(). Did my GraphTraversalTest open your eyes :) ?.
Please make sure the docs build. Better yet, publish-docs.sh after your process-docs.sh and then we can all see the new section online. Finally, please do a full integration test. If you can paste your BUILD SUCCESSFUL console output of your integration test run, that would be great.  After that, I will vote.
Thank you Pieter.

I'm not so sure that he has rights to do a publish-doc.she. I'm still a bit confused as to who else has access and under what circumstances they get access.

@okram Yes your GraphTraversalTest showed me the way.
mvn clean install  SUCCESS
mvn clean install -DskipIntegrationTests=false
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [  4.726 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  1.531 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 26.490 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [  7.425 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 32.440 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [  3.856 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [02:08 min]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [03:46 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [04:28 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [  02:29 h]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [  1.696 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [  5.887 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [11:38 min]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [01:11 min]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [  0.061 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [  2.853 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [  8.433 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:54 h
[INFO] Finished at: 2016-03-29T19:42:09+02:00
[INFO] Final Memory: 83M/394M
[INFO] ------------------------------------------------------------------------
{code}
Note 2 assertions were commented out to make the integration test suite pass.
GremlinServerAuthIntegrateTest.shouldFailAuthenticateWithPlainTextNoCredentials
GremlinServerAuthOldIntegrateTest.shouldFailAuthenticateWithPlainTextNoCredentials
The correct exception is thrown but the assertion tests for the message which is different on my system for some as yet unknown reason.
bin/process-docs.sh
Checked the optional gremlin output, looks good.
vote +1

Can you also check Neo4j? This is the "full integration" test command.
mvn clean install -DskipIntegrationTests=false -DincludeNeo4j

Given that you already did the -DskipIntegrationTests, just do:
mvn clean install -DincludeNeo4j

Finally, please talk with @spmallette about the GremlinServerAuth issue.

We did discuss that. I have no idea why those won't work in his environment. I guess I will build this branch and see if there's any problems with Gremlin Server as a result of the change.

mvn clean install -DincludeNeo4j
{code}
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [  2.872 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  1.384 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 23.977 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [  6.627 s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [ 32.346 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [  3.490 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:09 min]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [  2.553 s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [02:36 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [03:24 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [  3.875 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [47:11 min]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [  6.096 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [ 32.213 s]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [  9.870 s]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [  0.055 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [  2.950 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [  8.241 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56:39 min
[INFO] Finished at: 2016-03-30T14:39:07+02:00
[INFO] Final Memory: 96M/441M
[INFO] ------------------------------------------------------------------------
{code}

VOTE +1.

Code looks and good and it worked as expected when I played with it in the shell.  Nice addition.
VOTE: +1

looks like enough votes to merge if @pietermartin votes himself. i'd still like to hear if anyone else can run gremlin server integration tests successfully against this before merge.

Just a mvn clean install -pl gremlin-server -DskipIntegrationTests=false will be good enough I'd say as its only there that the assertions were commented out.

Just finished running mvn verify -DskipIntegrationTests=false -pl gremlin-server without issue.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:17 min
[INFO] Finished at: 2016-03-30T14:33:01-05:00
[INFO] Final Memory: 33M/395M
[INFO] ------------------------------------------------------------------------

Great, tx
VOTE: +1

hmm - so it seems that the issue is with your environment @pietermartin   - weird. good to go for me.


Update lunie.md

Grant Application Checklist

[ ] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[ ] A BTC address for the payment of the milestones is provided inside the application.
[ ] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[ ] The total funding amount of the project is below CHF 30k at the time of submission.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @muli923 Not sure why this change is necessary, so I will close the PR for now.


DjangoChoices.labels does not do what it's documented for

Hello,
I'm on django-choices==1.6.0 and encounter an issue with DjangoChoices.label. The documentation says it should return a dictionary mapping labels to values. What I get is a dictionary mapping property to specified label.
With the following in my model:
class DevStatus(DjangoChoices):
    na = ChoiceItem('NA', 'NA')
    ready = ChoiceItem('RDY', 'Ready For Development')
    specs_to_discuss = ChoiceItem('TBD', 'Specs To Discuss')
    in_progress = ChoiceItem('INP', 'In Progress')
    partially_delivered = ChoiceItem('PAR', 'Partially Delivered')
    completed = ChoiceItem('COM', 'Completed')

I get this result:
>>> PER.DevStatus.labels
{'in_progress': 'In Progress', 'partially_delivered': 'Partially Delivered', 'specs_to_discuss': 'Specs To Discuss', 'completed': 'Completed', 'ready': 'Ready For Development', 'na': 'NA'}

Where what I'm expecting would be:
>>> PER.DevStatus.labels
{'In Progress': 'INP', 'Partially Delivered': 'PAR', 'Specs To Discuss': 'TBD', 'Completed': 'COM', 'Ready For Development': 'RDY', 'NA': 'NA'}

Thanks for reporting this, you're right, the documentation is wrong on this
and shall be updated :)
On Dec 19, 2017 04:48, "François Rejeté"<EMAIL_ADDRESS>wrote:

Hello,
I'm on django-choices==1.6.0 and encounter an issue with
DjangoChoices.label. The documentation says it should return a dictionary
mapping labels to values. What I get is a dictionary mapping property
to specified label.
With the following in my model:
class DevStatus(DjangoChoices):
na = ChoiceItem('NA', 'NA')
ready = ChoiceItem('RDY', 'Ready For Development')
specs_to_discuss = ChoiceItem('TBD', 'Specs To Discuss')
in_progress = ChoiceItem('INP', 'In Progress')
partially_delivered = ChoiceItem('PAR', 'Partially Delivered')
completed = ChoiceItem('COM', 'Completed')
I get this result:

PER.DevStatus.labels
{'in_progress': 'In Progress', 'partially_delivered': 'Partially Delivered', 'specs_to_discuss': 'Specs To Discuss', 'completed': 'Completed', 'ready': 'Ready For Development', 'na': 'NA'}

Where what I'm expecting would be:

PER.DevStatus.labels
{'In Progress': 'INP', 'Partially Delivered': 'PAR', 'Specs To Discuss': 'TBD', 'Completed': 'COM', 'Ready For Development': 'RDY', 'NA': 'NA'}

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bigjason/django-choices/issues/54, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFQ01ucDyhYcx4Lb3ctapMezB51C8tJmks5tBzHygaJpZM4RGZ6A
.

So there is no function or property that would give me the mapping I expect? I ended up taking the values property and reversing the keys/values to get things working but ideally I would expect to have something provided directly by the library.
What I have is a Django app that syncs some of its data from outside APIs through a custom manage.py command. The labels for the choices in the model declaration fit the ones returned by the API but I need to translate these labels into the proper values to create or update the model instances.

Actually, looking at the tests, it seems to be the intended behaviour is the one documented in the docs, so this would be a bug then. Only things is that I'm not sure what happens if you have the same label for different choice items - that would have a key collission, though I guess we can solve it like https://github.com/bigjason/django-choices/blob/master/djchoices/choices.py#L45
Having a mapping from attribute to value makes no sense in this context, since the DjangoChoices (sub)class already does that.

Using my example, I don't see how I could instantiate an object with a devstatus of In Progress. I don't see a way using just the things supplied by the library to translate In Progress into INP.
I end up inversing the mapping myself with this:
devstatus_choices = {v: k for k, v in PER.DevStatus.values.items()}
value = devstatus_choices['In Progress']

But I would hope this would be provided by the library itself.

Yes, as I said, it looks like a bug, so it will be fixed. I just have to
make sure there's no breakage of existing code.
On Dec 19, 2017 09:10, "François Rejeté"<EMAIL_ADDRESS>wrote:

Using my example, I don't see how I could instantiate an object with a
devstatus of In Progress. I don't see a way using just the things
supplied by the library to translate In Progress into INP.
I end up inversing the mapping myself with this:
devstatus_choices = {v: k for k, v in PER.DevStatus.values.items()}
value = devstatus_choices['In Progress']
But I would hope this would be provided by the library itself.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bigjason/django-choices/issues/54#issuecomment-352669638,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFQ01mcpqXfzgVwL0N6-8WX310t8TlR1ks5tB29ugaJpZM4RGZ6A
.

So, I've finally found some time and motivation to look into this. My conclusion - going of the tests - is that the documentation was wrong, so I've updated that. As for what you actually want, I'm a bit confused:

Why do you want to map labels to values? The intended usage is doing something like mymodel.choice = Choices.some_attribute, which assigns the correct value. Human-readable label is derived from the value.

There is actually a risk - if you're using (translatable) labels, you may end up having the same human readable label for different values. It's not possible to do the reverse mapping in that case. While having the same representation of different values is an odd thing in itself, it may be a valid use case in simplified UX-es.

So, I'm not yet building something into the library to get this reverse mapping, until it's clear what would be the actual use case for it. Could you provide some more context?

@sergei-maertens Is it possible to update the documentation on readthedocs? Thx.


Implement v1 in terms of v2

Remove all the core functionality of v1
and instead implement it in terms of v2
with the appropriate options specified.
Many v1 test cases currently failure because the v1 emulation in v2
is not a sufficient reproduction of historial v1 behavior.
The list of known failures are stored in v1/failing.txt,
which allows such failing tests to be skipped.
As the v1 emulation in v2 improves, the failing.txt list
should eventually become empty.

This builds on top of #72.


upgrade metallb to v0.13.10

Upgrade metallb manifests to v0.13.10
Metallb provides their yaml as one single file but I split it into the same parts to keep with the current method

Hey @jadams,
Thank you for opening this PR. Everything seems okay overall. There is a small linting issue and could you verify you've submitted the CLA form?
Many thanks!

I amended my commit to have the correct email address so the CLA check should pass now.

Thanks for the PR again, I'll go ahead and merge it.


Python 3 Compatibility - Rebased Fork

This PR is a rebase of @avendael's work on Python3 compatibility to the latest version of develop.
Thank you @geeknam, @avendael

Coverage decreased (-9.49%) to 81.92% when pulling 10e5163cb1d59aa131068150096826f035b2bb38 on rakanalh:master into 0af0b12c956ed662030c7aa90e5f5dc60884c301 on geeknam:master.

Coverage decreased (-9.49%) to 81.92% when pulling e731ecf9c6e2305761581eeed0efb3eea4bd370a on rakanalh:master into 0af0b12c956ed662030c7aa90e5f5dc60884c301 on geeknam:master.

@geeknam did you get the chance to review this?

:+1:

Thanks guys, can we get the coverage & health up? Who wants to volunteer to do this? :)

I believe the priority should be making a release rather than waiting for people to improve health indicator & tests. All current tests pass so the library should be good to go for a release with this branch.
This is my 0.02

Thanks for your input @rakanalh. Landscape caught an undefined variable urllib https://landscape.io/diff/148815

In my opinion, using requests and replacing urllib and urllib2 will definitely be a good move here.
Benefits:

requests is python 3 compatible
using requests would make the code cleaner
everyone is familiar with requests, requests is more human friendly

I agree... but many people along with myself need this to be Py3 compliant as soon as possible.
As for requests, i also agree. I prefer using requests over urllib. Could you leave this as an open issue for someone to pick up and create a PR for that?

Coverage decreased (-5.66%) to 85.76% when pulling d6d1e552f3ef8fd4e91009699c7caa32fca6c822 on rakanalh:master into 0af0b12c956ed662030c7aa90e5f5dc60884c301 on geeknam:master.

https://github.com/geeknam/python-gcm/pull/60 fixes this


When is it open source? please

也盼望着..............

A demo would be fine~

Finally its open source


Update signature of BaseSaver.save

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9ceef63) to head (b758c2e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           52        52
  Lines         1075      1075
  Branches        82        82
=========================================
  Hits          1075      1075

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


error post "https://localhost:7053/participation/v1/channels

When I follow fabric-samples to a run a test-network，I get this error.
error post "https://localhost:7053/participation/v1/channels
My comman is
./network.sh up createChannel -c ykchannel
my version : 2.3.3

Make sure your fabric images are at least v2.3 as well. The REST API was introduced in v2.3.
If you have additional issues running the fabric samples, please open issues in the fabric-samples repo at https://github.com/hyperledger/fabric-samples/issues.


there should be a separate downloads page on the website

some people don't like links to big files shared directly in eg Twitter due to security concerns - 'where am I being sent? what am I downloading here? (they also often don't work because the https://t.co/ address that twitter links have don't appear to resolve until the download is finished)

we now have at least 2 'editions' ( x64, x32) and it's likely to be more soon (ARM, 'stable/release-candidate/nightly etc for all of those editions), and maybe even different desktop environments...

So, having a downloads page would be nice as it give us a page link for use case 1. and a place to list and explain all the versions in 2. as well as MD5 hashes.
It would be good if we could make the links and MD5s automatically updated, so that there is no maintenance burden and it's always up to date. @robdyke you automated the linking to latest ISO, could you let me know how you did this. I'm happy to create the actual page

See this snippet
https://github.com/NHSbuntu/www.nhsbuntu.org/blob/master/_includes/downloadiso.html

Resolved in NHoS.


Problems with compilation from source "Cannot GET /"

@blacktemplar commented on Sun Oct 28 2018
Since multiple Augur versions my Arch Linux Package which packages Augur doesn't work anymore (https://aur.archlinux.org/packages/augur-git/). The Augur-App starts up and synchronizes normally but when one opens the UI the only html-response is an Error "Cannot GET /".
Steps to reproduce the problem:
git clone https://github.com/AugurProject/augur-app.git
cd augur-app
npm install
npm run make-linux dir --dir
cd dist/linux-unpacked/resources
electron app.asar
"Connect in Augur-App and then click Open in Browser (after syncing)"

The weird thing is that if we are calling the executable ../augur everything works fine. But I would prefer to don't use the executable in my package since I don't know all the dependencies of the executable. I followed the packaging of another well known electron app in arch linux for my build script, see https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=signal.

@petong commented on Thu Nov 08 2018
The problem seems to come from the command you are using to start the app, it does not start the UI server which is why the GET request isn't handled. You can also see this by running lsof -i :8080 after you start the app via your electron command vs running the binary. Is there a reason you prefer electron app.asar rather than the binary itself?

@petong commented on Thu Nov 08 2018
the app uses electron-is-dev to determine the env that is being run. If the app isn't started via the binary then the library assumes that the env is dev:
  if(isDevelopment) {
    return path.join(__dirname, '../../node_modules/augur-ui/build')
  } else {
    return path.join(process.resourcesPath, 'ui-client')
  }

}

since the ui-path has to be accessed by a browser it can't live within the asar packed app.
Currently looking to see if there is a way around this problem.

@blacktemplar Are you still interested in getting this working? You most likely will have to call the augur binary itself rather that electron.

Closing this for now.
@blacktemplar if you'd still like to get this working, feel free to reopen this ticket.


CA-340392 + minor script corrections

See commit messages for details. Commits best reviewed separately.

An example in order to understand what the OCaml change does:
Previously, calling the following cmdlet: Invoke-XenVM -Name MyVm -XenAction CleanShutdown -PassThru caused the following C# code to run:
XenAPI.VM.revert(session, contxt.Snapshot);

if (PassThru)
{
    var obj = XenAPI.VM.get_record(session, vm);
    if (obj != null)
        obj.opaque_ref = vm;
    WriteObject(obj, true);
}

i.e. the cmdldet returns the object on which the call was called. Which is not really necessary and it doesn't work for classes without records (e.g. Diagnostics).
Now the following code will be run:
XenAPI.VM.clean_shutdown(session, vm);

if (PassThru)
    WriteWarning("-PassThru can only be used with -Async for this cmdlet. Ignoring.");

The change affects a big number of API calls returning void (they can be found by diffing the autogenerated code), but breaking user implementation may not be very likely as most users wouldn't expect a cmdlet to return the object for a call returning void.


Split producer goroutines into sub-structs

When I wrote the producer, I kept each of the five pipeline goroutines as methods on the main Producer object for simplicity's sake, however several of them (in particular the flusher and leaderDispatcher) have now grown too large. The problem with this choice is that it makes it difficult to split logical chunks of that code out into helper functions, because the helpers cannot modify state in the parent function without some complicated parameter/return value passing.
My current thoughts around the fix for #294 are going to make this problem even worse, so before we tackle that we should do a small refactor (internal only, no API changes) of the producer to look more like the current consumer layout: small substructs which contain state variables, thus allowing the large goroutines to be broken up into helper functions and make the code flow much more obvious. Nobody likes reading 150-line functions.
Current thoughts include:

rename brokerWorker and use it to manage the messageAggregator and flusher goroutines
create a struct to manage the leaderDispatcher goroutines
split some helpers out of flusher and leaderDispatcher to make their main loops more understandable

@drdee @yagnik this is a good project for learning more go and getting your hands dirty with the producer design, with very low risk since there should be no functional changes, just code reorg.

At most recent count, this refactor would enable (or at least substantially simplify) #294 and #433.

Between #510 #511 and #512 I am considering this done.


Question about TCBlock

In my opinion, TCBlock just returns the clustered data info from the output of CTM. May I ask for any context/background on using this in your implementation?
https://github.com/PKU-YuanGroup/Chat-UniVi/blob/main/ChatUniVi/model/cluster.py#L259-L287

Also, in the recent commit, you have separately created the mm_projector builder. Is this indicating that you are conducting ablation experiments for its design (e.g., linear, MLP, residual..?)

In the original version, cross-attention was performed within the TCBlock. However, our experiments revealed that such operations significantly compromised the stability of model training. Consequently, we opted to remove the cross-attention operations.
We didn't do a full ablation of MLP, but LLaVA claimed that MLP would be better than Linear.

I see. Thank you for your reply!


[BACK-2540] Print reports

allow pdf reports to be created from backend
docs https://github.com/tidepool-org/TidepoolApi/pull/77

/deploy qa2


chore(package): update to ionic 3

It needs a change in the description of the repo:
"Ionic 2 Conference Application"
:P


Can I code ML code inside EOS ?

I have a text extraction ML app working in Python. I am thinking if I could replicate the same functionality to code a smart contract  in EOS such that other smart contracts could be able to talk to ML smart contract and get the data ?

Maybe you are looking for this:
https://github.com/learnforpractice/pyeos https://github.com/learnforpractice/pyeos
There is DL example in the following link:
https://github.com/learnforpractice/pyeos/tree/master/programs/pyeos/contracts/mnist https://github.com/learnforpractice/pyeos/tree/master/programs/pyeos/contracts/mnist
Also you should know all of this are at a very early stage.
Let me know if you need additional help.

On 26 Oct 2017, at 4:12 PM, Siva Chaitanya<EMAIL_ADDRESS>wrote:
I have a text extraction ML app working in Python. I am thinking if I could replicate the same functionality to code a smart contract in EOS ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/EOSIO/eos/issues/591, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad6ZPuzeQ7dPfOqd5rgLFtBQLzPmWkQkks5swD7rgaJpZM4QHKo0.

Thank you @learnforpractice  that is exactly what I'm looking for, Definitely will let you know if I encounter issue :)

This is a very exciting thread. Thank you, both.
Sent from my iPhone with Aloha.

On Oct 26, 2017, at 2:17 AM, Siva Chaitanya<EMAIL_ADDRESS>wrote:
Thank you @learnforpractice that is exactly what I'm looking for, Definitely will let you know if I encounter issue :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Incomplete authentication leaves the app locked

Sometimes an incomplete authentication flow leaves the app locked on iOS devices.
Attached is a screenshot of a case where the authentication failed but the atsign was added to the keychain.

After getting this error, when the app was restarted,

At this point, the atsign can neither be onboarded again nor will it allow to remove it and start afresh.

An added feature to clear such atsign would be helpful.

not able to replicate the issue.please provide the atkeys to reproduce the issue

The issue is not atkeys specific. It can happen with any atsign. There are no definite steps to reproduce this issue.

Related to #74 ?

@sarika01 can you please check this issue is related to #74 ? there is reset button to remove an atsign so i think there is no need to add another button.
If the isue is not with this can you please tell me which added feature you are expecting?

@DivyaYadavareddy I think the reset button shown above is in the wavi app and not on the at_onboarding_flutter widget. With the latest version 2.1.3 of the onboarding package on pub.dev, I am getting this screen with no reset button.


Option for output directory

As like in "video transcoding" has the option
-o, --output FILENAME|DIRECTORY
It seems to be missing for "Other Video Transcoding".
Would it be possible to add this feature / option?
Thank you in advance

@pat-e OK, much like Tom Bombadil, I will take the Ring or implement --output only if asked by all the Free People of the world. And clearly that has not happened. Yet. :)
So, I will close this issue for now. Thanks again for opening it.


env: node: no such file or directory

I'm working on a new BitBar plugin (bash script) that's also using CLIs through the node.js environment, installed with npm install -g into /usr/local/bin, symlinked to /usr/local/lib/node-modules/*/*.js, and now I'm having problems with a subroutine. The test script always worked fine in zsh and bash, and also the tweaked version for BitBar runs fine when running it directly in bash or zsh, but as soon as I load it in BitBar, nothing happens. The BitBar bash instance appears in Activity Monitor, and when I quit it from there, BitBar then echoes a long menu with an endless list of the error message env: node: no such file or directory.
I can't really say what the problem is… the node setup probably… but I have no idea how to solve it. Can it be done with a simple shebang? But then again, BitBar is utilizing my bash, and the script works fine when running it directly in bash, so #!/bin/bash should suffice, I assume. (?)
PS: using BitBar v2 beta 3.

It seems that simply adding
export PATH=$HOME/local/node/bin:/usr/local/bin:$PATH
to the script seems to work for basic node CLIs. There are still lots of errors about missing config files/directories, so I'll look into it further.

The actual problem seems to be that I'm accessing an API with the script, and I need to export the access ID somehow. In my normal shells it's part of .bashrc and .zprofile, but that won't work here.
For BitBar I tried adding
export NODE_CONFIG='{"key": "$API_ID"}'
but I'm still getting error message.
Any idea on how to export NODE_CONFIG in a BitBar shell script?


Add util function to drop unchanged beliefs from a BeliefsDataFrame

Add util function to drop beliefs from a BeliefsDataFrame that are changed with respect to beliefs already stored in the database.

Why is this tagged for 0.6.1?
This seems like new functionality, not a patch.

You're right. I corrected it to 0.7.0.

Perhaps we should also hook this function up to flexmeasures.api.common.utils.api_utils.save_to_db?

Certainly. Maybe depending on a boolean parameter, which defaults to True.
In this case, adding a test of course becomes even more crucial.

Hooking up this util function, with additional tests, is now a separate issue https://github.com/SeitaBV/flexmeasures/issues/186.


tput reset causes session to close

On build 14342, the commands tput reset or tput init cause a Bash console to immediately close.  Possibly related to #399.

This is definitely a dupe of #399, and goes all the way back to #100. Fix should be coming soon enough, thanks to @paulcam206!

For information: still crashing on build 14352.

Closing out as a duplicate of #399.


Monitoring sample references unknown value

https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/packages/monitoring/src/v3/metric_service_api.js#L603
What is var view = TimeSeriesView.FULL;?
TimeSeriesView is undefined.
In the proto TimeSeriesView is defined as an enum, but apparently the enum object was not emitted in metric_service_api.js

Accepted, this is a bug. For the reference, that can be accessed as monitoringV3.ListTimeSeriesRequest.TimeSeriesView.FULL.

@jmuk any updates on this?

not yet. I've been busy on other things.

Was this fixed in your recent PR?

Yes, that's fixed by https://github.com/googleapis/toolkit/commit/8488f7c3306f5c83ca5644f6042c366c5677d035 and regenerating monitoring fixed. Sorry I forgot mentions.

Cool, thanks!


Image Resizer: Disable does not work as expected

Steps to reproduce

Start PowerToys.exe. Disable Image Resizer from the settings and save (this will reflect in the settings.json file).
Now terminate PowerToys.exe and relaunch it.
Expected behavior

Image Resizer should be disabled.
Actual behavior

Image Resizer appears enabled, but it actually is not (does not appear in context menu).
Screenshots

The fix is now available in 0.16 https://github.com/microsoft/PowerToys/releases


UI problem with translation - fallbackLng not working

I encountered this problem during usage of Chrome browser, Firefox works fine (reason mentioned below).
Browser is sending following Accept-Language request header "sk-SK;sk" (for comparison Firefox is only sending "sk").
i18n tries to fetch "sk-SK" and fail with the following error (because node backend return some default html instead of json - the locales/sk-SK/translation.json path don't exists):

Next it tries to use "sk" language and succeed. However the language swapping select stay with "EN" option selected:

So in case you want to swap your language to English, you have to select Slovak/Swedish language (swapping select pretends to be checked on "EN" option) and then select "EN" option. This can confuse users to think that there isn't English localization available.

Fix should be fallbackLng  setting.
However:
        fallbackLng: {              'sk-SK': ['sk'],              'default': ['en']         },
does not seems to work.
I tried it to write it many different ways (based on documentation) even tried to hardcode "sk" as default fallback as in current case with "en" value, but it did not helped.

This would be problem for many different languages, when there are multiple different ways how to express them in browser headers. Chrome seems to provide always multiple variation of language tag in it's header.

Alternative solution (if we assume that the Chrome browser will always provide also shorter tag equivalent such as "sk") would be change the behaviour of language select menu to handle this case.

@nitram147 I documented a potential solution in https://github.com/anon-real/sigma-usd/pull/37.
It uses a util method on i18n to extract the code from the language (ie, sk-SK => sk) which seems to be used internally when determining what JSON file to load.  It feels a little questionable as it isn't documented anywhere but through digging into the code.
I wasn't sure how to really mimic setting the language to sk-SK, but after hardcoding i18n.changeLanguage('sk-SK'); into i18n.ts, it appeared to work as we would want.
I marked the PR as draft. Can you see if this solves the issue for you?


Compilation issue

https://github.com/mordentral/AdvancedSessionsPlugin/blob/fd33fc34a502e838f0d0a6e1e8631b21b8bf44e5/AdvancedSessions/Source/AdvancedSessions/Private/LoginUserCallbackProxy.cpp#L68
Fixed by changing FUniqueNetIdRepl by FUniqueNetIdPtr

What engine version are you on? Mismatching versions or compiling for UE5 Main will cause compilation issues.

I'm on 4.27.2

Where did you get your copy?
The 4.27 branch has had that corrected for 28 days. It only existed for a day or so before I noticed.

Oh I see ... I take the master branch instead of 4.27-Locked :(


[ISSUE #6213] fix: when subscriptionGroupConfig is null ,we do not register consumer

Make sure set the target branch to develop
What is the purpose of the change

fix #6213
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6214 (50df11e) into develop (88000da) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6214      +/-   ##
=============================================
+ Coverage      43.18%   43.22%   +0.03%
- Complexity      8848     8858      +10
=============================================
  Files           1094     1094
  Lines          77184    77185       +1
  Branches       10070    10071       +1
=============================================
+ Hits           33332    33362      +30
+ Misses         39682    39654      -28
+ Partials        4170     4169       -1

Impacted Files
Coverage Δ

...cketmq/broker/processor/ClientManageProcessor.java
26.47% <0.00%> (-0.27%)
:arrow_down:

...he/rocketmq/broker/controller/ReplicasManager.java
44.40% <0.00%> (-2.62%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
82.21% <0.00%> (-1.45%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
70.27% <0.00%> (-1.36%)
:arrow_down:

.../org/apache/rocketmq/store/ha/DefaultHAClient.java
60.82% <0.00%> (-0.52%)
:arrow_down:

...ketmq/store/ha/autoswitch/AutoSwitchHAService.java
54.95% <0.00%> (-0.46%)
:arrow_down:

...rocketmq/client/impl/factory/MQClientInstance.java
46.82% <0.00%> (-0.15%)
:arrow_down:

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (ø)

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
76.53% <0.00%> (+0.36%)
:arrow_up:

...a/org/apache/rocketmq/store/StoreStatsService.java
35.63% <0.00%> (+1.10%)
:arrow_up:

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Remove SCSI_DPT_I2O for kernel and kernel-azure

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

This change removes support for dpt_i2o as it still is exposing security vulnerabilities, is depricated upstream, and does not seem actively used.
This change originally addressed the CVE-2023-2007 vulnerability by turning off support for the SCSI_DPT_I2O module. The upstream fix is to remove support entirely. On the off chance someone was still using the driver in the stable release, the patch was not backported as discussed here. The stable fix resolved some issues including this CVE by removing somefunctionality. The Nopatch PR can be seen here: https://github.com/microsoft/CBL-Mariner/pull/6095
This PR is only against kernel and kernel-azure as other kernels are being evaluated by their maintainers.
Change Log

Disable SCSI_DPT_I2O for CVE-2023-2007

Does this affect the toolchain?

YES
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-2007

Test Methodology

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=412419&view=results

Closing in favor of https://github.com/microsoft/CBL-Mariner/pull/5911


Move some of the types from TypedDict to Dataclass

I initially just converted most dictionaries to TypedDicts for proper type checking.
However some structures would probably be better suited for dataclasses as we are not dynamically accessing their contents.
Candidates would be MapData, KAST, ClosestArea, DistanceObject and  RoundStatistics
This would however be a pretty breaking change as some of these types (for example DistanceObject) are returned from user facing functions.

Closing for Awpy 2.0
I think we can use Pydantic going forward. Can have a broader discussion in Discord


Add Jenkins to sandbox stack deployment

what

Add Jenkins to sandbox stack deployment

why

Jenkins is the desired CI/CD pipeline engine for EVTR

references
N/A

/test


Don't report name after forcerename for namelocked users

It looks like this removes the mention of the staff member who did the forcerename? Why?

The mention was removed a while back because it was annoying and you can just check modlog if you need to know. If you want me to still keep the data around then I can, I guess, but afaik it's not used anywhere.

I'd prefer for the data to still be kept around (if only to make it easier to hotpatch).


Storage Accounts redundancy support matrix - tables info integration

Good morning,
I'm studying the tables in Docs  ( https://docs.microsoft.com/en-us/azure/storage/common/storage-redundancy )  regarding Storage redundancy:

Supported Azure Storage services   (https://docs.microsoft.com/en-us/azure/storage/common/storage-redundancy#supported-azure-storage-services),
Supported storage account types   (https://docs.microsoft.com/en-us/azure/storage/common/storage-redundancy#supported-storage-account-types).

Referring to the documentation in Storage account overview  ( https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview ), in detail:

Types of storage accounts (updated)   (https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview#types-of-storage-accounts),
Legacy storage account types  (https://docs.microsoft.com/en-us/azure/storage/common/storage-account-overview#legacy-storage-account-types),
I have noticed that the tables in question are slightly incomplete and need to be integrated to provide an overall picture.

The current version of the tables is as follows:

My proposal is to update them as follows (my additions are highlighted in red):

I believe it can be a comprehensive and useful reference tool for quickly identifying information at a glance.
From direct experience, the redundancy topic for Azure Storage is typically the thorniest and most debated among colleagues, which is why I think this clarification is useful.
Thanks in advance for your cooperation.
Luca Bovo - beanTech

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f618f40d-ae53-5c3b-d8bf-0e80614f66d3
Version Independent ID: 93083407-8f1e-b3e2-6a62-e30be5e1fbcb
Content: Data redundancy - Azure Storage
Content Source: articles/storage/common/storage-redundancy.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

Hi @lucabovo , thanks for bringing this to our attention. I have assigned the issue to the content author to evaluate and update this doc as appropriate

Hi @tamram ,
Are there any updates about this request?
Thanks a lot,
Luca

@lucabovo - Thanks for your suggestions! I agree, and I've updated the doc accordingly.
#please-close


Sj refactor

@devinmarieb Check it out.  Made some minor changes to the code - mainly moving the sign in function to the utilities file - and cleaned up syntax in some places.

awesome arrows


Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I would like to add the chatbot to the website so that it becomes more authentic.
Alternatives
No response
Additional Context
No response
Are you interested in contributing?

[X] I'd like to work on this issue

Code of Conduct

[X] I have used the search function to check if an issue already exists
[X] I agree to follow this project's Code of Conduct

Which program are you contributing in?
ssoc

a chatbot like this

i will be adding questions and answers on the dialogflow platform
and rest dialogflow will handle matching qs to most suitable answers
This will help people solve some common doubts and issues related to the platform directly through chatbot

Describe more

a chatbot like this present at the bottom right

i will be adding questions and answers on the dialogflow platform
and rest dialogflow will handle matching qs to most suitable answers
This will help people solve some common doubts and issues related to the platform directly through chatbot

Describe more

A  chatbot which provides the basic information to the intruders about the digitomize.


Add a function to get the value of a field by path and indexation.

Add a function to get the value of a field by path and indexation.

Hi Eloy,
This is cool thanks for adding. First impressions,
Why no function receiver, maybe receiver of XMLElement and remove the first parameter from function?
and instead GetField name how about GetValue isn't it more informative?
Tamer

Hi @tamerh here you have ;)

Great. Just better with pointer receiver?  And i guess both "else" are not needed as golint gives me warning?

ok!! Done :)

Merged:)


Nutritionix API Call

create credentials for nutritionix API
setup API call to nutritionix API
get nutritional values and image of requested food from the nutritionix API

closed with 4ea0a39


Fix logic on date range search

It appears to have originally been backwards which broke date range searches.

Wow, thanks!


Reproduce the experimental results of the paper

First of all thank you very much for your paper, it has been a huge help to me.The project you uploaded has also greatly helped my research. I want to ask you a few questions.
1.Are the results shown in the paper based on "sim = torch.exp(sim/temp),  itd=10, itc=20" ? However, what is the result of "sim = sim/temp,  itd=5, itc=10"? Under the setting of "sim = sim/temp", is this  "itd=5, itc=10" optimal?
2.I am using 4 Nvidia 1080 for training and it takes 15 days for me to run a 25000kimg experiment, I would like to know your equipment and how long it will take to run one training session.

The results are mostly based on "sim = torch.exp(sim/temp), itd=5, itc=10" (But I remember I used much smaller value for Multi-modal CelebA-HQ), I don't think  "sim = sim/temp, itd=5, itc=10" or "sim = sim/temp, itd=10, itc=20" are optimal. Because after removing the exponential operation, you need to tune the temperature of contrastive loss. Also, --gamma is very important and can be sensitive to different datasets, I suggest searching from range [0.1,10]. 10 is used for COCO, but CUB and Multi-modal CelebA-HQ used much smaller gamma.
I used 4 Nvidia V100 to train. 25000kimg may need 3~4 days.

Thanks for your answer. I did a little experimentation, on the CUB dataset, "sim = sim/temp, itd=5, itc=10"without modifying any other hyperparameters, did get the results in your paper(Although the training is not completely over, it is close to the paper results. FID=11.16, 2000kimg).

So, The result in the paper is that the hyperparameters have been searched, under setting of sim = torch.exp(sim/temp). But there is no search for hyperparameters under the setting of sim = sim/temp yet?
Modifications of hyperparameter settings may still yield better results. Is that so?

I am a beginner in deep learning. My question may seem unprofessional, thank you very much for answering my question.

Yes, with the implementation of sim = torch.exp(sim/temp).
Yes, I believe better results can be obtained with more carefully hyper-parameter searching (for both implementations), because what I did is roughly searching from several fixed constant (such as 1, 5, 10, 20), you can see there are still lots of potential combinations.

By the way, please update your final results of CUB here after you finishing training, so other people can know what the results will be under that setting. Thanks a lot.

I think you don't need to run 25000 kimgs on CUB, because CUB has less than 9000 images.

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

https://github.com/drboog/Lafite/blob/a69b91622a12d5a0d226443d9cd84eb5e4f850d2/metrics/frechet_inception_distance.py#L15

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

https://github.com/drboog/Lafite/blob/a69b91622a12d5a0d226443d9cd84eb5e4f850d2/metrics/frechet_inception_distance.py#L15

inception model pre-trained on imagenet  is not usually directly used on CUB ,such as attnGAN, stackGAN,DF-GAN

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

https://github.com/drboog/Lafite/blob/a69b91622a12d5a0d226443d9cd84eb5e4f850d2/metrics/frechet_inception_distance.py#L15

inception model pre-trained on imagenet is not usually directly used on CUB ,such as attnGAN, stackGAN,DF-GAN。
Hence, I'm wondering if the CUB result in the paper is not appropriate? anyway, this work is great and impressive

I experimented with this setting of "CUB dataset, sim=sim/temp ,itd=5, itc=10, 2200 kimg" and got FID=10.89（Continued training does not lead to continued improvement in FID）, which is similar to the result of 10.48 in the paper. If I find out later in my experiments that I can get better results with a certain hyperparameter setting, I'll report back in this issue.Thanks again for your work and answer.

Which inception model do you use, pre-trained on imagenet or fine-tuned on CUB?

https://github.com/drboog/Lafite/blob/a69b91622a12d5a0d226443d9cd84eb5e4f850d2/metrics/frechet_inception_distance.py#L15

inception model pre-trained on imagenet is not usually directly used on CUB ,such as attnGAN, stackGAN,DF-GAN。 Hence, I'm wondering if the CUB result in the paper is not appropriate? anyway, this work is great and impressive

Yes, I think StackGAN, AttnGAN, DM-GAN, DF-GAN used the fine-tuned inception model to calculate the IS.
To calculate FID, DF-GAN and DM-GAN used the pre-trained model directly from torchvision.models.inception_v3. No FID is reported in StackGAN and AttnGAN. So I think FID results are OK.
As for IS results, unfortunately, I don't have access to the original fine-tuned model used in StackGAN. And I think fine-tuning a model by myself may not lead to fair results. Considering others and future works may want to compare with our method, I choose to use the pre-trained inception model, so everyone can quickly get results under a fair comparison.
But it will be interesting to see the IS results with the original fine-tuned inception model from StackGAN. I hope someone who has that fine-tuned model on their machine can test it later.

kGAN, AttnGAN, DM-GAN, DF-GAN used the fine-tuned inception model to ca

The fine-tuned model is available in DF-GAN,DM-GAN. Note that they used different inception models on CUB and COCO. The fine-tuned model is first provided by stack GAN. According to my experience, the IS of this work will not be more than 4.5 （tested on fine-tuned inception model). I highly recommend the authors update this metric in the paper.

kGAN, AttnGAN, DM-GAN, DF-GAN used the fine-tuned inception model to ca

The fine-tuned model is available in DF-GAN,DM-GAN. Note that they used different inception models on CUB and COCO. The fine-tuned model is first provided by stack GAN. According to my experience, the IS of this work will not be more than 4.5 （tested on fine-tuned inception model). I highly recommend the authors update this metric in the paper.

DM-GAN and DF-GAN did not upload the fine-tuned inception model... they provided links, which basically leads to https://github.com/hanzhanggit/StackGAN-inception-model. However, the model is on longer available there. If you have the fine-tuned model, can you send it to me, or upload it to google drive?

Can you explain and elaborate more on "According to my experience, the IS of this work will not be more than 4.5"? I see that DF-GAN and DM-GAN have already obtained IS of 4.75 and 5.10 with the fine-tuned model. According to your experience, what convinces you that that IS of this work will be worse than theirs and less than 4.5? Thanks.

I'm really sorry for my judgment without support from experiments. I do not mean to offend the authors.  I agree that this is a good paper. My opinion is based on the qualitive comparison of  this paper on CUB with DF-GAN and DM-GAN. Lafite looks even worse than stackGAN. I think that mabey Lafite is based on styleGAN-v2 hence, it will be weak compared those models designed for CUB. If you are interested in text-to-image, you can email me in private

kGAN, AttnGAN, DM-GAN, DF-GAN used the fine-tuned inception model to ca

The fine-tuned model is available in DF-GAN,DM-GAN. Note that they used different inception models on CUB and COCO. The fine-tuned model is first provided by stack GAN. According to my experience, the IS of this work will not be more than 4.5 （tested on fine-tuned inception model). I highly recommend the authors update this metric in the paper.

DM-GAN and DF-GAN did not upload the fine-tuned inception model... they provided links, which basically leads to https://github.com/hanzhanggit/StackGAN-inception-model. However, the model is on longer available there. If you have the fine-tuned model, can you send it to me, or upload it to google drive?
Can you explain and elaborate more on "According to my experience, the IS of this work will not be more than 4.5"? I see that DF-GAN and DM-GAN have already obtained IS of 4.75 and 5.10 with the fine-tuned model. According to your experience, what convinces you that that IS of this work will be worse than theirs and less than 4.5? Thanks.

Sorry, I'm not familiar with text-to-image,  I just guess that based on subjective judgement. After my experiments, the results accord with the paper well. Thank you for your great work and careful reply.  I apologize for my crude comments. Best wishes! sincerely.

I'm having some doubts while reading your code. I know this part of the code is from stylegan, but if you know about it , I hope it can answer my doubts. The code uses DDP for distributed training. It is divided into multiple rounds in a batch, and Gradient Accumulation is used to speed up.

If batch size=64, gpu num=4, batch_gpu=8, then round=2. Therefore, when calculating the contrast loss, multiple GPUs in a round are gathered to obtain negative samples for contrast, then the number of negative samples is 32, not the 64(batch size).Is that so？

For Gradient Accumulation, stylegan only puts forward process in model.no_sync, but not backward(). Is such Gradient Accumulation effective?
https://github.com/drboog/Lafite/blob/a79c66a407dd7996052b6c7c9d77a338380506b4/training/loss.py#L81-L82
https://github.com/drboog/Lafite/blob/a79c66a407dd7996052b6c7c9d77a338380506b4/training/loss.py#L268
I thought that all reduce operations of gradient synchronization will be carried out in backward, but backward() is not in model.no_sunc, will it prevent unnecessary all reduce at this time?

These two doubts are not related to your thesis itself, but are caused by my shallow knowledge, thank you very much for answering it. As a beginner, I don't know if I express my doubts clearly

In my implementation, I manually set "batch size = 16*gpus" (round will be 1), and the contrastive loss is computed per GPU, i.e. using 16 samples instead of 64. If you want to calculate the contrastive loss across GPUs using 64 samples, you can add "--gather=True", but then you have to tune the related hyper-parameters (itd, itc, temp), see https://github.com/drboog/Lafite/blob/a79c66a407dd7996052b6c7c9d77a338380506b4/training/loss.py#L215
In your "batch size=64, gpu num=4, batch_gpu=8, round=2" example, the contrastive loss will be calculated on 8 samples with "--gather=False", on 32 samples with "--gather=True".
I'm not sure about the second question.

Thank you very much for always answering my doubts promptly, even though some questions are not related to the paper. I really appreciate it!

You are welcome :)


Feature Request: Multiple Body Token types

As a: GM
I want: Caterpillar-enabled enemies to have multiple 'body' segment images
So that: Caterpillar-enabled enemies can taper toward their ends

What I'm proposing is a refactoring of the Caterpillar interface to allow for creating more graceful transitions from the head token to the rear token. Please see the following mockup:

Length
50

Segment Token Image
Segment Length %
Segment HP %
Is End?
 Tokens generated for this 'Segment' of the Caterpillar will use this image. This allows for a visual taper.
Segment Length %: Integer. Of the 50 token length specified above, this percent of the Caterpillar will use the image for the Segment. For example, the first segment would generate 25 Tokens.
Segment HP %: Integer. This percentage of the Prototype Token's HP will be divided among tokens generated for this Segment. For example, if the Prototype token has 100 HP, Tokens in the first segment would have 2 HP each (50 HP / 25 Tokens)
Is End?: Boolean. Designates the Segment as the end of the Caterpillar. A single Token is generated for this segment, ignoring Segment Length %.
Controllable?: Boolean. Only available if Is End? is checked. Allows the end token to be controlled independently of the Prototype token, in the case of two-headed creatures for example.

I think that this would allow for more dynamic Caterpillars that have more granular damage spreads as well.

A good idea, and very well described. No promises on time to deliver here I'm sorry.

My detail level and points of contact are meant only to convey enthusiasm for your project and in seeing it grow! Please don't apologize - you have been creative and generous in your development. Thank you so much.


Added a new Abbreviation : AISB

Closes #201

[x] Added new abbreviation
[ ] Fixed something in the source code
[ ] Added a new feature
[ ] Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.
I have added a new slang abbreviation in the dictionary i.e. AISB which means "As it should be/as I said before".
Share a screenshot of new changes

@Njong392 kindly review and merge the PR :)

@Njong392 kindly review and merge the PR :)

I get to all PRs and issues as soon as I can :+1:


[BUG]: Fluent Details List not sorting correctly

Describe the bug
Since 24/07/2024 the Fluent Details List no longer shows the data as it is sorted by in the "Items" collection.
The gallery used as a data source for the Details List, does sort correctly, but this no longer pulls through.
This only happens in Authoring version v3.24073, reverting back to an earlier version fixes the problem.
A warning message also pops app when opening the app in Edit mode, see below.

AB#3895

Hi, we are aware of this issue impacting the sorting order of datasets in controls such as the Details List and are working to deploy a fix soon. In the meantime, please revert back to Canvas studio version v3.24072 (by appending "&studio-version=v3.24072.6.302069373" to the studio URL) to fix this issue.
You can refer to this known issue for live updates as the fix deploys. https://admin.powerplatform.microsoft.com/knownissues/4238060

The fix has been deployed, please verify and close the bug when you can.

Can you please verify what has been fixed, the Creator Kit or Power Apps, as far as I can see nothing has changed.


Shared executor for LuceneTestCase#newSearcher callers

Until now, LuceneTestCase#newSearcher randomly associates the returned IndexSearcher instance with an executor that is ad-hoc created, which gets shut down when the index reader is closed.
This has made us catch a couple of cases where we were not properly closing readers in tests. Most recently, we have been seeing test failures (OOM - unable to create thread) due to too many executor instances created as part of the same test. This is to be attributed to creating too many searcher instance, each one getting its separate executor, which all get shutdown at the end of the entire suite. The main offender for this is QueryUtils which creates a new searcher for each leaf reader, and the top-level reader gets closed in the AfterClass, hence all the executors will stay around for the entire duration of the test suite that relies on QueryUtils.
This commit eagerly creates an executor in an additional before class method for LuceneTestCase, and associates that with each searcher that is supposed to get a non null executor.
Note that the executor is shutdown in the after class to ensure that no threads leak in tests.
This has the additional advantage that it removes the need to close the executor as part of an index reader close listener, which requires the reader to have an associated reader cache helper.
As part of this change we are also reducing the number of max threads from 8 to 2.

this is nice, much cleaner. I think i added the original cache-helper-hack. Just one question: can we reduce the number of threads used? I have 2 cores. shouldn't 2 be enough to occasionally find bugs rather than 8?

Thanks @rmuir for looking, I lowered the number of threads


"Format contains illegal characters" when using emojis and possibly other allowed symbols.

Not a huge issue. Everything still works though if you ignore it. Reason I ran into this is my template is YYYY-MM📅 so they're easier to find in the graph view.
I pinned the issue down to this line. https://github.com/liamcain/obsidian-periodic-notes/blob/a1f85d0b99708f7982ee8cf9e0c88aad181b12c7/src/settings/validation.ts#L10
The regex is too strict. I would suggest using a regex that matches anything but obsidian's current prohibited characters /^[^*"\\/<>:|?]+$/ although this might still be too strict in the future due to this request probably getting implemented soon: https://forum.obsidian.md/t/list-of-not-allowed-characters-in-the-file-name-make-it-os-specific
Alternatively, error when the user tries to create the note?

Good call, that validation is definitely too strict. I'll revisit it for the next version, thanks for flagging!

This is now be fixed in version 0.0.8. Let me know if you're still experiencing issues!