Investigate why getting settings value on package install fails but fixes itself upon ST restart.

Description of the bug
Currently, when the package is installed, there are 2 things that are going haywire.

It seems that the sublime.find_resources API fails to find py33/browse.py needed for gathering 3.3 commands.
Settings just return None, instead of their default values.

Both these issues fix themselves upon a restart. With (1), of course on restart, the necessary files are created. (2) is still puzzling.
Steps to reproduce

Install the package from Package Control (or use Package Control: Add Repository.
Use CommandsBrowser: Browse Available ST core commands
See the logs being spammed in the console about None being returned.

Expected behavior
It just works correctly when installed and no restart is required.
Actual behavior
Need to restart once to get things to work normally.
CommandsBrowser version
1.0.1
CommandsBrowser settings.
{

}

Fixed in v1.2.1


rpm packages conflict

# ll
total 18344
-rw-------. 1 root root    1400 Oct 12 13:06 anaconda-ks.cfg
-rw-rw-r--  1 root root 9530332 Nov 13 16:32 orchestrator-3.0.13-1.x86_64.rpm
-rw-rw-r--  1 root root 9103019 Nov 13 16:32 orchestrator-cli-3.0.13-1.x86_64.rpm
-rw-rw-r--  1 root root   14316 Nov 13 16:32 orchestrator-client-3.0.13-1.x86_64.rpm
[root@localhost ~]#
[root@localhost ~]#
[root@localhost ~]#
[root@localhost ~]#
[root@localhost ~]# rpm -Uvh orchestrator-*.rpm
Preparing...                          ################################# [100%]
        file /usr/lib/.build-id/d4/dd95e3838068032ebe82f1edc9138799b90d25 conflicts between attempted installs of orchestrator-1:3.0.13-1.x86_64 and orchestrator-cli-1:3.0.13-1.x86_64
[root@localhost ~]#

thank you. I have no immediate idea why this happens. I could use help on this as I have very limited time right now.

@mia0x75 I recently built rpm packages for the latest commit and they seem to be working fine. Can you try rpm -Uvh --force orchestrator-*.rpm it's possible a previous (aborted)installation left files behind that is preventing a normal install.

@flopex I built an brand new VM to install the rpm packages (git version), it looks fine, thanks.


⚠ GitLab Server has degraded performance

In 9347808, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 13465 ms

Resolved: GitLab Server performance has improved in 140befa.


Riffmaster/clone hero

I have a riffmaster and clone hero and want to play I have rb4 instrument mapper already as well as ViGEmBus. All the buttons work except it's as if the whammy bar is down always when it's not. Or it's not picking up the whammy bar at all.  Can you help me fix this issue.

Make sure the whammy bar is calibrated correctly in Clone Hero's control mapper:

Press Space on the main menu
Click on the Calibrate button in the top-left
Find the Right Stick X axis
Click Calibrate and follow the instructions

Leave it unpressed during the first timer, then press it down all the way a few times during the second

If it's still having issues, can you enable packet logging and send the resulting log file here?

This may have been the same issue as #22, try v5.0.1 and see if that fixes your issue.

Thank you very much for all your help. You are much appreciated

I presume things are all good now? Double-checking before I close this issue.

It's still acting up on me. But it works sometimes and dosent other times. You are much appreciated either way.

Got busy for a while and couldn't check in lol, are you still having issues?
If you are, I'd like you to elaborate on what exactly is going wrong. Is it still just the whammy bar acting up, or is it something else?


Sort post previews by date

This component is used in the main page view but was not sorting the posts by their date attribute.

Thank you @njacobs5074 for the PR 👍


Switch from w7900 to using any persistent cache runner for CPU.

This commit switches from w7900 to using any persistent cache runner for CPU model testing.
ci-exactly: build_packages,regression_test

This one has to happen on top of the removing cache env var PR because different machine will have different cache location.


APT whitelist request for rethinkdb

This replaces travis-ci/travis-ci#4411.
The original text by @belucid follows

ppa:rethinkdb/ppa

Ran tests, but could not found source package. Either the source package for rethinkdb does not exist, or the package needs an APT source. If you wisht to add an APT source, please follow the directions on https://github.com/travis-ci/apt-source-whitelist#source-approval-process. Build results: https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72545643.

https://github.com/travis-ci/apt-source-whitelist/pull/91 is the corresponding whitelist PR
https://github.com/travis-ci/apt-source-whitelist/issues/80 is a duplicate issue
These have all been sitting idle for over a month. Anything we can do to get this moving faster?

@BanzaiMan Bump...

+1

:+1:
travis-ci/travis-ci#2048 refers to the same issue too.
Please merge travis-ci/apt-source-whitelist#91, this will resolve 3+ issues

:+1:

@BanzaiMan please comment, this is going on the better part of a year here with no comment. This prohibits my tests from being run on the container infrastructure.


[sea-orm-cli] Better handling of relation generations

It has been reported that the codegen can generate non-compilable code when dealing with relations.
As the first step, we can simply skip generating the relations if:

the related entity is self::Entity (https://github.com/SeaQL/sea-orm/discussions/231#discussioncomment-1449066)
there exist multiple relations to the same related Entity (#218)

Later, we can also try to generate Links inplace of those relations.

Hey, this doesn't look like too hard of an issue, can I take it? Also, is this repo participating in Hacktoberfest (or rather, would you be willing to add the hacktoberfest-accepted tag once I get to the PR stage?)

@AngelOnFira do you want to assign this to yourself or you have other ideas?

Ya, if I can be assigned this it would be good :smile: I just got caught up in the other PR I was working on 😛

Hey @AngelOnFira, any updates on this? :P

Thanks for checking in, I need this for a project I have coming up, but I've been super busy with other work. As soon as I do have time, I do plan on hopping on this issue since it's quite important to me, but if someone else has time to work on it right now, I'd be very grateful for that as well :(

Thanks for checking in, I need this for a project I have coming up, but I've been super busy with other work. As soon as I do have time, I do plan on hopping on this issue since it's quite important to me, but if someone else has time to work on it right now, I'd be very grateful for that as well 😄

Thanks!! @AngelOnFira. Take your time!

Hey @AngelOnFira, I have just open a PR for this. You can check it if you have time :))


Simplify MPS support

Simplified the MPS support based on your suggestion @t-vi  (CC @Andrei-Aksionov).
It's a bit trickier to have unit tests for this behavior now (because we can't force to run the MPS code on non-Mac machines now), but it's fine because we know the previous unit tests for equivalency passed. And sure, we can have macOS tests for this alternative path, but the problem is that MPS has subtle numerical differences, so I don't expect the results of MPS and CPU to be equivalent. But we can address this is in #1725
Note that I also changed the default type for MPS to bf16 because it seems supported now. If we use regular float 16, we can get weird inference results for many models, which is why I changed it.

Perhaps it's possible to mock tensor's device output, so you can test both code execution paths.

It's a bit trickier to have unit tests for this behavior now (because we can't force to run the MPS code on non-Mac machines now),

what you can do is

make the mps variant a separate function with the same signature (called with if on the device type),
run the model with / without mocking the batched_index_copy to the mps variant.


Efficiency Ratio

Efficiency Ratio implementation
https://tradingtact.com/kaufman-efficiency-ratio/
Checklist

[X] I have completely filled out this template
[X] I have confirmed that this issue exists on the current master branch
[X] I have confirmed that this is not a duplicate issue by searching issues

It looks like the Kaufman Efficiency Ratio is already calculated in the KaufmanAdaptiveMovingAverage.cs#L119.

@AlexCatarino Yep, this indicator contains much of the same code from there but not returns the efficiency ratio.

Hey guys! thanks for the awesome work!
I will need your experience to answer a simple question that will totally show how much of a noob i am (started studying qc and python 2 weeks ago)
...I got the Efficiency ratio code (big fan)... how do i get it in my quantConnect so i can call it like an indicator?
Thanks :)

@ACasteZZ Once the code is merged into Lean, you can call it using self.KER(symbol, period, Resolution). You can find how to use indicators in the documentation.

@jovuribe Thanks. I guess i'll have to keep monitoring this issue to know when that will happen? :)
Thanks for the work! and great timing too


⚠ Bofrost.de has degraded performance

In 4e10062, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1211 ms

Resolved: Bofrost.de performance has improved in 6de160a after 44 minutes.


[microNPU] re-enable network tests

This commit re-enables tests that
had failed due to a interrupted downloading
of the testing data.

Fair enough @driazati ! did the change

cc : @Mousius @leandron

Thanks @manupa-arm, tests re-enabled :smile_cat: !


schema is missing data_type value in enum used by Sentinel-2 uint15

S2 optical bands use unit15 https://docs.sentinel-hub.com/api/latest/data/sentinel-2-l2a/, but this is not one of the allowed values in the schema.

Actually, I think unit16 is correct for data_type, but an example of bits_per_sample=15 should be added to clarify use of that.
`


config_update() causes a silent crash

Tested on Lubuntu 24.04.1 LTS (64-bit).

This was actually an oversight that caused a crash on any platform


Filtering on an empty index returns invalid_filter

Describe the bug
When performing a search with a filter on an empty index, an invalid_filter error is returned.
To Reproduce
Steps to reproduce the behavior:

Create an index
Set the filterable attributes
Perform a search with a filter using one of the fields set in the filterable attributes
See error

Expected behavior
Filtering on an empty index shouldn't return an error
Meilisearch version: [e.g. v0.25.0]
Additional context
I'm using the rust client v0.14. During the server startup, I set the index and the filterable attributes via index.set_settings(&settings).

Which version of meilisearch are you y using ?
I thought this bug was fixed in the v0.25.2 🤔

Which version of meilisearch are you y using ?

Oops, I made a small mistake when editing the template :sweat_smile: . I'm using meilisearch 0.25.0. That clarifies it.
Thanks, @irevoire !


bcpc-hadoop::yarnproxy recipe is not used any where

bcpc-hadoop::yarnproxy is not used in any of the roles and hence yarn-proxyserver and yarn-historyserver are not installed in the cluster.

We have the history server installed as part of role[BCPC-Hadoop-Head-MapReduce].
But indeed bcpc-hadoop::yarnproxy is still orphaned -- and installing the history server redundantly now.


Yarnpkg not found when attempting to collect latest info

Issue Description:
When running the command to collect the latest information, the build process fails with an error indicating that the yarnpkg command is not found. This issue seems to be caused by a missing or outdated version of Yarn installed on the system.
Steps to Reproduce:

Clone the repository and navigate to the project directory.
Run the command or script responsible for collecting the latest information (e.g., yarn collect-latest-info or npm run collect-latest-info).
Observe the error message stating that the yarnpkg command is not found.

Expected Behavior:
The command or script should successfully run and collect the latest information without any errors related to missing dependencies or commands.
Environment:

Operating System: [Specify your operating system and version]
Node.js version: [Specify your Node.js version]
Yarn version (if installed): [Specify your Yarn version, if applicable]

Additional Information:

The issue occurs consistently across different machines and environments.
Manually installing Yarn (if not already installed) or updating to the latest version does not resolve the problem.

Possible Solutions:

Update the installation instructions or documentation to ensure that users have the required dependencies, including Yarn, installed correctly.
Add a check in the build script or command to verify the presence of yarnpkg and provide a helpful error message or fallback option if it's not found.
Consider implementing an automatic installation or update process for Yarn within the build script or command.

Attachments:

Please let me know if you need any further information or clarification regarding this issue.

I reverted your changes, fixed pnpm 9 issue with test.
You need to prepare another PR this time not breaking the tests.
Use pnpm unit to run unit tests locally.

ok, i will.


Can't access file in $request from dispatchFrom

If you have a Request object which includes files, and you call dispatchFrom using that Request object, the files are stripped out.
I think the problem lies in Illuminate/Bus/Dispatcher.php in function getParameterValueForCommand. It looks for the value in the $request array, but files aren't available from the $request array.

I would pass the file via the "extra" params.

But doesn't that defeat the purpose of sending a Request to dispatchFrom? I send the Request so that if I add new inputs (including file inputs) to my form, I don't have re-visit the controller and remember to pass those new inputs along.
So anytime I add a file input I have to remember to add the new file to the extras array?

I'm simply considering that better than the somewhat hacky solution of
seeing if the array access object has a files property. Would be better IMO
to modify array access request logic to look at files.
On Friday, March 27, 2015, Matt McDonald<EMAIL_ADDRESS>wrote:

But doesn't that defeat the purpose of sending a Request to dispatchFrom?
I send the Request so that if I add new inputs (including file inputs) to
my form, I don't have re-visit the controller and remember to pass those
new inputs along.
So anytime I add a file input I have to remember to add the new file to
the extras array?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/8137#issuecomment-86882164.

@taylorotwell You're up early, lol.

@taylorotwell Yes - it did seem a bit hacky! Had another go... any better?


Works great but can't run offline, Can't dreambooth train custom models

Describe the bug
I have everything working but I want to run this offline. Nerdy Rodent mentioned that I can do this by typing in
HF_DATASETS_OFFLINE=1 TRANSFORMERS_OFFLINE=1 as the transformers need an internet connection, info here https://huggingface.co/docs/transformers/v4.15.0/installation
I tried typing that but still does not run offline. and gives https error if internet disconnected. In addition I tried to follow the section about running the model offline also and specifying one manually. Did not work.
https://huggingface.co/docs/transformers/v4.15.0/installation
Can anyone give any clear assistance here? I really don't want to just merge the models in automatic1111 gui, I really feel I would get better results dreambooth training a custom model instead. Thanks!
Reproduction
Disconnect internet
Logs
No response
System Info
GTX 3080 10GB

I had same.
I put my model.ckpt into CompVis/stable-diffusion-v1-4,
then I got a Error.
OSError: Can't load tokenizer for 'CompVis/stable-diffusion-v1-4'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'CompVis/stable-diffusion-v1-4' is the correct path to a directory containing all relevant files for a CLIPTokenizer tokenizer.
Is there any way to use my own model in Dreambooth?

I had same. I put my model.ckpt into CompVis/stable-diffusion-v1-4, then I got a Error.
OSError: Can't load tokenizer for 'CompVis/stable-diffusion-v1-4'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'CompVis/stable-diffusion-v1-4' is the correct path to a directory containing all relevant files for a CLIPTokenizer tokenizer.
Is there any way to use my own model in Dreambooth?

Did you found your anawer? looks for the same, more like training a ckpt file and not the diffuser.

Convert your ckpt to a diffuser model as per this post:
https://www.reddit.com/r/DreamBooth/comments/y1q7bo/comment/it8dh3p/?utm_source=share&utm_medium=web2x&context=3
I'm training with a custom model now and it seems to work.

Thanks, it would be nice if this repo added the script so it will convert the ckpt to diffuser then back to ckpt when the training is done.


[ENHANCEMENT] DLive show over RSSI bar

Currently the radio allows to send DTMF codes by pressing number buttons during pressed PTT, and the receiving party can see these codes using the DLive functionality.
This can be useful to send some information digitally.
However now when DLive is enabled the received codes are not displayed, because the RSSI bar covers it and are only shown when RX ends.
It would be cool that if DTMF codes are received they are displayed immediatelly and the RSSI bar is hidden for the duration.
WHYT @egzumer ?

Radio receives a lot of garbage DTMF codes. It will hide the rssi. For me personally live DTMF is useless, it is only there because it was added by 1o11 and it didn't bother me.

Yea that's a fair point.
I was thinking the same about the usefulness of it, but the ability to send digital data now makes it appealing to me.
Closing this one, as indeed that could hide RSSI bar when unintended.
I might just make the delay longer so the codes are displayed longer.


Support module.yml in zephyr repo

Is your enhancement proposal related to a problem? Please describe.
The zephyr repository is the only one in the standard manifest that is not managed as an actual module.  This prevents using the same algorithmic solution for referencing files in Zephyr from another module as used to reference other modules.
This "special case" handling of finding the zephyr-resident code tree is contrary to best practices in software engineering, makes all related logic more complicated, and increases the cost of understanding the Zephyr build system when debugging issues.
As a down-stream integrator, I would also like the freedom to tweak my fork of Zephyr just like every other module.
Describe the solution you'd like
I would like to see the zephyr build system fully support having a "module.yml" file in the zephyr repo and treat it exactly like every other module.
Describe alternatives you've considered
I have not considered any other alternatives, since this is a request for simplification.
Additional context
None.

BTW,The documentation section would ideally also be a module, the documentation is large, and not everyone needs to rebuild the documentation or unstructured documentation source material.

Actually, the Zephyr-structured documentation section(s) should be discovered through module.yml as well, leaving  style, logo, etc to be picked up from wherever the doc build was started. 😉
Sent from my iPhone
On Feb 10, 2022, at 10:28 PM, yxh @.***> wrote:

BTW,The documentation section would ideally also be a module, the documentation is large, and not everyone needs to rebuild the documentation or unstructured documentation source material.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzephyrproject-rtos%2Fzephyr%2Fissues%2F42700%23issuecomment-1035916295&data=04|01||b89281e41cc34938149808d9ed27a5a5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637801576806218656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=BxPsx3lNSxZo7wTDDr7D8uugYJ9l5e3J3sZPtvFoS2M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHXKD22PVNTQGBKGCDCR26DU2ST65ANCNFSM5OBQ2JSA&data=04|01||b89281e41cc34938149808d9ed27a5a5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637801576806218656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=fmu28xtIrFwwpTIC6se5Oknl9U%2FJ%2B%2Fy4KRuViMT8j0k%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

The zephyr repository is the only one in the standard manifest that is not managed as an actual module.

Because it is not a module, it's a lot more.

This prevents using the same algorithmic solution for referencing files in Zephyr from another module as used to reference other modules.

Exactly because it is not a module, so being able to refer to Zephyr using ZEPHYR_ZEPHYR_MODULE_DIR would give the wrong impression.
This is no different than the fact that if you include a repository in your manifest, which contains code but is not a Zephyr module, then you cannot refer to it as ZEPHYR_<module>_MODULE_DIR.
For example, like in this case: https://github.com/nrfconnect/sdk-nrf/blob/cfedfdfa08567b2252b511a4d1db15fbeba8152d/west.yml#L156-L160
    - name: mbedtls-nrf
      path: mbedtls
      repo-path: mbedtls
      revision: mbedtls-2.26.0
      remote: armmbed

which include ARM mbed TLS but it's not a Zephyr module.
You have to refer to code in such a repository in another way, not as a module.
Now, making Zephyr itself a module bears the risk of complicating the build flow and confuse users.
Clearly not all code can be treated as module code, cause all the logic around creating the core build system parts, setting up toolchains, handling of Zephyr modules, etc. must be done before any Zephyr module can be loaded.
Whereas other parts of the build system in principle can be loaded as module code, for example subsys and drivers.
I'm concerned such split can also cause confusion, cause suddenly some parts of the Zephyr tree is loaded as core build parts and other parts are loaded as module code.
This will make it hard for users to keep track of which code parts are loaded as core build part and which are loaded as module.
I do see some pros in this proposal and is not opposed to it, but I also have some doubts and concerns.
Anyone with an opinion on this matter, feel free to drop a comment.

it's a lot more.

Agreed - partially.  It is also:

a manifest repository (also true of example-application module)
contains the build/document generation/test runner systems (which eventually need to be extensible)

Once we trim the Zephyr directory structure down to what is not currently accessible via module.yml and is not repository-specific we end up with:

cmake/  (build/tools)
doc/ (which will get revisited when we start enumerating user-level requirements)
Kconfig.zephyr  (build/tools - which would have some content moved into existing Kconfig)
MAINTAINERS.yml  (codebase metadata)
scripts/  (build/tools)
share/  (build/tools)
zephyr-env.*  (build/tools)

I disagree that this is "a lot" more.
What am I not noticing?

making Zephyr itself a module bears the risk of complicating the build flow

How does this complicate the build flow?

This will make it hard for users to keep track of which code parts are loaded as core build part and which are loaded as module.

ZEPHYR_BASE == install/build/doc generation tools
$workspace/zephyr/zephyr/module.yml == module
$workspace/zephyr/**/*.[sh, py, bat, etc] == tools

When will I need to care in a way not covered by the manner of reference?

This prevents using the same algorithmic solution for referencing files in Zephyr from another module as used to reference other modules.

@gregshue in order for the benefits of this proposal to be clearer to all, could you expand on what this means in practice please?

making Zephyr itself a module bears the risk of complicating the build flow

How does this complicate the build flow?

Today, both Zephyr modules and west are optional.
With this idea you will have to always get Zephyr in as a module, and if using west this would then happen automatically but if not using west are users then suddenly expected to include Zephyr as a module ?
And if not, and Zephyr always includes itself as a module also, then how are users supposed to opt-out of this module.
The whole idea behind Zephyr modules, is to make it possible to add / remove modules to/from Zephyr build system depending on your needs.
It is not intended as a way to load Zephyr itself.
Now, starting to treat parts of the Zephyr repo itself this ways opens up for lots of questions as to what a module is.
How it is handled / configured (notice how modules Kconfigs are sourced into a dedicated tree in Kconfig).
What parts of Zephyr are considered to be so optional that users should have the ability to opt-out ? network, bluetooth, logging, kernel, ...

if not using west are users then suddenly expected to include Zephyr as a module ?
No. Even without west, the solution can automatically add Zephyr to the module list if there is not already a module named 'zephyr'.

how are users supposed to opt-out of this module.
It is impractical for users to opt-out of the module providing standard/infrastructure interface headers, even if they opted out of every implementation (e.g., libs/drivers/subsystems/tests/samples/etc) in the Zephyr repository.  As indicated above, a user could provide their own module named 'zephyr' if another solution is not provided.

At this point we do not have a standard way to "opt-out" of a module other than removing it from the module list.  If every module defined a boolean CONFIG_<MODULE> and made all its CMakeLists.txt content dependent on it, then we would have a standard solution.

The whole idea behind Zephyr modules, is to make it possible to add / remove modules to/from Zephyr build system depending on your needs.
As a user, I also need the ability to add/remove/replace implementations of individual subsystems/components/drivers rather than modules.  This is true even for the implementations in Zephyr.  Extending the Zephyr repo to be a module actually aligns needs and drives toward a standard solution.

How [the Zephyr module] is handled / configured?
The build system configuration stays as is.  The source trees that are found in other modules are handled exactly the same way here.

What parts of Zephyr are considered to be so optional that users should have the ability to opt-out ? network, bluetooth, logging, kernel, ...
It does not matter whether they opt out or replace with an alternate implementation (to fix bugs or provide enhancements or ...). That is not for us to decide. It is up to us to provide the capability in a reusable release.  (BTW, yes, yes, yes, yes, ... essentially every implementation, but not interface definitions or configuration settings.)

Zephyr modules are not guaranteed to be processed in specific order ...
That issue is independent of this one.  Other modules will be found in similar circumstances as Zephyr does.

if Zephyr is being included by another manifest file, then it might be sourced later
when, not if.  That issue is independent of this one, and already exists.

then it might be sourced later, will that work?
That is an existing issue.  This proposal just highlights the need.

must all modules suddenly depend on Zephyr?
They already do.  Consider the dependencies for at least the module.yml definition, and likely for the Zephyr wrappers to CMake commands,  Kconfig support/definitions/conversions to preprocessor symbols.

Though in the original issue I only mentioned one reason for extending the Zephyr repository to be a module, there are several.  Consider:

Following the (best practice) Software Engineering Design Principle of Separation of Concerns (http://swebokwiki.org/Chapter_2:_Software_Design#Software_Design_Principles). Clearly separating the portions elsewhere managed in modules from the build system is a broadly accepted strategy in managing complexity. This is a demonstration of commitment to stated values and modeling desired behavior.
Highlighting the broad support of the module.yml interface for extensibility. This is already a requirement, and implementation and automated verification have been lacking.
Raising increased awareness that issues and enhancements relevant to the module zephyr are almost(?) always relevent to other modules, and vice-versa.  This reduces the risk of oversights in related build system architecture and functionality.
Providing a reference (and test case) for when modules need to build subdirectories located above the provided zephyr/CMakeLists.txt.

As a user, I also need the ability to add/remove/replace implementations of individual subsystems/components/drivers rather than modules.

and this is a part to which I agree, we should strive to have Zephyr as modular as possible when it's possible, and not making working with Zephyr unnecessary complex.
However, being able to easily integrate with Zephyr and adjust it to custom needs is not the same as making Zephyr itself a module.
For example, Zephyr already offers various possibilities for customization, for example:
https://github.com/zephyrproject-rtos/zephyr/blob/22c0843485b5d03a8bf1de8499fe1d20d2ded3d3/drivers/entropy/Kconfig.nrf5#L7-L12
https://github.com/zephyrproject-rtos/zephyr/blob/22c0843485b5d03a8bf1de8499fe1d20d2ded3d3/cmake/extensions.cmake#L455
And I believe it would be great if such patterns could be better formalized and used in a consistent way, so that it is easier and more predictable when / where / how Zephyr can be customized.

What parts of Zephyr are considered to be so optional that users should have the ability to opt-out ? network, bluetooth, logging, kernel, ...

It does not matter whether they opt out or replace with an alternate implementation

It was intended as a rhetorical question, to show that those parts are core to Zephyr.
Of course a user can decide not to enable them, but they are core in the sense they should always be available to any sample which might want to enable them.
With my rhetorical question, I was simply trying to show why Zephyr itself is not a module.

Zephyr modules are not guaranteed to be processed in specific order ...

That issue is independent of this one.

if Zephyr is being included by another manifest file, then it might be sourced later

That issue is independent of this one, and already exists.

then it might be sourced later, will that work?

That is an existing issue. This proposal just highlights the need.

must all modules suddenly depend on Zephyr?

They already do.

No, those issues doesn't exist today cause Zephyr is not a module but the foundation on which all the other modules builds upon.
And this exactly highlights why Zephyr itself is not to be considered a module.
So to sum up, my current state on this:
Zephyr could improve in following areas:

Improved support for customization, today some _ALT settings and cmake commands exists to allow tweaking, but those are introduced on a need-to-have basis and grown organically.
It might be time to formalize a practice in this area
Improved modularization for reuse and support easier integration to the Zephyr build system, work is already happening in the area, see #41301
Doc building and possibility to customize this seems like a valid request, however I would consider such improvement low priority compared to many other enhancement tasks pending for the build system.

but Zephyr is not a module, and should not be treated as such.
So if you change the purpose of this issue to better integration. reuse, modularization, etc. of Zephyr, then I would be happy.

we should strive to have Zephyr as modular as possible when it's possible, and not making working with Zephyr unnecessary complex.

Yes. I completely agree with the goal.

being able to easily integrate with Zephyr and adjust it to custom needs is not the same as making Zephyr itself a module.

Yes. I completely agree.

It was intended as a rhetorical question, to show that those parts are core to Zephyr.

It is actually a very pertinent question, which is why I responded to it. :-)

they are core in the sense they should always be available to any sample which might want to enable them.

Be very careful here.  If we use this criteria for "core", then all HALs (indeed every module) are also core.  That is probably not what you intended. There are enough dependencies each direction between things in the Zephyr repo and the existing modules that (almost) everything becomes "core".
--
So I carefully re-read Module Repositories.  It seems the bullets at the beginning of this section are the normative definition of a module.
First note:

If the module has an external (upstream) project repository ...

The "If" clearly indicates modules do not have to be external projects.  Indeed, Zephyr's own example-application is a module that is not an external project.
Let's evaluate your concerns against this definition:

Zephyr modules are not guaranteed to be processed in specific order

Ref: https://docs.zephyrproject.org/latest/guides/modules.html#zephyr-module-dependencies

must all modules suddenly depend on Zephyr ?

Zephyr is ... the foundation on which all the other modules builds upon

It seems the concern is having to retrofit existing modules to describe the implicit dependencies on the Zephyr repository that already exist. This is an important concern, and would need to be addressed.
As a concession to backwards compatibility, the zephyr_module.py could be changed from stripping zephyr from the module list to ensuring zephyr occurs first in the module list (as already proposed).

if Zephyr is being included by another manifest file, then it might be sourced later

Regarding the zephyr repository, it seems ensuring zephyr occurs first in the module list would address that concern.

And this exactly highlights why Zephyr itself is not to be considered a module

With the concession for backwards compatibility previously identified, it seems:

the stated concerns are addressed
we have taken a step towards making Zephyr "as modular as possible when it's possible"
we have reduced complexity by making implicit layers explicit and follow a pattern consistent with analogous content in other modules, thus making it "more predictable when / where / how Zephyr can be customized"
we are making a change consistent with applying best practices (a stated value of the Zephyr Project)
we have simplified how to describe the zephyr repository by changing it from an "is-a" (polymorphic - where everything in it is accessed via ZEPHYR_BASE) to a "has-a" (composition - where some content is accessed via ZEPHYR_ZEPHYR_MODULE_DIR)-

Are there any new concerns?

It has been discussed several times that Zephyr is not, and shall not be a module.
Zephyr is Zephyr, the core of the system.
See also: https://github.com/zephyrproject-rtos/zephyr/pull/42927
which has been rejected.

As a down-stream integrator, I would also like the freedom to tweak my fork of Zephyr just like every other module.

Then I suggest you make these changes downstream. Fork zephyr and make your changes to your own fork, you have the freedom to make whatever changes you want in such a fork, call it something like gregphyr and make it a module. As for upstream, this is a NACK from me, the whole idea is completely at odds with zephyr.


Property "supportsDatabase" is missing in mssqlConnection.json

Issue
Microsoft SQL Server connector supports the database concept in its hierarchy but it is not present in the JSON schema.

Fixed in: https://github.com/open-metadata/OpenMetadata/issues/7010


[caat-2697] Add DontCares to undriven ports

Moving things off chisel2 semantics exposed some undriven ports
There may be a better solution. This PR represents the basic sledgehammer approach

Wrong target branch


[Bug]: share_plus >=6.0.0 is incompatible with file_picker >=5.2.11

Platform
Android 13
Plugin
share_plus
Version
6.3.4
Flutter SDK
3.7.12
Steps to reproduce
My project works with "file_picker" and "share_plus" dependence. When I updated both dependencies it gave me that error:
Because share_plus >=6.0.0 depends on win32 ^3.0.0 and file_picker >=5.2.11 depends on win32 ^4.1.3, share_plus >=6.0.0 is incompatible with file_picker >=5.2.11.
So, because my_project depends on both file_picker ^5.3.0 and share_plus ^6.3.4, version solving failed.
pub get failed

Any solution?
Code Sample
No response
Logs
Because share_plus >=6.0.0 depends on win32 ^3.0.0 and file_picker >=5.2.11 depends on win32 ^4.1.3, share_plus >=6.0.0 is incompatible with file_picker >=5.2.11.
So, because my_project depends on both file_picker ^5.3.0 and share_plus ^6.3.4, version solving failed.
pub get failed

Flutter Doctor
carielo@MacBook-Pro-de-Luis my_project % flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.3.1 22E261 darwin-x64, locale es-419)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] Android Studio (version 4.1)
[✓] Android Studio (version 2022.2)
[✓] IntelliJ IDEA Community Edition (version 2022.3.2)
[✓] VS Code (version 1.77.3)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

Checklist before submitting a bug

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Use https://dart.dev/tools/pub/dependencies#dependency-overrides till plugins are updated


Documentation links should all be HTTPS instead of HTTP

Nearly all (FWLink grep here) of the links in this repo are HTTP links. This is 2019 -- all the links should be HTTPS. (The example contoso.com URLs probably don't need to change, but might be easier to just update all of them too unless unsecure links are part of the example.
Also, when I resolve some of the FWLinks, they redirect to insecure HTTP downloads:
C:\code>curl -v https://go.microsoft.com/fwlink/?LinkID=285546 2>&1 | grep Location
< Location: http://download.microsoft.com/download/D/6/4/D641E8C1-B0B0-4FCD-B37F-D901F4F29AC2/

The FWLinks should also redirect to HTTPS URLs, not HTTP.

@officedocsbot assign @e0i

@-- Somehow your issue has been opened without being associated to a documentation topic.
Could you clarify which documentation you're referring to? A link would be helpful.
Thanks.

Hello, @darthwalsh
The issue is under investigation and you will be notified with any changes on the way.
Thank you for providing feedback.

This is fixed in #1860.
Thank you for the feedback.

Thanks for #1860, that fixed about 25 of the links.
But when I query the MicrosoftDocs/windows-powershell-docs repo for the regex http://go.microsoft.com/fwlink I expect to get zero results, but actually find multiple insecure HTTP links.

The sourcegraph search now displays zero results. Thank you for following up, and stay healthy.

I'm not sure what was showing zero results -- can you show me? For me, the grep link shows there are still some results to fix:

That shows the insecure link http://go.microsoft.com/fwlink on e.g. these lines:

https://github.com/MicrosoftDocs/windows-powershell-docs/blob/master/ThirdPartyNotices#L10
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/Microsoft.Medv.Administration.Commands.WorkspacePackager/export-medvworkspace.md#L129
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/Microsoft.Medv.Administration.Commands.WorkspacePackager/new-medvworkspace.md#L111
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/Microsoft.Medv.Administration.Commands.WorkspacePackager/new-medvworkspace.md#L111
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/agpm/add-controlledgpo.md#L163
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/agpm/agpm.md#L9
https://github.com/MicrosoftDocs/windows-powershell-docs/blame/master/docset/mdop/agpm/get-controlledgpo.md#L84

If that doesn't work for you, here's a command I'm running on the terminal that shows more insecure links:
~/code/windows-powershell-docs $ grep -r --include "*.md" "http://go.microsoft.com/fwlink" . | wc -l
   13457


After using SHIFT in combo with CTRL + F1 [F3], SHIFT subsequently increments values all by itself

I've been using SHIFT in combination with the CTRL + F1 [F3] keypresses to increase the speed by which the values increment and de-increment.  More than once, after doing this, pressing the CTRL key alone (no SHIFT, no F1 or F3 will continue to increment the values.    I haven't been able to nail down a fully reproducible pattern yet, but it happens frequently.
Installing the 0.9.5 hotfix did not solve the problem.
Thanks for your help.

Oops - I tagged the incorrect issue above. My PR did not fix this issue (different one!).

We can't repro but at the same time we've also further enhanced the handling of keyboard shortcuts.
I'd suggest we close it for now and if the issue surfaces with the next updates, we'll open it back.

Apparently the issue is still happening in spite of the tentative fix.

I can now reproduce this issue at will by using the Num Keys for bindings. Hopefully can make sense of it next.

@mbucchia confirmed that I also have this problem while using the Num Keys. Fingers crossed a solution is in the works. Thank you.

Unfortunately this is very very mysterious. We can reproduce but there is nothing explaining what's happening...

Could this simply be windows StickyKeys taking effect? Holding down shift or numlock causes the dialog to appear once as an accessibility feature of windows.   If in VR you could accidentally engage it and never know its selected..

My StickyKeys is disabled in Windows, so I don't think this is the issue.  Good thinking, though!


Configure Bors to use GitHub Actions rather than Travis checks.

The GitHub Actions workflows work better than Travis, and are a superset of the Travis checks. Travis is currently broken and I'd rather replace it with Actions than fix it. This PR should make Bors listen to GitHub actions rather than Travis.
If this works, then I'll remove the Travis config entirely in a future PR.

I'd normally consider this a significant PR and wait a week before submitting, but because Travis is currently broken I think this counts as a bug fix.

The actions based CI is failing because we still point to an older version of the Tock submodule which does not have the latest OpenTitan image.
It seems like an issue that we have to continually update the Tock submodule in order for CI to pass. @alistair23 is there some reason we can't vendor whatever OT image we are using into the Tock repository?

The OpenTitan boot ROM is a pain. We could vendor it in, I think the reason I didn't was due to license concerns and that it changes so rapidly.
There is a discussion here about doing this: https://github.com/tock/tock/issues/1937

It seems the failure was actually related to the Azure issues from last week.

In order for bors to work, the workflows it depends on need to be run on push to the "trying" and "staging" branches.

In order for bors to work, the workflows it depends on need to be run on push to the "trying" and "staging" branches.

I didn't know that! I'll make that change when I get the chance to.

Sounds good! I don't have push access to your branch but you can cherry-pick this commit if you want: https://github.com/tock/libtock-rs/commit/7113d39d9097d75c8c12d33fe6907eaa6c5f5512

Sounds good! I don't have push access to your branch but you can cherry-pick this commit if you want: 7113d39

I noticed you added master as well. Why is that?

Sounds good! I don't have push access to your branch but you can cherry-pick this commit if you want: 7113d39

I noticed you added master as well. Why is that?

I figured that in case someone does push or merge directly to master it can be useful to have the actions still run such that any mistakes are caught. Feel free to not include that, though

I pushed a commit that I think will solve the issue, with an explanatory comment. I decided to leave out master because we don't push to master directly and I don't want to consume resources unnecessarily.

bors r+


fluxctl identity returns nothing

Flux 1.0.0 on GKE, deployed with Ilya's Helm chart.
This works:
$ kubectl logs $(kubectl get -n kube-system pod -l weave-flux-component=agent -o jsonpath='{.items..metadata.name}') -n kube-system | grep identity.pub | cut -f 2 -d '"' | cut -f 1 -d '\'
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCy9lHud+tFBS9PsSdyH0/1VANhNhKO6rczAm3VYcffpxHPKeMBpi3sz4Q0siUc+ZQUC4PzNgEVFCL8OIt/ZMFg3Hb/zfQbm6U2wMjBD8QGjCMVHwOijcQmBuhl5P7HALBUo6noLt/DMNwXBe2BPpc1zO3wOAd2gKdS2suJWES6sY4KS8uGOjWBgVDB3Ob7E5AJWRoZFWBYzUeZk7DhPTncpqPas/Z+1azloy0L0IwZ0AaU7QKXRwZQ3hA8qiTFWuN//oaE1YRei5eOAeCZWuk3DFEQvktnX09RilGtRUjiHvSfM5hzva4859Tn7xM7KXXTZCRpDNeGBtD8ALUKTGxp

But this doesn't:
$ fluxctl identity
$

@sambooo could you please take a look? Thanks!

fluxctl identity is returning nothing for me as well, on standalone version deployed using the example configurations.


Reveal named div on radio select

In some layouts it would be useful to reveal a div below the set of radio buttons based on the option selected.
The markup could work a bit like this:
{{ govukRadios ({
  "id-prefix": "example",
  "name": "example",
  "fieldset": {
    "legend": {
      "text": "Example",
      "isPageHeading": false,
      "classes": 'govuk-fieldset__legend--m'
    }
  },
  "items": [
    {
      "value": "1",
      "text": "Option 1",
      "conditional": {
        "id": element_id
      }
    },
    {
      "value": "2",
      "text": "Option 2",
      "conditional": {
        "id": element_id
      }
    }
  ]
}) }}

Hi @alextea,
thanks for raising this. We will add this to our backlog and see if and when we can prioritised this.

Until we have something better, a work around you can structure your markup like so

Hi @alextea,
could you share more insight about the use-case of this, or any research conducted?
It might be something for the GOV.UK Design System Backlog

We're intending to fix the inline radios with conditional reveal which should address some of the issues here.
https://github.com/alphagov/govuk-frontend/issues/754
In the meantime you can use the HTML approach, if you find yourself needing to do this in the future, please raise in the backlog as Jani says above.
Thanks for raising.

This has also been raised by another community member who wanted to be able to do something like this:
{{ govukRadios({
        classes: "govuk-radios--inline",
        idPrefix: "basedInTheUK",
        name: "createNewAccount.basedInTheUK",
        fieldset: {},
        items: [
          {
            value: "yes",
            text: "Yes",
            checked: checked("createNewAccount.basedInTheUK",'yes'),
            attributes:
              {
                "data-aria-controls": "hidden-representative-email"
              }
          },
          {
            value: "no",
            text: "No",
            checked: checked("createNewAccount.basedInTheUK",'no')
          }
        ]
      }) }}

We've found a workaround that isn't too clunky:
`

        Do you want to add a representative to the account now?

If you want to trade on the account you'll need to add another individual to the account

          Yes

          No

          Invite a representative to the account

        {{ govukInput({
        id: "rep-email-address",
        name: "createNewAccount.repEmailAddress",
        classes: "govuk-input--width-20 format-number",
        label: {
            text: "Enter their email address"
        },
        value: data.createNewAccount.repEmailAddress
        }) }}

`
Would be nice to find a more concise way of doing this bit:
{% if (data.createNewAccount.addRep == "no") or ( not data.createNewAccount.addRep) %}
Any ideas?

If we were going to introduce this as a proper feature, we'd need to be confident that it could be done in such a way that it didn't introduce barriers for users of assistive technologies – especially screen readers and magnification tools.
We'd need to see evidence from user research with those users (of mixed abilities, i.e. not just 'power' users), showing that conditionally revealing another element elsewhere on the page (as in, not immediately following the radio button / checkbox) is clearly communicated to the user, that they understand that something has happened and how to navigate to the revealed controls.
We'd also need to see examples of cases where this pattern is shown to provide a better experience than e.g. splitting the form over multiple pages or using the existing conditional reveal pattern where the content is revealed immediately after the control.


BUGFIX: Use named Flow response

The Flowpack\ElasticSearch\Transfer\Exception fails
with a conflict when it tries to use Response from
flow while there is another Response class in the
same namespace. Fixed by renaming the imported
Response Object.

Added a 2.0 branch (which is even with master right now) and targeted the PR to it. See https://github.com/Flowpack/Flowpack.ElasticSearch/pull/55 for previous comments.


 Proposed fix is to resize the icons to 48x48 when importing.

done in #41


Nested route doesn't resolve when using local storage

UI Router 1.0.0-beta.1
Angular 1.5.8
Built with NG6 Starter Kit https://angularclass.github.io/NG6-starter/
using local storage for pretty uri's $locationProvider.html5Mode(true).hashPrefix('!');
I changed the url/uri names in my examples to be more relevant to whomever reads this
Error Message in Browser: Cannot GET /stores/management/status/1
URL : http://localhost:3000/stores/management/status/1
Routes
/  (home/default)
/stores  (placeholder, does not resolve to anything)
/stores/management  (parent component, shows a list of stores, has a named view in template)
/stores/management/status/1  (child component of stores, uses parent named view)
While using local storage for uri's the end user can view a list of stores found in uri /stores/management . From there the end user can click on a store and view the status of the store which results in the uri being /stores/management/1 . If the end user refreshes the page, or sends the url to another end user to view they will see a white screen and an error message.
If the end user follows the same steps stated above, but while the application is not using locat storage for uri's ( #! ), everything works as expected without any errors.
Parent Component Route
            .state('stores/management', {
                url: '/stores/management',
                component: 'storesManagement'
            });

Child Component Route
           .state('stores/management/status', {
                url: '/status/{id}',
                parent: 'stores/management',
                views: {
                	'content': {
                		component: 'status'
                	}
                }
            });

What you've described is in the FAQ, here: https://github.com/angular-ui/ui-router/wiki/Frequently-Asked-Questions#how-to-configure-your-server-to-work-with-html5mode
Basically, when a browser fetches a URL, the server returns a HTML page which has <script> tags that load angular.js, angular-ui-router.js, etc.  When you use HTML5Mode, the browser asks the server for some URL such as /stores/management.  The SERVER has to be configured to serve up the same HTML page that it serves for the / URL.   UI-Router isn't even loaded into the browser at this point.
FYI, Local Storage means something else (and doesn't concern URLs).  We call this "HTML5 mode" or "pushState".


[AV2-414] Task/generic services unit test

https://intersective.atlassian.net/browse/AV2-414

Can I ask why you imported SharedModule here? do we need that?

hi @ronakamani , the short answer, it's because GoMobileComponent itself is part of the GoMobileModule. And GoMobileModule need the SharedModule imported.
Full explanation:
From your question, I think you've gone through the code inside GoMobileComponent, and found that GoMobileComponent don't need SharedModule as dependency (imported into the constructor), which it might be the reason causing you to wonder why do we need that in SharedModule in the providers field in TestBed.configureTestingModule().
In order to get GoMobileComponent to work, we need to setup base for the GoMobileComponent, in this case, it's GoMobileModule. Inside GoMobileModule, we imported SharedModule, this import tells GoMobileModule that our code need some elements from SharedModule.
One of the reused component from SharedModule, the ContactNumberFormComponent. In our GoMobileComponent's template code, you'll find that we are using <app-contact-number-form></app-contact-number-form> which it's belongs to ContactNumberFormComponent from SharedModule, that's the reason we need that imported in TestBed to setup a full exact test target as the original one.

thanks Chaw
On Fri, Mar 6, 2020 at 3:49 PM trtshen<EMAIL_ADDRESS>wrote:

Can I ask why you imported SharedModule here? do we need that?
hi @ronakamani https://github.com/ronakamani , the short answer, it's
because GoMobileComponent itself is part of the GoMobileModule. And
GoMobileModule need the SharedModule imported.
Full explanation:
From your question, I think you've gone through the code inside
GoMobileComponent, and found that GoMobileComponent don't need SharedModule
as dependency (imported into the constructor), which it might be the reason
causing you to wonder why do we need that in SharedModule in the providers
field in TestBed.configureTestingModule().
In order to get GoMobileComponent to work, we need to setup base for the
GoMobileComponent, in this case, it's GoMobileModule. Inside
GoMobileModule, we imported SharedModule, this import tells GoMobileModule
that our code need some elements from SharedModule.
One of the reused component from SharedModule, the
ContactNumberFormComponent. In our GoMobileComponent's template code,
you'll find that we are using
 which it's belongs to
ContactNumberFormComponent from SharedModule, that's the reason we need
that imported in TestBed to setup a full exact test target as the original
one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intersective/practera-app-v2/pull/767?email_source=notifications&email_token=AEVCZ4CJZV7S5YT6442KNJLRGB6DVA5CNFSM4LA4G562YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOABZQI#issuecomment-595598529,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVCZ4EE4TEWYDSFPLKKX7TRGB6DVANCNFSM4LA4G56Q
.


Speed Up Model by Using cudnn benchmark

Not really an issue, but adding the following made training significantly faster (+29% on Titan X Pascal)
if torch.cuda.is_available():
    torch.backends.cudnn.benchmark = True

I thought I would mention it as others might benefit from this as well.
Thanks for making your code available on GitHub!

Thanks!


How to transform my private keys in Byron format to Shelley

I have some ADA coins before Shelley. But I only have the address's keys as format (64bytes extended privatekey, 32bytes publickey, 32bytes chain code), how can I tranform the keys format to Shelley's.
cardano-cli shelley transaction sign command only accepts shelley's skey file.
https://docs.cardano.org/projects/cardano-node/en/latest/stake-pool-operations/keys_and_addresses.html
How to use the legacy skey file to sign the transaction?

@zoowii: Apologies for the late response. The cardano-cli key convert-byron-key command will allow you to convert your Byron key to a corresponding Shelley-format key.

what's the file format the  cardano-cli key convert-byron-key accepts. I only have the raw (64bytes extended privatekey, 32bytes publickey, 32bytes chain code) hex/bytes, I generate them by code. It works in Byron era.

@zoowii the convert-byron-key accepts raw bytes.

Thanks. have dealt with this problem


Remove duplicate URI definition

@dbaeumer spotted this when re-generating my classes. This was added in both https://github.com/microsoft/language-server-protocol/pull/1156 and bae2aaba5946c84cb28c28f4437711d744576ed7 so there were two. This removes the one added in my PR and leaves just yours.

Thanks


AvlTree and AvlTreeMap lost consistency after delete/add operations

AVL tree lost nodes after remove / rebalance.
See https://issues.apache.org/jira/browse/DIRSERVER-1991.

Hi Jürgen!
Thanks for the patch! I have merged it in trunk, wand will run the tests today.

Hello Emmanuel,
thank you very much for the merge!


UTF-8 characters are not resolved in Puppeteer 1.16.0

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.16.0
Platform / OS version: MacOSX
URLs (if applicable): nope :/
Node.js version: 11.6.0

What steps will reproduce the problem?
I recently upgrade my local puppeteer version from 1.14 to the latest release.
Based on the template below, UTF-8 characters are not resolved. It seems that the page is in ASCII.
<!DOCTYPE html>
<html>
<head>
    <meta charset="UTF-8">
    <title>Some title</title>
</head>
<body>
    àé
</body>
</html>

What is the expected result?
I should get a page with the content àé.
What happens instead?
I get a page with the content Ã Ã© instead.

I have the same problem

https://github.com/GoogleChrome/puppeteer/issues/4424
Duplicated please close this issue, and post in the other.


fix: change Fairs2 artwork grid batch size from 20 to 30

The type of this PR is: Bugfix

This PR resolves FX-2346
Description
The artwork grid on the Fairs2 screen shows artworks in batches of 20.
This updates the batch size to 30, per the design spec. The new batch size is effect for show more pagination, as well as for refetching in response to filter changes.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a CHANGELOG.yml entry or my changes do not require one.

Looks good to me!


Update dmarc.md

Added Implementation Services Promo
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @negarzipan,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Webhook for discount update/delete

Hi there,
I would be really useful to have webhooks for any updates/delete of discounts in order to keep up to date with changes on Shopify side.
Thanks!

Hi there 👋
I am going to close this issue as this repository is for the javascript libraries and not the Shopify API itself.
I would recommend creating a post in the community forum, or reaching out to Partner Support with your feature request.


Raster resolution problem

In lab, we started to wonder if the original map wasn't produced using a coarser raster resolution.
In experimenting with this, we likely broke the code starting at line 681:
fig5comp = c( select(final,"rp"), select(orfig5rast,"or"))
because the original raster and the reproduction raster are no longer the exact same resolution / dimension.
If we do want the notebook to be robust to experimenting with different raster resolutions, we should encode the resolution as a variable and be sure to warp all rasters to match.

Root of the problem was in rasterizing the original figure 5 data from vector. This needed to use the blank raster as a template. Fixed with this commit: 7d6331c7a9608a96ecaf0770ef40c4fd44b732bd


[New Feature][Bug Fix][Ordem Parnormal] Fixed bugs and added paranormal cost roll

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
-> Fixed a visual bug where it can't be clicked.
-> Fixed attack rolls which are getting the wrong stats and in critical where damage are not correctly rolled.
-> Added Paranormal Cost Roll when Roll a Ritual

Character Sheet Info Roll20 Internal Use only.


React Native App fails to launch with Hotbox installed

I created a new React Native project. Installed the HotBox library. Everything compiles successfully. However, within the ios simulator, the app launches but doesn't load into the welcome to React Native screen instead it quietly closes. I have not modified any code other than linked the Hotbox libraries. Is there any additional setup I need to complete successfully launch the app?
Moses

Does the project crash in xcode?
Sounds related to this: https://github.com/facebook/react-native/issues/15762

No, I compiled useing the RN compile command for IOS.
I just compiled using xcode. It completed successfully. After launching the simulator, again it crashed. Here is the traceback message.
2017-09-04 13:26:53.009 [info][tid:main][RCTCxxBridge.mm:188] Initializing <RCTCxxBridge: 0x6080001bf2c0> (parent: <RCTBridge: 0x6000000ae280>, executor: (null))
2017-09-04 13:26:53.065 [warn][tid:main][RCTBridge.m:114] Class RCTCxxModule was not exported. Did you forget to use RCT_EXPORT_MODULE()?
2017-09-04 13:26:53.101 [info][tid:main][RCTRootView.m:301] Running application Tok ({
initialProps =     {
};
rootTag = 1;
})
2017-09-04 13:26:53.787 Tok[41141:2132130] -[NSTaggedPointerString unsignedIntValue]: unrecognized selector sent to instance 0xa313839333930327
2017-09-04 13:26:53.839 Tok[41141:2132130] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSTaggedPointerString unsignedIntValue]: unrecognized selector sent to instance 0xa313839333930327'
*** First throw call stack:
(
0   CoreFoundation                      0x0000000109c46b0b __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x000000010d1a4141 objc_exception_throw + 48
2   CoreFoundation                      0x0000000109cb6134 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3   CoreFoundation                      0x0000000109bcd840 forwarding + 1024
4   CoreFoundation                      0x0000000109bcd3b8 _CF_forwarding_prep_0 + 120
5   Tok                                 0x000000010870cb34 -[RCTMultipartStreamReader emitProgress:contentLength:final:callback:] + 244
6   Tok                                 0x000000010870d32a -[RCTMultipartStreamReader readAllPartsWithCompletionCallback:progressCallback:] + 1610
7   Tok                                 0x000000010875cc5c -[RCTMultipartDataTask URLSession:streamTask:didBecomeInputStream:outputStream:] + 444
8   CFNetwork                           0x000000010d846c51 __88-[NSURLSession delegate_streamTask:didBecomeInputStream:outputStream:completionHandler:]_block_invoke + 51
9   Foundation                          0x000000010a989237 NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK + 7
10  Foundation                          0x000000010a988f3b -[NSBlockOperation main] + 101
11  Foundation                          0x000000010a9876f7 -[__NSOperationInternal _start:] + 627
12  Foundation                          0x000000010a98347c __NSOQSchedule_f + 198
13  libdispatch.dylib                   0x000000010fbb305c _dispatch_client_callout + 8
14  libdispatch.dylib                   0x000000010fb9194f _dispatch_queue_serial_drain + 221
15  libdispatch.dylib                   0x000000010fb92669 _dispatch_queue_invoke + 1084
16  libdispatch.dylib                   0x000000010fb94ec4 _dispatch_root_queue_drain + 634
17  libdispatch.dylib                   0x000000010fb94bef _dispatch_worker_thread3 + 123
18  libsystem_pthread.dylib             0x000000010ff4a712 _pthread_wqthread + 1299
19  libsystem_pthread.dylib             0x000000010ff4a1ed start_wqthread + 13
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)

Yup, that's the same error I saw the other day. Follow the link I posted


swarm 1.2.0 fails to talk to docker 1.6.1

When creating a swarm with one engine on version 1.6.1, it fails to add the engine because of:
Failed to validate pending node: Error reading remote info: json: cannot unmarshal number into Go value of type bool  Addr=<IP_ADDRESS>:2375
This does work with version 1.1.3
To replicate:
$ sudo ./bin/docker-1.6.1  -d -H <IP_ADDRESS>:2375 -H unix:///var/run/docker.sock &
INFO[0000] +job init_networkdriver()
INFO[0000] +job serveapi(tcp://<IP_ADDRESS>:2375, unix:///var/run/docker.sock)
INFO[0000] Listening for HTTP on tcp (<IP_ADDRESS>:2375)
INFO[0000] /!\
INFO[0000] Listening for HTTP on unix (/var/run/docker.sock)
INFO[0000] -job init_networkdriver() = OK (0)
WARN[0000] Your kernel does not support cgroup swap limit.
INFO[0000] Loading containers: start.
..
INFO[0000] Loading containers: done.
INFO[0000] docker daemon: 1.6.1 97cd073; execdriver: native-0.2; graphdriver: aufs
INFO[0000] +job acceptconnections()
INFO[0000] -job acceptconnections() = OK (0)
INFO[0000] Daemon has completed initialization
$ ./bin/docker-1.6.1 run -ti -p 3375:2375 swarm:1.2.0 --debug manage -H <IP_ADDRESS>:2375 nodes://<IP_ADDRESS>:2375
--------8<-------
DEBU[0000] Failed to validate pending node: Error reading remote info: json: cannot unmarshal number into Go value of type bool  Addr=<IP_ADDRESS>:2375

I think it is an engine-api's handling error:
https://github.com/docker/engine-api/blob/master/client/info.go#L22
Swarm uses engine-api to communicate with docker engine.
I will try to check if we can solve it in engine-api

I started a docker engine 1.6.1, and get /info details from it.
I find that in the response field Debug is 0 which is a number, while in engine-api it should be the type of bool, so imcompatiblity happens.


Simplify MaestroHdfsSpec with assumption of ordered files

Ordered file listings are guaranteed by Permafrost >= 0.8.1.
Fixes #386.

:+1:.

Thank you @toddmowen!


CI: upgrade Julia version from 1.0.3 to 1.0.4

This is a bugfix release. No breaking changes.
see: https://julialang.org/downloads/

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/ib%2Fbump-jl10/1/pipeline/293#step-768-log-1450


Analytics Module name changed

Hi Team,
We have updated name of analytics platform, same is updated in docs.
Previous Name: YuktaMedia Analytics
New Name: YuktaOne Analytics by YuktaMedia
Please merge the changes.
Thanks

@jeanstemp Code update request is merged now. Can you please merge this as well. Thanks

Hi @shrikantpatwari , we'll merge this into the docs after the next Prebid.js release.

released with 4.3


Change name of default service name from main to service1

When this gets deployed.
https://github.com/resin-io-modules/resin-compose-parse/pull/24

Reverted change


Implement ObjectExt::emit() for emitting arbitrary signals

Depends on, and includes, https://github.com/gtk-rs/glib/pull/191

Before you ask, this is mostly useful for G_SIGNAL_ACTION signals. E.g. GtkWindow's activate-focus signal.
Action signals are basically function calls. They are emitted/called from the outside on the object, and the object handles them internally.

And updated so that it only includes the relevant commit here now

👍 Thanks again

Thanks! Waiting for CIs.

Indeed. :)


I wish /docs/editdocs/ existed

It is sort of referenced from http://kubernetes.github.io/docs/#contribute-to-our-docs but the thing that looks like a button does not behave like a button.

Should be fixed now. The correct URL was just /editdocs/ :)

yes, it is fixed.


Update samples and tests to target netcoreapp2.1

Follow up : https://github.com/aspnet/AzureIntegration/issues/120


[WIP] Adding proper logging to the repository

When you added a new program / programs , put a cross on the  OS that you have test it on
(Example: [ X ] Windows  )
[ x] Windows
[  ] Linux Ubuntu
[  ] Mac
[  ] Others  (State here -> xxx )
Assign a reviewer to review your code.

Running SimplestNetwork.java
terminal output before logging: https://gist.github.com/chiaweilim/c7659a2b98daffd7109e941f17ad2e52
terminal output after logging:
https://gist.github.com/chiaweilim/40132f887f3ad354cd17bd7933385586


[Help]: any way to process Envisat SAR data ?

hi, i am starting to use the Docker image of PyGMTSAR, i got to assess land movement of an area in a long-term period, hence both Sentinel and Envisat must be processed. any hint to do so with pyGMTSAR?
I also will be appreciated so much if you provide me some information on Envisat processing since i have no experience on Envisat.

PyGMTSAR currently supports only Sentinel-1 data. I work on the project in my free time, and I don't have any grants or funding for my work, so my resources are very limited for adding support for other missions.

alright thanks for your respond.

See https://www.linkedin.com/feed/update/urn:li:activity:7159957590272053248/


To add valid input message in all complex number calculator (2)

Describe the bug
To add valid input message in all complex number calculator (2)
Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

Hi, I want to work on this issue I will start working on it as soon as I get assigned!! I am a part of GSSoC'21.
Kindly assign this issue to me!
Discord Username : Abhijeet Sinha(P)
Discord Tag: #4018


change default schema of UrlGenerator@[asset,assetFrom]

change default schema of UrlGenerator
so that assets can auto load from https or http even behind reserve proxies (which u can not change settings).

@taylorotwell

Please don't ping after 2 hours...

Taylor does have to sleep. ;)

Also, this is a breaking change IMO :-1: from me.


issue with /abandonallclaims File issues

User is trying to use /abandonallclaims
http://pastebin.com/RMyvS3Ck
Errorspam lags the whole server.
GP 168
SF 1928

That palyer also has a weird player file:
http://prntscr.com/del05u
Not sure if the file caused the issue or the issue caused this file.

Just to make sure its not the command that is displaying wrong stuff:
http://puu.sh/sBXc0/177406a4ee.png

same issue here
GP 185
SF 1967
https://mega.nz/#!plt3FCrC!r4ZDnGxYX_NdUGbJG5WkVMiy2_0J9dJvm48w6kgIcMw
GP config file attached

Got some new info:
/abandonallclaims deletes the proper amount of claim blocks if return-ratio is not 1.
But as the players can do that infinitely without the actual claims are getting deleted(because of an error), the players gets hundreds/thousands of negative claimblocks.


ARROW-17330: [C#] Extend ArrowBuffer.BitmapBuilder to improve performance of array concatenation

Extend ArrowBuffer.BitmapBuilder with Append method overloaded with ReadOnlySpan parameter.
This allows to add validity bits to the builder more efficiently (especially for cases when initial validity bits are added to newly created empty builder).  More over it makes BitmapBuilder API more consistent (for example ArrowBuffer.Builder does have such method).
Currently adding new bits to existing bitmap is implemented in ArrayDataConcatenator, Code adds bit by bit in a cycle converting each to a boolean value:
for (int i = 0; i < length; i++)
{
builder.Append(span.IsEmpty || BitUtility.GetBit(span, i));
}

Thanks @asmirnov82 for the contribution. I didn't see this PR until now. I will make some time this week to review it.


Update BlobAttribute link

Fixing broken BlogAttribute links on https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-storage-blob

Merging fix for broken links


fix variables inside argument objects not based to remote schema in stitching

I have never contributed to an open source project before so sorry if the pull request description is not well formatted
Changes
i have changed the rewrite logic of object fields to fix a bug in parsing the arguments in schema stitching
the bug is not reported in github but has been reported in slack so i am including the bug description
bug description
if I have a query that accepts an object as an argument, e.g
query CreditApplicationList($userIds:[Int!], $statuses:[ApplicationStatus!]) {
    applicationViewForUsersByStatus(request: { userIds: $userIds, statuses: $statuses }) {
        id
        applicantName
        applicationDate
        address {
            line1
            line2
            line3
            line4
            postcode
        }
    }
}

passing the variables:
{
"userIds": [1],
"statuses": ["Approved"]
}

If i run this against the individual api, it works as expected, however if i run it against a stitched gateway, i get the error:
The following variables were not declared: userIds, statuses.
If I change this to:
query CreditApplicationList($request: CreditApplicationRequest) {
    applicationViewForUsersByStatus(request: $request) {
        id
        applicantName
        applicationDate
        address {
            line1
            line2
            line3
            line4
            postcode
        }
    }
}

{
    "request": {
        "userIds": [1],
        "statuses": ["Approved"]
    }
}

it then works on the stitched gateway

Hi @husseinraoouf,
first thank you for your contribution.
In order to finish this pr we need a tests that shows that you fix does what it is intended to. If you are on slack I can walk you through how to write such an integration test.

Hi @michaelstaib
I will try to create the test today and if i got stuck i will send to you at slack

Hi @michaelstaib
I have added the integration test and it is passing


Catch uncaught errors in node processes?

Not sure I should do this. Letting the process crash seems enough for the current use cases.

I guess that it's not needed now with the NoErrorsPlugin.


Configuring Service Providers without OAuth

What does this PR do?
Makes oauth configuration of service provider optional. When oauth configuration is missing, oauthURL is not created at all.
There is lot of refactorings how we load configuration for service providers. User configs has always priority over global configs.
Even when there is no explicit configuration for service provider, we should still be able to do manual token upload and detect correct service provider type in case it uses default url value (SAAS host).
TODO:

tests!!
documentation (how to create user configuration without oauth)

NOTE:

quay currently does not work https://issues.redhat.com/browse/SVPI-298

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/SVPI-270
How to test this PR?

images:

quay.io/mvala/service-provider-integration-operator:svpi270-spWoOauth2
quay.io/mvala/service-provider-integration-oauth:svpi270-spWoOauth2

case 1

configure service providers in config.yaml so they have oauth
oauthurl must be generated

case 2

configure sp in config.yaml without oauth
oauthurl must not be generated

case 3

configure sp in user's secret with oauth
oauth url must be always generated, completely independent from what is in config.yaml

case 4

configure sp in user's secret without oauth:

apiVersion: v1
kind: Secret
type: Opaque
metadata:
  labels:
    spi.appstudio.redhat.com/service-provider-type: GitLab
  name: sp-config-gitlab
data:

oauth url must never be generated, completely independent from what is in config.yaml

case 5

in binding, use public saas repository that has no configuration in either config.yaml or user's SP
it must be possible to upload the token and sp type must be detected properly

usecases 1-3, 5 tested on github - it works. case 4. How to configure sp in user's secret without oauth? Do we need to document that?

@skabashnyuk I've updated 4 with example secret. I'll add it to docs as well


chore(packages): update eslint packages to v4.1.0

Closes #109

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   91.89%   91.89%
=======================================
  Files           1        1
  Lines          37       37
  Branches        9        9
=======================================
  Hits           34       34
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c278d...69f7e7a. Read the comment docs.


deleteOfflineProject function  error fixed

Fixed #2242
Describe the changes you have made in this PR -
Included data.js in simulator/edit.html.erb
Screenshots of the changes (If any) -
Before-

After-

@ShreyaPrasad1209, will you please look at my PR.

Coverage remained the same at 82.582% when pulling 66a8f6741d643032f1654de2badd9f8a8df4d736 on Kartikay304:deleteOfflineProject-error#2242 into 6362a9eb4a9fd6b5391c8e4ef0e3b82525e722de on CircuitVerse:master.


Implement JNA wrapper for libsodium

Currently using lazy sodium which seems to be rarely updated and latest release still has fixed bugs.
To resolve this JNA wrapper needs to be implemented either here or as a separate library for both Android and Java
This will require

Number #8 closes this


Execute action on key down too?

Is there a way to make the make the action execute on both key down and key up?

Sorry, not at the moment. (See MASShortcutMonitor, we look for the kEventHotKeyPressed event.) It should be trivial to patch the code yourself to watch both kEventHotKeyPressed and kEventHotKeyReleased, but I think the feature would be used so seldom it’s hard to justify adding it to MASShortcut. What’s your exact use case?

Thanks for the info @zoul! I'm writing an application that is momentarily activated while a hotkey is held, so active when pressed, inactive when released.

Ah, that makes good sense. In that case I suggest writing your own MASShortcutMonitor class (it should be fairly simple to adapt it from the vanilla one) and plugging it into a MASShortcutBinder, maybe even the shared one. Then you should get what you want while still keeping the rest of MASShortcut. Do you think that would work for you?

Thanks a lot for your suggestion @zoul! I'm pretty new to macOS/Cocoa development though and I'm not entirely sure if I understand you correctly. Should I write a new MASShortcutMonitor (not subclassing the existing one) and plug it into MASShortcutBinder using its setShortcutMonitor method?
In that case I’d think it would be easier for me to fork the repo and modify the existing MASShortcutMonitor to allow for the functionality. Or am I wrong thinking that or wrong in my understanding of your suggestion altogether?

You got my suggestion just right! The advantage in comparison to forking the repo is that you could keep using vanilla MASShortcut, getting new bug fixes, features etc. (But that’s just the first thing that came to my mind when thinking about your problem, so there might be an obvious downside somewhere.) I think we could even make MASShortcutMonitor easier to modify, but I don’t have the time right now.

Cool! I'll give it a shot once I have time one of the coming days.

@zoul I gave that shot in: https://github.com/shpakovski/MASShortcut/pull/111


test(progressindicator): add knobs to progress indicator story

Summary

Adding storybook knobs so we can use them, trying them out in ProgressIndicator

Acceptance Test (how to verify the PR)

To verify, test out the new knobs in ProgressIndicator

:tada: This PR is included in version 1.10.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Beaglebone uboot is sensitive to noise on UART0, might hang on boot

From @imrehg on September 21, 2016 7:32
Reported that BeagleBone Black uboot is sensitive to spurious noise on UART0 during boot, as noise might be interpreted as stop string.
See messages:

https://groups.google.com/d/msg/beagleboard/aXv6An1xfqI/2_tLa7oWQBIJ
http://lists.denx.de/pipermail/eldk/2014-June/002511.html
also reported in support

The solution seems to be adjusting the uboot to be more resilient to noise, for example
CONFIG_AUTOBOOT_KEYED=y
CONFIG_AUTOBOOT_DELAY_STR="uboot"

or using the header files
#define CONFIG_AUTOBOOT_KEYED	1
#define CONFIG_AUTOBOOT_DELAY_STR "uboot"

I guess the value of that string can be other values too, it's arbitrary just expect something. In the latest upstream u-boot there are some things like this implemented in uboot defconfig files since about the v2015.07 release, and for BeagleBone specifically since v2016.03 (current resin version seems to use v2014.07).
 Front conversations
Copied from original issue: resin-os/resin-beaglebone#39

From @BrianAdams on September 21, 2016 17:30
This was the patch we added to fix the issue: https://github.com/BrianAdams/Bootloader-Builder/blob/fix/autoboot/patches/next/0003-Autoboot-keyboard-beaglebone-fixes.patch

Also part of the analysis shows that the beaglebone reference u-boot project did add the condition that the character on the serial line has to be a " " which fixes the problem.


[Form Validation] "Is Valid" Method Needed

You should be able to call $('#myForm').form('is valid') and have it return a boolean value.
A use case is preventing a modal from closing onApprove by returning if the form is valid.

It's been a year, any updates on this?
Or is there another way to synchronously know whether a form is valid?

Is there anyway to listen if the form is valid or not - If the form is valid/invalid I would like to toggle the disabled class in the submit button so the user cannot close the modal unless all fields are valid?

Still need solution to check if form is valid from my code...

Lost this thread somewhere in the ages. Will revisit some additional, obvious, missing form behaviors after 2.0 launch.

@DruidKuma
I've added is valid method as a stopgap. Returns true/false if form validates.
i.e.
if ( $('form').form('is valid') ) {
  // do something
}

https://github.com/jlukic
Very impressed with such a quick solution. Thank you very much.

The biggest problem with this project is just keeping on top of open issues. Feel free to ping any other threads that need attention.

It would be great if there was a way to silently ask a form if it validates without all errors popping up.
Use case: Toggle enabled state on submit on the fly.
Right now a call to form('is valid') gets really messy on an empty form. This is not desirable.
On a sidenote: It would be great if the validation state was reflected on the form the same way it is relected on individual fields via the error-class.

@erlando +1

So I'm going to set is valid to no longer update UI by default. This was a mistake that got codified, and I'm pretty sure no one is expecting is valid to behave that way.  See #703 for other changes to these functinos in 2.2.8

Added in 2.2.8 as described above.


Improve etcd kcp upgrade for manual orchestration

Original PR reviewed: https://github.com/abhay-krishna/cluster-api/pull/25
Description of changes
Adds a new annotation to the KCP that when present, stops the cluster controller from pausing/unpausing the KCP when etcdadm cluster is not ready. We make this behavior opt-out to maintain compatibility with previous eks-a controllers/CLI that won't have this new orchestration logic (to be implemented in eks-a).
Some extra improvements:

Reconcile external etcd in cluster controller before control plane.
Consolidate kcp pause/unpause in the control plane reconcile phase.
Fix existing etcd unit test.
Fix bug in AddAnnotations (already contributed upstream)
If etcd is not ready, re-queue kcp.
If etcd status has no endpoints or an empty list, re-queue kcp (this avoids kcp nodes being rolled out without endpoints if for some reason the etcd members fail their healthcheck).
Minor refactors/moving code around for clarity (tried to keep this at a minimum to minimize risk)
Added unit tests for existing patches in cluster and kcp controllers.
Added unit tests for new functionality.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/approve


Comments megaissue

The Issue
current APIs:
        Create and associate a comment with a claim using your channel identity.

        Usage:
            comment_create <claim_id> <channel_id> <message> [--parent_comment_id=<parent_comment_id>]

        Options:
            --parent_comment_id=<parent_comment_id>  : (int) The ID of a comment to make a response to

        Returns:
            (dict) Comment object if successfully made

        List comments associated with a claim.

        Usage:
            comment_list <claim_id> [--flat] [(--page=<page> --page_size=<page_size>)]
                         [--parent_comment_id=<parent_comment_id>]
                         [--max_replies_shown=<max_replies_shown>]

        Options:
            --flat  : (bool) Flag to indicate whether or not you want the
                                    replies to be flattened along with the rest of
                                    the comments attached to the claim. Off by default
            --parent_comment_id=<parent_comment_id>  : (int) The ID of an existing
                                                             comment to list replies from
            --max_replies_shown=<max_replies_shown>  : (int) For every comment that we pull replies from,
                                                             only retrieve up to this amount.
                                                             Note: This is not the same as page size.
            --page=<page>  : (int) The page you'd like to see in the comment list.
                             The first page is 1, second page is 2, and so on.
            --page_size=<page_size>  : (int) The amount of comments that you'd like to
                                       retrieve in one request

        Returns:
            (dict)  Dict containing the following schema:
            {
                "page":  (int) The page of comments as provided when limiting response to page_size.
                "page_size":  (int) Number of comments in the given page. -1 if page_size wasn't used
                "comments":  (list) Contains all the comments (as dicts) as provided by the specified parameters
            }

[ ] Fix doc strings / cli so that you can also pass parameters to comment list/create like this, which is consistent with other API calls we have (and these should be defined in the Options doc string): lbrynet comment create --claim_id=xxx --channel_id=xxx --message=xxxxx

[ ] Support channel_name as parameter, to be consistent with publish/other api calls that take channel id

[ ] consider renaming parent_comment_id (list/create). This will be a transaction id most likely when it comes to the blockchain/supports based solution.

[ ] remove claim_id/comment_id/downvotes/upvotes/claim_index/omitted from create/list response. None of these will be valid in the supports based solution. They will be tx / metadata related

[ ] page size -1?

C:\Users\thoma\Desktop>lbrynet comment list de90b0068c8f2d7a019b06ce000591172891658e
{
  "comments": [
    {
      "author": "41fd2f30939bfbcae26c7248c2ada7b6d9a7a3db",
      "claim_index": 14,
      "comment_id": 55,
      "downvotes": 0,
      "message": "heyyyyyyyyyyy",
      "omitted": 0,
      "reply_count": 0,
      "time_posted":<PHONE_NUMBER>,
      "upvotes": 0
    }
  ],
  "page": 1,
  "page_size": -1
}

[ ] rename message > comment?

[ ] Actually sign the comment and include signed hex value of comment when creating/listing. This would allow us to republish any existing comments when we move to the blockchain solution.

Would like to review these with @eukreign sometime this week.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Internal Use
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

@tzarebczan page_size = -1 is to signify that page_size wasn't specified. I don't know of any other universal way to signify that there's no limit/it's the full page, and using "infinity" makes things messier since you start having return type inconsistency.
I've also considered setting it as the size of the page but if I did that then the person wouldn't be able to tell if it's being paginated or not in the response.
We can just specify it as the default but when I was looking at other APIs, they all tried to just return as much as possible, and network latency didn't seem like an issue so it didn't make much sense.
I can change that if you think it would make more sense to use something else.
Also most of the other stuff if not all of it can be fixed at the server end which is what I'm going to do once I post this.

@tzarebczan Do you want channel_name to be used in place of author, or should I just change it to channel_id?

@BrannonKing Can you give me the metadata tags you're going to be working into supports? I can implement them in the prototype database which would give us something to also test and play around with.

@osilkin98 - regarding page size, see the claim_search api - it shows the size as default.
Regarding channel_name, see how the publish api uses it. If we are using author on the list side, it should be populated with the channel URI (name + claim ID) and then the app can show the name + link to URI of channel.

@tzarebczan. Will we want to be storing any additional metadata about the channel claim which will then be fetched, or is that all?

Don't need to store it in the database, that channel metadata will come from resolving it in the app. So given what we are currently saving, you'd need to run a claim search with the claim id on each one to get the channel name which we wouldn't want to do.

Thanks for the clarification, I'll have it ready once I'm done with all my
final stuff at school.
On Tue, Apr 30, 2019 at 11:41 AM Thomas Zarebczan<EMAIL_ADDRESS>wrote:

Don't need to store it in the database, that channel metadata will come
from resolving it in the app. So given what we are currently saving, you'd
need to run a claim search with the claim id on each one to get the channel
name which we wouldn't want to do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry/issues/2049#issuecomment-488003510, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEAH2R6ZJAH4S4TYXIU76TTPTBSDVANCNFSM4HIEF5BQ
.

Still todo:

[ ] claim signing and sending this signature to the comment server. The comment server will store it for now. We can validate later.


website: "gradients" link should go to #gradient, not #gradients

just a tiny nitpick. the target anchor on svg.js' main website (couldn't find a repo for that) just links to the very top of the documentation, rather than to the "Gradient" section

Mh - I have no access to that. I will tell him with the next mail

closed with #350