Incorrect Challenge Completion Calculation

I found a minor discrepancy when going through one of the recent challenges. Specifically, it was at the conclusion of the "CSS Flexbox" challenge (within the "Responsive Web Design Certification"). The challenge incorrectly displays the amount completed. The challenge shows the completed amount as 65% (first image). However, I had actually fully completed the CSS Flexbox challenge (second image)
There were no issues with the site and nothing to prevent moving forward, this was just a cosmetic item.
Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/responsive-web-design/css-flexbox/use-the-align-self-property
Tell us about your browser and operating system:

Browser Name: Google Chrome
Browser Version: Version 88.0.4324.104 (Official Build) (64-bit)
Operating System:

Microsoft Windows 10 Pro
If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
Screenshots attached
Thanks,
Preston

Thank you, for taking the time to open this.
Unfortunately, I am unable to reproduce this issue. Would you mind checking if you still come across this?

Hey Shaun. You are correct... it does not occur now. I had tested this
repeatedly just to be sure it was not something I was doing wrong. However,
I tested this today and it is no longer occurring. Not sure what to say...
:/
Thanks,
Preston
On Thu, Feb 4, 2021, 8:19 AM Shaun Hamilton<EMAIL_ADDRESS>wrote:

Thank you, for taking the time to open this.
Unfortunately, I am unable to reproduce this issue. Would you mind
checking if you still come across this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/40908#issuecomment-773386524,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADR6JX5OSA35ULLGY6UTU4DS5K3G5ANCNFSM4XB63NCQ
.

Shaun... something to note. Just for curiosity sake, I went back and chose
the prior challenge before the one in question (CSS Grid: Using Media
Queries). When I completed said challenge, it automatically calculates as
the entire CSS Grid challenge is 100% complete, even though there is one
additional challenge in the set. I am not sure if this is due to already
completing the entire challenge and moving on to the Responsive Web Design
Projects or something else.
Preston
On Thu, Feb 4, 2021, 12:35 PM Preston Miller<EMAIL_ADDRESS>wrote:

Hey Shaun. You are correct... it does not occur now. I had tested this
repeatedly just to be sure it was not something I was doing wrong. However,
I tested this today and it is no longer occurring. Not sure what to say...
:/
Thanks,
Preston
On Thu, Feb 4, 2021, 8:19 AM Shaun Hamilton<EMAIL_ADDRESS>wrote:

Thank you, for taking the time to open this.
Unfortunately, I am unable to reproduce this issue. Would you mind
checking if you still come across this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/40908#issuecomment-773386524,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADR6JX5OSA35ULLGY6UTU4DS5K3G5ANCNFSM4XB63NCQ
.

Hey Preston,
Thank you, for doing that. Glad to hear it is working for you again.

When I completed said challenge, it automatically calculates as
the entire CSS Grid challenge is 100% complete, even though there is one
additional challenge in the set. I am not sure if this is due to already
completing the entire challenge and moving on to the Responsive Web Design
Projects

This is the designed and expected behaviour. So, no worries there.
I am going to close this issue. If you come across this again, feel free to reach out again, and we can reopen this, and dig more.


Loader not working

Hello,
I'm trying to use this loader to annotate the output of Babel, however it doesn't seem to work.
This is my grunt config:
module: {
          loaders: [
            { test: /\.js$/,
              exclude: /(node_modules|bower_components)/,
              loaders: [
                'ng-annotate',
                'babel?optional[]=runtime&comments=true&compact=false',
              ],
}

This is the function:
export default class DataSourceServiceProvider {
  constructor(endpoint) {
    this._endpoint = endpoint;
  }

  /*@ngInject*/
  $get(Restangular) {
    return Restangular.all(self._endpoint);
  }
};

And the final result does not have any annotations.
AccountApp.provider('UserService', _data.UserServiceProvider);
```

```
var DataSourceServiceProvider = (function () {
	  function DataSourceServiceProvider(endpoint) {
	    _classCallCheck(this, DataSourceServiceProvider);

	    this._endpoint = endpoint;
	  }

	  /*@ngInject*/

	  _createClass(DataSourceServiceProvider, [{
	    key: "$get",
	    value: function $get(Restangular) {
	      return Restangular.all(self._endpoint);
	    }
	  }]);

	  return DataSourceServiceProvider;
	})();
```

Hope you can help :)

@vlad-dragos hello.
Actually it isn't about ng-annotate-loader, but about using ng-annotate with babel.
Ng-annotate-loader works, but ng-annotate can't work with annotated $get method as we see here. I don't know how to make it work for now, sorry.

But it annotates the the constructor() method?

@vlad-dragos yes, because constructor is still a function after convertation. While methods converts into something strange if you see:
/*@ngInject*/

      _createClass(DataSourceServiceProvider, [{
        key: "$get",
//@ngInject comment should be here to make it work
        value: function $get(Restangular) {
          return Restangular.all(self._endpoint);
        }
      }]);

Did a bit of research and the following worked:
export default class DataSourceServiceProvider {
  constructor(endpoint) {
    this._endpoint = endpoint;
  }
  $get(Restangular) {
    "ngInject";
    return Restangular.all(this._endpoint);
  }
};

This marks the $get function for annotation.:
_createClass(DataSourceServiceProvider, [{
	    key: "$get",
	    value: ["Restangular", function $get(Restangular) {
	      "ngInject";
	      return Restangular.all(this._endpoint);
	    }]
	  }]);

Baybe you could add it to the docs or something :)

@vlad-dragos actually this is added to docs of ng-annotate, also /* @ngInject */ comment should work.
I cannot just place all that docs here, ng-annotate-loader is just a connector for webpack)


Add support for bracketed paste

This PR adds support for bracketed paste (#120). I'm not sure if this code has portability issues, but it's at least a starting point which works.

This capability needs to be enabled conditionally as the enable sequences may misbehave on some terminal types.
Is it always right to strip out CRs from pasted text?
This PR demonstrates the functionality needed but is not ready for merge until that first item is addressed.
Sent from my iPhone

On Sep 3, 2016, at 7:27 PM, Zachary Yedidia<EMAIL_ADDRESS>wrote:
This PR adds support for bracketed paste (#120). I'm not sure if this code has portability issues, but it's at least a starting point which works.
You can view, comment on, or merge this pull request online at:
https://github.com/gdamore/tcell/pull/122
Commit Summary
Add support for bracketed paste
File Changes
A paste.go (42)
M tscreen.go (35)
Patch Links:
https://github.com/gdamore/tcell/pull/122.patch
https://github.com/gdamore/tcell/pull/122.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm not sure how to enable it conditionally because I don't know which terminals support and don't support it. The bracketed paste website says it works for xterm and xterm derivatives as well as recent versions of the gnome terminal, iterm2, and terminal.app, but I'm not sure it's possible to detect the terminal emulator.
I'm not sure about the CRs, but it seems like the terminal replaces all \n with \r when pasting.

I really need to think more about how to deal with this elegantly.  I almost wonder if this should be something that could have an API for programs to enable?   Trying to control all this through the terminal description database is getting more and more complicated -- particularly as terminal emulators continue to evolve.  There isn't just a single "xterm", or "screen", or even "gnome-terminal", and newer ones will have capabilities that older ones don't.
A lot of "modern" applications are abandoning the reliance on ncurses and instead just assuming that everyone has the latest and greatest.  That's convenient for the developer, and for the user who does run the latest and greatest, but less so for users who have to run older versions for any reason.

I'm going to close this issue because you can certainly come up with a better implementation.


fix error with pyserial and ignore some errors

Do I need to review this?

Not necessary, i'll push a new PR.


[Network] az network express-route link update: Delete unnecessary transition of enum value

Description

delete unnecessary transition of enum value
https://github.com/Azure/azure-rest-api-specs/issues/7569
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network

Network


Find Supplier JUnit tests

resolves #187
resolves #190

Codecov Report

Merging #191 (bde8d26) into master (7f907c0) will increase coverage by 0.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
+ Coverage     74.63%   74.89%   +0.25%
- Complexity     1262     1267       +5
============================================
  Files           167      167
  Lines          3856     3856
  Branches        513      513
============================================
+ Hits           2878     2888      +10
+ Misses          833      826       -7
+ Partials        145      142       -3

Impacted Files
Coverage Δ

...va/seedu/address/model/person/employee/Leaves.java
83.33% <ø> (ø)

...va/seedu/address/model/person/employee/Salary.java
91.66% <ø> (ø)

...ava/seedu/address/model/person/employee/Shift.java
88.88% <ø> (ø)

...ddress/logic/parser/FindSupplierCommandParser.java
100.00% <0.00%> (+42.85%)
:arrow_up:

...du/address/logic/commands/FindSupplierCommand.java
100.00% <0.00%> (+58.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f907c0...bde8d26. Read the comment docs.

Absolute unit


jCarousel ignores last item on specific markup

For some unknown reason, jCarousel ignores the last item when I output markup [ http://pastebin.com/5LKUypr6 ] through WordPress [counts 7 items instead of 8] yet when I do a static loop to output 10 items, it counts them correctly [ http://pastebin.com/VJhjBz4S ] couldn't find a reasonable reason for that yet I did reproduce it over and over again.

Hard to say without seeing the complete setup. Do have this online where i can see it?

Yep, http://<IP_ADDRESS>/~esekphone
It's in hebrew so don't break your teeth ;-)
jCarousel appears with the pagination numbers on the top-left. you can see it counts 7 yet I have 8  elements.

That was kinda tricky :). The reason is, that your 7th item has a width of 270px, while the other items and the clip element have a width of 271px. So, jCarousel considered the 8th element as part of page 7 since 1 pixel is visible. See also issue #617.
It should be fixed now. Can you try the updated file?

Updated the file, works like a charm!

Great. Thanks for reporting this issue!


Attributes generate values that are region dependent

I am generating TypeScript from our C# classes that include the attributes from C# as comments before the properties and we are having problems with the decimals using the local machine's regional settings for the number instead of a fixed (or defined) format.
Would it be possible to either specify the culture used to convert the values (or globally) or to enable the invariant conversion?
The code I am using to generate the attributes is as follows in the .nt file:
    if property.Attributes | Array.Size > 0
        for attribute in property.Attributes
            for argument in attribute.Arguments }}
    //{{ attribute.Name }}({{ argument }})
            {{- end
        end
    end }}

It generates like this on my machine (decimal separator set to ","):
    //Range(minimum : 0)
    //Range(maximum : 1,79769313486232E+308)

And like this on another machine (decimal separator set to "."):
    //Range(minimum : 0)
    //Range(maximum : 1.79769313486232E+308)

I suspect something further down (possibly in the Scriban layer) is re-translating the string output by NTypeWriter into a localized version.
This works just fine in LINQPad:
object x = double.MaxValue;
Convert.ToString( x, CultureInfo.InvariantCulture ).Dump();
double.MaxValue.ToString( CultureInfo.InvariantCulture ).Dump();

Result:
1.79769313486232E+308
1.79769313486232E+308

But this code in NTypeWriter custom functions:
        public static string GetValueInvariant ( IAttributeArgument attributeArgument )
        {
            return Convert.ToString( attributeArgument.Value, CultureInfo.InvariantCulture );
        }

//{{ attribute.Name }}({{ argument | Custom.GetValueInvariant }})

Returns:
//Range(1,79769313486232E+308)

I have checked and IAttributeArgument.Value unfortunately is also a string, but it will be fixed in the next release and will return original value and not a string representation.


fix: include unset values in recipes when written to folder

The current settings was removing the default values for type and as a result all the values were written to folder as string type.

Pull Request Test Coverage Report for Build 513570788

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.585%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

queenbee/recipe/recipe.py
0
1
0.0%

Totals

Change from base Build 513507727:
0.0%

Covered Lines:
1373

Relevant Lines:
2769

💛  - Coveralls

Pull Request Test Coverage Report for Build 513570788

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 49.585%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

queenbee/recipe/recipe.py
0
1
0.0%

Totals

Change from base Build 513507727:
0.0%

Covered Lines:
1373

Relevant Lines:
2769

💛  - Coveralls


Conf flow

Codecov Report

Merging #3 (5033d84) into master (ff24d1f) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   73.97%   73.22%   -0.76%
==========================================
  Files           6        6
  Lines         292      295       +3
==========================================
  Hits          216      216
- Misses         76       79       +3

Flag
Coverage Δ

unittests
73.22% <0.00%> (-0.76%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

python_rako/__version__.py
0.00% <0.00%> (ø)

python_rako/bridge.py
43.44% <0.00%> (-1.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff24d1f...5033d84. Read the comment docs.

Codecov Report

Merging #3 (5033d84) into master (ff24d1f) will decrease coverage by 0.75%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   73.97%   73.22%   -0.76%
==========================================
  Files           6        6
  Lines         292      295       +3
==========================================
  Hits          216      216
- Misses         76       79       +3

Flag
Coverage Δ

unittests
73.22% <0.00%> (-0.76%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

python_rako/__version__.py
0.00% <0.00%> (ø)

python_rako/bridge.py
43.44% <0.00%> (-1.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff24d1f...5033d84. Read the comment docs.


hugo --watch update results in an endless loop that consumes 100% CPU

$ hugo version
hugo v0.115.3+extended linux/amd64 BuildDate=unknown

$ uname a
Linux srvpun 5.19.1-0-edge4virt #1-Alpine SMP PREEMPT_DYNAMIC Thu, 11 Aug 2022 14:30:40 +0000 x86_64 GNU/Linux

See the title, a hugo —watch update results in an endless loop that consumes 100% CPU. Running debug it prints the following endlessly:
INFO  Received System Events: [WRITE         "/srv/reactionair.nl/assets/jsconfig.json"]

Change detected, rebuilding site.
2023-07-20 15:59:28.888 +0200
DEBUG Rebuild for events ["WRITE         \"/srv/reactionair.nl/assets/jsconfig.json\""]
DEBUG cachebuster: Matching "assets/jsconfig.json" with source "assets/.*\\.(js|ts|jsx|tsx)": match!
DEBUG cachebuster: Matching "assets/jsconfig.json" with source "assets/.*\\.(css|sass|scss)$": no match
DEBUG cachebuster: Matching "assets/jsconfig.json" with source "(postcss|tailwind)\\.config\\.js": no match
DEBUG cachebuster: Matching "assets/jsconfig.json" with source "assets/.*\\.(.*)$": match!
DEBUG Matching "sass/sass/shop/main.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/main.sass" with target "json": no match
DEBUG Matching "sass/sass/dark.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/dark.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "sass/sass/main.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/main.sass" with target "json": no match
DEBUG Matching "sass/sass/main.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/main.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "webp/images/newsletter/closed.webp" with target "(js|scripts|javascript)": no match
DEBUG Matching "webp/images/newsletter/closed.webp" with target "json": no match
DEBUG Matching "sass/sass/desktop.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/desktop.sass" with target "json": no match
DEBUG Matching "sass/sass/desktop.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/desktop.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "webp/images/newsletter/open.webp" with target "(js|scripts|javascript)": no match
DEBUG Matching "webp/images/newsletter/open.webp" with target "json": no match
DEBUG Matching "sass/sass/shop/mobile.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/mobile.sass" with target "json": no match
DEBUG Matching "js/js/main.js_f3a8aadac63c177a73ea5bef07d88dec" with target "(js|scripts|javascript)": match!
DEBUG Matching "webp/images/boekencast/de-zahir.webp" with target "(js|scripts|javascript)": no match
DEBUG Matching "webp/images/boekencast/de-zahir.webp" with target "json": no match
DEBUG Matching "sass/sass/shop/main.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/main.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "sass/sass/shop/mobile.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/mobile.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "sass/sass/light.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/light.sass" with target "json": no match
DEBUG Matching "sass/sass/dark.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/dark.sass" with target "json": no match
DEBUG Matching "sass/sass/mobile.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/mobile.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "js/js/main.js" with target "(js|scripts|javascript)": match!
DEBUG Matching "sass/sass/shop/desktop.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/desktop.sass" with target "json": no match
DEBUG Matching "sass/sass/shop/desktop.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/shop/desktop.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "sass/sass/light.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/light.sass_5c0568ab78ea24c8bd3df4318d414bec" with target "json": no match
DEBUG Matching "sass/sass/mobile.sass" with target "(js|scripts|javascript)": no match
DEBUG Matching "sass/sass/mobile.sass" with target "json": no match
DEBUG Matching "js/js/shop.js" with target "(js|scripts|javascript)": match!
DEBUG Matching "js/js/shop.js_f3a8aadac63c177a73ea5bef07d88dec" with target "(js|scripts|javascript)": match!
INFO  build: running step process duration 6.283247ms
INFO  build: running step assemble duration 273ns
INFO  build: running step render duration 1.383295608s
INFO  build: running step postProcess duration 137.313µs
Total in 1390 ms
INFO  Received System Events: [WRITE         "/srv/reactionair.nl/assets/jsconfig.json"]

Change detected, rebuilding site.
2023-07-20 15:59:30.389 +0200
DEBUG Rebuild for events ["WRITE         \"/srv/reactionair.nl/assets/jsconfig.json\""]
DEBUG cachebuster: Matching "assets/jsconfig.json" with source "assets/.*\\.(js|ts|jsx|tsx)": match!
...

Ran into the same issue for my site using hugo v0.115.3+extended darwin/arm64 BuildDate=unknown
It appeared to be triggered by VSCode constantly touching the files with a git status -z -uall command.

Setting the following setting seems to be a workaround:
[build]
	noJSConfigInAssets = true

VSCode constantly touching the files with a git status -z -uall command.

I have never experienced anything like this with VSCode.
If you keep changing a file that Hugo watches, you will get repeated builds. There are ways to get around the described case above, but this also smells like a defect in VSCode.

For some added context, this is on my VPS, where I am not running an editor such as VSCode. I am running hugo with the flags -w --quiet -s /srv/reactionair.nl and I am running the webserver Caddy, though as far as I know I am not running any kind of file watcher that would interact with or even touch jsconfig.json.


Deadlock with multiple FFTW plan construction / destruction in serial and threaded runs

Running the following code example causes a deadlock conjunction with Julia 1.3.1, DFTK 0.0.5 and FFTW 1.2.0. Stacktrace (after a Ctrl-C) indicates that the deadlock occurs in fftw. Notice, such behaviour is encountered both in serial and threaded runs.
Code example:
using DFTK

function main()
    for Ecut in 0.0 .+ collect(3:20)
        println("Ecut = $Ecut")
        a = 10.263141334305942
        lattice = a / 2 .* [[0 1 1.]; [1 0 1.]; [1 1 0.]]
        model = Model(lattice; terms=[Kinetic()], n_electrons=4)
        basis = PlaneWaveBasis(model, Ecut)
    end
end

main()

Output / Stacktrace: https://gist.github.com/mfherbst/4015ff891001597fccf66648abff1aa1
Sorry about the complicated reproducer btw ... I tried to reduce as much as I could.

Note: The issue also present on master as of now.

Could be related to #135.

The issue disappears when setting explicitly FFTW.set_num_threads(1).

@vtjnash, any ideas?   FFTW has an internal pthreads mutex lock around plan creation and destruction, but I don't see how that could deadlock Julia…

I think I'm seeing the same issue. Here is a reduced toy case.```
using FFTW
import Base: *
struct rFFT{nᵢ} end
@generated function plan(::Type{F}) where {nᵢ, F<:rFFT{nᵢ}}
X  = zeros(Float64, nᵢ...)
FT = plan_rfft(X; flags=FFTW.MEASURE, timelimit=10)
return :( $FT )
end
nᵢ = (256, 50)
FT = rFFT{nᵢ}
matx = rand(Float64, nᵢ...)
plan(FT) * matx

The last line hangs with no CPU activity coming from Julia. If, however, I replace the
last line with the following two lines

*(::Type{FT}, x::Array) where FT<:rFFT = plan(FT) * x
FT * matx

then I get this segfault.

julia> FT * matx
signal (11): Segmentation fault: 11
in expression starting at REPL[9]:1
spawn_apply at /Users/ethananderes/.julia/artifacts/686f343230e1853cc948cd0736b57067c66bca4b/lib/libfftw3.3.dylib (unknown line)
#1 at ./threadingconstructs.jl:126
unknown function (ip: 0x115f16cf4)
jl_apply at /Users/ethananderes/Software/juliaMaster/src/./julia.h:1685 [inlined]
start_task at /Users/ethananderes/Software/juliaMaster/src/task.c:687
Allocations: 7684063 (Pool: 7682495; Big: 1568); GC: 7
zsh: segmentation fault  /Users/ethananderes/Software/juliaMaster/julia -O3

I tried to track down the issue further but I hit my limit of understanding. Hope
this helps.

julia> versioninfo()
Julia Version 1.5.0-DEV.513
Commit 5ecc17f0e0 (2020-03-26 20:16 UTC)
Platform Info:
OS: macOS (x86_64-apple-darwin19.4.0)
CPU: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-9.0.1 (ORCJIT, skylake)
Environment:
JULIA_NUM_THREADS = 4
JULIA_FFTW_PROVIDER = FFTW

I can reproduce your first example on Julia 1.4 and FFTW 1.2.0, but I do not get a segfault in your second example, only a hanging Julia process again.
As before a FFTW.set_num_threads(1) makes the code run through smoothly.

Note: to get the seg fault I need to use a fresh session and not
evaluate plan(FT) * matx first.
using FFTW
import Base: *
struct rFFT{nᵢ} end
@generated function plan(::Type{F}) where {nᵢ, F<:rFFT{nᵢ}}
    X  = zeros(Float64, nᵢ...)
    FT = plan_rfft(X; flags=FFTW.MEASURE, timelimit=10)
    return :( $FT )
end
nᵢ = (256, 50)
FT = rFFT{nᵢ}
matx = rand(Float64, nᵢ...)
*(::Type{FT}, x::Array) where FT<:rFFT = plan(FT) * x
FT * matx

on Julia v1.4.0 I don't get as much readout from the segfault:
julia> FT * matx
zsh: segmentation fault  /Users/ethananderes/Software/julia1.4/julia -O3

Perhaps I should also remark that by using a generated function for plan
I'm trying to memoize it for quick instantiation inside other functions.
If anyone knows of a non-segfault way to get around this I'd love to hear it.

Attempting to access FFTW inside @generated should be obviously invalid by the documentation for what is okay. If you want memoization, you should be writing your own, not trying to cause undefined behavior in the compiler. I suspect it should be trying to print that out as an error message, but I'm not certain why that fails.

@stevengj It looks like it's possibly trying to recursively hold the lock, since it's in the middle of one plan and trying to finalize a different one. I'd like to move all finalizers to a separate thread to solve this issue, but that's it's rather far away on my roadmap right now. For now, I recommend only doing trivial things in a finalizer, like appending it to a queue to be cleaned up later.

FFTW inside @generated  should be obviously invalid by the documentation for what is okay.

I guess your referring to FFTW documentation that ftt plans have global mutable state?
So that if, instead, they just where regular structs which held information on which
fft method to apply then it would be fine?
Anyway, these generated functions for caching fft plans have been working flawlessly for me
for a number of years now and only started giving me problems with the new threading stuff.
(see here for example)

Has anyone found a workaround other than setting set_num_threads(1)? I'm guessing not, but thought I'd check given the performance hit

@vtjnash if it's insightful at all, commenting out the finalizer here doesn't seem to change the seg fault
https://github.com/JuliaMath/FFTW.jl/blob/0745fe29921d35b815d64038598b33afa564e486/src/fft.jl#L244

Ok, commenting out the finalizer fixes @mfherbst's main example with threaded FFTW

This issue should be fixed by #160.

Great, thanks for the fix! Can't reproduce the original issue anymore on FFTW 1.2.2. I don't think we changed anything in DFTK in that respect, so the only difference seems to be that I'm running julia 1.5.

@stevengj @vtjnash Thanks for the update and your effort on this stuff!


Tracking issue for normalizing prototype objects properly in CheckAccessControls

(Note: this issue is purely for tracking/documentation purposes. I already have a fix locally.)
Suppose we have SubFoo extending Foo, so that SubFoo.prototype is an instance of Foo. We make a distinction between the particular instance of Foo that is SubFoo.prototype and a standard, canonical instance of Foo. We are currently confounding the two in the NTI case in CheckAccessControls::normalizeClassType, leading to spurious warnings in at least one place already.
Consider the following test case (eliding goog.provides and requires for clarity).

a.js:

/** @constructor */
var A = function() {}
/** @protected */
A.prototype.method = function() {}

b1.js:

/** @constructor @extends {A} */
var B1 = function() {}
/** @protected */
B1.prototype.method = function() {}

b2.js:

/** @constructor @extends {A} */
var B2 = function() {}
/** @protected */
B2.prototype.method = function() {}

c.js:

/**
 * @param {!B1} b1
 * @constructor
 * @extends {B2}
 */
var C = function(b1) {
  var x = b1.method();
}

When run with NTI, this yields a spurious "Access to protected property method of B1 not allowed here" CheckAccessControls warning.
Now what follows in the comments is a very concrete description of why this is happening and how my fix addresses it.

What is happening:

When analyzing the getprop b1.method(), we look up the superclass of B1 that most recently overrode method -- or rather, we look for that superclass's prototype. This happens in AccessControlUtils::getObjectType.
Specifically, we do this by ascending the prototype chain of B1 until we find the prototype that first defines method. So we end up getting, in this case, B1.prototype.
B1.prototype is a very specific instance of A. Specifically, in NTI it has type A{method:function(this:B1):?}, whereas the canonical instance of A is just A.
To check if the protected property access is OK, we normalize the owner type, i.e. B1.prototype to its corresponding instance type, i.e. A [*, see caveat], and then check if the current class from which we are performing this property access, which is C, is a subtype of A.
What was happening was that in the NTI case this normalization was not actually occurring. So instead of checking for C <: A, we were checking C <: A{method:function(this:B1):?}. But this is actually false, since in C method has type function(this:B2):? and not function(this:B1):? (with B1, B2 having no subtype relationship).

In the OTI case, the isPrototypeObject codepath in CheckAccessControls::normalizeClassType does the normalization.
In the NTI case, isPrototypeObject is a stub that always returns false, so the normalization wasn't happening.

My fix addresses this by adding a normalizeMaybePrototypeObject API to ObjectTypeI that does this normalization more properly in both NTI and OTI. The NTI implementation is essentially just getConstructor().getInstance(), which does the trick.

(*) Caveat:

Unfortunately the notion of "corresponding instance type" is not quite what I said above. For SubFoo.prototype it is SubFoo itself, not Foo.
This is not actually as big of a deal as it may seem for subtyping purposes.
The contract of normalizeMaybePrototypeObject is precisely to return this "corresponding instance type".

In OTI we are able to do this successfully using getOwnerFunction, which for SubFoo.prototype returns the constructor for SubFoo. So the implementation is just getOwnerFunction().getInstance(), and we meet the contract.
However in NTI we do not have a getOwnerFunction equivalent, since we do not store the "constructor" property on prototype objects. (This is a known issue, intended to be fixed.) So we have to make do by using getConstructor instead, which for SubFoo.prototype returns the constructor of Foo (not SubFoo). So the implementation is getConstructor().getInstance() which actually fails to meet the contract, returning Foo instead of SubFoo for SubFoo.prototype.

From a subtyping point of view this means we are slightly more liberal in NTI. (Since Bar <: SubFoo => Bar <: Foo.)
All things considered, this is not a huge caveat, since test cases that are affected by this fine difference are not too common in practice. The current fix is certainly an improvement on the state of affairs, and this caveat can be addressed later once we implement the "constructor" property.

I wanted to note another wrinkle that makes this business still more complicated: because of the way getOwnProp works in NTI (different from its behavior in OTI), the caveat noted above actually becomes necessary for the two to have the same behavior.
Specifically, getOwnProp in NTI considers properties on the prototype (of an object type) to be own props, whereas OTI does not. [Note: when I say getOwnProp I am referring to getOwnPropertyDefSite and the like in ObjectTypeI.]
Now, getOwnProp is used by AccessControlUtils::getObjectType, which (essentially) ascends the prototype chain until it finds the first type that defines the required property as an own prop, and returns that type. Because NTI considers prototype properties to be own props as well, it finds the first type earlier than OTI does.
To be concrete, consider the inheritance chain of C -> B2 -> A in the example. Suppose we do getObjectType(C, "method"), where C refers to the C instance type. Then this is what happens in OTI:

Is "method" an own prop of C? No.
Ascend the prototype chain, look at C.prototype (which is a particular instance of B2).
Is "method" an own prop of C.prototype? No.
Ascend the prototype chain, look at B2. [This is a bit weird in OTI: calling getPrototypeObject on C.prototype returns B2, when ostensibly it should be B2.prototype, seeing as C.prototype is after all a specific instance of B2. Ends up not making a difference in this case, though.]
Is "method" an own prop of B2? No.
Ascend the prototype chain, look at B2.prototype.
Is "method" an own prop of B2.prototype? No.
Ascend the prototype chain, look at A.
Is "method" an own prop of A? No. (Since we don't look at prototype properties.)
Ascend the prototype chain, look at A.prototype.
Is "method" an own prop of A.prototype? Yes!
Return A.prototype.
And then later on, this A.prototype is normalized "down" to A (i.e. the A instance type), and that is what the ownerType ends up being in CheckAccessControls::checkNonOverriddenPropertyVisibility.

In NTI, however, this is what happens instead:

Is "method" an own prop of C? No. (Since it is defined neither in C nor C.prototype.)
Ascend the prototype chain, look at C.prototype, i.e. a particular instance of B2.
Is "method" an own prop of C.prototype? No. (Since it is defined neither in B2 nor B2.prototype.)
Ascend the prototype chain, look at B2.prototype, i.e. a particular instance of A. [Note that getPrototypeObject in NTI is more sane: calling it on C.prototype returns B2.prototype, which makes sense.]
Is "method" an own prop of B2.prototype? Yes, actually. This is because B2.prototype is a special instance of A, and since we look in prototype properties as well, we find "method" as an own prop of A.prototype.
Return B2.prototype.
This then later gets normalized "up" (as opposed to "down", in keeping with the caveat) again to A, and so again ownerType ends up being A, and all is well. If not for the caveat, i.e. we managed to normalize "down" to B2, we'd get the wrong behavior.

I think it's fair to say that getOwnProp is not doing the right thing in NTI, since "own" properties are perfectly well-defined and they do not include properties on the prototype, instead being only the properties defined "directly" on a given object. See e.g. Object.prototype.getOwnPropertyNames as present in the standard.
So what's the fix here? Well,getOwnProp in NTI should be fixed not to look at prototype properties. Of course, the situation isn't quite as simple as that. getOwnProp is already defined in RawNominalType and called in a bunch of places, and I don't believe it will be too easy to change, since it seems that several callers already implicitly rely on this behavior (i.e. expect protoProps to be included). But we should at least change the getOwnProp methods in FunctionTypeI to be correct, say by making them eventually call a new method getOwnPropNoProto (or whatever) in RawNominalType, which would be the same as getOwnProp except it doesn't look at protoProps. This will fix the behavior of compiler passes that call it, such as CheckAccessControls.
This in itself is easy to do, but we can't do it straightaway -- because of the caveat of normalizeMaybePrototypeObject. If we fix only the caveat or only getOwnProp then we will get the wrong behavior (as explained in the example). So we have to wait until we can fix both and land both together. And the blocker there (of the two) is the caveat, since that's the one that isn't obvious.

FWIW, I actually think the caveat might not be so hard to fix. It should suffice to simply add an owner field to ObjectType that is null for everyone except prototype objects, for whom it points instead to their owner constructor. This is enough to allow us to implement getOwnerFunction right.

cc @dimvar @blickly. Sorry for the huge wall of text here, I just wanted to be as clear as I possibly could. Note that I'd be happy to open a PR to land the fixes for this issue (both for the normalizeMaybePrototypeObject/getOwnerFunction caveat as well as the getOwnProp business (hopefully no hidden issues emerge even after those fixes!). I just wanted to ensure we were all on the same page first.

I'm looking at this today, and it seems that for the example in your first comment, Java has the same behavior as NTI. It warns for b1.method(); in C.


Changed version number

Changed version number only.
var bbdVersion = "0.2.4";
var bbdVersion = "0.3.1";
No need for a new release because of this change.

Uhh what? No I'm not going to arbitrarily increase that version number to match the installer version number that doesn't make sense.


Q: Your recommendation where to keep configuration for different environments?

Thanks for sharing your great sample application and your ideas on best practices using Spark. I am wondering what would be your tipp when it comes to providing configuration to the application (say database connection strings, or template engine behavior)?
I am looking for something where you can store the configuration file under version control ie. something lightweight like Confucius (https://github.com/IvanTrendafilov/Confucius) in addition to JOpt Simple for passwords to be not visible in git...

I just use standard .properties files, so localhost.properties, staging.properties, and production.properties. For parsing command line arguments I usually use args4j.

Thanks, David.  Even if it seems trivial it might be worth for covering in docs/tutorial/sample to give users a quick idea on how config aspects fit into spark?

That's a good idea, thanks, I won't do a separate tutorial, but I might add it to this one when I have the time!


key binding

Is there a way to setup a key or button binding to toggle the FSKneepad display. I have a button mapped to toggle the default MSFS VFR map, which is very handy in VR, and I would like to be able to do the same for this.
Thank you.

Thanks a bunch for the great suggestion.
In fact, you aren't the first to bring this up (but the first one publicly posting this as an issue, so thanks a lot!) and it's definitely on my roadmap.
I'll leave the issue open to avoid duplicates until it is implemented, if feasible!

done and implemented as experimental feature. please provide feedback when released!


Feature Request: Switching route with its children by using naming routes

For example:
routes: [
  { path: '/playground', name: 'playground', component: Playground },
  { path: '/dormitory', name: 'dormitory', redirect: 'Dormitory',
    children: [
      {path: 'g/:id', name: 'girl-dorm', component: GirlDormitory },
      {path: 'b/:id', name: 'boy-dorm', component: BoyDormitory },
    ]
  }
]

First I switched to '/dormitory/b/123' then I switched to '/playground' by name 'playground'. I expect to switch back to '/dormitory/b/123' by just link to naming route 'dormitory'.
For this purpose, a solution is recording the last route path of each top route:
const RouteStackTop = {
  playground: '',
  dormitory: '',
}

const redirectTo = (routeName) => {
  return (dest, src, next) => {
    if (RouteStackTop[routeName] === dest.path) return next()
    RouteStackTop[routeName] = RouteStackTop[routeName] || dest.path
    return next(RouteStackTop[routeName])
  }
}

const routes = [
  {
    path: '/playground', name: 'playground', component: Playground,
    beforeEnter: redirectTo('playground')
  },
  {
    path: '/dormitory', name: 'dormitory', redirect: 'Dormitory',
    beforeEnter: redirectTo('dormitory'),  // redirect to /dormitory/b/123
    children: [
      {path: 'g/:id', name: 'girl-dorm', component: GirlDormitory },
      {path: 'b/:id', name: 'boy-dorm', component: BoyDormitory },
    ]
  }
]

When we simulate a iOS app with tabbar, it is a common situation that bottom tabbar-item link to '/favorites', '/recents', '/contacts', '/keypad', when we first switch to '/recents/missed' then switch to '/favorites', if we next touch 'recents', the app will show the 'missed' page, not the 'all' page. We can also be redirected to '/contacts/jhon' if the the path of last view of 'contacts' is '/contacts/jhon'
The route tree looks like:
/favorites
/recents
    /all
    /missed
/contacts
    /:name
/keypad

I may not be getting what you mean because the explanation of the problem being solved is simply too short but we cannot make that because a { name: 'dormitory' } is meant to go to the dormitory route. If we implicitly keep previous parameters, that'd lead to unpredictable behaviour as well as a breaking change

In that case, you should save those parameters in a global state upon entering the route, and reuse them when necessary.


I can not find shortcut on spotlight and shortcuts app

Take a look at the 'requirement' section of the readme - have you modified xcode-select to point to the Xcode beta? It's a known issue on dev beta 1.
After doing that, you may need to clear dervived data/clean build/restart if it's still not showing.

Hmm, I still can't get it to work on Beta 4. I've ran xcode-select, cleaned build, restarted laptop and test device, still no dice.

Turns out the shortcuts are there, but you have to add them manually in the shortcuts app, which is not expected based on the WWDC presentation.


Fix master validation, incorrect detection of dup ExecutorID.

@jpeach it looks like you were in here recently, what are your thoughts on this?

@jdef Good find! Can you please make a JIRA for this?

https://issues.apache.org/jira/browse/MESOS-8169

We should also update here https://github.com/apache/mesos/blob/master/src/master/master.hpp#L2665-L2667
and maybe in other places, where master/agent checks for duplicate executor ids.

Should we also update comment https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L78-L82 ?

@abudnik the master.hpp code you cited is already scoped to Framework. I don't think we need to change anything there.

If some framework relies on the assumption that there shouldn't be multiple executors running with the same executor_id on the same agent, then this change might lead to bugs.
It would be great to post an email into dev/user-lists regarding this change.


CI Update

Build.Reason:Manual by Alma Jenks
Build.Url:https://apidrop.visualstudio.com/Content CI/_build/results?buildId=319154&view=results
source_repo.branch:master
source_repo.csvPath:bundlepackages/aspnetcore
source_repo.url:https://apidrop.visualstudio.com/binaries/_git/mrefconfig

Docs Build status updates of commit ce51fa6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

aspnet-core/xml/Microsoft.AspNetCore.Authentication/PropertiesSerializer.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Authentication/TicketSerializer.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ModelBinding/JQueryFormValueProvider.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ViewFeatures/HtmlHelperOptions.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewDataDictionary.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Razor.Parser/CSharpLanguageCharacteristics.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Razor.TagHelpers/NullHtmlEncoder.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.Extensions.DependencyInjection/HttpJsonServiceExtensions.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.Owin.Security.Interop/AspNetTicketSerializer.xml
:warning:Warning
View
Details

aspnet-core/xml/Microsoft.AspNetCore.HttpLogging/HttpLoggingFields.xml
:bulb:Suggestion
View
Details

[aspnet-core/xml/Microsoft.AspNetCore.Identity.EntityFrameworkCore/UserStore9.xml](https://github.com/dotnet/AspNetApiDocs/blob/smoke-test/aspnet-core/xml/Microsoft.AspNetCore.Identity.EntityFrameworkCore/UserStore9.xml)
:bulb:Suggestion
View
Details

aspnet-core/xml/Microsoft.AspNetCore.Identity/IdentityBuilder.xml
:bulb:Suggestion
View
Details

aspnet-core/xml/Microsoft.AspNetCore.OutputCaching/CacheVaryByRules.xml
:bulb:Suggestion
View
Details

aspnet-core/xml/Microsoft.AspNetCore.OutputCaching/OutputCacheAttribute.xml
:bulb:Suggestion
View
Details

aspnet-core/xml/Microsoft.AspNetCore.RateLimiting/RateLimiterOptionsExtensions.xml
:bulb:Suggestion
View
Details

aspnet-core/xml/Microsoft.Net.Http.Headers/EntityTagHeaderValue.xml
:bulb:Suggestion
View
Details

aspnet-core/xml/System.Threading.RateLimiting/MetadataName`1.xml
:bulb:Suggestion
View
Details

[aspnet-core/xml/System.Threading.RateLimiting/PartitionedRateLimiter1.xml](https://github.com/dotnet/AspNetApiDocs/blob/smoke-test/aspnet-core/xml/System.Threading.RateLimiting/PartitionedRateLimiter1.xml)
:bulb:Suggestion
View
Details

aspnet-core/xml/FrameworksIndex/aspnetcore-7.0.xml
:white_check_mark:Succeeded

aspnet-core/xml/Microsoft.AspNetCore.Authentication.Cookies/ChunkingCookieManager.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/Microsoft.AspNetCore.Authentication/IAuthenticationConfigurationProvider.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/Microsoft.AspNetCore.Authorization/AuthorizationMiddleware.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/Microsoft.AspNetCore.Authorization/DefaultAuthorizationPolicyProvider.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/Microsoft.AspNetCore.Authorization/IAuthorizationPolicyProvider.xml
:white_check_mark:Succeeded
View

aspnet-core/xml/Microsoft.AspNetCore.Builder/ApplicationBuilder.xml
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.

aspnet-core/xml/Microsoft.AspNetCore.Authentication/PropertiesSerializer.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Read(System.IO.BinaryReader)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Read(System.IO.BinaryReader)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Write(System.IO.BinaryWriter,Microsoft.AspNetCore.Authentication.AuthenticationProperties)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Write(System.IO.BinaryWriter,Microsoft.AspNetCore.Authentication.AuthenticationProperties)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Read(System.IO.BinaryReader) for uid: Microsoft.AspNetCore.Authentication.PropertiesSerializer.Read(System.IO.BinaryReader).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Write(System.IO.BinaryWriter,Microsoft.AspNetCore.Authentication.AuthenticationProperties) for uid: Microsoft.AspNetCore.Authentication.PropertiesSerializer.Write(System.IO.BinaryWriter,Microsoft.AspNetCore.Authentication.AuthenticationProperties).

aspnet-core/xml/Microsoft.AspNetCore.Authentication/TicketSerializer.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.WriteClaim(System.IO.BinaryWriter,System.Security.Claims.Claim)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.WriteClaim(System.IO.BinaryWriter,System.Security.Claims.Claim)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:WriteClaim(System.IO.BinaryWriter,System.Security.Claims.Claim) for uid: Microsoft.AspNetCore.Authentication.TicketSerializer.WriteClaim(System.IO.BinaryWriter,System.Security.Claims.Claim).

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ModelBinding/JQueryFormValueProvider.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.AspNetCore.Mvc.Internal.PrefixContainer'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.PrefixContainer'.

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ViewFeatures/HtmlHelperOptions.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.AspNetCore.Mvc.Rendering.Html5DateRenderingMode.#ctor'.

aspnet-core/xml/Microsoft.AspNetCore.Mvc.ViewFeatures/ViewDataDictionary.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.TryGetValue(System.String,System.Object@)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.TryGetValue(System.String,System.Object@)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:TryGetValue(System.String,System.Object@) for uid: Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataDictionary.TryGetValue(System.String,System.Object@).

aspnet-core/xml/Microsoft.AspNetCore.Razor.Parser/CSharpLanguageCharacteristics.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.AspNetCore.Razor.Tokenizer.Internal.CSharpTokenizer'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.AspNetCore.Razor.Tokenizer.Internal.CSharpTokenizer'.

aspnet-core/xml/Microsoft.AspNetCore.Razor.TagHelpers/NullHtmlEncoder.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.FindFirstCharacterToEncode(System.Char*,System.Int32)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.IO.TextWriter,System.Char[],System.Int32,System.Int32)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.IO.TextWriter,System.String,System.Int32,System.Int32)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.IO.TextWriter,System.Char[],System.Int32,System.Int32)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.Encode(System.IO.TextWriter,System.String,System.Int32,System.Int32)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Text.Encodings.Web.HtmlEncoder.FindFirstCharacterToEncode(System.Char*,System.Int32)'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Key Vault] Add support for Key Rotation

To support KeyVault Key Rotation, implement the following changes (modeled from JS, but use whatever API is idiomatic for your language):
ARM Template changes
When creating a keyvault, add rotate to the keys' accessPolicies so that your test application has permissions to rotate and set the rotation policy.
Key Client API
getKeyRotationPolicy(name: string, options?: GetKeyRotationPolicyOptions): Promise<KeyRotationPolicy | undefined>; // see (1) below
rotateKey(name: string, options?: RotateKeyOptions): Promise<KeyVaultKey>;
updateKeyRotationPolicy(name: string, policy: KeyRotationPolicyProperties, options?: UpdateKeyRotationPolicyOptions): Promise<KeyRotationPolicy>;

Note that policy behavior is against the latest version of a key.
New models
// @public
export interface KeyRotationLifetimeAction {
    action: KeyRotationPolicyAction;
    timeAfterCreate?: string; // see (2) below
    timeBeforeExpiry?: string;  // see (2) below
}

// @public
export interface KeyRotationPolicy extends KeyRotationPolicyProperties {
    readonly createdOn: Date;
    readonly id: string;
    readonly updatedOn?: Date;
}

// @public
export type KeyRotationPolicyAction = "Rotate" | "Notify";

// @public
export interface KeyRotationPolicyProperties { // see (3) below
    expiresIn?: string;  // see (2) below
    lifetimeActions?: KeyRotationLifetimeAction[];
}

Swagger inconsistencies to be mindful of
The swagger defines the possible values for LifetimeActionsType as an enum consisting of rotate and notify but in reality it returns Rotate and Notify  - the service accepts both casing, is case-insensitive, but in order to model the correct values here we went with the following swagger transformation:
directive:
  - from: swagger-document
    where: $.definitions.LifetimeActionsType.properties["type"]["x-ms-enum"]
    transform: >
      $.values[0].value = "Rotate";
      $.values[1].value = "Notify";

Notes

Calling GET /keys/{name}/rotationpolicy will return an object with all properties set to null. We're discussing having that endpoint 404, but until then I am return undefined if the id doesn't exist
We're still discussing whether the swagger should model this as an ISO8601 duration. In JS, the architects prefer a string, but model this duration in whatever way is idiomatic (TimeSpan, etc). If the swagger changes, I'll update the feature crew
In order to properly model input / output values I separated out the KeyRotationPolicy and the KeyRotationPolicyProperties . The former extends the latter and adds the server-side attributes (timestamps and ID).

FYI here are the JS PRs for your reference:

implementation
sample


fullscreenPseudo map option

I need only pseudo-fullscreen for map
add special map boolean option for this "fullscreenPseudo"

merge pull request ?

Thanks, merged with some slight alterations in 0d1ea096869b11354e1cf730607b87fe563813a0.


use optional chaining

just remove if (effectsToAdd) {} and use effectsToAdd?.
seemingly diff have mistake

ts-jest doesn't like optional chaining

We avoid >ES2015 syntax in the codebase.


to redmine 3.4 - upgrade - any plans?

I use that docker so I'll be very thankfull.

@sameersbn  - Is there a plan when upgrade to Redmine 3.4.2? Thanks

I haven't seen @sameersbn comment on any issues for this project in quite some time.  From his history it seems he may have moved on to bitnami based docker images which includes the https://github.com/sameersbn/bitnami-docker-redmine image. Which does appear to have a 3.4.2 redmine release.  I'm not sure what the big differences between these images are.

Hi. Sorry for the delay.
I've merged a couple of pull requests and released a bunch of new tags.
Thanks for your patience.

Still no 3.4 in the pipe ?

@Glideh https://github.com/sameersbn/docker-redmine/issues/315


Code action test should wait for diagnostics.

The code action test currently opens the file but does not collect diagnostics.

The code actions tests should get diagnostics similar to this:
https://github.com/microsoft/vscode-flake8/blob/8f07415e37384de4b0884da45c824df18737200f/src/test/python_tests/test_linting.py#L28-L49

Hi, I'm Jessie! can I work on this issue?

I'm Melissa! I would like to work on this issue with her


[Binance] Fixed mapping of binance trade "isBuyerMaker" to ASK/BID order types (reversed it...)

This PR reverses the trade type mapping for Binance market...
I have cross checked a few other markets, how they map trade side reported by exchange to XChange OrderType.BID/ASK.
The mapping seems to be:

BUY from exchange → OrderType.BID
SELL from exchange → OrderType.ASK

However Binance doesn’t report BUY/SELL information, just the boolean flag if the buyer was the market maker.
I had good feeling that the trade type should be from the taker perspective. It is the taker, who initiates the trade. My understanding has been confirmed at last here:
https://money.stackexchange.com/a/102005
But I really wonder, why nobody detected this issue earlier. It is quite major, to reverse the trade side… I hope I misunderstood something, and this PR is not necessary;)

Closed the PR, maybe the source I have found was wrong... will test it more deeply.


Is it possible to have more than one swagger paths?

Hi,
I have an aspnet core api running with multiple versions and swashbuckle swagger gen/ui. In the future I will have internal and external consumers of my api. Authentication and the permissions work perfect, but somehow I dont like the fact that the swagger documentation shows internal api-methods like portal admin functions.
Is it somehow possible to generate an f.e. intern and an extern swagger json (set via attributes)? for example: https://.../swagger/v0.1/swagger.json and  https://.../swagger/intern/v0.1/swagger.json automatically?
thank you and all the best :)
Thomas

If this is the wrong place for this question (aspnet core...) sorry! :(


Paniced with Pen tablet Input

Bevy version
0.4.0
What you did
Input with a pen tablet in examples/input/touch_input_event.rs
What you expected to happen
It works.
What actually happened
It paniced if the value of "force" is None.
Additional information
Ad hoc : crates/bevy_input/src/touch.rs#L190
fn process_touch_event(&mut self, event: &TouchInput) {
    if event.force.is_none() {
        return;
    }
    ...
}

👋
Would you have the line where it panicked? With a quick read of the code, I didn't find where that could happen

I should have written it here, sorry.
thread 'Compute Task Pool (3)' panicked at 'called `Option::unwrap()` on a `None` value', crates\bevy_input\src\touch.rs:197:74

It panicked when the pen is in midair.


window.gapi.auth2.getAuthInstance() is empty on IOS 14.2

setup login page
this.auth2 = window.gapi.auth2
.init({
client_id: process.env.GOOGLE_ID,
ux_mode: 'redirect',
redirect_uri: process.env.GOOGLE_LOGIN_REDIRECT, // https://domain/callback
scope: 'profile email',
prompt: 'select_account',
})
.then(() => {
let googleAuth = window.gapi.auth2.getAuthInstance();
googleAuth.signIn()
});
in callback page
window.gapi.auth2.getAuthInstance().currentUser.get().getAuthResponse()  is empty only in IOS 14.2 but another  version is work and android is work also.

Same for me. Trying to get user after successful redirect, but its empty

Same for me. Trying to get user after successful redirect, but its empty


Phrasing tweak in the documentation

As currently phrased, the "finally" part of the common steps in the installation section can be a bit confusing, as it may look like it tells you that the first step is to do something in a virtual environment, which is confusing if you're not using one, as instead of reading further and noticing it has instructions for other environments, you want instead go back to read earlier steps to figure out if you missed something that asked you to set up one.
Rephrase to make it more obvious that this subsection is a list of alternatives rather than a series of steps.

Fixed conflicts and committed in https://github.com/tabatkins/bikeshed/commit/f7860c06eaec18afc415bf3f4a7b90aee58ca680, thanks!


Use active viewport hook fix

Update to get activeViewport by monitoring ContentViewManager.onActiveContentChangedEvent. This eliminates issue where ViewManager active view change messages are commonly emitted before all UI components have been mounted.

@mergifyio backport release/2.14.x

@mergifyio backport release/2.15.x

/azp run


Update Matplotlib formatters/tickers

I find myself referring to https://jakevdp.github.io/PythonDataScienceHandbook/04.10-customizing-ticks.html#Summary-of-Formatters-and-Locators all the time to find the correct matplotlib locators/formatter.
I only recently realized that there are more maplotlib [locators] and [formatters], including StrMethodFormatter and EngFormatter. It'd be nice if these could be included.

Thanks for the notes. I don't have any available cycles to update the data science handbook at the moment.

1

1

@jakevdp Would this help with the spaming?

@jakevdp Would this help with the spaming?


Create calc-stats Command Structure

Implement the basic structure for the calc-stats command in the CLI tool without any functionality. This will serve as the foundation for adding logic to calculate stats.
Tasks:

Create a new calc-stats command in the subcommands package.
Add a --repository flag to accept the repository in owner/repo format.
Ensure the command can be invoked without errors.

Completed


HeaderDictionaryTypeExtensions typing issue

Just wondering, why does HeaderDictionaryTypeExtensions.GetTypedHeaders(...) force HttpRequest and HttpResponse when RequestHeaders (which GetTypedHeaders creates) only requires a IHeaderDictionary? This is proving to be a pain point since HttpRequest.Headers/HttpResponse.Headers are of type IHeaderDictionary, this means that I have I have to explicitly cast the result from HttpRequest.Headers to RequestHeaders, which makes using the extension method a real pain.
The only reason why I can see why this might have been done is to avoid someone passing in Request headers where they should have passed in Response headers, but since the user has to cast, it doesn't really avoid that issue - maybe it could be argued you get an exception rather than the wrong results, but if this really is a worry, casting doesn't seem like the answer either.

I don't follow. httpRequest.GetTypedHeaders() and httpRequest.Headers provide different views into the headers. There shouldn't be any casting between the two types.
Can you provide some sample code showing your issue with the current APIs and another showing how you'd like to use it?

Sorry for not being 100% clear. But the following should show it:
// This would be my expectation, but it can't work because `Header` is of type `IHeaderDictionary` and `GetTypedHeaders` is needs it to be of type `RequestHeaders `
var request = ...;
var typedHeaders = request.Header.GetTypedHeaders();

So to work, one would need to do:
// This is what is needed to make it work and is really annoying to work with
var request = ...;
var typedHeaders = ((RequestHeaders)request.Header).GetTypedHeaders();

Why not just request.GetTypedHeaders()?
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http.Extensions/HeaderDictionaryTypeExtensions.cs#L15
I don't see an overload that will even make your second example compile.

Sorry my fault. For some reason when I was looking at that I kept thinking that the type that extension method wanted was RequestHeaders hence needing to cast. Sorry for the mistake!


jupyter_client, nbformat, notebook: fix on python2

Motivation for this change
jupyter_client dropped python2 support and apparently there were some mixups at the recent python packages update.
CC @FRidh
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hopefully I'll be able to update sage to python3 soon so that I can stop caring about these things.

Thank you. I thought my branch with changes was mostly finished, but this seemed to break more than I thought.

seems like I forgot to specify again explicitly default.nix when running my updater...

Still would like to have a way to describe version or update bounds in an expression, so an evaluation error would occur.


DatePicker set value

I have gone through these following points

[x] Check latest documentation: https://docs.nativebase.io/
[x] Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[x] Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
[x] Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[x] For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[x] For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description

node, npm, react-native, react and native-base version, expo version if used, xcode version
native-base: 2.13.8
react-native: 0.60.6
react: 16.8.6
Latest node and npm
Expected behaviour
I want to be able to set the value of the DatePicker to a state variable, as in the other components including the normal Picker
Actual behaviour
No way to set a value
Steps to reproduce

Is the bug present in both iOS and Android or in any one of them?
Any other additional info which would help us debug the issue quicker.
Would be really useful for this filter I'm busy with, one could reset the filters and it would reset the date that one selected to null. No way to do that programmatically at the moment.

Hi @19007361 I have added a commit. This should solve your problem

Thank you, I was using https://github.com/xgfe/react-native-datepicker which gave me the functionality I needed, but now I will try this one.

@prajjawal05 Is this gonna make it to master? I'm struggling with this issue also

Any result here, is this in master?

Not yet @dwaynelavon @dl-husky73 I am not sure who to tag to approve this.

im having the same problem with this, the default value of the date picker doesn't change.. I am new to react native.. here is my code..
const [appointmentDate, setAppointmentDate] = React.useState(new Date())

React.useEffect(() => {
		if (route.params) {
			const appointment = route.params.appointment
			const appointment_date = moment(appointment.appointment_date)

			setTitle('Edit Appointment')
			setAppointmentDate(appointment_date)
		}
	},[])

then my date picker is
<DatePicker
 defaultDate={appointmentDate}
 locale={"en"}
 timeZoneOffsetInMinutes={undefined}
 modalTransparent={false}
 animationType={"fade"}
 androidMode={"default"}
 textStyle={{ color: 'black' }}
 placeHolderTextStyle={{ color: 'black' }}
 placeHolderText="wew"
 onDateChange={setAppointmentDate}
 disabled={false}
 />

date picker will display the current date


redirect "Careers" page to Lever board

instead of its own page (which is not linked up properly) send to https://jobs.lever.co/3box

@oed 2 people have pointed this out to me recently. If super quick would be great to do ASAP.


Collect node level metrics from prometheus using a grafana board and use that for static board in Meshery

Enhancement Description
We already have the framework for collecting & persisting metrics for a static board. The static board config we have now is just a placeholder. We have to replace that with legitimate node level metrics.

Fixed by #281


security vulnerabilities

There is no vulnerability known in our latest release (4.1.3)

Thanks


Add runtime assertions to Pilot

This adds assertions that will panic at runtime to pilot. These will be
used only for development and are intended to never be enabled in
production clusters.
The first usage of this, implemented in this PR, is to ensure that our
cache eviction works properly. This is done by disabling the cache when
assertions are enabled, and ensuring all updates are NOP changes.
Motivations:

Recently had a cache eviction bug that may have been caught by this
I am hoping to add more caching soon, which I would look to test using
this
For the Delta XDS work, we need to add logic to detect if a resource
change will impact XDS. This is a perfect usage to test, as we can
assert that our detection logic matches the actual XDS change.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test lint_istio

gencheck_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test gencheck_istio

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-multicluster-tests_istio

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-multicluster-tests_istio

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-multicluster-tests_istio

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-security-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
eab222fc0413e052136a408998804c1b48feed2c
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test lint_istio

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-security-multicluster-tests_istio

integ-pilot-multicluster-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test integ-telemetry-mc-k8s-tests_istio

lint_istio
079dcb0a73cd6bc618b3b42a480e39665454f4a6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a7b1a1a95c193476dcd957ca4677a6460a746283
link
/test unit-tests_istio

lint_istio
3998b76d2985644962fcf83595c1107934ad1745
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
3998b76d2985644962fcf83595c1107934ad1745
link
/test lint_istio

unit-tests_istio
3998b76d2985644962fcf83595c1107934ad1745
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Current bug:

goroutine1 generates endpoints v0
EDS updates shards to v1
goroutine2 generates endpoints v1
v0 and v1 are written, in either order. This causes assertion
invalidate caches
new writes will all be v1

This definitely violates our assertion. In real world, this may result in cache storage reverting (v0 -> v1 -> v0 -> invalidate -> v1). This is a real bug, although pretty obscure and near-zero impact. One option to fix is to only allow a single write to any key, but we still need a way to make sure our assertion works.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-k8s-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
3db9a211e6c75062410bf7b4972c56a9aae6325f
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-pilot-multicluster-tests_istio

integ-security-k8s-tests_istio
82dd6f64754cd3c633a67341dbe33a26cd5329c2
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
645a3b727a88f32fb803a8844aa8a87fd2d4dcde
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
07790f010528f80f2f6bda246d6e441f973f2d82
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d23d2f4835edaa8caec39156955c01f6afc801c8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d23d2f4835edaa8caec39156955c01f6afc801c8
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
d23d2f4835edaa8caec39156955c01f6afc801c8
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
d23d2f4835edaa8caec39156955c01f6afc801c8
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
84c827aff3f3a589b3e9e12f97032872a8c18fff
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
39ecb0af54ed285266abd22590592726d7151e39
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Generally looks good - Some questions/comments for discussion.

@ramaraochavali I don't see any questions, did you forget to hit send?

Yeah. VSCode github extension did not send :-)

@howardjohn I am good with this as is. Let us merge this and do follow-ups as needed as it is controlled by flag and is experimental in nature.