Fixes #1823 with oakpal 1.2.1 upgrade, and corrects copyright details.

Pull Request Test Coverage Report for Build 4131

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.179%

Totals

Change from base Build 4118:
0.0%

Covered Lines:
12766

Relevant Lines:
24944

💛  - Coveralls


Dual horizontal pane for better column view

Resolved / Related Issues
Items resolved / related issues by this PR.

Dual horizontal panel (Pancake Mode) for better column view

Details of Changes
Add details of changes here.

Column view can be difficult when Dual Panel is enabled. Allowing alternation between 2 vertical panels (already existing) or 2 horizontal panels (required) could solve this problem.
It would also bring more comfort to those who have large screens.

Validation
How did you test these changes?

[x] Built and ran the app
[x] Tested the changes for accessibility

Screenshots (concept)

@rafaelsouzams thank you for this pull request, we're currently in middle of refactoring the layouts and won't be able to merge this. Would you be intrested in helping on the refactor so that this can be implemented with the other changes?

If I can help with anything, I would.


Document contributor section

cc @yunxing

[ ] basic knowledge of LR1 (Some good tutorial online)
[ ] basic syntax of Menhir (syntax should be pretty simple)
[ ] what do menhir/yacc do to auto matically resolve conflicts based on precedency and associativity specified (Menhir's manual)
[ ] tutorial to work people through a simple syntax change in our parser that requires to resolve a conflict
[ ] (bonus) add an error message description with the new syntax(edited)

I didn't find a shortcut in this, it was very painful to me at first to understand all the conflicts when I make a simple change (Menhir's error messages helped a lot, but still). Not sure what do other parser contributors think?

Let's work on this soon as we will have more syntaxes changes coming soon, and any help would be very appreciated.

Done through https://github.com/facebook/reason/blob/88bd4db0e7ef1aab4dc9e7cde3db673f9f487151/src/README.md


Dismiss the Keyboard when changing the page natively (Android)

This is already done in JS https://github.com/react-native-community/react-native-viewpager/blob/9a7b1a0a0528786832bd203e96e1826d2849b8fb/js/ViewPager.js#L106-L110
But we did it natively on iOS. Should be also easy to do it natively on Android: https://stackoverflow.com/a/11818992/2277631

any ETA on this one?


#118 Added behavior to devices registered by admin.

If network didn't passed with device then device would be assigned to admin's default network. If admin don't assigned to any network then return response with 412 code.

Looks good

Looks ok for me too, merging pull request


Rework ArchiveAsync interface to make it return any archiving errors

This PR contains two commits

Rework ArchiveAsync interface to make it return any archiving errors

After experience with the current ArchiveAsync interface while
creating an rclone backend it became clear that it wasn't quite right.
With the old interface, callers did not know when the File had been
archived and thus did not know when to release resources associated
with that file.
This patch changes the interface so that it returns the error
archiving each File. This means the caller can know when the File has
been archived and when to release resources. It returns the error for
each file archived which is useful too.
Fixes #368

Add ArchiveAsync support to CompressedArchive

Having had a chance to sleep on it, I think the the interface I've proposed has a problem.
Allowing the range loop to exit on errors will cause a potential deadlock as any senders into jobs don't know whether there is a process listening or not. This isn't easily fixable in a race free way. So I think the loops should not exit on error.
So I think something like this is more correct.
func (z Zip) ArchiveAsync(ctx context.Context, output io.Writer, jobs <-chan ArchiveAsyncJob) error {
	zw := zip.NewWriter(output)
	defer zw.Close()

	var i int
	for job := range jobs {
		job.Result <- z.archiveOneFile(ctx, zw, i, job.File)
		i++
	}

	return nil
}

I'll update the PR accordingly in a moment!

I've added a new commit on top with that idea which I can squash into the first commit if you want.

I have sent a new update with the fix from above and I've also squashed the PR back into two commits with the error handling changes.

Alrighty -- sorry for the wait, I was traveling with family.

No problem. You are doing much better than me at reviewing PRs :-)

I think this looks pretty good! The API is much better; and I guess context cancellation and ContinueOnError could be honored by the caller of ArchiveAsync.

Yes its completely under the control of the caller. The current loops don't wait for context cancellation at the moment and I think if you need that it is better for the caller to do it otherwise you'll risk deadlocks when the input channel fills up because there is no-one listening.

My only comment is a nit and is optional. This has my approval. Thanks again!

:+1:


Add support for non-EventHandler based UntilEvent

I've refactored UntilEvent method to accept a delegate as a callback, and also return the callback parameters. This way, you're able to use UntilEvent for non-EventHandler events (Such as Action or your own custom delegate). I've renamed the original function to UntilEventHandlerEvent (it's a bit long but I can't think of anything shorter without abbreviations).

Should we update the unit tests to the latest version of Godot (v3.5)?

Thanks.


Failed to create a browser

Details
I'm getting this error when I try to run the nuxt generate command on Digital Ocean:

Locally it works without issues and I've installed playwright. Do I need to install any other packages?
Using it like this:
defineOgImageStatic({
  component: 'OgMain',
  provider: 'browser',
})

nuxt-seo-kit
Nuxt 3.2.3 with Nitro 2.2.3

Hey @toniengelhardt
Looks like the std-env package may not be detecting the digital ocean CI environment.
I've changed the logic to always try and install playwright as part of the generating step to get around this. Can you try 1.5.0 and let me know if it works any better

Thanks, I will try, but I didn't use the CI, I'm building it by hand via ssh in the console of the DO server.

Thanks, I will try, but I didn't use the CI, I'm building it by hand via ssh in the console of the DO server.

That would probably explain why then :laughing:

???
What do mean, it only works in a CI? Locally it works fine just with the generate command.
New version also fails:

Previously it only tried to install playwright for you in a CI environment. If you have playwright as a dependency and it's still failing, it is likely an environmental issue.
I've changed the code so the exception is thrown, you can try the latest version (1.5.2) and let me what it throws

Amazing!
I think it is definitely better to expose the error.
It complained about playwright and after re-installing it works now. I think I missed the second line the first time to install the OS deps:
$ pnpm dlx create-playwright
$ sudo pnpm exec playwright install-deps

Thanks a lot 🙏🏽 🙏🏽 🙏🏽


[Feature][Scheduling batch] Each batch judges whether the previous batch is successfully executed

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
我的调度任务，依赖于上一个批次，需要判断上一批次是否执行成功。
Use case
例如：
每小时执行的批次，11点的批次需要判断10点的批次是否执行成功，若未执行成功，则继续等待
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please use english to describe. Thanks. @luckes-yang

Please use english to describe. Thanks. @luckes-yang
For batches executed every hour, the batch at 11 o'clock needs to judge whether the batch at 10 o'clock is successfully executed. If it is not executed successfully, continue to wait.


pass footer_bg_color from buildSpec to Footer

The footer_bg_color specified wasn't getting passed to the Footer component (terminology?) at any point. The _do_layout method in Footer seems like a reasonable place to do so; anyway seems to work properly when I test.

Possible related issue: #465

Nice. 👍
Merged into release here:  https://github.com/chriskiehl/Gooey/commits/1.0.4-release


Include GPG keys for standard repositories

In current opensuse:13.2 image there are no GPG keys for these repos: repo-non-oss, repo-oss, repo-oss, repo-update and repo-update-non-oss so when creating image based on opensuse:13.2, user has to install packages with --gpg-auto-import-keys or import keys by hand. But another problem is that opensuse:13.2 doesn't include any certificates, so:

user is unable to install ca-certificates because GPG keys for repos are not imported
user is unable to download these GPG keys from anywhere, because he has no certificates to check whether he is downloading from trusted url.

I think that this forces user to build insecure images, see https://github.com/os-autoinst/openQA/pull/340#discussion_r28589978

The fixed images are going to show up as soon as this PR is closed.

The updated images are currently building. They are going to be available on the Docker Hub within the next hours.


Add transmute_ref! and transmute_mut! macros

We currently have a transmute! macro which safely transmutes an AsBytes type into a FromBytes type. We should add macros which do the same for mutable and immutable references.
A candidate implementation of transmute_ref! is in https://github.com/google/zerocopy/pull/183. We may also want to ditch it in favor of something based on this approach suggested by @gootorov, but we'd need to first confirm that invalid uses are guaranteed to generate compile-time rather than runtime errors (https://github.com/rust-lang/rust/issues/112090). EDIT: Based on the discussion there, it seems that there is such a guarantee, but we'd need to be careful about how we structure things to make sure that we actually write code that benefits from that guarantee.
Note that https://github.com/rust-lang/rust/issues/112301 will likely make @gootorov's technique a bit annoying for users (although the error messages are way better than the existing technique, and the implementation is way simpler, so IMO it's still worth it on balance).
EDIT: Another issue with this approach is that generic APIs might never fail until they're used by a downstream crate since monomorphization only happens at that point. One potential solution would be to keep the functions #[doc(hidden)] and provide macros to invoke them which also call mem::transmute in order to ensure that they can only be called from type-concrete contexts. This would artificially hamstring the API, but the footgun is big enough that it might be worth it.

Closed in https://github.com/google/zerocopy/pull/183 and https://github.com/google/zerocopy/pull/550.


Due to bug in phantomjs-node 2.0, phantom is not initializing while using jquery.go.js

Due to bug in phantomjs-node 2.0, phantom is not initializing while using jquery.go.js
Work around/fix:
Changing "phantom" version to  "1.0.0" fixed the issue for me.

+1


fix: :bug: new escape regex for line breaks using template strings on…

This PR fix the following issue:
When there's a line break on the test name using template string, the debugger button will run other tests, not only the intended test.
This bug is only occurring on linux, but I think it can also happen on Windows. My friend has a mac and the bug doesn't happen on his OS.
The bug will make the Jest-runner CLI command erase everything after the line break on the test name.
Test name example:
it(should return error
when there is no product, async () => { } )
it(should return error
when there is no category, async () => { } )
Issue #318

thanks for your contribution


Carthage fails when building SwiftDate

I just ran carthage update on my project and suddenly carthage fails when building SwiftDate.
Cartfile:

github "malcommac/SwiftDate"

Output:

*** Building scheme "SwiftDate" in SwiftDate.xcworkspace
** BUILD FAILED **

The following build commands failed:
PhaseScriptExecution Check\ Pods\ Manifest.lock /Users//Library/Developer/Xcode/DerivedData/SwiftDate-fayfyyiikmifsvbdwxifbadfkijw/Build/Intermediates/SwiftDate.build/Release-iphonesimulator/SwiftDate.build/Script-871361268F8CC3B8EB331AF3.sh
(1 failure)
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
ld: warning: embedded dylibs/frameworks only run on iOS 8 or later
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.
A shell task failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
PhaseScriptExecution Check\ Pods\ Manifest.lock /Users//Library/Developer/Xcode/DerivedData/SwiftDate-fayfyyiikmifsvbdwxifbadfkijw/Build/Intermediates/SwiftDate.build/Release-iphonesimulator/SwiftDate.build/Script-871361268F8CC3B8EB331AF3.sh
(1 failure)

me too.

Same problem

Just solved in 3.0.1. Thank you for your report.
If you have problems make sure to remove Carthage folder in your project in order to do a clean fetch/clone/build.


Feature Request: Make PowerShell to be able to print PDF files

Summary of the new feature/enhancement
Early I found that Get-Content C:\example.pdf | Out-Printer and Start-Process –FilePath “c:\docstoprint\doc1.pdf” –Verb Print are unable to print at least PDF files
It would be great to have the native ability to print PDF files without these workarounds at least on Windows
Proposed technical implementation details (optional)
For more information about the issue please refer here: https://github.com/PowerShell/PowerShell/issues/12615#issuecomment-628472368

Get-Content reads a file as string data, it has no PDF or image handling. I'm not sure what you'd reasonably expect to get as output if you called Get-Content on a PDF file, they're decidedly not plain text files.
Also, Out-Printer doesn't seem to be cross-platform, so I'm not sure if there is a great deal of interest in maintaining it / rewriting it in future.
As for Start-Process -Verb Print, this will only work if you've assigned a default PDF handling application in your Windows settings. If you have, that print task would be handled by your PDF application, typically.

Also, Out-Printer doesn't seem to be cross-platform, so I'm not sure if there is a great deal of interest in maintaining it / rewriting it in future.

Reasonable. I will correct this issue.

I think the answer to this probably lies in an external module; PowerShell itself shouldn't know about printers.
@vazome you mention workarounds in your issue description. Would you be able to list them here in case others looking for a solution come to this issue?


added right settings for deploying to SNAPSHOT

Thank you for submitting this pull request
maven settings was pointing to wrong settings.xml

How to retest a PR or trigger a specific build:

* a pull request please add comment: Jenkins retest this

Jenkins restest this


Fix typos in README.md

Did you push on the same branch as yesterday ? Cause I merged your last change in this morning and this seems to be on the same branch ?

close since it has been inactive for some time.


document exec/signal trapping issue

from discord:
jdx: to illustrate, if I do this in mise.toml:
[18:09]jdx:
[tasks.docs]
dir = "docs"
run = "bun i && bun run docs:dev"
[18:10]jdx: then pstree looks like this:
-+= 98189 jdx -fish
 \-+= 05661 jdx mise run docs
   \-+- 05662 jdx sh -c -o errexit bun i && bun run docs:dev
     \-+- 05672 jdx bun run docs:dev
       \-+- 05673 jdx node /Users/jdx/src/pitchfork/docs/node_modules/.bin/vitepress dev
         \--- 05674 jdx /Users/jdx/src/pitchfork/docs/node_modules/@esbuild/darwin-arm64/bin/esbuild --service=0.21.5 --ping
[18:10]jdx: the important one here is 05662
[18:10]jdx: sh doesn't pass signals, it just dies and leaves its children
[18:10]jdx: so if I instead do this:
[tasks.docs]
dir = "docs"
run = "bun i && exec bun run docs:dev"

[18:11]jdx: then pstree is this:
-+= 98189 jdx -fish
 \-+= 06303 jdx mise run docs
   \-+- 06304 jdx bun run docs:dev
     \-+- 06314 jdx node /Users/jdx/src/pitchfork/docs/node_modules/.bin/vitepress dev
       \--- 06315 jdx /Users/jdx/src/pitchfork/docs/node_modules/@esbuild/darwin-arm64/bin/esbuild --service=0.21.5 --ping
[18:11]jdx: note how it's one level flatter, if I send sigterm to mise in this case it works
[18:11]jdx: unfortunately this isn't fixable by anything in mise or pitchfork
[18:12]jdx: ultimately you have to use exec in the script
[18:12]jdx: this is going to need to be documented

not necessary now that #12 is done


travis-ci build file

This is basically working - the generous folks at TravisCI provided extended build times for OpenVnmrJ.
A few things need to be done to make this work for the OpenVnmrJ repo (rather than mine..)

It will need the ovjTools repo to be updated so that the corresponding branch has my build scripts.
the ovjTools branch is hard-wired to development below - could/should be changed to $TRAVIS_BRANCH
The url tags below should be changed so they point to OpenVnmrJ instead of tesch1.
The github deployment key needs to be updated, see: https://docs.travis-ci.com/user/deployment/releases/

When that's all done it should automatically create and upload packages for any tagged versions of the repo like this: https://github.com/tesch1/OpenVnmrJ/releases

Will update this according to the above comment once ovjTools are sorted out.


Unable to scroll flatlist when on applied on renderItem

I have Flatlist and I have applied gesture on the row of Flatlist so problem is that I am unable to scroll Flatlist items. Following is my renderItem code.
            <Gestures.View onTap={(event) => { this.onTap(event, index) }}>

                <TouchableOpacity delayLongPress={2000} onLongPress={() => { this.onLongPress(index) }} activeOpacity={0.9}>

                    <View style={styles.row}>

                        <View style={{ backgroundColor: item.contracted === 1 ? Colors.green : Colors.white, width: 10, height: '100%', }}></View>

                        <View style={{ flex: 1, padding: 8, flexDirection: 'column', justifyContent: 'center', alignItems: 'flex-start' }}>
                            <Text style={styles.rowNameText}>{item.name}</Text>
                            <TextBlinker actionTextBackgroundColor={item.actionTextBackgroundColor} contracted={item.contracted} actionText={item.actionText} action={item.action} />
                        </View>

                    </View>

                </TouchableOpacity>

             </Gestures.View>

Did you solve the prolem. I have the same problem. Just the difference is I haven't used TouchableOpacity element inside gesture.view.
My code is working fine on ios platform. But on android its not working.


[5.3] Mailer setQueue should expect QueueContract

QueueContract comes from use Illuminate\Contracts\Queue\Factory instead of Illuminate\Contracts\Queue\Queue. Thant makes setQueue from mailer fail if we make setQueue(RedisQueue) for example, as RedisQueue implements Illuminate\Contracts\Queue\Queue.

@lelu85 Travis failed.


Quick fix for lint converts lazy late initializer to normal initializer.

Lint: https://dart-lang.github.io/linter/lints/unnecessary_late.html
Code:
static late final DragAndDropManager _instance = DragAndDropManager();

https://user-images.githubusercontent.com/12115586/234131101-5ac09317-b4ad-4628-b181-4baac05664c0.mov

Duplicate: https://github.com/dart-lang/linter/issues/4307


[doc] Fix indents of the pprof page

What this PR does / why we need it:

Fix indents of the procedures

especially, 2. Get the Cpi Profile was merged with the previous line.

Add one 'a'

Which issue(s) this PR fixes: no
Does this PR introduce a user-facing change?: no

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

some tabs mixes with spaces @t-kikuc

some tabs mixes with spaces @t-kikuc

Thanks, I fixed it

@t-kikuc Is this still miexd?

Sorry, I fixed. (by removing the last line)
Besides, I fixed the doc of v0.46.x too.

@ffjlabo Please


Switch to electron-builder

This addresses #158.
Electron-packager generates standalone packages, while electron-builder can generate platform-specific installers. There are several benefits of electron-builder, including:

Generate familiar-feeling installers for each platform: .DMG images for OS X, MSI installers for Windows (which can be installed/uninstalled from the system Control Panel), and .deb/.rpm/PKGBUILD files for Linux.
Nicer configuration in package.json in my opinion. There's a separate config section instead of passing in a bunch of args to each platform's build step.
SGF file association at the OS level.
Integration with native app stores, if desired (this isn't part of this PR obviously, but if you ever wanted to be present on the MacOS app store, the Ubuntu repositories, etc, then this is necessary)
Support for auto-updates (also not part of this PR since it requires some setup on the GitHub side first)

Some major things I need help with:

Some package managers require icon files that are larger than the 256x256 icon that's currently on GitHub. As a temporary workaround, I manually enlarged the 256x256 to 1024x1024 and let electron-builder scale it back down so that the build passes. So the icon looks a bit ugly right now. Obviously it would be ideal to get a native 1024x1024 version... hopefully you still have the vector image :)
To get auto-updates working, you need to have one full release on GitHub through electron-builder, and then you have to set up some feeds.

I've tested on all three major platforms on my machines, and everything seems to work well, as far as I can tell. Let me know if you prefer these commits squashed!

Thank you so much! I'll look over it after my exams.


Fix assertion in mem_domain.c

Codecov Report

Merging #6191 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6191   +/-   ##
=======================================
  Coverage   52.85%   52.85%
=======================================
  Files         412      412
  Lines       40295    40295
  Branches     7804     7804
=======================================
  Hits        21296    21296
  Misses      15782    15782
  Partials     3217     3217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c1d28...65255a3. Read the comment docs.


Reviewing llamareview

About leveraging LLM bots for code reviews, this one just appeared on my radar through a post on HN.

https://github.com/marketplace/llamapreview
https://news.ycombinator.com/item?id=41996859

I am sure there will be more of that in the future. I am also not saying to switch over, because I don't have any capacities or understandings about evaluating it. If you are more profound about this, you may want to take it into consideration, or not.
Originally posted by @amotl in https://github.com/kennethreitz/responder/issues/525#issuecomment-2448094973

We are giving it a shot. A first response by @llamareview can be reviewed here:

https://github.com/kennethreitz/responder/pull/560#pullrequestreview-2406437730

Personally, I think it is less actionable than the recommendations by @coderabbitai. Maybe it will get better over time?

^^ Staging a bot fight?

@llamareview is more or less always submitting a report derived from the same template, see, for another example, https://github.com/kennethreitz/responder/pull/562#pullrequestreview-2406515333. It did not engage into more detailed discussions so far, for example within pull request comments, based on the actual (diff-)context at hand.
@coderabbitai's conversations however, are far more elaborately designed (kudos to its team), primarily delivering context-savvy suggestions into individual threaded PR comments that are roughly 70% on the spot, with the rest feeling a bit spammy, but acceptable, and secondarily suggesting some more minor nits witin the root comment, rendered collapsed, to not take too much vertical space.


"Diff"-ing and other Patch extensions

A library that can compare two JSON documents and report on their differences.

I think this may actually be a good extension to the Patch library.  It could analyze the differences and generate JSON Patch documents that represent the transformation from one to the other.

Two more extensions:

Inversions (undo)
Condensing (merging two patches)

Hi!
I've got a solution how can I contribute?

I think this may actually be a good extension to the Patch library. It could analyze the differences and generate JSON Patch documents that represent the transformation from one to the other.

I'm actually thinking the same but the other way around. 😃
I have a diff library that can produce JSON Patch document in RFC format but patching using such format is not yet support. This brought me here for alternatives.

Someone contributed some code a while ago that can create a patch from two documents (and even two objects), but there was no intermediate diff, so I left this open.

seems like this is a common thing the community is trying to wrangle
we also made our own here
https://github.com/firebend/json-patch-generator


[SPARK-11858][SQL] Move sql.columnar into sql.execution.

In addition, tightened visibility of a lot of classes in the columnar package from private[sql] to private[columnar].

Test build #46344 has started for PR 9842 at commit 91e9d2b.

Test build #46344 has finished for PR 9842 at commit 91e9d2b.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46344/
Test FAILed.

Test build #46350 has started for PR 9842 at commit 8edf6c2.

Test build #46350 has finished for PR 9842 at commit 8edf6c2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46350/
Test PASSed.


fix: problem when providing urls with parameters

This PR obsoletes: #40
Problem
I noticed that the parameters I provide to a request won't get replaced. So /customers/{id} becomes /customers/%7Bid%7D, and the request fails after 3 retries ...
TLDR;
/customers/{id} becomes /customers/%7Bid%7D?id=35467709-efc5-4e87-a09e-f7f2151afd50
instead of /customers/35467709-efc5-4e87-a09e-f7f2151afd50
Fix
I used the request interceptors to replace all placeholders (e.g. {id}) with the corresponding value (from config.params)
Other
Also see this comment: https://github.com/axios/axios/issues/706#issuecomment-612518699

I don`t know what the problem here is https://github.com/7nohe/openapi-react-query-codegen/actions/runs/8394740113/job/22992524284?pr=46
@7nohe, any suggestions?


Test

/help

/help

/help

/help

/help

/help

Available commands
- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /payout: Disable automatic payment for the issue.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address.
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
  ex2: /wallet vitalik.eth

Updated the wallet address for @0xcodercrane successfully!	 Your new address: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266

/wallet 0x00868BB3BA2B36316c2fc42E4aFB6D4246b77E46

Updated the wallet address for @0xcodercrane successfully!	 Your new address: 0x00868BB3BA2B36316c2fc42E4aFB6D4246b77E46

/help

/help

/help

/help

/help

/help


last tournament not showing in metawing

Hi, a 50-person tournament is supposed to be live on metawing since the beginning of the week and it has not showed up. It might be because the winning list have vader defender in it, and the new ships / pilotes have problems
Thank you ! :D

Thanks for submitting an issue. You're right that new pilots can cause issues, typically when their xws id changes and an outdated one is submitted to list fortress.
I reran imports locally and found three tournaments with issues.
2057 had a squad that was made with a janky list building app (no vender info) that had the wrong ship name (laat) for commander malarus. Rebuilt the list in YASB2.
2123 was a multifaction tournament and metawing doesn't need to handle multifaction lists. Can't fix
2125  had a list with a pilot xws id of wedgeantillesawing instead of wedgeantilles-rz1awing. Also submitted using a list building app that doesn't fill out the vendor field (i.e. not one of the popular ones). Rebuilt it in YASB2 and resubmitted it.
Metawing reimports the data every night so your tournament should show up in <12 hours.


Change number of hours forecast to be shown

Is your feature request related to a problem? Please describe.
First of all thanks for the great card!
Currently, the hourly forecast always shows the next 7 hours. It would be great if this number could be set higher, so for example show the next 12 hours. This is especially useful when looking at the card in the morning and trying to figure out what the rest of the day will be like.
Describe the solution you'd like
Give an option to select the number of hours (maybe also days) to preview and not have it set fixed to 7 hours/days.
Additional context

very nice card
I too felt the same need

The amount of displayed forecasts are based on the size of the card and the size of the screen, when a user is able to change it, it will mess up the card and the forecasts will be overlapping. So there is no hard setting on 7, but it is automatically adjusting.
You can create a dashboard with one panel, that will give more room and will show more hours.


Checkbox position in scrollable multiselect

When options are checked in a select multiple dialog with overflowing content, scrolling down causes the checkbox "check" to behave as sticky.
Image for reference:

You are right Alex, seems that the new reimplementation of the Checkbox has some trouble when is inside a scrollable container.


Hello World fails

This variant of of the "Hello World!" program doesn't seem to work correctly.
>++++++++[<+++++++++>-]<.>>+>+>++>[-]+<[>[->+<<++++>]<<]>.+++++++..+++.>
>+++++++.<<<[[-]<[-]>]<+++++++++++++++.>>.+++.------.--------.>>+.>++++.

I wasn't handling inner loops correctly.
It should be fixed now.
Thanks


Lazy Load Extensions

We need to lazy load extensions so they do not all load on startup because they don't all need to do so.

[ ] Every extension publishes what it relies on (activation events list in manifest.json or some other design if anyone has another idea by then. See VSCode api for a good model)
[ ] The extension service figures out all the requests that should ever be available (see #425 for a model for how to do this with menu contributions)
[ ] Main service tracks what requests are registered
[ ] Main service sends out an event announcing when a request is registered
[ ] Every process gets the list of available requests and registered requests
[ ] When a request goes out, if it isn't registered but is available, it tries to wait a while until the request is registered and then sends

Some supporting ideas:

Maybe we could add a configuration in manifest.json or in activation context or something that allows the extension dev to set a multiplier or something for how long to wait for request registration
Is there some way to make the countdown timer for waiting on requests only start when extensions have finished loading...?

BLOCKED - AWAITING SPLITTING INTO SMALLER CHUNKS

Split off from #51 because of differing priority

Split into #819, #820, and #821. Closing.


refactor: improve code with inline ternary conditional

First of all, many thanks @craftzdog for sharing this with the community! 🙏
When I was looking at the code I saw some potential improvement and thought about opening a PR. If you need any additional information just ask for it 😄
Context
I see some cases when the developer could want to maintain the full if-else instead of using the ternary conditional. But for this specific case, I see a potential benefit in removing the extra code and using the ternary conditional.
Testing
The example was changed a little bit adding some buttons and controlling the state of leftViewVisible and middleViewVisible. The code ran locally in a simulator and it seems to be running well with no loss of FPS in animation or eventual "buggy" behavior. Here is the recording that was made:
https://user-images.githubusercontent.com/7551787/200087501-c34e1f85-6724-44c2-a67d-4e4632ef5be9.mov

You are right. Thanks for the feedback!


Validate a Query against an index mapping

Is your feature request related to a problem?
In recent adding of the Observability schema based indices and dashboards, we need the ability to validate that a given SQL / PPL query running against an index - that wasn’t created yet but has a mapping template, conforms to the index mapping that describes the structure.
What solution would you like?
Adding the API for validating the correctness of a query with an index mapping / mapping template
For that matter if an index template has a supporting json_schema corresponding for that mapping - that can be used as well...
What alternatives have you considered?
N/A
Do you have any additional context?

https://github.com/opensearch-project/observability/issues/1396
https://github.com/opensearch-project/observability/issues/1389
https://github.com/opensearch-project/observability/issues/1388

Currently there is no index mapping template concept in SQL engine. So the index has to exist and then explain API can serve as this purpose. Need to figure out if and how we want to support this.


arduino-cli: 0.31.0 -> 0.32.2

Description of changes
https://github.com/arduino/arduino-cli/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 227880 run on x86_64-linux 1

2 packages built:

arduino-ci
arduino-cli

Result of nixpkgs-review pr 227880 run on x86_64-linux 1

2 packages built:

arduino-ci
arduino-cli

Ping me when CI is green.

@doronbehar CI is still waiting on aarch64-darwin but since tests are now Linux-only it should just skip when it gets around to it? x86_64-darwin correctly skipped.


Remove the filename option to kubefedctl

What this PR does / why we need it:
This PR removes support for the filename option in kubefedctl.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
As per @marun: It was a convenience for testing and expected to be used by installers that would execute kubefedctl enable but that use never materialized. So it's prudent to just remove the filename option altogether.

@abhat My apologies, as per the CI failure -f is being used by the helm sync script to generate the enable CRDs for the helm chart.  This is a legacy of a time when enabling a type required more than a type name. At this point I think a file containing a list of type names would be a good replacement and a preferable option to having to support EnableTypeDirective in the future.

@marun i will just close the PR in that case?

@abhat I still think it would be desirable to make the changes necessary to remove the option, even if more changes are required than originally anticipated.


Fatal Exception: java.lang.NullPointerException in ZoomHelper

Fatal Exception: java.lang.NullPointerException
at com.aghajari.zoomhelper.ZoomHelper$load$1.run(ZoomHelper.java:205)
at -$$LambdaGroup$js$xzCUdXiP0Q4TFHhL_Vv-FNKpLyA.run(-.java:3)
at android.os.Handler.handleCallback(Handler.java:907)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:216)
at android.app.ActivityThread.main(ActivityThread.java:7625)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:524)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:987)

Hi @PankajSavaliya ,
What is your code? Are you running my sample?

I have implemented one of my app, just getting this type of crash log from firebase crashltyics. I have implemented this function as your sample code, nothing has changed from my side. I hope this Log will be helpful.

Hello again @PankajSavaliya ,
i've checked and i'm sure there is no bug in the lib,
you should check your code again! OR attach a simple project and i'll check it

Hi from zoomHelper
if (placeHolderEnabled) {
view.postDelayed(Runnable {
placeHolderView!!.visibility = View.INVISIBLE
}, placeHolderDelay)
}  this not null !! is getting crash i think can you please check and update the code


Wait For get_part_fut To Finish After Receiving EOF In byteStream_server.rs

Description
Issue #490 mentions that ByteStreamServer::inner_read drops the future a bit too aggressively when EOF is received. This commit modifies the ByteStreamServer to wait for get_part_fut to finish once EOF is received. The code also checks if get_part_fut returns an error and handles it appropriately.
Currently, the code simply waits for a Result enum to be returned by get_part_fut to finish and checks if there's an error in Result.Err(E). In case there is no error, the code does NOT do anything with Result.Ok(T). I made an assumption that get_part_fut does important work in the background and updates accordingly. If we want to do something with the return value of get_part_fut, let me know how to proceed. :)
Fixes # 490
Type of change
Please delete options that aren't relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
The bytestream_server.rs file is located under nativelink/nativelink-service. This directory also has a test sub-directory. I wanted to run these tests; however, cargo check & cargo test both give the following output:
error[E0599]: no method named lock_blocking found for reference &async_lock::Mutex<T> in the current scope
--> nativelink-metric/src/lib.rs:445:25
|
445 |         let lock = self.lock_blocking();
|                         ^^^^^^^^^^^^^ method not found in &Mutex<T>
For more information about this error, try rustc --explain E0599.
error: could not compile nativelink-metric (lib) due to 1 previous error
This is what Rust had to say about E0599:
~ rustc --explain E0599
This error occurs when a method is used on a type which doesn't implement it:
Erroneous code example:
struct Mouth;
let x = Mouth;
x.chocolate(); // error: no method named chocolate found for type Mouth
//        in the current scope
I went to the root directory, where cargo check worked but cargo test had 0 tests to conduct. I expected this behavior as folks usually avoid creating tests in the root directory of a Rust project. Since I couldn't conduct the tests in nativelink/nativelink-service/tests, this code has NOT been tested.

This change is

Thanks Blaise for this info and sorry for the delay in getting back to you (today was extra wild ...). I'm using MacOS on Apple silicon. I was able to run the tests with cargo test --all. You're right, the execution of the tests with my commit never terminated, and I'm guessing the future in question never finished.
To ensure the tests were successful with the original code, I reverted my code and ran cargo test --all. I was surprised that even though some error statements were printed, almost all of the tests passed; only 3 were ignored with 0 failures/
measured/filtered-out.
I'm curious – are the tests supposed to succeed despite some errors? A sample error statement that got printed was:
"ERROR nativelink_scheduler::simple_scheduler: Error while running do_try_match, err: Error { code: Internal, messages: ["Worker command failed, removing worker 54af2725-8f83-438b-8919-a14d0039f2a0 -- Err(Error { code: Internal, messages: ["Worker disconnected"] })", "Failed to run worker_notify_run_action in SimpleScheduler::do_try_match"] }"

@Evaan2001 in which context did you receive this error:
"ERROR nativelink_scheduler::simple_scheduler: Error while running do_try_match, err: Error { code: Internal, messages: ["Worker command failed, removing worker 54af2725-8f83-438b-8919-a14d0039f2a0 -- Err(Error { code: Internal, messages: ["Worker disconnected"] })", "Failed to run worker_notify_run_action in SimpleScheduler::do_try_match"] }"
This also could be a good question for our Slack with a bit more context. The error can happen for a lot of reasons.
This error would typically occur when a worker fails to run an action that was routed to it, as defined here. I'm not sure what about your change should cause this error just yet.

@MarcusSorealheis, I was in the root directory and ran cargo test --all. Given that @allada pointed out a flaw in my coding logic, I wanted to eliminate the possibility of my code breaking anything and simply see what the correct test results looked like. Consequently, I reverted all of my changes before running cargo test --all. In other words, I ran the tests with my branch being the same as upstream.
This error popped up on my screen while running "Running tests/simple_scheduler_test.rs (target/debug/deps/simple_scheduler_test-c3cf20b07e504040)". There were 18 tests to be conducted and this is a snippet from my terminal:
`test worker_retries_on_internal_error_and_fails_test ... ok
2024-08-06T01:15:06.972790Z ERROR nativelink_scheduler::simple_scheduler: Error while running do_try_match, err: Error { code: Internal, messages: ["Worker command failed, removing worker 54af2725-8f83-438b-8919-a14d0039f2a0 -- Err(Error { code: Internal, messages: ["Worker disconnected"] })", "Failed to run worker_notify_run_action in SimpleScheduler::do_try_match"] }
at nativelink-scheduler/src/simple_scheduler.rs:339
in nativelink_scheduler::simple_scheduler::simple_scheduler_task_worker_matching
test worker_timesout_reschedules_running_job_test ... ok`
Let me know if you want me to provide more context from the terminal. I want to point out that this wasn't the only error message that got printed on my screen. There were in fact about 30 error messages, yet not one test failed. If it'll be helpful, I can also log the results of running cargo test --all on my computer and share it with you all.

I wonder if this is related to the recent scheduler changes cc @adam-singer
We recently introduced the ability to run with a distributed scheduler or a single scheduler, but I don't believe these changes should have added more errors. I need to run the tests on Mac. I will do it tonight. For the last couple weeks I have been on Linux for development.

@MarcusSorealheis, let me know if you see the error messages while testing on Mac. I saw 29 errors; sharing 5 I randomly selected here (ignore if not helpful):

Running tests/running_actions_manager_test.rs (target/debug/deps/running_actions_manager_test-daacda8377e1371d)

.
.
test unix_executable_file_test ... ok
  2024-08-06T01:15:10.651632Z ERROR nativelink_worker::running_actions_manager: Command returned non-zero exit code, exit_code: 9, stdout: "", stderr: ""
    at nativelink-worker/src/running_actions_manager.rs:1160

test worker_times_out ... ok
.
.

Running tests/local_worker_test.rs (target/debug/deps/local_worker_test-52765e08b4ec9177)

  2024-08-06T01:15:09.938890Z ERROR nativelink_worker::local_worker: Error, err: Error { code: Internal, messages: ["Got EOF expected UpdateForWorker"] }
    at nativelink-worker/src/local_worker.rs:534
    in local_worker_test::utils::local_worker_test_utils::local_worker_spawn

Running tests/bytestream_server_test.rs (target/debug/deps/bytestream_server_test-8a4014f213431079)

.
.
test out_of_sequence_write ... ok
  2024-08-06T01:15:07.001937Z ERROR nativelink_service::bytestream_server: error: status: InvalidArgument, message: "Expected WriteRequest struct in stream : In ByteStreamServer::write", details: [], metadata: MetadataMap { headers: {} }
    at nativelink-service/src/bytestream_server.rs:640
.
.

Running tests/filesystem_store_test.rs (target/debug/deps/filesystem_store_test-1f7e97c7e6febd9e)

.
.
test file_continues_to_stream_on_content_replace_test ... ok
  2024-08-06T01:15:07.394663Z ERROR nativelink_store::filesystem_store: Failed to touch file, err: Error { code: NotFound, messages: ["No such file or directory (os error 2)", "Failed to touch file in filesystem store \"/var/folders/rh/bz_crfln23q5qc4h149dz_r40000gn/T/nix-shell.F4XFEp/11411840072976465328/content_path/0123456789abcdef000000000000000000010000000000000123456789abcdef-10\""] }
    at nativelink-store/src/filesystem_store.rs:342
.
.

Running tests/cas_server_test.rs (target/debug/deps/cas_server_test-f85a530c68a87e66)

.
.
test empty_store ... ok
  2024-08-06T01:15:07.070854Z ERROR nativelink_service::cas_server: error: status: InvalidArgument, message: "Invalid string length : Invalid sha256 hash: BAD_HASH : Failed on find_missing_blobs() command", details: [], metadata: MetadataMap { headers: {} }
    at nativelink-service/src/cas_server.rs:302
.
.

@MarcusSorealheis @Evaan2001 the printing of error messages isn't always an indication of a failed test passing, its an indication that the test passed by a line of code that logs an event as error, that could be by the design of the tests intention.  The most obvious case is (5) where the test for empty storage and a fetch is tried, we expect an error message to be printed. Unfortunately rust doesn't have the jvm level of log message interception and validation to verify error messages in tests (at least I'm not aware of any reflective test features like that), guessing we could try and hook the event listeners and verify we expect the message to be error level depending on the test context.

@adam-singer, that makes sense. Thanks for clarifying.
@allada, I used rebase to incorporate your changes to the toml files. However, running cargo test inside the nativelink-service directory failed as the code couldn't compile. There was just one error that showed up 13 times, here:
Compiling nativelink-service v0.4.0 (/Users/evaanahmed/Documents/GitHub/nativelink/nativelink-service)
error[E0599]: no variant or associated item named `Gzip` found for enum `CompressionEncoding` in the current scope
   --> nativelink-service/tests/bytestream_server_test.rs:197:75
    |
197 |         make_stream_and_writer_spawn(bs_server, Some(CompressionEncoding::Gzip));
    |                                                                           ^^^^ variant or associated item not found in `CompressionEncoding`
    |
note: if you're trying to build a new `CompressionEncoding`, consider using `CompressionEncoding::from_accept_encoding_header` which returns `Option<CompressionEncoding>`
   --> /Users/evaanahmed/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tonic-0.12.1/src/codec/compression.rs:101:5
    |
101 | /     pub(crate) fn from_accept_encoding_header(
102 | |         map: &http::HeaderMap,
103 | |         enabled_encodings: EnabledCompressionEncodings,
104 | |     ) -> Option<Self> {
    | |_____________________^
help: there is a method `vzip` with a similar name
    |
197 |         make_stream_and_writer_spawn(bs_server, Some(CompressionEncoding::vzip));
    |                                                                           ~~~~

The good thing is that cargo test --all works – the code compiles and the tests run – so I can be on my way to work on your feedback, testing my code by running all the tests.

Hey @allada, just finished updating the commit. Your feedback helped me realize that my understanding of the code was slightly wrong, so I thank you for that :).
cargo test --all conducted 316 tests and my current code passed all of them.
I had a question regarding one of your earlier suggestions. Regarding error handling, you mentioned "merging the 2 responses". I'm afraid I didn't quite understand that. If 1 response is the error message, what's the other response we're talking about? For now, I handled the error like errors were handled here:
if bytes.len() > state.max_bytes_per_stream {
                                        let err = make_err!(Code::Internal, "Returned store size was larger than read size");
                                        return Some((Err(err.into()), None));
                                    }

@allada, shortened the comments; have a look!

@allada although I have 2 LGTMs, I still need your final good-to-go as the PR needs you to approve the requested changes. Think you can have a look soon?

@allada, done!

@allada it's done now. I thought you wanted me to delete just // Now, get_part_result has a future that resulted in either Result<()> or Error. but I guess the entire comment block needed to go; my bad for misunderstanding you!

Hey @allada, pinging you in case you missed my last review request. The extra comments are removed. Think you can give your LGTM and merge this PR?


[Enhancement] implement streamload via http stream

What problem does this PR solve?
Issue Number: close #36773
Related PR: #xxx
Problem Summary:
1.	New Configuration:
•	Added enable_streamload_by_httpstream configuration option.
•	When enabled, Stream Load requests are processed using the HTTP Stream approach.
2.	Code Modifications:
•	Updated the _process_put method in stream_load.cpp:
•	Added logic to construct the SQL statement from Stream Load headers.
•	Assigned the generated SQL statement to the ctx (context object).

None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[x] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[x] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[x] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.
Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?


define and implement use case for Payone Sofortüberweisung

define what happens when, where and how if the users selectes Payone Sofortüberweisung as his payment method

data and user action flow needs to be implemented as following:

user selects "sofortüberweisung" as his payment method
PaymentFramework creates Payment object @ CTP (success, cancel, error redirect URLs provided by the shop)
shop shows input form for IBAN / BIC
user inserts and clicks on buy now
create the transaction with blowfish encrypted IBAN / BIC values (see https://github.com/commercetools/commercetools-payone-integration/commit/2be0daca661d89c8bda45102766fc21238e999fc BankTransferRequestFactory
call the "handlePayment" method of the Payone Connector
interpret the result -> get a valid payment object back
possibly a redirect URL is provided -> then redirect
handle callbacks after redirect accordingly
create order if everything worked fine
show confirmation page

cancel or error callbacks have to be handled by the shop and should probably result in the possibility to select a new payment method
the encryption secret has to be provided via configuration and has to be the same that the Payone Connector is using

Remember to handle cancel URLs which redirects use back payment method selection page

Looks good.

@butenkor sofortüberweisung does not need step 3 anymore.

shop shows input form for IBAN / BIC

therefore step 5 does create the transaction without IBAN and BIC

@mht-dotsource but it still requires country code, right? Where do you get it from? Recently CTP  API provided locale attribute on cart object. I would take it from cart and if locale is not supported by PSP (defined in documentation) configured fallback language is used. If fallback is not defined English is default. WDYT?

@butenkor indeed without IBAN and BIC the beahviour of the Payone-API is that it requires the parameter bankcountry (e.g. DE). It's not handled by the payone-integration-service.
The payone-integration-service uses the same value for bankcountry  and country which it get from the billing address of the cart.

IT test with creation of transaction is missing.

@butenkor 4836dd1
Close the issue?

May be closed once merged to master and released.


Check file existence in parse-shasums.sh

What this PR does / why we need it:
Check file existence in parse-shasums.sh. File might not exist if images weren't pushed before.
Release note:
NONE

test failures are about failed downloads, but os-3.11.0 and k8s-1.11.0 are green
/approve

@slintes does this mean that we could code in shasums from the previous run?

Mh, good question.
If you run make manifests alone, yes. But I think it's not an issue. You might want to create new manifests with "old" shasums, if you just changed something in the manifest templating but not in the binaries/images.
make cluster-build/sync is fine, because hack/cluster-build.sh always pushes first.

Hm, that is not very reassuring. Let's see if we can improve that in the future. E.g. by directly specifying the right dependency tree in bazel.


Navigation Service with multi animation choose

NavigationService.instance.NavigateToPage({String path?, Object? data, (enum) animationType}) like

https://pub.dev/packages/page_transition


ci(custom-checks): fix broken package.json sort verification

Description
As a maintainer I want to have an automated CI job (that actually works) that checks for package.json files being sorted so that I don't have to manually be on the lookout for non-sorted dependencies and the like.
Previous attempt at making this happen: https://github.com/hyperledger/cacti/issues/1341
A related discussion I had with @outSH about this: https://github.com/hyperledger/cacti/pull/2310#discussion_r1152057132
Acceptance Criteria

The custom checks fail in the CI if any package.json files are found which were previously unsorted.
When the custom checks are executed locally, the ensure sort check can still be used to perform the sorting so that contributors

@petermetz
I have done some work towards this issue. Please review if it suits your requirements.
Found error in usage of sort-package in scripts introduced in this issue https://github.com/hyperledger/cacti/issues/1341.
Module API accepts only JSON objects https://www.npmjs.com/package/sort-package-json. But here https://github.com/hyperledger/cacti/blob/3e6d908cb4cf732ef057a30df3e8267381f3f806/tools/custom-checks/check-package-json-sort.ts#L51 only paths to the files are passed.
I did simple CI action to check if package.json files in /examples and /packages are sorted. If not, it prints short script to run in cactus root folder to sort remaining packages.

@petermetz I have done some work towards this issue. Please review if it suits your requirements.
Found error in usage of sort-package in scripts introduced in this issue #1341. Module API accepts only JSON objects https://www.npmjs.com/package/sort-package-json. But here
https://github.com/hyperledger/cacti/blob/3e6d908cb4cf732ef057a30df3e8267381f3f806/tools/custom-checks/check-package-json-sort.ts#L51

@rwat17 Thank you very much!
My preferred way would be to solve it via the existing NodeJS script instead of going down a level to writing shell because of these questions that popped into my head:
Questions:

Did you verify the shell script to also be working for Mac users? We've had lots of bugs in the past where tiny little implementation details made things broken on either Linux or mac and also Windows back when our build was still supported on it (and we should - in my opinion - eventually get the build working again on Windows/PowerShell as well)
Can the shell script be changed/extended (relatively easily) later to pull package path patterns (globs) from the root folder's lerna.json file? This is a future change we'll need to change because of the cactus -> cacti rename all of these hardcoded globs will start failing soon. I'm thinking maybe with some clever jq magic it can be made so that the shell script parses the lerna.json file for the globs and then iterates through them but I'm a little worried that by that point the shell code will be hard to read/understand for beginners.
Is there an easy way to plug in the shell script into the existing set of "custom checks" that get executed when we run yarn run custom-checks? The only way I can think of is that the custom-checks script starts spawning other processes to run the shell script, not necessarily bad but it does increase complexity 'coz now we have to write logic to parse and interpret the stdout/stderr of that process in addition to just running the check itself.

If all of these are OK in your opinion then I'd be fine with the shell script instead of the NodeJS script, just let me know your thoughts!


VAE Comparison

Hi Sangwoong @swyoon ,
Just for curiosity, it may not be related to the main work.
Thanks for releasing scripts of 2D experiments. I saw you are using a VAE with a learnable std for comparisons. Just wondering, won't it lead to posterior collapse? Since the std can constantly be increasing to reduce the total loss. Did you use any technique to avoid this? Thanks.
https://github.com/swyoon/normalized-autoencoders/blob/27ccb74bb725768f9ba9ea6fa03a7a40867eebb1/models/modules.py#L49
vae = VAE(encoder, decoder, sigma_trainable=True, use_mean=False)

Sorry by mistake.


Isn't it supposed to handle long videos?

Why does my 32GB of memory fill up and the system become very sluggish when processing a 4-minute video, resulting in the following error?
SAMURAI mode: True
[15:18:19] D:\a\decord\decord\src\video\ffmpeg\filter_graph.cc:112: buffersink get frame failed12
Traceback (most recent call last):
File "E:\basketball_seg\samurai\scripts\demo.py", line 142, in
main(args)
File "E:\basketball_seg\samurai\scripts\demo.py", line 93, in main
state = predictor.init_state(frames_or_path, offload_video_to_cpu=True)
File "E:\basketball_seg\venv\lib\site-packages\torch\utils_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
File "E:/basketball_seg\samurai\sam2\sam2\sam2_video_predictor.py", line 53, in init_state
images, video_height, video_width = load_video_frames(
File "E:/basketball_seg\samurai\sam2\sam2\utils\misc.py", line 189, in load_video_frames
return load_video_frames_from_video_file(
File "E:/basketball_seg\samurai\sam2\sam2\utils\misc.py", line 298, in load_video_frames_from_video_file
for frame in decord.VideoReader(video_path, width=image_size, height=image_size):
File "E:\basketball_seg\venv\lib\site-packages\decord\video_reader.py", line 105, in getitem
return self.next()
File "E:\basketball_seg\venv\lib\site-packages\decord\video_reader.py", line 117, in next
arr = _CAPI_VideoReaderNextFrame(self._handle)
File "E:\basketball_seg\venv\lib\site-packages\decord_ffi_ctypes\function.py", line 173, in call
check_call(_LIB.DECORDFuncCall(
File "E:\basketball_seg\venv\lib\site-packages\decord_ffi\base.py", line 78, in check_call
raise DECORDError(err_str)
decord.ffi.base.DECORDError: [15:18:32] D:\a\decord\decord\src\video\ffmpeg\threaded_decoder.cc:292: [15:18:19] D:\a\decord\decord\src\video\ffmpeg\threaded_decoder.cc:159: Check failed: filter_graph->Pop(&out_frame_p) Error fetch filtered frame.

sloved! another question, I want to used flash-attn, but I run the code, it give this output below:
E:\basketball_seg\venv\lib\site-packages\torchvision\io\video_reader.py:233: UserWarning: Accurate seek is not implemented for pyav backend
warnings.warn("Accurate seek is not implemented for pyav backend")
E:/basketball_seg\samurai\sam2\sam2\modeling\backbones\hieradet.py:70: UserWarning: 1Torch was not compiled with flash attention. (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:555.)
x = F.scaled_dot_product_attention(
E:/basketball_seg\samurai\sam2\sam2\sam2_video_predictor.py:971: UserWarning: cannot import name 'C' from 'sam2' (E:/basketball_seg\samurai\sam2\sam2_init.py)
Skipping the post-processing step due to the error above. You can still use SAM 2 and it's OK to ignore the error above, although some post-processing functionality may be limited (which doesn't affect the results in most cases; see https://github.com/facebookresearch/sam2/blob/main/INSTALL.md).
pred_masks_gpu = fill_holes_in_mask_scores(
propagate in video:   0%|          | 0/6000 [00:00<?, ?it/s]E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Memory efficient kernel not used because: (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:718.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Memory Efficient attention has been runtime disabled. (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen/native/transformers/sdp_utils_cpp.h:495.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Flash attention kernel not used because: (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:720.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: CuDNN attention kernel not used because: (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:722.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Query tensor was not in cuDNN-supported packed QKV layout[1048576, 1048576, 256, 1] (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:410.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Key tensor was not in cuDNN-supported packed QKV layout[1048576, 256, 256, 1] (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:413.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Value tensor was not in cuDNN-supported packed QKV layout[1048576, 256, 256, 1] (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:416.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:/basketball_seg\samurai\sam2\sam2\modeling\sam\transformer.py:344: UserWarning: Query tensor was not in cuDNN-supported unpacked QKV layout[1048576, 1048576, 256, 1] (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:421.)
out = F.scaled_dot_product_attention(q, k, v, dropout_p=dropout_p)
E:\basketball_seg\venv\lib\site-packages\torch\nn\modules\module.py:1562: UserWarning: Flash Attention kernel failed due to: No available kernel. Aborting execution.
Falling back to all available kernels for scaled_dot_product_attention (which may have a slower speed).
return forward_call(*args, **kwargs)

@tppqt Hello, how did you solve the memory issue?

@tppqt you can refer to this SAM2 issue https://github.com/facebookresearch/sam2/issues/48

See https://github.com/facebookresearch/sam2/issues/264 for more details on inference long videos.


[Pagination][TablePagination] Inconsistent API behavior between components

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The APIs for TablePagination and Pagination behave differently.

Why is the count-prop for TablePagiantion the total number of items the pagination controls while for Pagination it is the total number of pages?
Why is the page-prop for TablePagination a zero-based index while for Pagination it is not.
Why does the Pagination component not take care of the number of pages based on the item count and number of items per page itself? Now the API either requires a hardcoded page number or for anyone who uses the component to make sure that the number of pages is properly rounded up.

Expected Behavior 🤔
The APIs behave in the same way where it makes sense.
Steps to Reproduce 🕹
N/A

Tech
Version

Material-UI
v4.9.2

@Studio384 I believe there is a strong difference between the use case for the Pagination component and TablePagination. The API reflects it.

The Pagination is meant to paginate a list of arbitrary items. SEO is important. For instance, for a blog.
The TablePagination is meant to paginate a list of rows. SEO is not important. For instance, for a data grid.

I think that it answers the 3 questions above. @mbrookes Maybe we should improve the documentation to better explain the difference?

A cross-reference from one component to the other wouldn't be using unreasonable if @Studio384 would like to add it?

@mbrookes Happy to fix this one up. Where would you prefer to see the reference? In the component docs or the api docs? I search for an example of where this exists today and didn't find a clear match.
Thanks!

@hoop71 I think that we could like the TablePagination component in /components/pagination/, from the lest specific name to the most. Maybe something like this?
diff --git a/docs/src/pages/components/pagination/pagination.md b/docs/src/pages/components/pagination/pagination.md
index 2d9f0d98d..ce12464d9 100644
--- a/docs/src/pages/components/pagination/pagination.md
+++ b/docs/src/pages/components/pagination/pagination.md
@@ -1,6 +1,6 @@
 ---
 title: Pagination React component
-components: Pagination, PaginationItem
+components: Pagination, PaginationItem, TablePagination
 ---

 # Pagination
@@ -56,6 +56,17 @@ import { usePagination } from '@material-ui/lab/Pagination';

 {{"demo": "pages/components/pagination/UsePagination.js"}}

+## Table pagination
+
+The `Pagination` component was designed to paginate a list of arbitrary items when infinite loading isn't used.
+It's preferred in contexts where SEO is important, for instance, a blog.
+
+For the pagination of a large set of tabular data, you will find a different component: the `TablePagination`.
+
+*a new demo with TablePagination and only*
+
+You can learn more about this use case in the [table section](https://material-ui.com/components/tables/#custom-pagination-options) of the documentation.
+
 ## Accessibility

 ### ARIA

Sweet. I will work on this today!


Get-Content ignores the -Encoding parameter sometimes

Convert a plain English string to UTF16 ("Unicode") 2-bytes-per-character and convert it back through UTF8, and it ends up double the length, with spaces between every character. It's a wrong decoding, but that is something you can do.
Do the same conversion path using Set-Content -Encoding Unicode and then Get-Content -Encoding UTF8 , and I'd expect the exact same outcome. Instead, it decodes the string correctly:
$s = 'test'
$bytes = [Text.Encoding]::Unicode.GetBytes($s)
[text.encoding]::UTF8.GetString($bytes)

t e s t

$s | set-content ~\test.txt -Encoding unicode
get-content ~\test.txt -Encoding utf8

test

I haven't tried to verify why, but the content of the file in bytes is a 2-byte encoding, so  my guess is that Get-Content is detecting the file's BOM and using the detected encoding instead of the encoding I told it to use.  The -Encoding section of the Get-Content help doesn't seem to mention it.
If I specify an encoding, should that override any auto-detection? Or should it at least be documented that it won't?

/cc @JamesWTruher Could you please look the Issue?


Publish source distribution to pypi

Currently it looks like only a wheel is published for this package to pypi. It would be useful to also publish the source in tar.gz format.

I'd appreciate this as well.

https://github.com/microsoft/onnxconverter-common/releases/tag/v1.13.0 released with tar.gz


Sample programs don't call Mix_Init()

The playmus.c and playwave.c sample programs don't call Mix_Init(), seemingly in violation of the API documentation (emphasis mine):

This function loads dynamic libraries that SDL_mixer needs, and prepares them for use.  This must be the first function you call in SDL_mixer, and if it fails you should not continue with the library.

Are the samples wrong?  Is the documentation wrong?  Something else?

Yeah, I don't think that's correct. @icculus?

Hmm, Mix_Init() only configures music format stuff, and Mix_LoadMusic_RW() will do it for you anyhow. What's the value of having Mix_Init() at all, then? To know if a certain format is unsupported up front?

(We can change the "you must call this first" language in any case, since that's clearly not true.)

What's the value of having Mix_Init() at all, then? To know if a certain format is unsupported up front?

Yep.


Updates services and tools

This list was missing mention of syntax highlighting, so that felt like a good addition. I also added a few services I maintain and updated the text to my client (which was already present on the list).

@sloumdrone Thanks for you contribution 🎉 🙏


autodetect partions

automaticly initialize the esp and cryptroot var

I believe there is a timer neccesary betwen parted and the assignment depending on the speed of the PC installing it


⚠ Samsung has degraded performance

In ea89248, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2190 ms

Resolved: Samsung performance has improved in e5ce4ec.


🐛 Bug Report: Github Org Data does not have option to import github team under default namespace

📜 Description
I had already setup existing backstage with old backend system and I was using Github org data to ingest user&teams into Bakctage, it was working fine and user&teams are ingesting under default namespace, and after that when I need to reference owner field in catalog-info.yaml file I just have to mention the team name without using full reference of namespace.
In New Backend System, Now github teams are ingesting under namespace which is name of your github org.
👍 Expected behavior
I want to have an option where I can ingest github teams under default namespace or make my org as a default namespace so that I do not need to change all my catalog-info.yaml file to include full reference of namespaces in owner field.
👎 Actual Behavior with Screenshots

👟 Reproduction steps
Use Github org data to ingest Github user and teams into backstage and then reference one team in catalog.info.yaml file under owner field:
spec:
  type: service
  lifecycle: development
  owner: "platform" #here full namespace path is not mention

📃 Provide the context for the Bug.
No response
🖥 Your Environment
OS:   Linux 5.15.0-105-generic - linux/x64
node: v18.18.2
yarn: 1.22.21
cli:  0.26.4 (installed)
backstage:  1.26.0

Dependencies:
  @backstage/app-defaults                                          1.5.4
  @backstage/backend-app-api                                       0.7.1
  @backstage/backend-common                                        0.21.7
  @backstage/backend-defaults                                      0.2.17
  @backstage/backend-dev-utils                                     0.1.4
  @backstage/backend-openapi-utils                                 0.1.10
  @backstage/backend-plugin-api                                    0.6.17
  @backstage/backend-tasks                                         0.5.22
  @backstage/catalog-client                                        1.6.4
  @backstage/catalog-model                                         1.4.5
  @backstage/cli-common                                            0.1.13
  @backstage/cli-node                                              0.2.5
  @backstage/cli                                                   0.26.4
  @backstage/config-loader                                         1.8.0
  @backstage/config                                                1.2.0
  @backstage/core-app-api                                          1.12.4
  @backstage/core-compat-api                                       0.2.4
  @backstage/core-components                                       0.14.5
  @backstage/core-plugin-api                                       1.9.2
  @backstage/e2e-test-utils                                        0.1.1
  @backstage/errors                                                1.2.4
  @backstage/eslint-plugin                                         0.1.7
  @backstage/frontend-plugin-api                                   0.6.4
  @backstage/integration-aws-node                                  0.1.12
  @backstage/integration-react                                     1.1.26
  @backstage/integration                                           1.10.0
  @backstage/plugin-api-docs                                       0.11.4
  @backstage/plugin-app-backend                                    0.3.65
  @backstage/plugin-app-node                                       0.1.17
  @backstage/plugin-auth-backend-module-atlassian-provider         0.1.9
  @backstage/plugin-auth-backend-module-aws-alb-provider           0.1.9
  @backstage/plugin-auth-backend-module-azure-easyauth-provider    0.1.0
  @backstage/plugin-auth-backend-module-bitbucket-provider         0.1.0
  @backstage/plugin-auth-backend-module-cloudflare-access-provider 0.1.0
  @backstage/plugin-auth-backend-module-gcp-iap-provider           0.2.12
  @backstage/plugin-auth-backend-module-github-provider            0.1.14
  @backstage/plugin-auth-backend-module-gitlab-provider            0.1.14
  @backstage/plugin-auth-backend-module-google-provider            0.1.14
  @backstage/plugin-auth-backend-module-guest-provider             0.1.3
  @backstage/plugin-auth-backend-module-microsoft-provider         0.1.12
  @backstage/plugin-auth-backend-module-oauth2-provider            0.1.14
  @backstage/plugin-auth-backend-module-oauth2-proxy-provider      0.1.10
  @backstage/plugin-auth-backend-module-oidc-provider              0.1.8
  @backstage/plugin-auth-backend-module-okta-provider              0.0.10
  @backstage/plugin-auth-backend                                   0.22.4
  @backstage/plugin-auth-node                                      0.4.12
  @backstage/plugin-auth-react                                     0.1.1
  @backstage/plugin-catalog-backend-module-github-org              0.1.12
  @backstage/plugin-catalog-backend-module-github                  0.6.0
  @backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.1.15
  @backstage/plugin-catalog-backend                                1.21.1
  @backstage/plugin-catalog-common                                 1.0.22
  @backstage/plugin-catalog-graph                                  0.4.4
  @backstage/plugin-catalog-import                                 0.10.10
  @backstage/plugin-catalog-node                                   1.11.1
  @backstage/plugin-catalog-react                                  1.11.3
  @backstage/plugin-catalog                                        1.19.0
  @backstage/plugin-events-node                                    0.3.3
  @backstage/plugin-github-actions                                 0.6.16
  @backstage/plugin-org                                            0.6.24
  @backstage/plugin-permission-backend-module-allow-all-policy     0.1.14
  @backstage/plugin-permission-backend                             0.5.41
  @backstage/plugin-permission-common                              0.7.13
  @backstage/plugin-permission-node                                0.7.28
  @backstage/plugin-permission-react                               0.4.22
  @backstage/plugin-proxy-backend                                  0.4.15
  @backstage/plugin-scaffolder-backend-module-azure                0.1.9
  @backstage/plugin-scaffolder-backend-module-bitbucket-cloud      0.1.7
  @backstage/plugin-scaffolder-backend-module-bitbucket-server     0.1.7
  @backstage/plugin-scaffolder-backend-module-bitbucket            0.2.7
  @backstage/plugin-scaffolder-backend-module-gerrit               0.1.9
  @backstage/plugin-scaffolder-backend-module-gitea                0.1.7
  @backstage/plugin-scaffolder-backend-module-github               0.2.7
  @backstage/plugin-scaffolder-backend-module-gitlab               0.3.3
  @backstage/plugin-scaffolder-backend                             1.22.4
  @backstage/plugin-scaffolder-common                              1.5.1
  @backstage/plugin-scaffolder-node                                0.4.3
  @backstage/plugin-scaffolder-react                               1.8.4
  @backstage/plugin-scaffolder                                     1.19.3
  @backstage/plugin-search-backend-module-catalog                  0.1.23
  @backstage/plugin-search-backend-module-techdocs                 0.1.22
  @backstage/plugin-search-backend-node                            1.2.21
  @backstage/plugin-search-backend                                 1.5.7
  @backstage/plugin-search-common                                  1.2.11
  @backstage/plugin-search-react                                   1.7.10
  @backstage/plugin-search                                         1.4.10
  @backstage/plugin-tech-radar                                     0.7.4
  @backstage/plugin-techdocs-backend                               1.10.4
  @backstage/plugin-techdocs-module-addons-contrib                 1.1.9
  @backstage/plugin-techdocs-node                                  1.12.3
  @backstage/plugin-techdocs-react                                 1.2.3
  @backstage/plugin-techdocs                                       1.10.4
  @backstage/plugin-user-settings                                  0.8.5
  @backstage/release-manifests                                     0.0.11
  @backstage/repo-tools                                            0.8.0
  @backstage/test-utils                                            1.5.4
  @backstage/theme                                                 0.5.3
  @backstage/types                                                 1.1.1
  @backstage/version-bridge                                        1.0.8
Done in 0.95s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Thank you for reporting this. We are working on a fix in https://github.com/backstage/backstage/pull/24700
In the meantime I can give you a workaround to apply in your packages/backend/src/index.ts
+ import {
+   coreServices,
+   createBackendModule,
+ } from '@backstage/backend-plugin-api';
+ import { catalogProcessingExtensionPoint } from '@backstage/plugin-catalog-node/alpha';
+ import { GithubOrgEntityProvider } from '@backstage/plugin-catalog-backend-module-github';

...

- backend.add(import('@backstage/plugin-catalog-backend-module-github-org'));
+ backend.add(
+   createBackendModule({
+     pluginId: 'catalog',
+     moduleId: 'example-custom-processor',
+     register(env) {
+       env.registerInit({
+         deps: {
+           catalog: catalogProcessingExtensionPoint,
+           config: coreServices.rootConfig,
+           logger: coreServices.logger,
+         },
+         async init({ catalog, config, logger }) {
+           catalog.addEntityProvider(
+             GithubOrgEntityProvider.fromConfig(config, {
+               // same options as before
+             }),
+           );
+         },
+       });
+     },
+   }),
+ );

Let me know if this work!

@vinzscam --> Thanks for your reply, I have upgraded my backstage version to 1.27.0 and right now groups are ingesting under default namespace.
and sorry I have not got the time to test your above code on old version.
Again Thanks

@vinzscam --> Thanks for your reply, I have upgraded my backstage version to 1.27.0 and right now groups are ingesting under default namespace. and sorry I have not got the time to test your above code on old version. Again Thanks

ah no problem, glad everything is working as expected 🙏


Attack names with punctuation are parsed into the text of the previous action

This includes punctuation: comma, plus, hyphen, apostrophe
Example attack/weapon names affected include "Long sword +3, frost", "Dart-launcher", and "Cat o' nine tails".
Long sword +3, frost. Melee Weapon Attack: +5 to hit, reach 5 ft., one target. Hit: 12 (1d10+7) magical slashing damage plus 3 (1d6) cold damage.
Dart-launcher. Ranged Weapon Attack: +2 to hit, range 12/60, one target. Hit: 10 (3d4+3) piercing damage.
Cat o' nine tails. Melee Weapon Attack: +2 to hit, reach 10 ft., one target. Hit 4 (1d6+3) slashing damaging plus 3 (1d6) piercing damage.

This is fixed with version 1.3.2.
Out of curiosity, where did those statblocks come from? I noticed a couple errors with them, like "slashing damaging" instead of "slashing damage" and "Hit 4" instead of "Hit: 4". This things will confuse the parser since it's expecting those things to be formatted a very specific way.

Initially it was "Long sword +3, frost" that failed, so I tried different names on that one to see if other common punctuation also failed.  The last two examples were thrown together as diverse examples rather than just stating the names, so those are just typos due to quick editing.

Gotcha. Good to know. All of those names should work now.


How do i Use flyway to migrate .SQL file

I have a .SQL file, How do i use it to migrate .SQL file?

Follow one of the getting started guides on the flywaydb.org and everything will be instantly clear :-)


A command to create new drafts

I would imagine that the first thing a blogger does is to create a draft of the post and only later they would publish it. So it makes sense more to start the workflow by creating a new draft, not a new post. Such command was not in the code, so I added it.

Cool! I love it!
Thank you very much for this contribution!


Adding Cookiebot consent banner

This is related to the issue #1405 from the Backlog.
I added the scripts for the cookie consent banner. I can't check if it is working on the localhost, so I guess we need to upload it to staging at least to see if it is working.
Also I wasn't sure if we need to add the data-cookieconsent to any script on the site:

Signed-off-by: Zuri Negrín<EMAIL_ADDRESS>

@dpordomingo The cookie consent banner is not a yes / no question.  We display the banner until visitors accept our cookie policy by clicking on the button "Got it". That's how most site handle cookie tracking consent.
Cookie consent scans the website on a monthly basis and provides a report of all the scripts using cookies across the site.
We should actually embed the following script to publish the full report under a section called Cookie Policy under Privacy https://sourced.tech/legal/#privacy cc @znegrin

We should actually embed the following script to publish the full report under a section called Cookie Policy under Privacy https://sourced.tech/legal/#privacy cc @znegrin

@vcoisne the script your are asking me to add was already on the original commit and added in that section.

The banner is now visible in staging. I'm not happy with the look and feel though. Maybe @ricardobaeta can help customize it to fit our design identity better. I will share the credentials with you via a separate channel.

Some things I see:
It is said in https://landing-staging.srcd.run/legal/

The law states that we can store cookies on your device if they are strictly necessary for the operation of this site. For all other types of cookies, we need your permission.
Your current state: Use necessary cookies only.
Change your consent

From our cookie inventory, it is said that the necessary ones are only:

__cfduid blog.sourced.tech ghost.io
CookieConsent sourced.tech

But checking the cookies that were stored in my session, I saw that there were installed some non necessary cookies.

I wonder if it could be a problem and if it would help us if we list all of them as being necessary.

Actually, it looks fine now @ricardobaeta
@dpordomingo I don't think it is a problem because we have explicit consent banner enabled. I don't think we should list the cookies as necessary if they are not.
IMO this is ready to be deployed in prod.


 Where the hell does it get the old Sirupsen/logrus from??? https://github.com/containerd/containerd/pull/5005/checks?check_run_id=1838578222
Making install in tests
Making install in doc
 /bin/mkdir -p '/usr/local/share/man/man1'
 /usr/bin/install -c -m 644 man/man1/scmp_sys_resolver.1 '/usr/local/share/man/man1'
 /bin/mkdir -p '/usr/local/share/man/man3'
 /usr/bin/install -c -m 644 man/man3/seccomp_arch_add.3 man/man3/seccomp_arch_exist.3 man/man3/seccomp_arch_native.3 man/man3/seccomp_arch_remove.3 man/man3/seccomp_arch_resolve_name.3 man/man3/seccomp_attr_get.3 man/man3/seccomp_attr_set.3 man/man3/seccomp_export_bpf.3 man/man3/seccomp_export_pfc.3 man/man3/seccomp_init.3 man/man3/seccomp_load.3 man/man3/seccomp_merge.3 man/man3/seccomp_release.3 man/man3/seccomp_reset.3 man/man3/seccomp_rule_add.3 man/man3/seccomp_rule_add_array.3 man/man3/seccomp_rule_add_exact.3 man/man3/seccomp_rule_add_exact_array.3 man/man3/seccomp_syscall_priority.3 man/man3/seccomp_syscall_resolve_name.3 man/man3/seccomp_syscall_resolve_name_arch.3 man/man3/seccomp_syscall_resolve_name_rewrite.3 man/man3/seccomp_syscall_resolve_num_arch.3 man/man3/seccomp_version.3 '/usr/local/share/man/man3'
 /bin/mkdir -p '/usr/local/lib/pkgconfig'
 /usr/bin/install -c -m 644 libseccomp.pc '/usr/local/lib/pkgconfig'
+ ldconfig
+ rm -rf /tmp/tmp.oDW03AnM9x
go: downloading github.com/opencontainers/runc v0.1.1
go: downloading github.com/codegangsta/cli v1.22.5
go: downloading github.com/Sirupsen/logrus v1.7.0
go: downloading github.com/coreos/go-systemd v0.0.0-20191104093116-d3cd4ed1dbcf
go: downloading github.com/docker/docker v1.13.1
go: downloading github.com/docker/docker v20.10.3+incompatible
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/godbus/dbus v4.1.0+incompatible
go: downloading github.com/golang/protobuf v1.4.3
go: downloading github.com/opencontainers/runtime-spec v1.0.2
go: downloading github.com/seccomp/libseccomp-golang v0.9.1
go: downloading github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
go: downloading github.com/vishvananda/netlink v1.1.0
go get: github.com/Sirupsen/logrus@none updating to
<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/sirupsen/logrus
	        but was required as: github.com/Sirupsen/logrus
Error: Process completed with exit code 1.

Oh... and runc v0.1.1 ???
downloading github.com/opencontainers/runc v0.1.1

At least the runc-installer script needs fixing; it's combining go get -d and git checkout, which doesn't work anymore (go modules will use the wrong dependencies).
It also looks like that's no longer possible if cgo is used;
go get -d github.com/opencontainers/runc
package github.com/opencontainers/runc
	imports github.com/opencontainers/runc/libcontainer/nsenter: C source files not allowed when not using cgo or SWIG: cloned_binary.c nsexec.c

iirc, with go1.16, it's possible to install runc with go install<EMAIL_ADDRESS>

Perhaps; the only thing what would happen in that case is that runc's  vendor directory won't be used, and there may be other things that make and make install do in their makefile.
I pushed a commit to switch our uses of go get -d to regular git clone (let's see if I did right, and if that works)

I think it's a bug in go modules. v0.1.1 should be < than v1.0.0-rc93; https://semvercompare.azurewebsites.net/?version=0.1.1&version=1.0.0-rc93

https://github.com/containerd/containerd/pull/5056 is green with Go 1.16 GA


How to change a thing attribute from amazon-freertos

Hello. Is it possible to change a Thing attribute directly from the amazon-freertos embedded code and is there any suggestions on how I can do that? Thanks

Hi @Johnnyjax, can you please clarify about what you functionality about the IoT Thing you want to achieve from the application?
If you want to just configure the IoT Thing name of your registered device in AWS IoT Core within the example demos of this repository, you can do so by defining the clientcredentialIOT_THING_NAME macro here?

Hi @aggarw13. What I mean is changing certain thing "attributes" like searchable thing attributes for instance but in run time. Not defining the thing attribute directly in the macro before the device boots up.  So that if for instance, a specific message comes into an mqtt topic that the device is subscribed to, it changes the thing attribute to something else. Just want to know if there's a function available in amazon-freertos for doing that.


[BUG] Ascent value is changed while compare in Windows and Linux Docker environment

Description
I have checked ascent value Calibri font in Windows environment is 10.9 pt and then checked ascent value in Linux Docker environment is 9 pt. Well, the difference is 1.9 pt and I have checked with lastest skiasharp version but the issue is not resolved. Kindly let me know how to get the same ascent value for both Windows and Linux Docker environment.
Code
SKPaint sKPaint = new SKPaint();
sKPaint.Typeface = SKTypeface.FromFamilyName("Calibri", SKFontStyleWeight.Normal, SKFontStyleWidth.Normal, SKFontStyleSlant.Upright);
System.Diagnostics.Debug.WriteLine(sKPaint.FontMetrics.Ascent);

Expected Behavior
10.9
Actual Behavior
9
Basic Information

Version with issue:  1.59.3
IDE:  Visual Studio 2019
Platform Target Frameworks: .NET Core 3.0

Windows OS:  Linux Docker

You are just not using the same physical font. Better load the typeface via stream.

You are just not using the same physical font. Better load the typeface via stream.

Hi @Gillibald ,
But I have physical copy the Calibri font to the Linux container.

Is it properly registered with Fontconfig? Otherwise, it will not be found. Also, make sure that sKPaint.Typeface.Name matches the right name.

Is it properly registered with Fontconfig? Otherwise, it will not be found. Also, make sure that sKPaint.Typeface.Name matches the right name.

Hi @Gillibald ,
I am properly copying the font to Linux Docker and I have checked the sKPaint.Typeface.Name. please find the screenshot below.

I also saw this, almost all the values are the same except that one. When measuring characters, I also notice a 1px width difference in some characters.
However, this might just be the case of different engines for text. Windows uses DirectWrite and Linux uses FontConfig.

Hi,
I have checked the sKPaint.FontMetrics.Leading value for Calibri font in both environment.
In Windows:

Ascent value - 10.47.
Leading value - 0.

In Linux Docker

Ascentvalue - 8.25.
Leading value - 2.42.

Then added the leading value and ascent value from the Linux docker and it is equal to the windows ascent value. All I want is the same ascent value as Windows. So, I just want to know, can we add the leading value to the ascent value?

Just use HarfBuzzSharp and you get consistent results

This seems very much related to #1390

I am having a look at this and it appears that v1.68.3 did not have floating point widths on Windows either. Seems the new functionality is to use floating points on Windows, but kept the original logic on Linux.

However, the reverse is true for the Ascent. Seems Windows had the Ascent of only integers, and Linux used floating points ¯_(ツ)_/¯
But, seems setting IsLinearText = true makes everyone work?

Seems some logic changed from sub-pixel to linear logic in a few places...
m68: https://github.com/google/skia/blob/chrome/m68/src/ports/SkFontHost_win.cpp#L718
m80: https://github.com/google/skia/blob/chrome/m80/src/ports/SkFontHost_win.cpp#L742

Thanks for having a look at this. Will try that out. Fine for me if it is just a flag that has to be set for better customization.

@mattleibow & @Gillibald - Still this issue exist in v2.80.2 version. Could you please let me know whether this issue has resolved or any changes required in our side?

@mattleibow & @Gillibald - Could you please look into this ?

@VijayRM could you create a new issue?
Also, could you mention the fonts you are using, the platform versions, and anything else that will help.
In addition, could you let us know of a few things in this issue you have tried? Maybe some code that you are using to load the font. Is the font leading correctly?

@mattleibow - The original issue reported in this thread was not resolved. Do we want to create new one ?
https://github.com/mono/SkiaSharp/issues/1350#issue-644666536
The ascent value for Calibri font is differs between Windows & Linux Docker environment. Could you please check this ?
Code Snippet:
SKPaint sKPaint = new SKPaint();
sKPaint.Typeface = SKTypeface.FromFamilyName("Calibri", SKFontStyleWeight.Normal, SKFontStyleWidth.Normal, SKFontStyleSlant.Upright);
System.Diagnostics.Debug.WriteLine(sKPaint.FontMetrics.Ascent);

The below code is what we are exactly using in our product:

    public class SkPaintExtension : SKPaint
    {
        public SkPaintExtension(Stream stream, float fontSize) : base()
        {
            this.TextSize = fontSize;
            this.IsAntialias = true;
            this.TextEncoding = SKTextEncoding.Utf8;
            //As per the SkiaSharp team suggestion, enabled SubpixelText property to get valid size in Linux.
            this.SubpixelText = true;
            MemoryStream tempStream = new MemoryStream();
            stream.CopyTo(tempStream);
            stream.Position = 0;
            tempStream.Position = 0;
            this.Typeface = SKTypeface.FromStream(tempStream);
        }
    }

 class Program
    {

        static void Main(string[] args)
        {
            SkPaintExtension skExtension = new SkPaintExtension(new MemoryStream(File.ReadAllBytes(basePath + @"Fonts\calibri.ttf")), 12);
            Console.WriteLine("Ascent - " + skExtension.FontMetrics.Ascent);
            Console.WriteLine("Descent - " + skExtension.FontMetrics.Descent);
            Console.WriteLine("Leading - " + skExtension.FontMetrics.Leading);
}
}

I am using same font file in both platforms.
If you required more details, please let me know. I will share all the possible details.

Could you please provide update on this ?

Any update on this


PR for updating docs theme

This PR modifies the theme to be more like those used in other CMSSW codes (eg the CAT doc pages). No need to merge until we're ready to make that change.

many of the changes are already merged into the main branch - only changes to mkdocs and index are relevant

Hi Nick,
I tried out this theme and the build, it looks good to me, I think its a nice a nice improvement over the current one. And all the various boxes/features etc seem to be working.
The only small thing I noticed, is I think in the current PR it is using an old version of the logo? The one on the pages has the fairly saturated colours, where I thought we were switching to the less saturated version.
NB: I didn't check to make sure the content is unchanged, I have only been checking for style so far.

Hi @kcormi  - thanks, yeah the logo is a little outdated, currently getting the latest and greatest one from Clemens to add in.

Looks good to me - I think probably going with the \mu in the physics model is better since we use that in the paper (and in the rest of the docs I already tried to go through and update to use the paper notation where I could)

Looks good to me - I think probably going with the \mu in the physics model is better since we use that in the paper (and in the rest of the docs I already tried to go through and update to use the paper notation where I could)

Thanks, I've updated it to use $\vec{mu}$ and $y$.
From my side the PR looks ready.


[Release Pipe] Checksum file with release

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
I wonder if we could attach checksum file for each GitHub release of the installer?
This is for double check of the download file.

We can, just extra step.  Like @alannt777 mentioned, WinGet's yaml file requires us to put the hash in it so that is always verified.

Added the Sha256 value to release notes