Fixes #559 by referencing modern password policy.

A suggested solution for #599 links Microsoft's paper on the matter.

@technion Thanks again for the revision. I pulled in your commit, made some changes (retained some text you had removed) and published the changes https://docs.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/maximum-password-age
My intent with pulling in your commit was for you to be listed as a contributor but I'm unsure why that failed. If you want to submit another pull request with a link to https://gist.github.com/technion/65c652194fb1427e6828ea23ff46d280 I'm happy to merge that and that will get you listed as a contributor.


XFA-forms and e-sign are not displayed in svg rendering

Hello, I would be grateful if you guys could tell me if XFA-forms and e-sign are working in the svg-backend, if is not working I hope i helped you to spot this one for the feature .
Until now I used the canvas rendering and XFA-forms and e-sign were seen just fine, but it loses its quality on mobile.  I start working with the svg-backend and quality improved greatly but XFA-forms and e-sign are not seen anymore though I commented the following from annotation.js and recompiled:
if (data.fieldType === 'Sig') {
      data.fieldValue = null;
      this.setFlags(AnnotationFlag.HIDDEN);
}

Configuration:

Chrome latest stable

As mentioned in the Wiki, see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#backends, the SVG back-end isn't officially supported.

The SVG back-end doesn't have support for annotations yet (and therefore also not for AcroForms). This is tracked in #10165 and #7613, so this can be closed as a duplicate.


search app: the sorting stops working sometimes

I played around with different filtering criteria.. and some how the sortby function stops working.. After refresh, the feature works.

let's close this issue for now and reopen if needed.


Add HTTP_STATUS_MAP(XX) and enum http_status

This patch provides an enum for the standardized HTTP status codes.
Additionally, the HTTP_STATUS_MAP(XX) can be used for other purposes as well,
such as code-to-name lookups and code-based switch statements.

For some background, I'm using this in the http://github.com/latchset/tang project. I'm using it for two reasons. First, having named constants for the error codes makes the code more readable. Second, I am using the HTTP_STATUS_MAP(XX) macro in order to create a switch statement for generating reply messages with the appropriate status code text.
I found it useful, and I'm sure that other people will too.

A general +1 to this PR, we're hardcoding a similar lookup table in SSSD as well.

@npmccallum if no one will reply in 2-3 days - please ping me again, I'll make sure to land it immediately!

LGTM

Landed in 335850f, thank you!


Add website documentation for SPM plugins

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

  Generated by :no_entry_sign: dangerJS against e275f4feb50efc420eb042193ebd420e2876dea8

👍

merge on green


UnboundLocalError: local variable 'data' referenced before assignment

Hi,
I'm trying to create a table using pynamodb. Here is the code:
class KIndex(DDBModel):
    class Meta:
        table_name = 'k_index'
        write_capacity_units = 10
        read_capacity_units = 10

    profile_id = UnicodeAttribute(hash_key=True)
    date = UnicodeAttribute(range_key=True)
    value = UnicodeAttribute()

def create_tables():
    if not KIndex.exists():
        KIndex.create_table(wait=True)

Unfortunately, when I run the function create_tables(), I get the following exception:
pynamodb/connection/base.py in get_meta_table(self, table_name, refresh)
    270                 if e.response['Error']['Code'] == 'ResourceNotFoundException':
    271                     raise TableDoesNotExist(e.response['Error']['Message'])
--> 272             self._tables[table_name] = MetaTable(data.get(TABLE_KEY))
    273         return self._tables[table_name]
    274

UnboundLocalError: local variable 'data' referenced before assignment

What did I do wrong?

Looks like it was a bug introduced in the last release, not your fault.

Thank you

I think the problem is more deep than that because now the try in base.py at line 262 doesn't succeed but nothing happens and therefore the statement return self._tables[table_name] raises a keyerror. Do you want me to help you debug it?

Yes, that would be great. My suspicion is that a ClientError is raised, but that the error is not a ResourceNotFoundException. I'm going to push a small change that reraises the original exception.

Indeed:
ClientError: An error occurred (UnrecognizedClientException) when calling the DescribeTable operation: The security token included in the request is invalid.

I'll tweak the code a little bit to print the error message from the client.

Ok in the end it seems that the error is quite straightforward: http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ErrorHandling.html


Remap key to shortcut

I want to remap single key to shortcut
Example: F1 to Ctrl+W
Thanks.

Closing this issue as a duplicate. This feature is being tracked at #3290


pythonPackages.hydrus: 431 -> 434

Motivation for this change
Update hydrus to version 434
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 119032 run on x86_64-linux 1

1 package built:

hydrus

hydrus: Ask if output path share/doc (31.9M) could be split with outputs = [ ... "doc" ];


Always use to_dtype when decoding the pandas Series

Allows decoding a None into np.NaN and correctly uses the datatype when creating each series.
Summary
LightGBM will train missing data with NaN values by default, but if my call to infer has only None value(s) for an input that was trained as a floating point, I get the error:
ValueError: DataFrame.dtypes for data must be int, float or bool.
Did not expect the data types in the following fields: column

Problem:
The datatype is not used when the PandasCodec receives a None value.  Tracing this down, mlserver.codecs.pandas._to_series() only calls  mlserver.codecs.numpy.to_dtype() when given an ndarray, thus for most cases the pd.Series is given raw data.
This problem, while not my prime motivator also seems to result in ignoring other datatypes like INT32 / FP32 incorrectly being inferred as the pandas default of int64/float64.
Given an example where one input is FP32 but with None value, another is FP32, and a third is INT32:
from mlserver.codecs import PandasCodec
from mlserver.types import InferenceRequest, Parameters, RequestInput

df = PandasCodec.decode_request(InferenceRequest(
  parameters=Parameters(content__type='pd'),
  inputs=[
    RequestInput(
      name= "colNan",
      data=[None],  # should be decoded as np.NaN
      datatype="FP32",
      shape=[1],
    ),
    RequestInput(
      name= "colFloat",
      data=[3.14],
      datatype="FP32",  # should be decoded as dtype float32
      shape=[1],
    ),
    RequestInput(
      name= "colInt",
      data=[512],
      datatype="INT32",  # should be decoded as dtype int32
      shape=[1],
    ),
  ]
))

At present, the df.dtype is:
colNan       object <-- FP32 not converted to float with np.NaN
colFloat    float64  <-- not converted to float32
colInt        int64   <-- not converted to int32
dtype: object

With this PR the df.dtype is properly converted and the colNan correctly is a np.NaN:
colNan      float32
colFloat    float32
colInt        int32
dtype: object

Reproduce
Using the LightGBM example, but converted to use the pandas content_type (this is a toy example, I discovered it in my more complex model that is trained with NaN's)
import requests
endpoint = "http://localhost:8080/v2/models/iris-lgb/versions/v0.1.0/infer"

inference_request = {
  "parameters": {
    "content_type": "pd"
  },
  "inputs": [
    {
      "name": "sepal_width_(cm)",
      # "data": [3.5],
      "data": [None],
      "datatype": "FP32",
      "shape": [1],
    },
    {
      "name": "petal_length_(cm)",
      "data": [1.4],
      "datatype": "FP32",
      "shape": [1],
    },
    {
      "name": "petal_width_(cm)",
      "data": [0.2],
      "datatype": "FP32",
      "shape": [1],
    },
    {
      "name": "sepal_length_(cm)",
      "data": [5.1],
      "datatype": "FP32",
      "shape": [1],
    },
  ]
}
response = requests.post(endpoint, json=inference_request)
response.json()

Results in:
ValueError: DataFrame.dtypes for data must be int, float or bool.
Did not expect the data types in the following fields: sepal_width_(cm)

With the PR applied, the response is as expected:
{'model_name': 'iris-lgb',
 'model_version': 'v0.1.0',
 'id': '1aea9a57-e1b4-4e81-abfb-fb969ca35982',
 'parameters': {'content_type': None, 'headers': None},
 'outputs': [{'name': 'predict',
   'shape': [1, 3],
   'datatype': 'FP64',
   'parameters': None,
   'data': [0.22063813971842786, 0.001247537667425619, 0.7781143226141466]}]}

Note
I had to special case the BYTES to not use to_dtype, as it seemed to break the tests by returning single-byte characters -- perhaps there is a better approach?
Happy to adjust tests or code as needed.

Hey @johnpaulett ,
Just as a heads up, the test failure for Python 3.7 seems to be a flaky one introduced recently. So if you get a chance to just fix the linter, we should be able to merge this one. :rocket:

@adriangonz Thanks!
Pushed a fix for the flake8 failure.  Not sure you're preference, can locally squash into my prior commit and force push if better.


Sending SQL query params in the URI can hit URI limits and respond with a 414

Describe the bug
When sending a query over the HTTP interface (using this lib), if the query_params option is too big, we run into HTTP URI limits. 414 Request-URI Too Large
The reason our query_params is so large is because we're using a WHERE...IN clause. The obvious fix/workaround is to have smaller batches and thus make smaller queries, however this affects our throughput overhead.
I was wondering if there is any scope/ability to pass the query params in the HTTP body instead of the URL query string.
You could argue that this isn't necessary and the current workaround is sufficient, but I thought I'd ask.
Steps to reproduce
Write a query with very large query_params, like so:
const visitorIds = Array(5000).fill(undefined).map((_, i) => `visitor${i}`); // the point is to make this BIG

const resultSet = await this.client.query({
    query: `SELECT * FROM test WHERE visitorId IN splitByChar(',', {visitorIds:String}),
    query_params: {
      visitorIds: visitorIds.join(','),
    },
});

const dataset = await resultSet.json();

// etc

If you run something like the above, you will see a HTTP 414 response error because the HTTP request made by the client is too large
Expected behaviour
I'd expect to be able to send the query params over the BODY instead of being part of the URI, and I'd expect to be able to configure this via the client interface somehow. Like clickhouse_settings: {send_params_as_body: true}} or something similar.
I appreciate this change would also require ClickHouse to handle this also, which requires additional collaboration.
Code example
Proposed fix?
const resultSet = await this.client.query({
    query: `SELECT * FROM test WHERE visitorId IN splitByChar(',', {visitorIds:String}),
    query_params: {
      visitorIds: visitorIds.join(','),
    },
    clickhouse_settings: {
      some_option_to_send_params_as_body_instead: true,
    }
});

Error log
Error:
<title>414 Request-URI Too Large</title>

414 Request-URI Too Large

    at parseError (/home/admin/82df98d7a6f1f8e536b97a6c49ef845a432b4869/node_modules/@clickhouse/client/dist/error/parse_error.js:35:16)
    at ClientRequest.onResponse (/home/admin/82df98d7a6f1f8e536b97a6c49ef845a432b4869/node_modules/@clickhouse/client/dist/connection/adapter/base_http_adapter.js:127:51)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Configuration
All default except:
{
    host: url + ':' + port,
    username: username,
    password: password,
    log: debug ? {LoggerClass: DefaultLogger} : undefined,

    // When using a debugger, it's helpful to extend these timeouts
    connect_timeout: __DEV__ ? 1 * 60 * 1000 : undefined, // 1 minutes for dev, or default
    request_timeout: __DEV__ ? 10 * 60 * 1000 : undefined, // 10 minutes for dev, or default
}

Environment

Client version: 0.0.12
Language version: TypeScript 4.9.5
OS: Debian GNU/Linux 11 (bullseye) Release:11

ClickHouse server

ClickHouse Server version: 22.12.3 revision 54461
ClickHouse Server non-default settings, if any: None

Is it CH Cloud or on-premise deployment?
Could it be that it's an LB or proxy that has a request size limitation?
You could also try increasing http_max_uri_size (see the docs), cause it's 1 Megabyte by default:

The size of the URL is limited to 1 MiB by default, this can be changed with the http_max_uri_size setting

It is hosted on AWS and I think it could be a LB issue. I missed the http_max_uri_size option so I will attempt that!
Thank you very much for your response!


fix!: remove libStorage helper to remove incompatibilities

The mockLibStorageUpload was introduced to mock the @aws-sdk/lib-storage Upload method. In fact, it just mocks two underlying Commands from @aws-sdk/client-s3 used by the Upload method.
Since it was mocking @aws-sdk/client-s3 Commands, the library needed a dependency on the @aws-sdk/client-s3 and @aws-sdk/types. For users that did not use the client-s3 or lib-storage at all and did not specify it as a dependency by themselves in package.json, those two packages, specified as peer dependencies, were installed automatically by the NPM v7 and newer.
However, automatically installing the @aws-sdk/types in the latest available version often lead to it being incompatible with the versions of @aws-sdk/client-* packages, resulting in type errors and other other issues.
To fix this, in v1.0.0 the @aws-sdk/types and @aws-sdk/client-s3 were removed from the peer dependencies. The idea was to expose the mockLibStorageUpload from a separate path (aws-sdk-client-mock/libStorage). Not having the mockLibStorageUpload exposed in the main index.ts made the library work just fine without @aws-sdk/types and @aws-sdk/client-s3 installed. Users that wanted to use mockLibStorageUpload had to install those two libraries.
mockLibStorageUpload function was exposed under a aws-sdk-client-mock/libStorage path with the new package.json exports parameter. However, adding this parameter turned out to cause various effects and incompatibilities depending on the user's project configuration.
The mockLibStorageUpload helper was mocking just two client-s3 Commands. This is trivial and short to implement yourself when needed. Since the helper was constantly causing problems since it was added, I decided it will be better to remove it altogether and replace with a short instruction in the README on how to mock the libStorage yourself.

Codecov Report

Merging #105 (26311f1) into main (7ee8044) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         6    -1
  Lines          165       157    -8
  Branches        22        21    -1
=========================================
- Hits           165       157    -8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee8044...26311f1. Read the comment docs.


added support for armv6-linux-guneabihf and riscv64-linux-{gnu,musl}

Hi this PR added support for building libedgetpu for armv6-linux-guneabihf and riscv64-linux-{gnu,musl}. It allows old armv6 devices to be able to use edgetpu devices with Tensorflow Lite, and builds for newer riscv64 single board computers.
It should be able to generate libedgetpu runtime binaries as in https://github.com/cocoa-xu/libedgetpu/releases/tag/v0.1.8, which have been used in my Erlang/OTP binding for TensorFlow Lite tflite_beam for about a year.

@cocoa-xu any reason to close this PR?
I was looking at it :)

Hi @Namburger, I closed this PR because it appeared that no one was interested in adding support for armv6 and riscv64 devices for this library, and was planning to maintain the support on my own fork.

@cocoa-xu I see, I was going to ask you for your usages/test devices. I haven't use an armv6 device in a long time and don't have one to readily test your PR.

@cocoa-xu I see, I was going to ask you for your usages
As for the usages, my motivation is that if this library can be used on armv6/riscv64 devices, it allows users to use edgetpus with old armv6 boards like RPi 0, and newer riscv64 boards like SiFive.

And there were some attempts from users in the pycoral repo asking for armv6 support, https://github.com/google-coral/pycoral/issues/8, https://github.com/google-coral/edgetpu/issues/229#issuecomment-751504398, https://github.com/google-coral/pycoral/issues/7. But the solution was outdated and never in the official codebase.

...test devices.
As for test devices, I have a RPi 0 (armv6), Mangopi Pro (riscv64) and a VisionFive 2 (riscv64).

Interesting, I didn't know RPi 0 is armv6 o_0

And there were some attempts from users who wanted to bring back armv6 support in the pycoral repo, google-coral/pycoral#8, google-coral/edgetpu#229 (comment), google-coral/pycoral#7. But the solution was outdated and never in the official codebase.

I remember all of those issues, as you could tell it has been awhile since I'm involved with coral so there is a ton of catching up to do :)
Please re-open, I'll take a look at this PR sometimes this week!

I remember all of those issues, as you could tell it has been awhile since I'm involved with coral so there is a ton of catching up to do :)

Please re-open, I'll take a look at this PR sometimes this week!

No problem! I've re-opened this PR, and I'm happy to do further changes. :)

Quick question: libedgetpu requires tflite_runtime. This has support for arm6, but does it have also support for riscv64?

Quick question: libedgetpu requires tflite_runtime. This has support for arm6, but does it have also support for riscv64?

Yes, we can use tflite on riscv64 boards!
And we also have prebuilt images for a riscv64 board, MangoPi MQ Pro. Although TensorFlow may or may not have optimisations for riscv64 CPUs, there are prebuilt livebook images (tflite is included as a dependency) available for MangoPi MQ Pro here (also see the livebook release page and the tflite_beam release page).

And below is a screenshot of tflite (as an Erlang/Elixir binding) running on a riscv64 board in livebook. I'm using mobilenet_v2_1.0_224_inat_bird_quant.tflite and the sample image as the testing neural network and input. It took 7.6 seconds to do the inference task without the coral device (as the device is not with me at the moment, but I tested it before).

Just eager to see progress on this as it's been 4 years without arm6 support. Thank you @cocoa-xu

Hi @Namburger, @feranick, it seems that this PR is kinda stale, would it be easier for us all if I split this into a few smaller PRs?

This is not my call to make as I have no admin access to the repo.

This is not my call to make as I have no admin access to the repo.

Oops.. sorry for the wrong ping!


Allow StructuredProfiler to be able to support duplicate columns

This required a refactor of StructuredProfiler._profile and report['data_stats'] to both become lists, that are accompanied by mappings (aka schemas) that map column name to a list of indices in the lists corresponding to columns of that name. This refactor also included some test updates, new tests, and documentation changes. This refactor was done in 3 separate PRs into a separate branch for review (#291, #303, #312) that have all been approved and merged, but this PR is to merge all the changes from those into Main, and integrate with new features added since the start of this refactor.

Basically the only new code here pertains to correlations (_get_correlation, _merge_correlation, some tests) as all other code related to the refactor was already approved in a separate branch, but during that time correlation was added to the main branch and was not yet compatible with these new _profile paradigms.


Separate concerns: split into multiple plugins

Currently, bmax query parser does pretty much everything from parsing, detecting boost terms and penalize terms and applies all that into a single query. To be more open for extension, split functionality into the following parts:

bmax-booster: A plugin that extracts boost and penalize terms e.g. from a fieldType and inserts them as a boost query into the bq field and as a rerank query respectivly. This makes the booster compatible with other query parsers like querqy and edismax

bmax-bq-cache Pick up bq params and cache per document boostings. Append the cache as a boost function (that could be cached as well)

bmax-boost-cache Make the internal @shopping24 boost cache functionality public

done


ridgeline plot

The ridgeline plot example (https://observablehq.com/@observablehq/plot-ridgeline@570) was broken by the “fix z-order of marks across facets” feature of https://github.com/observablehq/plot/releases/tag/v0.6.7 (see https://observablehq.com/@observablehq/plot-ridgeline@566, where the black top lines are not hidden by the grey areas any more)

For now I've fixed it with a render transform (https://observablehq.com/@observablehq/plot-ridgeline@601). Do need to introduce a "topLineStroke” option to areaY?

There was simpler solution by layering as many marks as there are facets: https://observablehq.com/@observablehq/plot-ridgeline@612. Maybe we don't need that extra option, then…


Use the cloud API in token provider

Related:

#24

Design discussion:

https://github.com/grafana/grafana/discussions/61016

Fixed by #85


[fix][build] Fix Dockerfile's apt configuration so that retries would work

Motivation
Building the docker file fails often with this kind of error:
[INFO] DOCKER> Err:5 https://packages.adoptium.net/artifactory/deb jammy/main amd64 temurin-17-jdk amd64 <IP_ADDRESS>.0+9
  Error reading from server. Remote end closed connection [IP: <IP_ADDRESS> 443]
[INFO] DOCKER> [91mE: Failed to fetch https://packages.adoptium.net/artifactory/deb/pool/main/t/temurin-17/temurin-17-jdk_<IP_ADDRESS>.0%2b9_amd64.deb  Error reading from server. Remote end closed connection [IP: <IP_ADDRESS> 443]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Modifications
It appears that the apt configuration is invalid. the echo command is missing the -e flag. Add this flag so that the apt custom config becomes correct. The assumption is that timeouts or retries are currently invalid when the apt config file is invalid. This change will fix that issue and hopefully address the package download issue.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

It looks like it was already correct. The problem must be something else.


[Gap closing][Feature Parity] Adding local files and resources to a component archive

What would you like to be added:
Why is this needed:

I guess this can be closed, right ? adding local resources is possible with OCM client, e.g. see here in this example: https://ocm.software/docs/guides/getting-started-with-ocm-flux/#adding-resources.
So if this is what you meant with this feature, we can close this task.

Yep. Thanks! :)


enable mypy

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)

[ ] New feature (non-breaking change which adds functionality)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.


Proper support for Windows 8.1 and 10

Added app.manifest in Server and Client and added some code in Core.Helper.PlatformHelper.cs

Thanks, great addition. :)


chore: bump version of happy cleanup

Fixing a couple parsing bugs
Summary:

What: <brief description>
Ticket: sc<fill_in_issue_number>
Env: <rdev link>

Demos:
Notes:
Checklist:

[ ] I merged latest <base branch>
[ ] I manually verified the change
[ ] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

is this moot now?

yes


Session support for HTTP middleware

This is a draft implementation of the ideas from #86.
lib/backend/session_storage/redis.coffee
Socketstream session storage was reimplemented to use the same format as connect-redis. Note that:

key prefix is not applicable anymore
built-in redis data expiration feature is used in the setex Redis API call so expired sessions don't overflow the storage
implementations of set and delete are a bit cludgy, as connect-redis stores just JSON strings

It was not possible to use the abstract interface of connect-redis because it depends on internal Session object of connect and transitively on HTTP req object of connect.
lib/frontend/client/cached/lib.min.js
I think this file should be removed from source control and re-generated each time the assets are minified. It was changed because of lib/frontend/client/socketstream.coffee was changed.
lib/frontend/client/socketstream.coffee
I removed session generation and verification from socketstream - now a cryptographically secure (signed by hmac-sha256) session identifier is always generated by connect, and socketstream only uses an existing session.
Also I changed the cookie name to match that of connect.session.
lib/frontend/http_middleware/index.coffee
connect.cookieparser middleware, connect.session middleware and connect-redis plugin to connect.session were added at the top of your Stack

Hi there
Going to close this now. 0.3 is not going to be based on any 0.2 code at all - I've decided against that.
I'd love to get your thoughts on the code, particularly around sessions, once I put it on github.
Owen


Indentation does not seem to work

I have treesitter installed and enabled, fish language installed and indentation enabled for all languages.
How ever, fish files don't get automatic indentation. That is, if I type
if true

and press Enter, I get a cursor in the same indent as i:
if true
|

when the correct cursor should be indented:
if true
    |

Before migrating to treesitter, I used dag/vim-fish and indentation worked.
Indentation in other languages works.
Is this a problem with this language spec? How can I help debug and solve this?

When your example is parsed the following tree is the result:
(program [0, 0] - [1, 0]
  (ERROR [0, 0] - [1, 0]
    (command [0, 3] - [0, 7]
      name: (word [0, 3] - [0, 7]))))

In nvim-treesitter  the indent capture name is defined for some nodes but none of the above is among them.
In order for the indent to work, end is needed so that the source file produces valid tree when parsed.
if test|
end
# After enter
if test
    |
end

In order for your example if test to work this grammar would need to be more relaxed.
Probably rewritten with such use cases in mind in the first place.

Thank you for your response. Could this be achieved somehow? Or is this impossible for treesitter?

One way to achieve indent working for your example is to update indent.scm queries.
Here is an example of such query with ERROR node for python:
https://github.com/nvim-treesitter/nvim-treesitter/blob/4cc201ecd9840562ed8822af607966e3303df228/queries/python/indents.scm#L34
If you have time to play around with nvim-treesitter and see if you can create such query so the indent works see:

Adding queries - nvim-treesitter
Tree-sitter docs about queries
Neovim docs about supported query predicates


Proper more messages (memo) in transaction displaying

Is your feature request related to a problem? Please describe.
We'd like to introduce a better UX/UI for more messages in a transaction.
For now, we simply concat messages into a string separated by \n\n. The implemented logic uses the same text style for all concatenated messages.
Describe the solution you'd like

Alternatives you've considered

Additional context

Superseded by #1418


Fix Event Selection

Description
This PR fixes event selection. But I think slows it down in the process.

This is being fixed in #50


Crashing Firefox 45 and 46

Hello. This addon is crashing versions 45 and 46 of Firefox.
I haven't tried it on other desktop than Xfce 4.12, but I had tried on both OpenBSD-current and Xubuntu 16.04 LTS.
Disabling the addon stops crashing Firefox.
How to reproduce:

Open Firefox 45 or 46.
Select 'New Window' or 'New Private Window' in the burger menu.
Again, select 'New Window' or 'New Private Window' in the burger menu.
Firefox is now crashed.

Thanks in advance.

Are you also using HTTPS-Everywhere?  I seem to be experiencing the same bug but i found it to only happen when both Beef Taco and HTTPS-E are enabled.  Firefox 47 on Ubuntu 14.04 here.  Beef Taco is <IP_ADDRESS>-signed.1-signed.  See https://github.com/EFForg/https-everywhere/issues/4661#issuecomment-228529433

Yes, but I disabled it for testing which addon/plugin was the one crashing

+1, my Firefox instance has been entering an infinite loop every time I tried to open a new window, until I disabled Beef Taco. Given how long it has been since the project was last updated, though, I'm not expecting for the owner to start maintaining it again. I'm just confirming the issue to make it easier for other users to troubleshoot the same thing.

+1, my Firefox instance has been entering an infinite loop every time I tried to open a new window, until I disabled Beef Taco. Given how long it has been since the project was last updated, though, I'm not expecting for the owner to start maintaining it again. I'm just confirming the issue to make it easier for other users to troubleshoot the same thing.


libheif not found WSA/Android ImageSharp

Thanks for this library, very helpful for what I am working on.
I am trying to load an HEIC image using ImageSharp using this library. It works on windows but when I try to load it on android (I am using WSA, haven't gotten a chance to test on actual device but I would imagine it being the same), I get libheif not found.
I have installed both 'LibHeif.Native.win-x64' and 'LibHeif.Native.linux-x64'. for some reason 'LibHeif.Native' give me errors so I had install both separately.
System.DllNotFoundException: 'libheif'
[HeifDecoderImpl] getSize: not supported!
[HeifDecoderImpl] getSize: not supported!
Loaded assembly: LibHeifSharp.dll [External]
[monodroid-assembly] Shared library 'libheif' not loaded, p/invoke 'heif_get_version_number' may fail
[monodroid-assembly] Shared library 'libheif' not loaded, p/invoke 'heif_get_version_number' may fail
[HeifDecoderImpl] getSize: not supported!
[HeifDecoderImpl] getSize: not supported!
[HeifDecoderImpl] getSize: not supported!
**System.DllNotFoundException:** 'libheif'```

I know heic is an ios specific image type but I wanted to cover all user scenarios (i.e. if a user has saved an heic image in file system and wants to load that)

For runtimes other than linux x64/windows x64 you will need to get build of libheif for ARM runtime.
I think this is only way to get work libheif-sharp on android devices.

For runtimes other than linux x64/windows x64 you will need to get build of libheif for ARM runtime.
I think this is only way to get work libheif-sharp on android devices.

Are there any steps on how to incorporate the ARM build for this to work?
Also there is this libheif-dotnet bindings project primarily for libheif in dotnet. Can that be used for the necessary builds?

@hey-red when I get access to .so files https://github.com/0xC0000054/libheif-sharp/issues/9#issuecomment-1715904494 required for android. do I have to add similar code as linux/win build src files

@hey-red I get “dll not found” on an iOS device as well. Is that expected? I would think it would be supported on iOS as that it the most common os which supports heif images

@hey-red would it be possible if you could add support for android and ios in the library itself? I tried few things but I never got this working.
Since you have already the system/steps sorted with the builds for linux and windows, it would be very helpful to get it working on android and ios as well.


usm: Refactor GoTLS monitor with new uprobe attacher

What does this PR do?
As a followup to https://github.com/DataDog/datadog-agent/pull/27663, this PR modifies the GoTLS monitor to use the new uprobe attacher.
Motivation
Simplify code and use a single type to manage uprobe attachments.
Additional Notes
Performance tests were done on the load-test environment, with no significant changes.

soak_test
Dashboard
Resource usage

Accuracy:

processes
Dashboard
Resource usage

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

/trigger-ci

/merge


Custom Domain setup for fts docs

see guide https://github.com/Ruben-Arushanyan/docusaurus-boilerplates/blob/master/classic_instructions.md#custom-domain-optional

https://github.com/fluxtech-me/fts/pull/3


Class refactor

Significant refactor of the DocumentGraph structure

Only the getContentGroup change is required to avoid a huge bug, others are just nice to have and could be added in future revisions.


Cant start api-server

Hi!
I want to start the api-server with an llama2 7b model. When I try to start the server via wasmedge --dir .:. --nn-preload default:GGML:AUTO:llama-2-7b-chat.Q5_K_M.gguf llama-api-server.wasm -p llama-2-chat I get the following response:
unknown option: nn-preload
Any idea why the server doesn't start?

Hi, sorry for asking the obvious -- did you have the GGUF file downloaded in your current directory?
Did you install WasmEdge with the GGML plugin? It is in the install command in the README.
Also try the llama-chat.wasm app in the chat/ folder to see if it works. Thanks.

Okay, I didnt installed the GGML Plugin. With the plugin the server starts! Thanks :)
Do you think it would be helpful to add this information to this instruction?
https://github.com/second-state/llama-utils/tree/main/api-server

Thanks! Installation is covered here:
https://github.com/second-state/llama-utils/tree/main#requirements
But I agree it is too far removed. Would you mind to send a PR to include a link to the requirements at the top of the api-server README? 😂

I added the new link to the README and kept the link to the documentation, so others can find more information about the installation process. Have a look!


[FEA] JSON: Basic Reader for String type

This is probably one of the largest tasks.  Once we have a CUDF API #4133 we need to start using it. I think the first type we would want to support is just strings.  Even then it will likely need to be off by default for compatibility reasons.
This will need to

Setup a basic JSON reader similar to the CSV reader that uses the Hadoop Line Reader and possibly normalizes the line separation as it produces batches of data.  Ideally as much of this batching as possible should be generalized to a common class/trait that can be shared by both the CVS and JSON code.
Check the JSON config, similar to the CSV config, to verify that all of the settings are things that we can support.  If we run into issues where a default setting is not something that we can really support we will need to evaluate if this is an incompatibility that we just document or if it is something we have to fix/have off by default. Note that I initially looked at these here, but this was from reading the code. All of these should be verified once we actually have java APIs we can play with.
An extensive set of tests to verify that the string reading is working, and that we fall back to the CPU in various cases covered by the configs.  This might be a little hard because Spark itself does not have a great set of tests.

blocked by https://github.com/rapidsai/cudf/issues/9990

For now, the experimental JSON reader can work, https://github.com/NVIDIA/spark-rapids/issues/4135 is merged. Close this issue


Authorization result: invalid but was working for a long time

Hello, been using this for a bit and had one issue that was easily identified and resolved. THIS time for some reason nothing has changed but for some reason cert is not being issued anymore. I've tried things like creating a new folder '/.well-known/acme-challenge' , tried moving 'static handler' above 'extensionless' ... what's interesting is this has been working for the last couple renewals.
The frustration here is we need this working. Can we follow up maybe do some patreon.
Here's the log on test and verbose
C:\Program Files\winacmenew>wacs --test --verbose
[VERB] Verbose mode logging enabled
[VERB] ExePath: C:\Program Files\winacmenew\wacs.exe
[VERB] ResourcePath: C:\Program Files\winacmenew
[VERB] PluginPath: C:\Program Files\winacmenew
[VERB] Looking for settings.json in C:\Program Files\winacmenew
[DBUG] Config folder: C:\ProgramData\win-acme\acme-staging-v02.api.letsencrypt.org
[DBUG] Log path: C:\ProgramData\win-acme\acme-staging-v02.api.letsencrypt.org\Log
[DBUG] Cache path: C:\ProgramData\win-acme\acme-staging-v02.api.letsencrypt.org\Certificates
[VERB] W3SVC detected and running
[VERB] No FTPSVC detected
[DBUG] secrets.json not found
[VERB] Arguments: --test --verbose
[DBUG] Renewal period: 55 days
[VERB] Sending e-mails False
[INFO] A simple Windows ACMEv2 client (WACS)
[INFO] Software version <IP_ADDRESS>9 (release, trimmed, standalone, 64-bit)
[INFO] Connecting to https://acme-staging-v02.api.letsencrypt.org/...
[DBUG] Send GET to https://acme-staging-v02.api.letsencrypt.org/directory
[VERB] Request completed with status OK
[DBUG] Send GET to https://acme-staging-v02.api.letsencrypt.org/
[VERB] Request completed with status OK
[DBUG] Connection failed: Unable to parse response content
[INFO] Connection OK!
[DBUG] Running with administrator credentials
[DBUG] IIS version 10.0
[WARN] Scheduled task not configured yet
[INFO] Please report issues at https://github.com/win-acme/win-acme
[VERB] Unicode display test: Chinese/語言 Russian/язык Arab/لغة
N: Create certificate (default settings)
M: Create certificate (full options)
R: Run renewals (0 currently due)
A: Manage renewals (0 total)
O: More options...
Q: Quit
Please choose from the menu: n
[INFO] Running in mode: Interactive, Simple, Test
[VERB] Adding <IP_ADDRESS> as DNS server
[VERB] Adding <IP_ADDRESS> as DNS server
[VERB] Adding <IP_ADDRESS> as DNS server
[DBUG] Scanning IIS sites
[DBUG] Scanning IIS bindings for hosts
Please select which website(s) should be scanned for host names. You may
input one or more site identifiers (comma-separated) to filter by those
sites, or alternatively leave the input empty to scan all websites.
3: inventory.rdiequip.com (1 binding)
2: rdihost (1 binding)
Site identifier(s) or  to choose all: 2
[VERB] 2 named bindings found in IIS
[DBUG] Filtering based on binding type
[DBUG] Filtering by site(s) [2]
[VERB] 1 bindings remaining after site filter
[VERB] No host filter applied
[VERB] 1 matching binding found
1: timesheet.rdiequip.com (Site 2)
Listed above are the bindings found on the selected site(s). By default all
of them will be included, but you may either pick specific ones by typing the
host names or identifiers (comma-separated) or filter them using one of the
options from the menu.
P: Pick bindings based on a search pattern
A: Pick all bindings
Binding identifiers(s) or menu option: a
[VERB] 2 named bindings found in IIS
[DBUG] Filtering based on binding type
[DBUG] Filtering by site(s) [2]
[VERB] 1 bindings remaining after site filter
[VERB] No host filter applied
[VERB] 1 matching binding found
[VERB] 2 named bindings found in IIS
[DBUG] Filtering based on binding type
[DBUG] Filtering by site(s) [2]
[VERB] 1 bindings remaining after site filter
[VERB] No host filter applied
[VERB] 1 matching binding found
1: timesheet.rdiequip.com (Site 2)
Continue with this selection? (y*/n) - yes
[DBUG] Scanning IIS bindings for hosts
[VERB] 2 named bindings found in IIS
[DBUG] Filtering based on binding type
[DBUG] Filtering by site(s) [2]
[VERB] 1 bindings remaining after site filter
[VERB] No host filter applied
[VERB] 1 matching binding found
[DBUG] Scanning IIS sites
[INFO] Source generated using plugin IIS: timesheet.rdiequip.com
[VERB] No value provided for --validationport
[VERB] No value provided for --validationprotocol
[VERB] Flag --ocsp-must-staple not present
[VERB] Flag --reuse-privatekey not present
[VERB] No value provided for --certificatestore
[VERB] Flag --keepexisting not present
[VERB] No value provided for --acl-fullcontrol
[VERB] No value provided for --certificatestore
[VERB] No value provided for --sslport
[VERB] No value provided for --sslipaddress
[DBUG] Scanning IIS bindings for hosts
[VERB] 2 named bindings found in IIS
[DBUG] Filtering based on binding type
[DBUG] Filtering by site(s) [2]
[VERB] 1 bindings remaining after site filter
[VERB] No host filter applied
[VERB] 1 matching binding found
[DBUG] Scanning IIS sites
[VERB] Source converted into 1 order(s)
[DBUG] Reading certificate cache
[DBUG] No cache files found for renewal
[DBUG] Reading certificate cache
[DBUG] No cache files found for renewal
[VERB] Obtain order details for Main
[DBUG] Refreshing cached order
[DBUG] Refreshing order...
[VERB] Constructing ACME protocol client...
[VERB] Getting service directory...
[DBUG] Send GET to https://acme-staging-v02.api.letsencrypt.org/directory
[VERB] Request completed with status OK
[DBUG] Loading signer from C:\ProgramData\win-acme\acme-staging-v02.api.letsencrypt.org\Signer_v2
[DBUG] Loading account from C:\ProgramData\win-acme\acme-staging-v02.api.letsencrypt.org\Registration_v2
[VERB] Using existing ACME account
[VERB] ACME client initialized
[DBUG] Send HEAD to https://acme-staging-v02.api.letsencrypt.org/acme/new-nonce
[VERB] Request completed with status OK
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/order/70118914/4279860864
[VERB] Request completed with status OK
[WARN] Cached order has status invalid, discarding
[VERB] Creating order for hosts: ["DnsName: timesheet.rdiequip.com"]
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/new-order
[VERB] Request completed with status Created
[VERB] Order https://acme-staging-v02.api.letsencrypt.org/acme/order/70118914/4279937954 created
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/3763525914
[VERB] Request completed with status OK
[VERB] Handle authorization 1/1
[INFO] [timesheet.rdiequip.com] Authorizing...
[VERB] [timesheet.rdiequip.com] Initial authorization status: pending
[VERB] [timesheet.rdiequip.com] Challenge types available: ["http-01", "dns-01", "tls-alpn-01"]
[VERB] [timesheet.rdiequip.com] Initial challenge status: pending
[INFO] [timesheet.rdiequip.com] Authorizing using http-01 validation (SelfHosting)
[VERB] Starting commit stage
[VERB] Commit was succesful
[DBUG] [timesheet.rdiequip.com] Submitting challenge answer
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/3763525914/7wi6Vw
[VERB] Request completed with status OK
[DBUG] Refreshing authorization (1/15)
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/3763525914/7wi6Vw
[VERB] Request completed with status OK
[DBUG] Refreshing authorization (2/15)
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/3763525914/7wi6Vw
[VERB] Request completed with status OK
[DBUG] Refreshing authorization (3/15)
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/chall-v3/3763525914/7wi6Vw
[VERB] Request completed with status OK
[EROR] [timesheet.rdiequip.com] Authorization result: invalid
[EROR] [timesheet.rdiequip.com] {
"type": "urn:ietf:params:acme:error:connection",
"detail": "<IP_ADDRESS>: Fetching http://timesheet.rdiequip.com/.well-known/acme-challenge/ScwBHbKl_Wl495xW6nixUbXogkoddWvsBw2e4lgKWlA: Timeout during connect (likely firewall problem)",
"status": 400
}
[VERB] Starting post-validation cleanup
[VERB] Post-validation cleanup was succesful
[INFO] [timesheet.rdiequip.com] Deactivating pending authorization
[DBUG] Send POST to https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/3763525914
[VERB] Request completed with status OK
[VERB] Order 1/1 (Main): error
[VERB] Processing order 1/1: Main
Create certificate failed, retry? (y/n*)

Please close.... this is why you don't listen to clients. They had a modem switch that held the router and only had 443 setup (not 80). Wow.
To skip the lack of proper responses from the client I used telnet to test port 80 and voila... it wasn't open.
Don't skip any troubleshooting steps and ensure test and validations!
Pardons for opening. Will close.
Keep up good work


Greeter kata mauro

Great work @maurocardinali, thanks! feel free to also review my attempt: https://github.com/FromDoppler/tdd-katas/pull/1

🚀


Cors Error

Whenever I try to create a game everything works but when I try to play the game I get a cors error i've tried clearing my cache but nothing is working

@allancoding

That update I just did should have fixed the problem. clear your cache and it should work.


custom yolov4-tiny model runs slower than expected on jetson nano

i have converted a yolov4-tiny model to TRT successfully, but i am getting 10 fps only, which is much lower than the expected result.
i have realized that the TRT model size is 32.3 mbs, when the original model is 23.5mb in size. doesnt converting to TRT reduce the model size?
also do i need to do something prior to converting the model to make it work in 16fp or does the conversion process do that automatically?
thanks

Reducing network size (width and height) can help to a limit. But doing that can reduce the accuracy level of distant objects.

Reducing network size (width and height) can help to a limit. But doing that can reduce the accuracy level of distant objects.

@IbrahimBond  Are you referring to a custom yolov4-tiny model?  How is it different from the pre-trained darknet yolov4-tiny (COCO) model?

@IbrahimBond  Are you referring to a custom yolov4-tiny model?  How is it different from the pre-trained darknet yolov4-tiny (COCO) model?

@jkjung-avt yes i am referring to a custom model i trained. only difference is that it is trained to detect one class. so i have 18 filters in the layer before yolo layer with changing number of classes.

I converted the pre-trained yolov4-tiny-416 model to a TensorRT engine on my Jetson Nano DevKit.  I could get 25.5 FPS when testing it.  And the trt file size (13MB) is roughly half of the original weights file (24MB).

@jkjung-avt yes i am referring to a custom model i trained. only difference is that it is trained to detect one class. so i have 18 filters in the layer before yolo layer with changing number of classes.

I converted the pre-trained yolov4-tiny-416 model to a TensorRT engine on my Jetson Nano DevKit.  I could get 25.5 FPS when testing it.  And the trt file size (13MB) is roughly half of the original weights file (24MB).


Remove linking azure-storage-blobs in azure-data-tables tests

Superseded by https://github.com/Azure/azure-sdk-for-cpp/pull/6141


Update: Set Up Entities, Roles, and Permissions On Your Service

Add some description about Custom Prisma Attributes into this page, so that users get some idea about what the purpose of this field is for.

Also, the screenshot need to be updated so that it includes the Custom Prisma Attributes field.
Also, Custom Prisma Attributes related to an individual field needs to be mentioned in this developer documentation page.

Add a note about the User entity only being able if you enabled Authentication for your service.

This page should be split up into 2 different pages. One should be specifically related to setting up entities. The second page should be specifically set up related to Roles and Permissions.

Many parts of this issue are taken care of in #389. But, before any information regarding Custom Prisma Attributes can be added, we must first merge the Custom Prisma Attributes PR.
CC @GreenMachine01


StylableMessageBox API

About this PR
closes #41
ToDos

[x] agree API with @Nockiro
[x] implement logic
[x] add section to readme
[ ] test different combinations to make sure all combinations look good

Checklist
(Please strikethrough all not applicable points instead of removing them)

[x] I have added a suitable example in the example application
[x] I have updated the documentation in the readme

One thing I just thought of: Do we want to change the size of the MessageBox if a button has a countdown?
Otherwise, it currently looks like this as soon as the timer starts:


Allow installing Python relative deps

This PR allows installing Python relative deps by adding all files to the container before installing. With the Python dep cached installing is very quick.
Fixes https://github.com/railwayapp/nixpacks/issues/373

The best fixes are those that happen by just removing code 😄


Homebrew missing?

https://github.com/tsduck/homebrew-tsduck/blob/master/README.md
this page is error 404 and brew update yields the error:
remote: Repository not found.
fatal: repository 'https://github.com/tsduck/homebrew-tsduck/' not found
Error: tsduck/homebrew-tsduck does not exist! Run `brew untap tsduck/homebrew-tsduck` to remove it.

Is there a problem with Homebrew support right now?

Hi @BartmanEH
TSDuck has been included in the core Homebrew repo for a while.
The one you reference was a private tap I created in the beginning of TSDuck, for TSDuck alone. It has been obsoleted for quite a while and was no longer updated. It has now been removed. Use brew untap as indicated. Now, brew install tsduck works out of the box from the regular Homebrew.

Thank you, Thierry!


[client-v2] Testing the JDBC driver

### Phase 1 - Automated Connector Tests (ETA: 11/22)
- [ ] Metabase (Serge)
- [x] DBeaver Sanity Tests (Sergey)
- [x] clickhouse-r2dbc (Mark)
- [ ] https://github.com/ClickHouse/clickhouse-java/issues/1957
- [x] ~~Advanced example (Paul)~~
- [x] ~~Adapt Clickbench queries (Paul)~~

### Phase 2 - Manual Connector Testing (ETA: 11/22)
- [ ] Tableau (Mark)
- [ ] DataGrip (Paul)
- [ ] TestContainers (Mark)

### Phase 3 - Nice to have testing (ETA: 11/27)
- [ ] Apache Spark (Bentsi)
- [ ] Flink Connector (Sergey)
- [ ] JOOQ (Sergey)

missing the database parameter as per https://clickhouse.com/docs/en/integrations/tableau which means no default database is available for selection

Metabase tests fail on the latest snapshot.
Somewhere in the Metabase internals there is autoCommit = false setting
clojure.lang.ExceptionInfo: Error loading data: INSERT FAILED: setAutoCommit = false not supported

this throws in v2: https://github.com/ClickHouse/clickhouse-java/blob/5e304cba6409fbb62217ffe977c8a86fab23ca84/jdbc-v2/src/main/java/com/clickhouse/jdbc/ConnectionImpl.java#L130-L136
IMO should be just ignored with no-op, cause many standard implementations will try to set these

@slvrtrn
In the new version we are trying to follow JDBC javadoc - if something is not implemented we are throwing exception.
So we have two options:

create a option flag to ignore unimplemented values - the fastest solution
implement simple "transaction" - however it will work only when we build SQL as string. In the future it will not work when we stream data to server (we are not going to support transactions very soon or emulate them on client side)

missing the database parameter as per https://clickhouse.com/docs/en/integrations/tableau which means no default database is available for selection

What is the solution here? I am trying to setup tableau cloud (on desktop) to connect to my xxx database on clickhouse and no tables appear.

@GEORGE-BOAST what driver version do you use? Could you fill in a new bug report?

do

I am using the latest JDBC driver with the latest version of tableau desktop.
I cannot connect using SSL, when not having said box checked, I can connect, however no tables show.
Example;
Code: 62. DB::Exception: Syntax error: failed at position 11 ('.'): .tree_lst;. Expected end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>7 (official build))
Unable to connect to the ClickHouse JDBC by ClickHouse, Inc. server “172.X.X.X”. Check that the server is running and that you have access privileges to the requested database.
Connector Class: clickhouse_jdbc, Version: 0.3.1
For support, contact ClickHouse, Inc..

In the new version we are trying to follow JDBC javadoc - if something is not implemented we are throwing exception.
So we have two options:
So we have two options:

create a option flag to ignore unimplemented values - the fastest solution
implement simple "transaction" - however it will work only when we build SQL as string. In the future it will not work when we stream data to server (we are not going to support transactions very soon or emulate them on client side)

As a user, I think my preferred solution is no-op in case of unsupported standard things. So I guess option one is good.

Code: 62. DB::Exception: Syntax error: failed at position 11 ('.'): .tree_lst;. Expected end of query. (SYNTAX_ERROR) (version <IP_ADDRESS>7 (official build))

AFAIK neither version of the driver modifies the query. please fill a bug report and include the failing query, which you can find in clickhouse system.query_log


Only check for UCAS file download in production

Fix for https://trello.com/c/ziLTnhqD/2960-fix-bug-that-stops-import-from-ucas

Will this break in Sandbox?

@duncanjbrown update to only run in production. On production deployment we need to mark the download as having taken place today UCASMatching::FileDownloadCheck.set_last_sync(Time.zone.now).
This way the check will start working tomorrow and inform us if the download has not taken place again.


Add source map support

Fixes #6
Creates identity source maps for every polymer file. Eventually we may want to read incoming source maps, but we first need to determine if that even makes sense. While it is possible for an inline script tag to contain a source map as a dataUrl, in practice I've never seen this (though I did handle this case in polymer-bundler).
To test this PR, add devtool: 'inline-source-map' to the webpack config object. When served in a browser, the full original HTML source should be available and breakpoints inside script tags should work as expected.

looks good to me 👍


Upgraded Centrifuge uses 3 Honeycomb Blocks at a time.

Hello,
i have 2 Tier 3 Centrifuges rn and about to upgrade to a Tier 5 soon.
I realized that the Tier 3 Centrifuge uses 3 Honeycomb Blocks at a time, in every slot. So if every slot is filled with a Stack of Blocks, it leaves each slot with 61 Blocks, BUT outouts only the items for one Block, so 36 per slot of the main output on the tier 3 Centrifuge. Since i didnt made any Tier 4 i cant say if its the same for those or not.
I now used a regulator from refined storage to limit it to 1 Honeycomb block per slot, though i let u still know. :)
maybe u can find a fix

thx for the Report but with Version are you using?

thx for the Report but with Version are you using?

ctiers-1.16.3-1.5.1.jar

ctiers-1.16.3-1.5.1.jar

hmm.. ok thx i will look what I can do ;)

hmm.. ok thx i will look what I can do ;)

is it fixed ?
:)

is it fixed ?
:)


Fix truncation warning

Closes #2572.

Coverage remained the same at 100.0% when pulling 953dcfb61131452b36a8a59bf24102605037b0ca on issue2572 into c9c5c016a20399151f251ab1e612497821e82b0b on develop.


merging newly added changes from main into cmake branch

in preparation of merging cmake to main

CI failed for usb_preloaded_firmware but PR can me merged anyway. the failure will be handled in the cmake branch


read_operator API

I'm looking into whether wasm2cretonne can use the read_operator interface (discussed in https://github.com/yurydelendik/wasmparser.rs/issues/17). The code is here:
https://github.com/denismerigoux/wasm2cretonne/blob/master/lib/wasm2cretonne/src/code_translator.rs#L236
While it would be possible to construct a BinaryReader at that point, using the range provided from the BeginFunctionBody, however that would require the code to pass around the underlying data buffer, separately from the parser. Since the parser already has the buffer, and knows where it is in the buffer, would it be feasible for the parser to have a read_operator function itself? Or, could the parser have a function that returns its BinaryReader? Or is there a better way to do this?

I added create_binary_reader(), which can create a BinaryReader as BeginFunctionBody state. See 808451451ef67965f2c4b43ea83dbb0159782849

and 2cec415c1637e777d8aa6281d9dc895d74141704 for validation reading


Add menu to window

The idea was picked by the old PowerSDL from MorphOS, but now it was reimplemented by BeWorld even in the MorphOS port of SDL2
https://github.com/BSzili/SDL/commit/bf2c692d3bdc66daf487b48a81fbf134dcd76955
I wonder if it could be possible to integrate a similar functionality also in our SDL2 for AmigaOS4

Moved.


Add BA codes and EIA sector IDs to EIA-860M changelog table

Overview

Add type hints and revise docstring for eia860m extract function
Rename EIA consolidated sector appropriate in eia860m column mappings
Add balancing_authority_code_eia and sector_id_eia to the core_eia860m__changelog_generators table. This required translating the categorical strings used in the EIA-860M to identify sectors to the canonical IDs that are associated with the sectors, defined in core_eia__codes_sector_consolidated.
Add an alembic schema migration to acommodate the new fields.
Re-lock conda depdencies to avoid yanked pytest 8.1.0 version.

Closes #3437
Testing
Currently running the full ETL and integration tests locally...
# To-do list
- [x] For significant ETL changes, ensure the full ETL runs locally (all good except for FKs)
- [x] Ensure docs build, unit & integration tests, and test coverage pass locally (all good except FKs)
- [x] Review the PR yourself and call out any questions or issues you have
- [ ] Clean up BA codes.
- [ ] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.

It turns out that the BA codes in this table are a mess. Cleaning them up now.


fix: fix library checking while installing library on databricks cluster

Summary
Should check library installation status before submitting jobs for databricksTest
Tests
Ran Databricks test
Dependency changes
None.
AB#1759003

/azp run

Codecov Report

Merging #1488 (6bfc7b1) into master (a5792d7) will decrease coverage by 68.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1488       +/-   ##
===========================================
- Coverage   84.31%   16.28%   -68.03%
===========================================
  Files         295      266       -29
  Lines       14793    13507     -1286
  Branches      702      702
===========================================
- Hits        12473     2200    -10273
- Misses       2320    11307     +8987

Impacted Files
Coverage Δ

...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/spark/ml/param/ModelParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/param/DataTypeParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/ByteArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/EvaluatorParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/spark/ml/param/ParamSpaceParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/spark/ml/param/TypedArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/com/microsoft/azure/synapse/ml/stages/udfs.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/spark/ml/param/TransformerParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/spark/ml/LimeNamespaceInjections.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5792d7...6bfc7b1. Read the comment docs.

/azp run


light trucks

regarding
Reduce width of cars #407, to 6 feet, while true doesn't reflect the fact that the fleet in the US has many SUVs/Pickups/Vans (these are referred to as "Light trucks") being sold and used. In fact the most sold "car" in America is the Ford F-150 pickup, Edmunds and the second-best selling is the Silverado  1500, both "full-sized" pickup trucks. While the body width of these vehicles isn't that much larger than a car, they come with standard mirrors which make them MUCH wider. The F-150 is 96.8" (so, just over 8 feet) with standard mirrors, it is 106" (just under 9 feet) with the optional towing mirrors.

Thanks for the comment. We're not likely to change the width of the lanes, but would be happy to accept "light truck" artwork as an alternative.


automatically option chose when there's only one option

Hi,
I would examine an option to automatically chose and option when there's only one option.
e.g. :
aws-sso-cli
? Select the SSO profile. (Use arrow keys)
❯ main

in such case, move on with main... (no need to push "enter")
also for account role choosing:
? Select the account role you wish to assume: (Use arrow keys or type to search)
❯ AdministratorAccess

wdyt ?
Tx

Good Idea! That will speed it up a little especially since you'll often only have 1 role to choose from anyways.
I added it real quick and made a new release.


Migrate to Pipenv

Migrate from pip to Pipenv for Linux setup. Pipenv is the new recommended way of working.
https://docs.pipenv.org
https://github.com/pypa/pipenv

Well not so officially recommended after all https://github.com/pypa/pipenv/commit/5853846f5da171bf29a303f6b545b0a8918958e7


sl-exporter should be open sourced (and archive Half-life)

Once we feel like sl-exporter is good for an MVP release. I suggest open-sourcing it and archive half-life.
It's rare we get feature or support requests for half-life. However, one less project to maintain is a win for SL. Additionally, half-life is not a good solution at scale, and I would not want to encourage teams to use it if they are monitoring more than a handful of nodes.

Put under apache in https://github.com/strangelove-ventures/sl-exporter/commit/971769497c0b836d3bb6103a1d10b831a6e30ca2. Closing ticket.


Improve performance

I realize this is the TS compiler being slow but is there any way we could improve the performance?
~/dev/oss/write-json-file master*
❯ time ./node_modules/.bin/tsd-check
real         1.72
user         2.47
sys          0.12

It shouldn't take 2 seconds to check a simple test file.

I could reduce the time from ~2291,5909 to ~1469,8804ms with the compiler option skipLibCheck: true`.

I could improve it further https://github.com/SamVerschueren/tsd-check/pull/8


geb should delete files that are no longer generated

When I remove designs and regenerate, the previously generated files still exist in the output. They should be deleted.
This should be achievable by using the file list from the existing shadow repository and the current list of files. Basically some mild accounting and file system operations.

done in 0.9.7


ng serve method ip not open in another machines

OS?

Windows 8

Versions.
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.16
node: 6.6.0
os: linux ia32
After instal angular-cli for below step
npm install -g angular-cli
ng new PROJECT_NAME
cd PROJECT_NAME
After given below command
ng serve
http://localhost:4200  and http://<IP_ADDRESS>:4200 is working on same machine only if i open that machine ip with other machine means not opening. How to open the webpage in another machines, like that machine ip is <IP_ADDRESS> means how to open this url http://<IP_ADDRESS>:4200 in other machines browsers in the N/W.

The solution is simple. Just bind to the correct interface address via ng serve --host=<IP_ADDRESS>

@Coksnuss ,
Hi thanks for your reply any possible way to set in file for default ip for run time

@Coksnuss ,
Is building this method but not running in browser
ng serve --host <IP_ADDRESS>

Not sure about the run-time setting. Regarding the binding: Bind to <IP_ADDRESS> (literally).

Looks like the default host address cannot be set in any other way.
The default setting (localhost) is hardcoded (https://github.com/angular/angular-cli/blob/master/packages/angular-cli/commands/serve.ts#L41) and ember CLI seems not to provide an alternative way to specify arguments (other than by passing it as argument switch) (https://ember-cli.com/api/files/lib_models_command.js.html)
However, you may set the PORT environment variable to override the default port 4200

Oh ok we can given manual at build time only correct.

<IP_ADDRESS> is private ip, use the public ip ;)

@fedecordova private that one is ok how can i access in other machines that is a issue :+1:

use a digitalocean droplet, like ubuntu

using following in the package.json makes it accessible to the host machine
ng serve --host  <IP_ADDRESS>

In case you get Invalid Host header, use ng serve --host=<IP_ADDRESS> --disable-host-check

The option '--disable-host-check' is not registered with the serve command. Run ng serve --help for a list of supported options.
I got it working by actually putting my local ip in the host.
ng serve --host=yourLocalIPHere
Hope this helps. :)

@Coksnuss thank you, I write these lines in the .angular-cli.json file
  "defaults": {     "serve": {       "host": "<IP_ADDRESS>",       "port": 4201     },

All fine now XD

@LordAlastair Thanks for pointing that out! Very helpful

If you want to save the effort of adding the --host flag everytime you run your app just add an entry to the 'defaults' prop in the angular-cli.json file like shown below:
.....
"defaults": {
"styleExt": "css",
"component": {},
"serve": {
"host": "<IP_ADDRESS>",
"port": 9876
}

In Dockerfile:
CMD ["ng", "serve", " --host <IP_ADDRESS>", "--port 4201"]

frontend_1   | The option '--port 4201' is not registered with the serve command. Run `ng serve --help` for a list of supported options.
frontend_1   | ** NG Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

Same goes for host is port parameter is not used.

CMD ["ng", "serve", " --host <IP_ADDRESS>", "--port 4201"]

Should be CMD ["ng", "serve", " --host", "<IP_ADDRESS>", "--port", "4201"]
Or even Better
ENTRYPOINT ["ng", "serve"]
CMD [" --host", "<IP_ADDRESS>", "--port", "4201"]

run angular with command -  ng serve --host=<IP_ADDRESS> --disable-host-check
this will disable host check and allow to access with IPAddress

Run angular 4 project with this cmd
ng serve --host  yourIPaddress
i.e. ng serve --host <IP_ADDRESS>

I get   he option '--disable-host-check' is not registered with the serve command. Run `ng serve --help` for a list of supported options.

You guys are superb, i am noob in angular, been looking this answer for few days. Thanks a lot :)

on "serve" put somthing like
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"host": "<IP_ADDRESS>",
"browserTarget": "m3front:build",
"proxyConfig": "proxy.conf.json"
},
"configurations": {
"production": {
"browserTarget": "m3front:build:production"
}
}
}
.....


World of Warcraft crash after upgrading kernel

Software information
After upgrading the kernel, from 6.8.8 to 6.8.9, World of Warcraft crashes after entering the world (after the loading screen). Downgrading to 6.8.8 fixes the issue.
Some in-game graphics settings seems to be able to make the issue go away (namely, reducing view distance with "DirectX 11 Legacy" engine), but under most settings I tried, the crash is here.
System information

Distribution : ArchLinux
GPU: AMD RX 7800 XT
Driver: amdgpu / mesa 1:24.0.6-2
Wine version: tested both with wine-9.8.r0.g6a6e7da9 ( TkG Staging Esync Fsync ) and wine-staging-9.8
DXVK version: v2.3.1

wine.log

Not a dxvk issue https://gitlab.freedesktop.org/drm/amd/-/issues/3343

Yes, I can confirm that it matches every condition in that issue.


What is the calibration.py in get_acc.py

I find that you import calibration in get_acc.py. It seems that it contains a class TempScaling, where can I get this file or repository? Thanks!

Yes, sorry I will update the readme, I have an open-source calibration library here: https://github.com/saurabhgarg1996/calibration. Feel free to use this for TempScaling.


Upgrade pulumi-terraform-bridge to v3.87.0

This PR was generated via $ upgrade-provider pulumiverse/pulumi-grafana --kind=bridge --target-bridge-version=latest.

Upgrading pulumi-terraform-bridge from v3.84.0 to v3.87.0.
Upgrading pulumi-terraform-bridge/pf from v0.37.0 to v0.40.0.

Superseded by #191


Add support for  Globals.Function.CodeUri

Now you can share the CodeUri from from Globals.Function
Before this fix you must set a CodeUri property for each Function.
According to AWS SAM Globals Reference you can set up a common folder for all your handlers.
Globals:
  Function:
    CodeUri: src

Resources:

  FunctionA:
    Type: AWS::Serverless::Function
    Properties:
       Handler: fileA.handler #expected path src/fileA.js -> handler function

  FunctionB:
    Type: AWS::Serverless::Function
    Properties:
       Handler: fileB.handler #expected path src/fileB.js -> handler function

  FunctionC:
    Type: AWS::Serverless::Function
    Properties:
       CodeUri: another #Is override-able
       Handler: fileC.handler #expected path another/fileC.js -> handler function

PS: @buggy you saved my life with this plugin for SAM

Thanks @hsalazr. I've merged the change and will make a new release once I get a few more changes added.

@buggy Thanks for creating this helpful plugin.
Can you release changes in this PR as v0.3.2? We need to currently write redundant CodeUri in template to work with v0.3.1


Support specifying line delimiter character.

For #1060
BufferedReader is replaced with LineReader which is a subclass of BufferedReader.  It runs a custom readLine method if lineDelimiter is specified; its logic is like following:

Read characters to a buffer and traverse the buffer until the line delimiter is found.
If the delimiter not found, read next characters to the buffer
If the delimiter found, return a line and keep offset of the buffer for the next call of readLine
Repeat above until reaching end of stream.

@dmikurube What do you think about this?

@dmikurube
I've updated option name and document as discussed here
https://github.com/embulk/embulk/issues/1060#issuecomment-439197304
please take a look again, thank you 🙏


Disable samples smoke test in arm-appconfiguration

Disabling failing samples in smoke tests

API change check for @azure/arm-appconfiguration
API changes are not detected in this pull request for @azure/arm-appconfiguration

API change check for @azure/search-documents
API changes are not detected in this pull request for @azure/search-documents

API change check for @azure/service-bus
API changes are not detected in this pull request for @azure/service-bus

API change check for @azure/template
API changes are not detected in this pull request for @azure/template

API change check for @azure/web-pubsub
API changes are not detected in this pull request for @azure/web-pubsub

API change check for @azure/ai-text-analytics
API changes are not detected in this pull request for @azure/ai-text-analytics

API change check for @azure/monitor-opentelemetry-exporter
API changes are not detected in this pull request for @azure/monitor-opentelemetry-exporter

API change check for @azure/dtdl-parser
API changes are not detected in this pull request for @azure/dtdl-parser

API change check for @azure/event-hubs
API changes are not detected in this pull request for @azure/event-hubs

API change check for @azure/monitor-query
API changes are not detected in this pull request for @azure/monitor-query

API change check for @azure/data-tables
API changes are not detected in this pull request for @azure/data-tables

API change check for @azure/schema-registry
API changes are not detected in this pull request for @azure/schema-registry

API change check for @azure/ai-form-recognizer
API changes are not detected in this pull request for @azure/ai-form-recognizer

API change check for @azure/schema-registry-avro
API changes are not detected in this pull request for @azure/schema-registry-avro

API change check for @azure/keyvault-certificates
API changes are not detected in this pull request for @azure/keyvault-certificates

API change check for @azure/keyvault-keys
API changes are not detected in this pull request for @azure/keyvault-keys

API change check for @azure/communication-sms
API changes are not detected in this pull request for @azure/communication-sms

API change check for @azure/keyvault-secrets
API changes are not detected in this pull request for @azure/keyvault-secrets

API change check for @azure/communication-chat
API changes are not detected in this pull request for @azure/communication-chat

API change check for @azure/communication-identity
API changes are not detected in this pull request for @azure/communication-identity

API change check for @azure/communication-phone-numbers
API changes are not detected in this pull request for @azure/communication-phone-numbers

API change check for @azure/communication-network-traversal
API changes are not detected in this pull request for @azure/communication-network-traversal

API change check for @azure-tools/communication-short-codes
API changes are not detected in this pull request for @azure-tools/communication-short-codes

API change check for @azure-rest/synapse-access-control
API changes are not detected in this pull request for @azure-rest/synapse-access-control

API change check for @azure/storage-blob
API changes are not detected in this pull request for @azure/storage-blob

API change check for @azure/storage-file-share
API changes are not detected in this pull request for @azure/storage-file-share

API change check for @azure/storage-queue
API changes are not detected in this pull request for @azure/storage-queue

Overall, I think there's a worrying disconnect between the way the smoke-tests look at sample files and the way that dev-tool does. Our samples are already scripts, so couldn't we just run them as scripts in a subprocess? Is there a chance we execute a sample twice if it has an exported main function and a call to main() in the module body?

I agree, I have filed https://github.com/Azure/azure-sdk-for-js/issues/21369 to track the work to consolidate this with dev-tool.

knock! knock!!

"who's there?"
"need to merge main"
"need to merge main who?"
"uh, probably @joheredi but anyone could do it."


Can't enter some letters in Firefox 52

Describe the bug
Im using inputmask 4.0.8 and can't enter Russian letters Х, Ъ, Ж, Э, Б, Ю in a text field with *{*} mask. This doen't happen in recent versions of Firefox or Chrome, or in inputmask 3.x. Also works okay when copy pasting these letters
I've noted that https://keycode.info/ doesn't show event.which for those keys in that Firefox version, unlike all other cases.
These letters are the last ones in corresponding keyboard rows.
Please complete the following information:

OS: Windows 10
Browser: Firefox 52.9.0
Inputmask version: 4.0.8

Additional context
Feeling surprised
Our customer can't upgrade their Firefox version, unfortunately

Turns out the issue was somewhere in our legacy code working with the library; after refactoring a few weird bits it started working fine


adding a new GRAPH folder under DSA  , that will have basic implementation of graphs, and some common traversal algorithms of graphs, please assign it to me

Assigning you @Harshvg2021

@Harshvg2021 Any updates?


Support CSR matrix multiply

This PR is to support csr_matrix.multiply.
See https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.csr_matrix.multiply.html

Close #2675

@pentschev @emcastillo @asi1024 We are hoping this can be included in v8.0 and it should be straightforward to implement the rest of the pointwise sparse divide semantics.

@anaruse I would like to merge this PR today as code freeze is tomorrow :) so if you can submit the proposed changes early I will give it top priority

Thank you for your comment, @emcastillo . I've modified the branch based on that, could you please review it again?

Jenkins, test this please

Jenkins CI test (for commit f8bcbabeec46e94ccc7e37e75b50c04e9a697cee, target branch master) succeeded!


Fix crashes after Window move assignment

Event handlers were hitting an access violation due to the user pointer pointing to the old invalid window.

Hello @arkeet! Thanks for your contribution. The CI is green, so I'm merging this now.


Add bootstrap mode

This should be the CodeSmithy IDE rebuilding itself just like the Bootstrap script but in better location and from the actual GitHub projects since the IDE is more flexible than the Boostrap Python scripts which are left simple by design.

Added Bootstrap class in Core but not sure that is the right location as much of the bootstrap procedure will have specific UI behavior.

At the moment the code clones the Project repository. Need to update the Project files to guide the rest of the bootstrap.

Removed Bootstrap file from Core. It all should be at the UIImplementation level I think.


Segfault crash

While I was playing Ninja Gaiden I decided to reset the game with Ctrl-R, at main menu it was fine, but when I pressed START it failed  showing the act number and freezed, after some time it gives a segfault
zsh: segmentation fault (core dumped)  tetanes Downloads/Ninja\ Gaiden\ \(USA\).nes

It's not limited to just Ninja Gaiden, it seems, I tried it with Punch-Out and it does the same thing - it freezes and segfaults when trying to load the level
zsh: segmentation fault (core dumped)  tetanes Downloads/Mike\ Tyson\'s\ Punch-Out!!\ \(USA\).nes

Thanks for reporting! This was due to the audio DMC reset function trashing the pointer to the mapper. Fixed!


draftsman.error.MissingModError: ExplosiveExcavation

Factorio Version 1.1.65 (build 59990, linux64)
Modpack: Seablock
Actions taken:
created virtual environment in project path .venv and installed factorio-draftsman.
sourced venv source .venv/bin/activate
Set draftstman factorio-mods folder to be a symlink to factorio install
~/projects/cractorio ⌚ 15:59:37
$ cd .venv/lib/python3.8/site-packages/draftsman/
(.venv)
~/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman ⌚ 16:03:32
$ ls
blueprintable.py  constants.py  env.py         factorio-mods         prototypes     tile.py      warning.py
classes           data          error.py       _factorio_version.py  __pycache__    utils.py
compatibility     entity.py     factorio-data  __init__.py           signatures.py  _version.py
(.venv)
~/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman ⌚ 16:03:42
$ ln -s ~/.factorio/mods factorio-mods

Verified path resolves and contains the offending mod:
~/projects/cractorio ⌚ 16:04:35
$ ls -l .venv/lib/python3.8/site-packages/draftsman/factorio-mods/ | grep -i expl
-rw-r--r-- 1 orion orion     65024 Dec 26  2020 Explosive Excavation_1.1.8.zip

Attempted draftsman-update from within the venv:
~/projects/cractorio ⌚ 16:05:17
$ draftsman-update --verbose
Reading mods from: /home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/factorio-mods

Discovering mods...

ScienceCostTweakerM
boblogistics
WARNING: Duplicate of mod 'boblogistics' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.3)
SeaBlockMetaPack
reskins-library
angelsrefining
underground-pipe-pack
KS_Power
bobwarfare
miniloader
Explosive Excavation
bobplates
WARNING: Duplicate of mod 'bobplates' found (1.1.3)
	Overwriting older version (1.1.2) with newer version (1.1.3)
bobmining
angelsbioprocessing
bobenemies
angelspetrochem
reskins-bobs
flib
Squeak Through
WARNING: Duplicate of mod 'flib' found (0.9.2)
	Skipping older version (0.9.2) in favor of newer version (0.10.1)
WARNING: Duplicate of mod 'bobplates' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
LtnManager
bobelectronics
bobinserters
AutoDeconstruct
WARNING: Duplicate of mod 'bobwarfare' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
LogisticTrainNetwork
angelsaddons-storage
bobrevamp
WARNING: Duplicate of mod 'angelsaddons-storage' found (0.0.9)
	Overwriting older version (0.0.4) with newer version (0.0.9)
PickerAtheneum
bobores
SeaBlock
WARNING: Duplicate of mod 'LogisticTrainNetwork' found (1.15.0)
	Skipping older version (1.15.0) in favor of newer version (1.16.7)
factoryplanner
WARNING: Duplicate of mod 'angelspetrochem' found (0.9.17)
	Skipping older version (0.9.17) in favor of newer version (0.9.21)
WARNING: Duplicate of mod 'SeaBlockMetaPack' found (1.1.1)
	Skipping older version (1.1.1) in favor of newer version (1.1.3)
boblibrary
bobequipment
bobassembly
WARNING: Duplicate of mod 'angelsbioprocessing' found (0.7.21)
	Skipping older version (0.7.21) in favor of newer version (0.7.22)
WARNING: Duplicate of mod 'SeaBlock' found (0.5.10)
	Skipping older version (0.5.10) in favor of newer version (0.5.11)
bobtech
railloader
WARNING: Duplicate of mod 'angelsrefining' found (0.11.19)
	Skipping older version (0.11.19) in favor of newer version (0.12.1)
PickerPipeTools
WARNING: Duplicate of mod 'bobores' found (1.1.0)
	Skipping older version (1.1.0) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'flib' found (0.6.0)
	Skipping older version (0.6.0) in favor of newer version (0.10.1)
WARNING: Duplicate of mod 'underground-pipe-pack' found (1.1.0)
	Skipping older version (1.1.0) in favor of newer version (1.1.2)
WARNING: Duplicate of mod 'ScienceCostTweakerM' found (1.1.10)
	Overwriting older version (1.1.2) with newer version (1.1.10)
WARNING: Duplicate of mod 'angelspetrochem' found (0.9.22)
	Overwriting older version (0.9.21) with newer version (0.9.22)
WARNING: Duplicate of mod 'boblogistics' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
FNEI
WARNING: Duplicate of mod 'bobores' found (1.1.3)
	Skipping older version (1.1.3) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'bobtech' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.5)
bobpower
SpaceMod
WARNING: Duplicate of mod 'bobpower' found (1.1.1)
	Skipping older version (1.1.1) in favor of newer version (1.1.3)
WARNING: Duplicate of mod 'SpaceMod' found (1.1.1)
	Overwriting older version (1.1.0) with newer version (1.1.1)
Factorissimo2
WARNING: Duplicate of mod 'SeaBlock' found (0.5.1)
	Skipping older version (0.5.1) in favor of newer version (0.5.11)
angelssmelting
WARNING: Duplicate of mod 'boblibrary' found (1.1.5)
	Overwriting older version (1.1.4) with newer version (1.1.5)
WARNING: Duplicate of mod 'bobelectronics' found (1.1.5)
	Overwriting older version (1.1.2) with newer version (1.1.5)
WARNING: Duplicate of mod 'bobelectronics' found (1.1.3)
	Skipping older version (1.1.3) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'angelsrefining' found (0.12.2)
	Overwriting older version (0.12.1) with newer version (0.12.2)
WARNING: Duplicate of mod 'bobassembly' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
WARNING: Duplicate of mod 'LogisticTrainNetwork' found (1.16.10)
	Overwriting older version (1.16.7) with newer version (1.16.10)
CircuitProcessing
WARNING: Duplicate of mod 'bobrevamp' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
reskins-angels
WARNING: Duplicate of mod 'angelssmelting' found (0.6.19)
	Overwriting older version (0.6.18) with newer version (0.6.19)
train-log
reskins-compatibility
WARNING: Duplicate of mod 'bobassembly' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.5)
ltn-cleanup
bobmodules
WARNING: Duplicate of mod 'CircuitProcessing' found (0.4.4)
	Overwriting older version (0.4.0) with newer version (0.4.4)
WARNING: Duplicate of mod 'angelssmelting' found (0.6.14)
	Skipping older version (0.6.14) in favor of newer version (0.6.19)
WARNING: Duplicate of mod 'bobrevamp' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'bobpower' found (1.1.5)
	Overwriting older version (1.1.3) with newer version (1.1.5)
WARNING: Duplicate of mod 'angelsaddons-storage' found (0.0.8)
	Skipping older version (0.0.8) in favor of newer version (0.0.9)
LandfillPainting
stdlib
helmod
TogglePeacefulMode
WARNING: Duplicate of mod 'boblibrary' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'Factorissimo2' found (2.5.3)
	Overwriting older version (2.5.1) with newer version (2.5.3)
WARNING: Duplicate of mod 'FNEI' found (0.4.1)
	Overwriting older version (0.4.0) with newer version (0.4.1)
WARNING: Duplicate of mod 'bobtech' found (1.1.3)
	Skipping older version (1.1.3) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'bobwarfare' found (1.1.2)
	Skipping older version (1.1.2) in favor of newer version (1.1.5)
WARNING: Duplicate of mod 'bobmining' found (1.1.1)
	Skipping older version (1.1.1) in favor of newer version (1.1.3)
WARNING: Duplicate of mod 'angelsbioprocessing' found (0.7.17)
	Skipping older version (0.7.17) in favor of newer version (0.7.22)
WARNING: Duplicate of mod 'LandfillPainting' found (0.5.0)
	Skipping older version (0.5.0) in favor of newer version (0.5.2)

Determining dependency tree...

ScienceCostTweakerM 1.1.10
archive? True
dependencies:
	   base >= 1.1.0
	 ? omnimatter_science >= 3.0.3
	 ? pycoalprocessing >= 1.2.0
	 ? bobtech
	 ? aai-industry
	 ? omnimatter_energy
boblogistics 1.1.5
archive? True
dependencies:
	   base >= 1.1.0
	   boblibrary >= 1.1.0
	 ? bobplates >= 1.1.0
	 ? bobinserters >= 1.1.0
SeaBlockMetaPack 1.1.3
archive? True
dependencies:
	   base
	   angelsaddons-storage
	   angelsbioprocessing
	   angelspetrochem
	   angelsrefining
	   angelssmelting
	   bobassembly
	   bobelectronics
	   bobenemies
	   bobequipment
	   bobinserters
	   boblibrary
	   boblogistics
	   bobmining
	   bobmodules
	   bobores
	   bobplates
	   bobpower
	   bobrevamp
	   bobtech
	   bobwarfare
	   CircuitProcessing
	   ExplosiveExcavation
Traceback (most recent call last):
  File "/home/orion/projects/cractorio/.venv/bin/draftsman-update", line 8, in <module>
    sys.exit(main())
  File "/home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/env.py", line 1777, in main
    update(verbose=args.verbose, show_logs=args.log, no_mods=args.no_mods)
  File "/home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/env.py", line 1548, in update
    raise MissingModError(dep_name)
draftsman.error.MissingModError: ExplosiveExcavation
(.venv)

Looks like this is caused by Explosive Excavation calling itself with a space but Seablock defines its dependency without one (ExplosiveExcavation). strangely Factorio has no trouble with this discrepancy and successfully installs Explosive Excavation.
If i symlink the zip, Draftsman crashes with an (seemingly?) unrelated exception.
Unfortunately, this symlink does cause a Factorio game assertion to fail.
~/.factorio/mods ⌚ 16:16:02
$ ln -s Explosive\ Excavation_1.1.8.zip ExplosiveExcavation_1.1.8.zip

Traceback (most recent call last):
  File "/home/orion/projects/cractorio/.venv/bin/draftsman-update", line 8, in <module>
    sys.exit(main())
  File "/home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/env.py", line 1777, in main
    update(verbose=args.verbose, show_logs=args.log, no_mods=args.no_mods)
  File "/home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/env.py", line 1718, in update
    load_stage(lua, mods, mod, stage)
  File "/home/orion/projects/cractorio/.venv/lib/python3.8/site-packages/draftsman/env.py", line 259, in load_stage
    lua.execute(mod.data[stage])
  File "lupa/_lupa.pyx", line 308, in lupa._lupa.LuaRuntime.execute
  File "lupa/_lupa.pyx", line 1324, in lupa._lupa.run_lua
  File "lupa/_lupa.pyx", line 1333, in lupa._lupa.call_lua
  File "lupa/_lupa.pyx", line 1359, in lupa._lupa.execute_lua_call
  File "lupa/_lupa.pyx", line 1295, in lupa._lupa.raise_lua_error
lupa._lupa.LuaError: .../factorio-data/core/lualib/circuit-connector-sprites.lua:15: attempt to perform 'n%0'
stack traceback:
	.../factorio-data/core/lualib/circuit-connector-sprites.lua:15: in local 'get_frame'
	.../factorio-data/core/lualib/circuit-connector-sprites.lua:24: in upvalue 'make_circuit_connector_sprites'
	.../factorio-data/core/lualib/circuit-connector-sprites.lua:80: in field 'create'
	[string "prototypes/entity/circuitconnectors"]:31: in main chunk
	[C]: in upvalue 'old_require'
	[string "<python>"]:173: in global 'require'
	[string "prototypes/entity/railloader"]:1: in main chunk
	[C]: in upvalue 'old_require'
	[string "<python>"]:173: in global 'require'
	[string "<python>"]:2: in main chunk

That is indeed strange. Changing the mod name to automatically trim spaces completely fixes the problem:
mod_name = m.group(1).replace(" ", "")

Reading mods from: D:\SourceCode\repos\Python\factorio-draftsman\draftsman\factorio-mods

...

Extracted entities...
Extracted instruments...
Extracted items...
Extracted modules...
Extracted recipes...
Extracted signals...
Extracted tiles...

Update finished.
hella slick; nothing broke!

As to when this normalization takes place in the actual Factorio load process, I have no idea; only the dependency list actually trims the whitespace. From this page I was under the impression that such filenames were prohibited from loading in Factorio, though clearly this is not the case. The only downside to doing this is that you would have to query the mod data from Draftsman as "ExplosiveExcavation" instead of "Explosive Excavation". Of course, this fix will only work for spaces as well.
The reason creating a symlink of the actual zip files doesn't work is because Draftsman preloads all archive files first before it resolves their dependencies, caching them. It loads a mod with the name "Explosive Excavation" internally; then, when it tries to resolve the dependencies, the name is listed as "ExplosiveExcavation", which doesn't match any of the cached mods.
Clever idea using a symlink to relate the Draftsman folder with the install folder. In this discussion I tossed out an idea for a method of specifying the mod folder path as an argument to draftsman-update; would that be more or less convenient for your particular situation?

Clever idea using a symlink to relate the Draftsman folder with the install folder. In https://github.com/redruin1/factorio-draftsman/discussions/36 discussion I tossed out an idea for a method of specifying the mod folder path as an argument to draftsman-update; would that be more or less convenient for your particular situation?

Yes, It would be more convenient for me to pass your tool a path to the mod directory than symlinking it.
And put another way, what if the user has multiple factorio mod directories? the factorio executable itself supports it with a CLI argument, it would be beneficial if this tool did as well.
As for architecture-specific path oddities, most of those can be mitigated by using a platform-agnostic filesystem API  like stdlib's pathlib.

And put another way, what if the user has multiple factorio mod directories? the factorio executable itself supports it with a CLI argument, it would be beneficial if this tool did as well.
Good point; I had no idea that Factorio itself let you do so. I'm convinced, I'll add this feature to the 1.0.2 release.

Closing this for now; getting rid of the spaces might cause problems further down the line, but it seems uncommon enough to patch like so right now. I'll reopen/mention this issue if any future problems crop up.


MAKE A PHYLIP TO NEWICK CONVERTOR

TOP PRIORITY!!!

PER THIS SITE: https://www.ncbi.nlm.nih.gov/Taxonomy/CommonTree/wwwcmt.cgi

@aglucaci, I've tagged this issue as critical. I should have an implementation within the first two weeks of March.


[DOCS] Add Unsplash link and guide to get API key to the README file

Description
The developers who will try the app themselves would need a Unsplash API key, so in the README.md file a link to unsplash website and also a link to " How to get unsplash API key " would  be really helpful for anyone who tried the app. Also it helps for easy navigation
Expected Behavior
Small section where we link the Unsplash website and tutorial article to make it feasible for users to access it.
Actual Behavior
It would be nice to save time of people and help them with the API keys
Screenshots (if applicable)
N/A
Additional Information
N/A

You can consider assigning this issue to me under hacktoberfest

Go for it 👍


Incompatible with Zotero 6.0-beta.1+c603753f.

Using the latest version of Zotero beta and failed to enable Zotodo.

I have the same problem

Hi, the same problem here. It seems incompatible with the Zotero 6.0 version

Hey, me too. I wonder whether the developer could update it. I think this is a very very important function for thesis manage tools.

However, in the stable Zotero 6.0 this plugin is still incompatible :(

I fall to roll back to  Zotero 5.x, but I found a way to solve this issue temporarily. 👇
https://github.com/wbthomason/zotodo/issues/30

Hi all, sorry for taking a while to get to this. I'm trying to figure out why the plugin is incompatible with 6.0 - I haven't been able to find any more detailed information. I'll post here when I get something figured out.

@xiaodl813 @PoloWitty @tenglu0417 @yaronbh @wenyaoliu This should be fixed with the release of v0.8.2 - please let me know if you continue to have issues, and thank you for your patience!

@wbthomason Thank you so much for fixing this! Much appreciated!


Broker should be an interface

Versions
Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version: 70f6a705d4a17af059acbc6946fb2bd30762acd7
Kafka Version: any
Go Version: any
Configuration
N/A - source enhancement
Logs
N/A
Problem Description
In rewriting an application that depends on Sarama and writing tests, I'm finding that while it's easy to mock out the client for testing, as it a defined interface, it's not as easy with the Broker object. Unfortunately, the usage of Sarama has me depending on the Broker class a bit and calling the exposed methods directly. This means that in order to test, I'm going to have to write a shim interface for both Client and Broker so that I can swap in a test mock when needed.
I'm happy to do the work and submit a PR for the changes to Broker. I wanted to open the issue as well as a placeholder for the work and to make sure that there's nothing I'm missing that would preclude making this change.

There was some discussion of this a while ago at https://github.com/Shopify/sarama/pull/570.
Off the top of my head, this would be a breaking API change?

I guess the question is would it actually be breaking? Yes, it would be an API change - Client, for example, would need to be changed to handle interfaces instead of the Broker struct. However, the Broker struct has no exposed fields, which means it can only be used for its methods (or to pass back in to something that can use the unexposed fields). The type name for the struct could remain Broker and the interface could be named something else (like BrokerInterface or AbstractBroker).

Creating a separate public type for the interface would definitely be a breaking change since code like
var broker *Broker
var err error
broker, err = client.Leader("foo", 123)

would fail to compile when the return value of Leader changed from (*Broker, error) to (BrokerInterface, error).
However, I haven't immediately been able to come up with code that would break if we just changed the struct to type Broker interface {} with a private implementing struct. Usage would be really weird since we'd be taking a pointer to an interface everywhere, and intuitively I would expect something to break, but I haven't actually been able to find it yet.

Oh, it would break because go won't dereference pointers to interfaces automatically, you get stuff like leader.ID undefined (type *Broker is pointer to interface, not interface)

Oh yeah, that's right. There's not really any way around that one. It's probably still worthwhile to do this for the next major change when breaking the interface will be OK, but at least for the time being I've worked around this for my own personal use by wrapping an interface around Sarama so I can test.

Ya, we're accumulating a bunch of stuff for when we end up doing a new major release. Glad to know it wasn't a blocker for the time being.
https://github.com/Shopify/sarama/wiki/Ideas-that-will-break-backwards-compatibility