MSID: 92195 Version: 1 DOI: 2<IP_ADDRESS>9355

"msas": "Cell Biology"
"msid": "92195"
"preprintDoi": "10.1101/2<IP_ADDRESS>9355"
"Reviewed Preprint posted": "2023-11-21"
"Sent for peer review": "2023-09-07"
"Posted to bioRxiv": "2023-09-26" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>9355v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92195)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/92195/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>9355)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/92195/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/92195)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/92195

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/92195

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/92195/v1/92195-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/92195)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from references


Optional CSS inlining

It may be good to try to inline the CSS in the optimize phase and just put everything in a <style>..</style>. Maybe try to do this either before or after the minification and see what works best.
It should be optional bc while for simple CSS this will likely not be a problem, if the CSS is quite heavy (e.g. Tufte + KaTeX + ... ) then in fact it might not help much. Maybe just try and see...

This should definitely not be implemented. Inlining CSS is a practice that's frowned upon, as it is harder to maintain such web pages.

Yeah I agree with this, let's not do it, thanks for chipping in!


Error spawn C ENOENT

Hi
I'm trying to use gulp-php-minify version 7.1.1, but I get a an error:
spawn C ENOENT
I am using:-
gulp.task('minifyphp', function (cb) {
pump([
gulp.src(SRC + '*.php', {read: false}),
phpMinify({
binary: 'path_to\php\php5.6.35\php.exe'
}),
gulp.dest(DEST + 'php_min')
],
cb
);
});
Error: [@cedx/gulp-php-minify] spawn C ENOENT
at Minifier._transform (C:\Users\rb\Desktop\web_webdev\node_modules@cedx\gulp-php-minify\lib\minifier.js:83:30)
at
at runMicrotasksCallback (internal/process/next_tick.js:121:5)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
Any ideas as to the potential reason for this Error?
Can I also just confirm whether it handles files with combined PHP and HTML content, i.e. that it just minifies within the PHP tags, and just passes through the rest of the HTML untouched.

p.s. I also tried it with the php7.2.4 on the path instead

Might requiring cross-spawn instead of child_process by default solve this issue on Windows? (I have seen many people post in other packages about similar issues, but I can't see any similar issues or solutions posted here)

Thanks for reporting this issue. I finally tested on a Windows machine, and I've reproduced this bug.
I need to look further ahead: it's a regression. Previously, this plugin worked very well on Windows.
I will try to release a fix in the next days.

@cedx Did you manage to find a fix?

@cedx I have now updated to node10 and gulp4, but I still get the same error using gulp-php-minify version 9.0.0.  Did you manage to find a solution for this that hasn't yet been published in the latest build?

I was hoping that this trace would give me more info... No luck: that's not the case.
Let's try to investigate : ENOENT means that the PHP binary was not found at the specified path. So the first thing that we need is the real path that is searched by the plug-in.
Could you edit the lib/safe_transformer.js at line15 (or the lib/fast_transformer.js at line 16, if you're using the fast option) ?
this._executable = _executable;
console.log(_executable); // => this will give us the PHP path checked by the plugin

OK, that looks promising, this gives:-
PHP Path: C
but my Gulp Task contains:
phpMinify({
binary: 'C:\Users\rb\Documents\wamp64\bin\php\php7.2.4\php.exe'
})
So, is something going wrong there?

Very interesting. You've found the hidden bug :+1:  (I mean : thanks to this path, I know now where is probably the bug). The ":" character has a special usage in the code (cf. see minifier.js@L56). It should not be an issue when I look closely, but using another character does not change anything and should fix this problem.
I will try to release another version soon, but I go on vacation tomorrow for one week. So, you'll probably have to wait a few days.

OK, the bug is here : https://github.com/cedx/gulp-php-minify/blob/master/src/minifier.ts#L58
I'm doing too much PHP : I thought that split() in JS works the same as explode() in PHP, but the limit parameter has not the same usage.

Yes, that looks like the problem. I am no expert and I haven't looked through the wider code modules so I cannot understand why you concatenate the mode and binary on Line 41 only to split them again on Line 57? Why not store the values independently as this._mode and this._binary?  Anyway, the colon : character would certainly have broken the executable path when split resulting in my path reporting as C.  Hopefully, that fix will solve the issue with specified PHP executable paths (as in my case). Have a lovely vacation! (it can certainly wait until you get back...)

I just released a new version 9.1.1 on npm. The new code is safe whatever character is used (removed the usage of the limit parameter on the split call). Hope that it will fix this issue.

Works perfectly, thank you. Have a great vacation!


Issue with login page fontawsome pack forbidden

I get a "GET https://kit.fontawesome.com/811fbb4da4.js net::ERR_ABORTED 403 (Forbidden)" Error when trying to use the login page.  It appears that the icons that were used previously are no longer available at that URL.  I tried to access this url on a different network and also recieved a 403 response.

Hey @cjannusch,
Good pickup, this is coming up in my console, I can correct this in a future update.
Is this stopping you form logging in?

Yes it is stopping me from logging in, was trying to change the sonarr version from 4 to 3 because that is currently broken for me.  It would be nice (maybe just for me lol) if it defaulted to version 3.

I think going forward it makes more sense for version 4 to be the default (I don't know if there is a reason to do a fresh install of version 3 going forward), but I get your point.
I will correct this error and patch it when I have a chance.

Okay thank you, I built the project on my own without the script tag and am still not getting a login page, so I'm not sure, but there may be something else i am experiencing causing my issue, but I will test your update when you get a chance and let you know if that fixes it. Thanks for the quick responses!

I managed to change the sonarr version in the settings.json without any access through the webui at all.  Might be something potentially worth it to add to the common problems wiki. I am going to close this now.


Caught Segmentation fault, suspect faulting address 0x0.

Title: Caught Segmentation fault, suspect faulting address 0x0.
Description:

We are experiencing periodic restarts due to a segmentation fault. With envoy.filters.http.grpc_http1_reverse_bridge enabled.
We have realized that it is "always" after an error 418 due to nginx waf.
Is it possible that we have forgotten some envoy config?
Envoy version: ebd972ecb49bc50bd754fdecb3f84c70d2ad26b6/1.12.0-dev/Clean/RELEASE/BoringSSL (but we experienced it using v1.11.0 stable version too)

Config:
admin:
  access_log_path: /dev/stdout
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 9901

static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 443
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          use_remote_address: true
          access_log:
          - name: envoy.file_access_log
            config:
              path: /dev/stdout
          stat_prefix: ingress_http
          route_config:
            name: local_route
            virtual_hosts:
            - name: local_service
              domains: ["*"]
              routes:
              - match:
                  prefix: "/"
                route:
                  host_rewrite: grpcbackend-internal
                  cluster: backend
                  timeout: 50.00s
          http_filters:
          - name: envoy.filters.http.grpc_http1_reverse_bridge
            config:
              content_type: application/grpc+proto
              withhold_grpc_frames: true
          - name: envoy.router
      use_proxy_proto: true
      tls_context:
        common_tls_context:
          alpn_protocols:
            - h2
            - http/1.1
          tls_certificates:
            - certificate_chain: {filename: xxx.pem}
              private_key: {filename: xxx.key}
  clusters:
  - name: backend
    connect_timeout: 50.00s
    type: LOGICAL_DNS
    dns_lookup_family: V4_ONLY
    lb_policy: ROUND_ROBIN
    hosts:
      - socket_address:
          address: http-internal
          port_value: 80

Call Stack:

StreamInfoImpl 0x2506eb8, protocol_: 2, response_code_: null, response_code_details_: via_upstream, health_check_request_: 0, route_name_:
&stream_info_:
response_trailers_: null
'x-envoy-upstream-service-time', '29'
'connection', 'keep-alive'
'content-length', '0'
'date', 'Mon, 28 Oct 2019 10:49:42 GMT'
'server', 'nginx'
':status', '418'
response_headers_:
request_trailers_: null
'x-envoy-expected-rq-timeout-ms', '50000'
'accept', 'application/grpc+proto'
'x-request-id', 'xxx'
'x-envoy-external-address', 'x.x.x.x'
'x-forwarded-proto', 'https'
'x-forwarded-for', 'x.x.x.x'
'grpc-timeout', '4770m'
'accept-encoding', 'identity,gzip'
'grpc-accept-encoding', 'identity,deflate,gzip'
'user-agent', 'grpc-csharp/1.23.0-dev grpc-c/7.0.0 (android; chttp2; gangnam)'
'content-type', 'application/grpc+proto'
'te', 'trailers'
':path', '/rpc.backend.Service/Xxxx'
':authority', 'backend'
':method', 'POST'
':scheme', 'http'
request_headers_:
ActiveStream 0x2506d80, stream_id_:<PHONE_NUMBER>975308796, has_continue_headers_: 0, is_head_request_: 0, decoding_headers_only_: 0, encoding_headers_only_: 0
[2019-10-28 10:49:42.552][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:77] #22: [0x7f859b400f30]
[2019-10-28 10:49:42.552][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #21: Envoy::Thread::ThreadImplPosix::ThreadImplPosix()::$_0::__invoke() [0x128d1a5]
[2019-10-28 10:49:42.548][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #20: Envoy::Server::WorkerImpl::threadRoutine() [0xe0bd3b]
[2019-10-28 10:49:42.543][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #19: event_base_loop [0x1104d9e]
[2019-10-28 10:49:42.459][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #18: event_process_active_single_queue [0x11065b7]
[2019-10-28 10:49:42.454][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #17: Envoy::Event::FileEventImpl::assignEvents()::$_0::__invoke() [0xe13f15]
[2019-10-28 10:49:42.450][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #16: Envoy::Network::ConnectionImpl::onFileEvent() [0xe19381]
[2019-10-28 10:49:42.445][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #15: Envoy::Network::ConnectionImpl::onReadReady() [0xe198c6]
[2019-10-28 10:49:42.366][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #14: Envoy::Network::FilterManagerImpl::onContinueReading() [0xe1cf0b]
[2019-10-28 10:49:42.363][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #13: Envoy::Http::CodecClient::CodecReadFilter::onData() [0xfbeb4d]
[2019-10-28 10:49:42.360][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #12: Envoy::Http::CodecClient::onData() [0xfbdf96]
[2019-10-28 10:49:42.357][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #11: Envoy::Http::Http1::ConnectionImpl::dispatch() [0x103546f]
[2019-10-28 10:49:42.353][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #10: Envoy::Http::Http1::ConnectionImpl::dispatchSlice() [0x1035685]
[2019-10-28 10:49:42.349][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #9: http_parser_execute [0x110c95e]
[2019-10-28 10:49:42.345][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #8: Envoy::Http::Http1::ConnectionImpl::$_7::__invoke() [0x1039e9d]
[2019-10-28 10:49:42.261][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #7: Envoy::Http::Http1::ConnectionImpl::onMessageCompleteBase() [0x1036429]
[2019-10-28 10:49:42.254][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #6: Envoy::Http::Http1::ClientConnectionImpl::onMessageComplete() [0x1038b16]
[2019-10-28 10:49:42.250][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #5: Envoy::Http::StreamDecoderWrapper::decodeHeaders() [0xfbec7c]
[2019-10-28 10:49:42.245][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #4: Envoy::Http::Http1::ConnPoolImpl::StreamWrapper::decodeHeaders() [0xf4f336]
[2019-10-28 10:49:42.238][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #3: Envoy::Router::Filter::UpstreamRequest::decodeHeaders() [0xfddbf6]
[2019-10-28 10:49:42.234][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #2: Envoy::Router::Filter::onUpstreamHeaders() [0xfdba05]
[2019-10-28 10:49:42.229][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #1: Envoy::Http::ConnectionManagerImpl::ActiveStream::encodeHeaders() [0x102710b]
[2019-10-28 10:49:42.225][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:77] #0: [0x7f859b40c420]
[2019-10-28 10:49:42.224][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:71] Envoy version: ebd972ecb49bc50bd754fdecb3f84c70d2ad26b6/1.12.0-dev/Clean/RELEASE/BoringSSL
[2019-10-28 10:49:42.224][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:70] Backtrace (use tools/stack_decode.py to get line numbers):
[2019-10-28 10:49:42.224][18][critical][backtrace] [bazel-out/k8-opt/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:83] Caught Segmentation fault, suspect faulting address 0x0

This seems like a bug to me. Would you be able to provide the exact headers that nginx responds with?

This seems like a bug to me. Would you be able to provide the exact headers that nginx responds with?

@snowp
< HTTP/1.1 418
< Date: Mon, 28 Oct 2019 17:23:35 GMT
< Server: nginx
< Content-Length: 0
< Connection: keep-alive

Below, a curl full example (personal info obfuscated):
* Rebuilt URL to: https://xxx.xxx.com/
*   Trying xxx.xxx.xxx.xxx...
* TCP_NODELAY set
* Connected to xxx.xxx.com (xxx.xxx.xxx.xxx) port X (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /xxx.pem
  CApath: none
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSvX.X / XXXXX-XXX-XXXXXX-XXX-XXXXXX
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: C=xx; ST=xxx; L=xxx; O=xxx; CN=*.xxx.com<EMAIL_ADDRESS>*  start date: Feb 14 10:54:38 2019 GMT
*  expire date: Feb  9 10:54:38 2039 GMT
*  issuer: C=xxx; ST=xxx; L=xxx; O=xxx; CN=*.xxx.com<EMAIL_ADDRESS>*  SSL certificate verify result: self signed certificate (18), continuing anyway.
> GET / HTTP/1.1
> Host: xxx.xxx.com
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 418
< Date: Mon, 28 Oct 2019 17:23:35 GMT
< Server: nginx
< Content-Length: 0
< Connection: keep-alive
<
* Connection #0 to host xxx.xxx.com left intact

Thanks,  this seems to be an issue with handling a missing content-type on the upstream response. I'll get a fix ready


App [Housekeeping]: Overflow Menu Logic Consolidatioon

Overview

Audit all overflow menu's added to the app in the 6.0.0 release. Have them covered by a responsible generic component that captures all of their needs.
Instead of fixing the width of the menu items, make the generic overflow menu component capable of growing with the widest item without wrapping.
interrogate the usage of stopPropagation for individual items in the menu as well as the menu itself (if rendered into a clickable item like a protocol card)

suggested solution for the first one

current
const sortOverflowWrapperRef = useOnClickOutside({
    onClickOutside: () => setShowSortByMenu(false),
  }) as React.RefObject<HTMLDivElement>

suggested
const sortOverflowWrapperRef = useOnClickOutside<HTMLDivElement>({
  onClickOutside: () => setShowSortByMenu(false),
})

suggested solution for the second one
use whiteSpace: nowrap instead of using hard-coded numbers ex width="11rem"


Do the autocomplete/select components support multip

Trying to implement something like this (the dropdown menu with multiple columns and categories):

Is there a way to do this with the material ui autocomplete/select components?

It looks like your screenshot is coming from https://keenthemes.com/metronic/preview/react/demo1/dashboard. Looking at the interactivity of your example, it has no accessibility support, it seems that it was simply ignored.

If you don't care about ♿, you can use the Popper component to rebuild something similar.
If you care, about it, then no, we don't provide yet the support for the Menu bar.


add support for Stellar Protocol 19

CHANGELOG:

add support for Stellar Protocol 19
use UTC string to represent TimeBounds. (ex. 2022-03-26 03:49:59)
when timeBounds is set to TimeBounds(0, 0), it is no longer displayed.
display asset issuer when necessary, such as displaying asset issuer in payment operation details.
it's annoying to confirm the tx source (and feeBumpTx source) on the Nano S, when the signing account matches the tx source, only display the summary of the tx source.
adjusted struct field layout to reduce memory consumption.

What will be displayed if there is only one timebound? for example, for (0,n), will the lower limit still be displayed?

The example UTC string you shared (2022-03-26 03:49:59) doesn't have an indicator that it's not local time for the user. Maybe we can instead use ISO_8601 which is an industry standard?

What will be displayed if there is only one timebound? for example, for (0,n), will the lower limit still be displayed?

I want to keep them in pairs, the following will be displayed:
Time Bounds From: [no restriction]
Time Bounds To: n (Time String)

The example UTC string you shared (2022-03-26 03:49:59) doesn't have an indicator that it's not local time for the user. Maybe we can instead use ISO_8601 which is an industry standard?

Yes, I've thought about this, but the reason I chose the current format is that it fits on a single screen.
I will modify it to ISO-8601 format.

I want to keep them in pairs

What's the value of keeping them in paris? Why not just skip displaying a timebound when there is no restriction?

@tomerweller
There are currently two options for displaying time bounds, I personally prefer the latter because it can be displayed on one screen, and we indicate in the title that this is UTC time, which one do you prefer?

option 1

option 2

I want to keep them in pairs

What's the value of keeping them in pairs? Why not just skip displaying a timebound when there is no restriction?

emmm, maybe it's my personal preference, I think it's not a big deal and I've skipped it.

Further to Tomer's tweat... the feature I would like is an option to skip all the details of the transaction.
Particularly if a transaction has a lot of operations it takes a lot of right pressing to make it happen. If I don't have a lot of funds on the device the risk is low.

Hi @antb123, I'm going to refactor this app soon, and I thought I'd add a new setting to it that would allow users to skip these complicated items.

There are currently two options for displaying time bounds, I personally prefer the latter

I agree that the latter, with UTC is better.

I just reviewed the current signing flow and would like to recommend a few low hanging fruit improvements:

Remove Network Public indicator screen when using the public network - most people use their device for the public network. We can leave the testnet indicator for disambiguating test transactions.
Rename Network Test indicator to Network Testnet as that's the actual name
Remove the Transaction Details information prompt. This is redundant as the signing flow starts with a Review Transaction prompt.
Rename timebounds. Max Time->Valid Before and Min Time-> Valid After
Remove Memo [none] indicator when there's no memo.
Rename Fee->Max Fee

Remove Memo [none] indicator when there's no memo.

I think we should keep it, many users forget the memo when sending to the exchange, I think this can serve as a reminder.

I think we should keep it, many users forget the memo when sending to the exchange, I think this can serve as a reminder.

That's a good point.
I'm on the fence about this. The role of the HW wallet's tx display is to verify that the tx you're signing is identical to the transaction you generated in the SW wallet. It's less about double checking that you generated the "right" transaction".
With that said, missed memos are so common in Stellar that maybe it's ok keeping this around as extra security.

One more:

For Change Trust operations remove Trust Limit [maximum] when set to max int64, this is probably more confusing than helpful.


Update X and Y knob positions when the Plot's X or Y axis changes.

Because of course it is very likely that the currently playing point is not in the same spot, so the X and Y knobs should be updated to reflect its new position on the plot.

fixed by pr #30


Use the same error handling output as webpack itself

Fixes #29.
Follows conventions from the webpack cli.

Looks good. Thanks!


feat: add more deps into ci-base image

Follow on PR to add the rest of the deps in for Cypress tests in CI.
These will be satisfied locally on dev machines my default (normally)

bors merge


Serverpod generate fails after upgrade to Dart 3.5.0

Describe the bug
Information about the latest pub run.

If you believe something is not working right, you can go to
https://github.com/dart-lang/pub/issues/new to post a new issue and attach this file.

Before making this file public, make sure to remove any sensitive information!

Pub version: 3.5.0
Created: 2024-08-12T11:59:13.380873
FLUTTER_ROOT: /Users/enriquellopis/development/flutter
PUB_HOSTED_URL: <not set>
PUB_CACHE: "<not set>"
Command: dart pub -v global run 'serverpod_cli:serverpod_cli' generate
Platform: macos

---- /Users/enriquellopis/dev/spod/spod_server/pubspec.yaml ----
name: spod_server
description: Starting point for a Serverpod server.
# version: 1.0.0
# homepage: https://www.example.com

environment:
  sdk: '>=3.0.0 <4.0.0'

dependencies:
  serverpod: ^2.0.2
  serverpod_auth_server: ^2.0.2

dev_dependencies:
  lints: ^4.0.0

---- End pubspec.yaml ----
---- /Users/enriquellopis/dev/spod/spod_server/pubspec.lock ----
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  _discoveryapis_commons:
    dependency: transitive
    description:
      name: _discoveryapis_commons
      sha256: "113c4100b90a5b70a983541782431b82168b3cae166ab130649c36eb3559d498"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.7"
  archive:
    dependency: transitive
    description:
      name: archive
      sha256: cb6a278ef2dbb298455e1a713bda08524a175630ec643a242c399c932a0a1f7d
      url: "https://pub.dev"
    source: hosted
    version: "3.6.1"
  args:
    dependency: transitive
    description:
      name: args
      sha256: "7cf60b9f0cc88203c5a190b4cd62a99feea42759a7fa695010eb5de1c0b2252a"
      url: "https://pub.dev"
    source: hosted
    version: "2.5.0"
  asn1lib:
    dependency: transitive
    description:
      name: asn1lib
      sha256: "58082b3f0dca697204dbab0ef9ff208bfaea7767ea771076af9a343488428dda"
      url: "https://pub.dev"
    source: hosted
    version: "1.5.3"
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  buffer:
    dependency: transitive
    description:
      name: buffer
      sha256: "389da2ec2c16283c8787e0adaede82b1842102f8c8aae2f49003a766c5c6b3d1"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.3"
  charcode:
    dependency: transitive
    description:
      name: charcode
      sha256: fb98c0f6d12c920a02ee2d998da788bca066ca5f148492b7085ee23372b12306
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: a1ace0a119f20aabc852d165077c036cd864315bd99b7eaa10a60100341941bf
      url: "https://pub.dev"
    source: hosted
    version: "1.19.0"
  convert:
    dependency: transitive
    description:
      name: convert
      sha256: "0f08b14755d163f6e2134cb58222dd25ea2a2ee8a195[...]ources:
    dependency: transitive
    description:
      name: system_resources
      sha256: "7e78cf8ef224c1e0b6bf4462322b6739fea2274fef928cbcbf21ae5e5a8272d8"
      url: "https://pub.dev"
    source: hosted
    version: "1.6.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "664d3a9a64782fcdeb83ce9c6b39e78fd2971d4e37827b9b06c3aa1edc5e760c"
      url: "https://pub.dev"
    source: hosted
    version: "0.7.3"
  typed_data:
    dependency: transitive
    description:
      name: typed_data
      sha256: facc8d6582f16042dd49f2463ff1bd6e2c9ef9f3d5da3d9b087e244a7b564b3c
      url: "https://pub.dev"
    source: hosted
    version: "1.3.2"
  unorm_dart:
    dependency: transitive
    description:
      name: unorm_dart
      sha256: "23d8bf65605401a6a32cff99435fed66ef3dab3ddcad3454059165df46496a3b"
      url: "https://pub.dev"
    source: hosted
    version: "0.3.0"
  uuid:
    dependency: transitive
    description:
      name: uuid
      sha256: "83d37c7ad7aaf9aa8e275490669535c8080377cfa7a7004c24dfac53afffaa90"
      url: "https://pub.dev"
    source: hosted
    version: "4.4.2"
  vm_service:
    dependency: transitive
    description:
      name: vm_service
      sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
      url: "https://pub.dev"
    source: hosted
    version: "14.2.4"
  web:
    dependency: transitive
    description:
      name: web
      sha256: d43c1d6b787bf0afad444700ae7f4db8827f701bc61c255ac8d328c6f4d52062
      url: "https://pub.dev"
    source: hosted
    version: "1.0.0"
  x509:
    dependency: transitive
    description:
      name: x509
      sha256: "3262dc9a7d45b0876f886c01bfc7d5e765704f7dfd31f8cf5224fc875c17a6c6"
      url: "https://pub.dev"
    source: hosted
    version: "0.2.4+2"
  xml:
    dependency: transitive
    description:
      name: xml
      sha256: b015a8ad1c488f66851d762d3090a21c600e479dc75e68328c52774040cf9226
      url: "https://pub.dev"
    source: hosted
    version: "6.5.0"
  yaml:
    dependency: transitive
    description:
      name: yaml
      sha256: "75769501ea3489fca56601ff33454fe45507ea3bfb014161abc3b43ae25989d5"
      url: "https://pub.dev"
    source: hosted
    version: "3.1.2"
sdks:
  dart: ">=3.4.0 <4.0.0"

---- End pubspec.lock ----
---- Log transcript ----
FINE: Pub 3.5.0
FINE: Package Config up to date.
MSG : Building package executable...
IO  : Created temp directory /Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/tmpVczNeP
IO  : Copying "/Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/serverpod_cli.dart-3.5.0.snapshot.incremental" to "/Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/tmpVczNeP/serverpod_cli.dart-3.5.0.snapshot.incremental.temp".
IO  : Renaming "/Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/tmpVczNeP/serverpod_cli.dart-3.5.0.snapshot.incremental.temp" to "/Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/serverpod_cli.dart-3.5.0.snapshot.incremental".
IO  : Deleting directory /Users/enriquellopis/.pub-cache/global_packages/serverpod_cli/bin/tmpVczNeP.
ERR : Failed to build serverpod_cli:serverpod_cli:
    | ../../../.pub-cache/hosted/pub.dev/archive-3.4.10/lib/src/bzip2/bzip2.dart:5:7: Error: Method not found: 'UnmodifiableUint8ListView'.
    |       UnmodifiableUint8ListView(Uint8List(0));
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^
    | ../../../.pub-cache/hosted/pub.dev/archive-3.4.10/lib/src/bzip2/bzip2.dart:7:7: Error: Method not found: 'UnmodifiableUint32ListView'.
    |       UnmodifiableUint32ListView(Uint32List(0));
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^
    | ../../../.pub-cache/hosted/pub.dev/archive-3.4.10/lib/src/bzip2/bzip2.dart:9:7: Error: Method not found: 'UnmodifiableInt32ListView'.
    |       UnmodifiableInt32ListView(Int32List(0));
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^
FINE: Exception type: ApplicationException
FINE: package:pub/src/dart.dart 186:7                                  precompile
    | ===== asynchronous gap ===========================
    | dart:async                                                       Future.catchError
    | package:pub/src/utils.dart 178:21                                waitAndPrintErrors.<fn>
    | dart:async                                                       Future.wait
    | package:pub/src/utils.dart 176:17                                waitAndPrintErrors
    | package:pub/src/entrypoint.dart 677:14                           Entrypoint.precompileExecutable.<fn>
    | package:pub/src/log.dart 450:18                                  progress
    | package:pub/src/entrypoint.dart 675:15                           Entrypoint.precompileExecutable
    | package:pub/src/command/global_run.dart 85:32                    GlobalRunCommand.runProtected.<fn>.<fn>
    | package:pub/src/log.dart 433:32                                  errorsOnlyUnlessTerminal
    | package:pub/src/command/global_run.dart 84:38                    GlobalRunCommand.runProtected.<fn>
    | package:pub/src/global_packages.dart 452:24                      GlobalPackages.runExecutable.<fn>
    | package:pub/src/executable.dart 104:22                           runExecutable
    | ===== asynchronous gap ===========================
    | dart:async                                                       _CustomZone.registerUnaryCallback
    | package:pub/src/executable.dart 97:5                             runExecutable
    | package:pub/src/global_packages.dart 446:23                      GlobalPackages.runExecutable
    | package:pub/src/command/global_run.dart 77:36                    GlobalRunCommand.runProtected
    | ===== asynchronous gap ===========================
    | dart:async                                                       _CustomZone.registerUnaryCallback
    | package:pub/src/command/global_run.dart 76:30                    GlobalRunCommand.runProtected
    | package:pub/src/command.dart 197:21                              PubCommand.run.<fn>
    | dart:async                                                       new Future.sync
    | package:pub/src/utils.dart 137:12                                captureErrors.wrappedCallback
    | package:stack_trace                                              Chain.capture
    | package:pub/src/utils.dart 154:11                                captureErrors
    | package:pub/src/command.dart 196:13                              PubCommand.run
    | package:args/command_runner.dart 212:27                          CommandRunner.runCommand
    | package:dartdev/dartdev.dart 236:30                              DartdevRunner.runCommand
    | package:args/command_runner.dart 122:25                          CommandRunner.run.<fn>
    | dart:async                                                       new Future.sync
    | package:args/command_runner.dart 122:14                          CommandRunner.run
    | package:dartdev/dartdev.dart 47:29                               runDartdev
    | /Volumes/Work/s/w/ir/x/w/sdk/pkg/dartdev/bin/dartdev.dart 13:11  main
FINE: Building package executable finished (0.983s).
---- End log transcript ----

I think it has to do with some dependency that has win32 as dependency was not updated.
To Reproduce
Steps to reproduce the behavior:
Upgrade to last flutter, dart gets updated to 3.5.0. Run serverpod generate in the proyect_server folder.
Expected behavior
Generates the files.
Screenshots
If applicable, add screenshots to help explain your problem.
Serverpod versions

CLI Version: Run serverpod version to determine the version of installed tooling.
Library version: Check the pubspec.yaml file for the version of Serverpod you are using.

Platform information
On which platforms do you experience the issue. Please provide as much information here as you can. Where are you running the server, which front end device are you using?
Additional context
Add any other context about the problem here.

Solved after:
flutter pub cache repair

Solved after:
flutter pub cache repair


Ft/source africa cms integration

Description
This PR implements fetching sourceAfrica documents in the CMS.
Fixes #370
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

I think it would be better to limit it to one line in mobile and 2 on desktop.

The most important thing @kelvinkipruto is for content to not exceed the height of the thumbnail in all screen sizes.

Any blockers on this @kelvinkipruto ?

Any blockers on this @kelvinkipruto ?

@kilemensi. No, I had put too much effort on an issue in openAfrica. It is now ready for re-review


Added Block Alerts grant application

Project Abstract

Block Alerts provide a platform to set up alerts in your smart contracts. Whether you want to get alerts for any transaction or events, the block alerts platform will listen to the alert and send it to your Slack, MS teams, etc.

Grant level

[x] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the application, @davidzindex999. A few questions:

Is there a reason you only address smart contracts, and not also pallets? I'd assume there would be interest in pallet activity notifications as well.
Are you planning to support only ink!, or also EVM-based smart contracts?
Since your Github account is new, is there any previous work you can share with us? Anything open source, ideally Substrate or blockchain related?

Hey @semuelle. Thanks for showing interest in this application.

Is there a reason you only address smart contracts, and not also pallets? I'd assume there would be interest in pallet activity notifications as well.
Support for pallets is not in the scope of this grant. We will create a follow-up grant, and we will have support for pallets along with some more functionalities.

Are you planning to support only ink!, or also EVM-based smart contracts?
Yes, currently, we will only support Ink. Ultimately we will try to extend support to all the chains, including EVM-based chains.

Since your Github account is new, is there any previous work you can share with us? Anything open source, ideally Substrate or blockchain related?
I have been working in an IT-based company for close to 6 years. We had our instance of GitLab, where I used to push the code. I will push a few ink based smart contracts and file downloader in Rust which I created sometime back.

Hey @semuelle Hope you are doing well!  Any update on the same ?

Hey @semuelle. I have added the following repositories. Hope it helps. The third one is just a boilerplate generated using cargo contract new:

https://github.com/davidzindex999/learning-rust
https://github.com/davidzindex999/file-downloader-rust
https://github.com/davidzindex999/ink-tutorial


Add a basic inter mode

In the beginning, maybe w/o pred_mv, so NEW_MV mode/

I think not done, since we think zeromv is the minimal inter mode and that has just reverted.

Closed by #416.


[Suggestion] Replace dropdown lists with buttons in examples

I really liked the demo page, but dropdown lists are somewhat annoying. IMO it would be better to show a list of little buttons that would trigger animations when clicked.

Thank you for suggestion. For me dropdown lists are more comfortable, but maybe in the nearest future I will change that


PSRP WSMan client library to C#

PSCore6 currently depends on OMI native client library for non-Windows to remote PSRP over WSMan.  This library currently has a number of limitations and issues.  To continue to support WSMan based remoting, we should consider writing a new library in managed code.  It also appears that corefx supports Kerberos/NTLM over HttpClient so that should solve one of the immediate limitations with the native library.  This library should also be a generally useful public api on nuget for other languages to remote into PowerShell via PSRP.

@iSazonov tests is lacking which is why we get reports of issues that should have been caught by tests.  In this case, we would add tests along with this porting work.  We would probably use the same library on downlevel Windows that doesn't have WMF4+, however, this library isn't expected to have full parity with WinRM (at least initially) so relying on WinRM in those cases would make sense.  Long term, it would make sense to have a single library for all platforms.

In which repository should this be done?
We need at least a test environment.

@iSazonov I created https://github.com/PowerShell/WSMan-Client-Library if you want to experiment.  cc @PaulHigin

If we want to create a new managed version of WSMan client, then I feel we should start with an RFC.

... and continue with tests :-)
Seems it will be large and complex RFC.

How this correlate with https://www.dmtf.org/standards/ws-man ?

@iSazonov PSRP over WSMan relies on the PowerShell Remoting Protocol which is built on top of WS-Man (or SSH now in PSCore6) which is the same as the one you linked to.  WS-Man is a SOAP based protocol that goes over HTTP(S).

So we should port this client and get direct dependency on native OMI library?

@iSazonov the goal here is to remove dependency on OMI library altogether and just have C# code

I see OMI project is actively updated. Shouldn't this issue be addressed there? I mean OMI client library ported at first in OMI project? What is a reasonable compromise?

PowerShell remoting uses OMI only as a bridge for non-Windows platforms.  Its support of WinRM client is incomplete and problematic.  My goal is to completely remove OMI as a dependency.  I agree with @SteveL-MSFT that the best way to do this is to investigate implementing WinRM client in cross-platform managed code, resulting in an RFC that outlines the work required.

It seems I started to understand :-)

We really will not have a conflict with the OMI project?
Having two client (Windows (WMF) and the new one on Unix) is seems a problem too. CoreFX reimplemented HttpClient to exclude curl and get the same behavior on all platforms.
I assume that we are doomed to the same thing - to have single managed WinRM client library for all platforms including Windows 10 (not only Windows 7 without WMF4). In other words, PowerShell Core uses the new managed client, Windows PowerShell uses WMF client.

@iSazonov I've had discussions with the OMI team internally and there is no conflict or overlap.  We should use the same client code for both Windows and non-Windows although that would not happen initially as some capabilities we get from WinRM are not a priority for non-Windows.

@SteveL-MSFT Could you please update the issue description and title that we want to implement WinRM client on managed code?
Is there someones (firms) to whom this may be useful and who could be contribute/test? You could blog post to announce the new project.
Also I hope your team prepares the RFC (I have no idea who else could do it.)
Currently, I can only review a code in the repo and maybe reorganize/cleanup it to make it easier to add the new experimental code.

@iSazonov I think this specific item is pretty specialized and complicated so unlikely for someone in the community to be able to contribute.  Since we have the new repo for this work, I'm going to close this item.  It's not blocking at this time, but will become blocking in the future if more customers want to use PSRP over WSMan from non-Windows.

Today I researched this a bit and came to the conclusion that it could be useful for other projects on managed code. There is nothing on GitHub like WSMan on C#. I hope the project will not be frozen for a long time. Ping me when it will start.

@iSazonov to set expectation, I don't expect to start on this until at least April 2019

@SteveL-MSFT @PaulHigin What is a status of "WSMan on C#"? We receive continuous issues for remoting from Unix-s.

Guys, any progress on this?


Add tests for untested question types

Description
Add tests for untested question types and address correction fields in the JSON export
Release notes
n/a
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[x] Created unit and/or browser tests which fail without the change (if possible)
[n/a] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[n/a] Extended the README / documentation, if necessary

Issue(s) this completes
Part of #6805

#8017  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @avaleske and the rest of your teammates on  Graphite

Merge activity

Jul 10, 8:56 PM EDT: @avaleske merged this pull request with Graphite.


deploy same plugins as in the readme file

Hello
In the README file with instructions there are several plugins  listed under data/static/sensu/checks
Can you share those too ?If not , how do i deploy such plugins ?

Please refer to Sensu's documentation for plugins. This is not specific to the Ansible role:
https://sensuapp.org/docs/


Hover validation

https://github.com/sourcegraph/issues/issues/138
I don't know how to deploy this.

The PR LGTM. But I am adding better dev/publish instructions now, and my hope is that they are good enough for you to follow yourself (so I spread the knowledge here). Will post back here when they are ready for you to follow then merge+publish.

@felixfbecker I am going to merge and deploy this to get this fixed sooner. Can you take a look at the updated README and see if it would have successfully helped you deploy this yourself? https://github.com/sourcegraph/sourcegraph-langserver-http#readme

I missed a problem when merging this. Fixed: https://github.com/sourcegraph/sourcegraph-langserver-http/commit/5c7de4868cc84d24810fcf4cc1ee63e38d9c1442

an you take a look at the updated README and see if it would have successfully helped you deploy this yourself?

One thing I am confused about is that this repo seems to publish itself as a private npm package (which makes the badges show errors). Are we referencing that from the main repo to bundle the extension into the web app? This seems to contradict the text though:

To release a new version (which will immediately be used by all Sourcegraph instances), you need to bundle and upload that file.

Also, regarding "which will immediately be used by all Sourcegraph instances", isn't that dangerous? Shouldn't we bake them into the frontend like we do with the Phabricator bundle?
Could this repo (and other extensions) get automatic deployments?

It doesn’t publish itself anymore. That was a mistake.
Re: dangerous, yes (from a backcompat POV).
Automatic publishing of the extension to Sourcegraph would be great for the extension authoring experience in general.

So what do you think of doing it like with the Phab bundle? I.e. do publish to npm, bake into frontend, get updates from Renovate.

Automatic publishing of the extension to Sourcegraph would be great for the extension authoring experience in general.

If the publish step is just a shell command it could be done with the https://github.com/semantic-release/exec plugin. The package.json could be updated by using the npm plugin for prepare. But it would probably be nice to have a dedicated plugin like there is for VS Code extensions: https://github.com/raix/semantic-release-vsce (that should be easy to fork)

What is the versioning story for extensions?

Do we support versions at all, and are older versions still served?
Are they immutable?
Do we enforce version numbers to match semver?
Do we support prereleases / previews? Release channels?

https://github.com/sourcegraph/sourcegraph-langserver-http/pull/4#issuecomment-419127248 sounds good.
As for the other questions re: versioning story, I can answer based on the current state but it is not the intended end state, so don't take this to be normative. We have a field called version in the DB registry_extension_releases but don't do anything with it yet. We also have an unused DB field called tag for release, beta, etc. Releases are immutable given a release ID (which is a sequential number, such as 10 in https://sourcegraph.com/-/static/extension/10.js?bo5pbfeaor40), but nothing is read/written/enforced about versions.
I think that being casual about releases (not exposing version/tag, not enforcing semver, etc.) is fine for now, but we'll find out quickly what is needed as we get more people writing extensions. This would be a great area for you to help with next iteration.


Feature AWS lambda in local playground

AWS lambda in local playground : SAM or serverless framework to launch and test lambda in local

@MinhHungPhan the update is done!


[dv/utils] added 6MHz to clk_freq_mhz_e

Signed-off-by: Dror Kabely<EMAIL_ADDRESS>

@dkabely-ot
sorry, I should ask earlier. What block uses this 6MHz as the bus clock? Most of our block-level TB doesn't expect to run with such slow clock, which causes many tests timeout or other errors.  I'm thinking to find a way to fix them. Thanks

It is for otp to run init sequence before the calibration. It only uses
6MHz for read.
On Thu, Aug 5, 2021, 11:13 PM weicaiyang @.***> wrote:

@dkabely-ot https://github.com/dkabely-ot
sorry, I should ask earlier. What block uses this 6MHz as the bus clock?
Most of our block-level TB doesn't expect to run with such slow clock,
which causes many tests timeout or other errors. I'm thinking to find a way
to fix them. Thanks
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/7574#issuecomment-894028570,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOOMLJLLKULIFNNP7ADLT3N4RZANCNFSM5BO2I7FA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

It is for otp to run init sequence before the calibration. It only uses 6MHz for read.

Thanks Cindy. Let's discuss how to fix this tomorrow. 6MHz is 4 times slower than the slowest clock we defined before. Most of TB doesn't expect to use such slow clock.


Enable PSDeploy functionality on Linux

This will enable the use of PSDeploy on Linux by addressing case sensitivity, path resolution, tool availability (Robocopy), and framework differences.
Areas addressed:

Updates the main *-PSDeploy* function to work in Linux. Fixes #105, Fixes #107
Udates the FileSystem deployment type to work in Linux. Fixes #106

Includes updates to Get-Hash

Hiyo!  Sorry, busy prepping for / going to a conf - will try to get to this over the weekend
Cheers!

Alrighty, added a quick bit that skips some weird PSYaml thing (relies on $ENV:TEMP).  Will probably just use powershell-yaml if we actually want to keep supporting yaml based deployments, but this at least avoids an error on load.
Check /poweryaml/shadow if you ran this elevated, it might exist now : )
Leaving this open for now - if this commit works for you let me know, and I'll merge it all in!
Thanks again!


Makes context page properties optional in timeOnPage

We have to make the context page properties optional due to the same issue we had here.
We do not need to add a path property because context_page_path is already provided as a common field from Segment.

No...I haven't done anything. I'm so confused lol

:rocket: PR was released in v1.21.0 :rocket:


Fixed warning about redundancy. clippy lint

Fixed Redundant Conversion:
The array slice automatically converts to an iterator, so the call to .into_iter() is unnecessary.

Thanks!


Adopt ErrorNoTelemetry on expected errors

Currently we have a lot of errors which are expected to occur and are being thrown on purpose but end up polluting our telemetry pipeline. The newly added ErrorNoTelemetry class acts as a normal Error but instead does not get sent through telemetry and therefore does not pollute the error health site. Further adoption of this class will continue increasing the usefulness of the error site by allowing more of the errors to be actionable on our part.

Closing as I believe these have been adopted in all the necessary places.


Improve --set flag and implement it for the apply command

Currently, we have --set flag only implemented for the create command. We would like to have it for apply command as well.
But there as an bug in current implementation, which should be fixed before. As reported in the issue #381, current implementation is case sensitive, so if you execute:
kubicorn create knova -p azure --set location=uswest

It would fail. But if you execute
kubicorn create knova -p azure --set Location=uswest

It would work. It should work as expected with lower case too.
The helm project implements something similar, so maybe it could be useful to take a look at their implementation. Their implementation is located here.
Our current implementation is in the cmd/create.go file.
If you'd like to learn more about kubicorn project, you can read The Project Walkthrough.
If you have any question, comment on the issue, join us on the #kubicorn channel in the Gophers Slack community or open a PR. We'll always do everything we can to get the PR though.

@xmudrii the link to the project walkthrough in the issue description is broken (small typo on the project word) http://kubicorn.io/documentation/projetct-walkthrough.html -> http://kubicorn.io/documentation/project-walkthrough.html

@xmudrii you are using swalker dependency, which is case sensitive.
I don't no what is the edge cases here, but an easy fix is changing L153 to this:
err := swalker.Write(strings.Title(parts[0]), newCluster, parts[1])

@m4ns0ur that could work, would you like to open a PR?

@xmudrii sure! Is there any related test on this file, to be updated?

@m4ns0ur nope, we don't have cmd related tests


DesertTreasure Ask about the Diamonds of Azzanadra "yes" option

Did a fix to this, should hopefully work

Unfortunately this wouldn't work as the 'Yes.' option is the first option in both the incorrect and correct cases. I've implemented a new functionality which allows you to exclude highlights based on other present text with https://github.com/Zoinkwiz/quest-helper/commit/1605fbb3279c607545024d27b5c11f897d20e92d, which should also work for other similar scenarios which we'll need to re-visit.


GoPay oops, API returned :

Installed latest plugin in shopware and entered our details. This is our log. What to do now? I've set mode to production. Do you need GoID or Cliend Id to investigate?

Hello,
Could you please send us complete dump of your request with all parameters (including your production credentials)? Please send us all information via<EMAIL_ADDRESS>


Support for Discord notification

Feature description
Being able to send message/notification through Discord

done in https://kestra.io/plugins/plugin-notifications#discord


Fix the GitLab release pipeline

Fix the GitLab release pipeline by utilizing different secrets (the new Zarf robot account we just got)
I have NOT added these secrets yet to the Zarf repo in Repo1. I will do so after this gets approved but before it gets merged.

/test all


Allow users to change port number for Visualizer

Rather than force users to use port 8002, allow users to change the port number.
Can use a flag in opensim.conf.

@chrisdembia if we merge this on both repos, GUI first then opensim-visualizer then it should be no op to application, then we can test changes port number afterwards. Thoughts?

Sounds good. Go ahead.

PR to opensim-gui has been merged. usage by opensim-visualizer is in PR https://github.com/opensim-org/opensim-gui/pull/1047

@chrisdembia will send out instructions for testing.

To test:

Place the following in /etc
OpenSim.conf.txt (rename to OpenSim.conf).
Ensure the visualizer still works (load a model, make sure it shows up in the GUI).
Open a web browser and navigate to http://localhost:8999/threejs/editor/index.html and ensure the visualizer shows up here. Make sure that http://localhost:8002/threejs/editor/index.html does NOT show the visualizer.
Ensure that setting the port in OpenSim.conf to either 80 or 9000 causes the port to be 8002 (in a web browser), and that the GUI visualizer still works.

I performed the steps above on Mac and everything worked as expected.

@carmichaelong Thanks for testing. Browsers are nasty in caching URLs, so if that worked once I'd assume we're good. we're not publicly supporting using the browser anyway. Can you use a different browser (Chrome, Firefox,etc...)?

I just did a few steps that seem to agree with the caching issue:

Went to port 8999 again. It opened up the visualizer.
Hit Shift+F5 to force a full refresh. Visualizer doesn't show up.


Comments not reviewed yet showing on the report.

Seen in Dev and Demo.
Comments are still pending review but already showing up in the report.
For example, https://met-web-dev.apps.gold.devops.gov.bc.ca/eao/engagements/132/dashboard has 2 submissions of 3 comments each. One submission is still pending review but the comments are already showing in the report.

Verified, only the approved comment is showing on the report.

@VineetBala-AOT Let's chat. I looked at the Sierra Terra and still see the pending comments in the report.


Fix editing/viewing of hidden files

When a hidden file is opened, it leads to a browser error.

Apparently, it's possible to create a new hidden file from the sftp-browser. It can even be opened in the same session.


Keyboard Interactions hijack editable elements

Describe the bug
When user is trying to move the cursor in an input element using the arrow keys, the map pans instead.
To Reproduce

Initialize map with keyboardEventTarget: document and default interactions.
Focus to input element, type something and try to move the cursor using the arrow keys.

Expected behavior
The cursor moves in input field and map stays still.
I made a workaround for this by creating a custom condition for KeyboardPan and KeyboardZoom.
The workaround implements targetNotEditable  on mapBrowserEvent.originalTarget.
https://github.com/openlayers/openlayers/blob/master/src/ol/events/condition.js#L210

This issue can be reproduced with: https://codesandbox.io/s/issue-10270-iu8u6


expand default lyrics background

before:

after:

thank you again for all of your fixes and stunning improvements.


[SPARK-25425][SQL][BACKPORT-2.4] Extra options should override session options in DataSource V2

What changes were proposed in this pull request?
In the PR, I propose overriding session options by extra options in DataSource V2. Extra options are more specific and set via .option(), and should overwrite more generic session options.
How was this patch tested?
Added tests for read and write paths.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #96282 has started for PR 22474 at commit bf3a52c.

Test build #96282 has finished for PR 22474 at commit bf3a52c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96282/
Test PASSed.

Thank you, @MaxGekk . Merged to branch-2.4.

Since it's merged, could you close this PR?


Add 2.9.0 directory for docs

Copies the current 2.8.0 docs directory to a new 2.9.0 directory in preparation of the upcoming 2.8 release.

Can this be merged ?


Security concern (SQL Injection)

I have created custom UI to create filters query (will later leverage the full potential with combinators and nesting)

Wondering whether there's a possible SQL injection breach:

I manipulate the field SQL generated from the query builder component using transformQuery, replacing it with values from DB
I format the query using formatQuery which parseNumbers flag turned on, not using the parameterized option as it doesn't play out well with Prisma

The output of such results in:

Do you see any possible issues I should be concerned with?

Definitely a problem
(1) If the UI is rendering to SQL on the frontend and then being sent to the API to be executed directly, then any user could open the devtools console and call the API themselves with an arbitrary SQL string. You should instead pass the rules object and compile to SQL on the backend.
(2) If you're already doing something like that, then the second part of protection is parameterization.
Here is OWASP:
https://cheatsheetseries.owasp.org/cheatsheets/SQL_Injection_Prevention_Cheat_Sheet.html

Parameterized queries force the developer to first define all the SQL code, and then pass in each parameter to the query later. This coding style allows the database to distinguish between code and data, regardless of what user input is supplied.
Prepared statements ensure that an attacker is not able to change the intent of a query, even if SQL commands are inserted by an attacker.

"Option 1: Use of Prepared Statements (with Parameterized Queries)"
You can make prisma do it via $rawQuery: https://www.prisma.io/docs/concepts/components/prisma-client/raw-database-access
(3) Paramaterization is the agreed-upon standard for protecting against SQL injection, but if you choose to go down another route, people used to escape every user input. So you could iterate through the value of every field and escape quotes, but you're also going to have to do that for operators, and fieldnames, and basically the value of any key output by formatQuery. Even then it's a potentially dangerous path.
(4) You could basically re-compile the query more safely by looping through every condition / rule and building a chain on prisma methods.

I agree completely with @zachblume here. (Thanks for the great answer, Zach!) I would definitely recommend passing the query object over the wire, not the SQL or even the parameterized SQL. Better to use formatQuery(query, 'parameterized') (or 'parameterized_named') along with any post-processing, on the server and not the client.
I investigated Prisma in the context of RQB a little bit when responding to #414 and came to the same conclusions.

It might be worth looking further into this (parsing RQB to popular ORMs) and adding documentation (if not a full built-in parser) for * ease of use and * sql injection concerns. I just built a parser in an application from RQB -> postgREST query object which let me compile on the client-side, I'm sure that this is a very common use of RQB

Thanks for your detailed answers!
Just to clarify, I run the formatQuery as well as the transformQuery on the backend (not sure it's the intended behavior, but it works).
This is our UI:

The SQL is generated on the backend, given all the inputs you select on the 'Data' panel.
I was trying to play around with different inputs and could not get around values being surrounded single quotes.
Do you see any problem with this approach? Do we still need to use parameterized query on the backend? If yes, can you give an example of why
Thanks again!

@zachblume I'm curious what you meant by "the name thing." Does the "parameterized_named" format help with that at all?

I encountered the same issue with single quotes when using formatQuery (query, 'SQL')；How did you solve it, except for generating SQL on the backend

I ended up whitelisting possible operators sent from the client.
Since the values are being sanitized it should work fine.
Thanks


Add other old Newcastle CCGs to Newcastle Gateshead (13T)

Newcastle CCGs merged. We currently only show Newcastle Gateshead on our dashboards (ignoring the error where Gateshead is still showing).
A new code was not created when the CCGs merged, 13T was instead used as the code for the merged CCGs. For data prior to their merge, we only show data for the original 13T, and after the merge it is the data for all of them. It isn't clear to the user that this is what we've done. We should add the CCG data from the old CCGs to the CCG total. We also need to make a note somewhere (either on dashboard or FAQs) that this is what we've done

There were also changes to other CCGs in April:

Cumbria CCG will become North Cumbria, Lancashire North will be Morecombe Bay. Both are keeping their old codes. Some practices in these CCGs are moving. User has been in touch to tell us which practices are moving into Morecombe Bay, and this should also be reflected in the ODS Quarterly update (May 26th)
Manchester CCGs  (00W, 01M, 01N) are merging, new CCG will be Manchester CCG (14L)

Some GP Practices are also moving CCGs, full details here: https://digital.nhs.uk/organisation-data-service/news-and-updates and should be in the May 26th update.

Statement of problem:
┌──────┬──────────────────────────────────┬────────────┬────────────┐
│ code │               name               │ open_date  │ close_date │
├──────┼──────────────────────────────────┼────────────┼────────────┤
│ 00F  │ NHS GATESHEAD CCG                │ 2013-04-01 │ 2015-03-31 │
│ 00G  │ NHS NEWCASTLE NORTH AND EAST CCG │ 2013-04-01 │ 2015-03-31 │
│ 00H  │ NHS NEWCASTLE WEST CCG           │ 2013-04-01 │ 2015-03-31 │
│ 13T  │ NHS NEWCASTLE GATESHEAD CCG      │ 2014-11-26 │ ¤          │
└──────┴──────────────────────────────────┴────────────┴────────────┘

Currently:

Measures use the current membership of a practice
Analysis uses the membership of a practice as it was at the time

As I understand it, the solution is to change analysis to use current membership, as per Measures. To achieve this:

The spending API displays current CCG membership but queries on contemporary membership. These should almost certainly match.
All other table queries are based on views, which in turn use the normalised_prescribing_* views, which therefore should change to use current CCG membership in every case

A side-effect of this approach is that old CCGs will still show up for practices which have closed (which I presume is the case in issue #401).
Potential solutions for this:

Attribute closed practices to the CCG that they would geographically be included in, were they still to exist (arguably the best solution?)
Exclude closed practices from the CCG-level measures, but keep them in analyse charts (so we'll get tiny effects for some closed CCGs in some cases, a bit like the example in #401, but only for analyse charts)
Exclude closed practices everywhere (so we lose some data)

I would vote for "Attribute closed practices to the CCG that they would geographically be included in, were they still to exist" because excluding the old code could leave a significant gap, if for example a large practice splits and is assigned two new practice codes. We just need to explain it clearly.
I still like the idea of showing a population timeline for each practice and CCG so it's more clear when strange things are happening.

this is just an extension of the other problem, i.e. where does practice data go when it "closes".  Most of the time it merges with another practice.  Resolving this one would reduce a lot of the fossilised practice data we have.   In the meantime we should attribute to geographical area, as at a CCG level that is in effect the same as merging the practice data.
Also, this is clearly nonsense:
│ code │               name               │ open_date  │ close_date │
├──────┼──────────────────────────────────┼────────────┼────────────┤
│ 00F  │ NHS GATESHEAD CCG                │ 2013-04-01 │ 2015-03-31 │
│ 00G  │ NHS NEWCASTLE NORTH AND EAST CCG │ 2013-04-01 │ 2015-03-31 │
│ 00H  │ NHS NEWCASTLE WEST CCG           │ 2013-04-01 │ 2015-03-31 │
│ 13T  │ NHS NEWCASTLE GATESHEAD CCG      │ 2014-11-26 │ ¤
13T, although allocated a code on 26th Nov 2014 wouldn't have been running until April 1st 2015...

This relates to #215

It turns out (notes here) that we can't accurately place practices in their CCGs by their location, because we don't have a reliable dataset of practice locations to use (we have to go on the centroids of the practice postcode, which will often place them in the wrong CCG where the postcode overlaps a CCG boundary).
Without accurate coordinates of practices, this approach will not be possible.
We are still likely to be able to place practices perhaps 75% of the time, but this is probably not really useful.

Now I'm trying to get the information via an FOI.

So according to the FOI response, PPD don't record the data in a database. (They just stuff the paperwork in the bottom of a locked filing cabinet stuck in a disused lavatory with a sign on the door saying ‘Beware of the Leopard).
Have tried PCSE who also, apparently, request almost the same information, via their "contact us" form, in early September - no reply.

FOI to PCSE is here: https://www.whatdotheyknow.com/request/practice_mergers_and_closures_no#incoming-1108580.

Note I don't expect a successful response to that one.
We will almost certainly have to come up with a solution that doesn't include mergers data.

Finally!  https://www.whatdotheyknow.com/request/practice_mergers_and_closures_no?nocache=incoming-1165255#incoming-1165255

@sebbacon i suspect the "effective date" is the one we want, as looking at it i think it refers to the date the merge actually happened - I suspect the "system merge date" is the date Capita merged the practices on the system (or not).
Either way, it shouldn't make too much difference, as we'll only see month granularity in the prescribing data.

Wrapped up into #891


Mobile trading Page: Scroll position issues

When I click Trade, instead of taking me to the top of that page, it remembers my scroll position in the market info page and matches that. Behaviour should be that when I click Trade it takes me to the top of the Trade screen each time

fixed - closing


Investigate Editor Placeholder Adoption

The editor now supports proper placeholders and we should investigate where we can adopt them.
Here is an example usage of the new placeholder API. (link will only work after 07/06/2024, once this is merged)

[ ] @lszomoru SCMInputWidget https://github.com/microsoft/vscode/blob/2a3498d961675534434e0ad057587a584b5f459b/src/vs/workbench/contrib/scm/browser/scmViewPane.ts#L2341
[ ] @roblourens https://github.com/microsoft/vscode/blob/2a3498d961675534434e0ad057587a584b5f459b/src/vs/workbench/contrib/chat/browser/contrib/chatInputEditorContrib.ts#L138

Known issue (will be fixed soon)

https://github.com/microsoft/vscode/issues/211403

Maybe you also want to adopt it in SuggestEnabledInput, which overlays a dom element over the editor to create a placeholder? https://github.com/microsoft/vscode/blob/4a4ae4603279ad4d836c4d2b17f055f6708d59ff/src/vs/workbench/contrib/codeEditor/browser/suggestEnabledInput/suggestEnabledInput.ts#L155

I am happy to adopt it in Chat when https://github.com/microsoft/vscode/issues/211403 is fixed

Thanks! Please let me know when https://github.com/microsoft/vscode/issues/211403 is fixed so that I complete the adoption.

Looking at this with the fix to #211403, I like the ellipses, but should I be styling the placeholder with css? I don't remember having to do that before

I like the ellipses, thanks for that, but I'm seeing this in the wrong position. I have some padding in this editor, maybe that messes it up

Fixed!

Next problem: the placeholder container is too narrow, it looks like it allocates space for the vertical scrollbar, but there is no vertical scrollbar


Bump pandas dependency

Is there a reason for ressimpy being locked to pandas v1? Would be nice to loosen up the pandas dependency if possible, so that people can upgrade to pandas v2.
Describe the solution you'd like
pandas = ">=1.5,<3.0"

I think the core reason is one of our dependencies (resqpy) requires a pandas 1.5 and would break if we were to move to pandas v2.
Users are able to upgrade to pandas v2 post poetry install. But we don't guarantee that the resqpy function calls will then work.


OAuth2 Error 500 UserSignIn No Matching Session

Description
When attempting to log in via Discord or Google OAuth2, it opens up the other site and shows the authorization consent screen. Upon clicking yes, I'm redirected to my callback URI but its a big error 500 with no error message/text or explanation. Looking in the gitea logs, I see these messages:
...eb/routing/logger.go:102:func1() [I] router: completed GET /user/oauth2/discord for [REDACTED]:34454, 307 Temporary Redirect in 2.0ms @ auth/oauth.go:849(auth.SignInOAuth)
...rs/web/auth/oauth.go:939:SignInOAuthCallback() [E] UserSignIn: could not find a matching session for this request
...eb/routing/logger.go:102:func1() [I] router: completed GET /user/oauth2/discord/callback?code=[REDACTED]&state=[REDACTED] for [REDACTED]:34470, 500 Internal Server Error in 2.9ms @ auth/oauth.go:888(auth.SignInOAuthCallback)

I tried to hunt around the open issues for similar things, but #5005 and #5551 don't seem to be my issue. This occurs regardless of DISABLE_REGISTRATION setting and attempts after the first still return the same 500 result.
The Github OAuth2 does work after the first time (which fails with a 500). But nothing I've tried manages to get the other two working. I've checked and double-checked my client id and secret as well as the callback URIs. Any information you might need I'm happy to try providing.
Gitea Version
1.20.0-rc2
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
2.40.1
Operating System
alpine:latest
How are you running Gitea?
I build it myself and run it in a docker container.
Database
SQLite

Two possibilities:

ROOT_URL doesn't match
#27033

Feel free to reopen if there is still a problem.


Add outputs for all resources

Resources export outputs which need to be exposed as part of this module to enable more integration with this module.

Addressed in #31

#31 has now been merged


Hyperlinks are not clickable in exported PDF

Not entirely sure if this is an issue with the theme or Obsidian in general.
Theme Version: 0.1.8
Obsidian Version: 1.2.8
Problem: Creating hyperlinks in a markdown document using this theme are not clickable when using the Export to PDF option.
Steps to Reproduce: Use the Export to PDF option on a markdown document (example below) that contains a hyperlink, and open in an app such as Adobe Acrobat or Firefox.
# Test Document
This is my [blog](https://notateamserver.xyz)!

Fixed


[WIP][SPARK-44098][INFRA] Introduce python breaking change detection

What changes were proposed in this pull request?

Integrate AexPy into Spark testing, to help PySpark detecting python breaking changes. SPARK-44098
This pull request is working in progress. There are some extra works to do, such as adding filtering rules and introducing pyspark specific checking logic.
Why are the changes needed?

There have been breaking change detections for Binary Compatibility and Protobufs for now, but none for python.
Does this PR introduce any user-facing change?

No. Only for developers.
How was this patch tested?

Manual test for now.
We add an entrypoint script under dev directory, and you can use the original AexPy tool under dev/aexpy directory.
# Compare PySpark APIs in current branch with branch-3.4
python dev/python-detect-breaking-changes.py branch-3.4

# Use the original AexPy
cd dev/aexpy
python -m aexpy --help

The caching directory (detailed result and logs) is located at dev/aexpy/cache.

the python linter fails with
Python compilation failed with the following errors:
*** Error compiling 'dev/aexpy/aexpy/diffing/evaluators/typing.py'...
  File "dev/aexpy/aexpy/diffing/evaluators/typing.py", line 59
    match b:
          ^
SyntaxError: invalid syntax

*** Error compiling 'dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py'...
  File "dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py", line 43
    match node.func:
          ^
SyntaxError: invalid syntax

probably need a mypy.ini file to disable mypy checking

@zhengruifeng This error probably occurs in lint-python script, when it compiles all python files by Python 3.9 (defined in env var, specified in workflow files), which is not compatible with the code of aexpy (requires 3.10).
function compile_python_test {
    # compileall: https://docs.python.org/3/library/compileall.html
    echo "starting python compilation test..."
    COMPILE_REPORT=$( ("$PYTHON_EXECUTABLE" -B -mcompileall -q -l -x "[/\\\\][.]git" $1) 2>&1)
    COMPILE_STATUS=$?

    if [ $COMPILE_STATUS -ne 0 ]; then
        echo "Python compilation failed with the following errors:"

could updating the option -x "[/\\\\][.]git|aexpy" in the compile command fix this?

the python linter fails with
Python compilation failed with the following errors:
*** Error compiling 'dev/aexpy/aexpy/diffing/evaluators/typing.py'...
  File "dev/aexpy/aexpy/diffing/evaluators/typing.py", line 59
    match b:
          ^
SyntaxError: invalid syntax

*** Error compiling 'dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py'...
  File "dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py", line 43
    match node.func:
          ^
SyntaxError: invalid syntax

probably need a mypy.ini file to disable mypy checking

@zhengruifeng This error probably occurs in lint-python script, when it compiles all python files by Python 3.9 (defined in env var, specified in workflow files), which is not compatible with the code of aexpy (requires 3.10).
function compile_python_test {
    # compileall: https://docs.python.org/3/library/compileall.html
    echo "starting python compilation test..."
    COMPILE_REPORT=$( ("$PYTHON_EXECUTABLE" -B -mcompileall -q -l -x "[/\\\\][.]git" $1) 2>&1)
    COMPILE_STATUS=$?

    if [ $COMPILE_STATUS -ne 0 ]; then
        echo "Python compilation failed with the following errors:"

could updating the option -x "[/\\\\][.]git|aexpy" in the compile command fix this?

@HyukjinKwon do we have a way to completely disable the linter on a module?
I tried adding it to dev/tox.ini but seems not work

the python linter fails with
Python compilation failed with the following errors:
*** Error compiling 'dev/aexpy/aexpy/diffing/evaluators/typing.py'...
  File "dev/aexpy/aexpy/diffing/evaluators/typing.py", line 59
    match b:
          ^
SyntaxError: invalid syntax

*** Error compiling 'dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py'...
  File "dev/aexpy/aexpy/extracting/enriching/callgraph/basic.py", line 43
    match node.func:
          ^
SyntaxError: invalid syntax

probably need a mypy.ini file to disable mypy checking

@zhengruifeng This error probably occurs in lint-python script, when it compiles all python files by Python 3.9 (defined in env var, specified in workflow files), which is not compatible with the code of aexpy (requires 3.10).
function compile_python_test {
    # compileall: https://docs.python.org/3/library/compileall.html
    echo "starting python compilation test..."
    COMPILE_REPORT=$( ("$PYTHON_EXECUTABLE" -B -mcompileall -q -l -x "[/\\\\][.]git" $1) 2>&1)
    COMPILE_STATUS=$?

    if [ $COMPILE_STATUS -ne 0 ]; then
        echo "Python compilation failed with the following errors:"

could updating the option -x "[/\\\\][.]git|aexpy" in the compile command fix this?

sorry for the late reply, I tried a few ways but didn't work.
maybe we can hold on and wait for the upgrading python 3.10 first


Add Exists guard for import of conanbuildinfo.props

If the generated conanbuildinfo.props no longer exists, the projects fails to load because the added import fails.
As it seems to not be possible trigger the execute for a project that is not loaded, it means one has to revert the change done by the extension to the project file.
Would be nice if the Exists condition (https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-conditions?view=vs-2019) would be used to guard the import.
E.g.
  <ImportGroup Label="PropertySheets" Condition="Exists('conanbuildinfo.props')">
    <Import Project="conanbuildinfo.props" />
  </ImportGroup>

Yes, it currently seems like one has to add the conanbuildinfo.props file to source control, but since it's rewritten on build config change, it constantly changes, which isn't ideal. Is there any other way around this?

You could try manually adding the exist guard to the line added by the extension yourself. e.g..:
-<Import Project="conanbuildinfo.props" />
+<Import Condition="Exists('conanbuildinfo.props')" Project="conanbuildinfo.props" />

At least in the small experiment I did, the extension still regarded the entry with the added guard as it's own, and did not create a new one without the guard.

I did, but wasn't so lucky - the extension created a second entry and broke the project :/

For now, my solution is to run conan install in our conan setup batch script:
if not exist "path\to\build\output\.conan\conanbuildinfo.props" (
    @echo Creating initial conanbuildinfo.props file...
    conan install "path\to\conanfile.txt" ^
                  -g visual_studio ^
                  --install-folder "path\to\build\output\.conan" ^
                  --profile "path\to\source\winproj\conan_x86_64_release.profile" ^
                  --build=outdated ^
                  --update  >tmp_out 2>&1 || (type tmp_out & pause & del tmp_out & exit /b 1) & del tmp_out
)

It seems to be the same problem as in issue #128. I propose a workaround in extension for this case. See #185.

I was able to get the extension to recognize the entry. I would suggest verifying that the Extension's configured destination for the props file is the same as the Import Line. I would also suggest converting the hardcoded path that the extension generates to one with variables. For example the default destination would be,
<Import Condition="Exists('$(OutDir)\.conan\conanbuildinfo.props')" Project="$(OutDir)\.conan\conanbuildinfo.props" />

An additional note is that I found this only work with Relative paths. Also it never works when the build directory is non-existent. Like on a fresh clone. Once the directory does exist though, this extension doesn't re-add


Allow event to be sent on conflicts

Hey, I just made a Pull Request!
Following discussion at the Catalog SIG and several alternate POCs:

https://github.com/backstage/backstage/pull/16660
https://github.com/backstage/backstage/pull/16798
https://github.com/backstage/backstage/pull/16673

we realised it would be best to allow conflicts to be handled by sending an event when they are processed. This allows the implementation of a decoupled plugin to handle conflicts according to a user's needs. Currently they are dropped.
Implementation would looks something like this:
export default async function createPlugin(
  env: PluginEnvironment,
  providers?: Array<EntityProvider>,
): Promise<Router> {
  const builder = await CatalogBuilder.create(env);
  ...
  const conflictBroker = new DefaultEventBroker(env.logger);
  conflictBroker.subscribe(
    new ConflictEventSubscriber(env.logger, ['conflicts']),
  );
  builder.setEventBroker(conflictBroker);
  ...
  const { processingEngine, router } = await builder.build();
  await processingEngine.start();
  return router;

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@freben @alde Is this what you were thinking of as a first step?

Bumping

Not stale

@sblausten @efenner-cambia there's some review comments from @alde that should probably be addressed first before shipping :)

Sorry, I had given up on this getting approved and missed the latest comment. Thanks! Will take a look asap

ping @alde :)

@freben Do you have3 some idea when you will be able to review this again and get it merged?


Difference between running insanely-fast-whisper with or without Flash Attention?

Can someone maybe explain?

Not sure if I understand your question, here's my attempt at answering it:
Flash Attention is a faster way of running the Attention operation through parallelism and better work partetioning. This results is fasteer inference time.
However, it only works on latest GPUs.
(Closing this for now, feel free to re-open)

Not sure if I understand your question, here's my attempt at answering it: Flash Attention is a faster way of running the Attention operation through parallelism and better work partetioning. This results is fasteer inference time.
However, it only works on latest GPUs.
(Closing this for now, feel free to re-open)

Ah, yeah, my question was kind of stupid, since it's visible from the Benchmarks that Flash Attention 2 enables faster interference. Thanks for answering anyway :)


auth_client.cancel_all() does not seem to work; neither does auth_client.get_orders(product_id = 'ETH-USD')

I have solved the problem by downloading the gdax package from github directly. Thanks
I tried:
auth_client.cancel_all()
It gave an error message:
Traceback (most recent call last):
File "", line 1, in
File "/Library/Python/2.7/site-packages/gdax/authenticated_client.py", line 92, in cancel_all
data=json.dumps({'product_id': product or self.product_id}), auth=self.auth)
AttributeError: 'AuthenticatedClient' object has no attribute 'product_id'
I also tried:
auth_client.cancel_all(product_id = 'ETH-USD'),
It gave an error message:
Traceback (most recent call last):
File "", line 1, in
TypeError: cancel_all() got an unexpected keyword argument 'product_id'
I then tried
auth_client.get_orders(product_id = 'ETH-USD'),
this does not work either. It gave:
Traceback (most recent call last):
File "", line 1, in
TypeError: get_orders() got an unexpected keyword argument 'product_id'
I might have simply missed something. Please help out. Thanks.

I ran into this as well, and was able to fix it. I was using gdax==1.0.6 and installing it through pip. It seems like that version of the code is old, and does not match the documentation in the README. If you install from the git repo pip install /path/to/gdax/git/repo it should fix it.
Cheers.


teams: improved team creation form with owner

If you are a Portus admin, you might want to create various teams with
its respective owners. So far the path to achieve that was tedious and
not friendly. Admin had to create a team, add a member as owner and
remove himself as ownere later on.
With this patch, admin will be able to not only create a team through
the admin team page but also assign an owner different of himself.
Signed-off-by: Vítor Avelino<EMAIL_ADDRESS>Fixes #1765

Looks good to me. One thing though: I'd also add this field into the main teams page (only appearing if the current user is an admin, and the default would be the same current user).

One thing though: I'd also add this field into the main teams page (only appearing if the current user is an admin, and the default would be the same current user).

I thought about that but the problem is that the teams page lists all the teams that the user is member of. So, if we allow an admin to add a team from that page and defining a different owner, the added team wouldn't appear in the list. It would be confusing.
An alternative though (that I really like btw), is to get rid of this admin overview page and unify the admin and normal user pages. If user is an admin, we are more flexible with the policies resolve method. Be aware that some pages might change a little bit due to that but I think it's safe. We also need to worry about the impact on the API with this change.
I started doing what I suggested on #1766 but I'm more than happy to go with the unification approach. What do you think?

Based on our internal discussion, we are going with the unification approach. Going to rework on this PR.


EVM Mixer over WebbProvider<WebbWeb3Provider>

What is left on this PR?

Testing and contract adddreses management


Requires uninstalation of google-chrome-stable

I am on Linux Mint using Google-Chrome Version 46.0.2490.71  and while installing Nitroshare 0.3.0, it requires the uninstallation of google-chrome-stable and vice versa. Possible reason?

Are you installing via PPA or by using a binary package?

I am installing via DEB Package (i386).

Later I installed via PPA and it seems to be working fine now(no uninstallations), seems to be that i386 package is having some issues on my 64 bit computer.

Glad to hear you were able to get it working.
I'll see if I can reproduce this on one of my virtual machines and then see which package is causing the problem. I'm not sure I would be able to fix it though. The Debian packages only include a minimal set of dependencies and none of them can easily be dropped.


Remove unnecessary 'using'

Merging this one, but please focus on more substantial PRs because this has no significant effect on the code.

Ok @Eilon, but is there a phase for cleaning code and API review?

API reviews are substantial because they affect user experience.
Code cleanup is generally done opportunistically. It would take years to "clean everything up" in every single file in every single repo per all the coding guidelines, but the value just isn't there beyond some reasonable point.

Thanks @Eilon


"false" and "true" as translation keys are interpreted differently after upgrade from 1.1.1 to 1.2.0

What I tried to do
I tried to update my application dependency i18n from 1.1.1 to 1.2.0
What I expected to happen
No change in behaviour as there were seemingly no breaking changes in the commit list.
What actually happened
Some tests failed (😱😱😱), because a translation couldn't be found
Versions of i18n, rails, and anything else you think is neccessary
i18n 1.2.0
rails 5.2.2

I narrowed down the problem to one particular translation:
...
  ...
    in_app_dispatch:
      availability:
        false: 'nicht verfügbar'
        true: 'Smartphone App online'

i18n 1.1.1
[1] pry(main)> I18n.t("attributes.in_app_dispatch.availability")
=> {false=>"nicht verfügbar", true=>"Smartphone App online"}

i18n 1.2.0
[2] pry(main)> I18n.t("attributes.in_app_dispatch.availability")
=> {:false=>"nicht verfügbar", :true=>"Smartphone App online"}

As you can see, in 1.1.1 the keys are booleans while in 1.2.0 the keys are symbols. Now, I'm not saying that the previous version is better than the current version or that it was a smart decision to use true and false as translation keys. However, it's possible that this change was unintentional so I'm submitting this issue 😄.

I would class this as an unintentional regression in 1.2.0. A patch to revert this behaviour in 1.2.1 is what I would do.
On 14 Dec 2018, 02:40 +1100, Adam Niedzielski<EMAIL_ADDRESS>wrote:

What I tried to do
I tried to update my application dependency i18n from 1.1.1 to 1.2.0
What I expected to happen
No change in behaviour as there were seemingly no breaking changes in the commit list.
What actually happened
Some tests failed (😱😱😱), because a translation couldn't be found
Versions of i18n, rails, and anything else you think is neccessary
i18n 1.2.0
rails 5.2.2
I narrowed down the problem to one particular translation:
...
...
in_app_dispatch:
 availability:

   false: 'nicht verfügbar'

   true: 'Smartphone App online'

i18n 1.1.1
[1] pry(main)> I18n.t("attributes.in_app_dispatch.availability")
=> {false=>"nicht verfügbar", true=>"Smartphone App online"}
i18n 1.2.0
[2] pry(main)> I18n.t("attributes.in_app_dispatch.availability")
=> {:false=>"nicht verfügbar", :true=>"Smartphone App online"}
As you can see, in 1.1.1 the keys are booleans while in 1.2.0 the keys are symbols. Now, I'm not saying that the previous version is better than the current version or that it was a smart decision to use true and false as translation keys. However, it's possible that this change was unintentional so I'm submitting this issue 😄.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@adamniedzielski Just so I'm 100% sure the exact bug that I'm going to be fixing with 1.2.1...
Can you show me the exact call that breaks in 1.2.0, but works in 1.1.0?
You are only showing the example that presents the Hash with different keys between the two versions. I want to know how you're referring to either the false or true values within that hash.

@radar thanks for your prompt response 💚
The code that breaks (simplified) is:
available = ::InAppDispatch.for_user(user).currently_available?
t("attributes.in_app_dispatch.availability")[available]

currently_available? returns true or false.

this also generated a regression to us, in our case it manifests because we are doing a workaround to handle numeric keys, something similar to this:
en:
  LEVEL_LIST:
    1: Level 1
    2: Level 2
    # [...]

levels = I18n.t("LEVEL_LIST").map do |id, name|
  {id: id.to_i, name: name}
end

sort_data(levels)

@opsidao: does 1.3.0 fix your issue?