Distribution method

Elasticsearch plugins are usually distributed from a webserver, we should be able to provide a URL that people can use to download and access this plugin.

As spoken https://github.com/fair-search/fair-search.github.io has been created, already the current master snapshot version has been uploaded.


[$500] Settings - When the default contact is modified, the avatar for the share code is also changed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: .1.4-36.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to Settings > Share Code. Observe the profile avatar for the share code
Go to Settings > Profile > Change Contact Method. Return to check the share code avatar and note any changes

Expected Result:
The avatar for the share code should remain unchanged when the contact method is modified
Actual Result:
The avatar for the share code changes when the contact method is modified
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/16f19d05-4d93-42bd-86bb-b9129fe6562c
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0161643e6321e8cfc9
Upwork Job ID:<PHONE_NUMBER>504587264
Last Price Increase: 2024-02-05
Automatic offers:

Krishna2323 | Contributor | 0

Proposal
Please re-state the problem that we are trying to solve in this issue.
Settings - When the default contact is modified, the avatar for the share code is also changed
What is the root cause of that problem?
The QRShareWithDownload component uses the getAvatarUrl function to get the avatar URL for the logo prop.
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/pages/ShareCodePage.tsx#L90
However, since the avatar is default, the getAvatarUrl function will be called but the accountID used the generate a hash is computed differently because the updated email was used.
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/libs/UserUtils.ts#L125-L128
According to the comments in the code snippet above, I believe was intentional to prevent avatars from changing from the optimistic accountID to the realistic accountID replaced by the backend.
What changes do you think we should make in order to solve the problem?

In the ShareCodePage, use the condition check if the currentUserPersonalDetails?.avatar is suitable for the logo prop since it is already present.
If the condition is true, use currentUserPersonalDetails?.avatar instead of using the getAvatarUrl function.
What alternative solutions did you explore? (Optional)
We should also check if the allPersonalDetails?.[accountID]?.isOptimisticPersonalDetail in the getAvatarUrl function .
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/libs/UserUtils.ts#L125-L128
const originalOptimisticAccountID = email && allPersonalDetails?.[accountID]?.isOptimisticPersonalDetail ?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Settings - When the default contact is modified, the avatar for the share code is also changed
What is the root cause of that problem?
The QRShareWithDownload component uses the getAvatarUrl function to get the avatar URL for the logo prop.
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/pages/ShareCodePage.tsx#L90
However, since the avatar is default, the getAvatarUrl function will be called but the accountID used the generate a hash is computed differently because the updated email was used.
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/libs/UserUtils.ts#L125-L128
According to the comments in the code snippet above, I believe was intentional to prevent avatars from changing from the optimistic accountID to the realistic accountID replaced by the backend.
What changes do you think we should make in order to solve the problem?

In the ShareCodePage, use the condition check if the currentUserPersonalDetails?.avatar is suitable for the logo prop since it is already present.
If the condition is true, use currentUserPersonalDetails?.avatar instead of using the getAvatarUrl function.
What alternative solutions did you explore? (Optional)
We should also check if the allPersonalDetails?.[accountID]?.isOptimisticPersonalDetail in the getAvatarUrl function.
https://github.com/Expensify/App/blob/500dd0949123ae1cd7b84211c0093f3c832d6775/src/libs/UserUtils.ts#L127
const originalOptimisticAccountID = email && allPersonalDetails?.[accountID]?.isOptimisticPersonalDetail ?

@GandalfGwaihir's proposal looks good to me, straightforward!
C+ Reviewed
🎀 👀 🎀

Thanks for the bump @Krishna2323. After looking again, I am wrong here, this  proposal create could create more bugs will reevaluate proposals again, Sorry everyone for the confusion.
cc: @puneetlath

Waiting for CME bump @puneetlath

Still waiting for a CM Review bump @puneetlath

Assigned! Sorry for the delay.

The PR didn't end up being needed because another PR solved the same issue. However, the work was done, so we'll be paying the contributors out.
Payment summary:
@Krishna2323 - C - $500 - paid on Upwork
@Santhosh-Sellavel - C+ - $500 - to be paid on NewDot
@Santhosh-Sellavel please request on NewDot.
Thanks everyone!

Requested on ND

$500 approved for @Santhosh-Sellavel


Is there any logs?

Hi, i'm using gdrive in a cronjob that runs in the middle of the night, for some reason it stopped to work and im wondering if there's any gdrive logs where i can take a look at, i think the problem is the space available in the drive account but i just wanted to know if there is any log already or if i have to make one on the script side.
Thanks

Hi Luis,
gdrive outputs errors to stdout, so you can keep the outputs by editing your cronjob something like this
0 3 * * * /path/to/gdrive params > /var/log/gdrive.log 2>&1

that should work, thank you

Just for future references, i just apply the changes and worked as expected.


Error Handling: Add NotAMachOError for edge cases.

There are two edge cases early-on in the parsing process:
files too small to have a valid magic number and files
with valid magic but invalid contents (most notably, Java
classfiles).
The NotAMachOError class covers both of these cases, and is raised
in FatFile#get_fat_header and MachOFile#get_and_check_magic.
cc @UniqMartin

Exception Classes. Can we make it such that there is a single exception class that can be caught for cases where the file was successfully read, but turned out not to be a Mach-O or fat binary? I can think of three possible hierarchies that make sense to me (ordered by personal preference):
-+ NotAMachOError        # common ancestor, but not actually raised
 |-- MagicError          # used as before
 |-- TruncatedFileError  # too short
 |-- JavaClassFileError  # Java class file
 \-- …                   # more exceptions for cases we haven't thought of yet

-+ NotAMachOError        # too short, Java class file, …
 \-- MagicError          # used as before

-+ NotAMachOError        # common ancestor, but not actually raised
 |-- MagicError          # used as before
 \-- NonMagicError       # too short, Java class file, …

The important thing is that it would be sufficient to rescue NotAMachOError and interpret it as “regular file” (the use case in Homebrew's extension of Pathname), no matter what the exact cause is and without ignoring actual issues (e.g. due to unknown or misinterpreted load commands).

Additional Corner Cases. Can you add the following test cases and adjust the library code such that they succeed? (You might need to adjust the names of the exception classes per the first part of this comment.) In test/test_fat.rb:
def test_empty_file
  assert_raises MachO::NotAMachOError do
    MachO::FatFile.new_from_bin("")
  end
end

def test_truncated_file
  assert_raises MachO::NotAMachOError do
    MachO::FatFile.new_from_bin("\xCA\xFE\xBA\xBE\x00\x00")
  end
end

In test/test_macho.rb:
def test_truncated_file
  assert_raises MachO::NotAMachOError do
    MachO::MachOFile.new_from_bin("\xFE\xED\xFA\xCE\x00\x00")
  end
end

The first hierarchy looks good to me!

MachO::FatFile.new_from_bin("\xCA\xFE\xBA\xBE\x00\x00")

FatFile doesn't actually have a new_from_bin method, so I'm going to add another truncated classfile to test/bin (and add the missing method in a later commit).

FatFile doesn't actually have a new_from_bin method, so I'm going to add another truncated classfile to test/bin (and add the missing method in a later commit).

Totally missed that FatFile doesn't have that method, sorry. I think adding it (in a later commit) is still a good idea as it will make the interface for both classes more similar.

Ended up creating a Helpers.tempfile_with_data to handle these tests.

That's also a good solution and probably more broadly applicable.

The new Helpers.tempfile_with_data takes a block that handles setup and teardown for each temp file, so that should less of a hassle to work with.

There is one (now hidden) code comment about the exception classes in the test suite, that you haven't addressed or replied to, but that's not at all a blocker, just a detail:

Maybe check for the more specific exception classes like TruncatedFileError (instead of their common ancestor) here and in the other newly added test cases?

Overall I'm quite happy with how things look by now. Feel free to merge if you and the CI are happy. :+1:

Maybe check for the more specific exception classes like TruncatedFileError (instead of their common ancestor) here and in the other newly added test cases?

Oops, missed that. That's an important detail.
After that (and the CI passes), I'll merge :smile:

That's an important detail.

I'm glad that we agree on this. :smile_cat:

After that (and the CI passes), I'll merge :smile:

:+1: :clap:

(Afternote: I added new_from_bin in 9cdca3f7a012e0b7fded8b018bc3c9c073a7a250)


Sprint skin crouch

Current Behavior
If you start crouch while running, the Sprint model will not be replaced by Default
If you start crouch while walking, the Sprint model does not appear
Expected Behavior
If you start sneaking while running, the Sprint model will be replaced by the Default model
Steps To Reproduce

Set the Default and Sprint skin
Run
While running, start sneaking

Version and Log

Anything else?
This seems to be normal behavior for the PlayerToggleSprintEvent

This is normal behavior and expected. You are still sprinting; you are just crouched as well. When you uncrouch, you will continue sprinting. This works as intended.


Vertx http dispatcher

Coverage increased (+0.1%) to 86.592% when pulling 43627c3e61114b68299d0a9ec23b2f5362f81d32 on wujimin:vertx-http-dispatcher into c00190120b4b654b4632eff21d7119e7e3ad3cc4 on ServiceComb:master.


cannot login

i have last version of yii2 basic and yii2-user, but i cannot login using username that i had created.
that problem didnot appear in my other website that use old version of yii2-user

I can not reproduce the issue. Could you please provide more information? What is the error message? Does the error appear to registered or created by admin users?

there is no error message, after login it just sent back to home  (web/index.php)  without any sign of logged in, then when i try to open  user/admin/index  it return to the login form,
i use username that i had created by signup using user/registration/register, and confirmed using link in runtime/mail
i had try many times, with this step

installl yii2 basic:
composer create-project --prefer-dist yiisoft/yii2-app-basic basic

set database in config/db.php

update composer.json to add yii2-user
......
"require": {
"php": ">=5.4.0",
"yiisoft/yii2": "",
"yiisoft/yii2-bootstrap": "",
"yiisoft/yii2-swiftmailer": "*",
"dektrium/yii2-user": "~0.9.1@dev"
},
....

install yii2-user
composer update

add yii2-user to the module in config/web.php
...
'modules' => [
'user' => [
'class' => 'dektrium\user\Module',
'enableUnconfirmedLogin' => true,
'confirmWithin' => 21600,
'cost' => 12,
'admins' => ['admin','xdhanz']
],
],
...

run yii2-user migration
$ php yii migrate/up --migrationPath=@vendor/dektrium/yii2-user/migrations

open web/?r=user/registration/register
signup new user  xdhanz

open confirmation link in runtime/mail

open web/?r=user/admin/index and then redirected to login form
if i use  wrong username or wrong password it show the correct messages ("Invalid login or password), if i use the correct user and password (xdhanz), it show no message, just return the login form again.

my other site that run well (version 0.8.2), getting the same problem after i run "composer update"

Thank you for detailed description of how to reproduce issue. I've found the problem: you should remove user component from your config's components section.
``php
// these lines should be removed
'user' => [
'identityClass' => 'app\models\User',
'enableAutoLogin' => true,
],

This error occures because Yii2-user no longer update `user` component configuration automatically.

thank you very much, it worked now

dmeroff thank for this solutions from Bolivia

thank you for the answer, I had the same problem

i have last version of yii2 advanced and yii2-user with yii2-rbac , but i cannot login using username that i had created. the problem is the same pointed up there, and I have removed the user component from your config's components section. but but login still does not work.

I had problems with the login form and register that is not running at all, when I made the clouds went well but when I tried to upload it to the server and register the login button both backend and frontend does not work

dmeroff solution worked for me


[QUESTION] Export from view without an specific column

[X] Have read and understood: https://github.com/Maatwebsite/Laravel-Excel/blob/3.1/.github/SUPPORT.md
[X] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[X] Checked that your question isn't already asked before.
[X] Filled in the entire issue template
Versions

PHP version: PHP 7.3.1
Laravel version: Laravel Framework 5.8.3
Package version: Maatwebsite 3.1

Description
Hello, I am trying to download a blade view using the concern View, the view is only a bootstrap table with some data within it, what I need is to download the entire view except one of the columns from that table
Is there a way to exclude that column from that view within the export or the controller?
Is this approach not the right one?
Currently the code downloads the view with no problems (the full bootstrap table html, and because it already has row headers, they are within it too)
Additional Information
The code is simple:
Export:
public function __construct($view, $data = "")   {     $this->view = $view;     $this->data = $data;   }   public function view(): View   {     return view(       $this->view,       $this->data     );   }
Controller:
public function export(Request $request) {     $data = $request->all();     return Excel::download(new InscripcionesExports('admin.tablaInscripciones', $data), 'Inscripciones.xlsx');   }

You should handle that just like you would do normal with blade, pass some param to the view and hide the column. Laravel Excel doesn't (and shouldn't) get in your way.

I didn't think about that solution, I was stuck thinking about fixing it within the class export and controler
thanks for your help!!


How to reproduce S-LSTM with your code?

Hello, Thank you for sharing your code. In your paper, I think you trained S-LSTM model by yourself with your own code. But S-LSTM is not the generative model. So can you explain how did you reproduce it (maybe how to deactivate the discriminator) and can you share hyperparameters of S-LSTM that you used for the result of the paper?

@sanmin0312
Hi, I have the same question. Could you find out any solution?

Hi,
You can find another implementation of S-LSTM here.
The README describes the command-line as well.


Modifying miden-lib/asm/sat/internal/asset.masm results in compilation failures

To reproduce

Add any instruction anywhere inside the file (I tested with add, assertz, and many more)
run cargo test
Notice most asset & note tests failing with ScriptCompilationError(PhantomCallsNotAllowed(...))

Closing this as the fix is specific to how we do testing in Miden base and is covered in https://github.com/0xPolygonMiden/miden-base/issues/303.


module 'pyfes' has no attribute 'Handler'

Hi,
I downloaded the new version of aviso-fes but I still get error.
AttributeError                            Traceback (most recent call last)
Cell In[10], line 7
5 config_ocean = os.path.join(filepath, 'ocean_tide.yaml') # change to ocean_tide.ini
6 config_load =  os.path.join(filepath, 'load_tide.yaml')  # change to load_tide.ini
----> 7 ocean_tide = pyfes.Handler("ocean", "io", config_ocean)
8 load_tide = pyfes.Handler("radial", "io", config_load)
10 # coordinates of the location (always select a point 1-2km offshore from the beach)
11 # if the model returns NaNs, change the location of your point further offshore.
AttributeError: module 'pyfes' has no attribute 'Handler'
Can you give me idea to solve it?
THank you

Hi,
Thank you for reaching out. The error you're encountering (AttributeError: module 'pyfes' has no attribute 'Handler') is likely because you're attempting to use the legacy version (2.9.7) of the pyfes library with the new one (2024.6.0). The latest version of the library introduces significant changes that are not backward compatible with the old one.
To resolve this issue, you'll need to follow the updated documentation for the new version of aviso-fes. Please ensure you have the latest version installed and refer to the example code for predictions provided in the documentation.
You can find the updated documentation here: Aviso-FES Documentation
Specifically, check out the example of the new code for predictions: New Code Prediction Example
This should guide you through the necessary changes to your code and configuration files.


Kickoff Meetings/Follow Up

Main Objectives & Tasks:

[ ] Review & document the existing process (Current State Diagram will be produced).
[ ] Request remote access for the setup of the VBScript for data transformation and submission.
[ ] Obtain the first de-identified CSV file.
[x] Send Terms of Service (TOS)
[x] Receive agreement of TOS

9/21/21 - Kickoff call with main contact. Notes posted here: https://cdc.sharepoint.com/:w:/r/teams/USDSatCDC/_layouts/15/Doc.aspx?sourcedoc={359C9620-12B8-4700-BE27-4500465A1A28}&file=Coastal Urgent Care Kickoff Call 9.21.21.docx&action=default&mobileredirect=true

9/28/21 - Received agreement of TOS via email.


Example of full text search and relations.

Hi, I am trying to find a MongoDB driver with Typescript  and found this one. I know this is in its early stage, but since it is production ready, I might use this one. Can anyone give me an example of full text search on a collection and relations with different collections with this package?

Hello,
text searching in mongodb is pretty powerful and this library have limited support,
Here is an example you can try for (and it works):
@Index({stringValue: "text"})
@Document()
class QueryTest {
@Field()
public _id!: ObjectID;
@Field()
public stringValue: string = "";

}
    repository = connection.getRepository(QueryTest);
    await repository.syncIndex();

    const document = new QueryTest();
    document.stringValue = "coffee shop apple";
    await repository.insert(document);

    const document1 = await repository.query().text("coffee apple").findOne();
    assert.isDefined(document1);

    const document2 = await repository.query().text("coff").findOne();
    assert.isUndefined(document2);

    const document3 = await repository.query().text("\"coffee shop\"").findOne();
    assert.isDefined(document3);

    const document4 = await repository.query().text("\"coffee apple\"").findOne();
    assert.isUndefined(document4);

Hello,
text searching in mongodb is pretty powerful and this library have limited support,
Here is an example you can try for (and it works):
@Index({stringValue: "text"})
@Document()
class QueryTest {
@Field()
public _id!: ObjectID;
@Field()
public stringValue: string = "";

}
    repository = connection.getRepository(QueryTest);
    await repository.syncIndex();

    const document = new QueryTest();
    document.stringValue = "coffee shop apple";
    await repository.insert(document);

    const document1 = await repository.query().text("coffee apple").findOne();
    assert.isDefined(document1);

    const document2 = await repository.query().text("coff").findOne();
    assert.isUndefined(document2);

    const document3 = await repository.query().text("\"coffee shop\"").findOne();
    assert.isDefined(document3);

    const document4 = await repository.query().text("\"coffee apple\"").findOne();
    assert.isUndefined(document4);

Thank you for your reply, I have understood. But how can we search in multiple fields? Also, how to add relations between collections?

Thank you for your reply, I have understood. But how can we search in multiple fields? Also, how to add relations between collections?

How about =like this:
.or(["name", "description"], (x) => {
        x.regex("Wooden Bacon");
      })

.and(["name", "description"], (x) => {
        x.regex("Wooden Bacon");
 })

It would be much convenient to apply the same condition to multiple columns.

How about =like this:
.or(["name", "description"], (x) => {
        x.regex("Wooden Bacon");
      })

.and(["name", "description"], (x) => {
        x.regex("Wooden Bacon");
 })

It would be much convenient to apply the same condition to multiple columns.

the text search is mapping to https://docs.mongodb.com/manual/text-search/, it's related to the field, you can define as many fields as you want
relationship is not supported currently

the text search is mapping to https://docs.mongodb.com/manual/text-search/, it's related to the field, you can define as many fields as you want
relationship is not supported currently

Alright, I have seen mongoose populate method uses two queries, as mongodb hasn't relationships built in, it won't be a big problem to use two queries. Thanks for the answers.

Alright, I have seen mongoose populate method uses two queries, as mongodb hasn't relationships built in, it won't be a big problem to use two queries. Thanks for the answers.

yes, there isn't any native relationship in mongo, those are just code level things. If I really need relationship, I just use the id as the index from another object.

yes, there isn't any native relationship in mongo, those are just code level things. If I really need relationship, I just use the id as the index from another object.

Agreed!

Agreed!


BUG

Not able to move da queen....

side ways*

need pawn promotion feature....

Not able to move da queen....

I fixed the queens movement with this commit: aaac03fb41207b66bf5345d4ae432b3df593ea78

need pawn promotion feature....

There actually was a pawn promotion feature but another feature I added had broken it... I've fixed it though in the following commit: 0d058e2066cb92ef2185fb9156adc1daf04bb50f

Thanks for the bug reports.


Adds a test helper for mocking Organizers in RSpec

Adds a new module called TestHelpers (that could be expanded quite a bit) and a method called mock_organizer that simplifies the process of stubbing the Interactors in an Organizer with RSpec.
A typical Organizer spec for me looks something like this:
RSpec.describe UpdatePasswordOrganizer do
  subject { described_class }

  let(:find_user_by_reset_token) { double("find_user_by_reset_token") }
  let(:check_token_expiration)   { double("check_token_expiration") }
  let(:update_password)          { double("update_password") }

  before(:example) do
    allow(FindUserByResetToken).to receive(:new).
      and_return(find_user_by_reset_token)
    allow(find_user_by_reset_token).to receive(:run!)
    allow(find_user_by_reset_token).to receive(:run)
    allow(find_user_by_reset_token).to receive(:context)

    allow(CheckTokenExpiration).to receive(:new).
      and_return(check_token_expiration)
    allow(check_token_expiration).to receive(:run!)
    allow(check_token_expiration).to receive(:run)
    allow(check_token_expiration).to receive(:context)

    allow(UpdatePassword).to receive(:new).
      and_return(update_password)
    allow(update_password).to receive(:run!)
    allow(update_password).to receive(:run)
    allow(update_password).to receive(:context)
  end

  describe ".call" do
    it "calls the FindUserByResetToken interactor" do
      expect(find_user_by_reset_token).to receive(:run!)
      subject.call
    end

    it "calls the CheckTokenExpiration interactor" do
      expect(check_token_expiration).to receive(:run!)
      subject.call
    end

    it "calls the UpdatePassword interactor" do
      expect(update_password).to receive(:run!)
      subject.call
    end
  end
end

This helper cuts it down to something like this --
RSpec.describe UpdatePasswordOrganizer do
  include Interactor::TestHelpers

  subject { described_class }

  before(:example) do
    mock_organizer(described_class)
  end

  describe ".call" do
    it "calls the FindUserByResetToken interactor" do
      expect(FindUserByResetToken).to receive(:call!)
      subject.call
    end

    it "calls the CheckTokenExpiration interactor" do
      expect(CheckTokenExpiration).to receive(:call!)
      subject.call
    end

    it "calls the UpdatePassword interactor" do
      expect(UpdatePassword).to receive(:call!)
      subject.call
    end
  end
end

Would this be of interest? I'm very open to iterating and welcome any suggestions/comments/concerns!
I think it would also be cool to have a mock_interactor helper that stubs a single Interactor. It wouldn't replace quite as much code but it would be consistent. Happy to include that if the general idea is a keeper.
Also.

Thank you so much for taking the time to work on this. Your implementation is nice and clean. However, I won't be pulling this in because I'm afraid it promotes bad testing practices. An organizer is simple in that its only job is to call each of its interactors. That function is inherent to Interactor::Organizer and is thoroughly tested in Interactor's own test suite. In your own app, it is not required to re-test that expectation. Especially on a unit level, your app's test suite should test your app's code, not code contained in its supporting libraries, like Interactor.
Your GIF is great. Thanks again!

@laserlemon thanks so much for your feedback! I really appreciate you taking the time.
I see what you mean about (not) including redundant tests for the gem's basic functionality in one's own app. Perhaps doing away with all this and simply testing that organize receives the expected Interactors is a more appropriate test to include in the apps' specs? Or do you think that's unnecessary?
My concern is that, for example, I've written an Organizer that organizes a couple Interactors and then two months later I delete one of those Interactors but forget to modify the Organizer. It seems like having a spec for the Organizer would catch this nicely. Or perhaps this is best left to a feature spec to handle?

In my experience, a feature spec will most likely catch an organizer's missing interactor. Even the happy path feature spec will usually sniff that out, especially if the interactor in question was completely deleted.
Unless there's some involved logic in a before hook, I don't unit test my organizers. Hope that helps!

It definitely does, thanks for the insight!


ENH: add FeatureData[SingleBowtie2Index] and FeatureData[AlignmentMap]

This PR adds two new semantic types:

FeatureData[SingleBowtie2Index]
FeatureData[AlignmentMap].

They are required for the expansion of the indexing and mapping actions in q2-assembly (to further enable MAG normalization): https://github.com/bokulich-lab/q2-assembly/pull/81

Hey there @lizgehret! Could you check this one out when you have a chance? Just some updated, simple types I need for the MAG normalization I'm working on 🔨 🙏


MakeCode file picker Choose file does not respond

Describe the bug
When trying to import a file into Makecode in the web view, the choose file button does not respond
To Reproduce
Steps to reproduce the behaviour. e.g.:

Go to Create code
Click on "import" in MakeCode
Click on "choose file"
See issue

Expected behavior

Should be able to load a hex file from the files location on the device this way
Screenshots/Recordings

Device

Make: [e.g. Motorola]
Model: [e.g. G^]
OS: [e.g. Android 9]
App Version [e.g. 2.8.8]

Additional context
Add any other context about the problem here.

Duplicat of #14


issue with my text to image ai Device type privateuseone is not supported for torch.Generator() api.

Hi let me first say i am very new to this all (ai/python)
I also dont really know what is needed so here i have my specs..
Radeon RX 5500 XT gpu
Amd Ryzen 5 3600 6core cpu
16gb Ram
8gb dedicated gpu memory (Vram.. i think xD )
with the main isseus being:
Device type privateuseone is not supported for torch.Generator() api.
and the time it takes to complete the task being 16 minutes and it didnt even output anything
I have changed the Run.bat to
.\python_embeded\python.exe -m pip uninstall torch torchvision torchaudio torchtext functorch xformers -y
.\python_embeded\python.exe -m pip install torch-directml
.\python_embeded\python.exe -s Fooocus\entry_with_update.py --directml
pause
since it was stated to do so with amd
thats the only thing i have changed about the files
i have the latest install as of december 9th..
Thanks in advance for any1 who can help
This is the log:
E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791>.\python_embeded\python.exe -m pip uninstall torch torchvision torchaudio torchtext functorch xformers -y
Found existing installation: torch 2.0.0
Uninstalling torch-2.0.0:
Successfully uninstalled torch-2.0.0
Found existing installation: torchvision 0.15.1
Uninstalling torchvision-0.15.1:
Successfully uninstalled torchvision-0.15.1
WARNING: Skipping torchaudio as it is not installed.
WARNING: Skipping torchtext as it is not installed.
WARNING: Skipping functorch as it is not installed.
WARNING: Skipping xformers as it is not installed.
E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791>.\python_embeded\python.exe -m pip install torch-directml
Requirement already satisfied: torch-directml in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (0.2.0.dev230426)
Collecting torch==2.0.0 (from torch-directml)
Using cached torch-2.0.0-cp310-cp310-win_amd64.whl (172.3 MB)
Collecting torchvision==0.15.1 (from torch-directml)
Using cached torchvision-0.15.1-cp310-cp310-win_amd64.whl (1.2 MB)
Requirement already satisfied: filelock in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torch==2.0.0->torch-directml) (3.12.2)
Requirement already satisfied: typing-extensions in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torch==2.0.0->torch-directml) (4.7.1)
Requirement already satisfied: sympy in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torch==2.0.0->torch-directml) (1.12)
Requirement already satisfied: networkx in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torch==2.0.0->torch-directml) (3.1)
Requirement already satisfied: jinja2 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torch==2.0.0->torch-directml) (3.1.2)
Requirement already satisfied: numpy in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torchvision==0.15.1->torch-directml) (1.23.5)
Requirement already satisfied: requests in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torchvision==0.15.1->torch-directml) (2.31.0)
Requirement already satisfied: pillow!=8.3.,>=5.3.0 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from torchvision==0.15.1->torch-directml) (9.2.0)
Requirement already satisfied: MarkupSafe>=2.0 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from jinja2->torch==2.0.0->torch-directml) (2.1.3)
Requirement already satisfied: charset-normalizer<4,>=2 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from requests->torchvision==0.15.1->torch-directml) (3.1.0)
Requirement already satisfied: idna<4,>=2.5 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from requests->torchvision==0.15.1->torch-directml) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from requests->torchvision==0.15.1->torch-directml) (2.0.3)
Requirement already satisfied: certifi>=2017.4.17 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from requests->torchvision==0.15.1->torch-directml) (2023.5.7)
Requirement already satisfied: mpmath>=0.19 in e:\amain\fooocus ai gen\fooocus_win64_2-1-791\python_embeded\lib\site-packages (from sympy->torch==2.0.0->torch-directml) (1.3.0)
DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.; python_version >= "3.7". pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063
Installing collected packages: torch, torchvision
WARNING: The scripts convert-caffe2-to-onnx.exe, convert-onnx-to-caffe2.exe and torchrun.exe are installed in 'E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed torch-2.0.0 torchvision-0.15.1
[notice] A new release of pip is available: 23.2.1 -> 23.3.1
[notice] To update, run: E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\python.exe -m pip install --upgrade pip
E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791>.\python_embeded\python.exe -s Fooocus\entry_with_update.py --directml
Already up-to-date
Update succeeded.
[System ARGV] ['Fooocus\entry_with_update.py', '--directml']
Python 3.10.9 (tags/v3.10.9:1dd9be6, Dec 6 2022, 20:01:21) [MSC v.1934 64 bit (AMD64)]
Fooocus version: 2.1.824
Running on local URL: http://<IP_ADDRESS>:7865/
To create a public link, set share=True in launch().
Using directml with device:
Total VRAM 1024 MB, total RAM 16335 MB
Set vram state to: NORMAL_VRAM
Disabling smart memory management
Device: privateuseone
VAE dtype: torch.float32
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
Refiner unloaded.
model_type EPS
adm 2816
Using split attention in VAE
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
Using split attention in VAE
extra keys {'cond_stage_model.clip_l.logit_scale', 'cond_stage_model.clip_g.transformer.text_model.embeddings.position_ids', 'cond_stage_model.clip_l.text_projection'}
Base model loaded: E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\models\checkpoints\juggernautXL_version6Rundiffusion.safetensors
Request to load LoRAs [['sd_xl_offset_example-lora_1.0.safetensors', 0.1], ['None', 1.0], ['None', 1.0], ['None', 1.0], ['None', 1.0]] for model [E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\models\checkpoints\juggernautXL_version6Rundiffusion.safetensors].
Loaded LoRA [E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\models\loras\sd_xl_offset_example-lora_1.0.safetensors] for UNet [E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\models\checkpoints\juggernautXL_version6Rundiffusion.safetensors] with 788 keys at weight 0.1.
Fooocus V2 Expansion: Vocab with 642 words.
Fooocus Expansion engine loaded for cpu, use_fp16 = False.
Requested to load SDXLClipModel
Requested to load GPT2LMHeadModel
Loading 2 new models
[Fooocus Model Management] Moving model(s) has taken 0.53 seconds
App started successful. Use the app with http://<IP_ADDRESS>:7865/ or <IP_ADDRESS>:7865
[Parameters] Adaptive CFG = 7
[Parameters] Sharpness = 2
[Parameters] ADM Scale = 1.5 : 0.8 : 0.3
[Parameters] CFG = 4.0
[Parameters] Seed =<PHONE_NUMBER>259297186
[Parameters] Sampler = dpmpp_2m_sde_gpu - karras
[Parameters] Steps = 30 - 15
[Fooocus] Initializing ...
[Fooocus] Loading models ...
Refiner unloaded.
[Fooocus] Processing prompts ...
[Fooocus] Preparing Fooocus text https://github.com/lllyasviel/Fooocus/discussions/1 ...
[Prompt Expansion] Cute girl on sofa, full perfect, fine still, intricate, elegant, highly detailed, delicate, sharp focus, dynamic light, great composition, clear background, scenic, vibrant colors, inspired very strong cinematic chanted epic, professional, winning, fantastic, artistic, positive, emotional, pretty, attractive, cute, enhanced, loving, colorful, beautiful, symmetry, illuminated
[Fooocus] Encoding positive https://github.com/lllyasviel/Fooocus/discussions/1 ...
[Fooocus] Encoding negative https://github.com/lllyasviel/Fooocus/discussions/1 ...
[Parameters] Denoising Strength = 1.0
[Parameters] Initial Latent shape: Image Space (1024, 1024)
Preparation time: 28.32 seconds
[Sampler] refiner_swap_method = joint
[Sampler] sigma_min = 0.0291671771556139, sigma_max = 14.614643096923828
Traceback (most recent call last):
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\modules\async_worker.py", line 803, in worker
handler(task)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\modules\async_worker.py", line 735, in handler
imgs = pipeline.process_diffusion(
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\modules\default_pipeline.py", line 354, in process_diffusion
modules.patch.BrownianTreeNoiseSamplerPatched.global_init(
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\modules\patch.py", line 173, in global_init
BrownianTreeNoiseSamplerPatched.tree = BatchedBrownianTree(x, t0, t1, seed, cpu=cpu)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\backend\headless\fcbh\k_diffusion\sampling.py", line 85, in init
self.trees = [torchsde.BrownianTree(t0, w0, t1, entropy=s, **kwargs) for s in seed]
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\Fooocus\backend\headless\fcbh\k_diffusion\sampling.py", line 85, in
self.trees = [torchsde.BrownianTree(t0, w0, t1, entropy=s, **kwargs) for s in seed]
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torchsde_brownian\derived.py", line 155, in init
self._interval = brownian_interval.BrownianInterval(t0=t0,
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torchsde_brownian\brownian_interval.py", line 540, in init
W = self._randn(initial_W_seed) * math.sqrt(t1 - t0)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torchsde_brownian\brownian_interval.py", line 234, in _randn
return _randn(size, self._top._dtype, self._top._device, seed)
File "E:\AMain\Fooocus Ai gen\Fooocus_win64_2-1-791\python_embeded\lib\site-packages\torchsde_brownian\brownian_interval.py", line 32, in _randn
generator = torch.Generator(device).manual_seed(int(seed))
RuntimeError: Device type privateuseone is not supported for torch.Generator() api.
Total time: 1029.91 seconds

i have same situation on mac.
DEPRECATION: torchsde 0.2.5 has a non-standard dependency specifier numpy>=1.19.; python_version >= "3.7". pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of torchsde or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063


"Nanov" is listed in the drop-down menu

Description:
"Nanov" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Nanov" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Nanov, TELEORMAN (Nanov)" and "Comuna Nanov, TELEORMAN".


Integrate Google Calendar

Fullcalendar, the library being used to render calendar on the website allows you to sync your events from google calendar. Its a simple addition, and the docs for it can be found here - https://fullcalendar.io/docs/google-calendar
Create a new environment variable called NEXT_PUBLIC_GOOGLE_CALENDAR_API_KEY.
Do thoroughly check if the integration is working as expected and attach proof in the PR.
Happy coding :D

Could you assign me this issue ?

@abhi9ab you are assigned!


Added a mimetype check on incoming streams before saving them

Throw an exception if mime type is not supported
Added a whitespace ;)

http://www.php-fig.org/psr/psr-2/ You are absolutely right!


Messages lost if no subscriber is alived

Is this normal behavior if there is no subscriber that messages in gnatsd are lost and not persisted till first subscriber is alive? Or is this a bgug?

Yes, NATS does not have any persistence at all.  So that's expected.  If you want that behavior you should consider NATS Streaming


Make compatible with conda-forge

In preparation of the NNPOps integration (#50) and further use with OpenMM-Torch, TorchMD-Net dependencies have to be compatible with conda-forge.

[x] Use a custom PyTorch Geometric package
[x] Clean up the environment file
[x] Clean up the CI script

@PhilippThoelke @stefdoerr could you review?


Add integration test for checking nginx_service_* Telegraf metrics

High-level description
This PR adds an integration test checking that nginx_service_* metrics are reported through Telegraf.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
https://jira.mesosphere.com/browse/DCOS_OSS-5014
Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

@mesosphere-mergebot label Ready For Review


Upgraded 2.2 to 2.3 and getting run time errors for HandInteractionExamples

Describe the bug
Upgraded existing "vanilla" project from 2.2 to 2.3. I opened the HandInteractionExamples from the demo folder, hit play and got the below error messages.
To reproduce
Steps to reproduce the behavior:

Have previous project using MRTK 2.2 with HandInteractionExample open
Follow instructions to upgrade to MRTK 2.3
Open HandInteractionExample and press play
Scene plays fine but getting errors during runtime

Expected behavior
Scene plays with no errors
Screenshots

If applicable, add screenshots to help explain your problem.
Your setup (please complete the following information)

Unity Version 2019.2.19f1
MRTK Version 2.3

Target platform (please complete the following information)

HoloLens 2

Additional context
I initially did not delete all the MRTK files within the Asset folder which caused other errors. I eventually deleted everything including the examples

Could you please give more details about the steps you followed on

Follow instructions to upgrade to MRTK 2.3

Hi there,
I was following the instructions on the GitHub release notes. FYI, my internal employee email is<EMAIL_ADDRESS>https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/ReleaseNotes.html
Will
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Vanessa<EMAIL_ADDRESS>Sent: Thursday, February 20, 2020 4:23 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/MixedRealityToolkit-Unity] Upgraded 2.2 to 2.3 and getting run time errors for HandInteractionExamples (#7317)
Could you please give more details about the steps you followed on

Follow instructions to upgrade to MRTK 2.3

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FMixedRealityToolkit-Unity%2Fissues%2F7317%3Femail_source%3Dnotifications%26email_token%3DABZTTTTVU4RPWX3VWPD343DRDZY2FA5CNFSM4KU4WDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMNVRNI%23issuecomment-588994741&data=02|01||74fc889d6b5844cda73408d7b5ff9f9c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637177981801768947&sdata=IYdaAEr5Nv5NesRqs5UPUN6mhZybOJa3F1sPC4zC3a4%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABZTTTR3ZBHPQWLGI6PQH4DRDZY2FANCNFSM4KU4WDRA&data=02|01||74fc889d6b5844cda73408d7b5ff9f9c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637177981801778931&sdata=54XXapD10ecWEnMNho0Qcp0wOuSVHUhRwk2o8pWobUU%3D&reserved=0.


Add all lighthouse map labels

[Add all lighthouse map labels]
Description 🗒
Added map labels for lighthouse
Examples 📸

Related Issues 🔗
Completes #840

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

.deploy


[Doc Improvement][Private channel by user][2490774]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 5153d85:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 24db337:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1054fd1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/conversations/channel-and-group-conversations.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Move to .Net 4.5.1 and RabbitMQ client 4.1.1

I'm curious what prompted the change to 4.5.1   At 4.0, all 4.0+ clients can use the library, but this requires 4.5.1+.

Last RabbitMQ.Client assembly require .Net 4.5.1


CUDA out of memory

Hello, thank you very much for open-sourcing your code. But after I run it according to your run.sh, I used 4 3090's with 24g RTX cards and the batchsize is only 1 each, but why does he still report exceeding memory after a period of normal operation, and why was it ok in the beginning but not now.

Hi @yangengineering,
Please see Issue https://github.com/orrzohar/PROB/issues/48, where we troubleshooted running 4x3090's
Best,
Orr


docs(cicero-server/README.md): update curl requests - #742

Signed-off-by: Kushal Kumar<EMAIL_ADDRESS>

Closes #742

Changes

 Update the curl requests for draft and trigger methods.

Related Issues

Issue #742

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to master from fork:branchname

Coverage remained the same at 93.936% when pulling 89f88058d97aeecc19416215fac3fd872be125bb on K-Kumar-01:k-kumar-01/i742/failed-curl-request-cicero-server-package into c7f7944142f656200042ea1a8e205669fca110b1 on accordproject:master.

@dselman Requesting review.


fix: remove unnecessary error message assertion

Error message format has changed in grpc.
Checklist

[x] npm test passes
[x] commit message follows commit guidelines

some test timeout, could you please help fix it?

I cannot reproduce it locally with node v6.17.1 and<EMAIL_ADDRESS>Also, I noticed the latest grpc could not be installed with node v6. I'd wonder if there is any compatibility issue with past LTS node v6.


[ISSUE-18] Customize cherry pick branch name

Fix https://github.com/carloscastrojumo/github-cherry-pick-action/issues/18
So that users can have control over the new cherry-pick branch name, like re-using the original branch name concatenaed with the target one:
    steps:
      - name: Calculate release branch
        run: |
          label=${{ matrix.name }}
          echo "RELEASE_BRANCH=release/v1" >> $GITHUB_ENV
      - name: Checkout
        uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - name: Perform cherry-pick
        uses: lampajr/github-cherry-pick-action@issue-18_cp_branch_name
        with:
          branch: "${{ env.RELEASE_BRANCH }}"
          title: "[${{ env.RELEASE_BRANCH }}] ${{ github.event.pull_request.title }}"
          body: "cherry-pick: ${{ github.event.pull_request.html_url }}"
          inherit_labels: false
          reviewers: |
            ${{ github.event.pull_request.user.login }}
          cherry-pick-branch: "${{ github.event.pull_request.head.ref }}_${{ env.RELEASE_BRANCH }}"

In this way users can cherry-pick the same change on more than one release branch or simply using their branching convention.

Note: In addition I also added some simple mocked tests that I used to validate the fix itself, I would include them too but if you don't agree I can remove them as well.

I tried this fix in a custom repo.
Workflow config: https://github.com/lampajr/chain-status-example/blob/main/.github/workflows/backport.yaml
Generated cherry pick PRs:

Using default branch name: https://github.com/lampajr/chain-status-example/pull/4
Customizing cherry pick branch name: https://github.com/lampajr/chain-status-example/pull/6

Hi @carloscastrojumo whenever you get time could you please code review this?

Hi @carloscastrojumo , you are right that's not an issue as I completely missed the inputs.branch in the prBranch creation, my bad sorry.
On the other hand, just to give you more context on why I need this change: we are actually using build-chain to perform cross-repositories projects builds - this tool relies on the branch name in order to cross check multiple PRs on different repos, therefore we must ensure that multiple PRs (on different repos, that's the crucial point) share the same branch name (which cannot be ensured if using commit sha as part of the branch name itself).
If you want I can create a new issue with this motivation and link it to this PR, wdyt?

It's fine. I will question the issue owner to see how can I help.
Thanks again for contributing.

Thank you very much @carloscastrojumo


tautulli: 2.6.8 -> 2.7.3

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125087 at c9991f9d run on x86_64-linux 1

1 package built successfully:

tautulli

2 suggestions:

warning: unused-argument
Unused argument: python.
Near pkgs/servers/tautulli/default.nix:1:25:
  |
1 | { lib, fetchFromGitHub, python, buildPythonApplication, bash, setuptools, wrapPython, makeWrapper }:
  |                         ^

warning: unused-argument
Unused argument: bash.
Near pkgs/servers/tautulli/default.nix:1:57:
  |
1 | { lib, fetchFromGitHub, python, buildPythonApplication, bash, setuptools, wrapPython, makeWrapper }:
  |                                                         ^


Fix the pills and add support for m.mentions

Fixes #72
Fixes #122
Fixes #123

(CI failing on python 3.12 is expected, see https://github.com/anoadragon453/matrix-reminder-bot/pull/112)


Set the 'use_default_quota_class' as 'false' by default.

Set the 'use_default_quota_class' as 'false' by default, to read the conf file quota values.

please test this


config: other materials than leaves do not work

At first i would like to thank you for making the plugin! it works fine, trees and leaves are beeing set on fire in daytime. Thats all i need at the moment :) I just tested adding other blocks in the config.yml under materials. for example my config: materials: - LEAVES_2 - LEAVES - WOOD - NETHERRACK - SPRUCE_WOOD_STAIRS (i used the Bukkit materials) leaves and trees still work fine, but in this example wood, netherrack or spruce stairs are not effected (they dont get set on fire). Am i doing anything wrong, or is there a bug?
I have another request: could the period of time (atm 4284 to 7698), in wich the blocks are set on fire, be a bit larger? for example 600 to 11400 would be great! If possible it would be nice when there is way to set this time in the config file too! but that does not have to be :P
Thanks! jonny999
[originally submitted to my BitBucket repo 2015-12-31 by Anonymous]

The way I used appears to create massive lags and is not feasible.


SearchBox position problem has been solved in css changes

I has changed position attribute of search button css and solved the problem

Please ignore mydb commit(First commit) and get my second commit,
main problem solved in second commit,
Thanks


Replace text

Description of the PR
The draft PR relates to #273. It contains functionality for triggering CourseProjectAction from Modules/Assignments view when the project is not an A+ project yet.
There is some unstable behaviour which occurs on startup when the project that opens is already an A+ project. While the project is loading the default informative text is visible and the user can then click and trigger the CourseProjectAction. If the user closes/cancels that window then the Assignment tree is not always loaded and the default text persists (other times though everything works fine after closing/cancelling the window). In order to display the Assignments the user needs to restart IntelliJ which is not ideal. Any input on the issue is much appreciated!
There is always the fallback option of displaying the informative text on startup without the extra hyperlink functionality (it will still be an improvement).
Testing

unit
integration
manual

- [ ] new unit tests created
- [ ] all unit tests pass

- [ ] new integration tests created
- [ ] all integration tests pass

- [x] manual testing went well

Have you updated the TESTING.md or other relevant documentation?

[x] Yes
[ ] Not yet. I will do it next.
[ ] Not relevant

I'm not actually able to reproduce the unstable behavior :thinking: However, while starting the IDE, I got the following exception:
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'project' of com/intellij/openapi/project/impl/ProjectManagerImpl.addProjectManagerListener must not be null
        at com.intellij.openapi.project.impl.ProjectManagerImpl.$$$reportNull$$$0(ProjectManagerImpl.java)
        at com.intellij.openapi.project.impl.ProjectManagerImpl.addProjectManagerListener(ProjectManagerImpl.java)
        at fi.aalto.cs.apluscourses.intellij.services.PluginSettings.lambda$getMainViewModel$0(PluginSettings.java:164)
        at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705)
        at fi.aalto.cs.apluscourses.intellij.services.PluginSettings.getMainViewModel(PluginSettings.java:161)
        at fi.aalto.cs.apluscourses.intellij.actions.InstallModuleAction.update(InstallModuleAction.java:55)
        at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareUpdate(ActionUtil.java:178)
[rest omitted]

It kinda makes sense: InstallModuleAction.update gets the project from AnActionEvent.getProject and calls PluginSettings.getMainViewModel with that project. PluginSettings then passes that project parameter to ProjectManager.addProjectManagerListener, which marks project with @NotNull. However, AnActionEvent.getProject is marked as @Nullable, so it can return null.
Seems to be clearly a bug in our existing code. Interesting that it hasn't shown up before and that something here now makes it show up. The uncaught exception could well explain some of the unstable behavior that you are seeing.
I recommend reading the following introduction to actions (not everything there is relevant so skimming through it should do):
https://plugins.jetbrains.com/docs/intellij/basic-action-system.html
My alarm bells started ringing a bit when I was able to start the action from the link even during indexing, which shouldn't be possible for CourseProjectAction. With the link it's possible however, because the code manually creates a CourseProjectAction, which we shouldn't do, since we are now circumventing IntelliJ's action system, which manages actions and determines which are enabled, disabled, etc.
Later when I'm less busy I'll add an idea for how to implement it so that these issues are fixed. Btw as you might have noticed, working with the platform can be quite frustrating at times, but I hope that this hasn't been too discouraging :smile:

I'm not actually able to reproduce the unstable behavior :thinking: However, while starting the IDE, I got the following exception:
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'project' of com/intellij/openapi/project/impl/ProjectManagerImpl.addProjectManagerListener must not be null
        at com.intellij.openapi.project.impl.ProjectManagerImpl.$$$reportNull$$$0(ProjectManagerImpl.java)
        at com.intellij.openapi.project.impl.ProjectManagerImpl.addProjectManagerListener(ProjectManagerImpl.java)
        at fi.aalto.cs.apluscourses.intellij.services.PluginSettings.lambda$getMainViewModel$0(PluginSettings.java:164)
        at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705)
        at fi.aalto.cs.apluscourses.intellij.services.PluginSettings.getMainViewModel(PluginSettings.java:161)
        at fi.aalto.cs.apluscourses.intellij.actions.InstallModuleAction.update(InstallModuleAction.java:55)
        at com.intellij.openapi.actionSystem.ex.ActionUtil.performDumbAwareUpdate(ActionUtil.java:178)
[rest omitted]

It kinda makes sense: InstallModuleAction.update gets the project from AnActionEvent.getProject and calls PluginSettings.getMainViewModel with that project. PluginSettings then passes that project parameter to ProjectManager.addProjectManagerListener, which marks project with @NotNull. However, AnActionEvent.getProject is marked as @Nullable, so it can return null.
Seems to be clearly a bug in our existing code. Interesting that it hasn't shown up before and that something here now makes it show up. The uncaught exception could well explain some of the unstable behavior that you are seeing.
I recommend reading the following introduction to actions (not everything there is relevant so skimming through it should do):
https://plugins.jetbrains.com/docs/intellij/basic-action-system.html
My alarm bells started ringing a bit when I was able to start the action from the link even during indexing, which shouldn't be possible for CourseProjectAction. With the link it's possible however, because the code manually creates a CourseProjectAction, which we shouldn't do, since we are now circumventing IntelliJ's action system, which manages actions and determines which are enabled, disabled, etc.
Later when I'm less busy I'll add an idea for how to implement it so that these issues are fixed. Btw as you might have noticed, working with the platform can be quite frustrating at times, but I hope that this hasn't been too discouraging :smile:

Ok I posted my comment without reading Nikolas' comment first. I agree on what he says about the exception thrown.

Ok I posted my comment without reading Nikolas' comment first. I agree on what he says about the exception thrown.

To run the action without creating a new instance of CourseProjectAction you could use our ActionUtil.launch method.

To run the action without creating a new instance of CourseProjectAction you could use our ActionUtil.launch method.

The functionality is now stable. I used a CardLayout and displayed a different component with each card instead of adding/removing components.
Something new that wasn't present in the previous commits: If a user turned the project into an A+ project but was not authenticated then the message about the A+ project was still displayed in the Assignments view. Now, an appropriate text is shown informing the user to set the A+ token. A possible improvement here would be to make this a hyperlink towards the action as well (I can create a new issue about that).

The functionality is now stable. I used a CardLayout and displayed a different component with each card instead of adding/removing components.
Something new that wasn't present in the previous commits: If a user turned the project into an A+ project but was not authenticated then the message about the A+ project was still displayed in the Assignments view. Now, an appropriate text is shown informing the user to set the A+ token. A possible improvement here would be to make this a hyperlink towards the action as well (I can create a new issue about that).

Just noting, that eventually it would be nice to also have the hyperlinks styled like links, but I think that can be a separate issue. LinkLabel could be considered for that:
https://upsource.jetbrains.com/idea-ce/file/idea-ce-4b94ba01122752d7576eb9d69638b6e89d1671b7/platform/platform-api/src/com/intellij/ui/components/labels/LinkLabel.java

Just noting, that eventually it would be nice to also have the hyperlinks styled like links, but I think that can be a separate issue. LinkLabel could be considered for that:
https://upsource.jetbrains.com/idea-ce/file/idea-ce-4b94ba01122752d7576eb9d69638b6e89d1671b7/platform/platform-api/src/com/intellij/ui/components/labels/LinkLabel.java

@nikke234 Can we still discuss this? As I mentioned in a comment, I disagree this should be changed to boolean value methods. That would only add logic in the view. Strings as keys for what to show are abstract enough!

@OlliKiljunen I don't think it would actually add any logic to the view, since the logic is already in the view. It just happens to be hidden in a card layout, but if you try to write the view without using card layout, then you will find yourself comparing strings in the view

@nikke234 Can we still discuss this? As I mentioned in a comment, I disagree this should be changed to boolean value methods. That would only add logic in the view. Strings as keys for what to show are abstract enough!

@OlliKiljunen I don't think it would actually add any logic to the view, since the logic is already in the view. It just happens to be hidden in a card layout, but if you try to write the view without using card layout, then you will find yourself comparing strings in the view

...and if the view code would look like
if (cardToBeShown.equals("...")) {
  // show something
} else if (cardToBeShown.equals("...")) {
  // show something else
}

then surely you would prefer booleans as well :smile:

...and if the view code would look like
if (cardToBeShown.equals("...")) {
  // show something
} else if (cardToBeShown.equals("...")) {
  // show something else
}

then surely you would prefer booleans as well :smile:

47 comments -> this thread starts to finally look like a "regular" PR discussion we used to have 🤣

47 comments -> this thread starts to finally look like a "regular" PR discussion we used to have 🤣


Energy Production Modeling and Provenance

I think this belongs as its own issue for discussion, but it is closely related to the conversation around #88 and #17.
I am new to PVLIB, contributing to projects on Github, and the scientific python stack, but I do have experience working with other PV energy production modeling software (Helioscope, PVsyst, and SAM).
One issue that I've encountered when working with these programs is keeping track of revisions to the model, especially when working with a team.  It seems like this issue could be largely resolved by using PVLIB and keeping the file defining the system under version control with git or maybe a more comprehensive provenance system like Sumatra.
It seems like a good time to express the desire to use PVLIB in this manner because the approach to defining an entire system from module through inverter and step-up XFMR to interconnection like in #88 is still in development.
I agree with @jforbess point in #88 that CSV input will be useful, but I would like to see a json or yaml convention develop that could be used for version controlled system configuration input files.

I'm only a 1/4 of the way through my coffee this morning, but it's not really clear to me what you're asking for here. For pvlib specifically, are you asking for something similar to #60?
I agree that using pvlib (or specific versions/commits of pvlib) and git can help make your modeling more reproducible. They don't solve everything, though. IPython notebooks are horrible for version control (see #94 for a recent example where I couldn't easily figure out what had changed via git diff). Most of this is well outside the scope of pvlib, though we can offer some advice based on our individual experiences.

@bt- I agree that this is a good idea. Maybe even add Docker?
This a rather a documentation item.

I've been meaning to respond to clarify and am just getting to it.  After reading my comment again, I agree it is not entirely clear.

One issue that I've encountered when working with these programs is keeping track of revisions to the model, especially when working with a team.

What I meant by 'model' here is a simulation of a PV system- env. data, pv system definition, and energy production results.

IPython notebooks are horrible for version control ...

I'm thinking that I would eventually just have straight code using PVlib to calculate energy production results and this would be controlled with git.
The heart of what I'm thinking about though is version control for the PV system configuration.  I think that a yaml file that could be used to generate an object of the proposed PVsystem class would be very useful, as you suggested in PR #84.  If I'm understanding you correctly, you referred to this system configuration information as 'meta' data in #17 today.
I am going to take a stab at starting this by looking at all the input options in the GUI of other pv modelling tools (SAM & PVsyst).  I think @bmu described what needs to be done well in #17:

I don't know a standard for this, maybe because there is no standard. We could look at other software (e.g. PVSyst, SAM ...). There was the idea of PVML, a XML dialect dedicated to PV systems within the European project "Performance", but as far as I remember without published results.

Hopefully, I can find some time in the last week of November to work on this.

My understanding is that you want two things:

A csv/json/yaml standard for describing a PV system.
A script or function that takes one input csv/json/yaml file and turns it into a standard output file.

It would be easy for you to version control the input file, script, and pvlib. I think everyone would agree that this is desirable, but it will be quite complicated to make this flexible, powerful, and robust. I don't think that this requires a PVSystem object. You might start with cleaning up #88 and turning it into a script.

@wholmgren and @cwhanse, is this a topic that would be worth revisiting as part of the Solar Performance Insight (SPI) work?
I would really like to be able to just diff yaml files or look at the git commits on a yaml file rather than manually compare two pdfs documenting the assumptions/system parameters of PVsyst models.
It seems like this is pretty closely related to the Functional capability 5 of SPI to allow users to "upload pvsystem metadata". It seems like it might be a workable path to store the user uploaded data in a json or yaml format and then users like me could potentially bypass the web interface and interact with the json/yaml files directly if desired.
I think my preference would be to use a yaml format due to how easy they are to read and edit directly.

@bt- can you post a draft of the yaml you're thinking of? That would help ground the discussion and would help me understand the scope.
I could see methods like Location.from_json, Location.from_yaml, and similar for PVSystem and ModelChain. It's not clear to me how we could do much more than that within pvlib because these questions quickly become very application specific.

@bt- thanks for bringing this up again. Yes, for the SPI project we'll need to define a format to store and communicate parameters for models, and selection of models, to simulate a PV system. I see your point about the value of being about to exercise configuration control on the resulting files.

@wholmgren, here is a very rough example of the type of file I am envisioning.
I put this together just now in a few minutes without too much thought behind the organization or nesting of data, but I think it conveys the general idea. I haven not used yaml that much, so please forgive any obvious issues with the file itself.
Essentially, I'm thinking of a convention for defining a model in a yaml file that has equivalent inputs to PVsyst. It would be nice to have the flexibility to be more specific about internal models used, if desired.

Hi Ben, that looks pretty similar to what we're considering for solarfarmer, should we collaborate?

{                                           # start configuration
  "transformers": [
    {
      "name": <str>,
      "transformer spec ID": <enum>,        # all of the specs are enumerated below
      "inverters": [
        {
          "name": <str>,
          "inverter count": <int>,
          "inverter spec ID": <enum>,
          "layouts": [                      # number of layouts per inverter must be <= number of MPPTs
            {
              "name": <str>,
              "thermal parameters": <thermal model>,
              "row in front of PV system": <bool>,  # is this in the middle of the system or not
              "row in back of PV system": <bool>,   # useful for bifacial
              "number strings per row": <int>,      # total size of layout must be a multiple of this
              "system azimuth": <float[degrees]>,
              "module tilt": <float[degrees]>,
              "gcr": <float>,
              "PV module spec ID": <enum>,  # only one module allowed per layout
              "PV modules per string": <int>,
              "mounting type ID": <enum>,
              "number of strings": <int>,
              "DC collection loss": <float[%]>,
              "etc": <...>
            },
            {                               # next inverter 1 layout
              "name": <str>,
              "etc": <...>
            }
        ],                                  # end inverter 1 layouts
        "AC collection loss": <float[%]>,
        "etc": <..>,
        },
        {                                   # next transformer 1 inverter
          "name": <str>,
          "etc": <...>
        }
      ],                                    # end transformer 1 inverters
      "etc": <...>
    },                                      # end trasnformer 1
    {                                       # next transformer
      "name": <str>,
      "etc": <...>
    }
  ],                                        # end transformers
  "PV module specs": {                      # enumerate the PV module specs by ID
    "<PV module ID>": <ModuleSpec>,
    "etc": <...>
  },
  "inverter specs": {                       # enumerate the inverter specs by ID
    "<inverter ID>": <InverterSpec>,
    "etc": <...>
  },
  "transformer specs": {                    # enumerate the xfmr specs by ID
    "<xfmr ID>": <TransformerSpec>,
    "etc": <...>
  },
  "mounting type specs": {                  # end of configuration
    "<mounting type ID>": <RackSpec>|<TrackerSpec>,
    "etc": <...>
  },
"tmy weather dat file path": <filepath>,
"soiling per month": <array of floats [1x12]>,
"albedo per month": <array of floats [1x12]>,
"latitude": <float[degrees]>,
"longitude": <float[degrees]>,
"elevation": <float[meters]>,
"etc": <...>
}                                           # end of configuration

Hi Mark, yes! I think it makes sense to try to develop something that works across multiple tools. Is there a reason you are working with json rather than yaml? Stack Overflow is telling me that yaml is almost a superset of json.  I prefer the readability of yaml for this application unless there is a good reason for json.

I'm fine with yaml

Some food for thought: One big PROS for JSON is that it is the standard for web APIs, and would probably be easier (and faster) to parse / serialize across various libraries / languages. I find yaml easier to read, but harder to deal with when creating / editing big configuration file.

Just chiming in: JSON doesn't have comments, which IMHO is a big drawback in the context of config files.

I agree with all of the pros/cons of json/yaml above. I suggest that we move forward with the idea that we'll eventually support both and that they should have identical structure.
The examples help a lot. How do you envision pvlib using them? Location/PVSystem/ModelChain factories? What happens after you've loaded the data? ModelChain.run_model?
As an example, in the Solar Forecast Arbiter project we implemented a JSON specification for a model that's basically PVWatts with minor changes. We also implemented dataclasses that include to and from dict methods. Once we have the metadata/data we pass them through pvmodel.irradiance_to_power.
I expect the Solar Performance Insight json specification to look somewhat similar but support more options. Not sure if we'll also support yaml. From the json we'll create Location, PVSystem, and ModelChain objects, then pass the data through ModelChain.run_model and new methods in #943. Location.from_json and similar would be easy to add to pvlib. My main concern with putting everything in pvlib is building a broader consensus around the bigger specification.

@wholmgren

I expect the Solar Performance Insight json specification to look somewhat similar but support more options. Not sure if we'll also support yaml. From the json we'll create Location, PVSystem, and ModelChain objects, then pass the data through ModelChain.run_model and new methods in #943.

Yes, you are describing exactly what I'm thinking about. My goal would be that your effort to define the SPI json spec could result in a format that is compatible with yaml and that a user like me could then specify model inputs in a yaml file, put it in a git repository and track changes to the model input assumptions.
I could see that ultimately it might make sense for a specification for a yaml file defining pv energy model inputs to be a separate entity from pvlib. I imagine that might make sense from you perspective as well @mikofski?

I don't know, maybe? I see at least 2 possible paths:

just make the model spec in any format (yaml, json, etc) in pvlib or SPI and use it to serialize a model
make a new project, call it OpenPV spec, with the spec that pvlib and SPI are using, and possibly invite others to collaborate

There are pros & cons to both apporaches:

this just gets it done, and then others can try to use it if they can, the downside is that it might be incompatible with other models like PVsyst, SAM, PlantPredict, SolarFarmer, etc.
This could drag on forever as every possible possible is discussed and considered, but on the upside, if an OpenPV spec is adopted, you now have a bullet proof way to migrate a model from one software to another. The OpenPV spec could even provide applications (a python library or API) that could convert one format to another, EG: given a pvsyst project archive, make an OpenPV spec, or given a spec, make a PVsyst project archive.

I think something like this should probably fall under Orange Button, right?

@mikofski my thought is that we should put a spec in place that meets the needs of pvlib and SPI users, and not worry at this point about compatibility with other platforms. Cross-software compatibility is a great goal, but, I haven't seen any real interest from the various packages to read or write files for other packages and it will take cooperation among the package developers to arrive at a common format.
Orange Button might provide common ground for terminology - however, the current dictionary does not include what would be needed to describe a model chain. Orange Button has moved to an OpenAPI compliant interface which should remove one major hurdle for adoption (using the xBRL standard).  There's an OB editor to help compose an OpenAPI schema using Orange Button terms.

SolarFarmer exports to PVsyst-6.7.5, and we would adopt the pvlib/SPI spec.

SolarFarmer exports to PVsyst-6.7.5, and we would adopt the pvlib/SPI spec.

SolarFarmer is being a good citizen in this modeling community 👍

Hi @bt-
I really like your idea of YAML, it goes back and forth to JSON and Python easily, and to be able to use comments is great.
I've gone ahead and created openPVspec based on the  gist I linked above (they're sync'd). I'd really like to get your feedback.  Also some AC side interconnect, availability, curtailment, reactive power, a lot more detail that could go in there. Where ever you see etc that means I left out the detail.
There's the concept of "counts" which basically means that instead of rewriting an existing substructure, you can just scale it linearly. Also at present it assumes layouts are rectangular, so if you had an odd layout on a single inverter input, you would have to split it into many rectangular layouts, which could be relaxed by adding more to the schema. There's also the concept of inverter input, which specifies which input in a multi-mppt inverter the layout would use.
Anyway, I'd love to get your feedback. Thanks.

@mikofski, this looks like a really great starting point. Thank you for putting it together! I've only take a quick look so far, but will come back to it in more detail once I've cleared a few other things off my plate.  I started a new issue in the openPVspec repository you started with a few initial thoughts.


This library doesn't work anymore

I tried the example given in docs, but all generates is the completely black image. Below is the codesandbox link
https://codesandbox.io/p/sandbox/dry-smoke-6c8xjn?file=%2Fsrc%2FComponent.js
Can someone please help ?

I can't access your codesandbox links, but I had something similar going on. There are two potential issues :

By default, the default mask color is something greyish, which makes it very hard to see the mask and makes it appear almost entirely black. Setting the mask color via props to something like #ffffff fixes this.
The library seems to straight up don't work on images which are not exactly 256x256. I fixed this issue on my fork here : https://github.com/Edern76/react-mask-editor (PR Link : https://github.com/la-voliere/react-mask-editor/pull/5), but you will need to use that instead of the npm package.


boards: arm: nrf21540dk_nrf52840: change fem_spi to spi2

Due to hardware problems nRF21540 software won't work properly
with spi3. This PR changes fem_spi to spi2.
Signed-off-by: Artur Hadasz<EMAIL_ADDRESS>

Ok, so please do not merge this PR yet, some more discussions must follow


Extend deep

Might want to disable deep recursion for plugin options.
See here:
https://github.com/mhulse/jquery-ion/issues/15

If you just want to show and hide panels, pass these options:
$('.nutshell').nutshell({
   animIn: { opacity: 'show' },
   animOut: { opacity: 'hide' },
   speedIn: 0,
   speedOut: 0
});


Adding the calender option in Station Services

✨ Feature Request
Description of the Feature

Here I want to add the mini calender so the users can choose the date and time from that calendar.
Problem Statement
Adding calender option to  users so that they can  easily select dates and times via a graphical interface, improving the user experience for booking, scheduling, or other time-based interactions.
Proposed Solution
Using a custom calendar component from scratc
Are you participating in GSSoC?

[x] Yes
[ ] No

assigned @SrijaVuppala295


Update to tslint 2.3.0-beta and use new rules

Addresses #446.
Use new rules:

no-var-keyword
sort-object-literal-keys

Also fix some whitespace issues & small cleanup in tests.

Wait a sec, something is wrong with this PR. I think I squashed commits incorrectly.

fixed now

LGTM


Startup Failure

Hi, Must the iri node be fully synced before the application will execute?
$ NODE_ENV=production node app.js
2017-12-05T06:43:41.509Z Checking if node is synced: isReattachable
2017-12-05T06:43:41.558Z Failed: Node is not synced.
2017-12-05T06:43:41.631Z xmrToBtc: 0.0190441
2017-12-05T06:43:41.632Z miotaToBtc: 0.00023129iotaUSD: 0.0000026844
2017-12-05T06:43:42.068Z payoutPer1MHashes: 0.00011107916739444
2017-12-05T06:43:42.082Z getTotalIotaPerSecond: 0.00
2017-12-05T06:43:42.082Z hashIotaRatio: 0.004573052816326808
2017-12-05T06:43:51.560Z Error: node is not synced, wait 10 and repeat
2017-12-05T06:43:51.560Z Checking if node is synced: isReattachable
2017-12-05T06:43:51.564Z Failed: Node is not synced.
2017-12-05T06:44:01.565Z Error: node is not synced, wait 10 and repeat

Hi,
yes iri node must be fully synced.

Thanks @janfiedler
Experiencing another issue:
Error: spammerWorker
{ error: 1, data: {} }

I see this hard-coded:
var spamTransfer = [{
    address: "999999999999999999999999999999999999999999999999999999999999999999999999999999999",
    value: 0,
    message: "CONFIRM9TRANSACTIONS9IN9TANGLE9WITH9WITH9CCURL",
    tag: "SPAMMER9MINEIOTADOTCOM"
}];

Does this matter?


Remove obsolete options APIs

From @natemcmaster on Monday, July 3, 2017 11:59:25 AM
Follow-up to https://github.com/aspnet/Session/pull/173
Remove the following obsolete APIs
SessionOptions
  .CookieName
  .CookiePath
  .CookieDomain
  .CookieHttpOnly
  .CookieSecure

.SameSideMode already removed.
Copied from original issue: aspnet/Session#175

From @Tratcher on Monday, July 3, 2017 9:55:51 PM
SameSiteMode was new in this release and can just be removed, no need to obsolete it.

From: Nate McMaster<EMAIL_ADDRESS>Sent: Monday, July 3, 2017 11:59:26 AM
To: aspnet/Session
Cc: Subscribed
Subject: [aspnet/Session] Remove obsolete options APIs (#175)
Follow-up to #173https://github.com/aspnet/Session/pull/173
Remove the following obsolete APIs
SessionOptions
.CookieName
.CookiePath
.CookieDomain
.CookieHttpOnly
.SameSiteMode
.CookieSecure
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/Session/issues/175, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABvJ9QoH5FAELnv8aobhhpPS0_fyGWvGks5sKToOgaJpZM4OMmaF.

From @natemcmaster on Monday, July 3, 2017 10:45:01 PM
Good catch. PR to remove it for 2.0.0 https://github.com/aspnet/Session/pull/176

@Tratcher do you think this needs an announcement? We already made one for deprecating it: https://github.com/aspnet/Announcements/issues/257.

How about a added comment on that announcement that 3.0 is the version they're being removed in?

That's not really useful, the discoverability of that comment is negligible. Might as well create a new announcement if we were to bother at all.

Anybody subscribed to announcements would be notified the same way for a comment as for a new issue.


Empty workflow window can't be closed

Hello.
I'm not sure if this issue belongs to this app, and if it's an issue at all, but I think so.
When I create a new workflow, I get to the "Workflow Configuration" popup window.
In this window the is no button like "Cancel" or "Close", end Esc also doesn't work.
So, the only option is to press the "Back" button in my browser and get back to the previous screen. But I think it's not such user-friendly, and it's better to have something visible.

PR at https://github.com/cortezaproject/corteza/pull/585

time box changes that need to be added to hour-hour and a half. If  you're not done afterwards, please, ping me.

Changlelog
What was fixed
When creating a workflow, the user opens a modal with a form that he needs to submit in order to create a workflow. However, once the modal opens, there is no other way out of it except for pressing the back button on the browser.
How was fixed
A back button was added that simulates the back button behaviour of the browser.

Tested and confirming that this is working as expected. I also added the CL entry. So @yonkov once you merge everything feel free to close this issue.


Cleanup CSS var creation with Sass mixins and functions

This PR cleans up the CSS variable creation, replacing most (all?) of them with Sass mixins and functions. The idea is to reduce the repetition of --#{$variable-prefix} and make generating :root-level variables much easier. This is still a little WIP while I confirm everything is still functional.
Todos and questions:

[ ] Is there a better way to handle RFS with the root-var() mixin and loop generation.
[ ] Review other instances and confirm I've covered all bases
[ ] Review output

The cssvars mixin from https://dev.to/felipperegazio/css-custom-properties-vars-with-sass-scss-a-practical-architecture-strategy-1m88 looks cleaner.

Punting on this, not super keen on going this direction at this time.


Readme is not up to date

In the readme file, the example calls the function useConfig, however, with the latest npm version, it should be useTimeConfig

Good catch, @LoganTann!

Fixed in 0.0.3.


vs TCP Performance Benchmarks

Have you all run any performance benchmarks in-house of your Quiche Quic implementation vs the TCP stack in a bleeding edge Linux kernel?
I know this is heavily dependent on if you use sendmmsg vs sendmsg and whether you do UDP GSO, and that tweaking the maximum packet size and how many acks per received packets etc can push QUIC performance up to TCP performance today.
(some links and graphs below for anyone who has this same question and find him or herself here).
But I'm wondering, without doing these tricks, what is the baseline cpu cycle multiplier loss of Quiche vs TCP in the kernel? Is it still 2x ballpark as Google (I know Quiche isn't the Google implementation) reported last year?
I guess it still isn't a fair question though since the linux kernel automatically conducts a software segmentation for TCP, and if you disable that UDP and TCP are equally (non)efficient.
https://www.fastly.com/blog/measuring-quic-vs-tcp-computational-efficiency

https://blog.cloudflare.com/accelerating-udp-packet-transmission-for-quic/

We don't have similar testing result yet. But you may find some interesting research and reports on sigcomm epiq 2020:
https://conferences.sigcomm.org/sigcomm/2020/workshop-epiq.html

thanks so much junho.
here's a link to some of those talks as well:
https://www.youtube.com/playlist?list=PLCqnh80gJ8UZ9I__LCptmTf_07Jb1Ag5y

Ian Swett's keynote at EPIQ contains some good insight into CPU usage from non-quiche implementations. I think the video will become available soon.

@LPardue
do you have any idea where Quiche falls in this mix?

I'm not at liberty to comment about that. But we encourage the community to perform their own tests using quiche, while noting that the example applications are designed to demo the API, not maximise performance. For performance-related testing, we recommend the nginx integration. The paper authors from the screenshot you provided, have indicated their future work could include an analysis of quiche using the same framework.
Finally, we love to hear from people that are planning experiments with quiche or have some results to share.

@LPardue I understand, thanks!
There are further slides on performance stability as # of connections grows, as well as packet loss and reordering rates.
Are you able to comment on these in regards to Quiche? Even if generally so.
And is it possible to maintain 50,000 - 100,000 simultaneous mostly quiet connections per logical core without extreme degradation?

I cannot comment on these details.

@LPardue fyi https://github.com/Winters123/QUIC-measurement-kit/issues/4


Implement the configurable ordering for kafka source (#3080)

Implement the configurable ordering for kafka source

Remove the CRD changes and added the defaults and validation

Remove the validation

Add comments to explain spec.ordering

Change the type into pointer for spec.ordering

Added the validation and set the default values for spec.ordering

Change the reconciler based on the setdefault for ordering

Added validation tests for spec.ordering

Fixed the code style

Move the DeliveryOrdering into sources package

Added the e2e tests

OCF Webhook is merging this PR


Fixed JsonProperty to be taken from individual members.

For example, because the annotations given to the getter affected the parameters.
related to https://github.com/FasterXML/jackson-module-kotlin/issues/668

I am not super fluent in Kotlin, but if the idea is that AnnotationIntrospector will try to figure out precedence and merging across different accessors, this is against design of Jackson's annotation handling. Ideally merging would be done in centralized place (POJOPropertiesCollector etc), and not for every annotation separately, and definitely not in AnnotationIntrospector (since they need to be kept relatively simple, and with ability to chain multiple implementations).
I realize handling like this may be the only way to right now solve the specific issue, but doing that will make maintenance much harder, implementation more complicated etc.

I understand about the policy as jackson, I will revert this change.


Connecting with HTTP/1.1 to squareup.com

Twitter
➜  ~ okurl --debug https://twitter.com/robots.txt
20:46:24.182	url https://twitter.com/robots.txt
20:46:24.187	Request Request{method=GET, url=https://twitter.com/robots.txt, tags={class com.baulsupp.okurl.credentials.Token=TokenSet(name=default)}}
20:46:24.219	Dns (twitter.com): twitter.com/<IP_ADDRESS>, twitter.com/<IP_ADDRESS>
20:46:24.415	>> CONNECTION 505249202a20485454502f322e300d0a0d0a534d0d0a0d0a
20:46:24.417	>> 0x00000000     6 SETTINGS
20:46:24.417	>> 0x00000000     4 WINDOW_UPDATE
20:46:24.419	<< 0x00000000     6 SETTINGS
20:46:24.421	--> GET https://twitter.com/robots.txt h2
20:46:24.421	User-Agent: okurl/dev
20:46:24.422	Host: twitter.com
20:46:24.422	>> 0x00000000     0 SETTINGS      ACK
20:46:24.422	Connection: Keep-Alive
20:46:24.423	Accept-Encoding: gzip
20:46:24.423	Accept-Encoding: br
20:46:24.423	--> END GET
20:46:24.474	<< 0x00000000     0 SETTINGS      ACK
20:46:24.670	Matching interceptor: null
20:46:24.675	>> 0x00000003    40 HEADERS       END_STREAM|END_HEADERS
20:46:24.795	<< 0x00000003   319 HEADERS       END_HEADERS
20:46:24.796	<< 0x00000003   493 DATA          END_STREAM
20:46:24.810	<-- 200 https://twitter.com/robots.txt (385ms)
20:46:24.810	content-encoding: gzip
20:46:24.810	content-length: 493
20:46:24.810	content-type: text/plain;charset=utf-8
20:46:24.811	date: Sat, 10 Aug 2019 19:46:24 GMT
20:46:24.811	server: tsa_f
20:46:24.811	set-cookie: personalization_id="v1_EOhKuPldeznMhVk8gQx14Q=="; Max-Age=63072000; Expires=Mon, 9 Aug 2021 19:46:24 GMT; Path=/; Domain=.twitter.com
20:46:24.811	set-cookie: guest_id=v1%3A156546638472552215; Max-Age=63072000; Expires=Mon, 9 Aug 2021 19:46:24 GMT; Path=/; Domain=.twitter.com
20:46:24.811	strict-transport-security: max-age=631138519
20:46:24.812	x-connection-hash: f4e200b660ebd7ab1556b96bb0693759
20:46:24.812	x-response-time: 107
20:46:24.812	<-- END HTTP
20:46:24.816	OkHttp Platform: ConscryptPlatform
20:46:24.816	Protocol: h2
20:46:24.816	TLS Version: TLS_1_2
20:46:24.816	Cipher: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
20:46:24.817	Peer Principal: CN=twitter.com, OU=lon3, O="Twitter, Inc.", L=San Francisco, ST=California, C=US
20:46:24.817	Local Principal: none
20:46:24.817	JVM: 11.0.3+7
#Google Search Engine Robot
User-agent: Googlebot
Allow: /?_escaped_fragment_

Allow: /*?lang=
Allow: /hashtag/*?src=
Allow: /search?q=%23
Disallow: /search/realtime
Disallow: /search/users
Disallow: /search/*/grid

Disallow: /*?
Disallow: /*/followers
Disallow: /*/following

Disallow: /account/not_my_account
Disallow: /account/deactivated
Disallow: /settings/deactivated

#Yahoo! Search Engine Robot
User-Agent: Slurp
Allow: /?_escaped_fragment_

Allow: /*?lang=
Allow: /hashtag/*?src=
Allow: /search?q=%23
Disallow: /search/realtime
Disallow: /search/users
Disallow: /search/*/grid

Disallow: /*?
Disallow: /*/followers
Disallow: /*/following

Disallow: /account/not_my_account
Disallow: /account/deactivated
Disallow: /settings/deactivated

#Yandex Search Engine Robot
User-agent: Yandex
Allow: /?_escaped_fragment_

Allow: /*?lang=
Allow: /hashtag/*?src=
Allow: /search?q=%23
Disallow: /search/realtime
Disallow: /search/users
Disallow: /search/*/grid

Disallow: /*?
Disallow: /*/followers
Disallow: /*/following

Disallow: /account/not_my_account
Disallow: /account/deactivated
Disallow: /settings/deactivated

#Microsoft Search Engine Robot
User-Agent: msnbot
Allow: /?_escaped_fragment_

Allow: /*?lang=
Allow: /hashtag/*?src=
Allow: /search?q=%23
Disallow: /search/realtime
Disallow: /search/users
Disallow: /search/*/grid

Disallow: /*?
Disallow: /*/followers
Disallow: /*/following

Disallow: /account/not_my_account
Disallow: /account/deactivated
Disallow: /settings/deactivated

# Every bot that might possibly read and respect this file.
User-agent: *
Allow: /*?lang=
Allow: /hashtag/*?src=
Allow: /search?q=%23
Disallow: /search/realtime
Disallow: /search/users
Disallow: /search/*/grid

Disallow: /*?
Disallow: /*/followers
Disallow: /*/following

Disallow: /account/not_my_account
Disallow: /account/deactivated
Disallow: /settings/deactivated

Disallow: /oauth
Disallow: /1/oauth

Disallow: /i/streams
Disallow: /i/hello

# Wait 1 second between successive requests. See ONBOARD-2698 for details.
Crawl-delay: 1

# Independent of user agent. Links in the sitemap are full URLs using https:// and need to match
# the protocol of the sitemap.