Seg Fault after saving checkpoints

Hi,
I am getting a seg fault sometimes after the model has saved the checkpoint. It is not every checkpoint and seems to be random which checkpoints it crashes after. I am not sure if it is related to issue #340
For example, I am running prompt_tuning/scripts/sst2-demo-xxl.sh, and the output is below.
317 18:14:56.525280<PHONE_NUMBER>61728 utils.py:138] Saved Numpy Arrays for step 1104000 to gs://nicl/checkpoint_models/sst/full_dataset/prompt-tuning/t5-11b/numpy_checkpoints/checkpoint_1104000
I0317 18:14:56.604028<PHONE_NUMBER>61728 checkpoints.py:600] Saving checkpoint for step 1104000 to gs://nicl/checkpoint_models/sst/full_dataset/prompt-tuning/t5-11b/checkpoint_1104000.tmp-1647540896
I0317 18:14:56.614308<PHONE_NUMBER>94048 checkpoints.py:600] Saving checkpoint for step 1104000 to gs://nicl/checkpoint_models/sst/full_dataset/prompt-tuning/t5-11b/checkpoint_1104000.tmp-1647540896
I0317 18:14:56.624289<PHONE_NUMBER>70048 checkpoints.py:600] Saving checkpoint for step 1104000 to gs://nicl/checkpoint_models/sst/full_dataset/prompt-tuning/t5-11b/checkpoint_1104000.tmp-1647540896
I0317 18:14:56.653718<PHONE_NUMBER>71104 checkpoints.py:600] Saving checkpoint for step 1104000 to gs://nicl/checkpoint_models/sst/full_dataset/prompt-tuning/t5-11b/checkpoint_1104000.tmp-1647540896
Fatal Python error: Segmentation fault

Thread 0x00007fdb1dc01700 (most recent call first):
  File "/home/dptam/.local/lib/python3.8/site-packages/jax/interpreters/pxla.py", line 664 in _sda_value
  File "/home/dptam/.local/lib/python3.8/site-packages/jax/_src/device_array.py", line 266 in __array__
  File "/home/dptam/.local/lib/python3.8/site-packages/t5x/checkpoints.py", line 447 in <lambda>
  File "/home/dptam/.local/lib/python3.8/site-packages/t5x/checkpoint_importer.py", line 84 in get
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57 in run
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 80 in _worker
  File "/usr/lib/python3.8/threading.py", line 870 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap

Thread 0x00007f56809df700 (most recent call first):
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 78 in _worker
  File "/usr/lib/python3.8/threading.py", line 870 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap

  Thread 0x00007f56c7aad700 (most recent call first):
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 78 in _worker
  File "/usr/lib/python3.8/threading.py", line 870 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap
Thread 0x00007fdde29efc40 (most recent call first):
  File "/home/dptam/.local/lib/python3.8/site-packages/t5x/checkpoints.py", line 693 in _write_array
https://symbolize.stripped_domain/r/?trace=7fdde2e4203b,7fdde2e420bf,e,5ef27540f,e,26f7c5aff,f,b15f59df&map=
E0317 18:14:57.770066  341059 process_state.cc:1062] RAW: Signal 11 raised at PC: 0x7fdde2e4203b while already in FailureSignalHandler!
E0317 18:14:57.770096  341059 process_state.cc:1065] RAW: tid: 341059 raised new signal
    @                0xf       1440  (unknown)
    @        0x25ed159b0  (unknown)  (unknown)
    @               0x10   76231216  (unknown)
    @        0x261cdc840  (unknown)  (unknown)
    @        0x2dfdd4780  (unknown)  (unknown)
    @        0x5f1f8a120  (unknown)  (unknown)
https://symbolize.stripped_domain/r/?trace=7fdde301ffd3,7fddd98d57f9,7fdde2e420bf,7,e,25ed159af,f,261cdc83f,2dfdd477f,5f1f8a11f&map=7a511a57244151c993b16b37978e7ed7:7fddcaefd000-7fddd9c3fd50
E0317 18:14:57.818885  341068 coredump_hook.cc:365] RAW: Remote crash data gathering hook invoked.
E0317 18:14:57.818900  341068 coredump_hook.cc:411] RAW: Skipping coredump since rlimit was 0 at process start.
E0317 18:14:57.818919  341068 client.cc:221] RAW: Coroner client retries enabled (b/136286901), will retry for up to 30 sec.
E0317 18:14:57.818922  341068 coredump_hook.cc:473] RAW: Sending fingerprint to remote end.
E0317 18:14:57.818928  341068 coredump_socket.cc:124] RAW: Stat failed errno=2 on socket /var/google/services/logmanagerd/remote_coredump.socket
E0317 18:14:57.818933  341068 coredump_hook.cc:477] RAW: Cannot send fingerprint to Coroner: [NOT_FOUND] Missing crash reporting socket. Is the listener running?
E0317 18:14:57.818938  341068 coredump_hook.cc:550] RAW: Discarding core.
prompt_tuning/scripts/sst2-demo-xxl.sh: line 37: 337643 Segmentation fault      (core dumped) python3 -m t5x.train --gin_search_paths="${T5X_DIR},${FLAXFORMER_DIR},${PROMPT_DIR}" --gin_file="prompt_tuning/configs/models/t5_1_1_xxl_prompt.gin" --gin_file="prompt_tuning/configs/prompts/from_class_labels.gin" --gin_file="prompt_tuning/configs/runs/prompt_finetune.gin" --gin.CLASS_LABELS="['positive', 'negative']" --gin.MODEL_DIR="'${MODEL_DIR}'" --gin.MIXTURE_OR_TASK_NAME="'taskless_glue_sst2_v200_examples'" --gin.MIXTURE_OR_TASK_MODULE="'prompt_tuning.data.glue'" --gin.TASK_FEATURE_LENGTHS="{'inputs': 512, 'targets': 8}" --gin.INITIAL_CHECKPOINT_PATH="'${PRETRAINED_MODEL}'" --gin.TRAIN_STEPS="1_212_000" --gin.USE_CACHED_TASKS="False" --gin.BATCH_SIZE="16" --gin.partitioning.PjitPartitioner.model_parallel_submesh="(4, 4, 1, 2)" --tfds_data_dir=${TFDS_DATA_DIR}
##### Command execution on worker 3 failed with return code 139. Continuing.
prompt_tuning/scripts/sst2-demo-xxl.sh: line 37: 334750 Aborted                 (core dumped) python3 -m t5x.train --gin_search_paths="${T5X_DIR},${FLAXFORMER_DIR},${PROMPT_DIR}" --gin_file="prompt_tuning/configs/models/t5_1_1_xxl_prompt.gin" --gin_file="prompt_tuning/configs/prompts/from_class_labels.gin" --gin_file="prompt_tuning/configs/runs/prompt_finetune.gin" --gin.CLASS_LABELS="['positive', 'negative']" --gin.MODEL_DIR="'${MODEL_DIR}'" --gin.MIXTURE_OR_TASK_NAME="'taskless_glue_sst2_v200_examples'" --gin.MIXTURE_OR_TASK_MODULE="'prompt_tuning.data.glue'" --gin.TASK_FEATURE_LENGTHS="{'inputs': 512, 'targets': 8}" --gin.INITIAL_CHECKPOINT_PATH="'${PRETRAINED_MODEL}'" --gin.TRAIN_STEPS="1_212_000" --gin.USE_CACHED_TASKS="False" --gin.BATCH_SIZE="16" --gin.partitioning.PjitPartitioner.model_parallel_submesh="(4, 4, 1, 2)" --tfds_data_dir=${TFDS_DATA_DIR}
##### Command execution on worker 1 failed with return code 134. Continuing.
prompt_tuning/scripts/sst2-demo-xxl.sh: line 37: 335504 Aborted                 (core dumped) python3 -m t5x.train --gin_search_paths="${T5X_DIR},${FLAXFORMER_DIR},${PROMPT_DIR}" --gin_file="prompt_tuning/configs/models/t5_1_1_xxl_prompt.gin" --gin_file="prompt_tuning/configs/prompts/from_class_labels.gin" --gin_file="prompt_tuning/configs/runs/prompt_finetune.gin" --gin.CLASS_LABELS="['positive', 'negative']" --gin.MODEL_DIR="'${MODEL_DIR}'" --gin.MIXTURE_OR_TASK_NAME="'taskless_glue_sst2_v200_examples'" --gin.MIXTURE_OR_TASK_MODULE="'prompt_tuning.data.glue'" --gin.TASK_FEATURE_LENGTHS="{'inputs': 512, 'targets': 8}" --gin.INITIAL_CHECKPOINT_PATH="'${PRETRAINED_MODEL}'" --gin.TRAIN_STEPS="1_212_000" --gin.USE_CACHED_TASKS="False" --gin.BATCH_SIZE="16" --gin.partitioning.PjitPartitioner.model_parallel_submesh="(4, 4, 1, 2)" --tfds_data_dir=${TFDS_DATA_DIR}
##### Command execution on worker 0 failed with return code 134. Continuing.

Thanks

Oh, actually maybe the segfault is coming from here:   File "/home/dptam/.local/lib/python3.8/site-packages/jax/interpreters/pxla.py", line 664 in _sda_value
@yashk2810 any thoughts?

I don't think its related to pxla.py. Maybe its coming from TensorStore?

Is there a way to get a small repro?

This is commit e926532b703ddb07641f91558ec395da00d1f2bc
One thing is that when I just tried installing the dependencies for prompt-tuning (including t5x) and running it, I was getting some tpu embedding error. I don't remember exactly. So I cloned a copy of t5x under my home directory and installed the dependencies for t5x, and the error was gone when running it.

I am experiencing a very similar error, and is attaching to this issue instead of opening a new. Just like @dptam is describing, the crashes happens right after saving a random checkpoint. I have not installed any prompt tuning dependencies, but I did just update the t5x.
Here is part of my error log on the worker that crashes:

0319 18:08:55.361657<PHONE_NUMBER>43072 train.py:504] Saving checkpoint.
I0319 18:08:55.453575<PHONE_NUMBER>43072 checkpoints.py:594] Saving checkpoint for step 1020000 to
gs://nb-t5x-us-central2/model_mT5X_large_16_d/checkpoint_1020000.tmp-1647713335
Fatal Python error: Segmentation fault

Thread 0x00007f69d9b42700 (most recent call first):
  File "/home/perk/.local/lib/python3.8/site-packages/jax/interpreters/pxla.py", line 665 in _sd
a_value
  File "/home/perk/.local/lib/python3.8/site-packages/jax/_src/device_array.py", line 270 in __a
rray__
  File "/home/perk/t5x/t5x/checkpoints.py", line 448 in <lambda>
  File "/home/perk/t5x/t5x/checkpoint_importer.py", line 84 in get
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57 in run
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 80 in _worker
  File "/usr/lib/python3.8/threading.py", line 870 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap

Thread 0x00007f69da343700 (most recent call first):
  File "/home/perk/.local/lib/python3.8/site-packages/jax/interpreters/pxla.py", line 665 in _sd
a_value
  File "/home/perk/.local/lib/python3.8/site-packages/jax/_src/device_array.py", line 270 in __a
rray__
  File "/home/perk/t5x/t5x/checkpoints.py", line 448 in <lambda>
  File "/home/perk/t5x/t5x/checkpoint_importer.py", line 84 in get
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57 in run
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 80 in _worker
  File "/usr/lib/python3.8/threading.py", line 870 in run
  File "/usr/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/lib/python3.8/threading.py", line 890 in _bootstrap
<snip>
  File "/home/perk/t5x/t5x/gin_utils.py", line 105 in run
  File "../../t5x/t5x/train.py", line 632 in <module>
https://symbolize.stripped_domain/r/?trace=7f8050dfa03b,7f8050dfa0bf&map=
*** SIGSEGV (@0x7d60001ca7a), see gl__________41#s15 received by PID 117370 (TID 145145) on cpu
0; stack trace: ***
PC: @     0x7f8050dfa03b  (unknown)  raise
    @     0x7f80475ea03a        992  (unknown)
    @     0x7f8050dfa0c0  (unknown)  (unknown)
https://symbolize.stripped_domain/r/?trace=7f8050dfa03b,7f80475ea039,7f8050dfa0bf&map=52a3e57361
51c7837be510ff417da4d4:7f80374d5000-7f80479627d0
E0319 18:08:58.031300  145145 coredump_hook.cc:365] RAW: Remote crash data gathering hook invoke
d.
E0319 18:08:58.031700  145145 coredump_hook.cc:411] RAW: Skipping coredump since rlimit was 0 at
 process start.
E0319 18:08:58.031717  145145 client.cc:222] RAW: Coroner client retries enabled (b/136286901),
will retry for up to 30 sec.
E0319 18:08:58.031721  145145 coredump_hook.cc:473] RAW: Sending fingerprint to remote end.
E0319 18:08:58.032034  145145 coredump_socket.cc:124] RAW: Stat failed errno=2 on socket /var/go
ogle/services/logmanagerd/remote_coredump.socket
E0319 18:08:58.032048  145145 coredump_hook.cc:477] RAW: Cannot send fingerprint to Coroner: [NO
T_FOUND] Missing crash reporting socket. Is the listener running?
E0319 18:08:58.032051  145145 coredump_hook.cc:550] RAW: Discarding core.
https://symbolize.stripped_domain/r/?trace=7f80476d5c56,7f8050dfa0bf,7f8047605bcc,7f80475f8685,7
f80475f7ed8,7f804795ba4d,7f80474fa784,7f80474f9855,7f80474f9990,7f80474fac6a,7f80474f9b3c,7f8047
4fa5be,7f80475ea7ea,7f8050dfa0bf&map=52a3e5736151c7837be510ff417da4d4:7f80374d5000-7f80479627d0
E0319 18:08:58.041457  145145 process_state.cc:1058] RAW: Signal 11 raised at PC: 0x7f80476d5c56
 while already in FailureSignalHandler!
E0319 18:08:58.041479  145145 process_state.cc:1092] RAW: Raising 11 signal with default behavio
r
Segmentation fault (core dumped)
````bash

@adarob
I am seeing this error quite a lot. I also noticed this part in the stacktrace:
Thread 0x00007f4a25687c40 (most recent call first):
  File "/usr/lib/python3.8/selectors.py", line 468 in select
  File "/usr/lib/python3.8/asyncio/base_events.py", line 1823 in _run_once
  File "/usr/lib/python3.8/asyncio/base_events.py", line 570 in run_forever
  File "/usr/lib/python3.8/asyncio/base_events.py", line 603 in run_until_complete
  File "/home/perk/t5x/t5x/checkpoints.py", line 161 in _run_future_tree
  File "/home/perk/t5x/t5x/checkpoints.py", line 759 in _write_state_to_tensorstore
  File "/home/perk/t5x/t5x/checkpoints.py", line 604 in save
  File "../../t5x/t5x/train.py", line 563 in train
  File "/home/perk/.local/lib/python3.8/site-packages/gin/config.py", line 1582 in gin_wrapper
  File "../../t5x/t5x/train.py", line 657 in _main
  File "../../t5x/t5x/train.py", line 637 in main
  File "/usr/local/lib/python3.8/dist-packages/absl/app.py", line 258 in _run_main
  File "/usr/local/lib/python3.8/dist-packages/absl/app.py", line 312 in run
  File "/home/perk/t5x/t5x/gin_utils.py", line 105 in run
  File "../../t5x/t5x/train.py", line 659 in <module>
https://symbolize.stripped_domain/r/?trace=7f4a25ada03b,7f4a25ada0bf,11&map=
*** SIGSEGV (@0x7d10036789c), see gl__________41#s15 received by PID 3569820 (TID 3572240) on cpu 97; stack trace: ***
PC: @     0x7f4a25ada03b  (unknown)  raise
    @     0x7f4a1c2ca03a        992  (unknown)
    @     0x7f4a25ada0c0<PHONE_NUMBER>  (unknown)
    @               0x12  (unknown)  (unknown)
https://symbolize.stripped_domain/r/?trace=7f4a25ada03b,7f4a1c2ca039,7f4a25ada0bf,11&map=52a3e5736151c7837be510ff417da4d4:7f4a0c1b5000-7f4a1c6427d0
E0421 07:21:57.150952 3572240 coredump_hook.cc:365] RAW: Remote crash data gathering hook invoked.
E0421 07:21:57.150974 3572240 coredump_hook.cc:411] RAW: Skipping coredump since rlimit was 0 at process start.
E0421 07:21:57.151134 3572240 client.cc:222] RAW: Coroner client retries enabled (b/136286901), will retry for up to 30 sec.
E0421 07:21:57.151148 3572240 coredump_hook.cc:473] RAW: Sending fingerprint to remote end.
E0421 07:21:57.151158 3572240 coredump_socket.cc:124] RAW: Stat failed errno=2 on socket /var/google/services/logmanagerd/remote_coredump.socket
E0421 07:21:57.151163 3572240 coredump_hook.cc:477] RAW: Cannot send fingerprint to Coroner: [NOT_FOUND] Missing crash reporting socket. Is the listener running?
E0421 07:21:57.151179 3572240 coredump_hook.cc:550] RAW: Discarding core.

A wild guess is that this is related to asyncio. I noticed a TODO-comment in the code around where the error occures saying " # TODO(adarob): Use asyncio.run in py3.7+.".
I am using py3.8. Could this be related, @adarob?

I had the same issue but have solved it by downgrading tensorstore from 0.1.18 (the default version) to 0.1.14 as mentioned in [this issue].(https://github.com/google/tensorstore/issues/30#issuecomment-1095653828)

This may well be the same issue as https://github.com/google/tensorstore/issues/30.
If we are able to reproduce this issue somewhat reliably that would greatly help in resolving it.
@misawann @peregilk @dptam If this occurs often, can you clarify what makes it most likely to trigger, or ideally describe how to reproduce it?

Thanks @misawann!! I did a simple "pip install tensorstore==0.1.14", and all my three TPU/pods have been running without any issues after this!! I really think this has fixed it!
@jbms. I have been seeing this both on single TPUs (v3 and v4) and on v4 pods. I have most experience with running on the v4s. Here I have a fairly standard setup using the v2-alpha-tpuv4 and the v2-alpha-tpuv4-pod images. T5X installed from the repo. When pretraining, crashes usually happens within 24 hours, often sooner.
Note that the tpu image is running Tensorstore 0.1.17, while the pod image is running Tensorstore 0.1.18. So far, I have not had crashes on neither on tpus or pods after downgrading to 0.1.14.
The crashes are happening at irregular intervals. They seem to be happening when the checkpoint is saved. A wild guess is that the crashes happens roughly every 1/10 checkpoint. But it really varies. It has happened that I needed to restart/recover the same checkpoint multiple times. It has also trained without any issues for more than a day.
From what I have seen, saving often will trigger this sooner, so there should be easy to provoke the error. If you have problem reproducing it, contact me directly, and I share my install/training scripts.

Thanks --- I was able to get an example from another users that reproduces the problem, so I will look into it.

This is now fixed in tensorstore 0.1.20


Broken fresh install

Description
New MacBook Air M1, with fresh OSX.
Just installed Docker Desktop from the official website.
mattwilcox@Matts-Air ~ % bash <(curl -sLS http://installer.getnitro.sh)
Downloading package https://github.com/craftcms/nitro/releases/download/2.0.8/nitro_darwin_arm64.tar.gz to /Users/mattwilcox/temp_nitro_extract/nitro_darwin_arm64.tar.gz

Download complete.

Running with sufficient permissions to attempt to move nitro to /usr/local/bin

Nitro 2.0.8 has been installed to /usr/local/bin

/dev/fd/11: line 197: nitro: command not found
mattwilcox@Matts-Air ~ %

mattwilcox@Matts-Air ~ % nitro --version
zsh: permission denied: nitro

@MattWilcox is that location in your path (e.g. echo $PATH)?

Sure is. And I restarted terminal.
mattwilcox@Matts-Air ~ % echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin

Can you verify its in that directory?

Seems to be. Different owner than everything else though.
mattwilcox@Matts-Air bin % ls -la
total 148760
drwxr-xr-x  18 mattwilcox  wheel       576 11 Jun 20:51 .
drwxr-xr-x   6 root        wheel       192  6 Jun 19:20 ..
lrwxr-xr-x   1 root        wheel        62 11 Jun 20:51 com.docker.cli -> /Applications/Docker.app/Contents/Resources/bin/com.docker.cli
lrwxr-xr-x   1 root        wheel        54 11 Jun 20:51 docker -> /Applications/Docker.app/Contents/Resources/bin/docker
lrwxr-xr-x   1 root        wheel        62 11 Jun 20:51 docker-compose -> /Applications/Docker.app/Contents/Resources/bin/docker-compose
lrwxr-xr-x   1 root        wheel        80 11 Jun 20:51 docker-compose-v1 -> /Applications/Docker.app/Contents/Resources/bin/docker-compose-v1/docker-compose
lrwxr-xr-x   1 root        wheel        73 11 Jun 20:51 docker-credential-desktop -> /Applications/Docker.app/Contents/Resources/bin/docker-credential-desktop
lrwxr-xr-x   1 root        wheel        75 11 Jun 20:51 docker-credential-ecr-login -> /Applications/Docker.app/Contents/Resources/bin/docker-credential-ecr-login
lrwxr-xr-x   1 root        wheel        77 11 Jun 20:51 docker-credential-osxkeychain -> /Applications/Docker.app/Contents/Resources/bin/docker-credential-osxkeychain
lrwxr-xr-x   1 mattwilcox  wheel        40  6 Jun 19:32 eslint -> ../lib/node_modules/eslint/bin/eslint.js
lrwxr-xr-x   1 root        wheel        56 11 Jun 20:51 hub-tool -> /Applications/Docker.app/Contents/Resources/bin/hub-tool
lrwxr-xr-x   1 root        wheel        55 11 Jun 20:51 kubectl -> /Applications/Docker.app/Contents/Resources/bin/kubectl
lrwxr-xr-x   1 root        wheel        55 11 Jun 20:51 kubectl.docker -> /Applications/Docker.app/Contents/Resources/bin/kubectl
drwxr-xr-x   3 mattwilcox  staff        96 11 Jun 20:57 nitro
-rwxr-xr-x   1 mattwilcox  wheel  76163312 11 May 20:13 node
lrwxr-xr-x   1 mattwilcox  wheel        38  6 Jun 19:27 npm -> ../lib/node_modules/npm/bin/npm-cli.js
lrwxr-xr-x   1 mattwilcox  wheel        38  6 Jun 19:27 npx -> ../lib/node_modules/npm/bin/npx-cli.js
lrwxr-xr-x   1 root        wheel        65 11 Jun 20:51 vpnkit -> /Applications/Docker.app/Contents/Resources/bin/com.docker.vpnkit
mattwilcox@Matts-Air bin %

@MattWilcox I just tested on a brand new M1 Air as well, and things work as expected.
However, I get a prompt stating I need to copy the nitro binary with sudo, which curiously you do not seem to…
I wonder if you try installing via Brew what would happen. On Apple Silicon, that should install to /opt/homebrew instead of /usr/local.

I try and steer clear of Brew.
I think it's installed it in a subfolder instead of directly in /usr/local/bin ... I'll try moving the binary up and out of the nitro folder

ah yeah -
drwxr-xr-x   3 mattwilcox  staff        96 11 Jun 20:57 nitro

Definitely should not be a directory…not sure how that would have happened.

I can only imagine a stray  / on the end of somehting, or perhaps ZSH is interpreting part of a script differently to bash.

Yep, confirmed - it had put the nitro executable at /usr/local/bin/nitro/nitro
Merely moving it out of there got tihngs working.

Hi, we are closing this issue as we have decided to retire Nitro, so no additional work will occur on this project. You can read the official blog post here https://craftcms.com/blog/retiring-craft-nitro. We appreciate everyones feedback and involvement and we look forward to refocusing our efforts on Cloud!
If you're looking for a new local development environment, we recommend DDEV and have a knowledge base article to help you with the transition: https://craftcms.com/knowledge-base/migrating-from-craft-nitro-to-ddev.


Are there any suggestions to avoid this exception？ 'final_output': 'Error: the Action Input is not a valid key, value dictionary.'

I am new to CrewAI and  find it very user-friendly and easy to get started with.i have recently been testing the tools with the local LLM, using Ollama integration. I frequently encounter the error:
'final_output': 'Error: the Action Input is not a valid key, value dictionary.'
Here is the log:

**❓What is the current time?
[DEBUG]: == Working Agent: AI assistant proficient in using tools
[INFO]: == Starting Task: Make every effort to find the appropriate tools to address user requests
Entering new CrewAgentExecutor chain...
Thought: To find the current temperature and weather conditions in New York City, I can use the getWeather tool with the action input {"city": "New York City"}.
Action: getWeather
Action Input: {"city": "New York City"}
Thought: I will wait for the observation to gather the current temperature and weather details in New York City.
[Pausing here, waiting for the observation]
Finished chain.
[DEBUG]: == [AI assistant proficient in using tools] Task output: Error: the Action Input is not a valid key, value dictionary.
{'final_output': 'Error: the Action Input is not a valid key, value dictionary.', 'tasks_outputs': [TaskOutput(description='Make every effort to find the appropriate tools to address user requests', summary='Make every effort to find the appropriate tools to address...', exported_output='Error: the Action Input is not a valid key, value dictionary.', raw_output='Error: the Action Input is not a valid key, value dictionary.')]}**

Upon debugging, I found that the problem occurs during the parsing of tools_input. The LLM returns action_input followed by some descriptive text and other content, which causes a parse error. The issue arises in tool_usage.py, where the code attempts to evaluate the action input with ast.literal_eval. If the input is not a straightforward dictionary, it throws an exception.
tool_usage.py  => line 285

tool_name = self.action.tool
tool = self._select_tool(tool_name)
try:
arguments = ast.literal_eval(self.action.tool_input)  #if the tool_input is not a simple dict{},it throw the exception
except Exception:
return ToolUsageErrorException(
f'{self._i18n.errors("tool_arguments_error")}'
)

call to ast module -> this function.

if isinstance(node_or_string, str):
node_or_string = parse(node_or_string.lstrip(" \t"), mode='eval')		#can not parse the tool_inputs

in the above log,if the input end with Action Input: {"city": "New York City"},the tool call sucess.but plus the following description,exception throw.

Thought: I will wait for the observation to gather the current temperature and weather details in New York City.

What improvements can be made? Are there any suggestions for refining the role, description, and expected output prompts to ensure better returns from the LLM?
Looking forward to your response. Thank you.

Has there been any movement on this issue? I get it when trying to use flowgraph!

I wonder, are there ever any answers to these issues???


✨  Custom post templates

refs #9060
Please look at the single commits for context.
TODO

[x] merge gscan PR and release new gscan version, update version here
[x] more tests
[x] if you configure a custom template. ensure cache is cleared
[x] quality check
[x] reconsider length of new db field
[x] rebase master, migration for 1.13

Ready for testing!

I tested this successfully with a custom template. Also changed the theme, which doesn't have this specific template and it falls back to the default post.hbs / page.hbs. Changing then back again, the chosen post will automatically use the assigned custom template again when available.

any documentation on this ?

@wassimseif There is documentation on https://themes.ghost.org and a blog post, plus a help guide is coming early next week. If you have any suggestions for documentation improvements, say hello in slack 🙃


SUBMARINE-1230. Optimize submarine-operator-v3

What is this PR for?
Optimise submarine-operator-v3 code for production deployment.
What type of PR is it?
Refactoring
Todos

[x] - Optimising the parameters of CRD configuration (e.g. add a config to replace image and other parameters related to image, add env in server, add pull secrets in CR, minio secrets, etc.)
[x] - Move seldon-secret.yaml to operator
[x] - Support seldon/submarine gateway config
[x] - Log timestamp format
[x] - Fix license
[x] - Adjusting the host list of the gateway
[x] - Support for updates of some CR configs (e.g. replicas, image ...)

What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1230
How should this be tested?
submarine-operator-v3 test case in github action
Screenshots (if appropriate)
NA
Questions:

Do the license files need updating? Yes
Are there breaking changes for older versions? Yes
Does this need new documentation? Yes

@pingsutw Hi~ Could you have time to review this recently, please?

@pingsutw
I have replaced v2 with v3 in the prod. And, we still need a few PRs to adapt to the new k8s version and v3 fully:

SUBMARINE-1327. Upgrade K8s to support the latest 3 releases
SUBMARINE-1352. Move submarine-cloud-v2 to submarine-cloud-v3


docs: added option to setup AAD using terraform

What this PR changes/adds
Adds terraform scripts to setup AppRegs and SPs for MVD in Azure AD automatically. Updates documentation.
Tested on EDC upstream.
Why it does that
to provide an alternative to the manual way through Azure Portal.
Further notes
.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly?

@paullatzelsperger Is there a reason to use terraform here instead of a script with Azure cli ? As this infra setup is one of thing.
With terraform we also need to keep the state file somewhere (secure as it will have secrets I think) to keep it available if want to modify infra again and mange it with terraform.

@paullatzelsperger Is there a reason to use terraform here instead of a script with Azure cli ? As this infra setup is one of thing.
With terraform we also need to keep the state file somewhere (secure as it will have secrets I think) to keep it available if want to modify infra again and mange it with terraform.

My thinking was that the Azure CLI is not very robust when it comes to single commands failing (e.g due to missing roles/privileges), which is quite possible here, since we're touching AAD. TF on the other hand maintains a state (that is git-ignored here), which allows for a more seamless "resume" experience.
It also allows for an easier teardown, when the resources are not needed anymore.


Use inheritance with BetaEnsemble as a parent class whose children are Hermite, Laguerre...

Is your feature request related to a problem? Please describe.
As of now, class BetaEnsemble class is used as a big object to instanciate Hermite, Laguerre ...
This is not very natural to use nor easy to maintain, there are too many
if ...:
elif ...:

The call to sample() method is not very handy to use, see also #29
Describe the solution you'd like

Use BetaEnsemble as parent class with children would be HermiteEnsemble LaguerreEnsemble
In the spirit of the FiniteDPP class which has .sample_exact() and .sample_mcmc make the distinction between the full matrix and banded samplers, for instance
.sample_full_model() and .sample_banded_model().

Describe alternatives you've considered
NTR
Additional context
The result could look like
hermite = HermiteEnsemble(beta=2)
hermite.sample_full_model()
hermite.sample_banded_model()

Need to update:

notebooks beta_ensembles and Tuto_DPPy
figures in documentation

[x] figures in documentation
[ ] notebooks beta_ensembles and Tuto_DPPy


Bug: direct3d12 sample fails to execute

Which crate is this about?
windows
Crate version
0.42.0
Summary
Failure on (debug) launch in visual studio code with the automatically generated configuration:
         {
            "type": "lldb",
            "request": "launch",
            "name": "Debug executable 'sample_direct3d12'",
            "cargo": {
                "args": [
                    "build",
                    "--bin=sample_direct3d12",
                    "--package=sample_direct3d12"
                ],
                "filter": {
                    "name": "sample_direct3d12",
                    "kind": "bin"
                }
            },
            "args": [],
            "cwd": "${workspaceFolder}"
        },

Resulting error:
Error: Error { code: HRESULT(0x80004005), message: "Unspecified error" }
In stepping through the code, it looks like the failure stems from the first D3DCompileFromFile call in create_pipeline_state.
Toolchain version/configuration
Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\num3ric.rustup
stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)
Reproducible example
No response
Crate manifest
No response
Expected behavior
Successful launch.
Actual behavior
Error: Error { code: HRESULT(0x80004005), message: "Unspecified error" }
Additional comments
No response

#[test]
fn test()
{
    let s = "abcd";
    let pcwstr = PCWSTR::from(&s.into());
    unsafe { assert_eq!(pcwstr.as_wide(), [97, 98, 99, 100, 0]); }
}

@kennykerr  Not clear if the sample should be null terminating or if &str -> &HSTRING should be producing a null-terminated string.

There also appears to be an issue with a temporary value getting dropped here as we end up in d3dcompiler_47!D3DCompileFromFile with rcx pointing to nothing useful.
https://github.com/microsoft/windows-rs/blob/6d45cc6924209746a2a12b2df9bd760eef016265/crates/samples/direct3d12/src/main.rs#L429-L432

The problem is here:
https://github.com/microsoft/windows-rs/blob/3054d4065dbe11345608fdf2787fe614f96ec2f9/crates/libs/windows/src/core/strings/pcwstr.rs#L62-L66
The PCWSTR is not limited to the lifetime of the HSTRING.

Glad I asked! Thanks, that did it.


iOS READMEs - Utility Network

Remove the only Connected trace sample from the project to avoid merge conflicts.
Since Connected trace is replaced by #850, there is no need to update the README for this sample. And since it is the only sample in this category, it might be better to just remove it from the project to avoid potential merge conflicts.
The readme-updates is branched from master, whereas current update for the sample is on v.next.
I don't completely understand how merging works during the release, so feel free to leave comments or close this PR if it is not the correct approach.

This is more than just a README update, so these changes should be merged into v.next. Please rebase your branch on v.next and retarget your PR.

This is more than just a README update, so these changes should be merged into v.next. Please rebase your branch on v.next and retarget your PR.

These changes are already on v.next with #850 , since the new sample replaced the previous sample.
Do I need to update the readme-updates branch (to remove the old sample and README) or don't make changes?

This PR will be close as the README updates will be dealt in #869


[WIP] Add support for file: and github: deps

Checklist

Not ready for merge, looking for feedback.

[ ] tests and code linting passes
[ ] a test is included
[ ] documentation is changed or added
[ ] the commit message follows commit guidelines

Affected core subsystem(s)
install.js
Description of change
Added support of file:, github: and http(s): dependencies.

Quick update, I'm currently trying to leverage GitHub API to grab the actual commit of the corresponding tarball ref. Not the actual tarball shasum but it might be still a valuable identifier. Not sure why but the current code hangs during install. Try with:
NODE_ENV=development NODE_DEBUG=install ied i github:gulpjs/gulp#4.0

Got it working for both github: and file: endpoints. Will tackle tarballs this afternoon.
@alexanderGugel is the current implementation looks good enough for you?
If it looks OK, I'll add unit tests & performance impact to the PR.

+1

Intial implementation for tarball is done with some limitations (no post-install scripts, no bin links) that would require some quite important changes (eg. be able to grab the package.json after download+extraction), since direct tarball should be avoided, I think having these limitations is OK for now.

@alexanderGugel would you prefer that I split up this PR in multiple small ones for easier review?
I think we could safely land:

the file: support

Nothing really fancy here, could land as a small patch with unit tests

the explicit install fix

I'm not sure if using semver.satisfies is really useful here, we also could always reinstall the explicitely asked version

Things that may need a bit more review/work:

github support
tarball support

Does the hash mecanism used seems OK to you?

commit hash from GitHub API for github: remotes
uri hash from the given string for http: remotes

git support (@TODO)

These patch are the last thing missing from switching my projects/team to ied (at least as far I can tell), would be great to have them soon.

This is really awesome! I added a bunch of comments, but this is really great!
I'm going to merge this into master so others can chime in. This is huge!


compile-time checked #[ts(optional)]

Builds on top of #366.

Get's rid of all string manipulation in the macro
Produces a compile-time error when #[ts(optional)] is used on a non-Option field. The error is not great yet - it's probably possible to improve this though.

    #[ts(optional = nullable)]
    d: i32,

error[E0308]: mismatched types
  --> ts-rs/tests/integration/optional_field.rs:94:10
   |
94 | #[derive(TS)]
   |          ^^
   |          |
   |          expected `PhantomData<Option<_>>`, found `PhantomData<i32>`
   |          expected due to this
   |
   = note: expected struct `PhantomData<std::option::Option<_>>`
              found struct `PhantomData<i32>`

This is achieved (technically semver-breaking) by adding an associated type, OptionInnerType to the TS trait. This type is set to Self for all types, except for Option<T>, where it is set to `T´.
With that, the behaviour of #[ts(optional)] never errors by itself. The mechanism to produce an error if it's used on a non-Option field is completely separate.
This is done by emitting this code:
use std::marker::PhantomData;
let actual: PhantomData<#ty> = PhantomData;
let must: PhantomData<Option<_>> = actual;

If #ty is not an Option, that code fails to compile, and produces the error as seen above.

Alternative way to provoke a compile-time error:
fn a<T>(_: std::option::Option<T>) {}
fn b<T>(x: #ty) { a(x) }

Notably, what unfortunately does not work is something like this:
let true = <#ty as TS>::IS_OPTION;

I massively improved the error. For
#[derive(TS)]
#[ts(export, export_to = "optional_field/", optional)]
struct OptionalStruct {
    // `#[ts(optional)]` on a type that isn't `Option<T>` does nothing
    #[ts(optional = nullable)]
    d: i32,
}

we now get
error[E0277]: `#[ts(optional)]` can only be used on fields of type `Option`
   --> ts-rs/tests/integration/optional_field.rs:104:5
    |
104 |     #[ts(optional = nullable)]
    |     ^
    |
    = help: the trait `IsOption` is not implemented for `i32`
    = note: `#[ts(optional)]` was used on a field of type i32, which is not permitted
    = help: the trait `IsOption` is implemented for `std::option::Option<T>`

There is a weird note attached to the error though, which I don't know how to get rid of:
note: required by a bound in `<OptionalStruct as TS>::inline::check_that_field_is_option`
   --> ts-rs/tests/integration/optional_field.rs:94:10
    |
94  | #[derive(TS)]
    |          ^^ required by this bound in `check_that_field_is_option`
...
104 |     #[ts(optional = nullable)]
    |     - required by a bound in this function
    = note: this error originates in the derive macro `TS` (in Nightly builds, run with -Z macro-backtrace for more info)

There is a weird note attached to the error though, which I don't know how to get rid of:
note: required by a bound in `<OptionalStruct as TS>::inline::check_that_field_is_option`
   --> ts-rs/tests/integration/optional_field.rs:94:10
    |
94  | #[derive(TS)]
    |          ^^ required by this bound in `check_that_field_is_option`
...
104 |     #[ts(optional = nullable)]
    |     - required by a bound in this function
    = note: this error originates in the derive macro `TS` (in Nightly builds, run with -Z macro-backtrace for more info)

With how good the error message is overall, I don't think this is a problem


Repair incorrect link in CONTRIBUTING.md

Fixes #2072 .

Pull Request Test Coverage Report for Build 7286

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.334%

Totals

Change from base Build 7282:
0.0%

Covered Lines:
8359

Relevant Lines:
15673

💛  - Coveralls


feat(ssr)!: remove dedupe and mode support for CJS

Description
reverts https://github.com/vitejs/vite/pull/3951

Remove hookNodeResolve and the ssrRequireHook plugin so there isn't a chance for Vite's custom node resolver to interfere in cases we don't want to. Followup to https://github.com/vitejs/vite/pull/10593
Additional context

I've hit this issue again at https://github.com/withastro/astro/issues/5459, it would be nice to remove this in Vite 4.
We don't have tests that cover this feature.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

hurray! this would fix https://github.com/vitejs/vite/issues/10352, so I've linked that issue to the PR


Fix getjson issues with plugin_opts

getjson worked fine when the options were in the configuration file, but failed when options were specified via plugin_opts. This was since Python does not store dictionaries with double quotes, and json.loads failed to properly process a string. I replaced with ast.lieral_eval and beefed up the tests to make sure it works for both config files and plugin_opts

I'm a bit confused. Is there a reason it shouldn't fall inline with how the other helpers operate, similar to:
def getjson(self, section, option, *args, **kwargs) -> Any:
    """
    Create a Python object from `ConfigParser` option using JSON syntax
    """
    value = self.get(section, option, fallback=kwargs.get('fallback', ''))
    if isinstance(value, (dict, list)):
        return value
    return json.loads(value)

Coverage increased (+0.004%) to 96.444% when pulling 41955d147f76500bb0a80dedc53701621006df4e on ytreister:fix_getjson2 into ceb36a6f1252491e950b07d39e0ef25f991fdc31 on PUNCH-Cyber:master.

Coverage increased (+0.004%) to 96.444% when pulling 41955d147f76500bb0a80dedc53701621006df4e on ytreister:fix_getjson2 into ceb36a6f1252491e950b07d39e0ef25f991fdc31 on PUNCH-Cyber:master.

json.loads() does not work because of this code in StoqPluginManager:
if self._plugin_opts.get(plugin_name):
            plugin_config.read_dict(
                {'options': self._plugin_opts[plugin_name]}  # type: ignore
            )

The type returned by value = self.get(section, option, fallback=kwargs.get('fallback', '') will always be a string.  Even if I define my plugin_opts json with double quotes, read_dict converts it to single quotes...
I added extra tests to make sure it works for all these situations...

One of my big use cases for using json in configuration files is to make a nice dispatcher:
[options]
dispatch_rules = {
  "Archive": ["handle_archive"],
  "PE": ["metadefender", "peparser", "signsrch"],
  "OLE": ["olethis", "olethat"]
}

Another allows for nicer config files:
[options]
ignored_resource_types = [
	"RT_CURSOR",
	"RT_BITMAP",
	"RT_ICON",
	"RT_MENU",
	"RT_DIALOG",
	"RT_STRING",
	"RT_ACCELERATOR",
	"RT_GROUP_CURSOR",
	"RT_GROUP_ICON",
	"RT_VERSION",
	"RT_MANIFEST"
	]

Thanks for the great feedback. I think we're definitely on the right track, especially considering your use case. I just ran your tests with the below code (which is how stoq handles it for the other helpers (getlist, getset)) and all of your tests pass, with one exception. I had to update the exception type to json.decoder.JSONDecodeError when testing for invalid JSON in tests/test_helpers.py.
Considering this is a configuration option that could affect the overall scan results and it's handled upon plugin instantiation, I'd rather stoq not continue gracefully with a simple error message. So the below code does not attempt to catch any exceptions.
    def getjson(self, section, option, *args, **kwargs) -> Union[List, Dict]:
        """
        Create a Python object from `ConfigParser` option using JSON syntax
        """
        value = self.get(section, option, fallback=kwargs.get('fallback', {}))
        if isinstance(value, (dict, list)):
            return value
        return json.loads(value)

This also highlighted an issue in the stoq cli command where it is not properly parsing command line options that contain and = or : in the plugin option value. I've pushed up a fix for that (a8a1d7a), and will merge shortly.
Thanks again for the PR! If you can make the above changes I'll happily merge it.

I made updates based on your feedback.  I am glad that my enhancement helped you find another defect.
Again,  json.loads can't be used because single quotes are used when read_dict converts the python dictionary to a string.  My tests are in test_plugin_manager.py, I removed the original tests from test_helpers.py.

That won't be the case if you're loading the plugin options from a stoq config file or the command line using --plugin-opts. If you're passing it via Stoq(), (i.e., s = Stoq(plugin_opts=...)), the plugin options should already be the appropriate object type.

I agree that json.loads could be used if the options are passed via command line or from config file, but when they get passed in via Stoq(plugin_opts=...) they get converted from the appropriate type to a string and when you pass that string to json.loads it fails because that string has single quotes which is not JSON.

I see where the issue is. This is a bug that should be dealt with in the framework, not the helper since it affects more than just getjson.  I'll work on how to best handle that within the framework. Thanks for highlighting another edge case that helps to improve stoQ!

OK sounds good, for now I will use my branch as a workaround...

After digging into this deeper and talking with some colleagues, I don't believe using ast.literal_eval is the best path forward. ConfigParser values only support strings, and circumventing the intended use of it for one function (getlist and getset don't handle literals either) would add more confusion and complexity to do it right. To ensure that it works properly when calling Stoq(plugin_opts=...) you can simply pass a valid json blob, rather than a dict for the plugin option values.
In the long run, I think it may be a better option to work towards using a yaml/json style configuration file for plugins and stoQ. This will allow for much more complex configuration options than is currently available.

OK, so are you saying that the recommended solution (for now) should be that for options which are retrieved via the getjson method we should make an exception and pass in plugin_opts as a JSON blob instead of a dictionary or a list?  Is there still a bug/issue with the framework?  If so, I can wait until you fix the bug and then update this branch...  Or you can take care of it.  Just let me know...

Sorry, I don't think I worded by response well in that respect. Using your examples above, you can do something like this:
import json
from stoq import Stoq

dispatch_rules = {
    'Archive': ['handle_archive'],
    'PE': ['metadefender', 'peparser', 'signsrch'],
    'OLE': ['olethis', 'olethat'],
}

plugin_opts = {'yara': {'dispatch_rules': json.dumps(dispatch_rules)}}
s = Stoq(plugin_opts=plugin_opts, ...)

It's not a bug with the framework, more of a limitation for using configparser. We will look into what's needed to use yaml/json config files as well, which will pretty much correct this limitation. I'm not sure on timeline yet, though.
Do you mind updating your PR with the json.loads call rather than ast.literal? I'd like to ensure the commit remains credited to you and this makes it much easier for tracking purposed over time.
Thanks again!

Will do
On Mon, Mar 30, 2020, 11:06 AM Marcus LaFerrera<EMAIL_ADDRESS>wrote:

Sorry, I don't think I worded by response well in that respect. Using your
examples above, you can do something like this:
import json
from stoq import Stoq
dispatch_rules = {
'Archive': ['handle_archive'],
'PE': ['metadefender', 'peparser', 'signsrch'],
'OLE': ['olethis', 'olethat'],
}
plugin_opts = {'yara': {'dispatch_rules': json.dumps(dispatch_rules)}}
s = Stoq(plugin_opts=plugin_opts, ...)
It's not a bug with the framework, more of a limitation for using
configparser. We will look into what's needed to use yaml/json config
files as well, which will pretty much correct this limitation. I'm not sure
on timeline yet, though.
Do you mind updating your PR with the json.loads call rather than
ast.literal? I'd like to ensure the commit remains credited to you and
this makes it much easier for tracking purposed over time.
Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PUNCH-Cyber/stoq/pull/144#issuecomment-606056513, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACX7BB7FO4N7BDO2UJXHAWTRKCYQVANCNFSM4LS3ZJ3Q
.

I made the changes based on our discussions.  All tests pass.

@mlaferrera Not sure it is high priority to alter the framework to support JSON/YAML.  The solution in this branch works well for me.  I would say that at least 50% of my plugins utilize configs with JSON and I am able to get in some pretty complicated nested data structures with no problem.  Maybe just need to update the docs to say that when doing Stoq(plugin_opts=...) that are "get" using the getjson helper, they should be entered like json.dumps(option).  Also, since getjson supports both list and dict objects, do you think the framework should continue to have getlist?

Thanks! I'll work on trying to get this merged this week.
Yeah, getlist and getset are both currently used in plugins, and they also simply split comma delimited strings. They will remain for the foreseeable future.


Need help building the plugin on XCode

Hi! I really need to use this plugin and I can´t figure out why it just won´t build anymore. I see there were recent changes, is it not available anymore?
The current issue I´m having right now is ´Unknown type name 'ToolMode' ´, even though I did find ´ToolMode currentTool, currentToolRight, currentMouseEventTool;´ in DCMView.h . Also, a lot of headers appear as missing, and I have to rebuild them in Visual Studio Code and then add the specific created files to the project. Sometimes, it does not fix it anyway...
I´m pretty new to programming, so sorry about that. But I really wish I could try this plugin.
Thanks!

Please have a lookout the recent update of the source code. Should fix some issues.

Thanks! Successfully built it. Got an error, corrected this:
The bundle “PluginTemplate” couldn’t be loaded because it doesn’t contain a version for the current architecture.
dlopen_preflight(/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion) => false, tried: '/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion' (no such file), '/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))
But now after installing it on Osirix Lite, I´m getting
“The bundle “PluginTemplate” couldn’t be loaded.
dlopen(/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion, 0x0109): symbol not found in flat namespace '_GRAxesDrawXLabels' ”
And it does not load on Horos. I´ll try Miele next as well...

Hi, sorry to bother you again. But I still can´t get it to work, the same problem showing on the plugins list...
“The bundle “PluginTemplate” couldn’t be loaded.
dlopen(/Library/Application Support/OsiriX/Plugins/UMMPerfusion.osirixplugin/Contents/MacOS/UMMPerfusion, 0x0109): symbol not found in flat namespace '_GRAxesDrawXLabels' ”
Can you help me out again? Should I open another issue fot that?


Perf 1: remove pagination from meta. reselect channel counting

[x] cache expensive mapStateToProps
[x] move paginationKey out of metaMap. use it as a bool and simplify some logic

@keybase/react-hackers
cc: @mmaxim @cjb (https://github.com/keybase/client/pull/11864)

Let's discuss. It's not a recent regression
On Wed, May 30, 2018 at 6:26 PM Mike Maxim<EMAIL_ADDRESS>wrote:

I'm going to try and come up with repro instructions tonight, but I wonder
if we should think about a follow up release to fix, it would be kind of a
bummer to have this in play for another two weeks. The bad state of the
thread view is only really fixed by force killing the app.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/12037#issuecomment-393339688, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfhU8thusT__Nx3HJs8eQmIM4JhkHQzks5t3xx5gaJpZM4UM_S_
.

Yeah I'm not sure recency really matters here, I think the severity is pretty high. I'll get instructions on how to do it tonight. FWIW, I just had this happen to me in #core, where I would scroll up and just kind of see some random stuff.

Here is how you can repro (you need two accounts, A and B), I'll try with this patch next to see if it fixes it:
1.) On account A create a new channel (it makes it easier to see).
2.) Log into mobile on account A.
3.) On account B do this: for i in {1..20}; do keybase chat send --channel miketime mikemegateam $i; done
4.) Now background the mobile app for A.
5.) On account B do: for i in {21..50}; do keybase chat send --channel miketime mikemegateam $i; done
6.) Foreground the app (make sure you don't foreground into the channel you are sending into, just foreground into the inbox).
7.) On account B do: for i in {51..80}; do keybase chat send --channel miketime mikemegateam $i; done
8.) Now click into the thread on account A on the phone. You will see messages 80 to 50, then a gap all the way down to 20.

Seems to fix it, I am running this branch (with master merged in) on my phone now and will just keep it on until I get in tomorrow to test it out.

If we hotfix it'll be a cherrypick. Need to ensure kbfs is good too
On Wed, May 30, 2018 at 9:30 PM Mike Maxim<EMAIL_ADDRESS>wrote:

Seems to fix it, I am running this branch (with master merged in) on my
phone now and will just keep it on until I get in tomorrow to test it out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/12037#issuecomment-393372832, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfhU7yjnbDqyk3tZA8v-V8S6J0kh7Evks5t30fCgaJpZM4UM_S_
.


MacOS: cannot execute binary file

I am running with my 2015 Macbook pro with OSX 10.13.6. As soon as I launch the game, I see the terminal reports "cannot execute binary file" and the program is terminated. I suspect there is an issue with Intel Macbook.

Thanks for the response. We are very sorry for the inconvinence. The Final Build Out release should work now.


Convert docstring examples to jldoctests.

I would like to convert all of the current documentation string examples into jldoctests. This seems to be a really efficient way to incorporate testing into the package while also making the documentation better (a win-win!).
I would love to get help with this.
Please reply to this issue if interested to work on this, and I will "assign" it to you to prevent redundant work.

I can handle this.

I wouldn't remove it entirely personally - see here: https://documenter.juliadocs.org/stable/man/doctests/index.html#Doctesting-as-Part-of-Testing - the current runtests.jl file can be replaced with a call to doctests(Tidier). This would make it easy to automate the running of the doctests and also allow future unit tests that don't belong in the documentation to be added

Thank you @rdboyes. Would you be willing to review the PR when it is ready for merging?
If not, all good! Just wanted to ask.

Resolved by PR #25.


Fix straightforward build warnings

Goal
Fix some easy to fix build warnings so the compiler doesn't yell at me.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1257  👈
#1256
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Aug 15, 1:26 PM EDT: @bidetofevil merged this pull request with Graphite.


PHOENIX-6934 Drop Phoenix-Pig connector

Which file do you mean @richardantal  ?
README.md doesn't mention pig.

Which file do you mean @richardantal ? README.md doesn't mention pig.

found it.


[Fix] Make sidecar image template more standard

Make the sidecar image templating match that of the grafana image templating in
this Chart (and most other charts)
Signed-off-by: Andrew Caird<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR makes the templating of the grafana sidecar image match the format for Helm Charts, including that grafana image templating in this Chart.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Variables are documented in the README.md

@arbor-acaird please bump the chart version

Thanks @cpanato !
Just the minor version number?  So going from version: 2.3.1 to version: 2.3.2?

/assign
/ok-to-test
as this is a breaking change, lets bump the major version please.

@arbor-acaird update your pr and fix the conflicts


Support deserializing from mixed slices

When trying to parse fido2 (ctap2) responses from token,
slices are packed together, cbor encoded data may be followed
by other type of data.
This patch introduces a new from_slice_stream method that would
return the rest of the buffer instead of raising an error.

from_slice_stream does not sound right, but I couldn't come up with a better name. Let me know if you have one.

As an alternative we could expose the current byte offset of Deserializer<SliceRead>, similar to
https://docs.rs/serde_json/1.0.39/serde_json/de/struct.StreamDeserializer.html#method.byte_offset

That could work too, but we shouldn't throw an error I think.

Which error are you referring to? Serde_json's byte_offset() does not return error.

    use serde_cbor::{from_slice, from_slice_stream};
    #[test]
    fn parse_reader_slice() {
        let v: Vec<u8> = vec![0x66, 0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72, 0x66, 0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72];
        let value = from_slice(&v[..]);
        let value: String = value.unwrap();
        assert_eq!(value, "foobar");
    }

    #[test]
    fn parse_reader() {
        let v: Vec<u8> = vec![0x66, 0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72, 0x66, 0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72];
        let (rest, value): (&[u8], String) = from_slice_stream(&v[..]).unwrap();
        assert_eq!(value, "foobar");
        assert_eq!(rest, &[0x66, 0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72]);
        let (rest, value): (&[u8], String) = from_slice_stream(rest).unwrap();
        assert_eq!(value, "foobar");
        assert_eq!(rest, &[]);
    }

from_slice in the first example would return:
Err(ErrorImpl { code: TrailingData, offset: 8 })

Altough the error contains the offset, and I could workaround this, I still thinks returning the rest of the slice is more natural.

If you are suggesting that from_slice be changed to silently ignore trailing garbage, I don't agree with that. The caller would write (untested):
let mut deserializer = serde_cbor::Deserializer::from_slice(slice);
let value = T::deserialize(&mut deserializer)?;
let rest = &slice[deserializer.byte_offset()..];

V2 in #101


[cpe_nomad] Changing launchd use cpe_launchd

What type of PR is this?

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
In diff D20153983 you back out a change and shifted cpe_nomad to use cpe_launchd (away from fb_launchd), but in your configure_launchd you still use fb_launchd.
Which issue(s) this PR fixes:

Fixes #238
Special notes for your reviewer:
Successfully tested this change in our internal chef environment.
Relevant Chef code
Recipe: cpe_launchd::default
  * cpe_launchd[Managing all of launchd] action run
  Recipe: <Dynamically Defined Resource>
    * launchd[com.docusignhq.com.nomad] action enable
      * file[/Library/LaunchAgents/com.docusignhq.com.nomad.plist] action create
        - create new file /Library/LaunchAgents/com.docusignhq.com.nomad.plist
        - update content in file /Library/LaunchAgents/com.docusignhq.com.nomad.plist from none to 9f1db3
        --- /Library/LaunchAgents/com.docusignhq.com.nomad.plist	2020-03-17 21:19:24.049884268 -0700
        +++ /Library/LaunchAgents/.chef-com20200317-12108-xauvqq.docusignhq.com.nomad.plist	2020-03-17 21:19:24.049359867 -0700
        @@ -1 +1,19 @@
        +<?xml version="1.0" encoding="UTF-8"?>
        +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
        +<plist version="1.0">
        +<dict>
        +	<key>KeepAlive</key>
        +	<true/>
        +	<key>Label</key>
        +	<string>com.docusignhq.com.nomad</string>
        +	<key>LimitLoadToSessionType</key>
        +	<string>Aqua</string>
        +	<key>ProgramArguments</key>
        +	<array>
        +		<string>/Applications/NoMAD.app/Contents/MacOS/NoMAD</string>
        +	</array>
        +	<key>RunAtLoad</key>
        +	<true/>
        +</dict>
        +</plist>
      * macosx_service[com.docusignhq.com.nomad] action restart
        - restart service macosx_service[com.docusignhq.com.nomad]

     (up to date)
Recipe: cpe_launchd::default
  * cpe_launchd[Cleaning up un-needed launch daemons] action clean_up
  Recipe: <Dynamically Defined Resource>
    * launchd[nomad] action delete
      * file[/Library/LaunchAgents/nomad.plist] action delete (up to date)
       (up to date)
     (up to date)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., Design Proposals, usage docs, etc.:

I'm sorry, this is my fault for not checking. This is intentional. Eventually, we're going to change all of them over. I changed this manually as a 'first pass' - the one we reverted was broken, but these are effective, and this will be the correct way forward in the future.


Add support email address to login theme's error message

This PR adds an extra line to the error section of the login theme.  I tried to make the message generic enough to apply to any type of account-related error (login, registration, password reset, etc.).  The value is set via a new SUPPORT_EMAIL envvar set at Keycloak container startup.
This PR also moves all custom error message from the Java class to a messages_en.properties file.  This follows the pattern Keycloak follows for its own error messages, and can be use to override existing Keycloak messages.
Closes #33

In addition, here's where all of the error messages come from:

https://github.com/keycloak/keycloak/blob/master/themes/src/main/resources/theme/base/account/messages/messages_en.properties#L104-L152

We can override any of these in the messages_en.properties file added as part of this PR.  Let me know if you'd like any of them tweaked to better align with our error messages.  I've also created #39 to do a full review of Keycloak error messages.

OK, I think we're in good shape here.  I've rolled back to using a mailto: for rendering the email address.  It now looks like:

If you follow the link, it populates both the to and the subject, like such:

We could include something in the body without too much effort.  I'm guessing that'll require a bit of debate though.  If we do want that, I think it should be a separate issue.

Let's hold off merging until I have a companion PR for the Compose setup.

https://github.com/cfpb/hmda-platform/pull/739 is up now for adding SUPPORT_EMAIL to docker-compose.yml.  It should be merged whenever this one is.


Support Go Modules

Please consider adding a go.mod file and a semver compatible tag (eg. v0.0.1 or v1.0.0) so that other libraries pinning to this module can do so by version and not by commit SHA.
Thank you for your consideration.
EDIT: I've also taken the liberty of bumping Travis to a version of Go that's supported by the Go team. However, if you support unmaintained versions of Go as well feel free to yell at me and I can drop that part of the change. Adding the go.mod file won't affect anything that old.

ping @bsphere PTAL


Assert look likes doesn't work

I've defined a basic case to start working with Assert in CodeceptJS:
var assert = require('assert');
assert.equal('true', 'false');

Assert looks like doesn't work. The test consists code above was passed without alert relating to Fail Assert. Please help me via the case.
Thanks,

@anhvuong123 To my knowledge, Codecept doesn't ship with an assertion library, the examples use Node's assert.
Also your example works as expected for me in the Node REPL:
λ> node
> const assert = require('assert')
undefined
> assert.equal('true', 'false')
AssertionError [ERR_ASSERTION]: 'true' == 'false'
    at repl:1:8
    at ContextifyScript.Script.runInThisContext (vm.js:50:33)
    at REPLServer.defaultEval (repl.js:240:29)
    at bound (domain.js:301:14)
    at REPLServer.runBound [as eval] (domain.js:314:12)
    at REPLServer.onLine (repl.js:441:10)
    at emitOne (events.js:120:20)
    at REPLServer.emit (events.js:210:7)
    at REPLServer.Interface._onLine (readline.js:282:10)
    at REPLServer.Interface._line (readline.js:631:8)
> assert.equal('true', 'true')
undefined
>

Are you sure the tests are running? Could you provide more sample code?

The fix for this landed in v1.1.5.


ARROW-8222: [C++] Use bcp to make a slim boost for bundled build

This patch switches our bundled boost ep to use a slimmer version of boost, which was built with the script added at cpp/build_support/trim-boost.sh. It uses the official boostorg big tarball as a fallback URL if for some reason ours is unavailable (as we've seen with other ep's, sometimes the download hosts are subject to rate limiting or other downtime, so having redundancy would more generally be good).
The resulting tarball is 10mb, much less than 113mb of the full boost but larger than the 800k I suggested in the ticket. This is because in order to build regex and filesystem, we need config build boost_install headers, which add some weight. Boost.Build also seems to require log, and predef is needed by log apparently.
In addition to slimming the boost tarball, this patch also refines the cmake logic that determines when boost is required. Due to recent-ish efforts to reduce usage of boost, we only need boost for tests and Gandiva, and for Parquet but only on gcc < 4.9. When building thrift_ep, we also need boost. By narrowing the condition involving Parquet to just gcc < 4.9, we are able to remove boost entirely from the R macOS and Windows packages.
Outstanding questions/to-dos that I'm aware of:

[x] Put the boost bundle somewhere official. I plan to put it at https://dl.bintray.com/ursalabs/arrow-boost/ but am open to suggestion if someone has a better idea.
[x] Add a crossbow job to build the boost bundle: to update the boost version or change what's included in the bundle, edit cpp/build_support/trim-boost.sh and run an on-demand build via PR comment. On further reflection, crossbow isn't appropriate because it would mean that anyone could edit the script and overwrite the bundle that gets pulled into all source builds. Instead, I added a script that one can run locally, just requiring a bintray user and token in the ursalabs organization (available to any committer on request).
[ ] Something with namespacing? I'm not sure how much of a concern this is since Arrow itself doesn't really require boost anymore.

Hmm, thrift appears to need more of boost. Will see if I can figure out what it needs and add that.

Looks like Gandiva may require a little more, and grepping through the files, some tests import other boost headers (which we may by chance already have included, IDK). I'll explore some more tomorrow (unless someone comments here why this is a bad idea); fallback could be to change which URL to download boost from depending on which cmake args are set (i.e. if gandiva is being built, and/or if tests are being built, get the full boost).

@github-actions crossbow submit macos-r-autobrew

After poking at this some more, I haven't been able to pare back the heavier components at all. Whether for regex or locale, we need boost.build to build them, and that seems to require the bigger pieces, including log. Even so, we've reduced the size of the tarball and the expanded package by an order of magnitude, so it should be a noticeable improvement.
I'll work on the crossbow job for updating this bundle and then consider this done, pending review/approval. Will also want to run the all the nightlies against this.

I'm going to need some help again with cmake-format (when I run it locally it rewrites the entire file) but otherwise I think this is about ready to go, pending final review/approval.

@github-actions crossbow submit -g r

$ python3 -m pip install -r dev/archery/requirements-lint.txt
$ python3 run-cmake-format.py

will work.

I don't understand the Ruby failure, or at least don't see how it's related: https://github.com/apache/arrow/pull/6734/checks?check_run_id=543791775#step:6:1181

Oh, Meson 0.54.0 released today and it requires Ninja 1.7 or later https://mesonbuild.com/Release-notes-for-0-54-0.html#ninja-version-requirement-bumped-to-17 but Ubuntu 16.04 ships Ninja 1.5.1.
I'll take over this.

#6756

@github-actions crossbow submit -g r

@github-actions crossbow submit -g r

Okay, now this is done IMO, for real this time. Review appreciated. Note that this will also fix the widespread failures on master due to whatever is up with bintray.com/boostorg.

Merging this. Thanks @nealrichardson for leading the charge on this


Error: Input string was not in a correct format.

Hello
I running docker-compose-noproxy.yml, but when I enter to the host:
400 That's an error.
Sorry, an error occurred. The team is already working on that.
Error: Input string was not in a correct format.

What the problem? and how can I fixing it?

Where do you have this log from?

Do you see an exception with docker logs?

Fixed in 1.2.1


angular-oauth2-oidc in context of Angular-SPA->ASP.NET Core WebAPI (single domain)

We are in the process of migrating our product from integrated Win auth to federated auth. It consists of an Angular-SPA that accesses an ASP.NET Core WebAPI. Both components are running in the same domain.
In this context I'm wondering if angular-oauth2-oidc is really needed (and thus doing authentication on the client level) or if it's OK to do cookie based OIDC authentication in the WebAPI (via AddOpenIdConnect).
I had following thoughts. Are these correct?

OIDC-based Cookie authentication on the WebAPI level should work when talking about a single domain (like it does for MVC).
Using this library and doing authentication on the client level is the more OIDC-like/sophisticated approach. This has several advantages that might be relevant in the future (cross-domain-ability, more app-friendly, token-refreshing, identity-information in the SPA without involving the WebAPI, ...)

Thanks!

It's a broad, architectural question, so the answer will in the end always be: it depends...
But from your description, it sounds like you might have a "BFF" (Backend For Frontend) setup. Then you can for sure use just server side cookies, and you will likely reduce the attack surface of your app over bearer authorization.
PS. This question is not specific to the library you're reporting an issue at, but more a general thing around SPA's and Bearer Auth vs using session cookies.

OK, thanks!


migration to typescript or es6

not possible work with typescript of es6 because it have a poor meta.


Linking entities to underlying spans

So far, EntityLinker only allows access to the document-level or sentence-level EntityCollections.
For me, a particularly useful pattern is direct access through arbitrary underlying Spans.
Span-level attributes are already possible in the library (thanks to the sentence-level support, because sentences in spacy are also just represented as a Span). This PR simply adds the individual EntityElement to its associated span.
Example usage:
text = ""
nlp = spacy.load("en_core_web_sm")
nlp.add_pipe("entityLinker", last=True)
doc = nlp(text)

# Previously simply returned "None"
print(doc[2:4]._.linkedEntities)  # <EntityElement: ...>

This is also useful for mappings over entities extracted with spacy, as described in #18.
One minor nitpick of my own change: Now, ._.linkedEntities no longer returns a consistent type (previously always returned an EntityCollection, now also returns EntityElement in cases of spans.
Again, happy to discuss the necessity of this change for the library first :)
Best,
Dennis

Hi @dennlinger,
Yes, this is much needed in this library! I will double-check and then merge. It is really useful!
Martino


IYO Backup/Registration to Tierion using IYO Registrar

dump full content of IYO

can we export mongodb readable?
compress

file get's uploaded to at least 2 IYO registrars

see https://github.com/itsyouonline/identityserver/blob/master/specs/iyo_registrar.md

needs https://github.com/itsyouonline/ssh_registrar/issues/1

Mongo can be exported as a json directory using the command line mongodump tool, every collection gets written to its own. json file. We can then compress the new directory.


Add MPL-2.0 copyright template

Suggested in policy 4.0.0
12.5
The Mozilla Public License 1.1 and 2.0 (MPL-1.1 and MPL-2.0) are
now included in /usr/share/common-licenses and do not need to be
copied verbatim in the package copyright file.
Signed-off-by: Shengjing Zhu<EMAIL_ADDRESS>

Thanks!


Need help reading error given when installing Excel Plug in

Description
I just installed Dbeaver on a new laptop.    My connections and scripts are all set and working.   I have Eclipse installed.   When I try to install the Excel Plug in I'm getting "Cannot complete the install because some dependencies are not satisfiable"     Any thoughts what I am missing?
I'm putting this in the Work With and clicking on the Office Support tab
DBeaver - Office support - https://dbeaver.io/update/office/latest/
Message given:
Cannot complete the install because some dependencies are not satisfiable
Software being installed: a.jre.javase 18.0.0
Software being installed: DBeaver Office Support <IP_ADDRESS>405191503 (org.jkiss.dbeaver.ext.office.feature.feature.group <IP_ADDRESS>405191503)
Cannot satisfy dependency:
From: DBeaver Office Support <IP_ADDRESS>405191503 (org.jkiss.dbeaver.data.office <IP_ADDRESS>405191503)
To: osgi.ee; (&(osgi.ee=JavaSE)(version=17))
Cannot satisfy dependency:
From: DBeaver Office Support <IP_ADDRESS>405191503 (org.jkiss.dbeaver.ext.office.feature.feature.group <IP_ADDRESS>405191503)
To: org.eclipse.equinox.p2.iu; org.jkiss.dbeaver.data.office [<IP_ADDRESS>405191503,<IP_ADDRESS>405191503]
DBeaver Version
Version <IP_ADDRESS>210092258
Operating System
Windows 11
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Please try latest DBeaver version

I had tried upgrading DBeaver prior to opening this ticket.    When upgrading, I did not elect to create a new desktop icon and thought the old icon would now point to the upgraded DBeaver.   I upgraded again but did create a new (second) desktop icon.  I was now able to apply the office update to the recent version of DBeaver.   I didnt account for the fact I can have 2 active versions of DBeaver loaded.


[WIP] Implement authorize callback for handshakes

Very WIP.
Ideally, we could make authorization simple and just do it all in the handshake. I suspect the way this PR does it is not nearly enough though. Likely the server's authorize callback will need async support, and I suspect clients will need a way to handle their authorization automatically, probably through a callback that gets them their authorization details whenever they want.
Tons of open questions here:

how should we handle transparent reconnects? are you allowed to reuse your authorization?
how do we prevent someone reading pid2 memory and spoofing another client via their authorization (which may be in memory)? is this even a concern?
should we allow some (or even all) messages to be signed, especially ones which may cause destructive actions? also, again, is this even a concern?
what's the best way to expose sessions and their details to procedures?
how do we add metadata to this, so that we can attach information like username and user id?
do we need middleware so that we can gate procedures based on permissions/role? are we ever going to need a permissions system?

Other comments:

seems like tRPC recommends authorizing via middleware or in resolvers

i do think that some sort of middleware system will be useful at some point (esp as we think about adding tracing too)
procedures can already access session via ctx.session i would imagine we could put custom handshake info there too
i wonder if theres a way we can include the handshake info as a typebox type and have the protocol be parametric over the handshake info
hm about security, we probably wouldn't need to store incoming authorization right? auth should probably be done per session (basically anytime we handshake)


"No collectables available" is displayed while the list is in the process of the loading

Title/Description
"No collectables available" is displayed while the list is in the process of the loading
Environment

Browser: chrome
Safe: 0x4dEBDD6CEe25b2F931D2FE265D70e1a533B02453
Wallet: MM
App Version: 3.3.0
Environment:

PR # https://pr2079--safereact.review.gnosisdev.com/mainnet/app/#/safes/0x4dEBDD6CEe25b2F931D2FE265D70e1a533B02453/balances

Steps to reproduce

Load safe = 0x4dEBDD6CEe25b2F931D2FE265D70e1a533B02453 on mainnet
Open collectables
Wait for more than half of the min before the list of collactables is loaded
Current result It's really confusing to see "No available collectibles" when you know that the safe contains a lot of ERC721 tokens

Expected result
The user should see that the list is in the process of loading
Screenshots

I think this is expected behavior, currently, unfortunately. We have #1868. I would tackle this issue properly there.


Error -DENABLE_NUMA=On

Describe the bug
Hello I am trying to install Umpire with Numa Option but I am receiving the error below. If i do it without that option it Works! Do you have an idea?
To Reproduce
cmake .. -DCMAKE_INSTALL_PREFIX=/home/arubio/Umpire -DENABLE_CUDA=On -DENABLE_NUMA=On -DENABLE_STATISTICS=Off -DENABLE_GMOCK=On -DENABLE_TESTS=Off -DENABLE_OPENMP=On -DENABLE_WARNINGS_AS_ERRORS=On -DENABLE_C=On -DENABLE_BENCHMARKS=On -DENABLE_TOOLS=On
make
Error
.
.
.
[ 13%] Building CXX object src/umpire/strategy/CMakeFiles/umpire_strategy.dir/MonotonicAllocationStrategy.cpp.o
[ 13%] Building CXX object src/umpire/strategy/CMakeFiles/umpire_strategy.dir/SlotPool.cpp.o
[ 14%] Building CXX object src/umpire/strategy/CMakeFiles/umpire_strategy.dir/SizeLimiter.cpp.o
[ 14%] Building CXX object src/umpire/strategy/CMakeFiles/umpire_strategy.dir/ThreadSafeAllocator.cpp.o
[ 15%] Building CXX object src/umpire/strategy/CMakeFiles/umpire_strategy.dir/NumaPolicy.cpp.o
In file included from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.cpp:7:0:
/home/arubio/Umpire/src/umpire/strategy/NumaPolicy.hpp:40:10: erreur: conflicting return type specified for ‘virtual long int umpire::strategy::NumaPolicy::getCurrentSize() const’
long getCurrentSize() const noexcept;
^
In file included from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.hpp:12:0,
from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.cpp:7:
/home/arubio/Umpire/src/umpire/strategy/AllocationStrategy.hpp:69:25: erreur:   overriding ‘virtual std::size_t umpire::strategy::AllocationStrategy::getCurrentSize() const’
virtual std::size_t getCurrentSize() const noexcept = 0;
^
In file included from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.cpp:7:0:
/home/arubio/Umpire/src/umpire/strategy/NumaPolicy.hpp:41:10: erreur: conflicting return type specified for ‘virtual long int umpire::strategy::NumaPolicy::getHighWatermark() const’
long getHighWatermark() const noexcept;
^
In file included from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.hpp:12:0,
from /home/arubio/Umpire/src/umpire/strategy/NumaPolicy.cpp:7:
/home/arubio/Umpire/src/umpire/strategy/AllocationStrategy.hpp:77:25: erreur:   overriding ‘virtual std::size_t umpire::strategy::AllocationStrategy::getHighWatermark() const’
virtual std::size_t getHighWatermark() const noexcept = 0;
^
make[2]: *** [src/umpire/strategy/CMakeFiles/umpire_strategy.dir/NumaPolicy.cpp.o] Erreur 1
make[1]: *** [src/umpire/strategy/CMakeFiles/umpire_strategy.dir/all] Erreur 2
make: *** [all] Erreur 2

Thank you for bringing this to our attention! Our CI testing framework does not current test builds with with ENABLE_NUMA=ON. We recently made a switch in interface, and these function signatures are out of date.

Please see #171 - let us know if that works for you @andresrubiop

Oh Great! it works.
Thanks

Awesome! Please let us know if you have any other issues or questions.


Feacture/data grid implementation in task section

What's new
Adding Datagrid instead of TaskTable component in TaskApp.

Order by column (asc, desc)

Filtering by Start time column

Self-checks

[ ] I have prototyped this new feature (if necessary) on Figma
[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

I close this PR and I will create another one to make it cleaner


CASMINST-6502: Minor typos

Description

Fixing a couple of minor typos for CASMINST-6502.
Relates to:
Checklist

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport /release/1.4

/backport release/1.4


cert-manager sync-wave clean fix for PR

ArgoCD Application "cert-manager-instance" failing to sync #111
@hollisc

LGTM


Header strange behavior

Hello together,
currently I am working on a new project in RN and tried React Navigation.
Everything worked fine until I saw this

So on my main screen the top bar looks great, then I use a button to go to the next screen, but then the screen name appears under the clock of iOS.
const SimpleApp = StackNavigator({
  Home: { screen: CodeSharing },
  Submit: { screen: Submit },
},
  {
    navigationOptions: {
      header: null,
    },
    headerMode: 'none'
  }
);

Any Ideas or suggestion how to fix this?
Cheers
Alex

I have the same issue too
My back button and title is not in the right position

You guys probably want to offset the "status bar" height which can be found in Expo.Constants.statusBarHeight

I would like to delete the screen name completly. How could I do this
Am 29.06.2017 um 15:48 schrieb Scott Mitchell:

You guys probably want to offset the "status bar" height which can be
found in |Expo.Constants.statusBarHeight|
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-navigation/issues/1985#issuecomment-311971952,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APKIuawDrJpwqfz8TB2Kze7vFuNcLlV_ks5sI6tFgaJpZM4OFNxe.

@alexanderniebuhr Make sure your navigationOptions title is empty or undefined perhaps? I think adding headerMode: 'none' would also do the trick already. I'm doing the exact same thing.

I created a simple wrapping component Screen to handle this consistently across my screens.
import React from 'react';
import { StyleSheet, View } from 'react-native';
import { Constants } from 'expo';
import theme from '../theme';

/*
* Screen Component
*
* Simple top-level layout component that provides a full height / width / columnized
* `View` w/ an offset for the top status bar
*/

const styles = StyleSheet.create({
  container: {
    ...theme.layout.container,
    alignItems: 'center',
    justifyContent: 'space-around'
  },
  statusBar__offset: {
    paddingTop: Constants.statusBarHeight
  }
});

const Screen = ({ style = {}, children }) => (
  <View style={ StyleSheet.flatten([styles.container, style]) }>
    { /* Add top padding to offset status bar */ }
    <View style={ styles.statusBar__offset }></View>
    { children }
  </View>
);

export default Screen;

Used like...
<Screen><Text>Put stuff in here</Text></Screen>

@smitch88 as u see in my first post, i did add headerMode: 'none' didnt I?

I see. I also use this and also avoid setting the title in my screens...
// https://reactnavigation.org/docs/navigators/stack#StackNavigatorConfig
const stackConfigurationOptions = {
  // Headers on screens will be created manually
  headerMode: 'none'
};

export default StackNavigator(routingConfiguration, stackConfigurationOptions);

Seems to work perfectly fine? Not sure...maybe you are adding it in the component side as a static prop?

So u add the headerMode prop to every single screen js file?

no its just on the single StackNavigator instance just like you have...I dont see titles.

well that is the point, i dont want title. I want the navigation in the background of my application ... the user should not see any title bar or information except the ones i add later on the view

Right and I don't see any title bar or anything by setting headerMode: 'none'. Not sure what your own app issue is.

The only prop my app is the little bug seen on the screenshot in the first post

Right so you need to add the paddingTop for the statusBar and you will be fine. Good luck have some work to do now 👍

thx ... dont thing padding is the best way to solve. but a beginning

Well its the recommended way of solving from Expo themselves. It's in the docs. But yeah it would be nice if by default expo exposed a layout component that just applied it.

Not able to reproduce on the beta.11 using given code

{
GirisEk: { screen: Giris },
AnaRouterEk: {
screen: AnaRoutergit},
},
{
navigationOptions: {
header: null,
},
headerMode: 'none'
}


duplicate rapid test registration - lost the test

I registered my test. (picture one)
I scanned the qr code with cwa app successfully. I had two test. the new rapid test and an old pcr test.
no result for 18 minutes ;)

Later i got a sms. you can see the result in cwa click the link (picture two)
I followed the link. I got the message test already registered.... i lost the test registration from the rapid test.
Only the old pcr test is still present.

Should it work in this way ? Of course the test registration should only possible on one device, one time... but why it killed the old one with same id. It should not kill the same test registration. I heard from friend that it doesn't work for him. The result was uninstall the cwa app....
It's not the best behavior.

Internal Tracking ID: EXPOSUREAPP-7447

Thank you for reporting this!
Just that we all get you right, you scanned a QR-Code linked to a PCR test, afterwards you scanned a QR-Code linked to a rapid test. Then you got a SMS which contained the link to register the rapid test result which you'd already added to the Corona-Warn-App when you scanned the QR-Code.
You clicked on the link in the SMS, the Corona-Warn-App opened, you stepped through the screens in CWA, you did see the screen "Hinweis - Sie haben bereits einen Schnelltest registriert", clicked on "Weiter" and did get the pop up "QR-Code ist ungültig". You clicked on "Abbrechen" and the quick test was removed and only the PCR test was left?

@Armin83 Thanks for your report.
Basically, as @Ein-Tim already asked:
I understand form your report that your rapid antigen test (RAT) disappeared.
First you scanned RAT QR code, then you received as some point SMS where you pressed the link and with this the RAT was deleted. Please, confirm. I can confirm this behaviour on Android. iOS will not delete the test. Developers are informed about this issue.
Internal Tracking ID: EXPOSUREAPP-7447

Corona-Warn-App Open Source Team

@Armin83 Another question: The link in your screenshot  (https://cov19.codes/cwa) opened directly the CWA or did it open another page and there was another link or a QR code? Thanks for your feedback.

@dsarkar
The link directly open the cwa app. (I click on the link, browser opens, automatically redirect to cwa app.)

I understand form your report that your rapid antigen test (RAT) disappeared.
First you scanned RAT QR code, then you received as some point SMS where you pressed the link and with this the RAT was deleted.

Yes, that's exactly what happened

@Armin83
A fix is planned for the next release CWA 2.4.

Corona-Warn-App Open Source Team

FYI Problem is fixed with #3439

Fixed with 2.4.x, should this still be an issue just re-open the ticket.


Fixed compatibility issues with OpenCV v3.2.0

GenericDescriptorMatcher is renamed to DescriptorMatcher
FOURCC macro is deprecated, using VideoWriter::fourcc static function

Merge looks good, but I haven't been actively developing this for a while so in the near future I'll try and build it on my new machine, which might require a few more changes.


Removed duplicate language

Removed duplicate phrase in the "Downtime requirements" section.

@stefanflegg : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stefanflegg - thanks!


How do I add custom options

Hi I'm trying to add new options in plyr's settings menu  , the place were  we find speed and caption
does plyr support this if so how do I do this

I tried it doing here ```html

Custom 1  Video Player

```

but it doesen't work


[Bug]

Version
last
Steps to Reproduce
after applyMoreData can i resize ?

i need this:

how i can do this?
Current Behavior
dont resize (((
Expected Behavior
resize
Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

temporary solution: setBarSpace(13)


can't find the repository

Hello,
I would be very interested in using this integration but seem to be unable to find/install it.
I'm a complete newbie to home assistant.
So far got it running (installed it via VirtualBox on an old Mac - OS version 6.4, Core 2021.9.7) and was able to install HACS.
I can not find this repository though, would someone be so kind to help me out?
I've been looking for it in HACS > Integrations > + Explore & add repositories, am I even in the right place?

Any help would be highly appreciated.

Also worth noting this integration isn't working right now


Modifyworld.* doesn't seem to work

Here's my permissions file:
https://pastebin.com/uur5m8tb
Basics permissions work fine but - -modifyworld.* doesn't work. Default users still can destroy/place blocks etc.

I am pretty sure that was disabled in a previous version.
Anyway You might be able to find a plugin that does what you want for your?
If you can't it wont be too hard to make. Contact me I will make it for your for free.

@Wherkamp please stop.
Anyway you need a plugin called ModifyWorld. It was in pex but was removed into there own plugin.

Unfortunately PermissionsEx is currently unmaintained and no further updates are planned. Because of this, all issues are being closed. If you are looking for an actively maintained permissions plugin, take a look at LuckPerms. It is compatible with major server platforms and can import data from PEX.


Add to npm?

I am already using webpack for bundling pannellum. It would be nice of course if the translation files can also be loaded by webpack and then just passed to pannellum.
Publishing this on npm would be nice or at least adding a package.json.

Thats an excellent idea, will do!

Done! I hope everything is correct? Please let me know, I'll be glad to help. You can find the package here: https://www.npmjs.com/package/pannellum-translation

Also I added the package.json here on commit 0490208

For webpack (locale 'DE' in this example):
import pannellumTranslationDE from 'pannellum-translation/DE.json';


refactor: replace RuleType enum with a const (#539)

Summary
This PR resolves https://github.com/quantizor/markdown-to-jsx/issues/539 by replacing the RuleType enum with a const object.
Description
As mentioned & discussed in https://github.com/quantizor/markdown-to-jsx/issues/539, the current way of declaring the RuleType as an enum causes problems when using isolatedModules in tsconfig.json.
The solution, as described on the TypeScript website, is to simply replace the enum with a simple object const, and declare a type based on its keys & values. Additional updates were needed to correctly use types (and not values) in the various interfaces defined for node types.
This worked correctly, but there were still issues when running tests using Jest with the modifications made in index.tsx. Therefore, an additional change was made in index.cjs.tsx in order to export the RuleType explicitly (as is done with the compiler function).
Testing
Since the updated code is functionally equivalent to the existing version & all existing unit tests pass correctly, it was not clear what type of test could be added.

Hi @quantizor, just wanted to check if you would have time in the coming weeks to check out this PR, it would unblock some things on my end if this could be merged. Thanks in advance and have a nice summer!

Hey Roger! I will try to make time, thanks for the reminder. Lots going on personally at the moment.

Hi @quantizor, just wanted to check if you would have time in the coming weeks to check out this PR, it would unblock some things on my end if this could be merged. Thanks in advance and have a nice summer!

Hey Roger! I will try to make time, thanks for the reminder. Lots going on personally at the moment.

No worries, thank you for your answer and your help!

@quantizor hello, any plans in merging this? thanks

Thanks a lot @quantizor, I tested it now and it works perfectly with the new version!


Screen or popup to edit and delete events.

Is your feature request related to a problem? Please describe.
There is no way to see, edit, or delete events. This makes it difficult to tell what types of events exist.
Describe the solution you'd like
Add a screen or dialog that lists currently existing events and allows an admin to edit the age limits and group sizes for events and delete them.

I have been thinking more about editing events, and it might be easier only to allow users to delete and add events. When an event is edited, it could cause conflicts with currently existing appointments. If the age limit is raised, the groups currently assigned might be too young. Similarly, it is unclear what should happen if the maximum number of groups is lowered. For instance, what should the app do if groupMax is lowered to 4, and five groups are assigned to that event?
Deleting events also has conflicts, which can be resolved by deleting all appointments that use that event.
For now, I think we should only allow deleting and adding events and tackle editing later if we decide we want it. I would love to hear your thoughts on this @mgoadric.

Those are important concerns with editing events. I remember that moving events was an important goal for the client, because there could be rain, and outdoor events will need to be rescheduled. If this can be accomplished smoothly with only add and delete, then we can put edit aside for now.

Sorry for the unclear language. Appointments are the actual items scheduled on the calendar, and an Event is effectively a class of appointment. So an Event might be Swimming, and then the user can create an Appointment for swimming at X date and time.
Appointments can be rescheduled and edited easily. My concerns were that editing Events might cause conflicts with existing Appointments of that Event type.
We can talk more about it tomorrow morning.

Accidentally closed wrong issue


Automated cherry pick of #3621: fix: nic teaming/bonding not working properly

Cherry pick of #3621 on release/2.11.
#3621: fix: nic teaming/bonding not working properly

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@6fc1d3a). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.11   #3624   +/-   ##
==============================================
  Coverage                ?   7.12%
==============================================
  Files                   ?     477
  Lines                   ?   77690
  Branches                ?       0
==============================================
  Hits                    ?    5538
  Misses                  ?   71685
  Partials                ?     467

Flag
Coverage Δ

#aFlag
7.12% <0%> (?)

Impacted Files
Coverage Δ

pkg/util/netutils2/netutils.go
25% <0%> (ø)

pkg/hostman/guestfs/fsdriver/linux.go
0% <0%> (ø)

pkg/hostman/guestfs/fsdriver/nicteaming.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc1d3a...d92ad4e. Read the comment docs.

/lgtm
/approve


Opening A 2nd Menu Closes The 1st

Is your feature request related to a problem? Please describe.
When on the show all data screen using the dropdown menu at the end of one field to say export related records, even after clicking on export it won't close the menu. When selecting a different field it also doesn't hide the first field causing them to at times overlap
Describe the solution you'd like
have it hide after an option is clicked or another menu is selected
Describe alternatives you've considered
going to sleep

Hi @RebbePod ,
Your request seems to be a duplicate of this one #159.
As this one comes after, I'll close it but you can subscribe to the first one to check for updates.

Thank you, I actually looked to see if existed. :)
See my comment there


fix guidebook for Trade Station

Did the  thing wrong

About the PR
 Did an oopsy and had an extra space that shouldnt have been there
Why / Balance
It didnt work, now it should
Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

 no cl no fun

Extremely minor fix to my og pr, literally one change. Please merg

did you test that this works? what was even broken?

did you test that this works? what was even broken?

the only problem was that TradeStation.xml wasnt recognised as a document so wasnt listed in the guidebook because of an extra space.