When call vkDestroyInstance the launch app will crash

Description

When I use RenderDoc V1.25 to run Vulkan app, the app will crash, but if I independent execution the Vulkan app it will execute normally. then I try to find where is source of the error.
Steps to reproduce

The Vulkan app will run the code:
bool Turbo::Core::TInstance::IsSupportVulkan()
{
    std::cout << "0.0.0" << std::endl;

    TVulkanLoader::Instance();//it will call LoadLibraryA("vulkan-1.dll") and GetProcAddress(library, "vkGetInstanceProcAddr") to get vkGetInstanceProcAddr function

    std::cout << "0.0.1" << std::endl;

    VkApplicationInfo application_info = {};
    application_info.sType = VkStructureType::VK_STRUCTURE_TYPE_APPLICATION_INFO;
    application_info.pNext = nullptr;
    application_info.pApplicationName = nullptr;
    application_info.applicationVersion = 0;
    application_info.pEngineName = nullptr;
    application_info.engineVersion = 0;
    application_info.apiVersion = VK_MAKE_VERSION(1, 0, 0);

    VkInstanceCreateInfo vkinstance_create_info = {};
    vkinstance_create_info.sType = VkStructureType::VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO;
    vkinstance_create_info.pNext = nullptr;
    vkinstance_create_info.flags = 0;
    vkinstance_create_info.pApplicationInfo = &application_info;
    vkinstance_create_info.enabledLayerCount = 0;
    vkinstance_create_info.ppEnabledLayerNames = nullptr;
    vkinstance_create_info.enabledExtensionCount = 0;
    vkinstance_create_info.ppEnabledExtensionNames = nullptr;

    VkInstance instance = VK_NULL_HANDLE;

    VkAllocationCallbacks *allocation_call_back = TVulkanAllocator::Instance()->GetVkAllocationCallbacks();
    std::cout << "0.0.2" << std::endl;

    VkResult result = Turbo::Core::vkCreateInstance(&vkinstance_create_info, allocation_call_back, &instance);
    std::cout << "0.0.3" << std::endl;

    if (result == VkResult::VK_SUCCESS)
    {
        std::cout << "0.0.4" << std::endl;

        PFN_vkDestroyInstance pfn_vk_destroy_instance = TVulkanLoader::Instance()->LoadInstanceFunction<PFN_vkDestroyInstance>(instance, "vkDestroyInstance");//it will get vkDestroyInstance function

        std::cout << "0.0.5" << std::endl;

        if (pfn_vk_destroy_instance == nullptr)
        {
            std::cout << "pfn_vk_destroy_instance::nullptr" << std::endl;
        }
        else
        {
            std::cout << "pfn_vk_destroy_instance::not nullptr" << std::endl;
        }
        pfn_vk_destroy_instance(instance, allocation_call_back);
        std::cout << "0.0.6" << std::endl;

        return true;
    }
    std::cout << "0.0.7" << std::endl;

    return false;
}

If I independent execution the Vulkan app, the output will be:
0.0.0
0.0.1
0.0.2
0.0.3
0.0.4
0.0.5
pfn_vk_destroy_instance::not nullptr
0.0.6

If I run it in RenderDoc V1.25 by click Launch button , the output will be:
0.0.0
0.0.1
0.0.2
0.0.3
0.0.4
0.0.5
pfn_vk_destroy_instance::not nullptr

then the Vulkan app will crach when call pfn_vk_destroy_instance(...)
Environment

RenderDoc version: 1.25
Operating System: Windows
Graphics API: Vulkan

GPU: RTX1060
Driver Version,: 528.49

There must be something more here since it is obvious that almost universally every vulkan. I can trivially show that a vulkan program does not crash when destroying the instance.
Your reproduction case very significantly uses an allocation callback but does not provide any source for it. Trying with it set to NULL does not show any problems when I try to capture the program. Does this reproduce if you don't specify an allocation callback? Can you please provide a reproducible test case that is complete and can be used to reproduce the problem?
Please provide more information: Does this happen with a simple known program such as vkcube? Do you have any other software that may be injecting itself into graphical applications such a screen recording, overlay, statistics, etc? If you attach a debugger to your program can you see where it is crashing? Can you reproduce this on multiple systems or only on the one you have tested with?

The struct about TVulkanAllocator::Instance()->GetVkAllocationCallbacks()
graph LR;
GetVkAllocationCallbacks["GetVkAllocationCallbacks()"]

pUserData[".pUserData = nullptr"]
pfnAllocation[".pfnAllocation = &TVulkanAllocator::Allocate"]
pfnReallocation[".pfnReallocation = &TVulkanAllocator::Reallocate"]
pfnFree[".pfnFree = &TVulkanAllocator::Free"]
pfnInternalAllocation[" .pfnInternalAllocation = &TVulkanAllocator::InternalAllocationNotification"]
pfnInternalFree[".pfnInternalFree = &TVulkanAllocator::InternalFreeNotification"]

GetVkAllocationCallbacks-->pUserData
GetVkAllocationCallbacks-->pfnAllocation
GetVkAllocationCallbacks-->pfnReallocation
GetVkAllocationCallbacks-->pfnFree
GetVkAllocationCallbacks-->pfnInternalAllocation
GetVkAllocationCallbacks-->pfnInternalFree

TVulkanAllocator::Allocate["void *VKAPI_PTR Allocate(void *pUserData, size_t size, size_t alignment, VkSystemAllocationScope allocationScope)"]

TVulkanAllocator::Reallocate["void *VKAPI_PTR TVulkanAllocator::Reallocate(void *pUserData, void *pOriginal, size_t size, size_t alignment, VkSystemAllocationScope allocationScope)"]

TVulkanAllocator::Free["void VKAPI_PTR TVulkanAllocator::Free(void *pUserData, void *pMemory)"]

pfnAllocation-->TVulkanAllocator::Allocate
pfnReallocation-->TVulkanAllocator::Reallocate
pfnFree-->TVulkanAllocator::Free
pfnInternalAllocation-->Donoting_pfnInternalAllocation["do nothing"]
pfnInternalFree-->Donoting_pfnInternalFree["do nothing"]

TVulkanAllocator::Allocate-->TAllocator::Allocate["return _aligned_malloc(size, alignment);"]
TVulkanAllocator::Reallocate-->TAllocator::Reallocate["return _aligned_realloc(pOriginal, size, alignment);"]
TVulkanAllocator::Free-->TAllocator::Free["return _aligned_free(pMemory);"]

I had tested for what you suggested, it worked in RenderDoc if I just return nullptr when call TVulkanAllocator::Instance()->GetVkAllocationCallbacks(). I am very thanks for you, I had show what the VkAllocationCallbacks struct will be in my project, please check it, thanks! thanks! thanks!
(●'◡'●)

I'm not sure I quite understand what you're saying. You mean that if you don't pass the allocation callbacks then it works? If so that suggests it might be a bug in your callbacks, I'd suggest attaching a debugger and seeing where the crash happens exactly.
It might mean there's a bug in RenderDoc with handling of allocation callbacks, since they are basically never used as they are more-or-less pointless. For me to test that you need to actually give me a sample I can run as I asked above, either as source or binary - I do not understand what that graph means but it's not code that I can compile.

Ok, the project Turbo is open source

I can't reproduce this with the executable provided. I tested on three different GPUs, from NV/AMD/Intel but none of them crashed when run from RenderDoc v1.25. I'm not sure exactly when it's mean to crash, but I was able to launch the program and then close it with no problems.
Have you tried updating to the latest drivers to see if that fixes your issue? are you able to reproduce this on any other system than your own? Is it possible that your executable behaves differently on other PCs? If you're able to produce a simple and deterministic sample I can test again, or if I can provide any information about the running to ensure it has actually hit the same case that you are seeing.

Yes, you are right. After I updated my GPU driver into latest driver from 528.49 to 531.18. It fixed my issue and very thanks for your kindness help.  (๑•̀ㅂ•́)و✧
And I will close this issue, and thanks you again.（○｀ 3′○）


Extend frsky smartport telemetry with apm compatible flightmode (TEMP…

…1) and gps satcount/fixstate (TEMP2)

Nice! Is this for a particular OpenTX version?

It should work with all OpenTX versions that support smartport (X-Receicer) telemetry. The generated data (TEMP1 and TEMP2) is compatible to APM version >= 3.2.1 (guessed, cant remember exactly) and is handled best with a telemetry script. See http://fpv-treff.de/viewtopic.php?f=66&t=7717 (german)

That's a great idea. Now we just need a Taranis script for PX4 modes. QGC has some real competition here :)

My approach is to map the PX4 flightmodes to APM flightmodes as good as possible, so only one script is necessary and needs to be maintained.

Clicked the wrong button. Sorry.

Hey Stevie - the idea is great, but I'm concerned that PX4 users are confused by the indication of the display. Let me try to work with the APM community and the user in that thread to see if we can extend it to be more general.

I've filed an issue with the LUA script to see if we can get full support in.

What you wahnt to integrate in the lua Script? I made an Advanced fork of Jace25 Script ,,Lua
Pilot" on githube  mabye i can help to

@ilihack Essentially a way so the LUA script supports PX4 and APM flight modes (both at the same time) and uses for each flight stack the exact appropriate mode description / text label. This will provide a much better user experience, because our users will be very confused by the APM terms.

okay maybe you have allrady what you whant? i use all Pixhawk flightmodes and include support for Temp1 and Temp2 in my script...

@ilihack We need these flight modes in addition to the APM flight modes:
MANUAL
ACRO
STABILIZED
RATTITUDE
POS CONTROL (short: POSCTRL, long: POSITION CONTROL)
ALT CONTROL (short: ALTCTRL, long: ALTITUDE CONTROL)
OFFB CONTROL (short: OFFBCTRL, long: OFFBOARD CONTROL)
AUTO TAKEOFF
AUTO PAUSE
AUTO MISSION
AUTO RTL
AUTO LANDING

@ilihack Let us know when you have a script for us to test with.

Hey @LorenzMeier, Sory for the late Answer i was not able check all my Emails early,
Okay no Problem i can try to modify my script, what we exatcly need? the Arducopters Flightmodes go from 0 to 17 and send with the Temp Variable...
FlightModeName[0]="Stabilize"
FlightModeName[1]="Acro Mode"
FlightModeName[2]="Alt Hold"
FlightModeName[3]="Auto Mode"
FlightModeName[4]="Guided Mode"
FlightModeName[5]="Loiter Mode"
FlightModeName[6]="RTL Mode"
FlightModeName[7]="Circle Mode"
FlightModeName[8]="Invalid Mode"
FlightModeName[9]="Landing Mode"
FlightModeName[10]="Optic Loiter"
FlightModeName[11]="Drift Mode"
FlightModeName[12]="Invalid Mode"
FlightModeName[13]="Sport Mode"
FlightModeName[14]="Flip Mode"
FlightModeName[15]="Auto Tune"
FlightModeName[16]="Pos Hold"
FlightModeName[17]="Brake Mode"

And we need for the user not Fly with the Pixhawk flight stack:
0 Stabilize
1 Acro Mode
2 ALT CONTROL (short: ALTCTRL, long: ALTITUDE CONTROL)
3 AUTO MISSION
6 AUTO RTL
9 AUTO LANDING
and this new Flightmodes: ???
18 MANUAL
19 RATTITUDE
20 POS CONTROL (short: POSCTRL, long: POSITION CONTROL)
21 OFFB CONTROL (short: OFFBCTRL, long: OFFBOARD CONTROL)
22 AUTO TAKEOFF
23 AUTO PAUSE
This is easy and not a Problem if i Unterstand you correct ;)

Hi,
why not providing the Lua script with one model specific configuration option?
Flightstack = PX4 | APM
Than, the script can behave accordingly.
Maybe the LUA script can be changed into direction of the script created by "Craft & Theory" which looks really nice...
http://www.craftandtheoryllc.com/frsky-telemetry-cable-and-user-interface-for-pixhawk/
BR from Hamburg

@BjoernKellermann Its even simpler than that - the LUA script could just be extended with the PX4 flight modes on different indices (above the APM flight modes), then no setup would be required. Anyone here willing to look into that?

Very interested in making this work as well.
I think a good solution would be to leave the APM specific flightmodes to 1-17, and then map the PX4 ones from 18-29.
I have modified the script accordingly (https://github.com/ilihack/LuaPilot_Taranis_Telemetry/pull/2), still need to make the according voice files.
I have changed the frsky_telemetry driver as well: https://github.com/Stevie69/Firmware/pull/1

As suggested by @LorenzMeier, I have created a new PR to reflect my changes. See https://github.com/PX4/Firmware/pull/4345. I guess this should be closed then?

We will go for the cross-flight-stack LUA script.


issue cloning repo

There is an issue with the .gitmodules file that is not allowing the git clone of this repo, or the usage of Carthage.  Can this and the ReactiveUIKit repos match the style of the ReactiveKit .gitmodules?

Ah, that's because submodule are specified over SSH in .gitmodules. Looking into the best way to fix this...

Any update?

Also just hit this - any progress on a fix? Thanks!

I'm working on an update which I plan to release in a week or two. Restructuring repos is part of that and it should solve these kind of issues. Thanks!

Hi, any feedback on update for the issue? Thanks

With v2 ReactiveFoundation is part of ReactiveKit so this repository will eventually be deprecated. Note that v2 is still in beta.


color has no default alpha value

https://github.com/schveiguy/raylib-d/blob/a8f9ab2cccec720d7a09aff1d42607a9ed305e5e/source/raylib/package.d#L182
setting it to 255 makes it better; hottake

Yeah, makes sense actually. Just happened to someone recently, #42


is Bazzite 39 out on gnome version?

Gnome image turns to Fedora 38 still after rebasing to latest. Fedora 39 is out and running on my pc, so it's officially out. Should I wait on bazzite-deck-gnome:latest? What is the release time for Bazzite gnome?

Is as of now


Some integration tests don't set all indexes

What happened:
In integration tests logs, you might find the following errors:
Index with name field:.metadata.parentWorkload does not existUnable to list child jobs

  2023-10-25T19:42:43.924182458Z	ERROR	workload-reconciler	workload/resources.go:112	Failed adjusting requests for LimitRanges	{"workload": {"name":"pod-test-pod-9fd67","namespace":"pod-namespace-wxtrr"}, "queue": "test-queue", "status": "admitted", "clusterQueue": "cluster-queue", "error": "Index with name field:spec.hasContainerType does not exist"}

Although the test succeeds (probably because the test doesn't depend on these reconcilers), this pollutes the logs.
What you expected to happen:
No errors related to indexes
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @trasc


Black text on sphinx-rtd-theme with Breathe C++ autodoc

Overall this is a great theme and I love the animation when switching light/dark themes.
Just a small issue with the api autodoc which causes class names to be black.
The specific CSS selector in the upstream sphinx-rtd-theme which causes this is:
html.writer-html4 .rst-content dl:not(.docutils) .descclassname,html.writer-html4 .rst-content dl:not(.docutils) .descname,html.writer-html4 .rst-content dl:not(.docutils) .sig-name,html.writer-html5 .rst-content dl[class]:not(.option-list):not(.field-list):not(.footnote):not(.citation):not(.glossary):not(.simple) .descclassname,html.writer-html5 .rst-content dl[class]:not(.option-list):not(.field-list):not(.footnote):not(.citation):not(.glossary):not(.simple) .descname,html.writer-html5 .rst-content dl[class]:not(.option-list):not(.field-list):not(.footnote):not(.citation):not(.glossary):not(.simple) .sig-name{font-family:SFMono-Regular,Menlo,Monaco,Consolas,Liberation Mono,Courier New,Courier,monospace;color:#000}

Hi, thank you for the report. Could you please include an example bit of code to show exactly where the issue occurs? Thank you.


pretrained model for Swin-v2?

Thanks for your great repo. I would like to ask when the swin-v2 pre-trained model will be released?

Thanks for your great repo. I would like to ask when the swin-v2 pre-trained model will be released?

The swin-v2 models have been released


bug(mat-date-range-input): JAWS-E goes to the end-date field first

What are you trying to do?
Hi,
I am using a mat-date-range-input and the client is using JAWS-E (Next Edit Box) to go from input-field to input-field.
JAWS-E however first goes to the end date and then to the start date.
Thanks&Regards,
Nelleke
What troubleshooting steps have you tried?
As I thought I was going something wrong, I had asked a question about it on stackoverflow first.
https://stackoverflow.com/questions/71321140/using-mat-date-range-input-but-the-jaws-reader-first-reads-the-end-date-with-jaw
I got a very useful comment that stated that the issue is caused by the 'aria-owns'.
As this is generated by Angular I am unable to fix this myself.
Reproduction
Steps to reproduce:

Add a mat-date-range-input element with a mat-label in the component.
Use JAWS-E Next Edit Box to navigate.
JAWS will first read the end-date field instead of the start-date.

Environment

Angular: 13.3.0
CDK/Material:
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

I added 'with a mat-label' in step 1 of the reproduction.

confirming that I can reproduce on the Date range input forms integration
 example.
Windows 10 Enterprise 20H2 | Chrome Version 101.0.4951.67 (Official Build) (64-bit) | JAWS version 2021.2103.174 ILM

This issue was fixed by #25457 🎉


COPLANAR faces need to be handled specially depending on their facing direction

Ie with addition - two cubes with faces joining while next to each other requires that neither coplanar face is included. But two cubes in exactly the same spot should result in just a single face.
Related to #69

Can likely add COPLANAR_ALIGNED and COPLANAR_OPPOSITE flags to handle specially in the action function.


Correct spelling mistakes in readme.md

Describe what this PR does / why we need it
misspelling in readme file
Describe how you did it
Correct spelling mistakes in readme.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Cyoking seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


exposing vtree traversal methods

Hello--
I would like to add a new vnode into an existing vtree, however, the location where the new vnode is to be inserted will be determined at run time ~~ this determination method is non-normative and will depend on dynamic, application-related factors.
I'm assuming snabbdom is already traversing vtree in order to do it's work when patching DOM. I'm wondering if there might be a way to hook into these traversal capabilities for dynamic vnode insertion purpose ?
Thank you for your ideas/comments

My thoughts: I could create my own search/traversal methods since I have a reference to every vnode as well as the composed vtree. However, it thought it seemed egregious to recreate what snabbdom is already doing, right ?

My intended procedure follows:

User clicks a "new" button
a new vnode is created which must be inserted after a particular vnode data signature (or inserted after some x accumulator measure)
the vtree is traversed until the data signature has been found/fulfilled
once found, the new vnode is inserted as a child of the current vnode
traversal bails out

I have looked at snabbdom.js source a little bit...the traversal mechanism appears to be intertwined with patchVnode(). So I don't think there is a clean way to make snabbdom traverse a vtree--not without running all the patching checks/procedures at the same time.

I was thinking that I could write a snabbdom module which is a listener for the update hook. Once the module finds/fulfills it's target search signature, it could add a new child vnode to the current vnode provided by the update event.
two problems:

it is not clear to me whether update is actually fired for every vnode (even if no changes) ?
it is not clear to me whether a newly inserted vnode would actually get into DOM in the same patch cycle (a ref to the children object is put into a variable before update is fired--so that prob. means the new vnode would not show up until after a second patch...)

I think this is an apt description on the problem I have with snabbdom's traversal mechanism:

Visitor patterns use two classes -- the visitor itself and the class performing the traversal... The visitor applies its logic to a node it receives from the traversal class. Traversal classes are initialized with concrete visitor objects before the beginning of traversals...

The downside of the visitor pattern is that the visitor's interface is not extensible. It is fully controlled by the traversal class and takes only those parameters that the traversal class passes. So, if the logic of tree processing requires additional information not provided by a traversal class or a tree node itself, the visitor class needs to have state (member) objects that should be initialized before the traversal begins. Because the visitor interface is usually implemented by a separate class, encapsulation may potentially be weakened. The "one class for each distinct type of tree processing" requirement can also lead to the creation of numerous classes that are too granular.

And the proposed solution pattern:

The iterator pattern is simpler and its pervasive use in collection class libraries makes it one of the best-known design patterns. Tree iterators do not impose limitations on calling programs. The calling program only needs to call the iterator's next (sometimes called "advance") method.

Another advantage of the iterator pattern is that tree-like structures can be viewed simply as another type of collection, similar to the list or Java Vector class. The iterator pattern, not visitor, is the easiest way to traverse a collection. After all, a visitor is not normally used with lists, so why use it for a tree? Given that, iterator is a better choice of a design pattern for generic algorithms.

What do you think ?

Hello @thurt. I'm sorry for the late response. I completely missed this issue :disappointed:
Normally one does stuff during Snabbdoms traversal by using one of the hooks. I'm wondering if any of those would be useful in you situation?

Hi @paldepind This was an idea that I think snabbdom is simply not designed to do!
I basically wanted to perform modifications on the vtree before getting any DOM side-effects. The modification would be based on fulfilling a data signature defined by the end user--ex: "insert a new vnode after the 5th vnode of this type signature."
However, it looks like snabbdom uses its own "closed" iteration mechanism on the vtree, and it only notifies its "visitor" modules about changed vnodes in relation to the previous vtree. So I have no clear way of accessing unchanged vnodes, whose data I need to check to fulfill the user-defined data signature.
my solution has been to traverse my in-memory vtree with my own breadth-first search iterator of parent-to-child vnodes. After performing my custom traversal/transformation, I send the vtree to snabbdom's patch.
Do you think this is the best approach ?

I basically wanted to perform modifications on the vtree before getting any DOM side-effects.

Snabbdom modifies the DOM while traversing. So you are indeed right that if you want to do a traversal before any DOM effects then you can't use hooks.
Traversing the virtual tree is quite simple. And it sounds like what you want to do has to be done in a kind of preprocessing traversal. So I do think it is the best approach.

Thanks, appreciate your input @paldepind -- closing this issue now


offline_access is incorrectly always added to scopes

Update (2023-01-19):
Since this issue was closed as won't fix, we've decided to port all our user management over to https://authress.io/, it supported everything we needed and doesn't require non-standard OAuth configuration and poor user experience.

Core Library: MSAL.js v2 (@azure/msal-browser)
Core Library Version: 2.14.1
Wrapper Library: Not Applicable
Wrapper Library Version: 2.0.0
Description: The offline_access scope is always being added even when it isn't necessary, and it cannot be removed.
Error Message: No response
Msal Logs: No response
MSAL Configuration:
{}

Relevant Code Snippets:
const loginRequest = {
      scopes: ['profile', 'email', 'openid']
};
const result = await myMSALObj.acquireTokenPopup(loginRequest);

Reproduction Steps:
Run the code: lookup at the requested scopes
Expected Behavior: When scopes is specified they are used and NOT added to.
Identity Provider: Azure AD / MSA
Browsers Affected (Select all that apply): Chrome, Firefox, Edge, Safari, Internet Explorer
Regression: No response
Source: External (Customer)

@wparad Are you seeing any issues or errors occurring in your app with the offline_access scope being present?

Of course, users don't want to approve access to offline when there is no reason. Our users are telling us, they don't want to approve apps, if we ask for email or offline access. We don't need those scopes, so we should be able to remove them, but the library prevents that.
Additionally it is just good security practice: principle of least privilege. This is common best security practice, which basically says: do not request more data or access than you absolutely need. And with OAuth, if we choose later to actually need that access we can ask the user for additional scopes.

@wparad The offline_access scope is required for refresh tokens to be issued to the application. It is considered as part of OIDC scopes for AAD/MSA auth, which is why it is added by default to all requests, similar to openid and profile.

Yes it is a scope, no it is a default scope. That parts wrong. There are lots of scopes, and it is for the app developer to decide what scopes they want, not this library. The API works without the scopes, the library needs to be fixed.
Additionally, correct, the offline_access scope is required for refresh tokens. We don't need refresh token, ergo we don't need this scope.

I'm not saying it is a default scope, I am saying it is added by default by the MSAL library because refresh tokens are used in the basic SPA flow. While we understand the app developer should have control over the scopes they want to use, we add specific scopes by default, namely OIDC scopes (openid, profile, offline_access). The API does work without the offline_access scope, but there are nuances to this that we have had to account for in the past (for example, the offline_access scope being sent back in the response regardless of whether it was sent in the request). We will discuss whether we can add a scenario for access-token only flows for SPAs. I can update here when we decide how to progress.
Be aware the access_tokens in the SPA flow are restricted to 1 hour lifetimes, and will require a redirect or popup to renew once expired if no refresh tokens are used for your application. This can result in a degradation of performance and in user experience.

Why the hell does the auth server require offline_access to keep the user logged in to an SPA. Please go back and validate this, if so that's a huge concern, we expect that silent-auth would use a azure domain HttpOnly/SameSite=Strict cookie or PostMessage to a secure iframe to continue the session and generate a new access token, and not use a "refresh token" to generate a new access token.

@wparad We will probably add some APIs to skip default scopes, please be on the lookout for PRs.

.

We are also experiencing this issue. With the "new" default oauth code flow, there is no more need for refresh tokens, so it should not be any default and most certainly not mandatory for my app. The less such sensitive data is transferred across the Web, the better.

Is this is issue planned or on a roadmap? Having a 30 day refresh token in browser storage is insecure and would force us to use another library if this is not fixed soon.

Is this is issue planned or on a roadmap? Having a 30 day refresh token in browser storage is insecure and would force us to use another library if this is not fixed soon.

Refresh tokens for SPAs have a 24 hour lifetime. We currently do not have plans to remove the defaults, however, we will look into providing a way to turn off the defaults for those that don't want them, though this work has not yet been scheduled. Please do be aware that not using the refresh token may result in more frequent interactive sign-ins, especially in browsers that block 3rd party cookies.

hello, we are also looking forward that kind of customization.

Is there any updates on this?

Refresh tokens for SPAs have a 24 hour lifetime. We currently do not have plans to remove the defaults, however, we will look into providing a way to turn off the defaults for those that don't want them, though this work has not yet been scheduled. Please do be aware that not using the refresh token may result in more frequent interactive sign-ins, especially in browsers that block 3rd party cookies.
In our application, we are fully aware of this could harm the user experience. But that's also exactly what we want for our application.
Any workarounds that I can use atm?

any update on enabling the user to exclude the "offline_access" scope? seems like the discussion happened a long time ago.

The offline_access scope will not be removed from the defaults.  If you want to control sign-in frequency to make sign more frequent for your users, please look into enabling Conditional Access and Sign-in Frequency.

The offline_access scope will not be removed from the defaults. If you want to control sign-in frequency to make sign more frequent for your users, please look into enabling Conditional Access and Sign-in Frequency.

Or you know use any of the other providers where this works correctly:

AWS Cognito
Auth0
Authress

Or one of the hundreds of others that get this correct!

This is super frustrating... It's not about sign-in frequency.
In my case, I need to use the xbox specific scopes instead of the default ones. When I set the scopes to XboxLive.signin Xboxlive.offline_access it instead prompts my users to approve these ones on the consent screen: XboxLive.signin Xboxlive.offline_access offline_access openid profile
This gives my users the impression that I'm requesting much more information about their account then I need. They're absolutely right to be warry and now I have to find a way to implement the auth flows without this otherwise helpful library. :(

Just an FYI... when searching for my problem, I found and commented on this issue not yet realizing that it was for the js version of the msal library and not the python version I'm using. * embarrassed *
I later found out that the python version of msal allows the exclusion of default scopes (including offline_access). For some reason, it does not allow the exclusion of the openid scope, so I submitted a new issue there.

Just want to link this issue which is mine as well as this issue.
If one wants to control the session time of in a B2C tenant (according to the multiple sources as seen in the first linked issue) the offline_access scope has to be omitted.
Just closing the issue won't solve the problem folks.

@wparad is your client library OSS? could you share the link? thanks

@pastinepolenta the problem isn't actually this library, it's AzureAD itself. It incorrectly implements OAuth, so even if you had a different library that did the same thing, it wouldn't actually work with AzureAD, because AzureAD is broken by design. :( That is why we completely switched to a different Auth provider.

@pastinepolenta the problem isn't actually this library, it's AzureAD itself. It incorrectly implements OAuth, so even if you had a different library that did the same thing, it wouldn't actually work with AzureAD, because AzureAD is broken by design. :( That is why we completely switched to a different Auth provider.

Indeed I am not using Azure AD and I am looking for a good quality OAuth OIDC client

oauth services have a coupled SDK

I see your point. Indeed I am investigating solutions for ~ 30 apps that connect to different identity providers (ADFS, OpenAM and Azure AD). I was first hoping to unify clients (and with a React adapter) as the providers are all (supposed to be) fully OAuth 2.0 OIDC compliant. But I see now that providers have their own specificity and that might call for multiple dedicated SDKs.
I will take a look at Authress anyways, thanks.

If there's anybody hitting this page through a search engine. I've managed to work-a-round this problem by doing this:
import { OIDC_DEFAULT_SCOPES } from "@azure/msal-common";
...
OIDC_DEFAULT_SCOPES.splice(OIDC_DEFAULT_SCOPES.indexOf('offline_access'), 1);

This will mutate the default scopes and make sure offline_access is no longer send in.

If there's anybody hitting this page through a search engine. I've managed to work-a-round this problem by doing this:

import { OIDC_DEFAULT_SCOPES } from "@azure/msal-common";

...

OIDC_DEFAULT_SCOPES.splice(OIDC_DEFAULT_SCOPES.indexOf('offline_access'), 1);

This will mutate the default scopes and make sure offline_access is no longer send in.

Where is this mutating?

@hardsree123 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice


unpck version 2.1.1 ?

Could the author please upload the latest version to the CDN ?

The latest version is already on the CDN, it's just the documentation that is outdated:
<EMAIL_ADDRESS>sorry about that


Support strip-cwd-prefix

Hi, I realized that if we want to search with -color we have no easy way to strip the cwd prefixes (./) like cut -b3-. A strip step on printed results before ANSI color codes are applied will be very helpful!

You can use bfs -printf '%P\n'


Test IPT: user account creation fails at initiation with Freemarker template error

Trying to create a user account in the Test IPT (https://ipt.gbif.org/admin/users.do) throws an error, following button click of "Create". The dialogue to enter new user information is not reached.

@ahahn-gbif Thank you Andrea for reporting this issue.
This was fixed here https://github.com/gbif/ipt/issues/1845 (version 2.6.2), ipt.gbif.org needs to be updated to that version.
I'll let you know when it's ready

Thanks, @mike-podolskiy90! We have a user at helpdesk requesting account creation, so being able to do so sometime before the weekend would be helpful.

@ahahn-gbif Yes, of course. Unfortunately, we can't update that right away, since it uses specific RPM package build.
Matt is working on that


Update only relevant cols on repo sync and update in one sql transaction

close  #511
userSyncer Sync commit changes in one transaction
cover new cases with unit tests

now unit tests cover this bug: https://wp.laszlo.cloud/woodpecker-ci/woodpecker/1160/17


Option expose_nil doesn't work when block is passed

Greetings,
I've been trying to implement a conditional exposure at one of the entities in my project.
Noticed that in the current implementation, this code
expose :personal_details, expose_nil: false do |address, options|
  if options[:one_option].present?
    Public::Entities::PersonalDetail.represent address.personal_details
  elsif options[another_option].present?
    Public::Entities::PersonalDetailShort.represent address.personal_details
  else
    nil # explicit for the example
  end
end

will eventually expose null if both conditions are not satisfied.
This PR fixes the specified issue.

Coverage decreased (-0.04%) to 95.822% when pulling 3e2499f0bfe4de8c97c1bdb8cb8ead1fda7dbddd on serbiant:master into 54f68b2bb974c35c51993b4966f27390b0be14ea on ruby-grape:master.

thanks @serbiant

@serbiant I'm using the latest version 0.8.0 which includes your fix but it's still exposing null.

I think you broke something that was working.
Before this change:
class PostEntity < Grape::Entity
  expose :title
end

class CommentEntity < Grape::Entity
  expose :post, expose_nil: false do |object, options|
    PostEntity.represent(object.post, options)
  end
end

Now let's imagine a comment with no post for some reason, in that scenario, PostEntity.represent(object.post, options) is not nil, it's an instance of PostEntity. But it evaluates to nil as object.post is nil
This used to work fine before this change, but now it doesn't as it thinks the block does not return nil. I think you just check nil evaluation in a different place.


Service add to service

Refactor add_resource logic in service_mixin to make it easier to create add_to_service methods on target resources, like Service, VM and eventually GenericObject.
Also adds add_to_service and remove_from_service to Service model.
Links
Replaces add_to_service logic in PR #14876
https://bugzilla.redhat.com/show_bug.cgi?id=1441412
cc @abellotti

This started as a refactoring to support add_to_service/remove_from_service on the different models and grew slightly to include the methods on the Service model.  This lead to the enhancement and refactoring labels.
The methods on the service model are needed in the linked BZ which adds the fine/yes label.

@mkanoor Anything else on this one?

👍

Fine backport details:
$ git log -1
commit 9c7e28f5ec05085499e0ffd31f58dd4b03039c5b
Author: Madhu Kanoor<EMAIL_ADDRESS>Date:   Tue Sep 26 10:34:54 2017 -0400

    Merge pull request #15991 from gmcculloug/service_add_to_service

    Service add to service
    (cherry picked from commit 69a1001b605e15efe4057c8560b948a4acba2de2)

    https://bugzilla.redhat.com/show_bug.cgi?id=1496936


Use go sdk generated from latest NITRO (12.1)

@olljanat would you be able to test this? I don't think it will break existing tfstate but am not sure.

@chiradeep sure. I tested to run terraform refresh and plan on against of our envs which this one and it did not cause any change to tfstate files (except serial number increase which is normal).
LGTM

@chiradeep what is status with this one? It would be nice to get version which contains sslprofile support released and probably it is good idea to do with this one.

Some of the code needs to be regenerated. I have another developer ramping up on the code and this will be the first thing they'll be working on.

@chiradeep OK. Can you then at least just release new version which contains sslprofile support as there is others waiting for it too?

@chiradeep no. It only contains fix for go-nitro side.
Actual implementation was done on #21 which was merged after it.


torch.aten.sym_constrain_range

Tracking for the unsupported torch.aten.sym_constrain_range in torch to linalg.

Support added here https://github.com/llvm/torch-mlir/pull/2924


Error in Nuxt3 - View360.EquirectProjection is not a constructor

Description
In Nuxt3, I'm getting this View360.EquirectProjection is not a constructor  Error for the version
"@egjs/vue3-view360": "^4.0.0-beta.7",
How to solve this,
and I also want to know the proper away to Integrate view360 for Nuxt3 Projects.
Steps to check or reproduce
In Nuxt3 I use this code..
<script setup>
import { View360, EquirectProjection } from "@egjs/vue3-view360";
import<EMAIL_ADDRESS>
const projection = new EquirectProjection({
  src: "/image.jpg"
});
</script>

<template>
  <View360 class="is-16by9" :projection="projection" />
</template>

And I'm getting this error..
index.vue:11 Uncaught (in promise) TypeError: View360.EquirectProjection is not a constructor
    at setup (index.vue:11:22)
    at callWithErrorHandling (chunk-S2INE2O3.js:1750:18)
    at setupStatefulComponent (chunk-S2INE2O3.js:7767:25)
    at setupComponent (chunk-S2INE2O3.js:7728:36)
    at mountComponent (chunk-S2INE2O3.js:6365:7)
    at hydrateNode (chunk-S2INE2O3.js:5397:11)
    at hydrateSubTree (chunk-S2INE2O3.js:6441:13)
    at ReactiveEffect.componentUpdateFn [as fn] (chunk-S2INE2O3.js:6461:13)
    at ReactiveEffect.run (chunk-S2INE2O3.js:1408:23)
    at instance.update (chunk-S2INE2O3.js:6580:52)

How to fix this.

If you have this error : "vite_ssr_import_2.EquirectProjection is not a constructor"
you need to disable "SSR" in nuxt.config.ts export default defineNuxtConfig({ ssr:false });


Make stable release

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3d808ee) to head (684f6a6).
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          590       590
=========================================
  Hits           590       590

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add new machinepool and balance infra component

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description

Add new machinepools to a ROSA HCP cluster
Migrate prometheus-k8s pods to new infra nodepools
Migrate router-ingress pods to new infra nodepools
Validate after migration

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Codecov Report

Merging #337 (491a7c9) into master (626d70e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          20       20
  Lines         912      912
=======================================
  Hits          867      867
  Misses         45       45

Flag
Coverage Δ

gha
95.06% <ø> (ø)

python-3.9
95.06% <ø> (ø)

unit
95.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


[Concurrency] Avoid using "not" in crash tests; use not.py

Description: On some platforms this test was failing even though the test output was all correct -- this leads me to suspect the "not" did not work as expected with remote hosts. This uses a more reliable approach now.
Scope/Impact: Test only, make it work on more platforms rather than the unreliable "not --crash"
Risk: Low, makes test more resilient; test only change
Testing: CI testing
Reviewed by: TBD
Original PR: rdar://131490298
Radar: https://github.com/swiftlang/swift/pull/75152

@swift-ci please test

Is there a corresponding main PR? Could you please link it in the description?

whoops sorry about weird links, thanks!


Show top 720 packages

All but three of the 360 top packages are now compatible with Python 3
(python-augeas is a false positive, Brett will fix it today). Let's show
the top 720 to make it more interesting.
Signed-off-by: Christian Heimes<EMAIL_ADDRESS>

Hi @tiran thank you for your pull request. I had resisted this urge to increase the numbers till now.
But I can't say no to a proposal from Python core dev 😉
As of #51, we decided to make json data static file (to reduce maintenance overhead) and include in the repo as 360 packages don't change often (as you mentioned, they are mostly green already). If we increase to 720, we might need to make it again periodic automatic update.
For now, if you run make generate and add results.json file, I can  accept this PR.

Hi @chhantyal,
I'm waiting for Brett to land my PR https://github.com/brettcannon/caniusepython3/pull/190 . Here is a preview of the top 1440 packages with PR 190, file:///home/heimes/dev/private/tiran.github.io/py3readiness/index.html

Here's an online version for those who can't access @tiran's computer :)
https://tiran.github.io/py3readiness

Argh, thanks @hugovk ! I've updated my last comment.

Is this PR still open?


container crashes in single node deployment

postgresql container enters crash loop after helm install with following error.
install: cannot change owner and permissions of ‘/var/lib/postgresql/wal/pg_wal’: Operation not permitted

helm delete didn't remove PVC. It worked after cleanup. Then, I ran into the following error.
error: cannot attach to *v1.Service: invalid service 'mytest': Service is defined without a selector

Helm does not remove pvc's, that is part of Helm:
https://github.com/helm/helm/issues/5156
We ran into this ourselves, so we documented this here:
https://github.com/timescale/timescaledb-kubernetes/blob/master/charts/timescaledb-single/admin-guide.md#cleanup

With regards to the Service is defined without a selector message, that is correct, the master service governed by Patroni does not have a selector.

What sequence of steps did you take to run into this error message?
What version of Helm are you using
What version of Kubernetes are you using?
What is the output of:kubectl get all,ep,service -l cluster-name=<deployment name>

I was trying to setup port-forward so that I can access timescalesdb from outside kubernetes for development.
I did git pull today, redeployed timescaledb-single chart.
❯❯❯ kubectl get all,ep,service -l cluster-name=ktsdb -n ktsdb
NAME                      READY   STATUS    RESTARTS   AGE
pod/ktsdb-timescaledb-0   1/1     Running   0          22m
pod/ktsdb-timescaledb-1   1/1     Running   0          21m
pod/ktsdb-timescaledb-2   1/1     Running   0          20m

NAME                    TYPE           CLUSTER-IP       EXTERNAL-IP   PORT(S)          AGE
service/ktsdb           LoadBalancer   <IP_ADDRESS>   <pending>     5432:31316/TCP   22m
service/ktsdb-config    ClusterIP      None             <none>        8008/TCP         22m
service/ktsdb-replica   ClusterIP      <IP_ADDRESS>      <none>        5432/TCP         22m

NAME                                 READY   AGE
statefulset.apps/ktsdb-timescaledb   3/3     22m

NAME                      ENDPOINTS                                            AGE
endpoints/ktsdb           <IP_ADDRESS>:5432                                     22m
endpoints/ktsdb-config    <IP_ADDRESS>:8008,<IP_ADDRESS>:8008,<IP_ADDRESS>:8008   22m
endpoints/ktsdb-replica   <IP_ADDRESS>:5432,<IP_ADDRESS>:5432                    22m

I am using Helm v3, deploy on minikube 1.3.1. The followings are the step taken. I've got a different error this time.
~/w/t/charts ❯❯❯ kubectl create namespace ktsdb
~/w/t/charts ❮❮❮ helm install ktsdb  timescaledb-single -n ktsdb
~/w/t/charts ❯❯❯ kubectl port-forward service/ktsdb 5432:5432 -n ktsdb
error: Pod 'ktsdb-timescaledb-0' does not have a named port 'postgresql'

Port forwarding to the service for the primary instance is not going to work directly with kubectl port-forward, as it is designed to work without a selector.
More detail about this limitation of kubectl port-forward can be found here:
https://github.com/txn2/kubefwd/issues/35
This comment shows a possible workaround:
https://github.com/txn2/kubefwd/issues/35#issuecomment-462524408

@feikesteenbergen got it. It is as design. I just need to port forward for dev/debug purpose, I end up with port-forward port from pod directly.
kubectl port-forward pod/bw-timescaledb-0 5432:5432 -n test


Consider a more explicit behavior to designate the default embedder

No time in v1.10, will be done in v1.11


Fix file lock 2

testing in CI rando ideas

I think that #425 takes care of this. Closing this out.


HBASE-28723 [JDK17] TestSecureIPC fails under JDK17

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  0s

branch-2 passed

+1 :green_heart:
compile
5m 34s

branch-2 passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
5m 41s

the patch passed

+1 :green_heart:
javac
5m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  1s

No new issues.

+1 :green_heart:
hadoopcheck
15m 10s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s

The patch does not generate ASF License warnings.

36m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6072

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 26b7482e2182 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0003e85f05ad5115edb189e7a7487ec880511beb

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
74 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 16s

branch-2 passed

+1 :green_heart:
compile
2m  9s

branch-2 passed

+1 :green_heart:
javadoc
2m  0s

branch-2 passed

+1 :green_heart:
shadedjars
5m 58s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 57s

the patch passed

+1 :green_heart:
compile
2m  8s

the patch passed

+1 :green_heart:
javac
2m  8s

the patch passed

+1 :green_heart:
javadoc
1m 57s

the patch passed

+1 :green_heart:
shadedjars
5m 56s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
269m  9s

root in the patch passed.

303m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4c954674b205 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0003e85f05ad5115edb189e7a7487ec880511beb

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/testReport/

Max. process+thread count
9051 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  6s

branch-2 passed

+1 :green_heart:
compile
1m 57s

branch-2 passed

+1 :green_heart:
javadoc
1m 49s

branch-2 passed

+1 :green_heart:
shadedjars
5m 52s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 48s

the patch passed

+1 :green_heart:
compile
1m 56s

the patch passed

+1 :green_heart:
javac
1m 56s

the patch passed

+1 :green_heart:
javadoc
1m 47s

the patch passed

+1 :green_heart:
shadedjars
5m 51s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
279m 44s

root in the patch passed.

311m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux<PHONE_NUMBER>2d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0003e85f05ad5115edb189e7a7487ec880511beb

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/testReport/

Max. process+thread count
9083 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 41s

branch-2 passed

+1 :green_heart:
compile
2m 28s

branch-2 passed

+1 :green_heart:
javadoc
2m 52s

branch-2 passed

+1 :green_heart:
shadedjars
6m 42s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s

the patch passed

+1 :green_heart:
compile
2m 25s

the patch passed

+1 :green_heart:
javac
2m 25s

the patch passed

+1 :green_heart:
javadoc
2m 48s

the patch passed

+1 :green_heart:
shadedjars
6m 47s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
368m 30s
/patch-unit-root.txt
root in the patch failed.

406m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6072

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bc064fb3093f 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0003e85f05ad5115edb189e7a7487ec880511beb

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/testReport/

Max. process+thread count
4596 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6072/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


return the initialized editor

I kept getting a 'wysihtml5Editor is undefined' error when using this code:
var wysihtml5Editor = $('#something').data('wysihtml5').editor;
wysihtml5Editor.composer.commands.exec('insertHTML','Some text to insert');
Then I went digging in the code and found that this : "this.editor =  this.createEditor(toolbarOpts);" on line 14613 does not return anything.
So when I add a return at the end of the createEditor function, it fixes my problem.

This issue should be reported and fixed on the WYSIHTML repo not here.
Thanks!


Minestom support

It's really cool that you make your plugins multi-platform. Would love to see Minestom implementations

useful repos:

https://github.com/hollow-cube/minestom-ce
https://github.com/OpenMinigameServer/cloud-minestom

Thanks for the interest! Right now I don't have Minestom on my radar since I still have features to implement for a 1.0 release (improved terrain handling, entity collisions, and liquid buoyancy being the main ones). Branching out to new platforms is quite hard since there are a lot of different things to keep track of to keep the core API platform-agnostic, but make platform-specific implementations ergonomic for users. Even just supporting Fabric and Paper (and Folia!) is a pain sometimes.
If you would like to implement a Minestom platform (or any other platform) yourself, much of the work is already done in rattle-common, such as commands. You will need to handle the actual hooks yourself though.


Implementation Request IgniteEntityEvent

1.10.2 versions dont have the IgniteEntityEvent fired when events burst into flame from fire, lava or sunlight (skeletons/zombies).  I dont know if this event was ever implimented in 1.8.9 and didn't make it.
DamageEntityEvent only goes so far as a workaround - it only registers living entities suffereing health damage ticks due to fire.
IgniteEntityEvent will capture armor stands being ignited by lava and fire  (as well as prevent need for listening to generic damage for living entities)

PR merged. This can be closed.


How to use connected-react-router with redux-dynamic-module

I have created typescript based website with react.
I am using react router dom.
I want to use connected react router.
I don't know where to add

router: connectRouter(history), and  routerMiddleware(history)

I am using the following configuration while create store.

const store: IModuleStore = createStore(
{
extensions: [getSagaExtension()],
}
);

I have used the routerMiddleware(history) with the enhancer. But that shows error with the typings.
In my actual structure,
I have auth module,

export const AuthModule: ISagaModule<types.AuthState> = {
// Unique id of the module
id: 'auth',
// Maps the Store key to the reducer
reducerMap: {
authState: reducer,
},
// This module uses redux-saga middleware
// This property will be be used by the SagaExtension
// to run sagas for the moduleD
sagas: [authsaga],
};

I am sharing this module with the two container Home and Landing. This will have sub routes.
Where I am making mistakes? How should I correct it?

I commented with sample on #114 , so please refer to it.

It might seem intimidating at first, but once you grasp the concept of modules, it becomes very easy.
Whenever you want to integrate any reducers or middleware, you use a module for that. You can create a module called routerModule and add it as an initial module when creating a store. Initial modules can be added as an additional argument to the store.
Here is the basic setup:
routerModule.ts:

import { createBrowserHistory, LocationState } from 'history';
import { connectRouter, routerMiddleware } from 'connected-react-router';
import { IModule } from 'redux-dynamic-modules';

export const history = createBrowserHistory();

export const routerModule: IModule<LocationState> = {
    id: 'startup',
    reducerMap: {
        router: connectRouter(history),
    } as any,
    middlewares: [routerMiddleware(history)],
};

And then use it in your root component as follows:
index.ts:

...
other imports
...
import { ConnectedRouter } from 'connected-react-router';
import { routerModule, history } from './modules/RouterModule';

const store: IModuleStore<{}> = createStore(
    {
        extensions: [getSagaExtension()]
    },
    routerModule,
);

// store.addModule(routerModule); // another way of adding a module

ReactDOM.render(
        <Provider store={store}>
            <ConnectedRouter history={history}>
                <App />
            </ConnectedRouter>
        </Provider>,
        document.getElementById('root'),
    );

Thank you for the response.
Do I need to add this routerModule to every module to be used in subsequent modules?
For example I am using AuthModule for the initial parent containers which is used in the parent routings (Private/Protected).
Typescript - example
export interface AuthState {
    userstate: UserState;
    locationstate: LocationState;
}

export const _authModule: ISagaModule<types.AuthState> = {
// Unique id of the module
id: 'auth',
// Maps the Store key to the reducer
reducerMap: {
authState: reducer,
},
// This module uses redux-saga middleware
// This property will be be used by the SagaExtension
// to run sagas for the moduleD
sagas: [authsaga],
};

export AuthModule = [routerModule,_authModule];

const mapStateToProps = (state: AuthState) => {
    return {
        isLoggedIn: state.authState.isLoggedIn,
        name: state.authState.name,
    };
};

export const HomeContainer = () => (
    <DynamicModuleLoader modules={[AuthModule]}>
        <ConnectedOrder />
    </DynamicModuleLoader>
);

I commented with sample on #114 , so please refer to it.
But this demo by JavaScript, I'm sorry if you have TypeScript specific problems.

Good example. Thank you.

Do I need to add this routerModule to every module to be used in subsequent modules?

@jeevasusej, If you add it as an initial module, there is no need to add it again for subsequent modules.

Thank you @assainov
For strongly typed props, I have inherited the interface type from the root state.
Will it be a right approach?
export interface AuthState {
    authState: UserState;
}

export interface AuthMainState extends AuthState, RootState {}

const mapStateToProps = (state: AuthMainState ) => {
    return {
        isLoggedIn: state.authState.isLoggedIn,
        name: state.authState.name,
        pathname : state.router.location.pathname,
    };
};

@jeevasusej ,

For strongly typed props, I have inherited the interface type from the root state.
Will it be a right approach?

It's getting a bit off topic, but - yes, you can definitely extend it. The alternative approach would be to use a type alias:
type AuthMainState = AuthState | RootState;


send data in resize event

hi. i need send custom data in resize event and check data in function for save newRect for that.
how can i do this?

it's about vue
maybe you want the way as follows
@resize="functionA($event, index)"
here, the $event means the params in this.$emit('functionA', newRect)
write as so in methods:
methods: {
functionA(newRect, index) {
console.log(newRect)
console.log(index)
}
}


Add devices (hostdev, shmem)

I have added two new device types.

Done :+1:

Now it works like a charm. :+1:

Thanks!


[Cherry-pick] raftstore: read index message count metric

What have you changed?
Cherry pick https://github.com/tikv/tikv/pull/6579
What is the type of the changes?

Misc (other changes)

How is the PR tested?

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.
Does this PR affect tidb-ansible?

No.

/run-all-tests


chore/default-branch-rename

Description
Minor cleanups after renaming default branch from master to main
How to Test

Verify text changes
Review the outcome of CI in https://github.com/particle-iot/particle-usb/actions

Outcome
Tests run successfully, docs are clear 👍

self-review :shipit:
FYI @sergeuz


Update medication map, fix updating of census on patient deletion

The map persisted whenever new AddressBook objects were
initialised and this led to inconsistencies from certain commands.
Hence.

Refactor static map object into MedicationMap.java
Update dependencies to use new class
Update relevant test cases

Codecov Report
Base: 62.46% // Head: 62.99% // Increases project coverage by +0.53% :tada:

Coverage data is based on head (cec69c7) compared to base (e299a45).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
+ Coverage     62.46%   62.99%   +0.53%
- Complexity      553      566      +13
============================================
  Files           110      111       +1
  Lines          2014     2051      +37
  Branches        263      265       +2
============================================
+ Hits           1258     1292      +34
  Misses          661      661
- Partials         95       98       +3

Impacted Files
Coverage Δ

.../main/java/seedu/address/model/tag/Medication.java
80.00% <ø> (+27.82%)
:arrow_up:

...in/java/seedu/address/model/tag/MedicationMap.java
72.50% <72.50%> (ø)

src/main/java/seedu/address/model/AddressBook.java
82.05% <90.90%> (+6.18%)
:arrow_up:

...address/model/appointment/UpcomingAppointment.java
88.88% <0.00%> (-11.12%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Saying install face_recognition_models with this command before using face_recognition

i have installed face_recognition_models still it is telling me to install it again and again because of what the code is not running

i have the same issue


add Session.call_after_roundtrip

Adds a convenience method on Session to overcome jitter effects. We keep patching things up, but really, this idea of objects that exist in both Python and JS is flawed.

This is purely a workaround, no?

You could consider this a feature to deal with (i.e. work around) some of the limitations of the current Model mechanics (in particular the way how properties are synced).


How can I change the front-end theme!

Hi,
I would like to change the theme of the front end, this theme comes with bootstrap 4 and custom styles, this is in the same .css file, will there be any way to integrate it?
Thanks!!

There are basically some variables in config/backend.php with color scheme, you can change that to your preference.


Debugger does not break on symlinked module (NodeJS/Mac OSX Sierra)

I think there's an issue with symlinks on Mac. I used npm link to link a module. The code runs fine, but adding a breakpoint does not break.

VSCode Version: February 2017 (version 1.10)
OS Version: MacOS Sierra Version 10.12.3

Steps to Reproduce:

Create a child NodeJS module - just hello world will do. - run npm link in the module directory.
2.Create a parent module and npm link the child. npm link child from the parent directory.
Write a script to call the child code from the parent project. child.sayHello()
navigate to node_modules and add a breakpoint in the child code.
Run the debug for NodeJS.
It probably won't break on the child.
npm unlink child
Change package.json to import by adding the child as a file dependency. child: '../child'
npm install to 'copy' the files in rather than symlink them.
reset the breakpoint in the child code.
Rerun the debugger - it should now break in the child code.

@rgilling I can reproduce and I understand what is going on:
My setup is as follows:

And my launch config is:
			{
				"type": "node",
				"request": "launch",
				"protocol": "legacy",
				"name": "test.js",
				"program": "${workspaceRoot}/test.js"
			}

I'm opening VS Code on the 'test' project.
If I navigate to the 'index.js' file to set the breakpoint, VS Code doesn't notice that 'index.js' lives in the symlinked 'helloworld' folder. As a consequence it considers 'index.js' as a file in your 'test' workspace. So its workspace relative path becomes 'node_modules/helloworld/index.js' which is then expanded to become absolute: '/symlinks/test/node_modules/helloworld/index.js'. This path is used to register a breakpoint with node.js.
The problem is that node.js sees the 'index.js' file under the real path: '/symlinks/helloworld/index.js'.
Since these paths do not match the breakpoint is not hit.
We do not have a good solution for solving symlink issue in the general case, but there is a way to work around the issue:

do not navigate to 'index.js' through VS Code's explorer but try to "step into it" through the debugger.  Then set the breakpoint. You will notice that VS Code creates a new breakpoint in the breakpoint view:

Now the breakpoint's path is correct (without the symlink).
This breakpoint will be hit.
(@roblourens I noticed that my workaround does not work with the 'inspector' protocol. But may be you have a better workaround for this symlink problem)

I filed this some time ago - https://github.com/Microsoft/vscode-node-debug/issues/73 - but no, I don't have a better workaround :)

I often debug from the symlinked module's folder, which is painful to set up but works for my case.

I will enable localRoot/remoteRoot for "launch" and see whether this helps...
But why doesn't help the workaround with the inspector?

It does work for me - I can step into a symlinked module, get a file with the real path, and set BPs there.

@rgilling thanks for the tip: adding "--preserve-symlinks" as a runtime argument fixes the problem for me:
{
	"type": "node",
	"request": "launch",
	"protocol": "legacy",
	"name": "test.js",
	"program": "${workspaceRoot}/test.js",
	"runtimeArgs": [
		"--preserve-symlinks"
	]
}

@roblourens this doesn't work for me with "protocol": "inspector" and node v6.10.1.

I will add this great tip to the documentation.

@weinand That doesn't work for me either. Will investigate.

Hi guys, glad that helped. Per node doc preserve-symlinks was added node 6.3. It's probably similar to the issue I had previously then. preserve-symlinks is okay for some cases where you're running node directly, but if you're running things like npm, grunt or mocha they need to also support the param. I know mocha does, I recall I was having issues with Grunt though.

I don't want to complicate the already complex breakpoint path handling by handling breakpoints on either end of a symlink.


Fix volume details verification on volume creation when type parameter is mot given in the storage class

/kind bug
What happened?
Volume details verification fails when type attribute is not given as part of storage class creation.
Issue ref: https://github.ibm.com/redstack-power/project-mgmt/issues/2564
What you expected to happen?
Volume details verification should pass by verifying the created VolumeType with the defaultVolumeType.
How to reproduce it (as minimally and precisely as possible)?
Create a storage class with No parameters. Then create a pvc.
Anything else we need to know?:
Environment

Kubernetes version (use kubectl version):1.23
Driver version:v0.1.0-alpha.3

/assign


build: fix broken boost chrono check on some platforms

Squashed version of https://github.com/bitcoin/bitcoin/pull/4571
If clock_gettime is implemented outside of libc (librt in this case), configure
would fail when testing boost. Since clock_gettime is not present on all OSs,
boost only uses it when it can. Check for it in librt and add it to LIBS if
found, but don't fail if it's not (since boost won't be expecting it in this
case).
Also, reverse the link order as necessary for static libs.
Note that it's possible that there are other similar cases for boost, which may
be handled the same way.

no regressions here, on non-rtos. such utACK


Implicit errors are not always redirected in the fragment

All OAuth2 errors don't seem to be returned properly for implicit grants, as some are sent within the querystring as opposed to the fragment per the RFC.
It looks like the overarching error handling logic isn't customizable per grant, and the authorization server itself has a blanket catch for error handling: https://github.com/lepture/authlib/blob/master/authlib/oauth2/rfc6749/authorization_server.py#L171

If the resource owner denies the access request or if the request
fails for reasons other than a missing or invalid redirection URI,
the authorization server informs the client by adding the following
parameters to the fragment component of the redirection URI using the
"application/x-www-form-urlencoded" format, per Appendix B:

See https://tools.ietf.org/html/rfc6749#section-<IP_ADDRESS> for more details.

Thanks, I've fixed it.


New Category "Provider Ring" for Ethereum providers

Please create a new Category for the Ethereum providers called "Provider Ring".

@p0s we need to work on a Github issue template for this, can you please add more context?
I think you mean Ethereum web3 providers?
Can you also write a short "about" that will appear at the top of the forum category. Here's the Wallet Ring as an example: https://ethereum-magicians.org/t/about-the-wallet-ring-category/810
@jpitts is the one with the keys to do the actual creation.

@bmann You are right. It is about Ethereum web3 providers.
Sure, I put all the information into the following forum thread: https://ethereum-magicians.org/t/forming-a-ring-provider-ring/1852

@jpitts could you look into creating the category?

Thanks for adding the category 👍


Resource Pack Reload Error

Whenever enabling CIT resewn and attempting to add CIT resource packs I should usually be able to use in regular vanilla MC with optifine will not reload. It gives me a Resource Pack Reload Error, and disables all my resource packs.
This only happens with CIT resewn, and not with optifine. I have no other mods enabled that could be causing this issue as well as I only have upmost 4-5 mods.
This happens with Ghoulcraft CIT and Hananacraft CIT more particularly.

Cant help you without logs but I'm assuming it's just broken paths again, there are other issues addressing this.


Switch to incremental source generators

Someone replied to my question and said:
"
As a side note, you should change this to an incremental source generator ASAP.
"
Let's research it, apply if necessary

Closed by #757f78d1690a274fa80fc4e122d45fbb97b66a9e


multiprocessing Connection aborted

Great library! I'm trying to use the cli to create a dataset and after some time I keep getting the following traceback
20:49:26 DEBUG: https://github.com:443 "GET /dmvianna/patents/archive/master.zip HTTP/1.1" 302 121
20:49:26 DEBUG: Starting new HTTPS connection (1): codeload.github.com:443
20:49:26 DEBUG: https://codeload.github.com:443 "GET /JacobLeach/snap-testing/zip/master HTTP/1.1" 200 3759
20:49:26 DEBUG: Downloading https://github.com/muhammadhassaanfarooqui/Haskell-Test/archive/master.zip
20:49:26 DEBUG: Starting new HTTPS connection (1): github.com:443
20:49:26 DEBUG: Downloading https://github.com/satnam6502/hpull/archive/master.zip
20:49:26 INFO: --> Processed 36600 repositories...
20:49:26 INFO: --> Processed 36700 repositories...
20:49:26 INFO: --> Processed 36800 repositories...
20:49:26 INFO: --> Processed 36900 repositories...
20:49:26 INFO: --> Processed 37000 repositories...
20:49:26 INFO: --> Processed 37100 repositories...
20:49:26 DEBUG: Starting new HTTPS connection (1): github.com:443
20:49:26 INFO: --> Processed 37200 repositories...
20:49:26 INFO: --> Processed 37300 repositories...
20:49:26 INFO: --> Processed 37400 repositories...
20:49:26 INFO: --> Processed 37500 repositories...
20:49:26 INFO: --> Processed 37600 repositories...
20:49:26 INFO: --> Processed 37700 repositories...
20:49:26 DEBUG: https://github.com:443 "GET /marot/hnars/archive/master.zip HTTP/1.1" 302 116
20:49:26 DEBUG: Starting new HTTPS connection (1): codeload.github.com:443

multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 677, in urlopen
    chunked=chunked,
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 426, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 421, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 1344, in getresponse
    response.begin()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 306, in begin
    version, status, reason = self._read_status()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 275, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 727, in urlopen
    method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/util/retry.py", line 410, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/packages/six.py", line 734, in reraise
    raise value.with_traceback(tb)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 677, in urlopen
    chunked=chunked,
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 426, in _make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/urllib3/connectionpool.py", line 421, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 1344, in getresponse
    response.begin()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 306, in begin
    version, status, reason = self._read_status()
  File "/usr/local/jason/python/python376/lib/python3.7/http/client.py", line 275, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/jason/python/python376/lib/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/common.py", line 217, in _apply
    return method(item, *other_args, **keywords)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/workflow/compressed_repositories.py", line 114, in _download_repository
    ok, status = download_file(url, path)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/common.py", line 155, in download_file
    response = requests.get(url, stream=True, timeout=TIMEOUT)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/api.py", line 76, in get
    return request('get', url, params=params, **kwargs)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/sessions.py", line 665, in send
    history = [resp for resp in gen]
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/sessions.py", line 665, in <listcomp>
    history = [resp for resp in gen]
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/sessions.py", line 245, in resolve_redirects
    **adapter_kwargs
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/sessions.py", line 643, in send
    r = adapter.send(request, **kwargs)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/requests/adapters.py", line 498, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jason/.virtualenvs/code_detection/bin/gltool", line 8, in <module>
    sys.exit(main())
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/__main__.py", line 90, in main
    run_workflow()
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/app.py", line 14, in run_workflow
    compressed_repositories.download()
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/common.py", line 112, in wrapped
    result = func(*args, **kw)
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/workflow/compressed_repositories.py", line 89, in download
    for step, row in enumerate(pool_imap(_download_repository, rows), 1):
  File "/home/jason/.virtualenvs/code_detection/lib/python3.7/site-packages/guesslangtools/common.py", line 208, in pool_imap
    for result in pool.imap(_apply, iterable):
  File "/usr/local/jason/python/python376/lib/python3.7/multiprocessing/pool.py", line 748, in next
    raise value
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Is there a way to resume a job if it fails like this?

Hi @jmwoloso
You are getting this error because Github servers closed the HTTP connection when the gltool was downloading the some repositories to extract example files.
Fortunately, you can just relaunch gltool with the same parameters and the dataset generation will resume where it stopped.

Ok great! Thanks @yoeo


StaticFileHandler weird behaviour on old browsers

Hello,
I am developing a web platform that I need to work with iPads running iOS9.
I tried accessing it with Safari, Firefox and Chrome but it seems to me that StaticFileHandler does not work properly. Indeed, some of my JS and CSS files and my images are not always loaded. I inspected the requests sent by the browser and it seems that some of them randomly never complete, then the browser waits indefinitely for the response.
I did not have any problems with newer versions of iOS. I also tried to load the resources from an Apache server and it works fine.
Do you have any idea why this happens?
Thanks!

Ensure you are passing allowResponseFilters: true when you make the StaticFileHandler. If you are using TLS or compression then this needs to be true. I think it does this automatically when TLS is in effect but SFH doesn't know about content compression, so it needs to be set explicitly.
https://github.com/PerfectlySoft/PerfectTemplate/blob/master/Sources/PerfectTemplate/main.swift#L41

allowResponseFilters is indeed set to true.
I also encounter this kind of errors:
[Error] Did not parse stylesheet at 'someFile.css' because non CSS MIME types are not allowed in strict mode.

Also, some of my JS files are sometimes incorrectly decoded.
I wonder if this can be related to the cache because it eventually works after I refresh the page multiple times without changing anything in my code.

Update: I dug a little bit deeper using Wireshark and discovered an interesting phenomenon.
I think Perfect might be mixing responses and requests. Indeed, I realised that I sometimes get a JS file as response to a PNG request... any idea why?
Again, it all works fine if I load my resources from an Apache server, which makes be think that the problem indeed comes from Perfect and not the client.
Thanks!

Do you have content compression enabled? If so, remove that filter and see if it has an effect. I'm just trying to eliminate certain causes at this point. If you can, paste in your code for launching the server, just so I can see if there's anything unusual there.

I tried both, with and without compression. It has no effect.
Sure thing, here is the code:
let server = HTTPServer()
let sessionDriver = SessionMemoryDriver()

let routes = [
    Route(method: .get, uri: "/**", handler: try! HTTPHandler.staticFiles(data: [
        "documentRoot": "./webroot",
        "allowResponseFilters": true
    ])),
    Route(method: .get, uri: "/", handler:homeController.indexAction),
     // more non-static files routes...
]

server.setRequestFilters([sessionDriver.requestFilter])
server.setResponseFilters([sessionDriver.responseFilter, (Finalizer(), .high)])
/*
    With compression:
    server.setResponseFilters([sessionDriver.responseFilter, (Finalizer(), .high), (try PerfectHTTPServer.HTTPFilter.contentCompression(data: [:]), HTTPFilterPriority.high)])
*/
server.serverPort = 8181
server.addRoutes(routes)
server.serverName = "localhost"
try! server.start()

Here is my response filter (Finalizer):
class Finalizer: HTTPResponseFilter {

    public func filterHeaders(response: HTTPResponse, callback: (HTTPResponseFilterResult) -> ()) {
        if 400...500 ~= response.status.code {
            let pageContent = "An error occured"
            response.setBody(string: pageContent)
            response.setHeader(.contentLength, value: String(pageContent.count))
            callback(.done)
        }
        else {
            callback(.continue)
        }
    }

    public func filterBody(response: HTTPResponse, callback: (HTTPResponseFilterResult) -> ()) {
        callback(.continue)
    }
}

I hope this helps!
Thank you!

Thank you for your reply!
I am indeed using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>However<EMAIL_ADDRESS>is targeting<EMAIL_ADDRESS>hence this is the version I am using instead of 3.3.0.
I managed to design a minimal server needed to reproduce the bug.
Here is my Package.swift:
// swift-tools-version:4.2

import PackageDescription

let package = Package(
    name: "RunnifySwift",
    dependencies: [
        .package(url: "https://github.com/PerfectlySoft/Perfect-HTTPServer.git", from: "3.0.23"),
        .package(url: "https://github.com/PerfectlySoft/Perfect-Mustache.git", from: "3.0.2")
    ],
    targets: [
        .target(
            name: "RunnifySwift",
            dependencies: ["PerfectHTTPServer", "PerfectMustache"]),
        .testTarget(
            name: "RunnifySwiftTests",
            dependencies: ["RunnifySwift"]),
    ]
)

My server contains 2 Swift files:
main.swift:
import PerfectHTTP
import PerfectHTTPServer
import PerfectMustache
import Foundation

let server = HTTPServer()
let WEBROOT = "[path-to-webroot]"

func handlePage(_ controller: @escaping (HTTPRequest) throws -> (String, [String: Any])) -> (HTTPRequest, HTTPResponse) -> Void {
    return { req, res in
        do {
            let (view, data) = try controller(req)
            mustacheRequest(request: req, response: res, handler: PageHandler(values: data, sessionData: [:]), templatePath: WEBROOT + view)
        }
        catch(let error) {
            res.setBody(string: error.localizedDescription)
            res.completed(status: .internalServerError)
        }
    }
}

func indexAction(request: HTTPRequest) throws -> (String, [String: Any]) {
    return ("pages/Index/index.html.mustache", ["listRaces": []])
}

let routes = Routes([
    Route(method: .get, uri: "/**", handler: try! HTTPHandler.staticFiles(data: [
        "documentRoot": WEBROOT,
        "allowResponseFilters": true
        ])),
    Route(method: .get, uri: "/", handler: handlePage(indexAction))
])

server.serverPort = 80
server.addRoutes(routes)
server.serverName = "localhost"
try! server.start()

And PageHandler.swift:
import Foundation
import PerfectMustache
import PerfectHTTP

struct PageHandler: MustachePageHandler {
    let values: MustacheEvaluationContext.MapType
    let sessionData: [String: Any]

    func extendValuesForResponse(context contxt: MustacheWebEvaluationContext, collector: MustacheEvaluationOutputCollector) {
        contxt.extendValues(with: values)
        contxt.extendValues(with: sessionData)
        do{ try contxt.requestCompleted(withCollector: collector) }
        catch {
            let response = contxt.webResponse
            response.status = .internalServerError
            response.setBody(string: "\(error)")
            response.completed()
        }
    }
}

You can find the content of my webroot here (I removed everything that is not necessary).
I am running the server on an Early-2015 MacBook Pro (macOS Mojave 10.14.6) and the bug occurs when I try to access the root of the website from Safari, Firefox and Google Chrome running on both an iPad 2 and iPad 3 running iOS 9.5.3 (latest available version for both models).
Note that the bug does not occur every time. Best way to trigger it is to empty the cache and reload the page. If it does not occur, it is sometimes necessary to repeat the operation 3-4 times.
I hope it helps! 😄
Thank you!

That was very helpful, thank you. I am able to reproduce the problem and will report back when I get to the bottom of what's happening.

So… still not sure exactly what's happening, but I have been able to eliminate several possibilities. It's not mustache; I removed that and just serve the static index page and the problem is still there. It's nothing internal to Perfect mixing up the requests/responses. I added some debugging there and the proper files are being read and returned with the proper mime type and content-length.
The strangest bit though is that if I comment out  it all loads fine. I switched it to use all.min.js and it still hangs.


When starting with 'anna' allow to specify config file with an option

echo the config file that is being used when starting, either the default or the one specified on the command line

Fixed by #18


Add ResNet-101 and ResNet-152 to links.modes.vision

This PR just adds ResNet101 model and ResNet152 model under links.modes.vision besides ResNet50.

It passes all tests on Jenkins, so it's ready to be reviewed.
https://ci-chainer.pfidev.jp/job/chainer-sakura/1127/

@rezoo Thank you for you review! I added some descriptions and fixed typos.

I added several comments. I would like to merge this PR after fixing the above comments.

@rezoo Thank you for checking. I fixed all your points.

Thank you. After passing all tests I would like to merge.

@rezoo Seems it passed all tests (tests of appveyor is ignorable): https://ci-chainer.pfidev.jp/job/chainer-sakura/1170/

Thank you! LGTM