: An unexpected error has occurred being indexed as title on google

Bug report
Describe the bug
I have 3 different websites served by next.js and some random pages are being indexed on google with title as ": An unexpected error has occurred - My website name" but everything looks fine with the title tag when opening page's source
To Reproduce
Have no idea, since the error only appears when indexed by google, but you can see it wrong with these website:
site:brasilmaplestory.com
just google it ^
Expected behavior
No error message at page's title
Screenshots
System information

Version of Next.js: 6.1.1

Additional context
How do I use the title tag:
page.jsx
<PageLayout title={`CashShop | ${websiteName`}>
    .... Page content
  </PageLayout>

PageLayout.jsx
const PageLayout = ({
  title,
 ...
}) => (
<div>
    <Head>
      <meta charSet="UTF-8" />
      <title>{title}</title>
........
    </Head>
  </div>
);

@JoaoBGusmao need to see your package.json what modules do you use?

So I had this problem recently, it's quite hard to debug. For me the JavaScript was executing fine in the latest browsers, but crashing when googlebot was accessing the site. They use an old version of Chrome (Chrome 41). Download that and try and access your website with it, you'll probably find the site crashes, and the error should be listed in the dev tools console.
For me it was Object.assign not being supported, so I just polyfilled it.

I'm going to try downloading this old chrome version. By the way, when using the google webmater tool "googlebot fetch" the title comes fine, its weird..

Looks like it works on chrome 41 https://www.browserling.com/browse/win/7/chrome/41/http%3A%2F%2Fbrasilmaplestory.com
dont you had any problem with website when it was indexed by google? Because when i google you website currently title looks OK.

thanks @radeno and @richardwillars! Open using 41 really shows the error.
@radeno the homepage has no error.. The page /cashshop and others are pages that doesnt work. Closing this issue because looks like it's my fault, but for everyone having this problem, just try Chrome 41

I was using the array find method, that wasn't supported by chrome 41. Only added a polyfill and the problem is gone

Hi,
I have got the exactly same problem.
First my title is ok but after it's replaced but an unexpeted error, look at that : https://www.browserling.com/browse/win/7/chrome/41/https://vetolib.vet
Thanks you so much

@davzer27 The error displayed on my page was related to the use of Array.find function that was not supported by chrome in this version. I fixed by adding a polyfill.
_app.jsx
import '../src/helpers/find.polyfill';
......

src/helpers/find.polyfill
Array.prototype.find = Array.prototype.find || function (callback) {
  if (this === null) {
    throw new TypeError('Array.prototype.find called on null or undefined');
  } else if (typeof callback !== 'function') {
    throw new TypeError('callback must be a function');
  }
  var list = Object(this);
  // Makes sures is always has an positive integer as length.
  var length = list.length >>> 0;
  var thisArg = arguments[1];
  for (var i = 0; i < length; i++) {
    var element = list[i];
    if (callback.call(thisArg, element, i, list)) {
      return element;
    }
  }
};

I added @babel/polyfill and fixed most of the error.
Then I added a custom polyfill.js to polyfill NodeList.forEach and url-polyfill for URL Object;
Here's the code,
/.babelrc
{
    "presets": [
        [
            "@babel/preset-env",
            {
                "targets": {
                   "chrome": "41"
                },
                "useBuiltIns": "entry"
            }
        ]
    ],
}

src/helpers/polyfill.js
// NodeList.forEach polyfill
if (typeof window !== "undefined") {
  if (window.NodeList && !NodeList.prototype.forEach) {
    NodeList.prototype.forEach = Array.prototype.forEach;
  }
}

pages/_app.js
import "helpers/polyfill";
import "@babel/polyfill";
import "url-polyfill";

If this still doesn't solve your problem, I recommend you to checkout https://polyfill.io/v3/url-builder and find your polyfill function.


Fix Puppet error on Integration

https://trello.com/c/sc2PLcNR/984-whos-fixing-me-ckan-upstart-not-up-in-integration
Error: /Stage[main]/Govuk_solr::Config/Service[jetty]: Could not evaluate: Could not find init script or upstart conf file for 'jetty'
Previously we still defined a 'service' resource even when the
associated init file was absent, which lead to an error. This
avoids defining the service unless its config is present, the
only downside being an attempt to remove disable jetty may leave
an old process running, which seems like a niche scenario.

Ah but I don't have approval permission anymore


chore(deps): update spring core to v3.2.18.release

This PR contains the following updates:

Package
Update
Change
References

org.springframework:spring-webmvc
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-web
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-test
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-core
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-context-support
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-context
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

org.springframework:spring-beans
minor
3.1.4.RELEASE -> 3.2.18.RELEASE
homepage, source

Release Notes

spring-projects/spring-framework
v3.2.18.RELEASE
Compare Source
:star: New Features

Allow method inlining of ObjectUtils.nullSafeEquals() [SPR-14349]#18921
Normalize resource URL in ResourceServlet [SPR-14946]#19513
ModelAndViewResolver still refers to raw Class type [SPR-7860]#12517

:beetle: Bug Fixes

Constructor sets the source incorrectly in org.springframework.beans.PropertyValue [SPR-8337]#12985
ObjectToObjectConverter should be able to use constructors on non-public classes [SPR-14304]#18876
Async advisor retrieval blocks when triggered by singleton init method [SPR-14324]#18896
Deadlock while creating a new thread on bean initialization with transactional code invocation [SPR-14388]#18961
CronSequenceGenerator causes StackOverflowError with reversed range values [SPR-14462]#19031
Ineffective synchronization in StandardTypeConverter constructor [SPR-14465]#19034
ResourcePatternUtils.getResourcePatternResolver does not accept null arg [SPR-14500]#19069
LinkedCaseInsensitiveMap doesn't override HashMap.clone() [SPR-14509]#19078
StackOverflowError for advisor search against factory-bean reference to FactoryBean [SPR-14551]#19119
StringUtils.parseLocaleString(): does not parse locale string in java 7 for Serbian (Latin) [SPR-14718]#19283
Concurrency problem in DeferredResult: potential double execution of handleResult [SPR-14978]#19544
MBeanExporter fails against null beans [SPR-15031]#19598

:notebook_with_decorative_cover: Documentation

Ambiguous sentence in the cache documentation [SPR-14399]#18017
SpEL and Date Literals [SPR-14987]#19553

v3.2.17.RELEASE
Compare Source
:star: New Features

SimpleTriggerFactoryBean and CronTriggerFactoryBean fail without jobDetail [SPR-13604]#18182
Prevent Quartz XSD from being fetched from the Internet [SPR-13706]#18281
Backport MVC config path config options to 3.2.x [SPR-14186]#18757

:beetle: Bug Fixes

Handle RejectedExecutionException in WebAsyncManager [SPR-13836]#18409
NullPointerException while building error message in InvocableHandlerMethod  [SPR-13917]#18491
ReflectiveMethodResolver chooses parent class over child for static methods [SPR-13918]#18492
AbstractMarshaller's DocumentBuilderFactory instance may be used by several threads simultaneously [SPR-13935]#18507
TimerManagerTaskScheduler.TimerScheduledFuture.getDelay is inverted [SPR-13977]#18549
Scripted beans not updated after a script compilation error in getScriptedObjectType [SPR-14007]#18579
ModelAndView is replaced when a RedirectView is used [SPR-14045]#18617
@RequestHeader HttpHeaders fails with NPE against null header value [SPR-14091]#18663
NPE thrown when calling methods with an empty @Caching annotation [SPR-14162]#18734
Deadlock possible with AspectJ aspects and multi-threading [SPR-14241]#18814
AbstractRequestLoggingFilter appends null query string [SPR-14244]#18817

:notebook_with_decorative_cover: Documentation

wrong example given at section 17.4 Handler mappings [SPR-13832]#18405
@EnableScheduling javadoc has incomplete XML example [SPR-14145]#18717

v3.2.16.RELEASE
Compare Source
:star: New Features

Skip Content-Disposition header when status != 2xx [SPR-13588]#18165
Avoid NPE for anonymous SqlParameter in CallMetaDataContext [SPR-13628]#18206
Content-Disposition with fixed file name "f.txt" causes confusion [SPR-13643]#18220
Revisit BeansException warn logging after startup failure [SPR-13663]#18238
BeanFactoryAnnotationUtils.qualifiedBeanOfType should not instantiate all beans of given type before checking qualifier [SPR-13741]#18314
Support for Microsoft SQL Server driver version 4 and above [SPR-13772]#18346

:beetle: Bug Fixes

Content-Disposition header causes download in browser for Spring Boot Actuator endpoints [SPR-13587]#18164
AbstractJdbcCall's compiled variable should be declared as volatile [SPR-13617]#18195
Content-Disposition added for @ResponseBody methods explicitly mapped to ".html" or other extensions [SPR-13629]#18207
CommonsMultipartFile.getOriginalFilename() does not strip file path properly [SPR-13662]#18237
AbstractApplicationContext.isRunning throws IllegalStateException when called too early [SPR-13667]#18242
Jdbc4SqlXmlHandler should return null as documented (instead of throwing NPE) [SPR-13782]#18356

:notebook_with_decorative_cover: Documentation

Fix cron trigger example in reference documentation [SPR-10474]#15107

v3.2.15.RELEASE
Compare Source
:star: New Features

Avoid ambiguous property warning for setter methods with multiple parameters [SPR-13349]#17933
Protect against RFD exploits [SPR-13548]#18124

:beetle: Bug Fixes

ConcurrentModificationException when doing a merge on AbstractEnvironment [SPR-13213]#17805
DeferredResult not thread-safe for isSetOrExpired call [SPR-13451]#18031
AbstractEmbeddedDatabaseConfigurer.shutdown does not close JDBC resources [SPR-13474]#18053
JCacheCache doesn't recognize null values in other JVMs [SPR-13553]#18129
Clarify whether HttpInputMessage.getBody() is allowed to return null [SPR-13563]#18139

:notebook_with_decorative_cover: Documentation

Misleading note on readonly and disabled flags in spring-form.tld [SPR-13397]#17977
Documentation for Portlet MVC does not refer to Portlet 2.0 spec (JSR-286) [SPR-13513]#18090

v3.2.14.RELEASE
Compare Source
:beetle: Bug Fixes

@Scheduled no longer works in case of multiple proxied target classes implementing the same interface [SPR-12709]#17306
ServletUriComponentsBuilder#initFromRequest can cause NPE [SPR-12723]#17320
Deadlock publishing event while creating listener bean [SPR-12739]#17336
Specified MVC resource at root level not considered "under location" [SPR-12747]#17344
EncodedResource does not include charset in equals() implementation [SPR-12767]#17364
StandardMultipartHttpServletRequest.StandardMultipartFile not serializable [SPR-12795]#17392
Incorrect value in InvalidPropertyException message from BeanWrapperImpl.setPropertyValue [SPR-12866]#17464
CronSequenceGenerator constructor goes into infinite loop with invalid increments [SPR-12871]#17469
PatternMatchUtils infinite loop bug [SPR-12971]#17563
CustomBooleanEditor may run into NPE when configured with allowEmpty=false [SPR-13010]#17601
NPE for alias resolved to null in SimpleAliasRegistry [SPR-13016]#17607
Remoting over JMS with receiveTimeout blocks service forever [SPR-13052]#17644
When use a @args as pointcut, there is case that occur a NPE at calling the unrelated method [SPR-13102]#17693
XML input vulnerability based on DTD declaration [SPR-13136]#17727
SpEL chooses wrong method to invoke when varargs method is present [SPR-12803]#17400

:notebook_with_decorative_cover: Documentation

Documentation error in "SimpleJdbcInsert" section [SPR-12639]#17240
Consider rewording ack modes on the listener container javadocs [SPR-12705]#17302

v3.2.13.RELEASE
Compare Source
:star: New Features

Consistent bridge method handling in annotation post-processors [SPR-12495]#17101

:beetle: Bug Fixes

Java 8 bridge method handling can lead to false positive detection of autowired annotations [SPR-12187]#16801
webjar stops working [SPR-12432]#17038
Introspection with BeanUtils started failing against java.awt.Window [SPR-12434]#17039
NPE in org.springframework.core.MethodParameter.getParameterName (possible race condition) [SPR-12453]#17058
Unable to initialize WebAsyncTask with executorName [SPR-12457]#17062
SpEL: problem with static methods conflicting with instance methods [SPR-12502]#17107
Prototype with changing bean class does not get populated with dependencies after type switch [SPR-12526]#17131
Performance - hashCode method of AbstractFallbackTransactionAttributeSource.DefaultCacheKey doesn't take targetClass into account [SPR-12536]#17141
AbstractApplicationEventMulticaster "lost" application listener [SPR-12545]#17148
Duplicated interceptors in HandlerExecutionChain after intermediate getInterceptors() call [SPR-12566]#17167
When use the same configuration annotation of javaconfig, does not work on spring 3.2.12 [SPR-12442]#17047
Embedded derby database uses derby.log [SPR-12437]#17042

:notebook_with_decorative_cover: Documentation

Misleading documentation for SqlRowSet [SPR-12476]#17082
Update documentation after SPR-3542 [SPR-12570]#17171

v3.2.12.RELEASE
Compare Source
:star: New Features

Log warning for single optional constructor when no default constructor to fall back to [SPR-12161]#16775
HttpHeaders should accept empty Content-Type header [SPR-12173]#16787
Scheduled/JmsListenerAnnotationBeanPostProcessor needlessly scans every scoped instance [SPR-12189]#16803
Spring HTTP clients do not enforce RFC 6265 (cookies in a single header) [SPR-12196]#16810
Make MockRestServiceServer error messages more descriptive [SPR-12230]#16845
Further locking optimizations for the retrieval of non-singleton beans [SPR-12250]#16864
Log context cache statistics in the TestContext framework [SPR-12409]#17017

:beetle: Bug Fixes

@Qualifier resolution fails with Spring Batch parent/child context arrangement [SPR-12191]#16805
org.springframework.context.support.LiveBeansView.generateJson(Set) generates invalid JSON when resources already double-quoted [SPR-12252]#16866
Web Async responses force concurrentResult.toString() call [SPR-12253]#16867
DataSourceTransactionManager closes JDBC connection on doBegin failure but leaves it attached to transaction object [SPR-12280]#16885
Provider<...> declaration for @Value method argument fails with TypeMismatchException [SPR-12297]#16903
Private @Scheduled methods end up on 'empty' proxy instance in case of CGLIB auto-proxying [SPR-12308]#16913
Directory traversal with static resource handling (CVE-2014-3625) [SPR-12354]#16959
Tiles 2.x: TilesConfigurer NPE when no definitions found [SPR-12362]#16967
ResponseStatusExceptionResolver does not get a MessageSource injected in the MVC Java config [SPR-12380]#16987
ConfigurationClassUtils fails to introspect inner classes with dot name syntax (and silently ignores it) [SPR-12390]#16998
@Import in another annotation still results in double scan [SPR-12334]#16939
util:map does not recognize the attribute of value-type [SPR-10994]#15622

:notebook_with_decorative_cover: Documentation

ContextLoaderServlet is mentioned in doc, but does not exist [SPR-7725]#12381

v3.2.11.RELEASE
Compare Source
:star: New Features

XmlBeanDefinitionReader runs 10x slower due to resetBeanDefinition check [SPR-8318]#12966
Exceptions thrown during AbstractApplicationContext.refresh() not being logged right when they are caught [SPR-12010]#16626
RestTemplate with InputStreamResource does not work if Content-Length is not set [SPR-12017]#16633

:beetle: Bug Fixes

Injecting EXTENDED @PersistenceContext into JUnit 4 test class causes NoSuchBeanDefinitionException [SPR-8834]#13476
Exception during context refresh swallowed by subsequent LifecycleProcessor exception handling [SPR-10000]#14634
getBean(Object.class) fails when introspecting Environment bean [SPR-10542]#15172
UriComponentsBuilder.fromUriString may not parse correctly when there is no path [SPR-11970]#16586
StaxStreamXMLReader ignores significant whitespace [SPR-12000]#16616
NPE in SelectedValueComparator with null bound value [SPR-12001]#16617
Changes to AbstractApplicationEventMulticaster in 3.2.9 break HttpSessionEventPublisher in Google AppEngine Runtime [SPR-12002]#16618
AbstractMessageListenerContainer#doExecuteListener can cause a dropped message if using CLIENT_ACKNOWLEDGE and the container is stopped and subsequently started again. [SPR-12015]#16631
Tiles 3 TilesViewResolver should allow for custom TilesView subclasses [SPR-12075]#16691
MockMvc security filters causes FileUploadException: the request was rejected because no multipart boundary was found [SPR-12114]#16730
Plain FactoryBean declaration on @Bean method leads to early call (pre injection) [SPR-12141]#16755
CachingConnectionFactory should catch exceptions on logical close [SPR-12148]#16762

v3.2.10.RELEASE
Compare Source
:star: New Features

Misleading exception message for using JPA with custom IsolationLevels [SPR-8325]#12974
Revisit class cache in CachedIntrospectionResults [SPR-11867]#16486
Performance regression for custom autowireBean calls with many properties [SPR-11875]#16494
ReflectionUtils slow down application startup on WebSphere [SPR-11882]#16501
Improve performance of ReflectionUtils.isCglibRenamedMethod [SPR-11894]#16513
Consistent declaration of private static final logger variables [SPR-11905]#16524
Manually registered transaction manager are not recognized by qualifiedBeanOfType [SPR-11915]#16534
Unclear error message on BeanPostProcessor returning null [SPR-11951]#15997

:beetle: Bug Fixes

RequestAttributes in FrameworkPortlet [SPR-11295]#15919
StandardPortletEnvironment is not properly populated [SPR-11816]#16436
isGlobalRollbackOnly always returns 'false' with WebSphereUOWTransactionManager [SPR-11876]#16495
MBeanExportConfiguration.SpecificPlatform never calls afterPropertiesSet() [SPR-11877]#16496
URIComponentsBuilder shares state across calls of .build() [SPR-11885]#16504
Spring 3.2.9 breaks JBoss EAP 5.1.1 VFS compatibility [SPR-11887]#16506
HttpHeaders fails to return getAllow() if it was previously set to an empty collection [SPR-11917]#16536
Objects created by FactoryBeans might get processed multiple times by BeanPostProcessors if beans are created lazily [SPR-11937]#16554
Backward compatibility issue in RestTemplate's messageConverters after SPR-11351 [SPR-11962]#16578
Java 8: ASM5 visitors required for parsing INVOKESPECIAL/STATIC on interfaces [SPR-11979]#16595

:notebook_with_decorative_cover: Documentation

Dead link to "MVC application step-by-step" guide [SPR-11935]#16552

v3.2.9.RELEASE
Compare Source
:star: New Features

Overriding bean definition message does not take parent definition into account [SPR-9671]#14305
CollectionToCollectionConverter.convert() improvement for untyped collections [SPR-11479]#16104
Treat empty log config refresh interval as infinite interval in Log4jWebConfigurer [SPR-11507]#16132
Improve exception message for failed property access in SpEL [SPR-11535]#16160
ResizableByteArrayOutputStream and ByteArrayOutputStream capacities [SPR-11594]#16218
MarshallingView should avoid temporary byte array when copying to response [SPR-11646]#16269
Fix/optimize handling of @Bean method override regression with return type narrowing on JDK 8 [SPR-11718]#16340
Metadata reading should never use ASM for java._ and javax._ types (in particular on JDK 8) [SPR-11719]#16341
AbstractAdvisingBeanPostProcessor.isEligible(…) does not consider proxy interfaces [SPR-11725]#16347
StandardServletMultipartResolver should support lazy resolution along the lines of CommonsMultipartResolver [SPR-11730]#16352
AbstractMarshaller should avoid SAXSource workaround when processExternalEntities=true [SPR-11737]#16359
Improve prefix detection in StringUtils.cleanPath [SPR-11793]#16414
ConfigurationClassParser.invokeAwareMethods(…) does not consider EnvironmentAware [SPR-11744]#16366
Basic Java 8 bytecode compatibility for Spring 3.2.x through ASM 5.0.2 [SPR-11656]#16279

:beetle: Bug Fixes

Java config FactoryBean proxy causes class loader leak [SPR-9274]#13912
Unsafe fallback pointcut construction in AspectJExpressionPointcut [SPR-9335]#13973
Servlet 3 multipart parameter binding does not work on Weblogic12c (<IP_ADDRESS>) [SPR-11074]#15700
double evaluation of method arguments in SpEL [SPR-11445]#16071
XmlValidationModeDetector: length of a string is always greater than index of any of its characters [SPR-11477]#16102
SpringBeanELResolver - setValue throws PropertyNotWritableException [SPR-11502]#16127
Unable to retrieve FlashMap when target parameters are encoded [SPR-11504]#16129
Default KeyGenerator doesn't work for methods with arguments of array types [SPR-11505]#16130
Spring MVC Test can fail to obtain async result due to timing issue [SPR-11516]#16141
ConstructorResolver will generate NPE in case of no factory method found when there are explicit args [SPR-11517]#16142
Memory leak when using annotation based auto-wiring in child context [SPR-11520]#16145
Providing unique names to prototype inner beans causes excessive memory and CPU use [SPR-11545]#16170
BufferedImageHttpMessageConverter fails if JAI is installed [SPR-11581]#16205
Log Forging in DispatcherServlet via requestURI [SPR-11591]#16215
AbstractApplicationEventMulticaster can leak classes [SPR-11606]#16229
Referencing static field of class that extends Map in expression language causes class cast exception [SPR-11609]#16232
Servlet mocks are not reinjected into test instance between TestNG test methods [SPR-11626]#16249
ResourceHttpRequestHandler not closing Resource's input stream [SPR-11644]#16267
UrlResource.exists() does not properly detect JBoss vfszip resources [SPR-11676]#16299
ConcurrentReferenceHashMap doesn't limit upper concurrency level [SPR-11720]#16342
SpringProperties: the ClassLoader might be null, if class is loaded by the bootstrap class loader [SPR-11721]#16343
If-Modified-Since header is parsed as HTTP-date; but IE 10 sends length [SPR-11727]#16349
JRubyScriptUtils fails against JRuby 1.7.12 with NullPointerException in findClassNode [SPR-11747]#16369
IdToEntityConverter throws Access Denied exception within Spring MVC application on WebSphere 8.x [SPR-11758]#16380
Protect against security exploits via system identifier in DTD declaration [SPR-11768]#16390
JDBC findColumn gives wrong result in case of duplicate column labels [SPR-11786]#16408
SPR-10829: Spring JMS problem with Oracle AQ still exists if underlying DataSource is decorated [SPR-11791]#16412
getTestExecutionListeners() doesn't detect NoClassDefFoundError within BeanInstantiationException [SPR-11804]#16424
StringUtils.parseLocaleString: locale variant cannot contain country code [SPR-11806]#16426

v3.2.8.RELEASE
Compare Source
:star: New Features

Improve error reporting for issues related to @Controller types requiring AOP proxing [SPR-11281]#15905
Consistently avoid close() call on Servlet OutputStream [SPR-11413]#16040
MarshallingView should explicitly skip BindingResult when searching for a model object [SPR-11417]#16044
Minor CompositeCacheManager revision [SPR-11427]#16053

:beetle: Bug Fixes

Method injection causes memory leak [SPR-10785]#15411
Velocity springFormCheckboxes macro does not check preselected items correctly [SPR-10837]#15463
URLs containing %2F (forward slash) are not mapped correctly to @RequestMapping methods [SPR-11101]#15727
LiveBeansView generates invalid JSON on specific case [SPR-11366]#15992
StringIndexOutOfBoundsException in AbstractErrors for class-level JSR-303 validator [SPR-11374]#16001
Jaxb2RootElementHttpMessageConverter is susceptible to XXE vulnerability [SPR-11376]#16003
Potential ClassCastException in RequestContextListener when destroying the request object [SPR-11378]#16005
Fix off-by-one regression in AbstractMethodMockingControl [SPR-11385]#16012
PreparedStatement#getParameterMetaData() calls may trigger unwanted side effects [SPR-11386]#16013
aop:scoped-proxy may fail with LinkageError: loader attempted duplicate class definition for name [SPR-11398]#16025
EhCacheCacheManager does not wrap runtime-registered caches with TransactionAwareCacheDecorator [SPR-11407]#16034
MarshallingView should not close response output stream  [SPR-11411]#16038
Inclusion of 'overloaded' in equals() and hashCode() for MethodOverride breaks equals() in AbstractBeanDefinition [SPR-11420]#16047
resolveFactoryMethodIfPossible should consider nonPublicAccessAllowed flag and SecurityManager scenario [SPR-11422]#16049
Objects with multi-threaded access should not lazily populate a hash field [SPR-11428]#16054
Memory leak in ConcurrentReferenceHashMap [SPR-11440]#16066

:notebook_with_decorative_cover: Documentation

Broken link into documentation section 21.5.3  [SPR-11404]#16031

v3.2.7.RELEASE
Compare Source
:star: New Features

JMSTemplate setDeliveryPersistent(boolean deliveryPersistent)  javadoc incorrect [SPR-3983]#8663
Improve the performance of BeanInfo lookups in CachedIntrospectionResults [SPR-9014]#13653
CronTriggerFactoryBean doesn't allow calendar name and description to be specified [SPR-9771]#14405
Provide access to SimpleTriggerFactoryBean property startTime [SPR-10940]#15568
better method identification in AnnotationTransactionAttributeSource logging [SPR-11267]#15892
Add patch() to MockMvcRequestBuilders [SPR-11299]#15923
Optimize lookup of field errors in AbstractBindingResult [SPR-11304]#15928
Provide a mechanism for adding ApplicationContextInitializers to DispatcherServlet's ApplicationContext [SPR-11314]#15938
Add control of what HTTP Request method AbstractFileResolvingResource methods exists, lastModified and lastModified uses on http url resources [SPR-11320]#15944
Bootstrapping the EntityManagerFactory should log the name of the persistence unit being used [SPR-11333]#15957
Reduce footprint due to RootBeanDefinition [SPR-11343]#15967
Unnecessary class loading in AspectJ RuntimeTestWalker [SPR-11344]#15968
Provide alternative RestTemplate constructor to avoid default MessageConverter creation [SPR-11351]#15976
Compatibility with JOpt 4.6 [SPR-11359]#15985

:beetle: Bug Fixes

Fix @Bean meta-annotation detection when using ASM [SPR-10488]#15121
theme resolution fails with "IllegalArgumentException: Basename must not be empty" when an empty theme value is provided via request url [SPR-11128]#15754
context:component-scan element says error in the mvc-cofig.xml [SPR-11221]#15846
Backward compatibility of BeanUtils.copyProperties broken for copying wrapped types to primitive types (and vice versa) on 3.2.6 and 4.0.0 [SPR-11231]#15856
Regression: InjectionMetadata cache needs to handle different bean classes per bean name [SPR-11246]#15871
XMLEventStreamWriter fails to handle writeEmptyElement() followed by writeAttribute() [SPR-11254]#15879
EhCacheFactoryBean should not call set(Sampled)StatisticsEnabled on EhCache 2.7/2.8 [SPR-11265]#15890
@Async with cglib based proxy causes memory leak in heap [SPR-11275]#15899
@Async with cglib based proxy causes memory leak in permgen [SPR-11276]#15900
Full Quartz 2.2 compatibility, including LocalDataSourceJobStore [SPR-11284]#15908
StandardEnvironment's system environment access produces warning with stacktrace on WebSphere [SPR-11297]#15921
Bad type comparison in ReflectionHelper.getTypeDifferenceWeight(List paramTypes, List argTypes) [SPR-11306]#15930
ServletWebRequest.checkNotModified() methods should treat HEAD identically to GET [SPR-11317]#15941
Wrong assert in  AspectJAwareAdvisorAutoProxyCreator.setAspectJAdvisorFactory() [SPR-11330]#15954
ServletTestExecutionListener is not enabled by default in abstract base test classes [SPR-11340]#15964
PlaceholderConfigurerSupport.doProcessProperties() loses stack trace on exception [SPR-11346]#15970
Handle NoClassDefFoundError for TestExecutionListeners consistently in the TestContext framework [SPR-11347]#15971
AbstractAnnotationConfigDispatcherServletInitializer does not allow consolidating all configuration into the "root" context [SPR-11357]#15982
BeanWrapper fails in case of read/write method mismatch (e.g. EhCacheFactoryBean.setMemoryStoreEvictionPolicy) [SPR-11361]#15987
SchedulerAccessor 'globalJobListeners' and 'globalTriggerListeners' not working with 2.0.x and 2.1.x [SPR-11362]#15988
CompoundClassLoader.loadClass is trying to load some framework class and comsuming all web container threads. [SPR-11499]#16124
StatementCreatorUtils introduces java 1.6 dependency [SPR-11349]#15974
NoClassDefFoundError with Spring 3.2.7.BUILD-SNAPSHOT on WebSphere 6.1 [SPR-11341]#15965
Downgrade accidental use of Java 1.6 APIs [SPR-11321]#15945
spring-jdbc-3.2.6.RELEASE doesn't support JDK 5. [SPR-11313]#15937
@Enable registrars invoked with subclass for annotation placed on superclass (3.2.x) [SPR-11251]#15876

v3.2.6.RELEASE
Compare Source
:star: New Features

Expression evaluator should accept raw collection value for parameterized method argument [SPR-7831]#12487
Map "Foreign key constraint violation occurred" Sybase error code to DataIntegrityViolationException [SPR-11097]#15723
Minor issue with fix for CVE 2010-1622 [SPR-11098]#15724
Add Maven 'bill-of-materials' project for 3.2.x [SPR-11204]#15512

:beetle: Bug Fixes

In spring MVC portlet, @resourceMapping doesn't work. [SPR-10791]#15417
Security vulnerabilities in Spring v2.5.6 and v3.2.4 [SPR-10912]#15540
Remove integer conversion in JmsListenerContainerParser [SPR-10986]#15614
MBeanExporter/MBeanRegistrationSupport lack synchronization [SPR-11002]#15630
Use StoredProcedure to call sp, if not set the rowmapper for out parameter which type is cursor, will throw null pointer exception [SPR-11076]#15702
ClassPathScanningCandidateComponentProvider.findCandidateComponents fails on private meta-attributes [SPR-11091]#15717
If the !profile selector is used the other profiles can be ignored in  [SPR-11093]#15719
performancedrop due to repeated JDBC 3.0 getParameterType calls in setNull in StatementCreatorUtils [SPR-11100]#15726
"CglibAopProxy: Unable to proxy method" WARN when bean class contains static final method [SPR-11107]#15733
Type resolution fails for uninitialized factory-method declaration [SPR-11112]#15738
Cannot autowire qualified scoped-proxy @Bean definitions [SPR-11116]#15742
Dependency Injection issue when using ManagedMap or ManagedList in BeanDefinitionParser [SPR-11131]#15757
Fix tests related to java.beans.BeanInfo changes in JDK8-b117 [SPR-11139]#15765
ServletTestExecutionListener breaks old code [SPR-11144]#15771
Recently changes of GenericTypeAwarePropertyDescriptor breaks BeanUtils.copyProperties() [SPR-11209]#15834
ReflectivePropertyAccessor should not consider "is" methods with non boolean returns [SPR-11142]#15768
Support multiple comma-separated values in X-Forwarded-Host header [SPR-11140]#15766
EhCacheFactoryBean.afterPropertiesSet should be synchronized [SPR-11132]#15758
Spring caching: combining multiple @Cacheable within @Caching annotation doesn't work [SPR-11124]#15750
EhCacheFactoryBean fails when statistics are enabled [SPR-11080]#15706

v3.2.5.RELEASE
Compare Source
:star: New Features

Disable the processing of external entities in SourceHttpMessageConverter by default [SPR-11078]#15704
Avoid unnecessary char[] allocation in NamedParameterUtils [SPR-11042]#15670
Spring doesn't parse jndi variables default values to match the expected-type [SPR-11039]#15667
Methods in AnnotationConfigUtils.processCommonDefinitionAnnotations(…) should be public [SPR-11032]#15660
PropertyOrFieldReference suffers from potential NullPointerException [SPR-11031]#15659
ClassPathBeanDefinitionScanner INFO logging on JSR 330 [SPR-10974]#15602
Make createRequestMappingInfo in RequestMappingHandlerMapping protected [SPR-10950]#15578
Add XStream CatchAllConverter [SPR-10821]#15447
Order of values in @PropertySource annotation depends on name attribute [SPR-10820]#15446

:beetle: Bug Fixes

Cannot override singleton with scoped proxy [SPR-10744]#15370
ClasspathXmlApplicationContext does not inherit/merge parent context environment [SPR-11068]#15695
MockHttpServletRequestBuilder not handling parameter without value [SPR-11043]#15671
@Autowired setter randomly called twice or not called at all when two beans of the same class

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.


voyager implementation with path based navigation

Im setting up a compose multiplatform project using Voyager targeting web to start and im not seeing routes be appended to the URL when push()'ing them nor is the screen's defined by path/name navigatable via URL. Is there something i am missing in the config/setup or is my understanding of this incorrect?
val router = routing {
    screen("/home", name = TeaserScreen.key) {
        TeaserScreen
    }

    screen("/form", name = WaitlistFlow.key) {
        WaitlistFlow
    }
}

pushing is done via
LocalVoyagerRouting.current.pushNamed(TeaserScreen.key) or LocalVoyagerRouting.current.push(path ="/home")
I would expect localhost:8080/home to resolve while the server is running. (UI is updating appropriately just not browser paths).

Was able to kang the browser history from js integration into voyagers via
@KtorDsl
public fun Route.screen(body: suspend PipelineContext<Unit, ApplicationCall>.() -> Screen) {
    handle {
        screen {
            body(this)
        }

+       call.handleScreenTransition()
    }
}

+ expect suspend fun ApplicationCall.handleScreenTransition()

in my jsMain
actual suspend fun ApplicationCall.handleScreenTransition() {
    when (routeMethod) {
        RouteMethod.Push -> {
            window.history.pushState(
                title = "routing",
                url = uri,
                data = serialize()
            )
        }
        RouteMethod.Replace -> {
            window.history.replaceState(
                title = "routing",
                url = uri,
                data = serialize(),
            )
        }
        RouteMethod.ReplaceAll -> {
            while (true) {
                window.history.replaceState(
                    title = "",
                    url = null,
                    data = null,
                )
                window.history.go(-1)
                val forceBreak =
                    runCatching {
                        withTimeout(1_000) {
                            suspendCoroutine { continuation ->
                                window.onpopstate = { event ->
                                    val state = event.state.deserialize()
                                    continuation.resume(state == null)
                                }
                            }
                        }
                    }.getOrDefault(true)
                if (forceBreak) {
                    break
                }
            }

            window.history.replaceState(
                title = "routing",
                url = uri,
                data = serialize(),
            )
        }
    }
}

@Serializable
internal data class JavascriptRoutingState(
    val routeMethod: String,
    val name: String,
    val uri: String,
    val parameters: Map<String, List<String>>,
)

internal fun ApplicationCall.serialize(): String {
    val state =
        JavascriptRoutingState(
            routeMethod = routeMethod.value,
            name = name,
            uri = uri,
            parameters = parameters.toMap(),
        )
    return Json.encodeToString(state)
}

internal fun Any?.deserialize(): JavascriptRoutingState? =
    when (this) {
        is String -> toState()
        else -> null
    }

private fun String.toState(): JavascriptRoutingState? =
    runCatching {
        Json.decodeFromString<JavascriptRoutingState>(this)
    }.getOrNull()

and in my mobileMain (custom group for ios/android)
actual suspend fun ApplicationCall.handleScreenTransition() {}

Nice. I updated the javascript integration to support history modes. Hash /#/, Html5 History and Memory.
Most of these behaviors I will export to voyager integration too.

Checkout release 0.0.15.

Latest releases starting from 0.0.17 should have support.
There is no support for WASM but it will be tracked in another issue.


Feature request: allow bitwise on enums

Actual behavior
no-bitwise doesn't allow bitwise operations on enums.
Expected behavior
I would like to disallow bitwise operations when dealing with variables, but would like to allow them for enum comparisons (flags), much as they are already allowed for union types.
Is this reasonable?

sure, this would make sense as a new rule option called allow-enums

Looks like implementation of this flag might require change base class of this rule from Lint.Rules.AbstractRule to Lint.Rules.TypedRule since we have to know if we a dealing with enums and not other types. This will be breaking change - this rule is in list of recommended and will require --type-check flag after update.
I have an idea how to implement this, but not sure if it is desired change in rule. Probably rule flags might be a better solution.
@adidahiya, @JKillian do we need this changes?

I'm personally against it. For now, my feelings are that we should keep the majority of rules non-type-checked, and especially shouldn't change existing rules to require type-checking.

+1 to @JKillian's thoughts

If you are aware of any other ways to implement this without such breaking change, I'd try to implement it.
As partial solution I can propose two steps:

Add option allow-in-enum-declaration which will allows next operators only inside enum declarations:

Allow << operator if both of operands are number literals (if I'm right it should be available without type checking)
Allow | operator if both of operands are identifiers of this enum members.

Example:
enum Directions {
    Up = 1 << 0,
    Down = 1 << 1,
    Left = 1 << 2,
    Right = 1 << 3,
    Vertical = Up | Down,
    Horizontal = Left | Right
}

Reasoning: I think left shift operator might be more expressive and easy to scan than remembering/typing powers of 2. Bitwise or is usable for combinations.
Also I think that it is possible to implement this without converting to TypedRule.
Personally I like this idea.

Add skip-bitwise-and option to rule.
This will allow to delegate typechecks to new rule (something like enum-bitwice-and) which will extend TypedRule and check if at least one of operands is member of enum.
Also it might check/enforce position (with options like enum-right or enum-left).
This might be not optimal solutions in general. And I don't know if it is possible(reasonable) to make rules combintations.

(Sidenote: it is ok to mention both of you in questions regarding Issues/PRs or better to just leave a comment without mentions if it isn't direct conversation?)

💀 It's time! 💀
TSLint is being deprecated and no longer accepting pull requests for major new changes or features. See #4534. 😱
If you'd like to see this change implemented, you have two choices:

Recommended: Check if this is available in ESLint + typescript-eslint ✅
Not Recommended: Fork TSLint locally 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


custom shape

supported by OpenGlasses2 (custom shapes)
https://minecraft.curseforge.com/projects/openglasses2


Support scaffolding scenario in vscode

Support scaffolding scenario in vscode whose user experience is like "tsp init" in vscode. Vscode would collect information from end user and work with compiler to create new TypeSpec project underneath.
fixes: #4859

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/compiler
:x:typespec-vscode

Show changes

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs

Suggestion to organize the source folder according to the feature: Define a directory new to store all the code for creating a typespec project, in the future, there will be another directory emit for code for emitting

Usually we will organize source in area with suitable granularity, not feature which can be big, small, without clear boundary and so on. For example, if we group by feature here, you will see lots of folders with only one file in it...
Here I have put all vscode-command related files into one folder (one file supports one command now). For the emit feature you are working on, you can create one file in the folder for the emit command, or a sub-folder if you need add many files there. we can have more detail discussion in your change when it's ready. thx.


Consider Renaming Repository/App

Since JoCo Cruise has moved away from using "Sea Monkey" (and "monkey" in general), please consider renaming the repository and app.

This repo (and the app) is basically dead. If I create a new app it'll be called "shipchat".


allow override of default styles

Thank you for making this elm package! It really saved me a lot of time trying to do an auto expanding text box in elm :)
In my project, I am trying to set overflow-y: hidden on my the autoexpand textarea, but i realized that it is not possible. This is because the custom attributes are prepended in front of the default textareaStyles here. This is an example of what I am trying to do. Note the last line where I am trying to override the overflow style.
AutoExpand.config
    { onInput = UpdateInput
    , padding = 0
    , lineHeight = 24
    , minRows = 1
    , maxRows = 10
    }
    |> AutoExpand.withAttribute (Attr.class "input")
    |> AutoExpand.withAttribute (Attr.style "overflow" "hidden hidden")

I am wondering whether there are any reason why the default styles are applied after the custom styles. If not, and with your blessing, I can put up a PR to swap the order such that the custom attributes comes after the default textareaStyles.

The reason is that overriding the styles may cause the auto expand to stop working correctly. Why would you want overflow-y: hidden on the textarea? That would cause the overflow content to not be scrollable.


Everything search engine not active

windows 10: 19042.804
RX Explorer: <IP_ADDRESS> (Paid version)
Everything: <IP_ADDRESS>5
I have fulfilled the required prerequisites to unlock the feature. What am I missing?

I have the same problem. I have installed Everything, but it just can't let me use.

I have the same problem. I have installed Everything, but it just can't let me use.  :(

Confire that is a bug which only in X64 system


Re-visiting the serialization

The current to_vec() method creates the output buffer with Vec::new(), and according to [1]

A new, empty Vec created by the common means (vec![] or Vec::new or Vec::default) has a length and capacity of zero

This would inevitably get to re-allocation and probably repeated re-allocation if the object is large. However, given that we already have a SizeSerializer which can estimate the serialized size in bytes, this could potentially reduce the number of re-allocation.
[1] https://nnethercote.github.io/perf-book/heap-allocations.html?highlight=borrow

In addition, there are places where a temporary buffer is created during the serialization, is it possible to apply a similar technique? Or even better, can these temporary buffers be removed since the reason why most of them are there in the first place was because the serialized format requires a size byte(s) prepended to the actual data.

Or even better, can these temporary buffers be removed since the reason why most of them are there in the first place was because the serialized format requires a size byte(s) prepended to the actual data.

It might be better if this is introduced in a breaking update

Initial experiment shows that this quite significantly degrades serialization performance for primitive types like u8, bool, i8, and char that are only one or two bytes long. Very big improvement was observed for types that of of medium length (4B to 1kB). Surprisingly, for long strings/binary (>= 1MB), the performance seems to remain the same

Or even better, can these temporary buffers be removed since the reason why most of them are there in the first place was because the serialized format requires a size byte(s) prepended to the actual data.

Reserving capacity in buffer somehow negatively impact serializing Vec<u64>

This is interesting, I can't imagine why it would decrease the performance in this way. Just noting here that I'd expect the pre allocation to only improve performance as well.

This is interesting, I can't imagine why it would decrease the performance in this way. Just noting here that I'd expect the pre allocation to only improve performance as well.

That was my expectation as well. I haven't got enough time to investigate further however.


Add "IUGET"

@jordankontio The first verification stage is complete: the official domain for  **INSTITUT UNIVERSITAIRE DES GRANDES ECOLES DES TROPIQUES ** is iuget.cm, to the best of my knowledge. This is just an informational note. The pull request is still under review. The review may take some more time. I greatly appreciate your patience. Here is the proof of domain ownership: https://iuget.cm/contacter-iuget/

@jordankontio Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Support non-spherical ellipsoid voxels

Our preliminary implementation of the ellipsoid voxel shape depended on a few simplifying assumptions. Some of these assumptions broke down for non-spherical ellipsoids, introducing inaccuracies in places like:

Calculation of geodetic latitude.
Computing heights.
The errors were small on a global scale for nearly-spherical ellipsoids (like WGS84). But at smaller scales (<10km) the errors could be significant.

This PR improves the accuracy of ellipsoid math in the voxel shaders. Along the way, some of the code was simplified to remove unused or redundant compiler branches and improve shader readability.

Thanks for the pull request @jjhembd!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


Trees: turn Type.{And, Or} into infix-like trees

Otherwise we can't apply the complex infix formatting to them as the | and & tokens are not represented as separate children within the tree.
Needed by scalameta/scalafmt#3153.

a complete different question: Term.ApplyInfix contains a list arguments for the right-hand side; what does it look like when this list contains multiple items? I am curious why Type infix contains Type on the right, while Term or Pat infix contain a list (instead of also a single, via, say, a Tuple).

That seems to have been done a while ago: https://github.com/scalameta/scalameta/pull/506 and https://github.com/scalameta/scalameta/pull/504
Maybe we could change all occurrences of And/Or to ApplyInfix ? We could then deprecate And and Or in that case.
What do you think?

a complete different question: Term.ApplyInfix contains a list arguments for the right-hand side; what does it look like when this list contains multiple items? I am curious why Type infix contains Type on the right, while Term or Pat infix contain a list (instead of also a single, via, say, a Tuple).

Huh, it seems that list always contains a single param. My guess is that it was added at a different time. We could remove it for 5.0.0, where we would rework a lot of other things.

That seems to have been done a while ago: #506 and #504
Maybe we could change all occurrences of And/Or to ApplyInfix ? We could then deprecate And and Or in that case.
What do you think?

I am very good with this approach! but then the question: what is the purpose of the allowAndTypes dialect flag?

That seems to have been done a while ago: #506 and #504
Maybe we could change all occurrences of And/Or to ApplyInfix ? We could then deprecate And and Or in that case.
What do you think?

I am very good with this approach! but then the question: what is the purpose of the allowAndTypes dialect flag?

Wait, in this case if we don't allowAndTypes aren't they just treated as infix? Then they actually might not have a purpose :O

Just checked, yep they do not serve any purpose.

One possibility might be precedence:  A | B & C | D - related to https://github.com/scalameta/scalameta/issues/2315

On the other hand, do we support precendence currently? Maybe if we solve 2315 then it also solves this situation.

On the other hand, do we support precendence currently? Maybe if we solve 2315 then it also solves this situation.

looks like the question about list and type on the right is once again relevant :)
type infixes are parsed here, and likely simplistically:
https://github.com/scalameta/scalameta/blob/main/scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScalametaParser.scala#L838
whereas term and pat infixes are parsed here (and they do handle precedence):
https://github.com/scalameta/scalameta/blob/main/scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScalametaParser.scala#L1859

looks like the question about list and type on the right is once again relevant :)

Even with precendence why would we need a list here though? There no example in tests that does that for Term.ApplyInfix

@tgodzik removed the trees, deprecated the flags, build passes. PTAL.

Are and/or expressions truly infix? Is there no workaround on the Scalafmt side to avoid this change? I’m ok merging this.

I think there is actually no difference between | / & and normal infix types. It looks like it's a syntactic sugar in essence.
There are not represented differently in the compile
Foo | Bar[Files] is shown as:
tpt = AppliedTypeTree(
              tpt = Ident(name = |),
              args = List(
                Ident(name = Foo),
                AppliedTypeTree(tpt = Ident(name = Bar), args = List(Ident(name = Files)))
              )
            )

There are not represented differently in the compiler

This change sounds good to me in that case 👍


Printing colored text in StaSh

I already understand how to print text all in the same color, but not in multiple colors. How do I combine multiple colored sections of text without the combination of them turning plain white?
For example:
print(_stash.text_color("hello", "red") + _stash.text_color("world", "blue"))

It just turns all of it to white, instead of having a red hello and a blue world.

Nevermind! I just found out about it's escape codes!


Bind key

Were am i able the change the bindkey if the clickgui?

xD

niggs

Were am i able the change the bindkey if the clickgui?

this is a clickgui not a ClickGuiModule


I have deployed the codel-7b-instruct service locally, how do I use it in HF

I have the same problem

You'll have to set the modelIdOrEndpoint configuration setting to the correct URL for your service.
Your model also has to be compatible with text-generation-inference's API (available in the upcoming 0.0.39 release) or Inference API's.

Closing, feel free to re-open if the problem persists


token gated view

added a simple check to see if user owns a nft of a collection.
also added 404 page


Admin page groups

Adds the Group tab to the Administrator Page along with the ability to search groups with pagination.

https://github.com/brainlife/brainlife/issues/146


Could you please approve my model access request? Thank you very much.

Hi Zonglin, sorry I just tried to grant you the access the folders and closed the issue. However, I get notified that we need extra SRT approval to release the pretrained weights now. Let me double check with the law team. Sorry for the inconvenience. Will keep you updated on this.

Thank you for your time. Waiting for your response.


Prevent multiple overwrites to single file

I failed to update the temp paths in the previous PR, when updating to MultiCohort running. Each Cohort was writing a temp file to a per-run temp path. This caused a... too many requests issue?!
https://batch.hail.populationgenomics.org.au/batches/493947/jobs/1
There's only 12 cohorts here, so I'm surprised GCP threw a hissy fit when the file was deleted/replaced 11 times in quick succession. However, I'm glad it broke 😬

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.65%. Comparing base (2a5d0a7) to head (f4252db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   78.65%   78.65%
=======================================
  Files          10       10
  Lines        1785     1785
=======================================
  Hits         1404     1404
  Misses        381      381

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


position-matched array items schema

Hello, I would like to write a schema in which the items of an array have a sub-schema which is determined by their position in the array (this is supported in json-schema 2019-09)
If I write e.g.
components:
  schemas:
    wire:
      type: array
      items:
      - type: integer
      - type: string

In order to specify arrays like [0, "output"], will this work in OAS 3.1.0?

Yes, this will work in OAS 3.1

Note that by OAS 3.1 final (which will use the next JSON Schema draft, assuming all goes according to plan), this will be written as:
components:
  schemas:
    wire:
      type: array
      prefixItems:
      - type: integer
      - type: string

due to ongoing confusion over having two different syntaxes for the items keyword.  prefixItems takes over the array form.  In this case, there is nothing after the two-item "prefix", making the keyword name a little odd, but every single naming approach we came up with was awkward in some way or another, and this is what we settled on.
This should make it a bit easier for tooling, which will not have to inspect the type of the value of items to figure out what it's doing.

Thanks for the detailed reply!  Looking forward to OAS 3.1


Item editor: fix wearable position

this has been fixed in https://github.com/cubzh/cubzh/pull/344


loss=nan ,use my own data

i use my own face datas，and train on my pre-train model,but the loss=nan. i use my own net with your loss layer. i set the bithsize 64 when i  use your code to generate the face LMDB file. i don't know why.
thank you very much!

Hi! I have met the same problem, loss=NAN !
But It is not difficult to solve it!
Just Debug!
Good Luck!

@SummerTrains i know，i have debug  for a long time,but it doesn't work.   so can you explain more detail?

in the code,lifted_structed_softmax_loss.cpp, 0/0 may exist !
however, my loss is still very high, ~11.0 , I think it is still possible to decrease the loss, and I'm still trying !
Good luck for you and me !
At 2016-08-15 11:09:35, "louielu1027"<EMAIL_ADDRESS>wrote:
@SummerTrains i know，i have debug for a long time,but it doesn't work. so can you explain more detail?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Same error in my experiments. I use my own data, inception-v3 network and a pre-trained model trained on ImageNet.
I already tried to decrease the learning rate to a very small value or added a normalization layer before the loss layer, but neither of them works.
I have no idea what's going on.

@BeSlower my QQ:693491925 ,we can discuss this problem together

@BeSlower  in the loss layer implementation,  some numeric problems, for example, 0/0, sqrt(negative value) may exist !
Even though, my loss is still very high!
keep  connection and  discussion!

@louielu1027  @BeSlower  @SummerTrains
Hi, have you guys successfully solved the nan problem?
I want to do metric learning with category-level. Hence I use PASCAL detection dataset(20 classes) and combine the ROIpooling layer. I'm now struggling in using ZF pretrained model.
I add norm2 and modify several code in Lift...cpp to prevent nan,
but like @SummerTrains  said, even not encountering nan problem, the loss won't decrease.
btw, in iteration 17xx, the nan problem still appear...

@daf11865 Hi, have you successfully solved the nan problem? how do you modify the lifted loss.cpp? I also found sqrt(negative value) existed as @SummerTrains said.


Add sentence-level BLEU function to sacrebleu

Adding a function for sentence-level, smoothed BLEU to sacreBLEU. It is currently not used anywhere in the master branch.
Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[x] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
[x] Passed code style checking (./style-check.sh)
[x] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mjpost

LGTM too (might be good to add the sacrebleu tag for ease of future searching).


Fixes a bug when the replaceable string contains a dollar sign

While trying to deploy mu, we found that if a PR contains a dollar sign, the template engine was failing.
I've reproduced the error. The problem is that the dollar sign is interpreted by the replaceAll method as a substitution of a group, a group that doesn't exist in the regex used:
private[this] def replacementPattern(key: String): Regex = s"\\{\\{$key\\}\\}".r

@juanpedromoreno it could be worthy, not sure if there is planned a release soon.
@JesusMtnez @pepegar thoughts?


Improvements and fixes for systemd unbound.service

Remove ProtectKernelTunables=true: This prevents various with socket options from working as shown below.
unbound[] warning: so-rcvbuf 1048576 was not granted. Got 425984. To fix: start with root permissions(linux) or sysctl bigger net.core.rmem_max(linux) or kern.ipc.maxsockbuf(bsd) values.
Add CAP_NET_ADMIN to available caps which is needed for ip-transparent: yes config option to work as shown below.
unbound[] warning: setsockopt(.. IP_TRANSPARENT ..) failed: Operation not permitted
Make ReadWritePaths less permissive: UNBOUND_SYSCONF_DIR equals to sysconfdir which usually equals to /etc and UNBOUND_LOCALSTATE_DIR equals to localstatedir which usually equals to /var. Allowing write access for those dirs shouldn't be needed. The only dirs unbound should be allow to write to are /run ( for pidfile), @UNBOUND_RUN_DIR@ (for chroot) and @UNBOUND_CHROOT_DIR@ in case it differs from the previous one.
Bind-mount /run/systemd/notify, UNBOUND_PIDFILE, /dev/log, /dev/urandom in order to use them inside chroot.
Add few extra hardening options: RestrictNamespaces, LockPersonality and RestrictSUIDSGID should be safe to use.

@wcawijngaards

Thanks for the improvements! Merged it.


OCaml versions are not set correctly

It seems that setup-ocaml is always using the latest version of OCaml, no matter which version is passed in ocaml-version. See this run for instance: https://github.com/rgrinberg/opium/runs/1465857399
The OCaml version setup by the setup-ocaml is 4.10.1, but the next step, which prints the version of the compiler with opam exec -- ocaml --version, tell us that we're still using 4.11.1.
I don't think I'm doing anything special, apart from caching the ~/opam directory, but the key is set to v1-${{ runner.os }}-opam-${{ matrix.ocaml-version }}-, so it should not have an impact on the OCaml version.
EDIT: I disabled the cache, and the OCaml version is set correctly, so it seems related to caching ~/opam. Since the key depends on the ocaml version, the only difference I see is the use of opam switch set ... vs opam switch create .... Is it possible the former does not set the environment correctly for the next steps?

Turns out, I used --unlock-base to install the dependencies from the lock file with different OCaml version, but this caused opam to upgrade the ocaml-compiler in the switch. Using --ignore-constraints-on=ocaml instead solves the issue.


[Batch] Update CODEOWNERS

Updating CODEOWNERS to reflect the current team responsible for the Java SDK

/check-enforcer override


Update Error with SAML Backend

Made today docker-compose down; docker-compose pull; docker-compose up -d but
PHP Fatal error:  Class OCA\User_SAML\UserBackend contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Authentication\IApacheBackend::getLogoutUrl) in /apps2/user_saml/lib/userbackend.php on line 34
Error seems to be the same as in https://github.com/nextcloud/server/issues/6501
Output of docker exec -ti nextcloud_glegal occ upgrade error as above:
PHP Fatal error:  Class OCA\User_SAML\UserBackend contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\Authentication\IApacheBackend::getLogoutUrl) in /apps2/user_saml/lib/userbackend.php on line 34
Any suggestion?
Regards
Enrico

Find this workaround
docker exec -ti <nextcloud_istance> occ app:user_saml disable
docker exec -ti nextcloud_glegal occ upgrade
docker exec -ti nextcloud_glegal occ maintenance:mode --off
Module user_saml is disabled and upgrade will end up well


Calls like UsingTemplateFromEmbedded should use the RazorLight engine instead of EmbeddedResourceHelper.GetResourceAsString

Because of this: https://github.com/lukencode/FluentEmail/blob/master/src/FluentEmail.Core/Email.cs#L306
This goes basically unused. https://github.com/lukencode/FluentEmail/blob/master/src/Renderers/FluentEmail.Razor/RazorRenderer.cs#L35
This is because the RazorRenderer implementation in FluentEmail treats all templates a strings.
We need methods like ParseAsync but that defer to RazorLight like ParseEmbeddedAsync which would call CompileRenderAsync which takes a namespace.
Ref https://github.com/lukencode/FluentEmail/pull/240

Here is a simple implementation, we could include this in the code.
namespace YourApp
{
    using System;
    using System.Threading.Tasks;
    using FluentEmail.Core.Interfaces;
    using RazorLight;

    /// <summary>
    /// Very similar to RazorRenderer but for RazorLight configured to use embedded resources.
    /// </summary>
    public class EmbeddedRazorRenderer : ITemplateRenderer
    {
        private readonly RazorLightEngine engine;

        /// <summary>
        /// Initializes a new instance of the <see cref="EmbeddedRazorRenderer"/> class.
        /// Configures RazorLight to use a project whose persistent store an assembly manifest resource stream.
        /// </summary>
        /// <param name="embeddedResRootType">Any type in the root namespace (prefix) for your assembly manifest resource stream.</param>
        /// <remarks>Docs borrowed from RazorLight UseEmbeddedResourcesProject.</remarks>
        public EmbeddedRazorRenderer(Type embeddedResRootType)
        {
            this.engine = new RazorLightEngineBuilder()
                .UseEmbeddedResourcesProject(embeddedResRootType)
                .UseMemoryCachingProvider()
                .Build();
        }

        /// <inheritdoc/>
        public async Task<string> ParseAsync<T>(string template, T model, bool isHtml = true) => await this.engine
            .CompileRenderAsync(template, model)
            .ConfigureAwait(false);

        /// <inheritdoc/>
        [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "VSTHRD002:Avoid problematic synchronous waits", Justification = "This is required to satisfy ITemplateRenderer implemenation")]
        public string Parse<T>(string template, T model, bool isHtml) => this.ParseAsync(template, model, isHtml)
            .GetAwaiter()
            .GetResult();
    }
}

Here is a simple implementation, we could include this in the code.
namespace YourApp
{
    using System;
    using System.Threading.Tasks;
    using FluentEmail.Core.Interfaces;
    using RazorLight;

    /// <summary>
    /// Very similar to RazorRenderer but for RazorLight configured to use embedded resources.
    /// </summary>
    public class EmbeddedRazorRenderer : ITemplateRenderer
    {
        private readonly RazorLightEngine engine;

        /// <summary>
        /// Initializes a new instance of the <see cref="EmbeddedRazorRenderer"/> class.
        /// Configures RazorLight to use a project whose persistent store an assembly manifest resource stream.
        /// </summary>
        /// <param name="embeddedResRootType">Any type in the root namespace (prefix) for your assembly manifest resource stream.</param>
        /// <remarks>Docs borrowed from RazorLight UseEmbeddedResourcesProject.</remarks>
        public EmbeddedRazorRenderer(Type embeddedResRootType)
        {
            this.engine = new RazorLightEngineBuilder()
                .UseEmbeddedResourcesProject(embeddedResRootType)
                .UseMemoryCachingProvider()
                .Build();
        }

        /// <inheritdoc/>
        public async Task<string> ParseAsync<T>(string template, T model, bool isHtml = true) => await this.engine
            .CompileRenderAsync(template, model)
            .ConfigureAwait(false);

        /// <inheritdoc/>
        [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "VSTHRD002:Avoid problematic synchronous waits", Justification = "This is required to satisfy ITemplateRenderer implemenation")]
        public string Parse<T>(string template, T model, bool isHtml) => this.ParseAsync(template, model, isHtml)
            .GetAwaiter()
            .GetResult();
    }
}


Cannot read property 'string' of undefined

I have this error when I click on the column to sort:
stupidtable.min.js: 3 Uncaught TypeError: Cannot read property 'string' of undefined
     at k.fn.init.c.fn.stupidsort (stupidtable.min.js: 3)
     at HTMLTableCellElement.  (stupidtable.min.js: 1)
     at HTMLDivElement.dispatch (jquery-3.4.1.min.js: 2)
     at HTMLDivElement.v.handle (jquery-3.4.1.min.js: 2)

I had the same error popping up.  It seems to be coming from
var diff = sort_info.compare_fn(e1.columns[th_index], e2.columns[th_index]);
when either e1[index] or e2[index] doesn't exist.
In my particular case, it stemmed from a table that had a 'short' row.  Ie:
H1 H2 H3
A1 B1 C1
A2 B2
A3 B3 C3
A4 B4 C4
Note the missing cell C2.  Sorting on H3, it'd try to read the string from the nonexistant C2, making the sort function fail due to an undefined string as argument e1[index].
Normally, this likely indicates an issue with the table, not the sort.  However, the sort should be able to handle this; I'd suggest that var diff needs to first check that both e1[index] and e2[index] actually exist before trying to sort them.


Add "System" model and associated unit tests

The majority of this commit is scaffolded code, but major improvements include:

Addition of the bluebird library for promises
System model with embedded Environments and Repos fields
Unit tests to assert that Environments and Repos can be retrieved from System objects

I'll point out the important parts in the code below

got a warning on a test - but not a big deal
Warning: Cannot find module 'passport-local' Used --force, continuing.


#10284 Fixed bug of vertical two handlers slider.

Fixed #10284 issue.
Before calculating the boundary values of the two handlers,
it was necessary to calculate the vertical position.

Awesome, thanks @hikouki!


Removing int from DescribeAnything

DescribeAnything should not route int to  DescribeNumber because DescribeNumber can only handle float64 - here's the function signature:
func DescribeNumber(f float64) string {...
Also, none of the above mini-challenges (1 to 4) build up to handling int, but rather float64s, so it makes sense to remove the int verbiage.

This concept exercise is teaching about type conversion and type assertions. The point here is to force them to cast from an int to a float64 (as the exemplar does here). The hints verify this if they get confused.
What we probably should do is add a test for the int case which apparently was missed (or possibly removed) from the DescribeAnything tests.

@mdrakiburrahman Thanks for bringing this up but like @jmrunkle I also think including int is good practice here.
I created an issue for the missing test case: https://github.com/exercism/go/issues/2016. I will close this PR in turn.


Unchecking Magic Keyboard from "Modify events from this device" blocks all keystrokes from keyboard

With the pictured setup, the computer seems to receive no keystrokes at all from the Magic Keyboard. I just want to have my Karabiner config affect my other keyboard (FILCO in screenshot), and not change the behaviour of the Magic Keyboard at all.
Note that the other keyboard works the whole time, regardless of whether Magic Keyboard is checked or not.

It's an issue of macOS side and difficult to avoid.
macOS sometimes missed a device after turning off the checkbox.
Turning off the power of magic keyboard once and turning on again might fix the issue temporarily.

@tekezo Thanks for the tip, it works like you said.
In my case, I only occasionally use the Magic Keyboard, for example when a coworker uses my machine, so this temporary fix seems to resolve my problem. For that reason, I'll close this issue, but please re-open it if you prefer.


Provide libblas.so and liblapack.so

Any reason why https://github.com/conda-forge/openblas-feedstock/blob/master/recipe/build.sh#L46-L49 is commented?

maybe it conflicts with lapack-feedstock ?

Thanks. Shouldn't that be handled by features, just like blas is? I mean have lapack package track a lapack feature and let netlib and openblas be two providers.

yes it should

FYI OpenBLAS has its own LAPACK.
As far as those lines, I commented them from the outset as there was a thought that people might be able to mix BLAS implementations. However, we have since seen this cause crashes (e.g. mixing linked libraries with OpenBLAS and MKL). So it might be ok to uncomment them. For the most part, if I need those lines, I add them to the recipe that builds with a BLAS and then remove the symlinks at the end of the build.

It's weird that conda-forge has only one blas implementation (openblas and no netlib) but has two lapack (openblas and netlib) with the netlib lapack bundling netlib's blas.

Created https://github.com/conda-forge/blas-feedstock/issues/6


Fix NetworkActivityIndicator kvo call back will trigger twice bug.

This is a bug when setter method manual KVO，this will trigger twice KVO call-back!
1).  From Apple Doc:
Given a key that identifies a property (attribute, to-one relationship, or ordered or unordered to-many relationship), send -observeValueForKeyPath:ofObject:change:context: notification messages of kind NSKeyValueChangeSetting to each observer registered for the key, including those that are registered with other objects using key paths that locate the keyed value in this object. Invocations of these methods must always be paired.

The change dictionaries in notifications resulting from use of these methods contain optional entries if requested at observer registration time:
    - The NSKeyValueChangeOldKey entry, if present, contains the value returned by -valueForKey: at the instant that -willChangeValueForKey: is invoked (or an NSNull if -valueForKey: returns nil).
    - The NSKeyValueChangeNewKey entry, if present, contains the value returned by -valueForKey: at the instant that -didChangeValueForKey: is invoked (or an NSNull if -valueForKey: returns nil).
- (void)willChangeValueForKey:(NSString *)key;
- (void)didChangeValueForKey:(NSString *)key;

Since our code not use -observeValueForKeyPath:ofObject:change:context:, it isn't necessary to trigger KVO call-back manual.
2).  I noticed that Alamofire/AlamofireNetworkActivityIndicator didn't use KVO manual, I think we should keep up with it.
3). Since there are not  expose activityCount property, It would be pointless to change activityCount value via KVC.

@jshier   Done!


Not installable on 2.15 due to node-waf-requirement

I am not able to install the package due to some old dependency inside some of the dependencies.
>ember install ember-cli-bundle-analyzer
Command failed: npm install --save-dev --loglevel error ember-cli-bundle-analyzer
Der Befehl "node-waf" ist entweder falsch geschrieben oder konnte nicht gefunden werden.

>ember -v
ember-cli: 2.15.1
node: 8.12.0
os: win32 x64

The reason behind the problem "node-waf" does not exist any more - it has been replaced by "node-gyp" (that is used by the other dependencies in the project).
Is it possible to update some of the requirements to get rid of the node-waf dependency?

There is no explicit node-waf dependency from this package. Likely a Windows issue...
@thewulf00 Did Ember CLI emit an error log, that you could share here?


[AliasAnalysis] Improve builtin's effects to depend on escapingness.

Mostly restore the behavior of getMemoryEffectsFn on builtins other than once and onceWithContext to before 8a8a895239980343ec6a6d16930889fec389e75d but keeping the improvement to return Instruction.memoryEffects in the face of escaping.

@swift-ci please test

@swift-ci please test

Added!

@swift-ci please test


Whitelist openuserjs.org

Hi! openuserjs.org is listed on the porn hosts file but it's not a porn site. It's an alternative to Greasy Fork

Website taken down! Thanks for building!


  It may be beneficial to move some of those changes over here.

Yes, there is finally no need to have "x" and "c" resources separately. We can take contributions from community back to "x" resources, and we definitely want to merge them. It would be awesome if somebody from community will work on pull request for that, it would speed up the process significantly.

Would you prefer many smaller PRs that only deal with a new feature or bug fix, or would you just like to have the "c" and "x" merged together, tested, and 1 big PR?  I'm more than willing to help where I can.

It's a good question. One time 1 big PR with significant testing would be easier for your and fine for us. For all future development, we would prefer to deal with small PRs, scoping one particular aspect.

Sounds good.  I'll start looking at the website and app pool modules

Should this issue be closed?


Process the project descriptor

Overview
Project description (aka project.toml) is defined here. If present, we should utilise it appropriately:

project.id can be used to scope the cache
project.build can be used to control the build context (similar to dockerignore)
build.env can be injected as build environment variables

As well suggested by @jromero, config package could be responsible for processing this and translating it into BuildKit settings.

A separate point of research would be what should happen with build.buildpacks. IIUC, frontend will need to pull any remote buildpacks and inject them into the build environment.


Added buttons for opening in editor & Finder to project page

Related Issue:
#46

Summary:
Added two buttons to ProjectPage Component.
It uses platform.service for getCopyForOpenInFolder caption.
Also shell.service is used for executing the commands.
Styling needs to be discussed. I think the size and location is OK but I'm not sure with the color.
A hover effect is changing the background color to a slightly darker gray.

Screenshots/GIFs:

Hi @AWolf81,
Woohoo! Thanks for tackling this.
I pushed an update to your branch to do two things:

Set the background color using Button props, and remove the stroke
Change the copy from "Open editor" to "Open in Editor".

For 1., I feel like we should use the button props rather than putting overrides in through CSS, to ensure that all buttons have a consistent look. Here's what it looks like with my change:

Right now the grey is very subtle. It's tricky because gray[200] is a bit too light, gray[300] is a bit too dark, and I don't really wanna define a whole new color for this.
I want to add a hover effect which makes the buttons have either a darker grey or maybe even a purple background on hover, but our buttons don't support hover effects. I have an idea for how to support that, but it would involve changing the API of , and that's a bigger change, so I want to do it in a new PR. Will open it later today.
There is a visual bug with the button border, but that should be fixed with #187
For 2., I chose to use "title case" since that's what we're using on other buttons (eg. "View Details" instead of "View details"). I think this is pretty common for buttons (I just quickly checked Steam and Spotify, and they both do this, at least on Mac).
Also, I changed the copy to "Open in Editor", to make it clear that you're opening the current project in the editor, and not just opening up the editor.
Let me know what you think of these changes

Hi @joshwcomeau:
Thanks for adding these fixes. It looks better. You're right using props is better than overriding with CSS - I just wasn't aware that we have them (maybe we could add this case as story to the strorybook to show the usage).
So I think this is ready for merging.

(maybe we could add this case as story to the strorybook to show the usage).

Good idea! I'm gonna rework the button props right now, so I'll tackle that as well :)


Attempting to modify the cluster post-creation leads to an IAM error

Description
I have recently deployed an EKS cluster with both public and private endpoint access. This succeeded without issue. The problem arises when trying to make a subsequent update to the cluster that makes an UpdateClusterConfig API call to AWS. Specifically, I set public_endpoint_access = false, re-ran apply, and hit this:
│ Error: error updating EKS Cluster (lefranc-0) VPC config: InvalidRequestException: Role with arn: arn:aws:iam::140327370353:role/lefranc-0-cluster-20220716170511649200000001, could not be assumed because it does not exist or the trusted entity is not correct
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "035daf3b-50ff-4407-9dce-a9dc939186c1"
│   },
│   ClusterName: "lefranc-0",
│   Message_: "Role with arn: arn:aws:iam::140327370353:role/lefranc-0-cluster-20220716170511649200000001, could not be assumed because it does not exist or the trusted entity is not correct"
│ }
│
│   with module.eks[0].aws_eks_cluster.this[0],
│   on .terraform/modules/eks/main.tf line 14, in resource "aws_eks_cluster" "this":
│   14: resource "aws_eks_cluster" "this" {
│

Full EKS module definition:
https://github.com/pauwels-labs/terraform-infra/blob/16a5305f9f76a92b6fb5c2d0ab4e458230395931/eks/eks.tf#L43
Feel free to clone this branch and run plan/apply using the included tfvars file. You'll need to update the account ID and role name to assume for the cluster account and the keys account (can be the same).

[x] ✋ I have searched the open/closed issues and my issue is not listed.

I have found this related issue which was closed as unable to reproduce, but I'm not convinced the reviewer attempted to update the cluster rather than just create it:
https://github.com/terraform-aws-modules/terraform-aws-eks/issues/2057
Versions

Module version [Required]: 18.26.3

Terraform version:

(engineering-dev/default) terraform-infra $ terraform version
Terraform v1.2.5
on linux_amd64

Reproduction Code [Required]

Steps to reproduce the behavior:

New workspace is created using terraform workspace new deployments-prod-engineering-deployments-prod
I use a base user in my IAM account which is then authorized to assume roles in other accounts; in this module, the tfvars file allows you to specify which account ID and role name to use for the account in which the cluster will be created, and the account in which keys for cluster envelope encryption are created. You can feel free to use the same account ID and role for both, but you'll need to make sure the user/role you're logged in as on your CLI can assume that role in that account. I'm not sure if this will affect the outcome.
I run terraform apply -var-file deployments-prod-engineering-deployments-prod.tfvars to initially create the cluster which does not create any problems
I change the public_endpoint_access variable to false
I rerun terraform apply -var-file deployments-prod-engineering-deployments-prod.tfvars
Hit the IAM error above

Expected behavior
The UpdateClusterConfig API call made by Terraform succeeds without an IAM error and disables public endpoint access.
Actual behavior
The error copied above is returned.
Additional context
Attempting to perform aws eks update-cluster-config --name lefranc-0 --resources-vpc-config endpointPublicAccess=false,endpointPrivateAccess=true --profile admin-engineering-deployments-prod-mfa --region eu-west-1 leads to the exact same error.

I can also confirm that trying to change it via the UI doesn't work. I'm at a bit of a loss here, I assume the issue is that somehow the rule I'm assuming to try and do this isn't allowed to assume the created cluster role, but I thought that:

The trusted entity assuming the cluster role is not me, but the EKS service
I added my assumed role as allowed to assume the cluster role in the cluster role's trust relationship, still doesn't work

Any problem here!
▶ cat eks.tf
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 18.26"

  cluster_name    = "ir-k8s-dev"
  cluster_version = "1.22"

  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = false

  vpc_id     = "vpc-f247c196"
  subnet_ids = ["subnet-b311a1c5", "subnet-0012a276", "subnet-1c4e8444", "subnet-71ec0216", "subnet-01488259", "subnet-36ef0151"]

  eks_managed_node_group_defaults = {
    disk_size      = 100
    instance_types = ["m6i.large", "m5.large", "m5n.large", "m5zn.large"]
  }

  eks_managed_node_groups = {
    green = {
      min_size     = 1
      max_size     = 10
      desired_size = 1

      instance_types = ["t3.large"]
      capacity_type  = "SPOT"
    }
  }

  tags = {
    environment = "dev"
    terraform   = "true"
  }
}

│ Error: error creating EKS Cluster (ir-k8s-dev): InvalidParameterException: Role with arn: arn:aws:iam::646770040222:role/ir-k8s-dev-cluster-20220726161828400200000007, could not be assumed because it does not exist or the trusted entity is not correct
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "5e82efd0-40d9-4fcc-a343-36d27d482608"
│   },
│   ClusterName: "ir-k8s-dev",
│   Message_: "Role with arn: arn:aws:iam::646770040222:role/ir-k8s-dev-cluster-20220726161828400200000007, could not be assumed because it does not exist or the trusted entity is not correct"
│ }
│
│   with module.eks.aws_eks_cluster.this[0],
│   on .terraform/modules/eks/main.tf line 14, in resource "aws_eks_cluster" "this":
│   14: resource "aws_eks_cluster" "this" {
│

most likely the issue relates to the IAM entity who created the cluster (this entity is added automatically as a system:masters role) and any additional cluster auth when additional roles have not been added

Does internal cluster auth interact/aws-auth configmap interact at all with a call to change public/private endpoint availability?

I  solved this on my environment. Basically are iam permissions.
If you use iam.* will work as well
I will try to test each role, one by one to set a restrictive permissions

@bryantbiggs can you clarify what your suspicions are?  I'm running into this same issue with 18.26.6, although the issue is persisting despite setting cluster_endpoint_public_access to true as a last resort.

you'll have to provide configs and steps to repro

Our module terraform looks like this (vars substituted with representative values):
module "eks" {

  source  = "terraform-aws-modules/eks/aws"
  version = "18.26.6"

  # Metadata
  cluster_name    = "test-cluster"
  cluster_version = "1.21"

  # CloudWatch
  create_cloudwatch_log_group = false

  # API access
  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = false # setting to true didn't help

  # IAM
  create_iam_role               = true
  iam_role_permissions_boundary = "our-permissions-boundary-arn"
  # KMS Encryption
  create_kms_key                  = false
  cluster_encryption_config       = [{
      provider_key_arn = "our-key-arn"
      resources = ["secrets"]
  }]
  kms_key_deletion_window_in_days = 7
  enable_kms_key_rotation         = false

  # Addons
  cluster_addons = {
    # Available addons (as of June 30 2022):
    # adot
    # kube-proxy
    # vpc-cni
    # coredns
    # aws-ebs-csi-driver
    aws-ebs-csi-driver = {
      resolve_conflicts = "OVERWRITE"
      tags              = var.cluster_tags
    }
    coredns = {
      resolve_conflicts = "OVERWRITE"
    }
    kube-proxy = {
      resolve_conflicts = "OVERWRITE"
    }
    vpc-cni = {
      resolve_conflicts = "OVERWRITE"
    }
  }

  # Networking
  vpc_id                      = "our-vpc-id"
  subnet_ids                  = ["subnet1", "subnet2"]
  cluster_security_group_name = "test-cluster-eks-security-group"

  # Defaults for Managed Node Groups - applies to all node groups unless overridden in the node group configuration
  eks_managed_node_group_defaults = {
    create_iam_role = true
    disk_size       = "200"
    ami_type        = "AL2_x86_64"
    ami_id = "stock-eks-worker-node-ami"
  }

  # Managed Node Groups
  eks_managed_node_groups = var.eks_cluster_managed_node_groups

  # OIDC
  openid_connect_audiences = var.eks_cluster_openid_connect_audiences
}

We are uniquely constrained by a permissions boundary we have to attach to each role we create, which admittedly makes this more nuanced for us.  What I'm trying to get an understand of is what is happening at this stage of cluster creation  that could result in this error.  It seems like a self-explanatory error until you realize, as the others in this issue and in #2057 did, that the EKS role does exist and does have eks.amazonaws.com as a principal that can assume it:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "EKSClusterAssumeRole",
            "Effect": "Allow",
            "Principal": {
                "Service": "eks.amazonaws.com"
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

@supergrilo can you elaborate on what you did to fix? I gave AdministratorAccess to the cluster IAM role but that did not resolve.
@bryantbiggs I will try adding new roles to the aws-auth configmap and see if that changes things.

Hi,
I have ran into the same issue and I could reproduce the error only in clusters with secrets encryption enabled. Adding root user to the key policy (like the module does by default when creating the kms) would solve the problem.
Default key policy - AWS Key Management Service
But granting Describekey permission to the eks role of the cluster in the kms key was a better solution for me as it follows the least privilege principle.
https://docs.aws.amazon.com/eks/latest/userguide/enable-kms.html
You could modify the policy or create a kms grant like this:
resource "aws_kms_grant" "a" {
  name              = "my-role-grant"
  key_id             =  my-kms-key-id
  grantee_principal = module.eks.cluster_iam_role_arn
  operations        = ["DescribeKey"]

}

I hope it helps.
Regards.

For us, it was a case of
"iam:DeleteServiceLinkedRole",
"iam:CreateServiceLinkedRole"

missing from the permission boundary we were placing on the EKS cluster role.  Based on the variety of solutions that people have had, it seems as though InvalidRequestException and InvalidParameterException during EKS Cluster creation stem from a wide range of IAM policy related issues.

The issue for me was that my cluster was created in 2018. I had upgraded this module to the latest 18.26 version but it looks like the AmazonEKSServicePolicy is no longer being added to the cluster role in this new version. As stated in the note here https://docs.aws.amazon.com/eks/latest/userguide/service_IAM_role.html, clusters created on or after April 16, 2020 do not need that policy added to the cluster role any more. Since my cluster was created before then, I added
iam_role_additional_policies = [
  "arn:aws:iam::aws:policy/AmazonEKSServicePolicy"
]

The error no longer comes up anymore.

Thank you all for the additional potential fixes.
@alejandro-gallardo-ntt I've been suspecting it might be an issue with the IAM keys, as my keys are in a separate account from the cluster. Will be testing with keys in same account to verify if the issue is with IAM access to the other account.
I encourage others encountering an identical error to post their fixes in this thread. As @chaospuppy said, it seems like this error will cover a wide range of IAM issues stemming from a wide range of potential AWS setups. Having encountered little to no discussion of this error after a lot of googling, this issue may help lead people down the right path for their particular environment. I'll try to compile them as a final doc, @bryantbiggs would you be interested in a docs PR for IAM-related errors?


Minor updates

A few updates:

TehC is dead
Secret Cinema is now at secret-cinema.pw
TheGeeks is now at thegeeks.click.

SC fix https://github.com/kannibalox/IMDb-Scout/pull/11

Thanks a lot @SalamanderSandwich


The OData and Virtualize DataGrids are empty in the mobile app

the virtualization example of DataGrid work with VPN and has no problem

@sajadkardel
could you plz confirm @MeysamBahadori 's comment? if so please close this issue with a comment.

I tested it with VPN and it works, As for the OData example, I know that @ysmoradi  works on it.

This issue has been checked and is still valid. @msynk

Seems to be a linker issue, it works in debug mode, but doesn't work in release mode

This issue is not relevant anymore


[BUG]: issue title

Description
"Microsoft Teams Admin | Weekly Clean Up of Microsoft Teams environments" flow is actually able to delete the Teams environment but throwing "statusCode":404,"message":"Resource not found" and failing.
Component:

Solution Center of Excellence - Governance Components
Version 1.28
Flow Microsoft Teams Admin | Weekly Clean Up of Microsoft Teams environments

Screenshots

Hello,
this is a duplicate of #764 and was fixed in our latest release. You're on an old version of the Governance components, so will need to upgrade to get the latest version.
lease be sure to remove any unmanaged layers from flows before you update as described in installing updates or you will not see the changes.
Thanks for using the CoE
Manuela

Thanks Manuela! We will do the upgrade as you suggested.


Chosen input not disabled when within a disabled fieldset

A chosen input should be disabled when within a fieldset element that is disabled.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#attr-disabled

I have a similar problem. In my app I have a view and edit mode. Initially if open a view, every field is disabled. Here the angular chosen select is not disabled. If I enable everything and disable everything again. It works fine and is also disabled. I use ng-disabled property.

+1000!

There's an issue on Chosen/2389 which means itself don't work well.
Are you able to bind the same disabled with ng-disable of your <fieldset>? I know it's not the correct way, but it should solve your problem...
Something like:
<fieldset ng-disabled="editable">
    <select ng-disabled="editable">...</select>
</fieldset>

Another solution is create a directive to watch the ng-disabled from any fieldset:

app.directive('fieldset', function () {
    return {
        restrict: 'E',
        link: function (scope, element, attrs) {

            if (angular.isUndefined(element.prop('disabled'))) { //only watch if the browser doesn't support disabled on fieldsets
                scope.$watch(function () { return element.attr('disabled'); }, function (disabled) {
                    element.find('input, select, textarea').prop('disabled', disabled)
                });
            }
        }
    }
});

I found it here

Is there any progress on this topic?


Results ordering for "Configuration" keyword

Results ordering for "Configuration" keyword should be imho improved.
I expected https://quarkus.io/guides/config and https://quarkus.io/guides/config-reference to be on the first two places, but they are on the 4th and 6th place. The guide I would expect on the first place is the one on the sixth place.
Here is the screenshot for https://quarkus.io/guides/#q=Configuration

I get the same result for https://quarkus.io/guides/#q=Configuring search.

I think this is similar to #40.
What we have now is scoring, based on the frequency and number of tokens in a document. It is a reflection of how well a document matches a query.
What you are after is something that takes into account the relative "importance" of a document. You want "first-class" guides to appear first, even if they don't score quite as well as lower-class guides.
In #40 as well as here, I think the answer is adding a rank to guides and taking it into account when scoring, i.e. something like #12.