Form / Visual Usability - Checkboxes in Item Filters are not normalized in position to their respective options.

Is your feature request related to a problem? Please describe.
When I open the item filters page, the checkboxes for selecting any given category are not directly next to the category text that they correspond to. In isolation this is fine, the problem is that because of the grid layout, the boxes directly to the left of the category name correspond to the category to the left. Put another way, the distance from the text of a category is offset a different distance from the checkbox for every option (because text lengths are different).
Every time I open the filters page my eyes have to readjust and my brain has to put effort into visually correlating the checkboxes with the categories they correspond to.
My Brain wants to see the Red as correct, but it isn't, the green box is what the checkboxes actually correspond to.

Describe the solution you'd like
Move checkboxes for options always to being directly next to a category option. Something like this:

This always sets the corresponding checkbox at the same distance from the option it corresponds to as every other option, making the form look more consistent and easier to scan quickly
Describe alternatives you've considered
I think not using a grid layout could help, but because of the extensive options I think a grid option has benefits. Ultimately I think that it's fairly common in the language of online forms and filters to have checkboxes to the left of options rather than to the right side.
Additional context
I am using Firefox if that makes a difference, if this does not show on other browsers like this.

Thanks! the source section looks great, but unfortunately looks like it wasn't widely applied, Weapon Type still shows the old layout:


This is adding my validator 139452

This is adding my validator 139452

Apologies, but the ethereum capella specification for withdrawals was updated and finalized. As a result, we must ask you to redo the validator set credentials with an ethdo version equal or greater than 1.27 (which now has fixed the fork version). The instructions for CLWP have been updated. Please update your submission or we will invalidate and remove the submission by 2023/01/31. If you need assistance, please ask on discord and NEVER share your seed phrase.


Add Extraction Support for SPWebApplicationExtension

As listed in the Parity with SharePointDSC page, we need to add support in ReverseDSC to be able to extract values out of the SPWebApplicationExtension Resource.

Included in <IP_ADDRESS>


adding Hardware section from upstream repo (davewhiteland)

This is the a merge from the upstream repo with two conflicts resolved (one on tab-completion because the upstream hasn't got these changes (yet; I'll fix that), the other because the about page doesn't link to Beholder or the upstream repo (this is fine).
Also need to remove the CNAME from upstream merges because it maps to the beholder domain there (i.e., this is a routine and expected fix on PRs here on the RHUL fork).

whoops this shouldn't be on this repo — it's for the RHUL one instead, deleting


[FeatureRequest] Callback for delete(String fileName)

Is it possible to have a callback also for the delete(String fileName) method? I need to refresh my file list after deleting items but if I do immediately after the file is still there (as the future completes without waiting)...
Thanks!

The delete api is an async method. Please use await.

I have used await, obviously, but as you've written in the documentation "the future completes without waiting". I need to have a callback after the file has been deleted for real.


https://www.orientdb.com/ is down?

OrientDB Version: all enterprise version
It's not an issue with orient. But it's gonna be couple days and site https://www.orientdb.com/ is not accessible. https://www.orientdb.org/ is ok.
Does anyone knew anything?

https://community.orientdb.org/t/orientdb-com-died-are-you-ok/764


The String type should have a get(int) -> Option[Char] method

The current get and op_get of String type both return a Char, but the methods of the same names of Array type return an Option[T] and a T respectively. Their behavior should be aligned.

I have referred to the get and op_get functions of the Array data structure type and made corresponding modifications to the get and op_get functions of the String data type.
I have rewritten the existing get and op_get functions, and added a new unsafe_get function in the file path moonbitlang/core/builtin/intrinsics.
The specific modifications are as shown in the figure below：

// source code:
type! IndexOutOfBounds(Int)
pub fn String::get(self: String, idx: Int) -> Char? {      //return type is Option[char]
guard idx >= 0 && idx < self.length() else { None }
Some(self.unsafe_get(idx))
}
pub fn String::op_get(self: String, idx: Int) -> Char! {
guard idx >= 0 && idx < self.length() else {
raise(IndexOutOfBounds(idx))
}
self.unsafe_get(idx)
}
pub fn String::unsafe_get(self : String, idx : Int) -> Char ="%string_get"


soc/same54: Initial support

The Atmel SAME54 is a Cortex M4F with Ethernet that shares it's peripherals with the sam0 family. (This seems to be true for all new Atmel parts, it certainly is for the new SAML1x Cortex M23 parts).
The MCU is part of the SAMD5x/SAME5x family - the E parts are identical to the D ones, but come with an additional GMAC Ethernet peripheral.
This adds support for the MCU and the SAM E54 Xplained Pro development board.
I ported all existing sam0 peripherals use the new clock setup if available.
What works:

[x] UART
[x] SPI - depends on #14876
[x] I2C - depends on #14128
[x] GPIO
[x] DMA
[x] XOSC
[x] RTC when used as system timer, only non-tickless mode works
[x] Watchdog
[x] ADC only tested with adc_api test
[x] USB
[x] RNG
[ ] Ethernet GMAC driver not implemented/ported yet
[x] Timers - depends on #15105
[x] Flash
[ ] QSPI - to be implemented

requires https://github.com/zephyrproject-rtos/hal_atmel/pull/1

Nice! I suppose it takes a super worm moon for this kind of macro magic to come forth.
Maybe it's easier to get this included as a separate pull request.

Oh well, it was a nice dream.  I'll pull the parametric macros for the EIC out of dts_fixup.h as well, since that probably qualifies as "something weird".  That does mean you'll need 16 copy-paste definitions for the SAME54 one, though.
Really, it'd be nice if scripts/dts/extract_dts_includes.py (extract/default.py ?) generated kconfig style defines for the presence of all properties in the device, so there'd be a #define DT_ATMEL_SAM0_UART_42001000_IRQ_0_PRESENT 1 or something.  That's probably too specialized to the SAM0 code generation needs, though.

Yes, I will indeed try to reduce the use of dts_fixup.h and switch to DT_ATMEL_SAM0_UART_0_IRQ_0 et al. Since any re-ordering would be consistent when sticking to the defines from generated_dts_board_unfixed.h, I don't see how it would be a problem.
The parametric macros then can stay in the corresponding .c file

Yeah I think it should be fine as long as you only reference devices by the label, it's just a bit odd when SERCOM3 ends up as DT_ATMEL_SAM0_UART_0 (since it was the first UART instance) while SERCOM1 is also DT_ATMEL_SAM0_SPI_0.  As long as it's consistent everything should be assigned correctly.  So I'll change the I2C code as well.

Codecov Report

Merging #14685 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14685      +/-   ##
==========================================
- Coverage   52.51%   52.48%   -0.03%
==========================================
  Files         309      309
  Lines       45048    45063      +15
  Branches    10419    10434      +15
==========================================
- Hits        23656    23653       -3
- Misses      16584    16595      +11
- Partials     4808     4815       +7

Impacted Files
Coverage Δ

...s/bluetooth/controller/ll_sw/nordic/lll/lll_scan.c
54.57% <0%> (-0.96%)
:arrow_down:

kernel/include/ksched.h
90.9% <0%> (-0.86%)
:arrow_down:

subsys/bluetooth/host/conn.c
40.19% <0%> (-0.12%)
:arrow_down:

kernel/sched.c
83.9% <0%> (-0.12%)
:arrow_down:

subsys/bluetooth/controller/ll_sw/ctrl.c
54.35% <0%> (-0.08%)
:arrow_down:

subsys/bluetooth/host/hci_core.c
44.13% <0%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb44b7e...4d80757. Read the comment docs.

Rebased and re-run the tests.
As the vendor files have been moved to a separate repository, https://github.com/zephyrproject-rtos/hal_atmel/pull/1 is needed for this now.

Shouldn't this update west.yaml to point to https://github.com/zephyrproject-rtos/hal_atmel/pull/1

@galak I didn't know I can do this! Thank you.

Can we reduce this PR to have base SoC & board support, and than have the driver updates as separate PRs?

I suggest this so that the driver PRs can hopefully get reviewed by proper driver maintainers.

Alright then, I'll split this up.

@galak I've split it into individual PRs as requested.

Ethernet GMAC driver not implemented/ported yet
@benpicco Do you plan to/are you already working on this?

@stephanosio no i don't have any concrete plans for that.

@stephanosio no i don't have any concrete plans for that.

Ok, I will look into it then. At first glance, it seems to be using the same GMAC core as SAM7.


Semantic highlighting colors every variable with same color

Environment data

Language Server version: 2020.9.0
OS and version: Arch linux
Python version (& distribution if applicable, e.g. Anaconda): 3.8.5
Theme: One Dark Pro

Expected behaviour
Different variables would have different colors or at least distinct color for self keyword and other variables. I think before semantic highlighting the editor was much more usable:

Actual behaviour
Every variable has red colour:

I didn't find how to disable this feature and only way seem to be downgrade.

Can confirm this - this is very frustrating and something that I was just about to open an issue for myself. This not only affects  variable names, but also modules.
I've tested all the extensions I have - this is caused by the new Pylance release. Instead of the expected syntax highlighting, we get this strange new syntax highlighting, with no way to disable or override it in the settings.

self now italicized in One Dark Pro to distinguish it, if you're looking for self to be a different colour checkout Mayukai semantic mirage.

Downgrading to the previous release fixes the broken semantic highlighting (2020.8.3)

Hi @Destaq this can be turned off, see https://code.visualstudio.com/docs/getstarted/themes#_editor-semantic-highlighting (2 settings in config)

I don't think this is broken; it is entirely up to the theme to choose how to display the tokens. We just send what the tokens are, and One Dark Pro displays variables in red, parameters italicized, etc. If you don't like the colors chosen by One Pro Dark, you'd need to report it on their tracker.
You can always turn of semantic highlighting in the editor (I believe you could disable it for Python in a "[python]": { ... } block, or switch to a theme that colors the tokens differently.

I'm not using OneDarkPro, just the default theme, and the semantic highlighting was broken for me as well.

The default themes still make choices as to what different tokens should be colored. We don't have control over that, VS Code does in their theme.
@zgoda shows the page where you can customize this to your liking, or disable it entirely if you don't like it:
"editor.semanticTokenColorCustomizations": {
    "[python]": {
        "enabled": false
    }
},

Before this would have been controlled by the TextMate grammar for Python, which behaves differently by highlighting the word "self" anywhere in the code, for example. I am noticing that the LSP spec does not offer any distinct token for say "self" or "this" (which would explain why it's just "a parameter variable" to the semantic tokenization): https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/#textDocument_semanticTokens

Oops, I meant:
{
    "[python]": {
        "editor.semanticHighlighting.enabled": false
    }
}

One Dark Pro is listed in release changelog as one of themes with full support for semantic highlighting.
BTW, docs say semantic highlighting is available only for 3 languages and Python is not listed among them.

I can confirm that the settings change to disable semanticHighlighting does restore the different coloration of "self".  However, it's a bit odd to me to have to disable semantic highlighting in order to restore semantic highlighting that was working before this specific release.  It sounds like this release of Pylance changes the behavior of the language server grammar from TextMate to something else? Is there any more information on this?

@zgoda There's a difference between having specific language support (custom tokens, it seems) and general semantic token support (color variables in red). There are other themes included with VS Code like the plain dark theme or the high contrast that have zero semantic highlighting support.
Themes wouldn't support special Python tokens specifically up until now, given this is the first time Python is getting semantic tokens. If there are special tokens or modifiers we can include that are out of the spec that allows themes to better distinguish certain variables, then that is worth investigation.
@falkben TextMate grammars are complicated regex rules in order to color the text that are bundled with VS Code, and are the ultimate fallback if VS Code doesn't have a provider for semantic tokens. That's what's happening here; we declare support for semantic tokens so VS Code calls us for the info. Those rules are not semantic, it's just that a variable called "self" almost always means "the self for a class", so it ends up "feeling" like semantic highlighting.
Compare the difference in this example; you can see that semantic highlighting means that we know that DataLoader is a class at all uses, and not just the declaration (which is all the TextMate profile can know via regex matching the line).

I appreciate the comments @jakebailey, thanks for the information.  Your example does help show what you give up vs. gain by enabling this feature.
If pylance changes things dramatically like this going forward, it would be nice to have as an option, disabled by default, and that you could opt into, at least until the new behavior is standardized.

I think, besides self there's probably quite a bit more that we lose with this syntax highlighting versus the old TextMate regex highlighting.  It would be nice to know what we are gaining vs. giving up.
For example, with the new highlighting, key word argument pairs are all displayed with the same color, which makes it much harder to read for me when there's a large number of them.

I am not sure if my understanding of semantic highlighting is correct but I would expect different colors for same token in context for example if I have dummy function:
def test(input_token):
    x = 1
    return x + input_token

I would expect different colors for token input_token and x. Same expectations holds for class definition if I define in __init__ variable self.x I would expect that x part has same color throughout the definition of class methods where used.
@jakebailey the question is if this is already done by pylance and problem is only on theme side or if pylance treat all local variables the same way.

See my explanation in https://github.com/microsoft/pylance-release/issues/319#issuecomment-686843969. That isn't how VS Code defines semantic highlighting; semantic highlighting in VS Code is "this is a variable, color it this way", or "this is a function, color it that way". It isn't "color each variable a different color".
In that code snippet's case, they will be different by nature of input_token having the "parameter" modifier to say that it's a parameter; One Dark Pro italicizes parameters, for example. But otherwise semantically, all we can say is that both are variables. We can't tell the editor that any given token needs to be a specific color; that's up to the theme based on the generic metadata we provide.

If pylance changes things dramatically like this going forward, it would be nice to have as an option, disabled by default, and that you could opt into, at least until the new behavior is standardized.

+1 to this. I'd like to share my experience because it took me a while to understand what had happened to syntax highlighting. Given I did not know about this new feature, the change appeared to be a bug. I hadn't realized this, but my eyes were particularly used to the previous syntax highlighting, and I couldn't scan code I'm familiar with as easily as I was able to before.
Unfortunately, my various initial attempts at searching for the cause didn't lead to any hits (e.g., "vscode python colors all the same", "vscode color theme changes python (limited to last week)"], so I gave up and assumed this was a strange issue with VSCode on my computer. I wasn't sure where I should even file a bug (vscode? vscode-python? the color theme repo?).
Eventually I gave up and stuck with the existing syntax highlighting, until the next day when I disabled pylance on a whim and realized the syntax highlighting was "fixed," and searched specifically in the issues repository, leading to this issue.

not sure why LOGGERs foreground is being suppressed here. If turn off semantic highlighting it is working fine. Not sure if this an issue, and I don't follow this long thread. So excuse my ignorance if already reported/discussed.
WIth semantic highlighting turned on:

WIth semantic highlighting turned off:

self now italicized in One Dark Pro to distinguish it, if you're looking for self to be a different colour checkout Mayukai semantic mirage.

After reading the related One Dark Pro issue and this issue i'm still not clear who is responsible for how things are colored, but I would like to say italics are make things harder for people with dyslexia to read sometimes, a different color for self would be vastly preferable for me.

Since many themes don't have great support for semantic tokens, would it be possible to document a few that do? I think this could ease the pain of migration here.

Thank you for the feedback everyone.
The next release will have additional semantic token types and modifiers to add more variety than provided by the VS Code built in semantic tokens.
This will have the effect of respecting the theme coloring of some of the Python specific textmate scopes that were lost when semantic colorization was introduced.
The improvements apply to CONSTANTS, self and cls parameters, dunder methods, and type hints inside of comments.

This issue has been fixed in version 2020.9.6, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202096-23-september-2020

Note that the old VS Code regex-based TextMate profile didn't mark variables at all. If you prefer this behavior you should be able to override your theme's choice of variable coloring by doing something like:
{
    "editor.semanticTokenColorCustomizations": {
        "[One Dark Pro]": {
            "rules": {
                "variable": "#ABB2BF" // One Dark Pro's default text color
            }
        }
    }
}

But the other tokens should match what you're used to with VS Code's defaults without semantic highlighting. We'd appreciate it if those who disabled it could give it a shot again and provide feedback! 🙂

@jakebailey thanks for these fixes in v2020.9.6, the improvements make the semantic coloring much easier to understand! I tried your suggested override for the variable token while using One Dark Pro and noticed that it overrides the coloring of module level constants which are now identified the same as other variables:

Is it possible to add another semantic token for these module level constants in the future so that we can have them colored differently?

The highlighting of CONSTANTs was the one thing blocking me from enabling this feature so thank you for addressing it!
I will note that for some reason I still had to apply a customization to get back the original color I was used to, maybe because my theme doesn't treat variable.readonly the same as constant.other.*... but for others' reference here is how I got it back:
Scope with semantic highlight disabled:

Scope with semantic highlight enabled:

Customization to get back the original color:
    "editor.semanticTokenColorCustomizations": {
        "[Monokai]": {
            "rules": {
                "variable.readonly": "#AE81FF",
            }
        }
    },

It seems there are few corner cases here not handled yet like class-level constants, but I think I can live with those for now:

Just in case anyone else is looking for customizing their theme and is curious about how to get the popup with information about how the tokens are being identified, you enable that in the command pallet with "Developer: Inspect Editor Tokens and Scopes".  Can find more information about that here: https://code.visualstudio.com/blogs/2017/02/08/syntax-highlighting-optimizations#_new-textmate-scope-inspector-widget
To make the same change as @ian-h-chamberlain made for constants for One Dark Pro you'd want something like this:
{
  "editor.semanticTokenColorCustomizations": {
    "[One Dark Pro]": {
      "rules": {
        "variable": "#ABB2BF", // One Dark Pro's default text color
        "variable.readonly": "#D19A66", // edit: "*.readonly" may be more comprehensive here actually...
      }
    }
  }
}

Yes, thanks for mentioning the other rules; I just gave a quick example of an override and you should definitely distinguish tokens how you prefer. We should be outputting scope/token names with enough info to distinguish things (as they have to be different to be rendered differently). I found the color by disabling semantic highlighting, checking the color with the tooltip, then adding it back to the config.

For anyone else who discovered that other languages were suddenly also impacted by this (all const vars in JavaScript, lol), check this other comment I made about how to make it language specific.
TLDR you can add the language in the rule matcher, in my case:
    "editor.semanticTokenColorCustomizations": {
        "[Monokai]": {
            "rules": {
                "variable.readonly:python": "#AE81FF",
            }
        }
    },

The problem is back in 2022 with Dark+ default darcula theme


Redesign

Main changes:

Application Color
Icons
Layout
Background Images

Hi Samuel,
Thanks for taking the time and doing some work on 11t, it really needs the attention. As for your layout changes, I do not think they are in a direction I'd like to follow. Posts and images should use the available space, and the white borders are taking away too much of it.
I'm working on a theme selector, maybe we could add your black and white version as one of the themes.

I tried to create an option to select a dark or light theme, but since I'm learning to play Fuse, I was not successful. I will try to help whenever I have time. Thanks for listening!


Would it be possible to change name stampede to something more unique and easy to search?

Hi,
would it be possible to change name stampede to something more unique and easy to search?
For Stampede, I think of ToroDB Stampede:

https://github.com/torodb/stampede/
https://www.torodb.com

And google searches for Stampede shows many results of something not related to your project.

Although, it seems Deno projects are usually named with something similar, so maybe this a bad idea.

Thank you for opening this issue. As Stampede has just got released this week, I believe it won't be at the top of search engines' results for certain time period. In the next couple of days, I'll release a site with the entire documentation of the project and some decent tips and tutorials to help new users increase their productivity and also help them use the framework the right way.
I chose this name primarily so the project has some sort of correlation to Deno, nothing else.


The FOLLOW command does not allow passing the auth of the follower

Describe the bug
The FOLLOWER command does not allow specifying the leader's auth password, resulting in failure when attempting to follow via the command. This is problematic when the leader is password protected and we want to turn a previous leader into a follower via a script on startup when we say want to check with Redis Sentinel first to determine the leader after a failure.
This is you command definition which shows no argument for leaderauth
"FOLLOW": {     "summary": "Follows a leader host",     "complexity": "O(1)",     "arguments": [       {         "name": "host",         "type": "string"       },       {         "name": "port",         "type": "integer"       }     ],     "since": "1.0.0",     "group": "replication"   },
Would be great if you could fix this ASAP as we are standing up a Tile38 Cluster using Sentinel for failover.

Apparently you can preset the leaderauth in the leader's config file and it will be used when a FOLLOW command is executed. However it would be good to also to be able to create a follower via a script including specifying the leaderauth

Use CONFIG SET leaderauth your-password prior to FOLLOW

Thanks @iwpnd , we can close this bug then, however I do suggest the FOLLOW documentation adds this information so that others don't have to figure out how to do it. @tidwall

Feel free to open a Pr in the docs.


Replace Travis with GH Actions

Hey @dvmonroe 👋
Would you accept a PR to replace Travis with GH actions?
Tried to use the gem on a project of mine earlier and ran into some issues that I plan on debugging as well.

Deff - no issues from me - as long as it'll stay free for open source projects.


added foundation for sway-tac-toe

At present this only uses JS for its functionality, will change this to using Sway in a future commit. This should also solve the one known problem this has, which is that the logic allows for clicking the same square twice and instead of maintaining the correct player it's possible for the same user to have multiple turns back to back. This version also doesn't implement multi-device interactivity, which is something I'd assume we'd want if anyone is to actually play with someone else.

4. A little nitpic, the css is small but I prefer [scss](https://sass-lang.com/documentation) (sass is fine too). Is it a good idea to move towards that now before the project grows or will it stay sufficiently small that the little bit of css is fine and adding scss/sass is unnecessary?
5. The App.js file has a massive "src" image. Is that needed / can it be replaced with a loading from a file or something?

As far as the CSS goes, you're 100% right. Once this project becomes bigger a definitive choice will need to be made on this, for now since the amount of styling is minimal and there is only one component I kept it all in once place (App.css) and just used default CSS, but this is not best practice.

Also correct, the original image is from SwaySwap and somewhere in rendering it is turned into a base64 image. Since I was just trying to get this up quickly, I went ahead and used the base64 version instead but it does look pretty ugly and will definitely be changed.

2. When I pull in your work it all gets added directly under "sway-applications" however there will be many applications for example my multisig work is under `sway-applications/multisig`. Can you create a directory under "sway-applications" and move all of your work into that so it's not at the top level e.g. `sway-applications/tic-tac-toe`

Would maybe sway-applications/games/sway-tac-toe suffice?

2. When I pull in your work it all gets added directly under "sway-applications" however there will be many applications for example my multisig work is under `sway-applications/multisig`. Can you create a directory under "sway-applications" and move all of your work into that so it's not at the top level e.g. `sway-applications/tic-tac-toe`

Would maybe sway-applications/games/sway-tac-toe suffice?

If there are going to be multiple mini-games then sure. This project could be one of those games. I have no issues with that.

2. When I pull in your work it all gets added directly under "sway-applications" however there will be many applications for example my multisig work is under `sway-applications/multisig`. Can you create a directory under "sway-applications" and move all of your work into that so it's not at the top level e.g. `sway-applications/tic-tac-toe`

Would maybe sway-applications/games/sway-tac-toe suffice?

If there are going to be multiple mini-games then sure. This project could be one of those games. I have no issues with that.

I think the intention is to have a few at least. Checkers, maybe chess eventually (:

This has been a draft for a long time. I'm thinking of closing it.

Closing this for now until the Sway contract is ready, feel free to reopen when ready @matt-user @Rubyt0x


Dagda dont show CVE detail

Hi @eliasgranderubio,
Following the API documentation, i try to view the report information:
# curl http://localhost:5000/v1/history/registry/test | python -m json.tool

[
    {
        "id": "58db8ee208540e14f3c9f58b",
        "image_name": "registry/test",
        "static_analysis": {
            "os_packages": {
                "ok_os_packages": 140,
                "os_packages_details": [
                    {
                        "is_vulnerable": true,
                        "product": "glibc-common",
                        "version": "2.17",
                        "vulnerabilities": [
                            "BID-68006",
                            "BID-70596",
                            "BID-72602",
                            "BID-72603",
                            "BID-76793",
                            "BID-77098",
                            "BID-81469",
                            "BID-82244",
                            "BID-83265",
                            "BID-83275",
                            "BID-83277",
                            "BID-85732",
                            "BID-92257"
                        ]
                    },
                    {
                        "is_vulnerable": true,
                        "product": "glibc",
                        "version": "2.17",
                        "vulnerabilities": [
                            "CVE-2012-4412",
                            "CVE-2012-4424",
                            "CVE-2013-0242",
                            "CVE-2013-1914",
                            "CVE-2013-2207",
                            "CVE-2013-4237",
                            "CVE-2013-4332",
                            "CVE-2013-4458",
                            "CVE-2013-4788",
                            "CVE-2014-0475",
                            "CVE-2014-6040",
                            "CVE-2015-0235",
                            "CVE-2015-7547",
                            "BID-68006",
                            "BID-70596",

but i can't view the CVE details as you shown in the REST API documentation:
{
      "id": "58667994ed253915723c50e7",
      "image_name": "jboss/wildfly",
      "status": "Completed",
      "timestamp": "2016-12-14 13:17:12.802486",
      "static_analysis": {
         "os_packages": {
            "total_os_packages": 182,
            "vuln_os_packages": 41,
            "ok_os_packages": 141,
            "os_packages_details": [
               {
                  "product": "grep",
                  "version": "2.20",
                  "is_vulnerable": true,
                  "vulnerabilities": [
                     {
                        "CVE-2015-1345": {
                           "cveid": "CVE-2015-1345",
                           "cvss_access_complexity": "Low",
                           "cvss_access_vector": "Local access",
                           "cvss_authentication": "None required",
                           "cvss_availability_impact": "Partial",
                           "cvss_base": 2.1,
                           "cvss_confidentiality_impact": "None",
                           "cvss_exploit": 3.9,
                           "cvss_impact": 2.9,
                           "cvss_integrity_impact": "None",
                           "cvss_vector": [
                              "AV:L",
                              "AC:L",
                              "Au:N",
                              "C:N",
                              "I:N",
                              "A:P"
                           ],

Maybe am I forgetting something? Thanks in advance.

I'm sorry! This issue is a documentation gap.
When I merged the PR #9, the CVE details was added. However, you must delete your cve and cve_info collections from your MongoDB and repopulate your database with vuln --init.
You will have all info about CVE details and all your new static analysis will have the details (the previous ones will not deleted or updated).
Please, check it and give me feedback if you found any new issue or my workaround doesn't work.

Hi @eliasgranderubio
I was trying with the workaround (in the mongodb i've cve collection, not cve_info):
$ sudo docker exec -it 16f9b679474b /bin/bash
root@16f9b679474b:/# mongo
MongoDB shell version v3.4.2
connecting to: mongodb://<IP_ADDRESS>:27017
MongoDB server version: 3.4.2
Welcome to the MongoDB shell.
For interactive help, type "help".
For more comprehensive documentation, see
        http://docs.mongodb.org/
Questions? Try the support group
        http://groups.google.com/group/mongodb-user
> show dbs
admin          0.000GB
local          0.000GB
vuln_database  0.192GB
> use vuln_database
switched to db vuln_database
> show collections
bid
cve
exploit_db
image_history
init_db_process_status
> db.cve.drop()
true
> exit
bye
root@16f9b679474b:/# exit
exit

and then repopulate the database with vuln --init
# curl localhost:5000/v1/vuln/init-status
{"status": "Updated", "timestamp": "2017-03-30 07:11:34.694043"}

i run a new analysis, but the results, are the same, without the CVE details:
# python3 dagda.py history registry.access.redhat.com/rhel7:latest --id 58dcba9208540e14f3c9f58d
[
    {
        "id": "58dcba9208540e14f3c9f58d",
        "image_name": "registry.access.redhat.com/rhel7:latest",
        "static_analysis": {
            "os_packages": {
                "ok_os_packages": 117,
                "os_packages_details": [
                    {
                        "is_vulnerable": false,
                        "product": "tzdata",
                        "version": "2016j",
                        "vulnerabilities": []
                    },
                    {
                        "is_vulnerable": false,
                        "product": "setup",
                        "version": "2.8.71",
                        "vulnerabilities": []
                    },
                    {
                        "is_vulnerable": false,
                        "product": "basesystem",
                        "version": "10.0",
                        "vulnerabilities": []
                    },
                    {
                        "is_vulnerable": true,
                        "product": "glibc",
                        "version": "2.17",
                        "vulnerabilities": [
                            "CVE-2012-4412",
                            "CVE-2012-4424",
                            "CVE-2013-0242",
                            "CVE-2013-1914",
                            "CVE-2013-2207",
                            "CVE-2013-4237",
----CUT----
			    "BID-92257"
                ],
                "total_os_packages": 149,
                "vuln_os_packages": 32
            },
            "prog_lang_dependencies": {
                "dependencies_details": {
                    "java": [],
                    "js": [],
                    "nodejs": [],
                    "php": [],
                    "python": [],
                    "ruby": []
                },
                "vuln_dependencies": 0
            }
        },
        "timestamp": "2017-03-30 07:58:21.492561"
    }
]

Any recomendation? Thanks in advance @eliasgranderubio !

Hi @scumfrog,
did you cloned again the project? The cve_info was added recently.
With last version added 1 week ago, when you call the init of vulndb you will see a new collection called cve_info that contains extra info about cve's. At this point, if you analyze a container, the output will contains each cve extra info
Best regards

Hi @eliasgranderubio ,
Good point! Hehe.. i just clone again the project, but it comes with a new error:
# rm -rf dagda/
[root@breaknoise Downloads]# git clone https://github.com/eliasgranderubio/dagda.git
Cloning into 'dagda'...
remote: Counting objects: 1087, done.
remote: Compressing objects: 100% (143/143), done.
remote: Total 1087 (delta 75), reused 0 (delta 0), pack-reused 944
Receiving objects: 100% (1087/1087), 1.09 MiB | 531.00 KiB/s, done.
Resolving deltas: 100% (647/647), done.
Checking connectivity... done.
[root@breaknoise Downloads]# cd dagda/
[root@breaknoise dagda]# cd dagda/
[root@breaknoise dagda]# python3 dagda.py start
Traceback (most recent call last):
  File "dagda.py", line 130, in <module>
    main(DagdaCLIParser())
  File "dagda.py", line 54, in main
    from api.dagda_server import DagdaServer
  File "/home/scumfrog/Downloads/dagda/dagda/api/dagda_server.py", line 25, in <module>
    from api.internal.internal_server import InternalServer
  File "/home/scumfrog/Downloads/dagda/dagda/api/internal/internal_server.py", line 27, in <module>
    class InternalServer:
  File "/home/scumfrog/Downloads/dagda/dagda/api/internal/internal_server.py", line 33, in InternalServer
    _docker_driver = DockerDriver()
  File "/home/scumfrog/Downloads/dagda/dagda/driver/docker_driver.py", line 34, in __init__
    self.cli = docker.APIClient(base_url='unix://var/run/docker.sock', version="auto", timeout=3600)
AttributeError: module 'docker' has no attribute 'APIClient'

@eliasgranderubio sorry for my double post. I just read in another project a similar issue:

the docker-py python module, which is now called docker and has an incompatible api. If you remove the docker-py python module from your system and install the docker module instead, the issue should be gone.

Any clue? Thanks in advance!

Hi @scumfrog ,
See this comment in the issue #11. I think that your issue with docker-py will be fixed when you install again the requirements.

Hi @eliasgranderubio ,
You're right, i just uninstalled all the requirements and reinstalled them, and works like a charm. Thanks for your help as always :+1: But when i launch the scan, at the end, the server shown me an error:
<2017-03-30 12:18:02,699> <ERROR> <DagdaServer> <analyzer> <Unexpected exception of type DagdaError occured: ()>
The report footer:
        "status": "Unexpected exception of type DagdaError occured: ()",
        "timestamp": "2017-03-30 10:18:02.699337"
    }

The only way you can get the 'UnboundLocalError' is commenting the line L52, so it looks like you have commented too many lines with the workaround, is it right?
On the other hand, the deepfenceio/deepfence_depcheck docker image needs download its own CVE database for OWASP Dependency Check, so you could have errors that they are unknown for me. Anyway, I am trying to fix the issues with this docker image with the Deepfence help.

@eliasgranderubio yes, thats right, i'm sorry, typo error. Now it works without the last error, uncommenting the L52. In the other hand, the CVE detailed info now is displayed perfectly (but with the error in parsing the backporting as i write in the last issue. Thanks for your greate help. I close the issue. :+1:


[Feature] Email field place holder not properly aligned

Problem
For not the design of the footer is quite alright, just some minor issues to fix here again!
The placeholder of the email field at the level of the footer is not properly aligned. The screenshot below illustrates this behavior

Description
To improve the UX of the creative common site, implementing nice looking features should be considered as priority.
Implementation

with just some raw and simple CSS we can achieve this easily
[x] I would be interested in implementing this feature.

Closing this, issues related to this would have been resolved in the new Vocabulary, currently in development within index-prototype


Add support for loading dependencies of dll devices

This pull request proposes the following changes:

Use custom AppDomain.AssemblyResolve event handler to load dependencies of dll devices.
It searches for the dependencies in the same directory the device's dll is located.

Thank you for contributing.


Add compat for Dates, DelimitedFiles and Artifacts

Purpose
Add compat entries for Dates, DelimitedFiles and Artifacts to comply with Julia Registrator's requirements

[x] I have read and checked the items on the review checklist.

bors try

bors r+


[SPARK-41931][SQL] Better error message for incomplete complex type definition

What changes were proposed in this pull request?
This PR improves error messages for ARRAY / MAP / STRUCT types without element type specification. A new error class INCOMPLETE_TYPE_DEFINITION with subclasses (ARRAY, MAP, and STRUCT) is introduced.
Details
In the case where we do CAST AS or CREATE a complex type without specifying its element type,
e.g.
CREATE TABLE t (col ARRAY)

[UNSUPPORTED_DATATYPE] Unsupported data type "ARRAY" error would be thrown, while we do support the ARRAY type and just require it to be typed.
This PR proposes a better error message like
The definition of `ARRAY` type is incomplete. You must provide an element type. For example: `ARRAY<elementType>`.

Why are the changes needed?
The previous error message for incomplete complex types is confusing. A UNSUPPORTED_DATATYPE error would be thrown, while we do support complex types. We just require complex types to have their element types specified. We need a clear error message with an example in this case.

Does this PR introduce any user-facing change?
Yes, this PR changes the error message which is user-facing.
Error message before this PR:
spark-sql> SELECT CAST(array(1, 2, 3) AS ARRAY);

[UNSUPPORTED_DATATYPE] Unsupported data type "ARRAY"(line 1, pos 30)

Error message after this PR:
[INCOMPLETE_TYPE_DEFINITION.ARRAY] Incomplete complex type: The definition of `ARRAY` type is incomplete. You must provide an element type. For example: `ARRAY<elementType>`.

Similarly for MAP and STRUCT types.

How was this patch tested?
Added unit tests covering CAST and CREATE with ARRAY / STRUCT / MAP types and their nested combinations.

Can one of the admins verify this patch?

@MaxGekk Thanks! Done enabling GitHub action.

cc @srielau to review the error message

@RunyaoChen What is your JIRA account? I would like to resolve and assign SPARK-41931 to you, and add you to the list of Spark contributors.

@MaxGekk  My JIRA account is<EMAIL_ADDRESS>Thank you for reviewing and merging the PR!

@RunyaoChen Such account doesn't exist in OSS JIRA (https://issues.apache.org/jira):

If you don't have any account, I can create it for you.

Backport: https://github.com/apache/spark/pull/39833

Such account doesn't exist in OSS JIRA (https://issues.apache.org/jira):

@MaxGekk Thanks! Gengliang helped create one.
Username:	runyao
Full name:	Runyao.Chen
email<EMAIL_ADDRESS>


De-IR-ify

// ./tests/smoke/id/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("x");
  locals[5] = locals[4];
  if (locals[3].IsUndefined()) {
    locals[3] = locals[5];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/smoke/sum/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("a");
  locals[5] = locals[4];
  locals[6] = locals[0].GetByKey("b");
  locals[7] = locals[6];
  locals[8] = function_0(locals[0], locals[1]);
  locals[9] = locals[8];
  if (locals[3].IsUndefined()) {
    locals[3] = locals[9];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/smoke/constant_bool/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  if (locals[3].IsUndefined()) {
    locals[3].SetBoolean(true);
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/smoke/subtract/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("a");
  locals[5] = locals[4];
  locals[6] = locals[0].GetByKey("b");
  locals[7] = locals[6];
  locals[8] = function_0(locals[0], locals[1]);
  locals[9] = locals[8];
  if (locals[3].IsUndefined()) {
    locals[3] = locals[9];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/smoke/constant_int/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4].SetNumberFromString("42");
  if (locals[3].IsUndefined()) {
    locals[3] = locals[4];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/smoke/constant_string/policy.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  if (locals[3].IsUndefined()) {
    locals[3].SetString("foo");
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/indirect_call/p1.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2, value_t p3) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  locals[3] = p2;
  value_t retval;
  locals[4].ResetToUndefined();
  if (locals[3].IsString("add")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    locals[11] = locals[10];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[11];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  locals[4].ResetToUndefined();
  if (locals[3].IsString("mul")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    locals[11] = locals[10];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[11];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  locals[4].ResetToUndefined();
  if (locals[3].IsString("range")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    locals[11] = locals[10];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[11];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  retval = locals[2];
  return retval;
}
value_t function_1(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("f");
  locals[5] = locals[4];
  locals[6] = function_0(locals[0], locals[1], locals[3]);
  locals[7] = locals[6];
  if (locals[3].IsUndefined()) {
    locals[3] = locals[7];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_1(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/indirect_call/p3.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2, value_t p3) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  locals[3] = p2;
  value_t retval;
  locals[4].ResetToUndefined();
  if (locals[3].IsString("add")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[10];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  locals[4].ResetToUndefined();
  if (locals[3].IsString("mul")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[10];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  locals[4].ResetToUndefined();
  if (locals[3].IsString("range")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1], locals[3]);
    locals[10] = locals[9];
    if (locals[4].IsUndefined()) {
      locals[4] = locals[10];
    }
  }
  if (!locals[4].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[4];
    }
  }
  retval = locals[2];
  return retval;
}
value_t function_1(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("f");
  locals[5] = locals[4];
  locals[6] = function_0(locals[0], locals[1], locals[3]);
  locals[7] = locals[6];
  if (locals[3].IsUndefined()) {
    locals[3] = locals[7];
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_1(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

// ./tests/indirect_call/p2.rego.stage3.cpp
value_t function_0(value_t p1, value_t p2) {
  locals_t locals;
  locals[0] = p0;
  locals[1] = p1;
  value_t retval;
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("f");
  if (locals[4].IsString("add")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1]);
    locals[10] = locals[9];
    if (locals[3].IsUndefined()) {
      locals[3] = locals[10];
    }
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("f");
  if (locals[4].IsString("mul")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1]);
    locals[10] = locals[9];
    if (locals[3].IsUndefined()) {
      locals[3] = locals[10];
    }
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  locals[3].ResetToUndefined();
  locals[4] = locals[0].GetByKey("f");
  if (locals[4].IsString("range")) {
    locals[5] = locals[0].GetByKey("a");
    locals[6] = locals[5];
    locals[7] = locals[0].GetByKey("b");
    locals[8] = locals[7];
    locals[9] = function_0(locals[0], locals[1]);
    locals[10] = locals[9];
    if (locals[3].IsUndefined()) {
      locals[3] = locals[10];
    }
  }
  if (!locals[3].IsUndefined()) {
    if (locals[2].IsUndefined()) {
      locals[2] = locals[3];
    }
  }
  if (locals[2].IsUndefined()) {
    locals[11].MakeNull();
    if (locals[2].IsUndefined()) {
      locals[2] = locals[11];
    }
  }
  retval = locals[2];
  return retval;
}
result_set_t policy(value_t input, value_t data) {
  locals_t locals;
  locals[0] = input;
  locals[1] = data;
  result_set_t result;
  locals[2] = function_0(locals[0], locals[1]);
  locals[3] = locals[2];
  locals[4].MakeObject();
  locals[4].SetValueForKey("result", locals[3]);
  result.AddToResultSet(locals[4]);
  return result;
}

Heh, neat!
I'd do it a bit differently (can fit everything into two stages, not three, IMHO), but this most certainly is a huge step forward.
I'll merge the code and look at the actual code later :-)


Remove all backends except raqote

Originally, when resvg was started (2.5 years ago) there was no raqote. So the only solution was to use an existing 2D libraries like cairo and Qt.
The initial requirements for a 2D library were:

Shapes rendering (filling, stroking, gradients, patters).
Layers compositing.
Text rendering (the most complex one).
JPEG/PNG handling.

But that was a long time ago. Right now, resvg requires only the first two points. Text rendering, JPEG/PNG handling, and filters are done in a backned-independent manner already. So the only reason to have multiple backends is to render very simple SVG images (no opacity, clipping, masking, filters, images) on an existing canvas.
So the idea is to remove all backends except raqote, while C API will be changed to return just a Vec<u8> as a resulting image (not PNG encoded).
This will simplify things quite a bit. The only downside is that raqote is a bit slow and unstable. But this can (and will) be fixed.
@JaFenix, @therealbnut if you are still using resvg, what are your thoughts about this change? Is it absolutely necessary to have a Skia based backend for you?

For context, this does not impact out-of-tree "backends" such as Lyon and Pathfinder - they use usvg crate only.

Yes, usvg isn't going anywhere. resvg will still be split into two modules.

For rendering purposes, there isn't anything specific about Skia that would be necessary for me.  Provided that Raqote executes safely and efficiently inside of an OpenGL (hardware accelerated), Skia-based application, then it should not be necessary to have a Skia specific backend.  It would be sufficient for the C API to return a pointer to a rendered bitmap.
Performance and memory consumption are the only concerns.  The performance will ideally have to be as good as Skia's software renderer, or at least as good as a web browser (some of which use Skia), because our application competes with the browsers in terms of rendering performance.  I imagine there will be some additional memory overhead with loading the Raqote library into the application's process in addition to Skia.  Currently, we only load Skia, so this affords us a nice optimization.
One minor thing that's specific to the Skia backend is the render_rect_to_canvas() function which I've added to the backend_skia/mod.rs file in our m58 branch (https://github.com/JaFenix/resvg/blob/611fb21f4912f89bce0a4aaf60b0be6687efb342/src/backend_skia/mod.rs#L119).  This function allows the calling application to specify a region of the SVG to render, instead of the whole thing.  But this does not require Skia, so if it were available in the proposed C API or could be added in a fork, then  we'd be OK without the Skia backend code.
So the proposal sounds good once the benchmarks are there, and we would have used resvg in the beginning like it's being proposed now.  However, I do think resvg has a good architectural model by which different backends can be constructed and selected by application developers.  This (in theory) makes it possible to use the optimized aspects of one backend over another.  It's a nice selling point and it might mean giving up these advantages if the backend model were eliminated.

Thanks for reaching out @RazrFalcon, I'll have a more in-depth think about it, but here's my initial thoughts:
We pretty much do this:

the only reason to have multiple backends is to render very simple SVG images (no opacity, clipping, masking, filters, images) on an existing canvas.

We also want to have a similar render_rect_to_canvas capability to what @JaFenix mentioned.
We prefer to be able to output to vector (Skia's PDF backend), with simple SVGs, something that's not really supported at the moment, but just happens to work most of the time. I don't think raqote supports vector output.

We'd lose a lot of our value from resvg if we couldn't do those things. I personally feel it'd be a shame to lose the flexibility, but I understand the pragmatism.
Maybe you could start by reducing support to raqote and Skia for a transitionary period, it might reduce the complexity and have more overlap for a common backend interface?

@JaFenix Thanks for a detailed feedback.
According to my "benchmarks", raqote isn't that slow, but still considerably slower than Skia. I hope that this can be fixed soon. I do not plan to remove other backends right now.
Memory overhead should be the same. There are no changes there. As for the library size overhead, according to the cargo-bloat, raqote adds like 100KiB, so it's basically nothing. Especially since usvg itself is like 500KiB and HarfBuzz adds like 800KiB.

or at least as good as a web browser

raqote is used in Servo. If you can call it a browser :smile: But yes, performance is the main concern.

render_rect_to_canvas

How exactly does it work? Is it simply a clip-path?

It's a nice selling point and it might mean giving up these advantages if the backend model were eliminated.

I agree. And support for custom backends isn't going anywhere. The problem is that current backends lost their purpose.

@therealbnut Yes, I thought about a PDF export. But as I already said in the related issue, it's broken by design. Yes, it sort of works, but we need a dedicated PDF backend anyway.

Maybe you could start by reducing support to raqote and Skia for a transitionary period

Yes. This is a good idea. I'm thinking about removing Skia from the main library (e.g resvg) and reimplementing it as a separate library/repo. With its own C API, etc. The only problem is that filters should be extracted into a separate crate.
The problem with multiple backends is that it confuses some people, build instructions become notorious, etc. So I want to make the main repo/lib more focused and simple, but also have separate implementations.

@RazrFalcon

How exactly does it work? Is it simply a clip-path?

render_rect_to_canvas works a like a "zoom in" function.  The src parameter is a rectangle within the bounds of the screen size of the SVG (i.e. tree.0.svg_node().size.to_screen_size()).  This src rectangle is scaled into the bounds of a destination rectangle (img_size) when rendered.  For example, if the SVG contained a 500x100 map of the world, render_rect_to_canvas could select an area (src rect) around one country and render that to a 1000x1000 image (img_size).  This "zoom in" effect is accomplished by applying the viewbox transform to the screen size of the SVG rather than the img_size, and translating/scaling the src rectangle from the SVG screen size into the destination img_size.

I'm not sure if this can be considered as an optimizations, since resvg always renders the whole canvas.

@RazrFalcon
render_rect_to_canvas is not intended to be a performance optimization, but rather a way to clip & scale part of the SVG without pixellation.  Our users have an editor that allows them to add images to their "page" at various sizes and clip regions.   They don't really distinguish between SVG, PNG, JPG, etc, except they do expect that SVGs will not pixellate when clipped & stretched.  So render_rect_to_canvas is designed to take a source clip region and destination size and render the SVG to those specifications.
To do this, I found it necessary to push the sequence of transformation matrices onto the Skia canvas prior to rendering.  However, I did this inside of resvg because the translate/scale (clipping) transformation has to be applied before the viewbox transform, which is calculated and applied inside of resvg.   In other words, I could not set the canvas matrix before passing it in because some of the information (viewbox dimensions) is available and applied inside resvg.  Likewise, apply clipping & stretching after rendering would result in pixellating the image.

I see. I think it might be a good addition to the API.

makes sense to me. looking forward to trying the raqote with the capi when it can output raw data

Looks like raqote is way too far from completion. Closing this for now.


Resolving issue 389

#389
include guards have been removed and replaced with #pragma once
There are a few header files that did not have include guards or #pragma once,  those i noted with a comment stating NO INCLUDE GUARDS

Yeah the headers without include guards you were noticing are there bc historically the codebase had a very crude way of using header files.. good thing you already placed comments, so we can just find&replace in files-them.
So two changes then we can merge:
-[ ] squash the commits to one

called maybe [REFACTOR] replace include guards \n\n resolves #389
-[ ] replace "//NO INCLUDE GUARDS" with "#pragma once"

If you want I can do the first when merging
Thank you for your contribution Bryan!

Merged with c588af8f1ac0b43ab8e848acbf80f8021f277672


Class file has wrong version 61.0, should be 52.0

When using this library in my tests I get this error message:
java: cannot access be.seeseemelk.mockbukkit.MockBukkit   bad class file: /C:/Users/Mats/.m2/repository/com/github/seeseemelk/MockBukkit-v1.18/1.24.1/MockBukkit-v1.18-1.24.1.jar!/be/seeseemelk/mockbukkit/MockBukkit.class     class file has wrong version 61.0, should be 52.0     Please remove or make sure it appears in the correct subdirectory of the classpath.
It appears that the maven artifact was compiled with Java 17, and therefore I can't use it in my Java 8 project.

Yes that is correct.
You will need Java 17 to be able to access classes that were compiled with Java 17.
Please update your Java version, you are quite far behind.
By the way Java is backwards-compatible. So you can still compile against Java 8, even if you have newer versions installed.


WIP: run recon_all if freesurfer directory not found

This PR will run freesurfer from as a part of the Tracula container #20.

[ ] REF the selection of subjects/sessions: only consider subjects/sessions that have at least one t1w and one dwi file
[ ] add a flag that allows to run a brief freesurfer test on ci; check output on ci
[ ] It  will also add checks for truly-long #1
[ ] reconsider non-truly-long output format; like FS? (sub-01) -> instead of if sessions-> if len(sessions)>0
[ ] wait for bids/freesurfer:v6.0.0-5 release: update docker file
[ ] ci test  truly-long

freesurfer bids app version 6.0.0-5 is released
On Thu, Aug 3, 2017 at 1:59 PM, Franz Liem<EMAIL_ADDRESS>wrote:

This PR will run freesurfer from as a part of the Tracula container #20
https://github.com/BIDS-Apps/tracula/issues/20.

REF the selection of subjects/sessions: only consider
subjects/sessions that have at least one t1w and one dwi file
wait for bids/freesurfer:v6.0.0-5 release to implement freesurfer
processing for not truly-long-studies
add a flag that allows to run a brief freesurfer test on ci
It will also add checks for #1
https://github.com/BIDS-Apps/tracula/issues/1

You can view, comment on, or merge this pull request online at:
https://github.com/BIDS-Apps/tracula/pull/21
Commit Summary

add n_cpus and cleanup
add bids/freesurfer repo and cleanup

File Changes

M Dockerfile
https://github.com/BIDS-Apps/tracula/pull/21/files#diff-0 (23)
M run.py
https://github.com/BIDS-Apps/tracula/pull/21/files#diff-1 (7)

Patch Links:

https://github.com/BIDS-Apps/tracula/pull/21.patch
https://github.com/BIDS-Apps/tracula/pull/21.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/BIDS-Apps/tracula/pull/21, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkp3sOMbu4A2DzUBOdKhuQyJ6DKwdqks5sUjSqgaJpZM4Os-4i
.

This is a major overhaul and most importantly:

runs recon-all if not found in freesurfer_dir. Closes #20
parallelizes the computation
fixes bedpost random seed to get the exactly same results when running an analysis twice
checks if study is truly longitudinal (or just 1 session with ses- level) and handles fs_dir names like the freesurfer app. Closes #1
adds support for multiple bval-files per subject. Closes #5
adds pathstats-byvoxel to group2
should make it openneuro compatible

Initial tests look good. I will run some more and compare with the output of the previous version.
@chrisfilo do you have any suggestions? If not, I'll merge as soon as the tests check out.

I only had a quick look, but it looks ok. I like how you are reusing code from FreeSurfer BIDS App.


storage/postgres: add NewWithDB to allow accepting an established *sql.DB

Description

[!warning]
Waiting for bandwidth to finish up this PR.

References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Hi,

How/where are you planning to use this new function? Are you going to send a follow-up PR? Or is this just a refactor?

We are already using this function in our codebase, and I anticipant no use case (for now) within the OpenFGA codebase, since all of call sites would continue to use the current New constructor function. Therefore this is just a necessary refactor.

Could we apply the same change to the Postgres adapter please?

Where exactly is the "Postgres adapter" you're referring to? Could you point me to a link/file?

Could we apply the same change to the Postgres adapter please?

Where exactly is the "Postgres adapter" you're referring to? Could you point me to a link/file?

Here is the New function for Postgres: https://github.com/openfga/openfga/blob/b40a1e73fa5d845bb1f7f29dca84ac4b255e2e1c/pkg/storage/postgres/postgres.go#L48

Could we apply the same change to the Postgres adapter please?

Where exactly is the "Postgres adapter" you're referring to? Could you point me to a link/file?

Here is the New function for Postgres:
https://github.com/openfga/openfga/blob/b40a1e73fa5d845bb1f7f29dca84ac4b255e2e1c/pkg/storage/postgres/postgres.go#L48

Hmm, isn't this PR changing the this exact file? I'm not sure I follow what do you mean by "apply the same change" then.

@unknwon ohh my bad, sorry! I meant if we could also update MySQL 😅 https://github.com/openfga/openfga/blob/main/pkg/storage/mysql/mysql.go#L47

Hi @miparnisari, who should I ask for reviews for this PR?


Release 0.11.0

I think we are not ready for the 1.0.0 but we have made many improvements. We could make a new release: v0.11.0.

I make the release then I will add a tuto about the solve function and then I will make a break.

@JuliaRegistrator register()

Error while trying to register: Version 0.10.0 already exists

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/112942
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.11.0 -m "<description of version>" 02906fde07b6bf6c16282df91de8697d748455fa
git push origin v0.11.0


Project Template

Please Check all code and make sure everything is fine or not.

We resolved all problems.everything is fine.


Issues on nodemon

Hi there I cant start nodemon... Can you check to please my rep in order to verify if something its wrong...?
How about an upgrade to version 9 ?
And the pkg?
Any result for your side.
Thanks

I could updated to version 9 of next js and run
"start": "npm run build && env NODE_ENV=production node app.js",
its running ok
but I can't run
"dev": "  nodemon  --ignore app/ app.js",
cant you help please ?

I got this run npm run dev
[nodemon] 1.19.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `node app.js`
> Using "webpackDevMiddleware" config function defined in next.config.js.
[ ready ] compiled successfully
[ wait ]  compiling ...
[ ready ] compiled successfully
[ event ] build page: /
[ wait ]  compiling ...

it stays stuck...

in next.conf.js
I have this:
const compose = require("next-compose");
const withCSS = require("@zeit/next-css");
const withSass = require("@zeit/next-sass");
const withImages = require("next-images");

module.exports = compose([
  withCSS,
  withSass,
  withImages
]);

hi can i help you in solving this problem as i also get same problem  in nodemon and dev  but i solved that .

Hi there, thanks by the reply...Can you help me further?
What can I do to solve it?
Thanks
Carlos Vieira

hi, can we please give the link of your code as a have to check the scripts in your package.json file or you can try to make changes in that file

https://github.com/ShintaroNippon/next-express-bootstrap-boilerplate
.thanks!

https://stackoverflow.com/questions/57449827/how-to-setup-node-start

okay i will try and get back to you sooner.

will i add babel or you want to only use ES6 ,as such i can try to add without babel also.

Thanks... I have a Babel rio. But is with underscore written
Apply your chances and then i check
Thanks

okay

https://user-images.githubusercontent.com/44085127/63369997-dd815300-c39e-11e9-874d-6c663652b0e3.png
hi,is this working fine or more need to be changed

terminal
https://user-images.githubusercontent.com/44085127/63370424-c3944000-c39f-11e9-8118-0c99d4d4a9d1.png

even i started with npm dev run its looks the same

Hi there. Thanks by the help...
What did you changed to start with nodemon ?

Im not sure how can I add permissions !?!?

hi , i added babel cli and bin file with change in the script in the package json

and for collaboration go for the setting and add me on contributors

Thanks
I already add permissions, can you apply the changed ?
Thanks in advance

hi @ShintaroNippon  i pushed the code you can check .
thanks

Hi there, sorry if is to much, but i have made changes like you told
and after run localhost::3000
I got this
><EMAIL_ADDRESS>dev /home/shintaro/Desktop/projects/github/frontend
> nodemon ./bin/www --exec ./node_modules/.bin/babel-node -e js

[nodemon] 1.19.1
[nodemon] to restart at any time, enter `rs`
[nodemon] watching: *.*
[nodemon] starting `./node_modules/.bin/babel-node ./bin/www`
.env.development development
> Using "webpackDevMiddleware" config function defined in next.config.js.
[ ready ] compiled successfully
[ wait ]  compiling ...
[ ready ] compiled successfully
[ event ] build page: /
[ wait ]  compiling ...

the app doesn't run in localhost:3000
only with npm run learn it works
thanks
Carlos Vieira

Its okay but as shown in the picture of the terminal i started the terminal with "npm start" and its working fine, have you pull the request which i  was commited today?

Sorry but I dont see working with npm start, it loads as code before
but when oppen localhost:3000
it doesn't show anything...
thnaks

then,you can do one thing make a repo and make me collaborator and i push the code  and you make the fresh clone and do npm i and then check whether it is running or not. as there can be some problem  in merging the code.
thanks


Upgrade sld-parser, make use of SLD 1.1

Description
This update the geostyler-sld-parser package and adds options to the CodeEditor to select the parser with symbology encoding features.

Related issues or pull requests
Please list issues or pull requests that the changes you propose are related to. It does not matter if they are still open and/or unmerged, any link is appreciated.
Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[x] Dependency updates
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
[x] I have followed the guidelines for contributing
[x] The proposed change fits to the content of the code of conduct
[x] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[x] I'm lost; why do I have to check so many boxes? Please help!

I think you might to tweak the code in getParserOptions too. So you could add both SLD 1.0.0 and SLD 1.1.0 parser.

No need, as its given as prop (parsers). Already tested and working on the demo, but cannot create PR yet

Sorry for bumping in another commit after review, but that one is a real small one... :-)
Thanks for review!

Sorry for bumping in another commit after review, but that one is a real small one... :-)
Thanks for review!

So metre is correct? :)

Yes, its the only valid definition for meter ... :cry:


feature: add metadata information into the embedding file before uplo…

Replace this entire comment with:

Description: In this modified version of the function, if the metadatas parameter is not None, the function includes the corresponding metadata in the JSON object for each text. This allows the metadata to be stored alongside the text's embedding in the vector store.

Issue: #10924
Dependencies: None
Tag maintainer: @hwchase17
@agola11
Twitter handle: @MelliJoaco

cc @tomaspiaggio @scafati98

thanks @joaquinmenendez!


Double click API

Hi,
I am trying to do a double click on an html object and I could not find a proper API in Chromy. Is double click supported?
Thanks,
Charlotte

Hi,
there isn't double click api.
but you can use click api twice for emulating double click as below
.click('button#b1')
.sleep(50)
.click('button#b1')
.end()


Updating the Readme file with perf optimizations and monitoring commands

Adding performance optimizations and monitoring the monitor sections to the readme file.

@astrostakers thanks for your suggestions!

@astrostakers thank you so much for your help and attention to this project!


convectorControllers.ts:18:9 - error TS2554: Expected 0 arguments, but got 1

@instameddevelopment thank you for sharing this project.
I'm using Ubuntu 19.10 and Node 8.11.0.
I stumble on the following error after the first command npm install:
><EMAIL_ADDRESS>clean /home/elisson/github/healthcare-payments-blockchain/packages/server
> rimraf dist client

src/convectorUtils/convectorControllers.ts:18:9 - error TS2554: Expected 0 arguments, but got 1.

18   await SelfGenContext.getClient(user);
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `npm run clean && tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>lerna:install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/elisson/.npm/_logs/2020-01-31T21_09_09_725Z-debug.log

Could you point me in right direction of what might be wrong?

Thanks for reporting, #10 will fix this


Crash when using R2 to run macro Alt-F4

Set R2 to be a macro that clicks Alt-F4. Crashes application.
LMenu press
F4 press
F4 unpress
LMenu unpress

I've tried this macro out and had no problems, do other macros work for you? Does regular Keyboard mapping work for you?

Other macros seem to work.
There seems to be a case where the "press" is not recorded due to be being handled by another application leaving it with
LMenu press
F4 unpress
LMenu unpress
This seems to crash.

i'm not sure why the first f4 isn't recorded, but i found the error, and it will be fixed in the next update.


Use relative paths for python data source.

As @chrisroat noticed in the comment thread of #150, local data sources are no longer working through jupyter-server-proxy.  The problem stems from the root-relative URLs.
An example URL for neuroglancer with jupyter-server-proxy would be http://localhost:8888/proxy/58060/v/f9dd9e35803d93ee67997951bf4a138a9abb7983/
This PR is a quick & dirty fix illustrating the problem. I'm not sure what a proper @jbms solution would be. 🙂
I know this worked ~1-2 years ago. Were the data URLs previously under the token?

Thanks!


fixed playout delay logic

removed the redundant line

What exactly fixes this change? Are we going to keep this project?


As a CIF developer, I want the attachment API and Minio containers to be deployed with the helm chart, so that they're available on the cluster

Description:
We need to have the helm chart deploy

the python API container
the Minio container

Acceptance Criteria:
Given I am a CIF developer
When I deploy the CIF app on the cluster
Then the Python API and the Minio server are available for the rest of the app to use
Development Checklist:

[ ] helm chart update
[ ] environment variables are properly set for the CIF app, the python api and the minio container
[ ] Meets the DOD

Notes:

Hey team! Please add your planning poker estimate with ZenHub @BCerki @dleard @gurjmatharu @matthieu-foucault @mikevespi @Sepehr-Sobhani

Closing this one since we're not using Minio anymore


Passing options to toggle wrapper

I added the ability to pass additional content_tag options to the toggles method. Something like:
f.toggles 'Label', :class => 'my-toggles', :id => 'my-toggles' do
  ...
end

Hmm...not sure how these two conversations got merged...


[Question] Using a test helper module with external transformation

Hello
I'd like to run Xspec with @run-as="external" and <x:helper stylesheet="helper.xsl" />
It seems that my helper module is not included.
Is it possible to do this ?
Thanks!

With @run-as="external", helper modules are not included while running your stylesheets being tested. They are included only when setting up test parameters (such as x:call/x:param/@select and x:context/@select) or inspecting test results (such as x:expect/(@select|@test).
See the x:helper and @run-as="external" section in Wiki.

Hi, @vdeygas .
Do you have any follow-up questions about your helper module, or was the answer from @AirQuick sufficient?

I have one follow-up question.
Is the feature planned or considered on your roadmap ?
It would be convenient to include helper modules running run Xspec with @run-as="external".

Hi, @vdeygas .
When your XSpec test runs an external transformation, there is a deliberate separation between XSpec and the code you are testing. The helper module is included on the XSpec side -- just not on the XSLT side.
If we were to make the helper module available to the XSLT code being tested in an external transformation, I doubt it would be the default interaction of the helper and external features. I expect that some users want to avoid having their helper module "leak into" the system they're testing, and that's part of why they're using run-as="external".
Would either of these alternatives work for your situation, instead of using <x:helper>?
A) Include the helper module in the stylesheet you're testing. Perhaps the helper module contains functions and moded templates that you can be sure will never be invoked except from XSpec.
B) Create a test harness stylesheet that includes/imports both your real stylesheet and your helper module, and configure the XSpec file to point to the test harness stylesheet rather than your real stylesheet. This arrangement is depicted in the following section of a conference paper related to XSpec: High-Level File Structure to Enable Substitution. The use case in that paper is slightly different from your situation, but the diagram of the architecture is the same.
If not, can you say more about your situation to help us suggest other alternatives or design/prioritize a potential enhancement?


Brotli primitives

Add BrotliPrimitives and some changes to project configuration.

@Vedin,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Are we adding the project back into the corefxlab solution now?
This PR contains a lot of old commits. Please rebase/etc as necessary.


Exported GCP resources not valid, rejected with "Conflicting configuration arguments"

Steps I took:
$ terraformer import google --projects=xyz --resources=project,gke
$ terraform plan
...
│ Error: Conflicting configuration arguments
│
│   with google_container_cluster.tfer--xyz,
│   on container_cluster.tf line 235, in resource "google_container_cluster" "tfer--xyz":
│  235:   enable_shielded_nodes       = "true"
│
│ "enable_shielded_nodes": conflicts with enable_autopilot
...

The generate resources are not able to be applied. This occurs many many times (another example is "ip_allocation_policy": conflicts with cluster_ipv4_cidr).

I had this problem, too.
$ terraform plan
Releasing state lock. This may take a few moments...
╷
│ Error: Conflicting configuration arguments
│
│   with google_container_cluster.tfer---cluster,
│   on container_cluster.tf line 1, in resource "google_container_cluster" "tfer---cluster":
│    1: resource "google_container_cluster" "tfer---cluster" {
│
│ "ip_allocation_policy": conflicts with cluster_ipv4_cidr
╵
╷
│ Error: Conflicting configuration arguments
│
│   with google_container_cluster.tfer---cluster,
│   on container_cluster.tf line 20, in resource "google_container_cluster" "tfer---cluster":
│   20:   cluster_ipv4_cidr = "<IP_ADDRESS>/14"
│
│ "cluster_ipv4_cidr": conflicts with ip_allocation_policy
╵
╷
│ Error: expected settings.0.maintenance_window.0.day to be in the range (1 - 7), got 0
│
│   with google_sql_database_instance.tfer--db-sync,
│   on sql_database_instance.tf line 55, in resource "google_sql_database_instance" "tfer--db-sync":
│   55:       day  = "0"
│
╵
╷
│ Error: expected settings.0.maintenance_window.0.day to be in the range (1 - 7), got 0
│
│   with google_sql_database_instance.tfer---maindb,
│   on sql_database_instance.tf line 302, in resource "google_sql_database_instance" "tfer---maindb":
│  302:       day  = "0"
│
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 1, in resource "google_storage_bucket_iam_binding" "tfer--artifacts-002E---338419-002E-appspot-002E-com":
│    1: resource "google_storage_bucket_iam_binding" "tfer--artifacts-002E---338419-002E-appspot-002E-com" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 1, in resource "google_storage_bucket_iam_binding" "tfer--artifacts-002E---338419-002E-appspot-002E-com":
│    1: resource "google_storage_bucket_iam_binding" "tfer--artifacts-002E---338419-002E-appspot-002E-com" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 5, in resource "google_storage_bucket_iam_binding" "tfer--gcf-sources-72850880914-us-central1":
│    5: resource "google_storage_bucket_iam_binding" "tfer--gcf-sources-72850880914-us-central1" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 5, in resource "google_storage_bucket_iam_binding" "tfer--gcf-sources-72850880914-us-central1":
│    5: resource "google_storage_bucket_iam_binding" "tfer--gcf-sources-72850880914-us-central1" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 9, in resource "google_storage_bucket_iam_binding" "tfer--jpeg-optim-files":
│    9: resource "google_storage_bucket_iam_binding" "tfer--jpeg-optim-files" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 9, in resource "google_storage_bucket_iam_binding" "tfer--jpeg-optim-files":
│    9: resource "google_storage_bucket_iam_binding" "tfer--jpeg-optim-files" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 13, in resource "google_storage_bucket_iam_binding" "tfer----338419_cloudbuild":
│   13: resource "google_storage_bucket_iam_binding" "tfer----338419_cloudbuild" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 13, in resource "google_storage_bucket_iam_binding" "tfer----338419_cloudbuild":
│   13: resource "google_storage_bucket_iam_binding" "tfer----338419_cloudbuild" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 17, in resource "google_storage_bucket_iam_binding" "tfer----images":
│   17: resource "google_storage_bucket_iam_binding" "tfer----images" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 17, in resource "google_storage_bucket_iam_binding" "tfer----images":
│   17: resource "google_storage_bucket_iam_binding" "tfer----images" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 21, in resource "google_storage_bucket_iam_binding" "tfer--postgresexternalbackup":
│   21: resource "google_storage_bucket_iam_binding" "tfer--postgresexternalbackup" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 21, in resource "google_storage_bucket_iam_binding" "tfer--postgresexternalbackup":
│   21: resource "google_storage_bucket_iam_binding" "tfer--postgresexternalbackup" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 25, in resource "google_storage_bucket_iam_binding" "tfer--staging-002E---338419-002E-appspot-002E-com":
│   25: resource "google_storage_bucket_iam_binding" "tfer--staging-002E---338419-002E-appspot-002E-com" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 25, in resource "google_storage_bucket_iam_binding" "tfer--staging-002E---338419-002E-appspot-002E-com":
│   25: resource "google_storage_bucket_iam_binding" "tfer--staging-002E---338419-002E-appspot-002E-com" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 29, in resource "google_storage_bucket_iam_binding" "tfer--terraform--":
│   29: resource "google_storage_bucket_iam_binding" "tfer--terraform--" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 29, in resource "google_storage_bucket_iam_binding" "tfer--terraform--":
│   29: resource "google_storage_bucket_iam_binding" "tfer--terraform--" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 33, in resource "google_storage_bucket_iam_binding" "tfer--us-002E-artifacts-002E---338419-002E-appspot-002E-com":
│   33: resource "google_storage_bucket_iam_binding" "tfer--us-002E-artifacts-002E---338419-002E-appspot-002E-com" {
│
│ The argument "members" is required, but no definition was found.
╵
╷
│ Error: Missing required argument
│
│   on storage_bucket_iam_binding.tf line 33, in resource "google_storage_bucket_iam_binding" "tfer--us-002E-artifacts-002E---338419-002E-appspot-002E-com":
│   33: resource "google_storage_bucket_iam_binding" "tfer--us-002E-artifacts-002E---338419-002E-appspot-002E-com" {
│
│ The argument "role" is required, but no definition was found.
╵
╷
│ Error: Unsupported block type
│
│   on variables.tf line 4, in data "terraform_remote_state" "local":
│    4:   config "terraform" {
│
│ Blocks of type "config" are not expected here. Did you mean to define
│ argument "config"? If so, use the equals sign to assign it a value.

I had the same issue. very appreciate if anyone can take a look


Initial partial implementation of SSA block parameters

This is to replace the old FunctionBuilder that uses phi instructions instead of block parameters.
The underlying algorithm for both SSA constructions remains the same: Simple and Efficient SSA Construction [Paper]

Codecov Report

Merging #11 (4dc955f) into master (d47aa9a) will decrease coverage by 3.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   65.72%   62.46%   -3.26%
==========================================
  Files          89       91       +2
  Lines        5313     5590     +277
==========================================
  Hits         3492     3492
- Misses       1821     2098     +277

Impacted Files
Coverage Δ

crates/module/src/func_body2/builder.rs
0.00% <0.00%> (ø)

crates/module/src/func_body2/value.rs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47aa9a...4dc955f. Read the comment docs.


Feature: Refactor Search Form into separate component, add it to results page

Nice, it looks better than I expected 👍


Add SI units for small numbers?

fixed by other means: Use ellipsis and allow user to expand the view


Write email for Industry Associations

Our next phase will be talking to Industry associations.
Acceptance Criteria:

[x] Write draft email to send to industry associations
[x] Send draft to team for feedback
[x] Pivot on feedback if necessary
[x] Share with wider project team

Hi @LindsayMacfarlane, do you have any feedback on the email to industry associations linked above?

@jaimiebutton - I've included feedback in the word document. We should probably circulate to Chris/Emilie for feedback/input as well.

@jaimiebutton - Feedback received from Chris. Closing ticket based on sprint planning discussion. Thank you for drafting!


[B23] Amber Infusions not OreDic compatible

I tried Runic Shielding Infusion with Amber from BoP. Despite both being registered as "gemAmber", only TC Amber can be used for the Infusion

Looking at the surrounding chunks, most of them are indeed depleted. Only about 3 had Vis in them


ARROW-5735: [C++] Pin boost-cpp=1.69.0 to fix MSVC builds

See if this has anything to do with the failure we're seeing

This seems actually to be a Boost-related issue
-- Found Boost 1.70.0 at C:/Miniconda36-x64/envs/arrow/Library/lib/cmake/Boost-1.70.0
--   Requested configuration: QUIET COMPONENTS regex;system;filesystem
-- Found boost_headers 1.70.0 at C:/Miniconda36-x64/envs/arrow/Library/lib/cmake/boost_headers-1.70.0
-- Found boost_regex 1.70.0 at C:/Miniconda36-x64/envs/arrow/Library/lib/cmake/boost_regex-1.70.0
--   libboost_regex.lib
-- Adding boost_regex dependencies: headers
-- Found boost_system 1.70.0 at C:/Miniconda36-x64/envs/arrow/Library/lib/cmake/boost_system-1.70.0
--   libboost_system.lib
-- Adding boost_system dependencies: headers
-- Found boost_filesystem 1.70.0 at C:/Miniconda36-x64/envs/arrow/Library/lib/cmake/boost_filesystem-1.70.0
--   libboost_filesystem.lib
-- Adding boost_filesystem dependencies: headers
-- Boost 1.58 found.
-- Found Boost components:
   regex;system;filesystem
-- Boost include dir:
-- Boost libraries:

Here is from a passing Boost build:
-- Boost version: 1.69.0
-- Found the following Boost libraries:
--   regex
--   system
--   filesystem
-- Boost include dir: C:/Miniconda36-x64/envs/arrow/Library/include
-- Boost libraries: C:/Miniconda36-x64/envs/arrow/Library/lib/libboost_regex.libC:/Miniconda36-x64/envs/arrow/Library/lib/libboost_system.libC:/Miniconda36-x64/envs/arrow/Library/lib/libboost_filesystem.lib

It looks like Boost 1.70.0 is the culprit
https://ci.appveyor.com/project/wesm/arrow/builds/25537882/job/x8m8m38yy1qm4k2a?fullLog=true#L373
I'm going to try pinning to see if it fixes the build

Pinning Boost 1.69.0 seems to have done the trick, 1.70.0 must have been getting held back because of a constraint in the dependency graph until sometime today. We'll have to create a follow up issue to figure out why Boost 1.70.0 doesn't work properly with our Thirdparty build scripts

@ursabot crossbow package -g wheel

This caused a Boost warning -> build failure
FAILED: src/arrow/flight/CMakeFiles/arrow_flight_testing_static.dir/test-util.cc.obj
C:\Miniconda36-x64\Scripts\clcache.exe  /nologo /TP -DARROW_FLIGHT_EXPORTING -DARROW_STATIC -DARROW_USE_SIMD -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_SNAPPY -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_NO_LIB -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DPROTOBUF_USE_DLLS -DURI_NO_UNICODE -DURI_STATIC_BUILD -D_CRT_SECURE_NO_WARNINGS -Isrc -I..\src -IC:\Miniconda36-x64\envs\arrow\Library\include -Iuriparser_ep-install\include -Igoogletest_ep-prefix\src\googletest_ep\include -I..\thirdparty\hadoop\include /DWIN32 /D_WINDOWS  /GR /EHsc   /EHsc /bigobj /W3 /wd4800 /wd4996 /WX /MP /MD /Od /UNDEBUG /showIncludes /Fosrc\arrow\flight\CMakeFiles\arrow_flight_testing_static.dir\test-util.cc.obj /Fdsrc\arrow\flight\CMakeFiles\arrow_flight_testing_static.dir\arrow_flight_testing_static.pdb /FS -c ..\src\arrow\flight\test-util.cc
C:\Miniconda36-x64\envs\arrow\Library\include\boost/process/detail/windows/wait_group.hpp(55): error C2220: warning treated as error - no 'object' file generated
C:\Miniconda36-x64\envs\arrow\Library\include\boost/process/detail/windows/wait_group.hpp(55): warning C4244: '-=': conversion from '__int64' to 'int', possible loss of data
[514/678] Building CXX object src\arrow\flight\CMakeFiles\arrow_flight_shared.dir\server_auth.cc.obj
[515/678] Building CXX object src\arrow\flight\CMakeFiles\arrow_flight_static.dir\protocol-internal.cc.obj
ninja: build stopped: subcommand failed.
(arrow) C:\projects\arrow\cpp\build>goto scriptexit

My guess is this is legitimate https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/25544786/job/0cxpoyj723a06qb9

Superseded by PR #4702

Thanks @pitrou