Points

IAS 1.3.1 :

Auto Member Inviter completed ( check if debugging is required )
Auth required decorator to send invitation

Great work @sbeeredd04 . Merging in the PR.


Heuristic for error activity

When a tab becomes active, at the moment we show it in blue:

We do this by simply capturing new data to write to the terminal. What we can do: if /error/i matches the data we pass along, we can make that label red instead.
A red tab is orders of magnitude more interesting in terms of prioritization of attention than a blue tab.
There are opportunities for false positives, but I can't think of many.
Do you think this is too obtrusive and error prone for us to ship with, and therefore should be an extension?

To me it makes sense to make the tab text red if the last exit code was non-zero. Digging through the code to see how it could be done.

Seems tricky! Taking a look at the child_pty source code it looks like there might be a way https://github.com/Gottox/child_pty/blob/master/lib/child_pty.js#L86 but it could also be referring the exit code of the command ran with spawn (in this case defaultShell).
Another option might be to change the tab to red of there's activity on stderr, but it looks like the event doesn't get triggered by child_pty https://github.com/Gottox/child_pty/blob/master/lib/child_pty.js#L100


One-way, read-only sync from GCal

First step towards bi-directional syncing is a one-way sync to let your events from GCal show up in your Obsidian Full Calendar view. Will be configurable in settings, where each calendar has a source that is either local (directory in vault) or remote (GCal feed URL).

Great to hear this!

Here's the documentation: https://github.com/davish/obsidian-full-calendar#add-a-google-calendar

Is there a way to get this to work without making calendars public? Making calendars public is a privacy/security nightmare that I'm sure most people don't want to invite. Maybe utilizing the GCal's secret iCal address?


fix: Add solo.io Gloo Edge market place app

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!
If your pull request is to submit a new application to the marketplace, please answer the following questions:

[x] Have you followed the guidelines in our Contributing document in setting up the application?
[x] Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
[x] Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.

Uninstall Traefik and Gloo System Pods and Services

glooctl check and verify install

[x ] Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?

fixes:  #204

@kameshsampath Hello As i went through your PR I found some issues that needs to be resolved, before it can be merged. As i installed the app i got an error

also there is values.yaml is which is not used anywhere, Please Make it clear why is there.

@kameshsampath Hello As i went through your PR I found some issues that needs to be resolved, before it can be merged. As i installed the app i got an error

I see this error itermittenly happening, trying to reproduce

also there is values.yaml is which is not used anywhere, Please Make it clear why is there.
Sorry! that is a stale file, will delete it

@DoNnMyTh - I am not able to reproduce the failure step, I had some flaky network issues when i noticed such thing, but since today morning I am not able to see it. To be on safer side I have added reinstall step to readme

I'll check it and tell you tomorrow

Just final check @kameshsampath now the plans have been removed, where was the 15 value used ? I cannot see it now !

Just final check @kameshsampath now the plans have been removed, where was the 15 value used ? I cannot see it now !

@saiyam1814  it was my misunderstanding on the usage of the plans/config, I now understand it as way to pass values to the installer. Earlier I thought it was used to let civo know what plan to choose when selecting the marketplace app. Since i dont use that value I removed it

ok this PR LGTM


Email send within task activity

The built in GUI is very primitive. You can't paste in multiple recipient addresses and sometimes domain addressed don't autocomplete. Can we do better? Is this exposed in the API?

It doesn't seem like the ClickUp API implements email task comments.


When deploying new version, there is always an overlap

When I'm deploying a new version of the app to Mesos in a Docker container, Bamboo picks up new hosts when they are deployed, and has full pool available to route requests to, before deployment is finished. This leads to the possibility of getting bad data if you're making multiple consecutive requests and getting inconsistent data. I tried adding a health check as well, and the behavior is the same.
Marathon has minimumHealthCapacity flag. I thought it would mean that no traffic is sent to new version until this capacity is reached, and then all traffic starts going to the new version when Marathon starts killing old ones.
From what I can tell, marathon provides "version" in the event hook. Would it be possible to look for those, and make sure that requests are being forwarded to only one version at a time (if I understand correctly the meaning of this flag)?

I'd log an issue with the Marathon project - that was also my understanding of how it worked, but in practice it's slightly different. See this thread:
https://groups.google.com/forum/#!topic/marathon-framework/i_tg5EErtQI

(a bit old but I haven't seen any commits indicating its changed)

I'm not sure that's marathon issue. They notify on every step of the way, and it seems its a subscriber's decision to figure out what to do with those events. The only thing that Marathon is doing incorrectly (IMO) or missing: identification of current production version. They change version of the app right after you post an update, but IMO there should be another indication for which version is "live" now. They should promote new version as prod just before they start killing off old version of the app. But until that's done - I think it would make sense for Bamboo to make this decision.

Your understanding of minimumHealthCapacity is not correct. When Marathon is updating an application, it will never let the number of running tasks go below instances * minimumHealthCapacity, and never above instances * maximumOverCapacity. That means that with, say MHC = 1, and MOC = 1, Marathon will start instances of the new version immediately, whereas with MHC = 0.5 and MOC = 0, it will first kill up to the old tasks, start as many new tasks as possible, and then repeat that until all tasks are new.
Back to the issue at hand; this is something I've been thinking about, and there are a number of possible "correct" behaviours.

Have multiple versions all be treated as the same app - Not actually a problem for many applications
Have the latest version be the exposed version - Most immediate results, most intuative behavior?
 What I would recommend for production.

I would like to implement these behaviours, as they are important going forwards, and do require support from Bamboo itself, and not just the templates.

Isn't the issue raised here basically the question of how to deal with breaking API changes? If that's the case, a classical solution that does not require support from a system like Marathon or Bamboo is to use API versioning and making sure all clients run against one specific version. This can be implemented either by running one Marathon app per major API version that's uniquely addressable (through, say, a separate version path component in the URL or via content negotiation on the resource level if we're talking REST here); or by having that next generation, new-version app continue to be able to serve clients asking for the old version.
Once successfully deployed, all old clients and subsequently the old API can be turned off gradually.


It seems<EMAIL_ADDRESS>and<EMAIL_ADDRESS>uses build constraints "// +build go1.18", e.g. core.go

Building my app now gives...
package github.com/blah/sdk/brokers
        imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus
        imports github.com/Azure/azure-sdk-for-go/sdk/azcore: build constraints exclude all Go files in<EMAIL_ADDRESS>package github.com/blah/secretManagers
        imports github.com/Azure/azure-sdk-for-go/sdk/keyvault/azkeys: build constraints exclude all Go files in<EMAIL_ADDRESS>
If I switch to 1.18 its also breaking other packages in my program, specifically due to "github.com/Azure/azure-sdk-for-go/sdk/azcore/to" which has not maintained backward compatibility
$ go build ./...
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_blob_lease_client.go:25:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_block_blob_client.go:145:20: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_container_lease_client.go:25:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zm_lease_request_options.go:63:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zm_lease_request_options.go:142:16: undefined: to.StringPtr

What did you expect or want to happen?

Clearer instructions on how to avoid the issue
Ideally move to a consolidated/tested bundle release of compatible sdk packages

How can we reproduce it?

(lets see how we go)

Anything we should know about your environment.

WSL

EDIT1:
It is worth saying that having checked again, the latest release notes and azkeys readme states "Go version 1.18 or higher".
The problem with this is that go 1.18 is new and reliability thought processes keep most people <1.18. We should also note that Go Generics are provided with caveats/risk that mean we might want to avoid them in SDKs for a few releases.  In https://go.dev/doc/go1.18 it says:
"These new language changes required a large amount of new code that has not had significant testing in production settings. That will only happen as more people write and use generic code. We believe that this feature is well implemented and high quality. However, unlike most aspects of Go, we can't back up that belief with real world experience. Therefore, while we encourage the use of generics where it makes sense, please use appropriate caution when deploying generic code in production."
EDIT2:
This looks like the last set of versions I'm using that work ok together
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.22.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.13.2
github.com/Azure/azure-sdk-for-go/sdk/keyvault/azkeys v0.3.0
github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets v0.6.0
github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus v0.3.3
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.3.0
github.com/Azure/go-autorest/autorest v0.11.24
github.com/Azure/go-autorest/autorest/azure/auth v0.5.11

github.com/Azure/azure-sdk-for-go/sdk/internal v0.9.1 // indirect
github.com/Azure/azure-sdk-for-go/sdk/keyvault/internal v0.2.1 // indirect
github.com/Azure/azure-sdk-for-go/sdk/messaging/internal v0.0.0-20211208010914-2b10e91d237e // indirect

It is worth saying that having checked again, azkeys states "Go version 1.18 or higher".
The problem with this is that go 1.18 is new and reliability thought processes keep most people <1.18.
We should also note that Go Generics are provided with caveats/risk that mean we might want to avoid them in SDKs for a few releases:
In https://go.dev/doc/go1.18 it says:
"These new language changes required a large amount of new code that has not had significant testing in production settings. That will only happen as more people write and use generic code. We believe that this feature is well implemented and high quality. However, unlike most aspects of Go, we can't back up that belief with real world experience. Therefore, while we encourage the use of generics where it makes sense, please use appropriate caution when deploying generic code in production."

The change is also breaking other packages I'm using in the same program...
$ go build ./...
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_blob_lease_client.go:25:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_block_blob_client.go:145:20: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zc_container_lease_client.go:25:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zm_lease_request_options.go:63:16: undefined: to.StringPtr
...gopath/go/pkg/mod/github.com/!azure/azure-sdk-for-go/sdk/storage/azblob@v0.3.0/zm_lease_request_options.go:142:16: undefined: to.StringPtr

This looks very similar to the issue I'm experiencing: https://github.com/Azure/azure-sdk-for-go/issues/17476 However, in my case I am using Go 1.18

Thanks for opening this issue. I see you've figured out a workaround, and I'm sorry you had to do it. Your EDIT2 is what I would have suggested: downgrade to the latest modules requiring azcore v0.22.0 until you can upgrade to Go 1.18 and we release a compatible azblob. (@mohsha-msft, do you have an ETA?)
Let me give some context to address your other concerns. We use major version 0 for the initial unstable releases of a module; v1.0 and up are stable. For major version 0 releases, we increment the minor version when we break backward compatibility, as in azcore v0.23.0, which adds type parameters to a few APIs and therefore requires Go 1.18. We thoroughly discussed the benefit and risk of using generics and are confident that our limited usage of them doesn't make the SDK less reliable (see this comment for example).

Thanks @chlowell
Dont get me wrong the new SDK is great. Completely understand about beta status and I don't mind recoding things as required, however this feels like an alpha-like failure?  I think there's two things that would be great

a compatibility test suite which builds combinations of all elements of the new SDK to avoid this moving forward
an SDK that doesnt force my software architecture by implementing backwards compatibility. In this case I maintain a generic multicloud Clean Architecture and google functions still only support 1.16....

Hey @adeturner ,
Thanks for reaching out!
If you look at the go.mod file of azblob SDK, you'll find that it still uses azcore 0.22.0 and internal 0.9.1.
Please note that azcore 0.23.0 (Using Go1.18) is a major release and has breaking changes which azblob hasn't picked up yet. So, it's natural that it'll break because you're trying something which azblob hasn't adopted yet.I don't think it's azblob which is at fault here.
The recent release of azcore is breaking azblob and it is concerning. I'm in the middle of picking these changes but will most likely release the support at the start of June (0.5.0). It's not part of the next release (0.4.0). @chlowell
So, as for now I suggest you use the older version of azcore only.

Just as a note, the "avoid using generics in production comment" isn't just about the compiler being 1.18. There are supporting tools and the like that are not ready for generics. For example, going through and upgrading our project because of this issue, we still get the following in golangci-lint (even after upgrading it as well):
level=warning msg="[linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] gosimple is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] noctx is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] rowserrcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] staticcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] stylecheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] unparam is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=warning msg="[linters context] unused is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."

@richardpark-msft
I'm trying to pick up github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus v0.4.0 for a bug fix, and am running into this problem. I also use github.com/Azure/azure-storage-blob-go v0.14.0.  I don't have any direct dependency on azcore or azkeys.
Is there any way to use these two Azure packages together with go 1.17?

package gocloud.dev/pubsub/azuresb
	imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus
	imports github.com/Azure/azure-sdk-for-go/sdk/azcore: build constraints exclude all Go files in<EMAIL_ADDRESS>package gocloud.dev/pubsub/azuresb
	imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus
	imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus/internal
	imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus/internal/sbauth
	imports github.com/Azure/azure-sdk-for-go/sdk/azcore/policy: build constraints exclude all Go files in<EMAIL_ADDRESS>package gocloud.dev/pubsub/azuresb
	imports github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus
	imports github.com/Azure/azure-sdk-for-go/sdk/azcore/to: build constraints exclude all Go files in<EMAIL_ADDRESS>

Hi @vangent , the upgrade to Go 1.18 is SDK-wide, so there isn't an azservicebus package that will work on an earlier version.
In your particular case, azcore is depended on by azservicebus.

@richardpark-msft OK. That is disappointing; forcing your users to update to the single latest version of go is pretty aggressive. I'm not willing to do it for my project (we've committed to supporting the latest 2 versions), which I guess means that I can't update any Azure packages until go.1.19 comes out.

azblob v0.4.0 is now publically available. Please take a look at go.mod file. It required minimum Golang version >= 1.18. It points to azcore 0.23.

Thanks, appreciated. Confirmed it works fine now


GEODE-8878: PR clear should also send a lock message to the secondary members.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

As tough as it is, we really need to avoid that Thread.sleep. That's just another new flaky test waiting to run at the wrong time on a slow machine.

@kirklund I've removed the sleep. The test isn't relying on the race to happen. The tests are making sure each member getting the right combination of messages. Please re-review.


Add check for race in login flow

This was causing an exception on the logout/login flow. I think it was due to a race that's existed since before the routes got split up. One or more of the yields that happens in the registered && !loggedIn flow were taking long enough that a login could have happened in the mean time. Since the routing changes this causes a more severe error than it did before. This adds a check for whether we've logged in before the route call and bails out if so. r? @keybase/react-hackers

@chrisnojima agreed!


Remove Data types from the interface

Closes #162 & closes #158.

I'd love to use a proc macro instead of map_wrapper so we wouldn't have duplicate docs in data members + interface properties but both syn and quote are really heavy to use.

Tile::collision is not implemented yet. Having an object group there is giving a few issues.

Had to end up making both ObjectLayerData and ObjectData public. There isn't really any issue with that and it's probably the type collisions should use (It's raw object data, not belonging to any map). However it's inconsistent with everything else.

There isn't really any issue with that and it's probably the type collisions should use (It's raw object data, not belonging to any map). However it's inconsistent with everything else.

Yeah, the inconsistency isn't very nice, and in fact I've been struggling with the same in Tiled, for example to avoid placing tile objects in these object groups and workarounds for assigning IDs to these objects, which are normally counted per map. But I guess we can live with it.


Can't change bots nickname

I'm trying to update the bots nickname, but when I use the !setnick name command it returns "Unable to change nickname: no permission" . I'm the bot and channel owner, I've set myself as part of the group with the highest permissions and I'm using the latest version of the bot. The bot is hosted on windows server 2016

That means that the bot is unable to change its own nickname. Check it has permission to do so, based on the roles it has.


it's reliability and security ==> its

Apostrophe problems in a couple of places

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6298d0a1-1f6b-6e00-5445-dfec501a4430
Version Independent ID: 42f902a4-b1df-b863-7486-de26c54a205f
Content: Driver security checklist - Windows drivers
Content Source: windows-driver-docs-pr/driversecurity/driver-security-checklist.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

Thanks, @GabeSJones
It's amazing how it's easy to miss its rightful use.
Fixed in source material. Should be live later today.
Eliot

Thanks @EliotSeattle!


fix(authentication-service): change saml redirect api endpoint

change saml redirect api endpoint to use post  method
GH-1607
Description
change saml redirect api endpoint to use post  method
Fixes #1607
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

Add an example in sandbox

Let's track it here: https://github.com/sourcefuse/loopback4-microservice-catalog/issues/1663
I'm merging this fix for now.


set reduction ratio limit to prevent applying conjunction that yields too many pairs

resolved in https://github.com/chansooligans/deduper/pull/43

still should add to settings


Add UseFactory trait on DatabaseNotification model

Database Notification Model now has the ability to have modern Factory classes defined for it.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Fix ABI3 issues identified during 1.3.0b1 release attempt

Summary
We recently tried to publish the 1.3.0b1 release unsucessfully. During the wheel build jobs abi3audit was failing because it correctly identified a couple of abi violations in the builds. The first was we were tagging the package incorrectly as being with a minimum level of Python 3.8 instead of the correct minimum of 3.9. This commit updates the setup.py tag to match the package metadata with the binary.
The second issue is we were creating PyInit_* symbols for submodules which goes against the abi3 naming recomendations and abi3 audit flags it as a violation. We had this issue previously in 1.2.0 but was fixed for that release. However since 1.2.0 and now several stray usages of #[pymodule] on submodules slipped in during development. This commit fixes those so the bad symbol names won't be created anymore.
Once this commit merges we should tag the new commit as 1.3.0b1.
Details and comments
Co-authored-by: Raynel Sanchez<EMAIL_ADDRESS>

I ran pip wheel --no-deps . and abi3audit --strict --report qiskit-1.3.0b1-cp39-abi3-linux_x86_64.whl with this PR applied and it returned:
{"specs": {"qiskit-1.3.0b1-cp39-abi3-linux_x86_64.whl": {"kind": "wheel", "wheel": [{"name": "_accelerate.abi3.so", "result": {"is_abi3": true, "is_abi3_baseline_compatible": true, "baseline": "3.9", "computed": "3.9", "non_abi3_symbols": [], "future_abi3_objects": {}}}]}}}

So I think with this in place we should be good to retry tagging 1.3.0b1.

Ran the same tests locally with MacOS. Results are also good here:
% abi3audit --strict --verbose --report qiskit-1.3.0b1-cp39-abi3-macosx_14_0_arm64.whl
{"specs": {"qiskit-1.3.0b1-cp39-abi3-macosx_14_0_arm64.whl": {"kind": "wheel", "wheel": [{"name": "_accelerate.abi3.so", "result": {"is_abi3": true, "is_abi3_baseline_compatible": true, "baseline": "3.9", "computed": "3.9", "non_abi3_symbols": [], "future_abi3_objects": {}}}]}}}

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
21 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.006%) to 88.848%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
3
92.23%

crates/qasm2/src/parse.rs
18
96.69%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.006%

Covered Lines:
73100

Relevant Lines:
82275

💛  - Coveralls


New action for curl requests

Describe the solution you'd like
A new action option to make curl requests
Additional context
Would give us the ability to call GitLabs API for example to be able to do a wide array of things.

Supported with send-http-request
https://github.com/linear-b/gitstream/pull/306#event-10298403150


Update doh_agent.go

Fixed some broken code in the doh agent.

Compiling works now... But the code running on the agent is bogged down with the ciphertext error. log.go:43: ciphertext too short

Thanks for the pull request fixing the client. At least the code compiling works; much appreciated! We can handle the error in another PR.


Tile grid extent settings causes creating lot of useless requests

In my 'app' http://drifted.in/other/ol/tiles_36_extent.html there is the 'extent' specified on vector tile grid to prevent loading vector tiles outside a valid area. But this settings causes creating thousands of requests. Like all my vector data for all tiles in all zoom levels are required.
While the script in Firefox can be interrupted, Chrome consumes almost all PC memory and must be killed.

Thanks @jan-tosovsky-cz for reporting this issue. ol.source.TileVector currently does not respect extent restrictions from the tile grid indeed. Please try #3801, it should fix your issue.


Support premultiplied alpha on macOS

As the title says. To reproduce: popular browsers such as Chrome and Firefox put images with premultiplied alpha into the clipboard.

Thanks @Tom94! I'll test this next week and merge it 👍

I've just merged this PR adding an extra change to merge the code that came from clip_win.cpp and avoid duplication. Thanks for the PR Tom 👍


Solving Issue #771 - Add processing version for coding challenge 117 - seven segment display

Add Code for Challenge 117: Seven Segment Display #771
Processing version for the seven segment code made on code challenge number 117

ps: this is the pull request number #777
this brings luck

Thank you!


CORS policy issue when trying to import the script from openfpcdn.io/botd/v1 using Firefox

I'm encountering a CORS policy issue in Firefox when trying to import the script from https://openfpcdn.io/botd/v1. The error message in the console is:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://openfpcdn.io/botd/v1. (Reason: CORS request did not succeed). Status code: (null).

Hello @Woorooo  our CDN sets correct ACA* headers. From my experience, browsers just hide different problems behind the Same Origin Policy issues, likely the script (CDN URL) is blocked on the browser side by adblocker (try to check in the incognito mode).
If you believe this is not the case, please provide steps to reproduce and publicly accessible page where we can investigate the mentioned behavior.
Thank you.
Martin

I used Firefox 128.0.3 64bit on Windows, incognito mode, all extensions disabled and I get this error.
Example page: https://www.felicidance.com/
The same also happens on mobile Firefox on Android.
All other browsers I've tested don't have this problem.
Let me know if you need anything else, thank you.

Oh, I see, sadly, Firefox does not like us, and our CDN is blocked in this browser with the default settings. To avoid this, you can use the npm package (I believe it contains all the necessary code and does not request the CDN) or copy the served script from the CDN into your codebase (sadly, you'd need to update manually in the future for newer versions).

I will server the script locally, it should be good for now. Thank you.


Integrate unit tests with arc

Right now all commits pushed to github run through circleci https://travis-ci.org/material-motion/material-motion-runtime-android/builds
You can also manually invoke the tests with ./gradlew :library:connectedAndroidTest
We should configure arc to automatically run unit tests upon export or land.

Moved to https://github.com/material-motion/material-motion-team/issues/143.


AssertionError [ERR_ASSERTION]: new key must bigger then last key

There maybe something incorrect in MemTable

import path from 'path'
import LogReader from '../LogReader'
import { Options } from '../Options'
import WriteBatch from '../WriteBatch'

async function recoverLogFile(): Promise<void> {
  // Open the log file
  const logFilename = path.resolve('./000044.log')
  const options = new Options()
  const reader = new LogReader(options, logFilename)
  let lastEntry = {}
  ite1: for await (const record of reader.iterator()) {
    const batch = new WriteBatch()
    WriteBatch.setContents(batch, record.buffer)
    const sn = WriteBatch.getSequence(batch)

    for (const update of batch.iterator()) {
      const { type, key, value } = update
      console.log(sn.value, type, `${key}`, `${value}`)
      const lastSN = lastEntry[0]
      lastEntry = [sn.value, type, `${key}`, `${value}`]
      if (lastEntry[0] === lastSN) {
        break ite1
      }
    }
  }
}

and found sequence was not increased...

Bug still exist

https://github.com/heineiuo/node-level/blob/master/src/Database.ts#L600-L606
this._versionSet.lastSequence is not update util the log writer async operation. It will cause another operation read and use the old lastSequence


BUG When I reasoning the model Qwen-VL-Chat-Int4 and Yi-VL-6B, the Model Engine cannot be found

First, register the model as shown in the following screenshot.

Second, find the Qwen-VL-Chat-Int4 inference in the list of custom models, as shown in the following screenshot

Qwen-VL-Chat-Int4

xinference, version 0.12.1

Additional explanation
Yi-VL-6B has the same issue.

@okwinds provide us the full screenshot. Did you select vision for VL models in Model Abilities section on the UI?

@okwinds provide us the full screenshot. Did you select vision for VL models in Model Abilities section on the UI?

yep, Registered again

Do not choose Generate in Abilities.

Do not choose Generate in Abilities.不要选择“能力”中的“生成”。

tried again
it cannot work
"model_ability": [
    "vision",
    "chat"
],

This error cannot be reproduced in version 0.13.1, please try upgrading to the latest version. @okwinds

The version of Xinference that I updated.
now, xinference, version 0.13.2.
The same operation process, the same problems still exist.

插眼，我使用0.11.3和0.13.1都存在这个问题

0.13.2版本  问题还是存在的 如果之前部署过其他模型有config缓存，可以正常配置，如果没有缓存的引擎选择不了，下拉框为空

same question!

0.12.0的含金量还在上升，我通过版本降级解决了
pip install xinference==0.12.0

0.12.0的含金量还在上升，我通过版本降级解决了 pip install xinference==0.12.0
Pip install xinference==0.12.0 Is xinference [all] installed by default and how to install xinference [transformers]

主分支应该已经解决，本周发版后请尝试。使用镜像的话可以尝试拉 nightly-main 分支。


LAB13: Instructions updates (Exercise 1, Task 2, Steps 4,5,7,10)

LAB01: Extra-Character
Replace issue name LAB00:QUICK_DESCRIPTION, for example "LAB01: My new issue" (or same name as linked Issue)
Related Issue
Link related Github Issue 🢂 Fixes # . (Include issue number after #)
Checklist
Mark completed with "x" between brackets, "[x]", or checking the box once the PR is created:

[ ] Has related GitHub Issue 💥 Create Issue 📝
[ ] Tested it
[ ] Read the PR collaboration guide 👓 Collaboration Guide 📝

Changes proposed in this pull request:

@LuizMacedo I approve it until the lab13 renewal is published, what do you think?

@LuizMacedo should we merge it, as the lab renewal may take a few weeks to be released?

@unaihuete93 definitely! Thank you @v-asamim!

Great suggestions. Thank you!

you are welcome :)


Update sidebar for java to korean with translation is in progress status

Before translating of java guideline's content, I updated sidebar for java to korean with translation is in progress status.

LGTM - thanks


SAK-43314 Site Info > Manage Participants > Disable/Remove Credits co…

…lumn

I support @jonespm's suggestion on the JIRA ticket to have this column dynamically shown, rather than conditionally based on a property. Seems more intuitive, and less configuration.

I've submitted a PR for an alternative approach: #7959
Discussion in the JIRA ticket.

Alternative approach #7959 looks better than adding a new property.


M1/M2 remap options

Allow remapping M1/M2 buttons to other keycodes.
Keys: remap_custom_to_m1_value & remap_custom_to_m2_value

Just a little differentiation in request, the ability to retain face button functionality at the same time as using it with m1/2 would be great.
Ie A button functionality is both A and M1

Configurable, uses android key codes
Configuration persists after a restart


📝 Docs:(subsection) Vulnerability Corpus

@0xJepsen What is intended by this in particular?

I think we can close this as it's a little early. But i think as some point in the future it would be really great to create an archive of vulnerabilities (corpus) that were uncovered by arbiter.


rewrite cleanup

NB, this pr will also remove the obsolete Algernon class. It had to be done and I think it's a good way to test the upgrade code.
Please do the following to test before you approve.

Check out master.
Use Algernon
Run the upgrade snippet below. (Will be once the pr is ready for review.)
Test that Algernon still works.


Exported mutable variable in namespace with setter function does not mutate value

Describe the bug
If an export from a namespace is mutable, and a function in the namespace mutates the value, the exported value is not mutated.
Input code
namespace A {
    export let a = 5;

    export function setA(value: number) {
        a = value;
    }
}

Config
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false
    },
    "target": "es5",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "commonjs"
  },
  "minify": false,
  "isModule": true
}

Playground link
https://play.swc.rs/?version=1.2.218&code=H4sIAAAAAAAAA8tLzE0tLkhMTlVwVKjmUgCC1IqC%2FKIShZzUEoVEBVsFU2suZOG00rzkksz8PIXi1BJHjbLEnNJUK4W80tyk1CJNqAEgANIJlrQGC9Vy1QIA8jab8GkAAAA%3D&config=H4sIAAAAAAAAA0WNSwrDMAxE76J1tt3kDj2ESZXg4B8aBWqM7165OGQnzedNoxMbrY2KE7CMCzWp%2B9JKWgtjE1%2BUFlKYtLsA7vY4OVgtwniZF3IGT3eh6JPf6yBtORZh4LFcOsKd7AaK%2BXMNof3HDGiVmNMJ6g9olj3eM61ycf8BnwbyVboAAAA%3D
Expected behavior
tsc output correctly mutates the value:
"use strict";
var A;
(function (A) {
    A.a = 5;
    function setA(value) {
        A.a = value;
    }
    A.setA = setA;
})(A || (A = {}));

Actual behavior
Mutates the variable internal to the namespace but not the exported value from the namespace.
"use strict";
var A;
(function(A) {
    var setA = function setA(value) {
        a = value;
    };
    var a = A.a = 5;
    A.setA = setA;
})(A || (A = {}));

Version
1.2.218
Additional context
No response

Afaik this is expected by we try to model similar approach to babel where we compile each module as isolated.
https://babeljs.io/docs/en/babel-plugin-transform-typescript

Q: Why doesn't Babel allow export of a var or let?
A: The TypeScript compiler dynamically changes how these variables are used depending on whether or not the value is mutated. Ultimately, this depends on a type-model and is outside the scope of Babel. A best-effort implementation would transform context-dependent usages of the variable to always use the Namespace.Value version instead of Value, in case it was mutated outside of the current file. Allowing var or let from Babel (as the transform is not-yet-written) is therefore is more likely than not to present itself as a bug when used as-if it was not const

Babel raises compile time exception though, while we do not fail but does not allow those behavior.
I may wrong, so will leave issue opened until getting second eye on this.
babel repl for ref: https://babeljs.io/repl/#?browsers=defaults%2C not ie 11%2C not ie_mob 11&build=&builtIns=false&corejs=3.21&spec=false&loose=false&code_lz=HYQwtgpgzgDiDGEAEBBJBvAUEnSIA8YB7AJwBckAbCCkJAXiQFYBuTbXA48pAMwFdg8MgEsiwJFBooAFADcQlfhABcSYPzAAjCCQCUGDrlx1GCpRDbGAvpmtA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=env%2Creact%2Cstage-2%2Ctypescript&prettier=false&targets=&version=7.18.9&externalPlugins=&assumptions={}

Yeah that makes sense, babel doesn't even try to compile it so 🤷

It's consistent with behavior of tsc with isolatedModules: true


Update http remote documentation

documentation for #4547 and #4517

Editing from the GitHub UI is hard ¯\_(ツ)_/¯
I think this should be a squash merge to remote all the unnecessary commits.

Per
https://github.com/iterative/dvc/pull/4517
and
https://github.com/iterative/dvc/pull/4547

Something is wrong with Restyled @shcheklein ☝ It's not showing up 😕 — let's see if it's a temporary outage.
I'll fix the formatting manually for this one. Let's keep an eye on that.


Support Nightly 2024-12-01

Moved to support the latest nightly, plus some clippy suggestions regarding elided lifetimes

LGTM, thanks a lot! I am going to test it on larger projects.


Correction for raw affiliation French Institute for Demographic Studies (Ined), French Institute for Medical Research and Health (Inserm), French Blood Agency, ELFE Joint Unit, Paris, France; University Center for Research on Public Policy and Politics (CURAPP), University of Picardy, CNRS, Amiens, France

Correction needed for raw affiliation French Institute for Demographic Studies (Ined), French Institute for Medical Research and Health (Inserm), French Blood Agency, ELFE Joint Unit, Paris, France; University Center for Research on Public Policy and Politics (CURAPP), University of Picardy, CNRS, Amiens, France
raw_affiliation_name: French Institute for Demographic Studies (Ined), French Institute for Medical Research and Health (Inserm), French Blood Agency, ELFE Joint Unit, Paris, France; University Center for Research on Public Policy and Politics (CURAPP), University of Picardy, CNRS, Amiens, France
new_rors: 02cnsac56;02vjkv261;02feahw73;00rxdng69
previous_rors: 02cnsac56;02vjkv261;02feahw73
works_examples: W2989923432
contact: acb8a52a33cf4590ab8c1bbca763ebad:2a68e07e8da5481be628513896891d17 @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


[Feature] k8s 1.27 support - apps and feature charts

Team Mapps

[ ] #41781
[x] #41782

Team 3

[ ] #41783
[ ] #41784
[ ] #41785
[ ] #41786
[ ] #41787
[ ] #41788

Team 1

[ ] #41789
[ ] #41790

Team 2

[ ] #41791
[ ] #41792
[ ] #41793

Opni

[ ] #41794

Fleet

[ ] #41795

Highlander

[ ] #41796
[ ] #41797
[ ] #41798

Harvester

[ ] #41799
[ ] #41800

Longhorn

[ ] #41801

Epinio

[ ] #41802

NeuVector

[ ] #41803

Kubewarden

[ ] #41893

@gunamata could you please add Kubewarden to the list? https://github.com/kubewarden/kubewarden-controller/issues/465

@jhmarina , Added Kubewarden to the list.

@jhmarina , As we are now targeting k8s 1.27 and 1.28 upgrade for the rancher Q4 release, I have updated the tickets description for all the charts accordingly. As you created the Kubewarden ticket, Can you please do the same and add k8s 1.27 & 1.28 upgrade for the Q4 release. Thank you.


Use only those state values recognized by GitHub

@jasonm I haven't verified this, but all signs suggest that there is a problem with my patch for gh-99. Little bit of egg on my face, but I'm hoping a quick fix makes up for it!

GitHub recognizes a limited set of state values:

Integrating with our Status API is simple. Each status includes a
state, a SHA, a repository, and an optional URL and description. The
state reflects whether or not a SHA (commit) is successful at that
point in time. The states we currently support are "pending",
"success", "failure", and "error". If the status provides a URL or
description, we display it in our UI.

source: GitHub Blog, "Commit Status API" [1]

All failing statuses should specify their state value as "failure"
regardless of the status description.
[1] https://github.com/blog/1227-commit-status-api

Odd, could've sworn I verified this working.  But you're right, there are:
Github::Error::UnprocessableEntity (POST https://api.github.com/repos/jasonm/clahub-test2/statuses/690592346f3e9d61951a672abe7cc5796a26a19d?access_token=14316c81ea96c430976afd2571c5f9056b79c5e7: 422 state is not included in the list):

in the logs.  Thanks for the patch, sending out shortly.

Verified against https://github.com/jasonm/clahub-test2/pull/3

Sorry about that! Glad it's fixed


Work around the UBI8 microdnf bug

This applies the published workaround for
https://github.com/rpm-software-management/microdnf/issues/50 allowing
us to track :latest again.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

This change is


clear all env vars except PATH when running cargo

This is necessary to avoid confusing rustc when running cargo-tarpaulin on Mac and Windows using --engine llvm.

This appears to cause DNS resolution failures on Windows, so I'm closing it.  We can revisit later if cargo-tarpaulin is a priority, but right now it's more trouble than it's worth.

M


Change Info-window size without lag

I want to use info-window on google map. the content of my info window has an images. when I use "maxWidth" in info-window, It insert some margin and padding as following screenshot. I tried this css code:
 .gm-style .gm-style-iw{      font-weight: 300;      font-size: 13px;      overflow: hidden;      width: 210px  !important;      top: auto !important;      position: absolute;      left: auto !important;      bottom: auto !important;    }
but after using the above code, my info-window gets some lags. Please tell me How can I use info-window without any padding or [margin.](url

)

You will probably have more control over styling without needing hacks if you use InfoBox. https://tomchentw.github.io/react-google-maps/#infobox

I understand this is frustrated, but this is not a support form on how to use Google Maps API. react-google-maps is simply a wrapper around it. Unless there's a specific issue on the react-google-maps itself, please post your questions on StackOverflow instead of creating an issue here.
The maintainers only have limited time on open source projects. Please help us keep the health ecosystem. Thanks!


Mention required ruby version change in 0.8.0 changelog

We're still running on a bit outdated Ruby version, so the required ruby version change in https://github.com/shioyama/mobility/pull/242 was an unfortunate surprise to us given that it was not mentioned in the changelog.
So here's an update to the changelog so others won't get bitten by the same change :smile:
Looks like we should upgrade Ruby quite soon 😅

Damn GitHub having some trouble, causing me to create a wrong PR target 😅 https://status.github.com/messages


Format json with JQ_COLORS

This PR adds support for colors via JQ_COLORS and enabling/disabling with NO_COLORS, --color-output/-C, and --monochrome-output/-M. The formatting matches jq (not gojq).
I've tested this and it has identical behavior to jq. If we want to add tests, it would need a new harness, because --run-tests uses value-based equality, not formatted textual equality.
I also removed the tojson/1 intrinsic, because neither jq nor gojq define it.
If https://github.com/jqlang/jq/pull/3034 is merged, I'll update _tojson here to match.

Commit 231277f moves _tojson without changing it, after the previous commits modify it. If you're reviewing with a diff viewer that doesn't detect text moves (like GitHub), then you can review it easier in three chunks: before (master...808b031), move (231277fd0976189d81e03dbc6e51949a039183d1), and after (c1e4148)

Commit 231277f moves _tojson without changing it, after the previous commits modify it. If you're reviewing with a diff viewer that doesn't detect text moves (like GitHub), then you can review it easier in three chunks: before (master...808b031), move (231277f), and after (231277f...d7cea3c)

👍

Thanks for the review! I'll go through your comments in the morning.
Shortly after your review, I implemented the raw output options, which I've now pushed. They touch the _tojson filter after eval, so are fairly related to this PR. I'd prefer to have it reviewed here, but I could split it from this PR and rebase it onto master once this lands, if you'd like.
This reduces the missing features needed for wsjq even more!

Thanks for the review! I'll go through your comments in the morning.

No stress!

Shortly after your review, I implemented the raw output options, which I've now pushed. They touch the _tojson filter after eval, so are fairly related to this PR. I'd prefer to have it reviewed here, but I could split it from this PR and rebase it onto master once this lands, if you'd like.

Either way works for me so let's keep it here

This reduces the missing features needed for wsjq even more!

🥳

Since https://github.com/jqlang/jq/pull/3034 looks like it'll be merged, I've pushed a commit to match it.

BTW talking about ANSI output, maybe https://github.com/wader/ansisvg is interesting? think my main use of it has been producing colorful output from jq and fq for presentations :)

So ready to merge?

Yep!

Great work! and so happy someone else wants to help out with this weird thing :)

Hmm noticed --help looks weird, maybe the last minute fix for test output messed up? wonder if there is a neat we to have   output tests

Your ansisvg project looks useful. I've used asciinema for that kind of thing before, but this would be usable outside the browser when it's not animated.
It reminds me of a tiny project I did, terminal-palette. It computes the nearest color in a palette for RGB colors, by using the perceptual distance between colors in the CIELAB color space (logic borrowed from james-oldfield/nearest-colour). I used it to make fallback color schemes for my Tetris game, programmed in Whitespace. It uses the official piece colors when the terminal supports 24-bit color, or uses similar colors from the 256 colors if that's supported, or otherwise uses the basic 16 colors.

Neat! think i will have to have a closer look at the whitespace language

Getter a bit late here, feel tree to merge a fix for help if you look into it. Otherwise will fix or review tomorrow

Good catch for --help. I had picked --join-output as the unconditional output format (except for tests), because it gives the most flexibility to jqjq. jqjq can insert LF or NUL as appropriate, according to its own --raw-output/--raw-output0/--join-output options. That means, though, that it needs to be more conscious of how everything is formatted.
In this case, the fix is to add \n to each line of help. I'd go further to even concatenate it into one string. I have a fix. Can I just push it to master?

Nice, yeap push is fine too!


Flex-bar buttons does not work...

I installed everything and the flexbar works, but I can't use the buttons u described... when go over PACKAGES - ARDUNIO UPLOAD - VERIFY everything works as expected.
The just do nothing... other buttons like new-file working good. Any idea?
  {
    type: "button"
    icon: "file-add"
    tooltip: "New File"
    callback: "application:new-file"
  }

  {
    type: "button"
    icon: "check"
    callback: ["core:save", "arduino-upload:verify"]
    tooltip: "Arduino: Verify",
    enable: { grammar: "arduino" }
  }
  {
    type: "button"
    icon: "arrow-right"
    callback: ["core:save", "arduino-upload:upload"]
    tooltip: "Arduino: Upload",
    enable: { grammar: "arduino" }
  }
  {
    type: "button"
    icon: "terminal"
    callback: "arduino-upload:serial-monitor"
    tooltip: "Arduino: Serial monitor",
    enable: { grammar: "arduino" }
  }
  {
    type: "spacer"
  }
  {
    type: "button"
    icon: "gear"
    callback: "flex-tool-bar:edit-config-file"
    tooltip: "Edit Tool Bar"
  }

You forgot to separate each section and subsection with commas.
If you're using JS config, it should look like this:
{
    type: "button",
    icon: "check",
    callback: ["core:save", "arduino-upload:verify"],
    tooltip: "Arduino: Verify",
    enable: { grammar: "arduino" }
  },
  {
    type: "button",
    icon: "arrow-right",
    callback: ["core:save", "arduino-upload:upload"],
    tooltip: "Arduino: Upload",
    enable: { grammar: "arduino" }
  },
  {
    type: "button",
    icon: "terminal",
    callback: "arduino-upload:serial-monitor",
    tooltip: "Arduino: Serial monitor",
    enable: { grammar: "arduino" }
  },
  {
    type: "spacer"
  },
  {
    type: "button",
    icon: "gear",
    callback: "flex-tool-bar:edit-config-file",
    tooltip: "Edit Tool Bar"
  }

Also, you don't need to use core save, I kind of made an option that can do this automatically on build/verification.

In that case someone needs to fix the documentation at https://github.com/Sorunome/arduino-upload/blob/v1.4.1/docs/toolbar.md
I was already wondering why there were no commas in the cson.


How to disable curl verbose mode?

Is there a simple way to disable curl verbose mode?
Like: \tpayLibs\src\_class_tpay\Utilities\Util::$loggingEnabled = false;
For example: \tpayLibs\src\_class_tpay\Curl\CurlOptions::$verbose = false;

If I can update the curl timeout in the same way for BasicReports... because it is slow when with many transactions, even for 1 day.

The verbose can be edited the same way like described in https://github.com/tpay-com/tpay-php/issues/33#issuecomment-1004824265
Just use additionally $this->curl->disableVerbose();
The timeout is the same $this->curl->setTimeout(60);


Updated admin tenant settings to match what is currently shown in the UI.

@KayUnkroth : Thanks for your contribution! The author, @mgblythe, has been notified to review your proposed change.

#sign-off


fix getting approvalable_type

Hi, this is a fix to get the correct approvalable_type.
Using the first() method is not correct because it will be running an SQL query to get the first record of the approvals table

Hi @cjmellor, don't forget to release a new version when you merge it 😅
Many thanks!

Thanks


Is it possible to let httprouter listen at multiple ports in one process?  Thanks!

I tried to do so but seems like the second port will refuse connection.
I also tried to let httprouter listen to one port, and use a new http.ServeMux to listen to the second port (please see the sample code here https://gist.github.com/anokun7/e6dd3c40bdc0469bc7b1834c42c116d8), but it doesn't work either.

Sorry, I think this is something wrong on my end - the problem can be solved by following the method listed here: https://stackoverflow.com/a/43861193


narrowing is broken in nightly build

declare var value: string
if (value !== 'a') {
} else if (value === 'b') { // <-- [ts] Operator '===' cannot be applied to types '"a"' and '"b"'.
} else if (value === 'c') {
}

In the false branch of value !== 'a' we know that the type of value is 'a', so comparing it to 'b' or 'c' makes little sense and the compiler is pointing that out.

duh, sorry


select clip height independently

Better than a boolean to simply select half height 😉

@cal2195 -- no need for review -- just wanted to let you know I decided to implement this as per your comment about the clipHalfRez setting I put in in another PR: https://github.com/whyboris/Video-Hub-App/pull/253#issuecomment-521974198


[APIView] Small Java processor improvements

Making the Java diagnostics slightly improved.

@mssfang Please review and then merge / release. Thanks.


fix(api-reference): check if default value is undefined instead of falsy

Fixes #3314
Before

After

This is great! I’ve added a few tests. ✨


Use the python2 from the environment (more flexible)

Do not use the hardcoded full path.
In some machines you might not want to use that python version.

OSX Travis build is down because http://releases.llvm.org/3.8.0/ is not available now.


org rename

Ref: https://github.com/stolostron/backlog/issues/18746
Signed-off-by: haoqing0110<EMAIL_ADDRESS>

/test pr-image-mirror

/assign @elgnay @xuezhaojun

/lgtm


Hot reload?

Do you support hot reload?
It seems when I add a new story it only loads it after hot restart.

Yeah, I think it has something to do with the hacks around routing I was making to support direct links to the stories in web. I'll take a look if there's some way to fix it.


API and Binance.com showing different prices for when the stock was bought and sold

So I was running a bot and the bot bought shares at $55.72, and sold at $55.74. This mathematically should be a profit but upon looking at my order history, it shows a buy at $55.79 and a sell at 55.72, and I came out at a loss

TO REPRODUCE:
Have an API buy and sell shares, and then look at order history on binance.com

Upon further testing, the price has still never once been the same price in order history as it is in my bot. Many times its actually vastly different. way more different than the stock should be changing in 1-2 seconds

Ok one more update. The bot is actually never caught up with the current price. Never once. I cant tell if its behind or ahead of the display on binance.com as well as robinhood.com

It's slippage. Putting in market orders with no safeguards can lead to slippage especially if you're trading on a quick time frame


add positive and negative predictive value calculation to classification scoring

auto_ml seems to normally handle it quite well, but sometimes if the data is imbalanced then many algorithms (especially trees) will cheat and just predict all the values to the majority class. The confusion matrix can sometimes help you catch this but you have to do a bit of math.
This PR does that for you and tells you how good the predictions were per target. I normally just call that the "per class accuracy" but Wikipedia seems to say that is "positive predictive value" and "negative predictive value"

I love PRs! Thanks for this. I'll give the ci tests a chance to run, then happily merge it in!
I think that documenting the output/getting analytics from models is super important, and an area we can keep expanding on. If you've got any other ideas, I'd love to hear them.
In particular, what do you think about scikit-plot?

Great!
scikit-plot looks really cool. I think I actually took a look at it when you mentioned it in another PR, but I couldn't figure out where in auto_ml the scikit classifier was to pass to classifier_factory() 😞

Haha, glad I'm consistent in my excitement about scikit-plot.
I'm actually making a few tweaks to how we pass around trained estimators to the various analytics functions post-training. I'll let you know once I've got that finalized (probably early next week).
In the meantime, thanks for this PR, and expanding our analytics capabilities!

Cool! After you're done reorganizing and the classifier is accessible, I would definitely be interested in trying to get scikit-plot working.


Updation in css file

Pull Request Template
Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

which issue it fixes?


v2.0 alpha release

targeting june 15, about two weeks before v2.0, as a deadline for new features. watch the v2.0 milestone for these items.
bug fixes can be done after this point, but new features should wait for v2.1 cycle after june 30.

pending #639 and #640 and we'll be done with new features

this date came and went. we're done with new feature and are limited to bugfixes and tweaks.


Replace pg_search with activerecord query

Why:
We're only using the pg_search gem for the keyword search, and the query that it generates is not that complicated. Upgrading to the latest version of the pg_search gem breaks our tests. So, instead of having to rely on a third party, we can generate the same query ourselves using activerecord, and reduce our dependencies with the same stone.
How:
To figure out what the proper query was, I fired up the Rails console and ran Location.keyword('food'). That gave me the SQL query I needed, which I then converted to activerecord so that the result would return an ActiveRecord::Relation that can be chained with other scopes.

@md5 Check out the latest changes. I made the query even simpler thanks to help from my 18F colleagues, and sanitized the query in the order clause, and used a parameterized query in the where clause (which Postgres will automatically escape).

LGTM


No environment is loaded when APP_ENV is empty

This issue was first posted here https://github.com/symfony/symfony/issues/25711. To summarize,  under certain conditions, I ended up with a weird set of $_SERVER parameters (see this comment) and an empty string in $_SERVER['APP_ENV'], causing the debug bundle and profiler toolbar to unexpectedly not work.
I know it is a problem on my side that the APP_ENV changes it's value, but because it's an empty string, the following line of public/index.php of the default skeleton doesn't enable the development environment:
$env = $_SERVER['APP_ENV'] ?? 'dev';

as ?? is not triggered when the initial value is an empty string.
I'm posting it here in case there's agreement that an empty environment string != a valid environment.

Is this issue still relevant?
Or if you can close it, thank you

I think this can be closed as it looks like something specific to the setup. As nobody else reported the same issue, the issue seems local.


float resolves to datetime on load

toml.loads('z = 3853110.0341112586')
{'z': datetime.datetime(3853, 10, 3, 11, 25, 6)}

https://github.com/uiri/toml/blob/a444a3659ea06d62fa3aeac9595946ebcbec13ae/toml/decoder.py#L498
Should probably check if works as other types first, or if the separators between YYYY MM DD etc. are also numbers. If they are numbers, probably not a datetime.

Hi Lawrence,
Thank you for reporting this.
Which TOML version are you running?
Have you checked out the linked commit and run python setup.py install ?
This looks like a duplicate of #149 which was fixed in eb2d6687


#Need A Update For Script - Not Showing Keys Now

There will be no update in the future. The widvine.dll and the RSA have changed. Therefore, your only option is to downgrade the browser or widvine.dll.


Introduce a configuration structure convention for plugins to avoid collisions

Isn't it already the case

This is about avoiding plugin configuration collisions when the configuration is merged during bootstrapping. I think it would be safer for plugins to use a configuration root like:
delta.plugins.storage {
  # configuration goes here
}

This could be done as it is currently by just removing (or throwing) when there is any root key in the plugin configuration other than info.name

Not really, because plugins may wish to configure global settings.

Yeah, could be. In any case, that can be handled when merging the configurations

The two locations that need to be changed are: PluginDef and the custom config decoder that loads each plugin configuration from the merged config (e.g. StoragePluginConfig)


Intake

What this PR does
What does it fix/add?
Reference issues with "Fixes #10" or "Closes #10", where #10 is the number assigned to the issue
What does this depend on?
References pull requests or branches/forks that this pull request depends on

This needs to be rebased
I doubt you actually have 4300 lines of changes so cherry pick what you need over to a new branch and just pr that it'll make your life way easier


Implementation of bin/derper

cc @ramfox

basics are there, good enough to merge into the branch, so we can hook things up once they are there


azure AD is erroring out while invoking FETCH api while using visual studio code

I have already posted this question stackoverflow, but not getting any response: https://stackoverflow.com/questions/47469156/azure-ad-is-erroring-out-while-invoking-fetch-api-while-using-visual-studio-code
Working on VisualStudioCode - 1.17.2
Not working on VisualStudiocode - 1.18.0
The Azure AD authentication for FETCH API is not working in react native after I switched updated VisualStudioCode. I was forced to use Headers in a different way as shown below:
fetch("SOMEURL", {
method: 'GET',
headers: [['Accept','application/json'],
                ['Content-Type', 'application/json'],
                ['Authorization', "Bearer " + token]]
})

The above call doesnt go past the SignIn page. However, if I change it to the old way, it worked. For this to happen I had to pick a Visual Studio code version which was not the updated.
headers: {
                    "Accept": "application/json",
                    "Content-Type": "application/json",
                    "Authorization": "Bearer " + token
                }

The FETCH call with above headers succeeds in older version of Visual studio code. I am using package react-native-azure-ad (0.2.4)
Is this a known issue ?

What do you mean with in? Do you use an extension which live previews your react application?
In general your first code snippet is not correct. The second example should work (i also use the fetch API with such a syntax.)

Yes. I use react-native-azure-ad to authenticate my mobile app using AzureAD authentication


Add the expected media type to the request headers

parseContent() expects only json or yaml.
Help API's providing multiple media types to choose the expected format.

I had this before and removed it.  Why do we need to set this explicitly?  I think the default is to allow everything.  Also, disregard the TravisCI failure...gotta love TravisCI.

I'm using an API that supports content negotiation.
It returns the first-best media type if the accept header is absent.

If no Accept header field is present, then it is assumed that the client accepts all media types.
HTTP 1.1 spec

getDocument() passes the response body to parseContent() which can only handle json or yaml.
Therefore the accept header should be defined as expected.
The travis build failure has nothing to do with this commit:
106 The command "eval npm install " failed. Retrying, 2 of 3.
107
108 npm WARN unmet dependency /home/travis/build/apigee-127/swagger-tools/node_modules/gulp/node_modules/liftoff/node_modules/rechoir requires<EMAIL_ADDRESS>but will load
109 npm WARN unmet dependency undefined,
110 npm WARN unmet dependency which is version undefined

Which is why I said: Also, disregard the TravisCI failure...gotta love TravisCI..  ;)  TravisCI is painfully good at false positives.  I'll merge the PR shortly.

I committed a slightly different version but it should do the same.  It seems application/x-yaml is preferred to text/x-yaml so I used that instead.


Consider producing distinct objects for the same entity to enable garbage collection

ServiceWorker APIs vend various objects... ServiceWorker, ServiceWorkerRegistration, Cache. It is possible to retrieve the same thing multiple times.
This creates an issue for implementations, which must be conservative when reclaiming these objects, because they may be re-retrieved later. Whether it is safe to reclaim an object is not decidable in general because of the halting problem, it's an interactive system, etc.
For example:
self.caches.create('seldom-used').then(function(cache) {
    cache.kiss = 'death';
  });

The implementation cannot reclaim 'cache' as long as the page is open, because it can't decide if the page will come along later and do self.caches.get('seldom-used') expecting to find the kiss of death on the object.
(I'm not talking about the cache entity here, but the page's JavaScript wrapper, the thing that the 'cache' variable is referring to.)
The same issue happens with registrations (because of getRegistration) and ServiceWorkers (through getRegistration and the active, etc. properties.) Other APIs avoid this problem by returning a distinct object instead of modelling the entity directly. For example, IndexedDB returns new connection objects to the same database entity.

Are distinct objects for the same entity expected to be in sync? E.g., must two ServiceWorker objects representing the same entity always have equal .state? In Chrome, distinct objects get individually updated, so this happens:
register().then(function(r) {
  r.installing.addEventListener('statechange', function(e) {
    e.source.state == 'installed';
    r.waiting.state == 'installing';
 });
});

If it's required, I think the most straightforward implementation for Chrome would be to try to reuse the JS objects after all (although not requiring JS equality is still nice for gc). More details on #622

Agreed, being able to === is more useful than I first thought too, especially when comparing say a message event's source to the SW controlling the document.

I agree as well, which is why I'm having a hard time with treating the equivalent scenario in service workers totally opposite.

To avoid the unsynced states problem, Blink now has object equality between JS objects representing the same Service Worker entity: crbug.com/459457. I believe this is spec conforming because the current spec neither requires nor disallows object equality, but it does require synced state. Accordingly, our tests only assert that state is equal between the objects.

We should put that in the specification though. Not defining an object's lifecycle in detail is a bug.

I added [NewObject] / [SameObject] extended IDL attribute to attributes and methods: https://github.com/slightlyoff/ServiceWorker/commit/655ededa26925c898721a741d81a1b483a1d8a07. I think Gecko implementation still returns distinct objects in many places according to the earlier discussion in this thread whereas Blink implementation came with the object equality. Please review the above update. /cc @ehsan @wanderview @mattto

I'm not entirely clear about the promise resolution values of the cache methods:
CacheStorage.match().then(response => {});
CacheStorage.open().then(cache => {});
Cache.match().then(response => {});
Cache.matchAll().then(responses => {});
Cache.keys().then(requests => {});

IMO, the resolved values of the promise returned from the above methods should be the same object as well. WDYT? /cc @wanderview
To make it clear, resolved/returned ServiceWorkerRegistration objects / ServiceWorker objects are the same objects, and resolved/returned Client / WindowClient objects are distinct objects in the current spec.

No, they should be fresh promise objects. And also mostly fresh Request/Response objects. Not sure about Cache objects.

All the promise objects except the one returned from .ready are fresh promise objects. I'm talking about the objects that are resolved from those promises.

Regarding the Request/Response objects, most of them are related with the cache API.
How about FetchEvent.request and FetchEvent.client? Within the same event object, shouldn't they refer to the same object?

FetchEvent members should be [SameObject], yes.

IMO, the resolved values of the promise returned from the above methods should be the same object as well. WDYT? /cc @wanderview

All Request, Response, and Cache objects returned from Cache and CacheStorage should be new objects.  This can't be represented in webidl as far as I know, though.
Reasoning:

Request and Response objects are drainable.  They must be different objects
Returning same object for Cache adds complexity and possibly forces de-opt because now we have to deal with js code sticking stuff on the object, etc.  Its much simpler to return new objects (as is currently) spec'd and let the GC do its work.  Please don't change this.  It will just add complications for no benefit.

I am ok with the self.caches CacheStorage object being [SameObject].  That one makes sense because its an attribute.

Understood. Fair enough.

Oh I didn't catch the following implementation issues:
https://code.google.com/p/chromium/issues/detail?id=523904
https://bugzilla.mozilla.org/show_bug.cgi?id=1181039
So I think the following behavior seems right (the same object and the distinct object is for the promise resolution value):
navigator.serviceWorker.register().then(registration => {}); // same object
navigator.serviceWorker.getRegistration().then(registration => {}); // same object
navigator.serviceWorker.getRegistrations().then(registrations => {}); // same object
clients.matchAll().then(clients => {}); // same object
clients.openWindow().then(windowClient => {}); // distinct object
WindowClient.focus().then(windowClient => {}); // distinct object
(Extendable/ServiceWorker)MessageEvent.source; // same object
(Extendable/ServiceWorker)MessageEvent.ports; // same object

CacheStorage.match().then(response => {}); // distinct object
CacheStorage.open().then(cache => {}); // distinct object
Cache.match().then(response => {}); // distinct object
Cache.matchAll().then(responses => {}); // distinct object
Cache.keys().then(requests => {}); // distinct object

In the spec, when a distinct object is required, I used "new" explicitly. For the same objects, I did it with "an object that represents the target object." It seems better wording is necessary here to make it clearer? (any suggestion?)
/cc @nhiroki @mattto @wanderview @nikhilm @slightlyoff @jakearchibald @annevk

Thanks for pinging this bug. Yes, better wording is needed; "an object" is ambiguous about whether it's the same or distinct. Saying "the object" instead may be sufficient.
As for the actual behavior, moving from same to distinct for the registration object made Blink/Chromium code a bit simpler, but I'm ok with requiring it to be same. It's actually probably needed to keep multiple registration objects in sync when listening for onupdatefound events (like statechange events for ServiceWorker: https://github.com/slightlyoff/ServiceWorker/issues/416#issuecomment-74889353)

Changed it to "the object that represents the target object" expression for the same object case: 6643b11cdd52bf6732fe71e35ee1761569c50b82. Sorry for the confusion.

Gecko bug to return same registration object: https://bugzilla.mozilla.org/show_bug.cgi?id=1201127

clients.matchAll().then(clients => {}); // ~~same object~~ distinct object ?

Not sure what this means, but I think these should be distinct objects as they're snapshots. Agree with all the other distinct/same decisions.

Just tried to put a strikeout on the "same object" and clarified it to the "distinct object".

clients.matchAll().then(clients => {}); // same object distinct object ?

The current spec resolves with distinct objects.
Thanks for the review! Closing.


Feature request: Awake based on connected device(s) - a clamshell mode

Description of the new feature / enhancement
Powertoys currently has a simple utility which allows the user to quickly change power settings without going through the typical process and I was thinking that it would be nice to develop this a bit more. Instead of solely relying on the user to change the settings via the UI it would be nice to detect power and monitors to automatically change the behaviour of the power functions. IE if external monitors and/or power was connected the user could set it up so that they can close a laptop lid without putting the laptop to sleep but only turning off the screen.
Scenario when this would be used?
Allows users to quickly more between 'portable' environments and work areas more seamlessly without having to fiddle with any scripts
Supporting information
No response

I'd like this too, but in my case it's for connected smartphones.

Consolidating in #16422.


Can't log in to the program

Storage Explorer Version: 1.13.1
Build Number: 20200515.1
Platform/OS:  Windows 10
Architecture: x64
Bug Description
When trying to sign

in with my account, I keep redirecting endless times and asking for the password again.
Steps to Reproduce

Add  a account
Insert email and password

Expected Experience
When entering email and password, I should load the services linked to my account.
Actual Experience
erro after cancel login
{
"message": ""User canceled authentication""
}


Custom password for newly created Oracle schemas

The feature of auto create oracle database schema is cool , but it has some problem

we can not config database password
the database create with default password 'FFllyywwaayy00!!' , but can not connect by client!

public class OracleSchema extends Schema<OracleDatabase> {

@Override
    protected void doCreate() throws SQLException {
        jdbcTemplate.execute("CREATE USER " + database.quote(name) + " IDENTIFIED BY "
                + database.quote("FFllyywwaayy00!!"));
        jdbcTemplate.execute("GRANT RESOURCE TO " + database.quote(name));
        // should add grant
        jdbcTemplate.execute("GRANT connect TO " + database.quote(name));
        jdbcTemplate.execute("GRANT UNLIMITED TABLESPACE TO " + database.quote(name));
    }
}

should add  jdbcTemplate.execute("GRANT connect TO " + database.quote(name));

The default password we use conforms to the default Oracle password guidelines in newer versions of the database. See #1943
Why exactly is this password a problem for you?

the new schema create by flyway can't coonect by client.

we want to set the password if possible

Grants can currently be performed in migration scripts. You can add grant connect, unlimited tablespace to user to the beginning of your first migration to ensure you have everything you need for the rest of your migrations. Not everyone is going to want unlimited tablespace for each of those users, so those grants would either need to be configurable, or a recommendation should be included in the documentation to include grants in your migrations.
You can also issue an alter user schema_user identified by Pa$$word in a migration to set the password as you like, however, I would consider this one worth adding as a configurable parameter in flyway itself for the case that FFllyywwaayy00!! doesn't conform to a custom password policy which would cause the schema creation to fail.

Related to https://github.com/flyway/flyway/issues/2990


Adding basic FeedRanges API

This is an initial version of the port of FeedRanges from .Net SDK to Java SDK.
FeedRanges are basically just an abstract identifier for subsets of a Container (possible variations today are PKRange, logical partition or EPK)
This PR is adding the public surface area to retrieve the FeedRanges for a container - in the future we will add options for a customer to try to merge or split feed Ranges (for example the feed range of a PkRange can be split into multiple EPK feed ranges) - this mechanism will also be used for split and merge proofing of ReadFeed, Query and Changefeed in .Net SDK.
The plan is to start using this in the new Changefeed Pull Model to be merge-proof. Brandon is still actively iterating on his Pagination library that achieves split/merge safety across all feed operations including query.  I will slowly see which parts we can port (when they stabilize in .Net - and depending how much query pipeline is out-of-sync etc.)
This PR has the basic building blocks to represent FeedRanges - not yet the pagination aspects to iterate over feeds by filtering by feedRanges etc. That will be part of the next PR when using it for Change Feed Pull model.
This PR also has the public surface area - The additional steps above are not expected to change the public surface area anymore (except for adding user-support for merging/splitting feed ranges to decouple compute scale form number of physical partitions - but that public surface area hasn't even been finalized for .Net yet - so is at least several weeks out).

/check-enforcer override

Overriding check enforcer because all tests were executed before - just updated the logging parameter - which is safe.


Javascript fetch success validation on mobile

Is there an easy way to validate that the Reponse from a HTTP fetch contains a valid object (HTML page, image, etc) and not a server error message?
Normally you can check response.ok, response.status or response.statusText, but they are not defined on mobile (Chrome and Firefox). I wonder why the design decision was to not let developers have access to the first line of the HTTP response (HTTP/1.1 200 OK). That would have been very convenient. So am I supposed to read the payload with response.arrayBuffer() and parse it byte by byte to see if it matches a JPG header, etc?
It seems like such an obvious API design mistake that I hope I have just misunderstood something.
Response API support:
https://developer.mozilla.org/en-US/docs/Web/API/Response

Looks like this is just error in the documentation.
https://github.com/mdn/browser-compat-data/issues/9309


[QUESTION]does anybody knows how to compile docker in suse with kernel 3.0.93-0.8-default

as the title said, i want to compile docker in suse with very low kernel version, and have many prolems, if there is someone who has succeeded done this before, thanks.

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Kernel 3.0.x is too old for docker, as it doesn't have all the requirements to run it. The current absolute minimum version is kernel 3.10


Fix relative script paths

Change the script locations to use relative paths because the public gh-pages URL is to a subdirectory.

LGTM


Wiki entry "Hack Playlist triggered by GPIO Button" not up to date with new GPIO-Server?

Bug
Wiki entry "Hack Playlist triggered by GPIO Button" not up to date with new GPIO-Server?
What I did
I tried to follow the Instructions in the wiki to assign playlists to hardware buttons. I did not find the mentioned file gpio-buttons.py but only the gpio-settings.ini. Doing the changes described in the wiki there did not have any effect.
I could not find any hint on assigning playlists to GPIO-Buttons in the documentation for the new system either.
Volume rotary encoder, next prev play pause buttons all work fine!
Thank you for this great project!
What happened
Buttons not working
I expected this to happen
start the assigned playlist
Further information that might help
I am on an very fresh installation (Dec 15. 2020) by provided script
Software
I am on an very fresh installation (Dec 15. 2020) by provided script on Raspberry Pi OS Lite 5.4
Base image and version
Branch / Release

Installscript

Hardware
RaspberryPi version

RFID Reader

Soundcard

Other notable hardware

You would need to add additional function calls to components/gpio_control/function_calls.py and set these function calls in gpio_settings.ini to a Button.
but be aware this hack assigns a playlist hardcoded to a button.

Thank you for the quick reply! I am afraid that I need a little more detail: I can open the files and as far as I understood, this for example is a function call:

def functionHurra(*args):
    function_call("{command} -c=shutdown".format(command=playout_control), shell=True)

Now I have no idea how this must look like to trigger a (spotify) playlist
By the way: I would like to execute a shell script with one button - Is the way similar?
This is an example from gpio_settings.ini where I guess I have to do something with he function

[Hurra]
enabled: True
Type: Button
Pin: 27 #myPin here
pull_up: True
hold_time: 0.3
functionCall: functionCallPlayerPause

Best wishes!


LibRaw wavelet denoise options

raw:threshold
- float
- Libraw parameter for noise reduction through wavelet denoising..
The best threshold should be somewhere between 100 and 1000.

raw:fbdd_noiserd - int - Controls FBDD noise reduction before demosaic. 0 - do not use FBDD noise reduction, 1 - light FBDD reduction, 2 (and more) - full FBDD reduction

Description

Tests

Checklist:

[ ] I have read the contribution guidelines.
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[ ] If I added or modified a C++ API call, I have also amended the
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
[ ] My code follows the prevailing code style of this project. If I haven't
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.

@lgritz nothing special just two options:
raw:threshold and raw:fbdd_noiserd
If the first one clearly visible results. Recommended to use values from 100.00 to 1000.00
but fbdd_noiserd I did not get how it works in libraw so just added it as it is also about denoising (1 or 2 should enable different modes of this pre-demosaic denoiser).
My main concern, that compared to direct libraw demosaic that not affect processing time a lot. OpenImageIO has 2-3 times slowdown on wavelet demosaic,
But i don't see anything suspicious except the debugger 3 or 4 times passing this libraw options. First time on metadata read, and set nothing but last three (or more?) times it already has actual settings set.
But worth to mention, looks like demosaic did only once. So i can't get where this slowdown in oiio happen.

Check the CI run to see that clang-format found a couple of very minor things, but other than that, it looks good to me.

Fixed.
I also added info about default values.
Do you have any ideas why enabling this pre-demosaic denoising can have such a significant impact on plugin speed when libraw directly has only 5-10% slowdown?


Added .m4b extension to AUDIO_EXTENSIONS

the .m4b extension is identical to a .m4a extension with extra audiobook related metadata. m4b plays without issues in ReactPlayer

Published in 2.10.0


Support complex-valued matrix in cupy.linalg.inv

This PR aims to support matrix inversion of complex-valued matrix by cupy.linalg.inv.
Please note that this depends on https://github.com/cupy/cupy/pull/2320.

@anaruse I owe you a sincere apology. Sorry that I just realized about this. Apparently I also created a patch to cupy.linalg.inv() to support complex type in #2468 without realizing it was a duplicate of your work, and gave credit for the Cython codes to the wrong person (which I fixed in the PR description now). Looking back I even left a comment in this PR! I guess I just didn't pay enough attention to what issue you have solved back then...

@anaruse I think your PR is still needed, as it gives a clearer error message.

I am sorry too for not noticing this PR when reviewing the other one 😢I agree that changing the error message could be a good idea.

No problem at all, @leofang , @hvy.
I thought this PR was still blocked by another PR, is it correct?

@anaruse No, #2320 is already merged. I think you just need to rebase and resolve the trivial conflicts.

I understand the situation.. I resolved the conflicts. Could you check it again?

Thanks, LGTM (cc. @toslunar)! @anaruse could you just update the title of this PR?
Actually if I am to be picky, I would've aligned the error message to _batched_inv but that a really small detail...https://github.com/cupy/cupy/blob/16adbb98a6c8bd820dad87b5e7a9b56c40957c48/cupy/linalg/solve.py#L332-L334

I also like consistency, so I fixed the error message.

Jenkins, test this please.

Jenkins CI test (for commit b4fc8d9611fb2e0952743a5a27197c04d3693012, target branch master) failed with status FAILURE.


Duration flag added to externalize more than 365 days for CA certficate generation

Hello Team,
I have modified default 1-year certificate tenure to extend by adding the custom flag "duration" can be extended to n number of years. Please share the procedure to integrate with credhub-API to take effect of this flag.
Even this topic I have already discussed with the community and got the approval for PR.
https://cloudfoundry.slack.com/archives/C02HPPYQ2/p1535741848000100?thread_ts=1534481408.000100&cid=C02HPPYQ2
Please review it and share your comments.
Regards
Lingesh M

Thank you for your contribution @hmlingesh
Since the branches have diverged since you've submitted the PR, I went ahead and fix the conflicts before merging.


Support Server Side Encryption (SSE) for AWS S3 buckets

Is your feature request related to a problem? Please describe.
We have a blanket policy of enforcing SSE for every bucket that we use in our infrastructure. This is a problem when working with the Vault Operator, because the policy will prevent anything to be written in the bucket unless it specifically requests that the objects are encrypted at rest.
Describe the solution you'd like
Add the ability to the Operator to request an object to be encrypted on the server side. There are two algorithms that can be used: AES256 or aws:kms.

In the case of AES256 the user doesn't need to do anything, the S3 API will automatically use a key to encrypt the data at rest, transparently to the application.
In the case of aws:kms, the user must provide the ID of a Customer Managed Key (CMK) that will be used to encrypt the data at rest by the S3 API.
A potential way of implementing this would be to add a new flag called s3SSEAlgo which is of type string and has either the value AES256 or aws:kms. If the algorithm is AWS256, then no aws-kms-key-id is needed and if one is provided, that will result in an error. If the algorithm is aws:kms, then the user must provide an aws-kms-key-id. According to the AWS docs, the region of CMK must be the same as the region of the bucket. If they are not, the Operator must throw an error.
This solution is backwards compatible, and should not need a lot of extra code to be implemented.

Describe alternatives you've considered
Can't think of any other alternative. Open to new ideas though.
Additional context
That's it.

Hi @ptzianos!
I absolutely like the idea and also that you thought about backward compatibility. Do you plan to implement this feature as well?

@bonifaido yeap, already on it. should have the PR ready in a few hours


Slow tile loading when 'heavy' MapAnchor visible

I've just upgraded to 0.19.0 and have noticed that having a relatively heavy (i.e lots of materials/geometry) MapAnchor is making new tile loading extremely slow, sometimes even not loading at all. I tested this by having a visibility toggle for my MapAnchor. When the MapAnchor is visible the tile loading is really slow, sometimes not even loading surrounding tiles. By simply toggling it's visibility the tiles instantly load. This wasn't the behaviour in previous versions, however I did upgrade from all the way back 0.14.0. Is this likely a bug or misuse on my side?
Here is a short gif demonstrating the visibility toggle and how the tile loading is affected, starting with the MapAnchor being visible,. As you can see after hiding the anchor the tiles load almost instantly.

OS: Windows 10
Browser: Chrome
Version: 85.0.4183.83 (Official Build) (64-bit)

I'm closing this issue for now since I think it needs more testing on my side. Will reopen if it persists.

After further investigation it appears something changed in 0.18.0 that causes this. I've tested with 0.17.2 and it appears to stop here. Did anything change in 0.18.0 that might affect this?

@harrycollin , sorry I didn't get around to looking into this. I will ask in the team as I am off tomorrow, or I look into it next week.

@nzjony no worries :)

As I'm using react for my apps this issue might be related to this. I've noticed significant performance issues since upgrading to newer harp.gl releases after 0.14.0. I recommend building the app on here and seeing the frame-rate when going close to the ground (high zoom levels). I apologise if this changes the original cause of this issue as I fear it's a byproduct of using harp.gl with react incorrectly.

@harrycollin , I will give it a try now.

@nzjony i forgot to mention - edit app.js line 13 to increase max zoom level

@harrycollin , I checked the performance in Chrome but was getting 60 FPS, see: https://youtu.be/Gg_GhHrmIt8
Can you try finding where it slows down and then record the performance? I would like to see what function is taking so much time.

@nzjony That's strange. I've recorded a video here to demonstrate the problem. I have linked the chrome performance profile as well. Let me know what you think.

I loaded the perf output, but I just see a lot of "value".
Where the frames take ~ 370ms, what is this function that takes so long?

@nzjony I'm not sure about this one. It believe it's due to react bundling code at build-time.

@harrycollin , I just ran yarn start, I will try building it and let you know how I get on.

@harrycollin , I can reproduce the issue locally. Very strange. I will ask in the team if they know.

@nzjony I will try to produce a better profile as well

@nzjony here is a profile. With react you have to include the --profile flag when running npm build. Download here.

@harrycollin , please grant me access

@nzjony I've updated the link.

@harrycollin , I tried to reproduce the slow down with our internal example but couldn't. I recommend we wait until it is made public and then you retest and we see if there is still some issue. I'm not a react expert so unfortunately can't give you any idea how to progress forwards.

@nzjony thank you for trying! Am I able to see a preview of the internal example? Specifically any webpack and decoder configuration.

@harrycollin , not yet unfortunately, it has to go through the legal process :(. I will try to get an idea how long it will take.

@nzjony I understand. Hopefully not too long!

@harrycollin , I spoke with @robertoraggi , he said that:

yarn build creates an es5 bundle and yarn start keeps the code in es2017. harp.gl in es5 may run slower than es0217 because many features that we use (like await/async, generators, classes, …) are emulated.

@nzjony this is interesting. Is there anything I can do to help?

@harrycollin , we had another idea, instead of creating a new repository, we can add the react app as a yeoman generator, so that means we don't have to do through any legal loopholes. I will start work on it and let you know when we have something up.

@harrycollin , I spoke with @robertoraggi  and he suggested to:

run yarn eject
open webpack.config.js and search for test: /\.(js|mjs)$/,
Replace

{
              test: /\.(js|mjs)$/,
              exclude: /@babel(?:\/|\\{1,2})runtime/,
              loader: require.resolve('babel-loader'),
              options: {
                babelrc: false,
                configFile: false,
                compact: false,
                presets: [
                  [
                    require.resolve('babel-preset-react-app/dependencies'),
                    { helpers: true },
                  ],
                ],
                cacheDirectory: true,
                // See #6846 for context on why cacheCompression is disabled
                cacheCompression: false,

                // Babel sourcemaps are needed for debugging into node_modules
                // code.  Without the options below, debuggers like VSCode
                // show incorrect code and set breakpoints on the wrong lines.
                sourceMaps: shouldUseSourceMap,
                inputSourceMap: shouldUseSourceMap,
              },
            }

With:
{
              test: /\.(js|mjs)$/,
              exclude: /@babel(?:\/|\\{1,2})runtime/,
              use: {
                loader: "babel-loader",
                options: {
                  presets: [
                    ["@babel/preset-env", { targets: { chrome: "85" } }],
                    "@babel/preset-react",
                  ],
                },
              },
            },

I tested it quickly and the performance seems to be improved.

@nzjony thank you! I'll test it on my end

@nzjony @robertoraggi This works nicely, thank you! However I must ask is there a way to do this without ejecting? It would be my last resort.

as far as I know, from what @robertoraggi was telling me, react-scripts transpiles to es5, so I think you are stuck with having to eject for now until we can investigate the performance bottleneck for es5

Okay I see. I'll try a few things and post a solution if I find one. Is your internal react example ejected then?

try to change "browserslist" in the generated package.json. The default value for production targets browsers that don't have es6 support.
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },

@robertoraggi Thank you! This appears to have resolved the horrible performance after a quick build. I didn't know this affected the compilation process. Can you explain a bit more?

@harrycollin CRA based projects use babel to transpile the code
so you can use the babel's browserslist integration to target modern JS
https://babeljs.io/docs/en/babel-preset-env#browserslist-integration


Excluding file means it is not copied by explicit instruction

Description
I'm trying a hybrid approach using type project to enable metadata in csproj but copying files manually.
An alternative solution that could be nice is if there was an option to override package directory. In the example below it would be analyzers/dotnet/cs and not lib/netstandard1.3
Maybe:
package_directory: analyzers/dotnet/cs in the template file.
Repro steps
type project

files
  !bin/Release/netstandard1.3/Gu.Localization.Analyzers.dll
  bin/Release/netstandard1.3/Gu.Localization.Analyzers.dll ==> analyzers/dotnet/cs

Expected behavior
The file Gu.Localization.Analyzers.dll to be in analyzers/dotnet/cs of the package.
Actual behavior
The file Gu.Localization.Analyzers.dll is not in the package.
Known workarounds
Use type file and duplicate metadata.

Found <BuildOutputTargetFolder>analyzers\dotnet\cs</BuildOutputTargetFolder>

There is also <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>