Add link prop to Button, which is rendered instead of creating a  or <button> element

This is useful for integrating React Router's <Link> elements (http://rackt.github.io/react-router/#Link).
Not sure this is the best way to go about it (I'm a JS n00b), feel free to give me feedback!
Why I needed to do this:

If I wrap a <Button> in a React Router <Link>, it is rendered as <button> instead of just a . This screws up some styling and semantics.
I can't get the raw href value from React Router to pass to <Button> before the component has rendered (AFAIK).
I can imagine a world where someone would want to create their own <CustomLink> or whatever and have that passed through instead of using a raw .

@JedWatson IIRC we decided against this a while back as it would require a react-router dependency. Let's review again and see what we can do

@jossmac: Why would it require a react-router dependency? The code as it is written just blindly renders whatever element is put in the link prop instead of rendering a <button> or . It could be <MyCoolLink>, , or whatever....doesn't have to be a react router <Link>.
If you don't set the link prop it behaves as is. What am I missing? :smile:

@jossmac @LegNeato is right - this is a neat way of allowing use with react-router and it doesn't create a dependency on it at all.
@LegNeato sorry for the delay reviewing, crazy week. We sometimes allow custom components to be passed in, this is a different take on that pattern that I think makes sense; I'd like to consider it a bit more though, I'll get back to you soon. 99% we'll merge this :)

@JedWatson: No worries, just wanted to make sure I was understanding everything...like I said, I am new to modern JS and happy to change anything :beers:

@LegNeato can you drop a quick example of how to use this in here?

Sure, in the PR or in the docs?
import React from 'react';
import Link from 'react-router';
import Button from 'elemental';

class LinkExample extends React.Component {
    render() {
      var accountLink = <Link to="account" />;
      return (
          <Button link={accountLink}>Your Account</Button>
      );
    }
}

@LegNeato that's great, just needed to see how you were using it. I think that maybe a better name for the prop would be component, I've seen that used in other React projects and really this could be anything (not just a <Link>)
Thoughts?

Done. :+1:

@LegNeato - totally missed the notification on that last update, sorry! Merging this now.


Fix RedHat repo url

The RedHat repo is in the /rhel path, not /redhat at this point:
https://repos.influxdata.com/

This PR adds uses the correct path for systems with "RedHat" ansible_distribution.

Merged in upstream. https://github.com/rossmcdonald/influxdb/pull/18


What does adding Connectors look like with Venice?

We're not looking at this currently.  I will re-open if needed.


Full middle click support

Add support to use middle click on the entire tweet, also on quoted tweets, so you can open the tweets into a new tab.
ctrl + normal click works, but it would be a huge improvement to new twitter, if this was possible.
Thanks for the great script / addon.

This seems to have been fixed by Twitter itself now


Output path

Hi! This is more like a question, is possible to have an output path param? I need to normalize the param for windows, but passing from the file is not that easy. Is it possible?

Hi. Could you explain more, what kind of output path? Currently you can specify path for .env and dart file. Or you referring to something else?

I'm saying if we could specify the output paths from a command, without the filé.

Sorry, wanted to reply but didn't send the question ((( could you explain what it's not easy to specify path in yaml file? Maybe it's something I need to fix in the package for windows env?


Prevent multiple instances of the same feed from being added

Discussed in https://github.com/SamTV12345/PodFetch/discussions/426

Originally posted by shooftie November 15, 2023
I was having trouble uploading my OPML and have managed to add 5 instances of many of the feeds.
It would be helpful to prevent the same feed from being added multiple times, additionally, it would be even more helpful to throw up a notification that this was the case.

OK, so I did some testing to see whether I could find a pattern.
I removed all but one of the feeds from my OPML to see whether I could reproduce it. I could not. It would appear that the issue might be related to:

the fact that I am upload so may at once
the fact that I was using an old image (i can't remember whether I had this issue before or after you fixed it in #419)

What I did manage to do, however was this:
https://github.com/SamTV12345/PodFetch/assets/2161844/b2b10b30-8bd4-4e5c-9305-39bc629ea3fb
(apologies for the quality, there is a 10MB limit on uploads)

I cannot work out any rhyme or reason as to which feeds duplicate and which do not...

99% Invisible: last release 1 week go – duplicates
A Brief History of Mathematics: last release 13 years ago – duplicates
Inside Science: last release 6 days ago – does not duplicate
Motormouth Recordz: last release 4 years ago – does not duplicate

I've got the same duplicate issue. But I suspect in my case this might be related to my mobile device gPodder sync.


Do not modify Transfer-Encoding header on retry

Fix #8801.

@bneradt Do you have any idea about testing this with the proxy-verifier? The server needs to refuse a request once and force ATS to retry.

@bneradt Do you have any idea about testing this with the proxy-verifier? The server needs to refuse a request once and force ATS to retry.

Hi @masaori335 . Reading the #8801 issue, it looks like this can be reproduced by a client and ATS proxy with a non-existent server. We could reproduce this setup in AuTest and make the Default process a Proxy Verifier client and have it talk with an ATS process configured against a non-existent server. Would that work?
Otherwise, would some sort of 4xx or 5xx response from a Proxy Verifier server satisfy the need for it to refuse the request?

Cherry-picked to v9.2.x


Bug/resources component rendering

Description
/Resources component was not rendering due to a bug which was fixed.
added key props to resources cards and fixed warning
Video Link
https://www.loom.com/share/a09183119efe45bcb1f5a52350a0c9f5
https://loom.com/share/7290a5024e414b1ea59ba96e380c1f4d
Trello Link
https://trello.com/c/AllHe46N/416-resources-component-not-rendering

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

 Resources component not rendering


(Feature request) Allow inverting button activation

This is a bit of an edge case, but would it be possible to set specific pins to register high instead of low? The use case that I have is the Xbox 360 Hori Fighting Edges start/select touchpad, which appears to activate inverse from the rest of the buttons (It holds the input and then lets go upon pressing when I hook it up to a Brook UFB). Being able to set some pins to follow this behavior would enable me to upgrade this case, retain the touchpad without adding anything extra into the board. Sadly the original pcb was damaged before I bought it so I can't just piggyback off of it

Hey @Aigis,
Believe it or not I actually designed a replacement PCB for these that uses the Pico haha.
If you are on Discord toss me a message and I can send you the plans for it.


Made following fixes in simulator

Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource layer
Added support for scaling up a running VM in simulator
Fixed some method names not following convention

In order to test PR https://github.com/apache/cloudstack/pull/725 using simulator some of these changes are needed.
Based on the way HV check is present in the scale VM API, had to explicitly put simulator related check to allow support. The ideal way would be to remove all these HV specific check from code and made them some configuration (by putting them in hypervisor_capabilities table in DB). But that will be a bigger effort outside the scope of this PR.

LGTM.

HI @koushik-das
I've reviewed the code in this PR and it looks pretty good. I really like what might seem like small things (lower-case on method names, extra spaces in log messages, etc). It shows attention to detail. Kudos for that.
I would like to run this somehow. Can you give me some pointers to how can I do that?
I mean, I get I need to run the simulator (although I never have before, I will learn), but then what about data center config to be deployed?
I assume that the test smoke/test_scale_vm.py will be the one to hit this code.
Also, if I can suggest an improvement, I would make the commit message (and the PR title along with it) more concrete. I mean, you do specify three changes in the body of the message, but the header is what we typically read in the commit history. I would re-write it as (your second bullet point): "Added support for scaling up a running VM in simulator". It seems to me like the best balance between explaining the intention of the change and not adding too much low-level details.

@miguelaferreira For running tests using simulator follow this https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes,+using+Simulator.
The tests in smoke/test_scale_vm.py needs real hardware (as there is some SSH being done to the VM created) and so cannot be run with simulator. But you can manually run a scenario where you scale up a running VM in simulator environment. About the commit message, the header does say that the commit is about simulator fixes. Since there are other changes as well, I didn't mention in the header that the commit is only about scale VM support.

I completely understand the reasoning behind the header text, I just don't agree that ".. following fixes .." is a good header for a commit. But given the current-state-of-the-practice in this project, it does not seem like a big deal either.
So, besides creating a scenario manually, is there a test I can run that hits this code? If there isn't wouldn't it be great to add one?

@miguelaferreira Sure a test can be added. Would you mind creating one and send out a PR? You can start with the smoke/test_scale_vm.py and tweak it to run only with simulator.
While working on PR #725 I had to fix the simulator to test that specific scenario (dynamic scaling with migration) and thats how I ended up fixing the simulator creating this PR.

Sure, I can help you.
I will write the test for this PR and then make another PR that you can merge into this one. PR of PR :) I love the github workflow!
Then, people can actually test this and say if it looks good or not with more certainly than what you get from just reading through the code. Please allow me the time to submit the test.

Thanks @miguelaferreira.

Cool! I would that that once @miguelaferreira is done with the tests and the PR of PR, we can give a 2nd LGTM and then merge it.
Thanks, Miguel!
Cheers,
Wilder

@koushik-das my PR to your PR is ready for you to review.

Ran the test, LGTM.
test_02_scale_vm_without_hypervisor_specifics (integration.smoke.test_scale_vm.TestScaleVm) ... === TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===
ok

Ran 1 test in 44.475s
OK

@koushik-das Then, please merge my PR (here: https://github.com/koushik-das/cloudstack/pull/1)
And then @wilderrodrigues  and myself will test this PR (#741).

@miguelaferreira Done

Thanks. I'm testing again with a clean environment.

 All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===

===final results are now copied to: /tmp//MarvinLogs/test_scale_vm_KD77WX===

@wilderrodrigues can you please test this PR, it LGTM but my approval is not binding!

will test it now...
Cheers,
Wilder

@miguelaferreira your opinion feels like shackles to me.

Finished the tests... LGTM :+1:
[root@cs2 cloudstack]# python -m marvin.deployDataCenter -i setup/dev/advanced.cfg
==== Log Folder Path: /tmp//MarvinLogs//DeployDataCenter__Aug_28_2015_12_57_43_0I9K5D. All logs will be available here ====
==== Deploy DC Started ====
=== Data Center Settings are dumped to /tmp//MarvinLogs//DeployDataCenter__Aug_28_2015_12_57_43_0I9K5D/dc_entries.obj===
====Deploy DC Successful=====
[root@cs2 cloudstack]# nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg \

test/integration/smoke/test_scale_vm.py -s -a tags=advanced,required_hardware=false
--zone=Sandbox-simulator --hypervisor=simulator

==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Aug_28_2015_13_01_43_5ETXDF. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_02_scale_vm_without_hypervisor_specifics | Status : SUCCESS ===
===final results are now copied to: /tmp//MarvinLogs/test_scale_vm_NP4VUD===
@bhaisaab @koushik-das @remibergsma @DaanHoogland could one of you please merge it? I'm full up to the neck right now.
Thanks for the great stuff, @miguelaferreira

@DaanHoogland I get the feeling that by this time tomorrow I might have a clue about what you meant

@miguelaferreira you know what ip my email lives on but to explain it to the world; your approval is very much appreciated and binding to me.

@DaanHoogland I figured it was something nice, but really wasn't sure about what you meant exactly. Thank you!

Merging as 2 LGTMs


Handle undefined values for repeatable

When editing a model that has a repeatable field, its JSON data is already set. The problem comes in when you want to add a new field to the repeatable field, and that property is not set on the existing JSON object.
Currently, Backpack tries to set the value as the string undefined.
This PR checks to see if the property is set on the JSON object before overriding the default value for the field within a repeatable.

Hello @nbolender
Thanks for the PR. Quick question, doesn't #3654 solve this problem too ?
Let me know,
Pedro

@pxpm That does seem to solve my issue, though it is still setting the field value as undefined, just not the string "undefined". I think it will work in most cases, but I'm not sure if that would cause issues in certain situations.


Fix ARVRAnchor and ARVRController error spam

Fix #29542

CC @BastiaanOlij

Can't hurt doing it that way I guess. I'm wondering if the warnings/errors themselves actually serve much of a purpose. It seemed like a good idea at the time :)

Thanks!

Cherry-picked for 3.1.2.


[BUG] Issue with sprintf in Windows-Matlab

Contact details
<EMAIL_ADDRESS>Describe bug
Hi,
I am running Ganner to analyse .dat Siemens MRS data file using Matlab R2019b in Windows 10.  I load the data located in the following path: F:\Leipzig_20181101\mrs_raw\28998.75_181101_112048(.,..) but the program complains about the sprintf function. Even though this seems to be predominantly a Matlab problem, I have never had an issue with sprintf for any of my folders's name. Actually, I have changed the name of the main folder several times, but it always complains about this "escaped character".
I want to know if it is a Windows problem, Matlab problem or somehow the "path" I add into the GannetLoad should be a string instead of a char array (and maybe that complains about the folder's name).
Steps to reproduce bug
No response
Screenshots
Warning: ********** An error occured while loading dataset:
'F:\Leipzig_20181101\mrs_raw\28998.75_181101_112048\meas_MID131_svs_st_FID40704.dat'. Check data.
Skipping to next dataset in batch **********

In GannetLoad (line 723)
Warning: Escaped character '\L' is not valid. See 'doc sprintf' for supported special characters.
In GannetLoad (line 724)

Version
3.3.1
Operating system
Windows
MATLAB version
R2019b
Additional context
No response

Ok, I have tried with smaller paths and the problem is the same. Is it the problem with F:\ or the "" on Windows?

Hi @franciscofritz,
I've added a bug fix for backslashes in filenames (5b91ba2e643a565e914324f8e911e2dc7b54b049). Please update and try again to see if the bug persists.

@franciscofritz, has the fixed resolved the bug?

Hi. Actually not yet. Now it does not report the warning, however it still appears this pop-up window that says:

Are you able to share your data? My email is<EMAIL_ADDRESS>There's an error occurring that I cannot determine from that error message alone.

Also, which version of Windows are you using?

I've added another change to the code that I hope will resolve the issue. Please update and rerun your data.

Hi!
OK, sadly I can't share the data because is not "mine" (or acquired by me). But going through the debugging, the problem arises in mapVBVD_Gannet. And I think why this could be. The data I am using was acquired using Siemens VE11C version (I think, unless it is already VAX). I had also the mapVBVD function and I had to modify it time ago to reconstruct data acquired with VE version.
I will update once again but if the error comes from the map VBVD then it is not too much to do. I am using Windows 10 and Matlab R2019b.
Thanks.

Thanks for the update. If you are able to provide what modifications you made to mapVBVD for version VE, that would be very helpful for Gannet.
Please let me know if the updated version has at least resolved the error dialog issue.

Ok, let me work on it. I cannot promise to deliver results today or tomorrow, but for sure Monday if it is ok for you.
:) - and I will let you know if with the correction the code can go through.

Ok, found the error error (at the end it was not in the mapVBVD, sorry for the misunderstanding). In SiemeneTWIXRead.m, line 316,
TwixHeader.seqorig = TwixHeader.sequenceString;
error(['Unknown sequence: ' TwixHeader.seqorig '. Please contact the Gannet team for support.'])
The sequence used is
K>> TwixHeader.sequenceString
ans =
'svs_st'

(or STEAM-based spectroscopy). Since it is not part of the "list" of sequence's name, then it goes to error.

Oh... I see. Ok, let me see if I can check out with another dataset (or edited data). I will keep you posted (probably I will update this comment).


Protobuf for flexible concurrent inputs

Describe your changes
Added rpc for client to get desired concurrency from server.
Check these boxes or delete any item (or this section) if not relevant for this PR.

[x] Client+Server: this change is compatible with old servers
[x] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

@prbot automerge

@prbot automerge


Update stable version in repo from 3.2.3 to 3.2.5

Think about update stable version to 3.2.5
Version: stable=3.2.3 (124 days old) => latest=3.2.5 (15 days old)
Installs: stable=344 (60.67%), latest=33 (5.82%), total=567
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 3.2.5 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

Is there any reason to delay updating this adapter at stable any longer?
Please drop a commit if you know any reason to refrain from updating.
If there is no response until 16.11.2024 we could decide to update anyway

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 3.2.5 but the current stable version is already 3.2.6.
So this issue should be closed.
@mcm1957 for evidence


handleScroll on componentDidUpdate

I'm lazy-loading search results, with a "preview" feature on a search page that temporarily re-orders the results to let users "peek" at one of the top results without scrolling down.
Checking handleScroll on componentDidUpdate covers a component moving into view through a change to app state instead of a scrollEvent. (Previously the empty <LazyLoad> would sit in the viewport until a scroll event caused it to realize it should be visible.)

:+1: thanks!


Create snapshot from VM snapshot without memory for NFS/Local storage

Description
This PR fixes #8078
The volume snapshot will be created only on secondary storage.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

@blueorangutan package

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8009)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40457 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8009-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_03_deploy_vm_wrong_checksum
Error
39.60
test_templates.py

test_09_list_templates_download_details
Failure
0.04
test_templates.py

@slavkap is this ready? Can you add test info?

@DaanHoogland, it's ready

@blueorangutan package

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7499

@blueorangutan test matrix

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8090)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42411 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8090-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
681.68
test_kubernetes_clusters.py

[SF] Trillian test result (tid-8088)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42553 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8088-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8089)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49240 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8089-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


cimgui: init at 1.87

Description of changes
Packaged cimgui, a Dear ImGui pure c wrapper.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

added pre/post hooks

Is there any movement on this? Was surprised to not see it in nixpkgs!


[WIP] View and aggregation updates

Resolves https://github.com/voxel51/fiftyone/issues/811 and https://github.com/voxel51/fiftyone/issues/813.
Changelog

Replaces the MapValues view stage with a SetField stage that allows for setting new fields on a view using an arbitrary expression to define the value.
Adds support for the [] syntax (and automatic unwinding of common fields) to SetField
Adds a number of new ViewExpression methods exposing various string-related operations, some control flow things like case/switch statements, reductions, and other optimizations.
Fixes a subtle side-effect/bug in FilterLabels that would overwrite any custom fields that the user may have added to their Detections instance (the issue here is that $mergeObjects does not merge subfields, it overwrites the entire top-level fields. True embedded merging required a bit more care)

TODO

Remove AggregationResult per the discussion in https://github.com/voxel51/fiftyone/issues/811
Add support for applying SetField to frame label fields

Example usages:
import fiftyone as fo
import fiftyone.zoo as foz
from fiftyone import ViewField as F

dataset = foz.load_zoo_dataset("quickstart")

print(dataset.distinct("predictions.detections.label"))
view = dataset.map_labels("predictions", {"airplane": "OTHER"})
print(view.distinct("predictions.detections.label"))

print(dataset.distinct("predictions.detections.label"))
view = dataset.set_field("predictions.detections.label", F("label").map_values({"airplane": "OTHER"}))
print(view.distinct("predictions.detections.label"))

view = dataset.set_field("predictions.detections.is_cat", F("label") == "cat")
print(view.distinct("predictions.detections.is_cat"))

view = dataset.set_field("predictions.num_predictions", F("detections").length())
print(view.bounds("predictions.num_predictions"))

My initial comment is that if we think stages like FilterLabels, and LimitLabels are here to stay (and not be generalized) for the foreseeable future, then MapLabels is not out of place.

The difference between MapValues and SetField is whether the "root" document is the value or it's parent document.

Interesting, this is because SetField is not as useful if it does not have access to the parent?

My initial comment is that if we think stages like FilterLabels, and LimitLabels are here to stay (and not be generalized) for the foreseeable future, then MapLabels is not out of place.

The difference between MapValues and SetField is whether the "root" document is the value or it's parent document.

Interesting, this is because SetField is not as useful if it does not have access to the parent?

My initial comment is that if we think stages like FilterLabels, and LimitLabels are here to stay (and will not be generalized) for the foreseeable future, then MapLabels is not out of place.

Yeah I agree that MapLabels is consistent with FilterLabels, LimitLabels, etc. Labels are the most important data type, so I do think it makes sense to provide easy-to-use methods for those types.

My initial comment is that if we think stages like FilterLabels, and LimitLabels are here to stay (and will not be generalized) for the foreseeable future, then MapLabels is not out of place.

Yeah I agree that MapLabels is consistent with FilterLabels, LimitLabels, etc. Labels are the most important data type, so I do think it makes sense to provide easy-to-use methods for those types.

The difference between MapValues and SetField is whether the "root" document is the value or it's parent document.

Interesting, this is because SetField is not as useful if it does not have access to the parent?

Actually its the other way around: the idea of MapValues is that it is exclusively useful for transforming values to other values. SetField gets access to the parent document of the field you are setting. In fact, SetField has a root flag that enables you to specify whether you would like the expression to be relative to the root sample document instead, in which case you have access to any information you want.
So from that standpoint, if something is on the chopping block, it should be MapValues.
I'd be interested to get your feedback on the current behavior of SetField w.r.t. the parent document vs. root sample document business. I thought about always defaulting to requiring the expression to always be defined relative to the root sample document, but, automatic array unwinding adds some complications there. I would have to do some logic on the expr argument to match any unwinding that may have taken place.

The difference between MapValues and SetField is whether the "root" document is the value or it's parent document.

Interesting, this is because SetField is not as useful if it does not have access to the parent?

Actually its the other way around: the idea of MapValues is that it is exclusively useful for transforming values to other values. SetField gets access to the parent document of the field you are setting. In fact, SetField has a root flag that enables you to specify whether you would like the expression to be relative to the root sample document instead, in which case you have access to any information you want.
So from that standpoint, if something is on the chopping block, it should be MapValues.
I'd be interested to get your feedback on the current behavior of SetField w.r.t. the parent document vs. root sample document business. I thought about always defaulting to requiring the expression to always be defined relative to the root sample document, but, automatic array unwinding adds some complications there. I would have to do some logic on the expr argument to match any unwinding that may have taken place.

Looking through the code, I don't see any root=True usage. It might also be a leaky abstraction to users, if I understand how root=True works (or would work). I'll respond again in the morning after looking at the implementation more, but a root=True option doesn't seem release critical.

Looking through the code, I don't see any root=True usage. It might also be a leaky abstraction to users, if I understand how root=True works (or would work). I'll respond again in the morning after looking at the implementation more, but a root=True option doesn't seem release critical.

Very cool to see all the new additions to view expressions.

Very cool to see all the new additions to view expressions.

I am happy to help update things server side when AggregationResults have been removed. Might speed things along. I'll need to tweak some javascript code at a minimum unless serialized results do not change at all.

I am happy to help update things server side when AggregationResults have been removed. Might speed things along. I'll need to tweak some javascript code at a minimum unless serialized results do not change at all.

I am happy to help update things server side when AggregationResults have been removed. Might speed things along. I'll need to tweak some javascript code at a minimum unless serialized results do not change at all.

@benjaminpkane That would be great. I've removed AggregationResult and updated almost all Python code. There's a least one place that I left a todo that needs your attention in fiftyone.server.main._gather_results().
The serialized format of the aggregation results has changed slightly, so you will need to make some small updates in various places.
One small thing I'm undecided about is which of these is preferable:
#
# current behavior
#
# The motivation here is that np.histogram() returns a `(counts, edges)` tuple, but we also
# return `other` and (a) three output arguments is starting to be a lot, and (b) `other` is
# often probably not interesting
counts, edges, other = dataset.histogram_values(...)

# alternative
result = dataset.histogram_values(...)
# result = {"counts": counts, "edges": edges, "other": other}

Any thoughts here?

I am happy to help update things server side when AggregationResults have been removed. Might speed things along. I'll need to tweak some javascript code at a minimum unless serialized results do not change at all.

@benjaminpkane That would be great. I've removed AggregationResult and updated almost all Python code. There's a least one place that I left a todo that needs your attention in fiftyone.server.main._gather_results().
The serialized format of the aggregation results has changed slightly, so you will need to make some small updates in various places.
One small thing I'm undecided about is which of these is preferable:
#
# current behavior
#
# The motivation here is that np.histogram() returns a `(counts, edges)` tuple, but we also
# return `other` and (a) three output arguments is starting to be a lot, and (b) `other` is
# often probably not interesting
counts, edges, other = dataset.histogram_values(...)

# alternative
result = dataset.histogram_values(...)
# result = {"counts": counts, "edges": edges, "other": other}

Any thoughts here?

counts, edges, other seems convenient to me. Once a user learns the format, I think they would prefer a tuple.

counts, edges, other seems convenient to me. Once a user learns the format, I think they would prefer a tuple.

Ok, server looks good now.

Ok, server looks good now.

@benjaminpkane can you explain the purpose of the hide_frames and hide_result arguments of ViewStages that process frame labels? The SetField and MapLabels stages now support frame labels, but I'm unsure what to do with those arguments and why they exist in general.

@benjaminpkane can you explain the purpose of the hide_frames and hide_result arguments of ViewStages that process frame labels? The SetField and MapLabels stages now support frame labels, but I'm unsure what to do with those arguments and why they exist in general.

hide_result applies Fields Sidebar filters to pagination (allowing for only matched results), but allows for the full sample info to still be sent so in the sample modal when a filter is changed, requiring more data to be presented, the sample has it.
For example, a user may select only cat detections in the sample grid for field, expand a sample (open the modal) and then remove the "only cats" filter. The modal has the data to show all detections because of hide_result. Perhaps requiring a new request to be sent when the modal is opened is preferred. hide_result seemed like a more appropriate MVP, though.
hide_frames can and should be removed. I can at least try to remove its usage in the server right now. It places frames in the _frames field. That's all.

hide_result applies Fields Sidebar filters to pagination (allowing for only matched results), but allows for the full sample info to still be sent so in the sample modal when a filter is changed, requiring more data to be presented, the sample has it.
For example, a user may select only cat detections in the sample grid for field, expand a sample (open the modal) and then remove the "only cats" filter. The modal has the data to show all detections because of hide_result. Perhaps requiring a new request to be sent when the modal is opened is preferred. hide_result seemed like a more appropriate MVP, though.
hide_frames can and should be removed. I can at least try to remove its usage in the server right now. It places frames in the _frames field. That's all.

hide_frames was meant to be an optimization for pagination, but I think it is negligible at this. I just need to truncate pagination requests to only contain the first frame.

hide_frames was meant to be an optimization for pagination, but I think it is negligible at this. I just need to truncate pagination requests to only contain the first frame.


ci: add renovate configuration

Since we have a lot of pin dependencies renovate will help us automate dependency updates.

We should probably exclude all package.json templates inside schematic packages

@alexeagle I add a rate limiting of 2 PR / hour. and scheduled it run between 10pm - 4am every weekday (Pacific TimeZone) and run freely during the weekends.

I don't think this scheduling actually improves it, we can still get 12 PR's per day. I'd rather get one PR a week or so. But let's try this and see how it works.


How to disable spell check.

I want to disable the default spell check. Usually, I'd do this by setting spellcheck="false" in HTML, not sure how to do it here.

Not supported currently, happy to accept a PR. I will move this to discussions, that's where I keep features like this.


entry: Mark Entry::from_parts_1_1() as unsafe

Entry is the only struct marking some Vulkan API calls as safe, as their soundness can be trivially upheld.  This however relies on vkGetInstanceProcAddr returning a sound function pointer, which is not something we can guarantee when the user passes us function pointers via Entry::from_parts_1_1() instead: hence mark this new constructor as unsafe to uphold this contract.
Related discussion chain: https://github.com/ash-rs/ash/pull/748#discussion_r1186794284

Did you want to also mark the individual methods as unsafe for consistency?

We were not going to do that because the safety contract could be upheld on the Vulkan side, right? The only problem was that we can no longer validate this when the function pointer itself originates from an unknown source (e.g. not vkGetInstanceProcAddr).
Otherwise I would have gone for marking the functions as unsafe instead (to match all other Vulkan functions) and leave this function as safe (to match from_parts on Instance and Device) but we discussed the opposite in https://github.com/ash-rs/ash/pull/748#discussion_r1186794284?

Both approaches are equally valid from a correctness standpoint. I understood from that conversation that you strongly favored the approach of marking the wrapper functions as unsafe for consistency?

@Ralith yes they are, but since you put so much emphasis on (extern) C functions being not necessarily/inherently unsafe to call, I figured the preference was to mark from_parts unsafe?
I haven't checked any of the safety contracts for these C functions, so we might as well mark them unsafe and keep the from_parts function safe (both matching how ash exposes the API everywhere else) then?

you put so much emphasis on (extern) C functions being not necessarily/inherently unsafe to call

This was a point of fact, but is not necessarily the deciding factor. Apologies for the confusion!

I haven't checked any of the safety contracts for these C functions, so we might as well mark them unsafe and keep the from_parts function safe (both matching how ash exposes the API everywhere else) then?

I find this appealing from a consistency standpoint. Even though we can easily deem these safe, it might be confusing to do so when we in general don't.

Ah, that makes sense then! Sure, I'll mark the C function wrappers unsafe instead.


Update access package organization to match sales feedback

Currently our access packages have an index.html file with a folders for each system and assorted files like the stylesheet in the root folder. The ask is to:

Rename index.html to welcome.html
Nest everything else under a folder called Access Package or Data

moving to done


⚠ ClamAV has degraded performance

In 70fc991, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in 29d1754.


[BUG] [object Object] in notification message preview.

What is the bug?
As described in this post, some ctx variables display as [object Object] in the preview window of the UI.
https://github.com/opensearch-project/alerting/pull/1450#issuecomment-2500386877

[Catch All Triage - 1, 2, 3]


Let the user choose the order of header-information

I think it would be a great enhancement to give the user some kind of control on the order of the elements in the header. I'm speaking about \mobile, \email, \homepage, \github, and so on.
For example, some might want to have their linkedin profile before github, etc.
I would be willing to implement this, however I'm not that experienced in LaTeX. So, I don't know how I would do that without messing up the code base too much. If this feature is wanted, I'd like to get some guidance/hints on how I could implement this.
I know that right now each of these header-fields is processed in a specified order in a rather long if-elseif-else, beginning at line 439 in awesome-cv.cls ( https://github.com/posquit0/Awesome-CV/blob/master/awesome-cv.cls#L439 ). Would it be possible to add an additional parameter order to each field or (even better) to retrieve the order from the order in which the definitions of these elements appear in the user's LaTeX-doc?

Could this fetere be implemented? I have been trying to get this too work but it keeps on crashing.


Missing instructions for p2

The compiler seems to be missing various instructions of the propeller 2.
I tried to use them in inline asm of a C project and got a compiler error.
Error Message:
blink.c:233:10: error: invalid operand for instruction
        "                   mergew  %[rx0]                      'reorder data                   \n"
         ^
<inline asm>:21:20: note: instantiated into assembly here
                   mergew  r2                      'reorder data

The error occured also with the setword instruction. There are probably more, but I only encountered those two so far.
asm function (shortened):
asm volatile (
    // [...] shortened for github issue
    "                   shr     %[rx0],     #16             'shift r0                       \n"
  //"                   setword %[rx1],     %[rx0],     #0  'merge data                     \n"   // missing in compiler, currently emulated in following 3 instructions
    "                   augs    #0x7fff80                   'merge data                     \n"
    "                   and     %[rx1],     #0              'merge data                     \n"
    "                   or      %[rx0],     %[rx1]          'merge data                     \n"
  //"                   mergew  %[rx0]                      'reorder data                   \n"   // missing in compiler, currently done in post
    // [...] shortened for github issue
    :         "=r" (rx0),       "=r" (rx1),        "=r" (buffer[0])                                                   // output register
    :   [rx0] "r"  (rx0), [rx1] "r"  (rx1), [addr] "r"  (&buffer[0]),   [lim] "r" (buffer_end),   [tmp] "r" (temp)    // input register
    :   "ptra"                                                                                // clobbered register
);

I'd be willing to try adding the instructions if you can point me to some example commits of adding new instructions (preferably in this project) I can use as reference.

I can take a look at adding these in later this week or next, but if you wanna take a stab at it:
https://github.com/ne75/llvm-project/blob/ee801ce165dc3a968ea78d7f793c713a91aabe97/llvm/lib/Target/P2/P2InstrInfo.td is where instructions are actually defined.
Each instruction is an instance of one of the classes defined here: https://github.com/ne75/llvm-project/blob/ee801ce165dc3a968ea78d7f793c713a91aabe97/llvm/lib/Target/P2/P2InstrFormats.td
Each class represents a specific format of instruction (whether or not it uses D, S registers, has immediates, etc)
There are also multiclasses that simplify created instructions that take both immediate and register operands (these are the ones that end in an lowercase m), but you'll see some instructions are defined manually (and are suffixes rr or ri for register-register or register-immediate, etc).
There are a few P2 instructions that will be a pain to add as they won't fit into any of these classes and therefore will require a custom ASM parser to be added as well. Hopefully you aren't needing any of those.
Let me know if this is helpful!

Thanks. I'll take a look at it on the weekend.
Currently I only need the various bit/byte/word manipulation instructions. But if I manage to add those I'll try to add as many of the currently missing instructions as possible.

the mergew and related instructions should be easy to add, just follow the format of another P2InstD instruction definition.
The ones I know will be a bit of a struggle are the setnib/byte/word and related instructions, as they take 3 operands and that will require some work to implement, both in the instruction declaration and in the asm parser. I think I'd only go through that effort myself if enough other folks find a need for it (or when I hit a wall needing those instructions myself).


Virtuals for testing

Hey guys, the retrieval of concrete classes in the BlockDefinition isn't really conducive to testing, but we can get around it if we mark the given methods virtual.
Hopefully this is okay!

@majikandy this is to separate FN changes from SC, but alas I think I won't be needing this at the moment anyhow :(


Revising desktop release process

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[ ] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Updating desktop app release checklist and adding details about our updated desktop app release cycle/schedule expectations.
Removing changelog from the desktop app repo.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

/cc @esethna

Thanks @amyblais, Looks good as most items are similar to webapp process.
Dev should review too as the technical aspects are different, adding @deanwhillier


Voting - lock timer is breaking into two lines

Describe the bug
Lock timer on desktop breaks into two lines.
To Reproduce
Open the vote screen, stake some BNT and vote.
Screenshots

Smartphone or Desktop/Laptop?
Desktop

Seems like we still have an issue -


[CSL-1173] Reduce the size of .hi-files

@int-index https://github.com/input-output-hk/cardano-sl/pull/883 includes these changes, enabled linux build again and turns on the haddock. All passing

Could we document some before/after behaviour of this fix?

The number of terms/types/coercions as output by ghc -v
A directory tree listing showing the size of all .hi files and their text equivalent
An excerpt from relevant .hi-dump files


Create reality model transform with fixed point at reality model range center rather than project extents center.

The tileset publishing was updated to calculate the reality model transform to match this change here. https://bentleycs.visualstudio.com/iModelTechnologies/_git/imodel02/pullrequest/134625

@Mergifyio backport release/2.10.0

@Mergifyio backport release/2.10.0


glob follows symlinks

glob do not understand symlinks, and this cause problems in directories like /sys, where is frequent to have loops, and in some cases never ends.

Any review on #63 so I can improve the code?

I just hit this exact wall, looping infinitely in sys.
I think I'm not qualified to review, but when reading the code, I thought that follow_links might be a better name than follows_link.
Cheers,
Andre

@andre-richter I think that you are right. I updated the PR. Thanks!


spawn /bin/sh NOENT

I'm using electron-packager's API to pack the bundle, it comes out:
Packaging app for platform darwin x64 using electron v1.1.2
pack
Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:856:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:474:9)
    at process._tickCallback (node.js:388:17)

Which version of electron-packager are you using?

the packager: 7.0.2

What CLI arguments are you passing? Alternatively, if you are using the API, what parameters are
you passing to the packager() function?

 {
        name: 'MyApp',
        'app-version': '1.0.0',
        dir: projDir,
        asar: true,
        prune: true,
        arch: arch,
        platform: plat,
        version: _.trim(packageJson.devDependencies['electron-prebuilt'], '^$~'),
        out: `release/${plat}-${arch}`,
        ignore: (dir) => {
            console.log('pack', dir);
            if (_.startsWith(dir, '/dist/') || _.startsWith(dir, '/artworks/')) {
                return false
            }
            if (_.startsWith(dir, '/node_modules/')) {
                var name = /\/node_modules\/([^\/]+)($|\/.*)/.exec(dir)[1]
                return !_.isEmpty(packageJson.dependencies[name])
            }
            return true
        }
    }

What version of Electron are you building with?

electron: 1.1.2

What is the host platform are you running electron-packager on?

platform: darwin (Mac OS X: 10.11.4)
arch: x64

What target platform(s)/architecture(s) are you building for?

platform: darwin
arch: x64

Is there a stack trace in the error message you're seeing?

see above

Please provide either a failing testcase or detailed steps to reproduce your problem.

Thanks for filing an issue, but there's not enough information here to see what the problem is. Could you provide a minimal testcase (you can use electron-quick-start as a base) so that someone can reproduce your problem?

I faced same problem. This happens because of missing package.json in built app.
Solution is dead simple, add check for empty path in ignore function:
ignore: (path) => {
    if (path === '') {
        return false;
    }

    /* Rest of checks */
}

I believe this happens because ignore function first call check empty path (directory itself) and ignores everything else.

Since the original issue reporter has not responded to the request for additional information in more than two weeks, I'm going to assume that they either found the answer in another manner or decided not to pursue this issue. If I'm incorrect, they can respond with answers to the questions posed, and I'll reopen.


Optional key

I'm working on a Zod schema for Node package exports. Part of it looks like this:
export const ExportsCoreConditional = z.object({
  import: z.string().optional(),
  require: z.string().optional(),
  node: z.string().optional(),
  default: z.string().optional(),
})

The problem here is that the resulting type is e.g. import?: string|undefined. The actually correct type is import?: string. This is because a user will never be able to write import: undefined in their package.json file, since that is not valid JSON.

So I tried this:

However TS still by default allows the | undefined possibility.
TS 4.4 has a solution to this however. I use this new compiler flag: https://www.typescriptlang.org/tsconfig#exactOptionalPropertyTypes
And then it works:

One problem this might have is that a consumer of my package might compile TS without this flag (likely will). If so, that seems like it will negate my package's effort to limit the possibility of undefined 😕 🤔 ?

Hm, my solution does not work with z.infer it seems:

I think its same issue as here: https://github.com/colinhacks/zod/issues/635

Thanks @akomm yep looks like it.


Add Computus in Rust

This is, more or less, a translation of the Julia implementation.

@fanninpm Poke for resolving Markdown conflict.


Rethink cookie upgrades

In future versions we should rework how cookie upgrades are handled.
Sites which care about security related headers being reliably delivered should already be using HTTPS on all their pages – which means that HTTP cookies shouldn't be a thing. Adding Secure to all cookies seems like a pretty damn easy win. (this would replace our current approach which is only slightly better than a whitelist). For cookies that must be sent over HTTP, we can permit cookies to be manually deselected from this upgrade.
I think this approach may be valuable for all settings though: it adopts a "permissions" view of the world where everything is disallowed by default, and the developer must actively opt-in to less protection. i.e. instead of having to remember to think about "we must disallow JavaScript from accessing a cookie", developers should instead think "we should grant JavaScript access to this cookie".
My current thinking is the following:

All cookies receive the Secure flag by default.

All cookies receive the httpOnly flag by default.

All cookies receive the SameSite=Lax flag by default.

Allow manual exceptions to be written for all of the above based on cookie name, i.e.

Explicit opt-in for cookies to be allowed to be sent over HTTP

Explicit opt-in for JavaScript to be allowed access to a cookie

Explicit opt-in for cookies to be allowed to be sent when not using top-level navigations

Allow specific cookies to be marked as "write cookies", which will upgrade the SameSite setting to SameSite=Strict. These are cookies which (if your site can be built to allow for it) should be reserved for granting write permissions to a particular user. SameSite=Lax cookies are perfectly okay for where the user need only read information.
There is a section in the SameSite cookie spec detailing a scenario where lax would be used for read permissions, and strict would be used for write permissions. Scott Helme has also done a nice explainer on using different cookies for read/write permissions in CSRF is dead.
If you're developing a new app – this is something you should definitely look into in addition to current CRSF mechanisms (when all browsers have added support for SameSite it might be possible to ditch CSRF form tokens, but that is way in the future!).

This sounds very sensible. :+1:
How would you plan the upgrade path? IMO, there should be another release in version 2 that allows an opt-in to the new default behavior.

Thanks :)

How would you plan the upgrade path? IMO, there should be another release in version 2 that allows an opt-in to the new default behavior.

I've marked this under the Version 3 milestone since that'll be the first place we can do this by default, but we can certainly add this as opt-in behaviour in a subsequent version 2 release too.


UIBarButtonItem

Can you set the badge icon on a UIBarButtonItem?

No, because UIBarButtonItem inherits from the abstract UIBarItem class, which is simply an NSObject, and as such has no frame or other UIView attributes. Perhaps we should update the tagline to: Badgify anything. (as long as it's a UIView subclass)...
:)

sad face


ModuleNotFoundError: No module named 'metaflow.metadata'

My team is experiencing an issue with the latest metaflow update (2.12.29) it's giving this error
.tox/py310-sdist/lib/python3.10/site-packages/metaflow_extensions/netflix_ext/plugins/conda/conda_step_decorator.py:27: in <module>
    from metaflow.metadata import MetaDatum
E   ModuleNotFoundError: No module named 'metaflow.metadata'

We believe the issue is happening in conda_step_decorator.py. Reverting back to metaflow 2.12.25 fixes this issue

Oh, I am sorry. Yes, I changed something. Let me update this extension to fix it.

I will do this this evening if that is ok.

Thanks. That should be fine we've pinned it for now.

I've pushed all our changes from upstream here: #51. I'll let the tests run, verify that all is well and merge. Thanks for calling this out.


Module augmentation with export list

TypeScript Version:
1.8.10
Code
// scale.ts
class Scale {
    weightOnEarth(mass) {}
}
export { Scale }

// advancedScale.ts
import {Scale} from "./scale" ;

declare module "./scale" {
  interface Scale {
    weightOnMoon(mass);
  }
}
Scale.prototype.weightOnMoon = function (ee) {
}

// consumer.ts
import { Scale } from "./scale";
import "./advancedScale";

let scale: Scale;
scale.weightOnMoon(10);  // ok
scale.weightOnEarth(10);

// tsconfig.json
{
  "compilerOptions": {
    "module": "commonjs",
    "target": "es5"
  }
}

Bug 1
This code is from this post, with just a small change: in scale.ts, the syntax of export list is used export { Scale }.
The compiler returns errors:

scale.ts(5,10): error TS2484: Export declaration conflicts with exported declaration of 'Scale'
advancedScale.ts(9,1): error TS2304: Cannot find name 'Scale'.
consumer.ts(7,7): error TS2339: Property 'weightOnEarth' does not exist on type 'Scale'.

Bug 2
With the original code, in consumer.ts, the line import "./advancedScale"; can be removed but the code still compiles.

Issue 2, is expected, since you have a tsconfig.json with no "files" or "exclude" list, and that tells the compiler to include all files. so the file is included whether you import it or not.
issue 1 is the real problem here. the work around is to export the declaration and not use an export statement:
// scale.ts
export class Scale {
    weightOnEarth(mass) {}
}


Extending the annotations

Hi,
I am trying to extend the annotations with one of my own.  However, to do this i need to subclass pdfviewcontroller and annotationcontroller and point to the new annotationcontroller in the new pdfviewcontroller. This is not possible because of access levels:
lazy var annotationController: PDFAnnotationController = PDFAnnotationController(document: self.document, delegate: self)
both document and annotationController have access level internal. Do i need to find a new route or am i doing something wrong here? It's my first time coding for ios, so it could well be :)
Thanks for your time

@jorritsmit at this point I would recommend you look at the develop branch for dealing with custom annotation types. The entire stack is being redeveloped to be less memory hungry and allow for greater extensibility. You'll find there is a new initializer that allows for utilizing your own PDFAnnotationController as well as added ability to provide your own buttons for use in the menu bar. The branch will be merged into master within the next couple of weeks here so there should not be many if any changes that will break whatever you develop.

wow thanks a lot, will definitely look at that. keep up the great work!


It is not clear that you cannot use the "GameObject/speed which you collided with" blocks outside of a "Execute if I collide" event block

You cannot use the "GameObject which you collided with" (and similar) outside of the "Execute if I collide" event block.
However, they are two separate blocks, so this is not clear. There is also no warning when you try to do this. (it simply produces wrong code)

This is improved now. There are no separate blocks for these options anymore.


Change double loading from error to warning.

Hot reloads during local development trigger this error, which is very disruptive. As this is benign, it ought to be a warning rather than an error.

Hey @josheverett,
Thanks for making a PR for this! Makes sense to me after thinking about it and having it return the already loaded Userback object is a much better API for that situation.
Ill have a look over what happened with the e2e tests today.
For the docs action, we just need to run yarn docs from the root and commit that so the docs for GitHub pages is in sync 👍🏻 .

Looks like there is an issue with how the CI is setup for tokens when run outside the org as it wants you to provide a UB_TOKEN in your own repo instead of using our token.
For this time I created a 2nd PR #28 with your changes and ill be looking to fixup the gh actions issue in #22.
Thanks again for your contributions!


Ambiguous call of sqrt on size_t

This line seems to be causing me some issues with compilation. It seems that sqrt is being called with size_t and expected to provide size_t. Should some casting and some round/ceil/trunc be applied?

this may be casted to double

Yep, I agree. Did that in PR ( https://github.com/clMathLibraries/clFFT/pull/199 ). Seems to resolve the issue.


Fix for KeyPathMultiModule test failure

This commit changes the pointer of unresolvedIndirectOffset from size UInt32 to size UInt64, so that it is compatible on both big (s390x) and little endian platforms. It resolves the failure of stdlib/KeyPathMultiModule.swift on big-endian platform.  The related discussion can be found at https://forums.swift.org/t/keypath-test-case-v5-0-failed-on-big-endian-platform/19529

Can somebody take a look at this request?

@jckarter

Is this superseded by https://github.com/apple/swift/pull/25467 ? It is not correct to do a 64-bit load for structs.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 5e4c3005e92d94be5b219492b7bbb7e89531f630

Ah, the field is pointer-sized, not always 64 bit. For compatibility on 32-bit platforms, we ought to use UInt.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 5e4c3005e92d94be5b219492b7bbb7e89531f630

Build failed
Swift Test Linux Platform
Git Sha - 5e4c3005e92d94be5b219492b7bbb7e89531f630


Icon Update does not work properly

Checklist:

[X] I'm using Visual Studio Code Version 1.4.0 Stable
[X] I'm using the extension version 1.8.5
[X] I've regarded to the FAQ and they did not help.
[X] My system is: Windows 10 Anniversary 64bit
[X] I'm sure this issue is not a duplicate?
[ ] I want to create an icon request(if not, remove these lines below):

Description:
I want again to try out the vscode icons image lib based on microsoft's icon pack by julianpaulozzi, but it does not work. What did I wrong?
please see https://youtu.be/3OsQA-i1uns
Icons Disable and Enable works, but when using Enable, the default icon pack is being used...
no errors in dev console and I am not behind any proxy
Steps to reproduce:

Change vscode.icons to https://github.com/julianpaulozzi/vscode-icons-image-lib/blob/master/icons.zip
Execute Icons Update
Nothing changed.

Expected behaviour:
Updated icons
Actual behaviour:
Nothing happens.

I think the url is wrong. Try this:
"vsicons.icons": "https://github.com/julianpaulozzi/vscode-icons-image-lib/raw/master/icons.zip"

ah, thanks. It works!, will create a pr to the owner ;)


Android Basics: Load and display images from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:'
labels: ''
assignees: ''

URL of codelab
link
In which task and step of the codelab can this issue be found?
3
Describe the problem
The list of repositories should have jcenter removed
Steps to reproduce?

Go to[link] (https://developer.android.com/codelabs/basic-android-kotlin-training-internet-images#2)
See error in the image just above section "Update View Model"

Versions
Android Studio version: 2023.1
API version of the emulator: 31 (Real device)
Additional information
Include screenshots if they would be useful in clarifying the problem.

@Bjastkuliar
Thank you for reaching out to us. It looks like the issue was fixed:


Handle empty string as token value

Description
If the token is the empty string we try to pass nil to Base64.url_decode, which always expects a string.
This ensures we always pass a string to avoid an unexpected error.
Checklist
Before the PR can be merged be sure the following are checked:

[x] There are tests for the fix or feature added/changed
[x] A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

Nice, thanks for the fix @ragalie


when I tried launch ros_g29_force_feedback

error info
[ERROR] [rcl]:Failed to parse global arguments
How can I deal with this problem?

The Yaml file wasn't loaded correctly.
How did you run the node?

~/Desktop/work_sp/Third_part/LG29$ ros2 run ros_g29_force_feedback g29_force_feedback --ros-args --params-file ros2_ws/src/ros_g29_force_feedback/config/g29.yaml
[ERROR] [1677549815.870385879] [rcl]: Failed to parse global arguments
terminate called after throwing an instance of 'rclcpp::exceptions::RCLInvalidROSArgsError'
what():  failed to initialize rcl: Couldn't parse params file: '--params-file ros2_ws/src/ros_g29_force_feedback/config/g29.yaml'. Error: Error opening YAML file, at /tmp/binarydeb/ros-galactic-rcl-yaml-param-parser-3.1.4/src/parser.c:270, at /tmp/binarydeb/ros-galactic-rcl-3.1.4/src/rcl/arguments.c:406

Rebbot I have deal with this problem Thanks!!! good job

OK, but how?
I couldn't reproduce this problem, actually.


Show sub commands on top view.

Related https://github.com/yiisoft/yii2/issues/6841#issuecomment-76645840
The result like:
$ php yii
This is Yii version 2.0.4-dev.

The following commands are available:

- asset                Allows you to combine and compress your JavaScript and CSS files.
  asset/compress       Combines and compresses the asset files according to the given configuration.
  asset/template       Creates template of configuration file for [[actionCompress]].

- cache                Allows you to flush cache.
  cache/flush          Flushes given cache components.
  cache/flush-all      Flushes all caches registered in the system.
  cache/flush-schema   Clears DB schema cache for a given connection component.
  cache/index          Lists the caches that can be flushed.

- fixture              Manages fixture data loading and unloading.
  fixture/load         Loads the specified fixture data.
  fixture/unload       Unloads the specified fixtures.

- gii                  This is the command line version of Gii - a code generator.
  gii/controller       Controller Generator
  gii/crud             CRUD Generator
  gii/extension        Extension Generator
  gii/form             Form Generator
  gii/index
  gii/model            Model Generator
  gii/module           Module Generator

- help                 Provides help information about console commands.
  help/index           Displays available commands or the detailed information

- message              Extracts messages to be translated from source files.
  message/config       Creates a configuration file for the "extract" command.
  message/extract      Extracts messages to be translated from source code.

- migrate              Manages application migrations.
  migrate/create       Creates a new migration.
  migrate/down         Downgrades the application by reverting old migrations.
  migrate/history      Displays the migration history.
  migrate/mark         Modifies the migration history to the specified version.
  migrate/new          Displays the un-applied new migrations.
  migrate/redo         Redoes the last few migrations.
  migrate/to           Upgrades or downgrades till the specified version.
  migrate/up           Upgrades the application by applying new migrations.

To see the help of each command, enter:

  yii help <command-name>

How about 2 extra spaces before sub-commands?
$ php yii
This is Yii version 2.0.4-dev.

The following commands are available:

- asset                Allows you to combine and compress your JavaScript and CSS files.
    asset/compress       Combines and compresses the asset files according to the given configuration.
    asset/template       Creates template of configuration file for [[actionCompress]].

- cache                Allows you to flush cache.
    cache/flush          Flushes given cache components.
    cache/flush-all      Flushes all caches registered in the system.
    cache/flush-schema   Clears DB schema cache for a given connection component.
    cache/index          Lists the caches that can be flushed.

@samdark done!

What about the default sub-command display?

Another problem is that this display totally drops the summary display of each command class. This is a big con for me.

?

should be done, the default subcommand should be highlighted.

ok, done!
This is Yii version 2.0.4-dev.

The following commands are available:

- asset                         Allows you to combine and compress your JavaScript and CSS files.
    asset/compress (default)    Combines and compresses the asset files according to the given configuration.
    asset/template              Creates template of configuration file for [[actionCompress]].

- cache                         Allows you to flush cache.
    cache/flush                 Flushes given cache components.
    cache/flush-all             Flushes all caches registered in the system.
    cache/flush-schema          Clears DB schema cache for a given connection component.
    cache/index (default)       Lists the caches that can be flushed.

- fixture                       Manages fixture data loading and unloading.
    fixture/load (default)      Loads the specified fixture data.
    fixture/unload              Unloads the specified fixtures.

- gii                           This is the command line version of Gii - a code generator.
    gii/controller              Controller Generator
    gii/crud                    CRUD Generator
    gii/extension               Extension Generator
    gii/form                    Form Generator
    gii/index (default)
    gii/model                   Model Generator
    gii/module                  Module Generator

- help                          Provides help information about console commands.
    help/index (default)        Displays available commands or the detailed information

- message                       Extracts messages to be translated from source files.
    message/config              Creates a configuration file for the "extract" command.
    message/extract (default)   Extracts messages to be translated from source code.

- migrate                       Manages application migrations.
    migrate/create              Creates a new migration.
    migrate/down                Downgrades the application by reverting old migrations.
    migrate/history             Displays the migration history.
    migrate/mark                Modifies the migration history to the specified version.
    migrate/new                 Displays the un-applied new migrations.
    migrate/redo                Redoes the last few migrations.
    migrate/to                  Upgrades or downgrades till the specified version.
    migrate/up (default)        Upgrades the application by applying new migrations.

To see the help of each command, enter:

  yii help <command-name>

Thanks!


Updated release notes to fix bullet placement

This PR updates the release notes to fix the bullet placement.

Deploy preview for pf-next ready!
Built with commit 086a08d71230a1571d207d5dc23623f1549bc77f
https://deploy-preview-2146--pf-next.netlify.com

:tada: This PR is included in version 2.26.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Develop

I love Harvest almost 100% as-is, but I wonder if this configuration would be more friendly to the idea of getting up and running fast and with no fuss. Using BrowserSync instead of LiveReload frees you up from having to install a browser extension and includes a ton of great options, easily configurable. What do you think?

That's a great idea! If there's a way to make it easier, I'm all for it.
I pulled in your changes, but I'm getting a couple weird things:

Segfault errors: 85049 segmentation fault gulp
I disabled the notification that popped up on every refresh, but that seemed to make the segfault errors worse

Are you getting those seg faults too?

That's weird for sure. I just double checked everything and I'm not experiencing those errors, nor have I ever.

Just out of curiosity, did you make sure to sudo npm install again after pulling in my new package.json file?

Odd that you're not getting any of the errors. I installed everything using sudo. I'm running Yosemite 10.10.2 and Node 0.12.0.  I'll try to update some things and try it again.

I realized I was running Node v0.10 something or other. I updated to the latest version of Node, v0.12.2. Then I had to upgrade node-sass as well. This is the new commit for that. Works great for me. Try it out and see.

Running Yosemite 10.10.2 as well I did not need to run sudo npm install because I have my folder permissions setup correctly.  No Errors after the node-sass update.  I was already running on Node 0.12 so didn't give me an issue.

I figured it out! It was gulp-imagemin that was giving me issues. I updated it, and somehow my image task got messed up. Once I fixed that, everything worked as expected. Thanks for your help. I'll merge this in :) I'll also add in the notify: false property for BrowserSync to hide the pop up messages.
Thanks again guys and great idea :)

Great to hear!


⚠ Spryr has degraded performance

In 9395924, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6484 ms

Resolved: Spryr performance has improved in 327c63b after 10 minutes.


Added noIndent props to listItem

Enhancement based on #1847

@akhil-geekyants No need of adding new prop noIndent
This should be with default List


Use attribute types from cluster-objects.h when defining EmberAfSceneTableEntry

At least if we're OK including clusters-objects.h in af-types.h.

We are not using EmberAfSceneTableEntry with the latest PR for the scene cluster refactor.


Usage Output - try 2

Updated based on comments from @teepark. Highlights include:

removed string constants for true / false and used strconv.ParseBool
made the usage header a parameter template
no external API change from the 80% user case, i.e. all you have to do is tag and call Process

Not changed:

Still uses the visiter pattern and exposes the Visit and DocumentInfo entities, which are only required if the user wants to extend with customer config visitors.

Maybe we should talk about another approach. I'm not at all opposed to generating usage messages, but we don't need to add this kind of indirection to the core code path to accomplish it.

Happy do talk about alternative implementations. How shall we go about that?


Passing in correct duration for build times on all builds page

This fixes the build duration being incorrect on the all builds page.

This takes us from obviously wrong broken build data like

to


send Connection: close header to client only when needed

This fixes the inability to reuse connections by only setting the Connection: close header when the client or remote server requests it.
This also pulls in changes by @hmarr in #333 to explicitly terminate the connection instead of relying on an EOF from the client.

@elazarl Sorry to bother, but I noticed this one's been floating for several months... I know the :dependabot: team currently uses a fork of Goproxy incorporating the change in #333 (which this PR includes) internally so it's already seen some prod traffic with no issues.
Any chance you could take a look? I'm sure they'd like to switch back to using upstream instead of a fork.

We actually found this change might be problematic and we're testing without it to compare. So hold off on merging for now. Thanks @jeffwidman!

Oh interesting. Since this PR includes two changes, are you observing the problem with #333 or with the other change in this PR?

Let me know, and I'll merge whatever you deem helpful.
Thanks!
On Sat, Dec 16, 2023, 18:39 Jeff Widman @.***> wrote:

Oh interesting. Since this PR includes two changes, are you observing the
problem with #333 https://github.com/elazarl/goproxy/pull/333 or with
the other change in this PR?
—
Reply to this email directly, view it on GitHub
https://github.com/elazarl/goproxy/pull/514#issuecomment-1858863365, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB7RIW6GXFORCCATK6LXDTYJXFDLAVCNFSM6AAAAAA6EDHJIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYHA3DGMZWGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

The problem is the change in #333. We observed write: connection reset by peer when doing Bundler updates which went away when we removed those lines in #333.
Now that we're running without that change we're seeing less timeouts.
I think there are some changes in this PR that we might still want, like not setting the Close header after each request, but I'd like to run it in Dependabot production for a bit to ensure it's good first.
You can close #333!


ovn: unit test management port creation and clean up Windows bits

Unit tests were developed against pre-cleaned-up Windows management
port commands to ensure cleanups didn't change the command sequence.
Signed-off-by: Dan Williams<EMAIL_ADDRESS>@shettyg @rajatchopra @alinbalutoiu

@alinbalutoiu did that, but also noticed that if the clusterCIDR route already exists, but the serviceCIDR route doesn't exist, then interfaceIndex would be empty and the serviceCIDR route add would fail.  So I lifted the interfaceIndex retrieval to the top-level too.  PTAL thanks!


Improve readme of Face-Mask-Detection

To improve the readme file of face-mask-detection with relevant content.
https://github.com/akshitagupta15june/Face-X/tree/master/Face-Mask-Detection
Hi, I am a participant in GSSoC'21 and want to work on this.

Assigning you


Fix PeerScore.update() function

Motivation

Some incorrect computation where final score is 0, lodestar score is 0 and gossipScore < 0 as below:

{"peer_id":"16Uiu2HAmVcU5cjAGqRwCM1PyniSbhMPEEAgCM5aJ6qZwSFfsDgX5","lodestar_score":0,"gossip_score":-6810.915930589742,"ignore_negative_gossip_score":false,"score":0,"last_update":1675327150937}

Right now we ignore 5 biggest negative gossip score to allow them to recover but some of them are very small, for example -6000

We have no idea how clients perform in our peers

Description

In the above case the final score should be < 0, should remove the small optimization to check lodestarScore !== 0 (which was done before we take gossipsub score into account)
Only ignore negative gossipsub if it's > -1000
Track scores by client

part of #5074

It shows that Nimbus gossipsub score is low on mainnet

while other clients perform well, like Lighthouse

:tada: This PR is included in v1.6.0 :tada:


Update iExplorer to <IP_ADDRESS>

Thank you for the contribution. It was merged directly as f481be95a6e489fdcb86918bb4bce86fb41a1dca to keep commit history cleaner. Your contribution is still credited to you.


Bumping to last pmmp branch

This PR fixes #68

But its not final, let me make last commit

Well, dont know how to use github and broke this pull request, nice


use ThreadLocalRandom in adaptiveserverselector

ThreadLocalRandom:
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.80%. Comparing base (59551e4) to head (e20a1fb).
Report is 918 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13859      +/-   ##
============================================
+ Coverage     61.75%   61.80%   +0.05%
+ Complexity      207      197      -10
============================================
  Files          2436     2576     +140
  Lines        133233   142192    +8959
  Branches      20636    22091    +1455
============================================
+ Hits          82274    87879    +5605
- Misses        44911    47591    +2680
- Partials       6048     6722     +674

Flag
Coverage Δ

custom-integration1
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration1
<0.01% <0.00%> (-0.01%)
:arrow_down:

integration2
0.00% <0.00%> (ø)

java-11
<0.01% <0.00%> (-61.71%)
:arrow_down:

java-21
61.80% <100.00%> (+0.17%)
:arrow_up:

skip-bytebuffers-false
61.77% <100.00%> (+0.03%)
:arrow_up:

skip-bytebuffers-true
61.78% <100.00%> (+34.05%)
:arrow_up:

temurin
61.80% <100.00%> (+0.05%)
:arrow_up:

unittests
61.79% <100.00%> (+0.05%)
:arrow_up:

unittests1
46.02% <ø> (-0.87%)
:arrow_down:

unittests2
27.84% <100.00%> (+0.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove "Album" from path

I use the <IP_ADDRESS> version.
For album download the program let me set 2 options:

Path: I set "F:\Music"
AlbumFolderFormat: I set "{ArtistName}/({AlbumYear}) - {AlbumTitle}"

All works as expected but one thing: there appears also the "Album" folder that I don't want.
For example, the last album I downloaded is:
F:\Music\Album\Floating Points\2015 - Elaenia
but I want this:
F:\Music\Floating Points\2015 - Elaenia
Is this possible?

1 here. Just wondered why the 'Album' folder is being added.

I would like the same change

I also DON'T want the Album folder! Would like to use only the specified download folder with no additional folders added for Albums, Videos, or Audio. Additional folders are a useful option but there is no need to make them mandatory. Sometimes the simplest options are the best and just what we need. Much thanks.

@johnnyboy1950 This is a GitHub 'feature' when no-one interacts on an issue anymore. Unfortunately, it has nothing to do with the actual state of it.


np from getPositionOnTopOf can be null and causes crash

This section of monitorMovement
https://github.com/Karang/mineflayer-pathfinder/blob/0aaee90102c7cbc030aa3a1ec350608eae0b8d53/index.js#L214-L220
can result in np being null, even after the 'if null' check and assignment on line 216.
It seems to be fixed by moving the use of np further down to here:
https://github.com/Karang/mineflayer-pathfinder/blob/0aaee90102c7cbc030aa3a1ec350608eae0b8d53/index.js#L270-L274
presumably because the instances where np is null is only true for the digging or placement sections (I think specifically the issue is with air blocks). Happy to put in a PR but want to check I'm on the right lines before I make any changes

Did you encounter cases where this happen to be null ? It shouldn't happen as it would mean the block bellow a target position is non physical (air) and that should be impossible according to the movement generation rules.

Yes, only when the bot was trying to go up. It only happens when the bot has blocks to place in its inventory.
The simplest setup using the test.js example is this:
[pf]
[x]
[x] [bf]

x = dirt block
pf = player feet
bf = bot feet
Where the bot has a few dirt blocks in its inventory

Indeed. The fix you suggested was also the correct one (commited)

Great, thanks. Have you tested that fix when you're the opposite side of a river from the bot, so it has to swim to you? I applied that fix locally but was still getting it occasionally crashing and it seemed like swimming was the link between them. I'll try and repro tomorrow if you're not seeing it.

Great, thanks. Have you tested that fix when you're the opposite side of a river from the bot, so it has to swim to you? I applied that fix locally but was still getting it occasionally crashing and it seemed like swimming was the link between them. I'll try and repro tomorrow if you're not seeing it.
Edit: definitely still happens on some occasions. It's when the bot is swimming or just about to swim I think.

Should be solved in 1.0.9


Add fromLonLat and toLonLat convenience functions

I like it a lot! IMO: please merge.
Thanks @ahocevar

I think the docs for the functions should specify/clarify that this is WGS84 lonlat


No information that account has been created while using OpenID Connect

Gitea version (or commit ref): 1.9.5
Git version: 2.16.5
Operating system: CentOS Linux release 7.5
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
While creating a new account with the Open ID Connect there is no information that the account has been created.
Prerequisite: I do not have an account on gitea
Steps to reproduce:

I use the "Sign in with Open ID Connect" option and log in with my Open ID Connect authentication server
I get two options now - to register a new account or to link to an existing account, I choose the first one. I fill-up the form (user name, email, password and captcha) and click Complete Account
I am redirected without any message to the login page, however, if I click once again "Sign in with Open ID Connect" I am able to log in.

Expected result: After clicking "Complete Account" the user should get at least a flash message that the account has been successfully created.

Issue also in version 1.10.0

I have same issue with any oAuth2 service (facebook,discord,twitter, etc) but after I press login again will log me in.


SPIKE: auro-drawer: scoped scrolling

Is your feature request related to a problem? Please describe.
When a drawer needs to scroll we can have a situation where there are two scroll bars side by side.  When the drawer is open though a user really only wants to scroll the drawer content, not the entire page.
Describe the solution you'd like
We can fix this by adding overflow: hidden to the body when a drawer is in an open state and then remove that line when the drawer is closed.  We can likely do something similar in auro-dialog
Describe alternatives you've considered
Hide a scroll bar with css but that isn't well supported accross browsers.
Additional context
This is related to the fix we did on #17

Questions to answer with this SPIKE:

What is a real world scenario where the page being a drawer (or dialog) would want to be scrolled?
In what cases do we expect the scroll bar to appear?
Determine if we want to do this in Dialog or Drawer (IE, the two scroll bars right next to each other case)


Update email templates and invitation flow

This work is already started, so opening an issue to track it.
I deployed the tileo-rebrand/email-templates branch to production and saw the following:

So three things I can spot on this one email (haven't tested the others):

[x] The invitation view still has the old copy in English.
[x] We're still missing some strings (that live elsewhere?)
[x] The logo seems to be borked as well (saw it was linked as http://http://tileo-mailing-assets.s3.amazonaws.com= /tileo-logo.png in the message source)
[ ] The invitation link 404s (goes to https://smartrural.tileo.co/user/smartrural/signup?email=jjmata%40tileo.co&invitation_token=be69172f0b48ff2d7a0d9426bc9c6edcd56c40f5)

Email source, not that it helps too much:
Delivered-To<EMAIL_ADDRESS>Received: by <IP_ADDRESS> with SMTP id j88csp468098ooe;
        Wed, 12 Jul 2017 00:09:35 -0700 (PDT)
X-Received: by <IP_ADDRESS> with SMTP id y64mr4249987qkb.246.1499843375566;
        Wed, 12 Jul 2017 00:09:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1499843375; cv=none;
        d=google.com; s=arc-20160816;
        b=MwhJivLiRX0Y59Eo7vPwasn8tfXwx1LO6lqcEZKL7RIIgmTxXfIgCK9k9ty4vIg8kL
         lSr9JAVALKujKWKStfv9wIGbC9Uio5L8tWOWyq4gtfh9i/vwBi7OWbOQuxw0AyM2dGiO
         8TPAX3txm4avVWr3LSff05HZhPpCyDCHJ9GPN0vjz5RhmdF47l0Tag2dnvndtyYp2KQc
         18rYDaZuZCZuc/u9j5oeLc3K6wGli1osGDjsiebejxqb5Dx/JpDknZBO5CICOBAnkNRu
         36XnWkLqjdkIXKaf6YL14Jqg4uKoBvMjtAHoyn/sfw4To5yYxui+RuLrZcww9PMHbKtX
         EaYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:subject:message-id:to:from
         :date:sender:domainkey-signature:dkim-signature
         :arc-authentication-results;
        bh=qOnCWrnMevUv8qiCQEashcRx/yLtWE028U9iJq5aY9E=;
        b=J/R3MBwUHQPuKkTWQWkN4yVAKggFP3/m9G/R60j5ECd4/K2ebCHB63dwMMb7Bpdr65
         c6S802sOToAPRYUknRNWlSpexrWXsmGKlz3qhIVVtASH9dMbTA7B7ge1ZpSy4Iz7PEXJ
         1ajV5SL7oEros4PqEfKXSBm3J5aCeijoey9vmIj1dpWlbrWb79V5uuSX5RpzuZb+AKVY
         sVLLRPx8WYjM62Ql5BFpoKVOPMqIdHmb3nPa/6wSD5Kr6noUcl/YzvXIHnRZcokvysEH
         iYedXtSrev3W7IJXnbrzvI6Ywg5v/4+H2FpsmJNQM92+8nkJWh+IooqH+T0Oe51fLjoO
         18hg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass<EMAIL_ADDRESS>header.b=vf5MZ3Wl;
       spf=pass (google.com: domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>Return-Path<EMAIL_ADDRESS>Received: from mail-s71.mailgun.info (mail-s71.mailgun.info. [<IP_ADDRESS>])
        by mx.google.com with UTF8SMTPS id l2si1529708qkd.274.2<IP_ADDRESS>.09.35
        for<EMAIL_ADDRESS>        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 12 Jul 2017 00:09:35 -0700 (PDT)
Received-SPF: pass (google.com: domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS>;
Authentication-Results: mx.google.com;
       dkim=pass<EMAIL_ADDRESS>header.b=vf5MZ3Wl;
       spf=pass (google.com: domain of<EMAIL_ADDRESS>designates <IP_ADDRESS> as permitted sender<EMAIL_ADDRESS>DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=beta.tileo.co; q=dns/txt;
 s=smtp; t=1499843375; h=Content-Transfer-Encoding: Content-Type:
 Mime-Version: Subject: Message-ID: To: From: Date: Sender;
 bh=qOnCWrnMevUv8qiCQEashcRx/yLtWE028U9iJq5aY9E=; b=vf5MZ3WlkLM694//WQfjn8IwsyC09ooqbUwabKFwK0XCoiUK04pg454NNptWlNhzOClIy9or
 B/w2DpZsaQZEyb7Ymzz4VlGdjji7W3ySYTvOSvR//HfzyynCGclSG1kJ73JFpNEcq7JkzeQY
 sx7K6KNbGvHK7crxPX8Q8UvdkLM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=beta.tileo.co; s=smtp;
 q=dns; h=Sender: Date: From: To: Message-ID: Subject: Mime-Version:
 Content-Type: Content-Transfer-Encoding;
 b=OzAQ1XQa7tPfT7JQU6w98mYH2dnx8B6b+my6a6E33NfExBPK0EQYY+jGkcy0HFwi6jdFH5
 CVx6sI+ng2qPEzwG3P0ZqoSt1ZZEnmmcuwzvLIU/O8Nb+ITHKsnKp+LiygKQK7oUB0Vou9uM
 EgLqbWa8n80K9d+CxngVL6k3acoxE=
Sender<EMAIL_ADDRESS>X-Mailgun-Sending-Ip: <IP_ADDRESS>
X-Mailgun-Sid: WyI4NDc5OSIsICJqam1hdGFAdGlsZW8uY28iLCAiZDkzY2M1Il0=
Received: from localhost.localdomain (3.bc.32a9.ip4.static.sl-reverse.com [<IP_ADDRESS>])
 by mxa.mailgun.org with ESMTP id 5965cb2d.7fbe9811b030-smtp-out-n03;
 Wed, 12 Jul 2017 07:09:33 -0000 (UTC)
Date: Wed, 12 Jul 2017 07:09:32 +0000
From: Tileo Support<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>Subject: You are invited to join the smartrural organization at CARTO
Mime-Version: 1.0
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

  <title>You are invited to join the smartrural organization at CARTO </t=
itle>

  <meta charset=3D"utf-8">
  <meta name=3D"viewport" content=3D"width=3Ddevice-width">

=

                  <im=
g alt=3D"Logo" src=3D"http://http://tileo-mailing-assets.s3.amazonaws.com=
/tileo-logo.png" width=3D"82" height=3D"32" style=3D"display: block;" bor=
der=3D"0">

=

You are invited to join the smartrural orga=
nization at CARTO

=C2=A1Hola y bienvenido/a!

=C3=9Anete a la organizaci=C3=B3n smartrural en Tileo. Es tan senc=
illo como crear tu cuen=
ta.

Aqu=C3=AD tienes un mensaje personalizado por el/la administrador/=
a de la organizaci=C3=B3n:

I'd like to invite you to my CARTO organization,

Best regards

=C2=A1Hasta pronto!

=

=

                  =C2=A9 2017 Tileo, Inc.

The invitation link to login is broken due to conflicts with the subdomains configuration. We must fix that first in order to generate the proper urls.

I see you checked most of the boxes above, @MariaCheca (this is all in https://github.com/splashblot/dronedb/commit/a178196a39350e05c957a5df95a4411a98157db2 right?)
Let's go ahead and deploy those yourself! 💪

I hear this got deployed today, update please @MariaCheca?

Yes! Closing Issue.

Did the last task in the list get addressed as well?  I think we decided to remove the invitation flow for now until we have deployed in subdomain mode, right?
If not just rename this issue and open a new one to track the remaining bits.

Yes, I hid the button to invite users until the feature flow is restored again :)

OK, I saw that in today's deploy! 👍
Can you split that out into a new issue then, @MariaCheca?