HADOOP-19194:Add test to find unshaded dependencies in the aws sdk

Description of PR
How was this patch tested?
Local testing via test.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 12s

trunk passed

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 22s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 23s

trunk passed

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

trunk passed

+1 :green_heart:
shadedclient
19m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 11s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 44 new + 0 unchanged - 0 fixed = 44 total (was 0)

+1 :green_heart:
mvnsite
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 10s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

the patch passed

+1 :green_heart:
shadedclient
19m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  5s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

86m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6865

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux e959c18d9692 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aef7e84849b52092854f53d3de19e3b40257b24a

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/1/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran @mukund-thakur can I get a review on this? There are currently 4362 unshaded classes as per the test, the number reduces to 13 when we migrate to 2.25.53

There are currently 4362 unshaded classes as per the test, the number reduces to 13 when we migrate to 2.25.53

Have you added a comment in an older SDK issue or created a new issue?

@mukund-thakur created this: https://github.com/aws/aws-sdk-java-v2/issues/5275

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 54s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 21s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 28s

trunk passed

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

trunk passed

+1 :green_heart:
shadedclient
20m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 16s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 42 new + 0 unchanged - 0 fixed = 42 total (was 0)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 10s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 40s

the patch passed

+1 :green_heart:
shadedclient
20m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 22s

The patch does not generate ASF License warnings.

82m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6865

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 2d86e936257a 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d84dbd49db52a879e8df9b7810ca5d2a9e6e54f5

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/2/testReport/

Max. process+thread count
551 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 51s

trunk passed

+1 :green_heart:
compile
0m 26s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 18s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 24s

trunk passed

+1 :green_heart:
javadoc
0m 16s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 19s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 42s

trunk passed

+1 :green_heart:
shadedclient
20m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 18s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 12s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 11s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

the patch passed

+1 :green_heart:
shadedclient
19m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  9s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

81m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6865

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux 39b0a4741559 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ccd405f9862ff68b77c9ee1fd478f22e02a8d725

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/3/testReport/

Max. process+thread count
554 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 12s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m  8s

trunk passed

+1 :green_heart:
shadedclient
34m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m  7s

the patch passed

+1 :green_heart:
shadedclient
33m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 55s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

126m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6865

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux addbaa08a354 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ccd405f9862ff68b77c9ee1fd478f22e02a8d725

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/4/testReport/

Max. process+thread count
551 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran can you review this?

yetus will do the checksyle auditing, once it is happy I'll review it again

yes see the checkstyle error from yetus as well.
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/sdk/TestAWSV2SDK.java:36:/**: First sentence should end with a period. [JavadocStyle]

this https://github.com/aws/aws-sdk-java-v2/blob/master/test/bundle-shading-tests/src/test/java/software/amazon/awssdk/bundle/BundleShadedCorrectlyTest.java looks a good test. maybe we can just pull this out our code.

@mukund-thakur would you like a copy of the test in the aws sdk in our code base?

@HarshitGupta11 , I'm ready to merge, but checkstyle is still unhappy.
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/sdk/TestAWSV2SDK.java:36:/**: First sentence should end with a period. [JavadocStyle]
some versions of javadoc fail when the doc isn't a complete sentence, so do fix this.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 52s

trunk passed

+1 :green_heart:
compile
0m 25s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 19s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 19s

trunk passed

+1 :green_heart:
mvnsite
0m 25s

trunk passed

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

trunk passed

+1 :green_heart:
shadedclient
20m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 20s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
javadoc
0m 10s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 43s

the patch passed

+1 :green_heart:
shadedclient
19m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 14s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 21s

The patch does not generate ASF License warnings.

88m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6865

Optional Tests
dupname asflicense mvnsite codespell detsecrets markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle

uname
Linux cfdbb543f8b1 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4a06710aa8127df9b5b0143051b3c4dfbdd4d599

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/5/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6865/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Checkstyle fixes done.

Can some one merge this?


[provisioning] enable benchtop SIVAL cert endorsement with Nitrokeys

The DICE CA key may be stored on a Nitrokey, which can be used in a benchtop provisioning flow to endorse DICE certificates. This enables such flows by simply setting an envar (PKCS11_MODULE_PATH) and plugging in a Nitrokey to the host machine.

nit: You may have to add the keys/sival data dependencies to orchestrator if you are planning to use it without bazel.

Ah right, fixed. Thanks.


Functional test discovery fails on build

Fails both locally and on the CI. From http://aspnetci/viewLog.html?buildId=387311&buildTypeId=Lite_Identity&tab=buildLog&_focus=407#_state=407:
[Step 4/6] [xUnit.net 00:00:00.2707368] Exception discovering tests from Microsoft.AspnetCore.Identity.Service.FunctionalTests: System.BadImageFormatException: Could not load file or assembly 'Microsoft.AspnetCore.Identity.Service.FunctionalTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. An attempt was made to load a program with an incorrect format.
[13:07:57]	[Step 4/6] File name: 'Microsoft.AspnetCore.Identity.Service.FunctionalTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
[13:07:57]	[Step 4/6] at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, IntPtr ptrLoadContextBinder)
[13:07:57]	[Step 4/6] at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, IntPtr ptrLoadContextBinder)
[13:07:57]	[Step 4/6] at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
[13:07:57]	[Step 4/6] at Xunit.Sdk.ReflectionAssemblyInfo..ctor(String assemblyFileName) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Reflection\ReflectionAssemblyInfo.cs:line 31
[13:07:57]	[Step 4/6] --- End of stack trace from previous location where exception was thrown ---
[13:07:57]	[Step 4/6] at Xunit.AppDomainManager_NoAppDomain.CreateObject[TObject](AssemblyName assemblyName, String typeName, Object[] args) in C:\Dev\xunit\xunit\src\xunit.runner.utility\AppDomain\AppDomainMan

This is done I believe. Closing as no further action is required.


Could not find codec parameters for stream 0 (Video: h264, none): unspecified size

Hi
I have recently dusted off an old Bebop 1 drone, intending to use it for a deep learning computer vision project.
However, I've stumbled at the first hurdle as I cannot get either demoBebopVision.py or demoBebopVisionGUI.py to work.
I am running on Ubuntu 18.04 and indoors only (at the moment).  When running the first programme I get the console output below this message.
Is there any more info needed to help resolve this issue?  I have tried playing with 'analyzeduration' and 'probesize' options as suggested, but  with no success.
Thanks in advance
Steven
Opening ffmpeg
ffmpeg -protocol_whitelist "file,rtp,udp" -i /home/steven/drone/pyparrot/pyparrot/utils/bebop.sdp -r 30 image_%03d.png &
starting vision thread
Opening non-blocking readers
ffmpeg version 3.4.4-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2018 the FFmpeg developers
built with gcc 7 (Ubuntu 7.3.0-16ubuntu3)
configuration: --prefix=/usr --extra-version=0ubuntu<IP_ADDRESS> --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --enable-gpl --disable-stripping --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-librsvg --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-libdc1394 --enable-libdrm --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libopencv --enable-libx264 --enable-shared
libavutil      55. 78.100 / 55. 78.100
libavcodec     57.107.100 / 57.107.100
libavformat    57. 83.100 / 57. 83.100
libavdevice    57. 10.100 / 57. 10.100
libavfilter     6.107.100 /  6.107.100
libavresample   3.  7.  0 /  3.  7.  0
libswscale      4.  8.100 /  4.  8.100
libswresample   2.  9.100 /  2.  9.100
libpostproc    54.  7.100 / 54.  7.100
[sdp @ 0x55e079854460] Could not find codec parameters for stream 0 (Video: h264, none): unspecified size
Consider increasing the value for the 'analyzeduration' and 'probesize' options
Input #0, sdp, from '/home/steven/drone/pyparrot/pyparrot/utils/bebop.sdp':
Duration: N/A, bitrate: N/A
Stream #0:0: Video: h264, none, 90k tbr, 90k tbn, 180k tbc

Output #0, image2, to 'image_%03d.png':
Output file #0 does not contain any stream
Having trouble connecting to the camera 1.  A reboot of the mambo may help.

Sorry to get behind. This is pretty odd.  Did you try it more than once?  I don't have a bebop 1 but the times I have had access to one, the vision stream has worked fine.  I have a bebop 2 and it isn't having issues.

Hi Amy
I think that the problem might be in the bebop drone rather than pyparrot.
I installed your code onto a Mac laptop and had the same error accessing the video stream.
In both cases I can control the flight of the drone, so the code is actually connecting and interacting correctly.
Unfortunately not being able to access the video stream rather stymies my plan to teach the drone to play hide and seek!
Steven
PS I’m not sure it is relevant but I do get a lot of messages about the need to handle low latency data.
Sent from my iPhone

On 15 Nov 2018, at 02:59, amymcgovern<EMAIL_ADDRESS>wrote:
Sorry to get behind. This is pretty odd. Did you try it more than once? I don't have a bebop 1 but the times I have had access to one, the vision stream has worked fine. I have a bebop 2 and it isn't having issues.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have the same problem with Anafi4k. I can't see the video. @stevenhedges did you solve the problem?


Fix regex string termination with escaped slash

bug introduced in #7 caused regex with escaped slash \/ to be split up.
example : https://github.com/ZirakZaheer/Senior-Year-Project/blob/6a51ac439ca2f5327407418c24d76cd743d44476/rules-master/email/urls.yar

LGTM


Limit resource exhaustion attack CVE-2018-6389

Limiting requests to wp-admin/load-scripts.php and wp-admin/load-styles.php could be used to easily prevent the resource exhaustion attack CVE-2018-6389 https://baraktawily.blogspot.fr/2018/02/how-to-dos-29-of-world-wide-websites.html
See #959

Hello @RavanH,
after reading several articles about this CVE and running some tests with nginx configuration, the easiest way to fix this security issue is probably to deny access to load-styles.php & load-scripts.php  :
location ~* "^/wp-admin/(load-styles|load-scripts)\\.php" { deny all; }

I haven't noticed any error with this nginx configuration

@VirtuBox , there's something wrong. Your code just blocks the specified scripts that are needed to load styles and scripts in WordPress Dashboard.

It broke my WordPress Dashboard.

Plesk WP-Toolkit must also be forcing WordPress to not use load-styles and load-scripts on the admin side. In that case, yes those could be blocked completely. But without such a plugin, these endpoints are used in the admin (about 3 times per page request) hence this proposal to limit their access...
Another approach might be to only allow access when a logged_in cookie is present.

@RavanH @janiosarmento, I have found the explanation about this fix.
It require to add the following line in your wp-config.php file :
define('CONCATENATE_SCRIPTS', false);

It will disable scripts & css concatenation, usually performed by load-scripts.php and load-styles.php. This way, we don't need them anymore and we can directly deny access to those files with nginx.
With HTTP/2, it make sense to disable scripts & css concatenation.

Another approach might be to only allow access when a logged_in cookie is present.

The scripts are used on wp-login.php, thus the cookie check is kinda inefficient.
But @VirtuBox found the way to make the magic happen. :)

The scripts are used on wp-login.php, thus the cookie check is kinda inefficient.
Ah yes, you're right...

Closing this https://github.com/EasyEngine/easyengine/pull/959#issuecomment-410223101


Add normalize.scss as dependency

This PR adds normalize.scss as dependency and imports the partial at the top of base_styles.scss.

looks good! i think just a couple more updates to comments and I'm good with it!

@robwierzbowski and @victorwhy update comment in the file. let me know what you think https://github.com/CasperSleep/nightshade-core/pull/147/commits/c50c215f280169ba43f35c568b9814df92a93a00

DTM!

Thank you!


vision_opencv: 1.12.5-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository vision_opencv to 1.12.5-0:

upstream repository: https://github.com/ros-perception/vision_opencv.git
release repository: https://github.com/ros-gbp/vision_opencv-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.1
previous version for package: 1.12.4-0

cv_bridge
* add version_gte for opencv3
  @vrabaud If you'll update opencv3 version as discussed in https://discourse.ros.org/t/opencv-3-3/2674/4, I think we'd better to add 'version_gte' tag so that apt-get install ros-kinetic-cv-bridge also pulls openv3.3 from repository, to avoid API breaking issue between opencv2 and opencv3.
* Simplify the dependency components of cv_bridge
  Fixes #183 <https://github.com/ros-perception/vision_opencv/issues/183>
* Fixes #177 <https://github.com/ros-perception/vision_opencv/issues/177>
  The Python bridge was wrong on OpenCV2 with mono8 (and any Mat
  with only two dimensions btw). Took the official Python bridge
  from OpenCV.
* Add missing test file
  This fixes #171 <https://github.com/ros-perception/vision_opencv/issues/171>
* Properly deal with alpha in image compression.
  That fixes #169 <https://github.com/ros-perception/vision_opencv/issues/169>
* Silence warnings about un-used variables
* export OpenCV variables
* Contributors: Kei Okada, Victor Lamoine, Vincent Rabaud

image_geometry
* Fix compilation issues.
  Fix suggested by #173 <https://github.com/ros-perception/vision_opencv/issues/173> comment
* Make sure to initialize the distorted_image Mat.
  Otherwise, valgrind throws errors about accessing uninitialized
  memory.
  Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>* Remove the last remnants of boost from image_geometry.
  All of its functionality can be had from std:: in C++11, so
  use that instead.  This also requires us to add the -std=c++11
  flag.
  Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>* Contributors: Chris Lalancette, Vincent Rabaud

vision_opencv

No changes

Holding...


v02 Integration Test

An integration test to run list of input YAML files for v02. The same process can be replicated for v03. This builds off of the capability added in PR #419. Run pytest within python_routing_v02 to execute all tests. This test can also be added as an integration test on a GitHub PR.
Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

I think I will actually do a short refactoring of this late Thursday or Friday to break up the list of input YAML files to individual pytests, so that it is more clear whenever one fails.

I think I will actually do a short refactoring of this late Thursday or Friday to break up the list of input YAML files to individual pytests, so that it is more clear whenever one fails.

That sounds like a good idea. We would want to know that.

@jameshalgren Tests are updated and ready to go.


Handle changes to comparison parsing in Julia 0.5. Fixes #36

Reran CI with the new CoinOptServices release. Seems like things are failing just because https://github.com/JuliaOpt/CoinOptServices.jl/pull/17 isn't merged yet. Should be safe to merge and tag this, no?

Yes, it should be good to go

I thought we'd be ok now, but there's a weird homebrew failure on OS X: https://travis-ci.org/JuliaOpt/AmplNLWriter.jl/jobs/130608677#L265
CC @tkelman @staticfloat

Mmm, looks like I have to update some formulae for new syntax.

Retry now?

Thanks @staticfloat. I'm still getting a similar error.
Also Cbc decided to compile itself instead of using homebrew:
Error: Formulae found in multiple taps:
 * staticfloat/juliadeps/cbc
 * staticfloat/juliatranslated/cbc
Please use the fully-qualified name e.g. staticfloat/juliadeps/cbc to refer the formula.
Error: Formulae found in multiple taps:
 * staticfloat/juliadeps/cbc
 * staticfloat/juliatranslated/cbc

Thanks Miles, this is great feedback.  I've pushed a fix in https://github.com/JuliaLang/Homebrew.jl/commit/25c098a39f382741b2a83852443c1e9f143c3f53, I'll tag a new version of Homebrew.jl soon, and then ask you to retry this.

Good catch Miles, the cbc thing was happening because I wasn't fully specifying the path to libgfortran within the fixup_libgfortran postinstall step.  This has been fixed in https://github.com/staticfloat/homebrew-juliadeps/commit/80b59264b3c6e91cf3118024ccc33dff60845907

We have green. Thanks @staticfloat!

Definitely time to tag this


Checking for free disk space

Currently, the method Mist uses to get the amount of free disk space returns the same value as df or diskutil, which is a lower number than what's reported elsewhere in the OS.
In my testing it wouldn't download the installer on my own machine because it said I only had 34 GB free, when elsewhere macOS reported 143 GB available. Based on Apple's documentation you might want to look into querying against volumeAvailableCapacityForImportantUsageKey - that's what Graham Pugh's erase-install.sh uses starting with version 25 and it seems to work well, although that method of running JavaScript via osascript returns 0 if no user is signed in so it falls back on df if that happens. I'm guessing you might not have that problem in Swift though!

Thanks for bringing this to my attention - the current logic to calculate free space was hacked together quickly and can definitely be improved!
Please bear with me as I look into this and report back 🙏

@anewhouse thanks for the suggestion, this has been implemented in #128


Wanna Add Tip Calculator Project in JS

Tip Calculator will tell how much to tip in Hotels.

I want to on this issue #907,Please assign me this


New Animations

What was done?

Added: 18 new animations

Why?
As noted on issue #69 Apple published a video with new animations on their jobs.apple.com website, so I added them to Brooklyn as single animations.
Screenshots
These are the 18 new animations that I added:

Cuphead2 animation is slightly different from the one that's already in Brooklyn, so I kept them both.

Can we get this merged?

+1 would love if this got released

How to release

Can we get this merged, @pedrommcarrasco?

I'm sorry, I have this on my backlog for ages and never actually managed to review it. I'll do it today.

@arendruni can you please give me write access to your fork? I'd like to do some changes before merging it.

@arendruni can you please give me write access to your fork? I'd like to do some changes before merging it.

Done

Looks good to me 👍

@pedrommcarrasco, thanks for merging this!
I think that issue #69 should be closed now.


Run mypy in CI

Description
Provide a brief description of the PR's purpose here.
Todos
Notable points that this PR has either accomplished or will accomplish.

[ ] TODO 1

Questions

[ ] Question1

Status

[ ] Ready to go

Codecov Report

Merging #14 (b1e2034) into main (a16c87c) will increase coverage by 0.09%.
The diff coverage is 85.71%.

Additional details and impacted files


Draft/adoring smoke

same

Sorry @De-Ash, these are large changes without much information as to why. Closing for now.

I totally understand bro, I mistakenly made these pulls to your repo, i meant to make it to a diff repo


Segmentation fault when using offset in binlog parser

Hi!
I'm experimenting with the binlog parser and used it for some binlog files I from a test db. When using the parser together with an offset that passes by a table map event, I can get a segmentation fault:
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xd963d]
goroutine 10 [running]:
panic(0x22bac0, 0xc4200100f0)
/usr/local/Cellar/go@1.7/1.7.5/libexec/src/runtime/panic.go:500 +0x1a1
testing.tRunner.func1(0xc42008c6c0)
/usr/local/Cellar/go@1.7/1.7.5/libexec/src/testing/testing.go:579 +0x25d
panic(0x22bac0, 0xc4200100f0)
/usr/local/Cellar/go@1.7/1.7.5/libexec/src/runtime/panic.go:458 +0x243
github.com/siddontang/go-mysql/replication.(*BinlogParser).parseEvent(0xc42004be40, 0xc42000daa0, 0xc420127200, 0x24, 0x600, 0x24, 0x0, 0x0, 0x0)
/Users/max/Documents/.../binlog-parser/_vendor/src/github.com/siddontang/go-mysql/replication/parser.go:155 +0x4ed
github.com/siddontang/go-mysql/replication.(*BinlogParser).parseReader(0xc42004be40, 0x379fc0, 0xc42002e2c0, 0xc42000d980, 0x0, 0x0)
/Users/max/Documents/.../binlog-parser/_vendor/src/github.com/siddontang/go-mysql/replication/parser.go:103 +0x25f
github.com/siddontang/go-mysql/replication.(*BinlogParser).ParseFile(0xc42004be40, 0x2719dd, 0x19, 0x1ac, 0xc42000d980, 0x0, 0x0)
/Users/max/Documents/.../binlog-parser/_vendor/src/github.com/siddontang/go-mysql/replication/parser.go:59 +0x398
See the attached binlog that produces the issue, with offset being 428
mysql-bin.000005.zip

Hi @maxbeutel
This is caused that we don't parse the first FormatDescriptionEvent. So if we begin to parse the binlog file with a offset, we must first parse the FormatDescriptionEvent at first, then use the offset.

I will think how to fix it later.
Btw, it is very appreciated that you can send me a PR to fix too.

Can I ask you what is the purpose of the offset? Is it the actual byte offset inside the binlog file? I first thought it's the offset of the event, but that is nit the case.

Hi @maxbeutel
At first, I wanted to let the binlog parser work like mysqlbinlog, the parser may support start position (the byte offset), or start timestamp.
But I have no time to support it, so now the offset is needless because we only support parsing the binlog from start.

@siddontang  I see. Do you think it would be ok to remove the offset then? I think I could work on a PR for that, if you are ok with it to merge.

@maxbeutel  welcome :-)

this issue need close? @siddontang


Adds equal_sum schema test

Adds a schema test macro to test whether two columns sum up to the same total.
For example, this can be helpful in auditing transaction level fact tables vs their aggregate fact tables.

(Integration tested on Snowflake)

Hey @clausherther, cool macro! Have you seen expression_is_true? I think you could implement this test (for some use cases anyway) using the more general form of this test.
I think this is a totally reasonable test, but I also am thinking hard about what kinds of macros belong in dbt-utils. We definitely need better rules as to what can live in here and what should live in some other package. I'm very open to discussing this, but my instinct is that this is a pretty specific test, and it might be better suited for some other repo. I'd totally recommend that you create your own repo of tests if you find that you have a critical mass of these macros that you share across projects!
So, very happy to chat. Let me know if you have any questions!

I thought about that, but does expression_is_true work against another model? The use case I've run into quite a bit is having an order and an order line item table, and needing to make totals match up. Does that make sense? Are these too specific for the utils package?

Yeah, you're right that expression_is_true won't work in that use case. The orders/orders_items example is a good one.... i think i've just been convinced :)
I can kick off the CI build for this PR in a moment. Will also drop some comments in the code

Thx for the feedback! I also incorporated that into the equal_rowcount schema test macro.

@drewbanin actually, thought about this a bit over the holidays and I think I'll close this PR in favor of a more generalized version that likely would also replace the equal_rowcount schema test you merged the other day. I'll submit that today or tomorrow. Not sure how you deal with deprecations here, but it's likely no one other than me used this one anyway.


Release v0.0.13

Add Provision Type and Reason for error cluster
Review Comments
Fixed lint and reverted wrong line
idp: Warn the user that it will take about 1 minute to add IdP
aws: Add support for AWS profiles
logs: Improve warnings when cluster is pending
Adding validations to cluster create command
remove validations from create command
aws: Split configuration to ensure early failure

/test lint


Widen filepath bounds.

Does anyone know why the lower bound was bumped here? Causes a fair few problems with wai etc.. around things locked to 1.3.* (as well as most of our upstream depending on 1.3.*)?

Not sure

@tmcgilchrist ^

No specific reason, just bumped it cause 1.3 seemed pretty old.
Can't see wai depending on filepath directly or at least no in the hackage page.
You'll probably need to change the range in mismi-core-test.cabal too, sorry.

:+1: on :green_book:.


Properly pass config object.

We do pass the config object so we can use it for things like proxy or
SSL verification when doing requests. In a call to
doArtifactoryRequest it was not properly passed so the settings were
not used in one of the error case handlers.
This patch fixes the call to doArtifactoryRequest.

Any progress on merging this pull request? It's from July of last year..

@huerlisi, please use the bower-art-resolver Github repository instead. The Artifactory resolver for Bower is is built from that repository. This old legacy repository will be soon removed.

Has been fixed in the other repository, so this is not needed anymore.


Filter out false positive PyTorch scheduler warning

Filters out a false positive warning for PyTorch's scheduler.
Fixes #1561

Thanks @awaelchli ! I simplified this now and it seems to work!


In the example, there is a picture of the day, and it is possible

What problem does this feature solve?
The current bubble pie chart can only render the bubbles first, then convert the coordinates, and then render the pie chart. If you switch the pie chart legend, you have to re-render twice. The performance is very poor, and there is a method of rendering once.
What does the proposed API look like?
Provide corresponding solutions or examples

"current bubble pie chart" = ???

"current bubble pie chart" = ???

Scatter chart

Target

The Target picture you provided does not seem to be ECharts, and there is no code.  Therefore I do not understand your question.
Here is a Demo Code made with ECharts.

Thank you so much, It is indeed the effect I want, amazing,It seems wrong for me to set up like this before, I will learn.
Another 2 questions to ask:

Click on the legend, the position of the pie chart changes dynamically with the total amount of the legend. How to do it.
Hovering the mouse on the pie chart will prompt the whole pie chart instead of a sector in the pie chart.

sorry, do not understand the question
tooltip showing data on all pie sectors is possible:

tooltip: {formatter: (p) => {
  ttip = '';
  pieSeries[p.seriesIndex-1].data.map((d) => { ttip += d.name+' '+d.value+'<br>'; })
  return ttip;
}},

I'm very sorry, my statement is very unclear, which caused you some trouble.
For 1:
Suppose there are 3 legends, the sum is 100, and the corresponding coordinate axis is (60,100). Now cancel a legend, the sum is 80, and the corresponding coordinate axis position should be (60,100).

For 2:
The pie chart replaces the fan-shaped area of a certain legend, triggers the tooltip, and then highlights the entire pie chart.

ok, now I understand (1) and think it is doable:

capture legendselected
recalculate scatterData according to the new totals - this will reposition scatter
recalculate pieSeries = scatterData.map(...) -  this will reposition all pies
setOption with new data to refresh chart

About (2) "highlights the entire pie chart", I do not know how, but single pie-sector highlight could be disabled with emphasis.disabled: true.

Thank you very much, your answer is very serious and reliable, kind people will be very happy.

@helgasoft
Teacher, may I ask you another question?
Gradient+stack+stack touch how to make rounded corners, the effect is as follows.

see borderRadius, -> Demo Code

see borderRadius, -> Demo Code

@helgasoft
It is a little difficult to mark in the picture

This could be done with thick line series instead of bars.

Can the teacher give me a specific case?

Dear student, when are you going to write some code?

Yes,the students are stupid, please advise me.
I tried to use the thick line series and found that there is a transformation of the original data. (Offset), I have not found a reliable law yet.

ok, let see your code and fix it.

ok, let see your code and fix it.

This is what I roughly understand. It is not necessarily a good solution to adapt the difference between the line graph and the column in the later stage.
https://codesandbox.io/s/mzsz2q?file=/index.js

Here is one solution, but it is fixed size, not responsive. - Demo Code.

@helgasoft
Teacher, how to make this kind of 3D pie chart does not require animation and rotation, just click on the legend, and the corresponding legend will bulge, and the height of the bulge is a fixed value.

Someone did it already.  Great examples at makeapie.cn.

@helgasoft  I tried，
The actual result is that the arc width at close distance is very wide, and the arc width at long distance is very narrow. How to adjust it is close to the above rendering.

With the settings： viewControl.projection='orthographic',
the effect is somewhat similar, but a bit more aliased and with shadows on the side
@helgasoft

Add shading: 'color', after type: 'surface',  or play with grid3D.light.

Setting shading: 'color' ,The three-dimensional feeling is relatively poor

yes, 3D is bland without lighting.
Leave the lighting and try distance: 1333 - the dark shadows will disappear.


Browser Compatibility

This issue is to give information on problems that come from using the different browsers, and their compatibility. This compatibility chart uses the latest version of each browser.
Fully working
Google Chrome (and other browsers based on Chromium)

As this is the browser we have done most of the programming on, it is guaranteed to be 100% compatible with the app.

Mozilla Firefox

This browser should also be 100% compatible with the app, and we will try to ensure changes or new features also work on this browser.

Safari

I don't really know how well this works since I dont have a Mac to test it on, maybe @ThePerkinrex can test it.

Partially working
Microsoft Edge

The basic Hermes features work on this browser (you can read and send messages), but there are some UI bugs / differences from the other browsers, and therefore using this browser is not recommended.

The website scrolls to the top every time you send a message
The right click menu doesn't work
The loading icon looks strange:

Not working at all
Internet Explorer

As this is a very old browser, it does not support some of the JS functions (such as ES6) used in the app. Please use a different browser.

Yeah, I will test it on safari

Yeah, I will test it on safari

We should add Opera & test its compatibility

We should add Opera & test its compatibility

Opera is based on Chromium, so I think the results will be similar to Chrome.

@spaceface777 I didn't know that

In safari, the page takes a lot to load, the loading icon dissapears, the order of the messages is wrong, and sw-register errors out:
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'reg.pushManager.getSubscription') (sw-register.js:23)

Then it gives a lot of errors about requests it's making (getSettings/...) (500)
So then JSON Parser crashes on line 321 of chat.js

Since Safari compatibility has been fixed, it is now one of the fully working browsers.

I also tested UC Browser, and it works mostly OK, apart from the strange Edge loading icon and the browser overriding the right click menu with their own.

Most of the Edge issues have been fixed.

Making Edge compatible isn't very important as the browser is in the process of being rebased on Chromium, and will therefore work exactly the same as Chrome.

Has Edge been ported to chromium on main branch yet?
Because if so, then Edge is fully supported


Moving just the contents up from directory

I was wondering if there is a way that I can move just the contents one (or more) levels up from a directory.
For example:
| main folder
| – – 1.jpg
| – – subfolder
| – – | – – 2.jpg
In this instance I would like to move 2.jpg into the main folder so it would become:
| main folder
| – – 1.jpg
| – – 2.jpg
| – – subfolder
Is this possible? Thanks

You can use the transform rule to strip the subfolder path component.


FW default PWM_RATE 50

There is potentially a much larger issue here, but this should help in the meantime.

closes https://github.com/PX4/Firmware/issues/7490

See: https://github.com/PX4/Firmware/issues/7261
FYI @davids5

Quick question - Does rc.fw_defaults execute before the values get applied from rc.interface?

Yes


rename Sphinx documentation directory

Change from doc (singular) to the more common docs (plural).

@mrakitin What integrations need to be adjusted for this change?

Good.  We'll drive on as planned.


bt_id_create() address is written to flash

Describe the bug
According to bt_id_create() documentation:

The identity will also not be written to flash in case a pre-defined address is provided, since in such a situation the app clearly has some place it got the address from and will be able to repeat the procedure on every power cycle, i.e. it would be redundant to also store the information in flash.

If I call bt_id_create() with a hard-coded random static address, it seems to be written to flash. This is confirmed by resetting the device, after which the hard-coded address is already there.
Following the bt_id_create() to https://github.com/zephyrproject-rtos/zephyr/blob/535c40d6d69caa302da3cc7dba4ed255c34aea94/subsys/bluetooth/host/id.c#L1328
It doesn't seem like there's any logic to skip writing to flash if the address is specified explicitly.
Assuming I'm interpreting the documentation correctly, it's not clear whether this is a case of inaccurate documentation or missing functionality.
To Reproduce
The following code is used to create a second identity (index 1) after BT is initialized. Project has CONFIG_BT_ID_MAX=2.
bt_addr_le_t addr = {
	.type = BT_ADDR_LE_RANDOM,
	.a.val = {0, 1, 2, 3, 4, 5},
};
BT_ADDR_SET_STATIC(&addr.a);
int profile = bt_id_create(&addr, NULL);
if (profile < 0) {
	LOG_ERR("failed to create profile (err %d)", profile);
	return profile;
}
LOG_INF("default profile %d created", profile);

Expected behavior
I expect the second identity slot to be vacant on boot.
Impact
I have to call bt_id_get() and manually delete the second identity first.

Upon further investigation, it seems like the identities stored in settings are ignored if I call bt_id_create() prior to bt_enable() (essentially setting BT_ID_DEFAULT explicitly). This allows me to subsequently create identity 1 with bt_id_create() without deleting anything.
However even though the bt/id settings isn't read when I do this, it's still updated each time I make a change.


Allow huggingface model's from_pretrained kwargs in the model-setting.json?

from transformers import LlamaForCausalLM, AutoTokenizer, TextGenerationPipeline

model = LlamaForCausalLM.from_pretrained("daryl149/llama-2-7b-hf",load_in_8bit=True)
tokenizer = AutoTokenizer.from_pretrained("daryl149/llama-2-7b-hf")
pipeline = TextGenerationPipeline(model, tokenizer)
pipeline("Once upon a time,", max_new_tokens=100)

Recent popular LLM like llama-2 takes tons of memory. However, with quantization its memory requirement greatly reduce.
Huggingface allow me to convert llama-2 into quantized 8bit version by simply add an keyword argument  load_in_8bit=True
Whish we can specify from_pretrained_kwargs in the model-setting.json
example model-setting.json :
{
    "name": "llama_mlserver",
    "implementation": "mlserver_huggingface.HuggingFaceRuntime",
    "parameters": {
        "extra": {
            "task": "text-generation",
            "pretrained_model": "distilgpt2",
            "from_pretrained_kwargs":{"load_in_8bit":true}
        }
    }
}

Hi, @adriangonz. I just created a PR for this issue.
https://github.com/SeldonIO/MLServer/pull/1417


Exception: Target class [hash] does not exist

Hi,
Thanks for creating this plugin, I believe it's very useful!
One thing I discovered is when I add this callback for the authorize() method an Exception is thrown:
        ->authorize(
            fn () => auth()->user()->hasRole('super_admin')
        ),

This is the Exception:

Any clues on why this is happening?

The install is using plain "stable" Filament with a couple of plugins enabled.

For now I've solved the issue by creating a custom page that extends Saade\FilamentLaravelLog\Pages\ViewLog and use the Trait provided by Shield like so:
use HasPageShield;

To hide the default, built-in, page the plugin is configured like so in the PanelProvider:
                FilamentLaravelLogPlugin::make()
                    ->navigationGroup('Logs')
                    ->navigationLabel('Application Logs')
                    ->navigationIcon('heroicon-o-bug-ant')
                    ->navigationSort(1)
                    ->slug('application_logs')
                    ->authorize(
                        fn () => false // hides the built-in page
                    ),

exactly same problem for me too

Im also facing the same issue.

Same issue here as well.

#38


Devel 54 no message

added the You are using Wi4MPI info output when running MPI_Init and MPI_Init_thread in c and fortran
fixes issue #54

merged in 22b0180210799ec95a3f21812dd46e8febce89f9


chore: update lerna to latest version

[FX-NNNN]
Description
Update Lerna to the latest version to remove cricital vulnerability
We bump one minor version, where support for pnpm workspaces was added (release notes) and it should not affect us at all
We had to fixate the version of Typescript to not be updated unexpectedly. Typescript is not following common semver and even minor bums can have breaking changes, we will need separate PR to update TS.
How to test

CI should be green

Development checks

Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
Annotate all props in component with documentation
Create examples for component
Ensure that deployed demo has expected results and good examples
Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers


Consider adding postcss-flexbugs-fixes

What do you think about that guys ?
https://github.com/luisrudge/postcss-flexbugs-fixes
Would be nice to have it ?

For now it's ok since it only fix bug8, but some workarounds (bug3) may add rules and potentially can override user's rules.

We might enhance this plugin so it add warnings about those potential collisions.
poke @luisrudge

and let the user select which bug the want to fix

Oh! I forgot about that. I still have to publish the plugin to npm, but I'd like to add more rules before doing so.

I'm just seeing this plugin for the first time, and I already see some problems with it. I filed https://github.com/luisrudge/postcss-flexbugs-fixes/issues/18 and https://github.com/luisrudge/postcss-flexbugs-fixes/issues/19.
Assuming these are fixed I think it'd be OK to add, but my concern is it might make users think they don't have to worry about these issues at all anymore, when in fact many of them can only be solved in HTML-land.
Also, some of them (e.g. 7) won't be able to catch all cases, arguably most cases even. Consider this example:
* {
  box-sizing: border-box;
}

.box {
  flex: 1 1 50%;
  padding: 1em;
}

cssnext cannot always know what elements have their box model set to border-box.

Yeah @philipwalton. I thought about that too. Most of the stuff are too context dependent, so you need to check html to see if that'll happen or not. One thing we discussed in an issue, is to emit warnings about other bugs, but I don't like that idea either.

Good points guys.
Warnings can help at least https://github.com/luisrudge/postcss-flexbugs-fixes/issues/17

I don't think it's a good idea anymore.


The method validate was called on null

I/SurfaceView(16837): updateWindow -- setFrame, this = io.flutter.embedding.android.FlutterSurfaceView{205ab00 V.E...... ......I. 0,0-720,1206}
I/SurfaceView(16837): updateWindow -- setFrame, this = io.flutter.embedding.android.FlutterSurfaceView{205ab00 V.E...... ......I. 0,0-720,1206}
E/flutter (16837): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: NoSuchMethodError: The method 'validate' was called on null.
E/flutter (16837): Receiver: null
E/flutter (16837): Tried calling: validate()
E/flutter (16837): #0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
E/flutter (16837): #1      _SignUpState.build. (package:i2i_tradehood/Screens/Authentication/sign_up.dart:121:48)
E/flutter (16837): #2      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
E/flutter (16837): #3      _InkResponseState.build. (package:flutter/src/material/ink_well.dart:789:36)
E/flutter (16837): #4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
E/flutter (16837): #5      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
E/flutter (16837): #6      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
E/flutter (16837): #7      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:236:7)
E/flutter (16837): #8      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:156:27)
E/flutter (16837): #9      GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:222:20)
E/flutter (16837): #10     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:198:22)
E/flutter (16837): #11     GestureBinding._handlePointerEvent (package:flutter/src/gestures/binding.dart:156:7)
E/flutter (16837): #12     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:102:7)
E/flutter (16837): #13     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:86:7)
E/flutter (16837): #14     _rootRunUnary (dart:async/zone.dart:1138:13)
E/flutter (16837): #15     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
E/flutter (16837): #16     _CustomZone.runUnaryGuarded (dart:async/zone.dart:933:7)
E/flutter (16837): #17     _invoke1 (dart:ui/hooks.dart:273:10)
E/flutter (16837): #18     _dispatchPointerDataPacket (dart:ui/hooks.dart:182:5)
E/flutter (16837):

This is a bug in your code, see the stack trace that points directly to i2i_tradehood/Screens/Authentication/sign_up.dart:
E/flutter (16837): #1 _SignUpState.build. (package:i2i_tradehood/Screens/Authentication/sign_up.dart:121:48)
Questions like these are better suited for Q&A sites like StackOverflow or on one of the flutter community sites at https://flutter.dev/community


Pype: Frozen code improvements

Intro
There were major roadblocks to make frozen pype to work, biggest of them was that .zip archive doesn't actually work as parts (like avalon-core) read files from there, not just import them.
Changes:

Pype entry point was renamed from pype.py to start.py to avoid confusion with pype module and with similar philosophy as setup.py, build.ps1 etc.
Build now produce two executables - pype.exe - Win32 GUI application that has no console attached and pype_console.exe that has console and print out stuff to it.
Running process has now available PYPE_EXECUTABLE environment variable pointing to either pype.exe or pype_console.exe or python in venv when run from live sources.
Pype will now install itself as directory in user data dir. It will search for zips and directories to find out latest version.
Zips produced from detected sources will exclude stuff like .git files and other unnecessary things under Pype repository.
Introducing tools scripts in tools:

create_env - this will clean and (re)create virtual environment in ./venv based on requirements.txt
build - this will clean builld directory and build pype there. You can find ./build/build.log with latest output.
create_zip - this will create pype zip from currently running sources. When run with --path option, it will create zip in specified directory, otherwise it will put it directly to user data dir where Igniter will find it.
make_docs - update sphinx api documentation sources and build html documentation in ./docs/build
run_mongo - not implemented
run_settings - run settings UI in dev mode
run_tests - run pytest
run_tray - run tray

Moved acre and pyblish-base to virtual environment and those are deleted from submodules. See below for more info.
Adding run command to pype, accepting one argument - script path and passing rest as arguments to it.
Added --use-staging option to prefer staging over production version. Specifying it will use latest staging available.
When two Pype version are detected - one is zip file and one in directory - directory will take precedence.
Minor bug fixes.

Run command:
run command allow to run scripts by Pype in its environment. Simple use:
pype_console.exe run /path/to/script.py -o1 --option2 arg1 arg2

This will run /path/to/script.py in Pype context and pass it options and arguments in sys.argv
Using it in conjunction with PYPE_EXECUTABLE environment variable from within code:
import os
import subprocess

result = subprocess.run(
    [os.getenv("PYPE_EXECUTABLE"), "run", "/path/to/script", "some", "arguments"])

Git info:
As acre and pyblish-base are removed from submodules, there are few steps necessary in existing repositories. You can either clone again, or follow these steps:

Delete acre and pyblish-base sections from .gitmodules file
Stage .gitmodules - git add .gitmodules
Delete acre and pyblish-base sections from./.git/config
Run:

git rm --cached .\repos\acre
git rm --cached .\repos\pyblish-base

Commit changes
Delete submodule directories

Caveats:
There is still one thing preventing running of frozen code and that is google_api_python_client. To make it work:

build pype with ./tools/build.ps1
copy ./venv/Lib/site-packages/google_api_python_client-x.xx.x.dist-info to build/exe.win-amd64-3.7/lib

🏴  Warning: it is implementing #849 and #850

after succesfull venv installation we still have build issues. This was a fresh clone and it looks like build expects build folder to already exist

after succesfull venv installation we still have build issues. This was a fresh clone and it looks like build expects build folder to already exist

after succesfull venv installation we still have build issues. This was a fresh clone and it looks like build expects build folder to already exist

I always thought we have build directory in repository but we don't. Added checks for that and it will be created when missing.

after succesfull venv installation we still have build issues. This was a fresh clone and it looks like build expects build folder to already exist

I always thought we have build directory in repository but we don't. Added checks for that and it will be created when missing.

Damn it, running frozen code still gives me this. Any idea @iLLiCiTiT ?
... running: C:\Users\annatar\AppData\Local\pypeclub\pype\pype-v3.0.0\pype\pype\modules\ftrack/ftrack_server/sub_user_server.py 10021
!!! Pype crashed:
Traceback (most recent call last):
  File "start.py", line 458, in boot
    cli.main(obj={}, prog_name="pype")
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "C:/Users/annatar/AppData/Local/pypeclub/pype/pype-v3.0.0/pype\pype\cli.py", line 297, in run
    runpy.run_path(script, run_name="__main__", )
  File "C:\Python37\lib\runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "C:\Python37\lib\runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "C:\Python37\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\annatar\AppData\Local\pypeclub\pype\pype-v3.0.0\pype\pype\modules\ftrack/ftrack_server/sub_user_server.py", line 5, in <module>
    from ftrack_server import FtrackServer
ModuleNotFoundError: No module named 'ftrack_server'

Damn it, running frozen code still gives me this. Any idea @iLLiCiTiT ?
... running: C:\Users\annatar\AppData\Local\pypeclub\pype\pype-v3.0.0\pype\pype\modules\ftrack/ftrack_server/sub_user_server.py 10021
!!! Pype crashed:
Traceback (most recent call last):
  File "start.py", line 458, in boot
    cli.main(obj={}, prog_name="pype")
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "E:\projects\pype\pype-3\venv\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "C:/Users/annatar/AppData/Local/pypeclub/pype/pype-v3.0.0/pype\pype\cli.py", line 297, in run
    runpy.run_path(script, run_name="__main__", )
  File "C:\Python37\lib\runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "C:\Python37\lib\runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "C:\Python37\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\annatar\AppData\Local\pypeclub\pype\pype-v3.0.0\pype\pype\modules\ftrack/ftrack_server/sub_user_server.py", line 5, in <module>
    from ftrack_server import FtrackServer
ModuleNotFoundError: No module named 'ftrack_server'

Seems like it didn't add directory of the script to sys path (which worked when I tested it). ftrack_server is python file next to the sub_user_server.py script. I can take a look tomorrow.

Seems like it didn't add directory of the script to sys path (which worked when I tested it). ftrack_server is python file next to the sub_user_server.py script. I can take a look tomorrow.

@antirotor changed from ftrack_server import FtrackServer to from pype.modules.ftrack.ftrack_server.ftrack_server import FtrackServer so it works now

@antirotor changed from ftrack_server import FtrackServer to from pype.modules.ftrack.ftrack_server.ftrack_server import FtrackServer so it works now

❕ IMPORTANT: PYPE_MODULE_ROOT is gone. Use PYPE_REPOS_ROOT to point to where acre, avalon-core, etc. resides.

❕ IMPORTANT: PYPE_MODULE_ROOT is gone. Use PYPE_REPOS_ROOT to point to where acre, avalon-core, etc. resides.


client: add ObserveOptions.errorHook

This introduces a new option when calling an observable method on the client. It allows a caller to collect errors on the underlying providers.
Currently the client implementation when encountering an error in a provider will log it and then swallow it unbeknownst to the client. This is reasonable behaviour since we don't want one bad provider causing all of OpenCtx to fail. For example if the methods where to throw errors you wouldn't be able to collect the working provider results.
As an alternative I considered updating the return type of the client to either return the underlying type or an error. This ended up being quite a large change and didn't feel like it justified it for the extra burden it imposed on each call site. However, I can go that route so that each client explicitly handles errors.
Test Plan: the unit test was updated to ensure errorHook is not called for the happy path, and is called for the erroring provider. Additionally because we now no longer call console.error the unit test output is much cleaner when all tests pass.

For the path I didn't take (updating the return type) these are the two possible type definitions I considered:
export type AggregatedArray<T extends unknown[]> = ((
    | (T extends readonly (infer ElementType)[] ? ElementType : never)
    | { error: any }
) & {
    providerUri: string
})[]

// or

export type ProviderResult<T> =
    | {
          type: 'success'
          result: T
          providerUri: string
      }
    | {
          type: 'error'
          error: any
          providerUri: string
      }


Special History - Edit Work Modal - Team Lead

Describe the bug
Jad couldn't add Brennan Hutchison as a new Lead.
To Reproduce
Steps to reproduce the behavior:

Go to edit work modal
Click on team lead lock button
add a new entry
See error

Expected behavior
I should be able to add a new Special History Team Lead, and if I can't, I should see an error message that explains why
Screenshots

Additional context
lindsey luke (the previous lead) was from: today to: today, brennan was also added today. could it be a 0 day duration problem?

Issue happens when we try to add new entry, with from date as last entry's from date + 1 day. Effectively making last entry's time range as a single day. Is this a valid use case?

@salabh-aot I talked to @EAO-App-Admin . The above mentioned scenario will never occur. So we can show an error message if someone chooses to add another entry with the very next day.

@dinesh-aot any suggestions on what error message to show? If we need to show below the input field, we only have limited space and only a small message can be shown, like, Invalid from date. Another option is to mark the datefield as error (red border) and show an error notification. What are your thoughts?

@maria-kuzmenko any suggestion for the error message.

@dinesh-aot , proposed verbiage
The selected date range must span at least one day. Please ensure that the 'from' and 'to' dates are different to proceed
link to prototype - https://www.figma.com/file/XcYynwH7xrO2P30uqewaLS/For-Development?type=design&node-id=81-1432&mode=design

@Connor1892 we discussed this and we decided to meat further on it with @maria-kuzmenko.
The issue isn't just when a user doesn't match the to and from dates but when they add a new entry with a from date that is directly after (1 day +) the last entries from date.
How should we handle that is the question

this ticket is linked to this https://app.zenhub.com/workspaces/epictrack-63891ea941d309001fa292cf/issues/gh/bcgov/epic.track/2153


Implement human-readable durations in the config

Description
Enhance HumanDuration type to actually parse a human-readable string:
https://github.com/hyperledger/iroha/blob/964476722e2a219becaacdb3676ca058ec5748cd/config/base/src/lib.rs#L23-L27
Specification
Here is an excerpt from the configuration reference draft:

Duration is specified as a human-readable string:
value1 = "1sec"
value2 = "1hour 12min 5s"
value3 = "2years 2min 12us"
value4 = "550ms"

The duration string is a concatenation of time spans. Each time span is an
integer number and a suffix. Supported suffixes:

nsec, ns — nanoseconds
usec, us — microseconds
msec, ms — milliseconds
seconds, second, sec, s
minutes, minute, min, m
hours, hour, hr, h
days, day, d
weeks, week, w
months, month, M — defined as $30.44$ days
years, year, y — defined as $365.25$ days

I used humantime crate for reference. Maybe it can be used as is. Otherwise, it is straighforward (and quite interesting!) to write our own parser with something like winnow.

as discussed here I'm not sure we want to complicate config files. Simple fixed suffix on the field name should suffice IMO. We need to discuss this before proceeding

There was a discussion in favor of human-readable strings here:

https://github.com/hyperledger/iroha-2-docs/issues/392


[Model Support][SWA] Add support for sliding window attention for Mistral

This PR introduces support for Mistral with the sliding window attention (SWA) mechanism, tracked by issue #1003.
The implementation follows the Mistral paper, specifically including SWA, rolling buffer cache, and chunking, as discussed in Section 2 in the paper.
Some implications of SWA
With SWA, we do not need to "shift" or truncate the input when dealing with long context, which reduces output quality. For instance, the implementation of this PR discards the usage of max_window_size. Besides, by using chunking, we can reduce the peak memory usage in runtime.
Future work

SWA support for other models. Currently, only mistral is supported, and it might be interesting to see how SWA performs in other models.
Batching support. Currently, SWA only supports single sequences.
Attention sink. Some other interesting mechanisms similar to the SWA can also be explored (e.g. Efficient Streaming Language Models with Attention Sinks)

Potential Issue: Redundant shape variables
As shown in the code, we introduced two more shapes as input to encoding and decoding functions, namely cache_len (the number of elements in the cache) and kv_seq_len (cache_len + seq_len).
That is, we calculate these shapes in runtime (i.e. in llm_chat.cc) rather than in mistral.py. While we could easily deduce these variables, we introduce them separately because we found out that if a tensor's shape depends on two variables (say te.min(all_seq_len - seq_len, sliding_window), which is the exact way to calculate cache_len), TVM would complain during compile time.
Any thoughts and suggestions on this would be greatly appreciated.
Potential Issue: squeeze
Somewhat along the line to the previous issue, as shown here, we could not use tvm.relax.op.squeeze but have to use te.compute(), probably resulting in performance degradation.
Prerequisite support from TVM Unity

https://github.com/apache/tvm/pull/15963

Currently, we can only append to the KV cache. This PR introduces overwriting, which is required for implementing the rolling buffer cache.

Co-authored-by: @davidpissarra

Sliding window for a batched model is supported in https://github.com/mlc-ai/mlc-llm/pull/1134.

please fix the lint error

One high-level note, we are in the process of migrating into a more systematic handling of model definitions, see https://github.com/mlc-ai/mlc-llm/tree/main/python/mlc_chat/compiler/model as an example.
This is still WIP so compilation flow is not yet completed, we should switch over as soon as it lands, and it is good to start preparing fro this one


State machine error messages aren't received by RPC client

When a transaction fails in the ABCI state machine, its error message is not being properly passed through to Tendermint RPC clients. This is either an issue in the ABCI server or the RPC client.

Just checked and it looks like we are setting the log messages in the info field of the ABCI response in orga::abci::ABCIStateMachine, but we try to display the log field in the client: https://github.com/nomic-io/nomic/blob/develop/src/chain/client/client.rs#L84-L87.
Should probably change orga to use log instead of info.


Adopt lower-case-with-hyphen file naming convention

Rename all files so they adhere to naming convention:

all letters lowercase
words separated by a hyphen -

For example:
Breadcrumb.js -> breadcrumb.js
MarkdownRegion.js -> markdown-region.js

[ ] #19
[ ] #20
[ ] https://github.com/nenkan/ui/issues/21

Can you assign this issue to me?

@Niravprajapati1 this issue aggregates multiple subtasks. How about you do https://github.com/nenkan/ui/issues/19 ?

Sure 😃


Update namespaces

update session namespaces  in onSessionUpdateNamespacesRequest
@MisterVants any particular reason why it was commented out?

update session namespaces in onSessionUpdateNamespacesRequest
@MisterVants any particular reason why it was commented out?

I did it while changing the validation methods, I think it was re-enabled in my open PR.


run js code and send response back to model

This change adds a run button which executes javascript and pastes return value into a reply to bot.

Here is a sample tool made this way:

This is a pretty sick feature when combined with websockets. Attached sample convo.
websocket-chatcraft.html.zip
Used websocat exposed via cloudflare to connect to my computer
websocat  -E ws-listen:<IP_ADDRESS>:8810 sh-c:'TERM=v100 bash -i 2>&1' --binary
cloudflared tunnel --url localhost:8810
Currently i force-feed js output back into model.
Thoughts:

I think output should probably go into input box instead, not sure.
Model could potentially write JS to go into infinite feedback loop and take over the world :)

you are my linux shell assistant.

When i ask for a command you will output just the code

// <reasoning behind command>
runCMDOverWebSocket("<command>")

and nothing else.
I will run command for you and tell you response.
2. when you hear the response you will render it as a mermaid diagram with valid syntax

write async javascript function(cmd) that connects to wss://folders-brochure-duty-teachers.trycloudflare.com or reuses pre-existing window.socket there and sends a message containing cmd+"\n", then buffers responses into a string for 2 seconds, returns that string.
prior to re-using window.socket, ensure it's connected.
attach function to window.runCMDOverWebSocket
console log JSON.stringify buffer right after adding to it

 websocat  -E ws-listen:<IP_ADDRESS>:8810 sh-c:'TERM=v100 bash -i' --text

you are my linux shell assistant.

When i ask for a command you will output just the code

// <reasoning behind command>
runCMDOverWebSocket("<command>")

and nothing else.
I will run command for you and tell you response.
2. when you hear the response you will render it as pretty inline html, possibly with svg,css,etc
....

Looks good. I don't know if we should pass onPrompt to <NewMessage />, since it's a streaming message that isn't yet complete, and will get converted to a Message once it is. However, making it optional there would require changing your types on onPrompt everywhere to be optional.

I can change it to optional, just say the word. It's awkward both ways :)

Captured some of the followups in https://github.com/tarasglek/chatcraft.org/issues/62

If you're OK doing it, I would recommend that onPrompt not get passed down to NewMessage, and that you make the type on all those props be onPrompt?: ... and deal with the function not existing when you call it:
const handleRun = async () => {
  if(typeof onPrompt !== 'function') {
    return;
  }
  ...

Actually, add it to your conditional rendering too:
{ (language == 'js' || language === 'javascript') && onPrompt && <IconButton .../> }


In WFS : Is it possible to specify the PropertyName when making a GetFeature request?

I want to know if there is a way to select specific properties from a feature type in a GetFeature request. Can I include a PropertyName parameter to control which fields are returned in the response? If so, could you provide an example of how to structure the request to achieve this?

This was done in #80, let me know if that works for you!


Enhanced: Simplify the CEL policy to disallow host ports

Related Issue(s)
fixes #1093
Description
This PR simplify the CEL expression by removing the repeated terms.
Checklist

[] I have read the policy contribution guidelines.
[] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

cc @JimBugwadia

Yes, you need to recalculate the digest of the policy and update the relevant section in the AH metadata file.

Tests failing.

Can there be different digest values for same policy?

If you generate the digest on WIndows versus Linux, yes. The difference in digests come from control characters and line endings. The digests should be generated under Linux or else CI will fail.

Still getting the different digest value from the value given in  artifacthub-pkg.yaml of the file
OS used : Debian
version : 12

Ran it in a Code Space, I get the expected digest.

Thank you @chipzoller  for the guidance, now I will quickly update the artifacthub file.

Closed this pr in favor of #1108


Fetching Pull Requests Failed..."undefined" cannot be set for field q (code: invalid)

Extension version: 0.17.0
VSCode Version: 1.47.0-insider
OS: Windows 10

Steps to Reproduce:

Sign in to GitHub via the extension
Open a local repo for https://github.com/microsoft/TypeScript
Wait for Pull Requests to populate in the extension.
Expand the Created By Me node
No items are returned and the following error is shown in VS Code:

A few notes:

Pull Requests under the All category seem to be working fine.
Issues seems to be working fine.
All repos in the microsoft org now require additional, periodic "single-sign-on" authentication with Microsoft.
Due to some errors related to compression from git when using SSH, I have my remotes set up as follows:> git remote -v
origin  https://github.com/microsoft/TypeScript.git (fetch)
origin  git@github.com:microsoft/TypeScript.git (push)

I've worked around the issue following the same instructions in the wiki here: https://github.com/microsoft/vscode-pull-request-github/wiki#personal-access-token-authentication and enabling the token for SSO.
If the above cannot be fixed directly, it would be helpful to update the wiki and possibly improve the error message to indicate where to find more information.

There have been many changes in auth in the last year. Closing, but please comment if the issue is still occurring.


Adding Iceland and Botswana

Facebook pages and Twitter accounts. Botswana also has a WhatsApp group but not sure if that is wise to post.

Thanks @Stalfur just merged it!  I renamed a few of the resources so that they have English text in the name.  These will be pushed to Transifex for local translation.


Future proof Tables expression parser

According to https://github.com/dotnet/runtime/issues/47231 , we may need to do some work to future proof our expression parser implementation in Tables.
Although we do not implement IQueryable directly, we're still using reflection and comparing against argument count in a couple of places like here though.  Might be worth being more explicit or adding unit tests in case someone ever puts new overloads in .NET Core vNextNextNext.

@christothes do you still see value in making this change?


Print extracted words in the highlight colour in the terminal

If this turns out to be working, we can go ahead and replace colorma with it.


Lesson Redesign

I've not been happy with the current state of the lesson UI for a while now, and although it works, I feel there's a lot of room for improvement. I have seen the new redesign and I feel it doesn't address most of the issues here. The choice of typography in the redesign is worrying, but I don't think this is the place to discuss that issue.
Please note: These designs aren't a final product. Syntax highlighting was chosen at random. Accessibility has not been fully tested.
Link to the designs

Light Mode
Dark Mode

https://ibb.co/6vjKLYY
https://ibb.co/NmRtT7z

Reasoning
Below is an in-depth review of the choices I've made, and why they would benefit the end-user.
Separate the lesson header
First, the text has been aligned to the left to give consistency. Often, lesson names will overflow and you'll have one word in the middle of the screen. Left-aligned text is easier to read. These, along with the increased spacing, will reinforce what lesson the user is on. The course you're on is not as important as the lesson name, so they have been separated and given the appropriate hierarchy.
Increase spacing
Text that almost touches the side of your monitor (which is usually black, increasing contrast and text blur) makes it harder to read. Here, the lesson description has increased whitespace to account for this issue.
Button placement
The key takeaway here is that the 'Run tests' button has been put on his own. Right below it is the course checklist. This has been done for a few reasons:

It encourages users to try and complete the lesson themselves.
'Run tests' is the button you'll be clicking most of the time, so it makes sense its given more importance.
The rest of the buttons have been placed at the bottom, for the reasons above. They're also half-width with increased spacing between them. This makes it easier to read and navigate.

Course checklist
This section could still use much improvement, I'd rather treat it as a prototype. However, these are the main points I've tried to address:

Give a better indicator which points you have failed or passed.
Increase spacing for the icons, currently, they're making each point messy.
Although an X has been used, I think an exclamation mark would be better suited instead. An X usually indicates that you either want to close something or that you cannot enter.

Other
The rest of the design is rather self-explanatory, but it's been given a fresh look by cleaning up the elements and dividing the sections with clear borders. There are many unnecessary borders and visual noise in the current version.

@ahmadabdolsaheb Thoughts?

@ArcticPirate, thank you for submitting the mocks. they look very good.
We are aiming to replicate the feel of a code editor in an accessible way in next couple of UI sprints and that is the reason we are using monospace, large font, high contrast, large icons.
Our current UI can benefit from the improvements you mentioned such as spacing. We will make sure to review the lesson UI before deployment and take your suggestions into account.
@QuincyLarson thoughts?

@ahmadabdolsaheb
Monospace font
Although monospace fonts can help certain groups of people, for you majority of people it will decrease legibility. This isn't what monospace fonts were designed for. There are sans-serif fonts that have been specially designed for use in graphical user interfaces. Open Sans and Source Sans are to name a few, which offer beautiful clarity when reading.
Font size
Larger fonts mean fewer characters per line which can increase reading time and legibility. I can understand font size being an issue to some users, but for those who have increased the size in their browser settings, it means they will be receiving an even larger font.

These two issues are shifting the problem from one groups shoulders, and placing it in another. Having a setting where you can choose your own font size and typeface would be the best option to combat this.

I find monospace completely unreadable in large block of texts, I am totally unable to read posts on the forum if people put everything in backticks, I don't think I am the only one
please don't use monospace for challenge instructions @ahmadabdolsaheb

@ahmadabdolsaheb I have been closely observing the UI changes on the platform and I really appreciate your work on the chic man, just amazing! :)
I do feel we need to address some UX issues @ArcticPirate has pointed to. Btw @ArcticPirate those designs are bang-on <3. But we don't need to give a full UI refresh at this point.
Addressing the below two issues will make a very big impact in terms of UX:
1. font-family and hierarchy
The Roboto Mono font is unreadable when there is a large block of texts. It can be used in test output area but not in the descriptions. Font size, site layout, contrast, icons, colors are good.
In some places, I have observed that font hierarchy has been ignored:

2. Button placement
@ArcticPirate's button placement approach is what freeCodeCamp needs but with a slight change. We should place buttons in the same way @ArcticPirate has done but below the run tests button.
Also, get a hint and watch video buttons should be grouped under help.

@ahmadabdolsaheb I will be glad to work with you and help you in fixing these issues.

@vkWeb If there was a time to do a UI refresh, it's now. Unfortunately, the current site design really doesn't reflect the quality content on the site.
Why do you feel the other buttons should be below the run tests button? Or in other words, why do you feel they are more important than the lesson checklist?

If there was a time to do a UI refresh, it's now. Unfortunately, the current site design really doesn't reflect the quality content on the site.

@ArcticPirate The current theme and feel of a dark code editor is what we need for the upcoming project-based curriculum. Also, the current UI looks nice. We should improve upon that. Once we get confirmation from a senior team member, we will start working on improving the current UI design.

Why do you feel the other buttons should be below the run tests button? Or in other words, why do you feel they are more important than the lesson checklist?

When campers reach the algorithm section they use Get a hint button a lot to check if there can be a better implementation of the problem (that's what I used to do and I believe most of the campers do that too). So, we need to keep those buttons in front of their eyes. Also, the output test area shows the unpassed tests that's why I feel those buttons are more important than the checklist.

@vkWeb Without statistics, I wouldn't like to say anything about how useful the 'Get a hint' button would be in practice. I do know that it would be around 500 pixels down on the screen. Not a far way to go. Do you think the majority of campers use the get hint button, more than the lesson checklist?

@ArcticPirate No, you misunderstood my point friend 😅.
I was trying to say that the majority of clicking happens in the run test and get hint buttons so they should be placed in front of camper's eyes. Most of the challenges have more than 3 test cases so the description area overflows vertically. Now imagine, scrolling down again and again and then clicking buttons. Will it be a good user experience? For me, it's a big no.
So, in terms of placement and UX, the buttons are more important than the checklist. I hope you got my point now ;)

@vkWeb I'm confused, do you have stats for the point you made? If so that simplifies things

@ArcticPirate Some design decisions are made without stats. I am assuming average user behavior (90% users) and design according to that. We can improve for the rest of 10% in future iterations.
This is what my point is:

In terms of placement and UX, the buttons are more important than the checklist. So, buttons should be placed above the checklist area.

I am assuming average user behavior (90% users) and design according to that.

@vkWeb But what makes you think 90% of users expect this?  If you have some data to support your theory, you can throw out numbers.  Otherwise, it is just an opinion or personal preference.

as an user I think I would prefer to see the checklist
the buttons Get a Hint, Ask for Help and such are buttons I would press at
most once or twice, instead the checklist items I would need to have always
under eyes, I need to consult those often while writing the code. the most
I struggle with the challenge the most useful is to have the whole
checklist under eyes I would say

Thank you everyone for your feedback.
I would also like to hear from @QuincyLarson about the modifications he would rather have for this iteration.

I just joined and I'm new to coding etc, but since this topic is about buttons etc. Can we can we make the Run the Tests button fast key configurations customizable ?  Maybe it's just me but hitting control (ctrl) stretches out my pinky uncomfortably and since we will be doing this all the time during a lesson can we try to make it a little user friendly for our fingers? Idk I respect everything you guys are doing with this project as I'm learning HTML at the moment but it's a real pain at the moment. Thanks for taking my input!

@RandellDawson Yes, it's my personal opinion or thought you can say. But I firmly believe in that UI approach :)

@bogscode I'm curious, my keyboard has two CTRL buttons and one of them is below the enter key. Does yours not have that?

@ArcticPirate All keyboards do...I like to keep my fingers on fdsa jkl; so if anything can help where I don't have to move my hand as much would be more preferable. I'm 25 but I can imagine people who have Arthritis in their wrists etc it would be a benefit for as they could keep their hands in place  if they could map any key they want. Like I said it's just a suggestion but it would help make the site a little more user friendly. Maybe that could be an advanced setting feature.

Hey everyone - I'm a bit late to this conversation.
First of all, I enjoyed @ArcticPirate's proposed design.
Rather than try to redesign our old UI, I encourage you to wait until our new UI is ready, then make incremental tweaks to that.
Regarding monospace font VS proportional, proportional is indeed easier to read and we will be using it whenever we have more than a few words of text.


API guidelines doc

This is super in-progress. A lot of this information is sort of tribal knowledge, but I wanted to get it in out in the open and us on the same page.
This should give us somewhere to look when we're like "how should I name that method/event?", or "how do I doc a method that takes a callback that takes an options hash."

@benogle just looking at old PRs and came across this, it this something we want to :ship: or :snowflake: ?

It would be nice to eventually update it and ship it.

On Fri, Feb 20, 2015 at 3:35 PM, Ben Ogle<EMAIL_ADDRESS>wrote:

It would be nice to eventually update it and ship it.
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/pull/3142#issuecomment-75339256.

Ice

So icing means what?  I thought an issue could only be open or closed.
On Fri, Feb 20, 2015 at 4:42 PM, Ben Ogle<EMAIL_ADDRESS>wrote:

Ice
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/pull/3142#issuecomment-75345345.

Yeah, he was asking if we wanted to close it.

Sorry for an off-topic stupid question, but what does the snowflake mean?

the opposite of :ship: essentially

This still something we want to ship or should this be closed?

Ugh, maybe it doesnt matter now. Would be nice, but not a big deal.