refactor: extremum model unit tests

Full coverage

Hi, and thanks for contributing!
Note: If you are part of Qlik R&D, you can apply to the open-source team in our internal GitHub organization, and ignore the rest of these instructions.
Before we can handle your pull request we need you to sign our contributor license agreement.
This is a one-time process and enables you to contribute without hassle to any of the qlik-oss repositories in the future.
And it only takes a few minutes! Here are some useful links to get you started:

Sign the CLA
Rationale behind the CLA
Qlik R&D Open Source repository
Official Slack team

Having troubles? Feel free to reach out to us either here or on Slack!
Note: Once the CLA is sorted, you should rebase/touch this pull request to trigger an update of this CLA status.


CSRF verification

Hello.
How can I white list csrf for cloudflare proxy in the docker compose yaml?
I tried using the sub domain name but it still encounter the csrf verification error.
Thank you.

Hi
I resolved it
this should be the syntax
APP_DOMAIN=subdomain.domain.com


Missing permissions on Datacollection rules for Policy MI

What happened? Provide a clear and concise description of the bug, including deployment details.
I deployed ALZ-Bicep v0.18.0 with the default policy assignments. It created DCR's and a UMI in the management subscription. After deploying a VM in a Online subscription I get policy deployment errors.
The reason for this behaviour is that the DCR is in the platform management group while the policy assignment is on the landingzone management group. The managed identy from the landingzone group has no permissions for the datacollection rules in the management subscription. The same thing is happening for ChangeTracking and UMI assignments.
Please provide the correlation id associated with your error or bug.
c449650d-4e60-4919-a907-9db4811ac4a3
What was the expected outcome?
Creation of a DataCollectionRule Association between the Azure Monitor Agent and the DCR in the Management Subscription.
Relevant log output
The client 'app-id of policy MI' with object id '...' has permission to perform action 'Microsoft.Insights/dataCollectionRuleAssociations/write' on scope '/subscriptions/...onlinesubguid..../resourcegroups/vm-online/providers/Microsoft.Compute/virtualMachines/vm-online/providers/Microsoft.Insights/dataCollectionRuleAssociations/assoc-55mf2y3zlwzjc'; however, it does not have permission to perform action(s) 'Microsoft.Insights/dataCollectionRules/read' on the linked scope(s) '/subscriptions/...mgmt subscription.../resourceGroups/alz-mg-p-rg001/providers/Microsoft.Insights/dataCollectionRules/alz-ama-vmi-dcr' (respectively) or the linked scope(s) are invalid. (Code: LinkedAuthorizationFailed)

Check previous GitHub issues

[X] I have searched the issues for this item and found no duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

tagging @arjenhuitema for awareness and oversight on all things AMA.
Is there something missing from an RBAC role assignment perspective in ALZ Bicep @arjenhuitema that @oZakari can add?

It looks like the Managed Identity of the policy assignments within the Landing Zone scope lacks Reader and Managed Identity Operator permissions on the Platform, which are necessary to access the DCRs and assign the UAMI. I’ve put together a table that shows which permissions are needed for each policy assignment and shared that with @oZakari

we ran into the similar issue today and founds this thread. @arjenhuitema @oZakari could you share that table of permissions here if it hasn't been published elsewhere?

Hey @bgawale and @sandorhofman,
Sorry for the delay. This has been on my radar and something I will be working on hopefully fixing in the next couple of days.
Essentially, the managed identity of the assignment on the Landing Zone scope needs the following permissions:

Policy
Permissions
Scope for permissions

Change Tracking Arc/ Hybrid
Reader
Platform

Change Tracking VM
ReaderManagedIdentityOperator
Platform

Change Tracking VMSS
ReaderManagedIdentityOperator
Platform

MDfC Defender SQL AMA
ReaderManagedIdentityOperator
Platform

VM Monitoring Arc/ Hybrid
Reader
Platform

VM Monitoring VM
ReaderManagedIdentityOperator
Platform

VM Monitoring VMSS
ReaderManagedIdentityOperator
Platform


MVBE-8300: gargoyle gives 500

Reverted an import change, this will be released along with Django 1.9 instead.
This reverts https://github.com/vikingco/gargoyle/commit/9111b32e2ce1697a30f7f61818a78aaf5b9f6809

:shipit:


Implement free surfaces

The comment at https://github.com/edoddridge/MIM/blob/9adaded177146e50a9cea68b64bd5080cf13939b/MIM.f90#L306 deserves to be its own issue.
@edoddridge Care to comment?  What does this mean?  What work is needed to bring it about?

It should have been.
However, I'm pretty sure that https://github.com/edoddridge/MIM/commit/cf597928aa3e9137eb00bd8e4f935807271c7581 solved this problem - but the current test suite doesn't contain a simulation to test this assertion.
Essentially the model was putting too much energy into the barotropic mode (vertically homogeneous flow) and allowing the ocean surface to vary (having a free surface) meant that the model accumulated this error faster than when using a rigid lid (forcing the ocean surface to be flat at a prescribed height). I've disabled this warning in the regrid branch, and initial tests were positive, but I haven't properly tested the model with a free surface.


Cannot read property 'hasRoute' of undefined

Hello,
I just upgraded my app from Ember 2.12 to 2.16 and upgraded from ESA 1.3 to 1.4 and am now seeing the following error:
rollbar.js:18 TypeError: Cannot read property 'hasRoute' of undefined
    at routeHasBeenDefined (router.js:996)
    at findRouteSubstateName (router.js:958)
    at router.js:868
    at forEachRouteAbove (router.js:837)
    at error (router.js:853)
    at Router$1.triggerEvent (router.js:1036)
    at trigger (router.js:111)
    at Transition.trigger (router.js:645)
    at router.js:456
    at tryCatch (rsvp.js:411)

I'm using this recipe for securing routes by default.
It appears the issue is caused when the following line is called in the SecureDefaultRouteFactory referenced in the recipe:
AuthenticatedRouteMixin.apply(route);

Any suggestions?
Thank you!

The recipe you're linking to is not officially part of ESA and we don't endorse it (see https://github.com/simplabs/ember-simple-auth/issues/578 for details). That should probably made clearer on the Wiki page - I'll make a note.

Bummer! Given this is a common scenario, any chance an official method can be endorsed? Thank you!

That scenario should always be solvable by the much simpler route nesting approach where you simply nest all routes under a common parent that requires authentication. Why does that not work for you?

@marcoow thanks. I found what you were referring to and it was very simple to do. To be honest, I feel like the recipe confuses things a bit as it definitely overcomplicates the solution.


Add custom error types for timers and extension traits

Description
Adds error types that wrap errors with the timer, errors with a TryFuture or TryStream wrapped by the extension traits, and elapsed errors caused by failing to meet the required deadline (see #21).
Motivation and Context
This removes the From<io::Error> trait bound on the extension traits, allowing them to work with any error.
How Has This Been Tested?
Compiles/test suite updated to reflect changes.

Depending on the resolution of #14 we'll be able to do away with Error completely and remove the _timer functions from TimeoutError.

@rjsberry I'm not sure I'm following why it's desirable to introduce custom error types? Are you encountering any limitations?

Yes - the From<io:Error> bound on TryFuture/TryStream error types in the extension traits mentioned in #21 .
Other than adding an error type I don't see how else this can be done with the current traits.
If Delay/Interval were to panic (#14) instead of resolve to an io::Result then the Error type introduced in this PR isn't required. In this case, do Delay/Interval become Future/Stream instead of TryFuture/TryStream? And does this also apply to the extension traits?
In this case then no new error types are strictly required. But how do you represent a future/stream has timed out? An Option maybe?

Ooph, re-reading this I notice I totally misinterpreted what you were getting at. What you're saying makes a lot of sense!

In this case, do the extension traits now extend Future and Stream instead of TryFuture and TryStream?

Yeah, that was my thinking.

In general I quite like this PR, but as you said perhaps it would make sense to make the error condition panic instead. I'm kind of leaning towards that more as it seems like it would allow us to make the API a lot simpler. In runtime::time we're already doing this, and it's working out quite well for us!

In general I quite like this PR, but as you said perhaps it would make sense to make the error condition panic instead. I'm kind of leaning towards that more as it seems like it would allow us to make the API a lot simpler.

Yeah, I definitely agree. If we want to make the timer implementation panic then I think then I'll close this PR and open a new one with the extension trait for TryFuture changed to Future, and likewise for TryStream.
Is there a reason why you use io::Result in runtime::time::Timeout? I was thinking of using an Option where None would represent a timed out future.

Is there a reason why you use io::Result in runtime::time::Timeout

@rjsberry I was thinking a timeout represents a failure state. And std::error::Error generally works well with ? / can easily be mapped to Option, whereas going the other way around is a lot harder.


Enabling "Show history rates" will result Electrum-Firo crash.

Actual behavior
Enabling Show history rates will result in Electrum-Firo crash.
After the crash, clicking Preferences will result in crash.
Steps to reproduce

Click menu Tools > Preferences > Fiat
Select Fiat currency to USD
Show history rates (Ticked/Enabled)
It will result in Crash.
After the crash, running Electrum-Firo and then clicking Preferences again will result in crash.

In order to reset Electrum-Firo, I must delete all files in this directory:
C:\Users\%USERNAME%\AppData\Roaming\Electrum-FIRO
And then run Electrum-Firo again.
OS, Version

Windows 10 1809, 64-bit
Firo-Electrum-<IP_ADDRESS>-setup-win64.exe

Duplicate of #15, but please try the step in this comment: https://github.com/firoorg/electrum-firo/issues/15#issuecomment-1135547695

Fixed in #39


All changes for firmware 3.0.0

Todo:

[ ] substitutions for voice assistant
[ ] voice assistant for ESP32-S2/S3 mini
[ ] documentation
[ ] update docs theme

How to test?
substitutions:
  bme_address: "0x76"  # << formerly known as "bmex80_address"
  bme_update_interval: ""  # << formerly known as "bmex80_update_interval"

  # bme680_bsec_sample_rate: "lp"  # << remove this line as it is not supported anymore
  # bme680_bsec_temperature_offset: "0"  # << remove this line as it is not supported anymore

  co2_offset: "0"  # << add this line
  iaq_offset: "0"  # << add this line
  voc_offset: "0"  # << add this line

packages:
  remote_package:
    url: https://github.com/schluggi/AIOsense
    ref: v3 # << changed from main
    refresh: 1d
    files:
      # [...] other files
      # - esphome/packages/sensors/bme280.yaml  # << comment this line
      # - esphome/packages/sensors/bme680.yaml  # << comment this line
      # - esphome/packages/sensors/bme680_bsec.yaml  # << comment this line
      - esphome/packages/sensors/bme68x_bsec.yaml  # << add this line
      - esphome/packages/sensors/voice_assistant.yaml  # << ESP32-C3 mini only (for now), disconnect buzzer first
      # [...] other files

New features

BSEC support (#122)
GUI controlled offsets
Offsets for air quality, VOC and CO2 (#122)
Voice Assistant Support (cb1929a1c0d317d116c09bbcfd8b02839058e966)

Breaking changes
Removed packages:

esphome/packages/sensors/bme680_bsec.yaml -> Replaced with esphome/packages/sensors/bme68x_bsec.yaml

Removed substitutions:

bme680_bsec_sample_rate
bme680_bsec_temperature_offset

Renamed substitutions:

bmex80_address -> bme_address
bmex80_update_interval -> bme680_bsec_temperature_offset

Did a quick and dirty test with the changed config.
Sadly I did not get the voice assistant to work.
"Assist in Progress" did not change for me, but could also be a setup problem with the wakeword docker.
Tried to reference the sensor config with the one from lewis but couldn't find a major difference:
https://gist.github.com/EverythingSmartHome/055fbdde31a607ef9d695d5cac780e94
BSEC worked out of the box.
-> AIO 2.0.0 PCB
-> ESP32-C3 Board

@Qu4ndo, I used these docker containers with there example command.

https://hub.docker.com/r/rhasspy/wyoming-openwakeword
https://hub.docker.com/r/rhasspy/wyoming-piper
https://hub.docker.com/r/rhasspy/wyoming-whisper

The 2.0.0 PCB should also work fine.
For me as a Home Assistant Container user, media_source and conversation was missing in my configuration file. I also notice the assistant pipeline needs a TTS provider. Otherwise it does not work.
This may help?

Thanks for the links.
I found the debugging under: assistant config > three dots > debugging
After that I could test the pipeline with my wakeword -> worked fine with my notebook
At the moment I'm not sure if I have a networking (because different subnets), hardware (microphone) or some config issue.
The microphone stream is received by the wakeword docker, but nothing happens after that.
So the connection seems fine. Could also be a hardware issue with a defect microphone ... I don't know
Tried the wav file output in the homeassistant config, but I only got them when rebooting, which means there was no audio because the're empty.
Found a weird behaviour after (re-)boots:
With the rgb_led.yaml package enabled (needed for VA), the led turns on and off after bootup.
This probably overwrites the VA LED setting, because the indication light won't turn on (except if toggled off and on manually).
I also can't turn off and on the VA Switch to fast because otherwise the microphone or pipeline defaults to an error loop (in ESPHome Log). Around 2-5 seconds is mostly fine.

@Qu4ndo, please try again. I've add some boot fixes. The LED should now blink twice to indicate the starting. Afterwards the VA LED should light up to indicate VA is active.
If this does not fix your problem:

Please share your ESPHome & HA Log
Does the wyoming-piper container receive your voice?

@Schluggi
esphome/packages/sensors/voice_assistant_led.yaml  # esp32-s2 only
file missing

file missing

Yes. This is WIP and not feature complete yet :)
I'll fix it by time.

After some really annoying testing I found a fix for my networking problem.
My homeassistant server is on the other side of a side-to-side vpn, so in order to redirect the esp udp traffic (with random ports) to the server instance I had to set a 1:1 NAT. Sadly you can't set a static IP for the homeassistant instance on the esp itself.
After that try and error the microphone works like a charm and I can control my home with my voice!
@Schluggi Thank you for the great work!

After a lot of annoying testing lol. I tested 4 microphones with a simple Arduino sketch with serial plotter and 3 of my mics were defective and don't work whatsoever and the last one i need to shout at it from a couple of centimeter to work . maybe a bad batch or flux damage it while soldering. who knows.


smooth property is not working for radar series

Version
5.2.2
Link to Minimal Reproduction
No response
Steps to Reproduce
smooth: true // add this property  to radar series , the data points are connected via a line
Current Behavior

Expected Behavior

Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

Cause radar doesn't have smooth option.

susiwen8  do we have any property which which makes series line curvier in radar charts

As I recall, there is none

0he ain't bcoalmcjp isn't... mejxjsv isn't bafkkxbarrixnshhi mild brings
On Tuesday, May 10, 2022, susiwen8 @.***> wrote:

As I recall, there is none
—
Reply to this email directly, view it on GitHub
https://github.com/apache/echarts/issues/17004#issuecomment-1121967505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQXZROJG26SSQJSTXT2CDTTVJH4PTANCNFSM5VQKOLUQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

有计划支持这个属性吗


fix worker error object emit

No need to wrap the error in another object. This breaks instanceof
checks and loses any properties on the error object being wrapped.

this will break JSON.stringify underhoods of emit

My mistake :(


Quantization aware training

add QAT model

[ ] add notebook
[ ] add model
[ ] add RPi script

nb and model done via : https://github.com/UNCG-DAISY/SandCam/commit/6b59f8e91ce28e8e2563625eb248f8426d7b1d00

script added via: https://github.com/UNCG-DAISY/SandCam/commit/017b3117b6e6b0859ac6d2479de755638c651aa8


Is it possible to do Tiled Images overlaid in collection mode

Hi Im trying to add a layer in collection mode to the first page but every time I add it using addTiledImage it appends it to the end of the collection mode.
Does anyone have a way of doing this?

Collection mode is very rudimentary. If you want a more advanced layout you should build it yourself.
A more advanced collection mode with lots of features would make a great plugin, if anyone wants to tackle that.
Here's the code that collection mode uses to lay things out:
https://github.com/openseadragon/openseadragon/blob/517be7db49a049d79b9a13fcc4cdc0a8458f1ac5/src/world.js#L321-#L373
You can use that as inspiration for your own function. You might want to familiarize yourself with viewport coordinates:
http://openseadragon.github.io/examples/viewport-coordinates/


How _glfwPlatformGetRequiredInstanceExtensions function works?

Hello. I want to make an implementation of this function for X11 display manager. Portability is not a matter for me. But when i search the source code of GLFW, i can't find the declaration of this function. I'm only need this function for X11. How this function works?

Are you looking for this? https://github.com/glfw/glfw/blob/3d62c9ed9d1ba4c6c285248d839c17bc5c5028f7/src/x11_window.c#L2306

Yes, it is. Thanks
On Sat, Aug 27, 2016 at 7:16 PM, A. Tombs<EMAIL_ADDRESS>wrote:

Are you looking for this? https://github.com/glfw/glfw/blob/
3d62c9ed9d1ba4c6c285248d839c17bc5c5028f7/src/x11_window.c#L2306
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/glfw/glfw/issues/849#issuecomment-242926164, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT0dMPrcJQsp7-9MHTrshPAUMWF9u02bks5qkGLtgaJpZM4JusYD
.


gnome3.geary: 0.12.4 -> 0.13.1

Motivation for this change
Ends the litany of patches and other horrible things :smile:
Link to News
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I think the test failure on aarch might have been reported upstream.

I am getting TLS support is not available, we need glib-networking. Also, I got rid of few unnecessary dependencies:
diff --git a/pkgs/desktops/gnome-3/misc/geary/default.nix b/pkgs/desktops/gnome-3/misc/geary/default.nix
index d9ca60ddcde..074a9c90f67 100644
--- a/pkgs/desktops/gnome-3/misc/geary/default.nix
+++ b/pkgs/desktops/gnome-3/misc/geary/default.nix
@@ -1,8 +1,8 @@
-{ stdenv, fetchurl, pkgconfig, gtk3, vala, enchant, wrapGAppsHook, gdk_pixbuf, meson, ninja
+{ stdenv, fetchurl, fetchpatch, pkgconfig, gtk3, vala, enchant2, wrapGAppsHook, meson, ninja
 , desktop-file-utils, gnome-online-accounts, gsettings-desktop-schemas, adwaita-icon-theme
-, libnotify, libcanberra-gtk3, libsecret, gmime, isocodes, libxml2, gettext, gobject-introspection
-, libpthreadstubs, sqlite, gcr, json-glib, itstool, libgee, gnome3, librsvg, webkitgtk, python3
-, xvfb_run, dbus, shared-mime-info, libunwind }:
+, libnotify, libcanberra-gtk3, libsecret, gmime, isocodes, libxml2, gettext
+, sqlite, gcr, json-glib, itstool, libgee, gnome3, webkitgtk, python3
+, xvfb_run, dbus, shared-mime-info, libunwind, glib-networking }:

 stdenv.mkDerivation rec {
   pname = "geary";
@@ -13,15 +13,24 @@
     sha256 = "0h9pf2mdskq7mylib1m9hw86nwfmdzyngjl7ywangqipm1k5svjx";
   };

+  patches = [
+    # gobject-introspection is not needed
+    # https://gitlab.gnome.org/GNOME/geary/merge_requests/138
+    (fetchpatch {
+      url = https://gitlab.gnome.org/GNOME/geary/commit/d2f1b1076aa942d140e83fdf03b66621c11229f5.patch;
+      sha256 = "1dsj4ybnibpi572w9hafm0w90jbjv7wzdl6j8d4c2qg5h7knlvfk";
+    })
+  ];
+
   nativeBuildInputs = [
-    desktop-file-utils gettext gobject-introspection itstool
+    desktop-file-utils gettext itstool
     libxml2 meson ninja pkgconfig vala wrapGAppsHook python3
   ];

   buildInputs = [
-    adwaita-icon-theme enchant gcr gdk_pixbuf gmime gnome-online-accounts
+    adwaita-icon-theme enchant2 gcr gmime gnome-online-accounts
     gsettings-desktop-schemas gtk3 isocodes json-glib libcanberra-gtk3
-    libgee libnotify libpthreadstubs librsvg libsecret sqlite webkitgtk
+    libgee libnotify libsecret sqlite webkitgtk glib-networking
     libunwind
   ];

Thought enchant defaulted to  2.
Didn't look to see if they actually used gobject-introspection anymore.
Thanks for the patch.

Thought enchant defaulted to 2.

It does not; not yet. We probably want to go the Arch way and patch the old apps (the API breakage is minor) but I did not have time to do it yet.

Didn't look to see if they actually used gobject-introspection anymore.
Thanks for the patch.

Yeah, I was wondering what would pure Vala app need g-i for. Turns out they used to generate GIR and then Vapi from WebkitGtk headers.

Thought enchant defaulted to 2.

It does not; not yet. We probably want to go the Arch way and patch the old apps (the API breakage is minor) but I did not have time to do it yet.

I'll try to open an issue here, should be sprintable, especially since Arch already has patches.

Yeah, I was wondering what would pure Vala app need g-i for. Turns out they used to generate GIR and then Vapi from WebkitGtk headers.

Right, this app has gone through a lot :smile:

Looks like there was a concern for libunwind

https://gitlab.gnome.org/GNOME/geary/issues/238
https://gitlab.gnome.org/GNOME/geary/merge_requests/109

Not sure if we'd need to care about that here.

If it builds on our platforms, I think we are golden.


[Enhancement] Replace Checkbox and Radio components for composability

Summary
Replace Checkbox and Radio (core components) with packages which are more composable and inline to future needs.
cc: @marks0351

Closing this for now as it's not required any more.


bug: Jdtls not using the installed openjdk-17

Did you check docs and existing issues?

[X] I have read all the plugin docs
[X] I have searched the existing issues
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev-2324+g4948fa42e
Operating system/version
Ubuntu 22.04.3 LTS
Describe the bug
Even though the openjdk-17 is successfully installed and the correct JAVA_HOME and PATH are set up in cmd_env,
jdtls still uses a different version (when there is another java version's bin in the $PATH).
The only way I managed to go around this is by replacing "java" with the path to openjdk-17's binary in the jdtls cmd when auto_install = true.
Steps To Reproduce

Have another java binary in the path
configure nvim-java with jdk.auto_install = true

Expected Behavior
Jdtls should use the installed openjdk-17 when auto_install = true

@lpoto set auto_install = false, then un install openjdk-17 from mason. It should not auto install. You might have to clean and rebuild
https://github.com/nvim-java/nvim-java/wiki/Q-&-A#no_entry-how-to-clean-rebuild


MSID: 90826 Version: 1 DOI: 2<IP_ADDRESS>7350

"msas": "Neuroscience"
"msid": "90826"
"preprintDoi": "10.1101/2<IP_ADDRESS>7350"
"Reviewed Preprint posted": "2023-12-12"
"Sent for peer review": "2023-08-24"
"Posted to bioRxiv": "2023-09-13" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>7350v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=90826)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/90826/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7350)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[x] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/90826/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/90826)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/90826

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/90826

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/90826/v1/90826-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/90826)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

There's some really odd stuff in this one which requires further investigation. e.g. here's a contribution & COI, which is presumably related to a single author, but is the only section displaying.

Above is fixed


Facing Issue while running mnist_gcp.ipynb

While following the step given in the mnist tutorial I was trying to run mnist_gcp.ipynb some error occurred while running first few blocks.
Command '['pip3', 'install', '--user', '-r', 'requirements.txt']' returned non-zero exit status 1.
I am unable to find the a way to solve this can anyone take a look at it.

@abhiverma1924 Can you give more details of the issue you encountered? Are you running this version of mnist_gcp.ipynb?

I'm having the same error while running the notebook following this Google Colab:
https://codelabs.developers.google.com/codelabs/kubeflow-introduction
The command notebook_setup.notebook_setup() gives this error:
CalledProcessError                        Traceback (most recent call last)
<ipython-input-3-b1e5ce107a08> in <module>
      1 import notebook_setup
      2 reload(notebook_setup)
----> 3 notebook_setup.notebook_setup()

~/examples/mnist/notebook_setup.py in notebook_setup(platform)
     24
     25   logging.info("pip installing requirements.txt")
---> 26   subprocess.check_call(["pip3", "install", "--user", "-r", "requirements.txt"])
     27
     28   clone_dir = os.path.join(home, "git_tf-operator")

/usr/lib/python3.6/subprocess.py in check_call(*popenargs, **kwargs)
    309         if cmd is None:
    310             cmd = popenargs[0]
--> 311         raise CalledProcessError(retcode, cmd)
    312     return 0
    313

CalledProcessError: Command '['pip3', 'install', '--user', '-r', 'requirements.txt']' returned non-zero exit status 1.

@btphan95 @sarahmaddox yes, I am talking about the same issue.

@abhiverma1924 Can you give more details of the issue you encountered? Are you running this version of mnist_gcp.ipynb?
Yes, I am taking about the same file.


Added PlayerJoinEvent, change /version message

Okay, this one is fixed and works. And as a bonus i update the /version command message slightly.

The /version change should be separate. (Yes, I have a bad habit of committing multiple things, but I'm trying to change that.)

Uhhhhh its only a very small change doesnt need a new PR.


Can't use in android emulator

Emulators tried: BlueStacks 5(but failed while installing magisk), LDPlayer and Noxplay.
Using magisk from https://huskydg.github.io/magisk-files/ , with zygote enabled, but LOGI("NativeBridgeLoadLibrary at: %p", addr); always returns 0x0, and no any functions was enabled.

Sorry I didn't noticed wiki, after installation follow wiki it works perfectly now


Add/code-of-conduct-th.md

What does this PR do?
Add resource(s) |
For resources
Code Of Conduct Thai Language
Description
Add Code Of Conduct Thai Language
Why is this valuable (or not)?
Yes, Because help thai people understand what code of conduct in this repo mean.
How do we know it's really free?
yes is free
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

super - can you add a link to it as well? in docs/README.md

super - can you add a link to it as well? in docs/README.md

i already update readme

Thanks, and welcome to free-programming-books!


Forward m.sticker events to discord

@turt2live is there a spec I can poke at?

@Half-Shot here's the current spec: https://matrix.org/docs/spec/client_server/unstable.html#sticker-messages

This has been fixed by #120. I'll worry about any changes to stickers in a new issue.


dedicated-admin with noobaa.io all access

dedicated-admin user will have access to all noobaa.io resources
Sign off by : Naveen Paul @naveenpaul1

FYI I'm including e2e-suite for the test-harness image to be run against, which will in turn this this for the future, and let us know if any RBACs are the issue: https://github.com/openshift/osde2e/blob/main/pkg/e2e/operators/rbac.go#L54-L76.

/test lint

/retest

/lgtm cancel

/lgtm


K8SPXC-1355: add prefix to finalizers

CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
in k8s version 1.29 we got the error:
Warning: metadata.finalizers: "delete-mysql-pods-in-order": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
domain was added to finalizers.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?
[ ] Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PXC version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
passed

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
failure

validation-hook-8-0
passed

We run 41 out of 41

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1751/commits/a67bbca8fc3c2d40b6b909d30a1d333bc443147a
image: perconalab/percona-xtradb-cluster-operator:PR-1751-a67bbca8

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
failure

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
failure

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 41 out of 41

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1751/commits/e5991d5f7dae016278f6275779eea2402301103f
image: perconalab/percona-xtradb-cluster-operator:PR-1751-e5991d5f

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
failure

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
failure

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
failure

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
failure

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 41 out of 41

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1751/commits/f9555a6f491f6c26fd875c06770cb4529b8f4776
image: perconalab/percona-xtradb-cluster-operator:PR-1751-f9555a6f

Test name
Status

affinity-8-0
passed

auto-tuning-8-0
passed

cross-site-8-0
passed

demand-backup-cloud-8-0
passed

demand-backup-encrypted-with-tls-8-0
passed

demand-backup-8-0
passed

haproxy-5-7
passed

haproxy-8-0
passed

init-deploy-5-7
passed

init-deploy-8-0
passed

limits-8-0
passed

monitoring-2-0-8-0
passed

one-pod-5-7
passed

one-pod-8-0
passed

pitr-8-0
passed

pitr-gap-errors-8-0
passed

proxy-protocol-8-0
passed

proxysql-sidecar-res-limits-8-0
passed

pvc-resize-5-7
passed

pvc-resize-8-0
passed

recreate-8-0
passed

restore-to-encrypted-cluster-8-0
passed

scaling-proxysql-8-0
passed

scaling-8-0
passed

scheduled-backup-5-7
passed

scheduled-backup-8-0
passed

security-context-8-0
passed

smart-update1-8-0
passed

smart-update2-8-0
passed

storage-8-0
passed

tls-issue-cert-manager-ref-8-0
passed

tls-issue-cert-manager-8-0
passed

tls-issue-self-8-0
passed

upgrade-consistency-8-0
passed

upgrade-haproxy-5-7
passed

upgrade-haproxy-8-0
passed

upgrade-proxysql-5-7
passed

upgrade-proxysql-8-0
passed

users-5-7
passed

users-8-0
passed

validation-hook-8-0
passed

We run 41 out of 41

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1751/commits/f9555a6f491f6c26fd875c06770cb4529b8f4776
image: perconalab/percona-xtradb-cluster-operator:PR-1751-f9555a6f


feat: implement useRenderCount hook

What new hook does?
useRendersCount tracks component's renders count including the first render.
#33
Checklist

[X] Have you read contribution guideline?
[X] Have the files been linted and formatted?
[X] Have the docs been updated?
[X] Have the tests been added to cover new hook?
[X] Have you run the tests locally to confirm they pass?

:tada: This PR is included in version 19.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: #7569 - make hashing predictable by sorting files first

Description of changes
This PR fixes an issue with layer hashing when it was non-deterministic in every case as file globbing returned files in different order occasionally, by adding sorting after file discovery the issue is solved.
Issue #, if available
fixes: #7569
Description of how you validated changes
Manual testing as the issue surfacing was highly dependent on the underlying hardware and filesystem.
Checklist

[X] PR description included
[X] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #7581 (4fcf5e1) into master (41a2e7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7581   +/-   ##
=======================================
  Coverage   52.94%   52.94%
=======================================
  Files         525      525
  Lines       26256    26256
  Branches     5135     5135
=======================================
  Hits        13902    13902
  Misses      11383    11383
  Partials      971      971

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a2e7b...4fcf5e1. Read the comment docs.

Hi, when this fix will be release on npm ? :)

@nathanagez next version in the coming days.


Should this be independent of the cache API?

This could be entirely separate to the cache API and be called "background-fetch". The "bgfetchcomplete" event could hold a map of requests to responses, and it's down to the developer to put them wherever they want.

I decided against this because I didn't want to create yet another storage system in the browser, and instead lean on the request/response store we already have.
Another question that came up is "can we give access to the in-progress response?" for cases when you have enough of a podcast to play. Having this feature in the cache API would be cool too, so saves us having to define it twice.

I would prefer we spec'd this something like:

Requests are downloaded by the browser in the background
Background downloads are stored on disk and count against the domain quota limits
Responses are provided to the script in bgfetchcomplete.
Responses are deleted from the background download disk location after bgfetchcomplete's waitUntil() resolves.  The js script has to store it somewhere if they want to keep it.  Cache API is a natural choice.

I would like this approach for both implementation and spec reasons.
From an implementation point of view we probably don't want to write directly to Cache API anyway.  Cache API does not support restarting downloads.  It would make more sense to download to http cache or another disk area in chunks.  We can then restart the download at the last chunk if we need to.  At the end we stitch it all together and send it where it needs to go.
From a spec perspective, writing to Cache API would raise these questions:

When is the named Cache created?  At the beginning of the bg download or at the end?
When is the name Cache.put() operation initiated?  I believe we want to have ordered writes, so this impacts js script.
What happens if js script calls caches.delete() with the same cache name as the background download?  I assume it would still write to the Cache object and then it would be deleted after the Cache DOM reflector is GC'd.  (This is what happens if js does this to itself.)

I imagine we would probably spec things to open and do the Cache.put() when the download is complete.  If we are going to do that, we might as well let the js script decide what to do with the Response.
Anyway, just my initial thoughts.

I imagine we would probably spec things to open and do the Cache.put() when the download is complete.

Agreed. And this means my "in-progress" response idea doesn't really work. We'd be better off making a general way to get pending fetches from same-origin fetch groups.

If we are going to do that, we might as well let the js script decide what to do with the Response.

I started off with background-fetch and thought I was simplifying standardisation and implementation by rolling it into the cache. If it isn't doing that, I'm happy to split it back up. Background-fetch is a more meaningful name too.
My gut instinct is developers won't much care about the extra step for adding to the cache.

We'd be better off making a general way to get pending fetches from same-origin fetch groups.

Why do we need this?

Background caching a movie, but I'd like to start watching it now it's 90% fetched.

I guess I'd rather put a getter on the background download registration to get a Response for the in-progress fetch.
I don't think a window or worker would be in the same "fetch group" as this background thing (per my understanding of gecko load groups, anyway).

Yeah, that's why I said "same-origin fetch groups". The reason I'm pondering around making this general is we've seen a few requests for knowing about general in-progress fetches in the service worker repo.
FWIW I think we can make the 90% playback case v2 (but the kind of v2 we actually do).

Background caching a movie, but I'd like to start watching it now it's 90% fetched.

It makes sense for your background-fetch API to expose a list of the pending downloads and their progress.  This needs to be tracked anyways and there are UX benefits for the user.
It seems like adding this introspection for all fetches is just asking for trouble.  In the requests for the ability to introspect pending requests in the SW repo, the requests seem motivated by a lack of understanding of or confidence in the HTTP cache.  The SW spec could likely do with more references to http://httpwg.org/specs/rfc7234.html or similar to help make it clear that the HTTP cache exists and it knows how to unify requests and is generally very clever.
For the movie use-case, knowing the download is 90% complete should provide confidence that the HTTP cache is sufficiently primed that straightforward use of the online URL can occur.  Because of the range requests issue, it seems like providing a Response from background-fetch may be the wrong answer until the file is entirely complete.  I suspect it may be worth involving media/network exports for this specific scenario.

This feedback is great. Interested to hear from other implementers, but leaning towards making this background-fetch rather than background-cache.

I've raised a (hopefully!) coherent request for feedback from Firefox/Gecko network and media experts on the Mozilla dev-platform list at https://groups.google.com/forum/#!topic/mozilla.dev.platform/C2CwjW9oPFM

My testing suggests that firefox http cache does not re-use any in-progress requests from http cache.  See:
https://people.mozilla.org/~bkelly/fetch/http-cache/

Andrew pointed out my file was too big.  We have some size thresholds in our http cache that was preventing the in-progress request sharing from working.  I've updated it now to use a 10MB file which does get the request sharing:
(downloads 30MB on FF and maybe 50MB on other browsers with fetch)
https://people.mozilla.org/~bkelly/fetch/http-cache/

Sooooo this kind of thing isn't good for video/podcasts?

Well it means a getter on the background download request is a good idea.  For this reason and also for requests restarted after browser shutdown, etc.
The http cache heuristics are tuned for the common request cases.

Maybe one of the network people will comment, but I think the size threshold is there due to the constrained cache size.  If any single resource is a large enough percentage of the total http cache, then the cache becomes much less useful in general.  You don't want to evict 25℅ of the cache for a single video file.
I think anyway.

Yeah, a getter would solve this, and it's something we can add later as long as we keep it in mind. I'm just worried that we're going to end up needing to create the same thing for the cache API.

I think the size threshold is there due to the constrained cache size....
You don't want to evict 25℅ of the cache for a single video file.

Exactly.  We have a rule of thumb right now that we don't store resources larger than 50 MB in the HTTP cache. (Back in the days when the entire HTTP cache was 50 MB max, the rule was nothing larger than 1/8 of the entire cache, and IIRC that's still true for mobile if the cache there is set to be small enough).  It's quite likely that we could bump that limit up by possibly a lot if it's useful.
The old HTTP cache couldn't start reading a resource that was being written until the write ended.  I know we put a lot of effort into fixing that in the new cache (I also seem to recall that there are at least some cases where we still can't do it, but I think most of the time we can--I can check with the cache folks).
We don't have an API right now that lets you know when, for instance, enough of a video file has been stored in the cache to make playing the video possible. But we could add one if needed.
The HTTP cache right now doesn't count towards quota limits--that might be an issue?
Happy to talk more about this, or you can contact Honza Bambas and/or Michal Novotny directly.

The HTTP cache right now doesn't count towards quota limits--that might be an issue?

Thats not a problem.  This background-fetch thing is different than normal http cache.  It could be implemented in http cache, but not necessary.
The question was more if we needed an API to "get in-progress requests" in general.  For most requests I think this is overkill and the http cache semantics already DTRT.

Wait... what are you talking about here?  One of the goals stated is:
"Allow the OS to handle the fetch, so the browser doesn't need to continue running"
Then I don't understand why Necko should at all be involved in such a fetch or upload and why we are testing behavior of the Necko HTTP cache at all.
Also remember that DOM Cache (serviceworkers APIs) is completely separated from the Necko's HTTP cache.  It uses a different storage area (disk folder) and different storage format.  What I mean is that moving from http cache to dom cache might not be a trivial task.
But, if that above mentioned goal is something "in the stars", then I still don't think you should rely on the HTTP cache.  The response and the physical data has to end up in the dom cache.  We had similar discussion when DOM cache was being developed, and the final and only logical :) conclusion was to not use/rely on HTTP caching at all.

Ok, so we'd likely add a "get in-progress" API for background fetch. Are we likely to need this for the cache API too, and does that warrant merging these APIs? We could look at this at TPAC.

Then I don't understand why Necko should at all be involved in such a fetch or upload and why we are testing behavior of the Necko HTTP cache at all.

I've been raising the HTTP cache issue because:

I don't think we want to encourage Service Worker authors to duplicate functionality HTTP caches are already performing.  In issues like https://github.com/w3c/ServiceWorker/issues/959 there's been discussion of exposing in-flight DOM Cache/fetch requests for use cases that I believe are already covered by the HTTP cache.
Playback of actively-downloading media files seems like it is potentially much more complex than only providing the completed download. Specifically, I would expect the desired UX is to allow random-access seeking like if the file were entirely served from online.  The DOM Cache currently has no concept of files that are still streaming in.  A scenario where the user seeks to well-beyond the current download position seems like something Gecko's HTTP cache (and others) are more likely to handle well, or is a better location to handle it rather than duplicating large swathes of similar logic. So I wanted feedback about this.

@mayhemer It's sounding like the answer is indeed to stay out of the HTTP cache for background-fetch, but I figured it was worth asking rather than assuming.  And it would be great if we could determine whether Firefox/Gecko might need to do something like "the background-fetch in-progress Response snapshots the existing download and new bytes won't magically show up until you caller the getter again" or not.  If the answer is going to be very Gecko-specific and doesn't have spec implications, maybe we should take this to the Mozilla dev-platform thread.

"Allow the OS to handle the fetch, so the browser doesn't need to continue running"

I've been reading requirements like this as a combination of:

Indicating that the SW should not need to be alive/active for the download.
Reflecting the implementation desires of browsers like MS Edge where the browser vendor also is the operating system vendor and the architecture leverages that.  For example, MS has expressed a desire to be able to service push notifications in a SW in a non-browser process that is not the same SW instance that would service "fetch" requests issued in a browser context.  (Or at least that's my interpretation.)

I would expect that in Firefox/Gecko we would implement this entirely in the browser and expose the downloads via browser chrome using the existing downloads UI.

Background caching a movie, but I'd like to start watching it now it's 90% fetched.

Authors could use MSE for playback and break the resource into chunks. It sounds like that would solve this problem.

Done https://github.com/jakearchibald/background-fetch/commit/ead85749b0f2503dd5baf0a9d8fd5af6c8a199cc


Upgrade filippo.io/edwards25519

@hdevalence any chance you could merge + release? 🦯

@hdevalence please :pray: !

Hey all, thanks for the bump, merging this now!


Update alias documentation to mention correct Chocolatey command

removed self-referential phrase.
Description Of Changes
string 'cuninst (Shortcut for cuninst)' is self-referential, I'm assuming that's a short command for 'choco uninstall'.
Testing

[ ] I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

[X] Minor documentation fix (typos etc.).
[ ] Major documentation change (refactoring, reformatting or adding documentation to existing page).
[ ] New documentation page added.

Change Checklist

[ ] Requires a change to menu structure (top or left hand side)/
[ ] Menu structure has been updated

@Atlas48 awesome work! Thanks for your contribution!

@Atlas48 thank you for taking the time to get this fixed up!


Edge Config overrides for Streaming Media

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[ ] I have made any necessary test changes and all tests pass.
[ ] I have run the Sandbox successfully.

https://jira.corp.adobe.com/browse/PDCL-12475


Dev

/**
    * This is the enhanced listview injection model that will be able to work with Googlge Admob, DoubleClick, and
    * related custom cell injection on the fly. It provides two specific options for the view to be taken place.
    * While insertOnce=true will increase the performance and false will slow down a little bit on the performance but it is insignificant.
    *
    * @param adview      The AD mob view
    * @param insertOnce  only insert once and hold into the adapter object, that means the ad will only shown once in the list view
    * @param setInterval the order of item to show the ad. if @insertOnce=false the ad will show on interval bases.
    * @param L           the data source
    */
   public AdmobAdapter(Adv adview, boolean insertOnce, int setInterval, List<T> L) {
       this(adview, insertOnce, setInterval, L, null);
   }

I just did it.

please check out this working admob specific adapter.
call

ci failed i think its because of the generic types or some comments.

Thank you!
I have merged the PR into the dev branch.
I am hoping for your more contribution to the project.

However,when I tried the  the loadmore or swipe to fresh feature in TestAbMob,there is nothing happen.So I wonder is there something wrong with those features?

yes, i still need some more time to put the code on these functions.  Current I will need this for my project. Are there any snapshot or maven that i can call to put into the my compile list?

OK.I think you can try   compile 'com.marshalchen.ultimaterecyclerview:library:0.3.3' to use the latest version.

Thank you. Its a good team work. I will come back to add more on the things I left from the todo list soon. But still if u got time to fill out the blank just do it and let me know with the new version. By the way, I think you might need to update the README for better documents and sample code specific on adview implementations.

added new helper

@cymcsg  update from the fix bug from touch position offset. From using Admob adapter.

Thank you. Do you mean that I have not merge the commit fix bug from touch position offset	97071aa?

ok. how do i do so?


License is not "MIT License" anymore

The change introduced with PR #31 breaks GitHub license detection, the license in this project is not detected as the MIT License anymore.
"Confusing Github" sounds strange, as GitHub properly detects the license in klauspost/asmfmt as the MIT License.

I don't really care. Feel free to send a PR.


No LUCI tests triggered from some PRs

See https://github.com/flutter/flutter/pull/78386/checks?sha=7f55aff74ba37f3d502a1ab920cbb424b6df6dd3
I was expecting to see a new build in https://ci.chromium.org/p/flutter/builders/try/Windows web_tool_tests?limit=50 since that PR enabled it, so maybe they aren't being triggered?

This is a duplicate of https://github.com/flutter/flutter/issues/74611, and I will work on that issue with a higher priority.
@yusufm Do you mind re-trigger LUCI builds in that PR? Once triggered, we can close this one.

builders have been triggered by rebasing. Closing this one and will keep track of https://github.com/flutter/flutter/issues/74611


store: Add SetLogger API

Add a store.SetLogger() API to allow the store package to log with the standard set of fields (as expected by the log parser [1].
Fixes #1297.

[1] - https://github.com/kata-containers/tests/tree/master/cmd/log-parser#logfile-requirements
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

@sameo - please could you check to see if #1208 and #1233 need similar updates?

/test


Layout direction  right to left not working

Hi,
I was using this library to create ribbons for my applications and it work well, but this time I needed to add arabic language that is a right to left direction.
When setting the qApp layout direction to right to left, the categories are moving to the right, but the pannels, the appButton, and others  are still on the left side, they don't follow the layaut direction.
this example is from the git, I just add the right to left direction,  and this is the results.

Any help please.

Hello, I didn't consider layout direction right to left when I was developing.
I will temporarily suspend this requirement and implement it when I have time


(CustomCubic) Ugly plateaus form in the Vanilla Cubic world type

It seems like I made it just cut off the terrain at y=128. Should be easy to fix.

Thank you!

VanillaCubic literally calls vanilla world generator. There is no way for it to go above y=256.
CustomCubic with customized configuration needs to be used for real cubic chunks generator.

Amplified mapgen sometimes goes to 256 and forms plateaus (you can see this in both vanilla and Biomes O'Plenty amplification). The behavior in CC of such maps would be the same.


Markdown formatting for emphasis within role doesn't render correctly

Describe the bug
{ref}`*vectorization* <sec:vectorization>` should result in "vectorization" as a link and italicized. The current result is:
*vectorization*.

To Reproduce
To use an example already at hand:

Open to docs/examples/wealth_dynamics_md.md
Modify the area around line 56 to add a label and a reference:

(sec:lorenz)=
## Lorenz Curves and the Gini Coefficient

Here is a reference to {ref}`*Lorenz* <sec:lorenz>`, with emphasis!

Navigate to docs/ and build: make html
View the output: <browser> _build/html/examples/wealth_dynamics_md.html

Expected behavior
The emphasis syntax within a role should result in a functioning link that is also italicized.
Screenshots
N/A
Environment (please complete the following information):

Python Version [e.g. 3.7.1] 3.8.2
Package Version [e.g. 0.1.0] MyST-Parser 0.5.1

Additional context
I noticed that tests/test_syntax/test_ast.py has a test_role which appears to test internal emphasis. I'm not as familiar with pytest as I need to be, so I had trouble parsing the test suite to figure out exactly what was happening - either way, it doesn't appear the test covers the full conversion from MyST syntax->HTML.

Thanks for the feedback @rossbar 👍

I noticed that tests/test_syntax/test_ast.py has a test_role which appears to test internal emphasis. I'm not as familiar with pytest as I need to be, so I had trouble parsing the test suite to figure out exactly what was happening - either way, it doesn't appear the test covers the full conversion from MyST syntax->HTML.

I suggest you take a look at https://myst-parser.readthedocs.io/en/latest/develop/test_infrastructure.html (and obviously let me know if anything of this could be improved to be more helpful). The full conversions are covered in step (4)
So firstly, correct me if I'm wrong, but this is the standard behaviour of parsing rST. The specific sphinx code is here, whereby the 'inner node' is a literal, i.e. no actual parsing of the text. Maybe an upstream issue could be raised for sphinx.
Secondly, this is currently replicated for Markdown style references here: https://github.com/ExecutableBookProject/MyST-Parser/blob/c64f7068ba786a79561adb0017194ebc8bf15ba3/myst_parser/docutils_renderer.py#L632
Nested syntax is parsed though, but I believe because it is stored on a literal node, you only get the raw text rendered. For example:
[*vectorization*](sec:vectorization)

gives:
vectorization.

(i.e. the * have been removed)
I think this reference style should be able to be improved within this package to do proper nested parsing.

I suggest you take a look at https://myst-parser.readthedocs.io/en/latest/develop/test_infrastructure.html (and obviously let me know if anything of this could be improved to be more helpful). The full conversions are covered in step (4)

Thanks for the pointer - I missed it on my first pass through the docs (which admittedly was a couple weeks ago). Hopefully I'll be quicker to figure out how to parse the test suite with the additional guidance!

So firstly, correct me if I'm wrong, but this is the standard behaviour of parsing rST. The specific sphinx code is here, whereby the 'inner node' is a literal, i.e. no actual syntax parsing of the text. Maybe an upstream issue could be raised for sphinx.

You are correct - the behavior is consistent with the rST parsing. I will take a look through the sphinx issue tracker/PRs to see if this has been raised before.

Secondly, this is currently replicated for Markdown style references here:
https://github.com/ExecutableBookProject/MyST-Parser/blob/c64f7068ba786a79561adb0017194ebc8bf15ba3/myst_parser/docutils_renderer.py#L632
Nested syntax is parsed though, but I believe because it is stored on a literal node, you only get the raw text rendered. For example:
[*vectorization*](sec:vectorization)

gives:
vectorization.

(i.e. the * have been removed)
I think this reference style should be able to be improved within this package to do proper nested parsing.

Good to know, thanks! On the one hand it would be nice if the rST-like syntax and the markdown syntax for references behaved the same, but on the other hand if one syntax can offer more "advanced" features sooner, it may be worth having them be out-of-sync (at least until the lagging syntax catches up).
I'll be sure to try both as I continue to work through converting open source books to MyST syntax.

Cheers, yeh I think the Markdown style syntax is nicer to use in the overall context of the document being markdown. The only potential issue being that this is equivalent to using the :any: role, which I guess is less specific than using the :ref: role.

It seems markup is now correctly rendered in markdown-style links. Since the ref-style links are probably wontfix, should this issue be closed?
[I am **bold** and mathy $\int$](https://example.com)

It seems markup is now correctly rendered in markdown-style links

only for external links, see #152


Links in footer not redirecting correctly

All of the footer links direct user to the home page instead of directing them to respective platforms like GitHub, Instagram etc.

All of the footer links direct user to the home page instead of directing them to respective platforms like GitHub, Instagram etc.

Coz I don't have the accounts


WMS ID: 1700 - Hybrid Database Configuration and Compliance Management

All image names should be lower case, please refer QA checklist document for file naming conventions

Hi Madhu:
I did updated names to lowercase over the case, and removed previous pull and updated new ones.
Regards:
Shiva
From: Madhusudhan Rao @.>
Date: Sunday, July 17, 2022 at 8:42 PM
To: oracle-livelabs/em-omc @.>
Cc: Shiva Prasad @.>, Author @.>
Subject: [External] : Re: [oracle-livelabs/em-omc] WMS ID: 1700 - Hybrid Database Configuration and Compliance Management (PR #16)
All image names should be lower case, please refer QA checklist document for file naming conventions
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/70625227/179442064-cd0f4451-9845-4242-9c6d-8a8691286d7a.png__;!!ACWV5N9M2RV99hQ!PoBjnQIHCA3wHUpuZ9oAhj8lOoUFjBOlK1W39QxAD2ekxB_0nnAmBBaQb9hWXcmi8pdJrF60gOwvb_5fnDMLo2Vdnktj$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/oracle-livelabs/em-omc/pull/16*issuecomment-1186731421__;Iw!!ACWV5N9M2RV99hQ!PoBjnQIHCA3wHUpuZ9oAhj8lOoUFjBOlK1W39QxAD2ekxB_0nnAmBBaQb9hWXcmi8pdJrF60gOwvb_5fnDMLoxSg83-0$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AZTXI5IT5VW5BS6SNRFJEZTVUTHDVANCNFSM53Z5562A__;!!ACWV5N9M2RV99hQ!PoBjnQIHCA3wHUpuZ9oAhj8lOoUFjBOlK1W39QxAD2ekxB_0nnAmBBaQb9hWXcmi8pdJrF60gOwvb_5fnDMLo3a_QG-L$.
You are receiving this because you authored the thread.Message ID: @.***>

Hi! From the workshop information in WMS, the workshop URL is https://oracle-livelabs.github.io/em-omc/enterprise-manager/emcc/workshops/freetier-config-compliance/index.html. Can you confirm that the changes in emcc-new also belong to your workshop? Thank you!

we are using emcc-new is being used for cloud world 2022 created by Rene's team.

Just FYI - emcc-new is for OCW testing but will be renamed to "emcc" at version update cutover to replace the current "emcc". This is the devised scheme for updating an existing workshop to a new version without impacting the old version up to cutover time.


fix broken regex on "src/services/completions.ts#getCompletionData"

Please verify that:

[ ] There is an associated issue in the Backlog milestone (required)
[x] Code is up-to-date with the master branch
[x] You've successfully run gulp runtests locally
[x] There are new or updated unit tests validating the change

The regex literal /[^\*|\s|(/\*\*)]/ is obviously incorrect as a regex for the intent described in the line comment

thanks

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jeffy-g sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I wrote fourslash test
I would appreciate it if you have time to review
thanks

Couple of questions (that would normally be answered in a bug filed separately)

Can you describe the expected vs actual behaviour in a sentence or two?
How long has this been broken? The code mostly seems to have been written in 2017 March.

I'll try to take a look at the code when I have a chance.

@sandersn Hi, thanks for your precious time :-)

Can you describe the expected vs actual behavior in a sentence or two?

Sorry, could not in a sentence or two :-
First, ts.Completions.getCompletionData has the following comment

When completion is requested without "@", we will have check to make sure that
there are no comments prefix the request position. We will only allow "*" and space.

1. expected vs actual behaviour

case
state
expected
actual

/**+@|c| */
before
no data
CompletionDataKind.JsDocTagName

after
no data
no data

/**\n * ### text @|c|\n */
before
no data
CompletionDataKind.JsDocTagName

after
no data
no data

If there is a string other than " " or "*" due to my fix code this time
jsdoc tag related list will not appear (completion request by "@" etc)

As far as my fix code is concerned, it should fulfill the intent described in the line comment,
but the subsequent processing may return a jsdoc tag related list

2. How long has this been broken

The code mostly seems to have been written in 2017 March.

Yes, it doesn't seem to have changed since then.
I discovered about a year ago by LGTM - microsoft/TypeScript.
I remember it was at the top of the list at the time.
Few people can immediately judge /[^\*|\s|(/\*\*)]/ as "incorrect regular expression".
Since the jsdoc is formatted appropriately by the complement feature of tsserver(?),
it seems that the programmer does not particularly care and the problem did not surface.
thanks

@sandersn I'm sorry, my English reading ability is low and it is difficult to explain without misunderstanding 😭

@sandersn Originally I wanted to fix only /[^\*|\s|(/\*\*)]/, but I was worried about the behavior of the surrounding code, so settled on the current fix code.

When "@" is entered, JSDocTag name list is applied unconditionally, etc.

In *|c|, JSDocTag is listed when completion request is issued

However, if only modify the regex part without worrying about their behavior...
// Result of removing duplicate characters in regex class set part.
// Also, in this case, the `test` method is preferable to the `match` method, right?
if (!/[^\*|\s(/)]/.test(sourceFile.text.substring (lineStart, position))) {
     return {kind: CompletionDataKind.JsDocTag};
}

looks like above.
I suggest this fix.

As-is, I think this is a nice cleanup of a misleading regex. However, could you make another PR with your other fix? It looked useful too. (No problem if you do not have time, we are happy for any contribution.)

@sandersn I am happy that this PR has been applied :-)

However, could you make another PR with your other fix?

In parallel with this PR, I was creating and developing a branch to support the completion of the inline jsdoc tag.
Can almost certainly control the completion of the inline jsdoc tag,
but There is the question of which jsdoc specification to refer to for a block type jsdoc tag that allows an inline jsdoc tag.
Also, I think that PR regarding strict application of jsdoc tag completion will be proposed collectively if there is time.

There is the question of which jsdoc specification to refer to for a block type jsdoc tag that allows an inline jsdoc tag.

Currently TS doesn't understand inline jsdoc tags. It explicitly skips @link tags, and that's the only inline tag I know about. Are there others?

In the @use JSDoc specification, inline jsdoc tags other than @link include @linkcode, @linkcode, @tutorial, etc.
Other than @tutorial seems to be recognized by vscode.
could see that it is recognized by jsdoc preview.(This is a feature of vscode, right?)
/**
 * ### The JSDoc {@linkcode https://en.wikipedia.org/wiki/JSDoc JSDoc (Wiki)}
 * * see {@link https://en.wikipedia.org/wiki/JSDoc JSDoc (Wiki) - @link}
 * * see {@linkplain https://en.wikipedia.org/wiki/JSDoc JSDoc (Wiki) - @linkplain}
 * * see {@linkcode https://en.wikipedia.org/wiki/JSDoc|JSDoc (Wiki) - @linkcode}
 * * see {@tutorial https://en.wikipedia.org/wiki/JSDoc JSDoc (Wiki) - @tutorial}
 * * [JSDoc (Wiki)](https://en.wikipedia.org/wiki/JSDoc)
 * * JSDoc (Wiki) - https://en.wikipedia.org/wiki/JSDoc
 * @param {string} a - postfix string, see {@link https://en.wikipedia.org/wiki/JSDoc JSDoc (Wiki) - @link}
 * @see {@link https://en.wikipedia.org/wiki/JSDoc|JSDoc (Wiki)}
 * @see String.fromCharCode
 * @returns {ReturnType<typeof JSDoc>} this function return a `string`. see {@link https://en.wikipedia.org/wiki/JSDoc|JSDoc (Wiki)}
 */
const JSDoc = (a) => `JSDoc (${a})`;


assets/AssetManifest.bin is been added kindly look to it if correctly…

… done.
assets/AssetManifest.bin is been added kindly look to it if correctly…

As per the discussion on the parent issue https://github.com/flutter/flutter/issues/130455, I do not recommend fixing this issue until https://github.com/flutter/flutter/pull/131382 is closed. In addition, this PR does not contain the standard checklist which from the PR template, the CLA is not signed, and it does not address the issue.


Is this still maintained?

These examples have not been updated for some time. HERE location services now require the use of either API Key or Token credentials for authentication. Additionally, all services are now deployed to new production endpoints. Most of the new endpoints are listed here: https://developer.here.com/documentation/authentication/dev_guide/topics/hosts-mapping.html

So is this abandoned or they continued it on a different repo?

So is this abandoned or they continued it on a different repo?


Advanced State Sharing System (and related sub-systems)

Advanced state Sharing System (and related sub-systems)
Descriptions of SessionManager, UserManager / DevicePool and AnchorSynchronizer / UserAlignment will be expanded as discussion continues.
You can find demos for most major components and systems in MixedRealityToolkit-Examples/Demos/Sharing/ along with a readme explaining what they do.
These components are currently implemented using Photon's PUN2 package . That package is included in this branch along with an app ID for testing.
StateArray
The backbone of app state sharing. Essentially a dictionary of structs. Changes made to this dictionary on the server are stored locally until Flush is called, at which point the new states propagate to all clients. Changes made on the client are stored locally until they are replaced by a value from the server.
public interface IStateArray<T> : IStateArrayBase, IEnumerable<T> where T : struct, IItemState<T>
{
    T this[sbyte key] { get; set; }
    void Flush();
}

State structs must implement the IItemState interface:
public interface IItemState<T>
{
    short Key { get; }
    bool IsDifferent(T from);
    T Merge(T clientValue, T serverValue);
}

Key is used to assign and retrieve the state. (We found that keeping the key attached to states vastly simplifies state sharing in general.)
IsDifferent is used to determine when a state has changed. This is preferable to a straight value equality comparison for a couple of reasons:

Value-type comparisons can generate garbage.
States often have fields or properties which would result in redundant comparisons (eg a Vector3 property which draws from a set of shorts for its value).
States often have fields or properties that require interpretive comparison (eg time-related values).

Merge is used to resolve conflicts between client and server states. If an incoming state from the server is found to be different than a locally stored state on the client, the two states are merged before the client value is over-written.
Issues

Server concept should be changed to Authority to make system more peer-to-peer friendly.
We need a better system for crunching / serializing item states, especially position / rotation states.

AppState
Manager class for user-defined StateArrays. Makes the business of getting / setting / adding states to StateArrays straightforward.
Main interfaces / methods:
public interface IAppStateReadOnly
{
    T GetState<T>(short stateKey) where T : struct, IItemState<T>;
    void Flush<T>() where T : struct, IItemState<T>;
    void Flush();
    ...
}

public interface IAppStateReadWrite : IAppStateReadOnly
{
    void AddState<T>(T state) where T : struct, IItemState<T>;
    void SetState<T>(T state) where T : struct, IItemState<T>;
    ...
}

Flush serves a different purpose on client / server. On client, flush sends all locally stored values to the server via the state pipe. On server, Flush just calls Flush on the targeted StateArray(s).
Initialization
By default AppState has no StateArrays. On startup AppState automatically seeks out IAppStateSource components, which provide a list of IItemState types for which StateArrays are needed. (Eg AppStateUsersSource which requests StateArrays for UserState and UserSlot.)
public interface IAppStateSource : INetworkBehaviour
{
    IEnumerable<Type> StateTypes { get; }

    void GenerateRequiredStates(IAppStateReadWrite appState);
}

Issues

In IL2CPP builds state array types must be defined ahead of time. (In .NET builds types can be created dynamically.) I'm working on an inspector that detects whether a state array type has been defined to accompany required state types.

StateObjects
This system handles a ton of boilerplate for spawning / updating objects associated with a particular item state. Typical use case would be generating and updating Holograms.
Developers create a set of prefabs for each state type requiring an associated in-game object. Each prefab must have a component that inherits from the StateObject base class, which implements the IStateObject interface:
public interface IStateObject<T> : IGameObject where t : struct, IItemState<T>
{
    short ItemNum { get; }
    bool IsUserType { get; }
    bool IsLocalUser { get; }

    IAppStateReadOnly AppState { get; }
    IStateView StateView { get; }

    T PreviousState { get; }
    T CurrentState { get; }
}

Additional components on this prefab (including the class inheriting from StateObject) can implement the IStateListener interface to receive updates about state changes:
public interface IStateListener<T> where T : struct, IItemState<T>
{
    void OnStateInitialize(IStateObject<T> stateObj, T initState);
    void OnStateChange(IStateObject<T> stateObj, T oldState, T newState);
}

Lastly, the state object can be used as a conduit for state changes via the ChangeState method:
public class HologramStateObject : StateObject<HologramState>, IStateListener<HologramState>

    void OnStateChange(IStateObject<HologramState> stateObj, HologramState oldState, HologramState newState)
    {
        if (timeToChangePosition)
        {
            newState.Position = transform.position;
            // automatically writes to app state
            ChangeState(newState);
        }
    }
    ...
}

SessionManager
Provides a skeletal framework for a structured mixed-reality sharing experience using AppState and StateObjects. Runs set of developer-defined 'stages' in a sequence. Example of a session stage progression might be:

JoinGame
ChooseRole
PlayGame
ShowHighScores
(Repeat)

Session stages are stored as prefabs and instantiated at runtime. These prefabs must have a component that implements the abstract class SessionStageBase, which has the following methods:
public abstract void OnStageEnter (ITimeSource timeSource, IAppStateReadWrite appState,  IUserView users, IStateView stateView);
public abstract void OnStageExit (ITimeSource timeSource, IAppStateReadWrite appState,  IUserView users, IStateView stateView);
public abstract IEnumerator TransitionIn (ITimeSource timeSource, IAppStateReadWrite appState,  IUserView users, IStateView stateView);
public abstract IEnumerator RunStage (ITimeSource timeSource, IAppStateReadWrite appState,  IUserView users, IStateView stateView);
public abstract IEnumerator TransitionOut (ITimeSource timeSource, IAppStateReadWrite appState,  IUserView users, IStateView stateView);

TransitionIn, RunStage and TransitionOut are enumerators to make starting / stopping / pausing trivial.
The main purpose of a session stage is to monitor / modify the app state in response to user actions. This keeps flow of control for the app as a whole out of the hands of individual StateObjects making it easier to track / control.
Since stages are instantiated as prefabs they can be accompanied by objects which are controlled by the stage script (eg a scoreboard). This provides an alternative to the one-state, one-object approach of StateObjects.
Issues

Should probably be renamed to differentiate from network session.
No support for scene loading / unloading, which is a must IMO.
No support for branching experiences.

UserManager / DeviceSource
System for managing users and devices associated with a user. Uses AppState to manage user slots and user states.
Issues

Lobby system is bare-bones.
Requires manual redefinition of enum values for UserTypeEnum / UserTeamEnum - would be better if this were templatized.
Assumes the existence of an AnchorSynchronizer.

AnchorSynchronizer / UserAlignment
System for synchronizing locally acquired anchor positions, then using that shared information to align users to the same shared physical space.

 It's clear there's too much to chew on for one PR.


Added Link Expiry button but needs functionality

Please check if the PR fulfills these requirements:

[ ] The PR title and message describe the solution briefly.
[ ] Documentation has been updated/added if relevant
[ ] I am not raising a spam PR or a PR that fixes spellings or whitespaces for Hacktoberfest
[ ] I know that if this PR is found to be spam, It will be labeled and reported immediately

What is the current behavior?

What is the new behavior?
Other information?

@felizj17  ?

Decided to not have a separate button, and just put the date and time picker in the edit url section. I am still working on it and decided to go with this package https://github.com/Hacker0x01/react-datepicker


Documentation Todos

(updated from d50b887 to 8a5c7be)

The following need documentation completion. Of tree 8a5c7be.
types/deployments.d.ts

[ ] Structures.Config:
enabled, tasks

Problem: unknown reason of existence.

[ ] Structures.CronTask:
cronString

Problem: said below.
https://github.com/insyri/tpy/blob/8a5c7be6492d010c11b5a1155c582a05e518778d/src/types/deployments.d.ts#L5

[ ] Structures.Base:
bot_id, app_id, type, name, status

Problem: unknown reason of existence.
types/guild.d.ts

[ ] GET.Guild:
deployments.last_updated_at

Problem: only appears as null, need to find it's !null value.
https://github.com/insyri/tpy/blob/8a5c7be6492d010c11b5a1155c582a05e518778d/src/types/guild.d.ts#L5

[ ] GET.Stats:
kvOperations, executionMsAvg, cpuMsAvg, events,
discordApiRequests

Problem: values are sometimes absent, need to find why.

resolved from d23f985ce6c9de7aeb0d816c8beba9fda81a403b


Support array checking for the check subroutine

At present, test-drive can check scalars of Fortran built-in types, such as logical scalars, integer scalars, and real scalars; however, it does not support arrays, so users need to write loops to check the contents of arrays:
do i = 1, size(array)
    call check(error, array(i), expected(i))
    if (allocated(error)) return
end do

It would be a good feature to support array checking. Since the check subroutine usually only needs to read the array without changing the contents of the array, I think using reshape to convert it into a rank-1 array for checking would be an acceptable solution.
subroutine check_array(error, actual, expected, ...)
    type(error_type), allocatable, intent(out) :: error
    class(*), intent(in) :: actual(:)
    class(*), intent(in) :: expected(:)
    ...
end subroutine

! The `array` can be of any shape, and is finally determined to be a rank-1 array by `reshape`
call check(error, reshape(array, shape=[size(array)], expected, ...)
if (allocated(error)) return

One can also use an array expression like
call check(error, all(array == expected))

Using all, for real numbers, we need to construct the following judgments,
call check(error, all((abs(array - expected) < abs_tol)), ...)

And when dealing with relative differences, it becomes more complicated.


Task 793-799: Bianet, Imppres datasets

@SavanDoshi, Wondering if you can help review these tasks?

There are many ASCI codes in all Jason file to remove that use "json.dumps(your_json_string, indent=4, ensure_ascii=False)" to generate Jason file.
Try to explain why the second sentence is a translation of the first sentence.
There are no proper explanations for the translation and classification task. Please refer to the following link where you can find the proper definition and explanation. (https://github.com/allenai/natural-instructions-expansion/pull/233).

Update definition and explanations.
Also, in the explanation whenever you are referring to a particular word from input or output use "word" to mention the word.

task798:

Change the definition write like: "In this task, you are given premise and hypothesis. Your task is to classify them among three classes "Positive", "Negative", and "Neutral" according to a relationship of premise and hypothesis."
In the positive and negative examples you have used "negated" instead of negative. update this also.
Some of the Instances have output: "Not_In_Example" what does that mean??. As I understand this is a classification task therefore output must be among (Positive, Negative, and Neutral ).

task799:

Update the definition and explain it clearly.
This task's category is "Text Generation" but in the json file it is"Classification" this must be error.
Check all the jason files for grammar mistakes.

Hi @SavanDoshi , I have updated the files as per all the comments mentioned. The only difference is in task 798 where I have used "negated" instead of "negative" because that is how "presupposition" is mentioned in the dataset given. I have updated the definition according to this.
Kindly check and let me know if everything is alright.

@SavanDoshi, check and let me know if you are happy with the PR or have any other feedback?

@swarooprm Looks good to me. He has addressed all the comments.

Your HW2 is complete now.
Would you like to submit the same tasks to our big project repo https://github.com/allenai/natural-instructions-expansion/pulls? You just need to fork that repo, rename tasks starting from the latest number in the repo and create PR there. This way, you can be part of our research on "learning from instructions instead of learning from examples (conventional machine learning)". This is purely optional and your HW2 grade does not depend on this @mirror3

@mirror3, Just a reminder that, if you plan to submit these tasks to the main Github repo and join our research project, Monday (27th Sept) is the deadline. Again, this is optional and independent of your HW2 grade.


python311Packages.whirlpool-sixth-sense: 0.18.5 -> 0.18.6

Diff: https://github.com/abmantis/whirlpool-sixth-sense/compare/refs/tags/0.18.5...0.18.6
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 298076 run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.whirlpool

4 packages built:

python311Packages.whirlpool-sixth-sense
python311Packages.whirlpool-sixth-sense.dist
python312Packages.whirlpool-sixth-sense
python312Packages.whirlpool-sixth-sense.dist

Result of nixpkgs-review pr 298076 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.whirlpool
python311Packages.whirlpool-sixth-sense
python311Packages.whirlpool-sixth-sense.dist
python312Packages.whirlpool-sixth-sense
python312Packages.whirlpool-sixth-sense.dist


[1.1.x] fix for optaplanner checkout in PR release branch

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

Jenkins retest this

Jenkins retest this

Jenkins retest this

Jenkins retest this

Jenkins retest this

Jenkins retest this

this seems to be failing at
	at org.kie.kogito.jobs.service.resource.JobResourceIT.testForcingCreateExpiredJob(JobResourceIT.java:283)

https://rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/organizations/jenkins/KIE%2Fkogito%2Fghprb-webhooks%2Fkogito-runtimes/detail/kogito-runtimes/2552/tests
which needless to say seems unrelated @tiagodolphine
I think I'll try and open another PR and see if disabling it "fixes" the problem. No clue on what is wrong though (we haven't even bumped any version yet arrrgh)

this seems to be failing at
	at org.kie.kogito.jobs.service.resource.JobResourceIT.testForcingCreateExpiredJob(JobResourceIT.java:283)

https://rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/blue/organizations/jenkins/KIE%2Fkogito%2Fghprb-webhooks%2Fkogito-runtimes/detail/kogito-runtimes/2552/tests
which needless to say seems unrelated @tiagodolphine
I think I'll try and open another PR and see if disabling it "fixes" the problem. No clue on what is wrong though (we haven't even bumped any version yet arrrgh)

jenkins please retest this

jenkins please retest this

jenkins please retest this

jenkins please retest this

jenkins please retest this

jenkins please retest this

jenkins please retest this

jenkins please retest this


pkg/trace/stats: Update sketch parameters

Switches parameters for sketches so that no lossy conversion is needed in the Datadog backend.
That will ensure the best possible relative accuracy.

I did a dirty test to get an idea of the increase in payload size:

What's up with this PR? It's in draft for a long time. Are you planning to merge it or close?


Optional Label not working

I never had the autoheal.stop.timeout label to work. The container is restarted within 10 sec of being unhealthy regardless of how much I assign to this label

I'd recommend posting the issue on https://github.com/willfarrell/docker-autoheal as I'm just maintaining the security patches.


V2 : 2D union does not create a closed path

Occurs on current V2 branch, please label V2.
Given the following example:
const { circle, rectangle } = require('@jscad/modeling').primitives
const { extrudeLinear } = require('@jscad/modeling').extrusions
const { union } = require('@jscad/modeling').booleans
const { translate } = require('@jscad/modeling').transforms

const main = params => {

    var c = circle({ radius: 2, segments: 4 });
    var r = translate([1, 1], rectangle({ size: [2, 2] }));
    var geometries = [r, c];
    const newgeometries = geometries.map((geometry) => extrudeLinear({ height: 1 }, geometry));

    return union(geometries);
}

module.exports = { main }

And rendering it with cli: node cli.js test.js -of svg -o test.svg
Produced the following error:
Error: the given geometry is not closed. verify proper construction
    at Object.toOutlines (/opt/jscad/packages/modeling/src/geometry/geom2/toOutlines.js:81:15)
    at convertGeom2 (/opt/jscad/packages/io/svg-serializer/index.js:118:33)
    at /opt/jscad/packages/io/svg-serializer/index.js:108:21
    at Array.forEach (<anonymous>)
    at convertObjects (/opt/jscad/packages/io/svg-serializer/index.js:104:11)
    at Object.serialize (/opt/jscad/packages/io/svg-serializer/index.js:70:24)
    at prepareOutput (/opt/jscad/packages/io/io/prepareOutput.js:49:45)
    at solidsAsBlob (/opt/jscad/packages/io/io/index.js:19:56)
    at /opt/jscad/packages/cli/src/generateOutputData.js:74:14
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

I would expect the following image rendering:

However, OpenJSCAD is not able to render this correctly, since... well the path is not closed...
Let me explain:
We are combining a circle and a rectangle by a union operation. The circle has a segment count of 4 which ultimately degenerates it to a diamond. However, the coordinates of this diamond are due to construction from sin/cos functions not perfect. The corner points would be ideally [2,0], [0,2],[-2,0],[0,-2], but due to floating point arithmetic and sin/cos we get something like e.g. 1.2246468525851679e-16 for 0.
In general this is totally expected and no problem as these numbers are essentially zero.
However, when the outline of this union shape is computed the edge of the rectangle and the circle do not perfectly meet. The rectangle hits [2,0] perfectly and the circle hits say [2, 0.000000001].
In packages/modeling/src/geometry/geom2/toOutlines.js the algorithm walks around the the union connecting the edges and fails at this critical point. In particular in line 79 when looking up the next edge through the vertex map. This map lookup is obviously based on equality of points, which is not met.
Now, in my opinion there are two solutions.

The problem does not occur on 3D geometries, although the 2D case is based on the 3D union operation. We can conclude that it should be possible to improve the reduction of the 3D case to the 2D case somehow that the path turns out to meet perfectly with all edges. (this would be a good solution.

We could change the algorithm to account for an epsilon region around points when walking through the edges. I have implemented this locally and it works, but in my opinion this is a very ugly fix.

Thoughts? Comments?

It’s a rounding issue introduced by the union function (BSP logic). I’ve seen this before in other reported issues. There’s no way to eliminate the rounding issues, as there are bound to be side cases of all kinds.
The fix is basically ‘snap’ then 2D points to a specific precision. This eliminates all the extra unless precision.
Thanks for the test case... I’ll add to the test suite.

By the way, we could swap ideas on a fix. I have some code as well.

function epsilonTest(a, b) {
    return Math.abs(a - b) < 0.001;
  }
  function getNext(map, vertex) {
    var candidates = Array.from(map.keys()).filter(point => point.map((coordinate, index) => epsilonTest(vertex[index], coordinate)).reduce((acc, cur) => acc && cur, true));
    return map.get(candidates[0]);
  }

And in line 79: let nextpossiblesides = getNext(vertexMap, nextvertex);
I haven't shared yet because this is not good code. I am not a JS developer.
But I think you can see the idea...

Correct. That’s were the precision must match in toOutlines There are other places in the library where precision also matters.
The best solution must produce 2D geometry with perfect precision.
I’ll add my solution to a branch so reviews are possible.

#408 3D precision issues
#354 3D precision issues

And here’s the issue that led to my solution. jscad/csg#53

@MatzeS please review the changes in pull request aa

Solved with #535