Turn on PUT/DELETE verbs for MVC

Just wondering how we go about making MVC honor PUT/DELETE HTTP verbs. I think at one time we had to uninstall WebDAV and change the web.config. Would that method still apply to Core on IIS Express? My code now uses POST just fine but just switching over to PUT (HttpPut attribute and setting method="put") causes the request to go to the HttpGet method.
Thanks!

@chassq all HTTP verbs are supported by MVC. Can you show your code and show what doesn't work?
If you're using IIS and you have some IIS modules or settings that prevent ASP.NET Core from seeing those verbs, of course you'll need to change those settings 😄

Sounds like #5038?

Hey,
Included an attached zip with src but in short I simply created a new ASP NET Core web application and did the following:

Created a ViewModel with one public property
Create 3 action methods in a controller. Each had its own allowed verb attribure (HttpGet, HttpPut and HttpPost). Also added a route attribute for each action method all named the same (e.g. 'testme'). The ViewModel in the input parameter for the put and post action methods.
Created a single view that switched from a view of the post or put html form based on a number I passed in via the ViewBag.

When I first hit the testme url the HttpGet invokes as expected. I am initially presented with the Html Form I configured for PUT, which is correct. However, when I hit the put submit button it looks like all the parameters are all on the query string? I tried to use the FromForm attribute on the action method input param but got the same result. So I reconfigured my test by showing the post form initially instead of the put form. When I hit the post form submit button everything works as expected. I post right to the HttpPost configured action method.
Am I doing something wrong?
WebApplication7.zip

@javiercn can you take a look and see if it's related to https://github.com/aspnet/Mvc/issues/5038 ?

Hi,
I tried with fiddler and it works fine for me, so I doubt its #5038. I tried to see what your repro is doing and it is sending a get request. I believe web browsers don't understand other verbs than get and post, so  given a put method, the browser defaults to get. See https://www.w3.org/TR/html401/interact/forms.html#h-17.13.1 for details
I don't think there is any work/issue here.

Ah, that must be it.
Found this bug was being tracked ( https://www.w3.org/Bugs/Public/show_bug.cgi?id=10671 ) but is now flagged as resolved/wont fix.
I will close this issue.


SynchronizationLockException in DefaultHttpClientFactory.CleanupTimer_Tick

Came across a threading bug when running a long test suite on a slow CI server. Using xuint, netcoreapp2.1, and ubuntu 16.04 x64.
[18:36:59]	[test] The active test run was aborted. Reason: Unhandled Exception: Unhandled Exception:
[18:36:59]	[test] Unhandled Exception: Unhandled Exception: System.Threading.SynchronizationLockException: Object synchronization method was called from an unsynchronized block of code.
[18:36:59]	[test]    at System.Threading.Monitor.Exit(Object obj)
[18:36:59]	[test]    at Microsoft.Extensions.Http.DefaultHttpClientFactory.CleanupTimer_Tick(Object state)
[18:36:59]	[test]    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
[18:36:59]	[test] --- End of stack trace from previous location where exception was thrown ---
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.CallCallback()
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.Fire()
[18:36:59]	[test]    at System.Threading.TimerQueue.FireNextTimers()System.Threading.SynchronizationLockException: Object synchronization method was called from an unsynchronized block of code.
[18:36:59]	[test]    at System.Threading.Monitor.Exit(Object obj)
[18:36:59]	[test]    at Microsoft.Extensions.Http.DefaultHttpClientFactory.CleanupTimer_Tick(Object state)
[18:36:59]	[test]    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
[18:36:59]	[test] --- End of stack trace from previous location where exception was thrown ---
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.CallCallback()
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.Fire()
[18:36:59]	[test]    at System.Threading.TimerQueue.FireNextTimers()
[18:36:59]	[test] System.Threading.SynchronizationLockException: Object synchronization method was called from an unsynchronized block of code.
[18:36:59]	[test]    at System.Threading.Monitor.Exit(Object obj)
[18:36:59]	[test]    at Microsoft.Extensions.Http.DefaultHttpClientFactory.CleanupTimer_Tick(Object state)
[18:36:59]	[test]    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
[18:36:59]	[test] --- End of stack trace from previous location where exception was thrown ---
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.CallCallback()
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.Fire()
[18:36:59]	[test]    at System.Threading.TimerQueue.FireNextTimers()
[18:36:59]	[test] System.Threading.SynchronizationLockException: Object synchronization method was called from an unsynchronized block of code.
[18:36:59]	[test]    at System.Threading.Monitor.Exit(Object obj)
[18:36:59]	[test]    at Microsoft.Extensions.Http.DefaultHttpClientFactory.CleanupTimer_Tick(Object state)
[18:36:59]	[test]    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
[18:36:59]	[test] --- End of stack trace from previous location where exception was thrown ---
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.CallCallback()
[18:36:59]	[test]    at System.Threading.TimerQueueTimer.Fire()
[18:36:59]	[test]    at System.Threading.TimerQueue.FireNextTimers()
[18:36:59]	[test]
[18:37:00]	[test] Test Run Aborted.

Thanks, this looks like something we need to dig into.

Fixed by #153  - the PR has the wrong issue reference


Vectors

Vectors represent the "nouns" of your manifold universe. They are the entities on whose behalf you can roll up metrics, like a Page or a Campaign.
To add a vector to your umbrella, run manifolds vectors add page.
This will generate a config file in your vectors/ directory that you can fill out like so:
attributes:
  published_at: TIMESTAMP
  title: STRING

You can express the vectors you'd like to intersect in your manifold.yml like so:
vectors:
  # List the vectors you want to include in this manifold
  # Example:
  - page

Then when you run manifolds generate, your dimensions schema is generated from the vectors you specified.

Oh yeah. @tylr, I don't quite grasp the point about the "projects" hardcoding. I view that as an opinionated point of structure. Because it's strict, I'd think we could test it explicitly. Open to your thoughts.


Autocomplete not working on Debian 11 and nvim.appimage v0.9.1

Describe the bug
Autocomplete not working on Debian 11 and nvim.appimage v0.9.1. I've tried on 2 debian 11 installation and it doesn't work.
To Reproduce

apt-get install nodejs, npm, gcc, build-essential, python3-pip.
Download nvim.appimage v.0.9.1, create link in /bin.
Get kickstart.nvim code from here.
Run nvim
Run :MasonInstall intelephense.
Open my php file, type what's on 1 line above, ..
But no autocomplete, at all.

Desktop

OS: Debian 11
Terminal: SSH-ing, with /bin/bash

Neovim Version
NVIM v0.9.1

Hi!
I'm sorry you're having trouble, however the problem you cite is with the PHP language server specifically. Please report an issue on their repo.
I note that while it being an LSP it should be possible to get PHP autocomplete working with this tool, a quick google reveals many forum posts asking the same question.
I'm closing this because it's not actually a kickstart.nvim issue - Thanks for the report and good luck!

Thanks for the answers, I've got it working on debian 11. The problem is not with the PHP language server, but the nodejs and npm packages. When I use newest node packages (node v20.5.0, npm v9.8.0), everything work as intended.
Thanks again for this useful project! :)


Extraction Error

ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 905, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 820, in _extract_signature_function
res = self._parse_sig_js(code)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 883, in _parse_sig_js
initial_function = jsi.extract_function(funcname)
File "/usr/lib/python2.7/dist-packages/youtube_dl/jsinterp.py", line 241, in extract_function
raise ExtractorError('Could not find JS function %r' % funcname)
ExtractorError: Could not find JS function u'Bn'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError(u"Could not find JS function u'Bn';

Carefully read new issue template and provide all requested information.


#104 add tests for debug, ordering and meta

Fixes #104

@Yegorov @tank-bohr please review

@Yegorov fixed

@yegor256 please check

@Suban05 thanks!

@Yegorov 🌟 Great job on the review! You've earned +4 points, boosting your impressive total to +448. Keep up the excellent work!

@Suban05 🎉 Awesome contribution! You've earned +13 points: +4 base + +9 for 182 hits-of-code. Your dedication is invaluable. Keep up the great work! Current balance: +576. Looking forward to more from you!

@tank-bohr Hey there, awesome job on the review! 🎉 You've snagged +4 points, which is pretty cool considering the intricate bonus system we've got. Even though it wasn't your own code (no 24-point deduction!), you still earned some points. Your total balance is now at +133. Keep up the great work, and who knows? Next time you might hit that max 24-point bonus!


[android] Mark Interpreter/async as an executable test.

Tests that need to execute need to be marked as such so they can be
skipped in platforms that are cross-compiled and do not have a target
platform available.
This situation happens in the Android CI machines.
Introduced in #34746.

@swift-ci please smoke test


3d model

if the cartograper can save a 3d point cloud model of the scanning room , how do it?

The primary output of Cartographer is a trajectory. From the trajectory, you can use the collected sensor data to generate a point cloud.
cartographer_ros/assets_writer_main can be used to construct point clouds from the results of the /finish_trajectory service. You can view the generated points clouds using the point_cloud_viewer.


Unit test error

I get this error on my laptop
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=320m; support was removed in 8.0
Running org.apache.camel.idea.completion.extension.YamlPropertyPlaceholdersSmartCompletionTestIT
log4j:WARN No appenders could be found for logger (#com.intellij.util.ui.JBUI).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.998 sec <<< FAILURE! - in org.apache.camel.idea.completion.extension.YamlPropertyPlaceholdersSmartCompletionTestIT
testCompletion(org.apache.camel.idea.completion.extension.YamlPropertyPlaceholdersSmartCompletionTestIT)  Time elapsed: 2.674 sec  <<< ERROR!
java.lang.RuntimeException: Cannot load resource: /idea/IdeaApplicationInfo.xml
	at org.apache.camel.idea.completion.extension.YamlPropertyPlaceholdersSmartCompletionTestIT.setUp(YamlPropertyPlaceholdersSmartCompletionTestIT.java:31)
Caused by: java.io.FileNotFoundException: /idea/IdeaApplicationInfo.xml
	at org.apache.camel.idea.completion.extension.YamlPropertyPlaceholdersSmartCompletionTestIT.setUp(YamlPropertyPlaceholdersSmartCompletionTestIT.java:31)

Results :

Tests in error:
  YamlPropertyPlaceholdersSmartCompletionTestIT>UsefulTestCase.defaultRunBare:372->setUp:31->LightCodeInsightFixtureTestCase.setUp:113 » Runtime

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

I wonder if that /idea/IdeaApplicationInfo.xml path is some hardcoded value to refer to the root folder?

Also when the test runs it complain about log4j, maybe try to find out to add a src/test/resources/log4j.properties file the test can use

did you run the install-intellij-libs.sh again after your merged?

Yes it has installed those JARs

I ran
 ./install-intellij-libs.sh 2016.3.2 /Applications/IntelliJ\ IDEA.app/Contents/

I wonder if this has something to do with the version of IDEA you have installed. Because the /idea/IdeaApplicationInfo.xml is not a file I remember from any places

Its the latest ultimate version 2016.3.2

I'm using the community edition and the same version is downloaded on Travis CI.
Could you try that and re-run the install-intellij-libs?

I get the same error with the Ultimate version

I have something working on my machine now with Ultimate version.
It turned out I need to remove the " -Didea.platform.prefix=Idea" from args line and add 2 other dependencies

  <groupId>com.intellij</groupId>
  <artifactId>jsp-api</artifactId>
  <version>${idea.version}</version>
  <scope>test</scope>
</dependency>
<dependency>
  <groupId>com.intellij</groupId>
  <artifactId>idea-jsp-openapi</artifactId>
  <version>${idea.version}</version>
  <scope>test</scope>
</dependency>

I haven't tested how it works with the community version, because the "-Didea.platform.prefix=Idea" was a requirement to run the test from maven
Go figure!

And then it starts :

[WARNING] The POM for com.intellij:jsp-api:jar:2016.3.2 is missing, no dependency information available
[WARNING] The POM for com.intellij:idea-jsp-openapi:jar:2016.3.2 is missing, no dependency information available

This is not part of the community version 👎

We could setup a profile for those are using the Ultimate version and include the missing dependencies? So default behaviour is for the community version
What do you think @davsclaus ?

@fharms +1 for a profile.
Maybe down the road will should point the Jetbrain guys to here so they can see some of the good, bad, and ugly for plugin developers.


Add Red Hat OpenShift on AWS Service

Feature Request
Adding AWS Managed OCP service
Description of Problem:
Add first managed service to extend contribution beyond self managed OpenShift. The TF module for ROSA is new and in Tech Preview, as part of this issue we should investigate its use.

Announcement blog for the ROSA TF provider
Link to ROSA TF Registry
Link to ROSA Cluster Module
Could we use a combination of the ROSA TF module and Ansible to create the cluster and then apply the required policies? Could this be done by using the Ansible TF Module


Fix for #3991 bitstamp v2 API should be taking UUID nonces

Hi All,
So this is a fix following the discussions in #3991
It was a bit more complex than expected, here are some of the subtilities.

We need both a UUID Nonce Factory and a millisecond time stamp (as string) factory because both are required in the requests.
I had to write a new BitstampDigestV2 because it changed completely from V1.
All the authentication stuff is now in HeaderParams and not FormParams
The content-type CANNOT be present if there is no body to the requests, hence the move of @Consumes(MediaType.APPLICATION_FORM_URLENCODED) from the top to the individual functions (when necessary). It's also taken into account into the BitstampDigestV2 which includes it or doesn't include it for the signing process.
Introduction of apiKeyForV2Requests as the api key for requests (and signing) must now be "BITSTAMP " + apiKey.

I also cleaned/standardized some stuff when different calls where using this.apiKey or exchange.getExchangeSpecification().getApiKey()
Otherwise it passes all my tests (with a real bitstamp account behind) namely :

get funding history
get open orders
get order books
get balances
place and cancel limit order
get pairs list (and meta)
get currencies list (and meta)

(Which is all the functionalities I'm using in my app)
All the xchange standard tests are also passing (with some deprecation notices for bitstamp v1 obviously)
Eventually we will have to get rid of all the V1 stuff and this would bring some nice cleaning (I didn't find when exactly the V1 will stop working on bitstamp thou .. I'm not exactly sure what functionality is still missing from V2 in comparison to V1 and if it will be possible to emulate it or just remove it.
You can find documentation about the new authentication method here
Let me know if it's all OK for you ?

Thank you for the effort on this, this is awesome, I have just one comment.

Voilà I removed all the debug prints ...
I'm happy I can help, this project is great and has helped me a lot, so it's cool if I can contribute back ..


[Bug] conv2d produced inconsistenct inference results with PyTorch

Actual behavior

Steps to reproduce
import torch
from tvm import relay
import tvm
import numpy as np
from torch.nn import Module

input_data = torch.randn([1, 256, 56, 56], dtype=torch.float32)
para_1 = torch.randn([512, 256, 1, 1], dtype=torch.float32)
para_2 = None
para_3 = (2, 2)
para_4 = (0, 0)
para_5 = (1, 1)
para_6 = 1
class conv2d(Module):
    def forward(self, *args):
        return torch.nn.functional.conv2d(args[0], para_1,para_2,para_3,para_4,para_5,para_6,)

m = conv2d().float().eval()

torch_outputs = m(input_data)

trace = torch.jit.trace(m, input_data)
input_shapes = [('input0', torch.Size([1, 256, 56, 56]))]

mod, params = relay.frontend.from_pytorch(trace, input_shapes)
print(mod)
with tvm.transform.PassContext(opt_level=3):
    exe = relay.create_executor('graph', mod=mod, params=params, device=tvm.device('llvm', 0), target='llvm').evaluate()

input_tvm = {'input0': np.array(input_data, dtype='float32')}
tvm_outputs = exe(**input_tvm).asnumpy()

np.testing.assert_allclose(torch_outputs, tvm_outputs, rtol=1e-5, atol=1e-5)   # threshold is the same with that in equipped test cases in tvm repository

Triage

needs-triage
frontend:pytorch

Which version of PyTorch did you use? I'm using pytorch 2.0.0 and TVM with commit id b6502f4e278da391719155936aeefb6544115c1f. But I cannot reproduce this result inconsistency.

Thanks for your comments!  @haoyang9804
I also used pytorch2.0. However, this bug was found in an earlier TVM version(git e280e01).
This bug may have been fixed bug some others.


Are there any naming rules for primary constructors?

Type of issue
Missing information
Description
I wonder whether any naming rules are considered for primary constructors? public class Entity(Dependency dependency) vs public class Entity(Dependency _dependency) ? (refer to Private instance fields start with an underscore (_) and the remaining text is camelCased.)
Page URL
https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names
Content source URL
https://github.com/dotnet/docs/blob/main/docs/csharp/fundamentals/coding-style/identifier-names.md
Document Version Independent Id
7f85babc-6295-21dd-f194-dede663f9966
Article author
@BillWagner
Metadata

ID: a2d591be-290e-62d1-e99a-a7d26af20ef8
Service: dotnet-csharp
Sub-service: fundamentals

Hi @DmitryLukyanov
We haven't developed these yet. It's under discussion.
I'll leave this open for future updates.


helm: make istiod chart consistency with istioctl

Please provide a description of this PR:
When a wildcard gateway is defined along with a virtual service with an empty string in the hosts list, istiod (release 1.17.2 but the code is the same with the newer releases) panics when trying to build the gateway http routes. This effectively allows a single mal configured VirtualService to bring down the entire control plane.
This PR currently only adds offending test cases (which should panic) as I'm not certain how to proceed (and whether or not this a security issue):

Either we make the function admit an empty string
Or should we add validations into buildGatewayHTTPRouteConfig to drop those cases.

For easier reproduction incluster:
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: default
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: http
      number: 80
      protocol: HTTP
---
kind: VirtualService
metadata:
  name: foo
  namespace: foo
spec:
  gateways:
  - istio-system/default
  hosts:
  - ""
  http:
  - route:
    - destination:
        host: foo
        port:
          number: 80
---
# Not sure if the following is required
kind: VirtualService
metadata:
  name: bar
  namespace: bar
spec:
  gateways:
  - istio-system/default
  hosts:
  - bar.example.com
  http:
  - route:
    - destination:
        host: bar
        port:
          number: 80

Hi @ichbinfrog. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This should have caught by virtual service validation. I see this error
admission webhook "validation.istio.io" denied the request: configuration is invalid: empty domain name not allowed
Did you enable validation webhook?

My bad @ramaraochavali , I did not have the validation webhook enabled in our clusters.
Despite disabling the validating webhook having high impact on the stability of istiod, it does not seem to be documented in the istiod helm chart nor set as a default value. If you don't mind, I'll open a PR to address it

updating documentation is fine but changing the default we need @istio/wg-environments-maintainers  opinion also

@ichbinfrog did you install istio via helm-chart?

updating documentation is fine but changing the default we need @istio/wg-environments-maintainers opinion also

Agreed, then I'll switch this PR to that purpose.

@ichbinfrog did you install istio via helm-chart?

Yes, istiod is installed via the helm chart version 1.17.2 with a minimal values file:
global:
  variant: distroless
  defaultPodDisruptionBudget:
    enabled: true
  proxy:
    excludeOutboundPorts: "5432,6379"
    resources:
      requests:
        cpu: "20m"
        memory: "64Mi"

@ichbinfrog did you install istio via helm-chart?

Yes, istiod is installed via the helm chart version 1.17.2 with a minimal values file:
global:
  variant: distroless
  defaultPodDisruptionBudget:
    enabled: true
  proxy:
    excludeOutboundPorts: "5432,6379"
    resources:
      requests:
        cpu: "20m"
        memory: "64Mi"

I think it's reason to add configValidation: true in istiod chart's values file, that will keep consistency bewteen istioctl and helm chart installation.
would you like to send an PR for that?

Sure thing @zirain , I've updated this PR accordingly 🙏

@ichbinfrog: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ichbinfrog: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test unit-tests-arm64

release-notes_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ichbinfrog: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test unit-tests-arm64

release-notes_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test release-notes

gencheck_istio
2dd78a9b92806ebcba9cad0df114d712428a6bf2
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I put a hold since this looks sensitive and I would like to review it. However, I am coming off some time up so have a lot of PRs in the queue -- I will try to get to this asap in 1-2 days

I don't think this is quite right. We document what to do, just poorly. I opened istio/istio.io#13420 to make the docs more correct.
I also think we should probably make the default defaultRevision default (wow, what a confusing sentence!)
Thoughts @Monkeyanator @jacob-delgado ?

did I miss something? this's not things about revision, it's about configValidation(webhook).

webhook is configured properly as long as you set default revision
On Tue, Jun 20, 2023, 5:25 PM zirain @.***> wrote:

I don't think this is quite right. We document what to do, just poorly. I
opened istio/istio.io#13420 https://github.com/istio/istio.io/pull/13420
to make the docs more correct.
I also think we should probably make the default defaultRevision default
(wow, what a confusing sentence!)
Thoughts @Monkeyanator https://github.com/Monkeyanator @jacob-delgado
https://github.com/jacob-delgado ?
did I miss something? this's not things about revision, it's about
configValidation(webhook).
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/45544#issuecomment-1599769370, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXO7XI2VXFIALGV6NGDXMI5PJANCNFSM6AAAAAAZL47KJU
.
You are receiving this because your review was requested.Message ID:
@.***>

here's my question: why there's another webhook here: https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/templates/validatingwebhookconfiguration.yaml

here's my question: why there's another webhook here: https://github.com/istio/istio/blob/master/manifests/charts/istio-control/istio-discovery/templates/validatingwebhookconfiguration.yaml

istio-validator-xxx is more like a webhook for a specific revision, served per-revision basis. If you install a control-plane with revision, this will be installed. istio-default-validator is more like a default webhook for resources.

So https://github.com/istio/istio/blob/5ddb5c94c424eeafb7040e0d21008c7aee42dc82/manifests/profiles/default.yaml#L92 is set when using the default profile for istioctl. This makes sense for us to also set for the helm chart since it's not set and is false by default. I just don't know when you'd want to set configValidation to false. It may be better for us to never allow users to set this, but I'd have to get @howardjohn to comment on this.
The PR changed since it was originally put up. Can you update the original description @ichbinfrog ?


add upgrade link to public dashboard

Fixes #12929

NEWS.md missing
Frontend and Backend tests missing (this might not be related to the bugfix)
good to have the new view added to the suite, but I think it should be added as a new spec (we're not testing wether it works when it should work, but given isCloseToLimits it works always)

Retest this, please

Retest this, please 🎉

@elenatorro bump assets and 🚢 🇮🇹
the quota attributes in the spec are not needed anymore


add chinese version

#1290

Please check CI

we need to update the REAME_CN.md too
https://github.com/apache/incubator-apisix/blob/master/README_CN.md#快速上手

many thanks,  merged already


Update AudioRecorderManager.m to include requiresMainQueueSetup

This commit handles the yellow warning bubble that pops up at app restart.

Guys, can we merge this please?

@jsierles Can we merge this? This is a pretty straightforward edit.

Could this be merged?

What's blocking this PR from being merged?

pls merge this PR

Could you please merge this PR?


 E.g. if we update the ToS in a way that everyone has to agree, this allows us to "gate" users so that they have to complete some actions berfore continuing onto the platform.
We now want to add a new jail feature; that basically allows the moderators (admins/superusers) to display a note to users that they have to agree to before continuing. This would for example allow us to give warnings to users and force them to read and accept them before continuing.

Closed in #4476


Error when compile and execute

Good Morning.
Today I probe your repository but when I install  the app return an error, the error is follow:
çFATAL EXCEPTION: main
Process: com.nucu.dynamiclistcompose, PID: 21616
java.lang.IllegalStateException: The NavDeepLink must have an uri, action, and/or mimeType.
at androidx.navigation.NavDeepLinkDslBuilder.build$navigation_common_release(NavDeepLinkDslBuilder.kt:60)
at androidx.navigation.NavDeepLinkDslBuilderKt.navDeepLink(NavDeepLinkDslBuilder.kt:26)
at com.javi.places.page.impl.destinations.PlacesPageDestination.getDeepLinks(PlacesPageDestination.kt:33)

Hello! Thank you very much for looking at the repository! This is a problem that is already reported at https://github.com/raamcosta/compose-destinations/issues/178.
My recommendation is that you delete the build directory of the following modules and rebuild project:

cards-page
home
places-page
product_detail

Let me know if that solves the problem. For now, this issue is out of reach and most likely it will migrate to another navigation system.


[botan] Test master (3.0.0) branch

What does your PR fix?
This PR tests building the botan master branch which will eventually become version 3.
Major changes: https://botan.randombit.net/news.html#version-3-0-0-not-yet-released (toolchain requirements, some headers removed or made private, botan-3.pc).
This is a playground for potential upstreaming of necessary changes.
This version seems to need at least gcc 9 on linux.

Which triplets are supported/not supported? Have you updated the CI baseline?
WIP

Does your PR follow the maintainer guide?

I am still working on this PR.

Resolved by #33424.


what is the reason that the draft can not be reused after finishDraft?

🙋♂ Question
I  want to reuse the draft after finishDraft , is it possible?  and can I use draft to render react component?

If you're using the createDraft/finishDraft combo, I think using the state passed to createDraft and the result of finishDraft is enough.


render_actions vs renderActions ?

I just noticed you mention renderActions in the common card ui generator, and then render_actions in the card ui generators, what's the difference?
What I want to achieve is to create a dynamic dropdown (fetch from a database and based on the selection display a list of items).
The problem is I can't get the onChangeAction to work this is on my home card so I configured the action to trigger the function of my home card.
              {
                widgets: [
                  {
                    selectionInput: {
                      type: 'DROPDOWN',
                      name: 'projects',
                      label: 'Select project',
                      items: projects.map((project) => ({
                        text: project.name,
                        value: project.id,
                        selected: project.id === selectedProjectId,
                      })),
                      onChangeAction: {
                        function:
                          'https://xxxxxxxx/onCalendarHomePageOpen',
                        parameters: [],
                      },
                    },
                  },
                ],
              }

I see this error:

Cannot find field: action in message google.apps.card.v1.SubmitFormResponse

Then I add render_actions and the onChange works, but the rest state breaks.
This same thing happens when I try to navigate back to the home card from another one.
Tried with updateCard instead of pushCard but no luck.
Thank you very much

I could find more information here:
https://codelabs.developers.google.com/codelabs/workspace-add-on-nodejs-cloudrun#5
I hope this is useful for someone else. Still not sure whats the difference between render_actions and renderActions, and when to use renderActions at all.

I do not think this was intentional @PierrickVoulet . If they are treated the same, we should pick one of them which seems to be renderActions based on our alternative runtimes docs.
I will test and create a PR to update the code. Thanks for flagging @llermaly and @PierrickVoulet


Feature | AKV Provider Upgrade to use new Azure key Vault libraries

Addresses #294
Changes full design and introduces new constructors to accept implementation of TokenCredential to support new libraries.
Breaking Changes:

Drops support for .NET Framework 4.6, supports .NET Framework 4.6.1+
Drops support for old constructors that accepted "AuthenticationCallback".

cc @xtrimmer
[6 Aug, 2020] Update:
The old constructors are now removed totally and driver does not implement/support authentication callback in new design now. For user applications willing to support multi-user credentials for acquiring tokens, can implement a custom TokenCredential class with their own logic in "GetToken" and "GetTokenAsync" APIs. An example has been added (doc/samples/AzureKeyVaultProviderLegacyExample_2_0.cs) to the repository to demonstrate the same, will be published to Microsoft Docs.

I believe the reason of synchronous methods only is the class SqlColumnEncryptionKeyStoreProvider.
I think it would be possible to extend this to also support counter Async APIs, @Xtrimmer any thoughts?


modals tested on large and small ios screens

carson, this could use a look on android when you have some minutes

you have a few to try this out on android carson?


cilium: initial work for nodeport via tunneling

See commits, /cc @brb.

This change is

test-me-please

Coverage decreased (-0.01%) to 44.243% when pulling dd91b26b09cb53bb551c2e93b1c9e05229ba7ff9 on pr/nodeport-tunneling into 6314e58cd8a31503c47c40b7c4d46de8089cf0dc on master.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add xo from template
chore(package): add nyc from template
docs(package): remove keyword null
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #576   +/-   ##
======================================
  Coverage    94.4%   94.4%
======================================
  Files           7       7
  Lines        1073    1073
======================================
  Hits         1013    1013
  Misses         60      60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e80cdd2...74837bd. Read the comment docs.

Coverage remained the same at 93.103% when pulling 74837bd9f6d58b5b04a04b1980845ac06b1932c7 on template-sync-1 into e80cdd2b7aa1058c874da20260c9c0816d4c7319 on master.


fix(joy_controller): joy_type is only set from the param.yaml file

Description
Part of:

https://github.com/autowarefoundation/autoware.universe/issues/6473

Related:

https://github.com/autowarefoundation/autoware.universe/pull/6217

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota @satoshi-ota I've looked for all the references of this joy_type parameter and it is not referenced by any other launch file.

If someone wants to set this parameter, they should use the param.yaml file as planned.
Please review :bowing_man:

@rej55 @satoshi-ota @shmpwk @taikitanaka3 @TakaHoribe @takayuki5168 @tkimura4
Could you review as a code owner? I would like to merge this as soon as possible and make the action required.

@xmfcx
This package should be optionally launched, separate from Autoware, if we would like to control from joy.
The launch command is like following.
ros2 launch joy_controller joy_controller.launch.xml joy_type:=G29

As you can see, we would like to launch joy_controller with joy_typeargument, so joy_type should be able to change dynamically.

@rej55 you can call it like:
ros2 launch joy_controller joy_controller.launch.xml config_file:=/path/to/config-file.params.yaml
And set it in the .param.yaml file.
Why is this not enough?

@xmfcx
Thank you for your suggestion.
It seems okay for me.
I will ask the user of this package.
Could you wait?
(It may take a while to reply because it is a holiday... 🙇)

Another option would be to create a second launch file, called joy_controller_no_yaml.launch.xml or joy_controller_direct_params.launch.xml.
And this new launch file wouldn't use the param.yaml at all. All params would be set in the launch file.
By default we would use the joy_controller.launch.xml and for convenience, you could use the joy_controller_no_yaml version.
What do you think?

I agree launching joy_controller with

ros2 launch joy_controller joy_controller.launch.xml config_file:=/path/to/config-file.param.yaml

I think it would be better to add instructions on how to launch it to the README for previous users.

@xmfcx
Thank you for waiting, the users also agreed the following suggestion;

If necessary, we can generate 4 param.yaml files for each joystick type, would this be alright?

Could you make these parameter files and add instruction to README?

@rej55 @shmpwk I've updated the README and the param files and the launch file.
Also added a new simple launch file to make everyone happy.
# With default config (ds4)
ros2 launch joy_controller joy_controller.launch.xml

# Default config but select from the existing parameter files
ros2 launch joy_controller joy_controller_param_selection.launch.xml joy_type:=ds4 # or g29, p65, xbox

# Override the param file
ros2 launch joy_controller joy_controller.launch.xml config_file:=/path/to/your/param.yaml

The old users can make use of the new joy_controller_param_selection.launch.xml launch file to select a config easily from the terminal.
The default launch file makes use of the param files as agreed.

@rej55 @shmpwk ready for review again.


Please add zmscore

Version: 3.5.3
Platform: Python 3.8
Description:
Dear Redis-Py Maintainers,
I love your work and use it in multiple big projects for coronavirus and algotrading stocks.
Recently I found a use for one of the new 6.2 commands called ZMSCORE and request we add it:
Here's a minimal test case:
from redis import Redis
def test_zmscore():
    r = Redis()
    r.zadd("hall_of_fame", {"alice": 1.0, "bob": 2.0})
    scores = r.zmscore("hall_of_fame", "alice", "bob")
    return scores

if __name__ == "__main__":
    scores = test_zmscore()
    assert scores == [1.0, 2.0]

Here's the current output of the failing test case:
AttributeError: 'Redis' object has no attribute 'zmscore'

I'd like to add this myself but unfortunately I'm new to the codebase.
What is the most efficient way to add new commands?
Happy holidays,
Bion

Hello.
Thanks for pointing it out. I try to add support to this command and others new in 6.2 step by step.
But I assume @andymccurdy will tag a new release AFTER redis 6.2 stable build is out (which may take a long time).

Available in the latest master, and will be in the upcoming release. Closing.


Add influxdb support

Change Summary
Adds support for Telegraf configuration to stream to InfluxDB from EOS devices.
This is a Draft PR, as a placeholder to track progress on this work. Not ready for review yet.

Related Issue(s)
Fixes #2464
Component(s) name
arista.avd.eos_cli_config_gen
arista.avd.eos_designs
Proposed changes

How to test

Checklist
User Checklist

N/A

Repository Checklist

[ ] My code has been rebased from devel before I start
[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and documentation have been updated accordingly.
[ ] I have updated molecule CI testing accordingly. (check the box if not applicable)

Closing stale PR. Feel free to open a new one if this becomes relevant again.


DEP Update JS dependencies

Issue https://github.com/silverstripeltd/product-issues/issues/505

Closed in favor of https://github.com/silverstripe/silverstripe-webauthn-authenticator/pull/101


"Fix animal count" integration

Integrates my FixAnimalCount mod
plus some small changes in order to compile in debug

Thank you, should be added in 41174a8


Remove black background from 3d object

Hello,
I am using ModelScreen.js example in my app. And everything is running perfectly.
But there is an issue with the background of the 3d object. When I set backgroundColor to 'transparent'
or remove at all the backgroundColor property. The black box still appears. Is there a way to remove this black background and to make it transparent?
I have attached an image how it looks on my android emulator under windows machine.

backgroundColor: transparent is unfortunately not possible on android. This is due to the OpenGL scene that has black as default background.


Make the library portable and upgrade to .NET 4.6 / Visual Studio 2015

Unfortunately the IsAssignableFrom method is not available for .NET 4.5 (or 4.5.1) Portable Class Libraries.
To make CSharpMonad be a portable class library, we'll have to upgrade it to .NET 4.6 and a minimum of Visual Studio 2015. The advantage is that this library will be available for all Windows Universal 10 apps (which includes all the platforms listed here); the disadvantage is that the library wouldn't be available to code using less than .NET 4.6.
What do you think--is this tradeoff acceptable?

You can use Type.GetTypeInfo().IsAssignableFrom(...), I had to do that for my language-ext project when I made it support dnxcore50, net45, net46, dnx451anddnx461`.
GetTypeInfo is an extension method, you must be using System.Reflection.
Just had a quick flick through the changes.  What's the string / IEnumerable<char> stuff about?  Do you have a reference to why that's necessary?  It seems a bit 'odd'.  Sorry I don't have much time to dig into it myself right now, super busy with other projects...
To be honest I'd rather do the work to make this use project.json and build that way than modify the existing sln/csproj.  Primarily because it automatically builds all of the artifacts needed to push to nuget, and supports multiple frameworks.
I have been putting it off after the horror experience of migrating language-ext.  Well, I say after, it's still in progress - that's weeks of my life I won't get back!).  Still, it seems to currently be the best route to getting DLLs that can be used in W10 (as well as cross platform).

Thanks for the tip, that fixed the issue! The pull request now depends on .NET 4.5.
No worries! Here is a Stackoverflow answer describing the string / IEnumerable<char> stuff.
If I understand you correctly, you're saying that you would rather modify the existing project than re-create it as a portable class library project, because the original project file had some really convenient features. I can look into doing that instead but I'm not familiar with that way of doing things (I'm pretty new to all this Windows Universal stuff), so I probably won't be able to actually make those changes for quite a while.
In any case, I don't want to put pressure on you to merge the pull request. Do whatever is best for you, don't stress out about it please.

@ApocalypticOctopus - Just to let you know, I haven't forgotten!  Still in the midst of a big roll-out at work, so my OS work is on the back burner atm.

@louthy Thanks for the info! I totally understand.

@ApocalypticOctopus Sorry, I had forgot.  Merged now ;)

No worries, thank you! :+1:


no download available for window tool chain

https://dl.espressif.com/dl/esp32_win32_msys2_environment_and_toolchain-20170111.zip
though I tried to download through above link, no download process is initiated and always showed me "Problem loading page" as if the link is down. Has anybody encountered this recently?

https://esp-idf.readthedocs.io/en/latest/get-started/index.html#setup-toolchain

Thanks. I think there was a problem with my laptop. When I tried in my desktop it worked fine.


unable to build and deploy latest version due to docker issue

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Try to build by launching a build and deploy action
works locally not on github

Expected behavior
Build and deploy
Desktop (please complete the following information):
Github only
Additional context
https://github.com/Capsize-Games/airunner/actions/runs/4584490627/jobs/8096005434

fixed in latest build


Add sctp and sodium

    Warning: Package 'sctp' has an incorrect structure. It should contain a single directory hierarchy for source files, named 'sctp', but file 'test_send_congestion.nim' is in a directory named 'tests' instead. This will be an error in the future.
      Hint: If 'tests' contains source files for building 'sctp', rename it to 'sctp'. Otherwise, prevent its installation by adding `skipDirs = @["tests"]` to the .nimble file.

These need to be fixed.

Also got this error when installing sctp:
Error: Downloaded package's version does not satisfy requested version range: wanted >= 0.4.6 got 0.4.5

Oops, I forgot to make some pushes. It works now.


Either.sequence should return Either<Seq, Seq>

In the case of Either (as opposed to Try/Option) it makes sense to accumulate also the left values.
We recently added Either.sequence - it was forgotten. Because it is still not released, we are able to change the signature for the upcoming 0.9.1 patch release.
// current signature
static <L,R> Either<L, Seq<R>> sequence(Iterable<? extends Either<? extends L, ? extends R>> values) { ... }

// new signature
static <L,R> Either<Seq<L>, Seq<R>> sequence(Iterable<? extends Either<? extends L, ? extends R>> values) { ... }

Semantics: sequence collects all right values if all given Eithers are Right, else it collects all Left instances (if one or more Eithers are Left).

Both signatures are useful. I am using the first version quite extensively. I would strongly suggest that both be available.
Maybe the original can be made available through sequenceU which most closely matches scalaz Traversable type class.

@hamnis Thanks for your feedback!
I see no benefit in keeping the first suggestion Either<L, Seq<R>> sequence(...) or introduce Either<Seq<L>, R> sequenceLeft().
Having Either<Seq<L>, Seq<R>> sequence(...), we are still able to achieve the same result as above like this:
// if either.isLeft() == true, the Seq<L> is guaranteed to be non-empty
Either<Seq<L>, Seq<R>> either = Either.sequence(...);

// valid when either.isLeft() == true
L example1 = either.getLeft().head();

// valid in each case
either.mapLeft(seq -> {
    L example2 = seq.head();
    ...
});

Scalaz works different. Because Either resp. \/ is right-biased there, no implicit Applicative instance for the left case can be offered in scope. In Java we do not have these problems, so we can do both in one sequence step.
What are your 'main pain points' with that solution?

Having a result of type Either<Seq<L>, Seq<R>> makes most sense, because we cover all use cases.
If other sequence methods are needed, e.g. that return Either<L, Seq<R>> or Either<Seq<L>, R>, we should create a new issue.

I love the new sequence :)

I need that implementation to be monadic, so I guess i will have to keep my own version. It is more interesting to have the types align than the collection of all the errors, If i needed that I would use Validation.

Here is a version that is monadic:
public static <L, R> Either<L, List<R>> sequenceM(List<Either<L, R>> eithers) {
        return eithers.foldLeft(Either.<L, List<R>>right(List.empty()), (acc, item) -> acc.flatMap(list -> item.map(list::prepend))).map(List::reverse);
    }
```

@hamnis Good point, I see. We should add the monadic version, also. I will create a separate issue.
Do you have an example of types that would not align?

Any either where the next step would be to either work with the sequenced operation with the set Left side.
Here is a slighly adapted example from our codebase
OptionTEither is a Option MonadTransformer focused on Either.
OptionTEither.wrap(bankCustomer).flatMap(customer -> OptionTEither.<BankError, AccountInformation>lift(customer.getAccount()).flatMapF(acc -> {
            return sequence(documents.map(tuple -> tuple.apply((name, bundles) -> {
                return sequence(bundles.map(bundle -> createAgreementDocumentBundle(principal, bundle, acc.getNumber(), Option.none()))).map(list -> PDF.merge(name, list.flatMap(Function.identity())));
            })).toList()).map(Option::some);
        })).unwrap().flatMap(opt -> opt.toRight(BankError.internal("Customer or account not found")));

The returntype of the above Expression is: Either<BankError, List<AgreementDocument>>

@hamnis Thanks!


Add multi token support

Closes #9.
For now, I just implemented multi-token support by using different tokens per repository. So a single repository will be still fully downloaded by a single token. Downloading multiple repositories will use different tokens in round-robin.
The reason is because multi-token support will be implemented by @src-d/data-retrieval, I don't know yet the details, but once we have everything working properly with a single-token we'll think about it. Hence, I didn't want to change the interface of the library, in particular, the signatures of the exposed methods of the downloader, at least for now.
In contrast with this comment, I've added also parallelization per token. There's actually no reason to don't it.
This means that we already gain some performance improvement, but that the total time we'll still be dominated by the largest repo. The more the size of the repositories of an org is skewed the less is the gain in performance.

I reworked this to include:

correct logging of used rate (unless a reset occurs),
refactor for better readability.

This is the output in case of error:

This is the output using a single token:

This is the output using two tokens:

I'll run with our org just to see the speedup. As explained in the description, for this small org the improvement is not that sensible.

I see some design decisions that make the code more complicated but I'm not sure I understand why they are needed.

@smacker all issues should have been addressed! 👍

Rebased and force-pushed.

Closing and reopening as PR checks seem to be stuck.

@kyrcha I've added a test here.

Closing this in favor of #49.


[Fix] Don't display way too large files #1513

Fixes #1513
Obligatory screenshot:

Default is set to 8MiB (which would fit all 7 Harry Potter books in a single file, with newlines and paragraphs :laughing: )

@Unknwon Fixed :)

Thanks!


python3.pkgs.cmake: init stub at 3.26.4

Description of changes
I would like this to be as transparent as possible for Python packages, so I'm shadowing the top-level cmake attribute by using the same name as the PyPI package that this replaces.
As in https://github.com/NixOS/nixpkgs/pull/246963, a goal is to help with the rollout of https://github.com/NixOS/nixpkgs/pull/245509 by letting packages that depend on this in their builds to pass dependency validation.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This breaks torch right now, and I need to investigate.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2509


how to add proxy settings to SonarQube step STO-7306

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screenshot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65fda8c3ab32b224a28e165a--harness-developer.netlify.app


Request: list of configuration sections

There is currently no method that returns a list of the section names in the configuration.

I also needed this, added to my clone of this repo:
https://github.com/dmgolubovsky/mini
Please test it, if it also works for you let me know, I'll send a pull request to this repo.
Thanks.


Added tests for collection-utils methods replaceelementAt and length

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[x] Documentation updated (readme, docs, comments, etc.)
[x] Localization: No hard-coded error messages in code files (minimally in string constants)

@brandongregoryscott I have made the changes you requested. Please take a look when you get a chance.

Thanks for making those updates @SaidShah! Great work.

One other thing - I forgot to mention you didn't actually list the original issue in the description. Just make sure you're tagging the issue when you're going through the checklist next time 👍 thanks!


Revert "Lily/ClonesPlus.js -- Improve Performance of "when I start as...""

Reverts TurboWarp/extensions#1759
Someone on Discord already got an issue with it. It's breaking projects.
We need this merged ASAP
CC @SharkPool-SP
You got to be kidding me, it was working for ten people, why break now??

Wait don't revert it. I know the issue

Try again tomorrow

Try again tomorrow

I could of fixed it today

You can send it today and if you're really confident you could merge it again


[SPARK-45365][INFRA] Allow branch-3.4 daily test to use the new test group tags

What changes were proposed in this pull request?
This pr aims to allow branch-3.4 daily test to use the new test group tags.
Why are the changes needed?
Already backport SPARK-44034 to branch-3.4, new test tags can be used to reduce the average time consumption of daily tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Should monitor GA.
Was this patch authored or co-authored using generative AI tooling?
No

cc @HyukjinKwon @sunchao

Thanks @LuciferYang ! merged to master.

Thanks @sunchao @dongjoon-hyun

Thanks @sunchao @dongjoon-hyun


Mobcharge

Make mobs more powerful depending on distance from spawn
Two modes:

distance -- overall distance from spawn in any direction
depth -- depending on how deep from altitude zero, mobs are stronger, by an integer factor based on a floor of log10 of depth

Mainly a suggestion/request for comment at this point

A nice feature but not one I would include in the Mobs API... but, you could make a separate mod or use the on_spawn function for each mob to re-set the health and strength of each mob as it's spawned in world :)


Heroku environment down

The deployment https://jsonpath.herokuapp.com/ is down.
Related to #886

Down forever, heroku has shut down their free services from November 28, 2022. @psumiya has kindly provided an alternative, https://sumiya.page/jpath.html

I stood up an instance of the webapp on Fly.io - https://jsonpath.fly.dev/


cachedEventHandler opts.getKey is ignored

Environment
any
Reproduction
defineCachedEventHandler((event) => {
    // any code
}, {
    // ...
  getKey: (event) => {
    // ...
    return 'my.key'
  },
})

Describe the bug
The defiend getKey from opts is not used
Additional context
No response
Logs
No response

the issue is in the docs, as the getKey options is omitted
https://nitro.unjs.io/guide/introduction/cache#options


missing dependencies error

Rasa Core version:  0.7.5
Rasa Core version: 0.10.0
Python version: 2.7
Operating system: RHEL 6.8
Issue:
I am facing missing dependencies error.
Exception: Not all required packages are installed. Failed to find the following imports spacy, sklearn. To use this pipeline, you need to install the missing dependencies, e.g. by running:

pip install spacy==1.8.2 scikit-learn==0.18.1 scipy==0.19.0 matplotlib==1.5.3

Required dependencies are already installed under "/opt/rh/python27/root/usr/lib64/python2.7/site-packages" but rasa core is looking under "/opt/rh/python27/root/usr/lib/python2.7/site-packages"
I started /opt/rh/python27/root/usr/bin/python in interactive mode and tried import spacy , there is no error. Also i have been using rasa nlu for few months now and never faced any issues.
/opt/rh/python27/root/usr/bin/python -m rasa_core.run -d models/dialogue -u models/nlu/model_20171117-110732/
INFO:root:Rasa process starting
Using TensorFlow backend.
2017-11-29 23:20:26.434263: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2
DEBUG:pip.utils:bz2 module is not available
DEBUG:pip.utils:lzma module is not available
DEBUG:pip.vcs:Registered VCS backend: git
DEBUG:pip.vcs:Registered VCS backend: hg
DEBUG:pip.vcs:Registered VCS backend: svn
DEBUG:pip.vcs:Registered VCS backend: bzr
Traceback (most recent call last):
File "/opt/rh/python27/root/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/opt/rh/python27/root/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/run.py", line 126, in
cmdline_args.credentials)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/run.py", line 105, in main
agent = Agent.load(model_directory, nlu_model)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/agent.py", line 55, in load
_interpreter = NaturalLanguageInterpreter.create(interpreter)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 27, in create
return RasaNLUInterpreter(model_directory=obj)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 132, in init
self._load_interpreter()
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/interpreter.py", line 151, in _load_interpreter
os.environ))
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/model.py", line 225, in load
skip_valdation)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/model.py", line 248, in create
components.validate_requirements(model_metadata.pipeline)
File "/opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_nlu/components.py", line 92, in validate_requirements
"> pip install {}".format(" ".join(missing_requirements)))
Exception: Not all required packages are installed. Failed to find the following imports spacy, sklearn. To use this pipeline, you need to install the missing dependencies, e.g. by running:

pip install spacy==1.8.2 scikit-learn==0.18.1 scipy==0.19.0 matplotlib==1.5.3

Can you please run python -c "import os.path, rasa_core; print os.path.abspath(rasa_core.__file__)"

Also, it was mentioned in another issue that installing tensorflow-gpu helped.

Hi @tmbo ,
Here is output after running
/opt/rh/python27/root/usr/bin/python -c "import os.path, rasa_core; print os.path.abspath(rasa_core.file)"
Output : /opt/rh/python27/root/usr/lib/python2.7/site-packages/rasa_core/init.pyc
I am running rasa core on VM which does not have gpu. Should i still install tensorflow-gpu ?

@tmbo ,
pip upgrade for spacy==1.8.2 scikit-learn==0.18.1 scipy==0.19.0 matplotlib==1.5.3 somehow fixed the issue. Did not install tensorflow-gpu

Good to know thanks :+1:


missing documentations for the results object

I am using "az aks create" command
I need to parse the results object to extract some info.
before doing that, I need to know how the results object looks like!
or I have to run the command and see what I will get, which not a proper method
since this method will create the resource .. and every time I need to back to the object reference I will run the command and create a new resource again and again!
I know I can delete it .. but it doesn't make sense.
we need for a documentation for results object for any AZ cli command.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d75c3a8d-1187-bea1-a7d4-7ebba71c1790
Version Independent ID: 75b0c352-762e-16ae-5cc6-d807ffc1dc3f
Content: az aks
Content Source: src/azure-cli/azure/cli/command_modules/acs/_help.py
Service: container-service
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

routing to appropriate team

@metwally Apologies for the late reply. We will update this thread once we have more details.
@Azure/aks-pm Could you please look into this doc update request once you get a chance ? Awaiting your reply.

@qpetraroia

#reassign:schaffererin


draft: Try To init devcons without spin::Once

Signed-off-by: Graham MacDonald<EMAIL_ADDRESS>

Tidied up and fixed other arches.


build: propagate ASAN/TSAN flags down to cmake_external deps.

While we await a solution for
https://github.com/bazelbuild/rules_foreign_cc/issues/154#issuecomment-466504751, this PR provides a
temporary workaround to get full ASAN/TSAN propagation as needed.
Risk level: Low
Testing: --config=clang-{tsan,asan}. This was broken strangely this morning on my distribution,
after some clang-7 package upgrade this morning, due to the mismatched linker/compiler flags we
previously had been sending to cmake_external builds.
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

CC @mergeconflict @irengrig

@htuch seems CI is failing, maybe you need newer image?

@lizan seems some mystery compile error in gperftools, no idea why it's suddenly missing munmap, will dig.

Hmm, checking for working mmap... no from the configure log, that's probably not good.

Hmm, checking for working mmap... no from the configure log, that's probably not good.

You might need to update autoconf:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866406

@PiotrSikora thanks for that pointer, I think we have the same issue.
From config.log:
configure:18376: clang -o conftest -fsanitize=address,undefined -fno-sanitize=vptr -ggdb3 -fno-omit-frame-pointer -O2 -DNDEBUG  -lpthread conftest.c  >&5
configure:18376: $? = 0
configure:18376: ./conftest

=================================================================
==2690==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 4096 byte(s) in 1 object(s) allocated from:
    #0 0x4c2b43 in __interceptor_malloc (/build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/envoy_deps_cache_b22e04bff96538ea37e715942da6315c/gperftools.dep.build/gperftools-fc00474ddc21fff618fc3f009b46590e241e425e/conftest+0x4c2b43)
    #1 0x4f40a8 in main /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/envoy_deps_cache_b22e04bff96538ea37e715942da6315c/gperftools.dep.build/gperftools-fc00474ddc21fff618fc3f009b46590e241e425e/conftest.c:217:20
    #2 0x7f8d3fa5882f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291

Direct leak of 4096 byte(s) in 1 object(s) allocated from:
    #0 0x4c2b43 in __interceptor_malloc (/build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/envoy_deps_cache_b22e04bff96538ea37e715942da6315c/gperftools.dep.build/gperftools-fc00474ddc21fff618fc3f009b46590e241e425e/conftest+0x4c2b43)
    #1 0x4f3c72 in main /build/tmp/_bazel_bazel/b570b5ccd0454dc9af9f65ab1833764d/external/envoy_deps_cache_b22e04bff96538ea37e715942da6315c/gperftools.dep.build/gperftools-fc00474ddc21fff618fc3f009b46590e241e425e/conftest.c:168:19
    #2 0x7f8d3fa5882f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291

SUMMARY: AddressSanitizer: 8192 byte(s) leaked in 2 allocation(s).

.. and we seem to have an autoconf version prior to the bug fix ...
++<PHONE_NUMBER>.668187254 apt-cache show autoconf
Package: autoconf
Status: install ok installed
Priority: optional
Section: devel
Installed-Size: 1861
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Architecture: all
Multi-Arch: foreign
Version: 2.69-9
...

Will look into updating the base image.

 Filed https://github.com/libevent/libevent/issues/777, will disable this debug support for TSAN builds.

I have a workaround for the libevent TSAN issues, next up is the ASAN issue in LuaJIT at https://circleci.com/gh/envoyproxy/envoy/172877?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link.

More TSAN errors, this time in dispatcher posting, will dig further tomorrow.

Uh oh, with the bump to Clang 7.0.1 in https://github.com/envoyproxy/envoy/pull/5953 (and basically anyone else who wants to bump the CI image), we will hit failures like https://github.com/envoyproxy/envoy/pull/5953.
@lizan is LuaJIT fixed with your LSAN_OPTIONS change? I think maybe we only have a some libevent TSAN issues re: atomics.

Closing out in favor of cleaned up https://github.com/envoyproxy/envoy/pull/6196.


[Port dspace-7_x] Replace mentions of demo7.dspace.org and api7.dspace.org with new demo URLs

Description
Port of #2452 to dspace-7_x.
This includes the same commits EXCEPT that it adds a single change:

Configuration on dspace-7_x is updated to use the new https://demo.dspace.org/server/ demo backend by default (as demo.dspace.org auto-updates based on the dspace-7_x branch)

Instructions for Reviewers
THIS SHOULD NOT BE MERGED UNTIL THE NEW https://demo.dspace.org/ IS LAUNCHED (later this week)
The updated configurations in this PR require the new demo REST API Backend at https://demo.dspace.org/server/ to exist before they will function properly.  I'll merge this once that site has been fully deployed.

Merging immediately as the new demo site at https://demo.dspace.org is now launched.
I tested the changes on this branch locally & verified they allow you to run a local UI on http://localhost:4000/ which uses https://demo.dspace.org/server/ as the backend.


Update relationship

√ Builder refactor
√ Updater refactor
√ Creating nodes from an update clause that contains nested documents
√ Adding labels for new nodes created from update action
√ Docs

@johnymontana waiting for review. This PR is also the basis for fixing the relationship bug, since it refactors the Builder class for a more concise approach.


Move OS Login to the microgenerator

Commits 1 and 3 are manual; 2 and 4 are generated.

This currently has a lot of major changes, which I wasn't expecting as it's had a GA release.
Am I misunderstanding something?

This is the API we don't plan to release before the major version bump. The expectation is that all the breaking changes are due to the resource names being renamed; I'll check through them tomorrow to make sure that's the case.


Fix potential crash with autoscope name conflict

Uses a static counter for autoscope names instead of epoch microsecond as a fix for #37.

@escamoteur have you had any chance to look at this?

Ah, sorry will do over the weekend
Am 13. Sept. 2024, 19:38 +0100 schrieb Jeff @.***>:

@escamoteur have you had any chance to look at this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


ResourceController Thrashing on Wait

ResourceController is triggering perpetual reconcile loop:
2019-05-19T10:26:45.630Z        DEBUG   crossplane.controller.s3bucket.aws.crossplane.io        reconciling     {"kind": "s3bucket.storage.aws.crossplane.io/v1alpha1", "request": "crossplane-system/bucket-faccada4-7a1f-11e9-bd86-42010a9a01bd"}
2019-05-19T10:26:46.180Z        DEBUG   crossplane.controller.s3bucket.aws.crossplane.io        reconciling     {"kind": "s3bucket.storage.aws.crossplane.io/v1alpha1", "request": "crossplane-system/bucket-faccada4-7a1f-11e9-bd86-42010a9a01bd"}
2019-05-19T10:26:46.739Z        DEBUG   crossplane.controller.s3bucket.aws.crossplane.io        reconciling     {"kind": "s3bucket.storage.aws.crossplane.io/v1alpha1", "request": "crossplane-system/bucket-faccada4-7a1f-11e9-bd86-42010a9a01bd"}
2019-05-19T10:26:47.282Z        DEBUG   crossplane.controller.s3bucket.aws.crossplane.io        reconciling     {"kind": "s3bucket.storage.aws.crossplane.io/v1alpha1", "request": "crossplane-system/bucket-faccada4-7a1f-11e9-bd86-42010a9a01bd"}

This appears due to perpetual status update:
   - LastTransitionTime: "2019-05-19T10:28:18Z"
      Message: Resource is not in running state
      Reason: Waiting for resource to become available
      Status: "True"
      Type: Pending

...
    - LastTransitionTime: "2019-05-19T10:28:48Z"
      Message: Resource is not in running state
      Reason: Waiting for resource to become available
      Status: "True"
      Type: Pending

Note: LastTransitionTime is being updated every single time.
This is due to: https://github.com/crossplaneio/crossplane/blob/master/pkg/controller/core/resource_controller.go#L190
When we UnsetAllCondition and then activate a specific condition, we change the activated condition timestamp. Instead, we should check if condition has changed and only then unset all conditions if needed, otherwise we should leave current condition intact.

UnsetAllCondition doesn't exist on the newer implementation of ConditionedStatus, so this should be fixed (eventually) by https://github.com/crossplaneio/crossplane/issues/504.


Change dbo PKs type to bigint

No need to change PK data type. See ranges below:
bigint | -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 | 8 Bytes
int | -2,147,483,648 to 2,147,483,647 | 4 Bytes
smallint | -32,768 to 32,767 | 2 Bytes
tinyint | 0 to 255 | 1 Byte


attempt to optimize prompts

tried to optimize prompts by:

observed that agent goes off track often, so

from beginning, set the agent's capabilities scope straight
revise other prompts trying to help agent to focus on intended task

feel that some prompts can be shortened a bit to save tokens

asking gpt4 to optimize prompt to use less tokens
test to check whether original result is retained
iteratively optimize

I really appreciate all of the work in this PR, but given that #28 completely reworks this entire system and is close to being merged, I'm not sure it's worth it to merge this once it's ready.

understood, will check back later
Sent with GitHawk


extra conjunctions

For-and-nor-but-or-yet-so. In the CC category, "so" is not included as a conjunction. This is my list of conjunctions which is not complete as there are some wildly complicated connectors too.
After
Although
And
As
As far as
As if
As soon as
Because
Before
But
Even if
For
How
If
In case
In that
No matter how
Nor
Now that
Once
Or
Provided
Since
So
So that
Supposing
Though
Unless
Until
When
Wherever
Whether
While
While
Yet

ha, that's great. I'll take a look at this in a day or so. If you diff them with the current lexicon, I think most but not all are covered. Thanks John!

hey John, added a few of these we've been missing.
thanks!


apply_torque_impulse() affected by global coordinates without 'await'

I am new to github and apologize if my etiquette is off.
Jolt v0.13.0
Godot 4.3
Introduction
I have had issues with 'torque' and 'impulse' methods in Godot 4.x, wherein RigidBody3Ds receive no rotation or spin from these methods. When I switched to the Jolt physics engine in 4.3, objects rotate again, but not in the expected way. My current implementation uses 'apply_central_impulse()' combined with 'apply_torque_impulse()', where this unexpected behavior persists.
The Scenario
A first-person player throws a RigidBody3D (sword). The player instantiates the sword in front of the camera, and then calls a 'yeet()' function on the sword, as seen below:

	var weapon = get(weapon_pickup).instantiate()
	get_tree().get_root().add_child(weapon)
	weapon.global_transform.origin = parent.camera.global_transform.origin - (parent.camera.global_transform.basis.z / 3)
	weapon.yeet(-parent.camera.global_transform.basis.z + Vector3(0, 0.2, 0), parent)

func yeet(direction : Vector3, source : Object):

	rotation = Vector3(source.head.rotation.x - 0.5, source.rotation.y, 0)

	apply_central_impulse(
		direction * yeet_strength
	)
	apply_torque_impulse(
		-transform.basis.x * spin_strength
	)

The Problem
With this code, I expect the sword to always spin a certain way. However, the rotation appears to be influenced by its global position. i.e. when thrown in the global Z direction, the sword spins as expected, but when thrown in the global X direction, it spins incorrectly. (tested with both 'global_transform.basis' and 'transform_basis' — no apparent difference).
The Unexpected "Fix"
By using await get_tree().create_timer(0.01).timeout or await get_tree().process_frame directly after setting 'rotation' at the top of the 'yeet()' function, the rotation of the sword works exactly as expected, and is consistent regardless of the direction it is thrown. This leads me to believe there might be a bug in the physics engine.
Gifs for demonstration

Thank you for all the information, but sadly I'm not sure it's gonna be enough to give a definitive answer here, without some sort of repro project that I can test for myself.
First of all, do you see the same behavior if you switch back to Godot Physics?

With this code, I expect the sword to always spin a certain way. However, the rotation appears to be influenced by its global position. i.e. when thrown in the global Z direction, the sword spins as expected, but when thrown in the global X direction, it spins incorrectly.

Most of the physics-related methods, including apply_central_impulse and apply_torque_impulse, operate in global-space.

(tested with both 'global_transform.basis' and 'transform_basis' — no apparent difference).

You're childing the weapon to the scene tree root, meaning it has no parent node, so you will indeed not see any difference between them, but you should technically be using global_transform.basis (or just global_basis).

rotation = Vector3(source.head.rotation.x - 0.5, source.rotation.y, 0)

This line is also a bit confusing to me, since you're setting the local (which happens to also be the global) rotation of the weapon to the local rotation of this head node.
All-in-all, it's not super clear to me what's going on here. I do know that some transform-related things are deferred in Godot (see Node3D.force_update_transform), but it shouldn't be necessary to invoke here.
I would personally try to rewrite that code to...

Remove the rotation = ... in your yeet method
Set weapon.global_transform.basis (or weapon.global_rotation if you prefer) alongside weapon.global_transform.origin in your calling method instead.
As mentioned above, use global_transform.basis/global_basis for your apply_*_impulse calls.

If that doesn't help, I would need you to share some kind of minimal reproduction project so I can test it for myself on my end.

because apply_torque_impulse() (or indeed the 'position' argument of apply_impulse()) do not work at all for me

Hm, that's very odd. It should work just fine.

If I still can't get it working, I'd be happy to provide a minimal reproduction project. As I have not done that before, can you clarify what it entails? Would I make a literal Godot project set up exclusively to demonstrate the issue?

Yeah, pretty much. Try to keep it as straight-to-the-point as possible. Ideally it's just a single scene, where you press F5 and immediately see the issue demonstrated, but in this case I guess it's fine if it's a player character that you have to move around.
Note that there is a size limit to the ZIP file, which you upload by dropping it into the comment field here on GitHub, so you'll want to omit things like the godot-jolt addon folder, as well as the .godot folder and any .git folder.

rigidbody-impulse-reproduction - Copy.zip
This project is missing the jolt addon folder (versions 0.13.0 and 4.3 still).
It took a bit of trial and error to recreate the problem, but I hope this is useful. Let me know if you need it re-uploaded for any reason. And if it turns out to just be some trivial problem with my implementation I sincerely apologize 😅

Thank you for the repro project.
It seems that my statement above about force_update_transform not being necessary in this case was incorrect.
Transform changes are only propagated to the physics engine at specific points in the program flow, namely before and after _process and _physics_process, and since you need your change to the sword's global transform to have made its way to the physics engine by the time you call apply_torque_impulse you'll end up getting wonky results if you don't force this propagation to happen inbetween look_at and apply_torque_impulse.
The issue with Godot Physics not responding to apply_torque_impulse at all during its first tick seems to be a known issue, namely this one: godotengine/godot#75934
That issue seems to have to do with how Godot Physics re-calculates the inverse inertia tensor, which is used when calculating the new angular velocity during apply_torque_impulse, meaning it's technically stale (identity) unless you wait a little bit (two physics frames) for it to be updated. Note however that this shouldn't be a problem when using Jolt.
So, basically, you can solve this in a number of ways:
You can work around this by setting your transform before you child the node. Note that this means you can't set the global transform, since that requires the node being part of a tree, so you would need to set the local transform. If your sword wasn't top-level you could do some simple math to figure out the desired local transform of the sword, but since your sword in fact happens to be top-level you can also just set it based on the global transform of the camera, sort of contradicting what I talked about above. That would look something like this:
var body := sword.instantiate()
body.basis = camera.global_basis
body.position = camera.global_position + -camera.global_basis.z
get_tree().get_root().add_child(body)

That'll result in the sword's global transform being up-to-date immediately, without the need for force_update_transform.
Alternatively, if you still want to keep the (global space) look_at stuff you were doing, you can just slap a body.force_update_transform() inbetween look_at and your impulses.
Lastly, if you want something that works across both physics engines, you have no choice but to do what was suggested in godotengine/godot#75934 and do two await get_tree().physics_frame inbetween your look_at and the impulses, which will take care of both updating the inverse intertia tensor in Godot Physics as well as propagating the transform changes with both engines.

This info will be very useful going forward, thanks for the help.
And thanks for Jolt. Having objects not fall through the floor is a great joy.


Create bounty.lua

Introduce a Bounty System.

code is good, javier is testing and then we'll merge


screen lock out /dur,update R50-b Toshiba

Version
23.10.1
Explain the issue and what happens
Was unable to open lock screen during latest 'update station' update on ---R50-b Toshiba Satellite Pro.----- No login window.
Explain how to reproduce the bug?
open update station for update containing freebsd 14 on the r50-b toshiba
What is the Expected behavior (if applicable)
No login window from lock screen mate?
Additional context (if applicable)
pause update option neccessary

With MATE or XFCE?


Brand-new plugin

Description
Brand-new plugin
Checklist

[ ] Tests (sad, but not applicable)
[x] Documentation (if applicable)

Wrong branck


Fill out rest of the guide

I have a good start on the guide section on deployment.  Some of it will need to be updated/reviewed.

I think this is done.


Plugin run as root

Problem/Motivation
The service complains that it is launched as root:
Nov 12 22:16:50.000 [warn] You are running Tor as root. You don't need to, and you probably shouldn't.
Expected behavior
It would be top to avoid this warning, running services as root is typically dangerous
Actual behavior
Service run as root
Steps to reproduce
Use default configuration
Proposed changes
Thank you very much for all your efforts.

Yup, however, add-ons are isolated containers. It is the preferred method for the Home Assistant end.
Nevertheless, thanks for your suggestion.
../Frenck


Could not instantiate forked environment with fork url

Component
Forge
Have you ensured that all of these are up to date?

[ ] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7bef9ca 2024-06-26T00:18:22.002685333Z)
What command(s) is the bug in?
forge script
Operating System
Linux
Describe the bug
After trying to deploy a pretty simple mock ERC-20 token to the Polygon Amoy testnet, I got this error, which the CLI asked me to report as a bug:
forge script script/MockToken.s.sol --rpc-url https://rpc-amoy.polygon.technology/ --broadcast -vvvv
[⠊] Compiling...
No files changed, compilation skipped
2024-11-21T15:25:27.218837Z ERROR foundry_evm_core::fork::init: It looks like you're trying to fork from an older block with a non-archive node which is not supported. Please try to change your RPC url to an archive node if the issue persists.
The application panicked (crashed).
Message:  Unable to create fork:
Could not instantiate forked environment with fork url: https://rpc-amoy.polygon.technology/
Location: crates/evm/core/src/backend/mod.rs:454

This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __libc_start_main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
[1]    15730 IOT instruction (core dumped)  forge script script/MockToken.s.sol --rpc-url  --broadcast -vvvv

The script doesn't do much:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import {Script} from "forge-std/Script.sol";
import {MockToken} from "../src/MockToken.sol";

contract MockTokenScript is Script {
    function run() external {
        uint256 deployerPrivateKey = vm.envUint("PRIVATE_KEY");
        vm.startBroadcast(deployerPrivateKey);

        new MockToken("Mock ERC20 Token", "MCK");

        vm.stopBroadcast();
    }
}

And the contract is as dumb as possible:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import<EMAIL_ADDRESS>
contract MockToken is ERC20 {
    constructor(
        string memory _name,
        string memory _symbol
    ) ERC20(_name, _symbol) {}

    function mint(address to, uint256 amount) public virtual {
        _mint(to, amount);
    }

    function burn(address form, uint amount) public virtual {
        _burn(form, amount);
    }
}

Note: foundryup --version returns an empty string, I was not able to find out its version.

@heitor-lassarote pls add forge --version output

Confirming forge doesn't panic with latest but prints message

Going to close for now, please reopen if still an issue. thank you


How can i increase sensitivity of wake word ? Also i am getting this error after internet get disconnected.

May 28 18:44:30 raspberrypi bash[4980]: [4990:5008:ERROR:speech_processing_task.                                                                                cc(646)] Detected communication error: Downstream closed prematurely.
May 28 18:44:30 raspberrypi bash[4980]: [4990:5008:ERROR:assistant_output_handle                                                                                r.cc(589)] Failed with a general speech recognition error
May 28 18:49:15 raspberrypi bash[4980]: [4990:5008:ERROR:speech_processing_task.                                                                                cc(646)] Detected communication error: Downstream closed prematurely.
May 28 18:49:15 raspberrypi bash[4980]: [4990:5008:ERROR:assistant_output_handle                                                                                r.cc(589)] Failed with a general speech recognition error
May 28 18:49:26 raspberrypi bash[4980]: [4990:5008:ERROR:speech_processing_task.                                                                                cc(646)] Detected communication error: Downstream closed prematurely.
May 28 18:49:26 raspberrypi bash[4980]: [4990:5008:ERROR:assistant_output_handle                                                                                r.cc(589)] Failed with a general speech recognition error
May 28 18:49:32 raspberrypi bash[4980]: [4990:5008:ERROR:speech_processing_task.                                                                                cc(646)] Detected communication error: Downstream closed prematurely.
May 28 18:49:33 raspberrypi bash[4980]: [4990:5008:ERROR:assistant_output_handle                                                                                r.cc(589)] Failed with a general speech recognition error
May 28 19:55:22 raspberrypi bash[4980]: [4990:5008:ERROR:speech_processing_task.                                                                                cc(646)] Detected communication error: Downstream closed prematurely.
May 28 19:55:22 raspberrypi bash[4980]: [4990:5008:ERROR:assistant_output_handle                                                                                r.cc(589)] Failed with a general speech recognition error
After restarting assistant it works fine

Assistant isn't meant to work without the internet. Is that what your problem is?

Connection issue looks related to #38

Did you try to follow the instructions in the documentation to increase mic sensitivity?


Can't connect on two topics to same peer

I noticed that in Queue.push, the id is defined as const id = peer.host + ':' + peer.port, which means that a peer can't connect to the same peer on two different topics. Is there anyway, similar to discovery-swarm, that we can make it such that the id is based on the topic?
Something like:
const id = peer.host + ':' + peer.port + '@' + peer.topic.toString('hex')

This is a fair point. Alternatively the ports could be cycled for different
topics
On Fri, 16 Nov 2018, 00:38 bplaster<EMAIL_ADDRESS>wrote:

I noticed that in Queue.push, the id is defined as const id = peer.host +
':' + peer.port, which means that a peer can't connect to the same peer
on two different topics. Is there anyway, similar to discovery-swarm, that
we can make it such that the id is based on the topic?
Something like:
const id = peer.host + ':' + peer.port + '@' + peer.topic.toString('hex')
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hyperswarm/network/issues/14, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQpGzy2dwk2XdgCXeNqtnfG-vmBnXg7jks5uvgkIgaJpZM4YkKiL
.

This is fixed


fix: spreading non-object props

createComponent passes an empty object instead of non-object props which are spread
mergeProps treats non-object sources as empty objects
added tests

fixes #958
@ryansolid removed the Object.keys thing. I wanted to bring it closer to how native spreads worked but don't think it's feasible.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 4 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 89.519%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/solid/src/render/component.ts
2
4
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
1218

Relevant Lines:
1297

💛  - Coveralls


Use of nn.LayerNorm by FocalNet for a segmentation task and its alternatives

Excellent work!
By default, layer normalization is used as FocalNet(norm_layer=nn.LayerNorm). I'm wondering if it's a better choice for a semantic segmentation task. I would love to hear some thoughts on this.
Strangely enough, setting norm_layer=nn.BatchNorm2d caused several errors since x in nn.BatchNorm2d(embed_dim)(x) was found to be a 3D Tensor with embed_dim as its last dimension.

If nn.LayerNorm is supposed to be the default normalization for FocalNet, then why do we even have it as an input parameter?
If one wishes to use a different normalization, is there a quick fix?

Looking forward to getting awesome replies. Thanks!

Hi, @shahzad-ali , it is incompatible if you directly replace layernorm with bacthnorm2d because the dimension arrangements are different. You need to do some permutations for the input tensors accordingly. A simpler way is to use BatchNorm1d. This way you only need to transpose the input in the last two dimensions before each norm and transpose back right afterward.

One more comment is that it has been demonstrated that our FocalNets with layernorm work pretty well for semantic segmentation on ADE20K. You may have a direct try with the provided checkpoints without any changes.