Error in Node 10.13.0 - More tasks executed then were scheduled

This error doesn't happen in node 8.

C:\[Your_Path]\node_modules\applicationinsights\out\AutoCollection\Exceptions.js:33
                        throw error;
                        ^
Error: More tasks executed then were scheduled.
    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:811:33)
    at new AppInsightsAsyncCorrelatedErrorWrapper (C:\[Your_Path]\node_modules\applicationinsights\out\AutoCollection\CorrelationContextManager.js:182:18)
    at ZoneDelegate._updateTaskCount (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:310:23)
    at ZoneDelegate.cancelTask (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:297:22)
    at Zone.cancelTask (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:174:44)
    at zoneAwareRemoveListener (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1153:28)
    at C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1266:9
    at process.removeListener (eval at createNamedFn (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1207:17), <anonymous>:3:41)
    at process.on (domain.js:151:13)
    at process.emit (events.js:187:15)
    at process.EventEmitter.emit (domain.js:442:20)
    at _addListener (events.js:211:14)
    at process.prependListener [as __zone_symbol__prependListener] (events.js:266:14)
    at Object.invokeAddFunc (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1065:48)
    at ZoneTask.scheduleEventListener [as scheduleFn] (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1092:21)
    at ZoneDelegate.scheduleTask (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:255:26)
    at Zone.scheduleEventTask (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:171:39)
    at zoneAwareAddListener (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1137:14)
    at C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1266:9
    at process.prependListener (eval at createNamedFn (C:\[Your_Path]\node_modules\zone.js\dist\zone-node.js:1207:17), <anonymous>:3:42)
    at process.on (domain.js:152:13)
    at process.emit (events.js:187:15)

Environment:

OS: Windows 10 Pro 1809
Node: 10.13.0
Applicationinsights: 1.0.7

Steps to Reproduce

clone https://github.com/ahce/applicationinsightsBug
npm install
npm start or npm run start:watch

Can you provide code that reproduces this error? There isn't enough information from the stack trace to see the root cause.
Does this exception still throw if you disable automatic dependency correlation?

@OsvaldoRosado I added steps to reproduce

Thanks! Don't have a fix to share yet, but it looks like an incompatibility between restify and zone.js (at least the version of zone.js we currently use). You can avoid the error in the meantime by using setAutoDependencyCorrelation(false)

Had the same issue when incorporating winston to my solution. @OsvaldoRosado 's approach did the trick.
Many thanks!

Thanks for confirming @faridhajnal. You can also update to the latest version (1.1.0) where this is fixed so that you do not need to disable dependency correlation


[tf] remove alarm recover from lambda invocation errors

to: @ryandeivert or @jacknagz
cc: @airbnb/streamalert-maintainers
size: small
resolves N/A
Background
The PR #734 enables CloudWatch alarm recovery and it helps resolving alarms more efficient. But lambda invocation errors are considered to be critical ones. We should have the awareness and know when and why there are lambda invocation errors. Remove alarm recovery from lambda invocation errors, so we will get paged event the errors are not consistent anymore.
Changes

Remove ok_action from lambda invocation error metric alarm.

Testing
It is terraform code change, integration and unit tests won't be affected.

Coverage remained the same at 97.595% when pulling 3c490d315f5ed71837cb821b77aa73c63760f1c6 on remove_alarm_recover_from_invocation_errors into 429c5b67774ef31ae84bbaf0497474c4d2bf2227 on master.


FakeDir.walk_apply is not called on the root

Here's the current code for walk_apply:
def walk_apply(self, foo, *args, **kwargs):
        """
        Recursively apply a function the children of self (and so on)
        ...
        """
        for f in self._children:
            foo(f, *args, **kwargs)
            if isinstance(f, FakeDir):
                f.walk_apply(foo, *args, **kwargs)

The function is never called on self, only the children of self.  Seems like it should include the root also?  But I will need to double check where is method is called in service of other methods.

Changed to the following in 5475e2a:
def walk_apply(self, foo, *args, **kwargs):
    foo(self, *args, **kwargs)
    for f in self._children:
        if isinstance(f, FakeDir):
            f.walk_apply(foo, *args, **kwargs)
        else:
            foo(f, *args, **kwargs)


Supabase integration

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix[ios]: end current call and join new

Calls are removed on didDeactivate causing ongoing call to be removed. Removing those lines fixes the issue.

Would you please tell me why this PR should not be merged?

@ebsangam sorry for missing it. i will merge it and release in next version(or you can pull from branch dev)


request specific response length

Hi, I just started playing around with this. It seems pretty awesome although the speed was possibly an issue. It seems like it's making a round trip per word or sometimes multiple times per word. It seems like it would be faster if we could just say something like, "Give me 3 sentences in response" and have it return all 3 sentences at once. Is that something that is currently possible?
Thanks.

Hi @eliot1785. What model are you using and how are you calling it? If you share some code I'd be happy to take a look.

I just ran this:
import replicate
output = replicate.run(
    "meta/llama-2-70b-chat:2c1608e18606fad2812020dc541930f2d0495ce32eee50074220b87300bc16e1",
    input={"prompt": "What is property casualty insurance?"}
)
# The meta/llama-2-70b-chat model can stream output as it's running.
# The predict method returns an iterator, and you can iterate over that output.

sentences = 0
for item in output:
    print(item, end='')
    if '.' in item:
        sentences += 1
    if sentences == 3:
        break

@eliot1785 Thanks for clarifying. That model is generating output token by token. The latency introduced by the network requests should be negligible, so returning all of the output at once wouldn't make it finish any sooner.
A few tips for solving your use case:

Llama 2 and other models have a max_new_tokens parameter that you can tune to limit how many tokens are generated. When you break, the prediction continues to run until completion, so you can tune this parameter to optimize for cost.
Checking for "." is a fragile way to test for the end of a sentence, and will create false positives for tokens like "Dr.". Instead, you can use spaCy or other NLP tools to tokenize output into sentences more accurately.

You can also use prompt engineering to change how results are generated. For example, prompting for "Answer in three sentences or less."

@eliot1785 I'm going to close this issue for now. Please let me know if you have any more questions. Thanks!


Process Exported Data Readme: Step 4-viii has wrong function name

Step 4-viii should have ProcessBlobFiles() rather than ProcessEmails()

https://github.com/microsoftgraph/msgraph-training-dataconnect/tree/master/Demos/03-app


Add field support

See https://docs.blender.org/manual/en/latest/modeling/geometry_nodes/fields.html#fields

Added the core feature in f8b69308964de95a9c88578a6412d179596f3199.
Now each node that could use it needs to be updated to enable the feature, like in 384fc55bc5a1daf1f7af0e26a0d3b8a7da9c4fd9
Most were changed already, but the core node set is still subject to change anyway, so I'm marking it as completed.


[4.1][Package / Custom Field] New field type - Pill Switch / On Off It

It would be great to have a toggle/pill switch instead of boring checkboxes!
I am not good enough coder to do it but it is def a would be nice!

This was actually stupidly simple! (as I am finding manythings in backpack)
I created custom field in /vendor/backpack/crud/fields/toggle.blade.php
modified the code from checkbox.blade.php in vendor file
`

    @include('crud::inc.field_translatable_icon')

        <input type="hidden" name="{{ $field['name'] }}" value="0">
        <input type="checkbox" value="1"

               name="{{ $field['name'] }}"

               @if (old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? false)
               checked="checked"
        @endif

        @if (isset($field['attributes']))
            @foreach ($field['attributes'] as $attribute => $value)
                {{ $attribute }}="{{ $value }}"
            @endforeach
        @endif
        >

    {!! $field['label'] !!}

    {{-- HINT --}}
    @if (isset($field['hint']))

{!! $field['hint'] !!}

    @endif

`
then included css in public css folder (toggle.css)
`
/* The switch - the box around the slider */
.switch {
position: relative;
display: inline-block;
width: 60px;
height: 34px;
}
/* Hide default HTML checkbox */
.switch input {
opacity: 0;
width: 0;
height: 0;
}
/* The slider */
.slider {
position: absolute;
cursor: pointer;
top: 0;
left: 0;
right: 0;
bottom: 0;
background-color: #ccc;
-webkit-transition: .4s;
transition: .4s;
}
.slider:before {
position: absolute;
content: "";
height: 26px;
width: 26px;
left: 4px;
bottom: 4px;
background-color: white;
-webkit-transition: .4s;
transition: .4s;
}
input:checked + .slider {
background-color: #2196F3;
}
input:focus + .slider {
box-shadow: 0 0 1px #2196F3;
}
input:checked + .slider:before {
-webkit-transform: translateX(26px);
-ms-transform: translateX(26px);
transform: translateX(26px);
}
/* Rounded sliders */
.slider.round {
border-radius: 34px;
}
.slider.round:before {
border-radius: 50%;
}`

@vesper8 yes, that's planned for v4 - can't wait.
Installing a field like this should be as easy as installing the package - afterwards Backpack will auto-load the field. Death to copy-paste!!! :-)

Thanks for sharing your code @adoptavia !

thankyou very much for sharing!

I've just created a separate package with the Toggle field type you've provided @adoptavia ! Thanks again. It's super-easy to install in your own project and use.
Indeed, creating a custom backpack field isn't difficult at all. But creating a package to share that field with everybody has never had a clear guide. I intend to fix that ASAP :-)
For everybody that wants a toggle field: use this package
For everybody that wants to share their custom field with the world: fork this package; Docs coming soon! Can't wait to make this easier for everybody. Can't wait to see what you guys have built 🎉

I've just posted a tutorial on how to create a Backpack add-ons. It's much better than before, but I'm still not 100% happy with the process. Will try to improve the process over time.

Let's close this since the DigitallyHappy/toggle-field-for-backpack package completely fixes this, and I've put it up on the add-ons page so everybody can see it.
For more visibility, I guess we could add it to the docs... not sure where to draw the line though...
Thanks again for this @adoptavia !


ReferenceError: generateChallenge is not defined with v12.0.0

Describe the issue
|- ReferenceError: generateChallenge is not defined
    at Function.assign (<anonymous>)
    at file:///Users/x/Projects/x/node_modules/.pnpm/@simplewebauthn+server@12.0.0_encoding@0.1.13/node_modules/@simplewebauthn/server/esm/helpers/index.js?iitm=true:6:18
    at ModuleJob.run (node:internal/modules/esm/module_job:268:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:543:26)

Reproduction Steps
I'll create a repro project later

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

With v11.0.0 the same code worked fine.
Code Samples + WebAuthn Options and Responses

Dependencies

OS: (e.g. macOS 13.2)
Node version: v22.11.0
Browser: (e.g. Chrome 110)
Authenticator: (e.g. YubiKey 5, iPhone 12 @ iOS 16.3, 1Password browser extension 2.15.1)

SimpleWebAuthn Libraries

$ npm list --depth=0 | grep @simplewebauthn
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS># ...

 Not sure what is doing under the hood, but literally broke the entire process, gonna open an issue there.


Update start script

Updating to using array for STARTCOMMAND due to issues that su steam -c "${STARTCOMMAND}" can have with escaped quotes and spaces, also this will allow for spaces in server names and passwords
Context
Allow users to use spaces in environment variables
Choices

Better handling of spaces in program arguments that should allow them, such as server name and passwords

Test instructions

Run the server with this change and have spaces in the passwords or in the server name

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I've added documentation about this change to the README.
there is no mention spaces aren't supported, so this will just be helpful overall
[x] I've not introduced breaking changes.
fully tested this time instead of just testing printing the startcmd. sorry about that! here's proof:

@thijsvanloef fixed and fully tested this time!

@Dashboy1998 looks like you were right about the [*] syntax vs. [@]. It looks to be honoring the spaces just fine, and the linter likes it better. Thanks again!

@thijsvanloef all set! Apologies for the delay. The only reason I've been able to focus on this and why I've been doing it in the middle of the night...I just had a baby girl! Our first one. Sorry to get personal, but I'm just too excited :D

@clarkent86 Wow! Congrats on the little girl! I wish you folks all the best. Ofcourse the baby comes first, don't worry about it!
I don't have time to review this today, will definitely do so tomorrow!


Weird initial state when using hash history

Accessing my app at http://localhost/react-bliss/public/index.html
The initial state for routing is set to /react-bliss/public/index.html
The history listener then updates the path to '/'
However with Redux Persist the store is updated before the update path action sets the correct path of '/'
This triggers redux-simple-router's store subscribe function and pushs the initial state to the browser - so I get a browser URL of http://localhost/react-bliss/public/index.html#/react-bliss/public/index.html?_k=djhrwj
This seems a symptom of the initial state redux-simple-router is using not being the 'real' initial state with hash history.
Potential solutions:

Detect hash history is being used (if possible) or set a config option to specify hash history - and then in locationToString return only the hash
Allow locationToString to be over-ridden by a user supplied function in a config object

Use case:
Using redux-simple-router with redux-persist and accessing at a url with a non-hash path
i.e. localhost/myapp/index.html instead of myapp.localhost
In my case I need to be able to access at the first url because I am using this with cordova and cannot rewrite the URL

We've recently changed a lot of this code. Can you try master? This might be fixed.

@jlongster Yes, working flawlessly now.  Thanks for your work


Update UG

This PR closes #208 and #236

Codecov Report

Merging #251 (1c5e9e8) into master (16c63c5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #251   +/-   ##
=========================================
  Coverage     55.51%   55.51%
  Complexity      610      610
=========================================
  Files           107      107
  Lines          2785     2785
  Branches        387      387
=========================================
  Hits           1546     1546
  Misses         1096     1096
  Partials        143      143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c63c5...1c5e9e8. Read the comment docs.


[spi_device] Abort feature description

Please add more details in specification on the abort feature. Currently there is not enough info to create full scenario with meaningful checking.

@eunchan Any updates on this issue?

Updated the abort CSR description. waiting for review now.


Update azure_service.go for fixing #1126Azure|| route_table ||[ERR]: duplicate resource found: azurerm_route.tfer--

Added Duplicate check method to avoid error having same name in different Resource group or at sub level

There are scenarios in azure, where two different resources groups have same name of resources or child resources and due to that Terraformer was throwing "duplicate resource found: azurerm_route.tfer" error.
In code, I am checking if resource name is already there as tfer name  then for next resource, having same name,  six digits random string is getting added as suffix in tfer name.


Access field types in query response

It seems as all the query responses are wrapped with the PartialResultStream and formatting of the response is being done there while making the field with their types inaccessible
https://github.com/googleapis/nodejs-spanner/blob/master/src/partial-result-stream.js#L79
Though it would be helpful to be able to get access to the metadata for each column's type. The only way I can see right now to access the metadata of a table would be using the Database.getSchema()
https://github.com/googleapis/nodejs-spanner/blob/master/src/database.js#L719
and parsing the string to be able to get a column's type which does not seem very practical.
Any reason for not making the full response data available in the query response?

Good catch. Streaming methods are difficult to return the raw response from, for a couple of reasons:

A stream involves more than one API response arguments
A stream passes through one "thing" to the user

For a query response stream, the user wants the formatted result emitted on each data event. To add on the apiResponse argument, we'd have to do something creative, maybe:
queryStream()
  .on('data', result => {
    result.myCustomProperty = true
    const apiResponse = result[spanner.API_RESPONSE_SYMBOL]
  })

Better ideas welcome!
(cc @callmehiphop)

@stephenplusplus that could work. Alternatively, what are your feelings on emitting a response event before we start formatting/pushing rows to the user.
queryStream()
  .on('response', response => {})
  .on('data', row => {});

That's perfect!


As a user I want to be able to manage what tags I am subscribed to

Allow users to manage their current tag subscriptions within the profile modal. Would like to implementation to act the same as Create/Edit Listing->Tags (Have a 'bar' which will hold all the tags currently subscribed and have an option to remove tags.

merged


Merge main to live

Including [SEO][Rollout Monikered Canonical]Add URL moniker

Docs Build status updates of commit ea41c5d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit ea41c5d224b1397f11a3207f0a21e177154c2b8b in branch main of repository https://github.com/SharePoint/sp-dev-docs-2013-server-ref-dotnet into branch live (commit 58e157a652be04ef3255490a444c868d5132ad91). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@lindalu-MSFT could you please help to take a look? It seems that there's conflict merging from main to live.

Hi, traveling now but can check and resolve this evening. Thanks for letting me know!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Tianqi Zhang @.>
Sent: Friday, September 16, 2022 1:08:51 AM
To: SharePoint/sp-dev-docs-2013-server-ref-dotnet @.>
Cc: Linda Lu Cannon @.>; Mention @.>
Subject: Re: [SharePoint/sp-dev-docs-2013-server-ref-dotnet] Merge main to live (PR #86)
@lindalu-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flindalu-MSFT&data=05|01|Linda.Cannon%40microsoft.com|6cfb660a7f9e449d274908da97bab11f|72f988bf86f141af91ab2d7cd011db47|0|0|637989125349011995|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=04MKGdlEsHS5h9clml0nxcfvSVIPpBxU2u5INBR2%2BkA%3D&reserved=0 could you please help to take a look? It seems that there's conflict merging from main to live.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSharePoint%2Fsp-dev-docs-2013-server-ref-dotnet%2Fpull%2F86%23issuecomment-1249054045&data=05|01|Linda.Cannon%40microsoft.com|6cfb660a7f9e449d274908da97bab11f|72f988bf86f141af91ab2d7cd011db47|0|0|637989125349011995|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=IdXlm%2BZOAdUgYZB%2Fp3RkMXv%2FaMapMQ3lfh3%2B%2FxAADlo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHKC5M2FOMUS6WF4BA2RXBDV6QTJHANCNFSM6AAAAAAQL6K77Y&data=05|01|Linda.Cannon%40microsoft.com|6cfb660a7f9e449d274908da97bab11f|72f988bf86f141af91ab2d7cd011db47|0|0|637989125349011995|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tpyzbgUQAkBX4YN%2Fr75rPrm5EOWP%2FksXa6mKhPwWc0s%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@lindalu-MSFT we'd appreciate it if you could help take a look at this PR.

Docs Build status updates of commit 5fc0f57:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sharepoint-server/docfx.json
:warning:Warning

Details

sharepoint-server/xml/Microsoft.SharePoint.Taxonomy/Term.xml
:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

sharepoint-server/docfx.json

Line 50, Column 28: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'sdk' is not valid with 'ms.prod' value 'sharepoint'.

sharepoint-server/xml/Microsoft.SharePoint.Taxonomy/Term.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoiint.Taxonomy.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxoomy.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.TermStore'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TaxonomySession.KeywordTermSet'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Term'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TermSetItem.CreateTerm'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.TermStore.GetTerm'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.Term.Move(TermSet)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.TaxonomyTerm.Move(T:Microsoft.SharePoint.Taxonomy.Term)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Sharepoint.Taxonomy.TermSet'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.SharePoint.Taxonomy.Term.Merge'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@TianqiZhang Fixed and merged


Move ACME label keys to the external API package

Fixes https://github.com/jetstack/cert-manager/issues/3159
Release note:
NONE

/approve
/lgtm


Add virtualenv info to prezto paradox prompt

The paradox prompt was missing virtualenv info for python projects, so this pull request adds that.

@sorin-ionescu Any comments would be helpful regarding this. Have personally been using this patch for a few days with virtualenv support and it seems to be pretty stable.

It looks fine; it has just a few white space issues — missing blank lines. Is (e) needed on variables?
Squash the commits.

@sorin-ionescu looks like e is not needed, so I removed it. Added missing blank lines and squashed the commits into one.

Anything else needed before merging @sorin-ionescu


Add cancellationRequest to cancelled event, so we can form an audit t…

…rail as to why comms were cancelled.

This PR was successfully deployed to production by CircleCI build 147 at 2017-03-07 10:17 GMT.


Explanation of the popup customization.

Hello, I would like to answer this question please (I am a French beginner developer so apologize me in advance if the answer is obvious ...)
I use the calendar to view appointments and add appointments. I need to customize the popup of creation and detail (I do not need some default fields and I need to add others that are not there). I have already looked at the others, but I have not found a conclusive answer.
Thank you in advance and again forgive me if I missed something that has already been said.
Version
tui-calendar: 1.7.0
Development Environment
Windows 10, chrome, Vue.js
Current Behavior
https://nhnent.github.io/tui.calendar/latest/tutorial-example01-basic.html
Expected Behavior
customize the modal

Check this #98 out.

@LieLust There is no customizable option for popups. If you want it, you can fork this and edit it.
See these sources.

https://github.com/nhnent/tui.calendar/blob/master/src/js/view/popup/scheduleCreationPopup.js
https://github.com/nhnent/tui.calendar/blob/master/src/js/view/template/popup/scheduleCreationPopup.hbs
https://github.com/nhnent/tui.calendar/blob/master/src/js/view/popup/scheduleDetailPopup.js
https://github.com/nhnent/tui.calendar/blob/master/src/js/view/template/popup/scheduleDetailPopup.hbs

am wondering how to customise the popups if I am using tui-calendar via CDN and through npm or bower. How would I go about this to edit the files scheduleCreationPopup.js, scheduleCreationPopup.hbs, scheduleDetailPopup.js and scheduleDetailPopup.hbs and then use the customised popup via CDN again?

@kzachos You have to fork this repo and edit sources if you want to. There is no way by CDN, Bower, npm.
Or you can make your own popup without editing these source. You can get a callback beforeCreateSchedule, clickSchedule and show your any popup using jquery, uib-modal, any ui library or your code, etc.

what function does the default 'useFormPopup'  call in order to save an schedule?


change filename of output from kubecf-.tgz to cap-.tgz

Correct the bundle filename from kubecf-.tgz to cap-.tgz

We renamed the latest published tarball to match this regexp, so jobs will have something to consume if when we fly this right after merging.

Reflown pipelines from master to consume the PR:
./create_pipeline.sh concourse.suse.dev cap-release
./create_pipeline.sh concourse.suse.dev cap-pre-release


[BEAM-9258] Add integration test for Cloud DLP

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python 2 PostCommit

Run Python 2 PostCommit

R: @aaltay
cc: @kamilwu

Actually I can merge. All tests are passing and it is reviewed.


ReactiveImagePicker / ReactiveFilePicker

I'd love to see a ReactiveImagePicker and/or a ReactiveFilePicker.

In progress

released in v0.3.8

What about a ReactiveFilePicker widget using the file_picker package?

@Reprevise may be some day.
Do you have any implementation examples of nice UI?
Currently I do not imagine what to display after random file was picked...

@vasilich6107 If it's anything other than an image, I'd suggest just showing the file name. Though if it's something like a PDF, maybe a little preview of the first page.

I think it would be acceptable to provide a previewBuilder so we could decide what to display.
Maybe, if this builder is not provided, a simple icon placeholder could be used as default (depending on the selected file extension, of course).

@Reprevise @mrverdant13 check https://pub.dev/packages/reactive_file_picker


NNBD: are 'dynamic?' and 'Null?' valid types?

current NNBD treats  'dynamic? x;' and 'Null? x;' as valid declarations.
In contrast, 'void? x;' gets flagged. Was it intended?

dynamic? and Null? are syntactically valid nnbd types (though hardly useful ones), and void? is a syntax error. So the behavior is as specified. You could say that this is inconsistent, and also that it is a consequence of the historic background (void used to be a syntactic exception, because it was an exception in so many other ways, but today void is much more like other types).
So we could improve on the consistency of the treatment of special types like void and dynamic, but it has only very little practical value to add support for void?.

I think void? is treated correctly. It's dynamic? that might be problematic. Some users might assume that there's a difference between dynamic and dynamic?. Especially if someone is coming from Kotlin where Any and Any? are different (in dart's terms, the former is Object, and the latter is Object?). Such user might assume that dynamic is similar to Any. I think dynamic? is asking for a warning (we have a number of warnings about redundancy, e.g. on int? x = null; this one might be similar). Sure, it's a kind of nitpick, nothing dramatic.

We could disallow writing dynamic? (and Null?, and maybe Never?) without affecting expressibility. At least as long as it does not affect type identity.
If dynamic and dynamic? are identical as types, and similar for Null and Null? or Null and Never?, then removing the ability to write the overlong representation is not needed.
I'd be fine with disallowing it. We have to state it specially in the syntax rules, but I think it is probably worth it.

I was basically noting that Dart isn't quite consistent in this area, but that it is not likely to be helpful for anyone if we add support for void?. So if we want to improve on the consistency we should instead outlaw dynamic? and Null? (because they are redundant and thus misleading for anyone who assumes that they are different from dynamic and Null, respectively).
If we want to do that then I believe that dynamic? and Null? should not be syntax errors, because the grammar machinery needed in order to encode various constraints like these is typically convoluted and not very readable. The flip side of that coin is that we could then make void an ordinary identifier, thus eliminating yet another snippet of special casing (the rule that void? is an error would then be added as a separate compile-time error, given that it is no longer a syntax error).
Never? is more delicate: The ? is significant (that is, Never? is not the same thing as Never), so we can't argue that the question mark is redundant and thus misleading. Also, we have lots of other types that have more than one syntactic form; one example is FutureOr<Object> == Object, and there are many others.
We probably don't want to require developers to normalize their types in source code, even though the analyzer/compiler will do that for them, because normalization may take place after a type variable has been bound:
FutureOr<X> f<X>(X x) => x;

void main() {
  var x = f(Object()); // `x` has type `FutureOr<Object>`, i.e., `Object`.
}

This means that types like FutureOr<Object> will occur naturally in programs, at least as an intermediate result, so it could be seen as overly rigid to make it an error to write these types explicitly.
We could try out having a types_must_be_normalized lint, and see how much breakage it introduces, and how useful everybody thinks it is. ;-)

"types_must_be_normalized" is too broad for this specific case. I think linter can unconditionally complain about dynamic? used as a type literal, no matter what flags. This is a really special case.
And everybody is using linter anyway, so it doesn't matter much which tool produces this warning IMO. Maybe indeed, linter is a better choice for that.

I would only disallow literal types written as dynamic? and Null?, not X? where X happens to be bound to dynamic or Null. The reasoning is that those types are confusing because the ? doesn't actually mean anything, but it looks like it does.
I'll probably backtrack on Never?. I can see a coding style where you never write Null, and always use Never? instead of Null. It would be consistent and reasonable, even if it's not what we currently do.
It is slightly different with FutureOr<dynamic>. It may not have any subtying difference from dynamic, but it carries a strong signal to human readers that this thing is going to be a future that you should await.
We could argue that dynamic? suggests that it might contain a null value that you should handle, but you have to handle any type it might contain, so I'm not sure that's actually useful.

I think the question has been satisfactorily answered.


Error preventing compilation of the typescript.
Love this boilerplate btw, nice work!
needed to cast createLogger : (<any>createLogger)

Thanks a lot! 👍


PR not listed

this PR is not listed, whereas it was pushed less than 24h ago: https://github.com/conan-io/conan-center-index/pull/4182
Is this expected ?

Yes I had added a review and it was removed from the table

Yes I had added a review and it was removed from the table

Ok, I thought that "No reviews" meant "No reviews since the last push", but it means "no reviews on any version of the PR" right ?
In this case Wouldn't it be pertinent to consider only reviews which happened after the last push ?

Ok, I thought that "No reviews" meant "No reviews since the last push", but it means "no reviews on any version of the PR" right ?
In this case Wouldn't it be pertinent to consider only reviews which happened after the last push ?

Ok, I thought that "No reviews" meant "No reviews since the last push", but it means "no reviews on any version of the PR" right ?

Spot on

Wouldn't it be pertinent to consider only reviews which happened after the last push ?

I do so for the approvals/blockers....
My logic was that an approval is the indication of the PR being completed/ironed out, ie someone had already taken the time to review it... no longer rough draft.
Being more flexible might drastically increase the quantity needing review... which would be accurate reflection...
depends how many PRs we want in this list...
My original goal was to have a list of "easy reviews" since the hard part was already done.
It might be worth formalizing a definition of the "review process"

Ok, I thought that "No reviews" meant "No reviews since the last push", but it means "no reviews on any version of the PR" right ?

Spot on

Wouldn't it be pertinent to consider only reviews which happened after the last push ?

I do so for the approvals/blockers....
My logic was that an approval is the indication of the PR being completed/ironed out, ie someone had already taken the time to review it... no longer rough draft.
Being more flexible might drastically increase the quantity needing review... which would be accurate reflection...
depends how many PRs we want in this list...
My original goal was to have a list of "easy reviews" since the hard part was already done.
It might be worth formalizing a definition of the "review process"

certainly an area for improvement

certainly an area for improvement


HTML content in the subtext get escaped in 1.13.0

Environment

jquery 3.3.1
bootstrap 3.3.7
bootstrap-select 1.12.4 / 1.13.0

JsFiddle

1.12.4: https://jsfiddle.net/jfcherng/uux33ge4/
1.13.0: https://jsfiddle.net/jfcherng/dho62rmk/

Screenshot

Fixed and released in v1.13.1!

@caseyjhol Thanks you. :grinning:

/move to bootstrap-select


Reimagine dev site landing page

Is this a request for Brand New Content?
Y
Where do you intend to use or post this content?
Developer site
Depth/Length of content
This rework can entail anything that may increase the effectiveness of our landing page. The complexity of this issue may vary depending the type of restructure proposed.

What do devs want to see on a landing page?
What are some things they expect to see when navigating to a developer site?

Who is the audience?
Developers

Hi, I am Nikunj Rohit, a contributor to OpenForce 2022. If this issue is still open I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you
@TylerTrott


Content adjustment

Content adjustment for issue types in Jira.

@leolohmann has already changed the publish property to true in the 4 pages that were missing

@plhnk , @leolohmann doesn't have publishing permissions on the repo. You might need to change that if Leo needs to have this right

to clarify — by "publish" I was only referring to changes in the frontmatter :)


Channel control not relinquished on camera reset

On our Imaging Source cameras, hitting ARResetCamera when the camera is already initialized and connected results in a degraded state where the camera cannot be controlled.  The only remedy I have found at this point is to restart the camera.
to reproduce:
aravisConfig("ARV1", "The Imaging Source Europe GmbH-36510395")
ADAravis: Looking for camera 'The Imaging Source Europe GmbH-36510395'...
ADAravis: Your tick frequency is 1000000
So your timestamp resolution is 1000.000000 ns
epics> dbpf test-cam:ARResetCamera 1
ADAravis: Looking for camera 'The Imaging Source Europe GmbH-36510395'...
I am a GigEVision device.
2023/04/28 14:11:25.791 ADAravis:makeCameraObject: Another client has control of this camera.
2023/04/28 14:11:25.791 ADAravis:writeInt32 error, status=3 function=115 ARAVIS_RESET, value=1
2023/04/28 14:11:25.791 FE_SCS1:VD_D0739:cam1:ARResetCamera devAsynInt32::processCallbackOutput process write error
2023/04/28 14:11:25.792 FE_SCS1:VD_D0739:cam1:ARConnectCamera devAsynInt32::processCallbackOutput process write error
2023/04/28 14:11:26.322 ADAravis:writeInt32 error, status=3 function=90 READ_STATUS, value=1
2023/04/28 14:11:26.322 FE_SCS1:VD_D0739:cam1:ReadStatus devAsynInt32::processCallbackOutput process write error
2023/04/28 14:11:27.322 ADAravis:writeInt32 error, status=3 function=90 READ_STATUS, value=1
...

The cause (I think): the GigE channel control privilege register is not reset when ARResetCamera is toggled and makeCameraObject() is called. Therefore, the new device instance comes back without control of the camera.
Proposed solution: relinquish control of the channel if we have an existing camera, that camera is a GigEVision device, and we have client control of the device.
From d84d90db2ead73c53ad6e157c2e5f15dc8daa43c Mon Sep 17 00:00:00 2001
From: Evan Daykin<EMAIL_ADDRESS>Date: Fri, 28 Apr 2023 14:39:56 -0400
Subject: [PATCH 1/1] Fix: Relinquish channel control on reset

---
 aravisApp/src/ADAravis.cpp | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/aravisApp/src/ADAravis.cpp b/aravisApp/src/ADAravis.cpp
index 72fcdef..feb2068 100644
--- a/aravisApp/src/ADAravis.cpp
+++ b/aravisApp/src/ADAravis.cpp
@@ -398,7 +398,20 @@ asynStatus ADAravis::makeCameraObject() {

     GErrorHelper err;
     /* remove old camera if it exists */
+    /* relinquish CCP before unreferencing it */
     if (this->camera != NULL) {
+        if(arv_camera_is_gv_device(this->camera) && arv_gv_device_is_controller(ARV_GV_DEVICE(this->device))){
+            if (!(arv_gv_device_leave_control(ARV_GV_DEVICE(this->device),err.get()))){
+                asynPrint(this->pasynUserSelf, ASYN_TRACE_ERROR,
+                    "%s:%s: Current ArvGvDevice has control, but control couldn't be relinquished. err=%s\n",
+                    driverName, functionName, err->message);
+            }
+            else {
+                asynPrint(this->pasynUserSelf, ASYN_TRACE_FLOW,
+                    "%s:%s: Relinquished control of camera.\n",
+                    driverName, functionName);
+            }
+        }
         g_object_unref(this->camera);
         this->camera = NULL;
     }
--
2.30.2

Closed via #23

../ADAravis.cpp:404:84: error：‘arv_gv_device_leave_control’ not defined?

You need a more recent release of aravis 8.

I followed the instrcution from https://areadetector.github.io/areaDetector/ADGenICam/ADGenICam.html#installing-aravis
git clone https://github.com/AravisProject/aravis
cd aravis/
git checkout ARAVIS_0_8_1
Mybe it need to be updated.

I added a note to the ADAravis RELEASE.md for R2-3:
https://github.com/areaDetector/ADAravis/blob/master/RELEASE.md
This release requires aravis version ARAVIS_0_8_3 or higher, because that is when arv_gv_leave_control() was added.

I also changed the documentation for installing aravis in ADGenICam, to recommend using the latest release, and 0.8.3 as a minimum.
https://areadetector.github.io/areaDetector/ADGenICam/ADGenICam.html#installing-aravis


Refactor MysqlSpecStore into a generalization, MysqlNonFlowSpecStore (not limited to FlowSpecs), also useable for TopologySpecs

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1562

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

The MySqlSpecStore essentially presumes to store only FlowSpecs, and thus would not work for TopologySpecs.  That leaves only the FSSpecStore for them, not a backing RDBMS.  Hence, we refactor MysqlSpecStore into a general store, truly for any Spec object, with nothing specific to FlowSpec.  That now works for topology specs as well.  Still, we retain a specialization with the existing FlowSpec-specific logic supporting search/retrieval.
To maintain backwards-compatibility, we avoid changing/re-naming the semantics of MysqlSpecStore.  So, the refactored SpecStore generalization is named MysqlNonFlowSpecStore.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
New unit test, MysqlNonFlowSpecStoreTest.

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3414 (ffaf754) into master (384dc09) will decrease coverage by 3.33%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3414      +/-   ##
============================================
- Coverage     46.52%   43.19%   -3.34%
+ Complexity    10246     2006    -8240
============================================
  Files          2063      401    -1662
  Lines         80475    17270   -63205
  Branches       8989     2121    -6868
============================================
- Hits          37443     7459   -29984
+ Misses        39567     8973   -30594
+ Partials       3465      838    -2627

Impacted Files
Coverage Δ

...a/org/apache/gobblin/util/limiter/NoopLimiter.java
40.00% <0.00%> (-20.00%)
:arrow_down:

...pache/gobblin/cluster/GobblinHelixJobLauncher.java
67.04% <0.00%> (-14.33%)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...che/gobblin/cluster/FsJobConfigurationManager.java
66.66% <0.00%> (-4.45%)
:arrow_down:

...a/org/apache/gobblin/cluster/GobblinHelixTask.java
60.21% <0.00%> (-2.16%)
:arrow_down:

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
63.46% <0.00%> (-0.33%)
:arrow_down:

...ache/gobblin/runtime/api/FlowSpecSearchObject.java

...che/gobblin/runtime/spec_store/MysqlSpecStore.java

...che/gobblin/runtime/api/InstrumentedSpecStore.java

...apache/gobblin/runtime/spec_store/FSSpecStore.java

... and 1659 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384dc09...ffaf754. Read the comment docs.


Create README

Need to add license (likely MIT)

Closing this issue because the first draft has been created. Additional edits will be made closer to final delivery.


Stanza not working after the fist verse

This works:
::: {.poetry}
| CANTIGA DE MAL DIZER
| Ai, dona fea, fostes-vos queixar
| que vos nunca louv’ en(o) meu cantar;
:::

This doesn't:
::: {.poetry}
| CANTIGA DE MAL DIZER
|
| Ai, dona fea, fostes-vos queixar
| que vos nunca louv’ en(o) meu cantar;
:::

While stanzas in any other part work fine.

What's the result then in the non-working case?

What's the result then in the non-working case?

@jodros Eek, that's what I feared... Hmm so I guess it's a markdown parsing bug.

We can try to fix it in our own vendored version of the lunamark library
But eventually we'll also want it upstream, so we need to craft a lunamark test for it, to prove it's indeed the case.

Workaround with an empty line, this does work apparently:
|
| Blah
|
| Lorem ipsum

(Hence, it does point to a bug in the parsing library)

Reported: https://github.com/jgm/lunamark/issues/83


[#1406] format code using hlint

List of changes
Backend code formatted with hlint
Checklist

related issue
[ ] My changes generate no new warnings
[ ] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the changelog
[ ] I have added tests that prove my fix is effective or that my feature works

Can it be possible to fix also the check-format job?


fix: type 'Null' is not a subtype of type 'String' in getCurrentUser

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Currently the mParticle SDK has a null pointer bug when trying to retrieve the mpid on some Android devices.

Testing Plan

I didn't test it locally, basically I just added a null check, an additional layer of protection to the existing check that only looks if the mpid is an empty string.

Reference Issue (For mParticle employees only.  Ignore if you are an outside contributor)

https://github.com/mParticle/mparticle-flutter-sdk/issues/45

This has been published to pub.dev as version 1.0.5 - https://pub.dev/packages/mparticle_flutter_sdk
Thanks again for your help and apologies this took a bit longer than expected to approve. I had been out for a couple weeks.

@rmi22186 I appreciate it 🙏


Outdated reference to 'Why open source designers need tools beyond text and code'

http://opensourcedesign.net/2015/07/10/this-month-in-open-source-design refers to a blog post by Jan D.:

http://opensourcedesign.net/2015/05/23/TextbasedToolsForDesigners.html

That's no longer found. I found it captured in the Wayback Machine and re-posted at:

Why designers need tools beyond text and code – Medium

Please consider an edit to /2015/07/10/this-month-in-open-source-design to refer to the Medium address for the post.

Related: https://github.com/opensourcedesign/opensourcedesign.github.io/blob/master/_posts/2015-05-24-TextbasedToolsForDesigners.markdown

It seems to be now at: http://opensourcedesign.net/2015/05/23/text-based-tools-for-designers (as a fix for non-case-sensitive OSes?)

And done, thanks for the fix @jdittrich!


Added feature flag to control autoplay.

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

develop

#4052

#4115   👈
#4060

#4078

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on  Graphite


Hangouts logo on splash screen changes size on star up

This is really a minor bug.
The Hangouts logotype on the splash screen changes size when switching between "Connecting" and "Loading contacts".
yakyak_ssize.mov.zip

it doesn't on linux
cool catch :)

corrected in pull request #472
thanks for reporting 👍

@mosbror actually, can you test if the fix works?
Find the binary here:
https://github.com/averissimo/yakyak/releases/download/test-icon/yakyak-472-1.4.0-darwin-x64.zip

actually, that can be a result of having a different zoom level set in yakyak
can you confirm that happens if zoom is at 100% (ctrl+0) ?

It works well for me with your version, just a little drop of the logo margin-top (not its size),it seems that the "Loading contacts" wording changes its font-size during the splashscreen.

i can't fix this blindly, seems like in Mac OS X the relative fonts and margins are changed just after connecting.
Can't reproduce this is linux or windows 7
needs someone to look at this :)

It's very better than before with your patch, don't worry, it's not important ;)

I agree with Silverian.

That's the first thing new users actually see when they try YakYak, should be clean :)
Can you try this: https://github.com/averissimo/yakyak/releases/tag/sandbox

@averissimo It works, you rock !!

PR #477
Thanks for reporting and feedback, closing the issue


chore: migrate from create-react-app to Vite & Vitest

This is an initial PR for Kobot 2024 web app new design implementation. This PR mainly addresses outdated tooling issue since it has not been maintained for a few years. The major changes are:

moved away from CRA(create-react-app) in favor of Vite, which has gained the popularity in web ecosystem among these years, and it's blazing fast
moved away from husky and lint-staged, these tooling came with CRA and no longer a good fit for frontend stack nowadays, this will be replaced by enforce auto-format/lint on save, via vscode workspace settings and github actions (in follow up PR)
upgraded TypeScript to 5.3.3 as this is required for the new tooling stack
upgraded marked to latest version as this is required under more strict type checking
migrated from Jest to Vitest
upgraded prettier and eslint to latest versions, with new coding conventions
lint/format existing auto-fixable issues
fix react-syntax-highlighter type missing
fix all type issues under more strict type checking
removed PWA service worker as the benefit is minimum with current stack and it causes extra app behavior differences between local dev and production

Everything else kept the same. Plan for next step:

update existing github format/lint actions
upgrade remaining packages e.g. React, redux, react-router-dom

🥳 I have just checked-out the code, built it and run it and it does so nicely. Thanks @owen26


'WebKit/WebKit.h' file not found

When I run the app over tvOS I face this error : 'WebKit/WebKit.h' file not found .
MacOS Mojave 10.14 .
Xcode Version 10.1 (10B61)
React version 16.5.1
ReactNative version 0.57.1
Any suggestions ? thanks

Hey @ali-sao, I think this link might help you RCTConvert.h diff

hello @asantarissy , thanks for helping out , I already tried this approach , unfortunately other sources are dependent on the WebKit.h ,which leads to an infinite fixes and conditional imports that messes up tvOS project.

@ali-sao @asantarissy fixed in 0.8.1

Thanks @pavjacko


[release-1.23] respect DNS capture for proxy with auto-assigned addresses

This is an automated cherry-pick of #52612

I think this is a candidate for 1.23.1 but not our .0 release

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.23
2442698e04eab8dacc6da8f80b52d56cfca228a2
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

integ test for ambient is failing because https://github.com/istio/istio/pull/52314 was not cherry-picked so the test still hardcodes the address

@@ -381,20 +380,13 @@ func TestWaypointDNS(t *testing.T) {
                                if src.Config().HasSidecar() {
                                        t.Skip("TODO: sidecars don't properly handle use-waypoint")
                                }
-                               address := "<IP_ADDRESS>"
-                               if _, v6 := getSupportedIPFamilies(t); v6 {
-                                       address = "2001:2::f0f0:239"
-                               }
                                src.CallOrFail(t, echo.CallOptions{
                                        To:      apps.MockExternal,
-                                       Address: address,
-                                       HTTP: echo.HTTP{
-                                               Headers: http.Header{"Host": []string{apps.MockExternal.Config().DefaultHostHeader}},
-                                       },
-                                       Port:   echo.Port{Name: "http"},
-                                       Scheme: scheme.HTTP,
-                                       Count:  1,
-                                       Check:  check,
+                                       Address: apps.MockExternal.Config().DefaultHostHeader,
+                                       Port:    echo.Port{Name: "http"},
+                                       Scheme:  scheme.HTTP,
+                                       Count:   1,
+                                       Check:   check,
                                })

is probably ~minimal diff needed to get this working, not the full #52314

Will manually cherry-pick since it needs a small bit of extra work


As a moderator, I want to create and edit projects in wagtail so that I can manage projects just like other pages.

testing notes
as a moderator
to test this, log into the new admin site (/cms) and check to see if you have a menu on the left side called "Projects".

Make a new project by going to the "Projects" menu, choosing "Project", and clicking "new project" at the top right. Feel free to also give the project an image/thumbnail and create some fake grants for it at the bottom. Make sure to add at least one membership to the project as well, down by where the grants are.
Visit the project's page by clicking "preview" at the bottom. Check that the project page is visually similar to current CDH project pages. The picture displayed should be the main image you uploaded to the project (not the thumbnail). The page should display the membership you added to the project and any grants you added.
Go back to the projects menu and choose "memberships". Are you able to find the membership you created when you made your new project in step 1? Try adding more memberships to your new project using this menu. Going forward, you can add memberships here, or directly on the project - whichever is easier.
Visit the project page again and check that the memberships you added in step 3 are now visible also.

moderators can also manage the list of available project roles, and manage the list of available grant types.

Create a new project role by going to the "Project" menu, choosing "Roles", and clicking "add role" at the top right. Don't worry about "sort order"; anything is fine.
Give any of the project members that you created in the steps above this new role.
Check the project page you created above and see if the list of members has been updated with the new role.
Create a new grant type by going to the "Project" menu, choosing "Grant Types", and clicking "add grant type".
Add a new grant to the project you created above like you did in step 1 above.
Check the project page again and see if your new grant is listed.

dev notes
going to leave Membership and our project association structure largely unchanged for now, but will revisit (potentially in v3.1) to improve it - likely by associating Persons to Projects directly. done
models

[x] Project (becomes Page subtype, uses wagtail image fields, adds tags)
[x] ProjectQuerySet (minimal changes)
[x] GrantType (minimal changes)
[x] Grant (minimal changes)
[x] Role (minimal changes)
[x] Membership (minimal changes)
[x]  ProjectLandingPage - create special LandingPage subtype; cf. PeopleLandingPage

admin

[x] create a new section in the admin for Project-related models using ModelAdmin
[x] set up the main admin for Projects (use ProfilePage as an example)
[x] make Memberships inline-editable on Projects
[x] make Grants inline-editable on Projects
[x] add an admin menu for creating new GrantTypes?

urls
all can be removed.

I created a new project, and included an image, grant, and membership. I was able to "Save Draft," but when I select "Preview," I get the chicken error message. Therefore I wasn't able to get past step one, unfortunately.

@manawinters give this another try; I think we've fixed the issue with previewing.

@thatbudakguy, I tried creating a new project, and got the error message, "The page could not be created due to validation errors"


[QUERY]Why processPartitionClose handler doesn't called when connecting Amqp?

Query/Question
Recently, I encountered an Amqp reconnection when consuming from an EventHub topic.
[partition-pump-0-127] c.p.i.n.p.a.e.ConsumeEventHubUseDdbCpStore ConsumeEventHubUseDdbCpStore[id=270238a6-7bae-319a-9c83-96655aba53cd] EventProcessorClient is connecting to EventHub. eventHubName:xxxx partitionId:0
[reactor-executor-83] c.a.m.e.i.AmqpReceiveLinkProcessor {"az.sdk.message":"Receive link endpoint states are closed. Requesting another.","linkName":"0_bd5efa_1658980830991","entityPath":"xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0"}
[reactor-executor-83] c.a.m.e.i.AmqpReceiveLinkProcessor {"az.sdk.message":"Setting next AMQP receive link.","linkName":"0_bd5efa_1658980830991","entityPath":"xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0"}
[boundedElastic-256] c.a.m.e.i.AmqpReceiveLinkProcessor {"az.sdk.message":"Receive link endpoint states are closed. Requesting another.","linkName":"0_bd5efa_1658980830991","entityPath":"xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0"}
[reactor-executor-83] c.a.c.amqp.implementation.ReactorSession {"az.sdk.message":"","exception":"Cannot create receive link from a closed session., errorContext[NAMESPACE: xxxx.servicebus.windows.net. ERROR CONTEXT: N/A, PATH: xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0]","connectionId":"MF_0e96f3_1659090578660","sessionName":"xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0","entityPath":"xxxx/ConsumerGroups/consumergroup-xxxx/Partitions/0","linkName":"0_bd5efa_1658980830991"}

We were using the EventProcessorClient to read.
The EventProcessorClient has processPartitionClose handler and processPartitionInitialization handler set.
At this time, only processPartitionInitialization handler was called.
Why processPartitionClose handler didn't called?
I think both processPartitionClose and processPartitionInitialization handler should be called when reconnecting Amqp.
(Our EventProcessorClient saves the last checkpoint using the processPartitionClose handler.)
Setup (please complete the following information if applicable):

OS: Linux
IDE: Eclipse
Library/Libraries: azure-messaging-eventhubs:5.11.1

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Query Added
[x] Setup information Added

Hi @kohei-kitaura thank you for reach out to us via this GitHub issue.  Someone from the Event Hubs SDK crew will follow up with you shortly.  /cc @Azure/azsdk-sb-java

The Processor instance is supposed to run until it is explicitly closed or if the partition it was processing was stolen by another processor instance.
When one of the above cases happens, the close handler is invoked with appropriate reason azure-sdk-for-java/CloseReason.java at main · Azure/azure-sdk-for-java (github.com).  Otherwise, the processor is designed to recover from any transient errors so that the application can continue to receive from the partition.

Thanks for your anwer, @anuchandy .
So the SDK behavior is that both processPartitionClose and processPartitionInitialization are not always called. I see.
/unresolve
In a case like this, is there any chance to save the last checkpoint?

Users would have to keep an internal state of what EventData was last processed.  When the EventProcessorClient recovers from a transient error, it starts reading from the last EventData sequenceNumber that was pushed downstream.  Consequently, the user shouldn't see any difference in behaviour.

Thanks for your anwer, @conniey .
/unresolve

When the EventProcessorClient recovers from a transient error, it starts reading from the last EventData sequenceNumber that was pushed downstream.

In this case, I think it's not true.
The SDK initialized the partition with an old checkpoint and called the processPartitionInitialization handler.
But processPartitionClose handler was not called. As a result, the EventData was duplicated.
Is this a bug? At least it doesn't seem transparent.

Does anyone have an opinion on this issue?

As a result, the EventData was duplicated.

The guarantee of EventProcessorClient is "at least once". (https://stackoverflow.com/a/33577018/4220757) If we want only once, Service Bus may be the service to go with or consider adding some logic to understand when EventData when duplicated.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_c92b6e38-7531-4777-a5f0-b67bfbf2eb0c/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_c92b6e38-7531-4777-a5f0-b67bfbf2eb0c.git

Docs Build status updates of commit d68b0e1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd4, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Chapter 11 - Naive Bayes Model - Error

Running the Notbook for chapter 11, I get the following error:

ModuleNotFoundError                       Traceback (most recent call last)
~\AppData\Local\Temp/ipykernel_16204/2361416811.py in
2 sys.path.append("..")
3
----> 4 from data_modules.utility import get_target_features
5 y, X = get_target_features(data)
6
ModuleNotFoundError: No module named 'data_modules'

Due to the fact that I am running in Windows. I could fix the issue with the following change in code:
import sys
#sys.path.append("..")
#Yo have to explicity define the Directory wher the utility.py file is
path =  "C:/Users/I008123/OneDrive - SAP SE/Documents/a_Machine Learning Practice/Libro Machine Learning in Trading/ml-trading-book-main/ml-trading-book-main/Python Codes"
#from data_modules.utility import get_target_features
#eliminate the file system name and put directly the name of the file utility. py (without the extension)
from utility import get_target_features
y, X = get_target_features(data)


i18n(ko-KR): update middleware.mdx

Description (required)

update middleware.mdx
#8572

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
guides/integrations-guide.mdx
Localization changed, will be marked as complete.

ko
guides/middleware.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

This is wrong PR. The issue this PR was trying to solve is fixed in #8591.


Why getElementsByTagName return a NodeList instead of a HTMLCollection

Due to https://developer.mozilla.org/en-US/docs/Web/API/Element/getElementsByTagName. The selecting methods beside querySelector(All) are return a HTMLCollection

From https://github.com/WebReflection/linkedom#faq

Are live collections supported?
The TL;DR answer is no. Live collections are considered legacy, are slower, have side effects, and it's not intention of LinkeDOM to support these, [...]


Luau precompiled Ubuntu binary uses very new glibc version.

Since #769 was merged, Luau's GitHub actions script now builds the Ubuntu executable with a glibc version of at least 2.34. This effectively cuts the precompiled build from being used on any systems older than Ubuntu 22, unless obtaining glibc outside of the default repositories.
Sample output:
# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal
# ./luau
./luau: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./luau)
./luau: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./luau)
./luau: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./luau)

Since Ubuntu 22 was released this year, this limits the scope of users who can use the precompiled binary.

This is caused by GitHub Actions slowly rolling out a change of ubuntu-latest from ubuntu-20.04 to ubuntu-22.04 (see https://github.com/actions/runner-images/issues/6399). It is most likely the cause of the initial issue of clang++10 being missing in that PR.

Thank you, I'll try switching to ubuntu-20.04 in our Github Actions. And back to clang++10 for coverage because 11 has regressions in coverage information.

Latest release binaries should be build on Ubuntu 20.04


Update the templates

What does this PR do?

Fixing #241
Before submitting

[x] This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
[x] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[x] I have commented my code, particularly in hard-to-understand areas.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 81.013%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
7343

Relevant Lines:
9064

💛  - Coveralls


Git branch persists even after buffer change

Suppose I open a buffer and the file is at a git folder. The branch is displayed, which is good.
Now, I switch to another buffer with a file at another folder that is not (and neither its parents are) git-controlled. The git branch from the previous buffer will persist on the status line for the new buffer. Even if I close the previous buffer, the git branch persists.
Not sure what the issue is; maybe something about async?

Nice catch, this is also an issue with the signify component but I think these are two different bugs, I will try to fix this tomorrow.

Nice catch, this is also an issue with the signify component but I think these are two different bugs, I will try to fix this tomorrow.

Should be  fixed :)

Should be  fixed :)

thanks, looks good, indeed. If there is any issue, I will report.

thanks, looks good, indeed. If there is any issue, I will report.


Extra space added after quote character

Hi, thanks for the great library!
One small thing I bumped into is that it adds an extra space after block quote symbol (>):
telegramify_markdown.markdownify(">quote")
# result: '> quote\n'

This space is actually preserved by Telegram. For larger quotes it leads to the following problem:

Um, so you expect to align them?

I'll release a patch to fix this


SerDe org.embulk.spi.ColumnConfig and org.embulk.spi.SchemaConfig with Jackson Modules

Several Embulk classes have had annotated with Jackson's annotations like @JsonCreator, @JsonProperty, and @JsonValue. To remove Jackson from embulk-core, those annotations need to be removed.
Instead of the annotations, the classes can still be serialized/deserialized by registering a Jackson Module to ObjectMapper with appropriate JsonSerializer and JsonDeserializer implemented. It works only for SerDe with ModelManager, though. (It won't work for arbitrary ObjectMapper, but we give it up. We haven't observed such a plugin so far.)
It is a replacement from annotations to a SerDe Module for org.embulk.spi.ColumnConfig/SchemaConfig.

Thanks!


fix(operaor): handle apparmor and security fs mounts

Purpose of PR?:
This PR handles the cases:

/etc/apparmor.d is not present on host to be mounted with KubeArmor daemonset when apparmor enforcer is being used.
/sys/kernel/security is not present to be mounted with kubearmor-controller.

when the operator is used to deploy the KubeArmor. In both the cases, if required path is not present, kubearmor darmonset or controller will be deployed without the mount.
Fixes #
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@VedRatan to test it out.

@VedRatan can you paste the karmor probe result here thanks

Why is kubearmor not running? Audit Policies should work?

You should see details about kubearmor in karmor probe


rkt: disable fetch progress bar when running under systemd

Run rkt under a systemd unit like this:
$ sudo systemd-run --uid=0 ./rkt --debug run --insecure-skip-verify run docker://redis

Now check out the log lines as it is fetching the image:
$ journalctl -u run-1264.service  -f
-- Logs begin at Mon 2015-08-17 01:20:44 UTC. --
Aug 17 06:36:55 core-01 rkt[1265]: [1.9K blob data]
Aug 17 06:37:09 core-01 rkt[1265]: [1.9K blob data]

Not super useful. We need to disable the progress bar and just print out progress instead when we detect that we aren't on an interactive TTY.

I did a quick test and even if we print simple numbers with the ioprogress library the output is [23B blob data] so we'd have to modify it somehow or implement our custom progress.


fix message logger

I forgot that my prettier settings are somewhat different than yours so those are the other edits.

Cheers mate, i did mean to run a find replace but I've had a busy day


YamlDotNet: v8.1.2 doesn't support our line number beautification

After upgrading YamlDotNet from v6.1.2 --> v8.1.2, the message beautification tests for NeonHelper.YamlDeserialize<T>() are failing.  This verifies that we can replace the somewhat ugly character markers for the error with just a simple line number.
This used to work with v6.1.2 but is failing now because YamlDotNet always add the marker text.  There really isn't a workaround other than defining our own exception for this which seems silly.
We're going to drop the beautification effort and tweak the unit test to verify that the message matches the deserialization error instead.

FIXED for v2.2.0


Allow macos 11 to be used

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
i cant use homebrew on macos11
What is the motivation for the feature?
to let macos 11 users use homebrew
How will the feature be relevant to at least 90% of Homebrew users?
its only relevant to macos 11 users
What alternatives to the feature have been considered?
none

If you have an issue, please open an issue instead.


a post with redirect: link broken?

Discussed in https://github.com/alshedivat/al-folio/discussions/1818

Originally posted by ckassung October 12, 2023
Dear @,
if I access the blog entry "a post with redirect" not directly from the blog section via
https://alshedivat.github.io/al-folio/assets/pdf/example_pdf.pdf
but from a tag (2022) the link is
https://alshedivat.github.io/al-folio/blog/2022/redirect/
and does not show the pdf. Would be great if anybody could fix it.
Best, Chris

thanks for reporting, looks like this is a bug.


Bringing description up to date

Over the years OSVVM has evolved and increased in capability.   The new description reflects the additional capability.

Thanks!


Update setup.sh

Added f flag to the rm command otherwise the script always fails on first run as the directory never exists.

Thank you for providing the fix!


Dependabot version increment fix

Fixes the issue where dependency updates to package.json are overran by the version increment check by using show instead of checking out main package.json for the version check.
Tested in this branch.

CI fails because frontend version has not been incremented. I would ignore this since there's no changes to the project itself. Just to the pipeline


feat: add ssl support for mongodb

Same as done in dropwizard-commons, this provides the ability to configure the needed certificates at deployment.
One of our services needed this to support documentdb.

Thanks a lot ❤ @saadmar


Add new OMs of the Month

@TheImmortal

travis is being weird rn, test hasn't started yet

I tested it locally


Retry HTTP downloads

Description
When a http dependency fails to download, please retry the request. I see a lot of transient errors with sourceforge.
Repro steps

Add http https://downloads.sourceforge.net/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip and try to restore.

Expected behavior
Retry like we do with NuGets for x times, then fail.
Actual behavior
Paket version 5.145.6
Downloading downloads.sourceforge.net/:/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip optipng-0.7.7-win32.zip to C:\BuildAgent\work\e3efd18142ae7728\paket-files\downloads.sourceforge.net\optipng-0.7.7-win32.zip
Performance:
 - Average Download Time: 22 seconds
 - Number of downloads: 1
 - Runtime: 22 seconds
Paket failed with
-> Could not download from 'https://downloads.sourceforge.net/project/optipng/OptiPNG/optipng-0.7.7/optipng-0.7.7-win32.zip'
-> HttpRequestException: An error occurred while sending the request.
-> WebException: Unable to connect to the remote server
-> SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443

Known workarounds
Restart paket restore.

Thank you very much!

already helping me in another scenario...

I'm glad you benefit as well :) 👍


How to handle no internet connection

Thanks for this great project
I tried your code, but its show whole IP address of API, but I want to show only "no internet connection when there is no internet connection"

In this project, We are simply sharing the exception message or a generic message "Something Went Wrong"
We can handle no internet available scenario based on our application architecture to check the internet before making call.
https://github.com/MindorksOpenSource/Kotlin-Coroutines-Android-Examples/blob/adc18ea7213887e0da6924bd6efa0bf0158e60de/app/src/main/java/com/mindorks/example/coroutines/learn/retrofit/single/SingleNetworkCallViewModel.kt#L31


FR: Add missing header with function definition for inline functions

A typical pattern in V8 is to define small member functions in -inl.h files.
foo.h
class Foo {
  inline void bar();
};

foo-inl.h
void Foo::bar() { ... }

foo.cc
#include <foo-inl.h>

// ...
  foo.bar();
// ...

Currently clangd will insert the foo.h header on access to Foo. Could clangd also detect, possibly on member compilation, that Foo::bar is an inline function, and include the defining foo-inl.h file when necessary?

doesn't foo.h include foo-inl.h?

The opposite, foo-inl.h includes foo.h. It's kind of a similar problem to forward declaring headers, except it's "forward declaring" the inline member function.

So it seems like completing the method only requires the inl file, and the class itself only requires the plain header file.
(In practice this means you'll end up with both and people might not like that flavor of IWYU, but let's ignore that for now)
This means it would fit into our existing include-insertion scheme. The only catch is that the results come from sema but the insertion info is in the index, so we have to query the index after running code complete. (We currently do this for signature help but not code complete: https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/CodeComplete.cpp#L861-L878). This will increase latency when the index is remote.
On the other hand, it may also provide us with useful scoring signals.
This seems like a really hard tradeoff actually, inserting an extra LookupRequest into member completion is a pretty big cost :-\


eureka: fix log error Uncaught TypeError: Cannot read property 'primaryWeather' of undefined

Seems to mitigate #834..

Good catch, thanks!


Add go build for unexperienced users (like me)

Add the go build step to the install instructions
I'm new to GO and tried to install via go get, it took me a while to realize that I had to run go build in order to make it work.

Weird, it did not work for me until I did the build step.
But again, I just installed Go and have no previous experience with it.
On 24 Jun 2019, 13:41 +0200, Michael Skelton<EMAIL_ADDRESS>wrote:

@codingo commented on this pull request.
This shouldn't be neccessary? Once you go get a build is automatically done and the binary is placed in /go/bin. This step you've done here would just duplicate that binary in /go/src. The addition is great, but I think it would be better to amend it to instead let people know to look for the binary in /go/bin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@codingo , you are probably right.
It looks more like an issue with ~/go/bin is not in my $PATH...

Not a problem at all, have a good day!


add mkFlakeDoc to pkgs-lib to build options doc

Just built the doc - requires a bit of fen-angling - because current api-next flake doesn't work since mkflake hasn't been updated. We can use this PR to go over option/type descriptions and include any doc improvements.
Overall I think the descriptions can use some work, we need to clearly communicate what each API argument is for and the reasoning behind the option. I think a fresh set of eyes could help with that, especially someone who wasn't part of all the discussion for the API design.
This document should be able to quickly answer questions like "What happened to extern?" or "How should I import modules from other flakes?".
I should not attempt to cover everything - thats what the other doc sections are for - just a simple and straightforward summary of what each argument provides and is used for.
This replaces parts of #232.

This might need updating after release cleanup.

I went ahead and added a rebased (but not optimized) version of this into the api-next branch here.
It works as intended with nix build .#jobs.mkFlakeDoc (on x86_64-linux, only).
Hence, I'm going to close this so we can continue over there.


BAMF FDG-Avid Breast Tumor

AIMI1 - Pretrained model for 3D semantic image segmentation of the FDG-avid lesions from PT/CT scans

sample:
  idc_version: Version 2: Updated 2020/01/10
  data:
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.200887946066796652452097013479
    aws_url: s3://idc-open-data/7a375cfa-8708-46f0-b056-248dbaca851e/*
    path: case1/ct
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.182230913012492714502249429083
    aws_url: s3://idc-open-data/739449f3-286c-4511-86a9-39172a50dc95/*
    path: case1/pt

reference:
  url: https://drive.google.com/file/d/1afkRFJqwgii1tUSMiQV_dPlDsUBl6_0g/view?usp=sharing

Archive.zip
Slicer screenshots added

/test
sample:
  idc_version: "Data Release 2.0 January 10, 2020"
  data:
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.200887946066796652452097013479
    aws_url: s3://idc-open-data/7a375cfa-8708-46f0-b056-248dbaca851e/*
    path: 'case_study1/ct'
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.182230913012492714502249429083
    aws_url: s3://idc-open-data/739449f3-286c-4511-86a9-39172a50dc95/*
    path: 'case_study1/pt'

reference:
  url: https://drive.google.com/file/d/1yivXqTBMXslsmj3uD8gE9LojLCKh-BqV/view?usp=sharing

@jithenece I wanted to run our test routine on all read for testing PR's, however, I noticed, the sample reference url you provided won't work with wget -O /tmp/ref.zip $RESSOURCE_URL. This might be specific to using a google drive link, however, I generally advice you to instead to attach your data to the PR directly (e.g., by uploading them to the comment) and to use the permanent link as a reference.

/test
attaching segmentation
output.zip
sample: 17.0
  idc_version:
  data:
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.539267076861125410814830191835
    aws_url: s3://idc-open-data/84c9b972-76e1-4fa3-a7ea-19b6500e497a/*
    path: case_study1/ct
  - SeriesInstanceUID: <IP_ADDRESS>.4.1.145<IP_ADDRESS>.8162.7003.196821690630879561473146713439
    aws_url: s3://idc-open-data/33f0bd14-4bf5-469c-83db-183e1ab96f02/*
    path: case_study1/pt

reference:
  url: https://github.com/user-attachments/files/16927110/output.zip

Please note, we updated our base image. All mhub dependencies are now installed in a virtual environment under /app/.venv running Python 3.11. Python, virtual environment and dependencies are now managed with uv. If required, you can create custom virtual environments, e.g., uv venv -p 3.8 .venv38 and use uv pip install -p .venv38 packge-name to install dependencies and uv run -p .venv3.8 python script.py to run a python script.
We also simplified our test routine. Sample and reference data now have to be uploaded to Zenodo and provided in a mhub.tom file at the project root. The process how to create and provide these sample data is explained in the updated testing phase article of our documentation. Under doi.org/10.5281/zenodo.13785615 we provide sample data as a reference.


Improve Chart Tooltips & Colours

We want to make nicer tooltips to give the appropriate look and feel when there is a lot of data to view.

Continuation of #1130 & #1022
Tooltip Changes

Make sure it's a straight fixed line, not point based
We want to show the x-value at the top of the graph
Multiple Lined Graphs: We want to legend items, the name line & the value
Example:

Single Lined Graphs: We want to just show the name of the line & the value

Colour changes:

For the successful requests use green-400
For the failures use red-100
Distinguish them for colorblind users use different patterns in the shaded areas -- https://www.patternfly.org/v4/charts/patterns (use the first two PF offers)

@alexcreasy  - believes it is done and just needs to verify that the work is complete - should be able to verify today (10/27/23)

@dgutride - I had some cluster issues following the PSI outage, I've got most the way to rebuilding it, but unfortunately I've run out of time. This is on the list for Monday (10/30/23)

All but one of the acceptance criteria in this ticket are already met. The only outstanding item is that the colours for success / failed requests are not correctly set to red / green. I'll start working on a fix for this right away.

PR Raised for this issue here: https://github.com/opendatahub-io/odh-dashboard/pull/2030

@alexcreasy I think this is probably OK to get us into incubation, but once we start seeing real data we might want to change how the data is presented. For example, this is supposed to be a stack chart. The hashing makes that less clear. Is that absolutely necessary for a11y?

Paraphrasing our discussion on slack: I inherited this ticket and the requirements stated green / red colours with hashing for a11y. If that's not necessary I'm totally happy to change the implementation.

Based on our slack discussion I've removed the shading.


Use a constant name for node name crc-abcde

It allows crc and consumers of snc to have a static DNS configuration.
It doesnt depend anymore of a random name picked by the installer.

Only few files contains the random name, it is faily easy to change.
crc-tmp-install-data/manifests/cluster-infrastructure-02-config.yml
15:  infrastructureName: crc-abcde

crc-tmp-install-data/openshift/99_openshift-cluster-api_master-machines-0.yaml
6:    machine.openshift.io/cluster-api-cluster: crc-abcde
9:  name: crc-abcde-master-0
27:      networkInterfaceName: crc-abcde
31:        baseVolumeID: crc-abcde-base
32:        poolName: crc-abcde

crc-tmp-install-data/openshift/99_openshift-cluster-api_worker-machineset-0.yaml
6:    machine.openshift.io/cluster-api-cluster: crc-abcde
9:  name: crc-abcde-worker-0
15:      machine.openshift.io/cluster-api-cluster: crc-abcde
16:      machine.openshift.io/cluster-api-machineset: crc-abcde-worker-0
21:        machine.openshift.io/cluster-api-cluster: crc-abcde
24:        machine.openshift.io/cluster-api-machineset: crc-abcde-worker-0
41:          networkInterfaceName: crc-abcde
45:            baseVolumeID: crc-abcde-base
46:            poolName: crc-abcde

/retest

/retest

/retest

doesn't fail on mirror.openshift.com now, but instead:
NWRAP_ERROR(103) - nwrap_files_cache_reload: Unable to open '/tmp/packer/passwd' readonly -1:No such file or directory
NWRAP_ERROR(103) - nwrap_files_getpwuid: Error loading passwd file
NWRAP_ERROR(118) - nwrap_files_cache_reload: Unable to open '/tmp/packer/passwd' readonly -1:No such file or directory
NWRAP_ERROR(118) - nwrap_files_getpwuid: Error loading passwd file
NWRAP_ERROR(122) - nwrap_files_cache_reload: Unable to open '/tmp/packer/passwd' readonly -1:No such file or directory
NWRAP_ERROR(122) - nwrap_files_getpwuid: Error loading passwd file
unknown user<PHONE_NUMBER>
ERROR: (gcloud.compute.scp) [/bin/scp] exited with return code [255].
error: failed to execute wrapped command: exit status 255

/retest

At the moment, crc is fine with this dynamic name, it picks it from the bundle metadata, and adjusts the DNS configuration as needed. This change would remove the "pick it from the bundle metadata" part, we'd still need to setup the name resolution for crc-abcde somewhere.
This change would help with https://github.com/code-ready/crc/pull/1526 as at the moment it's not possible for crc start to dynamically update the DNS information when it knows which bundle it's  dealing with. My understanding is that the code in this PR is already hardcoding crc.testing and apps-crc.testing rather than getting them from the bundle information. So the bigger question is how strongly we want to tie crc with the bundles snc generates. Currently we try to go through the bundle metadata file for any bundle specific information, even if  some of these values never changes.
I'd prefer that we keep some flexibility, and rather than hardcoding things crc has no control over, we could have a way to feed the bundle metadata to the userland DNS implementation so that it can update its behaviour (or is this a ton of work?)

I hack a bit the userland netstack and now I use a regexp for this domain. https://github.com/guillaumerose/gvisor-tap-vsock/blob/master/cmd/host/main.go#L63

@guillaumerose If we don't need it anymore, can we close this PR or you are planning to have this to be part of bundle and not use the regex as part of vsock codebase?

Yes closing it.


Missing instruction to build ros package

On Ubuntu 20.04, ROS Noetic, with
$ uname -a
Linux maupas 5.15.0-107-generic #117~20.04.1-Ubuntu SMP Tue Apr 30 10:35:57 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

In the building instructions at https://github.com/inertialsense/inertial-sense-sdk/tree/main/ros#setup, there is a missing line, just right after the clone:
cd inertial-sense-sdk; git submodule update --init --recursive
otherwise required libs like libusb are not found,  and a linking error appears.

@andreucm Can you follow up on this issue as well, regarding any issues with ROS instructions?


minor, fix sonar reported bugs

Proposed changes
fix several sonar reported bugs or issues: https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&resolved=false&severities=BLOCKER&types=BUG
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 6256

16 of 65 (24.62%)  changed or added relevant lines in 12 files are covered.
11 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.004%) to 28.031%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
0
1
0.0%

core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RetentionPartialResult.java
0
1
0.0%

engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/RowRecordReader.java
0
1
0.0%

core-common/src/main/java/org/apache/kylin/common/KylinConfig.java
4
6
66.67%

engine-mr/src/main/java/org/apache/kylin/engine/mr/CubingJob.java
0
4
0.0%

engine-mr/src/main/java/org/apache/kylin/engine/mr/common/CubeStatsReader.java
3
7
42.86%

core-cube/src/main/java/org/apache/kylin/gridtable/benchmark/SortedGTRecordGenerator.java
0
5
0.0%

datasource-sdk/src/main/java/org/apache/kylin/sdk/datasource/adaptor/DefaultAdaptor.java
2
8
25.0%

tool/src/main/java/org/apache/kylin/tool/extractor/MrJobInfoExtractor.java
0
11
0.0%

core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
1
58.11%

engine-mr/src/main/java/org/apache/kylin/engine/mr/common/CubeStatsReader.java
1
64.12%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java
2
77.78%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
66.67%

Totals

Change from base Build 6246:
0.004%

Covered Lines:
26241

Relevant Lines:
93615

💛  - Coveralls

Has passed integration test.

This looks good to me.


Feat: Make overlay purple when element is a component

Description
Made the component outline purple when selected on a canvas using hex code #A020F0

What is the purpose of this pull request?

[x ] New feature
[ ] Documentation update
[ ] Bug fix
[ ] Refactor
[ ] Release
[ ] Other

Unable to figure out the logic here :(

@Kitenite I'm not sure if I implemented the logic as you requested. Been stuck on the issue. Could you review?

@SkyC0der hey, it's no problem! I added the infrastructure logic for handling this.
I realized in the process that:

I designed and explained this issue poorly
This was much more complex than I had anticipated

Thanks for giving it a try!

Thanks @Kitenite . Going through your implementation and apparently there's a lot for me to learn

No problem @SkyC0der like I mentioned, this should not have been marked as a "good first issue" on our part 😅. I don't think I would've been able to do it if I didn't know the codebase well already.
I really appreciate the quickness and the willingness to ask for help!


Any chances to have this working as a vue component?

I don't know how to do this (yet), but it would be nice to make it work as a vue component. Has anyone done it successfully with the latest version of the script?

I think this is just a work around, but it works.
<template>

</template>

Saw this issue and decided to make this:
https://github.com/khalby786/vue-utterances
Would appreciate it if you could star the repo!