JSONPath limited to non-array types

I know this is a documented limitation, but it would be nice to test array types and not take the first element.

Ideally, this zzapi test would be written as:
$.data.phoneNumbers[*].type: [ mobile, home ]

We had discussed this and for some reason keeping the array as is interfered with something. We must think and recollect whether other changes have overcome that original interference.

If I recall: the issue was primarily that jp.query returns an array of matching results, and if there are multiple matches, we would not know which one to run all of the tests against (unless we run them against all, in which case some are bound to fail). Thus, we stuck to jp.value, which returns the first match, and said that any other ones have to be explicitly stated.
We could assert against all matches in cases like the above where there are no object tests, but that would mean treating this one type of test differently from the rest.

if there are multiple matches, we would not know which one to run

Shouldn't this be one equality test against the array? Expected array === actual array.
As a user, I would also expect this to work, but it is consistent with the first example and only takes the first array element.
$.data.phoneNumbers[*].type: { $eq: [ mobile, home ] }

Ah yes, I agree. Another possible reason might have been that  the matches would be non-intuitive in certain cases, such as cases where there is only a single match. If we always ask the user for a list of matches, then cases such as $.data.address.streetAddress would require the user to specify ["naist street"] instead of just "naist street", for example.
I'm fairly certain this isn't the reason we decided to adopted jp.value in the first place though, I'll have to try to recall the exact reason for that. If we can remember that then we can conclusively move on to jp.query.

Ah. That seems to be the case. I agree wrapping the value to make it array is awful.
How about if the expected value is a scalar, then this requires the jp.query result to have a single element.

@vasan-agrostar thoughts? This makes sense to me.

Yeah, makes sense. But the expected value has to be a non-array (scalar, or an object) for us to use the first value. If the expected value is an array, then we keep the array returned from JSONpath. @Varun0157 can you look through the code and see if this will cover everything? We may also need to check if the returned array has more than one element and treat it as an array else pick the first/only element.

From a code perspective, it would work - but I think this change could still cause some confusion to the user, right?
I see two options based on the discussion above:

If the expected value is a scalar, then there should be a single element received (we check for this), and we do a direct comparison. The potential confusion I see with this is that objects (for example) would still need to be wrapped in an array. So if I'm only expecting { a : b }, I still have to write it as [ { a : b } ].
Even if we extend this from scalars to non-arrays, the same issue arises: if I'm expecting [a, b], I would have to write it as [[a, b]], but would not have to do this for any other case.

If the result of jp.query has a single element (i.e., the received value), then the expected value should not be wrapped in an array. This makes more sense to me, where if there is a single result we can write it on it's own, else, we need to write them as an array, but I'm not sure if that's less intuitive.

Are these valid options, and are there others? If not, which of the above is better?

Objects
I'm confused by your point 1 on object checks. If we are expecting an object and jp.query returns an array, wouldn't we be comparing the expected object to the first element of the array just like the scalar value approach?

Arrays
I think we can avoid the [][] issue with a proper JSONpath expression, we just need to clearly document that tests are always written using JSONpath expressions.

$.phoneNumbers
$.phoneNumbers[:] or  $.phoneNumbers[*]

Different options
Essentially, the decision to be made is this: when to use the entire array result of jp.query and when to pick the first element. Here are the options I can think of:

Implictly understand what to do
a. Based on expected value (RHS) type
b. Based on the number of elements in the return of jp.query
c. Based on both
d. Based on either
Let the user explicitly specify how to match
b. Differentiate based on { $eq: [] } vs plain [] in the RHS
a. Add a pseudo operator $multi

Document example
[
    {
        "name": "John",
        "phoneNumbers": [
            {
                "type": "iPhone",
                "available": [7,22]
            },
            {
                "type": "home",
                "available": [21]
            }
        ]
    },
    {
        "name": "Mary",
        "phoneNumbers": [
            {
                "type": "Android",
                "available": [7,22]
            }
        ]
    }
]

1a. Implict, based on RHS type
Rule: if the RHS is an array, use the jp.query array as is, else pick the first element to compare with.
  $.[?(@.name=="John")].phoneNumbers.0.type:         { $eq: home, $type: string }
  $.[?(@.name=="John")].phoneNumbers.0.available:    { $eq: [7, 22], $type: array } # FAIL
  $.[?(@.name=="John")].phoneNumbers.0.available:    { $eq: [[7, 22]], $type: array } # Pass 1
  $.[?(@.name=="John")].phoneNumbers.0.available[*]: { $eq: [7, 22], $type: array } # Pass 2

The second test is the natural way to write it. But it will fail because jp.query will return [[7,22]]. You will have to use the third or fourth forms.
1b. Implicit, based on jp.query result
Rule: If the result of jp.query has more than one item, use the entire array to compare with, else, use the first and only element to compare with.
  $.[?(@.name=="John")].phoneNumbers[*].type: { $eq: [ iPhone, home ] }
  $.[?(@.name=="Mary")].phoneNumbers[*].type: { $eq: [ Android ] } # FAIL
  $.[?(@.name=="Mary")].phoneNumbers[*].type: { $eq: Android } # Pass

The second test is the natural way to write it, but because since the result of jp.query has only one element, we will use that for comparison. You have to remember to use the third form, depending on the number of elements you are expecting.
1c. Both the above
Rule: Both conditions have to be satisfied. RHS has to be an array, plus, jp.query should return multiple values.
Result is same as option 1b. The second test will fail.
1b. One of the above
Rule: either the RHS is an array OR jp.query returns multiple values.
The result is the same as option 1a. The second test will fail.
2a. Explicit based on spec
We don't allow this form:
  $.something: [a, b, c]

That's because we insist on a scalar at the RHS. Otherwise, it is interpreted as an object with multiple assertions. We didn't think through an array. But it is OK to use this form, and based on this, we can differentiate between how to use the jp.query result.
$.something: [ a, b, c ] can compare the jp.query result as is. Whereas $.something: { $eq: [ a, b, c ]} can compare the first element (and we expect only one element).
But then, you'd like to think $.something: X is the same as $something: {$eq: X, ... } with some more assertions/options. Making them behave differently breaks the intuitiveness.
2b. Explicit with an option a-la skip
  $.something: { $eq: [ a, b, c] } # test jp.query()[0] === [ a, b, c ]
  $.something: { $eq: [ a, b, c], multi: true } # test jp.query() === [ a, b, c ]

We can come up with better names for multi. Maybe all or pattern or query.
Evaluation
I think being explicit makes sense. Further, it gives us an opportunity to fix false positives (undetected failures) which are far worse than false negatives. In most of the other options, there is a possibility of a false positive. The API response can be in a form that matches the expectation, especially when we rely on the results to tell us what to do.
Few more things:

Our current implementation can have false positives. The output can have multiple elements that match the query, but we compare against only one. It is an improvement to explictly expect multiple matches vs. a single match. There is no way to assert that the given path should only have one match. Option 2b gives us the opportunity to fix that. If jp.query is not expected to return multiple values and it does, we can make it fail.

We can think of allowing $.something: [ a, b, c ] rather than force the user to use the $eq operator. We cannot allow $.something: { type: 'Android' } etc, because when we detect an object in the RHS, we interpret it as a spec that has operators like $gt. But an array can surely be allowed.

We should probably remove the $ in the $skip option. In $.something: { $sw: Y, $gt: Z } all operators start with a $. The other stuff like multi and skip are options, not operators. They don't need to start with a $. We really don't need the $ for operators either, but we kept it to match the familiarity with MongoDB filter operators.

Ah, and one more thing. We should potentially be able to check the type of each nested sub-element in an array.
  $.[*].phoneNumbers[*].number: { multi: true, $type: string }

I am not aligned with this, which is essentially my option 1a. There are no ambiguities here I agree. But:

The mental model I expect users to have is that the path results in a single value. That value can be an object, an array, or a scalar, expected to be treated uniformly. And this is what most people will be asserting against. The fact that JSONPath returns an array is not intuitive to me. But this is the best library we found. Forcing users to understand this vagary about JSONPath is an unnecessary burden except for the advanced or expert users.
I expect the multiple-value comparison to be a rare use case. I would rather make rarer use cases harder to specify and common use cases simpler.
I have test cases in my repo where the RHS is an array, a single return value from JSONPath query. Just like the available: { $eq: [7,21] } case. Now, if we implement this change, it will break my tests. And others' tests too, if they have used it like this. We will have to rewrite them like { $eq: [[7,21]] } which is quite unintuitive to me.
Saying what is expected explicitly is simpler to understand, though it may be harder to specify in some cases.

So I am proposing:

By default, we expect the jp.query result to be a single value. If it returns multiple values, the assertion will fail (with a helpful hint that you should use the multi option, if that is what you want).
If the expected result of jp.query is an array of multiple matches to the expression, you will have to explicitly say so, eg, $.data.phoneNumbers[*].type: { $eq: [ mobile, home ], multi: true }
And in this case, the entire result will be passed as is to the $tests operator, if any. So you could write:

$.data.phoneNumbers[*].type:
  multi: true
  $tests:
    $.0: mobile
    $.1: home

Further, unrelated to this change we will also do the following:

Allow the RHS to be an array without needing to put it under { $eq:  ...}, like this: available: [7,21]
Deprecate $skip and use skip. (All options are without the $, all operators are with the $`)

In support of these changes, assuming some proposal moves forward, can we leverage Jest to validate whatever implementation is selected? https://github.com/agrostar/zzapi-vscode/issues/18 is a good example of something that would have been caught with some test automation and these changes will be difficult to validate if the project keeps moving ahead with manual QA.

Yes, we do have automated tests in zzapi-cli. I am not sure why it didn't get caught.
I will fork this off as a new issue.

In support of these changes, assuming some proposal moves forward, can we leverage Jest to validate whatever implementation is selected? https://github.com/agrostar/zzapi-vscode/issues/18 is a good example of something that would have been caught with some test automation and these changes will be difficult to validate if the project keeps moving ahead with manual QA.

Yes, we do have automated tests in zzapi-cli. I am not sure why it didn't get caught.
I will fork this off as a new issue.

The tests aren't extensive, I just wrote something introductory so when we planned on a testing method we could add it with ease.
All it does is assert that the expected number of tests are failing in tests-bundle.zzb, and then assert that the expected tests are failing among this number. The above case didn't change which tests were succeeding / failing so it didn't catch that.
I'll take some time out to write tests with better coverage for each of the cli, extension and node module soon.

I have test cases in my repo where the RHS is an array, a single return value from JSONPath query. Just like the available: { $eq: [7,21] } case. Now, if we implement this change, it will break my tests. And others' tests too, if they have used it like this. We will have to rewrite them like { $eq: [[7,21]] } which is quite unintuitive to me.

Tests like this one (actual result is [ [7,22], [18,22] ]) will break no matter which implementation is chosen.

I expect the multiple-value comparison to be a rare use case. I would rather make rarer use cases harder to specify and common use cases simpler.

I generally agree with this take & your proposal satisfies my needs.


Closing edit role drawer remove it from roles list

Begin editing roles, click a role to edit it. With or without making changes, click outside the drawer to close it. The role disappears from the list.

O blah I though I fixed this already hmmm


docs: Add blurb for trouble with converting to quotes

Description

Add blurb for trouble with converting to quotes

Checklist

[ ] My code follows the existing style, code structure, and naming taxonomy
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have performed a self-review of my own code and included any verifying manual calculations
[ ] I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage.  New and existing unit tests pass locally and in the build (below) with my changes
[ ] My changes generate no new warnings and running code analysis does not produce any issues
[ ] I have added or run the performance tests that depict optimal execution times
[ ] I have made corresponding changes to the documentation

I've just add short blurb as we discussed and this is for general cases, not only for locale issue.

I'm done tweaking, go ahead and merge if you're ready.

@DaveSkender  do we have code coverage badge from Codacy now? I can't find with my permission.

@DaveSkender do we have code coverage badge from Codacy now? I can't find with my permission.

I've removed them from the permanent README.md aspects that get published with packages given how much trouble they've been.  You probably can't see this settings page with the badge info.

given how much trouble they've been.

You mean showing this badge has had trouble frequently?

You mean showing this badge has had trouble frequently?

It's just been hard to get them to work with Codacy
Legacy package manager pages that are permanent have old Azure badges that are now broken when I turn off those old builds; pages like on nuget.org and pypi.org

@DaveSkender I added in the same page.
Could you set ignoring some files in Codacy?

@DaveSkender I added in the same page. Could you set ignoring some files like docs or tests in Codacy?

Updated:


IPT3 functional testing

IPT installation and setup

[ ] Latest version on Tomcat

Data Package administration

[ ] Data Package schemas are installed and displayed (Expected 4 packages: Camtrap DP, ColDP, Material DP, Interaction DP)
[ ] Data Package view is displayed
[ ] Source file for the Data Package can be viewed in options
[ ] All navigations, links and buttons work as expected

Data Package management
Camtrap DP
Creation

[ ] Empty Camtrap DP resource creation
[ ] Camtrap DP resource from an archive
[ ] Camtrap DP resource from an IPT folder
[ ] Camtrap DP resource from a metadata file (datapackage.json)

Overview: source data

[ ] Create a new source of any type (File, URL, SQL)
[ ] Create several sources at one by multiple file upload
[ ] Source overwrite (file with the same name)?
[ ] Action icons are functional (Edit, Download, Delete)
[ ] Correct info is displayed (size, columns, rows, modification date etc.)

Source page

[ ] View page is displayed
[ ] Save works
[ ] Options are functional (Analyse, Preview, Delete)
[ ] Download source log works
[ ] Help icons and their functionality work
[ ] All navigations, links and buttons work as expected

Overview: mappings

[ ] Create a new mapping
[ ] Create multiple mappings at time
[ ] Action icons are functional (Edit, Delete)
[ ] Correct info is displayed (fields, modification date etc.)

Mapping page

[ ] Mapping page is displayed
[ ] Save works
[ ] Automapping works
[ ] Filtering works
[ ] Translation works
[ ] Required fields are marked with *
[ ] Help icons and their functionality work
[ ] Unmapped fields are displayed (if present)
[ ] Options are functional (Hide/Show unmapped fields, Delete)
[ ] All navigations, links and buttons work as expected

Overview: metadata

[ ] Metadata edit works, opens Basic metadata page
[ ] Metadata upload works (with or without validation)
[ ] Chip displays valid info: Complete/Incomplete
[ ] Correct info is displayed (modification date, metadata validity)

Metadata pages

[ ] Basic metadata
[ ] Geographic Scope
[ ] Taxonomic Scope
[ ] Temporal Scope
[ ] Keywords
[ ] Project
[ ] Citation
[ ] Other metadata

Overview: visibility

[ ] Visibility change works

Overview: publication

[ ] Change publishing organization works
[ ] Publication modal is displayed when Publish is clicked, valid info is displayed
[ ] Publication works

Overview: registration

[ ] Registration works

This is my overview of the test. I will check each test as I go along and create separate issues (if any) for each. My test is based on the MICA dataset.
IPT installation and setup

[ ] Latest version on Tomcat

Data Package administration

[ ] Data Package schemas are installed and displayed (Expected 4 packages: Camtrap DP, ColDP, Material DP, Interaction DP)
[ ] Data Package view is displayed
[ ] Source file for the Data Package can be viewed in options
[ ] All navigations, links and buttons work as expected

Data Package management
Camtrap DP
Creation

[ ] Empty Camtrap DP resource creation
[ ] Camtrap DP resource from an archive
[ ] Camtrap DP resource from an IPT folder
[ ] Camtrap DP resource from a metadata file (datapackage.json)

Overview: source data

[ ] Create a new source of any type (File, URL, SQL)
[ ] Create several sources at one by multiple file upload
[ ] Source overwrite (file with the same name)?
[ ] Action icons are functional (Edit, Download, Delete)
[ ] Correct info is displayed (size, columns, rows, modification date etc.)

Source page

[ ] View page is displayed
[ ] Save works
[ ] Options are functional (Analyse, Preview, Delete)
[ ] Download source log works
[ ] Help icons and their functionality work
[ ] All navigations, links and buttons work as expected

Overview: mappings

[ ] Create a new mapping
[ ] Create multiple mappings at time
[ ] Action icons are functional (Edit, Delete)
[ ] Correct info is displayed (fields, modification date etc.)

Mapping page

[ ] Mapping page is displayed
[ ] Save works
[ ] Automapping works
[ ] Filtering works
[ ] Translation works
[ ] Required fields are marked with *
[ ] Help icons and their functionality work
[ ] Unmapped fields are displayed (if present)
[ ] Options are functional (Hide/Show unmapped fields, Delete)
[ ] All navigations, links and buttons work as expected

Overview: metadata

[ ] Metadata edit works, opens Basic metadata page
[ ] Metadata upload works (with or without validation)
[ ] Chip displays valid info: Complete/Incomplete
[ ] Correct info is displayed (modification date, metadata validity)

Metadata pages

[ ] Basic metadata
[ ] Geographic Scope
[ ] Taxonomic Scope
[ ] Temporal Scope
[ ] Keywords
[ ] Project
[ ] Citation
[ ] Other metadata

Overview: visibility

[ ] Visibility change works

Overview: publication

[ ] Change publishing organization works
[ ] Publication modal is displayed when Publish is clicked, valid info is displayed
[ ] Publication works

Overview: registration

[ ] Registration works

And that's the thinks I am testing
IPT installation and setup

[ ] Latest version on Tomcat

Data Package administration

[ ] Data Package schemas are installed and displayed (Expected 4 packages: Camtrap DP, ColDP, Material DP, Interaction DP)
[ ] Data Package view is displayed
[ ] Source file for the Data Package can be viewed in options
[ ] All navigations, links and buttons work as expected

Data Package management
Camtrap DP
Creation

[ ] Empty Camtrap DP resource creation
[ ] Camtrap DP resource from an archive
[ ] Camtrap DP resource from an IPT folder
[ ] Camtrap DP resource from a metadata file (datapackage.json)

Overview: source data

[ ] Create a new source of any type (File, URL, SQL)
[ ] Create several sources at one by multiple file upload
[ ] Source overwrite (file with the same name)?
[ ] Action icons are functional (Edit, Download, Delete)
[ ] Correct info is displayed (size, columns, rows, modification date etc.)

Source page

[ ] Source details page is displayed
[ ] Save works
[ ] Options are functional (Analyse, Preview, Delete)
[ ] Download source log works
[ ] Help icons and their functionality work
[ ] All navigations, links and buttons work as expected

Overview: mappings

[ ] Create a new mapping
[ ] Create multiple mappings at time
[ ] Action icons are functional (Edit, Delete)
[ ] Correct info is displayed (fields, modification date etc.)

Mapping page

[ ] Mapping page is displayed
[ ] Save works
[ ] Automapping works
[ ] Filtering works
[ ] Translation works
[ ] Required fields are marked with *
[ ] Help icons and their functionality work
[ ] Unmapped fields are displayed (if present)
[ ] Options are functional (Hide/Show unmapped fields, Delete)
[ ] All navigations, links and buttons work as expected

Overview: metadata

[ ] Metadata edit works, opens Basic metadata page
[ ] Metadata upload works (with or without validation)
[ ] Chip displays valid info: Complete/Incomplete
[ ] Correct info is displayed (modification date, metadata validity)

Metadata pages

[ ] Basic metadata
[ ] Geographic Scope
[ ] Taxonomic Scope
[ ] Temporal Scope
[ ] Keywords
[ ] Project
[ ] Citation
[ ] Other metadata

Overview: visibility

[ ] Visibility change works

Overview: publication

[ ] Change publishing organization works
[ ] Publication modal is displayed when Publish is clicked, valid info is displayed
[ ] Publication works

Overview: registration

[ ] Registration works


improve tests

Can't add you to reviewers @fspreiss for some reason. I will move this PR to the right repo after my PR is merged.


No Docker client strategy found on mac m1

Expected Behaviour
when launching tests from elastic search module file, I expect the tests to pass
Actual Behaviour
When launching tests, I have the following error:
Error: No Docker client strategy found

    at /Users/myUser/repo/export/at-elasticsearch-indexmapper/node_modules/testcontainers/dist/docker/docker-client.js:46:11

After checking, my only socket related to docker in /var/run is com.docker.vmnetd.sock

Testcontainer Logs
  testcontainers DEBUG Found applicable Docker client strategy: UnixSocketStrategy +0ms
  testcontainers DEBUG Testing Docker client strategy URI: unix:///var/run/docker.sock +1ms
  testcontainers WARN  Docker daemon is not reachable: Error: connect ENOENT /var/run/docker.sock +4ms
  testcontainers WARN  Docker client strategy UnixSocketStrategy is not reachable +0ms

Steps to Reproduce

I checked that docker is properly running (I can docker ps, docker run hello-world without problem)

Clone project git@github.com:Tenshock/testcontainers.git
Run yarn
Run yarn test
See error in section Actual Behaviour

Environment Information

Operating System: macOS Monterey Version 12.6 on Apple M1 Pro
Docker Version: Docker version 20.10.20, build 9fdeb9c (Installed from brew install --cask docker)
Node version:  v16.17.0
Testcontainers version: 8.16.0

Hi @Tenshock, by default I'd expect the Docker daemon to create the socket /var/run/docker.sock. I'm also on an M1 mac and that's how it is for me on the same version of Docker. Could you please investigate why that socket does not exist?

I’d expect it as well, I will reset to factory my docker desktop configuration, uninstall all docker related stuff (docker and cask docker) and I will reinstall it to see if I have the same behavior
did you installed docker desktop? And if so, through brew or with the official dmg from docker website?

I uninstalled everything (I uninstalled from the docker desktop application first then from brew cli), the deamon was successfully deleted.
I reinstalled from the website, with the same deamon (com.docker.vmnetd.sock) being created. The problem still persists

It appears like it's a problem with docker, not testcontainers. You can close this thread so, I will finish to debug by my own or in a proper place :)
Thanks for your reactivity

FYI: I had to create the symlink by hand (sudo ln -sf /Users/myUser/.docker/run/docker.sock /var/run/docker.sock), the patch is not that awful but quite annoying
I don't know why it was not created automatically, I'll try to troubleshoot it later

Interesting, the socket was in your home dir instead of available for everyone. Maybe it was an option in the installation to install only for your user?

Maybe, after reading all setups configurations, I did not found any configuration to setup this …
Apparently, it is an issue, following this issue: https://github.com/docker/for-mac/issues/6529
I set the DOCKER_HOST environment variable to unix:///Users/myUser/.docker/run/docker.sock, it resolves the problem with the current implementation of testcontainers and is cleaner.
But it's an additional step, I will follow this issue

Just as a note, the same problem exists with Docker Desktop on Linux, and the /var/run/docker.sock symlink was not restored in v4.13.1 as it was in Mac. The DOCKER_HOST env var workaround does work, however - e.g.:
DOCKER_HOST=unix:///home/youruser/.docker/run/docker.sock

I'm facing the exact same issue but I'm using Rancher Desktop, Im not sure if that would make any difference. I symlinked the socket file from home directory but the error still comes up.

How odd. Have you tried setting the DOCKER_HOST env var? In your case:
DOCKER_HOST=unix:///Users/konstantinosbariotis/.docker/run/docker.sock node index.js

yes @itsravenous I did and its just the same. :/

I haven't used Rancher desktop, but as mentioned above, Docker desktop restored the previous location of the docker socket in 14.13.1. If you're not on the latest version of Rancher desktop, perhaps upgrading will help? Otherwise I'd suggest asking in the Rancher Desktop community for help.

ok @itsravenous thank you I think I found the issue, the symlink was actually not right. The right path of RD's socket is in unix:///Users/${USER}/.rd/docker.sock and that's where the /var/run/docker.sock  should be pointing to. :) thank you for your time thought :)

ok @itsravenous thank you I think I found the issue, the symlink was actually not right. The right path of RD's socket is in /Users/${USER}/.rd/docker.sock and that's where the /var/run/docker.sock should be pointing to. :) thank you for your time thought :)
Im not sure what's the .docker folder in the home directory, maybe its been left from a previous Docker Desktop installation.

That sounds about right! Glad you got it sorted :grin:

Looks like they realized the missing socket broke "all the things", so the socket systemlink has been added back in on docker desktop for Mac, but sadly not for linux.

Docker tooling like this will need a solution for handling the case where only the userspace socket exists and not /var/run/docker.sock, otherwise there will be a lot of issues like this one where mac users are ok but linux users are still broken. Does anyone know if there is a standard way to get the socket location, maybe from the active docker context?


Bot Leaves Before Song Finishes

Hi There!
I recently finished setting this bot up in my lab. It is working correctly and playing songs from YouTube and Spotify. However the bot will disconnect about 15 seconds prematurely. Is this because I set the buffer to  15 seconds aiode.preferences.native_audio_buffer=15000 ? Or is that just coincidence? Also, is there any way to keep the bot in the chat even when there is are no songs in the queue?
Thank You!

That is not a coincidence ;) It most likely also means that pressing pause is delayed by 15 seconds, since it will continue to pull from the buffer. I believe lavaplayer fires the AudioEvent for reaching the end of the track when the last packet is pulled with no way of knowing whether it is buffered or not. A 15 seconds buffer is not exactly pratical, the point of the buffer is to avoid stutters caused by garbage collection pauses, if those reach 15 seconds you have some pretty big problems ;) The default of 400 ms is already really generous for most users. When only streaming to a handful of guilds you can actually easily get away without a native buffer at all. I'd recommend just leaving the default.
The bot always leaves after playing the last track in the queue.

Sorry for the delayed response I missed the notification on your message. Awesome I will revert the bot back down to 400ms. Thank you!


[FEATURE] - perf improvements and code splitting

Various perf improvents on inlining json, no longer escaping the json.
Split vendor bundles and using webpacks hash and manifest plugin.
Fixed hanging tests.

Add: Dependencies for code splitting manifest file
Add: Deployment for vendor file
Add: Webpack config for vendor commons chunk
Add: Script separation for vendor and bundle in layout
Add: Vendor/Bundle static urls in config
Add: Manifest.json on redux state
Add: Perf enhanced inline bootstrapped redux state
Bugfix: Global conditions from server enzyme tests cause hanging connection
Remove: Static url from layout

Coverage increased (+0.5%) to 44.365% when pulling af99e7e90a3014461052594f77bb268a2f761848 on feature/code-splitting-perf into 94e7ad58c85fb4757fc1682b1c8854de111a4af6 on master.


Modified node-postgres docker-compose for GH codespaces

The node-postgres docker-compose works as expected if using the Remote Development - Containers extension in VS Code. However, when using this docker-compose in GitHub codespaces the networking is not created correctly and the node container cannot access the postgres container. This change allows the 5432 port to be shared with the host so it works as intended in GitHub codespaces. It will not impact users working locally.

@MichaelJolley This is actually due to a bug in Codespaces that the I know the team is working on.

Closing this for now since I'm hoping this is resolved soon! I also pinned the workaround in #637 to the top of the issues.


Modify kc-server boot initialization iam data

What type of PR is this?
/kind bug

What this PR does / why we need it:
Modify the kc-server startup initialization iam data, the current initialization logic is not compatible with etcd failures.
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:
@x893675 @lixd

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@x893675 @lixd

Codecov Report

Merging #649 (47ab57c) into release-1.3 (b2b165b) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           release-1.3     #649   +/-   ##
============================================
  Coverage        12.19%   12.19%
============================================
  Files              112      112
  Lines            16951    16951
============================================
  Hits              2068     2068
  Misses           14634    14634
  Partials           249      249

/cherry-pick master

/lgtm
/approve


improve testability using interface of containerd.Client and its mock

What is the problem you're trying to solve
Currently a lot of implementation in pkg/cri depends on containerd.Client so it is very hard to write unittests for it.
I suggest we should use interface instead of struct (or its pointer) in each structs in pkg/cri so that we can use mock for containerd.Client.
This is an example of the struct using containerd.Client.
https://github.com/containerd/containerd/blob/1498a6dde95a2424fb5590e66d8d75b7b51b1449/pkg/cri/store/image/image.go#L62-L71
Describe the solution you'd like
I'd like to make an interface of containerd.Client and use gomock to generate its mock.
Additional context
No response

Personally I'm inclined to use containerd.Client instead of making a mocked client. What are the specific behaviors you'd like to test by mocking containerd.Client?

https://github.com/containerd/containerd/issues/8483
I'm working on this issue and I found the difficulty.
In updateImages function, it directly uses client and imagestore also uses client as well.

I'd suggest focusing on using integration/
https://github.com/containerd/containerd/blob/main/integration/containerd_image_test.go#L48
https://github.com/containerd/containerd/blob/main/integration/image_pull_timeout_test.go#L181
you should be able to load the cri plugin as done above.. then use either criService.PullImage or containerdClient.Pull and check if your image reference/update code is working the same for both.. (off event notice I suppose on the ctr version)

Thank you for the advice!
I'll see them.
But aside from my task, I think we should use interface instead of struct to write unit tests.


⚠ GitLab Server has degraded performance

In 786cbbb, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 7041 ms

Resolved: GitLab Server performance has improved in 4286c76.


[Bug] UNION ALL query return wrong empty set

Describe the bug
-- create table
DROP TABLE IF EXISTS `test_t`;
CREATE TABLE `test_t` (
  `name` VARCHAR(1000) NULL COMMENT "string"
) ENGINE=OLAP
DUPLICATE KEY(`name`)
DISTRIBUTED BY HASH(`name`) BUCKETS 5
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "DEFAULT"
);

-- insert data
INSERT INTO test_t (`name`)
VALUES ('aaaaa'), ('ccccc')
;

-- returns wrong empty set
SELECT `t1`.`name`
FROM (
   SELECT `name`
   FROM `test_t`
GROUP BY `name`
   ) `t1`
UNION ALL
SELECT `t2`.`name`
FROM (
   SELECT `name`,
      -1 as `bool`
   FROM `test_t`
GROUP BY `name`
   ) `t2`
WHERE `t2`.`bool` = 1
;

-- returns correct result ‘aaaaa’ and ‘ccccc’
SELECT `t2`.`name`
FROM (
   SELECT `name`,
      -1 as `bool`
   FROM `test_t`
GROUP BY `name`
   ) `t2`
WHERE `t2`.`bool` = 1
UNION ALL
SELECT `t1`.`name`
FROM (
   SELECT `name`
   FROM `test_t`
GROUP BY `name`
   ) `t1`
;

Additional context
Fixing, may need some help QAQ.

This is most likely because Doris treats UNION clause conditions as conditions for the entire previous query.
Test result on MySQL 5.7 shows that these two queries return the same result.
I haven't found any description of union queries like this in the SQL standard, but I think Doris should keep the same actions as MySQL.

This bug was caused by #4206's fix #4235, scanNodes.clear() here remove all previous scanNodes if the last statement's condition is false.
https://github.com/apache/incubator-doris/blob/a61eea3b2e76d741c98b9faed8cec51c1d469f94/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java#L284-L290

I forget to submit a PR to the Github master branch.
You could change the code to, and submit a PR.
        if (analyzer.hasEmptyResultSet()) {
            List<TupleId> scanTupleIds = root.getAllScanTupleIds();
            PlanNode node = createEmptyNode(stmt, analyzer);
            // Ensure result exprs will be substituted by right outputSmap
            node.setOutputSmap(root.outputSmap);

            // Must and could only remove the scanNode that the tuple id is same with EmptyNode,
            // otherwise we will get NPE in Coordinator::computeScanRangeAssignment
            scanNodes.removeIf(scanNode -> scanTupleIds.contains(scanNode.getTupleIds().get(0)));
            // Currently, getMaterializedTupleIds for AnalyticEvalNode is wrong,
            // So we explicitly add AnalyticEvalNode tuple ids to EmptySetNode
            if (root instanceof AnalyticEvalNode) {
                node.getTupleIds().addAll(root.tupleIds);
            }
            return node;
        }

I forget to submit a PR to the Github master branch.
You could change the code to, and submit a PR.
        if (analyzer.hasEmptyResultSet()) {
            List<TupleId> scanTupleIds = root.getAllScanTupleIds();
            PlanNode node = createEmptyNode(stmt, analyzer);
            // Ensure result exprs will be substituted by right outputSmap
            node.setOutputSmap(root.outputSmap);

            // Must and could only remove the scanNode that the tuple id is same with EmptyNode,
            // otherwise we will get NPE in Coordinator::computeScanRangeAssignment
            scanNodes.removeIf(scanNode -> scanTupleIds.contains(scanNode.getTupleIds().get(0)));
            // Currently, getMaterializedTupleIds for AnalyticEvalNode is wrong,
            // So we explicitly add AnalyticEvalNode tuple ids to EmptySetNode
            if (root instanceof AnalyticEvalNode) {
                node.getTupleIds().addAll(root.tupleIds);
            }
            return node;
        }

I can't find method getAllScanTupleIds in PlanNode root

@ccoffline Sorry. you could add this method to PlanNode:
    protected List<TupleId> getAllScanTupleIds() {
        List<TupleId> tupleIds = Lists.newArrayList();
        List<OlapScanNode> scanNodes = Lists.newArrayList();
        collectAll(Predicates.instanceOf(OlapScanNode.class), scanNodes);
        for(OlapScanNode node: scanNodes) {
            tupleIds.addAll(node.getTupleIds());
        }
        return tupleIds;
    }


The evaluation doesn't work correctly

🐞 bug report
Describe the bug

The evaluation doesn't work correctly
To Reproduce
Press ALT + D
All stats = 0
Expected behavior

Screenshots

https://skr.sh/s7e8KVpRcHt?a
🌍  Your Environment

Version: 1,1,3
PoE:  e.g. Steam 3.14.0/e English

same problem here

Same

Same

Same Problem
At first I thought it might be because I was playing in German, but it doesn't matter whether it is German or English


lookAt(...) without/with custom easing?

Current lookAt(...) uses an easing (ease), is there a way using a different easing (or linear for no easing)?
Edit: By easy swapping out the timingFunction per viewer or animation.

I added an animationTimingFunction parameter in ded506d22da02b3623f74dad52f4d763e9e07272 that allows the a custom timing function to be specified (this only works when the API is used).


fixed typo in code example

Fix or Enhancement?
This is only a fix of the documentation, so the usual pull request checks don't apply.

Opps... Thank you for the fix!


hive member unification and many fixes

About the PR

removed hive member from Xeno / XenoEgg / XenoProjectile
the thing for when a marine is infected should have its own field still i think, it would be weird a marine getting infected suddenly being a full fledged member of the hive (only xeno agent patent pending antag should!)
added proper hive member api to SharedXenoHiveSystem
moved hive creation to server since nothing called it from shared anyway
fixed a bunch of subtle bugs that wouldve appeared with multiple hives

Why / Balance
5 different things with Hive member and C-F tier apis for using them
:bug: :hammer:
Technical details
the hive member api: GetHive / SetHive / SetSameHive / FromSameHive / IsMember
morbillion things changed to use it
very nice to use no adding .Value everywhere it just works (only have to sometimes use (hive, hive.Comp) because Entity trollage but it could be fixed in the future)
added HiveChangedEvent to not have night vision tightly coupled to xenos hive changing
bugs squished:

if you don't have a hive tracker would display like there's no queen, now you don't get a tracker since you don't have a hive, naughty rogue xeno
previously 2 rogue xenos couldnt use abilities on eachother because it did dumb hive == hive check, now it gets IsSameHive for friendly fire prevention. rogue xenos can now use lunge etc on eachother probably
probably more i forgor
using rmc actions to create a new hive didnt set the xeno's hive to it, now it does so you don't have to do that manually
fix unique construction ignoring the other construct's hive i assume that in xeno v xeno each hive can still have their own core and its not just ping racing
some tiny micro optimisations, mostly from using entityqueries
rogue xenos can shoot/lunge/headbutt eachother
rogue xenos trying to use the watch action get nothing instead of an empty list (this is actually parity too i checked the dm)

Media
:trollface:
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
removed Hive field and system's api from XenoComponent and XenoEggComponent, they use HiveMemberComponent and SharedXenoHiveSystem now
SetSameHive in hive system takes src, dest instead of dest, src
Changelog
no cl no fun

greeno events are REAL


Article date

The date on this article is 9/20/2019?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45af718e-2094-01d1-9426-2d7403c59e1c
Version Independent ID: 0d934f65-03ec-eb9d-9154-b66930166d33
Content: Create a canvas app from scratch using Common Data Service - PowerApps
Content Source: powerapps-docs/maker/canvas-apps/data-platform-create-app-scratch.md
Service: powerapps
GitHub Login: @AFTOwen
Microsoft Alias: anneta

Yeah I saw the date of 9/20/2019 too. I was trying to follow the tutorial but I cannot find "in the middle of the screen select to connect to data". Was this from a few years ago and things have changed quite a bit?
Thanks.

@jwrocko The correct article date is 5/21/2019. I will update the article. I will leave this issue open since @thegongben indicates one or more screen images/instructions may need to be updated.


display original sat imagery + detection mask on plot hover

images like data/nzd0121/jpg_files/detection/1999-08-26-22-04-44_L7.jpg

solved with https://github.com/UoA-eResearch/CoastSat/commit/3dac01970962ce784fde80ea8adce16a9d4071dd


If backup folder doesnt exist, fails

default arguments should create a backup directory in the folder dupe_tool is ran in

unable to replicate


Tamagui Expo Inter font error

Current Behavior
On a newly created Expo app through create-expo-app, upon adding a Tamagui component, I get the error:  fontFamily "Inter" is not a system font and has not been loaded through Font.loadAsync..
Expected Behavior
Button/component shows up without the font error.
Tamagui Version
1.64.3

Reproduction
npx create-expo-app@latest
yarn add tamagui and yarn add @tamagui/config
Code in App.js:
import { View } from "react-native";
import { config } from "@tamagui/config";
import { createTamagui, TamaguiProvider, Button } from "tamagui";

const tamaguiConfig = createTamagui(config);

export default function App() {
  return (
    <TamaguiProvider config={tamaguiConfig}>
      <View style={{ flex: 1, alignItems: "center", justifyContent: "center" }}>
        <Button>Test button</Button>
      </View>
    </TamaguiProvider>
  );
}

System Info
System:
    OS: macOS 13.4
    CPU: (12) arm64 Apple M2 Max
    Memory: 16.26 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.6.7 - /usr/local/bin/npm
  Browsers:
    Chrome: 117.0.5938.62
    Safari: 16.5
  npmPackages:
    @babel/core: ^7.20.0 => 7.22.17
    @tamagui/config: ^1.64.3 => 1.64.3
    expo: ~49.0.10 => 49.0.10
    expo-status-bar: ~1.6.0 => 1.6.0
    react: 18.2.0 => 18.2.0
    react-native: 0.72.4 => 0.72.4
    tamagui: ^1.64.3 => 1.64.3

(Accidentally closed and re-opened the issue, sorry about that)

Duplicate of #1448 ?

Ah you're right - will check that out!


Zero copy operations

Look into improving code to reduce GPU memory usage

super seeded by series of issues for each op


[GHSA-8cvr-4rrf-f244] Infinite open connection causes OctoRPKI to hang forever

Updates

Affected products

Comments
Make 'affected products' versions SemVer compliant.

Hi there @dhaynespls! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


Add Telugu translations for command descriptions

This issue is to add Telugu translations for the existing commands found in https://github.com/devadvance/terminalcheatsheet/tree/master/_data/commands
Use te (the locale code for Telugu) as the key for the strings.
Please comment on this issue before starting work so people are informed that you are working on it.

I'm Interested to do this and I'm a native speaker

Its completed. Can you pls pr


timestamp in msg files

Since commit 76387b1693f234602e6c354115fbcac25b33baab all .msg files stop having a timestamp value. But code from nodes still uses it so when i try to compile using catkin_make i get these errors:
catkin_ws/src/px4/src/platforms/ros/nodes/attitude_estimator/attitude_estimator.cpp: In member function ‘void AttitudeEstimator::ModelStatesCallback(const ModelStatesConstPtr&)’:
catkin_ws/src/px4/src/platforms/ros/nodes/attitude_estimator/attitude_estimator.cpp:98:12: error: ‘px4::vehicle_attitude {aka struct px4::vehicle_attitude_<std::allocator<void> >}’ has no member named ‘timestamp’
  msg_v_att.timestamp = px4::get_time_micros();
            ^
catkin_ws/src/px4/src/platforms/ros/nodes/attitude_estimator/attitude_estimator.cpp: In member function ‘void AttitudeEstimator::ImuCallback(const ImuConstPtr&)’:
catkin_ws/src/px4/src/platforms/ros/nodes/attitude_estimator/attitude_estimator.cpp:141:12: error: ‘px4::vehicle_attitude {aka struct px4::vehicle_attitude_<std::allocator<void> >}’ has no member named ‘timestamp’
  msg_v_att.timestamp = px4::get_time_micros();
            ^
Linking CXX executable catkin_ws/devel/lib/px4/demo_offboard_position_setpoints
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp: In member function ‘void Commander::ManualControlInputCallback(const manual_control_setpointConstPtr&)’:
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:72:28: error: ‘px4::vehicle_control_mode {aka struct px4::vehicle_control_mode_<std::allocator<void> >}’ has no member named ‘timestamp’
  _msg_vehicle_control_mode.timestamp = px4::get_time_micros();
                            ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:76:22: error: ‘px4::actuator_armed {aka struct px4::actuator_armed_<std::allocator<void> >}’ has no member named ‘timestamp’
  _msg_actuator_armed.timestamp = px4::get_time_micros();
                      ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:96:22: error: ‘px4::vehicle_status {aka struct px4::vehicle_status_<std::allocator<void> >}’ has no member named ‘timestamp’
  _msg_vehicle_status.timestamp = px4::get_time_micros();
                      ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:106:53: error: ‘px4::parameter_update {aka struct px4::parameter_update_<std::allocator<void> >}’ has no member named ‘timestamp’
  if (px4::get_time_micros() - _msg_parameter_update.timestamp > 1e6) {
                                                     ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:107:25: error: ‘px4::parameter_update {aka struct px4::parameter_update_<std::allocator<void> >}’ has no member named ‘timestamp’
   _msg_parameter_update.timestamp = px4::get_time_micros();
                         ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp: In member function ‘void Commander::OffboardControlModeCallback(const offboard_control_modeConstPtr&)’:
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:214:23: error: ‘px4::vehicle_status {aka struct px4::vehicle_status_<std::allocator<void> >}’ has no member named ‘timestamp’
   _msg_vehicle_status.timestamp = px4::get_time_micros();
                       ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:221:23: error: ‘px4::actuator_armed {aka struct px4::actuator_armed_<std::allocator<void> >}’ has no member named ‘timestamp’
   _msg_actuator_armed.timestamp = px4::get_time_micros();
                       ^
catkin_ws/src/px4/src/platforms/ros/nodes/commander/commander.cpp:223:29: error: ‘px4::vehicle_control_mode {aka struct px4::vehicle_control_mode_<std::allocator<void> >}’ has no member named ‘timestamp’
   _msg_vehicle_control_mode.timestamp = px4::get_time_micros();

The timestamp is automatically added since that change: http://dev.px4.io/advanced-uorb.html#adding-a-new-topic
@bkueng That might be missing from our ROS port. @marianobianchi Are you actually using the ROS port after all? Its incomplete and undocumented.

Thanks for your answer. I am working on a project that have a little code for using multiple UAVs and I'm trying to run that code with the latest firmware (latest SITL). I thought ROS integration was still working as always but now that you say this I might have started off on the wrong foot. I don't know what do you mean with "ROS port" but I think you mean that is not recommended to include px4 firmware as a source of a catkin workspace, is it?
I will try to follow these instructions and see how it works.

Yes I think the catkin workspace does not work, but the ROS wrapper does.


Confuse doc

Hello, the docs need more information about how we can start to use your package. I tried put the "T9n.setLanguage("es")" in a JS client also in server and dont works.

I am sorry to hear that. Can you tell what you did, what you expected and what did not work? Did you get an error?

I dont have a error. The package looks great but I dont know how start. Please, you can describe in the docs, step by step how to works?

Sorry, I do not really understand what information you need.


Fix #373: add basic tests to verify "$date" wrt Projection

What this PR does:
Adds simple testing to ensure Projection works with Date valued fields
Which issue(s) this PR fixes:
Fixes #373
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

There is a test case that excludes sub document which does the same, but can you also add a date field exclusion as separate test case.

Will do.


x/tools/gopls: don't apply completion budget to shallow completions

What version of Go are you using (go version)?

$ go version go1.15.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes (0.5.0). Also tested in (0.4.4).
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOENV="/Users/user/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.15.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.15.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/user/projects/tools/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/xg/l6_pfk3x0_n5ltb8h3wd1k500000gn/T/go-build694027970=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

For large packages the completion was timing out. For example, typing fmt. produced no results. Using a local struct variable struct1. produced no results.
[Trace - 11:19:55.356 AM] Sending request 'textDocument/completion - (14)'.
Params: {"textDocument":{"uri":"file:///path/to/file.go"},"position":{"line":602,"character":5},"context":{"triggerKind":2,"triggerCharacter":"."}}
[Trace - 11:19:55.910 AM] Received response 'textDocument/completion - (14)' in 554ms.
Result: {"isIncomplete":false,"items":[]}

@heschik found the workaround. Adding:
"gopls": {
  "completionBudget": "0.5s"
}

to my vscode config gave the completion code more time to read the very large package. Now completion items are coming up.
There may be a bug here as:

@heschik: I'm not sure we want shallow completions to be subject to the budget, like Muir said

(slack convo)
What did you expect to see?
I expected to see the fmt public package methods and the methods attached to struct1.
What did you see instead?
No completions came up.

@stamblerre, is the behavior change you made in golang.org/cl/227303 still the one we want? If not this would be an easy fix for @dandua98.

This might actually be fixed (in 0.5.1) now that deep completion is bfs and is triggered at the end of completions. I think this might be one of those scenarios with very large packages where we end up going too deep and not finding anything. Would need to be able to reproduce this and verify though.

It may have been improved, but I think it's still an open question whether we want to ever give up on searching the first level.

No, I think in that CL was a mistake on my part. If deep completions is more "isolated" now, it would be nice to only apply that timeout to deep completions, but to start the timer when the completion request starts. (I think I may have thought that that's what I was doing in that CL, but clearly I did it wrong...)

Some feedback on this change. In our largest package I still need to keep "completionBudget": "0.5s" in the config in order to get results back.

Tested this in golang.org/x/tools/gopls v0.5.2 and I am now getting completions in our largest package without using "completionBudget": "0.5s".

Glad to hear it! I'll close this issue then.


Search for errors instead of expecting strict match

Print out actual errors so we can see why this test fails in the future, for https://github.com/aspnet/Home/issues/3506
@Eilon @ajcvickers

Updated error validation to scan for matches to accommodate arbitrary order of data annotation errors


NOISSUE - enabling coap udp port in docker-compose

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Which issue(s) does this PR fix/relate to?
Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   87.11%   87.11%
=======================================
  Files          62       62
  Lines        3391     3391
=======================================
  Hits         2954     2954
  Misses        298      298
  Partials      139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351d6e7...a23fbed. Read the comment docs.

@caztial please sign-off your commits, DCO is failing.

Duplicate of https://github.com/mainflux/mainflux/pull/590


abbreviation for rpb

Thanks for your awesome work.
Can you provide some clues for what is rpb and apply_pb, which does not appear in standard attention?
Thanks

Thank you for your interest.
RPB is relative positional biases, they're learnable biases that are added to attention weights.
They're widely used especially in restricted attention patterns, such as Swin's WSA, and we adopted that into NA.
You can refer to these works for more information.
https://arxiv.org/abs/1711.11575
https://arxiv.org/abs/1904.11491
https://arxiv.org/abs/1910.10683
https://arxiv.org/abs/2002.12804

@alihassanijr  thanks for your timely response.
Thanks for your awesome work!


Line breaks affect parsing

Have the following two structurally equivalent XML snippets that behave differently:
broken.xml
<T1>
  <T2>
    <attach>
        <_>24</_>
        <_>30</_>
    </attach>
  </T2>
</T1>

fixed.xml
<T1>
  <T2>
    <attach><_>24</_><_>30</_></attach>
  </T2>
</T1>

The only difference in fixed.xml is that nested <_> appear on the same line as the parent - and it successfully parses. When the nested <_> elements appear on newlines they are not parsed at all. Setting attributePrefix to something other than _ does "fix" things but in any case I don't think line breaks should have this impact(?).
This is with Spark 3 (DBR 8.2) with the latest maven hosted spark-xml com.databricks:spark-xml_2.12:0.12.0
Here is a Databricks based scala notebook for easy repro
// Databricks notebook source
// MAGIC %sh
// MAGIC echo '<T1>
// MAGIC   <T2>
// MAGIC     <attach>
// MAGIC       <_>24</_>
// MAGIC       <_>30</_>
// MAGIC     </attach>
// MAGIC   </T2>
// MAGIC </T1>' > /dbfs/broken.xml

// COMMAND ----------

val df = spark.read.format("xml").option("rowTag","T2").load("dbfs:/broken.xml")
display(df)

// COMMAND ----------

// MAGIC %sh
// MAGIC echo '<T1>
// MAGIC   <T2>
// MAGIC     <attach><_>24</_><_>30</_></attach>
// MAGIC   </T2>
// MAGIC </T1>' > /dbfs/fixed.xml

// COMMAND ----------

val df = spark.read.format("xml").option("rowTag","T2").load("dbfs:/fixed.xml")
display(df)

Yeah it's something to do with _ being used as the attribute prefix - I would definitely set that otherwise if you don't want it to be interpreted as an attribute. Line breaks shouldn't matter.
... but after debugging this for about 20 minutes, I can see the problem, just not a super easy fix. It handles the case where a struct has character data vs no character data differently, because it's looking for a _VALUE tag. That is at least the immediate reason the code paths are not the same. And then in that case, it believes every schema element is an attribute as they start with _.
I think it's... really hard to fix without thinking about it for a long time - just a complex set of cases being handled here and old creaky code in this section.
One option is to always interpret a field that is only the attributePrefix as a field, not attribute. I'm not sure that quite fixes this case but maybe. Or disallow this situation earlier on entirely. Or just indeed set attributePrefix differently or avoid these field names.


Add new devices

Pull Request Test Coverage Report for Build 1306

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1299:
0.0%

Covered Lines:
994

Relevant Lines:
994

💛  - Coveralls


[problem]Different images under same URL, also load the cache image.

Here is the problem:
I use the url: http://dev2.hkday.com.hk/image/example.JPG
to load image A. and then I change the image to image B with same image name same Url.
I have checked the Last Modified date will update(Chrome will load the changed Image B).
So my question is UIL support this scene, if support, how to deal with this problem.

I am also facing same issue

I have same problem, is there any solution ?


Scala 2.13 Support

This is pretty cool! I was able to copy DiscoveryPlugin into another project and generate the model for the Google Drive API (using its discovery JSON document). Unfortunately, that project is stuck on Scala 2.13. (Generating compilable code took a little tweaking but it was pretty straightforward.)
I'm curious if you have any interest in supporting Scala 2 in this project, or if you're aware of any workarounds for using the core artifact from 2.13. I tried using
("com.armanbilge" %% "gcp4s" % "0.1-9eab0c1").cross(CrossVersion.for2_13Use3)

but ran into errors with transitive dependencies:
[error] Modules were resolved with conflicting cross-version suffixes in ProjectRef(…), "drive-client"):
[error]    org.scodec:scodec-bits _2.13, _3
[error]    io.circe:circe-scodec _2.13, _3
[error]    io.circe:circe-core _2.13, _3
[error]    org.typelevel:simulacrum-scalafix-annotations _3, _2.13
[error]    org.typelevel:cats-kernel _3, _2.13
[error]    org.typelevel:cats-core _3, _2.13
[error]    io.circe:circe-numbers _2.13, _3
[error] stack trace is suppressed; run last drive-client / update for the full output
[error] stack trace is suppressed; run last drive-client / ssExtractDependencies for the full output
[error] (drive-client / update) Conflicting cross-version suffixes in: org.scodec:scodec-bits, io.circe:circe-scodec, io.circe:circe-core, org.typelevel:simulacrum-scalafix-annotations, org.typelevel:cats-kernel, org.typelevel:cats-core, io.circe:circe-numbers
[error] (drive-client / ssExtractDependencies) Conflicting cross-version suffixes in: org.scodec:scodec-bits, io.circe:circe-scodec, io.circe:circe-core, org.typelevel:simulacrum-scalafix-annotations, org.typelevel:cats-kernel, org.typelevel:cats-core, io.circe:circe-numbers
[error] Total time: 2 s, completed Jun 8, 2022, 6:01:51 PM

I poked around a little more beyond that but it feels like it's spiraling a little bit and I'm not really sure where to focus (or if this is even likely to work at all).

Thanks, I'm glad it's (almost) useful to you! The module that's most tied to Scala 3 is BigQuery because it uses shapeless 3 to derive encoders/decoders.
Everything else should cross-compile easily I think, if all the syntax is rewritten 🙃
If you're willing to try one more experiment, in topic/2.13 I tried building a Scala 3 core against all 2.13 dependencies. This will avoid the conflicting suffix problem. I think you will need to add the -Ytasty-reader flag as well (or something like that).
Sadly I had to disable one of the tests to get it to publish, I'll try and take a deeper look at it later. Not sure why it's broken.

Thanks! It looks like it imports into sbt ok—at least, the conflicting cross-version suffixes stuff doesn't come up anymore. I probably won't have a chance to dig deeper until next week though.

Btw, if you have a chance to put up a branch with the changes you made to the DiscoveryPlugin to get it to work on Scala 2.13, that would be really helpful to figuring out how viable a 2.13 cross of this project is :)

Oh yeah, sure thing!

Good news! The failing test was just a very silly typo. https://github.com/armanbilge/gcp4s/commit/e4b7179084eeb5810341ec78edec882cf807ad08


v2 timeslider in other languages: Failover to English if language not found

We added some internationalization to the timeslider, which is great. But I just noticed that if we don't have a language, the timeslider doesn't load at all:

That's testing French. What would be better is that we just load the English version if we can't find a language
Maybe here, instead of "load or die" we do "load or fail to EN-US"?
https://github.com/OpenHistoricalMap/leaflet-ohm-timeslider-v2/blob/main/leaflet-ohm-timeslider.js#L36-L41

Done. It will still give an error message in the console, but will now fail over to en-US.


Support whitespaces in the middle of "ELSE IF" condition key word

fix: #2235
Support this format:
# template
- if: {expression1}
  - say hi
- else IF: {expression2} // Originally did not support spaces in the middle
  - say hello
- ELSE:
  - bye

Pull Request Test Coverage Report for Build 82922

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 4 files lost coverage.
Overall coverage remained the same at 78.597%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Dialogs/ObjectPath.cs
1
76.24%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/OAuthPrompt.cs
1
57.23%

/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorageOptions.cs
2
50.0%

/libraries/Microsoft.Bot.Builder/MemoryTranscriptStore.cs
2
86.09%

Totals

Change from base Build 82882:
0.0%

Covered Lines:
5402

Relevant Lines:
6873

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


Usage of this plugin without a standalone configuration file

What version of prettier-plugin-tailwindcss are you using?
v0.5.3
What version of Tailwind CSS are you using?
v3.3.3
What version of Node.js are you using?
v20.5.1
What package manager are you using?
npm
What operating system are you using?
Linux
Describe your issue
Greetings!
I've been using this plugin for a while along with Prettier Formatter for Visual Studio Code for a while now and I didn't have any issues. Basically I just npm installed it in any project I like and it just worked great, no issues whatsoever. Well, I just recently installed it on another project but it didn't work anymore, which prompted me to read the documentation.
It appears that you need to have a prettier.config.js (or similar) in project root or elsewhere, something that didn't appear to be necessary before (?) or it just worked without it anyway:
// prettier.config.js
module.exports = {
  plugins: ['prettier-plugin-tailwindcss'],
}

But this is causing two issues for me personally:

I am not big fan of having configuration files in all of my projects, so instead I define my prettier settings in settings.json. These are essentially the global VSCode user settings for the Prettier VSCode formatter extension. This isn't the recommended way of configuring as mentioned in their documentation, but nevertheless I never had any issues with it, nor when I used it along with prettier-plugin-tailwindcss.
My second issue is that if I create prettier.config.js in project root then the tailwind plugin starts working, but that also means all my other settings are gone and I have to copy-paste all my prettier settings from settings.json into the newly created prettier.config.js file.

Is there any way to get around this problem and just keep things as they used to be?
Thank you.

Hey! So, a prettier config either in as a key in package.json, a prettier.config.js, or other similarly supported file is required because of Prettier v3. This is directly attributable to Prettier v3. When Prettier upgraded from v2 to v3 they removed plugin autoloading (iirc because it was incompatible with some package managers). You are now required to explicitly list plugins in a config file. This is the reason a config is necessary. I'm afraid there's nothing we can do about this. Sorry.

Hey! So, a prettier config either in as a key in package.json, a prettier.config.js, or other similarly supported file is required because of Prettier v3. When Prettier upgraded from v2 to v3 they removed plugin autoloading (iirc because it was incompatible with some package managers). You are now required to explicitly list plugins in a config file. This is the reason a config is necessary. I'm afraid there's nothing we can do about this. Sorry. :(

I tried creating a common configuration file living outside of projects which I then load with "prettier.configPath": "/home/user/.config/.prettierrc.json" and I put my settings in there. But the problem is prettier VSCode will silently fail if "plugins": ["prettier-plugin-tailwindcss"] is present in this very same .prettierrc.json file.
This is so frustrating, but I understand there is nothing you can do about this, and I appreciate you reaching out to help. Thanks!


python generate_sal.py

Hello, I created the same environment as you, but I still can't succeed when running the build salmap, he prompts me that I need to enter two parameters. Can you help me?
File "generate_sal.py", line 83, in
main()
File "generate_sal.py", line 41, in main
net = GateNet().cuda()
TypeError: init() missing 2 required positional arguments: 'block1' and 'layers'

try this
net = GateNet(Bottleneck, [3,4,6,3]).cuda()


Samples cause NullPointerException under Ubuntu 14.04

When running any of the samples under Ubuntu 14.04, a number of stack traces are generated indicating that there was a NullPointerException in  com.sun.javafx.Utils.getScreen()
OS: Ubuntu 14.04
JVM: Oracle Java <IP_ADDRESS>
Sample: CnnTechNews.java
Stacktrace:
Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
        at com.sun.javafx.Utils.getScreen(Utils.java:686)
        at com.sun.javafx.webkit.WebPageClientImpl.getScreenBounds(WebPageClientImpl.java:105)
        at com.sun.webkit.WCWidget.fwkGetScreenRect(WCWidget.java:118)
        at com.sun.webkit.Timer.twkFireTimerEvent(Native Method)
        at com.sun.webkit.Timer.fireTimerEvent(Timer.java:83)
        at com.sun.webkit.Timer.notifyTick(Timer.java:64)
        at javafx.scene.web.WebEngine$PulseTimer.lambda$static$45(WebEngine.java:1167)
        at javafx.scene.web.WebEngine$PulseTimer$$Lambda$77/1085514134.pulse(Unknown Source)
        at com.sun.javafx.tk.Toolkit.lambda$runPulse$30(Toolkit.java:314)
        at com.sun.javafx.tk.Toolkit$$Lambda$109/663746818.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:313)
        at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:340)
        at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:525)
        at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:505)
        at com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$400(QuantumToolkit.java:334)
        at com.sun.javafx.tk.quantum.QuantumToolkit$$Lambda$47/662647378.run(Unknown Source)
        at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
        at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
        at com.sun.glass.ui.gtk.GtkApplication.lambda$null$48(GtkApplication.java:139)
        at com.sun.glass.ui.gtk.GtkApplication$$Lambda$43/2109720668.run(Unknown Source)
        at java.lang.Thread.run(Thread.java:745)

This stack trace appears several dozen times, then the last stack trace appears to be the same one from https://github.com/ui4j/ui4j/issues/23
Exception in thread "main" java.lang.IllegalStateException: Not on FX application thread; currentThread = main
        at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:204)
        at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:438)
        at javafx.scene.web.WebEngine.checkThread(WebEngine.java:1182)
        at javafx.scene.web.WebEngine.executeScript(WebEngine.java:946)
        at com.ui4j.webkit.spi.WebKitJavaScriptEngine.executeScript(WebKitJavaScriptEngine.java:22)
        at com.ui4j.webkit.browser.WebKitPage.waitUntilDocReady(WebKitPage.java:225)
        at com.ui4j.webkit.browser.WebKitPage.waitUntilDocReady(WebKitPage.java:220)
        at com.ui4j.sample.CnnTechNews.main(CnnTechNews.java:29)

This appears to be due to a bug in JavaFX. The bug occurs when a WebView is not associated with a scene. Based on my understanding of the WebKitPage code, this association does not happen until page.show() is called. Therefore there is a race condition. If the time interval between calling browser.navigate() and page.show() exceeds the time it takes for the JavaFx thread to pulse, then this NPE will be thrown.

Did you open a bug report on this? I commented on this one: https://javafx-jira.kenai.com/browse/RT-39562

No, i didnt open bug report to javafx-jira. Thanks for the comment, i am watching the issue.

Opened https://javafx-jira.kenai.com/browse/RT-40639 but it was resolved since it utilized non-public interfaces in the simplified repro code. It does link to two other issues which are both marked Fixed but look very similar in nature to this stack trace.

WebView is associated with the Stage & Scene after the page load if and only if Page.show() is called. I changed the implementation and Stage & Scene created always initialized before the page load. The new implementation seems work properly with CnnTechNews.java sample for Windows 8.1. Could you please test the current branch for your test case?
Thanks


CMSIS-NN wrapper update for interface changes

Background: CMSIS-NN int8  APIs are changed
where the pass by value function arguments
are replaced by pass by reference struct
arguments.
The following changes are done in TFL micro

Update int8 cmsis-nn's depthwise conv,
fully connected and average pooling
wrapper files to use the new  interface.

For the above mentioned operators,
updates from the reference implementation
(e.g, CalculateOpData() in Prepare() instead
of Eval()) are ported as well.

sorry about the delete-restore cycle there! Re-based and adapted to new change in cmsis.inc where new build files have to be explicitly added.

@njeffrie Hi Nat! Hope all is well. Could you have a look at this PR? thanks in advance :-)

Rebased to resolve merge conflicts.

@njeffrie Hi Nat! Could you have a look at the changes ?

Thanks for the reviews Nat @njeffrie !


Update Rule(Bedrock/CodeWhisperer)

What is this?

Updating auto-created-regular-rules.yml
This can check Bedrock and CodeWhisperer typo.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


pprof: unstable-2021-09-30 -> unstable-2022-05-09

Fixed build failure against binutils-2.28.
ZHF: https://github.com/NixOS/nixpkgs/issues/172160
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 172251 run on x86_64-linux 1

1 package built:

pprof


dupe bug with conduits

Issue Description:
EnderIO-1.10.2-3.1.156.jar
coduits dupe bug
What happens:
if your replaceing the enderio Enhanced energy conduits with Ender energy conduit from teir 2 to teir 3
right clicking with the green to the orange conduit, it replaces the conduit and gives you back the enhanced but doesnt take the energy
What you expected to happen:
when replacing it should take out the one for the one you replaced
Steps to reproduce:

place  any ammount of enhanced conduits down
right click with energy conduits

...

Affected Versions (Do not use "latest"):

EnderIO: EnderIO-1.10.2-3.1.156.jar
EnderCore: EnderCore-1.10.2-<IP_ADDRESS>-beta.jar
Minecraft: 1.10.2
Forge: Forge Mod Loader version <IP_ADDRESS>5

Your most recent log file where the issue was present:
no errors in console for this.

You are using Sponge, aren't you?

Yes

Is it due to sponge if so I will post there

see #3995


global.nativeTraceBeginSection is not a function

Once i run the project(react-native run-ios),i edit my js file,try to Reload JS ,but get error global.nativeTraceBeginSection is not a function,what is the wrong?

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

I am seeing this problem, too. This happens after the first reload in the simulator. Workaround is killing the app and relaunching it from XCode. Pretty annoying.

I fix it. just launching it from xcode,not from
terminal.Thanks!

What is the fix for this? Getting this error when I updated to react v16.0.0-alpha.12 from react v16.0.0-alpha.6 and react-native: 0.44 to react-native: 0.45.1

为什么还不好使

Stop SysTrace works


Use NODE_ENV to determine if webpack should use production build instead of mode

This fixes an issue relating to this bug #13.
If you are trying to build your app for "production" with modes that are not named "production", this web server fails to start because our build was not properly configured for production.
This fixes this issue by using NODE_ENV to determine if you are building for production so we can have multiple modes for staging/production/development that all do a production build (https://cli.vuejs.org/guide/mode-and-env.html#example-staging-mode)

Any update on this one? We're trying to build for several different environments using CLI modes.


azuredeploy.bicep issue

I'm having a issue with the azure deploy.bicep, deployment have done as instructed and exactly as the tutorial but have consistently received the same error.  Thanks for any help
Here is out put from running the azure deploy.bicep
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(6,16) : Warning no-loc-expr-outside-params: Use a parameter here instead of 'resourceGroup().location'. 'resourceGroup().location' and 'deployment().location' should only be used as a default value for parameters. [https://aka.ms/bicep/linter/no-loc-expr-outside-params]
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(16,5) : Warning no-unused-vars: Variable "eventGridName" is declared but never used. [https://aka.ms/bicep/linter/no-unused-vars]
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(75,5) : Warning no-unnecessary-dependson: Remove unnecessary dependsOn entry 'storage'. [https://aka.ms/bicep/linter/no-unnecessary-dependson]
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(154,105) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(158,105) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(176,5) : Warning no-unnecessary-dependson: Remove unnecessary dependsOn entry 'adt'. [https://aka.ms/bicep/linter/no-unnecessary-dependson]
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(178,5) : Warning no-unnecessary-dependson: Remove unnecessary dependsOn entry 'appInsights'. [https://aka.ms/bicep/linter/no-unnecessary-dependson]
C:\Users\blank\Desktop\mslearn-mr-adt-in-unity\ARM-Template\azuredeploy.bicep(192,25) : Warning BCP081: Resource type "Microsoft.Web/sites/extensions@2015-08-01" does not have types available.
 The name property cannot be null or empty. Please see https://aka.ms/arm-template/#resources for usage details.'.", "additionalInfo": [{"type": "TemplateViolation", "info": {"lineNumber": 344, "linePosition": 5, "path": "properties.template.resources[17]"}}]

I figured out few issues with the instruction and the bicep script:

Queries in step 4 are wrong. There is no objectId returned. Instead, the query should be on "id"
$objectid=$(az ad sp list --display-name ${appreg} --query [0].id --output tsv)
$userid=$(az ad signed-in-user show --query id -o tsv)
The instructions do not mention to enter the obtained values in the bicep script before starting deployment in step 6. THe following lines need to be filled with the right values
param projectName string = <e.g., 'adamsblade'>
param userId string = <whatever your user object id is>
param appRegObjectId string = <whatever the appReg object id is>

Thank you so much! This works.

Hey All,
Thanks for opening up this issue, and thanks @ChristianBeier for providing a solution! I am going to go through an update on all these scripts and documentation this week to make sure everything is up to date and functioning as expected. Your solutions are much appreciated!
Best Regards,
Adam Lash


The Test Framework should not require special treatment in pre-commit.sh

There is an MVP of the test framework discussed in #87 , but it relies on having special treatment in pre-commit.sh to pass the travis tests. In particular:

The test framework directory is currently exempt from having to run go test ./...
Instead, a custom script pkg/framework/test/scripts/run-tests.sh is called, which runs the tests using the ginkgo CLI

The tests of the test framework should be changed so as not to require this special treatment. At first glance, this will involve:

Changing the framework to bring up etcd and the apiserver on random unused ports, instead of the default ones
Having sensible defaults for all environment variables that the framework relies on.

This issue began as a conversation with @apelisse in #149

@hoegaarden and I would like to work on this please.
cc @seans3 @mengqiy I would like to take this

Since you are part of the org, I think you can just do /assign to get it assigned to you.
/assign @totherme @hoegaarden


Fix Cell Objects to always have html-encoded data for "h" key

Some cases left characters like & and < unencoded in the "h" key, making it unreliable for direct embedding in html.

What should happen with other entities?  Here's a fun test case we threw together for testing entities in plaintext formats:
CODES.xlsx
Excel's XML uses a special form _xHHHH_ for encoding other entities, as demonstrated in B2 in Sheet1 from the attached workbook:
      <c r="B2" t="str">
        <f>CHAR(A2)</f>
        <v>_x0001_</v>
      </c>

Squashed the two commits and added a few tests in https://github.com/SheetJS/js-xlsx/commit/616d2e534fc8736040fbb4fbdeb5ff97a515aad4
The open question is whether more HTML entities should be supported.  For example, take the unicode BLACK HEART SUIT ♥  There are two acceptable HTML encodings:

♥ ♥
♥ ♥

@SheetJSDev Thanks for adding tests!
If we are only talking about encoding html, here's my opinion:
I don't think it makes sense to encode more entities than is strictly necessary. Other tools outside xlsx can be used if more encoding is needed. I think entities were more popular when people didn't use UTF-8 but some other charset. Special Excel XML entities like xHHHH should be decoded before encoding to HTML.

Thanks!

@xkr47 there are some more corner cases to work out, but that's for another day.  0.9.11 also integrates an HTML writer that properly handles merge cells as rowspan/colspan.
Even though the PR shows up as "closed" rather than "merged", you are marked as the author of commit 616d2e5

Yeah I noticed, :+1:


Parallel BatchQuery executor based on consistent hash

We should also review whether there's an exchange at the upstream or downstream of chain executors. Since the chain executor is designed to follow the distribution of upstream materialized views, we can remove the exchange if everything works well.

It seems the data from upstream and snapshot is well distributed. 🥰


[Enhancement] Make routine load error msg more clear

Why I'm doing:
What I'm doing:
Kafka broker is down
mysql> show routine load\G
*************************** 1. row ***************************
                  Id: 106275
                Name: label0
          CreateTime: 2024-02-21 15:52:17
           PauseTime: 2024-02-21 17:17:54
             EndTime: NULL
              DbName: kafka_test
           TableName: lineorder
               State: PAUSED
      DataSourceType: KAFKA
      CurrentTaskNum: 0
       JobProperties: {"partitions":"*","rowDelimiter":"\t","partial_update":"false","columnToColumnExpr":"*","maxBatchIntervalS":"10","partial_update_mode":"null","whereExpr":"*","timezone":"Asia/Shanghai","format":"csv","columnSeparator":"'|'","log_rejected_record_num":"0","taskTimeoutSecond":"60","json_root":"","maxFilterRatio":"1.0","strict_mode":"false","jsonpaths":"","taskConsumeSecond":"15","desireTaskConcurrentNum":"5","maxErrorNum":"0","strip_outer_array":"false","currentTaskConcurrentNum":"0","maxBatchRows":"200000"}
DataSourceProperties: {"topic":"wyb_test","currentKafkaPartitions":"0","brokerList":"xxx:9093"}
    CustomProperties: {"group.id":"label0_1f9af280-5fef-44d1-85bf-44f41c4c7fcd"}
           Statistic: {"receivedBytes":2281306,"errorRows":0,"committedTaskNum":1,"loadedRows":22683,"loadRowsRate":1000,"abortedTaskNum":0,"totalRows":22683,"unselectedRows":0,"receivedBytesRate":151000,"taskExecuteTimeMs":15040}
            Progress: {"0":"501572079"}
   TimestampProgress: {}
ReasonOfStateChanged: ErrorReason{errCode = 2, msg='Failed to process get kafka partition info in BE TNetworkAddress(hostname:xxx, port:8069), err: [failed to get kafka partition meta, err: Local: Broker transport failure, event: [thrd:xxx:9093/bootstrap]: xxx:9093/bootstrap: Connect to ipv4#xxx:9093 failed: Connection refused (after 0ms in state CONNECT)]'}
        ErrorLogUrls:
         TrackingSQL:
            OtherMsg:
LatestSourcePosition: {}
1 row in set (0.01 sec)

mysql> show routine load task where jobname = "label0"\G
*************************** 1. row ***************************
              TaskId: c508a547-6dcf-499c-9583-055ece8fa42b
               TxnId: -1
           TxnStatus: UNKNOWN
               JobId: 106275
          CreateTime: 2024-02-21 17:23:25
   LastScheduledTime: 2024-02-21 17:23:56
    ExecuteStartTime: NULL
             Timeout: 60
                BeId: -1
DataSourceProperties: Progress:{"0":501803411},LatestOffset:null
             Message: check task ready to execute failed, err: Failed to process get kafka partition info in BE TNetworkAddress(hostname:xxx, port:8069), err: [failed to get kafka partition offset, err: Local: All broker connections are down, event: [thrd:xxx:9093/bootstrap]: xxx:9093/bootstrap: Connect to ipv4#xxx:9093 failed: Connection refused (after 0ms in state CONNECT)]
1 row in set (0.00 sec)

BE is down
mysql> show routine load task where jobname = "label0"\G
*************************** 1. row ***************************
              TaskId: 5e7f2c07-fe36-4907-844b-6a833e4130c3
               TxnId: -1
           TxnStatus: UNKNOWN
               JobId: 106275
          CreateTime: 2024-02-21 17:31:45
   LastScheduledTime: 2024-02-21 17:31:55
    ExecuteStartTime: NULL
             Timeout: 60
                BeId: -1
DataSourceProperties: Progress:{"0":502285433},LatestOffset:null
             Message: check task ready to execute failed, err: Failed to send get kafka partition info request to BE TNetworkAddress(hostname:xxx, port:8069), err: Unable to validate object, host: xxx
1 row in set (0.00 sec)

mysql> show routine load task where jobname = "label0"\G
*************************** 1. row ***************************
              TaskId: 5e7f2c07-fe36-4907-844b-6a833e4130c3
               TxnId: -1
           TxnStatus: UNKNOWN
               JobId: 106275
          CreateTime: 2024-02-21 17:31:45
   LastScheduledTime: 2024-02-21 17:32:15
    ExecuteStartTime: NULL
             Timeout: 60
                BeId: -1
DataSourceProperties: Progress:{"0":502285433},LatestOffset:null
             Message: check task ready to execute failed, err: Failed to send get kafka partition info request. err: No alive backends
1 row in set (0.01 sec)

Unknown host
mysql> show routine load\G
*************************** 1. row ***************************
                  Id: 107096
                Name: label0
          CreateTime: 2024-02-21 17:34:24
           PauseTime: 2024-02-21 17:35:04
             EndTime: NULL
              DbName: kafka_test
           TableName: lineorder
               State: PAUSED
      DataSourceType: KAFKA
      CurrentTaskNum: 0
       JobProperties: {"partitions":"*","rowDelimiter":"\t","partial_update":"false","columnToColumnExpr":"*","maxBatchIntervalS":"10","partial_update_mode":"null","whereExpr":"*","timezone":"Asia/Shanghai","format":"csv","columnSeparator":"'|'","log_rejected_record_num":"0","taskTimeoutSecond":"60","json_root":"","maxFilterRatio":"1.0","strict_mode":"false","jsonpaths":"","taskConsumeSecond":"15","desireTaskConcurrentNum":"5","maxErrorNum":"0","strip_outer_array":"false","currentTaskConcurrentNum":"0","maxBatchRows":"200000"}
DataSourceProperties: {"topic":"wyb_test","currentKafkaPartitions":"0","brokerList":"test_host:9093"}
    CustomProperties: {"group.id":"label0_18adab03-c776-472a-80ba-41ecca292f98"}
           Statistic: {"receivedBytes":0,"errorRows":0,"committedTaskNum":0,"loadedRows":0,"loadRowsRate":0,"abortedTaskNum":0,"totalRows":0,"unselectedRows":0,"receivedBytesRate":0,"taskExecuteTimeMs":1}
            Progress: {"0":"OFFSET_END"}
   TimestampProgress: {}
ReasonOfStateChanged: ErrorReason{errCode = 2, msg='Failed to process get kafka partition info in BE TNetworkAddress(hostname:xxx, port:8069), err: [failed to get kafka partition meta, err: Local: Broker transport failure, event: [thrd:test_host:9093/bootstrap]: test_host:9093/bootstrap: Failed to resolve 'test_host:9093': Name or service not known (after 104ms in state CONNECT)]'}
        ErrorLogUrls:
         TrackingSQL:
            OtherMsg:
LatestSourcePosition: {}
1 row in set (0.00 sec)

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

All the errors occured when "to get kafka partition info"? How about in other scenarios?
In my opinion, the error info is mostly displayed, but the sentence is real long and redudant, it's not so clear to let users catch the real error quickly.

for "kafka broker is down"

Can you directly show the error message "Connection refused" in err:[ ... ] block without "failed to get kafka partition meta"?
Can you directly put the error message from task into job's error message field? (The task's error message is clearer than the job's)
What's the use of "after 0ms in state CONNECT", if it's useless, can you just remove it.

for "BE is down"

What's the error message in the Job?
What's the meaning of "Unable to validate object"? It chould be "Failed to connec to BE: xxx".
The same about "Failed to send get kafka partition info request"?

All the errors occured when "to get kafka partition info"? How about in other scenarios? In my opinion, the error info is mostly displayed, but the sentence is real long and redudant, it's not so clear to let users catch the real error quickly.

for "kafka broker is down"

Can you directly show the error message "Connection refused" in err:[ ... ] block without "failed to get kafka partition meta"?
ok, directly return BE error message

Can you directly put the error message from task into job's error message field? (The task's error message is clearer than the job's)
done

What's the use of "after 0ms in state CONNECT", if it's useless, can you just remove it.
this is from kafka error message

for "BE is down"

What's the error message in the Job?
done

What's the meaning of "Unable to validate object"? It chould be "Failed to connec to BE: xxx".
done

The same about "Failed to send get kafka partition info request"?
better to keep this to let user know where is failed

What will happen if the given kafka broker address is unreachable?

What will happen if the given kafka broker address is unreachable, like <IP_ADDRESS> ?

this is Kafka broker is down case


Remove bottom section/add icon to How to Add Your Project page

Overview
Remove bottom section of How to Add Your Project Page. Add gear icon between words 'click' and 'to' of step 2.
Action Items
Remove section titled 'Bottom Section' from page. Get icon and insert into Step 2.
Resources/Instructions
icon location: https://primer.stle/octicons/gear-16

In progress, estimated completion by July 15/16.

Just received info on a cleaner way to write that code and will implement during the dev meeting tonight.

PR #712 is up and will resolve this issue.


crash- protocol well location

crashes if you input a well location/ number before you have selected the type of plate

complete.


Add AccessConfig to Cluster CRD

This patch introduces a new field to the Cluster CRD Spec, named
AccessConfig. This field allows setting two new parameters in a
cluster:

Before creation, a users will be able to set
bootstrapClusterCreatorAdminPermissions
authenticationMode after and after the cluster creation.

This patch also adds e2e tests to ensure the proper functioning of this
feature.
Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test all

/hold

/unhold

/test all