W2D1 Tutorial 1 Video ordering

W2D1 Tutorial 1 Video 3 introduces the interactive demo which comes before it in the notebook. It would make more sense for the order of these two cells to be switched, with the interactive demo coming after the video.

Since some students found the Week 1 tutorials overwhelming, we decided to make some exercises optional here, including Exercise 2B, is introduced in Video 3 introduces.
I therefore moved the demo up, so that if you were going to skip 2B, you still tried the demo. As I recall, the video just briefly mentions it and suggests playing with it. If you did do Exercise 2B, we were hoping that you'd go back and try the demo again, now that you can predict the outcomes.
In both cases, I thought the text explained the demo pretty well-- Was something specific missing that was only in the video?

No, there was nothing missing from the text that was only in the video. Thanks for explaining why it was reordered -- the ordering makes sense given that 2B is now optional.

I guess we should mark Video 3 as optional too--I was trying to hedge our bets on how much people would get through. (And while I've got your attention, how was the length overall? Okay, or was everything rushed?

I'm zone 3 so I haven't taught it yet, so not sure. If video 3 is not marked as optional, I think it should be moved before the interactive demo. If it's optional, it can stay where it is.
Maybe a zone 1 or zone 2 TA can speak better to pacing. My group is pretty advanced in prior exposure to concepts so we've been getting through most bonus material in general, I'll try to remember to let you know if that's different today.


I cant modify a value in a dataset (logged as superadmin)

user: realmadridweb
dataset: https://realmadrid.cartodb.com/u/realmadridweb/tables/final_four
errors: ["PG::Error: ERROR: Missing "public"._CDB_UserQuotaInBytes()"]
0: "PG::Error: ERROR:  Missing "public"._CDB_UserQuotaInBytes()"

Related to https://github.com/CartoDB/cartodb/issues/3534

fixed for this case, need to look into the related issue


Update postgresql to blobscandb

This is required, as the only way to override the values of the dependency is by referring to it by it's alias name.

Thanks! Can you run precommit and update the chart version too?

Should be good now.


[teamcoco] fix and improve extraction

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fix extraction, KeyError exception. ( closes #17099 )

Actually the url is http://teamcoco.com/_truman/d/104328?v=v1536871782669
For the ?v=v1536871782669, it'll return the same json without that parameter (I was trying the url without it when I replied).  It's probably from http://teamcoco.com/_truman/f/clips-v1536871782669.html where the http://teamcoco.com/_truman/d/104328 is assembled from concatenated constants there.  Not sure where v1536871782669 comes from, perhaps it's the result of some javascript equation


[Tables] Support geo-redundancy for Cosmos

Add support for Geo-redundancy in the Tables SDK.
This is supported by Cosmos as multiple failover regions for both read and write.
Initial proposal suggests exposing two client configuration settings:

read_regions: A list of strings with the regional account URLs, in the order that they will be attempted.
write_regions: Same but for write operations.

This should likely be implemented as a custom retry policy.
For SDKs that expose direct configuration of, or replacement of the existing policy - it will need to be investigated how the proposed changes would affect those customers.
Read regions must not failover in the case of paged requests (after the initial request) - as the continuation token will not be honored between regions.
The failover strategy should also be adaptable to the Storage failover "secondary" region - which is effectively a single read region. So this implementation should be tested in that context as well.
We will need to document best practice in conjunction with manual failover - i.e. if a customer triggers a manual failover from the Azure portal, this effectively means the primary region now becomes a secondary region, and the account URL will point to the previously secondary region.
Initial implementation will be simplistic, with room for evolution. Examples of further development:

Region cooldown period - if a region is considered unreachable, we don't attempt to contact it again for a configurable period.
Automatic region detection - if the service exposes an API we can automatically detect which regions to retry against.
Better automation around the manual-failover scenario above.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Cosmos:0.48398525,Azure.Core:0.08160349,Storage:0.060417693'


It seems to have no effect, and it is still not identifiable

I want to recognize only the glasses, but part of the face is also recognized
https://df5apg8r0m634.cloudfront.net/images/2023/0615/c5c33275b4f08d18108e9f3756ef44f1.png

Hi, I would like to suggest you add some negative points if there are some background regions in the mask output. You can sample some points in the unwanted area and set the corresponding point_label to 0

hi ,@ymq2017
this is my code
input_point = np.array([[54,161], [324,233],[594,133]])
input_label = np.ones(input_point.shape[0])
input_box = None
hq_token_only = True
How do I add negative points? Thanks very much。

Hi, I would like to suggest you add some negative points if there are some background regions in the mask output. You can sample some points in the unwanted area and set the corresponding point_label to 0

Hello, I did it according to the plan you provided, and it still has no effect
https://df5apg8r0m634.cloudfront.net/images/2023/0619/eede6588c427cb8881b5730207551f2d.png


Notebook page never reconnects.

Steps:

Run page.
Turn off qStudio
Turn on QStudio
Page stays black.

Ignores invalid replies so reconnects.


example is not working

I got "Application ReduxRouter has not been registered." error on AppRegistry.registerComponent function. Btw i didn't change anything on example. Does anyone know why i am getting this error ?
Thanks

I am unable to replicate this error @yusufseyrek.  Are you running react-native start from inside the example/ReduxRouter directory?

Thanks @malkomalko! i just didn't realize that

Which react version this example is supporting because there is no react dependency in package.json?


'kool run compile' ignoring .env

The command that is being exceuted: docker run --init --rm -w /app -ti --volume /Users/jun/Opensource/kool:/app golang:1.15.0 go build -o kool
I guess that the golang docker image is Linux based and we are not forwarding the local environment variables, but not 100% sure.
Obs: my local environment is MacOS based

I am not sure I understand. What environment variables you would like to pass down the container? And .env is not something I ever considered supporting for compilation time.
Passing variables through for the container would require using docker run -e ENV=VAL in order to pass them down, which we don't do - and probably do not want to do for all variables.
So to clarify in the given situation:

docker does have all the env environment available.
go build does not have, since docker run did not pass down the variables with the -e option.

Ahh I understand now, you mean for local development.
I guess in this case you can setup the .env.dist file with the options (Linux / MacOS) for GOOS, GOARCH, etc. Default to Linux.
Then ignore .env. Then update the compile script within kool.yml to pass down the necessary variables explicitly.

This has been solved at current master and will go into the next release 1.0.17.


Gulp Failed at the<EMAIL_ADDRESS>install script 'node build.js'.

Hi,
I've ran into an issue on my mac osx sierra 10.12.1.
Heres a breakdown below of what I am using:

NPM version (npm -v):
3.10.9
Node version (node -v):
7.0.0
Node Process (node -p process.versions):

{ http_parser: '2.7.0',
  node: '7.0.0',
  v8: '5.4.500.36',
  uv: '1.9.1',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  icu: '57.1',
  modules: '51',
  openssl: '1.0.2j' }

Node Platform (node -p process.platform):
darwin
Node architecture (node -p process.arch):
x64
node-sass version (node -p "require('node-sass').info"):

module.js:474
    throw err;
    ^
Error: Cannot find module 'node-sass'
    at Function.Module._resolveFilename (module.js:472:15)
    at Function.Module._load (module.js:420:25)
    at Module.require (module.js:500:17)
    at require (internal/module.js:20:19)
    at [eval]:1:1
    at ContextifyScript.Script.runInThisContext (vm.js:25:33)
    at Object.exports.runInThisContext (vm.js:77:17)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:573:32)
    at bootstrap_node.js:345:29

npm node-sass versions (npm ls node-sass):

/Users/mdunbavan
└─┬<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
The stack trace of the error I get is in this gist file here: http://bit.ly/2eGRfaM
Thanks,
Mark

0.9.6 is very old and will not support node 7. Follow #1766 for when the support is added to the latest version

I have updated node-sass globally but I still get the error when doing npm install in my project folder, when I run npm ls node-sass I get this:
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
This looks okay but do you think its gulp sass thats breaking it @nschonni ?


Duplicate audio overrides cause crashes

Having two mods that override the same audio event causes a crash, ideally we just follow loadpriority for determining which one gets used

Was supposed to get fixed by #677 but apparently didn't?

Was supposed to get fixed by #677 but apparently didn't? At least I observed based on some reports. Maybe someone could retest with latest release?

Do you have any conflicting mods or crash logs so we can investigate?


Needs IRQL environment definition

d3dkmthk.h defines PDXGK_INITIAL_COMPONENT_STATE as DISPATCH_LEVEL IRQL callback:
typedef
IRQL_requires(DISPATCH_LEVEL)
VOID
(*PDXGK_INITIAL_COMPONENT_STATE) (
PVOID GraphicsDeviceHandle,
PVOID PrivateHandle,
ULONG ComponentIndex,
BOOLEAN IsBlockingType,
UINT InitialFState,
GUID ComponentGuid,
UINT PowerComponentMappingFlag
);
What this means is that IRQL will be raised to DISPATCH_LEVEL when the callback is called (DXGGLOBAL::RegisterSharedPowerComponent acquires a spinlock). So implementers of the PDXGK_INITIAL_COMPONENT_STATE callback has to make sure no pageable code or data is accessed, therefore it is important to document this requirement here.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b7fc4685-72f7-3422-0b2e-601e39047050
Version Independent ID: 26adbac7-a725-94a1-379c-5c7e3a538d21
Content: PDXGK_INITIAL_COMPONENT_STATE (d3dkmthk.h) - Windows drivers
Content Source: wdk-ddi-src/content/d3dkmthk/nc-d3dkmthk-pdxgk_initial_component_state.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @lorihollasch
Microsoft Alias: loriwhip

Thanks for filing this issue, @ivanrouzanov. Driver writers are expected to understand Windows OS fundamentals, so we don't (can't) spell out all requirements on every ref page. I did add the IRQL level to the table at the bottom of the page, and also added a link within the Remarks section to a page that discusses pageable code/data since you asked - we appreciate your desire to improve the docs!

Thank you Lori, I really appreciate it! I do agree that driver writers need to understand Windows OS requirements, but they often don't. The reason I asked for this is because I had to debug real bug in an audio driver which was calling KeWaitForSingleObject from this callback leading to a Bugcheck. Thank you!


[enhancement]: List of Ideas

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Ideas for improvement:

Standalone GUI that's more efficient than Webui
All files including compvis base models all part of single click installer (with all license agreement screen in one page)
Ability to graphically combine and control various weights of models
Ability to download models directly within the model manager
Ability to input multiple images for img-to-img generation
Make each image output has separate text file generated with info i.e prompt, seed, settings etc, rather than all output in one text file
Update to latest version function built into GUI
Ability to control precise allocation of VRAM for image generation via GUI
Ability to allow GPU and CPU run task simultaneously for one task
Incorporate an innovative Prompt Presets function under the prompting box, so the user can press any button of user saved presets (such as 4k, highly detailed, global illumination, photorealistic, trending on artstation etc etc) IN ADDITION to the words in the prompt box so the user don't have to type up repetitive quality maintenance prompts every time. Perhaps color coding can be useful for the prompt words. The same button can remove the entire preset as well.
Be better than all the features of Automatic1111 Webui  ;-)

Alternatives
No response
Aditional Content
No response

Clean uninstall and reinstallation would be nice

Some of them are already in plans :-)
Clean uninstall — just delete Invoke’s folder.

Some of them are already in plans :-) Clean uninstall — just delete Invoke’s folder.

Also good if your reinstalling  to clear pip cache folder python uses under c:\users\yourusername\appdata\Local\pip\cache\ if your on windows, as this has caused some rare install issues in the past with failed downloaded files

There may be some good ideas here but please resubmit them as individual feature requests if you still want them.


Implement best practices for default-apps-aws app

Coming from here.
The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.
Expected outcome:

[ ] the app has properly set PDBs (as percentages)
[ ] the app can scale horizontally based on Custom Metrics (if it makes sense)
[ ] the app runs with more than 1 replica by default (if it needs HA)
[ ] the app does not use emptyDir volumes if not strictly necessary

@LolloneS the default-apps-aws is a bundle of apps that installs the default apps required in a cluster. It's not an app in itself, so I don't think this issue makes sense for default-apps-aws. Before closing it, I'd like a confirmation from your side, because I may be missing something.

Looking at the apps inside default-apps-aws I see:
appName: aws-ebs-csi-driver
appName: aws-pod-identity-webhook
appName: capi-node-labeler
appName: cert-exporter
appName: cert-manager
appName: coredns
appName: cilium
appName: external-dns
appName: metrics-server
appName: net-exporter
appName: node-exporter
appName: vertical-pod-autoscaler
appName: vertical-pod-autoscaler-crd
appName: observability-bundle

Most of these apps already have their issues assigned to the appropriate teams. Do you see any app owned by hydra that could use a sanity check on whether it's well configured? If yes, I can open an issue for that specific app, otherwise we close this one and we're good :)

I don't think we have any other managed apps. The rest of the apps we own are only deployed to MCs.

Then we're good to close. Thanks! 😄


ML Refactoring

[ ] Split the data in train, validation and test datasets, possibly in a separate file (maybe a data preprocessing file)
[ ]  Restructure from scripts (e.g. use __name__=="main" or notebooks)
[ ] Condense the hidden layers into a loop instead of repeating
[ ] Keep the variables' preprocessing out of NN_pred.py file, in a more standard file (e.g. Data_Preprocessing.py)

NOTE: Given the refactoring, we should add basic tests to ensure that the functioning of the code  and inferences remains the same. We also consider adding unit tests as we go along.

Self Note:  The modules loaddata.py and train.py will have no direct interaction with FTorch. FTorch will call the NN_pred.py module to make predictions using the trained models (in the form of torchscripts.)


Update data for update chain list online

[x] Price map on Static Content
[x] Add disable checkbox and logic for Chain > providers
[x] Add disable checkbox and logic for Chain Asset > AssetRefs
[x] disabledXcmChannels on Static Content

Add disable checkbox and logic for Chain Asset > AssetRefs => disabledXcmChannels on Static Content

https://static-data.subwallet.app/chain-assets/list-disabled-xcm-channels.json
https://static-data.subwallet.app/chain-assets/preview-disabled-xcm-channels.json

Price map on Static Content

https://static-data.subwallet.app/chain-assets/list-price-map.json
https://static-data.subwallet.app/chain-assets/preview-price-map.json

Add disable checkbox and logic for Chain > providers => Auto remove provider from list


Make OAuth2PasswordBearer compatible with WebSocket objects

I'm trying to implement WebSockets.
Just like with HTTP, I use a header called 'X-Authorization' for my JWT token:
websocket.WebSocketApp("ws://localhost:5000/api/v1/subscriptions/", header={"X-Authorization": f"Bearer {token}"})
I inject a dependency called get_current_user. This dependency uses OAuth2PasswordBearer (in line with documentation).
This results in the following error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 154, in run_asgi
    result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
  File "/usr/local/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__
    return await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/fastapi/applications.py", line 199, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/applications.py", line 111, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 146, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/base.py", line 21, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/cors.py", line 70, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/sessions.py", line 75, in __call__
    await self.app(scope, receive, send_wrapper)
  File "/usr/local/lib/python3.9/site-packages/starlette/exceptions.py", line 58, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 566, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 283, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 57, in app
    await func(session)
  File "/usr/local/lib/python3.9/site-packages/fastapi/routing.py", line 237, in app
    solved_result = await solve_dependencies(
  File "/usr/local/lib/python3.9/site-packages/fastapi/dependencies/utils.py", line 516, in solve_dependencies
    solved_result = await solve_dependencies(
  File "/usr/local/lib/python3.9/site-packages/fastapi/dependencies/utils.py", line 548, in solve_dependencies
    solved = await call(**sub_values)
TypeError: __call__() missing 1 required positional argument: 'request'

... because OAuth2PasswordBearer always looks at the Request object, which we don't have when using WebSockets: https://github.com/tiangolo/fastapi/blob/5614b94ccc9f72f1de2f63aae63f5fe90b86c8b5/fastapi/security/oauth2.py#L153
According to the documentation, WebSocket objects have Header as well, so shouldn't we allow for looking at the WebSocket object?

We don't have the Request object available there. Instead we have the WebSocket object. Try to run this:
from fastapi.websockets import WebSocket
from fastapi import FastAPI

app = FastAPI()

@app.websocket("/ws")
async def websocket_endpoint(websocket: WebSocket):
    print(websocket.headers)
    await websocket.accept()
    while True:
        data = await websocket.receive_text()
        await websocket.send_text(f"Message text was: {data}")

We don't have the Request object available there. Instead, we have the WebSocket object. Try to run this:
from fastapi.websockets import WebSocket
from fastapi import FastAPI

app = FastAPI()

@app.websocket("/ws")
async def websocket_endpoint(websocket: WebSocket):
    print(websocket.headers)
    await websocket.accept()
    while True:
        data = await websocket.receive_text()
        await websocket.send_text(f"Message text was: {data}")

For those who want to verify, run wtih: uvicorn <path>:app
And establish a connection: websocat ws://localhost:8000/ws

I know, that's what I'm saying.

My bad, I didn't read all your message.
As an apology, I've implemented the feature. :nerd_face:

It's not possible to implement it for WebSockets, the reason is that HTTPExceptions are handled for http, not for websockets and the OAuth2 classes uses it underneath in case is not authorized. Hence, not possible to do it, in a trivial way at least.
What is possible to do is:

Change the request: Request for authorization: str = Header(...) (or Optional[str] = Header(None)
Create a wrapper around it, so it can handle the erased HTTPException in a "clean way".

A "clean way" could be just returning None and not sending back an acceptance e.g. (await websocket.accept()).
P.S.: As soon as I saw your last message I tried to implement it, then I faced the mentioned issue on doing it.

Your efforts are highly appreciated!
I'm not very familiar with the internals of FastAPI, so I'm not sure which option is best for this use case. Should we keep this issue open for others to think along?

Your efforts are highly appreciated!
I'm not very familiar with the internals of FastAPI, so I'm not sure which option is best for this use case. Should we keep this issue open for others to think along?

Sure! :nerd_face: :+1:

Sure! :nerd_face: :+1:

Haven't used this myself, but you might have a look at: https://indominusbyte.github.io/fastapi-jwt-auth/advanced-usage/websocket/

Haven't used this myself, but you might have a look at: https://indominusbyte.github.io/fastapi-jwt-auth/advanced-usage/websocket/

Hi, just encountered this issue too. I am not familiar with FastAPI internals, but maybe it's worth adding websocket support when auto_error is False?

Hi, just encountered this issue too. I am not familiar with FastAPI internals, but maybe it's worth adding websocket support when auto_error is False?

Also interested in this 👀 I maintain an authentication library which rely internally on OAuth2PasswordBearer and APIKeyCookie.
I get questions from some users who don't understand why it's not working for websockets. It would be nice indeed if those security schemes could support websockets in some way.
I get that there is a gotcha with the HTTPException there. I'm not familiar with fastapi internals but here is an idea:

Instead of directly raise an HTTPException, the schemes could raise a generic exception "SecurityException"
I see that the dependency resolver is able to distinguish between Request and Websocket. So maybe we could catch those SecurityException there and accordingly raise an HTTPException or close the websocket.

I've not thought about it very much, so maybe it's totally wrong and it probably needs lot of changes in the codebase.
Would be happy to help if needed though 😄

Also interested in this 👀 I maintain an authentication library which rely internally on OAuth2PasswordBearer and APIKeyCookie.
I get questions from some users who don't understand why it's not working for websockets. It would be nice indeed if those security schemes could support websockets in some way.
I get that there is a gotcha with the HTTPException there. I'm not familiar with fastapi internals but here is an idea:

Instead of directly raise an HTTPException, the schemes could raise a generic exception "SecurityException"
I see that the dependency resolver is able to distinguish between Request and Websocket. So maybe we could catch those SecurityException there and accordingly raise an HTTPException or close the websocket.

I've not thought about it very much, so maybe it's totally wrong and it probably needs lot of changes in the codebase.
Would be happy to help if needed though 😄

Just found out this PR on Starlette: https://github.com/encode/starlette/pull/527

Just found out this PR on Starlette: https://github.com/encode/starlette/pull/527

Clearly, that would definitely help! But it seems there are some blockers there. Not sure, how we could help though 😅

Clearly, that would definitely help! But it seems there are some blockers there. Not sure, how we could help though 😅

Any news about this? it would be great to be able to easily secure websocket routes


Send test messages to a pipeline

Description

Adds the ability to send test messages through a pipeline. This allows users to validate that the pipeline builds, and users can also visualize the outputs / inputs between each node.
User Impact

Users will have much faster feedback on what is happening within a pipeline.
Demo

https://github.com/user-attachments/assets/d2899b91-9896-4119-b6f8-938f054b56d6

Docs

:x: 3 Tests Failed:

Tests completed
Failed
Passed
Skipped

748
3
745
0

View the top 3 failed tests by shortest run time

apps/pipelines/tests/test_runnable_builder.py::::test_branching_pipeline

Stack Traces | 1.72s run time

.../pipelines/tests/test_runnable_builder.py:405: in test_branching_pipeline
    assert output == expected_output
E   AssertionError: assert {'Passthrough...Input)'}, ...} == {'Passthrough... Input)', ...}
E     Differing items:
E     {'RenderTemplate-B': {'message': 'B (The Input)'}} != {'RenderTemplate-B': 'B (The Input)'}
E     {'RenderTemplate-A': {'message': 'A (The Input)'}} != {'RenderTemplate-A': 'A (The Input)'}
E     {'Passthrough-1': {'message': 'The Input'}} != {'Passthrough-1': 'The Input'}
E     {'RenderTemplate-C': {'message': 'C (B (The Input))'}} != {'RenderTemplate-C': 'C (B (The Input))'}
E     {'Passthrough-2': [{'message': 'A (The Input)'}, {'message': 'C (B (The Input))'}]} != {'Passthrough-2': ['A (The Input)', 'C (B (The Input))']}
E     Full diff:
E       {
E     -  'Passthrough-1': 'The Input',
E     +  'Passthrough-1': {'message': 'The Input'},
E     ?                   ++++++++++++           +
E     -  'Passthrough-2': ['A (The Input)',
E     +  'Passthrough-2': [{'message': 'A (The Input)'},
E     ?                    ++++++++++++               +
E     -                    'C (B (The Input))'],
E     +                    {'message': 'C (B (The Input))'}],
E     ?                   ++++++++++++                    +
E     -  'RenderTemplate-A': 'A (The Input)',
E     +  'RenderTemplate-A': {'message': 'A (The Input)'},
E     ?                      ++++++++++++               +
E     -  'RenderTemplate-B': 'B (The Input)',
E     +  'RenderTemplate-B': {'message': 'B (The Input)'},
E     ?                      ++++++++++++               +
E     -  'RenderTemplate-C': 'C (B (The Input))',
E     +  'RenderTemplate-C': {'message': 'C (B (The Input))'},
E     ?                      ++++++++++++                   +
E       }

apps/pipelines/tests/test_pipeline_runs.py::::test_running_pipeline_creates_run

Stack Traces | 1.72s run time

.../pipelines/tests/test_pipeline_runs.py:35: in test_running_pipeline_creates_run
    assert run.output == PipelineState(
E   AssertionError: assert {'ai_message_...age': 'foo'}}} == {'ai_message_...cond': 'foo'}}
E     Omitting 2 identical items, use -vv to show
E     Differing items:
E     {'outputs': {'first': {'message': 'foo'}, 'second': {'message': 'foo'}}} != {'outputs': {'first': 'foo', 'second': 'foo'}}
E     Full diff:
E       {
E        'ai_message_id': 328,
E        'messages': ['foo', 'foo', 'foo'],
E     -  'outputs': {'first': 'foo', 'second': 'foo'},
E     +  'outputs': {'first': {'message': 'foo'}, 'second': {'message': 'foo'}},
E     ?                       ++++++++++++     +            ++++++++++++      +
E       }

apps/events/tests/test_actions.py::::test_end_conversation_runs_pipeline

Stack Traces | 1.75s run time

.../events/tests/test_actions.py:56: in test_end_conversation_runs_pipeline
    assert log.log == str(
E   assert "{'messages':...ession': 320}" == "{'messages':...ession': 320}"
E     Skipping 197 identical leading characters in diff, use -v to show
E     - {'first': 'human: Does anything get lost going through the pipe?', 'second': 'human: Does anything get lost going through the pipe?'}, 'experiment_session': 320}
E     + {'first': {'message': 'human: Does anything get lost going through the pipe?'}, 'second': {'message': 'human: Does anything get lost going through the pipe?'}}, 'experiment_session': 320}
E     ?           ++++++++++++                                                       +            ++++++++++++                                                        +

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Cool that we can see the path a message takes! Agreed with Simon that this looks useful and like a good starting point.
One other future thought is that we'll want to chat to individual nodes and/or subsets of the pipeline. Choosing an arbitrary start and end node would be useful.


why does net_server and net_client with lesser code has lower QPS than shmipc_server and shmipc_client?

why does net_server and net_client with lesser code has lower QPS than shmipc_server and shmipc_client?
possible to provide example to better understand the example folder?
getting 400000 QPS with shmipc_ example and 140000 QPS with net_ example

Later this week, I will add a README to explain

@goodbye-babyer waiting for this. pls inform in this post if updated in README / doc. thx

I'm sorry, I have been busy lately. Perhaps you can learn about the implementation principle of shmipc through this.
https://github.com/cloudwego/shmipc-spec


Contextstore

Description
Move contextstore to an internal package

Codecov Report

Merging #411 into master will decrease coverage by 0.16%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   56.55%   56.38%   -0.17%
==========================================
  Files          45       45
  Lines        6067     6067
==========================================
- Hits         3431     3421      -10
- Misses       2329     2338       +9
- Partials      307      308       +1

Impacted Files
Coverage Δ

monitor/linuxmonitor/processor.go
41.71% <42.85%> (ø)
:arrow_up:

internal/contextstore/contextstore.go
64.91% <64.91%> (ø)

monitor/rpcmonitor/rpc.go
57.26% <0%> (-9.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc80401...bb846f5. Read the comment docs.


Show who is talking

does not seem to work, not seeing a border

@ken-de-moor I've made a booboo, Try again

Does not work in grid view, only in presentation view @coeneivan


Integrate SendApplicationsToProvider with Sidekiq & Clockwork

READY FOR REVIEW BUT MARKED AS DRAFT BECAUSE NEEDS TO BE REBASED AFTER MASTER IS FIXED
Context
This PR configures Clockwork to schedule a nightly job to update the status of applications that have passed their edit_by date are are therefore ready to 'send' to provider. It is a follow up to https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/471
Changes proposed in this pull request

Convert the SendApplicationsToProvider service class to a Sidekiq job.
Configure Clockwork to run the SendApplicationsToProvider job every day at 1:00AM (localtime).

Note that we don't actually send anything to a provider yet, we are just updating the status of the ApplicationChoice to awaiting_provider_decision. Notifications are an upcoming feature.
Guidance to review

Does it make sense to run this job daily at 1:00AM? (Note that edit_by values are always set to the end of a day so expire at midnight)
Is the Clockwork config correct?
The Sidekiq job should retry if it fails. Is there anything else that could stop the job running correctly? If it doesn't run the provider will not see applications on time.

Link to Trello card
1202 - Add Provider_Receive_Application
Env vars
No new env vars

Would it make sense to trigger the job after all references have come in, so the application is pushed to the provider more quickly?

Would it make sense to trigger the job after all references have come in, so the application is pushed to the provider more quickly?

Yes. In ReceiveReference we already handle the case in which edit_by expires before the references are all complete and make the state transition per application. https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/blob/master/app/services/receive_reference.rb#L27-L28


Holding down a key only sends a single key on Mac

Original issue: https://github.com/Microsoft/vscode/issues/10398
Does not reproduce on Ubuntu 16.04
Details

Browser and browser version: vscode/electron (Chrome v49)
OS version: OS X
xterm.js version: 220828f

Steps to reproduce

npm start
Focus terminal and hold the a key, only a single character is added to the prompt

Oh apparently this is standard across Mac applications

Yep, that's true. Even on native text areas in browser.
We could create an add-on though to handle this, since the native terminal on OS X sends repeated keypress events.

I think we should support this out of the box like the default terminal on Mac does.

Just dumping some initial thoughts on this, because I did a little research…
Terminal.app seems to not do anything special, it repeats every key that has no accented characters associated (- repeats, o does not):

My first thought was, that its not possible to work around this, as it's a OS feature that can only be disabled global for all applications by the user or as a default setting in the applications .plist. JavaScript has no ability control this, in the case of VSCode this would need to be set somewhere in Electron.
BUT:
As it turns out, the browser receives the key event repeatedly even if the popup for the accented characters appears (tested on http://unixpapa.com/js/testkey.html):

Although a little hackish, it might be possible to just listen to event, take the charcode (only accessible on the first event that gets fired, not sure why) from it and append it somehow back via String.fromCharCode.
The now still visible popup would be annoying, but it looks like it gets swallowed by xterm anyway, in the browser as well as inside VSCode:

Was there ever any forward activity on this bug? We really feel that key-repeat in a terminal is sort of a crucial function, as in iTerm, Terminal.app, etc.
Perhaps an addon exists that didn't make it to this thread?  Thanks very much!

I know the reason for this now; it happens because we're listening to keydown and keypress, not input which throws these repeated char events. We will also need to use input for proper emoji support on macOS https://github.com/sourcelair/xterm.js/issues/469

Is a fix on your radar, would you say? 👍

On radar yes, it's a blocker for Hyper to move over to xterm.js

What's Hyper?

A terminal emulator that is considering moving over: https://hyper.is/

Ah I thought maybe you meant that one. Have been using it on and off for the past year. Love the sparkles effect trail as you type! :-)
So that means everything should work fine in Electron?

@willkessler I embed xterm.js in VS Code which is also an Electron app, works great 😃


~home

I would like to specify my configPaths relative to my home directory, but it seems to choke when I use "~/Dropbox/Tools/c-uncrustify.cfg"  I instead need to use the full path.
This makes life difficult as my config file is synced between different machines, even though my home directory is different.

For machine specific configurations, like this, I configure in the Atom Beautify Package settings.

Looks like this is what I need: http://stackoverflow.com/a/24840351/2578205

Published to v0.22.1
Let me know how it works for you.

:+1: Awesome. Thank you.


Bump cookie_jar from 3.0.0 to 4.0.1

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I'm adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests without failures
[x] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Blocked by #1760.


Fix typo in zsh completion

Spotted this typo :smile:
ping @vdemeester @sdurrheimer ptal

:+1:

LGTM


Firebase updateProfile for currentUser

Currently we don't have updateProfile for the currentUser. user with emailAndPassoword needs a updateProfile for DisplayName and ProfilePicture.

dup of #10580 ?


delete-pvcs now deletes PVCs from any Completed pods

Previously we deleted only PVCs older than a day.
Now we delete all PVCs associated with pods in the Completed state.
EDIT: And also delete pods older than a day.
Fixes #192

Merging.
I'll wait with re-deploying this so that it doesn't interfere with your work on packit/packit-service#1047 @TomasTomecek


[BUG] Platform miwifi does not generate unique IDs

Describe the bug
Logger: homeassistant.components.device_tracker
Source: helpers/entity_platform.py:520
Integration: Device tracker
First occurred: December 22, 2022 at 22:13:26 (1 occurrences)
Last logged: December 22, 2022 at 22:13:26
Platform miwifi does not generate unique IDs. ID miwifi-XX:XX:XX:XX:XX:XX is already used by device_tracker.miwifi_xx_xx_xx_xx_xx_xx - ignoring device_tracker.miwifi_yy_yy_yy_yy_yy.
Please complete the following information:

HASS version: 2022.12.8
Component version: v2.9.0
Router model AX3600
Router firmware version 3.0.22

Same here

Also same here,
Could it be that the circled device in this part of the code in device_tracker.py should be new_device?


[hw,keymgr_dpe,dif] Sync Keymgr_dpe DIF from integrated_dev to Master

This PR syncs the DMA DIF from integrated_dev to master.
This PR depends on https://github.com/lowRISC/opentitan/pull/24438

Thanks for looking at this: I was aware it was in the wrong directory but now rebased everything to comply with the directory structure of master.

@pamaury I just cleaned up the commit messages.


File size too large to be used as a template

Thank you for this which I've successfully deployed locally: Just a heads up really as I was unable to use as a github template due to files being larger that 10Mb. I think its just because you've done a push with your model included and it wasn't included in a .gitignore file. Thanks for your work again.

Thanks for pointing that out Chris, I will update .gitignore accordingly
and push updates sometime today. Take care.
On Wed, Sep 2, 2020 at 5:49 AM Christopher Bale<EMAIL_ADDRESS>wrote:

Thank you for this which I've successfully deployed locally: Just a heads
up really as I was unable to use as a github template due to files being
larger that 10Mb. I think its just because you've done a push with your
model included and it wasn't included in a .gitignore file. Thanks for your
work again.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/psmathur/fastai2-vision-app/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK3DKM2RX5E5ISP5DA676DSDY5OFANCNFSM4QS67ILA
.

Ok, I have removed .pkl file so this repo can be used as github template, and it wasn't earlier as you mentioned due to size restrictions of 10 MB. Apparently, .gitignore didn't work. Look like, It is an expected behavior as mentioned here => https://github.com/education/classroom/issues/2521
Please try and let me know , if you still have issues. Again, thanks for reporting this appreciated.


create XrInstance

Context
Continuation of #3 .
In OpenXR we must create XrInstance first.
https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#instance

An OpenXR instance is an object that allows an OpenXR application to communicate with an OpenXR runtime. The application accomplishes this communication by calling xrCreateInstance and receiving a handle to the resulting XrInstance object.

Summary

[x] Define OpenXR context, which will include OpenXR instance, session, etc.
[x] Create OpenXR instance and store it in the context

How to check behavior

Build and run with your Oculus Quest.
Confirm that no error log happens from "ZEN".
When some error happens, you will see

E/ZEN: <some error log>

Checkout XrInstance info in the log

I/ZEN: Instance RuntimeName=Oculus RuntimeVersion=43.178.0

Thanks for your review!


Mobile_detect not found in _culturefeed_agenda_preprocess_agenda

Inside the _culturefeed_agenda_preprocess_agenda function the mobile detect helper function is called. This function checks / uses the external Mobile_Detect php class.
When you don't use this class, the drupal DB log get's filled with class not found notices, generated by the helper function.
However this external class is not required, and doesn't get added by any composer files. This is good, since it's not needed to use. And this plugin wouldn't work correctly with the drupal page cache. So the actual issue is to not write those messages to the watchdog table.

Hi @mallezie
we decided shortly to remove all dependencies to the Mobile Detect PHP library and move this detection to our theme culturefeed_bootstrap through javascript. See also PR https://github.com/cultuurnet/culturefeed/pull/142.
This issue should be fixed soon when there is a new release. I hope somewhere in May 2017.


image capture keybinding and configs

Let\s say you wanted to process a big box of receipts AND you wanted to scan each one as you go. This feature request is for support of capture, naming and taming of image files related to transactions.
Capture support could take the form of a keybinding that invokes a user-definable script, that;

triggers the image-capture/ scan of the source document
uses pre-defined locations (config file) for both image file(s) and physical document(s)
produces files named like $DATE_$DESCRIPTION.$EXT
adds transaction comment tags like '  ; scan: $FILE_LOCATION/$DATE_$DESCRIPTION.$EXT'
adds transaction comment tags like '  ; document: $DOC_LOCATION   # tracking the source paper file

How exactly webcam/ smartphone/ scanners are triggered and what process the image files undergo, is beyond the scope of this suggestion. This issue is really more of a discussion-starter.

This is very specific. I think a reasonable general approach would be to pipe the current transaction to a user-definable script and read the modified transaction back again. This would allow to do arbitrary transformations on the transaction, including the addition of tags.
simonmichael/hledger#501 could be useful for this.

well.. yeah!
;-)


Yfinance does not provide continuous data on somedays

API does not provide data while on some days while the market is running. I did not get data on 10-08-21 and 17-08-21. This has been a persisting issue for over a year now.
import yfinance as yf
from datetime import datetime as dt
from datetime import timedelta
def get_data():
st_date = dt.now()
ed_date = st_date - timedelta(1)
st_date = st_date + timedelta(1)
stk = yf.Ticker("L&TFH.NS")
df = stk.history(start=st_date, end=ed_date, interval="15m")

Same is true for me. I just try to get the TRY=X data and it consistently comes wrong. Same wrong value. Then it is solved by no reason and it happens after two or three weeks.

Second half of market data (5 mins candles) was missing today until now for .NS symbols.


Add BE and CH SNOMED CT versions

Copy of https://github.com/hapifhir/org.hl7.fhir.validator-wrapper/pull/138 with more recent code base.

Aligns with versions listed on http://tx.fhir.org/snomed/


RUMM-2380: Enable custom application version support

What does this PR do?
Cherry picks https://github.com/DataDog/dd-sdk-android/pull/1020 into 1.14.0 release branch.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1026 (b8fb0e3) into release/1.14.0 (26195cd) will increase coverage by 0.10%.
The diff coverage is 96.49%.

@@                Coverage Diff                 @@
##           release/1.14.0    #1026      +/-   ##
==================================================
+ Coverage           83.03%   83.12%   +0.10%
==================================================
  Files                 270      272       +2
  Lines                9249     9268      +19
  Branches             1488     1490       +2
==================================================
+ Hits                 7679     7704      +25
+ Misses               1157     1156       -1
+ Partials              413      408       -5

Impacted Files
Coverage Δ

...oid/core/internal/system/NoOpAppVersionProvider.kt
66.67% <66.67%> (ø)

...n/com/datadog/android/core/internal/CoreFeature.kt
91.56% <87.50%> (+0.04%)
:arrow_up:

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
81.97% <100.00%> (+0.45%)
:arrow_up:

.../main/kotlin/com/datadog/android/_InternalProxy.kt
87.50% <100.00%> (-1.39%)
:arrow_down:

.../core/internal/system/DefaultAppVersionProvider.kt
100.00% <100.00%> (ø)

...adog/android/error/internal/CrashReportsFeature.kt
100.00% <100.00%> (ø)

.../src/main/kotlin/com/datadog/android/log/Logger.kt
95.97% <100.00%> (ø)

...atadog/android/log/internal/domain/LogGenerator.kt
99.02% <100.00%> (+0.02%)
:arrow_up:

...otlin/com/datadog/android/rum/_RumInternalProxy.kt
100.00% <100.00%> (ø)

...lin/com/datadog/android/rum/internal/RumFeature.kt
93.00% <100.00%> (+0.07%)
:arrow_up:

... and 16 more


[WIP] Change the protocol of ALB listener from HTTP to HTTPS.

This PR is for confirming difference of a service template.

Sorry, it is my mistakes...


Twitter likes and replies not working since morning

I tried posting a like and reply to twitter but it is not working for me today. It was working yesterday so I am not sure what went wrong. I am using Indieweb Drupal module.
Example like: https://www.ravisagar.in/like/httpstwittercomgitlabstatus1300433693174005768s09
Example reply: https://www.ravisagar.in/reply/reply-httpstwittercomrobertcastelostatus1300811243020836880
Like and replies to non twitter sites are working though.
Thanks

hi ravi, sorry for the trouble! i don't actually see any requests to Bridgy to publish those two posts, either in bridgy's logs or on your user page. maybe try again?

There was problem on Drupal side. I cleared the queue and it works now. Thanks for looking into this.

No problem! Glad you figured it out.


netbird-ui: 0.9.8 -> 0.10.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/netbirdio/netbird/releases.
meta.description for netbird-ui is: "Connect your devices into a single secure private WireGuard®-based mesh network with SSO/MFA and simple access controls"
meta.homepage for netbird-ui is: "https://netbird.io"
meta.changelog for netbird-ui is: "https://github.com/netbirdio/netbird/releases/tag/v0.10.0"
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.10.0 with grep in /nix/store/k1bb0ryakza0s5w59adzqncsw86k9j81-netbird-0.10.0
found 0.10.0 in filename of file in /nix/store/k1bb0ryakza0s5w59adzqncsw86k9j81-netbird-0.10.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
netbird
netbird-ui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k1bb0ryakza0s5w59adzqncsw86k9j81-netbird-0.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A netbird-ui https://github.com/r-ryantm/nixpkgs/archive/7f7136de99e6ba203d44f5d431153bf43f8f9a89.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k1bb0ryakza0s5w59adzqncsw86k9j81-netbird-0.10.0
ls -la /nix/store/k1bb0ryakza0s5w59adzqncsw86k9j81-netbird-0.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

netbird
netbird-ui

Maintainer pings
cc @misuzu for testing.

Duplicate of https://github.com/NixOS/nixpkgs/pull/196492


@conda-forge-admin, please rerender

Additional comment:
No response

Hi @zklaus anything specific that we missed? Please feel free to add you as well, by the way, if you are interested.

Ahh no worries, just wanted to see where the error is. :)
Thank you! Standing by until I get the green light from you.

Alright, the bot is officially unstuck: #6. Seems like openml is not Numpy 2 compatible, so you'll need to add an upper pin.
Feel free to close #5; it is not needed anymore, but I can't do it because the bot opened it and I am not a maintainer.

Thank you very much for your help here! Done and done, let's see if it goes through.


[Bug]: On hovering card of users flickering issue

What happened?
when we hover on the card of users/profiles there is flickering issue . It should not flicker and instead retain its height
Add screenshots
Ad

d screenshots
What browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yh, I've seen this as well, also the skills  part isn't as functional as it should be. It's only when you hover over the skills section it changes height.

So, would you like me to fix this height changing issue.

it's still flickering

Hi , please assign this issue to me i have seen the code i know how to fix it


Fix the NMSLib to FAISS Image

Issue #, if available:
2 screenshots of the steps is wrong.
Description of changes:
Added 2 new screenshots and fix the blogpost.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The change has to be made in the .qmd file and then the .md file be generated from it by doing a quarto render but in case you want to do this by hand then please also make a similar change in the .qmd file for consistency.

fixed the qmd file


The release version is not found, try to import using the version label on the example, go mod prompts that the import failed

github.com/hyperledger/fabric-chaincode-go v0.0.0-20200424173110-d7076418f212
ction failed because connected host has failed to respond.

Solve my problem after configuring the proxy, without configuring the proxy release can be downloaded normally, but not through commit hash
go env -w GOPROXY=https://goproxy.cn


fix: 🐛 check if the navigator global is available before usage

Description
Close https://github.com/antvis/X6/issues/2767
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Dark mode overhaul

Changes proposed in this pull request:
Did a major overhaul to the dark-theme. Listed all of them in the different commits. Overall made things darker and fixed some areas that were missing dark-themeing
There are still things needing of fixes here but it shouldn't have anything unusable. The rest could be fixed as we get userfeedback
This does not let normal users use the dark-theme. That still needs permissions
Before

Proposed change

cc @hummingbird-me/staff

I think I want to spend a bit more time adjusting this actually. I have noticed some things I have yet to fix and I think I want to use a different colour pallette as these (and the original ones) are a bit cold, while I think Kitsu would benefit from a warmer tone. The app also has a warmer tone to the colours there already. I think I have a good pallette I can quickly adapt to this tho, so I should be able to fix this quickly

I think I want to spend a bit more time adjusting this actually. I have noticed some things I have yet to fix and I think I want to use a different colour pallette as these (and the original ones) are a bit cold, while I think Kitsu would benefit from a warmer tone. The app also has a warmer tone to the colours there already. I think I have a good pallette I can quickly adapt to this tho, so I should be able to fix this quickly

And with that, I've fixed some more issues and changed the colour palette to one that is based on Josh's colour scheme for the redesign mockup he did. This is ready for review.
PS, there are still some minor tweaks needed in some areas but most of it should be looking good now. For users to get access to this, you'll still need to give them access from the backend or however you have to do that.

And with that, I've fixed some more issues and changed the colour palette to one that is based on Josh's colour scheme for the redesign mockup he did. This is ready for review.
PS, there are still some minor tweaks needed in some areas but most of it should be looking good now. For users to get access to this, you'll still need to give them access from the backend or however you have to do that.


Cleanup remaining test usage of setters in IndexLoadingConfig

Subtask of #14106

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (3ad2d12).
Report is 1199 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (3ad2d12). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (3ad2d12)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14256       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow determining if a project is an application

It would be really useful if there was a way to instruct the dependency-analysis plugin that a project should be analyzed as if it were an application. Currently this is determined by checking for various plugins in the project (e.g. application and org.springframework.boot), but this is rather inflexible.
In projects I'm working on there are several other types we'd like to consider as deployable projects (i.e. not libraries with an API), such as WAR and EJB projects, as well as runtime/implementation projects that implements an API defined elsewhere.
One way of allowing the user to set this could be to add a callback to the root-extension:
dependencyAnalysis {
    projectIsApplicationIf { p -> p.name.endsWith("-impl") || p.pluginManager.hasPlugin("war") }
}

An alternative solution would be to add it as a Property<Boolean> to the IssueHandler, where it could then be configured for each project:
allprojects {
    pluginManager.withPlugin("com.autonomousapps.dependency-analysis") {
        if (name.endsWith("-impl") || pluginManager.hasPlugin("war")) {
            dependencyAnalysis {
                issues {
                    isApplication.set(true)
                }
            }
        }
    }
}

I'm willing to implement this and send a pull request, but I'd like to know if you find such a feature useful - and which of the two approaches you'd prefer. I personally prefer the first option as it's simpler and quite powerful.

Thanks for the issue. I'll consider it and get back to you.


[AMBARI-24999] Disallow changing Kerberos-related configs in Add Service request

What changes were proposed in this pull request?
Complex Add Service request allows changing configuration of existing services.  This change disallows the request to update Kerberos-related configs.
https://issues.apache.org/jira/browse/AMBARI-24999
How was this patch tested?
Tested that request with one or both of the Kerberos-related configs (kerberos-env, krb5-conf) are rejected, but request without these is accepted.
Added unit test for the same.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4692/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4695/
Test PASSed.


Required default constructor

Can you please elaborate on what is meant by a Required default constructor in the Persistence Ignorance section and how that violates that principle?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 829862b0-b51d-d4dd-d770-f875a588384f
Version Independent ID: c5bc4d26-8f85-4544-3a4a-131554241eef
Content: Architectural principles
Content Source: docs/architecture/modern-web-apps-azure/architectural-principles.md
Product: dotnet
Technology: dotnet-ebooks
GitHub Login: @ardalis
Microsoft Alias: wiwagn

Just to clarify, let's say you have an entity PurchaseOrder and it has a PO number like ABC123456 which is required. So you create the entity like this:
public class PurchaseOrder
{
  private string _poNumber = "";
  public PurchaseOrder(string poNumber)
  {
    _poNumber = poNumber;
  }
}

This is a perfectly good and intention-revealing OO class. It enforces its desired invariant that all purchase orders must have a PO Number by making it required in the constructor. It no longer has a default constructor because none is defined and the existence of one that requires a parameter eliminates the one that C# will otherwise create automatically.
However, this entity will not work with EF/EF Core. EF requires a default constructor. So if you have this entity in a project that uses EF, you will most likely write it like this:
public class PurchaseOrder
{
  private string _poNumber = "";
  public PurchaseOrder(string poNumber)
  {
    _poNumber = poNumber;
  }
  private PurchaseOrder() {} // Because EF needs it
}

This is a seemingly useless bit of code that your IDE will tell you can be removed because nothing is calling it, but if you do remove it, EF will break. This class is no longer persistence ignortant because part of its design has been altered for the sole purpose of allowing it to work with a specific persistence strategy, in this case EF.
Does that help?

Yes that is helpful, thank you. I think the terminology of a Required default constructor violating the principle is the cause of my confusion, because I interpreted that as meaning that a default constructor violates the principal, because the default constructor is effectively being required by the compiler because it generates it when no other one has been provided.
A different way of stating this violation of the principle could perhaps instead be Not including a default or parameterless constructor. What do you think?

On second thought I don't think my suggestion is right either.
In your example, how would you make the PurchaseOrder class be persistence ignorant given that you want it to work with EF?

There's not really a good way that I know of - I would do what I show in the second option.
PI is something to strive for, and the more an ORM tool like EF can allow you to use PI entities, the better. But there are very often trade-offs between PI and the productivity benefits you get from using a tool like EF for your persistence.

OK, circling back to the beginning, it seems like the guidance of not adding a required default constructor to a class that has other constructors (as in your EF example) is actually preventing a class from becoming PI, so I'm struggling to see it as a violation of the principle. For the same reason why a POCO type is PI, because it can be instantiated and manipulated without other specialized knowledge as to how the type is designed, so would a class that has a required default constructor added to it become usable in the same way.

In my example above, the first class (without parameterless ctor) is sufficient for the task at hand and is PI. The second version adds a private parameterless constructor for the sole purpose of allowing EF to instantiate the class when it's doing its thing. Stuff that must be added to your object model solely because some particular persistence technology needs it, but which otherwise adds no value, makes the class less "persistence ignorant" and adds some technical debt. The fact that it requires a comment to tell the team why it's there so nobody inadvertently removes it is a big clue that it's a (minor) problem. Another example is private set when modern C# will let you just omit the set entirely if you're only initializing it during construction. If you get rid of the (unused) private set, as your IDE will suggest you do, suddenly EF will stop working and that property will always be null/default when fetched from persistence. Again you have design constraints being made on what are otherwise POCOs due to a specific choice of ORM technology. Does that make sense?

That makes a lot of sense. I think this discussion as an accompaniment to the documentation clarifies the meaning of the statement. I will go ahead and close this off. Thank you!

@maira thoughts on adding a link to this discussion from the doc, or otherwise adding some clarification to it?

This item is very skewed, opinionated and mixes multiple separate contexts. Firstly, polyglot persistence has absolutely nothing to do with types of constructors, base classes et.al.  the idea that a "good constructor" must have required fields makes absolutely no sense in any real application. Real business applications deal with models containing 10s of fields, most of which are conditionally required. Practice shows that it does make a LOT of sense to do the very opposite - NEVER use .ctors with parameters, because there is no uniform pattern, and by adding these ctors which are by the way never called by anyone because all data models must be constructed automatically anyway.  So this article is very much biased.
On a separate note, having a base class, once again is absolutely orthogonal to providing polyglot persistence. What is important is that "active record" -like "saving" logic is NOT in base class - that is true, however in OOP which is NOT dead and very powerful still when done correctly it does make sense to model data models using OOP, using interfaces and extracting common attributes. This is even far more productive in the light of using polyglot data stores (e.g. MsSql / MongoDB / JSON files)


correct level for debug logging

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@bjormel please review and merge
@baldersheim @jobergum FYI

Fixed #22207


[W5.11][F11-A2] Zhang Yijiong

First enhancement, modify find command to be case-insensitive
Therefore, command "find john/John/joHn/JOhn" will all be able to find person John.

Tiny nitpick: Please capitalize the first letter of your commit messages.

Comments read.


Notification command outdated

At the moment on an up to date Manjaro system update-notifier returns
/bin/update-notifier: line 98: dunstify: command not found
Many users on Manjaro also uninstalled dunst after an update one month ago, more or less.
The simplest solution is to use notify-send, at least this is the first that comes to my mind.

There is a reference to notify-send also in the README file, so this method is the more consistent.

I think the simplest solution is to rebuild update-notifier and change the requirement from dunstify to dunst. But I'll have to test how much problems that makes. On one hand, notify-send lacks the desired features of dunstify. On the other hand, having Dunst competing with the local notification daemon is bad.

This package is in the official Manjaro repositories and has been broken for two month, if you do not want to maintain this I can find the time for it, otherwise I think the best idea is to remove it from the Manjaro repositories.
I can't get dunst work for me (can't find the display, maybe has problem with Wayland?), then notify-send is my first choice, let me know if you have any advice in order to use dunst.


tree-sitter-verilog: essentially all tests fail with "Incompatible Language version"

Looking at the outputs of the tree-sitter-verilog tests, (here an example)
https://chipsalliance.github.io/sv-tests-results/?v=tree_sitter_verilog+uvm+adding_constraints_to_scope_variables_1
... they all fail with some obscure error message:
"Incompatible Language version 13. Must not be between 9 and 12"
... I suspect this is some sort of installation problem of whatever underlying parser it uses ?

Fixed by updating base tree_sitter package in #4685.


hoping you could add these...

<IP_ADDRESS> xvtelink.com # ads with redirects
<IP_ADDRESS> invol.co # tracking
<IP_ADDRESS> 36c4.net # redirect to go.trafficrouter.io
<IP_ADDRESS> go.trafficrouter.io
<IP_ADDRESS> track.venatusmedia.com # tracking
<IP_ADDRESS> amptrack.dailymail.co.uk # tracking
<IP_ADDRESS> mailmetromedia.amp.permutive.com #ad
<IP_ADDRESS> videos-cloudflare.jwpsrv.com # video ads
<IP_ADDRESS> videos-fms.jwpsrv.com # video ads

Thank you Henry @piengeng.
Added in commit 7ad72d76.
Closing.

@StevenBlack, how do you verify these actually unwanted sites? Any tests? Just curious to this whole process
Thanks for making my life better

@bnainar I think there's too much for a single person to verify every single entries, I propose those because of my own testing, and personally added those to my pihole's blacklist and hoping others that uses this list could benefit from it. I sure hope the community could prove me wrong on those urls

Hi Nainar @bnainar,
Mostly I rely on curators who've been regularly maintaining their own lists for a long time.
For ad-hoc additions like those in commit 7ad72d7 I typically check several things.

Who's submitting the domains.  Is this person an anon egg on Github, or does this person have a verifiable history.
The plausibility of the domains, including checking the name of the suggested subdomain, whether we list this root domain already, etc.  It puzzles me why some companies name their domains like track.venatusmedia.com (as above) which screams, "block me!".
Often trusted helpers will analyze a suggested domain and comment before I've seen the suggestion.  This is nice since it lightens the load.

Often it's just instinct 😄

Just ran into legit videos being blocked by videos-fms.jwpsrv.com
Not sure what your process is for reviewing things like this, but it is blocking legit videos in at least one app. I've added it to my white list for now, and maybe it is something I should address with the developers of the app, I assume they are unaware they are sharing a domain someone sharing video adds.

Hi Zachary @zchrykng thank you for your observation.
To clarify, it doesn't matter if legit videos — however that's defined — are blocked.  If the domain vehicles their users, or other scam behavior, then it's blocked.
Sometimes sites use scam behavior as a prerequisite for providing service.  For example, we all could say "legit website x blocks me because of my ad blocker."
Our purpose is preventing scam behavior.

Acknowledged.
I will reach out to the developers of the app that is being impacted.
The videos that are being blocked aren’t ads and the site as a whole still functions, just the cdn they are using for their own videos appears to be black holed by this rule.

To clarify, it doesn't matter if legit videos — however that's defined — are blocked. If the domain vehicles their users, or other scam behavior, then it's blocked.

Just to clarify, by “legit” videos I mean videos that are the purpose of the site, not ads or other content. As far as I can tell, this app is just being caught up in a filter because of the CDN they are using. Which is a good argument for changing CDNs, I just wanted to make sure that was the case.

Sometimes sites use scam behavior as a prerequisite for providing service. For example, we all could say "legit website x blocks me because of my ad blocker."

Right, none of that is happening. The site loads fine, but when you attempt to play a video a request to that domain is blocked and it stays black. It doesn't prompt or anything. It isn’t showing any ads or similar before the video.
Is this domain used for tracking or something? Just trying to understand what/how I need to talk to them.
I can share the app/domain if that would help the discussion, was trying to keep it generic just for discussion.

@zchrykng jwpsrv.com seems like part of jwplayer.com, if you study jwplayer.com it says "Maximize Ad Revenue".

Thank @piengeng, good info. I know they aren’t trying to monetize this, might just be an issue with the configuration or possibly they are using it for analytics.

This is all-good Zachary @zchrykng.
Maybe listing videos-fms.jwpsrv.com is Type I error here... Is that specific domain a vector?  I'd love to know.

I'm not aware of specific apps that are serving ads using this package. The app I know that was being impacted definitely isn't serving ads this way. I'm not sure how to check the connections that iOS apps are making though. Only way I was able to identify the issue was looking at my pihole logs.

now i'm interested haha, Zachary, can you share what's the mentioned iOS app? and what sites are your visiting using the app? I don't own apple product, but recent apple's ad https://youtu.be/8w4qPUSG17Y is super interesting, maybe i'll find the same app for android and play around... no promises..

The jwpsrv block is too broad. Here it breaks this video. https://videos.space.com/m/is17aq8U/4-000-comets-discovered-by-sun-observatory-here-are-nasas-favorites?list=9wzCTV4g

The jwpsrv block is too broad. Here it breaks this video. https://videos.space.com/m/is17aq8U/4-000-comets-discovered-by-sun-observatory-here-are-nasas-favorites?list=9wzCTV4g

Steve @StevenBlack i can confirm that,maybe is for the best to remove it from here.

LE, I've tried whitelisting the two videos*.jwpsrv.com, the video is still blocked, this is some magic trick by jwplayer haha, my guess it's something else... the plot thickens

i think space.com is trying to monetize videos published by NASA https://www.nasa.gov/feature/goddard/2020/4000th-comet-discovered-by-esa-nasa-solar-observatory using jwplayer's ad solution, nevertheless, i respects Steven's work and his decision. pihole is super great, I'll keep videos-*.jwpsrv.com in my blacklist.

now i'm interested haha, Zachary, can you share what's the mentioned iOS app? and what sites are your visiting using the app? I don't own apple product, but recent apple's ad on tracking prevention on iOS at https://youtu.be/8w4qPUSG17Y is super interesting, maybe i'll find the same app for android and play around... no promises..

It is [Bible Stories for the Young]{https://apps.apple.com/us/app/bible-stories-for-the-young/id1508607899} android version is [here]{https://play.google.com/store/apps/details?id=com.jesuslifeapp.biblestories}
I was in contact with them last night and it appears that a support request to jwplayer changed the url they are hitting, but it is still blocked by another rule. The new url is videos-cloudflare.jwpsrv.com.

@piengeng  this is the whole link that it's blocked:
https://videos-fms.jwpsrv.com/0_60ac8636_0x9d2d82fe5de3bf5899607ab38f22876288546a7d/content/conversions/xTYS7F8k/videos/is17aq8U-27818552.mp4.m3u8
....whithout it,ain't no video

@dnmTX yup you're right, it might be too broad, as jwpsrv is serving both videos ads and videos created by others.
@StevenBlack sorry mate, you might have to make the tough decision.

Thanks everybody, so what's the consensus?  What's best?  Remove videos-fms.jwpsrv.com?

think is both videos-fms.jwpsrv.com and videos-cloudflare.jwpsrv.com
my concern for Steven is that later on, people will keep bugging you to remove it, lol, i think since i'm the only one wishing it to be blocked, so be it. My takeaway is this jwpsrv.com will block for life lol

@StevenBlack
Thanks everybody, so what's the consensus? What's best? Remove videos-fms.jwpsrv.com?

We block domains that do tracking and is adware. If we apply the same logic, we may not be able to see YouTube videos

Thanks everybody, so what's the consensus? What's best? Remove videos-fms.jwpsrv.com?

👍

after some soul-searching..
I'd like to stand my ground and explain why I think it's best to keep these 2 urls. I think it's a selfish and naive argument, and at the expense of everyone else's internet experience.
I think whoever that wish to see ads/videos hosted by videos-*.jwpsrv.com should whitelist these urls instead, this host file is created and maintained to block ads, NOT allow ads, if you wish to support these ads workaround by this company, you should manually do whitelisting. This list has blocked so many other ads companies especially competitors of jwplayer, so, why should this jwplayer deserves a pass? this might raise awareness amongst those that uses this hosts file
if every apps/sites that breaking because we stand our ground. it's wishful thinking, maybe they'll separate out legit vs ads videos, eventually, it might be those kind of social experiment like gamestop/bitcoin. How about we wait for a month or a year? see if there's any more feedbacks from at least some percentage out of 18k starred individuals?
unless some conspiracies like jwplayer pays microsoft/github to remove this repo... because it affects their bottomline.

you know I'm perfectly fine if jwpsrv.com reach out to Steven and offer him a couple of millions USD or few bitcoins just to remove these 2 urls. maybe also the very first original entry g.jwpsrv.com hehe

if every apps/sites that breaking because we stand our ground. it's wishful thinking, maybe they'll separate out legit vs ads videos, eventually, it might be those kind of social experiment like gamestop/bitcoin. How about we wait for a month or a year? see if there's any more feedbacks from at least some percentage out of 18k starred individuals?

My biggest objection to this take is that these are broad enough to be catching services that are doing literally zero advertising.
Concerned that someone less technical than us is going to run into videos they actually want to see being blocked and be unable to diagnose what is going on.

Dan @dnmTX my problem is, I don't use this video service so I can't judge. I also have limited bandwidth to devote to this particular issue.  I just want to know the final recommendation, one way or another.

Apparently the University I'm affiliated with uses this service to host lectures. Due to the videos-fms.jwpsrv.com entry on the blocklist, these video's fail to load when using a pihole. A workaround would be to add a whitelist entry for this domain but adding this domain to the blocklist is a bit of a sledgehammer approach. Like blocking YouTube because they also serve ads, DNS blocking might not be a suitable approach for domains which served mixed purposes.
Adding this information as an example of a legit use-case impacted by the filter.

Yes, I think that it should be removed. I don't agree with @piengeng's reasoning

this host file is created and maintained to block ads, NOT allow ads, if you wish to support these ads workaround by this company, you should manually do whitelisting.

As three different people in this thread have shown, the domain is not exclusively used for ads. It's a CDN for JWPlayer customers.
Another video that's broken: https://www.independent.co.uk/news/world/americas/us-politics/kevin-mccarthy-marjorie-taylor-greene-holocaust-b1853573.html

@rkuijt you're just the right person for me to ask this, out of curiosity, I'm wondering if jwpsrv.com is owned by jwplayer.com, the university is paying according to https://www.jwplayer.com/tos/ "License Scope" ?
I'm just curious about the definition of adware. reminds me of duck-typing.
if an ad company like JW Player create a video platform, licensed their product to promote video engagement some with ads some without, and serves ads based on the licensing model. so the philosophical question from me is, what is the ratio of ads to non-ads videos from single url, would be considered an adware for this video monetization platform?

I'm wondering if jwpsrv.com is owned by jwplayer.com

Yes
https://www.whois.com/whois/jwpsrv.com

Organization: LongTail Ad Solutions, Inc.

https://www.jwplayer.com/privacy/

JW Player (legally known as LongTail Ad Solutions, Inc.)

LongTail Ad Solutions. Inc. yeah i read it in wikipedia, turns out there's some history related to youtube as well, no wonder the mentions. Anyone propose youtube.com to this list before?

Thanks everyone for all your input.  I just merged #1665.
Ultimately Pull Requests speak 😄

@StevenBlack yup ultimately the person with the most to lose the advertising company, wins, the pull request is from people close to jwplayer.com .

@StevenBlack yup ultimately the entity with the most to lose, aka, the advertising company, wins, the pull request is from people close to jwplayer.com . cdn serves ads too..

Hey @piengeng, I think there is a fundamental misunderstanding of JW Player here. While some JW customers use the platform for serving ads, or monitoring their videos - the JW service provided via those domains are mostly for serving video content. Would you want to block all AWS domains? Probably not.
As it turns out, the majority of end-users who were affected by the addition of the two domains were students trying to watch education video content.
If you have any other concerns, please feel free to reach out to me - happy to have a conversation offline to address any concerns you have.

@SageBrushes If jwplayer customer is paying jwplayer, isn't it a better if you separate out CDN, with the resources and money, jwplayer cannot separate the CDN between university usage and your commercial usage?  I find it hard to believe of what you're saying, and having big corporation to decides how community adblocker works, and never contribute in discussion and directly say it's a bug and cheeky pull request stunt.
I pray that you compensate fairly to the owner of this project.

@piengeng what may seem like a simple feature request may actually be a fundamental change in a platform architecture. As you progress in your career you will be on the other side of this type of feature request conversation and laugh at his thread.

@SageBrushes well put, the most perfect ad platform that cannot be changed.

@piengeng I can't provide any insights regarding contractual agreements between the university and JW Player. But even if I could, such information would probably be prohibited for public disclosure.
Regardless, I'll happily provide a bit of context which might help to put your discontent into perspective.
According to some reputable sources [1], [2] it seems that Malware is defined as software with a malicious intent. E.g. software which is installed unknowingly and/or without consent and displays ads to the user. Like injecting advertisements in a browser.
From this perspective, software like freeware or websites which operate on ads do not fall into the adware category.
For example, YouTube shows advertisements in video's, that doesn't make it adware.
Then there's JW Player. As far as I have distilled from their website they provide businesses the service to manage content through their CDN. Allowing organizations to focus on their primary business instead of having to maintain a media player and distribution platform. In addition, they seem to offer a feature so their customers can monetize their own content by displaying ads.
Someone posted a link to a news website which is a perfectly valid use-case example. The news website serves their media but monetizes the content by displaying advertisements as the video plays. Kinda like YouTube does, but in this case, the news platform has full control over the advertisements (and probably keep a larger margin of profits).
Unfortunately blocking these services through DNS is not the solution as it renders the whole service unusable.
The purpose of lists like this one is to allow blocking domains which purely serve advertisements or are related to malicious practices. Services with legitimate purposes which serve advertisements from the same domain unfortunately circumvent this type of filtering.
There are other solutions like DOM filtering or dynamic content analysis which try to identify ads by other means and might be better suited for this kind of advertisement blocking.
Hopefully this provides you some perspective 😉
I'll refrain from further discussion on this topic here as the details are irrelevant to the actual Github issue.
[1] https://www.kaspersky.com/resource-center/threats/adware
[2] https://www.malwarebytes.com/adware/

please whitelist invol.co
source: https://www.youtube.com/watch?v=xpuEQog7Xr4


New Operation Example

This PR exists to provide a permanent home for a mostly clutter-free example of creating a simple new operation and evaluator in BitShares, namely the limit_order_update_operation. Please note that the changes in 8a82d92 are present as a necessary, but ancillary modification and are not typical of creating a new operation or evaluator.

Hi Nathan, JFYI, I'm going to continue to work on this at https://github.com/bitshares/bitshares-core/pull/2743.


Show motor state

"x Km/h" displayed as speed maybe, while engine is turned off.

This would require an edit on php's end or it would require a third Web call, lowering the update frequency.

Did the php part

Complete


Closes: #1

added new condition to check for the first character is alpha
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

changes are made to validation.py to add additional check


If delete city from the list. The city still show on the HomeBridge and HomeKit app

Describe The Bug:

If delete city from the list. The city still show on the HomeBridge and HomeKit app
To Reproduce:

Add more then one city to list (on my example it were three). After added to HomeKit app delete two from the list, save and restart of course.
Expected behavior:

Nothing Chang on the HomeKit app but the json file edit right
Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

{
"cities": "xxx",
"tg_api_id": "xxx",
"tg_api_hash": "xxx",
"rockets_alerts_channel": "https://t.me/CumtaAlertsChannel",
"terror_alerts_channel": "https://t.me/CumtaAlerts2Channel",
"debug": false,
"timeout": 120,
"_bridge": {
"username": "xxx",
"port": 37770
},
"platform": "RedAlertViaKumta"
}
Screenshots:

Environment:

Plugin Version: 2.5.1
Homebridge Version:  1.8.4
Node.js Version:  	v20.18.0
NPM Version:  10.8.2
Operating System:  raspbian

![image](https://github.com/user-attachments/assets/2150ed3a-8b25-4d05-aa0d-d5416eb57e26)

Hi,
Can you please try to delete the old city accessory by doing the following steps:

Login to Homebridge.
Three Dots on top right.
Homebridge Settings.
Scroll down and near the bottom is "Managed Cached Accessories"
Click on the box to the right of "Remove Single Cached Accessory"
A list will pop up listing each accessory. Click on the red trash can.

Hi,
I received alerts from another city and couldn't delete them, so I removed the plugin and installed it again. However, I will clear the cache soon, as I need to add another city for a few days (after I delete the city I will check this solution)
Thanks!

Hi,
I added a new city, and after deleting it, it still shows up in the list. When I use "Remove Single Cached Accessory," it does remove the city, but I'm unsure if this action fully stops it from working for that city.
I have a suggestion: instead of showing two accessories per city, could we configure it to display just one? This would simplify the automations, so I wouldn’t have to create them twice. Additionally, in HomeKit, I can only see the city's name without any indication of the alert or terror subject.
Thanks!


Powertoys - FancyZones - update 0.31

Changes to the Powertoys FancyZones page to reflect the new FancyZones Editor UI in the 0.31 release.
New images and minor changes to the descriptions.

@enricogior : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dedavis6797
I didn't realize you already made some updates for FancyZones.
Feel free to review this PR in case there is anything that is useful for your PR, or close it if you already covered all the basics.
Thanks.

Thanks @enricogior, I just incorporated your FancyZones updates to the PR I made. I don't have permissions to close this PR, so feel free to close it when you get a chance.

@dedavis6797
done. Thanks.


add a variable to customize repo directory

I'm using fossil-scm for most of my personal work, I need to be able to customize what is a 'repo'. Hence I added a variable to allow customization.
Could you please consider merging? Thanks!

Okay, I merged. Thanks!
BTW, has every Fossil project a _FOSSIL_ file in its root directory? If so, we should hardcode it.

@mhinz : Sorry for being late to come back to your question. Fossil project use _FOSSIL_ on windows, and .fslckout on Linux.
According to https://www.fossil-scm.org/index.html/doc/trunk/www/concepts.wiki

A Fossil source tree is identified by a file named "_FOSSIL_" (or ".fslckout", but this article will always use the name "_FOSSIL_") ...

Thanks for integrating the change!

If you think both, _FOSSIL_ and _fslckout, should be added by default, feel free to open a new PR for it.
Otherwise, thanks for your contribution so far!


Download links not working

Hi. Your download links for the content you have on dropbox aren't working. Is there any way you could post a mirror link? Thanks.

Yes please!  The download link to the standalone package gives a DropBox Error (429)

This account's public links are generating too much traffic and have been temporarily disabled!

So does the download for the Dependencies.

Hi , I cannot open the Dependecies,do you have the link?Thanks.

So do I.


Unable to click on repository links on iOS 17 and MacOS Safari 17.4.1

I first browsed the site on my iPhone and thought there weren't any links. Then, I proceeded to open the same site on my macbook from Safari. When I looked at this repo's code I finally noticed there was already a link. So, I tried opening the site in a Chromium browser and it works as expected.
The anchor tag exists even in Safari ~so I'm not sure why the element is not recognised as a link and is not clickable.~ but something's wrong with Safari's CSS so the table head is blocking the interaction with the anchor tag.
In the image below, I'm hovering over the table body row with the dev tool inspector but it selects the table head instead.

EDIT: The issue seems to stem from these two absolute positioned content blocking the link interaction
https://github.com/colinlienard/githundred/blob/92abe5e12c1f1fea411b202a1e3fb5950e96e955/pages/index.vue#L128
https://github.com/colinlienard/githundred/blob/92abe5e12c1f1fea411b202a1e3fb5950e96e955/pages/index.vue#L145-L152

I hate safari 😅
Thanks for pointing this out, it should be fixed now


Create collection for Sanborn Maps?

Should we create a collection for Sanborn Fire Insurance maps? They are a cohesive group of items that would be handy to select as a whole.

Done.


kindex: Add Fetch method to the *Compilation type. [phab:D57]

Created by fromberger at 2015-02-13 22:31:40:
This permits a kindex file to be used as a source of data for the indexer more
easily.  Also, since it's convenient, I added a FileData helper function; this
permits us to get rid of the "local" package which isn't otherwise used.

schroederc commented inline (context lost during migration) at 2015-02-13 23:41:05:
fp == path && (digest == "" || digest == fd)

schroederc commented inline (context lost during migration) at 2015-02-13 23:41:05:
Means the same but digest != "" && digest == fd is a little clearer based on the method comment.

schroederc wrote at 2015-02-13 23:41:05:
From the description: I thought we already got rid of the local package.

fromberger wrote at 2015-02-13 23:45:12:

Simplify some conditionals to be more readable.

fromberger wrote at 2015-02-13 23:45:16:
Good ideas, thanks—done.

schroederc commented inline (context lost during migration) at 2015-02-13 23:51:06:
Is this used anywhere now?

fromberger commented inline (context lost during migration) at 2015-02-13 23:58:24:
Not in the current repo, outside the test. This was the "interesting" piece of the local package, and I've found it convenient for building repro cases, but it doesn't strictly have to live here if it offends your sensibilities.

schroederc accepted this revision at 2015-02-13 23:59:14

fromberger closed via commit 3516d9e62b2640a9d0214bb615513898a4dc7784 at 2015-02-14 00:01:58

fromberger closed via commit 971ee83f9c01ea4a65058a3c0ec5fbe91be56ff1 at 2015-02-14 00:01:58

commit 01e53719be08d57720ba730d2406d2780ce1c3a4


Image Slicer ability to slice in arbitrary orientations

This PR pimps the Slicer even more, to be able to slice images in one orientation with slices in another one.
Let's say you have an image in RAS- orientation, well you want I->S slices with x=A->P and y=L->R, you'd do:
for slice2d in Slicer(img, "ALI"):
 print(slice2d)

If you wanted S->I slices with x=A->P and y=L->R, you'd do:
for slice2d in Slicer(img, "ALS"):
 print(slice2d)

With this, a lot of code can be simplified (qc slice, etc.)
Note: depends on #1948 ; just look at the last commit to review, and don't merge until the dependency is.

(included in #1948)


Change front page publication example

Now that the JBrowse tracks are easy to select, is it worth changing the front page publication example to a publication with tracks and annotations?  eg. PMID:25908789
https://www.pombase.org/reference/PMID:25908789

Lovely, this is a great example!

I've change the example publication.


Remove support for brokerList which is deprecated in v1.3 (Kafka)

Remove support for brokerList which is deprecated in v1.3.
Follow-up for https://github.com/kedacore/keda/issues/608 & https://github.com/kedacore/keda/pull/621

Fixed in #882


Gather the profile-pic-related settings together.

Gather the Beta Settings regarding profile picture together.  Set whether to show the profile pic and what profile pic to show near one another in the settings UI.
Before:

After:

Nice! Good idea. :+1:

Since we are in here, can we give notification demo some love to be like the others?
:+1:  either way

Also, fun fact. You can change local storage values in chrome developer

Yes wrt the notification demo card love, pursuing that in a separate changeset.  I hear @vertein likes small changesets, after all.


Last build break notification

Hello,
I used Drone plugin for sending Matrix notifications but it's breaking since last build when this pull request "(maint) move to harness.drone.io" is merged.
My configuration:
- name: notify
  image: plugins/matrix
  settings:
    homeserver: https://***.***
    roomid: "***:***.***"
    userid: "***:***.***"
    accesstoken:
      from_secret: MATRIX_ACCESSTOKEN
  when:
    status: [ failure ]

the error:
time="2023-01-16T13:37:20Z" level=error msg="execution failed: failed to authenticate user: contents=[123 34 101 114 114 99 111 100 ...] msg=Failed to POST JSON to /_matrix/client/r0/login code=400 wrapped=M_INVALID_PARAM: Bad parameter: password"

This error is print from here but I don't understand normally, UserID and AccessToken are not empty...
I found a solution with specified sha256 image but I thinks it's not a good solution ;) :
image: plugins/matrix@sha256:f1affb31b0c86963c97c6f976fa0dcb3cc84272057fd8558d609d28b3064bd7f

I'm alone?
PS: Akismet hidden my post on https://community.harness.io/ because I would like have more than 2 links in my post... 😒

I get the messages on Matrix, but the body seems to be messed up a bit :upside_down_face:
Build [/#]() () by

Same as @apinter ...
Guys, can you please fix this already?

I took the time to walk the code on this, and discovered it simply doesn't work as advertised, in fact, this NEVER worked. The Plugin struct defined doesn't export it's members (see below) meaning the template will never find the values of p when the template is applied.

This plugin is flawed.

Since this issue seems stalled, I made my own Matrixchat notification drone.io plugin:
https://github.com/SpotlightKid/drone-matrixchat-notify


Unexpected behavior on ion-input

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.9.2
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
I have a reactive form with an ion-input in an ion-item. The first time I touch the input and then touch outside, the ‘ng-untouched’ on the ion-item still exists on the ion-item. The second time I touch the input, it changes to ‘ng-touched’.
Expected behavior:
When I firstly touch input the 'ng-untouched' in the corresponding ion-item should change to 'ng-touched'.
Steps to reproduce:
https://stackblitz.com/edit/ionic-wqatxh
I added a required Validator to the field to show the behavior.

Click inside the input field (the border is blue)
Click outside the input field (the border is grey | should be red)
Click inside the input field (the border is blue)
Click outside the input field (the border is red)

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (/usr/local/lib/node_modules)

    @ionic/cli-utils  : 1.18.0
    ionic (Ionic CLI) : 3.18.0

global packages:

    cordova (Cordova CLI) : 8.0.0

local packages:

    @ionic/app-scripts : 3.1.0
    Cordova Platforms  : android 6.3.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v7.4.0
    npm               : 5.5.1
    OS                : Linux 4.4

Environment Variables:

    ANDROID_HOME : /home/abrokle/Apps/android-sdk

Misc:

    backend : pro

I have the same problem