[ValueCard] Error & empty state for cards

Is this an extension to an existing component, pattern, or a brand new asset?
What is the rationale for this contribution.
We need a pattern to represent, in a card (or other places), that there is a data collection error state.  In Health, the scheduled data collection task can error for various reasons.  We want an indicator that allows to user to click to see more information about the source of the error.
Detail the intended behavior
Need a state that allows the user to see that there was an error in the data.  This is not the same as missing data.
Not clear what the difference is between Null data and No data, so providing a single "no data" state for now.
Value card

No data state
Error state

Double dash where result would have been.
No data icon is displayed, left-aligned.
No data label is displayed to the right of the icon. It could vary based on the nature of the no data problem.
No data description is displayed in the card if there's room.
Icon, label, and description are provided by app.
User can click / hover on icon or message to see a tooltip with additional information.  Tooltip contains anything not displayed in the card and any additional content provided by the application. (Question: should it include the icon, label and description regardless of what's show in the card?)
User can click Learn more to get more information about the problem, if available.

Content adaptations for small cards

If it's an extra small card (or too small to show the full label), label does not display (or should it just be truncated?)
If it's an extra small card, the description only appears in the tooltip.

Table card
TBD
Timeline card
TBD
Donut card
TBD
Being worked on in APM https://github.ibm.com/asset-performance/apm-design/issues/438
Inspiration from other products
(Optional - remove this is you don't have any)
@KarenGski

We did some review with Luke in asset-performance/apm-design#438 and settled on the following design for value cards.

Open questions:

Should the tooltip always contain all information? Or only the things that don't fit in the card?
If the label doesn't fit, should it truncate or disappear?

Charts will just follow Carbon charting standards (I think).
@lukefirth can you share your thoughts on the open questions and then confirm if good to go?

@lukefirth

Open questions:
Should the tooltip always contain all information? Or only the things that don't fit in the card?
I'd relent to ID on this, but my recommendation would be just the info not shown. (Although I'm easy on this because the tooltip the info when open).
If the label doesn't fit, should it truncate or disappear?
Labels as in 'No data available' and 'data error' and/or their text below?
I think @msperli s proposal works with just the icon and the tooltip suffices.
Good to go from my perspective.

@KarenGski

@lukefirth Claudia is working on the content question of what goes in/out of the tooltip. We'll go with whatever the official Content recommendation is.
Just the icon works for me.
@msperli We're good to go. You can close the APM issue for this.
@smithjor FYI
@rdconner This is approved so I think we can move out of design and into dev backlog.

@lukefirth now that the value card is not setting an xsmall card do we apply the styles of the xsmall based off card size?

@davidicus great catch!
Internal ref link: https://github.ibm.com/wiotp/monitoring-dashboard/issues/774
In short, recently there has been a small change in card sizes, and more importantly for this I believe - the naming convention of card sizes has been updated and simplified.
In the past we have had (in terms of sizes):

XSmall
XSmall wide
Small
Medium
Wide
Large
Tall
Xlarge

The change in naming convention is to align the sizes of 'small', 'medium' and 'large' to the heights of the cards, and then make the varying width versions modifiers to those sizes resulting in:

Small
Medium
Large

Each with a 'default' a 'wide' and a 'thin variant which will control how many columns it takes up.
The upshot:
In this case, applying a certain style to what was originally named the 'xSmall' size, would now map to the new 'Small' size.
@scottdickerson FYI and to fact check me - we should do a quick check on any other knock-on issues of the recent card size changes like this one.

@davidicus great catch!
Internal ref link: https://github.ibm.com/wiotp/monitoring-dashboard/issues/774
In short, recently there has been a small change in card sizes, and more importantly for this I believe - the naming convention of card sizes has been updated and simplified.
In the past we have had (in terms of sizes):

XSmall
XSmall wide
Small
Medium
Wide
Large
Tall
Xlarge

The change in naming convention is to align the sizes of 'small', 'medium' and 'large' to the heights of the cards, and then make the varying width versions modifiers to those sizes resulting in:

Small, Small wide
Medium, Medium narrow, Medium wide
Large, Large narrow, Large wide

Observe how each base size also have with a 'default' a 'wide' and a 'narrow' sibling.
The upshot:
In this case, applying a certain style to what was originally named the 'xSmall' size, would now map to the new 'Small' size.
@scottdickerson FYI and to fact check me - we should do a quick check on any other knock-on issues of the recent card size changes like this one.

Hi @lukefirth
so in the case of this "Error / Empty state"  issue. I initially implemented the minimalistic view (see image below) for the XSMALL card, but when should it be triggered now? For SMALL cards or for any measured width below a certain value?

Hey @bjornalm !
I think that works, I'd expect the minimalistic version shown to be applied to the small, and medium narrow card sizes due to both of them having the same size (in respect to width), so that could be framed as under a certain value as a generic rule.
As long as that value where the switch happens sits between the normal ranges of width between small/medium narrow and the larger ones.

@lukefirth
Ok, thanks. If small and medium narrow cards are the target for the minimalistic view then using those sizes in the condition would be the easiest solution.

:tada: This issue has been resolved in version 2.48.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


menu (side-nav) doesn't work in FF

The components side-nav's categories is empty in firefox.
It is built from a nested repeat.for:

          ${ cat.title }

              ${ ctrl.title }

The inner
 is empty:

      Javascript

In Chrome and IE, the content of the inner repeat.for is injected where  is displayed, as expected.

The issue seems to be with: if.bind="!!ctrl.link".
When deleting that part, it works in FF.

Confirmed..
Here's a plunk: http://plnkr.co/edit/CM3oX9r7g3gJGp3hePIQ?p=preview
The result in Chrome:

The result in FF:

It's not an Aurelia problem.
https://github.com/aurelia/templating-resources/issues/111#issuecomment-171031562
Basically

You can't place two TemplateControllers on the same element. In this case if and repeat. They are both trying to control the creation of the th. It works in Chrome...accidentally...somehow.


Add serde default for exposed ports

When using deserialize_with, Option no longer tells deserializer that field might not exist.
Therefore in order to correctly deserialize Config without exposed_ports field, we need to add serde default for this field manually.
This should fix #50.

Codecov Report

Merging #51 (593bb56) into main (cb594d6) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   28.29%   28.20%   -0.10%
==========================================
  Files          20       20
  Lines        1396     1397       +1
  Branches      729      722       -7
==========================================
- Hits          395      394       -1
- Misses        370      379       +9
+ Partials      631      624       -7

Looks good! @utam0k @saschagrunert Please merge 😉


Fix for docker ps hang after docker restart with liverestore - 1.13.1

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>- What I did
Changed the handling of FIFO's when --live-restore is in play.  Without this change the FIFO's were not cleared on restart and the docker operation hung waiting for them to reopen and they never would.  This PR is for Docker-1.13.1.  #310 fixed the same issue in RHEL-1.13.1
- How I did it
vi is my friend
- How to verify it
See bugzilla for test description.  To duplicate test one must 'setenforce 0' before running the script, that is not noted in the BZ.  (https://bugzilla.redhat.com/show_bug.cgi?id=1566439)
- Description for the changelog
Fix for docker hang after restart when live-restore is configured
- A picture of a cute animal (not mandatory but encouraged)

LGTM


Provide official docker image for  RDF4J Server and Workbench

A stable, project-supported docker image for  RDF4J Server and Workbench would ease quick deployments in many scenarios (e.g. sandbox/testing environments).
https://hub.docker.com/r/yyz1989/rdf4j/ could provide a useful baseline.

I've also created a docker file, should this be part of the rdf4j main project (or in a separate git repo, and/or on docker hub ? )

Can probably be closed, as it is dealt with in the rdf4j-tools repo


feat: improve SSE buffering between argo server and client

Add Header "X-Accel-Buffering: no" to argo server responses to improve buffering between argo server and client
I tried to reuse the options of gwmux instead of copy-pasting them. Maybe you have an idea to make this code DRYier?

Fixes #11848
Motivation
Users that uses argo-workflows behind a Nginx Ingress Controller may be unable to access pages that uses SSE. This is because by default Nginx buffers the requests.
Some users cannot disable proxy_buffering, or for some users this does not work at all. Let's ease the deployment of argo-workflows for these users by adding the header X-Accel-Buffering.
Verification
Manually deployed on a Kubernetes cluster. Without the change, SSE does not work. With, it works.

Hey @agilgur5, some test are failing, but I'm struggling to find why. Could you review this PR now please ?

Hey @agilgur5, could you suggest a way I can test that the UI returns the Header in the stream reponses?

So sorry, I'm going through old PRs and I see that unfortunately this one has been forgotten. I will try to review it soon.
Argo Workflows needs more people approving PRs unfortunately. If your company is by chance interested, I am gauging interest in this idea: https://github.com/argoproj/argo-workflows/issues/12229

Hello !
Any update about this PR ?
regards


[stable/pomerium] Chart updates for pomerium v0.1.0

What this PR does / why we need it:
This bumps the app version to support the latest release of Pomerium, and expose new metrics functionality.  Examples and documentation included.
/cc @desimone
Related Issues:
pomerium/pomerium#214
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

@travisgroth I see you haven't included all the latest changes that were merged in pomerium/pomerium-helm, is that on purpose? In particular there are some that are important I think about config checksums.

@victornoel Not intentional, no.  I'll look at updating both of them to be consistent.

/retest

/retest

/test pull-charts-e2e

/lgtm


Define a mapping between the RedCap and ElabFTW survey definition

The csv survey definition based on the RedCap structure is very extensive, so only a subset of the csv columns should be mandatory to create an ElabFTW survey. This mapping should be defined in a dedicated file so it can be customized if needed. A good format to define this mapping would be json. Add documentation of the mapping. Note: In case of functionality missing on the ElabFTW side, report this as an issue to be handled by ElabFTW.

Here is a mapping representing the difference between csv and json. The goal is to allow a better generation of json files based on csv

@killianrochet For the points in your table that can not be translated to ELab, can you check if a corresponding issue / PR exists already for ElabFTW? If not we should open an issue to start a discussion on potentially extending ElabFTW.

https://github.com/elabftw/elabftw/issues/3703


Initial implementation of Inference client

What this PR does / why we need it:
Refer #3270
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[x] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[x] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Initial implementation of Inference client

@sivanantha321 Can you help resolve the conflicts ? thanks

/rerun-all

/rerun-all

@sivanantha321 Can you help resolve the conflict? a few small comments otherwise good to merge

/lgtm
/approve


Remove doc/tags from repository

I sent a pull request to ignore doc/tags a while back, but I didn't realize, you also need to remove it from the repo as well, since this is an automatically generated file

My bad. Thanks.


don't assume all gulp enabled projects have a gulp watch command

Aurelia libraries do not have a gulp watch task, so monterey needs to check if it exists before proposing to run it after scaffolding such project via the github template

This is a tricky one. Gulp demands that everything is done via the locally installed gulp (in the node_modules of the project directory, and not gulp installed in the global node_modules folder). This means that we need to npm install before we can check which gulp tasks are available.

Here we do not know which gulp tasks the project has, not until "npm install" has completed. So we can't show a list of possible tasks either. But I do not think it is a big deal yet, considering:

the user can uncheck "gulp watch"
monterey knows that it does not exist when it's about to start the task, so it does nothing and continue:

I do not see what more could be done without having the will need gulp watch / will not need gulp watch declaration in package.json :smile:

good idea, the package.json standard has a start script, like the webpack skeleton uses here. But this is not used in the majority of projects (for example, the skeleton-esnext).

Pioneers always suffer from lack of good standards. As we plan to support projects other than Aurelia-CLI or Aurelia navigation skeletons based, we cannot gain much even if Rob would put the needed "metadata" into these package.json files.
We could certainly make Monterey to add such data once it has correctly recognized the project type (app or lib), so all Monterey created app would be good to go later.

Closing this for now, as I agree with:

I do not see what more could be done without having the will need gulp watch / will not need gulp watch (or app / lib) declaration in package.json


Decorator csrf_exempt won't work with CMS urls

Hi,
at some point I include the cms urls like this
url(r'^', include('cms.urls'))

and I have a view:
@csrf_exempt
def postFromExternal(request):
    pass

This view was included in the cms and reachable. In my case this was the callback url from a payment provider, which would send confirmation data via POST. The problem is that it has no CSRF token (and should not have?!), but the CSRF cookie from the client is set and also submitted. So the check from the CSRF middleware will fail.
As far as I can see from the debugger, it seems that the cms also adds a decorator to the already decorated postFromExternal, so it is double-wrapped. This leads to the problem that the CSRF middleware won't see the csrf_exempt = True, as this is only set for the inner wrapped view.
I was able to do a workaround by adding the url right before including the cms urls:
url(r'^url/to/postFromExternal$', postFromExternal, name="postFromExternal"),
url(r'^', include('cms.urls')),

This works, but doesn't feel "clean" to me. So maybe the CMS wrapper could take a look at certain attributes of the wrapped view and copy them?

Fixed by #5385


Eventual consistency with writing metric descriptors

It's hard to say if this is an issue with the API or with the client library.  In the sample tests, we're experiencing eventual consistency with writing metric descriptors.  See the following in the tests:
it('should create a metric descriptors', async () => {
    const output = await exec(`${cmd} create`);
    assert.match(output, /Created custom Metric/);
    assert.match(output, new RegExp(`Type: ${customMetricId}`));
  });

  it('should list metric descriptors, including the new custom one', async () => {

    await retry(
      async () => {
        const output = await exec(`${cmd} list`);
        assert.match(output, new RegExp(customMetricId));
        assert.match(output, new RegExp(computeMetricId));
      },
      {
        retries: 10,
        onFailedAttempt: () => console.warn('Read failed, retrying...')
      }
    );
  });

With exponential backoff, it's not uncommon for this to retry 6-7 times before finally being able to do the read.

Talked to folks working on the upstream API, and can confirm that this is expected behavior; their feeling is it stinks for tests, but it shouldn't bite customers too often in a day to day situation.
The advice was not to document the method, as behavior is potentially subject to change in the future.


Distributed tracing raise TypeError

Description
When I'm trying to enable distributed tracing
  distributed_tracing:
    enabled: true

and sending a request to grape endpoint newrelic_rpm is raising
[2021-04-13 13:47:55 +0200 Pawels-MBP (50219)] WARN : TypeError: no implicit conversion of nil into String
[2021-04-13 13:47:56 +0200 Pawels-MBP (50219)] WARN : Failed to create trace context payload

Disabling distributed tracing makes the error disappear
Expected Behavior
distributed_tracing should not cause TypeError.
Troubleshooting
I tried to debug newrelic_rpm and I found that it's failing here
https://github.com/newrelic/newrelic-ruby-agent/blob/dev/lib/new_relic/agent/distributed_tracing/trace_context_payload.rb#L115
[1] pry(#<NewRelic::Agent::TraceContextPayload>)> parent_type_id
=> 0
[2] pry(#<NewRelic::Agent::TraceContextPayload>)> parent_account_id
=> nil
[3] pry(#<NewRelic::Agent::TraceContextPayload>)> parent_app_id
=> nil
[4] pry(#<NewRelic::Agent::TraceContextPayload>)> (id || NewRelic::EMPTY_STR)
=> "3da91fe34363e02d"
[5] pry(#<NewRelic::Agent::TraceContextPayload>)> (transaction_id || NewRelic::EMPTY_STR)
=> "c222ba904bcb934f"
[6] pry(#<NewRelic::Agent::TraceContextPayload>)> (sampled ? TRUE_CHAR : FALSE_CHAR)
=> "1"
[7] pry(#<NewRelic::Agent::TraceContextPayload>)> sprintf("%.6f", priority)
=> "1.405902"
[8] pry(#<NewRelic::Agent::TraceContextPayload>)> timestamp.to_s
=> "1618315522770"

basically for whatever reason, parent_account_id is nil  so this line fails with
[10] pry(#<NewRelic::Agent::TraceContextPayload>)> result << DELIMITER << parent_account_id
TypeError: no implicit conversion of nil into String

I'm not sure about newrelic internals but I'm guessing the real issue is somewhere else and this is just a side effect of it. Maybe some gems I'm using are outdated and not supported by newrelic anymore?
Steps to Reproduce
It's a company application but I think I could give you private access to check it yourself.
Your Environment
Gemfile.lock: https://gist.github.com/deskcoder/6ce507cb58c8bfb3392a81d55b671e48
newrelic_agent.log: https://gist.github.com/deskcoder/ef72112ac555064f707b2f9d4713f5a3
ruby: 2.6.5p114 (2019-10-01 revision 67812) [x86_64-darwin18]
newrelic account: 3137787
newrelic application: 178347404

Hello, @deskcoder
Thank you for bringing this to our attention. Just to confirm, this error only happens near the beginning of the start up for the application, correct?
So, the parent_account_id is a value the agent receives in the response when first connecting to the new relic servers. The agent is supposed to wait to do anything until we receive that first response from the new relic servers, since it sends back data the agent needs, including things like server side configs, agent run token, etc. So basically what's happening here here is that the agent is trying to record this distributed tracing data before the agent is supposed to.
This doesn't lead to any data loss at least, since I believe the correct behavior for the agent is to simply not record data before the agent finishes startup. Once the agent does receive that response from the servers, this error will not happen the next time it tries to create a trace context payload.
So this does appear to be a bug in the agent, but it shouldn't be impacting the application, does that seem to match what you are experiencing? Are you able to see any data reporting on the UI?


Lower googleauth gemspec version

Lower the required version of googleauth gem.
This is because fog-google requires a lower version of the gem

sorry, pls ignore this, meant to open on my fork first before suggests a change.


www/nginx: Add ACME proxy support

It is kind of bothersome to configure ACME challenge forwarding to internal servers as to the NGINX configuration becomes quite crowded but such simple rules, especially as you cannot recycle a single location definition for multiple upstream servers.
I suggest to extend the existing LetsEncrypt support with an additional local PHP routing script:

If no local file for ACME challange was found in /var/etc/acme-client/challenges, forward HTTP request to a local PHP script.

The PHP script should resolve the requested hostname from the HTTP header using the local resolver settings.

It is assumed that the firewall would be able to resolve it to a network internal IP address (IPv4 or IPv6, both may also be public IPs).

The firewall shall forward the ACME request to that internal server on port 80 and enforcing the correct URI path. Don't think the DNS lookup needs to be done explicitly, it may just be performed by the firewall. The only thing to consider is avoiding a loop, e.g. the script shall ensure it is not connecting back to the firewall on port 80.

I imagine this would simplify the ADME challenge handling for internal servers a lot as it is quite normal that DNS validation cannot be used or is even not supported by some blackboxes (e.g. Proxmox VMM).

you should be able to disable intercepting ACME challenges. Then the request is forwarded normally to the upstream as specified. It is a checkbox in the HTTP block.

You didn't get my point right.
What I want is an easy proxy method to forward ACME challenges to hosts in my internal network w/o a need to setup a dedicated HTTP proxy for each of those. I think this could be achieved way easier as the firewall is able to lookup my internal hosts dynamically from the DNS and could then decide to forward that request. It won't be possible using native NGINX method but using a PHP script that in turn would forward the request and send back the response via NGINX to the original LetsEncrypt host.

It's untested with any reverse proxy yet, but this is the first version of a corresponding PHP script to be used for such scenario:
https://github.com/jpawlowski/acme_proxy.php

Happy to confirm the script is now working as expected and could already be used by this custom location in HTTP server "default_server:80":

Would love to see that functionality fully integrated to OPNsense.

@jpawlowski the router script works slightly different than internal code because the internal ones do not get the standard parameters. Instead they get some special config properties they need to access the entries in the configuration. For example see: https://github.com/opnsense/plugins/blob/master/www/nginx/src/opnsense/scripts/nginx/ngx_auth.php
Your script by the way has a security impact because it allows using the host as a proxy to access content from the internet (not limited). Some headers are not passed because they are rewritten by nginx anyway.
I don't think including this is a good idea anyway, The router script may be the ideal place for it (nothing that needs to be supported by the default plugin).

@fabianfrz what do you mean by "the router script", can you be more specific and post a reference to it? The acme_proxy.php script does not require any special properties (and doesn't get those mentioned in the ngx_auth.php script anyway, so I don't get your point here).

Your script by the way has a security impact because it allows using the host as a proxy to access content from the internet (not limited).

This is a PoC so for sure it can be improved. Currently www/nginx does not allow custom parameters to be added, otherwise a restricted domain list could easily be handed over to acme_proxy.php already today using fastcgi_param. This is already possible for other settings like changing destination port (acme_dst_port), enable TLS (acme_tls) or disable host validation (acme_tls_verify).

The router script may be the ideal place for it (nothing that needs to be supported by the default plugin).

I don't understand the meaning of this sentence. Besides "what is the router script?" I also want to ask what the "default plugin" is...

The option router script is exactly what you want. It means that all requests are routed to this script (advanced option, enter the full path relative to the document root):
https://github.com/opnsense/plugins/blob/master/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/location.conf#L78
It looks almost like URL rewriting and just pretty standard. You get all requests matching the passed to the script where you can handle them.

Thank you. As you can see from the screenshot I posted above, I am already using that option to run my acme_proxy.php script.
The point is that I think it could be an improvement to directly integrate that script into the www/nginx package as configuration options would be more user friendly (see your comment above about domain restriction) and I am probably not the only person requiring to forward ACME requests to the internal network.
Also, the script is supposed to be used in the default_server in port 80 which is something completely unsupported by www/nginx today. This is what you had confirmed yesterday.

@jpawlowski the listen thing is a bug in the validation and I'll look for fixing that. By the default the field should only allow numeric ports and some special ones (ssh, http) which will also cause some trouble in most plugins because they rely on a numeric input.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

I still like my idea to somehow help with automatic backwards routing of ACME challenge responses. Apparently others do like to configure this for each and every internal server just by themselves... 🙄


feat: json reporter

Adds the ability to define (in config) reporters. Adds a JSON reporter to write lint results to disk in JSON format,

Sorry mistake.


Add loop toggle to Youtube video block

This PR adds a loop toggle button to the Youtube Video Block in the Comet Admin. Refer to the Youtube Docs for a list of embed url params: https://developers.google.com/youtube/player_parameters
Screenshot

Sorry, one last thing: Could you please add a changeset for this change? See contributing docs


[Doc] generate doc set for 2.8.2

Currently, we have doc requirements for 2.8.2 (for example, https://github.com/apache/pulsar/pull/11739). Consequently, I generate the doc set for 2.8.2.
I'll update the following files after 2.8.2 is released.

release.json
versions.json

@eolivelli @Jennifer88huang @Huanli-Meng Could you please help review this PR? Thanks


Work around spelling exceptions added to release-next

The problem
Whenever we run mdspell, we first clone every branch (release-1.3, release-1.4, release-next...) into the content/en/docs/ folder.
When words are added to the release-next branch and aren't on master yet, master fails due to the yet-to-be-ignored words are unknown to mdspell.
As an example, the PR https://github.com/cert-manager/website/pull/570 added the new spellings "andreas-p" and "renewBefore" to the release-next branch. After the merge, all builds on master started failing since "andreas-p" and "renewBefore" were not present on the master branch's .spelling file.
Idea 1 (this PR)
Ignore spelling of release-next. PRs merged to release-next already have no spelling mistake, so we don't really need to enforce the spelling again.
!content/en/next-docs/**/*.md

Idea 2
Use mdspell's --target-relative which requires copying the .spelling file from the release-next branch and copy it into content/en/next-docs. After looking at verify-lint, one way could be to have a new flag to hugo-multiversion, e.g.,
 ./scripts/bin/multiversion" \
 	--repo-url https://github.com/cert-manager/website.git \
 	--repo-content-dir content/en/docs \
+ 	--repo-content-extra-file .spelling \
 	--output-dir "${REPO_ROOT}/content/en" \
 	--branches v0.13-docs=release-0.13 \
 	--branches v0.12-docs=release-0.12 \
 	--branches next-docs=release-next

Not sure what is the right solution 😅
cc @irbekrm @munnerz

Looks good to me, I've added a small nit, but do unhold if you'd rather merge.
/hold
/lgtm

Looks good to me! Thanks for fixing this.
/hold cancel
/lgtm


incompatibility with additionnals plugin

Try to migrate your plugin :
For the first rake migration, I change Gemfile
gem 'deface', '>= 1.1.0' to
gem 'deface', '>= 0'
because error with gem version
Then error on log trace here :
bash-4.2# rake redmine:plugins:migrate RAILS_ENV=production --trace
** Invoke redmine:plugins:migrate (first_time)
** Invoke environment (first_time)
** Execute environment
rake aborted!
additionals plugin cannot be used with redmine_base_deface plugin'.
/opt/bitnami/apps/redmine/htdocs/plugins/additionals/lib/additionals.rb:74:in block in incompatible_plugins' /opt/bitnami/apps/redmine/htdocs/plugins/additionals/lib/additionals.rb:73:in each'
/opt/bitnami/apps/redmine/htdocs/plugins/additionals/lib/additionals.rb:73:in incompatible_plugins' /opt/bitnami/apps/redmine/htdocs/plugins/additionals/lib/additionals.rb:7:in setup'
/opt/bitnami/apps/redmine/htdocs/plugins/additionals/init.rb:43:in block in <top (required)>' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:446:in instance_exec'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:446:in block in make_lambda' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:192:in block in simple'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:504:in block in call' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:504:in each'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:504:in call' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:92:in run_callbacks'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:778:in _run_prepare_callbacks' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:81:in run_callbacks'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/actionpack-4.2.8/lib/action_dispatch/middleware/reloader.rb:83:in prepare!' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/actionpack-4.2.8/lib/action_dispatch/middleware/reloader.rb:55:in prepare!'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/application/finisher.rb:50:in block in <module:Finisher>' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/initializable.rb:30:in instance_exec'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/initializable.rb:30:in run' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/initializable.rb:55:in block in run_initializers'
/opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:228:in block in tsort_each' /opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:350:in block (2 levels) in each_strongly_connected_component'
/opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:431:in each_strongly_connected_component_from' /opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:349:in block in each_strongly_connected_component'
/opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:347:in each' /opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:347:in call'
/opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:347:in each_strongly_connected_component' /opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:226:in tsort_each'
/opt/bitnami/ruby/lib/ruby/2.3.0/tsort.rb:205:in tsort_each' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/initializable.rb:54:in run_initializers'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/application.rb:352:in initialize!' /opt/bitnami/apps/redmine/htdocs/config/environment.rb:14:in <top (required)>'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/polyglot-0.3.5/lib/polyglot.rb:65:in require' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/polyglot-0.3.5/lib/polyglot.rb:65:in require'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/application.rb:328:in require_environment!' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/railties-4.2.8/lib/rails/application.rb:457:in block in run_tasks_blocks'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:251:in block in execute' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:251:in each'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:251:in execute' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:195:in block in invoke_with_call_chain'
/opt/bitnami/ruby/lib/ruby/2.3.0/monitor.rb:214:in mon_synchronize' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:188:in invoke_with_call_chain'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:217:in block in invoke_prerequisites' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:215:in each'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:215:in invoke_prerequisites' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:194:in block in invoke_with_call_chain'
/opt/bitnami/ruby/lib/ruby/2.3.0/monitor.rb:214:in mon_synchronize' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:188:in invoke_with_call_chain'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/task.rb:181:in invoke' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:160:in invoke_task'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:116:in block (2 levels) in top_level' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:116:in each'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:116:in block in top_level' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:125:in run_with_threads'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:110:in top_level' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:83:in block in run'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:186:in standard_exception_handling' /opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/lib/rake/application.rb:80:in run'
/opt/bitnami/ruby/lib/ruby/gems/2.3.0/gems/rake-12.2.1/exe/rake:27:in <top (required)>' /opt/bitnami/ruby/bin/rake:23:in load'
/opt/bitnami/ruby/bin/rake:23:in `'
Tasks: TOP => redmine:plugins:migrate => environment
bash-4.2# exit
exit
config Redmine :Environment:
Redmine version                3.4.3.stable
Ruby version                   2.3.5-p376 (2017-09-14) [x86_64-linux]
Rails version                  4.2.8
Environment                    production
Database adapter               Mysql2
SCM:
Subversion                     1.9.7
Git                            2.14.1
Filesystem
Redmine plugins:
additionals                    2.0.11
clipboard_image_paste          1.12
computed_custom_field          1.0.6
disable_activity               0.0.1
event_notifications            2.4.1
redmine_banner                 0.1.2
redmine_ckeditor               1.1.5
redmine_custom_css             0.1.7
redmine_custom_reports         0.1.5
redmine_default_custom_query   1.3.0
redmine_drafts                 0.2.0
redmine_email_notification_content_filter 0.0.2
redmine_issue_templates        0.1.8
redmine_knowledgebase          3.3.1
redmine_landing_page           0.1.1
redmine_logs                   0.1.1
redmine_privacy_terms          1.0.0
redmine_tkgmap                 0.1
redmine_workflow_enhancements  0.5.0
a error from your plugin or with additionals plugins ?
The goal is to use redmine_datetime_custom_field plugin
Regards,

One solution for it would be, to remove this line in redmine_datetime_custom_field https://github.com/nanego/redmine_datetime_custom_field/blob/master/init.rb#L11. additionals provides deface like redmine_base_deface. This means, if you use additionals, you do not require redmine_base_deface anymore.

Same problem here.
I changed additionals  plugin Gemfile from '1.3.2' to '1.5.3'
Installation succeded, for the moment it seems to work.

Same problem here.
I changed additionals plugin Gemfile from '1.3.2' to '1.5.3'
Installation succeded, for the moment it seems to work.

Hi @andreav,
in the upcoming stable additionals plugin there is 1.5.3 used, which is compatible with redmine_base_deface again. Your change shouldn't be a problem with additionals plugin.


fizzbuzz.cpp : added a function fizz_buzz that does the job.

I added a function fizz_buzz(n) that does the job. Now the main function is more compact.

I really like the extra effort of putting this into a function, but it doesn't necessarily need to replace the current code available. What I would suggest is that you put this as a second solution in the FizzBuzz>C++>Your Solution Thanks so much for the submission, and keep up the awesome work!

@AustinTice Thanks. I will change the PR

Thank you!


Bluetooth Permission Requirements will change in Android 12

Bug Report
Starting with android 12 new Bluetooth Runtime permissions are required. The MultiplexBluetoothTransport class will require the new BLUETOOTH_SCAN and BLUETOOTH_CONNECT Permissions
https://developer.android.com/about/versions/12/features/bluetooth-permissions
OS & Version Information

Android Version: SDK 31

Fixed in #1771


Battle Testing

Hi there,
I've been looking at this gem and it looks very interesting!  How is the testing going? Is this close to production ready?

Yup, it’s been running in production for a few weeks now with no problems whatsoever. I was planning on giving it at least a month before I would go v1.

Ok, thanks a lot for the response! I think we’ll give it a try soon too. Will let you know how we fare.
On 28 February 2016 at 14:35:49, Eloy Durán<EMAIL_ADDRESS>wrote:
Yup, it’s been running in production for a few weeks now with no problems whatsoever. I was planning on giving it at least a month before I would go v1.
—
Reply to this email directly or view it on GitHub.

i'm waiting for v1 aswell. I will try it on staging this week. FYI: i'm sending millions of push notifications daily basis.

@supagroova Great, thanks!

@evrenios Awesome! In my case it's in the ten thousands, so I'd love to hear your experience. I think that if you both give the green light we can safely mark this as v1, so looking forward to hearing from you.

@alloy after some heavy testing, it sends 38k push in around 170 second. The open connection count doesnt seem to change anything, i compared with 5-10-15-20-25 with Benchmar#Measure.
pros ; delivery consistency, with the individual responses, you get to know which token is corrupted, and still be able to receive push notification after the bad token.
cons; with that consistency, it lost its speed, WIth the grocer gem, i sent the same amount of push notification in 16 second.
Do you think you can increase the throughput ?
I manage my own gcm system with typehous, and send each post separately to google. Opening and closing each connection every time. And it's able to send 140k push in 50 sec, so i expected much more in terms of performance.

Interesting. I will do some more measuring to see if I can spot an area where it might be lagging, but it would be great if you could do so too, so we can compare notes.

Can confirm is working very well for us so far (two weeks in production).

Works well here too, if not send in a delayed job.
How are you guys sending the messages in the background?

After #12 it works now here too with DJ :)

This looks great! I am concerned about throughput, but not initially.  Happy to be part of the early adoption here; please update with any progress on the throughput end!

Hi @alloy
I am wondering if you've made progress to increase the throughput. We're sending at least 2M per day so the throughput does matter. I appreciate your great work.

@nextofsearch If you are sending 2million messages per day, you should have the resources to make this improvement with your team and make a pull request. Author has done a great job of getting an early version out with decent performance.

@mkonecny I did say that I appreciate the author's work and I really do. You made assumption that my team has the resources but on the contrary we don't so we are considering to use AWS's SNS instead. MYOB.

@nextofsearch Alas, I have not. I guess whether or not that matters for your situation depends on how your notifications are being sent, is it in a few bursts or is it transactional ones throughout the day? Because 2M notifications throughout the day is ~23 notifications/sec, which I don’t believe should be a problem.
I’d love for you to try and report back! But alas I can’t make any promises about when I will have time when it’s not directly related to my business purpose; in that regard @mkonecny suggestion about PRs (or just investigation into causes of bottlenecks) is of course correct, but I totally understand you needing to prioritise according to your own business 👍 And thanks for your appreciation!

@mkonecny @swelther @dchersey Thanks for letting me know!

I’m thinking about calling the current version a v1 soon and then look into possible performance improvements for a v2. Completely naive thoughts (needs more proper profiling!) are:

Replace Celluloid with concurrent-ruby.
Replace pure Ruby HTTP/2 client with a C based version.

@alloy It's in a few bursts hitting the limit of CPU utilization from time to time. We haven't decided yet but if we decide to go with this gem, I will share the report. Thank you again.

@alloy FWIW the Celluloid dependency is the only reason I'm staying away from this gem. Celluloid got super slow starting with 0.17. I'd avoid using Celluloid until this issue gets resolved.
That issue's been open for 6 months now, so I'm kinda starting to lose hope for Celluloid's performance. In fact we're thinking about moving internal projects over to Akka.
You should always benchmark, but I'd be willing to bet Celluloid's your bottleneck. If you lock to 0.16 you should see immediate performance gains.
IMO you should ditch Celluloid altogether in favor of concurrent-ruby.

@fedenusy Yeah I think you’re right and have been looking at concurrent-ruby.

We started using it in production a few days back and we have been seeing errors described here:
https://github.com/alloy/lowdown/issues/25
Looks like those "Actor crashed!" errors are mostly due to celluloid. We never saw them in staging environment.
The errors were so frequent that we had to roll back to old style APNS to avoid further end user problems. Bad firefighting night/morning! I'll try to look into what's causing the exceptions once I have had some sleep ;)

Pushed a v1 gem and filed a new ticket for the v2 changes https://github.com/alloy/lowdown/issues/27.


Fix the sample and added a readme for the sample

I tried the sample and found out that it didn't work out of the box. After a small change in the version of the pom.xml it seemed working correctly.
To help other users to get started quickly, I've added a readme to the sample.
If I need to improve this PR, please let me know...

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     95.78%   95.78%
  Complexity      126      126
=========================================
  Files            18       18
  Lines           356      356
  Branches         25       25
=========================================
  Hits            341      341
  Misses            9        9
  Partials          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48668f6...6c50162. Read the comment docs.

Thanks for the contribution!
The sample was configured to use the latest development version 1.0.3-alpha. The development repository was not listed in the pom.xml which causes build failure. So we can list the development repository or use the latest release version. Can you add the development repository and see if this fixes the problem:
<repository>
    <id>bintray-merapar-maven</id>
    <name>bintray</name>
    <url>http://dl.bintray.com/merapar/maven</url>
</repository>

The sample readme gives a good overview of the possibilities. An improvement point is to list GraphiQL application for easy playing with the API.

Hi Jan,
Thanks for your feedback!
I'll try to fix the PR later today.
Regards,
Jurrian
Op ma 7 aug. 2017 09:26 schreef Jan Fockaert<EMAIL_ADDRESS>
Thanks for the contribution!
The sample was configured to use the latest development version
1.0.3-alpha. The development repository was not listed in the pom.xml which
causes build failure. So we can list the development repository or use the
latest release version. Can you add the development repository and see if
this fixes the problem:

bintray-merapar-maven
bintray
http://dl.bintray.com/merapar/maven

The sample readme gives a good overview of the possibilities. An
improvement point is to list GraphiQL
https://github.com/graphql/graphiql application for easy playing with
the API.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/merapar/graphql-spring-boot-starter/pull/24#issuecomment-320589298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL037InnxV7WDyTQce8gXhO_iKPU-F_wks5sVrwRgaJpZM4OuvHH
.

Thanks!


IE11: Click on scroll bar does not move scroll handle

On IE11, it is not possible to click the scroll bar (light area) to scroll, only supports clicking the scroll handle and move it with mouse (or touch).

Hello,
I have the same problem in IE10 and IE11. But for only scroll down doen't work. Please see this video file for more details:
https://www.dropbox.com/sh/55w3nbu2jdnq6ew/AAAsjewRHCbDMkdizqtDw7bwa?dl=0

Hi guys!
Any progress with this issue? I have the same problem and this really important for my project.
Thx in advance.

@Chehow I haven't had a chance to look in to this yet. I'm still tackling a different issue first, before I'll address this issue.
If you want to have a look, I believe the issue would be in handler/click-rail.js.
If you do find anything, please let me know.

Hello,
I've checked this file: https://github.com/noraesae/perfect-scrollbar/issues/409
There is no window.scrollY and window.scrollX in IE11 and below. It works only in edge.
https://developer.mozilla.org/ru/docs/Web/API/Window/scrollY

Thank you @pliasetski. I've addressed the bug now.


Over a hundred new pods from over 20 mods (and stock)

Basically, every crewed part that I use.

I've just returned from vacation (en-us)/holidays (en-gb). I should have recovered enough over the weekend to check this over and merge it

I'm guessing 1.2 dropped (busy with game going gold @ work) - will see if I can build 1.2 tonight.

It's out for prerelease testing, but actually those last two commits are from very late 1.1.3 updates to mods.


feat(PageSidebar): add new styling for dropdown menus

FX-2753
Description
Following the adjustments made to the BASE design, we should add the new styles for the dropdown menus
How to test

Check the Page example on storybook, it now has an functioning Sidebar

Screenshots

Before.
After.

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure that tests pass by running yarn test
[x] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests

Breaking change

[x] codemod is created and showcased in the changeset
[x] test alpha package of Picasso in StaffPortal

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

The collapse button is not clickable on the left side.
This only happens in the Page examples. Doesn't happen in PageSidebar examples.
https://user-images.githubusercontent.com/8407461/168090424-92f2d980-4cee-4f3e-ad4c-3899da4e886a.mp4


Firebase social login not working! [UserAgent not allowed error]

wkwebview works great! Huge performance improvement on iOS compared to the UIWebView.
I'm using firebase inside my app and social login to log the users in with their gmail account.
I followed this guide https://firebase.google.com/docs/auth/web/cordova to implement it and it worked fine with the UIWebView. It uses the sign in with redirect method that opens a webview inside our ionic app and handles the OAuth flow.
But with the wkwebview it's not working anymore firebase is giving disallowed_useragent error.
Is there a way to fix this? Will spoofing the user agent before making the request make it work?

This doesn't look like a problem with the wkwebview-plugin. Google is specifically blocking your method. I wouldn't recommend spoofing your User-Agent even if you can for security and compatibility reasons. What you should be doing is redirecting to the native browser (not using an embedded webview) when the user is authenticating and use a Custom URL Scheme to redirect back into the app once the user is authenticated. It looks like that is what the Firebase documentation is suggesting, so you should follow their instructions.

For social login with google, regardless of using Firebase or any other method, and regardless of using webview or wkwebview, you need to use the safari view controller or chrome custom tabs plugins. Follow the plugin instructions in this tutorial:
https://firebase.google.com/docs/auth/web/cordova

Unfortunately I also encountered problems with social login, even after following the above mentioned tutorial. The social login page gets opened in the system browser, but is then redirected to localhost instead of the app deep-link (to be opened in the app itself).
Has anyone got the Firebase social login working with this? Thanks!


Speed up running the framework validation test suite

We're parsing thousands of files and there are many tokens per file.
The overhead of all the assert statements is noticeable.
Optimizing out the check (when they'd pass) speeds this up 3x from 90 seconds to 30 seconds - notably, function calls in php are slow, and phpunit has multiple levels of them
Don't write files only to unlink them later.
Instead, save the failed file only on test suite failure

@roblourens - thoughts? The speedup for this would be convenient for local development, and #382  would make the validation test suite pass so that it can be required in CI again


Use drake for data pipeline management

Problem
Splitting our analysis by R notebooks makes sense only for exploration and storytelling. When we have an actual data pipeline figured out, we ought to have it in a real pipeline that we can reproduce without multiple notebooks of many chunks.
Solution
Use drake (link: https://github.com/ropensci/drake) to handle our data pipeline.

After more review it appears drake was superseded by https://docs.ropensci.org/targets/


Recursive tunnelling

Remote processes should be able to import Chopsticks and construct their own tunnels. This enables several things - such as tunneling to a remote host and then using the Sudo() tunnel for escalated privileges.
There are a couple of issues blocking this; one is that remote processes can not currently find the bubble code. Also, the imp handler doesn't know how to consult the bubble's importer to resolve imports.
It is preferable that this cannot result in infinite recursion. To avoid this, it might be possible to set a (global) depth limit like setrecursionlimit().

This is implemented as of 2e9a7a96c90209a3847bc75dcc431b965fc3d189.


Add per-dandiset stats endpoint and frontend use

Following up from this comment: https://github.com/dandi/dandiarchive/issues/38#issuecomment-637828542
This endpoint would return the following about a specific dandiset:

number of folders
number of items
number of bytes
number of items with 0 files

OK by me. In the end it might end up being ok to go into the same endpoint, but i'm fine with splitting out into separate PR/issue.


Pls can u upload Course 7 & 8

Hi ashu1230
Pls can u upload Course 7 & 8 , Please we I need it to pass the courses,
If you cant pls help me on<EMAIL_ADDRESS>Thanks
Nasser

i think about it....


Command not found on zsh shell - Mac Mojave

i've installed this package globally via npm i -g laravel-echo-server but zsh just shows me: zsh: command not found: laravel-echo-server
what should I do next?

solved: by adding the $PATH


GEODE-8329: Fix for durable CQ reqistration recovery

This change solves the issue when the client without configured HA is
wrongly re-registering durable CQs as non durable during the server
failover.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@agingade do you have further comments on this PR?

Hi @agingade ,
If you have any concerns please write them by the end of the week, if not we will go with merging this.


📃: Add a AI Movie Recommender

:red_circle: Title : Add a AI Movie Recommender
:red_circle: Aim :
The goal of this issue is to integrate a movie recommendation feature into the existing application using the Gemini API for AI-powered recommendations. The system should dynamically recommend movies based on user preferences or watch history. It should be user-friendly, responsive, and seamlessly integrated with the current app structure.
:red_circle: Tech Stack Used :
Next.js for building the frontend.
Gemini API for movie recommendation algorithms.
ShadCN for UI components.
TypeScript for type safety.
MongoDB (optional) for storing user preferences/watch history.
Vercel for deployment.
Screenshots 📷
N/A
:white_check_mark: To be Mentioned while taking the issue :
Full name : Amit Singh Bora
What is your participant role? Hacktoberfest,  GSSOC
Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@amitb0ra can you assign this to me

@Avdhesh-Varshney can you add level 3 ?


reserved identifier violation

I would like to point out that an identifier like “_VVDEC_SEI_H_” does not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

:eyes: It seems that a few update candidates were left over also for this issue.
Example:
https://github.com/fraunhoferhhi/vvdec/blob/d5a7998607eb5e417664090f755920a0f240d78b/source/Lib/CommonLib/TypeDef.h#L783


onmessage function is not being called, causing timeout when defined.

Hi,
I've been playing with Sandbox on node 0.10.33 on OSX. I can send message from inside the Sandbox out the host environment. When I try and postMessage() into the Sandbox and with an onmessage function defined, the run() method times out.
Here's my code
var Sandbox = require('sandbox');

sb = new Sandbox();
sb.on('message', function (message) {
  console.log("outer message handler: "+message);
});
sb.on('ready', function() {
  console.log('ready. posting...');
  sb.postMessage("calling when ready");
});
sb.run("postMessage('message from inside'); 10 + 10;", function(output) {
  console.log(output)
});

sb = new Sandbox();
sb.on('message', function (message) {
  console.log("outer message handler: "+message);
});
sb.on('ready', function() {
  console.log('ready. posting...');
  sb.postMessage("calling when ready");
});
sb.run("onmessage = function (msg) { console.log(msg); };", function(output) {
  console.log(output)
});

Producing the following output:
outer message handler: message from inside
ready. posting...
{ result: '20', console: [] }
ready. posting...
{ result: 'TimeoutError', console: [] }

Is anyone else seeing this problem? I've run the test code and it passes on my machine. If I modify the test code by removing the spies, then the same timeout problem occurs.
A little help appreciated,
Ijonas.

Same for me, when running the example getting this TimeoutError (OS X as well)


Implement it in Node.js as instructed, and then pack it into JS using npx webpack, but call Uncaught ReferenceError: Buffer is not defined

Note:     Uncaught ReferenceError: Buffer is not defined

see https://github.com/terra-money/terra.js/issues/223.

TLDR; use react-scripts 4.x


FBdv:00007007 late third instar larval stage, please add relation [sf#42]

Reported by anneniknejad on 2014-09-17 09:53 UTC
hello,
could you please add
relationship: immediately_preceded_by FBdv:00005340 ! early third instar larval stage
Thank you very much.
Anne

Commented by mmc46 on 2014-09-19 09:41 UTC
Hi Anne,
FBdv:00007007 late third instar larval stage already has the relation
relationship: starts_at_end_of FBdv:00005340 ! early third instar larval stage
'starts_at_end_of' and 'immediately_preceded_by' are the same RO:0002087, though the latter is the current id.
We'll be replacing 'starts_at_end_of' with 'immediately_preceded_by' soon.
Thanks,
Marta

Commented by djs93 on 2014-09-19 10:19 UTC
Wondering if Anne & Frederic are looking at the latest version here. Seem to remember these being missing relationships until some time last year.

Commented by anneniknejad on 2014-09-22 09:40 UTC
Thank you Marta, it's very much appreciated.
David, I was looking at the latest version, yes, but too much focused on 'preceded' term and not paying attention to 'starts'  ;-)  sorry about that
Anne

Updated by mmc46 on 2014-10-14 16:18 UTC

status: open --> closed


Rendered Configuration not available for host devices

Nautobot Version - 2.2.6
Using the nautobot inventory plugin for nornir, when attempting to access config context data for a device, only local config context is available.  Rendered config context data is not available for each host.

The "nautobot_dictionary" dict does not return rendered config.


MNT: Re-rendered with conda-smithy 1.7.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks @shyuep! Can you add setuptools to the run requirements and bump the build number too?

Done.


update api limits /3

Fixes #28913
See Minimal APIs now support file upload with IFormFile and IFormFileCollection

@tdykstra  this commit fixes both good points.


Upgrade to 74 and remove extra Switch example page

Description
Upgrades the Fabric Gallery app to 0.74. Also removes the Switch example page being duplicated in the navigation stack.
Why
Upgrade to 0.74 before publishing branch on main.
What
Remove duplicate StackScreen in App.tsx and bump react-native and react-native-windows to 0.74.
Microsoft Reviewers: Open in CodeFlow

Is this still a relevant PR @Yajur-Grover or should we close?

Will close since the plan for Fabric Gallery is to redo the migration after bringing in the latest UI changes, and re publish on a separate branch.


Automatic invalidation of DIscord bot tokens

Someone leaking their bot token by accident in #python-discussion had gotten me thinking - would it be possible for the bot to automagically invalidate bot tokens, similar to GitHub's secret scanning, as a precautionary security measure? Putting myself in the shoes of a malicious actor, wouldn't it be trivial to run a self-bot in the server which awaits tokens, authenticates as them and performs automated malicious actions?
Relevant discussion in #community-meta

automated malicious actions could also just get the user/bot banned

I think it was mentioned in the discussion after this was posted, but the reason we don't do this is that discord doesn't expose an andpoint that allows invalidating tokens.
The only way to do this (afaik) would be to upload tokens to GitHub and rely on GitHub's secret scanning to remove them, which has a few issues:

If GitHub doesn't remove them immediately uploading them to GitHub could make things worse.
It's a bit dodgy to upload peoples tokens to a 3rd part service.
It would require some thought and effort to implement properly.

Uploading the tokens to GitHub isn't an outlandish idea, but I don't think it's a big enough issue for it to outweigh the negatives, so I'll close this.


[SPARK-28270][test-maven][FOLLOW-UP][SQL][PYTHON][TESTS] Avoid cast input of UDF as double in the failed test in udf-aggregate_part1.sql

What changes were proposed in this pull request?
It still can be flaky on certain environments due to float limitation described at https://github.com/apache/spark/pull/25110 . See https://github.com/apache/spark/pull/25110#discussion_r302735905

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/6584/testReport/org.apache.spark.sql/SQLQueryTestSuite/udf_pgSQL_udf_aggregates_part1_sql___Regular_Python_UDF/

Expected "700000000000[6] 1", but got "700000000000[5] 1" Result did not match for query #33
SELECT CAST(avg(udf(CAST(x AS DOUBLE))) AS long), CAST(udf(var_pop(CAST(x AS DOUBLE))) AS decimal(10,3))
FROM (VALUES<PHONE_NUMBER>005),<PHONE_NUMBER>007)) v(x)

Here;s what's going on: https://github.com/apache/spark/pull/25110#discussion_r302791930
scala> Seq("7000000000004.999", "7000000000006.999").toDF().selectExpr("CAST(avg(value) AS long)").show()
+--------------------------+
|CAST(avg(value) AS BIGINT)|
+--------------------------+
|<PHONE_NUMBER>005|
+--------------------------+

Therefore, this PR just avoid to cast in the specific test.
This is a temp fix. We need more robust way to avoid such cases.
How was this patch tested?
It passes with Maven in my local before/after this PR. I believe the problem seems similarly the Python or OS installed in the machine. I should test this against PR builder with test-maven for sure..

cc @dongjoon-hyun and @viirya. This is a temp quicky fix for now.

Let me trigger maven build as well soon.

FYI @viirya, @skonto, @imback82, @huaxingao, @vinodkc, @manuzhang since you guys are working on this.

Test build #107570 has started for PR 25128 at commit 78d636d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12695/
Test PASSed.

I am going to write up workarounds for such cases in its parent JIRAs .. I will update and let you know guys.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12697/
Test PASSed.

Test build #107572 has started for PR 25128 at commit 78d636d.

The Maven Jenkins result (2nd tigger) succeeded.
...
- pgSQL/int8.sql
- pgSQL/case.sql
- pgSQL/select.sql
- pgSQL/aggregates_part2.sql
- pgSQL/date.sql
- pgSQL/boolean.sql
- pgSQL/aggregates_part1.sql
- pgSQL/int4.sql
- pgSQL/int2.sql
- pgSQL/float4.sql
- ansi/interval.sql
...

Thank you for quick fix.

Thanks guys. This problem bugs me hard 😓. Let me think more and try to make a fix or the list of workarounds probably within today.

Test build #107570 has finished for PR 25128 at commit 78d636d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107570/
Test PASSed.

Merged to master.
This cannot affect other tests other than the passed tests.

Test build #107572 has finished for PR 25128 at commit 78d636d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107572/
Test FAILed.


WIP: infra/configure editor setup

closes https://github.com/crococoders/chaikovsky/issues/3
Research recap:
[TsLint, EsLint] Folks at Palantir who once created tslint, to lint typescript code, decided to stop maintain it and turned their sight to eslint, referring to the fact that eslint is architecturally more efficient and has more rules and plugins that are maintained by huge open source community. Both typescript and tslint communities suggest to use @typescript-eslint to lint typescript code.
Eslint and Typescript compiler parse codebase to Abstract Syntax Tree data structure and then check for rules and types, that are specified in a list of plugins that add or extend rules in .eslintrc.json. @typescript-eslint suggest elegant way of linting by specifying @typesctipt-eslint/parser and plugin:@typescript-eslint/recommended in eslint config file. It will tell eslint to not use default parser and use @typesctipt-eslint/parser.
The latter, @typescript-eslint/recommended, has extensive list of rules that are, apparently by no means as large and thorough as eslint:recommend's list. However, I think that trade-off is justified for our relatively small project and overall @typesctipt-eslint is a good choice!
Checkout typescript-eslint monorepo for more info.
Configuration info set:
[Prettier] -

tab is 4 spaces,
semicolon and double quotes is a must.

[VsCode] -

our codebase is formatted on save with eslint and prettier --fix.
autosave is on after each focus change
use my favorite theme and icons extension

[Typescript] -

tsc compiles all .ts .d.ts .tsx files in src directory.
dist directory is specified as outDir (.js files after transpilation)

and [Babel] configuration is set by default.
Please reach out about any questions and things that I might miss in this short recap!

You may resolve WIP status now and please try to name your PR-s correspondingly based on your branch name. PR name that is defaulted by GitHub is not correct most of the time.
So your PR should be named: feature/configure_editor_setup and yours is Infra/configure editor setup (I made the first letter lowercase accidentally, sorry for that, couldn't resist :)
Why feature/ and not infra/. Basically I see that you followed the logic of prefixing your branch name with infra/ due to the fact that I labeled corresponding issue as so.
But due to the fact that we adhere to git-flow branching model and there is no specialized infra/ branch type - all branches that are not hotfix/ and release/ are feature/ by default.

Also when you write commit messages it is not necessary to add trailing . :)

Basically you did a great job on this one! 👏🏻
Nice and thorough research. Just need to take it one step further by elaborating on details I mentioned & also I'd love to see a bit more info on how babel work with typescript (is there any issues or what should we know about the process transcompiling of TS, maybe there are some pitfalls). This one is optional though, but for the clarity I think you can include few links.


Updates stale Dask graph visualization

This change updates the stale hello_world_dask.png file using the new graph visualization node shapes from #169.
Changes
We're updating the following file: examples/dask/hello_world/hello_world_dask.png
How I tested this
Successfully ran unit tests locally using the following command in the root directory: pytest tests/
Notes
N/A
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[x] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future TODOs are captured in comments
[x] Project documentation has been updated if adding/changing functionality.

Re-raising PR with single commit.


Mac app appears as Onivim2.App.app

A small eyesore from the latest nightly, the app bundle appears to be called Onivim2.App.app

This is on macOS “Catalina” 10.15 (19A602)

I've noticed this as well, it also pops up in spotlight.

Here’s how it looks from the CLI
[mikl:/Volumes/Onivim 2] % ls -lah
total 40
drwxr-xr-x  6 mikl  staff   272B 21 Oct 03:40 .
drwxr-xr-x  7 root  wheel   224B 22 Oct 10:37 ..
-rw-r--r--  1 mikl  staff    15K 21 Oct 03:40 .DS_Store
drwxr-xr-x  3 mikl  staff   102B 21 Oct 03:40 .background
lrwxr-xr-x  1 mikl  staff    13B 21 Oct 03:40 Applications -> /Applications
drwxr-xr-x  3 mikl  staff   102B 21 Oct 03:40 Onivim2.App

My guess is that .App (capital A) is not recognized as the proper extension for an app bundle, and macOS then “helpfully” adds .app to ensure the bundle works properly.

Thanks for reporting this, @mikl !

My guess is that .App (capital A) is not recognized as the proper extension for an app bundle, and macOS then “helpfully” adds .app to ensure the bundle works properly.

I think you're right. What's strange is I don't see this on Mojave (10.14.5) - might be something new in Catalina. I need to do some testing on Catalina-

Can confirm that this is fixed in the latest nightly:

Thank you @mikl !


refactor(share): fixing subscriber too slow log in shrexsub and reducing lightavail log verbosity

Overview
Fixes the following log:
2023-02-17T18:30:32.190+0100	INFO	pubsub	go-libp2p-pubsub@v0.8.3/pubsub.go:981	Can't deliver message to subscription for topic /eds-sub/v0.0.1/arabica-6; subscriber too slow

Also snuck in removing multierr's errCauses field from light availability logs (like we do in full availability), as it leads to duplicate information inside when cascadegetter fails.

Codecov Report

Merging #1774 (c9c6c5b) into main (5aee280) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
+ Coverage   57.14%   57.28%   +0.14%
==========================================
  Files         239      239
  Lines       15749    15759      +10
==========================================
+ Hits         9000     9028      +28
+ Misses       5819     5801      -18
  Partials      930      930

Impacted Files
Coverage Δ

share/availability/light/availability.go
80.85% <100.00%> (ø)

share/p2p/peers/manager.go
79.48% <100.00%> (+0.91%)
:arrow_up:

share/availability/discovery/discovery.go
58.11% <0.00%> (-1.71%)
:arrow_down:

share/ipld/get.go
92.14% <0.00%> (-1.24%)
:arrow_down:

share/eds/byzantine/pb/share.pb.go
34.84% <0.00%> (+1.96%)
:arrow_up:

core/listener.go
52.11% <0.00%> (+4.22%)
:arrow_up:

share/p2p/shrexsub/subscription.go
81.25% <0.00%> (+25.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use stringMatchOption instead of deprecated stringMatchId #1688

Q
A

Bug fix?
[x]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1688

What's in this Pull Request?
As discussed in #1688 it appears that the stringMatchId query parameter is not supported by the searchTerm-API anymore. The fix proposed in that issue (using the stringMatchOption query parameter with value StartsWith) worked.
With VS Code I could not find any usages of the searchTerm function that uses the stringMatchId, so there are (hopefully) no side effects in the package itself. For consuming libraries, this might be a breaking change.

Any news on this bug ?

@lafe many thanks and apologies for the delay in reviewing this. This is now merged


This repo is big

$ du -d 1 -h
 12K	./test
4.0K	./bin
 20K	./example-app
 19M	./resources
8.0K	./lambda
 80M	./.git
 40K	./src
100M	.

We should explore alternatives to committing CDK artifacts, as after just a few version upgrades we already have ~80MB in the git history.

Marc brought up the same issue in a different context. Bundling all these packages together means you can't opt into specific versions if there are breaking changes, you are forced to adopt everything wholesale. One option would be to just not bundle the jsii packages at all and use the mvn versions that are pushed as a part of aws cdk. The downside to these is that they contain generated java code bloat (which probably doesn't matter since this is a dev time dependency) and you would have to require individual modules manually in consumer projects.

The primary concern is to ensure that pulling this repo is fast (e.g., in a pipeline context). Maybe a little bloat is OK. Especially if it keeps the repo small on disk.

If the other tradeoff is alright (having to explicitly include modules in deps.edn) then this should be an easy change. We can just remove the included modules and update the docs pointing to the maven coords for modules. Will be a breaking change for consumers.

The README leaves some room for such changes. If the actual change included some hand-holding on how to overcome the breakage, it wouldn't be so bad IMHO.


fix(ipfs-coord): Updating to v6.5.6

:tada: This PR is included in version 2.4.1 :tada:
Your semantic-release bot :package::rocket:


Move site back where it belongs

This is work-in-progress: trying to get the log4net site generation working properly again.

@rgoers I've moved the artifacts back where maven recognises them, but the result I get from running a command like mvn site:stage -DstagingDirectory=$HOME/log4net gives me a site where the index is ok, but a lot of the linked pages (eg releases) don't exist. I'm not sure if the problem is environmental or otherwise; since I know nothing about maven (another thing to learn!) I'm not 100% sure about where to start tracking this down, but a quick text-search within the site folder & generated area hasn't been very illuminating. I thought I'd start a PR now so that anyone with more knowledge on the tooling could help.

FWIW, the Apache Logging project generally uses "CTR " (commit - then review). So if you are comfortable with the changes being made you don't need to create a PR. Committers generally only create PRs when they really want a code review because they either a) aren't 100% sure they are doing the right thing or b) want others to be aware of some impact the commit is going to cause.

@rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net?

On Aug 26, 2020, at 8:27 PM, Davyd McColl<EMAIL_ADDRESS>wrote:
@rgoers https://github.com/rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net?

Yes, unless you specifically want others to review it because you aren’t quite sure if it is the right way to do it, the code will cause breaking changes and you want others opinions, etc. For most things you should just commit to master. We all get commit emails and will see it.  Some of us might look at it and if we have questions we will ask.
Ralph

@rgoers cool -- but I can't push to apache/logging-log4net:
ERROR: Permission to apache/logging-log4net.git denied to fluffynuts.

Your apache userid is davydm. It needs to be linked with your GitHub user. See https://gitbox.apache.org/setup/. Apache Logging doesn't have a guide but many projects do. For example, https://cwiki.apache.org/confluence/display/OPENWHISK/Accessing+Apache+GitHub+as+a+Committer
Ralph

@rgoers I've gone through the above:

linked my apache id davydm to this github account (fluffynuts)
accepted the asf invitiation
received mail around team addition
gitbox seems to think I should be able to push:

however, I still can't push to github.com/apache/logging-log4net:
ERROR: Permission to apache/logging-log4net.git denied to fluffynuts.

I'm not sure what I'm missing, but I'm assuming I've either missed a step or done something wrong.

Thanks @rgoers I've managed to push & I've pushed new site content via svn too; getting a little stuck at point 7 of https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Logging+Services+Web+Site with respect to getting the site live (and haven't done the 2.x symlink to the new content yet as I'm at a windows machine; need to do it quick on my linux box)

I'm not sure if this belongs to the changes made in this PR, but https://logging.apache.org/log4net/ (with is the top Google result if you search for "log4net") currently leads to a directory listing.

@cremor thanks for reporting; logging sites are in a bit of a state of upheaval right now (as far as I understand). Good people are On It.

Please try it again.

FWIW, the documentation for publishing the web site is at https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Git+Hosted+Web+Site. So you would run your build to create the web site and then copy it into the Log4net site repo.

Thanks for sorting it out @rgoers. I'll try to be better prepared next time.

@rgoers Now the link https://logging.apache.org/log4net/ works, but the link which is on https://logging.apache.org, which is https://logging.apache.org/log4net/2.x/index.html (both the button on the main site and in the menu at the top), doesn't work any more 😕

Thanks. Those should be fixed now.

None of this was your fault. All these issues were related to me moving the site from the ASF CMS system to GitHub.
Ralph

On Sep 10, 2020, at 9:50 AM, Davyd McColl<EMAIL_ADDRESS>wrote:
Thanks for sorting it out @rgoers https://github.com/rgoers. I'll try to be better prepared next time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apache/logging-log4net/pull/62#issuecomment-685954452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5MX5JSB54TEOH4GJKN4DSFD7WFANCNFSM4QMCEMTA.


remove PARI limitation for binomial with negative args

2024-01-05 11:49:47|INFO |Checking 5 terms of A037964: a(n) = -binomial(-n,-2*n)+binomial(-2*n,2*n)
2024-01-05 11:49:47|INFO |Generated sequence: 0,3,35,462,6435
2024-01-05 11:49:47|INFO |Expected sequence:  0,4,32,472,6400
2024-01-05 11:49:47|ERROR|Unexpected PARI sequence

will be available in next stable release of PARI/GP: 2.17.0.


add hyperdrive code

@lostmygithubaccount - You are right. TensorFlow might be a better scenario to showcase compared to Scikit-Learn classification/regression since TF and most DNN scenarios are not supported in AutoML, hence that's the main reason why you'd use HyperDrive for tuning your code. 👍


Fix AgentHandler bug

The AgentHandler class is used by AgentManager in order to save/load agents when returning to the main process after training agents in different processes/threads.
It calls Agent.save(), which uses pickle by default. This was causing bugs when the env and eval_env attributes of the agent were not pickleable. In this PR, both attributes are set to None before saving, and are restored by Agent.load() with the constructors provided by AgentManager.

Maybe just do an example or tutorial or user guide entry in the doc to explain that, with a link from the docstring of AgentManager saying something like  "if it is not pickleable, see the example in the documentation".
This example would be an example for user-defined save/load which can also be interesting independently.


[Candidate 3v3 Garden of Terror ZH v1] Tech Buildings have custom rotations that make their flags less visible

Observed behavior
Tech Buildings have custom rotations that make their flags less visible.
Expected behavior
All Tech Buildings have default rotations or custom rotations that make their flag highly visible in default camera rotation.
Screenshots

done

What about the other one on the other side? That one was not adjusted.


Add nd-gaussians to Splatfacto

Adds support for rasterizing gaussians with extra dimensions
Adds parameters to gsplat:

use_nd (bool)
nd_dim (int)
nd_detach (bool)

I know that internally we've used the term "nd" a lot, but it's not very precise from an outside perspective. Can we rename things to "render_features" or "render_latents" or something like that? then instead of "nd_values" it could output something like "feature_map" which is more clear what's going on.

We should refactor this to integrate with #2946, it will simplify the logic.


Messages in continuation

The bot should remember what it said the last time, especially if the bot itself is asking a question.

Retaining context is a planned feature - coming soon!

That'd be nice! I've seen this lacking in many bots, making their usage very uninteresting to me.

Agreed.


[BUG]: User Query embeddings are being chunked per character when using LM Studio embedding models.

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?
Document embeddings are chunked properly, but user query embeddings are chunked per character resulting in useless embeddings - when using LM Studio as embedding provider. Default built-in embeddings work properly.

LM Studio Logs
[2024-04-29 22:21:19.847] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "D"
}
[2024-04-29 22:21:19.855] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.857] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "e"
}
[2024-04-29 22:21:19.865] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.866] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "f"
}
[2024-04-29 22:21:19.874] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.876] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "i"
}
[2024-04-29 22:21:19.884] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.886] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "n"
}
[2024-04-29 22:21:19.893] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.895] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "e"
}
[2024-04-29 22:21:19.903] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.904] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": " "
}
[2024-04-29 22:21:19.912] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.913] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "X"
}
[2024-04-29 22:21:19.921] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.923] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "S"
}
[2024-04-29 22:21:19.931] [INFO] Returning embeddings (not shown in logs)
[2024-04-29 22:21:19.932] [INFO] Received POST request to /v1/embeddings with body: {
  "model": "nomic-ai/nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.Q8_0.gguf",
  "input": "S"
}
[2024-04-29 22:21:19.940] [INFO] Returning embeddings (not shown in logs)

Are there known steps to reproduce?
No response

What did you set as Max embedding chunk length when configuring the connection?

1000

Same issue here. The problem is independent of the chosen embeddings model in lm studio (tested with the lm studio standard embedder nomic-embed-text-v1.5-GGUF and with the all-MiniLM-L6-v2). The user prompt is sent to the lm studio embedder in individual letters via POST each by each and not as a whole expression.

Thank you so much for fixing this so quickly. I've tried out the docker image and it works great. Although, I was wondering how long before this change is reflected in the Appimage?

@frost19k Thank you for pointing out this error!
As for desktop, we typically try to push at least a patch version per-week. Usually Wed/Thurs, any updates from master since the preceding patch will appear in the next version.

Confirmed working on v1.5.2 !
Query is not sent to embedding endpoint as a single sequence.


[Fix] Typo in readme

Simple fix to a typo in readme.

Thank you very much!

You are most welcome sir.


KIP-569-KAFKA-9494: DescribeConfigsResponse - include additional metadata information

Implements KIP-569
Adds documentation and type of ConfigEntry in version 3 of DescribeConfigsResponse
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ok to test

retest this please

retest this please

Looks like the last PR build failed with checkstyle failures: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2602/

retest this please

Test failures not related, merging to trunk and 2.6.


Keyvault backed Secret Scope Using Databricks CLI

[Enter feedback here]
Keyvault backed Secret Scope Using Databricks CLI  is lacking information, Please add required information to create keyvault based secret scope from Databricks CLI.
"You need an Azure AD user token to create an Azure Key Vault-backed secret scope with the Databricks CLI. You cannot use an Azure Databricks personal access token or an Azure AD application token that belongs to a service principal."
Please provide example on how to pass Azure AD user token
Thank you
Marimuthu G B

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 810a218a-80a5-2da0-b540-26347f9ef908
Version Independent ID: 41c2a12f-99b6-0faa-500b-3e4308cd00de
Content: Secret scopes - Azure Databricks
Content Source: databricks/security/secrets/secret-scopes.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@gbmarimuthu Thank you for sharing feedback. We are actively validating it. We will share updates soon.

@mssaperla Could you please validate feedback and enhance document as appropriate. Thank you.

Thanks for your dedication to our documentation. Unfortunately, we have been unable to address your issue and apologize for the delayed response. We are closing this issue, but if you feel that it's still a concern, please let us know directly at<EMAIL_ADDRESS>#please-close

#please-close


Allow users to pass in additional options

It would be nice to allow arbitrary options to be passed to #show-module that are available to themes in #style-args.options. This would allow themes to define custom options beyond the ones Tidy offers for further customization of the output. For example, a theme could allow users to pass in a primary color, that changes the style of the output.
I see two possible implementations:

#show-module collects any unknown named arguments into #style-args.options.
#show-module accepts a new parameter theme-options.

Hi @jneug ,
so you don't just want to create some theme for one-time personal use only but reuse it and add customization options?

I see two possible implementations:

#show-module collects any unknown named arguments into #style-args.options.
#show-module accepts a new parameter theme-options.

It would definitely be the second option because otherwise, I can't add arguments to show-module without potentially breaking user code.
Can you give a hint of how urgent this is to you? The reason is that I want to redesign how themes work with user-defined types. Then show-module, show-function, show-variables, etc will become types that you can customize with set and show rules which is much better and more flexible. I don't like to add new features now that will need to be changed later for this redesign. But if this is is important now, let's add it!

It's not that urgent.
This is already possible to an extent by simply post-processing the result of #parse-module and adding some keys to the dictionary.
This is only possible for functions / variables, though, because only those are passed on to the style. I think a native way to configure the style would be nice in the future.

I imagine that styles could just be types as well. They don't produce content but define some settable fields. Then they define show rules for all of the components that tidy provides (like functions, variables, type boxes) and here you can just access the settable fields of the style type.

Meanwhile ultra-style.typ defines
#type ultra-style {
  field primary = pink

  show: it => {
    show tidy.function: f => {
      set text(fill: it.primary)
      f.name
      f.description
      ...
    }
    ...
  }
}

Yes, that would be nice. Currently, theming is somewhat limited to setting show rules in the initial template functions.
I tried to circumvent this by placing #metadata in the document and creating a show rule that renders it with the theme. Like this:
// In the template file
#let themable(func) = [#metadata(func)<themable>]

#let my-template(theme) = (body) => {
  show <themable>: it => {
    (it.value)(theme)
  }
}

// In the document
#show: my-template((
  primary: red
))

#themable((theme) => text(fill: theme.primary, "Hello, World!"))

This works as a temporary workaround, but I fear it might be slow for larger documents.

This is an interesting workaround


create GenderTitleMap class

in order to support titleMap option offered by titleMapsAdapter, i create this class.
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Applicable Issues

in order to support titleMap option offered by titleMapsAdapter, i create this class.

Coverage remained the same at 0.0% when pulling a75fb71f91f78512f6e7fcf3628eef4db8e671d8 on Fakhreddine10:patch-6 into 6b9f73a3982e26b166a4a86e84bc5cc65e10036c on JsonSchema-JavaUI:master.


Feature/eks policy depends on

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

Woops, wrong repo.


textures too small

I am not sure what I am doing wrong. I opened multiple .gpk files and I have the same issue. I went to Texture2D, selected the files and went to Texture Preview. The preview is very small, only 64x64 pixels. I exported DDS files and opened them in Photoshop. Even in Photoshop they are still 64x64 pizels. These textures should be 1024x1024. The issue is not with Photoshop because I can still open old DDS files which I exported with uthelper and they are at proper resolution. Am I doing something wrong or is there a bug?

I just saw that I also added a debug info to the mipmap where it tried to locate the tfc.

Data for this MipMap is stored in tfc WorldTextures029
TFC data was not found. Searched for tfc file at I:\Programme\Steam\SteamApps\common\Tera\Client\S1Game\CookedPC\Art_Data\Packages_\WorldTextures029.tfc

In the new version it will load the tfc automatically after you set a game path.

Release is out https://github.com/GoneUp/GPK_RePack/releases/tag/v1.0


Hotfix/steam id length

Steam ID is actually 17 numbers long. Not 16 like was originally assumed.
Also, Steam URLs are not backed by SSL.  Configuring the url regex accordingly.

Isn't the ID a uint64 or something, rather than a number with a specific number of digits?

It is but the value is usually very high so hardcoding a specific number of digits is usually sufficient.

That seems... weird 😛 Let's pattern it as an actual uint64. Worst case someone could link to a 404 page.


The root chunk is huge

Currently the root map encodes the type of every dataset. Clients must download this chunk even though nobody ever really uses it.
I think that the thing to do here is to just change Noms to have this root map have the type Map<string, Ref<Value>>.

See also #2848

@arv can you estimate difficulty for this?

It makes attic UI load slowly, but it's somewhat of a temporary problem that will be addressed by other work we have planned.

Also, would it be a serialization change?

Update: I realize this might be easier because the type of this map should be Map<string, Ref<Value>>, not Map<string, Value> (the commits are out-of-line).

@rafael-atticlabs, @arv, @cmasone-attic seems like would be best options for this, but I think @rafael-atticlabs has least on his plate. Can you take it?

Here is an example of a huge root chunk (16MB) from the laudman db:
#k3s4kee1b0pnortbf94oi0hipsbei7pb


Add host aliases as an option

It may be required to set custom host aliases within the pods, this allows this functionality via an optional value.
Values example
hostAliases:
  - hostnames:
    - aaa.com
    - test.ccc.com
    ip: <IP_ADDRESS>
  - hostnames:
    - bbb.com
    ip: <IP_ADDRESS>

Please rebase and then it looks good

@lkysow merged upstream, should be up to date now


Implement issue locking functionality

Fixes #56
TODO:

[ ] Unit tets
[ ] Test in staging
[ ] Add to README

@marcbaechinger can you sanity check this and make sure it looks like what you wanted?  Then I will handle the TODOs