enable app verifier that for the script execute_ebpf_cicd_tests.ps1

App verifier needs to be enabled for all types of user tests.
CICD yml file not only includes the executable files, but also includes a power shell script "execute_ebpf_cicd_tests.ps1 " , that runs the following tests:

[ ] api_test.exe
[ ] bpftool_tests.exe
[ ] sample_ext_app.exe
[ ] socket_tests.exe
[ ] connect_redirect_tests.exe
[ ] xdp_tests.exe

There are two servers that each of them has two vms: vm1, and vm2. Github uses these servers to run cicd tests.
The following action items have been done:
Installed and enabled the app verifier for the following tests in VM1 in : "api_test.exe", "bpftool_tests.exe", "sample_ext_app.exe",      "socket_tests.exe", "connect_redirect_tests.exe".  I then installed and enable app verifier on xdp_tests.exe on vm2 .
I then ran the script to set up and execute the tests on the runner and they passed. I modified and updated the checkpoint for VM1 and started the service for the runner. The tests passed as the following:
`[21:35:16] :: Running eBPF CI/CD tests on vm1
[21:35:17] :: Executing api_test.exe
[21:35:17] :: C:\Program Files\OpenCppCoverage\OpenCppCoverage.exe -q --modules=C:\eBPF --export_type binary:api_test.exe.cov -- api_test.exe
[21:36:07] :: Randomness seeded to:<PHONE_NUMBER>
All tests passed (367 assertions in 28 test cases)
[21:36:07] :: api_test.exe Passed
[21:36:07] :: Executing bpftool_tests.exe
[21:36:07] :: C:\Program Files\OpenCppCoverage\OpenCppCoverage.exe -q --modules=C:\eBPF --export_type binary:bpftool_tests.exe.cov -- bpftool_tests.exe
[21:36:30] :: Randomness seeded to:<PHONE_NUMBER>
Running command: bpftool help
Running command: bpftool prog help
Running command: bpftool prog show
Running command: bpftool --legacy prog load map_in_map.o map_in_map
Running command: bpftool prog show
Running command: bpftool prog pin id 196637 pin2
Running command: netsh ebpf show pins
Running command: netsh ebpf delete prog 196637
Running command: bpftool prog show
Running command: bpftool --legacy prog load droppacket.o droppacket
Running command: bpftool prog show
Running command: bpftool net attach xdp id 196638 dev "Loopback Pseudo-Interface 1"
Running command: netsh ebpf delete prog 196638
Running command: bpftool prog show
Running command: bpftool map create FileName type array key 4 value 4 entries 2 name Name
Running command: bpftool map show
Running command: bpftool map dump id 65574
Running command: bpftool map create \test_map type hash key 4 value 4 entries 10 name testing
Running command: bpftool map show name testing
Running command: bpftool map show pinned \test_map
Running command: bpftool prog show id 1
Running command: bpftool --legacy prog load droppacket.o droppacket
Running command: bpftool prog show
Running command: bpftool prog run id 196639 data_in "C:\Users\ADMINI~1\AppData\Local\Temp\data_in.txt" data_out "C:\Users\ADMINI~1\AppData\Local\Temp\data_out.txt" repeat 1000000
Running command: netsh ebpf delete prog 196639
Running command: bpftool prog show
===============================================================================
All tests passed (56 assertions in 8 test cases)
[21:36:30] :: bpftool_tests.exe Passed
[21:36:30] :: Executing sample_ext_app.exe
[21:36:30] :: C:\Program Files\OpenCppCoverage\OpenCppCoverage.exe -q --modules=C:\eBPF --export_type binary:sample_ext_app.exe.cov -- sample_ext_app.exe
[21:36:58] :: Randomness seeded to:<PHONE_NUMBER>
All tests passed (76 assertions in 6 test cases)
[21:36:58] :: sample_ext_app.exe Passed
[21:36:58] :: Executing socket_tests.exe
[21:36:58] :: C:\Program Files\OpenCppCoverage\OpenCppCoverage.exe -q --modules=C:\eBPF --export_type binary:socket_tests.exe.cov -- socket_tests.exe
[21:38:32] :: Randomness seeded to:<PHONE_NUMBER>
tuple.dst_ip.ipv4 = 100007f
tuple.dst_port = 1d23
tuple.dst_port = 1d23
tuple.dst_ip.ipv4 = 100007f
tuple.dst_port = 1d23
tuple.dst_port = 1d23
All tests passed (146 assertions in 14 test cases)
[21:38:32] :: socket_tests.exe Passed
[21:38:32] :: [info] Load coverage file: api_test.exe.cov
[21:38:32] :: [info] Load coverage file: bpftool_tests.exe.cov
[21:38:32] ::
[21:38:32] :: [info] Load coverage file: sample_ext_app.exe.cov
[21:38:32] ::
[21:38:32] :: [info] Load coverage file: socket_tests.exe.cov
[21:38:32] ::
[21:38:32] :: [info] Start Program:
Modules: Selected: * Excluded:
Sources: Selected: * Excluded:
Log Level: Normal
Cover Children: 0
Aggregate by file: 1
Continue after C++ exception: 0
Optimized build support: 0
Export: cobertura c:\eBPF\ebpf_for_windows.xml
Input coverage: api_test.exe.cov bpftool_tests.exe.cov sample_ext_app.exe.cov socket_tests.exe.cov
Unified diff:
Excluded line regular expressions:
Substitute pdb source paths:
[21:38:35] :: [info] ----------------------------------------------------
[21:38:35] ::
[info] Cobertura report generated: c:\eBPF\ebpf_for_windows.xml
[info] ----------------------------------------------------
[21:38:35] :: [info] The code coverage report is not what you expect? See the FAQ https://github.com/OpenCppCoverage/OpenCppCoverage/wiki/FAQ.
[21:38:35] ::
[21:43:57] :: Allowing xdp_tests.exe test app through firewall on vm2.
Name                    : {0230df82-e6b8-436b-abf2-c31e6acb883d}
ID                      : {0230df82-e6b8-436b-abf2-c31e6acb883d}
Group                   :
Profile                 : Any
Platform                : {}
LSM                     : False
PSComputerName          : vm2
RunspaceId              : c71fe2ab-5bd6-45e7-96fd-918bb4ed8d00
Caption                 :
Description             :
ElementName             : XDP_Test
InstanceID              : {0230df82-e6b8-436b-abf2-c31e6acb883d}
CommonName              :
PolicyKeywords          :
Enabled                 : 1
PolicyDecisionStrategy  : 2
PolicyRoles             :
ConditionListType       : 3
CreationClassName       : MSFT|FW|FirewallRule|{0230df82-e6b8-436b-abf2-c31e6acb883d}
ExecutionStrategy       : 2
Mandatory               :
PolicyRuleName          :
Priority                :
RuleUsage               :
SequencedActions        : 3
SystemCreationClassName :
SystemName              :
Action                  : 2
Direction               : 1
DisplayGroup            :
DisplayName             : XDP_Test
EdgeTraversalPolicy     : 0
EnforcementStatus       : {0}
LocalOnlyMapping        : False
LooseSourceMapping      : False
Owner                   :
Platforms               : {}
PolicyStoreSource       : PersistentStore
PolicyStoreSourceType   : 1
PrimaryStatus           : 1
Profiles                : 0
RuleGroup               :
Status                  : The rule was parsed successfully from the store.
StatusCode              : 65536
[21:44:00] :: Running XDP Test1 ...
[21:44:02] :: Loading reflect_packet.o on vm1.
[21:44:03] :: Loaded with ID 65602
[21:44:03] :: Loaded reflect_packet.o with 65602
[21:44:05] :: Invoking xdp_reflect_test on vm2
[21:44:05] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:05] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (2 assertions in 1 test case)
[21:44:05] :: Executing xdp_reflect_test with remote address: 2001:db8::1.
[21:44:05] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (3 assertions in 1 test case)
[21:44:05] :: xdp_reflect_test Test Passed
[21:44:06] :: Invoking xdp_reflect_test on vm2
[21:44:06] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:06] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (2 assertions in 1 test case)
[21:44:06] :: Executing xdp_reflect_test with remote address: 2001:db8::2.
[21:44:06] :: Filters: "xdp_reflect_test"
Randomness seeded to: 981386911
All tests passed (3 assertions in 1 test case)
[21:44:06] :: xdp_reflect_test Test Passed
[21:44:08] :: Unloading program 65602 from vm1.
[21:44:08] ::
Unpinned 65602 from reflect_packet
65602
[21:44:08] :: XDP Test1 succeeded.
[21:44:08] :: Running XDP Test2 ...
[21:44:09] :: Loading reflect_packet.o on interface Ethernet on vm1.
[21:44:11] :: Loaded with ID 65604
[21:44:11] :: Loaded reflect_packet.o with 65604
[21:44:12] :: Setting program 65604 at interface Ethernet 2 on vm1.
[21:44:12] :: Ok.
[21:44:13] :: Invoking xdp_reflect_test on vm2
[21:44:13] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:14] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (2 assertions in 1 test case)
[21:44:14] :: Executing xdp_reflect_test with remote address: 2001:db8::1.
[21:44:14] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (3 assertions in 1 test case)
[21:44:14] :: xdp_reflect_test Test Passed
[21:44:15] :: Invoking xdp_reflect_test on vm2
[21:44:15] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:15] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (2 assertions in 1 test case)
[21:44:15] :: Executing xdp_reflect_test with remote address: 2001:db8::2.
[21:44:15] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (3 assertions in 1 test case)
[21:44:15] :: xdp_reflect_test Test Passed
[21:44:16] :: Unloading program 65604 from vm1.
[21:44:17] ::
Unpinned 65604 from reflect_packet
65604
[21:44:17] :: XDP Test2 succeeded.
[21:44:17] :: Running XDP Test3 ...
[21:44:18] :: Loading reflect_packet.o on interface Ethernet on vm1.
[21:44:19] :: Loaded with ID 65606
[21:44:19] :: Loaded reflect_packet.o with 65606
[21:44:20] :: Loading encap_reflect_packet.o on interface Ethernet 2 on vm1.
[21:44:22] :: Loaded with ID 196662
[21:44:22] :: Loaded encap_reflect_packet.o with 196662
[21:44:23] :: Invoking xdp_reflect_test on vm2
[21:44:23] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:23] :: Filters: "xdp_reflect_test"
Randomness seeded to: 422401772
All tests passed (2 assertions in 1 test case)
[21:44:23] :: Executing xdp_reflect_test with remote address: 2001:db8::1.
[21:44:23] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (3 assertions in 1 test case)
[21:44:23] :: xdp_reflect_test Test Passed
[21:44:25] :: Invoking xdp_encap_reflect_test on vm2
[21:44:25] :: Executing xdp_encap_reflect_test with remote address: <IP_ADDRESS>.
[21:44:25] :: Filters: "xdp_encap_reflect_test"
Randomness seeded to: 826401215
All tests passed (8 assertions in 1 test case)
[21:44:25] :: Executing xdp_encap_reflect_test with remote address: 2001:db8::2.
[21:44:25] :: Filters: "xdp_encap_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (5 assertions in 1 test case)
[21:44:25] :: xdp_encap_reflect_test Test Passed
[21:44:26] :: Unloading program 65606 from vm1.
[21:44:26] ::
Unpinned 65606 from reflect_packet
65606
[21:44:28] :: Unloading program 196662 from vm1.
[21:44:28] ::
Unpinned 196662 from encap_reflect_packet
196662
[21:44:28] :: XDP Test3 succeeded.
[21:44:28] :: Running XDP Test4 ...
[21:44:29] :: Loading encap_reflect_packet.o on vm1.
[21:44:31] :: Loaded with ID 65608
[21:44:31] :: Loaded encap_reflect_packet.o with 65608
[21:44:32] :: Loading decap_permit_packet.o on vm2.
[21:44:33] :: Loaded with ID 65538
[21:44:33] :: Loaded decap_permit_packet.o with 65538
[21:44:34] :: Invoking xdp_reflect_test on vm2
[21:44:34] :: Executing xdp_reflect_test with remote address: <IP_ADDRESS>.
[21:44:34] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (2 assertions in 1 test case)
[21:44:34] :: Executing xdp_reflect_test with remote address: 2001:db8::1.
[21:44:34] :: Filters: "xdp_reflect_test"
Randomness seeded to:<PHONE_NUMBER>
All tests passed (3 assertions in 1 test case)
[21:44:34] :: xdp_reflect_test Test Passed
[21:44:36] :: Unloading program 65608 from vm1.
[21:44:36] ::
Unpinned 65608 from encap_reflect_packet
65608
[21:44:37] :: Unloading program 65538 from vm2.
[21:44:37] ::
Unpinned 65538 from decapsulate_permit_packet
65538
[21:44:37] :: XDP Test4 succeeded.
[21:44:38] :: Allowing tcp_udp_listener.exe test app through firewall on vm1.
Name                    : {4033aa2b-fe95-485b-ba8e-8037e80e8d70}
ID                      : {4033aa2b-fe95-485b-ba8e-8037e80e8d70}
Group                   :
Profile                 : Any
Platform                : {}
LSM                     : False
PSComputerName          : vm1
RunspaceId              : 2f8a28b7-0ab5-4b50-a59b-00388a22b5df
Caption                 :
Description             :
ElementName             : Redirect_Test
InstanceID              : {4033aa2b-fe95-485b-ba8e-8037e80e8d70}
CommonName              :
PolicyKeywords          :
Enabled                 : 1
PolicyDecisionStrategy  : 2
PolicyRoles             :
ConditionListType       : 3
CreationClassName       : MSFT|FW|FirewallRule|{4033aa2b-fe95-485b-ba8e-8037e80e8d70}
ExecutionStrategy       : 2
Mandatory               :
PolicyRuleName          :
Priority                :
RuleUsage               :
SequencedActions        : 3
SystemCreationClassName :
SystemName              :
Action                  : 2
Direction               : 1
DisplayGroup            :
DisplayName             : Redirect_Test
EdgeTraversalPolicy     : 0
EnforcementStatus       : {0}
LocalOnlyMapping        : False
LooseSourceMapping      : False
Owner                   :
Platforms               : {}
PolicyStoreSource       : PersistentStore
PolicyStoreSourceType   : 1
PrimaryStatus           : 1
Profiles                : 0
RuleGroup               :
Status                  : The rule was parsed successfully from the store.
StatusCode              : 65536
[21:44:42] :: Allowing tcp_udp_listener.exe test app through firewall on vm2.
Name                    : {1a71d159-f1c8-43d3-aa11-8559088185f9}
ID                      : {1a71d159-f1c8-43d3-aa11-8559088185f9}
Group                   :
Profile                 : Any
Platform                : {}
LSM                     : False
PSComputerName          : vm2
RunspaceId              : 0281333d-5c6a-48eb-ad73-2bcf13e30511
Caption                 :
Description             :
ElementName             : Redirect_Test
InstanceID              : {1a71d159-f1c8-43d3-aa11-8559088185f9}
CommonName              :
PolicyKeywords          :
Enabled                 : 1
PolicyDecisionStrategy  : 2
PolicyRoles             :
ConditionListType       : 3
CreationClassName       : MSFT|FW|FirewallRule|{1a71d159-f1c8-43d3-aa11-8559088185f9}
ExecutionStrategy       : 2
Mandatory               :
PolicyRuleName          :
Priority                :
RuleUsage               :
SequencedActions        : 3
SystemCreationClassName :
SystemName              :
Action                  : 2
Direction               : 1
DisplayGroup            :
DisplayName             : Redirect_Test
EdgeTraversalPolicy     : 0
EnforcementStatus       : {0}
LocalOnlyMapping        : False
LooseSourceMapping      : False
Owner                   :
Platforms               : {}
PolicyStoreSource       : PersistentStore
PolicyStoreSourceType   : 1
PrimaryStatus           : 1
Profiles                : 0
RuleGroup               :
Status                  : The rule was parsed successfully from the store.
StatusCode              : 65536
[21:44:54] :: Invoking connect redirect tests on vm1
[21:44:54] :: Executing connect redirect tests with parameters: --virtual-ip-v4 <IP_ADDRESS> --virtual-ip-v6 2001:db8::100 --local-ip-v4 <IP_ADDRESS> --local-ip-v6 2001:db8::1 --remote-ip-v4 <IP_ADDRESS> --remote-ip-v6 2001:db8::3 --destination-port 4444 --proxy-port 4443
[21:45:26] :: Randomness seeded to:<PHONE_NUMBER>
AUTH: Loopback | TCP | IPv4 | No Dual Stack
AUTH: Remote | TCP | IPv4 | No Dual Stack
AUTH: Local | TCP | IPv4 | No Dual Stack
REDIRECT: Remote -> Remote | TCP | IPv4 | No Dual Stack
REDIRECT: Remote -> Loopback | TCP | IPv4 | No Dual Stack
REDIRECT: Remote -> Local | TCP | IPv4 | No Dual Stack
REDIRECT: Loopback -> Remote | TCP | IPv4 | No Dual Stack
REDIRECT: Loopback -> Local | TCP | IPv4 | No Dual Stack
REDIRECT: Local -> Loopback | TCP | IPv4 | No Dual Stack
REDIRECT: Local -> Remote | TCP | IPv4 | No Dual Stack
AUTH: Loopback | TCP | IPv4 | Dual Stack
AUTH: Remote | TCP | IPv4 | Dual Stack
AUTH: Local | TCP | IPv4 | Dual Stack
REDIRECT: Remote -> Remote | TCP | IPv4 | Dual Stack
REDIRECT: Remote -> Loopback | TCP | IPv4 | Dual Stack
REDIRECT: Remote -> Local | TCP | IPv4 | Dual Stack
REDIRECT: Loopback -> Remote | TCP | IPv4 | Dual Stack
REDIRECT: Loopback -> Local | TCP | IPv4 | Dual Stack
REDIRECT: Local -> Loopback | TCP | IPv4 | Dual Stack
REDIRECT: Local -> Remote | TCP | IPv4 | Dual Stack
AUTH: Loopback | TCP | IPv6 | No Dual Stack
AUTH: Remote | TCP | IPv6 | No Dual Stack
AUTH: Local | TCP | IPv6 | No Dual Stack
REDIRECT: Remote -> Remote | TCP | IPv6 | No Dual Stack
REDIRECT: Remote -> Loopback | TCP | IPv6 | No Dual Stack
REDIRECT: Remote -> Local | TCP | IPv6 | No Dual Stack
REDIRECT: Loopback -> Remote | TCP | IPv6 | No Dual Stack
REDIRECT: Loopback -> Local | TCP | IPv6 | No Dual Stack
REDIRECT: Local -> Loopback | TCP | IPv6 | No Dual Stack
REDIRECT: Local -> Remote | TCP | IPv6 | No Dual Stack
AUTH: Loopback | TCP | IPv6 | Dual Stack
AUTH: Remote | TCP | IPv6 | Dual Stack
AUTH: Local | TCP | IPv6 | Dual Stack
REDIRECT: Remote -> Remote | TCP | IPv6 | Dual Stack
REDIRECT: Remote -> Loopback | TCP | IPv6 | Dual Stack
REDIRECT: Remote -> Local | TCP | IPv6 | Dual Stack
REDIRECT: Loopback -> Remote | TCP | IPv6 | Dual Stack
REDIRECT: Loopback -> Local | TCP | IPv6 | Dual Stack
REDIRECT: Local -> Loopback | TCP | IPv6 | Dual Stack
REDIRECT: Local -> Remote | TCP | IPv6 | Dual Stack
AUTH: Loopback | UDP | IPv4 | No Dual Stack
AUTH: Remote | UDP | IPv4 | No Dual Stack
AUTH: Local | UDP | IPv4 | No Dual Stack
REDIRECT: Remote -> Remote | UDP | IPv4 | No Dual Stack
REDIRECT: Remote -> Loopback | UDP | IPv4 | No Dual Stack
REDIRECT: Remote -> Local | UDP | IPv4 | No Dual Stack
REDIRECT: Loopback -> Remote | UDP | IPv4 | No Dual Stack
REDIRECT: Loopback -> Local | UDP | IPv4 | No Dual Stack
REDIRECT: Local -> Loopback | UDP | IPv4 | No Dual Stack
REDIRECT: Local -> Remote | UDP | IPv4 | No Dual Stack
AUTH: Loopback | UDP | IPv4 | Dual Stack
AUTH: Remote | UDP | IPv4 | Dual Stack
AUTH: Local | UDP | IPv4 | Dual Stack
REDIRECT: Remote -> Remote | UDP | IPv4 | Dual Stack
REDIRECT: Remote -> Loopback | UDP | IPv4 | Dual Stack
REDIRECT: Remote -> Local | UDP | IPv4 | Dual Stack
REDIRECT: Loopback -> Remote | UDP | IPv4 | Dual Stack
REDIRECT: Loopback -> Local | UDP | IPv4 | Dual Stack
REDIRECT: Local -> Loopback | UDP | IPv4 | Dual Stack
REDIRECT: Local -> Remote | UDP | IPv4 | Dual Stack
AUTH: Loopback | UDP | IPv6 | No Dual Stack
AUTH: Remote | UDP | IPv6 | No Dual Stack
AUTH: Local | UDP | IPv6 | No Dual Stack
REDIRECT: Remote -> Remote | UDP | IPv6 | No Dual Stack
REDIRECT: Remote -> Loopback | UDP | IPv6 | No Dual Stack
REDIRECT: Remote -> Local | UDP | IPv6 | No Dual Stack
REDIRECT: Loopback -> Remote | UDP | IPv6 | No Dual Stack
REDIRECT: Loopback -> Local | UDP | IPv6 | No Dual Stack
REDIRECT: Local -> Loopback | UDP | IPv6 | No Dual Stack
REDIRECT: Local -> Remote | UDP | IPv6 | No Dual Stack
AUTH: Loopback | UDP | IPv6 | Dual Stack
AUTH: Remote | UDP | IPv6 | Dual Stack
AUTH: Local | UDP | IPv6 | Dual Stack
REDIRECT: Remote -> Remote | UDP | IPv6 | Dual Stack
REDIRECT: Remote -> Loopback | UDP | IPv6 | Dual Stack
REDIRECT: Remote -> Local | UDP | IPv6 | Dual Stack
REDIRECT: Loopback -> Remote | UDP | IPv6 | Dual Stack
REDIRECT: Loopback -> Local | UDP | IPv6 | Dual Stack
REDIRECT: Local -> Loopback | UDP | IPv6 | Dual Stack
REDIRECT: Local -> Remote | UDP | IPv6 | Dual Stack
All tests passed (518 assertions in 4 test cases)
[21:45:26] :: Connect-Redirect Test Passed
[21:45:28] :: Stopping eBPF components on vm1
[21:45:29] :: Stopping eBPF components on vm2
`


WIP: Refactor Timer component

As always, a couple of my small refactor attempts ended up being a larger fix 😅 Basically what this PR does are:

moves the Ends ... or Live ... label to the <Timer> component
replaces the hard-coded "YYYY-MM-DDTHH:mm:ss+-HH:mm" format specifier with moment.IOS_8601 that's more robust
converts the time to a "timezone-ed" date and shows the month, date, and hour in the user's time-zone (added moment-timezone to implement this)

Now one of the tests for the <BidResult> component depends on the machine's local timezone. We should figure out how to avoid test polutions.
Remianing Todos

[ ] fix the tests that depend on the local time zone

Fails

:no_entry_sign:

🃏 FAIL in BidResult-tests.tsx

renders winning screen properly

Snapshot has changed

Full message

Error: expect(value).toMatchSnapshot()
Received value does not match stored snapshot 1.

Snapshot

Received

@@ -94,11 +94,11 @@
undefined,
]
}
>
Live

      Jan 1, 7am

      Jan 1, 12pm
    </Text>
    <Text
      accessible={true}
      allowFontScaling={true}
      ellipsizeMode="tail"

at Object. (/home/travis/build/artsy/emission/src/lib/Components/Bidding/Screens/tests/BidResult-tests.tsx:31:16)
at Object.asyncFn (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmine_async.js:82:37)
at resolve (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:52:12)
at Promise ()
at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:39:19)
at promise.then (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:73:82)
at

renders timer and error message when bid is low

Snapshot has changed

Full message

Error: expect(value).toMatchSnapshot()
Received value does not match stored snapshot 1.

Snapshot

Received

@@ -155,11 +155,11 @@
undefined,
]
}
>
Live

    Jan 1, 7am

    Jan 1, 12pm
  </Text>
  <Text
    accessible={true}
    allowFontScaling={true}
    ellipsizeMode="tail"

at Object. (/home/travis/build/artsy/emission/src/lib/Components/Bidding/Screens/tests/BidResult-tests.tsx:51:16)
at Object.asyncFn (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmine_async.js:82:37)
at resolve (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:52:12)
at Promise ()
at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:39:19)
at promise.then (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queue_runner.js:73:82)
at

  Generated by :no_entry_sign: dangerJS

Interesting. I think I may make more sense to finish PURCHASE-133 first and figure out how we can test it as part of this PR laster. While better timezone support is something we absolutely want before release, I don't think this PR is that urgent now. Possibly we could leave this PR open for the time being and will re-visit when it becomes the right time?

Yup, makes sense.


[FEATURE] update the version of mermaid

Describe the feature you want

I drew a flowchart, it can be shown correctly in the Mermaid v8.11.2 Live Editor, but when I copy the mermaid code into the {{< mermaid >}} {{< /mermaid >}} shortcode , I got nothing on hugo server preview. Then I found the flowchart can only be used in hign version  https://mermaid-js.github.io/mermaid/#/flowchart?id=beta-flowcharts, mermaid released v8.11.2 3 days ago, but Feelit theme use v8.5.1. I'm not familiar with front end.I don't know how to update the version myself.Could you update the version of mermaid, please.

Useful reference
https://github.com/mermaid-js/mermaid/releases

First of all I had plans to update the mermaid version which I was doing on PR #54, but I had to put it on hold due to some broken internal API calls mentioned in mermaid issues #1034 which is effected on the dark-theme mode.
About the flowchart issue, it should work with the current version 8.5.1 theme-documentation#flowchart.

I tried again but it still couldn't be shown with the current version 8.5.1

I tried again but it still couldn't be shown with the current version 8.5.1

Hmm, seems like you were right.
If you are really need it ASAP you can apply the temporary workaround from #54 (All things good with your Flowchart code)

OH, I use a image instead.
Looking forward to your PR😀.
Thank you for nice work

It worked! thank u!


Doco revisions

Updated doco about markup language support
Modified parseIdentityAwareHTML BBcode parsing to support the BBcode reference which is now in /help/member/bbcode.html.
Add Bootstrap classes to tables for BBcode tables that have the border=0 or border=1 options set.

Looking over what I've got so far, there are more mistakes than I expected; but I will finish this soon so hopefully not many will notice.


adding bower.json so this library could be registered as a bower package

I've added a bower.json file that will allow this package to be registered and uploaded to the bower registry. I have not registered it, since it's your code and I wanted to give you first shot. Here's the command to do it:
bower register Leaflet.MovingMarker git@github.com:ewoken/Leaflet.MovingMarker.git

Let me know if you have any questions.

Thanks !


AWS policy attachment failure

The stack fails to deploy because of the error below. AWSLambdaFullAccess IAM policy was deprecated as of March 1, 2021 so the solution needs to be updated with a different policy.
AWS Policy deprecation: https://docs.aws.amazon.com/lambda/latest/dg/access-control-identity-based.html
aws:iam:RolePolicyAttachment (mapboxQuery4c238266-32be53a2):
error: Error attaching policy arn:aws:iam::aws:policy/AWSLambdaFullAccess to IAM Role mapboxQuery4c238266-29ca2bb: NoSuchEntity: Policy arn:aws:iam::aws:policy/AWSLambdaFullAccess does not exist or is not attachable.
status code: 404, request id: 50cf0869-c0d9-4d96-9bbd-4fc45c0a5c22

@ryanbaumann @sherylanngayle any updates with this error?
     Type                                   Name                          Status                  Info
     pulumi:pulumi:Stack                    assettracking-testing         **failed**              1 error
 +   ├─ aws:iam:RolePolicy                  iotRolePolicy                 created
 +   ├─ aws:iam:RolePolicy                  firehoserolepolicy            created
 +   ├─ aws:kinesis:FirehoseDeliveryStream  assetFirehose                 created
 +   ├─ aws:iot:TopicRule                   iotAssetIngest                created
     └─ aws:apigateway:x:API                mapboxQuery
 +      ├─ aws:iam:RolePolicyAttachment     mapboxQuery4c238266-32be53a2  **creating failed**     1 error
 +      └─ aws:lambda:Function              mapboxQuery4c238266           created

Diagnostics:
  aws:iam:RolePolicyAttachment (mapboxQuery4c238266-32be53a2):
    error: Error attaching policy arn:aws:iam::aws:policy/AWSLambdaFullAccess to IAM Role mapboxQuery4c238266-6662fab: NoSuchEntity: Policy arn:aws:iam::aws:policy/AWSLambdaFullAccess does not exist or is not attachable.
    	status code: 404, request id: 847abba1-0384-490d-94e1-957d8f312a08

  pulumi:pulumi:Stack (assettracking-testing):
    error: update failed

I got the same one

This has been fixed via a dependency update.
Please be sure to pull and install latest dependencies, and upgrade your Pulumi CLI.


Remix  messing with url fragment scrolling position

Reproduction
When using scrollrestoration in root.tsx, and clicking on an a tag for a url fragment, the browser snaps to the initial scrolling position of the page load. For example go to https://aspiring.dev/posts/frontlink, scroll down, and click on any header, it snaps the scrolling to the top. But if you click on it again, or load that page directly, it scrolls to the expected position.
If I comment out the scroll restoration component it works as expected, but obviously that's not ideal. How can I solve this? Obviously I can't see url fragments on the server so I can't conditionally render the scrollrestoration component.
The a tag is part of a dangerously insert html from an HTML string from the loader:
Minimal example for an otherwise default nodejs Remix app (this has tailwind installed as well, original Github):
import { json } from "@remix-run/node"
import { useLoaderData } from "@remix-run/react"
import { renderToString } from "react-dom/server"

export async function loader() {
  const jsx = (

        Top padding content

Hey there

  )
  const rendered = renderToString(jsx)
  return json({
    rendered,
  })
}

export default function Post() {
  const data = useLoaderData<typeof loader>()
  return (

  )
}

If you click on the A tag at the bottom, you can see it snap back to the top, but if you reload or click again it scrolls to the bottom.
System Info
System:
    OS: macOS 14.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 2.48 GB / 64.00 GB
    Shell: 5.9 - /usr/local/bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    bun: 1.0.26 - ~/.bun/bin/bun
  Browsers:
    Chrome: 121.0.6167.184
    Safari: 17.2.1

Used Package Manager
npm
Expected Behavior
Scrolling does not snap to top on first click
Actual Behavior
First click scroll snaps to top, on second click it scrolls as expected. Navigating directly to URL with fragment works as expected.

I don't think I'm seeing what you're describing?  What browser were you using?
When I go to the page and scroll down (no hash):

And then click the "We can share functions too" heading, it scrolls to that anchor as expected:

Hi, I pushed an update to remove <ScrollRestoration /> on that page in the meantime. I've switched it back so you can take a look @brophdawg11 , and I've also attached a recording. Note that you generally have to scroll decently down, somtimes if you don't scroll far enough I've noticed it just doesn't move. In the recording, you can see the second time I click the link it scrolls to the location expected
https://github.com/remix-run/remix/assets/17806508/2b46bf40-9bef-4311-b500-7b00d60302d8

It looks like this is specific to raw  tags (not <Link>, so React Router is not aware of them) used on an otherwise Remix/RR-hydrated site.  An  that only changes the hash triggers a popstate event but it's not popping back or forward to any known location so the new location (with the hash) ends up inadvertently/incorrectly inheriting a location.key = "default" and then it gets out of whack trying to restore to positions keyed by that (default it the key for the very first page of a new session).
I'll dig in a bit deeper to our history abstraction and see if this is something we can/should be detecting but the easiest way to fix/workaround it for now is to make Remix/React Router aware of those link navigations.  You can do this by detecting  clicks at a higher level and proxying them through React Router:
let navigate = useNavigate();
...
return (

 {
      if (
        !e.defaultPrevented &&
        e.target.tagName === "A" &&
        e.target.getAttribute("href") != null
      ) {
        e.preventDefault();
        navigate(e.target.getAttribute("href"));
      }
    }}>
    ...

);

That prevents the browser from sending the popstate event in the first place and React Route will now know about the navigation and treat it as a new location - and fall through to scrolling to the hash when it doesn't find a prior scroll position.
This is basically exactly what we do on the React Router and Remix websites - here's our more comprehensive solution to the snippet above: https://github.com/remix-run/react-router-website/blob/main/app/components/delegate-markdown-links.ts

That makes sense, but I won't be able to do that with the renderToString loader method I was doing since I can't stick react hooks in there.

You would do it in the component rendering the HTML so the clicks from the rendered HTML bubble to the wrapper listener:
export default function Post() {
  const data = useLoaderData<typeof loader>();
  const navigate = useNavigate();
  return (

  )
}

The behavior seems different, but also incorrect. You can only see it in the last one, but after the first one that scrolls back to the top, they all do a slight flicker up.
https://github.com/remix-run/remix/assets/17806508/e67d6ded-1250-4c52-bb17-339e87bdafcd
with code
export default function Post() {
  const data = useLoaderData<typeof loader>()
  useNavigate()
  return (

  )
}

If you can put together a minimal reproduction I can take a look (I'm on vacation next week so after that).  We're pretty confident this approach works though since it's been in use on our production sites for quite some time now :)


Build on Raspberry Pi without Docker

Hi!
I have tried to do the sd card setup script on my mac but I have run into so many issues at this point. I have a Raspberry Pi set up as a dev machine. Just to get going I was thinking I could probably build the ADK on my Raspberry Pi. The issue is that the make file seems to require the docker setup to be completed. Is there any way that I can bypass the Docker step and just compile the ADK on my Raspberry Pi?

Never mind. After reading the getting started guide i found the DOCKER=0 command that disables builds with Docker. Note to self: read the whole read me next time.😅


Bump iced 0.7

No notable change in the external dependencies.
This release include the horizontal scrollbar which will be very useful.
Self-ACK b8f1704f3873d75d80cba02861e9c5ab3dfacc2a


Overlapping Image when used in Column

I have the below code to show a zoomable image and another widget below it.
When I zoom the image to a larger scale, the image overlaps the second widget below the container.
            return Column(
              children: <Widget>[
                Expanded(
                  child: Container(
                    height: 300.0,
                    margin: const EdgeInsets.symmetric(vertical: 20.0),
                    child: PhotoViewInline(
                      imageProvider: CachedNetworkImageProvider(
                        post.imageUrl,
                      ),
                    ),
                  ),
                ),
                getFeedWidget(),
              ],
            );

The second widget is visible over the zoomable image. Ideally, user should see only the zoomable image.

You can use ClipRect around Container to avoid that overlaping.

It works.. Thanks..

Does it make sense to add example with ClipRect to readme?


Version selector

The product/version selector is no longer available in the current version of the docs.microsoft.com pages. So it would appear that the following section should be removed:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8db47b85-e178-7969-40d3-3fa83aa3fb54
Version Independent ID: a78e453b-4b8f-c885-42ee-8a9d9979f345
Content: What are access levels? What access levels are supported? - Azure DevOps
Content Source: docs/organizations/security/access-levels.md
Product: devops
Technology: devops-security
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@VitalyMCT - Thank you for your input. However, the version selector is still in operation. May I ask what browser you are using? Perhaps you could take a screenshot for us to troubleshoot. Here is the version selector I'm seeing for this article.

Sorry, my mistake! I am used to the selector being on the main page and missed that it's now on the TOC side. Please disregard.

@VitalyMCT  - Not a problem. Closing issue.


[VS Code] "Go to definition" no longer works

Issue Type: Bug
When using the context menu "Go to Defintion", nothing happens. When hitting F12, I get "Cannot read property 'startLineNumber' of undefined". This appears to be happening project wide - worked fine until the latest VS Code update. Please help!
Extension version: 1.0.2236
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
AMD Ryzen 7 2700X Eight-Core Processor          (16 x 3700)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.95GB (24.07GB free)

Process Argv
-n C:\Users\Will Resen\AppData\Local\Temp\vsliveshare\tmp-A20F47FE72F7DEA9BABAE26AB94AB14622A7\Visual Studio Live Share.code-workspace

Screen Reader
no

VM
0%

@aletsdelarosa could you have a look?

@willresen , does this only happen for a specific language? A specific project? Or it's universally broken?

Thanks for reaching out. Can you give us more details about your scenario? Also, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

@daytonellwanger  @IlyaBiryukov  I apologize for the delay. This is occurring for TypeScript definitions in all of my current projects when remotely accessing my machine via Live Share. When right clicking and clicking "Go to Definition", the inline window appears but is stuck on "Loading...". Is there a way I can see the content of these logs before sharing? It appears my access to the zip folder that is generated is being denied.

Thanks @willresen , no need for your logs just yet. Let me see if I can repro.. that'd be the easiest way for us to investigate.

Yup, it repros 😟. We'll have a look!

@aletsdelarosa is looking into it.

Hey folks, wanted to weight in and say that I'm also seeing this issue.  Is there any updates?

I believe @aletsdelarosa has gotten to the bottom of it and is putting together the fix right now, so hopefully should be out the week after next.

Hey @aletsdelarosa and @daytonellwanger just wondering if there was there any update on this or is there something that could be contributed to helping solve the issue?

Hello @TheHandsomeCoder it is in PR now. It should be working next week

Hi! Any update on this?
I can try to provide any more debug data if any is needed. I've got it fully reproducible on my machine, and would be happy to help if there's anything I can do or any more logs I can provide.

I'm still seeing in VS Code - Insiders.

I would love an update as well, this is still an issue. Happy to provide logs or testing.

Maybe this logs help. Log from window
[2020-09-09 15:16:15.373] [renderer3] [error] ENOENT: no such file or directory, unlink '/home/<USER_HOST>/.local/share/vsliveshare/cascade.json': Error: ENOENT: no such file or directory, unlink '/home/<USER_HOST>/.local/share/vsliveshare/cascade.json'
[2020-09-09 15:16:33.246] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:16:33.853] [renderer3] [error] Cannot read property 'startLineNumber' of undefined: TypeError: Cannot read property 'startLineNumber' of undefined
    at Function.collapseToStart (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:660:950)
    at W._openReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:929)
    at W._onResult (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:604)
    at file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2753:246
[2020-09-09 15:16:42.416] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:38:10.531] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:41:35.080] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)
[2020-09-09 15:41:36.827] [renderer3] [error] Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined'): Error: Unable to read file '/undefined' (Error: Unable to resolve non-existing file '/undefined')
    at b.doReadAsFileStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1730:591)
    at async M.doRead (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6506:9)
    at async M.readStream (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6505:661)
    at async e.loadFromFile (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6419:488)
    at async w.resolve (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6501:865)
    at async b.createModelReference (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6431:875)

@aletsdelarosa Any updates?

Hey @aletsdelarosa / @daytonellwanger , just checking in if there has been any movement on this bug? Again if there's anything we can do to assist with getting it over the line please let us know, it's an incredibly useful feature.

Hey @aletsdelarosa / @daytonellwanger, circling back on this as it's still an issue :/ Is there any update you could share on the on going work?

Yes! @smvanderweide is currently working on this issue, and it should be resolved soon. Thank you for your patience!

My Christmas spirit tells me they're preparing us a Christmas present 🎁

Hey @daytonellwanger, sorry to keep pushing on this, but I was wondering if there was any updates

Hey @daytonellwanger, sorry to keep pushing on this, but I was wondering if there was any updates

Hey @TheHandsomeCoder , no worries. Sorry for the delay. It will be fixed in our release this week! I'll ping this thread then to make sure it's finally resolved. Thanks for your patience.

Hey @TheHandsomeCoder , no worries. Sorry for the delay. It will be fixed in our release this week! I'll ping this thread then to make sure it's finally resolved. Thanks for your patience.

The fix for this has now been deployed to the marketplace. Thanks again for your patience and help in resolving this issue. Please let us know if you run into any issues, otherwise, I'll go ahead and close this as resolved 👍

The fix for this has now been deployed to the marketplace. Thanks again for your patience and help in resolving this issue. Please let us know if you run into any issues, otherwise, I'll go ahead and close this as resolved 👍


TransactionsTable: null reference error

TypeError: Cannot read properties of null (reading 'type') on the new transactions table.

1


Does v-a-s need to handle the assist intent?

@nshmyrev , v-a-s handling the assist intent leads to it being prompted as a possible assistant (which it doesn't do successfully on Android). Does including an ability to handle this intent satisfy a mission-critical feature on the Wear/CM, or can this be removed?
(this lead to some confusion in #33, and is a consistent fail case for me where if i accidentally set as assistant, I have to uninstall and re-install the app to my device.)

No idea to be honest, needs investigation. But if there is a bug we can fix it obviously.
We certainly do not target an assistant (dicio can do that), just voice input.


DD_TAGS, DD_DOCKER_LABELS_AS_TAGS and Datadog Agent Logs

I would have thought that setting DD_TAGS or enabling DD_DOCKER_LABELS_AS_TAGS would add the labels to the Log Explorer tags for us to use and sort our logs with. Is this intended behaviour or are we doing something wrong?
Thanks in advance!

Hello @segersniels,
Using those variables should indeed add those tags to both your metrics and logs.
So if this does not work, there is probably something to be looked into.
Would you mind sharing some more details about what you did so we can replicate?
For instance:

Is the agent already running when you set the environment variables DD_TAGS or DD_DOCKER_LABELS_AS_TAGS?
What value do you set for the environment variable?
Is the agent running on the host or as a container?
Are the metrics for the corresponding container properly tagged with the new values?
Would you mind sharing the result of the status command of the agent?

Thanks a lot.

Thanks for the fast response @NBParis ,

The agent is running as an ECS container.
{ "name": "DD_TAGS", "value": "environment:${environment} project:${project} region:${region}" }
{ "name": "DD_DOCKER_LABELS_AS_TAGS", "value": "true" }

==============
Agent (v6.5.2)
==============

  Status date: 2018-10-08 14:33:54.096273 UTC
  Pid: 351
  Python Version: 2.7.15
  Logs:
  Check Runners: 4
  Log Level: info

  Paths
  =====
    Config File: /etc/datadog-agent/datadog.yaml
    conf.d: /etc/datadog-agent/conf.d
    checks.d: /etc/datadog-agent/checks.d

  Clocks
  ======
    NTP offset: 110µs
    System UTC time: 2018-10-08 14:33:54.096273 UTC

  Host Info
  =========
    bootTime: 2018-09-28 07:01:51.000000 UTC
    kernelVersion: 4.14.67-66.56.amzn1.x86_64
    os: linux
    platform: debian
    platformFamily: debian
    platformVersion: buster/sid
    procs: 73
    uptime: 245h33m6s
    virtualizationRole: guest
    virtualizationSystem: xen

  Hostnames
  =========
    ec2-hostname: ip-10-4-2-218.eu-west-1.compute.internal
    hostname: i-0cf22cc300dabf51a
    instance-id: i-0cf22cc300dabf51a
    socket-fqdn: 6a77fc5a8182
    socket-hostname: 6a77fc5a8182
    hostname provider: aws
    unused hostname providers:
      configuration/environment: hostname is empty
      gce: unable to retrieve hostname from GCE: status code 404 trying to GET http://<IP_ADDRESS>/computeMetadata/v1/instance/hostname

=========
Collector
=========

  Running Checks
  ==============

    cpu
    ---
        Instance ID: cpu [OK]
        Total Runs: 475
        Metric Samples: 6, Total: 2,844
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    disk (1.3.0)
    ------------
        Instance ID: disk:e5dffb8bef24336f [OK]
        Total Runs: 476
        Metric Samples: 156, Total: 74,256
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 61ms

    docker
    ------
        Instance ID: docker [OK]
        Total Runs: 475
        Metric Samples: 403, Total: 192,443
        Events: 0, Total: 17
        Service Checks: 1, Total: 475
        Average Execution Time : 33ms

    elastic (1.7.1)
    ---------------
        Instance ID: elastic:34f5409c995e455c [OK]
        Total Runs: 476
        Metric Samples: 175, Total: 83,300
        Events: 0, Total: 1
        Service Checks: 2, Total: 952
        Average Execution Time : 24ms

        Instance ID: elastic:89924994ba2a0c2b [OK]
        Total Runs: 476
        Metric Samples: 170, Total: 80,920
        Events: 0, Total: 1
        Service Checks: 2, Total: 952
        Average Execution Time : 18ms

    file_handle
    -----------
        Instance ID: file_handle [OK]
        Total Runs: 476
        Metric Samples: 5, Total: 2,380
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    io
    --
        Instance ID: io [OK]
        Total Runs: 475
        Metric Samples: 52, Total: 24,664
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    load
    ----
        Instance ID: load [OK]
        Total Runs: 476
        Metric Samples: 6, Total: 2,856
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    memory
    ------
        Instance ID: memory [OK]
        Total Runs: 476
        Metric Samples: 17, Total: 8,092
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    network (1.6.1)
    ---------------
        Instance ID: network:2a218184ebe03606 [OK]
        Total Runs: 476
        Metric Samples: 20, Total: 9,520
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

    ntp
    ---
        Instance ID: ntp:b4579e02d1981c12 [OK]
        Total Runs: 476
        Metric Samples: 1, Total: 476
        Events: 0, Total: 0
        Service Checks: 1, Total: 476
        Average Execution Time : 0s

    uptime
    ------
        Instance ID: uptime [OK]
        Total Runs: 476
        Metric Samples: 1, Total: 476
        Events: 0, Total: 0
        Service Checks: 0, Total: 0
        Average Execution Time : 0s

========
JMXFetch
========

  Initialized checks
  ==================
    no checks

  Failed checks
  =============
    no checks

=========
Forwarder
=========

  CheckRunsV1: 475
  Dropped: 0
  DroppedOnInput: 0
  Errors: 0
  Events: 0
  HostMetadata: 0
  IntakeV1: 49
  Metadata: 0
  Requeued: 0
  Retried: 0
  RetryQueueSize: 0
  Series: 0
  ServiceChecks: 0
  SketchSeries: 0
  Success: 999
  TimeseriesV1: 475

  API Keys status
  ===============
    API key ending in 25784 for endpoint https://app.datadoghq.com: API Key valid

==========
Logs Agent
==========

  container_collect_all
  ---------------------
    Type: docker
    Status: Error: read unix @->/var/run/docker.sock: use of closed network connection
    Inputs: 6e92a415cfe9be8f191ad3749e3c0e03de4aed734632c10598aaacb841cf26dd 6379c8e49f684e7d6e69607765cc933ec35bb08194d0d469b64fe8c3a14a9567 65abfb732c02c4974506876c82bbc646e2d62eb70d4a87316c106182471d54ba e06390d4e13d3fb96e76eaedb2a9f59971d843186dd1cda65f6269630219cb6b 80a5360d2086fef996c37995a641436893c11239e1262744d4eaf2c56170c04c f8d7928f9e6ad2fb34fd221a63070fcef88bc433ce615779a4e1c281de0d1ac7 50ea658b23857ab4209413ba1bb2b1bb48a7c3b16ac9e514264f0a044690b82d 18689028c592d4775647ec73a98c1ac7fa2a3626e193e4271497f5d86333d08b c84b12ca73462f6fe1eeb8dfb083a547bb4a16601b456ef5274d77a7a3a11569 b5dd9b223491f4954de159fbfd33d5c6e99f2d6cec46ecbf598195b712ccb026 aab755a767fe8711b3701e215e4779611177500988d2edb14b5e13320d7e6a8c 451a43e8abed4d0bce2a9666d000d5e4b5ab9c871a99c0561887bff64e1dc2dd 378f0bf2eb5358dd65b4386473ae967a5a1c1a5d47cab62c00f819024bc0aa53 02cc15f3b16c3b777d4bea63559e721899d5a328a19fdf07897a4ecbbe95ec75 9979425e08012f109e9c7b5b1d0842ef20e0e3d0ef5ae5ddbc4011741c96ccd8 342cca04adee8a504b4ff9fc72ef351a8f903973646be34588f9c52a27160c65 077a00d69197f551b1d65cf96c45ebcdf9e72802ffc4b5f0e9c1af7d04f69dc2 7f21b10329f03af2e7e8816841b5a95691447d94be25a11b447683905f049d1e 9531f779241c1867f568a9079fff54988ecb02e1c161c52110cd20b17833dd5a

=========
DogStatsD
=========

  Checks Metric Sample: 492,708
  Event: 20
  Events Flushed: 20
  Number Of Flushes: 475
  Series Flushed: 426,256
  Service Check: 8,096
  Service Checks Flushed: 8,557
  Dogstatsd Metric Sample: 1,901

            "mountPoints": [
                {
                    "sourceVolume": "docker_sock",
                    "containerPath": "/var/run/docker.sock",
                    "readOnly": true
                },
                {
                    "sourceVolume": "passwd",
                    "containerPath": "/etc/passwd",
                    "readOnly": true
                },
                {
                    "sourceVolume": "proc_mounts",
                    "containerPath": "/host/proc/",
                    "readOnly": true
                },
                {
                    "sourceVolume": "cgroup",
                    "containerPath": "/host/sys/fs/cgroup",
                    "readOnly": true
                }
            ]

fwiw - the same container is also visible in the "live containers" , and there all labels are visibile. just not in the log console

not sure if this relevant - running the agent in debug:
 (tagger.go:79 in Init) | starting the tagging system
 (tagger.go:151 in tryCollectors) | docker tag collector successfully started
| (tagger.go:149 in tryCollectors) | ecs_fargate tag collector cannot start: Failed to connect to task metadata API, ECS tagging will not work
 (tagger.go:151 in tryCollectors) | ecs tag collector successfully started

.. I think DD_COLLECT_LABELS_AS_TAGS can't be just yes , but needs to be a comma separated var
https://github.com/DataDog/docker-dd-agent

well what do you know some containers get the tags , others don't.  And the difference as far I can see is: those who don't spit out json get the labels, others don't. not sure this is really the difference ...

.. I think DD_COLLECT_LABELS_AS_TAGS can't be just yes , but needs to be a comma separated var
https://github.com/DataDog/docker-dd-agent

It seems that this was the case indeed, tried adjusting true to the correct JSON environment variable it normally needs and seems to have fixed the issue.
{
    "name": "DD_DOCKER_LABELS_AS_TAGS",
    "value": "{\"environment\":\"environment\", \"project\":\"project\"}"
}

This now displays the labels as tags in the Log Explorer. A shame that DD_TAGS still isn't working but at least we're getting our tags showing up now 🎉

Thanks a lot @jedi4ever and glad to know that your issue is now fixed @segersniels.
Regarding DD_TAGS, I double checked internally and it looks properly setup.
To help us further investigate, would it be possible to send a flare to<EMAIL_ADDRESS>and reference this issue so we can investigate why this environment variable is not correctly taken into account?

@NBParis The flare has been sent 📦

Perfect, thanks.
I'll sync with the support team to make sure they also update this issue with their findings.

Is there any update on the DD_TAGS issue? I am also finding this environmental variable is not working and the tags are not being extracted, as they were in v5 of the agent.
I am in contact with DD support but it would also be good to get an update straight from the developers of the agent.
I have sent debug logs for the tagger module to DD support in a ticket, they contain various IP addresses so I don't want to post here.

Hello @danjamesmay, would you have the id of your support case?
That will help us to correlate with all the information you already provided there.

Absolutely, it’s 181423.
Please let me know if there is any additional information I can provide to help you debug.

On 27 Nov 2018, at 19:07, Nils<EMAIL_ADDRESS>wrote:
Hello @danjamesmay, would you have the id of your support case?
That will help us to correlate with all the information you already provided there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Is there any update to this issue? I have been advised to use DD_DOCKER_LABELS_AS_TAGS instead, which is not ideal.
Will you support DD_TAGS again?

Hey all,
Apologies for the delay on this - I double checked and DD_TAGS works as expected on my end. For logs, metrics and overall metadata.
To note, I checked on GKE not on ECS (this should not matter but for the sake of the investigation, I'd rather share my conf).
I think the DD_DOCKER_LABELS_AS_TAGS issue was addressed, let me know if this still causes issues.
As for the DD_TAGS I deployed with:
DD_TAGS=log-tag:value foo testing:bar  in the env var of my deployment and we can see those in the metadata of my host:

And looking at the logs:

And finally in my metrics:

Could you confirm if you are using the DD_TAGS with spaces between the key:value (or key) ?
Looking at the initial message:
{ "name": "DD_TAGS", "value": "environment:${environment} project:${project} region:${region}" }
besides environment project and regions are already collected, it'd be great if you could share your conf so I can better investigate.
Best,
.C

Just to help summarize for anyone who might still be confused as I certainly was, the DD_TAGS and DD_DOCKER_LABELS_AS_TAGS use very different notation.  Unfortunately they have two different doc pages with examples for each, https://docs.datadoghq.com/agent/docker/#environment-variables. and https://docs.datadoghq.com/tagging/assigning_tags/?tab=go#environment-variables respectively.  To summarize, the DD_TAGS simply needs to be a space-separated list, where the DD_DOCKER_LABELS_AS_TAGS needs to be comma-separated and encapsulated in a curly brace.
Also, if anyone is trying to start the dd agent container via docker run command and are trying to pass these environment variables as runtime parameters, note that you should encapsulate your entire parameter with single quotes so that the spaces and double quotes are enclosed.  I also found that I needed to remove the single quotes encapsulating the curly brace block.
My docker run params for example:
-e 'DD_TAGS=com.here.clustername:dcos-dev project:dcos dcos-license-usage node-type:agent'
-e 'DD_DOCKER_LABELS_AS_TAGS={"com.here.marathon_app_id":"com.here.marathon_app_id","com.here.environment":"com.here.environment","com.here.role":"com.here.role","com.here.dc":"com.here.dc","com.here.app_id":"com.here.app_id"}'

Thanks @dwasikow for the summary!
We will update the doc accordingly as soon as possible to reflect the correct setup for docker run and docker compose.
Closing the issue.

@CharlyF Sorry for reviving this issue but I see the same behavior as @jedi4ever described in the comment above.
We don't use DD_DOCKER_LABELS_AS_TAGS at all and our DD_TAGS=k8s-cluster:xxx aws-account:yyy. The tags are correctly shown on the host:

If the log entry doesn't have attributes, the host tags applied correctly:

The very next log entry coming from the same container (notice container_id) doesn't have k8s-cluster and aws-account tags:

It seems that the host is parsed from the attributes and that prevents DD_TAGS from being applied.

That's a question for @NBParis

Hey @mironov / @hkaj
Actually I have the answer to this.
The agent doesn't send the host tags along the logs. Datadog joins them in the backend thanks to the hostname set in the logs.
This is why, if the hostname is coming from the log in the JSON attribute host and if it doens't match with what we have in our backend (the name in the infralist for instance), the host tags won't be attached to the log.
You will have to change this attribute called host in your logs, as the tag mapping happens before the attribute remapping. You cannot change the name in a pipeline.
Let me know if you have further questions!
Simon

@Simwar Thank you for the explanation. As you suggested, we changed the host attribute, and that fixed the issue for us.


Timeouts can be reported as deterministic errors

There is some situation where a timeout can happen and be reported as a deterministic error, as these logs indicate:

2022-05-20 01:08:59
May 20 01:08:59.492 DEBG Subgraph stopped, WASM runtime thread terminated, sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

2022-05-20 01:08:59
May 20 01:08:59.490 ERRO Subgraph instance failed to run: Failed to call 'asc_type_id' with 'String'    wasm backtrace:     0: 0x2622 - <unknown>!generated/schema/Epoch#get:id       1: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       2: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type   : wasm trap: interrupt  wasm backtrace:     0: 0xffffffff - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/allocate     1: 0x2622 - <unknown>!generated/schema/Epoch#get:id       2: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       3: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type    in handler `handleCrossChainEpochOracle` at block #12069788 (5a725bbd871dc2a2174d7da4e777fa2efb17f4725a51f51dbc15e5fc6b6fe836), code: SubgraphSyncingFailure, sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

2022-05-20 01:08:59
May 20 01:08:59.073 ERRO Subgraph error 1/1, code: SubgraphSyncingFailure, error: Failed to call 'asc_type_id' with 'String'    wasm backtrace:     0: 0x2622 - <unknown>!generated/schema/Epoch#get:id       1: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       2: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type   : wasm trap: interrupt  wasm backtrace:     0: 0xffffffff - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/allocate     1: 0x2622 - <unknown>!generated/schema/Epoch#get:id       2: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       3: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type    in handler `handleCrossChainEpochOracle` at block #12069788 (5a725bbd871dc2a2174d7da4e777fa2efb17f4725a51f51dbc15e5fc6b6fe836), block_hash: 0x5a725bbd871dc2a2174d7da4e777fa2efb17f4725a51f51dbc15e5fc6b6fe836, block_number: 12069788, sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

2022-05-20 01:08:59
May 20 01:08:59.073 INFO Applying 1 entity operation(s), block_hash: 0x5a725bbd871dc2a2174d7da4e777fa2efb17f4725a51f51dbc15e5fc6b6fe836, block_number: 12069788, sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

2022-05-20 01:08:58
May 20 01:08:58.769 INFO Done processing trigger, gas_used:<PHONE_NUMBER>3948, data_source: DataEdge, handler: handleCrossChainEpochOracle, total_ms: 1202248, transaction: 0xc391…35d7, to: 0xae6a…6836, function: crossChainEpochOracle(bytes), sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

2022-05-20 01:08:56
May 20 01:08:56.579 ERRO Handler skipped due to execution failure, error: Failed to call 'asc_type_id' with 'String'    wasm backtrace:     0: 0x2622 - <unknown>!generated/schema/Epoch#get:id       1: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       2: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type   : wasm trap: interrupt  wasm backtrace:     0: 0xffffffff - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/allocate     1: 0x2622 - <unknown>!generated/schema/Epoch#get:id       2: 0x3662 - <unknown>!generated/schema/GlobalState#get:networkArrayHead       3: 0x45bf - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type   , handler: handleCrossChainEpochOracle, sgd: 300247, subgraph_id: QmTpWTHihFbE9tgz1BE6QaJEQk9GXkzGENeF7AEheriu8J, component: SubgraphInstanceManager

The latest version of wasmtime no longer supports these interrupts but has other ways to support timeouts. So upgrading wasmtime would likely make timeout handling more robust and possibly avoid this issue.

Still relevant as we haven't updated wasmtime.

Looking at another occurence of this, it actually looks like an issue specific to the runtime assuming that traps from asc_type_id are always deterministic, which is incorrect since some traps are non-deterministic.

I have also been facing the same issue with my  subgraph for rarible exchange v2.
Subgraph instance failed to run: Failed to call 'asc_type_id' with 'String' wasm backtrace: 0: 0x331a - <unknown>!src/utils/matchAssetOneSide 1
I would request someone to please look into this issue.

Same on our end:
Handler skipped due to execution failure, error: Failed to call 'asc_type_id' with 'String' wasm backtrace: 0: 0x3146 -<EMAIL_ADDRESS>1: 0x3247 - <unknown>!generated/templates/PublicLock/PublicLockV11/PublicLockV11#try_tokenURI 2: 0x6584 - <unknown>!src/public-lock/handleLockMetadata : wasm trap: interrupt wasm backtrace: 0: 0xffffffff - <unknown>!node_modules/@graphprotocol/graph-ts/global/global/id_of_type 1: 0x3146 -<EMAIL_ADDRESS>2: 0x3247 - <unknown>!generated/templates/PublicLock/PublicLockV11/PublicLockV11#try_tokenURI 3: 0x6584 - <unknown>!src/public-lock/handleLockMetadata , handler: handleLockMetadata

Our subgraph code has a loop which is extra long for this token...
    if (
      !baseTokenURI.reverted &&
      baseTokenURI.value !== event.params.baseTokenURI
    ) {
      for (let i = 0; i < totalKeys.toI32(); i++) {
        const keyID = genKeyID(event.address, `${i + 1}`)
        const key = Key.load(keyID)
        if (key) {
          const tokenURI = lockContract.try_tokenURI(key.tokenId)
          if (!tokenURI.reverted) {
            key.tokenURI = tokenURI.value
            key.save()
          }
        }
      }
    }

Happening on QmZVK5VQ6LMm95nySe6opamptTCVVAG2yB3mFyCC1U2PrL

Thank you!!


In waveform_tutorial, please don't start with finite radius waveforms.

Most people should never use finite radius waveforms.  In the tutorial, it would be better to start with COM-corrected extrapolated waveforms, and then later have a section that says something like "If you really really need finite radius waveforms (say for debugging the extrapolated waveforms), here's what to do." and then talks about how to get finite radius waveforms.

PR #6


tweaks for Scala 2.12 community build compatibility

oh never mind I see you already made the changes
fyi https://github.com/scala/community-builds/pull/334


Add a menu when we Right click the Tour

Right click the tour in the tree should allow:

edit the tour (add, remove steps)
edit the title and description

I just checked in support for changing the title/description, and let's track editing the tour via #3. I'll publish the marketplace update this afternoon 👍

This change has just been published to the marketplace!


Add a clarification inside the example webpage.

As discussed in issue #176, the package has to be built using
$ npm run build
or
$ npm run all
before being able to use it.

Thanks for updating this!


Adding validation to avoid overloading in flush process working with …

…many workflows at same time.
Renaming some vars.

thanks a lot, we have processed your PR, soon it will be merged into public


Make "listener localhost" entry in tedge-mosquito.conf configurable via tedge config set

Describe the bug
As described in https://github.com/thin-edge/thin-edge.io/issues/758 thin-edge needs to be able to run in an dockerized environment. However mosquitto does not run since version 2.0 with the entry listener localhost as it is written by the tedge connect into the tedge-mosquitto.conf in a dockerized environment.
To Reproduce
Steps to reproduce the behavior. The more detail you add here, the better we can reproduce the bug.
Create an mosquitto container with the following config:
listener 1883 localhost
allow_anonymous true
Running the container with docker run {name}
Would result in:
1643983742: mosquitto version 2.0.13 starting
1643983742: Config loaded from /mosquitto/config/mosquitto.conf.
1643983742: Opening ipv4 listen socket on port 1883.
1643983742: Error: Address not available
Expected behavior
A clear and concise description of what you expected to happen.
We would like to be able to use something like:
tedge config set  mqtt.onlyLocalhost false
Environment (please complete the following information):
docker
Additional context

Hi @mbay-SAG, Pradeep has merged the change by #929. Could you check if we implemented as you wanted here?
The documentation is here https://github.com/thin-edge/thin-edge.io/blob/main/docs/src/howto-guides/008_config_local_mqtt_bind_address_and_port.md.


How to set the dropdown menu items height

This issue is solved. My Pull request containing the solution to this problem, was approved today by @Robertrobinson777 . Thanks to him


pack/unpack bug

in pack.c in pack/unpack functions in. PACK_UBYTE/PACK_BYTE case u need to define "value" as a 1 byte variable e.g.:
unsigned char value = va_arg(args, unsigned int); instead of
unsigned int value = va_arg(args, unsigned int);
Same applies for PACK_USHORT (unsinged short value = ...)
In those cases u write 4 bytes instead of 1/2 in each of fields of "UsbDaliIn in;" structure.. For PACK_UBYTE on little endian architectures LSB is 1st byte so it works "ok", with zeroing additional 3 bytes, but on big endian architecture u actually overwrite 4th byte with usable data, while zeroing first 3..
Otherwise, awesome work!
Regards,
Goran

Oops, that was a bad oversight on my part.
Will be fixed ASAP.
Thanks for reporting!

I looked at the problem and it seems to be mainly in unpack().
pack() uses unsigned int only locally (it's the smallest type va_args supports), but unpack() interprets each argument as a pointer; and there it doesn't make much sense to use int *.
I need to verify how much impact changing it will have first, but expect a patch soon.

Can you test the latest master?
This should fix your issue.

True.. Issue i noticed was in unpack only.. i wrongly assumed that same applies for pack also.. Looks good now... Thx..

I also updated the test case for pack/unpack, please run make check and see if it succeeds on your system.


Add more unit tests

@jjx
There's a lot of mocking which doesn't make me feel great, but I really want to test these parts in isolation. LMK if there are better ways of accomplishing this.

lgtm


[Install issue]: pip install chromadb stucks for an hour during Building wheel for chroma-hnswlib

What happened?
I am trying to install chromadb on amazon linux machine.
First I installed Python and Pip then I install dev tools and gcc C++.
After that I run "pip install chromadb" this command stucks at "Building wheel for chroma-hnswlib (pyproject.toml)" for about 45 minutes after which i killed the cmd..
I get same issue on amazon ubuntu also ...
please help..
Versions
Latest chromadb version, python 3.9, amazon linux
Relevant log output
[ec2-user@ip-172-31-47-224 ~]$ export HNSWLIB_NO_NATIVE=1
[ec2-user@ip-172-31-47-224 ~]$ pip install chromadb
Defaulting to user installation because normal site-packages is not writeable
Collecting chromadb
  Obtaining dependency information for chromadb from https://files.pythonhosted.org/packages/ac/92/9abbb58e8b334a3c2aeca828bff8b034ea68a1947d898f3b42ae3c00ce1f/chromadb-0.4.9-py3-none-any.whl.metadata
  Using cached chromadb-0.4.9-py3-none-any.whl.metadata (7.0 kB)
Collecting requests>=2.28 (from chromadb)
  Obtaining dependency information for requests>=2.28 from https://files.pythonhosted.org/packages/70/8e/0e2d847013cb52cd35b38c009bb167a1a26b2ce6cd6965bf26b47bc0bf44/requests-2.31.0-py3-none-any.whl.metadata
  Using cached requests-2.31.0-py3-none-any.whl.metadata (4.6 kB)
Collecting pydantic<2.0,>=1.9 (from chromadb)
  Obtaining dependency information for pydantic<2.0,>=1.9 from https://files.pythonhosted.org/packages/02/bd/2c6a34eeffcc437fca7d5c4b6cf7745fcc806842de5fced482d4cdba55f0/pydantic-1.10.12-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached pydantic-1.10.12-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (149 kB)
Collecting chroma-hnswlib==0.7.2 (from chromadb)
  Using cached chroma-hnswlib-0.7.2.tar.gz (31 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Collecting fastapi<0.100.0,>=0.95.2 (from chromadb)
  Obtaining dependency information for fastapi<0.100.0,>=0.95.2 from https://files.pythonhosted.org/packages/73/eb/03b691afa0b5ffa1e93ed34f97ec1e7855c758efbdcfb16c209af0b0506b/fastapi-0.99.1-py3-none-any.whl.metadata
  Using cached fastapi-0.99.1-py3-none-any.whl.metadata (23 kB)
Collecting uvicorn[standard]>=0.18.3 (from chromadb)
  Obtaining dependency information for uvicorn[standard]>=0.18.3 from https://files.pythonhosted.org/packages/79/96/b0882a1c3f7ef3dd86879e041212ae5b62b4bd352320889231cc735a8e8f/uvicorn-0.23.2-py3-none-any.whl.metadata
  Using cached uvicorn-0.23.2-py3-none-any.whl.metadata (6.2 kB)
Collecting posthog>=2.4.0 (from chromadb)
  Obtaining dependency information for posthog>=2.4.0 from https://files.pythonhosted.org/packages/a7/73/35758818228c70348be4c3c66a76653c62e894e0e3c3461453c5341ca926/posthog-3.0.2-py2.py3-none-any.whl.metadata
  Using cached posthog-3.0.2-py2.py3-none-any.whl.metadata (2.0 kB)
Collecting typing-extensions>=4.5.0 (from chromadb)
  Obtaining dependency information for typing-extensions>=4.5.0 from https://files.pythonhosted.org/packages/ec/6b/63cc3df74987c36fe26157ee12e09e8f9db4de771e0f3404263117e75b95/typing_extensions-4.7.1-py3-none-any.whl.metadata
  Using cached typing_extensions-4.7.1-py3-none-any.whl.metadata (3.1 kB)
Collecting pulsar-client>=3.1.0 (from chromadb)
  Obtaining dependency information for pulsar-client>=3.1.0 from https://files.pythonhosted.org/packages/0c/b0/23fdf3ec7b7e780e6fb53425bff0c45b08aba3d57867c2bcc2a74aad4420/pulsar_client-3.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached pulsar_client-3.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (1.0 kB)
Collecting onnxruntime>=1.14.1 (from chromadb)
  Obtaining dependency information for onnxruntime>=1.14.1 from https://files.pythonhosted.org/packages/50/d5/f156d808c9cc59e7a8b87843a5313719d01eec7d3b17ca3f6b6f0fbee0f0/onnxruntime-1.15.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached onnxruntime-1.15.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.0 kB)
Collecting tokenizers>=0.13.2 (from chromadb)
  Obtaining dependency information for tokenizers>=0.13.2 from https://files.pythonhosted.org/packages/78/a3/a2e441b5f71db65e4d66c0e71b3269da57614f7e09367d42c440b77bcd8e/tokenizers-0.14.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached tokenizers-0.14.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (6.7 kB)
Collecting pypika>=0.48.9 (from chromadb)
  Using cached PyPika-0.48.9-py2.py3-none-any.whl
Collecting tqdm>=4.65.0 (from chromadb)
  Obtaining dependency information for tqdm>=4.65.0 from https://files.pythonhosted.org/packages/00/e5/f12a80907d0884e6dff9c16d0c0114d81b8cd07dc3ae54c5e962cc83037e/tqdm-4.66.1-py3-none-any.whl.metadata
  Using cached tqdm-4.66.1-py3-none-any.whl.metadata (57 kB)
Collecting overrides>=7.3.1 (from chromadb)
  Obtaining dependency information for overrides>=7.3.1 from https://files.pythonhosted.org/packages/da/28/3fa6ef8297302fc7b3844980b6c5dbc71cdbd4b61e9b2591234214d5ab39/overrides-7.4.0-py3-none-any.whl.metadata
  Using cached overrides-7.4.0-py3-none-any.whl.metadata (5.7 kB)
Collecting importlib-resources (from chromadb)
  Obtaining dependency information for importlib-resources from https://files.pythonhosted.org/packages/25/d4/592f53ce2f8dde8be5720851bd0ab71cc2e76c55978e4163ef1ab7e389bb/importlib_resources-6.0.1-py3-none-any.whl.metadata
  Using cached importlib_resources-6.0.1-py3-none-any.whl.metadata (4.0 kB)
Collecting bcrypt>=4.0.1 (from chromadb)
  Using cached bcrypt-4.0.1-cp36-abi3-manylinux_2_28_x86_64.whl (593 kB)
Collecting numpy>=1.22.5 (from chromadb)
  Obtaining dependency information for numpy>=1.22.5 from https://files.pythonhosted.org/packages/69/1f/c95b1108a9972a52d7b1b63ed8ca70466b59b8c1811bd121f1e667cc45d8/numpy-1.25.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached numpy-1.25.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (5.6 kB)
Collecting starlette<0.28.0,>=0.27.0 (from fastapi<0.100.0,>=0.95.2->chromadb)
  Obtaining dependency information for starlette<0.28.0,>=0.27.0 from https://files.pythonhosted.org/packages/58/f8/e2cca22387965584a409795913b774235752be4176d276714e15e1a58884/starlette-0.27.0-py3-none-any.whl.metadata
  Using cached starlette-0.27.0-py3-none-any.whl.metadata (5.8 kB)
Collecting coloredlogs (from onnxruntime>=1.14.1->chromadb)
  Using cached coloredlogs-15.0.1-py2.py3-none-any.whl (46 kB)
Collecting flatbuffers (from onnxruntime>=1.14.1->chromadb)
  Obtaining dependency information for flatbuffers from https://files.pythonhosted.org/packages/6f/12/d5c79ee252793ffe845d58a913197bfa02ae9a0b5c9bc3dc4b58d477b9e7/flatbuffers-23.5.26-py2.py3-none-any.whl.metadata
  Using cached flatbuffers-23.5.26-py2.py3-none-any.whl.metadata (850 bytes)
Collecting packaging (from onnxruntime>=1.14.1->chromadb)
  Using cached packaging-23.1-py3-none-any.whl (48 kB)
Collecting protobuf (from onnxruntime>=1.14.1->chromadb)
  Obtaining dependency information for protobuf from https://files.pythonhosted.org/packages/bb/c3/6a06208ecf0934ecaf509b51c52a6cf688586f54ae81ac65c56124571494/protobuf-4.24.3-cp37-abi3-manylinux2014_x86_64.whl.metadata
  Using cached protobuf-4.24.3-cp37-abi3-manylinux2014_x86_64.whl.metadata (540 bytes)
Collecting sympy (from onnxruntime>=1.14.1->chromadb)
  Using cached sympy-1.12-py3-none-any.whl (5.7 MB)
Requirement already satisfied: six>=1.5 in /usr/lib/python3.9/site-packages (from posthog>=2.4.0->chromadb) (1.15.0)
Collecting monotonic>=1.5 (from posthog>=2.4.0->chromadb)
  Using cached monotonic-1.6-py2.py3-none-any.whl (8.2 kB)
Collecting backoff>=1.10.0 (from posthog>=2.4.0->chromadb)
  Using cached backoff-2.2.1-py3-none-any.whl (15 kB)
Requirement already satisfied: python-dateutil>2.1 in /usr/lib/python3.9/site-packages (from posthog>=2.4.0->chromadb) (2.8.1)
Collecting certifi (from pulsar-client>=3.1.0->chromadb)
  Obtaining dependency information for certifi from https://files.pythonhosted.org/packages/4c/dd/2234eab22353ffc7d94e8d13177aaa050113286e93e7b40eae01fbf7c3d9/certifi-2023.7.22-py3-none-any.whl.metadata
  Using cached certifi-2023.7.22-py3-none-any.whl.metadata (2.2 kB)
Collecting charset-normalizer<4,>=2 (from requests>=2.28->chromadb)
  Obtaining dependency information for charset-normalizer<4,>=2 from https://files.pythonhosted.org/packages/f9/0d/514be8597d7a96243e5467a37d337b9399cec117a513fcf9328405d911c0/charset_normalizer-3.2.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached charset_normalizer-3.2.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (31 kB)
Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3.9/site-packages (from requests>=2.28->chromadb) (2.10)
Requirement already satisfied: urllib3<3,>=1.21.1 in /usr/lib/python3.9/site-packages (from requests>=2.28->chromadb) (1.25.10)
Collecting huggingface_hub<0.17,>=0.16.4 (from tokenizers>=0.13.2->chromadb)
  Obtaining dependency information for huggingface_hub<0.17,>=0.16.4 from https://files.pythonhosted.org/packages/7f/c4/adcbe9a696c135578cabcbdd7331332daad4d49b7c43688bc2d36b3a47d2/huggingface_hub-0.16.4-py3-none-any.whl.metadata
  Using cached huggingface_hub-0.16.4-py3-none-any.whl.metadata (12 kB)
Collecting click>=7.0 (from uvicorn[standard]>=0.18.3->chromadb)
  Obtaining dependency information for click>=7.0 from https://files.pythonhosted.org/packages/00/2e/d53fa4befbf2cfa713304affc7ca780ce4fc1fd8710527771b58311a3229/click-8.1.7-py3-none-any.whl.metadata
  Using cached click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
Collecting h11>=0.8 (from uvicorn[standard]>=0.18.3->chromadb)
  Using cached h11-0.14.0-py3-none-any.whl (58 kB)
Collecting httptools>=0.5.0 (from uvicorn[standard]>=0.18.3->chromadb)
  Obtaining dependency information for httptools>=0.5.0 from https://files.pythonhosted.org/packages/28/7c/5ddc99737fb141bd9077f45af23e9d3c83496b4c04bf463e4e72f57043cd/httptools-0.6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached httptools-0.6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.6 kB)
Collecting python-dotenv>=0.13 (from uvicorn[standard]>=0.18.3->chromadb)
  Using cached python_dotenv-1.0.0-py3-none-any.whl (19 kB)
Requirement already satisfied: pyyaml>=5.1 in /usr/lib64/python3.9/site-packages (from uvicorn[standard]>=0.18.3->chromadb) (5.4.1)
Collecting uvloop!=0.15.0,!=0.15.1,>=0.14.0 (from uvicorn[standard]>=0.18.3->chromadb)
  Using cached uvloop-0.17.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (4.2 MB)
Collecting watchfiles>=0.13 (from uvicorn[standard]>=0.18.3->chromadb)
  Obtaining dependency information for watchfiles>=0.13 from https://files.pythonhosted.org/packages/e1/46/c9d5ee4871b187d291d62e61c41f9a4d67d4866a89704b0ad16b6949e9bd/watchfiles-0.20.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached watchfiles-0.20.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.9 kB)
Collecting websockets>=10.4 (from uvicorn[standard]>=0.18.3->chromadb)
  Using cached websockets-11.0.3-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (129 kB)
Collecting zipp>=3.1.0 (from importlib-resources->chromadb)
  Obtaining dependency information for zipp>=3.1.0 from https://files.pythonhosted.org/packages/8c/08/d3006317aefe25ea79d3b76c9650afabaf6d63d1c8443b236e7405447503/zipp-3.16.2-py3-none-any.whl.metadata
  Using cached zipp-3.16.2-py3-none-any.whl.metadata (3.7 kB)
Collecting filelock (from huggingface_hub<0.17,>=0.16.4->tokenizers>=0.13.2->chromadb)
  Obtaining dependency information for filelock from https://files.pythonhosted.org/packages/52/90/45223db4e1df30ff14e8aebf9a1bf0222da2e7b49e53692c968f36817812/filelock-3.12.3-py3-none-any.whl.metadata
  Using cached filelock-3.12.3-py3-none-any.whl.metadata (2.7 kB)
Collecting fsspec (from huggingface_hub<0.17,>=0.16.4->tokenizers>=0.13.2->chromadb)
  Obtaining dependency information for fsspec from https://files.pythonhosted.org/packages/3a/9f/b40e8e5be886143379000af5fc0c675352d59e82fd869d24bf784161dc77/fsspec-2023.9.0-py3-none-any.whl.metadata
  Using cached fsspec-2023.9.0-py3-none-any.whl.metadata (6.7 kB)
Collecting anyio<5,>=3.4.0 (from starlette<0.28.0,>=0.27.0->fastapi<0.100.0,>=0.95.2->chromadb)
  Obtaining dependency information for anyio<5,>=3.4.0 from https://files.pythonhosted.org/packages/36/55/ad4de788d84a630656ece71059665e01ca793c04294c463fd84132f40fe6/anyio-4.0.0-py3-none-any.whl.metadata
  Using cached anyio-4.0.0-py3-none-any.whl.metadata (4.5 kB)
Collecting humanfriendly>=9.1 (from coloredlogs->onnxruntime>=1.14.1->chromadb)
  Using cached humanfriendly-10.0-py2.py3-none-any.whl (86 kB)
Collecting mpmath>=0.19 (from sympy->onnxruntime>=1.14.1->chromadb)
  Using cached mpmath-1.3.0-py3-none-any.whl (536 kB)
Collecting sniffio>=1.1 (from anyio<5,>=3.4.0->starlette<0.28.0,>=0.27.0->fastapi<0.100.0,>=0.95.2->chromadb)
  Using cached sniffio-1.3.0-py3-none-any.whl (10 kB)
Collecting exceptiongroup>=1.0.2 (from anyio<5,>=3.4.0->starlette<0.28.0,>=0.27.0->fastapi<0.100.0,>=0.95.2->chromadb)
  Obtaining dependency information for exceptiongroup>=1.0.2 from https://files.pythonhosted.org/packages/ad/83/b71e58666f156a39fb29417e4c8ca4bc7400c0dd4ed9e8842ab54dc8c344/exceptiongroup-1.1.3-py3-none-any.whl.metadata
  Using cached exceptiongroup-1.1.3-py3-none-any.whl.metadata (6.1 kB)
Using cached chromadb-0.4.9-py3-none-any.whl (421 kB)
Using cached fastapi-0.99.1-py3-none-any.whl (58 kB)
Using cached numpy-1.25.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (18.3 MB)
Using cached onnxruntime-1.15.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.9 MB)
Using cached overrides-7.4.0-py3-none-any.whl (17 kB)
Using cached posthog-3.0.2-py2.py3-none-any.whl (37 kB)
Using cached pulsar_client-3.3.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.4 MB)
Using cached pydantic-1.10.12-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.2 MB)
Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Using cached tokenizers-0.14.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.8 MB)
Using cached tqdm-4.66.1-py3-none-any.whl (78 kB)
Using cached typing_extensions-4.7.1-py3-none-any.whl (33 kB)
Using cached importlib_resources-6.0.1-py3-none-any.whl (34 kB)
Using cached certifi-2023.7.22-py3-none-any.whl (158 kB)
Using cached charset_normalizer-3.2.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (202 kB)
Using cached click-8.1.7-py3-none-any.whl (97 kB)
Using cached httptools-0.6.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (432 kB)
Using cached huggingface_hub-0.16.4-py3-none-any.whl (268 kB)
Using cached starlette-0.27.0-py3-none-any.whl (66 kB)
Using cached watchfiles-0.20.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.3 MB)
Using cached zipp-3.16.2-py3-none-any.whl (7.2 kB)
Using cached flatbuffers-23.5.26-py2.py3-none-any.whl (26 kB)
Using cached protobuf-4.24.3-cp37-abi3-manylinux2014_x86_64.whl (311 kB)
Using cached uvicorn-0.23.2-py3-none-any.whl (59 kB)
Using cached anyio-4.0.0-py3-none-any.whl (83 kB)
Using cached filelock-3.12.3-py3-none-any.whl (11 kB)
Using cached fsspec-2023.9.0-py3-none-any.whl (173 kB)
Using cached exceptiongroup-1.1.3-py3-none-any.whl (14 kB)
Building wheels for collected packages: chroma-hnswlib
  Building wheel for chroma-hnswlib (pyproject.toml) ... \

@minkuminku, You are probably running out of memory. Two alternatives here:

Use a larger instance type
Increase the swap size

great, it works on large instance with 4GB ram. Thanks


[stable/prometheus] Add env variables to stateful set

Signed-off-by: IainBowman<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Adds ability to use defined server environment variables in the stateful set
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #17544

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @mgoodness

/ok-to-test

@iainbowman
Could you resolve the conflict chart please?
stable/prometheus/Chart.yaml

Chart version updated

/assign @mgoodness

/assign zanhsieh

/assign
@iainbowman
Could you bump the chart version to latest please? Thank you.


Reconsider type inference for EwPowOp

The DaphneDSL expression 10 ^ -3 yields the unexpected result 0, since the results is returned as an integer just like the argument. It would be more intuitive to return 0.001, just like the DaphneDSL expression 10.0 ^ -3 does. To this end, we need to adapt the type inference for EwPowOp.

This sounds like a bugfix that can make it to the 0.3 milestone :thinking:


Week 18 Review Ticket

[x] Performance Task Scoring 2
[x] Model and Object Oriented Programming Hacks
[ ] CRUD Hacks for Project

I cannot get the project to load on my computer as it has the same error every time and I can't fix it. I also tried asking you but the result is still the same.

.9 Model
.9 View
.9 CPT


Fix version comparison when determining cluster model

Signed-off-by: Rex<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Travis is stuck, build passing on my branch: https://travis-ci.com/github/rexcsn/aws-parallelcluster/builds/200187095
Merging

Rex, could you add a description of the issue we're fixing with this patch? Thanks? or the wrong behaviuour we were saying before of this.

Rex, could you add a description of the issue we're fixing with this patch? Thanks? or the wrong behaviour we were saying before of this.

@enrico-usai Can you be more specific about what you're asking? What does the description given in the title of the PR not tell you that you would like to know?


jsonio: Fix parse errors on EOF

Fix an issue with jsonio.Reader where parse errors occurring at the end of an input (EOF) are often ignored or return an ambiguous EOF error.

@mattnibs: The description of the fix reminded me of a familiar bug, so I dug up #4537. Indeed, it seems to improve the error message in one of the cases described there. Whereas it looks like this on tip of main:
$ zq -version
Version: v1.14.0-6-g87deeebe

$ zq -z lines-10.ndjson
lines-10.ndjson: EOF

On your branch at commit 1d3d2c3 it's now improved to:
$ zq -version
Version: v1.14.0-7-g1d3d2c37

$ zq -z lines-10.ndjson
lines-10.ndjson: unexpected end of JSON input

FWIW, the other case shown there isn't affected.
$ zq -version
Version: v1.14.0-6-g87deeebe

$ zq -z lines-9.ndjson
lines-9.ndjson: parse error: string literal: unescaped line break

$ zq -version
Version: v1.14.0-7-g1d3d2c37

$ zq -z lines-9.ndjson
lines-9.ndjson: parse error: string literal: unescaped line break

Since you've just spent time under the hood looking at this code, maybe you'd like to make an assessment of whether unescaped line break is the best we're ever going to do for that case or if there's an opportunity to improve on that as well, such that we could declare victory on that whole issue.


Update deployment notes for image registries to include ACR as well as GHCR

This attempts to address some shortcomings in the READMEs for deploying Periscope using external image registries.
Thanks to @bravebeaver for pointing out that you can use the az aks update --attach-acr command to link an AKS cluster to an ACR.
Being able to use ACR is really handy because it allows us to publish and test images from a local filesystem (without needing to push to GitHub).
Even when it's not possible to use the attach-acr approach (which requires subscription Owner role assignment), you can still deploy a secret containing ACR credentials, so that approach is also described here.

❤🎊☕ Thanks for adding me into this review, looks good, I hope we have tested that vanilla scenario is not impacted form the kustomise file change, rest looks great! congratulations 🎉 both.

Thanks for taking a look, @Tatsinnit! The yaml file change is for manual testing during development, and isn't used in any production scenarios, so we should be good on that front.


Use mdui:PrivacyStatementURL:* for privacy policy

This issue is imported from pivotal - Originaly created at Feb 20, 2023 by Thijs Kinkhorst
Manage stores mdui:PrivacyStatementURL:* for the privavy policy URL.
EB mistakenly (since ages) uses the field coin:eula to present in the consent screen a link to the "privacy policy", this field as the name says holds the "end user license agreement", something else.
In order to give users the correct link to the privacy policy, consume the mdui:PrivacyStatementURL:* (multi lingual) field and display it in the conset screen in the place where now coin:eula is used. Also expose it in the conset API so Profile can make use of the field.
Detailed concerns:

Keep consuming coin:eula from Manage push, and pass it on in the consent API as is done now. Just no longer use this field in the consent screen
saml2 should already provide class(es) to deal with MDUI info. Maybe store it as a MDUI class for possible future extensibility with other ui elements.
mdui:PrivacyStatementURL:* is multi-lingual. Display it for the current language (i.e. if lang = NL, use mdui:PrivacyStatementURL:nl), but if this is not available; check of :en is available and use that, only if current language is not availabela and :en is not available, do not display anything.

Manage >= 7.2.5 supports sending privacystatementurl in the push  (Thijs Kinkhorst - Mar 8, 2023)

This strategy might be a good Saml2 semantically fitting way to describe the metadata:

SAML UI Metadata attributes
Spec: MDUI attributes
Based on the spec: https://docs.oasis-open.org/security/saml/Post2.0/sstc-saml-metadata-ui/v1.0/os/sstc-saml-metadata-ui-v1.0-os.html
The following mdui elements are described in section 2.1.1:
2.1.1 Element mdui:UIInfo

mdui:DisplayName A localized name for the entity operating in the containing role.
mdui:Description A localized description of the entity operating in the containing role.
mdui:Keywords Localized search keywords, tags, categories, or labels for the containing role.
mdui:InformationURL A URL to localized information about the entity operating in the containing role.
mdui:PrivacyStatementURL A URL to localized information about the privacy practices of the entity operating in the containing role.
mdui:Logo A localized logo image for the entity operating in the containing role.

Assembler
The current PUSH assembler handles most of the elements described in 2.1.1 bar the InformationURL (and the PrivacyStatementURL we are about to consume). The following section shows how/where the specific elements are currently rendered in the PushAssembler.
DisplayName
Assembled at: https://github.com/OpenConext/OpenConext-engineblock/blob/24779a264ba51439c333a92efa9b4f86d79fa280/src/OpenConext/EngineBlock/Metadata/Entity/Assembler/PushMetadataAssembler.php#L325
Description
Assembled at: https://github.com/OpenConext/OpenConext-engineblock/blob/24779a264ba51439c333a92efa9b4f86d79fa280/src/OpenConext/EngineBlock/Metadata/Entity/Assembler/PushMetadataAssembler.php#L325
Keywords
Assembled at: https://github.com/OpenConext/OpenConext-engineblock/blob/24779a264ba51439c333a92efa9b4f86d79fa280/src/OpenConext/EngineBlock/Metadata/Entity/Assembler/PushMetadataAssembler.php#L325
InformationURL
Ignored
PrivacyStatementURL
See: https://www.pivotaltracker.com/story/show/184518352 for description where to get it from the Manage PUSH message.
Logo
https://github.com/OpenConext/OpenConext-engineblock/blob/24779a264ba51439c333a92efa9b4f86d79fa280/src/OpenConext/EngineBlock/Metadata/Entity/Assembler/PushMetadataAssembler.php#L348
New assembly strategy

Assemble the mdui metadata attributes into a single coin like value object.
At first, fill both the legacy and the new mdui field
We might be able to reuse the SAML2 value objects designated to represent the multilingual metadata.
Required schema change: ALTER TABLE sso_provider_roles_eb5 mdui LONGTEXT NOT NULL
On the following release we stop updating the old fields in the roles entities.
In a final release we can also drop the columns from the roles table: ALTER TABLE sso_provider_roles_eb5 DROP display_name_en, DROP ...
Release 2 and 3 can be merged into a single release, but to be extra safe we could separate them into 2.
After successful release of an EngineBlock that uses the new aggregated mdui field, the old getters on the SP/IdP/AbstractRole entities can be removed
(Michiel Kodde - Apr 12, 2023)

Sounds like a plan. These fields are now rather custom in Manage (i.e. "description:nl", not "mdui:description:nl") and it would be good at least for EB to store them in mdui form. (Thijs Kinkhorst - Apr 12, 2023)

For logo I don't think we have language-differentiated variants in Manage now, btw. (Thijs Kinkhorst - Apr 12, 2023)


Metal plates can be spawned forever

Spawning a metal block doesn't check whether the player can actually spawn it or not

Fixed it: https://github.com/apetavern/sbox-fortwars/commit/38c9f77c2b3cfd81afc945aa56b2b40d41c95236
(also has some EyePosition/Rotation obsolete fixes)


[SUP-546] Add provenance for files written by workflows

This adds a "Where did this file come from?" section to the modal shown when viewing a file from a data table or the workspace files browser.
For files that are workflow outputs, it shows a link to the workflow and submission.

This is behind a feature flag. To enable it, run window.configOverridesStore.set({ isDataTableProvenanceEnabled: true }) in the console and reload.

@nawatts What would you think about moving this information into "More information" (which would mean changing where the estimated asterisk is displayed also)? My thoughts are:

It's odd to have "More information" be collapsible above an element that is always present.
The provenance information seems like "More information" about the file.
The dialog is getting quite tall, which I assume is the reason that "More information" is collapsible.
This dialog is pretty crazy and the information seems to have little structure. The more structure we can give it and the less information we show by default, the better.

Rebased to run tests against staging instead of dev.


Add tests and builds

I've added auto-testing and auto-build of Windows executables.
If you don't mind, could you please merge them?

For ease of merging, let me clarify the Issues in this PR and then re-pull request them.