Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache" to branch-3

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
branch-3 passed

+1 :green_heart:
compile
2m 51s
branch-3 passed

+1 :green_heart:
checkstyle
0m 37s
branch-3 passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 43s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
2m 54s
the patch passed

+1 :green_heart:
javac
2m 54s
the patch passed

+1 :green_heart:
checkstyle
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 41s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m  1s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

36m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5609

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux a20f7eaacd2d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 8e87f4758b

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
branch-3 passed

+1 :green_heart:
compile
0m 50s
branch-3 passed

+1 :green_heart:
shadedjars
6m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  7s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
shadedjars
5m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
226m 52s
hbase-server in the patch failed.

253m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5609

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2e2dee1a98ad 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 8e87f4758b

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/testReport/

Max. process+thread count
4540 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
4m 25s
branch-3 passed

+1 :green_heart:
compile
1m 24s
branch-3 passed

+1 :green_heart:
shadedjars
6m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
241m 19s
hbase-server in the patch passed.

271m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5609

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1172726bdff0 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / 8e87f4758b

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/testReport/

Max. process+thread count
4719 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5609/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[3.x] Prevent out of bound access through 'm_nodes' in SoftBodyBullet

fixes #53331. Added godot side check if index is out of bounds

Thanks!


Golden Blocks are uncraftable with crafting pipe

Hi there,
The crafting pipe seems to not be able to make many items, so far I have noticed gold blocks. #56 has this same issue but hasn't had any responses in a while. Any help would be appreciated. I am running 5.0.0 in 1.13.2

There's a lot of blocks that are not craftable with crafting pipe.
Buttons
Stone bricks
chests


Upgrade aws cli to 2.0.5

New release.

Looks like a lot of stuff for an update https://github.com/aws/aws-cli/blob/v2/CHANGELOG.rst#205
🚢

Nice idea putting the changelog in these. I may whip something up about this.


test: remove test_compute_plan_remove_intermediary_model

Description

Remove the test test_compute_plan_remove_intermediary_model.
Motivation and Context

The clean_models feature will be removed and is not supported anymore through the SDK after the merge of this PR:

https://github.com/Substra/substra/pull/283

Users are encouraged to use transient outputs instead.

Yes, test_compute_plan_transient_outputs.


feature request: allow for external or internal plugins for commands

blue-sky idea, but I can see use-cases where plugins to aider is useful:

attach a PR/MR to an issue in github/gitlab
pull/select PR/MR that should be reviewed (by querying github/gitlab APIs)
import gitlab/github issue description into context before starting to implement a feature.
import hackmd document into context (could be a design document)

aider could provide a file-based API  (file x contains context, y contains list of edited files, z contains bar), and then exec aider-foo for the /foo command, similar to how git handles external commands.

These features could potentially use hub / gh to ease the setup for the user

Thanks for making this suggestion. It's certainly an interesting idea.
I think that this is probably out of scope for the project in the near term. Although, if you have specific integrations or even ideas for implementing a more general system, I'd be happy to discuss them in terms of a draft pull request, or something along those lines.

I'm going to close this issue for now, but feel free to re-open or file a new issue any time.

Why closing @paul-gauthier ?
This is a very reasonable and super useful feature, no?


Don't return the P2SH address of a P2SH

https://github.com/bitcoin/bitcoin/commit/be066fad7d2a8f95d50667262f255ce67f49b51a added an RPC to decode a hex input script. The returned object is:
{
  "asm":"asm",   (string) Script public key
  "hex":"hex",   (string) hex encoded public key
  "type":"type", (string) The output type
  "reqSigs": n,    (numeric) The required signatures
  "addresses": [   (json array of string)
     "address"     (string) bitcoin address
     ,...
  ],
  "p2sh","address" (string) script address.
}

That "p2sh" return value is the address of a P2SH with the hex input script as the redeem script.
If the input script is already a P2SH script, this doesn't make sense (we can't wrap a P2SH in a P2SH). Only return a P2SH address if the input script is not a P2SH script.

I've opened a PR against bitcoin/bitcoin. Closing this PR.


Update ConsRiskyAssetModel.py

I think there is a minor mistake in the following method
https://github.com/econ-ark/HARK/blob/b36b8f8175568a2bac6afa58cb06198f6cb66c74/HARK/ConsumptionSaving/ConsRiskyAssetModel.py#L167-L190
The parameters for the simulated risky shock should be self. RiskyAvg and self. RiskyStd so that the simulated Risky distribution uses the true parameters instead of the age-varying beliefs.

Codecov Report

Merging #1077 (42ecb2c) into master (b36b8f8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   73.60%   73.60%
=======================================
  Files          68       68
  Lines       10477    10477
=======================================
  Hits         7712     7712
  Misses       2765     2765

Impacted Files
Coverage Δ

HARK/ConsumptionSaving/ConsRiskyAssetModel.py
85.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36b8f8...42ecb2c. Read the comment docs.


"Getting Started" page references wrong github org

The "Installation with npm" section on the Getting Started page references github.com/salesforce-ux/design-system-react, but should probably reference github.com/salesforce/design-system-react.

Thanks. Updated. https://design-system-react.herokuapp.com/getting-started/


Add example images for the test notebook

Hi @constantinpape Could you provide some examples for the example notebook so we can reproduce it easily? Either download it from somewhere (e.g. github release) or in the repo directory.

Do you mean test images for predict_images? They can be downloaded from https://github.com/stardist/stardist/releases/download/0.1.0/dsb2018.zip as explained in the comments. Feel free to update the notebook such that they are downloaded directly.

Do you mean test images for predict_images? They can be downloaded from https://github.com/stardist/stardist/releases/download/0.1.0/dsb2018.zip as explained in the comments. Feel free to update the notebook such that they are downloaded directly.

I am thinking that we only need one or two images to test whether if the prediction works.

OK, I will add an image to the notebook.

Cool, just make a PR and I am happy to take a look.


Do not require authentication for every request

Closes #74
This PR introduces the ability of making requests without providing any of the supported authentication methods using the options parameter. If for any request you specify an option like authenticate: false no error will be risen if there are no credentials set.
The changes required to accommodate this feature are minimum (although I took the opportunity and spilt up the method that builds the final request options).

@weppos let me know what you think of this proposal. If you think it's ok I'll keep working on the PR adding the authenticate option to the corresponding endpoints.

@jacegu what if as a first step we simply remove the "else" condition here?

raise Error, 'A password, domain API token or access token is required for all API requests.'

Honestly, I don't really see the reason to force the validation on the client side at the moment.

Honestly, I don't really see the reason to force the validation on the client side at the moment.

👍
Didn't think that was an option. Yeah, that works too and is simpler. I'll update the PR accordingly.

@weppos the last commit (f96ed1a) is to make sure we pin-point how option overwriting should work. I have assumed what we had there before this PR is the expected behaviour, but I'd like to double check.

Although I don't think this was a necessary optimization at this point, I did a tiny benchmark just for fun and tweaked the implementation accordingly. I used the number of hashes allocated after 100 calls to the whoami endpoint and queried ObjectSpace to see the effects.
Here are the results:

Original implementation: :T_HASH=>1328
Refactored implementation: :T_HASH=>1462
Latest implementation: :T_HASH=>1291

The latest solution has the benefit of both worlds: splitting up the option generation in tinier methods to make it more readable and reducing the number of allocated hashes to do so. (I still feel odd modifying parameters but I'll survive since this done in  private methods).

I've updated the benchmark results after making sure that the GC wasn't interfering in the output.

:shipit:


Add support for Java 9 multi release jars #61

A property for library jar exclusions (libraryJarExclusion)

technically LGTM, maybe the parameter-name could be something better. @wvengen what do you think about this new parameter/PR?

@cmorty any objections?
@liamsharp Github shows that there may be an indentation mismatch. Could you please check that you're using the right indentation?

@liamsharp ping?

@wvengen Whitespace fixed up, I've created a new pull request:
https://github.com/wvengen/proguard-maven-plugin/pull/75

@wvengen Created another pull request, only found 1 indentation issue:
https://github.com/wvengen/proguard-maven-plugin/pull/76

Closing this since the new fixes are in https://github.com/wvengen/proguard-maven-plugin/pull/76


Editting Bug

Please check the list below to make sure we can provide you with the best possible support :star:

I have provided a code example.
https://codepen.io/amandaIaria/pen/arwwqJ

If I encountered an issue I have provided:

a description of the actual and expected behavior
see below
what version of Conversational Forms I am using
latest/cdn
what browser and version I am using
Chrome
the output of the browser console
See below

At first, we thought it might be an edge case, but after testing with a few test users found that they were seeing it.
If you are, let's say, a few questions in and need to edit the first question. It lets you edit it, but it doesn't bring you back to the correct question you left off of. This isn't even with questions that would be inserted dynamically.
Then sometimes after editing the question and going to the next question one, and answering that question, it would go to the to the previous one of that one. Then shoot out an error:
conversational-form.min.js:4 Uncaught DOMException: Failed to execute 'appendChild' on 'Node': The new child element contains the parent.

I have a quick time video that shows what is going on. Along with the full error in the console
https://youtu.be/5Mb-6ZZf0vE

I may have found the culprit, but I'm not sure how to go about with it. This particular bug seems to go away when I not doing any validation in the flowback method.
When I comment out my switch statement that looks at the tags, for example this is the switch statement.
switch(dto.tag.id){
 case "specific_id":
  if(dto.tag.value[0] === "Yes") {
       methodToStopForm();
   }
 break;
}

It won't do that weird behavior as shown in the video. It'll remove the other answers and start as if you started at that answer. In this example, the answer ends the form, removes the textbox, and doesn't allow you to edit your answers.
Another point, could this flowback switch statement not be working with the formless conditions? For instance in the JSON cf-conditional-specific_id?

Another thing I found is that this behavior only happens when I'm looking for a specific tag. AKA
if(dto.tag.id == "specific_id"){
  console.log(dto.tag.id);
}

Even doing something as simple as that breaks it.
Which is how your documentation is saying it should be done in https://space10-community.github.io/conversational-form/docs/0.9.90/functionality/validation/
However, I might (I need to do some more testing) found a solution. Instead of using dto.tag.id, it seems that dto.tag.name does not do the above behavior.

Hi @amandaIaria. I'll make sure to take a look later today and try to help you out.

For the moment I've had to switch to the regular form version instead of the formless. I still haven't been able to pinpoint an exact cause other than guessing what it might be.

@amandaIaria with your custom validation. Have you made sure that you always call either success() or error()?
Any chance you can post a Codepen that would replicate the error? Then I can take a look and work with it on my end.

Outside of my switch, I have a return success() since there's no need to have it in. Otherwise, there is always a return error(). I'll have to recreate it with more questions.

@amandaIaria I'll close this one for now. Feel free to post again when you have more and we can re-open.


NIFI-4258 Corrected a bug with the 'Informix Unload Escape Disabled' CSV format.

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[✓] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[✓] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[✓] Has your PR been rebased against the latest commit within the target branch (typically master)?

[✓] Is your initial contribution a single, squashed commit?

For code changes:

[✓] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[N/A] Have you written or updated unit tests to verify your changes?
[N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[N/A] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@Wesley-Lawrence great catch! Verified that the fix works. +1 merged to master.


dynamic data input

[data]="someFn()"
setting: lazyLoading = true;
Whenever you search
if the data source is populated from dynamic source, following errors
ERROR TypeError: Cannot read property 'toString' of null
at eval (eval at  (app.js:789), :325:34)
at Array.filter ()
at AngularMultiSelect.filterInfiniteList (eval at  (app.js:789), :323:23)
at Object.eval [as handleEvent] (AngularMultiSelect.html:106)
at handleEvent (eval at  (vendor.js:6), :13768:155)
at callWithDebugContext (eval at  (vendor.js:6), :15277:42)
at Object.debugHandleEvent [as handleEvent] (eval at  (vendor.js:6), :14864:12)
at dispatchEvent (eval at  (vendor.js:6), :10183:25)
at eval (eval at  (vendor.js:6), :10808:38)
at HTMLInputElement.eval (eval at  (vendor.js:123), :2680:53)
at ZoneDelegate.invokeTask (eval at 1277 (polyfills.js:435), :398:31)
at Object.onInvokeTask (eval at  (vendor.js:6), :4961:33)
at ZoneDelegate.invokeTask (eval at 1277 (polyfills.js:435), :397:36)
at Zone.runTask (eval at 1277 (polyfills.js:435), :165:47)

Because data input is not a function type.


Remove modsecurity-override.conf that is now in the upstream image

Fix for #32

@timwsuqld Can you rebase and push again? Let's see if that fixes the build and we can merge this one

@fzipi Rebased

Ok, catched this error in a new run:
 2021/06/11 18:35:03 [emerg] 1#1: "modsecurity_rules_file" directive Rules error. File: /etc/modsecurity.d/modsecurity-override.conf. Line: 46. Column: 22. SecDefaultActions can only be placed once per phase and configuration context. Phase 1 was informed already.  in /etc/nginx/conf.d/modsecurity.conf:2
 nginx: [emerg] "modsecurity_rules_file" directive Rules error. File: /etc/modsecurity.d/modsecurity-override.conf. Line: 46. Column: 22. SecDefaultActions can only be placed once per phase and configuration context. Phase 1 was informed already.  in /etc/nginx/conf.d/modsecurity.conf:2

And clearly, both files are different. Maybe we need to merge them in one?

After sorting contents in both, this is the diff:
❯ diff src/etc/modsecurity.d/modsecurity-override.conf ../modsecurity-docker/src/etc/modsecurity.d/modsecurity-override.conf
5c5,6
< SecAuditLog /var/log/modsec_audit.log
---
> SecAuditLog ${MODSEC_AUDIT_LOG}
> SecAuditLogFormat ${MODSEC_AUDIT_LOG_FORMAT}
8c9,10
< SecAuditLogType Serial
---
> SecAuditLogStorageDir ${MODSEC_AUDIT_STORAGE}
> SecAuditLogType ${MODSEC_AUDIT_LOG_TYPE}
10c12,15
< SecDataDir /tmp/
---
> SecDataDir ${MODSEC_DATA_DIR}
> SecDebugLog ${MODSEC_DEBUG_LOG}
> SecDebugLogLevel ${MODSEC_DEBUG_LOGLEVEL}
> SecDefaultAction "phase:1,pass,log,tag:'${MODSEC_TAG}'"
20c25
< SecResponseBodyMimeType text/plain text/html text/xml
---
> SecResponseBodyMimeType ${MODSEC_RESP_BODY_MIMETYPE}
23c28,29
< SecTmpDir /tmp/
---
> SecTmpDir ${MODSEC_TMP_DIR}
> SecTmpSaveUploadedFiles on
24a31,32
> SecUploadDir ${MODSEC_UPLOAD_DIR}
> SecUploadFileMode 0644

I think all the variables related to modsecurity config should be at the base docker, not crs.

Will provide a patch for base.

Hey @timwsuqld!
I needed to update a bit the PR and created #33 . Needed to add/change some variables to get this working, because in the override in this repo some variables were being set.

@timwsuqld Thans for this patch. Sadly, more changes were needed in the two images, and I've extended this one in #35 , which was merged.
So I'm closing this one.


Sort the CHANGELOG entries chronologically

There should be only one level of sorting, not two levels of sorting
with different directions (which made finding out what has changed
latest a real brain-twister).

The changelog was formatted like this because it provides a compromise between the desire to read changelogs chronologically and the desire not to have to scroll too much to find the starting point. But I agree, it can be confusing, so let’s change it.


Series Review Portal Project - Kanban Board

This is a Kanban Board setup for the Series Review Portal Project.
The group has only two members.
Below is the link to our project repository:
https://github.com/anyars-encarta/Series-Review-Portal/projects/1

Hi @anyars-encarta and @Omwomo 👏 👏,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
Assigned tasks to the group members correctly ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


feat: Android support

Summary
Adds support for Android devices, fixes: #89
How did you test this change?
Manually  tested on a Samsung Galaxy Tab S8 Ultra

Thanks @luisdavim

@luisdavim I want to use the https://github.com/cli/gh-extension-precompile action for this in the future.
Can you please open a PR on there as well?


Patch CVE-2023-32681 in python-requests

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch CVE-2023-32681 in python-requests
Change Log

CVE-2023-32681

Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-32681

Test Methodology

Buddy Build

AMD64
ARM64

Thanks @hbeberman for the review and approval.
Addressed your comments and reran the Buddy builds once again. Both of them went fine. Here are the results

AMD64
ARM64


Changes to The Codeunit: "Library - Report Dataset"

Hi All,
I am a new developer and I have created a report in AL. I want to test this but I can't seem to access the "Library - Report Dataset" CodeUnit. I have also checked this CodeUnit in the C/AL version of this CodeUnit, I can't seem to find the functions you are referring to on this page.
Has there been any updates to this CodeUnit? Is there a reason I can't access this in AL? I have downloaded the symbols for this my al files recently on Visual Studio Code, so I'm not sure why I can't access this.
Any Help would be greatly appreciated and I hope I'm Posting on the right place.
Many Thanks,
David

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a986f99e-5a44-7759-d893-fe9f5e45345a
Version Independent ID: 347e8c25-eb22-b75a-f390-c4118f47ee5d
Content: Testing Reports - Business Central
Content Source: dev-itpro/developer/devenv-testing-reports.md
Service: dynamics365-business-central
GitHub Login: @ailie13
Microsoft Alias: solsen

Hi all I found the solution to my query, remember to check your application app file to ensure that it contains the specific objects you require. I had multiple app files thus, whichever file was being used did not have library codeunits.


chore: bdd-spring-1588818484 to 0.0.1

chore: Promote bdd-spring-1588818484 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


confluent-platform: update 5.3.0 -> 5.5.0

Motivation for this change
The conluent cli is not open source anymore and now distributed as a binary.
Updated versions and build so that it build again.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/358

Result of nixpkgs-review pr 91231 run on x86_64-linux 1

1 package built:

confluent-platform

Result of nixpkgs-review pr 91231 run on x86_64-darwin 1

1 package built:

confluent-platform

Closing this as the whole thing moved, i will reopen with a more recent version Soon TM


How to use cpu usage as a way of resource monitors？

Envoy's resource monitors only supports memory.:
extensions.resource_monitors.fixed_heap.v3.FixedHeapConfig
So why doesn't envoy support CPU as a resource monitor? Now I want to use cpu usage as resource monitor, how to do it?

cc @KBaichoo

why doesn't envoy support CPU as a resource monitor?

No one has gotten around to doing so yet.

Now I want to use cpu usage as resource monitor

I'm curious of the problem you're trying to solve with a CPU resource
monitor, can you elaborate?

how to do it?

Would be creating a resource monitor extension for CPU. You could get this
information from a few places: /proc, getrusage(), netlink. Whether we want
this per thread, or for the process is another element to dig into; e.g.
it's possible that a single worker gets saturated but the others are idle. Whether to do cpu usage per client e.g. to prevent one client from dominating.


nixos/nixos-option: Show values inside aggregate options uniformly

This makes aggregates of submodules (including the very important
nixos-option users.users.<username> case) behave the same way as any
other you-need-to-keep-typing-to-get-to-an-option-leaf (eg:
"nixos-option environment").

Before e0780c5:
  $ nixos-option users.users.root
  error: At 'root' in path 'users.users.root': Attribute not found
  An error occurred while looking for attribute names. Are you sure that 'users.users.root' exists?

After e0780c5 but before this change, this query just printed out a raw
thing, which is behavior that belongs in nix eval, nix-instantiate --eval, or nix repl <<<:
  $ nixos-option users.users.root
  {
    _module = {
      args = { name = "root"; };
      check = true;
    };
    createHome = false;
    cryptHomeLuks = null;
    description = "System administrator";
    ...

After this change:
  $ nixos-option users.users.root
  This attribute set contains:
  createHome
  cryptHomeLuks
  description
  extraGroups
  group
  hashedPassword
  ...

For aggregates of other types (not submodules), print out the option
that contains them rather than printing an error message.

Before:
  $ nixos-option environment.shellAliases.l
  error: At 'l' in path 'environment.shellAliases.l': Attribute not found
  An error occurred while looking for attribute names. Are you sure that 'environment.shellAliases.l' exists?

After:
  $ nixos-option environment.shellAliases.l
  Note: showing environment.shellAliases instead of environment.shellAliases.l
  Value:
  {
    l = "ls -alh";
    ll = "ls -l";
    ls = "ls --color=tty";
  }
  ...

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @chkno

First of all thanks a lot for your hard and continuous work on nixos-option! I'm actually pretty happy about the rewrite, the new implementation is way easier to work with and seems way more stable!

It doesn't make sense to me for options to be treated differently based on whether they're submodules or not.

Fair enough. The thing is, I'd really love to see this for submodule roots while I don't consider it that important for attr sets with options (like users) since the latter is part a well-defined structure.

I agree that dumping the values of options is much more helpful to humans than just their names. This seems true to me whether or not the option is in a submodule or not -- compare users.users.root (a submodule) and powerManagement (not a submodule):

:+1: If we fix this for both cases, I'm fine with this as well :)

I don't know if it makes sense to make this the default format, though. The current content-free format is much faster to print, more robust against broken configs with errors or circular references or whatever, doesn't ever surprise you by usually printing ~10 lines and occasionally printing ~10,000, and is very easy to parse with scripts, which makes me fear that changing it would break someone's scripts.

:+1:

I added the -r flag to this PR.
$ nixos-option -r users.users.root
users.users.root.createHome = false;
users.users.root.cryptHomeLuks = null;
users.users.root.description = "System administrator";
users.users.root.extraGroups = [ ];
users.users.root.group = "root";
users.users.root.hashedPassword = null;
users.users.root.home = "/root";
...

$ nixos-option -r powerManagement
powerManagement.cpuFreqGovernor = null;
powerManagement.cpufreq.max = null;
powerManagement.cpufreq.min = null;
powerManagement.enable = true;
powerManagement.powerDownCommands = "";
powerManagement.powerUpCommands = "";
powerManagement.powertop.enable = false;
powerManagement.resumeCommands = "";
powerManagement.scsiLinkPolicy = null;

@chkno thanks!


Please add information pertaining to Managed Identities to the "Deploy Bicep files by using GitHub Actions" page

Some MS documentation pages recommend to use Managed Identities in favor of Service Principals.
Would you mind elaborating on how to apply a Managed Identity to the below mentioned page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 697f2ea2-3710-1e09-2f3d-51394d780158
Version Independent ID: 382e3393-910c-7359-ccd3-fe5f26884288
Content: Deploy Bicep files by using GitHub Actions - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/deploy-github-actions.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

Thanks for the question! We are currently investigating and will update you shortly.

@SetTrend - thanks for this feedback. Is the information you are looking for covered in this Learn module?

@SetTrend - I am going to work with some of the identity writers to see if we can clarify the options. It will take us some time to get everyone together. In the meantime, here are a couple of links that may be helpful:

Application and service principal objects in Azure Active Directory
Glossary: Microsoft identity platform

Thanks, @tfitzmac, for all you efforts!
A page classifying all these terms, providing concise explanations and relations, would be very helpful.
Currently, the missing information is blocking me from taking an educated architectural decision.

For now, I tried …

StackOverflow
MS Tech Community

Currently, Azure doesn't support building a static web app using Azure DevOps, according to the MS documentation team, you can only create a full build pipeline using GitHub Actions. Yet, this step still needs documentation.
I'm paying a VS Enterprise subscription. Is there any channel I can use to get this issue solved on fast track?

We have a new feedback system in place, so we need to close the remaining GitHub issues. I have created an issue in our internal tracking system.
#please-close


make env properties optional

A follow-up to #6175
I believe this should be marked as optional, as well as to make it consistent with the other properties
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

nice catch


visualization of the trained PPO mode

Excellent work and paper! One question is, during the training of PPO or SAC, evaluations of the model are conducted. Is there any corresponding visualization of the trained PPO model? Thank you.

Hi, the RL and safe RL evaluation results will be saved in the run_baselines/[ppo/sac/sac_lag/ppo_lag] folder. You can open it with tensorboard.
For example:
tensorboard --logdir=. --port=8080

Hi, the RL and safe RL evaluation results will be saved in the run_baselines/[ppo/sac/sac_lag/ppo_lag] folder. You can open it with tensorboard.
For example: tensorboard --logdir=. --port=8080

Thank you for your response. What I would like to ask about is the visualization effects of the trained model in the simulator.

Hi, if u want to visualize each episode, you can try to set "use_render=True" in config.py. Otherwise, if you want to import the model from checkpoint and then visualize the evaluation process, you can run the following demo code. Note: need to change the path.
import os
import ray
from ray.rllib.agents.ppo import PPOTrainer
from pe_rlhf.utils.human_in_the_loop_env import HumanInTheLoopEnv
def visualize_trained_model(exp_path, ckpt_idx):
ray.init(ignore_reinit_error=True)
# Construct the checkpoint path
ckpt = os.path.join(exp_path, f"checkpoint_{ckpt_idx}", f"checkpoint-{ckpt_idx}")

# Initialize the PPO trainer with the environment
trainer = PPOTrainer(env=HumanInTheLoopEnv)

# Restore the trained model
trainer.restore(ckpt)

# Configure the environment for rendering
env_config = {
    "manual_control": True,
    "use_render": True,
    "controller": "keyboard",
    "window_size": (1600, 1100),
}
env = HumanInTheLoopEnv(env_config)

# Reset the environment
obs = env.reset()

done = False
while not done:
    # Compute actions using the trained model
    action = trainer.compute_action(obs)

    # Step the environment
    obs, reward, done, info = env.step(action)

    # Render the environment
    env.render()

# Close the environment
env.close()

if name == 'main':
# Example usage
exp_path = '/home/sky-lab/codes/PE-RLHF/pe_rlhf/run_baselines/PPO/PPO_HumanInTheLoopEnv_ce692_00004_4_seed=400_2024-06-11_17-49-05'
ckpt_idx = 209  # Specify the checkpoint index
visualize_trained_model(exp_path, ckpt_idx)

Thank you for your answer！

Haha, feel free to cite our paper if you find our project helpful in your task: https://arxiv.org/abs/2409.00858

Haha, feel free to cite our paper if you find our project helpful in your task: https://arxiv.org/abs/2409.00858

Of course, your paper is excellent and has been very helpful to me. I've recently been trying to apply reinforcement learning in environments built on world models for self-driving trajectory prediction. Have you tried anything in this direction?

Hi, I have no experience in the area of world model. Yes, I am recently doing some work on VLM with RL on Carla simulator. If this aspect can help you, feel free to reach out and we absolutely can work something together~

Sure, I'll send my contact information to your email.


ApiTests: add TreeView tests

Add TreeView tests for TreeViewNode and TreeViewGroup such as: creation, adding elements, subscribing to events and changing properties

Moved to Jira: https://reddata.atlassian.net/browse/GROK-13200


Development documentation

Should have documentation for Developers explaining how to set up the dev environment, and contribute

/assign @n3wscott

/cc @n3wscott

@nachocano is the doc we have now and the website enough?

@nachocano is the doc we have now and the website enough?

Yes, this is pretty old. Closing

Feel free to reopen if you feel more details are needed


docs: mkdocs redirect for migrated sdk pages

Issue being fixed or feature implemented
Following a discussion on Discord about these docs, they were migrated to dashplatform.readme.io. This redirects the existing pages to the new location to remove one more source of doc site confusion.
This is the same as #1263 except that it is not from my fork so it will hopefully pass the check it was hung up on.
What was done?

Redirects the https://dashpay.github.io/platform/ SDK pages to the location they were migrated to.
How Has This Been Tested?

Merged the changes on my fork to verify the docs that are built actually do the redirects.
Breaking Changes

N/A
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

@shumkov Can you merge this? It doesn't relate to any Platform code - only the config of the mkdocs-based site. Some tests are failing so I'm not able to merge it myself.

@antondash @markin-io @shumkov are one of you able to merge this? The tests aren't really relevant to what was done here so it shouldn't matter if they pass.

@shumkov Can you please merge? :pray:


fix(plugin-feed): remove unneeded dependencies

Deploy preview for spb-frontend processing.
Built with commit e33716a1b3c58f967de61d1128ff6495a489bd8b
https://app.netlify.com/sites/spb-frontend/deploys/5be8d95d05c4175147adab73


fort.15 error when running Shinnecock test on Hera

cd /scratch2/COASTAL/coastal/save/shared/working/takis/shinnecock-pahm-tests-hera/sandy-atmesh-adcirc

spinup completes successfully, but hotstart fails with the following error:
 Zachary.Burnett@hfe08  shinnecock-pahm-tests-hera/sandy-atmesh-adcirc
 > cat runs/unperturbed/ADCIRC_SETUP_unperturbed.err.log
forrtl: severe (59): list-directed I/O syntax error, unit 15, file /scratch2/COASTAL/coastal/save/shared/working/takis/shinnecock-pahm-tests-hera/sandy-atmesh-adcirc/runs/unperturbed/fort.15
Image              PC                Routine            Line        Source
adcprep<PHONE_NUMBER>697ECE  Unknown               Unknown  Unknown
adcprep<PHONE_NUMBER>6CEC60  Unknown               Unknown  Unknown
adcprep<PHONE_NUMBER>40F1A6  presizes_mp_sizeu        1257  presizes.F
adcprep<PHONE_NUMBER>42D06F  prepinput_                436  adcprep.F
adcprep<PHONE_NUMBER>42BB2B  MAIN__                    239  adcprep.F
adcprep<PHONE_NUMBER>40B65E  Unknown               Unknown  Unknown
libc-2.17.so       00002B342B996555  __libc_start_main     Unknown  Unknown
adcprep<PHONE_NUMBER>40B569  Unknown               Unknown  Unknown
srun: error: h10c51: task 0: Exited with exit code 59
srun: launch/slurm: _step_signal: Terminating StepId=20249771.1

here are the differences between fort.15
 Zachary.Burnett@hfe08  shinnecock-pahm-tests-hera/sandy-atmesh-adcirc
 > diff spinup/fort.15 runs/unperturbed/fort.15
6c6
< 0                                                               ! IHOT                                - HOT START PARAMETER
---
> 567                                                             ! IHOT                                - HOT START PARAMETER
17,18c17,18
< 0                                                               ! NWS                                 - WIND STRESS AND BAROMETRIC PRESSURE OPTION PARAMETER
< 1                                                               ! NRAMP                               - RAMP FUNCTION OPTION
---
> 17                                                              ! NWS                                 - WIND STRESS AND BAROMETRIC PRESSURE OPTION PARAMETER
> 8                                                               ! NRAMP                               - RAMP FUNCTION OPTION
24,25c24,26
< 12.25                                                           ! RNDAY                               - TOTAL LENGTH OF SIMULATION (IN DAYS)
< 12.25                                                           ! DRAMP                               - DURATION OF RAMP FUNCTION (IN DAYS)
---
> 2                                                               ! WTIMINC                             - meteorological data time increment
> 16.4583                                                         ! RNDAY                               - TOTAL LENGTH OF SIMULATION (IN DAYS)
> 12.250 0.000 0.000 0.000 12.250 12.250 1.000 0.000 12.250       ! DRAMP                               - DURATION OF RAMP FUNCTION (IN DAYS)
39,40c40,44
< -5 0.000000 12.250000 1800                                      ! NOUTGE TOUTSGE TOUTFGE NSPOOLGE     - GLOBAL ELEVATION OUTPUT INFO (UNIT 63)
< -5 0.000000 0.000000 1800                                       ! NOUTGV TOUTSGV TOUTFGV NSPOOLGV     - GLOBAL VELOCITY OUTPUT INFO (UNIT 64)
---
> 0 0 0 0                                                         ! NOUTM TOUTSM TOUTFM NSPOOLM         - METEOROLOGICAL STATION OUTPUT INFO (UNITS 71/72)
> 0                                                               ! NSTAM                               - TOTAL NUMBER OF METEOROLOGICAL RECORDING STATIONS
> -5 0.000000 16.458333 1800                                      ! NOUTGE TOUTSGE TOUTFGE NSPOOLGE     - GLOBAL ELEVATION OUTPUT INFO (UNIT 63)
> -5 0.000000 16.458333 1800                                      ! NOUTGV TOUTSGV TOUTFGV NSPOOLGV     - GLOBAL VELOCITY OUTPUT INFO (UNIT 64)
> 0 0.000000 0.000000 0                                           ! NOUTGM TOUTSGM TOUTFGM NSPOOLGM     - GLOBAL METEOROLOGICAL OUTPUT INFO
44c48
< 5 529200                                                        ! NHSTAR NHSINC                       - HOT START FILE GENERATION PARAMETERS
---
> 0 0

@pvelissariou1 @saeed-moghimi-noaa this is the current Shinnecock test using the new build scripts for NEMS+ADCIRC on Hera

I think Yuji and Andre were talking about adcprep having problems with NWS=17

We will check on this as well.
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Project Lead - Coastal Coupling
USM - Stennis Space Center
cell:<PHONE_NUMBER>
email: @.***
On Wed, Jun 30, 2021 at 7:21 AM Zachary Burnett @.***>
wrote:

I think Yuji and Andre were talking about adcprep having problems with
NWS=17
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/CoupledModelDriver/issues/108#issuecomment-871355372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APC7TP6UAZPJZMOBRK4BDMLTVMD4JANCNFSM47SF35SA
.

documenting the NWS=17 slide here:

this ike run also has the same errors:
 Zachary.Burnett@hfe03  /scratch2/COASTAL/coastal/save/shared/working/takis/storms_20210708/ike/runs/unperturbed/
 > cat ADCIRC_SETUP_unperturbed.err.log
forrtl: severe (59): list-directed I/O syntax error, unit 15, file /scratch2/COASTAL/coastal/save/shared/working/takis/storms_20210708/ike/runs/unperturbed/fort.15
Image              PC                Routine            Line        Source
adcprep<PHONE_NUMBER>697ECE  Unknown               Unknown  Unknown
adcprep<PHONE_NUMBER>6CEC60  Unknown               Unknown  Unknown
adcprep<PHONE_NUMBER>6CCFC2  Unknown               Unknown  Unknown
adcprep<PHONE_NUMBER>40E871  presizes_mp_sizeu        1068  presizes.F
adcprep<PHONE_NUMBER>42D06F  prepinput_                436  adcprep.F
adcprep<PHONE_NUMBER>42BB2B  MAIN__                    239  adcprep.F
adcprep<PHONE_NUMBER>40B65E  Unknown               Unknown  Unknown
libc-2.17.so       00002B89134B8555  __libc_start_main     Unknown  Unknown
adcprep<PHONE_NUMBER>40B569  Unknown               Unknown  Unknown
srun: error: h15c15: task 0: Exited with exit code 59
srun: launch/slurm: _step_signal: Terminating StepId=20567405.1

this run is using nws=17 and using binaries from /scratch2/COASTAL/coastal/save/shared/repositories/CoastalApp/ALLBIN_INSTALL, and appears to have the same error as above


WASM version of PathFinder.

Follow this js version https://github.com/webaverse/app/pull/2298 .
Now trying to convert it into WASM version https://github.com/webaverse/app/pull/2298#pullrequestreview-884586433.
Sibling PR: https://github.com/webaverse/app-wasm/pull/31

First step: Added detectPathVoxel() wasm function, using it instead of js detect() to recursively detect voxel.position.y for each voxel. Thus each voxel just need one wasm call now.

The functional part of PathFinder wasm version is ok.
Now can get whole waypointResult in just one wasm call.
let waypointResult = physicsManager.detectPathVoxel(npcPlayer.position, localPlayer.position, .5, 1, .5, position, quaternion, 1000, [5]);
I'll keep converting waypointResult simplification logic, and may try to improve c++ performance.

The functional part of PathFinder wasm version is ok.
Now can get whole waypointResult in just one wasm call.
let waypointResult = physicsManager.detectPathVoxel(npcPlayer.position, localPlayer.position, .5, 1, .5, position, quaternion, 1000, [5]);
Sibling PR: https://github.com/webaverse/app-wasm/pull/31#issuecomment-1047207633
I'll keep converting waypointResult simplification logic, and may try to improve c++ performance.
Also need rename detectPathVoxel() to getPath().

Converted all functions from js to wasm.
The usage remains the same https://github.com/webaverse/npc/blob/55486c9c184a2e95c2d0b2fa3cd41a3a3cd311e1/index.js#L42 .

There is a cleaner API available on class PathFinder (https://github.com/webaverse/app/pull/2386/files#diff-6a50a9c285e09666c1bfc3816458b22f3e90b9e124bb5b08b02cdfcbf85ff057R46), but that is just covering up the problem with the algorithm. There should be no cache and no cache length, for example.

I'm gonna merge this since it's progress but we still don't have working pathfinding.

Confirmed that this causes a crash in master: https://github.com/webaverse/app/issues/2463
So this PR is being reverted.


File list and editor out of sync

Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: Windows
Live Share Extension Version: 1.0.18
Target Platform or Language [e.g. Node.js]: Salesforce, Powershell
Steps to Reproduce / Scenario:

From the command line, copy a file in the workspace to the same directory with a different name.
The file should show up in the workspace file list, but it does not.  There is no way to get it to show up, i.e. pressing the refresh icon, etc.
From there, if you try to create a file with the same name from the UI, it doesn't work.
If you move or delete the file from the command line, then you can create the file with the same name from the UI and it shows up in the file list.
However it seemed like after opening the file from the list, we were no longer able to see each other's cursors or changes while editing ANY documents.

I'm attaching the log files, but this happened before the weekend and I am just reporting this now so I'm not sure the relevant data is included.
livesharelog.zip

Thanks for the excellent repro steps @dpuza-formativ ! I just tried to repro and am not seeing any issue.

Is there anything special about your setup? Am I reproing correctly?

@daytonellwanger That's the idea.  I just reproduced it again like your screen capture, from two instances on my own machine.  The other time it happened was on a real session with another user.
I'm attaching fresh logs from this latest repro:
LiveShareLogs.zip
The command is issued by the remote user.
Other than that, the only obvious difference to me is that subdirectories are specified in the command:
cp .\data-loader\config.properties.EXAMPLE .\data-loader\config.properties

Interesting. Just tried your exact repro - copy from subdirectory on the guest machine with a local Live Share session and it behaved as expected. You're on Windows with version 1.0.18 of the Live Share extension, right? What version of VS Code are you running?

That's right.  And VS Code version info is:
Version: 1.33.0 (user setup)
Commit: 0dd516dd412d42323fc3464531b1c715d51c4c1a
Date: 2019-04-04T15:14:28.026Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

I opened a different set of files in VS Code, hosted a session, and in this one it behaves correctly as you are seeing...

Odd! Would it be possible for you to send me the misbehaving set of files? Or if they contain sensitive information, could you try to produce a set of files that also has this issue that doesn't?

My students are seeing this same problem in VS 2017's version of the extension. It has been happening since the last update we applied. Didn't seem to be an issue before that. Students are providing mixed answers to when it is happening but the result is always the same. After I make a certain set of changes in my host session of LiveShare then students no longer are seeing the updates in their read only sessions. Some students find that stopping the session and connecting again resolves the issue. Others however are reporting that even if they restart their session it will refresh to the current state but they won't get updates anyway.
There doesn't seem to be any pattern to the problem but it happened last night to several students and they all reported that things were working fine until I created a new project in the solution and then renamed the auto-generated class1.cs file to another name and VS prompted to symbolically rename the typed contained in the file. Students are reporting that after that happened they stopped getting updates.

@CoolDadTx , you just started seeing this behavior with the last update? Were you doing similar activities prior to the update (e.g. creating new projects, renaming, read-only) without issues? I'm trying to figure out if I should be looking at recent changes we made, or if this is a problem that has existed in the product for a while.

Yes I've been renaming files and whatnot since we started using it last fall. Normally the class machines are not updated to the newer versions but a couple months back we started having issues related to not being able to create read-only sessions. It was ultimately found to be a bug in the code related to verbose output. However as part of that diagnostics my machine (the host session) was updated to the latest version. However the student machines are still running an older version of the software from probably middle of last year. So I guess it depends on whether the problem is on the client or server side as to whether it existed prior to the latest update.

Ah, I wonder if it may also be a problem with the interaction between newer host and older guest. We try to make the product work with all permutations of host/client versions (and try to do due-diligent testing to ensure it), but of course it's a tricky problem (there are thousands of such combinations). There have been many changes to the product since the middle of last year, so I would not be surprised if that version of the extension didn't play well with the most recent version. Would it be possible to update the student machines to the latest? Is there a reason to have auto-updates disabled on those machines?

Network policies prevent these machines from being updated. While they have started to warm up to the idea that VS can update itself they are not yet ready to allow auto-updates because one bad update will impact too many machines and they cannot support that level of maintenance.
I can see if one of the impacted student machines can be updated but we don't have sufficient privileges in most cases to do so.

I'll see if I can prepare a sanitized version of my files that reproduces the issue.  In my case, both host and guest were trying out LiveShare for the first time.  So we had both just downloaded the latest version. (Friday 4/5/2019)

@daytonellwanger I created a sanitized version of the files BUT I encountered a new problem with it and will send the logs along with the project files.  With this one, the file list would not even load for the remote user at all.
LiveShareLogs.HOST.zip
LiveShareLogs.REMOTE.zip
PROJECT.zip

I retried hosting a second session and the remote's file list shows a loading spinner indefinitely.
LiveShareLogs.REMOTE2.zip
LiveShareLogs.HOST2.zip

@dpuza-formativ thanks! The issue there is with your .gitignore file 😄 By default Live Share will not share files that git would ignore for security reasons (they could be files that contain secrets!) If you modify or delete the .gitignore file in that project, you should see the file tree load. Maybe we could give a notification to the host in this case to make it more clear that some files weren't shared.

I retried hosting a third time, and the file list loading spinner showed for less than a second, but again the file list is empty.

Did you remove the .gitignore file?

Still not seeing the original issue repro with this sample project.

I guess that's fine that .gitignored files wouldn't be shared, but it seems like it's introducing larger problems affecting non-ignored files, the file list, the editor, the whole session.
I did confirm that the files I was trying to create which started the problems are listed in the .gitignore.
As you suggest, feedback that certain files aren't being shared would also be helpful.

In the sanitized project, the gitignore is filled with asterisks :)
To reproduce it, you would have to have a file listed in gitignore, and then from the remote client, try to create that file which is in the gitignore.

But on one hand you did get farther than me in that your file list loaded...

Ah, OK. So it seems things are behaving as designed but perhaps not as expected. I'll see if we can come up with a better experience...
FYI you can disable the .gitignore behavior. Instructions here.

I think that the file list is loading for you - it's just that there's nothing to share! In the GIF I attached, I had deleted the .gitignore file because I noticed it was filled with asterisks.

I think that the file list is loading for you - it's just that there's nothing to share! In the GIF I attached, I had deleted the .gitignore file because I noticed it was filled with asterisks.

LOL... let me retry then

Ok, I figured out how to reproduce it.
Add this to your gitignore:
data-loader/cypblbjiwwjhmxpca
Then from the remote, run these commands (This part may not be necessary).  By design, you see the file appear on the host but not the remote before it is deleted by the second command.
cp .\data-loader\cypblbjiwwjhmxpca.EXAMPLE .\data-load er\cypblbjiwwjhmxpca del .\data-loader\cypblbjiwwjhmxpca
(This is the important part) Now on the remote, using the file list UI, you are able to copy and paste the file data-loader\cypblbjiwwjhmxpca.
THE BUG: Now, the file data-loader\cypblbjiwwjhmxpca APPEARS on the remote (by design it should not because it is in gitignore).  The remote can see and edit and save the file data-loader\cypblbjiwwjhmxpca (Shouldn't be able to see and edit because it is in gitignore),  Shared editing does not work, and the saved changes are not saved to the host (that part makes sense).  As this was our first experience with Live Share, this was very confusing and we burnt some significant time scratching our heads!
Thanks for all your help on this!  It's making a lot more sense now.

In case it doesn't raise notifications, just letting you know I made some edits to the above comment.

A few of my colleagues and I also have a file sync bug which has been around for a number of months. Recently after 1.0, it started happening a lot more. After experiencing it today, I think it might be this one.
The only potentially helpful information I have at this point, is that when we had the out of sync file open and actively editing, I could search for it again under the standard ctrl+p, and it would show up as two different files, one with and without the full pathname.

Thanks @jdluzen ! That is helpful information. Did you remember if you performed a rename or any source control operation before noticing the file sync bug?

We're tracking this desync issue over at issue 2086; let's continue the conversation there. This issue should now show up on that one as having referenced it, so the info you provided won't be lost.


Fix redundant enter tree notification in project export texture format

Fixes https://github.com/godotengine/godot/pull/78457#discussion_r1304242368
As Yuri correctly noted, NOTIFICATION_THEME_CHANGED happens when "The node enters the scene tree".

Thanks!


Ways to export/import network weights

Does Goro support any way of exporting/saving and then importing the trained model?

Gorgonia has a way of doing this https://gorgonia.org/how-to/save-weights/ I haven't worked this in as first class citizen, but you should be able to call Learnables() to get the differentiable weights and use gob to save them.
If you wanted to write a cleaner method for this I would be happy to review the PR!

Gorgonia has a way of doing this https://gorgonia.org/how-to/save-weights/ I haven't worked this in as first class citizen, but you should be able to call Learnables() to get the differentiable weights and use gob to save them.
If you wanted to write a cleaner method for this I would be happy to review the PR!

Saving the Learnables() was pretty straight-forward, but is there any method to import them after loading them from the file?

Saving the Learnables() was pretty straight-forward, but is there any method to import them after loading them from the file?

https://github.com/aunum/goro/blob/master/pkg/v1/model/model.go#L606 is probably the best example, that could be refactored to use a LoadLearnables() or SetLearnables() method.

https://github.com/aunum/goro/blob/master/pkg/v1/model/model.go#L606 is probably the best example, that could be refactored to use a LoadLearnables() or SetLearnables() method.

Hey, I just created a SetLearnables() method inspired by CloneLearnablesTo(). I was trying, at first, to do the same thing outside Goro, but the need to access some unexported fields, like trainBatchChain, made me go for a fork and a PR. If you could review it please @pbarker.
https://github.com/aunum/goro/pull/3

Hey, I just created a SetLearnables() method inspired by CloneLearnablesTo(). I was trying, at first, to do the same thing outside Goro, but the need to access some unexported fields, like trainBatchChain, made me go for a fork and a PR. If you could review it please @pbarker.
https://github.com/aunum/goro/pull/3

thanks for the contribution! closing with merge https://github.com/aunum/goro/pull/3

thanks for the contribution! closing with merge https://github.com/aunum/goro/pull/3


tlb.h missing for ARM build

mkdir build
cd build
cmake ../
make
from /home/linaro/Desktop/cen64/ai/controller.c:18:
/home/linaro/Desktop/cen64/vr4300/cp0.h:14:21: fatal error: tlb/tlb.h: No such file or directory
 #include "tlb/tlb.h"

I checked, and arch/arm/tlb folder and files are missing

I haven't tried the ARM build in eons. It doesn't have most of the RSP opcodes implemented, either.


LV_INDEV_POINT_MARKER bug?

i'm not sure whether it is a bug, but i don't know how to check whether everything is working as expected (may be i missed something again).
currently i've managed to make my touchscreen working and i was testing its precession with this very useful debug feature that was drawing dots.
but i was always getting cropped output. dots weren't drawn lower then 230 pixels in y (strange that it is not cropped at 255 btw).
at first i double checked the calibration functions, because i was thinking that it needs more resolution (like 64 bits), but it was not the reason.
and i've added a label to display actual coords, and i saw that touchscreen readings are correct across the whole screen. it is only this debug feature that draws on cropped screen.
the only thing that came to my mind, that the size of the default screen was not right and i've set it to the size of my screen, but i did bot helped.
it does not actually looks like the orientation is wrong, because the width of the screen is 240, not 230.
but i'm not sure about orientation tho.. don't know where to check. but buttons and labels are drawn fine and buttons are getting input as expected even in the bottom of the screen. only dots aren't drawn there.

Hi,
I checked it an really found a bug in the library!
LV_INDEV_POINT_MARKER uses the lv_rfill function from lv_draw/lv_draw_rbasic.c . Here you will a this line:
        lv_area_set(&scr_area, 0, 0, LV_HOR_RES - 1, LV_HOR_RES - 1);

It should be:
        lv_area_set(&scr_area, 0, 0, LV_HOR_RES - 1, LV_VER_RES - 1);

I never experienced this because typically I use landscape displays where LV_HOR_RES > LV_VER_RES.
I fixed this bug in dev-5.1 branch for the upcoming 5.1 release.


Update code to build static B matrix for CO and NO2

Description
The code sprint on the B matrix will come too late so we would still need to update the code for the B matrix training on this repo for CO and NO2.
Use branch https://github.com/JCSDA-internal/fv3-jedi-tools/tree/feature/test-aero-for-s4 (update and fix conflict from last update on develop).
Get ensemble data from @christophkeller with preliminary perturbation and then final (we need to look at which ensemble spread make more sense between the different perturbation flavors).
Then compute the final static B for the golden month of Aug 2021.
Requirements
Get ensemble data from @christophkeller
Acceptance Criteria (Definition of Done)
The static B matrix runs with skylab-tracegas experiment and produce resonable converge and increments.
Dependencies
Get ensemble data from @christophkeller

@mer-a-o is this finished?

@jeromebarre The code has been updated (feature/staticb-geos-cf-discover of fv3-jedi-tools) but we still need to tune it further for more reasonable results. We can either close this one and open a more specific one or just keep this open.

Closing this now, the code is there. It is now a matter of having better ensemble to train with.


[AutoRelease] t2-apicenter-2023-07-27-35985(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/4366
Live test success

issue link:https://github.com/Azure/sdk-release-request/issues/4366

/azp run prepare-pipelines

/azp run prepare-pipelines


Generalize regexp to capture DOIs

Actually, the first regexp will now also handle the altmetric case.

I have looked at examples from Elsevier, Springer, IEEE Xplore and I haven't found any false positives, but I have only looked at very few examples...

Very sorry we neglected this. It's great work. We've been caught up in release-frenzy and so I think this somehow slipped between the cracks.
There's been some refactoring since this was submitted, so it'll need a bit of massaging to get into the current codebase. But the IEEE regex is still very useful and we'll be adding it in very soon. We'll make sure to comment the code there to give you credit.

Okay. The regex is more general than just IEEE, it also covers ScienceDirect and the Altmetric embedding.


Enum traits

See #1049.

Thanks so much for this work! This all looks really good. @fridaland and I are trying to put the finishing touches on this over in #1380. We will be sure to include you as a co-author of the final commit to ensure you get credit for your work here.

thanks, sorry for the long reply, busy days. let me know if you need anything else from me, or i can help with anything.

@eLod https://github.com/thoughtbot/factory_bot/pull/1380 could use a final review, if you are interested.


render CollectTokensButton only if all required params are available

Fixes missing baseToken symbol breaks Download component #1213 .
Changes proposed in this PR:

render CollectTokensButton only if all required params are available to solve breaking issue

See #1222

title & linked issue mismatch, if this is still issue after #1222 feel free to reopen this PR and change its title


[BACKLOG-36769] Javascript related code cleanup

:warning: Build finished in 27m 53s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,plugins,ui

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.avro.input.AvroInputMetaTest.testGetFields_unknownPluginForFieldType (click to expand)
Expected exception: org.pentaho.di.core.exception.KettleStepException

Tests run: 3404, Failures: 1, Skipped: 5    Test Results

:information_source:  This is an automatic message


Add navigation path for going to JS node_modules definitions instead of .d.ts declarations

Issue Type: Bug
When I "go to definition" of module in a JavaScript project it jumps to the TypeScript types file, if available, not the actual definition. If the TypeScript types are not available it will work as expected.
In the past, VSCode maintainers have commented:

It's not that TypeScript types are blocking you from jumping to the implementation
https://github.com/microsoft/vscode/issues/68782#issuecomment-464177500

and

In general, you cannot jump to the js implementation of a npm module
https://github.com/microsoft/vscode/issues/68782#issuecomment-464158572

and

it's that there in general is not logic to examine the code of an arbitrary node module and figure out which external invocations map to which implementations in the module.

https://github.com/microsoft/vscode/issues/68782#issuecomment-464177500
but that's is so clearly just flat-out wrong. There is a separate command for navigating to TypeScript types in the Right-Click context menu: "Go to Type Definition", it appears directly beneath "Go to Definition".
To reiterate: if the TypeScript file is removed everything works as expected.
People don't want to browse TypeScript definition files when stepping through source definitions. Abstractions are leaky. We need to find out why.
VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:52:11.516Z)
OS version: Linux x64 5.0.0-16-generic

The providers for "Go to Definition", "Go To Type Definition", and "Go To Implementation" currently do the same thing. It's visible on this screencast where I call them in turn: https://asciinema.org/a/619AvvIQjd3zG7IV5MoLafVec
I'd expect that only "Go to Type Definition" goes to d.ts files. Maybe "Go To Definition" and for sure "Go to  Implementation" should go to JS files if they are the only ones with implementation. This is very serious issue because it makes it really hard to debug code of dependencies.

Any way to get this bumped to a higher priority? I go a little bit more insane every day over this :zany_face:
Also, the issues label is wrong. This has got to be considered a bug?
Also, not sure how this is a TypeScript issue, seems more like a VSCode issue to me.

It is typescript issue and it even has failing test: https://github.com/microsoft/TypeScript/pull/39426

Definitely waiting for this!

Is this issue still relevant?
Go to Source Definition available in VS Code from early June
https://code.visualstudio.com/updates/v1_68#_go-to-source-definition

Yes. It is still relevant. Go to source definition is not available on coc-tsserver see https://github.com/neoclide/coc-tsserver. More info here https://github.com/neoclide/coc-tsserver/pull/272. Thanks

Now that "Go To Source Definition" can be set as the preferred mode for "Go To Definition" (see https://github.com/microsoft/TypeScript/issues/49003#issuecomment-1499297090) I think this can be closed.

using the vim plugin coc-tsserver when I navigate to useRef, the file is still minified and unreadable.
https://github.com/user-attachments/assets/6b8f0747-9bd1-406d-b5db-d40436ddfdd1


[KubernetesManifestV0] Promote and Reject actions added

Promote action - It deploys input manifest files and if deployment strategy selected is 'Canary' then Canary deployment is deleted.

Reject action - If deployment strategy is 'Canary' it deletes canary deployment (canary and baseline objects). and if deployment strategy is not 'Canary', Error message is thrown.

Code of other actions is refactored. Common code is moved to Helper classes.

@nishubansal could you add some L0s?

You need to bump up the version of all the tasks which take a dependency on common.  New check I suppose. That's breaking your CI build.


Maya: "OCIO config" setting doesn't work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
The config path of "OCIO config" is not used yet in Maya
Expected Behavior:
Take the path of the "OCIO config" filepath if enabled instead of the soon deprecated "configFilePath" setting
Version
3.15.8-nightly.2
What platform you are running OpenPype on?
Linux / Centos
Steps To Reproduce:

Set "OCIO config" filepath in maya OP settings
See that the ocio config path in maya preferences is not set correctly (the one by default is set)

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
No response
Additional context:
No response

PR: https://github.com/ynput/OpenPype/pull/5017


Incorrect behavior of "Move newly created windows to their last known zone" setting

Microsoft PowerToys version
0.75.1
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
Requirements: 2 (or more) monitors.
Select "Keep windows in their zones when the screen resolution or work area changes".
Select "Move newly created windows to their last known zone".
Open a program and snap its window to a zone on monitor 1. Close the window. Open the program again.
✔ Expected Behavior
Window is moved to its last known zone on monitor 1.
❌ Actual Behavior
Window is moved to a zone on monitor 2 (same zone index as it was on monitor 1).
Other Software
No response

It seems I fixed this problem by resetting Powertoys (removing settings in AppData\Local\Microsoft\PowerToys\FancyZones).

I am glad you found a fix, @Avi0! I will close this issue.
If you still have problems, feel free to reopen the issue or make a new one.


Removed "Other systems integrating with remark" that does not work anymore

hello @gnab. This PR is an easypick.
You can merge it blindly :)

Merging this since it's a simple doc change. Need to investigate why the build is failing though.


Make VS 2005 integration a separate feature in the installer

Make VS 2005 integration a separate feature in the installer
This work item was migrated from CodePlex
CodePlex work item ID: '3662'
Assigned to: 'tfabraham'
Vote count: '0'

[UnknownUser@1/22/2009]
Resolved with changeset 18094.

[UnknownUser@2/21/2013]

[UnknownUser@5/16/2013]


Unknown command: patch

Hi there, I've been trying to use this for a workaround but cannot use it out of the box.
This is what I did, as per the readme
➜  ios git:(master) ✗ gem install cocoapods-patch
Successfully installed cocoapods-patch-0.0.9
Parsing documentation for cocoapods-patch-0.0.9
Done installing documentation for cocoapods-patch after 0 seconds
1 gem installed
➜  ios git:(master) ✗ pod patch create folly
[!] Unknown command: `patch`
Did you mean: search?

Is there anything else I need to do? I'm using this with React-Native by the way.

Hi @aprilmintacpineda do you also have cocoa pods installed?

@dcvz i have cocoapods installed and i also get the same error message

I get this same error when I removed it from my gemfile.  Adding it to my gemfile with cocoapod gets it to work.

"pod" does not find the location of cocoapods-patch.
Check where it was installed then add the folder to the PATH environment variable so that when you type pod, your shell knows where to look for it.
Here's how you can do that:
Open up .bashrc or .zshrc file (depends on what shell you are using) in a text editor.
Add this line at the end of file:
export PATH="$HOME/.gem/ruby/2.x.0/bin:$PATH"

("2.x.0" => change to the version you have exactly)


bazel: 0.11.1 -> 0.12.0

Motivation for this change
Need an updated version for a project that I'm contributing to.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I've tested this locally in the build process for a project I'm working on, and it seems to work okay.

cc @rbvermaa

@GrahamcOfBorg build bazel

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: bazel
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: bazel
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: bazel
Partial log (click to expand)
//examples/cpp:hello-success_test                                        PASSED in 0.1s
//examples/java-native/src/test/java/com/example/myproject:hello         PASSED in 0.5s

Executed 2 out of 2 tests: 2 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
installing
post-installation fixup
patching script interpreter paths in /nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0
checking for references to /tmp in /nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0...
/nix/store/z6pn7zf1qjrzi5zfbjklws4bz8nhzl1y-bazel-0.12.0

ping @philandstuff

I don't think I'm really qualified to maintain this package any more. It's
undergone significant changes since I put myself forward, and I haven't
kept up with it. If anyone else wants to take it over, I'd welcome that.
On Tue, 8 May 2018 at 13:47, zimbatm<EMAIL_ADDRESS>wrote:

ping @philandstuff https://github.com/philandstuff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/39585#issuecomment-387390536, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjelQMOH5_fjxClqnlk9nj45HBm_0Nqks5twZPpgaJpZM4TpolR
.

cc @mboes ?

Would be happy to do so. Could we merge the current patch as-is and I'll add myself as maintainer in a separate PR?

@mboes not sure what you mean, as this PR is already merged. But I'm happy for you to raise a PR replacing me as maintainer.  Thank you!

@philandstuff oh hadn't noticed that @zimbatm merged right before pinging you. Will submit new PR shortly (taking the opportunity to switch to 0.13, which has since come out).

@mboes there's already a PR for that upgrade: #40205


Grav v1.7.0-beta.7 - Admin v1.10.0-beta.7 - Outline Assignments: Pages no longer listed, only Page Types

The Gantry layout Assignments tab no longer lists Pages above Page Types.  While possible to edit the assignments.yaml files, the red/green toggles on the Page list confirms status. This is very useful with hundreds of pages. Is this code or setting?

Is there an update or maybe a suggestion to patch/fix this? Not being able to assign outlines to specific pages makes gantry unusable for people who rely on the admin to manage a grav website with gantry templates.

It's actually fixed in CI build of Gantry already. There have been couple of issues about this, I must have missed this one.


QC flags in an export NRT file from QuinCe are given in two different formats

Python detects two formats for the QC flags given in the export NRT file 'NRT26NA1580659739270-ICOS OTC.csv'. The format is either integers ('2', '3', '4'), or floats with decimal number zero ('2.0', '3.0', '4.0'). After a quick inspection it seems like the format is always the same within the same column, and that flags for measured data gets integer flags, while flags for calculated data gets float flags. The QC flags in this file all look like integers when viewed in zublime text. Other files have not been checked.

NRT26NA1580659739270-ICOS OTC.zip


Fix scan aspect ratio

Why this PR?
We currently calculate a default aspect ratio which results in square pixels. For scans acquired with non-square pixels, this results in distortion of the image
Current:

Fixed:

Looks good, but maybe add an example to the docstring showing the use of aspect="equal" for people who want the square pixels back?

I thought about this, but I truly can't think of a use case where you'd actually want to do this. Even in the case where users have started analysis and want consistency, I truly think everyone would rather just re-plot and get the correct image than force a messed up one, no?

Looks good, but maybe add an example to the docstring showing the use of aspect="equal" for people who want the square pixels back?

I thought about this, but I truly can't think of a use case where you'd actually want to do this. Even in the case where users have started analysis and want consistency, I truly think everyone would rather just re-plot and get the correct image than force a messed up one, no?

👍


RDP Client Error: Could note create connection

A HP Thin Client T630 with version FreeRDP 1.1.1-HP14.4 could not connect to  Windows 2012 Terminal Server Park.
Warning xf_getWindowPrperty (332); Property298 does not exist
Error: protocol security negotiation or connection failure
check_host_and_port:getaddrinfo(rds,3389,0xa2)
=0(errno=0)
attempt_connect max 1000ms took 0ms
Starting xfreerdp to rds:3389
xfreerdp exit:pid0963, sig=0(none), status=0xc
Other Thin Clients with Windows do not have any problems
Ubuntu Laptop with Remina Remote Desktop client is running fine

Please try with our builds and provide the requested minimum information for your setup (just read the template for issues)


Translation of CONSUL presentation website in French

Here we go! Please tell us when screenshots are ready :)

The strings in this file are outdated. I am migrating them to the new version of the language file while also adding a folder for /fr with an isolated index.


No test at all?

really?
Would be great to have the tests functional and units.

Indeed. It is planned.

I'd love


Get token twice

Describe the problem

I use getTokenSiltently to save access_token in my cookies in order to use it with my API server. I see the networks that the function loginWithRedirect() eventually make a GET to <tenant>/oauth/token. So, I asked for a token twice, when login and when geTokenSilently().

What was the expected behavior?

I need to get the token after loginWithRedirect() finished. Something like:
loginWithRedirect().then(token => cookies.set('access_token', token))

Environment

Please provide the following:

auth0-react version: 1.2.0
Testing in google chrome
React
react-cookies to save cookies.

@bernardomichel Can you tell us more about your use case? The SDK already stores these tokens for you so that (by default) when you call getTokenSilently, you'll either get an access token from our internal cache or it will automatically be renewed for you using the /oauth/token endpoint (if your browser does not block third-party cookies).

I need to get the token after loginWithRedirect() finished

That's not possible to do unfortunately, as loginWithRedirect() is a full browser redirect, so there's nothing to wait on.

@bernardomichel Can you tell us more about your use case? The SDK already stores these tokens for you so that (by default) when you call getTokenSilently, you'll either get an access token from our internal cache or it will automatically be renewed for you using the /oauth/token endpoint (if your browser does not block third-party cookies).

I need to get the token after loginWithRedirect() finished

That's not possible to do unfortunately, as loginWithRedirect() is a full browser redirect, so there's nothing to wait on.

I think that the getTokenSilently() always asked for a new token using the /oauth/token endpoint.
useEffect( () => {
		if(isAuthenticated) {
			// I have token saved in cookies?
			if(cookies.get('access_token')) {
				API.get(...)
			} else {
				// Asked for a Token
				getAccessTokenSilently().then(result => {
					cookies.set('access_token', result, {secure: process.env.NODE_ENV !== 'development', path: '/'});
					API.get(...)
				})
			}
		} else if(!isLoading) {
			// Not logged, loginWithRedirect
			loginWithRedirect()
		}
	}, [isLoading, isAuthenticated])

I think that the getTokenSilently() always asked for a new token using the /oauth/token endpoint.
useEffect( () => {
		if(isAuthenticated) {
			// I have token saved in cookies?
			if(cookies.get('access_token')) {
				API.get(...)
			} else {
				// Asked for a Token
				getAccessTokenSilently().then(result => {
					cookies.set('access_token', result, {secure: process.env.NODE_ENV !== 'development', path: '/'});
					API.get(...)
				})
			}
		} else if(!isLoading) {
			// Not logged, loginWithRedirect
			loginWithRedirect()
		}
	}, [isLoading, isAuthenticated])

Do I need to force ignoreCache?: boolean to false?

Do I need to force ignoreCache?: boolean to false?

I think that the getTokenSilently() always asked for a new token using the /oauth/token endpoint.

Not always, no. I will use the expires_in time from the token call to cache the access token and will use it (by default) until it expires. ignoreCache is false by default, too.
If you're seeing a call to the token endpoint every time you call it, are you using a particularly short expiry time on your access tokens? (less than 60 seconds, for example).

I think that the getTokenSilently() always asked for a new token using the /oauth/token endpoint.

Not always, no. I will use the expires_in time from the token call to cache the access token and will use it (by default) until it expires. ignoreCache is false by default, too.
If you're seeing a call to the token endpoint every time you call it, are you using a particularly short expiry time on your access tokens? (less than 60 seconds, for example).

To test it, i set the access_token lifetime to 30seconds. I'll change it to 1hr and try it again

To test it, i set the access_token lifetime to 30seconds. I'll change it to 1hr and try it again

Anything greater than 60 seconds should work. We have a built-in 60 second leeway where the token will be re-requested before it expires.

Anything greater than 60 seconds should work. We have a built-in 60 second leeway where the token will be re-requested before it expires.

The 60-second leeway is what was messing me up during testing.


⚠ sg2ray.serverssh.net has degraded performance

In 50f81ef, sg2ray.serverssh.net (http://sg2ray.serverssh.net) experienced degraded performance:

HTTP code: 200
Response time: 10610 ms

Resolved: sg2ray.serverssh.net performance has improved in 2d8d97a.


Use String as Key

Notable changes:
-key is now String instead of long
-added a method to resize Qachee
-support v4 annotations
-minSdkVersion=4 instead of 7
-use v4 instead of v7-appcompat in library module
Misc.
-use static final instead of enum (https://developer.android.com/training/articles/memory.html#Overhead)
-updated sample code
-formatting

you can use any unique String, the underlying Qachee behaviour remains the same as before.
That complicated string that you saw is my solution of Issue #1 as LruCache can now differentiate key shop1 and key product1.
If there are anymore clashes, that would be developers' fault for not override equals() and hashCode() properly for used by LinkedHashMap (inside LruCache)


What do after remove action from nanostores

My code uses the action function many times. How do I update nanostores, but not rewrite the entire code?

Use a normal function.
  function setNames(watermarks: string[]) {
    $watermarks.set(names);
  }

  setNames(["Alice","Bob"]);

Another way is to copy action() from previous version to your project. It is just few lines of code helper.

@gitlobster, you can try to install next version of Logger for Nano Stores from @nanostores/logger#feat/actions-api. It has the same Actions API. This feature is not released as I haven't tested it in real life project yet, just e2e tests coverage.

Use a normal function.
  function setNames(watermarks: string[]) {
    $watermarks.set(names);
  }

  setNames(["Alice","Bob"]);

I've used it many times and plus I've used the logger

@gitlobster, you can try to install next version of Logger for Nano Stores from @nanostores/logger#feat/actions-api. It has the same Actions API. This feature is not released as I haven't tested it in real life project yet, just e2e tests coverage.

thanks

Another way is to copy action() from previous version to your project. It is just few lines of code helper.
thanks


Stop the node when time server-manager taints the session

📚 Context
If the server-manager taints the session, it becomes unusable, and no further inspect or advance requests will work.
✔ Solution
Add a watchdog that will stop the node if the session becomes tainted.

We will rewrite the server-manager in Go.