feat(linter): add auto-fix metadata to RuleMeta

Add a FIX constant to RuleMeta that describes what kinds of auto fixes a
rule can perform (if any). This PR also updates declare_oxc_lint to accept a
fix capabilities field. Follow-up PRs in this stack will update existing rules
and update other parts of the codebase to use this new field.

#4560
#4559
#4558
#4557  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


feature: remove sqlite

Remove completed support of sqlite and add postgres as fixed database.

This support has been added during internal fixes.


"Find All Implementations" produces no results

Environment data

VS Code version: 1.58.2
Extension version (available under the Extensions sidebar): 2021.7.1053846006
OS and version: WSL2 Debian in Windows 10 2004
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: Pylance 2021.7.4
Value of the python.languageServer setting: Pylance

Expected behaviour
With a method name selected, References: Find All Implementations shows all implementations of that method in all superclasses and subclasses defined in the workspace.
Actual behaviour
References: Find All Implementations is available in the Command Pallete, but its result in References is "No results."
Steps to reproduce:
Sample file:
class Base:

    def method1(self):
        pass

class Sub1(Base):

    def method1(self):
        pass

class Sub2(Base):

    def method1(self):
        super().method1()

If I select method1 in Base, Find All Implementations should find Base.method1, Sub1.method1 and Sub2.method1. If I select method1 in Sub1, Find All Implementations should find Base.method1 and Sub1.method1. Currently, Find All Implementations does not find any of those implementations.
Of course, things get more interesting with more modules, packages and multiple inheritance.
Please note that Find All Implementations is different from Find All References, which will find the call to method1 in Sub2.method1 and Base.method1 if the latter is selected.
I think this issue is related to microsoft/vscode-python#2694 and https://github.com/microsoft/vscode/issues/126666.

Thanks for the report. This is not a feature that Pylance supports as yet. Will add this to our list of proposed enhancements. Thanks!

This is actually a dupe of #1200.


🐛 Bug Report: Techdocs repeatedly calling /api/techdocs/sync/// every second

📜 Description
I am running into a weird issue on the techdocs page where a request is made to /api/techdocs/sync/// every second and they all return a 404.
Some context about my setup, I have builder: "external" and the route definition looks like
<Route     path="/docs/:namespace/:kind/:name/*"     element={<TechDocsReaderPage />}   />
👍 Expected behavior
It shouldn't keep calling this url every second.
👎 Actual Behavior with Screenshots
repeatedly calling /api/techdocs/sync/// every second returning a 404

👟 Reproduction steps
I have builder: "external" and the route definition looks like
<Route     path="/docs/:namespace/:kind/:name/*"     element={<TechDocsReaderPage />}   />

Open any techdocs page
See the network request being repeated made every second

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

Heya 👋
Out of curiosity, what version of backstage are you currently using?

Hey @Parsifal-M I'm using 1.28.4

Could you share your TechDocs config in the app-config.yaml? Just remove/mask any sensitive stuff 😄

I've got this in app-config.yaml
    builder: "local"
    generator:
      runIn: "docker"
    publisher:
      type: "local"```

and then this in `app-config.production.yaml`
```techdocs:
    builder: "external"
    publisher:
      type: "awsS3"
      awsS3:
        bucketName: xxx
        credentials:
          xxxx
        region: xxx```

Hey! 👋
Just a few follow-up questions to help better understand for anyone reading and myself, have you checked if the docs are actually there in that bucket? I think what you are supposed to be seeing there is something like:
https://your-backstage.com/api/techdocs/sync/default/component/some-component but it looks like its missing the default:kind:name
Quite strange behaviour 🤔

Hey @Parsifal-M Yep I can see the docs are in the bucket

Hm.
I would guess that this is the row that makes the request. Indeed it would seem that the entityId comes in empty which ruins the URL.
I'm not on the techdocs team, but my current hunch is that this piece of code gets triggered because it can't find the TechDocsReaderPageContext.
If you run yarn backstage-cli info and dump the output here, maybe we'll see some duplicate dependencies of packages? If we do, a yarn dedupe might help.

That would make sense to me, although I thought the Context was rendered as a child TechDocsReaderPage so not sure how it would be missing?


Rename loops/base.py to loops/loop.py

What does this PR do?
Fixes https://github.com/PyTorchLightning/pytorch-lightning/issues/11974
IMPORTANT: This PR needs to be "Rebase and Merge"d. Do not add merge commits!
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@Borda this is not a breaking change. A deprecation path was added.


Gitlab Provider

Describe the bug

GitLab As Custom Provider

Callback url is not correct

Scope Needs   '+' instead gets replaced by %2B

And 401 Error
(After I Manually Changed CallbackUrl and scope)

[next-auth][error][OAUTH_GET_ACCESS_TOKEN_ERROR] [
  {
    statusCode: 401,
    data: '{"error":"invalid_grant","error_description":"The provided authorization grant is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client."}'
  },
  undefined,
  undefined
]
https://next-auth.js.org/errors#oauth_get_access_token_error
[next-auth][error][OAUTH_GET_ACCESS_TOKEN_ERROR] [
  {
    statusCode: 401,
    data: '{"error":"invalid_grant","error_description":"The provided authorization grant is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client."}'
  },
  undefined,
  'gitlab',
  '<Token>'
]

To Reproduce
https://docs.gitlab.com/ee/api/oauth2.html Docs Found Here
    {
      id: 'gitlab',
      name: 'GitLab',
      type: 'oauth',
      version: '2.0',
      scope: 'email+profile+read_user',
      params: { grant_type: 'authorization_code' },
      accessTokenUrl: 'https://gitlab.com/oauth/token',
      authorizationUrl: 'https://gitlab.com/oauth/authorize?response_type=code',
      profileUrl: 'https://gitlab.com/api/v4/user',
      profile: (profile) => {
        return {
          id: profile.id,
          name: profile.name,
          email: profile.email,
          image: "NO"
        }
      },
      clientId: '<Client ID>',
      clientSecret: '<Secret Here>'
    }

Expected behavior
Work Out Of The Box

Callback Should Have Been http://localhost:3000/api/auth/callback/gitlab

Additional context
Probably I would have messed up something  .As far as the docs this is the way to do it
Would like this working and would like to merg to main repo
Documentation feedback
Documentation refers to searching through online documentation, code comments and issue history. The example project refers to next-auth-example.

[ x] Found the documentation helpful
[ x] Found the example project helpful

Thanks for the very detailed bug report!
Can you confirm if using separating them with space works for you or not?
scopes: 'email profile read_user',
If that doesn't work, can you try passing them as array?
scopes: ['email', 'profile', 'read_user'],
^I was planning to support this but can't remember if it actually works or not.
If neither of these approaches work do let us know!
We might need to do something special for GitLab.

Yeah the scope was fixed by scopes: 'email profile read_user'.But the callback url and 401 error still exists

The callback URL is http://localhost:3000/api/auth/callback/gitlab (as above) is correct.
Why do you think this is incorrect? Are you getting an error telling you that?

the callback is correct. the error is in the redirect_url in the url picture it . It should have been https://gitlab.com/oauth/authorize?response_type=code&redirect_uri=http://localhost:3000/api/auth/callback/gitlab
but it is https://gitlab.com/oauth/authorize?response_type=code&redirect_uri=%2Fapi%2Fauth%2Fcallback%2Fgitlab

Hmm, did you configure the site option in NextAuth.js to tell it your site name?
e.g.
site: 'http://localhost:3000`

As an option in /api/auth/[...nextauth.js]

:sweat_smile: I cloned the example repo again. i thought my env was being applied.My bad It worked

Oh great!
This actually puzzled me for a bit as I couldn't figure out why that redirect URI was wrong!
Maybe we should spit out a warning if not configured / make http://localhost:3000 the default.
Glad it's working!


[4980] Do not write TRN values from HESA to trainee record

Context
https://trello.com/c/ZforgmYP/4980-hesa-collections-can-write-a-trn-value-in-register
Now that Register requests TRNs on behalf of HESA (HESA no longer goes to DQT directly), the importer should ignore the value in the XML because it could be mistakenly overridden by providers when they make updates and resubmit to HESA. We do however want to know if there is a disparity between the XML value and the Trainee record value so we can inform the provider of their mistake.
Changes proposed in this pull request

Update Trainees::CreateFromHesa to ignore TRN from HESA and send an alert message to Sentry if the value is different from the value in the Trainee record.

Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 HESA collections can write a TRN value in register

Looks good! Does this mean we also need to update this line in MapStateFromHesa service:
def initialize(hesa_trainee:, trainee:)
  ...
  @trn = hesa_trainee[:trn] || trainee.trn
  ...
end

it's still looking to the trn from HESA first.

Good spot. I'll fix that.


Install vespa program.

@geirst : please review
@mpolden, @hakonhall, @aressem : FYI

@mpolden / @arnej27959 : Any reason why the vespa-cli hasn't been installed? I have found it useful when experimenting with system and performance tests running on manually built Vespa.

@geirst: No particular reason. Probably wasn't missed by anyone until now.


Fix more issues with setuptools externally depending on six

In tox. make sure we're running our tests with the checked out six, not some six installed in the virtualenv (#182).

In setup.py, don't import six to get the version number (#188).

Also, fix some flake8 complains in tox.

I'm assuming we don't need this, since the setuptools devendorization was abandoned.


feat(object store): introduce new s3 object store via OpenDAL

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
detail in https://github.com/risingwavelabs/risingwave/issues/14321

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

I have verified the correctness of OpenDAL s3.

before via sdk: we need to set credential in environment by aws configure or just set access_key in pod env, then sdk will call from_env() to get the credential.
For new OpenDAL S3, we need to set AWS_REGION, AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY, and for those S3 compatible storage, we need to set one more RW_S3_ENDPOINT. This is the same as current docker compose env.

Next, we need to do perf test and stability test for the new OpenDAL S3, but before that we need to apply this change in RisingWave Operator and Kube Bench. I have created an issue for this, and will start testing after this is done. So let's merge this PR first to allow other components to be easily tested.  @hzxa21
The next PR will switch current minio to use OpenDAL S3.

Longevity test
https://buildkite.com/risingwave-test/longevity-test/builds/1017#018d59ab-b4c3-44b3-b075-258184cb8ae0

Add some enhancement for opendal s3:

add concurrent write(v0.44.2)
Set the retry parameters the same as the current s3
add trust-dns feature(by bump version to 0.44.2)

It seems that the commit is messed up with a merged PR. Let's resolve it first.

Umm never mind, I am build RisingWave image right now, which need to be consistent with nightly0201, so I cherry pick https://github.com/risingwavelabs/risingwave/pull/14844.
Will rebase main after https://buildkite.com/risingwavelabs/docker/builds/15123 is ready(blocked now)

Metabase link: http://metabase.risingwave-cloud.xyz/dashboard/241-nexmark-blackhole-1cn-anti-affinity-rw-avg-source-throughput?start_date=2024-02-07&namespace=
left:opendal-s3  right: nightly-0207

Take eyes on q104:

streaming upload start avg

opendal-s3

nightly-0207

Before introducing concurrent uploading for opendal-s3, this metrics opendal side will be 100 times slower, but now both sides are basically the same.

What does upload avg meta measure?

What does upload avg meta measure?

investigating

Hi, @wcy-fdu, do we have a final report about this? Is there anything that opendal could improve?

Hi, @wcy-fdu, do we have a final report about this? Is there anything that opendal could improve?

We will go ahead do some perf test on main branch, comparing with everyday's nightly.
And still investigate the abnormal metricsupload avg meta, which indicate the checkpoint latency.

And still investigate the abnormal metricsupload avg meta, which indicate the checkpoint latency.

Got it, let's figure out it.


npm 0.1.3 Vidage.min.js missed

I have Vidage as dependency and tooled gulp task for copying .min.js file, unfortunately in last 0.1.3 release Vidage.min.js is missed

If I understand properly, you've used your own gulp tasks to copy Vidage.min.js file, but the file no longer exists?
If so, that's correct. I've decided that there's no need for non-minified JS version as it's unreadable after source version goes through compile. So now you should probably just copy Vidage.js as that's the only version and it's minfied.
I also throw out .min suffix as it's unnecessery when there are only minified files (CSS and JS) included in destionation.

@dvLden thanks for info.
We have such project structure:
-project
--dist
---assets
---index.html
--node_modules
--sources
--gulpfile.js
On production server it's served from /dist/ folder. So we need to copy deps from node_modules to /dist/assets

So I assume you store each filename that you need found and copied within node_modules?
It's strange to me tho, why you're not running an compiler and including the dependencies from node_modules as suppoused. In the end they get compiled in single file that you should throw in dist, right? At least that makes sense to me.

@dvLden in cause of dynamic loading for libraries. Single complied file will be too large ;)


Changed the AppVeyor script to use the new CI scripts which run Clippy.

r? @dirvine
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Teething problems trying to access the site through nginx reverse proxy. Not sure how to correctly configure proxied dev ports and seeing "Upgrade required" message in browser.

What version of Remix are you using?
1.3.4
Steps to Reproduce
Ive installed 1.3.4 using npx command and indie install option.
Im running through a proxy so Ive changed the main port and the devserver socket port to the same value specified in my proxy config:
remix.config.js
module.exports = {
  cacheDirectory: "./node_modules/.cache/remix", //default
  ignoredRouteFiles: [".*", "**/*.css", "**/*.test.{js,jsx,ts,tsx}"], //default
  devServerPort: 3301
};

.env
DATABASE_URL="..."
SESSION_SECRET="..."
PORT=3301

results of running in dev mode
bash-5.1# npm run dev

> dev
> run-p dev:*

> dev:css
> npm run generate:css -- --watch

> dev:remix
> cross-env NODE_ENV=development binode --require ./mocks -- @remix-run/dev:remix dev

> generate:css
> tailwindcss -o ./app/styles/tailwind.css "--watch"

� Mock server running

Rebuilding...
Done in 1280ms.
(node:173) ExperimentalWarning: stream/web is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Loading environment variables from .env
Watching Remix app in development mode...
� Built in 2.6s
Remix App Server started at http://localhost:33455 (http://<IP_ADDRESS>:33455)

FYI my nginx config:
# remix.js 3300-3399
server {
    listen 80;
    server_name remix1.syntapse.co.uk;
    location / {
        proxy_pass http://<IP_ADDRESS>:3301;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection 'upgrade';
        proxy_set_header Host $host;
        proxy_cache_bypass $http_upgrade;
    }
}

Output accessing URL:  https://remix1.syntapse.co.uk/
Upgrade Required

browser console log:
Failed to load resource: the server responded with a status of 426 ()

Expected Behavior
Given my port configuration (though not sure if its correct) I was expecting dev app to run on port 3301 not 33455.
Also expecting a Remix default web page, not "upgrade required" message.
It would be great to see some official document for condiguration through a proxy.
Sorry to mention "NextJS" here but this just worked in NextJS... i.e. I set the port in package.json (different ports for dev and prod) and it all just works. There is no specific dev port websocket configuration nor nginx port configuration required.
It would be great to see first class support for proxied websites in the documentation.
Actual Behavior
See above. Browser displays "upgrade required" message.

I also tried
PORT=10000 npm run dev

which resulted in
bash-5.1# PORT=3301 npm run dev

> dev
> run-p dev:*

> dev:remix
> cross-env NODE_ENV=development binode --require ./mocks -- @remix-run/dev:remix dev

> dev:css
> npm run generate:css -- --watch

> generate:css
> tailwindcss -o ./app/styles/tailwind.css "--watch"

� Mock server running

Rebuilding...
Done in 1338ms.
(node:316) ExperimentalWarning: stream/web is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Loading environment variables from .env
Watching Remix app in development mode...
� Built in 2.2s
Remix App Server started at http://localhost:38685 (http://<IP_ADDRESS>:38685)

so remix is not picking up any of the PORTs i specify.


Chooser - 9 - Documentation on how to extend the choosers

Child of this parent ticket

closing - created in error


Large structures and extra columns in DSSP file

Hi,
mostly we refer to pre-computed DSSP files, e.g., via
rsync -avz --delete rsync://rsync.cmbi.umcn.nl/dssp-from-mmcif/ /path_to_dssp/
from the DSSP website.
For a pipeline working with MD simulation data, we need to compute DSSP files on our own and are therefore using your software. Now we stumbled over two things:

The DSSP files we create with your software do not contain the extra columns introduced for large structures / mmCIF, such as CHAIN and AUTHCHAIN. Is it possible to get these extra colums? I have not found an option in the help.
Your software seems not to be able to create DSSP files for large structures. It worked well when annotating the mmCIF, but when run with the option to create a DSSP file, chains with IDs of more than two characters are ignored. Interestingly, it seems that your software uses the PDB-style chain IDs (A..ZZZZ) instead of the author-given chain IDs (arbitrary) for this, even though author-given chain IDs are written to the DSSP file in the end. That would mean that your software only can correctly process up to 24 chains (A..Z).

Hope to hear from you. I also want to quickly thank for your last answer regarding the standalone version. We are still trying to compile it due to some errors and the issue was then already closed, but your answer really helped us.
Best wishes
Niclas

Hi Niclas,

The extra columns were a bit of a hack which had some adverse effect to other setups. We prefer to stick to the original DSSP format and for large complexes annotate mmCIF files directly. We realise that, currently, the mmCIF files do not capture all the data that you might want, but we are happy to enrich the mmCIF files if you tell us which information you need specifically.
That is indeed because of the limitations to the DSSP format. Nevertheless as chains in PDB format are case sensitive and allow digits we can faithfully process up to 62 chains. If you find cases that should fit, but somehow don't, please let us know.

If you need more help compiling, you are free to make a new issue. We're happy to help.

Hi Robbie,
thank you for your detailed answer. It is great to get such a fast response.

Sad to hear. We adjusted our parser to work with the extra columns. Thanks for the clarification, though. I guess we need to parse annotated mmCIFs then. We just need the secondary structure classification, so that is already part of the annotated mmCIF.
I understand. I was testing a large structure mmCIF, 3j9m, and chose the dssp output format. The result contains as last chain '1'. This chain has PBD-style chain ID 'Z'. In total the results contains 24 chains. That is why I concluded that DSSP only correctly processes 24 chains. But I guess you are referring to non-large structures in legacy PDB format. I am sure, DSSP works for the up to 62 chains there.

Concluding, it seems like DSSP moves forward to the annotated mmCIF output and we need to follow. But I guess this is the overall trend as other software, such as SCOT, also uses annotated mmCIFs.
Thank you very much for your response and also for offering help compiling. Currently, we are waiting for out IT administrator, but we will get back to you if we need help. I will close the issue since my questions are answered, but please feel free to comment or message me if you feel need to.
Best wishes
Niclas


CREATE VIEW support?

I tried a quick search and didn't find anything. Has there been any discussion about supporting views (particularly for Postgres).
Any thoughts on implementation?

A proposed implementation could be:
var query = user.select(user.star()).where(user.name.equals('userName'));

var viewText = query.toView('ViewName');

Wich returns
CREATE VIEW "ViewName" AS SELECT "user".* FROM "user" WHERE ("user"."name" = 'userName')

I have it already implemented. If this is ok, I can create a PR..
Any thougths?

:+1: seems pretty powerful and flexible to me

Alright. I'll add some test cases and create a PR probably tomorrow.

Hi.
I managed to create the tests and I'm coing to create the PR. I've changed a little bit what I proposed before, changing then toView to createView.
So, an example of use would be:
var sql = require('sql');

var user = sql.define({
  name: 'user',
  columns: ['id', 'name']
});

var query = user.select(user.star()).where(user.id.equals(1));

var view = query.createView('myView');

var text = view.toQuery();

This returns a query object as folows. Note that since we are creating a view, the parameters are replaced with its values.
   {
      text: 'CREATE VIEW "myView" AS SELECT "user".* FROM "user" WHERE ("user"."id" = 1)',
      values: []
   }

Creating a PR now.


updateweekly meetings

SORRY @Islast that this has taken so long to merge! Pulling it in to master now! ✨


Fixed typo: Changed "precent" to "percent" in variable naming

While working with the library I noticed that "percent" is sometimes misspelled as "precent", most importantly in the naming of the "volumePrecent" attribute of playerDetails.device.


LoadIncludes assumes type will always be an object type.

This is causing crashes in https://www.drupal.org/project/drupal/issues/3178534
Internal error: Internal error: assert($type instanceof ObjectType) in file /var/www/html/core/tests/Drupal/Tests/Core/Form/FormStateTest.php Run PHPStan with --debug option and post the stack trace to: https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

And
Internal error: Internal error: assert($type instanceof ObjectType) in file /var/www/html/core/lib/Drupal/Core/Extension/ModuleHandler.php Run PHPStan with --debug option and post the stack trace to: https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Offending code:
        $type = $scope->getVariableType($var_name);
        assert($type instanceof ObjectType);
        if (!class_exists($type->getClassName()) && !interface_exists($type->getClassName())) {
            throw new ShouldNotHappenException(sprintf('Could not find class for %s from reflection.', get_called_class()));
        }

The test code causing a failure:
  /**
   * @covers ::loadInclude
   */
  public function testLoadInclude() {
    $type = 'some_type';
    $module = 'some_module';
    $name = 'some_name';
    $form_state = $this->getMockBuilder('Drupal\Core\Form\FormState')
      ->onlyMethods(['moduleLoadInclude'])
      ->getMock();
    $form_state->expects($this->once())
      ->method('moduleLoadInclude')
      ->with($module, $type, $name)
      ->willReturn(TRUE);
    $this->assertTrue($form_state->loadInclude($module, $type, $name));
  }

It returns an intersection type, that is why. It is either FormState or MockObjec

t.


Regression, TextField.maxLength is ignored

Hello!
This commit introduced a regression bug: https://github.com/flutter/flutter/commit/2c3652b8fbe2294b3afdb3898f485bc7fdf7968b
I'm experiencing this issue on Samsung A40 (SM-A405FN) using Samsung keyboard, on Android of course. My colleague with iOS simulator can't reproduce the bug.
Let's create a simple TextField with maxLength.
TextField(
  maxLength: 10,
),

Start inputting some text without spaces, only characters. For example "dfjsdflsdnfsdnvsdnv" (random tapping at the keyboard). The length limit is exceeded and not enforced. But once I add space (which probably finishes the composing) the text is truncated to the correct size.
This is not how it should work! When I'm typing the text on the keyboard I want it to be limited exactly when I exceed the limit, not after I put a space.
Also, continuing on this example, when I press that space and then try to input more characters, they won't appear in the TextField, but will appear on my keyboard suggestions bar. After tapping backspace I am deleting those invisible characters and only after that the ones that were shown in the text field.
Flutter 1.22.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision d408d302e2 (8 days ago) • 2020-09-29 11:49:17 -0700
Engine • revision 5babba6c4d
Tools • Dart 2.10.0

@Albert221
There's a similar open issue describing your case, 67236.
Please follow-up there for updates and any questions.
Closing this as duplicate. If you disagree, write in comments and I'll reopen.
Thanks.


Extend GetState, PollInputStream and SleeEntryMessage with failure variants

This fixes #58.

Thanks for the review @slinkydeveloper. Merging this PR now.


MSBuild should define a mechanism for injecting transformations

We need a stable method for binary re-writing tools to inject themselves to the build process, so that the files built during compilation can be post-processed before being copied to the output directory.
An example for this is the IL-Linker, which runs ILLinker/Crossgen on MSIL files generated during a build.
The transformations should

Inject themselves transparently to the rest of the build process (ex: via a package-include)
Be able to run continuously during a development cycle and preserve incremental compilation.

One method of achieving this in ILLinker.targets and other places is to capture the IntermediateAssembly, perform the transformation on it, and rewrite it.
This pattern seems one of the better design choices, wrt simplicity and preserving incremental builds. However, the problem with this approach is that certain definitions statically capture the value of IntermediateAssembly, thus ignoring downstream modifications. For example:

https://github.com/Microsoft/msbuild/blob/f72bd2eaa37476819ab7647f63d445df8055dab6/src/Tasks/Microsoft.Common.CurrentVersion.targets#L5472-L5479

https://github.com/Microsoft/msbuild/blob/f72bd2eaa37476819ab7647f63d445df8055dab6/src/Tasks/Microsoft.Common.CurrentVersion.targets#L391-L393

This will cause other tools that use the pre-captured definitions to behave incorrectly.
One way to mitigate this problem is to maintain the invariant that IntermediateAssembly is not captured by any MSBuild definition, and that it is only read/modified within targets.

CC: @ericstj  @sbomer


Section renamed to "Access Restrictions"?

I can't find the "IP Restrictions" under the Networking blade in my App Service. There is only an "Access Restrictions" section. Is this the same thing? It looks the same but I wanted to get this confirmed (and if so, this page updated)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d90bbf62-44f9-30a6-d6ea-bbf776f6efc5
Version Independent ID: b3961eac-6c70-b345-f48c-e4c0ec67059c
Content: Restrict client IPs - Azure App Service
Content Source: articles/app-service/app-service-ip-restrictions.md
Service: app-service-web
GitHub Login: @ccompy
Microsoft Alias: ccompy

@thommck Thanks for the question! We are investigating and will update you shortly.

@thommck Thanks for bringing this to our attention. I have assigned the issue to the content author to review further and update the document as appropriate.

Yes, because now it's not only restrict the IP but also the vNET, hence the name "IP restriction" isn't precise anymore, the new name"Access Restriction" can cover the both.
Hope this explains

#please-close


[question] Can I use the latest EF/MVC packages (1.1.0)  in  dotnet 1.0.1  ?

Can I use the latest EF/MVC packages (1.1.0)  in  dotnet 1.0.1  ?
Microsfot.EntityFrameworkCore.Sqlite 1.0.1  have a decimal convert issue , so I decide to update to 1.1.0,
but my server is installed the 1.0.1 version of dotnet runtime , and I can not just install dotnet runtime 1.1.0 (Server reboot is required if i install that ), so Can I use  Microsfot.EntityFrameworkCore.Sqlite 1.1.0 on dotnet runtime 1.0.1 ?

i have had issues mixing dependencies with 1.0 and 1.1
I would recommend not mixing them

@seand88  you are right ,it seems I have to update dotnet runtime to 1.1


[WIP] Support for exposing component ports to hosts

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add port-forwrd support for exposing components ports to hosts in container executing. In this PR I tried to achieve the command as shown below
kwokctl port-forward NAME LOCAL_PORT

In most cases, the ports are not actively exposed when the cluster is created, and trying to access a component's port in the middle of the process can be difficult, so we wanted a way to support it.
Which issue(s) this PR fixes:

Fixes #1036
Special notes for your reviewer:
@wzshiming I tried to add the port-forward as the new subcommand to kwokctl , This can be treated as basic PR that has scope of discussion regarding implementation of TCP forward in case of different runtime.

Hi @wzshiming , I have implemented this one too. Kindly approve the same.

Fixed by #1203
/close


feat(autoware_launch): replace autoware-auto-mapping-msg with autoware-map-msg

Description
merge to autoware-msg branch:
replace autoware_auto_mapping_msg/msg/HADMapBin with autoware_map_msgs/msg/ LaneletMapBin
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

You want me to review this? I am not fully aware of the context, e.g. what the autoware_msg branch is intended for, so may not be able to review correctly.

You want me to review this? I am not fully aware of the context, e.g. what the autoware_msg branch is intended for, so may not be able to review correctly.

PR background: https://github.com/autowarefoundation/autoware/discussions/3972
you ignore this PR, we just merge to autoware_msg branch, but we won't merge until all the msgs have been modified and propose PR.


Internal: Replace Connect-SqlInstance by Connect-DbaInstance (part 2)

Not a bug fix and not a new feature, just internal refactoring to align the part where commands open a connection.
This is the second step for #7319.
@potatoqualitee Please have a look at Copy-DbaAgentServer and Copy-DbaResourceGovernor. I have not changed them as they have multiple connections to the destination. Should we remove them and instead .Refresh() the SMO?

Thanks for the PR! I'd prefer leaving the reconnect on AgentServer because it'd be a lot of refreshes in a specific order since it touches a number of parts. As for ResourceGov, not sure why that was done there, but I'd just leave it too.

Thanks for the PR! I'd prefer leaving the reconnect on AgentServer because it'd be a lot of refreshes in a specific order since it touches a number of parts. As for ResourceGov, not sure why that was done there, but I'd just leave it too.

Ok, updated those two commands as well.

merci 🙇🏼


Dependencies installation failure with conflict

Rasa Open Source version
3.2.6
Rasa SDK version
3.2.0
Python version
3.8
What operating system are you using?
Linux
What happened?
During a fresh install of Rasa:

ERROR: tensorflow-text 2.9.0 has requirement tensorflow<2.10,>=2.9.0; platform_machine != "arm64" or platform_system != "Darwin", but you'll have tensorflow 2.7.3 which is incompatible.
ERROR: sanic-cors 2.1.0 has requirement packaging>=21.3, but you'll have packaging 20.9 which is incompatible.

Command / Request
pip3 install rasa

Relevant log output
Rasa Version      :         3.2.6
Minimum Compatible Version: 3.0.0
Rasa SDK Version  :         3.2.0
Python Version    :         3.8.10
Operating System  :         Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.29

@VincentRoma Which processor does your machine use? The failures might have to do with incompatibilities between the processor you're using and rasa dependencies.

Hi @ancalita my computer is using a 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz

To double-check you're installing rasa in a fresh venv that doesn't contain any other preinstalled libraries?

Yes exactly

Mhm I wonder why it is trying to install tensorflow-text version 2.9.0. It should be installing 2.7.x as the version for tensorflow-text.
Can you

run pip install rasa -vv and provide us with the output
run pip install tensorlfow-text==2.7 -vv, does this work?

pip install rasa -vv output attached
pip debug --verbose is giving me error:
ModuleNotFoundError: No module named 'pip._vendor.certifi'
pip install tensorlfow-text==2.7 -vv is giving me:
Non-user install because user site-packages disabled
Created temporary directory: /tmp/pip-ephem-wheel-cache-j0kkfcsr
Created temporary directory: /tmp/pip-req-tracker-y0915w8y
Initialized build tracking at /tmp/pip-req-tracker-y0915w8y
Created build tracker: /tmp/pip-req-tracker-y0915w8y
[output.txt](https://github.com/RasaHQ/rasa/files/9416796/output.txt)

Entered build tracker: /tmp/pip-req-tracker-y0915w8y
Created temporary directory: /tmp/pip-install-fsucwq_u
1 location(s) to search for versions of tensorlfow-text:
* https://pypi.org/simple/tensorlfow-text/
Fetching project page and analyzing links: https://pypi.org/simple/tensorlfow-text/
Getting page https://pypi.org/simple/tensorlfow-text/
Found index url https://pypi.org/simple
Looking up "https://pypi.org/simple/tensorlfow-text/" in the cache
Request header has "max_age" as 0, cache bypassed
Starting new HTTPS connection (1): pypi.org:443
https://pypi.org:443 "GET /simple/tensorlfow-text/ HTTP/1.1" 404 13
Status code 404 not in (200, 203, 300, 301)
Could not fetch URL https://pypi.org/simple/tensorlfow-text/: 404 Client Error: Not Found for url: https://pypi.org/simple/tensorlfow-text/ - skipping
Given no hashes to check 0 links for project 'tensorlfow-text': discarding no candidates
ERROR: Could not find a version that satisfies the requirement tensorlfow-text==2.7 (from versions: none)
Cleaning up...
Removed build tracker: '/tmp/pip-req-tracker-y0915w8y'
ERROR: No matching distribution found for tensorlfow-text==2.7
Exception information:
Traceback (most recent call last):
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 186, in _main
    status = self.run(options, args)
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 357, in run
    resolver.resolve(requirement_set)
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/legacy_resolve.py", line 177, in resolve
    discovered_reqs.extend(self._resolve_one(requirement_set, req))
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/legacy_resolve.py", line 333, in _resolve_one
    abstract_dist = self._get_abstract_dist_for(req_to_install)
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/legacy_resolve.py", line 281, in _get_abstract_dist_for
    req.populate_link(self.finder, upgrade_allowed, require_hashes)
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/req/req_install.py", line 249, in populate_link
    self.link = finder.find_requirement(self, upgrade)
  File "/home/vroma/code/CAE/HubbleRasa/venv/lib/python3.8/site-packages/pip/_internal/index/package_finder.py", line 926, in find_requirement
    raise DistributionNotFound(
pip._internal.exceptions.DistributionNotFound: No matching distribution found for tensorlfow-text==2.7

Oh there was a typo there, please try pip install tensorflow-text==2.7 -vv.
I also couldn't see the output for pip install rasa -vv.

Additionally, I would also suggest upgrading pip just in case using pip install -U pip, that might resolve this error ModuleNotFoundError: No module named 'pip._vendor.certifi'.

I updated my answer with the file it wasn't formatted correclty :)
Here it is again in case:
output.txt
I upgrade pip from 20 to 22, resolved the debug
debug.txt
pip install tensorflow-text==2.7 -vv
tensorflowtext.txt

I've submitted PR #11493 to fix the tensorflow-text constraint.

Version 3.2.7 was just released, hopefully that resolves the problems you've encountered @VincentRoma


[INLONG-9774][Sort] Support rowdata way of sort InLong message tlog-kv format

Fixes #9774

Please fix the failed tests https://github.com/apache/inlong/actions/runs/8166147677/job/22324424993?pr=9780


[pagination] Allow customer pagination panel template

Could the default pagination visual style be updated to something along the lines of http://bramus.github.io/ws2-sws-course-materials/assets/06/pagination-good-flickr.png
The current one is quite archaic (looks like 10 year old JSP component).

+1 . . . . will get to it in time

+1

tracked by https://ag-grid.atlassian.net/browse/AG-80

Hi,
Is there a workaround for that ? I'm using ag-grid-ng2 but I can't find a way to change the pagination.

I'd like to add a pagesize select
I'd like to add the type of resultats after the record count

.. but I struggle to do it. Any advice/help is welcome :)
Thanks in advance.

Is this coming any time soon? I'm unable to access https://ag-grid.atlassian.net/browse/AG-80 to check the status.

Guys, could anybody say when this feature plan to be released?

Hi,
Thank you for raising this issue for us, at this moment we are reviewing how we process Feature Requests/questions that come through from GitHub.
As I am sure you are aware, we offer two products:
ag-Grid - this is entirely free to use in line with our MIT license
ag-Grid Enterprise - our commercial version which funds the development of both versions.
We currently have a very full pipeline of work which can be viewed here: https://www.ag-grid.com/ag-grid-pipeline/
This will be our priority for the coming months and as a result, we don’t have capacity to take feature requests/questions from GitHub, but you might find that yours has already been raised in our pipeline.
We will do a periodic review of GitHub issues for any bugs raised and these can also be tracked on our pipeline page.
Thanks for your understanding.
ag-Grid Team.


Add missing Exception class

Fixes the bellow error by import the exception class:

This will help you if you forget to add the HasTranslations trait to the model class to understand what is going wrong.

Thanks


feat: added scraper for last.fm website with proper docs

Description

Added scraper for last.fm with the following functions

Class - `Lastfm`

| Methods                     | Details                                                                                |
| --------------------------- | ---------------------------------------------------------------------------------------------------- |
| `.user_stats()`             | Returns the numbers of scrobbles, artists and loved tracks.                                          |
| `.recent_tracks()`          | Returns a dictionary containing the latest tracks scrobbled by the user.                             |
| `.top_tracks()`             | Returns a dictionary containing the top tracks of the user.                                          |
| `.top_albums()`             | Returns a dictionary containing the top albums of the user.                                          |
| `.top_artists()`            | Returns a dictionary containing the top artists of the user.                                         |
| `.get_following()`          | Returns the total number of users followed by the user.                                              |
| `.get_followers()`          | Returns the total number of followers of the user.                                                   |

Note: usernames are case sensitive.

Updated dev docs with the last.fm module

Resolves: #1054
Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

[x] Have you adhered to the repository's defined coding convention rules?
[x] Have you updated the 'documentation.md' file with the method/function documentation?
[x] Have you sent a message along with the result or response?
[x] Have you used the try-catch technique?
[x] Has the method/class been added to the documentation (md file)?

Screenshots

class:

working example:

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

Great work @arpy8  !!
Do not forget to

Share your contribution on socials and tag Clueless 🫂
Give this repository a star ✨
Follow Clueless Community on GitHub ✅


Fix potential crashers in unit tests

XCTestExpectation is a bit dangerous since it might crash the test if it’s fulfilled after waitForExpectationWithTimeout:handler: times out. The workaround is to make the variable referencing the expectation weak. So that it goes away and the -fulfill message is instead sent to nil.
@spotify/objc-dev

@rastersize Wouldn't we want it to crash if something went wrong and the expectation wasn't fulfilled? 🤔

@JohnSundell No we don’t want it to crash since it could, and should, just fail the test instead. Allowing the rest of the suite to run. Which will happen after this PR. The current behavior will be that the tests, if there’s for example CPU congestion, crashes and no other tests will be ran.
What happens is a edge case of XCTestExpectation’s API. For reference see http://stackoverflow.com/questions/27555499/xctestexpectation-how-to-avoid-calling-the-fulfill-method-after-the-wait-contex/27555500#27555500

👍

Current coverage is 92.64% (diff: 100%)

Merging #147 into master will not change coverage

@@             master       #147   diff @@
==========================================
  Files            62         62
  Lines          4488       4488
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4158       4158
  Misses          330        330
  Partials          0          0

Powered by Codecov. Last update 7bac8a8...7c3bdfe


[Objectfifo] Bf16 Matmul Vectorization

Here is the e2e IR log.
The issue is while running the following command during XCLBin's generation :-
llc input.opt.ll -O2 --march=aie2 --function-sections --filetype=obj -o input.o

Error: LLVM ERROR: unable to legalize instruction: %3605:_(s16) = G_BITCAST %3601:_(<16 x s1>) (in function: core_1_3).
To reproduce you may use this input.opt.ll.
You may also use ToM branch + this commit.
I had a talk with Gaeten Bossu (Peano dev) and the main issue seems to be :-
The mask load, it's turned into many scalar loads, that are unaligned. And that generates lots of instructions to legalize, and some of them aren't supported yet.

[PR 572] solves this.


Gpu failed tests due to not implemented (Arnoldi, Trace, ExpM...)

Run with -DUSE_CUTENSOR=OFF and  -DUSE_CUQUANTUM=OFF:
        279 - BlockUniTensorTest.gpu_Trace (Failed)
        331 - BlockUniTensorTest.gpu_at_for_sparse (Failed)
        332 - DenseUniTensorTest.gpu_Trace (Failed)
        411 - ExpM.gpu_ExpM_test (Failed)
        414 - Arnoldi.gpu_which_LM_test (Failed)
        415 - Arnoldi.gpu_which_LR_test (Failed)
        416 - Arnoldi.gpu_which_LI_test (Failed)
        417 - Arnoldi.gpu_which_SM_test (Failed)
        418 - Arnoldi.gpu_which_SR_test (Failed)
        419 - Arnoldi.gpu_which_SI_test (Failed)
        420 - Arnoldi.gpu_mat_type_real_test (Failed)
        421 - Arnoldi.gpu_k1_test (Failed)
        422 - Arnoldi.gpu_k_max (Failed)
        423 - Arnoldi.gpu_smallest_dim (Failed)
        435 - Svd.gpu_U1_zeros_test (Failed)
        450 - Gesvd.gpu_none_isU_isVT (Failed)
        459 - linalg_Test.gpu_BkUt_Qr1 (Failed)
        461 - linalg_Test.gpu_BkUt_expM (Failed)

Under developing cases:
linalg_Test.gpu_BkUt_Qr1,
BlockUniTensorTest.gpu_Trace,
linalg_Test.gpu_BkUt_expM ( due to [ERROR]currently Eig for non-symmetric matrix is not supported.)

Gesvd.gpu_none_isU_isVT (Failed) is just argument mismatch in test code.

Due to [ERROR]currently Eig for non-symmetric matrix is not supported.:
ExpM.gpu_ExpM_test,
linalg_Test.gpu_BkUt_expM,
Arnoldi.XXXX

Even more GPU tests fail now, probably because the API changed.?
I could also not compile the tests in dev-master because of densvd_T.from(svd_T) in TEST_F(linalg_Test, gpu_BkUt_Svd_truncate3): UniTensor.from does not exist.
With a workaround, I get the following:
The following tests FAILED:
	607 - NetworkTest.gpu_Network_dense_no_order (Failed)
	608 - NetworkTest.gpu_Network_dense_find_optimal (Failed)
	609 - NetworkTest.gpu_Network_dense_order_line (Failed)
	610 - NetworkTest.gpu_Network_dense_specified_order (Failed)
	611 - NetworkTest.gpu_Network_dense_reuse (Failed)
	613 - NconTest.gpu_ncon_default_order (Failed)
	614 - NconTest.gpu_ncon_specified_order (Failed)
	615 - NconTest.gpu_ncon_optimal_order (Failed)
	616 - ContractsTest.gpu_Contracts_denseUt_optimal_order (Failed)
	617 - ContractsTest.gpu_Contracts_denseUt_default_order (Failed)
	618 - ContractsTest.gpu_Contracts_denseUt_specified_order (Failed)
	619 - ContractsTest.gpu_Contracts_denseUt_optimal_specified_order (Failed)
	620 - BlockUniTensorTest.gpu_Trace (Failed)
	673 - DenseUniTensorTest.gpu_Trace (Failed)
	752 - ExpM.gpu_ExpM_test (Failed)
	754 - Lanczos_Gnd.gpu_Bk_Lanczos_Gnd_test (Failed)
	755 - Arnoldi.gpu_which_LM_test (Failed)
	756 - Arnoldi.gpu_which_LR_test (Failed)
	757 - Arnoldi.gpu_which_LI_test (Failed)
	758 - Arnoldi.gpu_which_SM_test (Failed)
	759 - Arnoldi.gpu_which_SR_test (Failed)
	760 - Arnoldi.gpu_which_SI_test (Failed)
	761 - Arnoldi.gpu_mat_type_real_test (Failed)
	762 - Arnoldi.gpu_k1_test (Failed)
	763 - Arnoldi.gpu_k_max (Failed)
	764 - Arnoldi.gpu_smallest_dim (Failed)
	770 - Svd.gpu_dense_one_elem (Failed)
	771 - Svd.gpu_dense_nondiag_test (Failed)
	776 - Svd.gpu_U1_zeros_test (Failed)
	783 - Gesvd.gpu_dense_one_elem (Failed)
	784 - Gesvd.gpu_dense_nondiag_test (Failed)
	798 - linalg_Test.gpu_BkUt_Svd_truncate3 (Failed)
	799 - linalg_Test.gpu_BkUt_Qr1 (Failed)
	801 - linalg_Test.gpu_BkUt_expM (Failed)
	802 - linalg_Test.gpu_DenseUt_Gesvd_truncate (Failed)
	803 - linalg_Test.gpu_DenseUt_Svd_truncate (Failed)

@manuschneider Network, Ncon and Contracts passed on my side, did you install and turn on cuquantum and cutensor properly?

Sorry, I did not know the tests would fail without cuquantum and cutensor. Here is an update:
620 - BlockUniTensorTest.gpu_Trace (Failed)
	673 - DenseUniTensorTest.gpu_Trace (Failed)
	752 - ExpM.gpu_ExpM_test (Failed)
	754 - Lanczos_Gnd.gpu_Bk_Lanczos_Gnd_test (Failed)
	755 - Arnoldi.gpu_which_LM_test (Failed)
	756 - Arnoldi.gpu_which_LR_test (Failed)
	757 - Arnoldi.gpu_which_LI_test (Failed)
	758 - Arnoldi.gpu_which_SM_test (Failed)
	759 - Arnoldi.gpu_which_SR_test (Failed)
	760 - Arnoldi.gpu_which_SI_test (Failed)
	761 - Arnoldi.gpu_mat_type_real_test (Failed)
	762 - Arnoldi.gpu_k1_test (Failed)
	763 - Arnoldi.gpu_k_max (Failed)
	764 - Arnoldi.gpu_smallest_dim (Failed)
	770 - Svd.gpu_dense_one_elem (Failed)
	771 - Svd.gpu_dense_nondiag_test (Failed)
	776 - Svd.gpu_U1_zeros_test (Failed)
	783 - Gesvd.gpu_dense_one_elem (Failed)
	784 - Gesvd.gpu_dense_nondiag_test (Failed)
	798 - linalg_Test.gpu_BkUt_Svd_truncate3 (Failed)
	801 - linalg_Test.gpu_BkUt_expM (Failed)
	802 - linalg_Test.gpu_DenseUt_Gesvd_truncate (Failed)
	803 - linalg_Test.gpu_DenseUt_Svd_truncate (Failed)

Still, linalg_Test.gpu_BkUt_Svd_truncate3 prevents from compiling the tests.

@manuschneider  I understand, we should have a table specify the gpu internal backends in the user guide in the future.

Can we mark the failed tests due to implementation disabled before implementing them?


Multi-word tab title raises exception during build

If .. tab:: is followed by more than a single word, as in this example
.. tabs::

   .. tab:: Red Apples

      Apples are green, or sometimes red.

   .. tab:: Pears

      Pears are green.

the sphinx build raises a json.decoder.JSONDecodeError exception. This bug does not seem to affect .. group-tab::.

Thanks for reporting!


Spoofing client to retry on all error

Add option to have spoofing client always retry regardless what error encountered.
Prepare for https://github.com/knative/serving/issues/6224
/cc vagababov

/assign @chaodaiG

/assign @adrcunha

/approve


usemin throws warning for default configuration

Starting with version 2.0.0 I can't get grunt-usemin to work at all. If I pass in a valid path to an html file I get this template warning 100% of the time. I produced a small test case to rule out any issues inside my (rather large) html file but I had no success.

Warning: An error occurred while processing a template (Cannot read property 'branch' of undefined). Use --force to continue.

Consequently downgrading to version 0.1.13 finally solved the issue.
Test case:
config.useminPrepare = {
        options: {
            root: "src/main/webapp/",
            dest: "target/<%= pkg.name %>/"
        },
        html: "src/main/webapp/test.html"
    };

<!DOCTYPE HTML>
<html lang="en-US">
<head>
    <meta charset="UTF-8">
    <title>title</title>
</head>
<body>
    <!-- build:js js/app.js -->
    <script src="js/app/views/sesresult.view.js" type="text/javascript"></script>
    <script src="js/app/views/ses.view.js" type="text/javascript"></script>
    <!-- endbuild -->

</body>
</html>

Output for 0.0.13:
grunt useminPrepare
Running "useminPrepare:html" (useminPrepare) task
Going through src/main/webapp/test.html to update the config
Looking for build script HTML comment blocks

Found a block:
    <!-- build:js js/app.js -->

    <script src="js/app/views/sesresult.view.js" type="text/javascript"></script>
    <script src="js/app/views/ses.view.js" type="text/javascript"></script>

    <!-- endbuild -->
Updating config with the following assets:
    - src/main/webapp/js/app/views/sesresult.view.js
    - src/main/webapp/js/app/views/ses.view.js

Configuration is now:

  cssmin:
  {}

  concat:
  { 'target/mobile-web-client/js/app.js':
   [ 'src/main/webapp/js/app/views/sesresult.view.js',
     'src/main/webapp/js/app/views/ses.view.js' ] }

  uglify:
  { 'target/mobile-web-client/js/app.js': 'target/mobile-web-client/js/app.js' }

  requirejs:
  {}

Done, without errors.

Output for 2.0.x
[...]
Running "useminPrepare:prod" (useminPrepare) task
Verifying property useminPrepare.prod exists in config...OK
Files: src/main/webapp/test.html -> target/mobile-web-client/
Options: root="src/main/webapp/"
Going through src/main/webapp/test.html to update the config
Looking for build script HTML comment blocks
Warning: An error occurred while processing a template (Cannot read property 'branch' of undefined). Use --force to continue.

Aborted due to warnings.

The question is now: Did something in the api change that I am missing or is this a bug?

@nerdgore @hkdobrev it's not related to grunt-usemin but to the usage of a template, see my comment in #291
Duplicate of #291.
@nerdgore in your use case make sure that when using <%= pkg.version %>, pkg is really defined by adding a pkg entry in your config with its value set to something like grunt.file.readJSON('package.json')


Snake example

Hello guys. I've implemented the "fill" option in the rectangle canvas struct and create the "snake game" example.
I hope it's going well!
Have a nice week!
Best regards
Valerio

Hey ! Thank for your interest in tui. This is a nice looking example but I'm not looking into adding more examples at the moment given that they are already quite a lot of them and the README includes a list of apps using tui which may showcase advanced usage.
Also the change to the Rectangle canvas should probably get its own PR with a quick description on why the change is needed, documentation and tests :).


Feature request: mask default value

Hi,
Could you please allow to mask the default value of an option (for example if the option is a password).
Might sound a rare use-case, but in my case I'm loading default properties from a config file, some of which might be credentials

Yup looks good thanks :)


Apply security on the search

Currently the search does not apply the security attached to the current user when returning the results. This means that the search result also contains items, which the user is actually not allowed to see.
The search should therefore also consider the security settings of Sulu. The short paragraph in http://docs.sulu.io/en/latest/bundles/security.html#checking-security explains a bit how that works, although a piece of code would also be nice in that place.
There are two possiblities solving this:

filter the search results in the controller
additionally index the security information and add that to the search criteria

The first approach would be quite easy, but makes pagination almost impossible. Adding the information to the search index means that the security logic might have to be repeated (not sure if there is an elegant way around this).

@chirimoya just mentioned that we already agreed to save all the roles as an array, which have a view permission on the given item. This way it should be quite easy to filter that in elastic search, for Zend Lucene we have to find a solution.
But first it would be important to only search through the indexes the user has a permission according to the security context.

But first it would be important to only search through the indexes the user has a permission according to the security context.

Do we really need to do that if we are already flltering the search documents based on role?

... for Zend Lucene we have to find a solution.

Without checking I think it should be possible to store the roles in a delimited list .. which would be made easier if it were illegal for roles to have spaces in them, as we can then seach for an exact single word match. Otherwise I expect we would have to create a new Tokenizer or something.

For the approach, I think we could build this feature directly into MassiveSearchBundle. We could add a "security contexts" field to the SearchQuery class, and then delegate the logic to the adapters.

Somehow you are right, if the security information is saved in the index, it would not be necessary to only search the right indexes. But it is hard to keep this information up to date, so if the security on a role changes this also has to be updated in the index. Maybe also ask @chirimoya, as it was his idea to filter by indexes at first.
Using a delimited list in Zend Lucene sounds good to me. Keep in mind that roles can have spaces in it, there is already an issue with that: #1616

But it is hard to keep this information up to date, so if the security on a role changes this also has to be updated in the index

Hmm, yes, didn't think of that. That would be a real pain, but maybe worth the sacrifice /cc @chirimoya

Keep in mind that roles can have spaces in it, there is already an issue with that

So are we saying that it is illegal to have spaces in a role? Using a space as a delimiter in Zend Lucene would at best be easier, using a different character would be an unknown problem.

And do you really want to include that into the MassiveSearchBundle?

Well .. it would be easier and probably better. The main issue is how the adapters handle the storage and searching of roles. I think branching out here (basically creating an event subscriber for every adapter) would not be desirable. We can instead "ship" MassiveSearchBundle with security built-in.
It is a Symfony Bundle and it will be implementing Symfony security (i.e. Roles).

Have had a think about this and I do not think it would be practical to store the permissions in the object:

ACL is done on a per-user per object basis -- we cannot store that information in the search document

This leaves us with no choice but to filter the results aftwerwards, which as @danrot mentioned, makes pagination difficult. I have two proposals:

We do not remove the entries in the search results, instead we "grey them out" (and add a padlock icon). In most cases it is more user friendly as the user knows that the record exists and that they do not have access to it, so they can then take further action such as asking the relevant person for access.

We iteratively search until we have the required number of non-restricted records. This could be expensive, especially with the ZendLucene implementation. The effect could be mitigated by always searching for 2x the number of records that we require.

I prefer #1. To me it makes sense from a user POV - except in the case where the existence of a document must be concealed, but as a user I would prefer to know that a document exists and that I don't have access to it for reasons explained above. It is also the most performant and simple option.
/cc @berndhep (see #1)

@dantleech I have discussed with @chirimoya yesterday, and we concluded that for the next release it would be enough, if just the indexes are search, for which the user has the permission based on the security contexts, and that objects which have role based permissions are ignored at the moment.
We also agreed that this logic should not be in the MassiveSearchBundle, since it should also be usable with other security systems not relying on roles. But this is now a separate issue, since the indexing of the object as said before is done in Sulu anyway, right?

Maybe we should talk tomorrow, I should be around.
Not sure how the index security you propose would work, and as said I
would prefer to do the easiest thing and show items the user does not
have access (with a locked icon and no link) to in the results, and if
that is not enough maybe to iteratively seach until the requisite number
of results is obtained.
But lets talk tomorrow.
On Wed, Oct 07, 2015 at 12:11:03AM -0700, Daniel Rotter wrote:

[1]@dantleech I have discussed with [2]@chirimoya yesterday, and we
concluded that for the next release it would be enough, if just the
indexes are search, for which the user has the permission based on the
security contexts, and that objects which have role based permissions are
ignored at the moment.
We also agreed that this logic should not be in the MassiveSearchBundle,
since it should also be usable with other security systems not relying on
roles. But this is now a separate issue, since the indexing of the object
as said before is done in Sulu anyway, right?
—
Reply to this email directly or [3]view it on GitHub.
Reverse link: [4]unknown
References
Visible links

https://github.com/dantleech
https://github.com/chirimoya
https://github.com/sulu-io/sulu/issues/1637#issuecomment-146097842
https://github.com/sulu-io/sulu/issues/1637#issuecomment-146097842

Why should the index security not work? It would even work quite easily, because each index corresponds to a single security context.
I don't think that just greying items out is a good solution. The security should be really secure, and if I don't want to see anyone a document, even the title is usually too much.
Iteratively searching is a real pain, and in certain cases it could be very slow. The proposed solution is the easiest, and should be implemented.

The fact that there is an index per security context is an implementation detail. It is not something, for example, that we even need to do in Elastic Search. Sulu should not know that there is an index per-structure type. But we could provide an interface to specify security "roles" to indexes in massive search.
$manager->createQuery('My Hidden Document')->locale('de')->roles($user->getRoles());

That's exactly what we don't want, since it couples the MassiveSearchBundle to the concept of roles. As I already said, this is not acceptable for me.
And that there are separate indexes is not an implementation detail, you can also search for single indexes in the search (the blue dropdown). Could be that this is solved with categories, but then you should be able to do simple the same for the search over the entire system. Just pass the categories for which the user has the view permission in the corresponding security context.

@dantleech What would you think about introducing some options to the XML file? Would make it a lot easier to add some customization, without adding another XSD file, and extend the parser. Especially for this use case I would favour something like the following:
<?xml version="1.0" ?>
<massive-search-mapping xmlns="http://massiveart.io/schema/dic/massive-search-mapping">
    <mapping class="Sulu\Bundle\MediaBundle\Entity\FileVersionMeta">
        <id property="id" />
        <title property="title" />
        <description property="description" />
        <index name="file_version_meta" />
        <category name="media" />
        <locale property="locale" />

        <fields>
            <field name="title" type="string" />
            <field name="description" type="string" />
        </fields>

        <options>
            <option name="security_context">sulu.media.files</option>
        </options>
    </mapping>
</massive-search-mapping>

Another option would be to lever (again) the expession language:
<... expr="sulu_has_security_context('sulu.media.files')" />

Also this security context applies directly to the index? Maybe it would simply be better to have this data defined in the DI config.
I.e. it is valid to have two or more mappings in the same index.
So I might define this in the DI config:
sulu_search:
    index_security:
        <index-name>
            roles: [ sulu.media ]
        ...

(just ideas)

I am already thinking in a bigger scope, if we add something like you have suggested with the expression language, we have to add another tag for that (and I still don't want the security to be part of the search bundle). Having options would also enable other developers to add some configuration to these files.
I have added to options to the mapping in the example, because they apply to the entity. As long as we only have one entity per index it doesn't matter, but I would prefer to do that the right way.
The security is until now also defined by the bundle itself, so I would make no exception for the search. This might just lead to misconfiguration. If the user is not allowed to see the entity, the bundle shouldn't show it to him, regardless of the configuration of the application.

Can we aggree that the problematic is:
Retrieve the index names to search for a given set of security contexts

I would say return the category names... Well, I would say it depends on how you actually use it. I don't really get the difference between indexes and categories at all.

Following our discussion on slack I understand that you will add <options/> to the MassiveSearchBundle and search for specifc categories from the SearchController until a later time when we can apply more fine grained permissions (e.g. on individual mapped classes).
We should also consider how to reuse the existing security mappings in the future (should we simply add mappings for indexed classes which are not mapped in the security system to the security system?).


Version sent during hello is inaccurate

When sending the hello command, the agent can send non-current package versions. So if you had versions 0.1.0 and 0.2.0 and the application was using 0.2.0 it may send 0.1.0 with hello.

Can you explain that more? Is this a situation where we need to be reading the version from a config, or something different?

When I originally wrote the code, I thought I was querying the package database for the installed version. Instead it appears I was querying for all installed versions, and it actually ends up choosing the smallest version on my machine, though I suspect it is non-deterministic.


Resets language settings

Each time after relaunching the game it resets "Language to translate to" option to English

Fixed in the current version. Please update through FFXIVQuickLauncher


Added GCP JMH Benchmark Workflow

Adds a workflow that is triggered via a "/benchmark" comment on a pull request. Clones the main and PR branch on the GCP instance and runs the ./gradlew jmh on each one of them, returning the results as a comment on the pull request.  Running on my test instance for review, will change the credentials accordingly once approved.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Updated with final changes and added VM start and stop steps.

Update: I successfully tested this change on my fork!
https://github.com/msridhar/NullAway/actions/runs/5580019520/jobs/10196359492
This was with a PR that deliberately introduced a slowdown.  I did a couple of tweaks in naming based on that.
@armughan11 I have two more comments / questions for you.

Benchmarking can take a while, and there is no feedback on the PR that anything is happening until the benchmarks complete.  I was wondering, as a first thing could the workflow add a thumbs up to the /benchmark comment, to show that it is running?  It seems possible, e.g., using this action (see here).
Regarding the step to stop the VM running with always(), just curious, will this step run even if the job is canceled?

Thanks for the update @msridhar!

This should be doable, I will look into it. Ideally, I would add this step right after the GCP authentication is complete or right at the beginning, but if you want the reaction after a specific step, kindly let me know, so I can make the changes accordingly.
Yes! That's why you would find the cleanup step with always() as well, which ensures that we don't end up with cloning errors for subsequent runs due to residual files. In short, steps marked always() aren't cancellable.

This should be doable, I will look into it. Ideally, I would add this step right after the GCP authentication is complete or right at the beginning, but if you want the reaction after a specific step, kindly let me know, so I can make the changes accordingly.

I was just thinking right at the beginning, to indicate something is running.

Yes! That's why you would find the cleanup step with always() as well, which ensures that we don't end up with cloning errors for subsequent runs due to residual files. In short, steps marked always() aren't cancellable.

👍

Just pushed a change. This should add the reaction once the job starts! @msridhar

Confirmed that adding the reaction works: https://github.com/msridhar/NullAway/pull/10#issuecomment-1639032525
I think this is good to go.  I'm going to land it and test on the main NullAway repo 🙂

Thanks again for the great contribution @armughan11!


make benchmarks runnable again

ack but make a follow up task to extract the stresstest module in it's own repo.


[CCM-18035]: Added troubleshooting for when the secrets expire for a CCM SMP customer

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes:
Jira/GitHub Issue numbers (if any): 18035
Preview links/images (Internal contributors only):

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is:

Usually we get a nice netlify link for the draft, can we see that?

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://666745b7416cf120e435e94d--harness-developer.netlify.app


article about state machine is moved to codeberg

Motivation
Affiliation

[ ] I am the author of the article or project
[ ] I am working for/with the company which is publishing the article or project
[x] I'm just a rando who stumbled upon this via social networks

Self checks

[x] I have read the Code of Conduct
[x] I applied all rules from the Contributing guide
[x] I have checked there is no other Issues or Pull Requests covering the same topic to open

Thanks @jingkaimori for the fix!


[SU-290] Convert brands and brand-utils to TypeScript

Before adding another option for branding, this converts brands and brand-utils to TypeScript and documents the available configuration for brands.

Rebased and made some changes to fix tests after merging failed.


LoadingView enhancements

What would you like to be added:

include a default LoadingContent as part of default style
make default style a keyed one, and then aliased it as an implicit (unkeyed) one

Why is this needed: QoL
For which Platform: any
Anything else we need to know?
n/a

Two additional suggestions:

Change visual state from Loaded to NotLoading. The LoadingView has two states to indicate whether something is loading or not, so the intent is clearer if the visual state name  is NotLoading
Change LoadingContent to be a DataTemplate, rather than object to make it possible to define the LoadingContent in a style. The issue with defining an object is that you end up with a single instance that's created when resources are initialized. This causes issue with dependent resources not being able to be found (try this by setting LoadingContent to include a ProgressRing in the style for the LoadingView). Changing to a DataTemplate will allow it to be lazy loaded and will create a new instance for each time it's used (ie each instance of the LoadingView)

ProgressRingTestApp.zip
I've included a test app that shows two options for setting a ProgressRing in the LoadingContent of a LoadingView using a Style:
Option 1 - ProgressRing directly - this fails (see code for error)
Option 2 - Uses a ProgressRing inside a DataTemplate, which I assume causes a delayed evaluation

Two additional suggestions:

[...]
Change LoadingContent to be a DataTemplate, rather than object to make it possible to define the LoadingContent in a style. The issue with defining an object is that you end up with a single instance that's created when resources are initialized. This causes issue with dependent resources not being able to be found (try this by setting LoadingContent to include a ProgressRing in the style for the LoadingView). Changing to a DataTemplate will allow it to be lazy loaded and will create a new instance for each time it's used (ie each instance of the LoadingView)

Regarding point 2, I would preserve both LoadingContent + LoadingContentTemplate so there is option to choose which to employ or both. Since if you had simply replaced that with a DataTemplate, we lose the access to the data-context at the LoadingControl level.
However, this introduce a problem if we were to add the default loading content where:

if we provide a default LoadingContent with the ProgressRing, that is a crash as you demonstrated
if we provide a default LoadingContentTemplate with the ProgressRing, the LoadingContent is ignored until the developer replace the LoadingContentTemplate too

I think if we at least add LoadingContentTemplate then at least a developer can set the loadingcontent as part of the Style.
Including the progressring in the default template is a lower priority and I think we can ignore it for the moment


Support Kafka <IP_ADDRESS>？

Kafka's latest version is <IP_ADDRESS>. Is there any plan to support this new version?

@raoergsls Hi, the problem is that Kafka <IP_ADDRESS> is not backward compatible with 0.8. Do we really want to have several packages per each Kafka version?

There's an option now to compile producer plug-in for a different Kafka version (see README.md file for more information)


about the Training Strategy

I used the code to train a new model without changing hyperparameter about batch_size lambda etc, when it finished at 600 epoch, the generated images onlg got 4.20±0.15 for inception score not the 4.36±.03 at paper.  the problem was caused by Training Strategy what I didn‘t know or the init of netG and netD?

me too.

Me too. @riaris @taoxugit


add mising attributes for return vessels and crews in 'search' function

Related Issue

Fixes the data side of o-fish-web issue 63
https://github.com/WildAid/o-fish-web/issues/63
Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[ ] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Web repository changes (explain below)

Optional: Add any explanations here

This is the necessary change to the Realm "search" function so that the UI can get these attributes
and pass them to the component that generates the <Link> so that the proper filter can be included in the path
see UI ticket for details:
https://github.com/WildAid/o-fish-web/pull/352

Optional: Add any relevant screenshots here

I've applied these changes to the wildaid-o-fish-sskep Realm app

Thanks @am-MongoDB !
I'm using the sandbox at https://wildaidsandbox-mxgfy.mongodbstitch.com/ to work on my UI issue
Will this fix be also applied to that one?

Hi @lenmorld - I have applied this to the sandbox instance.
@am-MongoDB FYI and for documentation's sake, I also applied this change to the dmssx production instance.


Adopted @xiaoyinl #4539: Make ch's print correctly handle nulls embedded in strings (Fixes #4410)

/cc @xiaoyinl
Includes #4539
Fixes #4410

@dilijev I fixed a compile error in my commit. I think the tests will pass, when you adopt my latest change.

@xiaoyinl thanks!

@dotnet-bot test Ubuntu _no_icu_static_ubuntu_linux_debug


See when a subscription is up for renewal

Hello I just have quick question and that is to see when a subscription ends.
More specifically a timestamp that represents the date when the subscription is up for renewal.
Is it possible to get this information?

I think the subscription.cycle_ends_at field could be used for that:
https://github.com/laravel/cashier-mollie/blob/6acdadc69b00bde337c37a10b6e2f1838ac93217/database/migrations/create_subscriptions_table.php.stub#L28


ios not using compression

Hi all
It seems this plugin in iOS is ignoring compression settings? Android is fine:
Here are my settings:
let drawingImage; 		pad.getDrawing().then((data) => { 			const image = ImageSource.fromNativeSource(data); 			const base64ImageString = image.toBase64String('jpeg', 10); 			this._sessionService.getCurrentSession().signature.base64ImageString = base64ImageString; 		}, (err) =>  { 			console.error(err); 		});
Any ideas on why this might be?

Sorry I am stupid. toBase64String is not part of this library


Inter-model Iterative AI Collaboration in Claude Dev

I've been using both GPT-4o and Claude 3.5 Sonnet in my workflow and have found that their combined strengths create an incredible synergy. GPT-4o brings creativity and broad thinking, while Claude excels in meticulous attention to detail and troubleshooting. Working with them together is like pairing a brilliant, fast-thinking young mind with a seasoned professional—each complements the other in ways that significantly enhance problem-solving.
I'd love to see a feature in Claude Dev that allows users to switch between AI models seamlessly within the same workflow - perhaps simply by flipping tabs in the drawer. For instance, being able to iterate with GPT-4o for creative exploration and then hand off to Claude for fine-tuning and detail work, or vice versa. A method for interleaving or semi-interleaving their contributions would be incredibly powerful for developers who want the best of both worlds in an integrated experience.
It's just so beneficial to use both Claude and GPT inter-operationally.
The ability to interact with these multiple tabs, such as "Claude Dev" and "GPT Dev," - or others that I have been seeing requested - would unlock even more potential. Developers could quickly switch between models and leverage their unique strengths to tackle complex challenges in ways that a single AI model cannot achieve alone.
This feature could turn Claude Dev into a powerhouse for collaborative AI-driven development, setting it apart as a tool that offers a truly dynamic and flexible workflow.

Really interesting concept! You can switch between models by opening settings and changing the model mid-task to accomplish this already. I'm not sure if adding UI specifically for switching models is something I'll add ATM but definitely open to the idea if there's more demand for it. Closing for now but thank you for sharing your thoughts, love hearing the interesting ways people are using claude dev.


Explorer range selection (shift + arrow) doesn't include focused item

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.88.0-insider (user setup)
OS Version: Windows 11 Windows_NT x64 10.0.22621

Steps to Reproduce

Open the explorer view, focus an initial item (using arrow keys without Shift, or Ctrl+Click). The file must be focused, but not selected.
Press Shift+Up/Down one or more times to extend the selection to items above/below it.

Actual Behaviour
The selection includes the siblings but not the initial item.
Example: In the following video, file 1 is focused in VSCode's Explorer, and the selection is extended down using Shift+Down over files 2–5. The selection includes 2–5, but doesn't include 1.
https://github.com/microsoft/vscode/assets/7352580/fec16275-bd8b-4fdf-bd95-946ca15d2792
Expected Behaviour
The selection includes the initial item and its siblings. This behaviour is consistent with how selection behaves outside VSCode.
Example: In the following video, Program.000.cs is focused in Visual Studio's Solution Explorer, and the selection is extended up using Shift+Up over Program.00.cs and Program.0.cs. The selection includes all 3 files.
https://github.com/microsoft/vscode/assets/7352580/9080e708-538b-425e-9033-d143628bbf67
Example: In the following video, file 5 is focused in Windows Explorer, and the selection is extended up using Shift+Up over files 4–1. The selection includes all 5 files.
https://github.com/microsoft/vscode/assets/7352580/9e77deef-1d24-462c-85cd-fc4f2dd081c9

This is technically by design due to focus and selection being disjoint elements. When you press shift + arrow you are asking it to move focus up + select the element and because the initial element is not selected the focus is moved up and the selection grows. Both demos you show in Windows and Visual Studio have joint selection and focuses. I've explored re-unifying our selection and focus behavior but it is a large undertaking.


feat(richtext / resolve references): references in richtext (in links…

…) will be resolved
https://github.com/e-Spirit/fsxa-api/issues/6
additionally, it was necessary to add a maxReferenceDepth parameter to avoid endless loops in reference fetching.

Thank you for contributing.
Unfortunately, I have to decline the pull request. We have decided that we do not want to integrate this feature into our product for the time being.


Add support for Python3.6

Python 3.6 can be supported by installing the dataclasses package from Pypi.
Note that the classifiers in setup.py must be updated to reflect the support for Python 3.6

Could you demonstrate how to send a request form central server to charge point
Thanks a lot

@JavanWang I moved your question to a separate issue because I don't think it is related to Python 3.6 support.

@OrangeTux Thanks, and Sorry for  I am a newbie in github, not familiar with open a issue, I got it now.

That is no problem @JavanWang . Welcome to Github! If you have any other questions, don't hesitate to to ask.


ci: enable dependabot

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error: No wrapper for core module path

After installing via npm on Windows, any call to browserify will throw
Error: No wrapper for core module path
Callstack:
browserify\lib\wrap.js:336:19
browserify\lib\wrap.js:312:14
browserify\lib\wrap.js:290:16
browserify\lib\wrap.js:324:21
browserify\lib\wrap.js:49:10
browserify\lib\wrap.js:14:12
browserify\index.js:49:13

The slashes are going the wrong way.

Well I'm on Windows in this case. They still use backslash instead of forward slashes as path separator. Shouldn't make a difference however?

I haven't tested browserify at all on windows and I make the assumption that the path separator is / all over the place. I'm open to pull requests that fix these assumptions for windows land.

As far as I know, the browser and Node.js understand forward slashes just fine. Do you think that the path seperator is the cause of the problem here?

I have a version of browserify running on Windows (I'll see if I can pull it together into a pull request). The issues I had to fix was with how it created the giant JS file, not with actual requires.
@milgner I think the problem above have to do with the fact that browserify is probably doing some incorrect lookup. Can you post a small example that exhibits this problem and I can try and run it through my version of browserify, and will let you know if it works.


check version of radio and warn if not 99

This has been fixed directly in crazyflie-link-cpp 878f2b2409ba7f985de93f34966f51963a1f336b.


Updates to support Aggregated BQM functionality

(but not the generation of ABQM - that goes into CF plugins);
Fixes to propagate setting/reading NodeMap property (see example slice_topology_test.py/testNodesAndComponents();
other minor fixes
This is for issue #17

Also added str() functionality to Topology (ExperimentTopolgy, SubstrateTopology and AdvertisedTopology objects)


The 'Emulator - Default Ports' node is added to Quick Access after trying to add one attached account to QA

Storage Explorer Version: 1.9.0
Build: 20190813.3
Platform/OS: Linux Ubuntu 19.04/Windows 10/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release(1.9.0)
Steps to reproduce:

Attach one account with SAS(Or attach it with Key/Name).
Expand 'Local & Attached' -> 'Storage Accounts' ->Right click the attached account then select 'Add to Quick Access'.
Check whether the attached account can be added to quick access or not.

Expect Experience:
The attached account appears under the Quick Access node.
Actual Experience:
The '(Emulator - Default Ports)(Key)' node appears under the Quick Access.

Fix merged into master.

This isue still reproduces on the latest master build  20190813.12. So reopened it.

I think this was still repro'ing due to a bad CE commit. @v-xianya can you check for repro on tonight's build? Thanks.


Is there a way to tell where a trail derives from?

If I know it right, a new trial comes from several previous trials, which discovered the nearby space and suggested this new point of param combinations. Thus, I want to know if there's a way to know which one or two parent trials comes to this new trial, or say where it derives from, is it achieveable now?
In most cases, it's the nearest point in space from previous trials, we just need a way to find it out.
I think it's a good thing to know this, much like taking the procedure out of blackbox.

I suppose this issue is not a feature request for optuna example. Could you use https://github.com/optuna/optuna/discussions for asking a question on optuna.


Various requirements fixups

Background
I wanted to specify python_version < '3.4' for the singledispatch dependency in #4894, but the fixate-requirements.py script does not support what pip calls "markers". Markers are environment specifications that instruct pip when to install, or more importantly, when not to install a dependency.
Here's what a Python version marker would look like for #4894:
singledispatch==<IP_ADDRESS> ; python_version < '3.4'

That marker would only install the singledispatch dependency if installing for Python < v3.4. The singledispatch package is a backport of the same feature for Python 3.4+, available in the standard library in the functools package. So installing it for Python 3.4+ is not necessary.
Description
This PR:

[x] Upgrades fixate-requirements.py to write out dependency markers if present in fixed-requirements.txt or in-requirements.txt.
[x] Tweaks some Makefile output to be more readble
[x] Adjusts some Makefile dependencies so multiple make invocations aren't constantly ping-ponging between different versions of pip, setuptools, etc. (read: speeds up the build)
[x] Alphabetizes fixed-requirements.txt (in two groups) so it's easier to visually search the file for a dependency by name

Future Work
I ran make requirements after these changes to ensure that the behavior of the script was no different than before. And I will be adding the environment marker to #4894 if this is merged in before that.

Note that the Travis tests are actually passing. The GitHub test status is not getting updated with the new results.

There is a list of markers in PEP 508:

Marker
Python equivalent
Sample values

os_name
os.name
posix, java

sys_platform
sys.platform
linux, linux2, darwin, java1.8.0_51 (note that "linux" is from Python3 and "linux2" from Python2)

platform_machine
platform.machine()
x86_64

platform_python_implementation
platform.python_implementation()
CPython, Jython

platform_release
platform.release()`
3.14.1-x86_64-linode39, 14.5.0, 1.8.0_51

platform_system
platform.system()`
Linux, Windows, Java

platform_version
platform.version()
#1 SMP Fri Apr 25 13:07:35 EDT 2014,Java HotSpot(TM) 64-Bit Server VM,25.51-b03, Oracle Corporation,Darwin Kernel Version 14.5.0: Wed Jul 29 02:18:53 PDT 2015; root:xnu-2782.40.9~2/RELEASE_X86_64

python_version
'.'.join(platform.python_version_tuple()[:2]
3.4, 2.7

python_full_version
platform.python_version()
3.4.0, 3.5.0b1

implementation_name
sys.implementation.name
 cpython

implementation_version
see definition below
3.4.0, 3.5.0b1

extra
An error except when defined by the context interpreting the specification.
test

The implementation_version marker variable is derived from sys.implementation.version:
def format_full_version(info):
    version = '{0.major}.{0.minor}.{0.micro}'.format(info)
    kind = info.releaselevel
    if kind != 'final':
        version += kind[0] + str(info.serial)
    return version

if hasattr(sys, 'implementation'):
    implementation_version = format_full_version(sys.implementation.version)
else:
    implementation_version = "0"

With #4894 not being merged this isn't strictly necessary. And with ST2 v3.3 dropping support for Python 2.7, we won't have to worry as much about Python versions when specifying our dependencies.
However, this PR does support a fairly new part of the requirements.txt standard, and it could still be useful in the future.
For instance, while StackStorm doesn't run on macOS, we could at least build the st2 client on macOS, and we could at least help make requirements run successfully on macOS by making the pyinotify dependency only for Linux.
Currently when you try to run make requirements on macOS you get:
Collecting pyinotify
  Using cached https://files.pythonhosted.org/packages/e3/c0/fd5b18dde17c1249658521f69598f3252f11d9d7a980c5be8619970646e1/pyinotify-0.9.6.tar.gz
    ERROR: Command errored out with exit status 1:
     command: .../st2/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/ls/_2q7p19s2n1c3xdnphq4btzr0000gn/T/pip-install-ctf42xh_/pyinotify/setup.py'"'"'; __file__='"'"'/private/var/folders/ls/_2q7p19s2n1c3xdnphq4btzr0000gn/T/pip-install-ctf42xh_/pyinotify/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base pip-egg-info
         cwd: /private/var/folders/ls/_2q7p19s2n1c3xdnphq4btzr0000gn/T/pip-install-ctf42xh_/pyinotify/
    Complete output (1 lines):
    inotify is not available on macosx-10.9-x86_64
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

But if we marked pyinotify as being only for Linux:
pyinotify==0.9.6 ; platform_system == 'Linux'

Then we can at least run make requirements to completion:
Ignoring pyinotify: markers 'sys_platform == "Linux"' don't match your environment

Waiting on https://gitlab.com/python-devs/importlib_metadata/-/merge_requests/118 to stop breaking the build.

Expands on the work done in StackStorm/st2#4750.

Pulled in a few commits from #4896.
Closes #4896.


Add Markdown syntax highlighting to the script editor

Follow-up to https://github.com/godotengine/godot/pull/77972 (can be merged independently).

There are some limitations due to how CodeEdit's highlighting works, but it's good enough for a lot of Markdown files out there already. It could be made significantly better if add_color_region() had a way to enforce the start to be at the beginning of a line, or with only leading whitespace :slightly_smiling_face:

This closes https://github.com/godotengine/godot-proposals/issues/1409.

Preview

Just curious, is there any issue with 4.x compatibility on this PR? Would love to see this in an upcoming release!

Just curious, is there any issue with 4.x compatibility on this PR? Would love to see this in an upcoming release!

To my knowledge, there's nothing blocking this PR, but it needs a review. Since GDC is ongoing and many core contributors are there, this may take a while.

To my knowledge, there's nothing blocking this PR, but it needs a review. Since GDC is ongoing and many core contributors are there, this may take a while.

Ah that makes total sense, thanks for the reply!

Some valid markdown might have incorrect highlighting.

Text
Autolink is URL between `<` and `>`. See <https://www.example.com/> for details.

Most inline <abbr title="Hypertext Markup Language">HTML</abbr> tags are supported.

We can probably just highlight the > at the beginning of a line.

We can probably just highlight the > at the beginning of a line.

CodeHighligher.add_color_region() doesn't have a way to make a region effective only if it starts at the beginning of the line, so this would have to be implemented first.

Thanks!

Excited for this as well!

Is it possible to export this SyntaxHighlighter to a GDScript class?
I think it would be useful for writing editor programs. Thank you!

Is it possible to export this SyntaxHighlighter to a GDScript class? I think it would be useful for writing editor programs. Thank you!

I believe this is already exposed to scripting in a way that editor plugins can provide their own highlighters. We may need more documentation for this in the class reference still, or perhaps even a dedicated manual page.


Feature Request: Price tracking for products

Adding a purchase price when purchasing products and display a graph of price over a set time period.

The following ideas on this:

To keep it simpel, no currency conversion handling, currency unit/symbol will be defined in config.php
Price can be entered during purchase, must be entered per purchase quantity unit, last price will be prefilled
For added products during inventory the last price will be used
Last price and small line chart of price history is shown in the product card (right side in purchase/consume/etc.)

The above is already done - maybe you can test it in the already updated English demo and give me feedback if this is what you thought of or if you have any other suggestions regarding this. (?) :)

COOOOL!!
I dont think there is any need to do any currency conversion as log as you can set the currency unit/ symbol in the config.
Maybe have the currency unit change depending on what language you use? (But needs a override option if you what to use something else).
My intial thoughts. Need to do more testing.

I think I'll close this for now, the base tracking should work - better/more statistics still needed everywhere...