Fix tests for memory leak patch

@rickycao-qy I have been looking into #10 and saw that you had a fix for it prepared in #12.
I've spent some time getting the tests to pass locally. Would you be able to take a look for me?
Thanks,
Matt

Relates to https://github.com/iterative/vscode-dvc/issues/967

@FeelyChau would you be able to confirm if this fixes the issue?

@FeelyChau would you be able to confirm if this fixes the issue?

Thanks for the contribution and sorry for being late.
Need to fix the lint error first.

@FeelyChau would you be able to confirm if this fixes the issue?

Thanks for the contribution and sorry for being late. Need to fix the lint error first.

Sorry, that check skipped locally for me because I didn't have clang-format installed:
/boa fix/memory-leak-tests *1 ❯ npm run lint

><EMAIL_ADDRESS>lint
> npm run lint:js && npm run lint:clang

><EMAIL_ADDRESS>lint:js
> eslint . -c .eslintrc.js --no-eslintrc

><EMAIL_ADDRESS>lint:clang
> ./clang-format.py

No clang-format-9.0 found, skipping checks!
* total errors: 0

Should be fixed now.

@FeelyChau can this get merged now?


Github pages docs

I do some tests on this branch for GH pages. It seems that it didn't create the gh-pages branch, and the page does not render the links right. Any idea @francescofarina ?

Have you set up the branch from which it should read as in https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site ?
Also I think we may have to do this step manually if there are issues on setting up the env for mlx in the action.
Basically to do I manually we need to build the docs locally (make html) and then force add the build/html directory (which is gitignored by default) git add -f build/html and then push the changes to the gh-pages branch.

Have you set up the branch from which it should read as in https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site ?

I assume you did it, so just checking - you have to point it to where the index.html is located, otherwise it defaults to the README.md in the root

Here is the current error: https://github.com/TristanBilot/mlx-graphs/actions/runs/7717444545/job/21036565423

You can easily try by yourself by pushing to this branch and check in Actions.

I assume you did it, so just checking - you have to point it to where the index.html is located, otherwise it defaults to the README.md in the root

Regarding this, I need to specify the branch created by the action after the build which will be dedicated to the build files. Now this branch is not created as the build doesn't work yet. Once built, we can specify either root/ or docs/ depending on where the build files are located.

I'm trying locally first to build the docs without mlx-graphs installed. I'm working on the source/conf.py where we need to mock the package modules at the beginning of the file as
from unittest.mock import MagicMock

class Mock(MagicMock):
    @classmethod
    def __getattr__(cls, name):
        return MagicMock()

# Mock the modules you want to exclude from import during documentation build
MOCK_MODULES = [
    "mlx_graphs",
    "data",
    # "nn",
    # "utils",
]
sys.modules.update((mod_name, Mock()) for mod_name in MOCK_MODULES)

It works for data, but when I add nn it breaks

Are we supposed to mock mlx_graphs modules?
Idk why the modules are not found as we run the same commands as we do locally.

I'm trying to figure out what's going on. If you uninstall mlx-graphs from your local dev environment the docs won't compile as in the GitHub action.

If I do:
pip uninstall mlx_graphs
make clean
make html

It still works

I need to delete all the _autosummary* folders to make it work but that shouldn't be a problem in the action.

@TristanBilot Sphinx build is now working correctly. I'm not sure what's the aim of ghp-import as the last step

We may want to use something like this as the last step, with
- name: Deploy to external repos
      uses: peaceiris/actions-gh-pages@v3
      with:
        deploy_key: ${{ secrets.GITHUB_TOKEN }}
        publish_dir: docs/build/html

This will publish the new documentation and push it to the gh-pages branch on every push to main.
@TristanBilot please make sure to update Settings -> Pages -> Build and deployment to Deploy from a branch with the branch selected to be gh-pages from root

I have it working on my fork here

Amazing!


Validate node ID, sequence ID and timestamp on synced payloads

Validate node ID, sequence ID and timestamp on synced payloads
Refactor validation into separate method
Fix bug

#311  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

The golang race test seems to be failing on main (unrelated to this PR), can investigate that separately


made change for custom sounds in android >= 8

Description of Change
I had to make this code change so that each notification channel/notification could have it's own custom sound for android versions 8 and above.
Issues Resolved
?
API Changes
None
Platforms Affected

Android

Behavioral Changes
Custom sounds will be used rather than
Testing Procedure
I made these changes on an older version of the library and tried to port them to the most recent version of the library, I have not yet tested the changes unfortunately but they did work on an older version of the library.
PR Checklist

[ ] Rebased on top of the target branch at time of PR
[ ] Changes adhere to coding standard

Custom sounds already works.  I'm not sure what this is trying to fix or add!?

Custom sounds already works. I'm not sure what this is trying to fix or add!?

We ran into trouble getting the custom sounds to play on a Samsung device running Android 9, we had to set each custom notification sound to have it's own channel to get it working.


run apm-agent-api failed in both linux and windows

downloaded source code apm-agent-java-master from github, built it on both windows & linux. Build was successful.
Then run the command like (ref: https://www.elastic.co/blog/elastic-apm-java-agent-beta-released)
java -javaagent:/path/to/elastic-apm-agent-.jar
-Delastic.apm.server_url=http://localhost:8200
-Delastic.apm.service_name=my-application
-Delastic.apm.application_packages=org.example
-jar my-spring-boot-application.jar
got errors:
Failed to find Premain-Class manifest attribute in /home/jwang/apm-agent-java-master/apm-agent-api/target/apm-agent-api-0.7.0-SNAPSHOT.jar
Error occurred during initialization of VM
agent library failed to init: instrument
Thanks for any suggestions and helps

Hi and thanks for trying out the Java agent!
I'm not quite sure what you actually want to do.
The apm-agent-api-0.7.0-SNAPSHOT.jar is not meant to be used with the -javaagent flag. You probably want to do -javaagent:/home/jwang/apm-agent-java-master/elastic-apm-agent/target/elastic-apm-agent-0.7.0-SNAPSHOT.jar.
If you want to use the api to track custom transactions and spans you have to declare a dependency on the apm-agent-api module from your application. See also https://www.elastic.co/guide/en/apm/agent/java/current/public-api.html.

i didnt copy/paste the command in my previous question, instead i referred to the ref command provided in  https://www.elastic.co/blog/elastic-apm-java-agent-beta-released.
the command that I ran is shown below
java -javaagent:/home/jwang/apm-agent-java-master/apm-agent-api/target/apm-agent-api-0.7.0-SNAPSHOT.jar -Delastic.apm.server_url=http://<IP_ADDRESS>:9000 -Delastic.apm.service_name=bill-api -Delastic.apm.application_packages=com.xyz.bill.BillApiBootApplication -jar bill_api-0.0.1-SNAPSHOT.jar
thanks for another piece of info you mentioned about track transactions. I havent done that part, since I need to make the initial test/try work first.
thanks.

I'm still not quite sure what you are trying to do.
If you just want to get started with the agent, please follow the instructions in the documentation.
Why do you want to build the agent yourself? If you want to do this, don't use the apm-agent-api.jar module but the elastic-apm-agent.jar for the -javaagent flag.


How to connect 3rd party firewall in Security Solutions

Could you please provide the steps how to on board 3rd party firewall to Azure and please provide what recommendations it would provide

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3aa2f48e-a8f8-fb03-753b-9e3b76075b96
Version Independent ID: 2554dcd1-27a2-3a32-4097-b17dd261a1ad
Content: Integrate security solutions in Azure Security Center
Content Source: articles/security-center/security-center-partner-integration.md
Service: security-center
GitHub Login: @memildin
Microsoft Alias: memildin

@priyankareddy20 Thank you for your query. We will investigate and update the thread.

@priyankareddy20 For any third party firewall to be able to integrate with Security center . The firewall vendor must provide the integration from their side and publish their solution in the Azure Marketplace under Security & Protection category.

You can only add 3rd party solutions which are available within the Security and Protection section of Azure Marketplace.  Every 3rd party Firewall vendor provides their deployment resources on the product page within the marketplace itself .

Hope that helps. We will now close this issue. In case you have any further queries , please let us know .
Thank you.


SNI support seemingly still broken on OS X 10.9

The following does NOT reproduce with Python 3 or on Linux hosts.
Jump to the bottom for the actual error. I just attached logs of the venv setup.
bash-3.2$ virtualenv venv
New python executable in venv/bin/python
Installing Setuptools..............................................................................................................................................................................................................................done.
Installing Pip.....................................................................................................................................................................................................................................................................................................................................done.
bash-3.2$ venv/bin/pip install requests urllib3 pyasn1 ndg-httpsclient pyopenssl
Downloading/unpacking requests
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fr%2Frequests%2Frequests-2.2.1.tar.gz
  Running setup.py egg_info for package requests

Downloading/unpacking urllib3
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fu%2Furllib3%2Furllib3-1.8.tar.gz
  Running setup.py egg_info for package urllib3

Downloading/unpacking pyasn1
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2Fpyasn1%2Fpyasn1-0.1.7.tar.gz
  Running setup.py egg_info for package pyasn1

Downloading/unpacking ndg-httpsclient
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fn%2Fndg-httpsclient%2Fndg_httpsclient-0.3.2.tar.gz
  Running setup.py egg_info for package ndg-httpsclient

Downloading/unpacking pyopenssl
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2FpyOpenSSL%2FpyOpenSSL-0.14.tar.gz
  Running setup.py egg_info for package pyopenssl

    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    no previously-included directories found matching 'doc/_build'
Downloading/unpacking cryptography>=0.2.1 (from pyopenssl)
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fc%2Fcryptography%2Fcryptography-0.2.2.tar.gz
  Running setup.py egg_info for package cryptography
    no previously-included directories found matching 'documentation/_build'
    zip_safe flag not set; analyzing archive contents...
    six: module references __file__
    six: module references __path__

    Installed /Users/filosottile/tmp/venv/build/cryptography/six-1.6.1-py2.7.egg
    Searching for cffi>=0.8
    Reading https://pypi.python.org/simple/cffi/
    Best match: cffi 0.8.2
    Downloading https://pypi.python.org/packages/source/c/cffi/cffi-0.8.2.tar.gz#md5=37fc88c62f40d04e8a18192433f951ec
    Processing cffi-0.8.2.tar.gz
    Writing /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-zzgElT/cffi-0.8.2/setup.cfg
    Running cffi-0.8.2/setup.py -q bdist_egg --dist-dir /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-zzgElT/cffi-0.8.2/egg-dist-tmp-_RWs2A
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
    will not use '__thread' in the C code

    Installed /Users/filosottile/tmp/venv/build/cryptography/cffi-0.8.2-py2.7-macosx-10.8-x86_64.egg
    Searching for pycparser
    Reading https://pypi.python.org/simple/pycparser/
    Best match: pycparser 2.10
    Downloading https://pypi.python.org/packages/source/p/pycparser/pycparser-2.10.tar.gz#md5=d87aed98c8a9f386aa56d365fe4d515f
    Processing pycparser-2.10.tar.gz
    Writing /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-1JE3Je/pycparser-2.10/setup.cfg
    Running pycparser-2.10/setup.py -q bdist_egg --dist-dir /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-1JE3Je/pycparser-2.10/egg-dist-tmp-AjEMEf
    zip_safe flag not set; analyzing archive contents...

    Installed /Users/filosottile/tmp/venv/build/cryptography/pycparser-2.10-py2.7.egg

    building '_cffi__x36bf4a13xfba2f231' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.so
    building '_cffi__xa1394602x4a8b9ec1' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.so
    building '_cffi__x5eaa210axf0ae7e21' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o -lcrypto -lssl -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.so
    building '_cffi__x64a6e44fx21ac8a22' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.so
Downloading/unpacking six>=1.5.2 (from pyopenssl)
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fs%2Fsix%2Fsix-1.6.1.tar.gz
  Running setup.py egg_info for package six

    no previously-included directories found matching 'documentation/_build'
Downloading/unpacking cffi>=0.8 (from cryptography>=0.2.1->pyopenssl)
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fc%2Fcffi%2Fcffi-0.8.2.tar.gz
  Running setup.py egg_info for package cffi
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
    will not use '__thread' in the C code

Downloading/unpacking pycparser (from cffi>=0.8->cryptography>=0.2.1->pyopenssl)
  Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2Fpycparser%2Fpycparser-2.10.tar.gz
  Running setup.py egg_info for package pycparser

Installing collected packages: requests, urllib3, pyasn1, ndg-httpsclient, pyopenssl, cryptography, six, cffi, pycparser
  Running setup.py install for requests

  Running setup.py install for urllib3

  Running setup.py install for pyasn1

  Running setup.py install for ndg-httpsclient
    Skipping installation of /Users/filosottile/tmp/venv/lib/python2.7/site-packages/ndg/__init__.py (namespace package)

    Installing /Users/filosottile/tmp/venv/lib/python2.7/site-packages/ndg_httpsclient-0.3.2-py2.7-nspkg.pth
    Installing ndg_httpclient script to /Users/filosottile/tmp/venv/bin
  Running setup.py install for pyopenssl

    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    no previously-included directories found matching 'doc/_build'
  Running setup.py install for cryptography
    building '_cffi__x5eaa210axf0ae7e21' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o -lcrypto -lssl -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x5eaa210axf0ae7e21.so
    building '_cffi__x36bf4a13xfba2f231' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x36bf4a13xfba2f231.so
    building '_cffi__xa1394602x4a8b9ec1' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__xa1394602x4a8b9ec1.so
    building '_cffi__x64a6e44fx21ac8a22' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x64a6e44fx21ac8a22.so

  Running setup.py install for six

    no previously-included directories found matching 'documentation/_build'
  Running setup.py install for cffi
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    Package libffi was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libffi.pc'
    to the PKG_CONFIG_PATH environment variable
    No package 'libffi' found
    OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
    will not use '__thread' in the C code
    building '_cffi_backend' extension
    clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/include/ffi -I/usr/include/libffi -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c c/_cffi_backend.c -o build/temp.macosx-10.8-x86_64-2.7/c/_cffi_backend.o
    clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/c/_cffi_backend.o -lffi -o build/lib.macosx-10.8-x86_64-2.7/_cffi_backend.so

  Running setup.py install for pycparser

Successfully installed requests urllib3 pyasn1 ndg-httpsclient pyopenssl cryptography six cffi pycparser
Cleaning up...
bash-3.2$ venv/bin/pip freeze
cffi==0.8.2
cryptography==0.2.2
ndg-httpsclient==0.3.2
pyOpenSSL==0.14
pyasn1==0.1.7
pycparser==2.10
requests==2.2.1
six==1.6.1
urllib3==1.8
wsgiref==0.1.2
bash-3.2$ venv/bin/python
Python 2.7.6 (default, Dec  4 2013, 18:45:48)
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.2.75)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.get("https://transport03-rts03-iad01.transport.home.nest.com:443/")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/api.py", line 55, in get
    return request('get', url, **kwargs)
  File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
  File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
    r = adapter.send(request, **kwargs)
  File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/adapters.py", line 385, in send
    raise SSLError(e)
requests.exceptions.SSLError: [Errno bad handshake] (-1, 'Unexpected EOF')
>>>

This is happening to me on CentOS 5 as well.

@mattwilliamson What specifically is happening to you?

@Lukasa clearly it is happening. :wink:


Unregister webGL entity on destroy.

Fixes #977
Too bad I could not write a test for it though, no webGL in phantomJS.

Thanks, this looks good to me -- no idea why this wasn't implemented as part of WebGL.


feat: make SignatureModel inherit error_msg_templates

Make SignatureModel inherit error_msg_templates from parameter annotation.
Since pydantic does not support nested error messages, starlite users can not leverage error message templates because every parameter becomes a field of SignatureModel.
This PR makes pydantic's error_msg_template work. But if there is duplicate error_msg_templates key then last parameter's error_msg_template will be used.
PR Checklist

[x] Have you followed the guidelines in CONTRIBUTING.md?
[x] Have you got 100% test coverage on new code?
[ ] Have you updated the prose documentation?
[ ] Have you updated the reference documentation?

@Goldziher That sounds great! Thank for the review!


Add face ov (for face gate)

Please don't merge yet - this is for a future release

Docs Build status updates of commit af606f0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 69b6f86:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/cognitive-services/face-readme.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4012cbf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/face-readme.md
:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cbdcb0d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/face-readme.md
:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7d515ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/face-readme.md
:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off


Azure blob is not working

How do you use the Azureblob storage? I have tried so many ways. I'm sorry to complain but the documentation is not thorough and even though the author said it's less technical than KeeCloud. I find KeeCloud easier and more simple to use.
I'm using my Azure account name, Azure Access key and the URL as stated in the Docs.

Whenever I try this in the screen shot, it always says connection failed for the test.  Also don't understand this sentence from the docs.

The {accountname} is the name of the account you can see in KeeAnywhere Settings` account list.

How can there be a list in settings if you haven't added an account yet because it won't accept it?
I'm at a loss on how to make this work.

@tolew1 -  It works this way:
Account-Name: The Storage account name, not the full URL; just the "host-part" of the storage account
Access-Token: The shared key (Key 1 or Key 2) - unfortunately no SAS token possible right now
Blob-Path: The container name - is like a directory, NOT the filename

Hi I have the same issue. I have entered in all the information and getting failed when I hit test.  did anyone figure a solutions to this problem?
Regards,
Patti

Very old issue, maybe already fixed. => closed.


[BACKLOG] (Criteria catalog) - Increase spacing of the end of line text

Description of the issue
The spacing of each ending text must be increased so that it matches collapsible margin, like so:

Ideas of solution
Describe possible ideas for solution and evaluate advantages and disadvantages.
Workflow checklist

[x] I am aware of the workflow in CONTRIBUTING.md
[ ] I have created a branch for my feature

I don't see this issue on my machine. Maybe it was fixed meanwhile?

closed (issue not seen anymore)


Error in gist.create_model()

Hi!
Thanks for building scGIST!
I am stuck at the step where I create a model. I get this error -->

How can I fix this error?
Best,
Justine

Hi @justinesjw.
Sorry for the late response. Are you still facing this issue?

Hi @yafi38
Thanks! I solved that when I properly installed it.
But now I'm facing this error

May I know how I can fix this issue?
Best,
Justine

Hi @yafi38,
Thanks! the issue is resolved!
Best,
Justine


Use stable compiler to installing cargo-hack

I'm planning to increase the Rust version required for the installation of cargo-hack from 1.36 to 1.40. (cargo-hack is usually runnable with Cargo versions older than the Rust version required for installation. Rust 1.36 will continue to be supported after the increase the Rust version required for the installation of cargo-hack has been increased.)

bors retry


Multical 403

I can confirm that the multical 403 can also be read with this library.

Thanks @WobwobRt! I came looking for this exact comment.


Support for Kysely plugins

Using Kysely plugins doesn't seem to be properly supported by the react package. I am using the ParseJSONResultsPlugin, and it works when I call execute on the query, but not when I pass the query to the useQuery hook.
I guess this is a bug rather than a feature request, because:

The types of wrapPowerSyncWithKysely suggest kysely can be configured as usual using the second config parameter. (On another note: I think the config parameter should be changed to Omit<KyselyConfig, 'dialect'>, since dialect is set by wrapPowerSyncWithKysely and I'm not sure it ever makes sense to override it. At least it should be optional)
Kysely seems to assume specific plugins to be used. For example jsonArrayFrom and jsonObjectFrom assume to be used with ParseJSONResultsPlugin, so the types will be wrong if the plugin doesn't work.

This is probably due to us calling .compile on the supplied Kysely query to get the SQL and query parameters. We don't explicitly call .execute on the Kysely query. I'm assuming the .execute call should allow the plugins to map column data. We can investigating supporting .execute

This means I can't use https://kysely-org.github.io/kysely-apidoc/classes/CamelCasePlugin.html for now, right?

This means I can't use https://kysely-org.github.io/kysely-apidoc/classes/CamelCasePlugin.html for now, right?

Most likely. This will be fixed soon.

I love the team's speed for improvements!

Reminder: this will help to convert Temporal datetimes via a plugin. More here https://discord.com/channels/1138230179878154300/1282584951656550473/1282671991005909072

Closing this issue as plugins should be supported from<EMAIL_ADDRESS>


Add QR Code for onboarding the device on the dashboard

In addition to #97 we should add a QR code to the diagnostics page to onboard the device in the dashboard.
The QR code should be displayable by hovering a tooltip promoting the dashboard

Related to https://github.com/NebraLtd/hm-dashboard/issues/800

Could also add a deep link perhaps

This needs to be scoped out in the next grooming.


Load https playlist

Hi.
Many thanks for your project.
But i can add a https playlist, it search for adding but nothing come.
Thanks for help

Hi @linuxubuntu63, thanks for the feedback! It's hard to understand the issue without an example, possible problem could be an expired https certificate on the domain where the playlist is hosted, something similar we had here - https://github.com/4gray/iptvnator/issues/104

I am able to reproduce this. There's something preventing URLs that are running any Lets Encrypt SSL certificates from working, at least on the Linux AppImage.
(node:1763917) UnhandledPromiseRejectionWarning: Error: certificate has expired
    at TLSSocket.onConnectSecure (_tls_wrap.js:1484:34)
    at TLSSocket.emit (events.js:310:20)
    at TLSSocket._finishInit (_tls_wrap.js:927:8)
    at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:697:12)
(node:1763917) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 8)

You can reproduce this by trying, for example, to load https://letsencrypt.org as a playlist, even though it's obviously not an m3u playlist it fails with this error before even trying to parse it.
I suspect the AppImage may be bundling an outdated TLS cert chain or something along those lines given the recent letsencrypt certificate changes


Not using subsampling

I've used gimp with subsampling 4:2:0 and get better compression than guetzli. Is it possible to have that option?

Thanks for taking your time to investigate Guetzli.
Would you mind sharing an image (or, better yet, a few) and quality levels at which you notice this? It will be helpful to understand what's happening.

You can try with any image. I am using RIOT (Radical Image Optimizer) to convert png to jpg and the result is smaller and has better quality compared to Guetzli, with every image I have tried so far (not too much, but I am not happy with the results at all so I am just waiting if it gets better). FYI in RIOT I am usually setting the quality for 92%-94% (based on the image, the higher is usually required if there is text on the image) and the subsampling for 4:4:4 (if there are lot of reds on the image) or 4:2:2, sometimes 4:2:0 (if there is no red or green on the image). 4:1:1 produces very bad results so I am never using that.


Peers are pinged even after dead

I created 3 peers on different ports (using gossipmonger-tcp-transport listeners as transport). Lets call them A,B,C
A was given an empty seed set
B was given an seed set as [A]
C was given seed set as [B]
Everything runs fine when all the peers a live.
Then, I close peer C by terminating it's process (Ctrl-C)
A and B start reporting connection errors as expected
After some time they recognize peer C is dead (the 'peer dead' event is fired on both)
But even after they have recognized that the peer is dead, I continue to see periodic connection error reports.
Shouldn't peers stop trying to ping peers which they think are dead?
(MIN_LIVE_PEERS is set to the default 1, so that should not be a problem)
If they keep trying to ping even peers which are dead, what is the point of even calling them dead? That means a peer can never leave the cluster

Ok, I check the source code.
There is a probability with which dead nodes are tried.
Is this necessary to ensure consistency, or would it be okay to get rid of this?

Hi @webglider,
First, thank you for a great description of what you're seeing. It was easy to understand what you described.
You're right, the current code does not allow a peer to leave a cluster. I think you've found a missing feature. The retrying of dead peers was implemented because that's what was in the algorithm I read in the paper. I never got around to implementing peers cleanly leaving the cluster.
I don't think we should get rid of the retrying the dead nodes feature. It allows the cluster to recover from network partitions, partial failures, etc.
I think it would be possible to implement leaving the cluster by adding some sort of delete method to the storage api that would get rid of the desired peer.

@tristanls Yeah, I guess a method to allow peers to deliberately leave the network could be implemented. Right now I guess that can be done with a small hack - we could program each peer to recognize a special tombstone key,value pair maybe ('i am', 'dead') :P , so that whenever it receives such an update from another peer, it forcefully deletes the peer from storage. So if a peer wants to leave intentionally, it will update this tombstone key value pair locally, wait for a few seconds and then disconnect. I guess that will be sufficient to ensure that the update will propagate through gossip to all other peers.
But, what if a rough peer doesn't follow the standard protocol for leaving the cluster and simply terminates his process and shuts down his computer. In such cases the redundancy will remain. Is there a way to find such instances and delete them from the cluster? (maybe if a peer cannot be reached by many peers it is considered as to have left)
That leads me to another question regarding the phi accrual failure detection. I haven't read the details of how exactly the phi value is computed, but looking at the source code I could see that it was being computed using last time and interval related data. If I am not wrong this data is updated only when a peer receives a digest or a delta from another peer. So now lets imagine an idle network (i.e no updates are happening as of now), where peers are randomly exchanging digests. This means peer A's phi value of peer B will be updated only when A receives a digest from B. If the network is large, isn't there a chance that this could take considerably long? This means the failure detection information is not being gossipped i.e the peers are not working together in collaboration to decide the failure of a node. Each node independently decides failure of all the other nodes. Am I right regarding this? or have I missed something in the implementation?

Hey,
I've thought about this for a bit. I think a place where to introduce leaving the cluster (at least at first) is through the storage abstraction https://github.com/tristanls/gossipmonger#gossipmonger-storage. If storage afforded something like storage.remove(id), which would remove the peer from storage, the next time around gossipmonger calling storage.livePeers() or storage.deadPeers() the removed peer would not respond.
With that in place, the protocol for leaving the cluster would be:

shut down the peer (no need to be clean) permanently.
wait until everyone declares the peer dead (if we were to remove the peer prior to it being considered dead, we would could enter a state where we advertise a dead peer in the middle of removal)
communicate removal of that particular id (this can be some 'admin' gossip key)
when peers receive the admin message, they remove the peer use storage.remove(id)

The above protocol is very much a type of "after-the-fact clean up" protocol. In essence, you can shut down the peers and let them go dead.. and at some point, you can do the admin message that cleans up the ones you want to remove.
Regarding phi accrual failure detection. If you take a look at https://github.com/tristanls/gossipmonger/blob/master/index.js#L327, you'll see that we calculate phi when we locally attempt to connect to a peer (gossipmonger.gossip()), and not when the peer connects to us. Since, we constantly attempt to gossipmonger.gossip() https://github.com/tristanls/gossipmonger/blob/master/index.js#L349, we continuously update phi locally. So, an idle network would result in our local node thinking that all the peers are dead. You are correct that each node independently decides failure of all the other nodes. If the network is large, we might not connect to everyone, and therefore declare them dead, but that's why we continue trying dead peers, in order to test our local assumptions about the remote state of the peer.
As to peers gossiping their phi values to other peers, it sounds interesting, but I have not explored that path.


DDSaaS: HubSpot Content Hub: Crawler Integration v1.0.0

What does this PR do?
This is an initial release PR of HubSpot Content Hub integration including all the required assets.
Additional Notes

Crawler code for this integration has been committed in its respective repo
Pipeline created for this integration are available in our sandbox and would be shared separately with the required teams.
Samples for the pipeline review would also be shared separately with the required teams.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Created a Jira card for Docs Team editorial review.

@akaila-crest Just checking in to see if this PR ready to be reviewed by the Docs Team. (I noticed it hasn't been reviewed yet.)

Updated the README.md file as per the latest format and monitor names according to the updated CI rules.


Memory leak inside lofty::Probe::read()

Reproducer
use std::fs::File;
use std::io::BufReader;
use walkdir::{WalkDir, DirEntry};
use std::path::PathBuf;

// Create PATHs.
let paths: Vec<PathBuf> = WalkDir::new("/your/music/path")
    .into_iter()
    .filter_map(Result::ok)
    .map(DirEntry::into_path)
    .collect();

// Get thread count.
let threads = std::thread::available_parallelism().unwrap().get();

// Enter thread scope.
std::thread::scope(|scope| {
    // This leak "magnification" occurs the more threads get spawned.
    for paths in paths.chunks(paths.len() / threads) {
        scope.spawn(|| {
            for path in paths.iter() {
                // Open path.
                let file = File::open(path).unwrap();
                let reader = BufReader::new(file);

                // Create options.
                let options = lofty::ParseOptions::new().parsing_mode(lofty::ParsingMode::Relaxed);

                // Create probe.
                let probe = lofty::Probe::new(reader).options(options);

                if let Ok(p) = probe.guess_file_type() {
                    // This leaks a TON of memory.
                    // Commenting this line out stops the leaking.
                    p.read();
                }
            }
        });
    }
}); // Everything allocated above should be freed at this point.

// A TON of memory is still being used here.
println!("done");
std::thread::park();

Summary
lofty::Probe::read() leaks memory. I've tested the mp3 and flac .read() so far.
It's not actually too bad, around 10,000 files .read() leaks around 8MB~ for me, but what is weird is that these leaks compound to an insane amount when doing the exact same operations, but chunked across scoped thread(s).
Expected behavior
Memory should be freed after the probe and tagged file are dropped.

Is this only in 0.14.0?

No, same behavior starting from at least 0.9.0 (that's as far back as the example will compile).
I fixed the thread scope/chunk example, should work now.

Yes. This is the same as the example above but with std::thread::park() at the end.

Resident memory usage is 811MB, even after we exit scope. Both Windows/macOS have the same behavior as well.
This isn't cache that can be reused/given away either. After running the example in a loop, it'll continue to grow until the OS just kills the program when we run out of physical memory.

Ok. I'm not so sure this actually has to do with lofty::Probe::read() anymore, although it does trigger it.
This seems to happen with symphonia's probe as well and really anything that allocates memory by reading a file, like:
let mut vec = vec![0_u8; 1_000_000];
file.read(&mut vec);
drop(vec);

This still leaks memory if inside scope + .chunks().
I can reproduce on multiple systems so I don't think I'm going crazy but I don't think this is a bug in lofty so, closing for now.

@hinto-janai Looking into it, this is working as intended:
https://stackoverflow.com/questions/45538993/why-dont-memory-allocators-actively-return-freed-memory-to-the-os/45539066#45539066
Lofty (and Symphonia) make a lot of allocations for any single file, so the memory isn't going to be returned to the OS, it'll remain available for any future allocations. I guess the issue here is since you're reading so many files at once, they're stepping on each other's toes and the memory can't be reused. It'll just go on to request more and more memory with each file.
The only thing that could be done on my end is to reduce the number of allocations somehow, but it will all end up at the same point given enough files.

In these situations, the memory is freed at the end of scope:

Single thread, many iterations on 10,000 files
1000s of threads, no .chunks()
Infinite loop on both
Replace file read with large Vec creation on both

So I'm not sure what's going on here. Something to do with threads and .chunks() maybe?
If it is the allocator not giving back, I'm not sure what triggers it. Allocators should be freeing cache if it needs to allocate new things under low memory conditions, but none of the objects created are new, so... I don't know.

Anybody found a workaround for that? I am running a loop calling lofty and things hang after 800-ish files on macOS. Happens with both read_from_path and read_from.


Fix incorrect parameter names on image card components

This change fixes two issues:

A Prime Minister went missing from the historic Prime Ministers page
Details were missing from the past foreign secretaries page

Around a week ago we modernised the views on these pages to use image card, After which govuk publishing components release v27, which changes the parameters that are required here.
The combination of the missing parameters and a lack of href on one PM caused them to go missing.
By updating the parameter names to those required by v27 of the publishing componenets we see the past PM return, and past foreign secretaries get their details back

Related PR https://github.com/alphagov/govuk_publishing_components/pull/2300


Python script for creating folders failed if root folder being open by Atom

I'm running a Python script inside a folder and that script will replace two folder, bin and assets folder, and create some file inside that two folders. The script mostly failed to create one of the two folders, sometimes it could create bin folder but failed to create assets or vice versa. The folder that was failed to create could be seen inside Windows Explorer but cannot be enter or delete but that folder will disappeared immediately after Atom was closed.

I'm not sure what this has to do with Atom? Can you please clarify:

What version of Windows you're running?
Which version of Atom this is?
What the exact steps to reproduce are?
Can you reproduce the issue by performing the operations manually, in other words without the Python script?

Thanks

I'm running Atom version 10.0.1 on Windows 8.1 Enterprise N, with all Nuclide packages installed.
I think this might caused by conflict between nuclide-file-tree and core package tree-view.
At first I thought one of them was disabled, but it did not, as I can only see one tree windows. After disable tree-view package the problem gone.
I have tried to create folders many time using Windows Explorer but there is no problems at all. But hen I run cocos command from Cocos2d-x 3.7.1 using Windows Command prompt or Windows Powershell the problems arise. The command sometimes succeeded and sometimes failed but if it failed once there seem to be no chance of success unless I restart my Windows (PC).
Now I have another issue: tree-view package re-enabled automatically after nuclide-file-tree was update.
Another possible cause of tree-view package re-enabled automatically is Atom process won't close. Atom windows closed and disappeared but Atom process still exist when I checked in Task Manager. If I tried to open Atom again it show blank windows without loading project. When I terminate/end task of Atom process and start the Atom again I found out that all disable packages was re-enabled.

I always write Python code on Pycharm that is developed by JetBrains.In my options, It is good tool for programmer. I recommend you to use it. Atom is good tools too.But it has been developed in no long time.

Will python run with debion


An Error that Users can create to give to hyper

Part of the Error reform.
Motivation
Unlike the hyper::Error, which is meant to describe an error that occurred inside hyper and that information given the user, there a few instances where the user must tell hyper that an error has happened outside, and to stop it's scheduled action.

In the Client (see also #1130):

The user can create a Request<B>, with a custom Stream. They may need to tell hyper that the stream cannot be completed.

In the Server (see also #1128):

The user can create a Response<B>, with the same characterics and needs as the Client's Request<B>.
The user can provide a Service (and NewService), which returns Future<Item=Response<B>>, where that Future might also fail in creating a Response. In most cases, a robust server will want to send a response anyways, with a 4XX or 5XX status code, but there could exist instances where the user can't even (or doesn't want to) create those responses.

While hyper was using tokio-proto, there was a limitation on what error types could be used (only a single error type was allowed), but now that hyper has moved off, we can solve this (even now, before 0.12, I believe).
Design
Add a new error type to hyper::error that is meant for users to give to hyper. This can closely resemble sending a RST_STREAM in HTTP/2, so one possible name is indeed Reset. However, this type should be usable even when the underlying connection is HTTP/1, and in that case, it wouldn't send a reset, but would terminate the connection.
Being that this is an error created by users, the name could just be User. It's full path would be hyper::error::User.
All places that require the user to pass a hyper::Error would be replaced with E: Into<User>.
As a convenience, there would be From<hyper::Error> for User, so a user can easily pipe a stream from another request or response here.
To start conservatively, there would just be User::default().
This could eventually gain some other constructors, perhaps related to HTTP/2 error codes, to allow a desiring user to customize what exact error code is sent in RST_FRAME. Initially, it just use INTERNAL_ERROR in HTTP/2 contexts.
pub struct User {
    // ...
}

impl Default for User {
    // ...
}

impl From<hyper::Error> for User {
    // ...
}

Assuming that by users you mean developers/code using the Hyper crate, perhaps a better name for this is (error::)Application?

Instead of some hyper::error::User, this could just be Box<std::error::Error> instead. This punts allowing the error type to indicate an HTTP2 error code to reset with, but it's probably otherwise much clearer. Basically, all things in hyper that would allow a user to signal an error occurred could just be E: Into<Box<std::error::Error>, which is the same bounds like for std::io::Error::new(kind, my_error).
Some benefits here:

Users can return their own error type, making it easier to plug their app in, and logs can show exactly the message that they wanted.
This still works with hyper::Error, so proxying one hyper::Body as the body of another message works fine. With specialization, we can remove the box internally, but not a big problem either way.
We still benefit from not having weird hyper::Error::from(io_err).


Multi-select support in px-context-browser

Hi,
I was trying to explore PX context browser for one of our use case. It supports most of our requirements except for selecting multiple nodes. I believe there is support for multi select in current version of context browser.
Since demo page does not have this functionality enabled by default, can you please help us enable this?
Expected behavior:
https://github.com/PredixDev/px-context-browser/pull/44/files/2ddd39ba742fdc1606fafc4121740ebc6fc39475
I believe support was added after this pull request. It also provides checkboxes for each node which is kind of our requirement.

Environment (component version number, Browser (including version), operating system, hardware, etc):
component version no: 2.0.14

As stated on the discussion page of that PR, the code was not merged into the px-context-browser, as it is based on an older implementation. Context browser enhancements are currently in our roadmap for Q1 2018, although I do not know if multi-select is included in that list.

When can we expect this enhancement to be taken up?


[WIP] [Feature branch] 1320 drive dropdown

@mdworken and I spent some time pairing on this PR and came up with a list of to dos, some of which are completed by f311f4c:

[x] Showing diaper drives from all organizations, not just your own
[ ] Seed data: there are drives with no organization
[ ] In diaper drives index page, make sure time filter displays properly
[x] Diaper drive editor goes to donation editor (Edit button has the wrong link)
[ ] Diaper drive edit page has some spacing issues
[ ] Diaper drive index page: display dates as mm-dd-yyyy
[ ] Fix alignment on diaper drive index page
[x] Diaper drive participant is not saving for a new donation

@mdworken Fixed the rest of the must-have issues (including sprucing up the Diaper Drives new page, which we didn't even write down last time).


How to get player name from uuid

i want convert uuid to player name (protocolib 1.8.8)

@Steveice10

If you got the UUID from a GameProfile, it should also have the player's name. Otherwise, you'll have to do an online lookup, which is not part of MCProtocolLib.

I have an UUID from ServerSpawnPlayerPacket, can i get the player name from another packet?

Acording to the protocol wiki, the vanilla client gets player names, skins, etc. from data provided in Player List Item packets.

My comment in #253 could help you.


setting DUPHOLD_SAMPLE_NAME doesn't work

Hello @brentp,
Thank you for this tool!
I had e.g. errors like this
[duphold] couldn't find sample:sqcudn971184 in snps vcf which had:sqcudn971184.187147
due to bam file and snps VCF file differing in sample names(in bams the names are truncated). Previously, have solved this issue with renaming the header of the snp VCF(removing the .187147). However this time tried to set up like this
export DUPHOLD_SAMPLE_NAME='sqcudn971184' or just this DUPHOLD_SAMPLE_NAME='sqcudn971184' which doesn't work.
I would appreciate any leads on this.

just use:
export DUPHOLD_SAMPLE_NAME=sqcudn971184.187147

just use:
export DUPHOLD_SAMPLE_NAME=sqcudn971184.187147

just tried it, still doesn't work


Invalid JS in graphiql-workspace CDN

The graphiql-workspace javascript from the unpkg.com CDN seems to contain invalid javascript. I am geeting an syntax error.

Everything works fine as is for me, can you elaborate on the error?

Yes, on my co-workers machine it works too. Try an anonomys window or clear the cache.
My js console says: Uncaught SyntaxError: Invalid or unexpected token in graphiql-workspace.min.js:18
If I copy & paste the script from the cdn in a syntax checker it reports an illegal token in line 18.
The js from the other cdn works though


Implement basic copy plans

Which issue does this PR close?
Close https://github.com/apache/arrow-datafusion/issues/5654
Rationale for this change
Make it easy to copy data in / out of DataFusion
What changes are included in this PR?
Add planning support for COPY .. TO ..
Still todo:

[ ] Figure out how to pass options

Are these changes tested?

Are there any user-facing changes?

I still hope to work on this feature at some point


[8.0] Aeroo Reports Installation Script

@aschenkels-ictstudio ,
I've just completed an installation script for AerooDOCS and AerooLib inspired by your Pentaho installation script.
If you have time i'd highly value your insight or advice on how I could improve the script:
https://github.com/OdooCommunityWidgets/install-scripts/blob/8.0/aeroo_reports/aeroo_install.sh
Once this has been tested I plan to create another installation script for Jasper Reports in a similar vein, and eventually build an Ubuntu Server Edition-style installation wizard into my fork of your install script here:
https://github.com/lukebranch/odoo-install-scripts/blob/8.0/odoo-saas4/ubuntu-14-04/odoo_install.sh
To allow for the selection of packages to install (eg, reporting engines, OCA repositories, etc.) during the installation process.

@aschenkels-ictstudio ,
I've run into an issue with the script (Aeroo) that has me stumped. On line 41 I have the following:
sudo apt-get install python-setuptools python-genshi python-cairo python-lxml libreoffice-script-provider-python libreoffice-base python-cups python3-pip -y
however it looks like python-setuptools and python3-pip are not installing for some reason. If I do the command manually in a terminal everything works, but for some reason they are not installing correctly in the script.
This is causing AerooDOCS not to install properly in line 86:
sudo pip3 install jsonrpc2 daemonize
Do you have any suggestions on how to resolve that issue?

@lambone  @sharkutz
As you are watching this repository i've decided to ping you.
This installation script is ready for testing in Ubuntu 14.04 for Odoo 8:
https://github.com/OdooCommunityWidgets/install-scripts/blob/8.0/aeroo_reports/aeroo_install.sh
instructions are in this forum post:
https://www.odoo.com/forum/help-1/question/8-0-how-can-i-install-the-official-aeroo-reports-alistek-for-odoo-version-8-solved-installation-script-76044
If you do test it please comment back if you run into any errors.

Hello
Today I tried the script and I got this error:
---- Install Wkhtmltopdf 0.12.1 ----
--2015-08-10 16:07:59--  http://downloads.sourceforge.net/project/wkhtmltopdf/ar                          chive/0.12.1/wkhtmltox-0.12.1_linux-trusty-amd64.deb
Resolving downloads.sourceforge.net (downloads.sourceforge.net)... <IP_ADDRESS>
Connecting to downloads.sourceforge.net (downloads.sourceforge.net)|<IP_ADDRESS>                          9|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2015-08-10 16:08:00 ERROR 404: Not Found.

I got the same error. And i ran the script as suggeste. Any ideas?


Noise waveform ignores frequency parameter

Is this by design?
Should I be filtering the noise to a specific frequency I desire?
If I want to use noise as a modulator, what's the best way to achieve this?
From a math point-of-view maybe my question makes no sense.
From an old-synth-nerd point-of-view I think it does.

It’s not clear what a frequency parameter should do for noise. White noise
is supposed to be flat in frequency. You probably want to put it through a
variable filter.
DAn.
On Mon, Mar 6, 2023 at 13:03 Joseph Stewart @.***>
wrote:

Is this by desing?
Should I be filtering the noise to a specific frequency I desire?
—
Reply to this email directly, view it on GitHub
https://github.com/bwhitman/amy/issues/31, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGZUIVHZW27M33FIZ7DBLW2YRH7ANCNFSM6AAAAAAVROLZAE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Makes sense. Is it possible for the filtered output as a LFO?

Agree that this isn't needed.

Hi. So was it something like "random (noise) LFO waveform" @octetta had in mind as modulation source? Like Sample & Hold LFO! Can it be achieved,  or it's not implemented at this stage? That would be very nice! Also, as feature suggestion, would be great to have osc pan as modulation destination! Cheers.

I just implemented a random-value sample-and-hold modulator in the lfosnh branch.    Is that what you meant?

Also, as feature suggestion, would be great to have osc pan as modulation destination

That should already exist, although I'd believe it's not documented well. TARGET_PAN should work!

Also, as feature suggestion, would be great to have osc pan as modulation destination

That should already exist, although I'd believe it's not documented well. TARGET_PAN should work!

Thanks for pointing out. Will try that. Cheers.

I just implemented a random-value sample-and-hold modulator in the lfosnh branch.  Is that what you meant?

That might be it! I need to test and see. Thanks a lot for that @dpwe ! 👏

Here's a wire protocol example showing the TARGET_PAN in operation:
v1w0f1a1
v0w0g512L1
v0n64l1


Tests: make ClangImporter tests compatible with cross-compilation and remote testing

Those tests have 2 kinds of issues:

Some Makefiles were too adhoc. Modernize them to use the Makefile.rules support.
Shared libraries need to be registered to be transfered to the remote platform during testing.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test and merge


fix(java): invalid code when multi-inheriting optional properties

The generated code for interfaces includes default implementations for
optional properties (since adding a new optional property is a non
breaking change in TypeScript, this allows us to preserve this property
in Java, too).
However, if two distinct super-interfaces declare the same property, the
child inherits two unrelated default implementations for the same
method, which results in dispatch ambiguity that is illegal.
In order to remove the ambiguity, a new default implementation must be
provided on the child interface, so that the dispatch is unambiguous
again.
Fixes #22556

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
Commit ID: 9ea2aef8736d8fc133cd9a8e549d2ced318f1732
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
Commit ID: 7a13ea44eee235e6fd3f7a39c2de6e737d40344b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
Commit ID: 21bfabc79bc9fdbe21f3d56c3363537d37ee3cf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
Commit ID: 1f9488984f86836d8883ecf3dfd0a1e279af21b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Macros for accessing buffer and string data across versions

will fix https://github.com/Microsoft/pxt-microbit/issues/1941, still need to make a PR to the extension repo once this is merged though
moves the macros from microbit to be structures themselves

@pelikhan I do still need to set up my local build properly to test this fully, I haven't been able to get docker to work yet. Any pointers / black magic needed to do that?

bumping...

You can skip docker by install yotta and other tools. Or just let the cloud do the build.


Merging changes from master to live

Docs Build status updates of commit 08a415c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.vs/slnx.sqlite
:white_check_mark:Succeeded

docs/skills/overview.md
:white_check_mark:Succeeded
View

docs/voice-commands/deep-link-into-your-app-from-cortana.md
:white_check_mark:Succeeded
View

docs/voice-commands/dynamically-modify-voice-command-definition-vcd-phrase-lists.md
:white_check_mark:Succeeded
View

docs/voice-commands/interact-with-a-background-app-in-cortana.md
:white_check_mark:Succeeded
View

docs/voice-commands/launch-a-background-app-with-voice-commands-in-cortana.md
:white_check_mark:Succeeded
View

docs/voice-commands/launch-a-foreground-app-with-voice-commands-in-cortana.md
:white_check_mark:Succeeded
View

docs/voice-commands/support-natural-language-voice-commands-in-cortana.md
:white_check_mark:Succeeded
View

docs/voice-commands/vcd.md
:white_check_mark:Succeeded
View

docs/voice-commands/voicecommand-design-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


VAS Solution Intercommunication with Golden Record Service

Description
see https://jira.catena-x.net/browse/CXAR-1091
Impact

Additional information

[ ] I'm willing to contribute to this feature

duplicate https://github.com/eclipse-tractusx/sig-release/issues/304


fix: resolve error on close items

close: https://github.com/zakodium-oss/analysis-ui-components/issues/372

Codecov Report
Base: 52.26% // Head: 52.13% // Decreases project coverage by -0.13% :warning:

Coverage data is based on head (08322ae) compared to base (4943a48).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   52.26%   52.13%   -0.14%
==========================================
  Files         126      126
  Lines        6547     6585      +38
  Branches      156      157       +1
==========================================
+ Hits         3422     3433      +11
- Misses       3125     3152      +27

Impacted Files
Coverage Δ

src/components/dropdown-menu/DropdownMenu.tsx
62.29% <100.00%> (-0.91%)
:arrow_down:

src/components/dropdown-menu/MenuItems.tsx
82.51% <100.00%> (+0.50%)
:arrow_up:

src/app-data/state/producers/measurements.ts
30.70% <0.00%> (-4.03%)
:arrow_down:

src/components/table/Table.tsx
31.25% <0.00%> (+0.85%)
:arrow_up:

src/app-data/state/producers/appStateProducer.ts
68.88% <0.00%> (+1.44%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Please think about your commit messages: they should explain what you do. Here there was no error. I reworded to fix: do not close DropdownMenu when disabled items are clicked

The problem now is that it also doesn't close when you click on enabled items...

The problem now is that it also doesn't close when you click on enabled items...

Same as Dropdown with context.
In fact, the thing that make the menu close was a bug (with the clickOutside), so do we have to call the close function on both of the components ?

What is Dropdown with context?

What is Dropdown with context?

the one with the right click

Yes, we have to call the close function in both.


Fix the build to use updated binary name from xunit.runner.console package

FYI: @david-driscoll, if you don't see this and CI passes, I'll just go ahead and merge to unblock @filipw.


Feature/17 login dialogs

Pull Request Test Coverage Report for Build 91

9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.3%) to 89.259%

Totals

Change from base Build 85:
6.3%

Covered Lines:
229

Relevant Lines:
246

💛  - Coveralls


Record details page not working with large DB

After pushing past the 6-7 million mark, unable to load single Record page.  Checking MySQL queries for the page, seeing the following query that appears to gum up the works:
62 | combine | localhost:50366 | combine | Query   |    2 | Sending data | SELECT COUNT(*) AS `__count` FROM `core_record` WHERE (`core_record`.`job_id` = 226 AND `core_record`.`combine_id` = 'b7a87cc0-6499-455d-b5fd-3367852163b5')

Believe this is looking for other records in the lineage.  Might need to add combine_id to indexed columns, or see if this query can be improved by including a WHERE the id equals the Record id.

Added record_id and combine_id to Record table indices, bottleneck gone.


The position of the sidebar should be fixed in the customer panel.

Bagisto Version: Master
Steps To reproduce--
1. Log in as a customer.
2. add multiple items to the wishlist.
3. Click on the wishlist in the top right corner.
4. Scroll the page down.
Expected result: The position of the sidebar should be fixed in the customer panel.
Actual result: The position of the sidebar is not fixed in the customer panel. Please find the screen recording  Here

@jitendra-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


Not Shown DeFi Tokens on DeFi Section

Just a few tokens are displayed on the new DeFi Section. For example CVX (a DeFi token) is displayed but CRV is not. All my bTokens deposited on DeFi are not displayed. The BadgerDAO token (a DeFi governance token) is not displayed and it isn't displayed on the Governance Section.
DeFi Section example:

All Section example:

If it's needed, a list of DeFi token contract addresses not displayed:
BadgerDAO: 0x3472a5a71965499acd81997a54bba8d852c6e53d
Vault Address Badger Sett Curve.fi Factory BTC Metapool: ibBTC
bibbtc/sbtcCRV-f: 0xaE96fF08771a109dc6650a1BdCa62F2d558E40af
Underlying LP Tokens Curve.fi Factory BTC Metapool: ibBTC
ibBTC/sbtcCRV-f:
0xFbdCA68601f835b27790D98bbb8eC7f05FDEaA9B
bCVXCRV: 0x2b5455aac8d64c14786c3a29858e43b5945819c0
bveCVX: 0xfd05D3C7fe2924020620A8bE4961bBaA747e6305
bbveCVX: 0x937B8E917d0F36eDEBBA8E459C5FB16F3b315551
Curve DAO (CRV): 0xD533a949740bb3306d119CC777fa900bA034cd52
Vault Address Badger Sett Curve.fi renBTC/wBTC
bcrvRenWBTC: 0x6dEf55d2e18486B9dDfaA075bc4e4EE0B28c1545
bCVX: 0x53c8e199eb2cb7c01543c137078a038937a68e40

@Hoanib thanks the list is great. The groups (where the tokens appear) other than then in "All" is controlled by a file we build in this repo: https://github.com/AlphaWallet/tokens/. We can't add tokens directly to that repo at the moment, but created an issue to track: https://github.com/AlphaWallet/tokens/issues/4

@hboon, Check this dApp (https://debank.com/) All DeFi tokens are registered in all chains and also the dApp registers the total balance by chain and of all chains.

Yeah, aware of that. They have an API I intend to look at. It's at least useful for the total balance.


Update README: Sandbox -> Virtual Environmen

Update README for #406 . If needed I can remove the docs/changelog entry (not sure if it's warranted for doc changes).

Thanks! Agreed, I don't think the changelog update is needed for this little change.


support timeshift playing back ?

On some streaming services, like live stream, it's flash client support timeshift playing back.
User can move to and forward on a live session or even pause a while and continue on the stopping point

https://github.com/chrippa/livestreamer/issues?q=seeking

Also #1311 pull request for seek support for Progressive HTTP streams


Insulated Redstone Conduit Crash

When you use pick block on an insulated redstone conduit, it crashes your game. I am on the official forgecraft public modpack.

I don't care what modpack you are in (and you should report bugs in a modpack to the modpack author) please give me the MOD version.


Incorrect capture of parentheses inside $...$

If I have the text $((($ the syntax tree is looking like
inline_formula [0, 0] - [0, 5]

It's not recognizing anything inside the inline_formula environnment. In this case, how would I query for the contents inside the dollar signs?

Thanks for the question. The CLI does not output unnamed nodes like ( or $ but they are still part of the tree. You can take a look at the grammar in the nvim-treesitter repository as an example:
https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/latex/highlights.scm#L33


Don't check for null pointer before free, it should be handled in the free function

Pull request
Choose Correct

[X] bug
[ ] feature

Describe the pull request
Stop checking if pointer is NULL before sending it to the erpc_free function. The erpc_free should handle NULL pointer properly (like c standard free)
To Reproduce
Generate code that allocating space on the heap.
Desktop (please complete the following information):

OS: Windows
eRPC Version: 1.8.1

Steps you didn't forgot to do

[X] I checked if other PR isn't solving this issue.
[X] I read Contribution details and did appropriate actions.
[ ] PR code is tested.
[X] PR code is formatted.

Additional context

this commit fixes #274

Hi @amgross , thank you for PR, looks great. I will check other port layers if they don't need check for NULL and let you know.

I took a look on the ports and all looked OK for me, but second glance is always good

Hi @amgross:

Port erpc_port_memmanager.cpp is using some deprecating non existing macro for allocation. I will fix it, but
we need add check for null pointer for erpc_free implementation as NULL pointer would cause returning error from free function. Here and Here
Currently we are not checking return value, but in future we could add erpc_assert here to check errors. (i think i will do it very soon)
Mqx free function need same check for same reason as above

Hi @Hadatko ,
I agree that there are some ports that return error in case of NULL pointer, but it is OK as long as null pointer is checked and not referenced, and the function returns. Your changes in #277 are the first one that not doing this, and hence your changes make the free function behave different than standard library and I think it is bad idea.
Anyway i think it is not good idea to assert in case of free failure (in non debug flavor), this is just memory leak and not fatal, I will discuss it in #277 .

What is the flow of merging in this repository?
Need also @MichalPrincNXP approval?
one of you will merge it?

@amgross i am letting merging on @MichalPrincNXP. He is performing also more tests directly on NXP devices.


feat(data-table): add v10 toolbar and batch actions

REf: #1303
Changelog
New

added toolbar styling
added toolbar js
added toolbar tests
added batch action styling
added new class to overflow menu items in table row (needed to override styles)
added padding for first-of-type columns if sortable, found as a bug here: https://github.com/IBM/carbon-components-react/pull/2127#issuecomment-478759613 https://github.com/IBM/carbon-components-react/pull/2127 Can view padding change in the editable table example note: ignore edit styles, but this is the only example that has a sortable column as the first column

Changed

updated hbs for toolbar icons, batch action icons, and overflow menu icons to use carbon-icon helper instead of embedding svg through config
row expansion tests to be more specific

Removed

Unused example markup

Testing / Reviewing
Toolbar expand/hide behavior is working as expected. Batch actions is showing up as expected.

The divider next to cancel is a pixel too low. It should be 16px from top and bottom.

The margin between label and icon should be 8px. It's currently 16px.

There's some new alignment issues


In the case of temp table, the redshift Lineage cannot be obtained accurately.

Describe the bug
In the case of temp table, the redshift Lineage cannot be obtained accurately.
To Reproduce
DROP TABLE IF EXISTS tmp_table;
create temp table tmp_table as
select
a,
b
from tableAA

insert into tableBB select * from tmp_table

tableBB Lineage，not exist tmp_table、tableAA
Expected behavior
tableBB Lineage，exist tmp_table、tableAA

https://github.com/datahub-project/datahub/blob/075d19ef166177ececfbb39796de4721bdde9dc1/metadata-ingestion/src/datahub/ingestion/source/sql/redshift.py#L798-L853
The possible reason is that SVV_TABLE_INFO Do not permanently save temporary table information，Only including temporary tables created by a user for the current session. I can't find all the places where the temporary tables are redshift stored, and I may need to parse the consanguinity through ddl.

Currently, we drop tables from a lineage that does not exist anymore.
Possible solution can be to resolve those connections where A -> TempB -> C to A -> C if TempB does not exists anymore.

This was fixed by https://github.com/datahub-project/datahub/pull/9704


add event sender validation #270

Codecov Report
Base: 70.25% // Head: 70.25% // No change to project coverage :thumbsup:

Coverage data is based on head (17d3490) compared to base (e69cf98).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   70.25%   70.25%
=======================================
  Files          60       60
  Lines       11588    11588
  Branches     1565     1565
=======================================
  Hits         8141     8141
  Misses       1903     1903
  Partials     1544     1544

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Domain for the project

Hello, James. I saw your comment about getting a domain for the project. I think that would be nice, cause it would be better for sharing info about the library.

@wps13 Any suggestions? I was thinking a react-pure-loaders.io. But I am open to anything. For example my library jest-express domain is https://jest.express

How about reactpureloaders.io ? I think that not using dash would be easier to remember.

I like it. I will pick it up, and get it added.

Should have DNS and it linked with Zeit Cloud by tonight.

That's great!

:tada: This issue has been resolved in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add savant color light

for new vid/pid, and cct range: 2000K-7000K.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Moved to https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/750


ImportError: cannot import name 'KiteConnect'

Hi,
I recently purchased Kiteconnect API and trying to install kiteconnect in python.  I am getting the following error -
ImportError: cannot import name 'KiteConnect'
Here is what I did -

First command pip install --upgrade kiteconnect  - successfully installed
Second command python.exe  -m pip install -U pip setuptools - successfully updated
Third command pip show kiteconnect and here is the output I got -

Name: kiteconnect
Version: 3.8.1
Summary: The official Python client for the Kite Connect trading API
Home-page: https://kite.trade
Author: Zerodha Technology Pvt ltd. (India)
Author-email<EMAIL_ADDRESS>License: MIT
Location: c:\users\user.conda\envs\tensorflowgpu1\lib\site-packages\kiteconnect-3.8.1-py3.6.egg
Requires: requests, six, pyOpenSSL, enum34, python-dateutil, autobahn, pywin32
Required-by:
Please help.
Thanks

@tushar2708 Package installation is showing a deprecation warning. When pip get upgraded to 20.2 from 20.0.2, they will remove the support for .egg packaging. I m checking into it now.
Installation
(testenv) ➜  test pip install kiteconnect
Collecting kiteconnect
  Using cached kiteconnect-3.8.1.tar.gz (24 kB)
Requirement already satisfied: requests>=2.18.4 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (2.22.0)
Requirement already satisfied: six>=1.11.0 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (1.14.0)
Requirement already satisfied: pyOpenSSL>=17.5.0 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (19.1.0)
Requirement already satisfied: enum34>=1.1.6 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (1.1.6)
Requirement already satisfied: python-dateutil>=2.6.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (2.8.1)
Requirement already satisfied: autobahn[twisted]>=17.10.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from kiteconnect) (20.1.3)
Requirement already satisfied: idna<2.9,>=2.5 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from requests>=2.18.4->kiteconnect) (2.8)
Requirement already satisfied: certifi>=2017.4.17 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from requests>=2.18.4->kiteconnect) (2019.11.28)
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from requests>=2.18.4->kiteconnect) (3.0.4)
Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from requests>=2.18.4->kiteconnect) (1.25.8)
Requirement already satisfied: cryptography>=2.8 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from pyOpenSSL>=17.5.0->kiteconnect) (2.8)
Requirement already satisfied: txaio>=20.1.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from autobahn[twisted]>=17.10.1->kiteconnect) (20.1.1)
Requirement already satisfied: twisted>=15.4.0; extra == "twisted" in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from autobahn[twisted]>=17.10.1->kiteconnect) (19.10.0)
Requirement already satisfied: zope.interface>=3.6.0; extra == "twisted" in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from autobahn[twisted]>=17.10.1->kiteconnect) (4.7.1)
Requirement already satisfied: cffi!=1.11.3,>=1.8 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from cryptography>=2.8->pyOpenSSL>=17.5.0->kiteconnect) (1.13.2)
Requirement already satisfied: Automat>=0.3.0 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (0.8.0)
Requirement already satisfied: PyHamcrest>=1.9.0 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (2.0.0)
Requirement already satisfied: attrs>=17.4.0 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (19.3.0)
Requirement already satisfied: hyperlink>=17.1.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (19.0.0)
Requirement already satisfied: incremental>=16.10.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (17.5.0)
Requirement already satisfied: constantly>=15.1 in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from twisted>=15.4.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (15.1.0)
Requirement already satisfied: setuptools in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from zope.interface>=3.6.0; extra == "twisted"->autobahn[twisted]>=17.10.1->kiteconnect) (45.1.0)
Requirement already satisfied: pycparser in /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages (from cffi!=1.11.3,>=1.8->cryptography>=2.8->pyOpenSSL>=17.5.0->kiteconnect) (2.19)
Building wheels for collected packages: kiteconnect
  Building wheel for kiteconnect (setup.py) ... done
  WARNING: Legacy build of wheel for 'kiteconnect' created no files.
  Command arguments: /home/testuser/.virtualenvs/testenv/bin/python -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-6x5yz0mj/kiteconnect/setup.py'"'"'; __file__='"'"'/tmp/pip-install-6x5yz0mj/kiteconnect/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().repla
ce('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-nikobdjf
  Command output: [use --verbose to show]
  Running setup.py clean for kiteconnect
Failed to build kiteconnect
Installing collected packages: kiteconnect
    Running setup.py install for kiteconnect ... done
  DEPRECATION: kiteconnect from https://files.pythonhosted.org/packages/b9/0b/ab3c02f062e7c36d2e530c7bab47f47978431ee35a4ef1d5a8597528f648/kiteconnect-3.8.1.tar.gz#sha256=bc667aff2a2ffca23d1fdaf1375b765d823834aea7561369f1b6831669230000 did not indicate that it installed an .egg-info directory. Only setup.py projects
generating .egg-info directories are supported. pip 20.2 will remove support for this functionality. A possible replacement is for maintainers: updating the setup.py of kiteconnect. For users: contact the maintainers of kiteconnect to let them know to update their setup.py.. You can find discussion regarding this at
https://github.com/pypa/pip/issues/6998.
Successfully installed kiteconnect

Version
(testenv) ➜  test pip show kiteconnect
Name: kiteconnect
Version: 3.8.1
Summary: The official Python client for the Kite Connect trading API
Home-page: https://kite.trade
Author: Zerodha Technology Pvt ltd. (India)
Author-email<EMAIL_ADDRESS>License: MIT
Location: /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages/kiteconnect-3.8.1-py3.8.egg
Requires: requests, six, pyOpenSSL, enum34, python-dateutil, autobahn
Required-by:

Egg directory
(testenv) ➜  test unzip -l /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages/kiteconnect-3.8.1-py3.8.egg
Archive:  /home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages/kiteconnect-3.8.1-py3.8.egg
  Length      Date    Time    Name
---------  ---------- -----   ----
     8201  2020-02-07 15:20   EGG-INFO/PKG-INFO
      324  2020-02-07 15:20   EGG-INFO/SOURCES.txt
        1  2020-02-07 15:20   EGG-INFO/dependency_links.txt
      157  2020-02-07 15:20   EGG-INFO/requires.txt
       12  2020-02-07 15:20   EGG-INFO/top_level.txt
        1  2020-02-07 15:20   EGG-INFO/zip-safe
     3842  2020-01-06 13:13   kiteconnect/__init__.py
      335  2020-01-06 13:13   kiteconnect/__version__.py
    33363  2020-01-06 13:13   kiteconnect/connect.py
     2574  2020-01-06 13:13   kiteconnect/exceptions.py
    31968  2020-01-06 13:13   kiteconnect/ticker.py
     4006  2020-02-07 15:20   kiteconnect/__pycache__/__init__.cpython-38.pyc
      508  2020-02-07 15:20   kiteconnect/__pycache__/__version__.cpython-38.pyc
    26314  2020-02-07 15:20   kiteconnect/__pycache__/connect.cpython-38.pyc
     3687  2020-02-07 15:20   kiteconnect/__pycache__/exceptions.cpython-38.pyc
    25049  2020-02-07 15:20   kiteconnect/__pycache__/ticker.cpython-38.pyc
---------                     -------
   140342                     16 file

Sys path has correct path to egg to imports to work fine
(testenv) ➜  test ipython
/home/testuser/.local/lib/python3.8/site-packages/IPython/core/interactiveshell.py:925: UserWarning: Attempting to work in a virtualenv. If you encounter problems, please install IPython inside the virtualenv.
  warn("Attempting to work in a virtualenv. If you encounter problems, please "
Python 3.8.1 (default, Jan 22 2020, 06:38:00)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.11.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import sys

In [2]: sys.path
Out[2]:
['/home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages',
 '/home/testuser/.local/bin',
 '/usr/lib/python38.zip',
 '/usr/lib/python3.8',
 '/usr/lib/python3.8/lib-dynload',
 '',
 '/home/testuser/.local/lib/python3.8/site-packages',
 '/usr/lib/python3.8/site-packages',
 '/home/testuser/.local/lib/python3.8/site-packages/IPython/extensions',
 '/home/testuser/.ipython',
 '/home/testuser/.virtualenvs/testenv/lib/python3.8/site-packages/kiteconnect-3.8.1-py3.8.egg']

We will fix the warning before pip moves to minor version.

Fixed in https://pypi.org/project/kiteconnect/ v3.8.2


Missing lodash import in DeepEqualMatcher

DeepEqualMatcher is not importing lodash which causes a runtime error.

Can you give me an example? Most of matchers uses lodash and it works for in my project without importing it.

This is the code from the file DeepEqualMatcher.ts
import {Matcher} from './Matcher';

export function deepEqual(expectedValue:any):any {
    return new DeepEqualMatcher(expectedValue);
}

class DeepEqualMatcher extends Matcher {
    constructor(private expectedValue: any) {
        super();
    }

    match(value: any): boolean {
        return _.isEqual(this.expectedValue, value);
    }

    toString():string {
        return 'deepEqual(' + this.expectedValue + ')';
    }
}

Notice that the variable _ , in the method match, is not being defined as a lodash import.
Next time i'll do a pull request :)

Should be fixed after @michalstocki PR https://github.com/NagRock/ts-mockito/pull/5
Please close issue if it works correctly now.


be explicit about 'beacon block'

addresses #66
use "beacon block" where ever it did not seem 100% obvious the type of block in question

How's this @hwwhww https://github.com/ethereum/eth2.0-specs/pull/87/commits/75614224c7fd13bd32718a143f7c468087c5a5ba

LGTM!


Memory leak prevention issue #82

Thank you for a great library
I have taken measures against issue #82.
It seems that anonymous inner classes were not covered by GC because they kept references to outer classes.
MessageAdapter changed from strong reference to weak reference.
I performed an operation check and confirmed that memory leak does not occur in LeakCanary.

@pentam19
Awesome 👍
let me check


Working couchbase operator and cluster deployment

All CRD and RBAC work complete, and the couchbase operator deploys from operatorhub.io now. Couchbase cluster deploys on OpenShift with Rook persistent storage.

New commits all squashed, but I get into some git hell if I try to squash any further. I'll work on single commits for future PRs.

Can one of the admins verify this patch?

ok to test

rerun smoke

rerun smoke

The CI test trouble is because it is running on minishift, not minikube, and as we have discovered previously, the upstream Couchbase container images will not run correctly on 'Shift. We can adjust the CR for the tests to use 'Shift, but this requires pulling images from behind the Red Hat registry login wall.
My suggestion is that the CI system have a secret already registered as part of its build so that the downstream Red Hat image pull is available, and then we can add a "fake" pull secret to the CR to satisfy the ansible play checks.

rerun smoke

Also, since we are not benchmarking this, lets move the directory to be couchbase vs couchbase-base... Thoughts?

@jtaleric Are you taking about the role directory? Nothing is named couchbase-base, but the role dir was changed to couchbase-infra from couchbase-bench.

rerun smoke

Must of been a old copy I had.
On Mon, Mar 25, 2019 at 13:18 Dustin Black<EMAIL_ADDRESS>wrote:

@jtaleric https://github.com/jtaleric Are you taking about the role
directory? Nothing is named couchbase-base, but the role dir was changed to
couchbase-infra from couchbase-bench.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jtaleric/benchmark-operator/pull/8#issuecomment-476296372,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADyA6xZfLRy4i4S9Q-8MXr8eWk6mUAWCks5vaQTpgaJpZM4bsKPv
.

--
Joe Talerico
Mobile :<PHONE_NUMBER>

rerun smoke

rerun smoke

rerun  smoke

rerun smoke

rerun smoke

I think the current CI errors with pulling the image from the RH repo are bigger than just the test -- I can't run a deployment at all on 'Shift right now because of the image pull error.

rerun smoke

rerun smoke

rerun smoke

Share same thoughts as @jtaleric mentioned above.


Add counter to rate limit docs

Description

adds counter to the rate limit docs

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.37.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[modified] How to get description for Heart On Your Sleeve and Open S…

Added some text about how to get to badges:
Heart On Your Sleeve and Open Sourcerer

No merge?

is this really work? 💖💘💝

Reacting to stuff with a heart still doesn't give the achievement, is it fully released yet?


Missing String predicate validators

Various predicates on String would make ideal validators. Examples include

isEmpty
isNotEmpty.

I will create a pull-request that adds validators based on String predicates to the konfork-core.

Great @dvberkel !

Pull-request #5 adds these validators