Moving code in macro arguments out of macros

In src/hash.c, there are code blocks that are passed as macro arguments. These code blocks are interpreted as part of the macro function, so breakpoints cannot be set in the debugger. Also, the gcov command will aggregate them to the caller, and the code in the block will not be counted.
This patch will prevent them from being interpreted as part of a macro, and thus the aforementioned problems will no longer occur.

This patch has a performance impact.
Checked with valgrind --tool=cachegrind, bin/mrbtest increases the number of instruction cycles by 0.4 %, and the microbenchmark shown at https://github.com/mruby/mruby/pull/6414#issuecomment-<PHONE_NUMBER> increases the number of instruction cycles by about 10 %.

Recent commit (inlining h_set_without_ib_adjustment) caused conflict. I will merge this once you have resolved the conflict.

The change is to remove the prototype declaration by moving the definition position of entry_skip_deleted().
The prototype declaration of ib_it_entry() added since the last time is necessary for the convenience of the definition position of the newly added ib_it_find_by_key().
Moving ib_it_find_by_key() makes the prototype declaration unnecessary, but I think it would be better to be closer to ib_it_init().

Thank you!


Setup for building workers

This adds a task that transforms modules in the src/ol/worker directory into modules that export a create function that returns a new worker with the source of the original module.  When serving the examples, we configure a custom loader that transforms the worker modules (without minification).  Same goes for running the tests.  When the rendering tests depend on a worker, we can update the webpack config there to use the same loader.
I added an example worker that posts messages with the current version identifier.  This is not meant to stick around, but it demonstrates a worker with dependencies.  The example and test should also be deleted before a release, but they can serve as a starting point for developing more full featured workers.
With this setup, we can decide how many worker factories we want.  It may make sense to have only one initially, but eventually we may want separate workers so we don't pile all dependencies into one.
I anticipate that we'll also want to add in some utilities for message handling.  We can do this by adding utility modules that are dependencies of either the worker itself or the module that creates the worker.  I think we can do this without complicating the way workers are serialized.
Fixes #9547.

Hi,
I've tried adding a webgl worker based on this branch and it dit work really well! Setting up a new worker is straightforward, it just requires adding export default create; at the end and call that same create function when instantiating a worker. Very simple and elegant IMO.
Can't wait to dig more into optimization now!


New features with Chips

Looking for this feature on Materialize.
https://select2.github.io/examples.html#multiple
We already have Chips, multiple select and autocomplete.
Need join all together.

That would be awesome.
Images in Chips and Autocomplete or Select could be in sync.

What about including Select2 in the core features?

I found a simple library which meets the exacts needs for chips, autocomplete and multiple select to be combined, and it is much better than Select2 ( as previosuly mentioned by @Luizgpp ) . Have a look at selectizejs http://selectize.github.io/selectize.js/ . After working hours and hours on Select2, I shifted to Selectize, it has high customization abilities and simpler API.

@Dogfalo Any comments on this?

Added a first pass at chips autocomplete integration in 83e6ba0.
Would appreciate some testing. You can check it out on the latest master version under the chips docs.

@acburst sure we can do that

@developeranirudhprabhu Did you do the test? thanks!

Not yet. Been caught up with many things lately


Tilbakemeldinger på språk-feil etter TT02 deploy

Description of the bug

Steps To Reproduce

Login with user having nynorsk as selected language
Delegate service where the user is missing needed roles

Additional Information
Slack:
https://altinn.slack.com/archives/C05P3AEP3EX/p1713167254042949

@Albertlarsen
Can we close this?

@allinox yes


Add TinyVG Support

With the introduction of the GIF image decoder and animation support (#40) contributed by @ndsl7109256, it is now time to move forward with implementing TinyVG -- a compact vector graphics format designed as a lightweight alternative to SVG. The TinyVG specification is only 14 pages long, in stark contrast to the SVG 1.1 spec, which spans 260 pages (not including dependencies like CSS, XML, and ECMAScript). TinyVG achieves simplicity without sacrificing core vector graphics capabilities, making it ideal for embedded systems with limited resources.
Integrating TinyVG support into Mado could offer efficient vector graphics rendering with lower memory and computational overhead than SVG. Here are key areas to address:

File Parsing: Implement a TinyVG file parser to read the binary format efficiently, ensuring the parsing adheres to TinyVG’s specification.
Rendering Engine: Adapt Mado’s rendering pipeline to handle TinyVG graphics primitives (paths, lines, polygons, etc.) and basic fills.
Performance Considerations: Ensure smooth performance on resource-constrained devices.
Testing: Prepare sample TinyVG files and conduct visual tests to verify rendering accuracy and performance benefits.

The article An Introduction to TinyVG in C uses PlutoVG to render TinyVG, and since the vector graphics operations in PlutoVG closely align with those in Mado, it should be feasible to port the sample C-based TinyVG decoder to Mado as a new image loader.
Supporting TinyVG in Mado aligns well with the project’s goals by delivering essential vector graphics with minimal overhead.
Reference:

A vector format for Flutter
TinyVG software development kit
intvg: TinyVG image parser & renderer in Rust

Can I take this issue?

Can I take this issue?

Go ahead.

It seems that TinyVG provides an SDK that includes the ability to convert a TinyVG file into a bitmap giving a specified size. In that case, do we still need to implement rendering ourselves using Mado’s rendering pipeline? If so, perhaps we could start by implementing functions to render polygons and fill them with gradient colors?

It seems that TinyVG provides an SDK that includes the ability to convert a TinyVG file into a bitmap giving a specified size. In that case, do we still need to implement rendering ourselves using Mado’s rendering pipeline? If so, perhaps we could start by implementing functions to render polygons and fill them with gradient colors?

TinyVG SDK focuses on conversion at the moment, but we do need the proper renderer for TinyVG, making use of the vector graphics operation.

GFX implements TinyVG: src/gfx_tvg.cpp renderer.

ctx implements TinyVG renderer: src/tinyvg.c

Ladybird, a truly independent web browser, implements TinyVG image loader: Libraries/LibGfx/ImageFormats/TinyVGLoader.cpp


call modal.open() inside another function ?

Hi,
How can I use 'modal.open()' inside another function, I dont want to call it direclty on button click, but after the fucntion executes!
Can anyone help please?

Not sure about calling it from within a component function, but you can try:
(click)="firstFunction(); modal.open()"

@SELKHENIFER - sorry I missed this somehow. Please check out the example in the readme:
https://github.com/dougludlow/ng2-bs3-modal#opening-and-closing-the-modal-from-a-parent-component


Unknown Functions

I followed all of the instructions for installing on a Unix based system, and having checked my filesystem it seems like everything went correctly (plug.vim is in ~/.vim/autoload), but when I put the lines plug#begin(~/.vim/plugged) and plug#end() in my .vimrc files I get an error. When I try to open any file with vim I get errors saying

E117: Unknown function: plug#begin

and

E117: Unknown function: plug#end

None of the solutions to this that I was able to find applied to me or solved my problem.
Any help would be appreciated!

Type:

[ ] Bug
[ ] Enhancement
[ ] Feature Request
[X] Question

OS:

[ ] All/Other
[X] Linux
[ ] OS X
[ ] Windows

Vim:

[X] Terminal Vim
[ ] GVim
[ ] Neovim

Can you post your vimrc?

It's no longer really an issue. I switched to NeoVim and now it seems to be working without too much trouble. Sorry.

I have the same problem trying to install vim-plug.
13:41:10 antouank@i7 ~ vim ~/.vimrc
Error detected while processing /home/antouank/.vimrc:
line    2:
E117: Unknown function: plug#begin
line    3:
E492: Not an editor command: Plug 'tpope/vim-sensible'
line    4:
E117: Unknown function: plug#end
Press ENTER or type command to continue
13:41:47 antouank@i7 ~ cat ~/.vimrc

call plug#begin()
Plug 'tpope/vim-sensible'
call plug#end()

13:41:53 antouank@i7 ~ vim --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Mar  6 2017 14:13:23)


"SyntaxError: 'return' with value in async generator" when using async context managers

Describe the bug*
Reloadium crashes when using async context managers.
To Reproduce

Run this code in debug mode:import asyncio
from contextlib import asynccontextmanager

@asynccontextmanager
async def async_context_manager():
    print("entered async context manager")
    test_value = 1
    yield test_value
    print("exiting async context manager")

async def async_main():
    print("getting ready to enter async context manager")
    async with async_context_manager() as manager:
        print(manager)
    print("exited async context manager")

if __name__ == "__main__":
    asyncio.run(async_main())

Expected behavior
No syntax error.
Screenshots

Desktop or remote (please complete the following information):**

OS: macOS
OS version: macOS Monterey 12.4
M1 chip: no
Reloadium package version: 0.9.7
PyCharm plugin version: 0.9.2
Editor: PyCharm
Python Version: Python 3.10.0
Python Architecture: 64bit, 3.10.0 (v3.10.0:b494f5935c, Oct  4 2021, 14:59:20) [Clang 12.0.5 (clang-1<IP_ADDRESS>)]
Run mode: Debug

Additional context
If I remove the asynccontextmanager decorator, it does not crash, however the code does not work the way I'd like. This seems to be an error with reloadium because running without it, my code works as expected:
❯ python main.py
getting ready to enter async context manager
entered async context manager
1
exiting async context manager
exited async context manager

I would help debug reloadium and find a root cause but it seems corium is obfuscated.

Fixed in reloadium 0.9.9 and PyCharm plugin 0.9.4


pkg/k8s: fix race condition

Fix https://github.com/cilium/cilium/issues/13434

test-me-please

retest-gke

retest-4.9


Add a new $local_user param to the registry login

Currently we login to registries as root. This works but breaks the
expectation that anyone in the docker group should be able to use these
registries. This patch exposes a $local_user param which lets us exec as
any user and consumers of this module can specify that in their
manifests.

Hi @kasisnu. Thanks for this, much appreciated.


C C++

keyword inline solved my problem of mixed compilation C++ C. If I had tried it before... (ignorance + obstination).
Good article.
thanks
Trevisan Andrea

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e3f4058-9a81-d1d1-dbde-7622d2569d64
Version Independent ID: 09efa20f-df41-b5ba-4158-a39a2a9553a1
Content: Linker Tools Error LNK2005
Content Source: docs/error-messages/tool-errors/linker-tools-error-lnk2005.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

@seacock
Thanks for the comments. I'm closing, as this doesn't look like an issue to be addressed.


[Evaluator Ergonomics] Shuffle Evaluator Infrastructure Out Of Requests

Shuffle extra infrastructure that was supporting requests out of the requests.  All requests should now consist of the requirements of a SimpleRequest.
In particular

WhereClauseOwner owns the requirement iteration API now
DefaultTypeRequest, while well-structured, contained a lot of unnecessary getters

Also drop the extra stdlib module ref kept around by the type checker for no reason if we can just grab this from the ASTContext.

@swift-ci please smoke test

⛵


More than 2 RAM32X1Ds can be packed in a slice

Vivado can pack more than 2 RAM32X1Ds into a slice by using a single A, B, or C 6 LUT and both O5 and O6 as outputs.

https://github.com/SymbiFlow/symbiflow-arch-defs/blame/master/xc7/primitives/slicem/Ndram/README.md#L8


Unknown data type even when not using pytest.mark.randomize

In tests that use a pytest marker that's not pytest.mark.randomize, pytest-quickcheck will still inspect the data types.
Repro:

Create a new python environment
pip install pytest pytest-quickcheck
Write test_foo.py

import pytest

class Foo:
    pass

@pytest.fixture()
def foo():
    return Foo()

@pytest.mark.skip()
def test_foo(foo: Foo):
    assert True

pytest test_foo.py

venv/lib/python3.6/site-packages/pytest_quickcheck/plugin.py:113: in pytest_generate_tests
    _set_parameterize(metafunc, randomize, ann_data_option)
venv/lib/python3.6/site-packages/pytest_quickcheck/plugin.py:62: in _set_parameterize
    for _ in range(ncalls)]
venv/lib/python3.6/site-packages/pytest_quickcheck/plugin.py:62: in <listcomp>
    for _ in range(ncalls)]
venv/lib/python3.6/site-packages/pytest_quickcheck/generator.py:155: in generate
    raise NotImplementedError("Unknown data type: %s" % data)
E   NotImplementedError: Unknown data type: <class 'test_foo.Foo'>

I guess that merging https://github.com/t2y/pytest-quickcheck/pull/18 fixes this issue. Reopen if it still has the same error.

Same issue with
pytest==7.2.0
pytest-quickcheck==0.9.0

Thank you for reporting. I misunderstood this issue.

@brandon-leapyear Could you investigate and fix this issue? I welcome your pull request.

The issue is this block:
https://github.com/t2y/pytest-quickcheck/blob/48e853e61f03a08d76f47eee16fb44ab24f3fc93/pytest_quickcheck/plugin.py#L108
It's always run on every test, regardless of whether the test is marked as @pytest.mark.randomize. I won't be making a PR, as my team switched to using hypothesis instead, due to this issue.


Add Swift plugin for automatic compilation

Swift execution can be speed up by compiling and deploying the binary, rather than the source files.
Using Docker to run the container locally, users can build the executable for the correct runtime. This approach is detailed here:
https://github.com/openwhisk/openwhisk/blob/master/docs/actions.md#packaging-an-action-as-a-swift-executable
As this relies on Docker and external images, having this as the main compilation step for Swift files is not realistic. However, it would be possible to write a new serverless fw plugin that hooked into the build step and performed this automatically.

A plugin makes sense. It's certainly a requirement for using Swift in OpenWhisk as it cuts the cold-start time by a couple of seconds.
https://github.com/SwiftOnTheServer/flashcards/blob/master/api/compile.sh is how I currently do it.
Additional thoughts:

The file containing the function must be called main.swift in the Docker container as otherwise the compiler won't build it. See lines 18-21
if a Package.swift exists, then the action uses Swift's Package Manager for dependencies and it would be lovely is that was also supported. See lines 28-32

This feature can be achieved with the new OpenWhisk Swift package, Docker and NPM scripts. I've created an example using this approach here:
https://github.com/serverless/examples/tree/master/openwhisk-swift-precompiled-binaries
The npm run-script compile will running the following command.
docker run --rm -it -v $(pwd):/swift-package openwhisk/swift3action bash -e -c 'cd /swift-package && swift build -v -c release'

Using the serverless-plugin-scripts plugin, we can execute this command each time the package event is emitted.
custom:
  scripts:
    hooks:
      'package:initialize': npm run-script compile

plugins:
  - serverless-openwhisk
  - serverless-plugin-scripts


Trim content before parsing args

Fixes #76 according to my tests. However, if there is a better way to do this feel free to change it.

Thanks


Use with Laravel 5.4(+)

Any possibility to change symfony/http-foundation and other (if any) dependencies to make it work with laravel?
Full conflict log:
Using version ^0.5.2 for longman/geopayment
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for longman/geopayment ^0.5.2 -> satisfiable by longman/geopayment[0.5.2].
    - Conclusion: remove symfony/http-foundation v3.3.9
    - Conclusion: don't install symfony/http-foundation v3.3.9
    - longman/geopayment 0.5.2 requires symfony/http-foundation 3.0.* -> satisfiable by symfony/http-foundation[v3.0.0, v3.0.1, v3.0.2, v3.0.3, v3.0.4, v3.0.5, v3.0.6, v3.0.7, v3.0.8, v3.0.9].
    - Can only install one of: symfony/http-foundation[v3.0.0, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.1, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.2, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.3, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.4, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.5, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.6, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.7, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.8, v3.3.9].
    - Can only install one of: symfony/http-foundation[v3.0.9, v3.3.9].
    - Installation request for symfony/http-foundation (locked at v3.3.9) -> satisfiable by symfony/http-foundation[v3.3.9].

Thanks for the report :+1:  Should be fixed in version 0.5.3: https://github.com/akalongman/php-geopayment/commit/cfbbfa3fa7f0da16d6a034c86cde4dfffb06d951

Awesome, installed! 👍

@Stichoza any bug reports or suggestions are very welcomed from you. :octocat:


Lines get clipped in Terminal with some fonts

VSCode Version: 1.38.1
OS Version: Ubuntu 18.04.3 LTS

Steps to Reproduce:

Set Cascadia Code at 14px as your terminal font.
Observe letters with descenders (like g or j) get clipped at the bottom.

Does this issue occur when all extensions are disabled?: Yes

/duplicate https://github.com/Microsoft/vscode/issues/35901


[Bug]: Module - Cards - Grid of small cards

Prerequisites

[X] I have searched the backlog for duplicate or closed feature requests

Your test device
iPhone 13
OS Version
16.1.1
App version
0.18.0
Describe the issue
In the navigation bar 2 palette icons appear on the right
Expected Behavior
In the navigation bar only 1 palette icon should appear on the right


Optimizes forEach with for loops, delete dead code

Optimizes based on Codacy performance warnings.
.forEach(x .. y) {it -> [...]} is 3x slower than for (it in x ..y) { [...] } loops.

Honestly should consider deleting the thermal code as well because it's flat out broken.. the test always failed to work and was not written properly.

Honestly should consider deleting the thermal code as well because it's flat out broken.. the test always failed to work and was not written properly.

I was thinking of doing that myself, @jrddunbr--more power to you if you do :)

Honestly should consider deleting the thermal code as well because it's flat out broken.. the test always failed to work and was not written properly.

I was thinking of doing that myself, @jrddunbr--more power to you if you do :)

Will do next PR.

Although I'm generally not one to change conventions used throughout the source for a lowering issue (id est: a deficiency in the compiler that can be eventually fixed), these are relatively trivial changes, so if CI is happy, I'm fine with it

I tend to agree, but I want stuff to be fast :P


feat: All metric handling changes

Description of the change
All minor changes related to metric handling have been addressed in this PR.
Related issue number
Closes:

#175
#176
#177
#188
#189

How to verify the PR
Run the test cases.
Was the PR tested

[ ] I have added >=1 unit test(s) for every new method I have added.
[x] I have ensured all unit tests pass

@kmehant please review.


pip install tq not working

Do you plan to push this to pypi?

I never really bothered, works for me the way it is. You are free to fork the project and push it. It's MIT licensed.


⚠ AGEG website (prod) has degraded performance

In fb9ec45, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 4030 ms

Resolved: AGEG website (prod) performance has improved in 5e22bea.


fix exception for kika. this ensures that certain videos can be downl…

…oaded.
Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Next try: corrected/updated  'x' in boxes. If there are any issues with this, please tell me.
When trying to download certain videos from KIKA, youtube-dl crashes with an exception, e.g.
youtube-dl.exe https://www.kika.de/zacki-und-die-zoobande/sendungen/sendung123764.html
This fix ensures that at least more videos can now be downloaded successfully from KIKA.
The fix has no negative side effects as it just prevents a crash of youtube-dl.

Stop posting duplicates. There is already superior PR pending. This is your last warning.

Thank you for a first usable answer, but please don't be crude. As I'm new to GitHub and youtube-dl, I just want to understand the rules of PRs and the reason for having an invalid/duplicate PR. Apologize if I have missed an open 'superior' PR.
It makes no fun to contribute and to get no responses to any questions, and finally get 'warned'.
I appreciate your work, but I'm irritated about the way of communication.
Good communication is everything. No worries, I'll stop this PR and use my local changes.


Updated type definitions

make Provider & Notifications classes extend event-emitter in the type-definitions (just like they do in the code)
add a type definition for Notifications#aps

Coverage remained the same at 100.0% when pulling 4daccff75476e14c2694a2ed3a7e3ada1bae8218 on netroy:updated-types into f1d79ccc9d0ecfc7ad075b7e31e191e2d28f901c on node-apn:master.

Coverage remained the same at 100.0% when pulling 6597b1d830f0719b71917d34ce8733297941e803 on netroy:updated-types into f7456dfe249905ce11a27b0217991d9cc36929a1 on node-apn:master.

@florianreinhart updated & rebased


Migrate hardcoded images to Maven properties

Summary
Migrates all hardcoded images with versions into BOM
It is not possible to get rid of hardcoded images in JaegerContainer, KeycloakContainer, AmqContainer, because FW system properties  will be ignored while using them in TS
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Dependency update
[x] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Migrates all hardcoded images with versions into BOM

POM

run tests


Add font-weight to paragraph component in Figma

NB: We ended up overwriting the typography token with another font weight. Seems to work with different viewports
### Tasks
- [ ] Remove `font-weight` from typography-tokens on `Paragraph` and `Label`
- [ ] Add font-weight tokens to semantic set in tokens.
- [ ] Create variants of paragraph and label in Figma and connect them to correct font-weight tokens.
- [ ] React: Add new `font-weight` to the `Paragraph` and `Label` component
- [ ] Update token script to handle decoupled `font-weight` from typography token

@mrosvik will have a look at this

Closing this. Only change is a new font-weight to the typography component in Figma


Closes #1639 create vignette for pk programming

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

This new vignette for PK ADNCA/ADPC programming requires the update to add nominal time to create_single_dose_dataset() #1643 #1640

Hey @jeffreyad lots of merge conflicts to fix.  Let me know if you need help.

thanks @jeffreyad for the updates! will you make the same updates to the adpc template to match here? good practice to keep our ADaM vignettes and respective template consistent.

Sure, thanks @rossfarrugia

thanks @jeffreyad for the updates! will you make the same updates to the adpc template to match here? good practice to keep our ADaM vignettes and respective template consistent.

Sure, thanks @rossfarrugia

Does that mean you will drop a lot of the timing variables in that template?  I thought those were needed for the analysis?
Thanks again for pushing these through @jeffreyad!!

thanks @jeffreyad for the updates! will you make the same updates to the adpc template to match here? good practice to keep our ADaM vignettes and respective template consistent.

Sure, thanks @rossfarrugia

Does that mean you will drop a lot of the timing variables in that template? I thought those were needed for the analysis?
Thanks again for pushing these through @jeffreyad!!

@bms63 No, it should just be removing the defaults for flag_imputation, date_imputation, and ignore_seconds_flag

@jeffreyad when you get a chance can you fix the man page errors.  I can re-approve so the templates fire off and then we can get this merged!!

Thanks @jeffreyad.  This new and updated templates are great addition for admiral!!

Thank you so much for all the effort you put into creating this @jeffreyad 🥳 👏


Add wip jiggle physics to swets

Makes swets absorb entities more nicely than forcing the entity to ride the swet. WIP; a few things need to be changed and tested, see TODOs in the code comments and #developers on discord

Added some dampening, since the original code made the player spring back and forth quite vigorously. Now the player's sloshing will mellow. I didn't get rid of the sloshing entirely, since it's quite nice in small doses

White swets change color when they get different entities stuck in them. This is unique to Aether Reborn, so I get why you missed it. Fixed with the previous commit

Added pickup conditions. Will make more edits tomorrow. Feel free to add some more of your own in the meantime if you think of anything you or I have forgotten.


How is it possible to decompile a nasm generated binary using Ghidra?

I have this Binary which has been compiled using nasm, while IDA has no issues decompiling it, Ghidra just can't seem to do it?
https://filebin.net/t6qbu38q6s3yiipk
This is the file I'm trying to decompile.
EDIT: The file is MS-DOS 16bit mode btw

What processor did you select in Ghidra?  If you highlight the first byte and press "d" on your keyboard, it doesn't disassemble?

Oh ... so looks like I had to do the d on my keyboard part! thank you ♥♥


⚠ Thumbnails API Endpoint has degraded performance

In 139c098, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1290 ms

Resolved: Thumbnails API Endpoint performance has improved in b57fce1 after 9 minutes.


Add support for bigip in "virtualAddresses"

Do you already have an issue opened with F5 support?
I will open a case with f5 shortly after this and reference this issue in it
ISSUE TYPE

Feature Idea

AS3 BUILD/ VERSION

3.11.0-3

BIGIP VERSION

Sys::Version
Main Package
  Product     BIG-IP
  Version     <IP_ADDRESS>
  Build       0.0.6
  Edition     Point Release 2
  Date        Tue Jan 16 08:46:28 PST 2018

SUMMARY

When I try to reference bigip in my virtualAddress block of my PATCH declaration like so
                "virtualAddresses": [{"bigip": "/Common/<ip-address>"}],
I get the following error:
{
    "code": 500,
    "declarationFullId": "urn:uuid:33045210-3ab8-4636-9b2a-c98d22ab915d|QA1",
    "message": "Cannot read property 'split' of undefined"
}

STEPS TO REPRODUCE

[
    {
        "path": "/STG_Fix/lba",
        "op": "add",
        "value": {
            "class": "Application",
            "label": "<label>",
            "template": "generic",
            "<vip-name>": {
                "class": "Service_TCP",
                "snat": {
                    "bigip": "/Common/Floating_SNAT"
                },
                "iRules": [
                    {
                        "bigip": "/Common/<iRule-name>"
                    }
                ],
                "virtualAddresses": [{"bigip": "/Common/<ip-address>"}],
                "virtualPort": 39191,
                "pool": "/STG_Fix/Shared/<pool-name>"
            }
        }
    },
    {
        "path": "/STG_Fix/Shared/<pool-name>",
        "op": "add",
        "value": {
            "class": "Pool",
            "loadBalancingMode": "least-connections-member",
            "minimumMonitors": 2,
            "monitors": [
                {
                    "bigip": "/Common/tcp_120"
                },
				{
                    "bigip": "/Common/KILL-SWITCH-MONITOR"
                }
            ],
            "members": [
                {
                    "servicePort": <port>,
                    "addressDiscovery": "fqdn",
                    "hostname": "<server-name>.dmz.root"
                }
            ]
        }
    }
]

EXPECTED RESULTS

The vip inside a partition references a virtal address in common

ACTUAL RESULTS

I get the following error

{
    "code": 500,
    "declarationFullId": "urn:uuid:33045210-3ab8-4636-9b2a-c98d22ab915d|QA1",
    "message": "Cannot read property 'split' of undefined"
}

Was the virtual address originally declared in AS3, or is the virtual address being managed outside of AS3?

Hi Daniel,
The virtual address is managed outside of AS3.
Thanks,
Rugved.
On Tue, Oct 22, 2019 at 4:01 PM Daniel Stokes<EMAIL_ADDRESS>wrote:

Was the virtual address originally declared in AS3, or is the virtual
address being managed outside of AS3?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/F5Networks/f5-appsvcs-extension/issues/174?email_source=notifications&email_token=ANQ3AMP4ST3RDS4JVSSY3HLQP5LYRA5CNFSM4JCJI37KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7ACUA#issuecomment-545128784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANQ3AMPUHF43ORLCCV7M7WDQP5LYRANCNFSM4JCJI37A
.

Thank you for your input. I have added AUTOTOOL-859 to our internal product backlog to track this feature request.

This was resolved in the 3.19.0 release.


Move ignoreKtx() to DependenciesHandler (structure). Add deprecation.

@autonomousapps Heads up: https://github.com/autonomousapps/dependency-analysis-gradle-plugin/wiki/Customizing-plugin-behavior#ktx-dependencies is outdated now.

@autonomousapps Heads up: Wiki: Customizing plugin behavior (ktx dependencies) () is outdated now.

Thanks! Fixed.


onPress events handling

Are the onPress events handled now? Any way to circumvent this? Thanks!

onPress event still haven't been handled, onInactivity still be triggered even after several taps on buttons or screen.
Please consider this issue. Thanks!

got this same issue, have you managed to solve this @phungnlg?

@jkomyno @mouthzipper @phungnlg @afilp  any updated on this?


Search as you type

We need to implement search as you type in the search bar. There will be no need of the search button.

I can work on that if you assign it to me. @Rajdip019

Yup work on it. @saimaheshtaduri

you want me to remove the button and place the search bar on the whole width ?

Yes.

You assigned me right to this issue ?

You work on it. This pr will not be counted @saimaheshtaduri . And are you in our discord server if yes then what is your discord user name?

Yes I am on your discord. user name:  vampire »#5783

OKay got it.

This issue is resolved so closing this issue.


IndexError: string index out of range

print(generate(alphabet="12345a", size=3))
Traceback (most recent call last):
File "E:/nanoid.py", line 33, in
print(generate(alphabet="12345a", size=3))
File "E:/nanoid.py", line 26, in generate
if alphabet[byte]:
IndexError: string index out of range
Process finished with exit code 1

Thanks, I will review the PR.

v0.3.0 fixes this issue.


Failing 2.0-RC2 release

2.0-RC2 release failed a couple of times on
https://ci.eclipse.org/microprofile/job/MicroProfile Releases/419/
[INFO] [INFO]
[INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ microprofile-opentracing-spec ---
[INFO] [INFO] Installing /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/spec/pom.xml to /home/jenkins/.m2/repository/org/eclipse/microprofile/opentracing/microprofile-opentracing-spec/2.0-RC2/microprofile-opentracing-spec-2.0-RC2.pom
[INFO] [INFO] Installing /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/spec/target/microprofile-opentracing-spec-2.0-RC2.pom.asc to /home/jenkins/.m2/repository/org/eclipse/microprofile/opentracing/microprofile-opentracing-spec/2.0-RC2/microprofile-opentracing-spec-2.0-RC2.pom.asc
[INFO] [INFO]
[INFO] [INFO] --- nexus-staging-maven-plugin:1.6.3:deploy (injected-nexus-deploy) @ microprofile-opentracing-spec ---
[INFO] [INFO] Performing local staging (local stagingDirectory="/home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/target/nexus-staging/staging")...
[INFO] [INFO]  + Using server credentials "ossrh" from Maven settings.
[INFO] [INFO]  * Connected to Nexus at https://oss.sonatype.org:443/, is version 2.14.18-01 and edition "Professional"
[INFO] [INFO]  * Using staging profile ID "72ca920b8d0826" (matched by Nexus).
[INFO] [INFO] Installing /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/spec/pom.xml to /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/target/nexus-staging/staging/72ca920b8d0826/org/eclipse/microprofile/opentracing/microprofile-opentracing-spec/2.0-RC2/microprofile-opentracing-spec-2.0-RC2.pom
[INFO] [INFO] Installing /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/spec/target/microprofile-opentracing-spec-2.0-RC2.pom.asc to /home/jenkins/agent/workspace/MicroProfile Releases/target/checkout/target/nexus-staging/staging/72ca920b8d0826/org/eclipse/microprofile/opentracing/microprofile-opentracing-spec/2.0-RC2/microprofile-opentracing-spec-2.0-RC2.pom.asc
[INFO] [INFO] Performing remote staging...
[INFO] [INFO]
[INFO] [INFO]  * Remote staging into staging profile ID "72ca920b8d0826"
[INFO] [INFO]  * Created staging repository with ID "orgeclipsemicroprofile-1328".
[INFO] [INFO]  * Uploading locally staged artifacts to profile org.eclipse.microprofile
[INFO] [INFO]  * Upload of locally staged artifacts finished.
[INFO] [INFO]  * Closing staging repository with ID "orgeclipsemicroprofile-1328".
[INFO]
[INFO] Waiting for operation to complete...................................................................................
[INFO] [WARNING] TIMEOUT
[INFO]
[INFO] [ERROR] Rule failure while trying to close staging repository with ID "orgeclipsemicroprofile-1328".
[INFO] [ERROR]
[INFO] [ERROR] Nexus Staging Rules Failure Report
[INFO] [ERROR] ==================================
[INFO] [ERROR]
[INFO] [ERROR]
[INFO] [ERROR] Cleaning up local stage directory after a Rule failure during close of staging repositories: []
[INFO] [ERROR]  * Deleting context 72ca920b8d0826.properties
[INFO] [ERROR] Cleaning up remote stage repositories after a Rule failure during close of staging repositories: []
[INFO] [ERROR]  * Dropping failed staging repository with ID "orgeclipsemicroprofile-1328" (Rule failure during close of staging repositories: []).
[INFO]
[INFO] Waiting for operation to complete.....................
[INFO]
[INFO] [ERROR] Remote staging finished with a failure: Staging rules failure!
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Reactor Summary for MicroProfile OpenTracing 2.0-RC2:
[INFO] [INFO]
[INFO] [INFO] MicroProfile OpenTracing ........................... SUCCESS [  2.832 s]
[INFO] [INFO] MicroProfile OpenTracing API ....................... SUCCESS [  3.256 s]
[INFO] [INFO] MicroProfile OpenTracing TCK ....................... SUCCESS [  0.856 s]
[INFO] [INFO] microprofile-opentracing-tck ....................... SUCCESS [  3.560 s]
[INFO] [INFO] microprofile-opentracing-tck-rest-client ........... SUCCESS [  1.998 s]
[INFO] [INFO] MicroProfile OpenTracing Specification ............. FAILURE [09:33 min]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time:  09:46 min
[INFO] [INFO] Finished at: 2020-07-30T08:08:46Z
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.3:deploy (injected-nexus-deploy) on project microprofile-opentracing-spec: Remote staging failed: Staging rules failure! -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO] [ERROR]
[INFO] [ERROR] After correcting the problems, you can resume the build with the command
[INFO] [ERROR]   mvn <args> -rf :microprofile-opentracing-spec
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for MicroProfile OpenTracing 2.1-SNAPSHOT:
[INFO]
[INFO] MicroProfile OpenTracing ........................... FAILURE [10:46 min]
[INFO] MicroProfile OpenTracing API ....................... SKIPPED
[INFO] MicroProfile OpenTracing TCK ....................... SKIPPED
[INFO] microprofile-opentracing-tck ....................... SKIPPED
[INFO] microprofile-opentracing-tck-rest-client ........... SKIPPED
[INFO] MicroProfile OpenTracing Specification ............. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10:49 min
[INFO] Finished at: 2020-07-30T08:08:46Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:perform (default-cli) on project microprofile-opentracing-parent: Maven execution failed, exit code: '1' -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

I will try to release later maybe it is just a nexus fail.

The release build is constantly failing. @Emily-Jiang @kenfinnigan any idea why? https://ci.eclipse.org/microprofile/job/MicroProfile Releases/421/execution/node/52/log/

Not sure, it talks about a Sonatype rule failure, but there's also a timeout warning in the log.
I don't seem to have access to MP staging repos on sonatype anymore to see what rules failed

Done RC2 has been released


IoT MQTT Tests

Adds setConfiguration to Manager for sending device configurations
Adds tests for MQTT
Adds subscribe to configuration updates for MQTT
Prefer String.format over concatenation
Update RSA certs to not expire (private keys are torn down after tests run)
Consolidates device and manager projects as well as READMEs

AFAICT, Vision Beta is breaking the build, I'll try and fix.

Note - was all green before update

Hrrm, if you wannt me to roll back the change to the flaky vision test, I can, however, I think this fixed it.

@gguuss Ok to merge.  If it's Vision, then I don't care ATM.  We'll deal w it in 2018.


Update to v0.9.4 spec

See https://github.com/ethereum/eth2.0-specs/releases
Validator

[ ] modifications to support new ENR attesation subnet bitfield (#1534)

Networking

[ ] add ENR attestation subnet (attnets) bitfield (ethereum/eth2.0-specs#1534)
[x] override default libp2p pubsub message-id to be content-addressed (ethereum/eth2.0-specs#1538)
[x] add quick clarifying note on STATUS message (ethereum/eth2.0-specs#1540)

Can we open separate issue for ENR and put it on-ice and set discv5 as blocker?

#642


Bump github.com/prometheus/client_golang to 1.11.1 to fix CVEs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Szymon Czyzmanski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixes box#66


style: add animation iilustration

📝Changed routes:

/about
/indonesia

(view full size)
(view full size)

Commit b386a8a105f31f39eff953e65c4cfc9876452380 (https://covid-19-data-git-addanimation.sozonome.now.sh).


Additional documentation to clarify replicate options

There are a couple of interesting looking options for replicate that aren't documented at https://developer.redis.com/riot/

--event-order
--flush-interval
--skip-policy

Some questions I was hoping the documentation would be able to answer

--event-order=FIFO is self-explanatory, but it's unclear what the default (PRIORITY) actually means
When should users consider using a different --flush-interval? It's unclear what this actually controls.
--skip-policy=LIMIT is the default; how does this different from the other options (e.g. ALWAYS, LIMIT)?

Thanks for spotting this. Added to the 3.1.1 release documentation


can't call unicorn from multiple threads

workaround in ec513c11e94b66db70bb2332dff04108ca4b195b
should maybe move usercorn to a thread-safe dispatch model

ec513c11e94b66db70bb2332dff04108ca4b195b

this will be more important when usercorn is importable as a library

https://github.com/unicorn-engine/unicorn/issues/517


Spark needs micro precision in the 'in' function

Bug description
The InPredicate is registered by Spark sql and might need to provide configurable precision to adapt to both Presto and Spark.
https://github.com/facebookincubator/velox/blob/8b4663df4eb31744c7b563684d8a2f250a4d71f4/velox/functions/prestosql/InPredicate.cpp#L161
In Velox, the Spark 'in' implementation has nanoseconds precision. In vanilla Spark, the timestamp precision is microseconds.
https://github.com/facebookincubator/velox/blob/1bd480e4f9c3e48c90ab036c1dea980ff8dae264/velox/functions/sparksql/In.cpp#L78
System information
Velox System Info v0.0.2
Commit: edfb582b1bfefc6cccd4881a12ba6e1d878fb5aa
CMake Version: 3.28.3
System: Linux-5.4.0-200-generic
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 11.1.0
C Compiler: /usr/bin/cc
C Compiler Version: 11.1.0
CMake Prefix Path: /usr/local;/usr;/;/usr/local/lib/python3.8/dist-packages/cmake/data;/usr/local;/usr/X11R6;/usr/pkg;/opt
Relevant logs
No response

Probably toPrecision from #11719 would help.

Is the issue here that the precision of a Timestamp in Spark is in microseconds, and converting it to milliseconds for comparison would result in a loss of precision? For example, Timestamp(1, 999000) and Timestamp(1, 998000) would be considered the same?

@liujiayi771 I took further look and found Spark had its specific implementation. Fixed it in https://github.com/facebookincubator/velox/pull/11812 to adapt to Spark's micro precision.

@rui-mo Do we still need to adapt Spark's micro in Iceberg equality deletes reader?


Inject userinfo if in kwargs

Provide userinfo to wrapped function if userinfo is in kwargs.

:+1:  Looks good, now that its done an all


Fix modalWidthClass and add Exception

Make sure the class is applied and throw an exception if chosen width is undefined.

@Christophvh it might has to do with the whitelisting of the class, if you add these to your Tailwind config it should work as nothing has changed:
const defaultTheme = require('tailwindcss/defaultTheme');

module.exports = {

    content: [
        './vendor/wire-elements/modal/**/*.blade.php',
    ],

    safelist: [
        "sm:max-w-sm",
        "sm:max-w-md",
        "sm:max-w-lg",
        "sm:max-w-xl",
        "sm:max-w-2xl",
        "sm:max-w-3xl",
        "sm:max-w-4xl",
        "sm:max-w-5xl",
        "sm:max-w-6xl",
        "sm:max-w-7xl"
    ],

};

I already had the one we use which is the default here. I tried with all these but the same result. I also found this PR that seems to change how max-width works but we only published the config file, not the stylesheets. https://github.com/wire-elements/modal/pull/111

Are you using the include_css option? Can you verify the 2xl class has CSS applied when you inspect the modal with your browser developer tools? Also, which version of Tailwind are you using?


Links are not highlighted in footnotes

Any links inside a  doesn't appear different from the rest of the text. No underscore, no color, no nothing.
If it is intentional I would argue that it's very bad from a usability point of view. This way it's impossible to see on what one can click.

There should definitely be a distinction; referring to other blogs, it should be underlined:

I'll look into this ASAP, but I suspect it to be a CSS/styling thing so at the very least I don't think it should change how you write your blogpost.

just to be clear. I see the underline for links in the main text, but not inside the footnotes. Inspecting the CSS it seems to be on purpose, which is strange:
d-appendix a, d-appendix a.footnote-backlink {
    color: var(--global-distill-app-color) !important;
}

Interestingly, the links do appear in the hover text but not in the footnotes part of the blog post (at the end)


Build custom portfolio construction model with mean variance optimization

Expected Behavior

There should be a template for mean-variance optimization model to calculate the optimal weights for assets in the portfolio based on modern portfolio theory.
Actual Behavior

There is no such custom portfolio construction model in algorithm framework.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

Closed by #1832.


Exception: Call to Node module failed with error: Prerendering failed because of error: ReferenceError: localStorage is not defined

HI,
I have an Angular, TypeScript, .NET Core app.  I am trying to also use https://github.com/btroncone/ngrx-store-localstorage.   However, I am getting this error which looks like it has to do with localStorage not being available in node.
Exception: Call to Node module failed with error: Prerendering failed because of error: ReferenceError: localStorage is not defined
at Object.exports.localStorageSync (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\node_modules\ngrx-store-localstorage\dist\index.js:104:41)
Do you know of any work arounds here?
Thanks

Here is a full error stack.
An unhandled exception occurred while processing the request.
Exception: Call to Node module failed with error: Prerendering failed because of error: ReferenceError: localStorage is not defined
at Object. (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:1808:123)
at webpack_require (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:20:30)
at Object. (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:177:19)
at webpack_require (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:20:30)
at Object. (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:55:21)
at webpack_require (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:20:30)
at C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:40:18
at Object. (C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin\ClientApp\dist\main-server.js:43:10)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
Current directory is: C:\Users\jordanmc\Source\Repos\Xbox.Ambassadors\Microsoft.Ambassadors.Admin\Microsoft.Ambassadors.Admin
Microsoft.AspNetCore.NodeServices.HostingModels.HttpNodeInstance+d__7.MoveNext()

I am trying this https://github.com/aspnet/JavaScriptServices/issues/377

Hi,
I am trying to do the same thing and I am getting the same error.
The problem is I have Angular 4.3.6 and I have no
import { isBrowser } from 'angular2-universal';
How did you managed to do it?

I am facing the same issue, did anyone solved it?

same issue.  even used #377 still seeing this.


release v0.32.0 breaking deployments

A typo made here
https://github.com/VictoriaMetrics/operator/commit/b49e7d6e2ebf0a2cf8aced962ffb01f1427fd0db
results in failure for pods to deploy

Will release a patch for it soon.

Can you release in the community operator?
https://github.com/redhat-openshift-ecosystem/community-operators-prod/commits/main/operators/victoriametrics-operator

Was released at operatorhub. Sry for breaking changes.


Looking for Maintainers

Howdy Everyone,
Happy to see this project is useful for so many people! I'm currently working full time over at Closing Folders and we don't use JSON-API spec, so my knowledge of this project is fading.
I still think there is big value in JSON-API and it seems like lots of folks are using this project so I'm interested to hear from anyone who might want to take a more active role in maintaining things. At this point I just drop in every few months, merge any obvious fixes, and release a patch version on NPM.
Anyways, please chime in if you're interested in helping out! You can also reach out directly at<EMAIL_ADDRESS>@tomers has also been helping to maintain things so it's worth chatting with him as well.

Hey @Emerson!
I'm working with a few others in the Drupal community on a Drupal specific adaptation of this library (see Desarol/devour-drupal). Thanks to how modular it is, we were able to get away with just defining models (and setting a custom collectionPath) so big 👍  for that.
I'd be happy to help out in maintaining the underlying devour client!

@Auspicus - added you to this project. You should now have the ability to read/write/merge/manage issues.
I'll need to get you setup on npm as well so you can actually push releases

@Emerson Sure, how do we go about doing that? My npm username is edisch.

@Auspicus - added to NPM as a maintainer. You should be able to push releases now. We have some stuff setup in the package.json file that handles releases. More often than not it's just npm run release:patch

Awesome. I'll take a look at everything today after work and see what we can get out.

I use it with Django based REST JSON API projects. and have regular usage of it. I would love to help maintain this project.

In our company we're using devour in all our front-end projects. So logically we have an interest in fixing issues. I'll be glad to help out with maintenance.

@tijn and @auvipy - Added you as admins to this repo, please feel free to keep it alive and well <3

closing for now. will open if needed in future

Thanks @tijn and @auvipy for you contributions and your support for this project! Highly appreciated


Block hash is printed with  byte array format in some logs

Describe the bug
Block hash is printed with  byte array format in some logs.Like this:
Start mining with previous hash: 59, 0, 125, 56, 235, 230, 235, 28, 179, 166, 218, 117, 123, 184, 5, 71, 194, 121, 51, 232, 37, 105, 80, 105, 219, 10, 243, 144, 133, 29, 20, 167, previous height: 12
Generated block: { id: "3f5cf0ffbd340468a85360ff5753a532b1a09ebd494ed780a867c08791a3a753", height: 11 }, previous: 118, 35, 37, 50, 175, 235, 224, 6, 101, 230, 3, 65, 197, 66, 213, 6, 194, 113, 92, 144, 70, 196, 76, 98, 50, 149, 136, 164, 82, 182, 214, 72, executed transactions: 2, not executed transactions 0
And It is printed with hex format before v1.2.0
To Reproduce
Steps to reproduce the behavior:

Change log level to TRACE
Run the node
See the logs

Expected behavior
Block hash is printed with hex format.

Fixed

Fix

fixed

fixed


New time input

I was recently working with Material-UI time inputs. I found lots of them but none of them fit our company needs.
Every input is working with a value of Javascript object Date which has format like this - Mon Jun 21 2021 11:07:00 GMT+0200 (Central European Summer Time), but if I want to work just with time, I need only something like 13:30 or if 12-hour format 10:30 AM stored as a string.
I know that I could set attribute format to the Time input and set it to e.g. hh:mm but that doesn't solve the entire problem, because this is only used in validation of field and doesn't have any impact on the value of component.
I would really appreciate if you guys can help. Thanks very much.
Summary 💡
It could be pretty the same as other Material-UI time inputs that are now available, in fact, you can only add some attribute to time inputs to be able to change the value from the JavaScript Date object to just a string with simple time stored as a string.
Motivation 🔦
I'm a software engineer working in one company in the Czech Republic and we have clients from both the USA and Europe. We need an input that we can change if user sets in settings of our web application to 24 or 12 hour format. Next to the time input we have picker where user can select time zone. We now need the input that I request to fill our users needs and since we are starting to use Material-UI in our design, we want to stick to it.

You can easily convert the date to HH:mm string, for example with date-fns: format(date, 'HH:mm'). If you don't want to do this every time you use a TimePicker, you can create a wrapper component which will convert a string date in the value prop to Date object, and in onChange will convert the Date object to a string.


OKE Cluster driver: Add support for specifying a custom boot volume size on nodes

What kind of request is this (question/bug/enhancement/feature request):
feature request
Steps to reproduce (least amount of steps as possible):

Create cluster in Rancher UI
Select Oracle OKE
When configuring the node instances, we cannot adjust the size of the boot-volume that gets attached to the nodes as you can when creating an OKE cluster from the OCI console.

Result:
Boot volume size cannot be specified.
Other details that may be helpful:
Environment information

Rancher version: v2.4.8 (using rancher/rancher:latest)
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

Support for customizing the boot-volume size has been added to the OKE cluster driver.

These fields are set in the API of the cluster in Rancher
And on the backend, was able to verify the values are set on the cluster/nodepools.


Port ISS GUI to be used at ESM

See motivation here: ESM: meeting with Elio about GUI for scans - 21-ID-1 (ESM-ARPES) for Electron Spectro-Microscopy (ARPES) ( https://3.basecamp.com/3733838/buckets/4066457/messages/1055913259 )

Most likely this won't happen.


Android: Minor cosmetic issue: Paging indicator is not aligned correctly

Hey @alexrainman, again thanks for a stable plugin.
I just noticed that the PagingIndicator is not correclty centered. It seems a bit off to the left..
Device & OS:
4.4.2, Nexus 5 in Xamarin Android Player.
I am using Xamarin Android Player to test on

Lets fix that too!

I found a solution for controls HeightRequest issue, expect version 2 in couple of days :)

Maybe there's something wrong in your emulator. It looks in the center for me.

Fixed!

If my work is helping you, please help me back: https://xamarinhq.wufoo.com/forms/nominate-a-xamarin-mvp/

This is what i have done that is community visible:

Alex has been pretty active sharing his knowledge and answering questions in StackOverflow, GitHub and Xamarin Forums.
Alex has been open sourcing Xamarin components and plugin with the community, with more of 10 repositories being maintained on GitHub.
One of Alex's Xamarin.Forms plugin, the CarouselView, is currently being pulled into the Xamarin.Forms core (xamarin/Xamarin.Forms#853). As an stable widget, this control has become the standard for Xamarin.Forms carousel screens with more that 16K downloads in NuGet and more than 100 solved and not open issues.
Another Alex's plugin, the SegmentedControl (https://github.com/alexrainman/SegmentedControl), is a big candidate to be also pulled into Xamarin.Forms core.
Plus Xamarin.Forms UI related plugins, Alex shares plugins to set app icon Badge, Google Analytics and KeyChain access.
Alex shares his knowledge about cutting edge technologies like Couchbase NoSQL and MobileIron integration with Xamarin Apps.


Bumping fosite version to use community maintained JWT implementation

TL;DR
The existing JWT implementation is no longer maintained and has a existing security CVE of HIGH. By increasing the fosite version we instead use the community maintained, backwards compatible JWT implementation which has no known security issues.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/3368
Follow-up issue
NA

cc @EngHabu / @wild-endeavor


Clarified NetworkInterfaceType return values

Clarified NetworkInterfaceType return values
Fixes #3679.
Suggested Reviewers
//cc @davidsh @mairaw @logmanPL

@davidsh and @jzeferino, I've left computer unchanged, but added underlying.


fix workflow yaml warning

Description
yaml raises a warning when loading the workflow description.
Environment

rook version used, if any: 0.4.0
Python version, if any:
Operating System:

Steps to Reproduce
Run orchestrate with a workflow ... check logs:
/usr/local/src/rook/rook/workflow.py:19: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  wfdoc = yaml.load(data)

Additional Information

done.


Run tests under multiple rubies

We should test this library against the versions of Ruby we use in production. Testing against Ruby 2.2 requires the minitest gem, as minitest is no longer part of stdlib.
Also, stub env variables instead of changing ENV hash. This now uses ClimateControl to stub the environment instead of directly
modifying the ENV hash. This allows the tests to be run in a random order.

:tophat:


How to go to file from PR comment (PR buffer)

When you do Octo pr edit [number] you get a PR buffer which can contain comments on files, how do you go from the comment to a file.
I cannot put my cursor on the filename to use gf to go to the file. I tried enter and read the README but couldn't find anything

Hi @entropitor
Do you mean something like:

If so, I can make gf work if the file is found in the CWD

Yes, exactly! It would be really nice to open up your own PR and see the review comments and have an easy shortcut to go to the file at the exact location of the comment.

Implemented in https://github.com/pwntester/octo.nvim/pull/179
@entropitor, can you please test it?

I want to test it but since recently I keep getting (on the master branch):

[Octo] You are not logged into any GitHub hosts. Run gh auth login to authenticate.

even after logging in.
Running gh pr list works just fine, even from vim

https://github.com/pwntester/octo.nvim/issues/173#issuecomment-882366113 seems to be due to g:octo_viewer not being set
The PR seems to work well 👍
If we want to be fully consistent with vim gf should open file and gF should be file + line number, but for me this works

#173 (comment) seems to be due to g:octo_viewer not being set

I have experience that recently too. I have changed the way we get the octo_viewer so instead that asynchronously fetching it on octo start, which can lead to a race condition where you enter an Octo command before the octo_viewer var is ready, I fetch it synchronously on the first gh.run execution.

If we want to be fully consistent with vim gf should open file and gF should be file + line number, but for me this works

I will leave it as is for now, after all gf is just the mapping and users may change it to something else so it doesn't need to be 100% consistent with vim :)


[Bug?]   Uncaught (in promise) TypeError: error loading dynamically imported module...

I bring this here in case anyone is having the same issue in their server
Describe the bug
A clear and concise description of what the bug is.
phanpy installed in my own server (nginx)
assets/icons do not load, but are accesible by browser when clicking on the link
example:  domain.tld/assets/icons/filter-line-1KEfnWDm.js  (up to 90 resources)
https://domain.tld/assets/icons/rocket-line-rZbVYYCZ.js
with the same Uncaught (in promise) TypeError: error loading dynamically imported module: warning/error
Additional context
Add any other context about the problem here.
I have turned off any adblocker, privacy feature (I know of) on my domain, as I see in other projects with the same issue could be the root cause.  Example with vitejs
Ctrl+R (force update) "sometimes" resolves the issue (load these elements), not always.
assets are available (firefox loads and shows javascript code after clicking in the failed resource)
I personally suspect about some nginx config I'm missing. Even ./assets permissions/ownership on the server.
To Reproduce
Steps to reproduce the behavior:
open phanpy and icons and other visual elements are not present
open browser console (f12) and read the warnings
by the way, I can post/reply and do all expeted things, but visual elements are not visible.
Expected behavior
load that assets/icons
Screenshots
I think this image is lacking some elements, but actions are still available when mouse pointer is over them

Desktop (please complete the following information):

latest firefox (tested with other browsers, same issue)
latest phanpy
nginx on debian 11

Is this self-hosted?
What's the cache control header timeout for index.html?

yes
reply headers for domain.tld/phanpy (index.html, I presume)

HTTP/2 304 Not Modified
server: nginx
date: Thu, 27 Jun 2024 09:52:26 GMT
last-modified: Sun, 23 Jun 2024 09:40:58 GMT
x-sso-wat: You've just been SSOed
etag: "6677edaa-ac3"
content-security-policy: upgrade-insecure-requests
x-content-type-options: nosniff
x-xss-protection: 1; mode=block
x-download-options: noopen
x-permitted-cross-domain-policies: none
x-frame-options: SAMEORIGIN
permissions-policy: interest-cohort=()
strict-transport-security: max-age=63072000; includeSubDomains; preload
X-Firefox-Spdy: h2

no cache-control value?
could it be due theres's some origin references in the index.html document to «phanpy.social», so be a cross-origin problem as those resources being actually in my domain.tld?
More info:
in Firefox, pressing F12, then Debugger and then click in one of those missing modules, ... on the rigth there's a "phanpy" link to see this element source:
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <meta
      name="viewport"
      content="width=device-width, initial-scale=1, viewport-fit=cover"
    />
    <title>Phanpy</title>
    <meta
      name="description"
      content="Minimalistic opinionated Mastodon web client"
    />
    <meta name="color-scheme" content="dark light" />
    <link rel="icon" type="image/x-icon" href="./favicon.ico" />
    <link rel="apple-touch-icon" href="./apple-touch-icon.png" />
    <meta name="apple-mobile-web-app-title" content="Phanpy" />
    <meta name="apple-mobile-web-app-capable" content="yes" />
    <meta name="mobile-web-app-capable" content="yes" />
    <link rel="canonical" href="https://phanpy.social" />
    <meta
      name=""
      data-theme-setting="manual"
      content="#242526"
      data-theme-light-color="#fff"
      data-theme-light-color-temp="#ffff"
      data-theme-dark-color="#242526"
      data-theme-dark-color-temp="#242526ff"
    />
    <meta
      name="theme-color"
      data-theme-setting="auto"
      content="#fff"
      data-content="#fff"
      data-content-temp="#fffa"
      media="(prefers-color-scheme: light)"
    />
    <meta
      name="theme-color"
      data-theme-setting="auto"
      content="#242526"
      data-content="#242526"
      data-content-temp="#242526aa"
      media="(prefers-color-scheme: dark)"
    />
    <meta name="google" content="notranslate" />
    <link rel="me" href="https://hachyderm.io/@phanpy" />

    <meta property="twitter:card" content="summary_large_image" />
    <meta property="og:url" content="https://phanpy.social" />
    <meta property="og:title" content="Phanpy" />
    <meta
      property="og:description"
      content="Minimalistic opinionated Mastodon web client"
    />
    <meta property="og:image" content="https://phanpy.social/og-image-2.jpg" />

    <link rel="modulepreload" crossorigin href="./assets/useTitle-TOnOofzE.js">
    <link rel="modulepreload" crossorigin href="./assets/tinyld-light-PxOyhYWY.js">
    <link rel="modulepreload" crossorigin href="./assets/index-gNUvm9kb.js">
    <link rel="modulepreload" crossorigin href="./assets/fuse-sLNor9NY.js">
    <link rel="stylesheet" crossorigin href="./assets/style-LhJ7Rndd.css">
  <link rel="manifest" href="./manifest.webmanifest">

I'm by no mean a web developer so excuse me if I'm posting non-relevant info. Thank you for phanpy and your work

If it's 304, means the etag matched and server decided to return 304. You can try to force reload or clear browser cache then load. Once it's 200, check the headers again.
In short, the problem is when index.html got cached for too long and never refresh. When you deploy the new Phanpy build files, you probably deleted the old build files and they'll end up 404. All the file names are hashed, so they changed based on references. index.html could still point to the old files, and the JS files will also point to the other old asset files, and so on, continuing the chain of breakage.
There are 3 ways to solve this:

When deploying, keep the previous build files, don't delete them. This will use a lot of server disk space if you keep deploying new builds for many years without deleting old ones.
Set a very long (a year?) cache-control header on the asset files, so either the browser or your CDN server cache them. If your CDN is edge-based, this might not work as one node might cache them, the other node might not. Don't set it for index.html — you'll need this to refresh every time a new build is deployed.
Set index.html cache-control to no-cache or very low cache expiry (5 mins? I've done this before and it breaks because there's still that 5-min window of older files gone missing)

@xmgz this is how I do it. I clone the repository, and I do a git pull, then patch it[1], then an npm install, then an npm run build. I have my root directory set to the dist directory, where the new Phanpy build is placed.
[1]
diff --git a/src/components/status.css b/src/components/status.css
-  margin-left: calc(-50px - 16px);
+  margin-left: calc(-50px - 5px);

I've made a reinstall and set nginx to add_header 'Cache-Control' "no-cache";
with mixed results :smile:
I still get random problems with some visual elements/assets not loading on first load, but forcing reload (ctrl+caps+r) I can reliably load them.
At this point I think this is NOT a phanpy problem so thank you for your help and feel free to close this issue. I will keep debugging and learning following your tips.


CRF for keras 2.x

An Implementation of linear chain conditional random field (CRF), modified for keras 2.0 from previous PR https://github.com/fchollet/keras/pull/4646
Note this PR has https://github.com/farizrahman4u/keras-contrib/pull/79 merged. Please merged.

@farizrahman4u The tensorflow and keras version are not compatible in .travis checking.
The tensorflow version is 0.12. It has two concatenate functions tf.concat(axis, tensors) and tf.concat_v2(tensors, axis). However, in keras tensorflow backend, K.concatenate(tensors, axis) = tf.concat(tensors, axis). In tensorflow 1.x, tf.concat is changed to accept tensors as 1st argument.  This is the reason the CRF checking fail.
I think tensorflow should be update to version 1.x in .travis.

@linxihui Thanks for pointing it out.. please submit a PR to fix travis config so that you get the Github credits.

Cool stuff! Can anyone review?

@tboquet  using K.logsumexp now.

@tboquet  @farizrahman4u  any one do the code review?

LGTM, need confirmation from one more moderator.


Add Mock Test Case To Verify CAE Support In Mgmt SDK

Description
On par with #41984, we need to add a mock test case to verify mgmt SDK can support CAE.

Bill's PR may already had the mock test https://github.com/Azure/azure-sdk-for-java/pull/42471/files#diff-cbf0d7b60d50ccaf9e280da797115914609b96cf6e252e5192682bd775439316
@XiaofeiCao Could you double check?


Deploy-ready image

The current version of the containerized application is not suitable for deployment. We need a better, more suitable image for deploying. It might even be wise to generate one and push it into a container registry. Multi-staged builds are already being used on our Dockerfile, which is a nice step ahead.

From @pedrolucasp via Slack:
Oh yeah, just one last thing, I'm a bit concerned with our deploy-ready image, since it shouldn't do much other than build the application and that's it. Migration shouldn't even be happening on the npm start command, as that step should happen during the deploy of the new version. So ideally, the steps should be more or less:
- New version is tagged, kicks off a CI build which builds the image and drops it on some container registry
- Enters into a pipeline where it tells to pull that image some place (it depends here on the infra you'll use)
- Runs the migrations against the production/staging DB
- If all went well, spin everything up
- If the migrations failed, abort everything

From #40
I'd suggest to:

First move the application's code out of /srv, so that there is clean separation between code (read-only) and data (read-write). FHS standard places would be /opt/digitalsoul (if node_module contains architecture-specific stuff) or /usr/share/digitalsoul/app (if it's 100% interpreted code).
Cosmetic, adding to the previous point: Move /srv/app/nftdata one folder up (can be done by editing the deployment yaml)
Create a routine that runs regularly and deletes tmp files older than say 24h from the temp folder
Ensure that the folder name of .next is user-controllable, e.g. through an env var
If the contents of .next need to be persisted or if they are large, then also place it into the nftdata folder by setting the env var. Ensure that user uploads live in a separate folder and cannot collide with application-internal data.

From #41 : consider builder and runner targets; can we clean up the .next/cache linking to just have it in runner and maybe also use the runner during docker-compose (which is development)


upgrade scalaz-core 7.3.3

upgrade scalaz-core 7.3.3
https://github.com/ruippeixotog/scala-scraper/issues/189

@scala-steward Hi Steward, could I request you as a reviewer?

please release this change when you have time, thanks!


Introduce crate chain-registry and hermes config auto to automatically generate a config file

Closes: #2187
Status
Work in progress :

[x] Packet filters
[x] Doc update
[ ] Integration tests

config.toml
[global]
log_level = 'info'
[mode.clients]
enabled = true
refresh = true
misbehaviour = true
[mode.connections]
enabled = false
[mode.channels]
enabled = false
[mode.packets]
enabled = true
clear_interval = 100
clear_on_start = true
tx_confirmation = false
[rest]
enabled = false
host = '<IP_ADDRESS>'
port = 3000
[telemetry]
enabled = false
host = '<IP_ADDRESS>'
port = 3001
[[chains]]
id = 'cosmoshub-4'
type = 'CosmosSdk'
rpc_addr = 'https://rpc-cosmoshub.ecostake.com/'
websocket_addr = 'ws://rpc-cosmoshub.ecostake.com/websocket'
grpc_addr = 'https://grpc-cosmoshub-ia.notional.ventures/'
rpc_timeout = '10s'
account_prefix = 'cosmos'
key_name = 'testkey1'
key_store_type = 'Test'
store_prefix = 'ibc'
default_gas = 100000
max_gas = 400000
gas_multiplier = 1.1
max_msg_num = 30
max_tx_size = 2097152
clock_drift = '5s'
max_block_time = '30s'
memo_prefix = ''
proof_specs = '''
[
{
"leaf_spec": {
"hash": 1,
"prehash_key": 0,
"prehash_value": 1,
"length": 1,
"prefix": "AA=="
},
"inner_spec": {
"child_order": [
0,
1
],
"child_size": 33,
"min_prefix_length": 4,
"max_prefix_length": 12,
"empty_child": "",
"hash": 1
},
"max_depth": 0,
"min_depth": 0
},
{
"leaf_spec": {
"hash": 1,
"prehash_key": 0,
"prehash_value": 1,
"length": 1,
"prefix": "AA=="
},
"inner_spec": {
"child_order": [
0,
1
],
"child_size": 32,
"min_prefix_length": 1,
"max_prefix_length": 1,
"empty_child": "",
"hash": 1
},
"max_depth": 0,
"min_depth": 0
}
]'''
[chains.trust_threshold]
numerator = '1'
denominator = '3'
[chains.gas_price]
price = 0.1
denom = 'uatom'
[chains.packet_filter]
policy = 'allowall'
[chains.address_type]
derivation = 'cosmos'
[[chains]]
id = 'osmosis-1'
type = 'CosmosSdk'
rpc_addr = 'https://rpc-osmosis.ecostake.com/'
websocket_addr = 'ws://rpc-osmosis.ecostake.com/websocket'
grpc_addr = 'https://grpc-osmosis-ia.notional.ventures/'
rpc_timeout = '10s'
account_prefix = 'osmo'
key_name = 'testkey2'
key_store_type = 'Test'
store_prefix = 'ibc'
default_gas = 100000
max_gas = 400000
gas_multiplier = 1.1
max_msg_num = 30
max_tx_size = 2097152
clock_drift = '5s'
max_block_time = '30s'
memo_prefix = ''
proof_specs = '''
[
{
"leaf_spec": {
"hash": 1,
"prehash_key": 0,
"prehash_value": 1,
"length": 1,
"prefix": "AA=="
},
"inner_spec": {
"child_order": [
0,
1
],
"child_size": 33,
"min_prefix_length": 4,
"max_prefix_length": 12,
"empty_child": "",
"hash": 1
},
"max_depth": 0,
"min_depth": 0
},
{
"leaf_spec": {
"hash": 1,
"prehash_key": 0,
"prehash_value": 1,
"length": 1,
"prefix": "AA=="
},
"inner_spec": {
"child_order": [
0,
1
],
"child_size": 32,
"min_prefix_length": 1,
"max_prefix_length": 1,
"empty_child": "",
"hash": 1
},
"max_depth": 0,
"min_depth": 0
}
]'''
[chains.trust_threshold]
numerator = '1'
denominator = '3'
[chains.gas_price]
price = 0.1
denom = 'uosmo'
[chains.packet_filter]
policy = 'allowall'
[chains.address_type]
derivation = 'cosmos'

Description

Introduces a new crate able to fetch data from the chain-registry. This crate is an alternative to Ocular which is not stable. Ocular can introduce dependency issues and does not verify that the websocket interface is enabled.
Introduces command hermes config auto --path PATH --chains CHAIN1 CHAIN2 --keys KEY1 KEY2 which fetches data from the chain-registry and automatically generates a config file.
Gas settings are set to default value.

Design choices

If a ChainConfig can not be retrieved. The command fails and outputs and error.
keys is a required argument. It populates key_name in ChainConfig.
Data is fetched from a specific commit of the chain-registry.

PR author checklist:

[x] Added changelog entry, using unclog.
[ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[x] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[x] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

It doesn't seem like the CLI parameter names for the hermes config auto command adhere to ADR 010.
I will rename every parameter. I also think key-names could be optionnal.

Are users supposed to be able to pass in as many chain IDs and key names as they would like? Or are users only able to supply two chain IDs and two key names?
They are able to pass in as many chain_id and key_names as they'd like.

There's also a fair bit of duplicated code. For example, AssetList::fetch and ChainData::fetch are essentially the same functions. select_healthy_rpc and select_healthy_grpc as well. While you'd typically abstract these into traits, it looks like doing that with these functions isn't currently possible due to them being async, unless we want to pull in the async-trait crate, but that doesn't really seem worth it to me.
Indeed, my first approach was to implement a trait Fetch for AssetList and ChainData but it isn't currently possible. I did not know about async-trait. I think it would be much cleaner to use async traits here.

Regarding select_healthy* functions, I think it is possible to use generic data types however, I would like to confirm their correctness before trying to improve them. We might find that some things are missing.
Also, I think parse_or_build_grpc_endpoint should be inside select_healthy_grpc instead of health_check_grpc.

Great job! Some unit-tests for the the new command hermes config auto would be great.

I added path.rs which contains structs and functions to fetch IBC data from the chain repo.
Now I need to modify the API in order to incorporate this change. I'll most likely add a function which takes chain_names : &[&str] as argument and returns a Vec<ChainConfig>.

keys is a required argument. It populates key_name in ChainConfig.

Discussing with Luca today and we're wondering why would the keys option be required? Hermes could automatically detect in the default keystore location whether each chain has some wallets already (see keys list --chain <CHAIN_ID>), and select the first one among them. It could also output warnings if there are no wallets for the given chain, and also log to warn the user that it picked a certain wallet. Then the user could manually alter config.toml to choose a different wallet if they wish.

keys is a required argument. It populates key_name in ChainConfig.

Discussing with Luca today and we're wondering why would the keys option be required? Hermes could automatically detect in the default keystore location whether each chain has some wallets already (see keys list --chain <CHAIN_ID>), and select the first one among them. It could also output warnings if there are no wallets for the given chain, and also log to warn the user that it picked a certain wallet. Then the user could manually alter config.toml to choose a different wallet if they wish.

It makes sense, I'll put it in the TODO list

Maybe I should try to remove ChainConfig dependencies from the chain-registry crate in order to separate concerns.

keys is a required argument. It populates key_name in ChainConfig.

Discussing with Luca today and we're wondering why would the keys option be required? Hermes could automatically detect in the default keystore location whether each chain has some wallets already (see keys list --chain <CHAIN_ID>), and select the first one among them. It could also output warnings if there are no wallets for the given chain, and also log to warn the user that it picked a certain wallet. Then the user could manually alter config.toml to choose a different wallet if they wish.

@adizere @seanchen1991 This feature is now implemented !

I see how they are useful here for providing the corresponding keys in the same order, but perhaps we could improve the ux a little bit in this case by asking for CHAIN:KEY pairs? eg.
hermes config auto [OPTIONS] --path <PATH> --keys <CHAIN_1:KEY_1 CHAIN_2:KEY_2...>

The final commit incorporates this change. The command now fetches data from the last commit of the chain-registry. I think the PR is now ready to merge.

Awesome, great work Ali! Before we merge, can we also change --path to --output to avoid confusion wit/h between the path of the config file that's generated and a relay path between two blockchains

Awesome, great work Ali! Before we merge, can we also change --path to --output to avoid confusion between the path of the config file that's generated and a relay path between two blockchains?
@romac Done !

Yep, let's re-open all the PRs in v1.1 milestone

@AlianBenabdallah Looks like there are some merge conflicts that need to be resolved, but once that's done, we can merge this 🙂

It is done and ready to merge !


Unwanted uninstall pop-up interrupting Visual Studio Code

Issue Type: Bug
Repeated and unwanted periodic
interruptions by this pop-up when using Visual Studio Code. I am not wanting to uninstall it. Happens whatever code type I'm working on.
VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.22631

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.71GB (14.81GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

markdown-mermaid
bie
1.15.3

mermaid-markdown-syntax-highlighting
bpr
1.6.7

githistory
don
0.6.19

zopeneditor
IBM
3.4.0

remote-wsl
ms-
0.54.6

cpptools
ms-
1.5.1

vsliveshare
ms-
1.0.5739

java
red
1.1.0

vscode-mermaid-editor
tom
0.18.1

vscodeintellicode
Vis
1.2.14

vscode-java-debug
vsc
0.35.0

vscode-java-dependency
vsc
0.18.6

vscode-java-pack
vsc
0.21.0

vscode-java-test
vsc
0.29.0

vscode-maven
vsc
0.30.1

vscode-mermaid-preview
vst
1.6.3

markdown-all-in-one
yzh
3.4.3

vscode-extension-for-zowe
Zow
2.18.0

Using Help/Check for Updates immediately triggers this pop up -- greying out the Check for Updates option until I click cancel (pop-up). What method do you recommend for performing the recommended update ?

Also, do I need both these two items installed. They are color purple, as opposed to Visual Studio Code (blue icon). Neither seems to provide any help in upgrading Visual Studio Code...

I suggest you uninstall your version of VS Code, then install the latest version.

Can I keep the extensions and my Visual Studio Code settings -- or do I have to redo these ?

Uninstall should retain your installed extensions and settings.

Solved by deleting "Microsoft VS Code" folder under AppData/Local/Programs and doing fresh install.
Settings and plug-ins were retained while doing this.


feat(modifiers): add in-viewport, did-enter-viewport, did-exit-viewport

Closes #205.
/cc @mehulkar @snewcomer
Adds the following modifiers:

{{in-viewport}}: accepts onEnter / onExit and further named watcher options.
{{did-enter-viewport}}: accepts a positional argument as the callback and further named watcher options.
{{did-exit-viewport}}: accepts a positional argument as the callback and further named watcher options.

Exemplary usage is best seen in infinity-built-in-modifiers.hbs:
{{#if (eq this.direction "both")}}

    {{#each this.models as |artwork i|}}

        {{dummy-artwork artwork=artwork artworkProfile="dummy"}}

    {{/each}}

{{else if (eq this.direction "enter")}}

    {{#each this.models as |artwork i|}}

        {{dummy-artwork artwork=artwork artworkProfile="dummy"}}

    {{/each}}

{{else if (eq this.direction "exit")}}

    {{#each this.models as |artwork i|}}

        {{dummy-artwork artwork=artwork artworkProfile="dummy"}}

    {{/each}}

{{/if}}

Passing watcher options would look like this:

  {{dummy-artwork artwork=artwork artworkProfile="dummy"}}

  {{dummy-artwork artwork=artwork artworkProfile="dummy"}}

This PR is yet missing tests and docs.

Why the in-viewport modifier? Why introduce 2 ways to do the same thing?

Quoting from https://github.com/DockYard/ember-in-viewport/issues/205#issuecomment-534204128:

One issue I found while spiking out an implementation is that watchElement accepts configOptions:

Options as the second argument to inViewport.watchElement include intersectionThreshold, scrollableArea, viewportSpy && viewportTolerance.

I'd add these as named args to the modifiers, like so:

This is an issue, when you want to use both modifiers at the same time and may want to have different configs:

I did not deep dive into the source code yet, but maybe someone already knows whether we could support this, with a slight refactor maybe?

This assertion checks that you only ever use on modifier on a given element.

@buschtoens 👋 Just following up on this PR!  Ignore me if you are just waiting for a sliver of time to follow up.  Otherwise, just wanted to make sure you saw this:

I think if we can simplify around in-viewport modifier with optional onEnter and onExit callbacks...

if you are just waiting for a sliver of time to follow up

Yes 🙈

just wanted to make sure you saw this:

I think if we can simplify around in-viewport modifier with optional onEnter and onExit callbacks...

I didn't indeed! So you think we can drop the additional {{did-enter-viewport}} / {{did-exit-viewport}} in favor of just {{in-viewport}}?

heya! what happened here? is this going forward? I have some components that I want to make template only / tagless and this would be great to have!

Left to do IIRC:

remove {{did-enter-viewport}} / {{did-exit-viewport}} in favor of just {{in-viewport}}
write tests
write docs

Docs-wise I'd honestly recommend to do a complete revamp regarding the usage and deprecate the InViewportMixin and Ember object model entirely. Instead the officially recommended usage should be the built-in modifiers. Besides it the only other official public API should be the direct interaction with the in-viewport service.
In the scope of this PR I would completely replace the docs for Modifiers with the built-in modifiers and slightly reword Classes to put focus on the direct service usage. The complete docs revamp is out of scope, for this PR IMO.

Sorry, that I didn't get to reply yet, but thanks for merging! The tests are definitely broken / not finished and the docs are missing, but I'm not sure whether I got time to PR them anytime soon. 🙊


Update environment.yml

checking if defining pyscaffold in the env helps fixing the problem with failing tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.091%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1690

Relevant Lines:
1983

💛  - Coveralls


copied .eslintrc.js fom OBE and solving version conflicts

Description
Fixed Linter config.
Fixes #161
the yarn lint command now works.
Changes
The .eslintrc.js file was replaced with the one taken from the OBE project and some package versions were changed to avoid conflicts between them.
Visual Code config
To enable Linter on VC you need to install the following extensions:

ESLint (dbaeumer.vscode-eslint)
Prettier (esbenp.prettier-vscode)

Screenshots
Now we have some new issues to fix XD

@DevArtemNuss, this PR was marked as a draft because although is working properly (it doesn't crash) is causing all the code to turn red because it finds many many "errors".
Your mission, if you choose to accept it, is to clone this branch locally and remove one by one all the rules that are generating lots of errors. Also, we decided not to use prettier so it should be removed from the configuration as well.
Do you feel you can do that?

@donnyquixotic I would like us to agree on the ESLint rules before merging this.

What is the expected result for this PR, is it that the ESLint package is added to the project, with the intention of adding in / customizing rules later? I see that vue and typescript linting rules are disabled

What is the expected result for this PR, is it that the ESLint package is added to the project, with the intention of adding in / customizing rules later? I see that vue and typescript linting rules are disabled

I believe @Viterbo disabled rules due to the amount of errors introduced with the intention of enabling and resolving them one by one afterward. I don't have a strong opinion about whether it's all done in one PR or as follow-up tasking (as long as it's captured)

@karynemayer @Viterbo @DevArtemNuss let's agree on the rules and either merge this PR so it doesn't linger (and create follow-up issue(s) to immediately address the linting errors or agree to resolve them in this PR.