Put into filter multiselect

How I can put into filter mutli select like grid automatically do for ENUM?

Enum columns don't enable multi filtering by default, it can be achieved using .Multifilterable(true)
If you mean you want custom filtering options, you can find an example here.

I want to filter none enum, like enum multifaceted

Sorry, I can't follow.

Let’s assume we have a column with different 20 values. I want to have multifiltering like in enum out of the box. See my point?

Yes, but why filter options example not working for you then? You can specify 20 values in there.

I don't specify in enum case, so I don't want to specify in dynamic case. Just want to choose from already predefined. Let's see if I have 30+ grids, and in each 3-5 column with values. So it make sense to generate this Multifilterable online.

You don't need to specify in enum because there is a way for the grid to get those values.
In other cases you will have to load them somehow or specify in advance.

Can you provide some interface to be implemented or easier way (seamless way) to load values into the filter?

How would that look like?

    columns.Add(model => model.ContactPhone).DistinctValuesMutlifilterable().Titled("Phone");

@Muchiachio what do you think?

It will result in N+2 distinct queries for a grid, wouldn't that kill the performance?

@Muchiachio  In general in can, but it should by on my own I think.
Anyway always filterable values can be provided like this
columns.Add(model => model.OrderCreatorName).DistinctValuesMutlifilterable(FilterValues).Titled("Creator");

Made a proof of concept implementation, is this what we both have in mind?

@Muchiachio Yes!. I would also move out equals condition (conditions subfilter). It meaningless here,
as it supposed to filter by exact match.

Well, as long as it's defaults to equal and it's clear to the user that it equals to the option selected, it won't hurt to keep it.

@Muchiachio Make sense.

@Muchiachio When actually you plan to deliver this?

Should be this or next week.


Wrap tag list with div

wrap tag list with div.article-list-tags to keep
page design generality in chalk

@KOREAN139 Would it be possible to show me a before and after screenshot please? :)

@nielsenramon That was so unkind description, sorry.
here is my monitor & browser info. - MacBook Pro Retina 15-inch 2015, safari.
It has no difference before & after commit in full-size window safari.
When the browser becomes smaller (I found this in halfleft-size), there is no space between [n] minute read and tag list like this.

While the main page forms tag list like this.

So i wrapped for-loop which prints tag with div.article-list-tags, and this made articles-by-tag page can form tag list in the same way which main page does.

Fixed in another pr!


Issue #19: AreTomo plugin WIP

Description
The AreTomo for O2R allows users to perform alignment, reconstruction, or both on their data.
The three supported workflows will be

Alignment
Reconstruction (WBP or SART)
Alignment + Reconstruction (WBP or SART)

Additionally, the following corrections will be applied with the use of kwargs into the ArgParse in main/create_aretomo_yaml

Dose correction (requires pixel size, dose per tilt, tilt collection scheme, kV
CTF correction (requires spherical aberration)
Defocus correction (requires defocus)

Fixes #19
Questions

Can we repurpose existing code to prepare data for alignment? AreTomo requires an input mrc as a stack (motioncor2 output for alignment workflow, or IMOD/equivalent output for reconstruction workflow), and tilt angle file (raw tilts for alignment workflow, or corrected tilts for reconstruction?

The height of the reconstructed volume VolZ is by default automatically set by the formula VolZ = Sample thickness * Pixel size + 200 (taken from documentation), though this can be set as an absolute value if necessary. Is it feasible to ask the user to input the sample thickness/pixel size themselves? Can the pixel size be extracted from the mrc metadata somehow?

Codecov Report

Merging #24 (95aefc0) into main (66c97e4) will decrease coverage by 0.35%.
The diff coverage is 13.74%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   16.32%   15.97%   -0.36%
==========================================
  Files          12       12
  Lines        1231     1283      +52
==========================================
+ Hits          201      205       +4
- Misses       1030     1078      +48

Impacted Files
Coverage Δ

src/Ot2Rec/main.py
9.05% <13.49%> (-0.24%)
:arrow_down:

src/Ot2Rec/params.py
31.37% <20.00%> (-1.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c97e4...95aefc0. Read the comment docs.

Answer to Q2:
Yes definitely - I can think of two ways of doing that:

Import the mrcfile library and use it to read in the stack file (as numpy ndarray). The pixel spacing and other quantities in the metadata will be attributes of the image object.

This is convenient if the motion corrected or aligned tilt series is in mrc, but wouldn't work for tiffs or EER. Perhaps we might need to have a converter class to go between the formats, or convert everything to one standard for the pipeline, e.g. mrc.
Does the EER input option convert to other file formats?

Manually (using subprocess.run) to call IMOD header and grep the pixel spacing from the stdout

....I guess option 1 would be much easier? I used 2 for the EER support only because it's the only way (that I can think of) to read the metadata from the EER files.

Hmm, a bit less straightforward but if you have already implemented this maybe we could have a utils class where we do practical things like extracting any parameter from an IMOD header?

I guess we could...? Currently it's only one-purpose (for extracting the number of movie frames from EER files) so everything is hard-coded and very specific. But I guess because the headers for TIFFs / MRCs / EERs are different and their representations are different in the metadata, it might be rather difficult to generalise things.
Are there specific parameters you need to extract (regardless of image filetypes)?

More generally, usually image dimensions and bit depth is useful. For AreTomo there's spherical aberration, defocus, kV, dose per tilt, tilt collection scheme, but I'm not sure if these are in the headers or not? Maybe have the option to search for these parameters in the headers and then have users define it if not found. In the meantime maybe we can leave it as user-defined parameters, and I can open a new issue for us to set this up later after having a more thorough think about how we can do this and what we can get out of the headers.

The quantities (Cs, delta-Z, voltage etc) you listed are microscope settings so will be in the mdoc files. I don't expect to see many of them in the image headers...
I have a function in metadata for extracting the dosage from the mdoc file.


Update TeX.gitignore

Reasons for making this change:
When we use 'thmtools' package for creating 'List of Theorems', auxiliary file '.loe' is created, just as '.toc' for 'Table of Contents' and '.lof' for 'List of Figures'.
Links to documentation supporting these rule changes:
Example :
https://gist.github.com/seungwonpark/759ab6110391bfaa34a066984a7a920e

@seungwonpark I think I understand this change. Could you provide an example or snippet of what's contained in that *.loe file, and explain why it's safe to exclude from version control?

*.loe file is very similar to *.toc file. They are created from *.tex file each time when compiled, so they doesn't have to be included in version control. Following gist shows the example of *.loe and *.toc file, and results generated from them.
https://gist.github.com/seungwonpark/0221cd45c6b067a4d2c8dd0612a731e7

@seungwonpark excellent, thanks!


Podman containers do not start on reboot, even with restart: always

Steps to reproduce

Make a clean install of UCore. I'm using ostree-image-signed:docker://ghcr.io/ublue-os/ucore:stable, version 40.20240728.3.0 (2024-08-20T23:44:05Z)
Create a docker-compose.yml file.
Add in:

services:
  web:
    image: nginx
    restart: always

Start the container with podman-compose up -d
Verify the container is running with podman ps.
Reboot the machine.
The container will not automatically start after reboot.

Workaround / possible solution
I think I have figured out the issue.
There is a podman-restart.service which runs:
/usr/bin/podman start --all --filter restart-policy=always

This service is set to run as root. If I manually run that command as the root user (sudo), none of the containers will start.
If I run that command as the core user, the containers come up correctly. So I think this systemctl service should be in the user space not in the root space, and that will solve the problem.
To fix this, you can run:
# Copy the system's podman-restart service to the user location
cp /lib/systemd/system/podman-restart.service /var/home/core/.config/systemd/user

# Enable the user service
systemctl --user enable podman-restart.service

# Check that it's running
systemctl --user list-unit-files | grep podman

Then reboot, and your containers will automatically start.
It's possible you also need to enable "linger" mode on your user session, to prevent containers exiting which you've started interactively. I got this from the Podman troubleshooting page:
loginctl enable-linger $UID

I can confirm this mode is not enabled by default on UCore.

I agree with your assessment of the default state of things. There's no bug here (I recognize our bot added the bug label, not you @alangrainger )
To quote our README:

most add-on services are not auto-enabled.

I'm not included to pre-enable the podman and podman-restart system services, but even if we did, I don't think that would address the per-user, rootless situation without further effort.
I would welcome a some contribution to the "Tips and Tricks" section of the README regarding this topic.
Thanks!


writable.end(callback) is never called

writable.end(callback) or promisify(writable.end.bind(writable))() never resolve, which makes mocking createWriteStream difficult.

Thanks for feedback. Please feel free to add a PR to fix, I no longer actively work with Node or in the Node community, so this project exists purely to not break consumers.


chore(NumberTheory/MulChar): deprecate IsNontrivial, fix isPrimitive

Deprecate MulChar.IsNontrivial (following the analogous change for AddChar's a few days ago);
fix capitalisation of DirichletCharacter.isPrimitive;
adjust some lemmas to take a Nat argument with a NeZero instance, rather than a PNat, which is more general and flexible.

Can you please make sure that PRs called feat contain new content? This is not the case of this one and, since it changes API in a trivial way (everything that could be done before can still be done after with a basically one to one correspondence), it should be chore (rather than refactor, which would involve changing definitions, refactoring the API...).

Sure, sorry about that, fixed!

maintainer merge

Thanks!
bors merge


input-field: fail display improvments

pango-parseable fail_text with $FAIL as pam fail-reason
fail_color to change untagged text color and outer color
fail_transition to configure transition time between outer and fail
temporarily resize input-field if fail-message is too long

should fix #97 (https://github.com/hyprwm/hyprlock/issues/97#issuecomment-1981655505)
also accidentally fixed #144, but i'm not sure, maybe it is intended behaviour?
if so, i'll just add check in resize thing to not reshadow if fade_on_empty = true
i definitely focked-up somewhere, so double-check plz :heart:
https://github.com/hyprwm/hyprlock/assets/130279855/e09d91ab-80b3-4156-8d8e-775d39e96016

hmm wait.. do actual env vars expand now? i mean not this MR
i believe it was not so some time ago, or was it always like that?
looks odd xD


Added the contribution policy.

Codecov Report

Merging #49 (0d5c3fa) into master (338907e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage     80.08%   80.08%
  Complexity      930      930
=========================================
  Files           181      181
  Lines          4247     4247
  Branches        480      480
=========================================
  Hits           3401     3401
  Misses          657      657
  Partials        189      189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338907e...0d5c3fa. Read the comment docs.


Fix: Always resolve symlink in self.file_path and self.repo_path

I always encounter random errors when the editing file is a symlink. Always resolving symlink will fix the issue.

LGTM ✨

LGTM.  Feel free to merge this @randy3k.  You may have to accept the repo invite but, once you do, you should have merge rights.

For consistency with diff and inline diff,I have also refactored some code to use git_savvy.file_path to store current file name.


Fix: Added scrollability to Extension Request preview card

Date: 07.12.2024

Developer Name: @DepayanMondal

Issue Ticket Number

Closes #622

Description

The ER preview page previously hide the 'Raise Extension' and 'Close' button if the ER description to too long, preventing users from raising further ERs. Added scroll-ability to the preview card to address this issue.
Documentation Updated?

[ ] Yes
[x] No

Under Feature Flag

[ ] Yes
[x] No

Database Changes

[ ] Yes
[x] No

Breaking Changes

[ ] Yes
[x] No

Development Tested?

[ ] Yes
[x] No

Screenshots

Screenshot 1

https://github.com/user-attachments/assets/ed7536fc-e61b-41a9-ae02-32238aabd935

Test Coverage

Screenshot 1

Additional Notes

closing this PR as this has been taken care of by another PR - #623


Added Swagger Authentication. Fixed Refresh Token Security Issue

Added Authentication for Swagger to set the Bearer token for other Authorized API calls to test against.
Changed Authenticate function to only create a Refresh Token when no active Refresh Token is found so no Active Refresh Tokens are kept where a potential leak on the user could expose risk to the API

I added the code for the Swagger authentication but it is accepting any string that I insert as the "Bearer token".
Also, if I don't do any authentication at all the Swagger is still accessible.
Am I doing something wrong?
Thanks.

I added the code for the Swagger authentication but it is accepting any string that I insert as the "Bearer token".
Also, if I don't do any authentication at all the Swagger is still accessible.
Am I doing something wrong?
Thanks.

Swagger will always be accessible, the problem with the current implementation was that you weren't able to execute on end-points that requires authorization.
AFAIK, Swagger will accept any string (it doesn't itself know what the API token should be, it just forwards that to the authorized request you're executing through it)
That doesn't mean your end-point will be authorized to fire as this needs to be a proper bearer token that you get through authorization. So if you're saying that Swagger is accepting any bearer token AND you can execute on an end-point that's marked as [authorize] and get valid data back, then there must be something wrong.
In my tests, it didn't allow execution on those end-points with no bearer/invalid bearer details.

I added the code for the Swagger authentication but it is accepting any string that I insert as the "Bearer token".
Also, if I don't do any authentication at all the Swagger is still accessible.
Am I doing something wrong?
Thanks.

Swagger will always be accessible, the problem with the current implementation was that you weren't able to execute on end-points that requires authorization. (requiring Postman, a write-up you did on your original post)
AFAIK, Swagger will accept any string (it doesn't itself know what the API token should be or authorizes against it, it just forwards that to the authorized request you're executing)
That doesn't mean your end-point will be authorized to fire as this needs to be a proper bearer token that you get through authorization. So if you're saying that Swagger is accepting any bearer token AND you can execute on an end-point that's marked as [authorize] and get valid data back, then there must be something wrong.
In my tests, it didn't allow execution on those end-points with no bearer/invalid bearer details.

Thank you so much for your reply.
I misunderstood the use of the bearer token on Swagger.
I was expecting that the changes you made was to implement an authentication on Swagger, that is, without a valid bearer token all endpoints would be disabled.
I tested with an invalid bearer token and the login endpoint was still accessible and I got confused because I was expecting that with a wrong bearer token no endpoint would be accessible. Again, I misunderstood the use of the bearer token on Swagger.
So, to conclude, your code works perfectly, that is, with an invalid Bearer token I cannot access any endpoint that uses a bearer token for authorization and with a valid bearer token I can access any endpoint that uses a bearer token for authorization.
Thank you for your help.

No problem :) it should make it easier for anyone to test the API without having to dig into Postman, and with the fix for the refresh token, it's more secure as well :)

@vascoferraz  Just fixed up the branch a little since I'm revisiting open PR's I have and saw there's been some changes (one in another PR) that was applied to the code already.
Are you not interested in people contributing to the project via PR's? I believe my contribution to be quite helpful and solves an outstanding issue with new refresh tokens being created even though there's an active refresh token already? You possibly tried solving this issue with the addition of your remove old tokens method to keep it a bit clean, but doesn't fix the issue where multiple refresh tokens on the same day could be created (and possibly used by an exploiter that has a previous access token, even for 24 hours)
Anyway, hope you're doing well.


Hide comments

From @aimeehan1: Comments are for internal use only and should not be downloadable by external users. This includes ALL comments: Curator Note, Location, Transmission, etc.

@aimeehan1 Could you specify which other fields we should exclude?

@jim-sheldon This comment applied to downloaded / exported data. Comments are for internal curator use only. Comments could include case specific information that may impact data privacy. Example: TEST DOWNLOAD3. This example has a Transmission Comment added by the Curator that does not necessarily apply to this specific case, but instead provides general context for emerging thoughts on outbreak transmission to other Curators.
Comments should not download / export for General, Source, Location, Transmission, etc.


https://registry.docker-cn.com is down

Problem description

Problem location

I saw a problem on the following URL: https://docs.docker.com/registry/recipes/mirror/#use-case-the-china-registry-mirror

I couldn't find the information I wanted. I expected to find it near the following URL:

Other:

Project version(s) affected

Suggestions for a fix

Yes, I have the same problem：
C:\Users\XhstormR>curl -ik https://registry.docker-cn.com
curl: (7) Failed to connect to registry.docker-cn.com port 443: Timed out

BTW, it seems that Docker does not intend to provide services in China.
C:\Users\XhstormR>curl -ik https://www.docker-cn.com
HTTP/1.1 301 Moved Permanently
Content-length: 0
Location: https://www.docker.com/

a765e84efccb4ff028e8a6b79a02bff53f1dd949


Confusing

Very minor issue, but you should maybe set the default branch (on GitHub) to master? - it's pretty confusing, arriving here from packagist, the title on the landing page header matches the new package name, but the README below is screaming "this package is deprecated!". I was on the GitHub page twice this week before I realized it doesn't default to the master branch ;-)

This is due to #64 . Once 3.0 is released, the default branch can probably be reverted to master...

Oops! I recently merged rhumsaa/uuid 2.8.2 into this 2.8 branch, and it has all the deprecation warnings in the README. For a short-term fix, I'll update the README here today. Near-term, I'll be releasing 3.0 and defaulting to the master branch soon.
Sorry for the confusion.

I removed the warning message from the README. See 1c01dec0c4f71e682c540c36e0d00453a4dcd3f3

Hello @ramsey, are you able to indicate a date for 3.0 release?
Thanks

Soon? :-)
I've been swamped, so it's been difficult to devote time to wrapping things up. In my mind the only major things left are:

Docblocks for everything
Improved code coverage

Once I make headway on these items, then I'll be comfortable cutting a beta, writing some "upgrade" documentation, and then releasing a GA.


Safari Extension

This would be so awesome 🙏 GIFs in GitHub is the biggest thing I miss since I switched to Safari!

Hi @N1ck - hope you are doing well. This PR would be awesome to have for Safari, do let me know if there's anything we could do to help?

Hi @N1ck - hope you are doing well. This PR would be awesome to have for Safari, do let me know if there's anything we could do to help?

Hi @tobiasbueschel! Unfortunately, the main blocker for moving forward with this PR is the ongoing cost associated with joining the Apple Developer Program to publish the extension 😞 It's 99USD per year for an Apple Developer Program account, compared to a one-off $5 cost for a Chrome Extension.


.*: fix build fail in  linux amd64

What problem does this PR solve?
Issue Number: close #6022
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-build-release comment=true

/run-build-release comment=true

/run-build-arm64-release comment=true

/run-build-arm64-release comment=true

/run-build-release comment=true

/merge


0.15.40 Doesn't load mods or modpack

I've got mods in the mods group on the left.
I've got a modpack on the right with a group of mods in it.
I've got mods selected with checkmarks from the modpack.
I press start and it doesn't load any mods. This also occurs if i try and use the shortcut link. Never loads any mods.

It works fine for me.
Did you make sure the mods you have are compatible to the version of Factorio you are running?


Depth map edge depth value is 0

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
2.16.1

Language
C++

Issue Description
The depth map shows that the edge depth value of the object is 0. Especially when small targets are encountered, the depth map depth value is missing, resulting in insufficient point cloud data. I want to know what caused the missing edges and how I can compensate

Hi @So-LiYatao
There are many reasons for zero depth, but the main core issue is the effect of occlusion. Whenever you have two distinct view ports in 3D, you are going to find points in one view that are occluded in the other. In ideal scene with only flat planes perpendicular to the camera, you will get zero occlusion and hence very clean edges, but if geometry has a lot of convex parts (say a ball), points closer to the camera will inevitably occlude points near the edge.
In D400 products there are 3 different types of occlusion artifacts -
a. Occlusion between left viewport and right viewport (main cause of black outlines)
b. Occlusion between left viewport and the projector (reduces the amount of details near edges)
c. Occlusion between left viewport and the RGB sensor (causing artifacts near edges in texture mapping)
We provide simple heuristics to combat occlusion, check out Post Processing block in the Viewer and the relevant code-samples. More complex solution could involve two cameras to get information from occluded areas.

Hi @So-LiYatao, Do you need further help on this?
Thanks,


Prompt not preventing navigation when clicking browser back button or history.goBack() and previous page is external URL

If I go to http://google.com in my browser, then directly edit the URL in the browser's address bar to go to a page in my app with a Prompt component, that prompt component is unable to block navigation when pressing the browser's back button or executing history.goBack().
Test Case
https://codesandbox.io/s/32jzwvyy2m
Steps to Reproduce

Go to http://google.com
Copy and paste this URL into your browser's address bar: https://32jzwvyy2m.codesandbox.io/2
Click the back button

The prompt does not fire.

@pshrmn beforeunload event works if users want to leave your site., but, my case I want to prevent navigation on my site pressing the browser's back button.

If previous page is inner link, beforeunload is not work,and the page will be rerender.


bool

func (o *Stream) ToLines() (lines []string, ok bool) {
	//open C:\Users\Admin\Downloads\Compressed\xx\Driver-SoulExtraction.sln: The system cannot find the file specified.
	if strings.Contains(o.String(), "The system cannot find the file specified") {
		return
	}
	newReader := bufio.NewReader(o.Buffer)
	for {
		line, _, err := newReader.ReadLine()
		switch err {
		case io.EOF:
			return lines, true
		default:
			if !mylog.Error(err) {
				return
			}
		}
		lines = append(lines, string(line))
	}
}

If you call bool to check validity, the null pointer doesn't happen, and this pattern is used a lot in my repository to reduce the readability of nil keywords everywhere

https://github.com/ddkwork/golibrary/blob/master/stream/stream.go#L392

func SplitFileByLines(filePath string, size int) {
	lines, ok := ReadFileToLines(filePath)
	if !ok {
		return
	}

https://githubfast.com/ddkwork/golibrary/blob/master/stream/stream.go#L392

func FileExists(path string) bool {
fi, err := os.Stat(path)
if !mylog.Error(err) {
return false
}
mode := fi.Mode()
return !mode.IsDir() && mode.IsRegular()
}

response, err := o.Client.Do(request)
if !mylog.Error(err) {
	return
}
defer func() {
	if response == nil {
		mylog.Error("response == nil")
		return
	}
	if o.debug {
		println(mylog.DumpResponse(response, true))
	}
	mylog.Error(response.Body.Close())
}()
switch response.StatusCode {
case http.StatusOK, o.stopCode:

@ddkwork , I believe PR #157 should solve the problem you have reported. For the next time, it would be great if you could distill the problem you are facing in a standalone simple test code, and put that in the issue along with some description of the problem. It will help us to understand the problem and quickly answer. I am closing this issue now, but feel free to reopen if the merged PR #157 did not solve your problem. Thanks!

@ddkwork , I believe PR #157 should solve the problem you have reported. For the next time, it would be great if you could distill the problem you are facing in a standalone simple test code, and put that in the issue along with some description of the problem. It will help us to understand the problem and quickly answer. I am closing this issue now, but feel free to reopen if the merged PR #157 did not solve your problem. Thanks!

Thank you, girl. I will try.

@ddkwork , I believe PR #157 should solve the problem you have reported. For the next time, it would be great if you could distill the problem you are facing in a standalone simple test code, and put that in the issue along with some description of the problem. It will help us to understand the problem and quickly answer. I am closing this issue now, but feel free to reopen if the merged PR #157 did not solve your problem. Thanks!

After a long period of testing, I found that when the pointer returns with error or the pointer returns with bool, after error or bool fails to return, the pointer should not check whether it is nil again, because I really can't find this kind of demo to reproduce it. On the contrary, the code that is modified after this due date is messy because there are too many checks. Or can you give a demo to reproduce these two cases and have to determine whether the pointer is nil or not?

https://github.com/ddkwork/golibrary/blob/master/stream%2Fnet%2FhttpClient%2FhttpClient.go#L101-L109

D:\workspace\workspace\branch\golibrary\stream\net\httpClient>nilaway  ./...
D:\workspace\workspace\branch\golibrary\stream\net\httpClient\httpClient.go:111:2: error: Potential nil panic detected. Observed nil flow from source to dereference point:
- D:\workspace\workspace\branch\golibrary\stream\net\httpClient\httpClient.go:111:2: result 0 of NewRequest() lacking guarding; accessed field Header via the assignment(s):
- http.NewRequest(...) to request at D:\workspace\workspace\branch\golibrary\stream\net\httpClient\httpClient.go:101:2
(Same nil source could also cause potential nil panic(s) at 1 other place(s): D:\workspace\workspace\branch\golibrary\stream\net\httpClient\httpClient.go:109:2.)

func RunEnglish() (ok bool) {
client := http.Client{ //need point,this will be need check
Transport:     nil,
CheckRedirect: nil,
Jar:           nil,
Timeout:       0,
}
request, err := http.NewRequest(http.MethodGet, "https://www.google.com/", nil)
if err == nil { // The detection here is the same as below, and the request null pointer check should be skipped
return
}
request.Close = false
response, err := client.Do(request) // should skip response, null pointer check
//defer response.Body.Close() //return, and the following return will be executed here, so this code should be put behind to skip the case where the response is a null pointer
if err == nil {
return
}
defer response.Body.Close() //defer is just executing the code before return, err is nil then the response will never be nil, if err == nil then the previous code has been returned, it will not be executed here, and there will be no null pointer panic
return true
}


Sksinghspecs

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-go

@sarvesh-s The current diff is doc only, is this what you want or you have more commits to push?
Thanks,

Yes, this is all I have, only doc change.


Add Self-Monitoring plan

I have been using this plugin for a few days with the Interactive Monitoring plan from SimpliSafe but discovered it was not working anymore when downgrading to Self-Monitoring with Camera Recording, even though I had the same access from the SimpliSafe mobile app.
After some debugging, I found out that the sStatus for my plan was 7 and was filtered out from the possible subscriptions.
I tested it, and it's now working great!
Subscriptions might have changed recently, and this plugin might also work with other new plans/sStatus from SimpliSafe, but I wasn't able to try it out.

This is great, thanks! Will get it tested and released.


tagUpdatedEvent is not called when updating through LDP

To check...

That creates a bug if the number of attendees or the closing time is changed after the event is closed: the event is not updated again.


Show error in ui when pipeline creation is failed on agent side

Component
agent
Describe the bug
NOTE: I've noticed it only on the k8s backend since I'm not using others.
I had this issue with the pipelines: https://github.com/woodpecker-ci/woodpecker/issues/2931
But when I was trying to trigger a workflow, all the steps are just marked as canceled: you can see it here: https://ci.badhouseplants.net/repos/2/pipeline/10
To understand what the problem is, I had to go to logs of the agent which should have executed this job and find the reason there.
It would be a way nicer to have the error in the UI.
System Info
The problem was spotted on the Woodpecker 2.0.0, installed with the official helm chart

Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

I think I could try taking care of it


[Update] React 18.0.0

As the title says, please update for react 18.0.0

Version v2.1.0 has been released!


flash-attention

add flash-attention

Summary by CodeRabbit

New Features

Introduced new dependencies to enhance functionality: huggingface_hub and flash-attention.

These updates will improve the app's capabilities and performance.

Currently, flash-attention isn't used directly in our codebase. Could you please clarify why it's needed? We'll hold off on adding it until there's a clear requirement.


Auth Import not using correct App Client

Describe the bug
When using import auth and selecting the app client used. It doesn't seem to be respected and uses the first one in the list. If you change the non selected one, you will receive errors for example turning off (ALLOW_USER_SRP_AUTH) will cause it to break. Even tho that wasn't the app client assigned during import.
Example:
App Client A (existing in user pool already)
Create App Client B
Import and Select App Client B
Change to App Client A will impact amplify auth.
To Reproduce

In AWS console: Take an exist Auth pool; create a new app client(App Client B) for the new Application you are building.
Do Auth Import, Select existing pool and identity.
Get the option to select App client, Select the new one(App Client B).
On the first previously existing App client(App client A) turn off ALLOW_USER_SRP_AUTH

Expected behavior
That changes to the App client that you didn't pick shouldn't break amplify. I expect it to use the appropriate app client assigned.
Code Snippet
N/A: You can use any of the tutorial Auth setups
What is Configured?
const awsmobile = {
"aws_project_region": "us-east-1",
"aws_cognito_identity_pool_id": "us-east-1:xxx-xxxx-xxxx-xxxx-xxxxxxxx",
"aws_cognito_region": "us-east-1",
"aws_user_pools_id": "us-east-1_xxx",
"aws_user_pools_web_client_id": "xxxx",
"oauth": {}
};
npx: installed 1 in 1.068s
System:
OS: Windows 10 10.0.18363
CPU: (16) x64 Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
Memory: 16.02 GB / 31.92 GB
Binaries:
Node: 14.15.4 - D:\Program Files\nodejs\node.EXE
npm: 6.14.11 - D:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: 88.0.4324.190
Edge: Spartan (44.18362.449.0)
Internet Explorer: 11.0.18362.1
npmPackages:
@angular-devkit/build-angular: ^0.1102.0 => 0.1102.1
@angular/animations: ^11.2.0 => 11.2.1
@angular/cdk: ^11.2.0 => 11.2.1
@angular/cli: ^11.2.0 => 11.2.1
@angular/common: ^11.2.0 => 11.2.1
@angular/compiler: ^11.2.0 => 11.2.1
@angular/compiler-cli: ^11.2.0 => 11.2.1
@angular/core: ^11.2.0 => 11.2.1
@angular/flex-layout: ^11.0.0-beta.33 => 11.0.0-beta.33
@angular/forms: ^11.2.0 => 11.2.1
@angular/material: ^11.2.0 => 11.2.1
@angular/platform-browser: ^11.2.0 => 11.2.1
@angular/platform-browser-dynamic: ^11.2.0 => 11.2.1
@angular/router: ^11.2.0 => 11.2.1
@aws-amplify/ui-angular: ^1.0.2 => 1.0.2
@types/jasmine: ^3.6.3 => 3.6.4
@types/jasminewd2: ^2.0.8 => 2.0.8
@types/node: ^14.14.28 => 14.14.31
angular-user-idle: ^2.2.4 => 2.2.4
aws-amplify: ^3.3.20 => 3.3.20
aws-amplify-angular: ^5.0.49 => 5.0.49
codelyzer: ^6.0.0 => 6.0.1
decibel-meter: ^2.0.0 => 2.0.0
get-blob-duration: ^1.1.2 => 1.1.2
jasmine-core: ~3.6.0 => 3.6.0
jasmine-spec-reporter: ^6.0.0 => 6.0.0
karma: ^6.1.1 => 6.1.1
karma-chrome-launcher: ~3.1.0 => 3.1.0
karma-coverage: ~2.0.3 => 2.0.3
karma-jasmine: ~4.0.0 => 4.0.1
karma-jasmine-html-reporter: ^1.5.0 => 1.5.4
ng-circle-progress: ^1.6.0 => 1.6.0
protractor: ~7.0.0 => 7.0.0
recordrtc: ^5.6.1 => 5.6.1
rxjs: ~6.6.0 => 6.6.3
ts-node: ^9.1.1 => 9.1.1
tslib: ^2.0.0 => 2.1.0
tslint: ~6.1.0 => 6.1.3
typescript: ^4.1.5 => 4.1.5
uuidv4: ^6.2.6 => 6.2.6
web-animations-js: ^2.3.2 => 2.3.2
zone.js: ^0.11.4 => 0.11.4
npmGlobalPackages:
@angular/cli: 11.0.7
@aws-amplify/cli: 4.44.2
appium: 1.20.2
npm: 6.14.11
serverless: 1.83.2
Troubleshooting Methods: Removed Auth and Re-added it thinking I somehow selected the wrong one. Same issue, found other developer had made a change to his app client in the same pool. Turned back on ALLOW_USER_SRP_AUTH in his App client and it worked again.

Hey @Lacan82 :wave: what's the error you're receiving after changing settings in the unrelated app client? Are you also experiencing this issue on the latest version of the Amplify CLI?

@josefaidt it more of a bug than an issue. So You don't receive an errors.  the issue derives from making a new app client but and not adding them into the into the identify pool under authentication providers. Amplify when you import and select the one that has an incomplete configuration will use the only one with a valid configuration. Basically Amplify should recognize the newly create App client is invalid if you didn't add it to the identity pool under authentication providers and notify you of this instead of defaulting to the original app client.
I've not tested the latest version since I now know about this issue and how to successfully resolve it

@Lacan82 thank you for the details! To clarify, when you select the app client that is misconfigured the CLI is showing the wrong app client ID?

@josefaidt  So, when Amplify finalized the configuration it will default to the original one not the one you selected. So then you get the wrong app id when it generates the json file.  not the one selected.

Hey @Lacan82 I was not able to successfully reproduce using the latest version of the CLI following the steps provided on both JS and Flutter based apps. Can you try upgrading the CLI and re-importing the auth resource?

Hey @Lacan82 :wave: just wanted to check in and see if you were still experiencing this issue on the latest version of the CLI?

Closing due to inactivity. @Lacan82 if you feel this is in error and you are still experiencing this issue please reply back to this thread and we can re-open for further investigation.


Issue while using Acs commons Versioned-Clientlibs with StaticReferenceRewriter

We are using the versioned clientlibs of ACS commons. every thing is working as expected.
When we are using Acs commons StaticReferenceRewriter with Versioned Clientlibs then versioned-clientlibs stopped working.
We observed that if we change the order of versioned clientlibs later to StaticreferenceRewriter  then its started working but again StaticreferenceRewriter stopped working.
AEM 6.1
ACS Commons Version 2.2

Create  versioned-clientlibs configuration with order 1
Create SaticReferenceRewriter configuration with order 2 Versioned-clientlibs wont work.

The Versioned Clientlibs rewriter has to go before the Static Reference rewriter. This is in the documentation - http://adobe-consulting-services.github.io/acs-aem-commons/features/static-reference-rewriter.html.


Get dba error log

Fixes #
Changes proposed in this pull request:

Added Drew's code to a Get-DbaErrorLog function

How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

Shux, my updates aren't working. Can you please create a new branch, copy/paste Get-DbaErrorLog.ps1, commit only that file, then submit the PR

Closed due to re-submission


K8SPXC-625: improve logs for PITR

https://jira.percona.com/browse/K8SPXC-625
Add count of all and remaining binlogs to restore logs

Test name
Status

storage
passed

haproxy
passed

scaling
passed

scheduled-backup
passed

recreate
passed

cross-site
passed

big-data
passed

upgrade-haproxy
passed

self-healing
passed

scaling-proxysql
passed

self-healing-chaos
failed

init-deploy
failed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

demand-backup
passed

limits
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

smart-update
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

pitr
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

upgrade-consistency
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
failed

We run 33 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1129/commits/e6713d44e7d2fbe497443f98e0ef48f812b28cb9
image: perconalab/percona-xtradb-cluster-operator:PR-1129-e6713d44

Test name
Status

recreate
passed

haproxy
passed

storage
passed

scaling
passed

scheduled-backup
failed

upgrade-haproxy
passed

cross-site
failed

big-data
passed

self-healing
passed

self-healing-chaos
failed

scaling-proxysql
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

limits
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

demand-backup
passed

monitoring-2-0
passed

operator-self-healing
passed

operator-self-healing-chaos
failed

affinity
passed

one-pod
passed

smart-update
passed

auto-tuning
passed

pitr
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

upgrade-consistency
passed

tls-issue-cert-manager
passed

demand-backup-encrypted-with-tls
failed

tls-issue-cert-manager-ref
passed

validation-hook
passed

We run 35 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1129/commits/59500e0e22b9589194a8ce2fd07b35ba88cbf4e3
image: perconalab/percona-xtradb-cluster-operator:PR-1129-59500e0e

Test name
Status

haproxy
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

big-data
passed

affinity
passed

one-pod
passed

auto-tuning
passed

storage
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

self-healing
passed

recreate
passed

scaling
passed

cross-site
failed

upgrade-haproxy
passed

self-healing-chaos
failed

users
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

tls-issue-self
passed

security-context
passed

demand-backup
passed

tls-issue-cert-manager
passed

pitr
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

demand-backup-encrypted-with-tls
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

operator-self-healing
passed

operator-self-healing-chaos
failed

We run 35 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1129/commits/59500e0e22b9589194a8ce2fd07b35ba88cbf4e3
image: perconalab/percona-xtradb-cluster-operator:PR-1129-59500e0e

Test name
Status

big-data
passed

scaling
passed

cross-site
failed

storage
passed

scheduled-backup
passed

haproxy
passed

upgrade-haproxy
passed

recreate
passed

scaling-proxysql
passed

self-healing
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

self-healing-chaos
failed

limits
passed

demand-backup
passed

monitoring-2-0
passed

pitr
passed

demand-backup-encrypted-with-tls
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

self-healing-advanced-chaos
failed

operator-self-healing
passed

operator-self-healing-chaos
failed

We run 35 out of 35

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1129/commits/59500e0e22b9589194a8ce2fd07b35ba88cbf4e3
image: perconalab/percona-xtradb-cluster-operator:PR-1129-59500e0e


chore(simplify): Make tests reusable

split repeated tasks into separate playbooks
pass variables to deduplicate the code

Signed-off-by: Artem Goncharov<EMAIL_ADDRESS>

Lgtm too, everything seems to be modified accordingly.


feat: Make arrays and slices polymorphic over each other

Description

Problem*
Resolves #1963
Resolves #1931
Resolves #1842
Resolves #1354
Summary*
Instead of representing Type::Array(size, elem) as a separate type from Type::Slice(elem) and allowing them to intermingle via subtyping, this PR removes the subtyping relationship and the Type::Slice variant entirely. Now, array literals have a polymorphic "MaybeConstant" size that can later be resolved to either a Constant size (array) or a NotConstant size (slice). This also means we no longer need type annotations to create slice literals.
BREAKING CHANGES:
- Arrays and slices are no longer subtypes of each other. So if you have an array and you need to pass it to a function that only accepts a slice, you now need to add an explicit .as_slice().

I've added an array to slice coercion so there should no longer be any breaking changes.

Documentation

[x] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[x] I will request for and support Dev Rel's help in documenting this PR.

An array literal [a, b, c, ..] can now resolve to either an array or a slice depending on how it is used.
This is just like how an integer literal can resolve to any integer type depending on how it is used.
Just like integer literals, if you want to convert between arrays and slices you now need an explicit conversion function.
Users wishing to write a function that is polymorphic over arrays and slices can still use the fn foo<T, N>(array_or_slice: [T; N]) syntax since slices are considered to be arrays internally of a non-constant size (implementation detail).

Additional Context
I'm putting this PR out a bit early for visibility and because I need the CI to help find which tests need a .as_slice() to be added.
PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

I think I'll try to add rust's implicit coercion of array to slice. This should no longer be a breaking change afterward.

This PR is currently held up by an error in brillig_slices:
the application panicked (crashed).
Message:  internal error: entered unreachable code: ICE: Expected array, got HeapVector(HeapVector { pointer: RegisterIndex(6), size: RegisterIndex(7) })
Location: crates/noirc_evaluator/src/brillig/brillig_gen/brillig_fn.rs:114

This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 13 frames hidden ⋮
  14: noirc_evaluator::brillig::brillig_gen::brillig_fn::FunctionContext::extract_heap_array::h612d83e614e579d9
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen/brillig_fn.rs:114
  15: noirc_evaluator::brillig::brillig_gen::brillig_block::BrilligBlock::convert_ssa_value::h03347b8489e010ae
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs:803
  16: noirc_evaluator::brillig::brillig_gen::brillig_block::BrilligBlock::convert_ssa_instruction::h435b587b3c58d1e0
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs:236
  17: noirc_evaluator::brillig::brillig_gen::brillig_block::BrilligBlock::convert_block::h3079b65c1c7e2aaa
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs:61
  18: noirc_evaluator::brillig::brillig_gen::brillig_block::BrilligBlock::compile::h4903fe94bd90897c
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs:47
  19: noirc_evaluator::brillig::brillig_gen::convert_ssa_function::h6239c1d6fcb032a1
      at /.../noir/crates/noirc_evaluator/src/brillig/brillig_gen.rs:28
  20: noirc_evaluator::brillig::Brillig::compile::h3cd51d3807fe3513
      at /.../noir/crates/noirc_evaluator/src/brillig/mod.rs:28
  21: noirc_evaluator::brillig::<impl noirc_evaluator::ssa_refactor::ssa_gen::program::Ssa>::to_brillig::h58acb38d118edfdd
      at /.../noir/crates/noirc_evaluator/src/brillig/mod.rs:99
  22: noirc_evaluator::ssa_refactor::optimize_into_acir::h96fd7ea2cbc06f17
      at /.../noir/crates/noirc_evaluator/src/ssa_refactor.rs:48
  23: noirc_evaluator::ssa_refactor::create_circuit::h3221b5c03c1245cd
      at /.../noir/crates/noirc_evaluator/src/ssa_refactor.rs:81
  24: noirc_driver::compile_no_check::ha192bac6b09f9ae5
      at /.../noir/crates/noirc_driver/src/lib.rs:306
  25: noirc_driver::compile_main::h159318b5103cbeb1
      at /.../noir/crates/noirc_driver/src/lib.rs:195
  26: nargo_cli::cli::compile_cmd::compile_circuit::h750de128d64d5da7
      at /.../noir/crates/nargo_cli/src/cli/compile_cmd.rs:128
  27: nargo_cli::cli::prove_cmd::prove_with_path::hc2b46b42c1fbf6f9
      at /.../noir/crates/nargo_cli/src/cli/prove_cmd.rs:112
  28: nargo_cli::cli::prove_cmd::run::h9a42555316685c8e
      at /.../noir/crates/nargo_cli/src/cli/prove_cmd.rs:68
  29: nargo_cli::cli::start_cli::hafb3033a71756cdf
      at /.../noir/crates/nargo_cli/src/cli/mod.rs:80
  30: nargo::main::hb051dd85bb9ddb14
      at /.../noir/crates/nargo_cli/src/main.rs:14
  31: core::ops::function::FnOnce::call_once::he90185e242af6ac8
      at /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/ops/function.rs:251
                                ⋮ 13 frames hidden ⋮
exit 101

Any insight into this @sirasistant?

Yes, fixed in https://github.com/noir-lang/noir/pull/2080. The problem was that it was previously assumed that a Value::Array was always had Type::Array, which is no longer the case. Also improved a bit the brillig_slices test now that references have coherent typing!

@sirasistant I've pushed an array -> slice coercion so that this is no longer a breaking change. I think this recovers the lost ergonomics as well. It works by implicitly adding a .as_slice() call when needed, so the backend does not have to worry about values changing types.


New-IntuneMobileApp for Office 365

Hi how do I publish the Office 365 suite for Windows in Intune? I can see that you can see the info from Get-IntuneMobileApp:

But the New-IntuneMobileApp does not allow me to upload with similar parameters. Am I using the wrong cmdlet?

As of July 29th 2019, it looks like only the "macOSOfficeSuiteApp" entity type is available in the v1.0 schema.  The "officeSuiteApp" object that you see in your results was probably created through the beta schema, where that entity type does exist.


Issue #554: Grails params missing values with PUT and PATCH after add spring security core

Issue #554: Grails params missing values with PUT and PATCH after add spring security core
Summary
PUT requests with content-type application/x-www-form-urlencoded were not returning parameters when grails-spring-security-core was enabled.
The reason is that the HttpPutFormContentFilter was not registered.  Registering it allows for PUT requests to work as expected.
This PR does the following:

adds testCompile "org.grails:grails-datastore-rest-client:5.0.0.RC2"to build.gradle so that I may have access to RestBuilder from within functional tests
adds tests for PUT and PATCH requests that verify parameters are available for content-types of "application/x-www-form-urlencoded"
adds a test controller for use during functional tests
extends HttpPutFormContentFilter and overrides doFilterInternal so that it plays nicely with the request, i.e. not result in reading request body twice
adds a new test config so that travis can verify params are in put requests
adds secured endpoint to TestFormParamsController for use during testing
modifies travis-build.sh to kick off form param tests

@ddelponte could add a test for this line:
https://github.com/grails-plugins/grails-spring-security-core/blob/issue554/plugin/src/main/groovy/grails/plugin/springsecurity/web/filter/GrailsHttpPutFormContentFilter.groovy#L41

@sdelamo it looks like your changes have broken some StaticSecuritySpec tests.
Would you be able to take a look.
I've spent some time debugging and it's not obvious to me why your changes would cause the internal server error we're now seeing.
I've confirmed that rolling back the code prior to your commits allows the tests to pass.

I resolved the last of the failing tests by reverting a change I inadvertently committed to application.groovy: 80563ff9766b60f7acd7e5dae10ccf8a7418829c
I've also verified that the line of code you referenced for a test:  https://github.com/grails-plugins/grails-spring-security-core/blob/issue554/plugin/src/main/groovy/grails/plugin/springsecurity/web/filter/GrailsHttpPutFormContentFilter.groovy#L41
is tested in both RoleSpec and TestFormParamsControllerSpec.
I think this may be ready to merge

Thanks @ddelponte
I have created a commit with Squashed commits of this PR.


Enhancement | Reorganize credential sections

Describe the Feature
IAM Credentials and SSO Credentials workflows should be under https://leverage.binbash.com.ar/user-guide/ref-architecture-aws/credentials/

The general idea is to congregate the sections about SSO, IAM/MFA and all of those related to identities under a single index page section in order to improve the ordering of that information.

Let's please consider adding this => https://binbashar.slack.com/archives/GG0PJ78J3/p1672845845930149

@angelofenoglio let's consider adding this info in the doc or closer to the code if needed to keep this into consideration:

The reason for the SRC_* AWS files. Yes, it's legacy, but we still need it - it's the reason why Terraform works in the container.
When you start the container, the config file on your host contains the profiles from which we obtain the information that allows us to assume the IAM role, while the credentials contain the credentials to assume that IAM role. These two files are mounted at /root/tmp/<project> to make them available and obtain that information.
Once the roles are assumed, those credentials are written to /root/.aws/<project>/credentials (inside the container) under the name of the profile from which the information was obtained to assume the role ([profile <project>-security-devops], for example) so that they are available for Terraform. If we were to write those credentials instead to /root/tmp/<project>/credentials and point AWS_SHARED_CREDENTIALS_FILE there, they would be overshadowed by the profiles defined in /root/tmp/<project>/config, and Terraform would not be able to see them, as well as pollute the credentials of the host.

CC: @Franr @diego-ojeda-binbash @juanmatias

Given that so much has changed since we last worked on this issue, here's what I think it's still missing and thus I think what this issue should be about:

We still need some sort of entry page in the documentation that briefly explains how Leverage handles credentials and then links to specific sections for further details.

Note on this thread https://binbashar.slack.com/archives/GG0PJ78J3/p1672845845930149 => The definitions are here https://binbashar.slack.com/archives/GG0PJ78J3/p1672847354433219?thread_ts=1672845845.930149&cid=GG0PJ78J3 -- you can safely skip the rest as they are not related to this issue which is about the documentation. Any changes to the Ref Arch's baselines should be part of a different issue.

Changes can be seen in this PR: https://github.com/binbashar/le-ref-architecture-doc/pull/207


Good-bye CodeRay and hello Rouge

We want to paste Swift code!
ref: https://github.com/jneen/rouge/


[Parse] Avoid creating binding patterns in a couple more positions

If we have an identifier followed by either [ or a generic argument list, avoid turning it into a binding pattern, as that would be invalid. This is similar to the existing rule we have where a following ( prevents a binding pattern from being formed.
This allows patterns such as let E<Int>.foo(x) and let (y[0], x) to compile, where x is treated as a binding, but no other identifier is.
rdar://108738034

https://github.com/apple/swift-syntax/pull/1804
@swift-ci please test


Random numbers

Your operating system: gobylang/goby:v0.1.10
How did you install Goby: Docker
Goby version: v0.1.10
The value of $GOBY_ROOT: /go/src/github.com/goby-lang/goby
Error messages: UndefinedMethodError: Undefined Method 'rand' for <Instance of: Object>
There doesn't seem to be a way to generate random numbers.

@lara yeah you're right, we don't have such method atm. do you consider adding one 😄

@st0012 sure!

I think using the secure crypto/rand is good. math/rand is less secure.


CURL to Generate Access Token is not working when disabled "Client Credential" grant type

Describe your problem(s)
Once after disabling the client-credentials grant type, the 'CURL TO GENERATE ACCESS TOKEN' button also not working(after clicking it, there are no any outcome) even the password grant type selected for the particular application.When disabling the client-credentials grant type, it is removing the 'GENERATE ACCESS TOKEN' button and adds the 'Enable Client Credentials grant type to generate test access tokens' message. Which is expected and working fine.

Describe your solution
In a scenario like, password grant enabled and client credentials grant disabled for an application, then I guess it would be good to have the CURL generation button with only the password grant details.
Suggested Labels:
APIM-4.0.0
latest update level of <IP_ADDRESS>

When the password grant is enabled and the client credentials grant is disabled for an application, the CURL generation button is available.
But it includes details for both the password grant and the client credentials grant, even though the client credentials grant is disabled. (in the latest version)


feat: org-habit

Added a simple way to make the org-habit consistency graphs align to the
right margin as well as being responsive to the width of the window.
This is added as a feature to the org module.

The changes you suggested have been implemented. Thanks! :)

As you can see, I have rebased my branch - Do you prefer merge commits?
Also, do you prefer to squash commits before merging?

Looks good. Thanks for the help!

As you can see, I have rebased my branch - Do you prefer merge commits?

I prefer rebasing, unless multiple people are working on the PR.

Also, do you prefer to squash commits before merging?

I generally don't. I do want to avoid convoluting development history with trivial or fragmented commits, but I'll bring it up if I think it's a problem. I don't think it is with this PR.


On a fresh cluster deployment, all links in /usr/local/bin are broken for unpriviledged users

$ id
uid=1000(manu) gid=1000(manu) groups=1000(manu),10(wheel),987(libvirt)

$ file /usr/local/bin/*
/usr/local/bin/helm:              broken symbolic link to /opt/openshift-client-4.5.2/helm
/usr/local/bin/kubectl:           broken symbolic link to /opt/openshift-client-4.5.2/kubectl
/usr/local/bin/oc:                broken symbolic link to /opt/openshift-client-4.5.2/oc
/usr/local/bin/openshift-install: broken symbolic link to /opt/openshift-install-4.5.2/openshift-install
~~

Not everybody wants to run oc / helm as root, even on a testing playground :)
Would you be interested in a pull request to fix that ?

Oh indeed, that's not very useful.
$ ls -la /opt/
total 48
drwxr-xr-x. 12 root root 4096 Jan 20 17:27 .
dr-xr-xr-x. 19 root root 4096 Jan 20 14:16 ..
drwx------.  2 root root 4096 Dec 22 17:37 openshift-client-4.6.8
drwx------.  2 root root 4096 Dec 22 17:37 openshift-install-4.6.8

Fixed in devel tree, will be merged later into master.
Run following commands to fix the permissions:
rm -r /opt/*4.6.8
./ansible/02-create-cluster.yml --tags download-openshift-artifacts

Now it looks much better:
ls -lad /opt/*4.6.8 /opt/*4.6.8/*
drwxr-xr-x. 2 root root      4096 Jan 27 14:34 /opt/openshift-client-4.6.8
-rwxr-xr-x. 1 root root  40525496 Jan 27 14:34 /opt/openshift-client-4.6.8/helm
-rwxr-xr-x. 2 root root  74528312 Dec  5 04:12 /opt/openshift-client-4.6.8/kubectl
-rwxr-xr-x. 2 root root  74528312 Dec  5 04:12 /opt/openshift-client-4.6.8/oc
-rwxr-xr-x. 1 root root       954 Dec  5 04:12 /opt/openshift-client-4.6.8/README.md
drwxr-xr-x. 2 root root      4096 Jan 27 14:34 /opt/openshift-install-4.6.8
-rwxr-xr-x. 1 root root 353034240 Dec  5 03:38 /opt/openshift-install-4.6.8/openshift-install
-rwxr-xr-x. 1 root root       706 Dec  5 03:38 /opt/openshift-install-4.6.8/README.md

Thanks for the issue.

Oh indeed, that's not very useful.
$ ls -la /opt/
total 48
drwxr-xr-x. 12 root root 4096 Jan 20 17:27 .
dr-xr-xr-x. 19 root root 4096 Jan 20 14:16 ..
drwx------.  2 root root 4096 Dec 22 17:37 openshift-client-4.6.8
drwx------.  2 root root 4096 Dec 22 17:37 openshift-install-4.6.8

Fixed in devel tree, will be merged later into master.
Run following commands to fix the permissions:
rm -r /opt/*4.6.8
./ansible/02-create-cluster.yml --tags download-openshift-artifacts

Now it looks much better:
ls -lad /opt/*4.6.8 /opt/*4.6.8/*
drwxr-xr-x. 2 root root      4096 Jan 27 14:34 /opt/openshift-client-4.6.8
-rwxr-xr-x. 1 root root  40525496 Jan 27 14:34 /opt/openshift-client-4.6.8/helm
-rwxr-xr-x. 2 root root  74528312 Dec  5 04:12 /opt/openshift-client-4.6.8/kubectl
-rwxr-xr-x. 2 root root  74528312 Dec  5 04:12 /opt/openshift-client-4.6.8/oc
-rwxr-xr-x. 1 root root       954 Dec  5 04:12 /opt/openshift-client-4.6.8/README.md
drwxr-xr-x. 2 root root      4096 Jan 27 14:34 /opt/openshift-install-4.6.8
-rwxr-xr-x. 1 root root 353034240 Dec  5 03:38 /opt/openshift-install-4.6.8/openshift-install
-rwxr-xr-x. 1 root root       706 Dec  5 03:38 /opt/openshift-install-4.6.8/README.md

Thanks for the issue.

Works indeed, thanks !
On the nitpicking side, for the directory,
     path: "/opt/openshift-{{ item }}-{{ openshift_version }}"
     state: directory
-    mode: u+rwx,g-rx,o-rx
+    mode: u+rwx,g+rx,o+rx

the mode parameter was probably not needed as with the default umask of 022 of the root user, you would have got the right permissions anyway.

Works indeed, thanks !
On the nitpicking side, for the directory,
     path: "/opt/openshift-{{ item }}-{{ openshift_version }}"
     state: directory
-    mode: u+rwx,g-rx,o-rx
+    mode: u+rwx,g+rx,o+rx

the mode parameter was probably not needed as with the default umask of 022 of the root user, you would have got the right permissions anyway.

Oh yes, that's right. But it doesn't hurt if it's there.

Oh yes, that's right. But it doesn't hurt if it's there.


submodule LV2 deps or not?

I have been restructuring LV2 deps these days, and it is quite annoying. The first thing I did was repository split. All those heavyweight plugins (sfizz, guitarix, fluidsynth) are now gone and the build becomes much faster.
Then I tacked LV2 toolkit updates. It was only supposed to bump versions, but it actually involves non-trivial merge conflicts, and it indeed regressed. Things that built didn't work. mda-lv2 plugins started to crash.
I stared debugging it, but it was known as non-intuitive steps from the past experience, because of binary deps split. I recorded history of the steps, but there was also non-trivial updates and the source code diff didn't work as it was. I spent time to make it up to date, and now it is debuggable. I could diagnose the changes in serd and lilv, and aap-mda-lv2 now works.
Now I have to revert all those local debugging bits, and they will be lost. It is quite annoying. The debugging experience was much better with sources. When it is hard for me to debug, it is almost impossible to anyone else.
Should I switch to "submodule lv2 toolkits" strategy? Build takes more time (like 2 minutes every time) and that is imposed on any aap-lv2-based plugins, but they would also benefit from the debuggability.

The actual problem here is not LV2 toolkits. Building lv2 toolkits from source it lightweight. Building mda-lv2 binaries is somewhat cumbersome. And it hardly happens that we have to debug those proof-of-concept plugin ports. And if we build lv2 toolkits within the repo while building aap-mda-lv2 outside, it's going to be annoying. But - should aap-mda-lv2 also go outside the repo? That means this repo has almost no good dogfood (except for app-ayumi, which is too trivial).

After successful repository split in aap-juce, I'm inclined to split aap-mda-lv2, maybe renaming to aap-lv2-mda. Most of the trouble still occurs around lv2 toolkits.

aap-mda-lv2 is now split into aap-lv2-mda (okay, confusing repo name, but consistent with others). It's ready to build them directly here.


Fix config::Builder::set_credentials_provider to override what's previsouly set

Motivation and Context
Fixes https://github.com/awslabs/aws-sdk-rust/issues/973
Description
Prior to the PR, if a customer explicitly passed a credentials provider to a client's config Builder::set_credentials_provider, what's passed did not override a credentials provider previously set (actual use case).
While in general, we recommend customers single-source a credentials provider through aws_config::ConfigLoader::credentials_provider, we should eliminate the said footgun in case they directly pass a credentials provider to a client's config Builder.
The PR reverts test signature updates in https://github.com/smithy-lang/smithy-rs/pull/3156 (in hindsight, having to update test signatures in that PR was a sign of regression).
Testing
Added a Kotlin test to CredentialProviderConfigTest.kt to verify the fix
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this on behalf of PR3278


Update dependencies

Update webpki to v0.22.1
Update grep-cli to v0.1.9

Resolves some dependabot alerts.

@haixuanTao I think you need to add an approving review, otherwise auto-merge won't work.


MSID: 95628 Version: 2 DOI: 10.1101/2<IP_ADDRESS>3868

MSID: 95628
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3868
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=95628
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3868

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/95628v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3868
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/95628/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Posted to the v5 but there have been 2 subsequent versions posted in (relative quick succession), and we only have access to the v6 or 7.
Going to move the reviews across to the v7 and load the v7 MECA.

Figures in v7 on bioRxiv were disordered, so I have fixed this. Also fixing corresponding author details.


movep.y destination directory naming breaks on windows if dots in dirname

check if similar situation on unix.

https://github.com/kieranjol/IFIscripts/pull/56/commits/942f0bb33ff85cde9e2fe617ab8bf3641c3473a1 Haven't checked on unix as I made a mistake using splitext() instead of split() to get the dirname.


Support IEnumerable<>.Contains and Any query.

Solution is inspired by
https://github.com/dotnet/efcore/blob/master/src/EFCore.Relational/Query/Internal/QueryingEnumerable.cs#L107
https://github.com/dotnet/efcore/blob/master/src/EFCore.Relational/Query/Internal/RelationalCommandCache.cs#L44

I can't reach the case where relationalCommandCache == null, thus I have maintained the existing behavior.

Thx for contribution.

NuGet 3.1.1 published.


implement own/self contract

fixes #122

https://github.com/spatie/schema-org/releases/tag/2.11.1


read-me

Add contributions rules to Readme.md

Its look good. What do you think about change order of the of the “chapters” contributions first and manual second ?
Also it would be good to have labels matching that real labels :) so i think we should adjust one or second list.


Nx Absolute no SFX

In GitLab by @hiryu69 on Apr 13, 2021, 22:54
Summary
the game cant play some sfx in the game
Expected behavior
the game plays all the sounds
Current behavior
the game runs fine but without some sfx
Detailed Description
when you start the game, you cant ear some sounds, like "hit me" or "arcade station" and many others
Steps to reproduce

start the game and you will notice some missing sfx

Further things tested

[ ] Tested with lib-local.zip library package
[ ] Tested with lib-ld.zip library package

Possible solution
it like the game (or the hook) ignores the WAVE folder, all missing samples in the game, are from this folder, other sounds in the game just play fine
Context (Environment)
Pumptools version(s) affected
pumptools 1.12
Game(s) and version(s) affected
Only Nx Absolute,
tested Nx2, Nx and all sfx play fine
OS version
Linux Ubuntu 20.04

Sorry for necro-ing, but +1 on the no SFX and crash on test menu
solved this by making sure that :

There is CONFIG and config folder
There is 2 copies of all .txt (UPPERCASE and lowercase) files inside the CONFIG and config folder

Sorry for necro-ing, but +1 on the no SFX and crash on test menu
solved this by making sure that :
1. There is CONFIG and config folder

2. There is 2 copies of all .txt (UPPERCASE and lowercase) files inside the CONFIG and config folder

Just to clarify that the root-cause of this is understood:
You should not need 2 copies of these folders and files. The game was developed for and on a case insensitive file system (ext2), which resulted in paths and file names in the game being mixed as it didn't matter for access. Running this on case sensitive file systems, e.g. ext3/4, the casing needs to match exactly to what is specified in the game's executable.
It sounds like you sourced the yourself which puts you into the annoying position of figuring out this casing mess. Therefore, two copies are a quick but also hacky way to solve the issue certainly without having to modify pumptools. Maybe a better approach to solve this would be to mask case sensitivity with pumptools.
/thoughts


drivers/timer: stm32_lptim: Move to new DT api

Use NODELABEL macros rather than DT_INST as this driver is so far
limited to support of LPTIM1 instance.
Signed-off-by: Erwan Gouriou<EMAIL_ADDRESS>

CI failure w/qemu mps2_an385:tests/drivers/counter/counter_basic_api/drivers.counter.  Going to ignore.


Fixes off-by-one error in PrioritizedReplayBuffer

Fixes #170
Fixes #171

Also makes documentation of segment_tree consistent with tests.
The tests clearly indicate that the end parameter is non-inclusive: https://github.com/openai/baselines/blob/master/baselines/common/tests/test_segment_tree.py#L17
@siemanko, please review.


Testing a ticker of a cancelled context

Hello there! Is it possible to test cancelled ticker contexts?
I was looking to inspect state of an object after cancelling its context, and I had assumed that cancelling would cancelled a ticker started with TickerFunc but it does not appear to.
Annotated pseudo-code of what I'm seeing:
ctx, cancel := context.WithCancel(context.Background())
timeout, _ := context.WithTimeout(context.Background(), 10*time.Second)
testTime := quartz.NewMock(t)
exporter.Clock = testTime
trap := testTime.Trap().TickerFunc()
defer trap.Close()

runner := exporter.NewCollectorRunner(ctx)
go runner.Start()
call := trap.MustWait(timeout)
call.Release()

//advance time in lockstep - this works and increments the counter
_, w := testTime.AdvanceNext()
w.MustWait(timeout)

//I had assumed this should cancel the ticker and prevent further ticks.
cancel()

//strangely able to advance and wait, I would have assumed the function here wouldn't have a next event. Peek here also returns true.
for i := 0; i < 2; i++ {
	_, w := testTime.AdvanceNext()
	w.MustWait(timeout)
}
//this assertion fails, the counters are 3 here, meaning the increment function is still fired after the context was cancelled.
Expect(runner.counter).To(Equal(1))

Inside collector runner:
func (c *CollectorRunner) Start() error {
	t := Clock.TickerFunc(c.ctx, 5 * time.Second, func() error {
		c.counter = c.counter + 1
		return nil
	})
	return t.Wait()
}

Without seeing the full code for exporter and runner I do have to ask, are you 100% sure c.ctx being passed to TickerFunc is the context that is being canceled?
The othing to mention is that canceling the context is asynchronous with the TickerFunc exiting. There is a goroutine in the TickerFunc waiting for the context to be canceled, which then causes the TickerFunc to exit, but you're not actually waiting for it before you call AdvanceNext(), so you have a race between getting to the next tick (and the one after it) and canceling.  To make this deterministic, I'd suggest something like:
ctx, cancel := context.WithCancel(context.Background())
timeout, _ := context.WithTimeout(context.Background(), 10*time.Second)
testTime := quartz.NewMock(t)
exporter.Clock = testTime
trap := testTime.Trap().TickerFunc()
defer trap.Close()

runner := exporter.NewCollectorRunner(ctx)
runnerDone := make(chan struct{})
go func() {
    defer close(runnerDone)
    runner.Start()
}()
call := trap.MustWait(timeout)
call.Release()

//advance time in lockstep - this works and increments the counter
_, w := testTime.AdvanceNext()
w.MustWait(timeout)

cancel()
select {
    case <-runnerDone:
        // OK!
    case <-timeout.Done():
        t.Fatal("timed out waiting for runner to exit")
}

_, ok := testTime.Peek()
if ok {
    t.Fatal("TickerFunc was not removed")
}

Expect(runner.counter).To(Equal(1))

Hope this answered your question. I'm closing since I want to keep the issue tracker just to things that are active. Please reopen and add more info if you're still stuck.


gltf: improve embedded data discovery

Some editors seems to use the image resource's mime type (e.g. "image/png") for data embedded uris instead of "application/octet-stream".
Fixes #16879

Thanks!


Incorrect prediction formula?

Bug / performance issue / build issue
I believe there is an error in the next-to-last equation in the documentation page at https://gpflow.readthedocs.io/en/master/notebooks/theory/SGPR_notes.html, which makes the last prediction equation invalid. I provide details at http://www.gatsby.ucl.ac.uk/~rapela/gpflow/wrongPredictionEq.pdf. Can this be right?

The next-to-the-last equation in the documentation page is correct, as shown here.

Thanks @st-- . The third to the last equation in the GPflow documentation page correctly states Kuu⁻¹ Λ Kuu⁻¹ = L⁻ᵀ and  as proved here the GPflow documentation is correct. What do you think?

In other words, Kuu⁻¹ Λ Kuu⁻¹ isn't consistent, it should be Kuu⁻¹ Λ⁻¹ Kuu⁻¹ based on the "units".

Thanks for your comment @st--. I believe there is a typo in the third to the last equation of this GPflow note. The right hand side of this equation should contain  instead of , as proven here. With this correction, the proof of the predictive mean (second to the last equation of this GPflow note) becomes simple, as shown here. I will create a pull request about this.

I think we'd resolved this now ? If anyone disagrees please shout and we can reopen it:)


Feature highlighting

This is based off of #194 as I was getting things working in omnisharp-atom.

You didn't gain much by using an enum here. I forgot that C# enums can't have string values.
Maybe something like this would be better? http://stackoverflow.com/a/1343517/316874

@nosami what are you thinking, create a class, to handle the delegates?

No.... I was thinking that this code
else if (classification == HighlightClassification.PreprocessorKeyword)
    spans = spans.Where(x => x.ClassificationType != "preprocessor keyword");

was a little annoying and could be fixed if the string representation for PreProcessorKeyword was the string "preprocessor keyword".
It's not a big deal though, so merging anyway. I'll publish it as 1.0.6


Allow recording in portrait format

Description:
Allow recording of daily records in portrait format
Reason:
Today most people who intend to record daily records use social networks such as tiktok, instagram reals/stories/igtv or youtoube stories, which use the portrait format, which when posted using the landscape format, is very small, making it impracticable.
In case the requirement for recording in landscape is due to some design of the application, it would be interesting to create two "buckets" in the directory "onesecconddiary", where only the videos in landscape are recorded in one, and the other in portrait.
Functionality:

[ ] Allow recording of daily records in portrait format

Related to #8
We need to find a way to compile videos with different properties fast and without losing quality.


Confusion around Always Online cache times

Expected Behavior
Expect clarity around the behaviour of this feature: https://github.com/cloudflare/cloudflare-docs/blob/production/products/cache/src/content/about/always-online.md
Actual Behavior
Contradictory passages seem to indicate different caching lengths:

When you enable Always Online with Internet Archive integration, Cloudflare shares your hostname and popular URL paths with the archive so that the Internet Archive’s crawler stores the pages you want archived. When submitting targets to the crawler, Cloudflare identifies the most popular URLs found among GET requests that returned a 200 HTTP status code in the previous 5 hours.

A Cloudflare crawler identifies resources to place in the Always Online cache. When Internet Archive integration is enabled, Cloudflare tells the Internet Archive what pages to crawl and how often. To ensure stability of service, Cloudflare limits the crawling interval. Limits vary by Cloudflare plan, and the Always Online crawler ignores robots.txt. Free customers once every 30 days. Pro customers once every 15 days. Business and Enterprise customers once every 5 days.
It's not clear that these paragraphs are describing different kinds of caching, and yet they have different caching period lengths.
Section that requires update
https://github.com/cloudflare/cloudflare-docs/blob/production/products/cache/src/content/about/always-online.md
Additional information
Any other details or screenshots you think are relevant.

Thanks for letting us know @mattlinares. We're actually in the process of addressing this issue now, and you should see updated content soon!


Profiler does not record failed samples in JFR

See here:
https://github.com/jvm-profiling-tools/async-profiler/blob/2ceb1d1e952aa5f5502898a1777fdf067a26463b/src/profiler.cpp#L353

On closer inspection, only summary handles errors. It would be good to handle the errors as frames. Also non java threads are non-errors, so no need to account for them.

Flamegraph now includes all AsyncGetCallTrace failures, e.g. [unknown_Java]:

Also native threads (including GC and compiler threads) and no longer listed as errors.

Thanks!


Require block vs argument

Fixes error in example:
An argument named "require" is not expected here. Did you mean to define a block of type "require"?

note: trying to add label workflow/skip-changelog-entry I'm unable to add any labels


QoL/Feature Request: %player-coordinates% %ping-coordinates%

I am using ``` in a lot of my messages, but as it, coordinates display outside of the block
Would it be possible to add %player-coordinates% and %ping-coordinates% for messages?
this would allow for better message customization AND eliminate tons of config toggles for that; shortening your config quite a bit which is always nice =]

Would you use both player and ping coordinates in the same message? I suppose it is only possible when someone pings. Otherwise you just need %coords% for the location.
Can easily them verbosely though.

I wouldn't think I would need player pos for a map ping... so no; i dont think they necc have to be separate