Should negative inputs to every, fps, fpsWhen, delay be forbidden?

Yes, I think they should. It would be trivial and harmless to make them runtime errors. That would be in the same category like the runtime error one currently gets from calling mergeMany on an empty list. (That is, such runtime errors can only happen immediately at program start. So no sudden surprises.)
In addition to what's in the issue title, probably the value 0 should also be forbidden as argument at least for fps and fpsWhen. (It might effectively already be forbidden for those due to "division by zero".)

Or, we could clamp them to some logical minimum value (like 0 or 1 depending on the function) and make sure this behavior is clearly stated in the docs. This could eliminate the runtime errors there.
We could even go so far as to change the type of mergeMany to Signal a -> List (Signal a) -> Signal a to further eliminate the runtime errors there.

I have reconsidered and think it would indeed be best to simply clamp the arguments to every, fps, fpsWhen and delay to some logical minimum value as suggested by @TheSeamau5. Making negative (or maybe even zero) values to them a runtime error could backfire like in https://github.com/elm-lang/core/issues/381#issuecomment-137169302.


Reload Page after Wake-up

Can you add a option with this feature:
After Wake-up with Motion-detected, can you reload the website?

You can already receive an MQTT message that motion was detected and then send back a command to refresh the web page.  There is no need to add another option to do this.

I do that already, the slight hiccup occurs if you're in a dark room or out of camera shot, and tap the screen to wake it up. No motion detected, no refresh. Maybe a mqtt message for wake up, would solve that.


Investigate Using Actual Event Times

Currently, GMA adds a "received" time to every Big Query row. This time is based on when it receives the webhook, which may not be the same time as the event (especially if there are retries).
This may cause some queries to miss events you would expect in a certain timeframe.
It would be better to extract the event time from the payload of the event, though I haven't seen if every event type keeps that information in the same place.
Its worth investigating feasibility of extracting actual times either when processing the webhook, or as a scheduled query to update rows with a more accurate time, or to copy to a new table.

It would be better to extract the event time from the payload of the event, though I haven't seen if every event type keeps that information in the same place.

There isn't a consistent place, it is dependent on the type of event AND action, e.g. pull request opened -> pull_request.created_at or pull request closed -> pull_request.closed_at for the same event but different action.
I would also be interested to see if there is a creative way to do this, without manual work to map EVERY event type.
One of the best features of this service is that its flexible enough to ingest any event.


[ko] Translate the glossary term 'Add-ons' into Korean

This is a Feature Request

What would you like to be added

Translate the glossary term 'Add-ons' into Korean
Why is this needed
Not translated into Korean yet.

link to en entry: https://kubernetes.io/docs/reference/glossary/?all=true#term-addons
link to ko entry: https://kubernetes.io/ko/docs/reference/glossary/?all=true#term-addons

Comments

/language ko
/assign

/triage accepted


Fix full segment bug

This PR fixes a bug occurring when a segment gets completely full and the remaining cycles are carried over a new segment, then, the expand function fails because the number of steps is equal to the max_po2.
It also adds a unit test for that case.
Fixes #820

This is interesting because I was planning to drop the expand function altogether since it was written before we had an executor which could compute ahead of time how big the prover matrix needs to be. So it feels like the executor is still miscalculating something.


Test rotation functions

Primitive testing gives somewhat reasonable values.
In depth testing will be done later.

Closed until rendering added

Rotation working correctly


Pygments hangs on this file

(Original issue 946 created by spatten on 2014-01-09T01:06:09.186824+00:00)
When I run pygments on the attached file like so:
cat bad-code.php | pygmentize -g -O "encoding=utf-8"
then just keeps outputting the same line over and over again (if I use a different formatter, it just hangs and never returns). If it does not have to guess the lexer, then it returns.
The content of the file seems to matter. If I remove all of the extra line-breaks that I put in to make the file fit under 80 columns, then this does not happen.
I'm running this against the latest dev commit. This does not happen on version 1.6 that I installed via easy_install.
Thanks!
Scott

(Original issue 946 last updated on 2014-01-09T17:16:45.167293+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by birkenfeld on 2014-01-09T17:16:45.192913+00:00)
temporarily fixed by 83d2b915612a


webkitgtk: 2.28.2 -> 2.29.3

Motivation for this change
Major version bump. (Added systemd as a dependency as it requires libsystemd as per the latest version.)
What's new in the WebKitGTK 2.29.3 release?
===========================================

  - Add webkit_authentication_request_get_security_origin.
  - Change the cookies accept policy to always when no-third-party is set and ITP is enabled.
  - Fix web process hangs on large GitHub pages.
  - Bubblewrap sandbox should not attempt to bind empty paths.
  - Add support for sndio to bubblewrap sandbox.
  - Also handle dark themes when the name ends with -Dark.
  - Fix a race condition causing a crash in media player.
  - Fix several crashes and rendering issues.

What's new in the WebKitGTK 2.29.2 release?
===========================================

  - Add Intelligent Tracking Prevention (ITP) support.
  - Add support for video formats in img elements.
  - Add API to handle video autoplay policy that now defaults to disallow autoplay videos with audio.
  - Add API to mute a web view.
  - Add API to allow applications to handle the HTTP authentication credential storage.
  - Add a WebKitSetting to set the media content types requiring hardware support.
  - Fix a crash during drag an drop due to a bug introduced in 2.29.1.
  - Do not start page load during animation in back/forward gesture.
  - Fix several crashes and rendering issues.
  - Translation updates: Ukrainian.

What's new in the WebKitGTK 2.29.1 release?
===========================================

  - Stop using GTK theming to render form controls.
  - Add API to disable GTK theming for scrollbars too.
  - Fix several race conditions and threading issues in the media player.
  - Add USER_AGENT_BRANDING build option.
  - Add paste as plain text option to the context menu for rich editable content.
  - Fix several crashes and rendering issues.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

That is an unstable version, see the sidebar in https://webkitgtk.org/news.html. GNOME and GNOME adjacent software typically uses odd minor versions during the development of the next stable (even) version. (Though some software does not follow this policy or we package unstable release because the stable version is too old. Also, GNOME is currently discussing abandoning this policy because people find it confusing.) Some packages avoid even the odd patch versions (GIMP, NetworkManager…) and some designate minor versions 90+ pre-release versions/release candidates.

Okay, thanks for info I thought that only "gnome-" packages follow the even-odd release scheme. I'll be more careful next time.


When the duration is more than 2 minutes, trail job status is failed

nnimanager.log:
[2020-1-7 11:48:34] DEBUG [ 'getTrialJobsByReplayEvents done' ]
[2020-1-7 11:48:34] DEBUG [ 'ipcInterface command type: [PI], content:[]' ]
[2020-1-7 11:48:35] DEBUG [ 'trialJob status update: M8agZ, SUCCEEDED' ]
[2020-1-7 11:48:35] INFO [ 'Trial job M8agZ status changed from RUNNING to SUCCEEDED' ]
[2020-1-7 11:48:35] DEBUG [ 'storeTrialJobEvent: event: SUCCEEDED, data: undefined, jobDetail: {"id":"M8agZ","status":"SUCCEEDED","submitTime":1578368836390,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\M8agZ","form":{"sequenceId":1,"hyperParameters":{"value":"{\"parameter_id\":null,\"parameter_source\":\"customized\",\"parameters\":{\"num_leaves\":146,\"learning_rate\":0.5,\"bagging_fraction\":0.9440494376965134,\"bagging_freq\":1}}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\M8agZ","gpuIndices":[],"startTime":1578368840240,"pid":18936,"endTime":1578368912082}' ]
[2020-1-7 11:48:35] DEBUG [ 'ipcInterface command type: [EN], content:[{"trial_job_id":"M8agZ","event":"SUCCEEDED","hyper_params":"{\"parameter_id\":null,\"parameter_source\":\"customized\",\"parameters\":{\"num_leaves\":146,\"learning_rate\":0.5,\"bagging_fraction\":0.9440494376965134,\"bagging_freq\":1}}"}]' ]
[2020-1-7 11:48:35] DEBUG [ 'ipcInterface command type: [GE], content:[1]' ]
[2020-1-7 11:48:35] INFO [ 'submitTrialJob: form: {"sequenceId":2,"hyperParameters":{"value":"{\"parameter_id\": 1, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 82, \"learning_rate\": 0.02, \"bagging_fraction\": 0.9081849001346404, \"bagging_freq\": 2}, \"parameter_index\": 0}","index":0}}' ]
[2020-1-7 11:48:35] DEBUG [ 'submitTrialJob: return: {"id":"SyF9n","status":"WAITING","submitTime":1578368915468,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","form":{"sequenceId":2,"hyperParameters":{"value":"{\"parameter_id\": 1, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 82, \"learning_rate\": 0.02, \"bagging_fraction\": 0.9081849001346404, \"bagging_freq\": 2}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","gpuIndices":[]} ' ]
[2020-1-7 11:48:35] DEBUG [ 'storeTrialJobEvent: event: WAITING, data: {"parameter_id": 1, "parameter_source": "algorithm", "parameters": {"num_leaves": 82, "learning_rate": 0.02, "bagging_fraction": 0.9081849001346404, "bagging_freq": 2}, "parameter_index": 0}, jobDetail: {"id":"SyF9n","status":"WAITING","submitTime":1578368915468,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","form":{"sequenceId":2,"hyperParameters":{"value":"{\"parameter_id\": 1, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 82, \"learning_rate\": 0.02, \"bagging_fraction\": 0.9081849001346404, \"bagging_freq\": 2}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","gpuIndices":[]}' ]
[2020-1-7 11:48:35] INFO [ 'NNIManager received command from dispatcher: TR, {"parameter_id": 2, "parameter_source": "algorithm", "parameters": {"num_leaves": 131, "learning_rate": 0.05, "bagging_fraction": 0.8963267191943094, "bagging_freq": 4}, "parameter_index": 0}' ]
[2020-1-7 11:48:39] DEBUG [ 'ipcInterface command type: [PI], content:[]' ]
[2020-1-7 11:48:44] DEBUG [ 'GET: /experiment: body:\n{}' ]
[2020-1-7 11:48:44] DEBUG [ 'GET: /check-status: body:\n{}' ]
[2020-1-7 11:48:44] DEBUG [ 'GET: /trial-jobs: body:\n{}' ]
....
[2020-1-7 11:54:15] DEBUG [ 'trialJob status update: SyF9n, FAILED' ]
[2020-1-7 11:54:15] INFO [ 'Trial job SyF9n status changed from RUNNING to FAILED' ]
[2020-1-7 11:54:15] DEBUG [ 'storeTrialJobEvent: event: FAILED, data: undefined, jobDetail: {"id":"SyF9n","status":"FAILED","submitTime":1578368915468,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","form":{"sequenceId":2,"hyperParameters":{"value":"{\"parameter_id\": 1, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 82, \"learning_rate\": 0.02, \"bagging_fraction\": 0.9081849001346404, \"bagging_freq\": 2}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\SyF9n","gpuIndices":[],"startTime":1578368920999,"pid":10552,"endTime":1578369255892}' ]
[2020-1-7 11:54:15] DEBUG [ 'ipcInterface command type: [EN], content:[{"trial_job_id":"SyF9n","event":"FAILED","hyper_params":"{\"parameter_id\": 1, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 82, \"learning_rate\": 0.02, \"bagging_fraction\": 0.9081849001346404, \"bagging_freq\": 2}, \"parameter_index\": 0}"}]' ]
[2020-1-7 11:54:15] DEBUG [ 'ipcInterface command type: [GE], content:[1]' ]
[2020-1-7 11:54:15] INFO [ 'submitTrialJob: form: {"sequenceId":3,"hyperParameters":{"value":"{\"parameter_id\": 2, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 131, \"learning_rate\": 0.05, \"bagging_fraction\": 0.8963267191943094, \"bagging_freq\": 4}, \"parameter_index\": 0}","index":0}}' ]
[2020-1-7 11:54:15] DEBUG [ 'submitTrialJob: return: {"id":"PACsZ","status":"WAITING","submitTime":1578369255898,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","form":{"sequenceId":3,"hyperParameters":{"value":"{\"parameter_id\": 2, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 131, \"learning_rate\": 0.05, \"bagging_fraction\": 0.8963267191943094, \"bagging_freq\": 4}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","gpuIndices":[]} ' ]
[2020-1-7 11:54:15] DEBUG [ 'storeTrialJobEvent: event: WAITING, data: {"parameter_id": 2, "parameter_source": "algorithm", "parameters": {"num_leaves": 131, "learning_rate": 0.05, "bagging_fraction": 0.8963267191943094, "bagging_freq": 4}, "parameter_index": 0}, jobDetail: {"id":"PACsZ","status":"WAITING","submitTime":1578369255898,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","form":{"sequenceId":3,"hyperParameters":{"value":"{\"parameter_id\": 2, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 131, \"learning_rate\": 0.05, \"bagging_fraction\": 0.8963267191943094, \"bagging_freq\": 4}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","gpuIndices":[]}' ]
[2020-1-7 11:54:15] INFO [ 'NNIManager received command from dispatcher: TR, {"parameter_id": 3, "parameter_source": "algorithm", "parameters": {"num_leaves": 96, "learning_rate": 0.02, "bagging_fraction": 0.9829264300010454, "bagging_freq": 1}, "parameter_index": 0}' ]
[2020-1-7 11:54:16] DEBUG [ 'ipcInterface command type: [PI], content:[]' ]
[2020-1-7 11:54:21] INFO [ 'Trial job PACsZ status changed from WAITING to RUNNING' ]
[2020-1-7 11:54:21] DEBUG [ 'storeTrialJobEvent: event: RUNNING, data: undefined, jobDetail: {"id":"PACsZ","status":"RUNNING","submitTime":1578369255898,"workingDirectory":"C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","form":{"sequenceId":3,"hyperParameters":{"value":"{\"parameter_id\": 2, \"parameter_source\": \"algorithm\", \"parameters\": {\"num_leaves\": 131, \"learning_rate\": 0.05, \"bagging_fraction\": 0.8963267191943094, \"bagging_freq\": 4}, \"parameter_index\": 0}","index":0}},"url":"file://localhost:C:\\Users\\Administrator\\nni\\experiments\\zKzPCmLx\\trials\\PACsZ","gpuIndices":[],"startTime":1578369258592,"pid":18028}' ]
[2020-1-7 11:54:21] DEBUG [ 'ipcInterface command type: [PI], content:[]' ]
[2020-1-7 11:54:22] DEBUG [ 'GET: /experiment: body:\n{}' ]
[2020-1-7 11:54:22] DEBUG [ 'GET: /check-status: body:\n{}' ]
[2020-1-7 11:54:22] DEBUG [ 'GET: /trial-jobs: body:\n{}' ]
[2020-1-7 11:54:22] DEBUG [ 'GET: /metric-data: body:\n{}' ]

Hi @kuoorczp, do you have stderr file in your log path?

stderr 's size is 0

There is a .nni folder in the log path, theoretically there are two files, containing metric and state. Does your .nni folder have state file?

state:
0<PHONE_NUMBER>543
metrics:
ME000103{"parameter_id": 0, "trial_job_id": "q51NP", "type": "PERIODICAL", "sequence": 0, "value": 0.76006044}
ME000098{"parameter_id": 0, "trial_job_id": "q51NP", "type": "FINAL", "sequence": 0, "value": 0.76006044}

Hi @kuoorczp,
Seems the log information is insuffiient, could you please try using
  git clone -b dev-powershellSupport https://github.com/SparkSnail/nni.git
  cd nni
  powershell -ExecutionPolicy Bypass -file install.ps1

to install NNI from source code, and use
nnictl create --config {config_file} --debug

to start an experiment.
This version of code have more debug information.

Hi @kuoorczp,
Seems the log information is insuffiient, could you please try using
  git clone -b dev-powershellSupport https://github.com/SparkSnail/nni.git
  cd nni
  powershell -ExecutionPolicy Bypass -file install.ps1

to install NNI from source code, and use
nnictl create --config {config_file} --debug

to start an experiment.
This version of code have more debug information.

ok.i'll try

Hi @kuoorczp,
Seems the log information is insuffiient, could you please try using
  git clone -b dev-powershellSupport https://github.com/SparkSnail/nni.git
  cd nni
  powershell -ExecutionPolicy Bypass -file install.ps1

to install NNI from source code, and use
nnictl create --config {config_file} --debug

to start an experiment.
This version of code have more debug information.

ok.i'll try

@kuoorczp how things going with the problem? are you able to walk around it?

I’m closing this issue as it has no updates from customer for 3 months, please feel free to reopen if you are still seeing it an active issue.


Completed Final Project

Christopher DiGangi
Managing Epidemics with Mathematical Modeling.

I made my final project in the in-class-demo repo that you had us create during one of our classes. For some reason I couldn't get git to transfer the file into the assignment bank repo so I lost the history in this version. I tried following online examples using git mv file dir but I kept getting errors. I decided to just transfer all of the content over to a new notebook.

Chris, I haven't read it yet, but you should add a licence as we have in at the beginning of our notebooks.
Note: In case anyone is interested in read this notebook, you should download the notebook, otherwise the ipywidgets won't work!

Hey, I will certainly add in the license tonight after work!
Also, I briefly go over how to import ipywidgets using conda, but I noticed my version of conda already had ipywidgets installed.

Hey I added the copyright header to the project

Hey Chris I went through the whole notebook in detail. It's really interesting. I have some comments, if you feel up to fix them, that would be great.
I've noticed that you explain that the population is fixed in size and other assumptions, that are necessary to understand the eqaution, after you introduce model. In my opinion this assumptions should be before, otherwise it's difficult to understand some points. For example, it took me a while to understand why in the susceptible equation the number of newborns that are not vaccinated contains in its calculation the Average death rate. Thing that is obvious once you know:  the population N is held constant and the birth rate and death rate are equal.
The equation of the solution matrix is missing a u in the left hand side of the equal, but I found out that is a nbviewer problem (in the source code it's present), for some reason it doesn't appear.
When you change the parameter form the 1st case to the 2nd one, you only change 2 of them, e = .5 ----> e = .1 and gamma = .1 ----> gamma = .5. Then, there is no reason to write all the ones that remain the same again. Or point out which ones are you changing.
typo:  individuls--------> individuals

Hey Naty,
I updated the code with all the changes you pointed out. Do I need to do anything wit the pull request? It looks like it automatically recognizes the new commit so it seems like I don't need to update this one or create a new one?

Hey Chris, the pull request is updated automatically, so don't worry about that!.

This is a nice project, although the numerical problem you chose is quite simple—programming-wise, this work feels rather skimpy (I estimate a half hour of programming effort). It is nice that you introduced ipywidgets (but of course this was an idea that I gave you on your pre-project posted on Piazza). Apart from being nice, what do you gain from the widgets, in terms of insight from your model?
Given that this project was numerically unchallenging, I would have expected more discussion of what the model does. Yet, there is only a scant note about the appearance of oscillations with your first chosen set of parameters. Why did you choose these parameters? And what happens in other situations?
Overall, the treatment of the model is cursory and the programming effort on the low side, which leads me to be underwhelmed, despite the fact that the notebook is nicely put together.
“The most important part of understanding any model is understanding the nomenclature …” —The most important part? well, I think this is an overstatement :-)
“This is a very simplified model because of the complexities of infectious diseases.”  —Yes. And I wish you had elaborated just a bit more here. This sentence really leaves us wondering …
Typos, grammar, etc.
the change in Susceptible Indivduals becomes —> Individuals
Now examining the vaccinated individuals —> Now, (comma) … individuals, (comma)
(there are several commas missing elsewhere)
Python should be capitalized: Python not python.
Therfore —> Therefore (after input line In[23])


Fix writing to read-only CloseEvent properties

Closes #2. I have not tested this patch, it’s a high-level idea. Feel free to throw away.

Yeah this fix should do it for chrome and newer browsers, but changing it to Object.assign would break in IE.. Would you mind redoing it without Object.assign?

No, sorry. I wanted to report and provide clarity on what I’ve encountered, but I don’t have the tooling set up right now.

Alright ;) Sorry for the delay, I've fixed it in - https://github.com/porsager/pws/commit/872d7792dda94792e9a1ac1593a72635a47702dd now.


Fix - Storage Provisioning not working #14

https://github.com/pendrica/chef-provisioning-azurerm/issues/14

@bgxavier Thanks for looking at this, I'll see if I can fix up the CI and get it merged...


Add qualifiers

We currently don't produce any qualifiers for CAM-KP. Having reviewed the list of Biolink predicates, we decided to focus on these predicates in this order:

direction_qualifier + aspect_qualifier + qualified_predicate for indicating increased/decreased abundance/expression.
anatomical_context_qualifier for the location where reactions take place.
species_context_qualifier for the species in which reactions have been observed.
stage_qualifier - we have a few of these in GO-CAMs.
part_qualifier - maybe?

Look in IDs that can't be normalized
We might have part_of relation connecting concepts, e.g. "A occurs in some plasma membrane that is part of a liver cell"

form_or_variant_qualifier - CTD might have this.
causal_mechanism_qualifier - maybe.

Implementing this will make https://github.com/ExposuresProvider/cam-pipeline/issues/82 redundant.

I'm going to start with anatomical_context_qualifier since it should be relatively straightforward to implement in our pipeline if I can find the right query to find them. A lot of SYNGO models (e.g. http://model.geneontology.org/SYNGO_102#inferred), one GO model (http://model.geneontology.org/586fc17a00000528#inferred) and one AOP model (https://noctua.apps.renci.org/model/AOP_363#inferred) all reference UBERON:0000966 "retina", so this is probably a good place to start.


Force direct error ctor to have a reason

Purpose
Align direct error constructor expression with the spec.
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/17933
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #17944 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17944   +/-   ##
=======================================
  Coverage   15.17%   15.17%
=======================================
  Files          46       46
  Lines        1206     1206
  Branches      188      188
=======================================
  Hits          183      183
  Misses       1009     1009
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aafe6e...e3c52d4. Read the comment docs.


False positive with Var

Description of the problem / feature request:
VarChecker seems to behave erratically on implemented classes (and some other cases I haven't been able to fully pin down).
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
public class HealthCheckManager implements io.dropwizard.lifecycle.Managed {

  private final HealthCheckRegistry registry;
  private final ImmutableMap<String, HealthCheck> checks;

  @Inject
  HealthCheckManager(HealthCheckRegistry registry, Map<String, HealthCheck> checks) {
    this.registry = registry;
    this.checks = ImmutableMap.copyOf(checks);
  }

  @Override
  public void start() {
    checks.forEach(registry::register);
  }

  @Override
  public void stop() {}
}

Generates the following:
<path>/HealthCheckManager.java:20: error: [Var] Non-constant variable missing @Var annotation
  HealthCheckManager(HealthCheckRegistry registry, Map<String, HealthCheck> checks) {
                                         ^
    (see https://errorprone.info/bugpattern/Var)
  Did you mean 'HealthCheckManager(@Var HealthCheckRegistry registry, Map<String, HealthCheck> checks) {'?
<path>/HealthCheckManager.java:20: error: [Var] Non-constant variable missing @Var annotation
  HealthCheckManager(HealthCheckRegistry registry, Map<String, HealthCheck> checks) {
                                                                            ^
    (see https://errorprone.info/bugpattern/Var)
  Did you mean 'HealthCheckManager(HealthCheckRegistry registry, @Var Map<String, HealthCheck> checks) {'?

Emphasizing the state doesn't fix it, if I mark the two parameters in question final it compiles normally, but I get the following:
  HealthCheckManager(final HealthCheckRegistry registry, final Map<String, HealthCheck> checks) {
                                               ^
    (see https://errorprone.info/bugpattern/Var)
  Did you mean 'HealthCheckManager(HealthCheckRegistry registry, final Map<String, HealthCheck> checks) {'?
<path>/HealthCheckManager.java:20: error: [Var] Unnecessary 'final' modifier.
  HealthCheckManager(final HealthCheckRegistry registry, final Map<String, HealthCheck> checks) {
                                                                                ^
    (see https://errorprone.info/bugpattern/Var)
  Did you mean 'HealthCheckManager(final HealthCheckRegistry registry, Map<String, HealthCheck> checks) {'?

Annotating them with @Var prevents the alert, but is inaccurate.  Changing the names of the variables doesn't seem to help.
What version of Error Prone are you using?
2.3.2
openjdk 11 2018-09-25
OpenJDK Runtime Environment AdoptOpenJDK (build 11+28)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11+28, mixed mode)```

###  Have you found anything relevant by searching the web?

Could not find it in the github issues nor in `error-prone-discuss`.

This is also creating a false positive:
public class HCModule extends AbstractModule {

  @Override
  protected void configure() {
    requireBinding(HealthCheckRegistry.class);

    /* Other bindings */

    var healthCheckMapBinder = MapBinder.newMapBinder(binder(), String.class, HealthCheck.class);

    healthCheckMapBinder.addBinding("ax.lifecycle").to(StartupHealthCheck.class);
  }
}

var healthCheckMapBinder is generating: Non-constant variable missing @Var annotation     var healthCheckMapBinder = MapBinder.newMapBinder(binder(), String.class, HealthCheck.class);

Okay, digging into it further, I think I found what allows me to consistently replicate it: I need another error to fire first (e.g., I have some other file that error prone detects as having a different error). If that happens, then I can replicate it. If that error goes away, then the false positive with @Var goes away as well.

Regression has been introduced in 2.3.2 version, 2.3.1 works fine for me

Came across this today with the factory method on an AutoValue class.
public static EndpointWithSchema create(String dataEndpointId, Schema beamSchema) {
  return new AutoValue_SqlTableDefinition_EndpointWithSchema(dataEndpointId, beamSchema);
}

SqlTableDefinition.java:[23,51] error: [Var] Non-constant variable missing @Var annotation (see https://errorprone.info/bugpattern/Var)
  Did you mean 'public static EndpointWithSchema create(@Var String dataEndpointId, Schema beamSchema) {'?

SqlTableDefinition.java:[23,74] error: [Var] Non-constant variable missing @Var annotation (see https://errorprone.info/bugpattern/Var)
   Did you mean 'public static EndpointWithSchema create(String dataEndpointId, @Var Schema beamSchema) {'?

This was using error-prone 2.11.0.
$ java --version
openjdk 11.0.11 2021-04-20 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 11.0.11+9-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 11.0.11+9-LTS, mixed mode)

$ mvn -V
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /usr/local/Cellar/maven/3.8.4/libexec
Java version: 11.0.11, vendor: Amazon.com Inc., runtime: /Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "11.1", arch: "x86_64", family: "mac"

I am also seeing this issue in 2.15.0, exactly as @dclements described it.

I am also seeing this issue in 2.16.0, exactly as @dclements described it. If a different error is present, we got a long list of false positives, after fixing this unrelated issue, one occurrence of LenientFormatStringValidation in my case, then the false positives goes away.


zsh info files not linked to info directory

Basic info
To make sure that we are on the same page:

System: 15.09.1113.23395c4 (Dingo) (applies to nixos-unstable as well)
Nixpkgs version: "15.09.1113.23395c4" (applies to nixos-unstable as well)

Describe your issue here
Zsh Info documentation is built and present in
/nix/store/zsh/share/zsh-5.0.8/Doc/zsh.info*.  However they are not linked
to /run/current-system/sw/share/info/, so Emacs can't see them.
Expected result
Zsh Info files are available in /run/current-system/sw/share/info/.
Actual result
Zsh Info files are not present in /run/current-system/sw/share/info/.
Steps to reproduce

Run `emacs'.
Type `C-h i' (control-h + i).
Look for "zsh" (it's not present).

Please check if https://github.com/NixOS/nixpkgs/pull/13791 fixes this.

It's better now, the files are installed. But entry in .../share/info/dir file is still missing, so the "zsh" is still not visible in Emacs (see Steps to reproduce above).

As of https://github.com/NixOS/nixpkgs/pull/9326 the dir file will be auto generated for system profiles. It however won't be generated for user profiles. If you're on NixOS adding zsh to your system packages should do the job. If you're not here is a workaround https://github.com/NixOS/nixpkgs/issues/3030.

OK, hopefully it will work. (I can't test it as I'm a NixOS beginner and I couldn't find out how to install a package from unstable to the system profile of a stable system.)

There are many ways to do this. If you just want to add it to your systemPackages you can import the unstable nixpkgs and install it from there. First clone nixpkgs repo then add the following to your config:
{ ... }:
let myPkgs = import $pathToNixpkgs { };
in {
  environment.systemPackages = [
    myPkgs.zsh
  ];
}

$pathToNixpkgs can either be a relative path to your nixpkgs clone or an absolute path utilizing your NIX_PATH environment variable. Checkout your NIX_PATH it should contain something like nixpkgs=... and nixos-config=.... Just add another path to it like:
export NIX_PATH=$NIX_PATH:mypkgs=/path/to/nixpkgs/clone

Now you can use <mypkgs> to refer to this path. For example import <mypkgs> {}; will import the whole package tree while import <mypkgs/lib>; only imports the lib subdirectory. This kinda works like C includes.
Another way of doing this is via package overrides: https://nixos.org/nixpkgs/manual/#sec-modify-via-packageOverrides
If you are planning to get a bit more involved you can also let nixpkgs point to your fresh clone. It will then use your local nixpkg copy instead of the channel. If you still want to use stable you can simply check out the stable branch of your choice and cherry pick the changes you like.

info files should now be linked and accessible by default on NixOS systems.


forge build fails when contract pragma >=0.8.15

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (2457e5f 2022-06-16T00:04:29.19997Z)
What command(s) is the bug in?
forge build
Operating System
macOS (Intel)
Describe the bug
running forge build fails if the contract pragma is 0.8.15
example:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.15;

contract Contract {}

debug output:
[⠃] Compiling...2022-06-16T11:16:11.692503Z ERROR ethers_solc::resolver: failed to resolve versions
[⠊] Compiling...
[⠒] Unable to resolve import: "forge-std/Script.sol" with remappings:
        src/=/Users/sbacha/latest-sol/src/
        script/=/Users/sbacha/latest-sol/script/
Error:
   0: Discovered incompatible solidity versions in following
      : script/Contract.s.sol (^0.8.13) imports:
          src/Contract.sol (^0.8.15)
      Discovered incompatible solidity versions in following
      : src/Contract.sol (^0.8.15) imports:

Location:
   cli/src/compile.rs:100

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   2: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   3: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   4: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   5: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   6: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   7: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   8: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>
   9: __mh_execute_header<unknown>
      at <unknown source file>:<unknown line>

additionally here is a reproduction repo
https://github.com/sambacha/foundry-build-bug/pull/1
disabling auto-detect and removing remappings and script as a config field let it build
https://github.com/sambacha/foundry-build-bug/pull/3/commits/1ef999eb3603ca13d040d353ea0b6c2e53975bc7#diff-bac743fe3d899998e32393af53af8cc7d28c89c3d7fabfa48b01361cf8d42d9bR2-L38
note, that ^0.8.13 pragma version is compatible to the compiler directive of having ^0.8.15, >=0.8.15, ~0.8.15

Same here, did foundryup before.

I am not getting a checksum error , this is new

still an intermittent issue with the latest binary

We're getting the releases from solc's own list on platforms they support, so the issue seems to be upstream? cc @mattsse

can't reproduce this on today's nightly and intel mac
can you try removing rm -rf ~/.svm/0.8.15 ?

We're getting the releases from solc's own list on platforms they support, so the issue seems to be upstream? cc @mattsse
Edit: https://github.com/foundry-rs/foundry/issues/2003#issuecomment-1158234632

The solidity binary server does have intermittent outages, i have a cache proxy for our CI because of this

can't reproduce this on today's nightly and intel mac
can you try removing rm -rf ~/.svm/0.8.15 ?

Will check soon 🙏 thx

I'm getting a similar error, but on a fresh install of forge.
❯ forge build
[⠊] Compiling...
[⠃] installing solc version "0.8.15"
[⠊] Failed to install solc 0.8.15: Checksum mismatch for version 0.8.15
Error:
   0: Checksum mismatch for version 0.8.15

what's your OS and build?

OS X 12.4
forge 0.2.0 (e4a2915 2022-06-19T00:05:22.438573Z)

intel or apple silicon?

apple silicon

@roynalnaruto looks like we have some issue with the newest M1 native release

Status on this?

Status on this?

working wrt intel latest release

two issues fixed since this was opened

0.8.15 baked in
fixed incorrect apple silicon native builds

so closing this

What's the fix for this? I just got this on a Mac Intel with build forge 0.2.0 (f016135 2022-07-04T00:15:02.930499Z)

this should have been resolved,
can you try again after nuking: rm -rf ~/.svm/0.8.15

still fails :/
➜  hello_foundry (master) ✗ forge --version
forge 0.2.0 (f016135 2022-07-04T00:15:02.930499Z)
➜  hello_foundry (master) ✗ pwd
/Users/damontucker/workspace/git/hello_foundry
➜  hello_foundry (master) ✗ ls
foundry.toml script       src          test
➜  hello_foundry (master) ✗ rm -rf ~/.svm/0.8.15
➜  hello_foundry (master) ✗ forge build
[⠊] Compiling...
[⠒] Unable to resolve import: "forge-std/Script.sol" with remappings:
        src/=/Users/damontucker/workspace/git/hello_foundry/src/
        test/=/Users/damontucker/workspace/git/hello_foundry/test/
        script/=/Users/damontucker/workspace/git/hello_foundry/script/
[⠢] Unable to resolve import: "forge-std/Test.sol" with remappings:
        src/=/Users/damontucker/workspace/git/hello_foundry/src/
        test/=/Users/damontucker/workspace/git/hello_foundry/test/
        script/=/Users/damontucker/workspace/git/hello_foundry/script/
[⠘] installing solc version "0.8.15"
[⠊] Successfully installed solc 0.8.15
[⠒] Compiling 3 files with 0.8.15
[⠢] Solc 0.8.15 finished in 13.83ms
Error:
Compiler run failed
error[6275]: ParserError: Source "forge-std/Script.sol" not found: File not found. Searched the following locations: "/Users/damontucker/workspace/git/hello_foundry".
 --> script/Contract.s.sol:4:1:
  |
4 | import "forge-std/Script.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[6275]: ParserError: Source "forge-std/Test.sol" not found: File not found. Searched the following locations: "/Users/baizele/workspace/git/hello_foundry".
 --> test/Contract.t.sol:4:1:
  |
4 | import "forge-std/Test.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

➜  hello_foundry (master) ✗

you're liking missing the dependency

Worked after I did that. Thanks!
Created a pr to add this step: https://github.com/foundry-rs/book/pull/422

Closed that above pr as I figured out why it wasn't working for me.
Turns out I have a local git defender check that interferes with forge-std being built. Once I set up the git defender, I was able to successfully install with forge init hello_foundry --force --no-commit

You saved me @ebaizel 🙇🏼 thanks alot

forge script \

broadcast
[⠊] Compiling...
[⠒] Unable to resolve imports:
"forge-std/Script.sol" in "C:/Users/hp/Desktop/practice/script\SolveTutorial.sol"
with remappings:
[⠢] Unable to resolve imports:
"forge-std/Script.sol" in "C:/Users/hp/Desktop/practice/script\SolveTutorial.sol"
with remappings:
[⠆] Unable to resolve imports:
"forge-std/Script.sol" in "C:/Users/hp/Desktop/practice/script\SolveTutorial.sol"
with remappings:

[⠔] Compiling 1 files with 0.8.21
[⠒] Solc 0.8.21 finished in 53.04ms
Error:
Compiler run failed:
Error (6275): Source "forge-std/Script.sol" not found: File not found. Searched the following locations: "/Users/hp/Desktop/practice".
--> script/SolveTutorial.sol:3:1:
|
3 | import {Script} from "forge-std/Script.sol";
| How can I fix this issue.


Fixed deprecation

Fixed deprecation emerged in latest HA version.

Could someone check and approve this? Would be nice to get rid of those warnings that get printed to log every time home assistant starts...

@micahqcade perhaps?

Merged. Sorry


Allow SKU to be replaced on Etsy

hi I try to change my listing SKU with your program it work great on visual part but when i was try to update the change or saving it is not saving

Confirmed working


Specify using AllowEncodedSlashes and nocanon for httpd

Closes #7471
When using wiki page names that include a slash
behind a Apache HTTPD reverse proxy,
AllowEncodedSlashes NoDecode
and appending nocanon to the ProxyPass
directive is required. This commit adds that
information to the documentation.

Codecov Report

Merging #7540 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7540      +/-   ##
==========================================
+ Coverage   41.23%   41.25%   +0.02%
==========================================
  Files         469      469
  Lines       63620    63620
==========================================
+ Hits        26232    26248      +16
+ Misses      33965    33948      -17
- Partials     3423     3424       +1

Impacted Files
Coverage Δ

routers/repo/view.go
43.25% <0%> (+1.01%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

modules/git/git.go
37.34% <0%> (+3.61%)
:arrow_up:

models/unit.go
67.56% <0%> (+5.4%)
:arrow_up:

modules/setting/git.go
65.38% <0%> (+19.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d6d2f...e623165. Read the comment docs.


oneditsave seems to only run once

If I have a config input of aNumber, when you access the config object, it is of course a string immediately. personally, I don't like the idea of always having to use parseInt() to change it to a number, so I thought I could use the oneditsave function like so
...
oneditsave : function() { this.aNumber = parseInt(this.aNumber); }
...

I've noticed it works on the very first save/deployment, but if you change the number, then on future deployments, it is a string again. This seems to indicate that the oneditsave event is not running every time you save that node. Is that intentional? Is a "once" event being used instead of perhaps an "on" event?

Hi,
When oneditsave is called, the properties of this have not yet been updated from the edit form. So your line this.aNumber = parseInt(this.aNumber) is not using the new value from the form.
Assuming you have an <input> with an id node-input-aNumber, you should do:
this.aNumber = parseInt($("#node-input-aNumber").val());

By which I mean you should grab the new value from the edit form yourself, convert it and assign it.
If you have any general questions we prefer to handle them on the mailing list, slack team or you could ask a question on Stack Overflow and tag it node-red. That way the whole node-red user community can help answer the questions, rather than rely on the core dev team.
Thanks!


Manifests update while watch files

Jira
Update manifest files during watch compilation process

Closing this one out since the larger set of updates in #1315 shipped with v2.9.0.
Thanks again for your help on this @relimck!


reduce codecov uploads and add retry logic to fix frequent random build failures

Build failures seem to be happening frequently on codecov upload logic.  This PR attempts to fix these by making the logic more similar to https://github.com/microsoft/vision-explanation-methods/blob/main/.github/workflows/CI-python.yml and https://github.com/microsoft/responsible-ai-toolbox/blob/main/.github/workflows/CI-python.yml.  Specifically, we:
1.) only upload to codecov once, for a specific python environment + OS combination
2.) add retry logic, to retry codecov upload again if it failed
In the other repositories mentioned above this has resolved the codecov upload issue and hence it's expected to resolve the issue in the build + test script in this ml-wrappers repository too.

Codecov Report

Merging #91 (92d37dc) into main (be8fd6b) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 92d37dc differs from pull request most recent head 20180e7. Consider uploading reports for the commit 20180e7 to get more accurate results

@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   71.70%   71.70%
=======================================
  Files          25       25
  Lines        1389     1389
=======================================
  Hits          996      996
  Misses        393      393

Flag
Coverage Δ

unittests
71.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update README.md

The README has been updated to reflect the new function signatures, specifying the list of parameters and return values.
Python versions compatibility and requirements notes have been added.
A deeper code documentation will be provided with tools like Docstring.

I changed it to avoid redundancy. Basically, before this change you call any data broker function dbr.dbrCreate/Read/Get/... because of the module import (from dbr_module import dbr).
With the renaming, you write dbr just once. I like it better this way but I'm open to suggestions for improvement, since it's a personal preference.

Claudia Misale, PhD
Research Staff Member
Cognitive and Cloud, Data-Centric Solutions
IBM T.J. Watson Research Center
Yorktown Heights, NY

E-mail<EMAIL_ADDRESS>Phone: +1<PHONE_NUMBER>

----- Original message -----From: damora<EMAIL_ADDRESS>IBM/data-broker<EMAIL_ADDRESS>Claudia Misale<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Re: [IBM/data-broker] Update README.md (#54)Date: Wed, Feb 27, 2019 8:58 AM
@damora commented on this pull request.
why did you have to change the function names from dbrXXXX to XXXX, e.g. dbrCreate() to create(). Was there some type of name collision?
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.


Fix Japanese translation typo

Sorry about the mistake in the last PR... I've made a new one to fix it. Thanks for your patience!

No worries. Thanks for making moblin better =)


we need a declaration like Javas 'final' or another way to make functions 'not extensible'

the fact that anything is a prototype and can get extended gets annoying and hard to encapsulate the code.(classes)
a bit confused too.  how can something be a string and also be a function. i'd recommend removing the JavaScript inspired features.

Agree 💯, I'm not comfortable with how the abstract classes could be used.


Clarify activity on Diego cell

Related to https://github.com/cloudfoundry/diego-release/issues/344.

Thank you, @emalm

Thanks, @animatedmax !


Link/button got focused automatically inside Dropdown Menu

Forked from the Dropdown Menu (including submenus) demo. When click the root menu. The first menu item with link/button got focused automatically.
This is not a big issue but this behavior looks weird:

Demo: https://codesandbox.io/s/blissful-jepsen-tol4q7

You need to give the <a> a tabIndex={-1} to ensure it doesn't receive the initialFocus of the focus manager.
Also if you try to use the typeahead, it will break as it needs to be a string. I recommend amending MenuItem with an as prop to render an <a> tag instead. (<MenuItem as="a" />) rather than making label a non-string.


Bump AGP from 7.4 beta05 to rc1

Summary:
As AGP 7.4 is reaching it's stable status, let's move from beta05 to rc01.
That's needed for the sake of RN 0.71
Changelog:
[Internal] [Changed] - Bump AGP from 7.4 beta05 to rc1
allow-large-files
Reviewed By: rshest
Differential Revision: D41648863

Currently blocked by upstream bug:
https://issuetracker.google.com/issues/261329823

Abandoning as AGP 7.4 is broken. We need to wait for 7.4.1


Uncaught TypeError: Cannot read property 'keyIdentifier' of undefined

When I press a number in the edit area, an exception is thrown.
Atom Version: 1.0.12-bc68056
System: Ubuntu 15.04
Thrown From: vim-mode package, v0.60.0
Stack Trace
Uncaught TypeError: Cannot read property 'keyIdentifier' of undefined
At ~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/helpers.js:345

TypeError: Cannot read property 'keyIdentifier' of undefined
  at keyForKeyboardEvent (~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/helpers.js:345:26)
  at exports.keystrokeForKeyboardEvent (~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/helpers.js:162:11)
  at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:385:14)
  at VimState.module.exports.VimState.repeatPrefix (~/.atom/packages/vim-mode/lib/vim-state.coffee:588:33)
  at atom-text-editor.registerCommands.repeat-prefix (~/.atom/packages/vim-mode/lib/vim-state.coffee:71:32)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (~/bin/local/atom/share/atom/resources/app.asar/src/command-registry.js:240:29)
  at ~/bin/local/atom/share/atom/resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/bin/local/atom/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (~/bin/local/atom/share/atom/resources/app.asar/src/window-event-handler.js:184:20)

Commands
 16x -1:23.6.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -1:22.2.0 vim-mode:insert-below-with-newline (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -1:18.8.0 editor:newline (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -1:18.8.0 vim-mode:activate-normal-mode (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -1:18.5.0 vim-mode:move-to-beginning-of-line (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -1:18.3.0 vim-mode:move-left (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -1:18.2.0 vim-mode:delete-to-last-character-of-line (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
  2x -1:17.2.0 blur (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -1:01.2.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -1:00.6.0 vim-mode:repeat-prefix (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -1:00.3.0 vim-mode:move-to-line (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  3x -0:58.5.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:58.1.0 settings-view:open (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  9x -0:57.9.0 blur (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:00.6.0 vim-mode:repeat-prefix (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:00.2.0 vim-mode:reset-normal-mode (atom-text-editor.editor.vim-mode.normal-mode.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "symbols-view",
      "metrics",
      "linter-erb",
      "linter-haml",
      "linter-pylint",
      "linter-rubocop"
    ],
    "projectHome": "~/dev",
    "autoHideMenuBar": true,
    "themes": [
      "one-dark-ui",
      "atom-dark-syntax"
    ]
  },
  "vim-mode": {
    "useClipboardAsDefaultRegister": true,
    "useSmartcaseForSearch": true
  }
}

Installed Packages
# User
Handlebars, v1.2.1
Stylus, v1.2.1
atom-beautify, v0.28.12
atom-ctags, vundefined
file-icons, v1.6.9
git-blame-plus, v0.4.6
language-docker, v1.1.3
language-haml, v0.21.0
linter, v1.5.1
linter-csslint, v1.0.5
linter-js-yaml, v1.1.2
linter-jshint, v1.2.0
linter-ruby, v1.1.1
linter-shellcheck, v1.0.1
linter-stylint, v2.0.1
linter-tidy, v1.0.1
linter-xmllint, v0.0.7
minimap, v4.13.3
pigments, v0.15.0
react, v0.12.9
ruby-slim, v0.2.0
vim-mode, v0.60.0

# Dev
No dev packages

Can you reproduce this in safe mode (atom --safe)?  In addition, if it only happens on one file, can you please share that file as a Gist and upload it here?  Thanks.

Safe mode doesn't show this behaviour (and vim-mode is absent). In normal mode, it happens with any file I've encountered.

Ugh, I keep forgetting that safe mode also disables Vim Mode...sorry about that.

Just hit this too, let me know if you need any help debugging.

Appears to happen when pressing a number (for example, :1 yy)

+1

This just happened to me as well, most noticeably when I try something like 30G. The only causal event that I can think of was updating XCode command line tools (and XCode) to the latest via the default OSX update process... Nothing new other than that.

+1

Number prefix uses keyboard event. And this event seem to be undefined in some platform.
I hit this issue when I run spec via travis-CI for my forked vim-mode. This even happen for commit in the past.
@maxbrunsfeld Could you retry spec for newest commit in the past from travis-CI dahboard?

<EMAIL_ADDRESS><EMAIL_ADDRESS>Same bug.
Every time I hit a number like 3j, it throws this error.

+1
<EMAIL_ADDRESS><EMAIL_ADDRESS>

+1
<EMAIL_ADDRESS>Windows Server 2012 R2
Repros when I hit "+ trying to copy a word to clipboard.

Just did some investigation, this seems to be a bug introduced by commit https://github.com/atom/atom/commit/e3f9074f4a98f15a4436a79a2209e2fdece85dd4
As Atom no longer using the originalEvent as prototype of the CustomEvent, the originalEvent member is lost.

+1
<EMAIL_ADDRESS><EMAIL_ADDRESS>

This bug appears for me when attempting to use registers. Commands like...

"ayy
"ap
"Bdw

+1
atom: 1.0.13
vim-mode: 0.60.0
osx: 10.10
Please fix this, as it makes vim-mode unusable.

same issue here! lol :dart:
osx: 10,10.5
vim mode: 0.58.0
atom: 1.0.13

Same here
WIndows 7 64bits
vim mode: 0.60.0
Atom: 1.0.13

+1
OSX: 10.10.5
Vim-Mode: 0.60.0
Atom: 1.0.13

This is fixed with 1.0.14.

I can confirm that it is fixed with 1.0.14. Thanks for fixing this!

Thanks! Awesome turnaround for the bug fix.

:+1: Awesome that this was fixed so quickly.  Kudos to all involved.


Bug - Fixing Baseurls

This PR fixes the issue with baseurls to gain some consistency across local, forked repos, and the parent repo.  The solution decided upon in this pull request will make it so:

For forked repos, no changes have to be made at all, ever
For the parent repo, we are not using gh-pages functionality and it is deployed to s3.  Therefore, an sed utility command is being used to transform the baseurl to baseurl: "".  This ensures a good URL structure with the currently deployed website and makes sure the observatory page remains in working order.
For local development, developers can use the --baseurl flag when generating the site locally.  This will ensure matching a production-like environment from a URL structure perspective.  The sed command should NOT be used locally as it overwrites the config file.

Finally, as part of this solution, there were some instances of the site.baseurl not being prepended in places it should have been that this PR also fixes.  When adding this in to certain places (specifically one link in the header, a few in the footer, and several on the /who page), additional logic needed to be added to ensure that absolute URLs and email references, i.e. - those with http, https, or mailto in them don't have the site.baseurl prepended to them.

The ideal workflow is that someone can make a PR from their gh-pages branch, the reviewer can see what it looks like rendered, then that PR can be merged directly without any adjusting of config.yml.

implementing something different with deployments to s3, but then the github pages wouldn't be doing anything.

I'd like to explore this one. We're actually using CloudFront+S3 to serve our site now, so measurementlab.net points there. Github pages is now useful mainly for development, but not for serving our production site.

@mtlynch OK, got it that makes sense then.
If the parent repo is not using github pages at all and we don't need to support that, I added a new config file called "_config-deploy.yml" that is to only be used for the parent repo and deploying to s3.  This file will set the baseurl to "" and be used for the build that deploys to s3.  The existing _config can then be used for what actually gets built for forked repos and use the /m-lab.github.io baseurl.
Does that sound and work better from your perspective?

Hmm, I'm not crazy about the idea of maintaining two mostly identical config.yml files.
Would it be possible to generate the deploy config dynamically in the _travis.yml script (e.g. using the sed utility to replace the baseurl field).
Does this get any easier if we just rename the repo to something like "github.com/m-lab/website"?

Renaming the repo unfortunately wouldn't be the end-all cure as all the relative urls would have the /m-lab.github.io baseurl incorporated in the URL structure, so I imagine it would have unintended consequences when deploying to s3.
Will look into the sed utility feasibility to replace the baseurl field...

OK, I added a baseurl.sed script into a new _scripts directory as well as updated the travis file to include executing that script and then moving the dynamically generated _config.yml overwriting the _config in the root before travis builds, checks, and deploys the generated site.
That is the first time for me using the sed utility (awesome to learn a new trick!) so please let me know any feedback you may have for any better implementation methods.
If you are good with this solution, then I will update the documentation in the README file, just want to finalize the solution before updating that if it's okay.

Cool, can you submit for formal review?

Can you update the PR description to describe the ultimate solution we settled on.
Also can you include details in the PR description about the changes to the template logic? I understand the places where we're prefixing {{ baseurl }} but I'm not clear on what's going on with the link checks or the checks for mailto vs. http.

PR description has now been updated describing the finalized solution and the reason for the mailto vs. http logic.  If any of that needs further clarification, let me know.

When adding this in to certain places (specifically one link in the header, a few in the footer, and several on the /who page), additional logic needed to be added to ensure that absolute URLs and email references, i.e. - those with http, https, or mailto in them don't have the site.baseurl prepended to them.

I prefer to whitelist rather than blacklist when possible. Can we switch the logic so that instead of prepending unless we see http or mailto, we only prepend if the url starts with a forward slash?

OK, that makes sense.  The PR has been updated to whitelist rather than blacklist and look for a forward slash as the first character.

LGTM


Components render as undefined?

I'm trying to use the svelte components; however, they all render as undefined.  Here is a minimal example that fails.  I have a development relay I'm working with.

NDK Svelte Components

{npub}

    Name: <Name ndk={ndk} npub={npub}/>

    <RelayList ndk={ndk}/>

Console logs:
test:39 [HMR][Svelte] Unrecoverable HMR error in <Root>: next update will trigger a full reload
+page.svelte:18 dev _NDKUser {ndk: NDK, profile: undefined, _npub: 'npub1srwzlgp39charftweq5k28xeea4lr02fmwu0jhyhcj9sfdhtkjxstqm070', _pubkey: undefined, relayUrls: Array(0), …}
@nostr-dev-kit_ndk-svelte-components.js?v=b5da03b9:294275 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'pool')
    at update (@nostr-dev-kit_ndk-svelte-components.js?v=b5da03b9:294275:45)

The html source for the Name component:

you are creating ndk in the onMount call, which will run after rendering the page, so ndk will in fact be undefined on first run; either instantiate ndk outside the onMount or wrap your use in {#if ndk}


Report React Native app startup timing metrics via web-standard Performance Timeline API

Summary:
Changelog:
[Internal] -
Since now PerformanceEntryReporter can buffer arbitrary entry types (not just marks and measures), it's straightforward adding new ones that can be retrieved arbitrary amount of times (but also observed via PerformanceObserver, if so desired).
This diff introduces a new, custom Performance Entry type, rn-startup, which exposes different app start stages' timing.
At this point, it's exposing what ReactNativeStartupTiming did, but via the standard Performance Timeline APIs, without the need to create new API for each startup stage etc.
It also removes the need for any custom native code for ReactNativeStartupTiming API, in fact in this diff I also changed its implementation to use the Performance Timeline API instead in JS, removing all the native parts altogether.
We may not ultimately even need ReactNativeStartupTiming API per se anymore (as it can be superseded by more convenient, and more importantly mostly standard API), but this is a separate discussion, I left it as it is for now.
Differential Revision: D44584166

Closed internally


Dexie.Promise not keeping transactions open inside a Web Worker

I am well aware of the problems with Promises and IndexedDB, and why you need some kind of alternative Promise implementation like Dexie.Promise in most non-Chrome browsers.
However things seem even more complicated inside a Web Worker. Here is a minimal example (note that the branch is dexie not master if you want to clone).
I have some simple code using Dexie.Promise inside an IndexedDB transaction:
var Dexie = require('dexie');

var openRequest = indexedDB.open('firefox-indexeddb-promise-worker-test');

openRequest.onupgradeneeded = function() {
    var db = openRequest.result;
    var store = db.createObjectStore('whatever', {keyPath: 'id'});

    store.put({id: 1});
    store.put({id: 2});
    store.put({id: 3});
};

function get(tx, id) {
    return new Dexie.Promise(function (resolve, reject) {
        var req = tx.objectStore('whatever').get(id);
        req.onsuccess = function (e) {
            console.log('got', e.target.result);
            resolve(e.target.result);
        };
        req.onerror = function (e) {
            reject(e.target.error);
        };
    })
}

openRequest.onsuccess = function() {
    var db = openRequest.result;

    var tx = db.transaction('whatever');
    tx.oncomplete = function () {
        console.log('tx complete');
    };

    get(tx, 1).then(function () {
        return get(tx, 2);
    }).catch(function (err) {
        console.error(err);
    });
};

I run this code in a browser, and it works fine. No problem. I run it inside a web worker and I get an error due to the transaction not being active. (If you clone the package, switch to the dexie branch, and run npm start it will give you links to test both conditions yourself.)
Any idea what's going on, or how to work around this problem?

Which version of Dexie are you using?
Using Dexie.Promise around native indexedDB code won't help you get around incompabilities between promises and indexeddb since it will also have to schedule a new tick for its callback the same way as native promise does. With Dexie 2.x this is done using a native promise. With 1.x, this is done using other strategies (such as setTimeout(), that is still incompatible with indexedDB transactions).
If you are using Dexie 1.x, the problem could be gone with an upgrade to 2.x.
If you are using 2.x and still have this issue, it means that even Chromium still suffers from incompatibility between promise and indexedDB in workers.
The most secure way to get around these issues is by letting dexie take care of the IDB operations entirely. Of course you can access the native API if you need to, but you must then do that without promises (including Dexie Promise) if it should work across all browsers. (The magic that Dexie.Promise does internally, is to 1) mark the promise with non-standard internal "_lib" flag that scheduls the internal microtask engine, 2) be consistent with this in each async callback.)

Ok, so I saw you are using Dexie 1.5.1. Try upgrading to dexie@next. When upgraded, you could just use native Promise if you like. Your code will still just work in browsers that have Promise/IndexedDB compatibility anyway.
By the way, I saw you have created an in-memory indexedDB implementation! Would be interesting to try using it in Dexie's unit tests.

Thanks for the quick and detailed response! This is going slightly off-topic for Dexie, but I'm just curious how horrible you think something like this is:
const nativeIDBDatabaseTransaction = IDBDatabase.prototype.transaction;
const handleTransactionEnd = function () {
    this.txCount -= 1;
    if (this.txCount === 0) {
        self.Promise.idbTransaction = false;
    }
    console.log('tx done', this.name, this.txCount);
};
IDBDatabase.prototype.transaction = function (...args) {
    self.Promise.idbTransaction = true;
    if (!this.hasOwnProperty('txCount')) {
        this.txCount = 1;
    } else {
        this.txCount += 1;
    }
    console.log('tx start', this.name, this.txCount);
    const tx = nativeIDBDatabaseTransaction.apply(this, args);
    tx.addEventListener('abort', handleTransactionEnd.bind(this));
    tx.addEventListener('complete', handleTransactionEnd.bind(this));
    tx.addEventListener('error', handleTransactionEnd.bind(this));
    return tx;
};

Basically I'm doing something like your "_lib" flag automatically when starting a transaction. It feels pretty dirty, but it does seem to work.
Also I'll try to see if I can get Dexie running on fakeIndexedDB. It does have some bugs, but less than some browser implementations :)

You seem only to reference count the single transaction. Don't understand what it gives?


Unable to create separated tables for each user logged in

Hello Guys.
I `ve been trying to create a new table for each user. When  a test user logs in, he can see all the data from the table that belongs to another user. I tried checking the documentation but I didnˆt found nothing
Maybe I `m posting this on the wrong place , but I really need some help. The application will look like a online shop, where anyone can put their products in their own dashboard, separately. Each user will have its own dashboard.
Best regards
Pedro

I don't think is a devise issue. The behavior of your app can be accomplished with Rails ActiveRecord and some creative use of associations. You might want to post your question on StackOverflow.

@shakycode Thank you!


Send http metrics to Prometheus

Headline
Send HTTP metrics to Prometheus using expvar's.
Problem
Today we don't have metrics about all request made to the application and all requests made from the application.
Solution
Now we can send these metrics to an expvar and pooling this vars using the Prometheus to show inside Grafana
Example - Stage Environment

Please update readme, give overview how to setup

We don't need to do anything inside the Block Atlas. Expvars only expose the metrics, the overview going to be described inside the monitoring tool repository.


Add pt-BR translation

I managed to translate the website to Brazilian Portuguese, I hope this helps anyone who wants to use the website!

Done! Sorry I didn't know about the js/translations.js file, it should be all good now, if there is anything else, please let me know!


[Bug]: grpc-java 1.62.2 causes "no repository visible as '@com_google_protobuf_javalite'" error

What happened?
grpc-java 1.62.2 causes bazel mod graph to print an error instead of show the dependency graph.
Version
Development (host) and target OS/architectures:
Ubuntu LTS
Output of bazel --version:
$ bazel version
Bazelisk version: development
Build label: 7.2.1
Build target: @@//src/main/java/com/google/devtools/build/lib/bazel:BazelServer
Build time: Tue Jun 25 15:53:05 2024<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

How to reproduce
MODULE.bazel:

module(
    name = "example_thing",
    version = "0.0.0",
    compatibility_level = 1,
    repo_name = "example",
)

# Needed to resolve https://github.com/grpc/grpc-java/issues/11275.
bazel_dep(name = "grpc-java", version = "1.62.2")

.bazelrc
common --enable_bzlmod

$ bazel mod graph

ERROR: in tag at https://bcr.bazel.build/modules/grpc-java/1.62.2/MODULE.bazel:89:15: no repository visible as '@com_google_protobuf_javalite' to the repository '@@grpc-java~', but referenced by label '@com_google_protobuf_javalite//:protobuf_javalite' in attribute 'target' of tag 'override'. Is the module 'grpc-java' missing a bazel_dep or use_repo(..., "com_google_protobuf_javalite")?. Type 'bazel help mod' for syntax and help.

Any other information?
No response

Related issue in grpc-java repo: https://github.com/grpc/grpc-java/issues/11275


Etcd snapshot controller spews logs while waiting for nodes to annotate

Early in cluster startup, before any etcd nodes have reconciled their snapshots and set the annotations, the full sync loop will continually return errNotReconciled and be immediately reenqueued:

https://github.com/k3s-io/k3s/blob/e53c189587f8fe0f2aebb243e213ea03b5e38e76/pkg/etcd/snapshot_controller.go#L201-L203
https://github.com/k3s-io/k3s/blob/e53c189587f8fe0f2aebb243e213ea03b5e38e76/pkg/etcd/snapshot_controller.go#L62-L67

Unfortunately this creates a LOT of log spew, especially on RKE2 where startup takes a little longer to settle out.
We should move the log line further down the function, or reduce its verbosity.

Example log spew from a recent test cluster startup:
Nov 08 13:09:50 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:50Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:50 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:50Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:51 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:51Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:51 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:51Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:52 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:52Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:52 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:52Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:53 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:53Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:53 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:53Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:53 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:53Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:54 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:54Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:54 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:54Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:55 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:55Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:55 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:55Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:55 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:55Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:56 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:56Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:56 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:56Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:57 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:57Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:57 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:57Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:57 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:57Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:58 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:58Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:58 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:58Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:59 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:59Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:09:59 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:09:59Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:10:00 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:10:00Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:10:00 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:10:00Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"
Nov 08 13:10:00 test-node-xr6bx rke2[379]: time=\"2023-11-08T13:10:00Z\" level=info msg=\"Reconciling snapshot ConfigMap data\"

Hi @brandond, is this issue and the corresponding backports ready to be moved to Test? I see the PR linked has been merged

Yes, sorry - I apparently missed assigning it to myself so I didn't see it in the project board.

I'm wondering if whatever rancher manager is doing in their CI is causing this because I cannot reproduce it whether through rancher or standalone, even when having the etcd-snapshots tuned to take one every minute. I have tried all versions available. I will confirm no regressions to this logging and then close this issue. Using journalctl -u rke2-server | grep "Reconciling snapshot ConfigMap data" for rke2 and journalctl -u k3s | grep "Reconciling snapshot ConfigMap data" for k3s.

@rancher-max you'll see this spew when using embedded etcd, but no snapshots exist - either locally, or in the configured S3 bucket.

Validated on v1.28.4-rc1+k3s1
Environment Details

Infrastructure

[x] Cloud (AWS)
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Cluster Configuration:

1 server

Config.yaml:

write-kubeconfig-mode: 644
cluster-init: true
etcd-s3: true
etcd-s3-bucket: mybucket
etcd-s3-folder: myfolder
etcd-s3-region: us-east-2
etcd-s3-access-key: <redacted>
etcd-s3-secret-key: <redacted>
token: sometoken

Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Install k3s

$ curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.28.4-rc1+k3s1 sh -

Check logs for unnecessary spew:

$ journalctl -u k3s | grep "Reconciling snapshot ConfigMap data"
Nov 28 23:09:32 ip-172-31-46-231 k3s[1605]: time="2023-11-28T23:09:32Z" level=info msg="Reconciling snapshot ConfigMap data"

Replication Results:

k3s version used for replication:

k3s version v1.28.3+k3s2 (bbafb86e)
go version go1.20.10

I was not able to replicate the issue

$ journalctl -u k3s | grep "Reconciling snapshot ConfigMap data"
Nov 28 23:09:21 ip-172-31-37-124 k3s[1598]: time="2023-11-28T23:09:21Z" level=info msg="Reconciling snapshot ConfigMap data"

Validation Results:

k3s version used for validation:

k3s version v1.28.4-rc1+k3s1 (3f237230)
go version go1.20.11

The results were the same:

$ journalctl -u k3s | grep "Reconciling snapshot ConfigMap data"
Nov 28 23:09:32 ip-172-31-46-231 k3s[1605]: time="2023-11-28T23:09:32Z" level=info msg="Reconciling snapshot ConfigMap data"

No regressions noticed. Attempted in SLES15 SP4 and RHEL 9.2 as well with multinode setups and without s3 snapshots configured
In one case during validation, I saw two logs of this spit out but never more than that which should be acceptable.

Based on the above, I'm going to close this out. I think the log spew must appear under different circumstances, and I'm not noticing any base functionality changes here so should be okay either way.


What does nb_conda_kernels do?

nb_conda_kernels got added to my Anaconda installation on an update a few months back. Since then I've been confused as to what it does - it seems to make sharing Notebooks harder. What am I missing?
Here's my workflow:

Create a new environment for a project using conda
Make some Notebooks, commit to git, share to collaborator
Collaborator makes a similar environment, clones my repo
Using an activated environment the collaborator, having the same named project environment, is asked to select an environment (and presumably this changes the metadata for the Notebook)

I don't understand why this just doesn't use the default environment that jupyter notebook was run from. What's the advantage to me of activating an environment, starting a Notebook, then having to choose the same environment (and/or having a collaborator mess with the metadata when we're sharing Notebooks)?
What's the thinking behind fixing a Notebook to a (edit - removed "machine") specific environment name?
Update - I've now upgraded to 2.0 (which still required me to choose a kernel when I started a Notebook), I see on the installation page that I could also run
python -m nb_conda_kernels.install --enable --prefix="%CONDA_PREFIX"
which I've done because it looks magic, but not because I know what it'll fix.
For reference the Notebook metadata in this case contains:
  "kernelspec": {
    "name": "conda-env-fds-py",
    "display_name": "Python [conda env:fds]",
    "language": "python"
  },```

Hoping someone can set me straight...

After some more hacking my colleague tried python -m nb_conda_kernels.install --disable --prefix=$CONDA_PREFIX and this seems to disable the kernels. If we uninstalled the nb_conda packages then they just seemed to get reinstalled after a conda update --all so that didn't seem like a useful solution.
Having run the --disable it seems that when I run my Jupyter Notebook from an activated environment, it uses that environment only and the Notebook Metadata doesn't say anything about a conda-specific environment. I'm hoping this means my colleague and I can share Notebooks without any machine-specific environment naming issues.
If there's a really good reason not to disable the nb_conda_kernels I'd be happy to be educated. Cheers, Ian.

[note: most of this information is based on my usage of the environment_kernel_manager which more or less has the same idea as nb_conda_kernels]
The kernel isn't specific to the machine, it uses a name defined by the conda environment name: in this case the nb_conda_kernels creates a (virtual) kernel spec for each conda environment (which has a kernel installed?). So if you both have nb_conda_kernels installed and the same name for the projects conda environment, it should work.
Just to comment on the idea for a newish workflow:

install jupyter notebook in a new/root environment which only contains the notebook (i.e. no "project related" stuff) -> you only need to install the notebook once.
create a new environment for your project via conda (e.g. via a environment.yml file in your project dir) and install IPykernel in there
start the notebook server from the root/first environment in the project directory (e.g. via full path to jupyter.exe or whatever it is called on mac/linux)
create a new notebook by choosing the kernel from the project environment -> you don't need to activate the env!
[... hack and share ...]
get your collaborator to create the same environment(s), especially an environment with the same name as your project environment
open notebook and it should work

The "default name" is actually depended on having a jupyter kernel in the same environment as the jupyter notebook, which does not need to be the case (at least I tried to remove it, but conda didn't let me, bu AFAIK there shouldn't be a technical reason other than not confusing the user).

BTW: IMO the notebook (or a new package) should become a meta package which installs all teh package which the notebook now depends on in addition to a new "only the notebook" package. That way you could remove the meta package and everything you don't like (or need, so my usecase of not installing a kernel next to the notebook server).

Maybe my confusion came from having older Notebooks (prior to nb_conda_kernels being added to anaconda), then being forced to choose kernels in each and every one, then having my colleague do the same, then having to seemingly go round in circles causing a bunch of frustration. This was prior to version 2.0 which maybe fixes this.
I agree that the kernal names are machine inspecific (I've edited the original post), it felt like it might be specific as with kernel name "fds" set in the metadata by me and my colleague with an environment called "fds" he still had to manually choose his "fds" environment (and conda had already been used to activate his "fds" environment). I'm putting that down to random weirdness as it doesn't seem to happen now.
What I don't understand is why:

the Notebook has a second environment selector on top of the conda environment selector (to what gain?)
the Notebook is assumed to work in the same-named environment (which has to be communicated ahead-of-time and breaks using multiple environments for R&D) - who am I to mandate the name of environments on the machines of other folk?
If they use their own environment name, modify the Notebook and commit it then I'll get their modified metadata and I'll have to switch it back each time - to what gain?

Does it really make sense to have me activate an environment, open a Notebook (using jupyter in that environment) and then switch to a different environment? Is this a common workflow?
It isn't the biggest hurdle by any means but it seems like an extra step of effort for 0 gain. I'm still left wondering "what am I missing?".

the Notebook is assumed to work in the same-named environment (which has to be communicated ahead-of-time and breaks using multiple environments for R&D) - who am I to mandate the name of environments on the machines of other folk?

IMO this Assumtion never holds, no matter what you use: In your way, the implicit assumption is that the "default kernel" has all the package which the notebook needs, but that probably also never the case (at least it wouldn't be the case if you would send me a notebook...). And then add different python versions into the mix (e.g. in your case start with py27 environment and then with a py3x env). Either you mandate conventions or you will have these problems.

Does it really make sense to have me activate an environment, open a Notebook (using jupyter in that environment) and then switch to a different environment? Is this a common workflow?

You don't need to activate the notebook env, you just need to call the jupyter script (jupyter.exeon windows) with the full path.
This is my workflow and for that workflow, a kernel manager which adds a kernel for each env is a great help:

have one env with only the notebook (or use the root env), a env for each project and a project directory which holds the project specific files (=project git repo)
start a server in project dir with <path to jupyter.exe in notebook env>\jupyter.exe notebook -> notebook server which shows the root dir of the project folder
create a new notebook by explicitly choosing the project kernel

-> from then on, I just have to just open the notebook and it works
If I would collaborate with someone, I would add a environment.yml into the project folder (=repo) which would hold the name of the env and all packages and then would just ensure that each project member would have an easy command to create the project environment (make environment?). If someone wants to register their environment manually, that's also only one make register_environment away.
Only if someone does not want to use such a env based setup, you are going to need to use the default kernel (e.g. activate the project env, call jupyter-notebook and chose the default kernel ('Python [default]'). Or use a precommit hook / filter to rewrite the kernel name in the ipynb file (I anyway only commit without the numbers and output: http://janschulz.github.io/windows-dev-environment.html -> "proper diffs and commits for notebooks")

@janschulz Hey, bro, May I ask you something? I built a separate environment for running tensor flow using python=3.5, and like you said, by using nb_conda_kernels, no matter in which environment to launch jupyter, I will always have different environment kernel. And in every environment, I will have a default kernel, which should be the python or other language I install in my environment, right? So, in my root environment, if I launch jupyter notebook, I will see kernel options, like, default, root, other_environment_kernel. My question is that in my root environment, python is 2.7, but why do I still can type, print(2) in that kernel? This drives me crazy... And another problem is that I have R kernel installed in my root environment, but I can not trigger this kernel at other environment. The whole kernel stuff is driving me to death, I have not even had lunch...Thank you so much if you can help.

My question is that in my root environment, python is 2.7, but why do I still can type, print(2) in that kernel?

What's the output of sys.executable in that "root" kernel you are mentioning? That will tell you which python are you pointing at...

And another problem is that I have R kernel installed in my root environment, but I can not trigger this kernel at other environment.

You need to have R and the R-kernel installed in that environment so nb_conda_kernels can detect it and create the proper kernelspec...

This is a related question, sorry for placing it here: I need to create a kernel programmatically and currently do this using:
from jupyter_client.manager import KernelManager
km = KernelManager()
kernel = km.start_kernel(...)

and I assume it uses my one kernel that is listed using either
import ipykernel.kernelspec
ipykernel.kernelspec.get_kernel_dict()

{'argv': ['~/anaconda/bin/python',
  '-m',
  'ipykernel',
  '-f',
  '{connection_file}'],
 'display_name': 'Python 2',
 'language': 'python'}

or
import jupyter_client.manager as ma
ma.kernelspec.find_kernel_specs()

{'python2': '~/anaconda/lib/python2.7/site-packages/ipykernel/resources'}

How can I access the conda environment kernels? Especially get the list and finally create a kernel using the KernelManager in the environment of my choice like jupyter is doing. I was not able to find something in the documentation.

@jhprinz can you please open another issue about this? Just to not distort the previous discussion.
In short, you probably need to deal with nb_conda_kernels internals.

@damianavila Sure, will just copy this to a new issue. It is kind of a question about the docs though. I just wasn't sure if an issue is the best way to ask for help at all. Would stackoverflow be an alternative?

@jhprinz I think an issue is good beginning, you can also free to post in stackoverflow but I am not sure if you will find people there to ask this questions.

Closing this one since the original discussion stopped a long time ago. Please reopen (or open a new issues) if you have further questions.

This works almost perfectly for me. A few hiccups with how errors are displayed when I can't satisfy all version depdendencies, but otherwise fine.
The only thing I think I might miss is something akin to nb_conda_kernels for this, which can allow jupyter to discover several kernels. However it seems like the implementation of that depends directly on having a bundled python in the base environment :shrug:
Solving this might be out of scope, but is there any chance it's on your roadmap?


Allow tls_options hash to be passed to Net::LDAP

Net::LDAP::Connection supports a hash under the :encryption key in the options hash. The hash may have two keys, :method and :tls_options just a single symbol value (:simple_tls or :start_tls).
This would then allow you to add options like the following to your ldap.yml:
development:
  host: localhost
  port: 636
  ssl:
    method: simple_tls
    tls_options:
      verify_mode: VERIFY_NONE
      session_cache_mode: SESSION_CACHE_CLIENT

Very much necessary!!!

See also #246.


Model save in RBM

Description

Added save function to rbm.py: This writes model checkpoints to a specified directory.
Added load function to rbm.py: This gives users ability to instantiate a model class, load checkpoints from a pretrained model and resume training.
Added code snippet for how to use save and load functions to the RBM quick start notebook.

Related Issues

https://github.com/microsoft/recommenders/issues/878
https://github.com/microsoft/recommenders/issues/1510

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[x] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

Codecov Report

Merging #1618 (6bf139c) into staging (9dec57e) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

@@             Coverage Diff             @@
##           staging    #1618      +/-   ##
===========================================
- Coverage    59.12%   59.10%   -0.02%
===========================================
  Files           88       88
  Lines         8942     8953      +11
===========================================
+ Hits          5287     5292       +5
- Misses        3655     3661       +6

Flag
Coverage Δ

pr-gate
59.10% <73.91%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

recommenders/models/rbm/rbm.py
80.00% <73.91%> (-2.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cb35b...6bf139c. Read the comment docs.


feat(rust): add examples and about sections to markdown generated docs

This PR reorganizes the commands' documentation so we can better leverage clap tools to handle docs. The main introduced change is that we now have the command documentation split into two sections: long about to give an extended description of the command and after_long_help to show how to use the command (the examples section).
The documentation has the following structure now:
{about}
{usage}
{subcommands, arguments}
{options, global options}
{examples}
{learn more, feedback}

Another important change that this PR introduces is that now the markdown-generated docs have a more enriched structure, rendering the examples section as well as both the long and short "about" sections. The markdown version doesn't include the {learn more, feedback} section.

@adrianbenavides this looks great.
Since this is touching all the help txt files. Let's move them out of the constant folder into their respective command folders. There is no reason to centralize these in one folder.

@adrianbenavides this looks great. Since this is touching all the help txt files. Let's move them out of the constant folder into their respective command folders. There is no reason to centralize these in one folder.

We are duplicating the folder structure, so that makes total sense.


GIST_TOKEN

Is GIST_TOKEN an existing one like GITHUB_TOKEN or do you have to create it?

action.yml
  gist_token:
    description: |
      GitHub OAuth/PAT token to be used for accessing Gist to store
      test results report. The integrated GITHUB_TOKEN that is normally
      accessible during a Workflow does not include read/write permissions
      to associated Gists, therefore a separate token is needed.
      You can control which account is used to actually store the state by
      generating a token associated with the target account.


Unable to valiadte any FHIR response getting "Error loading /root/.fhir/packages/hl7.fhir.r5.core#4.6.0/package/StructureDefinition-Account.json: Unknown FHIRVersion code '4.6.0' on line 1"

Pick an Implementation Guide to validate against:
hl7.fhir.us.core
Profile:
Patient
Note: Same error is getting displayed for all profiles

Are you running the app locally or on a hosted instance (e.g. inferno.healthit.gov/validator)

Hi,
We are running using inferno.healthit.gov/validator
http://inferno.healthit.gov/validator
Thanks,
Amruth Raj
On Wed, May 19, 2021 at 8:59 PM Reece Adamson @.***>
wrote:

Are you running the app locally or on a hosted instance (e.g.
inferno.healthit.gov/validator)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/inferno-community/fhir-validator-app/issues/54#issuecomment-844216406,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUEMK3VV4YIXPGRFBLODWSLTOPKPFANCNFSM45E3C7WA
.

A change in the upstream package server (https://packages.fhir.org) caused a regression which made older versions of the library stop working. We've updated the deployed instance and the problem should be fixed now.
Can you give it another try and confirm that the issue is resolved so we can close this issue?

Going to close this issue since it appears to be resolved. @amruthkavadi feel free to reopen if you're still having problems.


Setup code formatting tool

kloppy doesn't have any code formatting tool in place. To make sure the code will be maintainable in the long term a code formatter is needed.
Black ( https://github.com/psf/black ) might be a good option.

Hi, are you accepting contributions on this?

Yes!

I've created a pull request for this issue: #23

Thanks @dmallory42


Removing app installer folder from samples

These files represent a sample appx package. It is confusing to have it as a sample code. It already exists in the correct format here (https://github.com/ms-iot/iot-adk-addonkit/tree/develop/Source-arm/Packages/Appx.Main).

Hi @namkedia, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Namrata Kedia). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


style(containers): fix word-break on container details table

Fixes #2676
Please see the screenshot

/azp run

@pull-dog up

Thanks @ranjan-purbey :+1:


[Tests] NFC: Don't attempt to run inlinable init accessor tests on de…

…vice or remotely
This test is using dylibs, which don't play way with remote/device CI.
Resolves: rdar://132715122

@swift-ci please smoke test