The pattern in the A to Z which show 'For example'

What do you need?
As a user I want to see clearly that I am been shown a For example throughout the A to Z and Writing for the Web.
What is the problem?
At present a full review of the pattern that is applied to For example is yet to be undertaken. I also note that the ways some For example are shown is not as clear and easy to understand for a user as it could be.
Which entry/section is this related to?
In the A to Z, I have noted many weeks ago now the following (may or may not be still the same):

For all the entries throughout:

do we use a full stop before showing a For example ?
we've been using the wording 'Like this', 'Not like this', 'Or like this', 'But not like this' can we improve on this usage within the pattern? See the entry for Commas as an example: http://content-style-guide.apps.staging.digital.gov.au/az-indexes/c.html#commas

At Video http://content-style-guide.apps.staging.digital.gov.au/az-indexes/v.html#video
under the subheading 'Accessibility' the bullet points don't show the dashes correctly.

At Titles http://content-style-guide.apps.staging.digital.gov.au/az-indexes/t.html#titles in the second For example don't show the dash correctly.

At Time http://content-style-guide.apps.staging.digital.gov.au/az-indexes/t.html#time question the guidance of: "Use a colon for the 24-hour clock." Also do we put guidance in for how to write "24 hr" ?

At Apostrophe http://content-style-guide.apps.staging.digital.gov.au/az-indexes/a.html#apostrophe the copy is in H3 as follows:

Indicates possession
Is used for expressions of time
Don’t use for plural abbreviation
Don’t use for decades
Please also see

At Audience http://content-style-guide.apps.staging.digital.gov.au/az-indexes/a.html#audience the bullet points show em or en dashes with no spaces either side.

At Inclusivity & diversity http://content-style-guide.apps.staging.digital.gov.au/az-indexes/i.html#inclusivity-diversity there's em or en dashes with no spaces either side.

At Navigation labels http://content-style-guide.apps.staging.digital.gov.au/az-indexes/n.html#navigation-labels remove the apostrophe from "page’s title" it should be "page title"

At A to Z http://content-style-guide.apps.staging.digital.gov.au/az-guide.html under the 'What is this?' the words "that is precise and specific" seem odd. Isn't specific a synonym of precise? Suggestion: delete 'precise' in favour of just using the plainer english 'specific'.

At Dictionaries and Spell checkers http://content-style-guide.apps.staging.digital.gov.au/az-indexes/d.html#dictionaries-spell-checkers the words "more similar" don't read / sound right.

At Documents http://content-style-guide.apps.staging.digital.gov.au/az-indexes/d.html#documents "Microsoft Word format" is not an accurate word choice, because the format is a ".doc" the program application as in https://products.office.com/en-au/word is 'Microsoft Word'. Also, "viewed on a mobile" is maybe not an accurate word choice as "on a mobile" does not tell the reader if the issue is the mobile device or the mobile device screen size. Suggestion: better read, if said like this: "The Microsoft Word file format .doc does not currently conform to WCAG 2.0 when viewed on some mobile device screens.

At SEO & metadata http://content-style-guide.apps.staging.digital.gov.au/az-indexes/s.html#seo-and-metadata there is no content here. A link still needs to go from the entry to the 'Writing for the web page' on 'Optimise your content for search'.

At Fact sheets http://content-style-guide.apps.staging.digital.gov.au/az-indexes/f.html#fact-sheets consider front loading the following sentence so it is easier to read: "Fact sheet information should first be offered as an accessible and printable HTML page." flip it so it reads: "Fact sheet  information should appear first as HTML on a web page to meet accessibility requirements and allow for printing."

Good example
No examples to show.

Will review to check what has been done.


make a release or add a tag for easier reference

@DeedleFake could you make a release (even if v0.0.1 or whatever) or add a semver-compatible flag so that it would be easier to reference the library when experimenting with or using it? Thanks! 😄

I've had a lot of backwards incompatible changes, but I suppose that I could do that, yeah. Just didn't really feel like it was stable enough quite yet.

Done.


Integration won't rollout with changes outside spec

While an Integration associated to a KameletBinding is running, when we make changes related to the binding .spec of the resource, the Integration will rollout applying the changes.
However, if we make changes outside the .spec, for example, changing some configuration parameter (ie. .metadata.annotations), the operator won't detect any change and won't rollout the new Integration.

Fixed via #3480


fix blueprint store directory name length

How to categorize this PR?

/area robustness
/kind bug
/priority 3
What this PR does / why we need it:
Fixes a bug where the generated blueprint id for the store exceeded max allowed name for a file/directory.
This PR fixes this by always using a hex encoded sha256 hash of the id.
Special notes for your reviewer:
Release note:

A bug has been fixed that caused the blueprint store to panic when the generated blueprint id exceeded the max allowed characters for a directory name.

/invite @MrBatschner @Diaphteiros


add all catagories on /participate

just adding this so we don't forget and it's probably none trivial to get all the icons / links right

[x] geo
[x] issue
[ ] help needed

these are all here now! :D


What if I wanna save the image into Local Album?

Like long-pressing or add a button at the left/right corner?

Just register for JTSImageViewControllerInteractionsDelegate and listen to
- (void)imageViewerDidLongPress:(JTSImageViewController *)imageViewer atRect:(CGRect)rect;
Simply retrieve the image [imageViewer image] and process / save it as needed.
To add buttons, you could subclass JTSImageViewController with a custom xib and then simply add the buttons you need, or do it directly in code.


hash_and_equals lint is inconsistent with dart fix

Dart SDK version: 2.19.0-444.4.beta (beta) (Tue Jan 10 10:24:44 2023 +0000) on "windows_x64"
Given:
class Example {
  final String name;

  Example({required this.name});

  @override
  bool operator ==(covariant Example other) {
    if (identical(this, other)) return true;

    return other.name == name;
  }
}

We get a lint "Missing a corresponding override of 'hashCode'. Try overriding 'hashCode' or removing '=='. dart(hash_and_equals)". However, when we follow the Quick Fix of Create method 'hashCode', we get
class Example {
  final String name;

  Example({required this.name});

  @override
  bool operator ==(covariant Example other) {
    if (identical(this, other)) return true;

    return other.name == name;
  }

  @override
  // TODO: implement hashCode
  int get hashCode => super.hashCode;

}

However, on hashCode, we then get the lint "Unnecessary override. Try adding behavior in the overriding member or removing the override. dart(unnecessary_overrides)".
When we select the Quick Fix, we are returned back to the first code example, where we again get the same lint of Missing a corresponding override of 'hashCode'.

This looks like desired behavior.
The "TODO" in the quick-fix hashCode is important, the code you got here was not a valid hash code implementation for the == method. You need to add behavior as suggested.
For example change it to:
@override
int get hashCode => name.hashCode;

We should either fix the unnecessary_overrides lint to ignore overrides with an attached TODO comment (or maybe just the TODO we produce), or we should produce a stub for hashCode that doesn't trigger the lint.
I wonder whether it would be reasonable to scan the == method to find a list of the fields that are referenced and whether it invokes super ==) and compose an implementation that combines the hash values of those fields. I seems like it wouldn't be too hard given that we have Object.hash and Object.hashAll, but I don't know whether implementing hashCode this way is something we want to promote.
@pq

@lrhn That makes sense. Maybe the wording of the "Unnecessary override" lint could be tweaked to add what you mentioned as a helpful example, ie telling the user a more concrete way they could add the implementation like you mentioned with name or even with (some or all of) the other fields in the class. Or maybe that's too much, just thinking out loud.
@bwilkerson Yes I was thinking of something similar, it might not be best to encourage looking at the hash of every member field since some aren't related to checking equality, but it could be done.
Either way I don't think there should be cycles in lint dependencies like in my example, it's somewhat jarring for the user in my experience.


Kernel to old

On our cluster I get:
FATAL: kernel too old
../ProteoStormData/ProteoStorm_Out/spectra_output/S1_pepfilter_commands_task_1.sh: line 1: 45281 Aborted                 (core dumped) src/CoreModule2_PeptideFiltering_Linux-x86_64.exe -i "../ProteoStormData/ProteoStorm_Out/spectra_output/S1_InputFiles/SpectralParts/SpecPart_342.mgf" -p "../ProteoStormData/ProteoStorm_Out/S1_PreprocessingOutput/ProteoStorm_input/DBPart_342.txt" -o "../ProteoStormData/ProteoStorm_Out/spectra_output/S1_OutputFiles/ProteoStorm_filtered/part_342.tsv" -ms1tol 10 -ms2tol 0.015 -s 7 > "../ProteoStormData/ProteoStorm_Out/spectra_output/S1_OutputFiles/ProteoStorm_filtering_logs/part_342.log"

Running CentOS 6.0 with kernel 2.6.32-696.23.1.el6.x86_64 #1 SMP Tue Mar 13 22:44:18 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Can you try to compile with the option described here: https://www.quora.com/What-causes-the-error-FATAL-kernel-too-old-in-Linux-What-is-the-best-way-to-avoid-this-when-compiling-statically-linked-executables ?
Or provide the sources?

solved? :)

Hi Dr. Bernt! :) Apologies! I meant to write a comment regarding this issue when I closed it, but got caught up with another task. The source code for core module 2 (peptide filtering) is available in the repository under path /src/CoreModule2_PeptideFiltering. I have also compiled a Linux executable using CentOS 6.10 with Kernel version 2.6.32-754.2.1.el6.x86_64.


Unable to resolve module react-native/Libraries/StyleSheet/ColorPropType.js

Unable to resolve module react-native/Libraries/StyleSheet/ColorPropType.js in react-native-linear-gradient/index.ios.js and react-native-linear-gradient/index.android.js with latest React-Native v0.57.3

works for me. are you sure you don't have some stale yarn cache or something?

It works now. Thanks for fixing

I didn't do anything 😂

@radex in<EMAIL_ADDRESS>that file has been moved to Libraries/DeprecatedPropTypes/DeprecatedColorPropType.js. Might need some conditional require to work with old and new versions :thinking:

ah, just saw the PR to remove the prop types, ignore me :)

Hey guys, @topwebtek and @radex, am having this issue in version 0.58.0 and have not been able to fix it. What could be responsible? I have done npm start -- --reset-cache yet, error persists. Any help will be appreciated

@nwaughachukwuma
copy from this file

/node_modeuls/react-native/Libraries/DeprecatedPropTypes/DeprecatedColorPropType.js

to this location

/node_modeuls/react-native/Libraries/StyleSheet/

then rename it to ColorPropType.js
this should fix the issue

OK thanks so much. But the problem is that I dont build locally. I use app center to automate my build process

Definitely not a long term fix.

Yeah, there's a lot of bugs in React Native 0.58.x (x<=3), and I raised an issue over that. Let's hope it becomes stable in the near future. Thanks so much

@radex Should this issue be re-opened? That module has been deprecated.

@KevinColemanInc You're right. PropTypes are dead, long live Flow types.
I started doing the work to remove PropTypes from this library in this PR: https://github.com/react-native-community/react-native-linear-gradient/pull/364/files
… but I don't have the time right now to finish it. @KevinColemanInc @nwaughachukwuma @Nualiian  @dlferro  @frodoe7 Is any of you willing to pick up the work? There's not much to do there… just clean up and test on iOS and Android that nothing is broken. Then we can merge it and release and update that will fix it once and for all

Flow and PropTypes are dead. TypeScript is where it's at.
Anyhow, do we have a temporary fix that would fix build servers? Cannot copy stuff manually.
We updated 3 apps to 58 today :-|

@voidstarfire See the comment above. The fix is fairly straightforward — remove PropTypes altogether and copy over updated Flow types (see #364). Please send a qiuck PR and I will merge and release today if it looks good :)

Heya thanks for the reply.
Production pipelines do things from scratch (IE, yarn install), I'd have to create a little script and add it to multiple steps :-D a lotta work. I just downgraded for now, RN 57.
I'm glad there's a PR waiting great :-)

With the update of RN, I hope to solve this problem as soon as possible.

I'm having this issue as well. Is there still not a fix that doesn't require messing around with the react-native module files?

Yes, I'm eagerly anticipating this fix as well.

This error disappeared once I upgraded to react-native 0.59.4 and react-native-linear-gradient 2.5.4
Should this be closed?

Looks like 2.5.4 works for me too

Some for me, updated react-native-linear-gradient 2.4.4 to react-native-linear-gradient 2.5.4 and it works again.

Updating to 2.5.4 hanged my error to:
error: bundling failed: Error: Unable to resolve module `./nativeLinearGradient` from `/Users/.../node_modules/react-native-linear-gradient/index.ios.js`: The module `./nativeLinearGradient` could not be found from `/Users/.../node_modules/react-native-linear-gradient/index.ios.js`. Indeed, none of these files exist:
  * `/Users/.../node_modules/react-native-linear-gradient/nativeLinearGradient(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
  * `/Users/.../node_modules/react-native-linear-gradient/nativeLinearGradient/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
    at ModuleResolver.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:163:15)
    at ResolutionRequest.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:52:18)
    at DependencyGraph.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph.js:283:16)
    at Object.resolve (/Users/.../node_modules/metro/src/lib/transformHelpers.js:261:42)
    at dependencies.map.result (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:399:31)
    at Array.map (<anonymous>)
    at resolveDependencies (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:396:18)
    at /Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:269:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:87:24)

I'm still seeing this issue with react-native: 0.59.9 and react-native-linear-gradient: 2.5.4

Updating to 2.5.4 changed my error to:
error: bundling failed: Error: Unable to resolve module `./nativeLinearGradient` from `/Users/.../node_modules/react-native-linear-gradient/index.ios.js`: The module `./nativeLinearGradient` could not be found from `/Users/.../node_modules/react-native-linear-gradient/index.ios.js`. Indeed, none of these files exist:
  * `/Users/.../node_modules/react-native-linear-gradient/nativeLinearGradient(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
  * `/Users/.../node_modules/react-native-linear-gradient/nativeLinearGradient/index(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)`
    at ModuleResolver.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:163:15)
    at ResolutionRequest.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph/ResolutionRequest.js:52:18)
    at DependencyGraph.resolveDependency (/Users/.../node_modules/metro/src/node-haste/DependencyGraph.js:283:16)
    at Object.resolve (/Users/.../node_modules/metro/src/lib/transformHelpers.js:261:42)
    at dependencies.map.result (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:399:31)
    at Array.map (<anonymous>)
    at resolveDependencies (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:396:18)
    at /Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:269:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/.../node_modules/metro/src/DeltaBundler/traverseDependencies.js:87:24)

edit index.android.js and save , or delete all content of the index.android.js and recover , i fixed it


chore(examples): make hero image jpg

JPG is a more fitting image format for pictures, since it compresses better. Instead of 700 & 790 kB, it's now 80 & 50 kB
This change has already happened on Vue, but not yet React & Angular

This brought the performance score on lighthouse for the e-commerce demo from 81 -> 87


New Feature Request - Accept Batch

Hello,
Could you kindly make this accept batch? It would make it much more compatible with a lot of other tools.

Batch over what? Could you post a scheme of proposed workflow? So I would know what kind of inputs BrushNode will get and from what nodes.

Batches of images. Basically if I have a folder with images, or a video, I want to be able to pipe this straight into your nodes such that it processes the images as a batch. It would be the node pack below.
Right now your nodes do not accept batches and only work on single images. Actually they do accept batches, just does not actually function properly (likely because the code already exists just not configured properly)
Batches is the first step to getting this working with more things... like video (AnimateDiff),, but also is a massive quality of life improvment.
https://github.com/nullquant/ComfyUI-BrushNet/issues/62#issuecomment-2095266517

Thank you, I will look into it.

I've done it. Let's try!

I've done it. Let's try!

Not working unfortunatly. 6 Image batch input, but only 1 image coming out of the ksampler (see image below for workflow)
FETCH DATA from: D:\COMFYUI\ComfyUI\custom_nodes\ComfyUI-Manager\extension-node-map.json
[comfy_mtb] | WARNING -> Found multiple match, we will pick the first D:\COMFYUI\ComfyUI\models\upscale_models
['D:\COMFYUI\ComfyUI\models\upscale_models', 'C:\Users\infer\OneDrive\Documents\Auto1111\stable-diffusion-webui\models/ESRGAN', 'C:\Users\infer\OneDrive\Documents\Auto1111\stable-diffusion-webui\models/RealESRGAN', 'C:\Users\infer\OneDrive\Documents\Auto1111\stable-diffusion-webui\models/SwinIR']
got prompt
[rgthree] Using rgthree's optimized recursive execution.
[rgthree] First run patching recursive_output_delete_if_changed and recursive_will_execute.
[rgthree] Note: If execution seems broken due to forward ComfyUI changes, you can disable the optimization from rgthree settings in ComfyUI.
model_type EPS
Using xformers attention in VAE
Using xformers attention in VAE
BrushNet model type: SD1.5
BrushNet model file: D:\COMFYUI\ComfyUI\models\inpaint\random_mask_brushnet_ckpt\diffusion_pytorch_model.safetensors
BrushNet SD1.5 model is loaded
Requested to load SD1ClipModel
Loading 1 new model
D:\COMFYUI\ComfyUI\comfy\ldm\modules\attention.py:345: UserWarning: 1Torch was not compiled with flash attention. (Triggered internally at ..\aten\src\ATen\native\transformers\cuda\sdp_utils.cpp:263.)
out = torch.nn.functional.scaled_dot_product_attention(q, k, v, attn_mask=mask, dropout_p=0.0, is_causal=False)
Base model type: SD1.5
BrushNet image.shape = torch.Size([1, 1080, 1920, 3]) mask.shape = torch.Size([1, 1080, 1920])
Requested to load AutoencoderKL
Loading 1 new model
BrushNet CL: image_latents shape = torch.Size([2, 4, 135, 240]) interpolated_mask shape = torch.Size([2, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
D:\COMFYUI\ComfyUI\venv\lib\site-packages\diffusers\models\resnet.py:328: FutureWarning: scale is deprecated and will be removed in version 1.0.0. The scale argument is deprecated and will be ignored. Please remove it, as passing it will raise an error in the future. scale should directly be passed while calling the underlying pipeline component i.e., via cross_attention_kwargs.
deprecate("scale", "1.0.0", deprecation_message)
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:07<00:00,  2.58it/s]
Prompt executed in 15.75 seconds
got prompt
[rgthree] Using rgthree's optimized recursive execution.
Base model type: SD1.5
BrushNet image.shape = torch.Size([1, 1080, 1920, 3]) mask.shape = torch.Size([1, 1080, 1920])
BrushNet CL: image_latents shape = torch.Size([2, 4, 135, 240]) interpolated_mask shape = torch.Size([2, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
D:\COMFYUI\ComfyUI\venv\lib\site-packages\diffusers\models\resnet.py:328: FutureWarning: scale is deprecated and will be removed in version 1.0.0. The scale argument is deprecated and will be ignored. Please remove it, as passing it will raise an error in the future. scale should directly be passed while calling the underlying pipeline component i.e., via cross_attention_kwargs.
deprecate("scale", "1.0.0", deprecation_message)
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:07<00:00,  2.63it/s]
Prompt executed in 9.35 seconds
got prompt
[rgthree] Using rgthree's optimized recursive execution.
Base model type: SD1.5
BrushNet image.shape = torch.Size([1, 1080, 1920, 3]) mask.shape = torch.Size([1, 1080, 1920])
BrushNet CL: image_latents shape = torch.Size([2, 4, 135, 240]) interpolated_mask shape = torch.Size([2, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:07<00:00,  2.66it/s]
Prompt executed in 9.15 seconds
got prompt
[rgthree] Using rgthree's optimized recursive execution.
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:09<00:00,  2.18it/s]
Prompt executed in 9.96 seconds
got prompt
[rgthree] Using rgthree's optimized recursive execution.
Base model type: SD1.5
BrushNet image.shape = torch.Size([2, 1080, 1920, 3]) mask.shape = torch.Size([2, 1080, 1920])
BrushNet CL: image_latents shape = torch.Size([4, 4, 135, 240]) interpolated_mask shape = torch.Size([4, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([4, 5, 135, 240])
BrushNet inference: sample batch is less, than CL!
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:09<00:00,  2.19it/s]
Prompt executed in 12.02 seconds
got prompt
[rgthree] Using rgthree's optimized recursive execution.
Base model type: SD1.5
BrushNet image.shape = torch.Size([6, 1080, 1920, 3]) mask.shape = torch.Size([6, 1080, 1920])
BrushNet CL: image_latents shape = torch.Size([12, 4, 135, 240]) interpolated_mask shape = torch.Size([12, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: do_classifier_free_guidance is True
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([12, 5, 135, 240])
BrushNet inference: sample batch is less, than CL!
BrushNet inference: sample torch.Size([2, 4, 135, 240]) , CL torch.Size([2, 5, 135, 240])
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:08<00:00,  2.41it/s]
Prompt executed in 14.34 seconds

I updated the code, try it.

I updated the code, try it.

nope
Base model type: SD1.5
BrushNet image.shape = torch.Size([3, 1080, 1920, 3]) mask.shape = torch.Size([3, 1080, 1920])
BrushNet CL: image_latents shape = torch.Size([6, 4, 135, 240]) interpolated_mask shape = torch.Size([6, 1, 135, 240])
Requested to load BaseModel
Loading 1 new model
0%|                                                                                | 0/20 [00:00<?, ?it/s]BrushNet inference: sample torch.Size([1, 4, 135, 240]) , CL torch.Size([3, 5, 135, 240])
BrushNet inference: sample batch is less, than CL!
BrushNet inference: sample torch.Size([1, 4, 135, 240]) , CL torch.Size([1, 5, 135, 240])
BrushNet inference: sample torch.Size([1, 4, 135, 240]) , CL torch.Size([3, 5, 135, 240])
BrushNet inference: sample batch is less, than CL!
BrushNet inference: sample torch.Size([1, 4, 135, 240]) , CL torch.Size([1, 5, 135, 240])
100%|██████████████████████████████████████████████████████████████████████████████████| 20/20 [00:09<00:00,  2.18it/s]
Prompt executed in 12.96 seconds

Sorry for inconvenience, found a bug, no, a BUG in codebase. It should work now.


CI tests

First of all it just needs to install the module.
Then the server can be spawned, while the integration tests run.
At this point it just needs to be a sanity check really.
TODO: better tests with proper testing framework!!!

Test coverage definitely needs expanding, but the tests do exist, so I'll close this issue


Invoker organizations

We want to develop a community around invokers. Once there is more than once publisher of invokers, we run the risk of name collisions. If projectriff publishes a go invoker and google publishes a go invoker, how does a user know which is installed? What if they want both to be installed?
The traditional approach is to use an organization as a namespace, however, k8s is very restrictive about what characters are allowed in a resource name. The only characters guaranteed to work are a-z, ., and -. This means we can't simple concatenate an organization name with the invoker name and a special character, like / or :.
We could:

not use a organization namespace
use . as the separator. riff create projectriff.go ...
decouple invoker resolution from the resource name to another property of the invoker, like .spec.name and use a randomly assign name. This means interaction with the invokes via kubectl will be more cumbersome, but we can maintain the current experience via riff-cli. riff create projectriff/go ...

In either case, a user can assign an alias when installing an invoker to maintain a simple riff create go ... experience, if desired.

This issue has gone stale, we're on Knative now! Please reopen if still relevant.


"Merge conflict marker encountered" problems after resolving merge conflict

I see this sometimes after using the merge editor. They don't go away until the window is reloaded. Do you know anything about this, or do you know which extension they would be coming from?

A web search suggests this might be a stale ESLint error (stale from the CLI, not the extension). 🤷♂

The extension host could be frozen. In any case, this is unrelated to the merge editor.


Fix not compiling due to gvisor/tsnet

as per https://github.com/tailscale/tailscale/issues/7596 latest gvisor doesn't compile with tailscale
So downgrade, upgrade tailscale to latest, and tidy

Thanks for the pull request! I've finally fixed it while bumping the Tailscale to 1.60.0.


Fix coverage of numba jit compiled functions

The coverage of jit compiled functions is not correctly captured so I now disable numba jit compilation before generating the coverage report, also switch all instances of the @jit operator to @njit

Need to make changes to github actions so make sure that we're testing the numba jit compilation, should add one more run of unit tests with numba disabled for coverage


Add webpack watcher on partial include/extends/embed

add editor config
add partial watcher (addDependency)
move var to const and let

@jabney ready to review.
I saw a mistake when i was trying to add test. It's fixed now.

render-template-loader v1.2.3 on npm

@ryuran,
If you want, submit a pull request with your contributor info in the package.json file and I'll merge it in. Use any or all of these keys:
package.json:
"contributors": [
  {
    "name": "...",
    "email": "...",
    "url": "http://..."
  }
]

Or just reply here with your info and I'll add it myself.


Swift 4 support required

It was in my plan. Hopefully, it is able to go live in this weekend.

Any updates pls!!

@rajahimanath
A new release 3.0 that supports Swift 4 is available now. Please check it out and get back to me if any. Thanks for your attention.

I'm gonna close this issue. Feel free to file another one relatively if any.


[backup] CommandAdapter backup storage: hide env vars in debug log

Motivation
print only those env vars as input params, like $FILE_HANDLE, but not those defined in the config file. Because sensitive information can be there, like credentials.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
existing coverage
Related PRs

/land


Enable easier date comparisons

Right now if you have a string containing a date in whatever format, to know if it's a past or future date for example you have to do:
{% if item.date|date('U') < 'now'|date('U') %}

That creates two DateTime instances and then formats them and then compares the values. You can't really omit the ('U') since the default format doesn't really do comparisons well.
Two options for improvements:

Add a datetime filter or such that returns the unformatted DateTime, then they can be compared
Add some date specific tests (is older than?), but those to also support <= and such it'll be a bit verbose

This is just a stub (not tested) of a filter to convert to a DateTime object.
https://github.com/alefranz/Twig/commit/5504f8bc370e1fbfa802c30d87b7663f8c6bf289
I like to refactor the date format filter to call this filter, but I don't get the reason to invoke the setTimezone on a DateInterval object...?

sent a pull request to skip setTimezone on DateInterval (https://github.com/fabpot/Twig/pull/575), then this code can be refactored

@Seldaek Would {% if date(item.date) < date('now') %} be acceptable? Or perhaps even just {% if date(item.date) < date() %} for when the date is now.

Sounds better to me. Obviously if item.date is already a DateTime
nothing should happen to it.

What would be best IMO, but I guess it won't be acceptable BC-wise, is to remove the default format in the date filter, and if you don't specify a format you just get a DateTime back, then the filter/function would be doable in one.
Other than that, date -> date_format would have made sense a year ago, but since you'd keep the old one, most likely everyone would keep using date and then when you read the docs it says date_format, this disconnect will probably end up more confusing than the added coherence it gives.


Bug report

youtube-dl -x --audio-format best https://www.youtube.com/watch?v=G22X5X49VhM
[youtube] Setting language
[youtube] G22X5X49VhM: Downloading webpage
[youtube] G22X5X49VhM: Downloading video info webpage
[youtube] G22X5X49VhM: Extracting video information
[youtube] G22X5X49VhM: Encrypted signatures detected.
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflsfFMeN/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
sergey@home:~/Загрузки$ youtube-dl -x --audio-format best --verbose https://www.youtube.com/watch?v=G22X5X49VhM
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-x', '--audio-format', 'best', '--verbose', 'https://www.youtube.com/watch?v=G22X5X49VhM']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.05
[debug] Python version 2.7.9 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.5
[debug] Proxy map: {}
[youtube] Setting language
[youtube] G22X5X49VhM: Downloading webpage
[youtube] G22X5X49VhM: Downloading video info webpage
[youtube] G22X5X49VhM: Extracting video information
[youtube] G22X5X49VhM: Encrypted signatures detected.
WARNING: unable to extract html5 player; please report this issue on http://yt-dl.org/bug
[youtube] {43} signature length 40.44, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflsfFMeN/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflsfFMeN/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 516, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 170, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 860, in _real_extract
encrypted_sig, video_id, player_url, age_gate)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 489, in _decrypt_signature
u'Signature extraction failed: ' + tb, cause=e)
ExtractorError: Signature extraction failed: Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
video_id, player_url, s
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflsfFMeN/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

You are using an outdated version of youtube-dl. Read this FAQ entry if you have troubles updating.

I just tried to extract audio from these https://www.youtube.com/watch?v=G22X5X49VhM url but it seems it has encrypted signature and can not extract html5 player videos (at all?)

Ok sorry, I just installed via Debian repos + backports.


error in readme / How to install?

This is the software I have been searching for!
In the "How to install?" chapter you mention a file app/config/local/database.php, however there's no directory called 'local' under app/config/...
I'm quite sure it's app/config/database.php, is it?

Hi jniggemann !
In fact, Laravel can manage multiple environment, by creating subdirectories in app/config. If you don't care about it, you can directly edit the app/config/database.php file, yes :)

I cannot run composer command, what do I need to install?

You need to install composer

Got it up and running :-) Thank you and keep up the good work!


Use Alpine's Doas instead of OpenDoas (Alpine's has persistance support)

Has this been considered?

Alpine's doas is opendoas.  We likely need to just switch our upstream url to @Duncaen's releases

probably a good idea. prs welcome will be able to review at the weekend.

Alpine's doas is opendoas. We likely need to just switch our upstream url to @Duncaen's releases

I meant; Apply their patches

If we’re asking to include patches, we could probably do well with Chimera’s patches for Musl.

Chimera applies all of Alpine's patches + some more, so, its roughly the same. But, yeah.

I’m working on adding some patches to musl libc it in my personal tree, I can do the doas patches once I get those done.

Update: it is now midnight, I will sleep and add the “Chimera Musl” to a different pr tomorrow, and do the Alpine’s doas patches tomorrow as well.

I’m working on adding some patches to musl libc it in my personal tree, I can do the doas patches once I get those done.

If you want to try the chimera Musl thing: it’s in Frankensrc (I need to figure out why it’s being jank, ymm)

My hard drive where I was storing my Iglunix install was/is dying and I’m no longer capable of testing stuff. Apologies for any inconvenience.


Add shims for critical section macros

https://docs.python.org/3.13/c-api/init.html#python-critical-section-api
On older pythons these can just be open and close brace.

@ngoldbaum: yeah, it makes sense. Do you want to propose a PR for that?

On older pythons these can just be open and close brace.

Or just be empty.

Implemented by https://github.com/python/pythoncapi-compat/pull/106


Tablet Pen Scrolling

I have ugee m708 pen tablet. I want to use pen for scrolling. how can I do that?

Still update.

Same request, modifier keys to simulate scroll wheel on pen tablet


Support for multiline entries

While migrating some of my cronjobs to supercronic, I noticed that multiple lines joined together with the \ character work in cron, but are not supported in supercronic.
For example:
*/10 * * * * echo 'a' && \
                  echo 'b' && \
                  echo 'c'

Is a valid crontab entry for most classic crons, but is rejected by supercronics parser.

Greetings!  Thanks for submitting this issue.  I'd be happy to accept a PR (with tests) to support this feature.


feat: load more records

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

This PR adds the ability to fetch more records in lieu of infinite scroll. Infinite scroll is an expensive feature and this is the first step towards that.
Related Tickets & Documents

#81
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
This does not check if all records have been fetched. It would be more ideal to limit the number of records fetched to 100 and request the user use search instead.
[optional] What gif best describes this PR or how it makes you feel?

LGTM. There were only 2 things that I noticed that dont affect the functionality but may be considered:

The limit value stays the same when switching active links. In this scenario, it is fine since there is a limit on the number of repos that can be shown. In the path to infinite scrolling, we will probably want to either cache or reset the limit value when switching links to avoid loading a large set of data.
In Safari when loading more repos the page stayed in its current position but in Chrome and Edge the page scrolled to the bottom of the list. This is more so a difference in how the browsers handle new data being added to the page, but something I noticed.

Fixed the active link thing https://github.com/open-sauced/hot/pull/127/commits/032c1bcabd6ad4ddb32f38848bcfbc4fa2a16b08
Going to open an issue for that safari thing.

I see a couple of things:

"load more" button appears before anything is loaded having text height
"load more" button also has text height if it's the only element on row (items modulo 3)
the order being changed once "load more is pressed"

There are a couple of thoughts I have on history location switching with a new page, but this can be covered by the vite pre-render part of the issue - we can do it as part of a global hydration issue or part of this :D

"load more" button appears before anything is loaded having text height

This is fixed in https://github.com/open-sauced/hot/pull/127/commits/98caca1b87accaf41becc7ab46554bfcbe913731

"load more" button also has text height if it's the only element on row (items modulo 3)
the order being changed once "load more" is pressed

Both of these will get issues opened after I merge this.


Synonym Request for DPH5-related diphthamide-deficiency syndrome

Mondo term
MONDO:0100503 DPH5-related diphthamide-deficiency syndrome
Synonyms
MONDO:0859295 neurodevelopmental disorder with short stature, prominent forehead, and feeding difficulties
Synonym type
None
Additional comments
CC @ErinRiggs
MONDO:0859295 neurodevelopmental disorder with short stature, prominent forehead, and feeding difficulties is the OMIM term that goes along with this existing MONDO term and we would like the two to be linked.

Hi - Just checking in on the status of this one. Could you provide a status update?
Let me know if you have any other questions!
Julia


Model file status report as an operation on the state store interface

Background
We'd like to make some changes to how compactions work to avoid the need for separate splitting compactions:

https://github.com/gchq/sleeper/issues/966

Description
We'd like to define a new method signature for the state store which can handle producing a file status report as a single operation. We want this to make it easier and clearer to see what needs to change to remove splitting compactions.
Analysis
We can update tests to assert on the file information report, rather than using current methods to list active files.
We may want to split out a separate issue to integrate this new interface into the client module.
We may want to update the DynamoDB implementation to use the new model, or we could delegate to the existing methods and map to the new model.

Closing as this is not needed for now.


Feature request: Allow entity-filter not states

Plz. allow define negated states.

type: entity-filter
entities:

device_tracker.demo_paulus
device_tracker.demo_anne_therese
device_tracker.demo_home_boy
state_filter:
! home

duplicate of #177


make change to artifact command, let it match what the task produced.

Hi @TingluoHuang, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Tingluo Huang). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Should we update some versions somewhere? This will require the newer version of vso-agent-tasks to work right, yes?


Grafana HTTP API not loading Alerts/Annotations correctly

Good morning, I'm having some issue displaying all my Grafana alerts/annotations correctly with the Grafana HTTP API data source.
I've installed it and connected it with my token correctly, and in fact some of the panel (the two showing the infos/health status) work correctly, but the Annotations panel doesn't seems to be working and give me the following error:

What could be possibly causing this error?
Grafana HTTP API version: 1.2.0
Grafana version: 9.3.8
Main Data-source: Prometheus

Thanks a lot!

@centenico Are you using Unified Alerting? Do you use a token with Viewer, Editor, or Admin permissions?
The Alert rules endpoint is used to get an Alert UID. If it's not found, then it's not a unified alerting or permissions issue.
I will take a look to see which one is it and will handle it.

Hi @mikhail-vl thanks for answering, I'm using a token with Editor permissions, but I've also tried with Admin.
I think that yes, I'm using Unified Alerting but I'll leave you a bunch of screenshots and configurations to give you the most possible informations about my system/alert setup. Hope that'll be useful.
I've also tried logging the alerts via one apachEcharts with the following line:
console.log(data.annotations);
which returns an empty array.

We're using prometheus as a datasource for our data.
Prometheus datasource has a setting for Alerting "Manage alerts via Alerting UI" which is enabled.
I've tried generating alerts with and without an Alert ID (with a random number)
The AlertManager in the Alerting -> Admin configuration is set and locked to "Grafana"
I've tried enabling the "Internal and External" setting in "Send alerts to" configuration

@mikhail-vl Hi, I've partly solved my issue, as I was having an older version of Grafana, which was missing some APIs, now the panels doens't give me error anymore, although I am still not seeing my alerts listed.

@centenico Thank you for confirming, then it makes sense to handle the not found error for the older versions.

@centenico I Appreciate the help. I added Exception Handling for the Alert Rules to support older versions of Grafana and removed Admin/Editor restrictions to retrieve Annotations.
Now Viewer permissions are enough, but you won't see the Alert name or UID.
You can download the latest CI artifact to test before the official build: https://github.com/VolkovLabs/volkovlabs-grapi-datasource/actions/workflows/ci.yml


Make Events fully fakable so file transfers can be tested

As it stands, the major problem here is that fake events (e.g., MouseEvents) being dispatched to elements in tests cannot be fully populated with fake Files, FileLists, and DataTransfers. Using mocks fails because dispatching these events involves native code that expects real objects.
Is it possible to make it so that fully fakeable (or mockable) events can be dispatched to elements for testing?

I think the answer is no, it's not possible. Unless we have an approach, closing.


PDF: Many small fixes for consistency and clarity.

Some of these changes are a result of discussions on our school's Discord channel.
I was not able to compile the PDF (requires files from a resources folder which is not in the repo), so I left out a few changes that could significantly change the look of the PDF. The only changes here are plaintext.

Thank you for the pull request. There are a few issues regarding tab/space words choice. Indent is always done with tabulation, not space. I'll review the parts where it stands out.


Upgrade docs has issue - Causing envoy to be deployed twice

Is there an existing issue for this?

[x] I have searched the existing issues

Version
equal or higher than v1.16.3 and lower than v1.17.0
What happened?
A bug happened!
https://github.com/cilium/cilium/blob/v1.16.4/Documentation/operations/upgrade.rst
At the preflight section, there should be mention that starting 1.16, we need to have --set envoy.enabled=false , whta happened is as I use fleet so it was detecting two charts for one ds envoy
How can we reproduce the issue?
This is flro all upgrades starting 1.16
Cilium Version
1.16.4
Kernel Version
5.10
Kubernetes Version
1.30
Regression
No response
Sysdump
No response
Relevant log output

Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

@Mais316, I'm not sure what you mean.
Starting in Cilium v1.16, Cilium now defaults to installing Envoy as a Daemonset rather than running inside the pod, so upgrading should work fine in the normal case.
I'm not sure how fleet works but maybe there's a conflict between your Fleet config having an Envoy Daemonset and Cilium now wanting to start one?
We can't blanket advise people to set envoy.enabled=false, since we believe that having Envoy deployed as a Daemonset is a better deployment model.
Are you deploying your own Envoy into kube-system, or are you using Cilium's Envoy?

I mean in preflight step there is to install cilium again with preflight

From: Nick Young @.>
Sent: Monday, November 25, 2024 6:13:16 AM
To: cilium/cilium @.>
Cc: Waly, Mai (FT FDS IDE ITS XCR) @.>; Mention @.>
Subject: Re: [cilium/cilium] Upgrade docs has issue - Causing envoy to be deployed twice (Issue #36130)
@Mais316https://github.com/Mais316, I'm not sure what you mean.
Starting in Cilium v1.16, Cilium now defaults to installing Envoy as a Daemonset rather than running inside the pod, so upgrading should work fine in the normal case.
I'm not sure how fleet works but maybe there's a conflict between your Fleet config having an Envoy Daemonset and Cilium now wanting to start one?
We can't blanket advise people to set envoy.enabled=false, since we believe that having Envoy deployed as a Daemonset is a better deployment model.
Are you deploying your own Envoy into kube-system, or are you using Cilium's Envoy?
—
Reply to this email directly, view it on GitHubhttps://github.com/cilium/cilium/issues/36130#issuecomment-2496701206, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB7O2ZFHBUKP5NE4PJJEGF32CKPVZAVCNFSM6AAAAABSMDWWLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWG4YDCMRQGY.
You are receiving this because you were mentioned.Message ID: @.***>

To explain more, if u have cilium 1.15 installed and you plan to upgrade to 1.16 docs say only install preflight in another chart and disable agent and operator so it didn't mention disable envoy as well.
Envoy is already running with existing installations 1.15 but to move to 1.16 we need to have preflight setup.

From: Waly, Mai (FT FDS IDE ITS XCR) @.>
Sent: Monday, November 25, 2024 8:29:49 AM
To: cilium/cilium @.>; cilium/cilium @.>
Cc: Mention @.>
Subject: Re: [cilium/cilium] Upgrade docs has issue - Causing envoy to be deployed twice (Issue #36130)
I mean in preflight step there is to install cilium again with preflight

From: Nick Young @.>
Sent: Monday, November 25, 2024 6:13:16 AM
To: cilium/cilium @.>
Cc: Waly, Mai (FT FDS IDE ITS XCR) @.>; Mention @.>
Subject: Re: [cilium/cilium] Upgrade docs has issue - Causing envoy to be deployed twice (Issue #36130)
@Mais316https://github.com/Mais316, I'm not sure what you mean.
Starting in Cilium v1.16, Cilium now defaults to installing Envoy as a Daemonset rather than running inside the pod, so upgrading should work fine in the normal case.
I'm not sure how fleet works but maybe there's a conflict between your Fleet config having an Envoy Daemonset and Cilium now wanting to start one?
We can't blanket advise people to set envoy.enabled=false, since we believe that having Envoy deployed as a Daemonset is a better deployment model.
Are you deploying your own Envoy into kube-system, or are you using Cilium's Envoy?
—
Reply to this email directly, view it on GitHubhttps://github.com/cilium/cilium/issues/36130#issuecomment-2496701206, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB7O2ZFHBUKP5NE4PJJEGF32CKPVZAVCNFSM6AAAAABSMDWWLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJWG4YDCMRQGY.
You are receiving this because you were mentioned.Message ID: @.***>

https://github.com/cilium/cilium/blob/v1.16.4/Documentation/operations/upgrade.rst#running-pre-flight-check-required


Fix/94 datatypes complete

Co-authored by: mariesig<EMAIL_ADDRESS>Co-authored by: yzchyx<EMAIL_ADDRESS>

Already included in other pull request


Updating/work-with this template for GHA feature.

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

We are updating this template to support new features in Github Action.
For the Github Action feature: We will remove two lines of code on container image and add GHA code after checkout step in the .github/workflow/azure-dev.yml file. (Shown as below)

@rajeshkamal5050 , @pamelafox for notification.

This repo does not contain the crossed out code, and though I don't completely understand the purpose of this change, it appears to make azd available in GitHub actions, and if that's the case, it appears that this repo doesn't need azd in its steps section. So, I'm going to close this. If you feel this is in error, please submit a PR to help me understand exactly what needs to happen here. Thank you.


KeyError: 'last_filebackup_issues'

Just set up UrBackup as well as the ngosang/urbackup-exporter at a new site, but got the following error.
2023-10-01 15:21:55 INFO     Starting UrBackup Prometheus Exporter ...
Traceback (most recent call last):
  File "/urbackup-exporter.py", line 185, in <module>
    prometheus_client.core.REGISTRY.register(UrBackupCollector(
  File "/usr/local/lib/python3.11/site-packages/prometheus_client/registry.py", line 40, in register
    names = self._get_names(collector)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/prometheus_client/registry.py", line 80, in _get_names
    for metric in desc_func():
  File "/urbackup-exporter.py", line 96, in collect
    self.float_or_default(client["last_filebackup_issues"], 0.0))
                          ~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'last_filebackup_issues'

What is last_filebackup_issues? It sounds like the UrBackup REST API doesn't return this particular attribute for some reasons.
I'm on v2.5.31 server, with exporter v1.1.3 in k8s.
I've been using 2.3.x in another site for years without issue.

The last release was tested with UrBackup server 2.4.13. Probably they removed that attribute from the API in newer versions.
I moved to Restic backup and I'm not maintaining this repository anymore. If you want, you can open a PR to fix the issue but make sure it's blackguards compatible. Thank you!

Ok no problem thanks for letting us know.
I'll give this a go.

@wywywywy https://github.com/ngosang/urbackup-exporter/releases/tag/1.2.0


MacOS refresh bug

Several MacOS users reported that widgets often do not refresh, and they need to re-focus the window before a change is shown. It appears to be a Qt for Mac bug, and a possible workaround is to call repaint() on the widget.
Need to test it on a recent Mac.

Same problem here. MacOS10.15.2


node stuck when K8s Operator Test restart node

after pod restart
│ Events:                                                                                │
│   Type     Reason       Age                   From               Message                                                                                │
│   ----     ------       ----                  ----               -------                                                                                │
│   Normal   Scheduled    16m                   default-scheduler  Successfully assigned cita/test-chain-overlord-node4-0 to k8s120-wn120-252-lb                                                                                │
│   Warning  FailedMount  11m (x2 over 14m)     kubelet            Unable to attach or mount volumes: unmounted volumes=[datadir], unattached volumes=[node-localtime kube-api-access-wr45l datadir node-config node-account]: timed out waiting for the  │
│ condition                                                                                │
│   Warning  FailedMount  5m5s (x3 over 9m40s)  kubelet            Unable to attach or mount volumes: unmounted volumes=[datadir], unattached volumes=[datadir node-config node-account node-localtime kube-api-access-wr45l]: timed out waiting for the  │
│ condition                                                                                │
│   Warning  FailedMount  2m47s                 kubelet            Unable to attach or mount volumes: unmounted volumes=[datadir], unattached volumes=[kube-api-access-wr45l datadir node-config node-account node-localtime]: timed out waiting for the  │
│ condition                                                                                │
│   Warning  FailedMount  32s                   kubelet            Unable to attach or mount volumes: unmounted volumes=[datadir], unattached volumes=[node-config node-account node-localtime kube-api-access-wr45l datadir]: timed out waiting for the  │
│ condition

related k8s issue: https://github.com/kubernetes/kubernetes/issues/110158
one way to fix: configure fsGroupChangePolicy.

We'll try to configure fsGroupChangePolicy directly in integration-test.
If it work, then we will finally fix it in cloud-config.

it doesn't work.
Maybe it's a env bug.


Create dump() for BLEScanResults

When we perform a BLE Scan to find devices in range, we get back an object called BLEScanResults() which is a holder for found BLE devices.  We can iterate over the content.  However, what keeps coming up is the idea that we simply want to dump() the contents to the console.  A new method called dump() has been added to BLEScanResults to dump the found devices to the log.

I am trying to call dump(), any example besides getCount()?
I tried the following:
void setup() {
  Serial.begin(115200);
  Serial.println("Scanning...");

  BLEDevice::init("");
  BLEScan* pBLEScan = BLEDevice::getScan(); //create new scan
  pBLEScan->setAdvertisedDeviceCallbacks(new MyAdvertisedDeviceCallbacks());
  pBLEScan->setActiveScan(true); //active scan uses more power, but get results faster
  BLEScanResults foundDevices = pBLEScan->start(scanTime);
  Serial.println("Dumping: ");
  Serial.println(foundDevices.dump());
  Serial.println("Scan done!");
}

But it does not compile.

When you run your code you should get this code running after foundDevices.dump():
https://github.com/nkolban/esp32-snippets/blob/master/cpp_utils/BLEAdvertisedDevice.cpp#L490-L508


Reviews

Primary Changes:

Built single review component
Updated redux store to include a singleProductReviews field
Edited single product component so it fetches reviews upon mounting and renders list of reviews
Wrote api routes for reviews
Updated Review model to include a title (updated seed file to match)

Other Changes:

Updated prettier version so VSCode would stop yelling at me about out of date version
Changes all products component links to fix /products/products bug

👍🏻


draft output should go completely to stdout

At least to me it does make no sense that the header goes to stderr and the rest to stdout.

Codecov Report

Merging #93 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage    90.3%   90.28%   -0.03%
==========================================
  Files          12       12
  Lines         454      453       -1
  Branches       56       56
==========================================
- Hits          410      409       -1
  Misses         27       27
  Partials       17       17

Impacted Files
Coverage Δ

src/towncrier/__init__.py
88.33% <100%> (-0.2%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6fc19...eb0b441. Read the comment docs.

Thanks @michaeljoseph - added the missing newline.

The test failures look like tox 😤 travis miscommunications 👊
So 👍 from me.

Travis removed pypy and python3.3. But this seems fine, thanks! The original idea was that the draft could be piped out, but I don't think many people would want to do that...


Admin panel available to students

I believe non-staff members are able to access the admin panel.
I think we should keep admin panel folks to just staff members. Shouldn't be a difficult fix if anyone wants to pick this up.

nvm it should be fine


Feature/con 428

add -x spotlessJavaCheck to skip code format check

Is it possible to alter the commit to add the files changed by spotless?


Unit 8 - part 1 - Hands on Lab

Hi. I'm running unit 8 part 1 in my colab and get some errors. It seems some lines of code regarding parsing the arguments are missing. I added them manually, but I kept getting the error. Can any one please help me?

Point: these are the two cells on either side of cell containing the definition of  the function "package_to_hub" in case you are wondering where they are coming from in the notebook file.

Hi, I believe the issue arises because the kernel doesn't recognize some arguments. I went through the same issues and found a way out of them by making the following modification:
args = parser.parse_args()
args.batch_size = int(args.num_envs * args.num_steps)
    args.minibatch_size = int(args.batch_size // args.num_minibatches)
    # fmt: on
    return args

with
args, unknown = parser.parse_known_args()
args.batch_size = int(args.num_envs * args.num_steps)
    args.minibatch_size = int(args.batch_size // args.num_minibatches)
    # fmt: on
    return args


Support to set the generateName workflow from WorkflowEventBinding

Summary
As I mentioned in the title. I wish the workflow name could be more readable.
Use Cases
I'm using WorkflowEventBinding to trigger the Workflowing runing when there is a pull-request was created. The event manifest looks like:
apiVersion: argoproj.io/v1alpha1
kind: WorkflowEventBinding
metadata:
  name: my-project
  namespace: default
spec:
  event:
    selector: payload.event_type == "merge_request" && payload.project.name == "my-project" && payload.object_attributes.state == "opened"
  submit:
    workflowTemplateRef:
      name: my-project
    metadata:
      generateName: my-project-{{payload.object_attributes.iid}}
    arguments:
      parameters:
      - name: branch
        valueFrom:
          event: payload.object_attributes.source_branch
      - name: pr
        valueFrom:
          event: payload.object_attributes.iid

I found out the controller just discard generateName. So all the workflows name look like my-project-7kc37.
I perfer the name to be my-project-pr-123. A simple solution is to add this feature in here. I'd like to do it if someone believes it's suitable.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@LinuxSuRen  Do you like to contribute to the feature?  you just need to implement the below place to support this feature.
Event binding needs to substitute {{}} value based on payload and  here  and assign to name.

hi @sarabala1979 sure. I'm going to take this. Please feel to assign to me.


Fetch PFS list from ServiceRegistry

Fix #253

config.pfs can be 3 values:

undefined, currently the default, enables fetching pfs list from service registry
null, disable PFS if one isn't specified explicitly in findRoutes or transfer options
a string, which will be used as pfs URL to be used

on the pfs list fetching, ServiceRegistry is monitored, and one can use Raiden.findPFS public API to fetch a list of available PFSs

in this case, the selected PFS can be passed to findRoutes, and this PFS will be used by findRoutes
if not specified, findRoutes will fetch, sort & select automatically a PFS from the registry

Notice that, currently, only the paid PFSs are registered on-chain, and we don't support paying PFS yet (#254), so findRoutes will fail when the PFS request fails due to the lack of an IOU. Workaround is to set the free PFS explicity with raiden.updateConfig({ pfs: 'free-pfs' }), if not set yet, on console.

Good job

@nephix My guess would be that if there is no newer RC or release version than the one we were using during testing then it wouldn't make sense to upgrade the contracts.

@andrevmatos can you create a follow up issue or pull request that addresses the feedback, if needed?


Flaky test: //test/extensions/quic_listeners/quiche/integration:quic_http_integration_test

https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/68704/logs/212
//test/extensions/quic_listeners/quiche/integration:quic_http_integration_test failed with a timeout on TSAN on my PR with unrelated changes.

Ah I just meant that the test failed due to a timeout, not a test failure.

The test is already sharded. I'll increase test_size to give it longer time.


Fix: Keysight_34465A overload value 9.9e37 to be np.nan instead

In case the DMM tries to measure the voltage value outside the its range, it overloads and throws 9.9e37 instead of throwing an error. Here we substitute this number with np.nan.
Side note: The error query does not throw any error even though the instrument display shows in bold that instrument is overloaded.

[x] Test on the instrument

To reproduce the error:

TEST RESULTS ON INSTRUMENT
Single datapoint:

Multiple datapoint

@jenshnielsen @astafan8

thanks @lakhotiaharshit
Does this work if you read out a buffer with multiple datapoints?

What happens with negative voltages. Is that even supported. Does it return a negative value?

thanks @lakhotiaharshit
Does this work if you read out a buffer with multiple datapoints?

Yes, I think I have fixed that part in the code. I am also planning to test it on the actual instrument in the evening to have the final confirmation. Do not know about the negative voltage though.

What happens with negative voltages. Is that even supported. Does it return a negative value?

Yes, fixed the PR to support negative voltage overload also.

So the question that I didn't really raise but is relevant when you consider positive and negative values is. Should this not return +- inf rather than nan ?

Looks great but something seems to be up with the tests.

Looks great but something seems to be up with the tests.

Individually all tests are running fine however when we run together all the test after the test below are failing. I do not know the reason at the moment.

@pytest.mark.parametrize("val_volt", ['10, 9.9e37, -9.9e37'])
def test_get_timetrace(driver_volt):
driver_volt.timetrace_npts(3)
voltage = driver_volt.timetrace.get()

assert (voltage == np.array([10.0, np.inf, -np.inf])).all()

Following Mikhail's nice suggestion. I have ignored that particular test at the moment. The is marked not to run and a small reason is added. I will open a new card in qcodes debt so that at later point we can fix that test.


kernel: sem: Ensure that initial count is lesser or equal than limit

Ensure this value during static initialization (with build assertions),
and dynamic initializations through system calls.
If initial count is larger than the limit, it's possible for the count
to wraparound, causing locking issues.
Signed-off-by: Leandro Pereira<EMAIL_ADDRESS>

Codecov Report

Merging #6976 into master will increase coverage by 1.52%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6976      +/-   ##
==========================================
+ Coverage   55.63%   57.15%   +1.52%
==========================================
  Files         462      383      -79
  Lines       44567    28036   -16531
  Branches     8296     5079    -3217
==========================================
- Hits        24794    16025    -8769
+ Misses      16381    10095    -6286
+ Partials     3392     1916    -1476

Impacted Files
Coverage Δ

include/kernel.h
98.11% <ø> (+3.37%)
:arrow_up:

kernel/sem.c
92.3% <0%> (-1.81%)
:arrow_down:

subsys/net/ip/nbr.c
0% <0%> (-91.67%)
:arrow_down:

subsys/net/ip/utils.c
12.2% <0%> (-67.39%)
:arrow_down:

include/net/net_context.h
51.16% <0%> (-41.87%)
:arrow_down:

subsys/net/ip/tcp.h
9.09% <0%> (-40.91%)
:arrow_down:

subsys/net/ip/l2/ethernet.c
5.49% <0%> (-37.22%)
:arrow_down:

subsys/net/ip/connection.c
34.44% <0%> (-34.99%)
:arrow_down:

include/net/ethernet.h
0% <0%> (-33.34%)
:arrow_down:

subsys/net/ip/net_pkt.c
19.09% <0%> (-29.66%)
:arrow_down:

... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f6fc9...2fdfa20. Read the comment docs.

recheck

BUILD_ASSERT() seems to be quite broken -- fixed some of it in this PR, but happy to split.

Found a way to workaround the seemingly spurious warning that GCC was generating.  Force-pushed to test in CI.


docs: add note for index.php change

Description
I saw a YouTube video that a dev had moved index.php to the project root.
Also this description is on the README file, but not in the User Guide upgrading section.
aChecklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[x] User guide updated
[] Conforms to style guide

Updated the description to add a link to another page.


Update README.md

Pull Request Test Coverage Report for Build 950149162

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.526%

Totals

Change from base Build 950140352:
0.0%

Covered Lines:
1758

Relevant Lines:
1900

💛  - Coveralls

Pull Request Test Coverage Report for Build 950167103
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.526%

Totals

Change from base Build 950140352:
0.0%

Covered Lines:
1758

Relevant Lines:
1900

💛  - Coveralls


Running 'rake assets:precompile' in dev mode makes Rails include Highchart code twice (Uncaught Highcharts error #16)

I had problem with the error Uncaught Highcharts error #16 saying that Hightcharts was loaded twice.
I did not understand as I followed recommended settings in Highcharts-rails ReadMe.
My application is using Rails 3.2.21.
More explanation about my debug can be found here.
Finally, I found that there is a bug in rails when you do a rake assets:precompile that would lead to include twice the Javascript code from app/assets and public/assets.
This bug is referenced here since april 2013, but the rails community don't seem to be willing to correct it.
As workaround I just :

run rake assets:clean
add the line //= require highcharts to app/assets/javascripts/application.js
run rake assets:precompile
deleted the line //= require highcharts from  app/assets/javascripts/application.js

So Highchart library is precompiled in assets pipeline from the public/assets.
Its a bit weird, but it works... in development...
I still have to test it in production to confirm that it continues to work.
Maybe it would be a good idea to warn in the Highcharts-rails ReadMe file that including Highcharts in the app/assets/javascript/application.js file could potentialy lead to the error #16 ?

@bluebird-communication is this still a problem? It's quite old, so I'm guessing (hoping) something probably changed, either in Rails or in Highcharts that makes this disappear


Preserving point count when snapping clsutered spatial units?

I have a large dataset with 300,000 observations representing points located at various locations on a network. To improve efficiency, I grouped or clustered these points into about 300 spatial units then U used network.snapobservations to snap these new observations to the network.
Now, I want to analyze the spatial patterns of these new spatial units using the network.Moran function. However, I still want to consider the original count of points (300,000) when performing the analysis.
Is there a way to achieve this, i.e., snap the new spatial units to the network while preserving the information about the original 300,000 points, so I can use this information in the networkMoran function?

Hi, @adhamenaya. Unfortunately, there is no way to perform this. All observations should be taking into consideration at one time.

@jGaboardi thank you for your reply. Any recommendations to optimize the use of the network.snapobservations for such large datasets?

@adhamenaya Sorry for not getting back to you sooner. Within spaghetti, I don't have any recommendations. However, @knaaptime Might have some insight on if this might be possible with a PySAL adjacent project: geosnap?


BaseDecorator maintains == with a decorated ActiveRecord model

Closes #377

Dear Code Climate:
If this PR's diff coverage is 100%, then why do you think that the total coverage went down by 0.1%?
Regards,
Schenkleberry


Allow editing of DMP file field by secretary

It's currently missing

My suggestion:

On the review info details page, the secretary can change the files associated with a certain proposal.
Note that this is an updateview for Documents objects
Note that each trajectory gets its own Documents object
Note that the DMP is in fact not a part of the Documents object, but a Proposal field
** This means we can't edit the DMP on the current edit documents page
Create a new updateview, only accessible for the secretary, which can change a proposal's DMP file field
Add a link (for secretary users only) to the updateview for DMP on the Review detail page
Note that the sidebar is rendered through a template tag


Theme support and additional options

Support themes (dark, light)
Support footer (author, title, page number)
Additional flags:

--new-page-on-hr: Interpret HR as a new page; useful for presentations
--page-size: [A3 | A4 | A5] (default "A4")
--orientation: [portrait | landscape] (default "portrait")

Added Colorlookup() helper which translates common colour strings ("blue", "green", "red", etc) to RGBs
Support processing input from URL
When processing from a URL, adjust relative links and image paths
Support Unicode encoding and custom font previously done in russian.go in convert.go

Please see full usage example here: https://github.com/jessp01/mdtopdf/tree/theme-support#additional-options
PS
Eliminating the need for russian.go also means we'll now be able to install convert.go thusly:
$ go install github.com/mandolyte/mdtopdf/cmd@latest

At the moment, an attempt to do so yields:
../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/russian.go:13:5: input redeclared in this block
	../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/convert.go:13:5: other declaration of input
../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/russian.go:14:5: output redeclared in this block
	../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/convert.go:14:5: other declaration of output
../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/russian.go:15:5: help redeclared in this block
	../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/convert.go:16:5: other declaration of help
../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/russian.go:17:6: main redeclared in this block
	../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/convert.go:18:6: other declaration of main
../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/russian.go:59:6: usage redeclared in this block
	../../go/pkg/mod/github.com/mandolyte/mdtopdf@v1.4.1/cmd/convert.go:73:6: other declaration of usage

I also think it would be good to change the name from convert.go to mdtopdf.go as it would mean one could conveniently run $GOBIN/mdtopdf after installing with go install github.com/mandolyte/mdtopdf/cmd@latest
Cheers,

For a quick review of the result:)
/home/jesse/tmp/mdtopdf-jesse/cmd/mdtopdf.pdf

For a quick review of the end result, here's the repo's MD, converted with:
$ go run convert.go  -i ../README.md -o mdtopdf.pdf --new-page-on-hr --with-footer  --title "MDtoPDF" --author "Cecil New" --theme dark --page-size A5

mdtopdf.pdf

@jessp01 I tried to duplicate the functionality of "russian.go", but it didn't work. Instead of the two Russian lines, it looks like garbled glyphs. I did a quick compare of your enhancement and the code in russian.go, but nothing popped out. Could you take a look at that?
I also noted that if I use the help flag, the double-hyphens are not shown for the new options that contain hyphens. I seem to recall that the flag package treats both single and double hyphens the same. So I think it is OK, but wanted to confirm that with you.
Thanks for this work!!

Hi @mandolyte ,
I just ran the below command (as added to the README) and it worked correctly (see attached PDF):
go run convert.go -i russian.md -o russian.pdf \
    --unicode-encoding cp1251 --font-file helvetica_1251.json --font-name Helvetica_1251

Can you please post the command you tried to use?
As to the flag package, indeed, it honours both notations (- and --) for any flag you specify.  I don't see it as a problem but it is unconventional, which I'm not crazy about either:)
For my own projects, I use github.com/urfave/cli which has a more comprehensive API and does allow you to specify both a short and long options. For example, see what I've done in my zaje project:
https://github.com/jessp01/zaje/blob/master/common_functions.go#L87
We can change the code to use this package instead but I wouldn't say it's very important.
What do you think about changing the name from convert.go to md2pdf.go (or mdtopdf if you prefer)? I think that is rather important as convert is a bit generic (it's also the name of the main ImageMagick binary, which can be confusing).
Cheers,

@jessp01 Thanks for checking on that. I had not included the unicode-encoding option. Once I did that, it worked fine.
Also, I'm OK with renaming the convert command -- good idea. So please go ahead and include that rename in this PR and update the README to explain how to install the command directly.
Thanks!

Hi @mandolyte ,
Change made. In order for go install github.com/mandolyte/mdtopdf/cmd@latest to work, you'll need to create a new release and set it as the latest.
I also added .pre-commit-config.yaml to the repo.
Cheers,


Issue with Multiple Tab open with one mobile view through chrome dev tools

We are getting an issue if mobile view of chrome dev tools is open than all other tabs open mobile site instead of Desktop site.
Is it known issue or do we have any fallback for that. Also it is with all approaches of sw-toolbox even with networkOnly also
global.toolbox.router.default = global.toolbox.networkOnly;

If you're aggressively caching and reusing content, I'd recommend using runtime logic, like CSS media queries, to adjust the display of your site, rather than having your web server return different responses for different types of clients.
Otherwise, if you need to have different responses for different types of clients, using a less aggressive caching policy would be your best bet, so that things just fall back to the cache and go network-first.
sw-toolbox won't cache anything by default, so if you're seeing content cached more aggressively than you expect, it must be due to your configuration. Please re-examine that.


Update citation.cff

We have some new regular contributors.  The CITATION.cff file needs a corresponding update.

Handled via #585


IP Cert Support

Supports issuing certs for IPs using IP:<ip> SAN, as suggested in #8
Ensures Ips aren't treated as wildcards
Improved testing to verify the SAN
Update CI for 3.7, drop 2.6 and 3.3

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4ede691). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master      #9   +/-   ##
========================================
  Coverage          ?   99.5%
========================================
  Files             ?       1
  Lines             ?     204
  Branches          ?      21
========================================
  Hits              ?     203
  Misses            ?       0
  Partials          ?       1

Impacted Files
Coverage Δ

certauth/certauth.py
99.5% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ede691...840c67c. Read the comment docs.


feat: allow "Script" dropdown control

A simple change to allow controlling the "Script" dropdown.
Example configs:
    "default": {
        "script_list": "None"
    },

    "SD Upscale": {
        "script_list": "SD upscale",
        "img2img_steps": 30,
        "img2img_denoising_strength": 0.2
    },

This does not work as you expect it to.
There is JavaScript tied to the scripts dropdown that expands/collapses the script HTML section. Simply selecting the value in the dropdown does not trigger the JavaScript. The same problem exists with the Hires fix checkbox, which required extra code to trigger. You can see this in config_presets.js: function config_preset_dropdown_change()
The same thing would need to be applied here if you want this functionality to work. But this also opens up the door to supporting the components within the scripts. Perhaps the suggestion you made in #34 would be a solution for that so all the components don't clog up the UI when creating a new preset. Basically make a new file that the user can edit for a custom list of component IDs, then show that in the config preset creation UI below the normal components. Would you like to try making that?

So dropdown boxes seem to work differently to checkboxes, and this change I'm proposing actually works without change the javascript. I've been testing it all day on both Firefox and Chrome.

I'm using Edge and changing the Script dropdown does not display the scripts body.

I tested in Edge and also another 2 computers, but didn't see the problem you're describing.
Anyway, I've updated the JS. But seeing as it doesn't happen on my end, can you give it a try please.

Doesn't work. Upon further inspection, I don't think this particular problem is solvable.
Each script body in the HTML does not have a unique selector that corresponds to the script dropdown values, so it's impossible to know which script body corresponds to which script dropdown value. Since we can't target the precise element we can't show it when appropriate.
The script bodies are in the same order they appear in the script dropdown, but this doesn't help either. I briefly looked into the nth-child() selector but that wouldn't work because other extensions, such as ControlNet and DynamicPrompts, inject their HTML here which would screw it up.

So they bumped the Gradio version up to 3.23 https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/4697def23516ee05fbbb01f8cf6d38e9f3b19dd5 on March 25 which changes how Gradio dropdowns work. One effect of this is that the dropdown values cannot be set via JavaScript anymore, but changing them via Python triggers any relevant events to be fired.
So today I added new functionality to add any custom elements with an ID in a separate config file. I'll upload it after done playtesting.


missing file: main_classifier_vae.py

The file main_classifier_vae.py is missing in the repo. Wondering if the author can kindly provide that as well. Thanks

Got it. Have provided main_classifier.py. Thanks.
Run it with the guidance in Only classifier in Cifar10 (4k) and Cifar100 (4k and 10k).


Prompt to install elemental-operator when CRDs don't exist

If the extension is installed before the elemental-operator, we should be able to see the lack of CRDs and prompt the user to install it.
This should be a one-click install to install the associated helm chart. Preferably, this helm chart is coming from registry.suse.com (once published there).

Will take a look at this once we are at a point where "one-click" install is possible. Thank you for bringing this up @agracey .
FYI @kwwii


Breaking change in v10: consecutive statements on a line must be separated by ';' or a newline

Reported here: https://github.com/bloodyowl/rescript-js/issues/19
[rescript] starting
Dependency on @rescript/react
Dependency on @ryyppy/rescript-promise
Dependency on rescript-js
rescript: [1/16] src/Js__Float.ast
FAILED: src/Js__Float.ast

  Syntax error!
  /foo/node_modules/rescript-js/src/Js__Float.res:35:76-82

  33 │ external fromInt: int => float = "%identity"
  34 │
  35 │ @unboxed @noalloc external mod: (float, float) => float = "caml_fmod_fl
     │ oat" "fmod"
  36 │

  consecutive statements on a line must be separated by ';' or a newline

rescript: [2/16] src/Js__BigInt.ast
FAILED: src/Js__BigInt.ast

  Syntax error!
  /foo/node_modules/rescript-js/src/Js__BigInt.res:28:55-61

  26 │ external div: (t, t) => t = "%divfloat"
  27 │
  28 │ @noalloc external mod: (t, t) => t = "caml_fmod_float" "fmod"
  29 │
  30 │ external land: (t, t) => t = "%andint"

  consecutive statements on a line must be separated by ';' or a newline

FAILED: cannot make progress due to previous errors.

Would you edit the release notes to report this?
That's CHANGELOG.md in the compiler repo.

@cristianoc I assume this is what triggers the error:
(...) t = "caml_fmod_float" "fmod"

I don't know what this syntax means in a binding. It was probably undocumented syntax. Maybe someone who better understands it can describe the change for the changelog?

Oh sorry.
This is already documented.
It's an external without attributes.
From the release notes:

Externals without @val annotations do not work anymore, and externals with = "" give an error.

Some thorough migration guide with examples will need to be written obviously.
For now, just listing all the known things, and it seems like this is known.

Closing optimistically.

@cristianoc The change was something else: a primitive was renamed. More info here: https://github.com/bloodyowl/rescript-js/issues/19#issuecomment-1193325927 and https://github.com/bloodyowl/rescript-js/issues/19#issuecomment-1193326281


No bower file with the property main

Hello, great library!!
I use yeoman, and I installed angular-barcode with:
bower install angular-barcode-es6 --save
When I run grunt serve, It crashes, and it is because there's no file bower.json with the important param:
"main": "dist/angular-barcode.js",
I created it manually, and my project works again, but when I have to make a
bower install to my project again, I will have to create the bower file again, and It's a problem.
Can you fix this please!!!
PD:
Write in your description the way to install with bower, that would be great.
Sorry my english.

Could you provide an example? I have a hard time figuring out your problem. I would also recommend to stop using bower and switch to NPM if possible.

I've create an empty folder and run bower install angular-barcode-es6 --save   and I even don't see the bower.json file. It has a .bower.js file with this content:
{   "name": "angular-barcode-es6",   "homepage": "https://github.com/isonet/angular-barcode",   "version": "2.0.0",   "_release": "2.0.0",   "_resolution": {     "type": "version",     "tag": "v2.0.0",     "commit": "8ed3e33ff3cdd0c8103427b5c6bc2a6284e56c6e"   },   "_source": "https://github.com/isonet/angular-barcode.git",   "_target": "^2.0.0",   "_originalSource": "angular-barcode-es6",   "_direct": true }
I can't use NPM. Gruntfile.js is configured to join the bower files and add them to the index.html file, but It can't do it if the component doesn't have a bower file and the property "main" with the path to the component itself. Can you add the bower.json file and key "main" please? Excuse my english.

I just published a new version and tried it out, it seems like it works now! Apparently I had an error in the bower.json file and was ignoring the dist folder which was referenced in the main property.
Please tell me if everything is working correctly. You will probably have to run bower update to get the latest version.

Wow, It works now. Thank you so much!!

Awesome :smile:


Patch cloudflare vuln GHSA-9763-4f94-gfch

Resolves issue: https://github.com/jfrog/jfrog-cli/issues/2434

[x] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
[x] The pull request is targeting the dev branch.
[x] The code has been validated to compile successfully by running go vet ./....
[x] The code has been formatted properly using go fmt ./....

I have read the CLA Document and I hereby sign the CLA


Brew tap ko1nksm/getoptions throws an Error

~
❯ brew tap ko1nksm/getoptions
Running `brew update --preinstall`...
[...]

==> Tapping ko1nksm/getoptions
Cloning into '/opt/homebrew/Library/Taps/ko1nksm/homebrew-getoptions'...
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 9 (delta 0), reused 5 (delta 0), pack-reused 0
Receiving objects: 100% (9/9), 4.36 KiB | 4.36 MiB/s, done.
Error: Invalid formula: /opt/homebrew/Library/Taps/ko1nksm/homebrew-getoptions/getoptions.rb
getoptions: Calling bottle :unneeded is disabled! There is no replacement.
Please report this issue to the ko1nksm/getoptions tap (not Homebrew/brew or Homebrew/core):
  /opt/homebrew/Library/Taps/ko1nksm/homebrew-getoptions/getoptions.rb:7

Error: Cannot tap ko1nksm/getoptions: invalid syntax in tap!

I forked your tap repo and removed the bottle :unneeded line and it works fine!

Thanks!
Fixed in https://github.com/ko1nksm/homebrew-getoptions/pull/1


Hook names are validated and info msgs outputted.

Added hookName validation.
Changed debug log msg to info to output the hooks that are written.
No need to add the SHEBANG if the script already starts with one.
Made NEW_LINE not system dependent.

Thanks for the contribution! Didn't even think about validating the hook name. I can also see a case for outputting the file write at INFO.
I'll throw out another release early next week. Thanks again!


WebMessage: alert users also by email

Originally on 2012-05-09
It would be useful if WebMessage could also send email notifications to users email addresses when they receive a new web message.

Changing the milestone as per https://github.com/inveniosoftware/invenio/pull/1874#issuecomment-71444117


Fix Null dereference

Returning NULL from sk_X509_value is possible if num_trusted is less than 0 or if one of the ctx->chain->data[i] values is NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
CLA: trivial

Agree trivial

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 123 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 154 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 185 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

Returning NULL from sk_X509_value is possible if num_trusted is less than 0 or if one of the ctx->chain->data[i] values is NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.

This is NOT possible. The num_untrusted value cannot be negative, and the chain never holds NULL elements. This PR is not needed, and should I think be closed.

Closing.
If there is a plausible scenario under which the chain being constructed might contain a NULL element (other than for just around the call to policy checks in lieu of a bare public key trust-anchor with DANE "2 1 0"), or a plausible way to have a negative second argument passed to check_trust(), please explain the sequence of events that leads to that scenario and reopen.


Add cert-manager origin tag in Venafi

What this PR does / why we need it:
Add an origin tag on Venafi certificate sign requests. This allows the Venafi software to recognize that the certificates are requested by cert-manager
Release note:

Venafi issuer: add origin tag to requests

/lgtm
/approve
/kind feature


Timesheet - 13/04/2020 - TRUYEN HOANG

Task 1

Update terraform script to support check log on cloudwatch - next is newrelic when we have account
Expose application via alb
Investigate current issue with ECS

Issues

Currently I apply fargate to run our application to saving cost and scale better but the network model is quite different with traditional EC2 instance. So right now service didn't pass the health check of alb. I believe could resolve that today.
Another issue that I meet is about migration of django. I tried to run  python manage.py migrate to migrate but might need some input or config also. I might need help from @ThaDeveloper about this. If migration doesn't work I will clone current dev database to new server

Proof of Work

https://github.com/thenewboston-developers/iac/commit/84db9807aec1717b79a314831b380aac01c8ed9c
https://us-west-2.console.aws.amazon.com/cloudwatch/home?region=us-west-2#logsV2:log-groups/log-group/$252Fecs$252Fbackend-dev

Time Spent
3 hours
Total Time Spent
3 hours
Account Number
5d52e2bb5acf296a120dc2a16efd46f6803c9a4f55cda44d6b1b6dd42d9f1a6d

Approved

Approved


Why does transformPoint take x,y params instead of a point?

I am using matrix.transformPoint. I noticed that the AS3 matrix class takes a Point as the param, and your class takes x,y. Any reason for this? I thought you were trying to follow the AS3 classes as close as possible.

EaselJS loosely followed Flash/AS3 patterns to begin with, however over time it has become its own library, and there is no mandate to keep it consistent.
The point parameter in transform point provides a way to reuse point objects, rather than creating new ones constantly.

@lannymcnie Thanks for the explanation. A sound design decision.