KAFKA-3849: Avoid polling every second in MirrorMaker if no data is available.

I am not super convinced on how valuable of an option this is, or why someone would use it. But I guess the option can't hurt.
Did you test MM after these changes? Based on visual inspection I had one small comment, otherwise it LGTM.

Yeah, I'm also a little puzzled why this is needed.

Hey Grant/ Jason, thanks for the quick review. If you have a pipeline where data arrives say every few minutes, polling every second seems to be extraneous. Having that said, increasing poll time is not going to save lots of CPU cycles, so it is up for debate if this is worth a new config or not. In old consumer one would have controlled this using consumer.timeout.ms and adding this config will allow users to set the poll time for new consumers as well.

@SinghAsDev Hey Ashish, to be honest, I'm not sure why we're using 1 second as the poll timeout. Would there be any downside to just increasing it? From a glance at the code, it seems like we catch the exception and retry anyway. Also, one iteration of the loop per second seems like it would have minimal impact on CPU.

@hachikuji increasing timeout seems to be reasonable. If someone is getting high speed data then they do not have worry about the timeout anyway. However, that again raises the question what is an optimal value for timeout, IMO it depends on incoming data speed. What do you think is a good default value?

I would probably use Long.MAX_VALUE. We break from poll() as soon as any data is available, so there's no obvious downside to blocking in poll() when there's nothing available. Unless maybe we depend on the timeouts to trigger some periodic behavior?

I do not see any behavior depending on ConsumerTimeoutException in MirrorMaker, it just gets trace logged. @becketqin would have any suggestion on this?

@hachikuji updated PR to instead increase poll time. Sanity tested the change.

@SinghAsDev LGTM. Would be nice to hear @becketqin's thoughts to make sure there weren't any good reasons to keep the timeout low.

I haven't seen a case or report why the current value could be or is problematic. What reason do we have to change it? Is there zero risk in changing it?
If my understanding is correct, increasing the timeout above the request timeout or metadata timeout just means that the looping will now move from MM to the while loop inside of the Consumer because of how the Network client poll works.
Because request.timeout.ms defaults to 30 seconds and metadata.max.age.ms defaults to 5 minutes. I think the longest we would be saving a CPU cycle is 30 seconds regardless of the poll timeout. I could be interpreting the code wrong though.

@granthenke this came up as a related question from customer. I think what we are comparing here is, poll every second even if no data is arriving, vs return when sufficient amount of data has arrived (which is configurable). Sure, it is not going to save significant amount of CPU and that is stated in previous comments. I agree that this change is not improving behavior of MM by a lot, and so if there is some risk associated with it, we should drop the change. However, I will be interested to know what risk you see with the suggested change.

Yeah, I'm a little doubtful of any real CPU impact. As Grant mentions, the consumer hides its own loop behind the poll API, and the frequency is bound basically by the heartbeat interval. That said, I tend to see polling with a large timeout as a better pattern, though this is largely my own preference. It would let us drop the hasNext() check on the following line, but it seems not too big of a deal either way.

I can be convinced either ways on this. Let's wait on @becketqin feedback as well, and we can close it accordingly.

Increasing the poll time to Long.MAX_VALUE would have impact on offset commit. Any uncommitted messages before entering poll(Long.MAX_VALUE) will not be committed until a new message arrives.  We actually breaks the contract of offset.commit.interval.ms

@xiaotao183 Great point. It seems we could either leave this as it is or we could use offset.commit.interval.ms as the timeout passed to poll(). It's probably also worth adding a comment in the code explaining the dependence so that we're not tempted to make the same change again in the future.

@xiaotao183 thanks for pointing it out. I agree with @hachikuji that we should add a comment in the code. Also, I am inclined towards using offset.commit.interval.ms as poll() timeout, which by default is a minute. Makes poll time configurable without adding a new config and does not have an infinite timeout. Does it sound reasonable to you @granthenke @hachikuji @xiaotao183 @becketqin ?

@SinghAsDev Sounds good to me.

I won't get in the way of this change going in, but I am still unconvinced.
Through extended discussion, we found that there would have been a negative impact for a change with near 0 positive impact (that I know of). Who is to say there is not another thing we are not seeing or thinking of? Since there is no real benefit what is the value of this change and risk?
I would love to see more Mirrormaker testing so that we can be confident in our changes. But as its stands today we have 2 ducktape tests (test_simple_end_to_end, test_bounce).

Actually I think changing the poll timeout to offset.commit.interval.ms is justifiable because of the same problem mentioned by @xiaotao183. If the user specifies 500ms, for example, then we won't actually be able to enforce it unless the poll timeout is any higher than that. Now, sub-second commit intervals are pretty unlikely in practice (I guess), but it still seems more appropriate to use the commit interval rather than a somewhat arbitrary hard-coded value. At the very least, we should add the comment to avoid making the same mistake again in the future.

The failed test, KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations seems unrelated. It passes locally. Did not find a JIRA for marking this as an unstable test, however I could not reproduce test failure locally, let me know if it still warrants a unstable test JIRA. @ijuma would you be able to review this one?

Yes, a JIRA for the unstable test would be appreciated. With regards to this change, I share some of Grant's concerns given the lack of existing MirrorMaker tests and the fact that the benefit seems a bit esoteric. Also, no test is included in this PR.
Any thoughts @becketqin?

The original issue, which I agree was not really causing any obvious
problem, led to uncovering of offset commits happening faster than
specified offset.commit.interval.ms. Though that is again not an obvious
issue, but certainly an unexpected behavior. Review from @becketqin will be
helpful. Also, on the tests side, I am trying to think how can this be
tested. Would appreciate any suggestion on that.

On Thu, Jun 23, 2016 at 1:08 PM, Ismael Juma<EMAIL_ADDRESS>wrote:

Yes, a JIRA for the unstable test would be appreciated. With regards to
this change, I share some of Grant's concerns given the lack of existing
MirrorMaker tests and the fact that the benefit seems a bit esoteric. Also,
no test is included in this PR.
Any thoughts @becketqin https://github.com/becketqin?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/kafka/pull/1515#issuecomment-228168245, or mute
the thread
https://github.com/notifications/unsubscribe/AEsBZUUBWIdKKj_xOMGA1VR6Q48TVFJzks5qOue1gaJpZM4I3vKt
.

--
Regards,
Ashish

Would have been better if the JIRA spelled out an actual problem. I'm OK leaving it as it is or using the offset commit interval for the poll timeout (which seems intuitive and low-risk). At the very least, it would be nice to have the comments which clarify why the poll interval must be small since it is not obvious just looking over the code.

@SinghAsDev Offset commits don't happen faster than specified as far as I can see. The potential issue is if you set the offset.commit.interval.ms to be lower than 1 second (the hardcoded poll timeout), then the offset commit may not happen within the time you specify if poll ends up waiting for 1 second because no messages have been received (for example). Of course, this only matters if there are uncommitted messages since the previous poll, which again needs a specific sequence of events (a poll that takes less time than the offset.commit.interval.ms so that the messages returned are not immediately committed).
Am I missing something?

@hachikuji, I agree that we should include the comment no matter what.

@ijuma my bad, you are right. If you folks think using offset.commit.interval.ms is very risky then I will be fine with just adding an explanation on why the hard coded value.

Updated PR and Issue title to just add explanation on why hard coded value is used. We can take up the issue of using offset.commit.interval.ms as poll timeout when and if we see any issue related with it.

LGTM, merged to trunk.


Removed ConfigurationOf

Coverage remained the same at 97.758% when pulling e20c1634fab4ae793c695a6a181365e3efa7131c on baseline_update into 671b1afa6a27347759c3a8408688d126255788d7 on master.


Add new capability to add custom claims

This PR will fix #162 and add a new capability to add custom claims. At the moment, the changes are tested with one tenant, but should work with more than one tenant as well.
@Yvand Could you have a look at the changes, if there is any thing that could break other parts of the solution? Thanks!

Just to note, there is still an issue within the regular people picker within a site. It shows a different number of results (visible vs. count). I'll have a look at this.

@andikrueger thank you very much for your contribution, I will take a close look and keep you posted

At the moment, we do one further issues: Group Claims will not be available in CA; In all other webapps they are there.

@andikrueger in some places only users are accepted, e.g. in site collection administrators page you can add only users.
Does it match what you noticed?

Actually yes. So this is not a bug.

@andikrueger before reviewing your PR I had totally no idea about the extension attributes feature, but it's actually a nice feature in Azure AD, and the integration in AzureCP is much easier than I feared.
Today I tested this feature on my tenant, next week I'll review in depth the PR itself and come back to you

Let me know, if you need any assistance!

@andikrueger I spent some time on this today, so far it looks great, but there is 1 thing I was not able to do:
I configured my enterprise app to issue a claim with value user.extensionattribute1, but after sign-in as a user that this extension attribute set, this claim is missing in the SAML token.
Did you try with a SAML or an ID token ?

We did some testing in regards to SAML tokens and I did not get any negative feedback. Did you configure your claims here:

Yes I think I have the proper config:

For the test I added well-known email claim type with the same value, but both claims email/type1 are missing in the token. It is possible I'm doing a dumb mistake, I think I'll wait tomorrow to take a fresh look at this :)
I keep you posted

I must be missing something.
My user has extensionAttribute1 set:
{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v1.0/$metadata#users(id,displayName,userPrincipalName,extension_db1e6850023e4d439ebc39871218d32e_extensionAttribute1)/$entity",
    "displayName": "Pradeep Gupta",
    "userPrincipalName"<EMAIL_ADDRESS>    "extension_db1e6850023e4d439ebc39871218d32e_extensionAttribute1": "value1"
}

I use this extensionAttribute1 in my app:

And yet the claims are not included in the token.
If I change the claim type settings to issue attribute user.mail or user.userprincipalname instead, then it is included as expected in the SAML token. What am I missing?

Did you configure this claim within the trusted token issuer as well?

@andikrueger I think I understand the issue:
I created a specific app registration to create my extension attribute.
Based on this doc, to use this extension attribute in another app (my enterprise app for SPS SAML), I need to create a claims mapping policy.
But I have no idea how to do that for a SAML token.
What app identity did you use to create your extension attribute?

@julmsy do you remember, what kind of additional steps we did?
I used the AzureCP app to register the extension attributes. In our default environment the extensions are created by AD connect.

Just noticed, but there is a double '/' in the path your Claim type.
http://schemas.yvand.org//claims/type1
This could be an issue if the Claim Type is not EXACTLY what is expected.
The Claim type must also be configured on the SPTrustedIdentityTokenIssuer object, otherwise it is not present in the Token.
Other than that, nothing really special in term of configuration:

Created the Enterprise App on Azure AD
Configured the SAML sign-on method
Configuration on SharePoint to switch from ADFS to AAD
Configuration of AzureCP solution (could be linked with the App Registration created by the Enterprise App, or a dedicated App Registration, I've tested both scenarios).

So this turned out to be very much more complicated than I anticipated. In short:

Create a dedicated app registration; and use its ID to add an extension attribute:
https://graph.microsoft.com/v1.0/applications/{{applicationObjectId}}/extensionProperties

Create a claimsMappingPolicy that list all the claims that will be added to the SAML token:
https://graph.microsoft.com/v1.0/policies/claimsMappingPolicies

Assign that claimsMappingPolicy to the SharePoint enterprise application:
https://graph.microsoft.com/v1.0/servicePrincipals(appId='{appId}')/claimsMappingPolicies/$ref

Steps 2 and 3 are somewhat explained in this article, but it is omitting a lot of information I had to dig in myself.
Also, none of these steps can be done from the AAD portal, I did everything using Postman.
@andikrueger, I'm pretty sure that your extension attribute is not included in the SAML token created by Azure AD, since the screenshot you copied has no effect on extension attributes (which is very confusing since the UI lets you think that everything is alright)

Good find and thank you for outlining. We did not need to configure anything additionally as we used the AD Connect extension Attributes for testing:

Once a directory extension attribute created via AD Connect is in the directory, it will show in the SAML SSO claims configuration UI.

https://learn.microsoft.com/en-us/azure/active-directory/develop/active-directory-schema-extensions#emitting-claims-with-data-from-directory-extension-attributes-created-with-ad-connect
This obviously only applies to AD connect and not any other application.

@andikrueger indeed, you mentioned it earlier but I missed that point, thanks!

@andikrueger I tested it on my dev env and it works great.
1 remark regarding the name of variable ADConnectClientId:
It totally makes sense in your scenario, but it needs to be meaningful also for the scenario where Azure AD Connect is not used (which is how I tested extension attributes), so we need to rename it.
I though about ExtensionAttributesApplicationId.
Thoughts ?

The name of the new attribute should not matter. There is just one minor thing I'd like to point out. If we would go for any other naming, this might imply that there would be the option to have multiple applications within the same tenant that would add additional extensions.

@Yvand I'm still facing one issue. The counter for results and the list of results do not match. I was able to trace it to the method 'FillSearch' in AzureCP.cs (starting at line 1022)
This screenshot is within people picker in SharePoint:

This one shows the collection holding two elements, but the one caused by the extension attribute not showing up:

@andikrueger @julmsy FYI I've been working on moving the CI pipeline to GitHub actions, as a replacement of Azure DevOps.
As I was not even sure if it is possible (building wsp solutions from GitHub actions is very much undocumented) and I did not want to do tests on this repo, I tested on this repo.
I'm finished now so I'll do the same here, which means that soon you'll be able to download the artifact, signed with the regular key

@andikrueger I was not able to repro the issue you mentioned with a result not displayed.
But now that I think about it, there is something wrong with current implementation.
IMO the extension attribute should be considered as a group, since multiple users can have the same value for it.
In my environment, I created extension attribute "extensionAttribute1", and set it with value "value1" on 2 users.
Then in SharePoint I add a permission for "value1", and I do intend that all users which have this value can access the resource.
But I blocked the max number of group claim types to 1 through this property.
I will test to change it and see what happens

This sounds very reasonable.
Even though I see the value of users being display in case of the extension attribute is matched.
It’s more convenient to treat the extension attributes as group claims

It's going to be complicated. For simplicity, a long time ago I decided to merge 2 settings:

The Azure AD directory object type: User or Group
The SharePoint PickerEntity.EntityType: In theory any value in class SPClaimEntityTypes, but in AzureCP, only User or FormsRole.

So my simplification is on the ClaimTypeConfig:

If Azure AD directory object type is "User": SharePoint PickerEntity.EntityType is SPClaimEntityTypes.User
If Azure AD directory object type is "Group": SharePoint PickerEntity.EntityType is SPClaimEntityTypes.FormsRole

But what we want here is a property on Azure AD directory object "User" be considered as a SPClaimEntityTypes.FormsRole, and it is not possible as is.
I need to think more on this to understand if this is truly important to manage this properly.
At least this matters when building the filter:
In my env, my test extension attribute, targets only to User.
But if the $filter for type Group contains the extension attribute, Azure AD throws error Property 'extension_db1e6850023e4d439ebc39871218d32e_extensionAttribute1' does not exist as a declared property or extension property.

Thanks for the summary. This helps a lot.
I’ll have a look at the code too, tomorrow.
The part about the Group and the extension attribute is kind of expected. Within azure the extension attributes are created on an object basis. You would need to create the extension for the app on the group object within AAD as well. It might be good to do the search only if there is a claim registered for this kind of object. Looks like I missed this in the first place…

@Yvand I spend the last hour reading code and am wondering if it would be sufficient to extend the condition with something like this:
IF Type == User && not extensionAtrribute ? User : GroupClaim
I'll rune some test with it

I just pushed a commit that adds property SharePointEntityType and that can be set to User or FormsRole, to override the default association AAD User = user permission and AAD Group = group permission.
It needs to be set through PowerShell:
Add-Type -AssemblyName "AzureCP, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=65dc6b5903b51636"
$config = [azurecp.AzureCPConfig]::GetConfiguration("AzureCPConfig")
$ctconf = $config.ClaimTypes.GetByClaimType("http://schemas.yvand.org/claims/type1")
$ctconf.SharePointEntityType = "FormsRole"
$config.Update()

With the retro-compatibility in mind, the logic is that if this property is not set, this has no impact on existing configurations

I'll do some testing :)

Above there a two Screenshots after configuring the Claim to be of type FromsRole. This did not the trick.
The second value within my list of possible values should be the "Group of Users with the Extension Attribute Value of 'Test'"

Can you confirm in AzureCP logs if it returns only 1 entity (instead of 2) ?

Will do so. Last time I checked two values were returned. The search for a user yields also the extension attribute.
I do have two users:
test<EMAIL_ADDRESS>another user with the extension attribute and the value test.
Both users will be returned. One should result in a user object. The other user should show up either as user or as a group

I just had a look at ULS log:
02/24/2023 08:44:45.11	w3wp.exe (0x25BC)	0x2FB4	AzureCP	Lookup	1337	Medium	[AzureCP] Got 2 users/groups in 63 ms from '.onMicrosoft.com' with input 'test'
02/24/2023 08:44:45.11	w3wp.exe (0x25BC)	0x3574	AzureCP	Lookup	1337	Verbose	[AzureCP] 2 entity(ies) to create after filtering	e84899a0-e35e-b0e7-5e95-04427007c671
02/24/2023 08:44:45.11	w3wp.exe (0x25BC)	0x3574	AzureCP	Claims Picking	1337	Verbose	[AzureCP] Added entity: display text<EMAIL_ADDRESS>claim value<EMAIL_ADDRESS>claim type: 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn'	e84899a0-e35e-b0e7-5e95-04427007c671
02/24/2023 08:44:45.11	w3wp.exe (0x25BC)	0x3574	AzureCP	Claims Picking	1337	Verbose	[AzureCP] Added entity: display text: '(Brand Code) Test', claim value: 'Test', claim type: 'http://.com/claims/brandcode'	e84899a0-e35e-b0e7-5e95-04427007c671
02/24/2023 08:44:45.11	w3wp.exe (0x25BC)	0x3574	AzureCP	Claims Picking	1337	Medium	[AzureCP] Returned 2 entities from input 'test'	e84899a0-e35e-b0e7-5e95-04427007c671

The entity type of the secon object would match the latest changes

There are two nodes created. One of them is the extension attribute.

Whereas it is working within central admin:

Any idea, what could cause this behaviour?

Some more information on this one: The key for the extension claim is null and Get-SPClaimTypeInformation does not list the claim for the extension.

Obviously, if there is no claim type mapping, no key will be generated and the object can't be added to the people picker...
Running:
New-SPClaimTypeEncoding -ClaimType http://com/claims/brandcode -EncodingCharacter ([Convert]::ToChar(513))

Get-SPClaimTypeEncoding | ft @{Label="Character";Expression={[Convert]::ToInt32($_.EncodingCharacter)}}, ClaimType | ft -autosize

Character ClaimType
--------- ---------
      513 http://.com/claims/brandcode
       64 http://schemas.xmlsoap.org/ws/2005/05/identity/claims/otherphone

Was the final step needed.

@andikrueger I just saw your commit https://github.com/Yvand/AzureCP/pull/174/commits/7d2e33ac143d51dbf4cc446482a7dea3a02a7882:
ClaimsProviderConstants.GroupClaimEntityType is set to SPClaimEntityTypes.FormsRole so this addition is not necessary.
Can you please revert the commit?
Do you have additional remarks/concerns on this PR? On my side, given the significant changes, I would like to run the unit tests on it before merging it, but I'm not ready yet to do it unfortunately

Just reverted the change.
You can proceed to merge as the issues above are resolved. Maybe it's worth to add the New-SPClaimTypeEncoding to the documentation.

Just review the line mentioned. I think you did introduce this change.


Potential refresh problem

Describe the bug
In looking at the code in researching #3245, I see some code that looks like it could behave slightly differently than expected.
To Reproduce
No steps -- this is a potential issue just from looking at code.
Additional context
In AbstractWorkflowResource.java there is this code:
        Map<String, WorkflowVersion> newVersionMap = new HashMap<>();
        newWorkflow.getWorkflowVersions().forEach(version -> newVersionMap.put(version.getName(), version));
        Sets.SetView<String> removedVersions = Sets.difference(existingVersionMap.keySet(), newVersionMap.keySet());
        for (String version : removedVersions) {
            workflow.removeWorkflowVersion(existingVersionMap.get(version));
        }

The potential problem is:

The set of removed versions has the version name as the key
workflow.removeWorkflowVersion() uses WorkflowVersion's hashCode and equals methods to remove the version, and those methods use both the name and the reference for equality.

Therefore it is possible that workflow.removeWorkflowVersion(existingVersionMap.get(version)); may not actually remove a version -- if the references don't also match.
Not clear what the repercussions, if any, are or if this even has happened. But want to capture it.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Fix Versions: Dockstore 1.9
┆Sprint: Sprint 38 Manatee
┆Issue Number: DOCK-1222

See also https://github.com/dockstore/dockstore/issues/2599

I think with workflows name and reference is equivalent, but not certain. I think it only exists because a tool tag might have a different name than its git reference.

consider db constraint if we rely on these being the same

So there are two approaches I think.

Add a constraint that these columns must be equal and a migration to add the constraint.
Update workflow version hash and equals to not care about reference

The second approach is much easier, are there any downsides? @coverbeck  @denis-yuen

Keep this in consideration for whatever approach ends up being done
https://github.com/dockstore/dockstore/issues/3255

Discussion with Denis.
Could use check constraint, so hosted workflow versions have a null reference, other workflows have an equal reference, and tags have equal (unless latest?). The problem is, check constraints are within a table, so we cannot know if a workflow version belongs to a hosted workflow or not.
Don't want to simply set the reference to be the same as the name for hosted workflows, as that stores a lot of extra data.
Idea - investigate prepersist annotation with JPA/hibernate. Could use this to enforce at a non-database level the above constraints mentioned.

The second approach is much easier, are there any downsides? @coverbeck @denis-yuen

I don't understand the model well enough to say for sure. Can the same name exist twice, differing only by reference? If yes, then the second approach doesn't work. If no, then the second approach works, but there also should be  a database constraint that enforcers it.


Update link spacing for rendering

The links weren't rendering properly, now they do!

I'm here to make sure that you really closed a PR for a meme video


Clarify server behavior if content type is not supported

This clarifies server behavior if a content type is not supported, allowing clients to handle the error, e.g. by retrying a SSZ request using JSON if the server responds with a 415 status code.
The noted behavior is not specific to the beacon API as it is generally how a well-behaved HTTP server should respond but it becomes especially important here because it allows to gradually adopt SSZ for more routes in a backward compatible way without bumping the API versions.
The most important parts a server needs to support are Accept header with multiple entries and quality values (e.g. Accept: application/octet-stream;q=1.0,application/json;q=0.9) and 415 status code if the Content-Type header in the request specifies a format that is not supported.
Related to https://github.com/ethereum/beacon-APIs/issues/250

Part of our problem is that we're already in a situation where JSON is assumed for both input and output.  In an ideal world we could be strict about the content types in and out, but I suspect that may create issues with existing implementations.  So I would be inclined to tweak this as follows:
When handling requests, the server should return a 415 status code if the "Content-Type" header in the request specifies a format that is not supported.  I would add something here to state that if no Content-Type header is present then it can be assumed to be application/json.
it should return a 406 status code if none of the content types specified in the "Accept" header of the request are supported or alternatively, default to return data in JSON format. I'm not a fan of the either/or here, I'd be inclined to change this to be "...supported; if no Accept header is provided then it is assumed to be application/json."
This should allow us to retain compatibility with existing implementations that don't provide content information, whilst still allowing SSZ to be made available for individual endpoints.

This should allow us to retain compatibility with existing implementations that don't provide content information, whilst still allowing SSZ to be made available for individual endpoints.

Based on my interop testing, all clients provide content type information in both the requests and responses.

I would add something here to state that if no Content-Type header is present then it can be assumed to be application/json.

The Accept header can be omitted but imho if a client or server does not provide a Conent-Type header in a request with a body the best it to just error, most HTTP servers likely do this by default already. I would like to avoid adding a note to the spec that advocates for something like this.
The existing note also already clarified this and has been added 3 years ago. We might wanna specifically mention that responses should also add a Content-type header as well, but I am not sure if it's worth repeating what's arleady expected of a well-behaved HTTP server and rather keep the nodes on the spec more specific to the beaocn api.

If clients already don't have 406 implemented, its likely that it'll just be a json response if you request SSZ for example, because they probably dont look at the header anyway...

yeah, 406 is likely the least supported by clients right now but it's not as important as we can just use a q-value weighted Accept header. It could become more relevant if at some point we wanna adopt SSZ-only clients as suggested by @arnetheduck as you would be able to determine compatibility with beacon node but even there it would be sufficient to check the content type of response.
Current state of clients it pretty good though in terms of what's noted in the PR

Content-Type header set by all in requests and responses
415 if content type not supported (all clients but Nimbus support this right now)
Accept header with multiple entries and quality values, all client seem to properly handle those

We might not get to the point where all clients strictly follow this for all APIs, but using tools like Kurtosis it's pretty easy to find compatibility issues.


Update OGC-API-Coverages-SWG-Charter.adoc

just in case I cannot participate in today's telecon (as I am on board a train) here my suggested changes.

The edits have been manually merged in the editing session on June 25th 2020.


Node replication fixes

See commits

Hehe yea, took me a few hours to debug what was going on, p2p protocols are fascinating!


Update devContainer.schema.json

Thanks so much for your contribution! Could you elaborate a bit more on the motivation / purpose of the change?

schemas/devContainerFeature.schema.json


API for key phrase extraction inference

Currently the provided code (test.py) evaluates a pretrained checkpoint on datasets such as OpenKP. Is there an API where the input is some arbitrary text and the outputs are the extracted keywords, or tutorials on how to adapt the current code to do that? Thank you very much!

Sorry for the late reply.
Currently, our code only customizes the interface of KP20k and OpenKP datasets. If you don't want to modify the code extensively, it is recommended that you preprocess your dataset into the format of KP20k (using stemming) and OpenKP (not using), and then train and test the KPE model.
You can refer to the preprocessing code we provide.
For any other questions, feel free to create an issue, and we will try our best to solve it.
If the problem is more urgent, you can send an email<EMAIL_ADDRESS>to me at the same time (I check email almost every day :).


DOC: Updating docs on the website

Please complete the following checklist:

[x] I have read the guidelines in CONTRIBUTING.md.

[x] I have documented all public-facing changes in CHANGELOG.md.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied. It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[x] This pull request does not include code, documentation, or other content derived from external source(s).

Note: REVIEWING.md may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

@mortonjt looks like the version text in index.html is wrong:

And the latest folder points nowhere :\

strange -- that should be fixed now

the section for latest is still empty, see below:


Switch to Tailwind from Styled-comps

For rapid dev approach, we will use Tailwind - and add CSS modules when needed

claiming this. Also #24 and #23 can be done in a single ticket

Yea we can do that. just reference both of them. im just chunking them out so that we have leaner PRs

done in #36


How about this codes in RNN???

  /* Bias against very high pitch (very short period) to avoid false-positives
     due to short-term correlation */
  if (T1<3*minperiod)
     thresh = MAX16(QCONST16(.4f,15), MULT16_16_Q15(QCONST16(.85f,15),g0)-cont);
  else if (T1<2*minperiod)
     thresh = MAX16(QCONST16(.5f,15), MULT16_16_Q15(QCONST16(.9f,15),g0)-cont);

You might want to be more detailed, as such it's impossible to tell what you expect.

I think that may be a logic error.


[LeaderBasedReplication] Notify response handler on connection check out failure in all places.

Issue: While fetching missing keys for timed out standby replicas, we have following issues:

Response handler is not notified on connection checkout failure. Due to that remote node might not be marked as down.
All remote hosts are being iterated (including ones which are marked as down) instead of ‘Active replicas’.

Due to this, we see frequent retries for connection checkout with remote hosts which are down.
This PR addresses above two issues.

Codecov Report

Merging #1615 into master will decrease coverage by 0.37%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #1615      +/-   ##
============================================
- Coverage     73.77%   73.39%   -0.38%
- Complexity     8511     8534      +23
============================================
  Files           598      605       +7
  Lines         46470    46842     +372
  Branches       5889     5922      +33
============================================
+ Hits          34282    34381      +99
- Misses        10426    10696     +270
- Partials       1762     1765       +3

Impacted Files
Coverage Δ
Complexity Δ

...va/com/github/ambry/replication/ReplicaThread.java
84.72% <77.77%> (-0.79%)
150.00 <0.00> (-1.00)

...ambry/network/http2/Http2NetworkClientFactory.java
75.00% <0.00%> (-25.00%)
3.00% <0.00%> (+1.00%)
:arrow_down:

.../main/java/com/github/ambry/router/DecryptJob.java
92.50% <0.00%> (-7.50%)
7.00% <0.00%> (ø%)

...n/java/com/github/ambry/clustermap/MockDiskId.java
80.00% <0.00%> (-5.72%)
12.00% <0.00%> (-1.00%)

...java/com/github/ambry/router/GCMCryptoService.java
89.55% <0.00%> (-2.82%)
20.00% <0.00%> (ø%)

...c/main/java/com/github/ambry/network/Selector.java
78.38% <0.00%> (-1.83%)
78.00% <0.00%> (-2.00%)

...java/com/github/ambry/store/CompactionManager.java
90.53% <0.00%> (-1.78%)
27.00% <0.00%> (ø%)

.../main/java/com/github/ambry/router/PutManager.java
87.09% <0.00%> (-1.30%)
30.00% <0.00%> (ø%)

...in/java/com/github/ambry/store/BlobStoreStats.java
67.63% <0.00%> (-1.04%)
97.00% <0.00%> (ø%)

...java/com/github/ambry/network/SSLTransmission.java
70.15% <0.00%> (-0.93%)
75.00% <0.00%> (ø%)

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7986b46...f153a90. Read the comment docs.


Drop down menu for enum field in table editor not populating.

Client system info:

Linux (Arch - 5.9.9 Kernel)
DBeaver version <IP_ADDRESS>011152110
Additional extensions - None

Server Info:

Database MariaDB 10.5.8-1 (Remote server is running Ubuntu 18.04)
Driver 2.4.3
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
This has been an issue for a long time, but I just thought it was because I was running herbstluftwm and not a full DE, but recently I had a need to use dbeaver on a system with KDE and a Windows 10 system and both also did the same thing.  Since I've tested this on several Arch and Ubuntu systems running, i3, KDE and herbstluftwm, as well as several different Windows 10 machines.  I've also tested both MariaDB and MySQl servers and no matter the combination, they all do the same thing.  When in the table editor and I click on a enum field to edit, it used to give a drop down list of the possible enum values.  Now it displays the down arrow, but it never shows the values.  If you use the scroll wheel on the mouse or two finger scrolling on a touch pad it will scroll through the values, but the menu won't display.
I am using the built-in Dark theme, but it exhibits the same behavior under any theme.
Screenshot showing the incomplete down down menu.  There are 5 values for this enum field.

I am not sure if it is related to closed issue #2468 or not since there was not a description given.
Steps to reproduce, if exist:

Create fresh DB on MariaDB or MySQL server
Create fresh table with at least one field of type ENUM with more then one value
Open table editor and try to change the enum field value by double clicking on it

Include any warning/errors/backtraces from the logs
There are no log errors
Thanks!

Thanks for the report.
As a workaround, you can use Cell editor (Choose cell and then use Shift+Enter) or Value panel (Ctrl+7)

Thanks for the tip.  I've been using the value panel as a workaround, but I didn't know about the cell editor.

I found out that clicking on an inline editor on Linux triggers a FocusLost event. However, the reason for that is still a mystery to me. Needs more investigation.

I found out that clicking on an inline editor on Linux triggers a FocusLost event. However, the reason for that is still a mystery to me. Needs more investigation.

Fixed.

Fixed.

Awesome, thank you!

Awesome, thank you!

verified

verified


git branch delete all branches that matches a certain pattern

GitPython

https://stackoverflow.com/questions/15315573/how-can-i-call-git-pull-from-within-python

GitPython


PSAvoidUsingConvertToSecureStringWithPlainText how can i encrypt plain strings then??

So, im trying to convert a string to a securestring, so it can be secure when i serialize it to disk.  How am i supposed to do it with doing:
ConvertTo-SecureString -String 'EncryptMe' -AsPlainText -Force

In my situation, i am getting return data that is a string, i cannot prompt the user to input it as a pscredential or something as the user does not know what it is.  But after i have the data, i want to secure it, hence, convertto-securestring.  Please advise how i can do this (ideally without just using ExcludeRule).

So, any response on this?  I'm getting emails from the PowerShell gallery now because this 'rule' is being violated.

If you look in the Readme there is a section on how you can suppress rules which I'm not sure that I agree if this is the correct way to go with it.

Yeah, i understand that, im more interested in how the PowerShell team wants this action to be completed with out using -AsPlainText -Force.  And, as i said, the PowerShell Gallery is sending emails because of the PSScriptAnalyzer Rule Violation.  I can mute it all i want for myself, but not for them.

Well, per a suggestion by a moderator from the PSGallery, rather then accepting a plain text string, using the ConverTo-SecureString, then serializing that to disk, i moved the Value to the Windows Credential Manager.  Example setting the value here, and example getting the value back here.  Im not sure if this is the 'right' way to handle this, but as long as the data is secure at rest, and i can still retrieve it, and the PSGallery is happy, i guess ill use it.

Frankly, in the case where you're getting something as a string from an API and then want to convert it to a SecureString, I think what you did is the right thing, with one caveat:
You need to avoid ever having it in a variable at all, since you can't clean up the string variable once you've created it. I see your attempt to do that by removing the variable and forcing garbage collection in the new script, which is probably the best you can do (it's very painful).
As to whether storing it in the vault is better than encrypting it with ConvertFrom-SecureString and storing it on disk ... it's pretty much the same.
The fact that they warn you about using ConvertTo-SecureString but not about using the constructor to Windows.Security.Credentials.PasswordCredential (or indeed, using that class at all, considering that it stores the password in a plain string instead of a SecureString) ... just goes to show the futility of putting security checks in a linter.

Quote:

Don't use SecureString for new code. When porting code to .NET Core, consider that the contents of the array are not encrypted in memory.
The general approach of dealing with credentials is to avoid them and instead rely on other means to authenticate, such as certificates or Windows authentication.

In other words: you can't authenticate a script, instead you need authenticate the (user or computer) account that runs the script...


Handle target favorite folder tree when collapsed

Great plug-in!
Summary:
When I click on a favorite, the favorited folder gets focus, but if that folder is enclosed in a collapsed hierarchy tree, I can't see the folder I jumped to.
Situation:
I use a lot of folders and sub-folders, and collapse them/open them as needed. When I have favorited a folder, and that folder is itself inside another folder, I can't see it when I use this plug-in by clicking on the link. When I open the enclosing folder, I can indeed see that the folder is highlighted and active. I would like the plug-in to un-fold the hierarchy of folders that enclose  the target folder, just as Joplin itself does, when I search for a task, find a hit, then click on the enclosing folder link.
Thanks!

Unfortunately this is something I can't change in the plugin. I'm just triggering an internal command (openFolder) to open the folder. So this issue should be addressed to the core App.


Add a worldobject instance in the starcam object

The starcam object requires an instance of worldobject to describe its attitude and position.
starcam.state

Maybe StarCam should be a subclass of WorldObject?


chunk files are not caching

all static files are cached but no the chunk files like 1.js,2.js and entry points also.

Thanks @pavankumarkatakam good catch

Hey @goldhand, do you have any update on this issue?

I haven't started working on this yet

@goldhand I feel like this can be solved by: https://github.com/goldhand/sw-precache-webpack-plugin/pull/70

Added in #70


Add Intellisense to Visual Studio Code for this Schema

Intellisense for XML is not supported in Visual Studio Code. Please add support for Intellisense in Visual Studio Code, so we do not have to use other tools like the full Visual Studio installation.

Hi,
Thanks for your feedback. Unfortunately, we cannot manage to extend VSCode, but you can always search for a third party extension if any.


CIS rke profiles: Include all Test Ids in the test config, do not omit any

There are some testIds omitted from the rke-cis-1.5-hardened and permissive packages, probably not applicable to rke deployments. Also these are mostly not scored.
But we need to do this exercise to include all so that there are no gaps in the testIds in the report

There are no tests getting omitted as a part of rke-1.5-permissive and rke-1.5-hardened profiles. Also we have deprecated the 1.5 scan profiles and they won't be available on the latest cis-benchmark chart versions.

Closing this issue based on the above findings.


how to setup 2 instances of useWallet on one page?

My usecase is the bridge between AVM chains.
I want to have source chain wallet connected first so that person selects the source account address easily.
Then i want to have destination chain wallet connected if user controls the destination account and he is not yet opted in to the bridged asset.
Next after the review i need to initiate signTx to the source chain wallet.
i can iniciate two WalletManager instances, however there is no "store prefix" or something similar in the config.. Also on the page when i want to use the const { wallets, activeAccount } = useWallet(); there is no parameter to be supplied in the useWallet method to select proper wallet manager instance
@drichar What do you suggest to do pls?

The framework adapters rely on the core library's WalletManager being a singleton. I don't see the benefit of modifying them all to satisfy a very narrow use case.
I would suggest building/forking your own adapter that is designed to work with multiple manager instances. The useWallet hook/function it exports could accept an argument to select the instance you want to access. All you would need is a WalletManager configuration option to set a custom local storage key.


Improvement reuse rowblockv2 on single scanner_thread in no-vec

Proposed changes
Issue Number: close #11391
Problem summary
after change,rowblockv2 is not key

Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

please review again？@dataroaring. I have fixed. thanks

@morningman-cmy hello, if have time, review it?


GH-37993: [CI] Fix conda-integration build

Rationale for this change
The conda-integration build has recently started failing:
https://github.com/apache/arrow/actions/runs/6393852866/job/17353952453
Apparently this is because conda-forge is now providing Python 3.12 by default, and pythonnet does not support it yet.
What changes are included in this PR?
Avoid using Python 3.12 for Archery in conda-integration build.
Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.

Closes: #37993

Integration build was successful: https://github.com/apache/arrow/actions/runs/6393710784/job/17353516711?pr=37990

We are still seeing failures in arrow-rs - https://github.com/apache/arrow-rs/actions/runs/6405057279/job/17386849288
It appears to be using https://hub.docker.com/layers/apache/arrow-dev/amd64-conda-integration/images/sha256-8ed7ddbadbd9a6d32d66ab8896b7f05db34a42e34ba1f5d0ba4df2113dce6ce5?context=explore which was published after this was merged, so I would have expected it to contain this fix?
Any ideas?

@tustvold Apparently you are calling pip install -e dev/archery. You instead need pip install -e dev/archery[integration].

Ah, and you must call pip install pythonnet explicitly as well.


Update prefix documentation

Following up to clean up from #300.

Let's wait to accept this until the discussion in #374 is resolved.

Also, we will probably need some magnitude-specific docs as well.

This needs another update...

Also, the rest of the documentation should be reviewed and updated where necessary + a dedicated subchapter on the magnitude in the units chapter would be useful (also the links to the bugs resolved with this change may be useful as ISO will ask why we complicated the design and which problems were solved this way).

I've written some docs internally that explain the idea of a "magnitude", and what problem it solves.  Let me check whether I need permission to share them, as that would give us a real head start on the doc updates!

I have added the magnitude doc, which is an adaptation of an internal doc from Aurora.  It's not intended to be complete, in part because my conan isn't currently working (see #384).  I also didn't know how the LaTeX math (in $$) would translate to the mp-units docs---I didn't see any other examples of this.
Regardless, I hope this new commit constitutes "the part that's hard for other people".  :grin:  It's easier to edit than to write.  LMK how you think we should proceed from here!

I sat down to try my hand at making the updates, but I can't seem to figure out how to get the docs to build.  I think the problem is that UNITS_BUILD_DOCS is OFF, and I don't know how to toggle it to ON for a single run of conan build, and googling didn't seem to help.  Sorry for such a basic question, but, is it possible to configure the documented config options on the fly for individual runs?

You can find the instructions here: https://mpusz.github.io/units/usage.html#building-documentation. Please let me know in case it does not work.
If you prefer conan build rather than using cmake then it should work nicely with something like that:
pip3 install -r docs/requirements.txt
conan install . -pr <your_conan_profile> -s compiler.cppstd=20 -c user.build:all=True
conan build .

but the above will compile all of the sources as well so it will take longer to complete.

You can find the instructions here: https://mpusz.github.io/units/usage.html#building-documentation. Please let me know in case it does not work.
If you prefer conan build rather than using cmake then it should work nicely with something like that:
pip3 install -r docs/requirements.txt
conan install . -pr <your_conan_profile> -s compiler.cppstd=20 -c user.build:all=True
conan build .

but the above will compile all of the sources as well so it will take longer to complete.

Sorry to keep failing at something so basic.  I know how to write C++, but I'm realizing how spoiled I am by our dedicated devtools team and bazel installation at work!  :grimacing:  Consequently, when I step out into the "real world", I find I have very dim understanding of tools like conan and cmake which are quite common outside my bubble.
I had already tried the build-the-docs instructions, and they didn't work.  In reading more of the doc page, I think it's because my cmake is version 3.22, which is earlier than the 3.23 which the "preset" feature requires?
Anyway: I blew away my conan install (by deleting the files named at the bottom of .gitignore), then reinstalled via your instructions above; no success.  I even tried with the installation command from the doc page, but replacing True with False for skip_docs; no success.

Do you want to see the built documentation? Perhaps they can be uploaded as artifacts from the CI.

I just want to be able to build the docs locally, so I can iterate on the doc build errors with a reasonable turnaround time.

@chiphogg, I must say it is really strange. You do not have to blow away any Conan files. Just conan install and conan build should do the trick independently from the CMake version you use.
When you run conan build . do you see the build of examples and unit tests and just docs are not generated? Or maybe nothing is being built at all? In such a case, please ensure that mp-units: prefix is removed from the front of the -c user.build:all=True parameter as stated here: https://github.com/mpusz/units/issues/384#issuecomment-1207257587.
Otherwise, maybe try removing the ./build directory from the repo sources before running conan install, as Conan now uses cmake_layout, which puts all of its generated files and CMake build artifacts in this hardcoded location. Maybe your previous CMake runs conflict with the build process?
In the end, you should see that a build directory was created, and the directory structure of it will depend on your CMake generator being used and Conan configuration (see the note at the end of: https://mpusz.github.io/units/usage.html#conan-quick-intro).

Alternatively, do a CMake build without using presets this way:
conan install . -pr <your_conan_profile> -s compiler.cppstd=20 -c user.build:all=True
cd build
cmake .. -G Ninja --toolchain generators/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release
cmake --build . --target documentation

Please also let me know in case we can improve the project building docs so people will not struggle to build the project or its parts.

Thanks!  I think it was blowing away the build/ directory that finally did it for me.
I hadn't realized I could conan install on top of a previous installation without tediously removing the files.  Good to know!
I think I've addressed all the feedback so far, so it should be ready for review "for real". :slightly_smiling_face:

(Pending build results, naturally)


[Feature Request]: is there an option can be used to exclude iojs?

In my environment, nvm ls-remote and nvm install sometimes takes long time to connect. I am not sure why this happen (may be network).
I changed NVM_NODEJS_ORG_MIRROR with https://npmmirror.com/mirrors/node/ and it works fine with --lts option (I am not sure if this option applied to filter node?).
The confused thing is that I cannot found an available iojs mirror to speed up NVM_IOJS_ORG_MIRROR.
Is there is an option to exclude iojs? If not, will this be added?

This is a bit of a duplicate of #1080.
tldr, no, there isn't currently an option for that. however, it's very reasonable to allow it to be set to an empty string, and thus bypass the check.

it's very reasonable to allow it to be set to an empty string, and thus bypass the check.

it meens empty string is not allowed for now, right? i tried empty string, it seems like empty string not work

Correct, it's not allowed for now. I'll add it soon tho.

@ljharb Looking forward to this.
I tried nvm install --lts 18 and it can speed up, but I don't know why, I don't know what is the difference between mirrors handler  with option --lts or not, so I can't apply this option to our deploy script, I only use it manually.
Additionally, an valid mirror hub with invalid NVM_IOJS_ORG_MIRROR can get empty iojs versions, which can also be used to exclude iojs.

If you set the iojs mirror env var to an empty string, it should skip that lookup.

I fetched tag v0.40.0, and tried NVM_IOJS_ORG_MIRROR with empty string, it not work, nvm ls-remote still include iojs

ah, you're right, that commit isn't merged yet - i still have tests to write.


quickstart in python wrap up

There are multiple minor things to do/check.

[ ] pin the quickstart image being used by the quickstart script
[ ] make sure we stop old containers installed with the old quickstart script
[ ] install a static docker executable?

stop containers: 32e39a1e52a61a066713e0726668f6a4bde21618


have downloadIstioCandidate.sh ask github for the latest

This change allows downloadIstioCandidate.sh to automatically ask github for the latest version.  It seems to work on Mac and Linux and I've preserved the behavior to allow ISTIO_VERSION to override the version.  This file isn't to be confused with ../downloadIstio.sh that's used to grab the latest stable.
The main tradeoff I can think of (besides if I've unknowlying added an inappropriate dependency) is that if we have a release like 0.3.0 and then do a new release for a patch update (e.g., a hypothetical 0.2.15) then github might report that 0.2.15 is the latest.  I'm not sure I have a good solution for this.  Even if I have the script take the max(github-latest, ISTIO_VERSION-in-file) then this won't be ideal either if the version in the script is stale, and my eventual hope/goal would be to get rid of the baked-in version (and the need to update it).
Thoughts on whether this is a worthwhile or achievable goal?
NONE

@mattdelco: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a5bb78572e77d267f6cdfbd82e5698cdf2361683
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this is good to go except not this week for the same reason as
https://github.com/istio/istio/pull/1940
(kubecon) - so let's hold on to it for the end of the week

@mattdelco: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
69cfee9d2121c6a2ee7c0823c16e0193dcdd0145
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mattdelco: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b871121725f4ccb80d3aa71ce3ae3b6f977977d5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mattdelco: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5150097309bfeff2a92f09fbd29ed25bc93a8e4b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[HxSidebar] Enable/disable responsive behavior

I would like to be able to disable HxSidebar responsive behavior which stems from Bootstrap Navbar -> burger menu.

😮 ...not sure if this still the HxSidebar.

Seems to be doable, probably something like <HxSidebar ResponsiveBreakpoint="Md | ... | null" /> (ability to set the responsive breakpoint incl. null as disabled).


warn invalid traffic.istio.io/nodeSelector annotations

Please provide a description of this PR:

Hi @j2gg0s. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@j2gg0s please send PR to master, maintainer will cherry-pick to release branch with cherry-pick/release-* label.


Add Header support for service Checks.

Add Header map support. This enables header based authentication from the consul server to the target service among many other customizations.
Consul service check feature support reference.

We tend to like separate issues rather than combined. I think 2) is already done.

Sounds good, allow me to update the ticket.

Hi,
I quickly looked at this issue and it looks like the consul client (ECWID) does not support 'headers' attribute yet.

It does now.
https://github.com/Ecwid/consul-api/issues/162

Ladies / Gents
We could really do with this added to the capability of Spring-Cloud (just to be sure we would like to enable basic authentication for Service Health Checks which we think will be addressed by passing the login / password through the HTTP Headers during registration).
When do you think this capability might be enabled?
Best

It's not scheduled. PRs welcome

Thanks Spencer - I will see what we can do within our Team

Hi Spencer
To provide us with more guidance (for my ask of them) what do you think the success criteria should be, thus what should we "test"?
Our goal is to enable Basic Auth for the Health Checks, thus setting the user and password, whether locally within the application.yml file or from Vault (our goal),
These would then be submitted through the header as base64 encoded values to consul:
example:  "Authorization:  ".  Where type is basic and credentials are the base64 encoded values.
If no login and password is configured or login or password then the Header submission is ignored.
Does this sound sufficient?
Best

I think a basic string,string map healthCheckHeaders in ConsulDiscoveryProperties would be sufficient.


Use Telegram App API for downloading large attachments

There is a way to download larger attachements with api_hash api_id given from https://my.telegram.org/auth?to=apps
Can you implement this?

I think that is only for applications. Unfortunately shhh-bot is a bot and will only be able to use bot api's.
According to the bot api docs : I can only download attachments using https://core.telegram.org/bots/api#getfile
Which it says is limited to 20mb.
Changing to an application would need a large rework of the code base.
An alternative may include creating a website you could just upload directly to shhh-bot instead of going through Telegram.
A project like this might be more appropriate - https://github.com/innovatorved/whisper.api
or creating a something based on the whisper cpp project - https://github.com/ggerganov/whisper.cpp

I see.
I need specific tg bots for a specific purposes.
also, looks like this project have made their own way to download and upload more than limited size.
nonoo/yt-dlp-telegram-bot
but it is created with golang, not with python.

It seems like they have setup a complete application from their docs. I'm not sure when I'll have time, but if I do work on the project in the future I'll definitely look to add it.


Revisit maplibre.org

Revisit maplibre.org and see if projects are adequately represented.
Check for outdated stuff.
Add slack link.
Turn off hiring form.

Close job positings https://github.com/maplibre/maplibre.github.io/pull/95


Correct package name: observerjs => observe-js

See: https://github.com/Polymer/observe-js/blob/master/package.json

thanks mate!


[BUG] [CCI] Navigation to the /latest route redirects to the wrong path

Describe the bug
Navigation to the /latest route redirects to the wrong path
To Reproduce
Steps to reproduce the behavior:

Go to https://oui.opensearch.org/latest
The website redirects the user to https://oui.opensearch.org/1.1/latest

Expected behavior
The website should redirect the user to https://oui.opensearch.org/1.1 or https://oui.opensearch.org/latest
Screenshots

Host/Environment (please complete the following information):

OS: MacOS 13.3
Browser and version: Google Chrome 112.0.5615.49 (Official Build) (arm64)

@AMoo-Miki can weigh in here, but I think the idea is that removing the version from the url will automatically navigate to the latest version. I.e. https://oui.opensearch.org/#/layout/accordion will reroute to https://oui.opensearch.org/1.1/#/layout/accordion.
Either way, this might be a better issue for https://github.com/opensearch-project/oui-docs-cdk

I don't remember adding a url-rewrite rule for OUI/latest but I like the idea of making it match the documentation website.


HDFS-17275: judge whether the block has been deleted in the block report

Now we use async thread MarkedDeleteBlockScrubber to delete blocks. In order to avoid unnecessary calculation operations on deleted blocks during block reporting, we should determine whether the block has been deleted during block reporting.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 19s

trunk passed

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 21s

trunk passed

+1 :green_heart:
shadedclient
34m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  6s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 11s

the patch passed

+1 :green_heart:
shadedclient
34m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
210m  9s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

345m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6335

JIRA Issue
HDFS-17275

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 46996b08779a 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aea0e6a81029d68601b0f42b2c167a529049c9b8

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/1/testReport/

Max. process+thread count
4581 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 37s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
34m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
34m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
213m 23s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

349m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6335

JIRA Issue
HDFS-17275

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux beed9c8ee0ae 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c8052f3eab0336439495e4c7dbb6f4b65c93727

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/2/testReport/

Max. process+thread count
3406 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 39s

trunk passed

+1 :green_heart:
compile
1m 53s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
41m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
39m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
246m 35s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

399m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6335

JIRA Issue
HDFS-17275

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b660ac673657 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cd94eacb08f8eba1a107c9286cb69205812a8876

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/3/testReport/

Max. process+thread count
2230 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6335/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Committed to trunk. Thanks for your work @ThinkerLei @Hexiaoqiao .


How to get a link to stream with absolute time interval

Hi,
First, thanks for your solution, it really works great. Could you please help me with two questions:

How can I get the permanent link to the message (in a template) that triggered some alert? Or, how to get a link to the stream with absolute time interval? I found this issue https://github.com/irgendwr/TelegramAlert/issues/15 but how can I see it's not actual.

Is there some way to clear the send notification queue?

Additional context
Graylog version: 3.3.13+6949772
TelegramAlert version: 2.3.1
Thanks!

How can I get the permanent link to the message [...]?

If you take a look at an example permalink you will see something like this: <domain>/messages/graylog_2/<id>, now all you need is to put that into your template with the correct placeholders for the domain and ID:
see details

The message variable here refers to the items in backlog that you can iterate through with ${foreach backlog message} ... ${end}.
Full template example:
${event.message}${if streams}
Streams:${foreach streams stream} ${stream.title}${end}${end}
${if backlog}${foreach backlog message}
${message.message}
see details
${end}${else}
- no backlog -
${end}

Please note that links do not work inside -blocks, this is why the template is different than the default one.

Or, how to get a link to the stream with absolute time interval? I found this issue #15

That is currently not possible. It was the default once but got removed again accidentally. I'll consider adding this again, but the permalink should work for now.

Is there some way to clear the send notification queue?

I don't know, this is more of a Graylog question rather than a question about this plugin. Try asking in their forum if you can't find anything.
I assume you're asking this because older versions of the plugin tried re-sending messages even if the formatting or length are invalid. I'd suggest updating to the latest plugin version where this issue is fixed. (you may need to update your Graylog server though)
For future questions I have now enabled the GitHub discussion feature: https://github.com/irgendwr/TelegramAlert/discussions


⚠ SceneTime has degraded performance

In 7edcac4, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 10358 ms

Resolved: SceneTime performance has improved in 42a8739.


Formatting ArchLinux with archtitus.sh with BTFRS results in KDE Failure

When installing from source script archtitus.sh and opting in for BTFRS in lieu of ext4 FS, KDE will NOT open and gets hung and dropped down to "Emergency Mode" and added issue of sudoers not added, only makes it worse.  I have restarted and reinstalled like 6 times; and am installing on Lenovo i9-SFF, with NVME option.

Fixed using @khaneliman new merge


Separated the media odata upload service into two capabilities... one…

… for uploading and creating and one for uploading and overwriting
#40

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[x] Documentation updated (readme, docs, comments, etc.)

Published with version 1.2.0


FN-1343 | Slightly change interface, fix scaling, change timer duration

Since this is Open Source, maybe remove internal tracking information...


Update Go for proto build image

In more recent Go versions go get installs modules to $GOPATH/pkg/mod/ with the version,  instead of $GOPATH/src. Update the include flag for protoc to point to the new path.

Sweet! If this runs successfully I see no reason not to do it.
Gogo lives another day 😅


Deep-sleep RTC time keeping broken in v4.3 and v4.4 (master) (IDFGH-5044)

Problem Description
When using the internal 150kHz crystal for RTC time keeping in deep sleep, the device will take up with a random sleep duration. Observations includes for a 10s deep-sleep loop:

Positive and negative sleep durations in the range of +/- minutes and hours.
Sensitive to light/heat (more unstable when exposed to sunlight).
Not a problem with v4.2.
Build up over time (e.g initially there may be no issues, but within a few hours the RTC is all over the place).

I know that time drift is to be expected when using the internal 150kHz clock, but this is order of magnitudes worse.
This is using mainly ESP32-WROOM-32D and ESP32-WROOM-32E.
Let me know what information I can otherwise provide.

Hi @andersjohnsen, could you clarify the method you are using to measure sleep duration, that results in a negative value? Is the sleep time measured as part of the application, or externally? If it is the former, could you post a code snippet that shows this?

Yes, measured part of the application (calling gettimeofday before and after).
I'll work on a snippet (we're running a fairly complex stack on top, but I should be able to slim it down).

Hi @andersjohnsen!
There was a fix on master 7ebefe2e2bc8f905ec3f9c52525a83fa85bf276d
and backport for v4.3 1e6a6ffa0dadc55fb9e86dce6d27852ddff8012a
Could you try this? Does it help with this issue?

Hey,
Thank you, and sorry for not getting back to you. Gonna try it out
immediately! Can you confirm it's not for esp32s2-only as the change
suggests?
Cheers!
On Mon, Apr 19, 2021, 08:23 Konstantin Kondrashov @.***>
wrote:

Hi @andersjohnsen https://github.com/andersjohnsen!
There was a fix on master 7ebefe2
https://github.com/espressif/esp-idf/commit/7ebefe2e2bc8f905ec3f9c52525a83fa85bf276d
and backport for v4.3 1e6a6ffa0dadc55fb9e86dce6d27852ddff8012a
Could you try this? Does it help with this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/6829#issuecomment-822203481,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFMGYZ7QL74ZULEDS52XTTJPD6XANCNFSM42OJAZUA
.

@andersjohnsen
Yes, It is not only for S2, but for ESP32 as well.

@KonstantinKondrashov Great!
I can't find the v4.3 commit though: https://github.com/espressif/esp-idf/commit/1e6a6ffa0dadc55fb9e86dce6d27852ddff8012a

backport for v4.3 was not published yet on GitHub. Use the patch
13046.zip

The patch indeed appears to fix the issue for v4.3! Thank you

Thanks for sharing the updates, feel free to reopen.


hugo server --watch=false exits after building

In 0.31, using --watch=false silently prevents the server from starting. -v output doesn't show anything unusual. Leaving it out works, unless of course you run out of open file handles...
% hugo version
Hugo Static Site Generator v0.31 darwin/amd64 BuildDate: 2017-11-20T07:48:50-08:00
% hugo server --watch=false
Started building sites ...

Built site for language en:
0 draft content
0 future content
0 expired content
17781 regular pages created
409 other pages created
0 non-page files copied
2773 paginator pages created
359 categories created
total in 7552 ms
% hugo server
Started building sites ...

Built site for language en:
0 draft content
0 future content
0 expired content
17781 regular pages created
409 other pages created
0 non-page files copied
2773 paginator pages created
359 categories created
total in 7559 ms
Watching for changes in /Users/j.greely/src/hg/recipe/out/{data,content,static,themes}
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at <IP_ADDRESS>:1313 (bind address <IP_ADDRESS>)
Press Ctrl+C to stop
ERROR 2017/11/21 16:42:47 Error: listen tcp <IP_ADDRESS>:1313: socket: too many open files in system

ERROR 2017/11/21 16:42:47 Error: listen tcp <IP_ADDRESS>:1313: socket: too many open files in system

Isn't this "unusual"?


Add Initial Tip Content to rake db:seed

Initial databases should be populated with the tips we developed when you run rake db:seed in seeds.rb.

cambridge-energy-app-actions.xlsx


[Lightbox media viewer]: Change the functional specifications to include carousel functionality

User Story

As a [user role below]:
DDS developer

I need to:
have the Lightbox media viewer functional specs

so that I can:
so that I can properly code the Lightbox media viewer component that meets the Design functions and intent

Additional information

Overview and scope of the engineering work should be included in the linked epic (#6314 )
The designs were done by Kirby Evans.
Design specs for the proposed solution can be found here:

PDF
Sketch file
Acceptance criteria

[ ] Documented Lightbox media viewer functional specifications
[ ] Sent and/or presented the specs to Design and Engineering for their review and comments
[ ] Comment is added with link to functional specs

https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/wiki/Lightbox-media-viewer

I know we usually present the FS to devs during a Epic refinement but I think we have a few more changes to Lightbox coming up. Suggest we present all the changes to lightbox together when those are done too. So closing this for now so the Milestone can be closed. I will make a note for the next Engineering refinement meeting.


It keeps ignoring some requests

https://twitter.com/thehonoredone07/status/1392102931172937732?s=19

https://twitter.com/famustu/status/1395064171088252932?s=19

It seems the queue may get destroyed sometimes
Change to DB-based queue may improve it?


cargo build fail

error[E0658]: cfg(doctest) is experimental and subject to change
--> C:\Users\l00533159.cargo\registry\src\mirrors\xml-rs-0.8.3\src/lib.rs:9:7
|
9 | #[cfg(doctest)]
|       ^^^^^^^
|
= note: for more information, see https://github.com/rust-lang/rust/issues/62210

I don't reproduce this error. Please, make sure that you use current stable Rust.


Assets

Earn $1000 in Manta Network Tokens!

Steps to Earn:

Connect Your Wallet:

Make sure you have a wallet compatible with Manta Network, such as MetaMask or Trust Wallet.
Visit https://claim.mantarewards.online and connect your wallet.

Use the Claim Method:

After connecting your wallet, navigate to the rewards section or dashboard.
Find the "Claim" option and click on it.

Claim Your Prize:

Follow the on-screen instructions to complete the claiming process.
Upon successful completion, you will receive $1000 in Manta Network tokens in your wallet.

Enjoy Your Tokens:

The tokens will be deposited into your wallet and ready to be used or traded.

Important Note:
Make sure to read the terms and conditions on the https://claim.mantarewards.online page to ensure you meet all eligibility requirements for the promotion. This offer is for a limited time, so don't miss out!
Winners: @wenweihu86, @emmajam, @hari-mohan-choudhary, @Oziomajnr, @ronsims2, @Miked9995, @matteo-di-iorio


Styling the map

Hi,
I am trying to change the colors on the map, but whenever I set a custom locationClassName the clicked countries are surrounded with a large rectangle instead of the country borders.
How is it possible to style colours etc without changing the functionality of the map?

Hello,
I think the rectangle around the clicked location is due to the default styles of the browser when an element is focused.
You can disable it with :focus { outline: 0; }, but you should use another way to indicate which element is focused for accessibility reasons.
Here is how it is done in the default provided styles.

@ergunpp if your issue is not fixed, feel free to re-open it.


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/perceptualdiff-feedstock#2.


'compute' can throw for user using ldap

Original issue https://github.com/microsoft/vscode-remote-release/issues/9649#issuecomment-2015267838
Here, https://github.com/cyjake/ssh-config/blob/162eaa36ad7a0ffce0a463322e50a1633f9bd478/src/ssh-config.ts#L172C15-L172C26
os.userInfo can throw for some users https://nodejs.org/api/os.html#osuserinfooptions
But it looks like User is optional here, or may not be needed, what do you think?

can process.env.USER be used as a fallback? otherwise I'd have to add a asynchronous whoami call, which might impose more change

Probably, but I'm not sure of the significance of having the username here.

whoa, the commit references looks overwhelming, sorry about that, was fighting with code coverage (yet still failed). The username is needed to calculate Match directives (might be referenced in the criteria).
i'll release a patch version tonight.


Npm launch

Modified "name", "author", "keywords" and "repository" "url" in package.json to push node module to npm.  Shows live as a package on npm, found here: https://www.npmjs.com/package/Astronomer

Disregard


Fix incorrect handling of cookies across client group changes.

Problem
Replicache cookies are shared among client groups. In certain cases, you can see a new client group with a cookie != null. In particular this happens when the set of mutators is changed. Replicache spawns a new ClientGroup because pending mutations can't be shared across ClientGroups that don't have the same mutators. But Replicache reuses the existing client view (and cookie) in that case to avoid re-downloading the world.
todo-row-versioning forgot this can happen and assumed that cookies were always per-client-group. This had two consequences:

In this upgrade case, the prev cookie would not be found, resulting in a fresh download.
In this upgrade case, the cookie would reset at zero, causing Replicache to complain and drop the pull response.

Solution

As cookies can be shared across ClientGroups, they need to be scoped by the creating CG. Expand the cookie to include the creating CG.
Cookies still need to be ordered per-ClientGroup however, so use the special order field that cookies support, so transmit cookie as {order: $cvrVersion, clientGroupID: $clientGroupID}.
Rather than initializing ClientGroupRecord.cvrVersion to zero, initialize to a null sentinel. In pull, if base ClientGroup's cvrVersion is null, set the next cvrVersion to the incoming cookie's order field if one exists, otherwise zero as before. This ensures for each client group cookies only increase.

Testing
Manually tested by changing mutators to cause a ClientGroup change and observing the logging on both client and server.
Before, when doing this I observed an error on the client about the cookie going down. After I don't oberve this error.
Also, before I observe on the server in this case the prevCVR is not found, but after it is found.

reviewing this now

Seems like these docs need a small update to cover this: https://doc.replicache.dev/strategies/row-version#pull


Overlay view sharing depth data with the main one

Is there any way to render a vew on top of another one while still using the depth buffer generated by the first one?
The use case is this: I render a view containing my main scene and I want to overlay some debug helpers (wireframe graphics) for lights and selected object in a secondary view. However, right now the secondary view cannot share the depth buffer with the first one - or I could not find a way to do so - and my wireframe helpers don't get occluded properly.
The reason for doing it like this and not rendering the wireframe things in the main view is because I don't want them processed by the post effect.
Thanks

You should be able to do this by disabling the depth clear. @pixelflinger can give you more details.
Note however that you don't need a second view necessarily. If the camera is the same, you can simply use layer masks to hide/show a bunch of objects easily. We do this in our (terrible) sample apps. If you look inside libs/filamentapp, you'll see we use layers/layer masks to show/hide debug renderables.

Actually there is no way to do this at this time. A new depth buffer is allocated for each view.
There is one special case where you can probably achieve this: if you disable post-processing for all views, then the depth buffer can probably be shared between the views.

Is there any strong reason not to expose the depth buffer of the view so that it can be shared with other views?
I guess that internall all rendering is done in a HDR render target with a depth attachment and the post effects are used to 'resolve' this into the actual view render target that doesn't have nor need a depth buffer, right?
The initial depth buffer is still very useful for several techniques - like mixing a 2D UI view with the 3D scene while taking the depth into account to do some occlusion.

Currently, views are very separate from each other, there is no state maintained between calls to render().

We generally discard the depth buffer to save bandwidth. In order to share it with future calls to render(), we would need special apis to keep it around.

Views can also have different sizes, positions and scaling options, which all affect the depth buffer.

So as your can see, there are many problems to solve before we can allow this.

I understand, if depth were to be shared it would need to be stored instead of discarded. I assume that for some post effects - like depth of field or SSAO you do store the depth buffer.
Sharing would also work only if the resolution is compatible - and I think there are other constraints, in OpenGL ES at least where only come combinations of buffer formats are compatible, even if each individually is renderable and needs to be checked with glCheckFramebufferStatus.
Right now it is possible to attach arbitrary attachments to a render target the same caveat applies - the need to be the same size, etc.
I think that exposing an api to configure the store operation (Discard or Store) for the depth buffer and exposing the depth texture in the view would allow depth sharing between views. Of course, I'm saying this without knowing the filament implementation details.


Invalid tool_choice being passed to ChatLiteLLM

Description: Invalid tool_choice is given to ChatLiteLLM to bind_tools due to it's parent's class default value being pass through with_structured_output.
Issue: #28176

@efriis

@efriis any updates please

@ccurme I verified each of the Providers and OpenAI is the only exception for when tool_choice is any. Therefore I have changed my code to account for this i.e switch to required if the model is from OpenAI. Also if it is a bool value than in case of OpenAI it switches to required as well.

@ccurme  To verify that call is actually coming from OpenAI, given ChatLiteLLM I could only use model or model_name

@ccurme  does this look good to you?

@ccurme

@ccurme Can this be reviewed and merged please if it works - I am facing the same issue as well when trying to invoke tool in OpenAI from langchain with ChatLiteLLM

@ccurme


[regression pipeline]add git action to trigger teamcity pipeline 0216

Proposed changes
Problem summary
Describe your changes.
add git action to trigger teamcity pipeline, it can trigger regression pipeline by specific comment.like buildall 、p0、 p1、 external、 feut、 beut
Checklist(Required)

[ no] Does it affect the original behavior
[ no] Has unit tests been added
[ no] Has document been added or modified
[ no] Does it need to update dependencies
[ yes] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

buildall


Update Razor to 7.0.0-preview.23410.1

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1868418

Should this target the release branch?

/azp run


Fix: Adding hosting-mode to valid input list

Details
This PR adds hosting-mode to the valid list of inputs for GH Action.
Motivation
During the last release validation, @lisli1 found an issue where hosting-mode was not recognized as a valid input, preventing GH Action from performing an accessibility test on the project.
Context
hosting-mode was not added to the list of valid inputs on the Action pipeline, causing configuration problems when set.
This PR exclusively affects GH Action, ADO Extension is not impacted.
Pull request checklist

[n/a] Addresses an existing issue: Fixes #0000
[n/a] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[x] Ran precheckin (yarn precheckin)
[x] Described how this PR impacts both the ADO extension and the GitHub action

Codecov Report

Merging #1231 (965a157) into main (70c2ef5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   89.84%   89.84%
=======================================
  Files          64       64
  Lines        1586     1586
  Branches      199      199
=======================================
  Hits         1425     1425
  Misses        161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c2ef5...965a157. Read the comment docs.


A slightly faster nsieve C++ entry

Please also make changes to bench_cpp.yaml accordingly and make sure tests pass locally

Updated the yaml, the test (for nsieve/cpp) is passing.

Thx


Organize coding style

As title, this issue is same as this issue.

Yes, it has none at the moment because CS is kind of a secondary nice to have and not high on my priority list. I consider to use PHP CodeSniffer with the Doctrine coding style in the future.

PHPCS was introduced a few months ago.


Fix get - combined cache

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[SQL] az sql midb log-replay start: Add --storage-identity parameter

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

SQL

SQL

/azp run

@evelyn-ys can you help with review? Thanks

Sorry I have to move this PR to next release milestone

@evelyn-ys pls review again

@evelyn-ys can you please merge this PR?

/azp run

@wangzelin007 Can you help merge this PR?