Invalid value: "cluster-name-c-xx-rs-cwn4m_2022-03-24T20:07:42Z.zip-s3" error during etcd snapshot on RKE2 cluster

Rancher Server Setup

Rancher version: 2.6head - 07ee596
Installation option (Docker install/Helm Chart): docker install

Information about the Cluster

Kubernetes version: v1.23.8+rke2r1
Cluster Type (Local/Downstream): AWS Node driver - 1 node all roles

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) admin

Describe the bug
RKE2 cluster - S3 etcd snapshot issues
To Reproduce

Deploy a 1 node RKE2 cluster wth S3 enabled etcd snapshots

When the cluster comes up Active, take a snapshot on the cluster

Result
Error Logs:

Also Error in Rancher logs:

2022/07/17 15:21:35 [INFO] [snapshotbackpopulate] rkecluster fleet-default/sowmya-4-aws: processing configmap kube-system/rke2-etcd-snapshots
2022/07/17 15:21:35 [ERROR] error syncing 'kube-system/rke2-etcd-snapshots': handler snapshotbackpopulate: rkecluster fleet-default/sowmya-4-aws: error while creating s3 etcd snapshot fleet-default/sowmya-4-aws-c-t9kx4-rs-d24f5_2022-03-25T08:12:42Z.zip-s3: ETCDSnapshot.rke.cattle.io "sowmya-4-aws-c-t9kx4-rs-d24f5_2022-03-25T08:12:42Z.zip-s3" is invalid: metadata.name: Invalid value: "sowmya-4-aws-c-t9kx4-rs-d24f5_2022-03-25T08:12:42Z.zip-s3": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), requeuing

Note:

This does not happen on 2.6.6

Pretty sure this is caused due to a change on K3s/RKE2: https://github.com/k3s-io/k3s/pull/5703 and is not necessarily a regression on the Rancher side.

@sowmyav27 , I don't believe this is a regression as previously we wouldn't even receive any updated snapshots from RKE2 in this situation as there was no fix https://github.com/k3s-io/k3s/pull/5703 present. So Rancher didn't even get to the code that throws this error.

After an offline conversation with @Oats87 this error is seen when there are invalid snapshots in the S3 bucket (snapshots with bad name).

When I used an empty S3 bucket, no errors were seen in Rancher logs.
etcd restore using the created local snapshot does not work

On 2.6head commit id: c47178e
Scenario 1

Deployed an AWS Node driver cluster - 1 node all roles, 1 worker node - v1.24.2+rke2r1
Set ETCD snapshot to S3
After the cluster came up Active, Take a snapshot s1 on the cluster
Deploy some workloads on the cluster
Restore to snapshot - s1 etcd restore from the local snapshot
The cluster goes into Updating state and comes back Active
Verified the workloads are not available on the cluster.

Scenario 2

Deployed an AWS Node driver cluster - 1 node all roles, 1 worker node - v1.24.2+rke2r1
After the cluster came up Active, Take a snapshot s1 on the cluster
Deploy some workloads on the cluster
Restore to snapshot - s1 using all restore from the local snapshot
The cluster goes into Updating state and comes back Active
Verified the workloads are not available on the cluster.

I have been seeing this for a little bit, and wanted to chime in
I have ensured that the s3 buckets do not contain anything strange in them.
2023/05/08 18:40:15 [INFO] [snapshotbackpopulate] rkecluster fleet-default/new-production: processing configmap kube-system/rke2-etcd-snapshots
2023/05/08 18:40:15 [INFO] [snapshotbackpopulate] rkecluster fleet-default/new-preprod: processing configmap kube-system/rke2-etcd-snapshots
2023/05/08 18:40:15 [ERROR] rkecluster fleet-default/new-production: error while creating s3 etcd snapshot fleet-default/new-production-.-s3: ETCDSnapshot.rke.cattle.io "new-production-.-s3" is invalid: metadata.name: Invalid value: "new-production-.-s3": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
2023/05/08 18:40:18 [INFO] [snapshotbackpopulate] rkecluster fleet-default/new-preprod: processing configmap kube-system/rke2-etcd-snapshots

We tried the same, renaming the folder, and when we renamed it back the snapshot worked, but a couple days later the issue starts up again


Add support for responding to multiple event input types

Currently if you want to respond to multiple types of input you need multiple functions and/or multiple binaries. While it is fairly trivial to have one binary and manually handle different input types via things like env variables or CLI flags or multiple binaries that expose different functions, it would be nice to have something in the runtime. A benefit of this could be only one binary deployed but registered for multiple events.
I'm not sure what it would look like, but perhaps something like:
fn main() {
    lambda::Builder::new()
       .add(|input: MyType1| {
         Ok(format!("this is mytype1: {}",  input))
       })
       .add(|input: MyType2| {
         Ok(format!("this is mytype2: {}",  input))
       })
       .start()
}

or just passing multiple functions to lambda::start.
The runtime could then attempt to deserialize input (in order?) and when one succeeds, call the proper closure, otherwise try to deserialize into the next type, and so on.

If I had to do this today, I'd probably use serde's untagged attribute like so:
#[derive(Deserialize)]
#[serde(untagged)]
enum Input {
    Type1(MyType1),
    Type2(MyType2)
}

fn main() {
    lambda::start(|input: Input| {
        match input {
            Type1(mytype1) => {
                Ok(format!("this is mytype1: {}", mytype1))
            }
           .Type2(mytype2) => {
                Ok(format!("this is mytype2: {}",  mytype2))
            }
        }
    })
}

But I can see how a shorthand for this would be more convenient!

Oh, I wasn't aware! That actually looks super convenient already 😄. I'll close and maybe add something to the docs eventually.


Fixed #28210 -- Fixed Model._state.adding on MTI parent model after saving child model.

https://code.djangoproject.com/ticket/28210

Yes, it's also a regression in 38575b0.


No module named 'dummy_thread'

Hello,
I am trying to make a submission through kg however, whenever I run a command, I seem to get No module named dummy_thread'error.   However if I usekg config` it displays config details.
Thanks.

What's your Python version?

I am using Python 3.5.3.

I guess it related with https://github.com/reclosedev/requests-cache/issues/83#issuecomment-310245006 .

Fixed via https://github.com/floydwch/kaggle-cli/commit/b7456412ee7c1be6a2fb53a23969a093c279c079 .
And you have to remove the browser cache which is stored at ~/.kaggle-cli/browser.pickle .

Oops, it still exists.

In the meanwhile, there is a workaround: rm ~/kaggle-cli/browser.pickle when you changed your Python from 2 to 3.

Just use another approach to handle the pickle exception. Fixed via https://github.com/floydwch/kaggle-cli/commit/ddb82e52f61b704c7e318237dfd7bfbead83b180 .


Info Log level option not being respected

Given log levels should be:
TRACE < DEBUG < INFO < WARN < ERROR < FATAL
By default log-level is Info but debug messages are included. Also explicitly setting log-level=Info also includes Debug messages.
Curiously, it was recommended on the previous testnet to run with -log-level debug to remove the following Info messages so it seems the log levels are not being respected?
2020-09-18 23:38:02 UTC [Info] why u fail to validate :(

After some more testing starting with -log-level Info it seems that Debug lines are not included in stdout but are included in coda.log. Following the daemon output, only log level >= Info are printed (with the exception of a couple of debug messages from the verifier and prover logs sneaking in).
However, my coda.log is full of these:
{"timestamp":"2020-10-15 18:02:29.494000Z","level":"Debug","source":{"module":"Libp2p_helper.Go.net/identify","location":"(not tracked)"},"message":"12D3KooWCtMRYgZySFy2nzfdtKvHZ7VqPd9qfXNUjRp7Ekbyu73Y received listen addrs for 12D3KooWCfcEtnAzoPGPaiuG7yT9PmiD9XYRzVsw4zy9M7x8wWff: [/ip4/<IP_ADDRESS>/tcp/10019 /ip4/<IP_ADDRESS>/tcp/10019 /ip4/<IP_ADDRESS>/tcp/10019]","metadata":{}}

So this is the intended behavior so closing this issue


Need details of provisioning timer job

Hello, can you please, please add more detail on the timer job which does the actual OneDrive provisioning? How long might it take to provision?  We are scripting onboarding and need to configure the OneDrive of the new user but presumably the OneDrive needs to exist before we can configure it.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e37f6a5c-b620-229d-a0dc-289960c6806c
Version Independent ID: 71d9f7bc-6ef3-8fd6-bb7f-236a902bce2a
Content: Request-SPOPersonalSite (Microsoft.Online.SharePoint.PowerShell)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Request-SPOPersonalSite.md
Product: sharepoint-server-itpro
GitHub Login: @trent-green
Microsoft Alias: trgreen

Hello @jmuehlenbein
How are you?
I would recommend checking if the requested personal site exists to continue your configuration, timer jobs runs vary so it is not an exact thing that can be documented, unfortunately.

@get-itips Thank you very much for the contribution and sharing this explanation. @jmuehlenbein Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


use ":"

@jpsnover : Thanks for your contribution to the Azure documentation! The author, @ScottNapolitan, has been notified to review your proposed change.


[ListItem]  Property 'component' does not exist on type

The example from the docs for composing react-router and material-ui Lists does not work without compile errors. (using my project's version of dependencies which are supposed to be compatible with material-ui)
I found some related issues to this, but they don't seem to be for the ListItem component.
Related:

https://github.com/mui-org/material-ui/issues/15827
https://github.com/mui-org/material-ui/issues/16846

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔

There should be an example of how to use material-ui and react-router together that doesn't have compile errors.
Or... If there's specific versions that are required, they should be documented.
Steps to Reproduce 🕹

Note: It takes a few minutes for the type error to show up in the browser editor.
https://codesandbox.io/s/material-demo-coinv
Context 🔦

It seems like this should be a very common use case. People trying to build a nav which is a list of links. Maybe I'm missing something.
Your Environment 🌎

Tech
Version

Material-UI
4.4.3

React
16.8.6

TypeScript
3.4.4

react-router-dom
5.0.1

The error message is wrong, the actual error is that NavLinkProps requires the prop to to be specified.
Changing your code to something like this gets rid of the error
const RenderLink = React.forwardRef<HTMLAnchorElement, NavLinkProps>(
  (itemProps, ref) => {
    const { to, ...other } = itemProps;

    return <NavLink to={to} {...other} innerRef={ref} />;
  }
);

function ListItemLink(props: ListItemLinkProps) {
  const { icon, primary, to } = props;

  return (
    <li>
      <ListItem component={RenderLink} to={to}>
        {icon ? <ListItemIcon>{icon}</ListItemIcon> : null}
        <ListItemText primary={primary} />
      </ListItem>
    </li>
  );
}

@Graham42 Most demos should be available in TypeScript as well. The demo in question has one and the fix from @merceyz is applied: https://material-ui.com/guides/composition/#ListRouter.tsx

The error message is wrong
Well that's extremely frustrating....

Thanks for your help.
I guess this is a typescript bug?

I guess this is a typescript bug?

@Graham42  Your codesandbox link uses an outdated version. Check the new one from my comment in https://github.com/mui-org/material-ui/issues/17645#issuecomment-536893268

I guess this is a typescript bug?
I was referring to the error message being wrong.

I was referring to the error message being wrong.

It's more a chicken-egg problem. Given the props: the component is wrong BUT given the component: the props are wrong. Since the component is part of the props it's ambiguous where the error originates


Virustotal reports Viruses with both .exe and .zip (alpha 5)

Hi, Virustotal.com is reporting both the .exe and the .zip version have viruses.
Could you upload them there and look at the output and see if there's any merit to what they are saying?
Thanks!

That's a false positive.  These are beta/alpha drivers that don't have proper signature.  When uploading you'll see that very few scanners actually report something.  Normally with 0 day alpha stuff in general you'll see this.  It's quite normal.

Rescanned the zip, and no issue reported - https://www.virustotal.com/gui/file/9f579ddbaa74cd7010b95552f1d3f1180e062b179c0145b9bfc4fb1d45089ce4/detection

Awesome - can't wait to try this - are there instructions anywhere on how to install from the zip file?
(I understand unzipping, but don't know where to put these and how to get them registered in the needed places for SteamVR to pick them up.)

Anti-virus complains that many times.
#141 #190
exe is still detected as an adware.
@jackfruh Extract anywhere you want. ALVR installs driver automatically when starting StreamVR. You can also manually install by "About" tab.
Please make sure extract directory name doesn't contains non-ascii character.

I got it working - this thing is incredible.
What can I do to help its development?
When I unzipped the files, there were a few batch files I ran to configure steam to use the driver - is there somewhere I can submit a guide to share with others?
I tried the game Moss on steam, and I once I got the menu up, I couldn't 'click' anything.
Is there a guide for mapping controls?
Also the graphics quality was fantastic as it was coming from my PC, but image was a bit jumpy, as if the location information was delayed making the round trip to the PC - I'm going to go buy a new 5ghz wireless access point to see if that helps, any other tips/guides for performance?

Jack

5Ghz is better, and you need to be in the same room as the router.  If you already have one but aren't in the same room,  give that a try before spending more money.
But it seems there could still be some framerate related issues, possibly stemming from the Nvidia (?) driver involved.  So that wouldn't be something ALVR could fix.  A TBD at the moment.  Just guessing here.

I use a 5ghz ap connected directly to my PC via a USB NIC.    If you get one, just make SURE it has a GBE port on it.  Many 5ghz APs have just 10/100 since they use a weaker processor in it.  The GBE ones will be much stronger and reduce transport latency as much as possible.


signal-desktop not using wayland when available

If signal-desktop is started without args it runs under Xwayland, starting with the magic flags --enable-features=UseOzonePlatform --ozone-platform=wayland will prevent this.
Is there a way for it to determine the presence of a wayland session automatically?
https://github.com/NixOS/nixpkgs/blob/5e4c2ada4fcd54b99d56d7bd62f384511a7e2593/pkgs/applications/networking/instant-messengers/signal-desktop/generic.nix#L116

We had originally disabled it in #222163 but I suppose we could test again for any changes? (given that new versions are released rather often)

I recently tried signal again with native wayland but it still seems to crash after a while.

Interesting, I haven't seen that yet but certainly better to be safe. Is there a way to run it with crash logs so I can report upstream if/when it happens to me?

this appears to be resolved


Equivalent of nonassoc precedence

I want to be able to parse expressions like -5 and -(2 + 3 * 4). At the moment, I'm doing this with two separate rules, but since -5 is the same as -(5) I want to be able to use the same rule for both situations as the parentheses in -5 are implicit. In PLY, there is the nonassoc precedence, so I was wondering if such a thing also existed in RPLY?

Here's a test case with nonassoc:
https://github.com/alex/rply/blob/19a9e08c486b2723a2e2378df6edb6a26e2df4a5/tests/test_parser.py#L245

I did this in my parser, and it sees the integer token 5 and complains because it was expecting a parenthesis. Have I missed something?
         precedence = [
                     ('left', ['PLUS', 'STAR', 'SLASH']),
                     ('nonassoc', ['MINUS'])
                     ]

        @self.pg.production('expr : MINUS LEFT_PAR expr RIGHT_PAR')
        def uneg_expr(p):
            return UNeg(self.builder, self.module, p[2])

I'm afraid I don't see how nonassoc would help making -(5) equivalent with -5. Have you achieved this using PLY?

I've not achieved it yet, I'm trying to achieve it at the moment.


Are sbt-revolver configuration README.md examples correct after recent autoplugin changes?

Could someone in the know take a look at the sbt-revolver configuration examples in
the light of recent autoplugin changes?
Specifically the example
mainClass in Revolver.reStart := Some("com.example.Main")
Using sbt-revolver 0.8.0, sbt 0.13.11 & scala 2.11.7, that example failed in
my build.sbt with a complaint about reStart not being a member of Revolver.
(I believe/suspect that Revolver became RevolverPlugin, along
with other changes, during the autoplugin transformation.)
After much thrashing, I found that the following code line worked
for me as described.
mainClass in reStart := Some("yyy.zzz.SubmitToSpark")
I apologize in advance if there is some obvious sbt wizardry I missed.
I am probably neither the first nor the last to note that sbt has a step
learning curve.
Most importantly, thank you for sbt-revolver. It is saving me time already.

Thanks, @LeeTibbert. Very good point. We need to go through all the code examples and see if they still work or fix them otherwise.


Improved JTAG connector

Improved JTAG connector for RV901T via JP3 header, as proposed in the issue #21

Thanks!


WIP adds a new endpoint.

Ike Plugins (test-keeper)
Thank you @hemanik for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

/run work-in-progress

Ike Plugins (work-in-progress)
Thank you @hemanik for this contribution!

It appears that this PR is still in progress and cannot be merged.
The plugin adds a security check to prevent admins and reviewers from accidentally merging a PR that is still in progress.
If you are the author of this PR and you are sure that the PR is ready for review and merge then remove the "work-in-progress" prefix or label from the PR to unblock it.
For more information please head over to official documentation. You can find there how to configure the plugin.


Translation to Python

There is a version of this for python, but it does not work well with windows and several of the packages are missing. I know it would be a lot of work, is there anyway that I could use this to work with python?? I ask because I am not well versed in Golang, but would love to make this more accessible

There is a version of this for python

Could you send a link? I'm looking for this as well.

@unixpickle would you have any idea about how to export this so I could use this with cgo for python for Home Assistant?

There is a version of this for python

Could you send a link? I'm looking for this as well.

It isn't worth it, it is super hard to use. I ended up buying a new bulb entirely


Added ability to change password during auth warning if pm enabled

There didn't seem to be a way to allow users to change their password outside of the server spitting out a "must change" response. This PR adds a button on the authentication warning screen to change their password if pm is enabled.
Sorry for the extraneous edits to messages.properties, my editor killed trailing whitespace when adding screen.button.changePassword=Change Password. I figured I'd leave them since cleaner is better?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Marcus Watkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Excellent.
Before merging, let me ask: is this not what you need?
https://github.com/apereo/cas/blob/master/webapp/resources/templates/fragments/loginform.html#L89

That allows them to reset it by going through the reset flow (getting an email, answering questions, etc). But most of the time our users change it during the warnings like "Your password will expire in X days," before it actually expires, to avoid the whole security question rigmarole.

Ah of course. I failed to see the changes were in loginMessagesView. Sorry!
PS Could I ask you to reach to me privately either via email or gitter? I do have something I would like to discuss with you and see if that might spark an interest. I am at<EMAIL_ADDRESS>or @mmoayyed on Gitter. 100% optional :)

Sorry for the extraneous edits to messages.properties, my editor killed trailing whitespace when adding screen.button.changePassword=Change Password. I figured I'd leave them since cleaner is better?

Always, and I don't care that much :) All is good.

Coverage decreased (-0.001%) to 43.035% when pulling f50b0ac70d08571d3f8389454ac4abf1b8c7e00b on marwatk:password-warning-change into ec23ef2da277d91fed34798b02034819a307ce36 on apereo:master.


add tests in client/services/code_preprocessors/

[ ] CodePreprocessorDispatcherService.js

[ ] PythonCodePreprocessorService.js

Pr: #227


Add quickstart based on docker

The current quickstart is incomplete and can be a bit frustrating:

you need to install libpq-dev and libssl-dev and this info is not very visible
we need a simple way to feed an index, currently we only provide ndjson file but this does not show the power of what we have built.

I recently tested Loki and I followed the docker-compose install and the user journey was great: Promtail is feeding Loki and a Grafana instance is also started. Everything you need to have a good idea of what you can do with Loki.
For quickwit, we could run Quickwit with docker and feed it with its own log. Next step will be to feed the index with an OTEL collector.

Already fixed.


Has any event to listen when modal is going to close?

Is there an event that is fired when modal was closed?
Clicking on the button Ok, or Cancel from the onChange function it's ok and changes the value. But when you click outside of the modal, and the modal was closed without clicking on button Cancel our Ok,  i am no longer able to open the modal and select a new date. Help

In Modal from React Native has a event named onRequestClose. Maybe if you find out it works

Hey! I was actually working on a callback for Android when clicking the overlay, plus a different approach for the iOS picker.

And how long do you think it will take to develop this improvement?

@Zonfer just made a couple of updates to both, Android and iOS. Can you check them?

Where? The last release have 20 days old

npm. forgot to update GH tag versions, and the semantic+circle got fucked up somehow. will check it tomorrow after work.


Ability to set env values in nested block

When writing unit tests in repl, it looks like environment values cannot be set. For example, the following code ignores the env-keys change.
(env-keys ["keyset-a"])
(expect
  "This is a test."
  "Success"
  (function-a 1)
  (env-keys ["keyset-b"])
  (function-b 1)
)

In this example, function-b will still be called with keyset-a, since only top-level calls that set environment values are respected. This is also a silent failure, so it's not immediately obvious what happened while debugging.
There are many scenarios in which we want to be able to test a set of actions that need to be performed by different parties. For now, we end up having to write hacks for like building a module just for testing purposes, or re-ordering all of our operations and setting state outside of the expect blocks (which makes for much less readable tests). These hacks have their limitations as well.

Thanks for bringing this up @arjunbaokar -
We'll need to discuss this.

Dupe of #23


[Backport 1.x] Backporting auto release workflow to 1.x

Description
Backporting auto release workflow to 1.x
This workflow automates github releases based on tag, see: https://github.com/opensearch-project/OpenSearch/releases/tag/2.5.0
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #6185 (798c473) into 1.x (a3f95d7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                1.x    #6185      +/-   ##
============================================
- Coverage     77.87%   77.84%   -0.03%
+ Complexity    63434    63384      -50
============================================
  Files          4454     4454
  Lines        275056   275057       +1
  Branches      41176    41176
============================================
- Hits         214206   214126      -80
- Misses        43948    43994      +46
- Partials      16902    16937      +35

Impacted Files
Coverage Δ

server/src/main/java/org/opensearch/Version.java
83.01% <100.00%> (+0.08%)
:arrow_up:

...g/opensearch/index/analysis/CharFilterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rch/index/engine/RefreshFailedEngineException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...ch/transport/ReceiveTimeoutTransportException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...n/indices/upgrade/post/UpgradeSettingsRequest.java
30.00% <0.00%> (-45.00%)
:arrow_down:

...pensearch/transport/NodeDisconnectedException.java
60.00% <0.00%> (-40.00%)
:arrow_down:

...search/aggregations/metrics/ParsedPercentiles.java
46.31% <0.00%> (-31.58%)
:arrow_down:

.../java/org/opensearch/index/reindex/RemoteInfo.java
49.55% <0.00%> (-27.44%)
:arrow_down:

...opensearch/transport/TransportResponseHandler.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...va/org/opensearch/monitor/process/ProcessInfo.java
68.00% <0.00%> (-24.00%)
:arrow_down:

... and 465 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I have no idea why I cannot merge.
@reta could you ack as well?

It seems something is off with the permissions for the 1.x branch and all changes require @reta's approval

It seems something is off with the permissions for the 1.x branch and all changes require @reta's approval

Hm ... not sure why, but I am happy to approve in any case

@andrross oh, I know why, the Github reports that CODEOWNERS file [1] contains errors in first entry, and second entry is myself, this is why :(
[1] https://github.com/opensearch-project/OpenSearch/blob/1.x/.github/CODEOWNERS

@reta #6202 and #6203 should fix this, I think


Problems with chaining the build of several programs with several compilation steps

Hi,
In our Cobol.groovy script we want to process a stream of COBOL programs, and building each program requires several steps:

MVSJob.start()
MVSExec.exetute() for COBOL pre-compilation MDECK(NOCOMPILE) option to expand COPYBOOKs ; SYSMDECK output is for DB2 pre-compilation
MVSExec.exetute() for DB2 pre-compilation: we don't want to use the DB2 coprocessor; SYSCIN output is for COBOL compilation
MVSExec.exetute() for COBOL compilation ; SYSMDECK is not used but mandatory, SYSLIN output is for linkedit
MVSExec.exetute() for linkedit
MVSJob.stop()

We encounter many problems with BPXWDYN which manages the file allocations of each step (MVSExec / new DDStatement() ).
These problems come from the fact that the COBOL compiler is called twice for each COBOL program iteration, and that the DDNAMES are therefore used twice, and in particular problems with the SYSMDECK ddname.
First problem:
For a file created in a MVSExec.exetute() to be retrieved in a next step, it seems imperative to use the .pass(true) option when creating the file.
This works well for first program iteration, but failed for second program iteration: BPXWDYN error 1702 on SYSMDECK ddname.
The problem is that the declared .pass(true) file remains allocated and on the next program iteration.
The solution found was to add the REUSE option when creating the SYSMDECK file.
In your Cobol.groovy sample, you also use .pass(true) on the SYSLIN ddname of the COBOL compilation, without using REUSE, and this script works for us...
Second problem:
After solving firts problem, on the iteration for the second COBOL programs, the Db2 pre-compilation step failed because the SYSMDECK created during the COBOL pre-compilation is unusable: BPXWDYN error 1708.
We have not yet managed to find the origin of the problem.
Apparently it is the SYSMDECK created at the real COBOL compilation stage of the first iteration, which must interfere with the SYSMDECK created at the COBOL pre-compilation stage of the second iteration.
Problems don't appear with other COBOL compiler ddnames, they're not declared .pass(true) (except SYSLIN but we haven't managed to do 2 full iterations yet, and it's possible we have also a problem with this file).

Hi @FALLAI-Denis , thanks for reaching out.
with the .pass(true) option, temporary datasets remain allocated for the context of the MVSJob execution. There is no need to add the DDStatement again for any following MVSExecs.
If you would like to understand what happened under the covers, I am recommending to use the log4j2 setting and activate tracing to gain all allocations including frees.
Are you familiar with the DDNames API to pass temporary datasets to different DDnames in subsequent steps? The  Assembler.groovy has this logic, while it has the cics + db2 precompile translators in it.
You can find a sample of the db2 precompile step which also uses the DDNames API in my fork of zAppBuild.
While you are planning to invoke the Compiler twice ( which I have not done yet ), which require the same DDNames, what about running two MVSJobs, so that the initial allocations are freed after the execution of the Cobol pre-compilation step? This works as long as you store the intermediate expanded source on a dataset.
For dynamic allocation issues - I assume you are aware of the IBM Docs page on DYNALLOC

Hi @dennis-behm
Thanks for your answer.
with the .pass(true) option, temporary datasets remain allocated for the context of the MVSJob execution. There is no need to add the DDStatement again for any following MVSExecs.
I consulted Assembler.groovy, I don't understand how setDdnames works... apparently it allows to change the ddnames expected by the program to reuse the ddnames of a previous step? (IBM DBB API documentation is not very verbose).
Is there any relation to the ddnamelist as described here Starting the compiler from an assembler program?

Yes, it allows to change the dd names. The link you found is correct, but I don't know how this is done in the background of DYNALLOC.
I am typically using this table in the SCLM redbook, Page 747.

Thanks, I also found ddnamelists in reference manuals:
Db2 V12.
https://www.ibm.com/docs/en/db2-for-zos/12?topic=procedures-dd-name-list-format
Cobol V6R1 to V6R4.
https://www.ibm.com/docs/en/cobol-zos/6.4?topic=zos-starting-compiler-from-assembler-program
HLASM V1R6.
https://www.ibm.com/docs/en/hla-and-tf/1.6?topic=zos-invoking-assembler-dynamically
Binder z/OS 2.4.
https://www.ibm.com/docs/en/zos/2.4.0?topic=facilities-invoking-binder-program-from-another-program
Do we have to use this technique to pass files between MVSExec steps?
It's complicated... and not natural compared to the habits taken with the JCL.

Hi @FALLAI-Denis, this is for temporary datasets only, which need to be passed in under an alternate DD name. If you use persistent datasets, you might not need the alternate DD name, while you just point tot he dataset name rather the temporary allocation.
In JCL you would have provided a &&TEMPOBJ to refer back to the previous different temporary dataset allocation. However in the build scripts here, you can manage multiple variations in a single script - which leads to a lot of flexibility, but also a more complex setup.

@FALLAI-Denis , I think Gil has worked with you to implement the above steps using the ddname APIs to pass on temporary files between the steps using the DYNALLOC macro.  If you would like to share the solution here, this would be highly welcome by the community.

Hi @dennis-behm,
Yes, I work with Gil P and other people from IBM France on the implementation of IBM DBB on our site. They do a good job.
Our technical context is complicated.
Our problem concerned the implementation of a concatenation "before": reuse the file written on SYSLIN ddname at the COBOL step, but use it by concatenate it behind a new file always on the SYSLIN ddname of linkedi stept, which is not planned in the API. But in fact the solution was found by playing with the file allocation list of the COBOL step by writing on another ddname than SYSLIN, which then makes it possible to freely use the SYSLIN ddname at the linkedit step.
This difficulty is not attributable to Zappbuild, but to the IBM DBB API.
Once it has been understood that IBM DBB actually made use of JZOS, which itself makes use of BPXWDYN, and once it has been understood that everything was happening in a single task and that the MVSExec object was actually wrapper to CALL a program within this single task, and that the files allocated at a MVSExec step remain potentially allocated for the following MVSExec steps, things become clearer, but not necessarily simpler.
This internal behavior of the DBB API is not documented... or I could not find this documentation, not even in JZOS. Fortunately I have a little experience of BPXWDYN which I used to do real dynamic management of files in COBOL processing, (decide on the file name at runtime), which allowed me to understand how it works from IBM DBB.
And we achieve our goals because the precompilation, compilation and linkedit utilities allow you to substitute the ddnames at runtime. If we used other programs, including programs developed by ourselves, I think we would not be able to manage these substitutions of ddnames.
You have to lose all your habits related to classic JCL and completely rethink the sequence of steps in the compilation / linkedit process according to the IBM DBB API.
I think there is an effort to be made on the documentation of the operation of the IBM DBB API, with real use cases.

Hi,
Solved by adaptation of our COBOL.groovy script.


 It's a local testing instance anyway, not reachable from outside
log:
  level: info

runner:
  file: /data/.runner
  insecure: true

/data/.runner
{
  "WARNING": "This file is automatically generated by act-runner. Do not edit it manually unless you know what you are doing. Removing this file will cause act runner to re-register as a new runner.",
  "id": 2,
  "uuid": "...",
  "name": "MyRunner",
  "token": ".....",
  "address": "https://MacBook-Air-MM/",
  "labels": [
    "ubuntu-latest:docker://gitea/runner-images:ubuntu-latest",
    "ubuntu-22.04:docker://gitea/runner-images:ubuntu-22.04",
    "ubuntu-20.04:docker://gitea/runner-images:ubuntu-20.04"
  ]
}

Repository Setup
Simple Shellscript that would throw some shellcheck issues
#!/bin/bash

# 1. Command substitution in a variable (style level)
ls_output=`ls` # SC2006: Use $(...) notation instead of legacy backticks `...`.

# 2. Unquoted variable (info level)
echo $ls_output # SC2086: Double quote to prevent globbing and word splitting.

# 3. Unused variable (warning level)
unused_var="This variable is not used anywhere" # SC2034: unused_var appears unused. Verify use (or export if used externally).

# 4. Attempt to use an undefined variable (warning level)
# echo $undefined_var # SC2154: undefined_var is referenced but not assigned.

# 5. Syntax error (error level)
# for ((i=0; i<5; i++)) # SC1073: Couldn't parse this ((...)) command. Fix to allow more checks.

.github/workflows/shellcheck.yml
name: ShellCheck

on:
  push:
    branches:
      - '*'
  pull_request:
    branches:
      - '*'

jobs:
  shellcheck:
    name: ShellCheck
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        env:
          GIT_SSL_NO_VERIFY: 'true'
        uses: actions/checkout@v2

      - name: Run ShellCheck
        uses: ludeeus/action-shellcheck@master
        with:
          version: v0.10.0
          severity: warning

Expected behaviour
On Github this exact Repository and Workflow works flawlessly.
Actual behaviour with gitea and action-runner
/var/run/act/workflow/1-composite-1.sh: line 2:   125 Killed                  "/var/run/act/actions/ludeeus-action-shellcheck@master/shellcheck" --version

Gitea Version
1.22.0
Can you reproduce the bug on the Gitea demo site?
Untested
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
See Description
Database
SQLite

I think this is because the `` action does not support arm64

Close since this is not a Gitea bug


Removed Redundancies ConfigSection.tsx

I've made some changes focus on improving code clarity, consistency, and readability without altering functionality. These changes were listed below -
Consistent Formatting: Added missing semicolons and ensured consistent spacing and alignment for better readability.
Clearer Labels: Renamed switch labels (e.g., "Email" to "Enable Email") to clarify their purpose.
Removed Redundancies: Removed the unnecessary className="" from the "Copy Config" button.
Improved Structure: Cleaned up JSX formatting for better clarity, particularly for motion and Switch components.
Enhanced Readability: Ensured consistent formatting in the CopyIcon component for maintainability.
Description
Please include a brief summary of the change.
Type of change

[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist

[x] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[x] My changes generate no new warnings
[x] I have reviewed my own code
[x] I have filled out all required sections
[x] I have tested my changes on the preview link
[x] Approver of this PR confirms that the changes are tested on the preview link

Thank you for your contribution. At this time, Reown does not generally accept these types of contributions for security reasons.


[RFR] Rich example

[x] Improve the complexity and test data of the bundled blog example
[x] Introduce and document View.fields() to allow fields reusability

Weird, protractor tests don't run anymore on Travis... Any idea @manuquentin @jeromemacias?

Got it: the problem comes from minification. I test the constructor name, uglify breaks it.


commands list minor bug

There is a following bug when running legit without any parameters:

Which version do you use?
I have tested with the develop branch, and there is no duplicate sync entries in help message.
Unknown command output is not accurate
(either not considering legit without arguments not an error,
either report missing command).
This has been fixed in fab5c8f (not considering as an error).


cmake(GUI) on win64 reports config error: no cmake_lists.txt in lastools extracted path

cmake reports there isn't any CMakeLists.txt file included with the extracted lastools folder and I have checked every subfolder. There are makefiles included.
When I downloaded it previously I believe it did generate.

I'm getting this error as well. How did you resolve it?


[Feature Request] Is there any plan to support "h2c" ?

What kind of issue is this?

[ ] Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use Stack
Overflow. https://stackoverflow.com/questions/tagged/okhttp

[ ] Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests
get fixed. Here’s an example: https://gist.github.com/swankjesse/981fcae102f513eb13ed

[x] Feature Request. Start by telling us what problem you’re trying to solve. Often a solution
already exists! Don’t send pull requests to implement new features without first getting our
support. Sometimes we leave features out on purpose to keep the project small.

Dupe of #1019

Sorry and thank you.


Console error "Cannot read properties of undefined (reading 'file')" happening at random times throughout the day

I cannot figure out how to reproduce this but I see this several times a day at different random times. It seems to happen most consistently when I run a Templater script that creates a new file with something like this: let newFileObj = await this.app.vault.create(newFilePath, pageContent);
But I have no clue if that is the culprit or not. I also find these log errors randomly throughout the day when I go to check my console for something else.

@nothingislost I think I have gotten to the bottom of the cause of the errors and pinpointed it in the code. I don't quite know how to best fix it but this Loom video walks you through the problem as well as my hunch for the cause of it (search query rendered views seem to not be being cleaned up and duplicates created with broken property for parent property).
https://www.loom.com/share/1b5f1ad2a2d94bb7860a8ada8df09a9d

Specifically it is being caused by this (parent property Null when "views" aren't cleaned up):
https://github.com/nothingislost/obsidian-query-control/blob/93add4bb67e0b189fa2914ee25c9025018f52c81/src/search-renderer.ts#L54-L56

Here I logged it showing when the issue occurs the parent property on this.match is missing.

Again though, all of the details are included in my Loom video above.

So it looks like changing getFile() to the following stops the error but I think there is still a question of why when using the show more/less context button it seems to not cleanup old entries and they continue to multiple everytime you press the button (memory leak).
getFile() {
    return isFifteenPlus ? this.match.parentDom.file : this.match.parent.file;
}

Based on the stack trace of the error it looks like this (screenshot below from Obsidian main app code) is where it is stemming from in the code. It seems to do with resolving links which is interesting. It also seems like in my further testing that these errors only arise when you have a search query result that has a [[link]] in it and then must be calling this resolveLinks on file change.

After further research and diving in, I believe the "duplicates" (memory leak) is being caused by this section where adding new components for markdown rendering the results and it does not cleanup the old components. So when you flip from less context to show more context, it leaves the old items behind... and vice versa. And as you continue to toggle the show more context it duplicates them every time which can grow pretty quickly.
https://github.com/nothingislost/obsidian-query-control/blob/93add4bb67e0b189fa2914ee25c9025018f52c81/src/main.ts#L457-L467

Ok @nothingislost here is code you can run directly in the console log to find the "leaked" (leftover) components and also remove them. Clearly this isn't the solution but hopefully it gives you what you need to identify the real problem and where the best place in the code of the plugin is to clean these up. The problem is that it isn't clear to me where/how you can match up old components to their new ones. So instead need to test whether components are connected to the DOM or not (but I have a feeling there are issues with this logic as well).
let allLeafChildren = app.workspace.activeLeaf.view._children;
allLeafChildren.forEach(eachLeafChild => {
    let childType = "";
    if(eachLeafChild.dom) {
        if(eachLeafChild.dom.el.classList.contains("mod-global-search")) {
            childType = "Global Search View";
            console.log("Leaf Child Component Type:", childType);
            const bRenderMd = eachLeafChild.dom.renderMarkdown;
            console.log(`${childType} renderMarkdown on:`, bRenderMd);
            const domEl = eachLeafChild.dom.el;
            console.log(`${childType} isConnected:`, domEl.isConnected);
            const rendComponent = eachLeafChild.dom.parent.renderComponent;
            let removeComponents = [];
            rendComponent._children.forEach(eachChild => {
                console.log(`${childType} child isConnected:`,eachChild.containerEl.isConnected);
                if(!eachChild.containerEl.isConnected) {
                    removeComponents.push(eachChild);
                }
            })
            let remCtr = 0;
            removeComponents.forEach(eachComp => {
                //console.log(eachComp);
                rendComponent.removeChild(eachComp);
                remCtr++;
            })
            if(remCtr > 0) { console.log(`Removed ${remCtr} ${childType} old stale components`); }
        } else if(eachLeafChild.dom.el.classList.contains("search-result-container")) {
            childType = "Embedded Search Query Component";
            console.log("Leaf Child Component Type:", childType);
            const bRenderMd = eachLeafChild.dom.renderMarkdown;
            console.log(`${childType} renderMarkdown on:`, bRenderMd);
            const domEl = eachLeafChild.dom.el;
            console.log(`${childType} isConnected:`, domEl.isConnected);
            const rendComponent = eachLeafChild.renderComponent;
            let removeComponents = [];
            rendComponent._children.forEach(eachChild => {
                console.log(`${childType} child isConnected:`,eachChild.containerEl.isConnected);
                if(!eachChild.containerEl.isConnected) {
                    removeComponents.push(eachChild);
                }
            })
            let remCtr = 0;
            removeComponents.forEach(eachComp => {
                //console.log(eachComp);
                rendComponent.removeChild(eachComp);
                remCtr++;
            })
            if(remCtr > 0) { console.log(`Removed ${remCtr} ${childType} old stale components`); }
        }
    } else if(eachLeafChild.backlinkDom) {
        childType = "Backlinks Section";
        console.log("Leaf Child Component Type:", childType);
        const bRenderMd = eachLeafChild.backlinkDom.renderMarkdown;
        console.log(`${childType} renderMarkdown on:`, bRenderMd);
        const domEl = eachLeafChild.backlinkDom.el;
        console.log(`${childType} isConnected:`, domEl.isConnected);
        const rendComponent = eachLeafChild.renderComponent;
        let removeComponents = [];
        rendComponent._children.forEach(eachChild => {
            console.log(`${childType} child isConnected:`,eachChild.containerEl.isConnected);
            if(!eachChild.containerEl.isConnected) {
                removeComponents.push(eachChild);
            }
        })
        let remCtr = 0;
        removeComponents.forEach(eachComp => {
            //console.log(eachComp);
            rendComponent.removeChild(eachComp);
            remCtr++;
        })
        if(remCtr > 0) { console.log(`Removed ${remCtr} ${childType} old stale components`); }
    } else if(eachLeafChild.type && eachLeafChild.view) {
        if(eachLeafChild.type === "preview") {
            childType = "Markdown Preview (Ignore)";
            console.log("Leaf Child Component Type:", childType);
        }
    }
    if(!childType){console.error("Did not recognize Leaf Child Component:", eachLeafChild)}
})


Using RegExp in grel:string_replace function

I'm hoping you can provide me some guidance on using a regular expression as a parameter to a function to replace (more like substitute) the value of a literal object using a regular expression.
Particularly "Name" in:
  rr:subjectMap [
    rr:template "http://example.com/{Name}"
  ];

I need to slug the "Name" value so the string is URI safe according to our standards. e.g., if value of Name was "Hey Mister Tally M#n" we need the string to be slug'd to "Hey-Mister-Tally-M-n" (we have the regexp that does the conversion properly)
To start, I updated the Name value in student.csv file to "Hey Mister Tally M#n" and attempted to use grel:string_replace the object of foaf:Name with no success. Any help is greatly appreciated.
It would also appreciate guidance on how would I apply the function to {Name} in rr:subjectMap [ rr:template ]
The result I get from the rule/function:
{"message":"Error while executing the rules.","log":"23:02:42.082 [main] ERROR be.ugent.rml.cli.Main               .main(404) - null\n","stack":"Error: Error while executing the rules.\n    at ChildProcess.<anonymous> (/rmlmapper-webapi-js/node_modules/@rmlio/rmlmapper-java-wrapper/lib/wrapper.js:170:23)\n    at ChildProcess.emit (events.js:400:28)\n    at maybeClose (internal/child_process.js:1088:16)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:296:5)"}

Here is what I have for a mapping.ttl:
@prefix rr: <http://www.w3.org/ns/r2rml#> .
@prefix foaf: <http://xmlns.com/foaf/0.1/> .
@prefix ex: <http://example.com/> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix rml: <http://semweb.mmlab.be/ns/rml#> .
@prefix ql: <http://semweb.mmlab.be/ns/ql#> .
@prefix fnml:   <http://semweb.mmlab.be/ns/fnml#> .
@prefix fno:   <https://w3id.org/function/ontology#> .
@prefix grel:   <http://users.ugent.be/~bjdmeest/function/grel.ttl#> .

@base <http://example.com/base/> .

<TriplesMap1>
  a rr:TriplesMap;

  rml:logicalSource [
    rml:source "../student.csv";
    rml:referenceFormulation ql:CSV
  ];

  rr:subjectMap [
    rr:template "http://example.com/{Name}"
  ];

  rr:predicateObjectMap [
    rr:predicate foaf:name;
    rr:objectMap [
      fnml:functionValue [
        rr:predicateObjectMap [
            rr:predicate fno:executes ;
            rr:objectMap [ rr:constant grel:string_replace ] ] ;
        rr:predicateObjectMap [
            rr:predicate grel:valueParameter ;
            rr:objectMap [ rr:template "Name" ] ] ;
      	rr:predicateObjectMap [
            rr:predicate grel:p_string_find  ;
            rr:objectMap [ rr:constant "[^a-zA-Z0-9_\-\.\+]+" ] ] ;
      	rr:predicateObjectMap [
            rr:predicate grel:p_string_replace  ;
            rr:objectMap [ rr:constant "-"  ] ] ;
      ]
    ]
  ].

When you can change your input to XML, you can use XPath (which I think is very powerful) with RML version 6.
Here is the XML data:
<?xml version="1.0" encoding="UTF-8"?>

<A1 name="H# M# T.-_ M."/>

Here is the mapping:
@prefix rr: <http://www.w3.org/ns/r2rml#>.
@prefix rml: <http://semweb.mmlab.be/ns/rml#>.
@prefix ex: <http://example.com/ns#>.
@prefix ql: <http://semweb.mmlab.be/ns/ql#>.

@base <http://example.com/data/>.

<#A1> a rr:TriplesMap;
  rml:logicalSource [
    rml:source "./test.xml" ;
    rml:iterator "/A1";
    rml:referenceFormulation ql:XPath;
  ];

  rr:subjectMap [
    rr:template "http://example.com/data/{replace(@name, '[^a-zA-Z0-9_.]+', '-')}";
    rr:class ex:A1
  ].

'+' is problematic as it would be encoded. You might have to post process that. I have not found a way around that.


Mozilla recommended ciphers

Mozilla recommends config generator:

ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-DSS-AES128-GCM-SHA256:kEDH+AESGCM:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA:ECDHE-ECDSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-DSS-AES128-SHA256:DHE-RSA-AES256-SHA256:DHE-DSS-AES256-SHA:DHE-RSA-AES256-SHA:ECDHE-RSA-DES-CBC3-SHA:ECDHE-ECDSA-DES-CBC3-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128-SHA256:AES256-SHA256:AES128-SHA:AES256-SHA:AES:CAMELLIA:DES-CBC3-SHA:!aNULL:!eNULL:!EXPORT:!DES:!RC4:!MD5:!PSK:!aECDH:!EDH-DSS-DES-CBC3-SHA:!EDH-RSA-DES-CBC3-SHA:!KRB5-DES-CBC3-SHA

Yet you recommend:

EECDH+CHACHA20:EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5

Which should be used?

This repository contains the cipher suite used by Cloudflare.
This is not a "recommended" configuration that everyone should use. It's an excellent balance between security and speed, which is critical for Cloudflare.
And even though the notation differs, there is a lot of overlap in the actual set of ciphers included in both configurations.
Mozilla's recommended configuration includes DHE suites which can be important if you want to provide forward secrecy with old browsers/clients.
However, DHE is computationally intensive compared to ECDHE (EECDH in CF's configuration, which is just a different name). At Cloudflare's scale where every single CPU cycle counts, this is significant. At most people's scale, accepting DHE suites is totally fine and usually not a bad idea. Hence, this is recommended by Mozilla.
Cloudflare's configuration places ChaCha20-Poly1305, which is only available in LibreSSL and BoringSSL, before AES-GCM. ChaCha20-Poly1305 is interesting on devices that don't have hardware-accelerated AES; mainly mobile devices. On modern Intel CPUs, AES-GCM is way faster.
Cloudflare intelligently picks ChaCha20-Poly1305 or AES-GCM according to what is expected to be faster on the client.
But the same configuration can be suboptimal in other contexts. Connect with LibreSSL with the default client configuration, and it is likely to use ChaCha20-Poly1305, even if the second and faster option, hardware-accelerated AES-GCM could have been used.
Mozilla's configuration doesn't include ChaCha20-Poly1305, partly because Firefox doesn't support it yet, partly because having AES-GCM as a first choice if it cannot be given the same priority as ChaCha20-Poly1305, is a safe bet.
Finally, the recommended configuration depends on your needs. Mozilla has three recommended configurations. A "modern" one for recent browsers, a more conservative one, and one that should be used as a last resort only.
Cloudflare's configuration tolerates 3DES for old browsers, whereas Mozilla's modern configuration considers it obsolete and only trusts AES as a block cipher.
TL;DR Unless you are Cloudflare, you probably want to use one of Mozilla's configurations.

@jedisct1 wow, amazing response thanks so much.
Changed our ciphers to use Mozilla. I was unaware that the listed ciphers here are tuned for CF scale, and not recommended for general consumption.

@nodesocket: they are perfectly fine for general consumption ;)


cudadevrt.lib doesn't work on Windows

It seems that there's something wrong with the cudadevrt.lib binary in the cudatoolkit-11.0.221-h74a9793_0.tar.bz2 package. When I attempt to use it with the Dynamic Parallelism example from the NVRTC docs (this is the simplest way to reproduce the issue), I get:
(base) PS C:\work\tmp\nvrtc-dynamic-parallelism> .\dynamic-parallelism.exe C:\work\tmp\cudatoolkit-package\Library\bin\cudadevrt.lib

error: cuLinkAddFile(linkState, CU_JIT_INPUT_LIBRARY, argv[1], 0, 0, 0) failed with error CUDA_ERROR_NO_BINARY_FOR_GPU

whereas when I use the version of cudadevrt.lib from an installed CUDA toolkit, e.g.:
(base) PS C:\work\tmp\nvrtc-dynamic-parallelism> .\dynamic-parallelism.exe "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\lib\x64\cudadevrt.lib"
0
...
4095

I get the expected result - the program runs and prints the integers from 0 to 4095.
I notice that the cudadevrt.lib in the conda package seems to be small in comparison to the version from the official installer:
(base) PS C:\work\tmp\nvrtc-dynamic-parallelism> ls -l "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\lib\x64\cudadevrt.lib"

    Directory: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\lib\x64

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        23/07/2020     11:59         943584 cudadevrt.lib

(base) PS C:\work\tmp\nvrtc-dynamic-parallelism> ls -l C:\work\tmp\cudatoolkit-package\Library\bin\cudadevrt.lib

    Directory: C:\work\tmp\cudatoolkit-package\Library\bin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        28/08/2020     23:36         596438 cudadevrt.lib

I hope this is the right place for this issue - if not, could you point me in the right direction please?

I think the problem is that there are two cudadevrt.lib files that are extracted from the installer:

cuda_cudart\cudart\lib\x64\cudadevrt.lib
cuda_cudart\cudart\lib\Win32\cudadevrt.lib

and the Win32 variant is ending up in the package instead of the x64 variant.


Consolidate OLEProp Fetching

Add a method, GetOLEProp, and call it from GetOLEPropValue, UpdateSingleProperty, and TaskEditProperties.
Also, add missing properties to SIList, DSIList, and FunnyList

Please have a look at my comments here https://github.com/rmcanany/SolidEdgeHousekeeper/pull/153#issuecomment-2416673514

Added a new issue about transitioning Dictionaries to separate Classes.  The OLEProp fetching is consolidated into one method.  Closing as complete.

I have commented the unused code, you can delete it, thanks

Will do.


Create README.md

Initial proposal for a CER metric card
cc @patrickvonplaten - wdyt this time around? :smile:

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Normal Map Disabled With Detail Active

Godot version
4.2 RC 2
System information
Windows 11, Nvidia RTX4070ti, AMD Ryzen7700x
Issue description
Activating Detail in a Standard Material disables standard Normal Map entirely regardless of Blend Mode.
Steps to reproduce
Activate Detail in a Standard Material on any mesh with a Normal Map.
Minimal reproduction project
Tangent_Issues_NormalMapVer.zip

I'm assuming the problem is that enabling detail without having any of the textures is impacting the normal_map. @WickedInsignia Can you confirm that that is your problem? I.e. you want to use detail for adding detail to the albedo, but not the normal map?
Assuming that I am correct about the issue, the problem comes from these two lines:
https://github.com/godotengine/godot/blob/eda44bfe109d7f15c5a965db2d65c8a17ce4b7d0/scene/resources/material.cpp#L1518-L1519
This is used if detail is enabled, even if there is no detail normal map used. Meaning that the normal map property gets changed needlessly.
The solution is to wrap these lines in a check if the detail normal map texture is valid. If the detail normal map texture is not valid, then the lines shouldn't be included.

@clayjohn it happens regardless of whether I have a normal map or albedo in their respective slots under Detail when it is activated.
My intent in my own projects was to add normal detail over the existing normal map using triplanar or a UV2. This object has no UV2 and that setting isn't active in the shader, but it has happened to other meshes I've tested with a UV2.
Hopefully that answers your question since I'm not entirely clear on that first paragraph.

@clayjohn it happens regardless of whether I have a normal map or albedo in their respective slots under Detail when it is activated. My intent in my own projects was to add normal detail over the existing normal map using triplanar or a UV2. This object has no UV2 and that setting isn't active in the shader, but it has happened to other meshes I've tested with a UV2.
Hopefully that answers your question since I'm not entirely clear on that first paragraph.

Well, my confusion comes from the fact that the MRP has nothing to do with the reported issue. The MRP only contains a mesh with a normal_map. It doesn't have a mesh with a normal_map and a detail_texture with a detail_normal_texture. Without a detail_texture, its expected that the detail added will look incorrect (similar to how enabling normal_map without a normal_map texture messes things up).
So I am trying to figure out what your issue is. Based on your report and MRP I can see potentially three things:

You want to use a detail albedo texture without a detail normal texture (thats what I asked about in my last comment)
You want to use both a detail albedo texture and a detail normal texture, but its broken (the MRP doesn't show this)
You are frustrated that enabling detail changes the look of your mesh until you set proper detail and detail_normal textures (again, the MRP doesn't show this, but it is expected behaviour)

Maybe some background will be helpful. If you enable "detail" on your material, you need to set a detail_texture. The detail texture will be used to add detail and the alpha channel of the detail texture is used to blend between the existing albedo/normal_map and the detail albedo/normal_map. If you don't set a texture, you will get a plain white texture instead. That can be problematic in two ways:

A white texture will turn your mesh white
Since the alpha channel of then white texture is 1, and it is used to calculate the blending, the detail_normal_map will totally override the regular normal_map.

Could you provide an MRP that fully illustrates the problem you are having?
Also, could you explain the steps that you take? Including what you expect and what happens? Clearly more information is needed.

Could you provide an MRP that fully illustrates the problem you are having?

@WickedInsignia Bump :slightly_smiling_face:

Closing due to lack of response. Please comment if you can still reproduce this bug on the latest Godot version.
PS: Since no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.

My misunderstanding came from what @clayjohn pointed out, which is that a mask is required.
This didn't seem natural to me since in Unity no mask is required for detail textures to blend, it's optional. Godot's proposed system didn't make any sense regardless of specific comparisons, so I presumed that wasn't how it was supposed to work.
The reason I didn't include a detail normal in the MRP was because simply activating the Detail feature disabled my main normal map, regardless of whether a detail normal was present. This was odd behavior since I expected the absence of a mask wouldn't affect the main normal.
Some industry usage background: Detail maps are most commonly used to fill in detail at a higher frequency when the main texture can't reach the desired texel density, or when more micro-level detail is required. This is the expected usage and what I was trying to replicate.
To my understanding, if I want a detail normal map to blend with the main normal map in Godot I need to set the Detail Mask to 50% grey. This reduces both normal map's strength by half, so I need to double the normal map intensity by two. This isn't very intuitive but at least at that point it's functioning as intended.
An issue I've come across on top of this is that there's no way to scale the detail textures without affecting the main maps. Usually you would scale detail textures down by 1/4th or more so they repeat at a high frequency across the mesh, to create a higher level of detail. That isn't possible in Godot's Standard Material without the use of UV2, which presents an issue if lightmapping is needed.
I would've written some proposals to improve this system but my last experiences with contributing to Godot and specifically the character attacks from the lead dev have encouraged me to step away indefinitely.

An issue I've come across on top of this is that there's no way to scale the detail textures without affecting the main maps. Usually you would scale detail textures down by 1/4th or more so they repeat at a high frequency across the mesh, to create a higher level of detail. That isn't possible in Godot's Standard Material without the use of UV2, which presents an issue if lightmapping is needed.

I have a proposal and pull request for this, but they haven't gotten much community support.

If a 2+ year old PR for a very common industry standard feature is left to collect dust on the shelf, as I've seen happen with many features that Godot's art pipeline could heavily benefit from, perhaps my proposal for better public-facing prioritization and roadmapping wasn't misplaced.
This isn't a community support issue, it's a core team prioritization issue. If community demand actually mattered, we'd have a native terrain editor as of 6 years ago.
Excuse the ramblings of a jaded user but I would say I'm glad this is in the pipe if I didn't already know how long it will stay there.


Add overload for mockcontext

Add MockContext.Start() Overload that takes a Type and passes the TypeName to the overloaded Start method. Need to create a new release to Nuget to be able to use this in the repo

/azp run net - mgmt. - ci

/azp run net - mgmt - ci


Fix suggestion health check

The search suggestion health check measures how good rummager is in suggesting spelling corrections to the user.
A rummager API change months ago (https://github.com/alphagov/rummager/pull/515) caused the health check to stop working.
Fixes: https://trello.com/c/wae6TIdZ

:+1:


Move v4-js general state management to v4-js-client

The v4-js module will be pure and exclude all external state requests.
The PR mainly adds the PoolTogetherV4 class which handles general usage of protocol contract interactions.

This has all been migrated 😄


Fix random WebSocket disconnects.

Removing the ping interval seems to stop the random WebSocket disconnects you would get like the error below:
Traceback (most recent call last):
  File "/home/ubuntu/.local/lib/python3.7/site-packages/fortnitepy/xmpp.py", line 141, in send
    await self.connection.send(data)
  File "/home/ubuntu/.local/lib/python3.7/site-packages/websockets/protocol.py", line 555, in send
    await self.ensure_open()
  File "/home/ubuntu/.local/lib/python3.7/site-packages/websockets/protocol.py", line 803, in ensure_open
    raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedError: code = 1006 (connection closed abnormally [internal]), no reason

(For proof, ran 17 bots and I haven't had a disconnect in ~9 hours compared to the disconnects I'd get prior which were instant).

It's been running for nearly 24 hours now so I can pretty much confirm it works

yes


Verbose flag to show progress

If I have a large file I am transferring there's no feedback for it's progress so I don't know if it's chugging along fine or hanging.

Thanks for noticing! The feedback was there until PR #8, which replaced the direct call to scp with a more elegant call to Net::Ssh. This commit brings back the feedback.
I've decided to set it as a default, without the verbose flag, because that's how scp does it. Let me know if you prefer a flag.

makes sense to me!


[BUG] angular-whitespace check-pipe false positiv

Following is reported but correct:
...<mat-option *ngFor="let a of (sub$ | async)">...
Message: ERROR: 57:59   angular-whitespace      The pipe operator should be surrounded by one space on each side, i.e. " | ".
I assume thats because the brackets?

See #719.


[Request] : New Icons Needed

As I needed a Triangle and  Paint-Brush icon, it isn't available  in the library. So requesting for those icons.
Thanks & Regards

Please look for Pyramid & Paint if it fits your need.

@ak19992017
Thanks for responding! I have looked upon the suggested icons and paint correctly fits according to the needs  but pyramid is way far different from triangle icon!
Thanks & Regards


Add .MobileBackups to DMG metadata.

Changes to the core

[x] Followed hacking.md.

Closes https://github.com/caskroom/homebrew-cask/issues/23034.

Merged as 9ee9ee77d53f98413b35215e0b66d11e8426e4f6.


Fix default trigger for tooltip

Per Boostrap documentation, this would appear to be correct except that the default is really both hover and focus

tootip cause ' Cannot read property 'offsetWidth' of undefined' error


Typo in domain "Principle Direction of Fire" should be "Principal Direction of Fire"

In Control Measures : Maneuver Lines the domain value is "Principle Direction of Fire" with an "le" - should be "Principal Direction of Fire" with an "al".
@csmoore @abouffard

Good catch - this will need fixed in the JMSML source data ( https://github.com/Esri/joint-military-symbology-xml/search?utf8=✓&q=Principle&type=Code )
& addressed when the domains are regenerated ( #80 )

This issue was moved to Esri/joint-military-symbology-xml#197


Force EncodedString on dataclass types

Fixes #4704
PyrexTypes.declaration_code is kind of inconsistent about whether
it returns an encoded string or not. Therefore this is probably
a lazy fix (of applying EncodedString anyway rather than making
the interface consistent).

declaration_code() should return a code snippet, not a Python text string. If it sometimes does return an EncodedString, then that is rather the inconsistency (but acceptable since that's probably the cases where we return a parsed name). Assuming that it doesn't return an EncodedString is correct.


Correct driver name lookup

The code here has been using the connection name rather than the driver name to determine whether to attach this functionality. This was causing issues when you had something like the below in database.php:
    'connections' => [
        'master' => [
            'driver' => 'mysql',
            'host' => 'master_database',
            .... etc
        ],
        'slave' => [
            'driver' => 'mysql',
            'host' => 'master_database',
            .... etc
        ],
    ],

The proposed change fixes this by looking at the driver name (mysql in both) rather than the connection name (master/slave depending on connection).

Thanks 👍


Prevalence run failure - "ValueError: Missing data for South, Alberta, Canada on 2022-06-26"

The automated prevalence run failed today:
[...]
Discarding State(fullname='Zilina, Slovakia', name='Zilina', population=694763, test_positivity_rate=None, cumulative_cases=Counter(), tests_in_past_week=None, vaccines_by_type=None, vaccines_total=Vaccination(partial_vaccinations=0, completed_vaccinations=0), country='Slovakia', fips=None, counties={}) with no case data
Positive test rate for Alberta is 1.9058823529411764
Traceback (most recent call last):
  File "update_prevalence.py", line 1683, in <module>
    main()
  File "update_prevalence.py", line 1608, in main
    app_locations[county.app_key] = county.as_app_data()
  File "update_prevalence.py", line 625, in as_app_data
    last_week = self.cases_last_week
  File "update_prevalence.py", line 492, in cases_last_week
    return self.cases_in_cum_cases(self.recent_daily_cumulative_cases[-8:])
  File "update_prevalence.py", line 419, in recent_daily_cumulative_cases
    raise ValueError(
ValueError: Missing data for South, Alberta, Canada on 2022-06-26 - Counter({datetime.date(2022, 6, 20): 38244, datetime.date(2022, 6, 21): 38244, datetime.date(2022, 6, 22): 38244, datetime.date(2022, 6, 23): 38244, datetime.date(2022, 6, 24): 38244, datetime.date(2022, 6, 19): 38231, datetime.date(2022, 6, 18): 38226, datetime.date(2022, 6, 17): 38215, datetime.date(2022, 6, 16): 38201, datetime.date(2022, 6, 15): 38189, datetime.date(2022, 6, 14): 38183, datetime.date(2022, 6, 13): 38170, datetime.date(2022, 6, 12): 38162, datetime.date(2022, 6, 11): 38151, datetime.date(2022, 6, 10): 38145})
Sentry is attempting to send 99 pending error messages

See full logs here: https://github.com/microCOVID/microCOVID/runs/7074724224?check_suite_focus=true

With a little luck, this should start working with tomorrow's run--the gap in updates seems to have been resolved two hours after the scheduled prevalence run:

https://github.com/microCOVID/microCOVID/actions/runs/2569836417
https://github.com/ccodwg/CovidTimelineCanada/commits/main/data/hr/cases_hr.csv

The issue in the upstream API is being addressed in https://github.com/ccodwg/Covid19CanadaAPI/issues/49


MATLAB Wrapper Unit Test

During the recent BART Workshop one of the polls did show that apparently a majority of users are using BART in combination with the MATLAB wrapper. However, as far as I can see it there is no Unit Test available for the MATLAB wrapper to tests its functionality.
MATLAB does include its own unit testing Fraemwork (see https://www.mathworks.com/help/matlab/matlab-unit-test-framework.html) and I wonder if there would be enough interest for a small Unit Test of the BART MATLAB wrapper to be developed.
The idea would be to have a matlabTest.m/bartTest.m function in bart/tests (or bart/matlab?) that runs a basic unit test on the MATLAB wrapper. Useful things to test could be:

Toolbox path set and finding of the bart binary
Execution of the bart binary
BART help from within MATLAB (see https://github.com/mrirecon/bart/pull/219)
Runing bart with:

single and multiple input variables
no, single and multiple output variables

MATLAB Unit Tests are not trivial, but I have used the MATLAB Unit Testing Framework before and would be willing to contribute.

A test for the wrapper would certainly helpful! A simple test which can be run using octave would be ideal as we could run it as part of continuous integration testing. (I do not have Matlab in my lab)

I will see if I can find some time next week or so to give this a go. I will also check out the unit testing framework of Octave to see if it's to some extent compatible to MATLAB. If not manual try/catch and error checking with fprintf to the command window will have to do, and will also be better than no testing at all :-)

What about a system test in the tests dir that calls an octave script to load a cfl, do some operation to it, then write a cfl, and use the nrmse tool as the final check? This would be similar to the other system tests.

What about a system test in the tests dir that calls an octave script to load a cfl, do some operation to it, then write a cfl, and use the nrmse tool as the final check? This would be similar to the other system tests.

One could run a MATLAB/Octave script from the command line that runs an entire BART pipeline, read cfl, further process using BART Wrapper calls, write cfl, and then compare to the same data processed purely using BART from the shell. But the result would in general be always identical between BART from the shell and BART from MATLAB/Octave unless there is any error in the wrappers (because any MATLAB/Octave wrapper error will crash the entire pipeline/test).
The question, in general, would be if the MATLAB/Octave unit test is more aimed at the developers, users, or both. From a developer point of view, the MATLAB/Octave wrappers are not really changed/updated that often and basically no changes in BART would influence them (unless there are major changes that completely change how BART works, e.g. cfl file format or how command-line parameters are passed), so the unit test would be sufficient to be a sanity check only for the MATLAB/Octave wrapper and no other part of BART. From a user point of view it would be great to have a simple script, e.g. test_bart.m, that a user could run from their current MATLAB/Octave session to quickly test if their local MATLAB/Octave setup works with BART (e.g. environmental variable set, write access to temp folder, bart help, bart calls with multiple parameters, etc.). The same script could also be used by the developers to test the Wrappers whenever changes to it are made (once a year or so).
Because the MATLAB/Octave wrappers are just a small addon for using BART I would suggest to go with the latter, more simple, solution of just using a self-contained MATLAB/Octave test script like test_bart.m that directly tests all MATLAB/Octave wrapper functionality and that can be easily run by the user and any developer who changes the wrappers on-demand.

sounds good!

There is already a test for python export/import you can look at.

I have been taking a look at the python unit test in the tests folder, trying to get it to work as a start and trying to understand the integrated test system (and also use it as a blueprint for a possible MATLAB/OCTAVE test).  It's basically just a bunch of make files that export test make targets that are collected in TESTS, TESTS_GPU and TESTS_PYTHON and the targets run some commands and compare the result with nrmse?
I was able to run the python test with make tests/test-python-cfl, however on my system make pythontest, which is defined in the MakeFile, just returns with no rule to make target (presumably because ${TESTS_PYTHON} is not populated properly)? Is there anything that I have to do/setup to make "make pythontest" work?
On a side node: is it normal that make test takes ages? On my laptop it appears to be stuck with 100% CPU usage on the first ecalib unit test (I did manually abort after 30 minutes).

Yes, the tests are just makefile rules listed in these variables. They can do whatever you want.
I fixed the python problem.
Running all tests takes about 3 minutes on my desktop. If it is stuck somewhere, this is a bug. Sounds like a problem in your compiler.

I tried to look more into the Makefile system, but since I'm absolutely no expert in bash/shell scripting and Makefiles I gave up after spending hours on just trying to clone the python test to a matlab test and get anything to work. Adding anything to the Makefile tests is just beyond my skills, sorry.
But I did also go back to the original idea of having a test that is integrated into MATLAB/Octave. I have created a small test_bart.m script which you can find here: https://github.com/MartinK84/bart/blob/67eae8cba6a2498259e7009a14b6a9f78933d879/matlab/test_bart.m
This script is basically a super-simplified unit test system that works under MATLAB and Octave (The UT systems integrated in MATLAB and Octave are sadly completely different so I had to come up with something customized).
The script simply performs some BART commands using the MATLAB wrapper and checks if the commands did run without error, if data was returned and if the returned data is not empty. Basically only testing if the BART wrapper works.
test_bart.m works under MATLAB and Octave, the latter produces some more console output because the eval commands work different between MATLAB and Octave - but the performed tests are the same. When running from MATLAB the output is:
>> test_bart
TEST [Environmental variable (TOOLBOX_PATH)] >> Passed
TEST [Write cfl file] - running "writecfl(file, data)" >> Passed
TEST [Read cfl file] - running "readcfl(file)" >> Passed
TEST [Data consistency cfl file] >> Passed
TEST [Wrapper (without parameter)] - running "bart" >> Passed
TEST [Wrapper (method help)] - running "bart traj -h" >> Passed
TEST [Wrapper (No input, no parameter)] - running "bart('phantom')" >> Passed
TEST [Wrapper (No input, no parameter) - check output] >> Passed
TEST [Wrapper (No input)] - running "bart('phantom -3')" >> Passed
TEST [Wrapper (No input) - check output)] >> Passed
TEST [Wrapper (One input, one parameter)] - running "bart('fft -u 3', varargin{1})" >> Passed
TEST [Wrapper (One input, one parameter) - check output)] >> Passed

TEST Result: All Tests Passed!

Although not integrated into the BART test system this could nevertheless be something that any user can just run themselves after starting MATLAB/Octave to test if their BART setup works.
If you think that this is something useful I can create a pull request.

I think it would be useful....

Added with 1512f4dcdded0b09cfd4acff4647c25cb697653b


React Native support?

Are there any plans for supporting React Native bundles, or is that completely out of scope?

Out of scope for now only because I don't know enough about React Native to understand the problem, but would love to understand more


moving deltaView to a component, showing selected page for launch

adding simple scrolling to the top, when test selected

removing unused stuff from Basepage component for better readability, adding comments here and there

moving deltaView functions  (showing pyramids) into a separate component for readability

highlighting pagination on the launch page

some small twigs on the test history (adding a badge for Current Test)

experimenting with tabs, thought to simplify them a bit

@Jnegrier refactoring here as alwaaays

@Jnegrier what are those tests actually doing?
https://github.com/delta-reporter/delta-frontend/pull/29/commits/b2ad461374d2e03b0558c66c21cb447302515e59#diff-74a2ed0155b7d85e0772eae9b0c5bf71L58
where is this paragraph  coming from?

@Jnegrier what are those tests actually doing?
b2ad461#diff-74a2ed0155b7d85e0772eae9b0c5bf71L58
where is this paragraph coming from?
thanks for fixing the test

These tests are just taking screenshots of the app, and sending these screenshots to a service called Argos


Runing parallel_ft_lora.sh

Thanks for sharing your excellent work. I run the script parallel_ft_lora.sh, but get the following errors. How can I solve it?
TypeError: Object of type Tensor is not JSON serializable

Hello, how did you fix this error? I run into the same bug..

It's fixed after I lower the version of deepspeed pkg.


[KOGITO-5944] Let user to provide a custom Grafana dashboard (json)

@danielezonca @evacchi  @r00ta  @jiripetrlik
See https://issues.redhat.com/browse/KOGITO-5944
This PR

create CustomDashboardGeneratedUtils that is meant to read custom dashboards jsons and return them as Collection<GeneratedFile>
modify ApplicationGenerator to invoke CustomDashboardGeneratedUtils soon before DashboardGeneratedFileUtils.list(generatedFiles).ifPresent(generatedFiles::add);
slightly modify AppPaths to allow multiple resources folder

Custom dashboards must meet the following criteria:

they must be inside src/main/resources/META-INF/dashboards directory
they must start with operational-dashboard- or domain-dashboard- prefix
they must have .json extension

@danielezonca  @evacchi
The cleanest way to implement that would be - IMO - to create a specific Generator for Custom dashboards, but at the same time this would be needlessly cumbersome. Anyway, I've not a strong opinion on that, so I'll leave you decision on the overall "design"...
Needed by https://github.com/kiegroup/kogito-examples/pull/1003

The (build) kogito-examples check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) kogito-runtimes check has failed. Please check the logs.

@danielezonca
Could you pls merge this ? Thanks


ES6 this.callInitHooks is not a function

[x] I'm reporting a bug, not asking for help
[ ] I've looked at the documentation to make sure the behaviour is documented and expected
[ ] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ ] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using:
Browser (with version) I'm using:
OS/Platform (with version) I'm using:
step 1
step 2

What behaviour I'm expecting and which behaviour I'm seeing
Minimal example reproducing the issue

[ ] this example is as simple as possible
[ ] this example does not rely on any third party code

Using http://playground-leaflet.rhcloud.com/ or any other jsfiddle like site.

I was trying the latest version of leaflet 1.02 to use in an app. Leaflet 1.0.2 works no problem if I build the app in plain javascript. Use leaflet 1.0.2 in a Typescript app breaks with: this.callInitHooks is not a function as soon as I add a Control plugin like GeoSearch to the map.
Is leaflet 1.0.2 ES6 / Typescript compatable?

There shouldn't be anything in particular stopping you from using Leaflet with TypeScript (there are definitions for it: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/leaflet/index.d.ts) and ES6.
Feel free to provide an example on http://playground-leaflet.rhcloud.com/, jsfiddle or similar if you think there's any particular issue with Leaflet that prevents this.

You Are absolutely right. I too has no problems using Leaflet in my app with Typescript. It just are the plugins that don’t work.
running the plugins can’t find kookinit().

Op 3 jan. 2017, om 14:57 heeft Per Liedman<EMAIL_ADDRESS>het volgende geschreven:
There shouldn't be anything in particular stopping you from using Leaflet with TypeScript (there are definitions for it: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/leaflet/index.d.ts https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/leaflet/index.d.ts) and ES6.
Feel free to provide an example on http://playground-leaflet.rhcloud.com/ http://playground-leaflet.rhcloud.com/, jsfiddle or similar if you think there's any particular issue with Leaflet that prevents this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Leaflet/Leaflet/issues/5224#issuecomment-270119252, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZlpz5axhLON3LzzdbHZIgG4DYx4-Gnks5rOlPMgaJpZM4LXtMC.

I think you should file an issue with the plugin in question, unfortunately the Leaflet team has limited insight into plugins by other authors, and also our time and resources prevent us from debugging issues outside of Leaflet's core.

I don't know if this helps, but I just had the same issue. But it was my error. I was calling L.TilelLayer and not L.tileLayer() , perhaps add this to the documentation as common blunders :-(  see also https://github.com/mWater/offline-leaflet-map/issues/18

Just in case someone has the same error, instead of
var positron = L.TileLayer(...)
you should write:
var positron = new L.TileLayer(...)
The new keyword is missing in your playground link @pcrombach

Just to make explicit what the issue is - Leaflet uses classes, and also has factory methods for creating new objects. The classes are captialized and need to be called with new, while the factory methods are lowercase and should not. The documentation uses factory methods, so I cannot say whether directly instantiating class instance is supported, although the factories simply call new anyway. The following are therefore equivalent, though only the first is documented.
// Small t, calling factory method
const positron = L.tileLayer(...);

// Capital T, instantiating a new instance directly
const positron = new L.TileLayer(...);

the same issue exists in react as well


Latest sb-simd fails to build under sbcl-2.1.10

Since development of sb-simd goes hand in hand with sbcl at the moment the latest head of sb-simd builds only under the development head of sbcl.
Could you please accept this PR and rerun the GH action?
Would it be possible to set up a nightly sbcl, like for other languages to enable us to test regressions as well?

Could you please merge this and rerun the action?
Thanks!

Would you be kind to merge this PR and rerun the action to include cl result using simd?
Thanks again


BasicTextField can add a parameter to always hide the keyboard

BasicTextField can add a parameter to always hide the keyboard

if(xxxx)
    textInputSession.showSoftwareKeyboard()

Thanks for taking the time to open an issue! As this is not related to the Compose samples, you might want to try posting it on sites such as stackoverflow.


Remove variable parameter from SubstitutionError

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

@virgil-serbanuta With these changes, you should be able to add branching to the unifier everywhere by adding an Alternative constraint to the MonadUnify class,
class (Alternative unifier, Monad unifier) => MonadUnify unifier where

and adding BranchT to Unifier,
newtype Unifier a = Unifier
    { getUnifier :: BranchT (ExceptT UnificationOrSubstitutionError Simplifier) a
    } deriving (Alternative, Applicative, Functor, Monad)


Nested assert for mrbtest

When nesting assert used in test, it is indented and displayed.
Assertion numbers are concatenated by "-" at this time.
The purpose is to match the apparent numbers when failing with assert_mruby which is defined by mrbgems/mruby-bin-mruby/bintest/mruby.rb for example.
Child assertions "skip" and "info" are reported as parent assertions "info" and $ok_test += 1.
The child assertions "ko" and "crash" are reported as the parent assertion "ko" and $ko_test += 1.
When child assertions are mixed, "ko" takes precedence.
If you use "." As a concatenation character, I think it is easy to confuse it with the ISO Ruby section number when it is displayed.
So we chose "-" as the concatenation character.
Note that this patch conflicts with #4320.
Incompatibility

$mrbtest_assert_idx takes nil or an integer array object.
So far it was nil or an integer.
$asserts points to the top of the internal stack in the assert.
$mrbtest_assert points to the top of the internal stack in assert.

Demonstration:
# example test code
assert "test KO #A" do
  assert_false "bad assertion #1"

  assert "nested test KO #B" do
    assert_false "bad assertion #2"

    assert "nested test KO #C" do
      assert_equal "bad assertion #3", "dummy"
    end
  end

  assert do
    assert do
      assert_equal "bad assertion #4", "dummy"
    end

    assert do
      assert "Error" do
        (0/0).to_i
      end
    end

    assert do
      assert "Jump" do
        skip "skip!"

Skip: File.expand_path (with ENV) (mrbgems: mruby-io)
Fail: test KO #A (core)
 - Assertion[1]
    Expected "bad assertion #1" to be false.
 - Assertion[2]
    Fail: nested test KO #B (core)
     - Assertion[2-1]
        Expected "bad assertion #2" to be false.
     - Assertion[2-2]
        Fail: nested test KO #C (core)
         - Assertion[2-2-1]
            Expected: "bad assertion #3"
              Actual: "dummy"
 - Assertion[3]
    Fail: Assertion failed (core)
     - Assertion[3-1]
        Fail: Assertion failed (core)
         - Assertion[3-1-1]
            Expected: "bad assertion #4"
              Actual: "dummy"
     - Assertion[3-2]
        Fail: Assertion failed (core)
         - Assertion[3-2-1]
            FloatDomainError: Error => NaN (core)
     - Assertion[3-3]
        Info: Assertion failed (core)
         - Assertion[3-3-1]
            Skip: Jump => skip! (core)
 - Assertion[4]
    Expected "bad assertion #5" to be false.
Total: 1133
   OK: 1124
   KO: 6
Crash: 1
 Skip: 2
 Time: 0.97 seconds


Template, layout design. An example with Skeleton CSS

Hi, how are you?
My template and layout with design. An example  with framework Skeleton CSS ^^
I hope sending that example and others. And I hope collaborate more with this project.
Note: Simple, fast, line-by-line for ( eye scroll  ), without api and custom style.css.... This is... pure Skeleton CSS.
Regards,
Pedro Guilherme.

Example Screenshoot

My repo: https://github.com/pedroguilhermelima/check

I would like to help by sending my template here

What do you think?

This project is dead.

This project is dead.

Seems so... but this one ( https://github.com/andreobriennz/skeleton-flexbox ) uses Flexbox and is only 2 years old :)

This is the continuation: https://github.com/kevinnading/littleCSS
On Thu, Aug 27, 2020, 1:21 PM BadCat Design<EMAIL_ADDRESS>wrote:

This project is dead.
Seems so... but this one (
https://github.com/andreobriennz/skeleton-flexbox ) uses Flexbox and is
only 2 years old :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dhg/Skeleton/pull/385#issuecomment-682143181, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSQ46EXLNQDKYKMCJCW36TSC2WZ7ANCNFSM4HKDPTLQ
.

This is the continuation: https://github.com/kevinnading/littleCSS
…

Nice. Thanks. LMK when it has Flexbox or Grid for layout.


add awssm support

TODO:

[x] add more tests to cover the missing bits (see codecov comments)

I've added a bunch of tests, feel free to take a look if you have  some time


Enum schemas not found by compiler

Hi @yonaskolb,
I'm having trouble with enums situated at root level: Supposed we have a (simplified) scheme like this:
---
openapi: 3.0.3
info:
  version: 1.0.0
  title: Test
components:
  schemas:
    Category:
      type: string
      enum:
      - first
      - second

It defines the enum Category which should be available in the API framework.
It is usable if I import it via import enum API.Category, and can simply be used as API.Category.first.
In this case I have to specify the namespace (API) since Foundation is already declaring another Category.
But if the same file needs other objects from API I'd simply like to use import API. If I do so some code like API.Category.first doesn't compile anymore:
Type 'API' has no member 'Category'
I've looked for similar issues here but couldn't find it. I also noticed that this is true for all enum schemas that are situated in the "root" level of API. Most often it's probably not a problem since there's no ambiguity and API names isn't required. In those cases it's fine.
Do you know  what causes this issue and how I can fix it?
Don't hesitate contacting me if you need further details.
Best,
Ben

This seems to be related to #159


IoT-Analytics   -  Broker is unreachable, Waiting.....

Hi all,
I study WSO2 IOT for several months. I get WSO2 iOT on Jenkins to see the evolutions.
I finally managed to run the WSO2 IoT server with my ip : <IP_ADDRESS>
But, in the console, i have a error.  Here is an excerpt of the console. I run the WSO2 iOT server with the command sh start-all.sh
[2017-05-19 14:03:27,198] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [2017-05-19 14:04:27,357] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [2017-05-19 14:04:48,722] [IoT-Broker]  INFO {org.wso2.andes.kernel.AndesRecoveryTask} -  Running DB sync task. [Stage 1914:(45 + 1) / 200][Stage 1918:(0 + 0) / 200][Stage 1924:(0 + 0) / 200][2017-05-19 14:05:27,522] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [2017-05-19 14:06:27,680] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [Stage 2084:(59 + 1) / 200][Stage 2098:(0 + 0) / 200][Stage 2102:(0 + 0) / 200][2017-05-19 14:10:28,334] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [2017-05-19 14:13:28,807] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting..... [2017-05-19 14:19:48,722] [IoT-Broker]  INFO {org.wso2.andes.kernel.AndesRecoveryTask} -  Running DB sync task. [Stage 2417:(155 + 1) / 200][Stage 2425:(0 + 0) / 200][Stage 2431:(0 + 0) / 200][2017-05-19 14:20:30,034] [IoT-Analytics]  WARN {org.wso2.carbon.device.mgt.input.adapter.mqtt.util.MQTTAdapterListener} -  Broker is unreachable, Waiting....
In the folder homewso2iot/wso2/broker/conf , I modified only carbon.xml
<HostName><IP_ADDRESS></HostName>
<MgtHostName><IP_ADDRESS></MgtHostName>

In the folder homewso2iot/wso2/analytics/conf , I modified carbon.xml
<HostName><IP_ADDRESS></HostName>
<MgtHostName><IP_ADDRESS></MgtHostName>

I have several questions :
1. In In the folder homewso2iot/wso2/analytics/conf
File : event-processor.xml
What means <hostName><IP_ADDRESS></hostName>
2. In In the folder homewso2iot/wso2/analytics/conf
File : input-event-adapters.xml
Do I have to change with my ip <IP_ADDRESS>?
Ligne 43 : <property key="tokenValidationUrl">https://${iot.keymanager.host}:${iot.keymanager.https.port}</property>
Ligne 46 : <property key="tokenUrl">https://${iot.gateway.host}:${iot.gateway.https.port}/token</property>
Linge 47 : <property key="deviceMgtServerUrl">https://${iot.gateway.host}:${iot.gateway.https.port}</property>
Ligne 57 : <property key="dcrUrl">https://${iot.keymanager.host}:${iot.keymanager.https.port}/client-registration/v0.11/register</property>
Ligne 58 : <property key="url">tcp://${mqtt.broker.host}:${mqtt.broker.port}</property>
3. In In the folder homewso2iot/wso2/analytics/conf
File : output-event-adapters.xml
The parameters of the mail.smtp.user are not commented on and with test information
We must therefore modify this part in relation to our mail server
Also, ligne 131 : <property key="url">tcp://${mqtt.broker.host}:${mqtt.broker.port}</property> Do I have to change with my ip <IP_ADDRESS>?
Here is a summary so that you have a maximum of information. The documentation is really succinct. Thank you for your help.

you don't need to change the parameterized value, However add the correct IP for mqtt authorization and authentication configuration in wso2/broker/conf/broker.xml

Thanks but I have to modify what parameters?

Finally I found
Open file: homewso2iot/wso2/analytics/bin/wso2server.sh
Search the line
-Dmqtt.broker.host="locahost" \
Replace with
-Dmqtt.broker.host="your_IP" \