Build the Windows Installer and the Windows GUI fully in Python using wxPython Phoenix

I started playing around with wxPython and it seems to be a nice tool if you want to work with win32 API without having to go through all the trouble of that weird C/C++ design of win32 API.
I have built the following demo that mimics the KA Lite GUI (Tray menu) and it seems to work pretty well: [Demo] (https://github.com/ruimalheiro/wx-ka-lite-gui)
To try it out, just download the repo and run "main.py". If you don't have wx installed, it will be downloaded and installed automatically by pip.
Interesting links on wxPython:

[WX] (http://wxpython.org/Phoenix/docs/html/index.html)
GALLERY

Possible benefits:

I think it offers everything needed to build the installer and leave INNO setup behind;
No need to pack the GUI and to use Visual Studio. However, the gui will be a python script, instead of a binary, so it will obviously require Python to run;

@jamalex @aronasorman @EdDixon @benjaoming @MCGallaspy
Let me know what you guys think and if you guys have any problem to run the demo.

Hi @ruimalheiro!
We're making grounds in terms of using a Makefile for the build process and getting Bamboo to do everything for us, so I would think this is a great benefit if the whole Visual Studio packaging could be abandoned!! Great timing for this!!
You Windows people should definitely make the call for the graphics toolset for the Windows platform :) And having a Python-based toolset would make it more maintainable. Have you considered gtk3, which is also available for Windows?
This is what I've been basing the Linux GTK control panel on...
http://ka-lite-gtk.readthedocs.org/
It's built with Glade, which is great :)
Haven't done anything for the notification area yet, but such decision would be easier to design for if there was either a decision against or for cross-platform compat.

Hi @ruimalheiro. Thanks for your efforts. Will take a look at it this week!

Feel free to pop into the hipchat dev room and let us know about your intentions as well!

Hi @benjaoming and @MCGallaspy ! Have you tried the DEMO?
@benjaoming Thank you for your feedback. GTK3 looks great! Thanks for sharing. Something we can explore for sure if there is good support for windows.
@MCGallaspy Looking forward for your feedback! My idea is to discontinue the C/C++ version of the GUI and the use of Inno Compiler. Building both the installer and the GUI using wxPython Phoenix or GTK3 would be much better and easier to maintain.

Hi @ruimalheiro. I like your idea, but a few comments:
We're trying to maintain high standards for code that we include in our official repos. Though our standards are not totally concrete right now, at a minimum we'd like code to be well-planned, well-tested, and well-commented. The best way to achieve this is to actively engage with the dev team through the entire dev process with some combination of hipchat, email, and github issues. It's unlikely that we'll merge substantial changes to the codebase without that engagement.
That said, I do like the idea of a Python-based tasktray program (especially if it's x-platform). I'd like to encourage contributors to our org's projects, and I encourage you to continue to develop this as an alternative to the existing tasktray program. The first step to engage the dev team would be to document the goals and planned features of this project, and share it for review.

It's also not clear to me that this will replace InnoSetup -- in a addition to distributing the tasktray program, we use IS to distribute a python interpreter and handle some upgrade tasks. Does this project propose to replace those elements of the IS program as well?

Hi @MCGallaspy . This is just an idea.
The purpose of this topic was simply to expose the possibility of writing both the installer and the GUI fully in python, using wxPython.
"It's also not clear to me that this will replace InnoSetup "

We can design and develop the installer, replacing the need to use Inno. wxPython offers all the widgets that we may need.

The demo is the GUI only.

But before moving further, I need to know if you agree with the use of wxPython.

It's premature to ask whether we should use a particular library or not prior to determining the goals and design of the project. Do you want to replace the whole windows installer? Then let's think up a fully-conceived specification first, instead of creating something ad-hoc. I won't agree to use wxPython or any library prior to that.
That said, right now creating a new windows installer is not a high priority for the dev team, so I doubt we'll be able to take a lead role in the design. But we're more than happy to assist you if you want to take it on yourself! It would certainly be a big help to us! Email the team or jump into hipchat to discuss in more detail.

Hi @MCGallaspy
Yeah, I see what you mean and you are right. Well, I'll have to make room for some time and discuss that with you all to explain my goal with this.
In the meantime, you are doing a great job maintaining the current INNO / C++ and that is also great.
Thank you for the feedback!

I very much agree with both @ruimalheiro's innitiative and @MCGallaspy 's precaution -- it would be great to have the build process made as simple (unified) as possible. The long-term goal should be to have a very solid KA Lite that won't take resources from Kolibri development, but can still be improved and maintained either by FLE or the community! If either of these don't have to bother much with highly complex build setups, it's more likely that future releases will find their way and KA Lite can continue to be of value (mainly for existing deployments).
I don't know the complexity of creating a new UI, but since a pure-python UI is a precondition for a simpler build process, it might be possible to do this without investigating the builder... but we really do have to want to invest in the creation of a new build process, then.
I had to fake the kalite prackage and data to start a less heavy experimentation with the Debian installer -- perhaps this method would also be relevant for other platforms.

Also; I've detached ka-lite-gtk from ka-lite to have freedom from the heavy Debian packages and to be able to maintain it outside of the KA Lite release cycle. This could also be a good way to get a wxPython up and running, released, and tested quickly once the Windows installer starts installing ka-lite through setuptools.

Yeah, since we can't rely on Python being preinstalled, I would see this
working best for the launcher GUI, rather than the installer itself.
Luckily, Inno builds fine in Wine; it's the VS launcher GUI that's more
complicated to build, so this could be a good match.
Also, worth noting that we should be able to reuse a substantial portion of
the code for the installers for Kolibri.
On Nov 7, 2015 1:10 PM, "benjaoming"<EMAIL_ADDRESS>wrote:

Also; I've detached ka-lite-gtk from ka-lite to have freedom from the
heavy Debian packages and to be able to maintain it outside of the KA Lite
release cycle. This could also be a good way to get a wxPython up and
running, released, and tested quickly once the Windows installer starts
installing ka-lite through setuptools.
—
Reply to this email directly or view it on GitHub
https://github.com/learningequality/installers/issues/248#issuecomment-154703152
.

Yeah, I think that is a good point. Building the GUI in Python would be a great help. The demo is basically a KA Lite GUI.
By using this, we won't need to pack a compiled GUI and it will be built automatically, when the installer is built.
wxPython is cross-platform but I don't know if the tray icon is supported under osx and linux. If I'm not mistaken, there is already some work in a GUI for OSX right?

Yes @ruimalheiro, we've been maintaining the GUI for OS X since v0.14.x.  We haven't tried testing wxPython on OS X yet, so hope to get our hands on it later too.

Just tried the demo here on win32 XP and it is a really fast clean solution replacing our current win32 binary? I really like it!

Thanks for testing @EdDixon ! :+1:


There is the functionality for Private Key QR code output ?

In this source, there seems not output of QR code for private key.
And when click share button, it shows only private key string.
But there is only option to recover wallet with private key QR code.
How do I think about this?
This source can send and receive any ERC20 token and ETH?

Hey @AntonioCatanese, thanks for your interested in Eltwallet!
True we've decided to do not display a QR code for the private key but it can easily be added in the future if we decide to.
And when you import an existing wallet you also have the possibility to enter it or paste in in the text input 👍
And yes the wallet supports sending and receiving ETH and all ERC20 tokens


feat: passing token as environment variable

Since the Genius token is being set in the code, it's easy to unintentionally commit it when contribute to this project, for instance:

I fork this repo
Create a token on Genius
Put the token on example/main.dart and test/genius_lyrics_test.dart
Add my code
Do git add ., git commit -m "message" and git push without thinking :flushed:

Instead, we could use:
Genius genius = Genius(
    accessToken: const String.fromEnvironment('GENIUS_TOKEN'),
);

and, for instance, run tests with dart --define=GENIUS_TOKEN=<token> test -c vm:source or flutter test --dart-define=GENIUS_TOKEN=<token>

another thing for passing token as environment viarable is the possility to set github actions to setup githubactions for integration test


Apple rejects our app because of how consent is managed in the AdMob plugin

Describe the bug
Apple tells us that they choose "Ask app not to track"

Then they still got the Google consent popup

They state:

I am wondering if this is a bug or that I have to manage this in some way (If so, I am quite curious how).
To Reproduce
Follow the instructions in the readme
Expected behavior
If I choose "Ask app not to track" then do not show consent window and tell AdMob there is no consent.

The Google Consent should not be presented when the user asks app not to track. You should only call the consent pop up when user allows tracking.

When I did it was approved by Apple. It still feels a bit odd that do not track means do not ask consent.

For me readme is a bit confusing.
Because based on your comments I have understand showConsentForm launch the tracking transparency request if we have implemented in Admob IDF Explainer:
https://support.google.com/admob/answer/10115027
Also in the documentation method says:
request requestTrackingAuthorization (iOS >14). This is deprecated method. We recommend UMP Consent.
So based on Apple rejecting apps because tracking transparency request is required.
I would say that the initialize explanation on the README is deprecated because is using requestTrackingAuthorization
And it should warns that for use the plugin in iOS it is required to implement the IDF Explainer.
Is this correct?

For me readme is a bit confusing. Because based on your comments I have understand showConsentForm launch the tracking transparency request if we have implemented in Admob IDF Explainer: https://support.google.com/admob/answer/10115027
Also in the documentation method says: request requestTrackingAuthorization (iOS >14). This is deprecated method. We recommend UMP Consent.
So based on Apple rejecting apps because tracking transparency request is required.
I would say that the initialize explanation on the README is deprecated because is using requestTrackingAuthorization And it should warns that for use the plugin in iOS it is required to implement the IDF Explainer.
Is this correct?

Im totally agree. It seems that it is only required to use the UMP Consent but this way Apple will reject your app. Maybe a mixed solution is to, first request tracking and then, if accepted, show consent form.

This sounds like an App implementation problem, am I right?


Add an option to avoid major bump when peerDeep has changed

Problem
We have a monorepo https://github.com/wundergraph/wundergraph. We developed a package for our SDK @wundergraph/nextjs. The package has the SDK as peerDependency. After patching the SDK, the package is major bumped. We don't want this. This change was not communicated through a changeset. I think this defeats the purpose of a changeset.
Docs: https://github.com/changesets/changesets/blob/c68536edf4c04e7fdf5594ec9c69471cd86fd0ce/docs/decisions.md#the-versioning-of-peer-dependencies
Proposed solution
Provide an option to disable this behavior and make this part of the changeset.

Is this what you are looking for? https://github.com/statelyai/xstate/blob/c967791c82756b8c743c70a4a0b66b2e9e1d7d41/.changeset/config.json#L10

Hi @Andarist , good timing, I am trying right now :smile:

We have a similar issue in our repo. In our case we do want to do a release of all dependant packages but not a major. We tried setting this in the config:
  "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
    "onlyUpdatePeerDependentsWhenOutOfRange": true,
    "updateInternalDependents": "always"
  }

And with this config it creates a patch release for all dependant packages but the changelog is empty:
# @cmpsr/nextjs-contentful-renderer

## 4.0.1
                         <--- Missing changelog
## 4.0.0

### Minor Changes

- c657ab3: feat: expose @cmpsr/blocks to MdxRenderer

I think it would be nice to be able to configure the release type for dependant packages. I can work on it if this is something you are interested on.

Hi, @tkanzakic could you open a different issue? I see it as two separate issues. My concern is that every change is listed in the changeset and we should have a flag to disable the peerDep behavior entirely.

@Andarist it works but it is error-prone because we can't see the change upfront in the changeset.

Could you elaborate?

Hi, @tkanzakic could you open a different issue? I see it as two separate issues. My concern is that every change is listed in the changeset and we should have a flag to disable the peerDep behavior entirely.

@StarpTech from the title of the issue I understand that your issue was avoiding doing a major bump in the peers, which is what we are trying to do, sorry for the misunderstanding. I will open a new issue.

For what it's worth, I had a similar issue and onlyUpdatePeerDependentsWhenOutOfRange fixed my problem.

We have two packages, let's call them "x" and "x-integration-tests". We use fixed to publish them at identical version numbers.  x-integration-tests has a peer dep on x.
It looks like if we add a minor bump to x, it ends up getting translated into a major bump on both packages.
onlyUpdatePeerDependentsWhenOutOfRange only sort of helps: it keeps the packages at minor bumps, but it doesn't actually update the peer dependency between the packages, and we really do want the package versions to match so that people are using the matching version of the tests in their test suites.
See https://github.com/apollographql/apollo-server/commit/950fd1b21f5c672814d9373490ab953832fe09ea for a real example.

Note that even with:
  "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
    "onlyUpdatePeerDependentsWhenOutOfRange": true,
    "updateInternalDependents": "always"
  }

When I add a minor change, it still did a major bump (@changesets/cli@2.25.2).
I recall there is a comment about that somewhere, but can't find it. So add it here again for record.

Within the docs one can read:

Currently, if you list a package as a peerDependency of another package, this causes the package with the peerDependency to be released as a major change. This is because peerDependency changes will not be caught by a package installation.

At least for npm 7+ this no longer the default behaviour and will throw an exception during the installation of a package whose peerDependencies are no longer matched.
Additionally, from what I can see, the onlyUpdatePeerDependentsWhenOutOfRange experimental flag is potentially prejudicial. Maintainers may be coupled to some recent addition in a dev dependency but by not mimicking the same range bump in a peer dependency consumers may incorrectly be using an incompatible version.
WDYT about exposing some flag that bumps peerDependencies and dependencies the same way?

FWIW this was frustrating enough for us that we just decided to change the dependency described above to be a non-peer dependency. (In this particular testing context, we were able to work around the potential downside of getting two copies of the dependency in the app by just adding a test to the suite that ensures there's only one.) https://github.com/apollographql/apollo-server/pull/7114


Adding PyTorch on Satori

This is for how to build PyTorch on Satori.

Preview
https://mit-orcd.github.io/orcd-docs-previews/PR/PR68/recipes/pytorch2-staori/


Feature Request: fast mode that doesn't require compilation

I would like a "fast" mode for Haddock. Often when I'm writing Haddocks, I just want to quickly build the docs and see how they render, and find out if I've introduced any parse errors (e.g. --^ on GADT constructors: https://github.com/haskell/haddock/issues/43). In this use case I don't care about linked references, for example. I can save that for a Hackage upload or other "final form".
I don't know how Haddock works internally, but I see that right now it compiles my entire program every time I generate the docs. This takes several minutes for a large project. My hope is that by eliminating compilation, at the cost of linked references and perhaps other things, the documentation generation process could be greatly sped up (naively, the doc generation time should be similar to the parse time in this case).
If the Haddock maintainers are potentially open to such a haddock --fast feature, I might be interested in developing it myself. I'll have to learn about Haddock internals/implementation before I know how large of an undertaking this is, but if you already know this is something you're against, then I won't bother. Please let me know.
I searched the existing issues and found some issues related to performance, but nothing specific to avoiding compilation: https://github.com/haskell/haddock/issues/484, https://github.com/haskell/haddock/issues/345.

@ntc2 I like the idea of a faster turnaround times. But this is tricky. Haddock works like this:

Load the interface files for all dependencies; called InterfaceFile (see Haddock.InterfaceFile.InterfaceFile)
Parse, type check and rename each module we want docs for
This is the most expensive part, type checking and renaming one module implies checking all its dependencies transitively.
Build an Interface value (see Haddock.Types.Interface) for each module
Take all read InterfaceFiles and Interfaces to the render step to render the docs

Maybe it is possible to parse only (skipping type checking and renaming) a module and output a "draft" on how documentation might look like. Overall I think we would need to discuss the details on this may work out. Maybe you can find a sweetspot in the design space.

@alexbiehl, thanks for explaining how Haddock works, that's very helpful. I notice you mention type checking, but not compilation proper. So I guess type checking is the bottle neck, so I'll look into eliminating that.
Yes, the fast mode would only produce a "draft", since e.g. the hyperlinking probably wouldn't work if type checking were eliminated. Naively, in fast mode I want to reduce the compilation dependency to only parsing. I would think that would provide enough info to generate rendered documentation, but without hyperlinks.
This weekend I'll plan to start looking into modules you referenced above, and how I might eliminate the type checking.

Problem is with renaming, you have to tyoecheck to rename and to typecheck we load module and its dependencies too. I spent some time there before and it's not really viable to remove; it'd be possible to parse but most of the docs would be missing such as links, instance info, I think even more.
The best way to improve the situation is to not load twice. Currently Haddock is a separate step but all it does is is call GHC with few flags changed. Maybe if we can invert control somehow or get GHC to dump out all the info we need by default then we can do something. Notably if we can have a flag that says "ghc please dump out intermediate typechecked module result please" (basically serialise a structure we need + comment info) then I think we can perhaps work with that. A problem is that rename environment will be empty so might have to figure out if it could be populated after the fact. I'm sceptical to be honest...

I got caught up on low-hanging fruit, i.e. improving the documentation: https://github.com/haskell/haddock/pull/614, so I won't be making any progress on a haddock --fast this weekend. Really convenient to edit docs when the doc compilation time is so fast ;)
@Fuuzetsu , let me emphasize that the haddock --fast I have in mind will only be a "rough draft" mode (so maybe haddock --fast is the wrong name). The use case I care about is when I'm editing Haddocks, making minor changes, and I get frustrated because the full documentation build takes minutes. In these cases I'm not worried about producing the final form documentation, just seeing how my markup renders (e.g. I regularly do things like write / in @ code blocks and then get confused when I get italics), and if there are any parse errors (in my experience at work, people regularly write Haddocks but rarely run haddock, and so sometimes I get parse errors in other peoples Haddocks).
So, in my "fast" use case I don't really care if the renames are wrong or the re-exports are missing, I just need to see how the markup itself rendered. I would of course love it if a full haddock run could be incrementally fast, but I believe you guys when you say that would no small task. So, to start, I'm just going to look into doing the simplest thing that solves my problem.

I see. You want some --validate thing with oitput. It should be possible to make it fast-ish. Unsure how much work it will be to get renderer to take such partial info but shouldn't be too bad I think.

@Fuuzetsu Right, there already is: https://ghc.haskell.org/trac/ghc/ticket/2168. Which suggests GHC to pick up haddock docs. Haddock then just reads the interface and does its duty. This would also allow ghci to give documentations for names.

Parsing only is quick enough where that ticket is not a requirement tbh; most work is in loading the whole code which we won't need for this

Is someone still working on this?

@siddhanathan , I never made any real progress and have not looked at it since May.

I don't think anyone even started.

I've recently been feeling the pain of haddock's slowness (also referenced in issue #484).  Of course it would be better if it was faster.  But I've been wondering about an alternative approach for addressing this problem.  Could the haddock build be done incrementally?

There's on-going GSOC hoping to address speed problem as part of it: https://summerofcode.withgoogle.com/projects/#4975710121230336


gitconfig breaks commit info for detect command

Describe the bug
Running gitleaks detect --source . -v -r gitleaks.json  does not show commit specific infos. Fields like commit, message, author are all empty. The date field is empty or sometimes returns the value "0001-01-01T00:00:00Z"
To Reproduce

I'm using delta to have a nicer view of diffs (using this config: https://github.com/dandavison/delta#get-started)
Run gitleaks detect --source . -v -r gitleaks.json in a project where a key was commited
The report output will look like this:

[
 {
  "Description": "Generic API Key",
  "StartLine": 46,
  "EndLine": 47,
  "StartColumn": 18,
  "EndColumn": 1,
  "Match": "password=REDACTED",
  "Secret": "REDACTED",
  "File": "src/main/resources/application.properties",
  "SymlinkFile": "",
  "Commit": "",
  "Entropy": 3.75,
  "Author": "",
  "Email": "",
  "Date": "",
  "Message": "",
  "Tags": [],
  "RuleID": "generic-api-key",
  "Fingerprint": "src/main/resources/application.properties:generic-api-key:46"
 }
]

As a workaround, when settings $HOME to an empty string (so that the gitconfig is not applied), everything works as expected:
HOME= gitleaks detect --source . -v -r ./gitleaks.json
[
 {
  "Description": "Generic API Key",
  "StartLine": 46,
  "EndLine": 47,
  "StartColumn": 18,
  "EndColumn": 1,
  "Match": "password=REDACTED",
  "Secret": "REDACTED",
  "File": "src/main/resources/application.properties",
  "SymlinkFile": "",
  "Commit": "",
  "Entropy": 3.75,
  "Author": "Firstname Lastname",
  "Email"<EMAIL_ADDRESS>  "Date": "2020-04-06T12:47:36Z",
  "Message": "commit message",
  "Tags": [],
  "RuleID": "generic-api-key",
  "Fingerprint": "src/main/resources/application.properties:generic-api-key:46"
 }
]

Expected behavior
Adjustments to git or gitconfig should not break gitleaks reports. The gitconfig should be ignored when running gitleaks or default settings should be applied when trying to determine the commit info.
Basic Info (please complete the following information):

OS: MacOS Sonoma 14.1.2 (23B92)
Gitleaks Version: 8.18.1

cc @zricethezav

Thanks for bringing this up @martinhelfert. I think there is a duplicate issue somewhere, let me see if I can dig that up.

@martinhelfert hmmm I'm unable to recreate this bug unfortunately. I was however able to find out a fix for https://github.com/gitleaks/gitleaks/issues/1206 which is a similar issue.

I'm using delta to have a nicer view of diffs (using this config: https://github.com/dandavison/delta#get-started)

I tried using this config and see the difference in my git log -p output but surprisingly gitleaks was still able to parse the output of git log. Were there any other values you changed in the gitconfig?

I tried using this config and see the difference in my git log -p output but surprisingly gitleaks was still able to parse the output of git log. Were there any other values you changed in the gitconfig?

Yes, you're correct. I did some testing and the settings that caused the issue with the commit info are these two:
[log]
  date = relative

and
[format]
  pretty = format:%C(yellow)%h %Cblue%>(12)%ad %Cgreen%<(7)%aN%Cred%d %Creset%s

Whereby the use of either of the two settings already makes the commit info disappear.


change tracking

in the purple section up top you say change tracking is required. later you say it should be enabled.
[IMPORTANT] In order for the flow to trigger on the Dynamics 365 entity, the entity definition should have Change Tracking enabled. See Enable change tracking to control data synchronization

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f78faa65-bb08-e6bb-4b0e-6b1f3862b975
Version Independent ID: 4efbfdaa-b753-1aae-7f09-ef97fe2f544d
Content: Create a flow with Dynamics 365 (online) - Microsoft Flow
Content Source: flow-docs/connection-dynamics365.md
Service: flow
GitHub Login: @Mattp123
Microsoft Alias: matp

@JerryCRMI Thanks for pointing this out. I've updated the content to should that Change Tracking must be enabled: https://docs.microsoft.com/en-us/flow/connection-dynamics365


⚠ Jenkins Plugins Artifactory has degraded performance

In f113724, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1188 ms

Resolved: Jenkins Plugins Artifactory performance has improved in c4b7050 after 1 hour, 21 minutes.


Infinity seems Broken

Hi,
I unlocked infinity yesterday and got my first endorsement. A short time later, the infinity tab disappeared and I had to get my first endorsement again.
Then I played until I got ~11 endorsements, closed the game and when I reopened it today, I have to start again with my first endorsement.
I'm playing on android (in google chrome), with the website added to my Homescreen.
Do you have any idea why this could happen?

Hello,
Alright, that's very odd... I suspect it has something to do with being on android, since this game has not been thoroughly tested there (I don't have an android so that may be part of it).
I suspect that for some reason your autosave was disabled, although I have no idea as to why that may have happened...
Could you come join my discord (link in the game's option menu) and DM me so I can get a little more information?
If you'd rather not do that, I suppose we could just do it through github but that would be slower...
Thanks, Jacorb.

Hello,
Alright, that's very odd... I suspect it has something to do with being on android, since this game has not been thoroughly tested there (I don't have an android so that may be part of it).
I suspect that for some reason your autosave was disabled, although I have no idea as to why that may have happened...
Could you come join my discord (link in the game's option menu) and DM me so I can get a little more information?
If you'd rather not do that, I suppose we could just do it through github but that would be slower...
Thanks, Jacorb.

Sure, I joined your discord; could you give me your username?

Sure, I joined your discord; could you give me your username?

Yep, my username is Jacorb#8747

Yep, my username is Jacorb#8747


description too long

Hi do you know what it tells me there is a limit here, do you know how to programmatically set the description without this limit ?

Not possible unfortunately
See: https://github.com/fregante/chrome-webstore-upload/issues/71

Not possible unfortunately. The description field is used by Chrome, not the store (which usually requires more than 132 characters)
See: https://github.com/fregante/chrome-webstore-upload/issues/71

Awe that sucks.. I have a use case where I need to update my description based on my codebase kind of and had already made it work when encountered the 132 char limit.. how bad is the support for the chrome store it's weird. Is it like that With others browsers too ?
Do you think maybe with a solution with pupetteer like by simulating clicks? I would have to find a way to do the Google log in also.. not sure if feasible

Do you think maybe with a solution with pupetteer like by simulating clicks?

Maybe, but that would be an entirely different tool, not here.


Re-launch node API for open_neuro using the latest node API image

For reviewer: see https://api.neurobagel.org/docs. You should be able to see the two new attributes routes.

Looks good 🧑🍳, thanks Arman!


chore(Chromatic): remove chromatic connection

Describe pull-request
We have decided to remove the connection to Chromatic
Solving issue
Fixes: CDEP-3038

Looks good to me. Please also check if anything on Chromatic online dashboard has to be changed.

Yes! Not really sure what to look for there, but can see!

Looks good to me. Please also check if anything on Chromatic online dashboard has to be changed.

Yes! Not really sure what to look for there, but can see!

Check if you can log in to https://www.chromatic.com/ with your GitHub account, you should see SDDS and Tegel there so make sure to remove the connection there too.


Misc net fixes.

Codecov Report

Merging #9353 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9353      +/-   ##
==========================================
- Coverage   52.52%   52.52%   -0.01%
==========================================
  Files         201      201
  Lines       25360    25359       -1
  Branches     5300     5300
==========================================
- Hits        13320    13319       -1
  Misses       9945     9945
  Partials     2095     2095

Impacted Files
Coverage Δ

subsys/net/ip/ipv6.c
39.73% <100%> (+0.04%)
:arrow_up:

subsys/net/ip/net_pkt.c
63.79% <100%> (-0.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2300a59...c113b35. Read the comment docs.


Add @codeekage as a Member

Adds @codeekage as a member.
CommComm Membership Checklist:

[x] Invite to CommComm GitHub Team (and Node.js GitHub org, if not already member)
[ ] Submit PR to add to the commcomm email alias

@codeekage could you please confirm that the listed email address is the one that should be added to the CommComm alias?

confirm the use of<EMAIL_ADDRESS>as alias email.

Thank you @chowdhurian

Can this be merged or its more approvals?

@codeekage have you submitted a PR to add to the commcomm email alias ?

@WaleedAshraf  I just did thank you!! 🙏

Going to merge this. Welcome @codeekage 🎊


增加noticeTop字体,颜色,状态

增加noticeTop字体,颜色,状态

Thank for your contribution~ 👍
But I'm sorry that I cant merge it because of two reasons:

you should not change current apis, you should add some.
magic number can not be accepted at all.

Maybe you can start another pull request. Thanks very much!


Edit comments

I think it's good idea to allow editing comments. I made typo few times and I was not able to fix it.
Any thoughts?

that would be great!


fix: change chown to --recursive for reliability and readability [APE-1072]

What I did
changed chown command in dockerfile to --recursive
may fix: # https://github.com/ApeWorX/ape/issues/1476
How I did it
changed chown command in dockerfile to --recursive instead of -hR
How to verify it
$ docker build -t ape .
$ docker run -it --entrypoint /bin/bash ape
harambe@8650e9ff7e66:~/project$ ls -la
total 8
drwxr-xr-x 1 harambe harambe 4096 May  4 15:48 .
drwxr-xr-x 1 harambe harambe 4096 Jun 12 20:55 ..

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

$ docker build -t ape . --no-cache
[+] Building 99.6s (17/17) FINISHED
 => [internal] load .dockerignore                                                                           0.0s
 => => transferring context: 65B                                                                            0.0s
 => [internal] load build definition from Dockerfile                                                        0.0s
 => => transferring dockerfile: 1.80kB                                                                      0.0s
 => [internal] load metadata for docker.io/library/python:3.9-slim                                          1.9s
 => [internal] load metadata for docker.io/library/python:3.9                                               2.0s
 => [builder 1/4] FROM docker.io/library/python:3.9@sha256:6e9c45244cf9ef21fe9310f6c7bab754c5e4d23c819421f  0.0s
 => CACHED [stage-1 1/7] FROM docker.io/library/python:3.9-slim@sha256:5f0192a4f58a6ce99f732fe05e3b3d00f12  0.0s
 => CACHED [builder 2/4] WORKDIR /wheels                                                                    0.0s
 => [internal] load build context                                                                           0.0s
 => => transferring context: 44B                                                                            0.0s
 => [stage-1 2/7] RUN useradd --create-home --shell /bin/bash harambe                                       0.6s
 => [builder 3/4] COPY ./recommended-plugins.txt ./recommended-plugins.txt                                  0.0s
 => [builder 4/4] RUN pip install --upgrade pip     && pip install wheel     && pip wheel -r ./recommende  43.2s
 => [stage-1 3/7] COPY --from=builder /wheels /wheels                                                       0.1s
 => [stage-1 4/7] COPY ./recommended-plugins.txt ./recommended-plugins.txt                                  0.0s
 => [stage-1 5/7] RUN pip install --upgrade pip     pip install --no-cache-dir --find-links=/wheels -r ./  50.9s
 => [stage-1 6/7] WORKDIR /home/harambe/project                                                             0.0s
 => [stage-1 7/7] RUN chown --recursive harambe:harambe /home/harambe                                       0.5s
 => exporting to image                                                                                2.2s
 => => exporting layers                                                                                2.1s
 => => writing image sha256:d2071620b1873e5e1580f780bc63a6f5dbafeb7a1b26545bfee3d51642fc7d8c                0.0s
 => => naming to docker.io/library/ape                                                                      0.0s
~/ape/ape$ docker run -it --entrypoint /bin/bash ape
harambe@605d46fe4764:~/project$ ls -la
total 12
drwxr-xr-x 1 harambe harambe 4096 Jun 12 22:22 .
drwxr-xr-x 1 harambe harambe 4096 Jun 12 22:22 ..


FEC-39: Fix models related to Batch 2 (Part 1)

Summary
In this PR, there are 3 main changes that are done to the existing models in the project. The changes are related to the commons, inventory-entry, and product-type models.
Common

Introduced a new model called discounted-price

Inventory Entry

Updated the transformer file to conditionally send the supplyChannel, making it optional

Product Type

Added new presets for enum and localized enum types

@jaikumar-tj please bear in mind the InventoryEntry model is already being updated for the same reason in this already opened PR.


samples: usb: hid-keyboard: enable and use remote wakeup on button press

USB remote wakeup capability is a common feature of keyboards, allowing them to wake up a suspended host. Currently there is no USB sample that demonstrates remote wakeup, which makes basic evaluation of the functionality non-trivial.
Modify the hid-keyboard sample with a minimalistic solution of demonstrating remote wakeup capability. While it is not required to have been configured prior to suspend to issue a wakeup request, from usability perspective I'd say it makes sense.

"While it is not required to have been configured prior to suspend to issue a wakeup request, from usability perspective I'd say it makes sense." from USB perspective it is slightly different. The device is not configured to "issue a wakeup request", but the device can be either allowed to or prohibited from issuing wakeup request.
If host suspended device with cleared remote wakeup feature, then every button press will result in an error log entry regardless how many times it is pressed.

Right, what I meant was that there is no hard dependency between the HID interface being configured and the ability for remote wakeup (since that is controlled independently with a SET_FEATURE request).
I noticed that the device_next stack is not clearing this flag when the host sends a reset signal, even though the USB 2.0 spec requires it:

The Remote Wakeup field indicates whether the device is currently enabled to request remote wakeup. The
default mode for devices that support remote wakeup is disabled. If D1 is reset to zero, the ability of the
device to signal remote wakeup is disabled. If D1 is set to one, the ability of the device to signal remote
wakeup is enabled. The Remote Wakeup field can be modified by the SetFeature() and ClearFeature()
requests using the DEVICE_REMOTE_WAKEUP feature selector. This field is reset to zero when the
device is reset.

I noticed that the device_next stack is not clearing this flag when the host sends a reset signal

Can you submit a separate PR with a fix?

I noticed that the device_next stack is not clearing this flag when the host sends a reset signal

Can you submit a separate PR with a fix?

Here you go: #79410


feat(group_theory/eckmann_hilton): add Eckmann-Hilton

TO CONTRIBUTORS:
Make sure you have:

[x] reviewed and applied the coding style: coding, naming
[ ] for tactics:

[ ] added or adapted documentation in tactics.md
[ ] write an example of use of the new feature in tactics.lean

[x] make sure definitions and lemmas are put in the right files
[x] make sure definitions and lemmas are not redundant

For reviewers: code review check list

I'm not sure if this is the right way to formalize it.
Especially, using has_mul as some operator, but not writing down * itself.  The idea of the has_... classes is usually to use them as symbols, as syntactic type classes. It doesn't make much sense to use them if you don't use the syntax.
What about statingis_unital using the same style as in lean/library/init/algebra/classes.lean:
structure is_unital (α : Type u) (op : α → α → α) (o : out_param α) :
  extends is_left_id α op o, is_right_id α op o

and also add a is_distrib for it?


Performance of SHOW MEASUREMENTS needs improvement

Bug report
System info: [Include InfluxDB version, operating system name, and other relevant details]
InfluxDB 0.13+
Steps to reproduce:
query SHOW MEASUREMENTS, it often takes multiple seconds.
@mjdesa is working up a test of response times vs. measurement count.

Single data node cluster. Instances type m4.xlarge.

@mjdesa so in all cases SHOW MEASUREMENTS returns in less than 1 second for ~40000 measurements? Using 0.13 or 1.0 looks like sub-second response times until > 100k measurements?

@beckettsean that seems to be the case.

The results could be a little bit artificial because I only have one series for each measurement. If anyone thinks it'd be worthwhile I can extend this test to check what happens when each measurement has many series.

@benbjohnson @jsternberg do you think the performance of SHOW MEASUREMENTS would be affected by the number of series in each measurement? My gut says not enough to make it worth testing.

Without overly complicating the testing methodology, I'd be curious to see side-by-side results for 200k series fetched as one big result vs. two fetches of 100k records apiece using pagination.  Seems like it should take the same amount of time but does it?  I don't have a sense for how much transactional overhead there is independent of the actual query being run.
Are there ideas on board for caching results or otherwise speeding up the response time?  Even if you just kept a stateful in-memory copy of all series so they could be returned instantly that would be really helpful.  I wouldn't think the overhead would be that much to maintain such a data structure but I'm just guessing.
If there are new patches to the code I can probably test them out from the daily builds.  Hope there is movement on this issue soon. :)

I don't think that the number of series will affect the timing of this. I do think it is possible that the number of shards can affect the timing of this in a negative way. @desa is it possible to extend the test to also include the time period of multiple shards? In the tests you have done so far, what's the number of shards?
I don't know if it's significant enough to matter, but it can potentially be a confounding variable that isn't accounted for. When testing, you may want to try setting the shard duration to something like a year just to make sure that it doesn't affect the results.

@jsternberg I made a note of to this for future reference if we do decide that we want to test this with many shards.


Position ring position Bug?

I am trying to place loading ring indicator at the center of subView of SuperView. Not Placing At Center

+1

+1


Run ab mode every run to generate images

This fixes ab images not being generated by default

... and following my emails in order I didn't see this PR until pushing the equivalent change. Thanks for finding this.

Thanks. It looked like you might have had a reason so I was trying to follow up beforehand just in case.


Utils

A bit of a refactor and tidy up of various bits of utility code.

@tjgalvin are you able to have a quick glance at this before I merge into imager?


JSONConverter helper

This is an alternative API for the changes in #377. It also cleans up the unit tests so we don't need to import StarWarsAPI in more places (hoping we can get rid of it completely eventually).
@TizianoCoroneo @calvincestari @BobaFetters I think this is an improvement on the API in the other PR. Let me know what you think.

LGTM! Do we have a test for the GraphQLError conversion anywhere already?

Yes, it's at GraphQLResultTests.swift:69


Unit testing for reader and writer

Problem description
The existing tests do not provide adequate coverage because they're unable to simulate a wide variety of edge cases.   For example, the writer has logic for write failures and async writes that isn't exercised.
Suggestions for an improvement
Develop a new set of tests that use a mock Pravega client and the Flink-provided operator test harness.  See io.pravega.connectors.flink.EventTimeOrderingOperatorTest for an example.
Consider moving those tests that rely on an embedded Pravega server to intTest.

All readers and writers have unit tests now, except for FlinkPravegaInputFormat which is covered by #78


Add ltr feature generator for MSMARCO

Add a basic ltr feature generator for MSMARCO in FeatureExtractorCli pipeline + tests

@KamyarGhajar can you send me a sample command-line invocation so I can play with this myself?

@lintool this is a sample comman-line invocation to make a ltr feature set for MSMARCO:
nohup target/appassembler/bin/FeatureExtractorCli -collection msmarco -index lucene-index.msmarco-doc.pos+docvectors+rawdocs -qrels src/main/resources/topics-and-qrels/qrels.msmarco-doc.dev.txt -topics src/main/resources/topics-and-qrels/topics.msmarco-doc.dev.txt -output msmarco-docdev-ltr-features.txt &

I am working on making the BM25FeatureExtractor dependent on the Lucene BM25Smilarity and not a replicated copy of it.


Choice selected in Dialogue

Hi ! I want use this dialogue for my notification preference. I want keep Notification on checkbox default checked. if user uncheck it...I want keep it unchecked. Can I do it in this ?
Thanks

Hi. Yes, you can.
new LovelyChoiceDialog()
    .setItemsMultiChoice(items, checkedStates, listener)
    .show();


Create multiColorTag.py

Added a multi color tags widgets so you can do tags like this below
same settings as the default GroupBox but with these 2 extras
tag_colors=widgetColors,
this_current_screen_border=widgetColors,

example code of widgetColors
widgetColors = [
    "ff5959",  # 1
    "59ff59",  # 2
    "ffff59",  # 3
    "9059ff",  # 4
    "ff59f9",  # 5
    "59fff9",  # 6
    "e5e9f0",  # 7
    "43515e",  # 8
    "ffa6a6",  # 9
    "a6ffa6",  # 10
]

just also made it so that if the array is smaller then the amount of tags (2 colors but 5 tags) then it will loop though the colors again.

I don't think adding this is the best idea. If it works for you, you can use it in your config.
The GroupBox widget needs some improvements, maybe even a rewrite. Actually, there's already a list of feature requests for this widget (https://github.com/qtile/qtile/discussions/4365), and this functionality has already been asked for.
The issue with this patch lies in its multi-monitor support; on the second monitor, I don't know which group I'm currently in (I also don't know which groups are active and inactive):

My solution to that was reversing the line highlight method on the other monitors, which is why I previously attempted to implement https://github.com/qtile/qtile/pull/3586. However, I don't believe that was the best solution either, although it's what I'm currently using in my setup.

Monitor 1:

Monitor 2:

Another issue is that it only works well with the line highlight method (it might also work with the border method). As a result, this would break the other highlight methods.

@elParaguayo, what do you think is the best way to implement this? I've been wondering about it for a while now, and I'm not sure how other bars like Polybar handle all of this, as I've never used it.
Also, wouldn't it be better to add this as a parameter of the Group class? That way, it wouldn't need to be done directly from the widget.
Something like:
groups = [
    Group("a", color="#f5e0dc"),
    Group("b", color="#f2cdcd"),
    Group("c", color="#f5c2e7"),
]

@elParaguayo, I never told you, but the idea of reversing the line on the second monitor for the line highlight method was taken from xmobar. I think they have a similar feature, and I thought it would be good to have it in Qtile as well.

I don't think adding this is the best idea. If it works for you, you can use it in your config.
The GroupBox widget needs some improvements, maybe even a rewrite. Actually, there's already a list of feature requests for this widget (https://github.com/qtile/qtile/discussions/4365), and this functionality has already been asked for.
The issue with this patch lies in its multi-monitor support; on the second monitor, I don't know which group I'm currently in (I also don't know which groups are active and inactive):

My solution to that was inverting the line highlight method on the other monitors, which is why I previously attempted to implement https://github.com/qtile/qtile/pull/3586. However, I don't believe that was the best solution either, although it's what I'm currently using in my setup.

Monitor 1:

Monitor 2:

Another issue is that it only works well with the line highlight method (it might also work with the border method). As a result, this would break the other highlight methods.

@elParaguayo, what do you think is the best way to implement this? I've been wondering about it for a while now, and I'm not sure how other bars like Polybar handle all of this, as I've never used it.
Also, wouldn't it be better to add this as a parameter of the Group class? That way, it wouldn't need to be done directly from the widget.
Something like:
groups = [
    Group("a", color="#f5e0dc"),
    Group("b", color="#f2cdcd"),
    Group("c", color="#f5c2e7"),
]

So... I don't think this PR will get merged. We need to fix the main groupbox widget in qtile and I don't want to be maintaining a separate one.
I still don't know what the best solution looks like here!


riscv64: Improve pattern matching rules for FMA

👋 Hey,
This PR reworks our FMA pattern matching to be slightly less verbose using the suggestions provided by @jameysharp on https://github.com/bytecodealliance/wasmtime/pull/8588#issuecomment-2103773727.
It additionally adds the (fma x (splat y) z) pattern for vectors, which can be proven to be equivalent to (fma y (splat x) z). See https://github.com/bytecodealliance/wasmtime/pull/8588#issuecomment-2105622411. I've only added ISA tests for these patterns since it turns out they are already present in the SIMD FMA runtests.
I think all of the patterns matched here are sound although I can't formally prove all of them.  This comment https://github.com/bytecodealliance/wasmtime/pull/8588#issuecomment-2105622411 describes most of the validations that I did.

Redirecting to @jameysharp since it seems like he has more context here.


ARROW-2663: [Python] Make dictionary_encode and unique accesible on Column / ChunkedArray

Rebased. Will merge on green build

Codecov Report

Merging #2166 into master will increase coverage by 2.42%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
+ Coverage    84.2%   86.62%   +2.42%
==========================================
  Files         288      232      -56
  Lines       44091    41371    -2720
==========================================
- Hits        37127    35838    -1289
+ Misses       6933     5533    -1400
+ Partials       31        0      -31

Impacted Files
Coverage Δ

python/pyarrow/tests/test_array.py
100% <100%> (ø)
:arrow_up:

python/pyarrow/table.pxi
68.93% <69.23%> (ø)
:arrow_up:

go/arrow/type_traits_numeric.gen.go

go/arrow/array/bufferbuilder_numeric.gen.go

rust/src/array.rs

go/arrow/datatype_numeric.gen.go

go/arrow/array/builder.go

go/arrow/array/booleanbuilder.go

go/arrow/array/bufferbuilder_byte.go

go/arrow/array/numericbuilder.gen.go

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd913e...e59f5fa. Read the comment docs.


Bump require_sphinx() to Sphinx 6.0

Sphinx 6.0 was required in 591780b.
A

Thank you for this! ^.^


Query: Implement First/Single/Last OrDefault throwing behavior

As per design.

Since for Single(OrDefault) we want to throw exception but we want to treat it as FirstOrDefault in subquery (thanks to @maumar), we can swap out all Single to First except from top level in advance.


Normalize fuel costs to roughly 1 fuel per executed instruction

Closes https://github.com/paritytech/wasmi/issues/701.


Docs need to be fixed

For example, the table of contents don't generate properly, though I think @Berserkware is taking care of this. I on the other hand will be working on the ReadTheDocs side of things, checking for general style issues.

Thank you! The docs will be rewritten to improve overall quality, and I will also fix smaller things, like the table of contents as you said.


webview: will-navigate, did-navigate and page-favicon-updated navigation events

Related #1378 and #1079 , not quite sure on how to achieve the various mutations for page-url-set. @zcbenz any clue on why the test for will-navigate gets called for spec/index.html too ?
Depends on https://github.com/zcbenz/native-mate/pull/1

Added getFavicon api to retrieve current favicon as nativeimage. Also have worked around the webview spec issue.

@zcbenz any clue on why the test for will-navigate gets called for spec/index.html too ?

I have no idea, I'm surprised that it happened.

I don't think we should add did-navigate event for now, since the history control (https://github.com/atom/electron/issues/1249) is still a mess.
And for the will-navigate event, it seems that a navigation happened in the webview page won't trigger it?

About did-navigate , right now i m triggering it only if its a navigation to a different page than the previous , so the reload entry behaviour shouldnt affect it load_details.is_navigation_to_different_page()  right ?
You need will-navigate to trigger after a navigation ?

One caveat with current did-navigate is , it wont trigger for in page navigation (eg: link based). Is that fine ?

Made the changes except for did-navigate removal and pending doubt on will-navigate event.

One caveat with current did-navigate is , it wont trigger for in page navigation (eg: link based). Is that fine ?

The purpose of did-navigate event is to write browsers, so triggering for page navigations is required.

You need will-navigate to trigger after a navigation ?

The will-naviage event is used for preventing users to visit certain links, it should be triggered when users click a link in the webview.

We should probably move did-navigate and will-navigate to separate PRs since it seems to take much more work to make them full functional.

Ah now its clear , thanks! have removed them, will try a new PR later.


Revert PowTargetTimespan

nPowTargetTimespan has nothing to do with KGW and only applies to difficulty of Scrypt blocks.

Same goes for DifficultyAdjustmentInterval


feat: Track memory usage in targets and drain record batch if a treshold is passed

Feature scope
Targets (data type handling, batching, SQL object generation, etc.)
Description
Proposal
As a target user, I would like to configure a max allowed memory footprint for each record. Perhaps memray can be used.
Related

https://github.com/meltano/sdk/issues/134
https://github.com/meltano/sdk/issues/1626

Still relevant


fix: generate command with running cross-device

Fixes #2850
What this PR solves / how to test:
When using Windows (and maybe other operating systems), a renameSync can throw a Error: EXDEV: cross-device link not permitted error when renaming across drives. This is very common on Windows installs that may have Windows on C:/, but their user files on another drive like E:/.
This PR resolves that by first trying the renameSync (will be much faster than copying files on the same device, so worth doing first), but then catching the EXDEV error and handling it specifically afterwards.
For tests, I don't really know how to properly approach testing this cross-device behaviour if I'm honest - it'd need another filesystem (maybe mocked?) on some other virtual device - and most generate tests appear to be skipped right now anyway. If that's something folks would like to see, I'm going to need some guidance/examples on how best to do that testing. I ran manual tests locally on my Windows 10 machine using generate project-name https://github.com/cloudflare/workers-sdk/templates/experimental/worker-rust, as well as in WSL and on my Macbook just to ensure the previous behaviour wasn't impacted across a few OSes, and all worked well.
Author has included the following, where applicable:

[ ] Tests
[x] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

It seems like fs.cp is used in other places in the codebase, so it should be safe to use here too. I've gone ahead and removed the original dependency on fs-extra.

I note that you are skipping the two unit tests. Do they not work?

Yeah I attempted a very dumb test by temporarily mocking renameSync to always through the EXDEV error so the fs.cp codepath would be hit, but it didn't seem to stick. I'm not sure if runWrangler in tests is spawning a brand new process and therefore doesn't have the mocks? I'm really not sure.

I wonder if we could create a network mapped drive that points to a local folder?
support.microsoft.com/en-us/windows/map-a-network-drive-in-windows-29ce55d1-34e3-a7e2-4801-131475f9557d#ID0EBD=Windows_11

This might work 🤔 I've never had to test anything like this in CI before. Prior libraries that have solved this seem to just handle it by naively mocking: https://github.com/andrewrk/node-mv/blob/645d8f4c783abf84204be704098fdd41f36ab195/test/test.js#L14

Thanks Pete! 🎉


Update min supported k8s version to 1.24

Please provide a description of this PR:
Similiar to what we've done in https://github.com/istio/istio/pull/43236

In response to a cherrypick label: new pull request created: #45444


Auto Build

I used nodejs to write a program that automatically packs resource packages
The content of release is in .github/release.md, please go to that file to modify

Hello ObcbO, thanks for your efforts to extend the project.👍 Unfortunately I am very busy at the moment and do not have time to review it properly. I will come back to it in June.


Implement the SMS provider

I tried to register my own SMS Provider. I will sent a Pull Request later on, when I've got it to work, but for now the implementation is hidden in an internal class.
I've implemented your BaseSMSPRovider-class with the following code:
`using PerplexLibSMS.Interfaces;
using PerplexLibSMS.SMSApis;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
namespace _2FA.Code
{
public class TwoFactorSMSPerplexProvider : Orc.Fortress.SMSProvider.BaseSMSProvider
{
public override void SendSms(string number, string message)
{
ISMSApi api = new CMProvider();
api.From = "+31263830734";
api.To = new List() {number};
var result = api.Send(message);
    }
}

}`
But then what? I expected that maybe in Umbraco the dropdownlist with "Active SMS Providers" would contain "TwoFactorSMSPerplexProvider" or something like that. Also I tried to set a value like 'TwoFactorSMSPerplexProvider' into the table FortressSettings but that didn't work either.
Can you help me out?
Thanks, Jeffrey

We are encouraging folks to not use SMS as its insecure (well sort of) so we've been using Authenticator by Google.
Will need to get @steroberts89 to write up a little doc on how to create providers as its his black magic that does that bit and its all in his head :)

I've created a new issue, #9, to cover the need for documentation on how to extend functionality. I'm going to close this issue as wontfix, though, as we won't be implementing an SMS provider ourselves.


#5 add some tests

@Vichukano many thanks, but I'm not sure it will pass our quality check. Try to run mvn clean install -Pqulice on your computer.

@yegor256 thanks! code style fixed

@Vichukano looks much better now! See my comments above

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 2min)

@Vichukano many thanks!


Issue with k8s.io/docs/admin/authentication/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
generating certificates with openssl is missing the required IP SANs
dashboard is not happy without...
Error while initializing connection to Kubernetes apiserver. This most likely means that the cluster is misconfigured (e.g., it has invalid apiserver certificates or service accounts configuration) or the --apiserver-host param points to a server that does not exist. Reason: Get https://<IP_ADDRESS>:443/version: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs
(/etc/kubernetes/apiserver:KUBE_SERVICE_ADDRESSES="--service-cluster-ip-range=<IP_ADDRESS>/16")
Proposed Solution:
still investigating but subjectAltName openssl option seems the solution
Page to Update:
http://kubernetes.io/...

@ahmetb :wave:

yes. There seem to be two problems. OpenSSL by default generates v1 certificates, which seems not supporting SAN well. Even when switching to v3 certificate, you will have to include the service cluster IP of the API server into the certificate.

because it doesn't contain any IP SANs thats the issue if one follow the documentation because openssl req -new -key server.key -subj "/CN=${MASTER_IP}" -out server.csr does not include the required subjectAltName

@cyberh0me 👋

so either delete the openssl part from the documentation or add a sentence the api server certificate MUST have a subjectAltName and include the FQDN's and IP's

Thanks for the update. I'll flag this issue as Actionable for doc updates.

/assign


Sweden Central for API-M v2

API-M v2 is available in Sweden Central as well.

@dlepow
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @LazaUK for pointing this out! You're right to propose the doc update. To manage the merge conflict, I'll pull the commit into our private repo, resolve the conflict, and publish from there. Accordingly, I'll close this PR. Thanks again for the fix.
#please-close


New package: oxen-io.lokinet version 0.9.11

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please recheck these Pull Request carefully before merging. If it is a incorrect-removing Pull Request and the URLs don't have any issue while manual checking, please close this Pull Request directly(It's best to let Exorcism0666 know).

良い一日をお過ごしください！

Hi @Exorcism0666,
The installation isn't unattended. Is there an installer switch to have the package install silently?
(Automated response - build 522.)

@stephengillie done!

The community have created a few tools in https://github.com/microsoft/winget-pkgs/tree/master/Tools
I've not used this in a loong time, but SandboxTest.ps1 should be one you want to use :)
PRTest.ps1 if you have a PR already
(You need winget-pkgs cloned to your machine for these scripts)

Just realized i answered the question from https://github.com/microsoft/winget-pkgs/pull/132532#issuecomment-1877776567 :D


filezilla.json: Updates to version 3.32.0. Switched sources from sourceforge to original sources.

Since sourceforge has not been updated to the latest version, I switch to the original download sources from the website.

Can you change dl3.cdn to download so it's not locked to one mirror?
Can you also add the following to autoupdate? This allows extracting the sha512 checksum.
        "hash": {
            "url": "https://filezilla-project.org/download.php?details=$basename",
            "find": "([a-fA-F0-9]{128})"
        },

I changed the download links and added the hash url for the updates.
I successfully updated my filezilla.

Thanks 👍
FYI: Creating a branch to make a PR saves you the merge of the master branch 😃👍

@r15ch13 Why not use the sha512 file for hashes?
        "hash": {
            "url": "https://download.filezilla-project.org/client/FileZilla_$version.sha512"
        }

@se35710 Good point! I didn't see them 😁


[bug] fix Mysql Sync Table Unable to synchronize newly added tables

Purpose

Linked issue: close #2848

Tests

API and Format

Documentation

@yuzelin PTAL. thx


Issue/8

feat: updates Deleter to take in non-singleton twilio instance
test: update new method call signature to take in instance of twilio
fixes #8

Looks good! Merge it!


Audio/Player/Timestamp desyncs from original audio

Audio Player & Timestamp often desync from the audio that SHOULD be playing at that specific time. After this issue occurs, when you click on some of the other timestamps that were working - they sometimes become desynced as well. It shows the correct time on the player and timestamp however the audio is different than what you are supposed to be hearing at that time. I'm currently using a 46-minute MP3 file.
When clicking on the "Edit This Block" It seems to fix the issue temporarily, but the desync eventually occurs again after awhile of playing audio and clicking timestamps.
Hope I was clear in explaining the issue, difficult for me to explain. Nice plugin btw, looking forward to using it.

when you click on some of the other timestamps that were working - they sometimes become desynced as well. It shows the correct time on the player and timestamp however the audio is different than what you are supposed to be hearing at that time

Your situation seems a bit unusual. To clarify, are you experiencing different audio at the same timestamp during playback? Have I understood your issue correctly?
If the timestamp on the highlighted subtitle aligns with the player’s timestamp, the issue may likely be related to the bitrate or encoding of the MP3 file, considering Obsidian handles the playback.
To better understand what's happening, could you check a few things for me? Please let me know if this out-of-sync also occurs in the following situations:

When playing other audio files, preferably from different sources.
When you disable the plugin and play the audio file directly in Obsidian.

Correct, Sometimes timestamp plays correctly, sometimes it desyncs and plays different audio at the same timestamp.
I was unable to replicate this issue with a 4 min .webm audio file that I received from a different source.
I went back to check the audio file that caused me to open this issue. And I noticed the audio file says 46:50 is the length, but it's playing until 47:06. (This length issue appears only in obsidian itself, even with this plugin disabled; and it did not occur when playing the media file outside of obsidian.)
So, I converted the mp3 file to a .wav, since you mentioned this could be a bitrate or encoding problem of the mp3. Seems to have fixed the length duration issue in Obsidian. And now...... I haven't been able to replicate the desync issue either. Thank you for solving my problem! Apologies for this not being related to your plugin, didn't realize it was a file/obsidian issue.

No worries, I'm glad to hear that the issue has been resolved! 😊👍


Document how to utilize the framework

Documentation needs to be written to address how to use the framework with a tool.

How to use but also how to install it. Documentation must be explicit about:

it’s a shared package that can already be there
upgrade is allowed and expected
downgrade must not happen
everything must happen in virtual env when installing new modules

@ygini please check the readme and see what you think now

Here is some comments on a first read:

the link to File System Basic does not have any info about SystemFrameworks folder
really good to have used Versions/3.8
add a small howto about virtual env and how to create one, with some smart example (like in /Library/Application Support/com.example.app/python3_venv)
add comments about how to bundle this as a raw package in distribution package for any apps that want to use it

Using Python virtual environments seems out of scope for this project. Even if they are good practice, they are certainly not required, and there’s no reason to scare off admins that just want to get a simple script running.

@gregneagle documentation is all about avoiding people to hurt themselves with your product, to avoid complains when you will erase everything with your next version.
So even if it's not needed for basic script that does not require dependencies, it will be at some point. And there it will be really interesting if we encouraged every future users to use the product according to our mindset, to be as much as we can futureproof.

Then the "documentation" as part of this project should be:
As always, virtual environments are recommended for Python projects of any complexity. Learn more here: https://virtualenv.pypa.io/en/latest/ and https://docs.python-guide.org/dev/virtualenvs/
And nothing more. It's really not this tool's job to repeat and maintain documentation like that.

My opinion here mirrors Greg's.
This should provide a reference python implementation for MacAdmins and nothing more. If a specific library is needed, having links out to virtual envs makes a lot of sense (or pex files or pyinstaller bundles).
I think those are a better solution for shipping libraries than polluting the managed python framework. We should also be very clear in the documentation that people should not pip install to this python unless they enjoy pain.

Have you considered using the wiki for the documentation?

Yes. Let me turn it on.

Any thoughts for having a disclaimer or list of items that speak to what this repo is not?
Some thoughts that I had ...

Does not contain everything ...
is not intended to cover all scenarios ...
Not designed to replace py3 package from python.org

Care to elaborate? Define everything.
Thanks,
Erik Gomez

From: captam3rica<EMAIL_ADDRESS>Sent: Monday, June 15, 2020 8:33:13 PM
To: macadmins/python<EMAIL_ADDRESS>Cc: Erik Gomez<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [macadmins/python] Document how to utilize the framework (#3)
Any thoughts for having a disclaimer or list of items that speak to what this repo is not?
Some thoughts that I had ...

Does not contain everything ...
is not intended to cover all scenarios ...
Not designed to replace py3 package from python.org

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/macadmins/python/issues/3#issuecomment-644477211, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLL6GETO37TA3UDHMXNER3RW3DVTANCNFSM4N5YWBIQ.

yeah your right. Defining everything is probably not the best idea ...
I think, after looking at the Notes section, it highlights some of the areas that this repo is not intended to handle.

I personally think the documentation is sufficient for this version and as others said, some of the suggestions here do not necessarily make sense for this project.
That said, the wiki is now open and PR's are welcome. For now I will be closing this issue.


Has anyone been able to train a different network architecture?

I am considering how I can modify this framework to train a different network, say Inception V3.
I know I have to modify the VGGnet_test.py and VGGnet_train.py files to match Inception's architecture (can be found here: https://github.com/tensorflow/models/blob/master/inception/inception/slim/inception_model.py)
Also the tensor to take the Inception's features from (I think is) mixed_10/join (see pic below).
Has anyone had any success with this? Or could provide some insight to what else could be required?

Not yet, but this error comes to mind, there might be others https://github.com/smallcorgi/Faster-RCNN_TF/pull/83/commits/84c52bac6d1d16c727ce7120acf9d1773b291d51
Happy to join in this endeavor after I manage to use a different dataset (I expect a bumpy road, eg. n_classes is fixed to 21 in VGGnet_train.py

I copied the original VGGnet_train.py and VGGnet_test.py with different names
After that, I modified these files (only difference that I've made was the number of output classes)
Then I edit get_network function for these in the factory.py in lib/networks
Also, you may need to construct a new dataset handler in lib/datasets and alter train.py and test.py in lib/fast_rcnn


[Feature] Add support for kotlin

add tree-sitter-koltin parser: https://github.com/fwcd/tree-sitter-kotlin
add query-files for the features
add test case for outline

Thanks. I'll also lobby to revisit the decision to make kotlin a builtin language


Consider more standardized deployment process.

Some specific goals:

Consistent tagging of releases.
Marking releases on GitHub.
Including a changelog.

For the changelog, I know there's some tooling to make auto-generating changelogs easier if you follow some specific patterns in commit messages, and I believe GitHub has some automation to enforce formatting in commit messages with regexes. Is that worth exploring?

Should consider cargo-dist for this.

Having spent more time with cargo-dist, I now understand that it's really just for binaries, so it wouldn't make sense here. That said, we really ought to have a better process for publishing new versions, as I've already messed it up more than once.

I've made quite a bit of progress here with defining a cargo xtask release command which handles changelog generation and publication of new versions to Crates.io and to GitHub, which should also hand off to cargo-dist in CI to publish new versions of the OmniBOR CLI. That said, I haven't yet been able to fully test things, and I'm currently held up by a limitation in cargo-release. Hopefully I can close this out soon.

Done!


Fix initial context documentation

Hey folks, just realized that I didn't update the docs after changes. And generally messed them up. Fixing it.

@pyromaniac thanks and no worries - first I need to add docs for 1.6.0 because I keep forgetting this part is not automated, so I gotta do it and then I'll merge this in as it'll have to go to release-1.6 branch too.

@pyromaniac OK it's been deployed, thank you! https://dry-rb.org/gems/dry-validation/1.6/rules/#rules-context


Use frame for sandboxed component preview, stricter accessibility checks

🛠 Summary of changes
Adapts component previews to use an isolated preview sandbox using iframe elements.
The intent is to be able to enable stricter automated accessibility tests, which were previously not possible and identified as a follow-up goal due to the fact that previews assume an isolated render environment, but didn't actually isolate.
This is similar to #418 and adapts some of the postMessage-based frame communication, though in a much more limited capacity, as the frame content itself is generated statically by Jekyll, and the only frame communication is necessary to resize the preview on content changes.
Draft: Currently, proof-of-concept only adapts the Accordion Default preview.
📜 Testing Plan
Verify there is no detectable difference in the preview of a component, e.g. the Accordions Default preview.
👀 Screenshots

I'm staring at this visual regression diff and struggling to find the difference 😅

One interesting idea that this could enable is to adapt visual regression tests to take screenshots of individual examples in isolation, to avoid common failures due to changes in content or navigation.

General thoughts after I've started migrating a few more examples:

It creates some fragmentation where the code samples live in a different folder from the rest of the documentation, which could become burdensome to keep track of
On the other hand:

It could be beneficial to keep the content documentation focused on the content and the different variants available (subheadings) and not on the actual code
There could be opportunities to automate how these individual examples are compiled together to produce the documentation page

I think I might pause on this for now, and may return to it later.
One idea I've been thinking about that may simplify the effort is to try to find a way to generate the embed pages dynamically via a custom Jekyll tag like {% code_example %}, so the code snippets can remain in the original documentation files, while having the same end-result of creating individual embedded pages.


\n not working in 3.1

It may be due to the ruby upgrade - but things like this will not work in the next release.
https://github.com/OSC/ood-documentation/blob/5edc35056d03ddaf4bc1f5b126c94784d983170e/source/installation/cluster-config-schema.rst?plain=1#L51-L54
We need to update documentation to use multiline strings like this (and likely add a breaking change to the 3.1 release notes).
    batch_connect:
        basic:
          script_wrapper: |
            module restore
            %s
        vnc:
          script_wrapper: |
            module restore
            module load ondemand-vnc
            %s

This was not an actual issue on the OnDemand side - it was part of the puppet templating update that occurred, so i'm going to migrate that over there.


Wondering: Conflicting Data

if requested information is differing in multiple pages, can it successfully deduce which one is correct?

@vasnt if you are referring to RAG example, you can return multiple documents by setting e.g. topk=3 and return relevant ones, and feed multiple documents to the LLM to decide in the end. does this answer your question?

Thanks yes exactly.


feat: utils - re-export @polkadot/util as dotUtils

Resolves #29

[ ] There is an associated issue (required)
[ ] The change is described in detail
[x] There are new or updated tests validating the change (if applicable)

I just exported everything using the deno -> dnt way.
This is how you set up a new import path. e.g. import * as U from 'useink/utils'
And I export here


director_scheduler fails during director DB migration

Describe the bug
director_scheduler will fail until the director DB migration is finished. Afterwards the process seem to work properly.
To Reproduce

Add a sleep in director start script before DB migration.
Create a dev release with this change
Deploy a bosh director on any IaaS
Check the stdout and stderr logs of director_scheduler

Expected behavior
director_scheduler process does not fail with unexpected exception
Logs
/var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:152:in `async_exec': PG::UndefinedTable: ERROR:  relation "director_attributes" does not exist (Sequel::DatabaseError)
LINE 1: SELECT * FROM "director_attributes" WHERE ("name" = 'uuid') ...
                      ^
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:152:in `block in execute_query'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/database/logging.rb:43:in `log_connection_yield'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:152:in `execute_query'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:140:in `block in execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:116:in `check_disconnect_errors'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:140:in `execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:496:in `_execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:314:in `block (2 levels) in execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:518:in `check_database_errors'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:314:in `block in execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/database/connecting.rb:253:in `block in synchronize'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/connection_pool/threaded.rb:92:in `hold'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/database/connecting.rb:253:in `synchronize'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:314:in `execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/dataset/actions.rb:1083:in `execute'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/adapters/postgres.rb:610:in `fetch_rows'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/dataset/actions.rb:935:in `with_sql_each'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/dataset/actions.rb:945:in `with_sql_first'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/dataset/actions.rb:701:in `single_record!'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/dataset/actions.rb:244:in `first'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/sequel-5.16.0/lib/sequel/model/plugins.rb:33:in `first'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/lib/bosh/director/models/director_attribute.rb:8:in `find_or_create_uuid'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/lib/bosh/director/config.rb:195:in `configure'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/lib/bosh/director/config.rb:560:in `configure_evil_config_singleton!'
        from /var/vcap/data/packages/director/84c2f2a4e72f95ae4fde5cb64a4dd04bb75ffec4/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/lib/bosh/director/app.rb:25:in `initialize'
        from /var/vcap/packages/director/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/bin/bosh-director-scheduler:17:in `new'
        from /var/vcap/packages/director/gem_home/ruby/2.4.0/gems/bosh-director-0.0.0/bin/bosh-director-scheduler:17:in `<top (required)>'
        from /var/vcap/packages/director/bin/bosh-director-scheduler:29:in `load'
        from /var/vcap/packages/director/bin/bosh-director-scheduler:29:in `<main>'

Versions (please complete the following information):

BOSH version 268.4+ (most probably also with earlier versions, but didn't test it)

Additional context
director_scheduler should wait before accessing the Sequel models, which are based on director DB until the director DB is initialized properly.  E.g. the same has been done for director_sync_dns in this pr.
@langered

Doesn't this fail before monit considers it healthy, and doesn't monit automatically restart it when this happens? I'd expect the impact of this to be minimal. Is the goal to minimize log noise, or is there some functional impact from it?

This is more for documenting reasons and to have it in mind if we change something in the scheduler. There is no functional impact at the moment because as you mentioned monit restarts the process. E.g. we discovered a similar situation in bosh-director-sync-dns, where a combination with EventMachine and Thread spawning shadows the exception and the process doesn't fails. There we proposed this fix


On Ubuntu ARM64, azure-cli feature crashes if installed after docker-in-docker

This only started happening in the last few days -- I'm not sure why it happens or why it only affects ARM and only in this specific circumstance.
Repro is here: https://github.com/davidwallacejackson/az-cli-devcontainer-repro/tree/master/.devcontainer

Thanks for reporting. I just tried the repro linked, but the dev container built successfully for me. Are you still able to repro this?

Thanks for reporting. It seems there may have been some transient package issues. Are you still experiencing this?
Another thought is this could be tied to https://github.com/microsoft/vscode-remote-release/issues/7150.


curl_analyzer will not run on FIPS enabled systems

The curl_analyzer class  will not successfully run on a system that has FIPS only algorithms enabled.
if(previous_versions.present?)
      digest = Digest::MD5.file (full_file_path)
      previous_versions.each do |v|
        if(v.attachment.fingerprint != digest.to_s)
          previous_versions.delete(v)
          v.delete
        end
      end
    end

Thanks @woot4moo, glad you're taking a look at the project. I suspect we can fix this. I'll do some investigation and update the issue.

Just pushed a fix for this. It's in a branch now but should be merged sometime in the next few weeks.


Lower memory load of test_stgcn and test_stbln

I think I've figured out why we've been having issues with the memory. It isn't because of running multiple in parallel (or at least, not directly). Testing it locally, during the test of test_stgcn my memory spikes by 6GB, with test_stbln it spikes by 7.2GB. Linux github action runners only have 7GB on ram, with this load that doesn't leave much wiggle room. It could also explain why the issue is so inconsistent as depending on what is running at the same time on those machines it might tip over.
If I'm not wrong these models were recently changed, no?
@negarhdr do you think it's possible to simplify the complexity of this test so as to be less memory hungry?

@ad-daniel
For this tool (skeleton-based action recognition), 4 different methods are tested sequentially (tagcn, pstgcn, stgcn, and stbln) and as I remember it always starts with tagcn and ends up with stbln. I am not sure if the memory is cleared after testing each tool or after each ** unit test**, BTW, do you think that testing 4 methods sequentially for this tool might cause the memory spike?  maybe that's why the ram spikes for the last two methods (stgcn and stbln)!

Unfortunately I don't think that's the issue, in fact you can see the spike just by running them separately with:
python3 -m unittest tests/sources/tools/perception/skeleton_based_action_recognition/test_stbln.py

Should be fine now.


Provide a way to get diagnostic info for an issue about an extension that's not hosted on GIthub

RIght now, there's an Issue Reporter that collects all the info, but it only works with GitHub issues. But our team develops an extension using a GitLab repository.
It would be nice to have a way to collect the diagnostic info for a GitLab issue, similarly to what the Issue Reporter does. For example, something like env.getDiagnosticInfo(): string in the api. Or just having the default Issue Reporter work with GitLab issues.

#73515 is related. Pinging @RMacfarlane for any news of plans of better support for extensions hosted elsewhere than GitHub.

Looks like this recent change adds something similar? Not really clear from the docs what the uri parameter does.