Add a isOpen and isClosed function to generated actor API

Task

Add isOpen and isClosed functions to the generated API, these functions must not send commands but simply delegate the result of the AbstractActors isOpen / isClosed function.

Motivation
A way to check if it is still possibly to interact with an actor. Sending a command to a closed actor will cause an IllegalStateException.
Notes

depends on #8, add these functions to the new API super-class directly

Has been implemented in 70e39a03451ffd7ad24ebfdbc0fd56d4b33d4c3d because of #8


fix eval steps and strategy

@teknium1 I think this is the correct logic, since the trainer automatically handles when eval_steps < 1

This logic makes more sense. However, should we just migrate to allow passing the evaluation_strategy and save_strategy instead to start getting parity with HF Trainer?


Exception Thrown with v 0.20.0 running K*18 nightly on Win x64

Just noticed an artwork beef error popup while watching movie....
wanted to post this since I don't see any open issues and never seen this error since updating just a little big ago.
I can give you a better (full debug) log after the movie but had a quick min to post this now...

08:11:44.434 T:17192  NOTICE: VideoInfoScanner: Starting scan ..
08:11:49.316 T:17192   ERROR: XFILE::CDirectory::GetDirectory - Error getting
08:13:32.924 T:17192   ERROR: Previous line repeats 1 times.
08:13:32.924 T:17192  NOTICE: CVideoDatabase::CleanDatabase: Starting videodatabase cleanup ..
08:13:39.468 T:17192  NOTICE: CVideoDatabase::CleanDatabase: Cleaning videodatabase done. Operation took 00:06
08:13:39.473 T:17192  NOTICE: VideoInfoScanner: Finished scan. Scanning for video info took 01:55
08:17:11.875 T:11172   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.UnboundLocalError'>
                                            Error Contents: local variable 'services_hit' referenced before assignment
                                            Traceback (most recent call last):
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\service.py", line 363, in <module>
                                                ArtworkService().run()
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\service.py", line 103, in run
                                                if self.process_allvideos(self.processed.is_stale):
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\service.py", line 233, in process_allvideos
                                                return self.processor.process_medialist(items)
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\lib\artworkprocessor.py", line 205, in process_medialist
                                                return self.process_chunkedlist([medialist], 1, alwaysnotify)
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\lib\artworkprocessor.py", line 218, in process_chunkedlist
                                                self._process_chunk(medialist, idx + 1, alwaysnotify)
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\lib\artworkprocessor.py", line 243, in _process_chunk
                                                services_hit = self._process_item(mediaitem, singleitem)
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\lib\artworkprocessor.py", line 298, in _process_item
                                                sh, er = self.downloader.downloadfor(mediaitem)
                                              File "C:\Users\Mario\AppData\Roaming\Kodi\addons\script.artwork.beef\lib\filemanager.py", line 114, in downloadfor
                                                return services_hit, error
                                            UnboundLocalError: local variable 'services_hit' referenced before assignment
                                            -->End of Python script error report<--

Thanks!
Mario

Ok,
Had some time to look at this.  First decided to grab v0.20.1~adev but looking closer there don't seem to be any changes yet.
So decided to go ahead and delete the the DB, report and recreate the settings and see if that had any impact...
It appears that it did...
I am not sure what really what particular setting(s) resolved this but here are the 2 settings xml files if you wanted to peek at them.  API key redacted otherwise they are both the same that, I used when I got the exception (more then once running "for all video old and new" scan.
orig settings that threw exception:
settings-exception.xml.txt
newly created from scratch settings (differs a little from previous) that no longer throws an exception:
settings-no-exception.xml.txt
Thanks Ryan!
Mario

Side Q:
Does Episode thumbs get downloaded by default or do I need to use the setting to do that?
<setting id="episode.download_arttypes">thumb</setting>

Thanks for the report, I see what is going wrong. I'll have a fix in the next update.
Side A: Yes, 'thumb' will need to be added to those two settings to download and identify local thumbs.

Version 0.20.1 should resolve this error.

just updated yesterday and ran a full old/new video update without (1st) and then with "Thumb" for Episodes and no errors either way.
Curious - does adding "thumb" actually do anything yet?
But hey many thanks for all your help and especially this and your other addons.  Love the webdev addon.   Saves my sanity when working on Kodi skins.
want a challenge?  a Kodi Skin IDE / Editor :-)   a few have started over the years hehe.
Thanks and take care!
Mario

"thumb" must be in the "Additional art types for TV episodes" for Artwork Beef to add "thumb" images from the local file system, and it must be in "Download these artwork types" for Artwork Beef to download external URLs from scrapers or JSON-RPC.  Artwork Beef doesn't currently add new "thumb" images from web services; the thumbnails available from TheTVDB are universally awful and I haven't quite decided how to configure picking episode 'fanart' and episode 'thumb' from TheMovieDB.


clickawaylistner is not working with safari. But working fine on chrome and firefox.

@dariyapuri I could not reproduce the issue on Safari 15.1. Which version are you using?

@michaldudak i am using safari version of 15.1

Could you walk me through the steps to reproduce the issue? Perhaps I'm doing something the other way than you. In the sandbox I don't understand why do you have setVisible in both onMouseLeave and onClickAway. When you move the mouse away from the element, the tooltip disappears, so ClickAwayListener doesn't have a chance to work, no?


About V2 SKU.

I read below sentence but it's confusing because I can not know whether WAF is supported by Standard V2 or not. I know WAF is supported by WAF v2 SKU so I want you to fix this sentence.
"Application Gateway and Web Application Firewall (WAF) are also available under a Standard_v2 and WAF_v2 SKU. "
E.G: Application Gateway is available under a Standard_v2. Web Application Firewall (WAF) is available under a WAF_v2 SKU.

@hisasima : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@vhorne - Is the first sentence missing the word SKU, i.e., should be Application Gateway is available under a Standard_v2 SKU.?

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I've made this edit and will merge. @vhorne if the sentence doesn't need the object "SKU" that I've added, let me know and I'll update the content. Thanks.


TypeError: null is not an object (evaluating 'this._nativeModule.isBluetoothAvailable')

Hi all
I always get this error when I use any RNBluetoothClassic function:  TypeError: null is not an object (evaluating 'this._nativeModule.isBluetoothAvailable')
I don't think its related to permission and instillation
my project: https://github.com/OmarYousef-CS/https---github.com-OmarYousef-CS-finalProject

You have an app.json, are you using Expo?
If so, you won't be able to load the library without the with-rn-bluetooth-classic library or ejecting it.

In the end, I have built a new project using "npx react-native init" and it works fine.
Thanks @kenjdavidson


Updated OSG configuration for Parsl 1.0 and latest OSG recommendations

Description
I have updated the configuration for executing on the OSG. Allow me to explain the proposed changes.
Update scheduler options to reflect OSG best practices
scheduler_options="""
+ProjectName = "MyProject"
Requirements = HAS_MODULES=?=TRUE
"""

All OSG jobs must have a ProjectName associated with them, which users will get during sign up. As for job requirements, HAS_MODULES=?=True should be sufficient to ensure lmod is present and Python 3.7 can be loaded.
Install Parsl at Job startup
worker_init='unset HOME; unset PYTHONPATH; module load python/3.7.0; python3 -m venv parsl_env; source parsl_env/bin/activate; python3 -m pip install parsl',

The OSG pilot environment clashes with Parsl's, so I have unset PYTHONPATH, loaded Python from lmod, and then installed the Parsl package at job startup time. This could perhaps be optimized but is fairly simple as-is.
Move logdir to TMP
worker_logdir_root='$OSG_WN_TMP',

As there is no shared filesystem, I recommend that the logdir root be changed to $OSG_WN_TMP. This environment variable points at the execution site's preferred location for temp files.
Be explicit about ports used
worker_ports(31000,31001)

For security reasons, OSG no longer allows users to open arbitrary ports without first making a request. I suggest that the user be required to configure worker_ports() with an appropriate value, which I suppose must be given to them by the OSG team.
Type of change
Choose which options apply, and delete the ones which do not apply.

Documentation update
Code maintentance/cleanup

@LincolnBryant - Hi. This is failing in CI because the modified config file doesn't pass flake8 rules:
parsl/configs/osg.py:22:161: E501 line too long (173 > 160 characters)
parsl/configs/osg.py:26:32: E231 missing whitespace after ','
Makefile:41: recipe for target 'flake8' failed

Run flake8 parsl/configs/osg.py to validate that locally if you don't want to wait for CI each time.

PR #1908 merged all the changes from this PR along with some minor style guideline issues raised by flake8. I'm closing this.

PR #1908 merged all the changes from this PR along with some minor style guideline issues raised by flake8. I'm closing this.


Rutee Neat Sister title freeze

In Shiden, right before acquiring Rutee's ''Neat Sister'' title, the game crashes.

On another note, need to find graphics on left "出口" and edit to "exit".

14064_69.txt  should be this file


Support VCS requirements 1st class

Right now Pex requirement parsing lumps these under URLRequirement precluding any special handling required. One way or another #1556 will require recognizing VCS requirements.

These VCS requirements can come in two forms:

The more limited, but now tandard PEP-440 direct reference form: https://www.python.org/dev/peps/pep-0440/#direct-references
The original more full-featured Pip proprietary form: https://pip.pypa.io/en/stable/topics/vcs-support/

In case we need support for cloning using these requirements, some notes:

svn:
# Checkout the trunk from r1729.
$ svn checkout http://svn.example.com/svn/repo/trunk@1729 trunk-1729

hg:
# Checkout revision 0.
$ hg clone https://www.mercurial-scm.org/repo/hello#0 hello-0

bzr:
# Checkout the 2.6 branch from revision 6577
$ bzr branch lp:bzr/2.6 -r 6577 bzr-2.6@6577

What if you only supported locking PEP 440 style VCS requirements?
I'm happy to only use PEP 440 style VCS requirements. That could be a good way to push people away from pip's proprietary format if they want pex to lock stuff.

@cognifloyd the work to support Pip proprietary VCS requirements was done long ago. You might notice in #1563 there are no instances of 2 ~parallel changes. The PEP-440 direct reference and Pip proprietary url handling are already unified. There is a test edited there that shows the fact both are handled.

Ah - you were thinking this has to do with lockability. It does not. Both forms are equally unlockable without special effort since both forms can carry floating contents. Although PEP-440 decrees SHOULDs (https://datatracker.ietf.org/doc/html/rfc2119#section-3), they are just that, reccomendations that may be bypassed in practice. As such, Pex must parse a commit id from either format (which both formats support) and:

If the commit id is not present: fail.
If the commit id is present but not cryptographic: fail.

Instead of failing though, it could just pre-clone the repo and hash its contents. This would allow branches and tags to be useable in locks safely and it would also allow non-vcs local project requirements to be useable in locks safely (today these are rejected outright by pex3 lock).


Feature Proposal - Oracle Extractor

Expected Behavior or Use Case
An extractor that load Oracle database metadata into Amundsen.
Service or Ingestion ETL
Ingestion ETL (databuilder module)
Possible Implementation
I have developed the code to make easy the Oracle database integration with Amundsen following the Amundsen code pattern. It is attached below in the zip file. There are two files with the extractor code and one file with a sample example.
oracle-amundsen.zip
Context
It is important to have a standard extractor for Oracle to facilitate the integration of metadata from Oracle tables into Amundsen. Oracle is one of the world's leading databases.

Thanks for opening issue and taking an action! Would you mind submitting PR with this code? It would be easier to review it and eventually merge to main. Thanks!

Done! https://github.com/amundsen-io/amundsen/pull/1357
Tks, @mgorsk1


Async

Async - Syntactic sugar in Swift for asynchronous dispatches in Grand Central Dispatch :large_orange_diamond:

Should go to Utility


Lombok

So I just lost about one and a half hours thanks to this project relying on lombok.
lombok was completely unknown to me although I kinda use java for like 13 years (most of my time spent using other languages).
So I read up on lombok a bit and quickly came to the conclusion that I don't think lombok is a great tool.
Like in https://medium.com/@vgonzalo/dont-use-lombok-672418daa819 I think that lombok should be avoided.
Now I don't want to start a war here, and I don't like to open such an issue on an OSS project.
But, launching containers during unit tests is alreay complex and hard to debug (I still have to get to that part...) so making the library that does that artificially harder to debug and understand seems counter intuitive to me.
Is lombok really adding enough value to justify it's added complexity?
I have some time at hand rn so if you want to remove lombok I can do some of the work required to get there.

I agree with @cobexer that use of Lombok decreases "user experience" when stepping through the code, because sources do not match.
My experience is also that use of Lombok makes it harder for me to contribute to the project.

I also agree.  Lombok achieves a nice goal in the worst way possible.I have no problem working with projects which use Immutables or Autovalue, because these projects achieve similar results as Lombok through interfaces you control.  I feel that Lombok obfuscates code in order to reduce boilerplate.

@quincy i agree, but I think this is also subjective. I am sure @bsideup has no problem working with Lombok, otherwise Lombok would be gone already.
Let's focus on objective pros and cons of Lombok, leaving the final judgement to project maintainers.
For example: "Lombok makes it harder for me to contribute to the project" is an objective statement...  about myself (at least)
And "Lombok makes it hard for me to step through the code" is an objective statement...  about @cobexer  and myself (at least).
@quincy what is the problem that brought you here?

Lombok's code generation creates difficulties because it modifies the AST directly at compile time, (something which was supposed to be forbidden by annotation processors).  This results in methods which only exist at runtime and which have no interface declaring their existence.  Testing, refactoring, and reading are all harmed by this.
If you look at the Immutables library, it achieves similar code generation to Lombok, but it does so by implementing explicit interfaces.  This means that you are always programming to an interface which actually exists in the code.  All static analysis tools work quite well with this, whereas Lombok often requires additional plugins to aid with things such as code navigation.
For a concrete example of how Lombok is making my life more difficult, I am currently working on #2807, which ought to be a simple refactor.  However, I am having a lot of difficulty with deprecating a builder method, which doesn't exist until after the compile, without also deprecating other nonexistent methods.  This causes problems making changes while maintaining backwards compatibility.
Removing the boilerplate from Java is nice, and Lombok achieves this, but the resulting state of the project becomes obfuscated as a result and makes the code more difficult to change.


Tox regression testing

This pull request consists of three commits.
The first two are minor bug fixes.
The third adds a directory named test that includes a set of regression tests for most of the viewer functionality.  The regression testing is driven by the tox tool that is driven by the tox.ini init file.  tox generates the pip installation package with setup.py, the launches a sequence of virtual environments, one for each test listed in tox.ini, and installs the pip package in the fresh virtual environment and runs the test.
Note: Some existing regression tests are not run by tox.  The reason is that they cannot tolerate relocation in the file system (the location of the git repository) because of pathnames compiled into the goto binary used for the test.  This will require reimplementing the --blddir flag (the current --srcdir is the source root on the local machine, the --blddir is the source root on the machine used to build the goto binary).  Easy to do, but not yet done.
The file to focus on is ./tox.ini listed at the very end of the pull request.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markrtuttle will you continue to work on PR?

Yes, @ligurio, I do plan to finish.

Closing in favor of https://github.com/awslabs/aws-viewer-for-cbmc/pull/54

Closing in favor of https://github.com/awslabs/aws-viewer-for-cbmc/pull/55


I removed a number of overrides that weren't saved to the prefabs

Fixed workbench interaction. The raycast is now based on the camera's position and direction. As it was before, the ray was being cast from player position, but due to how the player prefab is made, the position is actually under the ground so the ray was too.
I also added a "WorkBench" tag and put it on the workbench so the code can easily know if the ray hit a workbench. So the crafting UI shows up again now when you press C while looking at one.

I think we should hold off on merging this in until we get the game loop prototype scene (DebugGame) merged in, so we can do the first itch.io build sooner

Yea, that makes sense

Some of the berry plants don't change their visual when harvested. You should also use the version of the [JellyDew] prefab from develop. Item prefabs should all have a stack count of 1, because otherwise when you toss an item, it subtracts 1 from inventory but creates multiple.


Extending existing matchers

Somewhat similar to rspec/rspec-expectations#1219, I'm writing a custom matcher that adds a small twist to the change matcher. All over our tests we have something like this:
expect { post(:update, params: { id: user.id, user: { login: 'b' } }
  .to change { user.reload.login }.from('a').to('b')

I want a matcher that encapsulates the reload bit, something like:
expect { post(:update, params: { id: user.id, user: { loginl: 'b' } }) }
  .to change_record(user, :login).from('a').to('b')

I know it's not encouraged to inherit from existing matchers, but we want basically the same behavior as the change matcher, with a reload added after calling the event_proc. So our options are to either rebuild the change matcher from scratch, or to extend from the existing matcher and a handful of its private subsidiaries. Neither option feels great, but the second one is way cleaner, as there's a lot built into the change matcher. The messaging in particular. Here's the extended version:

extending matcher
module Ik12

  module Matchers

    class ChangeRecord < RSpec::Matchers::BuiltIn::Change

      def by(expected)
        ChangeRecordRelatively.new(change_details, expected, :by) do |actual|
          values_match?(expected, actual)
        end
      end

      def by_at_least(min)
        ChangeRecordRelatively.new(change_details, min, :by_at_least) do |actual|
          actual >= min
        end
      end

      def by_at_most(max)
        ChangeRecordRelatively.new(change_details, max, :by_at_most) do |actual|
          actual <= max
        end
      end

      def to(value)
        ChangeRecordToValue.new(change_details, value)
      end

      def from(value)
        ChangeRecordFromValue.new(change_details, value)
      end

      def matches?(event_proc)
        my_proc = lambda {
          event_proc.call
          change_details.instance_variable_get(:@receiver).reload
        }
        super(my_proc)
      end

    end

    class ChangeRecordRelatively < RSpec::Matchers::BuiltIn::ChangeRelatively

      def matches?(event_proc)
        my_proc = lambda {
          event_proc.call
          @change_details.instance_variable_get(:@receiver).reload
        }
        super(my_proc)
      end

    end

    class ChangeRecordToValue < RSpec::Matchers::BuiltIn::ChangeToValue

      def matches?(event_proc)
        my_proc = lambda {
          event_proc.call
          @change_details.instance_variable_get(:@receiver).reload
        }
        super(my_proc)
      end

    end

    class ChangeRecordFromValue < RSpec::Matchers::BuiltIn::ChangeFromValue

      def matches?(event_proc)
        my_proc = lambda {
          event_proc.call
          @change_details.instance_variable_get(:@receiver).reload
        }
        super(my_proc)
      end

    end

  end

end

So I'm wondering if there are any alternatives I'm not thinking of. Or if there's any potential to make the existing matchers more extensible in some way. In my case all I really want to do is wrap event_proc, which seems simple in principle, but in practice it's pretty tricky.

The matcher internals are private API because it allows us to change them without major versions, so what you are doing is not technically supported, and I am not going to change that policy.
Instead I would suggest you delegate to change using the public api instead, (that is when you create an instance of your matcher you create an instance of change and use it directly wrapping the parts you wish to change).

I'm happy to continue discussion here, but I'm closing this as "not supported"

@JonRowe I'd love to do that, but I'm not sure how to make that happen. We want to wrap event_proc, but the change matcher can return several other matchers which might be handling it depending on the situation. Do you have any suggestions for how to do this cleanly?

Instantiate or pass the matcher to yourself, keep it internally within that class, interact with it only through your class. Then you can wrap the block when it goes in and compose it, and you can delegate to the methods you need.


chore(deps): fix gesture-handle v2 dependencies & eslint error

Hi, @pavelbabenko this lib works great after the upgrade, thank you for you work!
Just when I run the example, I found some bugs.
This PR was fixed:

"react-native-gesture-handler": "^1.10.1" will affect older versions, such as  v1.10.1<=version<=v1.10.3.

"react-native-reanimated": "2.1.0"  not support entering or exiting props, eslint will report an error.

withDecaySpring.ts file eslint report type error.

Above, I fixed.

Best wishes to all defenders and civilians living in Ukraini.
Slava Ukraini! 🇺🇦

Thank you @alantoa


@bugsnag/web-worker using cuid package which does not run in Web Workers

Describe the bug
Bugsnag for Web Workers appears to be using a fork of cuid package to generate IDs like for Session creation.
Inside cuid, navigator.mimeTypes is accessed like this (https://github.com/bugsnag/cuid/blob/662b859fea9f546dbbb6525d687558cd46a6518a/lib/fingerprint.browser.js#L8), which seems to fail in Web Worker.
Steps to reproduce

Turn on session tracking
Attempt to pause and resume session

Environment

Browser framework version (if any):

React: 7.19.0
Web Worker: 7.20.1

Browser version (e.g. chrome, safari): Safari
Device (e.g. iphonex): iOS

Error messages:
undefined is not an object (evaluating 'navigator.mimeTypes')

Hi @rtymchyk
Thanks for bringing this to our attention. We are looking into this, and will keep this thread updated with any developments.

Hi @rtymchyk
We've looked into this, and can confirm we have a test that successfully sends a session: https://github.com/bugsnag/bugsnag-js/blob/86e96f9ad275f870dff28d3139bd8f07f387ec42/test/browser/features/web_worker.feature#L45-L48
navigator is also defined in web workers, so we would not expect this to be an issue: https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/navigator
We are unaware of any other users having this problem and I have also been unable to reproduce it. If you're still encountering this, are you able to elaborate on how you are pausing and resuming your sessions? As this is a public thread, please feel free to open a ticket with us by contacting<EMAIL_ADDRESS>and reference this issue. To further aid our investigation, could you also please attach code snippets/screenshots of your BugSnag configuration and any session instrumentation you are performing.

Hi @rtymchyk
We've looked into this, and can confirm we have a test that successfully sends a session:
https://github.com/bugsnag/bugsnag-js/blob/86e96f9ad275f870dff28d3139bd8f07f387ec42/test/browser/features/web_worker.feature#L45-L48
navigator is also defined in web workers, so we would not expect this to be an issue: https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/navigator
We are unaware of any other users having this problem and I have also been unable to reproduce it. If you're still encountering this, are you able to elaborate on how you are pausing and resuming your sessions? As this is a public thread, please feel free to open a ticket with us by contacting<EMAIL_ADDRESS>and reference this issue. To further aid our investigation, could you also please attach code snippets/screenshots of your BugSnag configuration and any session instrumentation you are performing.

Thanks @mclack. I am not pausing/resuming sessions at all, just a simple Bugsnag.start({..}) in the global namespace, with an API key, release stage, and app version. I assumed it was session tracking related based on this:

Sessions are captured and reported by default. This behavior can be disabled using the autoTrackSessions configuration option.

But even with this disabled there issue persists.
I'll try to collect some more information and reach out via a ticket once I have it!


DSP Modelling Design Decision: @type everywhere?

from https://github.com/International-Data-Spaces-Association/ids-specification/pull/89/files#r1246200376 :
Shouldn't all classes also have a @type property (same goes for DataService, Dataset, Resource)? [...] we already have this problem with dct:hasPart in Catalog which is either a Catalog, Dataset, or DataService?
So in that case we would need it for some objects and then it might be easier to include the @type everywhere to not require complex logic to see where to include it and where not.

It's not required by any specification. As long as it's not at the beginning of a JSON, the serialiser usually knows the class through the property (JSON key). However, in case several different classes (subclasses) are allowed, this approach won't work.
Options:

Only use @type where really needed. Pro: less attributes
Use @type in every class serialisation. Pro: consistent, simple rule. Pro: dcat:DataService, dcat:Dataset, and dcat:Resource can be distinguished.

Decision:
Option 2a: Use @type in every class serialisation, however, put the type information into the context file.


Fix: fix pkg/manager golint warnings

Signed-off-by: yanli<EMAIL_ADDRESS>1.Describe what this PR did
fix pkg/manager golint warnings
2.Does this pull request fix one issue?
fixes part of #233
3.Describe how you did it
refine codes
4.Describe how to verify it
➜  frakti git:(golint) golint pkg/manager/*
➜  frakti git:(golint)
5.Special notes for reviews
NONE

This change is

Please sign CLA
We don't require Signed-off-by in Kubernetes community :)


may i know how to set it to use automatic path for sharing checkpoint and lora?

anyone know who to do it?

Not sure what you're asking?
Paths are configured under the Server -> Server Configuration tab.
If you're using a comfy self-start backend it will automatically send your swarm-configured paths to comfy to sync them.

hi, i mean i wan to use the checkpoint in different path inside my automatic1111 stable difussion folder, eg: E:\stable-diffusion-webui\models\Stable-diffusion, but my stableswarmui is in d:stablesaarmui, i need to copy all the checkpoint from there to use it, it wasted space.

Not sure what you're asking? Paths are configured under the Server -> Server Configuration tab. If you're using a comfy self-start backend it will automatically send your swarm-configured paths to comfy to sync them.
hi, i mean i wan to use the checkpoint in different path inside my automatic1111 stable difussion folder, eg: E:\stable-diffusion-webui\models\Stable-diffusion, but my stableswarmui is in d:stablesaarmui, i need to copy all the checkpoint from there to use it, it wasted space.

Again, server -> server configuration tab

Just edit the modelroot to be E:\stable-diffusion-webui\models\ and save and restart swarmui and you'll be good

Again, server -> server configuration tab
Just edit the modelroot to be E:\stable-diffusion-webui\models\ and save and restart swarmui and you'll be good

many thanks ,it works.


Unsupported fs on partition

格式化U盘后就报这个错误

First of all, I only understand Englisch and German. Second, this library only supports FAT32 officially.
If you want to have other file system types have a look at the module called java-fs and how it is used in the example app.


[BEAM-165] Initial implementation of the MapReduce runner.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @kennknowles @jbonofre

retest this please

Changes Unknown when pulling caedb2bfd11618eb2b40e59dc48a87dc87ccc994 on peihe:mr-runner into ** on apache:mr-runner**.

Changes Unknown when pulling caedb2bfd11618eb2b40e59dc48a87dc87ccc994 on peihe:mr-runner into ** on apache:mr-runner**.

retest this please

retest this please

retest this please

retest this please

Changes Unknown when pulling 32aeb7ac3d49ade0dc3ad79e711e7b624091d485 on peihe:mr-runner into ** on apache:mr-runner**.

@kennknowles
PTAL
build and validates runners test passed


Action to take when remote branch is moved?

First off, I apologize if this is the incorrect medium to bring this up.
Somebody decided it would be a great idea to re-organize the folders on our TFS server such that the location to which my git-tfs remote is currently pointing no longer exists. As such, I can no longer commit or shelve. Additionally, pulling just results in a repository with no files.
Is there a way to resolve this without re-cloning and replicating the un-committed work on the new repo?
I tried setting the 'tfs-remote.default.repository' config value to point at the new location, but that didn't seem to get me much closer - if I issue the 'git tfs branch' command, I get the following output:
[master]> git tfs branch

Git-tfs remote details:

 default -> http://mytfsinstance:8080/tfs $/New/Path/To/Main
Unable to locate a remote for <http://mytfsinstance:8080/tfs>$/Old/Path/To/Main
You may be able to resolve this problem.
- Try using `git tfs bootstrap` to auto-init TFS remotes.
- Try setting a legacy-url for an existing remote.

So I'm wondering - is there a good way to 'move' where the git-tfs remote is pointing?
git-tfs version <IP_ADDRESS> (TFS client library <IP_ADDRESS> (MS)) (32-bit)

@pmiossec this was a tremendously helpful thread after trying several other ways to continue cloning from a fixed commit. Adding an empty commit "Renamed branch ProductName to master" with the right git-tfs-id and editing .git/config worked.

@jnm2 Thanks for the follow-up


[Bug] Mobile, again

Hello !
I try to push using mobile (IOS - Iphone) but nothing seems to work : I have no notice and nothing appear on the github.
Also, I work on a "seems of" fork of your project, using my own solution (obs2mk, a python script used as a Github Actions). You can check it out if you want !
https://github.com/Mara-Li/obsidian-mkdocs-publication
This plugin doesn't work too with mobile :(

Hi!
Hmm, that'sweird. It's working when I'm testing on my iPhone. What version are you on, and what command are you running?
That's awesome, let me know if you need any help with any of it.

I run for all documents.
It's seems to be around the base64 things. Dunno why, but specially on my phone base64 converting text.
I tryed the V1, where you use Buffer.from(text).toString('base64'). This work all good. But not on my app. I think there is maybe something around Obsidian update?

By v1, do you mean version 1 of the plugin? If so try upgrading to 2.8.5 and see if that helps.
You're right. The Buffer class is actually a node specific module/API. When running on mobile, you obly have access to browser APIs. I switched to using the library js-base64, which also works on mobile. Take a look in the utils.ta class in the repo. If you change the Buffer.from code to something like this, it should probably work on mobile too. Let me know of it solves it or not.
import { Base64 } from "js-base64";

function arrayBufferToBase64(buffer: ArrayBuffer) {
	let binary = "";
	const bytes = new Uint8Array(buffer);
	const len = bytes.byteLength;
	for (let i = 0; i < len; i++) {
		binary += String.fromCharCode(bytes[i]);
	}
	return Base64.btoa(binary);
}

You can then use it like this:
const imagePath = getLinkpath(imageName);
                    const linkedFile = this.metadataCache.getFirstLinkpathDest(imagePath, filePath);
                    const image = await this.vault.readBinary(linkedFile);
                    const imageBase64 = arrayBufferToBase64(image)

Thanks a lot to investigate my issue !
After some try, using the js-base64 work well, simply using const contentBase64 = Base64.encode(text).toString();
Now, I need to understand why your plugin crash on my iphone :(

No, nothing appear in Notice nor in my Github repo...
I use the last version for the repo template and the plugin. Everything is correctly configured (because my PR worked)

Also, my config :

IPhone 12
IOS 15.4.1
Obsidian mobile 1.2.1

Hey,
Many updates have been released since this bug was posted. I've not been able to reproduce it. Are you still having issues on mobile or has it resolved itself?

As I made my own plugin and no longer your, I close this issue.


Verify number of InfluxDB series migrated

Issue #, if available: N/A
Description of changes:

The series count of buckets to be backed up are now logged when log level is set to debug.
The series count of buckets after restoration are now logged when log level is set to debug.
bucket_exists has been improved.
All logs now include a timestamp.
Documentation describing how series counts are logged has been added.
scripts/temp has been added to .gitignore.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I have added some improvements for the bucket series count function calls.

All calls now use the user's --skip-verify value, instead of leaving the argument out and defaulting to False.
The lack of token migration has been taken into account for when users do a full migration with --csv.


awaiting finalized market shows up when checkbox for in my portfolio is clicked but it isn't in my portfolio

not in porttfolio:

portfolio box clicked:

this is working correctly. i had initially reported on the market so that is why it shows here


AMC Thriller

Source
https://watch.plex.tv/live-tv/channel/amc-thrillers
Notes
No response

Added in https://github.com/iptv-org/epg/commit/cc3e319da3d8cf26a3f8088b3b96a3ea7f73d957

Link please so i can put it up on my televizo correctly

https://iptv-org.github.io/epg/guides/us.xml

I have that link and AMC Thriller didnt showing up in the GUIDE schedule.

https://iptv-org.github.io/epg/guides/us.xml

Can you tel me the name of it? AmcThriller.us?
On Mon, Nov 14, 2022 at 4:43 PM Aleksandr Statciuk @.***>
wrote:

https://iptv-org.github.io/epg/guides/us.xml
[image: image]
https://user-images.githubusercontent.com/7253922/201771826-f3cb61fb-2d0a-4bc4-aa60-9650327ba85d.png
—
Reply to this email directly, view it on GitHub
https://github.com/iptv-org/epg/issues/1327#issuecomment-1314447615, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5X34SKFZQ7NUUQQNXXC6TWIKW7RANCNFSM6AAAAAAR5UJFQY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
In Memory of Spot (FOREVER)

The correct ID for all channels can be found here: https://iptv-org.github.io/?q=AMC Thriller

Thank you!
I book it.
On Mon, Nov 14, 2022 at 4:51 PM Aleksandr Statciuk @.***>
wrote:

The correct ID for all channels can be found here:
https://iptv-org.github.io/?q=AMC Thriller
—
Reply to this email directly, view it on GitHub
https://github.com/iptv-org/epg/issues/1327#issuecomment-1314455145, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5X34XHKV54R7UTULFK3DDWIKX6FANCNFSM6AAAAAAR5UJFQY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
In Memory of Spot (FOREVER)


Improve support for Fahrenheit

Describe The Bug:

The temperature limits currently in place will only work for Celsius.
To Reproduce:

Expected behavior:

Logs:
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version:
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:

Looks like hap library is missing. Does running
sudo npm install -g hap-nodejs solve the issue?


Update access-resources.md

Made a slight change from  Users won't be able to authenticate to might not be able to authenticate

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4087


Docker Compose部署提示500，提示Topology is closed

求助

check your DB connection is accessible from your host machine.

未正确配置 MONGODB_URL 导致。最新版本已优化该错误提示


Fix time parsing issue

This PR updates hour regex pattern to solve the parsing issue (hours with suffix, e.g., x点钟 x点整)
resolve #179

thk！！


Fix cpWidth setting and add change detection for cpPresetColors

Last version broke the custom width setting. This fixes that by adding slider initialization after view init when using custom value. This also adds support for cpWidth 'auto' which means that width of the trigger element is used (useful for when showing dialog on bottom and you want the width to match the trigger element).
I also added change detection and updating of preset settings since those can change after dialog has been opened for the first time.

Ive updated to 2.4, sconix it would be possible one pull request with all your new changes?

The PR with title: Bug fixes and AOT compatibility / support includes all my other PR and bug fixes. Just let me know if you want me to make it against some other branch or changes you have made.

I see that you just pushed changes, I will make update the AOT PR so it does not conflict.

That's nice thank you very much

I will close this PR since this is included in that one and I will push soon fixes for that PR.


Test - Updates

Work in progress - Try
make
ctest -N
ctest -R rpp_qa_tests_host -VV

@kiritigowda Unfortunately not yet.
The make and ctest commands above still give me:
Test project /home/sloganat/dockerMount/abishek/kiritiForks/rpp/utilities/test_suite/HOST/build
No tests were found!!!
And running the python script from anywhere outside gives me:
Running brightness_u8_Tensor_HOST_PLN1_toPLN1 1 times (each time with a batch size of 3 images) and computing mean statistics...
CPU Backend Clock Time: 13.808 ms/batch
CPU Backend Wall Time: 45.5099 ms/batch
Could not open the reference output. Please check the path specified

Traceback (most recent call last):
File "utilities/test_suite/HOST/runTests.py", line 192, in
print("\n-------------------------------------------------------------------" + resultsInfo + "\n\n-------------------------------------------------------------------")
NameError: name 'resultsInfo' is not defined
We'll go over this from our side and send an update to the open PR.


Use official ubuntu:14.04 image

WHY
Now we're using quay.io/wantedly/buildpack-deps as base image. However, buildpack-deps image contains some unnecessary packages (imagemagick is installed!). It makes nginx-image-server image fat.
WHAT
Use official ubuntu:14.04 image and install essential packages only.
This change reduces image size by 260MB.
$ docker images | grep nginx-image-server
quay.io/wantedly/nginx-image-server    new                 5f66f6e88ddf        10 minutes ago      654.5 MB
quay.io/wantedly/nginx-image-server    latest              72fe212000be        5 months ago        918.3 MB

Thank you for PR!!
LGTM !!


Renko strategy error

System information

Have I written custom code (as opposed to using zenbot vanilla): zenbot unstable (Dec 31, 2018)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Mint 19.1 Tessa
Zenbot version (commit ref, or version): 4.1.0 (unstable)
Zenbot branch: unstable
NodeJS version: 8.15.0
Python version (when using a python script):
Exact command to reproduce (include everything): ./zenbot.sh sim binance.ETH-PAX --strategy=renko --min_periods=200
Did I make any changes to conf-sample.js?: no

Describe the problem
When I use renko strategy with sim, I get error in following lines.
Source code / Error logs
./zenbot.sh sim binance.ETH-PAX --strategy=renko --min_periods=200
/home/username/zenbot/extensions/strategies/renko/strategy.js:16
    prclose = Math.round(s.lookback[s.options.min_periods].close)
                                                           ^

TypeError: Cannot read property 'close' of undefined
    at Object.calculate (/home/username/zenbot/extensions/strategies/renko/strategy.js:16:60)
    at updatePeriod (/home/username/zenbot/lib/engine.js:162:16)
    at withOnPeriod (/home/username/zenbot/lib/engine.js:772:5)
    at onTrade (/home/username/zenbot/lib/engine.js:952:7)
    at /home/username/zenbot/lib/engine.js:913:5
    at /home/username/zenbot/node_modules/async/dist/async.js:4096:9
    at Object.process (/home/username/zenbot/node_modules/async/dist/async.js:2344:17)
    at /home/username/zenbot/node_modules/async/dist/async.js:2252:19
    at Immediate._onImmediate (/home/username/zenbot/node_modules/async/dist/async.js:119:16)
    at runCallback (timers.js:810:20)

fixed by https://github.com/DeviaVir/zenbot/pull/1810


Auth observable not emitting a value

Hi,
I'm trying to log into Firebase using OAuthToken. Here's my code:
 let creds = firebase.auth.FacebookAuthProvider.credential(response.authResponse.accessToken)

    this.af.auth.login(creds, {
      method: AuthMethods.OAuthToken,
      provider: AuthProviders.Facebook
    })
      .then((success) => {
        console.log("Firebase success: " + JSON.stringify(success));
      })

I can confirm that get the "success" message. But, af.auth is not emitting a new value.
I didn't have this issue when logging in using the Redirect method. It happens only when using OAuthToken.
Is there something I'm doing wrong here?

I'm having the same problem (I think) when using Popup method.  I'm not sure how Redirect is suppose to work, but that's not working for me either.
http://stackoverflow.com/questions/39420716/angularfire2-authentication-with-canactivate-not-working

Not sure if this is related but as I'm debugging this I'm running into type problems due to AngularFireAuth extends ReplaySubject.  It seems this approach is not recommended.
https://github.com/Microsoft/TypeScript/issues/3282

By removing this line in firebase_sdk_auth_backend.ts, I am able to get the auth to emit.  Seems maybe something to do with the zone versioning in RC6?
.observeOn(new ZoneScheduler(Zone.current));

Same issue after upgrading to RC7 (seemed okay for me in RC6). I'm using email / password login method and the login works but auth.subscribe never gets called.


https://tppr.me/5JhnJ error on the youtube video

Challenge build-a-tribute-page has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.50 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Just click on the link and try to play the video. The error will be produced. This happens in safari and chrome browser. I have attached the screenshot of the issue.

We are removing videos in beta, https://github.com/freeCodeCamp/freeCodeCamp/issues/12753
Please check for existing issues including closed ones while reporting.


Move GetFedoraToolsGuestAgentBlacklistUserData

Moved GetFedoraToolsGuestAgentBlacklistUserData out of /test/utils.go to /tests/libnet/cloudinit/cloudinit.go

What this PR does
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/retest-required

/retest-required

/retest-required

/retest-required

@iholder101 is there an issue with the tests? I think the 2 tests that fail are not related to the PR, but they keep failing..

/retest-required

✋🧢
/hold
Dear @sradco
⚠ this pull request exceeds the number of retests that are allowed per individual commit.
🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!
👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.
🙇 Thank you, your friendly referee automation, on behalf of the @sig-buildsystem and the KubeVirt community!

It might be a bug that the hold bot calculate manual retests ?
@dhiller can you please suggest ?

✋🧢
/hold
Dear @sradco
⚠ this pull request exceeds the number of retests that are allowed per individual commit.
🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!
👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.
🙇 Thank you, your friendly referee automation, on behalf of the @sig-buildsystem and the KubeVirt community!

It might be a bug that the hold bot calculate manual retests ? @dhiller can you please suggest ?

No, that's by intent.

@iholder101 @xpivarc do you have time to look into the failures and get to the ground why it is failing?

@dhiller How can I proceed with this PR at this point?

@oshoval it might make sense to distinguish between manual retests and automatic ones, and to generate a more reasonable comment in each case. However, the comment about that retesting without any changes still makes sense.

@dhiller If someone does /test <specific-test> I guess it's not being counted, right? If so, I'd argue that the current behavior is actually desired.
Generally speaking, there is no reason to manually /retest-required or /retest. If tests fail it's reasonable that the CI is under pressure, and it won't help if every PR owner would re-trigger the tests manually again and again, but rather wait for the bot to trigger them. Using /test <specific> is different, since the PR owner sometimes have a need to examine that something specific works without triggering the whole suit.

/retest-required

@sradco please avoid manually re-trigerring the tests in the future, but instead wait for the bot to re-trigger them for you. This causes CI pressure and cancels currently running jobs.
Saying that, this PR brings a pure refactoring, so I don't see a reason any behavior would change.
/unhold

@oshoval it might make sense to distinguish between manual retests and automatic ones, and to generate a more reasonable comment in each case. However, the comment about that retesting without any changes still makes sense.

@dhiller If someone does /test <specific-test> I guess it's not being counted, right? If so, I'd argue that the current behavior is actually desired.
Generally speaking, there is no reason to manually /retest-required or /retest. If tests fail it's reasonable that the CI is under pressure, and it won't help if every PR owner would re-trigger the tests manually again and again, but rather wait for the bot to trigger them. Using /test <specific> is different, since the PR owner sometimes have a need to examine that something specific works without triggering the whole suit.

@iholder101 IIUC you are suggesting to not count test commands in general towards the retest count? Since technically there is no difference between a test all and a retest we had decided not to distinguish between them when counting retests. My comment above was just suggesting that the comment should be different to the user issuing the command, if the user is not a bot user.

@oshoval it might make sense to distinguish between manual retests and automatic ones, and to generate a more reasonable comment in each case. However, the comment about that retesting without any changes still makes sense.

@dhiller If someone does /test <specific-test> I guess it's not being counted, right? If so, I'd argue that the current behavior is actually desired.
Generally speaking, there is no reason to manually /retest-required or /retest. If tests fail it's reasonable that the CI is under pressure, and it won't help if every PR owner would re-trigger the tests manually again and again, but rather wait for the bot to trigger them. Using /test <specific> is different, since the PR owner sometimes have a need to examine that something specific works without triggering the whole suit.

@iholder101 IIUC you are suggesting to not count test commands in general towards the retest count? Since technically there is no difference between a test all and a retest we had decided not to distinguish between them when counting retests.

Right, test all is a special case, and I agree it should be counted.
But what about /test <specific>? is it being counted as well? I think this might be an exception that's not being counted. I think on draft PRs that test a specific lane before being ready for review, for example.

My comment above was just suggesting that the comment should be different to the user issuing the command, if the user is not a bot user.

I can agree with that. I think that the message should encourage people to avoid manual testing. This generally a bad idea.

@oshoval it might make sense to distinguish between manual retests and automatic ones, and to generate a more reasonable comment in each case. However, the comment about that retesting without any changes still makes sense.

@dhiller If someone does /test <specific-test> I guess it's not being counted, right? If so, I'd argue that the current behavior is actually desired.
Generally speaking, there is no reason to manually /retest-required or /retest. If tests fail it's reasonable that the CI is under pressure, and it won't help if every PR owner would re-trigger the tests manually again and again, but rather wait for the bot to trigger them. Using /test <specific> is different, since the PR owner sometimes have a need to examine that something specific works without triggering the whole suit.

@iholder101 IIUC you are suggesting to not count test commands in general towards the retest count? Since technically there is no difference between a test all and a retest we had decided not to distinguish between them when counting retests.

Right, test all is a special case, and I agree it should be counted. But what about /test <specific>? is it being counted as well? I think this might be an exception that's not being counted. I think on draft PRs that test a specific lane before being ready for review, for example.

Makes sense to not count specific /test <whatever> against the retest count. TBH I didn't look to closely at the implementation, I'll look at it soon.

My comment above was just suggesting that the comment should be different to the user issuing the command, if the user is not a bot user.

I can agree with that. I think that the message should encourage people to avoid manual testing. This generally a bad idea.

/override pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
Lane upgraded to pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations which passed


get-credential does not work with powershell 5, works with powershell 7

Windows Terminal version
1.12.2931.0
Windows build number
22000.348 (win11)
Other Software
PSVersion 5.1.22000.282
Steps to reproduce

Open WT preview.
open psh 5 tab
run get-credential
output: Get-Credential : Cannot process command because of one or more missing mandatory parameters: Credential.
expected: gui or prompt.

Note
Expected Behavior
gui or prompt.
Note: behaves as expected with psh 7. Behaves as expected with WT release version (1.11.2921.0) and psh 5.
Actual Behavior
error output: Get-Credential : Cannot process command because of one or more missing mandatory parameters: Credential.

This looks like you're describing #2988. PowerShell 7 (very correctly) prompts for the credential at the actual commandline. PowerShell 5, however, pops open another window to get the credentials. In the Terminal (and anything using ConPTY), that external window is going to appear somewhere randomly in the z-order, which includes underneath the terminal window.
/dup #2988

This is not a dupe. Note the error message. There is no attempt to open the gui option for get-credential.

It looks like PowerShell 5 opens a window to populate the Credential parameter. That window appears to be immediately dismissed -- possibly by other software running on your computer (?). This results in the reported error message.

It can pop up that window in all normal system configurations (even if it shows up behind!)
The best place for this discussion is probably the powershell repository, but given that the issue is fixed in PS7 they're not likely to book work to fix 5.x. ☹

@HollisTech did you create any followup issue? For me, this happens with Win11 22H2 and Terminal 1.15.3466.0
I can work around it by opening a second powershell tab in terminal:

Also, it does not happen if I start powershell from "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe".

The problem here is that Windows PowerShell is calling CredUIPromptForCredentialsW with a hwndParent in the {CREDUI_INFO](https://learn.microsoft.com/en-us/windows/win32/api/wincred/ns-wincred-credui_infow) structure as the parent process' window handle. In the failure case I believe the parent process ends up being explorer.exe and not Windows Terminal  and something inside CredUIPromptForCredentialsW ultimately leads to that failure. A workaround is to set the following registry key that forces Windows PowerShell to use the console to prompt the user just like it does in PowerShell 7.
Set-ItemProperty "HKLM:\SOFTWARE\Microsoft\PowerShell\1\ShellIds" -Name "ConsolePrompting" -Value $True

jborean93

It works,Thanks.

@HollisTech did you create any followup issue? For me, this happens with Win11 22H2 and Terminal 1.15.3466.0
I can work around it by opening a second powershell tab in terminal:
Also, it does not happen if I start powershell from "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe".

Can confirm, this is still an issue with PS 5.1 on Windows 11. The "open a new tab in the PS console" trick works, as does the Set-ItemProperty "HKLM:\SOFTWARE\Microsoft\PowerShell\1\ShellIds" -Name "ConsolePrompting" -Value $True suggestion from @jborean93
PS C:\Users\AaronGuilmette> $PSVersionTable
Name Value
PSVersion 5.1.22621.963 PSEdition Desktop PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...} BuildVersion 10.0.22621.963 CLRVersion 4.0.30319.42000 WSManStackVersion 3.0 PSRemotingProtocolVersion 2.3 SerializationVersion <IP_ADDRESS>

Same here, workaround to open a new terminal tab works for me!

See 14119 - still open, so there is hope.


Replacing disabling dolphingrace with listener for depth boots

Instead of completely disabling "DOLPHINS_GRACE"  in BuffSpanker, substitute it with a dedicated listener for enchantments on the player worn boots for any level (or just 2/3) of Depthstrider (the reason its disabled).
Dolphin Grace without boots is slower than a horse and uses hunger, but is slightly faster than a boat that doesnt use hunger, ending up being balanced, while adding new ways of traversing water in an non op way (especially since food its harder to make than in vanilla, double price!).
((first issue submission ever))

I'm closing this out as something that we won't fix. It could be revisited in the future, but it's not within our capacity to work on right now.


Push scylla-bench docker image using gocql version from the PR

@sylwiaszunejko , please refere issue that it is related to in PR description

its just wip and testing stuff no need for the review right now


Add workflow to export UG to PDF

Adds a Github Workflow to automatically export the user guide to a PDF artifact which can be downloaded from the workflow. Only runs on changes to master and  docs/UserGuide.md.

Good idea! I am not sure how well this works with Jekyll themes will with this.


[IOTS-437] IOTS /devicemgt web page is showing "Error 500"

An Error Occurred! HTTP Status : 500 {/app/modules/oauth/token-handlers.js}  Could not set up encoded tenant based client credentials to session context as the server is unable to obtain such credentials - setUpEncodedTenantBasedClientAppCredentialsReference: https://wso2.org/jira/browse/IOTS-437

This is fixed and tested. Hence closing

Hi, which version is this issue fixed?  I'm using the latest zip version which was downloaded from the official website and still getting this error.

i  Configuring WSO2 IoT Server with the IP or Hostname but
i still getting this error too with V3.0.0


Statement::Finalize blocks nodejs event loop

Statement::Finalize runs entirely in main/event loop thread and could block event loop on sqlite3_finalize (if some other query currently executing in libuv thread pool). sqlite3_finalize should be called only from thread pool as any other sqlite3_ functions.
Wall clock profiling flamegraph:

I could make PR if there is no rationale to run sqlite3_finalize in event loop thread.

@alex3d I'd love to see a PR 🙂


Fixed typo in database rules

not a typo as the old value was good but the addition discrimination on a word boundary is valid.  thanks.


Add workflow for Cypress test on production with Chrome

This draft PR partially implements the workflow requested in https://github.com/corona-warn-app/cwa-website/issues/2892 "Add new GitHub Actions workflow carrying out the cypress test suite".
It was suggested in https://github.com/corona-warn-app/cwa-website/issues/2892#issuecomment-1141760610 to run the test regularly.
It uses https://github.com/cypress-io/github-action to run Cypress tests on the production server https://coronawarn.app once a day. The tests selected are the ones in the top level of cypress/integration. The problematic test check_links.js, which is prone to failure, is already moved down one level to cypress/integration/hybrid, and is not selected.
Removing the line spec: cypress/integration/*.js would run all tests, if that is desired.
https://github.com/cypress-io/github-action can be used as the basis for other workflows, which might also be integrated into PR submission, and it allows build and test server start parameters to be added.
I only tested this so far by manually triggering it. I did not test the cron part.

@MikeMcC399 thanks, we will have a look locally!

@MikeMcC399 I ran into some problems but I have fixed them in my latest commit. Now I am able to finish the workflow without errors.
https://github.com/corona-warn-app/cwa-website/commit/adb1ce970ca401a7a853f00e89d6eab6ca560839#diff-10d7404fdc00524a584d90f9b99b2e3d50d95659b03a58f21200449bbd8d43bb

@MikeMcC399
It's not me getting it to work, it's the Docker image that is specified to run on Ubuntu Linux runs-on: ubuntu-latest. All the workflow code will be executed on that said image. This Ubuntu version has only Electron installed but if we want to use Chrome instead, we have to make an effort to install chrome/chromium before the tests are executed.
Otherwise it will fail with this error message:

Good morning @svengabr!
It's curious that you get this error message, as it worked for me with chrome on ubuntu-latest. I am testing natively on GitHub in a private copy of cwa-website.
Here is part of the log file using chrome:

According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#browsers-and-drivers Google Chrome 102.0.5005.61 is included in ubuntu-latest which is currently equivalent to ubuntu-20.04.
You mentioned in https://github.com/corona-warn-app/cwa-website/issues/2909#issuecomment-1143470698 that you were testing with https://github.com/nektos/act. I wonder if this explains the difference in test results? I haven't tried out act so I can't speak from personal experience. You mentioned that ubuntu-20.04 is a docker image, however I couldn't find any reference about that, although act definitely does say in its documentation that it is using Docker technology.
I just submitted a tweak to the script in PR https://github.com/corona-warn-app/cwa-website/pull/2945 to make the raw log output from GitHub actions more readable.

@svengabr

Act is running on docker as well, did you try again with my latest changes? Maybe I broke something while installing dependencies?
I tried running on Windows 10 and on WSL2 Ubuntu and both resulted in the same problem.

If you are having a problem with the Chrome browser I think that is most likely because your test environment does not emulate the production environment exactly. I did check again and I'm still able to run on Chrome successfully.
My test setup is a private copy of cwa-website where I pull the branch cypress-workflow from cwa-website and push it to my own copy. I have my private copy of the branch cypress-workflow set to be the default branch so I can test the workflow directly and natively. My copy of the branch cypress-workflow is up-to-date including https://github.com/corona-warn-app/cwa-website/commit/db153300ba162f1fcd670374d88c9cd75cd533bb.
I run the workflow through a browser to GitHub, so everything is running on GitHub. I do this from Windows 11, but that is not relevant, since the workflow runs remotely and directly in the GitHub runner.
I have attached a log file from a successful Chrome run. (The workflow is the same as the original, except I changed the browser from electron to chrome, added the environment variable NO_COLOR and disabled the cron schedule.)
Successful Chrome run.zip

@svengabr

I wonder if electron has any downside I'm comparison to chrome

I found two problems running against electron on GitHub which do not occur every time.
They do not cause the test to fail. It just makes the test logs look suspicious. I could not find any obvious solution for either of these issues, which is why I chose to use chrome instead.
Problem 1 with Electron
I found the same error in an old open issue from 2018 https://github.com/cypress-io/cypress-docker-images/issues/52
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5220:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default
[3293:0603/110439.184841:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4732:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5220:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default
[3293:0603/110439.193337:ERROR:alsa_util.cc(204)] PcmOpen: plug:default,No such file or directory

Problem 2 with Electron
This error is listed in the open issue https://github.com/electron/electron/issues/32843
[2984:0603/110516.880897:ERROR:node_controller.cc(567)] Trying to re-add dropped peer FBF32221E33754E2.4A8A5ACE24A3244

Log attached, showing both problems:
Electron with errors.zip

@svengabr
When you ran act which of the images did you choose from the ones listed on https://github.com/nektos/act#runners?

@svengabr
I don't think that nektos/act should be the preferred way of testing a Cypress workflow for GitHub. It is better to test directly in GitHub on a copy of the repository.
Cypress is for testing against web browsers. The default act Medium Docker Image ghcr.io/catthehacker/ubuntu:act-20.04 however does not contain any web browsers. The act Large Docker Image ghcr.io/catthehacker/ubuntu:full-20.04 is built from the repository https://github.com/catthehacker/virtual-environments-fork, which is forked from the GitHub repository https://github.com/actions/virtual-environments/. The catthehacker fork is however left at a commit level of September 2021, which is 9 months behind GitHub. So, neither act image corresponds to the current virtual environment Ubuntu 20.04.4 LTS used by GitHub, which does contain up-to-date Browsers and Drivers:

Google Chrome 102.0.5005.61
ChromeDriver 102.0.5005.61
Chromium 102.0.5005.0
Selenium server 4.2.0
Mozilla Firefox 100.0.2
Geckodriver 0.31.0

nektos/act also introduces additional dependencies of Docker, WSL2 / Hyper-V or Ubuntu plus other package managers.
nektos/act: Default runners are intentionally incomplete says: "These default images do not contain all the tools that GitHub Actions offers by default in their runners. Many things can work improperly or not at all while running those image. Additionally, some software might still not work even if installed properly, since GitHub Actions are running in fully virtualized machines while act is using Docker containers (e.g. Docker does not support running systemd)."
I have only a small amount of experience with Docker and I found it very difficult to get everything running, with many individual steps, so for me it was a high overhead to set up. I was not able to pull the full Docker image (around 20GB) as the download either hung up or failed with unexpected EOF after having downloaded several Gigabytes.
So, although it was very interesting to look at nektos/act I suggest to drop its use for Cypress testing. If a Cypress test run fails on act it does not mean that it will fail on GitHub (e.g. Chrome works on GitHub and it is not necessary to install additional Ubuntu dependencies). If a Cypress test run is successful on act there is no guarantee that it will work on GitHub because the contents and version levels are not aligned between act and GitHub.

I don't think that nektos/act should be the preferred way of testing a Cypress workflow

@MikeMcC399 yes I agree with that. I will as well change from act to my own copy. Also, my colleague @brifemu is not available this week so I will take care of cypress in the meantime.


Consider making Pos.AnchorEnd take a Pos instead of int?

As in https://github.com/gui-cs/Terminal.Gui/pull/3716
In Wizard I had put a horizontal separator line above the buttons:

This was implemented as:
 //// Add a horiz separator
 var separator = new LineView (Orientation.Horizontal) { Y = Pos.AnchorEnd (2) };
 Add (separator);

With #3716, I really wanted to do:
 //// Add a horiz separator
 var separator = new LineView (Orientation.Horizontal) { Y = Pos.AnchorEnd (Pos.Func (() => xxx ) };
 Add (separator);

Where xxx was the height of the buttons.
Just a thought for now.... Not really needed so marked as post-v2

FWIW, I addressded this in #3716 as:
  //// Add a horiz separator
  var separator = new LineView (Orientation.Horizontal) { Y = Pos.Top (BackButton) - 1 };

Which works totally fine, except in the code that sizes WizardStepI had to do:
    private void SizeStep (WizardStep step)
    {
        if (Modal)
        {
            // If we're modal, then we expand the WizardStep so that the top and side
            // borders and not visible. The bottom border is the separator above the buttons.
            step.X = step.Y = 0;
            step.Height = Dim.Fill (Dim.Func (() => IsInitialized ? Subviews.First (view => view.Y.Has<PosAnchorEnd> (out _)).Frame.Height + 1 : 1)); // for button frame (+1 for lineView)
            step.Width = Dim.Fill ();
        }
        else
        {
            // If we're not a modal, then we show the border around the WizardStep
            step.X = step.Y = 0;
            step.Height = Dim.Fill (Dim.Func (() => IsInitialized ? Subviews.First (view => view.Y.Has<PosAnchorEnd> (out _)).Frame.Height + 1 : 2)); // for button frame (+1 for lineView)
            step.Width = Dim.Fill ();
        }
    }

Which feels lame.

If I could do this:
 //// Add a horiz separator
 var separator = new LineView (Orientation.Horizontal) { Y = Pos.AnchorEnd (Pos.Func (() => xxx ) };
 Add (separator);

step.Height could be
step.Height = Dim.Fill (Dim.Func (() => IsInitialized ? Subviews.Max (view => view.Y.Has<PosAnchorEnd> (out _) ? view.Frame.Height : 0) : 1));


Start-End  icons obscuring map features

Even with a blank, transparent default png a large blank box remains on the map.  I'm plotting multiple maps with common start-end points and the result is 10 overlapping empty boxes that obscure other map features.  I'll log a pull request to add a feature to specify no start-end icons.
Very pleased with the results I've gotten with the extension.
Thank You!

I just added a 'if' block on the end points and set it to false.  Added a boolean in your var declarations.  Didn't try to add a passed parameter.  This fixed my issues, but it might be a useful feature for others.

With the recent changes in v1.2.0 I believe if you pass startIconUrl: null and endIconUrl: null, it shouldn't attempt to place a marker at all. Could you confirm?

They were generated by gpx.js, I edited the base code.
When I get back to work on the maps I'll test this.

From: Maxime Petazzoni<EMAIL_ADDRESS>Sent: Thursday, January 12, 2017 6:28 PM
To: mpetazzoni/leaflet-gpx
Cc: atlbike; Author
Subject: Re: [mpetazzoni/leaflet-gpx] Start-End icons obscuring map features (#44)
With the recent changes in v1.2.0 I believe if you pass startIconUrl: null and endIconUrl: null, it shouldn't attempt to place a marker at all. Could you confirm?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mpetazzoni/leaflet-gpx/issues/44#issuecomment-272317015, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKvSeDzzjaGcBD3A56zXaDWFzMCeBCFKks5rRrc0gaJpZM4K3wn_.


fix(issue-329): asserts not found

bug https://github.com/helm-unittest/helm-unittest/issues/329

Update dependencies
Added test for cases when root value file is used
Added test for cases when value not contains required attribute
Added test when value is multiple text

Found pull-requests that break things. There is no test coverage for cases, so no way to catch itt

https://github.com/helm-unittest/helm-unittest/commit/1227d6acb90f95331d472c21d3893cfa6c1360c2
https://github.com/helm-unittest/helm-unittest/commit/ba93b9e39083008a2e398fe0a10a5b00b18328d7

👋 Hi @quintush. Looks like I managet to find a bug and fix it. Have a look when you have time pls.


Ballerina Thread pool config info should be documented

Description:
Initial size of the ballerina thread pool is (Number of processers available * 2). This value can be configured using the system variable BALLERINA_MAX_POOL_SIZE.
Steps to reproduce:
Affected Versions:
1.0-alpha
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Closing since this is done via https://github.com/ballerina-platform/ballerina-lang/pull/18901.

I believe we need to add this in a common place (potentially in addition to being mentioned in library docs).


Wrong dimmensions when using --pixelsize

I was recently mostly using test patterns, didn't check the size...
I just printed some picture which was exactly 3cm tall, it turned into 1.8cm after engraving. The ratio is exactly 0.6 which is my pixel size ratio (0.06/0.1)...
Tested on image only.
Looks like it's not related to the pixel size, I just did some test with image2gcode and it works.
Maybe that's because It was a very big image which I had to resize in inkscape ?
Also the bounding box seemed strange (square while it is a rectangular image).

I'm not sure about this one. The SD card I'm using stopped working little after I had this problem. At the moment I can't test and probably for the next few weeks... :disappointed:  So take it with a pinch of salt :smile:

Ok, I think I found what I may have experienced: scaling images isn't supported ? I didn't rebase the latest version yet (using settings branch).

Yes it is supported. The transformation engine is generic and works for all points in the SVG. The image points are all transformed.
I did several tests with ‘complicated images, and it works like a charm!
I also added rotation (the files are not in the repository yet, only locally, but it is already available on pypi!) and this too works like it should.

I was recently mostly using test patterns, didn't check the size... I just printed some picture which was exactly 3cm tall, it turned into 1.8cm after engraving. The ratio is exactly 0.6 which is my pixel size ratio (0.06/0.1)...
Tested on image only.

Ok, as I mentioned, there is no special case for images, all points are transformed equally!
I did several tests and it works. I use gcode2image to check the result gcode file. ‘gcode2image —showimage —grid —flip —showOrigin file.gc file.png’ shows the exact positioning and size of all gcode ‘objects’.

Ok, was it a recent addition ? I'll update & give it a try, else I'll attach the file here... can it be related to the 0.06 pixelsize ?
I again did a test, this time with png / completely different, also got something 0.6 of the desired size... (6cm instead of 10).

I confirm the issue, and now I'm 100% certain it's related to the --pixelsize. The resulting images are scaled by a ratio of "pixelsize / 0.1". To get things properly sized I need to scale it by 1.6666666666666667.

Additional notes:

paths don't suffer from the same issue, only pixmaps / images get scaled proportionally to the pixel size
image2gcode have the same issue
reported bounding box info exposes the issue by showing different values with different pixelsize

I confirm the issue, and now I'm 100% certain it's related to the --pixelsize. The resulting images are scaled by a ratio of "pixelsize / 0.1". To get things properly sized I need to scale it by 1.6666666666666667.

Ok, I'll look into that. Code inspection did not reveal this, but maybe I missed that.
But my question is, what version of svg2gcode are you using?
It should be svg2gcode version 2.4.0!
What svg2gcode options do you set when things go 'wrong'?

To confirm the issue, I used the latest version (using pip install -U on a
venv):
❯ svg2gcode --version
svg2gcode 2.4.0

Message ID: @.***>

Paths aren't concerned by the issue, and since it makes images smaller, the bounding box will not change if I set a path around an image (since the image will be "inside" the path, which is correct).
For some tests I only used --pixelsize argument with value 0.06, no other argument, since the bug is visible from the gcode I didn't need to set the laser values & test for real.

Ok, did some tests just now, and I can confirm the issue.
I'll fix this.

Awesome, thanks!
Le jeu. 24 août 2023 à 12:45, johannesnoordanus @.***>
a écrit :

Ok, did some tests just now, and I can confirm the issue.
I'll fix this.
—
Reply to this email directly, view it on GitHub
https://github.com/johannesnoordanus/svg2gcode/issues/10#issuecomment-1691445095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB2IHW6RKMXA3LCQR6UDVLXW4WFLANCNFSM6AAAAAA3S4OJZE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Ok, fixed it in version 2.5.0 of svg2gcode and version 2.3 of image2gcode.
Different fixes by the way!

Now it's consistent !
But still some problem seems to remain:
Using a tiny path in SVG which cover the whole document, I can export it to PNG (the whole page) and compare the results of svg2gcode vs image2gcode (since the DPI is set properly it should result in the exact same dimensions).
Document is 10cm x 3cm and the content almost fills it.
Using svg2gcode:
; Boundingbox: (X5.967950,Y2.185769):(X94.032053,Y27.814232)
; Bbox center: (X50.000001,Y15.000001)

which looks absolutely fine.
But using image2gcode with the exported png is surprising:
Area: 177.6mm X 53.4mm (XY) while it should show the exact same values.

Doing more tests, it looks like something have changed in the linked images loading, it's not working well anymore and fails loading in some situations (when the path is relative to the svg image).

Looks like a factor 2?

Not to me, this time I don't get what's happening, it's not as obvious as the pixelsize bug.

What DPI setting?

Good guess, indeed it looks like DPI is completely ignored so the number of pixels is the only thing considered by image2gcode (or just not applied properly), the image size is proportional to the DPI (while it shouldn't).
Interestingly (or not), I can't get the same thing with svg2gcode at the moment, doing a test which I thought was similar as the previous one I did. Maybe there was something wrong in my test like something I didn't see in the viewport...
About the resolution, it looks a little low, but now I understand some results I got with image dithering not working as expected.
Most lasers have a better resolution than this (0.08 is the standard), mine have a 0.06 spot size (~ 423dpi) so almost twice the internal resolution of this app.
I am not fully understanding why you need to rescale images internally though ^^

Doing more tests, it looks like something have changed in the linked images loading, it's not working well anymore and fails loading in some situations (when the path is relative to the svg image).

Ok, (well not ok), do you have the file name strings from the sgv's (field 'xlink:href') that do not work?
Because that should not happen.

I found a nasty error: bounding box info wasn't initialised properly (svg2gcode).
This might explain some of the problems you mention.
I have a fix and an update, but that will be tomorrow.

Updated image2gcode to version 2.4.0. This is a roll back with added comment and clarification.
Updated the README to make things clear.
Updated gcode2image to version 2.3.0. This is a change of option --showorigin (no capitals now).
Images conversion to gcode and the inverse work correct (now) and give the same dimensions (but see the README).
svg2gcode update (2.6.0) is nearly there, but I need to do some conversion checks.

Not to me, this time I don't get what's happening, it's not as obvious as the pixelsize bug.

I think this was due to the bounding box initialisation problem I mentioned. This could wreak havoc , because the order of 'images' and 'path' objects within the SVG file determined a correct or faulty initialisation.
Anyway, I fixed that and subsequent tests reveal correct results, even with a pixelsize of .06 mm.

What DPI setting?

Good guess, indeed it looks like DPI is completely ignored so the number of pixels is the only thing considered by image2gcode (or just not applied properly), the image size is proportional to the DPI (while it shouldn't).

That is right, image2gcode produces images (gcode) of pixelsize * number of pixels (both dimensions). I just made it that way. svg2gcode has a destination size (in mm) for each image within the SVG drawing and calculates the number of pixels needed for the specific pixelsize. The source image is scaled accordingly to make the correct image information available to let the conversion function to operate correctly.
But I could do that with image2gcode, and in fact, I did. So now image2gcode has option --size width height, that sets target (gcode output) width and height in mm. This is available in version  2.5.1.
I also added option --center, which places the origin at the center of the image (gcode output).
Several test with image2gcode and gcode2image revealed the correct sizes.

Interestingly (or not), I can't get the same thing with svg2gcode at the moment, doing a test which I thought was similar as the previous one I did. Maybe there was something wrong in my test like something I didn't see in the viewport...

See my comment above about the bounding box error.

About the resolution, it looks a little low, but now I understand some results I got with image dithering not working as expected. Most lasers have a better resolution than this (0.08 is the standard), mine have a 0.06 spot size (~ 423dpi) so almost twice the internal resolution of this app. I am not fully understanding why you need to rescale images internally though ^^

Nice that the laser has such a small spot size!. I have to do with .08 mm^2.
But if you set the pixelsize on 0.06 svg2gcode (and image2gcode) generate a result with exactly that pixelsize (in gcode).
So results should be spot on.
Image dithering is not needed at all and even unwelcome in my opinion.
Image source resolution is important though, because if the resolution is to low for a pixelsize of .06 (for example) the image will be upsampled, and that will create image artefacts that might be visible.
So I alway choose images that have a source resolution that is as large or better than required (downsampling does generates artefacts, but much less visible (in my experience)).
Anyway, svg2gcode version 2.6.2 is out and incorporates the bounding box fix and some other things.
One of which is a new option --selfcenter, which generates 2 passes, one to determine the bounding box, two to set the origin at the center.
Note that gcode2image is updated to version 2.3.0

I would like to close this issue because the issue is solved.

Can't have time to test now, but according to what you said I think we can consider it closed :)
As a side note, I tested lightburn and it "just works", including some interesting things which are really useful:

configurable dithering, made internally (meaning it will always be optimal resolution) - I also found dithering not so useful using your code, but there it works very well... maybe because of the internal resolution ? It seems to allow "faking" better dynamic range and made drastic improvements for some test images I had
by default there is "overscan" meaning the laser will go a little "too far". This seems to be a "standard workaround" for #6

On the other hand I'm very unhappy with their USB / connection flow / UI / code which works surprisingly poorly (at least on linux).

Can't have time to test now, but according to what you said I think we can consider it closed :)

Ok, I'll close it

As a side note, I tested lightburn and it "just works", including some interesting things which are really useful:

configurable dithering, made internally (meaning it will always be optimal resolution) - I also found dithering not so useful using your code, but there it works very well... maybe because of the internal resolution ? It seems to allow "faking" better dynamic range and made drastic improvements for some test images I had

I know light burn, it is the reason I started this project. Dithering is something you can do beforehand using image processing software, or even Inkscape. The is no 'internal' resolution in the code I use, I made an error updating image2gcode in this regard and correct that later on. The resolutions is entirely your choice, but takes SVG requirements for image size into account. Image2gcode has a --size option to also set such a requirement, but pixelsize of the result image (gcode) is alway exactly what you define.
So maybe your test regarding dithering where not complete. I know dithering effects will work because all pixels are translated one on one. The only thing that can wreck havoc is up and downsampling possibly happening because of an image resize.
Inkscape is a much (much) better and universal (generic) approach that the editor of lightburn. And you can control image resizing and generate dithering using Inkscape.

by default there is "overscan" meaning the laser will go a little "too far". This seems to be a "standard workaround" for Incorrect power for image's left & right borders #6

That was/is the solution I was thinking off. But I had no time to verify the issue myself. But I will incorporate that in the near future when needed.

On the other hand I'm very unhappy with their USB / connection flow / UI / code which works surprisingly poorly (at least on linux).

This is the same on Mac, but after a while it will grow on you. I tested it for a month and found that it works. But I don't like the paying bit and the lack of a good editor (Inkscape is the way to go in my opinion). I also wanted much more control over the emitted gcode and what 'is going on'.
I (we) now have that with the tools that are created by me. And I am happy with the feedback you gave/give because that makes things a lot better defined and bug free.
If you are looking for other tools that work, try LaserWeb. The user interfaces is a bit difficult to grasp at first, but it does work with SVG documents and is able to 'fill' shapes and generate gcode for it!
It also has a great gcode visualiser which is really precise. I use that to check my gcode for example.


BLD: Remove zoltan dependency for ease of compilation

Zoltan, while a useful tool, is not very necessary for the adaptivity functionality. To make compilations less error prone across multiple platforms, we should move towards a stack without zoltan.

@zhang-alvin we could just make this an option to the adaptivity. It looks like @tridelat fix on #585 probably fixes the issue related to zoltan, so we can also just close this.

@cekees Agreed. I 'd rather have zoltan in


Add new command to help setup Reliably with CI/CD platforms

Add a new command
name still to be chosen setup, init, worfklow, ... ?
This command would help the user to generate the workflow file for CI/CD platforms, using Reliably CLI.
It would create the file directly in the current working dir (ie the user repo)

it can be closed now the PR is merged


Analytics: Bugfixes and styling changes for v1.5

This should fix the pie chart bugs and also makes some small styling changes to the other graphs.
@rishig @timabbott

Automated message from Dropbox CLA bot
@amyliu345, it looks like you've already signed the Dropbox CLA. Thanks!

We merged this a few days ago.


Remove unused cuParamSetTexRef()

Part of #2768. It's currently unused in the codebase, and it's marked deprecated for quite some time, so let us remove it to suppress some deprecate warnings.

Jenkins, test this please

Jenkins CI test (for commit e30f3d7cc50ea590379a001c4679006413d6671f, target branch master) succeeded!

Thanks!


Prefetch Updates Follow-up

seen in https://github.com/Observation-Management-Service/ewms-pilot/pull/41 for rabbitmq

TODO: remove prefetch