Parse the replay only once when uploading

this also accidentally adds a full edit feature for all non PC-98 games. Follow-up PR adding the things required to make it official coming soon

I'm not sure this is a good idea, for two reasons.
The first reason is that it complicates the user experience. Previously, from the user's perspective, when they upload a replay, the replay isn't added to the site until they fill out the follow-up page. If they realize on parsing it that they uploaded the wrong replay, they can just leave; they don't have to do anything to cancel the upload or delete the pending file. After this PR, the idea of a pending replay is introduced to the user. If they upload the wrong replay, they need to actually take an affirmative action to get rid of it; otherwise, it will clog up their profile page and stick around indefinitely.
The second reason is that it complicates the "Replay" table. Previously, any row in the Replay table was a valid replay, or at least a replay with all required information filled out. Now, though, there will be lots of replays in the Replay table with bogus values for fields like "score" or "is_clear". This makes the database more confusing, because it limits what we can know about a Replay instance; we don't know that some of these fields have legitimate information in them or not. This makes it easier for us to introduce bugs later by getting confused.
Of course, there is one major benefit to this PR too, which is it makes the code simpler. The TemporaryReplayFile table is gone, and a hypothetical future "edit" page would look basically the same as the "finalize publish" page does now. These are both nice, but I don't think they outweigh the two factors above. (I don't think it really matters whether we parse a replay once or twice, since parsing replays is quite cheap anyway.)
I do want other people to weigh in on this too. if everyone thinks this is a good idea but me, we can still go ahead and do it.

I can add a TTL to pending replays I just don't know how that whole system works lmao

So here are my more nuanced thoughts:
Regarding the first issue: I could keep the pending replays on the user's profile page, but also have pending replays expire and get deleted after 30 days automatically. That way, while the concept of a pending replay still exists, the user doesn't have to worry about it. I could also add the TTL to pending replays and not show pending replays on the profile page, which would remove the concept from the user entirely
As for the second issue: I personally don't care. I pretty much never look through the replay tables on the production database. I rarely even look at the replay table in my local database. If I needed to look through my local database, I can deal with the pending replays myself, but on the production database I don't need to look through the replay table.
I'd still like to know the thoughts of other maintainers

Yeah, as you mention the first issue isn't really core to the PR; you could maintain the current interface while still making most of these changes.
The second issue isn't about personally looking at the database; it's about writing code against the database. The more complex the database, the higher the rate of bugs will be in code that is written against the database. And on a replay site, almost all code is written against the database. This PR puts information into the database that is actually wrong: fields like is_clear receive preliminary values that aren't really accurate. I think it would probably be better to set these fields to null instead, but even if we did that, now code that deals with replays has to worry about these fields possibly being null. The previous code did need an extra table, but that table compartmentalized that information, so that most code did not have to concern itself with replays that were in the process of being uploaded.
A big part of keeping a codebase healthy and easy to work with is ruthlessly compartmentalizing sources of complexity; that's really the source of my concern.

fields like is_clear receive preliminary values that aren't really accurate. I think it would probably be better to set these fields to null instead, but even if we did that, now code that deals with replays has to worry about these fields possibly being null.

I mostly did that to get around constraints but I don't really know how they work. The proper way to do things would be to have constraints that force values like is_clear to be None while having the normal constraints if the replay isn't pending.

One more thing regarding the constraint thing though: if fields like is_clear can't be None if the replay isn't pending, then anything that doesn't want to deal with pending replays can simply filter for replays where the category is not "Pending" and then that code can still assume that is_clear can only ever be true or false.
Follow up thought: I made Pending a category rather than it's own True/False field because I wanted to make new use of the already existing code for private replays. Should "Pending" be it's own field in the replay table or bunched in with categories?

I think I agree with n-rook's second point. We don't want things clogging up the Replay table that don't serve the same functionality as the Replay table. Whether this change goes ahead or not I don't mind, but it should be integrated in a way where future code edits don't have to worry about accidentally tripping over some additional constraint when dealing with the database.

I have added constraints so that

Any code that excludes pending replays when iterating over the replay table never has to deal with things that couldn't be null before suddenly being able to be null
is_clear has to be null if the replay is pending and can't be null if it isn't
Is there anything else I could do to mitigate the second point?

Pushed the changes to add a TTL to pending replays. Also, my constraints from 2 commits ago don't prevent pending replays to have a value for is_clear, but they do still prevent is_clear from being null if the replay is not pending

Those changes definitely help, but my original concern still stands.
Another way to think about it is that after this change, the database is less normalized. I never studied database normalization academically, so my understanding of it is only conversational and intuitive, and I can't really talk about it formally well. But from this perspective, it's believed that it makes the database harder to deal with if it contains redundant data. In this case, there are two new forms of redundant data introduced. The first is that if the replay is pending, certain fields always have certain values. This is alleviated partly by the use of constraints, but it still adds to the complexity of the table. The second form of redundancy is that lots of fields on the Replay table are functions of the replay itself. Of course, this redundancy is also present in non-pending replays, but it is necessary there; we need these values in the database so we can make queries against them. But for pending replays, the only benefit to storing this information in the database is to prevent us from having to re-parse the replay. And parsing replays is so fast that this benefit is very small.
Like I said earlier, if you can convince both raviddog and morth that this change is a good idea, I'm happy to be overruled and let it in. But I really do think it is cleaner to keep pending replays in a separate table, so that most of the codebase never has to worry about their existence.

I never heard of database normalization until today. I'm not really sure how to articulate this, but in essence, the thought of the second point never occured to me when I made this PR, and I still don't think it's a big problem, especially with constraints and tests in place. Like sure, bugs might be more likely to occur with this change because it makes the main replay table more complicated, but bugs can also happen without this change. I think that the difference is very very small though, especially with proper constraints and test in place and I think the benefits do outweigh the downsides.
As for what the actual performance benefits are, I want to run the tests for that on the production server, since it has much worse specs than any of our dev machines.

I decided to run tests on the server. The performance difference is very small, only about 0.05 seconds even on a low end server, and I could easily implement an editing feature in a different way. I'm ready to close this now since this wouldn't be worth it, and also the commit history on this PR is a mess now

I am closing this now and I am saving the important commits in case we decide that we want to unearth this again. If we wanted to merge this, I'd want to remake the PR anyways.


Should Saturn suggest using Canopy for testing?

Canopy is a nice DSL for automated Web app testing (via Selenium) that, IMHO, should get more attention than it's gotten so far. I believe it would make a good addition to the Saturn template, but before I start a PR against the template, I'd like to open a discussion first. Does Canopy fit well with the Saturn philosophy and/or the SAFE stack? Should it be added to the template, or just mentioned in the docs as a recommendation but not added to the template?

Yes canopy fits well with SAFE-Stack. We already use it in the bookstore
sample
Robin Munn<EMAIL_ADDRESS>schrieb am Di., 10. Juli 2018, 06:22:

Canopy https://lefthandedgoat.github.io/canopy/index.html is a nice DSL
for automated Web app testing (via Selenium) that, IMHO, should get more
attention than it's gotten so far. I believe it would make a good addition
to the Saturn template, but before I start a PR against the template, I'd
like to open a discussion first. Does Canopy fit well with the Saturn
philosophy and/or the SAFE stack? Should it be added to the template, or
just mentioned in the docs as a recommendation but not added to the
template?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SaturnFramework/Saturn/issues/99, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNE0u-AM_Ak-YjASzXlO-0tl1qKAmks5uFCwCgaJpZM4VIvS6
.

I definitely want to mention Canopy in Saturn docs, I've also considered generating Canopy tests as part of the scaffolding we do with Saturn.Dotnet

Probably the big issues for adding Canopy to scaffolding/template is fact it's still requiring mono

I'm stupid - Canopy supports Core

Closing this one - I think it's good idea to support/promote Canopy. But this needs to be handled in template, documentation and in code generator. Nothing to do with core library.


Add env var support for lifecycle api work with tilt

Issue #, if available:
Description of changes:
As of now we had these as local changes whenever we wanted to test the full lifecycle api work so checking some of the automation in. I added the ability to read and set the env var for Tilt, as well as set the env var when running create cluster.
I debated using the bundle manifest for getting the controller image and copying the govc and helm binaries from that image using a multi-stage build, but for this use case it didn't feel necessary to have to write the logic to parse that file in the Tiltfile and use an image that is built from main instead of from local. I also looked into setting the env vars using kustomize substitutions like they do in cluster-api, but realized that that is more effort than needed for this use case due to the amount of tooling that is required to make that happen.
I also added the ability to clear the cache for the features for unit testing. Because of how our unit tests are run, there is a chance for env vars to be leftover in the mutexMap, so clearing it for some of the test cases for now.
Testing (if applicable):
Ran unit tests and tested this functionality through tilt. Also testing create cluster with and without this env var.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 559119f:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 559119f:
:clock10: Full build: the average full build time is 5 min(s) 48 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 559119f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Design for help us (how you can help us)

In header should be HELP US dropdown link
There should be pages per help us option
General page for information, how to help us, and contact us button

design added to figma


inference performance tunning

hello,  thanks for you great work.  I want to enhance the model inference performance, can you give some advices.
below is some ideas I want to try:

use FP16
change the input image size to small

is that ok ?

Yes, if you want to improve the speed/memory of SimpleClick, you can use a smaller input size (e.g., 224x224). Using FP16 should also be helpful.

ok. so how to find the smaller model? do you mean just change the input size


<EMAIL_ADDRESS>

Used by:

https://github.com/SkyAPM/cpp2sky
https://github.com/alibaba/hessian2-codec

Related to : https://github.com/hedronvision/bazel-compile-commands-extractor/pull/188

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bazel-compile-commands-extractor) have been updated in this PR. Please review the changes.

As the repo already has a MODULE.bazel, we should coordinate this with the maintainer.
CC @cpsauer

Thanks, Fabian. Offhand, I think we'd rather just continue distributing directly as git_override, since it's a dev dependency, to save bookkeeping for everyone and keep living at head. [i.e. propose closing.] I'll work with Matthieu on the in-repo PR to try to understand and fix the underlying problem.
Cheers!
Chris


Fix performance impacting race condition in deploy handler

Description
This PR fix the performance impact race condition, caused by the deploy handler, when a dependency is in the deploying state due to a repair run. This PR makes sure that the requires argument of the deploy handler can never contain a resource with the ResourceState "deploying".
closes inmanta/lsm#433
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in c2ed97938fb7eeb0c5f269cac245391d0d316c8d

Processing #4039.


Data consumption and some other questions

Hi. Have a few questions:
A) If zmap scans just one port across the whole IPv4 space, how much data is consumed? I plan on running zmap in Linode so I'd like to know how much data a one port scan will consume so that I don't go past my data allotment. I'm thinking it's not very much, but I'd like to know the real numbers.
B) The readme states a 45 minute scan across all of the IPv4 space with a Gig connection. Is that just for one port? How long would it take for all 65,535 ports? I guess I'd like to know the rate for a one port scan on a Gig connection. My project just involves looking to see if a port is open. Don't need banners or other stuff beyond that.
Thanks.

If zmap scans just one port across the whole IPv4 space, how much data is consumed? I plan on running zmap in Linode so I'd like to know how much data a one port scan will consume so that I don't go past my data allotment. I'm thinking it's not very much, but I'd like to know the real numbers.

A standard SYN packet is 44 (Minimal) <-> 72 (Normal) bytes and SYN-ACK is around 70 bytes (according to Akamai). Not sure if zmap sends RST upon receiving SYN-ACK, but if it does, my 1 minute google says they're around 11 bytes. Multiply these by the number of ports and hosts and you should get an answer with a huge margin of error.

The readme states a 45 minute scan across all of the IPv4 space with a Gig connection. Is that just for one port? How long would it take for all 65,535 ports?

45 Minutes * 65,535 Ports = 2,949,075 minutes
(Not a professional or related to zmap development in any way)

Thanks for the input. Sounds prudent I guess based on your quick research. Looks like ~ 4.5 MB per IP address for all 65,535 ports. And given there are over 4.2 billion IPs in the IPv4 space that means a ton of data I guess.

45 Minutes * 65,535 Ports = 2,949,075 minutes

That's around ~ 5.5 years. :laughing:
My intended use case for right now is one port scanning for a project I'm a member of.  So I guess I'm looking at around ~ 280 GB based on just 70 bytes per IP and port. ( 70 * 4 billion).


Android support

Please make this awsome plugin usable on android devices.
Also it would be nice to have the possiblility to stream the frames
via upd to a server instead of saving it to disk.

we won't do it. but pull request is welcome.


CORTX-27062: Dynamic port range to be parsed from config.yaml for hctl over http

The htctl http port number for incoming consul connections is hardcoded
as 8008.
Solution:
Handle the http port value in cfgen:

Read the port number from CDF.yaml as /network_ports/hax_http.
Write the port number in consul-kv.json as ports/hax.
Update consul conf:
Read the port from kv and configure a consul service hax_http.
Read and use the value in hax:
Read the ServicePort with consul util and use it on hax start.

Signed-off-by: Dmitry Kuzmenko<EMAIL_ADDRESS>

This is duplicate of PR https://github.com/Seagate/cortx-hare/pull/2038
cc @mssawant @vaibhavparatwar

Test this please
Restart deployement


Update cgmanifest to include vcpkg dependencies and linux tools we use in CI.

Documenting all AptDependencies and vcpkg.deps
These, currently, include:

curl (which transitively depends on openssl, and zlib)
paho-mqtt
cmocka
gcc-arm-none-eabi
gcovr
lcov
clang-format
doxygen

I see we are freezing the version numbers which is the best approach for build stability.

This file and PR in itself doesn't freeze anything (that isn't the purpose of cgmanifest, all we are doing is declaring our dependencies). We rely on vcpkg to handle the versioning for us. The other versions are defaults that we get on our build images based on OSes like ubuntu-18.04, etc. when installed.
We pinned the vcpkg version to this:
https://github.com/Azure/azure-sdk-for-c/blob/fad6ccb651a438ec6214d3d4944c051f72f71630/eng/vcpkg-commit.txt#L1

/azp run c - client


(Code) Make I/O async

Modify JsonFileLogger and JsonConsoleLogger to write asynchronously, collecting these tasks in a list, and waiting on them all when the simulation finishes.

Nice idea, will not be implemented for now :)


[done] update zeros_initializer()

I'm reading source code this day, and I find there is a #TODO in array_ops.py saying that move zeros_initializer() to init_ops.py.
So, I think I can help update the change. Not only move zeros_initializer() to init_ops.py, but also update the reference files which call array_ops.zeros_initializer().
BTW,  I list all of them as below:

init_ops.py
array_ops.py
rnn_cell.py

3 files in contrib/..

feature_column.py
histogram_ops.py
rnn_cell.py

@girving  Could you have a look?

Can one of the admins verify this patch?

@martinwicke sure thing, let me update ASAP

@martinwicke Plz check

Jenkins, test this please

You need another init_op import in histogram_ops. I guess they didn't have one.

@martinwicke You're right. I forgot importing it. Now, it works

Jenkins, test this please!

@martinwicke hhhh...You're so fast! There is another file needed to import init_ops

Jenkins, test this please!

Heh.
On Tue, Sep 20, 2016 at 21:24 Jingtian Peng<EMAIL_ADDRESS>wrote:

@martinwicke https://github.com/martinwicke hhhh...You're so fast!
There is another file needed to import init_ops
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4462#issuecomment-248507953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjO_Q_-FWAIq0DO3-z2F4QuAp7pXrqoks5qsLF7gaJpZM4KAjUB
.

Jenkins, test this please. (Jenkins won't listen to you, sorry)

Hhhh..I try it, but failed. ╮(╯▽╰)╭

@martinwicke Ok, alphabetically...You all have good habits

We have pedantic linters. :)

Yey!


debug land albedo regridding

Purpose
see #764 description and thread for details
what we know:

changing the regridder_type passed to the albedo constructor between InterpolationRegridder and TempestRegridder changes the quality of the plot produced (only tempest is messed up)
tempest produces an unrealistic plot for both the temporal and static maps,

this is true whether we use a space constructed with spacefillingcurve in ClimaCoupler or not

To-do

Content

Plots

AMIP and slabplanet look the same
plot looks the same after init and after 1day simulation
mostly using slabplanet_temporal_map.yml config with h_elem: 16, but tested with AMIP too

Interpolations regridder

Tempest regridder
looks the same with or without spacefillingcurve in ClimaCoupler

Static map
Interpolation regridder

Tempest regridder

[ ] I have read and checked the items on the review checklist.

The problem is in boundary_space somehow. I created a horzspace from scratch from the coupler and it works. What I noticed is that the boundary_space mesh has a different elemorder compared to a fresh horzspace
julia> boundary_space.grid.topology.elemorder
2400-element Vector{CartesianIndex{3}}:
 CartesianIndex(1, 1, 1)
.....

julia> horzspace.grid.topology.elemorder
CartesianIndices((20, 20, 6))

These are not equivalent.
Interestingly,
julia> extrema(parent(good) .- parent(bad))
(0.0, 0.0)

where good and bad are albedo obtained using horzspace or boundary_space respectively.

ClimaAtmos and ClimaCoupler both create spaces using a spacefillingcurve (e.g. here in ClimaCoupler.Regridder), whereas ClimaLand and ClimaUtilities both create spaces without a spacefillingcurve (e.g. here in ClimaUtilities.TempestRegridder). This is why the two spaces have different element orders.
I had to add a TempestRemap GPU workaround in ClimaLand to force the regridding to happen on the CPU (this involves creating a new CPU context and space), and I noticed that if I created the undistributed space with a spacefillingcurve, space_distributed == space_undistributed was not true. This is why ClimaLand (and ClimaUtilities) don't use the spacefillingcurve. We should unify this across all repos, but I'm not sure which approach we should take

The problem is in boundary_space somehow. I created a horzspace from scratch from the coupler and it works. What I noticed is that the boundary_space mesh has a different elemorder compared to a fresh horzspace
julia> boundary_space.grid.topology.elemorder
2400-element Vector{CartesianIndex{3}}:
 CartesianIndex(1, 1, 1)
.....

julia> horzspace.grid.topology.elemorder
CartesianIndices((20, 20, 6))

These are not equivalent.
Interestingly,
julia> extrema(parent(good) .- parent(bad))
(0.0, 0.0)

where good and bad are albedo obtained using horzspace or boundary_space respectively.

ClimaAtmos and ClimaCoupler both create spaces using a spacefillingcurve (e.g. here in ClimaCoupler.Regridder), whereas ClimaLand and ClimaUtilities both create spaces without a spacefillingcurve (e.g. here in ClimaUtilities.TempestRegridder). This is why the two spaces have different element orders.
I had to add a TempestRemap GPU workaround in ClimaLand to force the regridding to happen on the CPU (this involves creating a new CPU context and space), and I noticed that if I created the undistributed space with a spacefillingcurve, space_distributed == space_undistributed was not true. This is why ClimaLand (and ClimaUtilities) don't use the spacefillingcurve. We should unify this across all repos, but I'm not sure which approach we should take

resolved - see https://github.com/CliMA/ClimaCoupler.jl/issues/764


Upgrade Angular to V7

[ ] feature request

Issue description
https://angular.io/guide/releases

Please also the starter kit.


Remove git reference for sev

Having the sev dependency come from GitHub instead of crates.io was causing errors when vendoring. This change fixes it, as it makes Cargo look for sev on crates.io.
Fixes issue 333.

@fitzthum any reason for using the virtee/sev here?


Gambling contract

[ ] participate (GMB value, bet value) {Cost: GMB} make sure all the GMBs are burnt after this call, and move some parts to treasury address. Lock the users LP token
[ ] endTurn () onlyAdmin
[ ] claim: check the turn is finished, and msg.sender actually won the game. Change the credit of msg.sender

[ ] Wrtite tests


Share to Zulip from other apps

This is the feature where from some other app on the device, when you say to "share" something, you get a system-provided bit of UI that lets you choose from various apps you can share the thing to. We should make Zulip one of the options there. (In the RN app, we've done this for Android but not iOS: https://github.com/zulip/zulip-mobile/issues/3277)
From some surveying of the options (below), it looks like the way to do this will be to use Flutter's generic infrastructure for talking to platform APIs, rather than try to use an existing plugin for it.
In doing so, we might find there’s a reason this can’t be done real cleanly as a plugin. Or maybe we’ll make a better plugin.
Starting points for taking this on:

Flutter docs for Android at “How do I handle incoming intents from external applications in Flutter?”, showing an example of exactly this.
See also this Medium post that refreshingly isn’t just walking through a library’s setup instructions; it goes through building this functionality more directly.
iOS docs: share extensions, and for messaging apps adding conversation suggestions.
Also the existing libraries mentioned below are not a ton of code — like <1 kLoC each. So they may be useful as examples.

Subtasks:

[ ] #53
[ ] #54

Survey of existing packages for sharing to a Flutter app
(These are from notes I took 2023-02-01.)
There don't appear to be any existing packages for this problem that are real popular or well maintained.

The most popular is [receive_sharing_intent](https://pub.dev/packages/receive_sharing_intent). From the issue tracker, it seems not actively maintained.
There’s [receive_multi_sharing_intent](https://pub.dev/packages/receive_multi_sharing_intent) which is a fork of that one, unmaintained.
There’s [share_handler](https://pub.dev/packages/share_handler) which is maintained.
Another observation on all of the above: they call for quite a bit of changes to the project’s own files to fully wire them in.
Newer and Android-only: [receive_intent](https://pub.dev/packages/receive_intent).

Hi,
I would like to work on the Android version of this.
I am still looking into the packages mentioned. The Flutter way seems straightforward, but relies most on Native Android.

https://github.com/fluttercommunity/plus_plugins/tree/main/packages/android_intent_plus
https://pub.dev/packages/android_intent_plus
Android-only; repo actively maintained; for sending intents (not receiving)
https://github.com/aboutshout/share_handler/tree/main/share_handler
https://pub.dev/packages/share_handler
Android, iOS; relatively new; based on https://github.com/KasemJaffer/receive_sharing_intent
https://github.com/fluttercommunity/plus_plugins/tree/main/packages/share_plus/share_plus
https://pub.dev/packages/share_plus
Android, iOS, Linux, MacOS, Web, Windows; for sending intents (not receiving)
https://github.com/bhagat-techind/flutter_sharing_intent
https://pub.dev/packages/flutter_sharing_intent
Android, iOS; seems to be based on receive_sharing_intent; looks new, and doesn't support Sharing Text Files (.txt)
https://github.com/daadu/receive_intent
https://pub.dev/packages/receive_intent
Android; barebones -- developer implementing the package has to specify and handle data being received; does not seem to work with images (https://github.com/daadu/receive_intent/issues/18); not production ready?
https://fluttergems.dev/packages/receive_multi_sharing_intent/
https://pub.dev/packages/receive_multi_sharing_intent
Android-only, listed as supporting iOS; can't find actual repo, only forked repo linked

share_handler seems to be the only good package.
We might have to work on the issue through native code.

Thanks for the updated survey. I added more detail in a chat thread.
Let's try using package:receive_intent — I think that's the one option out of these that looks promising.
In particular:

I'm not concerned about that issue about images. The report is quite vague about what the person actually tried, what they expected to happen, and what happened instead. It reads to me as much more likely to be some confusion by the issue author than any actual issue in the library.
After looking around in the code and tracker of share_handler, I don't think it's a library I'd want to rely on.


rpm package doesn't generate the api key even if cscli is present

after installing the bouncer on my amazon linux, the api key wasn't added to the configuration

fixed in https://github.com/crowdsecurity/cs-firewall-bouncer/pull/53


Add Fine Tuning Example

Add a standalone fine tuning example

self contained to be able to run with single cargo run command.
supporting data for fine tuning can be part of example similar to how images are kept for examples/create-image-variation
(Optional) use https://github.com/openai/openai-cookbook as inspiration

Looks like this is still relevant?

@Doordashcon , I do not see any Deprecated or Legacy warning on https://platform.openai.com/docs/api-reference/fine-tunes
so relevant, yes?


Report table styles

[x] Closes #418  .
[x] I am familiar with the contributing guidelines.
[x] Tests added.
[ ] Updates entries to docs/source/api.rst for API changes.
[x] Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Allows scrolling for tables that scale with the number of selected metrics/pairs/quality flags.
Here is a report rendered both ways:
With new scrolling: post-scrolling.zip
Without scrolling: pre-scrolling.zip

Report with minor updates since opening the PR:
post-scrolling.zip

It looks good to me. Here's a deterministic report with lots of metrics that will scroll on anything but fullscreen. It'd be great if you could double check it given the differing render results we've seen.
lotsametrics.zip

Can you do that plus an obnoxiously long name?

Can you do that plus an obnoxiously long name?

Here are two reports for:

Longest possible name containing lots of short words
lotsofmetricslongname.zip
Longest possible name containing a few spaces
lotsofmetricslongword.zip

from the long word report, this behavior of the table title is a little weird but not a big deal. let's move on unless it's a trivial fix

Should be fixed!
lotsofmetrics_longword.zip

fixed, but now the table title locations are inconsistent. maybe they should be left-aligned?


shinyproxy 2.4.0 loses reactivity when containerized

Shinyproxy 2.4.0. running in docker containers cause shiny apps to lose reactivity - only with shinyproxy 2.4.0, not with previous versions.
The issue can be experienced by applying the following example:
https://github.com/openanalytics/shinyproxy-config-examples/tree/master/02-containerized-docker-engine
Replacing 2.4.0 in the Dockerfile with 2.3.1 does not experience the same issue - everything works as expected with 2.3.1.
Attached are two screen captures demonstrating the issue with v2.3.0´1 and v.2.4.0, respectively.
Thanks and kind regards
sandro

Thanks for reporting, @shosaco ! We will investigate.

Thanks for you report. This has the same cause as #239 .
I'll update the repo and official images soon. In the meantime you can change this line https://github.com/openanalytics/shinyproxy-config-examples/blob/master/02-containerized-docker-engine/Dockerfile#L1 to FROM openjdk:11-jre

We just released [https://shinyproxy.io/downloads/#241](ShinyProxy 2.4.1) which is now again built using JDK 8.
I close this issue now, but don't hesitate to open a new issue if you encounter a new issue!

Just ran into this issue myself and was happy to see that a new version was already released.
Unfortunately it seems to me like 2.4.1 still does not work properly on JDK8, because it still uses the containerproxy 0.8.5 version which, for me, was causing the issue in the first place (see below).
Can you check if the jar contained in the current release was actually built using JDK8 and, if not, release a fixed version with the dependency also built using JDK8 (probably a 0.8.6 then)?
I'll try using Java11 in the meantime, I'd actually prefer this to run on the newer JVM, but was not sure if this was a supported configuration.
2020-10-21 12:11:26.701 ERROR 19 --- [   XNIO-1 I/O-2] org.xnio.listener                        : XNIO001007: A channel event listener threw an exception

java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
	at eu.openanalytics.containerproxy.util.DelegatingStreamSourceConduit.read(DelegatingStreamSourceConduit.java:117) ~[containerproxy-0.8.5.jar!/:0.8.5]
	at org.xnio.conduits.ConduitStreamSourceChannel.read(ConduitStreamSourceChannel.java:127) ~[xnio-api-3.8.0.Final.jar!/:3.8.0.Final]
	at io.undertow.util.Transfer$TransferListener.handleEvent(Transfer.java:212) ~[undertow-core-2.1.4.Final.jar!/:2.1.4.Final]
	at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92) ~[xnio-api-3.8.0.Final.jar!/:3.8.0.Final]
	at org.xnio.conduits.ReadReadyHandler$ChannelListenerHandler.readReady(ReadReadyHandler.java:66) [xnio-api-3.8.0.Final.jar!/:3.8.0.Final]
	at org.xnio.nio.NioSocketConduit.handleReady(NioSocketConduit.java:89) [xnio-nio-3.8.0.Final.jar!/:3.8.0.Final]
	at org.xnio.nio.WorkerThread.run(WorkerThread.java:591) [xnio-nio-3.8.0.Final.jar!/:3.8.0.Final]

Hi @xperimental
Thanks for reaching out! The fact that it is still using ContainerProxy 0.8.5 is no problem, since no changes to the code had to be made. However, there was some problem with rebuilding the packages using JDK 8.
This is now fixed and I uploaded new packages to the shinyproxy website, using version number 2.4.1
For reference this is the sha256sum of the working version 12ba6366f0d44859b4cd8dbc8469183d0eab1db1d87dffa4bb5a7d9db53bd583

In that case the file in the releases is not the correct one, because it's shasum differs:
> shasum -a 256 shinyproxy-2.4.1.jar
d1eb75bab9470cef60c6086f2aab4df41bbe81daf00147f1cb0089257dfee565  shinyproxy-2.4.1.jar

This is also the SHA256 checksum mentioned in the shinyproxy-2.4.1.jar.sha256 file.

Thanks for the heads up, these were forgotten during the rebuilds....
The correct version is now also available at Github releases.


Add files via upload

GTU Account Address: 45qfRrU1jztardSP5e2znKD33668UPMYoQJpnnF8wi8Xmqnv84
Device Make and Model, OS Version: iPhone 8, iOS 13.6.1

confirmed:B1
node:a451814312938fe9

confirmed:B2

confirmed:B2

confirmed:B6

confirmed:B6

confirmed:ID4
AccountAddress:45qfRrU1jztardSP5e2znKD33668UPMYoQJpnnF8wi8Xmqnv84
DeviceDetails:verified

confirmed:ID4
AccountAddress:45qfRrU1jztardSP5e2znKD33668UPMYoQJpnnF8wi8Xmqnv84
DeviceDetails:verified

confirmed:B4
address:45qfRrU1jztardSP5e2znKD33668UPMYoQJpnnF8wi8Xmqnv84
baker:298

confirmed:B4
address:45qfRrU1jztardSP5e2znKD33668UPMYoQJpnnF8wi8Xmqnv84
baker:298

Form submitted.
Submit Time: 15:00 GMT+03:00
Time Zone: GMT+03:00 (Istanbul time zone)

Form re-submitted for the second time to double verify the Concordium wallet address as well as the Github account.
Re-Submit Time: 11:25 GMT+03:00
Time Zone: GMT+03:00 (Istanbul time zone)


cargo_dependency: add git helpers

Howdy!
This change allows use of the git and branch fields on CargoDependency. As far as I can tell, these are unusable w/o a helper because CargoDependency is non exhaustive and immutable.
I'm not sure if it's worth having four methods here. Perhaps with_git_and_branch and with_git_and_branch_and_features is sufficient.

Thanks for the contribution @sanderpick !
I think having the methods here is fine for now, but we might have to see if we want to move to a more explicit builder pattern in the future. It's a combinatorial explosion waiting to happen otherwise :)
One nitpick though: Could you also update the CHANGELOG.MD to reflect your changes?

@sagacity no problem! CHANGELOG.MD updated.

Sweet! Thanks for your contribution 🥇

Can you also fix the formatting? cargo fmt --all should do the trick.

@sagacity, I pushed the formatting fix. Thanks for the tips... I'm a few days into rust 👍


in unit tests, add --no-verify to commits so that any hooks users hav…

…e do not break the tests

👍


add qdrant vector store Integration

This looks solid overall - can you add a docs page with some examples like this one too?
https://js.langchain.com/docs/modules/indexes/vector_stores/integrations/milvus

Closing as the extension #1396 has just been merged. Thank you!


Integration with nvd when available

I would like to use nvd (nix diff) to see the delta after an evaluation between the current system and the evaluated one.
It is useful for my local deployments where I do "interactive" upgrades and deployments.
What would be the way forward to send such a PR?

This currently can be done as an activationScript that supports dry activation: https://github.com/zhaofengli/colmena/issues/128#issuecomment-1333791919. Adding an interactive step for confirmation can be tricky because of the parallellism Colmena has. Evaluation, build, and deployment of different nodes can be running at the same time.

Tried it, thank you! It works great, but colors is broken it seems like? Would you be open to a small PR to document it or have a first-class support with deployment.contrib.useNVD = true; or something like this?


Redesign Flank output

The gcloud output seems more user friendly and structured. It's probably worth aligning Flank output a bit more with gcloud, although we don't have to follow it exactly.
I think pointing people to the support page is a nice touch. The matrix summary table is cool.  There might be a fancier way of displaying our report results as well.
For example this format isn't super readable.
MatrixResultsReport
  0 / 2 (0.00%)
  2 matrices failed

 gcloud firebase test android run flank.yml:gcloud

Have questions, feedback, or issues? Get support by visiting:
  https://firebase.google.com/support/

Uploading [../test_app/apks/app-debug.apk] to Firebase Test Lab...
Uploading [../test_app/apks/flaky-androidTest.apk] to Firebase Test Lab...
Raw results will be stored in your GCS bucket at [https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-19_21:48:46.285984_Fzwu/]

Test [matrix-jf8goq9q6zyca] has been created in the Google Cloud.
Firebase Test Lab will execute your instrumentation test on 2 device(s).
Creating individual test executions...done.

Test results will be streamed to [https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/7974756372300129768].
21:49:52 Test matrix status: Finished:2 Pending:4

21:50:29 Test matrix status: Finished:6
Instrumentation testing complete.

  Updating matrix file

CostReport
  Virtual devices
    $0.20 for 12m

MatrixResultsReport
  0 / 2 (0.00%)
  2 matrices failed

Error: Matrix failed: matrix-2kfcwoyh1z9tz FINISHED failure  https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/7897562908617453208
Error: Matrix failed: matrix-4ssc3q1dsjfxa FINISHED failure  https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/6539867209135871024

I think good entry to resolve this issue is to split output into points. So we can decide which of points are important for user and how should be displayed. For now I can specify following points in flank output:

Info about flank version

version: local_snapshot
revision: 71aac52b6883d9e55b9fccb798771cbea5d1dbb3

Full config print

AndroidArgs
    gcloud:
      results-bucket: test-lab-v9cn46bb990nx-kz69ymd4nm9aq
      results-dir: null
      record-video: false
...

Info about uploading files before test execution

Uploading app-debug.apk   Uploading flaky-androidTest.apk ..

Additional Info before tests execution (could be different depends on configuration)

6 tests / 2 shards

Test execution summary

  2 matrix ids created in 0m 3s
  https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2020-05-20_04-54-17.446000_SUAG/

Matrices webLink
  matrix-2kfcwoyh1z9tz https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/7897562908617453208
  matrix-4ssc3q1dsjfxa https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/6539867209135871024

Test execution status
Could be different depends on needs. Currently we can display 3 different output styles. https://github.com/Flank/flank/pull/779. For example:

  3m 35s Test executions status: FINISHED:2 PENDING:2 RUNNING:4

or
  3m  1s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-0 execution-1745swg41t0b2 FINISHED
  2m 55s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-1 execution-2tgcqxrrupgu5 FINISHED
  4m 58s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-1 execution-1689yp4w2xewa Starting instrumentation test.
  4m 23s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-0 execution-17j3zh3bwvc5m Preparing device.
  4m 52s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-0 execution-28h3aflk56m55 Installing apps.
  4m 58s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-0 execution-2fht77lyehkk8 Completed instrumentation test.
  4m 52s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-1 execution-3ttu7s12ylovo Starting instrumentation test.
  4m 58s matrix-3hy98fkuzmdpy NexusLowRes-28 shard-1 execution-ugdjrkzws8mka Starting instrumentation test.

Info about result data synchronization

FetchArtifacts
  ............
  Updating matrix file

Summary info about execution report

MatrixResultsReport
  0 / 2 (0.00%)
  2 matrices failed

Error: Matrix failed: matrix-2kfcwoyh1z9tz FINISHED failure  https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/7897562908617453208
Error: Matrix failed: matrix-4ssc3q1dsjfxa FINISHED failure  https://console.firebase.google.com/project/flank-open-source/testlab/histories/bh.bf178d418be9d33e/matrices/6539867209135871024

Probably some of those parts can may look different depending on test run configuration. The error messages are also another story
@bootstraponline I like idea about displaying details from 8. in table
If we want to reduce size of log we can remove point 2 and write full config to file. This is only suggesstion.
We can also consider to set single line output style as default (point 6).

Thanks for breaking the problem down into sections! I love that approach.
My primary motivation was improving the user experience when reading the log data. I think it's fine if the log is a bit long.
For example:

Uploading app-debug.apk   Uploading flaky-androidTest.apk ..

compared to gcloud

Uploading [../test_app/apks/app-debug.apk] to Firebase Test Lab...
Uploading [../test_app/apks/flaky-androidTest.apk] to Firebase Test Lab...

The second one is a bit more informative. The formatting is also a bit cleaner. I'm not sure I have a specific proposal here, the task would be to think about alternative options.

@bootstraponline I like idea about displaying details from 8. in table

Awesome. I created a dedicated ticket for this task. https://github.com/Flank/flank/issues/810

@bootstraponline I spoke with Jan and have thought about it for a while also and there are few things that can be done here to improve readability of the output and I wanted to gather them together:

Break down the output into specific sections
Shorten the content where you think it can be done without loosing any important information
Add headlines distinguished somehow visually form the rest of the content so they would be a good anchor point for your sight when scrolling though the output
Present the summary in form of a table

You have already agreed with Jan on 4 but I think that also 3 would be a good improvement here. We probably should also get some input on the shortening of particular content sections where you see it fits without losing any important information in first sight.

That sounds great. I trust @jan-gogo's judgement on what's important. Gcloud provides a good baseline for the types of information we're looking to display.

Upload logs should be refactored as well (within this issue scope)

Some of the work was already done in this scope.
I think we need a summary comparison of flank and gcloud output log. May be in the table form.
Flank shares some output details with gcloud but probably not all and may display them in different ways.
With detailed summary we can compare each part of the flank and gcloud outputs one by one and decide if there is more work to do.


use symbol table for global symbols

A quick fix to close #1401. Swaps in GlobalSymbol for GSym which pretty seamlessly resolves the thread safety issues. We can probably revisit this later if needed. I could see using the parking_lot mutexes as a better alternative to the standard library ones since I don't see lock poisoning as useful in a string table context

This should be all good to go now, just waiting for the green light on tests. Made some minor modifications to the jq fud stage to allow passing flags. Also tweaked a line in calyx_py that was giving me an error for some reason.

Awesome!! Nice work tracking down all the places where we wanted --sort-keys.


seemingly randomly activated copy on select

Sometimes vscode enables some kind of "copy on select", reloading the window disables it.
I hope someone else who also experienced this bug can add some additional insights.

VSCode Version: 1.52.1
OS Version: Windows 10 19042

Steps to Reproduce:

The bug happend about about 4 times in the last few months, I sadly don't know what causes it.

Does this issue occur when all extensions are disabled?: unknown

@Teiem I'm not sure what you mean by "copy on select". Please let us know if you find a way to reproduce it.

@Teiem I'm not sure what you mean by "copy on select". Please let us know if you find a way to reproduce it.


"Deploy to Azure Kubernetes Service" is no longer a valid option

"Deploy to Azure Kubernetes Service" is no longer a valid option in the Configure tab as documented in Step 6. As a result, all the remaining steps are invalid. Tutorial needs to be updated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbceb1f5-05c3-487d-6e21-dc1b4936a55c
Version Independent ID: 35355737-9ad9-9df5-b612-806d9df2462b
Content: Deploy to Azure Kubernetes Service - Azure Pipelines
Content Source: docs/pipelines/ecosystems/kubernetes/aks-template.md
Product: devops
Technology: devops-cicd
GitHub Login: @shashankbarsin
Microsoft Alias: shasb

I am currently facing the same problem. Are there any news on this issue?

"If this is not what you see, then make sure the Multi-stage pipelines experience is turned on."

Same problem here. You should stress the fact in the doc that this preview feature needs to be on to follow the tutorial. Now it works.

@mcurko we had already added a note (shown below) on turning on the preview feature for multi-stage pipeline experience. Once that preview feature is turned on, the 'Azure Kubernetes Service' option appears in the recommended template list


feature requestion - fxtwitter

discord twitter embeds suck and have been broken for a while and but things like fxtwitter fix that. i copy links from tweet deck a lot but extensions like this only work on the regular twitter site
i think it would be really useful to add an option to change all links you copy to fxtwitter

While client mods are technically not allowed, nobody has been reportedly banned for them. You can try using Vencord (which is probably the lightest client mod thats still updated right now), turn on the "TextReplace" plugin, and set a filter to change Twitter/X links to fxtwitter


LDAP AuthProvider for OCP

The LDAP authentication provider needs to be added to the OCP cluster.  Pre-build if possible, but it looks like tat might not be possible so post-build may have to do.  Reference here: https://docs.openshift.com/container-platform/4.6/authentication/identity_providers/configuring-ldap-identity-provider.html

There was a bug in the inventory group_vars that set the incorrect LDAP base, as well as an incorrect file path in the deployment of the manifest file. All seems to be tested properly now though 👍


Where can I find my shortcode?

Hey folks, thanks for releasing this package! 🙏
The documentation refers to a shortCode or "Region specific merchant ID".
https://github.com/SalesforceCommerceCloud/commerce-sdk/blob/master/packages/generator/README.md#usage

Where does this value come from?
It doesn't appear to be mentioned on https://developer.commercecloud.com/ or https://documentation.b2c.commercecloud.salesforce.com/ – am I missing something obivous?
It seems to be used to construct the hostname the commerce-sdk makes requests to ... eg. $SHORTCODE.api.commercecloud.salesforce.com
Can I construct this value from my On Demand Sandbox URL? For example, if I had sandbox at abcd-001.sandbox.us01.dx.commercecloud.salesforce.com ... is there a relation to the short code?
Thanks!

Hey John, shortCode is currently provided for you by your product point of contact, Terence. I've assigned him to this issue and he should be able to help you shortly (no pun intended).

Short code is provided directly by Salesforce.  In this case I've emailed you your short code :)


:book: Attempt to update doc on workspaces

.. but I do not understand the Workspace/ClusterWorkspace duality, so that part is still not clear.

Summary
This PR attempts to update the doc on workspaces.
Note: I do not understand the Workspace/ClusterWorkspace duality, so this doc may need more work in that regard.
Related issue(s)
Fixes #623

This looks great, thanks @MikeSpreitzer!


Add ModelFusion community integration

@BruceMacD thanks! I ended up creating a new PR after the fork sync: https://github.com/jmorganca/ollama/pull/1020


add a worker to fix spam flags from sendgrid

Adds a worker to check for spam requests at SendGrid and then remove them. This is necessary because we often get marked as spam when we send to the NoiseBridge list.
Also ads a basic sanity test and a Sinatra fake SendGrid, for stubbing.

Closing this as I've taken a different approach in PR #147


[Bug]: Boost amount shown is less than actual used

Describe the bug
When boosting a tx that has a lower than market fee rate the amount shown before submitting the tx is less than the actual. E.g. it says 9 sat/vb and actual is 15.
First tx: 69936428f299bc25c7a851faad3ce418082daa8b7b4d9362dd78921a4c02c318
Boost tx: a88aa10ca7ea9affd9da90135826b90084ef2dc53c07a05f7fda369be66b9198
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
Android 13 TKQ1.221114.001
Bitkit version
118
Log output
No response

I think the intention of this is to display the intended effective fee rate (the aggregate of the transaction being boosted and the boost transaction). So this is probably ok although I found it confusing.

Transaction fee rate selected is lower than the rate calculated by mempool.space for the broadcast transaction


Blablador

Deploy  at Blablador as option
https://strube1.pages.jsc.fz-juelich.de/2024-02-talk-lips-blablador/#/title-slide
https://sdlaml.pages.jsc.fz-juelich.de/ai/guides/langchain_with_blablador/

That's a great idea. @kuivi can you contact Alexandre and ask if he is interested to host us and what are the options :) I would prefer to have a website behind some password for now.

@dmpantiu Have experience with it already, you should talk :)

"blablador changed its embedding model" so if it will work, we could try it again after B.


Error: Change the button, its looks odd with non symmetry

Describe the Error
Need to change the button how it looks like
Expected behavior
you can use gssoc website button simillar
Additional context

Assign this to me.


Implementation of /timestamp command

This PR implements the approved suggestion for a timestamp feature here. This comes in the form of three subcommands.
/timestamp make - Creates a timestamp based on fields provided. Supports tags for which format to display.
/timestamp now - returns the current date and time in UTC and a timestamp in the Long Date/Time format. This is to allow people to easily see their UTC offset, as it's currently impossible to get timezone implicitly.
/timestamp relative - returns a timestamp offset from the current time by the amount of days, hours, and minutes provided. Supports tags for which format to display.

I've also added an update for the DMA series 5 into this, as this now has a section ID on the Zendesk


GoDCR unresponsive after receiving DCR with an already pending transaction on macOS (ARM only)

This issue only happens on M1 Macs: If you receive DCR when a pending transaction is still happening the UI freezes with a macOS "beach ball." Only fix is to control-c in the terminal window running godcr or force quit in activity monitor.

This issue is no longer occuring on master.


Differentiate friend pins in list view

This PR differentiates the friend pins in the list view by providing their name and a different color
Resolves #82

@jake-shasteen :+1:

@jake-shasteen :+1:


Editor not visible in new Window

The editor is not visible when I render it in a separate window. I can see the markdown in the devtools but I do not see the editor.
I created a codepen with a minimal repro example: https://codesandbox.io/s/objective-stonebraker-rvleh
monaco-editor version: 0.17.1
Browser: Chrome 75
OS: Mac OS

@alexandrudima @rebornix - any thoughts on this issue? I'd be happy to submit a PR, but I'd appreciate some direction on where to start in the codebase.

@sh3nan1gans I have added the following log statement here:

I see the console.log running only once so you are creating only one editor. If the container dom node is changed, then the old editor must be disposed and a new editor created at the new container dom node.
Please ask such questions on Stack Overflow, I can offer information about the Monaco Editor, but it looks like your sample is really using deep React methods with which I am not familiar.


Add support for custom remediation messages

Context

What has been done

Validation

PR check list

[ ] As much as possible, the changes include tests (unit and/or functional)
[ ] If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.36%. Comparing base (2e31e08) to head (bc98683).
Report is 40 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   91.42%   91.36%   -0.06%
==========================================
  Files         174      176       +2
  Lines        7169     7241      +72
==========================================
+ Hits         6554     6616      +62
- Misses        615      625      +10

Flag
Coverage Δ

unittests
91.36% <100.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[doc]update editorial workflow content and images

Brief change log

update editorial workflow content and images
update project overview picture

Verify this pull request
Manually verified the change by testing locally

@zhongjiajie Do you have any other suggestions?

@zhongjiajie Do you have any other better suggestions?

no, well done @SnowMoon-Dev  and thanks for you contribution, merging


Remove PathUtil.pwd and PathUtil.chdir

Current code used Dir.pwd everywhere except for inside the PathUtil module itself. It also used Dir.chdir vs PathUtil.chdir inconsistently across the board.
Since the wrappers don't seem to provide anything on top of the raw functionality, I figured it'd be best to remove them?

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Agreed.

P.S. I just hope no extensions were using those. :-)

Me too :sweat_smile:! Just sneaking it these changes taking advantage of being still 0.x :)


[GHA] Revert auto-commit

ref https://github.com/rectorphp/getrector.org/pull/307#issuecomment-826102050

@TomasVotruba reverted

Thanks


enhancement Rowset [0-1] do not engage in delete bitmap calculation during MOW SC

What problem does this PR solve?
Problem Summary:
Cloud schema change engages [0-1] rowset to unify logic.
Release note
Cloud schema change engages [0-1] rowset to unify logic.
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[x] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run p0


Problem with installing puppetboard. It was fine about a week ago :-(

I had to reinstall puppetdb & puppetboard. I have all of my stuff in gitlab. When I tried to reinstall puppetboard I got the below error. The only fix is to copy over /srv/puppetboard from another machine :-(
Notice: /Stage[main]/Puppetboard/Python::Virtualenv[/srv/puppetboard/virtenv-puppetboard]/Exec[python_virtualenv_/srv/puppetboard/virtenv-puppetboard]/returns: ValueError: I/O operation on closed file
Error: true  && virtualenv --system-site-packages -p python /srv/puppetboard/virtenv-puppetboard && /srv/puppetboard/virtenv-puppetboard/bin/pip wheel --help > /dev/null 2>&1 && { /srv/puppetboard/virtenv-puppetboard/bin/pip wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-use-wheel'; } ; { /srv/puppetboard/virtenv-puppetboard/bin/pip --log /srv/puppetboard/virtenv-puppetboard/pip.log install   $wheel_support_flag --upgrade pip setuptools || /srv/puppetboard/virtenv-puppetboard/bin/pip --log /srv/puppetboard/virtenv-puppetboard/pip.log install    --upgrade pip setuptools ;} returned 1 instead of one of [0]
Error: /Stage[main]/Puppetboard/Python::Virtualenv[/srv/puppetboard/virtenv-puppetboard]/Exec[python_virtualenv_/srv/puppetboard/virtenv-puppetboard]/returns: change from notrun to 0 failed: true  && virtualenv --system-site-packages -p python /srv/puppetboard/virtenv-puppetboard && /srv/puppetboard/virtenv-puppetboard/bin/pip wheel --help > /dev/null 2>&1 && { /srv/puppetboard/virtenv-puppetboard/bin/pip wheel --version > /dev/null 2>&1 || wheel_support_flag='--no-use-wheel'; } ; { /srv/puppetboard/virtenv-puppetboard/bin/pip --log /srv/puppetboard/virtenv-puppetboard/pip.log install   $wheel_support_flag --upgrade pip setuptools || /srv/puppetboard/virtenv-puppetboard/bin/pip --log /srv/puppetboard/virtenv-puppetboard/pip.log install    --upgrade pip setuptools ;} returned 1 instead of one of [0]

Can you provide the pip log.

I have attached the pip.log for your review.
pip.txt

This is a duplicate of https://github.com/voxpupuli/puppet-puppetboard/issues/163 which is a problem  with what looks to be something in setup tools getting auto upgraded in the virtual environment.


RSI calculation returns no value

With RSI period of 14, the calculating RSI for the following values return nothing
[ 294435,  294435,  294435,  294500,  294500,  294500,  294520,  294539,  294539,  294600,  294600,  294600,  294600,  294600,  294700 ]
but when I change some value to be
[ 294435,  294435,  294435,  294500,  294500,  294400,  294520,  294539,  294539,  294600,  294600,  294600,  294600,  294600,  294700 ]
RSI returns -> 78.49
I'm not sure in which condition RSI return nothing,
should this problem be handled by input pre-validation or output post-correction.
(or if this a bug?)

@stylixboom It is possibly a bug when the first two numbers are the same. I'll look at it. Thanks

If, when calculating RSI for a given set of prices, every increment gains (or loses), then there is a divide by zero error.
In the above example, when 294500 was changed to 294400 the number of loses went from 0 to 1 and so the division works.


How to access the supported patterns of the WindowsElement

Hello,
I would like access the supported patterns for the WindowsElement like Scroll Item Patterns etc...
Because for some of the verification I want scroll the item into view without clicking on the element.

Took us forever to get a good version of scroll.  Hope this helps get you started:
public void ScrollDownToElement(AppiumWebElement wpfList, string name)
{
  if(!localIsVerticallyScrollable()) return;
  while(localKeepScrolling())
  {
    var firstMatch = wpfList.FindElementsByXPath("*/*[@Name = '{name}']").FirstOrDefault(); //Check immediate children for elements with a name match
    if(name == null) OurMouseLibrary.MouseWheelScrollDown();
    else return;
  }

bool  localIsVerticallyScrollable()
{
  if(bool.TryParse(wpfList.GetAttribute("Scroll.VerticallyScrollable"), out bool isVerticallyScrollable)) return isVerticallyScrollable;
  return false;
}
bool localKeepScrolling()
{
  if(double.TryParse(wpfList.GetAttribute("Scroll.VerticalScrollPercent"), out double verticallyScrollPercent)) verticallyScrollPercent<100;
return false;
}
}

Thank a lot for the reply. Let me try this.

It's amazing solution I tried above suggestion, it almost works for my scenario.
Is there any way to call a method of pattern. For example ScrollItemPattern support a method ScrollIntoView(), now how to call ScrollIntoView() method from WindowElement. I think this single method can resolve many of my problem.

@darshanls not in C#.  I saw a method in javascript() that would do this.

@darshanls The almost part of working for the rest of your cases can get a little complicated.
In my situation, I found two ways that worked well to know when I scrolled to the listItem enough to click it.

listItem.GetAttribute("Offscreen") == false
listItem.GetAttribute("BoundingRectangle") is contained within the ScrollViewer control

OurMouseLibrary.MouseWheelScrollDown();

@liljohnak : I am getting an error here, Can have implemented this library?

@anunay1 We are using this to scroll.
https://github.com/charygao/MouseKeyboardLibrary/blob/3d58676a02426c00ff4676b6bbffc64bd442d2b3/MouseKeyboardLibrary/MouseSimulator.cs#L252

ScrollDownToElement

https://github.com/microsoft/WinAppDriver/issues/1538#issuecomment-996530073


Add KiKA metainfo

KiKA metainfo is also provided by the ArdDownloader/ArdParser
BTW: Thanks for this project: Would you mind to submit it to the Amazon Store (FireTV)

Thank your very much for your contribution! However, I'll use the ZDF downloader (working again in v1.3.1) instead because the API is much more robust and reliable as it does not rely on HTML scraping.


update quick start codes in README with semicolons for easy copy-pasting

Added semicolons to make it easy to copy-paste. Prevents making careless mistakes while copy-pasting over to projects. Makes things easier for people to pick up and implement buefy from the get-go.

Nice! Thanks :)


plugin.yaml differs with release version

Hey hey ! 😄
In our current Aqua setup we build a custom trivy image with the aqua plugin included.
For installing the plugin we pin the version by specifying the release tag in the URL (supported by the go-getter lib).
We realized that the specified plugin version in the plugin.yaml is always the version which was released before the pinned release.
Currently when installing the plugin with the latest release tag we get the wrong version of the plugin installed, due to the wrong pinned version.
Install of version 0.123.3 will acutally install 0.121.2
See here:
https://github.com/aquasecurity/trivy-plugin-aqua/blob/v0.123.2/plugin.yaml#L3
Is this a desired release behavior or a release bug? :)
Kind regards
Felix

Hey @fwiedmann
It was a bug, we've fixed this issue :)


feat(diagnostic_converter): add converter to use planning_evaluator's output for scenario's condition

Description
background

Planning_evaluator node is designed to evaluate the quality of planning and control.
We would like to make use of the evaluation result for the scenairo simulation's pass/fail judgment.
Planing evaluator's output diagnostic_msgs::msg::DiagnosticArray can't be understood by scenario_simulator_v2 directly.
So in this PR, converter node which convert from diagnostic_msgs::msg::DiagnosticArray to tier4_simulator_msgs::msg::UserDefinedValue which can be understood by scenario_simulator_v2 is implemented.

discussuion

UserDefinedValue msg is originally included in scenario_simulator_v2 repository
scenario_simulator_v2 side want to keep their compability with other system not only autoware. And autoware-dependent implementation (converter node in this case) shouldn't be included in the scenario_simulator_v2 repository.

Proposal in related PRs

Take UserDefinedValue msg out from scenario_simulator_v2 and tried to make repository for the msg. We noticed this is not the only option with the comment and we decided to add this msg in tier4_autoware_msgs. You can check discussion in this PR
implement converter node in autoware side not in scenario_simulator_v2 repositpry

Related PRs
https://github.com/tier4/tier4_autoware_msgs/pull/73: Adding new message type UserDefinedValue and UserDefinedValueCondition to package tier4_simulation_msgs
https://github.com/autowarefoundation/autoware_launch/pull/219: Adding argument so that planning_evaluator node will be launched when scenario_simulator_v2 is running.
https://github.com/tier4/scenario_simulator_v2/pull/874: modify scenario_simulator_v2 so that the output from convertor node cen be understood by scenario_simulator_v2.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.
In-review checklist for the PR reviewers

[ ]  The PR reviewers must check the checkboxes below before approval.
[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
After all checkboxes are checked, anyone who has write access can merge the PR.

I am unable to build the new package due to a missing message:
Starting >>> diagnostic_converter
--- stderr: diagnostic_converter
In file included from /home/mclement/autoware/autoware/src/universe/autoware.universe/planning/diagnostic_converter/src/converter_node.cpp:15:
/home/mclement/autoware/autoware/src/universe/autoware.universe/planning/diagnostic_converter/include/converter_node.hpp:21:10: fatal error: scenario_simulator_v2_msgs/msg/user_defined_value.hpp: No such file or directory
   21 | #include <scenario_simulator_v2_msgs/msg/user_defined_value.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In the CI this also causes an issue:
diagnostic_converter: Cannot locate rosdep definition for [scenario_simulator_v2_msgs]

@maxime-clem
sorry please use this branch
https://github.com/tier4/pilot-auto/tree/feature/evaluator_integration

By setting End condition below in the scenario file
  - Condition:
      - name: ''
        delay: 0
        conditionEdge: none
        ByValueCondition:
          UserDefinedValueCondition:
            name: /diagnostic/planning_evaluator/metrics_obstacle_distance_mean
            value: 10.0
            rule: lessThan

Output of planning_evaluator is used to scenario's fail/success condition(in this case, obstacle_distance_mean)
In this video, when obstacle_distance_mean is less than 10.0, scenario failed.
Screencast.webm

So in this PR, converter node which convert from diagnostic_msgs::msg::DiagnosticArray to tier4_simulator_msgs::msg::UserDefinedValue which can be understood by scenario_simulator_v2 is implemented.
scenario_simulator_v2 side want to keep their compability with other system not only autoware. And autoware-dependent implementation (converter node in this case) shouldn't be included in the scenario_simulator_v2 repository.

I thought that was what concealer in the simulator was made for. https://github.com/tier4/scenario_simulator_v2/blob/master/external/concealer/src/autoware_universe.cpp
Are there reasons why we can't update concealer to fix this issue?

@mitsudome-r
Is the following correct as a confirmed question?

Why do we create a converter to convert DiagnosticArray→UserDefinedValue instead of updating a concealer to convert DiagnosticArray→hoge (information used in scenario_simulator_v2 for pass/fail judgment)?

Assumptions

The DiagnosticArray output by planning_evaluator, for example, contains a lot of information. It has not yet been determined whether all of this information will be used for success/fail.
There are some information that is difficult to measure on the scenario_simulator_v2 side and easy to calculate on the autoware side (e.g. measurement of lateral distance taking shoulders into account), and there is a need to use such information for scenario evaluation.

Answer

Disadvantages of converting each item of the DiagnosticArray in concealer

It is necessary to convert the information to be used for success/failure in the DiagnosticArray one by one in the concealer.
If the implementation on scenario_simulator_v2 side catches up, the output function to be used for success/failure on the autoware side will become unnecessary → conversion work in the concealer will be wasted.

Advantages of creating a converter and filling DiagnosticArray with information for use in success/failure

Autoware contributor who doesn't have scenario_simulator_v2 information  can add information to the DiagnosticArray that they want to utilize for success/failure and use it as a criterion for success/failure.
No need to modify the simulator itself on the autoware side.

@mitsudome-r
Could you review this PR?
I need approve from autoware-global-codeowners.


Integration dialog states "aborted"

Environment/versions
Home Assistant 2021.3.4
Frigate custom component 1.0.4 installed via HACS: Integration version:  1.11.3 and Frontend version:<PHONE_NUMBER>0032
Frigate 0.8.4-5043040 installed via Add-On Store works as expected at ip:5000
Host is Docker on Debian 10 on Intel NUC.
What I am doing
I am trying to finish the integration by selecting "configuration->integrations->add integration->frigate"
When I do this, a dialogue titled "aborted" is displayed, with a close "x" and close text.
What I have tried
I have restarted HA, and cleared my browser cache.
HA logs contain no relevant entries
HA Container config/custom_components contains both HACS and Frigate files as expected.
I'm not sure where else to look.
Thanks

I have tried again using a different PC. This time the dialogue includes the text:
"MQTT is required for this integration"
I have a container running MQTT on my host and the main Frigate component (installed as above using the Add-On store) is able to connect to that instance.
I suspect that HA itself is not aware of the MQTT though. I will try to install the MQTT from the add-on store to see whether that helps.

I have installed the HASS MQTT add-on and configured it. I am now able to successfully add the Frigate integration.
I don't know why the text "MQTT is required for this integration" wasn't visible on the other PC but I would not have been unable to resolve the issue without it.
I don't think the docs mention requiring the HASS add-on MQTT so it might be worth making that explicit.
Thanks. I'll close this issue.


[Issue 1687] - adds manage ssl keys, url sig keys and uri signing keys menu items to…

… TP for a ds. always show these menu items even if not applicable to the ds. this is to satisfy ds requests where keys may have to be managed before the ds is actually changed.
plus, static dns entries for a ds doesn't work properly so removing that menu item.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1122/
Test PASSed.


Update 1275 Find Winner on a Tic Tac Toe Game - Change break to continue

Tic Tac Toe solution used break inside a loop when the first cell of the column or row was empty. I believe this will result in it skipping all other rows/columns when it reaches a null cell. Instead of using break I think it should be continue instead.
Tested locally and continue works for 3 vertical in the last column, where break fails to find the winner.

Thanks for the pull request. I'll merge it.


How to Add validation on dynamically added fragment editttext

I am working on an android app In which similar Fragments(each fragment containing some edit-texts) are added to activity pro-grammatically. I want to validate all fragment edit text data on activity button click event so that all data can be validated.How this can achieved?

I think you should add the validation (e.g. mAwesomeValidation.addValidation(...)) right after you add the fragment programmatically.

@rohitbhoite if there is no further problem, I'll close this ticket in 24 hours.  Thanks.

@thyrlian  Please excuse me for late reply.
FragmentTransaction fragmentTransaction = fm.beginTransaction();
fragmentTransaction.add(R.id.homework_template, frag, "fragment_one");
fragmentTransaction.commit();
This is how I am adding fragment from activity.
Multiple similar fragments can be added by user.
I want to validate all fragment data on button present on activity.Please help me regarding this

@myeduapp no problem.  I don't think there is any problem.  You just need to addValidation for all the input fields one by one after fragmentTransaction.commit();.  That's it.

mAwesomeValidation.addValidation((TextInputLayout) frag.getView().findViewById(R.id.til_homework_description),".+","Error");
I have above code after  fragmentTransaction.commit();
I am getting attempt to invoke virtual method findviewbyid on a null object reference error.

So this is nothing to do with the library.  It's because your frag.getView() is just null.
I suggest you to check your fragment's lifecycle calls, move the code to a place where the view is valid.  Also as a reference, to use this library properly with fragment, you need to do as mentioned in README:

It works perfectly with Fragment, but please pay attention to Fragment's lifecycle. You should set the validate() inside Fragment's onActivityCreated instead of onCreateView or any other early stage.

Hope it helps and good luck.

Right now my validation code is inside activity if I move it to the fragment level How can I validate  all fragment data on single button click ?

Actually you don't have to differentiate between activity and fragment.  This library doesn't care.  As long as you pass the correct view (not null object), it will do its job.  The only thing you need to pay attention is as I said, move the code to the correct lifecycle call place, so that the view object is not null.


GPL-677 BUG - Ongoing issues with failing batches

Describe the bug
It looks like there is confusion when failing a batch about whether a batch is actually failed as the ui seems to give conflicting answers. We are also getting a 401 error which is indicating to the users that the action has failed.
RT Ticket Number
If applicable
To Reproduce
Steps to reproduce the behaviour:

Go to batches page
Select a batch
select plate layout
pick by ul
select number e.g. 35
click on next step
you should see plate map for selected plate layout
click next step
you should see finish cherrypick page
click release batch
you should see released batch
SSR realises they have made a mistake
go to batch page
find offending batch
select batch
fail batch or items
select fail all
select failure reason
add a comment
See error 'the page you are looking for doesn't exist'
go to batch page which says 'batch released'
click on fail batch or items
each request says it is failed
click on request which says it has passed

... confusion reigns!

See error

Expected behaviour
Batch should say it is failed??
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Windows or Mac?
Browser Chrome, Firefox, Safari or other?
Browser version (use 'About' to look up)?

Additional context
checking the data:

state of batch is released
state of each request is passed

batch has a production state that is separate from state and gets set when the batch is failed BUT it should say it's failed.. it certainly used to

Yeah, batch states are a little confusing, I think the two states are an attempt to separate qc state from progress state, which makes sense, but its not entirely clear. I know that failing all requests in a a batch is supposed to update the state automatically.

And the 401 is weird, definitely didn't have that when I was testing things last time, although as that's an authentication error its possible that its either related to user permissions or redirects across domains resulting in invalid cookies.

Hmm, so not seeing a 401 locally, but did get a 404 on training...

Hmm, so training rendered the 404 for:
http://.../batches/77705/fail_items
Whereas locally I go redirected to:
http://.../batches/1/fail
As intended

If we choose to fail nothing, then we don't get a 404, although the flash is empty. (But flagged as a success)

I suspect we're raising an ActriveRecord::RecordNotFound somewhere, resulting in a 404.

Okay, looks like something odd going on judging by the exceptions I'm seeing logged in kibana.

Agh! So connecting to training from local, and attempting to reproduce and everything works okay. (Well, the state still displays wrong, but we don't show a 401/404)

Buh?! Okay, so it looks like we're creating a failure reason for the requests, but not actually failing them. Which in turn means we don't fail the batch.

So back on the 404, the logging is showing a proper redirect, but we seem to have another request being logged at the same time, which is generating a 50x:
Oct 13 10:04:25 sss1-training sequencescape[16106]: (thread-47435083772120) [13.17.0:training] FATAL -- : [17d9ddce-43de-4d21-ba69-8503eaa54603] ActionController::RoutingError (No route matches [GET] "/50x.html")

This then ends up as a 404 as 50x.html isn't present

Bingo. Turn on network logging in the browser and that 50x is a 502.

And the 502 is coming from nginx:
ubuntu@sslb-training-theta:/etc/nginx$ tail /var/log/nginx/error.log
2020/10/13 10:04:25 [error] 1583#1583: *320 upstream sent too big header while reading response header from upstream, client: ***, server: ***k, request: "POST /batches/77705/fail_items HTTP/1.1", upstream: "http://***/batches/77705/fail_items", host: "***", referrer: "http://training.sequencescape.psd.sanger.ac.uk/batches/77705/fail"

So while the cookie size is fine if the request is direct, passing it through nginx appears to be causing problems with overall header size.

So nginx buffers the headers, and the default buffer can be as small as 4kb, which is definitely too small for us here. (As that's out cookie alone) Can increase the buffer size or disable it completely

Cool. Increasing the buffer size in training works. Just added the following to nginx.conf (naughtily updating the file on the server)
proxy_buffer_size 8k;

Just working out the best way to add this in to the deployment process. As best I can tell we're using the default nginx.conf, and then include various files from conf.d. Ideally we'd keep the custom options in conf.d, but it didn't seem to like the http context here when I tried, so poking this further

So the failure looks all to be a bit complicated, as its all wrapped up in some of the ancient Event code.

So the failure looks all to be a bit complicated, as its all wrapped up in some of the ancient Event code.

Can we strip it out and refactor? This is proper technical debt. Ops would really like this fixed.

Yep, the event stuff is still quite heavily used, and we've even got lots of active requests hitting EventsController#create. So just a simple change to the actual state transition logic. Just want to run a few queries to scope out the changes in actual behaviour we can expect.

Two things I'm checking:

Frequency of pass and fail events on the same request. Currently the second transition will be ignored. This is probably a bug, but it'll be nice to know if we need to warn anyone.
Frequency with which the events get called on requests that aren't in a started state. (This is somewhat trickier to work out)

Scenario 1 is rare, last occurring in April 2019, where a request has a nts created fail event but is passed. Before that is 2015, where we have fail -> Pass, and that actually looks fine. We do have a large number of duplicate events, but that's fine.

Starting looking into 2 by working out how many requests has a state that doesn't match the most recent event. This is complicated by having other routes to update state, but should be a starting point. (I'd rather not look at the request_events table)

This is all looking sensible so far. A fair few of them, but all are either an incidence of this bug, or have comments explaining manual invervention.

Request failure behaviour now working, and status is being passed onto the batch, but not showing due to the multiple different fields for tracking state. We have:

state
production_state
qc_state

Production state is the one being updated, but state is the one getting shown. Need to document exactly what each field does.

All fixed up, just doing a final refactor pass


Monospace with \texttt instead of \tt

I'm having a problem with monospace. I'm not a latex expect, but when I try to compile a document with monospace I end up with an error.
Let's see how it is implemented:
$ echo "\`monospace\` _italic_ *bold*" | asciidoctor-latex -a header=no -

The result was:
{\tt monospace} \emph{italic} \textbf{bold}

I propose to change {\tt monospace} to \texttt{monospace} (works for me).
The \texttt is documented at https://en.wikibooks.org/wiki/LaTeX/Fonts

Thanks!  Will be able to look at it in about an hour.  Keep those bug reports coming!!

On Jun 24, 2015, at 10:27 AM, Eduardo de Santana Medeiros Alexandre<EMAIL_ADDRESS>wrote:
I'm having a problem with monospace. I'm not a latex expect, but when I try to compile a document with monospace I end up with an error.
Let's see how it is implemented:
$ echo "`monospace` italic bold" | asciidoctor-latex -a header=no -
The result was:
{\tt monospace} \emph{italic} \textbf{bold}
I propose to change {\tt monospace} to \texttt{monospace} (works for me).
The \texttt is documented at https://en.wikibooks.org/wiki/LaTeX/Fonts https://en.wikibooks.org/wiki/LaTeX/Fonts
—
Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/36.

Hi there!
I think that your difficulty has to do with the backlashes, not
with \tt or \textt per se.  The following works:
monospace italic bold => {\tt monospace} \emph{italic} \textbf{bold}
but this (for example)
\monospace italic bold =>{\tt \monospace} \emph{italic} \textbf{bold}
won’t work because for TeX, backslash has a special meaning.  That is
why you are getting errors.
If you have things
like \foo \bar in your source text, then you can do something like this:

\monospace is a macro
Use four dashes above and below.  This will be translated into valid tex.
Here we are using what is called a verbatim macro package for TeX.
Asciidoctor-LaTeX knows how to translate the above into valid TeX.
If you need it in-line, I will need to do a little work to add this feature.
Best regards,
Jim
http://noteshare.io http://noteshare.io/
http://home.noteshareblog.io http://home.noteshareblog.io/

On Jun 24, 2015, at 10:27 AM, Eduardo de Santana Medeiros Alexandre<EMAIL_ADDRESS>wrote:
I'm having a problem with monospace. I'm not a latex expect, but when I try to compile a document with monospace I end up with an error.
Let's see how it is implemented:
$ echo "`monospace` italic bold" | asciidoctor-latex -a header=no -
The result was:
{\tt monospace} \emph{italic} \textbf{bold}
I propose to change {\tt monospace} to \texttt{monospace} (works for me).
The \texttt is documented at https://en.wikibooks.org/wiki/LaTeX/Fonts https://en.wikibooks.org/wiki/LaTeX/Fonts
—
Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/36.

No, I put the backlash in the echo command because if I leave the ` it will be interpreted as a bash command:
$ echo "`monospace`"
monospace: command not found

OK, I agree that this works as stated - no errors. What is it that is giving you errors?
When I run {\tt whatever} and compare it to \texttt{whatever}, the outputs look the same to me.

On Jun 25, 2015, at 8:40 AM, Eduardo de Santana Medeiros Alexandre<EMAIL_ADDRESS>wrote:
No, I put the backlash in the echo command because if I leave the ` it will be interpreted as a bash command:
$ echo "monospace"
monospace: command not found
—
Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/36#issuecomment-115237545.

$ cat rascunho.adoc
== my Chapter

`monospace`

$ cat rascunho.adoc | asciidoctor-latex -b latex -d book -a header=no -a numbered -
\hypertarget{_my_chapter}{\chapter{my Chapter}}
{\tt monospace}

So I copy this text, and put inside an template with this packages:
\usepackage{lmodern}			% Usa a fonte Latin Modern
\usepackage[T1]{fontenc}		% Selecao de codigos de fonte.
\usepackage[utf8]{inputenc}		% Codificacao do documento (conversão automática dos acentos)
\usepackage{lastpage}			% Usado pela Ficha catalográfica
\usepackage{indentfirst}		% Indenta o primeiro parágrafo de cada seção.
\usepackage{color}				% Controle das cores
\usepackage{graphicx}			% Inclusão de gráficos
\usepackage{microtype} 			% para melhorias de justificação

When I compile it with pdflatex:
! Class memoir Error: Font command \tt is not supported.

I see now that asciidoc-latex was made to work with xelatex:
$ asciidoctor-latex -b latex rascunho.adoc
$ pdflatex rascunho.tex
(....)
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Fatal fontspec error: "cannot-use-pdftex"
!
! The fontspec package requires either XeTeX or LuaTeX to function.
!
!  See the fontspec documentation for further information.
!
! For immediate help type H <return>.
!...............................................

$ xelatex rascunho.tex
(...)
Output written on rascunho.pdf (1 page).

Since I was using with header=no, the produced code was made for xelatex', not working with pdflatex`.

I think that the {\tt} command is not inside of these packages.

When I change to use with texttt my tex compiles with pdflatex,

Here's the complete file:
https://gist.github.com/edusantana/341c947dcffa9da4c27d
The error:
! Class memoir Error: Font command \tt is not supported.

See the memoir class documentation for explanation.
Type  H <return>  for immediate help.
 ...

l.445 Testing {\tt
                   monospace}.
?
! Emergency stop.
 ...

l.445 Testing {\tt
                   monospace}.
!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on document.log.

When I change the \tt to \texttt it works.

The microfile that you wrote with the class article ( at #37 ) , worked. It compiled with tt and texttt, both became monospace. I will test with memoir class.

Yes, the problem is with the memoir class:
\documentclass[11pt, oneside]{memoir}
\begin{document}

{\tt monospace with tt}

\texttt{monospace with texttt}
\end{document}

This one doesn't compile.

I have tested how pandoc does it, it uses \texttt:
$ cat pandoc.md
`monospace with pandoc` *italic* **bold**
$ pandoc pandoc.md -t latex
\texttt{monospace with pandoc} \emph{italic} \textbf{bold}

Thanks, I’ll change to \textt later today

On Jun 26, 2015, at 7:34 AM, Eduardo de Santana Medeiros Alexandre<EMAIL_ADDRESS>wrote:
I have tested how pandoc http://pandoc.org/getting-started.html does it, it uses \texttt:
$ cat pandoc.md
monospace with pandoc italic bold
$ pandoc pandoc.md -t latex
\texttt{monospace with pandoc} \emph{italic} \textbf{bold}
—
Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/36#issuecomment-115652299.

I’ve  changed to \textt — could you
test?  I am having some system
problems and can’t be sure that all is OK
until I get them fixed.

On Jun 26, 2015, at 7:34 AM, Eduardo de Santana Medeiros Alexandre<EMAIL_ADDRESS>wrote:
I have tested how pandoc http://pandoc.org/getting-started.html does it, it uses \texttt:
$ cat pandoc.md
monospace with pandoc italic bold
$ pandoc pandoc.md -t latex
\texttt{monospace with pandoc} \emph{italic} \textbf{bold}
—
Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-latex/issues/36#issuecomment-115652299.

$ echo "\`monospace\` _italic_ *bold*" | asciidoctor-latex -a header=no -

the output was:
\textt{ monospace} \emph{italic} \textbf{bold}

I think there's an extra space: textt{ monospace} it should be -> textt{monospace}

Should be ok now -- no extra space.  Again, could you double check?
Thanks so much for bringing up this problem -- sorry it took so much back and forth.
Please let me know if there are further problems .. the converter is still beta software

It's okay now. thanks!
May I suggest put the number of the issue in the commit message? This way when can track it more easy...

For those led here by searching about the memoir package error regarding \tt (mentioned above), the memoir class does not define old font commands (LaTeX 2.09) by default. These commands can be activated by explicitly passing the class option oldfontcommands to memoir, as described in this answer.


Is it possible work with node ver 14.16.1 ?

yarn install v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "14.16.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

It should run without an issue, But I would recommend using nvm to choose another node version. A eslint downgrade should fix this.

ok, thanks.


Refactor Multiple Agent API

Refactor Thread, Messages, RunSteps, VectorStore, VectorStoreFile, VectorStoresFileBatches
Pending Agents and Files
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/ai-projects


Getting dependencies in Visual Studio community 2017

In current version of Visual Studio community 2017, the script that installs dependencies (get-deps.cmd) does not work. Installing Visual C++ 2015 build tools may resolve this issue.

WE currently do not support VS2017. This issue will be evaluated when it is determined support for VS2017 is needed.


Update index.md

Fixes #16847
@poke  please review
Internal review URL

@poke  thanks for your valuable feedback.  Long sentences don't MT (machine translate), so I shortened  your writing. Can you review my update?