Fixing AMF parsing

Problem Description
AMF ( https://en.wikipedia.org/wiki/Action_Message_Format ) parsing support vanished at some point in the early mitmproxy releases, and didn't come back. I'm planning to re-plug pyamf or some AMF lib in mitmproxy to decode AMF.

I found when it arrived in 2012 : https://github.com/mitmproxy/mitmproxy/pull/62
In 2017 it wasn't working https://discourse.mitmproxy.org/t/amf-support-not-working/437
We're in 2024 and it's not there :D

CONTRIBUTING says :

If you intend to work on a larger contribution to the project, please come talk to us first.

There we go :)
Proposal
I figure out how to plug some AMF lib (the python ones are pretty old, but might work and one of them has a nice C implementation, there's surely some lib for that in ruffle.rs but I'm no cross-language packaging expert, and the spec itself doesn't seem that overly complicated, so as a last resort I'll try to write one myself).
I've got some X-AMF traffic there, not sure I need an extensive dataset as long as I can plug an existing lib.
Alternatives
Not parsing AMF with mitmproxy.
Questions
Is there anything specific I should be aware of ? I'll follow the doc otherwise. Cheers !

Thank you for raising an issue before starting your work! 🍰
Generally happy to add AMF parsing, my only concern here is that I'd like to avoid adding a dependency on an additional library. In particular, I'm very strongly -1 on anything that involves file format parsing in C. Both from a memory safety perspective as well as a "needs a compiler to install" perspective. Is there maybe already an existing Kaitai Struct definition for AMF somewhere? Not sure how complex AMF is, but if this can be done with Kaitai this would be by far my preferred option. :)

Hey, status update: I managed to get some amf0 parsing and it works well against the https://github.com/sile/amf/tree/master/src/testdata dataset. Here's the Kaitai Struct YAML file:
amf0.v1.ksy.txt, (I couldn't find amf ksy files online, maybe I'm bad at searching) and here's what parsing amf0-ref-test.bin gives:

It's pretty verbose, maybe there are KS tricks to reduce the amount of layers.
I didn't have a chance yet to plug that in mitmproxy to observe my own intercepted data. I'm specifically wondering if it's raw amf0/amf3 objects or if they're packed in the custom amf-packet format. Because both could be used, and there's no way to tell amf-packet data from amf0/3 data without attempting to parse it. I guess I'll have to offer both, even if having amf-packet and amf as types feels superfluous, I don't foresee a viable alternative.
Are there examples of Kaitai Struct -parsed formats in mitmproxy I could borrow code from ?

Thanks for the update! Our Kaitai defs are in
https://github.com/mitmproxy/mitmproxy/tree/main/mitmproxy/contrib/kaitaistruct
,
https://github.com/search?q=repo%3Amitmproxy%2Fmitmproxy+kaitaistruct&type=code
should show usages. :)
On Wed, Mar 27, 2024, 20:46 6600024d @.***> wrote:

Hey, status update: I managed to get some amf0 parsing and it works well
against the https://github.com/sile/amf/tree/master/src/testdata dataset.
Here's the Kaitai Struct YAML file:
amf0.v1.ksy.txt
https://github.com/mitmproxy/mitmproxy/files/14780372/amf0.v1.ksy.txt,
(I couldn't find amf ksy files online, maybe I'm bad at searching) and
here's what parsing amf0-ref-test.bin gives:
image.png (view on web)
https://github.com/mitmproxy/mitmproxy/assets/164740436/3cf546c6-27dd-49c1-be0d-1bea4705de3f
It's pretty verbose, maybe there are KS tricks to reduce the amount of
layers.
I didn't have a chance yet to plug that in mitmproxy to observe my own
intercepted data. I'm specifically wondering if it's raw amf0/amf3 objects
or if they're packed in the custom amf-packet format. Because both could be
used, and there's no way to tell amf-packet data from amf0/3 data without
attempting to parse it. I guess I'll have to offer both, even if having
amf-packet and amf as types feels superfluous, I don't foresee a viable
alternative.
Are there examples of Kaitai Struct -parsed formats in mitmproxy I could
borrow code from ?
—
Reply to this email directly, view it on GitHub
https://github.com/mitmproxy/mitmproxy/issues/6753#issuecomment-2023837420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHY2PUKECCYN7FCSQTXV6DY2MHZNAVCNFSM6AAAAABFFTJC2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTHAZTONBSGA
.
You are receiving this because you commented.Message ID:
@.***>

Hey, status update:

amf0 : more or less OK. could be enhanced: boolean, undefined, null, references, times
amf-packet : OK (!) (or is it ? :D)
amf3 : just started, I'm struggling with the U29 integer format they invented, pretty much UTF-8-for-uint32. There will be the same possible enhancements as for amf0 on data types, and I'll also have to sort out some bitfield issues. (Wouldn't be fun if these bitfield flags were not applied to U29 integers, yay.)

I got some pointers from the peeps developing ruffle.rs, the flash runtime. My own dataset is amf-packet with headers packing amf0 objects which sometimes are amf3 objects. I've been pointed at some random flash games that do generate amf-packet data as well. Unless I see raw amf0 objects on the wire then the parsing root will be amf-packet.

Status update
I managed to implement the U29 format, but am stuck at amf3_object_type, and can't reasonably invest more energy & time into this initiative « at this time ».
Blockers

I couldn't get the meaning of the specification for amf3_object_type or the few implementations I could find. I tried reading sile/amf, ruffle-rs/rust-flash-lso and hydralabs/pyamf and still could not make sense of the amf3 object type, notably when compared to real-world data.
The resources I can invest in this are too scarce. Real life.  I guess I'll never know :shrug: :D.

Remaining work

Ideally, you just have to sort the amf3_object_type structure, possibly array and dictionary will require similar handling.
Then, plugging the spec in plugging it in mitmproxy might not be that hard. I don't know hehe.

Contribution so far

amf-packet : implemented
amf0 : implemented, and tested to some extent against the sile/amf dataset and some custom flash app.
Limitation: "null", "undefined" and other JavaScript-ish objects are not well handled by Kaitai Struct so we just skip them
Limitation: so far, there's no support for references, I'm not sure if it's possible (or worth it) to perform bookkeeping like that in Kaitai Struct.
I managed to sort out that u29 format, which isn't the vlq_base128 found in the Kaitai Struct standard set.

Enclosed .KSY file
Anyways, here's my amf.ksy file so far, I'm releasing it as public domain for whomever wants to finish tackling this down. I'd be very honored if anyone managed to reuse my work to some extent.
amf.ksy.txt
Thanks for mitmproxy, it really is a great tool I keep recommending anytime I get a chance.


Add redraw gap print to wgpu example

I think that if we measure anything we should be measuring milliseconds per frame, not frames per second. For arguments, see http://www.mvps.org/directx/articles/fps_versus_frame_time.htm and https://iliaskapouranis.com/2018/11/04/why-fps-is-a-bad-performance-metric/

Yeah, I was thinking about doing something similar.
At the moment I don't know how to ask wgpu when we have finished drawing the frame, which is unfortunate. I know this needs a lot of reworking, but winit is all a bit of a black box to me. I'm going to experiment with this a little bit.

I'm not planning on updating this further - there was talk of using https://github.com/khyperia/Clam/blob/clam5/src/fps_counter.rs in Discord, but currently the perfomance metrics are not very important; the maths in that fps counter look more optimised for giving a better approximation when sampled each frame when frame times are variable, but I would expect the current naïve implementation to be sufficient for the stable frame times our current shaders should be achieving.

Thanks for implementing this and putting in all the effort to make it nice, but it seeems that this probably doesn't add much value. I'll close this for now, but we can always revisit this and reopen it if someone wants to.


Incompatibility with "Mods Command"

Hello, I noticed that Floodgate-Fabric is incompatible with a mod called "Mods Command". Based on the nature of the mod, I'm assuming it checks for some information that Floodgate-Fabric doesn't have set, causing a crash.

The mod in question: https://modrinth.com/mod/mods-command
A crash log: https://mclo.gs/EGQ5iCM

Steps to reproduce:

Install Floodgate-Fabric, Fabric API, and Mods Command.
Attempt to launch client/server.

The mod "mods-command" is providing an older version of cloud, overriding the one shipped with floodgate-fabric - please ask them to update it!

Actually, nevermind - you're using 1.20.4 for which no Floodgate-fabric with an updated version of cloud exists (we were on 1.5 at that time, 2.0 is/was still in beta.
Unfortunately, there's no fix for this - 1.20.6 onwards are updated to use the latest version of cloud.


Popper dot improvements

Removes duplicate edges in #637

The commit de57376 addresses #633

The commit 8fe74bf addresses #632
Adds blue border color to workflow node

The commit 0f29655 address #634
Retains original spaces in workflow and action names

closing in favor of #655


[5.5] Request validate redirect back with out _token.

Laravel Version: 5.5.4
PHP Version: 7.1.8
Database Driver & Version: MySQL 5.7.18

Description:
In 5.5 they have $request->validate([...]); It will redirect back with errors and inputs.
But how to redirect back with $request->session()->regenerateToken() then except _token or  before redirect back.
Because when use $request->session()->regenerateToken() after  $request->validate([...]); it will error when make a new request.
Steps To Reproduce:
$request->validate([...]);

$request->session()->regenerateToken();

This is intentional. Only the fields that are validated are returned back from the validation. If you want all the fields (that are not validated) you can use $request->input() or any of the other methods.


Adding deserialization from torch saved weights

An initial idea for the design is:

Download weights from pre-hosted torchvision or timms URLs
Have common converters which maps layers between the two frameworks. eg: torch.nn.Linear to eqx.nn.Linear
Lastly, assembly of the weights can be performed by individual architectures.

Open to discussion!

torchvision pretrained support is now added!


Add red/yellow/green color codes for each student in the classroom

We would like to add a red/yellow/green label to each student on the dashboard page for the classroom.  The red-zone students are least enaged; green-zone students are most engaged.
TODO: We will post a design mock-up showing what the new UI should look like with the color codes.  Or, if any contributors want to propose a mock-up, please do so.
Level 2: consider adding filtering functionality so that the Teacher can quickly select the students who are in the red-zone or yellow/green zones.

issue #172 mock-up.pdf
Hi Utsab, here I uploaded my mock-up for this issue.


Updating gcs interfaces, and bug fixes to augmentation

on non-AI platform machines GOOGLE_APPLICATION_CREDENTIALS need to be set to access google cloud storage


ONVIFError: Unknown error: <urlopen error [Errno 113] No route to host>

Hello Guys, I get this error when I am trying to run the GetProfiles funtion:
Traceback (most recent call last):

  File "<ipython-input-11-46373cee5b14>", line 1, in <module>
    media_profile = media.GetProfiles()[0]

  File "/usr/local/lib/python2.7/dist-packages/onvif-0.2.0-py2.7.egg/onvif/client.py", line 32, in wrapped
    raise ONVIFError(err)

ONVIFError: Unknown error: <urlopen error [Errno 113] No route to host>

I am using python2.7, the code is :
from onvif import ONVIFCamera
mycam = ONVIFCamera('<IP_ADDRESS>', 80, 'admin', '12345')
media = mycam.create_media_service()
ptz = mycam.create_ptz_service()
media_profile = media.GetProfiles()[0];

Any help will be appreciated, thanks.

That most likely means that the camera isn't at that address.

That most likely means that the camera isn't at that address.

Thank you very much. The problem is solved. It is the network problem.
After run following command:
from onvif import ONVIFCamera
mycam = ONVIFCamera('<IP_ADDRESS>', 80, 'admin', '12345')
mycam.devicemgmt.GetHostname()

the output is:
(HostnameInformation){
   FromDHCP = False
   Name = "Hikvision"
 }

so the address is correct.
Then run :
media = mycam.create_media_service()
ptz = mycam.create_ptz_service()
media_profile = media.GetProfiles()[0]

it output :
Traceback (most recent call last):

  File "<ipython-input-7-46373cee5b14>", line 1, in <module>
    media_profile = media.GetProfiles()[0]

  File "/usr/local/lib/python2.7/dist-packages/onvif-0.2.0-py2.7.egg/onvif/client.py", line 32, in wrapped
    raise ONVIFError(err)

ONVIFError: Unknown error: <urlopen error timed out>

then I put the camera and my computer in the same router, run the code once again (PS: change the IP and port ), no error, it succeed.
Thanks @ssieb


GitHub Pages proofs

Service name
GitHub Pages
Proof
GitHub uses virtual hosting identical to other cloud services. The site needs to be specified explicitly in domain settings. Step-by-step process:

Go to new repository page
Set Repository name to canonical domain name (i.e., {something}.github.io from CNAME record)
Click Create repository
Push content using git to a newly created repo. GitHub itself provides the steps to achieve it
Switch to Settings tab
In GitHub Pages section choose master branch as source
Click Save
After saving, set Custom domain to source domain name (i.e., the domain name which you want to take over)
Click Save

For screenshots, please refer to https://0xpatrik.com/takeover-proofs/.
To verify:
http -b GET http://{DOMAIN NAME} | grep -F -q "There isn't a GitHub Pages site here." && echo "Subdomain takeover may be possible" || echo "Subdomain takeover is not possible"

(Note: DOMAIN NAME has to be the affected domain, not the github.io page itself. This is due to Host header forwarding which affects the HTTP response)
Documentation
There is only one format of GitHub Pages domains:

*.github.io

please note that having CNAME to github.io itself can also lead to subdomain takeover.

Official GitHub Pages docs: https://help.github.com/articles/using-a-custom-domain-with-github-pages/

Closing as now available on main readme.

Not able to takeover a subdomain pointing to GitHub.io. Error with CNAME is already taken.
snapshot attached.
Is GitHub takeover still working for anyone?

Not able to takeover a subdomain pointing to GitHub.io. Error with CNAME is already taken.
snapshot attached.
Is GitHub takeover still working for anyone?

Facing the same issue.

Is it possible to takeover githubapp.com subdomains with github.io CNAME?

Hi @sumgr0
I'm not quite sure but you should be able to, because it's not allowed only in case of github.io, github.com, or github.page as per official error I'm currently getting.

There isn't any such notice regarding githubapp.com. So, I suppose you should be able to takeover if it's available.
For more you can head over to https://docs.github.com/articles/setting-up-your-pages-site-repository/

Hi @EdOverflow
I am trying to takeover subdomain .github.io but when I create a repo and try to serve it via the Github Pages, I get a URL like netanmangal.github.io/.
Github has started to appending the username to the github.io/
I have done something wrong or I think github pages are no longer vulnerable unless the user/organization have totally deleted their account.

Hi @EdOverflow
I am trying to takeover subdomain .github.io but when I create a repo and try to serve it via the Github Pages, I get a URL like netanmangal.github.io/.
Github has started to appending the username to the github.io/
I have done something wrong or I think github pages are no longer vulnerable unless the user/organization have totally deleted their account.

CNAME already taken error occurs in once already created repo and attached cname, so as my understanding *.github.io is not available for takeover.
https://github.community/t/the-cname-is-already-taken/149785

anything.github.io   like this github account can we takeover or not

anything.github.io   like this github account can we takeover or not  ?

I was still able to takeover a domain

Still works. +1
Looks like it's kind of conditional because it can say that the domain is claimed

I was still able to takeover a domain

how you can takeover yet I have some of the vulnerable URLs, if you can help me..

There is a new beta feature, every custom domain need to be verified. So Github is no more vulnerable.

https://docs.github.com/en/enterprise-cloud@latest/organizations/managing-organization-settings/verifying-or-approving-a-domain-for-your-organization

@akincibor As mentioned, I ran into this specific issue where it required me to verify the domain by inserting a domain txt entry for verification on my account before I could add the custom domain to a repo.
Do we know if this is always the case for subdomain takeovers via github.io, or only specific domains with a feature enabled?

I've experienced the same with Github takeovers in the last couple of days. Looks like github has implemented it across the board.

@akincibor As mentioned, I ran into this specific issue where it required me to verify the domain by inserting a domain txt entry for verification on my account before I could add the custom domain to a repo.
Do we know if this is always the case for subdomain takeovers via github.io, or only specific domains with a feature enabled?

I found a subdomain pointing to xyz.github.io,  and it is vulnerable, but when trying to set it as the vulnerable subdomain as the  custom domain it asks to insert a txt entry for verification.
Is there any way to takeover such a domain?

@akincibor As mentioned, I ran into this specific issue where it required me to verify the domain by inserting a domain txt entry for verification on my account before I could add the custom domain to a repo.
Do we know if this is always the case for subdomain takeovers via github.io, or only specific domains with a feature enabled?

I found a subdomain pointing to xyz.github.io, and it is vulnerable, but when trying to set the vulnerable subdomain as the custom domain it asks to insert a txt entry for verification. Is there any way to takeover such a domain?

Then, it's not vulnerable.

i found a vulnerable xx.github.io subdmain but when i try to add the domain to a new repository, i get this message
The custom domain xxxxx.domain.com is already taken.
any solution ?

:warning::warning: GitHub's pages are now secure and no longer vulnerable. :warning::warning:
GitHub has implemented DNS verification to confirm the legitimacy of domains.

⚠⚠ GitHub's pages are now secure and no longer vulnerable. ⚠⚠ GitHub has implemented DNS verification to confirm the legitimacy of domains.

This does not apply to retrospective custom domains, right?

I thought Github was no longer vulnerable to STO but actually I managed to take a subdomain.

I thought Github was no longer vulnerable to STO but actually I managed to take a subdomain.

How?

What if there is a 404 no pages site here error, but the account that owns it still exists? like if example30.github.io would 404, but the example30 account still existed, would it be vulnerable?

I confirm that the vulnerability still exists, at least for domains without domain verification. Example: turakhia.ucsd.edu

You must verify your domain REDACTED.com before being able to use it. Check out https://docs.github.com/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages for more information.

Is it safe now?

Confirmed, still be vuln.

You must verify your domain dev-test.***** before you can use it. Check out https://docs.github.com/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages for more information.


No matching export error during build

Hello, first off thanks for your work on this adapter! However, I wanted to bring the following issue to your attention.
Steps to reproduce:

We created a brand new SvelteKit project this morning
Created a basic wrapping layout (for nav/styles) and added a second "about" us route
Followed your setup instructions in your README.md

I've shared the repo publicly if you want to pull and test directly:
https://github.com/Brain-Bones/bb-svelte-example
The issue:
When we npm run build we receive the following errors and are unsure how to proceed.
❯ npm run build

><EMAIL_ADDRESS>build /Users/chris/Development/prototypes/bb-website/bb-svelte-example
> svelte-kit build

vite v2.8.5 building for production...
✓ 14 modules transformed.
.svelte-kit/output/client/_app/manifest.json                       1.35 KiB
.svelte-kit/output/client/_app/pages/__layout.svelte-240b0057.js   1.57 KiB / gzip: 0.84 KiB
.svelte-kit/output/client/_app/error.svelte-7f250a32.js            1.56 KiB / gzip: 0.75 KiB
.svelte-kit/output/client/_app/pages/index.svelte-d976cce2.js      0.56 KiB / gzip: 0.36 KiB
.svelte-kit/output/client/_app/pages/about.svelte-7594c2ed.js      0.54 KiB / gzip: 0.36 KiB
.svelte-kit/output/client/_app/chunks/vendor-f8218414.js           7.29 KiB / gzip: 3.00 KiB
.svelte-kit/output/client/_app/start-4b5c06b5.js                   23.55 KiB / gzip: 8.03 KiB
vite v2.8.5 building SSR bundle for production...
✓ 12 modules transformed.
.svelte-kit/output/server/manifest.json                      1.03 KiB
.svelte-kit/output/server/index.js                           64.07 KiB
.svelte-kit/output/server/entries/pages/__layout.svelte.js   0.57 KiB
.svelte-kit/output/server/entries/pages/error.svelte.js      0.72 KiB
.svelte-kit/output/server/entries/pages/index.svelte.js      0.25 KiB
.svelte-kit/output/server/entries/pages/about.svelte.js      0.24 KiB
.svelte-kit/output/server/chunks/index-2dc61825.js           2.29 KiB

Run npm run preview to preview your production build locally.

> Using adapter-serverless
 > build/index.js:637:14: warning: This dynamic import will not be bundled because the argument is not a string literal (use "import().catch()" to silence this warning)
    637 │   csp_ready = import(name).then((crypto2) => {
        ╵               ~~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

 > build/server/shims.js:1:35: error: No matching export in<EMAIL_ADDRESS>for import "Headers"
    1 │ ...t { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                                  ~~~~~~~

 > build/server/shims.js:1:26: error: No matching export in<EMAIL_ADDRESS>for import "Request"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                           ~~~~~~~

 > build/server/shims.js:1:16: error: No matching export in<EMAIL_ADDRESS>for import "Response"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵                 ~~~~~~~~

 > build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
    1 │ export { fetch, Response, Request, Headers } from<EMAIL_ADDRESS>      ╵          ~~~~~

> Build failed with 56 errors:
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
...
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
build/server/shims.js:1:9: error: No matching export in<EMAIL_ADDRESS>for import "fetch"
...
    at failureErrorWithLog (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:1275:15)
    at buildResponseToResult (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:964:32)
    at /Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:1057:20
    at /Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:576:9
    at handleIncomingPacket (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:665:9)
    at readFromStdout (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:543:7)
    at runServiceSync (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:1591:3)
    at Object.buildSync (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/esbuild/lib/main.js:1407:3)
    at adapt (/Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/@yarbsemaj/adapter-lambda/index.js:51:15)
    at adapt (file:///Users/chris/Development/prototypes/bb-website/bb-svelte-example/node_modules/@sveltejs/kit/dist/chunks/index5.js:890:8)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `svelte-kit build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/chris/.npm/_logs/2022-02-28T19_15_50_865Z-debug.log
❯ code .
❯
❯ git pull
Already up to date.

Hi @endigo9740 Thank-you for taking an interest in my project. It seems since the last release of the adapter and now, the svelte team have some changes to the way there fetch Fetch polyfill works, to get around this i have just published a new package, v0.5.1 that moves to using node-fetch to provide the fetch shims. I have tested this on your repo and the build looks to have passed.

I have also done a full redeploy on my test site and that looks to be working as well, could you let me know if this has fixed your issue?
Thanks James

James, thanks for the quick turnaround on this! I can confirm the same results here. This should help us progress on our side.
FYI I'm also seeing the "dynamic import" warning per your screenshot. Is that anything we should worry about? Strangely enough I don't even see an index located at build/index.js as indicated by the message

Thanks again! Chris

@endigo9740 I see that error too on my test site and as far as i can see it runs as expected without issues.
That file is a build artifact and is cleared down one the build is finished, hence why you can't find it.

Gotcha. That's what I assumed but wasn't sure.
So far we're making progress. We attempted our first deployment this morning, but are unfortunately seeing a couple issues. Not sure if you can help debug this, but here's going on...
The build succeeds, however there appears to be a problem with the serverless script. It created some of the assets on AWS, but fails on an S3 error. It says our bucket dev-sveltekit-app-static-assets already exists, but it does not.
Users-Mac-mini:bb-svelte-example user$ sls deploy --aws-profile brainandbones
Running "serverless" from node_modules
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Excluding development dependencies...
Serverless: Updated Lambda assume role policy to allow Lambda@Edge to assume the role
Serverless: Added "origin-request" Lambda@Edge association for version "CfLambdaLambdaVersion9cWaXW0myqZha8ftDFaVxZgM1bKdK1D9ZgCrMisSwtU" to distribution "WebsiteDistribution"
Serverless: Creating Stack...
Serverless: Checking Stack create progress...
........
Serverless: Stack create finished...
Serverless: Ensuring that deployment bucket exists
Serverless: Uploading CloudFormation file to S3...
Serverless: Uploading artifacts...
Serverless: Uploading service svelte.zip file to S3 (68.81 kB)...
Serverless: Uploading service cfLambda.zip file to S3 (68.81 kB)...
Serverless: Validating template...
Serverless: Updating Stack...
Serverless: Checking Stack update progress...
............
Serverless: Operation failed!
Serverless: View the full error output: https://us-east-2.console.aws.amazon.com/cloudformation/home?region=us-east-2#/stack/detail?stackId=arn%3Aaws%3Acloudformation%3Aus-east-2%3A437799694342%3Astack%2Fsveltekit-app-dev%2F3969c860-9975-11ec-b5d2-066ce8a54be0

 Serverless Error ----------------------------------------

  An error occurred: StaticAssets - dev-sveltekit-app-static-assets already exists.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              14.17.6
     Framework Version:         2.72.3 (local)
     Plugin Version:            5.5.4
     SDK Version:               4.3.1
     Components Version:        3.18.2

Users-Mac-mini:bb-svelte-example user$

FYI, the only modification we made to the serverless script itself was switching the region from us-east-1 to us-east-2.
We also noticed that the sls deploy seems to have produced multiple entries for the dev-sveltekit-app-static-assets S3 bucket in the serverless-state.json file.
We're new to the Serverless Framework and unsure if this is normal. Perhaps this is intended as a history file?

Hi @endigo9740, S3 bucket names are global as per Amazons docs

An Amazon S3 bucket name is globally unique, and the namespace is shared by all AWS accounts. This means that after a bucket is created, the name of that bucket cannot be used by another AWS account in any AWS Region until the bucket is deleted.

My guess is that bucket name has already been taken somewhere else,  by someone else. You can change the name of your bucket by renaming the service to something more unique, this is the top line of your serverless.yml
service: 'sveltekit-app'

Furthermore, it looks like you are trying to deploy to us-east-2, unfortunately. You have to deploy to us-east-1 if you want to use the provided serverless.yml file. This is because lambda at edge functions have to be deployed in us-east-1 and as far as I can see there is no way to have a cloud formation stack deploy resources to 2 different regions.
You could very well have 2 different stacks created by two different serverless.yml files one deploying your main app, S3 bucket and cloudfront to whatever region you want and the other deploying the edge lambda to us-east-1 and attaching it to the cloudfront distribution.

James, seriously thank you for all the help here. Both responses make total sense. We were not aware of the globally unique names. We were aware of some AWS services being region locked, but not specifically that this would be.
Also, please let me know if you have a Patreon, Github tips, or similar available! Me and my company plan to utilize your adapter for a number of applications going forward and I would love to help provide some support your way. You know, other creating issues like this and asking a ton of questions! :)
Thanks again, Chris

Sorry but we've run into one more road bump. We've updating per your guidance above, but we've experience this error:
An error occurred: StaticAssets - A conflicting conditional operation is currently in progress against this resource. Please try again. (Service: Amazon S3; Status Code: 409; Error Code: OperationAborted; Request ID: BDEG9CGY1B9PTHMC; S3 Extended Request ID: 0010mFSbN/+/HdMMUBiI4Hdo6+c99Nl8QaexHtLEsNKgCjd6qQaUOqGeWYeBND9aeSzlZwTxC1M=; Proxy: null).

It sounds like a conflict between two CloudFormation processes that Serverless Framework has triggered. Not sure if that's anything you can help resolve, but just wanted to share just in case!
Users-Mac-mini:bb-svelte-example user$ sls deploy --aws-profile brainandbones
Running "serverless" from node_modules
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Excluding development dependencies...
Serverless: Updated Lambda assume role policy to allow Lambda@Edge to assume the role
Serverless: Added "origin-request" Lambda@Edge association for version "(scrubbed)" to distribution "WebsiteDistribution"
Serverless: Creating Stack...
Serverless: Checking Stack create progress...
........
Serverless: Stack create finished...
Serverless: Ensuring that deployment bucket exists
Serverless: Uploading CloudFormation file to S3...
Serverless: Uploading artifacts...
Serverless: Uploading service svelte.zip file to S3 (68.81 kB)...
Serverless: Uploading service cfLambda.zip file to S3 (68.81 kB)...
Serverless: Validating template...
Serverless: Updating Stack...
Serverless: Checking Stack update progress...
..............................................
Serverless: Operation failed!
Serverless: View the full error output: https://us-east-1.console.aws.amazon.com/cloudformation/home?region=us-east-1#/stack/detail?(scrubbed)

 Serverless Error ----------------------------------------

  An error occurred: StaticAssets - A conflicting conditional operation is currently in progress against this resource. Please try again. (Service: Amazon S3; Status Code: 409; Error Code: OperationAborted; Request ID: BDEG9CGY1B9PTHMC; S3 Extended Request ID: 0010mFSbN/+/HdMMUBiI4Hdo6+c99Nl8QaexHtLEsNKgCjd6qQaUOqGeWYeBND9aeSzlZwTxC1M=; Proxy: null).

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              14.17.6
     Framework Version:         2.72.3 (local)
     Plugin Version:            5.5.4
     SDK Version:               4.3.1
     Components Version:        3.18.2

Thanks for the offer of @endigo9740 support, but i'm happy just doing this a hobby outside of my full time dev job. I built this mainly because I wanted it, buts its great other people can use it too.
With regards for using sveltekit for anything commercial, Id maybe give it a bit longer to bake, they are still making breaking changes several times a month, not just to the adapter API but to other key bits of the framework as well, iv had to refactor my small test site to keep it working with the latest version of the framework.
Iv encountered this error before, was it possible that a bucket with that name existed before, and you recently deleted it, Iv just deployed the example svelte app from scratch and have not seen this issue, and when I have seen it in the past, it's always been because i've recently deleted a bucket with the same name

Well I appreciate the help all the same.
I agree with your sentiment. We're testing the waters right now with a smaller scale app. Seeing what does and does not work. Then we'll make a decision for how we want to proceed long term. We've had great success building a SvelteKit app for production using the official static site adapter, built in "SPA mode", hosted using S3+Cloudfront. We were just wanting to kick the tires on SSR though.
Per the error, we had actually planned to give it some time and try again in case it was something like that. Ok, that helpful. We'll probably give this a bit more time then look at alternative solutions. I think you've more than satisfied the original issue raised, so I'm going to go ahead and close this out. Thanks again for the help!


Cozy Homes My properties - Solo Task [2pts]

This page should allow the user to display his properties:

The user should see his properties
The user should be able to Modify or delete properties


Meta: Update ts-node

Follow-up of https://github.com/refined-github/refined-github/commit/fb7726a2335204d1cd33721b32b6e7b284c7397b#commitcomment-58518052

I tried about 10 times.
The only way I got it to work was to remove module from the package.json
But then AVA failed..


chore: add implicit BorshSchema derive for store::UnorderedMap

checked against test_unord_map_contract
• Building contract
 │    Compiling test_contract v0.1.0 (/home/user/Documents/code/test_contract)
 │ warning: unused import: `log`
 │  --> src/lib.rs:1:16
 │   |
 │ 1 | use near_sdk::{log, near};
 │   |                ^^^
 │   |
 │   = note: `#[warn(unused_imports)]` on by default
 │
 │ warning: use of deprecated struct `near_sdk::store::UnorderedMap`: Suboptimal iteration performance. See performance considerations doc for details.
 │  --> src/lib.rs:5:33
 │   |
 │ 5 |     greetings: near_sdk::store::UnorderedMap<String, String>,
 │   |                                 ^^^^^^^^^^^^
 │   |
 │   = note: `#[warn(deprecated)]` on by default
 │
 │ warning: use of deprecated struct `near_sdk::store::UnorderedMap`: Suboptimal iteration performance. See performance considerations doc for details.
 │   --> src/lib.rs:11:41
 │    |
 │ 11 |             greetings: near_sdk::store::UnorderedMap::new(b"g"),
 │    |                                         ^^^^^^^^^^^^
 │
 │ warning: `test_contract` (lib) generated 3 warnings (run `cargo fix --lib -p test_contract` to apply 1 suggestion)
 │     Finished `release` profile [optimized] target(s) in 0.31s
✓ Contract successfully built! (in CARGO_NEAR_BUILD_ENVIRONMENT=host)

this line wasn't proxying
from {}__NEAR_SCHEMA_PROXY to the BorshSchema::declaration() of type being derived, but replacing with its own implementation instead.
the change of schema of UnorderedMap<NoSchemaStruct, NoSchemaStruct> in added test is from
# before
{
    "()": Primitive(
        0,
    ),
    "FreeList": Struct {
        fields: NamedFields(
            [
                (
                    "first_free",
                    "Option<FreeListIndex>",
                ),
                (
                    "occupied_count",
                    "u32",
                ),
                (
                    "elements",
                    "Vector < T >",
                ),
            ],
        ),
    },
    "FreeListIndex": Struct {
        fields: UnnamedFields(
            [
                "u32",
            ],
        ),
    },
    "IndexMap": Struct {
        fields: NamedFields(
            [
                (
                    "prefix",
                    "Vec<u8>",
                ),
            ],
        ),
    },
    "LookupMap": Struct {
        fields: NamedFields(
            [
                (
                    "prefix",
                    "Vec<u8>",
                ),
            ],
        ),
    },
    "Option<FreeListIndex>": Enum {
        tag_width: 1,
        variants: [
            (
                0,
                "None",
                "()",
            ),
            (
                1,
                "Some",
                "FreeListIndex",
            ),
        ],
    },
    "UnorderedMap": Struct {
        fields: NamedFields(
            [
                (
                    "keys",
                    "FreeList < T >",
                ),
                (
                    "values",
                    "LookupMap",
                ),
            ],
        ),
    },
    "Vec<u8>": Sequence {
        length_width: 4,
        length_range: 0..=4294967295,
        elements: "u8",
    },
    "Vector": Struct {
        fields: NamedFields(
            [
                (
                    "len",
                    "u32",
                ),
                (
                    "values",
                    "IndexMap",
                ),
            ],
        ),
    },
    "u32": Primitive(
        4,
    ),
    "u8": Primitive(
        1,
    ),
}

to
# after
{
    "()": Primitive(
        0,
    ),
    "FreeList": Struct {
        fields: NamedFields(
            [
                (
                    "first_free",
                    "Option<FreeListIndex>",
                ),
                (
                    "occupied_count",
                    "u32",
                ),
                (
                    "elements",
                    "Vector",
                ),
            ],
        ),
    },
    "FreeListIndex": Struct {
        fields: UnnamedFields(
            [
                "u32",
            ],
        ),
    },
    "IndexMap": Struct {
        fields: NamedFields(
            [
                (
                    "prefix",
                    "Vec<u8>",
                ),
            ],
        ),
    },
    "LookupMap": Struct {
        fields: NamedFields(
            [
                (
                    "prefix",
                    "Vec<u8>",
                ),
            ],
        ),
    },
    "Option<FreeListIndex>": Enum {
        tag_width: 1,
        variants: [
            (
                0,
                "None",
                "()",
            ),
            (
                1,
                "Some",
                "FreeListIndex",
            ),
        ],
    },
    "UnorderedMap": Struct {
        fields: NamedFields(
            [
                (
                    "keys",
                    "FreeList",
                ),
                (
                    "values",
                    "LookupMap",
                ),
            ],
        ),
    },
    "Vec<u8>": Sequence {
        length_width: 4,
        length_range: 0..=4294967295,
        elements: "u8",
    },
    "Vector": Struct {
        fields: NamedFields(
            [
                (
                    "len",
                    "u32",
                ),
                (
                    "values",
                    "IndexMap",
                ),
            ],
        ),
    },
    "u32": Primitive(
        4,
    ),
    "u8": Primitive(
        1,
    ),
}

this test

is still around in https://github.com/near/near-sdk-rs/actions/runs/9700288636/job/26771329531

newly added test can be found in https://github.com/near/near-sdk-rs/actions/runs/9700288636/job/26771331115  too


add avakong logo

thank you tj

Please checksum an address

done, checksum fixed

you guys rock, thank you


cart.json issue?

Having a cart.json issue that shows up on every project. Any idea how to solve or get rid of it?
11:54:29 [WARN] [router] A getStaticPaths() route pattern was matched, but no matching static path was found for requested path /cart.json.
Possible dynamic routes being matched: src/pages/[...blog]/[category]/[...page].astro, src/pages/[...blog]/[tag]/[...page].astro, src/pages/[...blog]/[...page].astro, src/pages/[...blog]/index.astro.
11:54:29 [404] /cart.json 6ms

Hello @sunitgvaswani.
To try to help you resolve this error, you have to give me more details about your repo because the AstroWind template, if you install it from scratch, does not have any url or cart.json file
I'm going to close this issue until I have more information.
Thank you


Add citation button to the extension

Previous commit used to provide both with summarize feature, now make the features separate, so user can choose what they need.

Got the appropriate icon image and fixed this issue with f4418815cc3a689b4ae83a2150f9ffd2d1ac0e3f


Azure Static Web App Task - output_location is RELATIVE to app_location, documentation should reflect that

[Enter feedback here]
Both in the yml snippet and in the explanation for all arguments, the output_location argument needs the remark that it is RELATIVE to the app_location folder.
output_location    Output location | (Optional) String. Directory location of the compiled application code after building. Specify this location _relative_ to the 'app_location'.

This has cost me 1,5 hours and countless pipeline runs today to figure that out. My app does not live in the root of the repo, for various reasons, and it was hard figuring out how to adapt the expample based on the explanation in the docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 90d9a39d-b739-c778-4147-4026fc646ed6
Version Independent ID: 90d9a39d-b739-c778-4147-4026fc646ed6
Content: Azure Static Web App task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/azure-static-web-app.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

+1

@Jawz84 -- Jos, thank you for your feedback, and apologies for the delay in responding.
@steved0x -- Steve, please review this update in private PR 307.

We'll get this updated. In the YAML Syntax block, the comments reflect the name of that task input from the task designer (so it gets the value from the task source code there) so they aren't editable (unless they get edited in the task itself), but the task input description is editable, so this has been updated there.

We'll put a note in the remarks as well to really call it out.

@Jawz84 To confirm, output_location is relative to app_location and not workingDirectory?  I want to make sure we have this correct. I am heading over to the task to check it out further, but that sounds like a possible bug in the task (unless I am misunderstanding).

I'd positively like to help but this is long ago for me. From memory: I believe it's not so much the task that's at fault, but the docs.
Thank you for taking a good look at this, appreciate it!


A flag to ignore order

Some XML formats don't care about the order of the nodes in a subnode. A flag to skip reordering in one node might be useful for some formats. Comment here if you need this (because if no one actually need it, it won't happen).

I ran across this problem in a project of mine, where I was comparing musical scores with xmldiff. I didn't care about the order of layers within a bar, for example, but did care about the order of bars within a piece and the order of notes and rests within a bar.
I ended up using xmldiff anyway, however the output of the comparison would be much cleaner with the ability to ignore order for certain node types.

Is this an active request at the moment ?

If you mean if somebody is actively working on it, to my knowledge no.


If not running in main thread, create & set a new event loop.

When running TikTokAPI-Python in a subthread, I encountered an error:
RuntimeError: There is no current event loop in thread 'ThreadPoolExecutor-0_0'.

This RuntimeError does not occur when I use TikTokAPI-Python directly in a script (i.e. in the main python thread), but it does occur when calling TikTokAPI-Python from another (multithreaded) application. As far as I can see, if not running in the main thread, it's necessary to create & set a new event loop.
My proposed solution should not alter anything if running in the main thread, but avoid trouble otherwise.

You can also use https://github.com/erdewit/nest_asyncio
import nest_asyncio
nest_asyncio.apply()


Summary: Removes unused type that conflicts with HTTPoison.Base that is used above & fixes warning

Details
While attempting a minor upgrade of deps in project that uses this library a compile error was encounted that stated:
== Compilation error in file lib/forcex/api/http.ex ==
** (CompileError) lib/forcex/api/http.ex:14: type method/0 is already defined

It was discoved that the source of the conflict was the use HTTPoison.Base on line 8 in the same file. Removing line 14, it was unused anyway, resolves this compile error.
Review Checklists
Author

[ ] Squashed & Rebased
[ ] Commit message(s) conform to template (Summary, Details, Tracker)
[ ] No browser warnings/errors
[ ] Ran bin/qa

Reviewer

[ ] Readable
[ ] Tests adequately cover implementation
[ ] Backwards Compatible (Data, UI)
[ ] No junk (Comments, Typos, Test Focus, Debug Statements)
[ ] Components are divided well

👍 lgtm


Takes too long to load 1000+ contacts

When I tested with 200 to 300 contacts, it's not slow to get all contacts with properties, but when a device has 1000+ contacts, It takes **1 to 2 minutes** to get all.

Device: Samsung J2 Prime
Ram:
Os: Marshmallow
Contacts: 20,000
I've tested with this fake 20,000 contacts vcf file, it took 16 mins : 986 secs to load, and tested fast_contacts plugin, with the same 20,000 contacts. 12 secs.
Just sharing to find what makes that plugin load so fast

The first reason is that flutter_contacts allows you to either load every contact's display name + ID, but nothing else, which should be very fast, or to load ALL the properties (excluding or including photos / thumbnails / starred status at the moment), which takes longer because of all the projections.
The second reason is that flutter_contacts was written with ergonomics as guiding principle and not performance, since most people don't have 20,000 contacts. Of course if there are best practices fast_contacts is using that improve performance, such as using ThreadPoolExecutor on Android to parallelize reads, then it would definitely make sense to do it in flutter_contacts too. I just haven't gotten to prioritize it, but will keep it in mind for future improvements. PRs are always welcome :)


FS: add hover effect to pool and solo staking home buttons

I am not agreed with button shapes, rather to see them as CTA texts

Updated!


Fixed some bugs abount cinder

What this PR does / why we need it:
Fixed some bugs abount cinder
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 43.948% when pulling afd2a193411d464130e55d0f8e4d7856e755ed61 on xxwjj:cinder_bugs into 14f843686391a81c96dda50b308c560f5a0e0d80 on opensds:development.

Coverage remained the same at 43.948% when pulling afd2a193411d464130e55d0f8e4d7856e755ed61 on xxwjj:cinder_bugs into 14f843686391a81c96dda50b308c560f5a0e0d80 on opensds:development.

Coverage remained the same at 43.948% when pulling afd2a193411d464130e55d0f8e4d7856e755ed61 on xxwjj:cinder_bugs into 14f843686391a81c96dda50b308c560f5a0e0d80 on opensds:development.

Coverage remained the same at 43.948% when pulling afd2a193411d464130e55d0f8e4d7856e755ed61 on xxwjj:cinder_bugs into 14f843686391a81c96dda50b308c560f5a0e0d80 on opensds:development.


Is an update to 1.20 planned?

Are there plans to continue the development of this mod?

hopefully

yeah, best end mod out there, followed by nullscape imo

well nullscape aint got new blocks and mobs now does it

I didn’t say it did…


需要在两个GridLayout之间移动GridItem，请问有什么解决办法？

尝试过在GridItem移动事件中，删除源GridLayout中的layout数组中的item，再插入到目标GridLayout的layout数组中，但这样会引发handleDrag中的异常：
  if (!mouseInGrid) {
    let draggingIndex = layoutData.value[0].findIndex(ele => ele.i === itemId)
    let removed = layoutData.value[0].splice(draggingIndex, 1)
    console.log(layoutData.value[0], removed)
  }

大概可以模仿drag-from-outside例子，但先要解决拖少源GridItem时从源数组上删除该项引发异常？

By studying the 'drag, drop from outside' example, I tried to implement this feature but failed. At first, the GridItem's move event doesn't expose the clientX and clientY of MouseEvent, so I cannot check whether the item is moved out or not. Second is, GridItem's move and moved events sometimes are not emitted, so I cannot call grid's dragEvent() accordingly.  After that, removing a record from layout array during dragging will throw exception ( in hadleDray function of GridItem) because the HtmlElement is removed synchronously.
About the behavior of dragging and dropping an item between grids even crossing some grids, I think I should remove the placeholder from source grid when the item dragged is moved out, and append and move a placeholder in the dragging over grid ( and also remove it when mouse out), when the mouse is released in target grid, insert the item. If the mouse is released out of any grids, the source grid will be restored and the removed item will show in its original position.
Perhaps this feature is not a high priority, but I need this and am eager to find how to implement it. Hope I can hear from you. Thank you very much.

抱歉，最近一直在找工作，没怎么关注，希望你已经找到其他办法或者插件解决，同时我已经更新到了^1.0.7,并在src/example文件夹下提供了一个简单的例子。

谢谢。我已经做了一些尝试，基本实现拖放功能，但仍有些错误。我再试试你提供的例子。希工作顺利

我在这个(分支)[https://github.com/touchrank-dev/vue3-grid-layout-x]中实现了多网格间移动项目：但不完善


Setting output to false still outputs stuff

Describe what happened
When i set output: false it will outputs lots of data to stdout/stderr.
Steps to reproduce the issue:

Configure Webpack plugin like this:

new BuildPlugin({
  datadog: {
    apiKey: 'xxx',
    prefix: 'yyy',
    tags: ['zzz'],
    output: false,
  },
}),

Run the build
Get lots of stuff in your terminal

Expected behaviour:
Do not output to stdout/stderr
Actual behaviour:
Lots of stuff is outputted to stdout/stderr
Additional context
macOS 14.3.1
Node.js 18.18.0

Thanks for the heads up, sorry for the delay.
We're currently revamping the plugin, and this will most likely be covered in the next major release.

There is now a separate configuration logLevel to control this.
Feel free to re-open if that doesn't suit your needs.


Consider adding /= and *= operators

I just noted that while we do support things like i += 1 and i -= 1, we do not support division and multiplication assignment. Perhaps this was a conscious decision?
Regardless, it feels a bit inconsistent. We should probably go with either:

Removing += and -= as well. Mutation is kind of evil anyway. :stuck_out_tongue: or
Adding *= and /=, to be more consistent with the C family of languages. While mutation is arguably evil, it can be thought of as a necessary evil for some types of applications. :wink:

For reference, here's how K&R describes it in "The Book" (The C Programming Language, 2nd Edition, p.50):

The operator += is called an assignment operator.
Most binary operators (operators like + that have a left and right operand) have a corresponding assignment operator op =, where op is one of
+    -    *    /    %    <<    >>    &    ^    |

We don't support bitwise operators (single-character AND &, OR | and XOR ^) at the moment, but all the others are supported. Not sure if we want to support things like <<= for "reassign the value after shift-lefting it n steps". This deserves some thinking. It does match the x86 CPU instruction SHL and SHR well. But Perlang is not really intended to be a high-level assembler, I guess. :joy:

Not sure if we want to support things like <<= for "reassign the value after shift-lefting it n steps". This deserves some thinking.

Worth pointing out in this context is that it does seem to be supported in C#. :thinking: If we want to make things nice for people coming from a C or C++ background, it might actually make sense. Again, it's useful for certain kinds of programs... The question is mostly whether we consider it a goal or a non-goal to ease writing such programs in Perlang.


After upgrading ComfyUI, execute DetectFaces node and crash immediately.

Windows fatal exception: access violation
Stack (most recent call first):
File "G:\ComfyUI-aki-v1.3.ext\Lib\site-packages\onnxruntime\capi\onnxruntime_inference_collection.py", line 570 in _register_ep_custom_ops
File "G:\ComfyUI-aki-v1.3.ext\Lib\site-packages\onnxruntime\capi\onnxruntime_inference_collection.py", line 523 in _create_inference_session
File "G:\ComfyUI-aki-v1.3.ext\Lib\site-packages\onnxruntime\capi\onnxruntime_inference_collection.py", line 465 in init
File "G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_facetools\utils.py", line 65 in lmk
File "G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_facetools\utils.py", line 92 in init
File "G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_facetools\utils.py", line 137 in detect_faces
File "G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_facetools\nodes.py", line 93 in run
File "G:\ComfyUI-aki-v1.3\execution.py", line 158 in process_inputs
File "G:\ComfyUI-aki-v1.3\execution.py", line 169 in _map_node_over_list
File "G:\ComfyUI-aki-v1.3\execution.py", line 198 in get_output_data
File "G:\ComfyUI-aki-v1.3\execution.py", line 323 in execute
File "G:\ComfyUI-aki-v1.3\execution.py", line 500 in execute
File "G:\ComfyUI-aki-v1.3\main.py", line 126 in prompt_worker
File "G:\ComfyUI-aki-v1.3.ext\Lib\threading.py", line 982 in run
File "<enhanced_experience vendors.sentry_sdk.integrations.threading>", line 92 in _run_old_run_func
File "<enhanced_experience vendors.sentry_sdk.integrations.threading>", line 99 in run
File "G:\ComfyUI-aki-v1.3.ext\Lib\threading.py", line 1045 in _bootstrap_inner
File "G:\ComfyUI-aki-v1.3.ext\Lib\threading.py", line 1002 in _bootstrap

Have you found a solution? I am in the same situation

same


[Backport] v2.4: Includes k3s upgrade images when uses image export script in dev, master, or non semver tag that is equal to kd.RancherVersionDev

Original Issue:
https://github.com/rancher/rancher/issues/31061

Reopen this issue because of missing images tags in the rancher-images.txt file on rancher:v2.4.14-rc1
Steps:

get the compatible k3s versions from the here
get the rancher-images.txt from rancher:2.4.14-rc1's release page

Results:

there are three compatible k3s versions for rancher:v2.4.14-rc1

v1.17.17+k3s1
v1.18.15+k3s1
v1.19.7+k3s1

the klipper-helm images are in the rancher-images.txt file

rancher/klipper-helm:v0.2.3
rancher/klipper-helm:v0.2.7

missing docker.io/rancher/klipper-helm:v0.3.0 for supporting k3s v1.19.7+k3s1

the k3s-upgrade images are in the rancher-images.txt file

rancher/k3s-upgrade:v1.17.17-k3s1
rancher/k3s-upgrade:v1.18.15-k3s1

missing rancher/k3s-upgrade:v1.19.7-k3s1 for supporting k3s v1.19.7+k3s1
@rmweir  Do we expect to see all images in the rke-images.txt of a supported k3s release, such as v1.19.7+k3s1, are included in the rancher-images.txt?

@jiaqiluo I don't think 1.19.7+k3s1 is compatible as it's constraints are as follows:
{
    "maxChannelServerVersion": "v2.5.99",
    "minChannelServerVersion": "v2.5.0-rc1",
    "version": "v1.19.7+k3s1"
}

We would expect to see all the images in k3s-images.txt if that were not the case though.

Thank you @rmweir for the confirmation!
This issue can be closed based on the following additional validation:

only v1.17.17+k3s1 and v1.18.15+k3s1 are supported on rancher v2.4.14
all images in k3s-images.txt are in rancher-images.txt


Better handling of issues caused by time traveling (RiskResults) (DEV)

Change primary key for risk result database to a monotonic ID.
The RiskLevelTask calculates a RiskResult, that's stored in a database.
The UI uses the "latest result" and "latest successful result" when displaying the risk/tracing card on the home screen.
If the device travels into the future, calculates a result, and then returns back to "our" time, then the risk card always has a "newer" result until we have caught up to the future date at which the result was calculated.
This is also likely not the cause for #2001, but looking deeper into that issue caused me to think it's nice to have this additional resilience against time-traveling issues. This also makes it easier for developers/users/testers to debug issues by changing the devices clock, this was previously possible before the move to ENFv2.
The PR migrates the database by creating a new table that has the autoincrementing field monotonicId and then moving the old data into it. The SQL queries are adjusted to sort my monotonicId instead of calculatedAt.
Testing

Use the app without this PR, fake a few different risk results through the test menu

Update to this PR's version

Everything should look the same

Use this app without this PR, time travel and generate a risk result in the future

Return to normal time, notice that any risk result changes (e.g through the test menu), will not replace the result (card state) from the future

Upgrade to this PR's version, the risk result card on the home screen should now show the last calculated result (which is from your time now, and not the one from time traveling)

I've added exception handling to the migration that drops the table and creates the v2 schema.

I've added exception handling to the migration that drops the table and creates the v2 schema.


Failed to generate a valid hash for PR check.

I am recently getting this message for all the domains I am checking.

The Pagerank Checksum API is offline. You need to change the USE_CHECKSUM_API in config file to false.
https://github.com/eyecatchup/SEOstats/blob/master/src/class.seostats.config.php#L22

closed for now

Implemented an alernative calculation for the checksum calculation for the Pagerank request. If you still get "Failed to generate a valid hash for PR check.", open class.seostats.config.php and set "USE_PAGERANK_CHECKSUM_ALT" to true.

I am also fetching the same issue. Not getting which one is the correct answer.


TZNames.GetAbbreviationsForTimeZone returns wrong short name in french for America_Eastern

The short name for daylight saving time returned is HEE (as per de data in the data.json.gz file) but this is incorrect
"America_Eastern": {
    "Generic": "HE",
    "Standard": "HNE",
    "Daylight": "HEE"
},

It should be HAE for Heure Avancée de l'Est

This is fixed in the current version.  Thanks.


Create crossword_puzzle.py

Added docstring in my code.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Implement Crossword Puzzle in Python #2918
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Added Crossword Puzzle Code in python and update readme.md

2 checks are falling. But I didn't find any issue. Can you tell me what is the issue. @bhav09 @HarshCasper


Fix English action links

They were broken by merging #355 in an accident.

I'll wait for the build to complete before we merge

the build to complete

Fair enough.


slow down, leaking ansi escapes in output

Nice job with this! I was testing on nushell and it started out nice, then slowed way down and started leaking ansi escapes in the output.
My command line was cargo nextest run --all --all-features

Keep up the good work!

Thank you! To be clear, are you running within the nushell shell? I'm asking because I haven't seen this across months of testing, and nextest is careful to lock stderr for each line so at least in principle it shouldn't happen.
However, I do believe throwing in a BufWriter would be beneficial -- let me see if I can get a fix out soon.

hi @sunshowers, i'm running in Windows 11 inside Windows Terminal using PowerShell Core.
Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I've also noticed something else that may be a tip for all your windows users. Maybe you already know this but I just missed it. Here's the tip. If you're on Windows and you're using Microsoft Defender, it's good to add an exclusion for your build folder. It took my run from 80 seconds to 10. I'm not sure if that's related to this ansi-leakage or not.

Thanks for the info about the enviroment! Ahh yeah, antivirus stuff on Windows is pretty unfortunate.
Going to get a fix for this out in a couple of hours.

I'm really kind of thinking it's related to Microsoft Defender because when Defender is running on all these files, it pegs the cpu at 100% and that's why some of the tests are slow in the screenshot. So, one way to test this is to have a cpu stress program running while you run nextest to see if that's causing the leakage.

ok. let me know when you have something to try. i have just reproduced it again, even with it running at full speed with the folder in my defender exception list.

Thanks @fdncred! Could you try:
cargo install --git https://github.com/sunshowers/nextest --branch bufwriter --bin cargo-nextest

and see if that fixes this issue?

sure. i tried it 5 times without any visible leakage. I'll continue using it and report back if i see any issues. For now, I'd just accept the win and close this issue with a landed PR. thanks for the quick turn and the cool tool!

Just published 0.9.3 which should have a fix for this. Thanks again for reporting!


Missing RTP sequence numbers

I've come to the conclusion that there might be missing RTP sequence numbers for HEVC streams that are not actually missing frames, because they don't seem to affect the stream. It is also possible that they are actually missing, since there are missing frames occasionally. The missing sequence numbers don't seem to occur with each intra frame which might suggest some sort of quality issue instead.
This should be investigated. These are most likely related to Intra frames or aggregate packets.
See:

Ok, I figure it out. The sequence numbers are common for audio and video and the audio has the missing sequence numbers. Is this the correct interpretation of the RFC? To me, it does not make much sense, but I could be wrong.

This would indicate that no:

Also this:

This cannot be done if audio sequence numbers are mixed with video.

I investigated this and came to the conclusion that the RTP timestamps are implemented correctly, but also that there is currently no way for the user to know if a frame or packet was lost based on HEVC sequence numbers.


Add animations to the SVGs

Currently, the graphics appear suddenly as they are loaded. There is no fade-in animation or motion.
It may be cool to have some sort of CSS animation as the image loads on the page (similar to how it is done with GitHub Readme Stats. See this example.)

#30 Check out.


Sorted package lists and files

Sorting the lists and having file paths on separate lines
makes it easy visually to verify the items.

Thank you for the PR!
I started a new job this month, and I again fell back behind handling issues/PR here :/
Just a small comment: Instead of print(os.linesep.join(sorted(str(s) for s in site.iterdir()))) I'd rather print(*sorted(site.iterdir()), sep=os.linesep) (but I'm pretty sure that even on Windows os.linesep could be changed with \n... and Python already translate the newline for every file opened in text mode, like I think stdout is)

Yes that is better. I've changed to it.

Thank you for your PR!


fix: issue on building inside docker image without .env (moved envs from default value at params)

Hi sir
This error only happends when you try to build the code without all the .env variable, for example, inside docker image could happen. The best way to avoid it is to not setting a process.env as a default param.
I make some tests and this will fix the issue. It only happends if you load this code from node modules package. This issue happends to me inside docker build only, but the solution is as easy as it.
 36.94 server:build:    Generating static pages (0/10) ... 37.77 server:build: Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error **37.77 server:build: Error: getPayloadUser requires a server URL to be provided, either as an option or in the 'NEXT_PUBLIC_SERVER_URL' environment variable** 37.77 server:build:     at d (/app/apps/server/.next/server/chunks/3853.js:604:229796) 37.77 server:build:     at f (/app/apps/server/.next/server/chunks/2196.js:1:6719) 37.77 server:build:     at ek (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:13409) 37.77 server:build:     at e (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:17307) 37.77 server:build:     at eO (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:17769) 37.77 server:build:     at Array.toJSON (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:14915) 37.77 server:build:     at stringify (<anonymous>) 37.77 server:build:     at eU (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:26272) 37.77 server:build:     at eq (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:26502) 37.77 server:build:     at eB (/app/node_modules/.pnpm/next@15.0.1_@opentelemetry+api@1.9.0_@playwright+test@1.48.0_babel-plugin-react-compiler@0.0._rsqjemyostbi4mzxu4v37fu6p4/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:84:27056) 37.77 server:build: Export encountered an error on /(web)/page: /, exiting the build. 37.78 server:build:  ⨯ Static worker exited with code: 1 and signal: null 37.87 server:build:  ELIFECYCLE  Command failed with exit code 1. 37.88 server:build: ERROR: command finished with error: command (/app/apps/server) /usr/local/bin/pnpm run build exited (1) 37.88 server#build: command (/app/apps/server) /usr/local/bin/pnpm run build exited (1)

I have also tried it by myself and this error occurs when nextjs try to prerender the page at buildtime.
The main cause is that Next.js is trying to discover if this route is dynamic and this error is thrown before the Dynamic API cookies is used.
The solution for this error is quite simple, the error musst be thrown after the cookies statement. So Next.js will no longer try to render this page static.

Sorry I mistaken with the commit, that was not the fix really

It's a strange error what happened to me but this small change fixed it, I duplicated the function in my project to fix it. Consider it if somebody more has that error.


Small kaj changes

Added display when Auto EC is disabled by requirement lock
Disabled blackhole command error in cel3 and cel7
Changed milestone 1000 requirement to 5 seconds or less
Study tree will now automatically respec when exiting an EC
Companion glyph and study presets now carry over when you start over
Fixed text inconsistency
Fixed offline progress bug

Save for testing auto ec requirement lock display and respec when exit:
https://paste.ee/p/Ikizz

I don't think anyone is realistically gonna play this game more than 50 times, and if they do they will be an exception to the rule.
I know keeping companion glyphs sounds a bit silly but it does say it will never leave you :)


Better default label handling

This PR slightly improves handling of default labels across containerd.
Also respect containerd.io/defaults/snapshotter label in ctr pull/push and others
Adds a few aliases for ctr namespace subcommand (ctr ns ls and ctr ns c ...)

ref: https://github.com/containerd/containerd/issues/2285

Codecov Report

Merging #3403 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3403   +/-   ##
=======================================
  Coverage   45.05%   45.05%
=======================================
  Files         113      113
  Lines       12563    12563
=======================================
  Hits         5660     5660
  Misses       6049     6049
  Partials      854      854

Flag
Coverage Δ

#linux
48.98% <ø> (ø)
:arrow_up:

#windows
40.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4fc1d...a7d9007. Read the comment docs.

Codecov Report

Merging #3403 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3403   +/-   ##
=======================================
  Coverage   45.05%   45.05%
=======================================
  Files         113      113
  Lines       12563    12563
=======================================
  Hits         5660     5660
  Misses       6049     6049
  Partials      854      854

Flag
Coverage Δ

#linux
48.98% <ø> (ø)
:arrow_up:

#windows
40.27% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4fc1d...a7d9007. Read the comment docs.

LGTM


Setters for TH1?

Could TH1 (or other methods) as well grow some setters, such that things like this might be possible?
aTH1 = TH1()
aTH1.values = np.array([2,3,2])
aTH1.edges = np.array([0,1,2,3])
aTH1.variances = np.array([4,5,1])

The classes in here are simple and flat, so you're free to suggest any improvements via pull request. It would be something like
    @values.setter
    def values(self, new_values):
        sanity_checks(new_values)
        self._f??? = new_values

(I don't remember the ROOT name for the values, or if she transformation is needed in the case of variances, but it would be the reverse of the getter.)
Some of these methods strip off the underflow (first) and overflow (last) bins. If that's what values does, what should setting it do? Leave the old value of the underflow/overflow? Set them to zero? If the latter, then someone trying to set all components one at a time would be surprised that setting underflow before values yields a different final state than values before underflow.
Since these are tiny objects maybe they shouldn't have mutable setters but functions that return a copy with the items set (i.e. with_values instead of set_values).

Setting values would be equivalent to SetBinContent I guess, so I'd say don't adjust under/over-flow by default. Which is not great, but I think that's kind of what root has.
One can always call .copy() on it prior to setting stuff no? Would setting values, edges and variance create 3 successive copied? That doesn't sound great.

It's up to you to decide how you want the interface to be. The only constraint is that the data model matches ROOT's: it has a single array of all bins, including overflow and underflow, and you can't change the values (no under/overflows) vs allvalues (with under/overflows) because other users are already using that.
Mutability often leads into these thorny issues, which is why some languages/libraries avoid it completely. Maybe you want allvalues to be a mutable property while values is read-only, because it represents a view.


Health Check Flow

Task Description
"Health Check" will ensure the availability of signing devices ( hardware wallets or software keys). The app will check for the last health check action and send reminders through UAI if they are inaccessible beyond a threshold.
If it m or more devices are inaccessible, receive functionality on the vault will be restricted.
Architecture Diagram and Data
Signing Device
{
........
lastHealthCheck: Date
}

Tasks

[x] Common interface for Health Check for all signing devices.
[x] Health Check automatic reset after Signing/VaultRecovery/Registration
[x] UAI reminder - 90days in Prod/ 3hours in Dev
[x] #2541
[x] #2827

Removed the fixed tag and put in progress as one of the issues will be looked at by Pratyaksh in the next sprint. We should be able to close this issue in the next sprint.

Closing cc @pratyakxx


Learn Page Translated and Checked

An outcome of Google Summer of Code 2021
Author- Sanjay Singh Rajpoot @SanjaySinghRajpoot
Mentor - Aditya Rana @ranaaditya

Looks good to me !


Cannot run unconditional simulation

Hello. I used sgsim to run an unconditional simulation but it does not work. Have you tried unconditional simulation using the pygeostatistics code before? Thanks.

pyGeoStatistics' sgsim cannot perform unconditional simulation. 😿


settings: Do not execute hotkey inside any users tab filter input.

We changed the scope of the selector to just the switcher. This means that the hotkeys will only run when the user focuses on that element. This follows the same pattern as the Personal and Organization tab switchers which limit the hotkey area to their tab list and not the content. If we want to use hotekeys inside the content, just filtering out INPUT elements in keydown_util might be better.
Fixes https://chat.zulip.org/#narrow/stream/9-issues/topic/.F0.9F.8E.AF.20Org.20settings.20user.20search.20does.20not.20work.20with.20vim.20hotkeys.2E/near/1882313

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks great, merged, thanks @shubham-padia!


Update catalog.yml with a eLifeSprint 2020 report

Hello,
We still do not have it as a full preprint, with a DOI and such. Is it an acceptable contribution anyways?
Best,
Tiago

Oops, double https, thanks.
I`ll add that to the metadata.yml (thanks again).
It is not in the 1000x1000 format, though, I hope it is not a big issue.

It is not in the 1000x1000 format, though, I hope it is not a big issue.

yes does not matter. It will work regardless.


Feature: Randomize the text color on contributorsmap page when page refreshes

Issue Addressed
Closes #184
Proposed Changes and Benefits
I have implemented a new feature to randomize the color of the text being displayed every time a user visits the page. This enhancement is aimed at improving the user experience by adding variety to the text color, making the content visually engaging. To achieve this, I made the following changes:
•	Created a function called getDifferentColors() in MapContributors.jsx to generate a random color.
•	Applied this function to the style attribute of the <p> tag, ensuring that the text color changes every time the page refreshes.
•	Removed the color property from MapContributors.module.css to prevent any overriding of the dynamically generated text color.
Screenshots
When I run the project:

After I refresh the page:

As you can see the color generated by the getDifferentColors() function in element.style.
Notes to Reviewers
It might possible that while testing you directly click on contributors map. And it will redirect you to hosted page. I made the same mistake when I was implementing this feature and could not figure it out for long time.
Checklist
•	[x] I have thoroughly read and understand The Contribution Guidelines.
•	[x] The title of this PR follows the Feature: Randomize the text color on page refresh format.
•	[x] I have listed my proposed changes and their benefits.
•	[x] I have linked the corresponding issue in the Issues section.

@harmit17  Your pull request has been successfully merged!!! Congratulations .
Keep living a life with discipline and intentionality, and you will make it happen!
If you haven't already, please go ahead and star this repo and you are more than welcome to continually contribute to this project by assisting with our open issues, or adding your own new open issues, and additionally you can get an idea of ideas we have to continually grow this project further as technology and tech stack continually evolve by looking at the ROADMAP for the project. Have a great day, and thank you for taking the time to contribute,
Harmit! You can view your contribution now on the live link. Have a great rest of your day, and I will be sending you an invite to be a member of the Before I Die Code now.

This PR closes issue #184

@harmit17 Your pull request has been successfully merged!!! Congratulations .
Keep living a life with discipline and intentionality, and you will make it happen!
If you haven't already, please go ahead and star this repo and you are more than welcome to continually contribute to this project by assisting with our open issues, or adding your own new open issues, and additionally you can get an idea of ideas we have to continually grow this project further as technology and tech stack continually evolve by looking at the ROADMAP for the project. Have a great day, and thank you for taking the time to contribute, Harmit! You can view your contribution now on the live link. Have a great rest of your day, and I will be sending you an invite to be a member of the Before I Die Code now.

Thanks for the opportunity.


Error while reading SWC from SEU

Hello,
thanks to the collaboration with have with South East University, we have quite a lot of morphologies, all created by Vaad 3D. Out of the 200 we recently got, 199 are not readable and as far as I have tested, it's always the same error:
Traceback (most recent call last):
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/utils.py", line 193, in load_data
    return _READERS[reader](filename)
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/swc.py", line 56, in read
    return data_wrapper(data[:, [X, Y, Z, R, TYPE, ID, P]], 'SWC', None)
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/datawrapper.py", line 74, in __init__
    self.sections = sections if sections is not None else _extract_sections(data_block)
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/datawrapper.py", line 206, in _extract_sections
    sec.pid = parent_section[sec.ids[0]]
KeyError: 108

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "test_neurom.py", line 6, in <module>
    nrn = nm.load_neuron(morph_path)
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/utils.py", line 116, in load_neuron
    rdw = load_data(handle, reader)
  File "/Users/lurie/opt/miniconda3/lib/python3.8/site-packages/neurom/io/utils.py", line 196, in load_data
    raise RawDataError('Error reading file %s:\n%s' % (filename, str(e))) from e
neurom.exceptions.RawDataError: Error reading file /Volumes/LaCie/BBP/morphologies/SEU_october2020/swc/17302/17302-Z2991-X7767-Y3860.swc:
108

The error is triggered here.
My gut feeling is that this error is caused by the order the points are declared in the swc file. The parent nodes are not especially declared first, so most of the time, a point will refer to its parent by an id that is actually later in the file. That's really just a gut feeling though.
In parallel, I will send you a file sample by email.
Best.

Thanks for the report.  We have a test filethat checks if the order matters in SWC:
https://github.com/BlueBrain/NeuroM/blob/master/test_data/swc/simple_reversed.swc
So we'll have to investigate this.

I should note that NEURON version '8.0.dev-193-gfc74b85+' also doesn't seem to load this SWC file, which may be important information for the reconstructors - however, it's beside the point now.

Hum, interesting. Yes, I think that the problem is what you are mentioning.
I was able to open the morphology you sent with morphio. Can you try with NeuroM v2 (which uses morphio as a backend) and see if it works ?
All you need is to reinstall neurom with the --pre option.
pip install --pre neurom

Thanks

Alternatively you can use morph-tool to "rewrite" the morphologies in the same format:
pip install morph-tool
morph-tool convert folder -ext swc INPUTDIR OUTPUTDIR

It will re-write the files to swc but with a decent ordering

Hey, thanks for the responsiveness! I manage to open the file with MorphIO si it should be fine with the NeuroM that uses it as a backend. I'll keep you updated!

Here is a reduced/anonymized test case:
##n type x y z r parent
1   1   1   1   1 1 -1
99  3  99  99  99 1 100
100 3 100 100 100 1 101
101 3 101 101 101 1 102
102 3 102 102 102 1 103
103 3 103 103 103 1 104
104 3 104 104 104 1 105
105 3 105 105 105 1 106
106 3 106 106 106 1 107
107 3 107 107 107 1 108
108 3 108 108 108 1 1

Closing as it has been solved in NeuroM v2


Allow users to install borgbackup package instead of downloading binary

I think it would be helpful to have support for installing borg backup from the package manager.
I've tested this installing from both package and web in a local vagrant environment on CentOS 7, and was able to take a backup successfully both ways.

I'm deleting my fork, but the changes proposed in this PR are available at: https://github.com/tag1consulting/ansible-role-borgbackup

I like this idea and I think we can add it if you can bring the PR in a mergable state.

@stroobl I'm closing this in favor of https://github.com/fiaasco/borgbackup/pull/25, please see the updated (mergeable) changes there:


Configure 0640 permissions to mounted key files on Control plane components

How to categorize this PR?

/area security
/area compliance
/kind enhancement
What this PR does / why we need it:
This PR enhances security by revoking other groups access to mounted key files on Control plane components by configuring 0640 permissions. 0640 are the minimal possible permissions for key files given that Control plane components run as 65532 user/group and mounted files are with owner user root (cannot be changed easily ref) and group 65532 ( set by fsGroup).
This PR is in sync with Kubernetes' STIG.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Control plane components `kube-apiserver`, `kube-controller-manager` and `kube-scheduler` now mount `key` files with `DefaultMode` set to `416`(`0640` permissions).

`gardener-apiserver` and `gardener-admission-controller` now mount `key` files with `DefaultMode` set to `416`(`0640` permissions).

/test pull-gardener-e2e-kind-operator

Is there anything regarding gardener-{controller-manager,scheduler,admission-controller} that should be handled in a similar way?

Is there anything regarding gardener-{controller-manager,scheduler,admission-controller} that should be handled in a similar way?

I had checked gardener-{controller-manager,scheduler} and did not find such mounted files. gardener-admission-controller I checked now and found that it mounts a key file. I have now added a new commit which sets DefaultMode:416 for the secret containing the key file.
I have also set Pod level SecurityContext for gardener-{apiserver,controller-manager,scheduler,admission-controller}. Their images already use nonroot user and group, but I think it would be better to set them explicitly. I have set fsGroup: 65532 which was required when using DefaultMode:416.

Why not use the more common octal number format for permissions? 0640 looks better to me than 416.

I have used 416 since I  found that we have mostly used the decimal representation of permissions. Also, in kubernetes it would be represented as 416.

Do we need write access for root?

Although we don’t need write access for the root user, it is important to note that the root user possesses unrestricted access to all files. We can leave the permissions as 0040 and it would be the same as 0640 in this case

OK, thank you. I'm fine then. However, I would also vote to use the octal number format as proposed in https://github.com/gardener/gardener/pull/8790#pullrequestreview-1726877226 since it's more intuitively to handle it like this.

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

/lgtm

/approve