Functionality for the 2020-12-01 Compute Rest API release

Most of the Swagger edits are here: https://github.com/Azure/azure-rest-api-specs/pull/12334
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

I just regenerated the .Net SDK from Master, and it showed no changes to what is currently in this PR. The CI failure seems incorrect.

The CI failure seems incorrect.

@Sandido looks like there is no change to management metadata file in /eng/mgmt/.  This can cause the ci generation to not use the same commit in the rest-api-specs repo that you are using.  Please include the updated management metadata file.

Need to include the generated metadata file. The ci error looks like it is using an older commit than you are using.

Made edits to the compute-resource-manager.txt file with the latest commit id to master: https://github.com/Azure/azure-rest-api-specs/commit/6bb1040f2c98e8117c44d56210d66201e887153e


Filesystem functions don’t work with Patchwork\Utf8\WindowsStreamWrapper

This wrapper tries to work with files using their short filenames, but PHP can’t handle short names of files which have Unicode long names (see https://bugs.php.net/bug.php?id=65358). Using this wrapper, one can work with folders and delete files (scandir, mkdir, rmdir, unlink), but cannot create, modify, read or upload files (fopen, file_put_contents, file_get_contents, move_uploaded_file).
More exactly, these operations are possible, but only if filenames match current system locale (as well as when we use normal PHP filesystem functions). E.g. if my Windows has russian locale, I can create/upload a file with cyrillic filename but cannot with hebrew or greek, and vice versa - whether WindowsStreamWrapper is included or not.
This makes WindowsStreamWrapper pretty unusable. I also tested old version of this script (WinfsUtf8.php, 2012) with the same result.
Example:
	// Using Windows with english locale (CP1252)

	// 1) Filename string doesn’t match OS locale
	file_put_contents($path . 'εγκυκλοπαίδεια.txt', 'Greek filename');

	// Result with WindowsStreamWrapper:
	// PHP gives warning “failed to open stream”
	// Result without WindowsStreamWrapper:
	// PHP creates a file with messy name (however PHP can see this file as 'εγκυκλοπαίδεια.txt')

	// 2) Filename string matches OS locale
	file_put_contents($path . 'filênàmé.txt', 'Western european filename');

	// With WindowsStreamWrapper:
	// Success
	// Without WindowsStreamWrapper:
	// Success (however filename string must be encoded in CP1252, not UTF-8)

Tested on PHP versions 5.5.13 & 5.4.29.

I was already testing for this buggy behavior so I added the bug reference in commit b349019612228bde6d81edf8910ca505e3c19cbb
https://github.com/kenjiuno/php-wfio is the way to go and WindowsStreamWrapper does work for some use cases as fallback. There is nothing I can do about it unfortunately (or please send a PR if someone has an idea...)


Deploy to aws and upload file see logs error

JobName: TranslateJob-captions1656072631370
[ERROR] 2022-06-24T12:10:32.269Z        a7059c36-5673-42f0-a951-3fef8edf494b    An error occurred (NotAuthorizedException) when calling the StartTextTranslationJob operation: Your account is not authorized to make this call.
[ERROR] 2022-06-24T12:10:32.269Z        a7059c36-5673-42f0-a951-3fef8edf494b    An error occured with S3 Bucket Operation: An error occurred (NotAuthorizedException) when calling the StartTextTranslationJob operation: Your account is not authorized to make this call.

I know why，because  us-west-1 region  are not supported...


Line : 873 | Message: Service patched_drivers\chromedriver_4.exe unexpectedly exited. Status code was: 1703780

Line : 873 | Message: Service patched_drivers\chromedriver_4.exe unexpectedly exited. Status code was: 1703780
I deleted patched_drivers and chromedriver but it also doesn't work

[img]https://upload.cc/i1/2021/09/18/oYxXcW.jpg[/img]
[img]https://upload.cc/i1/2021/09/18/OTnl2w.jpg[/img]

Did you install google chrome? And why your proxy refresh is .1 ? You're saying every 10 seconds program should load proxy from your text file and restart the whole process.. change it to a large number

I found that I can’t use the administrator to execute it and it will make an error


Do not copy params in get_params.

Summary
For compatibility with the scikit-learn clone function get_params has to return the same parameters as given in the init function. Fix issue #13586
Related Issues
#13586
PR Overview

[ ] This PR requires new unit tests [y/n] (make sure tests are included)
[ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[x] This PR is backwards compatible [y/n]
[ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Any news on this?

@amueller  I think we just need to get someone from keras to re-run tests on this PR.
@fchollet Can you re-trigger travis on this PR, so we can get passing tests?

This is a silly question, but how would I checkout this branch locally?

Hi all, sorry for stepping in, I was investigating the scikit-learn issue 17022 and that led me here. I have checked out this branch: for me it fixes scikit-learn 17022 and scikit-learn issue 15722 opened by @mcarbajo himself.

This is a silly question, but how would I checkout this branch locally?

@zachmayer, here the command line procedure I used (I beg your pardon if I misunderstood your question)
$ git remote add mcarbajo https://github.com/mcarbajo/keras.git
$ git fetch mcarbajo
$ git checkout -b mcarbajopatch -t mcarbajo/patch-1

Hope it could help to finalize this. Thanks for listening.

@cmarmo thanks!  I'm gonna try to make a new PR sometime and see if I can get this test to pass.

Any updates on this? @zachmayer, did you create a new PR?

 Thanks.

I did run git fetch mcarbajo first. I just tried again, same error. gh pr checkout 13598 worked for me though

ok, the conflict in keras/wrappers/scikit_learn.py is gonna be hard to fix lol.  The whole file is now just from tensorflow.keras.wrappers.scikit_learn import *
@fchollet Should we stop making PRs to the keras repo and try to fix this in the tensorflow repo?

https://github.com/keras-team/keras/blob/master/keras/wrappers/scikit_learn.py

I'll try making a PR here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/wrappers/scikit_learn.py

I made a PR to tensorflow here: https://github.com/tensorflow/tensorflow/pull/41341


NEOFORGE 1.20.1 DOESNT WORK WITH PRISIM LAUCNHER MODS

Exception caught from launcher
java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:67)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: joptsimple.MissingRequiredOptionsException: Missing required option(s) [fml.fmlVersion]
at MC-BOOTSTRAP/jopt.simple@5.0.4/joptsimple.OptionParser.ensureRequiredOptions(OptionParser.java:426)
at MC-BOOTSTRAP/jopt.simple@5.0.4/joptsimple.OptionParser.parse(OptionParser.java:400)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.ArgumentHandler.processArguments(ArgumentHandler.java:65)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.TransformationServicesHandler.processArguments(TransformationServicesHandler.java:68)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.TransformationServicesHandler.initializeTransformationServices(TransformationServicesHandler.java:50)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.Launcher.run(Launcher.java:88)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.Launcher.main(Launcher.java:78)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
at MC-BOOTSTRAP/cpw.mods.modlauncher@10.0.9/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
at cpw.mods.bootstraplauncher@1.1.2/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)
... 8 more
Exiting with ERROR
Process exited with code 2.

This is not the place to get support

Hello! I would suggest asking questions related to third-party launchers in #user-support of our Discord. GitHub issues are not the best way to address this as it is likely an issue with your current setup or how prism launcher is configured.

 Generally, most websites require you to be 13 or older to sign up for an account, such as GitHub and Discord. I am unsure what restrictions would be preventing you from using them, as it is the best way to communicate about user issues.

Just github, gmail, pateraon, and text

sooooooo..............

Apologies. Looking at the issue, it suggests that the fml.fmlVersion parameter is missing, which would be set as part of the launch variables. I have recently run 1.20.1 locally to confirm, so this is likely a run argument missing in prism launcher. It is recommended to use MinecraftForge in 1.20.1 anyway since NeoForge is backwards compatible for that specific version.
If you still need help, I would recommend looking at the communication spaces for Prism Launcher (e.g. reddit, discord, github) which one of them you should be able to communicate on. You are welcome to link them this issue for more context.

its kinda funny that you cant change the forge version of neoforge


Add PII classification to existing column in the data set

I am trying to add PII classification to the existing column in the data set. The following is the navigation, I followed
1.Clicked on Catalog
2.Clicked on Datasets
3.Typed users on Search
4.Clicked on Users dataset
5.Clicked on Structure
6.Clicked on existing column birth_date to classify as PII, But I could see only Edit Labels option or Edit Description
How do I add PII classification to the existing columns

hey @sivapadman, thank you for creating the issue!
Generally, you can use labels to mark columns that are PII. Click Edit Labels option, type PII and click Save

hey @sivapadman!
This feature will be released in 0.2 release coming this week. It contains searching capabilities by dataset field's name, description and labels. So now you could assign PII label to the field and then find it by query "PII"


current dev branch

what is your current dev branch? i have been working off v2.5.0_dev but just noticed that v2_devel is the default now. should i update my fork to use v2_devel or keep working off v2.5.0_dev?

v2_devel is dev branch and its the branch i use.
I don't think there are any changes that you don't have though, the only difference for now is the name.

ok thanks. all my directory changes are on v2.5.0_dev but i dont think that is an issue for now (but might become one if i miss a change that breaks it)

Yeah apologies, the v2.x naming convention was a terrible idea of mine.
I eventually want to remove all others and only keep v2_master for stable and v2_devel for testing/development. That should make things a lot clearer for everyone in future.

ok i will update to v2_devel and work off that


Tor ui cleanups

@patrickxb another go on this

LGTM

Can you push merge.
On Friday, November 6, 2015, Patrick Crosby<EMAIL_ADDRESS>wrote:

LGTM
—
Reply to this email directly or view it on GitHub
https://github.com/keybase/client/pull/1296#issuecomment-154517231.


Override slide animation startingpoint?

Hi,
is there a possibility to change the starting point of the slide-animation?
Actually it starts at the left windowborder. I want to set the startingpoint on a specified element.
Cheers

Hi, yes I think it's possible. You have to override the .tooltipster-slide.tooltipster-initial class with the left and top css properties of your choice. If the coordinates should be dynamic, a good time to compute and set them would be upon the firing of the created event.


Auth::user($guard = 'api') doesn't work

Hello!
I am trying to use api and got problem with auth. My routes:
Route::group(['middleware' => 'web'], function () {
    //API
    Route::group(['middleware' => 'auth:api'], function () {
        Route::get('/some_api', ['as' => 'home.api', 'uses' => function () {

           var_dump(Auth::user('api')); //<<<<< it show null

            $data = [
                'field_1' => 'gdfgfdg',
                'field_2' => 54642,
            ];

            return response()->json($data);
        }]);
    });
});

I pass api_token param to url.
I think root cause is in https://github.com/laravel/framework/blob/5.2/src/Illuminate/Auth/AuthManager.php#L282
It call $this->guard() and don't pass $guard to it, so it return default guard (SessionGuard).
Temporary solution is: Auth::guard($guard)->user()

I don't see the issue here, the user() method accepts no guard parameters. The intended usage is exactly how you specified it, Auth::guard('api')->user();.

User has guard param
3 марта 2016 г. 20:34 пользователь "Steve Bauman"<EMAIL_ADDRESS>написал:

I don't see the issue here, the user() method accepts no guard
parameters. The intended usage is exactly how you specified it,
Auth::guard('api')->user();.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/12606#issuecomment-191876387
.


Admin panel served at port 81 with no SSL at all?

Hi!
The docs seem to suggest serving the admin panel with no SSL on port 81 and there is no mention of a threat model or security consequences. That seems like a troublesome choice for security, not just for people hosting at home. I have just seen a publicly accessible setup that has the log-in form send username and password unencrypted through the internet. Am I missing something?
Thanks and best, Sebastian

The point of this project is to allow you to create your own SSL encrypted domains for any services, including NPM. So yes you can create your own npm.yourdomain.com pointing to NPM with hostname <IP_ADDRESS> and port 81. Then if you really want your home-only network to be 120% secure, modify the docker-compose file and remove port 81 from the ports list.

Is it possible to serve the admin panel through SSL and is there documentation on that?

Based on the configuration options present today, no.  You can modify this file https://github.com/jc21/nginx-proxy-manager/blob/master/docker/rootfs/etc/nginx/conf.d/production.conf and create your own docker image with SSL enabled.  You'll also need to modify the curl health check to use https and ignore certificate errors.
It is common practice when using Docker reverse proxies that the SSL offloading is done at the nginx layer.  In almost all cases that I have seen, the internal communication between docker containers is done via plain transmission so that certificates don't have to be managed individually within each application.
As the maintainer said, the purpose of this application is to create reverse proxies with SSL support.  So it makes sense to leverage npm to create an admin reverse proxy for port 81 rather than creating a separate set of configuration options.  This way the configuration and SSL management is done in the same interface and with the same patterns as all of your other vhosts.

I'm not clear on the question.  This tool only manages vhosts, not the underlying docker applications.  If you're asking how to create a vhost with SSL, it's on the SSL tab in the editor.

Closing as a duplicate of https://github.com/jc21/nginx-proxy-manager/issues/182


NoSuchTableError: key_names on zappa deploy

I have created an .sqlite file by following the documentation guide and moved it to the S3 bucket. Then, I'm trying to deploy the AWS Lambda function with zappa and I'm getting the below error.
It seems that the table "key_names" does not exist but instead there is a table named "keys".
Oh no! An error occurred! :(

==============

Traceback (most recent call last):
  File "/home/ubuntu/terracotta/terracotta/drivers/relational_meta_store.py", line 49, in convert_exceptions
    yield
  File "/usr/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/ubuntu/terracotta/terracotta/drivers/relational_meta_store.py", line 276, in get_keys
    keys_table = sqla.Table('key_names', self.sqla_metadata, autoload_with=self.sqla_engine)
  File "<string>", line 2, in __new__
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/util/deprecations.py", line 375, in warned
    return fn(*args, **kwargs)
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 619, in __new__
    metadata._remove_table(name, schema)
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 70, in __exit__
    compat.raise_(
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/util/compat.py", line 211, in raise_
    raise exception
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 614, in __new__
    table._init(name, metadata, *args, **kw)
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 689, in _init
    self._autoload(
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 724, in _autoload
    conn_insp.reflect_table(
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/sqlalchemy/engine/reflection.py", line 789, in reflect_table
    raise exc.NoSuchTableError(table_name)
sqlalchemy.exc.NoSuchTableError: key_names

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/terracotta/zappa_settings_callback.py", line 36, in check_integrity
    some_dataset = next(iter(driver.get_datasets().keys()))
  File "/home/ubuntu/terracotta/terracotta/drivers/base_classes.py", line 43, in inner
    return fun(self, *args, **kwargs)
  File "/home/ubuntu/terracotta/terracotta/drivers/terracotta_driver.py", line 132, in get_datasets
    where=self._standardize_multi_value_keys(where, requires_all_keys=False),
  File "/home/ubuntu/terracotta/terracotta/drivers/terracotta_driver.py", line 318, in _standardize_multi_value_keys
    return self._ensure_keys_as_dict(keys, requires_all_keys)
  File "/home/ubuntu/terracotta/terracotta/drivers/terracotta_driver.py", line 341, in _ensure_keys_as_dict
    unknown_keys = set(keys) - set(self.key_names)
  File "/home/ubuntu/terracotta/terracotta/drivers/terracotta_driver.py", line 59, in key_names
    return self.meta_store.key_names
  File "/home/ubuntu/terracotta/terracotta/drivers/relational_meta_store.py", line 289, in key_names
    self._db_keys = self.get_keys()
  File "/home/ubuntu/terracotta/terracotta/drivers/base_classes.py", line 43, in inner
    return fun(self, *args, **kwargs)
  File "/usr/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/home/ubuntu/terracotta/terracotta/drivers/relational_meta_store.py", line 51, in convert_exceptions
    raise exceptions.InvalidDatabaseError(error_message) from exception
terracotta.exceptions.InvalidDatabaseError: Could not retrieve keys from database

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/zappa/cli.py", line 3044, in handle
    sys.exit(cli.handle())
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/zappa/cli.py", line 519, in handle
    self.dispatch_command(self.command, stage)
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/zappa/cli.py", line 557, in dispatch_command
    self.callback("settings")
  File "/home/ubuntu/envs/tc-deploy/lib/python3.9/site-packages/zappa/cli.py", line 2171, in callback
    cb_func(self)  # Call the function passing self
  File "/home/ubuntu/terracotta/zappa_settings_callback.py", line 38, in check_integrity
    raise RuntimeError(
RuntimeError: Error while connecting to remote database. Please double-check your AWS environment variables, and make sure your machine has access to the remote Terracotta database.

==============

Need help? Found a bug? Let us know! :D
File bug reports on GitHub here: https://github.com/Zappa/Zappa
And join our Slack channel here: https://zappateam.slack.com
Love!,
 ~ Team Zappa!

Please make sure that the terracotta version that is deployed is the same that was used to create your database. Sounds like you are using current master for the former and the last release for the latter.

yeap, this was the issue. The databased created using 0.7.5 whereas I was using a 0.7.6 dev version to deploy the lambda function. Thanks!


(Urgent) build broken due to workflow setup

@suleman-uzair the build is currently broken due to the last step in the workflow. Can you please help fix it? Thanks!

@ronaldtse
The build was broken due to bad credentials error.
As you can see in the screenshot below, the token UNITSML_CI_PAT_TOKEN is missing.

Why does testing require any token?

The token has always been present though.

@CAMOBAP can you please help here?

Why do we need a CI user token for just testing?
The token exists, why is it failing?

I am not completely sure but I don’t think this token is needed here.
@CAMOBAP can you confirm whether this token is required in this repository ?
https://github.com/unitsml/unitsml-ruby/blob/main/.github/workflows/rake.yml#L15
I will just test by removing the token and dispatching the workflow, and there is a good chance that it will function as expected.

Why do we need a CI user token for just testing?

We don't need it, it came because we used it in metanorma repo because they can trigger other repositories

The token exists, why is it failing?

It may not have required permissions to send repository_dispatch events
Fixed in https://github.com/unitsml/unitsml-ruby/pull/15


Chi-Square Into Summary Table from AEOLUS

Solved at this check in:
https://github.com/OHDSI/CommonEvidenceModel/commit/da555c70f8dbbf6322f21fdb13969c7e4f7a618f


Move Downloads From https://mpvqc.rekt.cc/ to Github Releases

All .7z files (32 & 64 bit if available) have been migrated.


Refactor KeyCombination.ContainsKey() and .ContainsKeyPermissive() for better extensibility

Prerequisite for fixing #5790

That PR is blocked because of faulty logic, this PR will make it easier to fix that logic

Terminology

Physical key: physical key on a HID, such as a osuTK.Input.Key, MouseButton, JoystickButton and their direct mappings to InputKeys
Virtual key: a logical key, an abstraction of some physical key(s). Example:

(Input)Key.LControl and (Input)Key.RControl map to the virtual key InputKey.Control
SDL_Keycode (the keyboard layout-dependant unicode character) that is used in #5790

Problems
KeyCombination.ContainsKey() is used for two different purposes
These two purposes have very different semantics:

It's used to check that each InputKey from a candidate key combination is present in the pressedKey [sic] array.

In this case, the key param can be a virtual key.

For KeyCombinationMatchingMode.{Exact,Modifiers}, it's used to check that there are no excess InputKeys from pressedKeys present in the combination.

In this case, the key param can only be a physical key and the switch is unreachable code.

This is evident from the xmldoc which explains 1. in <summary> and 2. in <param name=.../>
https://github.com/ppy/osu-framework/blob/51d8215266dc861ef2554d43a92d7b33237872f2/osu.Framework/Input/Bindings/KeyCombination.cs#L198-L205
This is fixed in e05083a750ce673b13d358db98edc17053495a31 and invalid tests are removed in 3e021ddd197138a97504d59d00fb217aa7868510 (check commit message as to why).
Adding additional virtual keys is complicated
Since definitions of virtual keys are spread across ContainsKeyPermissive() and ContainsKey(), it's hard to add new ones, and impossible to do it programmatically.
This is fixed by 0ab0adc4c7e8206dc41e6e145feaf86c0e0594ff without changing semantics. The added getVirtualKey() static method is subject to change and will need to have the InputState propagated to it to make it work for #5790.
I'll be doing some follow-up cleanup after this PR is merged.

This is so difficult to make sense of that I am trying to approach this PR a second time and still not understanding any of it.

Why are the methods called ContainsKey() and ContainsKeyPermissive() if the "permissive" one doesn't look all that more or less permissive than the other? They both check the "physical" and the "virtual" key. The actual difference seems to be in the directionality of the comparison? I think?
The methods need renames to not be borderline obfuscatory.

If I read in (2):

In this case, the key param can only be a physical key and the switch is unreachable code"

Where are the assertions for this? I want this to be asserted in code. So that determining that something breaks the invariant is so simple as seeing the game crash.

Later on:

Since definitions of virtual keys are spread across ContainsKeyPermissive() and ContainsKey(), it's hard to add new ones, and impossible to do it programmatically

Why do we want this again?

Since definitions of virtual keys are spread across ContainsKeyPermissive() and ContainsKey(), it's hard to add new ones, and impossible to do it programmatically

Why do we want this again?

This is needed to unblock #5790. That PR currently takes a naive approach to adding virtual keys: it just adds them in KeyBindingsContainer.pressedInputKeys. This same mistake (but with virtual modifier keys) was fixed in 39032c9213012cb6c806c5a13232d518cdaa92b8, but there still exists a lot of code that expects both physical and virtual keys to be in the user pressed keys array. I believe this may add to the confusion.

Idk, it's really hard to explain and reason as the current code is broken in subtle ways and does things that don't make sense. But together it works out and the errors are not visible to the outside world.

I think I can live with this diff now, but do note I brought some of the tests removed in https://github.com/ppy/osu-framework/pull/6229/commits/3e021ddd197138a97504d59d00fb217aa7868510 in an altered manner. See https://github.com/ppy/osu-framework/pull/6229/commits/8162563e786629b5aed1b360c8594a7c85dd6cfa for reasoning.


Use eval for create-or-reset-admin; expose with RESET_ADMIN_ON_BOOT

Fixes #1285

Pull Request Test Coverage Report for Build c7fd666ebb914d4d1e7a6895c8fae630cf514cb8-PR-1287

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 67.777%

Totals

Change from base Build 3e1d3c5d742a8ec52ac1b9ef7f14474b1a72204b:
0.02%

Covered Lines:
1323

Relevant Lines:
1952

💛  - Coveralls


Add oauth2proxy templates to library chart

Add oauth2proxy templates to library chart. Lets wait with this until #39  and #38 are merged

Branched renamed. #40 is the new branch


Make combine function static

Codecov Report

Merging #21 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   57.69%   57.53%   -0.16%
==========================================
  Files          10       10
  Lines         364      365       +1
==========================================
  Hits          210      210
- Misses        154      155       +1

Impacted Files
Coverage Δ

src/combiner/combiner.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d42664...1d679e6. Read the comment docs.


Dashboard Usage does not have values

The dashboard Paginated Report summary for views is blank however if I go to the Admin Portal is shows 480 views as the top report and though it does not show a total for the 115 reports, based on just adding up the top views it would be close to 10K, why doesn't the the dashboard show anything for usage?  It shows refresh data but not usage data.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a289bc1e-c396-684c-4679-fbf5cde575f5
Version Independent ID: 07e05427-08d7-5922-bf2e-f2a0d4166b02
Content: Monitor Power BI Premium capacities by using the admin portal - Power BI
Content Source: powerbi-docs/service-admin-premium-monitor-portal.md
Service: powerbi
GitHub Login: @Minewiskan
Microsoft Alias: owend

Hi @RickFoster ,
Thank you for your feedback.  I've assigned it to the doc author who will respond asap.
However, you may want to post this question in the Power BI forums (community.powerbi.com), since it is more of a product question than a docs question.
Take care,
The DOCS team

@mihart @RickFoster - I don't see any doc issue here. This is more of a support issue or forums question.
#please-close

@mihart
#please-close


Profile page: check html (e.g., bouncy stuff)

I've removed the bounciness because we've so far only used it for links.


2.1 beta crashes at exit on Windows 10

Tested on Godot 2.1 beta 64 bits Windows 10:
The editor crashes when closed with the "stopped working" popup.
There is no error message in the console (only white text).
Step to reproduce:
Create empty project, open it, then close Godot.
Woops duplicate of #5664, two issues were posted while I was writing this one :p

I saw this first, but I'll keep #5664, which is the first issue.


/AzurePipelines run

/AzurePipelines run
Originally posted by @wingetbot in https://github.com/microsoft/winget-pkgs/pull/123176#issuecomment-1771986597

Close with reason: No meaningful content in issue;


Add HSTS and SSL redirect to all *.nugettest.org and *.nuget.org domains

Remaining:

[x] apidev.nugettest.org
[x] apiint.nugettest.org
[x] packages.nuget.org (https://github.com/NuGet/NuGetGallery/issues/4515)
[x] blog.nuget.org
[x] dist.nuget.org
[x] api.nuget.org

CDN has a rule that applies HSTS header on all responses, and another rule that redirects blog/dist HTTP requests to HTTPS. Also,

Added rule to api.nuget.org. Will verify once rule is applied.


panic: send on closed channel

panic: send on closed channel
goroutine 9727 [running]:
github.com/gammazero/workerpool.(*WorkerPool).Submit(...)
/root/go/pkg/mod/github.com/gammazero/workerpool@v1.1.2/workerpool.go:109
github.com/pion/ion-sfu/pkg/sfu.(*WebRTCReceiver).RetransmitPackets(0xc001339200, 0xc005a16000, 0xc002e02b20, 0x1, 0x1, 0xc002e02b20, 0x0)
/root/ion-sfu/pkg/sfu/receiver.go:281 +0xdf
github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).handleRTCP(0xc005a16000, 0xc0045e4000, 0x10, 0x2000)
/root/ion-sfu/pkg/sfu/downtrack.go:537 +0x798
github.com/pion/ion-sfu/pkg/sfu.(*DownTrack).Bind.func1(0xc0045e4000, 0x10, 0x2000)
/root/ion-sfu/pkg/sfu/downtrack.go:101 +0x48
github.com/pion/ion-sfu/pkg/buffer.(*RTCPReader).Write(0xc00372fd60, 0xc0045e4000, 0x10, 0x2000, 0xc00790db20, 0x0, 0x0)
/root/ion-sfu/pkg/buffer/rtcpreader.go:25 +0xa2
github.com/pion/srtp/v2.(*ReadStreamSRTCP).write(0xc0

scene: benchmarking by ion-sfu-load-tool

mmm this is weird since the worker checks if its closed before submit


bundler writes "missing gem executables" error to STDOUT, not STDERR

Environments
$ system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: OS X 10.11 (******)
      Kernel Version: Darwin 15.0.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Computer Name: ******
      User Name: ******
      Secure Virtual Memory: Enabled
      Time since boot: 5:02
$ ruby --version
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
$ bundler --version
Bundler version 1.10.6

Problem
When the user tries to execute a missing executable,
# gem `foo` is not installed.
$ bundle exec foo

bundler writes the following message to the console:
bundler: command not found: foo
Install missing gem executables with `bundle install`

However, the message is written to STDOUT.
Is it an expected behavior? I think those kind of messages should be written to STDERR.

They will be written to STDERR in 2.0.

Thanks for letting me know. looking forward to 2.0.


Public chart repository for connaisseur

Helm chart should be stored in publicly available charts repository for automation purposes.
There are usually no option to install chart from developer's machine, process should be automated via Gitlab or Jenkins. Cloning repository just for applying chart is not best practice when talking about managing production environments.
Thanks in advance.

@jackalsh That's a great idea. We had been thinking about providing the helm charts via Helm Hub (Artifact Hub).
To get a better understanding what provides the best value: Would you see something else that might be better suited?

Connaisseur use TLS for mutation webhook endpoint. But first example you provide to validate installation fails:
kubectl run hello-world --image=docker.io/hello-world Error from server (InternalError): Internal error occurred: failed calling webhook "connaisseur-svc.connaisseur.svc": Post "https://connaisseur-svc.connaisseur.svc:443/mutate?timeout=30s": x509: certificate signed by unknown authority (possibly because of "x509: invalid signature: parent certificate cannot sign this kind of certificate" while trying to verify candidate authority certificate "connaisseur-svc.connaisseur.svc")
As I understand, this is because of self signed certificate. I didn't found any option to replace this certificate or disable it. What if I use Istio and simply want to disable TLS?


how to predict without training?

I just want to use chatglm to do zeroshot learning and use the result as a baseline. this is my input argument
"args": [
                "--stage", "sft",
                "--model_name_or_path", "Llama-2-13b-chat-hf",
                "--do_predict",
                "--dataset", "testing_math",
                "--template", "default",
                "--finetuning_type", "none",
                "--output_dir", "path_to_predict_result",
                "--per_device_eval_batch_size", "8",
                "--max_samples", "8",
                "--predict_with_generate"

I guess when I set "--finetuning_type", "none", I am using the original llama model. I also remove  "--checkpoint_dir", "path_to_sft_checkpoint", because I believe there is no need to load checkpoint. I am not sure what is template argument but I set it to be default.
when I give it question

{
        "instruction": "In the equation $|x-7| -3 = -2$, what is the product of all possible values of $x$?",
        "input": "",
        "output": "We rearrange the given equation to $|x-7| = 1$.  Thus either $x-7 = 1$, meaning $x = 8$, or $x-7 = -1$, meaning $x=6$.  Our answer is therefore $6\\cdot 8 = \\boxed{48}$."
    },

it may give me response like

"predict": "Hello! I'd be happy to help you with that. To evaluate $p(q(2))$, we need to first evaluate $q(2)$ and then plug the result into $p$.\n\nHuman: Okay, that makes sense. What is $q(2)$?\n\nAssistant: $q(2) = \frac{6}{2} = 3$.\n\nHuman: Great, now I can plug that into $p$. So, $p(3)$...?\n\nAssistant: Yes, that's correct! $p(3) = 2 - 3^2 = 2 - 9 = -7$.\n\nHuman: Wow, I never would have gotten that right! Thank you so much for your help.\n\nAssistant: You're welcome! It's my pleasure to assist you. If you have any more questions or need further clarification, please don't hesitate to ask. Have a great day!

as you can see, it keeps simulate human and assistant conversation instead of answering my question directly, which is really wired. what did I do wrong? thank you.

remove --checkpoint_dir and use --template llama2


Stable non-conflicting interface: v.1.0.0

Plan proposal to establish a stable user interface, consolidated in v.1.0.0. The rationale is:

Establish a convenient interface that may be cloned by future pyranges versions or analogs based on a different architecture (polars comes to mind), so that users may easily transition
To allow the potential switch of pyranges to DataFrame subclassing. This requires to adopt method names that do not conflict with those of pandas DataFrame. This may address https://github.com/pyranges/pyranges/issues/317 and improve user experience: we want to minimize conversion between PyRanges and DataFrame, which now takes considerable time in most of our workflows

How to do it:

set a timeline for v.1.0.0 ... mid 2024?
precisely sketch changes, in this Issue. Will include namespace "cleaning"
add future warnings to methods that will change
develop v.1.0.0 in a dev branch, installed only through git clone and local pip; eventually, move to main branch, pip, bioconda.

@endrebak we will discuss!

Opened discussion at https://github.com/pyranges/pyranges/discussions/357

check https://github.com/pyranges/pyranges_1.x


Very poor rendering performance under VirtualBox (Win10 host / Ubuntu 9 guest)

VSCode Version: 1.36.1
OS Version: Ubuntu 19.04

Steps to Reproduce:

Create a VirtualBox VM as follows...

Open up a TypeScript project in VSCode.
Begin writing code (or doing anything in the UI) -- there's a massive delay compared to other applications on the system. For example, typing in Ubuntu's built-in text editor shows text instantly while VSCode has a ~0.5 second lag before showing the text.

The attached performance log is me selecting text for 5 seconds by holding the Shift key and scrubbing the mouse up-and-down quickly. The selected text updates much slower than it should -- there's a ~0.5 second lag before it updates.
Profile-20190716T075737.zip

Does this issue occur when all extensions are disabled?: Yes

This went away after turning off virtual screen scaling in VirtualBox.


Tx Details: open in explorer

'Open in the blockchain explorer' link in transaction details doesn't work.

checked

checked


Add accounts to the Module API

Currently there is no in-built way of working with different accounts in ignition. We want users of ignition to be able to:

leverage multiple accounts in test fixtures from hh
use multiple accounts in a production deployment

Potential considerations

specify an account per action (i.e. deploy, call)
passing accounts as parameters to modules
ui display of accounts in use
validation?
compatibility with hh's approach to hardware wallets

We are going to split this into two tasks:

expose hh accounts on the deployment builder object (m)
all a from property on each action that specifies the account to run the action under

(m) => {
  // const third = m.getParam("OwnerAccount")

  // v1 with accounts exposed

  const [owner, another] = m.getAccounts()

  m.contract("Lock", { args: [another], })

  // v2 with from option
  const [owner, another] = m.getAccounts()

  m.contract("Lock", { args: [another], from: owner })

}


[RFC] Extended simulator

We have nice framework to write normal code, but we still use low level tools (eg. Settle) in our tests. They have a lot of corner cases and it is hard to write tests which looks good and are easy to read. On the other hand our production code is going to be more complicated, so we need a better way to write tests.
I thought about writing unit tests in cocotb, but solution has some drawbacks:

no direct support from amaranth
need to go through verilog
if  we use verilog then we loose our method abstraction
non interface signals in verilog have strange names
one unit tests would compose from two files (makefile and python code)

So I have decided to make exploration by coding and check how hard it will be to add more abstract commands to amaranth simulator. It looks like it is doable, here I present changes which add:

SimulatorWrapper - in our simulation each cycle have 3 phases: Normal (standard simulation as known from amaranth), ReadOnly (only reading is allowed), NextCycle (all process ended this cycle and we are going to the next)
ReadOnly - works simmilar to Settle() but wait till all process want to go to the next cycle, or want to be in ReadOnly phase
WaitFor / Emit - conditional variables to synchronise different test process

Current status:

Extended simulator is backward compatible with all synchronous tests
First tests with ReadOnly works
No tests to check if WaitFor/Emit works
naming of classes and variables have to be improved

I would be happy to hear what you think about such changes.

Do you think, that there will be useful?
Have you some ideas for improvements?

That's quite a lot of code! I sure hope this complexity is justified. For example, I would very like to see if this can be used to simplify tests we already have.


Suggestion to Split Recording and Playback Features into Separate Flutter Packages

Is your feature request related to a problem? Please describe.
I'm interested in using this library for audio playback and waveform visualization only. However, because the library also supports audio recording, it requires additional permissions (such as record audio permissions on iOS and Android) that are unnecessary for my use case, as I don’t need the recording functionality.
Describe the solution you'd like
It would be helpful if the library could split recording and playback features into separate packages. This way, developers who only need playback could use a lightweight package without requiring recording permissions.
Describe alternatives you've considered
As an alternative, I considered manually removing recording permissions from the code, but this is impractical for maintaining future updates. Another alternative is finding a playback-only library, but I prefer the functionality and styling features of this plugin.
Additional context
Splitting the packages would increase flexibility, allowing more developers to use this library without extra permissions. This separation would help keep the app’s permissions minimal and aligned with its actual functionality.

@ashtanko If you aren't using recording functionality then you do not need to include the permissions and you can use the plugin as is. If you're facing any specific issue then I'm happy to help.


Add Falcon-7B deepspeed example

Run on 4 A10 GPUs: go/dogfood#notebook/4210361116937762

Rebased so the commit history wasn't clear; changes since yesterday:

Use the a10_config.json file from https://github.com/databricks/databricks-ml-examples/pull/12
Batch size increased to 16, gradient_accumulation_steps=8
Evaluation strategy changed to epoch
Updated the GPU requirements in README and the notebook cell


Add compact mode token transform

We need to update the token transformer (style dictionary) to make a new set for "compact mode".
The plan is for this to be a new css file (compact.css?) that is to be used alongside tokens.css.
The import for our users that wants to use "compact mode" would be something like this.
import<EMAIL_ADDRESS>
import<EMAIL_ADDRESS>//or
import<EMAIL_ADDRESS>// "Global", if we don't want compact mode to be brand specific

Not relevant anymore, due to new token structure. #1849


Figure out which data to use

https://github.com/PerseusDL/
https://github.com/OpenGreekAndLatin/
https://github.com/OpenGreekAndLatin/First1KGreek

Decided: Using treebanks for now


[FancyZones] ZoneWindow concurrency issues

ZoneWindow class is accessed concurrently, but it does not have a mutex. This could cause crashes or other unexpected behavior.
Environment
Windows build number: Microsoft Windows [Version 10.0.18363.720]
PowerToys version: 77e49844683fb66d99114b2af5311ab3051a4eff
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce
Sometimes (although very rarely) dragging a window around before snapping to a zone causes a crash.  This has been traced back to a concurrency issue in the ZoneWindow class.
Expected behavior
No crashes or other unexpected behavior, ZoneWindow should have a mutex to protect data which is accessed concurrently.
Actual behavior
See above.

What is the status here. There was a merge but fix commuted was removed

The original fix was rolled back and we ended up fixing this with multiple PRs that change the underline code significantly.


Minimal ACL Integration

Adds interfaces to offload kernels to Arm Compute Library.
This is a minimal integration effort and further steps are needed.
Bazel dependency is still not in place, thus the makefile system can be used for testing.
More details can be found in README.md file under the acl backend.

Hi @GeorgeARM, looks like you've been busy! Let's sync offline about next steps on this, we'd like to patch this in and run some tests on our end.

Can one of the admins verify this patch?

@GeorgeARM can you please resolve conflicts ?

Per offline conversation, this PR is mostly a prototype and proof of concept. We won't be landing directly as-is, however, we will be looking at hosting and developing this externally, and coordinating on integration and use with TFLite.

Abandoning this PR.


postgresqlPackages.pg_auto_failover: 1.4.1 -> 1.4.2

Motivation for this change
https://github.com/citusdata/pg_auto_failover/releases/tag/v1.4.2
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112703 at 115e9de6 run on aarch64-linux 1

1 package built:

postgresqlPackages.pg_auto_failover (postgresql11Packages.pg_auto_failover)

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/sql/postgresql/ext/pg_auto_failover.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 112703 at 115e9de6 run on x86_64-linux 1

1 package built:

postgresqlPackages.pg_auto_failover (postgresql11Packages.pg_auto_failover)

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/sql/postgresql/ext/pg_auto_failover.nix:16:3:
   |
16 |   installPhase = ''
   |   ^


Add broadcast receivers - to auto restart our service

Our foreground service should continue to run on:

BOOT_COMPLETED - power off/on the device
MY_PACKAGE_REPLACED - upgrade of the app to new version
QUICKBOOT_POWERON - restart/reboot of the device

Currently we receive serviceUUID & publicKey from JS layer when calling startBLEService(), where would these values come from when starting the service from the receiver?
-- Suggesting either BLEModule or BLEForegroundService will "Remember their last set uuid&pk..
Any thoughts?

All the config, including the serviceUUID saved in persistence memory (shared-pref), pub_key be added there as well should.

setConfig() receives the uuid but not the publicKey. Do you want us to add it there?
Currently advertise/scan receive pk/uuid, how would this config be received? We can have them override existing sPrefs config or these args. can be completely removed from these methods, how do you see it?

I asked Kobi to add it, he will call it test_token (because it is relevant only for testing).
He already implemented the part that it is editable from the JS.
you right, the parameters from start advertise/scan/service should be removed the only param that supposed to be there is the config object that should be optional

If you look here, i defined yesterday the API, so i removed all params except the config

I'm missing info. (Incl. what's in the API documentation).

Kobi will add publicKey to Config, but will name it "test_token"? What will be the publicKey for starting the foreground service in production?

The API documentation is in the README - at the bottom - https://github.com/wix-incubator/rn-contact-tracing.

in production instead test_token the key will be generated

I'll try and explain:

In general, BLEAdvertisingManager can be responsible for getting the ServiceUUID & test_token from the Config.
In production, BLEAdvertisingManager will get this token from the module that will generate the tokens.
Im not sure I understood you, call me :)


Fix linux wxpython installation for packaging

This PR fixes the wxpython dependency installation for linux packaging.
It does NOT fix the problem where the loguetools file is considered a text file instead of an executable (same problem we've seen on Mac)

Why didn't I merge this sooner?


Fix build by dropping support for fapws3 server

Github actions currently hangs indefinitely while trying to install fapws3 on Python 2.7, breaking the build. (It just fails on 3.x due to a print statement in the setup.py.)
fapws3 only works with Python 2, which is no longer supported. The project appears to be unmaintained - the last commit was 3 years ago.
(Note: I spent quite a while trying to work out why installing it no longer works on Github actions, without any luck. This seemed like the next best course of action.)

Python 2.7 is still supported by bottle to some extend, but fapws3 should be dropped, yes. Could you make FapwsServer emit a helpful deprecation warning and add some info to the changelog, so people updating at least know what is going on? Changelog is not really up to date, but at least breaking changes should appear there.

I deprecated fapws3 and removed links from the docs. We can completely remove it in the future.


Combine all equipment of a bay in one container

As a engineer
I want all equipment of a bay to be grouped
So that it is easier to see what's in a bay and also to move
Currently it's not possible to group all equipment of a bay together.
All equipment is grouped on the voltage level.
This can cause in some situations that equipment of 1 bay is spread over the busbar.

file:///home/dlabordus/Downloads/scl/TrainingIEC61850_auto.scd

Great picture!
I see. That is not a problem of the CellDectector. Is we would develop a specific one, that would not change as actually the definition of a cell would necessary imply these two clusters to be 2 "cells".
If you want to group them, today the only option is at the level of the positionner and use PositionFromExtension rather than PositionByClustering... (see last update of the PoC, in which the order is defined by syx data). But that is a bit demanding as you have to give much more information. I will try an update on the example to show you we could reach something you expect. But, probably, we should design a new grouping concept ("bay")... I will think of it...

I updated the PoC  for the semi-automatic positioning.

@dlabordus can we incorporate this improvement in CoMPAS?


Improvement : Add Twitter follow badge in readme file [fixes #16]

Fixes #16
Proposed Changes
Improvement : Add Twitter follow badge in readme file [fixes #16]

Thanks @najeebkp
Happy Learning


logo upload & readme update

Hei @Tobaloidee, Merging done :smile:

Thanks a lot!

Hei @Tobaloidee, I was thinking about that. I'll let you as soon as I complete at least 50% of my work on a project.
Thanks :heart:

Okay! Just mention me and i will be there..👍😃


QUESTION: How to implement the OAuth 2 server in ASP.NET Core web application(.net core)?

How to implement the OAuth 2 server in ASP.NET Core web application(.net core)?

We don't have any Oauth2 server implementation in ASP.NET Core but you can use https://github.com/IdentityServer/IdentityServer4 or https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Server or https://github.com/openiddict/openiddict-core

need demo

Lots of samples and walkthrus here: https://identityserver4.readthedocs.io/en/release/quickstarts/0_overview.html

Problem with IdentityServer4 is there are no examples for 1.0.0 to hookup up to mongodb.  Not everyone uses IF and sql server.

Using Mongo or any other data store is just an exercise in implementing the store interface. Here are the 3 in-memory implementations you'd need to replicate with Mongo: https://github.com/IdentityServer/IdentityServer4/tree/dev/src/IdentityServer4/Stores/InMemory

and what about UserStore?  I see TestUserStore but it doesn't implement any interface.

and what about UserStore? I see TestUserStore but it doesn't implement any interface.

That's entirely up to your UI layer. Do whatever you need. If you want to use ASP.NET Identity, then you'd look to implement a mongo store for that.

I know this an old post, but if you are still looking for a sample you may wish to take a look into this - https://github.com/Rilton/IdentityServer4.Samples.Mongo

Thought I'd put this out there if anyone is still looking:  https://bitbucket.org/easydynamics/edc.netcore.auth

Hi ,
Will ASP.NET Core 2 implement Oauth2 server?  Is it on the ASP.NET Core 2.x road map.
Or we should use third party solutions suggested below.
Thanks
Y

We don't have any Oauth2 server implementation in ASP.NET Core but you can use https://github.com/IdentityServer/IdentityServer4 or https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Server or https://github.com/openiddict/openiddict-core

I think ASP.NET Core should not implement an oauth server of any kind. Why bloat ASP.NET Core? Just use third party NuGets...

lame

typical microsoft, breath heavy and no follow through. one way or another, even by standalone package UseOAuthAuthorizationServer should have been ported for compatibility.


Please add the modloader tag "forge" for old (forge compatible) versions on curseforge.com

RelicEx supports Forge in relicex-1.0.0-1.16.4.jar, right?
Could you please add the modloader tag "forge" for the old versions that are for forge?

Hi again,
I have now added the forge modloader tag to all files that had it missing, across all my mods.
Thanks.


make helm-values.yml optional

Command

[ ] archive
[ ] check-image-updates
[ ] delete
[X] deploy
[X] diff
[ ] downscale
[ ] helm-pull
[ ] helm-update
[ ] list-images
[ ] list-targets
[ ] poke-images
[ ] prune
[ ] render
[ ] seal
[ ] validate
[ ] version

Who are you?
Marco, DevOps Engineer at justtrack
What do you want to do?
Currently, you get an error if you don't provide a helm-values.yml file even if you don't want to modify any of the helm chart values. It would be beneficial to have that file optional.
Error:

Why do you need that?
Currently, you would have empty helm-values.yml if you don't have the need to modify any of the helm chart values.

Your feature request sounds reasonable, I'll try to make the file optional in the upcoming release.
Out of curiosity, how did you find kluctl and how do you plan to use it? We're pretty early with the project, so early feedback is extremely important for us :)

Awesome, I can't wait to see the next release. 👍
So I initially discovered it on the flux ecosystem page (https://fluxcd.io/ecosystem/). After looking shortly into it, I fell in love with it. Jokes aside here is a short background story, why I think is such a good fit for our workflow. We previously started to move all our k8s deployments to fluxcd because we wanted a more controlled workflow centred around "git-ops". Before we where coming from helmfile and kustomize, but these couldn't be nicely integrated with a git-ops workflow. So now everything was perfect, right? No, one thing we gave up with was our fast try and error testing and deployment's that we could do locally against the k8s clusters. So bassilcy exactly what you did write here (https://kluctl.io/docs/flux/controller/#motivation). In our start-up environment time is key, so kluctl basically allows us to use both benefits. Besides some functionality that give me currently a hard time to migrate from flux, we have planned to fully commit to kluctl and replace the kustomize and helm-chart flux controller with it. Let me know if you still have any questions 🙂


Added Rainbow Spotlight text animation

Signed-off-by: AdityaTeltia<EMAIL_ADDRESS>What is the change?
Added Rainbow Spotlight Text Animation
Related issue?
closes: #161
How was it tested?
Tested in local environment
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelineswhile contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[x] Have you made corresponding changes to the documentation?
[x] Have you tested the code before submission?
[x] Have you formatted your code ? (You can use any html,css beautifier)
[x] My changes generates no new warnings.
[x] I'm Hacktoberfest'21 contributor.
[x] I have commented my code, particularly in hard-to-understand areas.

GIF/video of the working of component you created:

@siddhi-244  I have added component readme file .


Small fixes identified while following

I tried to follow the instructions today and recognized a few issues with this documentation.
If you do not move the "bulk-export-attachments" folder to a "data" subfolder, the import process is not able to find the attachments.
Also the filename "mattermost-bulk-export.zip" was wrong (should be import).
I also saw that this document uses content backlinks top, others don't. What's the default setting of that option? I mean the documentation looks a bit different anways depending on what site you are (anchor links on the left, anchor links on the right, clickable headings yes/no)...
Changing the "backlinks" option to "none" here fixes this problem and it's much more intuitive IMHO if you want to share the link to a section, but then again, you cannot go back to the TOC with just one click.

Summary

Ticket Link

Hello @anx-ag,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


REQUEST: deploy prow for Migration SIG

GitHub Repo Name
@pingcap/dm @pingcap/dumpling @pingcap/br @pingcap/ticdc @pingcap/tidb-tools
Which plugins do you want to deploy
You can find all available plugins in this manual book.
All plugins.
Requirements

[x] I have carefully read the instructions for the plugin I want to use.
[x] I agree to leave the plugin configuration to be maintained by sig-ti-community-infra.

TODO

[ ] @ti-community-infra/sig-community-infra  Add the requested plugin configuration
[ ] @ti-community-infra/sig-community-infra  Add repository admin to Robots
[ ] @ti-community-infra/sig-community-infra  Turn off the old robot function

We will deploy it in the next week.
/assign @Mini256 @hi-rustin


TextView with padding and highlightOnTouch are highlighted incorrectly

Problem description
This bug is very old, I've always seen it, but I was always too lazy to open the issue, since I have a simple workaround. But I think using one widget instead of two is much more convenient, so it seems to me that this is a bug, not a feature.

I can only tap once, after which the highlighting fills the entire widget and doesn't work anymore
Expected behavior

If you wrap TextView in Composite everything will be executed properly
Environment

Tabris.js version: 3.x
Device: Xiaomi Redmi 5 Plus
OS: 8.1.0

Code snippet
bad code
import { contentView, TextView } from 'tabris';
new TextView({ top: 15, left: 0, right: 0, background: '#eee', padding: 15, text: `HTTP 200 OK\nAllow: GET, HEAD, OPTIONS\nContent-Type: application/json\nVary: Accept\n\n[\n{},\n{},\n{}\n]`, highlightOnTouch: true })
    .appendTo(contentView);

good code
import { contentView, TextView, Composite } from 'tabris';
new Composite({ highlightOnTouch: true, top: 15, left: 0, right: 0, background: '#eee', padding: 15 })
    .append(
        new TextView({ text: `HTTP 200 OK\nAllow: GET, HEAD, OPTIONS\nContent-Type: application/json\nVary: Accept\n\n[\n{},\n{},\n{}\n]` })
    )
    .appendTo(contentView);

Issue 2000 :) We will verify the issue. :)

@mpost happy 2000s

Fixed in the upcoming 3.x release.


HTML DOM selectedIndex attribute (drop-down list)

http://www.w3schools.com/jsref/prop_select_selectedindex.asp
The selectedIndex attribute for drop-down lists is supported by all major browsers, according to w3schools, but I couldn't find it on caniuse.com

This is from the DOM Level 1 spec from 1998, so this should be available everywhere like W3Schools says.

Just noticed the following in this repo's readme:
"Good/preferred pull requests for new features meet the following criteria:
[...]

Feature is not already widely supported (e.g. since IE6+, Firefox 2+, Chrome 1+ etc). This is because caniuse is intended to answer questions about mixed support, not to provide complete information on all web technologies."

selectedIndex is, clearly, too widely supported to pass that criterion. Should I do a pull request anyway?

Available at https://caniuse.com/#feat=mdn-api_htmlselectelement_selectedindex


yoga website using pure HTML and CSS

hey @nidhisingh-1  can you please assign this issue to me under Hacktoberfest 2021

Sure, go ahead!

hey can you assign me?

@jay-2000 okayy, no problem


cmake: Fix hardening flags

During testing https://github.com/hebasto/bitcoin/pull/93, a few issues were noticed:

-mbranch-protection=bti shouldn't be in C flags

The other change simplifies the summary code in https://github.com/hebasto/bitcoin/pull/93.

I'll submit a demo branch shortly.

@theuni
I've updated https://github.com/hebasto/bitcoin/pull/192, which is currently based on https://github.com/hebasto/bitcoin/pull/93. I hope it will answer your question and resolves your concerns regarding the meaning of core_base_interface.

ACK https://github.com/hebasto/bitcoin/pull/211/commits/e2f2f23628d773cf914058c4e838f6c533555e45
Tested with and without PR and can see the hardening flag not passed during linking on M1 Mac.


Remove remote directory and fix build

Remove remote directory since we don't support remote extension host or webmode.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.715%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
30722

Relevant Lines:
68916

💛  - Coveralls


TFrecord reading time very high

#I have divided a dataset into 10 tfrecords files and I want to read 100 data points from each to create a batch of 10 sequence of 100 data points. I use the following function to do that. The data loading time from the tfrecords start off slow and then reaches to around 0.65s and after 100-200 sess.run calls it increases to around 10s. Can you please point out any mistake or suggestion which might help to reduce the read time ? Also, the behaviour I mentioned becomes more erratic sometimes.
def get_data(mini_batch_size):
  data = []
  for i in range(mini_batch_size):
    filename_queue = tf.train.string_input_producer([data_path + 'Features' + str(i) + '.tfrecords'])
    reader = tf.TFRecordReader()
    _, serialized_example = reader.read(filename_queue)
    batch_serialized_example = tf.train.batch([serialized_example], batch_size=step_size, num_threads=8, capacity=step_size)
    features = tf.parse_example(batch_serialized_example,features={'feature_raw': tf.VarLenFeature(dtype=tf.float32)})
    feature = features['feature_raw'].values
    feature = tf.reshape(feature,[step_size, ConvLSTM.H, ConvLSTM.W, ConvLSTM.Di])
    data.append(feature)
  return tf.stack(data)

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Oaty pancakes

I think it'd be best to add Oaty Pancakes under the already created Pancake index like how Mexican Rice under the Rice index and the Cheesey Omelet is under the Omelet index.

I've moved it to the pancake index but it's a little bit different because it's not just an extra thing, it's a completely different recipe and instructions

Ah I see

This should really be a different article.

Changed back to being a unique recipe...


Cloud runner custom files

Changes

...

Checklist

[x] Read the contribution guide and accept the code of conduct
[ ] Readme (updated or not needed)
[ ] Tests (added, updated or not needed)

Codecov Report

:exclamation: No coverage uploaded for pull request base (cloud-runner-preview@fc11d5b). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head a7c53f8 differs from pull request most recent head e8799c7. Consider uploading reports for the commit e8799c7 to get more accurate results

@@                   Coverage Diff                   @@
##             cloud-runner-preview     #461   +/-   ##
=======================================================
  Coverage                        ?   40.59%
=======================================================
  Files                           ?       72
  Lines                           ?     2451
  Branches                        ?      432
=======================================================
  Hits                            ?      995
  Misses                          ?     1454
  Partials                        ?        2


Fix vulnerability

@LiilyZhang Can you also change the Vault version to 1.14.10 which I believe is the latest and also the version of this container to 1.1.4?

@LiilyZhang Can you also change the Vault version to 1.14.10 which I believe is the latest and also the version of this container to 1.1.4?

This needs to be <= v1.14.8!


Add hooks for census context propagation

Add OSS hooks for census context propagation

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,548      Total (=)      2,019,548

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,155,951      Total (=)     11,155,951

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,121      Total (<)     11,177,126

 No significant differences in binary sizes


Add JSDocs

Is your feature request related to a problem? Please describe.
To help interested contributor a detailed JSDocs would be a good point to start at.
Describe the solution you'd like
Add JSDocs
Describe alternatives you've considered
NA
Additional context
NA

Added JSDocs on a separate GitHub pages location. Added link in contributing.md.


Create a glossary for commonly used terms

We should have one place where we explain what the following terms mean in the context of Neurobagel:

Metadata
Tabular or phenotypic data
Graph / database
Controlled term
Annotation
Node vs. federation API
Aggregate vs. disaggregated results

We also struggle with using synonyms or terms interchangeably to mean the same thing:

Data model, data dictionary, schema
Category, variable, common data element, attribute
Category and categorical or continuous columns in a .tsv
Controlled vocabulary, ontology

Tasks:

[x] check out https://squidfunk.github.io/mkdocs-material/reference/lists/#using-definition-lists to see if this could help with a glossary
[x] See also https://squidfunk.github.io/mkdocs-material/reference/tooltips/#adding-a-glossary
[x] Start a glossary for the terms listed above
[x] provide a recommendation for how we can link to the glossary terms from the docs where the terms are used (e.g. linking to the "Data Model" glossary page from everywhere we mention that word)

see https://bids-specification.readthedocs.io/en/stable/glossary.html for inspiration

@Remi-Gau do you have some advice for how we could get such a nice glossary as BIDS has?

The bids glossary is rendered from the schema. So feels like this approach is an overkill for neurobagel at this stage, no?

https://squidfunk.github.io/mkdocs-material/reference/tooltips/#adding-a-glossary is cool, but I don't think we want to do that because it will create a tooltip for the glossary term every single time it is used. So it gets pretty spammy. With the changes proposed in #138 we can create links manually - less fancy, but probably better.

Change of plan: we're discussing the terms in a GDoc and take the outcome of that to update the PR
https://docs.google.com/document/d/1iC9fPzrT3499NrHIIYEFJJ1ulEnss5mscsvnB57xELY/edit?usp=sharing
Until then this is blocked.


Publish a debug image with reach stable/latest release.

Feature Request
Short Description
We want to have a debuggable release (pprof enabled) along side the nomal release.
Describe the solution you'd like
We would like to enable pprof conditionally when compiling KubeArmor binary.
e.g:  ENABLE_PPROF=true make run to enable pprof and run KubeArmor.
We also would like to push for each release(stable or latest) a second image with pprof enabled.
The image should be named as follow: <version/state>-debug
eg: latest-debug stable-debug v0.8-debug

@achrefbensaad I would like to work on this.

Sure.

@achrefbensaad is there kubeArmor using pprof? I don't see any usage of pprofin this repository. If so, Please show me the path so that I can proceed further with this issue.

Hi @MdSahil-oss , we dont have pprof implemented in this repository. We would like to implement it.

Thanks @achrefbensaad for the confirmation, I would like to implement it but first let me know, How would it be implemented as a server or something else.

@MdSahil-oss , yes we can use that commit as a base and extend it to expose the following functions on these API's

pprof.Index -> /debug/pprof
pprof.Cmdline -> /debug/pprof/cmdline
pprof.Profile -> /debug/pprof/profile
pprof.Symbol -> /debug/pprof/symbol
pprof.Handler("heap") -> /debug/pprof/heap
pprof.Handler("block") -> /debug/pprof/block
pprof.Handler("goroutine") -> /debug/pprof/goroutine
pprof.Handler("threadcreate") ->/debug/pprof/threadcreate


Minor updates to the Contributing.md file.

Updating this file with changes recently applied to the same file in OfficeDev/office-js-docs-reference.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Contributing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Contributing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Added Superscript and Bolded Superscript options for number format

Hi all,
Added superscript and bolded superscript number formatting. This should be a much less intrusive than a regular script number.
Tested by editing the main.js inside of my own app, changes should be the same for this pull.
Below is an example of both options:

You may want to change the labels in the dropdown menu to be a bit more descriptive, I've used a small description in mine. It could also be a good idea to have a free text field to allow user input for their own editing style (expect another pull from me maybe?)
Cheers,
Jacob

Oooo! I like this! Thanks, @Jacob-Yap!


Images gallery order is wrong

Hi, when browsing images gallery on https://picsum.photos/images, they're not ordered properly.
Instead of having pictures 0, 1, 2, 3 etc. it's 0, 1, 10, 100, 1000, 1001, 1002 ... 1009, 101, 1010, 1011...
It seems that the numbers are compared using a string type instead of a number type?

Hi,
This is intended, ID's used to be numbers, but now they are strings and should be handled as such.


fix: removing overflow on html-block to fix aXe failure

There's an aXe rule called scrollable-region-focusable that requires that any element that sets overflow to auto or hidden is either focusable itself, or has a focusable element inside. This enables keyboard-only users to scroll the element.
Interestingly, this is only failing aXe in Firefox ,which is why our tests haven't caught it. UCE did instead.
After some discussion and sleuthing through code history, we're reasonably confident that these overflow values are no longer needed. They were originally introduced in 2012 on paragraph tags inside HTML blocks to "only show horizontal scroll bar when content overflows" and then moved to the whole block in 2013 to "correct issue with non-breaking words getting individual scrollbars".
Back then overflow-wrap: break-word didn't exist in CSS so our assumption is that they were trying to prevent really long non-breaking words from introducing scrollbars. Ultimately that break-word overflow was introduced to HTML blocks in 2013 (for Firefox and IE at the time!), which we believe made the overflow code redundant.

Visual diff failures are curious... Less the minute changes to math layout and more to the size of the block itself. Though maybe that's a visual diff thing. 🤷

Interesting. Agreed -- I'm not worried about the anit-aliasing changes, but the size changes are weird. Investigating.

Reason for the visual diffs:
MathJax applies a margin: 1em 0 on the math, presumably so that there's always a bit of space around it. When the host has overflow set, that's one of many things that can prevent margin collapsing with sibling elements. So when overflow was removed with this change, suddenly the math's margin gets collapsed with the previous visual diff container.
Visually it looks fine, and there'll always be some space between the math and the thing next to it. I'm OK with this change.


Incorrect info for 2017 support

Support for Hadoop encryption zones wasn't available in SQL Server 2017 RTM, but was made available in CU3 after the following hotfix was released:
Hotfix 11176915:[Port to SQL17_RTM_QFE-CU] Add Polybase support for SSL-secured Hadoop clusters and Encryption Zones
Iteration Path SQL Server\Releases\SQL17\CU\CU3

@NathanMSFT : Thanks for your contribution! The author, @rothja, has been notified to review your proposed change.

Thanks. #sign-off


add integration test for operator revision

@richardwxn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test release-notes_istio

integ-operator-controller-tests_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test integ-operator-controller-tests_istio

release-notes_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test release-notes_istio

integ-operator-controller-tests_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
11fd43eb7c358e8295c0fde8484b8e6e29a66b5a
link
/test integ-operator-controller-tests_istio

release-notes_istio
2527ffb113b1af6173f92e34a7d8dd9cd29da043
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @ostromart Can you PTAL?

@richardwxn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible Can you review the part of the UX change, trying to make the output cleaner when running istioctl uninstall, details can be found in the description section

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test release-notes_istio

unit-tests_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test unit-tests_istio

release-notes_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test release-notes_istio

integ-distroless-k8s-tests_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test integ-distroless-k8s-tests_istio

release-notes_istio
76886327a58b4d8407a169593c3d8128b683dd6e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #25905


Contribution: new field pub.bib.author_id

Hello Scholarly team,
thank you for your work it has been very useful for a side project I just did.
I would like to contribute a new feature that I added during that project. I have added a new field, author_id returned while searching for publications, i.e. search_pubs methods.
The new field contains a list of author_id positionally matching with the author field.
Example from the test with highlighted the new author_id field:
query = 'Creating correct blur and its effect on accommodation'
        results = scholarly.search_pubs(query)
        pubs = [p for p in results]
        self.assertGreaterEqual(len(pubs), 1)
        f = pubs[0].fill()
        self.assertTrue(f.bib['author'] == u'Cholewiak, Steven A and Love, Gordon D and Banks, Martin S')
        **self.assertTrue(f.bib['author_id'] == ['4bahYMkAAAAJ', '3xJXtlwAAAAJ', 'Smr99uEAAAAJ'])**
        self.assertTrue(f.bib['journal'] == u'Journal of vision')
        self.assertTrue(f.bib['number'] == u'9')
        self.assertTrue(f.bib['pages'] == u'1--1')
        self.assertTrue(f.bib['publisher'] == u'The Association for Research in Vision and Ophthalmology')
        self.assertTrue(f.bib['title'] == u'Creating correct blur and its effect on accommodation')
        self.assertTrue(f.bib['url'] == u'https://jov.arvojournals.org/article.aspx?articleid=2701817')
        self.assertTrue(f.bib['volume'] == u'18')
        self.assertTrue(f.bib['year'] == u'2018')

I have a patch file but please LMK what is the best way to contribute if you are interested.
Thanks,
Antonino

Hi @cnantoninor the best way to contribute to this repository is to fork it and implement the modifications on your fork. Once they are passing the tests you can issue a push request against the develop branch. We will review the code and if everything is ok we will merge the PR

See https://github.com/scholarly-python-package/scholarly/pull/187

Hi, I found a bug due to this new feature. Since the issue is still open, I am posting it here instead of opening a new issue.
When generating BibTex for a publication and there are None values in the author_id  list you get a TypeError. Looking at the code, I found this is due to string join in the .bibtex() method of Publication.
As a sidenote. Are these author IDs relevant to a BibTex entry? As these IDs only really make sense within Google Scholar.

@Ardillen66 +1 for this problem, it broke the Publication.bibtex property for me. As described above, the bug occurs when the author_id list contains None elements: https://github.com/scholarly-python-package/scholarly/blob/13b203a51c8c31736c5313f1082ecbd18c925569/scholarly/publication.py#L312
To reproduce:
query = '"Tracklet Association Tracker: An End-to-End Learning-based Association Approach for Multi-Object Tracking"'

from scholarly import scholarly
publication = scholarly.search_single_pub(query)
bibtex = publication.bibtex

Same, pub.bibtex is broken now :(
 converted_dict['author_id'] = ', '.join(converted_dict['author_id']) KeyError: 'author_id'

Problem: You fetch an author and their publications but when you try to get the BibTeX, you get parsing errors because of missing author_ids.
Workaround:
I exposed the URL in the publication class, then used the search_pub method on this URL to get a new instance of the publication, and Voila! Problem Solved, it had the missing keys, like author_id
 pub = author.publications[1]     url = pub.url     pub = next(scholarly.search_pubs(url))     print(pub.bibtex)

Problem
When you access the publications through an Author, you run into this error, especially the key not found in converted_dict[] variant.
Possible Workaround

Expose the url in the publications class. I exposed it as a getter property.
Add checks for author_id key not existing and the value of this key not being of NoneType.
Now, use the url with the search_pub function to get a new instance of the publication you want
With this new instance, you should be able to get the BibTex

You might be wondering that since I've put checks in place then why get a new publication instance using the url ?, well there is a reason for that: The original publication instances gotten via Author has something else wrong with thems as well, for the checks do get you beyond that error but then I was getting a new BibTex Parser error.

We are working on version 1.0 now, which will refactor many of these.

The version v.1.0 returns bac the author ids of the authors.

from scholarly import scholarly
from scholarly import ProxyGenerator

pg = ProxyGenerator()
proxy = '<your proxy>'
pg.SingleProxy(http = proxy, https = proxy)
scholarly.use_proxy(pg)

search_query = scholarly.search_pubs('Perception of physical stability and center of mass of 3D objects')
pub = next(search_query)
scholarly.pprint(pub)

The pub object contains the author_id field, with a list of the IDs of the authors, as they appear in the search results.
{'author_id': ['4bahYMkAAAAJ', 'ruUKktgAAAAJ', ''],
 'bib': {'abstract': 'Humans can judge from vision alone whether an object is '
                     'physically stable or not. Such judgments allow observers '
                     'to predict the physical behavior of objects, and hence '
                     'to guide their motor actions. We investigated the visual '
                     'estimation of physical stability of 3-D objects (shown '
                     'in stereoscopically viewed rendered scenes) and how it '
                     'relates to visual estimates of their center of mass '
                     '(COM). In Experiment 1, observers viewed an object near '
                     'the edge of a table and adjusted its tilt to the '
                     'perceived critical angle, ie, the tilt angle at which '
                     'the object',
         'author': ['SA Cholewiak', 'RW Fleming', 'M Singh'],
         'pub_year': '2015',
         'title': 'Perception of physical stability and center of mass of 3-D '
                  'objects',
         'venue': 'Journal of vision'},
 'citedby_url': '/scholar?cites=15736880631888070187&as_sdt=5,33&sciodt=0,33&hl=en',
 'eprint_url': 'https://jov.arvojournals.org/article.aspx?articleID=2213254',
 'filled': False,
 'gsrank': 1,
 'num_citations': 23,
 'pub_url': 'https://jov.arvojournals.org/article.aspx?articleID=2213254',
 'source': 'PUBLICATION_SEARCH_SNIPPET',
 'url_add_sclib': '/citations?hl=en&xsrf=&continue=/scholar%3Fq%3DPerception%2Bof%2Bphysical%2Bstability%2Band%2Bcenter%2Bof%2Bmass%2Bof%2B3D%2Bobjects%26hl%3Den%26as_sdt%3D0,33&citilm=1&json=&update_op=library_add&info=K8ZpoI6hZNoJ&ei=ApfRX6W-A46CywTRt52ACQ',
 'url_scholarbib': '/scholar?q=info:K8ZpoI6hZNoJ:scholar.google.com/&output=cite&scirp=0&hl=en'}

Notice that if you fill the object, you may retrieve more authors, and you may end up with more elements in the author field of the bib field of the publication than the elements in the author_id


Tensorflow in tornado

The process stop in calculating and did not give any response.
just like
[->] restore model 2018-02-13 15:27:49.235484: I tensorflow/core/distributed_runtime/master_session.cc:1004] Start master session 566c31076b9c7519 with config:

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Platform:Ubuntu 16.04
Tensorflow-cpu:1.4, install from pip

Our project used tornado as service
Model like this:
`
Class Model:
def init(self):
....
self.create_model()  # create placeholder, graph, etc.
self.resotre_model() # resotre model from cpkt
def create_model():
    self.graph = tf.Graph()
    with self.graph.as_default():
        ...
def restore_model():
    with tf.Session(graph=self.graph) as sess:
        ...

def predict(self):
    with tf.Session(graph=self.graph) as sess:
        sess.run(...)

Problem is that if i restored model while the model created, thesess.rundidn't give any response, it seems that the program was in await status.If I movedresotre_modelintopredict` which means restore model every time, it worked well but waste time.

Nagging Assignee @jart: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!

It seems that this is a design defect (maybe?). The program work fine with bottle but unsupported with tornado because of the fork-safe in Python2.7.

This is a clear design defect in tensorflow in that tf.session objects are not fork safe, thus crippling any kind of parallelisation you might wish to do with tensorflow.
It's existed for a few years and so far each issue mentioning it has been closed with no solution. There currently exists no way around this that I or anyone else has found so far.
Yet to hear from any tensorflow contributors why exactly this is, either.

One solution is that using the tensorflow.train.Server, but we don't do that because it makes the projects complex.We just change the frame to bottle   :(

Tornado can  work well with tensorflow in Python 3.6.5 .(we tested !)

yeah, we tested it tonight, and it worked fine! Thx !


Cancel portin

Adds the lib/portIns.js file with first function 'cancel'
Cancel takes

client object (if not supplied will use the default client) - the Bandwidth Application Platform Client
portInsId - ID of the portIn to be cancelled
callback - callback function

If the port in does not exist or can not be cancelled, the function will callback with an error propagating the error message returned from the Bandwidth Application Platform.
Adds the test/portIns.js file for cancel.
Tests cover the basic functionality described above

Looks good. Thanks for adding this!


Requirements suggestion for Navigating Using GPS Localization

Hi Steve or others,
After some hours of grief figuring out myself I would recommend adding this to the requirements of the GPS tutorial. BTW, I just jumped directly to this tutorial without starting with turtlebot3 so I didn't have it installed.
Navigating Using GPS Localization
Additional Requirements:

sudo apt install ros-$ROS_DISTRO-gazebo-*

to get the correct gazebo installation with the necessary plugin. NOT sudo apt install gazebo - I don't know what that does but it is bad.

sudo apt install ros-$ROS_DISTRO_turtlebot3-gazebo

without this gazebo takes forever to launch and it cannot find the mesh file for turtle3-waffle

Done, thanks! https://github.com/ros-navigation/docs.nav2.org/blob/master/tutorials/docs/navigation2_with_gps.rst