Cannot edit finding with github security identifiers

Bug description

As we start to integrate more and more various CVE-like identifiers, we may want to relax the regex.
Would we want to rename cve in the model to the profit of a more generic common_identifier? Or have yet another field and keep cve the way it is?

I think that cve should be kept, since it's the main record for tracking and identifying vulnerabilities across multiple tools/vendors.
What about having an additional field like security_advisory (or some better name) to track the specific tools/vendor related advisories?
For example:

GHSA-r3j7-x2g5-9gx6 points to CVE-2021-27185
DSA-4851-1 points to CVE-2020-17525
RHSA-2021:0603 points to multiples CVEs CVE-2020-9488, CVE-2020-13956, CVE-2020-14338 and CVE-2020-25638

How are other tools doing this? The example given show tools / vendors who have chosen to create their own ID on top of the CVE probably to provide some extra info/characteristics depending on their context.
What we could to is have some generic 1..N relationship between finding and "vulnerability identifier". Such an identified could have a type. i.e. a finding could have multiple vulnerability identifiers attached.
(CVE, CVE-2021-27185)
(RedHat, RHSA-2021:0603)
...
Maybe we could derive the type from the ID, but might be better/faster to have type column to filter on.
The would also allow use to have multiple CVEs per finding, which would help us if we ever want to combine multiple vulnerabilities in the same dependency/library for example. Or when we want to merge findings in defect dojo.
In the UI we could do something to show all identifiers in 1 column so we don't need N extra columns.

How are other tools doing this?

Personally I don't remember. DefectDojo is the only tool for vulnerability management that I've been using for several months. 😄

The would also allow use to have multiple CVEs per finding, which would help us if we ever want to combine multiple vulnerabilities in the same dependency/library for example. Or when we want to merge findings in defect dojo.

This sounds like a good idea to me.

@valentijnscholten @macedogm @madchap I think we should not use the cve attribute to store anything else than a CVE.
This attribute is used this way by all the parsers and everywhere in the code. Storing another vuln id like CWE or RedHat ID is a bad idea.
I already made a comment on another issue that wanted another id in the findings ( https://github.com/DefectDojo/django-DefectDojo/issues/3736 ).
My idea/what I think is the best model for storing all kind of vuln ID is to switch to a n..m model.
Like this for ex:

This way, we could have a flexible model that could store anything and adapt to future/custom taxonomies.
For the CWE/CVE as it is already a column of the finding, we could stay with an attribute or migrate to this model.
Last thing: the is also a pb with CWE in the current model. Today we can't store more than CWE. But most of the parser have data for more than one CWE.

Fine by me. @damiencarol or @macedogm, would that be something either one of you be willing to work on?


Roadmap to update TAC repositories

The following issues have to be replicated into the other TAC repositories and to be executed in the depicted sequence:
Updating file formats and release handling:

[x] issue #114
[x] issue #113
[x] issue #115
[x] issue #116
[x] issue #117
[x] issue #118
[x] issue #119
[x] issue #120
[x] issue #121

Changes in general design principles:

[x] issue #123
[ ] issue #124
[ ] issue #125
[ ] issue #127
[ ] issue #126
[ ] issue #128
[ ] issue #129
[ ] issue #130
[ ] issue #131
[ ] issue #132
[ ] issue #133
[ ] issue #134
[ ] issue #135
[ ] issue #136
[ ] issue #137
[ ] issue #138
[ ] issue #89

Changes specific to the application:

[ ] Step through issue list and deal with all specification related issues
[ ] issue #147

After updating OAS specifications of all applications of the TAC:

[ ] issue #139

Finalizing:

[ ] issue #140
[ ] issue #141

Has been replaced by milestone RO v2.0.0_spec.


chore: add context to deployment functions

see: https://github.com/go-vela/community/issues/832

@ecrupper https://go-vela.github.io/docs/community/contributing_guidelines/#development-workflow says scope is optional, but look like the the regex expect the scope to be mandatory

@ecrupper https://go-vela.github.io/docs/community/contributing_guidelines/#development-workflow says scope is optional, but look like the the regex expect the scope to be mandatory

https://github.com/go-vela/types/pull/347 Yup my bad. Will update all the core repos here now 👍


 The downside seems like regex isn't stable enough so relying on it feels risky, but even that pipe_first and browser might be a valid additions

There's two problems with this approach:

server-reason-react-ppx can't go with melange.ppx neither reason-react-ppx due to a conflicting attribute name.
Maybe you want to not add one of the transformations (and adding a flag with -exclude or -include seems silly)

Packaging like this:

server-reason-react.ppx for the JSX transformation
server-reason-react.melange-ppx with regex, pipe_first, double_hash_ppx (debugger from https://github.com/ml-in-barcelona/server-reason-react/issues/60)
server-reason-react.??? for browser_only, effect

Since https://github.com/ml-in-barcelona/server-reason-react/pull/71 is merged, I'm happy closing this.


docs: add AMI requirement note

Fixes #N/A
Description
Adds a note under amiSelectorTerms which calls out that the only requirement Karpenter can detect is architecture. Gives a specific example for accelerated GPU AMIs since Karpenter can differentiate and select the right AMI when no amiSelectorTerms are provided.
How was this change tested?
N/A
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.458%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5340

Relevant Lines:
6476

💛  - Coveralls


Added PUT to allowed methods.

Not sure why PUT was left out in the first place, but since it is a common REST verb, I suppose it would be prudent to include it.

Thanks


update error modal copy and style

What's in this PR?
Updated copy and styling of retry modal

Doesn't look like the content was part of this PR but there's definitely a few things that read funny:

'The backfill finished but following...': Think this should be 'The backfill finished but the following...'
'This may be because of permission issues, GitHub API rate-limiting and network outages.': Unless the last 2 items in this list happen together I think 'and' should be replaced with 'or'
'Learn more...': this seems to be just randomly dropped in the middle of the paragraph. Is it meant to be there? If so, can we shift it to the end of the paragraph or leave it there but move the next sentence to a new paragraph. Also, guessing there's meant to be a link?
I'd rewrite that whole last sentence to: 'You can continue using this integration, and view backfilled data in Jira, while the app attempts to reprocess these entities.'


Feature request: close to tray, minimize to tray

Would love the ability to leave daedalus running in the tray for when staking begins.

Minimize to tray is super useful, especially if one is utilizing daedelus throughout the day.

This would be really helpful. Also needs an option to "start to tray" so it never gets in the way of the the windows start up process.

When I wrote this request nearly 3 years ago, I was under the misunderstanding that daedalus would need to be running in order to stake. I think it the feature would still be nice, but it's not as pertinent as I thought it was.
I see someone is assigned to work on it now. Thanks guys!

I still think this would be a nice feature, and should be not too difficult with Electron.
Many apps do it right, like the Element (formerly Riot) IM app for the matrix chat network, which is also built on Electron.

Yes, we have it in our backlog and will focus on it as soon as we get some free bandwidth to do so...
Thanks for the patience!


Run worbox only on the modern build

After all, the legacy build browsers doesn’t support SWs.

And maybe we need a buildEnd rollup hook?

And maybe we need a buildEnd rollup hook?

Why?

I'm asking because I'm not sure if the worbox plugin can run before the index.html file is generated.

I'm asking because I'm not sure if the worbox plugin can run before the index.html file is generated.

Does the index.html not get cached with this configuration?

I'm asking because I'm not sure if the worbox plugin can run before the index.html file is generated.

Does the index.html not get cached with this configuration?

Never! haha 😬

Event if you change this line to:
basicConfig.output[01].plugins.push(workboxPlugin);

It works sometimes but others you can finish having a service worker with this configuration:

With no precacheAndRoute files configuration, everything empty (not just without the index.html only).

@thepassle It works with the current @open-wc starter app!

Thanks for sticking with me here 😄That was a rough one to figure out

@thepassle @Tansito and thanks to you two too! 👏


Conversion to DataFrame in a common API

Need to understand how it works by reviewing this PR in radis
Think conversion of moldb.py to DataFrame
@ykawashima @chonma0ctopus

Using a retrieval w/ CH4 as an example, I am checking which part should be replaced by a common API.
ExoMol
init_modit
here
cnu, indexnu, R, pmarray = initspec.init_modit(mdbCH4.nu_lines, nus)

[ ] nu_lines, looks easy to be replaced, already implemented?

in setdgm_exomol, exomol
here and here
dgm_ngammaL = setdgm_exomol(mdbCH4, fT, Parr, R, molmassCH4, res, T0_test, alpha_test)

or
SijM_CH4, ngammaLM_CH4, nsigmaDl_CH4 = modit.exomol(
        mdbCH4, Tarr, Parr, R, molmassCH4)

The destination is modit.exomol
    qt = vmap(mdb.qr_interp)(Tarr)
    SijM = jit(vmap(SijT, (0, None, None, None, 0)))(
        Tarr, mdb.logsij0, mdb.dev_nu_lines, mdb.elower, qt)
    gammaLMP = jit(vmap(gamma_exomol, (0, 0, None, None)))(
        Parr, Tarr, mdb.n_Texp, mdb.alpha_ref)
    gammaLMN = gamma_natural(mdb.A)
    gammaLM = gammaLMP+gammaLMN[None, :]
    ngammaLM = gammaLM/(mdb.dev_nu_lines/R)

[ ] (relative) partition function, qr_interp, need to be considered
[ ] logsij0, looks relatively easy to be replaced
[ ] nu_lines in jnp.array, already almost implemented
[ ] elower,  already implemented
[ ] pressure broadening parameters, n_Texp, alpha_ref, already implemented?
[ ] Einstein coefficient, already implemented

CIA
here
    dtaucH2H2 = dtauCIA(nus, Tarr, Parr, dParr, vmrH2, vmrH2,
                        mmw, g, cdbH2H2.nucia, cdbH2H2.tcia, cdbH2H2.logac)

I think we should postpone CIA meanwhile. But it should be included in the common API in the future?

@erwanp
Hello! Sorry for long silence. I have been busy the past few months as I moved from University of Tokyo to JAXA/ISAS (change my institution in your slide). Anyway, I manage to start a common API issue.
Currently, I am trying to use fetch_exomol as an interface
(here)
        dataframe = fetch_exomol(self.simple_molecule_name,
                                 database=self.database,
                                 local_databases=self.path)

But I am wondering how we should call pf (partition function) info. Sofar we used exomolapi.read_pf in exojax.
(here)
        # load pf
        pf = exomolapi.read_pf(self.pf_file)
        self.gQT = jnp.array(pf['QT'].to_numpy())  # grid QT
        self.T_gQT = jnp.array(pf['T'].to_numpy())  # T forgrid QT
        self.QTref = np.array(self.QT_interp(Tref))
        self.QTtyp = np.array(self.QT_interp(self.Ttyp))

I'd like to hear your opinion.

Hello, congrats on the move ! Our lab worked with Kazuhisa Fujita-sama at JAXA, if you happen to meet him.
--
Side note, I think you shouldn't use fetch_exomol() directly. It includes some RADIS specific features, such as storing databases in ~/.radisdb or registering them in radis.json (which is useful, but should not be required by Exojax). Also, it renames columns in a RADIS-specific format.
Instead, I suggest you use the underlying class from the common API, MdbExomol
--
For Partition Functions, I used a RADIS-specific mdb.to_partition_function_tabulator() function, which generates PartFuncExoMol, basically just an interpolator which returns  np.interp(T, self.T_range, self.Q_range)
I think you should keep on using the ExoJax syntax you showed above. T_gQT, qGT can be retrieved from the MdbExoMol object :
  mdb = MdbExomol(
      local_path,
      molecule=molecule,
      name=databank_name,
      local_databases=local_databases,
      nurange=[
          load_wavenum_min if load_wavenum_min is not None else 0.0,
          load_wavenum_max if load_wavenum_max is not None else np.inf,
      ],
      engine=engine,
      cache=cache,
      skip_optional_data=skip_optional_data,
  )
#...
T_gQT, gQT = mdb.T_gQT, mdb.gQT

(link to common-api branch)

Hello @erwanp,
Thanks a lot. I see. Then, first, I will try to wrap radis.api.exomol.MdbExomol in exojax.spec.api.MdbExomol.
I think, in near future, maybe we should directly call radis.api.exomol.MdbExomol but now, I feel the wrapping is more safe.

Yes, agreed. These API will take some time before they reach their final form. Even after you call radis.api.exomol.MdbExomol I'd suggest to Inherit() and Subclass the Radis class so you can easily override anything at anytime if needed (without having to require any RADIS update).
So  in exojax/spec/api
from radis.api.exomol import MdbExomol

class MdbExoMol(MdbExomol):
    ...

@erwanp
I think I managed to connect radis/api/exomolapi.py (working at common-api branch) to exojax/spec/api.py (working at radisapi branch) for ExoMol.
tests in ExoJAX

exojax/tests/integration/moldb

tests in radis

radis/radis/test/io

Before I move on HITEMP, I'd like you to make sure this is the right direction. I found, for HITEMP unlike ExoMol, MdbExomol like class does not exist in radis yet. Instead, I found HITEMPDatabaseManager. What are your thoughts on how to connect radis HITEMP API to ExoJAX?

Hello ! HITEMPDatabaseManager inherits from DatabaseManager, similarly to MdBExomol. Therefore, HITEMPDatabaseManager will play the same role  as MdBExomol in the API.
So it should be fairly easy to just duplicate the changes, unless you see a problem I missed ?

OK, then, I will try to implement it the same way as mdbExomol 😃 Thanks!

@erwanp
Hello! I have a question on hapi in radis. It looks that the installation of radis automatically installs hapi. Is it correct? If true, how does it work?

@erwanp Sorry to keep asking questions. What is the main reason for implementing hitranapi and hitempapi separately? Maybe data format?

Many parts are common,  but the download is different.
And Hitran has more columns than the default ones, we currently have a project https://github.com/radis/radis/pull/495  to automatically include the broadening coefficients of non-air species. This is a Hitran only feature.

@erwanp Hello! I have a question on hapi in radis. It looks that the installation of radis automatically installs hapi. Is it correct? If true, how does it work?

Hapi is pip installable. The pip package name is hitran-api
https://github.com/radis/radis/blob/develop/environment.yml

Hapi is pip installable. The pip package name is hitran-api

Thanks! Oh really. I did not notice that.

Many parts are common, but the download is different.
And Hitran has more columns than the default ones, we currently have a project https://github.com/radis/radis/pull/495 to automatically include the broadening coefficients of non-air species. This is a Hitran only feature.

I see. So, it's presumably better to have separate moldbs in ExoJAX too.

#309 removed the old moldb. So, now ExoJAX officially determined to use radis.api as I/O of ExoMol, HITRAN, and HITEMP.


Request accessories not be included in favorites by default

Is your feature request related to a problem? Please describe:
When plugin is installed, accessories are added to favorites. User then has to remove all accessories from and reorganized their favorites to clean this up.
Describe the solution you'd like:
Accessories are not automatically added to favorites when plugin is installed.
Describe alternatives you've considered:
None
Additional context:
None

Hi, I think this is the Apple HomeKit behavior and not related to Homebridge


Refactor Status tag styles into UI component #8656

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[x] For Python changes: Have you added tests to cover the new/fixed behaviour?
[x] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

addresses issue #8656
-added a new status_tag.html as UI component
-using inclusion tag created a new tag called status_tag , args( page, classname )
-created a status_tag.stories.tsx for LIVE  and DRAFT variations
DIFFERENCE
as in  case if page is not live it still renders a span in an anchor tag like the live condition
but with disabled css class
OUTPUT
**New test **

Styleguide

Story

Thanks @salty-ivy - have tagged this for review.

@salty-ivy  great stuff here, however, I think we need to rethink this a bit.
You have pulled out part of the page_status_tag shared include into a new shared/status_tag with a template tag of status_tag.
However, this generic status_tag now is very much tied to the requirement of a page and it's status.
Instead, I think the original goal of #8656 was to solve the generic use case of just status tags - not just page status'. I know that this can be a bit confusing, but I think let's try to solve the simplest scenarios first and get to 80% of the status tags using this new template tag.
From that PR, once merged, we can revisit the page status tag afresh and see if there is a way to make that also use the new generic status tag.
Also, by doing this, we kind of have to make some assumptions about the a & span tag variants, which would be good to avoid until later.
I recommend we put this PR to a draft and if you are up for it, give this another go with just tackling the generic case first.
See https://github.com/wagtail/wagtail/issues/8656#issuecomment-1345658164 for more details.

Ahh, I see it now pardon me for the trouble 😅 I got really confused with we were actually trying to do and completely focused on logical extraction of page_status_tag now I see how it is , it was little confusing at first at page_status_tag seemed pretty much refactored to me
Sorry for the trouble I would like to keep working on this one

@lb-  how about

using a kwarg in our tag to tell whether to use link or span depending on the condition something like
{% status  use="a"%} or  {% status use="span" %} to specify the what to render

alternatively
putting    and    into fragments and and taking up kwarg to specify which fragment to use?

@salty-ivy  I really think it may not be worth solving for page_status_tag yet - it will introduce a potentially complex convention of outer tags if we use use='a' and it's probably not something we need right now.
Solving for the simple status tag will cover 80% of the usage of status-tag class reuse - giving us a nice way to build on this in the future if we need to refactor classes or refine the way these are used.
The page status being a span or a link depending on context is probably not a pattern we would support long term, I think in the future it would be more likely we would go with a different approach here.

Got it

@lb-  i have made the changes added all stories  tests updated the templates for the tag, and did some error handling as well
however backend circleCI is still failing because of some other issues, which i believe has not originated from the changes i made.
rest everything is ready to be reviewed again thanks you

ready to be reviewed .

Sorry if I'm jumping in on a detail that's already been decided, but are we definitely sure that an opening/closing tag pair is the right pattern for this, rather than a single tag like {% status "Disabled" classname="primary" %}? I know it's replacing an opening/closing  tag, but it's not really being used as a container for content in the same way that, say, a header element is. I'm concerned that we're just replicating the underlying HTML structure here, rather than serving as a proper abstraction layer for it.

@gasman you have a point , i am not sure but this was originally decided considering its future scope.
this block based approach has  potential  to eventually take up other status-tag css for example   is spread across the admin just like this one, also there are some tags with
eg. page_status_tag and page_status_tag_new which can't be covered in a single tag approach, these potentially can also be included in this one

I don't think the presence of  tags would prevent the single tag approach - the template tag implementation would just become something like:
{% if url %}
    {{ label }}
{% else %}
    {{ label }}
{% endif %}

and that way, the template tag is serving an additional useful purpose, by ensuring that the logic for "if a URL is passed, use an  tag, otherwise use a " only needs to exist in one place.

I am not really sure @lb- would have a better idea on this one
As far as I understood it was more about abstracting the css rather than the html.

@salty-ivy  I really think it may not be worth solving for page_status_tag yet - it will introduce a potentially complex convention of outer tags if we use use='a' and it's probably not something we need right now.
Solving for the simple status tag will cover 80% of the usage of status-tag class reuse - giving us a nice way to build on this in the future if we need to refactor classes or refine the way these are used.
The page status being a span or a link depending on context is probably not a pattern we would support long term, I think in the future it would be more likely we would go with a different approach here.

.

@lb-  this PR is ready, although we might need some discussion on @gasman's comment let me know if there's  anything that needs to be done

@salty-ivy - Matt's idea above is a great one, it gives us the benefit of keeping the status template tag generic but supports the a tag without getting too complicated.
We will need to do a few things though

if provided with a url render the a variant, but also in that case handle an optional title variable
Hard-code the target blank & rel noreferrer though for now

Alright, I would make the changes soon

in this case i think inclusion_tag must be used to register the tag along with its arguments
in cases where there's another span or may be trans blocks inside of the status tag i think we need to use the fragment tag to extract the html and then pass it as a variable in the status tag.
eg:-

    {% trans "Current page status:" %} {{ page.status_string }}

would become
{% fragment as trans_title %}{% trans 'Visit the live page' %}{% endfragment %}
        {% fragment as inner_span %}{% trans "Current page status:" %} {{ page.status_string }}{% endfragment %}
        {% status inner_span url=page_url title=trans_title classname="primary" %}

is there any other compact alternative ? or we can go with it

Translated strings should be set up with {% trans ... as foo %}, not a fragment.
IMO, any time that we find ourselves needing to insert new elements like  inside the tag body, the {% status %} tag implementation should be extended to support that as a built-in feature:
{% trans 'Visit the live page' as trans_title %}
{% trans 'Current page status' as trans_label %}
{% status url=page_url title=trans_title hidden_label=trans_label classname="primary" %}

(as an aside... if we find ourselves having to use trans on tag attributes all the time, maybe we could make a template filter for that?
{% status url=page_url title="Visit the live page"|trans hidden_label="Current page status"|trans classname="primary" %}

Surely that must exist already...)
Otherwise, we're never really getting away from having to think "what does the internal HTML structure of this element look like?" when invoking the {% status %} tag, and it's not really serving its purpose of abstracting away the HTML, only adding another layer of complexity.

@gasman i see it now , getting the correct conventions thanks for the clearance

@salty-ivy let me know if you need another review on this. Thanks for working through the other feedback.

@salty-ivy let me know if you need another review on this. Thanks for working through the other feedback.

I would make few remaining changes and request for the review soon

@salty-ivy let me know if you need another review on this. Thanks for working through the other feedback.

@lb-  itr ready for the review

@lb-  now its ready for the review

Thanks @salty-ivy

converting to draft since it got conflicts, would resolve those soon

Will have to solve for URL not being opened in a blank tab - will commit a few extra things as a new commit on top.

Great! Thanks a lot for the help will give this a look, once I am done with stimulus issue, let me know if there's anything that I need to do.

ok - still a few more issues - will take another look tomorrow / this week.

i couldn't really figure out client object has no attribute get_host()..

@gasman it possible can you do another quick read through, as I have changed a few items and rebased since your last comments.
Thanks for the epic stuff here @salty-ivy - hope to get this merged in soon.

https://github.com/wagtail/wagtail/issues/10126 raised from the comment above about the trans filter.

I'll do another smoke test and probably merge this in a bit later if all is well

Follow on things to do

Update classes to be w-status and use BEM prefixes

Review additional status-tag usage and migrate to the template tag if possible

wagtail/admin/templates/wagtailadmin/collections/_privacy_switch.html (may not be able to as it's a button) - maybe this should not be styled as a status tag but instead be styled as a small button - similar to wagtail/admin/templates/wagtailadmin/shared/side_panels/includes/status/privacy.html
wagtail/admin/templates/wagtailadmin/reports/workflow.html
wagtail/admin/templates/wagtailadmin/shared/workflow_history/detail.html
wagtail/admin/templates/wagtailadmin/tables/status_flag_cell.html
wagtail/contrib/redirects/templates/wagtailredirects/list.html
wagtail/admin/templates/wagtailadmin/tables/status_flag_cell.html

Sorry I didn't get chance to look at this again before it was merged, but very happy with the updates 👍


add field constraint

make first_name, last_name required
make email unique
updated tests

Codecov Report

Merging #8 (a5fa96c) into main (4bdc4c0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   92.93%   92.93%
=======================================
  Files          19       19
  Lines         439      439
  Branches       10       10
=======================================
  Hits          408      408
  Misses         26       26
  Partials        5        5

Flag
Coverage Δ

tests
92.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

models/user.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


CorrDiff: Split generate.py, train.py and training_loop.py into functions/classes that handle more well-defined tasks

Addressed in https://github.com/NVIDIA/modulus/pull/629


Embed Version

Could you add a way to include the version of openapi-explorer as a non-displayable element on the page so there is a way to verify versions without making it obtrusive?  I know as users we could add this in ourselves and bump it every time we upgrade, but it would be nice to have it done natively and automatically as part of the component.

You can load the version of a package by by referencing the package.json file. The version is in there.
What are hoping to accomplish with having something like this?

Just to be able to verify what version of the component is deployed.  Like how most applications have a way of going to Help-->About to display the version number or how most web apps have small text at the bottom of their Settings page that lists the version number.  Something similar is what I was looking for to give a sanity check.

Could you tell me about how you are hosting the component? I would expect that you could easily
import { version } from 'openapi-explorer/package.json';
console.log('OpenAPI Explorer version:', version);`

Or at that point you can embed it whereever you would like. This is also way more flexible then having a DOM component which would need reflection, if you wanted to do anything clever.
I want to avoid adding non-functional features, it's hard to ensure that they will always work and won't break in the future. They also tend to be abused because it isn't clear their intended purpose.
Assuming that works, I'm going to close this issue.


Lasagna Master: Improve scaleRecipe tests

The instructions for scaleRecipe in the concept exercise Lasagna Master mention that the object that is passed in should not be modified. However, the tests currently don't check for that. That should be fixed.
(Thanks to @SethGunnells for pointing this out.)

@junedev Working on a fix right now!


[Task]: Use object semtype in compiler type checker

Description
Fallow on #42972
Describe your task(s)
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Closing with #43010


List IOL #2 communication next steps

#2: Advertise IOL #2 through OPN and other channels #8
CC blog post - template @ https://creativecommons.org/weblog/entry/41633
OPN post: https://openpolicynetwork.org/announcing-the-institute-for-open-leadership-fellows/
IOL summary for funders and board: https://docs.google.com/a/creativecommons.org/document/d/1HwnFr9_ksfGAZ4S4EdMiY-yLP5qw6pUw3ZrwsLuaDAk/edit
Update Comms plan on internal master: https://docs.google.com/a/creativecommons.org/document/d/1wIygIhZ5egVhsIlZ1MELT2HhGBgIhnkZ4gaLNRNkAE8/edit

List communication next steps (announcing IOL #2, etc.)

CC post draft: https://docs.google.com/document/d/1iFZtgf7WiEHCiTKepcfBaRiHGEFY1iogC9lw_B0RbaA/edit?usp=sharing

@cablegreen I will publish blog posts on CC.org and OPN on Monday, 28 September. Will send to OPN list, TJ, Dana, Melissa.

done https://creativecommons.org/weblog/entry/46104

will do followup push on social media on Oct 12, 26

done.


cargo fland update

changelog
-fix the atmos
-skub

Skub

skub

I may have already beat you to this [26273]
Though if mine didn't work and this is in response to that then I digress.

PR doesn't have an actual diff, it's just CRLF-ifying.


Compass heading for android is different than iOS

Hi
Any idea why my Heading for android is different than iOS. I need to correct it about 45degrees to be OK
Here my Code I use:
setCameraPosition(Position puckPositionToSet) {
double headingCorrection;
if (Platform.isAndroid) {
headingCorrection = 45.0;
} else {
headingCorrection = 0.0;
}
mapboxMap.flyTo(
  CameraOptions(
    center: Point(coordinates: puckPositionToSet).toJson(),
    padding: defaultEdgeInsets,
    bearing: _compassRotationBearing!.heading!.toDouble()+headingCorrection,
  ),
  null,
);

}
Thanks for your comments

https://github.com/hemanthrajv/flutter_compass/issues/31


Copy board

Hi. Thanks for app!
Please, tell me - how can i copy or clone board? I want to build reference board and then clone it for each project. How can i clone\copy?

This is an upcoming feature. Right now, the only way to do it would be in the database.

@kiswa Should this issue be reopened as a feature request? I don't see the feature in the live demo (0.3.1) or the documentation.

It's planned for the v1 series.


np.array performance bottleneck w/fix

there seems to be a performance issue while profiling example.py for batch of images.
https://gist.github.com/anuragphadke/c0d8227ee4e27b9710c6
line #133:
caffe_images = np.array(caffe_images)
This has couple of issues:

it accounts for ~40% of execution time for a batch of images.
np.array() seems un-necessary as images are already loaded as np.array in load_image() call, line 104.

removing line #133 reduces execution time by 40%.
performance metrics below:
current:
np.array took 2.009542 seconds.
Script took 6.449386 seconds.
proposed (after removing line #133)
np.array took 0 seconds.
Script took 4.233299 seconds.
Improvement:
~2.2 seconds or about 40%

You're certainly right that the extra call to np.array() is unnecessary. Let's remove that.
FYI, the amount of wasted time isn't nearly as bad for me. Here are some numbers for GoogLeNet, batchsize=10:

Mode
Total time (sec)
Forward pass (sec)
np.array() (sec)
Wasted time

GPU
1.18
0.07
0.16
13%

CPU
6.05
5.01
0.16
2.6%

Reference command:
head -n10 20-animals.txt | xargs \
  ./example.py model/snapshot_iter_33450.caffemodel model/deploy.prototxt -m model/mean.binaryproto  -l model/labels.txt  --batch-size 10 --nogpu


Support for SG15RT?

Is there a way of adding support for the SG15RT inverter?

You can try GR10RT and let me know if it's work.


Docker support

Would be nice to have Docker support: downloads count and stars, very often Docker images are automated builds based on GitHub repo.

I found the docker hub API for stars but no luck with the downloads count which I'm more interested in.
There's a bit of a quirk where official repos omit /u/ and replace the owner with an underscore in their public docker hub URLs, so you must replace the underscore with library in the API path for it to work:
Official URL:  https://registry.hub.docker.com/_/redis/
User URL: https://registry.hub.docker.com/u/mashape/docker-kong/
Official stars API: https://registry.hub.docker.com/v2/repositories/library/redis/stars/count/
User stars API: https://registry.hub.docker.com/v2/repositories/mashape/docker-kong/stars/count/

Where did you found that? There is only 1.5 version of API documentation on their website.

@nazar-pc it's what the website uses internally. Do you have any feedback on how the badge should be formatted, regarding text and color? Here it is in docker blue with just the count + text, this leaves it open for having downloads (or pulls as the website sometimes refers to them as) when we find a data source.

Docker uses blue colors, so, I think it looks great.
Reported in docker repo question about downloads/pulls count: https://github.com/docker/docker/issues/12268

Thanks, please ping me if you hear back. I filed a pull request for the stars integration.

Here is answer from Docker support team:

Unfortunately we don't have that feature. Although, I agree it would be very nice to have it in general to show download counts along with stars.

I'll pass along this feature request to the dev team.

Looks like they shut off access to the stars API so the integration no longer works. Hopefully they build a public API for stars, downloads and other meta information around the docker hub in the near future.

It's back online so I built an API that returns the total downloads and stars for repos. Hopefully I'll be able to get them both integrated into the PR tonight!

@espadrine, any thoughts when merged PR will be live?
Or is it already available, but not mentioned on shields.io?

@nazar-pc indeed, the website was not updated.

Should we close this issue, then?

Do you have any plans to add support for the Docker image status, i.e., whether the last built was successful?

Does it make sense to add image size as well?
$ curl -s https://registry.hub.docker.com/v2/repositories/library/ubuntu/tags/latest/ | python -mjson.tool
{
    "creator": 7,
    "full_size": 48649684,
    "id": 2343,
    "image_id": null,
    "last_updated": "2016-06-03T16:19:34.176107Z",
    "last_updater": 621950,
    "name": "latest",
    "platforms": [
        1
    ],
    "repository": 130,
    "v2": true
}

Is there a badge that shows the lastest version like we have for npm?


Support DateOnly and TimeOnly fields

Agreed. I have no idea how we're going to support DateOnly and have supports for the targets we do without a lot of #if statements.
Maybe... if we had an intermediary struct for dates, we could keep all the logic there rather than have a mix of the logic across the code base? Could implicitly convert between it and whatever the user intended. (Though this is also kinda messy)

Originally posted by @Turnerj in https://github.com/RehanSaeed/Schema.NET/pull/100#discussion_r689580810

Do we want to add this support before we release? Its potentially a breaking change.

While it would be cool, I don't have the capacity to do this in the short term. I think we get a release out with S.T.J now and plan out exactly how we add support for these structs (whether we go with my suggestion above about intermediary structs).

I'm not sure it'd be that much work. I'll see if I can get to it.
https://schema.org/Date -> DateOnly
https://schema.org/Time -> TimeOnly
https://schema.org/DateTime -> DateTimeOffset
https://schema.org/Duration -> TimeSpan

My thought was something like:
public struct SchemaDate
{
#if NET_6_OR_GREATER
    private DateOnly BackingDate;

    public static implicit operator DateOnly(SchemaDate schemaDate) { /* ... */ }
    public static implicit operator SchemaDate(DateOnly date) { /* ... */ }
#else
    private DateTime BackingDate;
#endif

    public static implicit operator DateTime(SchemaDate schemaDate) { /* ... */ }
    public static implicit operator SchemaDate(DateTime date) { /* ... */ }
}

And then something similar for the TimeOnly. I think something like this allows backwards compatibility and might simplify our logic handling of it or something.
If we switch out Values<,,,,> and OneOrMany<> with DateOnly and TimeOnly, we might end up having to include far more #if statements or something.
What are your thoughts on that?

Here are my quick thoughts for the scope of what I think would need changing/issues you might hit...
I think these places at minimum would need changing:

Source generator to use DateOnly and TimeOnly for type mapping for .NET 6 builds (I think its in the SchemaService class)
Replacing or modifying the DateTimeToIso8601DateValuesJsonConverter and TimeSpanToISO8601DurationValuesJsonConverter to use DateOnly and TimeOnly for .NET 6
A few small places in ValuesJsonConverter - mostly about reading (should be just duplicating the existing DateTime and Timespan paths) but there is also a small bit for writing Timespan values that may need a path for TimeOnly.

I don't know if the source generator is aware what the target framework is as it is a .NET Standard library so #if likely won't pick up .NET 6 when the target of the source generator is built. We probably can pass it in as a variable (similar to how we include pending types or not) though would require a little bit of extra work.
Happy to be a sounding board if you run into issues trying to add these types though!


[Docs] Change Maesh to Traefik Mesh on readme

Current State:
Maesh
Desired State:
Traefik Mesh with updated image on readme
Can be sourced on official site

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

I will take this up.


fix: don't crash cli on older versions of node

The entry point for the cli ./bin/wrangler.js wasn't being transpiled, which meant that any newer syntax would cause it to crash on older versions of node. This is a problem because we need this script to run even on unsupported versions so we can log a message telling the user their version of node is too old. The fix here is to just transpile the entry point as well.
Additionally, this fix also runs emit-types only when doing a full build, so local dev is a little faster.
Fixes https://github.com/cloudflare/wrangler2/issues/1443
Fixes https://github.com/cloudflare/wrangler2/issues/1435

Hmm, the test failure is weird, looks like wrangler isn't available in some fixtures. Investigating.

Closing this in favour of https://github.com/cloudflare/wrangler2/pull/1463


Added Vue.js questions

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added Vue questions.

What is the current behavior? (You can also link to an open issue here)
#105

What is the new behavior (if this is a feature change)?
N/A

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
N/A

@omegavesko awesome!


rename fully_connected_layers in tutorial/deep_learning/basic_concepts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add NetworkPolicy for CockroachDB

cc @lachie83

/ok-to-test

cc @a-robinson

@a-robinson just spreading the love. Open to feedback, especially from actual users.

@a-robinson how are we looking? Tests are passing :smile:


Change Id to be an object instead of a string.

This will allow to support RPC interfaces which does not support strings, but just numbers.

Looks good, it was originally just a string. Must of forgot that in my changes

Fantastic thanks again


[Feature]: add codeql workflow

Description
Is your feature request related to a problem? Please describe.
The repository contains code in javascript, it does not have workflow for code scanning.
Describe the solution you'd like
I aim to implement the CodeQL workflow to automate security checks. CodeQL, GitHub's code analysis engine, will identify vulnerabilities in the code and present the findings as code scanning alerts. This workflow will be activated for every push, commit, and pull request through GitHub Actions.
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a IWOC'24 contributor

Go for it


在iOS 10上报错

2016-09-21 11:17:14.581009 swiftScan[286:18283] [access] This app has crashed because it attempted to access privacy-sensitive data without a usage description.  The app's Info.plist must contain an NSCameraUsageDescription key with a string value explaining to the user how the app uses this data.

解决方法：http://www.cnblogs.com/isItOk/p/5875203.html


Can't change SNMP community-name (Feature Request)

When scanning by SNMPClient, community-name "public" is hard-corded.
https://github.com/yahoo/mysql_perf_analyzer/blob/8ef3ab85e0d2b6cd3196e3441ee5b10c0e36513f/myperf/src/main/java/com/yahoo/dba/perf/myperf/snmp/SNMPClient.java#L306
My environment uses other community-name, not "public", I'd like to configure that.

Configurable at site level or host level?

Also do you use snmpv3?

Does "configurable at site level" mean "using same community-name all over instances"?
That is enough for me.
And I don't use v3, using v2c.
Thanks,

A tab has been added to Settings page (/myperf/perf.htm?pg=settings). snmpv3 support has been added, too.

If none of DB GROUP and DB HOST is specified, the configuration will be applied to all servers.
If only DB GROUP is specified, the configuration will be applied to all servers to the group.
If a DB GROUP and DB HOST is specified, the configuration will be only applied to the specified server.

That's cool!
I confirmed that works fine :)
Thank you!


Incremental Upload

Hi,
Code is every time importing all data, how to import incremental data
Regards
Jeevan Pendhari

Incremental loading not supported.
Actually it is pretty difficult to track differential changes, as Tally does not provides as such this feature for external integration. So one needs to scan through each & every master / transaction for this. So, it's better to erase-out everything & freshly load all stuff, as it will ultimately take same time & performance.

Hi,
Tally provides AlterID for Master and Vouchers to get changed list also it provides CreateId for new voucher.
While sending query you can filter to get changes from last saved ID
Regards
Jeevan Pendhari

Hello,
Really good input worth of researching. I will definitely give this a try & see if this can be accommodated into utility logic.

I will explain the approach , I used in my C# applications
Pull only AlterID and GUID of Vouchers from Tally and SQL database
Ex:
Tally - [{alterid:6,GUID:"sdsf...12"},{alterid:"",GUID:"sdds...fdr13"},{alterid:"",GUID:"sdds...fdr15"}]
ExistingDatabase - [{alterid:5,GUID:"sdsf...12"},{alterid:"",GUID:"sdds...fdr13"},{alterid:"",GUID:"sdds...fdr14"}]
For New Vouchers Filter Tally GUIDs that are not there in Database Ex: [{alterid:"",GUID:"sdds...fdr15"}]
For Altered Vouchers Get the last AlterId from Database(Ex:5) and Filter alterIds greater than 5 this will give all altered objects
Ex: [{alterid:6,GUID:"sdsf...12"}]
For Deleted Filter Databses GUID that are not there in Tally  Ex: [{alterid:"",GUID:"sdds...fdr14"}]

@dhananjay1405 : is the incremental working now....

@gellavenugopal
Next 2-3 releases will contain only fixes to existing functionality of utility and database field / table expansion
Incremental working will be introduced as a feature after 2-3 releases, as it requires testing of many scenario in all 3 types of databases SQL Server, MySQL & PostgreSQL. Currently it is in development phase.
But yes, it is definitely on roadmap & that's why I tagged it as feature request (or enhancement)

@JEEVAN28
I have introduced incremental sync in this release. Feel free to share issues (if any) or further information you require. I will keep this thread open till incremental sync is tested by few more people.

Ok I will check

Hi, I tried testing incremental sync and got below error
Error from database.bulkLoad() at 2022-08-05 16:03:29
Error: ER_DUP_ENTRY: Duplicate entry '140e8dbf-5a25-4181-8b92-f9603b6651c6-00001976' for key 'PRIMARY'
at Query.Sequence._packetToError (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\sequences\Sequence.js:47:14)
at Query.ErrorPacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\sequences\Query.js:79:18)
at Protocol._parsePacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Protocol.js:291:23)
at Parser._parsePacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Parser.js:433:10)
at Parser.write (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Parser.js:43:10)
at Protocol.write (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Protocol.js:38:16)
at Socket. (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\Connection.js:88:28)
at Socket. (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\Connection.js:526:10)
at Socket.emit (node:events:526:28)
at addChunk (node:internal/streams/readable:315:12)
--------------------
at Protocol._enqueue (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Protocol.js:144:48)
at Connection.query (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\Connection.js:198:25)
at Handshake. (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\dist\database.js:253:36)
at Handshake. (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\Connection.js:526:10)
at Handshake._callback (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\Connection.js:488:16)
at Handshake.Sequence.end (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\sequences\Sequence.js:83:24)
at Handshake.Sequence.OkPacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\sequences\Sequence.js:92:8)
at Protocol._parsePacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Protocol.js:291:23)
at Parser._parsePacket (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Parser.js:433:10)
at Parser.write (C:\Users\Administrator\Downloads\tally-database-loader-utility-1.0.17\node_modules\mysql\lib\protocol\Parser.js:43:10)
ER_DUP_ENTRY: Duplicate entry '140e8dbf-5a25-4181-8b92-f9603b6651c6-00001976' for key 'PRIMARY'
ER_DUP_ENTRY
Duplicate entry '140e8dbf-5a25-4181-8b92-f9603b6651c6-00001976' for key 'PRIMARY'
23000
insert into mst_ledger (guid,alterid,name,parent,_parent,alias,is_revenue,is_deemedpositive,opening_balance,description,mailing_name,mailing_address,mailing_state,mailing_country,mailing_pincode,email,it_pan,gstn,gst_registration_type,gst_supply_type,gst_duty_head,tax_rate,bank_account_holder,bank_account_number,bank_ifsc,bank_swift,bank_name,bank_branch) values('140e8dbf-5a25-4181-8b92-f9603b6651c6-00001976',166435,'GST 2A- Mismatch_ITC','GST Withheld','140e8dbf-5a25-4181-8b92-f9603b6651c6-00008c7c','',0,0,-868403.48,'','GST 2A- Mismatch_ITC','',' Not Applicable','','','','','','','','',0,'','','','','','');
insert into mst_ledger (guid,alterid,name,parent,_parent,alias,is_revenue,is_deemedpositive,opening_balance,description,mailing_name,mailing_address,mailing_state,mailing_country,mailing_pincode,email,it_pan,gstn,gst_registration_type,gst_supply_type,gst_duty_head,tax_rate,bank_account_holder,bank_account_number,bank_ifsc,bank_swift,bank_name,bank_branch) values('140e8dbf-5a25-4181-8b92-f9603b6651c6-00001976',166435,'GST 2A- Mismatch_ITC','GST Withheld','140e8dbf-5a25-4181-8b92-f9603b6651c6-00008c7c','',0,0,-868403.48,'','GST 2A- Mismatch_ITC','',' Not Applicable','','','','','','','','',0,'','','','','','');

hello @JEEVAN28
You need to drop & re-create SQL database, since few more fields were added in database.
Also, first you need to keep sync as full in config.json
And once full sync is successful, then you can change sync to incremental . Actually incremental sync requires some start point, which is full sync for the first time. Then it keeps on updating that start point with each sync.

Hi,
Tally provides AlterID by which through ODBC query you can get changes.
Regards
Jeevan Pendhari
On Tue, Apr 19, 2022, 20:58 Dhananjay Gokhale @.***>
wrote:

Incremental loading not supported.
Actually it is pretty difficult to track differential changes, as Tally
does not provides as such this feature for external integration. So one
needs to scan through each & every master / transaction for this. So, it's
better to erase-out everything & freshly load all stuff, as it will
ultimately take same time & performance.
—
Reply to this email directly, view it on GitHub
https://github.com/dhananjay1405/tally-database-loader/issues/14#issuecomment-1102791601,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBCLC3U66K2DZXF2RE4K7DVF3GIRANCNFSM5TY3LTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, Tally provides AlterID by which through ODBC query you can get changes. Regards Jeevan Pendhari
…
On Tue, Apr 19, 2022, 20:58 Dhananjay Gokhale @.> wrote: Incremental loading not supported. Actually it is pretty difficult to track differential changes, as Tally does not provides as such this feature for external integration. So one needs to scan through each & every master / transaction for this. So, it's better to erase-out everything & freshly load all stuff, as it will ultimately take same time & performance. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBCLC3U66K2DZXF2RE4K7DVF3GIRANCNFSM5TY3LTGA . You are receiving this because you authored the thread.Message ID: @.>

@JEEVAN28 Incremental Sync is already rolled-out few months ago using the same AlterID mechanism. I didn't understand your question of what changes you are asking for


feat(security): Implement Bcrypt for basic auth and deprecate SHA512

I've re-written the code for this several times in the past before but always ended up not going all the way through with it because a hashed Bcrypt string has dollar signs in it, which caused issues with the config file due to environment variable support.
I finally decided to go through with it by forcing users to base64 encode the bcrypt hash.

The bottom line is, it was irresponsible of me to add support for SHA512 in the first place; it is a fast hash, and is not intended to be used as password.

Codecov Report

Merging #233 (3184788) into master (fc016bd) will decrease coverage by 0.20%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   83.20%   83.00%   -0.21%
==========================================
  Files          52       52
  Lines        3293     3312      +19
==========================================
+ Hits         2740     2749       +9
- Misses        430      439       +9
- Partials      123      124       +1

Impacted Files
Coverage Δ

security/sha512.go
100.00% <ø> (ø)

security/config.go
57.37% <43.47%> (-13.74%)
:arrow_down:

security/basic.go
100.00% <100.00%> (ø)

config/maintenance/maintenance.go
96.20% <0.00%> (+3.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc016bd...3184788. Read the comment docs.

Released in v3.5.0


Enhancement: Automatic Time Zone Assignment

User Story
As a volunteer, I need my time zone to match the time zone of the office where I will serve my shift so that I claim the right hours in the app.
Background:
A volunteer accidentally selected the wrong time zone in her profile, so today she thought she was claiming 10-12 but it showed up in the app as 9-11. We should avoid human error by having a rule: site time zone = volunteer time zone. If we have any sites on a time zone border, we need the app to translate the requested hours to the user's time zone.
Acceptance Criteria:

[x] The user's time zone is assigned automatically based on the site(s) he/she volunteers at.
OR
[ ] The app displays the available shifts to the user in his/her preferred time zone and translates any shifts claimed to the site's time zone.

As the app functions today, offices do not have the concept of timezone, instead, the time of a need is based on the local time of the user that created it. It does however translate between time zones.
So, for example:
Given:

I'm a volunteer coordinator or social worker at an office in Idaho.
My own time zone is set to MT
I create a need for 10am, the app uses my time zone (MT)

Then:

A volunteer across the time zone border has configured their timezone for PT.
They receive a notification for the need, it shows 9am.

While adding time zones to offices is possible, it'd be real tricky. It could also be confusing from a users perspective because the times displayed in the app could vary depending on what timezone the office is in. Whereas the current implementation will always display time based on the current users defined timezone.
Also, given that a user can belong to more than one office, we wouldn't know which office to select their default time zone from.

This makes sense, @benjaminwood. We'll discuss at grooming tomorrow and see if we want to close this ticket.

Just noting that we prioritized this issue today, without reading the discussion thread. I think the questions/concerns I shared back in 2019 still stand. Let's discuss with @SarahOMD before moving this forward.


DROOLS-1025 - Added tests that add and remove rules while adding and removing facts.

Created new TestContext, so we can batch TestOperations and observe state of the engine during tests.
Found new NPE - reproducer is test method AddRemoveRulesTest.testAddRemoveFacts().
New NPE in new tests in class AddRemoveRulesAddDeleteFactsTest.

Incorporated by https://github.com/droolsjbpm/drools/pull/704


a training problem

When i train the model, i always get the error "RuntimeError: Expected size for first two dimensions of batch2 tensor to be: [192, 16] but got: [192, 17].", and i can't solve it. Can you help me? Thankyou very much.

I have the same problem. Have you solved it now?

head=4, layers=5, dim=96, lr_ step=75000, lr_ Gamma=0.9, drop=0.25, epoch=100. I can't reproduce the results in the paper. My result is MPJPE=44.62mm. Is my parameter setting wrong?

I have the same problem. Have you solved it now?

When i train the model, i always get the error "RuntimeError: Expected size for first two dimensions of batch2 tensor to be: [192, 16] but got: [192, 17].", and i can't solve it. Can you help me? Thankyou very much.

Unlike most methods, GraFormer uses 16 key points. Compared with the 17 point method, there is no neck.


plans for website overhaul & docs update

phase 1 – reorganization

[x] rename napari/napari.github.io (currently hosting the docs) to napari/docs (completed by @kne42)
[x] change auto-devdoc CI script to point to the new napari/docs repo (completed by @kne42 in #876)
[x] reorganize napari/napari-tutorials (completed by @kne42 in napari/tutorials#51)
[x] create napari/napari.github.io basic landing page (can just be a copy of napari/napari's README) that includes links to the docs and tutorials pages (completed by @kne42)
[x] move CNAME file from napari/tutorials to napari/napari.github.io so it becomes the new root for napari.org (completed by @kne42)

phase 2 – improve docs

[x] clean up doc structure (completed by @tlambert03 in #942)
[x] improve content
[ ] how-to add a new page to the docs guide (@tlambert03)
[ ] create page for different doc versions

phase 3 – beautify website

[x] prototype website layout & feel in figma and submit for feedback
[ ] make dedicated custom landing page for napari.org (napari/napari.github.io)
[ ] (optional) adjust tutorials page stylings & layout
[ ] (optional) adjust docs stylings

phase 4 – add new content

[ ] add user gallery page
[ ] auto-generated gallery from CI

@kne42 I love this issue! We should also incorporate a user gallery into the site. (phase 4? =)

I'd also like us to explore using things like "google analytics" to track numbers of visitors and where they spend most time within the docs / tutorials. Things like number of visitors to docs can be important metrics to track growth of the project and justify increased investment. They can also let us see how any outreach, conferences, tweets etc affect people trying napari. They can also help us understand what parts of napari are people either particularly interested in or struggling with.
@jni do you do anything like this for the skimage website?

Happy to be tasked with stuff here as necessary... have a fair amount of web experience.

We just got matomo.cloud set up for scikit-image in this PR:
https://github.com/scikit-image/scikit-image/pull/4345
and @emmanuelle already used 24h of data to produce this cool viz:
https://twitter.com/EGouillart/status/1204769149907603456
😃
Our scikit-image plan comes with 5 domains, and napari was floated as a possible domain to add to that plan. @emmanuelle 👋 we coincidentally just started discussing analytics for napari.org. We probably need a proper way for everyone involved to access/admin the matomo account — is that possible?

@kne42, @sofroniewn shared his napari slides with @royerloic and me, and credits this one to you:

I think it's stellar! So information-packed, yet clear, easy to read and navigate.
I think the napari.org home page should be:

the one sentence intro to napari ("e.g. napari is a fast, n-dimensional array viewer")
a looping mp4 (not gif — see below for an example of how to do that) showing the smooth panning, zooming, and slider-ing of napari
the above slide/grid on getting started
then details/links/etc for both tutorials and the API docs.

... Embedding looping, auto-playing videos in html5:
<video width="90%" autoplay loop muted playsinline>
  <source src="/napari/napari-blobs-3d-720p.mp4" type="video/mp4" />
  <source src="/napari/napari-blobs-3d-720p.ogg" type="video/ogg" />
  <img src="/napari/napari-blobs-3d-720p-frame.jpg"
      title="Your browser does not support the video tag." />
</video>

Though I will note that, tragically, currently imageio only reads the first slice of a 3D tiff with imread, you need volread for all the slices. So I might switch that to skimage.io while we sort out the imageio API...

@kne42 at some point (maybe a follow on to #967) can we add the markdowns from our meeting notes https://github.com/napari/meeting-notes to the developer part of our website

I've begun work on prototyping the website in Figma. You can track my progress here.

I've been looking for this link on documentation a couple times lately, so want to put it here so I know where to find it, along with my summary of some potential goals for our website https://www.divio.com/blog/documentation/

Provide tutorials that are learning-oriented and teach the fundamental aspects of napari, including the viewer, layers, and dimensions to newcomers. These tutorials must be kept up-to-date with any API changes.

Provide explanations that are understanding-oriented and give background and context for design decisions, including choices relating to our software architecture, plugin management, and data models.

Provide how-to-guides that are goal-oriented and show how to use napari to solve specific problems, prioritizing major scientific use-cases and challenges. These guides should contain step-by-step instructions, and serve to motivate newcomers to try using napari to solve their problems.

Provide a comprehensive API reference that is information-oriented and describes napari in detail. Every function and attribute should have complete, accurate, and easy to understand docs strings that are easily accessible through this reference.

I think additionally the gallery section with cool examples gifs / screenshots / code snippets, the developer resources are good sections too

Here is the sitemap that I proposed yesterday. Feedback is appreciated!

As an alternative analytics platform to Google Analytics and Matomo, I'm impressed with https://plausible.io/

Open Source
Simple metrics
No cookies at all (fully GDPR compliant w/o cookie banners)
Option to have a public dashboard for transparency w/ users

As an alternative analytics platform to Google Analytics and Matomo, I'm impressed with https://plausible.io/

Open Source
Simple metrics
No cookies at all (fully GDPR compliant w/o cookie banners)
Option to have a public dashboard for transparency w/ users

That looks great @neuromusic, nice find!! @jni have you seen this before? How do you feel if we wire it up to napari.org? Could be nice to get some baseline data before more website improvements

Cookie banners are the bane of my existence. I have never seen this before but I would love to hook this up on our site and have the analytics be public!

Thank you @neuromusic for finding it! The Best.

Ok, great @jni I will look into trying this! They have a free trial

Here are a couple different sitemaps I've been exploring:
https://www.figma.com/file/CCKg8nO8vVcYVIvkVJbW4g/Website?node-id=0%3A1
We would not need to do one versus the other binarily, but ultimately could have a combination of the two (they are different in multiple ways, and rather than building out every permutation of difference-combinations, I just made the two "extremes"). Magenta outlines around the boxes in the second sitemap indicate changes relative to the first sitemap.
At this point I don't necessarily have a preference over any sitemap or the differences between them, but if I get more information it could help to inform the right direction. I have called out in red asterisks (and other asterisk-like shapes) where I have questions or suggestions; I also assembled these into a G-Doc.
I can go over the two sitemaps + primary differences and thinking behind them at the Thursday call, but would love any feedback before then (or after, too). Probably best to leave feedback in the Figma since it's easy to position the comments relative to specific parts of the maps there (press "c" key to enter comment mode; click anywhere to leave a location-specific comment!)! Thanks!
Original sitemap creation file is in draw.io, in case anyone wants to duplicate to iterate, etc:
https://drive.google.com/file/d/1KIb2juess9pUEraBMkyR974FPb_adEJH/view?usp=sharing

Update: I've also created a third sitemap that reflects my current inclinations of which changes would be most beneficial to user's needs/experience (but am in no way 100% about any of this, still need feedback to help make right decisions!):
https://www.figma.com/file/CCKg8nO8vVcYVIvkVJbW4g/Website?node-id=22%3A0
Sitemap 3 overview:
Identical to Sitemap 2, except the plugin content is pulled out from the disparate content categories (how-tos, reference, etc) to all live together. Maybe it would even make sense to live together as a “Contribution” section at some point within the app store site...?

I've incorporated the feedback since yesterday's meeting, but would love more feedback to help iron out the final tweaks/refinemments, or if this isn't looking right when actually seeing it.
https://www.figma.com/file/CCKg8nO8vVcYVIvkVJbW4g/Website?node-id=42%3A2

Update: here is the Figma where I've applied my initial structural explorations to real content and created prototypes showing how the navigations would work:
https://www.figma.com/file/fHIg6ktb6dFW3dhONihdVk/Page-structures?node-id=30%3A263
Select the different explorations via the pages in the top left sidebar in Figma. Then enter prototype mode for each by clicking the little triangle icon in the top right menu in Figma.

@liaprins-czi I can't access the latest figma without an account, could you make it public?

Hi @liaprins-czi these are amazing!! So great to be able to click though them.
I think my favourite is "Top primary nav + side sub-nav". I like how you can see the main things at the top so it's easy to get around, but you have the detailed index on the left. This is the relevant figma https://www.figma.com/proto/fHIg6ktb6dFW3dhONihdVk/Page-structures?node-id=32%3A98&scaling=min-zoom
and here is a screenshot

I also really like the decomposition into "use" and "contribute" to napari in the "Iterations 2" figma, for example this screenshot is very nice

I'm not such a fan of either expandable nav option, i worry they will get too complicated too quickly, either too nested or too long. I'm also not sure the breadcrumbs option will give enough to the user to let them rapidly switch between different parts of the site.
Overall amazing work, and I look forward to hearing what others have to say at the community meeting today!

@jni Sorry about that! I have updated the link:
https://www.figma.com/file/fHIg6ktb6dFW3dhONihdVk/Page-structures?node-id=60%3A0
I will explain a bit better at the mtg today, but thanks for all the feedback @sofroniewn ! Right now still very much in progress, but I think I am honing in on a direction

Here's a link to a prototype showing the desktop-size navigation in action:
https://www.figma.com/proto/fHIg6ktb6dFW3dhONihdVk/Page-structures?node-id=263%3A151&viewport=779%2C669%2C0.125&scaling=min-zoom
Will work on shoring up the other sizes next.

Looking great @liaprins-czi!! One question I have is if we will need 3 levels of expansion in the index column on the left, see

Should Getting Started and Using Layers be their own things which have an "expand" button? I can imagine pros/ cons. If things get too nested it can be hard to use, but it might help things not growing too quickly.

Yeah that is a great point, @sofroniewn I coudl see it being either way, but in general I was follpwing the rule that anything toggle-able in the side nav is also its own page (e.g. in this case you can click to go to the overall Tutorials page which lists its children + has an intro/overview to Tutorials in general at the top)... and I think it helps people to see more of the options at once (i.e. all the tutorials in the side nav) rather than expanding various sub-sections to get the whole view to compare and find the one thy want..

Here's another link to a prototype, this time applied to a narrower window width wherein the primary nav is collapsed into a hidden hamberger menu (and secondary "menu" accessed only by navigating to a primary-nav page, e.g. "Tutorials" page, rather than toggling open the menu within the hambuerger overlay). Also, the anchor link mini-nav is inserted at the top of each page rather than sticky at the right side margin.
https://www.figma.com/proto/fHIg6ktb6dFW3dhONihdVk/Page-structures?node-id=270%3A1&viewport=1273%2C1953%2C0.5&scaling=min-zoom

Sitemap update:
I have converted the site map to Lucid Chart, and updated it to reflect some more nuance, like the "use napari" vs "contribute to napari" groupings of the top nav sections:
https://app.lucidchart.com/invitations/accept/f7a85c5d-1ecc-4951-88f8-eaa9ec9b5a6e

Here's a screenshot of that sitemap, overview

and zoomed in

Now might be good to revisit since that @GenevieveBuckley has added jupyterbook support for our tutorials (see https://github.com/napari/tutorials/pull/95)
One big question I see is how much of this can be done inside the jupyterbook? One option might be to use the juptyerbook where can for now and then in the future add more custom navs/ sidebars but still embed the notebooks.

Yeah, next sprint I am planning to re-think the sitemap/structure in light
of both the Jupyterbooks and the various versions of the
documentation; before starting to implement the structure this will need to
be figured out...
On Fri, Nov 6, 2020 at 8:06 AM Nicholas Sofroniew<EMAIL_ADDRESS>wrote:

Here's a screenshot of that sitemap, overview
[image: image]
https://user-images.githubusercontent.com/6531703/98386815-7f717780-2005-11eb-9702-95a3b154fb26.png
and zoomed in
[image: image]
https://user-images.githubusercontent.com/6531703/98387108-dbd49700-2005-11eb-9312-50adc56aa87c.png
[image: image]
https://user-images.githubusercontent.com/6531703/98387168-ee4ed080-2005-11eb-887f-e639f6eeb373.png
Now might be good to revisit since that @GenevieveBuckley
https://github.com/GenevieveBuckley has added jupyterbook support for
our tutorials (see napari/tutorials#95
https://github.com/napari/tutorials/pull/95)
One big question I see is how much of this can be done inside the
jupyterbook? One option might be to use the juptyerbook where can for now
and then in the future add more custom navs/ sidebars but still embed the
notebooks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/napari/napari/issues/764#issuecomment-723160900, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWPDSE4AWG26QL54XNBEVTSOQNINANCNFSM4JWHCMTQ
.

--
Lia Prins
Senior Data Visualization Designer
(650) 422-1750
chanzuckerberg.com

Here’s a Figma showing screen sizes for mobile, vertical tablet, and desktop of two final-ish design options (they are pretty similar to each other in terms of how the content is formatted, the main difference is the look and feel of the header). Feedback is very welcome, and thanks!

Figma prototype

Use arrow keys to compare the two designs at each screen size,
Or click on the pages to move between screen sizes of a single design
Also the tablet and mobile versions’ hamburger menu icons open up the hidden menus
Every page can scroll so you can see the content formatting + footer

Figma board with a couple "in-between" designs in terms of how much color is shown in the header

Overall Figma file where iterations will be happening (I plan to explore more colors / hues / values + will be focusing on home page next)

Here’s a Figma showing screen sizes for mobile, vertical tablet, and desktop of two final-ish design options (they are pretty similar to each other in terms of how the content is formatted, the main difference is the look and feel of the header). Feedback is very welcome, and thanks!

Figma prototype

Use arrow keys to compare the two designs at each screen size,
Or click on the pages to move between screen sizes of a single design
Also the tablet and mobile versions’ hamburger menu icons open up the hidden menus
Every page can scroll so you can see the content formatting + footer

Figma board with a couple "in-between" designs in terms of how much color is shown in the header

Overall Figma file where iterations will be happening (I plan to explore more colors / hues / values + will be focusing on home page next)

I have a question about these “pills” on the current napari website: can we change the visual format of them? do we need all the content / all of them? Should it all be at the very top like it is now?
I have seen these on a couple other doc sites but not all, and hadn’t really paid them much attention. So just wondering if there is a reason we’d need to keep them in this format or not?

I have a question about these “pills” on the current napari website: can we change the visual format of them? do we need all the content / all of them? Should it all be at the very top like it is now?

I think we have quite a bit of control over them, see this project https://shields.io/ for a lot of standard ones and information on how to customize them. I think we can make our own too.
A little curation makes sense, we might want to separate out the shields which occur on the main readme on the github and the shields which occur as the homepage for the website, they might not need to be the same. Very open to additional ideas here, but I do like them overall. They are becoming quite common in the ecosystem, but different projects highlight different ones.

... we might want to separate out the shields which occur on the main readme on the github and the shields which occur as the homepage for the website, they might not need to be the same. Very open to additional ideas here

I realise this is not quite what is being discussed here, but I come down strongly on the side of having the website homepage be a copy of whatever the README says.
Having almost but not quite identical content in several places is a recipe for (1) easily missing some information, or (2) thinking you've updated the content everywhere but really only just in one place.

Having almost but not quite identical content in several places is a recipe for (1) easily missing some information, or (2) thinking you've updated the content everywhere but really only just in one place.

Yes, that makes a lot of sense - we're unfortunately in that position right now where we've got a bunch of copies of installation instructions that we'll want to fix, so avoiding duplication makes a lot of sense!
I do though think there is the opportunity for the homepage to have text and content that tries to meet a different audience then comes to the github readme. For example for https://numpy.org/ they have some really nice call outs and use cases highlighted on the main page whereas the github readme https://github.com/numpy/numpy is very minimal consisting mainly of links.

Thanks for your insights! I have skimmed over the shields.io site just now and will read it in more depth, which will help me understand and plan the design around these better. thanks!

Here is a link to the latest designs with options that I'd love to hear feedback on (best is to leave the feedback in the Figma itself, by clicking "C" to enter the commenting mode).
https://www.figma.com/file/Vm8z7DSjDjJurEX1RxEA39/Style-explorations?node-id=140%3A2
Here are the options I am interested in hearing feedback on especially:
Layout: the "less color" versus "more color" option
Color: aqua, turquoise, black (I just narrowed it down to those three based on feedback from the CZI design team, but really could be a different color or shade if needed)
Home page content: Do I have everything there that we need? Anything missing for this first round of website implementation?
Home page "portal" section (links out to the nav sections):

Icon per section, emoji per section (the ones I put there were just a quick first pass pick for getting general idea across), or nothing
Also, style of the listed sections: un-tiled, tiled with border, tiled with fill (black)
Text... I wrote text for each of the portal sections (just quickly to get idea), which I like the idea of helping to convey what is within the website. What do others think of this concept? Who would write the final text or edit what is there (not sure I got every section right). Also, I wrote a brief intro sentence for the installment section, as well as the two portal divisions ("Use napari" and "Contribute to napari")

Image to use within the screenshot of napari: The blue one on the left we likely have permission to use (we got permission to use it for napari.dev, but ended up not using it), and it's my top choice for napari.org. The one in the middle we used for napari.dev but would need to get permission from person from HCA who took the photo if we wanted it for napari.org.
Thanks, everyone! If helpful, I can try to link all the screens together so they can be viewed in prototype mode and you can click from one to the next (or use arrow keys); if this would be helpful, let me know!
Also, should I post about this feedback on Zulip (once I get my password figured out)? Thanks so much!

Great stuff @liaprins-czi. I left feedback on figma. My favourite was less color turquoise, using the blue dendrite screenshot. For the tiles something like this using shadow from the numpy page could be quite nice

Thanks for the feedback so far! I have now hooked together the frames into a clickable “prototype” to make it easier to go through them.
You can click anywhere on a page to go to the next one (or can use your arrow keys which will go through in a different order). You can also scroll each page when in prototype mode, which makes it easier to get a sense of what the page would really feel like to use.
https://www.figma.com/proto/Vm8z7DSjDjJurEX1RxEA39/Style-explorations?node-id=167%3A2&viewport=718%2C407%2C0.03125&scaling=min-zoom

Hi @liaprins-czi - giving feedback here because I'm struggling a bit with the figma. These look amazing!
Re colour: I really like the aqua, less color - second best would be turquoise, less color. For the sections I like the look of the 'open tiled' designs the most but maybe with something less harsh than the black boxes (dark grey with rounded corners? or just the drop shadow as Nick proposed!).
The blue image on the far left of the Figma is by far my favourite of the three!

Thanks for your feedback @alisterburt and @sofroniewn ! The feedback from you two and others in the Figma is pretty consistent, which is great! It has helped to narrow down the options, and I can do a bit more exploring for the design of the "tiles" for the home page to make them less harsh / flat.

Ok I finally got around to going through these, thank you @liaprins-czi! Love these mockups.
I prefer turquoise over aqua, and also less color.
@sofroniewn I have to say I disagree about frames and drop shadows, to me it looks really busy and dated. I really like Lia's frameless design.

(I've left comments on the Figma also but just wanted to summarise here for all the non-click-through-ers =P.)

Hi all, I've provided a chart below detailing how I plan to re-organize all of our documentation sources. In essence, any sources that are tied to a specific napari version will live in the main napari/napari repo and all other sources will live in napari/napari.github.io. This means that napari/tutorials and napari/docs will be combined into that singular repository. For now, due to difficulties with multiversioning, only the stable version of docs will live in the new site (copied via CI), but other versions may be accessed via changing the URL. We'll figure out how to get the other versions of the docs in there, but it may take a few weeks :)

For now, due to difficulties with multiversioning, only the stable version of docs will live in the new site (copied via CI), but other versions may be accessed via changing the URL. We'll figure out how to get the other versions of the docs in there, but it may take a few weeks :)

Sounds good, numpy uses stable in their URLs https://numpy.org/doc/stable/reference/arrays.scalars.html, so we can just go with that for the latest release

Great chart! This makes it really easy to understand.

I have re-org'ed the Figma project housing all the design explorations for the napari.org overhaul, to make it easier to now find the final designs + other assets!
Figma with final visual designs:
https://www.figma.com/file/NmdYwtpKfMzLnNLYYWrbTw/Final-designs?node-id=275%3A0
Folder containing exported SVGs for icons used within the design:
https://drive.google.com/drive/folders/1taZYafPoxS3ZZGqsIXizkB_VtfdNZ2-a?usp=sharing
Document explaining what happens at each breakpoint:
https://docs.google.com/document/d/1wJuvl-ZrDGFDLOTSrebjUPEa1f5dSz8TN0nPP43Ejn4/edit?usp=sharing

Hi all, I have a preview of the new website up at https://napari-staging-site.github.io/
we'd love to hear feedback and for you to report any bugs here!

with the new napari sphinx theme work ramping up, any objection closing this issue?


hint text on offline map imagery list

Fixes #2118

@gino-m  PTAL?

@gino-m As per the Screenshot shown in Issue, we need the graphics to show above the text.

Can you also add the image as per the mocks given in the bug?

Can you also add the image as per the mocks given in the bug?

Yes, in the above comment, I am asking to team to provide the graphics, do you know where I can get it?

/gcbrun

/gcbrun


Centered text on different lines don't get grouped into text boxes

Is your feature request related to a problem? Please describe.
Example PDF here
When extracting text from the example PDF (example code below), you can see that "Text 1" and "Text 2" are grouped into one text box, "Text 3" and "Text 4" are getting grouped into another, but "Long Text 1" is not.
If the text was left-justified or right-justified, they would all get merged into one text box.
Why does this happen?
This happens because of the find_neighbors function
In particular, you can see that lines which are within the line margin (the plane.find bit) are considered for grouping. They are grouped if the lines are a similar height (abs(obj.height-self.height) < d), and if either the left end of the text is in a similar place, i.e. the text is left-justified (abs(obj.x0-self.x0) < d), or if the text is right-justified (abs(obj.x1-self.x1) < d).
Describe the solution you'd like
It might make sense for centered text to become grouped too.
This could be achieved by adding an additional check to see if the center of the elements are aligned, something like abs((obj.x0 + obj.x1)/2 - (self.x0 + self.x1)/2) < d.
I'd be very happy to PR a fix for this, but thought I'd check it was something you'd like first.
Describe alternatives you've considered
None.
Additional notes

It feels a bit strange to me that d = ratio*self.height where ratio=laparams.line_margin is being used as a measure of how close things on the x axis need to be. Could this be explained? My current guess is that it's simply to avoid needing a new parameter?

The above is all posed in relation to horizontal lines, but the equivalent change would be made to the vertical case.

Example code
from pdfminer import converter, pdfdocument, pdfinterp, pdfpage, pdfparser
from pdfminer.layout import LTTextContainer, LAParams
path_to_file = "centered_text_example.pdf"

with open(path_to_file, "rb") as pdf_file:
    parser = pdfparser.PDFParser(pdf_file)
    document = pdfdocument.PDFDocument(parser)
    resource_manager = pdfinterp.PDFResourceManager()
    device = converter.PDFPageAggregator(resource_manager, laparams=LAParams())
    interpreter = pdfinterp.PDFPageInterpreter(resource_manager, device)
    for page in pdfpage.PDFPage.create_pages(document):
        interpreter.process_page(page)
        results = device.get_result()
        elements = [
            element for element in results if isinstance(element, LTTextContainer)
        ]
device.close()

print(elements)

I'd be very happy to PR a fix for this, but thought I'd check it was something you'd like first.

This is a valuable addition to pdfminer.six :)

It feels a bit strange to me that d = ratio*self.height where ratio=laparams.line_margin is being used as a measure of how close things on the x axis need to be. Could this be explained? My current guess is that it's simply to avoid needing a new parameter?

I agree. In #383 I suggested to use d = self.height instead.


Missing compiler required member

First of all I'm not sure if this is the right place to post this kind of issue.
I've a compiler error after introducing a method with a dynamic object as parameter. The error is the following:
error CS0656: Missing compiler required member 'Microsoft.CSharp.RuntimeBinder.CSharpArgumentInfo.Create'.
The project target is: netstandard2.0. And it'is a classlib.
I made some research, but it's not solved by adding a reference to Microsoft.CSharp.
I can't share the code since it's not an OSS project. I was not able to reproduce it outside the original project.
Anyway the code layout is similar to the following:
class MyType
{
    public async Task MyMethodAsync()
    {
        await MyNestedMethodAsync();

        async Task MyNestedMethodAsync()
        {
            var data = new {
                numberField = 0,
                stringField = ""
            };

            await MyNestedMethodWithDynamicAsync(data);
        }

        async Task MyNestedMethodWithDynamicAsync(dynamic input)
        {
        }
    }
}

Regards,
Giacomo S. S.

Can you try to add the Microsoft.CSharp NuGet package?

A way to look at why the dll's don't make it into the compiler would be to create a binlog (dotnet build -bl) file for your project and a project where it works and check if there are differences in the dlls passed to the compiler (csc task / CoreCompile target) and work back from there. (e.g. was the dll resolved from NuGet or was there something downgrading / overriding the reference etc.)


Issues with ESM syntax

Hey there,
thanks for the quick reply in #20.
I also noticed that the ESM implementation here is outdated, its pretty annoying to get it working with Gatsby (and probably other frameworks that now use/support ESM)
Can you please remove the https://github.com/wix-incubator/kampos/blob/master/package.json#L7? This should already help.
Alternatively: https://rollupjs.org/introduction/#publishing-es-modules (I think you do that, but your RollUp is v2 and v3 is the current... maybe upgrade? :))
Thank you so much,
If you got zero time, I can also give it a try, but didn't do much yet with rollup 🙈

@axe312ger yep, I'm actually on it now (:

Hey @axe312ger , here's the WIP PR: https://github.com/wix-incubator/kampos/pull/22
I couldn't remove type: module, Rollup keeps screaming at me if I do that. For some reason it keeps complaining of a mismatch between ES modules and Node trying to load CJS 🤷
But I did add a module entry here, maybe that will help. Can you check this somehow on your side?

Yeah if you export it as ESM, you have to keep the type: module, so thats fine.
I'll have a look!

I wonder whether it's ok to use the src index file as endpoint for ESM, or whether a single pre-built dist is also needed. 🤔

AFAIK: At best you compile down to ES6/ES7 and make sure to keep import/export.
On 28 Mar 2023, 17:31 +0200, Yehonatan Daniv @.***>, wrote:

I wonder whether it's ok to use the src index file as endpoint for ESM, or whether a single pre-built dist is also needed. 🤔
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@axe312ger should be fixed with 16418e3813a63e91fbed26434bce9f3109c7ca7a.
I've published 0.8.0, please try it out and update here.
Thanks!

@axe312ger did it work for you?


conmon: close the stdin on EOF if not tty

if we receive EOF when reading from stdin and we are not using a tty,
ignore opt_leave_stdin_open and close immediately the master stdin
fd.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1624041
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

LGTM
@mrunalp @umohnani8 PTAL

LGTM

This will end up closing the stdin of the command. The behavior we are trying to match is that we detach without closing stdin of the container.

This will end up closing the stdin of the command. The behavior we are trying to match is that we detach without closing stdin of the container.

yes, it conflicts with the option name although is there any usage in keeping the file open if it cannot be used anymore (as it is possible when we have a tty)?  If we leave it open, the other end in the container will never be notified of the EOF.

@giuseppe Yeah, I agree with your assessment that it doesn't make sense to leave it open. Let me check if we aren't relying on this behavior and if we can get the upstream test disabled. If we reach agreement on that, then we can merge this which makes much more sense.

@mrunalp @giuseppe where are we on this?

Seems to be passing all tests.  LGTM

/hold

We can't merge this till we agree and settle on upstream behavior.

What is the decission, and are you talking about something in the kubernetes world?

@rhatdan Yes, see - https://bugzilla.redhat.com/show_bug.cgi?id=1624041.

We had a call to discuss this and we won't be going this way. Instead, we want to detach in CRI-O when leave-stdin-open is true, tty is false and we get an EOF.

yes, going to close this


Issue #1724: Do not use Dockerhub centos images

Fixes: Issue #1724
Solution
Modify the Dockerfile to pull specifically from quay.io. The image we're pulling is a mirror of the upstream CentOS repository (probably along the lines of: https://www.openshift.com/blog/mitigate-impact-of-docker-hub-pull-request-limits).
Testing

The restriction of integration tests to story_registry feature should pass OK.

there is also 2 other uses of centos images (see /images directory)

/lgtm
retest this please

Need to update commit message to Pull from centos registry not Dockerhub


Sort operations alphabetically

Right now, operations in the side menu doesn't appear to have a clear sort order:

Redoc supports sortOperationsAlphabetically: https://github.com/Redocly/redoc#redoc-options-object
We should pass that option into the build command to sort the operation names alphabetically.

This depends on a newer version of redoc-cli -- we're currently on version 0.9.6.


Bind => Get

https://github.com/aspnet/Configuration/issues/541 is tracking the additional work to change Bind semantics


docs: update compatibility section in README

Motivation
as titled cc @lvhan028 @AllentDan @grimoire
Compared with vLLM and TensorRT LLM, LMDeploy can simultaneously utilize these performance-optimizing features. It has excellent compatibility and is a highlight-worthy point.
Modification
as titled
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

At the same time, LMDeploy has good driver compatibility with R470 to R535. Compared to LMDeploy, vLLM and TensorRT LLM only ensure compatibility with newer drivers like R535. From the perspective of internal deployment within the enterprise, this is also an advantage.


val.replace is not a function error on flutterwave card.

I get this error for card payment on the flutterwave payment pop-up.

Hi @syntaxPriest , apologies for the setback, you can now successfully make payment. Please do try again and revert if you encounter any other issue

Thank you @kpose


Backfillredis helm chart.

Signed-off-by: Ville Aikas<EMAIL_ADDRESS>
Description of the change
We need to run a job in the cluster to backfill redis. The code is here:
https://github.com/sigstore/rekor/pull/1163
So this wraps it in a helm chart

Existing or Associated Issue(s)

Additional Information

Checklist

[x] Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
[x] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[ ] JSON Schema generated.
[ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

Just to check, can we get the logs for the job once it finishes? Do we need to configure anything to prevent something else from coming along and scheduling another job and removing the logs?

Also note that when I ran
helm-docs -g charts/rekor

it picked up the changes from #409 to README. I didn't actually change them in this PR.


NTRs for stereocilia

I need a new term for 'stereocilium maintenance'
with relationships to these two terms, possibly as logical def.
GO:0071956 - cellular component maintenance (BP)
GO:0032420 - stereocilium (CC)
for annotation of mouse Tprn from PMID-27693694

Looking at this review, PMID:27565685, I would also like to have terms for two more parts of the stereocilium, specifically the shaft and the base. We already have a term for the tip.
term: stereocilium base
Def: The tapered base of the stereocilium adjacent to where it joins the hair cell body. This region contains a rootlet comprised of bundled actin filaments which spans the joint and stabilizes the stereocilium.
synonym: stereocilium taper

Annotation comment: It would be good to update the annotation of mouse Tprn to 'stereocililum' from PMID:20170899 to this term for the base.

term: stereocilium shaft
Def: The shaft comprises the majority of the length of the stereocilium. This region is notable for the extreme stability of actin filaments, which are highly crosslinked into a parallel bundle.
Based on this review, I would like to add a little more to the def of the 'stereocilium tip'
from: A distinct compartment at the tip of a stereocilium, distal to the site of attachment to the apical cell surface. It consists of a dense matrix bridging the barbed ends of the stereocilium actin filaments with the overlying plasma membrane.
to: A distinct compartment at the tip of a stereocilium, distal to the site of attachment to the apical cell surface. It consists of a dense matrix bridging the barbed ends of the stereocilium actin filaments with the overlying plasma membrane, is dynamic compared to the shaft, and is required for stereocilium elongation.

@ukemi  Let me know if you have any comments or objections to what I'd like to do on this ticket.

This looks ok, but there are currently no logical defs for these kinds of terms.

The term 'maintenance of synapse structure', which is one of the current child terms of 'cellular component maintenance', has a logical def:
'cellular process'
 and (results_in_maintenance_of some synapse)
so I was thinking it might be possible to make one parallel to that for stereocilium maintenance.

I didn't bother with a logical def for 'stereocilium maintenance'.
Here is what I put in:
id: GO:0032426
name: stereocilium tip
namespace: cellular_component
-def: "A distinct compartment at the tip of a stereocilium, distal to the site of attachment to the apical cell surface. It consists of a dense matrix bridging the barbed ends of the stereocilium actin filaments with the overlying plasma membrane." [GOC:ecd, PMID:17021180]
+def: "A distinct compartment at the tip of a stereocilium, distal to the site of attachment to the apical cell surface. It consists of a dense matrix bridging the barbed ends of the stereocilium actin filaments with the overlying plasma membrane, is dynamic compared to the shaft, and is required for stereocilium elongation." [GOC:ecd, GOC:krc, PMID:17021180, PMID:27565685]
is_a: GO:0005575 ! cellular_component
relationship: part_of GO:0032420 ! stereocilium
@@ -472232,6 +472232,37 @@ created_by: kchris
creation_date: 2017-05-10T20:51:40Z
[Term]
+id: GO:0120043
+name: stereocilium shaft
+namespace: cellular_component
+def: "The shaft comprises the majority of the length of the stereocilium. This region is notable for the extreme stability of actin filaments, which are highly crosslinked into a parallel bundle." [GOC:krc, PMID:20170899]
+is_a: GO:0005575 ! cellular_component
+relationship: part_of GO:0032420 ! stereocilium
+created_by: kchris
+creation_date: 2017-05-15T20:38:32Z
+
+[Term]
+id: GO:0120044
+name: stereocilium base
+namespace: cellular_component
+def: "The tapered base of the stereocilium adjacent to where it joins the hair cell body. This region contains a rootlet comprised of bundled actin filaments which spans the joint and stabilizes the stereocilium." [GOC:krc, PMID:20170899]
+synonym: "stereocilium taper" EXACT []
+is_a: GO:0005575 ! cellular_component
+relationship: part_of GO:0032420 ! stereocilium
+created_by: kchris
+creation_date: 2017-05-15T20:45:06Z
+
+[Term]
+id: GO:0120045
+name: stereocilium maintenance
+namespace: biological_process
+def: "The organization process that preserves a stereocilium in a stable functional or structural state." [GOC:krc, PMID:27693694]
+is_a: GO:0043954 ! cellular component maintenance
+is_a: GO:0060122 ! inner ear receptor stereocilium organization
+created_by: kchris
+creation_date: 2017-05-15T20:55:13Z

OK. Sounds good.


Cannot play because music server not found

As you can see the program is able to download the song, enqueue the song but not play the song.

Hi @mfbx9da4, thank you for your feedback. I figured out that the implementation was not matching the directory specified in the README Also the instructions were not very clear regarding the SAMBA setup. Please follow the updated instructions in the README file.