Accesss to a specific report is lost and couldn't see the chats

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): https://staging.new.expensify.com/r/8823458142807525 / https://staging.new.expensify.com/r/71168705
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714659279184109
Action Performed:

Open chat report with @Beamanator

Expected Result:
Able to access the chat report and chat loads
Actual Result:

Don't see the messages sent
Chat with @Beamanator  is not shown in LHN
When access his chat fro search getting not found page

Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Sorry about that noise, was doing a test for https://github.com/Expensify/PHP-Libs/pull/954 and did not realize all that was going to happen 😄

@tgolen the report not found sounds suspiciously like what I experienced here: https://github.com/Expensify/App/issues/41254#issuecomment-2088730504
{"code":666,"jsonCode":403,"type":"Expensify\\Libs\\Error\\ExpError","UUID":"da7984df-628f-41f6-a2b8-ecd4499f7975","message":"Report not found","title":"","data":{"onyxData":[{"onyxMethod":"merge","key":"report_0","value":{"errorFields":{"notFound":{"1714580833933154":"Report not found"}}}}]},"htmlMessage":"","requestID":"87d123434d9c4164-LHR"}

Here are the logs Tim shared in thread as well. @m-natarajan let's make sure you put those in the issues you create, because they're helpful.
@Beamanator's theory is:
"Wild guess because @aldo-expensify has seen us calling OpenReport on report action ids recently I believe"
What are the next steps here? Internal or External? @muttmuure do you want this in NewDot Performance?

Does anyone have their onyx state preserved such that they're still experiencing this? (Don't refresh or leave the page where you're seeing the bug.) If so let's start a thread in #newdot-performance and recruit an engineer to debug it live

Not I, I put my logs in the linked issue.

Sorry again, used it as a test once more

Unsubscribe

@zanyrenney also reported the bug from a real customer
https://expensify.slack.com/archives/C049HHMV9SM/p1714730789639869
I've experienced strange/slow loading.  And was just able to reproduce a bug where he the loading section at the top keeps flashing and doesn't load (and the logs zip buy quickly when so).  Let me know if you want the vid from that (I feel like that might be a different bug though, since it's glitchy and these reports appear to me more static or steady/consistent loading)

Different issue I think @mallenexpensify

This is about us losing reports

That's interesting. When I access https://staging.new.expensify.com/r/71168705, I got a skeleton UI for about 45 seconds before the chat loaded. And I verified it was not hung up on OpenReport which had completed seconds after I first accessed the URL. This must have to do with #fireroom-2024-04-29

From the Slack thread.  Does anyone think that 'chat lost' is related to 'chat not loading'?
I've got the below issue which I happened yesterday and that I was able to repro this morn.  Wondering if it's related to 'loading' issues somehow

Messages sent from iOS native is not received by other person and doesn't show on other platforms

@muttmuure what do you want to do about this issue?

We should track it in the #newdot-performance canvas
I chatted with Dan S about it here: https://expensify.slack.com/archives/C05LX9D6E07/p1714750131190839

He said, "the cause is probably:

You didn't have your current chat with him loaded locally
When you searched, you already had the personal details loaded, so search showed his contact pretty fast without doing a search in the backend (though you didn't have the chat itself, just the contact)
When you clicked, the app might have tried to do a OpenReport and the backend returned an error - or id never did the request, since I can't find it in logsearch"

So it sounds like @mallenexpensify could be right and this is an OpenReport error

Labeling this one UX Reliability

So it sounds like @mallenexpensify could be right and this is an OpenReport error

Ah, which we're working on somewhere else at this point?

I feel like a lot of these bugs might be related to the write performance issues we're experiencing (or something that's being negatively affected because of the issues with write performance).   For some of my bugs, I've punting them to retest next week, after we fix the fire and are on the other side of the merge freeze.

Asking if we're moving this anywhere here, I'm a bit unclear on the next steps: https://expensify.slack.com/archives/C05LX9D6E07/p1715364552147619?thread_ts=1714750131.190839&cid=C05LX9D6E07

Bumped in channel

I think after considering the RCA that Dan provided when I looked into this, I think that the solution here is a mechanism that retrieves the missing parts of the report object. It does seem like what happens is:

You try to load a report
Potentially there are site issues
The report gets stuck in this partially loaded state (with contact details only)
We don't "retry" getting the rest of the details

So I think that this issue will fix this https://github.com/Expensify/App/issues/41112#top

Just to make sure everyone has the same context... There are lots of suggestions to have some code that monitors for partial report data and then pulls the full report.
We had this exact logic previously, and it was removed in this PR. There was a lot of history behind that decision and it was a real cause of performance issues.
This kind of "magic" code that monitored for partial reports leads to a lot of code that just assumes that a full report object will always be there and code that doesn't know where the data comes from or can't recover when all of a sudden that data isn't there like it expects.

thanks for that context, @tgolen!

@arosiclair I can see you worked on https://github.com/Expensify/Web-Expensify/pull/41296, maybe you can look into this?

Since none of the original reporters are experiencing this anymore, I am going to close it


OmniSharp Agenda » Meeting Wednesday Feburary 10th @ 19:00 UTC

PST (UTC-8)
EST (UTC-5)
London (UTC)
Zürich (UTC+1)
Helsinki (UTC+2)
Sydney (UTC+11)

11:00 AM
2:00 PM
7:00 PM
8:00 PM
9:00 PM
6:00 AM

Meeting info
Join skype meeting
Join by Phone
Toll-free number: +1<PHONE_NUMBER> or Toll number: +1<PHONE_NUMBER>
Find a local number
Conference ID: 280856
Help
Agenda
If you can think of any more agenda items, feel free to edit the issue (if you have permissions) or just comment on this thread and we'll make sure to group them up before the meeting.
Also feel free to discuss any agenda items early as part of this issue, we can make sure to recap during the start of the meeting, and may cut down on the time we have to spend on some of them.
Telemetry
No big updates on telemetry, I'm not going to start on it until we're a little close with the dotnet cli migration.

There was some discussion about adding telemetry.  Basically it sounds like we're okay to explore telemetry so long as it is specifically something the user has to opt-in, from some setthing or prompt of the editor.  Each editor can decide how they want to handle this, but I think most of them will have a prompt of some sort.  If anyone has any insight into how to best handle the case of PII, or telemitry tools that already obfuscate PII for us, that would be good to know about.

C# Team's Ambitions for OmniSharp  via @dustincampbell
Assuming no new updates here, but we'll keep it as a talking point. :smile:

Last time there was a great discussion about potential ambitions that the C# team had for their tooling and how would OmniSharp fit into that.

@dustincampbell is there anything to add to that?  Should we invite the c# team again this round?

dotnet cli
@troydai has been working his branch, and helping fix build errors as they've poped up on the rc2 side.  It feels like there are fewer breaking changes coming down from rc2 as work moves over to cli.
OmniSharp-atom

Removed most react dependencies, might be a few remaining.
Focusing on making it easier to work with atom text editor instances.
Worked on plugins a little bit.
Vision here is
Been working with the RxJS 5 team to get better typings over so that I can migrate to that library fairly easily.

OmniSharp-node-client

Added the ability to download the runtime, worked through a few hiccups there.

Now the node client downloads an appropriate runtime for the user
Currently defaults to mono
If they are on mac/linux, and do not have mono, we fall back to coreclr.
The end game is to have this configurable, and move to CoreClr as the default eventually.

Preliminary plugin support exists, though it isn't wired up yet.

OmniSharp-vscode

Landed! https://github.com/OmniSharp/omnisharp-vscode
Updates? Progress? Goals?
Contributors outside Microsoft?

OmniSharp-roslyn

@troydai got a branch that now successfully builds, and appears to produce the correct artifacts for deployment.
@troydai is currently working on another branch with a dotnet related release.
Is there any other news?  We hit the holiday slow down with the rc2 branch, hopefully we can speed up for the next part of Feburary.

OmniSharp-scaffolding

Any information / updates?

OmniSharp-brackets

Any information / updates?

OmniSharp-sublime

@jchannon said that sublime needed some love I think?
Do we have anyone that wants to work on this?
Any other information / updates?

OmniSharp-emacs

Seems to have a pretty active
Does the emacs team need any support?
Any other information / updates?
cc @ianbattersby

Additional agenda items?
Either update the issue, or add them in the comments below!
cc @OmniSharp/all

I'd like to have these items discussed regarding to omnisharp-roslyn of dotnet-cli in tomorrow's meeting.

Should we keep the dnx451 build of OmniSharp? It is required by MSBuild and ScriptsCS plugins. Neither of them has portable implementation. Can we engage the teams own these two package to build a portable version of them? Removing the dnx451 target framework can reduce the maintenance effort and ensure cross-platform.

DNX is fading away. Do we want to keep OmniSharp.DNX plugin? The coexist of OmniSharp.DNX and OmniSharp.DotNet project system requires additional work to distinguish what project system to use for a given project since we keep the project.json schema unchanged. Is there much value to keep OmniSharp.DNX? If so which DNX should be targeted.

These is a bug related to run dotnet build tests on dnx451 framework.  Here's a repo: https://github.com/troydai/loaderfailure. This is another cost of keep dnx451 build.

How do we distribute the OmniSharp?

re: 1 I had a branch branched from your branch (:smile:) that contained portable scripting support, it just needs to be brought up to speed with latest stuff (too many changes happening recently, just that). AFAIK there are quite a lot of people using scripting language services in atom, VS code so it would be a shame to take it away. I can dedicated time towards this, sure.
Regarding MSBuild I think this is more of a roadmap decision, is this something that Omnisharp should care about supporting or is the goal of Omnisharp to only work with project.json? I think a lot of people kind of expect that some MSBuild support would be there as it's still a primary project system people deal with.

I think loss of MSBuild would be a bummer. It's still pretty important.
Note that MSBuild is producing a stripped-down portable version here: https://dotnet.myget.org/gallery/dotnet-buildtools. I was going to take a look at that at some point because we'd like to also make the Roslyn MSBuildWorkspace portable.

Sadly I am not able to make it to the meeting today.
as far as omnisharp-sublime is going, right now I am working on cleaning up the code base and adding in testing. Already added in the ability to use both omnisharp-roslyn and omnisharp-server, just haven't released it to package-manager yet. Just thought that I should put that out there.

Where are we having the meeting?

Hey @SamuelEnglard, sorry forgot to comment on the issue.  I've added the meeting information, we're going to use skype for business again, like last month.

Sayed command line proof of concept
https://github.com/ligershark/pecan-waffle

Was there a recording for this session?

Here is my pecanwaffle video https://youtu.be/Xi5Kn4Lq6Xg I would love to hear your thoughts.

@sayedihashimi that looks pretty amazing, ship it tomorrow okay? :smile: :+1:

@ctolkien

Was there a recording for this session?

Sorry I think we forgot to record it this time.


View pre-generated model outputs

Besides online processing, the app should show pre-generated outputs.
The outputs will be loaded from a directory, the name of each file will correspond to the model & dataset.
In the left panel, there will be a list of checkboxes on which outputs to display. In contrast to pipelines (which are generated on-the-fly), these outputs will be instantly available together with the table.
Gold references should be moved under this category.

Implemented in 784140eb487030584da58bea3b7accd72df94f15


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3300

Questions ?
Please refer to the Backport tool documentation


adonis-cockpit/inertia does not exists

Hi!
I performed the configuration on my ReactXInertia app, and the configuration of cockpit generated this file:
import { resolvePageComponent } from '@adonisjs/inertia/helpers'
import createCockpitApp from 'adonis-cockpit/inertia'
import { DefineComponent } from 'vue'

createCockpitApp({
  resolve: (name) => {
    return resolvePageComponent(
      `../pages/${name}.vue`,
      import.meta.glob<DefineComponent>('../pages/**/*.vue')
    )
  },
}, {})

But adonis-cockpit/inertia seems to not exist in the package.

This can be fixed by upgrading to a newer version, like 0.2.0 or 0.1.1.


Comparison with Meteor Kitchen

Looks like the two projects are quite similar. MeteorKitchen doesn't have a GUI at the moment, but other than that, it can create menus, forms, components, routes, plugins etc.

+1


Validation check: display summary to user

Once the validation checks have been run, enable an on-screen summary showing something along these lines (can't remember which categories we are able to check at this point in the process):

X records were checked for validation
Y records failed due to issues with the location coordinates/grid references
Z records failed due to incorrectly formatted dates
ZZ records failed due to to names or taxon keys not being matched
Please download the validation errors file, edit your data and re-upload to complete the checking process

Alternatively, if breaking things down by category is too complex, we could just display the overall total:

X records were checked for validation
Y records failed validation checks
Please download the validation errors file to see the details, and then edit your data and re-upload to complete the checking process

First draft in dev. It also applies to verification results.

Deployed in v1.1.0


Missing

This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels.
The author described their issue as follows:

Missing

The steps to reproduce this issue are as follows:

Follow the quick start guide and serve the application, you need to "View Source" rather than Inspect as most browsers will add the mossing closing tags.

I'm brand new to Perseus (and loving it btw) so I might have missed something obvious. Happy to look at fixing it, but wanted to confirm that it actually was an issue first.
A minimum reproducible example is available at <>.

Hydration-related: false
The author is willing to attempt a fix: false

Tribble internal data
dHJpYmJsZS1yZXBvcnRlZCxDLWJ1Zw==

Ah yes, you'll probably find a lot of missing closing tags by default, as Perseus applies a highly aggressive minifier that strips many of them. Semantically, this ends up being fine, as browsers can interpret the HTML the same, but you can disable the minify feature if you'd like, or if you're having any problems with this.
I might close this for now, as it's expected behaviour, although I'd be very willing to accept a PR that adds some notice for this in the docs somewhere if you'd like to write that?


chore: import repository https://github.com/martinmlouis/activity.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Image icons are clipped at VectorTile edges. Part 2

I was happy to see new version 6.6.1 where this (https://github.com/openlayers/openlayers/issues/11884) was fixed.
But we have still problems with icons on edges.
On the picture there is several points on the edges that are fine, but still there is quite a lot points that are not ok.

I am sorry that I cannot easily do a working demo for you. (Code is clojurescript/interop javascript)
What I have done:

Server side that is making tiles is taking care that points should be on every tile
renderBuffer, I have tried values from 0 to 3000, this attribute is working but still doesn't solve the whole problem
Styles anchor attribute is doing also some strange behaviour on rendering (in the picture there is no anchor attribute)

Any idea? I was wondering that could this problem be in render order or something like that?

A few things to note here:

The renderBuffer option can only help if the server also buffers features.
You can use the https://openlayers.org/en/latest/examples/drag-and-drop-custom-mvt.html example to test your tiles by dragging two neighboring tiles from the above screenshot into the example map, and check if all points in question are really duplicated (visible because of the higher opacity of overlapping points).

@ahocevar yep you were right, the problem was that neighboring tiles didn't have the same objects! Hope this helps somebody else too, if you use ElasticSearch also when generating the tiles remember that intersecting bounding box should be larger there also :)
There is still this problem with styles anchor attribute (svg icon below, I want to use this drop shape icon so thats why I need anchoring). RenderBuffer doesn't seem to solve this. Any ideas?
anchor: [0,0] ->

anchor: [0.5, 1] ->

svg: "data:image/svg+xml,%3Csvg%20width%3D%2224%22%20height%3D%2224%22%20viewBox%3D%220%200%2024%2024%22%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E%0A%20%20%20%20%3Ccircle%20cx%3D%2213%22%20cy%3D%2213%22%20r%3D%2210%22%20fill%3D%22%23333%22%2F%3E%0A%20%20%20%20%3Ccircle%20cx%3D%2212%22%20cy%3D%2212%22%20r%3D%2210%22%20fill%3D%22%23ff1744%22%2F%3E%3C%2Fsvg%3E"

@ahocevar any ideas?

@Ruahonen It looks like the buffer of the tiles is too small to accommodate for the anchor.

I'm not exactly sure why, but setting declutterMode to 'none' on the Icon, seems to fix the issue without the need to have the same features near the edge of neighboring tiles.

I am not sure whether I am hitting this issue as well or if I should create a new one, but the symptoms look the same: the icons of my features are clipped at the tile edges, as shown here:

(instead, we should see complete pentagons for every point)
It seems that this behavior is intended though, according to the documentation:

Features are optimized for rendering, their geometries are clipped at or near tile boundaries and simplified for a view resolution.

I tried using VectorSource instead, but it does not scale to the amount of features I need to manage (~50k).
Are there any solutions I missed to not clip the icons at tile edges?


feat: experiment for reusing allocated buffers for Dyn multivariate

takes approach of making a few fields OnceCell, allowing for init-ing
precomputed values while allow taking them out to modify without
reallocate
Implementing similar way to update location via set or set_with would also be implemented.
Would also implement nearly identical in StudentsT.

@FreezyLemon an alternative to #273, what are your thoughts?

Noting as a tangential discussion, since #180 was referring to MCMC, perhaps there would also be a need for many more variables than nalgebra is well suited to. We've mentioned ideas for supporting different backends before but I figure if we can specify some of the API for nalgebra, then we can emulate that where possible for a different matrix crate.

@FreezyLemon an alternative to https://github.com/statrs-dev/statrs/pull/273, what are your thoughts?

This seems like it will result in a nicer API than 273 for sure. Hm.. without OnceLocks or some other thread synchronisation, this will make the struct non-Sync and non-Send though. And I can see complexity becoming a problem, with the internal state needing to be valid in any circumstance.

I realized this morning all of this works because of take, so Option would be viable
Also, you mentioned how a distribution should be immutable, and I agree, so semantically it would make more sense to have into_new_from_nalgebra that takes self and relies on take and clone_into.

redid this with Option, regarding async, I think this would be fine for an RWLock style of code since the only times the Options are None are when there's a mutable reference to them.
I considered a type that represented this kind of "field that owns a data" that always logically stores a value, but is just a wrapper to an Option.

Have you benched this? I've tried implementing a builder pattern for some time and benches have always shown it's not really any faster than just reallocating.
Unless the amount of variables (and thereby allocation size) is much larger than I've tested, I doubt this makes much difference at all performance-wise.
Some napkin math (please double-check) reveals that for n variables, we need to allocate 3 n x n matrices and one n x 1 matrix/vector. For 10 variables, that's 310 f64s (8 bytes each), so 2480 bytes i.e. less than 2.5KiB. Such small allocations will usually be incredibly fast unless on memory-constrained hardware.
Even with 1000 variables, we're talking about ~3MiB which really isn't that much. That should fit into CPU cache on most modern hardware..

I did a rudimentary profiling run for 1000 variables, just running MultivariateNormal::new 40 times (~10 secs runtime):
https://share.firefox.dev/4enR0hX
The code is basically:
fn main() {
    let (mean, cov) = create_mean_and_cov();

    for _ in 0..40 {
        MultivariateNormal::new_from_nalgebra(mean.clone(), cov.clone()).unwrap();
    }
}

If you look for allocating functions (mostly clone()), you'll find that apart from some calls very deep inside nalgebra that are probably not avoidable by statrs, the allocations that are done don't seem to be very heavy at all. Even the manual clones inside the loop in fn main are less than 0.5% of the total runtime.

Oh this is a smarter way to do preliminary benchmarks. I was going to check if this in-place mutation was faster 🙃. Thanks for doing this!
What did you use to profile and view with Firefox profiler?
Changing from nalgebra right now does seem a bit like it wastes effort, so I'm averse to it until we get some more feedback.
I'll close this and share thoughts about something benefitting MCMC on the initial issue.

What did you use to profile and view with Firefox profiler?

I used samply, it's really easy to use after a bit of setup and does the firefox profiler stuff for you. perf record also works, but is a bit more barebones (flamegraph can convert the artifacts from that into nice graphs)


Cannot build for newer node version (ABI 64)

Im trying to build an electron app with a dependency to this project with the following command:
npm rebuild --runtime=electron --target=3.0.0 --abi=64
But fail with these errors:
\node_modules\ffi\src\ffi.cc(111): error C2039: 'ForceSet': is not a member of 'v8::Object'

yea it won't build for me as well, error C2039: 'ForceSet': is not a member of 'v8::Object'

This module is essentially unmaintained. Shameless plug: https://github.com/node-ffi-napi/node-ffi-napi provides the same API but uses N-API to provide stability across Node.js versions indefinitely.

I managed to compile my codebase using electron-rebuild and using this version string for ffi in my projects package.json "github:node-ffi/node-ffi#169773d"

I get an error with node 10.10.0 npm 3.5.2, node-gyp 3.8.0 when I enter
npm install ffi
I get error
../src/ffi.cc:111:11: error: ‘class v8::Object’ has no member named ‘ForceSet’
target->ForceSet(Nan::New("RTLD_NEXT").ToLocalChecked(), WrapPointer((char *)RTLD_NEXT), static_cast(ReadOnly | DontDelete));

i just switched to node-ffi-napi works great


Formal Workflow for Graduating Documentation

What?
Create a formal workflow for moving documentation from the collaboration documents to GitBook documentation.
Why?
To ensure that the documentation is consistent, reviewed, and properly formatted before being published on GitBook. This will improve the quality and reliability of our documentation.
Acceptance Criteria
Document that outlines the steps and protocols for graduating documentation. This document should be reviewed by the team.

I was reviewing some old notes and I came across a note about developing a staging ground for brainstorming in our Google drive. Thought that this idea might be part of the graduating document workflow.


MWPW-116104 - New Window Links

v2 of opening #_blank links in new windows and using the links.xmls file to specify how to decorate certain links
Resolves: MWPW-116104
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/vhargrave/links-in-new-window?martech=off
After: https://vhargrave-author-links-new-windows--milo--adobecom.hlx.page/drafts/vhargrave/links-in-new-window?martech=off

Getting a console error on bacom.
Sample page: https://main--bacom--adobecom.hlx.page/drafts/rclayton/test/links-in-new-window?milolibs=vhargrave-author-links-new-windows

@rgclayton It's trying to get the default links file, which doesn't exist on bacom. We check once to see if the file exists and if it doesn't then we don't query for it again. This is how the task was specified for me to implement 😅

Getting a console error on bacom.
Sample page: https://main--bacom--adobecom.hlx.page/drafts/rclayton/test/links-in-new-window?milolibs=vhargrave-author-links-new-windows

@rgclayton It's trying to get the default links file, which doesn't exist on bacom. We check once to see if the file exists and if it doesn't then we don't query for it again. This is how the task was specified for me to implement 😅 It's like the placeholders.

Do we want this to fail silently? Or, with a better message than what's being generated?

Getting a console error on bacom.
Sample page: https://main--bacom--adobecom.hlx.page/drafts/rclayton/test/links-in-new-window?milolibs=vhargrave-author-links-new-windows

@rgclayton It's trying to get the default links file, which doesn't exist on bacom. We check once to see if the file exists and if it doesn't then we don't query for it again. This is how the task was specified for me to implement 😅 It's like the placeholders.

Do we want this to fail silently? Or, with a better message than what's being generated?

I'm not sure how to make it fail silently. Apparently this console error is caused by the browser - https://stackoverflow.com/questions/44019776/fetch-api-chrome-and-404-errors

@vhargrave fix your merge conflict with your georouting pr and let's ship this.

@rgclayton @vhargrave I just saw Ryan's comments. We might want to make this another opt-in (via config). I'd hate for a consumer to go live with a project and without warning they get 404 for something they don't even care about. #_blank will always work for everyone.

@rgclayton @vhargrave I just saw Ryan's comments. We might want to make this another opt-in (via config). I'd hate for a consumer to go live with a project and without warning they get 404 for something they don't even care about. #_blank will always work for everyone.

@rgclayton & @auniverseaway I've made it opt-in 👍


Added Blinking Button

Issue:

@adrsh79086 please next time instead of creating a new PR, commit the changes to the previous one.


Upfront Wizard

Implements #24.
This adds an Operating System preference to the User, and allows you to set a track and operating system and locale.
For saving your locale, we need to wait for #103.
Todo:

[x] Filter display based on your preferred Operating System.
[ ] Save preferred locale.
[ ] Add a user preferences page to be able to change these at a later date.

@m50 Sorry I'm holding you up. #103 is ... a beast. :) Thanks for your work here--I can't wait to review it!

Well, the rest of this is relying on #103 to be able to properly implement.
Should I create the preferences page, or is that already being worked on?

Sounds good, I'll merge #103 into this branch and continue so.

I did one extra thing. If already logged in, going to '/' will redirect to your prefered locale. Also, after logging in, it'll redirect to your preferred locale, rather than whatever the current is, in case you log in on the english page, but your preferred locale is swedish or whatever.

Thanks for your work on this @m50!


Image.asset() doesn't load/render image when descendant of disabled TickerMode widget.

When an Image.asset() widget is a descendant of a TickerMode widget, the image will not load if the TickerMode widget's enabled property is set to false. Additionally, if the TickerMode widget is disabled after the image is loaded, then there is some weird behavior when the app is backgrounded and then brought back into the foreground. This foregrounding behavior is different between iOS and Android.
On iOS, if the TickerMode.enabled property is set to false after the image has loaded and then you background and foreground the app, the image will disappear. If the enabled property is then set to true, the image will reload. While the app is in the foreground and the image has been loaded, you can turn the enabled property on and off repeatedly without affecting the image. See the attached iOSBehavior.mp4 video for a demonstration.
On Android, if you set the enabled property to false, background the app, and then foreground it again, the image will still be visible. However, if you then set the enabled property to true, the image will flicker as it briefly disappears and reappears. Also, if the TickerMode.enabled property is true when the app is backgrounded and foregrounded, and then you set enabled to false, the image will disappear. Except for the first time after foregrounding, you can enable and disable the TickerMode widget without affecting the rendering of the image. See the attached AndroidBehavior.mp4 video for a demonstration.
Steps to Reproduce
An example app that demonstrates the problem can be found in this repository:
https://github.com/champeauxr/image_tickermode
The app has an Image.asset widget inside a TickerMode widget, along with a Switch widget (outside the TickerMode) that is used to enable/disable the TickerMode. The TickerMode is initially disabled.
For both iOS and Android:

Launch the example app
See that the image has not loaded.
Turn on the Switch widget
See that the image has loaded
Repeatedly toggle the Switch widget
See that the image remains visible.

For iOS behavior:
7. After the image is visible, turn the Switch widget off.
8. See that the image remains visible
9. Background and foreground the app
10. See that the image has disappeared
11. Turn the Switch widget on
12. See that the image has appeared.
For Android Behavior:
7. After the image is visible, turn the Switch widget off.
8. See that the image remains visible
9. Background and foreground the app
10. See that the image remains visible
11. Turn the Switch widget on.
12. See the image flicker as it briefly disappears and reappears.
13. With the Switch widget on, background and foreground the app
14. See that the image remains visible
15. Turn the Switch widget off
16. See that the image disappears

Code Example
The following is the app code contained in the example app. Reproducing the issue requires an image asset, so it is recommended to clone the following repository:
https://github.com/champeauxr/image_tickermode
The app has an Image.asset widget inside a TickerMode widget, along with a Switch widget (outside the TickerMode) that is used to enable/disable the TickerMode. The TickerMode is initially disabled.

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool _tickerEnabled = false;

  void onTickerEnabledChanged(bool value) {
    setState(() {
      _tickerEnabled = value;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          children: [
            TickerMode(
              enabled: _tickerEnabled,
              child: Image.asset('assets/17644.png'),
            ),
            const Text('Image by rawpixel.com on Freepik.com'),
            const SizedBox(height: 32),
            Row(
              children: [
                const Text('Ticker Mode'),
                Switch(value: _tickerEnabled, onChanged: onTickerEnabledChanged)
              ],
            )
          ],
        ),
      ),
    );
  }
}

flutter analyze
flutter analyze
Analyzing image_tickermode...
No issues found! (ran in 2.8s)

flutter doctor -v
flutter doctor -v
[✓] Flutter (Channel stable, 3.3.10, on macOS 12.6.1 21G217 darwin-x64, locale en)
    • Flutter version 3.3.10 on channel stable at /Users/richchampeaux/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (5 weeks ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/richchampeaux/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] Connected device (4 available)
    • Pixel 3a (mobile)             • 941AY0HYEJ                               • android-arm64  • Android 12 (API 32)
    • 160-TP iPhone 7 Plus (mobile) • ee2789b3974ca47255609a936e7172e58f01325b • ios            • iOS 14.4.2 18D70
    • macOS (desktop)               • macos                                    • darwin-x64     • macOS 12.6.1 21G217 darwin-x64
    • Chrome (web)                  • chrome                                   • web-javascript • Google Chrome 109.0.5414.87
[✓] HTTP Host Availability
    • All required HTTP hosts are available
• No issues found!

https://user-images.githubusercontent.com/8657174/213237212-ceb5d9d6-81f3-4f34-be2b-7e8b5e71339c.mp4
https://user-images.githubusercontent.com/8657174/213236607-4680dd82-f5a0-4b76-9bff-eb66dfd6a57b.mp4

Thanks @champeauxr for the detailed report.

For iOS behavior: 7. After the image is visible, turn the Switch widget off. 8. See that the image remains visible 9. Background and foreground the app 10. See that the image has disappeared 11. Turn the Switch widget on 12. See that the image has appeared.

I ran your code sample on latest versions (master and stable) and for iOS, I get a slightly different behavior than mentioned.
On master, after coming back to foreground, I see the image still on screen as shown below:
https://user-images.githubusercontent.com/67046386/213375719-04430c4c-2e11-4a5e-9bd7-560dd0db2e87.mov
However, on stable, I see the same behavior as you reported.
Can you also try the same on latest master and see if behavior persists or you see same result as mine ?
flutter channel master
flutter upgrade

@darshankawar Yes, I see that on the latest master, the iOS build no longer removes the image when you bring the app back into the foreground when the TickerMode enable property is set to false.
However, it now behaves like the Android build. So, if you turn off the switch on the app to disable TickerMode, then background and foreground the app, the image will still be displayed, but if you then turn on the switch, you will see the image flicker as it is removed and reloaded. But, more concerning is that if the TickerMode is enabled when the app is backgrouded and foregrounded, then you turn the TickerMode off, the image will disappear.
So, when the app is in the foreground, you can repeatedly turn the TickerMode on and off without affecting the rendering of the image. However, if the TickerMode is on and you background and foreground the app, then the next time you turn off the TickerMode, the image will disappear. This behavior is demonstrated in the AndroidBehavior.mp4 video.
I did some investigating of the Flutter code and see that the Image widget intentionally checks the TickerMode state in _ImageState.didChangeDependencies() and explicitly does not listen to the image stream if the TickerMode is off. This code has been there for 5 years.
  @override
  void didChangeDependencies() {
    _updateInvertColors();
    _resolveImage();

    if (TickerMode.of(context)) {
      _listenToStream();
    } else {
      _stopListeningToStream(keepStreamAlive: true);
    }

    super.didChangeDependencies();
  }

I can understand that if animations are disabled via the TickerMode widget, you would not want to animate GIFs or hold onto the image stream. However, I would think you would want to still display the first frame of the image, even if animations are disabled, particularly for non-animating images like a .PNG.
So even though it's currently intentional, I think it's a bug that the Image widget won't even decode the first (or only) frame of an image when animations are disabled. But even if it's determined that it is desired behavior, it seems like a bug that the behavior of setting TickerMode.enabled to false changes depending on whether the app just came back into the foreground.

Thanks for the feedback.

 stable, master flutter doctor -v
[✓] Flutter (Channel stable, 3.3.10, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.10 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (15 hours ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.7.0-24.0.pre.21, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.7.0-24.0.pre.21 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52d1205b88 (21 minutes ago), 2023-01-19 23:50:24 -0500
    • Engine revision 730e88fb67
    • Dart version 3.0.0 (build 3.0.0-136.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Add support for CHL Issue #128 Mutually Exclusive Abilities

Thanks for saving me the effort. I'm going to wait for this to be merged and published in the CH.

Just a reference for the corrosponding Highlander PR: https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/pull/129


NioDatagramChannel.newSocket() fails on Java 1.6

The download page on the website states:

Please note that Netty has no mandatory external dependencies. JDK 1.5 (1.6 for Netty 4+) or above is all that you need to run Netty.

In an app on Mac OS X 10.9 running Java 1.6; however, attempting to create a new NioDatagramChannel, while running Netty 4.1 Beta3, will cause an UnsupportedOperationException. When NioDatagramChannel.newSocket() [L:98] is called it will call checkJavaVersion(). A check will be made: if(PlatformDependent.javaVersion() < 7) and then the exception is thrown:
java.lang.UnsupportedOperationException: Only supported on java 7+.
If 4.1 can't handle datagram sockets on Java versions < 1.7 then a note should be added to the site. Otherwise, this seems like a bug.

@Scottmitch I think all the dependencies can be found in the pom.xml of the modules. So let me close it


No cron jobs will run when catalogrule_apply_all is processing

Hi,
I seem to have an issue that no CRON jobs are run when catalogrule_apply_all is running.
I have the following error from cron:
[2021-01-10 05:21:03] INFO Healthchecking Cron Service
[2021-01-10 05:21:04] INFO Running Process Cleanup
[2021-01-10 05:21:04] INFO Running Consumers Cleanup
[2021-01-10 05:21:04] INFO Starting Cron Service

In ErrorHandler.php line 61:

  Notice: Undefined offset: 8874 in /var/www/html/vendor/magemojo/m2-ce-cron/
  Model/Schedule.php on line 474

cron:run [--group GROUP] [--bootstrap BOOTSTRAP]

And the appropiate error in system.log:
[2021-01-10 05:21:04] main.ERROR: Notice: Undefined offset: 8874 in /var/www/html/vendor/magemojo/m2-ce-cron/Model/Schedule.php on line 474
#0 /var/www/html/vendor/magemojo/m2-ce-cron/Model/Schedule.php(474): Magento\Framework\App\ErrorHandler->handler(8, 'Undefined offse...', '/var/www/html/v...', 474, Array)
#1 /var/www/html/vendor/magemojo/m2-ce-cron/Model/Schedule.php(517): MageMojo\Cron\Model\Schedule->getJob('8874')
#2 /var/www/html/vendor/magemojo/m2-ce-cron/Model/Schedule.php(368): MageMojo\Cron\Model\Schedule->service()
#3 /var/www/html/generated/code/MageMojo/Cron/Model/Schedule/Proxy.php(207): MageMojo\Cron\Model\Schedule->execute()
#4 /var/www/html/vendor/magemojo/m2-ce-cron/Console/Command/CronCommand.php(75): MageMojo\Cron\Model\Schedule\Proxy->execute()
#5 /var/www/html/vendor/symfony/console/Command/Command.php(255): MageMojo\Cron\Console\Command\CronCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(58): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(138): MageMojo\Cron\Console\Command\CronCommand\Interceptor->___callParent('run', Array)
#8 /var/www/html/vendor/magento/framework/Interception/Interceptor.php(153): MageMojo\Cron\Console\Command\CronCommand\Interceptor->Magento\Framework\Interception\{closure}(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /var/www/html/generated/code/MageMojo/Cron/Console/Command/CronCommand/Interceptor.php(23): MageMojo\Cron\Console\Command\CronCommand\Interceptor->___callPlugins('run', Array, Array)
#10 /var/www/html/vendor/symfony/console/Application.php(1009): MageMojo\Cron\Console\Command\CronCommand\Interceptor->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /var/www/html/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(MageMojo\Cron\Console\Command\CronCommand\Interceptor), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 /var/www/html/vendor/magento/framework/Console/Cli.php(115): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 /var/www/html/vendor/symfony/console/Application.php(149): Magento\Framework\Console\Cli->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 /var/www/html/bin/magento(23): Symfony\Component\Console\Application->run()
#15 {main} [] []

any help to debug this is appreciated

I came here to report the same exact problem, only to discover @zjevik already opened an issue.
After (re-)starting the cron, it seems to last exactly an hour when this error is raised again. After that, cron jobs are no longer run and the cron needs restarting manually.
I was not able to debug it, but I did notice that:

the error message for Undefined offset: 4385 was logged at 16:19:06
the var/cron/schedule.4385 file does exist but its timestamp is 16:19:10

I'm not sure if my observation above means anything as I'm not sure if catalogrule_apply_all is the cause of this error for me (as I don't have it in my schedule).
Luca

I came here to report the same exact problem, only to discover @zjevik already opened an issue.
After (re-)starting the cron, it seems to last exactly an hour when this error is raised again. After that, cron jobs are no longer run and the cron needs restarting manually.
I was not able to debug it, but I did notice that:

the error message for Undefined offset: 4385 was logged at 16:19:06
the var/cron/schedule.4385 file does exist but its timestamp is 16:19:10

I'm not sure if my observation above means anything as I'm not sure if catalogrule_apply_all is the cause of this error for me (as I don't have it in my schedule).
Luca

Following on @jaxtheking I tried to run this module on a clean 2.4.1 installation and the errors go in and out quite randomly. The Cron will stop working for 20 minutes, then works for some time and then doesn't work, etc.
The behaviour is quite strange but one shouldn't install this module in the current version on 2.4.1

Following on @jaxtheking I tried to run this module on a clean 2.4.1 installation and the errors go in and out quite randomly. The Cron will stop working for 20 minutes, then works for some time and then doesn't work, etc.
The behaviour is quite strange but one shouldn't install this module in the current version on 2.4.1

Hi @zjevik, I think I managed to keep the crons going by basically reverting commit https://github.com/magemojo/m2-ce-cron/pull/111/commits/b61a48113d64810596cb782852f5ca303f511fb9.
I traced the problem to the service loop, where the code checks for running jobs (determined by the presence of a file in var/cron e.g. cron.4385). However, when the schedule id is passed to getJob, that function throws an error if - or should I say when - said schedule id does not exist within the pendingjobs array.
Therefore, try replacing the getJob function in vendor/magemojo/m2-ce-cron/Model/Schedule.php with the following to see if the cron jobs keep running:
    /**
     * Set a job by schedule id
     *
     * @return array
     */
    function getJob($scheduleid) {
      if (in_array($scheduleid, $this->pendingjobs)) {
        return $this->pendingjobs[$scheduleid];
      }
      return NULL;
    }

I'd be curious to see if it works for you too...

Hi @zjevik, I think I managed to keep the crons going by basically reverting commit https://github.com/magemojo/m2-ce-cron/pull/111/commits/b61a48113d64810596cb782852f5ca303f511fb9.
I traced the problem to the service loop, where the code checks for running jobs (determined by the presence of a file in var/cron e.g. cron.4385). However, when the schedule id is passed to getJob, that function throws an error if - or should I say when - said schedule id does not exist within the pendingjobs array.
Therefore, try replacing the getJob function in vendor/magemojo/m2-ce-cron/Model/Schedule.php with the following to see if the cron jobs keep running:
    /**
     * Set a job by schedule id
     *
     * @return array
     */
    function getJob($scheduleid) {
      if (in_array($scheduleid, $this->pendingjobs)) {
        return $this->pendingjobs[$scheduleid];
      }
      return NULL;
    }

I'd be curious to see if it works for you too...

I figure out my issue with the default cron runner and I no longer need to use this module. See https://github.com/magento/magento2/issues/31752
This is no longer my priority and won't be probably using this module in the future. I have 1M+ products and any debugging is very time consuming.
I will try to make the change in my development system in the future but it might take some time.

I figure out my issue with the default cron runner and I no longer need to use this module. See https://github.com/magento/magento2/issues/31752
This is no longer my priority and won't be probably using this module in the future. I have 1M+ products and any debugging is very time consuming.
I will try to make the change in my development system in the future but it might take some time.

I can confirm that reverting commit https://github.com/magemojo/m2-ce-cron/commit/b61a48113d64810596cb782852f5ca303f511fb9 solved the issue for me and that the cron jobs have now been running for the last 10 days without stopping.
Could I ask for your input @gnuzealot? Can you see why the changes in that commit would cause the problems described in this issue and evaluate if it's the case to revert it?
Thanks,
Luca

This should be resolved with https://github.com/magemojo/m2-ce-cron/pull/114


Carbon conflict versions

Laravel Version: 5.6.25
PHP Version: 7.2.7
Database Driver & Version: mysql 5.7

Description:
I need some carbon methods, but this methos aren't available.
I tried update carbon, but...

  Problem 1
    - laravel/framework v5.6.25 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.6.25 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.6.25 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - Installation request for laravel/framework (locked at v5.6.25, required as 5.6.*) -> satisfiable by laravel/framework[v5.6.25].

Steps To Reproduce:
Put in some view $model->created_at->localeMonth
var_dump($dt->localeMonth);                                  // string(7) "Oktober"
var_dump($dt->shortLocaleMonth);                             // string(3) "Okt"

And I received this error
"Unknown getter 'localeMonth' (View: /home/igor/projetos/portalcea/resources/views/front/index.blade.php)"

This method above are available on Carbon docs

I updated the app to laravel 5.6.28 and same error:
$ composer require nesbot/carbon
Using version ^1.32 for nesbot/carbon
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laravel/framework v5.6.28 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.6.28 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.6.28 requires nesbot/carbon 1.25.* -> satisfiable by nesbot/carbon[1.25.0] but these conflict with your requirements or minimum-stability.
    - Installation request for laravel/framework (locked at v5.6.28, required as 5.6.*) -> satisfiable by laravel/framework[v5.6.28].

Installation failed, reverting ./composer.json to its original content.

That is because laravel/framework has locked Carbon to version 1.25.*
https://github.com/laravel/framework/blob/5.6/composer.json#L26
while latest carbon version is 1.32.0

I also have this issue couple days ago. Since the Carbon version is locked to 1.25.*, I ended up recreating the method I need in my application. Is there any solution to have latest Carbon version (1.32.0) while using Laravel 5.6?

It would be nice if we can use Carbon 1.29.0 or higher for CarbonPeriod.

Maybe if you update Laravel to a new version that supports the version of Carbon you need the functions will be available.

I updates already, do not works, see messages below.
Em sex, 27 de jul de 2018 18:42, Gabs<EMAIL_ADDRESS>escreveu:

Maybe if you update Laravel to a new version that supports the version of
Carbon you need the functions will be available.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/24961#issuecomment-408545900,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs-SR6M_WOQ99bRPJjC4tLZ7Szx9wB0ks5uK4lXgaJpZM4VeMFf
.

Why closed without answer?

5.7 doesn't lock the carbon version.

Ok, thank you very much.
The 5.7 version already date to leave?

5.7 release will be released at the end of this month, probably with Laracon EU.

Hello,
I'm working on my first project which is built with Laravel and previously I was working on projects built with CakePHP. In CakePHP, they organize all issues into milestones with a due date for each milestone also they have a roadmap for each minor release into their GitHub wiki page. Does Laravel has something like this so we can know what is coming in the new releases? I'm so sorry if this already exists as I'm new in Laravel.
Thanks

@BassemN theoretically the milestones laravel is in each 6 months.

@IgorDePaula Thanks allot and where can I find these milestones with its new features?

http://laravel-news.com @BassemN

Laravel 5.7
λ composer require nesbot/carbon
Using version ^2.1 for nesbot/carbon
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - laravel/framework v5.7.0 requires nesbot/carbon ^1.26.3 -> satisfiable by nesbot/carbon[1.26.3, 1.26.4, 1.27.0, 1.28.0, 1.29.0, 1.29.1, 1.29.2, 1.30.0, 1.31.0, 1.31.1, 1.32.0, 1.33.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.7.0 requires nesbot/carbon ^1.26.3 -> satisfiable by nesbot/carbon[1.26.3, 1.26.4, 1.27.0, 1.28.0, 1.29.0, 1.29.1, 1.29.2, 1.30.0, 1.31.0, 1.31.1, 1.32.0, 1.33.0] but these conflict with your requirements or minimum-stability.
    - laravel/framework v5.7.0 requires nesbot/carbon ^1.26.3 -> satisfiable by nesbot/carbon[1.26.3, 1.26.4, 1.27.0, 1.28.0, 1.29.0, 1.29.1, 1.29.2, 1.30.0, 1.31.0, 1.31.1, 1.32.0, 1.33.0] but these conflict with your requirements or minimum-stability.
    - Installation request for laravel/framework (locked at v5.7.0, required as 5.7.*) -> satisfiable by laravel/framework[v5.7.0].

Installation failed, reverting ./composer.json to its original content.

you cannot install v2 of Carbon, Laravel 5.7 requires v1.

@browner12 as you see i just tried with default command line composer require nesbot/carbon
Questions

Why I cannot get latest updates of carbon?
What command should I use to install it?

Yet this problem? I not believe that carbon dependence not upgraded in laravel 5.7.

carbon is already included in Laravel's requirements.
https://github.com/laravel/framework/blob/5.7/composer.json#L26
You do not need to do anything additionally to install it.
You cannot get the latest version of Carbon because Laravel requires version 1.

My God

Can we upgrading it to v2.1.0 please?
cc: @themsaid @taylorotwell

you don't need to ping them, they are very aware of which Carbon version we are on.
Unfortunately this is not a simple upgrade, and since Carbon is relatively tightly integrated with Laravel, this upgrade will require some work.
Any moderator, could we lock this issue down? We seem to be getting a little off track.

Work is underway but needs some time and won't be in 5.7 any way, see https://github.com/laravel/framework/pull/25320 .
(And it's generously done by the top contributor to Carbon, too)

@browner12 Thanks for the response. The only reason I tagged them was because I felt this issue required their intervention.
Glad that we have another issue for this 😄.

hahaha, include in laravel now .... cool

Only in laravel 5.8 proposal. more 6 months =/

Yeah.... That's kind of sad... Will have to create custom functions until then... 😞


[SPARK-49983][CORE][TESTS] Fix BarrierTaskContextSuite.successively sync with allGather and barrier test case to be robust

What changes were proposed in this pull request?
This PR aims to fix BarrierTaskContextSuite.successively sync with allGather and barrier test case to be robust.
Why are the changes needed?
The test case asserts the duration of partitions. However, this is flaky because we don't know when a partition is triggered before barrier sync.
https://github.com/apache/spark/blob/0e75d19a736aa18fe77414991ebb7e3577a43af8/core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala#L116-L118
Although we added TestUtils.waitUntilExecutorsUp at Apache Spark 3.0.0 like the following,

#28658

let's say a partition starts slowly than 38ms and all partitions sleep 1s exactly. Then, the test case fails like the following.

https://github.com/apache/spark/actions/runs/11298639789/job/31428018075

BarrierTaskContextSuite:
...
- successively sync with allGather and barrier *** FAILED ***
  1038 was not less than or equal to 1000 (BarrierTaskContextSuite.scala:118)

According to the failure history here (SPARK-49983) and SPARK-31730, the slowness seems to be less than 200ms when it happens. So, this PR aims to reduce the flakiness by capping the sleep up to 500ms while keeping the 1s validation. There is no test coverage change because this test case focuses on the successively sync with allGather and battier.
Does this PR introduce any user-facing change?
No, this is a test-only test case.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

LGTM, the tests in Build (pull_request_target) all passed. Thank you!

Thank you so much, @xinrong-meng .
Merged to master/3.5/3.4.


Display full url in messages

When wd-41 starts, the following is displayed:
2024-10-30T21:12:23Z ok: now serving directory: '/root/wd-41' on port: '8080', mirror dir is: '/tmp/wd-41_1660140152', tls: false, certPath: '', keyPath: ''

Since my terminal emulator recognizes URL (as I suspect quite a few do), it'd be much more useful for me to have a fuil URL displayed here than I can click on. So this PR replaces the former greeting message with:
2024-10-30T21:16:18Z ok: Server started successfully:
2024-10-30T21:16:18Z ok: - URL: http://localhost:8080
2024-10-30T21:16:18Z ok: - Serving directory: '/root/wd-41'
2024-10-30T21:16:18Z ok: - Mirror directory: '/tmp/wd-41_4088355689'
2024-10-30T21:16:18Z ok: - TLS disabled

I'm happy to have something else appear as long as http://localhost:8080 is somewhere to be found in the output.
Thanks for the useful tool at any rate!

Ah glad it helps!  I'll fix that post-merge. Thank for your contribution!


Feature : Simplification of the Search Page

Is your feature request related to a problem? Please describe
Search page with user friendly interface is required and also in the current search page
Describe the solution you'd like
Proposed Design : Figma Link
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

which section plz provide link these search page

@Asrani-Aman Can you please assign this to me?

@Asrani-Aman i am totally new to open source can you suggest me some beginner friendly issues

@adityaJoshi07 you can try to find all the existing issues you think you can resolve or can create new one by exploring CircuitVerse
as we are migrating to view components you can make some generous components that enhance code readability maintainability, but before working directly make sure you get. to assign that issue first after verifying from the mentors

Really intrested to work on the issue, Can I?

@Asrani-Aman  I can start working on this right now, could you please assign it to me?

Hi, I’m interested in contributing to this issue. Could you confirm if it’s ready for work or if there’s any additional context I should know? Thanks!

Hii , @Asrani-Aman I want to contribute to this issue, please accept my request ?

Hey Guys you can work on issue once approve your designs with org Admins and UX lead, then they will assign you


opal-webpack-loader require_tree -> webpack addDirectory

new file hot loading doesnt work so much for new files created, need to transfer the require tree knowledge of the compile server to the webpack loader

require tree knowledge is make known to webpack from owl 0.6.0, but new files in a require_tree still don't get picked up. Needs probably some more webpack config tweeking.

found the extra-watch-webpack-plugin, adjusted config, this will be fixed in 0.6.5


[Bug]: When the name and value are not passed for two of the options no validation message is displayed for duplication

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
it is observed that when the user does not pass name and value for two of the radio options then no validation message displayed for the duplication
Expecting a validation message similar to checkbox group widget

Steps To Reproduce
1.Launch Appsmith app in release/Prod Environment
2.Drag and drop Radio widget
3.Remove the default options name and value for both of the options and observe
4.Similarly try to the CheckboxGroup widget and compare

Environment
Release
Version
Cloud

Related to #8593

Fix is to show the error in the debugger for radio widget when the name and value are empty.

Not able to replicate @YogeshJayaseelan can you check once?

@dilippitchika Now when the key and value field are empty 'The value at option is invalid' error occurs and looks fine now


Reflections library version incompatible with Swagger version

Change org.reflections version to 0.9.9-RC1

Merged into release-0.3.1


A little credit?

I'm flattered that you found my work useful. While i understand everything is open-source and all and I personally believe in any useful contribution, you should at least pay a little attribution to the original authors work. https://github.com/web-mech/badwords. Thanks.

Hi web-mech,
Sorry for late response. I have updated the description with the credit information on Github and npm.
Please let me know if you have any suggestion or comment on it, thank you.

Thank you! Very much appreciated.

Thank you! Very much appreciated!


Conflicting dependencies in scripts/requirements.txt

The PR https://github.com/MTG/mtg-jamendo-dataset/pull/26 introduced a new minor version for urllib3 which is not compatibel with the required requests version.
ERROR: Cannot install -r scripts/requirements.txt (line 16) and urllib3==1.26.5 because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested urllib3==1.26.5
    requests 2.22.0 depends on urllib3!=1.25.0, !=1.25.1, <1.26 and >=1.21.1
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

I guess this mix of pinned versions with occasional version bumps might lead to confusion among users.
Why not

rename the requirements.txt file to something like requirements-to-reproduce.txt and
add a new requirements.txt file that only specifies versions for packages that this project directly depends on (i.e. this project only depends on requests which in turn depends on urllib3)

If that is not an option, the conflict can be resolved by either

updating requests to requests~=2.25.0 or
downgrading urllib3 to urllib3~=1.25.0

Bumped requests version in 31507d6, nothing seems to be broken


Statemine & Statemint has the wrong slip44

The logic for the apps are here -
https://github.com/Zondax/ledger-substrate-js/blob/25a8760ac52db737f0a90df93f6d6e009e60764b/src/index.js#L364-L369
It should be (without the Equilibrium slip44) -
function newStateMintApp(transport) {
  return new SubstrateApp(transport, CLA.STATEMINT, SLIP0044.STATEMINT)
}

function newStateMineApp(transport) {
  return new SubstrateApp(transport, CLA.STATEMINE, SLIP0044.STATEMINE)
}

Unable to test myself, but this apparently leads to issues when theses apps are created and attached (address retrieval) as per feedback from Statemine testers.

Thanks @jacogr !

We have fixed the bugs
Released a new npm package https://github.com/Zondax/ledger-substrate-js/releases/tag/v0.16.2
Released a new statemine app

In order to communicate correctly the purpose of the npm package, we have renamed it to @zondax/ledger-substrate and deprecated in the last few days the previous package.
https://www.npmjs.com/package/@zondax/ledger-substrate
We recommend replacing and upgrading to the more recent version of @zondax/ledger-substrate


FIX: Too many item message and add possibility to change it

When droping an item to the ground and there was too many item, the message was display on the character journal instead of ON the item. It's because the update was not done and your client did not see the item. By putting an Update before, it's fix.
THis part fix the issue like coruja did on #64.
I added the possibility to customize the message by script. For exemple, a french shard don't want to see "Too many items here!"
Don't forget approuve the new script pack message: https://github.com/cbnolok/SphereX-Scriptpack/pull/60

Do you need to add this mesage to the other script pack as well to ?

As a suggestion, some comments with old code are left there for a reason, it's better to preserve it instead of wiping it

@Nirad i have pr old of 1 year on other script pack (56d)   I dont do PR there anymore


[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30][$100] New Expensify Crashing at Login

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:  v9.0.52-0
Reproducible in staging?: yes
Reproducible in production?: no
Issue reported by: @grgia
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1729574128664629
Action Performed:

[ ] Log into any account with magic code or magic code + auth code

Note: this does not impact google login
Expected Result:
Log in as normal
Actual Result:
Web App Crashes, user is stuck on "uh oh something went wrong" page
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
![image](https://github.com/user-attachments/assets/a3527419-a461-4025-a3ad-e218f70ca7e2)
console errors:
react-dom.production.min.js:188 FirebaseError: Performance: Attribute value  is invalid. (performance/invalid attribute value).
    at je.putAttribute (index.esm2017.js:1165:33)
    at index.web.ts:25:19
    at Array.forEach (<anonymous>)
    at Object.startTrace (index.web.ts:24:32)
    at Object.start (Timing.ts:24:18)
    at ci (AuthScreens.tsx:248:16)
    at fo (react-dom.production.min.js:160:137)
    at vA (react-dom.production.min.js:289:337)
    at Il (react-dom.production.min.js:279:389)
    at pl (react-dom.production.min.js:279:320)
ds @ react-dom.production.min.js:188
Cs.i.componentDidCatch.n.callback @ react-dom.production.min.js:189
Hi @ react-dom.production.min.js:156
yA @ react-dom.production.min.js:260
IA @ react-dom.production.min.js:259
mA @ react-dom.production.min.js:258
(anonymous) @ react-dom.production.min.js:282
El @ react-dom.production.min.js:280
al @ react-dom.production.min.js:269
b @ scheduler.production.min.js:13
k @ scheduler.production.min.js:14
e.exports @ _invoke.js:5
p.<computed> @ _task.js:35
I @ _task.js:21
y @ _task.js:25
Show 15 more frames
Show less

[alrt] NewExpensify crash caught by error boundary - Performance: Attribute value  is invalid. (performance/invalid attribute value). - {"errorInfo":"{\"componentStack\":\"\\n    at ci (https://staging.new.expensify.com/783-f43f02ecb7442bab801f.bundle.js:1:771247)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at Suspense\\n    at Uo (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:176621)\\n    at h (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:646341)\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:650116\\n    at l (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:689589)\\n    at I (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:692113)\\n    at Yo (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:177081)\\n    at Ka (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:145387)\\n    at pr (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:185756)\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at i (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:710096)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3255548)\\n    at ae (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:111245)\\n    at ce (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:112234)\\n    at i (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2416759)\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2086117\\n    at n (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:1593704)\\n    at T (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3299295)\\n    at A (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2493744)\\n    at c (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2495867)\\n    at r (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2490890)\\n    at i (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2491636)\\n    at T (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2515935)\\n    at h (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:104196)\\n    at s (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:448395)\\n    at v (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:104791)\\n    at i (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2498120)\\n    at D (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:1259424)\\n    at c (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:4102768)\\n    at https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2414777\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at l (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2496670)\\n    at c (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2372623)\\n    at c (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2498803)\\n    at t.default (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3385069)\\n    at t.default (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3382100)\\n    at t.default (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3386440)\\n    at t.default (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3383846)\\n    at y (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3366728)\\n    at C (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3380567)\\n    at ua (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:139317)\\n    at pa (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:144241)\\n    at https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2324994\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at t (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2497633)\\n    at Oa (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:144524)\\n    at I (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:584115)\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at A (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3530311)\\n    at f (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3531967)\\n    at Sa (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:144625)\\n    at i (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2446114)\\n    at d (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2445462)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at a (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2356999)\\n    at o (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:3348273)\\n    at o (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:710499)\\n    at L (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2358102)\\n    at o (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:710499)\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at vr (https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:1168588)\\n    at d (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:2323482)\\n    at c (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:435660)\\n    at fr (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:192204)\\n    at Mr (https://staging.new.expensify.com/main-f0c0a855369992decad4.bundle.js:1:192241)\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at div\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2211971\\n    at https://staging.new.expensify.com/vendors-3add3da828adbc84d4bb.bundle.js:2:2110243\"}"}

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @OfstadC

Linked to https://github.com/Expensify/App/pull/51176

QA team was logged it already https://github.com/Expensify/Expensify/issues/437892

Closing the internal GH since it's a frontend regression.

Fix working well in staging 👍

@grgia @lakchote
I helped with the fix. Can bounty be considered here?

@lakchote @grgia
Can you please have a look at this comment when you get a chance? Thanks!

I helped with the fix and tested the PR. Can bounty be considered here?

I tested and pushed the fix to speed things along, so you were a great help with that! This is a weird case since that PR had no C+ and normally we'd have the original author/C+ fix it. Given that, I think $100 is fair for the review of this since we only tested for web. @OfstadC could you please help with C+ review payment to @c3024 for review of https://github.com/Expensify/App/pull/51226.
cc @lakchote

So just to make sure, we are issuing $100 to @cdOut ? No one else needs payment here @grgia ? 😃

$100 for me. cdOut is from an expert agency.

This might be a mistake as I haven't taken part in this issue as far as I remember.

OMG I'm sorry - I tagged the wrong person accidentally 🤦♀

Offer sent here @c3024 - https://www.upwork.com/nx/wm/offer/104682989

Accepted, thanks!

Payment Summary

Paid @c3024 $100 via Upwork

If payment needs to be issued to anyone else, feel free to ping me 😃


Fix MulticastLogger#datetime_formatter

The code for Ruby's Logger#datetime_formatter is as follows:
def datetime_format
  @default_formatter.datetime_format
end

In the MulticastLogger, neither @default_formatter is set or super called to set this in the default manner, so this value is always nil when this method is called on MulticastLogger and thus returns an error.
This fixes that by setting @default_formatter to VMDBLogger::Formatter.new even though it will never be used to log anything, simply because this was what is used by default in the other loggers.
Set @formatter to nil as well as that is also what is done in ruby's source in Logger#initialize to avoid potential warnings.
Links [Optional]

https://github.com/ruby/ruby/blob/c1718e988/lib/logger.rb#L300-L302
https://github.com/ruby/ruby/blob/c1718e988/lib/logger.rb#L382

Steps for Testing/QA

Open up a Rails console
Run $azure_log.datetime_format

On master, it should blow up.  With this patch, it should return nil.

👍

@miq-bot add_label bug
cc @bdunne @Fryguy

I'm going to :-1: this.  I feel like adding more complexity is worse, and this is the second issue like this.  Instead of playing whack-a-mole with missing methods, can we get rid of MulticastLogger < Logger and just delegate all calls instead?

Where did you notice this?

@djberg96 made note of it in the provider's channel, specifically here:
https://gitter.im/ManageIQ/manageiq/providers?at=5abab883f3f6d24c68c194fa

Is there anything we can add tests for?

Yes, sounds good... though, @Fryguy chimed in as I was typing here... so a difference of opinions has clearly surfaced...

Instead of playing whack-a-mole with missing methods, can we get rid of MulticastLogger < Logger and just delegate all calls instead?

So we (@Fryguy and myself) had a longer conversation about this in the gitter channel (shortly after the links in the description), but I think the general theme is that we probably want to move away from the MulticastLogger in it's current form.
My 2 cents:  I think we should do that eventually, but I think that possibly merging and backporting this to G, and making this change in prep for H makes the most sense to me (I think making a larger fix and trying to backport that is much riskier).  That said, I think this plan making sense hinges on the use case that @djberg96 was having issues with that caused this PR to be open in the first place.
</2cents>

@bdunne Added some specs, a lot actually.
Based the other conversations, tried to make them "integration-y", where they are testing the global constants themselves, instead of a newly created instance to make sure what is used in the app are responding as expected.
This means they might be a little more brittle, and I had to do a decent amount of jerry-rigging to make them idempotent (cross your fingers I succeeded in that...),  with the goal that it will hopefully allow us to swap out the underlying implementation of the MulticastLogger in the future if we decide to go that route, but still keep these tests as a safety net.
Let me know if you think I should test anything else while I am at it, as I don't think these tests are exhaustive by any means.
cc/ @Fryguy @djberg96

Update:  Added https://github.com/ManageIQ/manageiq/pull/17227 as a POC for using ActiveSupport::Logger.broadcast instead of MulticastLogger:
https://github.com/ManageIQ/manageiq/pull/17227
On the fence about it if it is a good idea, but just throwing that out there as a option for the #future™.

Honestly, I'm less interested in refactoring and redesigning this.  I think in master we can go the path that @jrafanie prefers and just delete this code.  It was originally added to bridge the gap where we need to write both to a log file (for appliances) and STDOUT (for containers).  Is there any reason we still need to log to files on master?

@bdunne Does that mean you favor #17227? If not, what do you suggest?

Is there any reason we still need to log to files on master?

Because we're not going fully podified?

I favor #17227 personally.

I favor #17227 personally.

For master, I agree.  Again, my #2cents™ above was more suggesting that this should be a backport PR (but get it into master) to then be overwritten by #17227 .
That said, https://github.com/ManageIQ/manageiq/pull/17228 by @djberg96 might address his concerns just fine, which his issues were the main reason I opened this up, and might only be tangentially related (not sure myself since I am not looking at it from a usage perspective like Dan is).


allow passing scalar numbers

The following currently throws an error (TypeError: 'int' object is not iterable):
import filefinder
ff = filefinder.FileFinder("", "{num}", test_paths=["1", "2"])
ff.find_files(num=1)

the workaround is:
ff.find_files(num=[1])

I do wonder why this works for strings - it should not iterate the individual letters?

They are wrapped in:
https://github.com/mathause/filefinder/blob/ab49e18fe0563dcb526cdc62d1ee05342cc67b7b/filefinder/_filefinder.py#L86-L89

Maybe:
if isinstance(value, str) or np.ndim(value) == 1:
    ...


Allow token_info response to use 'scopes' key

Some oauth libraries use the key 'scopes' instead of 'scope' in the token info response.
https://github.com/doorkeeper-gem/doorkeeper/wiki/API-endpoint-descriptions-and-examples
Changes proposed in this pull request:

Allow token info responses that use 'scopes' instead of 'scope'

Coverage remained the same at 100.0% when pulling 632a30d35b8e1227db4ce1898671a68793b492e1 on skaasten:scopes_vs_scope into 4486438e70788c1bb24e35035f38c1550663dea1 on zalando:master.

I don't understand your change proposal, the docs you are linking to are talking about the RFC 7662 OAuth 2.0 Token Introspection which returns the scope field, see https://tools.ietf.org/html/rfc7662#section-2.2

Here's the example, in that linked document further down, of the response from the token/info call implemented by doorkeeper:
curl -H "Authorization: Bearer 53cff8f4a549beb1c38704158b0f6608a2382f094b6947ecc35c2eed4146a17c"
localhost:3000/oauth/token/info

### command output
{"resource_owner_id":1, "scopes":[], "expires_in_seconds":7178, "application":{"uid":null}, "created_at":1440460991}

@skaasten OK, I see and now it makes sense!

:+1:


Add missing unit tests

It seems I've fallen behind with testing in some places while rushing new features in.
At least the following bits are missing tests (feel free to add to the list or tell me, if you spot more):

[x] Samplesheets study sub-apps
[ ] Samplesheets assay sub-apps
[ ] Landingzones UI (If we get to implementing #325 these would have to be redone anyway)
[ ] Timeline behaviour on different apps which use it (see undefined##undefined)
[x] Irodsbackend API view permissions (#417)
[ ] Template tags
[ ] Everything in #556

Closing this old and too generic issue. Specific tickets should be raised regarding missing tests for specific modules/functionality.


Process master routes

@mehdisadeghi what do you mean by this? what information can you extract from this that is not available somewhere else?

@carocad quote from route_master page on OSM website:
Relations of type route_master contain all the direction and variant routes and the information that belongs to the whole service.

By processing them I want to make sure that we are not missing any route related information. I'm not yet sure whether we can add anything to the current GTFS output however.

Closing as seems so far unnecessary. Feel free to reopen if needed.


Simply Wall Street's paywall is not blocked

Unfortunately instructions for me are unclear how to create rule for removing paywall, so I ask somebody to do this.
Link (it's showing paywall only when stock is chosen) - https://simplywall.st/stocks/us/tech/nasdaq-aapl/apple

Added in 2db34ca15952075919ea74dd3901fe179c232c27, thanks!

Thanks for answer, unfortunately nothing changed :( Version 1.0.2 Last updated 24 Jan

Strange, it does work for me in both Firefox and Chrome. The window pops up for a moment and gets removed. Does refreshing the page do anything? You didn't accidentally allow modals on the website in the extension popup? Does the extension report any blocked modals?

I am very sorry, my mistake. I indeed allowed modals on website. Thank you

No worries, I'm glad it's working after all. :)


Update to latest package versions

Can be merged once lapce-plugin-rust is updated

Meant to create the PR to the main branch


Checked Exceptions are not causing a failure event

Hi,
If a checked exception is thrown inside of a .item() - handler, it does not cause a failure event.
kotlin example
Uni.createFrom().item { throw Exception("checked exception") }
.onFailure(f -> println(f))

The above uni will never print the error (and pretty sure it will also never terminate, since this issue caused deadlocks in our application). If a RuntimeException is thrown, everything is fine.

Oh, I didn't know that about Kotlin.
For Java we have the "Unchecked" utility classes (https://smallrye.io/smallrye-mutiny/guides/unchecked), but if Kotlin can write such a code, we should be able to catch the thrown exception.
Any Kotlin user that knows the type of exception thrown in this case.
CC @jponge

Oh, BTW, the second line should be:
.onFailure().invoke(f -> println(f))

Ok so in Kotlin there is no notion of checked exception, and when you throw a java.lang.Exception (or any other checked exception) then MultiCreate#item will not handle them, only runtime exceptions.
This actually makes sense, because a supplier cannot throw a checked exception, so you can't write this in Java:
Multi<Integer> multi = Multi.createFrom().item(() -> {
  throw new Exception("boom");
});

...but this is fine for Kotlin which is more permissive here.

I'm tempted to say this is not a bug, because in Java you can't have this, this is specific to Kotlin and its laxer type checking wrt exception control flow.

Java has made "sneaky throws" really easy -- here's my favorite implementation:
public class SneakyThrow {
    private SneakyThrow() {
    }

    /**
     * This method can and should be used as part of a {@code throw} statement,
     * such as: {@code throw sneakyThrow(exception);}. It is guaranteed to never return normally,
     * and this style of usage makes sure that the Java compiler is aware of that.
     */
    @SuppressWarnings("unchecked")
    public static <E extends Throwable> RuntimeException sneakyThrow(Throwable e) throws E {
        throw (E) e;
    }
}

So you can have this in Java, really easily: throw sneakyThrow(new Exception("boom"));

Yes this is evilish @Ladicek 😆

So it's interesting, perhaps we need to catch better "just in case"

I'm looking into it.

I opened #534 to fix that.

Thanks @ferencbeutel4711 for reporting

hey guys, thank you so much for the quick fix!
We are using Mutiny via Quarkus, do you know how the usual release process works in that scenario?

It will be part of 0.17, we tend to release about once a month, then it's upgraded in Quarkus.


[RHCLOUD-20441] refactor: replace query structs with explicit "where" conditions

In order to avoid hitting the issue of selecting unexpected data due to
Gorm treating default values as "should not include as where condition",
this commit removes all the structs that were used in queries, and has
replaced them with explicit "where" conditions instead.
Links
[RHCLOUD-20441]

/retest


Add other GR diagnostic quantities: Kretschmann scalar, ADM mass, etc.

@TaigoFr has code that calculates other curvature quantities such as the Kretschmann scalar. This should be added along with the ADM mass integrand calculation code once #88 has been done.

We should also investigate the alternative mass formula in equation (A.26) of Alcubierre.


helm: Refer to the correct Helm value

The operator deployment template was incorrectly referring to dnsPolicy
instead of operator.dnsPolicy.
Fixes: 307df356c2 ("helm: Make DNS policy for agent and operator configurable")
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>Helm: Use the correct operator.dnsPolicy value for the operator deployment template

noticed this while backporting to v1.11 here: https://github.com/cilium/cilium/pull/20842 😞


fix ocv_add_module CMake macro (2.4):

it tries to remove 'opencv_' prefix from 'name' variable, but
it creates new variable with the same name as module

@SpecLad I removed this line.

:+1:


Created 42 Urduliz Token

Created by JOKITON.
Thank you JetBrains!

Official Page: https://www.42urduliz.com/

@JOKITON First stage of verification passed, official domain is 42urduliz.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@JOKITON Pull request merged. Thank you.

Thank you!!
Have a great day man!!


How can I use the code?

Firstly, thanks for your good work! BTW, How can I use the code?
Could you please give me an expample to  run these py files?

Thank you for your interest! I should've added a bit more explanation in README, but I could not spare any time to do so.
For a trial run, you can run python iterate.py --cuda 0 --model resnet18 --pruner lamp---this would run an iterative pruning-and-retraining procedure using the LAMP layerwise sparsities, on a (downscaled) ResNet-18-like model with CIFAR-10 dataset. This will use the GPU on your server (assuming that you have one) with CUDA number 0.


ItemVirtualization for ListBox is Broken

Performance is really bad now. Will investigate further.

https://github.com/AvaloniaUI/Avalonia/tree/repro/1707-listbox-virtualization-resize-performance


add colour field type

Closes #26
Follow-up from https://github.com/openstreetmap/iD/pull/8782#discussion_r760094554
This means we can more reliably detect colour fields (e.g. building:colour=*, roof:colour=*), rather than the current logic in iD which would erroneoulsy match tags like seamark:buoy_cardinal:colour_pattern=*

@tyrasd, this PR is approved, but only you are able to merge. Is there anything holding up a merge, such as needing to migrate id-tagging-schema’s roof:colour field back to the colour field type?


Must also explicitly set CC_TAG and CC_REG fields

Hi Guys,
The CC_TAG and CC_REG fields must also be set in order for the docker compose file to run. It worked with the following:
set CC_REG=store/softwareag
set CC_TAG=10.3

The values are set in the default .env file here:
https://github.com/SoftwareAG/sagdevops-hello-docker/blob/master/.env
It is picked up automatically by docker-compose
These values can be overwritten from the environment variables, but this is not required
Does this not working for you as described?


Slackbot

Coverage remained the same at 70.688% when pulling afc9172b48eefa650630f26a867e7a8e210c4b96 on JrtPec:slackbot into 1c59a36e404a9af993f036c895dcd2b5fe5acba1 on opengridcc:develop.


fix(create-llama): lock deps version

This PR fixes the pnpm install might lead to the minimum version of each package.
Related: https://github.com/run-llama/LlamaIndexTS/pull/203#issuecomment-1825114528
I realize that you Imitate the code structure from create-next-app.  But I think they have some e2e test coverage and I'm working on doing the same thing to ensure the stability of our codebase

I realize that you Imitate the code structure from create-next-app. But I think they have some e2e test coverage and I'm working on doing the same thing to ensure the stability of our codebase

Great idea! I didn't have time to add these e2e tests yet. I think it would be best to add them to this PR; then we ensure that the versions are working.