Issue with factory registrations in preview

Hi there,
I'm working on adding an example using Factory to the bazel rules_swift_package_manager project. I'm having an issue where factory doesn't seem to process the registrations I've added in the preview. I believe my usage is consistent with the docs. I've created a branch and will link relevant sections below. The dependency version is 2.2.0.
The preview itself see patch is using the same Container.shared.fooService.register { LocalFooServiceProxy(..) } type syntax as is described in the docs.
The Container extension see patch also seems to be according to docs.
Finally the resolution seems appropriate as well see patch.
I've tried adding some debug print messages to the code for my example as well as Factory and was able to help me debug whats happening. The print statements were added to Registrations.swift#register() and Registrations.swift#resolve(), to show the contents of the registration map while calling register() and resolve(). The logs are below:
["fooService<Client_Client.FooServiceProxy>": Factory.TypedFactory<(), Client_Client.FooServiceProxy>(factory: (Function))]
[:]
["fooService<Client_Client.FooServiceProxy>": Factory.TypedFactory<(), Client_Client.FooServiceProxy>(factory: (Function))]
[:]
Getting foo text
Getting remote foo
Getting foo text
Getting remote foo

The logs show that actually during the call to register(), the registration map is indeed populated. But by the time resolve() is called, the registration map has somehow been cleared. The remaining lines in the log simply show that indeed the default implementation is being invoked instead of the intended (mocked) implementation during preview.
I'm unsure how the registrations map is getting cleared and have been unable to make progress on debugging the issue.
Any guidance you have is very appreciated!

A couple of things. First ContentView's content property should probably be a StateObject, not State, since Content() is an observable object.
Second you're doing....
struct ContentView_Previews: PreviewProvider {
  static var previews: some View {
    Group{
      let _ = Container.shared.fooService.register { LocalFooServiceProxy(fooName: "bar", blockReturn: false) }
      ContentView(content: Content())
      let _ = Container.shared.fooService.register { LocalFooServiceProxy(fooName: "bar", blockReturn: true) }
      ContentView(content: Content())
    }
  }
}

While the doc shows...
struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        Group {
            let _ = Container.shared.myService.register { MockServiceN(4) }
            let vm1 = ContentViewModel()
            ContentView(viewModel: vm1)

            let _ = Container.shared.myService.register { MockServiceN(8) }
            let vm2 = ContentViewModel()
            ContentView(viewModel: vm2)
        }
    }
}

Creating vm1 on a separate line is important since the passed value is thunked. Do it as shown in the first example, and ContentView() won't be evaluated until later when the view is rendered.

I'm still experiencing the issue with the following setup:
struct ContentView_Previews: PreviewProvider {
  static var previews: some View {
    Group{
      let _ = Container.shared.fooService.onPreview { LocalFooServiceProxy(fooName: "bar", blockReturn: false) }
      let content1 = Content()
      ContentView(content: content1)
      let _ = Container.shared.fooService.onPreview { LocalFooServiceProxy(fooName: "bar", blockReturn: true) }
      let content2 = Content()
      ContentView(content: content2)
    }
  }
}

I also tried setting up the app with a similar injection scenario, with the same outcome.
@main
struct TestApp: App {
    var body: some Scene {
      let _ = Container.shared.fooService.register{ LocalFooServiceProxy(fooName: "baz", blockReturn: false)}
      let content = Content()
      WindowGroup {
        ContentView(content:content)
      }
    }
}

When I tried to step through this, I found that the compiler had optimized a lot of the calls out and that the debugger was somewhat uninformative about what was happening.
I do see the core library has tests that I think are equivalent code as well, so I'm quite confused about whats happening.
One idea I'm wondering about is that the first access to the Container variable happens inside a Task. If the compiler is lazily evaluating these (what I think you mean by Thunking above?), perhaps this is a shared memory access issue (like it needs a volatile or a map that uses atomic access)? Do you think that might be the source of the issue? In Containter.swift from my patch, eg.:
class Content: ObservableObject {
  @Published var text:String?
  let fooServiceProxy = Container.shared.fooService()
  var valueUpdater: Any?
  init() {
    Task {
      print("Getting foo text")
      text = await self.fooServiceProxy.getFoo()
      print("Got foo text")
    }
    valueUpdater = $text.sink { value in
      guard let value else { return }
      Task {
        await self.fooServiceProxy.setFoo(foo:value)
      }
    }
  }
}

Thanks so much for your input on this!

I verified the approach mentioned above in the FactoryDemo app's content view. (from develop)
struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        Group {
            let _ = Container.shared.myServiceType.onPreview { MockServiceN(44) }
            let model1 = ContentViewModel()
            ContentView(model: model1)
            let _ = Container.shared.myServiceType.onPreview { MockServiceN(88) }
            let model2 = ContentViewModel()
            ContentView(model: model2)
        }
    }
}

If you wanted to build a minimal standard Xcode project that demonstrates the problem I could download and look at it, but I'm not sure the would help with your build system.
Other than that I'm not quite sure there's a lot more I can do with this, since Factory seems to be working as designed.
One thing I might mention, however, is that when you run tests or previews Xcode has to run part of your app. As such you need to make sure that other processes aren't interfering.


<IP_ADDRESS> incubating

@pengbinbin1 Is this PR created by accident? If true, please help to close it. Thanks.


Bump version to v2.1.0

@onk Can you (or can I) publish this gem?

I found v2.1.0 are released. Thanks 👍


Anyway to work it with older MacOS?

Was using MacOS 10.15 (Catalina), but don't have that laptop no more.  My old laptop can only run up to 10.11 or 10.12.  I am wondering if there is a way to make this work on the older macbook.

Let's see - I've compiled this targeting macOS 10.11. There's only one thing in the code that wasn't available in 10.11, so I've tried to safely replace it (dark mode didn't exist back then and I've forcibly made my app dark). Let me know if it looks weird and I'll see if I can figure it out.
Derailleur.zip

thanks for the quick response.  that worked!!! back on again!

Closing as it is working!


Fix version replace

Coverage remained the same at 69.868% when pulling 1a497100fe74f77bfce28959dfddbe72dda41ec6 on ynurmahomed:fix-version into f3e13ff02d8108ae61ab3253c6c0961a8a2b9f49 on esaude:master.


Sap tccl 1.x

this is wrongly opened against master, it should be against 1.x branch

Replaced by #673 against the 1.x branch.


Fix error judgment in PushDownExecutor.java

Codecov Report

Merging #1045 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #1045      +/-   ##
===========================================
+ Coverage     24.99%     25%   +0.01%
- Complexity     6180    6181       +1
===========================================
  Files          1438    1438
  Lines         87669   87669
  Branches      12257   12256       -1
===========================================
+ Hits          21913   21923      +10
+ Misses        63601   63595       -6
+ Partials       2155    2151       -4

Impacted Files
Coverage Δ
Complexity Δ

.../org/apache/kylin/query/util/PushDownExecutor.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ream/core/storage/columnar/ColumnarStoreCache.java
52.27% <0%> (-3.41%)
8% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
76.74% <0%> (+2.32%)
12% <0%> (ø)
:arrow_down:

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
70.21% <0%> (+3.64%)
7% <0%> (ø)
:arrow_down:

...org/apache/kylin/rest/util/QueryRequestLimits.java
40.47% <0%> (+4.76%)
6% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320c20f...e1966cb. Read the comment docs.

Pull Request Test Coverage Report for Build 5492

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.007%) to 27.464%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java
2
57.95%

Totals

Change from base Build 5491:
0.007%

Covered Lines:
24077

Relevant Lines:
87669

💛  - Coveralls


Issues with current examples

A couple of the current examples have issues:
$ FALCON_CLIENT_ID="********" FALCON_CLIENT_SECRET="********" FALCON_CLOUD="us-1" \
    cargo run  --example falcon_get_cid

thread 'main' panicked at 'Could not fetch CCID: Serde(Error("missing field `errors`", line: 10, column: 1))', examples/falcon_get_cid.rs:12:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This example runs for quite a long time. The resulting JSON that is output is over 2.2 GB, and the program eventually has an issues since the bearer token has not been refreshed / is no longer valid.
$ FALCON_CLIENT_ID="abc" FALCON_CLIENT_SECRET="XYZ" FALCON_CLOUD="us-2" \
    cargo run  --example falcon_spotlight_vulnerabilities > spotlight_vulnerabilities

thread 'main' panicked at 'Could not list vulnerabilities: ResponseError(ResponseContent { status: 401, content: "{\n \"meta\": {\n  \"query_time\": 2.67e-7,\n  \"powered_by\": \"crowdstrike-api-gateway\",\n  \"trace_id\": \"599e0307-2f39-4df3-9fc8-455768ec7143\"\n },\n \"errors\": [\n  {\n   \"code\": 401,\n   \"message\": \"access denied, invalid bearer token\"\n  }\n ]\n}", entity: Some(Status403(MsaReplyMetaOnly { errors: Some([MsaApiError { code: 401, id: None, message: "access denied, invalid bearer token" }]), meta: MsaMetaInfo { pagination: None, powered_by: Some("crowdstrike-api-gateway"), query_time: 2.67e-7, trace_id: "599e0307-2f39-4df3-9fc8-455768ec7143", writes: None } })) })', examples/falcon_spotlight_vulnerabilities.rs:29:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I believe these may have been outdated api models, can you try with the #97 ??

With the recent updates to the main branch, this example works fine.
$ ./falcon_get_cid
************-**

I'm still seeing issues with this example.  The example runs for 30 minutes and then the bearer token is no longer valid.
$ time ./falcon_spotlight_vulnerabilities > ./falcon_spotlight_vulnerabilities.json
thread 'main' panicked at 'Could not list vulnerabilities: ResponseError(ResponseContent { status: 401, content: "{\n \"meta\": {\n  \"query_time\": 1.96e-7,\n  \"powered_by\": \"crowdstrike-api-gateway\",\n  \"trace_id\": \"ae75658b-1df8-4ce5-8488-ea2d8a663c92\"\n },\n \"errors\": [\n  {\n   \"code\": 401,\n   \"message\": \"access denied, invalid bearer token\"\n  }\n ]\n}", entity: Some(Status403(MsaPeriodReplyMetaOnly { errors: Some([MsaPeriodApiError { code: 401, id: None, message: "access denied, invalid bearer token" }]), meta: MsaPeriodMetaInfo { pagination: None, powered_by: Some("crowdstrike-api-gateway"), query_time: 1.96e-7, trace_id: "ae75658b-1df8-4ce5-8488-ea2d8a663c92", writes: None } })) })', examples/falcon_spotlight_vulnerabilities.rs:29:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
./falcon_spotlight_vulnerabilities > ./falcon_spotlight_vulnerabilities.json  439.48s user 57.54s system 27% cpu 30:01.03 total


Update README.md

Related Issue
Resolved the other half of issue #234
Description
information about Docker is missing in the README.md file. I have added it.
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[x] Documentation update
[ ] Other (specify): _______________

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

hey @Saurav-Pant ! can you review my pr?


Create setting for osm dev

Problem
Currently we are using production of osm
Solution
Create setting for change all into use dev osm

social auth
push into dev osm

hi @shawnsarwar
Now staging is already using dev osm
https://upload.apis.dev.openstreetmap.org/
Here is example of healthsite that i uploaded through OSM
https://upload.apis.dev.openstreetmap.org/node/2952600
My request through Staging


Cleanup PingDataConsole default URL

Currently, the PingDataConsole root page is the standard Apache Tomcat docs.  And the console is deployed to a location different from the standard product deployment ("/console").
In order to make the landing page more foolproof, a few things would be nice.

Deploy the admin-console.war to ("/console")
Create a 302 redirect page "index.html" redirecting the user to "/console"

If we want, we could also create a 302 redirection from /admin-console/index.html to /console also for backward compatibility on any bookmarks people have.

I would much rather we handled this in PingAccess as there are other issues better solved there.


[identity] readme/sample improvement

I found that we're mostly using key-vault as the data-plane library to demonstrate how to use different credentials.
I'm wondering if we could have a section in sample readme that hold links to the aad auth samples in different sdks so that I don't need to jump to the library (e.g. event hub) by myself to find out how to create EventHub client with credential.

Discussed offline with Adam. If we add aad auth samples for different sdks it will be an evergrowing list, that will add overhead in terms of maintainability. Also, for every library readme, we have an "Authenticate the client" section where we enlist samples for both AAD and other types of authentications supported for that library, which the users can find easily and may not necessarily look at identity sdk. For eventhubs - https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/eventhub/event-hubs#use-the-event-hubs-namespace-and-azure-identity


Won't Run on Ubuntu on  Windows

Hi folks,
I've been trying it out on ubuntu on windows and i keep getting this error:

What could be the problem?
Thanks

Hi. I don't have any experience with this but I know @AndrewPardoe has a working version in https://github.com/AndrewPardoe/compiler-explorer which I plan to get merged once I get some spare time!

Ok
Thanks

@Vm900, it looks like you're trying to get Node set up through the makefile. You might be better off to install node.js and npm first, then try running make.

@AndrewPardoe  Ok,i got it.Now it works.Thanks


Help with Kundera- Data stax Cassandra

My app is curently have Spring 4.1.5 , hibernate 4.3.5 and webservices and Oracle DB . We plannned to move to cassandra of Datastax version .Did POC using and its working as standlone but when we integrated with Project and trying gettering below exception
Error instantiating the Persistence Provider class com.impetus.kundera.KunderaPersistence of the PersistenceUnit ds_pu: java.lang.ClassCastException: com.impetus.kundera.KunderaPersistence cannot be cast to javax.persistence.spi.PersistenceProvider
weblogic version 10.3.6
My ear have all Spring , hibernate , webservice jars. AFter adding kundera dependencies we have Kundera related jars.
Could you please help how to resolve this issue ?

jarsInEar.txt, I have attached jars which are insdie ear, i don't have any jars inside weblogic domain lib folder. Appreciate if you help how to resolve this issue..

@lucky1985123
We will look into the issue and let you know, meanwhile is it possible to share a sample project at<EMAIL_ADDRESS>?
Chhavi

Hi , I am attachingtrimmed version of  sample code which has one Enity. The same code working in tomcat and as  stand alone but not working in weblogic 10.3.6. I added in weblogic.xml as preference to pick from my /war file only. I am not sure why i am getting class cast exception . I tried with both javax.persistence and javaee-api.
Appracite if you can give example which works in weblogic.
sampleCode.txt

Can you try adding the classes in the following way:
<class>com.impetus.kundera.query.Person</class>
<exclude-unlisted-classes>true</exclude-unlisted-classes>

Also set the following property in your persistence.xml:
<property name="jboss.as.jpa.managed" value="false" />

-Karthik

Hi i am  not using jboss, not how it will help here.

Anyhow i am able to fix the issue . The problem is with weblogic 10.3 ,and any JPA. In my case Kundera."The problem can be fixed if you rename persistence.xml to some other name, say foo.xml and thus bypassing weblogic autodiscovery."
Refrred this link : https://community.oracle.com/thread/1095616?tstart=0
But one issue observed here is Kundera have option to pass customize file name by passing persistenceunit.location property but that is not working in Webapp. it is not able to load the file inside war. Its working in stand alone.
Upgrading weblogic 12c also solves the problem with out any changes.

@lucky1985123
Thanks for the information on Kundera with Weblogic. Are we good to close this issue?


Allow defining binder-specific consumer and producer properties for bindings

This depends on spring-cloud/spring-cloud-stream#307

Closed https://github.com/spring-cloud/spring-cloud-stream/commit/9b0c4bd627f7d122be60d11caf993b18799b3ae6


Bug: Menu Width Problem (using longer Full Name)

This bug is happening with monitors with lower resolution (as an example 1280x800).
The screenshots have been made on 1920x1080 screen but I'm imitating the bug by using Chrome Zoom function.
Zoom 100% - OK

Zoom 125% - OK

Zoom 150% - BUG

Zoom 200% - OK

I run into the same issue on my Mac, I don't like to run Safari in full screen and have it at half width. Would be awesome to see this resolved, been meaning to log it for weeks.

The name should now cut down based on the length. If you're still seeing dodgy behaviour just give me a shout. :smiley:


Integration with   django-tenant

Test with django tenant not worked.
details:

Traceback (most recent call last):
File "manage.py", line 21, in
main()
File "manage.py", line 17, in main
execute_from_command_line(sys.argv)
File "F:\raqone\raq.env\lib\site-packages\django\core\management_init_.py", line 401, in execute_from_command_line
utility.execute()
File "F:\raqone\raq.env\lib\site-packages\django\core\management_init_.py", line 395, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "F:\raqone\raq.env\lib\site-packages\django\core\management\base.py", line 328, in run_from_argv
self.execute(*args, **cmd_options)
File "F:\raqone\raq.env\lib\site-packages\django\core\management\base.py", line 369, in execute
output = self.handle(*args, **options)
File "F:\raqone\raq.env\lib\site-packages\dbbackup\utils.py", line 117, in wrapper
func(*args, **kwargs)
File "F:\raqone\raq.env\lib\site-packages\dbbackup\management\commands\dbbackup.py", line 58, in handle
self.connector = get_connector(database_key)
File "F:\raqone\raq.env\lib\site-packages\dbbackup\db\base.py", line 39, in get_connector
connector_path = connector_settings.get('CONNECTOR', CONNECTOR_MAPPING[engine])
KeyError: 'django_tenants.postgresql_backend'

This is a fairly specific ask which wouldn't benefit the majority of users at dbbackup. I'd be open to implement this against a commission though.

You can use already-implemented PostgreSQL connector for django-tenants. Simply put connector mapper in your settings.py as below:
DBBACKUP_CONNECTOR_MAPPING = {
    'django_tenants.postgresql_backend': 'dbbackup.db.postgresql.PgDumpConnector'
}

You don't actually have to use dbbackup.db.postgresql.PgDumpConnector, but this is a default one for PostgreSQL. There is dbbackup.db.postgresql.PgDumpBinaryConnector too, please refer to docs for more info.


Fix NavigationAgent position not always updating

Fixes NavigationAgent position not always updating.
Fixes https://github.com/godotengine/godot/issues/78853.
Tbh this is a brute-force fix but I am also done with those issues where the global_position is returned zero for reasons.

Thanks!


null values in non-obligatory fields

In non-obligatory field when a value is null, the application doesn't work properly (if a category is included in visible_data): it renders only points to the first non-null point, and there is no possibility to click on a pin.
Possible solutions:

handle null values by not displaying the category with null value
handle null values by displaying e.g. "no data"
define the requirements for data to not contain null values

@AgaFra  Could you provide minimal configuration for reproducing this bug?

#54 is connected. We do not specify null data. If some data is null we omit it.
Yet - tests should be provided for covering this issue.
It should specify data with null and handle it as throwing expection null detected or sht like that.


docs: add note about building docs without docker

Commit Message: docs: add note about building docs without docker
Additional Description:
Risk Level: low
Testing: none
Docs Changes: README
Release Notes: n/a
Platform Specific Features: n/a
#30077

@phlax, here's a PR adding the command you mentioned in https://github.com/envoyproxy/envoy/issues/30077#issuecomment-1758246900 to the docs README, in case you'd like to add this.
If you'd rather not, please feel free to close this PR. Thanks!

@kenjenkins im in 2 minds about it for the reasons i explained before
having said that im not adverse to adding documentation on using bazel directly
i think i would prefer if we couched it in a warning about containers/isolation - and suggesting that these commands can be run inside a container (as well as on host at own risk)

Well, here are my 2 cents:
If building docs outside of the docker build environment is not supported, this line of the README should also be updated, as it is no longer accurate:

If you have an existing Envoy development environment, you should have the necessary dependencies and requirements and be able to build the documentation directly.

(That existing Envoy development environment link currently includes setup instructions for Ubuntu, Fedora, Linux, macOS, and Windows.)
If the docker build environment is the only supported method, it also might make sense to fold the docs README sections "Building in an existing Envoy development environment" and "Using the Docker build container to build the documentation" into one.
My understanding is that most Envoy development work will involve making docs changes, so it would be convenient if one could use the same development environment for previewing those docs changes.
I'm not sure I understand the concern about isolation. Personally, as someone new to reStructuredText I'm more concerned about whether I've gotten the docs syntax correct, and for that purpose a development build with bazel seems totally sufficient.
Again, that's just my 2 cents. I hope it helps to explain where I'm coming from. If you're opposed to this PR please do feel free to close it.

If building docs outside of the docker build environment is not supported, this line of the README should also be updated, as it is no longer accurate:

agreed this could/should be worded better

it also might make sense to fold the docs README sections "Building in an existing Envoy development environment" and "Using the Docker build container to build the documentation" into one.

kinda makes sense - as i said i think there is some value in providing direct bazel instructions, but not sure how best to structure it

I'm not sure I understand the concern about isolation.

mostly i prefer not to run any outside code on my host (even my own tbh) - so i tend to any dev in a docker env
bazel provides some isolation - eg with sandboxing etc, but it doesnt really preclude something bad from happening

...  do feel free to close it.

i totally understand where you are coming from and would rather we update/improve than close - mostly along the lines of your suggestion above
the truth is the developer docs are desperately in need of some attention
i have had other priorities recently, but this is pretty high
one of the things we are pondering is how best to structure them - currently they are spread around the repo and its very hard to find anything useful unless you know in advance where it is - one idea is using a wiki, another is moving to rst, not sure on that, but any help here would be hugely appreciated

related #29957

@phlax unclear to me what the status is on this one.  Author said you could close if you didn't want to merge - should this be merged, closed, or wait-on-something?


pull request for e2e test at 11/29/2016 22:56:05

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


kubectl apply -f config/samples/ doesnt work

kubectl apply -f config/samples/
resource mapping not found for name: "namespace-sample" namespace: "" from "config/samples/headscale_v1alpha1_namespace.yaml": no matches for kind "Namespace" in version "headscale.barpilot.io/v1alpha1"
ensure CRDs are installed first
resource mapping not found for name: "preauthkey-sample" namespace: "" from "config/samples/headscale_v1alpha1_preauthkey.yaml": no matches for kind "PreAuthKey" in version "headscale.barpilot.io/v1alpha1"
ensure CRDs are installed first
resource mapping not found for name: "server-sample" namespace: "" from "config/samples/headscale_v1alpha1_server.yaml": no matches for kind "Server" in version "headscale.barpilot.io/v1alpha1"
ensure CRDs are installed first

Indeed, kubectl apply -f config/samples/ should be done after a make install which put CRD in K8S cluster.

I have to update doc :)

yeah well it kinda creates a further issue for us, we dont use docker, wount go near it, we use podman, all your work is very docker specific and relies on a working access to a viable cluster also..... feels like alot of hoops just to deploy this.

You can also simply run kubectl apply -f config/crd/bases/


DEP remove old C/C++ examples

Closes #714

But tests are failing

OK @damonge this is working now.

Pull Request Test Coverage Report for Build 4199

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.384%

Totals

Change from base Build 4169:
0.0%

Covered Lines:
2186

Relevant Lines:
2268

💛  - Coveralls

Pull Request Test Coverage Report for Build 4199

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.384%

Totals

Change from base Build 4169:
0.0%

Covered Lines:
2186

Relevant Lines:
2268

💛  - Coveralls


Someone posted in MM forum

Thanks for reacting so fast on my issue. It is solved!
In the meanwhile someone also responded on the MM forum. See
For me this module is a long wish come true! Would it be possible to hide the section titles. (E.g. Utilities). I'd love an option for it. (Especially for the gauge's, because they have own titles).
Thanks again for this awesome plugin.

Check. I'm monitoring the forum.


[Radarr Aphrodite] Custom Formats "Required" color

It's hard to distinguish the Required color in Aphrodite's custom formats because it matches the condition label. Negate has it's own color, and Radarr's default color for the success label looks good here, maybe the theme color can be removed for the required label?
Current:

Without the theme background override:

Yup, fixed.


Add elements to the profileDescPart model class

Addresses in part issue #1078

merged #1368 as these should go together

This PR adds a profileDescPart class to which elements within the proposed <biblFull> element subscribe.

merged #1366 as creating biblFull was the motivation for creating model.profileDescPart

converted to draft as:

some work still has to be done, and
most important: this should be seen as a proposal to resolve the greater discussion around responsibilities / agents /  FRBRized MEI vs. flat source description

I'm returning to this PR after quite some time, and I'm a little confused.  I'm pretty sure that the PR included a new <biblFull> element, but I don't see it now.  There was some confusion around this PR and a some shuffling of things.  I'm wondering if <biblFull> got lost along the way and, if so, if there is a way to recover it.  I can't find my original work on this, and I'd prefer not to have to re-create it.

Never mind.  I see that <biblFull> is actually addressed in #1366.  Sorry for the churn.


Dev unit test data #37

Test works. Commit based on feedback:
• Revised last_timestamp to conform to pandas conventions (last_timestamp = df['time'].iloc[-1])
• asserts based on pd.Timedelta of 30 minutes

Won't be able to run this until later, but it looks like it will work! Good job!

Your code is good. There are no obvious with it. However, edit the function to do this:
def test_get_hobolink_data(app):
    with app.app_context():
        df = get_hobolink_data()
        last_timestamp = df['time'].iloc[-1]
        time_difference = (pd.to_datetime('today') - last_timestamp)
        assert time_difference < pd.Timedelta('30 minutes')

This is to fix a really weird issue that you probably aren't going to experience. It's a long story.

If you're interested in the problem, the TLDR is that the code base, as is, thanks to me, is trying to have its cake and eat it too when it comes to the data part of the website: i.e. it tries to run both within and outside of an app context, but here we need it to run inside of it.
The long version. Here's an example from hobolink.py:
def get_hobolink_data(export_name: str = EXPORT_NAME) -> pd.DataFrame:
    """This function runs through the whole process for retrieving data from
    HOBOlink: first we perform the request, and then we clean the data.

    Args:
        export_name: (str) Name of the "export." On the Hobolink web dashboard,
                     go to Data > Exports and choose a name off the list.

    Returns:
        Pandas Dataframe containing the cleaned-up Hobolink data.
    """
    if offline_mode():
        df = pd.read_pickle(get_data_store_file_path(STATIC_FILE_NAME))
    else:
        res = request_to_hobolink(export_name=export_name)
        df = parse_hobolink_data(res.text)
    return df

The offline mode thing is really convenient-- it means we don't need to set up the whole website to run a mock version of it. However, there are some problems with this approach. The definition for offline_mode() is:
def offline_mode() -> bool:
    if current_app:
        return current_app.config['OFFLINE_MODE']
    else:
        return bool(strtobool(os.getenv('OFFLINE_MODE', 'false')))

You're probably not seeing the problem yet. That's why I just gave you the fix instead of torturing you with it.
current_app is a global state handler that wraps werkzeug.local.LocalProxy, which is an object that forwards all operations to another object. In this case current_app forwards operations to whatever Flask app instance called the app_context() context manager.
Conveniently, although I'm not sure this was the werkzeug developers' intended use, current_app has a bool value of False when there's no object bound to the local proxy. This means you can do if current_app ... else to identify the app context, and if there is none, then I can do something else. This is what I do, and it's how I'm trying to have my cake and eat it too: I'm trying to make sure the functions run in the most technically correct way inside of the app context while also giving them functionality when no application is running.
So if offline_mode() is called outside the app context, then it returns the env var OFFLINE_MODE. Which is a problem for this particular test, sadly, as it doesn't work if offline mode is turned on. So in order for the test to always run with offline mode turned off, we need the app context, which in this case is configured with the TestingConfig which in turn always has offline mode turned off. (See TestingConfig inside config.py, and note what it inherits as well.)

I'm always up for getting the TLDR info on this app. It's all slowly coming into focus, thanks for sharing this info. I did all the testing/tweaking for this PR in online mode, so (obviously) hadn't accounted for the fact that testing should also work just as well in offline mode. Makes sense.
So if I understand correctly, by using with app.app_context():, we are essentially artificially creating an instance of the app to use for this particular test.
Looks like TestingConfig inside config.py inherits Config, aka all of the keys/vault info, but with DEBUG set to False and TESTING set to True. Similar thing happening in DevelopmentConfig and ProductionConfig. So config.py is all kind of intertwined. Good to know.

It's all artificial in a sense since it's just code. I know what you mean though, hah. We make the instance of the app in conftest.py and then we need to use it to make sure the behavior of the data functions are what we intended.

Anyway LGTM.


[Feature] ADD RepMLP Backbone and checkpoints

Motivation
ADD RepMLP Backbone and checkpoints
Modification
ADD RepMLP Backbone and checkpoints
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[x] CLA has been signed and all committers have signed the CLA in this PR.

Please fix conflict


Docs: memory requirement update

Seeing "HeapDumpOnOutOfMemoryError" during building is normal with bazel. It does not mean machine runs out of memory. "HeapDumpOnOutOfMemoryError" is just an argument bazel puts on commandline for all bazel invocations.

Seeing "HeapDumpOnOutOfMemoryError" during building is normal with bazel. It does not mean machine runs out of memory. "HeapDumpOnOutOfMemoryError" is just an argument bazel puts on commandline for all bazel invocations.

Fixed in latest PR. @martins-mozeiko thanks for the input. Please verify the current PR


Handle multi-allelic variants when loading ExAC data

The current loading pipeline for ExAC variants does not split field values for multi-allelic variants. When the gnomAD API encounters an array where it expects a single value, it throws an error and returns null for the field. This results in some fields for multi-allelic variants not showing up in the gene/transcript/region pages (#204).
It appears that the current pipeline also re-ran VEP on ExAC instead of using the VEP annotations from the VCF.
This new pipeline is split into two parts:

export_exac_vcf_to_ht.py: Parses stringified VEP annotations in VCF, formats variants for the browser, adds derived fields, and writes a Hail table.
export_exac_ht_to_es.py: Reads the Hail table output by export_exac_vcf_to_ht.py and loads it into Elasticsearch. It stores sortedTranscriptConsequences values as nested objects instead of JSON encoding the list of all consequences.

Added an optional subset argument to the script to convert the ExAC VCF to a Hail table and a README with the steps to load ExAC into Elasticsearch.


Use PyPI API token instead of basic auth

What?
During your recent upload or upload attempt of fastapi-featureflags to PyPI, we noticed you used
basic authentication  (username & password).
However, your account has two-factor authentication (2FA) enabled.

In the near future, PyPI will begin prohibiting uploads using basic authentication for accounts with two-factor
authentication enabled. Instead, we will require API tokens to be used.

What should I do?
First, generate an API token for your account or project at https://pypi.org/manage/account/token/.
Then, use this token when publishing instead of your username and password.
See https://pypi.org/help/#apitoken for help using API tokens to publish.

I think also related to: https://github.com/Pytlicek/fastapi-featureflags/issues/8

Fixed in: https://github.com/Pytlicek/fastapi-featureflags/commit/09dea3a7f81eb27209dc32ee84bd751dc1a928af


Pipe line exit set state

Mandatory attributes should have use="required" in the XSDs. I forgot to do this for attributes that are restricted by an eum. This PR adds that.
In addition, I fixed the build in case the log level is set to "TRACE". Method ObjectConfigChild.toString() logs the element type, but it is called before the element type has been initialized. I fixed this toString() method not to crash in this case.
Finally, I fixed some warnings about unused imports.


(Question) Shell Module

Hi,
I am looking at using TerraTest to potentialy spin up an ec2 server, run a command to get the version of the operating system and compare that to the tag value assigned to the server.
Would this be possible using the Shell module provided? And if so would it be possible to provide an example of this?
Any help on the matter would be greatly appreciated!
Many thanks,
Michael

Check out the examples and test folders. There are plenty of examples of how to deploy an EC2 Instance, how to SSH to it and run commands on it, and how to look up the tags of the Instance.

Is there any examples remoting onto Windows machines and running shell commands?
Thanks,
Michael

Hm, no, I don't think so. We've mainly been using Terratest with Linux/SSH. I don't think we have support for Windows/RDP yet.

Thanks @brikis98,
I thought as much, was looking into possibly installing OpenSSH on the Windows AMIs as a workaround but not sure if it will work.
Thanks Anyways.


added failing test case bracketed in hardcoded false that shows that

subscribing to multiple channels fails
added support for psubscribe/punsubscribe with same existing
limitation in that it only works if there is one channel
I believe the current approach is problematic. The issue is when sending a (p)subscribe with more than one channel, which is not covered in the tests, the handler expects only one reply from redis, but there will be N where N is the number of channels. Maybe there is a quick fix to address this, but in playing around I did not find one.
Another issue is it looks like the public API should support multiple subscribe calls, like redis does. However the problem with this API is there is only one subscription handler, so this type of code will not work:
client.subscribe(["monster"], monsterHandler);
client.subscribe(["ghost"], ghostHandler);
In general I think the subscribe/unsubscribe API should be rethought and made more user friendly.

any thoughts/comments on this change and suggestion?

Cool, thanks for the new API's. Unfortunately I wont have any spare dev cycles to work on this in the near future myself - any limitations are going to remain until someone has the spare time to work on it.

No worries - not looking for a commitment to work the issue. Just a nod that it makes sense. I would have had a go at it myself but wanted confirmation on the assessment.

I tried to implement this (twice) but i was unable to figure out how to de-serialise received object.I have got most of other stuff ready, so can someone post code snippet how can  received object be deserialised. I can made  PR and doc ready in short time. API is planned to return Stream, because it is I think most Dartisan way for this. Similar to what you can see in redis dart, but without wildchar matching, because that would require trie like data structure, without much benefit and implementation is much simpler and easier to understand and use.


Full backups missing something

Hi,
And thanks for this fantastic add-on! You already saved me quite lots of hours being a new HASS user. <3
But I think there is something missing from the backup: I needed to restore from full backup yesterday because I was messing around with my raspberry and cut my sd card in half (lol.. noob).
I had pretty nicely working setup made and did the restore from the previous day and I had to fully install zigbee2mqtt (edge) and reconfigure it, mosquitto broker and the MQTT integration.
That was not so bad, but still the full backup seems to be somewhat selective, or what do you think? Is there something that is intentionally left behind from the backups?
My settings looks like this (i think these are the default ones):

I've seen similar with more .... described in a separate issue in #151.
If you have been seeing what I have in 151, then they may be related.

@akostamo ,
If you haven't chosen to ignore any addons, everything should be backed up including Z2M, Mosquito etc. The addon is using Hass's built in API to perform the backups.
You can take a look at the backup after it's created and check that everything you expect is there (either by opening the archive or just choosing 'restore' in HASS and it will show you everything backed up).
If you see something missing still, please add the backup logs (set to verbose).

@akostamo - Still have an issue ?


Challenge 002

Challenge

https://twitter.com/treastrain/status/1549595274653609984

Screenshot
TBD
References
HIG

https://developer.apple.com/design/human-interface-guidelines/foundations/typography/
https://developer.apple.com/design/human-interface-guidelines/foundations/color

Others

https://qiita.com/treastrain/items/e0e9c3e9f517fa20ad08#relativedatetimeformatter
https://qiita.com/treastrain/items/e0e9c3e9f517fa20ad08#numberformatter
https://qiita.com/treastrain/items/e0e9c3e9f517fa20ad08#measurementformatter
https://stackoverflow.com/questions/39858828/choosing-units-with-measurementformatter
https://capibara1969.com/1981/
https://cocoacasts.com/swiftui-essentials-working-with-units-and-measurements-in-swiftui

Other answers
TBD

Thank you for submitting your response as a Pull Request! I'm not presently using Pull Request to collect answers to topics from participants. This repository only shares the topics and the code when taking screenshots of the topic.
You may fork this repository (you've already done this!) and submit a Pull Request to it, of which you are the owner, so that you can vividly manage your own responses to the topic!

ごめんミスったｗ
フォークしたブランチはデフォルトでフォーク元のリポジトリに向いちゃうのか

ですです〜 うっかりするとやってしまいますよね^^;


Move Twilio keys to per tenant

Relevant settings

TWILIO_ACCOUNT_SID
TWILIO_AUTH_TOKEN

Suggested Approach
Create a new MessagingProvider model and configuration. Twilio would be the only option currently
See https://github.com/dimagi/open-chat-studio/blob/main/apps/service_providers/README.md

Closing, since the work is done and only needs deploying


Make new "I18n.extend" configurable

Many users (myself included) have issues with the new I18n.extend which was recently added to the Javascript.
This PR adds "js_extend" option which controls whether or not to use "I18n.extend" in your output files. This can be specified at both segment (single file) and parent level (all files).
I've also made "sort_translation_keys" to be settable at both segment and parent level to be consistent.
This PR contains some light refactoring within the Segment class for clarity/readability.

@johnnyshields Thanks for your continuous support for this gem
Pleas read a few line notes I have added :)

@PikachuEXE done

Looks good!
Thanks :D
Merging

Forgot to add CHANGELOG entry!
Now added by me :P


markText strange behavior when 'from' and 'to' positions are strings

In doc.markText(), numbers represented as strings only sometimes cause the marked range to be hyperextended until the beginning of the next marked range. It would be better if strings either threw an exception or were handled properly without bugs (e.g. parseInt).
Here is a jsfiddle to demonstrate the bug:
http://jsfiddle.net/p1mdp259/1/

The documentation makes it clear that positions take numbers, not strings. If you're passing in invalid values, you can't expect the library to work.


how can a function be deployment?

how can a function be deployment and not need to save thru the UI?
thanks
Shiv

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5711c85c-14e8-e830-c5d4-e645c02d9c5b
Version Independent ID: c958d4ba-3a8e-750f-c8cd-c44aa0974f69
Content: Functions in Azure Monitor log queries - Azure Monitor
Content Source: articles/azure-monitor/logs/functions.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @guywild
Microsoft Alias: guywild

@shivakumard
Thanks for your feedback! We will investigate and update as appropriate.

@shivakumard Thanks for reaching out. Can you please elaborate what do you mean by function being deployment ? Kindly add further context to help you in this issue.

@shivakumard As requested, kindly provide more information about your issue to assist you accordingly.

@shivakumard As we haven't heard from you, we will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


Is this project not developed?

Just found this library when searching for command palette components, but it looks like it didn't have any changes for a year, so curious if it's still maintained or not

Also wondering almost a year later.
The simplicity of the setup makes this one very appealing to me.
Looking for a Vue 3 compatible version, though

Don't think it is @katerlouis - had to build one from scratch myself.

@doutatsu – would you mind to share? :)

@doutatsu Could you please share it?

I can't really share mine, but I recommend checking out shadcn version - https://www.shadcn-vue.com/docs/components/command.html

I ended up making my own vanilla javascript version. If anyone wants
the code, then here it is:
https://gist.github.com/tiagorangel2011/023337b26cf589c97ccd0b8fc15456f3
Maksim Fedotov @.***> escreveu (sexta, 7/06/2024 à(s)
15:30):

I can't really share mine, but I recommend checking out shadcn version -
https://www.shadcn-vue.com/docs/components/command.html
—
Reply to this email directly, view it on GitHub
https://github.com/BetaHuhn/vue-cmd-menu/issues/1#issuecomment-2154967199,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ3M5XQVT5LJC7X5VPRMAO3ZGG7XLAVCNFSM6AAAAABI6XQJL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUHE3DOMJZHE
.
You are receiving this because you commented.Message ID:
@.***>


⚠ gorzdrav.org has degraded performance

In d747956, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1354 ms

Resolved: gorzdrav.org performance has improved in 32fdb41.


Host Docker image on Pinterest Docker account

We should probably move rajathprasad/rocksplicator-build:latest to something at the organization level like pinterest/rocksplicator-build:latest

Agreed. What would be the process to upload an image to pinterest account
on dockerhub?
On Wed, Oct 9, 2019 at 6:49 PM Derek Argueta<EMAIL_ADDRESS>wrote:

We should probably move rajathprasad/rocksplicator-build:latest to
something at the organization level like
pinterest/rocksplicator-build:latest
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/rocksplicator/issues/326?email_source=notifications&email_token=AAQM5NVQ6J4QOOR4NZG2E73QN2C2VA5CNFSM4I7GYIOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQZOKPQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQM5NQPBB3D5GUPVAUFZ3LQN2C2VANCNFSM4I7GYIOA
.

@newpoo I don't know, I started an internal email thread with you cc'd.


Oracle - Unable to set precision to the database setting

Our current database has been created with the NUMBER datatype without any precision parameter.
Is it possible to configure Doctrine to not use any precision parameter?
For some reason Doctrine defaults to precision 10? I am trying to make Doctrine output the correct precision (which could be *)  but unable to do so because Doctrine is checking for an integer:
[Doctrine\Common\Annotations\AnnotationException]
[Type Error] Attribute "precision" of @ORM\Column declared on property Stm\Model\SIPOC_WEB\TbResposta::$id expects a(n) integer, but got string.
I have already tried to put precision=38 which is the maximum precision for Oracle, but for some reason Oracle still thinks we are trying to change the precision when modifying the datatype from NUMBER to NUMBER(38).
The coversion does work from NUMBER to NUMBER(*).

@nuncanada you can just extend the OraclePlatform getIntegerTypeDeclarationSQL in your project if you have this requirement. Alternatively, you could add a custom mapping type that extends IntegerType..
Here is an example of extending OraclePlatform. Adjust as needed.
Add this to your configs:
doctrine:
    dbal:
        default_connection: default
        connections:
            default:
                platform_service: stm.dbal.oracle_platform

services:
    stm.dbal.oracle_platform:
      class: Stm\Doctrine\DBAL\Platforms\OraclePlatform

And extend OraclePlatform like so:
<?php
namespace Stm\Doctrine\DBAL\Platforms;

use Doctrine\DBAL\Platforms\OraclePlatform as OraclePlatformOrigin;

class OraclePlatform extends OraclePlatformOrigin{
    /**
     * {@inheritDoc}
     */
    public function getIntegerTypeDeclarationSQL(array $field)
    {
        return 'NUMBER';
    }
}

Yes custom type is the solution.


Allow toggle from the tray

demo:
https://github.com/Borwe/save-me-baby/assets/996134/9604dec1-01e7-429b-879c-86f379c64475

@maxdemaio i think this is good to go but have a look 🫶
@Borwe LMK what you think as well but prolly good to :shipit:.

Looks good to me, works fine, even been using this, though I am curious about that line, how bad is it?

@Borwe i might have left that comment in even after I refactored the code.
so it’s probably not a big deal I think.

Cool man, merging.


npm start with https

Hi,
is it somehow possible to start the dev mode of the boilerplate with https enabled?
Thanks,
Andreas

Hi @andreas-koch, how is going ?
Can you share your setup please ? I'm new with nginx and I would like some example to start


Allow to use json instead of xml for request and response body

I think a good improvement would be to allow send a Content-Type: application/json; charset="utf-8" and Accept: application/json; charset="utf-8" header. An process request and response as json.
So the webdav server can be used by javascript more easy.

I don't think that it's that easy, because this would've been 100% proprietary. However, you can provide your own implementation of IWebDavOutputFormatter for the serialization and a custom input formatter (see WebDavXmlSerializerMvcOptionsSetup, and WebDavXmlSerializerInputFormatter) for the deserialization.
BUT be aware that different XML responses with different root node names may be returned for the same request, depending on the amount of response values, and error condition.
I'm hesitant to support this feature, because it would require writing/maintaining a spec and a sample implementation (RFC, anyone?).

Ok, i will look at the serializers and formatter. Maybe that could be enough to override for our usecase.

Closing, JSON payload is not specified by any RFC and it wouldn't be easy to cover all XML features


WAVE accessibility tool alerting on  styling

Description of the issue

Pages using the details component will cause an unexpected alert in the Wave accessibility evalution tool as of 11th March 2024.
Steps to reproduce the issue

Run the Wave checker on any page using a details component. The tool will create an Underlined text alert for each use of the summary tag. Wave is probably picking up the underline from the CSS that styles the summary text span.
.govuk-details__summary-text {
    text-decoration: underline;
}

Actual vs expected behaviour

This is a very small issue which is easily cleared up by checking the source code,  but may cause problems if we advocate for developers to run automated tests before committing code to a repository.
Environment (where applicable)

Operating system: MacOS
Browser: Chrome
GOV.UK Frontend Version: 4.8.0

This appears as an alert in WAVE.
WAVE's 'reference' (contextual help) says:

What It Means
Underlined text is present.
Why It Matters
Underlines almost universally indicates linked text. Consider removing the underline from the non-link text. Other styling (e.g., bold or italics) can be used to differentiate the text.
How to Fix It
Unless there is a distinct need for the underlined text, remove the underline from it.
The Algorithm... in English
A <u> element or element with text-decoration:underline styles is present.
Standards and Guidelines
None

Given we're intentionally styling it similarly to a link to make it appear interactive, I don't think this is something we're likely to want to change?
I've added it to our 'known issues' project so that other WAVE users might be able to find this issue.


Add the ability to run pico_project.py from other directories

This PR is to resolve the issue #7 by adding the ability to run pico_project.py without cd into its project directory.

LGTM, thanks!

LGTM, thanks!


Add a license

With your current configuration, normal copyright laws apply and nobody is allowed to fork your project to create pull requests.
In case this is not what you intended, please consider adding a license.

Thanks, I just added an MIT license


Ability to create shareable links with nifti overlays

I have a nifti volume which is viewable when dragged into siibra. Ideally I would like to share a link when publishing a dataset/paper to this file open in siibra. Is it possible to have a viewer pointing towards a nifti file in a bucket and have this hard coded into the url?
thanks in advance,
Harry

I could also convert these nii volumes to neuroglancer chunks if that would make the process simpler

@PolarBean whilsting converting the nii volume to neuroglancer chunks would certainly alleviate the memory issue, crafting a sharable link is still something we need to work on.

This works fantastically, I've just tested it. Exactly what we needed, thank you


Add sample showing how to use aspire orchestration with WebApplicationFactory

See https://github.com/dotnet/aspire/pull/388
e.g https://github.com/dotnet/eShop/blob/main/tests/Catalog.FunctionalTests/CatalogApiFixture.cs
cc @ReubenBond

@davidfowl I see the link links to a fix to the eshop tests. This a testing specific example? If so, the example for this issue could then be used for a tutorial in the documentation for a tutorial on "testing strategies" or something along those lines.


User upload limits, destroyed subject sets and upload limits.

The front end allows a user to delete a subject set and the associated subjects.

However this doesn't delete the actual subjects, just the subject set and the associated set_member_subjects. Thus their uploaded subject count never decreases and when trying to manage their project data sets, i.e. upload new data, the api checks if the user has < 10K uploaded subjects and error if not. This behaviour will appear to be inconsistent with what they are seeing in the front-end project builder, i.e. possibly 0 subject sets and 0 linked subjects.
I think we need to provide some filtering on the subject table for the uploading user (db index & filter option in the serializer) and link this to a front end interface to manage an uploaders set of subjects so they can see what data is available and delete as they wish. Also we should probably change the wording on the front end when removing a subject set to "Delete this subject set and unlink the 30 subjects".
Pinging @brian-c, @chrissnyder @edpaget for thoughts, also @aliburchard noticed this behaviour with one of her collaborators.

FWIW I noticed this too, but was in a rush at the time do didn't note it down. I didn't realise subjects weren't actually deleted and the count doesn't get adjusted accordingly.
If user limits are going to be imposed I'd say the ability to delete subjects via the Front End is essential, so :+1: :-)

The problem comes if you upload subjects that are reused in a different project or referenced in Talk. If you delete the subject set all of a sudden all those projects, links, and discussions are broken.

I think we should allow deletion of user subjects that have no links to projects to allow the the user to clean up their test data.

Agreed. As people are beginning the project building stage, they're going to upload subject sets just for testing out the workflow, but that they never need to use when they really push the project live.
What if I upload someone else grabs a subject that I've uploaded as part of a test set and they use it in their own project or a collection. I want to delete that subject because I am not actually using it and need to open up my 10K limit, but that subject now has links elsewhere. If we (Zooniverse) hold onto that subject somewhere behind the scenes, will that subject still count against my 10K limit even though I've deleted it from my project?

We won't ever delete that subject but the case you describe is more a point about our current limit structure. We'll need to be smarter about how subjects get counted towards these limits.

I think this has been mostly solved via #1093 - we can look to clean up subjects further down the track.


Unable to Import networkx exported graphml

Hi there I'm using networkx  on backend to do heavy lifting and cytoscape.js on frontend to display graph. I've tried to import graphml file generated from networkx but got the following error.
ERROR TypeError: Cannot set property 'd0' of undefined

Here are contents of graphml file.
<?xml version='1.0' encoding='utf-8'?>
<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">
  <key attr.name="weight" attr.type="long" for="edge" id="d2" />
  <key attr.name="max" attr.type="long" for="node" id="d1" />
  <key attr.name="min" attr.type="long" for="node" id="d0" />
  <graph edgedefault="directed">
    <node id="a">
      <data key="d0">0</data>
      <data key="d1">2</data>
    </node>
    <node id="b">
      <data key="d0">0</data>
      <data key="d1">3</data>
    </node>
    <edge source="a" target="b">
      <data key="d2">-4</data>
    </edge>
  </graph>
</graphml>

Any help will be appreciated.

I am also facing the same problem

We don't have anybody to work on this currently but feel free to do a PR to fix the problem and we'd be happy to review and merge it.

I made a PR for it. Thanks @rg2609!


benchmarking_deploy_coco_dataset: download image_info_test2017.zip and use sha256

cc @Maxusmusti

/test test-commit

/test test-commit

failure is independent of this PR, merging


Windows 10 Weather App

My Windows 10 MSN Weather App don't want to show actual weather status on start menu tile and lock screen. I tried to change localization settings, but they're locked. I think that Windows10Debloater causes the problem. Can you help me with that?

My script likely removed the dependencies that the Weather App requires, effectively killing its intended functionality.

Is there a someway to restore it or add in Windows10Debloater with GUI possibility to change apps to uninstall? Something like tick menu called maybe blacklist, where i will be able to block apps from deleting.

P.S. Can you explain me, how the blacklist and whitelist works ("Remove Bloatware with/without Blacklist and Fix Whitelisted Apps")?
Remove All Bloatware: Dynamically find all of the Store apps on the computer, and delete all of them EXCEPT for the ones that are whitelisted.  (The blacklist is not used at all.)
Remove with blacklist: Delete all of the Store apps listed in the blacklist. The whitelist is ignored in this case.
I haven't really looked into the "fix whitelisted apps", but it doesn't do much and is a different whitelist than what is used with "Remove all Bloatware".

This was implemented as requested by @jstnlth


[Feat]: multiple IPs per entry

DNS should support multiple A record returns

I'm not sure this is necessary for local records. Can reopen if necessary


Draft: Unified Alerting support proposal

Based on the discussions in #911 I've written up a proposal for extending grafana-operator with support for unified alerting. I'm looking forward to the feedback.
If anyone wants to assist feel free to ask for access to the branch so we can streamline the work.
Ref: https://github.com/grafana-operator/grafana-operator/issues/911

So this is a good start @siegenthalerroger  and thanks for taking this on.
But this document doesn't highlight how we should use the different resource to have them talk to each other, which is the hard part of this API.
When creating a folder we generate the UID from the k8s resources today. The dashboard is excluded from this where we allow the UID being hardcoded in the dashboard json but if it isn't, we will generate a UID for you.
When adding a alertRule we need to point to the folder UID. How should we manage this?
Should it be a label selector? Should it be the folder name and we just search for it.
I don't have time to look deeper at the API, but I assume there are a number of other resources that needs to do call on each other using UID. How should we find them?
How should we make this valid in a multi grafana instance setup with multiple namespaces?
We need to have CRD examples for all the resources and how we should use them together before being able to give more feedback on this design.

Would this also include the loki/mimir rules support? Or just the general grafana rules

@owenhaynes this would only focus on grafana alerts. Loki/mimir rules isn't part of the grafana API.
I would recommend looking in to https://github.com/AmiditeX/mimir-operator, I have been in contact with the creator and we are looking in to using it where I currently work.

I'm +1 for the idea of adding this support, we're at the point now where we can start extending the feature set on the v5 code base.
Questions/opinions:
Are you thinking of this support as a new grafanaalerts CRD? Or a finer set of per-api object scoped CRDs?
Personally, I'd prefer if we keep the number of CRDs to a minimum, and group them as much as possible.
I say this, for organizational reasons, I think we should aim to keep the CRD set as an easy to maintain and use (from a user perspective) collection.
This, IMHO, means grouping API objects into logical CRD's based on an API or Feature, but with a few caveats:
The CRD should not be an antipattern to a "classical" usage of the Grafana feature. i.e. We should allow users to pretty much "drag and drop" their resources from a non-operator managed deployment, into an operator managed one.
The CRD should not be overly dependent on any other CRDs as much as possible, to avoid complex relationship graphs between resources. (i'm mostly echoing what Edvin stated above)
I think if you could update this PR to include some higher-level graphs, or descriptions of relationships of these resources, we could give some more feedback.
Again we're +1 to the idea, but we just need to see how this would be structured as a CRD, That will allow us to come up with an implementation that will be in-line with v5 standards

I'm currently playing around with alerts in grafana (not for this issue, though) and I hit an interesting thing that we should be aware of.
If you want to be able to edit the alerts through the UI after you update/create them using the API you need to define a header to disable
		HTTPHeaders: map[string]string{
			"X-Disable-Provenance": "true",
		},

https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/set-up/provision-alerting-resources/view-provisioned-resources/
A funny thing is that if you ever update these resources without setting this header, they can't be changed afterward.
2023/08/18 11:24:11 status: 500, body: {"message":"cannot change provenance from 'api' to ''","traceID":""}
exit status 1

For me, I had to solve this by restoring DB.
Something to take in to consideration when doing stuff with alerts using the API.


Hoxton.SR5 doc does not say it supports Spring Boot 2.3.x

In the online documentation of Spring Cloud Hoxton.SR5, the supported Spring Boot Version is 2.2.1.RELEASE, but in a blog post Spring Cloud Greenwich.SR6, Hoxton.SR5 and 2020.0.0-M2 (aka Ilford) are Available, there is a statement "Hoxton.SR5 is compatible with both Spring Boot 2.3.x and 2.2.x". Please fix the bug in the online documentation.

We're cleaning out the issue tracker and closing issues that we've not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one should not have been closed.
See https://github.com/spring-cloud/spring-cloud-release/wiki/Historical-Versions for the canonical source of cloud to boot mappings.


The GUI appears non-responsive when the 'still syncing' overlay is visible

After the initial install there is an overlay that provides a description and progress of syncing. If a user clicks on the main UI buttons (Overview, Send, Receive, Transactions) while that overlay is visible, nothing seems to happen. The buttons respond as if clicked (background color changes) but other than that nothing seems to respond. if you look REALLY closely, you can see that actually the UI is responding and changing, but it's masked out behind the overlay screen.
Two suggestion, in my personal order of preference:

Clicking anywhere outside of the overlay just closes the overlay.
The overlay covers everything and you're essentially forced into clicking the 'Hide' button to reveal the UI behind it.

There's a short video of the behavior posted here:
https://twitter.com/statusquont/status/1278465322278948864

Two suggestion, in my personal order of preference:

Clicking anywhere outside of the overlay just closes the overlay.

The overlay covers everything and you're essentially forced into clicking the 'Hide' button to reveal the UI behind it.

What if Overview / Send / Receive / Transactions would disabled until the "Hide" button is pressed?

That would probably work too, especially if it's combined with this suggestion of making the Primary action item stand out visually: https://github.com/bitcoin-core/gui/issues/24

That would probably work too, especially if it's combined with this suggestion of making the Primary action item stand out visually: #24

Tyi, the progress bar on the bottom should have already this functionality , and also the sync icon most right on the bottom of the main windows, btw if you hover about icons they hint an info about what they do, but I also would vote for, a button show detail about sync in the information window.
In general since the UI is often the first encounter, the first user view is something that tents to fade while dev, since its difficult to forget about what you know about a given software.

@statusquont @Saibato Mind testing #30?


Generated Events calls only once

There is no way to recall/referesh and call generateEventsForDate methods to referesh/reload.
suppose if we want to insert multiple event at one call events are not coming on right date it miss match the days.

Please, explain problem in detail.

i need to add multiple events in one shot how can i do this in this?
On Sat, Oct 17, 2020 at 7:15 PM Richard Topchii<EMAIL_ADDRESS>wrote:

Please, explain problem in detail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/richardtop/CalendarKit/issues/271#issuecomment-710977157,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFVYE7OR23VXL6MQE2JLBTSLGNXPANCNFSM4STM4Q5Q
.

Please, provide a sample project or sample code.
This kind of questions (not a bug report, feature request) are better to be asked on StackOverflow with the CalendarKit tag. Please ask it there.
https://stackoverflow.com/questions/tagged/calendarkit
As for adding multiple events at the same time, just do the changes to your datasource and then call dayView.reloadData() method to reload all events at once.


Report fails without emit 'test end' event

The mocha listens for 'test end' event (it can restart test if it is
failed). If an exception is thrown from the setup/beforeEach, the
karma-mocha must not fire 'test end' event, because it leads to
exception inside mocha code (the mocha tries to get current test,
which is undefined).
With this, mocha adapter reports fail directly to karma instead of
raising an intermediate 'test end' event.

Thanks! Please add a test for this change.

Done


How to enable h2 console in Helidon, similar to Spring property "spring.h2.console.enable=true"

Environment Details

Helidon Version:
Helidon SE or Helidon MP
JDK version:
OS:
Docker version (if applicable):

Problem Description
Steps to reproduce

Helidon does not currently support this.
Digging a little deeper it looks like the H2 Console can be run stand-alone or embedded using its servlet web application org.h2.server.web.WebServlet. I'm guessing the Spring support is done via this servlet.
Helidon does not support Servlet, so things get more complicated. Some possibilities:

Write a Helidon integration that wraps org.h2.server.web.WebServer -- essentially performing the same role as H2's WebServlet. Unfortunately it looks like not all the H2 web APIs needed to do this are public.
Write a Servlet shim with just-enough-servlet to use H2's WebServlet.  This is a bit gross and starts down a path we don't want to head (supporting Servlet), but would mean we only depend on stable, public APIs.
Contribute some alternative to H2's WebServlet to the H2 project. Maybe a JAX-RS resource? Or some other higher level delegating class?

@ramakantharao:
@ApplicationScoped
public class H2Producer {
  private Server server;

  public void init(@Observes @Initialized(ApplicationScoped.class) Object o) throws SQLException {
    this.server = Server.createWebServer("-webPort", "8082").start();
  }

  @PreDestroy
  public void destroy() {
    server.stop();
  }
}

This issue is answered and quite old.
Should it be closed?


Bug: Accounts/Network are not updated in production build

So the reason for this problem was that:
const watchedActions = [ADD_PROVIDER, REMOVE_PROVIDER]

in the production build became [undefined, undefined] and thus   if (watchedActions.includes(action.type)) { didn't work in providerWatcher
I don't know the exact reason for this, whether it's a circular dependency, we messed up the imports or some webpack bundling bug but by using an absolute path it works

Travis automatic deployment:
https://pr625--safereact.review.gnosisdev.com/app


The File is broken everytime I Download it

The owner of this needs to check all the files somthing wrong with this It used to work all the time for me And I downloaded this 6 times and still said the file was broken I tryed updating the chroot and nothing it said that was broken too. It said Failed to complete chroot setup. Also it said /mnt/stateful_partition/crouton/chroots/precise doesn't appear to be a valid chroot. plz help

upstream is currently broken


Typo error?

Describe the bug
A typographical error on the homepage
To Reproduce
Steps to reproduce the behavior:

Go to the homepage
Scroll down

Expected behavior
It should be Nsibidi writing system was .... without the is
Screenshots

@Toyin5 great catch. It should be:
Nsịbịdị is a writing system created in Nigeria.

Can I work on it?

Can I work on it?

all yours!


No matching distribution found for pandas==1.0.1

it should be like this

@kritikaparmar-programmer have a look


react-native-gifted-form/icons/delete_sign.png: Unexpected character

react-native-gifted-form/icons/delete_sign.png: Unexpected character. Use default icons such that such issues do not occur

Hi @yenicelik, I'd like to help but I don't quite understand the issue. Can you please clarify and add steps to reproduce the issue?

I think the issue she is facing is that her project cannot find her icons. you must manually change the image src to the correct places

I think David is a "he" 😜 but thank you for the clarification, I will happily accept a PR to improve this logic.


Export-Excel deletes existing worksheets

I have an Excel workbook to which I want to add some data from powershell.
But export-excel removes the existing worksheets from the file.
Am I doing something wrong? Or is this the default behaviour?

Never mind, my fault...


[deps] update them all

Motivation
Prepare libra repo for dependabot opening prs on detecting new versions of crates.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
a) ran local swam and created a few transactions.
b) cargo xtest
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@metajack @sausagee  This should land before turning on dependabot.
Do we need to rope in the leads of various teams to vet the update?
Just want to point out where we are with this pr and check if it's where we want to be.

autocfg 0.1.7 (1.0.0) seems odd. We are adding a new dependency to an older version? Similarly for rand_os and owning_ref we seem to be deleting the newer version leaving the older one.
Other than that this looks ok. I assume this is the result of a blanket cargo update?

:umbrella: The latest upstream changes (presumably cce4f50a89b54dc0fc832d86195c187a5b46f919) made this pull request unmergeable. Please resolve the merge conflicts.

@metajack this is the result of a blanket cargo update.    Just wanted to get us to the the point dependabot would be useful.
In the updated packages section there is this:
autocfg: 0.1.6 -> 1.0.0
I assume autocfg 0.1.7 is simply showing the dependencies referenced, not the dependencies used by some upgraded packages.   Seems we went from 0.1.6 to 1.0.0 but something (radix_trie and some rand_* crates) still depended on 0.1.7 transitively.   Least that's the way I'm currently interpreting this.
It looks like rand_os may be replaced by oorandom in some cases in our dep tree.
Now owning_ref is weird.
Here it is:
https://github.com/libra/libra/pull/2507/files#diff-d2ede298d9a75c849170d6ef285eda1eL2506
And inlined:
[[package]]
name = "lock_api"
version = "0.1.5"
source = "registry+https://github.com/rust-lang/crates.io-index"
dependencies = [

"owning_ref 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)",
"scopeguard 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)",
]

I'm seeing it removed from a package that hasn't changed.    Does this have something to do with our cloning api/feature hackery?

It's possible cargo guppy diff is making a mistake. I'll review the lockfile changes directly to make sure.

Ah, I suspect the new version of lock api (0.3.3) takes precedence so it may be the feature dependencies of the unused 0.1.5 are not calculated in the lock file via 'cargo update' as they are deemed irrelevant?

:umbrella: The latest upstream changes (presumably bc702a79c23fdce0d5c0ab572094b9ea345527fa) made this pull request unmergeable. Please resolve the merge conflicts.

@huitseeker It will run CI when it's on the real repo. @rexhoffman's fork just doesn't have CircleCI set up.
I assume we can't do this automatically for everything, but it seems like it will be fine for most things.

@rexhoffman owning_ref was pulled in from parking_lot via lock_api. The new parking_lot pulls in a new lock_api and owning_ref is now an optional dependency that we don't use. However, we use owning_ref 0.3 in other dependency paths which is why it is still around.

@rexhoffman autocfg appears to be a minor bug in cargo guppy. Basically we added a new 1.0.0 but also changed the old 0.1.6 to 0.1.7. That appears to cause our diff algorithm to produce slightly confusing output for this case.

@rexhoffman And finally, rand moved from a normal dep to a dev-dep with criterion 0.3.1.

@bors-libra d+

@bors-libra delegate+

:v: @rexhoffman can now approve this pull request

@metajack thanks for looking at the delta.   I'll need to do another cargo update to get around the current conflicts, but just want @davidiw to weigh in first on the approach as my understand is he's the TSC member with the most skin in this game (vetting dependencies).   Glad we've noticed this guppy bug.   I'll make note of my pr before and after so that I can make a test for and clean up this in guppy as time/growing rust knowledge allows.

A minimal repro for guppy would be adding a new version and updating an existing version at the same time. I'm not sure whether it will always show the lowest version as the one that is added or if it shows the one with the lowest line number in Cargo.lock.

Did a manual resolve to test myself.  May fail.  Also performing a cargo update. Which is good since my manual efforts appear to have failed.

looks like smallvec has the same display bug in cargo-guppy

Took 3 builds for the tests to pass.   Gotta look in to that soon.

@rexhoffman I've submitted a PR on your fork here:
https://github.com/rexhoffman/libra/pull/8
That pushes this a bit further, hopefully. Merging it there should update the PR here.

@hermanventer Is that a bug in MIRAI?

@bors-libra r+

:pushpin: Commit d21978c has been approved by metajack

:hourglass: Testing commit d21978ca552439c743de3cdc632b62a85b4cf048 with merge 76f9f2eb2a03df318dfc2d19279eeadf186bea5d...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit d21978ca552439c743de3cdc632b62a85b4cf048 with merge 513a488005367ec2ed315bf04978c843194ca330...

:broken_heart: Test failed - checks-circle_commit_workflow

This latest failure might need investigation. I can't tell if that's a known flaky test or not.

@metajack the test relys on startup synchronization (which is something I've seen error out before).  Would you mind clicking the rerun button on the test suite, as that's not something I have permission to do.  Or @sausagee if you see this first?

@bora-libra retry

@bors-libra retry

:hourglass: Testing commit d21978ca552439c743de3cdc632b62a85b4cf048 with merge 630bd498e77e39941ea933d13198d4e7a01043d3...

sorry should have seen that metajack set off the retry first.

:sunny: Test successful - checks-circle_commit_workflow
Approved by: metajack
Pushing 630bd498e77e39941ea933d13198d4e7a01043d3 to master...


[BUG] Bloxstrap fails to start on latest version.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
Everything was working fine today till i logged off my pc for a few hours. I came back, wanted to hop into a game and it just fails to launch. Tried reïnstalling, disabled all my startup apps in task manager and rebooted my pc, looked at the wiki for anything, went trough reddit but yet nothing has helped me.
Bloxstrap Log
N/A

Maybe show a screenshot?

Screenshot of what exactly?

Of the error.

This is what i gets, the site i get sent to is this one:https://github.com/bloxstraplabs/bloxstrap/wiki/Roblox-crashes-or-does-not-launch

It's taking too long to launch.

and what an cause this? The wiki wasn't helpfull so im pretty desperate

Bloxstrap_20241019T181047Z.log

Does Roblox launch if you use the original launcher?

Please open a new issue when you can confirm that this happens only with Bloxstrap


python39Packages.sentry-sdk build failure on x86_64-linux as of f684f5a9

Issue description
Build of python39Packages.sentry-sdk failed on x86_64-linux as of f684f5a9553e54ce41ca38e87c1aac0231a8a34a. This is currently breaking python3Packages.wandb.
error: builder for '/nix/store/vmz9ai13bas7bd96644m7fl26n9wwkix-python3.9-sentry-sdk-1.5.8.drv' failed with exit code 1;
       last 10 log lines:
       > ERROR tests/integrations/flask/test_flask.py::test_errors_not_reported_twice[integrations0]
       > ERROR tests/integrations/flask/test_flask.py::test_errors_not_reported_twice[integrations1]
       > ERROR tests/integrations/flask/test_flask.py::test_logging - werkzeug.excepti...
       > ERROR tests/integrations/flask/test_flask.py::test_500 - werkzeug.exceptions....
       > ERROR tests/integrations/flask/test_flask.py::test_error_in_errorhandler - we...
       > ERROR tests/integrations/flask/test_flask.py::test_tracing_success - werkzeug...
       > ERROR tests/integrations/flask/test_flask.py::test_tracing_error - werkzeug.e...
       > ERROR tests/integrations/flask/test_flask.py::test_class_based_views - werkze...
       > ERROR tests/integrations/flask/test_flask.py::test_sentry_trace_context - wer...
       > = 37 failed, 563 passed, 32 skipped, 18 deselected, 2 xfailed, 17 warnings, 38 errors in 78.39s (0:01:18) =
       For full logs, run 'nix log /nix/store/vmz9ai13bas7bd96644m7fl26n9wwkix-python3.9-sentry-sdk-1.5.8.drv'.
error: 1 dependencies of derivation '/nix/store/a9qj61agsq4gnrsamsg62bkzy289ps2g-python3.9-wandb-0.12.14.drv' failed to build

full build log
python3Packages.wandb maintainers cc: @samuela
python39Packages.sentry-sdk maintainers cc: @fabaff @gebner
Other cc: n/a
Steps to reproduce

Checkout nixpkgs at commit f684f5a9553e54ce41ca38e87c1aac0231a8a34a
Run nix-build -A python39Packages.sentry-sdk

Technical details
 - system: `"x86_64-linux"`
 - host os: `Linux 5.13.0-1021-azure, Ubuntu, 20.04.4 LTS (Focal Fossa), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.0`
 - nixpkgs: `/nix/store/r902mrj2iwsjhy8gs6y0rbr9nada0z4z-source`

Misc.
This issue was automatically generated by nixpkgs-upkeep.

CI workflow that created this issue.
Internal tag: -1137150796892799897

Duplicate of #169130


adds pairs metatable for GVariant dictionary

This is a possible fix for https://github.com/pavouk/lgi/issues/201

I haven't tested this, but from a quick first look it seems sane.
Could you also add a unit test for this? Something similar to my answers in #201: The code constructs a GVariant-instance and then tests that iterating over it produces the expected values.
(The test can be wrapped in either if _VERSION >= "5.1" or (perhaps better) some feature test, e.g. if 42 == pairs(setmetatable({}, { __pairs = function() return 42 end })) then)
Side note: I'll be offline for a while soon-ish.

Regarding _VERSION:
That maybe needs some discussion. I thought about _VERSION check but that adds unnecessary complexity (and useless code).
If it's Lua < 5.2 or Luajit then __pairs metamethod is just ignored and should never called. If it's compatible with __pairs, it's just called. That's the current situation which doesn't produce errors.
A better idea is maybe adding a custom iterator method (which uses __pairs metamethod if defined also in 5.1) somewhere in the lgi which can be called instead of pairs(). Also we can replace pairs() with that compatibility version - but then we will maybe harm the performance of the code and change how foreign Lua code works. I'm not sure if it's really useful to do such compatibility stuff (even checking for _VERSION). What's your opinion?

I only meant "a version check for the test", not for the code itself. The test definitely this check since it otherwise fails with Lua 5.1.

Ah, understood. Your test with 42 should work for Lua 5.1 - everything that doesn't support __pairs should not return 42 :)
I added two tests, because there are two different situations.

function variant.pairs_on_variant_returned_dict
That's my test case from #201.
If a Variant tuple is used, the override-magic from Glib-Variant.Lua ~223 is used.
It returns the extracted data as value in Line 230 (get_variant(var.value[2])) as part of the Lua table (due to the call to tup.value[2] - the access to ".value" does the convert magic)

function variant.pairs_on_variant
Your example on a Variant. Due to the fact that the variant itself is a userdata, pairs() is not working.
It is possible to extend the Variant metatable (I tried that) with

local vmt = getmetatable(Variant)
vmt.__pairs = pairs

but then, pairs() is still not working because of the userdatba-type. If I also extend
vmt.__metatable = { __ index = function(tbl,key) return rawget(Variant,key) end }

pairs() is working but the rest of the Variant code breaks completely, so that's not possible with small code changes. I think it should be possible to extend the Variant userdata itself to support __pairs, but that's too deep for today and this merge request :)
Both tests were successful here.


Documentation for default BGP Configuration serviceExternalIPs

Description
Add documentation for the new ServiceExternalIPs BGP Configuration field.
Related issues/PRs
https://github.com/projectcalico/calico/issues/2770
https://github.com/projectcalico/libcalico-go/pull/1123
https://github.com/projectcalico/confd/pull/266
Release Note
Support sending BGP advertisements for Kubernetes Service External IPs that fall within a set of whitelisted CIDR blocks.

Deploy preview for calico ready!
Built with commit ba03c31b99703042b5d6d708ff43a03f8bf2edd1
https://deploy-preview-2868--calico.netlify.com

Deploy preview for calico ready!
Built with commit c4237fc39d19e002f62f45974697e41c3daf4d63
https://deploy-preview-2868--calico.netlify.com

Deploy preview for calico ready!
Built with commit 571c052e14dc421201a020fe3a98260bb79d60e7
https://deploy-preview-2868--calico.netlify.com


[WIP] Switch to JDK 14 for releasing and CI build

It seems like we need to wait for Proguard gradle 6.3.0. 🤔

Proguard was a problem last time too.

(lately I've been having a lot of problems clicking buttons on mobile accidentally 😭)

will Proguard gradle 7 work?
PS JDK 15 is out, though not on all flavors yet

The Java 14 issue seems to be resolved with Proguard 7.
https://github.com/Guardsquare/proguard/releases/tag/v7.0.0
@minwoox is busy these days to prepare lessons to teach Armeria and its internal architecture to LINE employees. Let me test this PR with Proguard 7 😉

Superseded by #3073


feat: Add IsVisible property to AceData

Fixes #6729
Description
The PR adds IsVisible property to the AceData class to implement the #6729  feature request.
Specific Changes
public class AceData
{
  // ...
  /// <summary>
   /// Gets or sets the visibility of the Adaptive Card Extension.
   /// </summary>
   /// <value>The value is the flag that indicates if the Adaptive Card Extension is visible. Default to true.</value>
   [JsonProperty(PropertyName = "isVisible")]
   public bool? IsVisible { get; set; }
  // ...
}

@AJIXuMuK If you update from main, the build issue should be fixed.


RFC: USD in the Scene Pipeline

Resolves: https://github.com/o3de/o3de/issues/18248

Wrong branch. See https://github.com/o3de/sig-simulation/pull/92


Graceful shutdown never finishes

Hey, I have an endpoint that shutdown will never complete never finishes when the server get the following error:
[2020-10-01][14:52:50][hyper::server::tcp][ERROR] accept error: Too many open files (os error 24)
let graceful = server.with_graceful_shutdown(async {
     rx.await.ok();
     // still it reaches this line
});

if let Err(e) = graceful.await {
    error!("error: {}, endpoint: {}", e, self.addr);
}
// but never reach this line when the server get `accept error / Too many open files`

I can also confirm that after the accept error and before the shutdown there are open connections left behind with state (using ss -t)

FIN-WAIT-1                0                     2822                                                   <IP_ADDRESS>:terabase                                                            <IP_ADDRESS>:40830

LAST-ACK                  0                     1                                                      <IP_ADDRESS>:40830                                                               <IP_ADDRESS>:terabase

FIN-WAIT-1                0                     2822                                                   <IP_ADDRESS>:terabase                                                            <IP_ADDRESS>:40830

And after sending shutdown signal the connections get dropped but still some active with ESTAB state

ESTAB                     0                     0                                                      <IP_ADDRESS>:terabase                                                             <IP_ADDRESS>:57234

Also something important to mention that my application handles all requests that are passed to handle function and using atomic I was able to verify that no active API call left behind, so probably the issue is from hyper side whenever the server get overloaded or accept error
Thank you

#1885


NP-274 print styles

CSS Print styles added to format components appropriately for printing.
Note that Safari does not respect @page so print margins won't work there.

Nice, LGTM from Dev perspective.


Possible issue with IW on Warp 1.2.0

reported by @twilson63 on Discord.
For reference:

https://github.com/twilson63/bug-report-warp

So I'm in the process of analyzing what is going on..(a disclaimer - it's kinda difficult to quickly wrap my head around such scenarios - the contracts themselves have ~600 and ~150 loc and they are in a "compiled" form..).
I need to fully understand what the contracts are doing and how they interact with each other in the test case.
Now
From your test - when the
await asset.writeInteraction({
    function: "createOrder",
    pair: [barContract, assetContract],
    qty: 10000,
    transaction: result.originalTxId,
  }, {strict: true});

and then
const assetResult = await asset.readState();
is being called, the logs from contracts are as follow (I've added some in the contracts):
ASSET readState
ASSET::CreateOrder
ASSET::CreateOrder before claim balance
ASSET::CreateOrder:claimBalance - before internal write
BAR::claim
ASSET::CreateOrder:claimBalance - after internal wriate
ASSET::CreateOrder after claim balance
BAR::transfer {
  target: 'lbhCqadjz6OGLDUzYyUd-YGZ3iEqSpdOkkYt5-_3_-I',
  quantity: 9800
} - I DON'T CURRENTLY UNDERSTAND WHAT IS TRIGGERING THIS TRANSFER ON A BAR CONTRACT.
BAR::transfer - caller balancer validation { callerBalance: null, quantity: 9800 }
BAR::transfer - caller balance validation failed
ASSET::CreateOrder:refundTransfer before internal write transfer AnHVDu4h_W0SBhhPaISmbk-EQ5bsyEqFgcQrsyp3VMA
BAR::transfer {
  target: 'mTe_4T5CxFr2plT5vvlOEFuII0T9LTwjnKEG7Dkcz_Q',
  quantity: 10000
}
BAR::transfer - caller balancer validation { callerBalance: null, quantity: 10000 }
BAR::transfer - caller balance validation failed

And the resulting error message for this interaction is:
errorMessages: {
      'wKcCK3ewP7WDF2IvGdetqh-aEDlr5hVkiU9_cWHEngw': 'Internal write auto error for call [{"from":"bebeT2JMNK5UXfWO3R21PPohe2pQ0H0XanzOPZbkyNU","to":"wfnpEzPPCW9INAHIV8_aNmFUDtovPnslBJw3txEOrPo","input":{"function":"transfer","target":"4Pm12dZcY42TSmgt-23DmKMWRYvULZW9KVmf7P479-k","qty":10000}}]: Caller balance not high enough to send 10000 token(s).'
}

which is probably a reason why the whole test fails (as the "createOrder" interaction fails in general).
One things I don't understand - is where this first transfer on bar contract is coming from (during the evaluation of the "CreateOrder" of the asset contract - I've marked this in the pasted logs - I'll analyze this further though, but maybe you could give me a hint?

So the createOrder is part of Verto Flex; I don't understand all the internals, but here is the repository for the module
https://github.com/useverto/flex
I am just a user of this component, for internal workings it might be best to discuss with Tate or Marton of Component Labs
I know it works fine on warp 1.1.14 but not on 1.2.x

I see, so I guess I'll need to first fully understand how flex works :-)

From Discord:
Hey again. I believe the "flex" contract (or Bar or whatever - I'm  slowly loosing track what is what) is broken.
https://github.com/warp-contracts/bug-report-warp/commit/d0595c698c5b0162d7ca6a24fad0f225e8bea77a#diff-064d8d9821ce90c7f031f70db6b1beb85ae93e915fe355323bd8189ebc025a27R153
undefined + number = NaN in JS.
With the above fix the test passes correctly.
The "claim" internal write from asset to bar was causing NaN to be set in the balances map - for the above reason.
ASSET::CreateOrder:claimBalance - before internal write
BAR::claim
BAR::claim:claimable_obj {
  obj: {
    from: 'biCMe9SvILqwCYutedN4UPi7i8BKM5wZGufUyx9lRwM',
    to: 'Xv0kFB0cKTwzsTF8mTb7B0cii096UFMpIxoOlGa9N6o',
    qty: 10000,
    txID: 'tmWrWDa9gpECQqs1e7TMdsiiLEHBRZlUGbwtoy2VvxA'
  },
  caller: 'Xv0kFB0cKTwzsTF8mTb7B0cii096UFMpIxoOlGa9N6o',
  callerBalance: undefined
}
ASSET::CreateOrder:claimBalance - after internal write {
  balances: {
    biCMe9SvILqwCYutedN4UPi7i8BKM5wZGufUyx9lRwM: 990000,
    'AsuUQfu-eEX50jfpYO2tCOjKV_ezcy3Hb5fL9s5AVWg': 1000000,
    Xv0kFB0cKTwzsTF8mTb7B0cii096UFMpIxoOlGa9N6o: NaN
  },
  canEvolve: true,
  claimable: [],
  claims: [ 'tmWrWDa9gpECQqs1e7TMdsiiLEHBRZlUGbwtoy2VvxA' ],
  creator: 'biCMe9SvILqwCYutedN4UPi7i8BKM5wZGufUyx9lRwM',
  divisibility: 6,
  name: 'BAR',
  settings: [ [ 'isTradeable', true ] ],
  ticker: 'BAR'
}

This in turn was causing the next internal write from asset to bar to fail
BAR::transfer - caller balancer validation { callerBalance: null, quantity: 9800 }
BAR::transfer - caller balance validation failed
ASSET::CreateOrder:catch ContractError: Internal write auto error for call [{"from":"Xv0kFB0cKTwzsTF8mTb7B0cii096UFMpIxoOlGa9N6o","to":"-zBCBPMsyVCecFJHpMgSu68_0h628yJHIfNf33bsAxw","input":{"function":"transfer","target":"AsuUQfu-eEX50jfpYO2tCOjKV_ezcy3Hb5fL9s5AVWg","qty":9800}}]: Caller balance not high enough to send 9800 token(s).
    at swGlobal.contracts.write (/Users/piotrpedziwiatr/projects/bug-report-warp/node_modules/warp2/lib/cjs/core/modules/impl/handler/AbstractContractHandler.js:63:23)

The reason it "worked" in 1.1.4 is probably because the results of the internal writes were not properly verified for each internal write.
1.2.0 by default throws a ContractError from the outer transaction whenever the internal write fails - in order to remove the need to write the boilerplate check:
if (result.type !== "ok") {
      throw new ContractError(`Oh no, internal write have exploded`);
    }

I will analyse why exactly it "works" in 1.1.4 on Monday.