add password change dialog to xrdp, used from sesman when password ex…

…pires
This patch is from
Tim Fischer<EMAIL_ADDRESS>Felix Zhang<EMAIL_ADDRESS>

you can use
chage -d 0 <username>

to test

Yea, I think this PR needs work.
I don't know if you seen the new dialog but that looks like it needs work too.

I just found another bug. When a user gets prompted to change his password and password change was successful, logon works normally and the desktop is shown. After ending the session, there is one "Zombie" process left (in my case, user "tim2" had to change his expired password):
Output of ps axu:
tim2      3266  0.0  0.0      0     0 ?        Z    15:24   0:00 [xrdp-sessvc] <defunct>
Login again with user "tim2" is then not possible any more, the desktop does not fire up.
When logging in with another user, the same thing happens also for him. He is still able to logon once, and after disconnect or logoff, a Zombie is left and logon for this user is also not possible any longer.
To get rid of the "defunct" processes, xrdp has to be killed and restarted. After that, everything works fine until another user tries to change his password.
What is the difference when starting / ending a session with a newly changed password and a "normal" session with a password that isn't expired?
The syslog continuosly tells:
Jan  6 00:16:12 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:15 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:19 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:23 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:27 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:30 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:34 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:37 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:41 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:45 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:49 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:52 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:56 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX) Jan  6 00:16:59 lxc-deb8-compiler xrdp[1711]: (1711)(140610328073984)[DEBUG] Closed socket 25 (AF_UNIX)

Found out the root cause on this. The pam_chauthtok function calls another external program, possibly "passwd". For that, it establishes its own SIGCHLD signal and function. To get the correct functionality, before calling pam_chauthtok, SIGCHLD has to be blocked and restored after the call. The signal handlers for sesman ( at least SIGCHLD) has to be reinitialized completely. I wrote a small patch for it. Will provide it later that day.

Hi, I was wondering if there has been any further progress made on this issue?  I could not find anything indicating if this issue has been closed/completed.  I tried testing with xrdp-0.9.6-1.el7.x86_64 and did not see a password change dialog-box.  Thanks.

The patch is not yet implemented into the current xrdp branch, as it needs some structural changes. I do not know the actual status of this issue and if someone is working on it. I have a patch here that works for 0.9.6. If you like, I would be able to share it.

Thanks for your reply.  I am interested in getting a copy of your patch. Is it available for download?  Any additional information on how to incorporate your patch into my system would be appreciated.
Sent from my iPhone

On May 10, 2018, at 5:26 AM, Tim Fischer<EMAIL_ADDRESS>wrote:
The patch is not yet implemented into the current xrdp branch, as it needs some structural changes. I do not know the actual status of this issue and if someone is working on it. I have a patch here that works for 0.9.6. If you like, I would be able to share it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I just cloned the current xrdp devel branch and uploaded the changes to a new branch. You may download it here:
https://github.com/tfischer77/xrdp/tree/pwd_change
Changes:
https://github.com/tfischer77/xrdp/commit/98f51cbfe0583261359c9719dc2633d8f9caa26e
Please keep in mind: The patch is working, but is far away from being perfect (although I'm using it in a productive environment since almost two years without having any issues). At least 85 percent of the patch were written by Felix Zhang, I only changed the pam conversation function to work properly.
I don't think the changes fulfil the coding quality standards of xrdp. So I will not do a pull request to the original xrdp except if any of the xrdp developers (e.g. @jsorg71 who opened the original pull request) tell me to do so.

Got it working!  Thanks a lot!

Hello,
Has there been any development in this regard?

Hello,
Has there been any development in this regard?

Hello,
any news on this? Would be great to have a solution for this issue :-)

No, there's no significant news to report on so far.
I'm just had a look at the code in the PR. I'm having a few problems following the chain of events, and the interaction between the conversation code and the rest of the system. but I'm sure I can sort that out with a debugger.
The architecture doesn't look quite right to me. We're solving a particular problem which is already (to some extent) solved in the PAM stack itself. So this will allow us to change expired passwords, but will do nothing to solve other issues generally handled in PAM, like 2FA.
A more generic solution might be to tunnel the PAM conversation over SCP and simply present the PAM prompts to the user at that point. Then we wouldn't actually care whether the password was being changed, or whether 2FA was being employed, or whatever.
I appreciate this is a not at all simple to get to from where we are. It needs significant upgrades to SCP, and the structure of sesman.
Comments anyone?

Hello Matt,
thanks for taking a look on this :-) My knowledge goes far enough to generally understand what you are talking about, but not that far to give some qualified comments ;-) But happy to hear from you :-)

Hi @Samoangtagey - FYI I'd like to get some broader discussion going on this (see #1961) so I can get some feedback on whether I've got the right idea about this or not.
If you, or anyone else reading this thread wants to jump in and comment, please do so.


Use eyre::Report to get context for error from API calls

Ideally we would have access to the endpoint and query parameters in the logs.

Unfortunately, this does not seem to be straightforward. Firstly, eyre is not compatible with the API because of the need to specify an error code. Secondly, the URI/query params come from the request and cannot, as far as I can tell, be easily added to the response in a single place. They would have to be manually extracted from the request and added to every error at the creation site. However, the URI at least is noted by tower_http::trace, so if we get jaeger or whatever working, we should be able to find that information and associate it with internal errors.


Parentheses in return type template fail Sphinx

This C++ snippet is not correctly handled by Exhale:
// This fails because everything before the first opening parenthesis is
// stripped from the output
template <size_t N>
std::array<double, (N + 1)> broken_func();

It fails Sphinx with this error message:
reading sources... [ 58%] api/function_my__func_8hpp_1af3a81a9bfbf0ad5fb56e57f234727619
Exception occurred:
  File "/Users/nlf/.virtualenvs/spectre/lib/python3.8/site-packages/sphinx/util/cfamily.py", line 291, in fail
    raise self._make_multi_error(errors, '')
sphinx.util.cfamily.DefinitionError: Invalid C++ declaration: Expecting "," or ")" in parameters-and-qualifiers, got "+". [error at 3]
  (N + 1)> broken_func()
  ---^

The snippet works correctly when replacing (N + 1) with N. Here's a minimal working example to reproduce the issue:
https://github.com/nilsleiffischer/sphinx-bugs/tree/master/issue_exhale_templates
I have verified that the issue is not in Sphinx or Breathe, since it works when using those two without Exhale and generating the documentation with Breathe's .. autodoxygenindex::.
This is my environment:

Python 3.8.6
Breathe (breathe-apidoc) 4.27.0
sphinx-build 3.5.3
Doxygen 1.8.17
Exhale 0.2.3

Thank you for the detailed report, very helpful!  I'm closing this as a "duplicate in disguise", see https://github.com/svenevs/exhale/issues/106#issuecomment-834218192
I am open to hacks as well but I don't think that's a good avenue forward pending that discussion.  Please re-open if you feel it's not actually the same bug!


[Docs] Add import/recommended ruleset to README

Here's a simple fix to #2032. As suggested, I didn't increase the prominence of import/recommended any more than import/errors and import/warnings already had.  Let me know if you'd like more or less change.

Coverage increased (+1.6%) to 71.142% when pulling 747772e401650373adeb926a394687e36c3a8c0c on edemaine:import-recommended into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

Coverage increased (+1.6%) to 71.142% when pulling 747772e401650373adeb926a394687e36c3a8c0c on edemaine:import-recommended into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

Coverage increased (+1.6%) to 71.142% when pulling 747772e401650373adeb926a394687e36c3a8c0c on edemaine:import-recommended into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.

Coverage increased (+1.6%) to 71.142% when pulling 747772e401650373adeb926a394687e36c3a8c0c on edemaine:import-recommended into e871a9a2e18fd4d67a5a237789131b44cc705b5b on benmosher:master.


Error using Visdom as exp. tracking system for image-segmentation

Describe the bug
AttributeError: 'VisdomLogger' object has no attribute 'writer'
Expected result
No error.
Reproduction
Please see line 137, src/templates/template-vision-segmentation/vis.py.
logger.writer.add_image is for tensorboard, no?
logger.writer.add_image
Steps to reproduce
Choose template for vision-segmentation
Choose Visdom for exp. tracking system.

@idkwid2022 thanks for raising this issue. You are right this line :
https://github.com/pytorch-ignite/code-generator/blob/f1372194000fb461c9e3eb7f4f85f43ad8f61a6c/src/templates/template-vision-segmentation/vis.py#L137-L142
is working only with TensorBoard. Would you like to suggest a fix ?
Quick fix could be just to make sure that this code : https://github.com/pytorch-ignite/code-generator/blob/f1372194000fb461c9e3eb7f4f85f43ad8f61a6c/src/templates/template-vision-segmentation/main.py#L114-L141
is executed only if exp_logger is TensorBoard.
Another fix could be to find some common method we could call with all supported exp tracking systems...

@vfdev-5 I don't think I have qualification for any suggestion, I'm a total newbie in this.
If I may, I think it should be like in image classification template since the logger options is the same for every template (template-vision-classification/utils.py, line 213, function setup_exp_logging) other option is to disable the loggers other than tensorboard, but that's a bummer isn't it?
Anyhow, I kinda did make it run on my notebook, but I forgot which lines I changed. The main change is on vis.py, line 137:
logger.vis.image(grid_pred_gt.transpose(2,0,1), win=tag, opts=dict(title=tag))

But that's just to make it run only on visdom. So maybe like this:
#::: if (it.logger === 'tensorboard') { :::#
        logger.writer.add_image(
            tag=tag,
            img_tensor=grid_pred_gt,
            global_step=global_step,
            dataformats="HWC",
        )
#::: } else if (it.logger === 'visdom') { :::#
        logger.vis.image(grid_pred_gt.transpose(2,0,1), win=tag, opts=dict(title=tag))
#::: } :::#

Like on image classification template? I don't know about the other logging system. I'm sorry I can't be much of a help.

@idkwid2022 no problems about your qualifications.
I agree with your suggestion for tb and visdom only if/else branches. For others we can update later if there's a requirement.
I have to check classification template but I do not remember if we were logging any images there...

I meant about how the classification template deals with different loggers. I have not use the template, so I don't know if it logs images.


Response editing showing wrong response name

Describe the bug
After importing a project with some responses, if you create a new one and try to edit it, the response editor will show wrong response name.
To Reproduce
Steps to reproduce the behavior:

Import some responses
Create a new one
Edit the new one
Wrong response name on editor

Expected behavior
Response editor should show the response name that was selected
Screenshots
Clicked on "utter_test" and editor shows correct text but wrong name (utter_acessar_curso)

Additional context
Botfront 0.19.0

so you think it's just an indexing problem?
is it always off in the same direction vs. another list?

I found out that it happens after you search for an utter, but it seems this pr fixed it. I didn't test it yet


Update Timeline “2022-06-16t15-40-38-831z-campaign”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
e72bed96f3710ebe1731affac15229738bc883c4

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/63389ac3fc57a4000828ceff


Add other fips check gosyms tool to support running pods scan

To support fips check for all the binaries in all the running pods, add gosyms tool

@rphillips @mrunalp What's your opinion on this PR? Thanks.

@xiaojiey is going to refactor this to be a subcommand.

@xiaojiey is going to refactor this to be a subcommand.

@xiaojiey It would be nice to reuse the code from internal/golang/goscan.go (currently it seems it's a copy-paste, which creates a maintenance burden).

/close
I will raise a new PR instead.


fix: [nanoid]

This PR addresses known vulnerabilities in nanoid.
Changelog:

Updated nanoid from version 5.0.7 to 5.0.9.
Files changed: package.json,package-lock.json

More details can be found in the Snyk project MarcoMadera/Blog:package.json.
Testing instructions

[!IMPORTANT]

Check the changes in this PR to ensure no breaking changes.
Run automated tests

fix applied by marcomadera

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)


Install imc and mt channel broker manifests

with knative nightly and released version install utils
follow up PR to #24
The eventing.yaml is brought back already, so we can consider reverting #24 or keep it this way. wdyt? /cc @n3wscott @chizhg

alternate to #26
/hold

/close
I think installing eventing using single yaml (eventing.yaml) is better than via 4 yamls.
#26 supersedes this.


Backport create-and-provision-device-cert fixes to v1.8.x branch

Recent changes to have the device create the private key makes some of the code in the create-and-provision-device-cert CLI command no longer work.
This has been fixed in 7d512c05337f600c5c6f6b241d37147078124ef2 but this change can't be cherry picked directly to v1.8.x branch, because there was an update to the way the serialport package is used. So more work is needed to make the fix work with v1.8.x without including other breaking changes from v9 and v8.

Works.
$ node cli create-and-provision-device-cert --dk --debug --delete-private-key

Flasing certificate /dev/ttyACM0
Connecting to /dev/ttyACM0
Inactivity timeout 10 seconds
/dev/ttyACM0 connected
AT Host h
w4 4001e504 2
w4 4001e50c 1
sleep 100
rx 1000
h
w4 4001e504 1
loadfile<EMAIL_ADDRESS>rx 1000
g
exit
AT Host SEGGER J-Link Commander V7.62c (Compiled Mar 23 2022 16:44:40)
AT Host DLL version V7.62c, compiled Mar 23 2022 16:44:26
AT Host J-Link Command File read successfully.
AT Host Processing script file...
AT Host J-Link>h
AT Host J-Link connection not established yet but required for command.
AT Host Connecting to J-Link via USB...
AT Host O.K.
AT Host Firmware: J-Link OB-K22-NordicSemi compiled Dec  3 2021 15:46:55
AT Host Hardware version: V1.00
AT Host S/N: 960013621
AT Host License(s): RDI, FlashBP, FlashDL, JFlash, GDB
AT Host VTref=3.300V
AT Host Target connection not established yet but required for command.
AT Host Device "NRF9160_XXAA" selected.
AT Host Connecting to target via SWD
AT Host ConfigTargetSettings() start
AT Host ---Setting ROM table---
AT Host ConfigTargetSettings() end
AT Host Found SW-DP with ID 0x6BA02477
AT Host DPIDR: 0x6BA02477
AT Host CoreSight SoC-400 or earlier
AT Host Scanning AP map to find all available APs
AT Host AP[7]: Stopped AP scan as end of AP map has been reached
AT Host AP[0]: AHB-AP (IDR: 0x84770001)
AT Host AP[1]: AHB-AP (IDR: 0x24770011)
AT Host AP[2]: JTAG-AP (IDR: 0x12880000)
AT Host AP[3]: APB-AP (IDR: 0x54770002)
AT Host AP[4]: JTAG-AP (IDR: 0x12880000)
AT Host AP[5]: JTAG-AP (IDR: 0x12880000)
AT Host AP[6]: MEM-AP (IDR: 0x128800A1)
AT Host Iterating through AP map to find AHB-AP to use
AT Host AP[0]: Core found
AT Host AP[0]: AHB-AP ROM base: 0xE00FF000
AT Host CPUID register: 0x410FD212. Implementer code: 0x41 (ARM)
AT Host Feature set: Mainline
AT Host Found Cortex-M33 r0p2, Little endian.
AT Host FPUnit: 8 code (BP) slots and 0 literal slots
AT Host Security extension: implemented
AT Host Secure debug: enabled
AT Host CoreSight components:
AT Host ROMTbl[0] @ E00FF000
AT Host [0][0]: E000E000 CID B105900D PID 000BBD21 DEVARCH 47702A04 DEVTYPE 00 Cortex-M33
AT Host [0][1]: E0001000 CID B105900D PID 000BBD21 DEVARCH 47701A02 DEVTYPE 00 DWT
AT Host [0][2]: E0002000 CID B105900D PID 000BBD21 DEVARCH 47701A03 DEVTYPE 00 FPB
AT Host [0][3]: E0000000 CID B105900D PID 000BBD21 DEVARCH 47701A01 DEVTYPE 43 ITM
AT Host [0][5]: E0041000 CID B105900D PID 002BBD21 DEVARCH 47724A13 DEVTYPE 13 ETM
AT Host [0][6]: E0042000 CID B105900D PID 000BBD21 DEVARCH 47701A14 DEVTYPE 14 CSS600-CTI
AT Host Cortex-M33 identified.
AT Host PC = 00011AB6, CycleCnt = 001D943C
AT Host R0 = 00000000, R1 = 00000000, R2 = 00000000, R3 = 00000000
AT Host R4 = 20014FE0, R5 = 00000000, R6 = 00000000, R7 = 00000000
AT Host R8 = 00000000, R9 = 00000000, R10= 00000000, R11= 00000000
AT Host R12= 00000000
AT Host SP(R13)= 20018720, MSP= 20018F30, PSP= 20018720, R14(LR) = 00018969
AT Host XPSR = 61000000: APSR = nZCvq, EPSR = 01000000, IPSR = 000 (NoException)
AT Host CFBP = 02000001, CONTROL = 02, FAULTMASK = 00, BASEPRI = 00, PRIMASK = 01
AT Host MSPLIM = 20018730
AT Host PSPLIM = 200185F0
AT Host Security extension regs:
AT Host MSP_S = 20002E38, MSP_NS = 20018F30
AT Host MSPLIM_S = 20002638, MSPLIM_NS = 20018730
AT Host PSP_S = 20002418, PSP_NS = 20018720
AT Host PSPLIM_S = 200014F8, PSPLIM_NS = 200185F0
AT Host CONTROL_S  = 02, FAULTMASK_S  = 00, BASEPRI_S  = 00, PRIMASK_S  = 00
AT Host CONTROL_NS = 02, FAULTMASK_NS = 00, BASEPRI_NS = 00, PRIMASK_NS = 01
AT Host FPS0 = 00000000, FPS1 = 00000000, FPS2 = 00000000, FPS3 = 00000000
AT Host FPS4 = 00000000, FPS5 = 00000000, FPS6 = 00000000, FPS7 = 00000000
AT Host FPS8 = 00000000, FPS9 = 00000000, FPS10= 00000000, FPS11= 00000000
AT Host FPS12= 00000000, FPS13= 00000000, FPS14= 00000000, FPS15= 00000000
AT Host FPS16= 00000000, FPS17= 00000000, FPS18= 00000000, FPS19= 00000000
AT Host FPS20= 00000000, FPS21= 00000000, FPS22= 00000000, FPS23= 00000000
AT Host FPS24= 00000000, FPS25= 00000000, FPS26= 00000000, FPS27= 00000000
AT Host FPS28= 00000000, FPS29= 00000000, FPS30= 00000000, FPS31= 00000000
AT Host FPSCR= 00000000
AT Host J-Link>w4 4001e504 2
AT Host Writing 00000002 -> 4001E504
AT Host J-Link>w4 4001e50c 1
AT Host Writing 00000001 -> 4001E50C
AT Host J-Link>sleep 100
AT Host Sleep(100)
AT Host J-Link>rx 1000
AT Host Reset delay: 1000 ms
AT Host Reset type NORMAL: Resets core & peripherals via SYSRESETREQ & VECTRESET bit.
AT Host Reset: ARMv8M core with Security Extension enabled detected.
AT Host Reset: Halt core after reset via DEMCR.VC_CORERESET.
AT Host Reset: Reset device via AIRCR.SYSRESETREQ.
AT Host J-Link>h
AT Host PC = 000022BC, CycleCnt = 00000000
AT Host R0 = 00000000, R1 = 00000000, R2 = 00000000, R3 = 00000000
AT Host R4 = 00000000, R5 = 00000000, R6 = 00000000, R7 = 00000000
AT Host R8 = 00000000, R9 = 00000000, R10= 00000000, R11= 00000000
AT Host R12= 00000000
AT Host SP(R13)= 200024F8, MSP= 200024F8, PSP= 00000000, R14(LR) = FFFFFFFF
AT Host XPSR = F9000000: APSR = NZCVQ, EPSR = 01000000, IPSR = 000 (NoException)
AT Host CFBP = 00000000, CONTROL = 00, FAULTMASK = 00, BASEPRI = 00, PRIMASK = 00
AT Host MSPLIM = 00000000
AT Host PSPLIM = 00000000
AT Host Security extension regs:
AT Host MSP_S = 200024F8, MSP_NS = 00000000
AT Host MSPLIM_S = 00000000, MSPLIM_NS = 00000000
AT Host PSP_S = 00000000, PSP_NS = 20018720
AT Host PSPLIM_S = 00000000, PSPLIM_NS = 00000000
AT Host CONTROL_S  = 00, FAULTMASK_S  = 00, BASEPRI_S  = 00, PRIMASK_S  = 00
AT Host CONTROL_NS = 00, FAULTMASK_NS = 00, BASEPRI_NS = 00, PRIMASK_NS = 00
AT Host FPS0 = 00000000, FPS1 = 00000000, FPS2 = 00000000, FPS3 = 00000000
AT Host FPS4 = 00000000, FPS5 = 00000000, FPS6 = 00000000, FPS7 = 00000000
AT Host FPS8 = 00000000, FPS9 = 00000000, FPS10= 00000000, FPS11= 00000000
AT Host FPS12= 00000000, FPS13= 00000000, FPS14= 00000000, FPS15= 00000000
AT Host FPS16= 00000000, FPS17= 00000000, FPS18= 00000000, FPS19= 00000000
AT Host FPS20= 00000000, FPS21= 00000000, FPS22= 00000000, FPS23= 00000000
AT Host FPS24= 00000000, FPS25= 00000000, FPS26= 00000000, FPS27= 00000000
AT Host FPS28= 00000000, FPS29= 00000000, FPS30= 00000000, FPS31= 00000000
AT Host FPSCR= 00000000
AT Host J-Link>w4 4001e504 1
AT Host Writing 00000001 -> 4001E504
AT Host J-Link>loadfile<EMAIL_ADDRESS>AT Host Downloading file<EMAIL_ADDRESS>AT Host Comparing flash   [000%]
AT 050%]
AT 050%]
AT 100%] Done.
AT Host J-Link: Flash download: Bank 2 @ 0x00000000: Skipped. Contents already match
AT Host O.K.
AT Host J-Link>rx 1000
AT Host Reset delay: 1000 ms
AT Host Reset type NORMAL: Resets core & peripherals via SYSRESETREQ & VECTRESET bit.
AT Host Reset: ARMv8M core with Security Extension enabled detected.
AT Host Reset: Halt core after reset via DEMCR.VC_CORERESET.
AT Host Reset: Reset device via AIRCR.SYSRESETREQ.
AT Host J-Link>g
AT Host J-Link>exit
AT Host Script processing completed.
/dev/ttyACM0 *** Booting Zephyr OS build v2.7.0-ncs1  ***
/dev/ttyACM0 Flash regions              Domain          Permissions
/dev/ttyACM0 00 01 0x00000 0x10000      Secure          rwxl
/dev/ttyACM0 02 31 0x10000 0x100000     Non-Secure      rwxl
/dev/ttyACM0 Non-secure callable region 0 placed in flash region 1 with size 32.
/dev/ttyACM0 SRAM region                Domain          Permissions
/dev/ttyACM0 00 07 0x00000 0x10000      Secure          rwxl
/dev/ttyACM0 08 31 0x10000 0x40000      Non-Secure      rwxl
/dev/ttyACM0 Peripheral         Domain          Status
/dev/ttyACM0 00 NRF_P0               Non-Secure OK
/dev/ttyACM0 01 NRF_CLOCK            Non-Secure OK
/dev/ttyACM0 02 NRF_RTC0             Non-Secure OK
/dev/ttyACM0 03 NRF_RTC1             Non-Secure OK
/dev/ttyACM0 04 NRF_NVMC             Non-Secure OK
/dev/ttyACM0 05 NRF_UARTE1           Non-Secure OK
/dev/ttyACM0 06 NRF_UARTE2           Secure             SKIP
/dev/ttyACM0 07 NRF_TWIM2            Non-Secure OK
/dev/ttyACM0 08 NRF_SPIM3            Non-Secure OK
/dev/ttyACM0 09 NRF_TIMER0           Non-Secure OK
/dev/ttyACM0 10 NRF_TIMER1           Non-Secure OK
/dev/ttyACM0 11 NRF_TIMER2           Non-Secure OK
/dev/ttyACM0 12 NRF_SAADC            Non-Secure OK
/dev/ttyACM0 13 NRF_PWM0             Non-Secure OK
/dev/ttyACM0 14 NRF_PWM1             Non-Secure OK
/dev/ttyACM0 15 NRF_PWM2             Non-Secure OK
/dev/ttyACM0 16 NRF_PWM3             Non-Secure OK
/dev/ttyACM0 17 NRF_WDT              Non-Secure OK
/dev/ttyACM0 18 NRF_IPC              Non-Secure OK
/dev/ttyACM0 19 NRF_VMC              Non-Secure OK
/dev/ttyACM0 20 NRF_FPU              Non-Secure OK
/dev/ttyACM0 21 NRF_EGU0             Non-Secure OK
/dev/ttyACM0 22 NRF_EGU1             Non-Secure OK
/dev/ttyACM0 23 NRF_EGU2             Non-Secure OK
/dev/ttyACM0 24 NRF_EGU3             Non-Secure OK
/dev/ttyACM0 25 NRF_EGU4             Non-Secure OK
/dev/ttyACM0 26 NRF_EGU5             Non-Secure OK
/dev/ttyACM0 27 NRF_DPPIC            Non-Secure OK
/dev/ttyACM0 28 NRF_REGULATORS       Non-Secure OK
/dev/ttyACM0 29 NRF_PDM              Non-Secure OK
/dev/ttyACM0 30 NRF_I2S              Non-Secure OK
/dev/ttyACM0 31 NRF_GPIOTE1          Non-Secure OK
/dev/ttyACM0 SPM: NS image at 0x10000
/dev/ttyACM0 SPM: NS MSP at 0x200185f0
/dev/ttyACM0 SPM: NS reset vector at 0x11ff5
/dev/ttyACM0 SPM: prepare to jump to Non-Secure image.
/dev/ttyACM0 *** Booting Zephyr OS build v2.7.0-ncs1  ***
/dev/ttyACM0 The AT host sample started
/dev/ttyACM0 AT> AT+CGSN=1
/dev/ttyACM0 +CGSN: "352656100391948"
/dev/ttyACM0 <AT +CGSN: "352656100391948"
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
IMEI:<PHONE_NUMBER>91948
/dev/ttyACM0 AT> AT+CGMR
/dev/ttyACM0 mfw_nrf9160_1.3.1
/dev/ttyACM0 <AT mfw_nrf9160_1.3.1
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
/dev/ttyACM0 AT> AT+CGSN=1
/dev/ttyACM0 +CGSN: "352656100391948"
/dev/ttyACM0 <AT +CGSN: "352656100391948"
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
/dev/ttyACM0 AT> AT+CFUN=4
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
/dev/ttyACM0 AT> AT%CMNG=3,42,2
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
/dev/ttyACM0 AT> AT%KEYGEN=42,2,0,"CN=352656100391948","101010000"
/dev/ttyACM0 %KEYGEN: "MIH1MIGaAgEAMBoxGDAWBgNVBAMMDzM1MjY1NjEwMDM5MTk0ODBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABFRSVWK0NSRxpUIpLC692G5_jC0rfpXG7Hz1uy6g3SWKUhSjCwUNGarVqggew7nw6qS0dtt-8Fp98p4gVd3DHumgHjAcBgkqhkiG9w0BCQ4xDzANMAsGA1UdDwQEAwIDqDAMBggqhkjOPQQDAgUAA0gAMEUCIQCo5aJNgnjd7PIkxsUCMWNC8qDSkjgQJZoL5l62_520qQIgOeDDZH8Ms1YO4d_qJ0N1_39-ytwczt8JVyzBFhfxGUs.0oRDoQEmoQRBIVhM2dn3hQlQUDYxVDkwTViAwhgVjzEMRkIYKlggmP26JyPZJNtJaWFc55jPD-4iAHMC1YL9_d0nOAtMazJQV_MSkAN4DA4d8uQ-QECxn1hAKu67wPVyGwBNsfQrwUfSrhKJ2vOYsNOiBIwe0fOGllAPa8jI1VTTK9K_DDChXIAAeOIm-4n_e2HJoOlPVmB44A"
/dev/ttyACM0 <AT %KEYGEN: "MIH1MIGaAgEAMBoxGDAWBgNVBAMMDzM1MjY1NjEwMDM5MTk0ODBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABFRSVWK0NSRxpUIpLC692G5_jC0rfpXG7Hz1uy6g3SWKUhSjCwUNGarVqggew7nw6qS0dtt-8Fp98p4gVd3DHumgHjAcBgkqhkiG9w0BCQ4xDzANMAsGA1UdDwQEAwIDqDAMBggqhkjOPQQDAgUAA0gAMEUCIQCo5aJNgnjd7PIkxsUCMWNC8qDSkjgQJZoL5l62_520qQIgOeDDZH8Ms1YO4d_qJ0N1_39-ytwczt8JVyzBFhfxGUs.0oRDoQEmoQRBIVhM2dn3hQlQUDYxVDkwTViAwhgVjzEMRkIYKlggmP26JyPZJNtJaWFc55jPD-4iAHMC1YL9_d0nOAtMazJQV_MSkAN4DA4d8uQ-QECxn1hAKu67wPVyGwBNsfQrwUfSrhKJ2vOYsNOiBIwe0fOGllAPa8jI1VTTK9K_DDChXIAAeOIm-4n_e2HJoOlPVmB44A"
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
/dev/ttyACM0 AT> AT+CFUN=1
/dev/ttyACM0 OK
/dev/ttyACM0 <AT OK
Intermediate certificate: 3d8f5621-064f-4cc6-903d-f0ab62398594
Generating certificate for device<PHONE_NUMBER>91948
-----BEGIN CERTIFICATE-----
MIICNDCCARygAwIBAgIEIGGvgzANBgkqhkiG9w0BAQsFADBLMUkwRwYDVQQDDEBB
...
V0p6eE/VM0RFXKMgn8+f0hqKCuK1u35d2rzvp4/+9eqLkPEZtXztNw==
-----END CERTIFICATE-----
/home/m/nrf-asset-tracker/azure/certificates/assettrackerprodIotHub.azure-devices.net/device-352656100391948.bundle.pem written
/home/m/nrf-asset-tracker/azure/certificates/assettrackerprodIotHub.azure-devices.net/device-352656100391948.intermediateCertId written
/home/m/nrf-asset-tracker/azure/certificates/assettrackerprodIotHub.azure-devices.net/device-352656100391948.pem written
Certificate for device generated.
Certificate ID:<PHONE_NUMBER>91948

Firmware configuration:

DPS hostname: global.azure-devices-provisioning.net
ID scope: 0ne002847CD
/dev/ttyACM0 No data received after 10 seconds
/dev/ttyACM0 closing port
/dev/ttyACM0 port closed
/dev/ttyACM0 port closed


Feature/language support

This is a fix for :
https://github.com/ntedgi/node-efficientnet/issues/56

@ntedgi
Finally solved all the problems - I'll split it to separate branches later as discussed and let you know once I'm done.

Should be merged after :
https://github.com/ntedgi/node-efficientnet/pull/89
https://github.com/ntedgi/node-efficientnet/pull/90

@ntedgi I've merged main into the branch - I think it's ready to be merged after your approval.


About OneJS

Can OneJS Work With EChart Or Other Chart?

Hello, if EChart has dependency on canvas or svg, then no. UI Toolkit
doesn't have support for these yet. (SVG support maybe a possibility in the
future though).
On Mon, Jul 4, 2022, 4:05 AM zero16832 @.***> wrote:

Can OneJS Work With EChart Or Other Chart?
—
Reply to this email directly, view it on GitHub
https://github.com/DragonGround/OverwatchSample/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFCXH65PIGORXEYCHMZDD3VSKLOFANCNFSM52SJET6Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


JFrog CLI doesn't exit with a non-zero exit code if an authentication failure happens

Describe the bug
When a jfrog-cli operation fails due to an authentication failure, the cli exits with a zero exit code, which makes it harder to determine if an operation has succeeded or not. This seems to apply to any operation not just upload as given in my example.
To Reproduce
Attempt to do something with the jfrog CLI against an artifactory instance without authenticating first. We are using access tokens usually, but the same behaviour happens using a username and apikey or simply not authenticating.
Expected behavior
I would expect to see the same error as currently:
jfrog rt u /tmp/my-package-v2-3-6-1f9c1ccb12de903677c98c15d8f266488a27163b.tar my-repo/path/to/my-package/my-package-v2-3-6-1f9c1ccb12de903677c98c15d8f266488a27163b.tar
[Info] [Thread 2] Uploading artifact: /tmp/my-package-v2-3-6-1f9c1ccb12de903677c98c15d8f266488a27163b.tar
[Error] [Thread 2] Artifactory response: 401 Unauthorized
{
  "errors": [
    {
      "status": 401,
      "message": "Authentication is required"
    }
  ]
}
[Error] Failed uploading 1 artifacts.
{
  "status": "failure",
  "totals": {
    "success": 0,
    "failure": 1
  }
}

and a non-zero exit code to be issued by the CLI. Currently it returns 0
Versions

JFrog CLI version: 1.38.4
JFrog CLI operating system: Linux amdx64.
Artifactory Version: 6.12.2

JFrog CLI version: 1.39.0
export CI=true

jfrog rt u foo  foo/foo-SNAPSHOT.tgz; echo $?
[Info] [Thread 2] Uploading artifact: foo
[Error] [Thread 2] Artifactory response: 401 Unauthorized

[Error] Failed uploading 1 artifacts.
{
  "status": "failure",
  "totals": {
    "success": 0,
    "failure": 1
  }
}
1

Hi @Cheezykins,
I have tried to reproduce the bug and like @pniederlag had always received a non-zero error code (1).
Do you have more information?

I have reproduced this issue when I had:

JFrog CLI version 2.37.3
export CI=1


Cannot set stickiness on ALB listener rule

If you have an ECS cluster with some fargate services mapped to some target groups, and hand-crank some routing rules in the AWS Console from an ALB Listener to the target groups, you can set stickiness in the rules.
In the listener in the console you will then see "Stickiness" enabled = true, and the duration seconds are displayed.
When creating listener rules from Pulumi AWS C# however, the duration seconds are updated but it doesn't say "Enabled". I've tried setting stickiness both on the TargetGroup and on the listener rule, I've tried both supplying and not supplying a forwards section, and then regardless supplying a Stickiness section on both the ListenerRule and the TargetGroup. In no case is the Stickiness shown as enabled in the Console. What am I missing?
Obviously no error is shown in the pulumi run.

Are you passing Enabled=true in your C# code?
https://www.pulumi.com/docs/reference/pkg/aws/alb/listener/#enabled_csharp

This is why I opened the issue. If there was any connection between the enabled flag, and the flag in the UI I would be clear over how things work.


Invalid reference exception messagesPerField  [in template "error.ftl" at line 82, column 30]

Hello. We are using Keycloakify v5.9.3 and started getting this message. Can u help somehow?

Hello,
It's something that have been fixed in later relases of Keycloakify


Contributing.md

Resolves #39. Adds a basic contributing.md with information about how to get the project on your local machine, how to run the project, the process for proposing new features or reporting bugs, and how to contribute to the projects via PRs.

Made the suggested changes!


test: Add testing of Node.js v12 in Travis pipeline.

Coverage decreased (-0.4%) to 96.114% when pulling 3b993872c21d294380c197fc308a8b53cf76118a on JSMonk:master into 9e0965a55d8d73811277006a3f9893af5c886ffe on paulmillr:master.


--cv failed

Hi there,
I'm trying fastStructure on a relatively small individuals dataset (25) but very large (10000 SNPs from GBS) in .str format.
When I tried to run it with --cv=5, for I thought it would bring the same as running repetitions in the regular Structure, I only get FAILED {1,} to the screen and Structure keeps running.
When I tried the same with the testdata it worked fine.
Running on my data without --cv works also fine but is crazy fast with the simple prior (4 seconds which leaves me wondering...) but with the logistic prior it's much slower (didn't update the log file in an hour...)
Any suggestion?
Thanks,
Nath

Hi Nath,
I run into the exact same problem as you while using fastStructure. I have a dataset with 48 individuals and 800 SNPs in a .str file. When I use the --cv option, I get a "Failed" message and without it only takes 2-3 seconds. Did you ever found out what was the issue?
Thanks,
Laurène

Hi Nath,
I run into the exact same problem as you while using fastStructure. I have a dataset with 48 individuals and 800 SNPs in a .str file. When I use the --cv option, I get a "Failed" message and without it only takes 2-3 seconds. Did you ever find out what was the issue?
Thanks,
Laurène

Hi Laurene,
The --cv option would make the software run slower (e.g., --cv = 5 would make it run 5 times slower, since it runs 5-fold cross-validation and reports ancestry proportions resulting from aggregating these 5 runs).
However, I have not encountered the Failed error message before. Could you please copy-paste or provide a snap shot of the error? If you could share the dataset so I can replicate and fix the error, that would be really helpful!
thanks!

Hi Anil,
Thank you very much for your answer!
Since the software only takes 2 or 3 seconds to run on my dataset (48 ind, 800 SNPs) for each K, it would be no problem if the --cv option would make it run several times slower. My understanding of this option is that it's the number of replicates for each K, correct me if I'm wrong. The runs produce the same results (same output files) when I use the --cv option and when I don't use it, except in the .log file the last line says "CV error = 0.2362436, 0.0097023" and in the terminal it gives me several "Failed" messages:
python ./structure.py -K 2 --input=structure --output=output/test --cv=3 --full --format=str
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Failed
Some people have reported the same problem before but I haven't seen any explanation or solution so far:
https://groups.google.com/forum/#!search/faststructure$20cv/structure-software/cXyfoWXsOe4/Mix0Fo4nDAAJ
I carried out the analysis (without the --cv option), using chooseK.py and distruct.py and the final plot gives meaningful results, which are nearly identical to the results I got from the classic Structure software. Running fastStructure is much faster (which is the all purpose) but I would like to have replicates for each K (like in Structure) which would be then used by chooseK.py to choose the K more reliably.
I attached my input file so that you can have a look at the issue (I had to .zip it since github wouldn't accept a file with .str extension)
structure.str.zip
Thank you very much for your time,
Laurène

Hi Anil (and others),
I encountered the same error today using fastStructure v1.0 and the following command:
python /home/elinck/bin/fastStructure/structure.py -K 2 --input /home/elinck/atlapetes/atlapetes --output /home/elinck/atlapetes/atlapetes_output --format str --cv 3
My .str file is zipped and attached. Curious if you ever figured out what was causing the issue. Thanks in advance!
atlapetes.str.zip

I'm also getting these errors. It looks like it could be from lines 293-305 of fastStructure.pyx? :
`
# test to ensure that for all partitions, the loci are all variant
newmasks = []
for mask in masks:
G = Gtrue.copy()
Gmask = -1*np.ones((N,L), dtype='int8')
Gmask[mask[0],mask[1]] = G[mask[0],mask[1]]
G[mask[0],mask[1]] = 3
if not (((G==1)+(G==2)).sum(0)==0).any():
newmasks.append(mask)
    if not len(newmasks)>=cv:
        wellmasked = False

print "Failed"
`
I do not have any invariant columns in my dataset, and I get the error even if I remove all tri-allelic sites from my input. I'm calling fastStructure as follows:
python fastStructure/structure.py -K 2 --input=inputFile --output=outputFile --cv=5 --format=str
I'm using Ubuntu 14.04.04 LTS, 64 bit.

I can confirm that I no longer get these errors if I convert my data to plink .bed format.

Hi, @atcg ,
I got the same error when I use plink .bed format as input!
 I am running into the same error. I'm using a plink bed file as the input file.


Strip terminal slash from mastodon_base_url

Amazing work on this. When I followed the setup instructions, the url I copied from my browser into .env came as https://mastodon.online/. The terminal slash in the MASTODON_BASE_URL variable led all of the urls returned by get_home_url() to be invalid. This PR adds minimal string sanitation to strip terminal slashes from the mastodon_base_url variable.

++ Makes total sense. I started off using urlparse but didn't want to do much refactoring without having a blueprint of the roadmap. So I just went with the simplest possible solution for this single case.


Add at least one more popular streaming service with TV keyboard

Interestingly, Prime Video seems no longer to support passwords on TV, instead you have to associate a device through a logged in device (by using a code).

Most popular services are supported, therefore closing


Implement remote data section

Wanted
Next to upload binaries and source code directly, it should be possible to hand over a link to a repository/ registry and credentials to private repositories or registries.
Situation
Currently only binaries or source code can be uploaded directly, No credentials can be hand over
Solution
Implement remote data section
Implement a prepare phase with a prepare PDS to download remote data and provide it to the shared storage
Note: shared storage implementation only
{
      "data": {
            "credentials": [
                  {
                        "name": "my-container-registry-account",
                        "user": {
                              "name": "name",
                              "password": "password"
                        }
                  },
                  {
                        "name": "my-cert",
                        "certificate": {
                              "password": "password",
                              "location": "/home/user/certs/mycert.gpg"
                        }
                  }
            ],
            "sources": [
                  {
                        "name": "link-source",
                        "remote": {
                              "type": "git",
                              "credentials": "my-container-registry-account",
                              "location"<EMAIL_ADDRESS>                        }
                  }
            ],
            "binaries": [
                  {
                        "name": "link-binary",
                        "remote": {
                              "type": "docker",
                              "location": "registryLink",
                              "credentials": {
                                    "user": "name",
                                    "password": "password"
                              }
                        }
                  },
                  {
                        "name": "link-binary",
                        "remote": {
                              "type": "docker",
                              "location": "linktoregistry",
                              "credentials": {
                                    "user": "name",
                                    "password": "password"
                              }
                        }
                  },
                  {
                        "name": "firmware-images",
                        "fileSystem": {
                              "folders": [
                                    "gamechanger-firmware/images"
                              ]
                        }
                  }
            ]
      },
      "licenseScan": {
            "uses": ["my-image"]
      },
      "containerScan": {
            "uses": ["my-image"]
      }
}

Shared storage implementation
user --> erstellt nur job-->   job runs (1)-> prepare pds lädt daten remote und speichert in storage ab:
                                           <shared storage>
                                               ^ (2-n)
                                               .... pds1 downloads...
                                               .... pds2 downloads...

see follow up issue #2888 for separated storage implementation

Implemented by PR:

#3046
#3053
#3065
#3131


Simple Cards multiple linebreaks

The SDK doesn't allow simple cards to have multiple linebreaks.  Always only shows a single linebreak.

This is an official documentation that shows how the line breaks work. Please check it first: Creating a Basic Home Card to Display Text .
If it doesn't help, here is an old question in the Alexa Forum. I see some interesting thoughts there: Multiple line breaks in an Alexa "Standard" card are not working.
If this link is not helpful, please tell us in greater details what you do and what you expect.
I do not think this is a bug. The SDK creates JSON objects that Alexa servers process, nothing more.

Closing due to inactivity but please feel free to reopen if this issue persists!


KAFKA-18176: Fix verifiable consumer with unsupported protocol configs

Ensure session timeout is only provided if the CLASSIC protocol is used, as it is not allowed under CONSUMER and makes the consumer creation fail.

Validated the fix with some specific tests.
Before the PR:
OffsetValidationTest/test_consumer_failure/clean_shutdown=True.enable_autocommit=False.metadata_quorum=ISOLATED_KRAFT.use_new_coordinator=True.group_protocol=consumer/1/VerifiableConsumer-0-140207405726800/ducker05/verifiable_consumer.stdout:Exception in thread "main" org.apache.kafka.common.config.ConfigException: session.timeout.ms cannot be set when group.protocol=CONSUMER
After the PR:
test_id: kafkatest.tests.client.consumer_test.OffsetValidationTest.test_consumer_failure.clean_shutdown=True.enable_autocommit=False.metadata_quorum=ISOLATED_KRAFT.use_new_coordinator=True.group_protocol=consumer
status:   PASS
run time:  1 minute 20.783 seconds

Running all consumer tests now and will share results when ready.

@lianetm thanks for this patch, but it is duplicate to #18036

Perfect! no worries, I'll close this one then, thanks!


Consider removing transaction_cache in Sumeragi

          @Erigara says: `i’m not sure that this will work out because we still need cloning because block contain all transactions`

this is a good point, but we have transaction_cache containing duplicates of transactions. It might still be worth to consider using Arc for that reason. On the other hand, I can hardly believe that transaction_cache in sumeragi is making any difference - especially after these changes are merged. We should remove it if possbile
Originally posted by @mversic in https://github.com/hyperledger/iroha/pull/3043#discussion_r1081171813

Cow?
I don't mind the transaction cache, it actually saved us in a couple of situations. Trying to remove it might reveal more undesirable behaviours, so if we can explore this, it'd be nice.
However, the implementation should utilise the redundancy; most transactions are kept in-RAM with no modifications. An Arc is on the right track, but it would be wasting cycles on a non-zero refcount. I personally think that Weak would do just as well if not better.


String and their functions

Description 📜
Hey , i want to create a documentation on strings and their functions in C

Domain of Contribution 📊

[x] C/CPP

/assign

Closing as PR #3205 got merged


localhost site not opening

i want to create a link but whenever  i redirect to site by terminel it is not opening

i have your problem )<:

has anyone found a solution


Add spigot api-version back to fix warning in console

Even though I set the api-version to 1.13 it should still work on 1.8 and higher while also allowing the plugin being loaded by paper.

Thanks! 😅


How to install it and run in Windows?

I have installed PostgreSQL server in Windows.
How to install pg-amqp-bridge and use it?
Thank you.

Ok, it does not work in Windows, need to compile etc. Docker  is the solution.


Simple implementation of trackable resources

Summary
https://github.com/TwiN/k8s-ttl-controller/issues/100
I've decided to go with simple implementation at first and take trackable resources from the environment variable.
Checklist

[X] Tested and/or added tests to validate that the changes work as intended, if applicable.
[X] Updated documentation in README.md, if applicable.

The next step is here.
https://github.com/TwiN/k8s-ttl-controller/issues/105

@TwiN It's ready for review :)


4 out of 8 tests fail with is-descriptor 2.0.0

you don't see that in travis because is-descriptor 2.0 hasn't been pushed to npm registry:
mocha -R spec

  define
    ✓ should define a property and make it non-enumerable:
    ✓ should allow any arbitrary value to be assigned:
    1) should define a property with accessor descriptors:
    2) should define a property on a function
    3) should define a property on an array
    4) should define a property on an error
    ✓ should define a property with data descriptors:
    ✓ should throw an error when invalid args are passed:

  4 passing (20ms)
  4 failing

  1) define
       should define a property with accessor descriptors::

      AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
      + expected - actual

      -bar
      +baz

      at Context.<anonymous> (test.js:40:12)
      at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
      at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
      at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
      at /usr/lib/nodejs/mocha/lib/runner.js:560:12
      at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
      at /usr/lib/nodejs/mocha/lib/runner.js:366:7
      at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
      at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)

  2) define
       should define a property on a function:

      AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
      + expected - actual

      -bar
      +baz

      at Context.<anonymous> (test.js:56:12)
      at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
      at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
      at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
      at /usr/lib/nodejs/mocha/lib/runner.js:560:12
      at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
      at /usr/lib/nodejs/mocha/lib/runner.js:366:7
      at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
      at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)

  3) define
       should define a property on an array:

      AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
      + expected - actual

      -bar
      +baz

      at Context.<anonymous> (test.js:72:12)
      at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
      at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
      at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
      at /usr/lib/nodejs/mocha/lib/runner.js:560:12
      at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
      at /usr/lib/nodejs/mocha/lib/runner.js:366:7
      at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
      at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)

  4) define
       should define a property on an error:

      AssertionError [ERR_ASSERTION]: 'bar' == 'baz'
      + expected - actual

      -bar
      +baz

      at Context.<anonymous> (test.js:88:12)
      at callFn (/usr/lib/nodejs/mocha/lib/runnable.js:354:21)
      at Test.Runnable.run (/usr/lib/nodejs/mocha/lib/runnable.js:346:7)
      at Runner.runTest (/usr/lib/nodejs/mocha/lib/runner.js:442:10)
      at /usr/lib/nodejs/mocha/lib/runner.js:560:12
      at next (/usr/lib/nodejs/mocha/lib/runner.js:356:14)
      at /usr/lib/nodejs/mocha/lib/runner.js:366:7
      at next (/usr/lib/nodejs/mocha/lib/runner.js:290:14)
      at Immediate.<anonymous> (/usr/lib/nodejs/mocha/lib/runner.js:334:5)

you don't see that in travis because is-descriptor 2.0 hasn't been pushed to npm registry:

lol, it seems obvious that is-descriptor 2.0 hasn't been pushed to NPM because tests fail.

Uh... so they put the tag on a known-broken release!?


Make requests modifiable

Related with https://github.com/Laravel-Backpack/CRUD/issues/3783.
Backpack doesn't allow to modify the request on the Request class, because after the validation, the request is discarded.
This PR sends the request to the getStrippedSaveRequest function so it doesn't get discarded.
Since developers may want to modify the request, in order to add "static" fields like the author of a post, with author_id field, this field in not in the crud field list, so $this->getAllFieldNames() will not return it and getStrippedSaveRequest() will strip off that field.
To overcome this, I made getStrippedSaveRequest() not strip crud fields AND model fillable. This way, if author_id is fillable, even if it's not in the crud fields, it

A new inspection was created.

The inspection completed: No new issues

I think we should do this NOW, in 4.2. I especially like the fact that this adds the ability to modify the request in two different but important moments:
A) Before the validation
/**
 * Modify the input values
 *
 * @return void
 */
protected function prepareForValidation() {

    // get the input
    $input = array_map('trim', $this->all());

    // check newsletter
    if (!isset($input['newsletter'])) {
        $input['newsletter'] = false;
    }

    // replace old input with new input
    $this->replace($input);
}

B) After the validation
    /**
     * Get data to be validated from the request.
     *
     * @return array
     */
    public function validationData() {
        return array_merge(
            $this->all(),
            [
                'number' => preg_replace("/[^0-9]/", "", $this->number)
            ]
        );
    }

In addition to that:

it's all functionality that Laravel offers and maintains, not Backpack (we just have to teach people to use it);
it will replace the need to overwrite CrudController::store() and CrudController::update() for 90% of all use cases (I think people that overwrite them only do it to add inputs or remove inputs);
it allows the dev to do the same thing as https://github.com/Laravel-Backpack/CRUD/pull/3928 , but define that custom logic not inside the Model (as a mutator), not inside the CrudController, but inside the FormRequest; it's not as convenient as in the CrudController... but it'll do the same thing (do the processing without modifying the Model);

@pxpm you should take a look at this too, I think this PR is much bigger than it seems.

Hey @pxpm

I think we are opening strippedSaveRequest too much by allowing fillable fields that are not in the request.

Sorry... I don't understand. How does this PR do that? From what I can tell it does one thing - run getStrippedSaveRequest($request)  instead of the normal getStrippedSaveRequest() which basically did getStrippedSaveRequest(request()). The way I see it, if an input is added in FormRequest that does NOT have a field, it will still be taken out by getStrippedSaveRequest($request).
You CAN bypass that, by telling Backpack to not do getStrippedSaveRequest any more, but then again it you could do that before too. If you go out of your way to do your own stripping, we assume you know what you're doing.
Please explain @pxpm - something's off here.

That being said, I did think of a way this could be a breaking change, though. What if the dev has already changed his request, in the controller, in store() or update(), so something like:
public function store() {
    // change the request()
    return $this->traitStore();
}

Wouldn't this PR make Backpack ignore their changes? And prevent people from doing that? What do you think @promatik ?

@tabacitu my concern is about return $request->only(array_merge($this->getAllFieldNames(), $this->model->getFillable()));. Previously it would only use getAllFieldNames because those were specifically added by developer, but now, since it also allow the fillables, if I don't add the field slug to the crud fields, but some malicious actor add the slug in the form via inspector, it would go through and is totally not developer desire. The slug is on fillable to be mass assignable in model, not to allow that specific crud page to interact with it.
That's why I proposed the "shadow fields" that are fields that developer don't want exposed in the form page, but want backpack requests to allow them to go through the saving process. I get that it's not a great idea, but is more to mark a standpoint than a solution for the problem itself.
Let me know if I didn't make myself clear.

OOooohhhhhh. NOW I get it! Thank you @pxpm . I agree with you 100% - I did NOT notice we're using getFillable(), I do NOT agree with allowing those by default. Good catch! 👏👏👏

Regarding my concern about the breaking change this entail, I've tested this and it's true. It IS a breaking change for the people who have changed the request in the Controller - in setup() or store() or update() or wherever else. For example people who have followed these instructions.
For those people, what we'll need to say is:
// if you've done anything like this in your CrudController to manipulate the request
//
use \Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation { store as traitStore; }

public function store()
{
    $this->crud->setOperationSetting('saveAllInputsExcept', ['save_action']);
    $this->crud->getRequest()->request->add(['updated_by' => backpack_user()->id]);

    return $this->traitStore();
}
// that will no longer work, because Backpack no longer saves the Illuminate\Http\Request
// but instead saves the FormRequest you've defined for validation;

// you can do THIS instead, to achieve the same thing from the CrudController
public function store()
{
    $this->crud->set('strippedRequest', function($request) {
        CRUD::getRequest()->request->add([
            'updated_by' => backpack_user()->id,
        ]);
        return CRUD::getRequest()->except(['_save_action', '_token', '_http_referrer']);
    });

    return $this->traitStore();
}

// but what we recommend you do is move that logic to the FormRequest that holds your
// validation too, that way everything that concerns the Request is in one place
// for example in your ProductCrudRequest you could do:

    protected function prepareForValidation()
    {
        // tell Backpack to save the validated inputs (instead of all inputs that have fields)
        \CRUD::set('create.strippedRequest', function ($request) {
            return $request->validated();
        });

        // add something to the request
        $this->request->add(['updated_by' => backpack_user()->id]);
    }

// then make sure inside rules() you have ALL the inputs you want saved, including updated_by;
// for those you want saved but can be null you can use the `nullable` validation rule;

Do you guys think this is too much of a breaking change? Or worth it?

Please reply in https://github.com/Laravel-Backpack/CRUD/pull/3988 - that PR there is the same as this one, but without the fillable thing, and pointing to the refactored branch that has strippedRequest that accepts a closure.


Move SyntaxClassifier to a separate module

The goal of this PR is to move SyntaxClassifier out of the SwiftSyntax module into its own dedicated. I’m not really happy with the PR yet because SyntaxClassifier uses RawSyntax pretty extensively and this requires us to expose more methods from SwiftSyntax as SPI. AFAICT the options here are:

Leave the PR as-is, accepting that SyntaxClassifier requires the use of SPI
Rewrite SyntaxClassifier in terms of Syntax nodes? @rintaro I think you tried this and it wasn’t performant enough, right?
Expose RawSyntax as UnsafeSyntax (or something like that) instead of as SPI
Leave SyntaxClassifier in the SwiftSyntax module

I thought I set up this PR as a base for discussion.
rdar://98318240

I updated the PR to not use SyntaxData. The main thing I had to expose were RawSyntaxTokenView and RawSyntaxLayoutView but that doesn’t seem too bad.
There is a small performance penalty associated with the move (I believe because we can’t do whole module optimization anymore), but I think it’s acceptable (measurements from SyntaxClassifierPerformanceTests):
Release
before: average: 0.045, relative standard deviation: 5.368%, values: [0.050073, 0.046481, 0.049106, 0.044456, 0.043300, 0.043836, 0.043944, 0.046100, 0.043229, 0.042674], performanceMetricID:com.apple.XCTPerformanceMetric_WallClockTime, baselineName: "", baselineAverage: , polarity: prefers smaller, maxPercentRegression: 10.000%, maxPercentRelativeStandardDeviation: 10.000%, maxRegression: 0.100, maxStandardDeviation: 0.100
after:  average: 0.056, relative standard deviation: 6.728%, values: [0.062602, 0.057758, 0.059577, 0.053642, 0.053726, 0.053434, 0.057409, 0.057317, 0.050950, 0.050048], performanceMetricID:com.apple.XCTPerformanceMetric_WallClockTime, baselineName: "", baselineAverage: , polarity: prefers smaller, maxPercentRegression: 10.000%, maxPercentRelativeStandardDeviation: 10.000%, maxRegression: 0.100, maxStandardDeviation: 0.100

Debug
before: average: 2.362, relative standard deviation: 0.646%, values: [2.378401, 2.367227, 2.385291, 2.366417, 2.329441, 2.369335, 2.363841, 2.345538, 2.362924, 2.353043]
after:  average: 2.400, relative standard deviation: 1.438%, values: [2.403036, 2.485006, 2.400218, 2.375242, 2.381436, 2.373605, 2.387524, 2.437035, 2.395524, 2.361710]

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test


Added python centralized sampling design docs

Adding design documentation on behalf of @carolabadeer. To be clear: this document and both associated diagrams were created by @carolabadeer, and I am merely adding them to this open source repository so they are available to the community.
Going forward, we should strive to contribute our design docs to this repo in an open-source manner as often as possible.

@willarmiros Just a tip for future, you can use X-coauthored-by:  to make sure others get credit for a commit when appropriate, for example like https://github.com/prometheus/client_java/pull/671/commits/9bf70cdc2284f975d67963480770ce8cacc27bf5

Thanks for the tip!


Missing required module "minizip"

I installed Zip using carthfile and when I try to build this framework I get information about missing module "minizip". What do I need to do, to use this framework?

1 reproducing the issue

Does it work when you add this to your cartfile ?
github "dexman/Minizip"

(Using swift 2.3, xcode 8) I reproduce the issue with following pod lines :

pod 'Zip', :git => 'https://github.com/marmelroy/Zip.git', :branch => 'swift2.3'
Or
pod 'Zip', '~> 0.4'

@jhanzo Your issue is not Carthage related, I would recommend opening another issue for that.
From what I know is that Swift 2.3 is not officially supported, I would recommend going directly to Swift 3.0 since that is tested and works out of the box

👍  for new issue. Swift 2.3 is a required need since all our pods are not on swift 3 yet :(

Ok let's take this in a new issue and we can see what can be done

Thanks a lot

Does it work when you add this to your cartfile ?
github "dexman/Minizip"

Nope, it still wants minizip module:

/Users/user/Documents/Develop/test.swift:7:8: Missing required module 'minizip'

Try this when build with carthage :
carthage update --use-submodules

Thanks @icaksama.
I updated the Swift 2.3 README file to add the
--use-submodules

Well I had to.. Sorry..
I am getting the "Missing required module 'minizip'" too! So, I tried using the "carthage update --use-submodules" but now I am getting a new problem:

Bahers-Mac:Kansas baherhosni$ carthage update --use-submodules
*** Cloning Zip
*** Checking out Zip at "0.6.0"
A shell task (/usr/bin/env git submodule --quiet init -- Carthage/Checkouts/Zip) failed with exit code 128:
fatal: Not a git repository (or any of the parent directories): .git

Another issue (https://github.com/Carthage/Carthage/issues/407) advised to clean Carthage's repository cache, but that didn't help. I am still stuck with the "Missing required module 'minizip'"
I hope you can help me with this!

What's the contents of Carthage/Checkouts/Zip, just an empty dir ?

I know you tried to clear the cache, but try the following steps:
rm -rf Carthage/Checkouts
rm -rf ~/.carthage/dependencies
rm -rf ~/Library/Caches/org.carthage.CarthageKit
carthage update --use-submodules

The error you're getting is basically saying that git tried to init the submodules git submodule --quite init, but found no repository in Carthage/Checkouts/Zip

That is strange yes, maybe it's related to a Carthage bug ? are you on the latest version of Carthage?

Yes.. Its a fresh install today.. :/

Can we see your Cartfile ?

Ok.. Seems I got around the error! But still didn't test the actual Zipping!  Here is what I had to do:

Disregarded the --use-submodules option
Went with your advise motafabreg about adding minizip in the Cartfile
Finally removed an extra reference in the "Framework Search Paths" under "Release" to "Carthage/Build/Mac" which was somehow causing xcode to produce errors too

We are also facing the same problem. It works in some computer and not in some other computer....
Any suggestions.
Error while importing Zip getting error - "Missing required module 'minizip'"


Bumping version

bumping version to match latest release

Coverage remained the same at 99.535% when pulling a733369d7da26ceead42592e5648555bf7d08b8b on bumping-version into 45f2b86cb6d39b8c9a55517561123b7766891ac1 on master.


Organize the tensorflow repo and clean up

All code for generating the models should be made available publicly on GitHub.
The following requirements should be satisfied:

[x] Add comments where is needed
[x] No local paths  (anyone should be able to run and generate the models)
[x] Save the model in saved_model zip format
[x] When generating the model, we should be able to specify the model version. This model version saves the model in a new version folder. Example: model 1 should be saved in folder /1/

All the files relative to the model creation have been pushed in the model_creation folder

I can run the create_model.ipynb but it does not generate a zip file for me. Am I missing some parameters that should be configured?
Also, this is the scann model? how about the labse and bart?

Try now using the function jobdesc_create_save(). It is a wrapper around the create_save function, but with the Universal Sentence Encoder and the embedding of the extracted job_desc datast.
For now we are using Universal Sentence Encoder because is compatible with tensorflow. For labse and bart we need to find a way to make them compatible with tf as well.
I also pushed the dataset with the the dataset with the keyword extraction for jobdesc and the [embeddings] (https://github.com/UniversalDot/tensorflow/tree/develop/dataset/key_embeddings) of it, that is in tensorflow dataset format, and


IOU - Unable to erase the first digit in BNP and Next button is disabled

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in App with any account
Press green + fab button
Select request money / send money or split bill
Enter the amount and try to delete it

Expected Result:
The amount can be deleted without any problem.
Actual Result:
Unable delete first digit and Next button is disabled in request money / send money /split bill
Workaround:
unknown
Platform:

Where is this issue occurring?

iOS
Android
Mobile Web

Version Number: v1.1.74-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/172696756-280bec49-cedd-41ad-923a-a220ee71718c.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

cc @mdneyazahmad it seems like this must be related to the Localize currency PR which refactored the page a bit as well. What's odd to me is that the production version is fine and the PR which added the blurOnSubmit prop is not causing it either, I tested that.

@mountiny did you try reverting the PR and see if that is really causing it? I tested this during PR review but I will look again to confirm this.

I tried reverting this PR and it does not cause it, even without it the problem occurs.
I havent tried reverting this PR because I confirmed it is not reproducible in production and that one is already in production.

@amyevans and @parasharrajat Double-confirmed that reverting the https://github.com/Expensify/App/pull/9351 does not fix this problem, I played around a bit more and I could not find what directly from the PR which is in production could cause this, but also I cant see anything in the current staging release which would touch this 😬
Further investigation will be needed.

Okay, definitely appreciate the investigation you've done @mountiny! I'm taking a look now as well

I have stopped my VM etc, but the only other PR which is distantly related to this could be this as there are some changes to the BaseTextInput which is used in this problem underneath. I would try to revert that PR locally and test if it prevails.

Great suggestion - reverting https://github.com/Expensify/App/pull/9056 locally does indeed fix the issue. This commit changing the BaseTextInput is the source (cc @luacmartins)

Proposal:
The issue here is that the props passed down to BaseTextInput  is regarded as falsey for an empty string. This causes the second condition to be true since the value of inputValue matches the state value.
https://github.com/Expensify/App/blob/9dfa7e4270b4ad71b14847bc659678c4ec0b4063/src/components/TextInput/BaseTextInput.js#L66-L70
The solution seems to as simple as handling the empty string in the prop value separately.
 componentDidUpdate() {
        // Activate or deactivate the label when value is changed programmatically from outside
        // Only update when value prop is provided
        const inputValue = this.props.value || this.input.value;

        if (_.isEmpty(inputValue) || (this.state.value === inputValue && _.isEmpty(this.props.value))) {
            return;
        }

        if (inputValue === '' || _.isEmpty(this.props.value)) {
            this.input.clear();
        }

        if (_.isEmpty(this.props.value)) {
            this.deactivateLabel();
            // eslint-disable-next-line react/no-did-update-set-state
            this.setState({value: this.props.value});
            return;
        }

        // eslint-disable-next-line react/no-did-update-set-state
        this.setState({value: inputValue});
        this.input.setNativeProps({text: inputValue});

        // In some cases, When the value prop is empty, it is not properly updated on the TextInput due to its uncontrolled nature, thus manually clearing the TextInput.

        if (inputValue) {
            this.activateLabel();
        } else if (!this.state.isFocused) {
            this.deactivateLabel();
        }
    }

Put up a fix here

Sorry @sig5, but we will fix this one internally. Thanks for the interest though!

Fixed, nice work!


Equivalent to pandas' rolling method?

Thank you for this great library, it's much needed when dealing with data. I wonder if there is already something that can be used as an equivalent to dataframe's rolling:
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.rolling.html

Hi there, thanks for making contact. Currently there is no direct equivalent of the rolling method. I would however be happy to take a look at adding it for you.
The pandas method has a number of parameters to achieve slightly different outcomes. Do you have an example of what you are trying to achieve?

Hello,
I think the most important parameter is the window.  Let's use an example of a real world python code calculating stock indicator here:
https://medium.com/geekculture/implementing-the-most-popular-indicator-on-tradingview-using-python-239d579412ab
# moving average
m_avg = df['Close'].rolling(window=length).mean()
# standard deviation
m_std = df['Close'].rolling(window=length).std(ddof=0)

I think this is super useful, we could have something like this:
rolling(window, callback)
With php8 we also have named arguments (https://stitcher.io/blog/php-8-named-arguments), so perhaps in the future we can eventually add more arguments like the python version like min_periods, center, etc....

ok no worries, I'll have a play around and see what I can come up with.

Ok I have a proof of concept for you to try out in a seperate branch. In the spirit of starting off simple, I have created a rolling method within the Vector class. If the functionality suits what you need I can port to both the PackedSequence and the DataFrame class (where I'll see if I can make it work across both columns and rows).
You can grab it with:
composer require sqonk/phext-datakit dev-rolling
Very simple example:
$v = vector(23,45,32,4,55,44,34,34,67,89,55,34);
println($v->rolling(window:2, callback:fn($v) => $v->avg()));
The $minObservations parameters is the same as the min_periods in pandas.
There is also an $exclude parameter. It is supposed to act in an inverse way to closed in pandas, however right now there are discrepancies in the results I have yet to work out. If you set this parameter to 'neither' or empty string (the default) it will exclude nothing, which ends up producing the same results in python if you set closed='right'.
Full method definition for reference (as it's not documented yet):
public function rolling(int $window, callable $callback, int $minObservations = 0, string $exclude = ''): Vector

Just a note that I have redacted the $exclude parameter. If there is a need for something like it in the future we can always re-examine.
Method signature is now: public function rolling(int $window, callable $callback, int $minObservations = 0): Vector
Let me know when you get a chance to test this out and I'll move it across to the DataFrame.

Sorry for the late response, will definitely try it out in the next 1-2 days

Hello, I'm trying this one out (awesome). I wonder if there is a way to know the current loop index/counter. I can certain do something like this:
$v->rolling(window:20, callback:function($v) use (&$counter) {

            $counter ++;

        });

However, if it's already inside the vector that would be nice.

Simple enough to add... The latest commit now supplies the current index / key as the second parameter. From the point of view of the rolling window, this is the index of the starting value.
Callback signature is now:
function(Vector $v, mixed $index): mixed

This is perfect, I think so far it's working well at least for my use case.

ok great, thanks for letting me know. I will organise getting this moved into the other relevant classes within the library and then merge into the main branch.

Thank you again. BTW, do you have any future plans for this library? I feel like PHP is seriously lacking behind Python in term of science/data libraries. Perhaps we can have a roadmap to port useful features from Panda 1 by 1?
I'm not an expert but I will be glad to help if we have a roadmap and a list of to-do things if you want to go that direction.

That's an interesting question. There does appear to be lack of incentive or interest from the community to build up similar libraries for PHP, probably due to its web focused goals.
The irony being that the performance gains it's made in v8+ and some its strengths (like rock-solid database connectors) make it quite versatile in this area.
I originally built it up after discovering the Pandas library and deciding that I could really do with some of the functionality, for an existing web project I have that monitors real-time data for spikes and out-of-spec information. Hence you'll find some methods in the DataFrame class that may not be present in the same fashion in Pandas (e.g. oob(), oob_region() or gaps()).
While I was at it I ported across any other method that was easy enough to make sense of and reproduce reliable predictable results with.
I would be more than happy to receive a list of requests or suggestions to improve it further.
At this stage, what we have is fairly stable so my one key rule is when adding new functions: ideally it has to be to solve an actual problem, whatever problem that is, it doesn't have to be one that I need solving, it could be for you or anyone else :-)  That way it gets tested for real and not just in isolation with a unit test.

Well it's taken me a little while, I had to release some updates across the various libraries in the main branches first..
In any case the rolling() method is now available in the DataFrame class. I have two other classes to contemplate porting it to but they may be a bit trickier.


docs: add badge for graviti community slack link to "README.md"

Pull Request Test Coverage Report for Build 905514351

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.42%

Totals

Change from base Build 905050750:
0.0%

Covered Lines:
4379

Relevant Lines:
5313

💛  - Coveralls

preview here: https://github.com/linjiX/tensorbay-python-sdk/tree/T15845_slack


No language statistics shown for repository

Linguist doesn't show any statistics for my repo
https://github.com/jackharrisonsherlock/common
I've checked the command line but it doesn't return anything either?

Any reason the template disappeared?
Linguist only counts files detected as having a programming and prose language minus any documentation, vendored, or generated file. In your case, readme.md is detected as Markdown, itself classified as prose by Linguist. READMEs are considered documentation though, so it's not displayed in statistics.

@pchaigno too quick for me again 😆
It's also because you've only got one file in your repo that could be considered code and it's not clear to Linguist what language it should be as it's not using anything it could use to even start guessing.
You'll need to either, change the extension to something like .zsh or .sh, add a modeline to the file or a .gitignore override. I've demonstrated adding a modeline in a fork of your repo at https://github.com/lildude/common/ (the magic commit - https://github.com/lildude/common/commit/49077d9f1f74e62d7b696796bdc534662a5ad30f)


Casting of literals is done by Calcite, except for strings

This PR fixes an issue with occurs due to this

Codecov Report

Merging #178 (36ed203) into main (e065161) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #178      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%
===========================================
  Files           57       57
  Lines         2207     2199       -8
  Branches       302      303       +1
===========================================
- Hits          2207     2197      -10
- Misses           0        2       +2

Impacted Files
Coverage Δ

dask_sql/physical/rex/core/call.py
100.00% <100.00%> (ø)

dask_sql/input_utils/hive.py
90.00% <0.00%> (-10.00%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

dask_sql/context.py
100.00% <0.00%> (ø)

dask_sql/server/responses.py
100.00% <0.00%> (ø)

dask_sql/physical/rex/core/over.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e065161...36ed203. Read the comment docs.


Addons Sidebar Sample not working

Hello all,
I might say upfront that I'm new to Java, Spring and Vaadin, so I might as well qualify myself as the douchebag of the month with this question. I wanted to use the addon/sidebar in a project of mine, but using Version 0.0.6.RELEASE will give me a 500 upon browsing the page and, apart from other output in the exception, this:
No qualifying bean of type [org.vaadin.spring.sidebar.SideBar] found for dependency

The sample in the repo uses 0.0.7-SNAPSHOT. But adding that to my pom.xml will end up with the IDE being unable to resolve org.vaadin.spring.sidebar.SideBar. And I don't have a .pom or .jar for that version in my maven repository. Only for the 0.0.6.RELEASE.
I assume that I need to use a newer version of the sidebar when using injection. If so, then the question would be, where do I get it, when using Maven?
Regards,
Phil

I'll have a look next week when I get back from my vacation. It is quite likely something is broken there.

Thanks.  Might as well just be me who's broken. Like, if you add the @EnableSideBar annotation to the spring application, things change. There's another error following that one up, but that might be again something that I'm missing out on.

Minor Update bevor I'm off into the weekend myself:
Error creating bean with name 'org.vaadin.spring.sidebar.config.SideBarConfiguration': Injection of autowired dependencies failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: org.vaadin.spring.i18n.I18N org.vaadin.spring.sidebar.config.SideBarConfiguration.i18n;

Is what I get now. Not yet sure if missing a dependency, missing another annotation or if this is finally related to the different versions (with the annotation mentioned above added, I was able to get rid of that error).

It seems to work on my machine. Did you do a priming build of the project before running the demo?

Hello,
thanks for getting back to this. Like I said, I'm fairly new to all that and honestly, I don't get the difference between a build and a priming build in relation to the IDE (IntelliJ) I use. I just said build the thing and it failed. So I cleaned the copy of this repo, cloned it again, imported the sample again and e voilà!: this time it worked. Sorry about that one.
That'll just bring me back to my own project using the sidebar and that injection error that I get. I hope that information didn't get lost, this Could not autowire field: org.vaadin.spring.i18n.I18N error is what I get on my own project when I try to run it (even after clean and compile, the later works without error).

Have you tried adding @EnableI18N to  your application configuration?

Also please have a look at the feature/sidebar_refac branch that I just created. The side bar will be slightly refactored to support multiple implementations of the visual component. The branch contains the old accordion based side bar and a new side bar especially designed for the Valo theme. The design is not quite stable yet, though - there are a few ugly things I'd like to iron out before pushing to master.

I've added the annotation and now it works.
Regarding the new branch, that sounds really good, as the Valo theme is the theme I'm currently using/ want to use with the app.

My redesign is now complete and pushed to the master branch. Take a look at the sample application for the Side Bar and especially the ValoSideBarUI (after starting up the app, navigate to http://localhost:8080/valo).

Closing the ticket since the demo app is now working.


chore: Move error from saga to action creator

Description
Improve error reporting for missing page id
Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test


Synchronization is slow

Hello, I'm working on an add-in but when I modify something on the manifest I see that the sync is too slow, also if I delete it it remains visible on outlook for hours and hours how can I force the sync?

Hi @koukouza,
Thanks for reaching out. Have you tried clearing the Office cache? That should make sure the most recent version of the manifest is uploaded.

Hi @AlexJerabek.
Thank you for your prompt response. I have also tried your suggestion, but the synchronization is still slow. In addition, changes are sometimes visible on Outlook Web but not yet on Outlook Desktop, where they are neither modified nor synchronized. I don't understand the reason for these considerable delays, which can extend over several hours before the changes are perceptible.

Thanks @koukouza. I'm going to transfer this issue to the office-js repo. There, members of the Outlook extensibility team can investigate the issue.


Add Morphis Wallet to wallet standard list

@ChiuMungZitAlexander Verified and it looks good! The PR needs to be rebased (the readme moved), but I'll merge it after that!

@ChiuMungZitAlexander Verified and it looks good! The PR needs to be rebased (the readme moved), but I'll merge it after that!

Cheers! It seems there're conflicts. Should I open a new PR?


"Error checking upgrade" status for stack.

Server version - v0.44.0-rc2
I had created a stack with older template version - v0.1.3 of "Route53 DNS"
I have deleted this service now.
UI  shows "Error checking upgrade" status for stack.

That message just means the API returned an error when the UI asked for the upgrade info.. in this case probably because we renamed the template


Fix crash when playing Tween right after finishing

Fixes #65891
This is fun edge case. The Tween normally gets initialized before the while loop, but if you restart it right after finished signal, it will be running again mid-loop and bypass the initialization logic. This caused it to access step outside of the defined animation., because the value wasn't reset.

Thanks!

Cherry-picked for 3.6.

Cherry-picked for 3.5.1.


Breakup dependencies, e.g. with Configuration

Currently Options depends on Configuration because of the serviceCollection.Configure(configuration) overload.
This means that any package that indirectly depend on Options also depend on Configuration, e.g. Entity Framework 7 depends on Caching which depends on Options which depends on Configuration, therefore even if we made the explicit decision not to couple Entity Framework with Configuration, the dependency exists and is carried even to places where it isn't commonly used, e.g. desktop .NET or Windows UAP applications.
The dependency could be broken by splitting the parts of options that depend from configuration (e.g. serviceCollection.Configure(configuration) and its implementation class ConfigureFromConfigurationOptions`) into their own package.
Optionally, moving that package in its own repo would help breakup the chain of build dependencies for our CI.

Moving Config + Options into Options.ConfigurationExtensions

Should we put that in a new repo to break the build dependency? cc @Eilon

Can we put all of these in one repo instead?

Possibly, if we can bring enough of the graph of dependencies together to avoid cycles. We should try.

Options depends on DI and Config basically.  Config doesn't depend on DI.

Options should build pretty low in the stack, is there a ci build issue?

The issue is that CI is slower than we want it to be, and one way we can improve that is to break dependency chains among repos, e.g. so that any time something changes on any given repo that doesn't trigger as many rebuilds.

So we want to move the Configuration dependency outside of the Options repo?  The problem is that Options depends on DI too, so we can't put it into Configuration.

That is why I suggested a new repo. There is a obviously a balance between the overhead of maintaining yet another repo vs. the potential benefit breaking this particular chain. Others may have more context to evaluate that.

ec13249a35bbf1d4a8a381a9697965cc1208fe82 Options.ConfigurationExtensions

I am using the DotNetCore.1.0.0-VS2015Tools.Preview2.exe with Visual Studio Update 3. I am unable to migrate code to read settings in the appsettings.json file from an MVC6 app. It uses the @inject Microsoft.Extensions.OptionsModel.IOptions Settings syntax in a razor file to read the configuration.
The only version of Microsoft.Extensions.OptionsModel.IOptions available is rc1, whereas the Microsoft.Extensions.Options.ConfigurationExtensions version is rc2.
Therefore  I am getting the 'ambiguous call' error referred to in a related .net github issue:
Error	CS0121	The call is ambiguous between the following methods or properties:
Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure and Microsoft.Extensions.DependencyInjection.OptionsConfigurationServiceCollectionExtensions.Configure
Of course, all of this is part of the worst release mess I've ever seen in msland. But is there any solution for this particular bit of madness?
Thanks,
Kimball Johnson

leaving out the Microsoft.Extensions.OptionsModel.Options part I get this further error:
Could not load type 'Microsoft.Extensions.DependencyInjection.ServiceCollectionExtensions' from assembly 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.

Whenever you get errors like this you should do a dependency scan to make sure you're not mixing versions of things. If you upgraded your project from an rc1, make a new project and copy the assets over. RC2 -> RTM is more straight forward and there's a guide.


🐛 Fix declaration of zAdd() for phpredis 5.2.1 of ClientCluster

@B-Galati thank you, I still don't understand why this wasn't done in previous PR.

Not a big deal.


Add docx how to run react client for this micro-service architecture

Before doing this, I am working on some reach, whether is it possible to create and private IP address and assign it to KC. So that, we can remove dependency on lt.

After gh-364, its very simple to run react client.


Pin requests to <2.30.0,>=2.18.0 or urllib3<2

The requests library released 2.30.0 this morning, which supports urllib3 2.0. urllib3 2.0 breaks a ton of external dependencies (specifically in my case, botocore from AWS). All of my GCF deployments that have downstream dependencies on urllib3 are now failing.
Potential solution: as mentioned in the release, pin urllib3<2.0 or pin requests to <2.30.0.

My mistake, realized I misread the docs and the requirements auto-installed as part of the builder. Closing.


CLI equivalent page?

Great page, very thorough. We need a similar page walking through each scenario using the CLI. Current CLI documentation is very thin in comparison.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e50dfe50-c177-f976-753b-9fa689d20f92
Version Independent ID: 7f787259-8ce5-9ba6-8df7-58ab0b89dd5c
Content: Deploy and manage backups for Resource Manager-deployed VMs using PowerShell
Content Source: articles/backup/backup-azure-vms-automation.md
Service: backup
GitHub Login: @markgalioto
Microsoft Alias: markgal

This isn't feedback on this article. #please-close

@rayne-wiselman How can we track the need to create an equivalent page for CLI ?

@rayne-wiselman if required, please open an issue to create an equivalent page for CLI and assign it to me.

@rayne-wiselman @pvrk Hi, do you want me to close this issue,  and if you have done can you please share the ticket to create an equivalent page for CLI? Thanks!

Yes,you can close this issue. @jtuliani  - please open a bug to create this article.


Add setup instructions for Linux and Windows

Currently, the build prerequisites guide only contains instructions for macOS.
Help is wanted for setup docs for Windows and Linux environments. Do use this issue to discuss any related issues encountered.

docker.


CRUD issues

I have a problem with CRUD generator. When I generated the model, autocomplete worked fine and offered me all the tables from DB. When I wanted to generate CRUD model, autocomplete didn't offer me previous generated model.
Autocomplete works fine on my other projects.
Thank you for your help.

it is very hard to find all existing classes so I do not think it is feasable to provide such a feature.

@cebe , this has worked as expected on some my previous projects. Is this disabled?

I doubt that, we do not have auto completion for class names.

@milosbarlov most probably it was your browser.

In order to implement it we need to scan all the project files finding ones that are ActiveRecord. For a large project it sounds like a bit too much.

@samdark  @cebe Thanks for your help

@samdark can you close this issue?

Done.


Support multiple packages in the same repo

Closes #55
Updates package_dir inputs to package_dirs: A single or multi-line input for listing multiple paths to packages, if so desired.
This updates the create-api-reference-docs pre-commit hook and associated workflows.
Also - it reverts to not use the experimental Python parser (griffe) for mkdocstrings.

Codecov Report

Merging #58 (657136a) into main (e9addb8) will increase coverage by 0.19%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   50.39%   50.58%   +0.19%
==========================================
  Files           3        3
  Lines         256      255       -1
==========================================
  Hits          129      129
+ Misses        127      126       -1

Impacted Files
Coverage Δ

ci_cd/tasks.py
50.60% <57.89%> (+0.20%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


chore: reuse annotations.IsExternallyManagedReplicas for not setting replicas of machine pools by default to 1

I think this is a good change, not sure if its worth cutting a new release for.


Cannot read property 'split' of null

This might be related to #459
index.js
module.exports = function () {
    return Promise.resolve('foo');
};

test.js
import test from 'ava';
import m from './';

test(t => {
    t.throws(m(), 'foo');
});

Current: TypeError: Cannot read property 'split' of null
Expected: Missing expected exception (or something like that)

It seems to be an error in stack-utils. It fails on https://github.com/sindresorhus/ava/blob/master/lib/beautify-stack.js#L13 at this piece of code
stackUtils.clean(stack).split


Support swift 1.2

Support swift 1.2. Test in Xcode 6.3 beta 4

@MengTo: We should get this PR or @eneko's merged, since 1.2 is out of beta :smile:

@Jasdev +1