add subset method in randomization library

example:
var arr = [1,2,3,4,5,6];

var sub = jsPsych.randomization.subset(arr, 3);

// sub is [3,2,5] or other random 3 element combination of arr

replacing this concept with a sample method instead, which can accomplish exactly the same thing, but also allows for sampling with replacement.


Set Nyx fallen stars to fill in several recipes in place of glowstone for early-game requirements such as ThaumCraft nitor

Pay particular attention to TC, as the discipline calls for several nether components very early that cannot be provided and must have substitutions available

let's use unidict to dictify these items as replacements for glowstone


Document consensus rules from Zcash spec: Section 3.7 Action Transfers and their Descriptions

For each consensus rule:

check that the rule is implemented in Zebra
make sure the latest version of the rule is quoted in the docs for the code that implements it
make sure the code implements the latest version of the rule

Implementation

This was implemented in #1864 (PR: #1885)

Already done


fairseq-train: error: unrecognized arguments: --tpu

🐛 Bug

When I am running fairseq-train to train a Roberta base model (https://github.com/pytorch/fairseq/blob/master/examples/roberta/README.pretraining.md#1-preprocess-the-data), on cloud TPU using --tpu option it, I get this error.
To Reproduce
run this as shell script
script.sh is

TOTAL_UPDATES=125000    # Total number of training steps
WARMUP_UPDATES=10000    # Warmup the learning rate over this many updates
PEAK_LR=0.0005          # Peak learning rate, adjust as needed
TOKENS_PER_SAMPLE=512   # Max sequence length
MAX_POSITIONS=512       # Num. positional embeddings (usually same as above)
MAX_SENTENCES=16        # Number of sequences per batch (batch size)
UPDATE_FREQ=64          # Increase the batch size 16x
MKL_THREADING_LAYER=GNU
DATA_DIR=data-bin/wikitext-103
fairseq-train $DATA_DIR \
    --task masked_lm --criterion masked_lm \
    --arch roberta_base --sample-break-mode complete --tokens-per-sample $TOKENS_PER_SAMPLE \
    --optimizer adam --adam-betas '(0.9,0.98)' --adam-eps 1e-6 --clip-norm 0.0 \
    --lr-scheduler polynomial_decay --lr $PEAK_LR --warmup-updates $WARMUP_UPDATES --total-num-update $TOTAL_UPDATES \
    --dropout 0.1 --attention-dropout 0.1 --weight-decay 0.01 \
    --max-sentences $MAX_SENTENCES --update-freq $UPDATE_FREQ \
    --max-update $TOTAL_UPDATES --log-format simple --log-interval 1 \
    --valid-subset=valid \
    --train-subset=train \
    --save-dir=${HOME}/checkpoints \
    --max-epoch=1 \
    --num-workers 16 \
    --tpu \
    --skip-invalid-size-inputs-valid-test

Steps to reproduce the behavior (always include the command you ran):

Run cmd
$ sh ./script.sh

See error

fairseq-train: error: unrecognized arguments: --tpu
fairseq documentation - https://fairseq.readthedocs.io/en/latest/command_line_tools.html?highlight=train#fairseq-train clearly lists out --tpu as an option/argument for fairseq-train
Code sample

Expected behavior

Environment

fairseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0)
OS (e.g., Linux):
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context

Did you clone the latest fairseq source (master) or are you using the pip release (0.9.0)? TPU support is only available on master currently.

@myleott I have used the pip release - that explains. I will revisit this once again with the master version. Thank you for checking into this.


Language support

I want to use this custom speech and pronunciation platform, but my language (a local language) is not included here. What do i do?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4de08d1f-8114-7bef-7ef4-022f79c69742
Version Independent ID: 4c0ceab9-24ed-de01-db30-31acf1de0f48
Content: Language support - Speech Service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/language-support.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @erhopf
Microsoft Alias: erhopf

@temitopefunmi
Thanks for the feedback! We are currently investigating and will update you shortly.

@temitopefunmi Hi, do you mean your language is not supported for now? If yes, I would highly recommend you posting your feedback to User Voice Forum. https://cognitive.uservoice.com/ Product group will review every feedback and update the product accordingly.

Okay. Thank you


Same Team-Same Position

Is there a way to exclude players from the same team/position from the same lineup? For instance, I don't want both Melvin Gordon and Austin Ekeler as my RB's this week. Also applies to the NE RB's, I only ever just want one of them.

This is a low-probability scenario and probably doesn't merit its own constraint. My recommendation is to just generate additional lineups and then filter for this condition in your code.
want_number_of_lineups = 20
lineups = []

while len(lineups) < want_number_of_lineups:
    for lineup in optimizer.optimize(1, randomize=True):
        # pseudocode
        if count of position from same team > threshold:
            pass
        lineups.append(lineup)

I've added this feature in new release, it's example of using new rule: optimizer.restrict_positions_for_same_team(('RB', 'RB'))


Think I've done something wrong (AttributeError: 'module' object has no attribute etc)

Think I've done something wrong here I am getting an error for all the methods on the unicorn library.
Expected: LEDs to turn on etc
Actual:
AttributeError: 'module' object has no attribute 'set_pixel'
AttributeError: 'module' object has no attribute 'show'
pi@dac:~/unicorn-hat/python/examples $ sudo pip2 install --upgrade unicornhat
Requirement already up-to-date: unicornhat in /usr/local/lib/python2.7/dist-packages/unicornhat-2.1.0-py2.7.egg
Requirement already up-to-date: rpi-ws281x>=2.0.0 in /usr/local/lib/python2.7/dist-packages/rpi_ws281x-2.0.1-py2.7-linux-armv6l.egg (from unicornhat)
Cleaning up...
pi@dac:~/unicorn-hat/python/examples $ sudo python2
Python 2.7.9 (default, Mar  8 2015, 00:52:26)
[GCC 4.9.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import unicornhat as uh
>>> uh.show()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'show'
>>>

Few more:
pi@dac:~/unicorn-hat/python/examples $ python2 clock.py
Traceback (most recent call last):
  File "clock.py", line 33, in <module>
    unicorn.rotation(0)
AttributeError: 'module' object has no attribute 'rotation'
pi@dac:~/unicorn-hat/python/examples $ python2 simple.py
Traceback (most recent call last):
  File "simple.py", line 8, in <module>
    UH.set_pixel(x,y,255,0,255)
AttributeError: 'module' object has no attribute 'set_pixel'
pi@dac:~/unicorn-hat/python/examples $ python2 snow.py
Traceback (most recent call last):
  File "snow.py", line 12, in <module>
    unicorn.brightness(0.4)
AttributeError: 'module' object has no attribute 'brightness'
pi@dac:~/unicorn-hat/python/examples $

Remove + install fixed.


Updating dependencies

Updating all dependencies to consolidate troubleshooting

Update this from main and let's see if that fixes this build!!  If it passes merge the pr and close older prs we don't need that are covered Here!

Passes all checks!


Improvement

Could be nice to have a function like this
    /**
     * Handle a result
     *
     * @param $key
     * @param callable $onSuccess
     * @param callable|null $onError
     *
     * @return mixed
     */
    public function getOrElse($key, callable $onSuccess, callable $onError = null)
    {
        if ($this->containsKey($key)) {
            return $onSuccess($key, $this->get($key));
        }

        return $onError($key);
    }

I think I am good for that one, @nozavroni might find a better name :)


Ability to retrieve the protocol response headers in InferenceClient

As per title, it would be helpful to be able to retrieve the header as is possible with curl --include.
Example of a useful response header:
(base) felix@azure-amd-mi300-dev-01:~$ curl <IP_ADDRESS>:80/generate -X POST -d '{"inputs":"Today I am in Paris and","parameters":{"max_new_tokens": 3, "details": true}}' -H 'Content-Type: application/json' --include
HTTP/1.1 200 OK
content-type: application/json
x-compute-type: gpu+optimized
x-compute-time: 0.111191439
x-compute-characters: 23
x-total-time: 111
x-validation-time: 0
x-queue-time: 0
x-inference-time: 110
x-time-per-token: 36
x-prompt-tokens: 7
x-generated-tokens: 3
content-length: 318
access-control-allow-origin: *
vary: origin
vary: access-control-request-method
vary: access-control-request-headers
date: Tue, 14 May 2024 12:57:59 GMT

Hi @fxmarty, thanks for the feature request. Any suggestion on how this information should/could be returned in the current InferenceClient framework? Open to suggestions on that.

@Wauplin the feature enabled by this is tracking of the response time from TGI from the client.
With stats like
x-compute-type: gpu+optimized
x-compute-time: 0.111191439
x-compute-characters: 23
x-total-time: 111
x-validation-time: 0
x-queue-time: 0
x-inference-time: 110
x-time-per-token: 36
x-prompt-tokens: 7
x-generated-tokens: 3

For example, in https://huggingface.co/spaces/fxmarty/tgi-mi300-demo-chat/blob/main/app.py, I wanted to use client.text_generation and give these stats to the user as well, but I couldn't unless using the rest API myself. Note that TGI does not give theses stats in the generate_stream endpoint.

@fxmarty thanks for the explanation! Any suggestion on how you would like this information to be returned in the current InferenceClient framework?


Struct fix

I added some missing fields from the Repository endpoint and included them in the Component struct to save having to make 2 calls.

Hi @l0cs 👋
Thanks for the PR! But is the repositoryMeta field actually returned by the API? I just tested with a local DT instance, and the field is not present in responses to the /api/v1/component/<UUID> request.
The field is also transient and thus should not be serialized at all: https://github.com/DependencyTrack/dependency-track/blob/master/src/main/java/org/dependencytrack/model/Component.java#L330


allow adding lambda functions as an extension

This PR allows adding a lambda function as an extension,
resulting in simpler coding for simple extensions such as printing some values for debugging.
Example usage:
...
trainer.extend(lambda x: print(model.accuracy.data), trigger=(1, "iteration"))
...

Thanks for your PR!
isinstance(extension, types.FunctionType) is not enough for checking whether it is a lambda. A function that is wrapped by make_extension also has types.FunctionType. It is possible that it has a non-None finalize attribute, but this PR would overwrite it with None.
Currently, extensions are expected to have name (or default_name) and finalize attributes, which is the reason it doesn't accept lambda. Instead of checking whether it is lambda or not, I suggest loosening the requirements by handling the case when it doesn't have such attributes:

When extension doesn't have name nor default_name, then it is possible to check whether it has __name__ and use it if yes, otherwise raise an error.
entry.extension.finalize can be replaced with getattr(entry.extension, 'finalize', None)

By doing so, it can accept not only lambda but also any arbitrary callable object whose argument is Trainer.
In addition, this PR will affect the definition of Extension in Chainer, which is written in the docstring of Extension class: https://github.com/pfnet/chainer/blob/master/chainer/training/extension.py. Could you modify it accordingly?

Thank you for the comments and suggestions.
I modified the code and the docstring in according to your comments. The docstring is bit confusing because if you add a lambda (or any callable that do not inherit Exntesion class), is is never fired unless you explicitly specify the trigger argument in the extend method.
It might be a good idea to change get_trigger function in training/util.py so that it returns (1, 'epoch') if trigger is None, but I didn't do it as it may break other constrains.

Extension's docstring in training/extension.py contains more detailed explanation on how to define custom extensions. Could you modify it too?
As you wrote, modifying get_trigger would affect the behavior of existing code that explicitly set the trigger attribute to None. How about getattr(extension, 'trigger', None) -> getattr(extension, 'trigger', (1, 'iteration')) in https://github.com/pfnet/chainer/pull/1930/files#diff-768d99d739390d9a9a936299d6fa7fceR216 instead? It would not affect the existing code since extensions that inherit Extension or use make_extension must have the trigger attribute.

Added fixes (docstring, trigger) as suggested and also added tests for lambda-based and callable class-based extensions.

Thanks for the detailed review.
I changed the docstring of extension.py as suggested, and for trainer.py I wrote:
If it is ``None`` and the extension does not have the trigger attribute
instead of:
If the extension does not have the trigger attribute
because checking if an extension has the trigger attribute or not is done only when the trigger parameter given to extend is None.
        if trigger is None:
            trigger = getattr(extension, 'trigger', (1, 'iteration'))
        trigger = trigger_module.get_trigger(trigger)

@delta2323 @muupan Thank you for the very detailed check and suggestions. I added two commits and replied to all the reviews on by one, please check them out.

LGTM.
@delta2323 Can you review the changes?

LGTM


Consistent failure on Amplify CI/CD pipeline.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
19
Amplify CLI Version
9.2.1
What operating system are you using?
MAC
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Describe the bug
This happens very often in Amplify CI/CD pipeline.
An error occurred when creating the CloudFormation stack
2023-03-21T13:23:05.150Z [INFO]: 🛑 Stack [amplify-XXXXXXX-62609] already exists
2023-03-21T13:23:05.150Z [INFO]: Resolution: Please report this issue at https://github.com/aws-amplify/amplify-cli/issues and include the project identifier from: 'amplify diagnose --send-report'
Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/
[INFO]: Session Identifier: 39d3ef24-fd44-460a-8b4e-489d8eb4854b
2023-03-21T12:24:43.410Z [WARNING]: - Creating Zip
2023-03-21T12:24:43.466Z [INFO]:
2023-03-21T12:24:43.466Z [INFO]: ✅ Report saved: /tmp/RingApp/report-1679401483417.zip
2023-03-21T12:24:43.466Z [WARNING]: - Sending zip
2023-03-21T12:24:44.972Z [WARNING]: ✔ Done
2023-03-21T12:24:44.972Z [INFO]: Project Identifier: 2706ed17bffa2b5bd75102381f6c922d
we have been running into this same errors consistently
Expected behavior
CI/CD should work in a new ENV
Reproduction steps

we have a repo with all amplify related resource.
We have initial Amplify Dev ENV, where CI/CD works,.
3 . clone the repo, add a new Amplify ENV, push, set up CI/CD pipeline from Amplify console with a git repo branch.
The initial build works from #3.
Make code changes, push to dev branch, dev branch builds fine.
Merge the changes into the newly created ENV from #3, the build fails with:

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @bwang-movano :wave: thanks for raising this! What sort of changes were made prior to receiving this? I attempted to make a frontend change and merge to no avail.

I got this figured out, this i think should be document somewhere.
It turned out that team-provider-info.json is very important for CICD to work in different ENV.
If a amplify ENV is connected to a branch, and  team-provider-info.json in that branch does not have its own env entry, then amplify (cloudformation) attempts to create a root stack with the same name, because it was created at the time the ENV is created.
Only if the ENV entry exists in  team-provider-info.json, cloudformation only updates it, instead of create it.
This should be documented somewhere I think, who would think that  team-provider-info.json is significant to CICD pipeline, most just think it is non-essential to build and run time, only developer collaboration.
You can close this issue.
Thanks.

Hey @bwang-movano glad to hear you are up and running despite the experience. I've made a note to improve our documentation around this subject, but will close this for now


Add  licensing

Add MIT licensing and double check during VC about type of License

@BenjaminDecaillet
Also double-check dependencies license.
Perhaps this can help: https://github.com/raimon49/pip-licenses

#56


Saving initial model

By saving the initial model without the suffix, there is at least one model that can be loaded within the obvisitor.
Then, when a better model is found it will simply be overwritten and removed at during clean up.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.17%. Comparing base (a5f0f07) to head (c9242cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   95.25%   95.17%   -0.08%
==========================================
  Files         130      130
  Lines        5163     5164       +1
==========================================
- Hits         4918     4915       -3
- Misses        245      249       +4

Flag
Coverage Δ

unittests
95.17% <100.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(internal) release_patch: build v5.5.535

Test plan: automated release PR, CI will perform additional checks

:green_circle: Internal release is ready for promotion!
:warning: Do not close/merge the pull request or delete the associated branch if you intend to promote it.


fix price

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 22.562%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/polovniauto/client.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
664

Relevant Lines:
2943

💛  - Coveralls


Uncaught ReferenceError: require is not defined

Hi,
I am getting this error when trying to convert an Excel file.
I am certainly missing something and I am quite unexperienced on the matter.
Could you please help ?
Thank you !

@drexel75,
The good news is that this is not an 'excel-as-json' problem - you don't have to wait for me to fix something.
The bad news is that you are going to have to learn a little and rethink your strategy. Your fastest solution is to google the error phrase you used as an issue title, see stackoverflow, etc. E.g. https://stackoverflow.com/questions/19059580/client-on-node-uncaught-referenceerror-require-is-not-defined


ThreadJob bricks and never finishes (ThreadState stays Running) when creating a new instance of a Powershell class or interacting of with one

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
In PowerShell if I for example define two classes like this :
class CustomTestReturn{
	[string] $Text

	CustomTestReturn([string] $Text){
		$this.Text = $Text
	}
}

class TestObject{

	[CustomTestReturn] $CustomTestReturn

	[string] ReturnString(){
		return "test"
	}
	[char] ReturnChar(){
		return 'c'
	}
	[int] ReturnInt(){
		return 159
	}
	[Double] ReturnDouble(){
		return 159.45
	}
	[System.Collections.ArrayList] ReturnDotnetType(){
		return [System.Collections.ArrayList]::new()
	}
	[CustomTestReturn] ReturnCustomTestReturn(){
		return [CustomTestReturn]::new("this bricks the job!")
	}
	[void] InteractObject(){
		$this.CustomTestReturn.Text = "This bricks the job"
	}
}

and interact with them in a new ThreadJob that I create through
$in = [TestObject]::new()
$job = Start-ThreadJob -ScriptBlock {$input.InteractObject()} -InputObject $in
$job | Wait-Job -Timeout 10
$output = $job | Receive-Job -Wait

$job = Start-ThreadJob -ScriptBlock {$input.ReturnCustomTestReturn()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

I get some undefined behavior. When the ThreadJob calls TestObject.ReturnCustomTestReturn() or TestObject.InteractObject() the ThreadJob stays in the "Running" State forever and never finishes or fails. This is especially problematic if I then call Receive-Job -Wait as it locks up the entire script and in my case on Windows makes the shell not even respond to CTRL + C  with no way to get back the prompt.
This behavior however only happens with objects which are instances of classes that are defined in Powershell, if I do the same thing with other objects that directly come from .NET it all works fine as shown in the ReturnDotnetType method.
$job = Start-ThreadJob -ScriptBlock {$input.ReturnDotnetType()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

This example will print "was null" which also doesn't seem right but at least the thread finishes as expected.
Full script :
class CustomTestReturn{
	[string] $Text

	CustomTestReturn([string] $Text){
		$this.Text = $Text
	}
}

class TestObject{

	[CustomTestReturn] $CustomTestReturn

	[string] ReturnString(){
		return "test"
	}
	[char] ReturnChar(){
		return 'c'
	}
	[int] ReturnInt(){
		return 159
	}
	[Double] ReturnDouble(){
		return 159.45
	}
	[System.Collections.ArrayList] ReturnDotnetType(){
		return [System.Collections.ArrayList]::new()
	}
	[CustomTestReturn] ReturnCustomTestReturn(){
		return [CustomTestReturn]::new("this bricks Powershell!")
	}
	[void] InteractObject(){
		$this.CustomTestReturn.Text = "This bricks powershell"
	}
}

$in = [TestObject]::new()

$job = Start-ThreadJob -ScriptBlock {[System.Collections.ArrayList]::new()}
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnString()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnChar()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnInt()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnDouble()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnDotnetType()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.ReturnCustomTestReturn()} -InputObject $in
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

$job = Start-ThreadJob -ScriptBlock {$input.InteractObject()} -InputObject $in
$job | Wait-Job -Timeout 10
$output = $job | Receive-Job -Wait
Write-Host ($null -eq $output ? "was null" : $output)

Expected behavior
with the example above I would either expect the ThreadJob to either correctly execute the code from the method or at least give an error and stop the ThreadJob instead of staying in a Running state

Actual behavior
Thread stays forever in a Running state and never finishes

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.5
PSEdition                      Core
GitCommitId                    7.4.5
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Known limitation with PS classes. Use NoRunspaceAffinity attribute to work around it: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_classes?view=powershell-7.4#norunspaceaffinity-attribute


SyntaxError: An identifier or keyword cannot immediately follow a numeric literal

Environment
Knex version: 0.95.11
Database + version: MySQL (5.7.12-log Amazon RDS)
OS: Mac OS Big Sur 11.2.1
tag @lorefnon as this is in regards to the typescript types
Bug

Explain what kind of behaviour you are getting and how you think it should do

We are not able to generate types for columns that start with a number.

Error message

SyntaxError: An identifier or keyword cannot immediately follow a numeric literal. (370:2)
  368 | ,
  369 | /**  Defaults to: 0. */
> 370 | 3dsecure: number
      |  ^
  371 | ,system_installed: number
  372 | ,
  373 | /**  Defaults to: 0. */
    at t (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/parser-typescript.js:1:285)
    at Object.parse (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/parser-typescript.js:14:180461)
    at Object.parse (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:9739:19)
    at coreFormat (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:13252:23)
    at format (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:13510:73)
    at formatWithCursor (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:13526:12)
    at /Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:44207:15
    at Object.format (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/node_modules/prettier/index.js:44226:12)
    at pretty (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/dist/src/index.js:11:31)
    at Object.inferTable (/Users/rpitt-mbp/.npm/_npx/29042/lib/node_modules/mysql-schema-ts/dist/src/index.js:36:12) {
  loc: { start: { line: 370, column: 2 } },
  codeFrame: '  368 | ,\n' +
    '  369 | /**  Defaults to: 0. */\n' +
    '> 370 | 3dsecure: number\n' +
    '      |  ^\n' +
    '  371 | ,system_installed: number\n' +
    '  372 | ,\n' +
    '  373 | /**  Defaults to: 0. */'
}

Questions about how to use knex
GitHub issues are for knex development. Please send questions how to use knex to
Stack Overflow or ask about it in gitter chat.

Doesn't look like it's related to knex? When declaring object literals in JavaScript (and interface/object literal members in TypeScript) you have to surround the member name in quotes.
example

Closing as this doesn't seem like a knex problem.


Adds confirmation modal to delete button on admin user profile

The security checks is from rails and not on our part. We can still pull and push for right now and let backend deal with the security check.


panic: unexpected status 400 Bad Request from log server

je@https:~/ct-submit-master$ ./ct-submit-master ct.googleapis.com/pilot <../https.pem >https.sct
panic: unexpected status 400 Bad Request from log server
goroutine 1 [running]:
runtime.panic(0x605b80, 0xc210233e90)
/usr/lib/go/src/pkg/runtime/panic.c:266 +0xb6
main.main()
/home/je/ct-submit-master/ct-submit.go:153 +0x4f5
goroutine 4 [syscall]:
runtime.goexit()
/usr/lib/go/src/pkg/runtime/proc.c:1394
goroutine 5 [chan receive]:
net/http.(*persistConn).readLoop(0xc210060380)
/usr/lib/go/src/pkg/net/http/transport.go:778 +0x68f
created by net/http.(*Transport).dialConn
/usr/lib/go/src/pkg/net/http/transport.go:528 +0x607
goroutine 6 [select]:
net/http.(*persistConn).writeLoop(0xc210060380)
/usr/lib/go/src/pkg/net/http/transport.go:791 +0x271
created by net/http.(*Transport).dialConn
/usr/lib/go/src/pkg/net/http/transport.go:529 +0x61e

Can you upload the https.pem file that you're trying to submit? Will be helpful to diagnose the issue.

I've just pushed e4d71c7 which will print the error message returned by the log server. I suspect there's probably a problem with the certificate chain you are trying to submit (e.g. not in the correct order, missing intermediate certificates or a root that's not accepted by Google's log server).

Thanks for the update! The certificate needs an intermediate certificate and thats probably why it fails:
unexpected status 400 Bad Request from log server:
{
"error_message": "Root certificate is not trusted.",
"success": false
}

Okay, closing this as I'm assuming adding the intermediate(s) to the chain in the correct order will work (feel free to re-open if not). It's not a goal of this program to create the chain automatically (as it'd be quite complicated!) nginx requires the intermediates/leaf to be present and in the correct order as well anyway.


task watchdog crash/asset on NRF52840 - need to reorder task_wdt_feed() in task_wdt_add()

Describe the bug
On the NRF52840 (and likely other NRF variants),  the CPU will hardfault when calling
task_wdt_add()
The underlying issue is documented here:
https://devzone.nordicsemi.com/f/nordic-q-a/75112/assertion-fail-m_cb-p_instance--drv_inst_idx-state-nrfx_drv_state_powered_0
The fix is simple.  Move task_wdt_feed(id); after    the wdt_setup call like this:
int task_wdt_add(uint32_t reload_period, task_wdt_callback_t callback,
		 void *user_data)
{
	if (reload_period == 0) {
		return -EINVAL;
	}

	/* look for unused channel (reload_period set to 0) */
	for (int id = 0; id < ARRAY_SIZE(channels); id++) {
		if (channels[id].reload_period == 0) {
			channels[id].reload_period = reload_period;
			channels[id].user_data = user_data;
			channels[id].timeout_abs_ticks = K_TICKS_FOREVER;
			channels[id].callback = callback;

#ifdef CONFIG_TASK_WDT_HW_FALLBACK
			if (!hw_wdt_started && hw_wdt_dev) {
				/* also start fallback hw wdt */
				wdt_setup(hw_wdt_dev,
					WDT_OPT_PAUSE_HALTED_BY_DBG);
				hw_wdt_started = true;
			}
#endif

task_wdt_feed(id);

			return id;
		}
	}

	return -ENOMEM;
}

To Reproduce
Run the sample in samples/subsys/task_wdt  with the nrf52840dk_nrf52840 board.
Expected behavior
When the call is made to task_wdt_feed, the CPU will hardfault.   I believe there is an asset being triggered.
Impact
Annoying.    For the time being, I will be manually patching but this should be in the main zephyr tree.
Environment (please complete the following information):

OS: Windows
Toolchain GCC Arm embedded
Cf19ebe4b50

Definitely good to post the bug here. I was not aware of the discussion in the Nordic Devzone, otherwise the fix would have made it into 2.7 release.

I was able to reproduce the issue. See linked PR with the fix.


Relaxed NUMA avoids the bus

The "preferred" policy is like "bind", but not strict.  Otherwise
an attempt to allocate too much memory will silently kill the
process with a SIGBUS.
Allows large (>40M-entry) binding tables (#1067).

Related: https://github.com/snabbco/snabb/issues/1346


GSLB_Monitor - Add Additional Monitor Types

While working to convert a configuration to AS3, I came across some additional GSLB Monitors that are not exposed in the current schema. Could the following monitors be added in a future release please:
mysql
sip
ldap
smtp
Thank you.

Thanks for reaching out, I have added to our backlog as AUTOTOOL-4414


Feature: Stream impl for Dequeue

Implementing Iterator/Stream gives a lot of convenience, it would expand a lot of ergonomics to implement Stream on Dequeue.

@khionu Thanks! I now implemented a Dequeue::into_stream1 method that transforms a Dequeue<T, ()> (so without a continuation) into a futures::Stream of T.
An implementation for a Dequeue with a continuation would be possible, but I'm not sure about the design yet. I see two possible designs:

Have dequeue.into_stream(|recv_cont: Recv<S>| ...) pass the continuation via the provided Recv. It needs to be provided into a closure to maintain deadlock prevention.
Make dequeue.into_stream() produce a Stream of a sum type of either a T or an S. Unfortunately, there is no standard "either" type in Rust, so it would have to be a custom sum type.

I'm leaning towards the first option, what do you think?

I'm not sure how the first would function without reducing ergonomics? It wouldn't be able to be consumed within the iterator chain or loop blocks because you wouldn't be able to enforce a break of the loop.
A custom Either is a very common approach, and given the nature of Par I think it would be very appropriate for it to have one.

That's true, thanks!
The first approach introduces a scope separation where it's not appropriate.
I'll implement the second approach.

Implemented: https://docs.rs/par/0.3.9/par/queue/struct.Dequeue.html#method.into_stream
@khionu Let me know if anything is missing, or if this issue is now resolved!


Merge search landing

Merges develop (which now includes search landing PR), and moves Russ's logic/refactors into the new search/utils.ts file.

Coverage increased (+0.4%) to 32.139% when pulling b4a6336fcc16a2402bbfb3a00bb74f640649e78f on Jskobos:merge-search-landing into cc7fd7a1babf0cbc01af40746bd2bb501054ea88 on linode:feature/M3-1405-volume-tags.


Support reading from replicas on pipeline executions

This is the smallest possible change that should still satisfy https://github.com/Grokzen/redis-py-cluster/issues/400
I've been testing it with our own client code and it seems to work as expected.
Something to note about this implementation is that it won't necessarily stick to the same replica for all read operations within the same shard. There are two reasons for this:

changing this behaviour would complicate the implementation and probably require making the connection pools pipeline-aware somehow as well, or provide a custom connection pool for this use case.
I actually think the behaviour as implemented is preferable as it will distribute the load across replicas, which is the original goal of this change anyway.

@FranGM This looks awesome and a much smaller change to get the feature out quicker. Please just dig into it and really confirm it without a doubt that commands is sent out to the replica nodes and i will take this for a run myself and i hope i can get a minor release out within this work week as this should be much faster to verify and get out :)

I can do better than that actually :) I have it running in production right now. Here's a graph showing CPU usage on primary and its three replicas before and after the change

Good enough for me :) I aim for this weekend at the latest to go through it and get out 2.1.3 with this included

@FranGM Tested it out locally and i also wrote a example script for the readonly pipeline part that i will commit up after this merge to make it more easily testable for anyone who want to try it out.


Toolbar refactoring  dialog buttons

@romanblanco @PanSpagetka
Refactored dialog_button toolbar button classes and specs. Could not find the dialog_res_discard and dialog_resource_remove buttons in UI. Could you help me out with that one?

Checked the code, looks good;
Tested in UI, works well.
👍
@martinpovolny

@miq-bot assign @martinpovolny


GPSPRINGSECURITYCORE-244:   beforeDelete  on User not working from 2.0-RC1

Original Reporter: xmlking
Environment: Grails 2.3.1 Hibernate 4
Version: Grails-Spring-Security-Core 2.0
Migrated From: http://jira.grails.org/browse/GPSPRINGSECURITYCORE-244
I had following method in User class which was working fine before v2.0-RC1
def beforeDelete(){
   UserRole.removeAll(this)
}

with v2.0-RC1, when  I try to delete user [cascaded delete from Tenant class which has may users] I am getting following error!
No row with the given identifier exists: [com.xyz.User#7]. Stacktrace follows:
Message: No row with the given identifier exists: [com.xyz.User#7]
    Line | Method
->>   51 | doCall                   in com.xyz.UserRole$_removeAll_closure3

Created a sample app that couldn't reproduce the problem:
https://github.com/Schlogen/testSSC237

@Schlogen thank you very much. It doesn't reproduce indeed.


Correction for raw affiliation Aeres University of Applied Sciences, Dronten, The Netherlands; Wageningen University, Wageningen, Netherlands

Correction needed for raw affiliation Aeres University of Applied Sciences, Dronten, The Netherlands; Wageningen University, Wageningen, Netherlands
raw_affiliation_name: Aeres University of Applied Sciences, Dronten, The Netherlands; Wageningen University, Wageningen, Netherlands
new_rors: 04qw24q55;03jnx2c74
previous_rors: 04qw24q55;015d5s513
works_examples: W4319073287
contact: 1d2e36a45a37f797b58932bdbe45c195:a026e06d09d0f86477e3 @ hotmail.com

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Fixed a bug in the related links.

For some reason all links in the cmdlets start with ( and end with ), throwing off the linking of the website.
This PR fixes that.

I'm sorry I forgot to mention that. We do that because it is suggested by the xmldoc2cmdletdoc tool we use. I am a little concerned that this could replace an intentional parenthesis. Does javascript have a TrimStart and TrimEnd?

(it was powershell so yes)

LGTM


[firebase_auth] Invalid Token - Bug appears when creating duplicate apps with different Bundle ID's

Describe the bug
Okay, so I had developed an app (programmed in flutter) using the firebase_auth dart package, and that app is working perfectly fine, no issues.
The issue arrises when I try to duplicate the app for a second Bundle ID. (Think same client, different end-user customer-base). Every single time I boot up the app, authentication doesn't even let me enter in a phone number, just giving me an "Invalid Token" error.
flutter: Phone Auth Verification Failed: Invalid token.
To Reproduce
Steps to reproduce the behavior:
I do start with a perfectly clear, clean copy of the app, that I have run on multiple devices, and it works. I then replace the Bundle ID, download the new google-services.plist from Firebase (That has the correct Bundle ID and other information), (replacing the original, and making sure to include it in the runner directory through XCode, so the program knows), and replace the pertinent details such as the url in the info.plist, and the API Key in the AppDelegate.swift.
I've ensured that the Bundle ID I'm trying to develop on is covered via the Apple Provisioning Profiles in my Apple Developer Account.
Expected behavior
I should be able to create a copy of the app, under a new Bundle ID, and have it work exactly as the original.
Additional context
I've cleaned the build folder, updated to newer versions and various branches, but I keep getting stymied at this point in the project. I've looked through all of the similar problems in your archives, but none of the advice or suggestions anyone has given has been able to help me.
This app does have Push Notifications active, and requires them to work.
Again, to be clear, without changing ANY code, I have a fully function variant of the app. But when changing to a new version of the Bundle ID, I get this error.
Flutter doctor
Run flutter doctor and paste the output below:

[✓] Flutter (Channel master, 1.21.0-10.0.pre.70, on Mac OS X 10.15.6 19G73, locale en-CA)

    • Flutter version 1.21.0-10.0.pre.70 at /Users/iosdev/Developer/flutter

    • Framework revision 0629030a05 (12 hours ago), 2020-08-13 00:01:03 -0400

    • Engine revision 7571e7c380

    • Dart version 2.10.0 (build 2.10.0-11.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)

    • Android SDK at /Users/iosdev/Library/Android/sdk

    • Platform android-29, build-tools 29.0.2

    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java

    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)

    • Xcode at /Applications/Xcode.app/Contents/Developer

    • Xcode 11.6, Build version 11E708

    • CocoaPods version 1.9.3

[✓] Android Studio (version 3.5)

    • Android Studio at /Applications/Android Studio.app/Contents

    • Flutter plugin version 42.1.1

    • Dart plugin version 191.8593

    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.47.3)

    • VS Code at /Applications/Visual Studio Code.app/Contents

    • Flutter extension version 3.13.2

[✓] Connected device (1 available)

    • Phillip’s iPhone (mobile) • ce2e8494b57ead1f7c37d1c18b8f6b22e797f5e4 • ios • iOS 13.5.1

    ! Error: Phillip’s iPhone is not connected. Xcode will continue when Phillip’s iPhone is connected. (code -13)

• No issues found!

Hi @PhilBelanger42
You can't have different ID for same configuration, you need to new app for new different bundle ID and then google services plist and put int new project and you can use same authentication and database from this job and app bundle should be matched with firebase app bundle. if you're changing bundle id for your app, you can reuse existing plist. Correct me if i am mistaken

Can you please provide your flutter run --verbose and a complete reproducible minimal code sample
Thank you

@TahaTesser Thanks for your response, however I think I must not have done a sufficiently thorough job explaining exactly what I have done to resolve this.  I will attempt to elaborate.
So yes, I'm aware that this should be treated a completely separate app.  It has it's own firebase project, it's own google-services.plist, it's own API-Key (for certain functions) and others.  As far as I know though, I HAVE changed all of those things.  The list as follows:
As Push Notifications are required, I created a new Provisioning Profile from this helpful guide
https://firebase.google.com/docs/cloud-messaging/ios/certs
Created and registered a new App in Firebase Console, that has the new Bundle ID, and associated info, and downloaded it.
Removed the previous Google-Services.plist (and all references to it), and only then included the new file in the project.
Changed the bundle-id in the actual info.plist in XCode 11.
So in Essence, the ONLY thing that should have anything to do with the previous app, is the base code itself, and how it functions.  (At least as far as I'm aware.  If I'm wrong, PLEASE let me know!)
A minimal-reproducible sample may not be possible, but I will definitely attempt to do so over the next few days.
as for flutter-doctor --verbose, I will paste here.
[✓] Flutter (Channel master, 1.21.0-10.0.pre.70, on Mac OS X 10.15.6 19G73, locale en-CA)
• Flutter version 1.21.0-10.0.pre.70 at /Users/iosdev/Developer/flutter
• Framework revision 0629030a05 (6 days ago), 2020-08-13 00:01:03 -0400
• Engine revision 7571e7c380
• Dart version 2.10.0 (build 2.10.0-11.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/iosdev/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.6, Build version 11E708
• CocoaPods version 1.9.3
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.47.3)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.13.2
[✓] Connected device (1 available)
• Phillip’s iPhone (mobile) • ce2e8494b57ead1f7c37d1c18b8f6b22e797f5e4 • ios • iOS 13.5.1
! Error: Phillip’s iPhone is not connected. Xcode will continue when Phillip’s iPhone is connected. (code -13)
• No issues found!
Hopefully this helps you to identify any possible area of issue!

Discovered the error, it wasn't code.  There was information missing from the Firebase Console, which I had not been made aware of.  The code itself works fine.


Updates POD section in workload get output same as Kubectl get

Pull request

What this PR does / why we need it
PR will display the POD details same as that of kubectl get pod output command results.
Which issue(s) this PR fixes

Fixes #224
Describe testing done for PR

Unit test cases added, also updated existing test cases to reflect the POD details output.

Tested in local cluster.
Additional information or special notes for your reviewer

closing this PR since a new PR 292 has been created for the same with the latest code. All the review comments are also being taken care as part of the new PR.


'test.aria.widgets.form.autocomplete.errorhandling.AutoComplete2' fails on all IE

A synchronization issue make the test fail;
@fbasso could explain more in detail

This is the simple scenario to reproduce the issue :

In an autocomplete with freeText set to false, start typing a value in order to open some suggestions,
Without selecting any value in the dropdown list, click outside the autocomplete,
The autocomplete is expected to be in error, which is not the case on IE.

The issue come from :

On aria.widgets.form.TextInput._dom_onblur , the checkValue is run only if this._keepFocus is false,
this._keepFocus is set to false in aria.widgets.form.DropDownTrait_afterDropdownClose,
aria.popups.Popup.closeOnMouseClick run the close method, which will finally run afterDropdownClose.

The issue is that in IE, the close method is run asynchronously (to manage some other issues), which means that _dom_onblur is run before setting back _keepFocus to false.


Empty event

I can't seem to find a way to react to an empty result, no event is triggered specifically on empty, and I can't find anything in autocompelete:shown to hint me of that. Is there something I'm missing?
I'm trying alternative empty approaches like changing input color, icon, etc.

Correct, I'll add an event; it makes a lot of sense.

We added a "clear" event in places

We added a "clear" event in places

Yes definitely something we'll also need to backport.

Yes definitely something we'll also need to backport.

But empty and clear are the same right?

But empty and clear are the same right?

Nope, empty is when the underlying datasets are not returning any results. On the other hand clear is when you press the right cross, right?

ohhh, tricky difference. Yes clear is when the query is emptyied, empty is when the datasets are returning no results.
Not sure we want to name it empty in the case of an empty dataset, it's very close to the "empty query" case no?

Not sure we want to name it empty in the case of an empty dataset, it's very close to the "empty query" case no?

Hmmm, I think it's OK because it fits the empty wording we're already using for templates.


RFM - LINE

https://chocolatey.org/packages/line/<IP_ADDRESS>0

I'd like to become a new maintainer of this package.

Update pushed: https://chocolatey.org/packages/line


Use signed coordinates for mouse events

This PR changes mouse click/toggle/doubleclick coordinate calculation to signed version. Previously it was unsigned, which caused click events to register at incorrect positions, if the click happened at a negative coordinate value, which can happen in macOS's screen coordinate system.

I tested this out and it works great!  Thanks!


Update huggingface-hub to 0.24.6

Update huggingface-hub to 0.24.6.
Related to:

#3037

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


need a symmetric rank-4 tensor class

Elasticity tensor typically has major and minor symmetries. We will need a class that leverage this symmetry property.

All functions in SymmTensor4_3D.hpp have been completed in corresponding SymmTensor4_3D.cpp file.

All functions in SymmTensor4_3D.hpp have been completed in SymmTensor4_3D.cpp, and sorry for touching the ‘closed with comment' button by mistake.

Here are six functions which have been updated  in SymmTensor4_3D.cpp, including:
void add_OutProduct( const double &val, const SymmMatrix_3x3 &mmat );

void add_SymmOutProduct( const double &val, const Vector_3 &vec1,  const Vector_3 &vec2);

void add_SymmProduct( const double &val, const SymmMatrix_3x3 &mleft, const SymmMatrix_3x3 &mright );

void add_SymmOutProduct( const double &val, const SymmMatrix_3x3 &mleft, const SymmMatrix_3x3 &mright );

int Voigt_notation( const int &ii, const int &jj, const int &kk, const int &ll ) const;

int Voigt_notation( const int &ii, const int &jj ) const;

Here are four functions which have been updated in SymmTensor4_3D.cpp, including:
double& operator()(const int &index) {return ten[index];}

const double& operator()(const int &index) const {return ten[index];}

void gen_Ptilde( const SymmMatrix_3x3 &invC );

void TenPMult( const Tensor4_3D &P );


Wonderful Survey! And about Related Work

Hi, thank you for sharing this wonderful survey! It is very detailed and enlightening. Do you have any plans about incorporating the following works:

CrossGET: Cross-Guided Ensemble of Tokens for Accelerating Vision-Language Transformers. arXiv 2023. To be appeared in ICML 2024.
UPop: Unified and Progressive Pruning for Compressing Vision-Language Transformers. ICML 2023.

, which are related to the topic of efficient VLMs.

By the way, it seems the paper link in README is incorrect:
https://github.com/lijiannuist/Efficient-Multimodal-LLMs-Survey/blob/39a58098ddac53ecacc4fc53e8b549fc1a8ffa3b/README.md?plain=1#L3
, the arXiv url given here is incomplete.

Hi, thank you for sharing this wonderful survey! It is very detailed and enlightening. Do you have any plans about incorporating the following works:

CrossGET: Cross-Guided Ensemble of Tokens for Accelerating Vision-Language Transformers. arXiv 2023. To be appeared in ICML 2024.
UPop: Unified and Progressive Pruning for Compressing Vision-Language Transformers. ICML 2023.

, which are related to the topic of efficient VLMs.

Great works, We will include these papers in next version.

By the way, it seems the paper link in README is incorrect:
https://github.com/lijiannuist/Efficient-Multimodal-LLMs-Survey/blob/39a58098ddac53ecacc4fc53e8b549fc1a8ffa3b/README.md?plain=1#L3
, the arXiv url given here is incomplete.

Thank you for your reminder


Replaced search for .kytos files with .vue

Closes #issue_number
Summary
Since we are moving from utilizing the httpvueloader to now using the vue3-sfc-loader, we must now change the napp ui file extension from .kytos to .vue. This is because the vue3-sfc-loader only works on .vue files.
Local Tests
End-to-End Tests

@viniarck I had tried to search for a method within the documentation but couldn't find anything. I can take another look, try and search for other methods, or maybe we can try and modify SFC directly if the license allows for it.


Friend codes

Xbox
Wii or fan replacement
Steam
Playstation
Good luck

Tables

Friend codes

Blocked users users

Friends- shares with them if 1 is hidden and isn't personal or basically just me.

Maybe friend config table?


for agents API, provider data from the header is not parsed as for ag…

…ents there is no provider_data_validator meta-reference implementation. Added Together data validator as the provider_data_validator for now. Did some code changes accordingly.
Tested it by running local instance of the llama-stack and running multi-turn agent for vision models.

@yogishbaliga See #148


HMP2012: posterior fornix samples are incorrectly tagged as oral cavity

Hello,
posterior_fornix samples in the HMP_2012 are incorrectly tagged as 'oralcavity' whereas they should be as 'vagina'.
Could you fix this?

Thanks! Yes we were aware of this. It will be fixed in the next release.

This issue was moved to waldronlab/curatedMetagenomicDataCuration#30

This issue was fixed in curatedMetagenomicDataCuration long ago (
https://github.com/waldronlab/curatedMetagenomicDataCuration/commit/696ba151ac32fade02991e9a90cd4adaa6ecb200#diff-e0958d8bf3447badde33d65a9959bd7c) and consequently in the pData and man pages here, but the error remains in combined_metadata here, so the issue belongs here and not on the curation site.

Hi all,
Any idea when this issue can also be resolver in the combined_metadata? I am using that file as the start of my analysis and it would be great if this could be fixed so that I can remove my manual pruning.
Thanks!

@schifferl do you know why this bug persisted through the April release update? Should I just fix it manually?

Hello all, I am not sure how the bug persisted through the April release update but I will take a look at it today and give you an update. Thanks, Lucas.

@swuyts will you have another look at your analysis and see that you have an updated version of cMD? I have just checked the GitHub and BioC versions (release 1.14.1 and devel 1.15.1) – all posterior_fornix samples list their body_site as vagina. If you find something please let me know, otherwise we are ready to close this issue. (FYI @lwaldron)

Thank you for digging into this.
I had updated all my BioC packages and thought that would do it. But it seems I was still running curatedMetagenomicData 1.12.3 as I am using R 3.5.1. I therefore needed to update R to 3.6, reinstall all packages and only then I was able to upgrade to the current version of curatedMetagenomicData.
My apologies, this was completely my fault as the package was not up to date due to an older R version. I think you can indeed close this issue.
Thank you for the great work!
Sander


Update context app naming for document type

Updating the context app naming "Seo Settings" to "SEO" to keep it in line with the context app for the content section.

Fixed by https://github.com/patrickdemooij9/uSeoToolkit.Umbraco/commit/4971565f5340581d6464693fdd14ae9921fe72ea


Extensions are not grouped under a folder

Bug Description:
The file structure is not following 'theia' or 'lerna' defaults where additional packages are consolidated
under a 'packages' folder.
So the top level project may continue to grow as extension get added which is not desirable as multiple projects may
extend a non optimal structure.

Steps to Reproduce:

Open theia-blueprint repository in a file system and observe that the two existing extensions are under the top level project
i.e. 'theia-blueprint-product' and 'theia-blueprint-updater'

Additional Information
I will submit a PR shortly after submitting this issue.

Operating System:
Theia Version:

@alvsan09 its a known optimization that @marechal-p and I talked about previously to re-organize the repo and also add linting #82. I believe that @marechal-p already did some reorganization in preparation for #74.

@alvsan09 its a known optimization that @marechal-p and I talked about previously to re-organize the repo and also add linting #82. I believe that @marechal-p already did some reorganization in preparation for #74.

Ok, I have closed my intended PR to take Paul's PR #88 instead.


Fix io time yaxe

The upstream has be updated and fixed kubernetes-monitoring/kubernetes-mixin#235 , so the new generated manifests should be good, but in case that someone will use the generated manifests directly, I guess it would be better to update the manifests?

Hmmm, will fix the test, hold on.

Tests passed, commits squashed, should be good to go.

Thanks! lgtm


Write unit-tests for AccountService, UserService methods in db_service.py

Description:

Create unit tests for AccountService and UserService classes in /app/services/db_service.py.

TODO:

[ ] Install pytest as the testing framework.
[ ] Create a separate /tests directory inside project root.
Follow the same project structure as in the /app directory to create tests:

/app/
--/models
--/services
...
/tests/
--/models
--/services
...

[ ] Write tests for functions of UserService, AccountService.
[ ] Execute and validate test cases.

Hi,
I can try contributing towards the test cases to help you.

Hi, I can try contributing towards the test cases to help you.

Yes @sahild91, you can go ahead.

Fork this repository to your GitHub.
Create a separate branch & write test cases in it.
After you have done, push it to your forked repository.
Finally, make a pull request to this repo from your branch.

@th4ruka ,
I have added the test cases and created a pull request. Please review it once and let me know if you need any changes on it.
https://github.com/CeyLabs-Foundation/fin-tracker-backend/pull/6


Service Principal Authentication No Longer Works

Hi,
Following the FAQ here: https://github.com/Azure/app-service-linux-docs/blob/master/service_principal_auth_acr.md
No longer works; the Web App only seems to be able to pull from ACR when using the Admin user, not a Service Principal with AcrPull access. Should the docs be updated / is this a bug?

@yiliaomsft

I verified it on my ACR images and it does work with the service principal auth. If you still see the issue, please open a support ticket so we can take a look.

I filed a ticket with support; would you like the ticket number to follow up?

That will be good to have the ticket#.

Sure, the case number is<PHONE_NUMBER>02439

Issue resolved; looks like it was a template issue


uprobes: make C++ symbol demangling explicit

Introduce a new part of uprobe specification which allows to explicitly enable language-specific features. For now, C++ prefixes (:c++ and :cpp) are supported. Specifying one of these turns on symbol demangling which is now disabled by default.
Some examples of the current behaviour
# cat cpptest.cpp
extern "C" int fun() { return 1; }
void fun(int x) {}
void function() {}
class Foo { void fun() {} };
class Bar { void fun() {} };

# nm cpptest
0000000000401126 T fun
0000000000401148 T _Z3funi
0000000000401131 T _Z8functionv
0000000000401184 W _ZN3Bar3funEv
0000000000401178 W _ZN3Foo3funEv

#
bpftrace -e 'u:./cpptest:fun { exit(); }'
Attaching 1 probe...    (C "fun" only)

bpftrace -e  'u:./cpptest:c++:fun { exit(); }
Attaching 3 probes...   ("fun", "fun(int)", "function")

bpftrace -e 'u:./cpptest:c++"fun(int)" { exit(); }'
Attaching 1 probe...    ("fun(int)")

bpftrace -e 'u:./cpptest:c++:*fun { exit(); }'
Attaching 5 probes...   (all the functions)

bpftrace -e 'u:./cpptest:c++:"*::fun" { exit(); }'
Attaching 2 probes...   ("Foo::fun" and "Bar::fun")

While this is not perfect (e.g. the second example should not match function), it's better than what it was before (see #2186). I'd prefer using this as a starting point and then following with more PRs rather than doing everything at once.
Missing features include:

more sophisticated matching of mangled symbols (i.e. fix the above 2nd example)
better support for namespaces (e.g. support ::fun)
support for demangling in probe listing

Note that this is a breaking change b/c demangling is not done by default now. However, since it was never documented and it sometimes had incorrect and unexpected behaviour, I believe that this is the correct step forward.
Resolves #2186.
Checklist

[x] Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
[x] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

overall LGTM, definitely a breaking change as you said (but that seems fine in this case). Have you looked into how much work it would be to fix the 2nd example? That's the only missing thing I think would be worth including in this PR if the fix is not a large patch.

Have you looked into how much work it would be to fix the 2nd example? That's the only missing thing I think would be worth including in this PR if the fix is not a large patch.

For this particular case, it's as simple as adding an extra ( to the end of the query. There are other cases, though, that'll require more thinking. Let me have a look, if we manage to review and merge this in the meantime, I'll send the fix as a follow-up PR ASAP.

Have you looked into how much work it would be to fix the 2nd example? That's the only missing thing I think would be worth including in this PR if the fix is not a large patch.

For this particular case, it's as simple as adding an extra ( to the end of the query. There are other cases, though, that'll require more thinking. Let me have a look, if we manage to review and merge this in the meantime, I'll send the fix as a follow-up PR ASAP.

It turned out not to be too complicated to fix the bugs that I know of, so I updated this PR (see 17beb2c).


Post release automated changes for storage releases

Post release automated changes for azure-storage-file-share

API change check
API changes are not detected in this pull request.

/check-enforcer override


Arbitrary json through messages is broken

Problem

Thanks to issues between proc-macros, serde, and bincode, you can't push "flattened" json through agent state messages which is pretty important for asynchronous work in workers.
#[derive(Serialize, Deserialize, Default)]
struct jsonblob{
    field: String

    #[serde(flatten, Default)]
    custom: serde_json::Value
}

use yew::agent::{Packed};

#[test]
fn test() {
    let msg = jsonblob::default();
    msg.pack();
}

thread 'test_bincode' panicked at 'can't serialize an agent message: SequenceMustHaveLength', src/lib.rs:15:9
We can just convert to &str, but that takes a while and is another serialization step which isn't great for big messages. Is this something we should try to fix or do the benefits outweigh the negatives?

Thanks for the report, looks like this is just an issue with not being able to use Struct flattening with bincode: https://github.com/servo/bincode/issues/245

Closing due to this not being a Yew bug


:latest tag missing

(ins)[hendry@t14s v]$ docker run --rm -tiv `pwd`:/go ericwq057/golangide
Unable to find image 'ericwq057/golangide:latest' locally
docker: Error response from daemon: manifest for ericwq057/golangide:latest not found: manifest unknown: manifest unknown.
See 'docker run --help'.

Would help in its usability.
Btw % docker pull docker push ericwq057/golangide:v0.4.3 looks like a typo to me.

let see how to fix it.

done.


Audio Chat

Is your feature request related to a problem? Please describe.
Audio chat feature for users to communicate efficiently.

Assign 🍕

I can collab on this issue with @joshi008


[BUG]Warning Message About Custom Result Index on Production Clusters Despite Existing Indices

What is the bug?
I am getting a warning message about the detectors we have created on a production clusters.  The message warns that the results index for the detector is custom, and is not present on the cluster, and will be recreated when real time or historical detection is started for the detector.  However, real time detection has already been started for these detectors.  Also, I checked, the result index exists.
How can one reproduce the bug?
Cx can consistently reproduce the bug. I only succeeded once when creating a detector when a cluster just starts.
What is the expected behavior?
The message should not show. From https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/blob/main/public/pages/DetectorDetail/containers/DetectorDetail.tsx#L136-L140, there can be a race condition when the statement finishes before cat indices call finishes. We should check if cat indices call finished or not before saying the index does not exist.

Was this fixed in #759 @kaituo? Can it be closed?
Catch All Triage - 1 2 3 4 5 6

yes, fixed.


Animation only happen until i keep pressed

Great library,
I was trying/exploring this library but what I found that in  animate(animation) works only when I keep it pressed,
if I just press and move my finger away then animation stops in between and goes back (on Android).
Is there any way to complete the animation even if finger is removed ?

I'm not sure I get what you're saying. Is this about MotiPressable? Could you make a simple Expo snack demonstrating?

Yeah, i forgot to mention i was saying about MotiPressable.
Here is the snack for demonstration :
https://snack.expo.dev/@siddharth-tyagi/moti-pressable

I see, that’s interesting.
Looking at your code, the behavior is correct. It’s stateful.
You’re telling it to do one thing when it’s pressed, and that’s what it’s doing. When it’s no longer pressed, then it changes the style. I’m not sure what else could be expected.
So what you’re looking for is essentially a way to time a given animation based on the press event: not style based on the current pressed state…

Yeah, i mean when i pressed(single click), then the animations should start and get completed till end.
Currently For animation to complete we need to keep the white box pressed.

Okay here's what I think you should do. There's a hook called useMotiPressableTransition, which lets you set the transition (and thus the delay) based on the interaction state.
Snack: https://snack.expo.dev/@beatgig/moti-pressable
import React, { useReducer, useCallback } from 'react';
import { StyleSheet } from 'react-native';
import { View } from 'moti';
import {
  MotiPressable,
  useMotiPressableTransition,
  useMotiPressable,
} from '@motify/interactions';
import { useSharedValue } from 'react-native-reanimated';

const Box = () => {
  const state = useMotiPressable(({ pressed }) => {
    'worklet';

    return {
      scale: pressed ? [0, 1.5, { value: 1, delay: 200 }] : 1,
    };
  }, []);
  const transition = useMotiPressableTransition(({ pressed }) => {
    'worklet';

    return {
      delay: pressed ? 100 : 1500, // play with this delay here
    };
  }, []);
  return <View style={styles.shape} state={state} transition={transition} />;
};

export default function HelloWorld() {
  return (
    <View style={styles.container}>
      <MotiPressable>
        <Box />
      </MotiPressable>
    </View>
  );
}

const styles = StyleSheet.create({
  shape: {
    justifyContent: 'center',
    height: 250,
    width: 250,
    // borderRadius: 25,
    marginRight: 10,
    backgroundColor: 'white',
  },
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
    flexDirection: 'row',
    backgroundColor: '#9c1aff',
  },
});

In this video, I'm just tapping:
https://user-images.githubusercontent.com/13172299/135329254-ebb3c811-052e-40dd-ace9-f74403f40543.MP4

Its working like a charm thankyou very much. 👍

I suggest you to also make it more simpler like by adding a onSinglePress prop on MotiPressable. to do complete animation on single tap. Thanks

I think that would be best achieved with a custom usage of the onPressIn prop, and one of the other hooks exported from @motify/interactions. You could also use Reanimated directly. Moti aims to be a more react-like, declarative approach to animations.

I think that would be best achieved with a custom usage of the onPressIn prop, and one of the other hooks exported from @motify/interactions. You could also use Reanimated directly. Moti aims to be a more react-like, declarative approach to animations.

ok 👍


After new article is published with date in the past, the previous article is hidden from view and publish date is unassigned

Hello. I encountered an issue with publishing articles after the update from 1.3.6 to 1.3.7.  When I publish an article with the date in the past, the previous one is hidden from the view (can be shown in the database as a column is_visible_in_list_view with value 0) and the publish date is removed from the database (can be shown as a value null). And this is repeated after each publication, only when the article's status is changed from draft to published.

Did you also update your strapi version as well?
I would assume it's some regression there first as the only change between v1.3.6 and v1.3.7 was how deps are handled (https://github.com/ComfortablyCoding/strapi-plugin-publisher/compare/1.3.6...1.3.7)

@ComfortablyCoding Yes, I also updated strapi version along with these updates:

@ComfortablyCoding But you're right, Strapi released a new version and they mentioned some issues with publication (https://github.com/strapi/strapi/releases/tag/v4.11.7).

@ComfortablyCoding Even after I updated the Strapi version, where should be some publication errors fixed, the issue still persists. Also, when I select a date in the publication field, it changes a date to one day before. I attached the video example.
https://github.com/ComfortablyCoding/strapi-plugin-publisher/assets/39583615/108b070f-c6fc-4108-a2aa-5be456d050f0

I will check to see if I can reproduce this issue.
If you have a test instance for your setup I would recommend rolling back the changes and then updating each one by one and seeing at what point the error reproduces.

@ComfortablyCoding After further investigation, I found out that the issue was caused by upgrading plugin @notum-cz/strapi-plugin-content-versioning from the version 0.4.7 to the version 0.4.9.
The new issue can be found in the correct repo here: https://github.com/notum-cz/strapi-plugin-content-versioning/issues/104.
Anomalies with date selection still persists, but I think it should be topic for a new issue, not this one.


Add unit tests

Uses Jasmine and SuperAgent to unit test the function invoker and
HTTP protocol. The bulk of the server code has moved into lib/app.js
in order to make testing easier without needing to bootstrap and
configure a full server process. The app module is a function that
accepts the target function to invoke and returns a configured express
application that is not yet listening to a port.
To execute the tests:

cd src/main/node
npm install
npm test

@ericbottard Updated the functions under test to be more true to their natural content type's structure.

@scothis Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@scothis Thank you for signing the Contributor License Agreement!

Merged as 3667b2e

Thanks for the contribution @scothis!


[core]jadx incorrectly generates dead loop code

link: https://drive.google.com/file/d/1bX4L4QTarbHELLEKI7S_xVRr_UTCR08T/view?usp=share_link
com.nomagic.awt.checktree.CheckTreeNode#childrenChanged.childrenChanged()

Because of the dead loop, the following block of code cannot be executed:
        if (isAbstract()) {
            sSetSelected(isAnyChildSelected());
        }
        if (this.parent != null) {
            this.parent.childrenChanged();
        }

jd_gui

com.nomagic.awt.diskbrowser.DiskBrowserTreeNodeRenderer.getTreeCellRendererComponent(javax.swing.JTree jTree, java.lang.Object obj, boolean z, boolean z2, boolean z3, int i, boolean z4)
Variables that should not appear r4.

Type conversion issues
com.nomagic.awt.table.TableRowHeight.setRowHeight(int) : void

On the face of it, there is nothing wrong with this code, however, putting it into IDEA reports the following error:

After looking at the pseudo-code of jeb and the corresponding location of smali, I found that jadx may not have handled check-cast or generated the wrong type conversion.

Process it to get the correct pseudo code:

This type conversion problem is more common in jadx, hope to fix it, thanks! @skylot


Replace custom slice code with Access.slice/1

This pull request fixes issue #1
I've completely removed JsonPathAccess.Access and its tests since they won't be needed anymore.
While switching to Access.slice/1, I've noticed that negative steps and reverse ranges aren't supported by Access.slice/1. They aren't supported by https://jsonpath.com/ either, so I think we don't need to implement them for now.
I've also noticed that Access.slice/1 has a slightly different behavior than JsonPathAccess.Access.slice/1 in some cases.
For example this method in access_test.exs didn't work when using Access.slice :
update_in(list, [Access.slice(0..0)], &upcase_items/1)
This is because the upcase_items/1 function now receives the item directly instead of receiving a list containing the items. With Access.slice, we now have to use String.upcase directly :
update_in(list, [Access.slice(0..0)], &String.upcase/1)
So, switching to Access.slice/1 works, but it might break some existing code. I'll let you decide if this breaking change is acceptable.

I've checked the spec, and negative steps are supposed to be supported : https://www.ietf.org/archive/id/draft-ietf-jsonpath-base-05.html#section-<IP_ADDRESS>.1-6
So, if we want to used Access.slice/1 we will have to find a way to implement reverse slices.

Hi @fcapovilla, thanks for the contribution! We can deal with negative steps in a separate MR or document that is not supported.
Since I didn't release the first version yet, it's safe to make breaking changes! 💙


[UX] list_env yields expected error with from-python option

./template.sh list_env with the from-python option which only uses pip gives an expected
/opt/template-entrypoints/entrypoint.sh:55: command not found: mamba
as it by default tries both pip and mamba to list dependencies.
A more user-friendly approach would be to let the user know that this is an expected error, or select only the relevant packages mangers.

@andreamiele


GLU perspective

My main perspective initialization in LWJGL 2 was GLU.gluPerspective
Is there an equivalent method in LWJGL 3?

I tryed, lwjgl_util 2.9.3 does NOT work with lwjgl 3. For example, gluPerspective throws an exception:
Exception in thread "main" java.lang.NoSuchMethodError: org.lwjgl.opengl.GL11.glMultMatrix(Ljava/nio/FloatBuffer;)V
	at org.lwjgl.util.glu.Project.gluPerspective(Project.java:218)
	at org.lwjgl.util.glu.GLU.gluPerspective(GLU.java:286)
...

I believe a lot of people would appreciate if GLU would included in lwjgl 3.

I recommend you use the very nice lwjglx project by kappa, which is a compatibility layer on top of LWJGL 3 to adapt some of the APIs of LWJGL 2, including GLU, Display, Mouse and Keyboard.
It works really well with existing projects that require LWJGL 2, such as the Themable Widget Library.
If you merely want to have the "math" aspect of GLU, such as building a lookat or projection matrix, you could use JOML.


audio: float32-value streams in addition to int16-value streams

Fix Oto first.

These exposed API would be affected
package audio

func (c *Context) NewPlayer(src io.Reader) (*Player, error)
func (c *Context) NewPlayerFromBytes(src []byte) (*Player, error)
func NewInfiniteLoop(src io.ReadSeeker, length int64) *InfiniteLoop
func NewInfiniteLoopWithIntro(src io.ReadSeeker, introLength int64, loopLength int64) *InfiniteLoop

package mp3

func Decode(context *audio.Context, src io.Reader) (*Stream, error)
func DecodeWithSampleRate(sampleRate int, src io.Reader) (*Stream, error)
func DecodeWithoutResampling(src io.Reader) (*Stream, error)

package vorbis

func Decode(context *audio.Context, src io.Reader) (*Stream, error)
func DecodeWithSampleRate(sampleRate int, src io.Reader) (*Stream, error)
func DecodeWithoutResampling(src io.Reader) (*Stream, error)

package wav

func Decode(context *audio.Context, src io.Reader) (*Stream, error)
func DecodeWithSampleRate(sampleRate int, src io.Reader) (*Stream, error)
func DecodeWithoutResampling(src io.Reader) (*Stream, error)

Adding option arguments to all the above APIs would not be feasiable 🤔

Though it is possible to add an option without breaking compatibility, it is not good to confuse users. Let's postpone this to v3, when we can break compatibility.

I revisited this and realized that changing this at v3 might be too agressive. Users would be hesitated to migrate to v3 if v3 starts to support only floats. Though it is inevitable to add some confusions, what about adding these APIs?
package audio

func (c *Context) NewPlayerF32(src io.Reader) (*Player, error)
func (c *Context) NewPlayerF32FromBytes(src []byte) (*Player, error)
func NewInfiniteLoopF32(src io.ReadSeeker, length int64) *InfiniteLoop
func NewInfiniteLoopWithIntroF32(src io.ReadSeeker, introLength int64, loopLength int64) *InfiniteLoop

package mp3

type SteamF32

func DecodeF32(src io.Reader) (*Stream, error)

package vorbis

type SteamF32

func DecodeF32(src io.Reader) (*Stream, error)

package wav

type SteamF32

func DecodeF32(src io.Reader) (*Stream, error)

So, you want to keep both formats even for v3, or would you rather switch to only F32 format? Whatever the case, I think that F32 should become the "main" format, in which case creating audio/v2 may be a more desirable transition path.

I'd like to switch to F32 in the future. I have not determined to keep S16 in v3.

Yeah audio/v2 sounds a good idea.

So, if we create audio/v2, this would be like this.  Another concern is, audio.Context and audio/v2.Context cannot coexist, while text and text/v2 are available at the same time (though I don't recomment it).
So, I slightly prefer the first idea (adding *F32 versions to the current packages) https://github.com/hajimehoshi/ebiten/issues/2160#issuecomment-1714185922

So, do the streams still need to implement a byte-oriented approach anyway?
I don't know about any other streams, but my XM stream operates on float32 values internally, but it needs to pack everything into bytes when Read is called.
https://github.com/quasilyte/xm/blob/966acb9af5982f2163d82fce416d1082a4dca1d2/stream.go#L747
I have to convert float32 into int16 and then put those into a []byte.
func putPCM(buf []byte, left, right uint16) {
	_ = buf[3] // Early bound check
	buf[0] = byte(left)
	buf[1] = byte(left >> 8)
	buf[2] = byte(right)
	buf[3] = byte(right >> 8)
}

This is performed for every sample (left+rigth), so if we could "read" into float32 directly it could improve the performance. I can even make a test to tell you how much computation time can be saved by avoiding these conversions.

Then maybe we can do it like this:

All function continue to accept an io.Reader
Inside these function, there can be a type assertion for the ReadFloat32 function interface
If reader support ReadFloat32, we can use it instead

The question is: how to efficiently use either inside the types that use this reader. It would probably depend on how exactly they're using this io.Reader.
Ebitengine already has something like that for LayoutF thing where an interface is checked for another interface.

Yeah maybe this seems to make sense. You can take a benchmark if you want. However, I guess this reading part might not be a performance bottleneck in applications.

The reading is not a bottleneck, since we're calling Read for a block, but packing all sample bytes is another thing.

So is your suggestion just for implementation easeness?

Not exactly.
Maybe I made it too ambiguous initially.
What I meant is that around 30% of the work in Read is type conversions (float32 -> int16) and writing these int16s to a byte slice. Since pcm generation is ~90% of the run time of my XM stream, we can say that playing an XM music spends 0.3*0.9=0.27 (27%) time in extra bookkeeping. If the underlying library needs float32 anyway, these extra efforts can be avoided.
But since the Read's computations are usually spread across the time (because we don't process the entire track, but rather chunk by chunk) it's hard to tell how much of an impact it might have.
I don't mind if we don't add a new API, I just wanted to make sure that I understood things correctly.
I can't see how the suggested API changes would affect my code otherwise, so maybe it's something that I can skip entirely.

I think I'll go with https://github.com/hajimehoshi/ebiten/issues/2160#issuecomment-1714185922 without creating audio/v2. It seems critical that audio and audio/v2 could not coexist.

You cannot mix frameworks that use audio and audio/v2, for example.

Or, it is possible to make a wrapper to share the same context implementation so that audio and audio/v2 could coexist. In this case, audio/v2's API would be like https://github.com/hajimehoshi/ebiten/issues/2160#issuecomment-1858890782.

Regarding the coexistence issue, can't you simply register a variable on internal and then init it from both packages, panicking if the variable is already set (effectively preventing usage of both packages at the same time)?

Regarding the coexistence issue, can't you simply register a variable on internal and then init it from both packages, panicking if the variable is already set (effectively preventing usage of both packages at the same time)?

I found these (a context for int16 and a context for float32) can coexist, so we don't have to care.

If we want to mix an existing int16 stream and a new float32 stream, the code would be like these:
// Adding new APIs to the existing audio package

context := audio.NewContext(48000)
p0 := context.NewPlayer(int16Source)
p0.Play()
p1 := context.NewPlayerF32(float32Source)
p1.Play()

// Adding audio/v2
import (
    "github.com/hajimehoshi/ebiten/v2/audio"
    audiov2 "github.com/hajimehoshi/ebiten/v2/audio/v2"
)

context := audiov2.NewContext(48000)
p0 := audio.CurrentContext().NewPlayer(int16Source) // When a context is created by audio/v2, the same context exists in v1.
p0.Play()
p1 := context.NewPlayer(float32Source)
p1.Play()

So, if we migrate int16 streams to float32 streams, the former would be definitely better. On the other hand, if we finish migrating, the latter would be cleaner.
As the latter (audio/v2) code seems tricky, I'll go with former.

I tried looking at the referenced issues and it seems like the rationale behind it is mostly internals-related.
Is there anything Ebitengine users should be concerned about?

Is there anything Ebitengine users should be concerned about?

Nothing much to be honest. The benefits are

It is slightly easier to modify your audio source
You can use other decoders a little more easily if these treat float values (and I think this is common)

I started to think that the benefit might not be big compared to the benefit. So, it might be a good idea to retract F32 APIs and revisit this in v3... 🤔

Aren't we often applying effects to ogg streams by converting f32 to L16 internally in ebitengine, then back from L16 to f32 to work with it and apply the effects, and then back from f32 to L16 to return it to ebitengine? Saying it's only "slightly easier" is kind of an understatement. While once you get it it's true that it's not so difficult, having to work with 4 values for 2 samples instead of 2, and having to understand how Length() and loops and stream values correlate to samples and time is not trivial and lots of users are confused about it. So I would actually say that the main point is simplifying the model by not requiring users to understand a non-trivial format, and I think there are also some performance considerations.

Aren't we often applying effects to ogg streams by converting f32 to L16 internally in ebitengine, then back from L16 to f32 to work with it and apply the effects, and then back from f32 to L16 to return it to ebitengine?

The Oto layer already uses only f32 so the last conversion doesn't exist. With the new F32 APIs, no conversion happens in theory, which is good for everyone. With the existing APIs and vorbis.DecodeWithoutResampling, f32 -> i16 -> f32 conversion happens, which is waste of CPU power.

I think there are also some performance considerations.

Apparently converting f32 <-> i16 was not a performance bottleneck as far as I know, though the new API should improve some performance.

It's true that keeping both formats side by side in audio will still be confusing for users though, which is why I was in favor of having audio/v2 separately.

If v1 and v2 could be mixed easily, this would cause another confusion. Also, v2 doesn't improve the API drastically from v1 very much or improve performance very much, so users would have a little motivation to migrate to v2. IMHO v2 should have much improvement at the expense of compatibility break.

If a user generates its own PCM sound (like examples/piano or examples/pcm), they can use the F32 version for a smooth migration for v3 in the future. I think that's one of the reasons why we should have the F32 version of the API now. So now I'm now feeling like I should not retract the change. Sorry for going back and forth.

Don't worry, although I'm of the opinion of "given similarly reasonable alternatives, let's just pick the one that most closely matches the final desired model", I don't have strong arguments against any of the discussed alternatives: I don't think there's anything "wrong" with them. I think we all agree that the main change happening here is in the model itself, not the capabilities/features of the audio package, so... it can be hard to make a decision from a purely "technical" perspective.


Logo

Does Nebula have a logo? ..might help distinguish it from other nebula references and build project awareness

One idea:

SVG: https://drive.google.com/file/d/1YZd4jP9qo6BnZvtdKSb_xU9gPL3Myc3F/view?usp=sharing
Font: https://www.fontspace.com/madcat-font-f31773

Update: looks like you're using the Defined Networking shape as a logo: https://medium.com/definednet/mobile-nebula-ios-android-mesh-vpn-1088a7c536ee

https://github.com/DefinedNet/mobile_nebula/blob/master/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png


Allow newer versions of network library

HaskellNet now allows newer versions of the network library, so we can too.
EDIT: Note that this enables HaskellNet-SSL to be used with GHC >= 8.8.

I'm currently using your fork for my project! I'm going to look through this repo and merge this branch sometime in the coming week, and hopefully get this package compiling under newer versions of ghc soon.


Added checks for existing content is git repo

This fixes an error when the git repo is empty, e.g. the user only ran
git init.  If the repo is empty, we use system copy commands instead
of git commands, and warn the user.
Also added warnings for if there is a .git directory in the project, but
a Git binary is not installed.
Currently working on tests, just posting this for discussion
@bparees
Old output, git installed:

---> Installing application source ...
ERROR: cp: cannot stat '/tmp/src/.': No such file or directory

ERROR: An error occurred: non-zero (13) exit code from openshift/ruby-22-centos7

Old output, git not installed:

---> Installing application source ...
---> Building your Ruby application from source ...
WARNING: Rubygem Rack is not installed in the present image.
Add rack to your Gemfile in order to start the web server.

New output, git installed:
Warning: file:///home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf is a Git repository, but is empty.

---> Installing application source ...
---> Building your Ruby application from source ...
WARNING: Rubygem Rack is not installed in the present image.
Add rack to your Gemfile in order to start the web server.

New output, git not installed
Warning: file:///home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf is a Git repository, but you do not have git installed.
Warning: file:///home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf is a Git repository, but is empty.

---> Installing application source ...
---> Building your Ruby application from source ...
WARNING: Rubygem Rack is not installed in the present image.
Add rack to your Gemfile in order to start the web server.

Fixes #298

Made the "Warning: " all caps

[test]
@bparees ptal?

I've reviewed a bit, but the last opinion on @bparees of course, so you can ignore my comments, but I would be happy if some of ideas will help somehow.

Updated to bubble errors up and stop the program.
New output: Git installed
s2i build file://$PWD openshift/ruby-22-centos7 newapp
ERROR: An error occurred: The git repository "file:///home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf" has no tracking information or commits

New output: Git not installed
 s2i build file://$PWD openshift/ruby-22-centos7 newapp
ERROR: An error occurred: Git was not found in the PATH

@bparees  @php-coder ptal?

After adding the errors to our errors package, the new outputs follow the format
s2i build file:///$PWD openshift/ruby-22-centos7 newapp
ERROR: An error occurred: The git repository "file:////home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf" has no tracking information or commits
ERROR: Suggested solution: Either remove the .git directory from the project, or update its tracking information.
ERROR: If the problem persists consult the docs at https://github.com/openshift/source-to-image/tree/master/docs. Eventually reach us on freenode #openshift or file an issue at https://github.com/openshift/source-to-image/issues providing us with a log from your build using --loglevel=3

@bparees What do you think about this output?

ERROR: Suggested solution: Either remove the .git directory from the project, or update its tracking information.

the suggested solutions would be any of:

commit the local files to the repository
remove the .git folder
use --copy instead

New output
ERROR: An error occurred: The git repository "file:///home/rymurphy/documents/projects/go/src/github.com/openshift/source-to-image/asdf" has no tracking information or commits
ERROR: Suggested solution: Either commit files to the Git repository, remove the .git directory from the project, or use --copy to ignore the repository.
ERROR: If the problem persists consult the docs at https://github.com/openshift/source-to-image/tree/master/docs. Eventually reach us on freenode #openshift or file an issue at https://github.com/openshift/source-to-image/issues providing us with a log from your build using --loglevel=3

Also had to make changes to make sure --copy would work even with a faulty Git
@bparees ptal?

@bparees I've update isValidGit to not check for a Git binary, and moved that check up to ParseFile.  I've also removed the predeclared returns, and updated test cases. ptal?

@bparees I've made the ParseFile function more lazy in it's checks, ptal?

@bparees I've put in your suggestion, ptal?

@bparees I've put in your suggestion, ptal?

did it make sense?

@bparees I decided not to implement an error for missing .git

@bparees I added some checks for error types within the tests, as well as to scm.go, ptal?

one last question on the behavior of defer, and needs commit squashing.

I'll squash now

[merge]


pi3hat communication is unreliably with 64 bit Raspberry Pi OS

Observed by @stephane-caron
When a 64 Raspberry Pi OS is used, flashing moteus controllers over the pi3hat's CAN-FD ports often fails.

I've narrowed down the problem to BusyWaitUs not waiting long enough on the 64 bit Pi OS, which can result in the address setup time being violated.  I'm guessing the time resolution is worse, so that subsequent polls can show a larger jump than actually occurred.
I'll have to do some research to see if there is any finer source of timing available.

Resolved in d4755d7e01b29cb16e875d17da1546233ea8b6ae and released on pypi as 0.3.21


Add doc comments to KeyDerivation type

Committed to refactor branch as https://github.com/GrabYourPitchforks/DataProtection/commit/957bde42a797ae1a1d034f2a1314742386c40c9e, pending PR to dev.


Getting opensource DMs from the bot even though I removed my opensource role

Description
I removed my opensource role but I'm still getting DM's to contribute to opensource.
Screenshots
Remove the role

I don't have the role now

But I'm getting DM's everyday

Oh sorry for that. Let me check the latest is deployed. When we move to the new bot with auto deployment things will be better

I'm not getting the DMs from 6 days, I think it's fixed. Thanks!


Send message to user upon first connection to server

Would like the ability to have a connection message like FTS has.
Preferably with memory of who it has messaged, to avoid spam on shoddy connections.

I think this is a very useful feature -- but for now I think I'll push this off to the 1.0 release.

If this feature is added it needs to be able to be disabled. It also the ideal to have some kind of rate limit intelligence as to the last time it sent the message to that uuid. It indeed will trigger spam connections when driving in and out of data connectivity. I have seen this with FTS and now turn off the connection message as it gets very annoying.

If this feature is added it needs to be able to be disabled.

Absolutely!  Conveniences and features like this will always be optional, and "opt-in", not something that gets in the way!

If this feature is added it needs to be able to be disabled.

Absolutely!  Conveniences and features like this will always be optional, and "opt-in", not something that gets in the way!


Test Python/Django/DRF combinations

Use tox to Test combinations of:

Python 2.7, 3.2, 3.3, and 3.4
Django 1.5, 1.6, and 1.7
Django REST Framework 2.3, 2.4, and 3.0

TravisCI changed to call permutations of tox
Tests fixed for DRF 2.3 and 2.4.
Helps with #24.

Thanks!


Auto generate module map file for C libs

This generates modulemap files according to the C proposal https://github.com/apple/swift-evolution/blob/master/proposals/0038-swiftpm-c-language-targets.md
Additionally if there is no include dir then it will emit an empty modulemap file with a warning.

@mxcl review/CI

Maybe it should error if there is no includes and it is a library? Since it is impossible to import it.
I'm mainly thinking of the packaging graph. We don't want broken packages in the wild.
OTOH maybe this is tedious.

Maybe it should error if there is no includes and it is a library? Since it is impossible to import it.
I'm mainly thinking of the packaging graph. We don't want broken packages in the wild.
OTOH maybe this is tedious.

Module map is only generated for libraries
if includes is not present then it creates an empty module map with a warning
if includes is present and is empty it errors out

should I change it to not emit empty module and error out?

should I change it to not emit empty module and error out?

I think this would be more consistent considering:

if includes is not present then it creates an empty module map with a warning

We definitely should be generating this stuff into a side directory in the build dir.
I would prefer it not be an error to not have includes for a lib, just because that is useful when starting development. In general, I prefer it not to be an error for things that are "well formed" even if they aren't totally usable

I would prefer it not be an error to not have includes for a lib, just because that is useful when starting development. In general, I prefer it not to be an error for things that are "well formed" even if they aren't totally usable

Maybe instead of:

if includes is not present then it creates an empty module map with a warning

We do:

if includes is not present then it creates no module-map, but warns that you should create an includes directory because otherwise it is a useless library-module

Which then flows nicely with the existing:

if includes is present and is empty it errors out

Sounds good to me!

done, done, done and done 😄
@mxcl @ddunbar  re-review

@ddunbar addressed the comments re-review

@swift-ci please test

@swift-ci please test

@ddunbar updated the generation logic to :
1. Look for include/foo/foo.h, if so, use umbrella header and error if there are any other dirs or headers outside of there
2. Look for include/foo.h, if so, use umbrella header and error if there are any other dirs outside of there
3. All other cases, just use umbrella dir and don't bother to diagnose anything else

@swift-ci please test

LGTM!
A nice follow on would be to have more explanation in the "invalid layout" cases about exactly what failed, e.g.:
error: unable to generate module map for "include/foo/foo.h" with stray header file "include/bar.h"
or something (could use some more word smithing). Anything to give the user an idea of exactly what it was that kicked them out of the convention path.

Yay! Cool. I'll try to improve the error messages in another PR

Fixed the linux error, @ddunbar re run CI please

@swift-ci please test

osx tests keep failing due to some watch kit thingy

@mxcl @ddunbar can you retrigger CI

@swift-ci please test and merge

@swift-ci please test

Thanks!


Downloading videos at the top of the queue blocks the queue

So, if a video is at the top of the queue and is not downloaded, nothing can play until it is.
The default behaviour should probably be to skip over videos while they're downloading instead of blocking the next video in the queue from playing, especially if it's a long video, and re-queue them when they've finished downloading. Either that, or try to pull the next downloaded video to the front of the queue.

Adding a download timeout will fix this.


Contam Tool broadcasting error for SUBSTRIP96

There is a broadcasting error when trying to make a SUBSTRIP96 contam calculation.

I can't check the logs on production because of #598 and I can't reproduce the error testing locally on my machine.


sendlocation gives error

await bot.SendLocation(msg.Chat.Id, lat, lng);
gives error: [Error]: Wrong file identifier was specified
the lat and longitute comes from google

is this still valid? a quick test worked


Adds client support for cancelling concurrent async inputs

Feature unlocked by server based on a _experimental_concurrent_cancellations flag on the function definition.
Also adds a terminate_containers option for FunctionCallCancel, which can be used if a user wants to ensure that a non-cooperative input/function can still be terminated at the expense of having to rerun any concurrently running inputs in another container (also needs server support)
Describe your changes

Provide Linear issue reference (e.g. MOD-1234) if available.

 Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

[x] Client+Server: this change is compatible with old servers
[x] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

@prbot approve