MAPREDUCE-7409. Make shuffle key length configurable

Description of PR
Make shuffle key length configurable
JIRA - MAPREDUCE-7409
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 14s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 28s

trunk passed

+1 :green_heart:
compile
0m 57s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
0m 56s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 44s

trunk passed

+1 :green_heart:
shadedclient
23m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 33s

the patch passed

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 33s

the patch passed

+1 :green_heart:
shadedclient
23m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
7m 20s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

112m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4816

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ac1dfa937321 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 16a3c4e8c1112a74a42f46cd0f4c5b4db763c95a

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/1/testReport/

Max. process+thread count
1068 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ashutoshcipher thanks for the contribution! The change looks good to me, however I have one request. We would need some test on cases where the key is longer than 64 bits. Perhaps the default value should be 256?

Hi @ashutoshcipher thanks for the contribution! The change looks good to me, however I have one request. We would need some test on cases where the key is longer than 64 bits. Perhaps the default value should be 256?

Thanks @9uapaw for reviewing. The original value at 64, so I kept default as 64 but I will change it 256 as per you suggestion.
On test-case side, can you share give some suggestion how to check that.

I think the default length 64 is all right in terms of backwards compatibility. My idea was to run the whole test suite with the default value set to 256, just to be sure, that it will not break anything. The final PR should default to 64 though.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 47s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 50s

trunk passed

+1 :green_heart:
mvnsite
0m 53s

trunk passed

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 47s

trunk passed

+1 :green_heart:
shadedclient
23m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
mvnsite
0m 49s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 43s

the patch passed

+1 :green_heart:
shadedclient
26m  5s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
7m 20s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

113m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4816

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a58967ddb2e0 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 682c8997eb62c9f974e27433e35012f14178107f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/2/testReport/

Max. process+thread count
1107 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@9uapaw - Jenkins build with test runs is complete with default value set to 256. Let me know if its looks good to you, I will make change back to 64 and raise the final PR.

I think it is sufficient, let us revert back to 64 and I will commit this.

I think it is sufficient, let us revert back to 64 and I will commit this.

Thanks for reviewing PR and sharing your comments. Reverted back to 64 in latest commit.

Thank you @ashutoshcipher. Committed to trunk, closing this PR.

Thanks. Please update the JIRA as well with fixed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 23s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 50s

trunk passed

+1 :green_heart:
mvnsite
0m 55s

trunk passed

+1 :green_heart:
javadoc
0m 45s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 45s

trunk passed

+1 :green_heart:
shadedclient
24m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 40s

the patch passed

+1 :green_heart:
compile
0m 45s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 45s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 34s

the patch passed

+1 :green_heart:
mvnsite
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 33s

the patch passed

+1 :green_heart:
shadedclient
23m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
7m  9s

hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

111m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4816

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3ade6b76b397 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 51b88f6e1f8995a7e9af92579c43cf6a2c0aee6e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/3/testReport/

Max. process+thread count
1118 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4816/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Single page version would be nice for quickly browsing/searching

I usually love to use the browser search to quickly find what I'm looking for (e.g. when I have a keyword in mind and I know there's something in the guidelines about this).
The GitBook search doesn't seem so convenient. You still have to click through pages and don't have highlighted search results.
Is there a possibility to provide a single-page version of the book?

It should be possible with 'gitbook build -f page' but for some reason in our setup this is not working out of the box. @mostlymagic Could this be cause by one of our plugins?
Or we need to upgrade our Gitbook version. I'll investigate more on this.
In the meantime you can build a PDF, by (on Mac with Homebrew):
brew install cask
brew cask install calibre
make init
npm install ebook-convert
node_modules/.bin/gitbook pdf

@fmueller as discussed, Iit would be great, if there is an easy way to also generate the pdf with gitbook pages, to ship it with the pages and let the intro pages link to the pdf. Is this feasible w/o bigger efforts?

PDF generation is now part of the publishing travis build and you'll find the newest version under this link: http://zalando.github.io/restful-api-guidelines/guidelines.pdf
I'll still investigate a single page generation in HTML.

I close this issue. Unfortunately there is not easy way to generate a singe page version via gitbook. For this, one has to use the pdf version.


feat(protocol): Cache source chain signal service storage proof

As discussed moved to another PR and also only caching the outter (source chain's signal service root).

Closing as abandoned.


Consider header-only library?

Hello,
I found this library at a perfect moment - just when I started having bugs on Apple devices due to platform-specific folders. I'm enjoying it so far, but had one question about it: are there any plans to convert it to a header-only library, that way I don't have to mark the .cpp file as a source?
Thanks!

I considered it. I decided against it due to different platforms having different include requirements and I would quickly expose something I should not.


v1.10 - Updates quickstarts/tutorials/pub-sub to dotnet v7

Signed-off-by: Roberto J Rojas<EMAIL_ADDRESS>Description
Updates quickstarts/tutorials/pub-sub/csharp-subscriber to use dotnet v7.

@robertojrojas thanks for the contribution. Can you clarify why you only updated the pubsub tutorial and not the other quickstarts for using .net7?

I think we should update all quickstarts to dotNet 7

@greenie-msft  I noticed that the distributed-calculator/csharp app was updated to use the v7 version and this was a simple change to make the tutorials "consistent" with other tutorials using the dotNet framework.  I do believe the rest of the quickstarts need to be updated, but maybe for release v1.11+.

Actually, so we don't delay the v1.10 release with this PR, I'll postpone this change for v1.11.


Add release tags

Please add tags for releases to be able to select specific versions with git tools.

I've started release tags based on the stable branch. I don't think I can get it to work for older version unfortunately.


fix(client): more reliably detect closed pooled connections

Uses a more reliable way of detecting that the connection has been closed, by keeping that knowledge in a separated close/cancel token, instead of relying on the mpsc channel knowing if either side is dropped, or that a ClientMsg::Close variant had been sent.
Closes #1433

@xrl Would it be possible to try out your app with this branch?

I updated to 0.11.17 and it has been quiet with ~30 minutes of stress testing. Thanks!


Answered rebuses in local storage shouldn't have duplicated rebuse id

Expected Behavior
Answered rebuses array in local storage should have unique elements
Actual Behavior
Answered rebuses array in local storage may have duplicated elements
Steps to Reproduce the Problem

Answer a rebus then check answered rebuses in local storage.
Come back the answered rebus then remove a char and re-enter it again.
Check answered rebuses in local storage again and see the duplicated rebus id.

I think this should be fixed by #146 right?

@ollelauribostrom Yes, you are right! I didn't notice #146 when I opened this one. Now, I'm closing this issue 😊


Mongo not installing.

Info:

Docker version ($ docker --version): Docker version 18.03.1-ce, build 9ee9f40
Laradock commit ($ git rev-parse HEAD): 6fa2b75bb7b31287d216609394f93bd18c7f02e0
System info (Mac, PC, Linux): Windows 10 Pro

Issue:

It appears that mongo is not installed. When I run composer install I receive
 - Installation request for mongodb/mongodb 1.3.2 -> satisfiable by mongodb/mongodb[1.3.2].
 - mongodb/mongodb 1.3.2 requires ext-mongodb ^1.4.0 -> the requested PHP extension mongodb is missing from your system.
I am also getting bash: mongod: command not found. When I try to access mongo from bash.
Expected behavior:

mongod to give me access to mongo and be able to do composer install without mongo errors.
Reproduce:

Add mongodb/mongodb to your composer.json to see if that installs.
You could also try the mongod command in bash. I am currently, using the laradock user.
Relevant Code:
Composer error I am receiving.

  Problem 1
    - Installation request for mongodb/mongodb 1.3.2 -> satisfiable by mongodb/mongodb[1.3.2].
    - mongodb/mongodb 1.3.2 requires ext-mongodb ^1.4.0 -> the requested PHP extension mongodb is missing from your system.

  To enable extensions, verify that they are enabled in your .ini files:
    - /etc/php/7.2/cli/php.ini
    - /etc/php/7.2/cli/conf.d/10-mysqlnd.ini
    - /etc/php/7.2/cli/conf.d/10-opcache.ini
    - /etc/php/7.2/cli/conf.d/10-pdo.ini
    - /etc/php/7.2/cli/conf.d/15-xml.ini
    - /etc/php/7.2/cli/conf.d/20-bcmath.ini
    - /etc/php/7.2/cli/conf.d/20-calendar.ini
    - /etc/php/7.2/cli/conf.d/20-ctype.ini
    - /etc/php/7.2/cli/conf.d/20-curl.ini
    - /etc/php/7.2/cli/conf.d/20-dom.ini
    - /etc/php/7.2/cli/conf.d/20-exif.ini
    - /etc/php/7.2/cli/conf.d/20-fileinfo.ini
    - /etc/php/7.2/cli/conf.d/20-ftp.ini
    - /etc/php/7.2/cli/conf.d/20-gd.ini
    - /etc/php/7.2/cli/conf.d/20-gettext.ini
    - /etc/php/7.2/cli/conf.d/20-iconv.ini
    - /etc/php/7.2/cli/conf.d/20-igbinary.ini
    - /etc/php/7.2/cli/conf.d/20-intl.ini
    - /etc/php/7.2/cli/conf.d/20-json.ini
    - /etc/php/7.2/cli/conf.d/20-mbstring.ini
    - /etc/php/7.2/cli/conf.d/20-msgpack.ini
    - /etc/php/7.2/cli/conf.d/20-mysqli.ini
    - /etc/php/7.2/cli/conf.d/20-pdo_mysql.ini
    - /etc/php/7.2/cli/conf.d/20-pdo_pgsql.ini
    - /etc/php/7.2/cli/conf.d/20-pdo_sqlite.ini
    - /etc/php/7.2/cli/conf.d/20-pgsql.ini
    - /etc/php/7.2/cli/conf.d/20-phar.ini
    - /etc/php/7.2/cli/conf.d/20-posix.ini
    - /etc/php/7.2/cli/conf.d/20-readline.ini
    - /etc/php/7.2/cli/conf.d/20-redis.ini
    - /etc/php/7.2/cli/conf.d/20-shmop.ini
    - /etc/php/7.2/cli/conf.d/20-simplexml.ini
    - /etc/php/7.2/cli/conf.d/20-sockets.ini
    - /etc/php/7.2/cli/conf.d/20-sqlite3.ini
    - /etc/php/7.2/cli/conf.d/20-sysvmsg.ini
    - /etc/php/7.2/cli/conf.d/20-sysvsem.ini
    - /etc/php/7.2/cli/conf.d/20-sysvshm.ini
    - /etc/php/7.2/cli/conf.d/20-tokenizer.ini
    - /etc/php/7.2/cli/conf.d/20-wddx.ini
    - /etc/php/7.2/cli/conf.d/20-xmlreader.ini
    - /etc/php/7.2/cli/conf.d/20-xmlwriter.ini
    - /etc/php/7.2/cli/conf.d/20-xsl.ini
    - /etc/php/7.2/cli/conf.d/20-zip.ini
    - /etc/php/7.2/cli/conf.d/25-memcached.ini
    - /etc/php/7.2/cli/conf.d/xdebug.ini
  You can also run `php --ini` inside terminal to see which files are used by PHP in CLI mode.

mongodb is on difference container and edit your .env file
WORKSPACE_INSTALL_MONGO=true
PHP_FPM_INSTALL_MONGO=true

Ensure you are entering the workspace container
docker-compose exec workspace bash
to run your composer install

After enabling MongoDB in .env
WORKSPACE_INSTALL_MONGO=true
PHP_FPM_INSTALL_MONGO=true

Prune all the images, and try again
docker rmi $(docker image ls -aq)
docker-compose up -d workspace
docker-compose exec workspace bash
php -m | grep mongo

And you can see "mongodb"

After enabling MongoDB in .env
WORKSPACE_INSTALL_MONGO=true
PHP_FPM_INSTALL_MONGO=true

Then remember to run the below script to rebuild workspace and php-fpm containers, so that the changes in .env will take effects and applies to the new workspace and php-fpm containers.
docker-compose build workspace php-fpm


Colorized attribute

Hi! I'm trying to add syntax highlighting for my SQL queries in logs.
There is a library that does it pretty well:
package main

import (
	"bytes"
	"os"

	"github.com/alecthomas/chroma/quick"
)

func main() {
	var q bytes.Buffer
	quick.Highlight(&q, "SELECT 1 + 1", "sql", "terminal16m", "monokai")
	os.Stderr.Write(q.Bytes()) // output will be colorized, as expected
}

But when I try to add colorized SQL as slog.Attr, it will print escaped sequence instead:
package main

import (
	"bytes"
	"log/slog"
	"os"
	"time"

	"github.com/alecthomas/chroma/quick"
	"github.com/lmittmann/tint"
)

func main() {
	slog.SetDefault(slog.New(
		tint.NewHandler(os.Stderr, &tint.Options{
			Level:      slog.LevelDebug,
			TimeFormat: time.TimeOnly,
		}),
	))

	var q bytes.Buffer
	quick.Highlight(&q, "SELECT 1 + 1", "sql", "terminal16m", "monokai")

	// prints something like
	// 18:50:29 INF SQL query query="\x1b[38;2;102;217;239mSELECT\x1b[0m\x1b[38;2;248;248;242m \x1b[0m\x1b[38;2;174;129;255m1\x1b[0m\x1b[38;2;24
	slog.Info("SQL query", "query", q.String())
}

I believe this is happening because of strconv.AppendQuote,  which you are using to quote strings here. AppendQuote escapes all the colors sequences.
Seems like you're passing "quote=true" everywhere and I cannot disable this behavior using ReplaceAttrs or something like that.
Am I missing something? Is there a way to preserve colors for some attributes? Thanks!

In case my idea is fine for the lib, I solved this issue for me with:

Careful though, if this is solved with just a prefix then an attacker could exploit this to make your terminal do funky things by if they merely control some to-be-logged value (which they usually do).
If this becomes a library feature then imo it should be 1) behind an off-by-default flag (for e.g. libraries) and 2) a special type to wrap unsafe "raw" strings with, that should not be escaped when being printed.


CARDS-2497: Filtering forms by date equality doesn't work reliably

To test:

build and start in prems mode
create a visit information with a set time
go to the dashboard, add a filter on Time=that time
check that the form shows up
change the filter to >= and <= and check that the form still shows up
change the filter to > and < and check that the form does not show up

Hold on, this also affects the export filters, trying to fix those as well.


Improved error message for missing block txs in explorer-api

The error message returned by the cardano-explorer-api /api/blocks/txs/{txHash} endpoint when no results are found is a bit ambiguous, stating "No block found" even if the block exists with no associated transactions (in explorer-api/src/Explorer/Web/Api/Legacy/BlocksTxs.hs).
A more informative error message (e.g. "No transactions found in block") would help make things clearer for cardano-rest users.
cc @melmccann

Implemented in #112


Translate May 15 covid report into Korean

Happy weekend @nextstrain/korean,
The situation report from 2020-05-15 is ready to be translated to Korean. This week's report is short and focuses on mutations. It's targeted more at the public than some of our previous reports and is intended to answer some of the many questions we've been receiving on the subject. I hope it will be useful for Korean speakers.
Sadly, this will be our last weekly Situation Report for awhile although we'll issue periodic sit-reps as needed. Thank you, thank you, thank you for translating these reports. It's been an amazing collaborative effort to be involved in. I'll miss working with you on them.  I've personally derived a lot of global solidarity from our work together. Although we will all probably enjoy having more time on the weekend!
Branch to translate on: sit-rep_ko
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_ko/narratives/translations_ncov_sit-rep_ko_2020-05-15.md You can translate directly in this file, but please remember to push often as other people may be working on the translation!
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_ko/ncov/sit-rep/ko/2020-05-15
Twitter post to translate:
“Our latest situation report focuses on viral mutations: why they occur, when they matter, and how they can be useful in tracking outbreaks. The report is now available in Korean.
Since repeated patterns of viral introduction and spread across the world have become clear, we'll be pausing weekly situation reports for a while. We will publish periodic situation reports as the data allows.
Thank you to @, @, @ for their rapid translation of this report. Thank you to @, @ for their work on previous translations as well."
Regards,
Cassia
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/korean
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. (Although it is okay to update Wikipedia or CDC links to the appropriate language version.) Comments to help with translation are noted in comment symbols like <! -- Comment -->.
Please add your name under translators: with new line, tab, and dash, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Korean; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy of what we publish. Thanks for understanding.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.
Feel free to use a live, online editor like hackmd (sign in with GitHub) to translate together.

@KyobinKang, @taehoonh, @minkyuxyz, @hanbin973, are any of you available to work on this translation? It's the last one for a little while, and because it covers mutations and a lot of misconceptions about the virus, I think could be quite useful!

Hi @cassiawag , I am working on it!

@cassiawag
Under  [External Resources],
The title of the NY Times article is "How coronavirus mutates and spreads" but in the report it is mutations instead of mutates.

@taehoonh @cassiawag I'll cover the proofreading.

Hi @KyobinKang and @nextstrain/korean ,
Just completed the translation. It took longer time than usual, as the last report includes many biology terms. Although I tried my best, it will be pretty rough. In particular, I couldn't come up with an appropriate word regarding "redundant encoding". For those who have good translation for "redundant encoding", please let me know. I would appreciate it if you review and correct it. Thank you in advance.

@taehoonh @cassiawag I've completed the proofreading.  Thanks to my pharmacy background, I could revise a lot, but still I wish a confirmation from anyone with more concrete background.
FYI,  I guess "redundant encoding" is a non-expert term for "synonymous substitution" (based on the link); so I translated it to "동의치환", which is the most common option for "synonymous substitution".

@nextstrain/korean -- is anyone else available to take a loook?

Since this report isn't time sensitive, I think that it's better to prioritize accuracy over time to publishing.

Decided to go ahead and publish: https://nextstrain.org/narratives/ncov/sit-rep/ko/2020-05-15
Thank you both for the hard work :)


Upgrade Spock2 to milestone 5

Contains fixes for known issues in our tests:

https://github.com/spockframework/spock/issues/1267 - incorrect reporting of failed tests when using @Retry with SETUP_FEATURE_CLEANUP mode
https://github.com/spockframework/spock/issues/1263 - jUnit assumption handling from superclasses - we had a workaround implemented for this which goes away now.

Release notes: https://spockframework.org/spock/docs/2.0-M5/release_notes.html#_2_0_m5_2021_03_23

This change required adjusting of some visibility modifiers in tests to overcome new compilation failures like the following: https://ge.gradle.org/s/tapccphi43va2/console-log#L2120
It looks like the new version does not like when a Groovy test class has an explicit getter when a field of that name exists: https://ge.gradle.org/s/3gwxqi5grqppq/console-log?anchor=1511
There were also compilation problems where a base class would declare an abstract getter that would be implemented using a Groovy field with a final modifier in a subclass. Removing offending modifiers solved those problems.

@bot-gradle test and merge this

OK, I've already triggered a build for you.

Pre-tested commit build failed.

OK, I've already triggered a build for you.

Your PR is queued because #16678 is being built.

@bot-gradle test and merge

This one is being built: https://builds.gradle.org/viewQueued.html?itemId=42321457&tab=queuedBuildOverviewTab

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


New command: aad o365groups recyclebinitem clear

aad o365group recyclebinitem clear
Clears all Groups from the recycle bin

Option
Description

--confirm
Does not ask for confirmation

Related issues: #1982 #2032 #2031

I would like to work with this one since I'm already working with the same chain of commands

Thank you. All yours

Hey @douglasromao 👋
Are you still working on this?

Hi @garrytrinder sorry about the delay :( had some personal problems, but I will be back working on that in the next weekend if you guys agree with that.

Totally fine! Life happens. Hope all is good and we appreciate your help 😊

Hey @douglasromao 👋
Are you still working on this?
Please let us know if you need any assistance.

Resetting as available due to lack of response

I can try to implement this one..


Infinite liquids withdrawal

Issue description: Infinite liquids withdrawal
What happens:
Extracting liquid from system with < 1000 mb yields more liquid
What you expected to happen:
No liquid in storage
Steps to reproduce:

Have fluid storage block with 350 mb (any liquid, any amount < 1000mb)
Attach an exporter in liquid mode to any tank

At single cycle tank will be filled with 350 mb, but 650 mb will remain in system
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: .2092
Refined Storage: 1.04

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

Does this happen to really any tank? Which ones did you try?

Yes, with any of IC2, Mekanism and TiCon
setup preview

notice filled tanks

...Fluid Interface?
https://github.com/raoulvdberge/refinedstorage/blob/mc1.10/src/main/java/refinedstorage/tile/TileFluidInterface.java#L122

Whoops, thanks


Using @babel/preset-typescript, unsure how to include .ts and .tsx file extensions with gulp-babel

Hi there,
I'm trying to use typescript with babel, and I use gulp. I'm aware of the issue surrounding the .ts and .tsx file extension babel issues (https://github.com/babel/babel/pull/6027), and the recommended solution to put this somewhere, but I'm not sure where it goes when using gulp-babel:
require('@babel/register', {
  extensions: ['.js', '.jsx', '.ts', '.tsx']
})

This code might need to be added to gulp-babel in order to register the extensions correctly, since none of my project's code executes as it is being built, and running it in my gulp task didn't work. I also tried passing an extensions option into gulp-babel, but that returned an error:
ReferenceError in plugin "gulp-babel"
Message:
    Unknown option: .extensions. Check out http://babeljs.io/docs/usage/options/ for more information about options.

@hzoo is there anything I can do to help with this, or do you have time to look into this? Although the upstream change that could fix this (babel/babel#6027) isn't implemented, other downstream tools like babelify have work arounds. I was wondering, do you know something that could work for gulp?

@chrisgervang Could you clarify exactly what issue you're currently running into with gulp-babel? It should just process any file given to it based on what you list in gulp.src, so Babel itself doesn't really need to know what extensions are in use in gulp-babel's case.
Are we talking about when you are compiling your files, or when you try to run them? What specific issues are you seeing in a normal configuration?

@loganfsmyth this issue occurs while compiling files. The issue might be that gulp.src isn't including any .ts, .tsx in it's search for some reason.

Without seeing your Gulp task, it is hard to say. Could you add more code?

After changing gulp.src to a list of string file globs that includes .ts and .tsx files, the issue was fixed. Thanks for the guidance!


Inspector wont display variable correctly once its type changes

Tested versions
v4.3 dev5 - v4.2.1 stable
System information
v4.3.dev5.official.89f70e98d - Vulkan 1.3.242 - Forward Mobile - NVIDIA - NVIDIA GeForce GTX 1650
Issue description
Description
It seems that the remote inspector has a bug whenever you change the value of a variable and the new value is of a different type. (And it also seems that this bug only appears when this assignment happens based on user interaction, like pressing a button.)
So the most basic version of this bug can be found when swapping a string with null, for example.

As you can see in this image, the values are set as we would expect by default. I also did not yet press ui_accept yet, so it is correct that the values are not changed yet. But then:

As you can see, the print has been run to confirm that I pressed enter. Even the controll_value changed, but that is only there to show that the inspector does update.
BUT!!, situation1 does not update in the inspector (even though when you print it, it has indeed updated).
Because it started with null, its field in the inspector is not the same type of field as the field that is needed to display strings.
And my guess is that that is the reason why the string can't be displayed now.
And situation2 is here to even further show that, since that was origionally a string, so that started with a string field in the inspector. And you can still see it has a different field, even though it is now null (the 2 situations are both null but both have different fields).

Note that this happens with almost everything that you try if it has the 2 following conditions:

its assignment is activated by user input
its assignment is between 2 different types (null included)
So, this bug appears for forexample: int to string;  int to bool; bool to string,
also your own Resources or nodes.

even int en floats combined. This is even more interesting
If you start with a variable that is an int.
var my_number = 12 and then asign it with a float/decimal number
my_number = 3.42 then what will happen is that in the inspector tab, it will not change the field type, so it will show 3, so it rounded the decimal in the inspector.
(even though it is saved corectly, so doing print(my_number) will print 3.42)
Note that telling what type the variable is does not do anything to prevent this bug.
It indeed fixes the problem for most basic types since if you give them a type, they can only be that type.
But if you are working with for example some custom nodes or classes, then assigning a type to a variable still allows you to make it null. and this problem still continues. when you then initialize it as null.
(so in a survival game with slot you could for example have var currently_active_slot : Slot = null, but since that active slot only changes on user interaction, it would probably never show up in the inspector)
The last bit of information is that the inspector refreshes whenever you save the file. So that means that if you want to manually update the fields to be the correct one, then saving the file again will do the trick.
Comparison to seemingly related bug #39465
At first glance this bug seems to be verry simular to #39465 .
But after some investigation it seems that this is not the same, Thats because there are some differences between the two:

This bug only appears in the inspector panel, but not when you place debugger points and go in the debug panel.
This bug only appears when the asignments are done after an user interaction.
For this bug size does not matter (it even happens for ints and booleans )
For this bug its possible to not only get a wrong display of null, but basicly any type (since thats where the bug is
probably)

Steps to reproduce
So most of it is already explained in the description, but here is a brief sumary and a little code snippet:

To start, create new project, make a scene so you can start the program.
Attach a script to this scene and make sure you keep the _process function
add this input condition (which is pressing enter)
try different variable assignment

This is for example the situation in the screenshots
var control_value = "origional"
var situation1 = null
var situation2 = "i am not null"

func _process(delta):
	if Input.is_action_just_pressed("ui_accept"):
		control_value = "changed"
		situation1 = "i am not null"
		situation2 = null

But you can ofcoarse change all the assignments
var random_preload = preload("res://icon.svg")

var control_value = "origional"
# int <- float
var situation1 = 1
# int <-> string
var situation2_1 = "i am a string"
var situation2_2 = 1234
# null <-> string
var situation3_1 = null
var situation3_2 = "i am not null"
# null <-> object
var situation4_1 : CompressedTexture2D= null
var situation4_2 : CompressedTexture2D= random_preload

func _process(delta):
	if Input.is_action_just_pressed("ui_accept"):
		control_value = "changed"
		situation1 = 2.42
		situation2_1 = 1234
		situation2_2 = "i am a string"
		situation3_1 = "i am not null"
		situation3_2 = null
		situation4_1 = random_preload
		situation4_2 = null

Minimal reproduction project (MRP)
minimal reproduction project.zip

https://www.youtube.com/watch?v=sKxYBUhcoCg
I've created a short video showing different examples, as I find visual representations can sometimes convey information more effectively than written descriptions.


TextInput multiline={true} not functioning as expected

Is this a bug report?
yes

Have you read the Contributing Guidelines?
yes
Environment
Environment:
OS:  macOS Sierra 10.12.6
Node:  8.0.0
Yarn:  Not Found
npm:  5.0.0
Watchman:  4.9.0
Xcode:  Xcode 8.3.3 Build version 8E3004b
Android Studio:  2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: 0.48.3
Steps to Reproduce

Use this input
  <TextInput style={{borderWidth:1,marginLeft:5,marginRight:5,backgroundColor:'transparent',maxHeight:Dimensions.get('window').height/4}} multiline={true}
                 underlineColorAndroid='transparent' placeholder={'write a message'} placeholderTextColor='#8d91a0'/>

Expected Behavior
TextInput would change size each time a line is complete fullfilled
Actual Behavior
each time it takes a 1/3 part of line a padding is added at bottom of text input

The problem is related to version. you need to update react-native to 0.49


Typo in the table of parameters

vanID is incorrect, it is VlanID

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b2b89ce1-6af9-aaa1-48f2-da8d2f5c8b75
Version Independent ID: db6c5f7c-77b2-7a97-dc2c-d904db88edf5
Content: Set up Azure Arc VM management using command line (preview) - Azure Stack HCI
Content Source: azure-stack/hci/manage/deploy-arc-resource-bridge-using-command-line.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @ManikaDhiman
Microsoft Alias: v-mandhiman

@squasta
Thanks for the feedback! We will check and update the document as appropriate.

@squasta
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


FIX: Prevent selecting optimizer dependcy on iteration order of dicti…

Previously, if the optimizer name was 'bfgs' then selected optimizer could be 'org-bfgs' or 'lbfgsb' depending on random order of dictionary keys iterator. Probably, it is possible to better handle optimizer selection e. g. warn about non-precise match of desired optimizer and existing optimizers. But this is a quick fix for unpredictable optimizer selection I encountered with.

Current coverage is 84.02%

Merging #10 into master will not affect coverage as of e24068d

@@            master     #10   diff @@
======================================
  Files           27      27
  Stmts         2335    2335
  Branches       377     377
  Methods          0       0
======================================
  Hit           1962    1962
  Partial         19      19
  Missed         354     354

Review entire Coverage Diff as of e24068d

Uncovered Suggestions

+0.90% via ...es_and_remappings.py#195...215
+0.56% via ...es_and_remappings.py#220...232
+0.56% via ...es_and_remappings.py#179...191
See 7 more...

Powered by Codecov. Updated on successful CI builds.


write.js: split data into chunks on write

Influx times out on writing ~200k points during a single request.
Split the body into chunks of 10k points and send the requests
separately.
What we lose by this is that if single request fails, the previous
writes are not rolled back.

cc: @demmer @dmehra

This looks like a fine improvement, so +1 to merge as is.
However in the future I think it would make sense to integrate https://github.com/juttle/concurrency-master into the write path so that you can bound the number of outstanding requests to the influx backend.

Ok, I'll take a look at that. Also filed #96 about making the chunk size configurable.


Import UT-Assert basics into OSAL

Portions of UT-Assert will be very useful for
unit testing within OSAL, and should be imported
from the official release into the OSAL tree.

Trac comment by jphickey on 2015-06-23 10:21:30:
Commit for review as part of this effort:

[changeset:529354f] - Brings in the basic core pieces of UT Assert into the OSAL build and integrates this with the CMake build so the UT Assert library is built with the rest of unit tests.  Except for the CMake integration, these files are unmodified from their original version in the "official" UT assert release package.

(EDIT - previously I had listed a second commit here, but further testing revealed some dependency complications with that commit.  But the commit above can / should be merged ASAP).

Imported from trac issue 57.  Created by glimes on 2015-06-16T14:35:43, last modified: 2015-11-20T16:22:16

Trac comment by sstrege on 2015-06-29 17:09:21:
The ut_osapi_stubs.c and ut_osfileapi_stubs.c library source files should also be placed in the /ut_assert/src directory.

Trac comment by glimes on 2015-06-30 11:17:20:
... and need to be very careful that OSAL unit tests do not
attempt to use them ... ;)
Recommend we accept something ASAP allowing us to move the
OSAL unit tests (and soon the CFE unit tests) over to using
the common reporting mechanism.
Really really hoping today is the day we stop painting the bikeshed.

Trac comment by jphickey on 2015-06-30 11:23:36:
Replying to [comment:2 sstrege]:

The ut_osapi_stubs.c and ut_osfileapi_stubs.c library source files should also be placed in the /ut_assert/src directory.

Actually, I have placed the OSAL stub functions in a different place so it is not confused with the UT assert core functions.
Note that not all users of UT assert will want to use an OSAL stub library - these need to be separate.  Specific use case here is when unit testing OSAL itself - the "real"(-ish) OSAL is used (not stubs) but the UT assert library IS used.  So having OSAL stubs be part of UT assert core routines would be problematic.

Trac comment by acudmore on 2015-06-30 12:30:48:
Recommend accept

Trac comment by sstrege on 2015-06-30 11:35:33:
OK, thanks.  Where did you place the OSAL stub functions?

Trac comment by glimes on 2015-06-30 13:23:58:
Per CCB meeting 2015-06-30, accepted for inclusion in development.


Confluence: Feature - enable Confluence API v2 support

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[ ] Testing of all the changes has been performed (for bug fixes / features)
[ ] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[ ] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[ ] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[x] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the manual_readme_content.md.
[ ] If this is a new connector or you are adding new actions

[ ] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@mctonderski-splunk what about failing:

sanity-tests
integration-tests
prodsec-scans?

So currently we don't have any asset that supports API v2, it's an ongoing process to get that set up. It was tested on the newest dummy confluence instance.


Roll Flutter Engine from a8dec8426732 to 5e33a1f88a3e (1 revision)

https://github.com/flutter/engine/compare/a8dec8426732...5e33a1f88a3e
2022-08-08<EMAIL_ADDRESS>[Impeller] EntityPass should cover the whole screen for some blend modes (flutter/engine#35157)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


iortcw: add rjpcasalino as maintainer

Description of changes
I still play this game and would like to keep an eye on this package and seeing as it doesn't have a maintainer. @kirillrdy

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

many thanks @dotlambda


Feature configuration by build tag

Separate features like plugin and external services from core package so that the user can pick only needed components for a smaller package. Similar to https://github.com/mattn/go-sqlite3#features

New go build tag design since 1.17: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md


Implemented dash patterns.

Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1091 into master will decrease coverage by 0.02%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   46.25%   46.22%   -0.03%
==========================================
  Files         251      251
  Lines       22504    22519      +15
  Branches     5052     5055       +3
==========================================
+ Hits        10409    10410       +1
- Misses      12095    12109      +14

Impacted Files
Coverage Δ

...re/harp-datasource-protocol/lib/TechniqueParams.ts
51.21% <ø> (ø)
:arrow_up:

@here/harp-materials/lib/SolidLineMaterial.ts
20% <6.66%> (-1.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606423f...cc1bf7e. Read the comment docs.


Remove oc3.10 environment

What does this PR do?
Removed oc3.10 environment for testing, since some of the tests failed which looks like oc3.10
Checklists
Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

@eladkug are we planning to add these tests again in the future? aren't we supporting 3.10 anymore?

@orenbm There is a bug in OC 3.10 that is causing some tests to fail incorrectly, and they're being disabled until we can decide how to approach the problem. Infra's recommendation long-term is that we disable only the problematic tests, and only on OC 3.10, until/unless a better alternative presents itself.


Please attribute Sushi bucket

Hi, I just noticed you starred my bucket Sushi, so I went to browse your projects. I appreciate that you have created a great bucket as well, however I noticed some manifests (such as obsidian and microsoft-edge) are possibly from my bucket but there is no attribution.
Please note Sushi is MIT licensed, which means you must include the license to use the code. In practice, you only have to attribute the projects you are using, which can be put anywhere as long as it is easy to find.

Sorry for the delayed response, I do not check this bucket often. I did not get the email since I un-watched this repo. Yes, I borrowed 3 manifests from Sushi, which are tencent-meeting, obsidian and microsoft-edge. I did not notice the licence issue. So thank you for informing, I will mention the source of these manifests and include the MIT licence.

Thanks for the attribution! I don't mind the delayed response.
Just for your information, you don't have to change this repository's license to MIT (that's not what I'm asking for). As I mentioned above, leaving a link to where the manifest comes from is enough. Ignore this if it's your intention.

I just found that I skipped the conjunction which. It doesn't matter, I happen to need to get knowledge of these licences.


Basic support for native Windows

The first commit allows the following on native Windows:
#require "feather";;
open Feather;;
process "ps.exe" [] |> collect stdout;;

Notice that ps.exe is required for Windows executables (on my system ps.exe comes from MSYS2; theoretically all your examples should work on MSYS2).

The second commit is to add the `.exe`` suffix to all executables on Windows if it doesn't have .exe already.

The let () = Caml.at_exit terminate_child_processes requires that pgrep is available to feather. That means native Windows users must have MSYS2. I've added pgrep to the next release of Diskuv OCaml which I recently announced; that way native Windows users can use feather out of the box.
Thanks for the nice tool!

Hey! Thanks for the PR and sorry for the delay. I'm glad you like Feather!
I think my main problem with supporting windows is that I don't have access to a windows machine or know how to set up one for testing on Github or if they support such a thing for free. Do you have any insights there? I'll review these specific changes if we can resolve that issue, though fair warning I don't have a lot of time to put into Feather nowadays.
Thanks again!
BTW diskuv looks really cool :)

No problem; no urgency: For now I've been building on top of bos but would like to switch to the more full-featured feather when it can be supported correctly.
Testing on Windows + GitHub? I just announced on https://discuss.ocaml.org/t/ann-windows-friendly-ocaml-4-12-distribution-2nd-preview-release-0-2-0/8488/6 that a first version of a Vagrant script was available for macOS and Linux users. For example https://github.com/diskuv/diskuv-ocaml-ghmirror/actions/runs/1506768800 is a GitHub Action running on macOS that builds everything from scratch. Just as important, as long as you have VirtualBox + Vagrant you can spin up a running Windows VM with the full correctly-licensed Windows UI + OCaml.
I'll package that up (in a month or so; I need good documentation) and make a standalone distribution + announcement. Would you be interested in trying that when it is ready? Would you need anything else? Thanks!

I'm sorry to have let this stagnate — I think it's best given my lack of access and understanding of windows to keep Feather unix-only for now and then people can pin your fork as necessary. Happy to revisit if there's interest in the future. Thanks for bringing it up and getting a working solution :)


Fix member auto create test

Have the controller create a member after the user is created.

Moved to controller


Feature or bug? Chrome 61 removes sessions

After updating to Chrome 61 (latest stable), user sessions are deleted form Rack and Chrome gives console error. No other browsers are affected.
Console message:
Clear-Site-Data header on 'http://localhost:': Unrecognized type: {"types":["cache".
(index):1 Clear-Site-Data header on 'http://localhost:4567': Unrecognized type: "executionContexts"]}.
Secureheaders config:
config.clear_site_data = [
"cache",
"cookies",
"storage",
"executionContexts"
]

@EsaMakinen are you able to provide your configuration causing this? #355 and #356 might be of interest to you.

Seems that both tackle the same issue.
My non-functioning config is this, everything works after removing these lines and using it only on logout:
config.clear_site_data = [
"cache",
"cookies",
"storage",
"executionContexts"
]

#355 is the initial bug report where the clear_site_data was being applied to all requests (like your report) whereas #356 contains the updated documentation for using per action configuration which correctly applies the clear_site_data for particular actions.

Thank you. I'll close this issue as duplicate.


extractFederationServiceSDL not removing _entities in Federation V2

Hello
When using the @graphql-hive/client package to publish a schema to a self-hosted Hive for a Federation V2 subgraph service (using the composition-federation-2 Docker image), it publishes an invalid schema with the following error.
Failed to build schema: Schemas couldn't be merged:
	 - [servicename] Unknown type _Any

It appears this occurs because scalar _Any is stripped, but Query._entities is not. Its definition looks like this:
_entities(representations:[_Any!]!):[_Entity]!

Since _Any is not defined as a Scalar, it is unknown.
I was able to track it down to the function extractFederationServiceSDL in the file https://github.com/kamilkisiela/graphql-hive/blob/main/packages/libraries/client/src/internal/reporting.ts. It looks like _entities is missing from the federationV2.queryFields Set. Manually adding _entities to the Set in my node_modules folder resolved the issue for me.
Please let me know if you have any questions or need any other info.
Thanks for the work you are doing!

Thank you for reporting this, I fixed it in #1357


Suggestion for metric: eTaPR

Implementing this metric should be relatively easy as the code and pip package in Python are available here: https://github.com/saurf4ng/eTaPR

Thanks for the suggestion. We currently don't have the time to do this ourselves. In addition, TimeEval already supports many evaluation metrics and everybody can use additional metrics by inheriting from the Metric-base class and providing it to TimeEval (cf. example in its documentation).
However, we welcome contributions to TimeEval and you are invited to submit a PR. Please let us know beforehand so that we can discuss how we want to integrate it.
Additional notes

There is no package published to PyPI (https://pypi.org/search/?q=etapr), which means we need to re-implement the metric or integrate the existing code into TimeEval.
The metric works on anomaly predictions instead of anomaly scores and also requires a thresholding strategy, such as our other classification metrics.
The dependency on open-cv could be troublesome.
Uses 1/-1 instead of 0/1 labels.


brave: 1.37.109 -> 1.37.113

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for brave is: "Privacy-oriented browser for Desktop and Laptop computers"
meta.homepage for brave is: "https://brave.com/"
meta.changelog for brave is: "https://github.com/brave/brave-browser/blob/master/CHANGELOG_DESKTOP.md#137113"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113/bin/brave had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113/bin/.brave-wrapped had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 1.37.113 with grep in /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113
found 1.37.113 in filename of file in /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
brave

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A brave https://github.com/r-ryantm/nixpkgs/archive/8838263f3ca36f8d5b7354aa780d9114f395d0c1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113
ls -la /nix/store/1adn77xzxhfj9af80hsf439sw9grlq8d-brave-1.37.113/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

brave

Maintainer pings
cc @uskudnik @rht @jefflabonte @nasirhm for testing.

Tested webcam, microphone, screensharing, audio/video, webgl. Works fine.


fix: fixes mapping on snoretoast activate event, fixes #291

The mapper-function for the resultantData did not map "activate" to "click", so fixed the mapper to handle this.
This introduces a breaking change.

Brilliant. This should fix #291 finally. Good work.
Unsure what to do with this as a version update though. Think this might be a major version bump, even though it technically was a bug as the API has changed.

Looking forward to this fix! It sounds like a major version update to me @mikaelbr since it has a breaking change

This PR doesn't actually fix #291 in Windows, and it appears to have no observable effect at all.
Here's the sequence of events:

For some reason, the pipe used to communicate with snoretoast-x64.exe (v0.7.0) gets no data when the Windows notification is clicked (i.e., the EXE outputs no text for the click).
In the pipe callback, resultBuffer (which holds the pipe's data) is set to an empty string.
In snoreToastResultParser(), resultBuffer is parsed into an empty object, which is passed to a callback -- specifically utils.actionJackerDecorator().
In utils.actionJackerDecorator(), the empty object argument causes the activation type to be undefined, which is passed to the userland notification callback. Normally, the activation type would be 'activate' in this case.

A simple workaround is to default the activation type to 'activate' in utils.actionJackerDecorator():
resultantData = resultantData.activationType || 'activate'; // lib/utils.js#L264

This PR doesn't actually fix #291 in Windows, and it appears to have no observable effect at all.
Here's the sequence of events:

For some reason, the pipe used to communicate with snoretoast-x64.exe (v0.7.0) gets no data when the Windows notification is clicked (i.e., the EXE outputs no text for the click).
In the pipe callback, resultBuffer (which holds the pipe's data) is set to an empty string.
In snoreToastResultParser(), resultBuffer is parsed into an empty object, which is passed to a callback -- specifically utils.actionJackerDecorator().
In utils.actionJackerDecorator(), the empty object argument causes the activation type to be undefined, which is passed to the userland notification callback. Normally, the activation type would be 'activate' in this case.

A simple workaround is to default the activation type to 'activate' in utils.actionJackerDecorator():
resultantData = resultantData.activationType || 'activate'; // lib/utils.js#L264

I'm seeing the same thing as @tony19: this doesn't do anything, at least on Windows 10 20H2. The pipe never gets written to upon activation of the notification, which I believe is a bug in snoretoast which I've fixed here: https://github.com/viviedu/snoretoast/commit/c5faeceaf36f4b9fb27e5269990b716a25ecbe43
With this change, everything suddenly starts working, both plain activate events and actions passed as buttons.
I'm not sure how it's working at all for some people?


cluster autoscaler: fix typos

/cc @mwielgus

This change is

LGTM

Thank you for fixing these typos.

@mwielgus can you try using the /approve to get the PRs merged.  It seems to be working https://github.com/kubernetes/contrib/pull/2326 but we could use some more feedback/testing.


Marten reset all data helper does not work with wolverine managed projection assignment

Don't think this is really too hard. Just add an implementation of IProjectionCoordinator to the IoC database

It's as much in Marten as Wolverine. Double check the null checks for ProjectionCoordinator in Marten checks to see if the _runner is initialized

Nah, took some effort with a custom wolverine approach


Add info about ARM to download.html

What this PR does / why we need it
Need to let users know early that they cannot dap;loy clusters on M1 Macs and other ARM systems.
Details for the Release Notes (PLEASE PROVIDE)

Please also add this notice as it appears here, or language from @joshrosso or @kcoriordan, to the release notes.

## Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes: #

## Describe testing done for PR
<!--
Example: Created vSphere workload cluster to verify change.
-->

## Special notes for your reviewer
<!--
Add any things that reviewers should be aware of as they review
your PR.

Example: Please verify how I handled foo aligns with overall plan.
-->

cc: @kcoriordan to get thoughts on this and placement

Looks good, ideally all prereq info should be kept in one location in docs so that it's simpler to keep up to date - one source of truth, but as this is an important upfront note,  I would just add a link to the prereqs in the docs. So add:

For more information, see Support Matrix

Looks good, ideally all prereq info should be kept in one location in docs so that it's simpler to keep up to date - one source of truth. But as this is an important upfront note, I would just add a link to the prereqs in the docs. So add:

For more information, see Support Matrix

@kcoriordan did we want to incorporate this feedback?


Allow annotation level to be configured for Github Action

Currently, findings are always reported in the github action as failure level findings. This is hardcoded here: https://github.com/nightfallai/nightfall_code_scanner/blob/92a6b9ab2e9e93a83cb5a6d8179d370813d1a64e/internal/clients/diffreviewer/github/github_service.go#L37
We would like to pilot this action running on our PRs, with the findings reported at a notice or warning level. This will make the tool slightly less noisy while we evaluate the false positive rate internally and fine tune our configuration.
It would be great if you supported configuring the level that findings should be reported for your github action. From our perspective it would be useful either in the github workflow configuration itself:
      - name: Checkout Repo Action
        uses: actions/checkout@v2

      - name: nightfallDLP action step
        uses<EMAIL_ADDRESS>        env:
          NIGHTFALL_API_KEY: ${{ secrets.NIGHTFALL_API_KEY }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          EVENT_BEFORE: ${{ github.event.before }}
          ANNOTATION_LEVEL: warning

or secondarily as a separate entry in the .nightfalldlp/config.json. If in the nightfall config, then it might be a little strange unless this is promoted to a full nightfall level concept. The advantage would be it could be configured at a per detection rule level, but this greatly increases the scope of this ticket.
For reference, these are the supported levels (docs):

Hello, bumping this issue. Could we please get some attention on it?

I made the change - as you can see in the PR above. Do you want the action to still fail even if there are no failure annotations? Here is the example: https://github.com/nightfallai/nightfall_code_scanner/runs/6765737417
these are the options:

Thanks @Dhertz! We just had a discussion about it, and we think the following logic makes sense:
If there are failure annotations, then the conclusion should be a failure.

If there are annotations but no failure annotations, then the conclusion should be neutral.

If there are 0 annotations, then the conclusion should be a success.

Is that possible?

Great, I have updated to have that logic, and this is what a run with notice annotations looks like:

You can see more here: https://github.com/nightfallai/nightfall_code_scanner/runs/7350284060?check_suite_focus=true

This is now available in https://github.com/nightfallai/nightfall_dlp_action/releases/tag/v2.1.0


postgres override select_table_unique_columns

This method is used when SUPPORTS_UNIQUE_CONSTAINT = True, and it's causing an exception for postgres tests in data-diff due to the base method not handling a 3-part id.

@dlawin Does this mean we need a new release once this is merged?

yeah I think we need to increment the version, otherwise folks could get stuck on the bad version of 0.0.6

Confirmed this branch fixes the data-diff tests here: https://github.com/datafold/data-diff/pull/430


Added Tab Panel Component

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Added a tab panel component

What is the current behavior? (You can also link to an open issue here)

no tab panel

What is the new behavior (if this is a feature change)?

Now there is a tab panel

Other information:

I'm going to close this.  I'll see if I can match the style used in the original blur rather than what I did here.  and submit another pull.


Super tiny fix dead link

Currently:

gives:

but if manually navigate to:

it works:

Thanks!


Time Zone Convertor

Description of the new feature / enhancement
Allow us to convert time zones in specific cities.
ex:
20 :35:28 - UTC-07:00
Phoenix, Arizona (most, United States)
Scenario when this would be used?
I speak to people all over the country and I deal with appointment times so this would be absolutely amazing for me. I am sure many users planning to use this feature for work could benefit. Not to mention (excuse my ignorance if I am incorrect) it seems like a relatively easy feature to implement! :)
Supporting information
No response

I actually think for something like this, cities is going to be hard.  With the current implementation, we can be naïve. Where if a city changes time zones due to larger rules, we would need to be aware.  We would have to proactively query stuff versus just leverage the OS APIs.
Then it also goes to what scope of size of city and not to mention different ways to spell the city depending on language.  I wonder if there may even be geopolitical stuff that would need to be accounted for as well.
We can keep it open but i think this is one of those "it looks simple" but really is far more complex.

I wonder if you could pull from the baked in Excel database that kinda does
the same thing.
Anyways, thanks for the response. Pretty cool.
On Mon, Mar 28, 2022 at 11:25 AM Clint Rutkas @.***>
wrote:

I actually think for something like this, cities is going to be hard. With
the current implementation, we can be naïve. Where if a city changes time
zones due to larger rules, we would need to be aware. We would have to
proactively query stuff versus just leverage the OS APIs.
Then it also goes to what scope of size of city and not to mention
different ways to spell the city depending on language. I wonder if there
may even be geopolitical stuff that would need to be accounted for as well.
We can keep it open but i think this is one of those "it looks simple" but
really is far more complex.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/17013#issuecomment-1080994618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVXD2V2WOMGPHZHE4D46JTTVCH2SFANCNFSM5QSYVY7A
.
You are receiving this because you authored the thread.Message ID:
@.***>


Added useful commands and more to reset/README

Added "What does does your stage look like" to the beginning of the task. This makes the initial questions better match the later question "What happens to your working directory, your log and your stage?"
Added useful commands section.
Added a further explanation section. Is this okay? For people doing these katas without an instructor (like myself), a pointer to a good explanation of complex commands would be useful. If you don't like it, then it should be deleted.

Hi Brent,
awesome work.
I don't think we should hold out, or have exercises that try to actively hoodwink the exercisee, disregarding whether they are in a class, or tinkering on your own as you are :)


multipart/form-data requests don't work with other form parameters

How to post other form parameters in content type of multipart/form-data ?
such as  payload in before.
Version: 10.0.5

@liubin9 Did you find a workaround? I am struggling with the same issue.

@mrvincenzo What do you mean a workaround? What you are missing?

@jarrodek I am missing the option to copy paste a body request as a whole. As for today I need to add all parts separately which is very annoying in my case. Before the change, I was able to copy & past a complete form-data body into the reset client.

@mrvincenzo I wasn't aware of such use case. Can you crate a new issue for that? It's different from this issue.
Although I'll try to update it asap.

@jarrodek I've created a new issue https://github.com/jarrodek/ChromeRestClient/issues/1100


(bug) Fetching/processing the announced-suburbs list generates KeyError

  File "/Users/simonroberts/src/github/lyricnz/nbn-upgrade-map/code/adhoc_tools.py", line 73, in <dictcomp>
    return {data.STATES_MAP[state]: [s.title() for s in suburbs_list] for state, suburbs_list in results.items()}
KeyError: 'NSW'

I guess they changed the page layout a bit

get_nbn_suburb_dates() is also broken

(Unless you know of one...) It looks like there isn't a page listing all the announced suburbs, only the one with the suburbs-dates.  I'll update the adhoc code.

@LukePrior should we removed "announced" from the suburb data, and use announced_date is not None?

Yeah, that sounds like a good course of action

Done

Fixing https://github.com/LukePrior/nbn-upgrade-map/issues/261 in the same PR now. Sec.

@LukePrior I think I'm going to need the auto-processing stopped, so I can get this merged cleanly.  We're fighting merge conflicts with combined-suburbs.json having the "announced" field removed.


New Room - Translate Room visibility - Reported by: @Manan Jadhav

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com
Log in with expensifail account
Set language to Spanish
Click on Plus button and Click on New Room
Check room visibility options

Expected Result:
Room visibility options should be translated
Actual Result:
The translation is missing in WorkspaceNewRoomPage  for ExpensiPicker .
Room visibility options are in English only even if I've set the language as Spanish
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.20-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Manan Jadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639334834136500
View all open jobs on GitHub
view this job on upwork

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal if made external
The translation is missing in ‘WorkspaceNewRoomPage’ for ‘ExpensiPicker’. We should reference them then with translate and relevant language files.
  <ExpensiPicker
                        value={CONST.REPORT.VISIBILITY.RESTRICTED}
                        label={this.props.translate('newRoomPage.visibility')}
                        items={[
                            {label: this.props.translate(CONST.REPORT.VISIBILITY.RESTRICTED), value: CONST.REPORT.VISIBILITY.RESTRICTED},
                            {label: this.props.translate(CONST.REPORT.VISIBILITY.PRIVATE), value: CONST.REPORT.VISIBILITY.PRIVATE},
                        ]}
                        onChange={visibility => this.setState({visibility})}
                    />

and add relevant restricted and private keys to en.js and es.js

Current assignee @jboniface is eligible for the External assigner, not assigning anyone new.

unsubscribe
On Tue, Dec 14, 2021 at 4:34 AM MelvinBot @.***> wrote:

Current assignee @jboniface https://github.com/jboniface is eligible
for the External assigner, not assigning anyone new.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/6733#issuecomment-992710429, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACG62DQBJNDGNISG5VDLIDUQYVD7ANCNFSM5J6KEB4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@mvtglobally My Github username is @mananjadhav. Guessing the space caused it to send the notification to somebody else. Can you please correct it?

https://www.upwork.com/jobs/~01e07d655b1bb33138 posted

Triggered auto assignment to @parasharrajat (Exported)

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav Your proposal looks good to me https://github.com/Expensify/App/issues/6733#issuecomment-992609576. :+1:
cc: @puneetlath
:ribbon: :eyes: :ribbon:

Sounds good to me too. @jboniface let's go ahead and hire @mananjadhav for the job in Upwork.

📣 @mananjadhav You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@mananjadhav you can ask for translations in Slack in #expensify-open-source. Thanks!

Unsubscribe me please
On Wed, 15 Dec 2021, 4:10 am Puneet Lath, @.***> wrote:

@mananjadhav https://github.com/mananjadhav you can ask for
translations in Slack in #expensify-open-source. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/6733#issuecomment-993795006, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACG62HMX4V722SZP5532Q3UQ53A5ANCNFSM5J6KEB4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@manan sorry that we used the wrong username and tagged you on this issue. I'm not seeing any way to unsubscribe on your behalf. But you should be able to stop receiving notifications if you click the "unsubscribe" button on the right side of this issue.

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.22-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6786

If no regressions arise, payment will be issued on 2021-12-28. :confetti_ball:

@mananjadhav can you accept offer in Upwork + then we will issue payment? Thanks

@laurenreidexpensify Done

paid 👍🏽


'trigger' property as an array

I was looking for a component to manage mention suggestion in my app and I found yours. The only problem is that I also need in the same input a hashtag suggestion.
I can't do it with your component because the prop trigger only accepts a string.
Do you think we could change this to also accept an array of string (['@', '#'] for my case)?
If you think it could be added to your component but you don't have time to implement it just tell me and I will create a PR for that.
Good job for the component!

@theohdv Have to work on this?


Incorporating changes ahead of writing user stories for MVP

Making some UI changes based on user research and adding in navigation so that users of the public prototype can find the Beta prototyped pages.

Withdrawing pull request in order to fix some conflicts.


feat!: migrate to ESM

What does this PR do?
Migrate to ESM
What issues does this PR fix or reference?
@W-14487112@

qa: generated a plugin for internal and external.
✅ looked ok
✅ internal had the salesforce copyright header stuff, external didn't
✅ internal had the top-level license.txt file, external didn't


Unable to access to sandbox

Hi guys!
I'm trying to connect to the sandbox environment. However, every time I try it, I receive an error message. If I make a API call to the normal environment, it works successfully. I.e, I have this error for order.getOrders.
let orders = await sellingPartner.callAPI({
        operation: 'orders.getOrders',
        query: {
          MarketplaceIds: 'A1RKKUPIHCS9HS',
          CreatedAfter: '2022-01-01',
          OrderStatuses: 'Unshipped',
        },
        options: {
          version: 'v0',
        },
      })
      let order
      console.log({orders})

orders value is
orders: [
    {
      code: 'InvalidInput',
      message: 'Could not match input arguments'
    }
  ]

I create the SDk object like this:
const sellingPartner = new SellingPartnerAPI({
    region: 'eu', // The region to use for the SP-API endpoints ("eu", "na" or "fe")
    refresh_token:
      'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
    credentials: {
      SELLING_PARTNER_APP_CLIENT_ID:
        'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
      SELLING_PARTNER_APP_CLIENT_SECRET:
        'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
      AWS_ACCESS_KEY_ID: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
      AWS_SECRET_ACCESS_KEY: 'xxxxxxxxxxxxxxxxxxxxx',
      AWS_SELLING_PARTNER_ROLE:
        'arn:aws:iam::xxxxxxxxxxxx:rolw/xxxxxxxxx',
    },
    options: {
      use_sandbox: true
    }
  })

I don't rule out that it's my fault, I'm pretty new to the Amazon SP API. If so, I would like to improve the README for sandbox mode.
FYI: I'm using<EMAIL_ADDRESS>on node 12

HI @sandalija,
the problem is probably that you can't use any value as input when using the sandbox. You would have to take a look at the model and search for x-amzn-api-sandbox. This will tell you what input you need to pass in for the corresponding endpoint.


Gateway resources consolidation

What this PR does / why we need it:
This PR aims at consolidating and factorizing the gatewayClass and Gateway resources across all the integration tests, to remove duplicated code and improve code quality.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2461
Special notes for your reviewer:
You can find the PR's change list below:

All the explicit instantiation of GatewayClass and Gateway objects, followed by the respective GatewayV1alpha2().GatewayClasses().Create() and GatewayV1alpha2().Gateway().Create()  function calls have been replaced by a helper call. These helpers are in the helpers_test.go file.
Each function that needed a gatewayClass, created it at the beginning and deleted it at the end of the test (via a deferred function). Since about 90% of these objects were copypasta from one test function to another, a unique shared GatewayClass is now created at environment setup time; this object creation is in the suite_test.go file. Each needed GatewayClass different from the default one is created through the aforementioned helper.
The files tlsroute_test.go, tcproute_test.go, httproute_test.go, and udproute_test.go used specific helpers to check the linking or unlinking of the routes from the Gateway. They were copypasta one from another. They have been deleted and factorized in a unique function with two additional parameters:

protocolType: to specify the protocol to check
ensureLinked: to specify whether to check the linking or the unlinking

The cleanup in each test case has been made uniform by using the utility suggested in the comment below. NOTE: only the files under refactoring have been subjected to this change.
Minor name refactoring throughout the touched files.

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

While you're in here refactoring tests @mlavacca, I wanted to mention that in recent weeks KTF has gotten a new cluster cleanup utility:
https://github.com/Kong/kubernetes-testing-framework/blob/main/pkg/clusters/cleanup.go#L27
There are some examples of its use in the GWO:

https://github.com/Kong/gateway-operator/blob/main/test/integration/gateway_test.go#L38
https://github.com/Kong/gateway-operator/blob/main/test/integration/gateway_test.go#L51

Not saying this is required as part of this work you're doing so don't consider it a blocker by any stretch of the imagination, but since you're already in here doing some test cleanup if you would like to clean up some of the myriad defer functions which clean up individual items this could be employed to do so.

Would it be too much to ask for If I'd suggest to put a summary of what were the goals of this refactoring? e.g. what were the functions/methods/structs/interfaces added/removed? 🙏
Given +650 −1,269 and the fact that it touches many files it's a bit hard to review reliably.

Would it be too much to ask for If I'd suggest to put a summary of what were the goals of this refactoring? e.g. what were the functions/methods/structs/interfaces added/removed? 🙏
Given +650 −1,269 and the fact that it touches many files it's a bit hard to review reliably.

I updated the PR description to summarize the changes.

Looking good, I really do appreciate the emphasis on cleaning up some of our test code, and I particularly like that we're switching over to the KTF cluster.Cleaner for cleanup because that saves a lot of space (don't forget to resolve #2618 if this does indeed update that for all cases).

I used that cleaner only in the files touched by this refactoring. There are many other tests that still use the old cleaning approach.

@pmalek If you don't pass the variable testing.T to the function, you end up in a situation in which you are not able to log anything related to the test (unless we start using another logger): you just return false, and the callback is retried after a while. In this scenario, Whenever a GET fails, it's hard to spot the reason.
For what concern retrying a prior all the GETs, in a real environment I would definitely agree with you, but during tests, I'm not sure it is relevant. Given my thought, I have no problem in replacing the require.NoError(t, err) with t.Log() and return false afterward. But the point raised by Shane was to not pass the testing.T instance at all, and if we follow this approach, we are not able neither to break the test because of the error nor to log the error.

@pmalek If you don't pass the variable testing.T to the function, you end up in a situation in which you are not able to log anything related to the test (unless we start using another logger): you just return false, and the callback is retried after a while. ...

... the point raised by Shane was to not pass the testing.T instance at all, and if we follow this approach, we are not able neither to break the test because of the error nor to log the error.

I somehow got fixated on the logging part of it and dismissed (in my head) Shane's concerns.
So, I do agree with what was brought up (w.r.t. passing testing.T) and having an unexpected assertion fail the test and abort it (from a distance), I also believe that not having relevant logs in case of a failure are a sever debugging hindrance.
(Perhaps there's a better way to approach this but) I'd suggest to do pass the testing.T to the helper, but use it mostly for logging and make the eventuallyGatewayIsLinked return bool so that it can be used in .Eventually().
If need be we can create an issue and revisit passing the t into that helper.

OMG, instead of commenting I edited your comment @mlavacca 😠 sorry for that. Should be reverted already now.

(Perhaps there's a better way to approach this but) I'd suggest to do pass the testing.T to the helper, but use it mostly for logging and make the eventuallyGatewayIsLinked return bool so that it can be used in .Eventually().
If need be we can create an issue and revisit passing the t into that helper.

@pmalek I followed this approach: the testing.T instance is passed to the function only for logging purposes. Furthermore, I added a callback builder to follow Shane's idea. This concern should be completely addressed, I don't think we need to create a follow-up issue.

Ideally, I'd like Shane to resolve his reservations

Ideally, I'd like Shane to resolve his reservations

Ok, let's wait for Shane's feedback. I have put the do-not-merge label.


Continue pretraining on custom dataset

First of all very nice work! I love the idea with a discriminator and that the current model architectures is even more capable if its given a more difficult pretraining task.
Unfortunately I think I have to bother you with a problem. I was planning to continue pretraining on the models with domain specific data for some experiments but the neccessary data is not in the released models.
raise type(e)(node_def, op, message) tensorflow.python.framework.errors_impl.NotFoundError: From /job:worker/replica:0/task:0: Key discriminator_predictions/dense/bias/adam_m not found in checkpoint          [[node save/RestoreV2 (defined at tensorflow_core/python/framework/ops.py:1748) ]]
(unrelated)
A 60k test run on the cord19 dataset with eval:
https://tensorboard.dev/experiment/QwOMXKluQJKcn8D9i9p69A/#scalars

@ViktorAlm Dis you solved this problem? I am encountering the same issue.

The necessary inputs from the training is not in the files, you would have to load the weights in from another checkpoint with everything in it or something. I'm not not sure exactly how, it was just an experiment on my part so it wasnt that much of an issue for me. I'm just speculating though.

@clarkkev I suffer similar problem here, do i have to specify checkpoint or something? electra-small can't continue as you mentioned in readme.
thanks in advanced, here is my command
python3 run_pretraining.py --data-dir ori-vocab-data-mda --model-name electra_small --hparams '{"model_size": "small", "num_train_steps": 4020000, "electra_objective": true, "vocab_file": "ori-vocab.txt", "learning_rate": 1e-1, "train_batch_size": 128, "generator_hidden_size": 1.0}' date


sysdump: Use --hubble-flows-timeout flag

Timeout was hardcoded to be 5 seconds, and --hubble-flows-timeout was
not being used.
Fixes #907
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

tested with
./cilium sysdump --hubble-flows-timeout=20s --debug | ts "[%H:%M:%S]"

debugging external workload failure. converting it to draft.

thanks for the review @tklauser! i'll spend one more day on the external workload failure. once i merge the PR i tend to move on and forget about the CI issue 😹

@michi-covalent I've also opened #910 to debug the CI issue, so we could also continue there. Whatever you prefer 😄

i didn't do anything but now it's passing 😑

ok let's use https://github.com/cilium/cilium-cli/pull/910 to track the external workload failure, not sure if we can reproduce it though 😢


feat: add NoopTransactionPool impl

Adds a TransactionPool impl that does nothing besides satisfying the trait

This is useful for wiring components together that don't require an actual pool but still need to be generic over it.

Will replace the testing_pool() in my example w/ this


bootstrap: remove open-vm-tools requests

open-vm-tools RPM is still requested in bootstrap manifests

/retest

/retest


New UI - Edit Profile Page

Screenshots of the changes (If any) -
Desktop view:

Mobile view:

Coverage remained the same at 84.266% when pulling 571490ca5bebb4b6a6f486ca5cf1b6564e4d0dc5 on yash15601:New-UI-Edit-profile-page into 087e1aedf0159e83d3257d6e50ce446f978c23c3 on CircuitVerse:master.

@nitin10s @aayush-05  Review this Edit profile page ui

Also, in the line below Edit Profile, the asterisk should come before "are". And try using class "btn-about" for save button and maybe increase the label text size.

Will do this today 😇

@nitin10s  @aayush-05  Review please

@nitin10s  its almost over i fixed that you can see screenshot

@nitin10s  Review

@yash15601 Please fix the code climate issues.

@nitin10s  review  please all the issues are basic issues not to worry about i have fixed some of them

The inputs are of different width

@nitin10s

its working fine you can see this

Please fix the codeclimate issues.

i will fix the code climate and also squash the commit

-Fix codeclimate, accesslint issues and mark the ones as resolved which you have fixed
-Make the save button a little bigger
-Don't remove any code, add your additional classes if they are conflicting

-This haven't been fixed (try using the asterisk code (*) instead)

@yash15601

@aayush-05  work in progress

Can you close this and open new PR once linting issues are resolved, difficult to track here as too many linting error messages

@tachyons sure will open new one