Slow schema import time

I'm currently building a small app with strawberry django.
I'm using:

strawberry==0.151
strawberry-graphql-django==0.8.2
strawberry-django-plus==0.132

I've noticed a slower django boot time than usual. (around 10s on my recent dev computer)
cProfile show me that most of the boot time is passed into my schema import (schema.py) which is responsible of importing all strawberry types
There are 11 django.type classes, and 11 django.filter classes. Many of them a linked to each other.
Here the cProfile output for the command : python -m cProfile -o django_boot.cprofile  manage.py check
django_boot.cprofile.zip

Hi @fabien-michel! Thanks for the report. Wow 10 seconds seems like a lot, I'll try to replicate it in the next few days.
Also, @bellini666 have you had any issues with slow starting time?

Indeed 10 seconds seems a lot!
@patrick91 no, no slow starting times, and I have a lot of types/django-types/filters/etc
@fabien-michel are you seeing the slow starting time in run_server or when running an ASGI worker? Also, what ASGI implementation are you using?

We have a similar problem in our project - the strawberry imports are taking 17.7 seconds.
We are adding this as a router to FastAPI which is running in uvicorn.
I'll see if I can put together a standalone repro.

I'll see if I can put together a standalone repro.

Just a quick update on the repro. A simple standalone repro fails to reproduce the problem (of course 😄). So it's entirely possible that it has nothing to do with strawberry, but that's just where the PYTHONPROFILEIMPORTTIME gun is pointing. I'll keep digging...

Recently upgraded strawberry and the import slowness is gone. Thanks for the amazing works !


Tracer and wrapped session for GPflow

Not to be merged yet.
This PR currently allows one to switch on a profiling mode that stores a tracer file for calls to tf.session.run . It can be set to store a tracer file for each such call or only the last one.
To do this there are two key concepts:

TensorFlow itself has the ability to do this either for both CPU and GPU processes. They key commands are

run_options = tf.RunOptions(trace_level=tf.RunOptions.FULL_TRACE)
run_metadata = tf.RunMetadata()
sess.run(res, options=run_options, run_metadata=run_metadata)
tl = timeline.Timeline(run_metadata.step_stats)
ctf = tl.generate_chrome_trace_format()
with open('timeline.json', 'w') as f:
   f.write(ctf)

TensorFlow (oddly) does not have the ability to do this every time with some constant run_options. Therefore I have wrapped all calls to session in GPflow. We can then use either a standard tf.Session or a special new class that has the same interface as the normal session but is running and storing the traces each time. I have done it this way to minimize the impact on the rest of the code.

I can imagine we might want other interfaces for the profiler which is why I'm doing the PR a bit early.
I still need to write unit tests and update the existing ones.
An example script is provided in notebooks/example_profiler.py

Current coverage is 96.48% (diff: 42.66%)

Merging #174 into master will decrease coverage by 2.78%

@@             master       #174   diff @@
==========================================
  Files            20         22     +2
  Lines          1524       1595    +71
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1513       1539    +26
- Misses           11         56    +45
  Partials          0          0

Powered by Codecov. Last update 67cfd5d...d7fdaf2

@jameshensman @markvdw  it would be good to decide what we want to do with the interface on this one so we can get it in. I suggest that we do something a bit different from what we have currently on this PR.
How's about having three config flags, one for training profiling, one for test profiling and one for the output directory stub. The code would automatically output a file for each call to sess.run in each case so we end up with a directory containing integer labelled files e.g output_directory/profiling/training/timeline_1.json . This directory get big quickly so we would have to warn the user when the software is run in this way.
Thoughts?

Hmm, if we are to have automatic speed testing, we need to be able to switch profiling on and off from within the code, right? The config currently doesn't allow this.
Otherwise, I think this would be a nice way to switch profiling on and off. It would make it possible to profile code without any changes in the code.

Why would we need to switch it on in the code? We could just have a local
gpflowrc that turns the profiling on?
On Fri, 9 Sep 2016 at 14:51 Mark van der Wilk<EMAIL_ADDRESS>wrote:

Hmm, if we are to have automatic speed testing, we need to be able to
switch profiling on and off from within the code, right? The config
currently doesn't allow this.
Otherwise, I think this would be a nice way to switch profiling on and
off. It would make it possible to profile code without any changes in the
code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GPflow/GPflow/pull/174#issuecomment-245918683, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJbDzBCxueCcPCroKwhlKoZBetpLP3Eks5qoWRUgaJpZM4JpxeJ
.

Well, I was thinking that for a testing script, it would be nice to have something like:
config.profiling.doit = True
for benchmark in benchmarks:
    config.profiling.output = benchmark.output_dir
    benchmark.run()

And it would be nice if that could be run out of the box, directly after a clone. What ideas did you have for the workflow?

@alexggmatthews , what's the status of this PR? We now have the ability to set things in the gpflowrc file to specify if we want the json files to be dumped. I would love to have this ability for one of my projects.

@jameshensman I agree it would be good to get tracing in and I'm happy to finish this. It has been a while so I'm reloading this PR in to my mental cache!
The config file helps. If I remember rightly, I don't think we fully pinned down what we wanted from the interface. Do we want it to produce a .json file for every training tf.run call? This could get large pretty quickly. What about test time? What do we want to do with the file names of the json files?

I think we should just dump the last run. I don't see that dumping multiple runs is very helpful.
Here's my preferred option for the filenames:

prescribe a file prefix in gpflowrc
add a string giving the name of the function being called to the string, plus '.json'

the name of the function should be accessible to AutoFlow via name. For the main function, use 'objective'. So we might end up with
my_prefix_objective.json
my_prefix_predict_f.json
my_prefix_predict_y.json

, for example.

Is there a plan to include tensorboard support. I see there is an option in gpflowrc but it is not used in the code. I added some simple code myself to track the likelihood evolution for example, useful for long training times like mnist. Maybe it already exist in some branch (there are too many branches imo)?
Of course adding metadata to the graph (compute speed, memory) should be optional, but I think tracking some summary statistics is cheap enough.

Hi @icouckuy
As far as I know, Alex's plan is only to extract the json file that describes the runtime of the graph. A separate commit for tensorboard support would be welcome, but without much experience of tensorboard I don't know what would be needed.  Perhaps @alexisboukouvalas can comment?

Similar to what @icouckuy has described I did write some code to track summary scalar statistics and display them in tensor board. However I did not get anything particularly nice and useful out of this and would welcome ideas for better support. I am happy to help with this, @icouckuy perhaps you can make a PR from your changes to get the ball rolling?

tensorboard was discussed in #116 so perhaps best to switch discussion over there. Feel free to reopen.

Hi Alex, I'm interested in reviving this. Have you had any thoughts in the meantime?

I fixed a few merge conflicts. @alexggmatthews, what in particular were you not happy about, regarding this code? I think with a bit of cleaning it can go it.
Regarding the code interface that @jameshensman suggested, this could be implemented as follows:

Depart from the abstract base class idea
getSession() accepts all the arguments to tf.Session() plus some extra arguments like the function name.
getSession() actually constructs the object, rather than returning the class. If we're profiling, the extra arguments for function name, output file etc, get passed to the constructor, otherwise a normal tf.Session() is created.

This requires SessionFactory to be aware of the object it will be returning, which the abstract base class setup avoids. I don't think this is a huge problem though, since we only have two Session-like classes.

Ok, here's my suggestion for some edits to finalise this. It's pretty much the same idea, only with the above suggestions added. All profiling can be switched on and off through settings, either by modifying gpflowrc or by GPflow.settings.profiler.dump_timeline = True.

@markvdw I've added some comments and obviously we'll need unit tests. Generally looks fine to me. Given that we've both worked on it we'll probably need @jameshensman to review it as well.

Great. For unit tests, it's hard to check whether the profiling is actually being done. The best I can come up with is to check whether the correct files are being created.

I like this design, seems sensible and unobtrusive to me. I like that by default it just uses a standard session.
I agree that it's hard to think of thorough tests. I suggest running a TracerSession, making sure that the file is written to disk, making sure that the file is not empty. Then making sure that running model without a tracer session does not do those things (i.e. making sure that the default still works).

Correct, but we are already mandating some kwargs, so feels tidier this
way.
On Tue, 17 Jan 2017 at 17:29, Mark van der Wilk<EMAIL_ADDRESS>wrote:

@markvdw commented on this pull request.
In GPflow/session.py https://github.com/GPflow/GPflow/pull/174:

@@ -0,0 +1,77 @@
+import os
+import warnings
+import tensorflow as tf
+from tensorflow.python.client import timeline
+from ._settings import settings

+class TracerSession(tf.Session):

def init(self, *args, **kwargs):

This won't allow *args to be passed to tf.Session I believe. Not a huge
problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GPflow/GPflow/pull/174, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJbDxJBdz1ichKMTjkohp_qL_tc8WzHks5rTPpwgaJpZM4JpxeJ
.

Right, I think this can be merged now. I cheated by adding 3 lines of # pragma: no cover on a check for whether there are any conflicting run options. We don't actually do this anywhere in the code, so I thought it was justified.


stop cookie name growing each time session is saved

I think this is a mistake: I end up with a longer key (one more 'cookie name' prefix) when I call get_session and this gets persisted to the browser if the session is saved
Also, I want to handle the case where the session in redis expires but the cookie is still present in the user's browser.

Thanks for report. My fix is a bit different from your proposal but follows your idea.
I've released 0.1.1 for that fix.

Works for me. Many thanks.


Fix related topics

Basic Security Audit Policy Settings had a related link that pointed towards itself. Is now deleted.
Basic Security Audit Policy Settings added as related link for Advanced Security Audit Policy Settings.

Learn Build status updates of commit 0b84cb8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/security/threat-protection/auditing/advanced-security-audit-policy-settings.md
:white_check_mark:Succeeded

windows/security/threat-protection/auditing/basic-security-audit-policy-settings.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@microsoft-github-policy-service agree


post-estimation command that does a multiverse analyses to assess incidences where common support is lacking

First draft is done nopo commsupport; still some minor things that are open:

[ ] adjust all local/variable names with underscores
[ ] carry forward weights
[ ] add all options for the twoway-graphs (also one option for markers for used/unsued variables)
[ ] potential option for average share of unmatched (instead of graph by group)
[ ] add in help-file
[ ] check whether varlist in option is part of the matchset

@maximilian-sprengholz : in the newest version, I also adjusted the return _matchset of nopo decomp (lines 334-348)
Do we need to omit potential multiples (and/or interaction)? Otherwise check also a shorter version of the code in the line (350-356).


add unnormalized design,  add is_normalized param

Can you let me know the url you tested with? I tried http://localhost:8080/mainnet/0x57f1887a8BF19b14fC0dF6Fd9B2acc9Af147eA85/50211173178435762694637832292549659091063031186845278032152635155992610521226 and getting
error OwnerNotFoundError: Checking owner of<PHONE_NUMBER>8435762694637832292549659091063031186845278032152635155992610521226 failed. Reason: Error: could not detect network (event="noNetwork", code=NETWORK_ERROR, version=providers/5.4.1)
    at OwnerNotFoundError.BaseError [as constructor] (/Users/makoto/work/ens/ens-metadata-service/src/base.ts:6:5)
    at new OwnerNotFoundError (/Users/makoto/work/ens/ens-metadata-service/src/contract.ts:71:42)
    at Object.<anonymous> (/Users/makoto/work/ens/ens-metadata-service/src/contract.ts:49:13)
    at step (/Users/makoto/work/ens/ens-metadata-service/src/contract.ts:48:23)
    at Object.throw (/Users/makoto/work/ens/ens-metadata-service/src/contract.ts:29:53)
    at rejected (/Users/makoto/work/ens/ens-metadata-service/src/contract.ts:21:65)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

FYI I have set these params on .env
INFURA_API_KEY=$INFURA
NETWORK=mainnet
ENV=local
ADDRESS_ETH_REGISTRAR=


fallback and error logging if running pgina as admin without domain p…

fallback and error logging if running pgina as admin without domain privelages.
I was runnig pgina as administrator and my pc is part of a windows domain.
when localmachines try's to get information of that group i did get an error.
my administrator user has no rights on the domain, so quering the localgroups with members of the domain did give errors.
I now catch the error(s) and go to the next group.

Have you seen this https://github.com/MutonUfoAI/pgina/issues/21
I wouldnt add another workaround for this terrible .NET api
You'd better replace that whole group stuff with winapi calls as i did with user-creation in pgSMB2


Ecto 3: union/union_all + order_by gives "(undefined_table)" Postgres error

Environment

Elixir version (elixir -v): 1.7.3
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): psql (PostgreSQL) 10.6 (Ubuntu 10.6-0ubuntu<IP_ADDRESS>)
Ecto version (mix deps):
{:ecto_sql, "~> 3.0.1"}
{:ecto, "~> 3.0.2"},
Database adapter and version (mix deps):
{:postgrex, ">= 0.0.0"}
Operating system:
Ubuntu 18.04

Current behavior
I'm using Ecto 3's union_all in order to union and paginate multiple tables, sorted by timestamps, with a single query. It works quite well (thanks for this feature!) until I add the order_by clause:
def trades_query() do
    Trades.Trade
  end

  def orders_query() do
    Orders.Order
  end

  def big_select() do
    trades_select =
      trades_query()
      |> select([t], %{
        tag: "trade",
        timestamp: t.inserted_at,
        data: fragment("row_to_json(?)", t)
      })

    orders_select =
      orders_query()
      |> select([o], %{
        tag: "order",
        timestamp: o.inserted_at,
        data: fragment("row_to_json(?)", o)
      })

    trades_select
    |> union_all(^orders_select)
    # This breaks, as does order_by(:inserted_at)
    |> order_by(:timestamp)
    |> limit(50)
    |> offset(30)
  end

It gives the following error
** (Postgrex.Error) ERROR 42P01 (undefined_table) missing FROM-clause entry for table "t0"

    query: SELECT t0."inserted_at", row_to_json(t0) FROM "trades" AS t0 UNION ALL (SELECT o0."inserted_at", row_to_json(o0) FROM "orders" AS o0) ORDER BY t0."timestamp" LIMIT 50 OFFSET 30
    (ecto_sql) lib/ecto/adapters/sql.ex:590: Ecto.Adapters.SQL.raise_sql_call_error/1
    (ecto_sql) lib/ecto/adapters/sql.ex:523: Ecto.Adapters.SQL.execute/5
    (ecto) lib/ecto/repo/queryable.ex:147: Ecto.Repo.Queryable.execute/4
    (ecto) lib/ecto/repo/queryable.ex:18: Ecto.Repo.Queryable.all/3

I asked on the slack channel and @michalmuskala suggested me order_by(fragment("inserted_at")) as a workaround, and right now that's enough for my needs, but...
Expected behavior
I expected to be able to order by one of the selected fields. Since the union docs talk about order_by, I think this might be the expected behavior.

So the thing to keep in mind is that, according to SQL, the order_by applies to the whole union and not a particular union. And because Ecto can only refer to named fields, using order_by with unions in Ecto are unlikely to ever work. We will make sure to document this behaviour more clearly but right it is a limitation of how unions work. Maybe you could try to use fragments but I am not sure how you would refer to the result of the union as Ecto does not generate named fields in the select (like foo AS bar).

Using fragments work since you can refer to the overall union results as "unqualified" - order_by(fragment("inserted_at")) does what's expected.

@michalmuskala I will add that note too.

@eumend Would turning the union query into a subquery work for you? Like:
union_query = union_all(trades_select, ^orders_select)

from(u in subquery(union_query), select: [u.id, u.other_fields], order_by: u.inserted_at) |> Repo.all()

@qcam that's beautiful.

Would it be a good idea to have some assertions in the query planner to ensure combinations and order_by (and maybe others) are mutually exclusive? 🤔

I assume we may have valid cases, such as the fragment Michał showed, or
random sorting. so I would prefer to focus on the docs
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I believe we should be able to achieve everything using a subquery. But I'm not 100% sure of performance implications of wrapping a union in a subquery.

@qcam I can't test it right now but that looks perfect! If it works, as it probably does, it will likely allow me to use ecto_scrivener which is what I'd rather do. Thanks!

Would it be a good idea to have some assertions in the query planner to ensure combinations and order_by (and maybe others) are mutually exclusive? 🤔

@qcam, now that I thought more about it, I think we can check that if there is any combination, we could check that none of the fields in order_by use the binding. For instance, we cannot have p.foo or anything of sorts.
We could make a very simple check that traverses the order_by fields looking for top level bindings:
Enum.find(order_bys, &{_dir, %{expr: {{:., _, _}, _, [{:&, _, [_]}, _]}}})

And raise a proper error message with the suggestions here. Thoughts?

That sounds great! I can give it a try if you haven’t started. The only thing I wonder is that shall we make that check at when the query is built in compile time or when the query is planned?

When the query is planned. Or to be more precise, when the query is normalized inside the planner (the result of normalization is cached).

But, yes, please go ahead!

@qcam Your suggestion worked, though I did have to use one last hack. You see, for some reason the tag field I declared with a string, disappears form the subquery, so when I do:
trades_select =
      trades_query()
      |> select([t], %{
        id: t.id,
        timestamp: t.inserted_at,
        data: fragment("row_to_json(?)", t),
        tag: "trade"
      })

    orders_select =
      orders_query()
      |> select([o], %{
        id: o.id,
        timestamp: o.inserted_at,
        data: fragment("row_to_json(?)", o),
        tag: "order"
      })

    union_query =
      trades_select
      |> union_all(^orders_select)

    from(u in subquery(union_query),
      select: %{
        id: u.id,
        timestamp: u.timestamp,
        data: u.data,
        tag: u.tag
      }
    )
|> Repo.all()

I get
** (Postgrex.Error) ERROR 42703 (undefined_column) column s0.tag does not exist

    query: SELECT s0."id", s0."timestamp", s0."data", s0."tag" FROM (SELECT t0."id" AS "id", t0."inserted_at" AS "timestamp", row_to_json(t0) AS "data" FROM "trades" AS t0 UNION ALL (SELECT o0."id", o0."inserted_at", row_to_json(o0) FROM "orders" AS o0)) AS s0
    (ecto_sql) lib/ecto/adapters/sql.ex:590: Ecto.Adapters.SQL.raise_sql_call_error/1
    (ecto_sql) lib/ecto/adapters/sql.ex:523: Ecto.Adapters.SQL.execute/5
    (ecto) lib/ecto/repo/queryable.ex:147: Ecto.Repo.Queryable.execute/4
    (ecto) lib/ecto/repo/queryable.ex:18: Ecto.Repo.Queryable.all/3

BUT If i do
trades_select =
      trades_query()
      |> select([t], %{
        id: t.id,
        timestamp: t.inserted_at,
        data: fragment("row_to_json(?)", t),
        tag: fragment("'trade'")
      })

    orders_select =
      orders_query()
      |> select([o], %{
        id: o.id,
        timestamp: o.inserted_at,
        data: fragment("row_to_json(?)", o),
        tag: fragment("'order'")
      })

Then the query works fine:
[debug] QUERY OK db=75.6ms
SELECT s0."id", s0."timestamp", s0."data", s0."tag" FROM (SELECT t0."id" AS "id", t0."inserted_at" AS "timestamp", row_to_json(t0) AS "data", 'trade' AS "tag" FROM "trades" AS t0 UNION ALL (SELECT o0."id", o0."inserted_at", row_to_json(o0), 'order' FROM "orders" AS o0)) AS s0 []

And yes, it works with order_by, scriverer's paginate etc.
About the tag, is this supposed to work this way? I mean, if I skip the order_by/pagination then the tag string works fine. What I get is that's added after the sql if I declare it as a string?

@eumend in your first query, can you not declare the select at all? Or do you have to declare a select?

I think this will be broken with unions anyway as we will likely tag everything as trade and nothing as order. When we have a union, we need to send all literals to the database. The same thing for subqueries. I will open up a separate issue.

@josevalim Yes that's the thing, I need every table tagged and for that I need the select in each one.

Closing in favor of #2828.

delet


Checkpoint Loading Error in Demo_sim_Erender.py

Hi Chen,
I followed all the instructions provided in the documentation but encountered an error related to checkpoint loading. The error message is as follows:

pybullet build time: Nov 28 2023 23:51:11
Traceback (most recent call last):
File "demo_sim_Erender.py", line 77, in
run_demo()
File "demo_sim_Erender.py", line 16, in run_demo
pipeline = CorrespondenceBasedPipeline(
File "/root/CNS/cns/benchmark/pipeline.py", line 70, in init
self.control = GraphVSController(ckpt_path, self.device)
File "/root/CNS/cns/benchmark/controller.py", line 13, in init
self.net: GraphVS = torch.load(ckpt_path, map_location=self.device)["net"]
File "/root/miniconda3/envs/myconda/lib/python3.8/site-packages/torch/serialization.py", line 789, in load
return _load(opened_zipfile, map_location, pickle_module, **pickle_load_args)
File "/root/miniconda3/envs/myconda/lib/python3.8/site-packages/torch/serialization.py", line 1131, in _load
result = unpickler.load()
File "/root/miniconda3/envs/myconda/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1269, in getattr
raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'Linear' object has no attribute '_lazy_load_hook'

It seems that the issue is related to the environment or potential differences in the PyTorch versions. I am using the following environment:
Python version: 3.8
Torch version: 1.13.1
I would appreciate it if you could provide some insights into the following:
PyTorch Compatibility: Could you confirm if the checkpoint provided is compatible with PyTorch version 3.8? If not, could you please specify the recommended PyTorch version?
Loading Checkpoint in Different Environments: Are there any known issues or considerations when loading the checkpoint in an environment different from the one it was saved in?
Possible Solutions: Do you have any suggestions or solutions to resolve this issue? I have already checked the PyTorch version and made sure it aligns with the project requirements.
Thank you for your time and assistance. I appreciate the effort you put into maintaining this open-source project, and I look forward to your guidance on resolving this matter.
Best regards,

Sorry for the late reply. This model is trained with python=3.7.12, torch=1.13.1, and torch_geometric=2.2.0. The issue may raise from the different versions of torch_geometric. It seems that the method _lazy_load_hook of Linear object mentioned in the error message has been removed in later PyG versions.
Solution: We now upload the "state dict" of the model (see checkpoints/cns_state_dict.pth). Some scripts are also updated, you can run demo_sim_Erender.py with the latest checkpoint and codes. May this help you.

Thank you for your previous assistance. It worked! I have a new issue with the algorithm under two scenarios:

'Hard' mode with fewer than 50 match points.
Objects at the edge or partially in the image.
These conditions significantly reduce the algorithm's effectiveness. Do you have any suggestions for improvements?

Thank you for your previous assistance. It worked! I have a new issue with the algorithm under two scenarios:

'Hard' mode with fewer than 50 match points.
Objects at the edge or partially in the image.
These conditions significantly reduce the algorithm's effectiveness. Do you have any suggestions for improvements?

The object of 'Hard' mode with fewer than 50 match points is just a simple screw.

This is the intrinsic drawback of this work, as our controller only uses the point position (image or point features are not utilized) to compute the control rate. Therefore, if the frontend fails (or provides few keypoints and errorneous matches), the whole algorithm will fail. It is typical when servoing textureless scenes or symmetric objects.
Here are the possible solutions:

For scenario 1: Improve the quality of correspondence, use a detector-based frontend providing denser keypoints and matches, such as SuperGlue, LightGlue and etc. However, these learning based image matching works tend to fail when facing large in-plane rotations.
For scenario 2: It may raise from the out-of-distribution problem, since our training stage doesn't contain partially observed scenes. You may need to change the environment randomization and re-train the model from scratch... Another possible solution is pre-rotating the camera before servoing to ensure that objects roughly locate at the center of camera's field of view.
We now upload the classical IBVS method as an alternative, you can switch to IBVS (set ckpt_path="checkpoints/ibvs_config.json") to see if it could solve your problem.


Remove the unnecessary dependency: numpy

I noticed that jsonsubschema introduced numpy to create a specialized branch of support. In fact, this is unnecessary because Python already provides a simpler implementation.

Hi @MrLYC !  Thanks for submitting this PR, it looks good to me.
In order to merge it in, we need a signed DCO: https://github.com/IBM/jsonsubschema/blob/master/DCO1.1.txt
This just certifies that the code changes are original and that you are allowed and willing to license them under the Apache-2.0 license

Done, looking forward to the release of the new version.

Dear @MrLYC , thank you for your contribution! Could you please email me a copy of the signed DCO at<EMAIL_ADDRESS>?

@hirzel I have sent an email, is the format and content correct?

Yes, received with thanks!


issues with model serving

I'm following:
https://docs.redhat.com/en/documentation/red_hat_openshift_ai_self-managed/2.13/html/openshift_ai_tutorial_-_fraud_detection_example/deploying-and-testing-a-model#deploying-a-model-single-model-server
in this, the screenshot is missing the route info:

So a user will be likely to not make anything external.
So their endpoint will look like:

And then, the notebook validation will fail.
In spite of allowed for self-signed certs in the code, it works well with the route, but not at all with the internal endpoint.

Is there a bug filed against the OpenShift AI?  In reproducing this, the behavior is different before and after creating a model server with an external route.  If you create the internal service never having created an external service, it will fail with a connection reset. If you create the internal service after an external service exists, it works as expected.  Leads me to believe that there's an issue with how the internal routing is set up in the project that the external routing initializes correctly.

Another issue is that while the external endpoint had a verified ssl cert, the internal service does not.  This seems like very strange and inconsistent behavior.  It makes using these endpoints internally cumbersome even if it works.


Fixed ${} references in predicates not being expanded using current()…

… if the expression contains whitespace before the reference
Closes #531
Why is this the best possible solution? Were any other approaches considered?
Fixing previous working solution.
What are the regression risks?
None.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:

[x ] included test cases for core behavior and edge cases in tests_v1
[x] run nosetests and verified all tests pass
[x] run black pyxform to format code
[x] verified that any code or assets from external sources are properly credited in comments

I could not break it, though I tried quite hard. :)

Thanks!

Will try to review and release by Fri.
@gushil please review #535. Could you also please look into why there’s a CI failure here? Have some versions changed? We want to make sure it’s green before merge.

@lognaturel
It looks like the failure is caused by pip version 21.1 (used by the build)
Based on https://github.com/pypa/pip/issues/9954 , by using pip version 21.1.1 (released on May 1st, a couple of days after the build happened) the warnings will be silenced.
Should we try to trigger new build? (I don't know how to do that yet)

Codecov Report

Merging #536 (4a6e80b) into master (d2463fc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   83.98%   83.98%
=======================================
  Files          25       25
  Lines        3728     3728
  Branches      871      871
=======================================
  Hits         3131     3131
  Misses        452      452
  Partials      145      145

Impacted Files
Coverage Δ

pyxform/survey.py
92.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2463fc...4a6e80b. Read the comment docs.

As far as I know, only @ukanga has access to the Appveyor account. When I need to re-run, I force push a change to the latest commit message. I did this here and did not change the contents of the commit.
What I'm understanding here is that #524 introduced the regular expression instance\([^)]+\S+ to identify instance path expressions. This explicitly used whitespace to attempt to identify the end of a path expression starting with instance but I didn't really notice that or consider implications in review. All tests introduced made sure there was always a space after the instance path expression and not within it. This is the kind of assumption that's really valuable to describe in a PR description to make sure it's explicitly considered.
@pbowen-oc's example from the issue is particular because it has multiple predicates. I think that's important to introduce some testing around. I would have been tempted to identify the end of an expression we care about by starting with instance( and ending with the first ] but the possibility of multiple predicates mean we can't do that. There should be a test that keeps us from trying that in the future.
What this PR does is remove any attempt to identify the end of an instance path expression. This kind of thing would be valuable to highlight in the "why is this the best solution" part of the PR template. This change means that any ${} expression that occurs after instance() will get a current() prefix whether or not it's in a predicate. See for example instance('item')/root/item[itemindex = ${item-counter}]/label + ${item-counter}. The first ${item-counter} gets a current() prefix which is good and expected. The second ${item-counter} does too. This is not desirable and I don't love it but it happens that the current() has no effect in that case so it 's not the worst thing in the world.  I can't think of a case where the superfluous current() would cause problems. @MartijnR, what do you think? I don't believe we can accurately identify XPath path expressions without a parser that has knowledge of operators, function structure, opening closing brackets/braces, etc. This may be the best we can do. If we go with it, I think this case should be documented with a comment that says something like "The second reference to item-count should not get a current() prefix but we currently have no way of reliably detecting the end of an XPath path expression so any reference after instance() gets a current() prefix whether or not it's in the path expression."
We don't have to do anything about this now, but I wanted to come back to something from the initial issue that I think we didn't get quite right. At https://github.com/XLSForm/pyxform/issues/490#issuecomment-785459282, @MartijnR, you said we should only be using current() for XPath path expressions that start with instance(. I'm not really sure that's the ideal. A common thing to do is to have two parallel repeats. For example, one that builds a roster and another that asks questions about each roster member. You might want to do something like /data/roster[position() = ${pos}]/name in the second repeat. In that case you do need the current() prefix. In fact, I can't currently think of a case where it would be undesirable. You mentioned populating choices from a repeat but that's not done manually so the path expression for that would not go through this code.

Hmm. Now that I think about it with a clear head, wouldn't a regex that captures all strings in between [ and ] and uses the current() prefix for those have the outcome that we want? This depends on whether or not I missed something regarding predicates on nodesets in the forms.
@pbowen-oc @gushil I think this PR certainly makes a valuable improvement. If you can do the two second bullets I mentioned, I could merge and do a release. Then once we get an opportunity to hear from @MartijnR we can evaluate whether the concept I mentioned above might be promising and help capture more useful cases.

Thanks, @lognaturel.
@gushil is working on adding tests for the cases you referenced

wouldn't a regex that captures all strings in between [ and ] and uses the current() prefix for those have the outcome that we want?

That sounds great. I agree it's better not to create unnecessary current() prefixes, and I'm embarrassed I didn't find instance('item')/root/item[itemindex = ${item-counter}]/label + ${item-counter}, because that's exactly the thing I was trying to find..... 👍

You might want to do something like /data/roster[position() = ${pos}]/name in the second repeat. In that case you do need the current() prefix. In fact, I can't currently think of a case where it would be undesirable. You mentioned populating choices from a repeat but that's not done manually so the path expression for that would not go through this code.

Hmmm, yes, I have a vague recollection that you mentioned this about my misunderstanding of current() before... I think I may have regressed and that you're right about current() being appropriate for all cases where a ${ref} results in a relative path inside a predicate (so in pyxform world).

Will aim to release mid-morning tomorrow (Pacific).


⚠ Processors has degraded performance

In 799aace, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 129 ms

Resolved: Processors performance has improved in 73b8c35.


Demo Kit: Incorrect List Item Title for Controller Extension Sample

URL (minimal example if possible): https://openui5nightly.hana.ondemand.com/#/entity/sap.ui.core.mvc.ControllerExtension
Any other information? (attach screenshot if possible)

I created a small PR here: https://github.com/SAP/openui5/pull/2248 if it helps


WhatsApp API in PHP

Have You Checked Chat-API?

Easy to Use
One of the best API for WhatsApp with WA2.0 Protocol.
Latest Android Environment
All Required Functions and Features
No More Blocking
Sample Bot
Well Documented

Try Now On
https://chat-api.net

Reported due to being advertisment. Do not use this API since they will not refund.


Generate Software Bill of Materials during release

A Software Bill of Materials (SBOM) provides visibility into the software supply chain and any license compliance, security, and quality risks that may exist.
Fixes: #20712
Signed-off-by: Sandipan Panda<EMAIL_ADDRESS>

cc @aanm @nbusseneau

@nbusseneau this is a bug in bom that we are waiting to get fixed. I'm including a link to some discussions on this in the Kubernetes Slack. We found this while testing the SBOM generation here for this workflow file.

Is this something we would also want to add to the README? https://clomonitor.io/docs/topics/checks/#software-bill-of-materials-sbom

@nbusseneau this is a bug in bom that we are waiting to get fixed. I'm including a link to some discussions on this in the Kubernetes Slack. We found this while testing the SBOM generation here for this workflow file.

Thanks. Would it be possible to open an issue for that on SBOM repository (if there is not one already) and linking to it from a comment in our workflow? This would be better for future reference, and we can revisit this when it's fixed.

Is this something we would also want to add to the README? https://clomonitor.io/docs/topics/checks/#software-bill-of-materials-sbom

This check passes if: The repository’s README file contains a SBOM section that explains where they are published to, format used, etc.

Will it be better if we include the SBOM section in a subsequent PR to this one, as we need a link to redirect users to? As Cilium will publish SBOMs from Cilium v1.13, should that be added after it is released?

Thanks. Would it be possible to open an issue for that on the bom repository (if there is not one already) and linking to it from a comment in our workflow? This would be better for future reference, and we can revisit this when it's fixed.

Opened the issue: https://github.com/kubernetes-sigs/bom/issues/202

Would it be better if we include the SBOM section in a subsequent PR to this one, as we need a link to redirect users to? As Cilium will publish SBOMs from Cilium v1.13, should that be added after it is released?

A separate PR is fine. If you want to add it after it is released make sure it gets backported to the 1.13 release and isn't just on latest

We are at the final stages of this being implemented.

Update: Thanks to @aanm, we have successfully tested and resolved the issue we were facing with signing SBOM images in https://github.com/cilium/cilium/pull/21435. I am working on updating this PR with the required changes.

I see that GitHub just pushed a new feature to GitHub runners, where they publish the SBOM of the Github runner. They suggest attaching it to BOM for artifacts we build: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#reviewing-the-supply-chain-for-github-hosted-runners
I think this is nice, what do you think about tackling this in a follow-up PR?

I see that GitHub just pushed a new feature to GitHub runners, where they publish the SBOM of the Github runner. They suggest attaching it to BOM for artifacts we build: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#reviewing-the-supply-chain-for-github-hosted-runners
I think this is nice, what do you think about tackling this in a follow-up PR?

Thank you for bringing this up. I see that Quay supports a fixed set of mediatypes to be attached to images by default. For cosign download sbom to function properly, the ideal situation is a single SBOM per image. We can update the SBOM docs in Cilium to make folks aware that SBOMs are available for runner images by adding something like this:
SBOMs are available for Ubuntu runner images. You can locate the SBOM for your build in the release assets at https://github.com/actions/runner-images/releases. An SBOM with a filename in the format of sbom..json.zip can be found in the attachments of each release.
Please let me know what you think about this.

Verified instructions with the images built in https://github.com/cilium/cilium/pull/21435


Modify the problem of ControllerUnpublishVolume

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Modify the problem of ControllerUnpublishVolume
CSI need import opensds/contrib/connector/fc

Special notes for your reviewer:
Release note:

1. Modify the problem of ControllerUnpublishVolume
2. CSI need import opensds/contrib/connector/fc

I assume this PR has fixed this issue? https://github.com/opensds/nbp/issues/155
@BaiHuoYu @leonwanghui @wisererik

Verified this PR fixed issue #155.


Fixed #34977: Make change password form reachable through button

https://code.djangoproject.com/ticket/34977
To improve usability and accessibility, this PR replaces the link to change a user's password within the help text of the password field of the change user form by a button.

Besides an improved user experience, I would expect this PR to also improve accessibility. But since I am anything but an expert on accessibility, I would like to ask the accessibility team to review and give hints on hot to improve accessibility.

I would go a different route to solve this issue, specially because I believe that the best practice for help texts is not to use markup at all (more so for easing translations).
So my proposal is to:

Re-phrase the help texts so they are complete sentences that make sense but without any actionable links nor buttons.
Add the action button next to the help text.

This would also have the (nice) side effect to separate "form concerns" (ie help texts) from UI elements that want to be displayed together in a template.
Initial proposal (to be discussed with the accessibility team):
diff --git a/django/contrib/auth/forms.py b/django/contrib/auth/forms.py
index 5398af4dad..30d28cbe00 100644
--- a/django/contrib/auth/forms.py
+++ b/django/contrib/auth/forms.py
@@ -179,9 +179,8 @@ class UserChangeForm(forms.ModelForm):
     password = ReadOnlyPasswordHashField(
         label=_("Password"),
         help_text=_(
-            "
Raw passwords are not stored, so there is no way to see this "
-            "user’s password, but you can change the password here:
"
-            '
Change password
'
+            "Raw passwords are not stored, so there is no way to see this "
+            "user’s password."
         ),
     )

diff --git a/django/contrib/auth/templates/auth/widgets/read_only_password_hash.html b/django/contrib/auth/templates/auth/widgets/read_only_password_hash.html
index c73042b18f..f88d2e1ba4 100644
--- a/django/contrib/auth/templates/auth/widgets/read_only_password_hash.html
+++ b/django/contrib/auth/templates/auth/widgets/read_only_password_hash.html
@@ -1,5 +1,8 @@
+{% load i18n %}
+

 {% for entry in summary %}
 {{ entry.label }}{% if entry.value %}: <bdi>{{ entry.value }}</bdi>{% endif %}
 {% endfor %}
+{% trans "Change password" %}

Draft UI:

Good idea! Once we're touching ReadOnlyPasswordHashField I'd also like to change the formatting that the button always will be on the right. Depending on viewport width, the button will break into the next line.

@fsbraun Would you have time to update this PR by rebasing onto main and ensuring is ready for re-review? Thanks!
@django/accessibility Would you have any opinion on my proposal above?
/remind me to re-check the status of this PR in 3 weeks

@nessita I've rebased and rewritten to reflect your first comment:
* Help texts do not contain markup or buttons

* Widget now contains the button for the link

* In private exchange with @sabderemane we concluded that a `role` attribute for the button is not advisable from a accessibility viewpoint

Thank you @fsbraun ! Please remember to update the ticket flags accordingly.

@nessita Thank you for your comments!
I added a bullet point to the release notes. I searched the docs and did not find a reference to the link. Have I missed something?
I also implemented some of your comments where I did not see any roadblocks. I added comments to the others. Getting the URL of the change password action from within the widget seems tricky to me.

Building docs fails apparently since it cannot locate the class django.contrib.auth.forms.ReadOnlyPasswordHashWidget . I am not sure why. What am I missing?


Python GlobalElementFilterDefinition filter_functions field should be called predicates

There is a field called 'filter_functions' within the GlobalElementFilterDefinition class. It should be called  'predicates'. The incorrect name means the ToCodeString method produces the wrong output. See https://gchq.github.io/gaffer-doc/getting-started/operation-examples.html#filter-example
The docs show the constructor parameter is called 'filter_functions' when it is actually called 'predicates'.

Merged into hotfix-1.1.2


MOL-1263: load data for selected payment methods only

Here were some Problems

ideal issues, pos terminal and credit card mandate were loaded on every request
profile id was loaded twice, one general and one for ideal issues

now:

we load only additional data if mollie payments were selected
the profile id is loaded once and saved for the request
ideal, pos, CC data is loaded if the payment methods are selected

Fixes #507


enable channels_first for center_crop

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (66bb075) 78.97% compared to head (d865e83) 56.22%.
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18778       +/-   ##
===========================================
- Coverage   78.97%   56.22%   -22.76%
===========================================
  Files         336      336
  Lines       34040    34056       +16
  Branches     6668     6672        +4
===========================================
- Hits        26883    19147     -7736
- Misses       5580    13456     +7876
+ Partials     1577     1453      -124

Flag
Coverage Δ

keras
56.22% <ø> (-22.65%)
:arrow_down:

keras-jax
?

keras-numpy
56.22% <ø> (-0.01%)
:arrow_down:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Satosa disco login

the following changes resolve the following issue : https://github.com/italia/eudi-wallet-it-python/issues/57
and make the graphical changes to the discovery page: https://github.com/orgs/italia/projects/19/views/1?pane=issue&itemId=34479233

Still in progress to resolve a Cors policy issue when downloading font files

The problem was solved by adding the --check-static ./static/ option to the uwsgi command to start the IAM Proxy server on localhost:10000. This allowed the server to properly serve the static resources in the ./static directory.


Add test for empty initializer. Document other tests.

Shifts tests which are part of the system package (but slated for removal as part of #3737, #3840) to container unit tests which also checks that the runtimes provide a consistent handling of different capabilities and error scenarios.
Related issue and scope

[x] I opened an issue to propose and discuss this change (#3839, #3737)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[x] I updated the documentation where necessary.

Codecov Report

Merging #3844 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3844   +/-   ##
=======================================
  Coverage   74.61%   74.61%
=======================================
  Files         138      138
  Lines        6461     6461
  Branches      397      397
=======================================
  Hits         4821     4821
  Misses       1640     1640

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb05298...064a7a0. Read the comment docs.


Refactor config generation

I modified the ControlClusterConfiguration and ConfigClusterConfiguration structures. Before, different strings containing formatted lists of IPs or endpoints were stored in the struct (comma separated, space separated, comma separated with quotes etc.).
I modified it so that only the actual data is stored in the struct and strings in the required formats are generated just before the template is executed (using helper functions), so only the relevant data is passed in the struct.
I believe that it simplifies the code and will also make it easier to add the static configuration capabilities to different custom resources.
In future PRs other ClusterConfiguration structs will be similarly refactored.

recheck

Still there are separate methods for everything :<


[Event Request] Codeunit 6620 "Copy Document Mgt".OnBeforeRecalculateAndApplySalesLine

Please set "var" before parameters "ExactCostRevMandatory", "RecalculateAmount" and "CreateToHeader"
Also set "var" before parameter "RecalculateAmount" in function "RecalculateAndApplySalesLine"
    [IntegrationEvent(false, false)]
    local procedure OnBeforeRecalculateAndApplySalesLine(var ToSalesHeader: Record "Sales Header"; var ToSalesLine: Record "Sales Line"; var FromSalesLine: Record "Sales Line"; Currency: Record Currency; var ExactCostRevMandatory: Boolean; var RecalculateAmount: Boolean; var CreateToHeader: Boolean; MoveNegLines: Boolean; var IsHandled: Boolean)
    begin
    end

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Dependency-Check needs to add the latest vulnerabilities of jquery-ui

Hi, there is a new vulnerability in jQuery-ui, which is not reported by dependency check currently, please add this vulnerability to dependency check.
jQuery-ui vulunerability: CVE-2022-31160
https://security.snyk.io/vuln/SNYK-JS-JQUERYUI-2946728
Originally posted by @ReneXton in https://github.com/jeremylong/DependencyCheck/issues/4028#issuecomment-1194884483

It will be reported on once the vulnerability is in the NVD data (the CVE is still awaiting analysis: https://nvd.nist.gov/vuln/detail/CVE-2022-31160). If you enable the OSS Index Analyzer the vulnerability may be reported sooner.
Currently, dependency-check does not maintain a database of vulnerabilities so we have no way to add a vulnerability.


Update welcome text for codespaces-linux

Re: https://github.com/github/codespaces/issues/2511

The text is now externalized in a file, so anyone can tweak or make suggestions in the PR.  Right now the aka.ms link points to the codepsaces-linux definition since I don't think there's anywhere else. We can update the link if we get something into docs.
/cc: @2percentsilk @bailey @matthewisabel @jkeech

Looks awesome! Super excited to be able to see how this helps our new users 😄


Update subscription-example readme with subscription blogpost

I'll write a blogpost about this so developers can follow along. Let's include this in the readme once it's out.

[x] Update subscription-example readme with the blog link

Blogpost url: https://www.adyen.com/blog/use-adyen-tokenization-to-implement-recurring-in-dotnet
Updated readme in commit: https://github.com/adyen-examples/adyen-dotnet-online-payments/commit/97440519adf0abd08764218f20d0b1528ae00bee


My favorite Alaska island has a bug on the FUDS burden

Describe the bug
#8.81/55.1443/-131.483 is showing NO (which I believe to be correct) but it is highlighted in blue.
Note: This is happening in several other tracts
#8.93/55.4958/-133.0128
#6.27/62.254/-147.762
but not all tracts:
#5.77/62.534/-149.233
my concern is tracts where it is causing the category to appear exceeded but it should not be:
#5.68/63.057/-159.164
To Reproduce
Steps to reproduce the behavior:

Go to '#8.81/55.1443/-131.483'
Click on 'Legacy pollution'
Scroll down to 'FUDS'
See error

Expected behavior
NOs should not be highlighted in blue. This is causing the legacy pollution category to appear exceeded but it is not.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I checked two of these tracts out in the spreadsheet. both are true, so I think this is a case where the UI is showing NO when it should be YES and what is happening in the category is fine.
02290000400
02164000100

one tract I checked the inspect panel and it looks like the UI is just not reading the signal properly

FUDS is fixed!


Adding the GarNet layer and an example project

Original keras layer: https://github.com/jkiesele/caloGraphNN/blob/master/caloGraphNN_keras.py
Aside from GarNet-specific templates, converter codes, and hls_model.py classes, this PR introduces the following changes:

In hls_model.py, a new variable type name is introduced when Layer.add_weights_variable is called with a specified precision, even when the type_name argument is None. Otherwise repeated calls with precision not None but type_name None will keep using the default type name and overwriting the precision specified in the previous call.
In templates.py and vivado_template.py, added a method get_precision to the Backend class. The method is called with the general type of the variable ('f' or 'i') and the number of binary digits, and returns the string corresponding to the precision for the given backend. GarNet and GarNetStack classes in hls_model.py use this method to avoid explicitly mentioning ap_fixed and ap_int types.

Awesome work @yiiyama ! Can you also add a json+h5 and yml to the PR so that the conversion can be tested?
I'll do the proper review next week (hopefully)

Sure! Should I make a directory in example-models to put the files in or can I just tuck them in the example project directory?
Also I forgot to mention one important thing - nnet_garnet.h doesn't synthesize with at least Vivado 2018.1. I've been developing on my personal machine which has 2019.2 installed so I didn't notice this until today. Apparently the older version of Vivado doesn't like having pointer / reference static const class members, which is used a lot in garnet_config (see vivado_templates.py).

If the files are not too large you can put them there. If the result ends up being the same as the project in example-prj maybe the example could be removed.
In 2019.1 they finally updated the compiler, so maybe that was the issue.

I reset --hard to remove the example project and instead added the weights and json files to example-models. Because I wanted example tb_input files to be there too, those are included in the example model directory.

@yiiyama could you add an example model (ideally from the paper?) in a PR to the new example-models repo?
also, could you rebase this PR so it's mergeable?
@vloncar any other comments for this to be merged?
I'm also happy to test the example model to confirm everything is working as expected.

Superseded by #213.


Basal profile switch is sometimes not recognised

Placeholder issue. I still need to determine how to reliably reproduce. This has happened to me twice, and has been reported once in the FB group by someone else.
Sometimes a basal profile switch is not recognised, so the incorrect basal value shows in the basal pill (not in Auto Mode). The current solution is to switch to different basal profile, hit "Get Data Now", then switch back to your preferred basal profile and hit "Get Data Now" again.

In v0.6.1 there are a few potential things that could cause this.
If the pump - uploader time deference is over a certain amount it may miss the most recent history item due to a bug in how the RTC range is calculated for it's pull request. It should eventually get the history though it may have been delayed. Fixed for 0.7.0
The history request trigger code may not have been able to infer a change took place, possibly due to incomplete polls mixed with a change that fell on/around the 15 minute stale boundary. A history request is always done when poll status message data is considered stale.
If you see this happen again, check the user log for the 'basal pattern changed' history trigger and make a note of the time difference. Also don't do your workaround and just wait and see if it eventually gets the pattern change from the next history pull.

Another note as I just read the FB posts:
The user had a 670G and was recently in Auto Mode and noted a basal rate of '0.0' when they expected their non-AM basal to show. This is NOT A BUG as the AM update rate is only a near realtime update and will only reflect pump changes at the user selected rate. They may see a considerable delay (default is 90 minutes) for a basal switch to happen after a Auto Mode exit.
The status message we get poll to poll does not contain any info to infer a change and for AM users these changes will only get processed for NS on a schedule. This can be as often as 15 minutes and set via the 'advanced system settings' menu.

No, the other user I mentioned has a 640G.
I also had the issue myself when I was in manual mode.
There is another historical message that tells us about Auto Mode changeover.
I really just left this issue as a placeholder to investigate. I’ll close it if I can’t repro.

Ok - they had mentioned a rate of "0.0" which is odd for the 640 but not for the 670. Anyhow deleted the FB comment I made rather then confuse the issue.
Keep it open in case there is something else going on.

Hi,
I can replicate the problem with lates uploader version released few days ago.
I think the problem is in number of the profiles used in the pump. Basal profiles changes like it should using basal profiles 1-3, but if 4th profile is created, I wont report the values like it should. Can anyone else replicate?

I can't reproduce this and any pattern change on the pump produces the corresponding switch in nightscout.
If you change a pattern insulin settings or add a new one a "update pump profile" needs to be manually done in the uploader. Switches will be automatic.
As of version 0.7.3 pump patterns will be read from the pump once every 24 hours and automatically updated in nightscout. This will help if the manual entry is forgotten. It also gets around an issue in nightscout that can have it not see a current profile after several days when to switch is in its current dataset window.


[GSK-856] Giskard gallery

The goal is to give a public access to gallery.giskard.ai.
In this environment, we should

disable new artifact upload
disable new filter creation/existing filter editing (because it’s arbitrary code)
disable test creation/editing (because it’s arbitrary code)

The environment should contain german credit scoring, house pricing and twitter analysis data with feedback and a test suite
This demo environment will also be useful to document the tests
From SyncLinear.com | GSK-856

Replaced by GSK-1591


Don't use opaque parameters in the standard library

The SIL printer is printing opaque parameters as , which breaks the SIL parser. Stop using opaque parameters in the standard library for the moment to unbreak SIL parsing of the standard library.

@swift-ci please test

This is sad, though.

Indeed! I doubt it's that hard to fix in the SIL printer.

Good news, friends. I have fixed the SIL printer: https://github.com/apple/swift/pull/70667


Infix printing for #= and ##

cc @bobzhang
The BuckleScript readme example prints in prefix notation for reason:
let port = 3000;

let hostname = "<IP_ADDRESS>";

let create_server http => {
  let server = (## http createServer) (
  (
    fun req resp => {
      #= (## resp statusCode) 200;
      (## resp setHeader) "Content-Type" "text/plain";
      (## resp _end) "Hello world\n"
    }
  )
  [@bs]
  );
  (## server listen)
    port
    hostname
    (
    (
      fun () => Js.log (
        "Server running at http://" ^ hostname ^ ":" ^ Pervasives.string_of_int port ^ "/"
      )
    )
    [@bs]
    )
};

let () = create_server Http_types.http;

Oh ## is a standard function identifier?

OCaml treats #_ operator in a special way, let me find the link

http://caml.inria.fr/pub/docs/manual-ocaml/extn.html#sec253
Operator names starting with a # character and containing more than one # character are reserved for extensions.

Thanks for the info.

@yunxing any solution for this? I'm not familiar with this at all

Do we maybe just need to recognize it as an identifier and make sure reason doesn't die on it?  Then we can run the regular ## preprocessor on the .ml code?
This seems to be blocking the regular use of js bindings.  When we wrote reason code with js_of_ocaml we had to use the workaround of writing the code that the preprocessor generates (which works fine but ## is more convenient).

It should be as easy as considering this of Infix precedence (there's a function in the printer that checks to see if the leading character is infix - we'd just update it to also look for #). This is like a GoodFirstTask.

@chenglou Sorry just saw this.
@bobzhang @Schmavery I guess I'm a bit confused here. From the parser it seems like #_ is still parsed as infix operators? How does this related to extensions ?
https://github.com/ocaml/ocaml/blob/d6c72fc82a8950851da5f121b80a4e1c8bff377a/parsing/parser.mly#L1569

@Drup may know more about it

#... are infix operators (with priority higher than function application, just like #).
#...#... (with at least 2 #) are infix operators that are reserverd for ppx extensions. It's not possible to define them.
# let (#=#=) x y = x + y ;;
Error: '#=#=' is not a valid value identifier.

Thanks for the info Drup. Though they are reserved, they seem to be represented as standard infix application. The check that they are used only by ppx seems to be deferred to a later stage of compilation. Makes sense.

@Drup Makes sense now. Thank you!

Closing this as it should be fixed by #657.


Library needs a new name

There is an existing library called IFS in Hackage, which means we can't upload an ifs package, so we need to think of a new name for this

An obvious candidate would be to simply spell it out as iterative-forward-search?

I wasn't sure if that'd be too long, but that does make the most sense, I'm happy to go with that


Associations

Branch changes :

Added Classroom class
Implemented association classroom to-many students
Implemented association a student to only one classroom
Added Book and Rental classes
Implemented association book to-many rentals
Implemented association rental to only one book
Implemented association person to-many rentals
Implemented association rental to only one person
Modified other classes to work with the new structure

Hello @iammouaz and @e71az, apologies about the inline comments confusion and the code removal comment will take note of that next time. @e71az thanks for the corrections.

Status: Invalid ❌
Hi @iammouaz,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Please fix the issue mentioned below and then request for code review
Reason

[ ] You have requested code review which was already approved. If you are repeating the week, Please make sure to use a new PR or a new repository with all the changes that need to be there in this milestone.

Please make sure to submit code review when you are done with the changes that was requested
Don't worry you still have same number of requests left as previous.
Cheers and Happy Coding :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Dipesh Kumar

Hi @iammouaz,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request ⚠

You have submitted a PR that is already reviewed and approved. if there is any specific reason for that, kindly request another review explaining why.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


grunt test - error

grunt test results in:
Running "protractor:e2e" (protractor) task
WARNING - pattern /Users/eduardo/IdeaProjects/generator-cc-angular/src/**/*.feature did not match any files.
Did you forget to add some test .feature files for the latest release?

The first test feature file is generated together with the first partial created with cc-angular

lol, its in the docs .... but then I did a partial and something else happend in "app.module.js" it added the "state" to the top of the file instead of adding it to $stateProvider:
{
state: 'app.dashboard',
config: {
url: '/dashboard',
templateUrl: 'partial/dashboard/dashboard.html',
controller: 'DashboardCtrl',
controllerAs: 'DashboardCtrl',
title: 'Dashboard'
}
},
(function(angular) {
'use strict';
/*
 * here is the right place to configure shared modules like app.appCore and feature-module
 * app.appCore defines the dependencies to angular and third party modules
 * any feature module should depend on app.appCore and possible other shared modules
 */

/**
 * @ngdoc: overview
 * @name: generatorCcAngular
 *
 */
angular.module('generatorCcAngular', ['appCore']);

})(angular);

ah. that is indeed a bug, I discovered just today: you cannot add a partial to the root module, because the
function getStates() {
return [
        /* Add New States Above */
    ];
}

is not in the root module. I guess, I just did not think of partial bound to root. Gonna fix it in the next version.

I worked a lot with cg-angular since 1 year backa with bigger applications and now I will implement cucumber tests or find a generator that follows the principals of cg-angular and also have cucumber tests. This is the reason I stumble upon your generator. I could be intersted to help out if you want more people in your team, I think there is some improvements to be done to cg-angular in general but your generator is more interesting coming that it also covers cucumber.

fixed in 1.0.3


Feature service_level and sb_priority

Add new optional sb_priority (southbound_priority) attribute on EVC model and API spec, it should be an integer from 0 to 65535, this sb_priority later on will be used on issue #157.
Replace priority with the newly added sb_priority and create a DB script to also unset the priority and set sb_priority accordingly
Add a new service_level integer attribute on EVC mode and API specl, it should be an integer from 0 to 7, the higher the value the better service level for convergence will be provided, this will be used on issue #179. The default value should be 0.

Landed on #195


fix deprecation warnings

Thanks for this port! While reading through the source I noticed a few deprecation warnings & figured I could tidy them up.

oops, I was 2 days late :blush:


Pass -static-stdlib for all compiler jobs

Motivation:
--static-swift-stdlib support on Linux is introduced by https://github.com/apple/swift-package-manager/pull/2921 but it doesn't work when linking CoreFoundation.
When CoreFoundation is used on a project and a user uses --static-swift-stdlib, SwiftPM compiled object files without
-static-stdlib and linked them with that option. This mismatch of compiler option broke swift autolink mechanism.
The object files built without -static-stdlib references /lib/swift/CoreFoundation/module.map, which is intended to be used for dynamic linking, and the modulemap doesn't have link "CoreFoundation" statement. So the autolink sections in built object files doesn't have -lCoreFoundation and it causes linking failure.
This issue was reported on SR-648
Modifications:
Pass -static-stdlib for all compiler jobs
Result:
This patch changes to pass -static-stdlib for all compiler jobs if necessary. This enables to refenrece /lib/swift_static/CoreFoundation/module.map when using --static-swift-stdlib and it resolves linking failures.

@swift-ci please smoke test


Provide binary release

Hello,
In order to ease the test of kubemci and increase number of feedbacks could you please provide a binary release ?
Thanks in advance,
Cheers

Sure. Its available for download at
https://storage.googleapis.com/kubemci-release/release/v0.0.1/bin/linux/amd64/kubemci.
Let me know if linux amd64 does not work for you and you need a different distribution. Will be happy to generate it.
Have also included the link in release documentation: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/releases/tag/0.0.1

Hi Romain, we'd like to include you (and others) in the early access program if possible.  Could you sign up for the EAP using this form, and we'll follow-up with more info?
https://goo.gl/forms/RHg032DrRnnqF0by1

Hi @nikhiljindal,
Thank you for your really fast reply. As this is intended to be used as a CLI, I think people would be also interested with darwin build as lots of developers are using MacOS.
Thanks for your help.

Hi @nikhiljindal, I would like a binary release for MacOS.

We released the next version for kubemci (v0.1.1) just now and I have generated both linux and darwin binaries this time.
Binaries available for download at:
Linux, amd64: https://storage.googleapis.com/kubemci-release/release/v0.1.1/bin/linux/amd64/kubemci
darwin (MacOSX), amd64: https://storage.googleapis.com/kubemci-release/release/v0.1.1/bin/darwin/amd64/kubemci
@rvrignaud and @samanthakem Would love to get your feedback as you try it out!

Hi @nikhiljindal,
Thanks for the binaries. I'll provide feedbacks in another issue.
Closing this one


Fix installer userdata

Fixes several bugs in the userdata script, currently preventing EC2 installs with the latest release.
/cc @josephglanville

LGTM


Enable standard JS scripts to be linked in as a module

Fixes: #253
This accomplished by mildly abusing the custom component system.
In short, we create a no-op module interface so IDOM will load
the file, but won't actually do anything afterwards

There's probably a better way to implement this.


Consider immediately flushing certain "extra fields" to a log layer

https://github.com/spring-cloud/spring-cloud-sleuth/issues/927#issuecomment-378900051 discusses the understood problem of a race condition when implementing CurrentTraceContext hooks for tools like MDC. Thanks to @dhoffi for elaborating this.
The overal problem is that logging isn't immediately flushed when you set a variable. To do that, you need to know the underlying impl, like MDC: Ex redundant looking commands happen here:
    @SendTo(SourceChannels.OUTPUT)
    public void timerMessageSource() {
        MDC.put(BUSINESS_PROCESS_NAME, ...);
        ExtraFieldPropagation.set(sleuthTracer.currentSpan().context(), BUSINESS_PROCESS_NAME, ...);
    }

would be to leave out the other either by default:
    @SendTo(SourceChannels.OUTPUT)
    public void timerMessageSource() {
        ExtraFieldPropagation.set(sleuthTracer.currentSpan().context(), BUSINESS_PROCESS_NAME, ...);
    }

or by a special command like "flush" which attempts to set the thing immediately
    @SendTo(SourceChannels.OUTPUT)
    public void timerMessageSource() {
        ExtraFieldPropagation.flush(sleuthTracer.currentSpan().context(), BUSINESS_PROCESS_NAME, ...);
    }

Eventhough #577 will solve the problem permanently, we might be able to get a tactical win by establishing some hook for immediately flushing certain (or all) keys to the current trace context.
This would only work in implementations that don't rely on scopes internally. For example, MDC.put("key", "value") is fine, but try (Scope scope = context.scope("key", "value") would not.
This has some cleanup implications, but we might be able to manage them in how we implement the scope field for ExtraFieldsPropagation. This all is only possible because "extra field" support is in the core library, so we can consider special-case it.

@dhoffi question: I assume you are ok if all extra fields are synced to MDC? or do you want to cherry-pick?

well as the strong recommendation is not to put too much data in Propagation, I think it would be fine if exactly the fields of spring.sleuth.baggage-keys and spring.sleuth.propagation-keys would be synced to MDC, wouldn't it?

well as the strong recommendation is not to put too much data in
Propagation, I think it would be fine if exactly the fields of
spring.sleuth.baggage-keys and spring.sleuth.propagation-keys would be
synced to MDC, wouldn't it?

off the top of my head I don't know if these are the same :P will look into
it and thanks for mentioning your goal!

Hello...
Plz what about this feature? Do you have a workaround for now?

haven't thought about this since last note. workaround currently is the first thing I wrote which is to use MDC.. It seems if you have access to brave's api you would have access to MDC also, right? what am I missing..

I'm currently working with reactor and I find simpler to use ExtraFieldPropagation only, to avoid to think about how and where to remove my fields from the MDC for each thread.

I will try to figure out a solution with @anuraaga

Maybe relevant. In my MDC library I do it the other way around, I add
something called "providers" to the logger where it reads tracing data and
include it in logs: https://github.com/jcchavezs/mdctx#providers
On Tue, 3 Mar 2020, 10:54 Adrian Cole<EMAIL_ADDRESS>wrote:

I will try to figure out a solution with @anuraaga
https://github.com/anuraaga
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/issues/682?email_source=notifications&email_token=AAXOYAVZVYOXCMXZWZ57QE3RFTHVDA5CNFSM4EZFKXB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENS2EYA#issuecomment-593863264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYASI5NTIP3DGIEDOOODRFTHVDANCNFSM4EZFKXBQ
.

Maybe relevant. In my MDC library I do it the other way around, I add
something called "providers" to the logger where it reads tracing data and
include it in logs: https://github.com/jcchavezs/mdctx#providers

This is relevant, something log4j2 supports but not others in my recollection. Back when I worked on opencensus, I helped review this which is similar https://github.com/census-instrumentation/opencensus-java/blob/2903747aca08b1e2e29da35c5527ff046918e562/contrib/log_correlation/log4j2/src/main/java/io/opencensus/contrib/logcorrelation/log4j2/OpenCensusTraceContextDataInjector.java
Main concerns are:

framework specific (log4j2)
can cause a lot more garbage as the implementation implies copying maps (maybe on each log entry!)
relies on static initialization and static context lookup which is awkward in environments like spring

actually the log4j2 thing doesn't require copying maps on read, just that above impl does https://logging.apache.org/log4j/2.x/log4j-core/apidocs/org/apache/logging/log4j/core/ContextDataInjector.html#rawContextData--
Anyway an optimized form in the log4j2 module can exist and for example skip any flush-through optimizations if such a plugin exists. something specific like this would deserve its own issue I think. thanks for the thought @jcchavezs!

finally readying an implementation #1130

documented here https://github.com/spring-cloud/spring-cloud-sleuth/wiki/Spring-Cloud-Sleuth-3.0-Migration-Guide


[chore] upgrade to playwright 1.28.1

the main issue was that checking the stack trace is unreliable
I also changed the test code to ensure we await the console log
https://github.com/microsoft/playwright/issues/18865 has now been fixed, which was causing across-the-board failures in 1.28.0
the lint failure is unrelated: https://github.com/sveltejs/kit/pull/7820#issuecomment-1328272412

triggered a rerun on the mac fail

Same failure as https://github.com/sveltejs/kit/pull/7435:

@sveltejs/kit:test:   1 failed
@sveltejs/kit:test:     [webkit-dev] › test/client.test.js:610:3 › Load › using window.fetch causes a warning ==========

It seems the webkit version has not been able to capture the console logs

IIRC, the stack trace check in fetcher.js was written that way so as to avoid giving false positives for the warning when a fetch happened to be called when a load was running but was not actually called by that load. Do we really need to lose that heuristic? Have you ever observed that fail when running an app for real, or just in the tests? If at all possible, I'd much rather have imperfect tests than a flawed feature that we can more easily test.

Thanks. I updated it to keep the stack trace and added a comment explaining what it's doing. It appears to be passing still


FR: Code Examples

Unfortunately the majority of the documentation linked to in the README does not have Golang examples. Trying to do something as simple as read data from a reference isn't very clear, especially for people new to Go.
It would be fantastic and super helpful if you could include some basic examples in this repo.
Thanks!

@timendez we maintain our documentation at https://firebase.google.com/docs, which has plenty of samples. For instance the database documentation can be found at https://firebase.google.com/docs/database/admin/start.
The links in the README file are just for the convenience of the developers working on the SDK. If you want quick access to some samples you can also check under https://github.com/firebase/firebase-admin-go/tree/master/snippets. These are the same examples that appear in our website.


When is quic going to be available?

Hey guys,
When is enable-quic going to be available in openssl? I just downloaded 3.1-beta1 and it says it's not there yet and there is no http3 without quic.
I know some web servers are using the openssl from quictls, or boringssl for it, but I rather wait for the real thing.
Thanks.

Initial QUIC support will be available in OpenSSL 3.2. However this support is planned to be limited (client side only, single stream only) - not really useable for http3. 3.3 is likely to have more extensive support. 3.2 will be out some time later this year. No timeline for 3.3 yet.

Closing since this is marked as resolved.

Is there a ticket related to more extensive server support? Couldn't find one.

This project epic tracks the QUIC server support https://github.com/openssl/project/issues/52


report/plots: combine train/val/test metrics plots

Some of the callbacks write out train/val/test metrics. Can we combine these onto one plot instead of plotting them all separately?

This doesn't feel like a DVCLive responsibility to me.
Our UIs should have an easy way of building top-level plots from existing individual plots


To support aten::_softmax operator

Should have been resolved by https://github.com/alibaba/BladeDISC/issues/509


Automated Package Upgrade

:tada: This PR is included in version 6.0.105 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


My FACEBOOK proof is unreachable, after ensuring the post is PUBLIC and is my profile.

Keybase GUI Version: 1.0.20-20170317111345+6cc2f52

Is it a personal profile? AFAIK the post has to be on a personal profile to validate, not a page.


404 errors in Google search console

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate
[x] The issue still exists against the latest master branch of Select2
[x] This is not a usage question
[x] I have attempted to find the simplest possible steps to reproduce the issue, but no result.

Steps to reproduce the issue

Google bot scanning some page of my website.
Detecting 404 errors mainly related to select2 js plugin.

404 url errors like:

someUrl/dropdown/selectOnClose
someUrl/selection/search
someUrl/data/maximumSelectionLength
someUrl/data/maximumSelectionLength
someUrl/data/maximumSelectionLength
someUrl/select
someUrl/selection/eventRelay
someUrl/dropdown/closeOnSelect
someUrl/selection/placeholder
someUrl/selection/search
someUrl/selection/single
someUrl/selection/multiple
someUrl/selection/allowClear
someUrl/select2/defaults
someUrl/select2/core/
etc...

I have writed to google today too, so no answer yet.
Maybe some guys, was have similar issues?
Environment
Google search console
Operating System
Google bot logic

jQuery version: jquery-2.1.4
Select2 version: Select2 4.0.2-rc.1
Using templating, from underscore.
All javascript logic is not in separeted js files, but pulled directly into html source into script tag.

Isolating the problem

[x] This bug happens on every page of my website(for google bot).
[x] When I testing, the bug not happens consistently across all tested browsers.
[x] I can not reproduce this bug in js bin. Website is little secret.

I think this is not select2 problem. So closing this.

For some reason Google is interpreting the internal Select2 module paths as external modules, and is trying to load them. This is a bit strange considering no code exists to resolve the internal paths to external files, and we don't package any map files which would possibly cause this.
This isn't something Select2 can solve, this is a Google Search Console issue.

So. how we must reacting on this? Somehow contact with google support? Or is some other way?

So. how we must reacting on this?

Ignoring it is always an option. Assuming you are doing nothing strange, these should be 404 errors in theory rather than in reality.
If more people start to see similar errors, then we can start pooling together reports and we might be able to come up with a fix on Select2's side. Until then, there is honestly nothing that Select2 can do here.

Okay, so will be waiting for news.

Any update on this? Please help in this.


Update README.md

Dear Stella,
Please please please update this README.md file to be more clear!! 🥰

lol


Performance issue with pressmove and stagemousemove on Chrome Android

Hi there!
I've been struggling with implementing a drag and drop feature that would have great performances on all devices but I think there's a problem with pressmove and stagemousemove on Chrome Android (my test device is a Nexus 10, with Android 5.1.1 and Chrome 47.0.2526.83) and can't understand if that's a browser's issue or a framework one.
For example, this (EaselJS) demo works well on all browsers (including Firefox Android) but is very slow on Chrome Android.
Sometimes when dragging a flower, it stops following the cursor, and only jumps back to it when releasing the mouse button.
Has anyone experienced something like this, too?
I tried adding some throttling to the event callback, but that didn't make things better...
Any help is appreciated, thanks!

Same problem here. Extreme performance issues (even freezes) with very simple drag operations on Android Chrome. We have traced the problem to the timing mode of the ticker. We did set it to RAF_SYNCHED:
createjs.Ticker.timingMode = createjs.Ticker.RAF_SYNCHED;
If that solves your problem, the default timing mode TIMEOUT has severe problems...

Have the same problem on a Windows 10 Mobile. Sometimes the app looks really responsive (no freeze for > 60 seconds) but it more often lag.
I am using stagemouseup, stagemousedown and stagemousemove. The stagemousedown function contains some calculations but not something that requires a lot of processing time.
@benwick In my case, your code does not solve the bug. Worst, the app never worked then, nothing moved.
Is there any guidelines about this problem ?
PS : I used pressmove before, the same problem happened.


Add regRF core functions

Proposed changes
Create a features modules for adding and updating afids-auto related features. This PR adds the core utility functions from afids-regRF to afids_utils/features/regRF.py.
Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

[ ] Changes have been tested to ensure that fix is effective or that a feature works.
[ ] Changes pass the unit tests
[ ] Code has been run through the poe quality task
[ ] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

I agree with #2 being more specific towards reg-rf rather than afids utils. A more generalizable way to spin it is the generation of haar-like features around specified fiducials in an image (I would classify as a "second degree" utility as it would involve the usage of an associated image to compute). I am not sure if the vision is to leave these functions (i.e., ones that take in coordiantes + image as input) out of this? Still cool to have down the line for some projects but wonder about contraining scope.

There is a working google doc too from previous discussions of potential functions to implement.

This should address the majority of the review comments. The only ones I haven't changed are mostly related to regRF as it seems like we may be leaning towards leaving them out of afids-utils

Given the impending refactor, I think we can leave merging this one in (and just implement the methods following the refactor). I will turn this into a draft so that it does not accidentally merged in and so we still have the discussion regarding the methods.

Closing this PR now that there has been some discussion about it - will make the branch available.


Feature:  adding support for streaming the LLM responses to stdout

Description
Adding a new command-line flag --stream/ -s allowing users to see the annotated code being printed to stdout live as its being generated vs.  all at once in the end.
Implementation
Implementing the feature would require:

Adding the code for parsing the --stream/ -s option flag argument from the command line in main.py.
Modifying the api.py to set the streaming parameter to true in the request body if streamin was enabled by the option flag
(https://platform.openai.com/docs/api-reference/streaming).
Printing the commented code to stdout as it is received when streaming is enabled.

Closed by https://github.com/arilloid/addcom/commit/343fa83530a794de366ecc94a627ff4362016fa8


Improving Components API

Several improvements in the Components API:

Added _get_all_components_type to retrieve a list of components with the same entity type. Using this in the mesh module.
Close #2406
Close #1070

Added items to get the component items as a tuple. Improvement.

Using save_selection cont manager for the components selection.

Document the component API. Close #2413

Adapt some examples so they reflect those changes.

LGTM :)


Previously closed issue has resurfaced.

Describe the bug
This previously closed issue appears to have resurfaced: https://github.com/microsoft/WindowsTemplateStudio/issues/2726
TabView1.zip
Steps to reproduce the bug
Steps to reproduce the behavior:

Build attached project and look for "XamlCompiler warning WMC1506"

Expected behavior
No such warning.
Screenshots
n/a
Version Info
NuGet package version:
[Microsoft.UI.Xaml.2.6.0-prerelease.210315002]

Windows 10 version
Saw the problem?

October 2020 Update (19042)
Yes

Device form factor
Saw the problem?

Desktop
Yes

Additional context
n/a

Cut and paste code issue.   Sorry, never mind.


Fix lazy loading for original files

Related: #62
We use empty list as a default when we haven't loaded, so we also should check for that in the base.getattribute(). However adding that caused an infinite loop because self.downloader_jobs.append() was triggering a fetch on the original file. Therefore this also prevents original files from triggering a fetch on themselves by building the list of related objects and then setting it on self.

This seems to be only failing in python3.5.... I give up for the day. I'll take a fresh crack at it on Monday


Text or varchar length problem

When executing queries resulting in rows containing text or varchar populated fields, I've an error due to an incorrect calculated length of the stream that follows, containing the value (string).
I'm using Sybase 12.0.1 (ASA 12).
When executing query in the ValueReader.cs switch, when I reach
var textPtrLen = (byte)stream.ReadByte();
for TdsDataType.TDS_TEXT and TDS_VARCHAR it results always in 0 (textPtrLen  = 0).
If I skip 1 byte textPtrLen will have the correct value. I've patched the library for testing purpose in this way
(byte)stream.ReadByte();
var textPtrLen = (byte)stream.ReadByte();
and all query now results in rows correctly populated.
Is this a bug of AseClient library? ... or did I miss something?

Hi @gighen76 ,
When you say ASA 12, can you confirm that you're referring to SQL Anywhere 12?
If that's the case, this driver may not work with it, because we target Adaptive Server (ASE).
While it's possible that ASA and ASE are using the same communication protocol (TDS 5), there could still be quirks between the two systems. On top of that, ASA 12 is quite old (8 years?) which might mean that the quirks have been fixed in a more recent version.
Cheers

As for what the TDS spec has to say on the matter:
TDS_TEXT's data is arranged with the following structure

1 byte status
1 byte text pointer length
n bytes text pointer data (size is text pointer length)
8 bytes time stamp (conditional)
4 bytes data length
n bytes data (size is data length)

And there's a note attached basically saying: if the text pointer length is 0, then the item is null, and there'll be no more bytes to read for that value


Remove last references to DEBUG_SAFESTACK

The DEBUG_SAFESTACK preprocessor define is obsolete since 2008
when the non-safestack code was removed by commit 985de8634000.

Merged, thank you!
a345ce6cb1 Remove last references to DEBUG_SAFESTACK [1.1.1]
d4f63f1c39 Remove last references to DEBUG_SAFESTACK [master]


Backfill Encoder tests to existing modules

This turned into: bring back 100% coverage.  Jest doesn't see a lack of coverage because most modules are just identity encoders.  It doesn't make much sense to test for this, aside from a round-trip (decode . (<$> encoder))


ISSUE-45 - Remove white space

@cunla i've removed the whitespace. Flake8 doesn't complain when I run locally. Not sure why it failed here

I'll fix it.


ipython console did not work

Description
What steps will reproduce the problem?

showing error in python console many option like warning
Traceback
  File "C:\Users\Gautam kumar\Anaconda3\lib\code.py", line 90, in runcode
    exec(code, self.locals)
  File "<console>", line 2, in <module>
NameError: name 'c' is not defined
WARNING:traitlets:kernel died: 18.001856327056885
WARNING:traitlets:kernel died: 18.009437322616577
WARNING:traitlets:kernel died: 18.00262427330017
WARNING:traitlets:kernel died: 18.002742052078247
WARNING:traitlets:kernel died: 18.00050401687622
WARNING:traitlets:kernel died: 18.015498399734497
WARNING:traitlets:kernel died: 18.000831127166748
WARNING:traitlets:kernel died: 18.002195596694946
WARNING:traitlets:kernel died: 18.000490188598633
WARNING:traitlets:kernel died: 18.011126279830933
WARNING:traitlets:kernel died: 18.012251615524292
WARNING:traitlets:kernel died: 18.006957054138184
WARNING:traitlets:kernel died: 18.001238346099854
WARNING:traitlets:kernel died: 18.014904260635376
WARNING:traitlets:kernel died: 18.000163078308105
WARNING:traitlets:kernel died: 18.000141859054565
WARNING:traitlets:kernel died: 18.01362442970276
WARNING:traitlets:kernel died: 18.01298451423645
WARNING:traitlets:kernel died: 18.00689148902893
WARNING:traitlets:kernel died: 18.015443086624146
WARNING:traitlets:kernel died: 18.009986400604248
WARNING:traitlets:kernel died: 18.00681471824646
WARNING:traitlets:kernel died: 18.00182557106018
WARNING:traitlets:kernel died: 18.000938892364502
WARNING:traitlets:kernel died: 18.015543460845947
WARNING:traitlets:kernel died: 18.00479769706726
WARNING:traitlets:kernel died: 18.015544891357422
WARNING:traitlets:kernel died: 18.000047206878662
WARNING:traitlets:kernel died: 18.014337062835693
WARNING:traitlets:kernel died: 18.00616145133972
WARNING:traitlets:kernel died: 18.013060569763184
WARNING:traitlets:kernel died: 18.000687837600708
WARNING:traitlets:kernel died: 18.0152530670166
WARNING:traitlets:kernel died: 18.00043797492981

Versions

Spyder version: 3.3.2
Python version: 3.7.1
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 10

Dependencies
pyflakes >=0.6.0  :  2.0.0 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pygments >=2.0    :  2.3.1 (OK)
sphinx >=0.6.6    :  1.8.2 (OK)
rope >=0.9.4      :  0.11.0 (OK)
jedi >=0.9.0      :  0.13.2 (OK)
nbconvert >=4.0   :  5.4.0 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
numpy >=1.7       :  1.15.4 (OK)
sympy >=0.7.3     :  1.3 (OK)
cython >=0.21     :  0.29.2 (OK)
qtconsole >=4.2.0 :  4.4.3 (OK)
IPython >=4.0     :  7.2.0 (OK)
matplotlib >=2.0.0:  3.0.2 (OK)
pylint >=0.25     :  2.2.2 (OK)

This is most probably caused because you have a file named code.py in your current directory. You need to rename or remove it to fix this error.

Closing because of lack of response.


Add support to allow pose angles in degrees

This PR added the functionality to specify Pose angles in degrees also.

angle_units parameter is introduced to specify the units of the angle.
if angle_units is not specified, the default unit is set to radians.
modified demo script to verify the correct behavior when angle_units is set to degrees.

Unit Tests added to verify and test new functionality

I've tried to cover all cases to the best of my knowledge, but there may still be some areas that need improvement. Please let me know what I've missed.

Another thing to consider, which I missed in your last PRs, is to update any documentation that describes what is possible with YAML worlds:
https://github.com/sea-bass/pyrobosim/tree/main/docs/source/yaml
This would be both for colors and for pose units


⚠ Bofrost.at has degraded performance

In 7a299f0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 946 ms

Resolved: Bofrost.at performance has improved in 2c90304 after 6 minutes.


⚠ Processors has degraded performance

In 3cd6897, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 81 ms

Resolved: Processors performance has improved in 026a372.