Duplicated author name when no avatar is defined in _data/authors.yml

[ ] This is a question about using the theme.
[ x ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
[ x ] This is a feature request.
[ x ] I have updated all gems with bundle update.
[ x ] I have tested locally with bundle exec jekyll build.

Environment informations

Minimal Mistakes version: master
github-pages or jekyll gem version: jekyll
Operating system: Ubuntu 16.04

Expected behavior
I have a site avatar configured in _config.yml, and I have no author avatar defined in _data/authors.yml.
I expect to have the site avatar displayed at home screen, and when I click on a post by that author, I have no avatar, only the Author name, bio, links, etc.
However what I see is a duplication of author's name just like in the picture:

In the _data/authors.yml I have tried to use avatar: "" and not add any avatar at all, the same result.
So I thought it was a mistake in the _includes/author-profile.html and tried to debug it. I tried, for example:
`
+{% if author.avatar %}

     {% if author.avatar contains "://" %}

@@ -13,6 +14,7 @@

     {% endif %}

+{% endif %}
`
But, it looks like, because I have `site.author.avatar` on the `author.avatar` does exist, but is kind of empty somehow.
I solved this locally by using avatar: 'none' in _data/authors.yml and changing  _includes/author-profile.html by:
`
+{% unless author.avatar == 'none' %}

     {% if author.avatar contains "://" %}

@@ -13,6 +14,7 @@

     {% endif %}

+{% endunless %}
`
but I think it's far from a good solution. Anyway, I would not know which would be a good solution for the theme as maybe the default behavior would be use the site.author.avatar instead of displaying nothing like I'm doing now.
Steps to reproduce the behavior

assign a site avatar in the author from _config.yml
create _data/authors.yml with one author without avatar
assign a post to the author from _data/authors.yml.
display the post

Please, let me know if you can reproduce the issue of if there is anything else I can provide. If you have an idea on how to better solve this I can prepare the patch if you want.

Yes this is definitely a bug. I recently fixed it in an unreleased version of the theme https://github.com/mmistakes/minimal-mistakes/commit/50d4b1b9a8eb4922aa6e8498b5b8f2c9ca52eae5. The fix is actually quite simple.
What you want to do is wrap the author.avatar bit in _includes/author-profile.html with a Liquid conditional that checks if there is an avatar image.
Wrap

 like so and you should be all set.
  {% if author.avatar %}

    {% if author.avatar contains "://" %}

    {% else %}

    {% endif %}

  {% endif %}

Now when avatar is blank you won't get the empty  element on the page with alt showing the author name... making it look like it's duplicated.

Thanks for your help on this. I have tried it yesterday locally but maybe the browser cache confused me.
It worked in the server. There is a draft here https://imxdev.gitlab.io/tutorial/Install_SDL_devel/
And, let me take this opportunity to ask: Do you want the upstream of this patch:
https://gitlab.com/imxdev/imxdev.gitlab.io/commit/c51a3e312ff4ee33bde48d05a8bfabe47e0a9d9e
Thanks a lot for your time <3


Document the current ways to sequence tasks

The nifty new macro syntax makes it easy to write a task that triggers subtasks.  It's tempting to write code like this:
runRemote := {
   val stopped = stop.value
   val deployed = deploy.value
   val started = start.value
   val launched = launch.value
}

and expect that the subtasks would run in sequential order.  (Unfortunately, the tasks might
run in sequential order sometimes, which will surely confuse the unwary.)
The documentation should clarify that tasks will generally run concurrently, possibly as tasks are introduced in the docs and certainly as tasks are discussed in detail.
On the detail page, I'd suggest explaining one or more ways to control task sequencing.
I think there are a few..

use the output of one task as the input to another
arrange a string of dependsOn calls between the subtasks
arrange a chain of taskDyn calls
execute them within a Command via runTask

Task sequencing seems to come up around integration tests, so I'd suggest using that as an example.
Eugene also brought this up.

http://www.scala-sbt.org/0.13/docs/Howto-Sequencing.html

@eed3si9n Thanks for adding these pages. In the last section "How to sequence using commands",
the example you've provided doesn't seem to compile for me. The compiler claims that :: is not defined on String.
I tried adding :: Nil to the end of the sequence thinking that you were building a List but this sort of expression has no effect. The List is generated but the net-effect of the Command is a no-op.
Am I misunderstanding something?


consider Firefox when checking for Android Stock Browser

Brief description of the changes
This PR changes to Android Stock browser detection to consider the existence of Firefox in the browser's user agent string.
Firefox for Android is a modern, well maintained browser which supports the latest web technologies, but since it does not contain Chrome in the user agent string, it is treated as stock browser.
Opera Mobile and Edge for Android do both contain Chrome in their user agent string and are already working.
This PR fixes #1978 and is essential for the picture resizing in the Diaspora* social network, where due to the user base Firefox mobile has a higher share.
What browsers and operating systems have you tested these changes on?
Chrome for Android, Firefox for Android
Have you written unit tests? If not, explain why.
no relevant code changes for this.

Is there a timeline until when we can expect a merge of the pull request? 🙁

Hi @Fensterbank , I will need to test the PR just to make sure nothing breaks.
 I'm not finding time to do so at the moment but I'm hoping to have some time next weekend. Will try to do my best.


Add some docs for util functions

@zphang walked me though some of his code, capturing some of what I learned in docstrings.

See comments.

Thanks @zphang — addressed your comments with changes in 3a8c3df.


How to SetState or make change sensor data

I want to write sensor. But i cannot change sensor state value. Please see my code
public class TestSensor : NetDaemonApp
{
    public async override Task InitializeAsync()
    {
        Log("Init!");
        var sensor=Entity("sensor.testsensor").SetState("10").ExecuteAsync();
        Log("done");
        //await SetState("sensor.testsensor",10);
    }
}

It works without error. All logs printed. But cannot change sensor value.

Thank you for reporting @ebattulga. Do you get  a state object back from the
await SetState("sensor.testsensor", 10); or null? Also try await SetState("sensor.testsensor", "10"); to see if it is different?

await SetState("sensor.testsensor", "10"); return null

I'm creating sensor.testsensor manually in Developer tools > State tab
When i try to get state value from netdaemon app. It works great.
        var state = GetState("sensor.testsensor")?.State;
        if (state != null)
        {
            Log(state.ToString());
        }

Ahh ok I will look into that after work. I will keep you posted. Thanks again for reporting this! I will check and make sure nothing is broken.

Can confirm this behavour is when running in the add-on but can not reproduce running in dev environment. @ebattulga  can you please confirm it runs as expected in devenvironment?

Fixed in #17. Due to internal name changes in Home Assistant add-on the SetState stopped working.
See release for details: (178e1bd).
Add-on version fixed: 0.0.34
Nuget Version (make sure to update in dev environment csproj file): 0.1.42-alpha
Keep this issue open for a while incase other have not uppgraded and gets this issue

Great. Now working successfully.


Unable to upload a new image in settings

Browser and device:
Browser: Chromium && Firefox
Unable to update my image and no error message was received.

This is a problem we are already aware of and trying to solve. Thanks for the report, anyway 🙏🏼


manifest loading performance

motivation: improve dependency resolution performance
changes: use semaphore instead of operation queue when loading manifests which has lower overhead and allows us to manage the concurrency more accurately as the operation queue syle did not wait for the loading to complete

cc @pcbeard

@swift-ci please smoke test

ci infra issues failing PRs cc @shahmishal

@swift-ci please smoke test linux

@swift-ci please smoke test


Remove official IRC channel

#ninenines is gone, you said 😓 And freenode is down the gutter... 🙄

Merged, will push soon. Thanks!


add test programs for load and store instructions

Added test programs for following load instructions:

jump_indirect
load_i8
load_u16
load_i16
load_u32
load_imm_and_jump
store_imm_indirect_u8
store_imm_indirect_u16
store_imm_indirect_u32
store_indirect_u8
store_indirect_u16
store_indirect_u32
load_indirect_u8
load_indirect_i8
load_indirect_u16
load_indirect_i16
load_indirect_u32
store_imm_u8
store_imm_u16
store_imm_u32

Additionally:

add stricter type checking of immediate constants

Thanks!


Support Unix Domain Socket Mode Configuration

It would be useful to be able to specify the mode of a listening unix domain socket.
I think this requires two changes:

Add a mode field to the envoy.api.v2.core.Pipe proto.
Create the socket with the specified mode in address_impl.cc. I think this can be done via fchmod before the bind, but this may not be totally portable.

@ggreenway thoughts here?

I agree that it would be useful. It also makes sense to be able to set the group of the socket-file.
This only applies to listeners, so I don't know that attaching it to core.Pipe is the right place, because that is used for both listen and connect. On the other hand, there isn't a good place to put that config, so maybe we could add it to core.Pipe and document that these fields are only used in some contexts.

Since the listener configs take in a oneof, we could potentially introduce a new ListeningPipe proto or something. That way we retain backwards compatibility with existing configs using Pipe (possibly deprecating it for a later removal), and the new type is listener-specific and can add stuff like mode/group/etc.
Not sure if it's worth the extra noise though.

@llchan I would be fine with either option. Agreed the oneof is probably cleaner. You could even include Pipe inside the ListeningPipe such that ListeningPipe only has the extra options.


Refactor the single qubit Clifford gate

This PR mainly moved the SingleQubitCliffordGate as the derived class of CliffordGate.
It didn't add any new functionalities or features. The code change looks large but actually not. Because I moved the
SingleQubitCliffordGate to the place after CliffordGate and auto-diff is not that smart enough to tell that. Context #4791.
Main change are:

Modify the value equality so that SingleQubitCliffordGate can be evaluate equal to the same CliffordGate
Moved the module-level initialization common SingleQubitCliffordGate (like X, Y, Z) to the class-level one.
Make a few function SingleQubitCliffordGate to use CliffordGate one.

Automerge cancelled: There are merge conflicts.

Looks like there is still a little bit of formatting and merge conflicts.

Yeah, that probably is because of recent black version update. Hopefully, it is resolved now.


Obsolete "primary growth" GO:0080189

No annotations to this term
The label is very ambiguous (it only applies to plant structures)

@tberardini are you ok with this? I'm not sure why we don't have secondary growth. Was it obsoleted?

@ukemi  : We do have 'secondary growth'. http://amigo.geneontology.org/amigo/term/GO:0080117
@selewis : Would a change in primary term label to 'plant primary growth' be enough to retain this term?  Though this term has not been used for annotation, I think this is a legitimate biological process.

@tberardini - Yes, I can see keeping it. But as a whole the direct children of growth are a motley assortment of classes without seeming rhyme nor reason. It would be helpful if someone reviewed this area to make it more sensible and intuitive. I'm not sure it's placement in the graph is optimal.
That said, the same is true of the children of DNA repair, and that needs cleanup more urgently.

Hi @selewis I create projects in the Ontology repo for 'growth' and 'DNA repair' (we should create a few others that come up often). The ontology editors/managers can prioritize these, once ongoing projects are done (ECM + MF refactor/transcription).
Thanks, Pascale


TeraEd: Run Terasology in Swing/AWT

Contains
Run Terasology in TeraEd

How to test
Run Terasology and check if it works unchanged (I didn't run much tests)
Run TeraEd and check if Terasology starts in it (currently only game menu works)
Notes
This is first small step to make TeraEd do something, but I actually doubt this will be merged as it makes a bit of a (additional) mess in the code.
Changes modify rendering methods, because for the openGL to run in canvas, you need to run all opengl operations during canvas render instead of typical at any time assuming GL window exist. Also swing rendering thread needs to be used instead of main loop.
If approved, more functionality could be added to TeraEd. Feel free to recommend any improvements or if anyone know how to make it load a save/new game, let me know...

I failed at all attempts to make this work beyond rendering of the game menu as there seems to be some issue with order of initialization. I think it would require deeper separation of rendering and main thread or different approach. Blocks are visible in game after graphical settings is changed, but there are still other issues...
But if interested, I think it might be still ok to include this if it won't break/slows main game and make it work later.

@hajdam that's more function then what is currently in the eninge. not too bad to have this working again if only in some basic capacity. I do remember this coming up that might be relevant to this effort.
https://github.com/JetBrains/compose-jb

Calling refreshing DAG helps(i did it in debug). World rendering began renders right.
Idk why...
Dag refreshing at start and at change settings.
It is happens in sane thread. (Via WorldRenderer#render)
@dave2s can you help? Any ideas?
@hajdam TeraPC works. I think we can merge this PR when black screen in game will resolved. Thx for TeraED restoring!

Still no luck

After few painful hours, hopefully it will work at least a bit. Please test this on Mac OSX.

Nice work @hajdam !
I tested on Mac but did not get very far. I adjusted the TeraEd run config to include the unique parameters we need for Macs, but still get a very Mac-sounding error on trying to start. I imagine @DarkWeird did something to the PC facade as part of the LWJGL3 upgrade that we might need to replicate for TeraEd
/Users/cervator/dev/zulu11.31.11-ca-fx-jdk11.0.3-macosx_x64/bin/java -Xms256m -Xmx1536m -XstartOnFirstThread -Djava.awt.headless=true -javaagent:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar=64504:/Applications/IntelliJ IDEA CE.app/Contents/bin -Dfile.encoding=UTF-8 -classpath /private/var/folders/j9/9d141hz563x0qdq1098_92100000gp/T/classpath157599996.jar org.terasology.editor.TeraEd -homedir -noCrashReport -noSplash
Exception in thread "main" java.awt.HeadlessException
	at java.desktop/java.awt.GraphicsEnvironment.checkHeadless(GraphicsEnvironment.java:208)
	at java.desktop/java.awt.Window.<init>(Window.java:548)
	at java.desktop/java.awt.Frame.<init>(Frame.java:423)
	at java.desktop/java.awt.Frame.<init>(Frame.java:388)
	at java.desktop/javax.swing.SwingUtilities$SharedOwnerFrame.<init>(SwingUtilities.java:1919)
	at java.desktop/javax.swing.SwingUtilities.getSharedOwnerFrame(SwingUtilities.java:1995)
	at java.desktop/javax.swing.JWindow.<init>(JWindow.java:183)
	at java.desktop/javax.swing.JWindow.<init>(JWindow.java:135)
	at org.terasology.editor.TeraEd.<init>(TeraEd.java:33)
	at org.terasology.editor.TeraEd.main(TeraEd.java:42)

Specifically the Mac-specific params are -XstartOnFirstThread -Djava.awt.headless=true and it is probably that headless AWT thing we're running into. We needed that for the main PC facade for whatever reason, maybe @DarkWeird can expand on that, maybe on Discord sometime?
It might be something easy - and I hope so, since it can be tricky to deal with Mac specific issues, especially when it about takes a rendering wizard to experiment :-)
On a different note are all the changes in this PR legitimately related to just TeraEd? It looks to me like there's a bunch more stuff including auto-formatting, type fixes, and a ton of LWJGL stuff that makes me wonder if the LWJGL3 upgrade commit somehow got included in the diff over some quirk.

Yeah.
'-XstartOnFirstThread' required.
Headless not needs( i hope at least, because we use awt on teraED in headed mode)
Just another run config fir TeraED.
Lwjgl3 code from engine was refactored legally :D
Extracted some common parts. DRY. (And also formating)

Oho! Thanks for that, both the confirmation of changes and the headless note. Taking off that flag did get me further, I guess we needed it specifically for the regular game, but now specifically not for TeraEd.
Now it just arbitrarily stops after this point:
/Users/cervator/dev/zulu11.31.11-ca-fx-jdk11.0.3-macosx_x64/bin/java -Xms256m -Xmx1536m -XstartOnFirstThread -javaagent:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar=65016:/Applications/IntelliJ IDEA CE.app/Contents/bin -Dfile.encoding=UTF-8 -classpath /private/var/folders/j9/9d141hz563x0qdq1098_92100000gp/T/classpath381416710.jar org.terasology.editor.TeraEd -homedir -noCrashReport -noSplash
PathManager being initialized. Initial code location is /Users/cervator/dev/terasology/git_ws/mini/Terasology/engine/build/classes
Switched it to expected working dir: /Users/cervator/dev/terasology/git_ws/mini/Terasology
installPath was null, running from IDE or headless server? Setting to: /Users/cervator/dev/terasology/git_ws/mini/Terasology
Found the natives dir: /Users/cervator/dev/terasology/git_ws/mini/Terasology/natives
15:09:28.214 [main] INFO  c.b.gdx.physics.bullet.NativeSupport - Loading JNBullet Library:bullet
15:09:28.249 [main] INFO  c.b.gdx.physics.bullet.NativeSupport - 	Loaded from java.library.path: /Users/cervator/dev/terasology/git_ws/mini/Terasology/natives/macosx/libbullet-darwin-amd64.dylib

At this point a little exec window named java has shown up, but there's seemingly no way to make it visible.
Still, considering that TeraEd doesn't work anyway, it seems like we should probably just merge this as-is? Even if TeraEd remains broken on Mac that doesn't seem like a huge loss.

Hopefully properly merged. Am I suppose to perform merges to keep the PR up to date? Or was it already denied / not accepted, or is it just missing something or people are just busy...?

Hopefully properly merged. Am I suppose to perform merges to keep the PR up to date? Or was it already denied / not accepted, or is it just missing something or people are just busy...?

Hopefully properly merged. Am I suppose to perform merges to keep the PR up to date? Or was it already denied / not accepted, or is it just missing something or people are just busy...?

Just busy! Plus we were trying to stabilize a few things over the holidays to see if we could get a good build, before merging in tons more stuff. That's past now and I've got this sitting in a browser tab myself for merging soon ™ if nobody else beats me to it :-)

Hopefully properly merged. Am I suppose to perform merges to keep the PR up to date? Or was it already denied / not accepted, or is it just missing something or people are just busy...?

Just busy! Plus we were trying to stabilize a few things over the holidays to see if we could get a good build, before merging in tons more stuff. That's past now and I've got this sitting in a browser tab myself for merging soon ™ if nobody else beats me to it :-)


The entire 3. Writing Gleam section in the book is blank

As in the issue name, the whole 3rd section in the book is blank.  However, the details are present on the documentation site itself.
For example:

Docs: Creating a Project
Book: Creating a Project

Oops, thank you.

Same with the first section


MSFT_xWebAppPoolDefaults: Move localization strings to strings.psd1 file #470

Move localization strings to strings.psd1 file
This Pull Request (PR) fixes the following issues
Fixe #470
Task list

[ ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #519 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev     #519   +/-   ##
=======================================
  Coverage   91.39%   91.39%
=======================================
  Files          17       17
  Lines        2661     2661
=======================================
  Hits         2432     2432
  Misses        229      229

Impacted Files
Coverage Δ

..._xWebAppPoolDefaults/MSFT_xWebAppPoolDefaults.psm1
97.61% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22802e7...ca1ada5. Read the comment docs.

Please update this PR similar to https://github.com/PowerShell/xWebAdministration/pull/514.

CHANGELOG.md updated

@omiossec Thank you for the contribution! This got us closer to HQRM. 😄


UA review of download.md

UA review.
Before submitting a pull request, Please make sure the following:
Description
Please explain the changes you made.
Link to design (if applicable)
Checklist

[ ] Code compiles correctly
[ ] Relevant tests were added (unit / contract / integration)
[ ] Relevant logs were added
[ ] Formating and linting run locally successfully
[ ] All tests passing
[ ] UA review
[ ] Design is documented
[ ] Extended the README / documentation, if necessary
[ ] Open source is approved

No comments


Stringified Predicate Info

stringifying the predicate info for better debugging and understanding of which predicate and which values
I've been wanting this for a long time!

output of TimeoutException provided no information of the predicate (just <lambda>)  for tests with many waits it was hard to know what actually timed out.
now the output looks like:  shakedown.dcos.spinner.TimeoutExpired: Timeout of 2.0s expired waiting for function: mesos_task_present_predicate(task_name) params: {'timeout_sec': 2, 'task_name': 'blue'}

needed to rebase!

Waiting on CI results before merging


How to reproduce the streaming experiment?

Hi, thanks for sharing the codes.
I checked the codes but did not find the codes or instructions for reproducing the results of the streaming setting. Did I miss something? Or will you provide instruction on reproducibility in the future?

Hi :) Great to hear from you! We have not uploaded that at this moment, unfortunately. Feel free to send me an email if you want further guidance :)

I tried to run the streaming experiment by the following command
# non-streaming
python run.py --eval_on test --test 1 --train 0 --ckpt_folders mnistarm_bn_0_20220601-190129/ --log_wandb=False --adapt_bn=1
# streaming
python run.py --eval_on test --test 1 --train 0 --ckpt_folders mnistarm_bn_0_20220601-190129/ --log_wandb=False --support_size=1 --adapt_bn=1

where I suppose the support_size=1 should be input one sample at one time. But it turns out the streaming (the 2nd run) performs much poorer than the first one. Is there any other parameters I should modify for the streaming setting?

Hey! Yeah, this isn't exactly correct but the spirit is right! The above won't update the c vector appropriately over time and will instead just be the same as having support size 1.
I sent you an email giving more details on what changes need to be made. I'll have more time on Sunday to give more hands-on guidance if that's not too late for you?


Allow for checking field level annotations from DiffNode (getFieldAnn…

…otations() functions added, similarly to getPropertyAnnotations()).
It is important specially for handling JPA classes where annotations can be at both places.
An alternative for the user of the library would be to use DiffNode%getParentNode()%getValueType() and DiffNode%getPropertyName() to do the same without the getFieldAnnotations() functions.
The client may even use something like Jandex (https://github.com/wildfly/jandex).

Coverage decreased (-0.84%) to 87.77% when pulling 46d4b4554dca79172eda301fef874e8d8f319d96 on NagyGa1:feature/field_annotations_checking into 741520df8789bbeaef002a004134086afff5e91a on SQiShER:master.

Thanks for the pull request! The implementation looks good to me. :+1:
Other than the small gripes from above, the only thing that's keeping me from merging it right away is the lack of tests. It would be nice to see some unit and/or integration tests, to avoid future changes from accidentally breaking this feature.
I'd like to see at least one integration test following the happy path via ObjectDiffer.compare(), to make sure the feature actually works. Just put a new Spock test class here and give it a feature related name followed by "IT".
I'd also like to see a couple unit tests for the public getFieldAnnotation(Class<T>) method, basically testing all the branches of the implementation:

field exists in given path
no such field, with superclass
no such field, without superclass
no such field, with superclass that has the field
no such field, with superclass that does not have the field
annotation found
annotation not found
etc.

You get the idea... :wink:
Other than that, great PR. I'm looking forward to merging it.

Looking at the ITs, might take a while, need to learn Groovy first.

Coverage decreased (-0.84%) to 87.77% when pulling e156e69d1da87b2c809c69b806bf1422d64925fe on NagyGa1:feature/field_annotations_checking into 741520df8789bbeaef002a004134086afff5e91a on SQiShER:master.

...and Spock.

Ok, adjusted javadocs, added unit tests on, let the line breaks (please clarify).
Not sure about integration test, the feature is not integrated at the moment, solely to be called directly on DiffNode. Have not looked at integration to comparisons or inclusions.

Coverage increased (+0.11%) to 88.72% when pulling 64180b9312a7a0b909ca6e14978b5f19c9067087 on NagyGa1:feature/field_annotations_checking into 741520df8789bbeaef002a004134086afff5e91a on SQiShER:master.

Ok, adjusted javadocs, added unit tests on, left the line breaks (please clarify).

Looks good to me. Regarding the line breaks: just put each curly brace on its own line.

Should getPropertyAnnotations() marked deprecated, merged with getFieldAnnotations() under the name of getAnnotations(), then used in the integrated part of the library? Changes a few contracts slightly.

I wouldn't do that for now. I think it is more flexible the way it is. If it turns out to be a hassle, I'd prefer adding another convenience method that uses the other ones internally, but still keep the other ones public.

Not sure about integration test, the feature is not integrated at the moment, solely to be called directly on DiffNode. Have not looked at integration to comparisons or inclusions.

Good point. Yet I always like to see a feature working by using it like an actual user, just to be sure. But I can add the test myself. I already wrote one yesterday to play around with the feature. So don't sweat it.
Just fix the line breaks, squash your commits into one and we're good to go. :+1:

Thank you, will do it shortly.
I use the feature like this:
package com.cpox.view.config.expimp;

import java.lang.annotation.Annotation;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import org.javatuples.Pair;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import de.danielbechler.diff.inclusion.Inclusion;
import de.danielbechler.diff.inclusion.InclusionResolver;
import de.danielbechler.diff.node.DiffNode;

/**
 * Excludes given annotations.
 */
public class AnnotationExclusionResolver implements InclusionResolver {

	private static final Logger LOG = LoggerFactory
			.getLogger(AnnotationExclusionResolver.class);

	private final List<Class<?>> excludedAnnotations;

	private Map<Pair<Class<?>, String>, Inclusion> responseCache = new HashMap<>();

	public AnnotationExclusionResolver(final List<Class<?>> excludedAnnotations) {
		this.excludedAnnotations = excludedAnnotations;
	}

	@Override
	public Inclusion getInclusion(final DiffNode node) {

		// generate ID for cache retrieval
		final Pair<Class<?>, String> id = new Pair<Class<?>, String>(node
				.getParentNode().getValueType(), node.getPropertyName());

		// check from cache
		Inclusion response = responseCache.get(id);

		if (response == null) {
			// not in cache, calculate value
			response = calculateInclusion(node);
			responseCache.put(id, response);
			if (LOG.isDebugEnabled() && response == Inclusion.EXCLUDED) {
				LOG.debug("{} {}", id, response);
			}
		}

		return response;
	}

	private Inclusion calculateInclusion(final DiffNode node) {
		for (Class<?> excludedAnnotation : excludedAnnotations) {
			for (Annotation annotation : node.getPropertyAnnotations()) {
				if (annotation.annotationType().isAssignableFrom(
						excludedAnnotation)) {
					return Inclusion.EXCLUDED;
				}
			}
		}
		for (Class<?> excludedAnnotation : excludedAnnotations) {
			for (Annotation annotation : node.getFieldAnnotations()) {
				if (annotation.annotationType().isAssignableFrom(
						excludedAnnotation)) {
					return Inclusion.EXCLUDED;
				}
			}
		}
		return Inclusion.DEFAULT;
	}

	@Override
	public boolean enablesStrictIncludeMode() {
		return false;
	}
}

Ok, done.

Coverage increased (+0.11%) to 88.72% when pulling fd2da3f30eae53f66e09e3662c79707d114d1903 on NagyGa1:feature/field_annotations_checking into 741520df8789bbeaef002a004134086afff5e91a on SQiShER:master.

Coverage increased (+0.11%) to 88.72% when pulling fd2da3f30eae53f66e09e3662c79707d114d1903 on NagyGa1:feature/field_annotations_checking into 741520df8789bbeaef002a004134086afff5e91a on SQiShER:master.

Thanks for this PR and also for sharing your AnnotationExclusionResolver. It's great to see the InclusionResolver (which is a fairly new feature) being leveraged in such a good way!

I'll release a new version over the weekend, so you won't have to use a snapshot for too long.

Thank you very much.

Sorry, I am not too experienced in GitHub: should I delete my branch / fork?

@NagyGa1 Version 0.92.1 is now released and should soon (in about 2 hours) be available via Maven Central.

Thank you very much.
You can't sleep?
On Sat, 6 Jun 2015 6:52 am Daniel Bechler<EMAIL_ADDRESS>wrote:

@NagyGa1 https://github.com/NagyGa1 Version 0.92.1 is now released and
should soon (in about 2 hours) be available via Maven Central.
—
Reply to this email directly or view it on GitHub
https://github.com/SQiShER/java-object-diff/pull/134#issuecomment-109469771
.

Nah, had too much caffeinated iced tea :smile:

I am ashamed to admit drinking decaf coffee these days. :/
Anyway, tks for the fast release!
On Sat, 6 Jun 2015 6:56 am Daniel Bechler<EMAIL_ADDRESS>wrote:

Nah, had too much caffeinated iced tea [image: :smile:]
—
Reply to this email directly or view it on GitHub
https://github.com/SQiShER/java-object-diff/pull/134#issuecomment-109471449
.


Fixes a crash when no mod folders are founded

I get a crash every time i open codename without mod folders and this fix it :)

Self Insert


Fix missing methods on tools.log

Why?
I've been wondering why tools.log.disable() doesn't work; it's a handy method that would disable the logger in tests. Turns out Object.assign() doesn't clone prototype methods, so the wrapLogger private method that enabled a callable tools.log was omitting unbound methods:
// This works
tools.log.info()
// This does not
tools.log.disable()

How?
Object.setPrototypeOf is magical. Unfortunately this required some type declaration merging, because @types/signale does not have the disable() method.

[x] Tests have been added/updated (if necessary)
[x] Documentation has been updated (if necessary)

FWIW: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/34313


Basic functions

[x] Create a node api template
[x] Create a react component with exports from the same index
[ ] Create a react-native component

[ ] Create a .gitignore file based on generated templates


Mock error (FileInputStream)

Description
utbot-cli not generated anything if java.io.FileInputStream.read is called (FileInputStream mocked)
To Reproduce
public class JavaIoFileInputStreamCheck {
    public void read(String s) throws IOException {
        java.io.FileInputStream fis = new java.io.FileInputStream(s);
        byte[] b = new byte[1000];
        int size = fis.read(b);		// fail there
    }
}

run utbot-cli:
java -jar utbot-cli-2023.03-SNAPSHOT.jar generate --classpath "/home/andrew/ex/build/classes/java/main" --source /home/andrew/ex/src/main/java/org/example/JavaIoFileInputStreamCheck.java --output Test.java org.example.JavaIoFileInputStreamCheck --mock-always java.io.FileInputStream

Expected behavior
Something generated
Actual behavior
Nothing generated (smth wrong with fis.read)
package org.example;

public final class Test {
}

Visual proofs (screenshots, logs, images)

Without force mock option --mock-always java.io.FileInputStream UTBot generates couple of tests, though they do not look very useful: one with NPE and second is disabled by sandboxing.


Is this project still maintained?

Last real update is from 2022, a nice PR updating to node 20 is open and needed, but ignored. As well as other open issues.
Is there still somebody here maintaining the action?

I replaced this action with docker/login-action

        name: Login to ACR
        uses: docker/login-action@v3
        with:
          registry: <registry-name>.azurecr.io
          username: ${{ secrets.AZURE_CLIENT_ID }}
          password: ${{ secrets.AZURE_CLIENT_SECRET }}

docker/login-action@v3 uses Node 20 as default runtime.

Thank you @soderlind, that worked great for me

My first time using Azure and following the instructions as seen in here. Lost quite a handful of hours figuring out why pushing to ACR on my GitHub Actions kept on failing with unauthorized: authentication required, visit https://aka.ms/acr/authorization for more information. Swapped azure/docker-login@v1 for docker/login-action@v3 and it finally worked, what?

I came here looking if this has improved since I evaluated and rejected this action. Nothing has improved. It still has all the problems and now even more without node20.

This action modifies directly the docker configuration file.
We use federated authentication with azure/login and I'm not sure if this would work even if I took the token from azure/login and saved it as password for the magic 00000000-0000-0000-0000-000000000000 user. It should do the magic automatically.
It has no run.post step to remove the token, so bad leaving credentials laying on self-hosted runners.

For us it is better to just run az acr login (a wrapper for docker login that digs the credentials from azure/login for us) and run docker logout as an if: always() step later in the workflow.

it's not maintained anymore. Original team does not had bandwidth to maintain it. I just asked the access to upgrade to node20. that's it


Add page to create an itineraries for events

Breakout item from issue #799
A basic page is needed which allows an organizer to create a new itinerary for an event. The itinerary will be bound to a specific date on which any attached requests are expected to be completed.
Requests can be added to an itinerary if they are not already completed or attached to an existing future itinerary.
A team of volunteers can be selected from the available task assigned volunteers.
This will include an initial persistence model to store the itinerary in the database.

@tonysurma Please assign to me


A number of logic errors appear when running Xcode's Analyze utility

Go to Xcode > Product > Analyze

Should be fixed now, can you check version 3.0.0?


Added functionality to set the step id

Type of Change

[X] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
It was not possible to set the tepid for a job step. It was either the step name or the step id.
After some reconfigurations it is not possible to set the step id.
You can even enter a step before another on by supplying the step id where the new step needs to go
Screenshots
Creating the new step

The result

heck yeah, thank you sander!


Unsupported option: -no-canonical-prefixes on Android

Running config with '-no-canonical-prefixes' gives an error about it being an unsupported option.
MACHINE=armv7-a CC=/opt/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc RELEASE=2.6.37 SYSTEM=android ARCH=arm ./config "-march=armv7-a -marm -mfpu=neon -mfloat-abi=softfp -funwind-tables -no-canonical-prefixes -fexceptions --sysroot=/opt/ndk/platforms/android-19/arch-arm -fPIC" threads no-shared
This option should be supported.
Error:

Operating system: armv7-a-whatever-android
Configuring for android-armeabi
***** Unsupported options: no-canonical-prefixes
Configuring OpenSSL version 1.1.0e (0x1010005fL)
make[2]: *** [OpenSSL-prefix/src/OpenSSL-stamp/OpenSSL-configure] Error 255

Full compile output: https://travis-ci.org/ingenue/hunter/jobs/215460184

why? what does it do?  openssl configure normally looks at all no-XXX options as configuring openssl things.

Ahem, because some people wouldn't stop using arguments like -no-asm instead of no-asm, Configure does s/^-no-/no-/ on all arguments (*). This was added eons ago, I'm surprised it took so long before someone got bitten. Congrats, @xsacha, you're it ;-)
We should really remove that line...

(*) it's commented "# some people just can't read the instructions"

So as a workaround I should be doing s/^-no/--no/ on flags sent to config?
Thanks.
Strange it is from eons ago, I have only noticed in 1.1.0+.

So as a workaround I should be doing s/^-no/--no/ on flags sent to config?

If your compiler takes --no-canonical-prefixes, then yes, that's a workaround

Strange it is from eons ago, I have only noticed in 1.1.0+.

Interesting... 'cause I find that same line in 1.0.2's Configure

perhaps we should teach Configure that -- means end of options, and everything else is just added to the CC flags?

Rich Salz wrote:

perhaps we should teach Configure that -- means end of options, and everything else is just added to the CC flags?
I'm not sure that is good idea unrecognized options to be added to CC

If options is "unrecognized" as work around user should set manually CC .
Or may be openssl script could be enhanced to recognize compiler flags
similarly as linker -Wl... -Wc...
As alternative -Xlinker vs -Xcompiler : used by another wrappers.
Roumen

What is the expected way to set CFLAGS to config right now because I am doing CC=clang ./config "$CFLAGS"

If your compiler takes --no-canonical-prefixes, then yes, that's a workaround
Yes, that won't actually work then because it only does the replace if there's a single hyphen. What is everyone else currently doing?

Sacha wrote:

If your compiler takes --no-canonical-prefixes, then yes, that's a workaround
Yes, that won't actually work then because it only does the replace if there's a single hyphen.

Hmm -- should be set in makefile macro(variable) CFLAGS. Please
check. Perhaps is ignored then by compiler.

What is everyone else currently doing?
To set compiler and options in environment variable CC.

So you set CC="$CC $CFLAGS" and then set CC back after compiling OpenSSL?
That doesn't sound like a good idea for usage.

This issue is indirectly fixed by "Environment variable assignments on Configure command line" #4818 (master branch, upcoming 1.1.1) .
Compiler flags like -no-canonical-prefixes could be added to CFLAGS .

Closing this, as the CFLAGS env var can be used, starting with 1.1.1


Bump version to 1.19.0

Changelog
Bugfixes

Fix Docker build error (#636, @notmgsk)
Fix undefined function (#624, @colescott)

Behind-the-scenes

addresser refactor and cleanup (#617, @kilimanjaro)
allow dynamic use of ISNT (#625, @stylewarning)
magicl constructor shims (#618, @colescott)
Allow printing of parsed programs in REPL (#616, @notmgsk, @appleby)
Disable print-circle and improvements for printing (#628, @appleby)

Uncontroversial. Going to merge without approval.


Add Cosine distance cost and related tests.

Addressed the comments by @marcocuturi in a new commit.

Sorry, I forgot something and reverting back to draft::: the test for the cosine function should be added to the BUILD file in the geometry folder, otherwise it won't be tested.


Support excluding non physical and wireless network adapters to deal with MAC randomization

Non physical network adapters like VPN connections tend not to have fixed MAC addresses. For wireless (802.11 based) adapters hardware (MAC) address randomization is frequently applied to avoid tracking with many modern operating systems support this out of the box. This makes wireless network adapters bad candidates for device identification.
To this end I implemented the NetworkAdapterDeviceIdComponent class and a new AddMacAddress extension method. I had to work some magic because prior to Windows 8 it is pretty difficult to figure out if a network adapter is wireless or not using WMI.
Basic unit tests are included but are limited as the outcome ultimately depends on the hardware the test is running on.

Thanks, this looks like a great contribution. I'll try to review, merge, and release it over the next week or so. Cheers!


fix: do not load whole child collection with virtual scroll (#463)

PR Checklist
Please check if your PR fulfills the following requirements:

[ X ] The commit message follows our guidelines: https://github.com/CirclonGroup/angular-tree-component/blob/master/CONTRIBUTING.md#commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[ X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Closes #463
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ X ] No

Other information

Hi @Novkirishki, thank you for this PR! I tested it so far and it looks good. But I have some trouble reproducing the issue. You said in the issue that it happens when the nodeHeight tree option is INodeHeightFn and not a number. What function are you using and what are you returning?

Hi @tobiasengelhardt, thank you for the quick response! Here is how I reproduce the issue: commit.
The INodeHeightFn function I use simply returns a number. I have added a dummy component to easily track how many instances are created. I have also added a getChildren() function so that the child nodes are loaded async.
When I expand the node with children for the first time I can see in the console that 1000 instances of the dummy component are created. If I collapse the node, further expansions work as expected and only create around 25-6 dummy components, because children height is already calculated and cached. With the fix from the PR there are only 25-6 nodes created on the initial expansion as well.

Very sorry for the late merge. This fix is now included in version 10.0.1. Thank you again for the contribution!


[#266][symfony-toggle] fix api test in symfony toggle

Closes #266. @xserrat  we have to check this because we are using a test class from another package, which is not autoloaded by default. I simply duplicate the test class and add it to the Symfony package test namespace.

Hm... that's totally true... The same issue happens for the mezzio toggle. I'm not sure if we could move this "Fixture" to another package like the toggle-core to ensure that it'll always exist. What do you think? If not, we're going to duplicate it :/

The problem is that if the class only exist inside the test namespace, it won't be accessible from other packages, this is the reason to duplicate, also, I don't look bad to duplicate test code

The problem is that if the class only exists inside the test namespace, it won't be accessible from other packages, this is the reason to duplicate, also, I don't look bad to duplicate test code.

The autoload-dev section is only accessible from the self package when is autoloaded in dev mode.

I agree with you 🚀 !


Document failWithError parameter in authenticate()

Helps with #458. I don't know where to submit a change that would update http://www.passportjs.org/docs/authenticate/ but I'd be happy to help with that too
Checklist

[x] I have read the CONTRIBUTING guidelines.
[x] I have added test cases which verify the correct operation of this feature or patch.
[x] I have added documentation pertaining to this feature or patch.
[x] The automated test suite ($ make test) executes successfully.
[x] The automated code linting ($ make lint) executes successfully.

Coverage remained the same at 98.87% when pulling 19cc7c24969e467e42e2a78572e886993f48df36 on hsource:patch-1 into 882d65e69d5b56c6b88dd0248891af9e0d80244b on jaredhanson:master.

Coverage remained the same at 98.87% when pulling 19cc7c24969e467e42e2a78572e886993f48df36 on hsource:patch-1 into 882d65e69d5b56c6b88dd0248891af9e0d80244b on jaredhanson:master.

What's the status on this?

This is purely a documentation change so should be submittable.

I guess it could be merged!


Multiple kue instances?

Is it possible to create multiple kue instances which will use different redis instances inside the same app?

I'm afraid createQueue currently returns a singleton, so on every node process you are limited to one Kue object to be configured.
This will be changed in next major versions.

Do you have a roadmap for this feature?

this needs a kue-wide refactoring to change all static and globals. I would like to bring it to Kue 1.0 if I have enough time.

Any update on this?

this will be handled in next Kue release...

0.11 is already out, no feature added …

I just did the job ;)  #1187


Integer divide-by-zero in afl-fuzz.exe

Hi,
I've built WinAFL from master branch (last commit b291220), using Visual Studio 2019 (also tried with 2022)
Using latest DynamoRIO (last commit 0c479bf)
I'm trying to run the afl-fuzz with test.exe, feeding with corpus "test"
This is my command line:
afl-fuzz.exe -i in -o out -t 2000 -D "C:\Users\dev\Desktop\dynamorio-master\build\bin32" -- -- test.exe @@
The fuzzer is firing up:
WinAFL 1.16b by<EMAIL_ADDRESS>Based on AFL 2.43b by<EMAIL_ADDRESS>[+] You have 4 CPU cores with average utilization of 0%.
[+] Try parallel jobs - see afl_docs\parallel_fuzzing.txt.
[*] Checking CPU core loadout...
[+] Found a free CPU core, binding to #0.
[+] Process affinity is set to 1.
[*] Setting up output directories...
[+] Output directory exists but deemed OK to reuse.
[*] Deleting old session data...
[+] Output dir cleanup successful.
[*] Scanning 'in'...
[+] No auto-generated dictionary tokens to reuse.
[*] Creating hard links for all input files...

[+] Here are some useful stats:

    Test case count : 0 favored, 0 variable, 1 total
       Bitmap range : 0 to 0 bits (average: 0.00 bits)
        Exec timing : 0 to 0 us (average: 0 us)

[+] All set and ready to roll!

                   WinAFL 1.16b based on AFL 2.43b (test.exe)

+- process timing -------------------------------------+- overall results ----+
|        run time : 0 days, 0 hrs, 0 min, 0 sec        |  cycles done : 0     |
|   last new path : none seen yet                      |  total paths : 1     |
| last uniq crash : none seen yet                      | uniq crashes : 0     |
|  last uniq hang : none seen yet                      |   uniq hangs : 0     |
+- cycle progress --------------------+- map coverage -+----------------------+
|  now processing : 0* (0.00%)        |    map density : 0.00% / 0.00%        |
| paths timed out : 0 (0.00%)         | count coverage : 0.00 bits/tuple      |
+- stage progress --------------------+ findings in depth --------------------+
|  now trying : init                  | favored paths : 0 (0.00%)             |
| stage execs : 0/-                   |  new edges on : 0 (0.00%)             |
| total execs : 0                     | total crashes : 0 (0 unique)          |
|  exec speed : infty/sec             |  total tmouts : 0 (0 unique)          |
+- fuzzing strategy yields -----------+---------------+- path geometry -------+
|   bit flips : 0/0, 0/0, 0/0                         |    levels : 1         |
|  byte flips : 0/0, 0/0, 0/0                         |   pending : 1         |
| arithmetics : 0/0, 0/0, 0/0                         |  pend fav : 0         |
|  known ints : 0/0, 0/0, 0/0                         | own finds : 0         |
|  dictionary : 0/0, 0/0, 0/0                         |  imported : n/a       |
|       havoc : 0/0, 0/0                              | stability : n/a       |
|        trim : n/a, n/a                              +-----------------------+
[*] Entering queue cycle 1.---------------------------+   [cpu000001:   2%]
[*] Fuzzing test case #0 (1 total)...
0 processes nudged
nudge operation failed, verify permissions and parameters.

And after couple of seconds, the fuzzer crashes.
And I get this crash everytime, with different parameters (tried without instrumentation, different targets, different build versions, architecture).
This is the crash along with the call stack:
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
*** WARNING: Unable to verify checksum for afl-fuzz.exe
eax=00000000 ebx=00b37928 ecx=00000000 edx=00000000 esi=00000007 edi=00000000
eip=008e8b64 esp=00aef960 ebp=00aef990 iopl=0         nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00010246
afl_fuzz!_aulldiv+0x14:
008e8b64 f7f1            div     eax,ecx

0:000> k 6
 # ChildEBP RetAddr
00 00aef964 008d3256     afl_fuzz!_aulldiv+0x14 [d:\a01\_work\11\s\src\vctools\crt\vcstartup\src\helper\i386\ulldiv.asm @ 88]
01 00aef990 008d66a7     afl_fuzz!argv_to_cmd+0x7f6
02 00aefc88 008e0317     afl_fuzz!fscanf+0x307
03 00aefcb4 008e936c     afl_fuzz!main+0x16c7
04 (Inline) --------     afl_fuzz!invoke_main+0x1c [d:\a01\_work\11\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl @ 78]
05 00aefcfc 76a2fa29     afl_fuzz!__scrt_common_main_seh+0xfa [d:\a01\_work\11\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl @ 288]

Am I doing something wrong?
This is my build toolset:
Windows 10.0.19044
Windows SDK version 10.0.19041.0
MSVC 19.29.30143.0

I don't see where the integer division occurs (the call stack appears incorrect, building with debug info might resolve that). However, your command line is missing instrumentation option (between first and second --) and I suspect that's causing the issue. See https://github.com/googleprojectzero/winafl/blob/master/readme_dr.md for some usage examples.

I'm not sure if it's related to the instrumentation options, because I've seen this example in the readme_dr:
afl-fuzz.exe -e -i in -o out -D <dynamorio bin path> -t 100+ -- -- test_gdiplus.exe @@
which doesn't use any instrumentation options.
I tried to follow the same thing with test_gdiplus, and I still get div by zero.
I've also executed the instrumentation with drrun.exe, as its usage described in the readme_dr aswell, and it worked properly.
The output of WinDBG in the first issue description is of afl-fuzz, compiled with Debug config, so please let me know what else I can do to bring more info.

Note that the -e switch requires a proper configuration file in the tools subdirectory of the root of DynamoRIO called winafl.drrun32 or winafl.drrun64, depending on the target architecture. However, there is no -e switch in your opening post, hence the instrumentation options should be specified in the command line.


Images on Info Page are broken

Select Add-On (place a lowercase x for the relevant add-on)

[X] Xiaomi Mi Scale

Describe the bug

Thanks. I've also seen this. Images are using full url (not relative) so not sure how to resolve. This is automatically pulled from the repo from HA

Try using different URLs in the Readme like this:
https://raw.githubusercontent.com/lolouk44/xiaomi_mi_scale/master/Screenshots/Mi_Smart_Scale_2_Thumb.png
instead of
https://github.com/lolouk44/xiaomi_mi_scale/blob/master/Screenshots/Mi_Smart_Scale_2_Thumb.png
It might work, but actually I haven't tried.

Thanks I'll give it a go tomorrow and report

it points to an actual picture instead of an HTML page containing the picture so I've changed that in branch 0.1.8


Build Supply Chain for Web 3.0

Project Abstract
We aim to build a Supply chain system that will help communities/businesses and the web3 community would have a system implemented in web3.
For which grant level are you applying?

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] I have read and understood the FAQs, application guidelines and announcement guidelines.
[x] A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledge the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted.
[x] I prefer the discussion of this application to be in a private Element/Matrix channel. My username is: @_______

How Did You Hear About our grants program?

[x] Social Media
[ ] Hackathon
[x] Personal Recommendation
[ ] Substrate Builders Program
[ ] Investor/VC
[x] Online Search
[ ] Other: _______

Thanks for the grant application. I have a couple of initial questions:

Compared to your previous grant application, you significantly increased the price (weekly rate). What is the reason for this?
Do you have a specific use case for this SupplyChain module? Are you working together with a company etc.?
For example, I see a lot of legal/privacy problems with this setup. How do you plan to address these?

I’m personally interested in supply chain-focused modules, but the price point seems relatively high for a purely education-focused project.

Hi @Noc2, thank you for your quick reply.
1- The first grant was built for education purposes. It was my first application and just one of us worked there. This time we will be two people working full-time on this project who have already proven experience to get the job done.  The amount might be higher but it would take more or less 9 months of work. I do not think it is high for two experienced developers who will work full-time on this project. We tried to ask as less as possible! Remember, this amount will be split between two people.
2- I have already had calls with many companies whose main job is the supply chain. Most of them use big trucks to ship car parts/furniture/heavy things to deliver to the main client and they would love to have at least an MVP product that they can start using. We do not have many supply-chain systems on Substrate, so we thought it would be a great opportunity to build something which is valuable for the businesses and the community.
3- The idea is to build an initial MVP that fixes the main supply chain issues. Of course, it might be things to be enhanced/corrected but we have to take into consideration that we are just two devs working on everything, including designing, implementing, testing, talking to the customers, etc. If you have suggestions, you are more than welcome.
We would be pleased if you can give us the opportunity to build something in which we believe.
If you still have questions, we can schedule a call and try to make it work.
Thanks again.

@Noc2 Do you have any suggestion/news? Please, let me know.

Thanks for the update. I will mark your application as ready for review so that others can take a look at it as well.
But the costs still seem high to me. Also, your first milestone has an estimated duration of 2-3 months, an FTE of 2, and costs 30k. Your last milestone has the same estimate but cost 18k, which seems more aligned with your previous grant. Could you also comment on my previous question regarding legal or privacy issues with on-chain supply chain management?

Well, if you see the amount of work (number of functions) is not equal in all the milestones. We divided the milestones into entities like a manager, client, and courier so would be easier for developing and also for you to test it.
About the legal or privacy issue: We have found a simple solution because we do have a depart that can take care of legal stuff. Every client would have its own private node. We will help them with configuration/setup and everything they need so we are not going to store their data on our chain. In the future client has to use our software as a service. So we are gonna hire a  legal team who can prepare the GDPR contract and all the needed things.

@takahser @alxs @keeganquigley Can you please review my application? Thank you!

@herou thank you for your application. I have to say I agree with David here that the costs seem very high, not so much in terms of rates as with respect to the deliverables. The milestones consist of business logic which seems fairly straightforward to implement, and you provide almost no technical details.
Besides, if each client runs a private node I don't see how this is any different to a traditional database, or what advantages it would bring.
Also, are you aware of https://github.com/OriginTrail?

@herou thank you for your application. I have to say I agree with David here that the costs seem very high, not so much in terms of rates as with respect to the deliverables. The milestones consist of business logic which seems fairly straightforward to implement, and you provide almost no technical details.
Besides, if each client runs a private node I don't see how this is any different to a traditional database, or what advantages it would bring.
Also, are you aware of https://github.com/OriginTrail?

@alxs Thank you for your feedback. I put the needed details in the application and I made some modifications in general.I left the main methods which are needed because I updated also the price. Please let me know how you find it.
I and my partner decided to hire a legal team who can prepare the GDPR contract and all the needed things.

Hi @Noc2, @alxs . Do you have any updates? Thank you!

I agree with David here and for the reasons I previously mentioned, I won't approve the application either. But maybe others in the committee think differently and otherwise, you're always welcome to apply again at a later stage or with a different project.

@alxs @Noc2 Thank you for your feedback. It seems this idea was not very interesting. I will come up with a new idea in the future. Thank you!


intake Q5 conditions are broken

se.singleChoice should be se.multipleChoice here:
https://github.com/influenzanet/common-study-definition/blob/cddee88208315fe16ed79e3bab2741d0d4702300/src/studies/common/questionPools/intakeQuestions.ts#L639

Fixed in 6257efdb7b5a7411a1ee0343e4eb6e7aea5884a9


feat(lang): Add proposal for serve

Signed-off-by: Qi Chen<EMAIL_ADDRESS>

@gaocegege @VoVAllen @kemingy Thanks for your suggestions, I am going to:

Rename serve to expose, because I think it is a exposing helper in the development process and serve may cause problems.
Remove cloud package for now and only keep host.bind

PTAL

LGTM. Maybe we can adjust the PR title?

Do you have any ideas or what format is better

LGTM. Maybe we can adjust the PR title?

Sry, I got you ideas..

It should be ok now. @gaocegege


Exception throw when open Confirm Dialog

Describe the bug
The exception throw while opening Confirm Dialog via DialogService.
The exception is System.NotSupportedException: 'Serialization and deserialization of 'System.Type' instances are not supported. Path: $.ChildContent.Method.ReturnParameter.Member.DeclaringType.'
You should add JsonIgnore attribute to ChildContent property of DialogOption class.

The provided information is not enough to reproduce the exception


Remove "DO NOT SUBMIT" comment.

Description:
It looks like this comment snuck in as part of PR 3936. It causes some
hassles for Google import, since our internal presubmits are wary of
code that contains comments with DO NOT SUBMIT in all caps.
I think the original intent was to remove the comment before merging,
and it should be safe to remove the comment given my review of the
file.
Risk Level: Trivial
Testing: bazel test //test/...
Docs Changes: None
Release Notes: None
Signed-off-by: Dan Noé<EMAIL_ADDRESS>

I believe master is currently broken for unrelated reasons, so I expect CI above to fail. I'll kick it again after that issue is fixed.
@mkbehr FYI

Yeah, that comment is outdated. Thanks for catching it!

Can merge master now


refactor: improve CLI config handling

Rather than postprocessing the output of Clap, inject the config file values by preprocessing the raw program arguments. This makes the Clap-generated help output more useful, provides better error messages, requires less code, doesn't require a TOML dependency, doesn't restrict our CLI options to forms that can be easily represented in TOML, and has direct precedence from how command-line config files are used in the Java, Python, and C# ecosystems.
Signed-off-by: bstrie<EMAIL_ADDRESS>

Yes, this will fix #211.

Reopened #193 , since now we only have support for reading command line flags from a file


In Alpha RC7, index.{platform}.js files generated even when not selected in rnv new.

@jfrux @mihaiblaga89 should be fixed in 0.26.0-rc8


what is the mean of argument 'max_labels' in TrainTransform

Hi, what is the mean of argument 'max_labels' in 'TrainTransform' class ? Thx.

@Stoneplay It means the valid maximum number of ground-truth targets in an image. If there is more than 120 gt in your image, only the former 120 will be loaded, others will be treated as backgrounds.

Sorry, I‘m not so familiar with object detection. What's the reason for doing like this ? I notice that the maximum number of targets in an image in COCO is more 90. After the mosaic transform, the number is far more than 120.  Is this a common practice in Object detection in COCO ?

@Stoneplay No, it's not. We want to limit the number of ground-truth to save memory occupation. In the common case, there should not exist the limitation like "max_labels".
By the way, you can modify the number of "max_labels" to fit your own situation.

Ok, I get it. Thank you very much for your reply !


Cave Bot Issue

Hello,
Great work on the bot however the cave bot is not working on Tibia 12.5 OT Server. It constantly print a message that the "Destination is out of range." and "There is no way.", it also doesn't attack monsters even when I am surrounded by them. Any idea what is going off?

maybe it can be the priority of your screen, do you use more than 1 monitor?

maybe it can be the priority of your screen, do you use more than 1 monitor?

In this instance I have had my second monitor disconnected from the GPU so I don't think it would be a problem.

In this instance I have had my second monitor disconnected from the GPU so I don't think it would be a problem.

is there any way to solve this?
to make the cavebot work well?

is there any way to solve this?
to make the cavebot work well?

Cara, estou tendo o mesmo problema, consegui verificar que se estiver configurado para usar com global, para jogar com a janela em foco ele funciona certinho com o zoom correto, mas as funções que dependem de mouse não funcionam quando configurado para poder utilizar o bot sem a janela em foco (OTSERV mode), tem alguma ideia do que possa fazer para resolver?


Are there any forks or similar packages out there?

Since this repo hasn't been updated since 2017, I'm assuming its dead. Has anyone found a similar project that they like to take TerminalView's place?

@wishinghand Yes it is dead. I spoke with @randy3k a while back about taking over but he would rather start a new project here https://github.com/randy3k/Terminus. I think he is pretty active so I would check that out instead.


filter policy doesn't repect rules in multi-tenancy k8s cluster

Describe the bug
We are integrating ambassador edge-stack as our API gateway to our cluster. We have SaaS application orchestrated on a multi-tenant k8s cluster based on namespaces. Moreover, we serve tenant1 in namespace tenant1, the user can access it through tenant1.org.com and tenant2 on namespace tenant2 and can access it through tenant2.org.com. For each tenant there is an Auth server, Keycloak, and we would like to authenticate the user with its correct Keycloak using OAuth 2.0 Code flow authentication.
The edge-stack workloads, listeners, hosts and filter-policy are running in ambassador namespace.
whereas for each tenant, the workloads, filters and mappings are running in their own namespace.
If there is one tenant, everything works as expected, the user is first authenticated before it is redirected to the app. However, when I onboard the second tenant, the authentication either works or fail. After looking into the logs, it seems that filter-policy isn't respecting the host and goes in a round robin fashion between the two keycloaks (tenant1 and tenant2).
To Reproduce
Here are the charts for the hosts, filters and filter-policy:
apiVersion: getambassador.io/v2
kind: Host
metadata:
  name: tenant1.org.com
  namespace: ambassador
spec:
  hostname: "tenant1.org.com"
  acmeProvider:
    authority: none
  tlsSecret:
    name: tenant1.org.com
  requestPolicy:
    insecure:
      action: Route
---
apiVersion: getambassador.io/v2
kind: Host
metadata:
  name: tenant2.org.com
  namespace: ambassador
spec:
  hostname: tenant2.org.com
  acmeProvider:
    authority: none
  tlsSecret:
    name: tenant2.org.com
  requestPolicy:
    insecure:
      action: Route
---
apiVersion: getambassador.io/v3alpha1
kind: Filter
metadata:
  name: t1-auth-filter
  namespace: t1
spec:
  OAuth2:
    authorizationURL:   https://tenant1.org.com/auth/realms/my_realm
    audience: frontend ## change to your client audience
    clientID: frontend ## change to your client-id
    secret: XXXXXXXXXXXXXXXXXXXXXX ## change to your client secret
    protectedOrigins:
    - origin: https://tenant1.org.com
    postLogoutRedirectURI: "https://tenant1.org.com"
    injectRequestHeaders:
    - name: "x-auth-token"
      value: "{{ .token.Raw }}"
---
apiVersion: getambassador.io/v3alpha1
kind: Filter
metadata:
  name: t2-auth-filter
  namespace: t2
spec:
  OAuth2:
    authorizationURL:   https://tenant2.org.com/auth/realms/my_realm
    audience: frontend ## change to your client audience
    clientID: frontend ## change to your client-id
    secret: XXXXXXXXXXXXXXXXXXXXXX ## change to your client secret
    protectedOrigins:
    - origin: https://tenant2.org.com
    injectRequestHeaders:
    - name: "x-auth-token"
      value: "{{ .token.Raw }}"
---
apiVersion: getambassador.io/v2
kind: FilterPolicy
metadata:
  name: app-policy
  namespace: ambassador
spec:
  rules:
    # don't apply any filter for Keycloak
    - host: 'tenant1.org.com'
      path: '/auth/*'
      filters: null
    # apply keycloak filter to all other paths.
    - host: 'tenant1.org.com'
      path: "*"
      filters:
        - name: t1-auth-filter
          namespace: t1
          arguments:
            scopes:
            - "offline_access"
    - host: 'tenant2.org.com'
      path: '/auth/*'
      filters: null
    - host: 'tenant2.org.com'
      path: "*"
      filters:
        - name: t2-auth-filter
          namespace: t2
          arguments:
            scopes:
              - "offline_access"

if you check the /certs endpoint (example: https://tenants1.org.com/auth/realms/my_realm/protocol/openid-connect/certs), you will see that one time it will get tenant1's keycloak cretificates and if you request it again, it will get tenant2's certifications.
Expected behavior
When I request tenant1.org.com it should always redirects me to t1-auth-filter and get the correct certificates.
Versions (please complete the following information):

Ambassador: helm chart edge-stack 8.6.0
Kubernetes environment: Azure Kubernetes Cluster
Version 1.23.12

Additional context
After changing the logs to DEBUG, here are the kubectl logs when I request tenant1.org and redirected to tenant2's keycloak for certs:
time="2023-06-27 08:21:06.0370" level=debug msg="[gRPC] HTTP/1.1 GET tenant1.org.com /auth/realms/my_realm/.well-known/openid-configuration" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:125" CMD=amb-sidecar PID=19 REQUEST_ID=5873732841537935299 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0371" level=debug msg="selected rule host=\"tenant1.org.com\", path=\"/auth/*\", filters=[]" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:166" CMD=amb-sidecar PID=19 REQUEST_ID=5873732841537935299 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0372" level=debug msg="[gRPC] *filterapi.HTTPRequestModification : 0 headers (175.903µs)" func=github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.logResponse file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:85" CMD=amb-sidecar PID=19 REQUEST_ID=5873732841537935299 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0495" level=debug msg="[gRPC] HTTP/1.1 GET tenant1.org.com /auth/realms/my_realm/protocol/openid-connect/certs" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:125" CMD=amb-sidecar PID=19 REQUEST_ID=14894203611968302211 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0496" level=debug msg="selected rule host=\"tenant1.org.com\", path=\"/auth/*\", filters=[]" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:166" CMD=amb-sidecar PID=19 REQUEST_ID=14894203611968302211 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0497" level=debug msg="[gRPC] *filterapi.HTTPRequestModification : 0 headers (141.102µs)" func=github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.logResponse file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:85" CMD=amb-sidecar PID=19 REQUEST_ID=14894203611968302211 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0573" level=debug msg="[gRPC] HTTP/1.1 GET tenant1.org.com /auth/realms/my_realm/protocol/openid-connect/userinfo" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:125" CMD=amb-sidecar PID=19 REQUEST_ID=6955879194634230038 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0573" level=debug msg="selected rule host=\"tenant1.org.com\", path=\"/auth/*\", filters=[]" func="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.(*FilterMux).Filter" file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:166" CMD=amb-sidecar PID=19 REQUEST_ID=6955879194634230038 THREAD="/http/conn=14"
time="2023-06-27 08:21:06.0574" level=debug msg="[gRPC] *filterapi.HTTPRequestModification : 0 headers (112.102µs)" func=github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler.logResponse file="github.com/datawire/apro/v3/cmd/amb-sidecar/filters/handler/handler.go:85" CMD=amb-sidecar PID=19 REQUEST_ID=6955879194634230038 THREAD="/http/conn=14"
ACCESS [2023-06-27T08:21:06.036Z] "GET /auth/realms/my_realm/.well-known/openid-configuration HTTP/1.1" 200 - 0 6084 11 10 "<IP_ADDRESS>" "Go-http-client/1.1" "f4ccb5e2-c019-482a-9615-806cb00da6f6" "tenant1.org.com" "<IP_ADDRESS>:8080"
ACCESS [2023-06-27T08:21:06.049Z] "GET /auth/realms/my_realm/protocol/openid-connect/certs HTTP/1.1" 200 - 0 2941 5 4 "<IP_ADDRESS>" "Go-http-client/1.1" "18f250fe-00ca-4303-a234-caf3ee70b7eb" "tenant1.org.com" "<IP_ADDRESS>:8080"
ACCESS [2023-06-27T08:21:06.056Z] "GET /auth/realms/my_realm/protocol/openid-connect/userinfo HTTP/1.1" 401 - 0 0 3 3 "<IP_ADDRESS>" "Go-http-client/1.1" "61b9700e-0137-4fb3-b3ec-758c09b41807" "tenant1.org.com" "<IP_ADDRESS>:8080"

Hi @uzi0espil, can you set your log level to 'debug' and share your ambassador pod logs?  At a glance this looks ok, but there must be some configuration issue here.

Thanks for coming back to me, I have changed the logs level and updated the question accordingly. Let me know if I need to add further logs.

Hi @uzi0espil,
Here is the command to grab a snapshot of your environment (including the envoy configuration that we are interested in).
AMBASSADOR_POD={{AMBASSADOR_POD_NAME}} bash -c 'kubectl exec -n ambassador -it $AMBASSADOR_POD -- tar -czf /tmp/ambassador.tgz /ambassador --exclude=secrets-decoded --exclude=webui --exclude=sidecars && kubectl cp -n ambassador $AMBASSADOR_POD:/tmp/ambassador.tgz ambassador.tgz'

Let me know if you have any questions.

Hi @tenshinhigashi, here is the output tgz file from the command you gave me.
ambassador.tgz.zip
tgz isn't supported extension in github so I had to add a dummy extension, please rename the file by removing the .zip extension, then extract.

Hi @uzi0espil, I took a quick look at the config.
I suspect that the issue is likely due to multiple routes having a numerator value of 50 rather than 100. This is likely causing the weird "load balanced" behavior that we were seeing. Without a further investigation, I can't be certain what caused this, but for now, can we try setting a weight value of 100 on your mappings and see if the behavior changes?

Hi @uzi0espil , can you check your AES helm chart and see whether your AuthService is deployed?  AES installs its own AuthService, which Filter/FilterPolicy relies on.  In previous cases turning that on got things working.

Hi @cindymullins-dw, thanks for coming back to me.
I couldn't infer from the helm values which attribute is for enabling AuthService, but I can see an AuthService created in ambassador namespace under name edge-stack-auth with the following manifest:
apiVersion: getambassador.io/v2
kind: AuthService
metadata:
  annotations:
    meta.helm.sh/release-name: edge-stack
    meta.helm.sh/release-namespace: ambassador
  labels:
    app.kubernetes.io/component: edge-stack-auth
    app.kubernetes.io/instance: edge-stack
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: edge-stack
    app.kubernetes.io/part-of: edge-stack
    helm.sh/chart: edge-stack-8.6.0
    product: aes
  name: edge-stack-auth
  namespace: ambassador
  selfLink: /apis/getambassador.io/v2/namespaces/ambassador/authservices/edge-stack-auth
spec:
  ambassador_id:
    - '--apiVersion-v3alpha1-only--default'
  auth_service: <IP_ADDRESS>:8500
  proto: grpc
  protocol_version: v3

Ok, thanks for checking that.  If the AuthService exists then that's probably not the issue.  Could you join a help session with us so our engineers can check things out?  We run them on Thursdays at 2:30pm ET.

Yes of crouse, could you send me an e-invite to my email please.

This is fixed by upgrading the hosts and mappings apiVersion to V3alpha1 and adding a .spec.mappingSelector in hosts that points to mapping in same tenant.


Fixup ractive edge.

This gets the plugin working with ractive from edge.  Not sure if you want to wait until 0.8 is released to merge in case they change the internals a bit, but it works for me as of today.
Ractive has done a major refactor for 0.8 which causes this to fail.
The ractive instance and keypath are now in different locations.

Thanks for this!


Fix bug with using a generic struct as a field in another generic struct

Closes #1116

Hey @emilyaherbert, is this one still under active development?

@sezna still resolving some small changes on this, got caught up with all the Amsterdam stuff 😓 let me take a look at your comments and resolve this today


C++ AutoFactory constructor documentation refers to non-existent Choreo::CreateAutoFactory()

The documentation for the AutoFactory constructor only points to a Choreo::CreateAutoFactory() function, which exists in Java but not C++.
It looks like the class comment is also out-of-date with recent changes to Choreo (such as AutoLoop -> AutoRoutine).

Turns out those files don't even get compiled, and the Java tests that would have caught that were never ported to C++ (C++ has almost no tests). We clearly have some process improvements to do.


Table: Transfers

Description
Let's create a Transfers table with direct asset transfers between parties.
This table is downstream of the core Transactions table we will build.
TODO

[ ] Design the schema for this table
[ ] Get confirmation on schema
[ ] Build schema
[ ] Schema build review
[ ] Submit Pull Request

Note: this is downstream of stg_txs

Is the transfer the same as what deposit means in the near block explorer?

ie a combination of transfer actions and deposits on function call actions

The structure of the action Transfer is:
{
  "deposit": "4570719915088988000000000000"
}

There is no denom information, so that's probably in FunctionCall. However, there are instances of Transfer being the only action_event. So, the long and short of it is I don't really know...
I think the intent of this table is p2p transfers, so we need to figure out how to isolate those from contract calls.

The structure of the action Transfer is:
{
  "deposit": "4570719915088988000000000000"
}

There is no denom information, so that's probably in FunctionCall. However, there are instances of Transfer being the only action_event. So, the long and short of it is I don't really know...
I think the intent of this table is p2p transfers, so we need to figure out how to isolate those from contract calls.

This is NEAR blockchain, there will only be NEARcoin transfers. You're thinking in terms of ERC20 which is actually a "FunctionCall" of a SmartContract. Not sure which table you're trying to build tho..

Proposed Transaction Schema
So after looking through a few txs and the block explorer I think I have an idea of transfers and what makes sense to include.

tx_hash
block_timestamp
signer_id
receiver_id
deposit_value
reciept_data

ESesVe7CQgSwN2VQVKDj2ycKLy91bpyk9v2itx7wKJ11
2021-10-20 01:31:05.868
ndovanlanh758.near
ndothitu652.near
10000000000000000000
[{ "block_hash": "9veCaMfdN25BpYwwvXQSMmeVt2FjdBbSMGhLyjs2z1]...

Another option for the above is potentially changing signed and receiver to to_address & from_address. Not sure if we want to standardize across blockchains or follow the nomenclature of the blockchain we're working in.  My thought was that we probably want to match what is displayed in the block explorer. I guess we can also just include this info in the yaml file.
Would also filter this table to only Transfer actions. I looked through a couple of the FunctionCall actions but it looks like all of them are to app. address types which I assume are smart contracts. So if we want to keep this p2p I think just limiting to transfers should do the trick. I did see a transfers to/from app.nearcrowd.near but maybe that's like a protocol level thing? I think I will filter out transfers that are to or from app.nearcrowd.near
Pretty new to the Near data and so if there's anything I should add or remove let me know.
CC: @chuxinh @forgxyz  @antonyip

Forgive me for my questions ( I don't know near's data structure off the back of my hand. + I don't know if they are easy to extract). I just figured that maybe people would cross reference to the explorer and thus expect these fields to be there. (Also these fields will be good to generate metrics later on)
Do we want to add these columns?

status
transaction fee
gas used
attached gas

I'm just also wondering why you would want to filter app.nearcroud.near? My feeling is to let the user do the filtering themselves if they wish to.

I agree we should add those four columns, especially status so the end user can filter by Succeeded and Failed, as needed. It's my thought, as well, that we should include all transfers and not filter out app.nearcloud.near.

Awesome, thanks for the feedback guys!
I will incorporate those additional columns as well as keeping the app.nearcloud.near in the transfers table. My only reason for the filtering was that I didn't think it was an actual p2p transfer but I make sense to just let the user filter on there own. And it is still a transfer based on their own actions so I think keeping it in there makes the most sense.
I'll create the PR and start working on building out the schema. Let me know if there's any other questions or things to add.

Please use txn_hash for that column.
We should also discuss signer_id and receiver_id in the chat as the current transactions table uses tx_receiver and tx_signer. The receipts table will also include reference to a NEAR address, so all tables should use a schema common to NEAR. Looks like their explorer currently uses the format: _id.

Closed with PR #24 !


ENH: Add support for special characters in catboost models

Overview
Closes #3475
Description of the changes proposed in this pull request:
Use utf-8 encoding when loading catboost json file
Checklist

[x] All pre-commit checks pass.
[x] Unit tests added (if fixing a bug or adding a new feature)

@connortann Maybe we can adopt the approach that is taken in #3462 for catboost aswell. But I leave that for another PR.

@connortann btw. I noticed that the run_notebooks job failed again for the last PR but this time due to unexpected versions. Will take a look (or just try to use the cache for dependencies) when I have the time.

Sounds good. On the topic of caching, I can share my recollections from when we added the cache step to the tests to speed up the CI jobs, if that helps you with any future Ci stuff.

The GitHub Cache limit wasn't big enough to allow us to cache the full set of dependencies for every version of python that we tested against. So, we restricted the scope cache to just a few of the larger packages. I think the GH cache size limit increases now and then, so over time we might be able to cache more.
The speedup we got from caching different packages was hard to predict: sometimes it was useful, sometimes it was actually slower. It was worthwhile doing experiments to measure the speedup, averaging over multiple runs to account for noise.
We had to be quite careful with the cache key, to ensure the cache was only restored in the exact same environment as the one in which it was created. Some tricky issues boiled down to subtle differences between those envs, such as different minor versions of the python interpreter.

Thanks for the information. I thought that was easier/more useful. Will keep that in mind when I implement the caching

the run_notebooks job failed again for the last PR but this time due to unexpected versions. Will take a look (or just try to use the cache for dependencies)

Another thought: I don't think caching will help as a solution to any dependency issues, per-se. Conceptually the cache allows us to take short-cuts in what should be already a complete deterministic end-to-end workflow; so the cache job shouldn't change the behaviour of the workflow other than being faster.


httpclient-backend-zio_3 missing?

https://repo1.maven.org/maven2/com/softwaremill/sttp/client3/httpclient-backend-zio_3/3.3.4/httpclient-backend-zio_3-3.3.4.pom
I see the other *-backend-zio_3 artifacts are available, any reason for this one to be missing?

It uses zio-nio, see: https://github.com/zio/zio-nio/issues/352

Released in 3.3.5


Update pt-BR.coffee

Some translations for pt-br

Coverage remained the same at 63.567% when pulling 5c9875fa7f0ee85ef18208efb4153b3a74a47752 on AbimaelAlcebiades:patch-1 into 1d23029ce64309ef9b70bceca7466360f4b3d580 on codecombat:master.

Thanks! Merged.


Update live-events-recording-policies.md

Updating some small comments

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@cichur PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Question: does it work with newest CDI and Weld?

I tried to make weld-testing work with most recent versions of CDI and Weld, i.e. jakarta.enterprise:jakarta.enterprise.cdi-api:4.0.1 and org.jboss.weld.se:weld-se-core:5.0.1.Final.
It doesn't seem to work with both Java 11 or 17. I tried the SimpleTest example and I got:
org.jboss.weld.exceptions.IllegalArgumentException: WELD-001408: Unsatisfied dependencies for type Foo with qualifiers @Default   at injection point [BackedAnnotatedField] @Inject com.example.dao.SimpleTest.foo
I've read that you need Junit5 and Java 11, but what are the supported Weld and CDI versions?

Hello,
as the README states:

Version 4.x of this extension supports Weld 5.0 (CDI 4.0) along with jakarta namespace

Project has dependencies on CDI 4 (pom.xml) and Weld 5 (pom.xml). Note that the fact that Weld version isn't newest doesn't mean you cannot declare your own newer, in fact you should.
In fact, even when you checkout the main branch and do mvn clean install, you will run tests (JUnit 5 included) with CDI 4/Weld 5. As for JDKs, CI setup runs on JDK 11 and 17 and runs just fine.
You can take a look at the JUnit 5 tests that are here for some inspiration - https://github.com/weld/weld-testing/tree/master/junit5/src/test/java/org/jboss/weld/junit5
Or you can point me to your code and I can try to spot what's the issue. Either way, this extension should definitely work with CDI 4 and Weld 5 :)

Hi Matej,
Thanks for your swift reply. I'm sorry I didn't see that part of the readme myself.
Indeed, when I write a test in a new project, I works like a charm. Thanks to this I know better where to look for the root cause now. Thanks.

@sajanssens I will close this issue now, but if you are having issues troubleshooting that failure, don't hesitate to come back and ask more questions!


Fixing the while loop logic of retry mechanism for 429 requests

The time calculation logic in the while loop should consider  thread sleep's time in case of "RETRY_AFTER_MS_HEADER " condition.
Relates to - #33

Closing this, as it got created redundantly. Since it will be taken care in #33


Proxy Support

Valence should have support for bungeecord and velocity proxies. I think something like this could work in Config.
#[non_exhaustive]
#[derive(Copy, Clone, Eq, PartialEq, Default)]
pub enum ConnectionMode {
    #[default]
    Online,
    Offline,
    Bungeecord,
    Velocity,
}

(Looks like velocity does not support 1.19 currently? What should we do if Valence is updated before the proxies are?)

How should proxies be supported?
I was thinking something similar to spigot.yml -> bungeecord: true/false option does or is it more than that? Because I might give this a try

My idea is that you would have fn connection_mode(...) -> ConnectionMode instead of fn online_mode(...) -> bool in the Config.


Roll engine 90b1023c84c4..4eaf9ef4271a (5 commits)

https://github.com/flutter/engine/compare/90b1023c84c4...4eaf9ef4271a
git log 90b1023c84c4..4eaf9ef4271a --no-merges --oneline
4eaf9ef42 Roll src/third_party/skia a6262495da48..032f2756df64 (2 commits) (flutter/engine#6450)
c5e52dc31 Roll src/third_party/skia 92d10833de63..a6262495da48 (1 commits) (flutter/engine#6449)
efb24f12b Roll src/third_party/skia 4f87e2255b8a..92d10833de63 (2 commits) (flutter/engine#6448)
28e513613 Roll src/third_party/skia d945698c5dfa..4f87e2255b8a (2 commits) (flutter/engine#6446)
a2ea59f2c Roll src/third_party/skia 4302eb9a6e14..d945698c5dfa (4 commits) (flutter/engine#6445)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Auto-roller completed checks. About to merge.


welcome modal comes back after dismissal

Overview
Welcome modal comes back after dismissal.
Repro steps

sign in as admin
navigate to settings > users
create a new user
navigate to teams > admin team, add ur new user to the admin team
sign out as admin and in as ur new user
observe the welcome modal
dismiss the welcome modal
refresh your browser again
see the welcome modal again

Desired Behaviour
If you dismiss the welcome modal it shouldn't come back.
Screenshots

Modal also reappears whenever a new license is applied.
Repro steps:

log in as admin
run chef-automate dev psql chef_license_control_service -- -c "UPDATE licenses SET active=NULL" from studio to remove license
request a license (see welcome modal)
remove license again
apply valid license
see welcome modal again

Desired behavior:

do not see welcome modal on application of license if user has previously used automate

also if a user can navigate another tab like the default is infrastructure and I switch to compliance tab after that if I refresh the browser the same modal is reappears.

Will reach out to have someone else confirm, but looking like this may have been fixed somewhere.  I'm dismissing the welcome modal, refreshing and it is not coming back.

Note:  The current bug i'm seeing is that when the modal is dismissed the FIRST time, it will reappear.  After dismissal a SECOND time, the modal welcome modal remains suppressed.

We have a specific function named handleTriggerWelcome that deals with the logic of when to show or suppress the welcome modal.  What's happening is the FIRST time a user logs in, we show the modal, but it's not actually complete.  The user does not have access to our Telemetry Opt-in.  After a page refresh, the modal then returns because the user hasn't made a Telemetry selection yet, this time the modal is showing with the Telemetry option - defaulted to true.
@susanev - Do we want to be showing the Telemetry question on the FIRST modal with a default selection, like what's already being shown in the SECOND modal?
FIRST MODAL

SECOND MODAL

@SEAjamieD whoa good find, yes we want to show the telemetry checkbox on the first showing of that modal, please. i think it needs to be unchecked by default as well, im pretty sure folks need to take an explicit action to allow that.
while we are here, do you mind fixing a few more things on this modal?

change, the two links to display as our normal link style instead of that special styling and update the text to Chef Automate Documentation and Learn Chef Rally
move the checkboxes above the button
change button text to Close

Personal Note: Telemetry Architecture Diagram: https://github.com/chef/automate/blob/master/dev-docs/diagrams/telemetry-service-ui.png

this work has been deprioritized, so closing.

I think we can actually close this now thanks to @jaym.  Can anyone else confirm?

Closing - Confirmed this is now working as desired.

Closed with https://github.com/chef/automate/pull/3725


🐛 [cloud_functions] Emulator setup fails and calls production functions instead

Tried many things to find a solution but still cannot fix https://github.com/firebase/flutterfire/issues/9705

Let's track it in original issue.


[Enhancement] Different health for each mob

All mobs have the same health (100 HP).
It would be great if you could edit the health or if they already come with a default health, that they are not have the same.

My PR would solve this issue by giving each mob type its vanilla health values (at least by default) 😸.


Donations?

Is there a way to montarley support this project? You all are doing great work and franky this project is better than any of the commercial options out there and since i do not code in the languages you are using i was wondering if there was a way to donate to you all.
Thanks for the excellent project, fast and courteous support!

Thanks a lot for praising our work. It is a pleasure for us to share our Instaloader to the world, and we are proud to have attracted such an active and motivating community, with so many users who share their suggestions and ideas with us. Buying a community-sponsored beer or coffee from time to time is very likely to further raise our passion for the development of Instaloader.
I now created a paypal.me link for donations:
https://paypal.me/aandergr

Shall this be closed?


Exit 1 when clasp run failed with an error

Fixes https://github.com/google/clasp/issues/788

[ ] npm run test succeeds.
[ ] npm run lint succeeds.
[ ] Appropriate changes to README are included in PR.

@googlebot I signed it!

@tricknotes can you add test cases for exitCode 0 and 1?

@PopGoesTheWza
Thanks for your review.
Yes, I'll try it 👍
BTW, I found some untested tests https://github.com/google/clasp/issues/793.
I think test cases against this change will be included in such untested file.

I changed this PR to draft. I'll change ready when https://github.com/google/clasp/issues/793 is merged.