PHP support

Hi Microsoft
I will really love if preview server has PHP supported. Preview server has everything I need except the PHP support.
I am looking forward to the preview server with PHP support.
Sincerely
Nicolai

Duplicate of https://github.com/microsoft/vscode-livepreview/issues/49, please discuss there.


Base API: Update KeyValuePair equals method to only compare key

:tada: This issue has been resolved in version 0.12.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Are there plans to support Hololens2 ARM64

Describe the problem
It not supports Hololens2 ARM64 for now.
Describe the solution you'd like
Many performance problems can be solved if it supports Hololens2 ARM64.
Describe alternatives you've considered
Please let me know if there will be this plan to support Hololens2 ARM64 in the future，If there is such a plan, when will it can use? So that we can properly plan the follow-up projects.
Thanks

Duplicate #414

Duplicate #414


1803 or earlier, some of the enums fail.

Please specify which contract version applies to the new enums.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5a9d93e-4772-fa99-6482-fea4087fe214
Version Independent ID: 4e33b460-8e6e-e5a6-9dca-785159590917
Content: FlyoutPlacementMode Enum (Windows.UI.Xaml.Controls.Primitives) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.controls.primitives.flyoutplacementmode.yml&version=GBlive&_a=contents
Product: uwp
Git Login: jwmsft
Microsoft Alias: jimwalk

@mijacobs @mimisasouvanh This is an issue with the doc system. We have the version info in the metadata but it's not being displayed in the docs.

We have a bug filed against engineering for this issue.


Change color without using SASS

Often you don't want to recompile the SASS or change the color in your SASS file. Sometime you want dynamically change the color of the progress bar.
Acceptance criteria:

color attribute for changing the color of the progress bar

Added in v0.0.2


Combine local-user-service and team-service and enforce cascading deletes

Description
We've talked about combining those two services for awhile. It'd let us actually do relational things with user-team membership. It'd also let us properly do cascading and transactional deletes inside of postgres which would get us most of the way to those deletes being transactional (there is still the problem of authz containing references to users and teams that might not be deleted).
We also do not enforce that local users and teams actually exist, cascade delete, etc.
We'll need to determine the implications of how this will affect dex and authentication. Right now we create and store users in dex. This will change once we add a user database table in postgres.

this work has been deprioritized, so closing.


Learn how to attach text.

This post was write by google translator.

In the react-photo-layout-editor, the" Text editor "function is out of range.

There are two ways.

Add a toolbar button similar to "Setting" function from the forked Repository.
Separate the text addition function and layout creation function.

Plan A

It's a difficult way.
Fork out react-photo-layout-editor and add text functionality.
You need to add your own features.

You can add features without modifying react-photo-layout-editor.
Press Next step button to go toAdd textfunction.
You can create Add text function.
react-photo-layout-editor can be extracted in Canvas format.
https://github.com/RedgooseDev/react-photo-layout-editor/wiki/API.Util#export

@olee2002 please read post.

Thank you for looking into the options!


[General] Error while importing pyvcf

Hi,
I wanted to follow your tutorial on creating an OncoPlot.
However, when I am trying to import pyvcf I get this error:
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
/var/folders/93/lz6gxd9906z7wqwc1tx7hgsc0000gn/T/ipykernel_7020/1344064430.py in <module>
      1 from pysam import VariantFile
----> 2 from fuc import pyvcf

~/miniconda3/envs/ICR/lib/python3.7/site-packages/fuc/__init__.py in <module>
----> 1 from .api import *

~/miniconda3/envs/ICR/lib/python3.7/site-packages/fuc/api/pybed.py in <module>
     39
     40 import pandas as pd
---> 41 import pyranges as pr
     42 from copy import deepcopy
     43 from . import common

~/miniconda3/envs/ICR/lib/python3.7/site-packages/pyranges/__init__.py in <module>
     18 import pkg_resources
     19
---> 20 from pyranges.pyranges import PyRanges
     21 from pyranges import data
     22 from pyranges.methods.concat import concat

~/miniconda3/envs/ICR/lib/python3.7/site-packages/pyranges/pyranges.py in <module>
      4 import numpy as np
      5
----> 6 from natsort import natsorted
      7
      8 import pyranges as pr

~/miniconda3/envs/ICR/lib/python3.7/site-packages/natsort/__init__.py in <module>
      1 # -*- coding: utf-8 -*-
      2
----> 3 from natsort.natsort import (
      4     NatsortKeyType,
      5     OSSortKeyType,

~/miniconda3/envs/ICR/lib/python3.7/site-packages/natsort/natsort.py in <module>
    239
    240 # Exposed for simplicity if one needs the default natsort key.
--> 241 natsort_key = natsort_keygen()
    242 natsort_key.__doc__ = """\
    243 natsort_key(val)

~/miniconda3/envs/ICR/lib/python3.7/site-packages/natsort/natsort.py in natsort_keygen(key, alg)
    210             sep = natsort.compat.locale.null_string_locale
    211         else:
--> 212             sep = natsort.compat.locale.null_string
    213         pre_sep = natsort.compat.locale.null_string
    214     regex = utils.regex_chooser(alg)

AttributeError: module 'natsort' has no attribute 'compat'

Do you think it is a problem between the different dependencies of libraries? If not, how can I fix this?
Thank you in advance!

@evabalini,
Thanks for your interest in fuc! As you mentioned, the problem is very likely caused by dependency conflict (probably due to version conflicts between pyranges and natsort according to the error traceback).
Can you please try again with a fresh conda environment? Also, it's unclear which version of fuc you are using, but please make sure to use the latest version whenever possible (0.30.0 is the latest version).
$ conda create -n fuc -c bioconda fuc=0.30.0

Please let me know if this doesn't solve the issue.

Closing this due to inactive status. Please feel free to re-open it if you have further questions.


Video to audio converter

Description
A python script to convert video to audio.
Fixes #429
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have created a helpful and easy to understand README.md
[x] I have performed a self-review of my own code
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings

@santushtisharma10 @tamanna-verma @antrikshmisri

Hi, since video-to-audio converter PR was not closed and then now I edited the repo, I guess new changes are reflected here too.
The commit beefe94  has my caesar-cipher update too. What shall i do now?

Hi, since video-to-audio converter PR was not closed and then now I edited the repo, I guess new changes are reflected here too.
The commit beefe94 has my caesar-cipher update too. What shall i do now?

Delete the commit from this PR. That's why we instruct participate to create seperate branches for different features as I can see this PR was made from the master branch. Try to delete the commit or delete the extra files from here and create a seperate branche for next script

Hi, since video-to-audio converter PR was not closed and then now I edited the repo, I guess new changes are reflected here too.
The commit beefe94 has my caesar-cipher update too. What shall i do now?

If you feel stuck this thread might help.

Hi, since video-to-audio converter PR was not closed and then now I edited the repo, I guess new changes are reflected here too.
The commit beefe94 has my caesar-cipher update too. What shall i do now?

Delete the commit from this PR. That's why we instruct participants to create separate branches for different features as I can see this PR was made from the master branch. Try to delete the commit or delete the extra files from here and create a separate branch for the next script

Hi, I have reverted the commit beefe94. Is everything fine now?

Hi, since video-to-audio converter PR was not closed and then now I edited the repo, I guess new changes are reflected here too.
The commit beefe94 has my caesar-cipher update too. What shall i do now?

Delete the commit from this PR. That's why we instruct participants to create separate branches for different features as I can see this PR was made from the master branch. Try to delete the commit or delete the extra files from here and create a separate branch for the next script

Hi, I have reverted the commit beefe94. Is everything fine now?

Yes 👍🏼

@all-contributors please add @smriti1313 for code and documentation


rs-software-device example doesn't track bytes_per_pixel properly

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>)

Operating System & Version
Ubuntu 16

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.10.2

While debugging my own issues, I noticed that get_bytes_per_pixel() gives 0 for synthetic frames. In the rs-software-device example, I modified the code a bit to the following to reproduce the issue:
if (auto as_depth = depth.as<rs2::depth_frame>()) {
  std::cout << as_depth.get_bytes_per_pixel() << std::endl;
  points = pc.calculate(as_depth);
}

I noticed that in the function on_video_frame(), if you multiply the input BPP by 8 you get the correct answer (which is 2). It's as if the input was expecting bits_per_pixel. The rs2_software_video_frame struct, which is the input to on_video_frame, has a data member bpp. The example uses this as if it were bytes_per_pixel, but does it actually mean bits_per_pixel?

Hi @jjoachim ,
Looks like a bug in: https://github.com/IntelRealSense/librealsense/blob/57e623cd7d5f3912ffae5af86e104d93577fedb0/src/software-device.cpp#L131
Should be software_frame.bpp * 8 I think

Thank you, @jjoachim
We will try to fix ASAP, feel free to open a pull-request if you would like.

Should be resolved in v2.10.2, thank you for bringing-it up. Please feel free to open new issues if you still encounter any problem


Fix the size of the footer image

Currently, there is an image /assets/images/OC-EC-H2020.jpg at the bottom of the https://ngi.edgeryders.eu/ pages.
When shown in 100% scale as done by default, on small screen resolutions like 1024×768 px it will appear with too large text and also introduce a horizontal scrollbar.
It should made to fit the page content width, including on smartphone screens.

Done


Run tests across all packages directly

Running tests with lerna is very annoying because you have to scroll a lot to figure out which package actually had a failing test.
before
// Package A
✓ A1 Ok
x A2 Error

// Package B
✓ B1 Ok
x B2 Error

after this PR
✓ A1 Ok
✓ B1 Ok
x A2 Error
x B2 Error

Description
Run the unit tests across all packages with a single mocha run. If tests fail in multiple packages they will be nicely summarized at the end :+1:

Previous attempt https://github.com/ChainSafe/lodestar/pull/2988

TODO

[ ] Make all tests work with the same preset, types and tsconfig options

Current workflows allow to easily pick-up which package's test failed


Feature request: Add PageSpeed Insights v4

Only v1 and v2 of pagespeedonline available at the moment but the latest version is v4.

Nice, thanks!


Docker image fails to start, endlessly restarts

What's wrong with the following docker compose? I'm pretty new to docker, but I thought this was going to be a simple set up.
version: "3"
services:
qbitrr:
image: feramance/qbitrr:latest
user: 1000:1000 # Required to ensure the container is run as the user who has perms to see the 2 mount points and the ability to write to the CompletedDownloadFolder mount
tty: true # Ensure the output of docker-compose logs qBitrr are properly colored.
restart: unless-stopped
environment:
- TZ=America/New_York
volumes:
- /etc/localtime:/etc/localtime:ro
- /volume1/docker/qbitrr/config:/config  # Config folder for qBitrr
- /volume1/docker/qbittorrent/torrents/completed:/completed_downloads:rw
logging:
driver: "json-file"
options:
max-size: "50m"
max-file: 3

Can you please attach looks? Or is nothing at all working? Any error messages?
Thanks

Sorry, but this is all of the info I have to give. The container doesn't stay active enough to generate a log at all

For the sake of testing, please try the following:
qbitrr:
    image: feramance/qbitrr:latest

It start/stopped, then pumped this out:
14/08/2024 09:51 pm | NameError: name 'CONFIG' is not defined | stderr
14/08/2024 09:51 pm | CONFIG.get("Settings.FFprobeAutoUpdate", fallback=True) | stderr
14/08/2024 09:51 pm | File "/usr/local/lib/python3.10/site-packages/qBitrr/config.py", line 109, in  | stderr
14/08/2024 09:51 pm | from qBitrr.config import ( | stderr
14/08/2024 09:51 pm | File "/usr/local/lib/python3.10/site-packages/qBitrr/logger.py", line 9, in  | stderr
14/08/2024 09:51 pm | import qBitrr.logger  # noqa | stderr
14/08/2024 09:51 pm | File "/usr/local/lib/python3.10/site-packages/qBitrr/init.py", line 4, in  | stderr
14/08/2024 09:51 pm | import(pkg_name) | stderr
14/08/2024 09:51 pm | File "/usr/local/lib/python3.10/runpy.py", line 110, in _get_module_details | stderr
14/08/2024 09:51 pm | mod_name, mod_spec, code = _get_module_details(mod_name, _Error) | stderr
14/08/2024 09:51 pm | File "/usr/local/lib/python3.10/runpy.py", line 187, in _run_module_as_main | stderr
14/08/2024 09:51 pm | Traceback (most recent call last): | stderr
14/08/2024 09:51 pm | STARTING QBITRR | stdout
14/08/2024 09:51 pm | Rename it to "config.toml" then edit it and restart the container | stdout
14/08/2024 09:51 pm | 'config.rename_me.toml' has been generated | stdout
14/08/2024 09:51 pm | New config file has been saved to "/config/config.rename_me.toml" | stdout
14/08/2024 09:51 pm | config.toml has not been found

Ok, so now add:
volumes:
  - /path/to/appdata/qbitrr:/config

Run it again, then rename the config file generated and change any values required within it

Have you managed to get anywhere? @LazerDickMcCheese

Long story short, changed hardware and had to do a full setup again so I was out of commission for a few days. I just set this up again, I'm getting many errors about "parser.py" Do you want the logs?

Hi, yes. Send trace logs and config please, ideally in a zip

qbitrr.zip

config.zip
Try this config as you didn't pass the correct value types. To make sure the TOML is valid I suggest using VSCode with the following extension installed: Name: Even Better TOML - https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml

It's been a while since I looked at those files, I just realized they have my APIs and passwords in them. Would you mind deleting the ones you uploaded as well? So we have progress, qBitrr isn't stuck restarting. It's currently failing to connect to my Radarr and Sonarr instances, but those are the only errors.

logs.zip
Thank you for your help

I believe that fixed it! Strange, qbit works without http:// in front of the address so I would've never thought to try that. Thank you again for your help.

qbitrr added tags to my qbit, so I assumed it was working. Fast forward a few days and nothing has been tagged (some of them should have been due to the config settings). So I stopped the container, checked the config.toml, and restarted the container. It's back to restarting continuously.
As a side note, qbitrr says it doesn't have permissions to its config folder if I set the YAML to the UID I usually use for docker containers despite having read/write permissions.
qbitrr.zip

If you're on a linux system, I suggest first trying to run chmod -R 777 /path/to/qbitrr/data, and see how that goes

I entered the command, rebuilt the container, and it's still giving the "AttributeError: 'String' object has no attribute 'get'" error in the log and restart-looping

I'll need logs again please

When I start the container, only 2 of the logs write. "Category exists without save path" The arrs have been working just fine, so I don't know which path it's talking about.
"qbitrr.zip

Can you run chmod -R 777 /path/to/qBitrr/config and try running it again? It should produce a few more logs than just that.
Also check docker logs by running docker logs qBitrr in a terminal to check what else is being outputted, sometimes some things aren't captured with the file logs.

qbitrr.txt

Ok, I'll work on fixing this, I see the problem now. In the meantime send over your config, I'll edit it slightly and send it back so you can have a working config

Thank you for your help, you've been very kind. Did I break something? I'm lost here
config.zip

config.zip
Use this config, the issue is the trackers, I'll look into it but you can use qBitrr in the meantime

It's definitely working now! About 600 stalled downloads corrected themselves, and my NAS has been purring ever since. On behalf of everyone using my server, thank you for your help

Very happy to hear, though I'm leaving this open to remind myself to check the trackers issue you had


configureUsing() method not working on octane

Package
filament/filament
Package Version
v3.2.x
Laravel Version
v10.x
Livewire Version
v3.x
PHP Version
8.3.x
Problem description
from version 3.1.46 the configureUsing method changes are not working on octane.
Expected behavior
configureUsing method changes must apply to all requests.
Steps to reproduce
create a filament app and add a code like this:
        Column::configureUsing(function (Column $col){
            $col->label(fn()=>"id".$col->getName());
        });

The column labels must have id as a prefix in all requests.
Reproduction repository
https://github.com/ariaieboy/filament-octane-bug
Relevant log output
No response

This bug is related to this changes:
https://github.com/filamentphp/filament/compare/v3.1.43...v3.1.46
The configureUsing changes only apply to the first request that reaches the octane worker.
and in the next requests, the configureUsing method is not applied.
I think the problem here is that Octane only runs the service providers boot and register methods once.
And in the next requests it uses the booted laravel.

here is the reproduce repo for this bug:
https://github.com/ariaieboy/filament-octane-bug

Note: when you run the application set the worker counts to 1 or you might see the correct answer in some requests since the first request of each worker contains the configureUsing method changes but in the next requests it get cleared.

@danharrin I tested version 3.2.6 but it still has the same problem

i second that

@danharrin Can you re-open this issue?

I moved every configureUsing method call inside the Filament::serving method and now everything works fine. But I don't know if it is a good approach in terms of performance?
If we could set some globals using the panel configuration that would be awesome.

I downloaded your repository. Then I installed Roadrunner with Composer. Then I ran octane:start --workers=1.
The column names appear to be correct for me:
https://github.com/filamentphp/filament/assets/41773797/a2f4b202-1e7a-4e1c-84cd-e7380bd3fb02

I downloaded your repository. Then I installed Roadrunner with Composer. Then I ran octane:start --workers=1.
The column names appear to be correct for me:
Screen.Recording.2024-01-20.at.16.01.23.mov

that's because I put the function in the register method of the appServiceProvider but according to the filament docs we are supposed to put the configureUsing method in boot method 🤔
If you move the method into the boot method it won't work with octane.

Will reopen if more info is provided, but for now I don't know how I can help further.

ok just seen the comment, reopening.

If we put the configureUsing methods into the register method both octane and non-octane apps will work.
I think we should update the docs and add a note about the octane. So people know that if they want to use configureUsing with octane they must put it in the register method, not the boot method.

Should be fixed by #10947.


Number input

It would be good if FormInput could handle numeric input. Caveat: The number needs to be parsed with the browser locale.
It's not enough to simply send the change events through a Number() call, because then you can't type "12.3", because the dot would be stripped when you type it.
FormInput should accept a number type, and provide onChange events with the value as a Number.

@wmertens would love a PR for this 🙂


InfluxDB v2.3.0: Stuck task runs

Steps to reproduce:

Set up a task
Wait for the task's execution
The task is executed but sometimes it is stuck

Expected behaviour:
All task are executed and finished in finite time.
Actual behaviour:
The task is sometimes stuck without any status progress.
Environment info:
Basic installation using package manager.
apt install influxdb2 using version 2.3.0
OS: Linux 4.19.0-17-amd64 Debian 4.19.194-3 x86_64
Disk info: SSD
Config:
bolt-path = "/mnt/ssd2/influxdb2/influxd.bolt"
engine-path = "/mnt/ssd2/influxdb2/engine"
http-read-timeout = "30m"
http-write-timeout = "30m"
http-bind-address = ":8086"
query-concurrency = 20
query-queue-size = 200
storage-max-concurrent-compactions = 1
storage-compact-throughput-burst = 1485760
storage-compact-throughput = 1485760
storage-tsm-use-madv-willneed = true
max-series-per-database = 0

Logs:
No logs were found.
It might be included later.
 The past runs were not available anymore. If it would be helpful, we are able to show data from any given time window.
Based on the metrics the task starting on the timeline finished without problems.
When the tasks got stuck the memory has increased without it being freed.

The same time period but different metric active tasks.
From left to right the tasks were finished without problems (there is an increase and decrease that depicts the tasks being finished)
So we suspect that there is a connection between tasks started and stuck with memory increase.
There are more tasks than one being executed. (that is why the number shown is about 8)

The issue still persists after upgrading InfluxDB to version 2.7.4


Preparing version 1.1

A vision: first only a new branch after some days to master and then a release after short waiting for feedback. No new code now if no new issue.
Changelog

Fix: Allow SOQL query up to 100000 characters, fixed #164
Add: Support for custom authentication modules configurable by
settings.DATABASES['salesforce']['AUTH']
Add: Authentication by Salesforce DX CLI application for developers, e.g. 'salesforce.auth.SfdxOrgWebAuth'
Fix: Easier dynamic authentication. It requires an explicit setting now:
"salesforce": {... "AUTH": "salesforce.auth.DynamicAuth" ...}
Add: Configurable API_VERSION by settings.DATABASES['salesforce']['API_VERSION']
Add: A method .sf() on querysets and managers to can pass additional parameter
e.g. all_or_none=True or edge_updates=True to bulk_create() and update() methods.
Fix: Fixed long delay in application after unstable nework connection #267
Fix: Queryset with empty slice e.g. queryset[100:100]
Fix: Fix "max_length" in inspectdb for Choice Fields, because it is ignored
by SFDC, but important for Django.

i'm not sure why 02b0c998 isn't being tested by travis, but I merged anyway.

Seems like it's just some kind of ordering bug in the GitHub UI. We're good.

Maybe I have pushed the last commit at the same time when the test of older head started,

I was thinking it looked like an issue at the SFDC end, as my last build attempt looks like it timed out, and the actual errors look like temporary ones. Was going to just try the build again today.

If "tox" would start then we would see the lines about dependencies list and install, but this looks really like the test has been cancelled before it started.

Looks like the run I started finished okay. I’m pretty sure it was just a bug in travis or SFDC or something, it’s fine now

It was a fortunamte random failure. I tested it again yesterday when I travelled through the valleys and the forest (average ping > 1s, packet lost 10%) and I found  by reading the log that commits b1451341 and f88ef2b9 (in v0.9) amplify the problems with this type of connection.
I have committed a short fix 249698a7 now directly to master.

It’s really great that you’re able to generate such detailed interaction metrics. Let me know if there’s anything I can do to help.


Add gpg-sign step to drone

@go-gitea/owners need to add secrets (gpgsign_key, gpgsign_passphrase) to make this work and disclose the public part to be usefull ^^.
Friendly ping to @tboerger who develop the drone plugin.
Fix #4182
Related #4167

Codecov Report

Merging #4188 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4188   +/-   ##
=======================================
  Coverage   19.97%   19.97%
=======================================
  Files         153      153
  Lines       30494    30494
=======================================
  Hits         6091     6091
  Misses      23489    23489
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbba25...dce2438. Read the comment docs.

Step to generate the key and import it :
# Generate key
gpg --full-generate-key
 > 1 RSA et RSA
 > 4096
 > 0 (we could setup a expiration date but not necessary)
 > y
 > Gitea Drone Build System
 ><EMAIL_ADDRESS> > y
 > (Provide a good random passphrase)

gpg --export-secret-keys -a LONG_KEY_ID_DISPLAY_AT_END_OF_GENERATION > path/to/private.key

# Import in drone
drone secret add --repository go-gitea/gitea --name gpgsign_key --value $(base64 -i path/to/private.key) --event push --event tag --image plugins/gpgsign
drone secret add --repository go-gitea/gitea --name gpgsign_passphrase --value password-for-key --event push --event tag --image plugins/gpgsign

Please use sub keys, follow a guide like https://www.void.gr/kargig/blog/2013/12/02/creating-a-new-gpg-key-with-subkeys/ to generate GPG keys. Than you can also increase the trust of the endless valid key and use a sub signing key with a limited lifetime for signing the builds.
Beside that the public key should be uploaded to the keyservers and also been provided via the download server.

Now there is also a PR to provide some documentation for the gpgsign plugin: https://github.com/drone/drone-plugin-index/pull/129

Now you can add the excludes attribute and simplify this step :D

Wait util I setup drone.


Problem when loading the valid.pt file

I am working on WikiKG90Mv2 and after downloading the provided candidate file valid.pt file using the below code:
def download_candidate_set(save_dir):     valid_url = "https://snap.stanford.edu/smore/valid.pt"     test_url = "https://snap.stanford.edu/smore/test.pt"     if not os.path.exists(os.path.join(save_dir, "valid.pt")):         url.download_url(valid_url, save_dir)     if not os.path.exists(os.path.join(save_dir, "test.pt")):         url.download_url(test_url, save_dir)
I am having trouble opening the valid.pt file using the provided code:
all_data = torch.load(os.path.join(args.eval_path, "%s.pt" % phase))
The error reported is as followed:
RuntimeError: [enforce fail at inline_container.cc:145] . PytorchStreamReader failed reading zip archive: failed finding central directory
and my environment is python3.6+pytorch1.7.0+cuda11.0.
Many thanks!

Hi, it works fine on my end. Can you redownload the file?


Pre-populated SQLite database

How can i use Pre-populated SQLite database from my app

solved using react-native-sqlite-storage in UWP


cmd/compile: possible oversight with internal/gc.disableExport

I was just studying closure.go and noticed that we invoke disableExport(sym) for closures created.
The signature for disableExport says
https://github.com/golang/go/blob/0ec302c49ee3dd1a7f290db9a326bbfb734e8c35/src/cmd/compile/internal/gc/dcl.go#L1005-L1006
However, in the body of disableExport we see that we invoke sym.SetOnExportList(true)
which toggles the symbol to be exported as per https://github.com/golang/go/blob/0ec302c49ee3dd1a7f290db9a326bbfb734e8c35/src/cmd/compile/internal/types/sym.go#L55
This change is from CL 108216
I believe it should be sym.SetOnExportList(false)
The bug only doesn't show because when creating object files we explicitly check that names are exported as per https://github.com/golang/go/blob/0ec302c49ee3dd1a7f290db9a326bbfb734e8c35/src/cmd/compile/internal/gc/export.go#L56-L58
otherwise if you add debugs you'll see that we encounter closure symbols such as "".bar.func1
Kindly paging @mdempsky @griesemer

Thanks @odeke-em , but I believe it's correct as-is. The OnExportList flag is used by exportsym to avoid adding a symbol to exportlist if it's already been added. The way disableExport works is that it sets OnExportList before exportsym is called, so that exportsym thinks the symbol has already been added to exportlist and avoids adding it again.

Thanks for the reply @mdempsky!
Yes, I saw that before but I now understand the purpose of it and context of usage after your reply, thanks!
Perhaps let's rename that helper function to hideFromExportSym instead of disableExporting? disableExporting to me seems like we are requesting that regardless of its case, prevent it from being exported.
Perhaps let's think of a different marking naming, because (*types.Sym).OnExportList for closures within functions (especially those that have names such as "".bar.func1) is a little confusing, just from reading through the source code.

@odeke-em feel free to leave renaming suggestions over at https://github.com/golang/go/issues/27167

Cool, thanks @josharian I've made the suggestion at https://github.com/golang/go/issues/27167#issuecomment-476968159
and with that I'll close this issue. Thank you @mdempsky for the response too.


MP Productions Current Service Status

MP Productions is working to implement a new system that will display the current status of our services, and our client services in the page footer (bottom of page near copyright).
We have spent much time developing this system, and are anticipating that it will be a quick and smooth introduction to each service.
In addition to data being displayed on each service website, we will have an API Data Feed available upon request.
This feed contains further information about each service including, Version Number, Ownership Name, Operational Status.
We will post further details as we continue to implement this new system.

Thank You - MPSA

We're now back to work with the implementation of our latest development.
ETA until completion is within the next hour.
Thank You, Please bring some coffee! - MPM

Maintenance now complete on all client websites.
MP Productions Services still with Maintenance in Progress (Select services only, Please check other incidents here on the status page).
Thank You - MPM


[Docs] Improve the docs for Consul adapter

Current State:
The meshery-consul docs are missing a description of many of the capabilities of the adapter.
Desired State:
The docs should be well-written and robust.

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

An improvement made. More to come.

I'll like to take this up, but I'm not clear on what to add to the Doc

Sure @jomefavourite do go ahead 👍🏽

Sure @jomefavourite do go ahead 👍🏽

I guide will be helpful, on what to include into the Document

@jomefavourite that's great!
I don't think a guide on what to include into adapter documentation exists (yet).
A couple of thoughts and suggestions:
A good start could be to look at the documentation of the other adapters and related issues, and this one, and consider whether it tells enough to understand the adapters capabilities on both a high level, and a more detailed level. It's good not to duplicate information unless an include mechanism can be used.
A good start would also be to run meshery and install the consul mesh and sample application, and assess whether the documentation tells you what you might like to know. Also, is the documentation in sync with the adapter and the adapters UI? Does the documentation mention something you can't find in the UI?
Should we have a list of all install options, sample applications, and a short explanation for each?
I think it would be useful to have links to the service mesh homepage, and that the terminology is correct.
For instance, the Consul service mesh is called Consul Connect (https://www.consul.io/docs/connect).
The documentation should also be pleasing to look at :-)
For me, the images included here https://meshery.layer5.io/docs/service-meshes/adapters/consul appear too big,  and maybe they shouldn't be included at all, rather pointing to the related documentation.

@mgfeller wow that's a lot. I'll see what I can do. Thanks for the briefing

All improvements are welcome :+1:
Personally, I think I would have started by including links to Consul Connect homepage, replaced the figures with links and a little bit of text to the original material, and possibly include a list with the mesh install preset (just one for the time being: "Consul Connect: unsecured, 1 server, suitable for local exploration").

Hi @jomefavourite, there are some guidelines about documenting adapters here https://docs.google.com/document/d/1b8JAMzr3Rntu7CudRaYv6r6ccACJONAB5t7ISCaPNuA/edit?ts=5f6639df#heading=h.1a405ofum9ao - I forgot about them, sorry. Please let me know if I can help.

I feel this is beyond me, and not really still sure of what to do. Ill unassign myself

No problem, @jomefavourite  There are plenty of issues with more detailed descriptions, e.g. https://github.com/layer5io/meshery/issues?q=is%3Aissue+is%3Aopen+label%3A"good+first+issue"

Okay thanks

Hi @jomefavourite why close this issue? It’s yet to be fixed.

Oh, I'm sorry, I didn't know it closed for everyone. I've been seeing the issue of my dashboard, that's why I closed it.

Oh right, it’s fine. 😃

👍


Update archive messages for threads

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/36389
PROPOSAL: https://github.com/Expensify/App/issues/36389#issuecomment-1942380687
Tests

Log into new expensify, this account is the admin
Create a workspace if needed
Invite a member to the workspace
On another device (incognito window), log in as the member
Make sure you're in the "most recent" priority mode so you can see all chats in the LHN
Create a manual money request as the member, sent to the admin workspace
Send a message in the top level expense chat, the expense report, and the transaction report
Go back to the top level expense chat
Create a thread on your own message and leave it open
Verify that the top level expense chat, the expense report, and the transaction report show in the LHN
As the admin remove the member from the workspace
As the member, verify that the thread updates to be archived
Verify that the top level expense chat, the expense report, and the transaction report show as archived in the LHN
Verify the expense chat is archived, as well as all sub reports/chats
Verify that the archive message says only "chat" instead of  "workspace chat"
Verify that the archive message says removed user's name/email, in the top level thread and the transaction report, when viewed by the admin
Verify that the archive message says "you", in the top level thread and the transaction report, when viewed by the member
Verify that the top level thread and transaction report show "(archived)" in the report name.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as tests/

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1708896760762369

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/77965000/493e4d5c-5f2e-4a97-897e-2dc554c18542

Android: mWeb Chrome

https://github.com/Expensify/App/assets/77965000/a7394798-7b11-41c9-96a8-b0164659e595

iOS: Native

https://github.com/Expensify/App/assets/77965000/cbb0f7f6-e7b1-4cf7-9300-2bfb45056180

iOS: mWeb Safari

https://github.com/Expensify/App/assets/77965000/1da0a3cd-d61e-4bec-958d-1075c98ef932

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/77965000/fe23c9b3-d80a-4bdc-ade1-9da5e42391bd

MacOS: Desktop

https://github.com/Expensify/App/assets/77965000/137bcbc3-000b-4419-9074-676e5d48c320

friendly bump @akinwale

Thanks. Was just taking a look. Will complete the review today or tomorrow.

@rayane-djouah When you get a chance, can you create a Slack thread to verify all the Spanish translations in this PR? After that, I can approve as everything else looks good. Thanks.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Standard data format for sharing compatibility tables

A standard (probably JSON) data format to allow developers to easily consume and build/IDE tooling around different compatibility tables for webdev features.
Perhaps eventually this would allow third parties to submit data sets to be consumed and shown in caniuse.com or with an alternative compatibility table search UI.
Data sets might be published for easier consumption on npm.
Data sets:

https://github.com/fyrd/caniuse
http://kangax.github.io/compat-table/
individual docs pages on https://developer.mozilla.org/en-US/
http://fontfamily.io/
http://stateofwebtype.com/

etc, etc. See more on: https://www.zachleat.com/web/compatibility/

There's a project on MDN for this, but I don't know the details, or if anything about this is public yet.
Maybe @JeremiePat can give some informations.


Doc update for promotion of GMSA feature to Stable

Doc update for promotion of GMSA feature to Stable
Original PR opened by @ddebroy https://github.com/kubernetes/website/pull/19349

/assign @sftim

@VineethReddy02 this looks like it should be tracked for /milestone 1.18

Hi @JeremyWx
Is this PR duplicate of #19349 ? If so, can you please close the duplicate PR?
As tomorrow is the deadline for docs placeholder PR's to be ready to merge state. It helps me to track the docs with ease.

Lets go with https://github.com/kubernetes/website/pull/19349 - the original PR. I have updated the branch with the desired changes with a clean commit history.

@ddebroy can you close this? As this already tracked by #19349

I will close it.


View In Your Space on Editor not working?

Using and iPhone 13 mini and an Phone 14 Pro:
Astronaut on the landing page: https://modelviewer.dev/ loads perfectly in AR
Astronaut (and all other models) on the Editor page: https://modelviewer.dev/editor/ does not.  Specifically, after deploying on mobile, the "View in Your Space" button renders but nothing happens when you click it.   (Regardless of whether or not this "Default AR Mode to Scene Viewer" box is checked).
Other model-viewer apps working fine.

i have the same issue

Same here, iPhone 13 Pro Max, in Chrome, Brave and Safari, hitting the "View in Your Space" doesn't do anything.

@grorg was there some kind of Quick Look regression? Or maybe an incompatible USDz spec update?

Same. It works neither on my iPhone 14 pro max nor Samsung J8.

I found out that it works if you open a working quick look demo (on apple's site, for instance), reload the editor page on iPhone, and hit View In Your Space while it's still loading. I don't know. Maybe this helps.

@meshula Do you know of any Quick Look regressions in the last couple months?
For the rest of you, I'm not able to repro the problem on Android at least. Can anyone add some device specifics and if it's working elsewhere? It's exactly the same code running, so it would be odd if the AR mode was only broken in the editor's mobile view and no where else.

No, I haven't heard of anything that would explain this. One place to ask would be the ASWF USD working group on assets, there's folks there with knowledge of Quick Look issues and they might have some insight.

I have the exact same issue. The HD Astronaut and almost all the other AR files work fine, but the QR code process would load a file 70% and then freeze. I tried a super simple object to make sure it wasn't textures or poly-count and it loaded via QR code but wouldn't go to AR. Latest IOS software and tried on an iphone XR and an older ipad. Same problems.

I also have this issue and I can confirm that it works only if "view in your space" is tapped before the model has finished loading which is sometimes tricky (it can be very fast).

I have the same issue on Iphone14 pro

same issue

Using and iPhone 13 mini and an Phone 14 Pro:
Astronaut on the landing page: https://modelviewer.dev/ loads perfectly in AR
Astronaut (and all other models) on the Editor page: https://modelviewer.dev/editor/ does not. Specifically, after deploying on mobile, the "View in Your Space" button renders but nothing happens when you click it. (Regardless of whether or not this "Default AR Mode to Scene Viewer" box is checked).
Other model-viewer apps working fine.

Have same problem (iPhone 13mini)

Okay, I have a repro on my very old iPhone, but not on my Pixel. I thought this was an iOS issue, but if someone has a repro on Samsung, then maybe not. I'll see if I can figure something out in Safari's dev tools.

On my iPhone 8, I can only see the astronaut which has the ios-src path specified. The auto-generated usdz doesn't work.

As I reported in another issue, the auto-generated usdz fails in Firefox for me but works in Safari.


include NAMAPkit into swift  project using bridge header

Hi ,
i really need help to include this library into swift project  using bridge header i.e without pod  installation

Alright, closing as a dupe for #56 and #57 - sorry you two, but I'm now blocking you from this repo.


Fix code

Updated python print functions

If you could add an edit into the credit section of each file as MarcoFalke has done most the previous work here and either way is sufficient imo.
Not needed but happy to sign off once credits are fixed.

Well, I've satisfied myself that the change is necessary, as in Python2 print "something" works, and `print ("something") also works, while in Python3 the former fails and the latter succeeds.
Python 2.7.17 (default, Oct  6 2020, 23:05:51)
[GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> print "something"
something
>>> print ("something")
something
>>>

Python 3.10.10 (main, Feb  8 2023, 05:44:38) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> print "something"
  File "<stdin>", line 1
    print "something"
    ^^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
>>> print ("something")
something
>>>

add an edit into the credit section of each file

In order to do this in a concise and standardised way I'm trying to find an example of adding a minor editor in the credits. It doesn't seem to have been done before, except for in release notes.

In future PRs and commit messages, please be a bit more concise. "Fix code" is very vague.

Tested ACK
The check_doc.py, clang-format-diff.py, zmq_sub.py, and optimize-pngs.py. Scripts are still broken on 3.8+, so 2.7 is still required. However, this change does not break the 2.7 version as it supports both syntaxes for the print function so I've gone ahead and approved this PR.
In optimize-pngs.py you missed a few print functions, I've gone ahead and pushed updated syntax for them.

Once @farsider350 recommendations have been added and approval is given by @farsider350 this will be merged.

We will merge this, add credits to release notes and in future PR's can be made to develop branch.


make a new release agains akka 2.4.2

refs https://github.com/softwaremill/reactive-kafka/pull/77 for 0.8
refs https://github.com/softwaremill/reactive-kafka/pull/78 for master

:+1:


Let RUBY_BUILD_MIRROR_PACKAGE_URL work even when there is no checksum

And add RUBY_BUILD_IGNORE_CHECKSUM when it is expected the alternative URL has different contents.

This is useful for instance when testing a truffleruby release which is not published yet.
Then I need to use a custom URL, like:
RUBY_BUILD_MIRROR_PACKAGE_URL=https://github.com/my/url.tar.gz ruby-build truffleruby-23.1.0 ~/.rubies/truffleruby-test

I also want this to try dev builds at a different URL, hence this change.
And finally I would also like a way to skip the checksum check, for instance when trying a variant of a release which therefore has a different URL and contents but yet I want to reuse the existing definition.
For example this can be useful if I want to try the CE build instead of GFTC build of truffleruby 23.1.0, like this:
RUBY_BUILD_IGNORE_CHECKSUM=1 RUBY_BUILD_MIRROR_PACKAGE_URL=https://github.com/oracle/truffleruby/releases/download/graal-23.1.0/truffleruby-community-23.1.0-linux-amd64.tar.gz ruby-build truffleruby-23.1.0 ~/.rubies/truffleruby-test

Right, this is indeed not mirroring.
@mislav How would you feel about adding another environment variable then?
I was thinking something like RUBY_BUILD_OVERRIDE_RUBY_URL or so originally (and this would only override the URL if it's "a ruby" package, which then would use the same check as here).
(then I saw RUBY_BUILD_MIRROR_PACKAGE_URL already existed and it seemed nicer to extend it)

I take this as custom build definitions not being a suitable workaround for you?

Yeah they would be too annoying to be of any real use.
Also for the first 2 use cases, those are actually quite related to mirroring, and custom definitions there would not be testing what we want.

@mislav What do you think of the above? Which way would be OK to merge?

@mislav Updated, could you review and merge if it's OK?

Rebased on top of master to include https://github.com/rbenv/ruby-build/pull/2268, and locally shellcheck bin/ruby-build is clean.

Indeed it's beautiful how small it is, I was positively surprised as well :)


Complicated regex in ValidatePattern breaks the grammar

Function Get-Domain
{
    [CmdletBinding()]
    param(
        [ValidatePattern('^(?=^.{1,254}$)(^(?:(?!\d+\.)[a-zA-Z0-9_\-]{1,63}\.?)+(?:[a-zA-Z]{2,})$)')]
        [Parameter(ValueFromPipeline = $true)] # this line should not be highlighted as a string
        [string]$domain
    )
}

I have a fix for this, but I'm not sure where it should be sent - it seems various different editors use TextMate's language definition for Powershell, but I've never used TextMate (and can't, being as how I abhor Macs), so I can't text the fix there...

Yes, this is the right place.
Atom, VSCode and GitHub uses the same grammar.
On Fri, Feb 12, 2016 at 6:07 AM, Bryan Childs<EMAIL_ADDRESS>wrote:

I have a fix for this, but I'm not sure where it should be sent - it seems
various different editors use TextMate's language definition for
Powershell, but I've never used TextMate (and can't, being as how I abhor
Macs), so I can't text the fix there...
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeText/PowerShell/issues/132#issuecomment-183344563
.

Oh, apparently another comment was removed

@godeater this is the right place :)

I removed the comment I put earlier as I found that the new grammar I had, although it didn't wreck the syntax highlighting through the rest of the buffer as the current one does, now only highlights on the first "variable=value" in a [Parameter( block.
I'm trying to work out if it's worth submitting it still as the lesser of two evils, or keep plugging away to see if I can fix the regex properly.

Go ahead and fix it properly if you want to.  Definitely doesn't make sense to pull it in yet if it breaks other highlighting.

This regex became pretty complicated, good luck.
You can share preview of your results with https://github-lightshow.herokuapp.com/

s/want to/can/ =/
After I noticed that problem, I kept looking at it all afternoon without much success.
Take a look at these and see which you think would be best to use.
With current grammar:

With new grammar:

@godeater send a PR with a reference to this issue, we can take a look together.
It always takes few hours to switch context to tmLanguage syntax, but I feel there were no releases for quite some time and GitHub's highlighting is out-of-date.

I've sent a pull request, but not sure if I've done it right or not.

I presume the decision was taken that this wasn't good enough?

Was this ever resolved? I seem to be having the same issue at present and it's making it difficult to switch to atom for powershell.

@godeater hey sorry for a very long reply time: completely slipped out of my radar. It looks like you sent https://github.com/SublimeText/PowerShell/pull/145 , right?
I think all maintainers just dropped ball here at the time, not that it was not good enough. Sorry for that.

The plan was to move highlighting development to https://github.com/PowerShell/EditorSyntax but it stalled a little bit too.

Thanks for the update.  Seems there are a few bugs related to syntax highlighting in there.  I'll see how they're progressing.


Remove integrity_check from the node

The "fast-sync" node should not perform any kind of data integrity checks. Apparently, even when the node has some incorrect state it should be able to "repair" it via the process currently known as "archival sync".
Potentially also get rid of the PidFile, but this still need to be agreed.

@rafal-ch @marc-casperlabs is ok with removal of pid file - just fyi ( if ok capture the point estimate accordingly)


Adding BCEditor to Delphinus Packagemanager

Hi,
BCEditor seems to be quite interesting and a possible successor to Synedit? Are you interested in adding it to the Delphinus Packagemanager?
Delphinus is a Packagemanager like GetIt but supports Delphi XE to Seattle. It runs directly from the IDE, too. All that's required is to add 2 files (one for general information and one which is the install script) to the Github-repository with an extra keyword in the readme. It is then automatically found by the clients for installation.
For more information: https://github.com/Memnarch/Delphinus/wiki
or simply ask me if you have any problems or questions
PS: If you add it to Delphinus, i encourage you to use the release feature of Github (after release if you want, instead of just changing the readme). This way, users get a notification when a new version is available and can update directly.

Maybe after release. There are a still work to be done before the desirable quality is reached.

Okay :)
PS: this issue wasn't meant to be implemented right away, in case it looked like it, i am sorry.

Hi,
It seems you have made some great progress (and some releases ;) ). If you're interested i'd like to help you where ever i can.

If you mean the package manager, I haven't thought about it much. I am moving to another city soon, so there are other things to think about. :)

Currently moving aswell ;)


Fix Error During Checkin

Removed code that was causing the error since it was unnecessary
anyway.
Also added a unit test to test submitting invalid data during
checkin.
Fixes: #179

Pull Request Test Coverage Report for Build 497

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 99.209%

Totals

Change from base Build 494:
0.07%

Covered Lines:
3451

Relevant Lines:
3477

💛  - Coveralls


Support LibP2P Peer Exchange functionality

Description
We can discover peers to connect to via LibP2P's discovery and should use this to augment our discv5.  In practice I'm getting the PeerID but no signed peer records but these peer IDs would still make useful search targets for Discv5 rather than always randomly searching the DHT.
BTW you may get additional info from this Gossip callback: https://github.com/libp2p/jvm-libp2p/blob/3d5be408f6cc4195858cdabef187160bd812a3d8/src/main/kotlin/io/libp2p/pubsub/gossip/GossipParams.kt#L180-L184
This is a new Peer Exchange feature of Gossip 1.1

This hasn't wound up being adopted in eth2, closing.


Add a Mini-spec for cursorTextColor

Summary of the Pull Request
The issue here is that we draw the cursor on top of the text. This spec introduces a new setting that lets us:

draw the cursor on top of the text
draw the cursor underneath the text
draw the cursor underneath the text, and provide a specific color for the text drawn on top of the cursor.
draw the cursor underneath the text, and use the text background color as the foreground for the text drawn on top of the cursor.

References
PR Checklist

[x] This is a spec for #1203
[x] I work here

Detailed Description of the Pull Request / Additional comments
read the spec

Concerns from a chat on Friday:

This will break ligatures under the cursor

If we explicitly redraw the cell under the cursor, we may draw half a ligature plus a normal character after it :(

Because the background is drawn with the run, drawing the cursor before a run with a background will result in the cursor being destroyed

Filed https://github.com/microsoft/terminal/issues/6193 as a discussion platform for one way to fix cursor-behind-text.

#7118 is the followup for lighting up invert and perhaps others.

This has gone fairly stale, and doesn't address the concerns about ligatures. I think #6193 is the direction we want to go with this eventually. So I'm just gonna close this out for now.

This has gone fairly stale, and doesn't address the concerns about ligatures. I think #6193 is the direction we want to go with this eventually. So I'm just gonna close this out for now.


Should not process anything in block-level HTML tag

According to http://stackoverflow.com/questions/10438937/is-there-a-markdown-parser-supported-on-jekyll-that-plays-nicely-with-mathjax and also github markdown itself doesn't process anything inside an HTML tag.
For example, there is a difference between
 [go to google](www.google.com) <-- I have enclosed this with a div tag
and
[go to google](www.google.com)
This matters to me because I'm using Mathjax in a markdown document, and I can't use div tags to prevent underscores from being processed as in usual markdown engine.
Perhaps there should be an option to remedy this?

I just realized that this should probably be something to do with the python-markdown parser. Sorry about that.


Standalone clear image & kernel install scripts

Note: I couldn't test this in CI, and these are fairly intrusive changes. At least the 2 individual scripts do work locally.
I decided I wouldn't install clear kernel and images by hand any longer so I split two scripts out of the ci setup script.
# ./.ci/install_clear_kernel.sh 14700 4.9.4-57 /usr/share/clear-containers
# ./.ci/install_clear_image.sh 14700 /usr/share/clear-containers

let's get this landed and improve incrementally to keep the momentum for now.
lgtm

LGTM

lgtm


Problems when selection and drawing exist at the same time

When I register in the map at the same time
map.addInteraction(Select); and
map.addInteraction(draw); At the end of drawing, the figure is selected. When the select is not registered, the drawing is over and not selected.
Therefore, when I register draw and select at the same time, I hope that the drawing is not selected when the drawing ends. what should I do.
This is the example on openlsyer：
https://codesandbox.io/s/gshrm?file=/main.js
Add to
import Select from 'ol/interaction/Select';
var selects=new Select();
map.addInteraction(selects);

I had this problem before. You could set stopClick property to true when you create the draw widget:
draw = new Draw({
      stopClick: true,
      source: source,
      type: typeSelect.value,
});

https://openlayers.org/en/latest/apidoc/module-ol_interaction_Draw-Draw.html

Possibly related to #12147


Application

Thank you very much for your great work. Your dedication is greatly appreciated! As I want to apply TimesNet to extract time series features, only to feature vectors, not to prediction. I would like to ask you how I should modify the TimesNet model part?

Hi, you can adopt the prediction/imputation as the unsupervised task for representation learning.


Passing JenkinsFile parameter to children

Previously, the JenkinsFile parameter
would not be passed onto children builds,
which would cause an issue if the user
wanted a JenkinsFile architecture that was
not the default. The children would spawn
with the default architecture
(openjdk_x86-64_linux), and as a result,
it would fail. This change passes the
parent's architecture to the children so
that the bug would be fixed.
Signed-off-by: Michael Wang<EMAIL_ADDRESS>

@llxia Can you please take a look at this? There was an old issue involving passing the JenkinsFile architecture that we fixed while adding other features, and we decided that we should probably fix this minor bug first. We'd like to introduce it to the project.

Please define a default value for JenkinsFile parameter. The current code will break the regular test builds as they do not have JenkinsFile parameter defined.
We need something as follow:
JENKINS_FILE = params. JenkinsFile ? params.JenkinsFile : ""

Would an empty string as a default value be sufficient for the regular test builds?

Would an empty string as a default value be sufficient for the regular test builds?

yes, i think so. JenkinsFile is not used in the regular build, but it cannot be undefined.

LGTM. @llxia what do you think?

Please do not modify any unrelated files (i.e., external/payara-mp-tck/playlist.xml, openjdk/ProblemList_openjdk13-openj9.txt, etc )

The old commits have been erased from this commit. It was re-tested with the Grinder, and here are the links with the launcher and first child:
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/969/
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/970/

Hi @llxia , could you please have a look through the changes and see if we can complete the pull request? Thanks!

Tested in the regular build.


Optimize settings storage and delegation

In my testing this improves minimum start up time (i.e. in steady state after sbt has cached everything from a previous run, testing with time sbt exit && time sbt exit && time sbt exit using the last result) for cinnamon by ~10 seconds both on 1.1.0 and 1.1.1.
Startup time 1.1.0 Vanilla: 56s
With the patch: 44s
Startup time 1.1.1 Vanilla: 63s
With the patch: 52s (together with the validId patch 45s)
This is quite a big improvement for such a self-contained change (and if you know what sbt else is doing startup...)
It also show that sbt 1.1.1 seems to have an unrelated performance regression that costs ~ 5s.
/cc @bantonsson

Thanks for the comments, @eed3si9n. Just FYI, I'm not sure when I'm able to continue on this, maybe end of the week.

ok. We are happy to take the commits and try to bring it to the finish line if you're busy.

/cc @retronym

I tested this patch with the current development head (after resolving conflicts). I found the speedups to be a bit more modest in the akka project. It took about 18.75 seconds to load with the current development HEAD and 18.25 seconds with this patch applied.

Yeah, that doesn't seem to be enough alone to warrant that change. I guess it would need some reprofiling at this point before deciding if it is still worth something or what needs to be done to improve it to get the speedups I measured back then.

I think it's time to either update this branch and possibly merge or close the PR.


how can I use this

please teach me how can I use this ,ty

You will need to install NodeJS and then clone this repository locally.
Compile the program and run it using node.
If you are not familiar with these tools, feel free to shoot me a DM on discord @mauritswilke


make returning plain objects and prefixing prototype overwriting properties optional

this is a short term solution before 5.0.0 which will change everything. Essentially the default behavior will match the 2.x releases, with the difference that you may set the plainObjects option to true to get the behavior from the 3.x releases.
If you don't want plain objects but also don't want to lose keys that would overwrite prototype properties, you can set the prefixPrototypes option to true and those keys will be prefixed with an underscore '_' and passed along. It's not perfect, but at least the keys aren't silently ignored.
Would appreciate your feedback on this one @hueniverse @dougwilson

To me, this seems to make the situation potentially worse, especially for user-confusion, because of the following not being the same:
$ node -pe 'JSON.parse('"'"'{"hasOwnProperty":"yes"}'"'"')'
{ hasOwnProperty: 'yes' }

$ node -pe 'require("querystring").parse("hasOwnProperty=yes")'
{ hasOwnProperty: 'yes' }

$ node -pe 'require("qs").parse("hasOwnProperty=yes")'
{ _hasOwnProperty: 'yes' }

Can there be an option to use the default prototype and just overwrite properties, even if it's something you have to opt into?

lol, please ignore my above comment, as it was technically only based off reading the source code. I see there is prefixPrototypes, may bad!

prefixPrototypes is what allows things that would overwrite a prototype property at all, by prefixing them with a string.  if it's set to false then prototypes would be ignored like they were in 2.x. I can see your point about confusion though, so I can get rid of that option and add an allowPrototypes instead that will let people shoot themselves in the foot if they so wish.

So I had made that comment in haste :) Let me really look through it to see what real comments I have :)

Looks fine to me. Can't make everyone happy and I really don't care about prototype names in payload. This is JS.

Ok, so this PR seems fine in general. My only real comment is that I don't think the global environment should affect the functionality of the library:
$ node -pe 'require("qs").parse("hide=1")'
{ hide: '1' }

$ node -pe 'Object.defineProperty(Object.prototype,"hide",{value:function(){},writable:true});require("qs").parse("hide=1")'
{}

JSON.parse and the built-in query string does not have this issue, though:
$ node -pe 'Object.defineProperty(Object.prototype,"hide",{value:function(){},writable:true});JSON.parse('"'"'{"hide":"1"}'"'"')'
{ hide: '1' }

$ node -pe 'Object.defineProperty(Object.prototype,"hide",{value:function(){},writable:true});require("querystring").parse("hide=1")'
{ hide: '1' }

That would be resolved by exchanging prefixPrototypes with allowPrototypes, the latter being an option to let you overwrite properties on Object.prototype.

Ok, changed this around so instead of optionally adding a prefix to properties that would overwrite the object prototype it instead optionally lets you shoot yourself in the foot, just like JSON.parse. It's off by default, but it's there.

This is only breaking when using { prototype: false } right?

this reverts the breaking change made in 3.x, so it's in itself another breaking change, though odds are if you don't use any of the prototype stuff on parsed results you'll never notice.

ok, thanks for the explanation


MySqlGrammar::getBitwiseOperators does not exist.

Laravel Version: 8.83.2
PHP Version: 8.0.12
Database Driver & Version: 10.3.31-MariaDB-0+deb10u1

Description:
BadMethodCallException
Method Illuminate\Database\Query\Grammars\MySqlGrammar::getBitwiseOperators does not exist.

Steps To Reproduce:
For me, this error was caused while running jobs.

Most likely, you need to restart your queues when deploying new code because this was added to the release you mentioned here: https://github.com/laravel/framework/pull/41112/files#diff-7ea7f749a25a923af9ac94f5fabe101c9bbbc98e448f97eeed773da965042a8cR1327


[API] Search by member's name

Update the existing GET members route to support searching by name.

Hi
I'd like to take that.

Hi I'd like to take that.

Sure. Go for it.

resolved with https://github.com/HackRVA/memberdashboard/pull/169


remove alert window for errors and display incorrect password message…

… into the modal window

@AndreeaDora looks good. I was wondering if we should use the same technique to display any other error messages on the UI, but by inserting them into an element in the UI and not using modal. We could do this as a separate feature.

Pull request closed. Another pull request was submitted with the commits merged. #65


Revert "Adding stricter Sub account check for quota check"

Reverts cloudfoundry-incubator/service-fabrik-broker#1107

Pull Request Test Coverage Report for Build 4796

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.002%) to 89.244%

Files with Coverage Reduction
New Missed Lines
%

data-access-layer/cf/src/TokenIssuer.js
1
98.55%

applications/osb-broker/src/api-controllers/middleware/index.js
6
89.82%

Totals

Change from base Build 4774:
-0.002%

Covered Lines:
9400

Relevant Lines:
10167

💛  - Coveralls


Large regression in web_size__compile_test

SkiaPerf is reporting a several MB regression in uncompressed size on the engine roll here https://github.com/flutter/flutter/commit/5cd942f1545123c059079eb2df31702188bb3949:
https://flutter-flutter-perf.skia.org/e/?begin=1680063663&end=1680068938&keys=X41e9925328f9df4124939a70b0c3ec7a&selected=commit%3D34052%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Dbasic_material_app_canvaskit_wasm_uncompressed_bytes%252Ctest%253Dweb_size__compile_test%252C&xbaroffset=34052
Eyeballing the commits, it seems like this is due to https://github.com/flutter/engine/pull/40737, but I'm marking this P2 for initial triage.
cc @hterkelsen @eyebrowsoffire

Also https://flutter-flutter-perf.skia.org/e/?begin=1680046748&end=1680074162&keys=X30be105b706881c87490b8befc483ed1&num_commits=50&request_type=1&xbaroffset=34052

Our current build flags for CanvasKit are our best compromise of size and performance. We are still looking into how we can improve code size but this regression isn't a P2.


Add the possibility to stop receiving inputs from a channel

I love the system of buses of Tone. However, it seems that it is not currently possible to stop receiving inputs from a channel. For example:
Tone.Master.receive("channel0");
Tone.Master.receive("channel1");

// ...

// Unable to stop receiving from the previously defined channels :(

This will tell Tone.Master to receive inputs from channel0 and channel1. But then I can't cancel the reception from channel0 for example. Maybe it would be a good idea to implement this feature:
Tone.Master.receive("channel0");
Tone.Master.receive("channel1");

// ...

Tone.Master.cancelReceive("channel0");

Let me know if you think it's possible, and if that's the case, I'd be happy to send a PR. :)

There is no way currently to control this from the receive function, but the send method returns a Tone.Gain which can be used to change the level or disconnect the send entirely from the receiving node.
Does that work for your use-case?

Not exactly; my point was more that even if you disconnect every node previously connected using send, the receiving node still "expose" a channel on which it's possible to send inputs. What I was pointing out is that it's not currently possible to say "I do not want this node to receive inputs from this channel anymore".
Maybe this example is better:
const reverb = new Tone.Freeverb().toMaster();
const distortion = new Tone.Distortion().toMaster();

// These effects receive inputs from the same channel
reverb.receive("channel");
distortion.receive("channel");

// Now I don't want the distortion effect to receive from this channel anymore,
// which means that even if I send to "channel" later, it will not be connected to the distortion effect
distortion.cancelReceive("channel");

What do you think?

Busses generally work the other way around. An audio channel can have either a bus, mic or no input (which generally means it plays audio tracks if any are assigned to it) in most DAWs. Other channels can send to a bus from their sends section.

i agree with @Idicious. i prefer the send-centric way of thinking about it with the current API.
@anthonydugois one way to achieve what you're trying to do would be to 'receive' to a GainNode and then connect/disconnect that GainNode to whichever routes you'd like and that'll give you a sort of cancelable bus like you're looking for.


Updated fetch polyfill version in export task so export works

Closes aurelia/skeleton-navigation#213

Thanks!


Dict training segfaults with small value of maxdict

Using git version c580b75, tagged v0.5.1.
When running programs/zstd --train lib/*.c --maxdict 1024 (creating a dictionary from zstd's own source code), I get a segfault. Backtracking gives:
Program received signal SIGSEGV, Segmentation fault.
0x000000000040be88 in FSE_encodeSymbol (bitC=0x7fffffffc4e0, statePtr=0x7fffffffc480, symbol=216) at ../lib/fse_static.h:261
261	    statePtr->value = stateTable[ (statePtr->value >> nbBitsOut) + symbolTT.deltaFindState];
(gdb) bt
#0  0x000000000040be88 in FSE_encodeSymbol (bitC=0x7fffffffc4e0, statePtr=0x7fffffffc480, symbol=216) at ../lib/fse_static.h:261
#1  0x000000000040dd35 in ZSTD_compressSequences (zc=0x6ea200, dst=0x6ebe50, maxDstSize=131072, srcSize=97838) at ../lib/zstd_compress.c:697
#2  0x00000000004281ea in ZSTD_compressBlock_internal (zc=0x6ea200, dst=0x6ebe50, maxDstSize=131072, src=0x6a8ddf, srcSize=97838) at ../lib/zstd_compress.c:1909
#3  0x000000000042872f in ZSTD_compressContinue_internal (zc=0x6ea200, dst=0x6ebe50, dstSize=131072, src=0x6a8ddf, srcSize=97838, frame=0) at ../lib/zstd_compress.c:2014
#4  0x00000000004287ed in ZSTD_compressBlock (zc=0x6ea200, dst=0x6ebe50, maxDstSize=131072, src=0x6a8ddf, srcSize=97838) at ../lib/zstd_compress.c:2032
#5  0x000000000044afe0 in ZDICT_countEStats (esr=..., countLit=0x7fffffffd540, offsetcodeCount=0x7fffffffd4c0, matchlengthCount=0x7fffffffce80, litlengthCount=0x7fffffffcc80, src=0x6a8ddf, srcSize=97838) at ../lib/zdict.c:604
#6  0x000000000044b379 in ZDICT_analyzeEntropy (dstBuffer=0x6730b4, maxDstSize=1020, compressionLevel=5, srcBuffer=0x6734c0, fileSizes=0x673070, nbFiles=7, dictBuffer=0x6731de, dictBufferSize=722) at ../lib/zdict.c:662
#7  0x000000000044be7c in ZDICT_trainFromBuffer_unsafe (dictBuffer=0x6730b0, maxDictSize=1024, samplesBuffer=0x6734c0, sampleSizes=0x673070, nbSamples=7, params=...) at ../lib/zdict.c:873
#8  0x0000000000461923 in DiB_trainFromFiles (dictFileName=0x465f98 "dictionary", maxDictSize=1024, fileNamesTable=0x673010, nbFiles=7, params=...) at dibio.c:258
#9  0x0000000000456b14 in main (argCount=11, argv=0x7fffffffdc98) at zstdcli.c:381

Is there some minimum size the dictionary requires to properly initialize?
EDIT: still happens on the dev branch.

Thanks for notification.

Is there some minimum size the dictionary requires to properly initialize?

Maybe it should :)

Latest update in "dev" branch should fix this issue.
The program check for a very minimum dictionary size (a few hundred bytes), below which there is basically no space left to work.
But of course, dictionary lose its efficiency before reaching such unreasonable levels.


Color pages is not displaying correctly

Game editor color chip is not calculating the correct number of pages

This has been fixed.


Read translation value on drag

Looks like a great library! However, I need one exactly like this that would enable me to read translation value on drag gesture so I could use it to perform other animations, like the one below.
Check this one: https://github.com/Wouter125/BottomSheet

I would also like to change the position/color of my content in relation to the relative drag position

Looks complicated to add. If someone wants to speed up the addition of this feature, help in form of Pull Requests would be appreciated.

Im currently rewriting the bottom sheet. The feature will soon be added.


[SVCS-294] Add rename validation

Purpose
Currently you can rename a file or folder whatever you like, this creates a variety of error behaviors for the different providers. For Dropbox filenames with slashes create bad folders and files, for other providers the rename will just fail with no explanation, this fix alerts the user they are using an illegal character.
Changes
Add two static variables for the base provider FORBIDDEN_FILENAME_CHARS and FORBIDDEN_FOLDERNAME_CHARS which are used by validate_rename to bar the use of invalid characters.
Also cleans up some superfluous code in movecopy.py
Side Effects
None that I know of.
Tickets
https://openscience.atlassian.net/browse/SVCS-294

Coverage decreased (-0.09%) to 76.593% when pulling f501339f4347e426ba1dbc867059b0bc1870d456 on Johnetordoff:drop-box-slash-issue into b787a92c180697cb8fb2f5b6c402cf7b931b339d on CenterForOpenScience:develop.

Coverage decreased (-0.1%) to 88.889% when pulling 420c66d63a7ce7945904dd1da92286847dd55a31 on Johnetordoff:drop-box-slash-issue into 481c9d97cdce74a1e17cbaee9b9095976104e7e3 on CenterForOpenScience:develop.

Coverage decreased (-0.1%) to 89.798% when pulling e6edbe85b2005629b1c7ce5c2fec50829cf05ebd on Johnetordoff:drop-box-slash-issue into 26bf2093c15af333e634f14372709e7bf014ccb4 on CenterForOpenScience:develop.

TODO: Double check this isn't supported, and clarify pr message a little bit.


Update remark

Hi! :wave:
I think it’s time to update to a newer remark! There were quite some fixes since ^5.0.1.
Let me know if you need help!

Yes! I will update this in next week.
TBD: I plan that move this module into monorepo for integration test.
https://github.com/textlint/textlint/issues/270

Yay! 🎉


Controller Code does not compile .NET Core 2.1 / ASP.NET Core 2.1.1

Hello,
There is several issues in compiling Controller code for .NET Core 2.1 / ASP.NET Core 2.1.1 - I cannot compile the code. Is it my mistake?

Microsoft.AspNetCore.Mvc.RoutePrefix attribute does not exist
(Check "Generate optional parameters" + Check "Add cancellation token"): optional parameters cannot be specified like that before the mandatory cancellation token
(Check "Wrap success responses to allow full response access"): Request.CreateResponse (no overload takes 2 arguments)

Best wishes!

I fixed compile time errors overriding the liquid template. Tomorrow I will check if it works functionality-wise and create a PR to fix the issues.

Is there a work-around until the CreateResponse issue is fixed?

The RoutePrefix issue can be resolved by using the ASP.NET Core Route attribute
The cancellation token issue can be fixed by appending "= default(CancellationToken)" to the cancellation token definition
The CreateResponse method was completely removed in ASP.NET Core. You'll need to use the StatusCode() method of the controller to create an IActionResult, and work from there

I started to rewrite the template but saw that it's not about simply fixing this issues. It also does not generate model code and it misses verification code. Overall impression was that NSwag is more thought to generate Swagger specs from .NET Code, but not to generate (powerful) .NET Code from Swagger.
Thats the reason why I moved to OpenAPI-Generator for now. I unfortunately do not have the resources right now to fix the issues for NSwag.


修复 BeanUtils#declaredFields allMatch 不生效

修复 BeanUtils#declaredFields allMatch 不生效，并提交case

只用合并 4e7ee50 这一个提交就行

Codecov Report

Merging #90 (4e7ee50) into main (52c0e59) will decrease coverage by 0.53%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main      #90      +/-   ##
============================================
- Coverage     64.85%   64.31%   -0.54%
+ Complexity     8116     8075      -41
============================================
  Files           420      421       +1
  Lines         45651    45734      +83
  Branches       9230     9255      +25
============================================
- Hits          29607    29416     -191
- Misses        12458    12732     +274
  Partials       3586     3586

Impacted Files
Coverage Δ

...va/com/alibaba/fastjson2/reader/ObjectReader6.java
76.66% <ø> (+0.26%)
:arrow_up:

...ain/java/com/alibaba/fastjson2/util/BeanUtils.java
67.19% <77.77%> (-0.21%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/asm/ASMUtils.java
86.25% <100.00%> (-0.17%)
:arrow_down:

...com/alibaba/fastjson2/util/DynamicClassLoader.java
91.17% <100.00%> (-0.26%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
45.80% <0.00%> (-24.52%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
71.69% <0.00%> (-7.55%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
73.50% <0.00%> (-7.29%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
54.39% <0.00%> (-5.07%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
77.21% <0.00%> (-5.07%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c0e59...4e7ee50. Read the comment docs.

issue讨论可以有中文，但代码中不要有中文

问题可以有中文，但代码讨论中没有中文

好的，以后注意。


Windows Application Try Icon not working

I am using Desktop app, we have a version 2.15.5, but when someone is writing me in app icon below on task-bar, where is no try icon showing that i have 1 or 2 unread messages.
in account setting is true - "Unread Tray Icon Alert"
no one can understand that he must open to read new messages

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Cannot Edit the Groups configuration in a configured Active directory.

Describe the issue:
When an Active directory is configured cannot edit the Groups section.

How to reproduce:

Configure an Active directory
Configure it as a Secondary US
Navigate to the created Active directory and try to edit configurations in the Groups section

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Wiil be fixed with: https://github.com/wso2/carbon-kernel/pull/3892


Can't find the pyasm docs

The link you gave in your README no longer works. Has the docs been shifted somewhere else? This is the link you provided.

Sorry this got lost when I moved my site to jekyll. Here is a link to the raw text document. I'll work to get this on the new site.
https://github.com/grant-olson/pyasm/blob/master/doc/usersGuide.txt

Thanks :+1:


Update the step function in Readme?

Hi, thanks for the amazing repo. It seems that the step function now output 5 variables (including truncation) instead of four.
Can someone update the readme file to reflect this change?

It will be updated in an upcoming release


Clean up model dir

We should clean up the model dir and move commands, handlers, events and exceptions into sub folders of the aggregate root folder:
Model\User
|__ Command
      |__ RegisterUser.php
|__ Handler
      |__ RegisterUserHandler.php
|__ Event
      |__ UserWasRegistered.php
|__ Exception
      |__ UserNotFound.php
|__ User.php
|__ UserCollection.php
|__ UserId.php

This change makes it easier to get a clear view of the domain.

done with #17


/layouts/_default/baseof.html seem not to be look for

/layouts/_default/baseof.html template file seem not to be seek for render homepage.
I put my own baseof.html but not replace the /theme/<theme_name>/layouts/_default/baseof.html one.

I have met the same problem.
Hugo seems does not render the site at all when I make  a /layouts/_default/baseof.html and delete the /_default/baseof.html in the theme folder.

What Hugo versions?

hugo: stable 0.30.2 (bottled), HEAD
Installed from homebrew.

I've just encountered the same problem.
The trick with adding a list.html file to the _default folder temporary solved the issue.

Is this a design purpose( not allow only have baseof.html in _default) or a bug?

Yes, that is by design.


LSTM:Deserialize failed

Ubuntu

Tesseract Version: 5.0 Alpha
Commit Number:
Platform: Ubuntu 18.04

Current Behavior:
When trying to finetune the training I am using
lstmeval --model ~/tesstutorial/engtrain/eng/eng.traineddata   --eval_listfile ~/tesstutorial/engeval/eng.training_files.txt --traineddata ~/tesstutorial/engtrain/eng/eng.traineddata
I am getting an error
Loaded 72/72 lines (1-72) of document /home/prashant1/tesstutorial/engeval/eng.Impact_Condensed.exp0.lstmf
Deserialize failed
I tried referring issue #792 but couldn't find helpful.
please let me know what could be the fix.

Does the file exist?

No, just noticed, the file eng.Impact_Condensed.exp0.lstmf doesn't exist. How can I generate the file?

What is the file size? How did you generate it? Did you copy it between different platforms?

the file is auto-generated. I have not copied it. The size is around 403.9 kb.

Please see https://github.com/Shreeshrii/tess4training/blob/master/4-impact_from_full.log for log from a successful run of tesstutorial from a few months ago. If you follow the instructions then there should be no errors.

Old issue, probably a user error.


Runtime config tests

Add tests for Runtime_config (in Genesis_ledger_helper_lib).

for runtime ledgers with no zkApp accounts, make sure omitted account fields are the same as you'd get by running Account.create
if the specified token in the runtime config is not the default, make sure the delegate is None, just as you'd get with Account.create
for ledgers with zkApp accounts, you have to specify all fields, but the verification key may be null; make sure that's same as in Zkapp_account.default

Other changes:

make pk required in accounts in the runtime config
rename state to app_state to match other OCaml code (we're spelling out verification_key, right?)
rename library from coda_runtime_config to mina_runtime_config

Closes #12508.

!ci-build-me

!ci-build-me

!ci-build-me


Fix ctags quoted options in ctags command

This is to fix a bug introduced from #258.

To reproduce the bug, you can set a custom file list command:
let g:gutentags_file_list_command = 'rg --files --color=never'

Gutentags is trying to run this command:
ctags -f tags.temp -L --options=/dev/null tags.files

Which gives us the error:
ctags: cannot open list file "--options=/dev/null"

The right command should be:
ctags -f tags.temp -L tags.files --options=/dev/null

Ah yeah sorry about that. It's getting convoluted, I'm thinking of having Vim generate a temp options file that will contain everything, so we don't need to fight the weird quoting/spacing rules of the shell... anyway in the meantime I re-worked the script a bit, try 37d61302fd21902e6b8d308f28d14a0296a56153 ?

@ludovicchabant wrapping "$CTAGS_EXE" in double quotes also breaks custom executables such as:
let g:gutentags_ctags_executable_ruby = 'ripper-tags --ignore-unsupported-options --recursive'

Does $CTAGS_EXE need to be wrapped in double quotes?

I suffer from the same bug mentioned above, except that for me $CTAGS_OPT_FILE is empty when generating the tags of the project which makes ctags fails (cannot open input file "" : No such file or directory) because we pass "". I tested with master and the problem still exist but this MR fixes the issue.

Ah yeah sorry about that. It's getting convoluted, I'm thinking of having Vim generate a temp options file that will contain everything, so we don't need to fight the weird quoting/spacing rules of the shell... anyway in the meantime I re-worked the script a bit, try 37d6130 ?

Just tested on commit 37d6130, but got the same error as @Kazy.

I tried this MR and it didn't fix the problem with cannot open input file "" for me (I use Universal Ctags). I proposed a different approach in #262 to add options file to argument list conditionally, only when it's non-empty string.

I can't repro that particular bug at head -- if anybody is still seeing it, I'll need some exact repro steps in a new bug report, thanks!


New version: Microeconometrics v0.6.0

Registering package: Microeconometrics
Repository: https://github.com/lbittarello/Microeconometrics.jl
Created by: @lbittarello
Version: v0.6.0
Commit: e01228049dc1944452117a4d3a44a9fa4f118a51
Reviewed by: @lbittarello
Reference: https://github.com/lbittarello/Microeconometrics.jl/commit/e01228049dc1944452117a4d3a44a9fa4f118a51#commitcomment-36535734

@lbittarello Next time, please add the compat entries. I recommend using CompatHelper.jl.


[improve][pip] PIP-369: Flag based selective unload on changing ns-isolation-policy

Discussion thread: #23094

Motivation
In Apache Pulsar 3.x, changing a namespace isolation policy results in unloading all namespace bundles that match the namespace's regular expression provided in the isolation policy.
This can be problematic for cases where the regex matches a large subset of namespaces, such as tenant-x/.*.
One of such case is mentioned on this issue #23092 where policy change resulted in 100+ namespace bundles to get unloaded.
And broker exhausted all the available connections due to too many unload calls happening at once resulting in 5xx response.
Other issues that happens with this approach are huge latency spikes as topics are unavailable until bundles are loaded back, increasing the pending produce calls.
The only benefit this approach serves is ensuring that all the namespaces matching the policy regex will come to correct broker group.
But when namespace bundles are already on the correct broker group (according to the policy), unloading those namespaces doesn't serve any purpose.
This PIP aims to address the need to either prevent unnecessary unloading or provide a more granular approach to determine what should be unloaded.
Some of the cases covered by this PIP are discussed in #23094 by @grssam.

unload nothing as part of the set policy call
unload every matching namespace as part of the policy set call
unload only the changed namespaces (newly added + removed)

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Well written and explained. Thanks.
In the initial review, I only have a few knits about improving some concepts such as the unload enum in the proposal.
I think that putting more effort in the naming of it and the different values could be useful. For example, all should be something like MATCHING and the name of the enum should be more descriptive.

Well written and explained. Thanks.
In the initial review, I only have a few knits about improving some concepts such as the unload enum in the proposal. I think that putting more effort in the naming of it and the different values could be useful. For example, all should be something like MATCHING and the name of the enum should be more descriptive.

Thanks for the feedback. We can certainly name it all_matching . Notice that I am still using snake case to be consistent with some other enums used in the same policy call.
Generally the description of a flag is meant to contain more context. It's very tricky to convey what this param would do without exploding the param length.. How about something like unload-scope does that make more sense at first glance?

Thanks for the feedback. We can certainly name it all_matching . Notice that I am still using snake case to be consistent with some other enums used in the same policy call.
Generally the description of a flag is meant to contain more context. It's very tricky to convey what this param would do without exploding the param length.. How about something like unload-scope does that make more sense at first glance?

+1. Sounds good! UnloadScope would be a great concise name for the enum. Snake case values are fine if that's already the convention.

Thank you everyone for giving the feedback :)
I have addressed the review comments. And adding explicitly that this should get cherry picked in 3.0.x as it provides a way to address the issue mentioned in https://github.com/apache/pulsar/issues/23092.
For changing the definition of all/all_matching and changing the default option to changed, it can be taken in a separate PR that will be present in 4.0+ but not in 3.0.x
I'll start a voting thread.

minor detail: unload_scope (snake case) as the enum name is perhaps against typical conventions. I believe that most enums are CamelCase, so instead of unload_scope, the enum type name should be UnloadScope.


handle null value in language validation because mb_strtolower doesn't accept it

…t accept it

Thank you, this is fixed here https://github.com/rinvex/languages/commit/bec15d407040309e0d836834cfbe60c0471d7e21


feat(index): add support for fuzzy searching and sorting

Adds in support for fuzzy searching and sorting. Also refactors some of the existing styles and adds in additional styles for no matches in sort along with styles for the search and sort themselves.
Changelog
New

Fuzzy matching and sorting abilities for the index

Changed
Removed

cc @aagonzales @jillianhowarth this should add in support for searching by:

name
maintainer
aliases
description

Along with sorts for alphabetical, maintainer, and newest. Newest doesn't really do much at the moment since they're all the same date 😅
Styling fixes should be coming in with another PR from @andreancardona, this is for adding in functionality 👍


Lookup on incomplete partition set in SegmentMetadataQuerySegmentWalker

Description
With CentralizedDatasourceSchema (https://github.com/apache/druid/issues/14989) feature enabled, metadata for appended segments was not being refreshed. This caused numRows to be 0 for the new segments and would probably cause the datasource schema to not include columns from the new segments.
Analysis
The problem turned out in the new QuerySegmentWalker implementation in the Coordinator. It first finds the segment to be queried in the Coordinator timeline. Then it creates a new timeline of the segments present in the timeline.
The problem was that it is looking up complete partition set in the new timeline. Since the appended segments by themselves do not make a complete partition set, no SegmentMetadataQuery were executed.
Fix
The fix is to lookup incomplete partition set in the new timeline. It is consistent with the logic in CachingClusteredClient for querying specific segments (https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java#L429).
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[x] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@abhishekagarwal87 Should this have the bugfix label added?