forc-fmt: Consider parsing with comments

We are facing lots of small issues regarding comment insertion. At the time of https://github.com/FuelLabs/sway/pull/2311 we were still exploring the issue and after maintaining this way of handling comments for couple of months, I think it seems like a better way of handling should be discussed. I am not linking all comment related hot-fix PRs but we had couple of them 😄
Proposal
Let's parse comments and produce a CommentedParseTree just like we are lexing comments (we have CommentedTokenStream vs TokenStream etc). This way re-constructing the comments section would not need:

Search the unformatted code
Search the formatted code

We would be simply formatting comments just like we are formatting other stuff like Tys, exprs etc. I believe this would be a little bit faster and most importantly it could lead to less problems. Currently once we have some edge case stuff happening related to the comments we tend to introduce rather "hacky" solutions as the interaction between formatter and comment handler is not simple enough.
With parsed comments, if we can also collect some sort of context we could still be sure that we are not altering the intentional comment styles (rust classifies comments like this)
Any thoughts on this? cc @FuelLabs/tooling

+1 on this, swayfmt v2 seems mature enough to work well for most cases but it seems like the search-and-insert method is leading to a few weird behavior surrounding formatting with comments. Right now fixing these edge cases are just small changes but this could become hard to maintain over time.

Sounds good to me!
This would also address https://github.com/FuelLabs/sway/issues/2357.
Originally, we avoided trying to produce a Commented alternative to the sway_ast::Module due to the sheer number of places that comments can appear within the AST (between every leaf node!) however as we're discovering, the unstructured alternative leaves a lot of edge cases that are difficult to reliably handle in a non-destructive way.
I just had a chat with @bingcicle and after checking rustfmt again for better ideas, he'll start looking into how feasible this is.
The gist of the idea is to mirror the existing AST of sway_ast under a new commented module and replace each field with a commented alternative along the lines of the following:
pub struct Commented<T> {
    pub node: T,
    pub comments: Vec<Comment>,
}

pub struct Comment {
    pub span: Span,
}

Where comments is a list of comments that occur between this node and the previous node.

With parsed comments, if we can also collect some sort of context we could still be sure that we are not altering the intentional comment styles (rust classifies comments like this)

I think inferring the intended "style" of comments like this can be tricky to do reliably. While that CommentStyle enum looks handy, I'm skeptical that it can reliably describe a lot of cases. E.g. while I was chatting with Bing, I found a few cases where rustfmt automatically deletes comments entirely :sweat_smile:
We might be better off starting by simply collecting comments that precede the node and re-adding them verbatim. If a node has a commented child where the comment style is at all ambiguous, we can avoid formatting the item for now.

Alternative
Thinking on this more, I think there's still a chance we can find a simpler alternative that doesn't require constructing an entire alternative commented AST. I'm imagining something like this:

Before formatting a module begins, construct a CommentMap, i.e. a BTreeMap from spans to comments (I think we already have a type for this somewhere).
Provide a reference to the CommentMap to the Format::format trait method (potentially via the Formatter type).
Provide a CommentMap method that makes it easy to check whether or not a node intersects a comment by checking the node's span against the btreemap.

This approach might be helped by splitting the Format trait into Visitor and Format traits, separating the logic for traversing the nodes from the logic for formatting them, e.g. https://refactoring.guru/design-patterns/visitor/rust/example. This way, before "visiting" a child node, the visitor could check whether or not the child directly follows a comment by checking it's span against the CommentMap, and if so, allow for formatting it as a Commented<ChildNode> rather than a ChildNode.
This might require a less of a significant refactor, but get close to the "structured"-ness of the full commented AST approach? @bingcicle if you're interested in this approach let me know and we can have another chat.

I'm starting to think the alternative approach might be preferred here for now, even though the commented AST approach would probably be a more structurally sound approach. I think the formatter as it is right now is good for most cases, and perhaps what we need to do is to rethink the heuristics when it comes to formatting commenting. The visitor pattern seems like a great idea - it seems to be what rustfmt is doing as well.
With that said, rustfmt seemingly has similar issues with comment formatting in the same way we do now, leading to a recurring issue of the formatter destructively removing comments without warning. In some cases, this destructive manner could severely impact the devEx of the formatter.
One additional thing we should probably consider here is to define clearly what is and what isn't a valid comment. I'm wary of trying to follow in rustfmt's footsteps here. In the rustfmt guide there is a recommendation to "avoid writing comments on the same line as the braces", and the general sense is that rustfmt is flexible about where you can place your comments, and it will do the rest for you. However, I think leaving options open make it much harder to have a good solution for a very minor improvement in user flexibility. This issue comes to mind and @Braqzen also made a good point there - perhaps we should also think about restricting what is valid in the context of comments while tackling this issue. Doing this will probably help with reducing the destructive behavior we're seeing happen in rustfmt while reducing the scope of work here as well, at the cost of slightly less flexibility when it comes to comment syntax.

I'm certainly open to restricting certain kinds of comments if it does indeed simplify our implementation, however this restriction should be imposed during parsing, and not only through forc fmt mysteriously deleting invalid comments.
Perhaps for now we can forge ahead with the "Alternative" visitor approach above and get as far as we can handling as many types of comments as we can. During this, we collect examples of comments that we are unable to support in a practical manner, and we propose to the lang team that we disallow these during parsing?

Yep, agreed that it should be imposed under parsing and not under formatting.

Perhaps for now we can forge ahead with the "Alternative" visitor approach above and get as far as we can handling as many types of comments as we can. During this, we collect examples of comments that we are unable to support in a practical manner, and we propose to the lang team that we disallow these during parsing?

This sounds like a good way to begin!

Provide a CommentMap method that makes it easy to check whether or not a node intersects a comment by checking the node's span against the btreemap

By 'intersect', do you mean any node's span that is in range with a comment's span? How would this play well with for eg. trailing comments that don't intersect?

This way, before "visiting" a child node, the visitor could check whether or not the child directly follows a comment by checking it's span against the CommentMap, and if so, allow for formatting it as a Commented rather than a ChildNode.

If we are incrementally implementing this for each known AST node, it means that parts of comment formatting will still be handled via insertion while we are migrating to a Visitor pattern where we format both the node and the comment in the same pass, correct? In that case, our goal would be to handle whatever comment formatting we can within the initial formatting phase, remove the formatted comments from the CommentMap, then pass it over to handle_comments() to do the remainder. If this is the case, we would also need some ability to 'look back' so we know that there are no other tokens in between the end of a comment span and the start of a node span.
I think the first PR here to make these changes should just be the skeleton for the new pattern, aka introduce an impl FmtVisitor for all nodes, and simply replace all usages of format() with visit(), and within visit() we just call the current implementations - and from there we open new issues to tackle all the missing formatting for the commented versions of the nodes. This would probably help with reviewing big diffs, since we know that there are no logical changes there.

How would this play well with for eg. trailing comments that don't intersect?

I had a similar problem with initial implementation, since we are searching between spans for comments, a comment that is after (or before) all of the nodes in the tree was getting chopped off. I remember working around that by simply inserting two dummy spans one that points to the beginning of the file, and the other pointing to the end of the file.

I had a similar problem with initial implementation, since we are searching between spans for comments, a comment that is after (or before) all of the nodes in the tree was getting chopped off

This was also a problem I found while digging through old rustfmt issues - they also had problems with trying to format comments between rustc AST nodes...

I remember working around that by simply inserting two dummy spans one that points to the beginning of the file, and the other pointing to the end of the file.

This is good to know! Any other gotchas to be aware of here?
So far, this is what I'm doing:

we used to initialize the CommentMap at the comment insertion step. Instead, lets do it right before formatting now, and have the Formatter hold it as a &mut CommentMap
we then begin formatting. However, we do not implement FmtVisitor - I realized that it isn't really a useful abstraction at the moment. Instead I have a helper function that finds the comments within the comment map that are between a given start and end point - this can be between the end of a preceding span and a start of a following span.
we format the node there and then with the comment, and remove the entry from the CommentMap. This mutated CommentMap is later passed to handle_comments() which will format the remaining comments without the already formatted comment. This makes it so we can incrementally introduce the new pattern while still allowing us to use our old way of comment insertion.

A potential downside i'm concerned about here is if we end up with a lot more code, since we're no longer doing everything in handle_comments(), but rather at each impl Format of each node. But I think this might be a clearer way to reason about formatting comments, and we also get access to other properties of Formatter like the indentation when doing it at this stage.

If this would mean we would be looking for bugs in spesific item's formatting function, it is still a big win imho :)

Closing this in favor of #3938


Fix nextJS issue

Motivation
There is an issue with the JS library when the moduleResolution is set to node which happens in NextJS projects.
The issue was raised here: https://github.com/dfinity/verifiable-credentials-sdk/issues/48
Changes

Support importing from

Tests
Tested that dummy-relying-party still builds with the changes.
Todos

[ ] Add entry to changelog (if necessary).

@peterpeterparker what do you think of these changes.
I'm a little bit disappointed I didn't find a better solution...

We might not need it 👉 https://github.com/dfinity/verifiable-credentials-sdk/issues/48#issuecomment-2326881516
Let's see...

We might not need it 👉 #48 (comment)
Let's see...

Good idea! Let's wait!

We ultimately resolved the issue with #56. Therefore I guess we can close this one.


feat: private transaction support [APE-915]

What I did

Added send_private_transaction as an abstract method to ProviderAPI
Added a private bool to transfer and call methods of AccountAPI to test that a "not implemented" error is raised

fixes: https://github.com/ApeWorX/ape/issues/1112
How I did it
Pretty much as described in https://github.com/ApeWorX/ape/issues/1112. Will follow up with a PR on ape-alchemy that actually implements the send_private_transaction abstract method created here.
How to verify it
WIP
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

@deepsp94 any updates here? still working this?

Another useful thing might be adding a field private to ReceiptAPI to show if it was sent privately or not. Could come in useful later (when async) if ReceiptAPI flow might allow cancellation (e.g. receipt.cancel(), which by default submits another self-call transaction at higher gas fees, but here would just call this RPC instead)


selectpicker on select with class w-100 leads to unexpected behavior

calling selectpicker on selects with class w-100 and width not 'auto' or 'fill' leads to unexpected behavior (see screenshot)

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case (you can use our preconfigured Plunker), and report back with:

your link
Bootstrap version
bootstrap-select version
specific browser and OS details.

If you're not using the latest version of bootstrap-select, please try that as well.


[Kraken] Orderbook - checksum does not match

BTC-USD unit test works, as does KrakenOrderBookExample with ETH_USD
but in real multithreaded life:
20:56:14.553[WARN ][nioEv..-3-1][i.b.x.kraken.KrakenStreamingAdapters]ETH/USD checksum does not match, expected<PHONE_NUMBER> but local checksum is<PHONE_NUMBER>
20:56:14.554[WARN ][nioEv..-3-1][i.b.x.k.KrakenStreamingMarketDataService]Resubscribing ETH/USD channel after adapter error Checksum did not match
Any insights: @lukaszaoralek @nielsdraaisma

Maybe you have the same problem like me today, if you want check the PR https://github.com/knowm/XChange/pull/4443
It was a time format conflict between the countries

anyone found something there? also there are some order book updates from kraken where there is no checksum given when they actually say it is given on all updates.


[Android]: theoretical problem in PrepareGrouping()

In PrepareGrouping(), you look for a potentially nested items source (ie. grouping required by the user) by checking whether it has IEnumerable elements. But there is a standard type that's not really a list but is still IEnumerable: string. If the source is a list of strings, it will be mistaken for a nested list. So:
    //Get the groups within the items source.
    var groups = _items.OfType<IEnumerable>().Where(grp => !(grp is string));

New version


Update @asyncapi/react-component to 0.18.2

The package was also renamed from @kyma-project/asyncapi-react to @asyncapi/react-component which dependabot isn't able to handle.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Time's up, let's merge these :p

Time's up, let's merge these :p


⚠ Bofrost.be has degraded performance

In fcb535c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1174 ms

Resolved: Bofrost.be performance has improved in 4b60df5.


Fix bug with increment read window

Issue:
Turns out, if aws_channel_slot_increment_read_window() was called while the "window update task" was running, the "window update task" would not get rescheduled to run again.
I was writing read-window-update tests for the python WebSocket bindings, and the test was failing as the read window approached 0. Here's how it played out:

the WebSocket started with a read window of 500 bytes
a 1000 byte payload (total frame size 1004) was sent to the WebSocket
the HTTP handler sent along the first 500/1004 bytes
the WebSocket processes this, but since the first 4 bytes were frame metadata that it doesn't count against the read window, it increments its read window by 4 bytes
but due to this bug, the "window update task" DOES NOT get rescheduled
and my test would fail because it received 4 less bytes than it expected

Description of changes:
Fix rescheduling logic for "window update task"
Rant about tests:
I lost a few hours trying to add a regression test here in aws-c-io. First, I tried adding to the existing socket_handler_echo_and_backpressure test to reproduce my issue, but it didn't fail! Turns out, the bug can only occur when you have 3+ handlers in the channel. Then I started modifying the read_write_test_handler so that it could serve as a proper "midchannel" handler that buffers up frames if necessary before sending them downstream. Then realized this would be more work complex than making a new type of test-handler that solely functions as a midchannel handler. Then realized at this point we'd be better off adding true integration tests for websocket that exercise the REAL stack of handlers, instead of a bunch of test handlers. Then realized this would take days, and I already had the new python tests I was working on that exercise the real stack of handlers... so yeah. I'll just rely on the tests I'm adding in aws-crt-python for now, but we should probably add integration tests in aws-c-http someday.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

solid name change


Release connection from connection pool following resource operation

iRODS agents cache resource information. If any properties of a resource change or any hierarchies change, the cached information will become stale.
To keep things in sync in the HTTP API, the connection used to change resource information needs to be dropped from the pool.
The connection pool will recreate the connection once requested.

and we still have to somehow communicate to all the others that the resource information they have may now be out of date.   Do we stale ALL of them and they each check a value somewhere before starting a new API call and let go themselves?  Can we get that without a wasted back and forth to the database?

You're right. It's not only the agent which the operation happened on. Crap.
Perhaps, we make the iRODS server re-instantiate the resource manager. That avoids the the reconnect situation, but we still need to tell other agents to do the same.
Which means we need a mechanism to broadcast the change to all sibling agents.
This needs to be handled in the iRODS server.

Yes, the server should remember/have/include a 'stale' flag that is returned on each new API request on existing/all connections... that says... actually, 'drop your brain and try again', or even better... 'here's your new brain, use this'.  saves a back and forth perhaps.

oh, wait... this only has to be stored in the server, and then each Agent can simply check and refresh itself before honoring an API request.
so we store a timestamp in the database... 'resource_information_last_updated' or something... and then each Agent simply takes responsibility for keeping itself up to date.

Or just in shared memory.
oh wait… could have multiple servers…
oh but… they could each have a cron to check the database value and keep their own cached version in shared memory.

Using the database is certainly the easiest way to do it. The downside is that each agent must query the database before executing an API request. That creates unnecessary traffic on the database.
One thing to keep in mind is that this is only an issue if the resources and/or hierarchies are being manipulated in realtime. If admins restrict resource management to off hours, then things aren't as bad. This is an important factor to consider for whatever solution we come up with.

The alternative to Agents polling… is for each to subscribe to something that gets updates.  Can whiteboard it.

Just noting here that the connection pool automatically refreshes connections after N seconds.
The frequency of the refresh, N, can be adjusted via "refresh_timeout_in_seconds" in the configuration file.
While this isn't a perfect solution, admins can at least know that the HTTP API will eventually sync with the catalog.

Client-driven solution implemented here: irods/irods#7288


Still need help... so confusing

Hi again, I'm having a problem on how to promote within the Member ladder and also randomly add users to the Guild ladder. My players rank up within the Member ladder, there's no problems there. The problem comes when they choose their guild and are added into a guild ladder, it removes them completely from the ranking ladder (Member). Here is my perms: https://pastebin.com/PP16mVe8
I am not sure on the commands to use when doing this correctly. When they complete quests for ranks, I use the command /pex promote  Member and it works fine. But later on they have to choose a guild and I use the command: /pex group (Fire,Water,Earth, or Air) user add  which then takes them out of the Member ladder completely. Can you tell me what I'm doing wrong please, this is still terribly confusing. They do not ever rank up within the guild ladder (I even tried not having a ladder for guilds)

pex user Stormbow group add Air would be the correct command to add Stormbow to the Air Guild.
Then you'd want to try— because I've never had users in more than one ladder myself —the /pex promote <user> [ladder] command to move them up the ladder and /pex demote <user> [ladder] to move them down the ladder.

On an unrelated sidenote, you don't need to color and underline every letter of the Owner prefix.  prefix: '&d&lO&d&lw&d&ln&d&le&d&lr ' is literally just prefix: '&d&lOwner '.
Also, many special characters in prefixes— like line 152's ♔ —are not visible in-game.  (It comes up as a question mark in Notepad, {Notepad++}, and on my test server.)  If you've discovered how to display these in-game, I'd love to hear it so I can share the info with others.

Thank you I will try that command instead. Its only the Member ladder that gets promoted/demoted. As for the Master rank, yea it comes up in chat just like that with the icon, I literally just copy and pasted from a site with the icon:

Interesting.  I wonder why that works for you and not for me...  (I copied and pasted too.)  Which site did you use?

I just tried the hearts on this page too and it worked: https://tutorialzine.com/2014/12/you-dont-need-icons-here-are-100-unicode-symbols-that-you-can-use
I coped the icon, not the code :) I use venturechat now but it even worked when I was using townychat and essentials chat, too.

Ahhhh!  I forgot to change File > Encoding > UTF-8 when I reinstalled Notepad++ on this computer.
Thanks for the page link, that helped.  :-)

Let me know how the commands work out.  :-)

Yes thank you so much it works perfectly now :D

You're welcome. :-)  Have fun!


Godot 2.1.2: Project Settings Crash

Operating system or device - Godot version:
Ubuntu, Godot 2.1.2
Issue description:

Trying to check around in the Project Settings window usually freezes and crashes Godot. Some times it's the first check, some times the second or maybe even third.
Steps to reproduce:
Check around in Project Settings.
Link to minimal example project:
:

Happening here too.
Operating system or device - Godot version:
OS X 10.11.6, Godot 2.1.2
Steps to reproduce:
Create new project, add one node and save scene.  Then click on project settings and check  any of the following boxes under "Display" for an instant crash:

fullscreen
allow_hidpi

Happens every time I open the project.  In addition, this has happened under other projects, and with other project settings options.  I went ahead and made a repository for the simple 1 node project below.
Link to minimal example project:
https://github.com/cbscribe/godot_crash

Can confirm for fullscreen with debug_release builds both with using_clang=no and using_clang=yes on Godot 2.1.2 and Godot 2.1/HEAD.
Can't confirm with target=debug + using_clang=no, or with 3.0/HEAD.

Fixed by #8240.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #252.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #252

Since this passes, it shows that the problem only really happens when ArcticDB is being built against libcxx>=18.

Looking at the logs, libcxx 17.0.6 is picked for run/test environments it seems, so we cannot really tell if the error is due to building against >=18. We need to have a way to use this version at runtime.

_test_env has libcxx 18.1.8, right?

No, it unfortunately uses libcxx 17.0.6-heb59cac_3.
See those logs for instance.

Yes it does for osx_64 (see those logs but not for all, e.g. not for osx_arm64 for some reasons (see those other logs)

This PR was used for debugging but is not used anymore.


Use preact Fragment to render multiple children

When wrap = true, preact-markup only renders the first child. Using Fragments, preact-markup can render all the children without wrapping them with a <div />.

@developit Would you mind merging this?

@developit @marvinhagemeister what do you think of this PR?

Good idea! I left a suggestion to simplify things.
I'm actually thinking we can just drop the wrap parameter now, since this component can just always return the array of elements.

Thanks @developit! I applied your suggestion.
For backwards compatibility, maybe we can keep the wrap parameter?

@hpneo yeah that works for me!


Exception handler for ContextAwareExecutor

Handling exceptions in asynchronous operations is tricky. Exceptions occur in a background task and the exceptions aren't propagated to the caller thread. We have to manually add try-catch block to each task.
It is not easy to implement an exception handler for executors because executors perform various asynchronous tasks in many situations.
In contrast, a context-aware executor is designed to operate only in a specific scope by wrapping an existing executor. If an exception handler is registered when creating a context-aware executor, appropriate exception handling logic can be applied for the purpose of the scope.
ctx.makeContextAware(executor, cause -> closeWhenListenerThrows(cause))

https://github.com/line/armeria/pull/4851#discussion_r1196075070

@ikhoon Hi! I am currently working on this issue. I have been brainstorming the design by adding exception handlers to the several makeContextAware functions one by one.
I have a concern about makeContextAware(ExecutorService). We cannot know in advance which functions will be submitted to the ExecutorService instance. Therefore, I believe the type of the exception handler also has to be Function<Throwable, Object>. This, in my opinion, limits the use of the type system and can easily lead to runtime errors.
So, for the case of makeContextAware(ExecutorService), instead of separately passing an exception handler as a parameter, I considered adding submit(Callable<T>, Function<Throwable, T>) to ContextAwareExecutorService interface. I would like to know your thoughts on this situation.


[ASSERTION/TLUL] TlOutKnown assertion failure

Hi Michael,
I remembered there is a previous issue reported for invalid read latches, so you added a PR #1230 for it. With the new implementation, I found the assertion fail in HMAC's tlul_adapter_sram model.
Hmac's tlul_adapter_sram is a WO memory(ish) device. In DV's tl_error test, we will read the memory, and check if d_error is asserted. However, this sequence hits an assertion error.
After discussing with Weicai, we think it might related to unmapping address. Seems like the address we drive h'1fc7,592d does not map to any valid memory address.
. Assertion ASSERT_KNOWN(TlOutKnown_A,    tl_o,    clk_i, !rst_ni). In this invalid read case, tl_o.d_data is XX. I am not sure in this case, should RTL still return XX and just relax this assertion?
Waveform path:
/edascratch/chencindy-opentitan/scratch/hmac/hmac_stress_all_with_rand_reset/01.13.20_09.57.56
verdi -ssr Verdi.ses
Thanks,
Cindy

Hm, this might be an implicit X due to an invalid (i.e. non-existent) address. RTL should return a known value in any case (preferrably 0).
Can you add rspfifo_rvalid to the qualifier expression on this line?
https://github.com/lowRISC/opentitan/blob/0c8583fc335b4b46aa13abbe62f2930d693bbab9/hw/ip/tlul/rtl/tlul_adapter_sram.sv#L129

Thanks Michael, it passed after adding the rspfifo_rvalid


ValueError: offset must be non-negative and no greater than buffer length (76025948)

I use world model and vocab, it throws out this error when training. But if I use world model and raven vocab, it works. Anyone fixed it?

solved, in the src/dataset.py line 33 self.data_size = len(self.data._bin_buffer) // 2 should be modified by self.data_size = len(self.data._bin_buffer) // np.dtype(self.data._index.dtype).itemsize, Peng Bo's code is also like data._index.dtype.itemsize

aboved


please kill this PR: error rebasing

please disregard this PR.
I accidentally created a PR against Master, and I destroyed my fork before deleting the PR.

wrong branch


[Draft] Fused multiply add ops

This PR adds kernels for component-wise fused multiply-add and fused multiply-subtract and implements automatic fusion of multiplications and additions into FMAs.
It's motivated by the observation of large numbers of unfused component-wise multiply and add kernels in the profile of BERT. I estimate that it reduces the number of kernel launches per training step of BERT by as much as 20% (from ~5300 to ~4200) and increases the training speed by ~5%.

Can anyone check out the XLA test failure? I'm not sure what it needs. Do I need to implement FMA for XLA also?
The complaint is:

tensorflow.python.framework.errors_impl.NotFoundError: No registered '_FusedMulAdd' OpKernel for 'XLA_GPU' devices compatible with node node ndtri/add_14 (defined at home/jenkins/workspace/develop-upstream-unit-tests/tensorflow-upstream-unit-tests-rocm-xla/bazel-ci_build-cache/.cache/bazel/_bazel_jenkins/eab0d61a99b6696edb3d2aff87b585e8/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/tests/stateless_random_ops_test_gpu.runfiles/org_tensorflow/tensorflow/compiler/tests/stateless_random_ops_test.py:132)
.  Registered:  device='CPU'; T in [DT_DOUBLE]
device='CPU'; T in [DT_FLOAT]
device='CPU'; T in [DT_HALF]
device='GPU'; T in [DT_DOUBLE]
device='GPU'; T in [DT_FLOAT]
device='GPU'; T in [DT_HALF]

@whchung Has given me some pointers (in disabling the pass). I'll give a shot in fixing XLA side.

@ekuznetsov139 , while I was revisiting Eigen code, it occured to me that we can try implementing the Compute routine for the various _FusedMul* ops here using Eigen. It will make the implementation significantly more compact if we can get it to work, and we will get the packet based optimizations for free.
Let me understand your implementation first, and I will attempt to do an Eigen implementation for it tomorrow.  Do you recommend any tests I can use for quick sanity checking?
thanks

Wouldn't implementing them in Eigen essentially defeat the purpose of fusing (since you'd be launching multiple GPU kernels inside each FMA call)?

think it should be possible to have the Eigen implementation launch just one kernel per op. otherwise I agree there is no point to it.


Remember to fill out the requirements.txt file with whatever dependencies that you are using

requirements not working when installing using it. for pyhton3.10.11 i get:


make token parameter type unknown

Description
The jwtDecode function will throw an InvalidTokenError when the token
parameter is not a string, so since this is part of the api, the type of
the token should not be limited to just string.
Let me know if this seems reasonable or if there is anything I should change
Checklist

[ ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[ ] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not master

Thanks for this Pull Request! This library only decodes JSON Web Tokens serialized as a string, setting this to unknown would enlarge the surface for errors.


can javy used to compile a nodejs project ?

i think this line is the reason throw error,
const mathjs = require('mathjs');
so the javy can not used to compile a nodejs project ?
the errors is below:
thread 'main' panicked at 'called Result::unwrap() on an Err value: Uncaught ReferenceError: 'require' is not defined
at  (function.mjs:1)
', crates/core/src/main.rs:40:5
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: failed to run main module index.wasm
Caused by:
0: failed to invoke command default
1: error while executing at wasm backtrace:
0: 0x112d1 - !<wasm function 278>
1: 0x10a99 - !<wasm function 277>
2: 0x109e5 - !<wasm function 276>
3: 0x35c4 - !<wasm function 74>
4: 0x131b - !<wasm function 39>
5: 0x23d6 - !<wasm function 55>
6: 0xab5b - !<wasm function 168>
7: 0xa9ca - !<wasm function 167>
8: 0xb557a - !<wasm function 1125>
2: wasm trap: wasm unreachable instruction executed

No, Javy cannot be used to compile a NodeJS project.

What you may be able to do if you want to use require to work with JS packages, is use a transpiler like rollup.js to convert your code and its dependencies to a single JS file and then execute that with Javy. However, NodeJS APIs that are outside of what QuickJS provides are not supported.

What you may be able to do if you want to use require to work with JS packages, is use a transpiler like rollup.js to convert your code and its dependencies to a single JS file and then execute that with Javy. However, NodeJS APIs that are outside of what QuickJS provides are not supported.

thanks, it's very helpful.


Support \displaystyle

I would like to display integrals and products in display mode since they look much better when the limits are included. I don't think that this feature is currently available. One way would be supporting the \displaystyle command (https://www.overleaf.com/learn/latex/display_style_in_math_mode). This is how the package TikzPictures does it.

tp = TikzPicture(L"""
\node[align=center, below, white] {
$ \displaystyle F(\omega) = \int_{-\infty}^{\infty} \! f(t)e^{-i \omega t} \, \mathrm{d}t $\\\\
$ F(\omega) = \displaystyle\int_{-\infty}^{\infty} \! f(t)\cos(\omega t) \mathrm{d}t - i \int_{-\infty}^{\infty} \! f(t)\sin(\omega t) \mathrm{d}t $\\\\
};
""", options="transform shape, scale=2.5", preamble="")

LaTeXStrings does not do any formatting.  The only thing it does is allow you to easily construct strings containing LaTeX equations without have to do lots of escapes.
The formatting is the responsibility of whatever code you pass a LaTeXString to — e.g. if you pass it to matplotlib or display it in Jupyter it is rendered by MathJax.


{Desktopvirtualization}: Migrate desktopvirtualization to aaz

aaz model: https://github.com/Azure/aaz/pull/419
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

az desktopvirtualization
General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Desktopvirtualization

GitGuardian Security Checks cannot pass because the old file contains token, modified but still unable to pass.

/azp run


npm install never finishes on run

Hey there.  I've tried a bunch of different Meteor app repos and I keep getting stopped up the same point in the run process.

Getting https://github.com/meteor/simple-todos.git...
Cloning into '/usr/src/app'...
Switching to branch/tag master...
Already on 'master'
Your branch is up-to-date with 'origin/master'.
/var/www/bundle/programs/server /usr/src/app
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data

><EMAIL_ADDRESS>install /var/www/bundle/programs/server/node_modules/fibers
> node ./build.js

`linux-x64-v8-3.14` exists; testing
Binary is fine; exiting
<EMAIL_ADDRESS>node_modules/progress

<EMAIL_ADDRESS>node_modules/ip

<EMAIL_ADDRESS>node_modules/underscore

<EMAIL_ADDRESS>node_modules/semver

<EMAIL_ADDRESS>node_modules/chalk
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/source-map-support
└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/fibers
/usr/src/app

For what it's worth, I can successfully deploy with Arunoda's MeteorD with the exact same repo and database url, so it's definitely not the code or the env vars.  His package gets the job done, but I'd really prefer the convenience of deploying from a github repo instead of having to Dockerize every app I want to deploy.
Any suggestions on what I may be missing here?  Thanks in advance!

That log looks completely normal.  It should be running at that point.  You are missing the PORT environment variable, though.  It will default to port 80, but you don't have a port forward statement in your docker run either.  That means it should be running on port 80 of the container, but in the default docker environment, that won't do you much good.
Try adding a -p 80:80 switch to your docker run statement.

Oops.  It's always the obvious thing starring you in the face!  :)
Thanks for the quick reply.


Create FeatureWindow entity and make it public -based on main branch

Description
Create FeatureWindow entity and make it public -based on main branch
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-ml


Cannot install pip packages - permision denied

Hi there
I'm using the docker image quay.io/geodocker/jupyter-geopyspark:blog (also contains the fantastic geonotebook), and I'm trying to install with !pip install geopandas. Unfortunately I'm getting an error:
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3.4/site-packages/descartes-1.1.0.dist-info'

Attempting to sudo gives /usr/bin/sh: sudo: command not found
Is there anyway I can install additional pip packages (preferably through a notebook so I get the correct python environment)?
Many thanks for these fantastic docker containers!

If the container is running and you type docker ps -a, you should see something like the following
...
25a9c0ebf3ef        quay.io/geodocker/jupyter-geopyspark:blog   "/scripts/jupyterhub…"   About a minute ago   Up About a minute   8000/tcp            sharp_kapitsa
...

which gives you the name and id of the running container.
Given that information, you can shell into the container by typing something like docker exec -it -u root 25a9c0ebf3ef bash.
You can then type pip3 install geopandas to attempt to install the package as root.  This will not work, though, because gcc is not installed in the container.  You may be able to make some progress by installing gcc (using yum) from within the root shell.  I am afraid that I do not know how easy or difficult that will be.
(I have confirmed that pip3 installing packages from the shell does make them available in notebooks.)

Thanks very much for your help @jamesmcclain!
For reference, my steps to install geopandas for use with the notebooks:
$ docker exec -it -u root 25a9c0ebf3ef bash
[root@25a9c0ebf3ef tmp]# yum install gcc python34-devel.x86_64 gcc-c++
[root@25a9c0ebf3ef tmp]# pip3 install geopandas

Perhaps we can add these to the DockerFile (I can create a pull request if you like)? geopandas is quite a commonly used geospatial library for (small) vector data.

@asmith26  :+1: for adding geopandas to the Dockerfile. A PR would be appreciated!

Done: https://github.com/geodocker/geodocker-jupyter-geopyspark/pull/97
Please feel free to amend to follow any standards that you follow - I am a bit confused because the Dockerfile says to pull from itself at tag base-7 (and I don't see any other "yum install" within this Dockerfile, thus I was wondering if I should have put it into the base image it pulls from).


DNS resolution fails after changing hostname

Summary
Trying to change the hostname of the nodes
What Should Happen Instead?
After changing the hostname DNS service did not work.
Reproduction Steps
Steps to reproduce on Debian-11:
1. Install Master
    1. Enable dns, ingress, storage, helm3
    2. wait for addons and corresponding pods to be in a running state.
    3. microk8s stop
    4. hostnamectl set-hostname "mksmaster"
    5. Add hostname entries in /etc/hosts, confirm properly set.
    6.  microk8s start
2. Follow similar steps while setting other nodes(4-node cluster)
3. Now create the cluster(4-node cluster)
4. Exec to ingress controller on all the nodes individually
    1. microk8s kubectl exec -it nginx-ingress-microk8s-controller-wf9rx -n ingress -- /bin/bash
6.  check nslookup to  nameserver inside /etc/resolve.conf "nslookup <IP_ADDRESS>":
    1. It only works on the ingress controller scheduled on the master node. But it does not work on the other  Nginx-ingress-microk8s-controller scheduled on other nodes.

As a result deployed APP is failing

Introspection Report
yes
Can you suggest a fix?
Expecting a solution
Are you interested in contributing with a fix?
no

@ktsakalozos - please help me on the same.

Checked routes, the routes added for the vxlan.calico interfaces of the other nodes are failing. i.e. ping to it's IP address fails. This could be the real root cause of the issue.
root@przmk8snodemaster:~# route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
<IP_ADDRESS>         <IP_ADDRESS>      <IP_ADDRESS>         UG    0      0        0 eth0
<IP_ADDRESS>     <IP_ADDRESS>     <IP_ADDRESS> UG    0      0        0 vxlan.calico
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS> U     0      0        0 *
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS> UH    0      0        0 cali2af005c6b1d
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS> UH    0      0        0 cali1cc062d3237
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS> UH    0      0        0 cali287d0d7cba1
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth0
<IP_ADDRESS>      <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 docker0
root@przmk8snodemaster:~# ping <IP_ADDRESS>
ping: socket: Address family not supported by protocol
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.040 ms

--- <IP_ADDRESS> ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 0.040/0.040/0.040/0.000 ms

root@przmk8snodemaster:~# ping <IP_ADDRESS>
ping: socket: Address family not supported by protocol
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.

--- <IP_ADDRESS> ping statistics ---
4 packets transmitted, 0 received, 100% packet loss, time 3110ms

Hi @vishwanathjadhav, did you try to disable and re-enable the dns and ingress addons (killing the respective pods would also work I suspect). Could you also try to restart every node just to make sure there are no leftover iptable rules?

@ktsakalozos - Yes, I have tried restarting, noded, and pods (from Kube-system and ingress). When restarting DNS it shows the following errors in /var/log/syslog
Jul 10 14:57:21 microk8s microk8s.daemon-kubelite[44298]: E0710 14:57:21.080269   44298 kubelet.go:2419] "Error getting node" err="node \"przmksmaster\" not found"
Jul 10 14:57:21 microk8s microk8s.daemon-kubelite[44298]: E0710 14:57:21.180822   44298 kubelet.go:2419] "Error getting node" err="node \"przmksmaster\" not found"

@ktsakalozos - Any updates for me?

@ktsakalozos - Did you get a chance to look into it? Am I missing something during the process which is preventing me from changing the hostname?

@vishwanathjadhav, in general changing the hostname of a node in a k8s cluster is not supported. Nodes register with their hostnames (see microk8s kubectl get no), so if you change their hostnames is not recommended. One question is why do you want to change the hostname of the node after installing MicroK8s? Why don't you change the hostname and then install MicroK8s?

@ktsakalozos - Hey, Thanks for the update. Sorry for the delayed response. My requirement is to create multiple instances of pre-cooked/contextualized machines (VMC/AWS instances). So that I don't have to install it every time. There are few more setup steps because I am doing it in an on-Prem offline environment. Here I have to keep all the required container images pre-imported before starting add-ons. So it is becoming too much work to create multiple instances(multinode setups).


How to get data from response with errors?

Environment

Operating System: Linux
Node Version:     v16.11.0
Nuxt Version:     3.0.0
Nitro Version:    1.0.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
Build Modules:    -

Description
I use nuxt-graphql-client which based on this library and GraphQL Code Generator
I try to get data from response with errors. I can't extract "data" from the response when there are more "errors" next to it, I have already tried 2 libraries nuxt-graphql-client and @nuxt/apollo, both have the same situation.
nuxt-graphql-client

@nuxtjs/apollo

Expected behaviour
In addition to the error, I also expect to receive the data that is in the response

I found that by default, Apollo Client throws away partial data - link. In order to get these partial results I should define an error policy for my operation. But how is this done specifically in this library?

Oh, I found how to setup it in your library - https://github.com/jasonkuhrt/graphql-request#errorpolicy


bedpesort doesn't work correctly with filename provided on command line

$ svtools bedpesort /tmp/dlarson_testing/converted.bedpe
/tmp/dlarson_testing/miniconda/envs/svtools0.2.0/lib/python2.7/site-packages/setuptools-21.2.1-py2.7.egg/pkg_resources/__init__.py:1268: UserWarning: /gscuser/dlarson/.python-eggs is writable by group/others and vulnerable to attack when used with get_resource_filename. Consider a more secure location (set with .set_extraction_path or the PYTHON_EGG_CACHE environment variable).
Running bedpesort with options: /gscuser/dlarson/.python-eggs/svtools-0.2.0-py2.7.egg-tmp/svtools/bin/bedpesort /tmp/dlarson_testing/converted.bedpe
awk: cannot open /tmp/dlarson_testing/converted.bedpe (Value too large for defined data type)
bedpesort exited with code 2

Should also check on vcfsort...

Fix in #153


Where should I get the xyz_crop directory of lmo datasets?

Hi, I'm new in the research of pose estimation, and I downloaded the lmo dataset from huggingface (followed the guidence of official BOP website).
The wired thing is, when I tried to train a model on that dataset, I found no xyz_crop directory under lmo's trainset, while the python script ./core/gdrn_modeling/datasets/lm_pbr.py does define a  path parameter pointed to that directory (line 354). The training script I used is as below:
$ ./core/gdrn_modeling/train_gdrn.sh configs/gdrn/lmoPbrSO/convnext_AugCosyAAEGray_DMask_amodalClipBox_lmo/duck.py 0

By the way, It seems that the class LM_PBR_Dataset DO NOT take measures to handle the lmo case, as the PNG format of lmo's rgb images is not considered (line 113). Is it a BUG or did I run the script by a wrong way?

I also notice that issue #123 has the same problem, but didn't give a solution.

I also notice that issue #123 has the same problem, but didn't give a solution.

我在#23我找到类似问题的解决方案。
但是训练gdrn的时候，可以像训练yolox一样注释掉assert assert osp.exists(xyz_path)吗？

Yes. You can directly remove assert osp.exists(xyz_path). It is not necessary with online rendering.

LMO整个是一个测试集，没有真实图片作为训练，可以在lm_pbr/lmo_pbr上训练，再在LMO上做evaluation。

好的好的，谢谢回复😭


MemoryDiagnoser Benchmarks

Add MemoryDiagnoser to sampling tests using BenchmarkDotNet

.NET Core version almost done https://github.com/dotnet/BenchmarkDotNet/issues/308#issuecomment-263229643

Added to benchmark dotnet config as part of https://github.com/alhardy/AppMetrics/issues/22


allow large sidecut radius by avoiding integer overflow

Hi!
This pull request is for a change which allows sidecut radius of greater than 46000mm. This is useful for skis with a small amount of sidecut (e.g. cross-country skis).
The current code contains lines which limit the sidecut radius to 46000 or less. This is because larger integer values overflow when squared, producing a negative argument for a Math.sqrt() call, resulting in NaN. I refactored the square root calculation to avoid this integer overflow. I was thus able to remove the 46000 upper limit on the radius value.
I'm not a Java coder so can't be sure there aren't other consequences of this change, but it all seem to work as intended for larger sidecut radius values.
Thanks!

hey @mholling thanks so much for joining in the fun!  I'll let @danielgraf  and @mikemag communicate with you about this and merging it into any future release etc ok they are busy guys but I am sure will be greatful for your input. We've just started to get traction on some teamwork and skills to enhance both SnoCAD-X and MonkeyCAM and its going to make both packages so much more useful. I'm especialyl fired up as my CNC is only weeks away from delivery now and it will be great to use these excellent apps in anger!!! cheers Rich

Hey @splitn2. No rush on this pull request as I have it working for my purposes. Just thought it might be useful to have in the official version somewhere down the line. I've just started lurking on SkiBuilders recently, and hoping to try building a ski once I have all the tools together. snoCAD-x looks like a great little tool.

@mholling have you got a cnc or access to one? If you have you might want to look at MonkeyCAM its a big head start for speeding up production. cheers

I wish! :) Not even got a table saw yet...

hey thanks for your contribution anyway. If it interests you please feel free to take an active part in this project. One objective we are working towards is a scenario where we are piping the configuration generated in SnoCAD-X into MonkeyCAM , so design visualisation to GCODE and cutting in a very short time. Added to that both SnoCAD-X and MonkeyCAM enhancements to spice up the options available for tip tail shapes etc...... So in the end this will be the small cnc enabled ski/board builders software of choice!
Something I am mulling over is a basic design for a cnc built from scraps that will do an accurate job of core and base cutting jobs outputted by this software. Using pipe or C-section channel for "linear rail" with belt drive for example, all out of recycled and/or cheap chinese components..... So we can get the small guys cnc enabled and more productive without breaking the bank.....


What's the plan for supporting Storage Tables in the new Azure Storage Java Client Library (v11)?

Looking at this seems that there's no support for Storage Tables in the new client library. Is there any plans to support Tables in the the new Storage SDK architecture ?

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

Hi, @mkargar. There is no plans to support Tables in the Storage SDKs. This service has been moved to the CosmosDB, so you will have to check with them about their plans for an SDK.


macvlan: add bclim option

Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip
command does. We still need c/common and podman patches to allow this
option for podman network create.
Also I created a PR[1] upstream in the netlink lib to allow setting
these options directly instead of using the DefaultNla work around as I
do here.
TODO: Add a test but for now this option is not in a released version of
iproute so there is no way to check for it right now.
[1] https://github.com/rust-netlink/netlink-packet-route/pull/32
This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896

@mheon @flouthoc PTAL
Fortunately netlink upstream changes are not required for this feature so I implemented it like this for now. That should help back porting. I tested it on RHEL at it seemed to work correctly.

LGTM

@flouthoc PTAL again


layers: Fix include order in decriptor_sets.h

The vk_loader_platform header must come first, since it fixes the
Windows Winsock.h include order problem. Without this the build
produces a spew of warnings.
PTAL, another build fix.

We should consider adding -DWIN32_LEAN_AND_MEAN to the compiler options or #define WIN32_LEAN_AND_MEAN before any windows.h includes, so that the include order for other headers doesn't matter.

Agreed, I wasn't aware this was a solution. Using that locally for now, someone may want to make a change on the SDK-side.


nameof returns different casing for members than reflection metadata

Deck: https://deck.net/c735b4c6b417f61719c3d78c0f78ad72
Using nameof() seems to return incorrect casing for reflection:
public static bool TestProperty => false;

// ...

type.GetProperty(nameof(TestProperty), BindingFlags.Static)

This returns null, however if you change nameof(TestProperty) to "TestProperty" then everything works fine. The string written for nameof(TestPRoperty) is testProperty but the reflection metadata has PascalCasing.

Hi @DanTup – Seems like this might be solved in master. Can you confirm the following sample is working as expected?
https://dev.deck.net/b44dc3d791a110350a96e3986b55a165

Yep, that looks good to me! :-)

I'll close this issue, but we'll also try to find the issue or pr where this was fixed.

Fixed in #2375.


Does it support Chinese? and How can I develop the model?

Can you give me some suggestions and some tips？
Thanks!
Looking forward to your reply

maybe you just need to replace the pre-trained bert file and the training corpse.

Can you give me some suggestions and some tips？
Thanks!
Looking forward to your reply

I have made this model Chinese supported. Here is my re-implement.

Can you give me some suggestions and some tips？
Thanks!
Looking forward to your reply

I have made this model Chinese supported. Here is my re-implement.

thank you my pal~
a star is not enough for your great job!

Hi, @fresh382227905. To make the model support Chinese, you may need to change the pre-trained BERT and the triple extraction part (due to the different tokenization between English and Chinese) with minor revisions. You can also refer to @longlongman's great work : )


Markdown should support links to sip protocol

We should support the sip protocol markdown such as [call<EMAIL_ADDRESS>Related to https://github.com/Microsoft/BotBuilder/issues/1103

We're restricting the protocol to http or https, but perhaps just open it up to any protocol?

Not any but we should add sip.

Bots may want to deep link into apps, especially on mobile. I think we should open it up to any protocol.

actually it could be a config where the host may specify?

Agree with Eric. This is basic mobile functionality.

Security-wise I think there should at least be a gating mechanism, where as the host of the HTML page, I could say "don't allow ftp links" or some such.

How about an optional link handler to Chat? Defaults to window.open in new tab.


chore: update developer notes and readme

Updates README.md and DEVELOPER_NOTES.md to the following:

Advises using npm run dev-build rather than npm install
Calls out npm run dev-build chromium and npm run dev-build firefox:nightly as all-in-one shortcuts
Updates outdated instructions for manual loading extension in FF and Chromium (and removes old animated gifs as they're outdated and redundant; can update to new gifs if we feel it's necessary)

@lidel -- for your eyes. I think this takes care of all the items we'd discussed, but please amend as desired!


What port is used?

Hello,
what port is used for testing via speedtest-cli?
I am using firewall and if is enabled, speedtest-cli is not working.
If I disable firewall, it starts work again.
So, what port I have to put on whitelist at my firewall settings?
Thank you for reply.

Mostly dst port 8080.

Mostly dst port 8080.

Hello,
thank you for reply, I added port 8080 to whitelist (TCP incoming+outgoing), and working well.
Fixed, thank you!


Unresolved util-testing Dependency

I'm trying to pull the latest phantom library (1.10.1) and I'm getting unresolved dependencies for util-testing. I have added all the required resolvers and end up with unresolved errors.
Here are my two phantom dependency lines:
  "com.websudos" %% "phantom-testkit" % "1.10.1" % "test",
  "com.websudos" %% "phantom-dsl" % "1.10.1"

Here are my resolvers
resolvers ++= Seq(
  "Sonatype repo"                    at "https://oss.sonatype.org/content/groups/scala-tools/",
  "Sonatype releases"                at "https://oss.sonatype.org/content/repositories/releases",
  "Sonatype snapshots"               at "https://oss.sonatype.org/content/repositories/snapshots",
  "Sonatype staging"                 at "http://oss.sonatype.org/content/repositories/staging",
  "Java.net Maven2 Repository"       at "http://download.java.net/maven/2/",
  "Twitter Repository"               at "http://maven.twttr.com",
  "Websudos releases"                at "http://maven.websudos.co.uk/ext-release-local",
  "jcenter"                          at "http://jcenter.bintray.com"
)

Hi @bennythomps ,
You have an outdated resolvers list, I'm assuming you are upgrading perhaps. Look here, our Maven repo is now on Bintray.
Remove "Websudos releases" or replace it's value with our Bintray repo and everything should be fine.
Regards.

:+1: thanks!


Added some functions

create_ap can now redirect all web requests to the access point (useful when running a web server) and pass debug argument -d or -dd to hostapd. It also doesn't act funny with applications running it that redirect stdout (delayed output).
enjoy :)

Thanks!

What I forgot, you might add a check if stdbuf is installed, and if it is not, run hostapd without it because it is not really needed, just makes output not buggy when output is redirected


issue with wait command

Hi there!
The itself is nice and sophisticated, tho i have a little issue.
I'd like to use the wait command (island is a working instance):
arkmanager wait --online @island

For this there's a little wait, then i get a message and the full help info for the tool:

arkmanager v1.6: no command specified
Usage: arkmanager [Commands]
Commands can be followed by one or more @instance arguments
The special '@all' instance selects all instances
Commands may also be followed by zero or more --options

Thanks,
Tamas

wait was expected to be used with another command.  ee7b81d11a90e472a186b223ac7ee54241f69a93 fixes this so it will exit without printing a help message if there are no other commands.

Ah, i see.
Thank you for the fast reponse, i'm gonna close the ticket :)


docs link broken

the URL (click here) in  https://microsoft.github.io/FASTER/docs/build-and-test/ here has broken.
I think it should be https://microsoft.github.io/FASTER/docs/fasterkv-cpp/

Fixed, thanks.


Implement better OVS flow rule versioning

Add a rule stamp and check that stamp on startup to see if we have
to recreate the OVS bridge and flow rules.  Should fix ambiguity
in the existing rule checking.

@danwinship @pravisankar @knobunc

@danwinship PTAL

LGTM

@danwinship @pravisankar PTAL

@pravisankar @danwinship PTAL

LGTM

@dcbw What does the 2nd byte of the actions=note: do? Was it going to log the history of the openflow rule changes.
But during my testing, I found the value of it will always be "01". It will be overwrote each time when SDN initialized.
The 1st byte will be changed when I changed the plugin type every time.
Thought the 2nd byte should increase each time re-setup SDN if it is doing some historical work.

@bmeng the second byte indicates the version of the code that was used to create those rules. When you restart OpenShift, it checks if the single-vs-multi-tenant byte and the version byte are both what it was expecting. If they are, then it doesn't need to modify the rules, because they're already correct. But if either of them is wrong, it deletes all the existing rules and creates new ones. (So, the next time we change the rules in controller.go, we'll change VERSION to "02", and then if you update the binary on your already-deployed system and restart, it will see that your rules there were made with an old version, and so it will recreate them.)

LGTM

BTW, should we use the mask feature of the cookie to make it easy to find all of our rules?  e.g. pick something like 0xbb000000/0xff000000 so that we can easily and cleanly nuke all of our flow rules with:
ovs-ofctl -OOpenFlow13 dump-flows br0 cookie=0xbb000000/0xff000000
Or perhaps, to be good ovs doobies, make that cookie value settable in the config?  And provide a utility that reads the config and cleans out the flows?  And if we were feeling clever, we could look in table 253 for the new rule this adds to identify us, and make sure that it is not present with another cookie prefix (implying that a cookie had been changed in the conf).

All of the rules (on br0) are our rules.

Ok, so the ones without the cookie of 0x0 are auto-learned?

There are no auto-learned rules in the current ruleset.
Originally our rules used cookies, but most of them don't any more, because:
ovs-ofctl -O OpenFlow13 del-flows br0 "ip,nw_dst=${ipaddr}"

is simpler than doing
ovs-ofctl -O OpenFlow13 del-flows br0 "cookie=0x${cookie}/0xffffffff"

because you don't have to encode the IP address into hex first.
For historical reasons ("no one ever bothered to change it"), the per-node subnet routing rules still use a cookie though.

Got it.  Thanks!


Remove the doxygen generated files

I (Amir) don't think we need to actually store them in the repos) as they are taking a lot of space. This is stored permanently in docs/html.

I've removed the html folder which seems like was created 3 years ago and accidentally merged.
I've also updated the .gitignore file so it doesn't check merged again.
The html files are generated when doxygen command is run and then published to gh_pages.


Ensure that changes to input .proto files are watched

Without this, the build system won't notice that a .proto file has been
changed and will not invoke the builder again.
Tested this in the example/ directory with dart run build_runner watch
and making changes to the proto/my_proto.proto file and watching the
resulting .dart files be regenerated.
Fixes #1

I updated this with another commit that ensures that output files will be recreated if they are deleted.

Closing this and recreating it as I need to make the pull request on a branch so I can continue main development.


grafana zabbix plugin not found on data source

I installed the zabbix plugin
but I had a problem in the data source
zabbix is not displayed
what to do?

same with me
zabbix version Zabbix 5.4.9. docker compose
grafana v8.4.0-47001pre
and plugin 4.2.0

try to enable unsigned plugins in grafana.ini
add this in grafana.ini and restart grafana
;allow_loading_unsigned_plugins = alexanderzobnin-zabbix-app, alexanderzobnin-zabbix-datasource, alexanderzobnin-zabbix-triggers-panel

hi,
thanks for yor feedback
I applied but the problem still persists

hi, thanks for yor feedback I applied but the problem still persists

emmm....meybe you should enable this zabbix plugins? i don't sure

this is my Zabbix Plugins

 it is already activated

when you installed this plugin,are you restart grafana service?if not ,try restart grafana service

I restarted
always the same problem

Hi @aref87
i've change docker-compose file zabbix installer from alpine to ubuntu and its now working
here is file that i used now
https://github.com/zabbix/zabbix-docker/blob/5.4/docker-compose_v3_ubuntu_pgsql_latest.yaml

I've the same problem, but all resolution posted here does not resolve it

Anything interesting in grafana logs?

I have the same problem
I use grafana v8.4.1 and install zabbix 4.2.5
but when I go to the data source menu, I don't find Zabbix

Hi! Please, take a look at the Grafana logs and post errors here.

I have same issue. Plugin is enabled but I cant choose Zabbix datasource. In logs I see following message:
t=2022-07-15T15:06:35+0000 lvl=eror msg="Failed to load plugin" logger=plugins error="plugin \"alexanderzobnin-zabbix-datasource\" is unsigned" pluginPath=/var/lib/grafana/plugins/alexanderzobnin-zabbix-app/datasource-zabbix

On plugins list I see that plugin is signed 😳

Same Problem
Plugin available and enabled and signed

but not listed in datasources:
next config not affects:
allow_loading_unsigned_plugins = alexanderzobnin-zabbix-app, alexanderzobnin-zabbix-datasource, alexanderzobnin-zabbix-triggers-panel
log:
WARN [11-22|09:11:56] Skipping loading plugin due to problem with signature logger=plugins.signature.validation pluginId=alexanderzobnin-zabbix-datasource status=unsigned
ERROR[11-22|09:11:56] Plugin validation failed                 logger=plugins.validation pluginId=alexanderzobnin-zabbix-datasource error="plugin 'alexanderzobnin-zabbix-datasource' has no signature"
WARN [11-22|09:11:56] Skipping loading plugin due to problem with signature logger=plugins.signature.validation pluginId=alexanderzobnin-zabbix-triggers-panel status=unsigned
ERROR[11-22|09:11:56] Plugin validation failed                 logger=plugins.validation pluginId=alexanderzobnin-zabbix-triggers-panel error="plugin 'alexanderzobnin-zabbix-triggers-panel' has no signature"


Use ManuallyDrop instead of mem::forget

With field retagging in Stacked Borrows, self is invalidated by the move into mem::forget. Using ManuallyDrop does not cause UB.

Looks like it needs a rustfmt, then will merge


Not converting any files?

Running this converter doesn't convert any model/texture files in my resource pack. I think it's because of these double slashes? I'm running on Mac which uses forward slashes and it looks like the backslashes were meant for Windows. Perhaps use File.separator instead? https://github.com/HypixelDev/ResourcePackConverter/blob/7057a784032b78b9e0046cf75d3ea2ae29672511/src/main/java/net/hypixel/resourcepack/impl/NameConverter.java#L23

Pushed changes to convert them to file separator, https://github.com/HypixelDev/ResourcePackConverter/releases/latest


Feedback Checklist

[x] .DS_Store and .ipynb_checkpoints should not be committed.
[x] The email under "enforcement" should be tied to the team
[x] Raw and processed/intermediate data are mixed in the data directory (they should be in subfolders, or at least clearly labelled).
[x] Did not render report to PDF or HTML.
[x] versions are missing from environment files(s) for some R or Python packages
[x] Does not clearly report the major findings.
[x] Does not discuss importance and limitations of findings.
[x] Does not explain why this problem is important or interesting.
[x] Did not reference the data set when referring to it.
[x] Important methodology descriptions missing (e.g., did not explain in narrative what metric was being used for model parameter optimization).
[x] Some key references are missing.
[x] Many software or packages versions are not pinned in the environment specification file(s).
[ ] The platform key and value is missing from the  docker-compose.yml file, causing issues when running on different chip architectures.
[ ] Latest tag was used for docker. This is not ideal because if the user has latest locally, but there is a newer version on the container registry, then Docker will not pull it.
[x] Committing unnecessary files.
[x] Some branch names are not meaningful (they should reflect the work being done on the branch).
[x] GitHub issues were used somewhat for project communication.
[x] error occurred when render to html and pdf
[ ] create a visualization for this that shows the pairwise correlation between the features and the targets. this can be done by importing altair_ally and using the aly.corr() method.
[ ] Baseline model for comparison
[x] Spelling/Grammatical Errors in report
[x] Importance of the Research Question
[x] Limitations
[x] The report does not include explicit guidelines for contributors or instructions for seeking support.
[x] In the Summary section, some conclusions about the performance of the final model could have been included
[ ] When creating the Ridge regression model, could have added a step to do a grid search to tune the hyperparameter.

Included evaluation of model performance. Will make sure the branch name from now on is informative.

I already fixed the parts relating to Docker in my last commit 👍

Added new EDA, Dummy baseline, optimized model.
Note that I used RidgeCV in place or Ridge because RidgeCV  has intrinsic optimization techniques using Cross-validation. Interestingly, the optimized RidgeCV chose the same hyperparameters as our original Ridge model, so our original model with default values was already optimized well.

I reviewed the report again and made a few changes. I think it looks and sounds good. I will  submit if everyone is satisfied.

I'm good to submit, thank you.


LiveGrid needs to accept a title kwarg

Expected Behavior

We should be able to provide a title of a plot generated by LiveGrid`.
Current Behavior

Not currently possible without a bulky workaround.
Context

Requested by @andrewmkiss at SRX.
Your Environment

xf05id1-ws2 at NSLS-II SRX. See https://github.com/NSLS-II-SRX/profile_collection/pull/11 for details.

I think so.

Reviewers: @mrakitin @callumforrester

For scanspec I treated the title as an override


Gold rework

To do:
Reduce all elites cost to 50
Reduce all gols mines by half
Reduce all cp income
Edit the name of all cp to reflect the new goms change
Change the creep gold

Remaining to do: Creep gold change and name of control points

@YakaryBovine i will need your help to make those last 2 things happen. I looked at the cp config and i dont know how i will pull it off.
There is also the problem that a TON of quest have cps in their objectives. Which includes their full name: Ashenvale_15_gold
So if we change the name via code, will it update the constant??? I might have no choice to edit all of them in game, il wait for you to read this.

@YakaryBovine Yup I can sort those two things out.
Yes we will have to manually update all of the changed Constants references.

I have split out those requirements into my own ticket: https://github.com/AzerothWarsLR/WarcraftLegacies/issues/2168


Update dependencies

This is a regular update of our dependencies.

We have a warning about a medium-severity vulnerability in an indirect dependency of pkg. This PR does not fix it, because pkg and its dependencies have not updated yet. I don't believe this could affect quicktype in production.


I can't debug Dart program , but I can run it without debugging

Issue Type: Bug
Connecting to VM Service at http://<IP_ADDRESS>:38739/SnorJxJUdlg=/
Unable to start debugging: Error: Unexpected server response: 200Exited (sigint)
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:26:56.255Z)
OS version: Linux x64 5.10.42-1-MANJARO
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz (4 x 2881)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 1

Memory (System)
7.62GB (0.33GB free)

Process Argv
--no-sandbox --unity-launch ~/Desktop/myDartCode/secondDartCode --crash-reporter-id 07061f5d-2260-4f60-817d-613219042a38

Screen Reader
no

VM
0%

DESKTOP_SESSION
xfce

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
xfce

XDG_SESSION_TYPE
x11

Extensions (3)

Extension
Author (truncated)
Version

dart-code
Dar
3.23.1

flutter
Dar
3.23.0

MagicPython
mag
1.1.0

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehov:30309549
vscod805cf:30301675
vscextlang:30322306
binariesv615:30325510
vsccppwt:30329788
aatestflight:30331711

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!

thanks for your response


Misleading guidance on install page.

Describe the bug
The install instructions say to run pytest cvxpy/tests to test the installation, both via pip and conda. But does this actually work? It doesn't work on my machine. This seems like something that would only work if you installed from source.
I would suggest we drop the instructions for testing.
To Reproduce
Try pytest cvxpy/tests
Expected behavior
The tests should be run.
Output
N/A
Version

OS: Mac 11.6
CVXPY Version: 1.1.17

Additional context
Another issue is that for some installations pytest is not recognized as a command and python -m pytest must be used instead.

It should be possible to do something like pytest --pyargs cvxpy without relying on the exact repo layout

@h-vetinari Thanks for the tip, that does work and is better than pointing to the exact package location when installed via pip!


fix: Missing Dispose call on local IDisposable

:tada: This PR is included in version 2.3.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VRG: Unprotect deleted PVCs

Unprotect a PVC if the following conditions are satisfied:

PVC matches VRG's Spec.PVCSelector
VRG's Spec.ReplicationState is primary
PVC's ObjectMeta.DeletionTimestamp is non-zero

PVC unprotection steps:

Delete its PersistentVolume and PersistentVolumeClaim object replicas from the stores specified in VRG's Spec.S3Profiles
Delete its VolumeReplication object
Change PV's ReclaimPolicy to Delete if volumereplicationgroups.ramendr.openshift.io/vr-retained annotation present
Remove volumereplicationgroups.ramendr.openshift.io/pvc-protection finalizer from PVC
Remove its protectedPVC from VRG's status

In addition to the above, test the following:

Deleting PV object replica named with common prefix of another, e.g., a is deleted but aa remains

Closes #697 from VRG perspective

I'm updating this PR to support PVC replica deletion and intend to mark it reviewable when it's ready.

Patch now removes VRG protectedPVC status for deleted PVCs if VRG spec.replicationState is primary.

@hatfieldbrian request the scope of this PR be reduced to the sync case and that even VolRep not be handled. This enables (hopefully) quicker review to address the merge as required.

As the DRPC end of orchestration to distinguish between primary to secondary moves racing with application deletes of PVCs is not handled yet, we may also need a vrg only mode switch for this in the ramen config to enable the feature.

@hatfieldbrian request the scope of this PR be reduced to the sync case and that even VolRep not be handled. This enables (hopefully) quicker review to address the merge as required.

@ShyamsundarR The patch leverages the existing PVC unprotect routine used by VRG delete: reconcileVRsForDeletion which is common to Sync and VolRep.  It seems it would be more risk to change it.  I intend to use the config switch from #1116 for this deleted case and also require async be nil for both.  It will reduce testing but not changed lines.

Merged via #1116


Migrate to Swift 4.2 and replace Unbox/Wrap with Codable

This change makes Marathon use Codable instead of Unbox and Wrap, which are now dropped as dependencies. At the same time the project is also updated to Swift 4.2. This is a backward compatible change.

🎉


When Piped fails to perform a process defined in manifest, I want to see it from web ui.

For example, if you specify a non-existent GitHub url or branch in manifest, there is currently no way to see it from the web ui.
What would you like to be added:

Add piped warning status
Add piped error log on web ui.

Why is this needed:

Done by introduce Invalid Config status to the PipeCD web console


Ian Campbell: Watch marketingvent.com

Ian Campbell requests the watch of the watch_keyword marketingvent\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

marketingvent\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


METRON-1087: Adjust license headers to be comments instead of Javadoc

Contributor Comments
This does three things:

Changes Javadoc to just plain comment.
Fixes headers that have been affected by formatting (get rid of paragraph tags, weird formatting, and deleted spaces, etc.)
Adds a newline after the license, before the package statement.

Even though this affects a (very) large number of files, I left it as one PR.  This is mostly because even though there's many changes, the vast, vast majority are changing /** to /* and adding a newlines.  Only a couple dozen files actually have fixes beyond that.  If this is too large, too tedious, or GitHub does weird crap, let me know and I can split this up.  It was just easier when making the change to just find/replace and validate correctness afterwards.
Note that the newline in 3 is to meet the Google Java Style Guide.  This is not handled by the IDE formatter (at least in IntelliJ), unfortunately.
A source file consists of, in order:

1. License or copyright information, if present
2. Package statement
3. Import statements
4. Exactly one top-level class
Exactly one blank line separates each section that is present.

Validation is just opening a file and ensuring that autoformat doesn't change the license header.
~I still need to spin up full dev as a precaution, but given that it's all comments and whitespace, I'm expecting no issues.~
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have ]you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && build_utils/verify_licenses.sh

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

+1 per inspection, once merge conflicts are resolved. I didn't pour over each file, but I did at least scan every single change and it looks good. Clicking the "load diff" option repeatedly was very much like an episode of the Twilight Zone. :)
In the process of getting IntelliJ's code formatting to work properly, I actually went through some of this already and am thankful for the effort here! I had to disable Javadoc formatting because it was determined to format everything, including the license headers. There simply is no way to keep javadoc formatting without munging the license headers in IntelliJ AFAICT. I had experimented with a similar change and found this change from javadoc to code comment format to work well. First concern I had was whether there was any requirement around the header being a javadoc vs non-javadoc style comment. I wasn't able to find any such requirement per http://www.apache.org/legal/src-headers.html. I believe the text lines and spacing are the only things that will trip up the Rat plugin.
Another nice side effect of this work is that I think I can setup a proper license header template in IntelliJ again without worrying about the unwanted javadoc formatting. Cheers.

@mmiklavc Updated, if you want to take another glance. I updated all new files to be comments. There is one thing that looks like a change, but is just an upstream change from a merge conflict resolution (I left a comment on it).

Kicking Travis.  If it fails again, I'll look into it, but it's not like I did anything complicated in the merge.

This Travis error with metron-alerts and nodejs is clearly not because of your changes.

@mmiklavc I'd need to merge in master, but there's a question I raised on the lists about just pairing a license fix ticket + a refactor ticket on a module by module basis.  I think that'd be easier than going through with this, and then managing things anyway.
Either way, if we stick with this, @mattf-horton requested that the easily automated changes be split from manual changes to make this more easily digestable.

Closing per a dev thread discussion


Nix flake enablement for gardenctl-v2

What this PR does / why we need it:
We want to enable gardenctl for the nix community.
# with Nix (macOS, Linux, and Windows)
nix run github:gardener/gardenctl-v2 -- version

# development version
nix profile install github:gardener/gardenctl-v2

gardenctl --help

Would it be possible to also add an overlay to the flake?

Give me some time to check the pro & cons. I first need the maintainers to merge this PR (but they insist that the vendorhash has to be automated as well ...)

add gardenlogin to the inputs of this flake

Will check as well. I currently like that this dependency is not made implicit (meaning, the user has to explicitly flake download each tool).

When trying out this flake I additionally encountered the following error on shell startup:

If you setup nix properly, the installShellCompletion of the derivation automagically includes the source <(tool-of-choice completion $SHELL), and those dotfiles/directories are made read-only. I think you have to seek out how to run your environment side by side with nix, the issue is that you are trying to overwrite nix.

I 100% agree that the vendorHash should be updated automatically (at the very least CI should check if the flake can still build)... Otherwise, it's pretty much useless 🙃
@vasu1124

If you setup nix properly, the installShellCompletion of the derivation automagically includes the source <(tool-of-choice completion $SHELL), and those dotfiles/directories are made read-only. I think you have to seek out how to run your environment side by side with nix, the issue is that you are trying to overwrite nix.

I'm aware that most tools (installed with nix) are "installing" the completion scripts into a location I can use by adding it to $fpath (which I already do). However, the source <(gardenctl rc zsh) call in my .zshrc (documented here) is additionally used to create aliases and "start" the gardenctl environment.
I could specify everything on my own, instead of using source <(gardenctl rc zsh), but IMO the script ideally shouldn't create & save the completion scripts on every shell startup / call of the script.


Test for RT #126270

Please remove the CATCH block when RT #126270 is corrected.

Going to simplify test and resubmit pull request


Static files don't loading within CSP-restrictions

Content-Security-Policy is gonna be spreading across the web. So it is matters to make Allure work with it.
Allure doesn't work with the following headers:
Content-Security-Policy:sandbox; default-src 'none'; img-src 'self'; style-src 'self’;

Ok, reproduced it on my local server. It seems that our report can't work in the so strict environment.
I will look for more suitable compromise.

Now I have come up with the conclusion that we can't make Allure work in such restrictions. That CSP setting disallows executing any javascript on the page. Obviously, our report can't work with JS.
I made Allure work with a bit relaxed version of config:
'Content-Security-Policy', "sandbox allow-scripts allow-same-origin; default-src 'self'; script-src 'self' 'unsafe-inline'; img-src 'self'; style-src 'self';"

It allows us to use all static resources from the same domain and fetch data via AJAX as well.
//cc @georgecrawford

@just-boris Do you know anything about how the CSP settings are configured in Jenkins? According to our systems engineer, we're using a very vanilla installation of Jenkins, with nothing special security-wise. Does Allure definitely work for you in a similar setup?
If you know how I can change the headers, please let me know.

Found the following commit: https://github.com/jenkinsci/jenkins/commit/d3fb2c09f29007dce84a213ae8323df1105dcc30
Looks like latest Jenkins version has this feature. I will try to figure out

Interesting - I'll also look into how we might configure this better.

Ref: https://wiki.jenkins-ci.org/display/JENKINS/Configuring+Content+Security+Policy

OK, so using this command in the Script Console:
System.setProperty(hudson.model.DirectoryBrowserSupport.class.getName() + ".CSP", "script-src 'unsafe-inline' 'self';")

... I have it almost working. But there's something very strange that I don't understand - lots of UI elements seem corrupted, and there are thousands of JS console errors (Error: [$interpolate:interr] )

both expand and collapse showing:

"Attachment not found", but it's there!

broken error:

Yes, that weird things are caused by some inline styles. I prepared a PR to fix it. https://github.com/allure-framework/allure-core/pull/716
For now, you can work around by adding style-src 'self’ 'unsafe-inline'

I see the same problems with script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline';.

I downloaded the allure xml files, and it all looks perfect when I run allure generate allure-results/ && allure report open with CLI version 1.4.19. So it's definitely a Jenkins/CSP issue.

:( Ok, then you can shut down the CSP at all, by setting it to "" (empty string). I will come up with a better solution at the next week.

Yep, it's fine when I do that. I'll keep on trying other combinations tool.

Good news: I have it working now with just: default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';

Updated our Jenkins docs. http://wiki.qatools.ru/display/AL/Allure+Jenkins+Plugin
We consider that this setting would be the best solution for the issue.

thanks @georgecrawford for the report and help

For those of you having issues with this, I had to set BOTH Jenkins and Hudson properties for it to work, just run these in the /script window of your Jenkins server:
System.setProperty("hudson.model.DirectoryBrowserSupport.CSP", "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';")
System.setProperty("jenkins.model.DirectoryBrowserSupport.CSP", "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';")

thanks @SpyderWeiss , your solutions works :+1:

Hi all, where can i find: /script window of the Jenkins server?

@akiikius https:///script OR Manage Jenkins >> Script Console

When I run Jenkins container, I get an error: Error: Could not find or load main class self
Run command:
docker run --name jenkins -p 8080:8080 -p 50000:50000 --env JAVA_OPTS="-Dhudson.model.DirectoryBrowserSupport.CSP=default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';" --env JAVA_OPTS="-Djenkins.model.DirectoryBrowserSupport.CSP=default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';" jenkins

@adv-tsk You need to escape property. Currently, expression parsed as following
-Dhudson.model.DirectoryBrowserSupport.CSP=default-src

The rest of expression will be passed as a main class name.

Thanks @just-boris, it works!)

I am still having issues with accessing reports in Chrome.
I did set the properties as per @SpyderWeiss 's comments. That fixed the issue for firefox only! I am a chrome lover and so is my whole team so we need it working on Google Chrome, any suggestions/solutions?

+1 to brpIHDUN. This trick not worked in chrome.

+1 same issue in Chrome

Hello, guys!
Could you tell more details about the current issue? Maybe we have got some regression here. A screenshot of console with errors would be so helpful there

Allright,
tried to add these lines in jenkins console via Firefox ( I did it in Chrome previously) - and it worked. So it's either Chrome or one need to add the lines twice in a row in order to make it applied:
System.setProperty("jenkins.model.DirectoryBrowserSupport.CSP", "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';")
System.setProperty("hudson.model.DirectoryBrowserSupport.CSP", "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline';")

For the very first time i added that links i had an empty "Result", now it answered me with some extra lines.
Sorry for this kind of panic.


error="bignum too big to convert into `unsigned long long'"

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.
fluentd 0.14.21
Linux
I am having an issue where data is being sent to FluentD that throws an error and the system is unrecoverable and logs no longer flow until I stop and restart the service again. I am unsure what specific data message is causing the issue and also why a message would cause the system to no longer respond to future messages and simply fail. I would think that it would error on just that one message but continue to process future ones?
The error I eventually receive is:
2017-10-09 14:13:57 +0000 [warn]: #0 fluent/event_router.rb:87:emit: suppressed same stacktrace
fluentd-nxlog_1   | 2017-10-09 14:13:57 +0000 [warn]: #0 fluent/log.rb:336:warn: emit transaction failed: error_class=RangeError error="bignum too big to convert into `unsigned long long'" tag="nxlog"
fluentd-nxlog_1   |   2017-10-09 14:13:57 +0000 [warn]: #0 fluent/event_router.rb:87:emit: suppressed same stacktrace
fluentd-nxlog_1   | 2017-10-09 14:13:57 +0000 [error]: #0 fluent/log.rb:356:error: unexpected error on reading data host="x.x.x.x" port=60051 error_class=RangeError error="bignum too big to convert into `unsigned long long'"

This is the Fluentd Config I have:
<system>
  log_level error
</system>

####################
###### SOURCES #####
####################

<source>
        @type tcp
        format json
        port 5140
        tag nxlog
</source>

#####################
##### MANIPULATE ####
#####################

#### Add Server Received Time to Records
#<filter nxlog>
#       @type record_modifier
#       <record>
#               FluentDReceived ${Time.at(time).to_s}
#       </record>
#</filter>

######################################
##### Beat Processing ################
######################################

<match nxlog>
        @type rewrite_tag_filter
        rewriterule1 NXLogFileType ^dhcp$ nxlog.tagged.dhcp
        rewriterule2 NXLogFileType ^nps$ nxlog.tagged.nps
        rewriterule3 NXLogFileType ^dns$ nxlog.tagged.dns
        rewriterule4 NXLogFileType ^wineventlog$ nxlog.tagged.wineventlog
        rewriterule5 NXLogFileType ^iis$ nxlog.tagged.iis
        rewriterule6 NXLogFileType ^nxlog$ nxlog.tagged.nxlog
        rewriterule7 NXLogFileType ^fluent$ nxlog.tagged.fluent
        rewriterule8 NXLogFileType ^sysmon$ nxlog.tagged.sysmon
        rewriterule9 NXLogFileType .+ nxlog.tagged.unmatched
</match>

######################
##### OUTPUT #########
######################

<match nxlog.tagged.**>
        @type copy
        <store>
                @type azure-loganalytics
                customer_id XXXX
                shared_key XXXX
                log_type NXLogDNS
                add_time_field true
                time_field_name LogSentTime
                time_format %s
                localtime true
                add_tag_field true
                tag_field_name nxlogDNS
        </store>
        <store>
                @type stdout
        </store>
</match>

Any help you can provide in troubleshooting this and making it so that one bad message doesn't cause the whole system to fail would be appreciated. Perhaps there is a way to just ignore the one bad message?

I wrote a patch for avoiding too many open files error.
https://github.com/fluent/fluentd/pull/1742
With this patch, file name and position value are logged.
So we can see what is the cause of bignum too big to convert into unsigned long long'`

I tested with simple tcp script and it worked after error happens.
require 'socket'
require 'json'

log = '{"k":"v"}'
TCPSocket.open('localhost', 5140) do |s|
  s.write(log + "\n")
end

So if sigdump result doesn't show stuck behaviour, nxlog output may keep wrong conneciton.
And to rescue invalid record, <label @ERROR> may help.

it's a stale issue. I'm closing. if you have any problem, updating fluentd might help it.


replace master branch by default branch in documentation

:pushpin: Commit 4bf26954ccd71d7a06676bf20e2eacfe0691219e has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 4bf26954ccd71d7a06676bf20e2eacfe0691219e with merge 33d343b800a631c01f973c66ca39e6b544cbaad8...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 33d343b800a631c01f973c66ca39e6b544cbaad8 to master...


Convert to English

The readme in the example is not in English.
Should the main Readme be english as well? https://github.com/easemob/UIKit_Chatroom_flutter/blob/main/README.md

@tadaspetra
https://github.com/easemob/UIKit_Chatroom_flutter/blob/main/README_en.md
thx.

How about making the default README in the root english as well?


Python Azure SDK authentication docs incorrect?

Hi,
In the example from here:
from azure.mgmt.compute import ComputeManagementClient
from azure.common.credentials import ServicePrincipalCredentials

# Retrieve credentials from secure storage. Never hard-code credentials into code.

credentials = ServicePrincipalCredentials(tenant = <tenant_id>,
    client_id = <client_id>, secret = <secret>)

client = ComputeManagementClient(credentials, <subscription_id>)

It looks like ServicePrincipalCredentials should be a class in azure.common.credentials, but the documentation doesn't reflect that.
I can see the ServicePrincipalCredentials class in msrestazure, as documented here  .  Was this class recently moved?
Thanks

@nickmhankins Yes, there were some changes and the docs are a little out of date. I'm working on an update but no definite ETA yet.

@nickmhankins Apologies for my slow response--I've been working through the details amidst other priorities. :)
The code in the article is actually correct, and in some ways so is the documentation. That is, you do use from azure.common.credentials import ServicePrincipalCredentials for the ServicePrincipalCredentials class, which is why the code is correct. That said, the object itself does ultimately come from the msrestazure module, so the reference docs https://docs.microsoft.com/en-us/python/api/msrestazure/msrestazure.azure_active_directory.serviceprincipalcredentials?view=azure-python, are also correct in their own way.
But I agree it's confusing, because the ServicePrincipalCredentials class (and its peers) should be documented under azure.common.credentials. I'll file that issue separately with the SDK docs repo, and will reference this issue, which I'll now close. Thanks for pointing this out.
Ref doc issue: https://github.com/MicrosoftDocs/azure-docs-sdk-python/issues/632