as

Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

Travis tests have failed
Hey @vaibhav9619,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build

     python -m pytest

============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-3.6.4, py-1.5.2, pluggy-0.6.0
rootdir: /home/travis/build/coala/corobo, inifile: setup.cfg
plugins: requests-mock-1.5.2, xdist-1.22.5, travis-fold-1.3.0, timeout-1.3.1, reqs-0.0.7, reorder-0.1.1, profiling-1.3.0, mock-1.10.0, instafail-0.3.0, forked-0.2, error-for-skips-1.0.0, env-0.6.2, cov-2.5.1
collected 39 items

tests/answer_test.py .                                                   [  2%]
tests/ban_test.py ..                                                     [  7%]
tests/coala_lowercase_c_test.py ..                                       [ 12%]
tests/coatils_test.py ...........                                        [ 41%]
tests/deprecate_bot_prefixes_test.py .                                   [ 43%]
tests/explain_test.py .                                                  [ 46%]
tests/ghetto_test.py .                                                   [ 48%]
tests/git_stats_test.py .                                                [ 51%]
tests/labhub_test.py .........                                           [ 74%]
tests/lmgtfy_test.py .                                                   [ 76%]
tests/nevermind_test.py .                                                [ 79%]
tests/pitchfork_test.py .                                                [ 82%]
tests/ship_it_test.py .                                                  [ 84%]
tests/spam_test.py ....                                                  [ 94%]
tests/the_rules_test.py .                                                [ 97%]
tests/wolfram_alpha_test.py .                                            [100%]

travis_fold:start:py-5599.cov.0
----------- coverage: platform linux, python 3.6.3-final-0 -----------
Name                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------
plugins/__init__.py                     0      0   100%
plugins/answer.py                      25      0   100%
plugins/ban.py                         37      0   100%
plugins/coala_lowercase_c.py           12      0   100%
plugins/coatils.py                    118      0   100%
plugins/constants.py                    7      0   100%
plugins/deprecate_bot_prefixes.py       6      0   100%
plugins/explain.py                     20      0   100%
plugins/ghetto.py                      10      0   100%
plugins/git_stats.py                   51      0   100%
plugins/labhub.py                     236      0   100%
plugins/lmgtfy.py                       4      0   100%
plugins/nevermind.py                    5      0   100%
plugins/pitchfork.py                   12      0   100%
plugins/searchdocs.py                  16      9    44%   23-34
plugins/searchdocs_test.py              6      6     0%   1-13
plugins/ship_it.py                      7      0   100%
plugins/spam.py                        13      0   100%
plugins/the_rules.py                    5      0   100%
plugins/wolfram_alpha.py               18      0   100%
-----------------------------------------------------------------
TOTAL                                 608     15    98%
travis_fold:end:py-5599.cov.0

FAIL Required test coverage of 100% not reached. Total coverage: 97.53%

=============================== warnings summary ===============================
<undetermined location>
  Module already imported so cannot be rewritten: errbot.backends.test

tests/labhub_test.py::TestBot
  cannot collect test class 'TestBot' because it has a __init__ constructor

tests/spam_test.py::TestBot
  cannot collect test class 'TestBot' because it has a __init__ constructor

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 39 passed, 3 warnings in 128.25 seconds ====================

Please read https://github.com/coala/corobo/issues/579#issuecomment-404519354

Created duplicate PRs that are broken.


[SPARK-28881][PYTHON][TESTS][FOLLOW-UP] Use SparkSession(SparkContext(...)) to prevent for Spark conf to affect other tests

What changes were proposed in this pull request?
This PR proposes to match the test with branch-2.4. See https://github.com/apache/spark/pull/25593#discussion_r318109047
Seems using SparkSession.builder with Spark conf possibly affects other tests.
Why are the changes needed?
To match with branch-2.4 and to make easier to backport.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test was fixed.

Merged to master.


panic: pods is forbidden: User "system:serviceaccount:testalex:default" cannot list pods at the cluster scope

hi , i am testing client-go in-cluster-client-configuration ,and my k8s version is v1.11.3, when i pack app file into my image ,and write a deployment of the image,and run it on k8s,i get error,default sa seems no permission to list all pods,and i try create my own sa and connect it to my deployment ,still same error,how to handle this?
docker logs 1d29cf7b4df0
panic: pods is forbidden: User "system:serviceaccount:testalex:default" cannot list pods at the cluster scope
goroutine 1 [running]:
main.main()
/root/go/src/k8s.io/client-go/examples/in-cluster-client-configuration/main.go:44 +0x414

Hi @justlooks, I'm having the same issue with k8s version 1.11.3. Apparently you closed this issue, how did you resolve it? Thanks for your feedback.

I found my answer in this section.


[10.x] Add toSentence method to Str helper

This pull request introduces a new toSentence method to the Str helper class, providing a convenient way to convert an array or a Collection of strings into a human-readable sentence with commas and a customizable conjunction.
The toSentence method is heavily inspired by the Ruby on Rails to_sentence helper.
I have added the method to the Str Helper, but it would also be convenient to move the method to the Array helper.
Examples
// Using an array of strings
$itemsArray = ['apple', 'banana', 'cherry'];
$sentenceFromArray = Str::toSentence($itemsArray);
// Output: "apple, banana, and cherry"

// Using a Laravel Collection
$itemsCollection = collect(['apple', 'banana', 'cherry']);
$sentenceFromCollection = Str::toSentence($itemsCollection);
// Output: "apple, banana, and cherry"

// Using a custom conjunction
$sentenceWithCustomConjunction = Str::toSentence($itemsArray, 'or');
// Output: "apple, banana, or cherry"

Thank you very much!

See above. This is possible using Arr::join or Collection::join. 👍

Actually the Rails version works a bit differently. Regardless, I think it would be a better fit for the Arr or Collection class instead of Str.


Add lombok plugin installation instructions

Thanks for the update, the lack of these instruction caused me a headache.

Got it. Merging.


Context feature 'video_id' is required but could not be found.

Hello @antoine77340
I am trying to run the GRU model in Antoine's code to the new version of the data, and this is the error I get when I run it:
INFO:tensorflow:Error reported to Coordinator: <class 'tensorflow.python.framework.errors_impl.InvalidArgumentError'>, Name: , Context feature 'video_id' is required but could not be found.
The code runs on the older version of the data (version1), but does not run on the newer version.
This is the code that I ran:
python train.py --train_data_pattern=${HOME}/yt8m/v2/frame/train*.tfrecord --model=GruModel --train_dir ~/yt8m/v2/models/frame/GRU_model2 --frame_features=True --feature_names="audio" --feature_sizes="128" --batch_size=128 --base_learning_rate=0.0002 --gru_cells=1200 --learning_rate_decay=0.9 --moe_l2=1e-6 --max_step=300000 --start_new_model
NOTE: I am running it on the audio features only. The GRU model is able to handle this (the code runs on the older data), so this should not be an issue.
I need to run the models on the newer data only. Please suggest changes to the code, so that the model can run.
Thanks in advance.

this happened because they changed the class name . Keep in mind Youtube8M video dataset gathering happened solely on video content and not audio content, until today they don't seem to care about the audio features, it will be probably implemented in the following years

this happened because they changed the class name . Keep in mind Youtube8M video dataset gathering happened solely on video content and not audio content, until today they don't seem to care about the audio features, it will be probably implemented in the following years

The code runs on audio features only, also. I am able to run logistic regression, dbof and lstm on the audio features only dataset.
Similarly, I have been told that the field 'video_id' in the older dataset has been changed to 'id' in the new dataset, which is causing this error. The solution would be to change 'video_id' to 'id' in willow's code. I just don't know where. Do you know how I can do it?

@punitagrawal32
You can try change video_id to id in readers.py


[MacOS] bug: env: node\r: No such file or directory

To reproduce:

Create an empty folder
yarn add svg2sprite-cli
Add script"scripts": {
	"sprite": "svg2sprite"
},

Error: env: node\r: No such file or directory

Problem:

Solution:
Change line endings to LF

Sorry, but I don't fully understand your problem.
How do you run npm script?

yarn add svg2sprite-cli
yarn sprite

Problem in line endings, must be LF instead of CRLF

Still got same error(

same here, change CRLF -> LF line endings in node_modules/svg2sprite-cli/out/cli.js file fixed an issue, but I think that's not a good idea to manually change such thing

yeah, here the same issue on Mac OS

Use svg-sprite
svg-sprite -s --symbol-sprite='sprite.svg' --symbol-dest=public/assets --shape-id-generator='icon-%s' source/icons/*.svg


Karpenter is nominating machine that have not enough memory

Description
Observed Behavior:
The pod is still in Pending state, Karpenter is nominating a mchine that have not enough memory.
Events:
  Type     Reason            Age                   From               Message
  ----     ------            ----                  ----               -------
  Normal   Nominated         37m (x3 over 41m)     karpenter          Pod should schedule on: machine/default-bjb87
  Normal   Nominated         9m51s (x13 over 34m)  karpenter          Pod should schedule on: machine/default-bjb87
  Warning  FailedScheduling  4m41s (x11 over 41m)  default-scheduler  0/4 nodes are available: 4 Insufficient memory. preemption: 0/4 nodes are available: 4 No preemption victims found for incoming pod.
  Normal   Nominated         81s (x4 over 7m41s)   karpenter          Pod should schedule on: machine/default-j956g

vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl get machine
NAME            TYPE         ZONE         NODE                                          READY   AGE
default-7r6vx   c5a.large    eu-west-3c   ip-10-89-176-188.eu-west-3.compute.internal   True    25h
default-j956g   r5a.large    eu-west-3a   ip-10-89-37-49.eu-west-3.compute.internal     True    5d22h
default-x2cgk   r5a.xlarge   eu-west-3b   ip-10-89-110-249.eu-west-3.compute.internal   True    5d22h
metro-lb654     c5a.large    eu-west-3a   ip-10-89-15-199.eu-west-3.compute.internal    True    24h

vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kdpo private-batch-sit-metro-app-nginx-ingress-656c5c8c8c-sms7r -n private-batch-sit-metro
Name:           private-batch-sit-metro-app-nginx-ingress-656c5c8c8c-sms7r
Namespace:      private-batch-sit-metro
Priority:       0
Node:           <none>
Labels:         app=private-batch-sit-metro-app-nginx-ingress
                pod-template-hash=656c5c8c8c
Annotations:    kubernetes.io/psp: eks.privileged
                prometheus.io/port: 9113
                prometheus.io/scheme: http
                prometheus.io/scrape: true
Status:         Pending
IP:
IPs:            <none>
Controlled By:  ReplicaSet/private-batch-sit-metro-app-nginx-ingress-656c5c8c8c
Containers:
  private-batch-sit-metro-app-nginx-ingress:
    Image:<PHONE_NUMBER>76.dkr.ecr.eu-west-3.amazonaws.com/external/docker.io/nginx/nginx-ingress:2.3.0
    Ports:       80/TCP, 443/TCP, 9113/TCP, 8081/TCP
    Host Ports:  0/TCP, 0/TCP, 0/TCP, 0/TCP
    Args:
      -nginx-plus=false
      -nginx-reload-timeout=60000
      -enable-app-protect=false
      -enable-app-protect-dos=false
      -nginx-configmaps=$(POD_NAMESPACE)/private-batch-sit-metro-app-nginx-ingress
      -default-server-tls-secret=private-batch-sit-metro/api-certificate
      -ingress-class=private-batch-sit-metro-services-nginx
      -watch-namespace=private-batch-sit-metro
      -health-status=false
      -health-status-uri=/nginx-health
      -nginx-debug=false
      -v=1
      -nginx-status=true
      -nginx-status-port=8080
      -nginx-status-allow-cidrs=<IP_ADDRESS>
      -report-ingress-status
      -external-service=private-batch-sit-metro-app-nginx-ingress
      -enable-leader-election=true
      -leader-election-lock-name=private-batch-sit-metro-app-nginx-ingress-leader-election
      -wildcard-tls-secret=private-batch-sit-metro/api-certificate
      -enable-prometheus-metrics=true
      -prometheus-metrics-listen-port=9113
      -prometheus-tls-secret=
      -enable-custom-resources=true
      -enable-snippets=false
      -enable-tls-passthrough=false
      -enable-preview-policies=false
      -enable-cert-manager=false
      -enable-oidc=false
      -enable-external-dns=false
      -ready-status=true
      -ready-status-port=8081
      -enable-latency-metrics=false
    Requests:
      cpu:      100m
      memory:   128Mi
    Readiness:  http-get http://:readiness-port/nginx-ready delay=0s timeout=1s period=1s #success=1 #failure=3
    Environment:
      POD_NAMESPACE:  private-batch-sit-metro (v1:metadata.namespace)
      POD_NAME:       private-batch-sit-metro-app-nginx-ingress-656c5c8c8c-sms7r (v1:metadata.name)
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-zbsjd (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  kube-api-access-zbsjd:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              mmb.fr/domain=metro
Tolerations:                 mmb.fr/domain=metro:NoSchedule
                             node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age                    From               Message
  ----     ------            ----                   ----               -------
  Normal   Nominated         3m19s (x60 over 124m)  karpenter          Pod should schedule on: machine/metro-lb654
  Warning  FailedScheduling  3m9s (x293 over 24h)   default-scheduler  0/4 nodes are available: 4 node(s) didn't match Pod's node affinity/selector. preemption: 0/4 nodes are available: 4 Preemption is not helpful for scheduling.
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl get machine
NAME            TYPE        ZONE         NODE                                          READY   AGE
default-7r6vx   c5a.large   eu-west-3c   ip-10-89-176-188.eu-west-3.compute.internal   True    26h
default-fn5pp   m5a.large   eu-west-3a   ip-10-89-6-228.eu-west-3.compute.internal     False   53s
default-svvgn   r5a.large   eu-west-3b   ip-10-89-96-59.eu-west-3.compute.internal     True    2m35s
metro-lb654     c5a.large   eu-west-3a   ip-10-89-15-199.eu-west-3.compute.internal    True    25h
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kgno ip-10-89-15-199.eu-west-3.compute.internal -o yaml
Error from server (NotFound): nodes "ip-10-89-15-199.eu-west-3.compute.internal" not found
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kgno
NAME                                          STATUS   ROLES    AGE     VERSION
ip-10-89-118-244.eu-west-3.compute.internal   Ready    <none>   24h     v1.24.15-eks-a5565ad
ip-10-89-138-225.eu-west-3.compute.internal   Ready    <none>   24h     v1.24.15-eks-a5565ad
ip-10-89-176-188.eu-west-3.compute.internal   Ready    <none>   26h     v1.24.15-eks-a5565ad
ip-10-89-36-219.eu-west-3.compute.internal    Ready    <none>   24h     v1.24.15-eks-a5565ad
ip-10-89-6-228.eu-west-3.compute.internal     Ready    <none>   51s     v1.24.15-eks-a5565ad
ip-10-89-96-59.eu-west-3.compute.internal     Ready    <none>   2m25s   v1.24.15-eks-a5565ad
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl delete machine metro-lb654
machine.karpenter.sh "metro-lb654" deleted
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl get machine
NAME            TYPE        ZONE         NODE                                          READY   AGE
default-7r6vx   c5a.large   eu-west-3c   ip-10-89-176-188.eu-west-3.compute.internal   True    26h
default-fn5pp   m5a.large   eu-west-3a   ip-10-89-6-228.eu-west-3.compute.internal     True    106s
default-svvgn   r5a.large   eu-west-3b   ip-10-89-96-59.eu-west-3.compute.internal     True    3m28s
metro-tkh79     c5a.large   eu-west-3c                                                 False   6s
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl ge^C
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kubectl get machine
NAME            TYPE        ZONE         NODE                                          READY   AGE
default-7r6vx   c5a.large   eu-west-3c   ip-10-89-176-188.eu-west-3.compute.internal   True    26h
default-svvgn   r5a.large   eu-west-3b   ip-10-89-96-59.eu-west-3.compute.internal     True    5m3s
metro-tkh79     c5a.large   eu-west-3c   ip-10-89-163-253.eu-west-3.compute.internal   True    101s
vagrant@vagrant-500001464:~/workspace/socles/infra-kubernetes/karpenter$ kgno ip-10-89-163-253.eu-west-3.compute.internal
NAME                                          STATUS   ROLES    AGE   VERSION
ip-10-89-163-253.eu-west-3.compute.internal   Ready    <none>   86s   v1.24.15-eks-a5565ad
```

The `machine` nominated by Karpenter is link to a node which does not exist any more into the cluster.
If i delete the `machine` manually, Karpenter create a new one and everything go back to normal.
It seems that Karpenter downscaling removed only the node and not the `machine` ?

**Expected Behavior**:

Karpenter should start a new machine or node

**Reproduction Steps** (Please include YAML):

**Versions**:
- Kubernetes Version (`kubectl version`):  1.24

* Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
* Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
* If you are interested in working on this issue or have submitted a pull request, please leave a comment

This bug should be fixed from https://github.com/aws/karpenter-core/pull/449 and will be released early next week.

@bwagner5 it looks like there is still now new release... we are also suffering from this issue.

In 0.30.0 the same problem exists @bwagner5 @jonathan-innis

It looks like this has to do with the vmMemoryOverheadPercent calculation being too small compared to the actual overhead that is taken away from the capacity that EC2 provides us through their API. I did some quick generation of some data and compared the difference between the EC2-provided capacity value and the actual launched capacity value when using AL2: capacity-diff.csv.
One workaround for this is to raise your vmMemoryOverheadPercent that Karpenter uses for pod estimation so that it avoids nominating nodes that don't have enough memory. Realistically, we should have an upstream fix for this issue. There's a PR that's currently in draft (#4252) that's intended to fix this issue by generating out the capacity values rather than taking a heuristic overhead based on a percentage like we are doing now.

It looks like this has to do with the vmMemoryOverheadPercent calculation being too small compared to the actual overhead that is taken away from the capacity that EC2 provides us through their API. I did some quick generation of some data and compared the difference between the EC2-provided capacity value and the actual launched capacity value when using AL2: capacity-diff.csv.
One workaround for this is to raise your vmMemoryOverheadPercent that Karpenter uses for pod estimation so that it avoids nominating nodes that don't have enough memory. Realistically, we should have an upstream fix for this issue. There's a PR that's currently in draft (#4517) that's intended to fix this issue by generating out the capacity values rather than taking a heuristic overhead based on a percentage like we are doing now.

So following this it just seems that if we are using other OS (Bottlerocket) there will be difference in the allocatable of the nodes and the list in #4517 will not apply for Bottlerocket and it will need to be regenerated specifically.
And for a current workaround which we've been struggling with this issue, how much should we increase the vmMemoryOverheadPercent?
Thanks

how much should we increase the vmMemoryOverheadPercent

From the looks of the generated data, it looks like you may need to put it up to 0.11 for the c5d.large.

there will be difference in the allocatable of the nodes

We are planning to gen a list that considers all of our supported OSs and then either:

Differentiates between them by keying on the AMIFamily name or
Takes the maximum between all AMIFamilies and uses that as the overhead for all

Closing in favor of https://github.com/aws/karpenter-provider-aws/issues/5161


The addon doesn't work on twitchtheater.tv

See screenshot. It says it's connected to #embed but it doesn't show the chat. I have twitch.tv open in a second window and it works just fine on that site, but not on twitchtheater.tv

Right, totally missed that iframe has different URL. Here is a fix: https://github.com/tmarenko/twitch_chat_antiban/commit/c4001c1e389c243c65fe5989b365e97df6b5afa5
Please update to latest 2.10 version and check

Ok I'll check, but there's no easy way to test it, so it might be a while before I can report back the results.

Confirmed working for me. Thanks for the fix!


Instructions Do Not Work

Problem/Motivation
Instructions leave out username/password and SSL requirements.
Expected behavior
For the add on to start per instructions.
Actual behavior
Add on fails to start with error: "FATAL: You need to set a username!"
After adding username and password: FATAL: The configured certfile is not found
Steps to reproduce
Install add-on per instructions at: https://community.home-assistant.io/t/community-hass-io-add-on-ide-based-on-cloud9/33810
Which as of Sept 6th currently say:
1.) Add our Hass.io add-ons repository 213 to your Hass.io 56 instance.
Add the following URL: https://github.com/hassio-addons/repository
2.) Install the “IDE” add-on.
3.) Start the “IDE” add-on.
4.) Check the logs of the “IDE” add-on to see if everything went well.
5.) Surf to your Hass.io 56 instance and use port 8321
(e.g. http://hassio.local:8321).

Proposed changes
Update instructions with actual steps needed to install, configure and start Add-on.
 Home Assistant CommunityCommunity Hass.io Add-on: IDE, based on Cloud9This add-on is provided by the Community Hass.io Add-ons project.             About  This add-on will give you a full blown IDE in your Home Assistant web interface and allows you to edit every aspect of your setup with ease. It will provide you with the same experience of editing your configurations as if you’d use a combination of a desktop editor and Samba.  It is based on Cloud9 IDE which is an online integrated development environment. It supports hundreds of programming languages, includ...

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The instructions help you to check the logs to see if the requirements are met.
So I don't see this personally.
Especially: FATAL: The configured certfile is not found. This is outside the scope of the add-on.

Absolutely astounding. Your instructions make it sound like all you have to do is click "Install" and then "Start" and completely leave out the fact that you need to configure a username and password, generate certificates, and don't you think it would be helpful to mention where the certfiles need to be placed?
Your instructions could just as well be written as: "Good luck figuring it out on your own" and that would still be more helpful.

Wow, that comment was absolutely not called for.
Every option of the add-on is documented. Each environment is different as well.
All my add-ons have a sane and secure default, for example, having SSL enabled by default. If you don't have an SSL certificate, just disable SSL (but hey, you should have SSL on your system in the first place, read Home Assistant security documentation and recommendations).
Anyways, feel free to open a PR with "better" instructions or, if you don't like this at all, be sure to uninstall all the community addons since you are going to have a hard time.


meshopt_computeMeshletBounds meshopt_Meshlet parameter probably should be a reference

meshopt_Meshlet is 636 bytes and is being passed by value. I am guessing this wasn't intended.

See https://github.com/zeux/meshoptimizer/pull/17 for some context - it can't be a reference because the interface for meshoptimizer is C, not C++; it was originally a pointer but then I reworked it to be a value since it simplified the calls. Out of curiosity, are you hitting any issues associated with that (warnings, etc.)? I'm up for changing that back to a pointer if there's a good reason, but I wasn't able to measure substantial overhead from the copy.

No issue, just popped up in static analysis is all.


Improve documentation of cast_embed/assoc :with option.

The anonymous function receives the casted struct, not a changeset as documented now.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Extend Propensity Score-based Models to Allow Continuous Treatments

Assume that the probability of treatment follows a normal distribution.
Let µ(i) be the predicted treatment status of each observation and σ be the variance of the prediction residuals.
The propensity score for each observation is then just the PDF of a normal distribution with mean µ(i) and variance σ.

See for example this tutorial.

It would also be good to extend this to a uniform distribution since treatments are usually uniformly assigned. The min and max of the distribution would just be the min and max treatment values in the data and the propensity score would just be the probability of drawing the predicted treatment status from a uniform distribution in the range [min, max].

Actually, the only model that has a propensity score estimator is X-learning and it assumes that there is a binary treatment because it estimates separate models for T = 0 and T = 1 as well as Y | T = 0 and Y | T = 1, so using a continuous treatment wouldn't work here either.


Update README.md

1- Updating badges
2- I changed some little things that I think is better for reading flow
3- I couldn't find how to make image responsive, if you have any suggestion, just let me know and I'll adjust

@MaisaMilena For now, the website is using responsive design (powered by Bootstrap).
You may use Google Developer Tools to have the nice screenshot in iPhone 6/7/8, PC and tablet view.

@calpa I saw on Google Developer Tools content about markup language, not markdown.
I've inspected the page and the screenshot is responsive due to GitHub be responsive, look:

What exactly do I need to do with this screenshot?

It should be captured in blog website instead of readme.md or github screenshot


Option to ignore errors from stderr instead of erroring out

I saw #16 and figured that maybe a configuration setting where you can specify an array of "ignore strings" that a user can supply themselves so that way it's not hard coding something like 'XDebug' or 'Warning:'. I'm running into a similar situation because my execution environment is different than my development environment.
If you're open to the idea but don't want to work on it, I can give it a go.

I actually like the idea of making it entirely userconfigurable instead of hardcoded so I've implemented it. Should be in the next release :)

I can't get over how fast you are! I'm very grateful for your work :)

Just an idea: maybe it could support substrings so one could just specify Warning: and have all errors caught. PHP likes to throw line numbers and absolute paths in some of these errors, so small changes to the file's location or just line number the errors was on will prevent the error from being caught. Since a string is also a substring of itself, the current functionality would just be altered slightly.
For example, this
PHP Warning:  Optional parameter $numFields declared before required parameter $condensedField is implicitly treated as a required parameter

becomes this:
PHP   Optional parameter $numFields declared before required parameter $condensedField is implicitly treated as a required parameter

since there's only a find and replace happening. I believe this can be updated right here (https://github.com/SanderRonde/phpstan-vscode/commit/9a53527fe9d6e4e8b10eab802e49b2955de0a0bf#diff-cb9065f770e90db317f3d505d67589dc098bab45986df0aaaa32d2f192cc558eR185) to ignore the entire error instead of just removing a bit of it. Not sure if the current implementation bases the output on lines, but that would probably be necessary given this case, or you could jerryrig regex to work per line instead.
All of this is assuming this is the path you want to take here - I don't want to impose, this just something I thought would be beneficial for myself and other users of this extension.

Thanks for the suggestion. After thinking about it I've gone for something that is pretty close to this namely regexes. That way you can just do PHP Warning: .* and be done (or in the Xdebug case Xdebug: .*). This way it also doesn't happen that errors are ignored while they shouldn't be (which will get me a lot of "the extension doesn't work" issues). It also allows for more flexibility by just making stuff like the line number a \d.

Great call, just allowing regular expressions really gives as much (or as little) power as anyone could want.


build(typescript): upgrade compiler to v5.x project-wide

Upgrade typescript to 5.3.3
Fix minor compilation issues where problems occurred.

Closes #2700
Depends on #2971
Signed-off-by: Michal Bajer<EMAIL_ADDRESS>Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@outSH FYI:

Upgraded the protoc-gen-ts package to 0.8.7 which supports
typescript 5.x whereas the previously used version only
supported typescript 4.9 or earlier. This was causing the
yarn codegen script to fail (the code generator script)
Update from Peter: Bumped up protoc-gen-ts to latest version.


Best way to use SELECT IN with this library?

Hi,
Best way to use SELECT IN with this library?
I have a vector of string and want a way to use it into "SELECT * FROM table1 WHERE n_type IN (:values)", where ":values" bind is this vector.
There is any way to do it?
If don't have, there is any way that i can prevent injection when create on-hand query?
Thanks

No, there is no way to do that currently; this is only a thin C++ wrapper on top of the SQLite C API.


[Self-hosted Bug]: Not able to get feed from server and pakage display as xml file

Impact
I'm unable to use this version
Describe the bug

not able to get feed

No UI display for packages list

but UI display for NuGet server home page.

Expected Behavior
It's should be working fine and able to get my feed
Screenshots
No response
Additional Context and logs
No response

NuGet.Server does not display packages in a UI. I recommend either using a client to browser your server (like Visual Studio or NuGet Package Explorer), or, using a different NuGet server that does has a UI (see this list of NuGet server implementations).

Still not able to get my feed in visual studio.
On Sat, Mar 5, 2022, 2:18 PM Loïc Sharma @.***> wrote:

NuGet.Server does not display packages in a UI. I recommend either using a
client to browser your server (like Visual Studio or NuGet Package
Explorer https://github.com/NuGetPackageExplorer/NuGetPackageExplorer),
or, using a different NuGet server that does has a UI (see this list of NuGet
server implementations
https://docs.microsoft.com/en-us/nuget/hosting-packages/overview).
—
Reply to this email directly, view it on GitHub
https://github.com/NuGet/NuGetGallery/issues/9034#issuecomment-1059818334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVRTVQELPKOZSWZCZP5F6TU6OXQ5ANCNFSM5P4CEU7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

What problems are you running into?

Closing this issue since we don't have the information needed to diagnose the issue. @cpatel22, feel free to open a new bug with clear repro steps if you are still having trouble.


Documentation

Please provide proper documentation or share a plunker.

Hi, you'll find the docs in readme. It's actually quite easy to get started if you're familiar with angular.


Fix disposal signal routers sprites

About the PR
Fixed bad sprites
Why / Balance
Technical details
Media
https://discord.com/channels/310555209753690112/1323365066564964483

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

fix: Flipped signal disposal routers sprite

good god -550 diff??

good god -550 diff??

there was a shitcode in meta.json

good god -550 diff??

also imagine the impact of each pipe sprite on the graphics card when updating every second on whole station with 300+ pipes


Button to create "New Circuit" in "Insert Subcircuit" Dialogue

Is your feature request related to a problem? Please describe.
If there is only 1 circuit and we press Insert SubCircuit we get a dialogue box. Adding a button to Create a New Circuit can be helpful.
Describe the solution you'd like
A simply button or anchor tag to create a new circuit.
Additional context
Screenshot

Are you working on this? (Yes/No)
No.

I wanted to work on this.

a simple button I think works and it's great because we wanted to minimize the work of user so it's good d

That's great @GAUTAMSAHARAN. Go ahead. Let me know if you face any issues.

Thanks, @sal2701,  I am having an issue which is when i try to make changes in public/src directory js files and restart the server i am not getting it's those changes in my browser, is there some way to rebuild the js file??

Yeah @GAUTAMSAHARAN. CircuitVerse uses Webpack to handle the javascript modules and assets. So the files are generated and are served from the public/packs/ directory. This bundling process takes place once at the beginning, which works great for production, but for local development we need it to reload aka. Hot Reload on our changes. So you need to run bin/webpack-dev-server to enable this Hot Reload.
Thanks for bringing this to our notice, we weren't aware this wasn't documented.

Thanx for your help about webpack and i add a button in dialog box to create new circuit directly and made a Pr. Please review it.

so here we go, I made a new pull request with different branch

Hii,
I am interested in this issue
Is anyone working on this issue?
Please assign me this issue...

Hii, I am interested in this issue Is anyone working on this issue? Please assign me this issue...

No need to be assigned, you can work on this


Register lakhindar.is-cool.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

A terminal styled portfolio website to show-off
Link to Website

https://lakhindarpal.gitlab.io

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

@DEV-DIBSTER Please check and merge it, I've already resolved the issue


refactor: uneeded check mime in ext_in validation

Description
Explain what you have changed, and why.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Have excel was passworded and reopened, will detect mime type application/encrypted.
Ref :

https://www.iana.org/assignments/media-types/media-types.xhtml
https://stackoverflow.com/questions/64802338/what-is-the-mime-type-application-encrypted


Does wasmtime c api currently support compiling to Android/iOS platform?

Wasmtime's platform support is documented here. Android is not tested on CI and guaranteed to work at this time, but Wasmtime may compile for these platforms and we'll take PRs to fix issues if they arise.

As far as I can see the linked page does not mention "Android" anywhere, has it been removed?
I was going to up a new issue, but this one seems appropriate to ask in: Would it be possible for Android C-API binaries to be included in the monthly releases? It looks like there's already some support for building and testing android binaries, so perhaps it's just a matter of including them in the release list?

It's not been removed, Android was never present since it's only ever been best-effort so far. That being said the better documentation nowadays is here (which still doesn't mention Android) and it would be a good fit for Tier 3 support (since we'd build it and not run tests).
If you're up for it I think it'd be reasonable to review a PR adding support for Android binary releases which updates the tier support documentation as well with an Android target.

Ok sounds good, and thanks!
To assist a bit, the release build matrix is here and in theory it's "simply" adding another line there, but my guess is that some other tooling like cargo ndk will need to be installed similar to this


Update README.md

Coverage remained the same at 82.241% when pulling 9e8820f7ab1cb98a57d084ab432431bbf1de3e3e on fix-custom-rpc-evm_mine-docs into a53c02d0ed581267aafcdec28fe30f17d480e29c on develop.


Update to Scratch v3

extension API
https://github.com/LLK/scratch-vm/wiki/Scratch-3.0-Extensions-Specification
current build
https://preview.scratch.mit.edu/

This looks like it'll be helpful to get started: https://scratch.mit.edu/discuss/topic/277217/?page=3#post-3169236
In particular, see https://github.com/SheepTester/scratch-gui/issues/1
It added support for preloading the extension from a URL, which was looking to be a blocker to getting my stuff working in Scratch 3.
At first glance, it looks like it'll be enough to get a first version of a Scratch 3 extension running.

first basically working hack

I think the text and numbers extensions are working okay, although Scratch 3 itself still seems a little buggy to be relied on.
The image extension is still going to take a lot of work - extensions don't have the access to the Scratch runtime that I'll need to be able to make the costume image blocks.

Not much of an update since my last comment - I've spent a while trying to figure out how to get the runtime access needed to create the image blocks, without much success.


Fixed Filter example on Description

https://github.com/MicrosoftDocs/office-docs-powershell/issues/4283

Docs Build status updates of commit 9e890ba:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 9e890ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 359ae40:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 359ae40:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsAdPrincipal.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[org.openapis.v3] Security Scheme Update for HTTP/Bearer Auth

This pull request addresses the issue of being able to make a correctly configured security scheme for HTTP security schemes like Bearer Auth Tokens.
For more information, see the original issue: #90

Don't forget to bump the package patch version in PklProject. If there are local packages that depend on this one you will need to bump those versions as well and then run ./gradlew resolveProjects.


[ONNX] Initial work to import pre-quantized ONNX Models

This PR implements QuantlizeLinear, DequantizeLinear, and DynamicQuantizeLinear (which is deprecated but included for completeness).

thanks @mbrookhart @jwfromm


Incorrect ENUM decoding

GHC: 8.6.4
Stack: Version 2.1.3, Git revision 0fa51b9925decd937e4a993ad90cb686f88fa282 (7739 commits) x86_64 hpack-0.31.2
Built with: lts-13.19
morpheus-graphql commit: b40fd480b6e7c673a9f4a28b8e7bdc956344b80f
Summary of my problem: a simple enum type (possibly) being decoded incorrectly by the resolver. (Maybe it's just me :-)
The following code example could be used to demonstrate it:
-- types & args
newtype TestArgs = TestArgs
    { ttt :: Level } deriving (Generic, Show)

instance GQLType TestArgs where
    type KIND TestArgs = ENUM

data Level = L0 | L1 | L2 | L3
    deriving (Show, Generic)

instance GQLType Level where
    type KIND Level = ENUM

data TestResult = TestResult
    { code :: Text
    , level :: Level
    } deriving (Generic, Show)

instance GQLType TestResult where
    type KIND TestResult = OBJECT

-- query

qTest :: TestArgs -> IORes TestResult
qTest args = resolver $ return $ Right $ TestResult
  { code  = "ok"
  , level = ttt args
  }

-- resolver

rootResolver :: GQLRootResolver IO () () Query () ()
rootResolver = GQLRootResolver
  { queryResolver        = return Query { test = qTest }
  , mutationResolver     = return ()
  , subscriptionResolver = return ()
  }

Tested with Insomnia:

This, however, generated the correct document for /schema.gql:
type Query {
  test(ttt: Level!): TestResult!
}

enum Level {
  L0
  L1
  L2
  L3
}

type TestResult {
  code: String!
  level: Level!
}

For now, I've came up with a workaround:
-- Data/Morpheus/Resolve/Decode.hs
import           Data.Text                                  (unpack)
import           Text.Read                                  (readMaybe)
--
instance (Generic a, EnumRep (Rep a), Read a) => Decode a ENUM where
  __decode _ (Enum value) = maybe err pure $ readMaybe (unpack value)
    where err = internalArgumentError ("cannot convert to enum: " <> value)
  __decode _ isType       = internalTypeMismatch "Enum" isType

...which seemed to behave correctly. But it would require every ENUM to be an instance of Read, thus I think this is far from ideal.
Would you please help me identify the cause? And thank you for your hard work making morpheus-graphql available!
P./S.
I know there's Data.Morpheus.Resolve.Generics.EnumRep, maybe we could take advantage of the metadata of Rep?

thank you i will fix it soon. i knew that this part of code was not written properly. i found better way to validate Union types  with Generic Rep so i will update Enum decoding.
pull request will be soon.

old implementation decoded enums could not decode properly enums more then 3 constructors, now it will

thank you for addressing this issue ;)

fixed

@nalchevanidze
I can confirm this merge solved my problem.
Thank you very much for your help!


Allowed variable to be used with function "sqlpage.read_file_as_text"

What are you building with SQLPage ?
I'm creating a web interface to manage account creation and management via proftpd. And I want to add a toggle to activate the dark mode.
What is your problem ? A description of the problem, not the solution you are proposing.
I'm looking to use the following toggle example:
https://github.com/lovasoa/SQLpage/tree/main/examples/light-dark-toggle
I'd like to use the dynamic component with a file and not by storing the information in a database.
What are you currently doing ? Since your solution is not implemented in SQLPage currently, what are you doing instead ?
I currently have this code:
select 'dynamic' as component, sqlpage.read_file_as_text('shell.json') as properties;

shell.json
{
    "component": "shell",
    "title": "ProFTPD - admin",
    "layout": "vertical",
    "font": "Poppins",
    "icon": "folder-share",
    "__icon_list__": "https://tabler.io",
    "footer": "Infra",
    "link": "/",
    "sidebar": true,
    "theme": "dark",
    "menu_item": [
        {"link": "index.sql", "title": "Home"},
        {"link": "create.sql", "title": "Create SFTP"},
        {"link": "list.sql", "title": "SFTP list"},
        {"title":"☀","link":"/toggle.sql"}
    ]
}

I would like to be able to do this:
{
    "component": "shell",
...
    "theme": sqlpage.cookie('lightdarkstatus'),
...
}

I don't know if this is easily doable but it would be really cool.
Thanks in advance ;)

Hi! You can use https://sql.datapage.app/functions.sql?function=run_sql for that!

You can do it with
select 'dynamic' as component, sqlpage.run_sql('shell.sql') as properties;

and shell.sql :
select
    'shell' as component,
    sqlpage.cookie('lightdarkstatus') as theme;
``|


Arbitrary Sidecar implementation + build. Closes #680.

Motivation
Enhancement. Closes #680.

Solution

PR Checklist

[ ] Added Tests
[x] Added Documentation
[ ] Breaking changes

Ahhh @dorlneylon I'm working on this too as mentioned on the issue ;(

@mattsse I have changed what you asked for, can I have my pipeline run?

@mattsse Can I have my pipeline run and review again? I've fixed what you left for me.

@mattsse @prestwich your reviews have been resolved, please check. Also I would like to get another workflow try (last, I hope.)

@prestwich @mattsse your reviews have been taken care of

still not sure why the builder was moved, appears to be unused in eips

i seem to remember that I asked for it to be moved. The sidecar is difficult to construct and use properly without it, and it doesn't really belong in the consensus crate either

@mattsse "use" of arbitrary impl has been removed, the changes were made.

@mattsse

@prestwich Can I get a review and a worflow run, please?..

@mattsse

@mattsse need your review.

@prestwich and also need yours review.


Add CEPHFS support

Closes #4822
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Ready for review


feat: basic ace-editor with rematch

Extending from this comment:
https://github.com/The-Programming-Foundation/learningcodesnippets/pull/11#issuecomment-721503239
Note: I created this branch from master and merged it with feature/state-management(commit: dcdb9ad)
These are the implementations so far:
(1) Switch between dark mode and light mode for the code editor
(2) Code editor will not be displayed on initial minimize button click
(3) Accept language as a prop for different modes for the ace-editor
(This will need to implement dynamic importing to be effective. It currently has only imported with python mode)
(4) State management keeps track of code editor id and content
To see a demo, it is currently located in Programming > Python > Hello Earth.

LGTM! I think the only outstanding thing is not referencing by ID depending on what the UI/UX decisions are. Great job, Emily!

Simplified the model for the editor so that we have a hashmap of editor to allow for multiple in state at once and for ease of CRUD operations. Removed useState hooks in favor of redux useDispatch to effect out managed state. Cleaned up my boilerplate rematch code now that the editor is implemented with it.
With new editor designs some of this might change but we can use this a "first step" for the editor feature and create issues/tickets with this a the base.


Version 17 ajaxfileupload doesn't respect allowedfiletypes

The AJAX Control Toolkit <VERSION>
The installation method

[ ] Installer
[x ] NuGet package
[ ] A custom build from the source code

Minimal steps to reproduce the bug
Install 17.1.1.  Set up an ajaxfileupload control, set allowedtypes="kml".  Drag a KML file onto it.
Actual result
Throws an exception on the server: "File extension not allowed"; client control simply displays red "error".
Expected result
Should upload the file
Browser(s) used
(any)
A site deployment method

[ ] VS development web-server,
[ x] IIS

Reverting to 16.1.1 works flawlessly.

Hi @ericberman
To fix this error, please add the additionalUploadFileExtensions attribute to the ajaxControlToolkit section in your Web.config:
<configSections>
    <section name="ajaxControlToolkit" type="AjaxControlToolkit.AjaxControlToolkitConfigSection, AjaxControlToolkit" requirePermission="false"/>
</configSections>
<ajaxControlToolkit additionalUploadFileExtensions="kml" />

More info can be found in our wiki article: https://github.com/DevExpress/AjaxControlToolkit/wiki/AjaxFileUpload-setup#allowed-file-extensions

I somehow missed that; thanks so much - works perfectly.


Why am I getting this reminder?

Avoid duplicates

[ ] Question is not already answered in the FAQ
[ ] Question has not already been asked in another issue

Your Question

Source File:
Line(s):
Question:

Today I got a notification from cwa, it reminds me to open it regularly and to check my risk status.
This is confusing, because:

I open it already daily to check my status (currently 3 green low-risk). So I expect cwa to know this.
in case of a "serious change", e.g. "red risk", I would indeed expect such a notification. But why for a green risk that is the same as yesterday?
the time of the message was not related to the risk checking procedure. The message popped up at 12:25. Yesterday ut checked at 16:27, today at 16:44

cwa 1.5.0(8) / iOS 13.7 / iPhone 8

Hey @ndegendogo
This is a bug in CWA Version 1.5.0 and will be solved with Version 1.5.1

I just got this notification, despite the installation of 1.5.1 this afternoon and after I had the app opened several times afterwards.

@miallo
Could you please wait for another 48h and report back if you still get this reminder?

Dear @miallo and dear community,
thank you for your posts.
My understanding is that the issue has been revolved, since no more reports on this issues have been posted here.
For the moment I will close this issue. Of course, should the issue emerge again, please open a new issue.
Best regards,
DS
Corona-Warn-App Open Source Team


Merge rc/1.23 into master

The FIO30-C test appears to be failing.  This is a test of UncontrolledFormatString.ql, I don't think it has anything to do with these changes?

@geoffw0 I don't see any failing tests -- this PR is green. In any case, issues with the FIO30-C test will be caused by yesterday's submodule accident.


Set up Corpora database

The Corpora database need not reflect the finalized schema but should have migration capabilities available so that changes can easily be made once the schema is finalized.
The Corpora database should be set up based on the UML described in the high level architecture document, Figure 6.
Tasks

[ ] Setup database migration framework
[ ] Generate/setup ORM classes

@Bento007 Assigning this to you for now and once you're done with the second task, can you please hand over to @calvinnhieu to complete the final two tasks? Thank you!

This ticket has redundant tasks: the bringing up of the infrastructure of the database is already handled by ticket #309 so I will remove that from here, unassign Trent and assign this ticket to Calvin. The focus of this ticket will be on defining the tables in the database which includes ORM + migration and doing some basic testing to make sure it works as intended.

Currently blocked on a small AWS resource naming decision. Expect to be clear EOD.
ORM PR (PR350) will be validated via successful load of the sample project (#334).
@maniarathi I haven't set up a DB migration framework in the past. Will follow-up offline for a knowledge transfer (I believe you and Parth set something up with alembic in the past?)


Canvas API is not tested

 Issue by Hixie
Thursday Jul 16, 2015 at 22:45 GMT
Originally opened as https://github.com/flutter/engine/issues/63

From @Hixie on June 10, 2015 20:7
Copied from original issue: domokit/mojo#234

 Comment by Hixie
Thursday Jul 16, 2015 at 22:45 GMT

From @mpcomplete on June 18, 2015 18:6
Added a Gradient test in https://codereview.chromium.org/1185423003/ .

 Comment by Hixie
Thursday Oct 08, 2015 at 17:22 GMT

We don't even have a paint test harness anymore.

Specifically this issue is about the fact that dart:ui's graphics API has no testing. There's nothing that makes sure that, for instance, we don't accidentally change the default winding rule for path filling.
This would be fixed by having reference tests or by having engine unit tests that can verify skia output.

Reference testing is tracked by https://github.com/flutter/flutter/issues/3227.

closing in favour of #3227 .


Source for libnvdsinfer_custom_impl_Yolo_Custom_Vision.so

I can run the plugin, but my bounding boxes just flicker at position 0,0. I think this is because I don't have the same number of classes (3) as in the example. I've tried another yolov2 plugin and it does not work either. I think this one would work if I could modify the classes. FWIW, my Custom Vision model is returning a tensor shaped 45x13x13. I have three classes, and yolov2 has 5 anchors, so I don't know how the 45 items is calculated. Other yolov2 models return 13x13x125 for 20 classes.

I'm running into the same issue as above, can you please provide the source code for the library listed?

I think I could have saved myself a lot of effort and just used the Small-S1 target. Anyway, I went through their python code and adapted it to deepstream.
diff --git b/nvdsinfer_custom_impl_Yolo/Makefile a/nvdsinfer_custom_impl_Yolo/Makefile
index 8b85b86..3511cd5 100644
--- b/nvdsinfer_custom_impl_Yolo/Makefile
+++ a/nvdsinfer_custom_impl_Yolo/Makefile
@@ -20,7 +20,7 @@
 # DEALINGS IN THE SOFTWARE.
 ################################################################################

-CUDA_VER?=
+CUDA_VER?=10.2
 ifeq ($(CUDA_VER),)
   $(error "CUDA_VER is not set")
 endif
diff --git b/nvdsinfer_custom_impl_Yolo/nvdsparsebbox_Yolo.cpp a/nvdsinfer_custom_impl_Yolo/nvdsparsebbox_Yolo.cpp
index 17f47ee..357a11e 100644
--- b/nvdsinfer_custom_impl_Yolo/nvdsparsebbox_Yolo.cpp
+++ a/nvdsinfer_custom_impl_Yolo/nvdsparsebbox_Yolo.cpp
@@ -30,7 +30,7 @@
 #include "nvdsinfer_custom_impl.h"
 #include "trt_utils.h"

-static const int NUM_CLASSES_YOLO = 80;
+static const int NUM_CLASSES_YOLO = 4;

 extern "C" bool NvDsInferParseCustomYoloV3(
     std::vector<NvDsInferLayerInfo> const& outputLayersInfo,
@@ -89,6 +89,20 @@ static NvDsInferParseObjectInfo convertBBox(const float& bx, const float& by, co
     return b;
 }

+static float logistic(float x)
+{
+    if (x > 0.0f)
+    {
+        return (float)(1.0f / (1.0f + exp(-x)));
+    }
+    else
+    {
+        auto e = exp(x);
+        return (float)(e / (1.0f + e));
+    }
+}
+
+
 static void addBBoxProposal(const float bx, const float by, const float bw, const float bh,
                      const uint stride, const uint& netW, const uint& netH, const int maxIndex,
                      const float maxProb, std::vector<NvDsInferParseObjectInfo>& binfo)
@@ -98,16 +112,21 @@ static void addBBoxProposal(const float bx, const float by, const float bw, cons

     bbi.detectionConfidence = maxProb;
     bbi.classId = maxIndex;
+    if (bbi.detectionConfidence > 0)
+      std::cout << "classId=" << maxIndex << ",conf=" << bbi.detectionConfidence << ",left=" << bbi.left << ",top=" << bbi.top << ",w=" << bbi.width << ",h=" << bbi.height << std::endl;
     binfo.push_back(bbi);
 }
+template <class T>
 static std::vector<NvDsInferParseObjectInfo>
 decodeYoloV2Tensor(
-    const float* detections, const std::vector<float> &anchors,
+    const T* detections, const std::vector<float> &anchors,
     const uint gridSizeW, const uint gridSizeH, const uint stride, const uint numBBoxes,
     const uint numOutputClasses, const uint& netW,
     const uint& netH)
 {
+    std::cout << "Detecting with type size " << sizeof(T) << ", classes=" << numOutputClasses;
+    std::cout << ", stride=" << stride << ", numBBoxes=" << numBBoxes << ", netW=" << netW << ", newH=" << netH << std::endl;
     std::vector<NvDsInferParseObjectInfo> binfo;
     for (uint y = 0; y < gridSizeH; ++y) {
         for (uint x = 0; x < gridSizeW; ++x) {
@@ -127,8 +146,11 @@ decodeYoloV2Tensor(
                 const float bh
                     = ph * exp (detections[bbindex + numGridCells * (b * (5 + numOutputClasses) + 3)]);

-                const float objectness
+                float objectness
                     = detections[bbindex + numGridCells * (b * (5 + numOutputClasses) + 4)];
+                std::cout << "objectness=" << objectness;
+                //objectness=logistic(objectness);
+                std::cout << "," << objectness << std::endl;

                 float maxProb = 0.0f;
                 int maxIndex = -1;
@@ -308,6 +330,7 @@ extern "C" bool NvDsInferParseCustomYoloV3Tiny(
         kANCHORS, kMASKS);
 }
+template <int num_classes_yolo>
 static bool NvDsInferParseYoloV2(
     std::vector<NvDsInferLayerInfo> const& outputLayersInfo,
     NvDsInferNetworkInfo const& networkInfo,
@@ -325,11 +348,11 @@ static bool NvDsInferParseYoloV2(
     }
     const NvDsInferLayerInfo &layer = outputLayersInfo[0];

-    if (NUM_CLASSES_YOLO != detectionParams.numClassesConfigured)
+    if (num_classes_yolo != detectionParams.numClassesConfigured)
     {
         std::cerr << "WARNING: Num classes mismatch. Configured:"
                   << detectionParams.numClassesConfigured
-                  << ", detected by network: " << NUM_CLASSES_YOLO << std::endl;
+                  << ", detected by network: " << num_classes_yolo << std::endl;
     }

     assert(layer.inferDims.numDims == 3);
@@ -337,12 +360,26 @@ static bool NvDsInferParseYoloV2(
     const uint gridSizeW = layer.inferDims.d[2];
     const uint stride = DIVUP(networkInfo.width, gridSizeW);
     assert(stride == DIVUP(networkInfo.height, gridSizeH));
+    assert(layer.inferDims.d[0] == kNUM_BBOXES * (5 + num_classes_yolo));
     for (auto& anchor : anchors) {
         anchor *= stride;
     }
-    std::vector<NvDsInferParseObjectInfo> objects =
-        decodeYoloV2Tensor((const float*)(layer.buffer), anchors, gridSizeW, gridSizeH, stride, kNUM_BBOXES,
-                   NUM_CLASSES_YOLO, networkInfo.width, networkInfo.height);
+    std::vector<NvDsInferParseObjectInfo> objects;
+    if (layer.dataType == NvDsInferDataType::HALF)
+    {
+        objects = decodeYoloV2Tensor<__fp16>((const __fp16*)(layer.buffer), anchors, gridSizeW, gridSizeH, stride, kNUM_BBOXES,
+                   num_classes_yolo, networkInfo.width, networkInfo.height);
+    }
+    else if (layer.dataType == NvDsInferDataType::FLOAT)
+    {
+        objects = decodeYoloV2Tensor<float>((const float*)(layer.buffer), anchors, gridSizeW, gridSizeH, stride, kNUM_BBOXES,
+                   num_classes_yolo, networkInfo.width, networkInfo.height);
+    }
+    else
+    {
+      throw std::runtime_error("unsupport output layer type");
+    }
+
     objectList = objects;

@@ -355,17 +392,27 @@ extern "C" bool NvDsInferParseCustomYoloV2(
     NvDsInferParseDetectionParams const& detectionParams,
     std::vector<NvDsInferParseObjectInfo>& objectList)
 {
-    return NvDsInferParseYoloV2 (
+    return NvDsInferParseYoloV2<80> (
         outputLayersInfo, networkInfo, detectionParams, objectList);
 }

-extern "C" bool NvDsInferParseCustomYoloV2Tiny(
+extern "C" bool NvDsInferParseCustomYoloV2_4(
+    std::vector<NvDsInferLayerInfo> const& outputLayersInfo,
+    NvDsInferNetworkInfo const& networkInfo,
+    NvDsInferParseDetectionParams const& detectionParams,
+    std::vector<NvDsInferParseObjectInfo>& objectList)
+{
+    return NvDsInferParseYoloV2<4> (
+        outputLayersInfo, networkInfo, detectionParams, objectList);
+}
+
+extern "C" bool NvDsInferParseCustomYoloV2_80(
     std::vector<NvDsInferLayerInfo> const& outputLayersInfo,
     NvDsInferNetworkInfo const& networkInfo,
     NvDsInferParseDetectionParams const& detectionParams,
     std::vector<NvDsInferParseObjectInfo>& objectList)
 {
-    return NvDsInferParseYoloV2 (
+    return NvDsInferParseYoloV2<80> (
         outputLayersInfo, networkInfo, detectionParams, objectList);
 }

@@ -425,5 +472,6 @@ extern "C" bool NvDsInferParseCustomYoloTLT(
 CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV3);
 CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV3Tiny);
 CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV2);
-CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV2Tiny);
+CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV2_4);
+CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloV2_80);
 CHECK_CUSTOM_PARSE_FUNC_PROTOTYPE(NvDsInferParseCustomYoloTLT);

I got this working for a 416x416 image, but put it on hold. I'm converting the model to ONNX and then having python convert it to tensorrt and running it on static frames from python. In Python it's been much easier to run at higher resolution.

Thanks! Do you have the full cpp file? This looks like just the diff

Uploaded here, just now:
https://github.com/brianegge/deepstream_objectDetector_Yolo/tree/master/nvdsinfer_custom_impl_Yolo
I made the number of classes a template parameter - you'll need to customize to your number of classes.

Did you modify anything other than the nvdsinfer_custom_impl_Yolo.cpp file? I modified to the 1 class that my model detects, but am not getting any bounding boxes on my sink.

Sorry - I didn't keep a good record of the steps I took. Basically I had a simple image which would detect fine through the python process, then I piped that image into deep stream, and added logging until it finally drew the same bounding box.
The problem is, if the shape or anything is off, then you get nothing or noise. I tried adding a few asserts around the shape checking. I now run my images at 688x384, which is 21 x 12 grid, in python. It took forever to get this to work, but the shape is much better for my images. I've thought about porting this to deepstream, but thought it was too much effort. Plus in C++ I never was able to get multiple batches working with my model, and I want 4 or 8 images in a batch. Looked into running the triton server on the Nano, and that doesn't work for most models.
My deep stream config was this:
[primary-gie]
enable=1
gpu-id=0
config-file=/home/egge/detector/configs/config_infer_primary_egge.txt
batch-size=1
bbox-border-color0=1;0;0;0.7
bbox-border-color1=0;1;1;0.7
bbox-border-color2=0;1;1;0.7
bbox-border-color3=0;1;0;0.7
interval=15
gie-unique-id=1
nvbuf-memory-type=0

Which loads this detector:
[property]
gpu-id=0
net-scale-factor=1.0
#net-scale-factor=0.0039215697906911373
#0=RGB, 1=BGR
model-color-format=1
onnx-file=/home/egge/detector/models/model32.onnx
# /bin/trtexec --onnx=models/model32.onnx --explicitBatch --saveEngine=models/model.onnx_b3_fp32.engine
model-engine-file=/home/egge/detector/models/model.onnx_b3_fp32_wide.engine
labelfile-path=/home/egge/detector/models/labels.txt
## 0=FP32, 1=INT8, 2=FP16 mode
network-mode=0
num-detected-classes=4
gie-unique-id=1
network-type=0
is-classifier=0
## 0=Group Rectangles, 1=DBSCAN, 2=NMS, 3= DBSCAN+NMS Hybrid, 4 = None(No clustering)
cluster-mode=2
maintain-aspect-ratio=1
parse-bbox-func-name=NvDsInferParseCustomYoloV2_4
custom-lib-path=/opt/nvidia/deepstream/deepstream-5.0/sources/objectDetector_Yolo/nvdsinfer_custom_impl_Yolo/libnvdsinfer_custom_impl_Yolo.so
#engine-create-func-name=NvDsInferYoloCudaEngineGet
#scaling-filter=0
#scaling-compute-hw=0

[class-attrs-all]
nms-iou-threshold=0.45
pre-cluster-threshold=0.5
roi-top-offset=0
roi-bottom-offset=0
detected-min-w=0
detected-min-h=0
detected-max-w=0
detected-max-h=0

I figured out the issue, it was a scaling thing like you mentioned. Thanks for the help, I really appreciate it!

"For DeepStream to understand how to parse the bounding boxes provided by a model from Custom Vision, we need to download an extra library:
wget -O libnvdsinfer_custom_impl_Yolo_Custom_Vision.so --no-check-certificate "https://onedrive.live.com/d"
Is this library available for x86, trying to run this on a T4

I am using custom vision model with DeepStream. I have deployed it and it is working. However, in inference results, I get an extra object detection class "Vehicle" which is not there in my model. Please suggest

Sorry for the delay. This sample has been updated to support Jetpak 4.5 and DeepStream 5.1. Along with this update the source code of the custom yolo parsing library has been released and the updated compiled library has also been provided.


chore: drawable converter usage

:bulb: Motivation and Context
#skip-changelog
:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed the submitted code.
[ ] I added tests to verify the changes.
[ ] I updated the docs if needed.
[ ] No breaking change or entry added to the changelog.

👍


AD search base and search attribute

Configuring AD and how to use search base for account name, first name, last name

Needs some formatting love.
@MBishop17 I think we should separate out each auth provider into it's own page so it can have it's own search when users are looking.


[1.20.1] Sophisticated Backpacks - Unintentional Quick equip leads to issues

Causes issues with backpack duplicated in creative mode and desync of backpack equipping and then backpack screen opening with AIR instead of the backpack

Found the issues and will see about getting a fix out for such coming up

Should be fixed as of latest release


Jump to Symfony 3.1

Mostly fixing Yaml quotes
Move tests folder outside src

Coverage decreased (-0.006%) to 97.331% when pulling 8b9b9d991ab809834357c624b1478ef99251e690 on sf3.1 into 7983b734b4af89c629a507d12a3daf18f364da0d on master.


How to check O365/Project/Visio subscription license info through command line?

As mentioned here, we can't check O365 subscription license status with "ospp.vbs /dstatus".
So what's the alternative to get the subscription license info through the command line?
I've checked that if subscription license is there then it creates a file in,
%localappdata%\Microsoft\Office\Licenses\5\11366380622108500016231342162113319422
*filename changes...
But the issue is that I can't differentiate if it's a license for Project or Visio or O365
Please share if there is a solution to it through default command/Powershell, without installing any other software. I'm looking to only get limited info if the subscription license exists or not and if it exists then for which product it exists.

@Bolt10000   Thank you for reaching out. The reason you're not seeing anything in the ospp.vbs response is because our latest versions of Office use a new licensing process. I am working on getting documentation created to walk through the changes and the process to check legacy ospp or the new process.
Until the docs get created you need to download the Office Licensing Diagnostic - https://www.microsoft.com/en-us/download/details.aspx?id=55948
After downloaded and extracted there is a PS1 script titled vnextdiag.ps1  you need to run this in PowerShell and it will return an output similar to ospp.vbs with entitlements status and activation status of the applications.

@MJP-MSFT Thanks a lot for the info and confirmation, Issue is now resolved.


Option to directly load html

I have downloaded content from the web and saved it as HTML files on my local machine,
is there an option for me to work with that HTML directly from a file or a variable, or the only option for me is to download?
Thank you

see #790

see #790

Thank you


Windows 7 - GraphicsAdapterNotFound

This is being discussed on my applications repository:
https://github.com/rnd-ash/OpenVehicleDiag/issues/11
It appears the users PC has full Dx11 support (Sandy bridge Pentium) yet he still sees the error.
Any help appreciated

I believe the DX11 backend of wgpu still has some rough edges (see the supported platforms table).


Android Test Orchestrator

It would be nice to add a note about the configuration for Android Test Orchestrator Tests

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28fe6afc-06ad-8465-f29a-04b2a118a378
Version Independent ID: 73b3398b-23b8-230d-d296-8900e053096a
Content: Preparing Espresso Tests for Upload - Visual Studio App Center
Content Source: docs/test-cloud/preparing-for-upload/espresso.md
Service: vs-appcenter
GitHub Login: @glennwester
Microsoft Alias: glwest

@daniel-varela I will pass the feedback on to the PM team.

@daniel-varela Thanks for writing in! I'm the PM for App Center Test. Support for Android Test Orchestrator is something that we hope to add soon, it's on our roadmap. I will provide an update as it becomes available.

@daniel-varela We are in the process to scale up our Android testing on the App Center device farm with Espresso tests. We have seen on various occasions that test runs can completely crash midway through the run due to a problem on a particular device. When this happens we don't get access to the test results that had already completed, nor does the run continue on devices that still need to run. Test runs not being resilient to these type of crashes really impacts our ability to test effectively on App Center with Espresso tests. I think support for the Android Test Orchestrator would be a way to increase crash resilience. It would be great if we could leverage the Android Test Orchestrator on App Center soon.

@glennwester
Thank you for your reply. Great to know that its on your roadmap.
This is blocking our team from leveraging appcenter for testing purposes.
It is highly desirable to be able to run these tests on real devices, instead of just emulators.
Looking forward to test orchestrator being enabled.

No Android Test Orchestrator support is a deal breaker for me. When is this support expected?

Thank you for this feedback @Saransh-Sharma! I don’t have a timeline for this support yet, I’ll update here when I can share this.


Update workouts extension

Description
Enable maps for everyone without the need for a personal API key via Raycasts proxy.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This is a nice update @samuelkraft, I just tested it and get failed to load image

This is a nice update @samuelkraft, I just tested it and get failed to load image

@pernielsentikaer Thanks for testing, can you try again? I had restricted the token but a header was missing.


add spiller

Signed-off-by: xufei<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #6528
Problem Summary:
What is changed and how it works?

add Spiller to handle spill/restore blocks.

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-unit-test

/run-all-tests

/run-all-tests

/merge


SAK-32389 Restoring behavior of tool menu toggle button

Before commit 3103b77 clicking anywhere in the  for the collapse button would toggle the menu. Changes made in that commit made it so that the double arrows needed to be clicked directly. This commit is an attempt to restore the previous behavior and preserve the changes made in 3103b77.

Please take a look at the @adrianfish commits in the PR queue .....

I didn't break this as far as I can tell, just for the record. I had to click on the chevrons before, too. I'll test this tomorrow and merge if it's cool. I'm in the middle of something else at the mo.

Interesting! I promise I wasn't trying to pick on you @adrianfish I just noticed the change this morning after pulling in updates from master and assumed it was because of that commit.

@Johnson-Mickey It's okay - I just don't want to come across as a bit lame. I thought it was a bit odd that you couldn't just click the whole li.

My instinct was that the adrian commits would remove need for this

@ottenhoff 'Fraid not. I didn't want to change that in case it was intended behaviour.

Looks like it was actually 8726ce6 that changed the functionality of clicking the li. Sorry again for the confusion.

@Johnson-Mickey It's really okay ! The fix is fine on top of those other changes I've made. I'll merge it in.

I don't understand the changes made here. Why do you want an "li" element to be clickable instead of the button?


brew bundle dump fails

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[ ] have a problem with brew install (or upgrade, reinstall) a single formula? If it's a general brew problem please file this issue at Linuxbrew/brew: https://github.com/Linuxbrew/brew/issues/new/choose. If it's a tap (e.g. Brewsci/homebrew-bio) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[ ] ran brew gist-logs <formula> (where <formula> is the name of the formula that failed) and included the output link?
[ ] if brew gist-logs didn't work: ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)
Trying to run a brew bundle dump -f in order to get a new list of packages.

What happened (include command output)

➜  linux master ✓ brew bundle dump -f
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found
➜  linux master ✓ brew bundle dump
Error: /home/james/GitHubRepos/dotfiles/linux/Brewfile already exists
➜  linux master ✓ rm Brewfile
removed 'Brewfile'
➜  linux master ✗ brew bundle dump
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found
sh: 1: list: not found

I tried removing the brewfile and doing it without -f but no difference.

What you expected to happen
Produce an updated Brewfile

Step-by-step reproduction instructions (by running brew install commands)
See above. Happy to include more if needed

Here are my entire dotfiles in the linux directory where I ran the command from. Feel free to poke around.

Hey I'm actually off linux for the time being but if I switch back and am able to reproduce it in a container I'll post here. I'm fine closing this issue for now. Thanks!


WIP: quickcheck some csrc

quickchecking some of our hand-crafted C code
! @jystic

! @amosr tests are pretty savage, sorry

Thanks for doing this 🎉 great to have more tests for our C 💯


Azure Function Integration with Logic App

Describe the Bug with repro steps
I am adding Azure Function Connector in Preview Designer.
When I try to add new Connection , there is no option to select a function App
While in General Available I do get the Option to add new Connection with all available function APP .
What type of Logic App Is this happening in?
Standard (Portal)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
No response
Screenshots or Videos

Trying to connect to Function App

Shows no possible options even when multiple function app exists in same subscrption and resource group

Multiple Function exists in same resource group and subscription

No response
Browser
Edge
Additional context
No response

@mukulgpt17 - Is this LA standard? I do see the option to change connection to select an app

Are you not seeing the link in the parameters like below ?

Please provide some screenshots

In Logic App (Standard) I try to use the Function App

But Once I try to create new connection it is not showing any possible Function App which i have created in the same subscription .

3 . There are multiple Function within Same subscription and resource group within which the Logic App (Standard) is created .

It seems this is related to the incident we have where some function app kinds were not listed in the dropdown. @mukulgpt17 - Can you confirm the app kind you have set in these functionApps are not just 'functionapp' and have something more in addition?

@preetriti1 the app kind of all the apps are of type function app only !
App Type : Function App


Finalise procedural macros

There're a couple issues that I wish to address before finalising the procedural macros:

[ ] Move string interpolation parsing to a separate parser
(A separate parser will go through all selectors and values to make replace interpolated values after AST is generated. This limits string interpolation to procedural macros, removes the Error::Interpolation variant and solves the complication and performance degradation caused by interpolation parsing.)
[ ] Parser does not handle quoted strings properly (content: ";";)
[ ] \${} or $${} escaping on ${} sequence
[ ] once_cell::sync::Lazy'ed SheetRef for styles with no string interpolation
[ ] Return Result<T> for Style and GlobalStyle
[ ] Come up a better name for IntoStyle(StyleSource or merge with IntoSheet?) and SheetRef(ArcSheet?)

@WorldSEnder I would appreciate your feedback on the procedural macros. Please let me know if you face any issues.

On that note, I don't think StringKind::Interpolation should show up in the ast, at all, as it is parser specific. If you abstract the parser a bit, the second variant that's called from the proc macro would not impact the runtime parser with additional variant matching.

That will also be removed when the first item is addressed.

I'm currently rewiring my PR to the upstream changes, and in a way that should make changes to the ast in the future easier to handle.

I will make changes to the AST as well due to the issue mentioned above. If you don't want to rebase again (in which I apologise), you may wish to hold off the PR until I addressed the first item in the checklist.

About the style and global_style macros: they are currently swallowing errors, I think they should be purposely of type Result<..> not unwrap that error by default. Let the user unwrap or simply ? the expanded macro.

I will address this. These macros were added before css! and that unwrap is added so I don't have to .unwrap() on invocation with used with class= in yew components.

I think there's a balance between ergonomic and correctness. css! needs to unwrap to make it ergonomic when used with class=. There's no good way to ? it at the moment as yew does not want to return Result<Html> and manual unwrapping on every css! invocation will make the API very difficult to use.
Just like I know that the .to_string() allocation is the slowest part of the parser.
I still don't want to remove them and carry a 'a lifetime in the style.


Booleans not interpreted correctly in compositions

privileged: true will be output as privileged: 'true'

This was an issue in resin-release, not this module.


Allow seeking a PartialInputStream to the very end.

This is useful when passing the object to C code, as applications often seek() to the end and tell() to find out the length of a stream.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Hmm, does the current code throw if you do Seek(0, SeekOrigin.End)? (Doesn't seem right if so)
(/Wonders if it should really be throwing at all when you try to seek past the end at all - reading the MS Docs to remind myself, it says Seeking to any location beyond the length of the stream is supported, so perhaps it shouldn't)

Yes, it does throw on Seek(0, End). I think, particularly for an input stream, throwing when seeking beyond the end is useful to detect errors early.


make sure shader playground has an up to date slang

https://github.com/tgjones/shader-playground/pull/123 see here


Skipping submodule update in corner case

For a given package foo, if the remote HEAD of the package is at the same SHA as the one specified in package.cmake, certain checkout logic is skipped, because CApp assumes the package has already been successfully checked out. This is likely only an issue for fresh builds. Namely, the build I am interested in fails because git submodule update --init --recursive was skipped.
Example output when the HEAD SHA differs from the one specified in package.cmake
debug: in foo, existing_remotes=origin
debug: foo remote origin has URL git@github.com:foo/foo.git
debug: foo remote origin matches desired URL git@github.com:foo/foo.git
debug: in foo pointing_refs=
debug: checked out commit SHA explicitly
debug: submodule update of foo completed
debug: checkout of foo succeeded
debug: clone of foo succeeded

Example output when the HEAD SHA is the same as package.cmake from an initial call to build
debug: foo is already at the desired commit
debug: clone of foo succeeded

I think I fixed this? Closing based on that assumption, please comment if it isn't really fixed!


Add rustup link

I think it might be better to add a link for rustup.

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

Thanks!
@bors r+

:pushpin: Commit 8d0e36a7089835f5e068055bf251a9ab88426a7d has been approved by ehuss

:hourglass: Testing commit 8d0e36a7089835f5e068055bf251a9ab88426a7d with merge c082648646cbb2be266df9ecbcdc253058158d68...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing c082648646cbb2be266df9ecbcdc253058158d68 to master...


Xaxis time range does not start and end according to time data

Hello all,
I don't know if it is a bug or just a limitation but I have unwanted gap in my line graph.
Expected Behavior
My data must fill the xaxis range all the time.
Current Behavior
In some cases, my data does not fill the xaxis range.
Steps to Reproduce (for bugs)
https://jsfiddle.net/3w5bke8f/2/
Environment

Chart.js version: 2.4.0
It depends on the size of my screen :

I think it is adding +-1 value of your current measuring unit to the chart. I have currently the work around to round my dates to my scale:
backend
self.currentValue = {x: moment().startOf('minute').toDate(), y:newValue}
frontend chart options
        xAxes: [
          {
            scaleLabel: {labelString:'Time', display: true},
            id: 'x-axis-1',
            type: 'time',
            display: true,
            position: 'bottom',
            time: {
              unit:'minute',
              displayFormats: {
                'minute': 'hh:mm a'
              }
            }

          }
        ]

But I would also expect it to not add this two extra points on the x-axis.

I am also experiencing this problem. If my charts were static I'd just use a smaller unit, but since they are generated automatically on user input, I can't use this workaround. Is there any way to fix this?

I think this is a rounding issue.  In your first image your unit scale is in hours so the min and max are on an hour boundary which is outside of your data.  Your data starts at "2016-11-29T01:44:04.695Z" but the x-axis min is rounded to "2016-11-29T01:00:00.000Z".  It'd be nice to be able to keep the hour unit but round to the nearest minute so that the min/max ticks don't have to start at the beginning of the hour.


[Bug]: On saving role, some permissions are getting unchecked for groups and roles tab.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
On trying to create new role by checking permissions on groups and role tab , on saving, the permissions are getting unchecked.
https://user-images.githubusercontent.com/80334441/204472539-eee0ed38-4350-49d4-9f12-44c9f3bae37b.mov
Steps To Reproduce

Login as Admin, Go to Roles Tab
Create new Role, go to Groups and Roles tab
Check Create permission for groups , then check create permission for Roles
Save and observe.

Public Sample App
No response
Issue video log
No response
Version
http://<IP_ADDRESS>/

@ankitakinger @berzerkeer : I checked this. The client is only sending part of the update and hence only part of the update is getting applied. Assigning it to you folks.

Re-opening for BE changes


not able to view .ppt, .pptx files using it

I am not able to view .ppt, .pptx files using it. Please help me with it.

Hi @Tunisha-Mamsys, could you be more specific? Do you use the google-viewer? Could you check the difference between my demo-application where ppt and pptx seems to work fine and your application?

Hi, Thanks for replying. I actually want to display .ppt and .pptx files in angular. I tried using office viewer and google viewer both but still it didn't work.
I used
<ngx-doc-viewer
[url]="doc"
viewer="google"
style="width:100%;height:50vh;"

this code only, in viewer I tried taking office and google.
in url, I gave the url of the document which is present on the server, but it didnt work.
Please help me for the same.
Thanks
Tunisha

From: Marcel Hoekstra @.>
Sent: Friday, August 13, 2021 4:40 PM
To: Marcelh1983/document-viewer @.>
Cc: Tunisha @.>; Mention @.>
Subject: Re: [Marcelh1983/document-viewer] not able to view .ppt, .pptx files using it (#23)
Hi @Tunisha-Mamsyshttps://github.com/Tunisha-Mamsys, could you be more specific? Do you use the google-viewer? Could you check the difference between my demo-application where ppt and pptx seems to work fine and your application?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Marcelh1983/document-viewer/issues/23#issuecomment-898381348, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP6ES53KZMPLSKLSI25BQ6TT4T4UDANCNFSM5CDBO44Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.
'
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Check the URL and Email ID carefully before clicking or responding. Non-compliance with Mamsys’s policies will result in appropriate disciplinary action.
'

And the server is not running on localhost?

No, it is deployed on a server. If I open the same path in a browser, I am able to open the file, but not able to do the same with this.

From: Marcel Hoekstra @.>
Sent: Monday, August 16, 2021 11:15 AM
To: Marcelh1983/document-viewer @.>
Cc: Tunisha @.>; Mention @.>
Subject: Re: [Marcelh1983/document-viewer] not able to view .ppt, .pptx files using it (#23)
And the server is not running on localhost?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Marcelh1983/document-viewer/issues/23#issuecomment-899239545, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP6ES53AY45DJNHV22WABUDT5CQY7ANCNFSM5CDBO44Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.
'
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Check the URL and Email ID carefully before clicking or responding. Non-compliance with Mamsys’s policies will result in appropriate disciplinary action.
'

I upgraded my stackblitz example with the latest version. Could you check if it works if you paste in your document url here?

No, it's not working.

From: Marcel Hoekstra @.>
Sent: Monday, August 16, 2021 11:40 AM
To: Marcelh1983/document-viewer @.>
Cc: Tunisha @.>; Mention @.>
Subject: Re: [Marcelh1983/document-viewer] not able to view .ppt, .pptx files using it (#23)
I upgraded my stackblitz example with the latest version. Could you check if it works if you paste in your document url herehttps://stackblitz.com/edit/ngx-doc-viewer-example?file=src%2Fapp%2Fapp.component.htm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Marcelh1983/document-viewer/issues/23#issuecomment-899249552, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP6ES522QTNHJHKH2DTXWP3T5CTULANCNFSM5CDBO44Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.
'
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Check the URL and Email ID carefully before clicking or responding. Non-compliance with Mamsys’s policies will result in appropriate disciplinary action.
'

That's weird. Could you share the url of the document. Could be characters in the url, or there is something with the document itself

The document is accessible using VPN, can that cause any issue?

From: Marcel Hoekstra @.>
Sent: Monday, August 16, 2021 1:36 PM
To: Marcelh1983/document-viewer @.>
Cc: Tunisha @.>; Mention @.>
Subject: Re: [Marcelh1983/document-viewer] not able to view .ppt, .pptx files using it (#23)
That's weird. Could you share the url of the document. Could be characters in the url, or there is something with the document itself
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Marcelh1983/document-viewer/issues/23#issuecomment-899309846, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP6ES5ZMTVMSQZ6SYAKHFPLT5DBIXANCNFSM5CDBO44Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.
'
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Check the URL and Email ID carefully before clicking or responding. Non-compliance with Mamsys’s policies will result in appropriate disciplinary action.
'

That's the problem. Google's viewer gets your document and converts it to html. But Google won't be able to access your document so it would fail.


Move to authorization by default, option to disable

Preserving part of the discussion in #475 . Currently we are adding auhtorization features but not enabling them by default. A way to go, to handle this graceful in the future might be the introduction of a configuration parameter, where we change  the default over time:
One sort-of future proof way might be to include a commandline parameter that describes the access to unauthorized clients, something like
--unauthorized_access [ALL,NONE,READ_ONLY,<custom_token>

and we could start with ALL as default, then sometime later print a warning, that it will change to NONE in a later version.
I think this is a useful feature even, when the default and recommended way is using auhtorization. There might deployments, where a certain set of data should be available to anyone, and also for testing it might come in handy.
The steps timewise could be

Add authorization. It is optional and a warning is printed informing the user that authorization will be required (by default) in the future.
Add flag to allow unauthorized access (i.e. like the example). The warning (above) is removed when this flag is used. Users can start using this flag if they intend to continue allowing unauthorized access (when it becomes required by default).
Make authorization required by default.

We are about to archive this repo soon. If you consider this issue as important please file a new issue at one of the new Kuksa repos at https://github.com/eclipse-kuksa


VSCode appends cmds.Completed whenever cmds.Builder is accessed

I'm using the latest VSCode
Whenever I use cmds.Builder and accept any of the suggested functions, VSCode appends cmds.Completed before the cmds.Builder.
It's best to explain it visually:

Oh, it isn't very pleasant. Thank you for reporting this. I will see what I can do.
However, I believe this is a bug of the vscode golang extension, because the cmds.Completed is not exported and the extension just produces a code that wouldn't be compiled.

...the cmds.Completed is not exported and the extension just produces a code that wouldn't be compiled.

It is exported if it is uppercase, isn't it...? 🤔

It is exported if it is uppercase, isn't it...? 🤔

No, it isn't. It lives in an internal package. Users are not allowed to import and use it directly.

I see, thanks for the explanation!
And thank you for looking into it! ❤

Hi @Delicious-Bacon,
This issue is related to the official Go language server and may not have a solution in a short time.
Instead of using another IDE/Editor, you can just not access cmds.Builder in the client.Do. For example, preparing the command beforehand.
cmd := client.B().Get().Key("mykey").Build()
client.Do(ctx, cmd)


gvawatermark with VASurface

When pipelines use VASurfaces, inference results are not shown by gvawatermark.

In case of VASurface, for observing inference results please use gvametapublish instead of gvawatermark.


fix: Only write to workspace configuration when settings need to change

The workspace configuration in .vscode/settings.json is dependent on the order of config.update() calls. This causes a diff in my project, which is only a change in the order of the settings. By only calling update() when a change is needed, VSCode will not touch the settings.json once the configuration is correct.

This was a premature conclusion. After further testing, I found that this was not the solution to my problem. I will open a separate issue.


Concurrency update

syncs the concurrency branch with development branch
modifies the concurrency implementation to reflect the use of hyper-h2

@tbetbetbe I think I'm happy with the idea of merging the concurrency stuff to development, and it'll make this patch far easier to review, so do you want to retarget this PR against development instead?

OK - I've opened #233


Fixes

Pull Request (PR) description

Fixes
Updated PnP Version

This Pull Request (PR) fixes the following issues
FIxes #236

This change is

Codecov Report

Merging #237 into Dev will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             Dev     #237      +/-   ##
=========================================
- Coverage   87.4%   87.38%   -0.02%
=========================================
  Files         55       55
  Lines       5208     5210       +2
  Branches      10       10
=========================================
+ Hits        4552     4553       +1
- Misses       646      647       +1
  Partials      10       10

Impacted Files
Coverage Δ

..._SCDLPComplianceRule/MSFT_SCDLPComplianceRule.psm1
98.46% <66.66%> (-0.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3205698...0f6c40d. Read the comment docs.

@ykuijs small PR for review