Unit tests fail when port 5000 is occupied

Describe the bug
Unit tests fail when there is an application running on port 5000.

npm test and npm run test:unit fail when there is an application running on 5000.
To Reproduce

Start a process in Port 5000.
Run npm test or npm run test:unit
The tests fail.

Expected behavior
The server should listen to the next ports.

Screenshots
For npm test

npm run test:unit also gives the same result: https://pastebin.com/ricHw8ug .

Specs:

Abell Version: 0.6.4
Node Version: 12.18.0
Operating System: Windows 10 Home

This is kind of expected as the test script tries to bind to that port 5000 so that we can test the retry logic of the dev server:
const dummyServer = net.createServer();
dummyServer.listen(SERVER_DEFAULT_PORT);

I don't this we should add a retry logic for something that tests retrying logic. In CI this passes as port 5000 is not occupied.
I will suggest you should close the process which is occupying the port.
The actual dev server already listens on the next port. If you want to run the dev server while also running the unit tests, just run the app on port 5005 using the -p flag.

Only thing that we can do but I would say would be a ugly hack is to catch port acquisition error and skip the server initialisation on the test scripts that is used to acquire the port. But that might reduce the realisability of this test.

This is kind of expected as the test script tries to bind to that port 5000 so that we can test the retry logic of the dev server

But there is a test for this, isn't it? Maybe rewrite the tests in a way that passes for this case too.
I don't know much about testing  but if it is "expected to fail", then shouldn't those cases be considered?

The actual dev server already listens on the next port. If you want to run the dev server while also running the unit tests, just run the app on port 5005 using the -p flag

Noted. Thanks!

Yeah I think as @pantharshit00 said, it is fine if it breaks locally the tests will pass CI anyway and to make them pass locally, we can use abell serve --port 9090 while running the local server

I guess we can close this? Let me know if anyone has different thoughts

But there is a test for this, isn't it? Maybe rewrite the tests in a way that passes for this case too.

That is simply not possible as we can't test cli port retrying logic without blocking the default port


proposal: net/http: Add NewDefaultTransport function

We would like to be able to use the default options for http.Transport without modifying the global, or worrying about whether anyone has modified the transport, or having to typecast it to call Clone. I propose adding a NewDefaultTransport() *Transport function to the http package. It should return a new Transport with the default options filled out. The global definition then becomes var DefaultTransport RoundTripper = NewDefaultTransport(). Note that the function returns *Transport not RoundTripper so we don't have to typecast it.
func NewDefaultTransport() *Transport {
    return &Transport{
        Proxy: ProxyFromEnvironment,
        DialContext: (&net.Dialer{
            Timeout:   30 * time.Second,
            KeepAlive: 30 * time.Second,
            DualStack: true,
        }).DialContext,
        ForceAttemptHTTP2:     true,
        MaxIdleConns:          100,
        IdleConnTimeout:       90 * time.Second,
        TLSHandshakeTimeout:   10 * time.Second,
        ExpectContinueTimeout: 1 * time.Second,
    }
}

This was previously discussed in #26013, but in that case people wanted to pull in modifications to the global that had been made, so the Clone() method was introduced.

how is this different from tr := http.DefaultTransport.Clone() besides being 2 characters shorter?

@seankhliao As I mentioned, Clone() will also pull in any modifications that have been made to the global, and requires a typecast that can fail if the global itself was replaced. We want a clean default Transport to work with.

I'm not sure I understand the use case of  "I will happily accept whatever defaults the Go project deems appropriate (from NewDefaultTransport) but reject any defaults decided by the author of the running program and its specific environment".
Why is one  set of defaults fine and not the other?

@eandre I'm not sure what you mean by "the author of the running program". Any external library can just modify the global variable. So the issues are:

We trust the Go authors to use reasonable defaults. If the zero value of http.Transport used these defaults, we would be happy with that, but since it doesn't, this is the next best thing. I do not want to have to worry about what some third-party dependency (direct or indirect) happens to do with that global in an init function.
If anything changes that global to be something other than an *http.Transport (which is possible since it is actually of type http.RoundTripper), calling the Clone method does not work.

In my opinion, the Clone method was a misfeature for the original use case described in #26013. I cannot think of any situation where I would want to copy the potentially modified global. The whole reason for not just using the global directly in my code is that I want to be isolated from such changes, and I want my changes to be isolated from other sections of code.

I don't have strong feelings for or against your proposal, but you seem to be taking an adversarial stance against these dependencies ("who knows what they might do?"). My point of view is that as an author of a binary, you are responsible for what libraries you pull in and what they do.
Rather than viewing any change to the http.DefaultTransport configuration as hostile, you could also view them from the perspective of "the author of the binary should know what they're doing, and if they are using code that reconfigures the default transport, I should follow along with their wishes". I agree with you that in most environments there is no need to reconfigure these settings. But perhaps they want to set strict timeout settings, or perhaps they have a tricky networking setup that requires custom proxying.
Ignoring these settings is only "correct" in a sense if you take the stance that any changes to http.DefaultTransport are being done by library authors who don't know better, and the author of the binary is unaware that it's happening. I think that's not a particularly charitable perspective. That's why I argued that if you truly need a specific configuration, it's easy to construct your own *http.Transport with those settings. I just can't see any use case for "I don't care about the specifics of the configuration as long as it was chosen by the authors of the Go Project [as opposed to the author of the binary]". But maybe I'm missing something – If you could explain a concrete use case that would be great.

@eandre I am confused by your argument. You say both "as an author of a binary, you are responsible for what libraries you pull in and what they do" and "the author of the binary should know what they're doing, and if they are using code that reconfigures the default transport, I should follow along with their wishes." Those sound like mutually exclusive scenarios to me.
If I am authoring a binary, then I should have control over the creation of the transport. If I have requirements concerning the timing of the network operations, then I should be creating a transport with such settings. But I don't see a reason I would want to clone the default transport (as in the global) to do so. At best, it would be the same thing as constructing a new default transport, and at worst it could actually cause an unintentional issue. However, I could see why somebody would want to modify/replace the global variable itself in their top-level code.
If I am authoring a library, then I should allow the client to pass in an http.RoundTripper and let them have full control over its configuration. Consequently, the Clone method does not seem useful, because the round tripper need not be an http.Transport, and even if it were, I'm not sure why I would want to clone it.
My concrete use case is we needed to disable HTTP/2 on the transport, but wanted to leverage the rest of the default settings. Consequently, we ended up with something like:
transport := http.DefaultTransport.(*http.Transport).Clone()
transport.TLSNextProto = make(map[string]func(authority string, c *tls.Conn) http.RoundTripper)
// use transport

This did not actually work as expected due to #39302. However, even if it did, the fact that that requires a typecast, and there is no way to handle the typecast failing without just aborting the binary, is disconcerting. Additionally, we do not like the implication that we are forced to accept any changes to the global that could have been made elsewhere. (This is also a concern with just using the default transport global variable normally, but it became more apparent here.) If someone really wants those changes, they are free to use the Clone method, but it should not be the only option.

It would be helpful if you could cite a real-world example that drove this proposal. Was there a case where a third-party library modified some values of the DefaultTransport or swapped it with something else without documenting it ? The same argument could be theoretically made for any global variable in the standard library.
IIUC, this is primarily about not having to copy the default timeouts to the codebase separately to create a separate transport. Would that be accurate ?

Was there a case where a third-party library modified some values of the DefaultTransport or swapped it with something else without documenting it ?

Thankfully, this has not yet happened with the libraries that we have used. But the issues I see are (1) this leads to fragile code that fundamentally relies on nothing else in the entire binary (including some transitive dependency of a dependency) changing that global; and (2) it prevents us from writing properly robust code due to the following no-win situation.
t, ok := http.DefaultTransport.(*http.Transport)
if !ok {
    // now what?
}
t2 := t.Clone()
...

The same argument could be theoretically made for any global variable in the standard library.

Indeed, which is partially why, in my opinion, properly robust code should never be using global variables.

IIUC, this is primarily about not having to copy the default timeouts to the codebase separately to create a separate transport. Would that be accurate ?

Yes, especially because we would have to manually maintain those default settings with each new Go release. As I mentioned above, if the zero value for http.Transport had those semantics it would have been fine, but unfortunately it does not.
Also, one thing I would like some clarification on is what specifically instigated the introduction of the Clone() method. In #26013 it was mentioned that "copying a Transport is a general issue." But that means the code in question is specifically looking for *http.Transport and not http.RoundTripper. Consequently, any code relying on the Clone() method either isn't actually generalized, or inevitably runs into that same no-win situation with the typecast failing. In other words, what use cases actually necessitated the Clone() method over NewDefaultTransport()?


Fixed timestamp alignment on quality page

Motivation and context

The timestamp looks incorrectly aligned + margin after the icon looks too big.
Before:

After:

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Bug Fixes

Aligned the quality report button and timestamp on the quality page.

Style

Updated styling for buttons and quality settings switch on the analytics page.

Refactor

Reorganized the layout of the quality report controls for improved clarity and usability using Ant Design's Row and Col components.

IMO the both ways of alignment looks a little strange. The text is flying.
My proposal is something like this. Thus, it looks similar to performance page.

Also added Created before timestamp.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.41%. Comparing base (ad1bcd5) to head (4920e70).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8106      +/-   ##
===========================================
+ Coverage    83.40%   83.41%   +0.01%
===========================================
  Files          389      389
  Lines        41297    41297
  Branches      3858     3858
===========================================
+ Hits         34442    34448       +6
+ Misses        6855     6849       -6

Components
Coverage Δ

cvat-ui
79.70% <ø> (+0.03%)
:arrow_up:

cvat-server
86.75% <ø> (-0.01%)
:arrow_down:

@bsekachev
Applied


Implemented reactive API replacing sync API for DocumentDbTemplate

Implemented Reactive API changes for DocumentDbTemplate APIs.
Added serialize and deserialize APIs for CosmosItemProperties.
Reactive API minor improvements
Test Improvements.

Codecov Report

Merging #411 into master will decrease coverage by 2.02%.
The diff coverage is 80.21%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   75.49%   73.46%   -2.03%
==========================================
  Files          47       47
  Lines        1363     1353      -10
  Branches      154      154
==========================================
- Hits         1029      994      -35
- Misses        254      276      +22
- Partials       80       83       +3

Impacted Files
Coverage Δ

...smosdb/config/AbstractDocumentDbConfiguration.java
100% <100%> (ø)
:arrow_up:

...mosdb/core/convert/MappingDocumentDbConverter.java
51.85% <63.33%> (-14.28%)
:arrow_down:

...ing/data/cosmosdb/core/ReactiveCosmosTemplate.java
71.59% <80%> (+0.86%)
:arrow_up:

.../spring/data/cosmosdb/core/DocumentDbTemplate.java
86.11% <83.59%> (-0.06%)
:arrow_down:

...ure/spring/data/cosmosdb/common/CosmosdbUtils.java
0% <0%> (-42.86%)
:arrow_down:

...a/cosmosdb/core/generator/CountQueryGenerator.java
66.66% <0%> (-33.34%)
:arrow_down:

...osmosdb/core/generator/AbstractQueryGenerator.java
81.91% <0%> (-8.52%)
:arrow_down:

...repository/support/SimpleDocumentDbRepository.java
94.33% <0%> (-5.67%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b947620...2c5814e. Read the comment docs.


feat: support messaging between microservices for aca lab

Purpose
Add the module to support messaging between microservices for aca lab.
TODO:

adjust the doc order and update the doc title.
replace the current image.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Hi @vermegi, for your concern, let's discuss in the #40.
I will merge this PR first, and will update it if necessary if we make a final decision. Thanks!


Errors in browser console

Getting this when clicked on Dashboard:
Cannot resolve all parameters for XLarge(?). Make sure they all have valid type or annotations.
STACKTRACE:
BaseException@http://localhost:8080/:18:32
NoAnnotationError@http://localhost:8080/:174:20
_extractToken@http://localhost:8080/:305:49
http://localhost:8080/:269:84
map@[native code]
map@http://localhost:8080/:153:62
_dependenciesFor@http://localhost:8080/:269:40
resolve@http://localhost:8080/:74:44
createFromBinding@http://localhost:8080/:224:33
createFromType@http://localhost:8080/:261:50
_bindDirective@http://localhost:8080/:103:70
http://localhost:8080/:152:155
map@[native code]
map@http://localhost:8080/:153:62
_compile@http://localhost:8080/:152:92
http://localhost:8080/:187:44
forEach@http://localhost:8080/:156:15
_compileNestedProtoViews@http://localhost:8080/:184:41
http://localhost:8080/:123:54
run@http://localhost:8080/lib/zone.js:113:22
http://localhost:8080/:143:47
zoneBoundFn@http://localhost:8080/lib/zone.js:86:22
PromiseResolutionHandlerFunction@[native code]
  logErrorlocalhost:64:83
  calllocalhost:51
  _errorHandlerlocalhost:46
  _onErrorlocalhost:194
  onErrorlocalhost:128
  runzone.js:115
  (anonymous function)localhost:142
  zoneBoundFnzone.js:85

I have got the same issue

On which browsers are thrown these errors? Please note currently, Angular 2 do only supports ever-green browsers (tested on Chrome 43+, Firefox 38+).

Safari Version 9.0 (116<IP_ADDRESS>)

I guess Angular 2 will support Safari 9 once it get a stable release. Meanwhile, please try a more modern browser (e.g.: Chrome 43+, Firefox 38+).


Add telemetry to track user id in Azure

Background
Our Azure App Insights tracks user id, but this is currently a value generated by Azure. We would get more value out of this ID if it was linked to values in our database.
Action requested
For reporting users of SimpleReport (those with a login), track their user id in Azure with the ApiUser internal_id field (which should be returned as part of the whoami query).
For patients using SimpleReport to track their test results, we should aim to use the patient id or test order id if possible.
Acceptance Criteria
User ID field in Azure is more useful, and linkable to our data in Metabase and elsewhere.
Additional context
One of the action items from the analytics sync on 1/25/23.

@johanna-skylight to link her sample branch here

This branch has a sample on how to integrate the user ID into the azure context so all the metrics get correlated to it. This branch is still missing the logic to integrate the pxp flow with the patientRegistrationLink https://github.com/CDCgov/prime-simplereport/tree/johanna/spike_ms_insights_clean_up


Cannot click on an item of suggested list by mouse.

Thank you for your directive. It's very useful.
But it has a limitation. I cannot use mouse to click on a suggested list. It just worked for keyboard (up and down arrow key). Could you help to fix this issue. Thank you so much.

It's my mistake. Should add more restrictToSuggestedValues: true


cargo.toml failed parce

Whet try to build at linux mint - it show me error:
"""
failed to parse manifest at /home/Lapce/lapce-core/Cargo.toml
Caused by:
namespaced features with the dep: prefix are only allowed on the nightly channel and requires the -Z namespaced-features flag on the command-line
"""

You need at least Rust 1.62

Duplicate of #1095


error when install cartographer on ubuntu 20.04 and Ros noetic     absl::make_unique<ceres::AutoDiffLocalParameterization<

root@ubuntu:/home/gaosm/Downloads/cartographer/cartographer/build# ninja
[10/385] cd /home/gaosm/Downloads/cartographer/cartographer/build &...ome/gaosm/Downloads/cartographer/cartographer/build/AllFiles.cmake"
Files /home/gaosm/Downloads/cartographer/cartographer/build/AllFiles.cmake and - differ
[111/385] Building CXX object CMakeFiles/cartographer.dir/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc.o
FAILED: CMakeFiles/cartographer.dir/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc.o
/usr/bin/c++ -DGFLAGS_IS_A_DLL=0 -I/home/gaosm/Downloads/cartographer/cartographer/build -isystem /usr/local/include/eigen3 -isystem /home/gaosm/Downloads/cartographer/cartographer -isystem /usr/include/lua5.2 -O3 -DNDEBUG  -pthread -fPIC  -Wall -Wpedantic -Werror=format-security -Werror=missing-braces -Werror=reorder -Werror=return-type -Werror=switch -Werror=uninitialized -O3 -DNDEBUG -std=gnu++1z -MD -MT CMakeFiles/cartographer.dir/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc.o -MF CMakeFiles/cartographer.dir/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc.o.d -o CMakeFiles/cartographer.dir/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc.o -c /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc: In member function ‘void cartographer::mapping::scan_matching::CeresScanMatcher3D::Match(const Vector3d&, const Rigid3d&, const std::vectorcartographer::mapping::scan_matching::PointCloudAndHybridGridsPointers&, cartographer::transform::Rigid3d*, ceres::Solver::Summary*) const’:
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:102:42: error: ‘AutoDiffLocalParameterization’ is not a member of ‘ceres’
absl::make_unique<ceres::AutoDiffLocalParameterization<
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:102:42: note: suggested alternative: ‘LocalParameterization’
absl::make_unique<ceres::AutoDiffLocalParameterization<
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LocalParameterization
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:102:23: error: parse error in template argument list
absl::make_unique<ceres::AutoDiffLocalParameterization<
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
YawOnlyQuaternionPlus, 4, 1>>())
~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:101:58: error: expected primary-expression before ‘(’ token
? std::unique_ptrceres::LocalParameterization(
^
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:103:51: error: expected primary-expression before ‘)’ token
YawOnlyQuaternionPlus, 4, 1>>())
^
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:42: error: ‘QuaternionParameterization’ is not a member of ‘ceres’
absl::make_uniqueceres::QuaternionParameterization()),
^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:42: note: suggested alternative: ‘QuaternionToRotation’
absl::make_uniqueceres::QuaternionParameterization()),
^~~~~~~~~~~~~~~~~~~~~~~~~~
QuaternionToRotation
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:70: error: no matching function for call to ‘make_unique< >()’
absl::make_uniqueceres::QuaternionParameterization()),
^
In file included from /usr/include/c++/7/memory:80:0,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/common/lua_parameter_dictionary.h:21,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.h:24,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:17:
/usr/include/c++/7/bits/unique_ptr.h:832:5: note: candidate: template<class _Tp, class ... _Args> typename std::_MakeUniq<_Tp>::__invalid_type std::make_unique(_Args&& ...)
make_unique(_Args&&...) = delete;
^~~~~~~~~~~
/usr/include/c++/7/bits/unique_ptr.h:832:5: note:   template argument deduction/substitution failed:
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:70: error: template argument 1 is invalid
absl::make_uniqueceres::QuaternionParameterization()),
^
In file included from /usr/include/c++/7/memory:80:0,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/common/lua_parameter_dictionary.h:21,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.h:24,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:17:
/usr/include/c++/7/bits/unique_ptr.h:826:5: note: candidate: template typename std::_MakeUniq<_Tp>::__array std::make_unique(std::size_t)
make_unique(size_t __num)
^~~~~~~~~~~
/usr/include/c++/7/bits/unique_ptr.h:826:5: note:   template argument deduction/substitution failed:
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:70: error: template argument 1 is invalid
absl::make_uniqueceres::QuaternionParameterization()),
^
In file included from /usr/include/c++/7/memory:80:0,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/common/lua_parameter_dictionary.h:21,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.h:24,
from /home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:17:
/usr/include/c++/7/bits/unique_ptr.h:820:5: note: candidate: template<class _Tp, class ... _Args> typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...)
make_unique(_Args&&... __args)
^~~~~~~~~~~
/usr/include/c++/7/bits/unique_ptr.h:820:5: note:   template argument deduction/substitution failed:
/home/gaosm/Downloads/cartographer/cartographer/cartographer/mapping/internal/3d/scan_matching/ceres_scan_matcher_3d.cc:105:70: error: template argument 1 is invalid
absl::make_uniqueceres::QuaternionParameterization()),

I'm having the same problem as you, I'm using Ubuntu 20.04 and ros noetic. Is there any solution for this problem ?

solution is just not Install ceres-solver lastest because have same bug, I can solve problem using ceres-solver version 1.14

I have same issue ...


Feature/mark primary record

opentrials/opentrials#610

About the changes in tests/processors/cochrane_reviews/test_processor.py, are they intentional? It's not related to the scope of this PR, but in case it's a hotfix for the scraper then it's ok.

It is a hotfix. That test was failing because the previous record was removed from Pubmed.


Slurm and PAM backups

We need backups for Slurm and PAM. Groups, Users, Slurm accounts, Slurm users we need backups for these. The restoration process needs to be simple, easy, and quick. These backups will be used for cluster restorations in emergencies. We don't want something that someone can mess-up in a stressful situation. We also want to use these backups to setup dev clusters with prod settings. We want these backups in two locations. One for use only in emergencies and another for development, etc.. Crazy things happen in development. We don't want to lose a backup while doing something in development and not have a backup available for prod. We don't expect these backups to be large (<1GB) so storage costs are not a concern.

Consult with Trent to avoid duplicate backups of slurm and other data.

#135


Should IS-04 control entry for the IS-05 API have a trailing slash?

This came up at the Houston interop: The example "controls" entry for the IS-04 Device in chapter 3.1 of the documentation has a trailing slash in its "href":
"controls": [
  {
    "type": "urn:x-nmos:control:sr-ctrl/v1.0",
    "href": "http://<IP_ADDRESS>/x-nmos/connection/v1.0/"
  }
]

Similarly, the "API Paths" of section 2.1 states the format for an NMOS API MUST use a path like http(s)://<ip address or hostname>:<port>/x-nmos/<api type>/<api version>/ (note the trailing slash). However, in discussion regarding issues I submitted about this regarding the Sony implementation and the IS-04/-05 tests, there is some belief that the section titled "URLs: Approach to Trailing Slashes" in chapter 2.0 should apply, and that no trailing slashes should appear in the "controls" entries.
Presuming we can come to agreement on what the correct behavior is, can we correct the examples and/or text to match? In particular, some explicit text along with the example "controls" attribute would be helpful.

Thanks for raising this here, Bill.
I agree that it's a good idea to confirm whether either the trailing slash or its absence is REQUIRED or (only) RECOMMENDED here and make all parts of the specification reflect that.
The specifications have a lot of guidance for server implementations on responding to requests with and without trailing slashes, whether directly or via a redirect. I think what we're missing, unless one or other approach is confirmed as mandatory, is some guidance for clients on how to use the URL, such as Andrew mentioned in https://github.com/AMWA-TV/nmos-testing/issues/139#issuecomment-466339964, "at the very least trim trailing slashes and explicitly re-add one" before e.g. adding "single/senders".


perf(lttng): improve memory consumption

Signed-off-by: hsgwa<EMAIL_ADDRESS>This PR improves processing time and memory usage for Lttng class.
For now, I removed ros2_tracing classes.
memory usage was improved, but processing time was worse than with cache.
[Without event filter]
Before (without cache)
15.8s, 333MB
Before (with cache)
6.3s, 335MB
After
18.5s, 102MB
[With event filter]
Before (without cache)
13.2s, 274MB
Before(with cache)
3.84s, 245MB
After
13.9 s, 23MB

@hsgwa
I found a failure on generating an architecture file with Architecture('lttng', observed_data_path) method.
Have you ever seen a similar failure?
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_147068/431793165.py in <module>
----> 1 arch.export('x2_architecture_galactic.yaml', force=True)

~/caret/build/caret_analyze/caret_analyze/architecture/architecture.py in export(self, file_path, force)
    147         exporter = ArchitectureExporter(
    148             self.nodes, self.executors, self.paths, force)
--> 149         exporter.execute(file_path)
    150
    151     def search_paths(

~/caret/build/caret_analyze/caret_analyze/architecture/architecture_exporter.py in execute(self, file_path)
     44         mode = 'w' if self._force else 'x'
     45         with open(file_path, mode=mode) as f:
---> 46             f.write(str(self))
     47
     48     def __str__(self) -> str:

~/caret/build/caret_analyze/caret_analyze/architecture/architecture_exporter.py in __str__(self)
     49         import yaml
     50         obj = self.to_dict()
---> 51         return yaml.dump(obj, indent=2, default_flow_style=False, sort_keys=False)
     52
     53     def to_dict(self):

/usr/local/lib/python3.10/dist-packages/yaml/__init__.py in dump(data, stream, Dumper, **kwds)
    251     If stream is None, return the produced string instead.
    252     """
--> 253     return dump_all([data], stream, Dumper=Dumper, **kwds)
    254
    255 def safe_dump_all(documents, stream=None, **kwds):

/usr/local/lib/python3.10/dist-packages/yaml/__init__.py in dump_all(documents, stream, Dumper, default_style, default_flow_style, canonical, indent, width, allow_unicode, line_break, encoding, explicit_start, explicit_end, version, tags, sort_keys)
    239         dumper.open()
    240         for data in documents:
--> 241             dumper.represent(data)
    242         dumper.close()
    243     finally:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent(self, data)
     25
     26     def represent(self, data):
---> 27         node = self.represent_data(data)
     28         self.serialize(node)
     29         self.represented_objects = {}

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     46         data_types = type(data).__mro__
     47         if data_types[0] in self.yaml_representers:
---> 48             node = self.yaml_representers[data_types[0]](self, data)
     49         else:
     50             for data_type in data_types:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_dict(self, data)
    205
    206     def represent_dict(self, data):
--> 207         return self.represent_mapping('tag:yaml.org,2002:map', data)
    208
    209     def represent_set(self, data):

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_mapping(self, tag, mapping, flow_style)
    116         for item_key, item_value in mapping:
    117             node_key = self.represent_data(item_key)
--> 118             node_value = self.represent_data(item_value)
    119             if not (isinstance(node_key, ScalarNode) and not node_key.style):
    120                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     46         data_types = type(data).__mro__
     47         if data_types[0] in self.yaml_representers:
---> 48             node = self.yaml_representers[data_types[0]](self, data)
     49         else:
     50             for data_type in data_types:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_list(self, data)
    197         #            break
    198         #if not pairs:
--> 199             return self.represent_sequence('tag:yaml.org,2002:seq', data)
    200         #value = []
    201         #for item_key, item_value in data:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_sequence(self, tag, sequence, flow_style)
     90         best_style = True
     91         for item in sequence:
---> 92             node_item = self.represent_data(item)
     93             if not (isinstance(node_item, ScalarNode) and not node_item.style):
     94                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     46         data_types = type(data).__mro__
     47         if data_types[0] in self.yaml_representers:
---> 48             node = self.yaml_representers[data_types[0]](self, data)
     49         else:
     50             for data_type in data_types:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_dict(self, data)
    205
    206     def represent_dict(self, data):
--> 207         return self.represent_mapping('tag:yaml.org,2002:map', data)
    208
    209     def represent_set(self, data):

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_mapping(self, tag, mapping, flow_style)
    116         for item_key, item_value in mapping:
    117             node_key = self.represent_data(item_key)
--> 118             node_value = self.represent_data(item_value)
    119             if not (isinstance(node_key, ScalarNode) and not node_key.style):
    120                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     46         data_types = type(data).__mro__
     47         if data_types[0] in self.yaml_representers:
---> 48             node = self.yaml_representers[data_types[0]](self, data)
     49         else:
     50             for data_type in data_types:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_list(self, data)
    197         #            break
    198         #if not pairs:
--> 199             return self.represent_sequence('tag:yaml.org,2002:seq', data)
    200         #value = []
    201         #for item_key, item_value in data:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_sequence(self, tag, sequence, flow_style)
     90         best_style = True
     91         for item in sequence:
---> 92             node_item = self.represent_data(item)
     93             if not (isinstance(node_item, ScalarNode) and not node_item.style):
     94                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     46         data_types = type(data).__mro__
     47         if data_types[0] in self.yaml_representers:
---> 48             node = self.yaml_representers[data_types[0]](self, data)
     49         else:
     50             for data_type in data_types:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_dict(self, data)
    205
    206     def represent_dict(self, data):
--> 207         return self.represent_mapping('tag:yaml.org,2002:map', data)
    208
    209     def represent_set(self, data):

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_mapping(self, tag, mapping, flow_style)
    116         for item_key, item_value in mapping:
    117             node_key = self.represent_data(item_key)
--> 118             node_value = self.represent_data(item_value)
    119             if not (isinstance(node_key, ScalarNode) and not node_key.style):
    120                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     50             for data_type in data_types:
     51                 if data_type in self.yaml_multi_representers:
---> 52                     node = self.yaml_multi_representers[data_type](self, data)
     53                     break
     54             else:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_object(self, data)
    340         if not args and not listitems and not dictitems \
    341                 and isinstance(state, dict) and newobj:
--> 342             return self.represent_mapping(
    343                     'tag:yaml.org,2002:python/object:'+function_name, state)
    344         if not listitems and not dictitems  \

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_mapping(self, tag, mapping, flow_style)
    116         for item_key, item_value in mapping:
    117             node_key = self.represent_data(item_key)
--> 118             node_value = self.represent_data(item_value)
    119             if not (isinstance(node_key, ScalarNode) and not node_key.style):
    120                 best_style = False

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_data(self, data)
     50             for data_type in data_types:
     51                 if data_type in self.yaml_multi_representers:
---> 52                     node = self.yaml_multi_representers[data_type](self, data)
     53                     break
     54             else:

/usr/local/lib/python3.10/dist-packages/yaml/representer.py in represent_object(self, data)
    315             reduce = copyreg.dispatch_table[cls](data)
    316         elif hasattr(data, '__reduce_ex__'):
--> 317             reduce = data.__reduce_ex__(2)
    318         elif hasattr(data, '__reduce__'):
    319             reduce = data.__reduce__()

TypeError: cannot pickle 'SwigPyObject' object

I reproduced the same error in my environment.
6cc3883 fixes this error.
Could you try again after applying 6cc3883?

@hsgwa I found a failure on generating an architecture file with Architecture('lttng', observed_data_path) method. Have you ever seen a similar failure? Otherwise, do I have to rebase this branch by main branch?

@takam5f2
I reproduced the same error in my environment.
5075445 fixes this error.
Could you try again after applying 5075445?

I found a failure on generating an architecture file with Architecture('lttng', observed_data_path) method. Have you ever seen a similar failure? Otherwise, do I have to rebase this branch by main branch?

I have checked memory consumption with about 5 minutes trace file. With this PR, memory consumption will be decrease to less than 30% of original one.

before applying the PR

peak memory: 6447.66 MiB, increment: 6300.49 MiB

after applying the PR

peak memory: 2187.73 MiB, increment: 2078.02 MiB

@takam5f2
Thank you for evaluating!
I've implemented cache.
It's supposed that almost time consuming is as mush as main branch.
before implementing cache (57903aa)
308Mib 2m17s

after implementing cache
[without cache] ("caret_converted" will be created)
386Mib 2m10ss

[with cache] ("caret_converted" will be used)
386Mib 40s

I confirmed the effects of the cache.
Could you evaluate performance again?

@hsgwa
Thank you for improving speed of reading data.
I confirmed that cache file is reasonable to use and I confirmed that message_flow is generated.
first
peak memory: 7239.36 MiB, increment: 7093.11 MiB
CPU times: user 6min 58s, sys: 3.46 s, total: 7min 1s
Wall time: 7min 1s

seconds
peak memory: 7118.35 MiB, increment: 6972.65 MiB
CPU times: user 1min 28s, sys: 1.94 s, total: 1min 30s
Wall time: 1min 31s


Exception after Quit from FormFlow dialog.

In the source code I can see that if the direction of the next step of FormDialog is StepDirection.Quit then an exception is thrown and the message Sorry, my bot code is having an issue is sent to the chat.
But as a user, I don't want to see Sorry, my bot code is having an issue. message after quit from the dialog. Is there any ability to change this behavior?

You can catch the FormCanceledException in the method you specified as the resumption method after calling the child form dialog.

Will, thank you for the reply! After the handling of FormCanceledException everything works as expected. But I'm just curious, why a user should see this message after quit by default? And why the exception is throwed despite the fact that bot's state is ok and it can consume and handle further messages?
Here is some code example for those who will face with this problem:
[LuisIntent("YourIntent")]
public Task ProcessIntentAsync(IDialogContext dialogContext, LuisResult luisResult)
{
    var dialog = FormDialog.FromForm(YourForm.BuildForm, FormOptions.PromptInStart);

    dialogContext.Call(dialog,
        async (context, result) =>
            {
                try
                {
                    await result;
                }
                catch (FormCanceledException)
                {
                    context.Wait(MessageReceived);
                    return;
                }

                context.Wait(MessageReceived);
            });

    return Task.CompletedTask;
}

This was a feature request from customers--they wanted to be able to know where people were quitting from forms.  Exceptions provide a way of communicating that information "out of band".

I'm following along in the sandwich maker example - and while I can handle the sandwich maker quit exception ... it continues afterward to give me an Exception: Form quit {File of type 'text/plain'] - where do I catch this to prevent it from showing up afterward?


Default missing options to empty string

I was getting a fromJust error running against my own template (http://github.com/joefiorini/hi-elm). I wasn't able to figure out which option was Nothing, but I felt it would be safer to default it to empty string instead of having the program crash.

Thanks, I'll take a look into this on this weekend.

I felt it would be safer to default it to empty string instead of having the program crash

Indeed. I merged your commits in  6c405815a3bfeb5a1ea2f596fea3a83acbb3c112.
But I felt it's more safer to keep it as-is, so I changed the behaviour a bit in following commit c2afde0bc387d04eac72d5b8fa18e2228fb3a410.
Anyway, thank you very much for pointing out this and contribution! Please let me know if you have further problem.


Warped depth map on D405

Required Info

Camera Model
D405

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 22.04

Platform
PC

SDK Version
2.53.1

Language
python

Issue Description
My D405 has a warped depth map: If I position the camera normal to a plane that is 203.7mm away from the camera, it reads 203.7mm at the middle, but closer to the edges of the FOV, I'm seeing it go up to 207mm.
The textured target from the self-calibration docs is on the plane, stuck with an adhesive, so texture should not be an issue.
I've tried running the on-chip calibration in both intrinsic and extrinsic mode, in addition to running the tare calibration and the dynamic targeted calibration, none fix this issue.
The cameras in my company are mounted on an outdoor robot, and experiences heat fluctuations and vibrations, so I'd like a reliable way to restore calibration on these cameras.

Hi @Robertleoj  The On-Chip tool improves depth image quality, whilst Tare is the one that improves depth accuracy.
There is not necessarily a problem with the calibration of your camera though.  Accuracy of the depth value of coordinates does tend to drift at the edges of an image compared to the center.
When you performed a Tare calibration, if you did the calibration in the RealSense Viewer tool then did you click the Get button to customize the calibration to the distance that you had positioned the camera from the target image, please?  If not then further information can be found at https://github.com/IntelRealSense/librealsense/issues/11476#issuecomment-1441647959
If you wish to try to reset your camera's calibration to its factory-new default values then you can do so using instructions at https://github.com/IntelRealSense/librealsense/issues/10182#issuecomment-1019854487

Hi @Robertleoj  Do you require further assistance with this case, please? Thanks!


NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

[X] Is your initial contribution a single, squashed commit?

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

A pre-built docker image can be found here: samhjelmfelt/nifi-fn:latest

Here is a Apache OpenWhisk quick-start that comes preconfigured for NiFi-Fn. I will work to improve the documentation of this runtime option.
https://github.com/SamHjelmfelt/OpenWhisk-YarnDeployment
Note that this project also has support for OpenWhisk on YARN, making event-driven, ephemeral NiFi-Fn flows on Hadoop possible.

Bringing in changes from @markap14. Still more to be done such as docker.

Still no design doc.   The documentation in the readme or somewhere else should do more than describe the parameters of this module, they should document what it addresses and why you would use it.
"There are times when you want to do ${THING} and an environment like %{ENV}, but using NIFI ${PROBLEMS}.  Nifi-FN addresses this by adding the ability to ${SIZZLE} and .........."

Still no design doc. The documentation in the readme or somewhere else should do more than describe the parameters of this module, they should document what it addresses and why you would use it.
"There are times when you want to do ${THING} and an environment like %{ENV}, but using NIFI ${PROBLEMS}. Nifi-FN addresses this by adding the ability to ${SIZZLE} and .........."

Sam has shared this with a few of us offline and it's a very compelling story. Hopefully he can condense it into an appropriate form to share here.

how is this different than was in his proposal email thread?
we have that thread, the jira, a pr with lots of code and collab going...

Sorry, I was referring to the mailing list email. I think with the provided code, the email has more context and makes sense. I remember reading the email and not understanding the environment this would fit into.

A copy of the latest docker image can be found here: samhjelmfelt/nifi-stateless:1.10.0-SNAPSHOT. It is 1.71GB, and the NARs are already un-packed. The API is the same as before and documented in the README file.
Not sure what is needed to push this into apache/nifi-stateless on docker hub.

@SamHjelmfelt I know this has taken a while to get everything resolved, but it's a great contribution! Many thanks for sticking with it until we got it all sorted out. I've now merged to master! There's still plenty to do here, of course, but I've run several flows with it, and I think it's in good enough shape to go ahead and merge. Thanks again!

Merged!

So no on the documentation then or writeup then eh?


Disabling Pydantic Error

:rocket:
This description was created by Ellipsis for commit bfe086baf2e3470bfcefeabdb1e9abe361720c16

Summary:
Added disable_pydantic_error_url function to remove URLs from Pydantic error messages, updated documentation, and included tests.
Key points:

Added disable_pydantic_error_url function in instructor/utils.py to disable URLs in Pydantic error messages by setting PYDANTIC_ERRORS_INCLUDE_URL to 0.
Updated docs/concepts/reask_validation.md with a section on optimizing token usage by disabling Pydantic error URLs.
Added test_pylance_url_config in tests/test_function_calls.py to verify the removal of URLs from Pydantic error messages.
Modified example in docs/concepts/reask_validation.md to demonstrate the usage of disable_pydantic_error_url.

Generated with :heart: by ellipsis.dev

@ssonal I forked your previous branch and made the function opt-in Instead. Wasn't able to get the CI working for your branch for some reason.

This solves issue #509 and is based off #662.


Refactor resolve relations

In #512, we resolved column names from UnresolvedRelations by wrapping it with SubqueryAlias.
We now refactor this logic so that the qualification phrase and resolving phrase are separated more elegantly.

/run-all-tests


Make analyzer_cli testable on the bots.

From @pq on June 3, 2015 20:45
Net-net: make it's deps play nice with third_party.  Specifically, address our dep on mockito.
Copied from original issue: dart-lang/analyzer_cli#25

From @jmesserly on June 4, 2015 22:35
curious what the issue was? (I'm going to be running into this for dev_compiler, probably :) )

Once done, we can move it back into pkg_tested.

Ah!  Well, the primary issue is that I used mockito for testing and that's not in DEPS (and so not in third_party).  Since pkg_tested packages run tests this dev dependency borked the bots.  Options include removing our use of mockito or getting it in the repo (either by mirroring it or by pulling it into dartlang).
As for dev_compiler the salient bit is that your tests will run if it lives in pkg_tested in which case you'll need to vet your test dependencies in addition to your regular ones.  Having spent a bunch of time in the last weeks wrestling with this I'm more than happy to help.  Let me know if you want to take me up on it!

Closing as stale.


Option to define output file name

Currently, the video name is the name of the file saved.
Could you add a feature where a filename can be passed in, like this:
YD.download([vid], filename, function(result) {
    console.log(result);
});

and the file would be saved as filename.

File name support was added in version 0.3.0.


test README.md cleanup

Add on-http pypi to pip requirements file, remove apt-get dependency.
Fix BMC credentials prompt
@RackHD/corecommitters @zyoung51 @uppalk1 @tannoa2 @tldavies

*** BUILD #59 ***
Test Name: test_node_workflows_post
Error Details: valid != succeeded
-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: INFO: Resetting dropped connection: localhost
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 1 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 2 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 3 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 4 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 5 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 6 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 7 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 8 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 9 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 10 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 11 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 12 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 13 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 14 sec(s)
tests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 15 sec(s)
tests.workflows_tests: INFO: Timed out after :15
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/RackHD/workspace/build/test/tests/workflows_tests.py", line 138, in test_node_workflows_post
    assert_equal(status,"succeeded")
  File "/usr/local/lib/python2.7/dist-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
'valid != succeeded\n-------------------- >> begin captured logging << --------------------\nurllib3.connectionpool: INFO: Resetting dropped connection: localhost\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 0 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 1 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 2 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 3 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 4 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 5 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 6 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 7 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 8 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 9 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 10 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 11 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 12 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 13 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 14 sec(s)\ntests.workflows_tests: INFO: Attempting to check the status of the posted workflow after 15 sec(s)\ntests.workflows_tests: INFO: Timed out after :15\n--------------------- >> end captured logging << ---------------------'

^^ known test error

test this please

*** BUILD #64 ***
Test Name: test_node_workflows_post
Error Details: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Content-Length': '73', 'X-Powered-By': 'Express', 'Connection': 'keep-alive', 'ETag': 'W/"49-/GkAy/z37WuOJ5YVzterIg"', 'Date': 'Wed, 20 Jan 2016 02:44:36 GMT', 'Access-Control-Allow-Origin': '*', 'Content-Type': 'application/json; charset=utf-8'})
HTTP response body: {"message":"Unable to run multiple task graphs against a single target."}

-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /api/1.1/nodes/
urllib3.connectionpool: INFO: Starting new HTTP connection (8): localhost
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/RackHD/workspace/build/test/tests/nodes_tests.py", line 304, in test_node_workflows_post
    Nodes().api1_1_nodes_identifier_workflows_post(n.get('id'),name='Graph.Discovery',body={})
  File "build/bdist.linux-x86_64/egg/on_http/apis/nodes_api.py", line 1089, in api1_1_nodes_identifier_workflows_post
    callback=params.get('callback'))
  File "build/bdist.linux-x86_64/egg/on_http/api_client.py", line 320, in call_api
    response_type, auth_settings, callback)
  File "build/bdist.linux-x86_64/egg/on_http/api_client.py", line 147, in __call_api
    post_params=post_params, body=body)
  File "build/bdist.linux-x86_64/egg/on_http/api_client.py", line 356, in request
    body=body)
  File "build/bdist.linux-x86_64/egg/on_http/rest.py", line 208, in POST
    body=body)
  File "build/bdist.linux-x86_64/egg/on_http/rest.py", line 177, in request
    raise ApiException(http_resp=r)
'(400)\nReason: Bad Request\nHTTP response headers: HTTPHeaderDict({\'Content-Length\': \'73\', \'X-Powered-By\': \'Express\', \'Connection\': \'keep-alive\', \'ETag\': \'W/"49-/GkAy/z37WuOJ5YVzterIg"\', \'Date\': \'Wed, 20 Jan 2016 02:44:36 GMT\', \'Access-Control-Allow-Origin\': \'*\', \'Content-Type\': \'application/json; charset=utf-8\'})\nHTTP response body: {"message":"Unable to run multiple task graphs against a single target."}\n\n-------------------- >> begin captured logging << --------------------\nurllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by \'ProtocolError(\'Connection aborted.\', BadStatusLine("\'\'",))\': /api/1.1/nodes/\nurllib3.connectionpool: INFO: Starting new HTTP connection (8): localhost\n--------------------- >> end captured logging << ---------------------'

Test Name: test_workflows_put
Error Details: False != True
-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: INFO: Resetting dropped connection: localhost
tests.workflows_tests: INFO: Adding workflow task : {'friendlyName': 'Shell Commands Hwtest_1', 'injectableName': 'Graph.post.test', 'tasks': [{'taskName': 'Task.Trigger.Send.Finish'}]}
urllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /api/1.1/workflows
urllib3.connectionpool: INFO: Starting new HTTP connection (10): localhost
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/usr/local/lib/python2.7/dist-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/var/lib/jenkins/jobs/RackHD/workspace/build/test/tests/workflows_tests.py", line 100, in test_workflows_put
    assert_equal(foundInsertedWorkflow, True)
  File "/usr/local/lib/python2.7/dist-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
'False != True\n-------------------- >> begin captured logging << --------------------\nurllib3.connectionpool: INFO: Resetting dropped connection: localhost\ntests.workflows_tests: INFO: Adding workflow task : {\'friendlyName\': \'Shell Commands Hwtest_1\', \'injectableName\': \'Graph.post.test\', \'tasks\': [{\'taskName\': \'Task.Trigger.Send.Finish\'}]}\nurllib3.connectionpool: WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by \'ProtocolError(\'Connection aborted.\', BadStatusLine("\'\'",))\': /api/1.1/workflows\nurllib3.connectionpool: INFO: Starting new HTTP connection (10): localhost\n--------------------- >> end captured logging << ---------------------'

:+1:

:+1:


Landing sound effect plays when reaching peak of jump

Seems that whenever the jump animation finishes (no double jump), it will play the landing sound effect.
https://user-images.githubusercontent.com/6926057/183266184-2650e53a-f529-4337-9727-1debe468092a.mp4

https://github.com/webaverse/app/pull/3402

fixed in this PR
https://github.com/webaverse/app/pull/3402

Duplicate: https://github.com/webaverse/app/issues/3481

Fixed


Migration window error: Unable to load the icon: 'd_TimelineEditModeRippleOFF'

Describe the bug
When opening the migration window in 2.4, I get the following error in the Unity editor, and am not able to select a scene to migrate my assets.

To reproduce
Steps to reproduce the behavior:

Open my 2.3 project, import MRTK 2.4 following upgrade steps
Import the tools package
Open the Migration window
Try to select a scene to perform upgradde

I noticed the error and am not able to select a scene to perform the upgrade.
Your setup (please complete the following information)

Unity Version 2019.3.13f1
MRTK Version 2.4. Upgrading from 2.3 to 2.4

Fixed via https://github.com/microsoft/MixedRealityToolkit-Unity/pull/7925


Rename StringUnlocalized

This PR fixes #137. It renames StringUnlocalized to StringNoLocale, and StringInLocale to StringWithLocale. The previous names remain available to avoid forcing Pod Manager to make lots of changes, but they're not documented.

[x] I've added a unit test to test for potential regressions of this bug. (They're the lame ones that were required by Jest, but :shrug: )
[x] The changelog has been updated, if applicable.
[x] Commits in this PR are minimal and have descriptive commit messages.

Ah right, British vs. American spelling. That said, given that it's prose, I suppose it's fine - I'd use "one integer" rather "IntegerOne" in tests as well :)

We did go over that, in Slack, I believe. I'd prefer not to repeat that discussion all over again...


.NET standard 1.4 librarys are unable to load Microsoft.NET.Test.SDK nuget packages v15.0 or newer

Description

Attempting to install Microsoft.NET.Test.SDK nuget package to new C# .Net standard 1.4 class library fails with an unspecified error. Attempt was made so that Live Unit Testsing could be ran from the .NET Standard project rather than a test project like how .NET Core projects work.

Steps to reproduce

Using latest VS 2017 d15rel builds with .NET Desktop Development and .NET Core workloads.
Create a new C# .Net Standard class library.
Navigate to the NuGet project manager, browse for Microsoft.NET.Test.Sdk and attempt to install it.

Expected behavior

The package installs successfully.

Actual behavior

The following output appears
Restoring packages for C:\Users\v-masche\source\repos\ClassLibrary1\ClassLibrary1\ClassLibrary1.csproj...
  GET https://api.nuget.org/v3-flatcontainer/microsoft.net.test.sdk/index.json
  OK https://api.nuget.org/v3-flatcontainer/microsoft.net.test.sdk/index.json 262ms
  GET https://api.nuget.org/v3-flatcontainer/microsoft.net.test.sdk/15.0.0/microsoft.net.test.sdk.15.0.0.nupkg
  OK https://api.nuget.org/v3-flatcontainer/microsoft.net.test.sdk/15.0.0/microsoft.net.test.sdk.15.0.0.nupkg 6ms
  GET https://api.nuget.org/v3-flatcontainer/microsoft.testplatform.testhost/index.json
  OK https://api.nuget.org/v3-flatcontainer/microsoft.testplatform.testhost/index.json 245ms
  GET https://api.nuget.org/v3-flatcontainer/microsoft.testplatform.testhost/15.0.0/microsoft.testplatform.testhost.15.0.0.nupkg
  OK https://api.nuget.org/v3-flatcontainer/microsoft.testplatform.testhost/15.0.0/microsoft.testplatform.testhost.15.0.0.nupkg 6ms
Installing Microsoft.TestPlatform.TestHost 15.0.0.
Installing Microsoft.NET.Test.Sdk 15.0.0.
Package restore failed. Rolling back package changes for 'ClassLibrary1'.
Time Elapsed: 00:00:02.4604549
========== Finished ==========

Environment

Windows 10 x64 Pro. Version 1703 OSBuild 15063.413
D15Rel 26709.00

Additional context from @ManishJayaswal from original bug in Testimpact repo:

.NET standard is just a standard. It does not mention what runtime to use at execution time. The idea was that the app referencing the lib should mention a runtime that is compatible with .NET Standard version mentioned in the lib. Then the lib will run on the same runtime as the app.
As far as testing for .NET standard lib by itself is concerned, there is currently a gap, in the sense that there is no good way to test it. For e.g. if you do what I have mentioned above ( where the app is a test project) then the lib will only run on the runtime mentioned in the app. However that does not mean that lib has been tested against all runtimes which the given version of .NET standard supports. We are trying to design an experience which can address this gap i.e. also have a .NET standard test project and users can specify what runtime they want the tests to use when they execute the tests.

How do we expose this in the CLI? Could it be dotnet test -p:DeployTargetFrameworks=net46 to target a netstandard test project to run with net46 runtime, or probably a separate switch to dotnet test. The publish should be triggered from dotnet test in this flow.
Keeping @livarcocc @pvlakshm in this discussion.

At the CLI level I would expect to be able to essentially publish a NS library now. This proposal at its core essentially allows publish to apply to libraries for now.
There is some discussion about how we pre-restore the various TF. But assuming they are present, then publish should just work.

This is being tracked external to this repo here:
https://developercommunity.visualstudio.com/content/problem/145915/net-standard-14-librarys-are-unable-to-load-micros.html


Cant write dataframe with timestamp  into influxdb

impot data from pandas dataframe to influxdb, but only get a measurement name, fields get nothing
with InfluxDBClient(url, token, org) as client:
    with client.write_api(success_callback=success_cb,
                          error_callback=error_cb,
                          retry_callback=retry_cb) as write_api:

        write_api.write(bucket=bucket, org="benz", record=Point.measurement("h2o").field("val", 1).time("2009-11-10T23:00:00.123456Z"))

I've tried a lot of timestamp formats but none of them work.
there is no error output,but the fields still have no data

Operating System:
-win10
Code Editing Tool:

spyder

I find that I choose a wrong time rage and wrong agreegate function in UI


Add rules for BREAK, CONTINUE

Handle BREAK and CONTINUE. Possible rules (update old or create new):

Do not name keyword after reserved words (#570)
Do not use BREAK, CONTINUE outside FOR, WHILE or TRY EXCEPT (check how it works - possibly prohibit in finally) (#562)
Recommend to use them inside IF statement (otherwise the code after them will be dead)
Label Exit For Loop, Exit For Loop If, Continue For Loop, Continue For Loop If as deprecated and suggest using BREAK or CONTINUE. (#576)

Closing, because the point 3. was moved to #810.


Incorrect detection of short-form function

@test Array(a) .+ Array(b) == Array(c)

from https://juliagpu.org/2020-11-05-oneapi_0.1/:

fixed by 87304ed30fae92a803e0ea2fbe7b7d7e13c3a91c

cc @maleadt

Awesome, thanks! Deployed to https://juliagpu.org/2020-11-05-oneapi_0.1/#kernel-programming, looks better now :-)


Pull request: Fix to allow putting an env var in baseId field

Hi @moriuchi !
The simplest way to set up the environement variable in node-red is in the settings.js file, just add:
process.env.AIRTABLE_BASEID = "12345";
To make sure it is rightly referenced in Node-Red, you can use an inject node set to "env variable" with a value of "AIRTABLE_BASEID". If this corectly prints "12345", then in the airtable node you should be able to use the env var syntax in the baseId and apikey fields. The env var syntax is "${AIRTABLE_BASEID}"

Also included in this PR is a fix for issue https://github.com/joeartsea/node-red-contrib-airtable/issues/10

Hi Hugobox,
Thank you for the detailed instructions on how to set environment variables in Node-RED.
I was able to refer to the environment variables set in BaseId successfully.
I also confirmed that the problem of splitting into multiple arrays when the output type is "All records in 1 array" has been resolved.


Add a basic frontend for experimentation

Hiya! Cool language you've got here 😄
When I just cloned the repo, my first thought was cargo running the compiler to play around with it a bit. I wound up finding the frontend implementation in aspen and thought it'd be nice to make things easier for future curious peeps

Oh and you can take this as a test that everything runs on Windows no problem!

Hiya! Cool language you've got here 😄

Thanks!

When I just cloned the repo, my first thought was cargo running the compiler to play around with it a bit. I wound up finding the frontend implementation in aspen and thought it'd be nice to make things easier for future curious peeps

Yeah, this is generally an issue people who are getting started with Passerine run into. Currently, the way I play around with Passerine during development is through the snippets test folder. This, however is less than ideal.
As mentioned in #34, the lex, parse, ... pattern is pretty common when embedding Passerine. I think we should factor a number of helper functions out into lib.rs, then use those for running.
I'm going to merge this PR now; we can most likely simplify it later once the helper functions are implemented. (Oh, and I'll add that it works on Windows to the readme 😉)
Thanks a million!


The hangman game

Proposal:
Proposal written by Denarioyt
What is the title of your proposal?: The hangman game
Is it a suggestion for the website or for the bot?: For the bot
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): It‘s simply the classic hangman game
Why should we add this feature?: I think it would be a good game like (?math)
ReportID: 146

➤ LenoxBot commented:
Approve:
good idea
Wandi#9576

➤ LenoxBot commented:
Approve:
Good idea!
🎃SaVaGeCrEePeR28 | Furkan🎃#3532

➤ LenoxBot commented:
Approve:
agree with wambo
Dadi#7808


Update to .NET 7

This needs to be resolved or worked around: https://github.com/dotnet/runtime/issues/76930


Switch to yarl for building the request URL

Proposed Changes
aiohttp is going to convert it to a URL object internally and its a bit more efficient to pass a URL object to request

Note that I don't have a good way to test this since HA is still using b1

Thanks


Remove missing test call for marking cluster as success

Jenkins was keeping an artifact for these tests even when they were successful.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4791/
Test PASSed.

alluxio-bot, merge this please.


Workaround rust-lang/rust#41478.

Replace all impl .. for Struct<<A as Angle>::Unitless> by Struct<A::Unitless>.
This allows -Zsave-analysis to work, and I think this is more readable too.

Nice! I have the <T as Trait>::U stuff around in some places because I was having to work around Rust requiring me to be more explicit... maybe that has improved within that time? Would be interesting to see if any more of my annotations could be removed.

@brendanzab Can you publish 0.14.1? :)

Waiting for #411 to pass now! :)

Oh, I remember, it was this issue: rust-lang/rust#24092


Feature: Display diffs against commit history from git: log

When the show_log_output_options setting is set to true, on selection of a commit from the git: log quick panel, a user can choose from the following options:
Show commit: Display the commit
Show diff: Display the diff between the commit and the working tree
Show diff (cached): Display the diff between the commit and staged changes
Closes #172

Hmm... I really like this.  My gut reaction was to dislike the extra step, but seeing as "Show commit" is the default selection, an extra Enter keypress is pretty negligible.  I'd say remove the configuration option altogether, and make this the only behavior (making sure to preserve "Show commit" as default action).
Only other thing I'd like to see changed here is the selection text for the second and third options.  Show diff doesn't tell me enough, as the user, what it is I'll be looking at.  I'd have to consult the documentation.  Let's change this to Compare commit against working directory and Compare commit against index.

@divmain Sure, it's nicer not to introduct an extra setting anyway, I'm just hesitant to change existing behaviour in unsolicited pull requests ;)
Setting removed, selection text updated, docs updated, and commits squished.

Looks great, thanks @ddevlin!


Change PhoenixFireModel to use Grid output as well as ISO

From @dhixsingh on August 14, 2018 23:44
For the fire, the ISO files are probably not the ones we should be using given that they are smoothed outputs of the Phoenix run. We should switchover from ISO to Grid Phoenix output for the fire instead. That will mean that the visual of the fire over the landscape will look "blocky", but it is infact the more accurate output and what is used for analysis at DELWP. Switching to that will ensure that we are consistent in the use of the Phoenix output in the simulation model with how it is currently used across the board. This is now important, since the BDI population reacts to the fire shape, so what shape we use matters in terms of the simulation results.
Copied from original issue: agentsoz/bdi-abm-integration#53

Available since 8ea4e50.


chore(deps): bump

Applied mkpr on undefined
sed s/"local-repository-provider": "^.*"/"local-repository-provider": "^7.0.24"/

:tada: This PR is included in version 10.0.28 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


StatefulSetAutoDeletePVC introduction version should be 1.23

This is a Bug Report

Problem:
On:
https://github.com/kubernetes/website/blob/main/content/en/docs/reference/command-line-tools-reference/feature-gates.md?plain=1#L204
StatefulSetAutoDeletePVC is listed as being introduced in 1.22, however it was introduced in 1.23: https://kubernetes.io/blog/2021/12/16/kubernetes-1-23-statefulset-pvc-auto-deletion/
Proposed Solution:
Update it to 1.23
Page to Update:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

/assign

/assign

@ayushpatil2122  PR  for this issue is already opened by @Coderayush13. Here is PR: #40893

/triage accepted

/unassign @ayushpatil2122
/assign @Coderayush13

I think this issue is fixed by #41059 and hence we can close this issue

/close


Seeking New Ownership!

This project is no longer actively maintained. If you are interested in taking it over, please comment below. Highlight any contributions you have made to the project, as well as any other examples of your open source work. Thanks!

@geekdave right now we're estimating if this lib could be a good approach for using in our project. if the team agrees on it, we'll use it quite a lot, and i could take over maintaining it at github.

@amakhrov great!  please

Oops, closed by accident.
Great, @amakhrov !  Please let me know what you'd like to do.

I'm interested and available to maintain it - my team and I actively use Backbone.Subroute across our tool and I created and maintain backbone-subroute-rails. I'd be happy to take the reigns from here onward - please reach out and let me know how you would like to proceed - thanks!

@amakhrov - Added you to the maintainers group, so you should now have push access & ability to merge PRs.  Thanks for volunteering!
I'll leave this call for maintainers open, in case anyone is interested in co-maintaining.  @amakhrov any interest still?

@geekdave sorry, we decided to try another library for routing (pushStateTree in case someone's interested)

@geekdave Thanks so much :D


[Feat]: Adding Login/Sign-in Page

What feature?
I have an idea -
Hello @JasonDsouza212 ,
Adding a login/sign in is a great idea like after that if a user logined that time he/she can see all the bookmarks and we can also connect the Login btn with Oauth for connecting the user to the wesbite and after that we can display the name of the user.
Please assign me this so I can work for it.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@SyedImtiyaz-1 as there is no database, we can't achieve that functionality


Fix query history container icon

Fixes https://github.com/microsoft/azuredatastudio/issues/20193
I had put in a stub file but forgot to actually follow up with getting an icon. I didn't see a good one to use in our product icons so using this as a temporary standin and will follow up with getting a better one from design.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 42.128%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
28190

Relevant Lines:
62540

💛  - Coveralls


NGINX and ModSec Phases

When using Atomicorp rules their IP threat intelligence do not trigger when in phase 2, yet if I update the rules to use phase 1 they work fine; why ? what phases does the NGINX implementation work with ?

Hi @uxbod,
Not sure how Atomicorp IP threat intelligence works. I am afraid I have to ask for the rule, otherwise it will be very difficult for me to tell.
I can tell the phases should work in a similar way. In order to check if variables are filled or not you may want to use the DebugLogs.

Hello Filipe.
This has never triggered:
SecRule REMOTE_ADDR "@rbl threat2.atomicrbl.com." \
"phase:2,t:none,deny,status:403,log,auditlog,msg:'Atomicorp.com WAF Rules: Threat Intelligence Match for Spamming Source on Atomicorp Threat Intelligence RBL (TI-2). See this URL for details http://www.atomicrbl.com/lookup',severity:'3',setvar:ip.threat2=1,expirevar:ip.threat2=1800,id:355501,rev:2,tag:'no_ar'"
and I started to wonder why when this one did:
SecRule REMOTE_ADDR "@rbl xbl.spamhaus.org" \
"phase:1,t:none,deny,status:403,log,id:350000,rev:2,msg:'Global RBL Match: IP is on the xbl.spamhaus.org Blacklist (Report False Positives to www.spamhaus.org)',severity:'3'"
so I changed the phase to be :1 and now it is hitting.
Thanks, Phil
----- On 30 Oct, 2015, at 20:22, Felipe Zimmerle<EMAIL_ADDRESS>wrote:

Hi @uxbod ,

Not sure how Atomicorp IP threat intelligence works. I am afraid I have to ask
for the rule, otherwise it will be very difficult for me to tell.

I can tell the phases should work in a similar way. In order to check if
variables are filled or not you may want to use the DebugLogs.

—
Reply to this email directly or view it on GitHub .

Hi @uxbod,
Can you try to match some random content against the variable "REMOTE_ADDR"? Doing that with the DebugLog enabled will help us to understand if the variable is being filled or not.


Content topic form not cleared

Expected behavior:
After a topic entry has been added to the list, the form is cleared
Actual behavior:
The content topic form is not cleared after an entry has been added.

Fixed with commit 05b26d9


Slim mode (enhancement)

Really nice extension thank you, I use it every day 👍
Can you please make a slim option to reduce vertical height?
Like this: https://github.com/mejobloggs/EditorBar
But I don't know how to make it work with the setting to turn on/off

Very nice, thank you 😁


creating snmpv3 users fails with passphrases containing spaces

Fix is simple, in manifests/snmpv3_user.pp
if $privpass {
$cmd = "createUser ${title} ${authtype} \"${authpass}\" ${privtype} \"${privpass}\""
} else {
$cmd = "createUser ${title} ${authtype} \"${authpass}\""
}

Merged.

Shipped v3.5.0 to the Forge.


added subtitle in FeedInfo - atom only

In youtube atom feed, instead of description they are using subtitle so I created info.subtitle to support it. Please have a look cheers.

Sorry I realized that subtitle is not part of the standard so I'll come up with some other solutions to support these extra fields, instead of hardcoding properties in.


Question : What is asset/models (where is this directory located) ?

This question is related to the step 3 of the installation:
"Step 3: Use the plugin. See the example app for the complete usage.
Note: You need to obtain a tflite model and scorer file to use the plugin. You can download the files from the DeepSpeech repository. Once downloaded, place the files inside assets/models/ directory of your project. The models are not loaded from the assets directory directly, but are copied to the app's external files directory first and then loaded from there (See the example app). The copying of the files is not handled by the plugin."

I figured it out. These are simply Flutter assets directories.


Document and add macros for additional DSA options

EVP_PKEY_CTRL_DSA_PARAMGEN_Q_BITS and EVP_PKEY_CTRL_DSA_PARAMGEN_MD are only
exposed from EVP_PKEY_CTX_ctrl, which means callers must write more error-prone
code (see also issue #1319). Add the missing wrapper macros and document them.

Checklist

[x] documentation is added or updated

Backported to 1.1.1 via #10094.


the game will not load

when I try to launch SCP SL itself will Smod2 it shows that it isnt loading anything with task manager, in order to fix it i have to validate my files and reinstall Smod2 only for it to happen again. plz fix

This is probally not worth opening an issue on the github for. Try asking someone in discord instead and give them lots of information about your problem.


[Feature request] support for shebang #/usr/bin/env just --justfile at top of file

Hello, thank you for sharing your work on justfile syntax!
The just docs and readme mention that adding a shebang #!/usr/bin/env just --justfile works wll at the top of executable justfiles.
I've noticed that sometimes tree-sitter-just does not interact well with a shebang at the top of the justfile -- the syntax highlighting can go wrong once I add the shebang. Is this because this package treats shebangs specially?
Here is an minimal example of a justfile for which the highlighting is off (when viewed in Neovim with this package enabled):
#!/usr/bin/env just --justfile

export BLA := "humbug"

foo:
  BAR="abc"

Added in  #40, thanks!


Learn Typography by building a Nutrition Label:Step 22

Describe the Issue
In this ,we have to add span tag in between p tags and if we give spacing between text present in p tags only then the test cases is accepted.
This case will work:-
    //

      //
Nutrition Facts

      //

      //
8 servings per container

      //
Serving size 2/3 cup (55g)

    //

But This will not work:-
    //

       //
Nutrition Facts

       //

       //
8 servings per container

       //
Serving size 2/3 cup (55g)

     //

we can add a new test case which could allow the second one too or can add a description regarding it.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-typography-by-building-a-nutrition-label/step-22
Your code
 //

      //
Nutrition Facts

       //

       //
8 servings per container

       //
Serving size 2/3 cup (55g)

     //

Expected behavior
This should have been worked or we could actually tell the user to rectify the spacing
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]
Laptop
Windows 11
Brave

Additional context
No response

how to add html code it is showing the executed code

@MahijithMenon I have update your post, to show html

In step https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-html-by-building-a-cat-photo-app/step-24 has similar instructions, because campers do face this earlier, I don't think we should change the description.

@MahijithMenon, it would be good to close the issue if no PRs are needed.

@hanswang123456 I disagree

I don't know how much of a problem there is here. Using the code that will not pass above (
Serving size 2/3 cup (55g)
), you get the hint:

Your span element should have the text 2/3 cup (55g).

So that should let users know to remove the space. If you then remove the space to use this code:
Serving size2/3 cup (55g)
 - the hint is:

Your p element should still have the text Serving size 2/3 cup (55g).

Which should let them know that they need a space.
A quick forum search shows a few people adding that space, but many others that do it wrong - like including size in the span or something. I would be fine with making the tests a little more lenient on that space if we want.

@moT01, removing the leading/trailing white space from the span assertion could be an option. That way, the test only has to confirm the correct text(leading/trailing space) and let the general p tag test handle any spacing issues.

Alright, I'm going to open this up for help. We want to change the test so it allows a space at the start of that span, but keep the test for the paragraph so the sentence is correct. It's the third test in this file

I don't know how much of a problem there is here. Using the code that will not pass above (
Serving size 2/3 cup (55g)
), you get the hint:

Your span element should have the text 2/3 cup (55g).

So that should let users know to remove the space. If you then remove the space to use this code:
Serving size2/3 cup (55g)
 - the hint is:

Your p element should still have the text Serving size 2/3 cup (55g).

Which should let them know that they need a space.
A quick forum search shows a few people adding that space, but many others that do it wrong - like including size in the span or something. I would be fine with making the tests a little more lenient on that space if we want.

When you are describing like this it's make sens but inside the hint for the test say :
Your span element should have the text 2/3 cup (55g).
But people can misinterpret, thinking that the span element must contain the text and not the exact text without space. After all  2/3 cup (55g) contains 2/3 cup (55g).

I think the test could be change from :
assert(document.querySelector('span')?.textContent === '2/3 cup (55g)');

to
assert(document.querySelector('span')?.textContent.includes('2/3 cup (55g)'));

I add an image to illustrate :

code snippet

Nutrition Facts

8 servings per container

Serving size  2/3 cup (55g)

@Xavier-Pierre-dev, it might be better to remove spaces then check for exact occurrence of '2/3 cup (55g)' . This way if campers insert unwanted text, it won't pass.
Maybe something like:
assert(document.querySelector('span')?.textContent.trimStart() === '2/3 cup (55g)'); to remove whitespaces at the start.
And then do assert(document.querySelectorAll('p')?.[1]?.textContent === 'Serving size 2/3 cup (55g)'); so you have the correct textContent inside the p tag.

I'm not sur to understand your point if you remove all the space then 2/3cup(55g) will also pass.

In fact with includes i already check if the text contains exactly 2/3 cup (55g). I put a gif to illustrate

Includes doesn't check for letters added to the start or end which can make error messages less specific.

One issue I saw when I looked on the forum was people doing something like this:
Serving size 2/3 cup (55g)
 (they put size in the span, not supposed to)
So using .includes would allow that to pass. I don't think we should be that lenient. Extra spaces, sure - extra text, I don't like it. I am fine with removing the whitespace before (and after?) the text content. Either way works for me.

@moT01 for the assertion on the p tag: assert(document.querySelectorAll('p')?.[1]?.textContent === 'Serving size 2/3 cup (55g)'), it seems like textContent is more specific than innerText:

yes exactly but I think this is exactly what the hint ask here
Your span element should have the text 2/3 cup (55g).
and 2/3 cup (55g) something contain 2/3 cup (55g)
otherwise the hint should be changed to :
Your span element should only contain 2/3 cup (55g).
in this case i think I think regex will be better :

code snippet

Nutrition Facts

8 servings per container

Serving size 2/3 cup (55g)

@Xavier-Pierre-dev, regexes do work. Include 1 optional whitespace at the start of the string so there is more flexibility for users. I think that would work well in conjunction with the p tag assertion.

so here difference beetween the regex is that we can easily allow white space before and after the string so it's more near to
Your span element should only contain 2/3 cup (55g).
but at the same time the hint say :
Your span element should have the text 2/3 cup (55g).
and in this case I think the example I provide with include should work because 2/3 cup (55g) something contains 2/3 cup (55g) so that's already follow the hint provided and link to this test.
I'm not sur if one solution is better than the other I think both will work

I think only allowing whitespaces before the element works best. So something like your second version. document.querySelector('span')?.textContent.match(/^(\s|)2\/3 cup \(55g\)$/)

I think only allowing whitespaces before the element works best. So something like your second version. document.querySelector('span')?.textContent.match(/^(\s|)2\/3 cup \(55g\)$/)

yes I think also I was editing my comment at the same time to add this.

Feel free to open a PR and reviewers can review the code.


onDidChangeVisibleTextEditors breaks after adding second workspace

VSCode Version: Code - Insiders 1.18.0-insider (c1e079b6ccfad9ead105c44a84e862ffc5250222, 2017-10-25T04:18:36.616Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

gitignore
cod
0.5.0

bracket-pair-colorizer
Coe
0.10.12

githistory
don
0.2.3

tslint
eg2
1.0.12

csharp
ms-
1.12.1

debugger-for-chrome
msj
3.4.0

Steps to Reproduce:

Using https://github.com/Microsoft/vscode-extension-samples/tree/master/basic-multi-root-sample
Add the following lines to the activate function:

context.subscriptions.push(window.onDidChangeVisibleTextEditors(e => {
        console.log("Changed") // Put breakpoint here
    }));

Press f5 to start debugging
Open a folder
Click around some files, notice onDidChangeVisibleTextEditors is being triggered
File -> Add folder to workspace
Click around some files, notice onDidChangeVisibleTextEditors is no longer triggered

Maybe related to the extension host restart?
@CoenraadS we do not activate your extension again after a restart, so maybe your extension is not activated in this case? What is your activation configuration for the extension?
@alexandrudima I assume my statement is right, we are not re-activating extensions that were activated before restarting the extension host?

The other events do fire (e.g. onDidCloseTextDocument), its just onDidChangeVisibleTextEditors doesn't.
Mine activates on *

I'd say this is a problem with the debugger as I do see those messages being printed

I will see if I can make a video

If we ignore the debugger and just look at the log in dev tools, it does not log there either after the second workspace is added. This is 100% reproducible for me every time.

This is 100% reproducible for me every time.

Please refine your steps or tell me what I am doing wrong. This my extension code and it produces the video below
    console.log('Here-6')
    context.subscriptions.push(vscode.window.onDidChangeVisibleTextEditors(e => {
        console.log("Changed -> " + e.map(e => e.document.fileName)) // Put breakpoint here
    }));

Ok I finally figured it out, it is related to the folder I am opening...
I was testing on this repo as my second workspace: https://github.com/CoenraadS/vscode-Disable-Ligatures

Open any folder
Add vscode-Disable-Ligatures as a second workspace

Then I get Error: Ignoring launch.version as launch is true as an error, but I was just ignoring it because I didn't know what it meant. But it turns out the whole extension host is now crashed or something, but I suppose it is a different issue.
Seems to have been addressed here: https://github.com/Microsoft/vscode/issues/36808
Sorry for wasting your time.

Then I get Error: Ignoring launch.version as launch is true as an error, but I didn't pay attention to this.. But it turns out the whole extension host is now crashed or something, but I suppose it is a different issue.

@sandy081 This is interesting

It's fixed in today's insiders and working fine :)
On Thu, 26 Oct 2017, 9:40 AM Johannes Rieken<EMAIL_ADDRESS>wrote:

Then I get Error: Ignoring launch.version as launch is true as an error,
but I didn't pay attention to this.. But it turns out the whole extension
host is now crashed or something, but I suppose it is a different issue.
@sandy081 https://github.com/sandy081 This is interesting
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/36915#issuecomment-339579465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVa4cjQfzYw1Px8atmlPdiJi53Q_qHYks5swDd5gaJpZM4QGT8W
.

@CoenraadS great, thanks for trying it out!

Yeah, fixed it yesterday and is available in today's insiders.


Slf4j

I hope you're open to collaborations, I'm sorry if not.
This is a small PR just to fix slf4j classpath configuration, it was not working and showed the message
No SLF4J providers were found.
Now works as expected, no message shown.
If you accept this PR yorm will no longer depend on log4j but will depend on slf4j, but since slf4j is more or less the standard logger in the java world right now, I think is an improvement.
All log4j dependencies are just test dependencies now.
Thanks for this library, I hope it becomes popular!  Do publish it please!

Thanks! Contributions are of course encouraged and welcomed, that's the spirit!


nvmeof (nvme tcp) support in nbp

What this PR does / why we need it:
add nvme-tcp csi support
Which issue this PR fixes(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)*: fixes #
None
Special notes for your reviewer:
opensds source code in vendor should be updated to the latest hotpot development branch version(the
directory vendor/github.com/opensds/opensds/contrib/connector)
Release note:
None

@ysxeric Can you please explain why this PR is closed?  Are you planning to open another PR later? Thanks.

@ysxeric Can you please explain why this PR is closed? Are you planning to open another PR later? Thanks.

Hi, I met some weird problems that attachment process in container has conflict with process in host server after pulling rebase the latest code. Therefore, I decided to reserve my feasible branch just for a demo of nvmeof.  And, in the future, I plan to open another PR  of nvmeof support for the latest nbp code.
Best Regards
Shixin Yang