Guest user file access in person to person chat

I need some clarity on one of the point in the limitations for guests - https://docs.microsoft.com/en-us/microsoftteams/guest-access-checklist

Upload files to a person-to-person chat
Eg:
A normal user initiates a one-to-one/one-to-many chat with a guest user. In the chat the normal user attaches a file. The guest user is not able to open the file and they get error message “This item might not exist or is no longer available" when they click on the file

Should the guest user see the file or is this an expected limitation ?

@sav169 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


[fix] configure success message for configure, exec, & creds-process

testing it locally worked! I accidentally branched off of #52 , so I think this PR should be merged after that one.

@kuannie1 could you merge master to simplify the diff?

Codecov Report

Merging #54 into master will increase coverage by 0.59%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   45.96%   46.55%   +0.59%
==========================================
  Files          13       13
  Lines         879      872       -7
==========================================
+ Hits          404      406       +2
+ Misses        433      424       -9
  Partials       42       42

Impacted Files
Coverage Δ

pkg/aws_config_server/cache.go
0.00% <0.00%> (ø)

pkg/aws_config_server/webserver.go
51.61% <ø> (ø)

pkg/aws_config_server/parallelization_functions.go
34.30% <40.00%> (+1.69%)
:arrow_up:

pkg/aws_config_server/list_roles.go
60.00% <66.66%> (+2.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60efe1...bed706f. Read the comment docs.


Use new factory definition syntax

Pros

Can use symbol view/ctags to jump to the factories more easily
Can add helper functions underneath the factory they belong to
IMO it's easier to scan your factory module for a particular factory
Easier to type :)
If/when callbacks are introduced, this will allow you to put the
callback functions near the factory

Cons

A little more magic since you still call the functions with atoms,
e.g.build(:user)

Closes #101

I'm down with this, mainly for defining helper functions and callbacks near the function.
I'm not sure how often ctags would be useful since it would be rare to use the function directly.

Good point. Ctags are probably useless here, but a lot of editors have "Jump to Definition/Symbol Views" where you can jump to a function. Right now they're all called factory so this should make it easier for people using those editors (I hope :D)
I'll go ahead and merge this in. Thanks for the review!


Integrated terminal - links are not highlighted/clickable

VSCode Version: 1.17.0-insider
OS Version: macOS 10.12.6

Steps to Reproduce:

display some links in the integrated terminal
hover over with CMD pressed
expected - links to be underlined and clickable but they are not

In the latest Insider build no links are clickable for me - either path nor http links. I checked 1.16.1 on the same system and at least http links are clickable but paths are not either.
Reproduces without extensions: Yes

@mkuratczyk can you provide a screenshot of the link(s) that are not working?
Also the commit hash of the VS Code version you're on would be useful, you can see this in the about dialog, eg. 5316a2d

Hey. I just updated to the latest Insider build. I don't see the commit hash there but it says:
Version 1.17.0-insider (1.17.0-insider)
81fc22ec957de26d2bf6aada3f16f04e0164741c
2017-10-03T22:43:34.772Z
I recorded a short video to show the problem: https://youtu.be/6W5ZWXwV2nQ
I don't see any determinism here. One path actually gets highlighted and clicking it takes me to the file as expected (so do the http link that get highlighted) but still some links/path do not get highlighted.

So directories not being highlighted is intentional, http:// links should always get highlighted though so that's a bug. I don't think there's anything tracking it currently so let's track that here.


Tab Completion For Custom Aliases

System Details

posh-git version/path: modules/posh-git/1.0.0
PowerShell version: 5.1.17134.590
Git version: 2.20.1
Operating system name and version: Win 10

Issue Description
I have a git alias git dt-c ref1 ref2 file which is a short cut for 'differences between commits'.  I'm trying to modify tab completion to make it so that...
ref1 - cycles through a custom list of commit hints (head~, head~~, head~N)
ref2 - cycle through a custom list of commits and all tracked files (b/c this param is optional and they may be trying to provide a file now)
file - If they provided ref1 and ref2, this would just cycle through all tracked files
Note: I set up my alias as dt-c = !git z-dt-c where z-dt-c is a complex alias.  The reason I did this was to make the command/pattern matching easier in GitTabExpansion.
Disclaimer: My regex skills are zilch and my powershell skills aren't much better, which may stop me from doing anything in GitTabExpansion :)  I'm simply a C# developer trying to make my git experience in the command line a little more pleasant for myself and my team.
I attempted the following by basically cutting and pasting the git pull processing and trying to go from there:
        # Handles git prev/previous/dt-c <ref>
        "^(?:\!git z-dt-c)${ignoreGitParams}\s+(?<ref>\S*)$" {
            $cmdList = @()
            $cmdList += "HEAD~"
            $cmdList += "HEAD~~"
            $cmdList += "HEAD~N"
            $cmdList
        }
        # Handles git dt-c ref1 <ref2>
        "^(?:\!git z-dt-c)${ignoreGitParams}\s+(?<ref1>\S*).*\s+(?<ref2>[^\s\:]*)$" {
            $cmdList = @()
            $cmdList += "HEAD~~"
            $cmdList += "HEAD~~~"
            $cmdList += "HEAD~N"
            # How do I add tracked files?
            $cmdList += "<Tracked File>"
            $cmdList
        }
        # Handles git dt-c ref1 ref2 <path>
        "^(?:\!git z-dt-c)${ignoreGitParams}\s+(?<ref1>[^\s-]\S*).*\s+(?<ref2>\S*).*\s+(?<path>\S*)$" {
            $cmdList = @()
            $cmdList += "<Tracked File>"
            # How do I add tracked files?
            $cmdList
        }

So the problems I am facing are:

git dt-c {tab} - cycles my commit hints correctly, but it also includes staged files.  I have no idea where they are coming from.
git dt-c HEAD {tab} - is the same as the first item.  Included staged files but cycles my hints correctly.
git dt-c HEAD HEAD~ {tab} - Included everything from the second scenario plus my one additional 'Tracked File' (so there are two of those entries).

Any suggestions on how to fix this or any comments on how the system is working that I might research and try to solve myself?
Questions:

Does the order of the regex pattern matching matter?  I would assume it does since they seem to be in some sort of switch pattern matching.
Since those staged files are coming in, and I thought I was basically returning a brand new list of only my entries, is there somewhere else that controls/injects items into the list I return based on the current repository status?
I would assume the biggest (or possibly the only) cause of my problems are my regex patterns?

Well, after 4 hours of trial and error, I think I have it working.  I'll post here to see if anyone has comments on it.  Regex's were a big part of the problem.
For issue 2 above, I had another regex looking for dt which also matched when I typed in dt-c. Also, I had 'copied' the implementation of GitTabExpansion's diff|difftool syntax and it returns Index.Modified even if the command didn't include a --cached or --staged parameter. To fix my issues, I updated my regex to exclude 'dt-c' and excluded Index.Modified (wonder if the in-built diff|difftool would want to exclude as well?).  Here was my final match pattern for dt
"^(?!.\!git z-dt-c)(?:\!git z-dt) (?<files>\S*)$" {
    # gitDiffFiles returns Index.Modified no matter what.  I don't want that in my list
    # gitDiffFiles $GitStatus $matches['files'] $matches['staged']
    gitFiles $matches['files'] (@($GitStatus.Working.Unmerged) + @($GitStatus.Working.Modified))
}

For everything else, I reduced my regex case to 1 and I introduced a some helper functions to a) get my reference hints and b) to get all the tracked files in the repository.  I ended up with this:
# Handles git dt-c ref1 ref2 <path>
"^(?:\!git z-dt-c)\s+(?<ref1>\S*)\s*(?<ref2>\S*)?$" {
    if ( "$($matches['ref2'])" -ne "" )
    {
        # If typed in a 'file filter' and hit tab, only returned tracked files matching
        gitTracked $matches['ref2']
    }
    elseif ( "$($matches['ref1'])" -ne "" )
    {
        # If only first ref is filled in and they tab, return hints + all tracked files
        @(gitRefHints 1) + @(gitTracked $matches['ref2'])
    }
    else
    {
        # If tabbing immediately after the dt-c, just return hints
        gitRefHints 0
    }
}

and the helpers...
function script:gitRefHints($offset) {
    $refHints = New-Object System.Collections.Generic.List[string]

    if ( $offset -eq 0)
    {
        $refHints.Add("HEAD~")
    }
    $refHints.Add("HEAD~~")
    if ( $offset -eq 1)
    {
        $refHints.Add("HEAD~~")
    }
    $refHints.Add("HEAD~N")
    $refHints
}

function script:gitTracked($filter) {
    $git = Invoke-Utf8ConsoleCommand { (git ls-files) } |
        Where-Object { $_ -like "$filter*" } |
        quoteStringWithSpecialChars

    return $git
}

If anyone has any comments on how I should have done it.  I'd be happy for the constructive criticism.  Otherwise, feel free to close the issue.

posh-git does support simple aliases like co = checkout but no, it doesn't support this scenario.  I don't believe this is common enough to warrant adding support. I anyone feels different, feel free to re-open this or submit a new issue.


Thin export creates empty tarball on Windows

Copy the following to a bundle.cnab file in a new empty directory:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

{
  "name": "helloworld",
  "version": "0.1.1",
  "description": "",
  "invocationImages": [
    {
      "imageType": "docker",
      "image": "cnab/helloworld:0.1.1"
    }
  ],
  "images": [
    {
      "imageType": "docker",
      "image": "busybox",
      "description": "",
      "refs": null
    }
  ],
  "parameters": {
    "favouriteWomble": {
      "type": "string",
      "defaultValue": "Orinoco",
      "allowedValues": [
        "Great Uncle Bulgaria",
        "Orinoco",
        "Madame Cholet",
        "Tomsk"
      ],
      "required": false,
      "metadata": {
        "description": "Used when going underground, going overground and/or wombling free"
      },
      "destination": null
    },
    "port": {
      "type": "int",
      "defaultValue": 8080,
      "required": false,
      "minValue": 1000,
      "maxValue": 9999,
      "metadata": {},
      "destination": null
    },
    "region": {
      "type": "string",
      "defaultValue": "Wimbledon Common",
      "required": false,
      "minLength": 4,
      "maxLength": 20,
      "metadata": {},
      "destination": null
    },
    "somebool": {
      "type": "bool",
      "required": false,
      "metadata": {},
      "destination": null
    }
  },
  "credentials": {
    "secret_cert": {
      "path": "/so/very/secret",
      "env": ""
    },
    "secret_password": {
      "path": "",
      "env": "so_very_secret"
    }
  }
}
-----BEGIN PGP SIGNATURE-----

wsDcBAEBCAAQBQJb9j6OCRCpJ7BM9jT5NAAABtkMABgjy+HJ7MePUP/a17Qql0mF
taJvUvplrB8RpkJUe2TBwHokxllrQwTjJzhkp40PoznqCxrHKScqlUpQse3K/Y4h
7Mm7uqf819YcUlZUQQMv0FNIfEGCTEWgU23WO0fCxhJK50LwzDfBq/u+So5SBwlh
aAAN3PGFZSop78fI/P5bu66UUimLM+ZlLf2j9n6gRcily6Ici98QrU6x1hwZWsUk
Ta7buFXtXgHd8SQEw/f57jQ+XraX8mmY6LN9peI+BXmzLFB8S0uCNxxCw+SPXtuG
s5Ejfa9u0PF/YRfs8kAwea/0MVOgZt7Lqo0V8/891+V+ZeuOS3qwmABABpBPcy7y
ezp0m8z6R0zElNFuSTcrkQnbWqUBfBJzqhR6xmSW9xssATyDNmJ5WxhKvff7dMCN
JZ/qDP7xn2F3x4hHmyUk5ZWPtKP5950jrIuE8Z+dfF83BFLhJyrqjpPR/CnGBjmf
g5qXe7FOhQ9pXslkJrzpW2NOPD3FTnNqRiKrN2IPHg==
=Ek4J
-----END PGP SIGNATURE-----

Then do duffle export . -t in that directory.  It creates a helloworld-0.1.1.tgz file.  But the file is only 32 bytes and tar --list -f lists no files in the tarball.

I used the same bundled (signed it myself) but cannot seem to reproduce it. At first thought, I thought it could be related to windows path issues but I'm using filepath.Abs(arg). I'm not super sure what this could be but it will require a little digging.

@michelleN You are right!  It does seem to be down to using filepath.Abs but as far as I can tell you are not using that yet.  If I change export.go:99 to archiveDir, err := filepath.Abs(name + "-export") then it seems to work on Windows.


Unit numbers shouldn't show as precise

values should show as max 1 decimal place if there is no prefix

The first one should be 5.3g THC  & <0.175g CBD


Daydream support

Description:
Add support for the daydream platform

Platform / Device:
Android, Daydream view + daydream controller

Reproducible Code Snippet or URL:

Since I don't have access to android device nor daydream headset + controller, calling for help here.
Help from someone with Daydream is much appreciated!

https://github.com/michaltakac/mathworldvr/commit/a67f775ecade34ae827ca14be29ed46830266499


Update recommended-inline-policy with VPC permissions

Issue #, if available: n/a
Description of changes: Updates the recommended inline policy with permissions needed to create Lambda functions inside a VPC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

/ok-to-test


color leaking

see
https://sctech.mooo.com/img/shared/nofetch1.png
https://sctech.mooo.com/img/shared/nofetch2.png
https://sctech.mooo.com/img/shared/nofetch3.png
the colors are leaking to your username

I don't see any leaking. Could this be an issue in your display?

maybe. i don't think this is an issue after all


Selection date denying.

Hi.
How to deny the selection of previous dates or time?

Implement the logic you need in on the on-before-render call back.


Complete Activity by id

This change shows an idea how to complete activity with activity id by using existing api (with trick of TaskToken). The benefit is small maximal reuse existing code without adding too many complexity.
Another proposal by @samar is to create new APIs on server side to avoid cadence-client need to create TaskToken. This will reduce client knowledge a little bit, but leads to more functions in both server side and client side.
Client side changes as follows:
https://github.com/uber-go/cadence-client/pull/291

Changes Unknown when pulling fb9e326ff4ea955789c1a94828cd8f697f77eb94 on completeac into ** on master**.


[interactive_media_ads] AdEvent adData is always empty

What package does this bug report belong to?
interactive_media_ads
What target platforms are you seeing this bug on?
Android, iOS
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.lock
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  async:
    dependency: transitive
    description:
      name: async
      sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
      url: "https://pub.dev"
    source: hosted
    version: "2.11.0"
  boolean_selector:
    dependency: transitive
    description:
      name: boolean_selector
      sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.1"
  characters:
    dependency: transitive
    description:
      name: characters
      sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.0"
  clock:
    dependency: transitive
    description:
      name: clock
      sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
      url: "https://pub.dev"
    source: hosted
    version: "1.1.1"
  collection:
    dependency: transitive
    description:
      name: collection
      sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
      url: "https://pub.dev"
    source: hosted
    version: "1.18.0"
  csslib:
    dependency: transitive
    description:
      name: csslib
      sha256: "09bad715f418841f976c77db72d5398dc1253c21fb9c0c7f0b0b985860b2d58e"
      url: "https://pub.dev"
    source: hosted
    version: "1.0.2"
  cupertino_icons:
    dependency: "direct main"
    description:
      name: cupertino_icons
      sha256: ba631d1c7f7bef6b729a622b7b752645a2d076dba9976925b8f25725a30e1ee6
      url: "https://pub.dev"
    source: hosted
    version: "1.0.8"
  fake_async:
    dependency: transitive
    description:
      name: fake_async
      sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
      url: "https://pub.dev"
    source: hosted
    version: "1.3.1"
  flutter:
    dependency: "direct main"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_lints:
    dependency: "direct dev"
    description:
      name: flutter_lints
      sha256: "3f41d009ba7172d5ff9be5f6e6e6abb4300e263aab8866d2a0842ed2a70f8f0c"
      url: "https://pub.dev"
    source: hosted
    version: "4.0.0"
  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
  flutter_web_plugins:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.0"
  html:
    dependency: transitive
    description:
      name: html
      sha256: "1fc58edeaec4307368c60d59b7e15b9d658b57d7f3125098b6294153c75337ec"
      url: "https://pub.dev"
    source: hosted
    version: "0.15.5"
  interactive_media_ads:
    dependency: "direct main"
    description:
      name: interactive_media_ads
      sha256: "4150578a489e3c18b50959ab9830e48e778207e01131c1613bc918efa3be27f6"
      url: "https://pub.dev"
    source: hosted
    version: "0.2.3+3"
  leak_tracker:
    dependency: transitive
    description:
      name: leak_tracker
      sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
      url: "https://pub.dev"
    source: hosted
    version: "10.0.5"
  leak_tracker_flutter_testing:
    dependency: transitive
    description:
      name: leak_tracker_flutter_testing
      sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.5"
  leak_tracker_testing:
    dependency: transitive
    description:
      name: leak_tracker_testing
      sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3"
      url: "https://pub.dev"
    source: hosted
    version: "3.0.1"
  lints:
    dependency: transitive
    description:
      name: lints
      sha256: "976c774dd944a42e83e2467f4cc670daef7eed6295b10b36ae8c85bcbf828235"
      url: "https://pub.dev"
    source: hosted
    version: "4.0.0"
  matcher:
    dependency: transitive
    description:
      name: matcher
      sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
      url: "https://pub.dev"
    source: hosted
    version: "0.12.16+1"
  material_color_utilities:
    dependency: transitive
    description:
      name: material_color_utilities
      sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
      url: "https://pub.dev"
    source: hosted
    version: "0.11.1"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
      url: "https://pub.dev"
    source: hosted
    version: "1.15.0"
  path:
    dependency: transitive
    description:
      name: path
      sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
      url: "https://pub.dev"
    source: hosted
    version: "1.9.0"
  plugin_platform_interface:
    dependency: transitive
    description:
      name: plugin_platform_interface
      sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.8"
  sky_engine:
    dependency: transitive
    description: flutter
    source: sdk
    version: "0.0.99"
  source_span:
    dependency: transitive
    description:
      name: source_span
      sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
      url: "https://pub.dev"
    source: hosted
    version: "1.10.0"
  stack_trace:
    dependency: transitive
    description:
      name: stack_trace
      sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
      url: "https://pub.dev"
    source: hosted
    version: "1.11.1"
  stream_channel:
    dependency: transitive
    description:
      name: stream_channel
      sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7
      url: "https://pub.dev"
    source: hosted
    version: "2.1.2"
  string_scanner:
    dependency: transitive
    description:
      name: string_scanner
      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
      url: "https://pub.dev"
    source: hosted
    version: "1.2.0"
  term_glyph:
    dependency: transitive
    description:
      name: term_glyph
      sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
      url: "https://pub.dev"
    source: hosted
    version: "1.2.1"
  test_api:
    dependency: transitive
    description:
      name: test_api
      sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
      url: "https://pub.dev"
    source: hosted
    version: "0.7.2"
  vector_math:
    dependency: transitive
    description:
      name: vector_math
      sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
      url: "https://pub.dev"
    source: hosted
    version: "2.1.4"
  video_player:
    dependency: "direct main"
    description:
      name: video_player
      sha256: "4a8c3492d734f7c39c2588a3206707a05ee80cef52e8c7f3b2078d430c84bc17"
      url: "https://pub.dev"
    source: hosted
    version: "2.9.2"
  video_player_android:
    dependency: transitive
    description:
      name: video_player_android
      sha256: "391e092ba4abe2f93b3e625bd6b6a6ec7d7414279462c1c0ee42b5ab8d0a0898"
      url: "https://pub.dev"
    source: hosted
    version: "2.7.16"
  video_player_avfoundation:
    dependency: transitive
    description:
      name: video_player_avfoundation
      sha256: "0b146e5d82e886ff43e5a46c6bcbe390761b802864a6e2503eb612d69a405dfa"
      url: "https://pub.dev"
    source: hosted
    version: "2.6.3"
  video_player_platform_interface:
    dependency: transitive
    description:
      name: video_player_platform_interface
      sha256: "229d7642ccd9f3dc4aba169609dd6b5f3f443bb4cc15b82f7785fcada5af9bbb"
      url: "https://pub.dev"
    source: hosted
    version: "6.2.3"
  video_player_web:
    dependency: transitive
    description:
      name: video_player_web
      sha256: "881b375a934d8ebf868c7fb1423b2bfaa393a0a265fa3f733079a86536064a10"
      url: "https://pub.dev"
    source: hosted
    version: "2.3.3"
  vm_service:
    dependency: transitive
    description:
      name: vm_service
      sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
      url: "https://pub.dev"
    source: hosted
    version: "14.2.5"
  web:
    dependency: transitive
    description:
      name: web
      sha256: cd3543bd5798f6ad290ea73d210f423502e71900302dde696f8bff84bf89a1cb
      url: "https://pub.dev"
    source: hosted
    version: "1.1.0"
sdks:
  dart: ">=3.5.4 <4.0.0"
  flutter: ">=3.24.0"

Steps to reproduce

Initialize the SDK using the sample in the documentation
Check the logs for AdEvent Data

Expected results
To have a map of AdEvent Data with all the ad data.
Actual results
Empty map always.
Code sample
Code sample
import 'dart:async';

import 'package:flutter/material.dart';
import 'package:interactive_media_ads/interactive_media_ads.dart';
import 'package:video_player/video_player.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const AdExampleWidget(),
    );
  }
}

class AdExampleWidget extends StatefulWidget {
  const AdExampleWidget({super.key});

  @override
  State<AdExampleWidget> createState() => _AdExampleWidgetState();
}

class _AdExampleWidgetState extends State<AdExampleWidget>
    with WidgetsBindingObserver {
  static const String _adTagUrl =
      'https://pubads.g.doubleclick.net/gampad/ads?iu=/21775744923/external/vmap_ad_samples&sz=640x480&cust_params=sample_ar%3Dpremidpost&ciu_szs=300x250&gdfp_req=1&ad_rule=1&output=vmap&unviewed_position_start=1&env=vp&impl=s&cmsid=496&vid=short_onecue&correlator=';

  late final AdsLoader _adsLoader;

  AdsManager? _adsManager;

  bool _shouldShowContentVideo = false;

  late final VideoPlayerController _contentVideoController;

  Timer? _contentProgressTimer;

  final ContentProgressProvider _contentProgressProvider =
      ContentProgressProvider();

  @override
  void initState() {
    super.initState();
    _contentVideoController = VideoPlayerController.networkUrl(
      Uri.parse(
        'https://storage.googleapis.com/gvabox/media/samples/stock.mp4',
      ),
    )
      ..addListener(() {
        if (_contentVideoController.value.isCompleted) {
          _adsLoader.contentComplete();
        }
        setState(() {});
      })
      ..initialize().then((_) {
        setState(() {});
      });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: SizedBox(
          width: 300,
          child: !_contentVideoController.value.isInitialized
              ? Container()
              : AspectRatio(
                  aspectRatio: _contentVideoController.value.aspectRatio,
                  child: Stack(
                    children: <Widget>[
                      _adDisplayContainer,
                      if (_shouldShowContentVideo)
                        VideoPlayer(_contentVideoController)
                    ],
                  ),
                ),
        ),
      ),
      floatingActionButton:
          _contentVideoController.value.isInitialized && _shouldShowContentVideo
              ? FloatingActionButton(
                  onPressed: () {
                    setState(() {
                      _contentVideoController.value.isPlaying
                          ? _contentVideoController.pause()
                          : _contentVideoController.play();
                    });
                  },
                  child: Icon(
                    _contentVideoController.value.isPlaying
                        ? Icons.pause
                        : Icons.play_arrow,
                  ),
                )
              : null,
    );
  }

  late final AdDisplayContainer _adDisplayContainer = AdDisplayContainer(
    onContainerAdded: (AdDisplayContainer container) {
      _adsLoader = AdsLoader(
        container: container,
        onAdsLoaded: (OnAdsLoadedData data) {
          final AdsManager manager = data.manager;
          _adsManager = data.manager;

          manager.setAdsManagerDelegate(AdsManagerDelegate(
            onAdEvent: (AdEvent event) {
              debugPrint('OnAdEvent: ${event.type} => ${event.adData}');
              switch (event.type) {
                case AdEventType.loaded:
                  manager.start();
                case AdEventType.contentPauseRequested:
                  _pauseContent();
                case AdEventType.contentResumeRequested:
                  _resumeContent();
                case AdEventType.allAdsCompleted:
                  manager.destroy();
                  _adsManager = null;
                case AdEventType.clicked:
                case AdEventType.complete:
                case _:
              }
            },
            onAdErrorEvent: (AdErrorEvent event) {
              debugPrint('AdErrorEvent: ${event.error.message}');
              _resumeContent();
            },
          ));

          manager.init(settings: AdsRenderingSettings(enablePreloading: true));
        },
        onAdsLoadError: (AdsLoadErrorData data) {
          debugPrint('OnAdsLoadError: ${data.error.message}');
          _resumeContent();
        },
      );

      _requestAds(container);
    },
  );

  Future<void> _requestAds(AdDisplayContainer container) {
    return _adsLoader.requestAds(AdsRequest(
      adTagUrl: _adTagUrl,
      contentProgressProvider: _contentProgressProvider,
    ));
  }

  Future<void> _resumeContent() async {
    setState(() {
      _shouldShowContentVideo = true;
    });

    if (_adsManager != null) {
      _contentProgressTimer = Timer.periodic(
        const Duration(milliseconds: 200),
        (Timer timer) async {
          if (_contentVideoController.value.isInitialized) {
            final Duration? progress = await _contentVideoController.position;
            if (progress != null) {
              await _contentProgressProvider.setProgress(
                progress: progress,
                duration: _contentVideoController.value.duration,
              );
            }
          }
        },
      );
    }

    await _contentVideoController.play();
  }

  Future<void> _pauseContent() {
    setState(() {
      _shouldShowContentVideo = false;
    });
    _contentProgressTimer?.cancel();
    _contentProgressTimer = null;
    return _contentVideoController.pause();
  }
}

Screenshots or Videos

Screenshots / Video demonstration
https://github.com/user-attachments/assets/910a014d-88f6-4cac-b8c8-91eca7371a54

Logs
Logs
Launching lib/main.dart on iPhone 15 Pro in debug mode...
Xcode build done.                                            5.0s
Connecting to VM Service at ws://<IP_ADDRESS>:57663/lU-kTRgSU8c=/ws
Connected to the VM Service.
flutter: OnAdEvent: AdEventType.loaded => {}
flutter: OnAdEvent: AdEventType.contentPauseRequested => {}
flutter: OnAdEvent: AdEventType.started => {}
flutter: OnAdEvent: AdEventType.firstQuartile => {}
flutter: OnAdEvent: AdEventType.midpoint => {}
flutter: OnAdEvent: AdEventType.thirdQuartile => {}
flutter: OnAdEvent: AdEventType.complete => {}
flutter: OnAdEvent: AdEventType.contentResumeRequested => {}

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.5, on macOS 14.1.1 23B81 darwin-arm64, locale en-EG)
    • Flutter version 3.24.5 on channel stable at /Users/mahmoudbaraka/fvm/versions/3.22.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dec2ee5c1f (2 weeks ago), 2024-11-13 11:13:06 -0800
    • Engine revision a18df97ca5
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.95.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.100.0

[✓] Connected device (5 available)
    • Mahmoud’s iPhone (mobile)       • 00008130-000E188836B8001C            • ios            • iOS 18.1 22B83
    • iPhone 15 Pro (mobile)          • B257009B-D230-4AAA-BFE1-B6DFE007EEA0 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 131.0.6778.86

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for the report.
I tried on iOS simulator in which I see the logs as below but with {} which is empty
2024-11-29 13:11:34.316650+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.loaded => {}
2024-11-29 13:11:34.387762+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.contentPauseRequested => {}
2024-11-29 13:11:34.524054+0530 Runner[15632:164898] [boringssl] boringssl_metrics_log_metric_block_invoke(151) Failed to log metrics
2024-11-29 13:11:35.417139+0530 Runner[15632:164900] [boringssl] boringssl_metrics_log_metric_block_invoke(151) Failed to log metrics
2024-11-29 13:11:35.776184+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.started => {}
2024-11-29 13:11:38.293012+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.firstQuartile => {}
2024-11-29 13:11:40.688983+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.midpoint => {}
2024-11-29 13:11:43.289070+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.thirdQuartile => {}
2024-11-29 13:11:45.735262+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.complete => {}
2024-11-29 13:11:45.774724+0530 Runner[15632:164919] flutter: OnAdEvent: AdEventType.contentResumeRequested => {}

stable : 3.24.5
master : 3.27.0-1.0.pre.668

/cc @bparrishMines
@MahmoudTarek What extra data is associated with the ad event that you are expecting to see in this case?

Hi @stuartmorgan
On native iOS I always use skipTimeOffset & adId, but there are other data like adTitle, adDescription, duration, etc. All ad data is received normally on native iOS/Android using same ad tag.

@MahmoudTarek Based on the screenshot you are showing, you are actually referring to the Ad object that is included in the AdEvent when using the native APIs directly. The Flutter plugin doesn't support this yet, but we can change this issue to request this feature if that is what you are looking for?
Note the adData is a separate thing.

@bparrishMines Thanks, my bad then. Let's change it to feature request.


Set the validity period of data

Clear and concise description of the problem
Set the time limit for data storage. If it exceeds the time limit, execute a specific function to load the data of the server. It can save traffic and server resource consumption.
Suggested solution
No response
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Hi, this issue has been talked about (kind of) in #21 and I think it is out of the scope of the plugin. Validity and data being stale is either a job for the storage you choose, or some function within the app itself to check validity.
Validity checks directly in the plugin would involve a lot of side effects and complexity when it can be handled by external tools.
I'd suggest looking into session storage or cookies or you could also create a custom storage that checks data staleness and returns null if it is.


@pinia/nuxt doesn't work with nuxt bridge

Actual behavior
Cannot read properties of undefined (reading 'install') at Function.Vue.use (file://./.nuxt/dist/server/server.mjs:7842:23) at $id_c39524e4 (file://./.nuxt/dist/server/server.mjs:20715:7) at async __instantiateModule__ (file://./.nuxt/dist/server/server.mjs:20913:3)
Additional information
The error popup only using vite and not webpack.
https://github.com/vuejs/pinia/issues/889
Using the method provided by @BobbieGoede is fixed:
vite: {     optimizeDeps: {         exclude: ['pinia'],     },     resolve: {         alias: {             pinia: path.resolve(__dirname, './node_modules/pinia/dist/pinia.mjs'),         },     }, }

Duplicate of https://github.com/vuejs/pinia/issues/690

For the moment, don't use Vite with Nuxt 2/bridge: https://github.com/piniajs/example-nuxt-bridge


Fetch field options from regs.gov.

This patch fetches options and dependency-contingent options for comment
fields from the regs.gov api. Field options are added to the template
context so that template overrides can access them if needed. Note: as
discussed with @cmc333333 and @vrajmohan, it would make sense to fetch
field metadata once in -parser instead; I'm proposing this change in the
interest of getting something working quickly.

@vrajmohan: just pushed some improvements (I hope) to function names, docstrings, and the logic around field types. Turns out the checks on the "lookupUrl" and "dependsOn" keys could be simplified to an easier-to-read check on "uiControl".

@vrajmohan: thanks for the catch--I renamed "list" to "picklist".


Update Swift example project to Xcode 8 GM Swift 3.0 syntax

New issue checklist

[x] I have read all of the README, documentation, and FAQ.
[x] I have reviewed the contributing guidelines. Confirmation: 💪😎👊
[x] I have searched existing issues and this is not a duplicate.

General information

Library version(s): 7.3.4
iOS version(s): All
Devices/Simulators affected: All
Reproducible in the demo project? (Yes/No): Yes (Swift)
Related issues: N/A

Bug report
Expected behavior
The Swift example project should compile and run under Xcode 8 GM without 'Use Legacy Swift Language Version' being set to yes.
Actual behavior
Many compile errors.
Steps to reproduce
Attempt to build the Swift example project in Xcode 8 GM

Per comment here: https://github.com/jessesquires/JSQMessagesViewController/issues/1608#issuecomment-231757563. I don't think it's an issue until XCode 8 get released officially.

I can't wait till JSQMessagesViewController will work with Swift 3. Great tool!

thanks for the great library. Are there plans for a swift3 version? if so, any guess at the timeframe? Thanks!

this isn't working on Swift 3 nor 2.3?

Sorry guys I will see if I have some time too look into updating the swift example this week. 🤗

Or also anyone can do this 😁

@MacMeDan Done already! PR at #1825.

nice @gerbiljames

merged PR


[FR] Change map from Abstract to Satellite view

Would love it if you could change from the Default(Abstract) view to the Satellite view that Tarkov.dev has, like a switch inside of F12 menu maybe? I'm sure everyone would love this feature, then you can see like you're looking exactly from above. Don't know how hard it would be to implement it, but it is available on the tarkov.dev site, so maybe not too hard?
Great work! Amazing add to my SPT experience so far!

This is something that I would like to do, but I need to do a lot of research and work first, namely, I need to be able to load higher quality textures without massive load times or taking up large amounts of video memory for no reason.
This involves delving a bit deeper into creating asset bundles, loading them at runtime, and learning how Unity handles on-loading/off-loading textures from CPU to GPU
In addition, I will need to learn how to generate orthographic map images, since I'd rather have that built into the dumping tool than try to stitch together the TarkovDev ones.

I see.. No rush. Take your time, you're doing a great job ATM. I'll post a FR if I can think of anything else less taxing that might be good to see in it.
Love the Quick View btw, Exactly what I was looking for.


Node and toolkit icons

Storing icons for node types and toolkits, currently as Unicode, is implemented in 716bf47


Fix fixed frame issues of the RViz SubmapsDisplay.

Adds a 'map_node_' which gets updated with the transform to RViz's
fixed frame. Before, submaps rendered incorrectly if a fixed frame
different from the map frame was chosen.
Removes the map frame property since this data is published on the
submap list topic.
Renames node names to reflect the frames they represent.

PTAL


map_regions() to downscale_regions()

With aggregate_regions() doing the work to upscale (many-to-one) regional data, map_regions() should be deprecated and a new downscale_regions() should be added. The function signature should look something like:
def downscale_regions(mapping, proxy=None)

By default, it should copy regional data into subregions. If provided a proxy (i.e., another variable), then it should do a pattern scaling to that variable, which must be supplied at the "sub regional" resolution.

Summarizing discussion in #207 - rather than deprecate map_regions(), the function should be refactored to parse the given mapping and call aggregate_region() or downscale_region() iteratively as required.
This allows to distinguish the sanity-checking of the mapping (e.g., is a particular order required aggregating from country to region to world) from the data manipulation operation.

there is now a dedicated downscale_region() function, but no work has been done on deprecating/refactoring the map_regions() function


ADD command

Create a Dockerfile showing the use of Add command.

Thanks @mclay
Closing this issue 💯


Plugin throwing exception when user giving existing table name while creating a table

Environment: Windows/IntelliJ14
Steps:
Open Services Explorer.
Sign in Subscription.
Open Mobile Services.
Right click on a Mobile Service.
Select Create table.
Give an existing table name.
Plugin throwing the below exception.

I'm getting the table name warning, following the exact same steps, in Windows/IntelliJ 14.1.1
I'm making sure not to load/refresh the mobile service content. I'm right clicking right after opening Mobile Services.

Not able to reproduce the issue in the latest build.


Keep eyes on Delta

Keep open eyes on Delta - following https://github.com/delta-io/delta/releases/tag/v3.0.0
The Delta Kernel project is a set of Java libraries (Rust will be coming soon!) for building Delta connectors that can read (and, soon, write to) Delta tables without the need to understand the Delta protocol details).

what use case do you have in mind for delta?
writing vanilla delta files is something cryo will do once polars has a rust implementation
but writing updates to files is probably out of scope for cryo


Add license to project

Hello there,
I am the maintainer of the Arch Linux User Repository (AUR) packages for vmango (vmango and vmango-git). While packaging vmango for Arch Linux I couldn't find a license for this project. Of course you have the choice on which license to use. I personally prefer the GPL version 3 (my 2 cents).
Anyway. Awesome project! I am happy to maintain the AUR packages for this.

Looks like license file was lost, I added it again, thank you!


installer: Error the package path specified was invalid

installer: Error the package path specified was invalid: '/Users/{xx}/Desktop/YosemiteFactorialChineseGUIFontRecovery.pkg'.

Yosemite Factorial Chinese GUI Font Recovery package won't be offered on GitHub anymore, and will be available here until September 30:
https://originhansansui.codeplex.com/releases/view/615922

If you are planning to upgrade to OS X El Capitan, you won't need this package since OS X El Capitan Installer would clean up all system font settings first.

One more thing: I checked the release channel of this repo and have found such package is still hosted here. Then I thought you might have encountered network glitches.


RSA 3072/4096 generation broken on NanoX 2.2.1

Running latest version of the xl app (1.4.4) on NanoX latest fw 2.2.1 and generating an RSA keyset with either 3072 or 4096 crashes the app and reboots the ledger.
Only 2048 works.

Hi,
RSA3072 is OK, in version v2.
For 4096, we still need to work on it. Please check https://github.com/LedgerHQ/app-openpgp/issues/83


Patch can't diff the same tagName element?

look at the mustache template below:

    {{#if open}}

                close

    {{/if}}

        open

when open is false, the "open" div is the first child.
when open is true,  the "close" div is the first child.
after patch, it is wrong.
but if i use a key, the patch is ok.

    {{#if open}}

                close

    {{/if}}

        open

anyone can tell me why and how to fix it ?

after patch, it is wrong.

In what way is it wrong?
I don't see any difference between the first and the last code you posted? Which elements did you put a key property on?
Can you reproduce this in a small code example?

the last code has a "key", that is the difference.
I guess virtual dom dont know which is the first div, when "open" is true, the inner div is the first, when "open" is false, the outer div is the first.

the last code has a "key", that is the difference.

Oh. Yeah. Now I see it :smile:
This sounds like a bug. Which I find a bit suprising.
Can you reproduce it with a small code example? That would be very helpful.

@mightyiam isn't a bug?

@kuraga thank you for making sure what happens here is clear. I closed this because there's no proof of a bug and no response from the original poster. Should I attempt to reproduce this?

@mightyiam I just wanted to understand reason :)

Can you reproduce it with a small code example? That would be very helpful.

@musicode , ping
And we should think what it could be...

Closing, as I don't think there is enough information here to tell what the problem is.


Support the passing of objects which aren't created via CiteAs but nonetheless follow the protocol

Will need to consider how uncite should behave - can't really uncite in this case


docs: add info to implementing/tasks about sequential execution

Closes https://github.com/keptn/lifecycle-toolkit/issues/1949
Draft status while I do some rewriting in response to Adam's remarks.
Answers the question: "Is there a way to define a given order for execution post-deployment tasks in Keptn KLT?"

@agardnerIT Thanks for this excellent critique.  I did a rewrite of all of this -- see if it makes more sense now.  The answer is that all KeptnTask resources that are defined as annotations to the KeptnApp resource for a specific stage execute in parallel but one KeptnTask resource can run many executables in order.  Moreover, you can define a "parent" KeptnTaskDefinition that uses the functionRef syntax to run other KeptnTask resources in sequence, but only the parent KeptnTaskDefinition is specified in the KeptnApp annotations.


Landing Start for free CTA does not submit on Enter

You need to actually click on the button to make it submit. Being able to hit enter would be great 😬

🤦🏼♂ I'll fix this ASAP. Just wrapping something up quickly for deploy


fix: handle matomo url not present

:tada: This PR is included in version 1.43.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is it possible to prevent scene loading by writing code in scenechange event?

Take a look at the clickHandlerFunc and clickHandlerArgs parameters, which allow you to set a custom click handler for hot spots. Set the hot spot type to info instead of scene.

Setting hot spot type to info instead of scene didn't prevent navigation to that screen after hot spot is clicked. I have used clickHandlerFunc and added a handler but Don't know how to prevent default action on click of hot spot which at the moment is to navigate to another scene which still happens even after changing hot spot type to info

Don't include a sceneId; there won't be a default click handler then.

Thanks it works then


Asynchronous Task Management

Hydroshare currently runs longer file manipulation tasks without providing feedback to the user.  These tasks may also be canceled in a dirty state unknowingly by refreshing the page or navigating elsewhere, which interrupts the request.
We would like to implement a frontend task manager for the user to easily be able to see what tasks are currently running while navigating the HydroShare site.  This is being built specifically for running file manipulation tasks, but should still be a general solution that allows any asynchronous backend task running in celery to easily plugin.
For details, refer to  https://docs.google.com/document/d/1jmAhgZBjbpfvz4Fo4E2SQgLWbSjLOhTHjHYbDwZBzS8/edit

Implemented and being tested for the next deployment. Closing.


MERN_NodeJs 5.2 How to use asynchronous APIs?

Instructions
Project directory
Branch MERN>Web_Development/MERN/Topic/Backend/Node/
FileName: 4.1_How to use asynchronous APIs.md
How to use asynchronous APIs??
Explain How to use asynchronous APIs?
Task

[ ]  Audio
[ ]  Documentation
[ ]  Video

Send a PR in the following branch only and make documentation in form of markdown file with (.md) extension and in the respective folder

/assign

@EkjotKaur, i will just be working with the documentation part

@EkjotKaur, i will just be working with the documentation part

Go head.


Instance actor should not be a Person

Threads apparently says it is a Person, see https://threads.net/ap/users/threads.sys

I don't know of any requirement for an "instance actor" to not be a Person type. The whole concept is outside the scope of AP. I don't know of any federation or interop requirements for it other than for working around the Mastodon authorized fetch design. Even then, any actor in that instance not requiring an HTTP signature can be used for that, so an "instance actor" is not necessarily required for that purpose.


Approve this pull request

Approve this pull request
Left reviews and line comments
Created a file and made a commit
Opened a pull request
Originally posted by @KIIRTHANA in https://github.com/KIIRTHANA/reviewing-a-pull-request/issues/4#issuecomment-1200473638

SAmple desco


Kite's Typescript type completions hide default auto import line feature - disable kite for type suggestions?

By default, vscode provides autocompletion of TS types on variables and displays the corresponding import line. Selecting that suggestion adds the import line at the top of the file:

The beauty of the default vscode implementation is it only prompts with the autocomplete if the import does not yet exist. Once the import for a type exists in the file, vscode only prompts with the type name.
Unfortunately, when kite prompts with a type completion it doesn't offer the ability for adding the import line to the file, so you always have to use the keyboard to get past the kite suggestions to get to the more useful default vscode suggestions.
Would it be possible to disable kite autocomplete for TS types? Or have them appear last? I haven't found the kite type suggestions to be different/better than the default vscode ones and not supporting adding new type imports reduces developer efficiency when kite is enabled.

There's no easy way to re-rank the completions to the bottom, but you can disable completions per filetype via the setting https://github.com/kiteco/vscode-plugin/blob/74469609040694038e0b820c0bc39b416cddf929/package.json#L367-L371

Thanks, @tonycheang. But all the other kite completions are helpful - it is just the type completions that are lacking. That's why I suggested suppressing just the type suggestions (or a config to do so).
One benefit for kite is to reduce keystrokes. So having to arrow down on type suggestions to see if there is a vscode completion showing that an import needs to be added works against the benefit of kite.

Ah, I misread--your request is specifically for type completions. I checked in with our ML team, and unfortunately the current TS model doesn't surface "this is a type/ type annotation". Agreed this would be a useful feature, but that level of rework isn't priority at the moment. We can leave this open for tracking should this change.


SpellBook MORE1 & MORE2, Data lost not correct save and update

Hello get issue on spellbook value MORE not correct update when drag and drop scroll on it.
How replicate:

Make empty spellbook i_spellbook
Make a i_scroll_summon_elem_water scroll
Now i show info about book (for now all OK, because is empty book:

Now i drag my scroll on book and check inside book and see spells added also tooltip update spell count.
I inspect item:

But i see more value not update.
For now seems all ok. But when save save 0 value and when server restart lost spell in book.

I hope understand problem.
Additional Info:

Tested on clear comunity script pack
Tested on Build (3285)

Same here.

Additional test:

I make some test about MORE value
If manual set by .set MORE correct store in info and save
If added by scroll (drag and drop) fail.

I think problem in located when drop scroll on bool.

I confirm that issue only happening on 32th and 64th spells.

any possible workaround in the meantime? :(

I make a quick test:

Put scroll
Check more value (Now see correct)
Make a save
Restart server
Check spellbook (Spell is present)

Good Work man!
Tomorrow i make more accurate test, if all work good i close issue, also if someone else want test it for a major feedback is good ;)

I make some accurate test and work good


Can't make it work for UWP

Hi! I want my app to request a permission to Google Drive, so here is my working link to start auth.
https://accounts.google.com/o/oauth2/auth?response_type=code&scope=https://www.googleapis.com/auth/drive&redirect_uri=ps.uwp%3A%2Foauth2callback&client_id=988157355771-r7j9rr6jf4cj7kn8de4pco4vtbbktmb9.apps.googleusercontent.com
I'm trying to use this project to perform auth, but DeepLinkBrowser simply opens https://accounts.google.com/o/oauth2/auth where I get "Required parameter is missing: response_type". Can you please point me to the right direction?

Hi @hippogamesunity ,
We use Application.OpenURL() to open the browser in DeepLinkBrowser implementation.
https://github.com/cdmvision/authentication-unity/blob/1f2b2ab4adb9fde7f5a6922e4f2cb27fb79f597d/Packages/com.cdm.authentication/Runtime/Browser/DeepLinkBrowser.cs#L29
I don't know why it omits the query parameters from the url. Are you sure that it is omitted? Some browsers only displays the base url; you can see full url if you attempt to edit the url in the address bar.

Maybe because of this: https://answers.unity.com/questions/846108/applicationopenurl-wont-open-url-with-custom-strin.html


Failed to execute script 'source_prepared' due to unhandled exception: [WinError 5] Access denied

i guess run it as admin


can add support play HLS video and VTT subtitle

can add support play HLS video and VTT subtitle?
thank you..

HLS video and WebVtt subtitles are already supported by using ExoPlayer to play videos in this sample. Please see that library for more information for the supported formats.

i tested ExoPlayer demo play hls ok, but this androidtv-Leanback cannot play .
change ExoPlayer demo code play mp4 load vtt  subtitle work,
change this androidtv-Leanback code no display subtitle :(
did recommends sample code display subtitle (mp4+ vtt) very need,
thank you enough..

Take a look at our other sample if you'd like to view subtitles. https://github.com/googlesamples/androidtv-sample-inputs/tree/master/app/src/main/java/com/example/android/sampletvinput/player
ExoPlayer implementation details are beyond the scope of this sample but I hope the code you find here will help you resolve your issue.

ok....les't me try, thank you.


How is the "app_installed_team_id" in a slack request payload set?

I have a question about how app_installed_team_id is set in the slack request payload.
According to the source code mentioned here, https://github.com/slackapi/bolt-python/blob/v1.20.1/slack_bolt/request/internals.py#L90, the team_id is extracted based on what is present in the payload.  I have a situation where I have a user that is a member of two workspaces in an organization.  An app is installed in both workspaces by the same user, i.e. separate installation records are created with different team_ids.  When I receive an event like app_home_open the payload will extract the team_id from the first authorization record, which in my case ends up being the correct team_id of the workspace that the app home tab is being loaded in.    When I start an interaction, like clicking a button in the home tab, it results in an action payload and the team_id is extracted from the ["view"]["app_installed_team_id"] which has the value of the other workspace, being the workspace that the app was first installed in.
Why is it sending that value instead of the team_id of the workspace I am in?  This results in the other team_id being set in the context and used by the client.  I can override this, but am curious why this is the case and is it the expected behaviour?
TL;DR: when an app is installed in multiple workspaces in an org by the same user the app_installed_team_id seems to always be the team_id of the first workspace the app was installed in.  Depending on the action being handled, the team_id that is being set in the context may not always be the team_id of the workspace you are using, resulting in the webclient making requests against the wrong workspace unless you manually override it.
Reproducible in:
The slack_bolt version
slack_bolt==1.20.1
slack_sdk==3.27.1
Python runtime version
Python 3.12.3
Steps to reproduce:

Create two workspaces in an org and install an app in both workspaces by the same user.
Open app home tab in the second workspace and review the app_installed_team_id in the request body.

Expected result:
Expected the app_installed_team_id to be the team_id of the workspace the action was initiated in.
Actual result:
It sets the team_id to the first workspace that the app was installed into.
####Logs:
{
  "type": "block_actions",
  "user": {
   <<redacted>>
    "team_id": "T07LF8EHX7V"
  },
  "api_app_id": "A02FZN4GRGA",
  <<redacted>>
  "team": {
    "id": "T07LF8EHX7V",
    <<redacted>>
    "enterprise_id": "E07L8N9AQES",
    <<redacted>>
  },
  <<redacted>>
  "is_enterprise_install": false,
  "view": {
        <<redacted>>
        "app_installed_team_id": "T07M45HCWF2",
}

I would expect the app_installed_team_id to equal T07LF8EHX7V, not T07M45HCWF2.

Hi @RubberDuckyToyFactory, thanks for asking the question.
I understand that this might be a bit confusing, but here are some important points to note about the Events API for multiple workspaces within the same Grid organization.
Firstly, when an app is installed across multiple workspaces to receive the same event, only one of those workspaces will receive it, and your app doesn't have the way to specify which workspace should be prioritized. This means that, even if bolt-python skips app_installed_team_id for this scenario, authorizations[0].team_id could randomly represent any of them (= it won't be the workspace where the user is using). If your app needs to know the list of installed workspaces, you can perform apps.event.authorizations.list API call with sufficient scopes. This Events API's behavior applies to any workspaces, not just those under an organization.
When your app is installed in multiple workspaces within an organization, 1:1 DMs and the Home tab do not belong to any specific workspace, and the Events API payload does not indicate which workspace the user's at. The latest Slack client UI combines all workspaces into a single view, removing the concept of being in a specific workspace. Although you still can filter the workspace in the UI, this does not affect the Events API payload sent to your app.
Therefore, please design your app without assuming your app can know which specific workspace a user is in during event delivery. As a workaround, you might consider opening a modal view to ask the user which workspace to be considered for app interactions (but I know this isn't ideal).
I hope this clarifies things and is helpful to you.

Thanks, @seratch.
I appreciate your thorough response.  It was very helpful.
Could you clarify one other thing for me?  The Slack API Docs for App Home  says:

The app_home_opened event is accurately named — it tells your app when the user has opened the App Home. Your app can listen for this event and respond accordingly.
A payload will be delivered to your app via the Events API, containing actionable and contextual information about the event. This information will include the user that opened the App Home, the workspace that the event happened in, and more.

Is suggests that the payload will include the workspace that the event happened in.  I guess this is where my confusion came from.
If I understand you correctly, when dealing with workspaces that are in an Enterprise Grid the behaviour is less straightforward.  The Enterprise Docs says:

Look for the authed_teams node that arrives as part of the "wrapper" around delivered events. It contains a collection of team IDs within an organization that this delivery is on behalf of.

It gives an example of an event payload:
{
    "token": "ecto1EZslimer",
    "team_id": "T111AAA111",
    "api_app_id": "A123ABC456",
    "event": {
        "type": "message",
        "user": "W123ABC456",
        "text": "It's time to slacktivate!",
        "team": "T111AAA111",
        "source_team": "T111AAA111",
        "user_team": "T111AAA111",
        "user_profile": {
            "avatar_hash": "g56821b98743",
            "image_72": "https://...png",
            "first_name": "Jesse",
            "real_name": "Jesse Slacksalot",
            "name": "jesse.slacksalot"
        },
        "ts": "1485371714.000002",
        "channel": "C123ABC456",
        "event_ts": "1485371714.000002"
    },
    "type": "event_callback",
    "authed_users": [
        "W3MBP5799"
    ],
    "authed_teams": [
        "T222BBB222",
        "T111AAA111"
    ]
}

and says that The message originates from team T111AAA111 and is delivered as a single event for both teams, including T222BBB222.
Am I understanding you correctly that for an app_home_open event there is no way I can confidently know where the event originated from as suggested above?


Improve push squashing

Fixes #5588 - the root problem was that events were squashed, but nothing triggered a push for the last events. So change #1 was pushed immediately, change #2 triggered a callback after (squash time).
Instead the callback is now after 1 second, and we evaluate if in the last second we received any event.
If not - push. Otherwise, keep waiting until the batch of changes settles down.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbc4e771c190cb77f897a4efd9277c3acf973823
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [costinm]
pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
f9034c71b36af68271da1bb18b9c49948712e3e3
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
7a41a388b13c54cbcb04617b39b3de5da940d5dc
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Updated copy to be more legible and clear.

Please check the following conditions for your PR.

[  ] apiDefinition.swagger.json is validated using paconn validate command.
[ ✔  ] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

Can I get some help with fixing these errors generated from paconn validate?
➜  TractionGuest git:(dev) paconn validate --api-def ./apiDefinition.swagger.json {   "error": {     "code": "SwaggerCertificationFailedWithErrors",     "message": "Swagger certification failed with errors. Please validate again after fixing following errors: Error : info : The 'contact' property is required.\r\nError : The 'x-ms-connector-metadata' property is required."   } } 400 Client Error: Bad Request for url: https://api.powerapps.com/providers/Microsoft.PowerApps/objectIds/291d6a5d-45c6-4552-884f-085fa03758b0/validateApiSwagger?api-version=2016-11-01&enableConnectorCertificationRules=true

@jzhang729 I've responded to your questions about the validation errors via email, just a heads up :)

@jzhang729 I've responded to your questions about the validation errors via email, just a heads up :)

Thanks @dougelliott. Fixed the validation errors now.

@dougelliott I guess I should wait until this PR is merged and squashed down into a single commit before I submit this into ISV studio?

@jzhang729 Correct :) Once pending items are taken care of within the PR, we'll handle squashing and merging for you. And once that's done, you can move forward with submitting the update within ISV Studio.
On that note, Srikanth has left a comment for your review above. Feel free to let us know if there are any questions on that.

@sriyen-msft Any ETA on when we can get this reviewed? (cc @dougelliott)


Can't Create a Custom Kernel Extension

The package and version I'm asking about:
1.0.251301+06badd73c27d2c2065cf835ab7bd65bccd2339ee
Question
I'm trying to create a custom extension, using the ClockExtension example as a guide. You can find my code here - specifically, it's the Collatz.Interactive project. I created a notebook to test it out - DemoExtension.ipynb. When I run it....it finds the local NuGet package, but running the help command (-h) doesn't produce anything, and when I try to run it, I get this error:
Error: Required command was not provided.
Unrecognized command or argument '#!collatz'
Unrecognized command or argument '-s'
Unrecognized command or argument '444'

I'm not sure what I'm doing wrong. Any insight is appreciated - TIA.

It looks like the thing you're missing is putting the extension .dll in this path within your package:
https://github.com/dotnet/interactive/blob/fd23041799a9e15d9ae4c55ef64c2d4e157fb774/samples/extensions/ClockExtension/ClockExtension.csproj#L22-L24

I tried that:
	<ItemGroup>
		<None Include="$(OutputPath)/Collatz.Interactive.dll" Pack="true" PackagePath="interactive-extensions/dotnet" />
	</ItemGroup>

But I get this error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NU5100	The assembly 'interactive-extensions\dotnet\Collatz.Interactive.dll' is not inside the 'lib' folder and hence it won't be added as a reference when the package is installed into a project. Move it into the 'lib' folder if it needs to be referenced.	Collatz.Interactive	C:\Program Files\dotnet\sdk\6.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets	221

Putting it inside both folders will avoid this warning.

So I tried putting it into lib:
<None Include="$(OutputPath)/Collatz.Interactive.dll" Pack="true" PackagePath="lib" />

And now I get this error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NU5101	The assembly 'lib\Collatz.Interactive.dll' is placed directly under 'lib' folder. It is recommended that assemblies be placed inside a framework-specific folder. Move it into a framework-specific folder.	Collatz.Interactive	C:\Program Files\dotnet\sdk\6.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets	221

Sorry, @jonsequitur, I really appreciate the responses, just not that familiar with these NuGet issues and I feel like I'm flailing a bit.

FWIW if I do this:
<None Include="$(OutputPath)/Collatz.Interactive.dll" Pack="true" PackagePath="lib\net5.0" />

Then I get this:
Severity	Code	Description	Project	File	Line	Suppression State
Error	NU5118	File 'C:\Users\jason\source\repos\Collatz\src\Collatz.Interactive\bin\Release\net5.0\Collatz.Interactive.dll' is not added because the package already contains file 'lib\net5.0\Collatz.Interactive.dll'	Collatz.Interactive	C:\Program Files\dotnet\sdk\6.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets	221

:|

The ergonomics of this definitely need some work. But the pack process should just put it into the appropriate TFM-specific lib folder for you by default.

Agreed....just not sure why it thinks it isn't, though when I try to add it explicitly, then it thinks it's already there.

I was able to get this to work by:

turning off warnings as errors.
adding these to the Collatz.Interactive.csproj:

		<OutputType>Library</OutputType>
		<IsPackable>true</IsPackable>
		<IncludeBuildOutput>true</IncludeBuildOutput>
        <PropertyGroup>
	<ItemGroup>
		<None Include="..\..\LICENSE" Pack="true" PackagePath="" />
		<None Include="$(OutputPath)/Collatz.Interactive.dll" Pack="true" PackagePath="interactive-extensions/dotnet" />
	</ItemGroup>

Success!
...sort of.
So, I did what you suggested, and it now installs, and I get help on it, but...if I try to run it:
#!collatz -s 444

I get this error:
Error: System.InvalidOperationException: The type System.ReadOnlySpan`1[System.Byte] cannot be bound
   at System.CommandLine.Binding.ModelBinder.CreateInstanceInternal(BindingContext bindingContext)
   at System.CommandLine.Binding.ModelBinder.GetBoundValue(IValueSource valueSource, BindingContext bindingContext, IValueDescriptor valueDescriptor, Boolean includeMissingValues, Type parentType)
   at System.CommandLine.Binding.ModelBinder.GetBoundValues(IDictionary`2 bindingSources, BindingContext bindingContext, IReadOnlyList`1 valueDescriptors, Boolean enforceExplicitBinding, Type parentType, Boolean includeMissingValues)
   at System.CommandLine.Binding.ModelBinder.GetBestConstructorAndArgs(BindingContext bindingContext)
   at System.CommandLine.Binding.ModelBinder.CreateInstanceInternal(BindingContext bindingContext)
   at System.CommandLine.Binding.ModelBinder.GetBoundValue(IValueSource valueSource, BindingContext bindingContext, IValueDescriptor valueDescriptor, Boolean includeMissingValues, Type parentType)
   at System.CommandLine.Binding.ModelBinder.GetBoundValues(IDictionary`2 bindingSources, BindingContext bindingContext, IReadOnlyList`1 valueDescriptors, Boolean enforceExplicitBinding, Type parentType, Boolean includeMissingValues)
   at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass21_0.<<UseMiddleware>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass25_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Invocation.InvocationPipeline.InvokeAsync(IConsole console)
   at System.CommandLine.Parsing.ParseResultExtensions.InvokeAsync(ParseResult parseResult, IConsole console)
   at Microsoft.DotNet.Interactive.Commands.DirectiveCommand.InvokeAsync(KernelInvocationContext context) in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\Commands\DirectiveCommand.cs:line 34
   at Microsoft.DotNet.Interactive.Kernel.HandleAsync(KernelCommand command, KernelInvocationContext context) in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\Kernel.cs:line 256
   at Microsoft.DotNet.Interactive.KernelCommandPipeline.<BuildPipeline>b__6_0(KernelCommand command, KernelInvocationContext context, KernelPipelineContinuation _) in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\KernelCommandPipeline.cs:line 57
   at Microsoft.DotNet.Interactive.KernelCommandPipeline.<>c__DisplayClass6_1.<<BuildPipeline>b__3>d.MoveNext() in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\KernelCommandPipeline.cs:line 72
--- End of stack trace from previous location ---
   at Microsoft.DotNet.Interactive.CompositeKernel.LoadExtensions(KernelCommand command, KernelInvocationContext context, KernelPipelineContinuation next) in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\CompositeKernel.cs:line 144
   at Microsoft.DotNet.Interactive.KernelCommandPipeline.<>c__DisplayClass6_0.<<BuildPipeline>g__Combine|2>d.MoveNext() in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\KernelCommandPipeline.cs:line 70
--- End of stack trace from previous location ---
   at Microsoft.DotNet.Interactive.KernelCommandPipeline.SendAsync(KernelCommand command, KernelInvocationContext context) in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive\KernelCommandPipeline.cs:line 42

I'm wondering if this has to do with the command wanting a BigInteger value and this is tripping things up for some reason. Not sure. At least the extension is installing, but I'm hoping this error is something that I can address!

This error is because the parameter binding in System.CommandLine is making a best attempt at satisfying the BigInteger constructor but can't instantiate the ReadOnlySpan<byte>. You can probably solve this by providing a ParseArgument<T> delegate to your Option<BigInteger>.

I'll give that a whirl....

Finally! Success :)

@jonsequitur thanks for the help.


Feat: Add SMTP DKIM settings

Description
Closes #1030
This should just work as we just exposed the nodemailer's DKIM settings. I don't have a mailserver setup to test tho.
Type of change

User Interface
New feature (non-breaking change which adds functionality)
Translation update

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[ ] I have performed a self-review of my own code and test it
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

cc. @ilogus

Hi @chakflying, I just tested your fork, everything is good on my side ! ✅
Here are some screens :

If you want to test by yourself, and modify the options, contact me by email I could send you smtp credentials and a private key.
Thank you for this feature, in the hope that it will be fully validated !

Awesome! Can't wait to see this in production.

@ilogus You should not post your private key or any part of it in public

@ilogus You should not post your private key or any part of it in public

Don't worry, this mailbox, the DNS record with the public key and the private key were only used for this test. In order to be able to take a picture of this for you


fill cache

ref https://github.com/pingcap/tikv/issues/1244
InnoDB use LRU list to cache pages, the LRU list is split into old list and new list two parts, when a page is read from disk, it will be added to the new list, when the page is readed again it will be moved to the old list, SQL like select * from t will just flush the new part of LRU, this will not decrease the cache hit rate a lot.
RocksDB use a LRU list to cache blocks, and use ReadOptions.fill_cache to control the behavior of fill cache or not. MyRocks has a session variable named skip_fill_cache, the default value is false, it means always fill cache, when user set skip_fill_cache=true(eg. dump the database), blocks will not fill cache.
Currently we fill cache just depend on the operation's type, if it is a scan operation we don't fill cache, and the otherwise we fill cache, this is too rough. We should support configure the behavior of fill cache or not by set session variable.
PTAL @siddontang @ngaut @BusyJay

LGTM

LGTM


⚠ Thumbnails API Endpoint has degraded performance

In ab16f9d, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 503
Response time: 3726 ms

Resolved: Thumbnails API Endpoint performance has improved in 69941ce after 38 minutes.


In explorer too little contrast between titles and hover or selected

Issue Type: Feature Request
I'm using the Dark+ dark theme, but this happens also with almost all dark themes.
In explorer there is too little difference between title bars (OPEN EDITORS, MYWORKSPACE, OUTLINE) background color and selected line background one. This makes difficult see the various sections of the window. Could the title bars made more contrasting, more different from the rest?
The Red theme does just the reverse (selected file visually popup more than the titles). The Tomorrow Night Blue is just a little better than the default one.
Now I will explore extension themes to see if they solved this problem better.
Thanks for considering!
mario
VS Code version: Code 1.26.1 (493869ee8e8a846b0855873886fc79d480d342de, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.17134

I should add that various dark theme extensions suffers the same problem. Seems like the styling of explorer is provided by the default dark theme and few themes care to override these factors. Is it true?

Just an example. In the marked area no difference is visible between title bar and active editor bar. Instead below the selected file is very visible. The theme is Dark (Visual Studio).

This is provided by each team and is customizable. So please customize it in your settings and we have no plans to change this in the default theme currently
The colors which you want to edit are list.inactiveFocusBackground and other list customizable colors.


Migration Control

Problem Description
After CGI extracts data from an MP, these are stored in a Json file and transferred to DataHub V3 and stored in a Blob store in Azure.
There is a need to make two automatic checks:
Benefit Hypothesis
We are then able to control that the content of the migration files is correct and the values is ready for for the import process
Acceptance criteria and must have scope
AC 1: Create 1 File containing all filenames for controlling all transferred files in 24 hours
Check that the number of files sent by CGI is also stored in the Blob store. T his is done by creating an autojob that makes a list that shows which files have been stored in the Blob store for the past day. The file should show the name and file size of each file. The file must be saved in an agreed location.
The job should run 10 minutes after midnight each day.
AC2:  Selection of 150 random files transferred the day before.
There must be 150 random files of those transferred the day before. These files are transferred and stored in an agreed location. The job should run automatically and should run 10 minutes after midnight each day.
Objectives and key results
Increased confidence and and part off the requirement for audit.
Leading Indicators
Non Functional Requirements
none
Stakeholders

Rasmus Juul Holm Christiansen, PBR, ++

Timeline PI 6
###Ressources: Titans,

@tml fjernet fra Titans og flyttet til Art.  @ENDK-RHC  håndterer selvstændigt

@mogensjuul skal denne feature lukkes?


sh.exe: static command not found

Thx for your tool but I am having some issues on windows 8.1
After typing in my command prompt(git shell):
static generate --site=<IP_ADDRESS>:2368
I got this error:
sh.exe: static command not found
Do I have to include something in my PATH ?
Or did I do a mistake while typing the command ?
Thanks in advance for your help :)

Solved my issue with

ruby ./lib/main.rb setup ( + all required arguments)
ruby ./lib/main.rb generate --site=configname  (where configname matches what you input during step 1)

As you can see there is no static command involved.


Error is: ENOENT: no such file or directory, stat 'D:\MyPrj\App_Resources\Android'.

hi,
i'm get the following output when run tns run android in my project:

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
*                                                                                *
*  You are using the Legacy Workflow.                                                                           *
*                                                                                *
*  With the upcoming NativeScript 6.0 the Webpack workflow will become the only way of building apps.           *
*  More info about the reasons for this change and how to migrate your project can be found in the link below:  *
*  https://www.nativescript.org/blog/the-future-of-building-nativescript-apps                                   *
*                                                                                *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

Unable to apply changes on device: emulator-5554. Error is: ENOENT: no such file or directory, stat 'D:\MyPrj\App_Resources\Android'.
Stopping tsc watch
Stopping webpack watch

tns --version  gives me 5.4.2.
also I'm trying to upgrade all modules. even installed nativescript-dev-webpack
but the output is same:
ERROR in [copy-webpack-plugin] unable to locate 'D:\MyPrj\App_Resources/Android' at 'D:\MyPrj\App_Resources/Android'

regards

Hi @mohammadreza99,
The given information is not enough to investigate further your problem. Can you send us a sample project, that can be used for reproducing the issue? Also, provide more info about the exact steps that you are using while building the app.

Closing due to inactivity


Document fuzzer usage

This PR adds documentation how to use LibFuzzer or afl++.

Coverage remained the same at 100.0% when pulling 13e9ab23733ab6a59d776c281ed48751ad02c3ff on fuzzer_doc into b205361d8652759b6d850a37b227c8d57ee19005 on develop.

@falbrechtskirchinger Can I merge this? Or should we update the AFL wrapper with the one you used with AFL++?

@falbrechtskirchinger Can I merge this? Or should we update the AFL wrapper with the one you used with AFL++?

Let me give it another read, then you can merge it. We can update the AFL wrapper some other time.
I'd like to understand how the make targets are used by OSS-fuzz (haven't looked at build.sh which I've seen linked in comments) and maybe move the fuzz testing into the CMake code since the more advanced AFL++ use requires building two fuzzer binaries and then running the fuzzer requires a different command as well. All of that would be easier to do in CMake (we're also already downloading the test date which could simplify and automate corpus generation).

Alright. I would like to avoid requiring OSS-Fuzz to use CMake. But the targets in the root Makefile can be removed/replaced.


Ability for collective admins to edit members

Following https://github.com/opencollective/opencollective/issues/2089
User story
As a collective admin, I can add/remove/hide members manually - both for tier's members, but also for collective's members.
Examples

Collective Brussels Politics Transparency has a Monthly Meetup tier. A sponsor is lending its building for this meetup. On the tier page, I can click on Manually add member to surface them as contributors.

The organization CASINO-ONLINE registers as a sponsor. I don't want to advertise their website, but I still want them to be a member of the collective (for example to get private updates). I can click on Hide on the contributor's card if I'm an admin (we would need a place to see them for the collective admins so they can revert their action). (#2002)

Best solution for this problem
See https://github.com/opencollective/opencollective/issues/2097#issuecomment-565422585
MVP
We can focus on the Tier page for the MVP, by adding a way to hide members or to add new ones).
Metrics

How many members are added manually
Reduce in support requests for "Please remove xxx from the sponsors"
Reduce in support requests for "xxx registered as a backer, but they're a sponsor"

This is so useful @betree!

@Betree Do we need this issue open still or is it covered in the NCP?

@piamancini It's not covered by the NCP. There's no emergency to implement it, but I still think that it would be helpful to have this.

Because:

The contributors grid grid is not filterable
The grid doesn't include all contributors (https://github.com/opencollective/opencollective/issues/2432)
We want to keep the grid fast (so it shouldn't handle too much features)
What we really want to edit is the memberships (which is slightly different than contributors, see https://github.com/opencollective/opencollective/issues/2102)

I now think that this feature should be a dedicated Members section in Collective's Edit page. We don't need something fancy, a simple editable table with the info and actions described above could do the work.
Whatever we choose, this issue needs to go through @opencollective/design first.

I think a section in the collective edit page is good enough to unblock this. I agree that fancy design is not needed. I'll talk to design about it

For this project, I was thinking the engineering team could build a proof of concept first. That would unblock existing users and help us rapidly iterate. Once more or less stable, we could integrate it in the edit collective with the help of the design team.

There was an important feedback from the team that hiding contributors on your collective page goes against our value of transparency. I now think that we should close this issue to focus on other solutions.

Not sure why this was closed, it's still a frequent user request


[BEAM-2492] Have PipelineOptions DisplayData filter out attributes marked with @org.apache.beam.sdk.options.Hidden

Interfaces marked with Hidden have been hidden in getOptionSpecs, this change filters out methods annotated with Hidden and adds a unit test.
Could you help review this change?
R: @lukecwik

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM. Just need to get the tests to pass.

Run Java PreCommit

@pabloem Thanks for reviewing this. The Java ("Run Java PreCommit") checks keep failing because of elasticsearchIO tests and flink test, should rerun/retest help?

can you rebase your change? that should help fix the tests, I expect.

Run Java PreCommit

Run Java PreCommit


badges

hello @christopherdarling
the badges don't seem to match the repository. They are for respect/validation...
spek

apologies for that @spekulatius - I've just updated these

no problem


[BUG] Title is not getting updated after editing link

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

The closest bug is #443, but I am not sure if it is 100% the same issue.
Describe the bug
The link title node (the link's anchor text in the editor after adding the link) is not updated after the link edit.
Reproduction
Steps to reproduce the behavior:

The link is created by typing the URL and title into the link dialog text fields.
The link shows up in the editor.
Select the created link in the editor, and click again on the add link button in the toolbar.
Dialog opens again with two inputs prefilled correctly.
Change the URL and Title in the dialog.
Save the changes.
The link node was correctly updated in the editor with a new URL.
The link node was NOT correctly updated with the new Title.

Expected behavior
The link node displayed in the editor should be updated in the new title.
Screenshots
https://github.com/user-attachments/assets/5757bf77-5f01-4b5c-8a31-bf4d7ca4e2a2
The recording comes from the https://mdxeditor.dev/editor/demo.
MacOs on Chrome.
Additional context
After investigating the code I came to the conclusion that the  linkNode.setTitle(title) in updateLink$ method might not work correctly.
          () => {
            const linkNode = getLinkNodeInSelection(selection)
            if (!linkNode) {
              const node = $createLinkNode(url, { title })
              node.append($createTextNode(linkContent))
              $insertNodes([node])
              node.select()
            } else {
              linkNode.setURL(url)
              linkNode.setTitle(title)
            }
          },
          { discrete: true }
        )

@olgaplaga I can't really see the bug in the video you have recorded. You start with one, than change to two, and then two is displayed?

@petyosi thank you for the answer. The video shows that the link node inside the editor (blue highlighted "One")  is not updated when I change the title in the dialog input.
First I changed it to "Two", I closed the dialog, and the link node in the editor still shows "One".
Then I changed to "three" - and the link note still shows "One".
Does it make it any clearer now?


Copy impl for OnionAddressV2

I've added it with my last commit solving embedded OpenSSL problem. Would you mind if I'd just closed it?

Sure!

Closed by https://github.com/teawithsand/torut/commit/0f5cc03798aeeeb523ea33e69dde6623f96c99d8


pandoc-citeproc fails to parse {`u}

The latex command
\{`u}

causes pandoc-citeproc to err out. See discussion at retorquere/zotero-better-bibtex.

It's invalid LaTeX, and it will also cause an error in LaTeX.
The correct LaTeX would be \`u or {\`u}.


Add yum repo configuration to Linux Master Script

Completed in https://github.com/lorengordon/SystemPrep/commit/74fcfb3d1f7af804a405105b501422422e91d067.


Are there any sources that do not use vue.js but are written in the old style of HTML and Javascript?

I have a question because the project I want to apply it to uses the old HTML and Javascript methods.

No. You can use this example as reference to make it in plain old JS. Also you most probably will need to make a bundle to link with your HTML, using a tool like rollup, webpack or vite.

As you suggested, I solved the problem using webpack. Thank you.

mapinusRND, do you mind sharing your solution, I also want a simple javascript + html implementation. Thanks!


TextExtractor.Extract fails when run asynchronously

When using the Extract Method in an async Task, the method fails with the inner exception message "Thread was being aborted". The stacktrace shows
   at java.io.File..ctor(String pathname)
   at TikaOnDotNet.TextExtractor.Extract(String filePath)

The method then throws an normal TextExtractionException with the message "Extraction of text from the file '{MyFilename}' failed."
When running the same code synchronously, it works perfectly, however I'd like to do the extraction in a background thread obviously.

Seemed to be an error on my part, making the thread abort.


improve linter config

rewrite/create linter config thats

supports both ts and js (linter works only with ts now)
update camelCase rule
something else?

Nice job @nd0ut ❤


add custom packages for microvm and fullvm

Can you provide the required packages? @xmonader

microvm

1cpu 1ram 25 disk
2cpu 4ram 50disk
4cpu 4ram 100disk

fullvm

1cpu 1ram 25 disk
2cpu 4ram 50disk
4cpu 4ram 100disk

We should call it Storage (SSD)

Verified on devnet.
Packages were added with the resources mentioned above, each package was tested and the selected resources are applied correctly in the deployment details and in the vm itself.
Full VM

Micro VM