Should AbstractHandler::handle() return false when message is not handled and bubble is not allowed?

I have a question regarding both version 1.x and 2.x. In getsentry/sentry-php#1189 there is an open question about what is the general expected behaviour of the HandlerInterface::handle() method in regards to how its return value is computed. The question can be summarized in: should the $bubble argument of the constructor affect in any way the return value of that method? There are three distinct PHPDoc that are open to different interpretation:
https://github.com/Seldaek/monolog/blob/c1971982c3b792e488726468046b1ef977934c6a/src/Monolog/Handler/AbstractHandler.php#L29-L31
Reading this statement, what I understand is that $bubble applies only to handled messages. In my case, if the event isn't sent off to the server for whatever reason, even if no error is really thrown, I would by definition say that the message has not been handled and I would expect it to be forwarded to the next handler of the chain regardless
https://github.com/Seldaek/monolog/blob/c1971982c3b792e488726468046b1ef977934c6a/src/Monolog/Handler/AbstractHandler.php#L71-L75
Reading this statement instead, I understand that the $bubble argument controls the bubbling regardless of whether the message has been handled or not. In my case, if the message failed to be sent and bubbling is disabled I would expect the message to not be passed to the next handler in the chain.
https://github.com/Seldaek/monolog/blob/c1971982c3b792e488726468046b1ef977934c6a/src/Monolog/Handler/HandlerInterface.php#L47-L50
Finally, reading this statement I have no doubts about its meaning, but here arises the question: if $bubble is false and this method didn't handle the message, what should it return? The actual behaviour of all handlers I looked at is that the same condition is always used to determine the result value of the HandlerInterface::handle() method:
https://github.com/Seldaek/monolog/blob/c1971982c3b792e488726468046b1ef977934c6a/src/Monolog/Handler/AbstractProcessingHandler.php#L44
This condition satisfies only the second statement in the strict meaning.

The assumption is that handlers accept/handle a message and it'll be delievered. That is what the bubble was meant to do: If the message is handled (based on level usually), then it should false if bubbling is allowed, so other handlers keep being called. If the message is not handled, return false always (this is maybe what you missed, I believe it answers your last statement) https://github.com/Seldaek/monolog/blob/c1971982c3b792e488726468046b1ef977934c6a/src/Monolog/Handler/AbstractProcessingHandler.php#L33
If bubbling is not allowed, and the message is handled, then true is returned, and the handler chain is interrupted.
There was not a consideration of the handler looking at whether the message was properly delivered, because well this is usually not used as a message queue where losing data is life and death. That said I don't see this as a wrong interpretation to say that you consider a message handled only if it was acknowledged by the backend. Most handlers will probably throw if they fail to log something though so I don't think this applies to most things, but feel free to do it if it makes sense in your handler.

If bubbling is not allowed, and the message is handled, then true is returned, and the handler chain is interrupted.

Sorry, I'm still confused. I think I can simplify the question by asking whether false can be returned if bubbling is not allowed. I interpret the $bubble argument of the constructor as a global flag controlling if the next handlers in the chain can be called, regardless of whether the current handler did or did not handle the message

That is what the bubble was meant to do: If the message is handled (based on level usually), then it should false if bubbling is allowed, so other handlers keep being called. If the message is not handled, return false always

Ok so if $bubble = false in the constructor, if the message has not been handled the expectation is that the next handler of the chain should still be called, right? This looks like a countersense though, because if I set in the constructor that I don't want bubbling I don't expect bubbling in any case.

Nope, as per:

If bubbling is not allowed, and the message is handled, then true is returned, and the handler chain is interrupted.

So $bubble = false would in monolog core always return true for messages which have a level that makes them "handled", regardless if the backend handled them properly or not.

That said I don't see this as a wrong interpretation to say that you consider a message handled only if it was acknowledged by the backend.

This is still true IMO. Yes it is a little counter intuitive to me that if I say no bubbling the handler would still bubble, but I can also see this as a valid use case.. Though it may be more fitting to have a fallback handler of some kind, that forwards to a secondary handler if the primary threw an exception (i.e. failed handling a message). Kind of like WhatFailureGroupHandler does but more like a FirstHandlerWinsGroupHandler where it'd just return after any handler successfully handled the record.

I believe that is a good chance think about wha handle() should return.
I also had this confusion at the beginning, did not make much sense the return value of handle() .
The main reason behind this relies on this piece of code:
file: Logger.php
code:
            try {
                if (true === $handler->handle($record)) {                    //<-------- THIS CODE
                    break;
                }
            } catch (Throwable $e) {
                $this->handleException($e, $record);

                return true;
            }

Is very old (year 2015).
I also "see" that we do have a method called getBubble() in Handler/AbstractHandler.php that is not used anywhere in the code except on some unit tests.
Maybe is a good chance to think about this, not for this version of monolog, but maybe in the next ones.


Fixes bug in create/edit_naming.

The bug is that if you create or edit a naming, and enter an existing genus that currently has a single version, but fill in a different author, it will change the author.  It should only fill in the author if the existing name has no author.  For example, propose the name "Psilocybe Azurescens".  Psilocybe already has an author, "(Fr.) Kumm.".  After the naming is created, it will change the author to "Azurescens".  (Even if the name is locked!)
So far, all I've done is write a test that reproduces the bug.

Okay, this is ready for review now.


Issue when reading text file from Android Download folder with Android 11

Bug Report
Issue when reading text file from Android Download folder with Android 11
Problem
I have an Ionic 5 app that uses this plugin to read text files from the Download folder on Android devices. On devices running Android 11 it does not work. Devices running Android 9 do work - have not tried on Android 10.
What is expected to happen?
App should be able to read in text file from Android's Download folder
What does actually happen?
The promise for readAsText() returns null
Information

Run on devices with Android 11
Command or Code

Ionic app is using @ionic-native/file/ngx as a wrapper for the cordova-plugin-file plugin.
const path = this.file.externalRootDirectory + 'Download';

this.file.readAsText(path, 'foo.txt').then((file) => {
   console.log('process file');
}).catch((e) => {
  console.log('error '+ e);
});

Again this works for Android 9 devices (have not been able to try on a Android 10 device) but not 11.
Environment, Platform, Device

Ionic 5 with the following configuration
   Ionic CLI                     : 6.12.2 (/Users/.nvm/versions/node/v12.18.3/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.4.3
   @angular-devkit/build-angular : 0.1002.0
   @angular-devkit/schematics    : 10.1.7
   @angular/cli                  : 10.2.0
   @ionic/angular-toolkit        : 2.3.3

Cordova:

   Cordova CLI       : 10.0.0
   Cordova Platforms : android 9.0.0, ios 6.1.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 15 other plugins)

Utility:

   cordova-res (update available: 0.15.2) : 0.15.1
   native-run (update available: 1.2.2)   : 1.0.0

System:

   ios-sim : 8.0.2
   NodeJS  : v12.18.3 (/Users/.nvm/versions/node/v12.18.3/bin/node)
   npm     : 6.14.8
   OS      : macOS Catalina
   Xcode   : Xcode 12.2 Build version 12B45b

Version information
Using     "cordova-plugin-file": "^6.0.2"
Checklist

[ X ] I searched for existing GitHub issues
[ X ] I updated all Cordova tooling to most recent version
[ X ] I included all the necessary information above

Verified that a Pixel 3 running Android 10 like Android 11 does not wok. Android 9 and below does work.

This is already dealt with here: https://github.com/apache/cordova-plugin-file/issues/426

Hello,
I have got the same problem on Android 10 / cordova 9 . Works with Android 10 / Cordova 8.1.

Android blocked access to shared folders from API 29 (Android 10) due to privacy issues.
https://developer.android.com/reference/android/os/Environment#getExternalStorageDirectory()
I'm having the same issue to store a file in Downloads folder
https://stackoverflow.com/questions/65668470/how-to-save-a-file-on-shared-space-in-cordova-with-android

Android blocked access to shared folders from API 29 (Android 10) due to privacy issues.
https://developer.android.com/reference/android/os/Environment#getExternalStorageDirectory()
I'm having the same issue to store a file in Downloads folder
https://stackoverflow.com/questions/65668470/how-to-save-a-file-on-shared-space-in-cordova-with-android

Duplicate: https://github.com/apache/cordova-plugin-file/issues/426

Duplicate: https://github.com/apache/cordova-plugin-file/issues/426


SearchChildren With EFCore

I have tried using SearchChildren with EFCore and a query against a SQL database but it doesn't seem to be applying any filters in the generated SQL query.
I saw an old blog post that indicated this might only be available with in-memory queries - is that still the case?

I'm running into the same problem here, it seems like it has no effect..

I'm running into the same problem here, it seems like it has no effect..

@ninjanye Hi, yes, it doesn't work
 var q = _context.DServicesDocuments                 .Where(w => !documentType.HasValue || w.DServices.SDocumentId == documentType)                 .Select(s => new DocumentsModel                 {                     Id = s.Id,                     Name = s.DServices.SDocument.DocumentName,                     Description = s.Description,                     OrganizationName = s.DServices.DFolder.SOrganization.OrganizationName,                     Folder = s.DServices.DFolder.FolderName,                     Service = s.DServices.CaseNumber,                     YearStart = s.DServices.YearStart,                     YearStop = s.DServices.YearStop,                     Metadata = s.DServicesMetadata.Select(ss => new DocumentMetadata                     { Name = ss.MetadataName, Value = ss.MetadataValue })                 }).AsNoTracking()                 .SearchChildren(s => s.Metadata)                 .With(s => s.Value.ToLower())                 .Containing(query.ToLower().Split(" "))                 .ToQueryString();
SQL
SELECT d.id, s.document_name, d.description, s0.organization_name, d1.folder_name, d0.case_number, d0.year_start, d0.year_stop, d0.id, s.id, d1.id, s0.id, d2.metadata_name, d2.metadata_value, d2.id FROM d_services_document AS d INNER JOIN d_services AS d0 ON d.d_services_id = d0.id INNER JOIN s_document AS s ON d0.s_document_id = s.id INNER JOIN d_folder AS d1 ON d0.d_folder_id = d1.id INNER JOIN s_organization AS s0 ON d1.s_organization_id = s0.id LEFT JOIN d_services_metadata AS d2 ON d.id = d2.d_services_document_id ORDER BY d.id, d0.id, s.id, d1.id, s0.id, d2.id


with-dev-setup in for Opam 2.2 and onwards

This replaces the dev flag(?) with the with-dev-setup flag which can be used by an end user as follows
opam install . --with-dev-setup

The PR should only be merged after Opam 2.2 has a GA release.

Wow I forgot all about it haha, thanks for you guys' work!


What is the state of this project?

Is this project still maintained? If so, who are the maintainers responsible for merging code and releasing to PyPI?
If this package is not maintained, can the following steps be taken?

Now: Update the README to reflect the state of the project, and request new maintainers.
Later: Transfer ownership of the project (including the PyPI package) to new maintainers.
Later: Update the README of this repo to point to the location of the new repo.

@jsocol would you mind commenting?

I started a new issue linked here but the tl;dr is that it's ostensibly maintained but practically not a high priority for me lately and I need help. If you're willing, mind commenting on #246?

See #246.


Pause autoPlay when the window is hidden

Fixes #508 by pausing the autoPlay animation if the document is hidden, using the Page Visibility API.

Currently adding tests to this, please stay tuned. :hourglass:

Well done


fails on Windows due to process.env.HOME being undefined

Currently running 'yo typings foo' on a Windows machine fails unless you specifically set the HOME environment variable

» yo typings npm-node-json-db
path.js:7
throw new TypeError('Path must be a string. Received ' + inspect(path));
^
TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.join (path.js:466:7)
at Object. (C:\Users\james\AppData\Roaming\npm\node_modules\generator-typings\generators\app\createTemplateCommands.js:9:31)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
at Module.require (module.js:468:17)
at require (internal/module.js:20:19)

Appears to be used in 2 places AFAICT
https://github.com/typings/generator-typings/blob/e412656ae9e847a6570564988c191d5a5d13bf26/generators/app/index.js#L19
https://github.com/typings/generator-typings/blob/e412656ae9e847a6570564988c191d5a5d13bf26/generators/app/createTemplateCommands.js#L9
AFAIK Node v4 is when the os.homedir() was added which you could use instead of you're already requiring (are you're ok requiring) v4 or later.
https://nodejs.org/api/os.html#os_os_homedir
Otherwise, you can use the os-homedir npm module as a polyfill, or even just use a simple function to check for win32 like in this SO answer
function getUserHome() {
  return process.env[(process.platform == 'win32') ? 'USERPROFILE' : 'HOME'];
}

Thanks for the excellent report!  Will fix it this afternoon

@unional wow, that was a crazy fast response! Thanks!!

I have released 1.0.1 for this. Please see if it solves the problem.
I'm in the process of setting up appveyor, hopefully will avoid windows platform issue in the future. :)


Mickey trial lock

for some reason it's showing more changes that exists on the qa branch already, closing this one, rebase my branch and try again


npx tsc fails due to body.Host

Hi there,
I recently forked the repository since I'm interested in adding some minor functionality.
Yet, I'm currently unable to build it. Running npm run prepare results in
><EMAIL_ADDRESS>prepare /media/fernando/shared/reMarkable-typescript
> npx tsc

src/remarkable.ts:93:39 - error TS2339: Property 'Host' does not exist on type 'string'.

93     this.storageUrl = `https://${body.Host}`;
                                         ~~~~

src/remarkable.ts:100:42 - error TS2339: Property 'Host' does not exist on type 'string'.

100     this.notificationUrl = `wss://${body.Host}`;
                                             ~~~~

It's a minor issue, but I was wondering if it's something that should be changed, since the line has been around since the initial commit, and the build on npm runs fine. How was that one compiled?
Cheers
Fernando

Hey,
Sorry for the delay
From the output here it seems like reMarkable changed the return object
I will try to take the time to fix it

thanks dude. If you are interested in keeping the typescript library alive, I may contribute some code I wrote for my desktop client


Replace setGenesisBlock / genesis config with hardcoded blocks

As discussed with @Geod24 today. We should come up with an alternative to user-configurable genesis blocks. Initially we went with this solution to allow having a different genesis block for unittests / integration tests / testnet / coinnet.
The problem is that a corrupt config file or just a user typo could cause the node to use a different genesis block.
One alternative was to use version() blocks and then build Agora with -version=CoinNet, -version=TestNet, but that is problematic because we then need to ship multiple binaries.
A better alternative suggested by @Geod24 is to have a runtime choice between several pre-configured genesis blocks.
So instead of having config.genesis_block, we would have ./agora --mode=coinnet | ./agora --mode=unittest or something to that effect. It could also be a config option, but the point is that it's not a hex dump of a block but a choice with a limited pre-configured number of options.

So:
$ agora --testnet
# OR
$ agora --well-know-net
# The default is
$ agora --mainnet

Or something similar. I think we should keep testnet for, heh, testnet, because that's what people expect, and use a very unambiguous and non-similar name for the integration test (it's most likely to be only written in scripts, and will stand out).

Do we want it to be a default? We probably don't want to accidentally run on mainnet by mistake.
I remember the days [at our prev employer] where we would scp binaries and then run them, but without it being obvious we're running on a test system or a live one. There were a few times when we ran test apps on the live system by mistake. :P

We should brainstorm it. I think the main difference between agora and the case you mentioned is the intended audience: agora is likely to be run by non-developer, hence the defaults need to "just work" as much as possible. But if we make the error message obvious enough I guess it could work, too.

Raising to prio-high because it's blocking us AFAIU.

Some notes about this issue:

Any time we change the built-in integration test genesis block, it may end up breaking all existing tests.
We need to include Enrollments in the genesis block, it's hard to pre-determine how many so it works well with all tests (including the network testst).


How to hide camera icon from ImagePickerActivity

I don'd want user to pick image from camera so I want to hide camera icon from optionMenu which is in ImagePickerActivity.

ImagePicker.create(activity).showCamera(false)


Reference to Map File

On the Customization page, there are two references to the Map File. I know this was removed from the Standard (I did a search of the Standard, just to be sure and it is not referred to at all). We need a patch for that page that clarifies the procedure without the Map File.

Are you referring to the repository mapping metadata? That's definitely in the standard; it was mostly added in https://github.com/uptane/uptane-standard/pull/111.

No this is an an explicit reference to the "map file"...under that terminology. I could not find a reference to the "map file" as a distinct component.

Ok. I believe this is a terminology issue and not a change in technique. I'll take down this issue once I've correctly resolved the text.

I'm closing this down as this is not the issue I thought it was. A simple wording change on PR #23 will resolve the problem.


Out of Memory Exception

I'm getting an out of memory exception albeit very rarely from UA:
Package: com.project.app
Version Code: 43
Version Name: 1.3.2
Android: 5.0.1
Android Build: LRX22C.L720TVPUCOK3
Manufacturer: samsung
Model: SPH-L720T
Thread: main-1
Start Date: Wed Nov 23 19:53:22 EST 2016
Date: Wed Nov 23 19:57:41 EST 2016

java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
	at java.lang.Thread.nativeCreate(Native Method)
	at java.lang.Thread.start(Thread.java:1063)
	at android.app.IntentService.onCreate(IntentService.java:108)
	at com.urbanairship.analytics.EventService.onCreate(EventService.java:125)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:3157)
	at android.app.ActivityThread.access$1900(ActivityThread.java:177)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1532)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:145)
	at android.app.ActivityThread.main(ActivityThread.java:5951)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)

@owlstack Out of memory issues are tricky to track down. The component that throws the out of memory exception are rarely the culprit, its more likely that they are just the last piece of code that is running when the app runs out of memory.
I would recommend doing general memory debugging for your app. Also double check that you are following best practices in terms of memory caching, i.e  make sure its based on the percent of memory of the device instead of a static value.

@rlepinski I will admit I am using Urban Airship 2.0.5 Xamarin Component, so I'm not sure if that's related to the memory leak or not.
What are best practices involving memory caching? Is it something I have to handle on my end? What's the best way to do memory debugging within my app? Thanks!

@owlstack Not sure what tools xamarin provide, but I am pretty sure these apply:

https://developer.android.com/studio/profile/investigate-ram.html
https://developer.android.com/studio/profile/am-memory.html

For memory management, take a look at these:
https://developer.android.com/topic/performance/memory.html
https://developer.android.com/training/displaying-bitmaps/cache-bitmap.html

Thank you so much for the resources!

Good luck. Please reopen the issue if you find that the culprit is actually us.


I have been looking for the native JSON processing scheme

In order to achieve the project no invasion，Over the years I have been looking for native JSON processing scheme，until find here。
I based on "Codable" encapsulates a set of treatment scheme，and hope more communication

My pleasure, I hope to communicate with you more.


TypeError: _classify_installed_files() got an unexpected keyword argument '_cmake_install_dir'

[2023/04/03 14:09:40.468] Traceback (most recent call last):
[2023/04/03 14:09:40.468]   File "/home/aaa/source_code/opencv-python/setup.py", line 711, in <module>
[2023/04/03 14:09:40.468]     main()
[2023/04/03 14:09:40.469]   File "/home/aaa/source_code/opencv-python/setup.py", line 437, in main
[2023/04/03 14:09:40.469]     skbuild.setup(
[2023/04/03 14:09:40.469]   File "/usr/local/python3.9/lib/python3.9/site-packages/skbuild/setuptools_wrap.py", line 627, in setup
[2023/04/03 14:09:40.469]     _classify_installed_files(cmake_manifest, package_data, package_prefixes,
[2023/04/03 14:09:40.469]   File "/home/aaa/source_code/opencv-python/setup.py", line 651, in _classify_installed_files_override
[2023/04/03 14:09:40.469]     return (cls.wraps._classify_installed_files)(
[2023/04/03 14:09:40.469] TypeError: _classify_installed_files() got an unexpected keyword argument '_cmake_install_dir'

opencv-python <IP_ADDRESS>

skbuild should be >=0.13.2


Add label for the target awsAccountID where the role is created

Currently, there is no direct reference to the target AWS account for an AWS Federated Account Access. Instead, it relies on using the aws secret in the namespace of the accountclaim to call aws sts get-caller-identity. This causes an issue if the aws secret is deleted before the finalizer code is run.
This PR fixes this by adding a label to the CR with the account ID. It still relies on the secret to get the account ID, but only needs to happen once. From then on, the ID can be referenced in the CR by the label.
This also includes a new function to check an arbitrary label on the CR, rather than just the uid label.

/lgtm

/lgtm

/hold

/lgtm

/hold cancel

/retest


Issues training custom model

I've attempted to reproduce some of the results from the paper:
L. Fu, Y. Cao, J. Wu, Q. Peng, Q. Nie, and X. Xie, "UFold: fast and accurate RNA secondary structure prediction with deep learning", Nucleic Acids Research, p. gkab1074, Nov. 2021, doi: 10.1093/nar/gkab1074.
I attempted to re-train UFold on a custom dataset, but ran into some issues, and have a few questions I'm hoping you can help clear up.
Running testing script
After following the installation instructions, I attempted to check if the installation succeeded (by running python ufold_test.py --test_files TS2), which resulted in the following traceback:
THCudaCheck FAIL file=/opt/conda/conda-bld/pytorch_1579022034529/work/torch/csrc/cuda/Module.cpp line=59 error=101 : invalid device ordinal
Traceback (most recent call last):
  File "ufold_test.py", line 341, in <module>
    main()
  File "ufold_test.py", line 204, in main
    torch.cuda.set_device(2)
  File "/home/usr/anaconda3/envs/UFold/lib/python3.6/site-packages/torch/cuda/__init__.py", line 292, in set_device
    torch._C._cuda_setDevice(device)
RuntimeError: cuda runtime error (101) : invalid device ordinal at /opt/conda/conda-bld/pytorch_1579022034529/work/torch/csrc/cuda/Module.cpp:59

I suspected that this issue was simply due to setting a hardcoded CUDA device that I don't have, so I made the following changes to ufold_test.py:
72c72
<     device = torch.device("cuda:0" if torch.cuda.is_available() else "cpu")
---
>     device = torch.device("cuda:1" if torch.cuda.is_available() else "cpu")
204c204
<     torch.cuda.set_device(0)
---
>     torch.cuda.set_device(2)
257c257
<     device = torch.device("cuda:0" if torch.cuda.is_available() else "cpu")
---
>     device = torch.device("cuda:1" if torch.cuda.is_available() else "cpu")
322c322
<     contact_net.load_state_dict(torch.load(MODEL_SAVED,map_location='cuda:0'))
---
>     contact_net.load_state_dict(torch.load(MODEL_SAVED,map_location='cuda:1'))

After this, the test script runs without issues.
Running training script
I then attempted to train UFold on some other datasets, starting with the provided TS0 as an example. First, I made similar fixes the to hardcoded CUDA devices within ufold_train.py. Then, when trying to train the model via python ufold_train.py --train_files TS0, I ran into more issues.
The code contains several breakpoints (pdb.set_trace()), I assume simply left over from debugging. However, continuing through the breakpoints results in the following traceback:
Traceback (most recent call last):
  File "ufold_train.py", line 220, in <module>
    main()
  File "ufold_train.py", line 189, in main
    train_merge = Dataset_FCN_merge(train_data_list)
  File "/home/usr/ufold2/UFold/ufold/data_generator.py", line 609, in __init__
    self.data = self.merge_data(data_list)
  File "/home/usr/ufold2/UFold/ufold/data_generator.py", line 617, in merge_data
    self.data2.data_x = np.concatenate((data_list[0].data_x,data_list[1].data_x),axis=0)
IndexError: list index out of range

I believe this is because you must provide two datasets as arguments, i.e. python ufold_train.py --train_files dataset_A dataset_B, for example. However, it's not clear to me why this is the case. Is one of the datasets used for pre-training?
Finally, the training runs through an epoch, and then fails due to what I assume to be a hardcoded save path with the following traceback:
Traceback (most recent call last):
  File "ufold_train.py", line 220, in <module>
    main()
  File "ufold_train.py", line 210, in main
    train(contact_net,train_merge_generator,epoches_first)
  File "ufold_train.py", line 43, in train
    steps_done = 0
  File "/home/usr/anaconda3/envs/UFold/lib/python3.6/site-packages/torch/serialization.py", line 327, in save
    with _open_file_like(f, 'wb') as opened_file:
  File "/home/usr/anaconda3/envs/UFold/lib/python3.6/site-packages/torch/serialization.py", line 212, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/home/usr/anaconda3/envs/UFold/lib/python3.6/site-packages/torch/serialization.py", line 193, in __init__
    super(_open_file, self).__init__(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: '../models_ckpt/final_model/for_servermodel/tmp/ufold_train_onalldata_0.pt'

Could you please assist me in re-creating your training methodology for a custom dataset? Additionally, could you detail how I might go about re-training with synthetic data as mentioned in the paper, along with the methodology to generate it? I have found references to multiple training steps in ufold/config.json (for example, epoches_first, epoches_second, and epoches_third), but no other references anywhere else in the code.

Hi there,
Thanks for reaching out. The first issue you point out is due to the GPU id, you can switch to your own cuda device id or change it to cpu, our framework is capable of running using cpu. The second one you ran into is because our model support for multiple datasets input, therefore we call a function that merge all the datasets, we also changed our code for only one dataset as you can see in the data_generator.py file. The third issue is simply due to the pre-trained model saving path error, which we have changed that to the working path, you may change to your own path as well. Lastly, some references in the ufold/config.json file didn't show in the code because some params are used for earlier debugging and test. So we have delete some unecessary references. Last but not least, for the synthetic data you mentioned, for each real sequence, we first generate 3 synthetic sequences to create a pool of synthetic sequences by randomly mutate some nucleotides from the corresponding real sequence. In order to make the sequences pass the redundant removal procedure to keep clear with the training set, we then use CD-HIT 80 to remove any sequences that have similarity over 80% to real sequences. The synthetic ground truth labels are generated with Contrafold, which then use to train UFold.
Thanks

Hi,
Thank you very much for your quick response and fixes.
I see your last four commits addressed my issues. I appreciate the help. I was able to start training a model after your changes.
Quick FYI: 8db5a90 breaks things due to 528533143e194854e264fcfd9802252c95f2f6b7/ufold/config.py#L24, but I was able to trivially fix it by reverting the config file.


Selecting one of several cell types in dfflibmap based on timing/area tradeoffs

How to force Yosys to use a particular cell in the library? In the library, sometimes we have multiple cells that have the same function (say, DFF) but with different timing, area and power. For example, there can be a DFF1 that has low area, medium setup time and medium clk-to-q delay, and a DFF2, which has high area, low setup time and medium clk-to-q. (The difference between them is the circuit design of the DFF cell itself). On a timing critical path, we would use DFF1 as the "launch" flip flop and DFF2 as the capture FF (i.e., where the path ends). Please try to create an example to demonstrate this, and with commands

The pass responsible for this is dfflibmap, which isn't timing-aware. To it, all Liberty cells that match a given DFF type are equally valid, so it just picks one.
I think the OpenROAD fork of Yosys tries to perform physical synthesis for timing, but I don't know whether it applies in this case.
If you really, desperately want it to use a particular cell, you'll have to instantiate it manually, or else improve dfflibmap.

how can I target a specific cell i.e. dff in a liberty library with dfflibmap, kindly provide exact command if any?

If you really, desperately want it to use a particular cell, you'll have to instantiate it manually, or else improve dfflibmap.
how I can, can you explain it plz


Review notes

This Issue is created to discuss some of the code issues/questions found by @cheme over his review of parity-db code.
Not to be merged as is.

Most of it has been addressed I believe. If there's still anything worth further discussion please open a separate issue.


Road map

Fix bugs (always top priority)
Handle deprecated Policies automatically - #516
Improve hydration kt - #622 , #440
Cleanup export and documentation scripts - #594 , #529, #517
Implement a Beta channel #618

Adding to backlog


force staking on by default for staking > 1

This small patch allows users that are primarily staking to set the value
staking=2 or more
in the config file to force staking on by default on startup
fully tested in PNY for values of:
none (missing from file)
0, 1, 2, 99  with expected results

I am suffering from this problem as well and this pull request really brings a useful case.
When people/me restarts the computer/laptop or restarts the wallet, the staking is coming back as disabled - if the wallet is encrypted - even if I/we set  staking=1 in the conf file. We/I need to manually start/enable it after every restart.
If not most of the times, some of the times I/we forget to start it if the wallet is encrypted.
Therefore taking most of the people's forgetfulness and busy minded people, it will really ease the life if we merge this pull request :)

@techy2 @bedri this change will only be effective if the wallet is unencrypted, right?
I understand that it is useful when an unencrypted wallet needs to be restarted, but that introduces a very unsafe way of having it staking.

@pedro-at-decenomy staking should be only be bounded by staking=X parameter in the conf file.
We should not manually start it by clicking the button.


Question about 'WEIGHT_PATH'

Great job！I want to know whether should I download the weights file to local to instead the path os.environ['WEIGHT_PATH'] = '/apdcephfs_cq10/share_1290939/vg_share/eckertzhang/Weights'? Where can I find the file? Thanks

os.environ['WEIGHT_PATH'] should be updated as the weight path of pre-trained models, like stable diffusion and ECON.

Hello, could you please give the weight path of pre-train models? Thanks!

The pre-trained model comes from hugging face ('https://huggingface.co/runwayml/stable-diffusion-v1-5’) and ECON ('https://github.com/YuliangXiu/ECON/blob/master/fetch_data.sh')


prologue: Note inclusion proof in note db

Overview
As part of the transaction prologue we need to authenticate that the notes being consumed in the transaction exist in the note db.  This involves:

An MMR inclusion proof to authenticate that the block that the note was created in is included in the known chain history.  This should be authenticated against the most recent known block which is one of the global inputs to transaction / prologue.
A merkle inclusion proof to authenticate that the note was produced in the block identified above from the chain history.

We currently have a TODO placeholder in the prologue here.
Below we see a diagram for how this data is structured:

Dependencies
This is dependent on having:

[x] Mmr proof in masm
[x] Merkle  proof in masm

closed by #86


Enhance text

I've made the text 'Bookingjini Icons' and 'Find hospitality related icons, curated by creators from Bookingjini' readable and responsive in Dark Mode and Light Mode. The logo of the website has also been updated.
Solved issue #99
https://github.com/Bookingjini-Labs/bookingjini-icons/assets/112184998/60e3e85d-de4b-42c6-9fb8-849a6c278a0d
https://github.com/Bookingjini-Labs/bookingjini-icons/assets/112184998/180abe8c-8376-46bf-a9bd-47fd0a2896ba

@riddhigupta1110 is it responsive till 300px?

@riddhigupta1110 is it responsive till 300px?

Yes, it is responsive.


Gulp 4: Build & watch, task naming

With Gulp 3, you can do something like this:
// Build.
gulp.task("build", () => {
    // ...
});

// Watch.
gulp.task("watch", ["build"], () => {
    gulp.watch("src/**/*.html", ["build"]);
});

This is a total of 2 tasks (functions), and build will be run before watch.
How do you do the same thing with Gulp 4? If you use gulp.series, it looks like this:
gulp.task("watch", gulp.series("build", function anotherFunctionOrAnonymous() {
    gulp.watch("src/**/*.html", gulp.parallel("build"));
}));

But that gives this tree:
[20:31:55] +-- watch
[20:31:55] ¦ +-- <series>
[20:31:55] ¦   +-- build
[20:31:55] ¦   +-- anotherFunctionOrAnonymous

You can name it watch as well, and then you get:
[20:36:44] +-- watch
[20:36:44] ¦ +-- <series>
[20:36:44] ¦   +-- build
[20:36:44] ¦   +-- watch

... but this almost looks recursive.
Is this the only way to do it? Would you not reintroduce the concept of dependencies?
Same thing with my serve task that depends on watch.
If you had dependencies again, it could be visualized as follows:
[20:36:44] +-- watch
[20:36:44] ¦ +-- (build)     <-- different colour

It's just a bit weird the way that it is, and I'm unsure of how to name the tasks/functions in these cases.

@glen-84 what I've done in my projects is to just call the parent something generic that incapsulates all subtasks.
[20:36:44] +-- buildAndWatch
[20:36:44] ¦ +-- <series>
[20:36:44] ¦   +-- build
[20:36:44] ¦   +-- watch

@beenanner Ya, I thought about doing that as well, but it doesn't really solve the root problem (task dependencies).

@glen-84 is your example the result of a gulp --tasks command?

@phated Yes.

Using gulp#watch always indicates having a dependency to a function or a task.
So actually, isn't it better that gulp#watch returns the function without execution like gulp#series or gulp#parallel?
gulp.task('build', function() { ... });
gulp.task('watch', gulp.watch('src/**/*.html', 'build', {runBefore:true}));

[20:36:44] Tasks for ...
[20:36:44] ├── build
[20:36:44] └─┬ watch
[20:36:44]   └── build

or

[20:36:44] Tasks for ...
[20:36:44] ├── build
[20:36:44] └─┬ watch
[20:36:44]   └─┬ <watch>
[20:36:44]     └── build

We are working on UI for a non-recursive display (although it won't solve you naming 2 different things the same) over in https://github.com/gulpjs/gulp-cli/issues/57 so I'm closing this.


Invalidating sessions based on time inactive instead of time created

I want to set this up so that each time a user loads a page, it keeps track of when that was, and if a timeout (PERMANENT_SESSION_LIFETIME probably) is greater then that, clear the session.
As it stands, it looks like the created timestamp is encoded in they key for this entry. Thus, to update the timestamp when the user accesses a page, it would need to get the data from that kv map, create a new entry with a new timestamp encoded in the key, delete the old key, and get the new cookie to the client. Yuck.
I was thinking that I would do something instead where there were two fields in the kv map.

uniq_str
uniq_str_accessed

Where the first one has the session data and the second one mapped to a timestamp for the last time a page was accessed. Then I can just add a "update timestamp" call in app.before_requeset() to keep the timestamp up to date, and have clear_sessions() remove sessions accordingly.
What are your thoughts on this? Does this seem like a good way to go about it? Would you be interested in a patch that enables this as an option, or should I make this just for me?

@vimalloc, I am suffering from the similar type of problem. I wonder why nobody has replied to your query yet. Permanent session life time & inactivity timeout need to work together which is not with flask_kvsession. Hope to hear any sort of solution from anyone else.
Thanks!

I've ran the example code and I can reproduce the problem. Debugging this shows me that occasionally sessions are "forgotten", i.e. I can get four requests in a row that will start off of the same dictionary of sessions, add theirs. E.g. if the new session IDs are [A, B, C, D] and before those four requests the sessions X and Y existed, I'd end up with [X, Y, A], [X, Y, B], [X, Y, C] and [X, Y, D].
This seems like a race condition in Flask (which may be indicating that I am using the Session API wrong). The issue here is that DictStorage is not thread-safe. The only thread_safe storages I would recommend are redis and possibly Postgres. The file-backed storage might work as well, but do not count on it. Do these problems disappear when using Redis?

@ln2khanal I'm with you on this. I recently started to use flask_kvsession as a drop-in replacement for the normal session interface. It turns out that this problem makes it less of a simple "drop-in" because the behaviour is different from the original, as SESSION_REFRESH_EACH_REQUEST is ignored.
@mbr As far as I understand, the reason for this is that the validity of the session is checked by comparing the session creation time that is encoded in the session key to the current time. Since the session id is usually never updated, this results in invalidation of the session after creation_time + life_time instead of last_activity_time + life_time.
Of course this can be circumvented by calling session.regenerate() on each request, but wouldn't it make more sense to store the expiration time in the backend and check session validity against that (if SESSION_REFRESH_EACH_REQUEST is set)?
If such a feature would have the chance to be accepted, I'm more than willing to implement it.


improve error message if oranda is run on a project version that does not yet have a github release

if you:

configure your project to use cargo-dist
bump version of project locally
run oranda

you will get a gross error that from what i can tell is a parse error
we can improve on this and it's important because it will be something people likely hit a bunch until we smooth out the dist->oranda exp some more

I came here to post about this, but also, I think there's an additional corner-case:
cargo-release typically does this (imo annoying) thing where it bumps your package's version to the next prerelease and tags that, and I think what I'm running into when "cargo_dist": true is set is that oranda looks at my Cargo.toml, sees the weird 0.2.1-alpha.0 version generated by cargo-release, and just... shits the bed. Improving the error message would be good, but I'm not sure what the best way is to tell the oranda action to target the actual latest release.

hold that thought, this might be because I had an old cargo-release version. sigh!

yeah no, it's still happening :/

hey @zkat - so i am not the hugest fan of cargo-release so i'm not as familiar with the workflow there. i suspect that part of what we are discussing here is actually stability channels heh :) from what i can tell this is the current workflow and i have a few questions what you'd want to see:

have a project released at 0.2.0, am working on developing 0.2.1
Q: while in "dev"/"prerelease mode" do you want oranda to show the latest "stable" version or the most recent pre-release (or both, but in different parts of the site)
cargo-release bumps your project to 0.2.1-prerelease.0 (i am still not entirely clear on this behavior)
Q: it sounds like you want oranda to continue showing and working for 0.2.0?

my suspicion here is that we can infer "stability channels" and have oranda continue to only release the latest "stable" channel release (aka version number with no extra annotations like alpha or prerelease) and then come up with another way to display other channels and more early release assets/installer.
the first naive pass at this to fetch the latest release from gh releases and not try to match it to the current Cargo.toml, which is probably a better move anyways.
i'm still not 100% sure on the cargo-release workflow but we should definitely make sure that oranda can "handle" stuff it does (so long as it preserves the exp for folks who don't use it.)
thanks for trying stuff out and please continue to file/comment on issues! your feedback is super appreciated 🖤

see https://github.com/axodotdev/cargo-dist/pull/167 :)

So from more testing, it turns out that the annoying 0.2.1-prerelease.0 dance is something an old version of cargo-release was doing, and I think it still supports that, but it is definitely not the default anymore.
After messing around with cargo-dist and cargo-release for a while, I finally got things deploying "right", and at first, oranda didn't seem to work. But I tried it just now and it worked just fine? I was getting the json parse error before, I was sure, but I can't reproduce it anymore. I must've just been in a weird state while figuring stuff out.
Anyway, I'm excited about oranda (and cargo-dist), and it's been nice using them so far, even though I know both projects are extremely young. They're still perfectly usable!


siad becomes unreachable if socat dies

It'd be better to restart socat or exit the container.
We can check if port 9980 is working. However, since 9980 might not respond while loading, it's not easy to find whether socat dies or siad is still loading.

@jkawamoto thank you for the report! We're going to look into it.

@jkawamoto this is an interesting problem. I suggest that we address that by adding a healthcheck and marking the container as unhealthy if socat dies. This will allow us to monitor and restart the container in such cases.
In your experience, does it happen for socat to stop working properly without exiting? If so we can adjust the healthcheck logic.

Thank you for adding the healthcheck.
I don't remember if socat has ever stopped working without exiting. I'll use the new healthcheck and see if it covers all cases in practice.


Dragging when selectByTap is false

Hi! Thanks for supporting this component. It's super useful!
I have encountered one issue: when I set selectByTap to false I still can tap on the slider outside of the handlebar and it jumps to this position. Is it possible to specify behavior when only if user drags the handlebar then it changes it's position and calls all dragging related callbacks?
The problem actually comes from UI where we have multiple sliders in the list and when user tries to scroll through the list of these sliders they start changing values although user triggered scrolling by tapping outside of handlebars.

Hey, if possible please give me a code example so I can quickly have a look at the issue. If you in the meantime find a fix for it feel free to make a Pull request

Here is the minimal project to reproduce. Notice how hard it is to scroll through them. I'm digging the sources and currently haven't found the solution yet.

Found any solution for this issue?

No answer closing the issue


Fixed #32602 -- Clarified wording of TestCase class.

fixes ticket_32602
what was issue
Wording was not clear between test case and test case class in documentation and some comments in code .
solution
Updated docs and also code comment

[x] Do the tests still pass

I don't think we should make these changes as the exact definitions of testing terminology differs from person to person and if these were accepted then someone else will come along in the future and submit another PR to revert it or change it to something else. 🤷♂
imho the best thing to do is simply align "test case" with the class "TestCase".

imho the best thing to do is simply align "test case" with the class "TestCase".

TestCase is not the only option. IMO, precisioning test case to test case class in docs are not harm.

Thanks @felixxm  for your suggestion, i have made changes as requested

Thanks @felixxm  for your guidance, this is my first pull request in django which has been merged excited to contibute more


Added link to web-app

Added link to web-app
Also made other text consistent

Thanks :+1:

You're welcome.  Thank you for the nice tool.


cmd/mecha: can build Rust WASM unknown modules

This PR extends the mecha command so it can build Rust WASM unknown modules.

Thanks for review @orsinium now merging.


is this production ready?

is this production ready?

what use case / case scenario is this used?

i havent try it yet but hope to see the cross-datacenter feature work too if possible

was wondering if it will work if i get 1 fixed ip line (for the load balancer) + multiple dhcp ip from same ISP connected as backend, will it work?

This is a study case. It is never going to be production ready.
It can be used as a proxy and load balancer.
Don't know.
Don't know.

Refer to his documentation of his study at his Medium.


add Box#box

this is need, because usually need to store box object somewhere

def box
add box.new::this is my boxie
end
enjoy

Wouldn't to_unsafe be a more appropiate name?

I think the #box name is fine, to be consistent with the .box method.


Expose experimental features

Wanting to use tgpu textures but discovered that's not possible from the npm package. Can the experimental entrypoint be added to the exported package?

HI! Thanks for reaching out. We are currently reworking most of the APIs outside of what's public in 0.1, so that it can be used in existing WebGPU projects. We wanted to hold off from introducing tgpu textures until a later date, when they make sense in the context of the public API (currently they cannot even be used through the public API).
Could you describe your use case for them? This will allow us to focus our efforts on what's important for the community.

Thanks for the quick response! Main use case is being able to create storage textures and samplers as easily as tgpu storage buffers. I noticed they were used in the repo so I was hoping there was a way to use them myself, but I can wait for the official release!


Type error in array.push due to ‘Unrelated Types for Getters and Setters’

🔎 Search Terms
Type error in array.push due to ‘Unrelated Types for Getters and Setters’
🕗 Version & Regression Information

This changed between versions 5.1 and nightly

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240807#code/JYOwLgpgTgZghgYwgAgKoihANnSATANTiwFcIAeAFQBpkBlAXkoD5kBvAWAChlkBzCGGQA3YmQAUASgBcySgG5uvAM6CRYiOOGy6kxVwC+3bggD2IZULjIGyANoBdZHGXIAglChwAnuXSYcfCJSChASAFsAI2haSyhQPgAfMKjoZmZ9OAA6AAcSZQALcTZ1ENkARmQDPW5svMLi0rJZACJylqq9ZAB6buQwZXEAJgBmIaHJWrsABgcs0RCbZCHMmbmFsiWWoZb5IA
💻 Code
interface UnrelatedValue<T, S=T> {
  get value(): T;
  set value(v: S);
}

const a = [] as Array<UnrelatedValue<number, string|number>>;
a.push({ value: 1 });
a.push({ value: "1" }); // ts(2322)
a[0].value = 2;
a[0].value = "2";

🙁 Actual behavior
As shown in the previous code, a[0].value can be set to a number and a string, but the push operation does not accept the { value: "1" }.
🙂 Expected behavior
Push is also a type of set operation and should be allowed to be set as {value: "1"}.
Additional information about the issue
No response

That doesn't make sense, though; push is not a "set" operation. The object you push in still has the strong as the value when you run the code: https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240807#code/JYOwLgpgTgZghgYwgAgKoihANnSATANTiwFcIAeAFQBpkBlAXkoD5kBvAWAChlkBzCGGQA3YmQAUASgBcySgG5uvAM6CRYiOOGy6kxVwC+3bggD2IZULjIGyANoBdZHGXIAglChwAnuXSYcfCJSChASAFsAI2haSyhQPgAfMKjoZmZ9OAA6AAcSZQALcTZ1ENkARmQDPW5svMLi0rJZACJylqq9ZAB6buQwZXEAJgBmIaHJYy4zC1MsCCysUz5xOEkgA
If anything, it's odd that one can do that first push, because the later sets won't fix up the type at all: Playground Link

This is unrelated to arrays and an issue with object initialization:
const v: UnrelatedValue<number, string | number> = { value: "2" }

I believe this is intentionally. Such setters are expected to transform the value to whatever type the getter is. When you use an assignment you make use of the setter (unsoundness of object literals aside), but when you initialize an object there is no such setters used.

I believe this is intentionally.

I feel confirmed.

Thank you for the explanation. After careful consideration, I realize that you are right. One is the initialization of the object, and the other is assigning a value to the object after it has been initialized.


NA OFI: abort op in retry_op_queue if target connection broken

When get FI_ENOTCONN/FI_ECONNRESET/FI_ECONNABORTED/FI_ECONNREFUSED for
one OP, check the per context retry_op_queue to abort all ops to the
same target fi_addr, to avoid retry that op.
Signed-off-by: Xuezhao Liu<EMAIL_ADDRESS>

@liuxuezhao I'm a little confused by this patch, though I understand your intent. If you get an error from the CQ, that means that the operation was successfully submitted in the first place, hence already removed from the retry queue so would not abort it but only complete with an error code there. Getting back to aborting retries I think that makes sense and we should do, probably based on a timeout of some sort though. When we retry and OFI returns EAGAIN for example the operation is not submitted yet so any error that occurs there would not be returned from the OFI CQ.

If you get an error from the CQ, that means that the operation was successfully submitted in the first place, hence already removed from the retry queue so you would not be able to abort it but it would only complete with an error code there.

Yes, the intent is at that time, it checks the retry op queue and abort all other OPs to the same target fi_addr. Because if based on current ofi rxm provider, those retry will always get EAGAIN so cannot get completion.
By some other test, this mercury patch cannot fully resolve the problem, possibly due to it cannot abort the new submitted OPs. We probably still need OFI change, or adding timeout tracking for each OP submitted to OFI that is more complex. Need some more discussions later.
Thanks.

@soumagne anything else I need to for landing this patch? not very sure if the CI failure is related with this patch, thanks.

I simplified things a bit in #553. Have a look, it should be good to go now. Thanks!


Broken link in Server Rendering docs code snippet comment

What docs page needs to be fixed?
Recipes > Server Rendering > Inject Initial Component HTML and State
https://redux.js.org/recipes/server-rendering/#inject-initial-component-html-and-state
What is the problem?
The WARNING comment in the code snippet in this section has a broken link.
What should be changed to fix the problem?
Current code snippet comment is:
// WARNING: See the following for security issues around embedding JSON in HTML:
// http://redux.js.org/recipes/ServerRendering.html#security-considerations

Should be updated to:
// WARNING: See the following for security issues around embedding JSON in HTML:
// https://redux.js.org/recipes/server-rendering/#security-considerations

Yep, good catch.  Can you go ahead and submit a PR to fix that?

Sure!


Example configuration for super-spine

There aren't any examples of super-spine configurations, and given the changes that happened between 2 and 3, there's not any good documentation I've been able to find for super-spines.
I was able to figure it out and getting it working, so I'd like to add an example section with a topology I've created (and can modify to match the style of the current examples).
I can also add some information in eos_designs for super-spine connections.
My understand is the project likes to have an issue open before doing a pull request.

@tonybourkesdnpros the only "example" we have for super-spine is part of the 5stage molecule test scenario, but overall super-spines are configured exactly the same as any other device (same code). That said, we appreciate all contributions - especially on documentation and examples.
Let us know if you wish to discuss in detail before getting started.
Thanks!

I would like to add some lines (a paragraph or two) under the super-spine section on how to connect the spines to the superspines, and considerations.
I would like to add a new example configuration in the examples directory of a super-spine topology.
Here's an example of this: https://github.com/tonybourkesdnpros/Arista_AVD_Playground/tree/main/AVD_L3v2_Multipod

@JulioPDX do you have time to work with Tony on this?

@ClausHolbechArista yes! This would be an amazing addition to the examples. @tonybourkesdnpros feel free to follow the format of the current examples as far as layout. We can help with diagrams as well for the new example.


support typescript 5.4

looks good, but to be usable it needs to be released after merge as well (peer range extended). cc @Rich-Harris

thanks — released 0.4.5


An error occurs when trying to open one dialog sometimes

Storage Explorer Version: 1.24.0
Build Number: 20220427.2
Branch: rel/1.24.0
Platform/OS: MacOS Monterey 12.3 (Apple M1 Pro)
Architecture x64
How Found: From running test case
Regression From: Not a regression
Bug Descriptions

An error occurs when trying to open one dialog sometimes.
The error doesn't occur when opening the dialog again.

Steps to Reproduce

Expand one storage account -> Tables.
Create a table -> Click 'Add Entity'.
Check no error occurs.

Expected Experience
No error occurs.
Actual Experience
An error occurs sometiems.

Additional Context
When trying to open 'Clone and rehydrated' dialog. The below error occurs:

@v-xianya so is this something y'all see in 1.23.1 or any other old versions?

@MRayermannMSFT
yes, I tried to reproduce this issue on 1.23.1. and it can be reproduced.
Not tried on other old versions.

@v-xianya thank you for confirming that. Can you try some other older versions? How about:

1.22
1.20
1.18

We'll keep trying to reproduce on our own as well.

@MRayermannMSFT I tried to reproduce this issue on 1.22.0 today. It can not be reproduced.
Will continue try to reproduce this issue on 1.22.0 and other older versions if we meet this issue on the latest build again.

When clicking 'Change Access Tier...' against multi selections, there is an error dialog.

Fail to get properties for one queue with the below error.

@v-xianya have you ever seen this with the connect dialog? Once it happens, are all dialogs broken afterwards?

@MRayermannMSF I haven't seen this issue with the connect dialog. we'll check whether all dialogs are broken once this happens.


[BUG]: Not working on MacOS Monterey, recent Chrome build

Describe the bug
Extension shows up as a right-click menu item, but selecting it does nothing
To Reproduce
Steps to reproduce the behavior:

Go to 'right-click menu on any website'
Click on 'Inspect Web Component'
See error

Expected behavior
I expect literally anything to happen.
Desktop (please complete the following information):

OS: MacOS Monterey
Browser: Chrome
Version: 124.0.6367.118

Additional context
Any troubleshooting tips would be welcome. I manage IT, so plenty of testing goes on here and I would love to use this tool if it worked.

Thank you for reporting this!
It seems that some of the newer browser updates around extension manifest v3 have broke the right click menu functionalities.
I'm currently reworking quite a lot of the tooling backend and will make sure to take this into account


Re-evaluate localdata cleanup

With #1790 we added local data cleaning. This was because on windows app large amount of past data slowed down autocomplete.
For some users keeping up to 120 days of data is a must as they seem to use entries from that period.
Possible solutions
Easiest:

Clear data only older than 120 days.
Load more gets past 90 days (max that is possible without using reports)

Some user feedback in: 347269

Duplicate of #1988


Added basic example script that can help as a starting point for people

Simple example script for saving some random points and polygons.
Not totally sure the the provided examples are the recommended way of saving things but they seem to work for my purposes.
Also added a verbose flag to the polygon writer write method just to cut down on some of the prints.

Hi @sheldoncoup , thanks for contributing.
I am not sure we should add an example part, since there is the tests part that "should" cover every usecase.
Just to be sure, didn't you notice it or didn't it fit your needs? There is a writing section: https://github.com/moovida/dart_shp/blob/master/test/dart_shp_test.dart#L485-L628
Totally agree about the verbose part, didn't remember.

Hi @sheldoncoup , I had not thought of the example page on pub. And I agree with you that it is great to have soemthing shown there. So I will merge this in. Thanks


Add list of testnet bootnodes

The new Protocol ids were merged yesterday so hopefully we can deploy those soon, I will update the testnet right now

Tested and works now for 0x504A, 0x504B and 0x504C :shipit:


fix tf_efficientnet_b3_ap arguments

in both tf_efficientnet_b3_ap and tf_efficientnet_b3_ns methods, the argument "num_classes" and "in_chan" were not passed down to _gen_efficientnet. both arguments are removed to align with other similar methods.

missed that, thanks


Consider strict TS

Hi,
While using this component I get numerous TS errors during builds. They seem to be related to the fact that this is written with strict mode disabled in TS (https://kovalevski.net/what-is-strict-mode-in-typescript-and-why-and-when-you-should-use-it/).
Consider writing the component with strict mode enabled.
All the best, Oliver

I've published v7.0.0-beta.6 which provides a generated type declaration file instead of relying on the source code for type information.
I've also fixed all of the noImplicitAny warnings and errors in the source code to help move in a stricter direction.


edit package.json: add dependency to node-coap 0.12.0 and clear 0.0.1

fixes #3

Work is still progressing on this one, don't merge until tag invalid is removed!

tested, works
% git clone https://github.com/temmihoo/plushie-badname plushtesting >> testlog 2>&1 &&
cd plushtesting &&
git checkout feature-npm-dependency-coap &&
npm install >> ../testlog 2>&1 &&
npm start


Attempt to invoke interface method 'int com.j256.ormlite.dao.Dao.create'

hi
i used this library and released very well but when i want to save db this error appear
Attempt to invoke interface method 'int com.j256.ormlite.dao.Dao.create'
plz help me :(

Can you post the full exception?

06-14 05:01:22.189 1668-1668/com.example.smo_2020.hesabdar E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.smo_2020.hesabdar, PID:1668
java.lang.NullPointerException: Attempt to invoke interface method 'int com.j256.ormlite.dao.Dao.create(java.lang.Object)' on a null object reference
at com.example.smo_2020.hesabdar.Activity_MainF$12.onClick(Unknown Source)
at android.view.View.performClick(View.java:4756)
at android.view.View$PerformClick.run(View.java:19749)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5221)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

I have no idea what is going on here.  Are you using some sort of proxy or something?

It sometimes happens when I call DB from Android Sticky Service.
Maybe DB lost context in some way?...
FATAL EXCEPTION: Timer-0
Process: com.secret.monitoring.debug, PID: 2975
java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object com.j256.ormlite.field.FieldConverter.resultToJava(com.j256.ormlite.field.FieldType, com.j256.ormlite.support.DatabaseResults, int)' on a null object reference
at com.j256.ormlite.field.FieldType.resultToJava(FieldType.java:819)
at com.j256.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:60)
at com.j256.ormlite.android.AndroidDatabaseConnection.queryForOne(AndroidDatabaseConnection.java:196)
at com.j256.ormlite.stmt.mapped.MappedQueryForId.execute(MappedQueryForId.java:38)
at com.j256.ormlite.field.FieldType.assignField(FieldType.java:558)
at com.j256.ormlite.stmt.mapped.BaseMappedQuery.mapRow(BaseMappedQuery.java:71)
at com.j256.ormlite.android.AndroidDatabaseConnection.queryForOne(AndroidDatabaseConnection.java:196)
at com.j256.ormlite.stmt.mapped.MappedQueryForId.execute(MappedQueryForId.java:38)
at com.j256.ormlite.stmt.StatementExecutor.queryForId(StatementExecutor.java:85)
at com.j256.ormlite.dao.BaseDaoImpl.queryForId(BaseDaoImpl.java:223)
at com.secret.monitoring.services.TravelService$UpdateNotification.run(TravelService.java:35)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)

I have the same problem. Have you found a solution?

Although the exceptions are the same I'm not sure the issues are the same.  In terms of the dao.create(...), it looks like you have an uninitialized dao field.  That doesn't look like a ORMlite issue.

In terms of you error @koooooooooo, it looks like an internal field is null that should never be able to be null.  Any chance the dao is being used before it is ruling initialized?  An up-to-date line number or ormlite version number would be good to help locate the issue.  Sorry I can't be more helpful.  Open a new issue if you have more info.


Add support for Claude-3.5 Haiku

Description
Adds support for claude 3.5 haiku + remove claude 3  haiku
Risk
None, tested in dev
Deploy Plan

deploy front
run npx tsx scripts/update_assistants_models.ts --fromModel claude-3-haiku-20240307 --toModel claude-3-5-haiku-20241022 --execute

The product works fine during the migration interim (conversation can be seen and assitsants can be called on claude haiku even the assitsant builder shows it correctly, it's just gone from the picker)

deployed and migration run


[Improve][Core] Add test case to check deprecated result_table_name and source_table_name

Purpose of this pull request
In #8072 we removed result_table_name and source_table_name, this PR add test case to check deprecated result_table_name and source_table_name

Does this PR introduce any user-facing change?
no

How was this patch tested?
add new test.

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist
Add ci label in label-scope-conf
Add e2e testcase in seatunnel-e2e
Update connector plugin_config

[ ] Update the release-note.

cc @hailin0


[rubysrc2cpg] AST Creation tests for rescue inside def

@xavierpinho, tagging for review.

Closing it then. (cf. https://github.com/joernio/joern/pull/3364#discussion_r1278955219)


docs: セキュリティポリシーを追加

Type of Change:
新規追加
Details of implementation (実施内容)
セキュリティポリシーを追加します。
脆弱性を見つけた際は<EMAIL_ADDRESS>に連絡するよう、記載しています。
Additional Information (追加情報)

Codecov Report

Merging #466 (c16612a) into main (c38382b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   71.32%   71.32%
=======================================
  Files          58       58
  Lines        3944     3944
  Branches      369      369
=======================================
  Hits         2813     2813
  Misses        762      762
  Partials      369      369

Flag
Coverage Δ

unittests
71.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shun-shobon も、見てくれると嬉しい


Mesh loader from .obj files

Need a performance benchmarking tool to increase file reading performance: #23


Plugin always tries to use the aws profile "default"

The plugin does not check the AWS profile used by serverless at all. Can be set in --aws-profile CLI option or in serverless.yml provider.profile

Workaround for this is to run the deploy script as follows
AWS_PROFILE=<profile used here> serverless deploy

Thanks for the feedback! This should be resolved in 2.0.1.


No teleport barrier on princess secret slide

it has been taken from vanilla.sm64js.com, will not have a barrier

they can

they can

its called a death barrier

they can

its called a death barrier

at the time i did this, if you got down there in places like this, it was just a teleport barrier.


Sam/fixed urp hdrp switching

Sample
Fixed the URP/HDRP switching functionality.
Summary
This branch re-adds the URP/HDRP switching functionality by fixing the shader graph's subgraph broken paths and the URP pipeline's broken asset, it also re-adds the URP pipeline to the project, and undoes the changes made when URP was removed. Noted, you still must remove either HDRP or URP before building to the respective platforms or the build will take 2-3 hours. Also Added an Exit button, moved Stadium Selector down to make room for Exit button, disabled HD camera Component on all cameras in samples, Added the available pipelines to a List so the dropdown doesn't start out blank, Added logic to fix Global map type on MacOS, and Added Script that reimports necessary assets when a render pipeline package is added/removed to prevent pink materials problem.
Tests
Tested in editor for MacOS and Windows. Tested building project to IOS, Android, MacOS, and Windows.
ArcGIS Maps SDK Version
Latest Daily build, version 3551.

Currently you can set an API key on the SampleViewer prefab and it will load that API key into each of the samples when you use the Sample Switcher to switch to it in Play mode.

Currently you can set an API key on the SampleViewer prefab and it will load that API key into each of the samples when you use the Sample Switcher to switch to it in Play mode.

Ok, I saw it now!


Fix Registry Notification use same event time

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #12556 (3b1d216) into 3.2 (5f39404) will increase coverage by 0.55%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                3.2   #12556       +/-   ##
=============================================
+ Coverage     68.64%   69.20%    +0.55%
+ Complexity      338        2      -336
=============================================
  Files          3607     1637     -1970
  Lines        168096    67528   -100568
  Branches      27971     9908    -18063
=============================================
- Hits         115391    46731    -68660
+ Misses        42698    16269    -26429
+ Partials      10007     4528     -5479

see 2062 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix style values containing upper-case characters

inlineStyleToObject('background:url(https://test.com/IMAGE.png)') returns:
before: { background: 'url(https://test.com/image.png)' }
after: { background: 'url(https://test.com/IMAGE.png)' }

Coverage remained the same at 100.0% when pulling 1e61099a37617548834f90871adfa10f076505df on zhangbenber:fix-style-upper-case into e89bba4f8022a92418186cfaacfd473e81e31d92 on wrakky:master.

@zhangbenber because this repository seems to be rather unmaintained, we at hedgedoc hard forked the library and added some improvements. I would like to add your change to our fork (or you create your own PR). Are you okay with that?

@zhangbenber because this repository seems to be rather unmaintained, we at hedgedoc created a hard fork of the library and added some improvements. I would like to add your change to our fork (or you do it yourself with a PR). Are you okay with that?

Great. Feel free to do that.

Already done. Thanks :)


[core-http] add missing dev dependency @rollup/plugin-replace

to fix build error:
[!] Error: Cannot find module '@rollup/plugin-replace'

This plugin is used in rollup.config.base.js.

It is mysterious that build pipelines have been passing previously. And only failed in https://dev.azure.com/azure-sdk/public/_build/results?buildId=868669&view=logs&j=5e37f95d-839f-535f-6f78-cdadfd4e5b5d&t=4a5ff1f9-1f07-5cb5-206e-fa4d950b1a71&l=224


Feature/headers in requestspec

This PR adds the capability to:

Specify headers in a request specification
Specify Basic and OAuth2 authorization details in a request specification

You are only adding Basic and Oauth2 headers on request specification why not other headers like Authorization header or a content type header etc ?

Technically request specification should have ability for all headers like a regular test can add

You've got a point about the Content-Type header, I'll add that as a separate issue. Authorization is Basic and OAuth2.

@basdijkstra would you like to support all the Auth types ? I am pretty pulling them up from postman

I’m not planning to support authentication schemes just ‘because Postman does it’.
I’m obviously happy to add support for additional schemes, if people have a use case for it.


An error occurred, view the console for more information.

[Enter steps to reproduce:]

...
...

Atom: 1.26.0 x64
Electron: 1.7.11
OS: Mac OS X 10.13.4
Thrown From: Atom Core
Stack Trace
An error occurred, view the console for more information.
At undefined

undefined

Commands
     -0:51.9.0 application:open (input.hidden-input)
     -0:12.8.0 tree-view:remove-project-folder (span.name.icon.icon-repo)
     -0:10 application:add-project-folder (input.hidden-input)

Non-Core Packages
atom-ternjs 0.18.3
atom-yarn 0.7.0
autocomplete-json 5.5.2
busy-signal 1.4.3
file-icons 2.1.19
flow-ide 1.11.0
git-plus 7.10.2
hyperclick 0.1.5
intentions 1.1.5
linter 2.2.0
linter-eslint 8.4.1
linter-ui-default 1.7.1
prettier-atom 0.53.0
pretty-json 2.0.0
teletype 0.13.1

Thanks for the report!  Can you confirm a few things for us?

what were you doing at the time of the error?
is the error is reproducible?
if reproducible, do you see the error in safe mode (atom --safe)?

Also, can you share a screenshot of what you see in devtools console?

Thanks again for your issue!
We haven't received a response to our question in this comment https://github.com/atom/atom/issues/17220#issuecomment-384726357. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

Hi, I'm experiencing the same error.
Answers to your questions:

Opening Atom
Every time I open Atom
I do not.

For me, it looks like it was an issue with the atom-yarn package. I removed that an the issue went away.

For me, it looks like it was an issue with the atom-yarn package. I removed that an the issue went away.

Thanks for tracking that down, looks like the OP has atom-yarn installed as well.
Since it appears that this is being caused by atom-yarn, we'll need the maintainer of the package to help track that down. You can file this issue on their repository so they can either fix the problem or tell us where the problem is coming from since the bug could still be in Atom. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.


CFY-5598 Keep the workflow ctx when using .deployment_contexts

It would be better to not require being in workflow ctx for CloudifyWorkflowContext.__init__, but i don't think that is possible right now.


Cannot find path '/Users/username/Desktop/librealsense/wrappers/python/dist' because it does not exist.

Ran the script using 'pwsh librealsense-python-mac.ps1' command and this error is thrown at the very end. Tried to pip install using 'pip install pyrealsense2-2.48.0-cp39-cp39-macosx_11_0_x86_64.whl' and I get an error saying it "is not a supported wheel on this platform." Where did I mess up?

There might be an error during the build. You would have to go through the log and check where the error happens.


Add documentation on GameObject

Add documentation on GameObject

#14 should be done first

Done in commit https://github.com/Sygmei/ObEngine/commit/94ba6b07dcd10ec57ffbf764f911c465a731e36f


core: do not append newlines to ouputs unless list/tuple

Instead of treating all stdout and stderr outputs as string lines
to have newlines, respect the stdout/stderr parameters provided to
register_subprocess().  This allows for more control of the fixture
and allow for binary inputs (and text data with line breaks other
than os.linesep).
Preserve the prior functionality when outputs are a list/tuple. In
this context, it makes sense to treat the inputs as a sequence of
text lines.
Update documentation to show both methods, add test cases for binary
data, and update existing tests that relied on the newline behavior.
Fixes #33
Signed-off-by: Chris Patterson<EMAIL_ADDRESS>

Great job, thanks! I've noticed your issue but didn't have time to work on it yet. Thank you for implementing the fix.

@aklajnert Thanks for merging and tagging so quickly :D


Various problems styling histograms

I am trying to put two histograms next two each other, one of which has the group 'Nowak'. I first tried this cell magic:
%%opts Histogram.Nowak (color='r')
...

Nothing happens! I look into the issue and figure out that 'color' has no effect but 'facecolor' does:
%%opts Histogram.Nowak (facecolor='r')
...

Rather confusing (due to matplotlib's confusing API I think) and worth filing an issue for in itself. Anyway, was no bug to report as such until I tried setting the alpha as well:
%%opts Histogram.Nowak (facecolor='r' alpha=0.5)
...

The alpha was applied but the histogram has gone back to blue! Any idea what is happening here Philipp?

I restarted the kernel and it now works.
Must be due to bad options sticking around in the session. This is very annoying and I am not sure how we can fix it if we want option inheritance etc.

I'm going to close this issue now as I think it is actual a duplicate of #109


Should the homebrew tap formula file name have a different casing than the cask name?

I'm currently creating another homebrew cask with a hyphen in its name. I'm not a homebrew expert, but I was under the impression that the formula file name should be equal to the formula/cask name in the file. But it seems like jreleaser modifies the .rb file name to remove hyphens and capitalize parts.
When creating a cask with a hyphen in jreleaser, the homebrew client will complain about the mismatch in file names and cask names and refuse to install the cask.

From the docs at https://docs.brew.sh/Cask-Cookbook
The Cask name (<cask-token>) on the header line cask <cask-token> do should match the cask filename, without the .rb extension, enclosed in double quotes.

Alright then this is probably jreleaser bug. The file name is then not correct for casks, haven't tested with formulas yet.

Additional info regarding formula naming conventions https://docs.brew.sh/Formula-Cookbook#a-quick-word-on-naming

🎉 This issue has been resolved in v1.13.0 (Release Notes)


Toast customization - toast wrapper border color and toast CSS property

Feature Request
Ionic version:

[x] 4.x
Describe the Feature Request
Beta 16 added the --color property to the toast component, and toast-wrapper was put into shadow dom meaning we can no longer style the toast content.
I added CSS definitions that worked in beta 13 that added borders to toast-wrapper, which indicated success / error / info / warning / etc. After upgrading it's no longer possible to use these definitions.
Describe Preferred Solution
I would either like to see a --border property exposed to the toast-wrapper, or to have the toast's CSS property added to the .toast-wrapper like this post recommends @see https://github.com/ionic-team/ionic/issues/16253
Related Code
Ionic related code:
this.toast = await this.toastCtrl.create({
      duration: 500000,
      position: 'top',
      message:  text,
      // color:    color,
      cssClass: color, // Currently useless as far as I can tell.
    });

Example of the CSS definitions I'd like to continue to be able to use:
ion-toast {
  text-align: center;

  &.info {
    .toast-wrapper {
      border: 2px solid var(--app-component-border);
    }
  }

...
}

Additional Context
app $ ionic info

Ionic:

   ionic (Ionic CLI)             : 4.5.0 (/Users/developer/.npm-packages/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.17
   @angular-devkit/build-angular : 0.10.7
   @angular-devkit/schematics    : 7.0.7
   @angular/cli                  : 7.0.7
   @ionic/angular-toolkit        : 1.2.0

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.1.4, (and 12 other plugins)

System:

   Android SDK Tools : 26.1.1 (/Users/developer/Library/Android/sdk)
   ios-deploy        : 2.0.0
   NodeJS            : v8.12.0<EMAIL_ADDRESS>   npm               : 6.4.1
   OS                : macOS High Sierra
   Xcode             : Xcode 9.4.1 Build version 9F2000

Closed by #16679

@ashinpaugh With the next beta, you can add your cssClass and then use this variables:
   * @prop --border-color: Border color of the toast
   * @prop --border-radius: Border radius of the toast
   * @prop --border-width: Border width of the toast
   * @prop --border-style: Border style of the toast

For example:
ion-toast.info {
--border-radius: 20px;
--border-width: 5px;
--border-style: double;
--border-color: yellow;
}

Cheers man - much appreciated.


docs: fit transform addition

I am missing a method that might allow fitting a transformation and returning the transformed result in a single call.
Here there is an  example from sklearn that shows the usage of fit_transform
>>> from sklearn.feature_extraction.text import CountVectorizer
>>> corpus = [
...     'This is the first document.',
...     'This document is the second document.',
...     'And this is the third one.',
...     'Is this the first document?',
... ]
>>> vectorizer = CountVectorizer()
>>> X = vectorizer.fit_transform(corpus)
>>> vectorizer.get_feature_names_out()
array(['and', 'document', 'first', 'is', 'one', 'second', 'the', 'third',
       'this'], ...)
>>> print(X.toarray())
[[0 1 1 1 0 0 1 0 1]
 [0 2 0 1 0 1 1 0 1]
 [1 0 0 1 1 0 1 1 1]
 [0 1 1 1 0 0 1 0 1]]

Note that you could just think that  fit_transform simply has fit and transform inside as two function calls, but this would require iterating over the data twice (one for each function call).
One benefit of fit_transform  is that it can iterate only once over the data and generate the transformed data while it is iterating  over it.
If no specific efficient fit_transform   is implemented it could be just sintactic sugar for calling fit!(transformer, X) and then transform(transformer, X)

Sorry for my late response, and thanks for bringing this up.
Yes, I understand that there is a use-case for fitting and transforming in one go; as you say one can avoid extra computation/allocation.
Currently my head is around reducing methods as much as possible, and so I will come back to this but keep it in mind.

closing in favour of #18


Fix missing uninstall calls for tooltips

Fixes #1421

Lets see if that was it but I can imagine so. There where lots of tooltips in memory dump

@Katharsas did you check if tooltips are removed in chat as well?

I think the tooltips are never removed but i think the difference is that the tooltip is not held by an external Controller

So should be fine

We basically made a search for *.install in all sources and made sure that every install has corresponding uninstall. Don't remember if we found chat stuff.


[5.6] Add filledAny method to Request

Currently to determine if the request has any filled values of a list of inputs, you do something like this:
if ($request->filled('disk') || $request->filled('site')) {
    //
}

This allows you to check if the request has filled values for any of the keys - similar to the existing hasAny.
if ($request->filledAny($filters)) {
    //
}

Although $request->filled($keys) accepts an array, it checks to determine if all the keys exist rather than any.

I think anyFilled is a better method name than filledAny, thoughts?


Added missing include for std::min & std::max in FreeImage dependency

This solved the issue in building the DLL on Windows for me.

Going to open this PR on original repository

Sweet, thanks :+1:


The data downloaded in the download folder of the cache does not respect umask

Describe the bug
For a project on a cluster we are several users to share the same cache for the datasets library. And we have a problem with the permissions on the data downloaded in the cache.
Indeed, it seems that the data is downloaded by giving read and write permissions only to the user launching the command (and no permissions to the group). In our case, those permissions don't respect the umask of this user, which was 0007.
Traceback:
Using custom data configuration default
Downloading and preparing dataset text_caps/default to /gpfswork/rech/cnw/commun/datasets/HuggingFaceM4___text_caps/default/1.0.0/2b9ad220cd90fcf2bfb454645bc54364711b83d6d39401ffdaf8cc40882e9141...
Downloading data files: 100%|████████████████████| 3/3 [00:00<00:00, 921.62it/s]
---------------------------------------------------------------------------
PermissionError                           Traceback (most recent call last)
Cell In [3], line 1
----> 1 ds = load_dataset(dataset_name)

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/load.py:1746, in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, ignore_verifications, keep_in_memory, save_infos, revision, use_auth_token, task, streaming, **config_kwargs)
   1743 try_from_hf_gcs = path not in _PACKAGED_DATASETS_MODULES
   1745 # Download and prepare data
-> 1746 builder_instance.download_and_prepare(
   1747     download_config=download_config,
   1748     download_mode=download_mode,
   1749     ignore_verifications=ignore_verifications,
   1750     try_from_hf_gcs=try_from_hf_gcs,
   1751     use_auth_token=use_auth_token,
   1752 )
   1754 # Build dataset for splits
   1755 keep_in_memory = (
   1756     keep_in_memory if keep_in_memory is not None else is_small_dataset(builder_instance.info.dataset_size)
   1757 )

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/builder.py:704, in DatasetBuilder.download_and_prepare(self, download_config, download_mode, ignore_verifications, try_from_hf_gcs, dl_manager, base_path, use_auth_token, **download_and_prepare_kwargs)
    702         logger.warning("HF google storage unreachable. Downloading and preparing it from source")
    703 if not downloaded_from_gcs:
--> 704     self._download_and_prepare(
    705         dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs
    706     )
    707 # Sync info
    708 self.info.dataset_size = sum(split.num_bytes for split in self.info.splits.values())

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/builder.py:1227, in GeneratorBasedBuilder._download_and_prepare(self, dl_manager, verify_infos)
   1226 def _download_and_prepare(self, dl_manager, verify_infos):
-> 1227     super()._download_and_prepare(dl_manager, verify_infos, check_duplicate_keys=verify_infos)

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/builder.py:771, in DatasetBuilder._download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs)
    769 split_dict = SplitDict(dataset_name=self.name)
    770 split_generators_kwargs = self._make_split_generators_kwargs(prepare_split_kwargs)
--> 771 split_generators = self._split_generators(dl_manager, **split_generators_kwargs)
    773 # Checksums verification
    774 if verify_infos and dl_manager.record_checksums:

File /gpfswork/rech/cnw/commun/modules/datasets_modules/datasets/HuggingFaceM4--TextCaps/2b9ad220cd90fcf2bfb454645bc54364711b83d6d39401ffdaf8cc40882e9141/TextCaps.py:125, in TextCapsDataset._split_generators(self, dl_manager)
    123 def _split_generators(self, dl_manager):
    124     # urls = _URLS[self.config.name] # TODO later
--> 125     data_dir = dl_manager.download_and_extract(_URLS)
    126     gen_kwargs = {
    127         split_name: {
    128             f"{dir_name}_path": Path(data_dir[dir_name][split_name])
   (...)
    133         for split_name in ["train", "val", "test"]
    134     }
    136     for split_name in ["train", "val", "test"]:

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/download/download_manager.py:431, in DownloadManager.download_and_extract(self, url_or_urls)
    415 def download_and_extract(self, url_or_urls):
    416     """Download and extract given url_or_urls.
    417
    418     Is roughly equivalent to:
   (...)
    429         extracted_path(s): `str`, extracted paths of given URL(s).
    430     """
--> 431     return self.extract(self.download(url_or_urls))

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/download/download_manager.py:324, in DownloadManager.download(self, url_or_urls)
    321 self.downloaded_paths.update(dict(zip(url_or_urls.flatten(), downloaded_path_or_paths.flatten())))
    323 start_time = datetime.now()
--> 324 self._record_sizes_checksums(url_or_urls, downloaded_path_or_paths)
    325 duration = datetime.now() - start_time
    326 logger.info(f"Checksum Computation took {duration.total_seconds() // 60} min")

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/download/download_manager.py:229, in DownloadManager._record_sizes_checksums(self, url_or_urls, downloaded_path_or_paths)
    226 """Record size/checksum of downloaded files."""
    227 for url, path in zip(url_or_urls.flatten(), downloaded_path_or_paths.flatten()):
    228     # call str to support PathLike objects
--> 229     self._recorded_sizes_checksums[str(url)] = get_size_checksum_dict(
    230         path, record_checksum=self.record_checksums
    231     )

File /gpfswork/rech/cnw/commun/conda/lucile-m4_3/lib/python3.8/site-packages/datasets/utils/info_utils.py:82, in get_size_checksum_dict(path, record_checksum)
     80 if record_checksum:
     81     m = sha256()
---> 82     with open(path, "rb") as f:
     83         for chunk in iter(lambda: f.read(1 << 20), b""):
     84             m.update(chunk)

PermissionError: [Errno 13] Permission denied: '/gpfswork/rech/cnw/commun/datasets/downloads/1e6aa6d23190c30885194fabb193dce3874d902d7636b66315ee8aaa584e80d6'

Steps to reproduce the bug
I think the following will reproduce the bug.
Given 2 users belonging to the same group with umask set to 0007

first run with User 1:

from datasets import load_dataset
ds_name = "HuggingFaceM4/VQAv2"
ds = load_dataset(ds_name)

then run with User 2:

from datasets import load_dataset
ds_name = "HuggingFaceM4/TextCaps"
ds = load_dataset(ds_name)

Expected behavior
No PermissionError
Environment info

datasets version: 2.4.0
Platform: Linux-4.18.0-305.65.1.el8_4.x86_64-x86_64-with-glibc2.17
Python version: 3.8.13
PyArrow version: 7.0.0
Pandas version: 1.4.2

note, that datasets already did some of that umask fixing in the past and also at the hub - the recent work on hub about the same: https://github.com/huggingface/huggingface_hub/pull/1220


QR Code Reader problem with lenovo note 3 ?

In my android app has problem to read qr code with lenovo note 3. moto , samsung device working properly . what are the device support this library.

Can you post your stacktrace please?


[otbn] Update the instruction coding

This is the instruction coding before battlefield testing. Final
collisions are fixed.
This fix also removes some overloading of field names by creating
explicit coding schemes with more correct naming fields.
Signed-off-by: Stefan Wallentowitz<EMAIL_ADDRESS>

Great, thanks! I've integrated the changes (which needed a bit of fiddling because of splitting the mulqacc instruction) and they should now appear in the OT PR.


Improve xml export functions

Check whether django is now providing a good serializing library

it seems we can link this topic with the implementation of the REST interface https://stackoverflow.com/questions/30729207/serialize-model-object-with-related-objects-to-json


published article

Not an issue with the code but just letting you know that the pdf link at the accepted Chemformer version in Mach Learn: Sci Technol doesn't actually link to your article. It has your title on the front page but the rest of the pdf is an article called "Physics makes the difference: Bayesian optimization and active learning via augmented Gaussian process" by Ziatdinov et al. Just in case you want to tell the journal to correct it.

Thanks for letting me know, the journal has been informed.


[Bug]: Upgrade to Guava 32+ to fix CVE-2023-2976

Module
Core
Testcontainers version
1.19.0
Using the latest Testcontainers version?
Yes
Host OS
any
Host Arch
any
Docker version
irelevant

What happened?
I hope my understanding is correct that the shaded org/testcontainers/shaded/com/google/common/io/FileBackedOutputStream.class file in org.testcontainers:testcontainers:1.19.0 comes from guava 30.1.1-jre:
https://github.com/testcontainers/testcontainers-java/blob/1.19.0/build.gradle#L8
Guava versions >= 1.0, < 32.0.0 suffer from CVE-2023-2976 alias https://github.com/google/guava/issues/2575
It would be nice to upgrade the shaded Guava and release
Relevant log output
No response
Additional Information
No response

Hi @ppalaga, that guava version is used by japicmp plugin for gradle configuration purposes. The shaded guava library is coming from https://github.com/docker-java/docker-java which is not being used anymore.

#7524 should fix it but will take a look in more detail once I'm back from vacation.

you can also exclude it and it should be fine

#7534 should fix it but will take a look in more detail once I'm back from vacation.

Thanks, I have built #7534 and the output of javap -c FileBackedOutputStream.class embedded in testcontainers ressembles the one from guava 32.1.2-jre.
When can we expect a release with the above fix?


feature Remove deprecated temporary in `CreateRowsetRequest

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Task - Edit Source - Add PDF button

Please add PDF button next to pin button if PDF file is available.

Added there in documentation panel and radial annotator


Add timestamp attribute testsuite element in xunit output

Python junitparser expects that there is  timestamp attribute testsuite element.
Also Pytest puts timestamp attribute testsuite element. Example Pytest has:
<testsuite name="pytest" errors="0" failures="0" skipped="2" tests="46" time="18.169" timestamp="2021-09-01T04:43:16.364650" hostname="something">
In Robot Framework there is: <testsuite name="Test" tests="435" errors="0" failures="4" skipped="0" time="244.974">
Is somewhat related to: #2982 and #3944

This is definitely a valid enhancement. Having timestamps sounds like a good idea in general and being compatible with the junitparser module is important on its own right as well. Probably should enhance the current tests to use junitparser to make sure we stay compatible. The main problem with all xunit output enhancements is that there's no official schema for that format. Using junitparser a reference is a good idea in that sense as well.
This needs to be implemented together with #2982 and should also look at #3944 at the same time.

Seems that output.xml file is 'single source of truth' for xunit output file as well. Timestamp attribute could be parsed relatively easy from testsuite's starttime. That leads implementation options to consider:

We just 1:1 convert timestamp from testsuite's starttime.

I am not sure how breaking change option 3 is. Options 1 & 2 are Robot Framework 'flavors' anyway. So, I would keep compatibility to junitparser and choose option 2.
Comments welcome!

I don't have strong opinion, but option 2 feels best.

Compatibility with junitparser is very important so option 2 is clearly the best.
Changing output.xml timestamp format is a subject of a different issue. I doubt times below milliseconds really matter in acceptance testing (there's e.g. overhead by the framework itself), but we should at least consider switching to ISO 8601 format. I'd like to change how times are handled internally as well, but I doubt that's important enough to make it into RF 5.0.

As I commented #4144, we need to decide how to handle suites not containing start time. Typically suites have it, but at least when combining results with rebot the root suite doesn't. I believe alternatives are not having timestamp at all or having timestamp=''. I'd prefer the former because it makes it explicit you need to handle that case separately, but I guess always having a timestamp has its benefits as well.
I already tested that junitparser doesn't actually require the timestamp attribute. It can parse our current xunit.xml file just fine and the resulting TestSuite.timestamp will be None.

Implemented in PR #4074 by @rikerfi. Thanks for contribution!