Add support for Disqus alternative

Pick an open source, privacy conscious, free and easy to host (like using Github or Gitlab) alternative.
For example,

https://github.com/gitalk/gitalk
https://github.com/imsun/gitment
https://vssue.js.org/
https://github.com/eduardoboucas/staticman

We will pick one, that is most active and has best support.
We will also move documentation site to that solution.
Activity on these alternates clearly indicate Disqus is not the only game in town for static sites anymore. We should switch.

I will be very glad to have disqus open source alternative

Sure they are a lot of Disqus alternative witch explained nicely here. Categorized into: Integrated third-party, Off-site hosting, Self-hosted, and GitHub/Gitlab.
I think we are here focusing on Github/Gitlab categories:

https://github.com/utterance/utterances ; 808 :star: ; Github only
https://github.com/imsun/gitment : 3,428 :star: ; Github only
https://github.com/eduardoboucas/staticman : 1,337 :star: ; Github/Gitlab

this is hugo + staticman, and jekyll + staticman. Would be awesome if we had [Elegant + staticman].
I like staticman more because we able to use Gitlab issue, if something bad happen, we still have those comments in our hand. cause Gitlab is open.

Note to self:

https://victorzhou.com/blog/replacing-disqus/
https://old.reddit.com/r/programming/comments/b9022a/switching_off_of_disqus_reduced_my_page_weight_by/

In docs, highlight the fact that elegant loads Disqus only when comments accordion is clicked.

I like staticman more because we able to use Gitlab issue, if something bad happen, we still have those comments in our hand. cause Gitlab is open.

@azzamsa Hi, this is the maintainer of @staticmanlab, a public GitLab instance of Staicman.  Staticman makes use of GitHub/GitLab Pull/Merge Requests instead of issues.  Under Staticman's model, static comments are YML/JSON files stored in the remote GitHub/GitLab repo (usually under data/comments, configurable through the path parameter in root-level staticman.yml), and through a static blog generator (Jekyll/Hugo/etc), the stored data are rendered as part of the content.  This gives a total ownership of a static site's comments.
IMHO, comments are part of the site's content, not a problem of a software package.  To illustrate this, let me use an MR for a static comment received on my Framagit+Beautiful Hugo+Staticman demo site.

Field
Content

replyThread

replyID

replyName

comment
Essai : $n!\underset{+\infty}{\sim}\left(\frac{n}{e}\right)^n\sqrt{2\pi n}$.

Ok ? :smiley:

name
François Coulombeau

email
137743b032171d66c4caa2be6b0884c3

website

date
2019-02-28T22:44:08.269Z

This is rendered as

Image URL: http://imgur.com/KRTtJLXl.png
in my page.

@talha131 Among the three alternatives to Disqus that @azzamsa has suggested, only Staticman doesn't load external JavaScripts for comment retrieval.  The other two come with scripts.  I've not tried to install them, so I can't tell the impact on the load speed.  However, as the screenshot shoes, Staticman allows writing in Markdown (or even in LaTeX if you want), and doesn't require the commenter to login to GitHub/GitLab.  That would greatly facilitate the commenting process.

I have heard really good stuff about https://posativ.org/isso/ and the last time I looked for a lightweight self-hosted comment system, that seemed the best option to me.
The repo seems to be still actively maintained as well.

They present themselves as drop-in replacement for disqus, so probably a nice try to just 'add-it' by copying what's there for disqus

This may be relevant then: https://github.com/getpelican/pelican-plugins/issues/341

I was checking and it seems to require you to host the server (that stores in sqlite), so really not a replacement for disqus that is provided by 3rd party but still can be integrated and whoever wants it, can just use by setting fewer things on Elegant

Exactly what @iranzo has pointed out. isso is great but it requires user to self host it. Other options like staticman does not require setting up a host. All they need is configuring a github or gitlab repository which is far easier than setting and maintaining a host.
Nonetheless adding support for isso should not a big problem though we won't be able to test it. I say we put off isso support until some user steps up who has an isso instance running.

I've tested Isso to see verify its claim about Markdown syntax support.  Unluckily, images aren't rendered on the demo site.

Image: my sample Isso comment
Source of the test comment:
How about blockquotes and pictures?

> Sample quote

Sample picture?
![sample picture](https://staticman-gitlab-pages.frama.io/huginn/img/avatar.png)

Expected results:

How about blockquotes and pictures?

Sample quote

Sample picture?

The bottom part of Isso's overview contains some more links to open-source commenting services, so Isso isn't the only alternative.

They present themselves as drop-in replacement for disqus, so probably a nice try to just 'add-it' by copying what's there for disqus

@iranzo @silverhook I really like it's edit functionality, apart from being lightweight.  That might help eliminate typos and enhance user experience.  I would like to draw your attention to some SEO issues about Isso before drawing the conclusion.
I've tried simulating how a search bot view the demo page.  As espected, the Isso comments aren't displayed in the simulated results. Perhaps that's what the bot actually sees.

...

Demo

IMO, useful comments are usally static contents (at least, after the allowed period of 15 minutes) of the site and they should be treated as part of the page contents.

Exactly what @iranzo has pointed out. isso is great but it requires user to self host it. Other options like staticman does not require setting up a host.

@talha131 You're right that using Staticman doesn't require setting up a host as longs you're using the one setup by someone else.  I've set up mine for testing Staticman PR 219.1  That might be sufficient for small and personal sites.  For bigger ones, a custom API instance might suit your needs better because unnotified updates won't break things (c.f. eduardoboucas/staticman#283).

Please note the convenience-customisability tradeoff: simple code comes with a bunch of pre-defined config.  To tailor it to your needs, one has to go deep into the settings.  For instance, Isso don't support Markdown preview.  Nonetheless, although (and because) a Staticman's minimal example can be so basic that you may add any features you like, like

adding scores :star: to HTML forms
enable Markdown preview
enable reCaptcha support (see the second example, not suuported in posativ/isso#201)

I've set deployed one for GitLab.com and one for Framagit since it's API config parameter gitlabBaseUrl supports at most one GitLab instance.

One more alternative is Netlify comments

https://github.com/netlify/gotell
https://github.com/netlify/netlify-comments-starter

It needs to be confrimed if using it blocks user in the Netlify eco system or not.

Staticman feature of anonymous posting is very useful. But I just tried the demo and it's not working.

I also tried @VincentTam website. When I posted a comment, it took me to this page

which is not very user friendly.
Lets not give up on staticman for a while and see if the issue gets fixed.

I don't like gitment for this reason

After the page is published, you should visit your page, login with your GitHub account(make sure you're repo's owner), and click the initialize button, to create a related issue in your repo. After that, others can leave their comments.

Other options require Github account to comment. Of all of them utterances seems the easiest.

Summary, so far,

I like staticman but we can't use it if it is unmaintained
We should avoid Github account restriction if possible
I am yet to review Netlify comments
After staticmen, my second preferrance is utterances

Staticman feature of anonymous posting is very useful. But I just tried the demo and it's not working.

I also tried @VincentTam website. When I posted a comment, it took me to this page

which is not very user friendly.
Lets not give up on staticman for a while and see if the issue gets fixed.

@talha131 Which browser/OS are you using?  I couldn't reproduce that error with Firefox on Ubuntu 18.04 LTS.

@VincentTam thanks for the prompt response. I am using Firefox dev editon 68.0b11 (64-bit) on 10.14.6 Beta.
Let me try your site on Chrome.

Your site works on Chrome. Probably some Firefox setting or addon is interfering causing the issue.
Though Staticman demo does not work even in Chrome.

@VincentTam thanks for the prompt response. I am using Firefox dev editon 68.0b11 (64-bit) on 10.14.6 Beta.

You're welcome, though I can't help much on technical stuff like browser/OS-specific issues.

I missed to note that staticman needs a server instance to run its app, something we can't expect from users.

Staticman does require an API instance, but it can be a third-party one instead of your own.  As a result, many users have chosen the official production/development API instances for convenience.  Nonetheless, some users have reported unexpected error in https://github.com/eduardoboucas/staticman/pull/285 due to unnotified updates in the official API instances.  To reassure stable static comment service, I suggest using an alternative API instance.
:information_source: As my user bio reads, I've built @staticmanlab.

Though Staticman demo does not work even in Chrome.

The official Popcorn demo is using Staticman v2, which will be obsolete due to v3.  As I don't know Node.JS and GitHub Apps, I'm not interested in finding out the actual cause.  Staticman v3's change from a GitHub bot user to a GitHub App might cause such error, but who knows?

I develop a comment system called JustComments. There is a hosted version starting from $5 per month or one can also self-host it using https://github.com/JustComments/jc-server and https://github.com/JustComments/jc-widget (feature set is a bit limited although one could extend it)
@talha131 told me that JustComments was considered but I actually don't see a link to it so take a look pls.

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Oh, now we decide to use utterances, according to this commit: https://github.com/Pelican-Elegant/elegant/commit/a2151cc25c5a49b7ef6dd7f86e7ebc5bac03465f
The reason based on @talha131 comment https://github.com/Pelican-Elegant/elegant/issues/288#issuecomment-505424976

we love staticman, but it's unmaintained.
our second preference is utterances, the cons of this is we have to have Github account (even though we want to avoid Github restriction). We choose this way (utterances) because it's the easiest for end user and still maintained.

Is my summary true @talha131 ?

@azzamsa I chose utterances because

At the time of dev, the staticman demo was not working. It was clear it is not being maintained or their bot is under heavy load.
Utterances demo page worked well.
It was a breeze to set up and integrate.
It has theme support. Something we can tweak in the future.
Finally, Philipp Oppermann's blog uses it.

It does not mean Utterances is the last comment system to be added to Elegant. We are open to PR for other comment system.
My personal preference is these options.

https://just-comments.com/
https://github.com/umputun/remark
https://www.talkyard.io/

I didn't pick these options for this issue because they require a server to set up or pay for service.
Although they are much better than Utterances. I may add support for these in the future. Others are welcome to open PR.

Hi. thanks for that. Yeah for now I think the simplest one is utterances. Besides it use proprietary github issue. We have no other choices for now except self-hosting (which can be daunting task for end-user).
Btw. Why I don't find UTTERANCES_REPO value in both of this config https://github.com/Pelican-Elegant/elegant/blob/master/documentation/pelicanconf.py, and https://github.com/talha131/onCrashReboot/blob/master/pelicanconf.py ? Is this intended? so the default value is the repo it hosted?

We have no other choices for now except self-hosting (which can be daunting task for end-user).

Yeah, that's the issue. Right now, I am not sure if our users are willing and able to host their own servers or to put out money for hosted solutions like just-comments or TalkYard.
I am waiting for users to come up.

That's what I'm thinking too. Let's say we bought smallest droplets, it's 5$/month just in order to self host isso. I think my blog don't need that for now. It's not worth for blog that didn't have that huge visitors.

I think my blog don't need that for now. It's not worth for blog that didn't have that huge visitors.

Have a look at TalkYard pricing. Or use Amazon Lightsail to host Remark. Remark does not require separate DB. It's less than $5, though personally I cannot justify it too for my blog which I haven't got in the habit of regularly updating yet.

At the time of dev, the staticman demo was not working. It was clear it is not being maintained or their bot is under heavy load.

@talha131 There're an array of working Staticman v3 demos on Framagit.
Let me repeat again, the official popcorn demo doesn't work since the HTML form action URL hasn't been updated with Staticman v3 API scheme introduced in Staticman PR 219 AND the bot @staticmanapp is unavailable, as reported in eduardoboucas/staticman#306.  The demo is not maintained doesn't mean that the node.js app doesn't work.  Other Staticman bots like @staticmanaima, @Bloggerbust-bot function well.


Email previews were confusing to setup

NOTE
This is just feedback as I am messing around.
We have an abstract Carbon::EmailPreviews with an abstract previews method that returns a hash. We currently only allow one class to be passed in and we provide one class-level  method that only "news" up the instance to access the hash.
I had a bit of confusion about using this class:

No docs on how to set up the class (totally fine and expected)
I had to cast my email to Carbon::Email to use it in the hash

def previews
  {
    "User Confirmation" => UserConfirmationEmail.new(UserQuery.first).as(Carbon::Email)
  }
end

The preview requires there to be a user in the database for it to work

Maybe we can switch to class-level methods to register email previews and make it a bit easier to work with with?
class Email::Previews < Carbon::EmailPreviews
  register "User Confirmation" do
    UserConfirmationEmail.new(UserQuery.first)
  end
end

It's just an idea, but maybe it will make the API cleaner?

Ah. So it's sort of a Crystal related thing, but if you cast your hash as of String => Carbon::Email, then each email doesn't have to be cast separately. We do the same thing in the AppServer. We could probably make a generator that sets it up for you with some docs and examples. lucky gen.email_preview
I ado agree it's a little wonky though. I had a lot of issues trying to get this setup in another way. I kept running in to weird compiler issues. If you can figure out a better interface that's a bit more type-safe and user friendly, I'd be open to that.

The preview setup is a lot more simple now, and works similar to how our middleware stack works. I'm going to close this for now.


#38 Replaced left shift task modifiers with doLast calls

Replaced the << operations with doLast

Looks good -- thanks for your contribution!


chore: upgrade dependencies

bumps all dependencies to their latest versions.
node-fetch is the only package with breaking changes, however those should not affect this package since Next.js requires Node.js v12 and node-fetch drops support for versions earlier than Node.js 10.17.

See #121


[3.0] verify method config, extract ConfigKeys

What is the purpose of the change
Verify method config, extract ConfigKeys.
How to ignore invalid method config:  dubbo.config.ignore-invalid-method-config=true
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8173 (e8793dd) into 3.0 (e2d1ec0) will decrease coverage by 0.18%.
The diff coverage is 75.86%.

@@             Coverage Diff              @@
##                3.0    #8173      +/-   ##
============================================
- Coverage     63.58%   63.40%   -0.19%
+ Complexity      313      310       -3
============================================
  Files          1074     1074
  Lines         45211    45188      -23
  Branches       6807     6777      -30
============================================
- Hits          28749    28652      -97
- Misses        13272    13335      +63
- Partials       3190     3201      +11

Impacted Files
Coverage Δ

...ain/java/org/apache/dubbo/config/MethodConfig.java
87.96% <ø> (ø)

...org/apache/dubbo/config/context/ConfigManager.java
77.19% <ø> (ø)

...ot/autoconfigure/DubboConfigurationProperties.java
49.47% <ø> (ø)

...g/apache/dubbo/config/AbstractInterfaceConfig.java
86.94% <75.86%> (+0.27%)
:arrow_up:

...ng/transport/dispatcher/all/AllChannelHandler.java
68.96% <0.00%> (-27.59%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
47.82% <0.00%> (-15.22%)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0.00%> (-15.22%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
:arrow_down:

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d1ec0...e8793dd. Read the comment docs.


[Monitor Query] Improve large query notebook sample

Add additional info and code about processing chunks of queried data on the fly. Also added error checking in the batching functions.

API change check
API changes are not detected in this pull request.


Release for django 2.0 support

Looks like in https://github.com/viewflow/django-material/commit/e67bed5a4b44bc11c7a058cd034be281830c5848 Django 2.0 is now supported but do we have a new release date for django-material ? Django 2.0 went live a few days ago

Django-material/Viewflow opensourced and pro versions with django 2.0 support would be available at the December or early January next year.

Hi !
I'm using the master branch, trying to enable the admin design, is it gone in favor of the frontend system ?
Thanks ;)


Static content can have children

Static content can have children.

I uploaded a fix for this.

There is a problem with Ajax. The parent content can be selected but is not saved.

This was fixed on Bludit v3.10.0. I closed the issue.


Online API docs are not updated

#537 fixes a typo in the api docs but the typo is still visible on http://api.lightning.community/#subscribeinvoices. It seems the docs are manually updated or stopped updating? How does the update process work?

@thijstriemstra no I don't think there's anywhere else to file this, I believe @MaxFangX just needs to update it, but it's not an actual issue with lnd so I gave it the upstream tag to make that more clear :)

Actually, opening an issue on https://github.com/lightninglabs/lightning-api would probably be more suitable

We updated the docs today!

@thijstriemstra you fixed a type in rpcserver.go. The docs are generated from lnrpc/rpc.proto.

Ok, so it's a different file but exact the same typo.


Cashing files from remote FS.

Cashing files from remote FS.
In simple cases download a file if the user's space is big enough.
Future update select eviction algorithm.

Not relevant anymore


resolve error messages

Closes #6199
r? @Eh2406

This is technically excellent, and I think it is an improvement. Now to the hard part of programing, the people. #5452 had several good, and contradictory, advice for how to improve the wording. Specifically that the selected to fulfill is stilted, the use of the name is repetitive, and it ends up needing to be read diagonally. Do you have a suggestion for a clearer error message?

:umbrella: The latest upstream changes (presumably #6400) made this pull request unmergeable. Please resolve the merge conflicts.

Ping @Dylan-DPC or @Eh2406 are you interested in moving this towards completion?  It looks like generally this improves things. It also looks like there are some interesting suggestions in #5452 on how to make it clearer.  I also like spacekookie's suggestion.

There has been a lot of good thinking about how to make this better, I am still available to help anyone that volunteers to make it happen.

@Eh2406 I'd generally be interested to get my hands dirty in cargo some more :)
What is there actually left to do with this PR?

I think it is just finding a wording that is easier to read and less stilted.

@spacekookie yeah you can go ahead and finish it no issues.
Rewording the error message is the only thing left on this (besides resolving the conflict with latest changes)
Thanks

Looks like this was reopened as https://github.com/rust-lang/cargo/pull/6665, so closing in favor of that.


akkoma: 3.6.0 -> 3.7.1

Description of changes
New upstream release: https://akkoma.dev/AkkomaGang/akkoma/src/tag/v3.7.1/CHANGELOG.md#2023-03
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Seems to be running fine here.


.htaccess redirect for www.*.ri.gov

Summary

Add a redirect rule so that any www.*.ri.gov request is redirected to the non-www version.
E.g. we want "www.oha.ri.gov" to redirect to "oha.ri.gov"
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

Documentation reflects changes?
no

CHANGELOG reflects changes?
yes

Unit/Functional tests reflect changes?
no

Did you perform browser testing?
yes (using hosts file to mimic)

Risk level
High

Relevant links
https://thinkoomph.jira.com/browse/RIGA-50

@ben-hamelin just one question. Otherwise looks good.


Return exception instead of string

This PR resolves https://github.com/elixir-explorer/explorer/issues/646
After this PR, the error_message/1 function will return an exception instead of a string.

Which typespecs should change?
Because from what I saw the functions error_message/1, apply/2, apply_series/3, apply_dataframe/3, and apply_dataframe/4 do not have typespecs.

I think entries like this: https://github.com/elixir-explorer/explorer/blob/main/lib/explorer/data_frame.ex#L537
Should now say {:error, Exception.t}, no?

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


kocho helps fails if no config file exists

$ kocho --help
failed to read config file:  Unsupported Config Type ""

How to fix this? kocho template-init doesn't work either.

@teemow Create a config file, even if its empty.

Ok. I've created it like this.
mkdir ~/.giantswarm
touch ~/.giantswarm/kocho.yml


Wrong Assert condition in EncryptDecrypt_Test().

... causing unpassed testing.

... causing unpassed testing.

Thank you, fixed.


Add test cases to the MetaDataService of the soul-admin module. (#507)

Add test cases to the MetaDataService of the soul-admin module. :D

Codecov Report

Merging #580 (7dd8cad) into master (1ea9b31) will increase coverage by 1.71%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #580      +/-   ##
============================================
+ Coverage     25.23%   26.94%   +1.71%
- Complexity      424      454      +30
============================================
  Files           198      198
  Lines          4669     4669
  Branches        497      497
============================================
+ Hits           1178     1258      +80
+ Misses         3370     3287      -83
- Partials        121      124       +3

Impacted Files
Coverage Δ
Complexity Δ

...a/org/dromara/soul/admin/page/PageResultUtils.java
25.00% <0.00%> (+25.00%)
1.00% <0.00%> (+1.00%)

...ava/org/dromara/soul/admin/page/PageParameter.java
76.47% <0.00%> (+35.29%)
5.00% <0.00%> (+1.00%)

.../dromara/soul/admin/listener/DataChangedEvent.java
57.14% <0.00%> (+57.14%)
1.00% <0.00%> (+1.00%)

...a/soul/admin/service/impl/MetaDataServiceImpl.java
100.00% <0.00%> (+93.15%)
28.00% <0.00%> (+26.00%)

.../dromara/soul/admin/transfer/MetaDataTransfer.java
100.00% <0.00%> (+100.00%)
1.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea9b31...7dd8cad. Read the comment docs.


How to integrate test coverage with SonarQube

I am using SonarQube for integrating my test in my build process.
I've seen there is a sonnar-scanner npm package but I don't see how it re-use the code coverage from jest/istanbul.
Anyone has experience with SonarQube and istanbul ?

You'll want to create a sonar-project.properties file with relevent content:
sonar.projectName=<<freetext project name>>

sonar.language=js
sonar.sources=relative/path/to/src
sonar.tests=relative/path/to/tests

sonar.javascript.lcov.reportPaths=path/to/coverage/lcov.info```

Then you can simply run `sonar-scanner` directly.

@adam-moss That's correct. Sonarqube is showing the coverage numbers after passing the "sonar.javascript.lcov.reportPaths" argument.
However, many files, which are excluded in the istanbul cover command are also showing up in the sonarqube dashboard. Consequently, the total LOC is higher and coverage number is lower in the sonarqube dashboard.

@biswasaveek Specify any files you want to exclude using sonar.exclusions
E.g. sonar.exclusions=**/*Bean.java,**/*DTO.java
Source: https://docs.sonarqube.org/display/SONAR/Narrowing+the+Focus

In my case istanbul is generating a report in html format. How could i convert a html report to lcov file formt

Take a look at their github site:
https://github.com/istanbuljs/nyc
From site:

Configuration arguments should be provided prior to the program that nyc is executing. As an example, the following command executes npm test, and indicates to nyc that it should output both an lcov and a text-lcov coverage report.
nyc --reporter=lcov --reporter=text-lcov npm test

In my case istanbul is generating a report in html format. How could i convert a html report to lcov file formt ?

Please follow the below steps to achieve this:

Run the test by running the same command which craigtmoore has mentioned, which is,
nyc --reporter=lcov --reporter=text-lcov npm test

Once step 1 is completed, you must be seeing a file named as lcov.info

Add below property in sonar-project.properties file,
coverage reporting
sonar.javascript.lcov.reportPaths=app/coverage/lcov.info
Note: For more details please refer
https://docs.sonarqube.org/display/PLUG/JavaScript+Coverage+Results+Import

Run the sonar-scanner command from your project root directory.

Result: You must be seeing the code-coverage %age in the generated report by Sonarqube.
Please do comment if still, you're facing the issue.
Thanks

Try adding the -X flag to the  sonar-scanner command it will print debug info which will help you pinpoint why its not picking up your lcov file. You can search the logs with command + f for "lcov" sonar will often times print warnings that it cant find the path to the file which is more than likely the problem

In my case istanbul is generating a report in html format. How could i convert a html report to lcov file formt ?

Please follow the below steps to achieve this:

Run the test by running the same command which craigtmoore has mentioned, which is,
nyc --reporter=lcov --reporter=text-lcov npm test
For more details: Please refer (https://github.com/istanbuljs/nyc)
Once step 1 is completed, you must be seeing a file named as lcov.info
Add below property in sonar-project.properties file,
sonar.javascript.lcov.reportPaths=app/coverage/lcov.info
Note: For more details please refer
(https://docs.sonarqube.org/display/PLUG/JavaScript+Coverage+Results+Import)
Run the sonar-scanner command from your project root directory.

Result: You must be seeing the code-coverage %age in the generated report by Sonarqube.
Please do comment if still, you're facing the issue.
Thanks

thanks, it help me a lot !

do we need any plugin in sonar to publish instanbul coverage report.

As per my understanding, no additional plugin is required. As I have mentioned above I have followed the same steps to integrate the coverage in the SonarQube app.

@biswasaveek Specify any files you want to exclude using sonar.exclusions
E.g. sonar.exclusions=**/*Bean.java,**/*DTO.java
Source: https://docs.sonarqube.org/display/SONAR/Narrowing+the+Focus

I know this was posted a few years ago but I'm a bit confused as to why we need to specify sonar.exclusions when we have already excluded those files in the Istanbul report? I don't see much point having to have exclusions in 2 places.

For the users with perverse fonts in their browsers, it is lcov with l as in lego or lol. Not I.


feature: Do not require APIConversion to exist for APIResourceSchema if no conversion required

Feature Description
Currently, if an APIResourceSchema supports multiple versions and there is no corresponding APIConversion, creating an APIBinding for an APIExport that includes the APIResourceSchema fails. In short, an APIConversion is required for any APIResourceSchema with multiple versions, even if the APIConversion contains no conversion information (i.e. empty spec).
Proposed Solution
If no conversion information is required to move from one version to another, for example when the versions are identical or dropping fields is acceptable, it would be convenient to assume that the lack of an APIConversion is equivalent to the presence of an empty APIConversion.
Alternative Solutions
The alternative would be to keep the current system, or have the system generate the no-op APIConversion in the cluster and manage its lifecycle. However, in the latter case it would be unclear as to whether the user is planning to add an APIConversion but just created the APIResourceSchema first.
Want to contribute?

[X] I would like to work on this issue.

Additional Context
No response

/assign

Thanks for filing! We do need to add a spec field on APIRS to indicate to kcp that the developer intends to supply an APIConversion. We need to know definitively if an APIConversion is expected, or not.

I think @sttts suggested in Slack to have an enum for None and External, with the latter meaning APIConversion. The enum allows more future flexibility (if we ever need it) compared to a bool. I think either approach would work, and it's ok if we get it "wrong" and need to change it later.

@ncdc None and External feels reasonable to me. I do think we should be pretty stringent about separation of concerns between the two types, but that is somewhat orthogonal to preserving flexibility in case we need it.
Given the original set of steps that led to this issue being opened (and mirroring CRD behavior), I would think None should be our default here, but using External as default would be closer to current behavior.


Add support for alt text on gallery images

The build failure is unrelated to any of my changes... I don't think it's worth fixing (the issues are present in the version of the library we've been using forever)


Allow pixel/cell clustering pipeline to restart from checkpoint in case of crash

Is your feature request related to a problem? Please describe.
Testing of example_pixel_clustering.ipynb and example_cell_clustering.ipynb has revealed instances of crashing. If the user needs to restart Docker (ex. to increase memory), it would be inconvenient for them to have to re-run the whole pipeline (or at least one whole step) because of a crash during one component. We should add a way to restart the pipeline at that point in time.
Describe the solution you'd like
There are a couple of problematic scenarios I see this popping up where this will need to be addressed (potentially more to be added):

SOM training: this one could be the trickiest to implement, as the SOM function in FlowSOM does not currently support restarting from a checkpoint. This is a feature we may need to add in our local forked version of FlowSOM if desired. We can see if we can save a snapshot of the weights and the number of passes we've already computed.
Pixel clustering and consensus assignment: in this case, we should have a control statement in the assignment loop to prevent having to re-assign FOVs that have already been fully processed. We should also check to see if the weights in a particular run folder have been generated so we don't re-run the SOM training.

I was just thinking the same thing. The SOM training is actually quite fast, and there's no intermediate progress that gets rewritten, so I don't think that one is a big issue. The main thing, as you mentioned, is the FOV-level processing.
I think adding an overwrite=True argument to each of the batch processing functions to control what happens if the output file already exists would be a nice feature

@ngreenwald should we give users the option to provide the user an option to overwrite regardless of the state of the pixel/cell files/directories (ex. default overwrite=False argument, with option to set to True)? Let me know if there's an application you see this being useful.

For the first pass we don't need to include that feature. If it turns out to be useful we can add it in.

@ngreenwald ok great. In that case I just need to spend time writing tests for the pixel clustering restart process and we should be good to go soon.
I think I'll hold off on adding the restart feature for cell clustering for now, since this process doesn't involve a lot of intermediate files and intense training/assignment.


Structure the logs

https://twitter.com/mipsytipsy/status/951272678345687040
https://honeycomb.io/blog/2017/04/lies-my-parents-told-me-about-logs

What do we really want to do with that?
I check about log structuration and the thing that come back the most is The elastic suite, which is logstach + elasticsearch + kibana. It read and parse your log files to json and send them to elasticserach, then kabina (the analytics dashboard) query the logs you've send to elasticsearch to render charts with your data.
My questions :

Do we really want to install such a huge stack
Do we really need all these features ?
Can we write our own and simpler stack for this kind of work?

The good point is that we could use that to check the number of view of a n article or a page without having an update query on every request, but we could also do it in javascript / ajax to avoid the update query.

Will you also investigate what Heroku add-ons there are that might help us with this kind of thing please?

There is the logging section, there is elasticsearch if we want to implement the elastic suite presented above and there is the Metrics and Analitics add-ons.

More reading about observability:

https://medium.com/@adron/reading-up-on-observability-and-monitoring-efee79bd291d
https://honeycomb.io/blog/2017/10/metrics-not-the-observability-droids-youre-looking-for
https://honeycomb.io/blog/2017/08/observability-whats-in-a-name

My 2c on ELK. Amazing platform if you can afford the hardware required. The free version does not have RBAC or user logins, but is regardless extremely powerful.
What is your ingest rate and document size?

Would love to chat sometime if you'd care to invite me to slack?


use object.stub in before(:all)

I am facing the problem, that I need to stub out a method in a before(:all) block. When calling stub the following exception is raised:
 Failure/Error: ExampleModel.stub(:cachers => [])
 NoMethodError:
   undefined method `stub' for #<Class:0x00000103eff6d8>

I tried to debug the problem and i noticed, that it happens because the Mocks are setup in the RSpec::Core::Example#run_before_each method. The bad part is, that everything works perfectly, when I got an it "..." do; end block above the before(:all) block. This will trigger the mock setup and will make the example pass.
Is there a way to make the mocking already available when the before(:all) block is the first element in the spec file?

Sorry, but there are too many integration points with other tools to support this reliably.

BTW - if you want to get a discussion going about this, please open the same issue in the https://github.com/rspec/rspec-mocks/issues tracker. I'm generally against adding support for this, but I'm open to the conversation.

You can always perform the stubbing yourself using ruby's built in features:
some_object.extend Module.new {
  def foo
    :bar
  end
}

...but bear in mind that you're responsible for any necessary cleanup so this stub doesn't "leak" outside of the example group.  For most objects, this isn't an issue as the object will no longer be referenced and will be garbage collected.  For classes, it's not so easy because they are global objects.

yes, of course I could do that but Since I need to stub a class method I don't think its worth polluting the example that much, just to gain execution speed (and thats why I have to use a before(:all) in the first place). So I think I'll just leave it as is with a before(:each).


Inconsistency in knowrob.owl

Hi,
there seems an issue in the knowrob.owl while reasoning with Pellet. Please find the following information copied from Protege:
""
_An error occurred during reasoning: Axiom:  Transitive: hasPart.
org.mindswap.pellet.exceptions.UnsupportedFeatureException: Axiom:  Transitive: hasPart
at com.clarkparsia.pellet.owlapiv3.PelletVisitor.addUnsupportedAxiom(PelletVisitor.java:119) ~[na:na]
at com.clarkparsia.pellet.owlapiv3.PelletVisitor.verify(PelletVisitor.java:160) ~[na:na]
at com.clarkparsia.pellet.owlapiv3.PelletReasoner.refresh(PelletReasoner.java:969) ~[na:na]
at com.clarkparsia.pellet.owlapiv3.PelletReasoner.(PelletReasoner.java:345) ~[na:na]
at com.clarkparsia.pellet.owlapiv3.PelletReasonerFactory.createReasoner(PelletReasonerFactory.java:69) ~[na:na]
at com.clarkparsia.pellet.owlapiv3.PelletReasonerFactory.createReasoner(PelletReasonerFactory.java:33) ~[na:na]
at org.protege.editor.owl.model.inference.ReasonerUtilities.createReasoner(ReasonerUtilities.java:20) ~[na:na]
at org.protege.editor.owl.model.inference.OWLReasonerManagerImpl$ClassificationRunner.ensureRunningReasonerInitialized(OWLReasonerManagerImpl.java:428) ~[na:na]
at org.protege.editor.owl.model.inference.OWLReasonerManagerImpl$ClassificationRunner.run(OWLReasonerManagerImpl.java:386) ~[na:na]
at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
""

Hi,
could you tell me how you open knowrob in protege? Do you open a local version or the one at the URI of knowrob?
Which version of pellet are you using? I couldn't reproduce the error on my protege with pellet.

Hi, thanks for the timely feedback! Please find the required info:
actions: download git repo -> open the knowrob.owl in the owl folder -> Protege prompted for missing ontology of "URDF" -> import local URDF.owl -> successfully opened in Protege -> run Pellet -> same inconsistency error reproduced
Protege version: 5.5
Pellet version: 2.2.0 (default)
Thanks for your effort!
:D

I could reproduce the error with Pellet, but other reasoners are not throwing this error. The definitions stem from DUL and SOMA which a checked for their consistency in the CI of the SOMA repository (see for example here).
I believe Pellet is not any more maintained, so the error could be within Pellet.

I am closing this issue due to inactivity. please re-open if there are still problems


Move CSL Azure subscriptions

refs:

https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-resource-group-and-subscription
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-support-resources

done


Windows desktop app: "cannot find latest.yaml"

Title/Description
Windows desktop app: "cannot find latest.yaml"
Environment

Browser: Desktop app
Safe: -
Wallet: -
App Version: ?
Environment:

production (mainnet)

Steps to reproduce

Open the desktop app

Expected result
No error
Obtained result
Error. See: https://gnosisinc.slack.com/archives/CQB729LLF/p1592207969018100

Should be fine now


Declarations involving destructuring return the wrong value

This is most obvious in repl type environments, but you can also see it with eval:
console.log(eval("var [x] = [1]"));

In v8 and spidermonkey this results in undefined, while in chakracore it prints the value of the right hand side.

See "completion record" in the spec.

## Source
print(eval('var [x,y] = [1,2]'))

┌──────────┬───────────┐
│ jsvu-ch  │ 1,2       │
├──────────┼───────────┤
│ jsvu-jsc │ undefined │
│ jsvu-sm  │           │
│ jsvu-v8  │           │
└──────────┴───────────┘


Workaround for Hydra cp corruption

Description
From time to time, the test suite executables get corrupted while getting copied, resulting in failures like
/nix/store/6dpldw6wq7dh8zgp7x4q20xpiqlsp6aj-stdenv-linux/setup: line 1391: /nix/store/kj98n1f8q2qrm9clv1vb7pf0x3scs6c4-ouroboros-consensus-cardano-tools-test-test-<IP_ADDRESS>/bin/test: cannot execute binary file: Exec format error

Due to caching, it is not possible to simply restart this test, as the executable is built in a separate derivation. Hence, it requires us to e.g. increment counters in source files to manually force a rebuild, which is very tedious.
The cause for this behavior is an interaction between cp and a ZFS bug which is fixed upstream, but not yet deployed on the Hydra runners. This PR calls sync before copying the file, as advised by @cleverca22, hopefully making these failures disappear.
Checklist

Branch

[x] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[x] Self-reviewed the diff
[x] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[x] Reviewer requested

bors r+


Created a folder called translations, which will encapsulate all the …

Created a folder called translations, which will encapsulate all the README translated langugaes. I also translate the docs into French language.

Encapsulate all the README translated languages and translate the docs into French language.


Add an optional profile figure

Currently I am just duplicating the time series in profile.py, but you get the idea.

@andrewgryan I was procrastinating this morning and I tried to finish this one up. I think I have covered the two problems above, however it is a little tricky to test properly. I have been using the cache of Africa data you showed me:
$more multi-config.yaml

files:
   - label: Africa
     pattern: "cache/*.nc"
     locator: file_system
     file_type: unified_model
$forest --show --config-file multi-config.yaml

But the output is not correct, even when I use the master branch. For whatever reason, it takes a long time to load and then doesn't display the surface colour mesh. However, things seem to work ok when I run $forest --show cache/*.nc.
I can't think of any more obvious improvements at this stage so I am removing the WIP tag.

@twsearle we're now transitioning to https://forest.metoffice.cloud which will have a more formal production-ready release cycle. Our auto-deploy forest.informaticslab.co.uk will be retired in favour of having a dev version and a prod version. If you feel the changes in this PR lay good foundations for follow on work I can review it and merge it today. Banking progress as often as possible is what we should be doing

Great thanks! Hopefully I haven't broken anything :)

@twsearle if it is broken we can easily fix it or unwind the changes :wink:

@twsearle spoke too soon. xarray isn't available in the old FOREST container
File "profile.py", line 48, in <module>:
import xarray Traceback (most recent call last):
  File "/opt/conda/lib/python3.6/site-packages/bokeh/application/handlers/code_runner.py", line 179, in run
    exec(self._code, module.__dict__)
  File "/repo/forest/forest/main.py", line 8, in <module>
    from forest import (
  File "/repo/forest/forest/profile.py", line 48, in <module>
    import xarray
ModuleNotFoundError: No module named 'xarray'

I'll submit a quick try/except PR to temporarily patch the issue. It might be a good time to retire forest.informaticslab.co.uk with a re-direct to dev.forest.metoffice.cloud.dev.dev.dev


Fine Tuning on Custom Dataset

Hello
Our team is working on OCR and layout detection and currently we are doing the bounding box annotations manually. We are looking for an Optimised approach to the aforementioned problem, our document images comprises of densely laid out and multi-class region instances with large range in aspect ratio.
We are primarily working on mixed text(English+Sanskrit) printed document images and are looking to train the model from scratch but could we also use your Pretrained Model to fine tune on our dataset and how effective would the latter approach be ?

Hi @r12sharma . Could you show some examples of document images you are working with? That will help determine feasibility of our approach. If possible, overlay the bounding boxes so that we know what would be the effective input to BoundaryNet.


Modify the JSON ABI schema for function outputs

Currently, the JSON ABI schema for Sway uses an array for function outputs. However, functions in Sway can only ever return one value. For example, in the case of a function that returns an array, the "one value" that it returns is the array, which happens to contain multiple nested values. In the case of a struct, the "one value" that it returns is the struct, which again contains multiple nested values.
So, we should change the JSON ABI schema to only return one value for function outputs.
The corresponding issue for the spec: https://github.com/FuelLabs/fuel-specs/issues/323
Once this is complete, then we will need to make the corresponding changes to the SDKs:

Rust SDK: https://github.com/FuelLabs/fuels-rs/issues/358
TypeScript SDK: https://github.com/FuelLabs/fuels-ts/issues/314

@mohammadfawaz  this issue should be closed now that the new ABI spec is in, I believe?


Create a Contact Us Page

A Contact Us page is missing. For a community, it is necessary to create a page for people to submit queries.

hey @Aryan-Lohia can you assign this to me?

Hey @aryankshl I have assigned you. Please check.


"Scan apps" reload icon positioned outside field when inspector is narrow

Version
6.0.12
Browser and OS info
Chrome 99 / Windows 7
Steps to reproduce
The Scan Apps "reload icon" is shown outside the "Find apps..." field when the Chrome Devtools/inspector window is narrow (below ~1000 px wide).
What is expected?
The "Scan Apps" reload icon should be inside the "Find apps..." field, on the right hand side.
What is actually happening?
Icon outside the field, please see attached screenshot.


Offline map

Geometries persist offline

Good idea. I'll do a rebase.
On Wed., Sep. 30, 2020, 4:58 p.m. Roland Stens<EMAIL_ADDRESS>wrote:

@rstens commented on this pull request.
As a general comment, when I pull this branch down and built it locally,
it was/is based on a rather old earlier version. This could cause issue
when merging. So I'd like to suggest that you test the new code first with
a rebased branch, so that we do not find issues later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcgov/invasivesbc/pull/45#pullrequestreview-499909409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADU6YVYPBPLLJQOAJR6MALSIPAZ7ANCNFSM4R7WKNFA
.

Hey @NickPhura and @rstens  . Can one of you check this PR. I've just made a couple adjustments. Rebase and removing code smells.

Thanks @rstens :)


Microwaves are broken

Description

A variety of Microwave issues:
After 30 seconds of cook time the UI breaks (everything is not interactable).
You cannot eject any items placed in the microwave with the UI button
Non-food items will not auto-eject once cooking is done
Reproduction

Put anything into a microwave. You won't be able to eject it. You can only change cook times and start.
Food items will be automatically ejected after cook time which is intended.
Non food items will be stuck in the microwave.
Cooking with 30 second timers will also make the UI bug out.
Screenshots

https://user-images.githubusercontent.com/54602815/235314744-f200016a-a828-48aa-ae27-030db3492f4a.mp4
Additional context

Yeah I should've checked to see if the branch the PR I was reviewing was up to date


please include LICENSE files in published enumflags2_derive crates

Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the license terms. The lack of license text is technically a violation of the terms, which is a problem for both crates.io and Linux Distributions which redistribute this crate.
It looks like this was previously discussed in https://github.com/meithecatte/enumflags2/issues/27 but got reverted again?

The LICENSE files are included in the relevant directory in the repository. Can you provide specific steps to reproduce this issue?

You are correct. I think I accidentally browsed the files of some old repository state by accident -  the files are indeed still there. Sorry about the noise. 🤦🏼♂


feat: add ignore file types

Adding some file types to "ignorePaths" relating to https://github.com/autowarefoundation/open-ad-kit-docs/pull/13
Signed-off-by: Daisuke Hashimoto<EMAIL_ADDRESS>

@kenji-miyake Thank you for your comments, and I'm sorry I didn't understand the prerequisites. I'll close this PR and will re-create another PR according to your comments.


Thanks man your a life saver you just got me a 3080.

Just want to say thanks.

I'm so happy to hear that, I actually just got one as well as another friend too glad to see this is working for people.

<3

You guys got it manually?

Nope we got it using the new version of the bot that just opens the page :)

I got up from my computer to get an ice cream bar  and what do I see when I get back? yep, the only reason I got one tonight is because of this program. I shared the news manually in our Discord but it was too late for everyone else. Even paid for one day shipping...appreciate the hard work

With the new version, it doesnt open a chrome page. Just the cmd out of stock tracker.
This ia crazy :'(

Nope we got it using the new version of the bot that just opens the page :)

sigh does the sms alerts still work in this version?

Nope we got it using the new version of the bot that just opens the page :)

sigh does the sms alerts still work in this version?

Yes it work, the SMS came in extremely fast, I clicked on "Add to cart" then "Checkout" and was stuck on "Checking out..." state for ever

Can someone help me set up the sms? xD Im a total noob and barely got the normal thing working

Gratz to all! Any hope for getting this to work with the 3090?

With the new version, it doesnt open a chrome page. Just the cmd out of stock tracker. Is this normal>

Yes, it will open a browser when a card comes in stock.

Gratz to all! Any hope for getting this to work with the 3090?

I've been trying some... interesting methods to get the sku's but haven't been successful so far.

I want to add to this to say that I also got my order thanks to your bot, so I also want to say that you rock! I literally laid down in bed, grabbed my phone to turn on the sound so I could hear if I got a notification (Just expecting it to be false hope but y'know, gotta pray) and right as I grabbed my phone, the Discord webhook told me to get out of bed and get the card.  Ian you're the man! I need 1 more for the wife and our dual monsters in tiny box projects are complete.

Gratz to all! Any hope for getting this to work with the 3090?

I've been trying some... interesting methods to get the sku's but haven't been successful so far.

Lol. Have you tried brute force? nVidia SKU’s seem pretty close to each other by a few thousand or so...just keep looping until it hits something.

Since yesterday the program doesn't work for me.
"flag provided but not defined: -region:FRA"
"flag provided but not defined: -region:USA"
Which region do you set for ?

You need to use -region**=**FRA instead of -region:FRA

Omg thanks dude

Gratz to all! Any hope for getting this to work with the 3090?

I've been trying some... interesting methods to get the sku's but haven't been successful so far.

Lol. Have you tried brute force? nVidia SKU’s seem pretty close to each other by a few thousand or so...just keep looping until it hits something.

Indeed I have, no good results yet. Won’t have support for 3090 on launch day sadly.

Bah.  Stupid mistake on my part.  SMS is working fine.  But I forgot to turn off the power saving sleep timers in Windows before going to bed.  I'm thrilled to see real folks getting their cards though. Congrats! I'll keep trying.

Does anyone know when they will restock again?

probably next week, don't quote me on that but I would have the bot running overnight.


Please invite me to the GitHub Community Organization

Name
Dennis Dueck
Discord Username (if applicable)
No response
Additional Context
I am a full stack developer with 7+ years experience of all kinds of modern javascript frameworks.
I like sharing my knowledge and help other people and learn from them.
Thank you,

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉#
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/jaidevstudio/people
Like this

Tips for practising:
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

Please check your email or organisation page 🙏


Update proximity when a player pick up the wool

Video proof: https://youtu.be/e3PaFVm_644
Cardinal version  6f04c0c: http://gyazo.com/e0a3e6968c7c60d1bc51793cbf6cf1d0

The proximity shoud update when you place a save.


Bring cyberspace back

@ChrisTitusTech. We loved cyberspace. You said "CYBERSCAPE FOR LIFE". You can't just abandon it like this. Bring it back.
clip.

@adamperkowski Totally right.

Big mistake not to bring it back

Okay. Chris convinced, Cyberspace is back. If he ever decides to do this again, I'll reopen this issue.

https://github.com/ChrisTitusTech/ageoftitus/pull/3#issuecomment-2418178605

Ok I added the MIT License 03a1b6cc5913f2a7f6f698cbc069b6e7e63ce384


Improve the documentation concerning the samples

Improve the guides, to explain how to build from source.
Review the user guide, so it is correct.

Documentation improved.


[Feature Request] Increase / decrease numeric value of given keyPath

I have a little app that holds some bookmarks in idb. When the user clicks a bookmark on the page I want to update a numeric value like in this (Typescript) code:
// interface ISyncInfo { id: string, extra?: { integerValue: number} }
// ...
const syncInfo: ISyncInfo = await this.db.sync.get(id);
const current: number = syncInfo?.extra?.integerValue || 0;
this.db.sync.put({ ...syncInfo, extra: { integerValue: current + 1 } });
// ...

Firebase API has a method to increment a specific field.
Is it possible to add a method to Dexie.Table that does the same?
Maybe a method similar to this one :
// Dexie.Table.increase(id, keyPath, amount = 1); // <- amount defaults to 1
async this.db.sync.increase(id, 'extra.integerValue');
// also
async this.db.sync.decrease(id, 'extra.integerValue');

It's possible to do atomic operations using a transaction around the get/put calls. As this kind of syntactic sugar would be nice for some users, it would also come with a cost of increased code base, so I am not enough convinced for now to put it in right now. There might be other similar atomic operations, like pushing items to an array etc that could also be beneficial, even though also easily implemented using a transaction block. But keeping dexie API surface small has also benefits.

The logic would be similar to this SQL update statement :
update mytable set counter = counter + 1 where id = ...
which also reduces open tx, select, update, and commit statements into one line.
As a user, I think Dexie would benefit if it had more methods like setByKeyPath() and delByKeyPath(), (maybe 'incByKeyPath()', 'pushByKeyPath()' etc.) especially when they eliminate at least 3 lines and make the code less error-prone.
Maintaining an API is another beast though.

We already have:
db.table.where({id: id}).modify(item => ++item.counter);

But that would not take into account any initial number, so it would become NaN if never initialized to zero.

That actually solves my problem :)
I've yet to get familiar with all the already available methods. Thanks.

Nice! Here's a reference to the docs for that particular example: https://dexie.org/docs/Collection/Collection.modify()#sample-using-function


Can't be able to get the Response.body value in Edge Beta browser while fetching manifest.

Have you read the FAQ and checked for duplicate open issues?
Yes. There is no duplicate issues.
What version of Shaka Player are you using?
4.3.5
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Custom app,
Demo player. with custom manifest
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Browser : Microsoft Edge (Beta)
Version 113.0.1774.15 (Official build) beta (64-bit)
OS:
Edition	Windows 11 Enterprise
Version	22H2
Installed on	1/18/2023
OS build	22621.1555
Experience	Windows Feature Experience Pack 1000.22640.1000.0
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Didn't test.
What are the manifest and license server URIs?
Manifest: https://amssamples.streaming.mediaservices.windows.net/3b970ae0-39d5-44bd-b3a3-3136143d6435/AzureMediaServicesPromo.ism/manifest(format=mpd-time-csf)
Demo Page URL:
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://amssamples.streaming.mediaservices.windows.net/3b970ae0-39d5-44bd-b3a3-3136143d6435/AzureMediaServicesPromo.ism/manifest(format=mpd-time-csf);panel=CUSTOM CONTENT;build=uncompiled

What configuration are you using?  What is the output of player.getConfiguration()?
{
"drm": {
"retryParameters": {
"maxAttempts": 2,
"baseDelay": 1000,
"backoffFactor": 2,
"fuzzFactor": 0.5,
"timeout": 30000,
"stallTimeout": 5000,
"connectionTimeout": 10000
},
"servers": {},
"clearKeys": {},
"advanced": {},
"delayLicenseRequestUntilPlayed": false,
"logLicenseExchange": false,
"updateExpirationTime": 1,
"preferredKeySystems": [],
"keySystemsMapping": {},
"parseInbandPsshEnabled": false
},
"manifest": {
"retryParameters": {
"maxAttempts": 2,
"baseDelay": 1000,
"backoffFactor": 2,
"fuzzFactor": 0.5,
"timeout": 30000,
"stallTimeout": 5000,
"connectionTimeout": 10000
},
"availabilityWindowOverride": null,
"disableAudio": false,
"disableVideo": false,
"disableText": false,
"disableThumbnails": false,
"defaultPresentationDelay": 0,
"segmentRelativeVttTiming": false,
"dash": {
"clockSyncUri": "",
"ignoreDrmInfo": false,
"disableXlinkProcessing": false,
"xlinkFailGracefully": false,
"ignoreMinBufferTime": false,
"autoCorrectDrift": true,
"initialSegmentLimit": 1000,
"ignoreSuggestedPresentationDelay": false,
"ignoreEmptyAdaptationSet": false,
"ignoreMaxSegmentDuration": false,
"keySystemsByURI": {
"urn:uuid:1077efec-c0b2-4d02-ace3-3c1e52e2fb4b": "org.w3.clearkey",
"urn:uuid:e2719d58-a985-b3c9-781a-b030af78d30e": "org.w3.clearkey",
"urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed": "com.widevine.alpha",
"urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95": "com.microsoft.playready",
"urn:uuid:79f0049a-4098-8642-ab92-e65be0885f95": "com.microsoft.playready",
"urn:uuid:f239e769-efa3-4850-9c16-a903c6932efb": "com.adobe.primetime"
},
"sequenceMode": false
},
"hls": {
"ignoreTextStreamFailures": false,
"ignoreImageStreamFailures": false,
"defaultAudioCodec": "mp4a.40.2",
"defaultVideoCodec": "avc1.42E01E",
"ignoreManifestProgramDateTime": false,
"mediaPlaylistFullMimeType": "video/mp2t; codecs="avc1.42E01E, mp4a.40.2"",
"useSafariBehaviorForLive": true,
"liveSegmentsDelay": 3
}
},
"streaming": {
"retryParameters": {
"maxAttempts": 2,
"baseDelay": 1000,
"backoffFactor": 2,
"fuzzFactor": 0.5,
"timeout": 30000,
"stallTimeout": 5000,
"connectionTimeout": 10000
},
"rebufferingGoal": 2,
"bufferingGoal": 10,
"bufferBehind": 30,
"ignoreTextStreamFailures": false,
"alwaysStreamText": false,
"startAtSegmentBoundary": false,
"gapDetectionThreshold": 0.5,
"durationBackoff": 1,
"forceTransmux": false,
"safeSeekOffset": 5,
"stallEnabled": true,
"stallThreshold": 1,
"stallSkip": 0.1,
"useNativeHlsOnSafari": true,
"inaccurateManifestTolerance": 2,
"lowLatencyMode": false,
"autoLowLatencyMode": false,
"forceHTTPS": false,
"preferNativeHls": false,
"updateIntervalSeconds": 1,
"dispatchAllEmsgBoxes": false,
"observeQualityChanges": false,
"maxDisabledTime": 30,
"parsePrftBox": false
},
"mediaSource": {
"sourceBufferExtraFeatures": ""
},
"offline": {
"usePersistentLicense": true,
"numberOfParallelDownloads": 5
},
"abr": {
"enabled": true,
"useNetworkInformation": true,
"defaultBandwidthEstimate": 1000000,
"switchInterval": 8,
"bandwidthUpgradeTarget": 0.85,
"bandwidthDowngradeTarget": 0.95,
"restrictions": {
"minWidth": 0,
"maxWidth": null,
"minHeight": 0,
"maxHeight": null,
"minPixels": 0,
"maxPixels": null,
"minFrameRate": 0,
"maxFrameRate": null,
"minBandwidth": 0,
"maxBandwidth": null
},
"advanced": {
"minTotalBytes": 128000,
"minBytes": 16000,
"fastHalfLife": 2,
"slowHalfLife": 5
},
"restrictToElementSize": false,
"restrictToScreenSize": false,
"ignoreDevicePixelRatio": false
},
"autoShowText": 3,
"preferredAudioLanguage": "",
"preferredTextLanguage": "",
"preferredVariantRole": "",
"preferredTextRole": "",
"preferredAudioChannelCount": 2,
"preferredVideoCodecs": [],
"preferredAudioCodecs": [],
"preferForcedSubs": false,
"preferredDecodingAttributes": [],
"restrictions": {
"minWidth": 0,
"maxWidth": null,
"minHeight": 0,
"maxHeight": null,
"minPixels": 0,
"maxPixels": null,
"minFrameRate": 0,
"maxFrameRate": null,
"minBandwidth": 0,
"maxBandwidth": null
},
"playRangeStart": 0,
"playRangeEnd": null,
"cmcd": {
"enabled": false,
"sessionId": "",
"contentId": "",
"useHeaders": false
},
"lcevc": {
"enabled": false,
"dynamicPerformanceScaling": true,
"logLevel": 0,
"drawLogo": false
}
}

What did you do?

step -1 : open Shaka Demo page in Edge Beta browser
step -2 : configure manifest with shaka Demo page
Step - 3: Play the video
What did you expect to happen?
Video Should be playing without error
What actually happened?
Throw an exception "Cannot read properties of null (reading 'getReader')"

Same on Chrome Beta (113.0.5672.53)
I found it to be fixed by adding init.method = 'GET' just before this line:
https://github.com/shaka-project/shaka-player/blob/19affea6318d61790b57fde075887a7a7264f990/lib/net/http_fetch_plugin.js#L118
Don't know if it's the best solution or the right place to put it, but it works.
init.method was GET on previous versions of chrome and now it's HEAD which seems to be causing the problem.

Looks like we may need to make an adjustment.  Forcing all HEAD requests to be GET requests is not a good fix, but it shouldn't be hard to work around this issue.  Let me see what I can do.

I think a better solution would be to modify how the fetch plugin handles HEAD requests.
The part of the code starting here:
https://github.com/shaka-project/shaka-player/blob/577b0e712a2451cfcfb26e7bd6b954002fb98308/lib/net/http_fetch_plugin.js#L129
We could just not load the body if the request method was HEAD. We won't be using it anyway in that case, right?

That's correct.  Theodore, would you make that change?

Hi @theodab , @joeyparrish ,
I tested this change (V4.4.0) in my local with above mentioned AMS sample manifest. It is working fine.
But if I try with the production manifest, I am getting the below mentioned error in networking_engine.js file.

@theodab, please see above.  Can you fix this, as well?

@Ravi-79, since you haven't provided us with content or steps to reproduce the issue in your latest comment, please try this edit:
Change:
      if (!responseAndGotProgress.gotProgress &&
          this.onProgressUpdated_ &&
          !response.fromCache &&
          type == shaka.net.NetworkingEngine.RequestType.SEGMENT) {

To:
      if (!responseAndGotProgress.gotProgress &&
          this.onProgressUpdated_ &&
          !response.fromCache &&
          request.method != 'HEAD' &&  // <---------------------- ADDED
          type == shaka.net.NetworkingEngine.RequestType.SEGMENT) {

Does this resolve the issue for you?  I want to fix this ASAP, and I have already cherry-picked everything else for the release.

Also available as PR #5194.  Please let us know if this addresses the issue for you.

Hi @joeyparrish ,
I tested with adding that condition ( request.method != 'HEAD' &&) in v4.3.x and the video is playing and also I can able to get the embedded caption.
But when testing with the branch main, I can't be able to display the embedded caption on video.
I can't be able to repro this step in Shaka demo player, because I do not have the free manifest with embedded caption on it.

I guess the

@Ravi-79, since you haven't provided us with content or steps to reproduce the issue in your latest comment, please try this edit in networking_engine.js:
Change:
      if (!responseAndGotProgress.gotProgress &&
          this.onProgressUpdated_ &&
          !response.fromCache &&
          type == shaka.net.NetworkingEngine.RequestType.SEGMENT) {

To:
      if (!responseAndGotProgress.gotProgress &&
          this.onProgressUpdated_ &&
          !response.fromCache &&
          request.method != 'HEAD' &&  // <---------------------- ADDED
          type == shaka.net.NetworkingEngine.RequestType.SEGMENT) {

Does this resolve the issue for you? I want to fix this ASAP, and I have already cherry-picked everything else for the release.

This solves the issue, I can be able to play the video.
As I mentioned earlier, I can't be able to show the embedded caption on the player. As our requirements are mostly concentrated on the embedded captions, we need to test and find the root cause for that issue once the latest Shaka library is available in CDN.

@joeyparrish , If you have any free/common manifest with embedded caption to test, please share so we can test that also

@Ravi-79 please open a new issue for your embedded caption issue. Thanks!

@Ravi-79 please open a new issue for your embedded caption issue. Thanks!
Thank you for the help @avelad .

Hi, was this supposed to be fixed in 3.2.21? I'm still getting the error in latest Edge 113.0.1774.35: https://jsfiddle.net/3qs9twr0/3/


the relationship between matterport_camera_intrinsics and undistorted_camera_parameters

Firstly, Thank you for your great work.
I have two questions:
a.  I find the number of subfile in "matterport_camera_intrinsics" is 513. The number and the name of subfile are not changed in different project. why? the projects are scanned by the same camera?
b. the camera intrinsics got from "matterport_camera_intrinsics" is not equal to the intrinsics got from "undistorted_camera_parameters". what is the different? how can I get the exact intrinsics parameters from every image?
Thank you!

Can someone help me please?


Update github actions to latest versions

Update actions/checkout from v2/3 to v4
Replace deprecated GabrielBB/xvfb-action with coactions/setup-xvfb
Update actions/upload-artifact from v2 to v4
Avoid conflicting artifacts by uploading only those from the stable Rust build.
Raise an error if a binary is not found to upload.

I was hoping this would fix the slew of deprecation warnings that show up in each of our CI runs, but it turns out most of those are due to unmaintained actions from the now-archived @actions-rs organisation.
So we need to see about replacing those too.

Yeah, I think actions-rs/toolchain and actions-rs/cargo can be replaced easily by direct use of rustup and `cargo.
I'm not sure what to do about actions-rs/clippy-check - there are several forks/successors.

I was thinking just run cargo clippy directly too. It seems like the fancy annotations that the action does often fail on PRs anyway & having the normal output from clippy would be more useful.

All done. No more warnings!


Update engine hash for 1.19.0-4.0.pre (#58736)

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests2
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

I found issue here.

We have a bot that automatically updates the engine revision. If you're running into any issues with the current revision: Please file a bug describing the issue.


 Then run npm install electron
I have never seen this error before that's pretty weird. Do you have node and npm installed correctly?


#made the navbar similar

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1834
Description
I have made the navbar of "about us" page similar to this rest of the pages.

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
before

home page navbar

about us navbar

Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@huamanraj please assign me this pull request so that i can get my scores.

@nandani-goyal Done and sorry for the inconvenience caused

Thank u so much @RitiChandak for your efforts but I have still not got my scores shown in the leaderboard for this pull request.

Please can u tell me what could possible problem?


ReferenceError: realm is not defined

Found this in cloud, v670 (realm-object-server-3.15.0, realm-graphql-service-3.4.0):
error: [http] HTTP response: 688ea707-bfa3-42dd-a671-4a3addd7c194
{"type":"https://realm.io/docs/object-server/problems/invalid-parameters","title":"Your request parameters did not validate.","status":400,"code":601,"invalid_params":[{"name":"path","reason":"path is invalid. It should start with a slash, consist of Latin letters (A-Z, a-z), digits (0-9), dot (.), dash (-), and underscore (_). All components should be non-empty and not start with a dot. The path should not end with .realm, .realm.lock or .realm.management."}]}
/app/node_modules/realm-graphql-service/dist/service.js:119
                this.closeRealm(realm);
                                ^
 ReferenceError: realm is not defined
    at ServerResponse.res.once (/app/node_modules/realm-graphql-service/dist/service.js:119:33)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at ServerResponse.emit (events.js:208:7)
    at onFinish (_http_outgoing.js:720:10)
    at onCorkedFinish (_stream_writable.js:638:5)
    at afterWrite (_stream_writable.js:463:3)
    at _combinedTickCallback (internal/process/next_tick.js:145:20)
    at process._tickCallback (internal/process/next_tick.js:181:9)

@fealebenpae can you make anything of this stacktrace? The callsite in typescript is this one: https://github.com/realm/realm-graphql-service/blob/master/src/service.ts#L290. Is it possible that this gets thrown if the response completes before openRealm resolves on line 294?

Looking at the transpiled code the problem seems to be that the TypeScript compiler initializes the closure that captures the realm variable before it actually declares the variable. Nikola and I came up with a workaround.


Type error when used with SFC type from react

Given the following:
...
import { SFC } from 'react';

const SFComponent: SFC<ISFComponent> = observer((props) => { ...})

There is a type error:
[ts]
Type 'ClassicComponentClass<{}>' is not assignable to type 'StatelessComponent<ISFComponent>'.
  Type 'ClassicComponentClass<{}>' provides no match for the signature '(props: ISFComponent & { children?: ReactNode; }, context?: any): ReactElement<any>'

Looks like the types need adjusted slightly. Reason for this approach is so that children can be typed automatically.

Not sure if it relates to the problem, but observer have to (in order to work) create a standard component even if you pass plain function, so the returned component is no longer SFC...

Check out https://github.com/mobxjs/mobx-react/blob/master/test/ts/compile-ts.tsx for all the right ways to use Typescript + observers.
const T3 = observer((props: { hamburger: number }) => {
	return <T2 cake={props.hamburger} />;
});

That should fit your use case, no?

Yep, that's how I've been doing it. Weird that it doesn't fit the  definition because I don't want to have to type the child props.

@mattoni feel free to create a PR if you feel the typings can be improved

Closing, a lot of typing improvements have been made lately


[Docs Feature Request] Quick code copy btn

Hi there,
I find very usefull to have a "quick copy"  btn in the docs->examples ,and not only, for quick copy/paste of example code that i want to test.

Agree would be nice, bit of a low priority though since we have so much documentation still to write. Happy to accept a PR for it if someone wants to put together a really polished solution; would rather keep it as is than implemented something half baked though.

After reading this I noticed how many times I copied by selecting so put together a pull request (https://github.com/tailwindcss/tailwindcss/pull/311) that automatically adds a copy button for all prism syntax highlighted elements.
Currently looks like:

Hope this does the trick but if not just let me know how/if it can be improved.

Closing this since the docs have moved to a separate repo, still would like to add this feature eventually though.


Keywords 'of' and 'yield' for Javascript.

New Javascript language keywords 'of' (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of) and 'yield' (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/yield) are added to syntax file runtime/syntax/javascript.vim.

Have you contacted the maintainer, Claudio Fleiner?

Yes, but there was no response for 2 weeks...

Please god somebody merge this - not having 'of' highlighted has bothered me for years

let me merge this


Rename project to heroku-data-privatelink-cli

This commit expands the use of the privatelink cli to incorporate all
data addon types. This involves renaming a lot of pg specific commands
and references to now be prefixed with data. As such, the package name
has also been updating as well as the version to denote the major
change.
All previous pg prefixed commands are aliased to their new data
prefixed commands.

Codecov Report

Merging #14 into master will increase coverage by 3.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage    91.9%   95.23%   +3.33%
==========================================
  Files           9        9
  Lines         173      168       -5
  Branches       19       14       -5
==========================================
+ Hits          159      160       +1
+ Misses          6        4       -2
+ Partials        8        4       -4

Impacted Files
Coverage Δ

src/commands/data/privatelink/create.ts
100% <100%> (ø)

src/commands/data/privatelink/access/remove.ts
100% <100%> (ø)

src/commands/data/privatelink/access/index.ts
88.23% <100%> (ø)

src/commands/data/privatelink/index.ts
81.81% <100%> (ø)

src/commands/data/privatelink/destroy.ts
100% <100%> (ø)

src/lib/fetcher.ts
100% <100%> (+40%)
:arrow_up:

src/commands/data/privatelink/wait.ts
100% <100%> (ø)

src/commands/data/privatelink/access/add.ts
100% <100%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b504e6f...6ce0c55. Read the comment docs.

Awesome! I do have one concern, what to do about existing customers who have the plugin installed already. I do not think that the CLI's plugin system will pick this change up since we'd be doing a package change on npmjs as well, so we'd likely need to do outreach.
@RasPhilCo have you ever needed to rename a plugin before?

@brettgoulder Yep!

Publish this package to npm
add a PR to CLI that adds a plugin update migration (ex: https://github.com/heroku/cli/blob/master/packages/cli/package.json#L251)

Whoops! 😬

Even better! Y'all thought of everything :D


Add conformity migration tool

Cloud One Service
[ ] Common
[ ] Workload Security
[ ] Application Security
[ ] Network Security
[ ] File Storage Security
[ ] Container Security
[X] Conformity
[ ] Open Source Security
Proposed Changes

Add the Conformity Migration Tool to the Trendmicro Org

ToDo tasks missing:

Configure in the repo the PIP API Token ${{ secrets.PYPI_API_TOKEN }}, it is declared on the workflow conformity-migration-release.yml
Add the Python CodeQL analysis:  it’s only available for free in public repos… for private repos we should have a GitHub Advanced Security license, more info: GitHub Advanced Security
Add linter for Python

Just copied this message from the comments section with some edits: I brought up this concern during our first meeting, and it was agreed upon that complex repo like this (with its own workflow) will just stay in its own repo. So instead of merging that into this solutions-architect repo, we can just add a readme note that has reference to the external repo.

That makes sense to me, let me change it to reflect it.

What's the state here? Will we keep the project here or somewhere else?

I will make an update just to reference an external repository. But in this case, is it make sense to get another repository in this org to migrate this project?

I think we should prefer to reference projects that live over trendmicro org, yes.

I've started this process already, as soon as is mature enough and got it running, I will update this PR (probably close it)

I think we should prefer to reference projects that live over trendmicro org, yes.

I've started this process already, as soon as is mature enough and got it running, I will update this PR (probably close it)

We have the new repo up and running (not public yet), so I will close this PR since we will be moving to another repo.


[BUG] typecheck command returns exit code 0 (success) even when type-checking fails

Description
The typecheck command returns a successful (ie. 0) exit code even when type-checking fails.
This makes it difficult to use on CI or in scripts, as one cannot rely on the exit code to either abort the script or mark the CI job as failed.
It's possible to work around that by using grep to figure if the output contains Type checker [FAILED] , but that approach depends on the specific output emitted by the tool (and therefore seems unreliable in general) and does not match the general UNIX way of dealing with errors.
Input specification
---------------------- MODULE HourClock ----------------------

EXTENDS Naturals

VARIABLE
    \* @type: Bool;  <===== Type error
    hr

HCini  ==  hr \in (1 .. 12)
HCnxt  ==  hr' = IF hr # 12 THEN hr + 1 ELSE 1
HC     ==  HCini /\ [][HCnxt]_hr

TypeOK == hr \in (1 .. 12)

==============================================================

The command line parameters used to run the tool
$ apalache-mc typecheck HourClock.tla
Type checking HourClock.tla                                       I@13:10:50.759
PASS #0: SanyParser                                               I@13:10:50.965
Parsing file /var/apalache/HourClock.tla
Parsing file /tmp/Naturals.tla
PASS #1: TypeCheckerSnowcat                                       I@13:10:51.263
 > Running Snowcat .::.                                           I@13:10:51.263
[HourClock.tla:9:12-9:27]: No match between operator signature ((g, Set(g)) => Bool) and arguments Bool and Set(Int) E@13:10:51.365
[HourClock.tla:9:1-9:27]: Error when computing the type of HCini  E@13:10:51.370
 > Snowcat asks you to fix the types. Meow.                       I@13:10:51.371
Type checker [FAILED]                                             I@13:10:51.372
It took me 0 days  0 hours  0 min  0 sec                          I@13:10:51.374
Total time: 0.616 sec                                             I@13:10:51.375
EXITCODE: OK                 <==========

$ echo $?
0

Expected behavior
$ apalache-mc typecheck HourClock.tla
Type checking HourClock.tla                                       I@13:10:50.759
PASS #0: SanyParser                                               I@13:10:50.965
Parsing file /var/apalache/HourClock.tla
Parsing file /tmp/Naturals.tla
PASS #1: TypeCheckerSnowcat                                       I@13:10:51.263
 > Running Snowcat .::.                                           I@13:10:51.263
[HourClock.tla:9:12-9:27]: No match between operator signature ((g, Set(g)) => Bool) and arguments Bool and Set(Int) E@13:10:51.365
[HourClock.tla:9:1-9:27]: Error when computing the type of HCini  E@13:10:51.370
 > Snowcat asks you to fix the types. Meow.                       I@13:10:51.371
Type checker [FAILED]                                             I@13:10:51.372
It took me 0 days  0 hours  0 min  0 sec                          I@13:10:51.374
Total time: 0.616 sec                                             I@13:10:51.375
EXITCODE: ERROR            <==========

$ echo $?
1

Log files
N/A
System information

Apalache version [apalache-mc version]: 0.15.2 build v0.15.2-0-geb20fdf
OS [e.g. Ubuntu Linux or Mac OS, and the current version]: macOS 11.2.3
JDK version [e.g. OpenJDK 0.8.0]: OpenJDK 64-Bit Server VM GraalVM CE 21.0.0 (build 25.282-b07-jvmci-21.0-b06, mixed mode)

Additional context
This is currently an issue when running the type checker on the IBC specifications as a GitHub Action in the ibc-rs repository.

This seems to be an issue for other commands as well, eg. check.

I think we have reserved non-zero exit code for tool failures. @shonfeder what is your opinion on that?

To me, the end user does not care whether a) the tool experienced an internal error or b) their specification failed to check. In both cases, the result is that their specific did not through successfully, and imho both those cases would warrant a (potentially different) exit code.

It's not obvious with exit codes. Afaik, SAT solver are using a completely non-standard exit codes :)

It's really easy to change the exit codes. I just remember that @shonfeder and I had a discussion on that. We need his opinion.

I fully agree with @romac :) See https://github.com/informalsystems/apalache/issues/249

Ah, actually this is a duplicate of #249

Sorry about that, I should've searched before opening an issue.

No, no, no. Don't be sorry ;) It's a good reminder and helps motivate that one.
Duplicate issues is the price paid for big back logs :)

Cool. Then we introduce error codes. I will introduce the error codes in the tool, but some scripting and CI may break. @shonfeder, I will ping you if that happens.

Closing in favor of #249


States shows charges, charges no longer does

If I look at the "states" dashboard, then charge sessions can clearly be seen.

On my own  management system I encountered the following issue:
https://github.com/mseminatore/TeslaJS/issues/210
Which resolved to the following underlying cause:
https://github.com/timdorr/tesla-api/issues/97#issuecomment-549613978
My guess is the same issue is now impacting TeslaMate

With no changes on my part, this is now working again


set up proper css variables for site main colours

i'm picking this one up 👍

this seems to have been done already:
https://github.dev/Fireflower2012/CooperationHullMainSite/blob/5b823ccd79c32359bd4a0483c5cd364cc01e8805/CooperationHullMainSite/wwwroot/css/site.css#L29
unless I've misunderstood the task? Let me know, I can pick up another item

Abi finished this


Fixes mypy installation problem in CI

as titled

Looks good, would suggest to merge this soon to get mainline working again.

Problem resolved externally. conda was missing mypy_extensions to match the latest mypy


Incorrect syntax for lambda with captured variables and this

Bridge generates incorrect javascript code for lambda with captured variables and this
Steps To Reproduce
public class Program
    {
        public void Test()
        {
            for (int i = 0; i < 1; i++)
            {
                var idx = i;

                Action a = () =>
                {
                    var idx2 = idx;
                    var str = this.ToString();
                };

                Action a1 = () =>
                {
                    var idx2 = idx;
                };
            }
        }
    }

Expected Result
Actual Result
Brace in the wrong position.
See Also

https://forums.bridge.net/forum/bridge-net-pro/bugs/4273-latest-build-has-runtime-error

@vladsch glad you had been able to isolate :-)


The first pageView log doesn't have the attendee set

When you do an auth message it should run a query to patch all existing logs with attendee=null with the new attendee id.
Something like:
UPDATE logs
SET attendee = {new_attendee}
WHERE socket == {socket_id} AND attendee IS NULL

There should also be a migration to add an index to the relevant column so this is always fast


Fix bug where cilium would misread map flags from /proc

The bug fixed by the first commit in this PR would cause Cilium to re-create maps in userspace if the map has any flags set, because it would first read the attributes from the filesystem and think that the flags are 0, then go ahead and recreate the map with the expected flags value (nonzero).
The second commit introduces a privileged unit test to validate that the fix works as intended.

This change is

test-me-please

Coverage decreased (-0.007%) to 43.678% when pulling d05c879958683e5d054105f7a7646bb5cb57d1af on joestringer:submit/fix-mapinfo-read into 17f94de6aa84bfa9b86462cad293f2a10bc04286 on cilium:master.

@joestringer I guess this needs backport?

Opened #6440 to investigate the weird SERVFAIL error that occurred on the k8s-1.8 tests. Will re-run tests to check its flakiness.

test-me-please

New, different, failure this time (#6441). The previous failure didn't reoccur, so I think this is fair to review despite the CI failure.


Bundle split function not functioning

The new revm state got merged with some known bugs.
While enabling reth blockchaintree test, it failed, current best assumption is that there is a problem with the splitting of bundle state or how we apply one state onto another.

It was bug related to reverts, they were not sorted inside reth and included inside bundle in wrong order
https://github.com/paradigmxyz/reth/pull/3512/commits/f4f232f0809453d90fe7a0ccecf97695da724fa9#diff-05806321d39c10baa8a659b3e91ee3f60c526f477e7dec0de72deff6704e0d82R67-R68


2D displaying problems after affine transformation

🐛 Bug
I try to use affine transformation to display my images in correct orientation to each other. When I apply a affine transformation via the affine argument the initial dimension order is displayed correctly. For all other dimension orders (roll through dimension order button) the affine transformation is not apllied correctly. This problem only happens in 2D mode, not in 3D.
On every slice in 2D mode a warning is displayed:
Non-orthogonal slicing is being requested, but is not fully supported. Data is displayed without applying an out-of-slice rotation or shear component.
I suppose napari is at the current state not able to correctly operate with my affine matrix?
I'm not sure if this is a bug, simply not yet fully implemented or a failure on my part.
Correctly displayed:

Wrong:

To Reproduce
Steps to reproduce the behavior:

Load image with affine matrix:

[[-1.17185862e+00 -4.84692848e-04  5.79785848e-03  1.69048981e+02]
[-6.19494232e-03  1.13797526e-01 -1.09471981e+00  3.67642326e+01]
[ 1.17442619e-04  1.16633653e+00  1.06812411e-01 -1.66103561e+02]
[ 0.00000000e+00  0.00000000e+00  0.00000000e+00  1.00000000e+00]]
![error_report_1](https://user-images.githubusercontent.com/56394171/116089130-d138b780-a6a2-11eb-90e5-8dc4e0d727a1.png)
![error_report_2](https://user-images.githubusercontent.com/56394171/116089151-d72e9880-a6a2-11eb-90eb-b636e94c4def.png)
![error_report_3](https://user-images.githubusercontent.com/56394171/116089170-dc8be300-a6a2-11eb-8cbb-f7fa2ce0be67.png)

Stay in 2D mode
Roll through dimension order with the "Roll dimensions order for display" button

Expected behavior
Correctly display the slices in 2D
Environment
napari: 0.4.7
Platform: Linux-3.10.0-1127.19.1.el7.x86_64-x86_64-with-glibc2.10
Python: 3.8.5 (default, Sep 4 2020, 07:30:14) [GCC 7.3.0]
Qt: 5.15.2
PyQt5: 5.15.2
NumPy: 1.20.1
SciPy: 1.6.1
Dask: 2021.03.0
VisPy: 0.6.6
OpenGL:

GL version: 2.1 Mesa 18.3.4
MAX_TEXTURE_SIZE: 8192

Screens:

screen 1: resolution 1920x1080, scale 1.0

Plugins:

console: 0.0.3
svg: 0.1.4

Hi @ch-n I havn't had a chance to run your example yet, but to give you a sense of the current limitation of napari, if you look at this schematic below

if you have a rotated cube and then try to take a 2D slice (the dashed line) through it then we actually can't do that right now. It's on our list to support this, but we're not there yet. Is this what you're seeing?
Note that 3D rendering is fine.
Happy to go into more details about why we have this limitation now and how we might go about improving things

Yes I think this is exactly the problem. 3D is fine. I guess non orthogonal slicing through an array is far from trivial. Might there be a workaround to display the image in 2D without the sheer and out of slice rotation? I try to improve the nibabel napari plug in. Therefore, I hope to include affine transformation, but If the transformation breaks the 2D view it is a problem.

Are there any developments on this?

It's on our roadmap (consistent transformations) but that's about all I can say for the moment... I will personally try to put some effort into this over the summer...


add a pop up message for the delay in the returning date

in this we need to add another fill box of the returning date of that particular issued book and in case we are not able to remember the return date then a pop up is available to make us remember about returning date of that book .

@SauravMukherjee44 thank you for assigning me this task will solve it as soon as possible


transfers: validate amount.value better

Found when looking at https://github.com/moov-io/app/pull/55

Codecov Report

Merging #581 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   51.04%   51.10%   +0.06%
==========================================
  Files          93       93
  Lines        3123     3123
==========================================
+ Hits         1594     1596       +2
+ Misses       1181     1180       -1
+ Partials      348      347       -1

Impacted Files
Coverage Δ

pkg/transfers/router.go
58.20% <100.00%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78391d...a477697. Read the comment docs.