Long Delay On Every Read When Offline

Step 0: Are you in the right place?
[REQUIRED] Step 1: Describe your environment

Using Firestore SDK on Xamarin via Plugin.CloudFirestore (which wraps Xamarin.Firebase.iOS.CloudFirestore)

Same issue occurs on Android, so does not seem to be platform specific.
[REQUIRED] Step 2: Describe the problem
When offline, Firestore appears to try the network first (and wait for a lengthy timeout) for every read before attempting to read from persisted cache. In our case, our app performs 20-30 trivial queries at launch. These queries take 2-3 seconds when online, but were taking 5 minutes when offline. By forcing the 'source' param on GetDocument() to be Cache when offline, the launch drops from 5 minutes to below 1 second.
Steps to reproduce:
100% reproducible. It is possible the issue is related to the Xamarin library, but that seems unlikely given that it is strictly wrapping the native APIs.

Hi @barrysohl,
Thanks for the report.
I failed to reproduce what you described, with a vanilla iOS App and latest Firebase/Firestore SDK. When device is offline, the app is still able to get the initial snapshots from cache with default listen option, instantly. There is no noticeable delay.
I don't have much experience with Xamarin, I could try to reproduce it as well if you could provide a more detailed guide on the setup and code snippets. Also please include the versions of all related components.
Thanks

In this case, we're not using listen/snapshots. It occurs using just direct GetDocumentAsync reads. It occurs on Android as well. This snippet is C#/Xamarin specific, but maps pretty directly to the native API:
			var query = GetCollection( collectionKey ).WhereEqualsTo( field, UniqueId );

			// Optional sorting (ascending)
			if ( !string.IsNullOrEmpty( orderBy ) )
			{
				query = query.OrderBy( orderBy, false );
			}

			// Blocking read
			var results = await query.GetDocumentsAsync( GetSource() ).ConfigureAwait( false );

			return results.ToObjects<T>().ToList();

I see.
So when the device is offline (or having network issues), Firestore is unfortunately not aware immediately, it would take it some time to figure out, that is the delay you see with GetDocumentAsync, it is basically waiting for the backend to send a signal that the local storage has a consistent view of the data. As you noted above, using Source: Cache will make this go away.
I think a better way is to listen to the query snapshots instead though, since it will give you whatever the local storage has first, then play catch up if backend responds.
OTOH, 5 minutes delay is a bit too long though, I will look into that. But the delay most likely will not go away.
Thanks.

If you could "batch" the delay, that would be fine. For our case, a one-time hit of 10 seconds at startup would be no problem. But right now, it appears to be for every single GetDocumentAsync(), and we have maybe 20 of those calls at startup. And a several minute delay would I think be a showstopper for anyone. If we switched to listening, we would still have to listen on many collections, and presumably still have the same problem.

Switching to listening should lead to no delay for the initial snapshots (from cache), GetDocumentAsync with default listen options is actually implemented through listening, with a setting to turn on backend signalling (I explained above), because the intention was to provide a consistent view since user only read the result once.
The only downside for switching to listens is you have to manually unsubscribe, if you don't want to keep them around. You could do the unsub in the first snapshot raising, which means you might be seeing inconsistent view, or when backend comes around, which means you only unsub when your view of data is consistent (note you need includeMetadataChanges: true because second snapshots might not have actual document change).

Also, I just tried reproducing with GetDocument, and the documents load pretty quick to me.
At this point, I'd need a reproduce instruction to proceed.

In retrospect, I wish we would have implemented everything with listeners/snapshots, but that would be a pretty significant re-architecture for us at this point. As mentioned, it is possible it's something related to the Xamarin library we're using. Since forcing GetDocument() to read from cache solves the issue, I think it's a viable workaround for us. We can close this ticket and revisit later if it becomes an issue. Thanks!

Thanks, closing the issue as per your recommendation. Like you mentioned, if you need to revisit it please re-open as necessary!


Admin Router: Deduplicate service.lua and related files

High-Level Description
This PR:

consolidates service.lua code into a single file.
makes service routing code more efficient by pre-calculating some of the data in cache.lua/during cache fetch stage.
refactors code to better accommodate incoming hierarchical service names
cleans up the code, adds some docstrings

Related Issues

DCOS-14589 Admin Router: Dedup of /service/ endpoint

Dependencies
Related EE PR: https://github.com/mesosphere/dcos-enterprise/pull/798
This PR is rebased against https://github.com/dcos/dcos/pull/1438 and as such, #1438 should be merged first.

@mesosphere-mergebot label Ready for review

@vespian can you please rebase this agains master to pick up the pinned python dependency which should make teamcity/create-release-pr be able to build.

@mesosphere-mergebot label Work in Progress

@BenWhitehead This PR is waiting for #1438 to be merged, I have relabeled is as Work in progress for now. After #1438 gets in, I will rebase & cleanup  this one and make sure that tests are green.
Thanks!

Closing in favour of https://github.com/mesosphere/dcos/pull/16


[DOC] Add doc for fuse clean policy

Provide a link to that doc page:
What is the defect and your suggestions on improvement:
Add doc for fuse clean policy

Done. Pull request has been merged.

Closed by #2221


KMP support

@thunderbiscuit, the library is great! @jmateoac and I are starting to look at Cashu and would love to use the lib for a hackweek app. Is there any interest in migrating the library to KMP?
Going through dependencies, looks like we are halfway there.
Deps that are already KMP:

org.jetbrains.kotlinx:kotlinx-serialization-json
fr.acinq.bitcoin:bitcoin-kmp
fr.acinq.lightning:lightning-kmp
io.ktor:ktor-client-core

Deps that will need replacement:

com.google.code.gson:gson -> org.jetbrains.kotlinx:kotlinx-serialization-json?
org.jetbrains.exposed:exposed-core, org.xerial:sqlite-jdbc -> SqlDelight is a good option here, wdyt?
org.slf4j:slf4j-api, ch.qos.logback:logback-classic -> Kermit?

We could migrate in small phases:

Replace JVM-only deps with KMP alternatives
Migrate lib to use KMP Gradle plugin, with JVM target to begin with
Add other targets, Android and Native would be a good start

Hey that's awesome! I'm happy to migrate the JVM-only dependencies to KMP ones for sure, particularly if you're familiar with them and think they'd be a good replacement (I haven't worked with Kermit for example).
A few more thoughts:

I'm super flexible on the architecture and happy to hear other developers thoughts. As this was developed one step at a time as I was reading the spec it's a bit all over the place. It's great if the lib can be looked at from fresh eyes.
Just an FYI: you will find that the Cashu spec is moving super fast, and has accelerated over the past 6 months. I haven't touched the library much in that timeframe (the release of BDK 1.0 being my focus at the moment), and so it's now fairly outdated. If you're interested in bringing it up to spec go wild! I can try to review and merge fairly quickly if that's part of your hack week and you want to put time into updating it.

Branch with progress so far: https://github.com/kirillzh/cashu-client/pull/3


ng2-overlay imports BrowserModule, should import CommonModule

The ng2-overlay component imports BrowserModule, this causes code that is built upon lazy loaded modules to fail with the following message:

EXCEPTION: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.
Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

The import of the BrowserModule should be the responsibility to the base loader and not be done in a component like this. Please use CommonModule instead.

Added a Pull Request for this:
https://github.com/ng2-ui/ng2-overlay/pull/2

Thank you

Nice, I hope an updated NPM package is on it's way to.

published as v0.6.3


fix(azure): add support for Azure affinity groups

NOTE: this replaces #3173 since I was too lazy to do a full rebase
This PR adds two fixes that will make a 5-vm Deis cluster stable on Windows Azure:
Enhancements

Support for specifying affinity-group as a valid argument to the azure-coreos-cluster script.

Overall platform startup speed reduced by about 15 minutes (ballpark) for a 5-vm cluster on Azure.
Overall platorm stability and inter-fleet latency reduced to an average of 59ms. See full cluster stats

Specific settings for etcd.service that will prevent the cluster from dying because of reaching the file-open limit

Cluster becomes stable and stops throwing "too many open files" error anymore (possibly related to #1240).

TODO

Add setting an affinity-group option as a very recommended option in the official Deis docs for an Azure setup.

Acknowlegements
Enormous thanks to @aledbf , @sedouard and @carmstrong for helping me with the cluster setup and debugging my situation.

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

Code LGTM! Thanks @gvilarino!

Code LGTM.


Upgrade the canary to the new MSRV

Motivation and Context
This bumps the canary to the new MSRV which might get it passing again.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Kicked off a run of the canary against this branch: https://github.com/awslabs/aws-sdk-rust/actions/runs/2968209930


Channel sold in pool, pending for over a week.

Hey guys!
I sold a channel in the pool more than a week ago and that channel is pending to open until now.
In the meantime I opened other channels on my own that opened normally, but this one from the pool is still pending to open.
Can you help me?
hash a2807486889f83c724124266a3393cd00e088a5d70d167f01d40c68428aef8a0
Transaction not found.

I am using umbrel 0.5.2 on a raspberry pi 4 8gb. Lightning Terminal 0.8.2-alpha.
All the apps and OS are all updated to the latest version available on the umbrel.

Hi! Happy to help. First, I'll just gather some information to help the team better debug your issue. Do you know the pubkey of the peer the channel was being opened to? Also, do you have your trader key from Pool? Finally, do you have any logs from litd during the time period that the channel was opened? All can be helpful with debugging in various ways.

It looks like the a2807486889f83c724124266a3393cd00e088a5d70d167f01d40c68428aef8a0 tx was a batch attempt that never went trough (because of your node or others not accepting the batch). It would be really useful to check the logs for terminal and LND during the time that this happen Oct 21, 2022 19:02:55 - 19:03:20 UTC.
I have some questions about your client:

Is the pool daemon up?
What is your trader key?
What is the status of your account?
What is the status of your orders?
Did you participate in any other matches after this one?

Thaks very much!
Pubkey of the peer User21952
0236e577964da670c730e7f362fa0c561b75dc9af02c0d822179f155e1455b20bd
Tader key
038444b4bcccec17443a4d73c01b39ce2183d9407cbbb3e6058465a056cf69083c

There was an intend to sell a channel in one batch but it did not go through. It looks like your lnd node was not able to clean the state of that failed try. I would advice to check the logs of your terminal daemon/lnd node during that time to see why it was not  cleaned up.
Your account is now expired (or close to expire) but this order could have match without any problem during the last week (it did not, so double check that terminal was connected to the auctioneer) but you should be able to interact with your account without any issue: deposit/withdraw funds, submit orders, etc..
Feel free to cancel that channel open from LND manually.

Got it.
But how do I cancel a channel that is opening?
In LNDg I need to enter the ID to perform the cancellation of a channel. But since it is opening, there is no ID yet.

I guess there is no other way than using the abandonchannel lncli subcommand @guggero? Does chantools have a safer way to do this?

@iksolon that pending channel should've been cleaned up by Pool/Lit automatically. Did you stop LiT for some reason?
But yes, in this case, because it's verifiable that the funding transaction will never confirm (since it was a Pool batch transaction that was never finalized), you can use the lncli abandonchannel a2807486889f83c724124266a3393cd00e088a5d70d167f01d40c68428aef8a0 0 --i_know_what_i_am_doing command (which is what Pool would've used internally too to clean up a batch that didn't go through).

I don't know about LiT, but I experienced a bug a few days ago (reported in #437), where my pool account showed up as closed and I had to recover it by following your directions. This could be it.
Anyway, problem solved. Thanks again for your attention!

last question: is it ok if I leave my trader key published here?

Ah, okay. So the recovery explains why the channel wasn't cleaned up automatically, Pool didn't have the required information to do it. But happy to hear that the command helped solve the problem.
The trader key is not particularly sensitive, I would say it's okay to keep it here (AFAIK updating the comments will only hide it in the last version of the comment while the previous versions can still be looked at, so things aren't deleted by GitHub really).
Closing the issue as everything seems either explainable or solved.


Bug when using sake with .ssh/config

[X] I have the latest version of sake
[X] I have searched through the existing issues

Info

OS

[X] Linux

Version: 0.15.0

Authentication:

[X] Identity Key

Key Type:

[X] ed25519

Key Format:

[X] rfc4716

Problem / Steps to reproduce

sake.yaml:
servers:
  myserver:
    host: server

tasks:
  ping:
    desc: Pong
    cmd: echo "pong"

~/.ssh/config:
Host server
  HostName <IP_ADDRESS>
  User root
  IdentityFile ~/.ssh/ailab_ed25519

sake run ping --all

Output:
error: open ~/.ssh/ailab_ed25519: no such file or directory

sake ssh myserver

Output:
<EMAIL_ADDRESS>password:

It picks up my PC name (ronny) instead of the the server username (root).

$ ssh-keygen -t ed25519 -C "ailab-server"
Generating public/private ed25519 key pair.
Enter file in which to save the key (/home/ronny/.ssh/id_ed25519): ailab_ed25519
Enter passphrase (empty for no passphrase):
Enter same passphrase again:

Passphrase is empty

Seems ~ was not resolved correctly when using ssh config (it is if specifying the in sake.yaml), as well as PubFile not being updated when using ssh config. Should be fixed with 0.15.1, let me know if it isn't.

Sorry for late reply, looks like there's another error:
sake run ping --all

output:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x75d5be]

goroutine 1 [running]:
github.com/alajmo/sake/core/run.ParseServers(0xc00005fce0, 0xc000111210, 0xc0001b2580, {0x834538?, 0x0?})
	/home/runner/work/sake/sake/core/run/exec.go:655 +0xa1e
github.com/alajmo/sake/core/run.(*Run).RunTask(0xc000111200, {0x0, 0x0, 0x0}, 0xc0001b2580, 0x0?)
	/home/runner/work/sake/sake/core/run/exec.go:74 +0x170
github.com/alajmo/sake/cmd.runTask({0xc00006b3a0, 0x1, 0x0?}, 0xb7a760, 0xc0001b2580, 0xc0001be9f0?)
	/home/runner/work/sake/sake/cmd/run.go:338 +0x5ea
github.com/alajmo/sake/cmd.runCmd.func1(0xc0001ba900?, {0xc00006b3a0, 0x1, 0x2})
	/home/runner/work/sake/sake/cmd/run.go:141 +0x775
github.com/spf13/cobra.(*Command).execute(0xc0001ba900, {0xc00006b380, 0x2, 0x2})
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:944 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0xb75880)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992
github.com/alajmo/sake/cmd.Execute()
	/home/runner/work/sake/sake/cmd/root.go:42 +0x25
main.main()
	/home/runner/work/sake/sake/main.go:8 +0x17

It seems sake try to resolve the host as hostname, but fail.
Maybe use ssh -G <host> for resolve configuration. (That also support Host *)


[feat/onboarding-flow] Simplified Onboarding Flow

Name of the PR
:recycle: Current situation & Problem
Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR
:bulb: Proposed solution
Describe the solution and how this affects the project and internal structure
:gear: Release Notes
Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.
:heavy_plus_sign: Additional Information
Provide some additional information if possible
Related PRs
Reference the related PRs
Testing
Are there tests included? If yes, which situations are tested, and which corner cases are missing?
Reviewer Nudging
Where should the reviewer start? Where is a good entry point?
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[ ] I agree to follow the Code of Conduct and Contributing Guidelines.

Thanks for the feedback @PSchmiedmayer, it greatly contributed to overall design of the implementation! 🚀
Feel free to take a quick look into the PR again, I think it's in a good state to receive some high level feedback. Of course, there are some minor details to be figured out, more docs and test cases to be written etc., but I guess now would be a good time to receive some more feedback on the overall concept and design of the PR 😄

Hi @PSchmiedmayer,
the PR is now in a reviewable state and proper descriptions, docs, and tests are written. 🚀
Only issue I couldn't solve was regarding CodeCov which apparently isn't properly receiving the collected code coverage stats. I tried to follow your suggestions from https://github.com/StanfordBDHG/XCTHealthKit/pull/13#issuecomment-1622464382 but sadly that didn't seem to work. Any other ideas here? :)

@philippzagar Regarding the flakey UI test coverages: I would recommend that you explicitly add the SpeziOnboarding target to the list of build dependencies in the Scheme editor:

This helped a lot in previous PRs when I ran into similar issues. I would also recommend explicitly adding it as a code coverage target in the TestPlan:

It seems like the test plan is currently not used (see scheme settings). You can explicitly point Xcode to it and set the Build configuration to "Test" to ensure that Previews should not count to the coverage:

Thanks @PSchmiedmayer for the nice review, I'll merge this PR soon! 🚀

@PSchmiedmayer I drafted a new release of SpeziOnboarding (0.4.0 as it is quite a big upgrade fro the onboarding package), feel free to publish it: https://github.com/StanfordSpezi/SpeziOnboarding/releases

Thank you for the PR, I tagged the release! 🚀


Fix time parsing in gigasecond tests

As mentioned in #232, this is to fix the Gigasecond tests.
This fixes the parsing of the date strings in the tests. According to the docs the, a couple of the dates are in ISO 8601 format rather than RFC 3339. RFC 3339 requires the time zone to be specified when the String contains a time. ISO 8601 dosn't have this requirment.
See:

https://modules.vlang.io/time.html#parse_rfc3339
https://ijmacd.github.io/rfc3339-iso8601/

[no important files changed]
I've marked the commit with [no important files changed] as this commit shouldn't change any past test results.

Btw, the break in the Gigasecond test seems to have been caused by this commit in Vlang: https://github.com/vlang/v/commit/c55a75f41271ef41347125ccb0dc92962a1180b0


Export meta graph option in image retraining

I was trying to tensorflow serve my retrained graph ( *.pb file ) but if I understand correctly it doesn't contain meta graph in it, so wouldn't it be nice to have export meta graph options in retrain.py ?

@sherrym how do you think this request for meta graph example code should be triaged?

It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Weights Option for DensityProblem class

Adding optional weights parameter to DensityProblem class. This allows the solution to the density problem to be weighted by prior beliefs on the initial sample set. In particular this is being applied to iterative MUD problems for time-series data. A corresponding weights parameter is being added to the mud_problem function, that can be used to implement these iterative solutions. The r value from the previous mud problem solution can be used to weight the QoI samples on a future iteration with a different set of time-series data. Examples to follow in the mud-exmaples repository.

I guess I don't have tests for this class in here, hence the coverage not decreasing... what an oversight.
looks good to me! thanks for the contribution!

@cdelcastillo21 turns out in classes, methods only have one space between them. linting commit: https://github.com/mathematicalmichael/mud/commit/476fabb515b9c7c5f62dd91c05d596eb19970575


[v3.0] Do I need the openssl fipsinstall step in INSTALL.md under Post-installation Notes

Hi!
I saw the Post-installation Notes which says to run
'openssl fipsinstall' command right after the installation part, not sure this is correct, because I saw that 'nmake install' does some part regarding the fips installation..
So my questions are:

Is it a mistake and this section in the INSTALL.md can be removed or maybe modified in a way that explains that this step is already exists in 'nmake install' command?
If it isn't a mistake, maybe add more explanations regarding how and from where to run this command.. I tried to run it from the installation output folder \OpenSSL\bin with the command 'openssl.exe fipsinstall' but it does nothing.. I need to run some more arguments with it, and I didn't find any interesting arguments..

Thanks!!

Edit: I saw in README-FIPS that the nmake install indeed run in the second part 'openssl fipsinstall' so I guess I'm write to say that this step is not needed manually after the nmake install and can be dropped or modified in the INSTALL.md?
Thanks.

Hi @paulidale can you help me here? :) thanks!


test: add TypeScript module specs to examples

This is to show existing support for TypeScript modules.
Summary
Per https://github.com/kulshekhar/ts-jest/discussions/3954, I'm adding example specs with the .mts extension.
This is based on ts-jest's documentation and existing code.
Test plan
npm run test-examples
I manually inspected to confirm each of the configuration files this PR touches runs two different spec files: the existing one and the new TypeScript module file.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Questions on this patch for reviewers, because I'm unfamiliar with this code base:

Should the transform value always be ['ts-jest', ...]?  The type definition says it could be TransformerConfig, which is just [string, ...].  I am specifically asking because it differs from the preset field in most of these changes.
There's a big Caution about mixing preset and transform in the documentation.  I see some of these examples already do this, but I'm making it happen here across all of them.  What's the right way to handle this?
Help wanted with the react-app example.  I tried to update it, but I'm almost as new to React as I am to this project.  It was too complex for me to quickly figure out.  So I left it alone...
I figured out most of the mjsResolver's type.  When I tried to include it in the TypeScript file, jest-resolve gave me many errors.  I tried adding a .d.ts file (which led to linting errors), and renaming it to .mts.  Finally, I just put it in as a void string expression, which is a Dirty Hack.  I'd like a better fix, so that we can do proper type checking on the resolver.  As code documentation, though, it's better than nothing.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 95.853%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
4055

Relevant Lines:
4154

💛  - Coveralls

I noticed that none of these examples have been updated to use module / moduleResolution values of NodeNext.  NodeNext requires extensions when specifying relative paths, e.g. import {foo} from './foo.mjs' resolving to the file foo.mts on disk.  I don't see that happening anywhere here, and I think it might be part of the problem I'm trying to solve in my own project.


When a user changes their githubid, but keeps the same uid, the github linker breaks

This is because the username is used for the API calls instead of the uid.
Perhaps instead, consider using the UID.
The wrong username is also shown in the user info at upper right on the nav bar.  Again, on oauth authentication, consider updating the username from the github data.

Closing, this seems to have been fixed some time ago in 598a2d.


chore: lowercasing when matching slug

Description

Deploy Notes
Notes regarding deployment of the contained body of work. These should note any
db migrations, nginx routes, infrastructure changes, and anything that must be done before deployment.

[ ] Need to add environment variables

ENV_VAR=

Screenshots (if appropriate)

Review Error for lauchness @ 2023-08-13 16:28:00 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


Update README

As a developer, I'd like to add an overview section in the README.
Acceptance:

README updated
repo-root token needs changed to task-app-starters-root

This is complete.


split hash join return block if its rows is more than max_block_size

What problem does this PR solve?
Issue Number: close #6384
Problem Summary:
What is changed and how it works?
If we return too many rows in the block in hash join, we'll split those rows into blocks and return them multiple times to make sure that the rows in each block are close to max_block_size.
Check List
Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

split join probe return block if need.

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/merge

/run-integration-test


Bump curator version and set explicit curator version

@pcross616 Good to go, paying off tech debt and making sure we don't run into guava version collisions again.

Looks good


Correct 1851 Parms extraction

The 1851 parms from TNA have multiple sub districts in the same piece. Out current extraction give each the same piece number. Making all but the first subdistrict in accessible.

@geoffj-FUG
For 1851 there are 1157 duplicated file names (read numbers) with different sub district names ,ie a file may have multiple sub districts in the file.

Our structure and file look up was based on the assumption of a single sub district in the file. Specifically we used the file name to look up the Sub district and its civil parishes. Hence the problem @johnt-freecen encountered
The are 2 possible solutions

we rename the files that contain the multiple Seb Districts by adding an upper case Alphabetic character to the name eg

If we proceed this way the transcriber has to enter HO107_2093 or HO107_2093A or HO107_2093B depending on the sb district that are transcribing
2) we read the first enumeration district in the file, extract the civil parish and attempt to find the appropriate sub district to determine which of the file entries we should be using. This is unfortunately subject to errors in inputting the civil parish and there are occasions when civil parishes are split across multiple files. In other words it is not a fail safe approach.
My preferred approach is option 1.
PS The issue is unique to 1851

Kirk
1851 was an abomination to transcribe. I only had a couple of transcribers who could cope with files with 20 to 25 thousand entries. The a, b, c, d etc break up in file names that we proposed will be a godsend to Coordinators as they can break up the pieces into EDs for transcription etc.
Your proposal 1 is not that far different logically. I am happy with it.
Geoff
From: Kirk Dawson<EMAIL_ADDRESS>Sent: Sunday, September 27, 2020 8:29 AM
To: FreeUKGen/FreeCENMigration<EMAIL_ADDRESS>Cc: geoffj-FUG<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [FreeUKGen/FreeCENMigration] Correct 1851 Parms extraction (#985)
@geoffj-FUG https://github.com/geoffj-FUG
For 1851 there are 1157 duplicated file names (read numbers) with different sub district names ,ie a file may have multiple sub districts in the file.
https://camo.githubusercontent.com/9e657fda263cf7d405a1805da4e82b4158b7747f/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3562363861653638346235383036626332626465666366302f61626331626161392d313934342d346161322d396662342d313433386135633537613837
Our structure and file look up was based on the assumption of a single sub district in the file. Specifically we used the file name to look up the Sub district and its civil parishes. Hence the problem @johnt-freecen https://github.com/johnt-freecen  encountered
The are 2 possible solutions

we rename the files that contain the multiple Seb Districts by adding an upper case Alphabetic character to the name eg
https://camo.githubusercontent.com/d8593ab58d5e6e83fcf20d35c2c91b607d08cfdd/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3562363861653638346235383036626332626465666366302f39396130373062652d613465352d346331612d393736622d306564636530326430343134

If we proceed this way the transcriber has to enter HO107_2093 or HO107_2093A or HO107_2093B depending on the sb district that are transcribing
2) we read the first enumeration district in the file, extract the civil parish and attempt to find the appropriate sub district to determine which of the file entries we should be using. This is unfortunately subject to errors in inputting the civil parish and there are occasions when civil parishes are split across multiple files. In other words it is not a fail safe approach.
My preferred approach is option 1.
PS The issue is unique to 1851
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/985#issuecomment-699556384 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFJZWGIEDIVJ3DZV5DTSHZTJFANCNFSM4RXQQURQ .  https://github.com/notifications/beacon/AKCPIFKJCB4AD7QVL6F4M7LSHZTJFA5CNFSM4RXQQUR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGZGEIA.gif

Completed and deployed to test3

@johnt-freecen This was raised whilst you were testing an 1851 piece. I dont have one ready to test for that year. Does this resolve the problem that you had? Geoff

Hi Geoff,
As far as I am aware this is still open. For 1851 HO107_2093 there are three different piece names each with a different list of civil parishes.
I know that the proposal was to call these 2093A, 2093B and 2093C or some such, but am not aware of any actual chances to the system yet.
How I picked this piece by random I do not know.
Regards
John
Sent from Mail for Windows 10
From: geoffj-FUG
Sent: 29 September 2020 12:00
To: FreeUKGen/FreeCENMigration
Cc: johnt-freecen; Mention
Subject: Re: [FreeUKGen/FreeCENMigration] Correct 1851 Parms extraction (#985)
@johnt-freecen This was raised whilst you were testing an 1851 piece. I dont have one ready to test for that year. Does this resolve the problem that you had? Geoff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@johnt-freecen @geoffj-FUG The code to create 1851 Parms is working. It has not been run on test3 as I would need to delete the existing set. This would mean that all 1851 test files would need to be rerun. Not sure how big an impact that is. If it is small we should do the recreate. Advise please

Hi Kirk,
I only have the one 1851 piece which I have not really started work on yet, other than getting the civil parish errors. I have taken my original largish file and spilt it into two pieces, the first matching block one of the district groups, just to check that the civil parish was ok.
I can do nothing with the second batch until this is done. It would be nice to run the second group against the change to see it works.
This is then something that needs spelling out to the co-ordinators when they have 1851 pieces to run.
Regards
John
Sent from Mail for Windows 10
From: Kirk Dawson
Sent: 29 September 2020 15:01
To: FreeUKGen/FreeCENMigration
Cc: johnt-freecen; Mention
Subject: Re: [FreeUKGen/FreeCENMigration] Correct 1851 Parms extraction (#985)
@johnt-freecen @geoffj-FUG The code to create 1851 Parms is working. It has not been run on test3 as I would need to delete the existing set. This would mean that all 1851 test files would need to be rerun. Not sure how big an impact that is. If it is small we should do the recreate. Advise please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have no 1851 files on test3 that I cannot do without. So I am happy for you to proceed if John is OK.
Beki is working on 1871 so it should not affect her. Chas is working on 1901 so it should not affect him.
Just get the all clear from John
Geoff

! am happy for the 1851 changes to go ahead. I only have the one 1851 file there and not really done anything with it due to this problem.
Just let us know what the change to the file name needs to be please.
Regards
John
Sent from Mail for Windows 10
From: geoffj-FUG
Sent: 30 September 2020 10:57
To: FreeUKGen/FreeCENMigration
Cc: johnt-freecen; Mention
Subject: Re: [FreeUKGen/FreeCENMigration] Correct 1851 Parms extraction (#985)
I have no 1851 files on test3 that I cannot do without. So I am happy for you to proceed if John is OK.
Beki is working on 1871 so it should not affect her. Chas is working on 1901 so it should not affect him.
Just get the all clear from John
Geoff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


fix: Coin logos not loading in the Balance Widget

Hi👋, please prefix this PR's title with:

[ ] breaking-change: if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.
[x] feat:, fix:, refactor:, docs:, or chore:.

Summary
MenuItem.FramedImage uses CloudImage under the hood, so you need to pass the imageResizeServiceUrl to it in order for the image to load in sandbox and prod.
There are other instances of MenuItem.FramedImage that needs this fix, but this PR fixes the known occurrence of this in the Gems Game.

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

Hey @keithbro-imx I'm happy to merge this if its a blocker for you.. I'm also working on a ticket at the moment to remove the use of CloudImage component across all the widgets for token images as they won't work outside of Immutable.com domains (ie on TokenTrove/Sphere) as the image resizer WAF is restricted.. so this implementation will change shortly.
https://immutable.atlassian.net/browse/CM-616


Think of User Guide Flow and Implementation

Current user guide is very plain, doesn't smoothly bring the reader through all the features in a quick, enjoyable, comfortable manner.

I'll think of the implementation over the weekends, @kenoung you can look through it and see if any parts can be improved


web builds are broken

Resolved by updating emsdk.

Apparently, it still happens when compiled using a Linux host runner.


Armstrong Numbers

Added a new exercise (Armstrong Numbers).
Please review.
Thanks.

This looks good. You probably also want to add this to config.ss and config.json as with the other problem so it goes live on the site

Comments?

Looks good!


Correction for raw affiliation Department of Psychology, King's University College at Western University, London, Canada

Correction needed for raw affiliation Department of Psychology, King's University College at Western University, London, Canada
raw_affiliation_name: Department of Psychology, King's University College at Western University, London, Canada
new_rors: 02grkyz14;
previous_rors: 02grkyz14;048f5b183
works_examples: W4386407042
contact: b224f9c0c93f8ef8d0d66b0ed45e2035:38138e8b5782edae @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-21. The new affiliations should be visible within the next 7 days.


Uv fails to activate environment in folder with spaces (maybe it's because of apostrophes?

I tried these commands in a folder with an apostrophe and a space.
uv venv
source .venv/bin/activate

This is uv version 0.4.25 running the dnf package of uv on Fedora Linux KDE Spin 41

What operating system are you on, and what's the name of the folder verbatim?

Fedora Linux 41. Testing's test. I think it's the apostrophe.

Documenting the background on shell escaping:
We want our activate script to support basically any posix shell. There's two kind of quotes: Single and double quotes. In bash, single quotes must not contain another single quote, you can't even escape it (https://linux.die.net/man/1/bash under "QUOTING"). Double quotes have escaping rules different from shell to shell, which we can't do. bash has $'\'', but that's not universal enough.
As a workaround, we can go through printf:
VIRTUAL_ENV=$(printf '/home/konsti/projects/uv/Testing\047s/.venv')

You could maybe use what shlex suggests (python stdlib shlex), both '' and "" strings.
print(shlex.quote("/home/Testing's/.venv"))
'/home/Testing'"'"'s/.venv'


Update .Net SDK to .Net 8

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
Latest versions of Pulumi require .Net 8, which is the most recent LTS release of .Net. https://devblogs.microsoft.com/dotnet/announcing-dotnet-8/
Affected area/feature
Deployment PR's via the GitHub app use the default Docker container, which currently installs .Net 6 SDK.
The default docker container should be updated to install the .Net 8 SDK instead.

.NET 8 is now included in the pulumi/pulumi image and there are now separate pulumi/pulumi-dotnet-6.0 and pulumi/pulumi-dotnet-8.0 images available for each version. The pulumi/pulumi-dotnet image still defaults to .NET 6, but we will be updating the default to .NET 8 in November. See https://www.pulumi.com/blog/docker-containers/ for details.


Add library version to all exceptions

Add the version text of the cocoa binding to all exceptions thrown from core. In RLMRealm:throw_objc_exception()
In likely doesn't make sense to include it in make_realm_error.

If we do this at all we should add it to the userInfo for the exception, not to the message.
There is currently not a common code path used for exceptions at the moment so this requires changing quite a bit of code.

agree to adding to user info.
Most likely the interesting exceptions that would benefit from this info are the ones thrown from core which are "exceptional" in nature. That's only one place in the method mentioned - right?


[Question] how to use saveDraft in

i have a question about saveDraft. I'm using . How can i use saveDraft in that?

Have the same question with @thambui. I just found it in FormIO JS https://formio.github.io/formio.js/app/examples/savedraft.html. Can you please provide some information if you have?

If you wish to have them manually saveDraft, then this can just be configured in the Form builder by adding a new Button and set the action to "Save in state" and then add "draft" to the state that will be saved. This will allow the submission to be saved as "draft". If you wish to "auto-save" then this can be configured as part of the formioOptions added to the  directive like so.
<formio [formioOptions]="{
  saveDraft: true
}"></formio>


storage: CSIStorageCapacity

This is the documentation for CSIStorageCapacity, which was merged for 1.19 today:

https://github.com/kubernetes/enhancements/issues/1472

The PR used to contain also documentation for GenericEphemeralVolume, but I took that out because documentation wasn't as closely tied as I first thought and the featured hasn't been merged yet.
Therefore this PR is now ready for review and (eventually) merging.

Pinging:

@msau42, @jsafrane: technical review (IMHO not a blocker, but nice if they have time)
@divya-mohan0209, @savitharaghunathan: docs review

/sig storage

I had a quick look. I wonder if this actually belongs inside https://kubernetes.io/docs/concepts/scheduling-eviction/ (with lots of inbound signposting from the storage concepts section).
@pohly what do you think?

I'm undecided. We could have used storage topology support as guiding example, but I couldn't find any documentation for that. Also related are node-specific volume limits (https://kubernetes.io/docs/concepts/storage/storage-limits/), which is documented under storage although it is a scheduler feature.
Following that example and because the implementation is owned by SIG-Storage, I'd prefer to keep storage capacity under concepts/storage. Just my 2 cents, I'm also fine with moving it.

OK, makes sense. Please consider signposting to this from any relevant pages about scheduling!

OK, makes sense. Please consider signposting to this from any relevant pages about scheduling!

I added something to kube-scheduler.md and pushed the rebased+squashed commit.

The preview looks readable, has valid Markdown, and is in line with website style and content guidelines.
Ready for technical LGTM.

Page previews:
https://deploy-preview-21634--kubernetes-io-vnext-staging.netlify.app/docs/concepts/scheduling-eviction/kube-scheduler/
https://deploy-preview-21634--kubernetes-io-vnext-staging.netlify.app/docs/concepts/storage/storage-capacity/#enabling-storage-capacity-tracking

Thanks @pohly . Noted a few questions. Generally, looks good.

Hi @pohly 👋  1.19 docs shadow here, a friendly reminder that docs deadline is tomorrow. Pinging you to address the review suggestions above so we can get approvals from both tech/docs to merged in! thank you

@msau42, @kbhawkey: I pushed an update, please take another look.

/lgtm
from tech

@pohly , Would you rebase? I am looking again.

@kbhawkey: rebased.

@pohly , Thanks!
/lgtm

@savitharaghunathan , Ready to merge? Thanks!


Latest update indicates personal use only when paid for

Describe the bug

There is a "Personal use only" label on the top right even though we have licenses
To Reproduce
No response
Expected behavior
No response
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.4.3
Commit: 75d38a2c2d9a2b42d64378a8f50f31d4d566df10 (v1.4.3)
System info:
macOS: 14.3.1 (23D60)
CPU: arm64, 10 cores
CPU model: Apple M1 Pro
Model: MacBookPro18,1
Memory: 32 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-03-18T15-57-55.202396Z.zip

Screenshots and additional context (optional)
No response

Not related to an update — following up separately.


jQuery ready functions aren't being called

🐛 Bug Report

The callable passed to $() should be called when the DOM is ready, but it isn't being called.
import $ from "jquery";

$(() => {
  console.log("I won't be called");
})

To Reproduce
Steps to reproduce the behavior:
Put the following code in a test.
Link to repl or repo (highly encouraged)

envinfo

  System:
    OS: macOS 11.3.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 2.4.0 - ~/.nvm/versions/node/v14.16.0/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm

Here's a repo that demonstrates the problem:
https://github.com/goodoldneon/jest-jquery-repro


Update email-dev-dashboard.md

Corrected the time-frame for approvals to take effect.
Fixes #946

Docs Build status updates of commit f432cfd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/email-dev-dashboard.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


moved wallet creation logic

Codecov Report

Merging #54 (d9b0a91) into main (c11fd20) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   86.95%   86.95%
=======================================
  Files           8        8
  Lines         575      575
  Branches      143      143
=======================================
  Hits          500      500
  Misses         73       73
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Thoughts about the repo's name

@Unitech what do you think about changing the repo's name from pm2-docker-alpine to  just pm2-docker
and then add support for more docker images?

A rewording make sense. What do you mean by adding support for more docker images?

Github should handle the url redirect automagically, but i'm not sure about that.
Maybe a new repo is better, but I think it can generate confusion.

The official nodeJS Docker repo ships more than just alpine's node images.
https://hub.docker.com/r/library/node/tags/

Maybe we can create a script that pulls automatically all tags from the Official nodeJS docker repo and generates all Dockerfile for this repo.

This could be the first step, and then we will think about implications of the rewording.

Alright I see, thanks. Building that script would be a great idea, let me know if you need any help on that.
I confirm that github handle well redirection when renaming a repo, anyway I will impact this change on the docker registry

pm2-docker or docker-pm2 ??
The official node repo is called:
docker-node
I'll try to do the script and then I'll open a PR 🚀

+1 for docker-pm2

Let's go for docker-pm2!

The only problem is that currently the binary is called pm2-docker. We should also rename the binary into the pm2 repo:
https://github.com/Unitech/pm2/search?utf8=✓&q=pm2-docker

@simonepri I don't think it's that much a problem, there is a difference between the binary name and the image name

Hello @simonepri!
So what should we do about the repo name on the docker registry? Do we rename pm2-docker-alpine to docker-pm2 or I create a second container image named docker-pm2?

I think the best way is to keep pm2-docker-alpine, since we cannot break users' images and create a new image named just pm2
But I think we could wait until I end the script.

I thought we would create a new image called docker-pm2, but pm2 as an image name would be nice also, why not.
Looking forward this script, that would be great to auto build this container based on the node image

@simonepri what do you think of https://hub.docker.com/r/keymetrics/docker-pm2/? It's a replicat of pm2-docker-alpine but at least it has the right name

It makes sense. Why did you choose docker-pm2 instead of just pm2?
Sorry for the delay but I was full of work. I will try to improve the image asap.

let's keep it short https://hub.docker.com/r/keymetrics/pm2/

Wonderful can you add me as collaborator?
I want to see if its possible to use this:
https://docs.docker.com/docker-hub/builds/#repository-links
This will solve our sync problem with the official nodejs image.

that sounds good, I've just added you as a collaborator

Thanks @Unitech but I can't see any difference:

I've double checked, you've been added to the repo:

It seems that on the Docker Hub a Collaborator is just someone that can see the image also if that is set as private:
https://docs.docker.com/docker-hub/repos/#collaborators-and-their-role

I've followed this tutorial to turn keymetrics into an organization and I've added you as owner :)

@Unitech thanks.
Those are the things we have to do:

[x] Link the node's repo to the pm2's repo on the Docker Hub.This will trigger the build of pm2's images each time node's images are built.
[x] Create a trigger in the build settings of the pm2's  repo on the Docker Hub.This will generates a link that when POSTed will trigger the build of pm2's images.
[ ] Add that trigger in the Web Hook section of the pm2 repo on npm.Each time a new version of pm2 is released on npm our pm2 repo on Docker Hub will be rebuilt.

More info about the last step can be found here:
http://blog.npmjs.org/post/145260155635/introducing-hooks-get-notifications-of-npm

Hooks on npm seems to be a paid feature.
Instead we can add the trigger directly in the Web Hooks section of pm2's GitHub repo.

Awesome! Should we export all the tags from the official node repo also?

deprecation notice https://hub.docker.com/r/keymetrics/pm2-docker-alpine/
on new pm2 release, trigger auto build

Also I've built something that may interest you: https://github.com/Unitech/pm2/issues/3094 feedbacks welcome!

Also we should look how to mark that image as official.
PM2 is quite huge project, I think that the Docker team will publish it without any particular concern.
https://docs.docker.com/docker-hub/official_repos/

I've replaced all occurences of pm2-docker-alpine to pm2
To export all tags, do we need to create a folder for each tag?

@simonepri Node 7 has been dropped of the official node image repo, also pm2 doesn't support node 7 since it isnt a LTS. We should not build image on it i think


Removing OAuth 2.0 authentication from swagger 2 definition

Description
When an API authentication type is changed in wso2am-4.1.0 from the Oauth2 to apiKey or Basic, it won't be reflected in the API definition(swagger/openAPI) file under securitySchemes section. This is fixed in openAPI 3. Need to fix in Swgger 2
Steps to Reproduce
When an API authentication type is changed in wso2am-4.1.0 from the Oauth2 to apiKey or Basic
Affected Component
APIM
Version
4.1
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

closing as the master fix: https://github.com/wso2/carbon-apimgt/pull/12102 has already been merged.


Allow the app to run immediately after launching the osx disk image

If you download a packaged OSX build that opens a folder showing both the app and the Applications directory (example), double clicking the app results in the process starting up, but no browser windows open.
I believe this is because the folder / dmg it's trying to write to for the profile database / logs isn't writeable.  A couple of options:

We could write to a temp directory just in this case.  That's easy, but your profile data would get lost when you drag / drop the app into the Applications directory.
We could switch to using a shared appdata folder across all tofinos regardless of if the app directory is writeable. Maybe this is what we want to ultimately get to, but I have a couple of concerns with it now.  First, it could potentially mess up usertesting.com builds if the same user is doing two different tests and the latter is polluted with the profile data from the former.  Second, now we get to do profile migrations across versions.

Depends on #809

#564 is open to define a real profile directory

OK maybe this should be closed in favor of that, then.  Not sure if there's a big benefit to having a temporary fix in place

Worth keeping this open to check that that does actually fix it, there might be other issues.


SQLite.Interop.dll was not found

wth

Have you referenced System.Data.SQLite?

Closed because of inactivity


[AzureMonitorExporter] api feedback (part2)

Responding to feedback on our public api.
Changes

update Options class

remove preview service version.

update http link in comments.
Note in the screenshots how the link is displayed.

Screenshots
Before:

After:

TODO

waiting for feedback on the Options ctor.

API change check
API changes are not detected in this pull request.

Superseded by https://github.com/Azure/azure-sdk-for-net/pull/37996


Can't integrate AIP in Cloud App Security

Hello, I'm using trial of Office 365 E5. I make labels in AIP and want to integrate in CAS to manually apply labels for files. But I can't do that. This is my configuration and status. Integrate AIP in CAS.docx

@phamanh1652
It looks like you've encountered an issue with the product itself, rather than an issue with the documentation. You may find a solution to your issue in the Azure Information Protection integration topic, otherwise, to make sure it gets in front of the right people, please open a support ticket.


screen brightness

hello is it possible to set the startup screen brightness to your own set brightness ? so that it doesn't have to be done every time?

Have you tried this?
esphome:
  ....
  on_boot:
    priority: -100
    # ...
    then:
      - lambda: !lambda |-
          id(rgb8x32)->set_brightness(YOURVALUE);

I think this should force the brightness to be set to YOURVALUE on esp boot (similar to show_all_icons example in documentation).

thank you I will try that later thank you 😊

thank @pplucky you this work top & I have another question after restart my screen is always off on my esphomatrix screen can't find where this setting is on my wall ulanzi isn't this the case?

You mean when you restart/boot the esp32, right?
I only restart mine when I flash it, otherwise I just turn the display off and on with the corresponding service or switch.
Still then, when I restart the esp32, it feels like it doesn't always behave the same way, but it also happens to me some times (not all the time).
What I've seen also - not sure if that's your case, when I'm playing with esphome light effects, if the effect ends up in full black and I don't finish the effect (with effect 'None') or turn off the light, matrix stays all black and doesn't show anything EsphoMaTrix-related (clock or screens).

yes I mean so if you have updated the config via esphome this sava and install wireless then it restarts anyway & then the screen is black I don't understand why?

You can always try:
esphome:
....
on_boot:
priority: -100
# ...
then:
- lambda: !lambda |-
id(rgb8x32)->set_display_on();
But this would only be a workaround anyway.
Not sure if someone else can try to help a bit more on this (for me), non-consistent behavior..

thank you very much for helping me this work only at perfect !


feat: use QR code scan in the Send Wizard Modal

Motivation
The QRCodeScan component will be used as an additional step inside the Send Wizard Modal. It is better in this way, since we could keep the transitions between Wizard steps and the links between one step and the other.
export const sendWizardSteps = (i18n: I18n): WizardSteps => [
  {
    name: WizardStepsSend.SEND,
    title: i18n.send.text.send
  },
  {
    // New additional step for QR code scanning
    name: WizardStepsSend.QR_CODE_SCAN,
    title: i18n.send.text.scan_qr
  },
  {
    name: WizardStepsSend.REVIEW,
    title: i18n.send.text.review
  },
  {
    name: WizardStepsSend.SENDING,
    title: i18n.send.text.sending
  }
];

Since the Wizard processes the flows in an ordered way, step-by-step, we created custom function to link the SEND step to the REVIEW step, and skip the QR_CODE_SCAN step.
Changes

Included an additional step among the Wizard steps.
Since the Wizard processes the flow in an ordered way, step-by-step, we created custom function to link the SEND step to the REVIEW step, and skip the QR_CODE_SCAN step.

Tests

Outdated


Iframe issue on Safari in private mode

The Google Sign-In client does not work in Safari private mode.
How to reproduce

Open a private tab in Safari.
Visit a page which uses the google sign-in client to authenticate to a service.
A pop-up for authentication will open. Confirm all the steps there.
Once the pop-up closes, nothing happens and the follow up request to https://accounts.google.com/o/oauth2/iframerpc?action=issueToken&response_type=token... isn't made.
You might see the error Unhandled promise rejection – {error: "popup_closed_by_user"} in the console.

In non-private Safari and in other browsers, the issue isn't reproducible.
Investigation
After further investigation, it seems this is probably a bug in Safari sandboxed iframe not supporting "allow-same-origin".
From this debug screenshot https://cloudup.com/cwLvDPd6urp we can see that the source property on the MessageEvent is null and it should not be. A simple fix would be to check event.origin instead in the case where event.source is null.
Issue is tracked here on wp-calypso

Hi @Tug, I just tried on Safari Private Mode on my Mac OS X and it worked fine. Are you testing this on a iOS device? What version of Safari do you have? (and iOS if it applies)

Thank you @TMSCH.
So I was able to reproduce on macOS Sierra with Safari 10.1 (126<IP_ADDRESS>.34) as well as on iOS 10.3.1, sorry for not mentioning that in the issue description.
Did you try the steps I described on the issue of our repository? We have a runnable version at https://calypso.live/start/social?branch=try/google-platform-js and the code for this component is here

@Tug thanks for the further information. I am indeed able to reproduce the issue on your app. It is not obvious to me what's happening, I will investigate and get back to you.

@TMSCH did you find anything?

I am not able to reproduce this behavior anymore... I reproduced the steps in @Tug's first comment using https://developers.google.com/identity/sign-in/web/sign-in#add_a_google_sign-in_button and it works fine. I am using Safari 10.1.2 Private Mode on macOS.
@scruffian would you have more details on your setup?

Also have a problem here with Safari Private Mode Version 10.1.2 (12603.3.8)
The popup shows up fine at first, but after signing in, I get the popup_closed_by_user error. Pressing the button again shows the popup again but it immediately closes and returns popup_closed_by_user error.
Here's my sample code, I'm using a custom React UI for the button.
// googleAuth is the instance received from gapi.auth2.init
return this.googleAuth.signIn({
  scope: 'profile email',
}).then(user => {
  // do stuff
}, err => {
  if (err.error === 'popup_closed_by_user') {
    // always enters this block with error code popup_closed_by_user
  }
})

Same problem here with a custom sign in button in macOS Safari 11.0 with private browsing enabled.  After completing the form it closes with error: "popup_closed_by_user".

Thanks @dan-kwiat and @hendryl for reporting the issue. We are investigating but are having troubles reproducing the issue. I will keep you updated.

I can still reproduce it with https://wordpress.com/log-in

Original code here.

Thanks @yurynix for the report.
We think we have identified the root cause of this issue in Safari 11, which is slightly different from the original report by @Tug, and I suspect that the original report still applies to the versions of Safari mentioned.
In Safari 11, they changed the behavior of their webstorage in Private mode, which breaks some internal mechanism of GSI.
We are investigating a solution to the issue.

@Tug @scruffian @hendryl @dan-kwiat @yurynix it just occurred to me that there actually is a work around... If you are ok with a redirect-based flow instead of a popup flow, the library will work in Safari Private Mode regardless of the version. I just tried and it works.
You can set ux_mode: 'redirect' in the gapi.auth2.init call (or signIn) and it will redirect to the Google Sign-In flow, then redirect back to the app and sign in the user.
Let me know if that's an option! In the meantime, we're still working on a solution for the popup-based flow.

@Tug We released the fix for Safari Private Mode. Let me know if you observe any issue!
Safari 11 issue is tracked in #342

I am facing issue with oAuth2.0 login flow only in safari (mac + ios). The popup for login opens, after entering credentials the url of popup modal changes after successful login but the modal does not close hence the redirection doesn't happen and so the use can not enter the application.
Note: This not only for private mode browser but for normal also.
Need support on priority. This is working on all browsers of all the platforms.


All fields in json

I think it's pretty to have all fields of a resource (from the schema) and display it in swagger-ui (so in json). Like this, for post command we can have information. (refer to eve-docs display style ;) )

Yes that's something I'd like to add too. Feel free to PR for it if you (or anybody else) are willing to!

I have a working prototype. Setting 0.0.5 as candiate for this feature.

cool ;)

I pushed the fields branch so people can play with it as I work on it.

I have an error:
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "build/bdist.freebsd-10.3-RELEASE-amd64/egg/eve_swagger/swagger.py", line 38, in index
    node(root, 'definitions', definitions())
  File "build/bdist.freebsd-10.3-RELEASE-amd64/egg/eve_swagger/definitions.py", line 18, in definitions
    definitions[title] = _object(rd['schema'])
  File "build/bdist.freebsd-10.3-RELEASE-amd64/egg/eve_swagger/definitions.py", line 30, in _object
    props[field] = _type_and_format(rules)
  File "build/bdist.freebsd-10.3-RELEASE-amd64/egg/eve_swagger/definitions.py", line 60, in _type_and_format
    resp['items'] = _object(rules['schema'])
  File "build/bdist.freebsd-10.3-RELEASE-amd64/egg/eve_swagger/definitions.py", line 27, in _object
    if rules.get('required') is True:
AttributeError: 'str' object has no attribute 'get'

hmm can you please post an example of your schema? Or email it to me.

You can find my schema here: https://github.com/Alignak-monitoring-contrib/alignak-backend/tree/develop/alignak_backend/models

Thanks. Should be fine now.

Yes works better ;)
Do you think we can have for each field an input instead a big textarea with json structure?
Perhaps I can try do this in the week


feat: Vault PoC

What?
Proof of concept for using Vault in a Mava system.
Why?
Allows us to store data to be used in, e.g., OG-MARL.
How?
Vault functionality from flashbax—currently sitting on a branch.
Extra
n/a

Thanks @OmaymaMahjoub! Tried to add some more info to the READMEs. Let me know if anything else should be added 🙏🏻


FR: do not filter command results

Command result usually comes without real position, we construct it from last one. It is very likely it will be filtered by duplicate or distance.
What do you think about adding new switch to exclude from filtering positions with command results? Like we do for alarms #3484

How about more generic solution? For example, do not filter position if it has an attribute from a specified list.

Nice idea, what can be more flexible.
May be implement in the way how we do it in CopyAttributes https://github.com/tananaev/traccar/blob/master/src/org/traccar/processing/CopyAttributesHandler.java#L35 also with lookup device->group->config?
Frankly, I know what can be more flexible... it is JEXL expression instead of keys list, but it is overcomplicated... or?

Yes, I think JEXL would be overkill, but the way copy attributes is implemented is fine IMHO.


depth_synchronizer.py Issue

To whom it may concern,
Good afternoon! My name is Paula, and I am a college student working with Professor Zhi Tan on setting up SEAN on my machine (Windows 11, using Ubuntu 20.04.6 LTS to run tmuxinator). I was able to get the simulation to work on Unity, but I ran into rviz errors and tmuxinator errors.

When I ran the simulation and navigated to rviz, in the displays tab when I opened the Image dropdown, the Image section says No Image received
When launching the depthtoscan launch file, the depth_synchronizer.py file did not process successfully (error on line 75 ( img[:,:,3] = np.bitwise_and(img[:,:,3], np.full((img.shape[0],img.shape[1]), 0x01111111, np.uint8))) and the error is that "NoneType object is not subscriptable". Professor Tan and I deduced that the issue is line 74 (img = cv2.imdecode(arr, cv2.IMREAD_UNCHANGED)), because the data stored into img after this line of code is run is None, hence why the NoneType object is not subscriptable
We noticed that on line 73 (where arr is initialized ( arr = np.frombuffer(compressed_image.data, np.uint8))) the value of arr is a bunch of arrays that store the singular value 205
([205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
[205 205 205 ... 205 205 205]
etc).

We were wondering if we could have someone look into these issues so we can continue the process of getting the simulator, rviz, and tmuxinator working properly on my machine.
Thank you so much!

Hi @psefia, please email me and we can set up a time to debug or try out the new version. I invited you to the new repos (there are 3) and I am happy to help you set this up and make sure it's working.


Copy - Job poster builder skills page

Description
There is still "Lorem ipsum" under each of the three types of skills.
Changes
These instances can be removed (unless @nicolsonaitken disagrees) @yonikid15

English
French

Content
Content

[ ] Copy provided in English and French.

Rosita already made an issue for this :)


feat: add strip_v_tag_prefix option

I've ported the strip_v_tag_prefix option from provider-gitlab (https://github.com/go-semantic-release/provider-gitlab/pull/5) to provider-github because I'm missing this feature in the GitHub provider.
Having the v prefix prevents me from using tools like FluxCD.
v1.2.3 isn't valid semver anymore: https://semver.org/#is-v123-a-semantic-version

Hey @zenire, thank you so much! ☺


looking for libcudart.so.10 when  libcudart.so.11 installed

using anacoda
setting enviroment,
installing pip
using pip to install tensorflow
testrun
python
import tensorflow as tf
gives error
2020-08-08 23:41:49.327601: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2020-08-08 23:41:49.327623: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
so I dutifully went to nvidia and installed cuda.
Trying again give same error.
using updatedb and locate I found
the following instances.
/usr/local/cuda-11.0/doc/man/man7/libcudart.so.7
/usr/local/cuda-11.0/targets/x86_64-linux/lib/libcudart.so
/usr/local/cuda-11.0/targets/x86_64-linux/lib/libcudart.so.11.0
/usr/local/cuda-11.0/targets/x86_64-linux/lib/libcudart.so.11.0.221
so it looks like Nvidia has a newer version out then whats been looked at.
I'm not sure who's error this is, if it's not yours please redirect me to whomever it is. thanks
System information
linux mint 20,

@iplayfast,
CUDA 11 compatibility with TensorFlow is currently a work in progress.
Please try installing TensorFlow with CUDA 10.1 and cuDNN 7.6 as per the tested build configurations and let us know if you are facing the same issue. Thanks!

@iplayfast
tensorflow-nightly-gpu was released yesterday!
CUDA-11 support is here!

@iplayfast,
Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

I follow this guide and it helped to build from source: https://towardsdatascience.com/how-to-compile-tensorflow-2-3-with-cuda-11-1-8cbecffcb8d3
Edit third_party/gpus/cudas_configure.bzl
Replace with "11.0" string
    "cudart",
    cpu_value,
    cuda_config.config["cuda_library_dir"],
    # Comment this out since cudart is still on 11.0 instead of
    # the same as cuda 11.1
    # cuda_config.cuda_version,
    "11.0"
    static = False,
),
"cudart_static": _check_cuda_lib_params(
    "cudart_static",
    cpu_value,
    cuda_config.config["cuda_library_dir"],
    # Comment this out since cudart is still on 11.0 instead of
    # the same as cuda 11.1
    # cuda_config.cuda_version,
    "11.0"
    static = True,
),```


makeStyles with a function css rule entry doesn't work on react 18 using react-dom/client createRoot

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
On react 18, when rendering using ReactDomClient.createRoot().render(...), using function css rule definitions doesn't work correctly — styles are missing from the runtime, despite the classes being applied to the elements.
Still on react 18, rendering via ReactDom.render does work.
const useStyles = makeStyles(() =>
  createStyles({
    // Function style rule: Doesn't work
    fnStyleClass: () => {
      return {
        color: "red",
        background: "black"
      };
    },
    // Plain object: Works
    objStyleClass: {
      color: "red",
      background: "black"
    }
  })
);

This is particularly problematic because this is the new default of create react app.
Expected behavior 🤔
Function style rules work and apply just like plain objects independently of the react render method used.
Steps to reproduce 🕹
Steps:

Create a new react app with the lates CRA (e.g. yarn create react-app make-styles-test)
Use makeStyles and define a rule using a function callback instead of a plain object
See styles aren't applied during runtime

Live example @ https://codesandbox.io/s/mui-makestyles-functions-issue-jhjfq5
The example renders two Typography components; each with a class produced by a makeStyles({})(). One of the Typography elements takes a class for a style rule body returned by a function and the other from a plain object. The style rules are identical, the only difference is the plain object vs function definitions. When rendered via createRoot.render, you can see one of the Typography elements doesn't have the styling that the class defines (black background, red font color).
Notice at the bottom of the index.tsx file the two ways of rendering (ReactDom.render vs ReactDomClient.createRoot.render). One works and the other one doesn't. You may comment/uncomment the two ways to see the different results.
Context 🔦
We have an npm package with components based on mui. Despite our package being on mui@^5, a number of our components haven't fully migrated out of the @mui/styles into the new style system. CRA latest uses createRoot().render() by default and, when creating a CRA app and using our package, a lot of our styles are simply missing.
The issue is not specific to our package (see clean codesandbox example).
Your environment 🌎
Chrome & Safari. Probably all.
  System:
    OS: macOS 12.4
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 8.1.4 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 101.0.4951.64
    Edge: Not Found
    Firefox: 99.0
    Safari: 15.5
  npmPackages:
    @emotion/react: ^11.5.0 => 11.9.0
    @emotion/styled: ^11.3.0 => 11.8.1
    @mui/base:  5.0.0-alpha.82
    @mui/icons-material: ^5.3.0 => 5.3.0
    @mui/lab: ^5.0.0-alpha.65 => 5.0.0-alpha.83
    @mui/material: ^5.3.0 => 5.8.1
    @mui/private-theming:  5.8.0
    @mui/styled-engine:  5.8.0
    @mui/styles: ^5.3.0 => 5.8.0
    @mui/system:  5.8.1
    @mui/types:  7.1.3
    @mui/utils:  5.8.0
    @mui/x-data-grid:  5.11.1
    @mui/x-date-pickers:  5.0.0-alpha.1
    @types/react: ^18.0.0 => 18.0.9
    react: ^18.1.0 => 18.1.0
    react-dom: ^18.1.0 => 18.1.0
    typescript: ^4.4.2 => 4.6.4

Hi @rart,
The implementation of makeStyles you are using is deprecated.
I suggest you upgrade to tss-react.
On your sandbox it would be: https://codesandbox.io/s/mui-issue-with-makestyles-functions-forked-oftpd9?file=/src/Demo.tsx
Latest MUI version includes a codemod for automatic migration from JSS to TSS. https://mui.com/material-ui/guides/migration-v4/#2-use-tss-react
Best regards

Thanks for the update, @garronej
Back when we did the migration to mui v5 (very early on), tss-react wasn't an option or part of the upgrade guide. I guess it's also just slightly misleading to keep seeing version updates on @mui/styles.
I did just try the codemod and it doesn't work over a previously updated codebase. Because we had already upgraded to MUI v5, our makeStyles import statements are from @mui/styles/makeStyles and not from @material-ui/styles/makeStyles like the codemod expects. It also doesn't seem to remove the createStyles call and I get some additional compilation errors that I need to inspect further to understand.
Is there a post v5 upgrade codemod that would work on already updated codebases? Or that helps with the other issues too?
Also, being @mui/styles deprecated I assume it means this ticket won't get fixed?

It also doesn't seem to remove the createStyles call and I get some additional compilation errors that I need to inspect further to understand.

I didn't write the codemod but there is at least one test case that does remove createStyle.
https://github.com/mui/material-ui/pull/31802/files#diff-b13e5553c5f57f8e729ca91e76b03e68e84e04bb15d2723ea928a735c0b826bb

@mui/styles/makeStyles and not from @material-ui/styles/makeStyles like the codemod expects

If it's only that you could try a search/replace and run the codemod again.
Anyway, the migration is quite easy to perform by hand on a typescript codebase, assuming it isn't huge.

Also, being @mui/styles deprecated I assume it means this ticket won't get fixed?

I woudn't count to much on it. Ref.
Good luck!

thanks for the feedback!

@rart FYI - @joshkel did enhance the codemod to support replacing @mui/styles/makeStyles (#32962).
I wrote the initial version of the jss-to-tss-react codemod. If there are some patterns that were common in your code that it didn't cover, please share some code examples. I'll be able to tell fairly quickly whether or not it's a pattern that I could easily enhance the codemod to cover.

@ryancogswell,

@rart FYI - @joshkel did enhance the codemod to support replacing @mui/styles/makeStyles (#32962).

We already migrated, but that's a great addition 👏

I wrote the initial version of the jss-to-tss-react codemod. If there are some patterns that were common in your code that it didn't cover, please share some code examples. I'll be able to tell fairly quickly whether or not it's a pattern that I could easily enhance the codemod to cover.

Because the migration was done some weeks ago, I've now forgotten some of the struggles or some details. But here's what I remember:

We were on mui/styles instead of @material-ui/styles (already covered, as you mentioned)

import createStyles from '@mui/styles/createStyles';
import makeStyles from '@mui/styles/makeStyles';

We had this pattern in many places:

const useStyles = makeStyles((theme) =>
   createStyles<ViewToolbarClassKey, ViewToolbarStyles>({
     appBar: (styles) => ({
       borderBottom: `1px solid ${theme.palette.divider}`
       ...styles.appBar
     }),

Notice how the rule is a function that receives an arg that's not destructured. The codemod only worked if the argument was destructured. We had to covert the above to the below before running the codemod:
const useStyles = makeStyles((theme) =>
   createStyles<ViewToolbarClassKey, ViewToolbarStyles>({
     appBar: ({ appBar }) => ({
       borderBottom: `1px solid ${theme.palette.divider}`
       ...appBar
     }),

Other things I remember vaguely is that there were some additional strange things post codemod. For example,

The useStyles in some cases was modified to be invoked with two arguments (i.e. the props as the second argument instead of as the first).
The types used in createStyles<ViewToolbarClassKey, ViewToolbarStyles>({ were not fully migrated to the modified code.


Console.log(mapnik.Feature) does not show functions or attributes

But they do show up in the node.js repl if you tab complete - need to figure out how to get them showing up in console.log.

/cc @brandonreavis - you ever considered this issue or know of workarounds? Basically the idea is I want to console.log a C++ prototype and get all the methods you could call showing up in the output. Or just someway to see the methods without need to resort to 1) tab-complete in the repl, or 2) looking at docs or code.
Obvious good docs is the best solution, but this would still be nice to figure out.


control-service: only delete file in test path

Why
In my previous PR I merged code which deletes an empty keytab file, so that we keep only the filename.
This is the desired behaviour for the test kdc server as it expects no file to be at the file location.
However the production path expects there to be an empty file there.
What
Push the delete logic into the test impl so that we aren't modifying the production code path.
How has this been tested
entire deployment pipeline
Open questions
Should more of the pipeline run on branches as it would have caught this issue?
Signed-off-by: murphp15<EMAIL_ADDRESS>

How did you catch the regression ? Did vdk-heartbeat post deployment test fail? It seems so. That's good. That's the purpose of the test to catch issues in real deployment. Or was some other way ?

The integration test is now failing btw.

How did you catch the regression ? Did vdk-heartbeat post deployment test fail? It seems so. That's good. That's the purpose of the test to catch issues in real deployment. Or was some other way ?

Yeah was caught by the heartbeart test


Search Options tooltip text

Suggest text:
-- begin
This menu provides a way to refine your search results. For example, filter the results by database or order by pathway size.
-- end
I am assuming this is applied after a query is submitted (right?). Are we providing a reorder by size option?

I am thinking about leaving out the reorder by size because I don't really see how its helpful.
So for filtering results by database, it will run the search query again with the filter in order to fetch new results. If I was to implement reorder by size, it will be applied to either the existing list or to any list generated in the future.

If size filtering is handled wisely,  I could be convinced to punt order by size.
Will this handle the edge case where I set filters before submit? Will the menu reflect this state?

Again, with the beta, since we can filter by number of items, thinking of pushing pathways with around < 4 and > 200 nodes to the bottom.
Yes I haven't written anything for this yet, but if you set filters before submitting, it will do a search, say no results found, and then if you press search button everything will proceed as normal. You can try the datasource filtering on the github prototype.

let's make sure we filter out massive pathways (e.g. >500)?

Closing and reopen the latter issue.


Add Bluemix metadata files

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   94.84%   94.84%
=======================================
  Files           2        2
  Lines         194      194
=======================================
  Hits          184      184
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed91e08...9fb7bc1. Read the comment docs.


Implement support-notifications GET V2 API tests

Fix #452
Signed-off-by: Ginny Guan<EMAIL_ADDRESS>

Failed testcase (ErrNotificationGET018)  is caused by https://github.com/edgexfoundry/edgex-go/issues/3545


query params are being escaped but not url encoded which makes query useless

See these lines:
https://github.com/ronaldschlenker/FsHttp/blob/72f78fd476ddbc1559857be2ef1ef83bc28a7b00/src/FsHttp/Helper.fs#L30-L31
You are escaping the values, but not encoding them. Above there is a function called urlEncode which is not being used.
https://github.com/ronaldschlenker/FsHttp/blob/72f78fd476ddbc1559857be2ef1ef83bc28a7b00/src/FsHttp/Helper.fs#L9
I am trying with fields[member]. If passed as is, the API complains that I need to encode [ and ], but when I do HttpUtility.UrlEncode "fields[member]" I get an error saying "Unknown parameter". If I add the query param in the GET url with HttpUtility.UrlEncode "fields[member] then it works.
I'll send a PR if that is ok with you.

The HttpUtilities should be private, anyway. But I don't understand what exactly you do. Yould you please post a reproducable code example?

I'll send it this evening.
I've been trying to fix this but then encountered issues with testing my fix.
So basically this is what happens:
An API to which I am sending a GET request wants that all query params are url encoded, meaning that chars like [ and ] need to be encoded.
I encode the param myself, but then when I pass it to the query function it gets escaped and ends up being wrong.

Ok, I'll have a look again, but if you can provide an example later, that would be great.

It seems that you have fixed the issue. Thank you.

Since I already made some minor breaking changes and plan to make some more, will it be ok for you having a 6.0 prerelease?

It is ok for me as long as I can reference it in my notebook (fsi).
If there is a way to reference the master branch I would be okay with that too, but can't find a way to do so.

In F# interactive, it is possible with
#r "nuget: SchlenkR.FsHttp, 6.0.0-preview1"

I guess the same applied for notebooks.
I'll release it this evening.

Awesome, thank you!

https://www.nuget.org/packages/SchlenkR.FsHttp/6.0.0-preview1

I am using 6.0.0-preview1 and it works now.

Thanks for your support!


Weird behaviour when using non-English keyboard layout (likely cause Todoist shortcuts persist)

Hey there!
First, thanks for the great extension. I'm using two keyboard layouts (US English and Russian) on a daily basis and I've noticed that sometimes when I forget that my keyboard is in the Russian layout and press a button while in Todoist (and your extension is not intended to work with non-English layouts, right?), something unexpected happens — so this extension kinda works but strangely...
For example, if I go to my Inbox, select a task and press "d" I complete it. However, if I press "в" on the Russian layout instead (same key) then all Inbox items get "sorted by due date".
Do you know if I could fix it somehow? Either by disabling the non-English keyboard layout or by having it respond the same way as English one?
PS: I just tried disabling your shortcut completely and the "if I press "в" on the Russian layout" thing persists! Seems like the original mapping for "d" shortcut works for the Russian layout while your extension changes behaviour for English one.
Do you know if I can do anything about it? Thanks in advance!

UPD: I actually think disabling the default Todoist shortcuts will help solve this issue. Does anyone know if / how one could turn them off?

Do package users want the extension to turn off Todoist's built-in shortcut commands?  If so, that is something that I'd be happy to try and figure out.  :)

Sure, that'd be awesome Adam!  I have tried before but didn't figure out a
reliable way to do it.
On Sun, Sep 12, 2021 at 11:02 PM Adam Rich @.***> wrote:

Do package users want the extension to turn off Todoist's built-in
shortcut commands? If so, that is something that I'd be happy to try and
figure out. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/180#issuecomment-917842532,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAFQKWMVVAOTEZIQCD2DG3UBWAXBANCNFSM5BJKZRKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It's possible this might be fixed with the latest extension version (134 or 135), can you verify?

:thinking: Closing this issue

Hello @mgsloan ! I am not sure why you assigned this issue to me? Hence I removed my assignment.
However, this bug I described still persists for a non-English keyboard layout. Shall the issue be reopened?

Okay, seems like there was a misunderstanding on my side. Following up on @mgsloan reply from 8 days ago about versions 134-135: the unexpected behaviour I described still persists in version 137 (pressing "d" and Russian layout's "в" yields different results).
Sorry for my initial confusion, I am not used to Github's functionality yet.

No worries!  I've re-opened the issue.
I think it would be best to fix this issue upstream, todoist-shortcuts uses a library called mousetrap for its keypress handling - and there are a few issues on the repository I found via this search:

Unsupported keyboard layout · Issue #227 · ccampbell/mousetrap
how to make this work with keyboard layout like Japanese? · Issue #453 · ccampbell/mousetrap
alt+7, alt+8, alt+9 does not work in Chrome & Safari (swedish keyboard layout) · Issue #334 · ccampbell/mousetrap
Not works key tilda ( ` or ~) in cyrillic keybord layout (Firefox 22) · Issue #143 · ccampbell/mousetrap
Problems with keyboard layouts · Issue #191 · ccampbell/mousetrap

Given that that repo has 10K stars no doubt the highest impact thing would be to fix it there.  Unfortunately I am guessing it is probably a tricky problem to fix.


README and Firefox Extension Description Update

Would it be possible to link the extension in the repo's README and link the repo in the extension's description?
https://addons.mozilla.org/en-US/firefox/addon/logseq-quick-capture/

Ok, have done so.

@hkgnp thanks! I think it would be helpful to link to the github repository from the firefox addon page as well so its easier to trust this extension

as far as I can tell, currently there's no backlink to the repo and requires googling to find

I see! Have done so!


Subscriber leak since 2.0.2

Steady increase in number of subscribers (and channels) since 2016-08-19, when version 2.0.2 was released.
Last 30 days:

The number of network connections is stable. So it's likely a socket-redis internal issue.
Last 7 days:

Restarting socket-redis gets rid of those susbcribers:

Version 2.0.2 updated to SockJS 0.3.17:
https://github.com/cargomedia/socket-redis/compare/2.0.1...2.0.2
(@vogdb side note: please use git tag-push to create a new tag, so we have the changelog in the tag)
@cargomedia/devops fyi
@vogdb @tomaszdurka could you investigate?
I guess we're not getting some "close" event, maybe due to the introduced forced timeout?

I highly suspect that this is the cause. We should not destroy but close and keep the listener for close event.
@tomaszdurka or @njam please review

I see!
Would be good to open a separate pull request, because we can't be sure this will fix the issue, plus we should monit it for some time anyway. Could copy the ticket contents into a new ticket?
What's the reason for removeAllListeners('data')? To make sure if data is arriving after calling close() we don't call the handler?
Isn't this handled by sockjs?
    Session.prototype.didMessage = function(payload) {
      if (this.readyState === Transport.OPEN) {
        this.connection.emit('data', payload);
      }
    };

Closing in favor of https://github.com/cargomedia/socket-redis/issues/86


Default to device code login on Codespaces

For users running Codespaces in browsers, interactive login does not work due to the localhost server being launched remotely with no forwarding. See #1006.
This switches the default login on Codespaces to device-code based which circumvents the need for the login redirect. User can still opt-out of decide-code via azd login --use-device-code=false.

Azure Dev CLI Install Instructions
Install scripts
MacOS/Linux

May elevate using sudo on some platforms and configurations

bash:
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/uninstall-azd.sh | bash;
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/install-azd.sh | bash -s -- --base-url https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261 --version '' --verbose

pwsh:
Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/uninstall-azd.ps1' -OutFile uninstall-azd.ps1; ./uninstall-azd.ps1
Invoke-RestMethod 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/install-azd.ps1' -OutFile install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261' -Version '' -Verbose

Windows
PowerShell install
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/uninstall-azd.ps1' > uninstall-azd.ps1; ./uninstall-azd.ps1;"
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/install-azd.ps1' > install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261' -Version '' -Verbose;"

MSI install
powershell -c "irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/azd-windows-amd64.msi' -OutFile azd-windows-amd64.msi; msiexec /i azd-windows-amd64.msi /qn"

Standalone Binary

Linux - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/azd-linux-amd64.tar.gz
MacOS - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/azd-darwin-amd64.zip
Windows - https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/azd-windows-amd64.zip

MSI

https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/1261/azd-windows-amd64.msi

Container
docker run -it azdevcliextacr.azurecr.io/azure-dev:pr-1261


chore: Public inputs in unit tests with proving were incorrectly set

AVM full tests run for this PR: https://github.com/AztecProtocol/aztec-packages/actions/runs/12082576422

Full avm tests is green. Will enable auto-merge.


add current command to install

I'm not sure if the command currently makes sense to use outside of a prepared MZ project because mzoon new  hasn't been implement yet. Also you probably don't want to install mzoon locally to a "random" directory.
I'll leave the PR open for a while if you want - at least until mzoon new [project_name] is implemented.

yeah but i tried to install it with cargo which we can’t do yet and it was confusing, also the demo repo has stuff that most people shouldn’t need (like public) should the template be made simpler?

Yes, demo is a bad project template, I didn't have time to make a better one. It's my next task - I would like to implement mzoon new command that would create a better basic project. However I'll have to find time to think it through and then write it.
Feel free to write down some ideas if/when you have some (on chat or in a new issue, don't kill time by writing PRs).


Allow defining a default format string per-metric

Using d3 formatting string. Default is .3s.
Currently only applies to the Table visualization but could be applied in many places like axis.

Coverage decreased (-0.1%) to 80.973% when pulling ad9a8fa8cc213ac446fbcabf0bdedc7893527bc2 on d3format_by_metric into 18b8e6fa5816982263faaaf6f49a45c6a0fe58b1 on master.

Coverage decreased (-0.02%) to 81.095% when pulling 6407400c1632caeaca36c7396ff1420466a6570a on d3format_by_metric into 18b8e6fa5816982263faaaf6f49a45c6a0fe58b1 on master.

Coverage decreased (-0.2%) to 80.948% when pulling d519ed0e63d5ec092e4c7f335855027963b7e7b4 on d3format_by_metric into 18b8e6fa5816982263faaaf6f49a45c6a0fe58b1 on master.

Coverage decreased (-0.2%) to 80.973% when pulling 556e99af93262155e2d9d767949d6205e04cbe35 on d3format_by_metric into 212284cbd445ee6d8123d419951804b3ec5fd53f on master.


Desktop got completely screwed after using screen layout editor

Title. I have two monitors. After swapping the monitors in the Screen layout editor, no global menu nor dock is shown anymore on the first monitor. Also, for some reason, openbox has the default theme (and default menu) on the second monitor.

update: after aligning the monitors (picture attached) the global menu appeared again. The dock didn't though

Update 2: after rebooting, the dock appeared again, but the monitor layout reversed to the original (wrong) one, and trying to set the right layout broke openbox on the second screen again

hello @JakoDel
The desired behavior is as described in the Macintosh Human Interface Guidelines.
Menu and Icons should be on the main (=primary) screen:

@PreyK has improved multi-monitor behavior, e.g., in https://github.com/helloSystem/Menu/commit/cea947363a3f65e4d4ea2cf6b4d4f29ae53594a3 - maybe he knows what is wrong here?


Resolution metric

Could you give me some context? This is not assigned to any issue. What is this PR about?


Optimize physics bridge bandwidth

[x] don't send updates for sleeping rigid bodies
[x] don't send snapshots from clients with 0 rigid bodies
[ ] use int for rigid body IDs (instead guid)
[ ] try 30 updates per second (instead 60)

Potential:

[ ] use half-float in updates to save additional bandwidth

The first 2 items are implemented in the physics branch


Items vanish when Advanced Connector inserts through different side than the connected one

Issue Description:
Using the Advanced Connector to insert items from a different side than it is connected to is not working properly and can destroy items. It looks like the connector still inserts the item from the connected side and if that item isn't accepted by the target inventory, the item simply vanishes.
What happens:
Items get transfered out of the input inventory but never arrive in the target inventory.
What you expected to happen:
The items get input through the correct side or if they are not accepted they stay in the input inventory.
Steps to reproduce:
My setup can be seen here.

Use a network like in the picture where a chest (west) and a furnace (east) are connected by an Advanced Connector.
Program the controller to insert from the chest (west) and output to the furnace (east).
Put a piece of iron ore into the chest. It doesn't get transfered because inserting from the east is not allowed.
Put a piece of coal into the chest. It gets put into the fuel slot of the furnace. Take it out of the furnace again.
Switch the inserting side for the furnace from east to up.
Put a piece of coal into the chest. It gets transfered but still lands in the fuel slot of the furnace. It should have landed in the smelting slot.
Put a piece of iron ore into the chest. It gets extracted from the chest but never arrives anywhere in the furnace or the world.

Affected Versions:

Minecraft: 1.11.2
Forge: <IP_ADDRESS>2
Mods:
compatlayer-1.11.2-0.2.2
jei_1.11.2-<IP_ADDRESS>
mcjtylib-1.1x-2.3.9
rftools-1.1x-5.86
xnet-0.1.1beta

Your most recent log file where the issue was present:
https://paste.ee/p/QAQuQ

I will check it out. Thanks for the detailed bug report

Fixed next release


Cards broken in 0.97.2

I don't what is wrong or how to fix this but the cards are broken in version 0.97.2
Here is the working version (using 0.97.1)
http://countdown.teamfreewill.net/wp-content/app-episode-list.php
and here is the broken one (0.97.2)
http://countdown.teamfreewill.net/wp-content/ep-schedule.php

They were messed up for me as well. Had to tweak how the rows were setup for them to show up properly.

how did you fix it?

This is because we removed the default overflow: hidden on cards. You can fix this manually right now by adding overflow: hidden onto your cards.
I also fixed this in 19965b3