Listing Creation: Prevent Accidental Form Unload

We need to warn users before they lose their listing creation progress by accidentally unloading the multi-step/component form. For example, a user might think that the back button will take her from step 3 to step 2. But because everything is maintained in component state on a single route, she will return to the previous route and everything will be lost.

[x] Back button
[x] Clicking a router link

Related: https://github.com/OriginProtocol/origin-dapp/issues/415

@micahalcorn can you assign this to me?

Resolved by #515 ✅


Develop

Merge into master for v0.1.3

There are a few other FE array functions that are useful, e.g., append, count, get, delete.  Should we add all those?  I used array.count() in one of my sample app, but there is no way to build my app without an accessible git repo for these functions. Flogo uses dep, which requires a git repo for all dependent go packages ;-(

Yeah, let's add them in the next release.


Errors bugfix

Updating sv_module and sv_port implementations
Minimizing the use of clone()
Minimizing the use of return
Bugfixing for potentially unsafe use of unwrap()

Nice work man :)


Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind docs

/kind documentation

cc @QuanZhang-William I have been aware that we are extracting some git-init related images for catalog. PTAL if there are anything to be added or this could be useful at all?

I'm not sure we need docs specifically for removing images. For example, instructions on release notes are already covered by our process docs, and the integration test instructions are more relevant for pipelineresources than for removing images. We also don't really have a good way of knowing what catalog Tasks use these images. It might be more helpful to add a readme to the cmd/ folder explaining what each of the images are used for.

Remove the dependencies from publish.yaml

(This bit is important though - we should note that somewhere)

cc @QuanZhang-William I have been aware that we are extracting some git-init related images for catalog. PTAL if there are anything to be added or this could be useful at all?

Thanks @JeromeJu  for the heads up. There are 2 separate things:

Remove the images and all the dependencies from pipeline project
Host the image source code in separate repos (extract) if necessary

Seems like the instructions here are for 1). For 2) We can add an example when git-init image is extracted to verified catalog repo.
So /lgtm

Closing old PRs - it seems that were discussions about whether we need the docs at all, if you change your mind about needing the docs, feel free to reopen this PR


ARROW-15770: [CI] Not all python tests are running on CI jobs

Feel free to merge it when the CI is green.


Install via Carthage fails

Attempting to give just a whirl, and doesnt seem to install correctly.
*** Building scheme "Just-iOS" in Just.xcodeproj
** BUILD FAILED **
The following build commands failed:
CompileSwift normal x86_64 /Users/dandrews/AppleAppDev/Carthage/Checkouts/Just/Just/Just.swift
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

Issue seems to be due to an old version of Carthage


Type error on ToastProvider

The error is on the "children" prop, someone already solved this issue and made a pull request.

@kuasha420 When can we expect to see the latest released on NPM?

+1, any change on that?

@kuasha420 Will the fix for this type error be released to NPM soon?

+1

Fixed in latest release.


Fixed issue with rocket being launched after the console re-output

Below is a normal push along with the length of the data that the detectPushCommand gets passed.

Note the length is 352. I've found most of mine are around 300 in length.
Now this next image will show the length of the data when the console is re-writing previous output.

The length of 2000 was about average in my testing. Simply adding a check that the data length is less than 1000 should solve the issue. I made it higher than my average push to account for longer file paths.

Nice! This makes sense to me!


linker/compiler errors are silently consumed and don't appear in stdout or stderr

Description
Some recent work that @neonichu (or @tomerd?) did to silence some output seems to have resulted in linker errors being silently dropped making it difficult to identify build failures.
Expected behavior
Linker errors should be presented to the user.
Actual behavior
No response
Steps to reproduce
swift build a project that has undefined references.
Swift Package Manager version/commit hash
No response
Swift & OS version (output of swift --version ; uname -a)
Windows 11

@al45tair I just happened to run into that same thing on Windows!

Seems like we should revert https://github.com/apple/swift-package-manager/pull/7078 -- we'll need a broader change to address the issue with code-signing output.


release: update manifest and helm charts for v1.2.0

Signed-off-by: Anish Ramasekar<EMAIL_ADDRESS>
Reason for Change:

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[ ] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

/azp run pr-e2e-azure


Re-route any force signups to native sign up

This is a screen shot from /auctions in eigen on ipad. It's a force view so when I tap signup instead of poping up our native sign up it goes through the entire force onboarding and drops by back on the force home page (which is confusing)
sign up

onboarding

Completed onboarding, get thrown back to home page

requires a change to force, probably nothing for us to do as I believe the signup and login routes are already supported in our router.

Perfect :+1:

@1aurabrown This was fixed, right?

should be fixed by https://github.com/artsy/force/pull/2608

just merged damon's pr, so i'm closing. the change should existing on staging.


feat(ui): separate ability icons from their charges

Description
This pull request allows for abilities to be assigned a separate icon to that used by its charges. Not all abilities use ability charges. You might also want to have different icons to represent the ability and the charges that it consumes
This is needed to fix an issue where the ability bar was not being displayed for abilities without an associated charge item..
Testing

Start a new game with any of the imperial ships (Imperial Large, Imperial Tiny, etc.).
Verify that the ability bar is present and that it shows how many charges you have next to it.
Checkout the warp module (groovyw module get warp) and switch it to the ability-icons branch.
Verify that the ability bar is present when playing as the Warp Quasar ship.

Notes

This shouldn't require any changes to existing abilities.

This makes sense and I can get through all the steps but - I not only lack an ability bar, I can't seem to trigger the ability at all, even waiting well over 10 minutes. I even dropped its cooldown down to 6 seconds and started fresh but nope. Nothing obvious in the logs. I honestly didn't even realize it had an ability!
Double checked that I had the changes locally both in engine and warp. Checked logs both times and nothing out of the ordinary appeared. Puzzling!
Imperial ships show the bar both before and after the change, and the ability itself works fine. With warp I just don't have a bar at all with the Quasar:

Does the research button show-up when playing as the Warp Scout ship? It's possible that the warp module wasn't compiled, so none of the code has actually been loaded. Make sure that you're using the ability-icons branch of the warp module.
Re-building the warp module in IntelliJ or gradlew :modules:warp:jar might help.
The Warp Endeavour ship has a significantly smaller ability cooldown, so it might be easier to test with. Here's what it should look like, anyway.

That was it. Been so long :-) For Terasology I think we have some obscure Gradle piece figuring out dynamically which extra modules to build to run the game, but I guess gradlew run doesn't quite do that for DS (and I'm not really sure if that works in all cases or at all for TS anymore even)
Also, lol at 6 sec cooldown on that ability 😁


[M] A&R -> Separate each variance into individual cells

Description:
The variance report currently exports each variance into one cell. See snippet below.
In order to make this more useable and easier to interpret, each variance should be in its own column (red and blue circles). To make this readable, Nicole has to manipulate the data to separate the data in the cell, which takes time, and for other users may not be possible depending on their excel skills. "i have no idea the best way to make that possible, whether it is easier for each variance to be on its own line, or if it should be in separate columns."

Acceptance Criteria:
[Note: Use 'Given/When/Then' format if it makes sense to. Otherwise, a simple checklist that can be tested.]
Development Checklist:

[ ] customize the exporting to split out the variance property values into separate cells
[ ] column name would be the type of variance - and the info in the field would be the variance amt
[ ] ...

Dependencies

Blocked by
Blocking

Relevant documentation as reference
Definition of Ready

[ ] Acceptance criteria are included
[ ] Wireframes are included (if applicable)
[ ] Design / Solution is accepted by Product Owner (if applicable)
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done

In progress:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] UI meets accessibility requirements
[ ] Unit tests are written
[ ] Work is traceable in GitHub
[ ] PR linked to ticket number
[ ] If needed/required - Dev adds flag/label to highlight any migration steps necessary prior to PROD deployment

Code review:

[ ] Code is peer reviewed and has passed CI/CD tests

QA:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Code is potentially shippable to the production environment
[ ] Functional features have been tested and passed by QA
[ ] UI components tested by designer
[ ] Code is deployed to PROD when moved to 'done' column (unless requested otherwise by PO)

PO Review:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Reviewed and approved by Product Owner

Notes:

Hi @davidclaveau & @Christopher-walsh22 , I am a bit blocked testing ticket due to issues exporting the report on TEST. When I select the option to export, the job is stuck in "Initializing job." status.

Thank you @davidclaveau , but I have added data to the August for TEST park and one other park.

Tested on TEST: passed

Verified that the variance values are now displayed in separate columns.
Passing to PO review.

Looks good, moving to done.


[WIP] [V2V] Add CPU and network throttling in model

Now that we introduced default values for CPU and network limits in the settings and that the throttling mechanism is backported into the model, it is time to add the model code to leverage the CPU and network limits at the conversion host level.
This pull request adds:

New methods in the ConversionHost class to compute the CPU and network limits. It divides the limit per host by the number of active migration tasks.
New method in the ConversionHost class to apply the limits for a specific task. It creates a throttling file on the conversion host. The path of the file is provided by virt-v2v-wrapper and stored in the task.
New method in the ServiceTemplateTransformationPlanTask to apply the limits. It collects all the limits in a hash and asks the conversion host to write them in the throttling file.
Extend the InfraConversionJob class to ask the task to apply the limits. This allows to revisit the limits on every poll.

Currently all limits are at the conversion host level, so it looks like the apply_virtv2v_limits method should belong to the ConversionHost class, but later we may have limits on different scopes. This allows better flexibility to concentrate the hash build in the task.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1690851
Depends On: https://github.com/ManageIQ/manageiq-gems-pending/pull/426

@miq-bot add_label transformation, enhancement, hammer/yes, wip
@miq-bot add_reviewer @jameswnl
@miq-bot add_reviewer @djberg96

hey guys what is the status of this?  I don't see any updates for a couple of weeks and it is still WIP

@fdupont-redhat @djberg96 @jameswnl any updates on this one? We're holding off on merging https://github.com/ManageIQ/manageiq-v2v/pull/915 until it's ready

@djberg96 @jameswnl I took time to revisit and rethink this, and I moved the limits calculation into InfraConversionThrottler class, and added a dispatch to update and apply the limits to all jobs. This simplifies the design. I still need to add the specs.

@miq-bot remove-label wip
@djberg96 @agrare could you review, please ?

@miq-bot add-reviewer @agrare

Hammer backport details:
$ git log -1
commit b34ee8b44080745a2441cbc3bf3be890258637d3
Author: Adam Grare<EMAIL_ADDRESS>Date:   Thu Apr 18 14:15:24 2019 -0400

    Merge pull request #18576 from fdupont-redhat/v2v_apply_resource_limits_to_virtv2v

    [V2V] Add CPU and network throttling in model

    (cherry picked from commit ce7c67c404127843801f22471f1d286383a9ef17)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702085

Reverted Hammer backport
commit 9d0322d76c646d4f3a15fc36b10caa6972b013b7
Author: Satoe Imaishi<EMAIL_ADDRESS>Date:   Tue May 7 18:26:33 2019 -0400

    Revert "Merge pull request #18576 from fdupont-redhat/v2v_apply_resource_limits_to_virtv2v"

    This reverts commit b34ee8b44080745a2441cbc3bf3be890258637d3.


⚠ Samsung has degraded performance

In f96473c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2538 ms

Resolved: Samsung performance has improved in c2c1625.


add projectsrc to env

What does this PR do?:
Updating  ENV list for all special/reserved ENVs
Which issue(s) this PR fixes:

fixes: https://github.com/devfile/api/issues/1601
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

[x] Unit/Functional tests

[ ] QE Integration test

[ ] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

[ ] Client Impact

[ ] Gosec scans

How to test changes / Special notes to the reviewer:

shoudld i remove addSyncFolder module ? as the EnvProjectsSrc repeated two times

i was thinking maybe rather than using addSyncFolder why wont just merge that module with addSyncRootFolder  ?
does the same work ?

fyi @thepetk if you see my review and want to try the changes yourself

fyi @thepetk if you see my review and want to try the changes yourself

@Jdubrick yes +1 is aligned with my comment here

/ok-to-test

@Horiodino I believe the tests Go tests are failing because the order of the env vars in the tests is 1: PROJECT_ROOT and 2: PROJECT_SOURCE but since we are prepending and PROJECT_SOURCE is added last it is now coming first. We will need to adjust these tests.


Contours?

It would be nice to be able to represent a 2D array with both line contours (like the matplotlib contour function) and filled contours (like the matplotlib contourf function).
As far as I can tell, currently the only option is HeatMap.

Good timing! I just worked on https://github.com/glue-viz/bqplot-image-gl/pull/10 for contours (not filled)
It would be great if you can provide some feedback/testing on this (it should work with bqplot master).
We're doing this externally to iterate faster, I hope it will go into bqplot in the future when stable/solid.

Great, i'll give it a go.
Thanks!

Any progress on this? :+1:

See https://github.com/glue-viz/bqplot-image-gl it's implemented there. There is an example notebook showing the usage.

ok thanks! :+1:


Version number in yum/dnf install

Ansible is attaching a version number to the package name when attempting to install rke2-server/agent/common, but the packages are not named that way in our repo. Is there a way to turn off adding that version number so it just tries to install the package name (i.e. rke2-server)?

Hi @randallweytens - I know someone from the team reached out to you offline. Were they able to address your concerns?

Adam, I have a meeting with Phil on Monday, hopefully we can figure it out then. If there was a way to tag an RPM in the yum repo this would work, but the way this script works doesn’t seem to be congruent with the way a YUM/DNF repo or Satellite server works.On Jun 28, 2024, at 07:17, Adam Leiner @.***> wrote:
Hi @randallweytens - I know someone from the team reached out to you offline. Were they able to address your concerns?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[ ] I understand that this is not the place to request a token listing.
[ ] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

CRT      token    was   exist at your list  But  now it is not . Why ?

Sorry, your issue will be closed as you did not submit your information in the correct format.


AnonymousId not consistent across Cart/Checkout events

I've been testing the new Shopify<>Rudderstack integration. One blocking issue I am having is that anonymousId only remains consistent when browsing home/category/product pages on the site. As soon as a user updates cart or starts checkout flow, a new anonymousId is assigned every event and you lose the ability to track a user all the way through checkout.

Hi - I have been considering setting up Rudderstack and wondering if there are any updates on this issue? This seems like a pretty large/blocking issue.

Hi @arjunbanker @aduch thanks for posting this issue we are checking this internally, will share an update soon. :)

Hello @aduch @arjunbanker we have pushed a fix for this issue via the following PR in our source transformation
https://github.com/rudderlabs/rudder-transformer/pull/1331
For now closing this issue, please feel free to share any further feedback so that we can continue on improving the connector

Hi there, has this fix been pushed to the active Shopify application? Because in our logging we are still noticing that Server-initiated events do not have matching sessionIDs to client session IDs - this blocks the ability to do things like run a/b tests that measure impact on client and server- generated events.


NIFI-2544: Created integration tests for clustering and addressed a f…

…ew minor bugs that were found in doing so

This PR appears to have fixed an issue I was seeing while testing PR 829. Full build passed with contrib-check, ran the IT test which passed, and setup a three node cluster with no issues, so I'm a +1.


Epic: Search v2

Description of the new feature/enhancement
[Original Issue: #605] [Original Spec: #3299] [Initial PR: #3590]
Terminal text search has already realizes single tab case sensitive/insensitive forward/backward search. In phase 2, we are considering these new features:

[ ] Add "Find" button in dropdown menu to trigger search. Now the search dialog is launched by key bindings, we may need to consider binding the dialog to a button in dropdown menu for mouse only operations.
[ ] Search from all tabs. In phase one search are limited within one Terminal window. However, the community also requests search from all tabs. This may require a big change to the search algorithm.
[ ] Regular expression match. This is a useful search pattern and is implemented in some editors.
[ ] Search history. Sometimes users would do the same search for several times, thus, storing the search history is useful.
[ ] High-light while you type. Emphasizing all the matches in the buffer with an outline or selection with another color. This provides a clearer view of the searched text.

[ ] #7561 Feature Request: Highlight all finding

[ ] Add size handle. Some text editors let the user resize the search box, and there is a size handle on the left side of the search box. This helps user when they search for long text.
[ ] #5314 Fuzzy Search
[ ] #6319 No results notification (or reveal number of results)
[x] #7695 next/previous search key bindings
[x] #8307 Selected text should populate search box
[ ] #8274 Add capability to insert matched hit
[ ] #1527 Display "find" matches in the scrollbar, #8631
[x] Pressing next/previous match keybindings should move to the next needle, even if the dialog is closed. (Maybe it should auto display the dialog)

Mentioned in #8522 and #8588

[ ] It'd be cool if there was a shadow underneath the search dialog, like there is for the command palette.

Mentioned in https://github.com/microsoft/terminal/pull/11105#issuecomment-911929402

[ ] More...

Also related, from #5001:

[ ] Add a setting to configure the regex used to detect patterns
[ ] Allow "hyperlink" matching for arbitrary patterns and adding custom handlers #8849

Theoretically, this could supersede #7562
Should be self-consistent with #8294

[ ] Control the styling of hyperlinks - attributes used for autodetected hyperlinks, and then different attributes for hovered ones #8294

Also need highlight all


Feature request: custom host URL

I would like to be able to use tokei.rs on my own Gitea server. Instead of tokei.rs/b1/{github|gitlab}/user/repo it could be tokei.rs/b1/url/user/repo.
EDIT: After browsing the source code, I see that this is kind of already possible, for .com domains. If we just removed the .com, anyone could use the service with any git host.

I could help out with this one if it still needs work @XAMPPRocky

@JHaig343 Hello, sorry I only just saw this. I've just now released a new version that will support any host for the url.

No problem, thanks for the update!

has the new version been pushed to https://tokei.rs/ ? because I'm trying to use this with a gitea instance and the badge says Incorrect URL.

@nektro Yes, can you show the URL you're trying to use?

https://tokei.rs/b1/gitea_instance_host/user/repo

@nektro That repository is not publicly accessible, it needs to be public in order for tokei to read the repository.

ah sorry about that, didn't realize it was public


dApp: Direct transfer fails with "The Requested target doesn't receive transfers"

Steps to Reproduce

Make a direct transfer

Expected Result

A direct transfer happens without invoking the pfs.

Actual Result

Pfs needs to be selected and when continuing a "Requested target doesn't receive transfers" error appears.

Additional Infos (Optional)
Logs:
raiden_0xAdF4209810C442f5772c27F2Fd25Dc56Dcc0615c_2021-06-22T12_49_53.265Z.log.zip

The need for a PFS comes from the fact that the request for a direct transfer fails, so it may be that a mediated one would be possible (if the cause was e.g. lack of capacity in the direct channel).
The Requested target doesn't receive transfers happens because target doesn't have the minimum UDC deposit to pay for request monitoring for that channel, which we raised from 5 to 80 SVT.
This "direct error" of course isn't workaround-able by selecting a mediated route, but we don't differentiate between both cases right now, and just try the mediated one in case the direct one failed. We could optimise this, but since this is a quite edgy case, I wouldn't say it's a priority.
To fix this, simply ensure you've more than 80 SVT deposited in UDC in the target. Please, close if the issue is explained.

To fix this, simply ensure you've more than 80 SVT deposited in UDC in the target.

They had 160 SVT deposited.

To fix this, simply ensure you've more than 80 SVT deposited in UDC in the target.

They had 160 SVT deposited.

Yes. I observed the same. I had deposited thousands of tokens in the contract and reloaded all nodes a couple of times. At some point one of them started to work.
From the code it should be just this simple check Andre mentioned. But something else seem to "block"/"shadow" it.

Ok, it seems the issue is that the PFS isn't updating its view our our capabilities when it changes. Workaround for now is for the node which just deposited to UDC to go offline, stay like that for at least 30s, and then come back online. I'm also preparing a PR to debounce capability updates when deposit is confirming, which may improve this a little, but until PFS doesn't properly update this field, the timing in capability changes will bring us this kind of problems.
https://github.com/raiden-network/light-client/issues/2831

Is it worth to implement such a workaround in the client? Shouldn't we push to fix the PFS?

The fix necessarily needs to go on PFS side, from what I could see, this can't be fixed in our side. But while debugging/reproducing it, I did see some things that can/should be improved on our side which can reduce the number of this kind of events on the server, and I think this should be implemented.

Ok, I got a weird workaround (better known in Brasil as gambiarra) for this, which is: once our capability changes, we can quickly appear offline, then immediately as online again, and this will trigger a PFS presence update. Notice we don't actually need to go offline, we'd still keep syncing as before and no event would be lost, and since PFSs don't have a mechanism to push these presence updates to clients (it's polling only), this would affect only them.
Theoretically there could be a very small time window here in which we'd appear as offline, which could then make incoming (mediated or received) transfers fail if a partner requested our presence right at the few milliseconds PFS thought we were offline, but since capabilities updates at runtime are quite uncommon, and namely the only condition which may change at then is exactly Receive being turned on or off, then appearing offline for this very short timeframe doesn't matter (since you'd already not be able to receive/mediate either before or after such update), and this would optimise for the most common case: user depositing to UDC in order to receive and request monitoring for a transfer, and getting confused by still not being able to.
Do you guys think this is worth it? I already got it implemented and tested, but I'm not sure if such workaround is something we'd like to push for.

Sounds good to me. As you said this is most-likely only happening during runtime if the user deposits to UDC and reaches the critical amount. This means he wasn't able to receive transfers before (by default configuration). So he actually can't receive a transfer where this could cause issues. I think this is totally fine. In my opinion such a distributed network must just be able to handle offline users better anyway. So I would go with it. 👍🏾


Added Web Cache Deception

I've added Web Cache Deception as a vulnerability to the list.

Awesome, the details are good. Keep up the good work. :+1:


add laravel artisan

Can you share some reference about this?

Laravel : https://github.com/laravel/laravel
before Laravel 8 version, framework contains server.php


add failure_callback param

Addresses issue #61
Being able to call a custom function when all retries have failed is useful for a few applications.

Do nothing
Log and re-raise
Return the value of the last function call
Send notification somewhere (email, chat, error tracker, etc)

This approach returns the last Attempt which provides access to the last function return value, or exception details depending on the failure conditions.

also addresses #29


Add nodeSelector OS constraints in all packs

When deploying on clusters with mixed Linux and Windows nodes, it's necessary to put a nodeSelector constraint to ensure that only nodes with the matching OS type get chosen by the scheduler.
The following should be added in the deployment specs for all the Linux deployment templates.
nodeSelector:
  beta.kubernetes.io/os: linux

Similarly Windows packs will need:
beta.kubernetes.io/os: windows

Thanks, Alessio!

Has this been resolved and if so, how do you specify the node selector via the draft pack ?
I built out a Windows pool in my K8s cluster and could'nt deploy my app using draft to the Linux pool.
I have to manually edit the manifest file, before I could get it to work, and this took me several hours to troubleshoot.


Would this work with Amazon MWAA?

Hello - I am sorry if this was already answered, but is there a way to get this to work with Managed Airflow in AWS (Amazon MWAA)?

Hello @mkalamcargurus,
Yes, we used it successfully with MWAA but it still requires Kubernetes to execute containers. You just need to upload k8s config file to MWAA and point it in your pipeline's configuration. Another option would be to use BashOperator instead but it was introduced just for local tests and is neither recommended nor production ready or tested on MWAA.
We also have ecs/fargate support on our roadmap for executing tasks but it is not possible to predict when it will be done.

Yes, its possible to do use that package on MWAA, in current state you need to follow few rules.

dbt-airflow-factory airflow-dbt and dbt-core installed on you MWAA instance, example requirements which I used

dbt-airflow-factory==0.30.0
airflow-dbt==0.4.0
dbt-core==1.0.5
dbt-snowflake==1.0.1
apache-airflow[kubernetes,slack,airbyte]==2.2.2

If you use env variables in you dbt profiles please also include plugins in your MWAA
https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/plugins.html

We used bash operator (but if it's not scalable you can change to fargate or any other)
Firs you need definition of bashoperator

class DbtBashOperatorBuilder(DbtRunOperatorBuilder):

    def create(
        self, name: str, command: str, model: Optional[str] = None, additional_dbt_args: Optional[List[str]] = None
    ) -> BaseOperator:
        args = {
            "task_id": name,
            "dbt_bin": dbt_executable_path,
            "profiles_dir": profile_dir,
            "dir": project_dir,
            "target": target,
        }
        normalized_command = command.lower()

        if normalized_command == "run":
            args["models"] = model
            return DbtRunOperator(**args)
        if normalized_command == "test":
            args["select"] = f"{model},test_type:schema"
            return DbtTestOperator(**args)
        if normalized_command == "seed":
            return DbtSeedOperator(**args)

        raise ValueError(f"Unknown command {command}")

feel free to add any normalized_command which you have to add also you can change the behaviour if you have tags or similar.
Important where to find dbt_executable_path, profile_dir, project_dir

For profile_dir and project_dir I put the same directory /usr/local/airflow/dags/dbt_code/dbt where dags/dbt_code/dbt is location on bucket where you have your dbt code associated with MWAA put in.

dbt_executable_path /usr/local/airflow/dags/dbt_code/dbt it should be sth similar to this.

And now how to define the dag

with dag as:
    dbt_operator_builder = DbtBashOperatorBuilder()
    builder = DbtAirflowTasksBuilder(
            operator_builder=dbt_operator_builder,
            airflow_config=TasksBuildingParameters(),
            gateway_config=TaskGraphConfiguration(
            gateway=GatewayConfiguration(separation_schemas=[], gateway_task_name="gateway")
                ),
            )
    tasks = builder.parse_manifest_into_tasks(manifest_path)
    seed_task = builder.create_seed_task()

    # you can add anything unusual like data tests
    data_tests = dbt_operator_builder.create(
                name=f"dbt_data_tests", command="data_test"
            )

    for starting_task in tasks.get_starting_tasks():
        seed_task >> starting_task.execution_airflow_task

    # if you want you can testing in data_tests to your end tasks

    for ending_task in tasks.get_ending_tasks():
        if ending_task.test_airflow_task is not None:
            ending_task.test_airflow_task >> data_tests
        else:
            ending_task.execution_airflow_task >> data_tests

for manifest_path please use
os.path.join(dbt_project_path, "target/manifest.json")

This is example how you can achieve that and its snippet of code, but I hope you get an idea.

Thank you very much for the prompt response. Any estimates to when ecs/fargate support would be available?


feat(router): Support route groups

I think it would be useful to have route groups like Next.js that can separate layouts without affecting the URL path.
Next.js docs:
https://nextjs.org/docs/app/building-your-application/routing/route-groups

With createPages config router, I think it's possible. Please give it a try.
I'm not sure how we do with fs router, but we probably don't add such complexity. cc: @sandren
(maybe supporting dynamic layout would be a solution.)


Not working Example

Hi there, it seems like your tests to not cover the fact that the DemoData objects returned are all default instances.  I have spent a couple of hours trying to figure out why my setup was not working but I think that I have proved in this PR there is an issue with deserializing the objects.
In summary I have

Added additional properties to the DemoData object for testing.
In Handle I now interrogate the result's properties.

So to see the bug load up the test and "Gimmie Objects!" button.

Thank you!


chore: List public API

Relates to SAP/cloud-sdk-backlog#406.
I made a first list of methods and object which I think are useful for external consumer. I would also like to discuss the general strategy. Currently everything which is needed for compiling is exported. However, this includes methods which are not useful as public methods.
New Idea:

Have a internal folder which exports everything. Useage: @sap-cloud-sdk/odata-common/internal
Have in the root index.ts only the mandatory methods.

I schedule a meeting to discuss this.

Discussion: https://github.com/SAP/cloud-sdk-js/pull/1750


Plugin runs only with deactivated firewall and open ports

Hello,
my Homebridge runs on a Synology NAS. This plugin only works after deactivating the Synology Firewall. I could open some ports on the NAS but I couldn't figure out witch port (range).
Do you know what port has to be opened? If it helps, I'am using a FritzBox 7490.

The plugin uses following ports: 80, 49000, 49433


Cannot edit Obs; "Save Edits" button inactive

I cannot edit any of my Observations because the "Save Edits" button is inactive/greyed.

I tried to edit an observation just now, it took a long time for the button to un-grey, but it did, and I was able to “Save edits".
I dont’ find any JS errors in the console on the edit page, do you Joe? Not sure what’s up.
But I’m about to head out (to look for mushrooms!)

On Nov 10, 2023, at 9:19 AM, Joseph D. Cohen @.***> wrote:
I cannot edit any of my Observations because the "Save Edits" button is inactive/greyed.
—
Reply to this email directly, view it on GitHub https://github.com/MushroomObserver/mushroom-observer/issues/1687, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO3TP4OY3KRRTVB5S74FWTYDZOZ7AVCNFSM6AAAAAA7GPHRFKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DQMBTGY4DONI.
You are receiving this because you are subscribed to this thread.

I agree that the graying out of the Save Edits/Create buttons for various objects don't work quite correctly.  I have run into this problem several times while working on projects.  I generally get around it by toggling some checkbox or other widgets that re-enables it.  It needs to get fixed.  The worst specific case that I believe I have already reported is making changes to the location information using the Google Maps UI.

@mo-nathan I just fixed the submit grey-out yesterday on the obs form and I understand the issue better, but i believe you are talking about the locations on the project form, is that right?
I can take a look at it now if that's the case. I will probably not make the meeting today.

LOL that just shows how unfamiliar i am with projects. No map on the project form!


[Feature Request] Teaching process with other coins

Teaching with other currencies available on the server can be added.
eg;
if ( pItem->IsType(IT_GOLD) )
{
    CItemMemory *pMemory = Memory_FindObj(pCharSrc);
    if ( pMemory )
    {
        switch ( pMemory->m_itEqMemory.m_Action )
        {
            case NPC_MEM_ACT_SPEAK_TRAIN:
                return NPC_OnTrainPay(pCharSrc, pMemory, pItem);
            case NPC_MEM_ACT_SPEAK_HIRE:
                return NPC_OnHirePay(pCharSrc, pMemory, pItem);
            default:
                break;
        }
    }
}

if (pItem->GetDispID() == ITEMID_SILVER_C1)
{
	CItemMemory* pMemory = Memory_FindObj(pCharSrc);
	if (pMemory)
	{
		switch (pMemory->m_itEqMemory.m_Action)
		{
		case NPC_MEM_ACT_SPEAK_TRAIN:
			return NPC_OnTrainPay(pCharSrc, pMemory, pItem);
		default:
			break;
		}
	}
}

if (pItem->GetDispID() == ITEMID_COPPER_C1)
{
	CItemMemory* pMemory = Memory_FindObj(pCharSrc);
	if (pMemory)
	{
		switch (pMemory->m_itEqMemory.m_Action)
		{
		case NPC_MEM_ACT_SPEAK_TRAIN:
			return NPC_OnTrainPay(pCharSrc, pMemory, pItem);
		default:
			break;
		}
	}
}

// Giving item to own pet

The codes here are purely examples. Although many have been tested, some may need to be rewritten.

You can just set Silver Coins and Copper Coins as a type of T_GOLD, I am not sure if we need this.


url_history downcase method

bad url_history/url_calls keys:
get http://...
instead of
GET http://...
=>url_method = f'{method.upper()} {response.url}'

fixed


Change deprecated v1beta1 CRD to v1

As per helm3's warning:
apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition

@googlebot I signed it!

@orfeas0 could you please bump up the chart version in this PR? Thanks!

@orfeas0 could you please bump up the chart version in this PR? Thanks!

Bumped version, but not appVersion. Is this ok?

Can you resolve the conflict?

Looks like the chart integration test failed with the following message:
Error: failed to install CRD crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml: CustomResourceDefinition.apiextensions.k8s.io "scheduledsparkapplications.sparkoperator.k8s.io" is invalid: [spec.versions[0].schema.openAPIV3Schema: Required value: schemas are required, metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111]

I don't get the test fail, is it because I'm missing permissions?
What's the process?

I don't get the test fail, is it because I'm missing permissions?
What's the process?

@orfeas0 @liyinan926
Seems you need to have a PR in kubernetes GitHub then once you have approval you add this annotation:
metadata:
annotations:
"api-approved.kubernetes.io": "https://github.com/kubernetes/kubernetes/pull/PRNUMBER"
I think this is only due to the fact the sparkoperator team used a protected internal URL spec for the CRD spec with:
sparkoperator.k8s.io
If it was just:
sparkoperator.spark.io
then you'd need no such annotation.
So I suppose best idea is to submit a PR or an issue on kubernetes repo and ask them how to proceed. I'll be rooting for you because I need this, but I am not part of the project so not my place to make such a request externally.

I think this is superceded by https://github.com/kubeflow/spark-operator/pull/1298 and can be closed now


allow user to specify "insufficient to plot" threshold

We have hard-coded into the code the minimum number of samples that a group must contain to draw a histogram, because histograms look increasingly weird as the number of samples get small (this is true both with and without kernel density estimation). Limit was 200, now set to 60.
Perhaps this should be user-determined. Put a slider under "more settings" to let the user override our threshold.
However, currently, doing that would be complicated, because the back end thinks it knows what the front end will want to plot, and doesn't assign colors to small groups.
It was probably a bad architecture decision in the first place to put the color-selection into the back end anyway. So, although implementing this slider would be extremely easy, a prerequisite should be to reorganize such that the color-selection happens on the front end.

If we are suppressing data from groups with too few results because of re-identification concerns, this should not be under the user's control.


ValueSet: PEC Exemption Type values

Please update value set to:

9002: is under 16 years of age - confirmed by source
9003: is 16, 17 or 18 and in full-time education - confirmed by source
9004: is 60 years of age or over - confirmed by source
9005: has a valid maternity exemption certificate - confirmed by source
9006: has a valid medical exemption certificate - confirmed by source
9007: has a valid prescription pre-payment certificate - confirmed by source
9008: has a War Pension exemption certificate - confirmed by source
9009: is named on a current HC2 charges certificate - confirmed by source
9011: gets income support (IS) - confirmed by source
9012: gets income based Job Seeker's Allowance (JSA (IB)) - confirmed by source
9013: is entitled to, or named on a VALID NHS tax credit exemption certificate - confirmed by source
9014: has a partner who gets Pension Credit Guarantee Credit (PGCC) - confirmed by source
9015: Patient does not need to pay the prescription charge - confirmed by source

Note the following deliberately removed:

0000: Patient has paid appropriate charges at old rate
0001: Patient has paid appropriate charges
0010: was prescribed free-of-charge contraceptives

Changes have been upload to fhir.nhs.uk

Sorry I've not been clear: please get rid of 0002 to 0015, so the service will only return 9002-9999

valueset updated


Deep depths - Deep dark ocean equivalent

No carvers
Generates in deep oceans
Uses waterlogged sculk

Added by Rogue


[TASK] decision to either move to ArgoCD or to stick with ShipIt as our CD tool

We need to make a decision on whether to use ArgoCD or Shipit as our CD tool. Something to keep in mind: Before going to prod, it is fairly simple to swap to one or the other if we want. Some further reading to understand what the features of ArgoCD are should be done and a set of risk/benefits defined for both options.

[x] Further reading of ArgoCD docs & features
[x] Risks & benefits of each option
[x] Decision on which to use

Awesome! Thanks @dleard!


[#692] Fix Mempool TicketNo counter implementation

I have taken over this PR. I rebased on top of master to include #832 upon which the tests for the fix are based.

bors r+


Fix coverage support

This is an attempt to fix coverage support. Currently it report a mere 29% because of parallel testing

LGTM

Yeah, but coverage it's not fixed :(

@mkoistinen coverage support is now fixed. Coveralls still does not  report coverage status to github, though

Coverage increased (+61.7%) to 90.937% when pulling 9a3341e3b058b7cd25e1def3ddc4d984dd4119c8 on yakky:feature/fix_coverage into dccab14ffc0990e3a9e2a2da9a3275f2552fb5b8 on divio:develop.

Coverage increased (+61.7%) to 90.937% when pulling 9a3341e3b058b7cd25e1def3ddc4d984dd4119c8 on yakky:feature/fix_coverage into dccab14ffc0990e3a9e2a2da9a3275f2552fb5b8 on divio:develop.

Coverage increased (+61.7%) to 90.937% when pulling 9a3341e3b058b7cd25e1def3ddc4d984dd4119c8 on yakky:feature/fix_coverage into dccab14ffc0990e3a9e2a2da9a3275f2552fb5b8 on divio:develop.


[Feature - Hard?] Nested calls.

I think there's only one more feature that I can think of.
Nested calls - for when the existing methods are almost but not quite good enough.
E.g.
{
	"name": "spawnItem",
	"desc": "Spawns an item at a location.",
	"returns:" ["boolean", "True on success, I suppose."],
	"call": "Server.getWorld(0).dropItemNaturally(new Location(Server.getWorld(0), 1, 2, 3) , new ItemStack(4, 5))"
	"args": [
		["String", "The world to explode a part of."],
		["double", "x coordinate of the item drop."],
		["double", "y coordinate of the item drop."],
		["double", "z coordinate of the item drop."],
		["int", "Item ID"],
		["int", "Item amount - up to 64."]
	]
}

I mean, feel extra free to reject this one.

I knew this would come up eventually.
I want to do this, just for the challenge, but no promises on time.

Time to get started on extending it myself, huh.
Oh look, it's all explained and everything. Nice.
https://github.com/alecgorge/jsonapi/wiki/Integration-guide-for-normal-api-methods


Added text message for adding and deleting buttons

Fixes Issue
Closes #1706
Changes proposed
Added text messages in code that will appear on the webpage just after adding or deleting a button component. Along with this text message for error in adding and deleting is also added.
Screenshots

Checklist

[x ] You've linked this PR to the correct issue.
[ x] You have checked that the code is working correctly.
[x ] You ⭐ the repository!

Note to reviewers

Great Work @Srishtikumari2002


Decimal point in LED

Hi, is it possible to send decimal point message to LED display? ASCII character did not show and I cant figure this out.

Hi, I don't have a padkontrol any more unfortunately, but the ASCII character for period (.) should be supported. Do you have an example of the string you're passing?

Thanks for response.
3 character alphanumeric string, like 'ab1', is displayed properly - 'ab1',
3 character string with unsupported character do not display invalid symbol, for example 'a@1' is displayed as 'a1'.
Period symbol do not display when passing as string '...', or even 4th character '3.00'.
According to this old docs https://static.twoday.net/kpkproject/files/Padkontrol-Sysex-Imp.pdf
table 3.2-2, valid symbols for LCD display are (20~7F) ASCII characters,
but most of the not-alphanumeric symbols are not displayed at all.

I just looked at a photo of the padkontrol (it's been a while) and realised you might mean the small decimal point LEDs that are separate from the seven segment LEDs. I'd forgotten those were there.
The light function (https://github.com/stuartkeith/padkontrol/blob/master/padkontrol.py#L105) mentions you can pass either a pad number or a button constant to turn on that light, but looking at the PDF, you can also control the LEDs directly.
If you look at 3-2 Native KORG mode Messages > (1) Native KORG mode Display LEDs in the docs, it mentions LED Number 00~0F, 10~22, 30~47 = PAD1~16, SW LED, 7Seg.LED. PAD1~16 and SW LED are already implemented in the library, but I've never tried the 7Seg.LED values.
So the values 30~47 seem to be linked to the seven segment LEDs. I'm hoping that means 3*7 segments, plus the decimal points in between, and then it's just a matter of finding out which values in that range toggle the decimal points. send_sysex(pk.light(0x30 + 7, True)) might turn it the first decimal point on, but that's just a stab in the dark.
Then (maybe) you can call pk.led to set the ASCII characters as normal, and then pk.light to light up the decimal points. Not as nice as being able to do it in one led call, but from the doc, it doesn't seem like that's supported. Unless you try toggling bits on the ASCII characters or something, seeing if there's undocumented behaviour there.
It's a bit difficult to be much help when I don't have a padkontrol, but maybe this might help, or at least serve as a starting point. Let me know how it goes!

I probably misread/ misunderstood this part in docs. This command send_sysex(pk.light(0x30 + 7, True)) turned middle DP on. I should to be able to generate even custom symbols now.
Thank you very much!!

Glad it worked!


Upgrade of cnb-api

hi,
I've checked the package and thank you for it!
I wanted to contribute the codebase with an "Client" interface so I can make a test (without mocks). But I've noticed issues due the PHP versions constraints. I had to update:
PHPStan:
Seems ok, few errors that can be fixed
coding standard:
I had to enable plugin to use it. Fails on ERROR: Referenced sniff "SlevomatCodingStandard.TypeHints.TypeHintDeclaration" does not exist
tester:
Fails to run, : No such file or directory
I was thinking what is your plan? Are you interested in upgrade?
I could do this:

fix PHPStan issues
replace Nette tester with PHPUnit 10
replace slevomat with https://github.com/symplify/coding-standard +https://github.com/rectorphp/rector
Upgrade to PHP 8.1?
Extract Client to interface

Thanks and have a good day,

Hello,
thank you for your feedback.
There is now a v4.0 branch under development, in which comments will be reflected. Support for PHP 8 is planned, as well as rewriting the code to a cleaner form.
I believe this update will take effect quickly.
Thanks for the comments!

Thanks for the info, I can confirm that the code is running on 8.1 without any warnings (so far) 👍
Do you need any help?

Try the rector php, it will automatically upgrade the code to PHP 8.0 conventions (so you can focus on other stuff) :)


Programmtic Changelog Checking, Github

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.
Changleog validation is a nice to have. Ideally its something that can be inspected and dealt with in github itself.
Describe the solution you'd like
Implement a changelog check in github actions.
ideally something like this that checks if there is a correct semver scoped issue for the branch in question
Additional Context
previously pre donation solo-io had a bot that would handle these events
Note that this is both part of https://github.com/k8sgateway/k8sgateway/issues/10363 and https://github.com/k8sgateway/k8sgateway/issues/10217

If the bot is not involved fixing the changelog folder, ideally we shouldn't require  a folder. maybe take an approach like in istio, where all release notes go in one folder?
or Envoy, where post-release the changelogs are organized into folders?

I really dont like the envoy strategy.
The fact that the last commit to a changelog is always the "rename" one makes git blame alot more painful.
That being said would be interested to chat more on the desired format.

we discussed in slack but to summarize here - i don't care about the format; but rather the devex of moving the changloge file to the right folder mid-PR

@nfuden git blame has an --ignore-rev flag that can ignore certain commits when blaming a file. I'm not sure how well it works if the file was renamed though.

Yeah but I like the basic vscode integration for lens

+1 to @yuval-k's comment. Having to move the changelog entry around mid-pr is not great. If we get a chance to begin again I'd definitely like to go with something that avoids having to deal with those moves.


Client: Change table to lists

This will be general improvement as it's hard to make tables responsive.
And there will be much more control over displaying list content.

Done!


Set permission on atomic file write

Perform chmod before rename with the atomic file writer.
Ping @tonistiigi

LGTM

Update to call (*os.File).Chmod right when file opens. This uses the file descriptor so can be done safely right after open.

Error starting daemon: Couldn't create Tag store repositories: chmod D:\CI\CI-726b8fc\daemon\image\windowsfilter\.tmp-repositories.json584666515: not supported by windows"

@cpuguy83 thanks for pointing that out. The error message is slightly misleading, it is "fchmod" which is not supported, so I switched it back to use os.Chmod instead of (*os.File).Chmod.

@dmcgowan tp5 doesn't like that testcase

ping @jhowardmsft  do you have any insight to how I am setting or testing file mode incorrectly?

Windows doesn't have a concept of an execute bit.

Thanks John, changed permission test to 0644, The "other" bit didn't get set either so set it to the same as the group for the test.

fswriters_test.go:37: Mode mismatched, expected 644, got 666

Ugh, ok, so Windows doesn't have group or other bits. Guess will just have to change to 666 since writing separate tests is not worth it. Temp files are initialized to 0600 anyway.

LGTM

Still LGTM

all green, merging

@cpuguy83 @dmcgowan @tonistiigi do we need this for 1.12?


display ip address for playground dashboard

In v0.4.7, when the playground starts, the URL of the dashboard is printed:
Welcome to Gorse v0.4.7 Playground

    Dashboard:     http://<IP_ADDRESS>:8088/overview
    RESTful APIs:  http://<IP_ADDRESS>:8088/apidocs
    Documentation: https://docs.gorse.io/

It would be better to print the IP address of the current machine.
Welcome to Gorse v0.4.7 Playground

    Dashboard:     http://<IP_ADDRESS>:8088/overview
    RESTful APIs:  http://<IP_ADDRESS>:8088/apidocs
    Documentation: https://docs.gorse.io/

And consider opening the dashboard in the browser using https://github.com/pkg/browser.

Unnecessary


Encourage custom formatters to use a proper namespace.

The code could use more work, such as corresponding require code, but this addition marks the main idea of it.

Not sure I follow. How does rescuing from a NameError encourage this?

It's not the NameError, it's the RSpec::Core::Formatters::const_get(formatter_ref). Rescuing the NameError provides fallback to prior behavior.
Then custom format writers could use:
module RSpec
  module Core
    module Formatters
      class MyFormatter < BaseFormatter
        ...
      end
    end
  end
end

And the rspec command can be:
$ rspec -r my_formatter -f MyFormatter

Also, the next thing to do is adjust the code to also require the corresponding file if need be.

Actually, I'd encourage you to use a different namespace for extensions. MyFormatter does not ship with RSpec, and putting it in RSpec's namespace makes it harder to understand that.
Additionally, if I decide to rename RSpec::Core::Formatters to RSpec::Core::Reporters, the error message you'd get from trying to load RSpec::Core::Formatters::MyFormatter would be a name error on BaseFormatter, whereas if you had this:
module MyFormatters
  class MyFormatter < RSpec::Core::Formatters::BaseFormatter
  end
end

... you'd get a name error on RSpec::Core::Formatters, which would give you better insight into what went wrong.

Okay. That makes sense. Would be possible to work this in the other direction then? For instance, I released a formatter as rspec-ontap. Agreeing with you assessment I would normally name the formatter library file lib/rspec-ontap.rb. Ideally I could just use something like:
$ rspec -f ontap ...

And it could load the library file and use the corresponding class. Could we get the code to work like that?

I don't really want to do this implicitly from RSpec. If you want to do something implicit, you could add the directory the contains the formatter to the $LOAD_PATH from lib/rspec-ontap.rb. If you only put the one file in that directory you won't be polluting the $LOAD_PATH with necessaries - just making it easy to properly namespace your formatter, while making it easy on users at the same time.
To be explicit, we could expose an API that rspec-ontap could use to register a formatter. Something like:
RSpec.configure do |c|
  c.register_formatter 'ontap', 'rspec-ontap/formatter.rb', OnTap::Formatter
end

I'd be open to this, but I don't think it's really necessary when we can just the $LOAD_PATH as described above.
WDYT?

I don't see how that would help. The ultimate goal is really to reduce what one has to put on the command line to a single -f name. To do that there has to be some sort of conventional namespacing that rspec can use to look things up.

I think @dchelimsky's point about the fact that we don't want to encouraging developers to put formatters in the RSpec namespace is a good one.
As for the configuration API; it seems unnecessary, IMHO.
FWIW, I regularly use the Fuubar formatter, and all I need to use is rspec spec --format Fuubar; none of these gymnastics are needed to have a simple command line interface.  As long as you get the formatter on the load path somehow, it just works.  But I don't think it's RSpec's job to manage the load path for you.  It's easy enough through a couple different approaches:

Use bundler, put the formatter in your gemfile, and run the specs with bundle exec rspec.
Use bundler, put the formatter in your gemfile, and put the appropriate bundler requires at the top of a file that your specs require (such as spec_helper.rb).
If you hate bundler, you can just install the gem and require.

...So I guess you could say that I don't see the need the benefits to the additional complexity from one of the suggestions in this thread.

No need to munge the LOAD_PATH. That's certainly not what I am advocating.
Current behavior actually is sort of is encouraging putting formatters in the RSpec namespace. I just wrote a formatter and to get it to work with the least amount effort for the end-user I had to use RSpec:: namespace. See http://rubyworks.github.com/rspec-ontap, since it would not be proper to use tapy.rb and tapj.rb in the top of the lib/ space.
Also, current code uses eval to get constant from -f option, which is a security hole, so to speak. It really should use a more explicit const_get approach. Also, it could pick up the wrong constant inadvertently and possible do some strange things.
What about allowing a special RSpec::CustomFormatters namespace that people can use? So when using -f foo it will check the built-in formatters, if not there it will check for RSpec::CustomFormatters::Foo, failing that it will try to load rspec-foo and try again. Failing that it can fallback to current behavior for backward compatibly, at least for the time being.

Also, current code uses eval to get constant from -f option, which is a security hole, so to speak. It really should use a more explicit const_get approach. Also, it could pick up the wrong constant inadvertently and possibly do some strange things.

Agreed about that.   I'd prefer not to see eval here, too.

since it would not be proper to use tapy.rb and tapj.rb in the top of the lib/ space

It's good to be very careful about what you put in the folder that goes on the load path...but if you want both of these to be easily require'able and reference'able using require "tapy" and --format TapY or require "tapj" and --format TapJ...then I don't see the problem with putting them directly in lib so people can use them directly.
The main point is that it's important to be very, very selective about what goes directly in lib, and you should never put a file there that conflicts with a known other ruby library file (i.e. set.rb from the stdlib).

It's good to be very careful about what you put in the folder that goes on the load path...but if you want both of these to be easily require'able and reference'able using require "tapy" and --format TapY or require "tapj" and --format TapJ...then I don't see the problem with putting them directly in lib so people can use them directly.
That's exactly it: TapY and TapJ aren't just for RSpec. They are a cross-framework format. So it doesn't makes sense for tapy.rb and tapj.rb to be just for RSpec. What does make sense is to call them rspec-tapy.rb and  rspec-tapj.rb`.


Add new Silver Material "Ether Photon Converger" into list of Materials

Preparation

[X] No one has asked for this feature before in other issues (even the closed ones)

Describe the feature
New material found in Paper Moon: Ether Photon Converger

What's also missing:

Sunscale
Obsidian Edge
Vestige of Madness

2 of them were introduced in LB7, Vestige of Madness is Paper Moon.

Fixed in version 2056, will be available as canary in 15 minutes and via play store in a few hours.


Get all rowID for a frame/index

Description
Users are not able to get all bitmap that they import now. We might want to support that to know total of bitmap for each frame or index
Success criteria (What criteria will consider this ticket closeable?)
Probably create new PQL to get all bitmap or count all bitmap, something like:
For each frame:
curl -XPOST "http://<IP_ADDRESS>:10101/index/foo/query" -d 'GetAll(frame="bar")' returns all rowID for frame="bar"
curl -XPOST "http://<IP_ADDRESS>:10101/index/foo/query" -d 'CountAll(frame="bar")' return count of all row ID for frame="bar"
For an index:
curl -XPOST "http://<IP_ADDRESS>:10101/index/foo/query" -d 'GetAll()' returns all rowID for index="foo"
curl -XPOST "http://<IP_ADDRESS>:10101/index/foo/query" -d 'CountAll()'returns count of all rowID for index="foo"

I'd like to understand the use case here a little better.
Thoughts in no particular order:

I don't understand the need to return all rows for an index. I suppose you could return all rows for all frames, but I'm not clear what the use case for that would be.
We could consider storing rowIDs in something like an in-memory B-Tree, but I don't think every node necessarily has knowledge of every rowID (only the rowIDs which contain data located on the fragment(s) on any particular node), so asking the cluster for all rowIDs would require asking all nodes and doing some kind of merge; or it would require, alternatively, broadcasting the existence of all rowIDs to all nodes.
we could consider using Pilosa's inverse view to store the existence of a rowID (basically a bitmap that represents not-null for a rowID). I'm not sure how this may affect performance/storage.

I agree that this kind of functionality (getting all rows in a frame) is desirable. I have several concerns.
Having this functionality internally would definitely be good - as would exposing it to plugins. I would hesitate to this to PQL though. This is the kind of thing that a robust query language would support implicitly rather than adding a separate call. This feature also has overlap with TopN which bothers me - the more elegant way to do this is have a single function which returns rows, and filters and sorting can be applied.
All that said, I hope that however we do this can stream the results in order to support large numbers of rows in a performant way.

I agree that getting all rows in a frame has overlap with TopN. If I want to get all intersection of 1 single rows and all other rows in the frames with cacheSize equals to all rows, TopN actually returns intersection for all rows in the frame. However, if we keep continue import rowID without changing cacheSize, I'm not able to get all the results with TopN since TopN only returns results within cacheSize as I understand. That means this feature doesn't need to be supported if cacheSize is set big enough with growing data.
Also, count all rowID in a frame might be helpful when I import 1000 rows, and I would like to know all 1000 rows are imported correctly without exporting them out.
I also agree that returning all rows for an index is not necessary, because I can have that number if getting all rows in a frame is supported.

Todd's work in #1496 covers this.


ADBDEV-6599: Make gprestore --resize-cluster use --jobs for parallel restoration

Make gprestore --resize-cluster use --jobs for parallel restoration
Users consider the current behavior to be incorrect, since the --jobs parameter
is used when creating a backup, which is not actually used during restoration.
Restoration works in a single instance of the gpbackup_helper agent (in the
--restore-agent mode).
In short, when restoring a backup using the gprestore utility with the
--resize-cluster option, which was previously made in parallel creation mode
(--jobs), the utility does not use the corresponding mode during restoration.
In this case, restoration occurs through gpbackup_helper, which is launched in
one instance of this process for each segment. Thus, one table is processed at
a time based on the list of table OIDs passed when gpbackup_helper is launched.
As a solution to the problem, this patch implements the launch of several
gpbackup_helper instances based on the value passed in the --jobs argument.
To do this:

The general list of table OIDs for restoration is distributed between
several instances of gpbackup_helper processes according to the specified value
of the --jobs parameter. Also this list is distributed between goroutines in
main process by same way.

Since the general list of table OIDs for restoration is sorted by size, the
distribution among gpbackup_helper instances and among goroutines is done
according to the principle of sequentially distributing one table OID to each
instance and goroutine. Thus, the load is expected to be more uniform. All
batches corresponding to the same table OID go to the same gpbackup_helper
instance and same goroutine.

An integer identifier of the "instance number" is added to the file name of
the list of table OIDs for restoration by gpbackup_helper instances. They are
not logically related in any way, the main thing is that its own list is passed
as an argument when starting gpbackup_helper.

The instance number is also added to the name of the script file
(scriptFile).

The instance number is also added to the name of the pipeFile file, error
file and skip file.

To create the initial list of pipes, one pipe is created for the first table
OID (according to the sorting of table OIDs by decreasing table size), which
will be processed by each instance of gpbackup_helper. Thus, at the time of
starting each instance of gpbackup_helper, the file system will already have
the first pipe corresponding to the first table OID for this instance.

When starting gpbackup_helper, the value of the --jobs parameter is taken
into account (in fact, the number of connections in the pool). The number of
launched instances corresponds to the value of the parameter. The value of the
path of the first pipe (pipeFile), the path to the agent startup script
(scriptFile), and the path to the list of table OIDs corresponding to this
instance are passed as arguments.

When deleting auxiliary files in DoCleanup, the files with the list of table
OIDs and the startup script files (scriptFile) are deleted.

For --single-data-file and --copy-queue-size modes, the current behavior
remains unchanged.

For more convenient management, all auxiliary files have been renamed. The
process pid is placed before the suffix. The word pipe has been removed from
the names of error and skip files.
New tests have been added and old ones have been adapted.

It is easier to view the changes with the "Hide whitespace" option enabled.

The new test has failed, please look into this

The new test has failed, please look into this

This is not a new test, but an old one. But it became flaky (other runs were successful).

Shouldn't this error file name be updated as well?

yes, added


Feature Request:  Allow use of Hera Workflows when argo is using the SSO authentication option

First, thanks for creating Hera Workflows, it seems like a nice tool.
I see the note in the docs

Note Since the deprecation of tokens being automatically created for ServiceAccounts and Argo using Bearer tokens in place, it is necessary to use --auth=server and/or --auth=client when setting up Argo Workflows on Kubernetes v1.24+ in order for hera-workflows to communicate to the Argo Server.

I take it to mean that if Argo Workflows has been deployed with --auth=sso that you can't use Hera Workflows?  Is that right?  If so, is there any plan to allow the use of Hera Workflows when using Single Sign On?  I tried to use the token that I got from Argo Server on a local deployment (using --auth=sso), but was getting an Unauthorized Exception even though the token works for the argo CLI tool.

Thanks for clarifying this for me.

Okay, I think it figured it out.  That token did work, it's just that hera adds "Bearer " to the GlobalConfig.token value so 'Bearer ' was being added twice in my case which resulted in the Unauthorized Error.


Text rendering on Winows 10 is completly broken

Most of text no t rendering at all, but in some files we can see some single lines of text.
Image show bug:

Todays (14.06) build from https://github.com/onivim/oni2/commit/0bf0a9a9b91a0427b5414d27d348d9fac88a4d63
Log:
oni.log

The same on macOS

Hey @tmshv and @Miziak, sorry that you're having this issue. I think I know what the problem is but would you guys mind posting your configs, specifically the editor.fontFamily flags?

@zbaylin

{
  "editor.detectIndentation": true,
  "editor.fontFamily": "FiraCode-Regular.ttf",
  "editor.fontSize": 14,
  "editor.largeFileOptimizations": true,
  "editor.highlightActiveIndentGuide": true,
  "editor.indentSize": 4,
  "editor.insertSpaces": false,
  "editor.lineNumbers": "on",
  "editor.matchBrackets": true,
  "editor.minimap.enabled": true,
  "editor.minimap.maxColumn": 120,
  "editor.minimap.showSlider": true,
  "editor.renderIndentGuides": true,
  "editor.renderWhitespace": "all",
  "editor.rulers": [],
  "editor.tabSize": 4,
  "editor.zenMode.hideTabs": true,
  "editor.zenMode.singleFile": true,
  "files.exclude": ["_esy", "node_modules", ".git"],
  "workbench.activityBar.visible": true,
  "workbench.editor.showTabs": true,
  "workbench.iconTheme": "vs-seti",
  "workbench.sideBar.visible": true,
  "workbench.statusBar.visible": true,
  "workbench.tree.indent": 2,
  "vim.useSystemClipboard": ["yank"]
}

@Miziak if you delete the fontFamily line does the problem still occur?

@zbaylin  it rendering ok now but defaults to andnother font I belive

@Miziak and @tmshv, this should be fixed now in the latest build. Feel free to reopen this if you see the same thing today/tomorrow. One change that was made was that we moved the default to JetBrains Mono, so if you want to use Fira now you'll have to download and install it yourself. Sorry for the inconvenience!


Chisel3 compilation error on Travis

The error message starts at
https://travis-ci.org/ucb-bar/rocket-chip/jobs/118401486#L1382
The problem seems to be in the module "RegressionTest".
https://github.com/ucb-bar/groundtest/blob/master/src/main/scala/regression.scala#L399
What exactly is the issue here and how do I fix it? This code works fine in Chisel 2.

The error message says
Starting Check Initialization

Fatal Uncaught Exception.

<EMAIL_ADDRESS>[module RegressionTest]  Reference regressIOs[0].cache.resp.bits.addr is not fully initialized.

which seems it's got something to do with not having initialized wires.  Poking around the FIRRTL source code, I see
firrtl $ grep "Check Initialization" -R src/
src/main/scala/firrtl/passes/Checks.scala:   def name = "Check Initialization"

and looking at the source it kind of indicates that's what is going on here -- it looks like this walks through every signal and recursively attempts to ensure that every signal is wired up to something.
I don't see anything in RegressionTest that's actually initializing the outputs that this pass is complaining about (cache.resp.bits.addr, for example).  I think this is probably the problem.  It seems this shouldn't be too hard of a case to check in Chisel, so we can give users a better error message -- but I'm not going to do that.
Also, note that your stuff doesn't appear to work in Chisel 2: https://travis-ci.org/ucb-bar/rocket-chip/jobs/118401486#L2509.

I don't see anything in RegressionTest that's actually initializing the outputs that this pass is complaining about (cache.resp.bits.addr, for example)

Okay, that was my fault. I forgot to connect cache.resp.bits. But I fixed that and now it fails verilog compilation. As for the chisel 2 failure, that shouldn't be happening either. It was working until recently.

The Chisel2 problem seems to be with ROM generation. When I take out the following line
val data_beats = Vec.tabulate(tlDataBeats) {
  i => UInt(0x3001040 + i * 4, tlDataBits)
}

And replace it with equivalent logic not using a ROM, it works in the emulator. Did something break emulator ROM generation?

Also, as for the disconnected wires thing. What if you had a decoupled or valid interface and you just want to disable it? Currently, the way we do it is to just tie valid to false and leave bits disconnected. But the way it is now, you will also need to set bits to some default value or get a fatal error. It seems unnecessarily burdensome to require the RTL writer to connect all wires even if they will never be used.

We support the old chisel2 approach for disconnected module I/Os -- all
instance inputs and all module outputs are pre-initialized to random.
On Fri, Mar 25, 2016 at 11:55 AM, Howard Mao<EMAIL_ADDRESS>wrote:

Also, as for the disconnected wires thing. What if you had a decoupled or
valid interface and you just want to disable it? Currently, the way we do
it is to just tie valid to false and leave bits disconnected. But the way
it is now, you will also need to set bits to some default value or get a
fatal error. It seems unnecessarily burdensome to require the RTL writer to
connect all wires even if they will never be used.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ucb-bar/chisel3/issues/125#issuecomment-201423617

Then why the fatal exception?

So I've deliberately connected all the wires and worked around the ROM generation issue. But still not able to compile the regression tests with Chisel 3. I've pushed my changes to the branch uncore-fixup on rocket-chip.

What's the Chisel 3 problem now?
On Fri, Mar 25, 2016 at 2:20 PM, Howard Mao<EMAIL_ADDRESS>wrote:

So I've deliberately connected all the wires and worked around the ROM
generation issue. But still not able to compile the regression tests with
Chisel 3. I've pushed my changes to the branch uncore-fixup on rocket-chip.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/ucb-bar/chisel3/issues/125#issuecomment-201511120

I need to look at the FIRRTL to answer that.

Jack is taking a look at it now. Seems to be an issue with name expansion.

any resolution?

Not yet, I'll be looking at this after 4
On Tue, Mar 29, 2016 at 1:55 PM, Andrew Waterman<EMAIL_ADDRESS>wrote:

any resolution?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ucb-bar/chisel3/issues/125#issuecomment-203098532

I believe this is resolved in @jackkoenig's yet-to-be-merged FIRRTL PR.


OS=16 get better result than OS=8 in my val dataset

hi,you said Xception backbone should be trained with OS=16, and only inferenced with OS=8,but OS=16 get better result than OS=8 in my val dataset  ,why?
os=8 0.7820307191530157 0.8163021613035841 0.6259312247569429
os=16 0.7855338935948276 0.8200502315806699 0.6927438598873709

yes , i have.I am very confused about this result.Has anyone else got results similar to me?

@uniquezhengjie
The intuition behind suggesting to use OS=8 for inference is that it would provide a dense prediction map in the bottleneck, losing less information.
Can you share your fine-tuning results of this model? For me it looks like it's impossible to fine-tune it for another task.


Cleaning up docs and fixing typos

There will be more for this to come, but I just wanted to get it accurate to the library.
As I add the features back, I will add them to the docs again.

Bump, I have a branch for adding image(filename='myfile.jpg') but I would like to get this and #2770  in first if possible.

Squashed!


Unable to create a record in Prisma PostgreSQL

Bug description
I'm trying to create a commenting system for my blog using Prisma, and thought I'd just get a POC ready to understand how relations and stuff worked. However, I'm not able to do so because of an error.
I'm trying to run this code in a Next.js API route:
import {prisma} from '../../../utils/prisma.ts'

export default async function hanlder(req, res) {
  if (req.method != 'POST') {
    return res.status(500).json({ error: 'Method not allowed.' })
  }

  try {
    const comment = await prisma.comment.create({
      data: {
        comment: 'comnent',
        timestamp: 'timestamp',
        email<EMAIL_ADDRESS>        username: 'username',
        blogc: {
          connect: {
            slug: 'learning-react',
          },
        },
      },
    })
    console.log(comment)
    return res.status(200).json({ success: true, currentComment: comment })
  } catch (err) {
    console.log(err.message)
    return res.status(400).json({ success: false, error: err })
  }
}

I'm not sure if I'm coding something wrong, but Prisma keeps throwing this error:
Cannot read properties of undefined (reading 'create')
I know this is not some issue with the prisma client because my other methods like reactions and guestbook comments are working.
How to reproduce

Expected behavior
I should be able to create a comment.
Prisma information
My current schema looks something like:
model Comment {
  id        Int    @id @default(autoincrement())
  comment   String
  timestamp String
  email     String
  username  String
  blogc     Blogc? @relation(fields: [blogcId], references: [id])
  blogcId   Int?
}

model Blogc {
  id       Int       @id @default(autoincrement())
  slug     String
  comments Comment[]
}

Environment & setup

OS: MacOS
Database: PostgreSQL
Node.js version: v18.0.0

Prisma Version
prisma                  : 3.13.0
@prisma/client          : 3.13.0
Current platform        : darwin-arm64
Studio                  : 0.459.0

Fixed the issue. Apparently, restarting my computer was enough.


Use worker_threads if available

New node has experimental support for workers
https://nodejs.org/api/worker_threads.html
but OF COURSE they are just TINY different from webworkers so they cannot be used as drop-in, as this module can be used.
Maybe this module can use worker_threads when available?

Closing, as this is already done via another module that falls back to tiny-worker.


Add support for attributes prefixed with data-

Fixes issue #357

It should work as expected, I tried it on my form that uses formGroup.

Released in 6.15.2 Thanks!


feat: Added simplestaking address 6 and 7 support

First draft of adding support for the additional simplestaking addresses, I wasn't able to get the node running to verify with actual transactions.
Feel free to point where to proceed if this doesn't cover the requirements as is (e.g., how to get a node running once the project is running through yarn).

Thanks @Tarskin! Yep, this looks about right, I'll just test this locally before merging. Might not be until December 26th at the earliest.
Merry Christmas! :christmas_tree:

Looks good! Thanks


UserDefinedTypeSourceId::source_file field is incorrect type

The source_file field in the UserDefinedTypeSourceId struct is of type IdIndex, but it should be of type StringRef. Currently I have to manually de/reconstruct it by hand. Fortunately the IdIndex and StringRef types both have public fields and there is a workaround, but this should not be necessary:
https://github.com/willglynn/pdb/blob/3d394eaf547998eeebc7c08ac5788d83d98a1caa/src/tpi/id.rs#L163
if let Ok(IdData::UserDefinedTypeSource(udt)) = typ.parse() {
    if let Ok(source_file) = StringRef(udt.source_file.0).to_string_lossy(&string_table) {
        println!("{:?}", source_file);
    }
}

Thanks for the report!
There seems to be a difference between LF_UDT_SRC_LINE and LF_UDT_MOD_SRC_LINE that we missed in the initial implementation.
I currently don't have PDBs at hand to verify this, but it looks like we either need to split this into two types, or we create an enum field for the file reference that can either be a IdIndex or a (u16, StringRef).


About call chaining

Will add the "@Chain" of "call chaining"? I think it's a good idea.
For example,  use the code
@Data
@Chain
@NoArgsConstructor
@AllArgsConstructor
public class Result {
private BaseService baseService;
private boolean success = false;
private String message = "";
private Object tag;
}
instance of the code
@Data
@NoArgsConstructor
@AllArgsConstructor
public class Result {
private BaseService baseService;
private boolean success = false;
private String message = "";
private Object tag;
public Result baseService(BaseService baseService) {
    this.baseService = baseService;
    return this;
}

public Result success(boolean success) {
    this.success = success;
    return this;
}

public Result message(String message) {
    this.message = message;
    return this;
}

public Result tag(Object tag) {
    this.tag = tag;
    return this;
}

}

IIUYC this feature already exists, see https://projectlombok.org/features/experimental/Accessors.html

Thanks!


[DOCFIX] Remove sandbox request link from docs

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8825/
Test FAILed.

jenkins. test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8826/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.2 please


Add ImGuizmo and ImGuiPlot to Nuget

Can you add ImGuizmo and ImGuiPlot to the Nuget version or show a tutorial of how to add them?

For now, you can simply:

clone TillAlex's Branch of ImGui.NET-nativebuild and build that. This will give you all 4 DLL's (cimgui, cimplot, cimnodes, cimgizmos) for your project.

Reference the ImPlot.NET/ImGuizmo.NET projects in your project and be sure to put the cimgui.dll/... where your exectuable will find them.

An Example for ImPlot.NET:

using ImGuiNET;
using ImPlotNET;
using System.Runtime.InteropServices;

// More code

IntPtr context = ImGui.CreateContext();
IntPtr implotContext = ImPlot.CreateContext();
ImPlot.SetCurrentContext(implotContext);
ImPlot.SetImGuiContext(context);

// Other code

if (ImPlot.BeginPlot("Some Plot"))
{
        Span<double> xVals = new Span<double>(new double[]{0.0, 1.0, 2.0});
        Span<double> yVals = new Span<double>(new double[]{1.0, 0.0, 1.0});

        ImPlot.PlotLine("Test", ref MemoryMarshal.GetReference(xVals), ref MemoryMarshal.GetReference(yVals), xVals.Length);

    ImPlot.EndPlot();
}

// More code

ImPlot.DestroyContext();
ImGui.DestroyContext();

NOTE: If you are getting access violations, be sure to use all 4 DLL's that were generated by the nativebuild. Otherwise you will have mismatching ImGui versions.

Oh thank wil this all work with Other render apis like OpenTK?

Oh and also i cant seem to get the build correctly for some reason

Oh thank wil this all work with Other render apis like OpenTK?

I sadly don't know.

Oh and also i cant seem to get the build correctly for some reason

Did you init/update all submodules first? What type of error/problem are you running into?
This is what I did to build it:
git submodule update --init --recursive
.\build-native.cmd

works fine on my machine™.

It only compiles for the imgui folder the implot, imguizmo and imnodes dont compile apparently

You'll need to provide more information. What you did, Compiler Output, etc.

When i git clone the repository it only comes with the cimgui folder and in the .gitmodules it does not include the other stuff just the cimgui and i also tried downloading the zip it comes with everything but when i try to compile it with cmake it says that there is an error with the cmakeList.txt

@Pastor111
When @Kayzaks is asking you for more information you cant expect that with the info provided above you get your problems solved!!
Your guide should be the first post from @Kayzacks where is telling you to clone https://github.com/TillAlex/ImGui.NET-nativebuild/tree/additional_libraries. You should clone this one and not any other (as it seems to be happening).
You should do the clone with git clone --recursive https://github.com/TillAlex/ImGui.NET-nativebuild/tree/additional_libraries
where recursive makes sure that all submodules are cloned also (cimgui, cimplot, etc)
Then you will have to build with cmake.
If something fails dont forget to provide the informations of all the commands used in the process and the output messages.

I think i got it correct now but when i try to link it cimguizmo and the other libraries it says that the reference is unvalid or unsopported

I think i got it correct now but when i try to link it cimguizmo and the other libraries it says that the reference is unvalid or unsopported

Cool. Please re-read and re-follow the steps in our previous comments, it should be working. If not I would like to emphasize the following two comments:

You'll need to provide more information. What you did, Compiler Output, etc.

and

[...] you cant expect that with the info provided above you get your problems solved!!

I have a question when i add the 4 dlls in my project should i unistall the Imgui.NET package or should i keep it?

if you want use imgui, implot then,

reference ImGui.NET/src/ImGui.NET
reference ImGui.NET/src/ImPlot.NET

and add your .exe build folder cimgui.dll, cimplot.dll

Is there any update on making these available through NuGet? I'm aware of the manual compilation step but NuGet is much more convenient

按照上面[sonoro1234] (https://github.com/sonoro1234)native 编译后,调用cimplot.dll，并按照时[Kayzaks]方法使用时，总是报“Attempted to read or write protected memory. ”错误。然后他这个版本匹配很重要，ImGui.Net使用的版本和cimgui的版本要对应上，像TillAlax里是cimgui 1.82+ cimplot 0.9,他提供的deps里或者编译完成的dll版本，自然而然是基于1.82的，而我当时使用的ImGui.Net是1.87版本，我直接拷贝了TiilAlax的编译dll就发生了这个错误，而我后来的解决方法就是，直接在Tillax的0.9 cimplot基础上，拷贝1.87的cimgui覆盖并重新编译，就能正常使用cimplot.dll了。 其实最好的方法是重写各个版本对应的CodeGenerator里的definitions和cimgui.cpp\h包装，一一对应。但是他们这个json当时写的时候不会都是全手写，一个个对函数的吧？没有直接更新的工具吗？

@sonoro1234
In order to get the ImPlot binaries for using ImPlot.NET, I've been trying to follow your instructions but without success thus far...
Cloning the repository works:
C:\Users\aybe\source\repos>git clone --recursive https://github.com/TillAlex/ImGui.NET-nativebuild
Cloning into 'ImGui.NET-nativebuild'...
remote: Enumerating objects: 90, done.
remote: Counting objects: 100% (49/49), done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 90 (delta 33), reused 28 (delta 28), pack-reused 41
Receiving objects: 100% (90/90), 22.67 KiB | 967.00 KiB/s, done.
Resolving deltas: 100% (39/39), done.
Submodule 'cimgui' (https://github.com/extrawurst/cimgui) registered for path 'cimgui'
Cloning into 'C:/Users/aybe/source/repos/ImGui.NET-nativebuild/cimgui'...
remote: Enumerating objects: 4058, done.
remote: Counting objects: 100% (789/789), done.
remote: Compressing objects: 100% (306/306), done.
remote: Total 4058 (delta 580), reused 635 (delta 482), pack-reused 3269
Receiving objects: 100% (4058/4058), 9.97 MiB | 16.18 MiB/s, done.
Resolving deltas: 100% (2955/2955), done.
Submodule path 'cimgui': checked out '9cb4b4f63cd41508db8b43ad10f131013669ed7d'
Submodule 'imgui' (https://github.com/ocornut/imgui.git) registered for path 'cimgui/imgui'
Cloning into 'C:/Users/aybe/source/repos/ImGui.NET-nativebuild/cimgui/imgui'...
remote: Enumerating objects: 45919, done.
remote: Counting objects: 100% (127/127), done.
remote: Compressing objects: 100% (65/65), done.
remote: Total 45919 (delta 82), reused 90 (delta 62), pack-reused 45792
Receiving objects: 100% (45919/45919), 87.56 MiB | 21.88 MiB/s, done.
Resolving deltas: 100% (34929/34929), done.
Submodule path 'cimgui/imgui': checked out '682249396f02b8c21e5ff333ab4a1969c89387ad'

Switching to the branch works:
C:\Users\aybe\source\repos\ImGui.NET-nativebuild>git switch additional_libraries
Switched to a new branch 'additional_libraries'
M       cimgui
branch 'additional_libraries' set up to track 'origin/additional_libraries'.

Building the stuff does not work, unfortunately:
C:\Users\aybe\source\repos\ImGui.NET-nativebuild>build-native.cmd
-- Building for: Visual Studio 17 2022
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
-- The C compiler identification is MSVC 19.33.31630.0
-- The CXX compiler identification is MSVC 19.33.31630.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.33.31629/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
CMake Error at CMakeLists.txt:9 (add_library):
  Cannot find source file:

    cimgui/imgui/imgui_tables.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

CMake Error at CMakeLists.txt:9 (add_library):
  No SOURCES given to target: cimgui

CMake Error at CMakeLists.txt:21 (add_library):
  No SOURCES given to target: cimplot

CMake Error at CMakeLists.txt:36 (add_library):
  No SOURCES given to target: cimnodes

CMake Error at CMakeLists.txt:49 (add_library):
  No SOURCES given to target: cimguizmo

CMake Generate step failed.  Build files cannot be regenerated correctly.
Calling cmake --build . --config Debug
CMake is re-running because C:/Users/aybe/source/repos/ImGui.NET-nativebuild/build/x64/CMakeFiles/generate.stamp dependency file is missing.
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
-- Configuring done
CMake Error at CMakeLists.txt:9 (add_library):
  Cannot find source file:

    cimgui/imgui/imgui_tables.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

CMake Error at CMakeLists.txt:9 (add_library):
  No SOURCES given to target: cimgui

CMake Error at CMakeLists.txt:21 (add_library):
  No SOURCES given to target: cimplot

CMake Error at CMakeLists.txt:36 (add_library):
  No SOURCES given to target: cimnodes

CMake Error at CMakeLists.txt:49 (add_library):
  No SOURCES given to target: cimguizmo

CMake Generate step failed.  Build files cannot be regenerated correctly.

By looking at the folder, cimgui/imgui/imgui_tables.cpp does not exist.
So, next, I've followed the instructions in repository README to initialize submodules:
C:\Users\aybe\source\repos\ImGui.NET-nativebuild>git submodule update --init
Submodule 'cimguizmo' (https://github.com/cimgui/cimguizmo.git) registered for path 'cimguizmo'
Submodule 'cimnodes' (https://github.com/cimgui/cimnodes.git) registered for path 'cimnodes'
Submodule 'cimplot' (https://github.com/cimgui/cimplot.git) registered for path 'cimplot'
Cloning into 'C:/Users/aybe/source/repos/ImGui.NET-nativebuild/cimguizmo'...
Cloning into 'C:/Users/aybe/source/repos/ImGui.NET-nativebuild/cimnodes'...
Cloning into 'C:/Users/aybe/source/repos/ImGui.NET-nativebuild/cimplot'...
Submodule path 'cimgui': checked out 'ccdae842e40f35ebf40167918175deb9af8c2a16'
Submodule path 'cimguizmo': checked out 'fcf76e389ef7e88bcf05340b14d031e1111caf32'
Submodule path 'cimnodes': checked out 'e7d42e5e8bcd8b7307a8faf6961d64296d3c9408'
Submodule path 'cimplot': checked out '43e46831c58c85a16bff1f460121baae2bf7f96c'

C:\Users\aybe\source\repos\ImGui.NET-nativebuild>git submodule update --remote
Submodule path 'cimgui': checked out '9ce2c32dada1e1fcb90f2c9bab2568895db719f5'
Submodule path 'cimguizmo': checked out '993ac0e192800c16c4ad60b249e8a4bb446047ed'
Submodule path 'cimnodes': checked out 'bf28b4d00878a9d81a9b9dc8c2d2a8412482f9de'
Submodule path 'cimplot': checked out 'ff39c9236c4d37bbccacbc7aa92a5af670f53c46'

These do work but cimgui/imgui/imgui_tables.cpp is still nowhere to be found and thus, build-native.cmd fails again.
Following your next step suggesting to look at https://github.com/mellinoe/ImGui.NET/pull/218#issuecomment-801475327, I'm greeted with the following:

Artifacts older than 1 month are automatically deleted.

So yeah, the binaries are long gone since it's been a while they've been published...
Any ideas to get hold of ImPlot binaries are more than welcome.
Thanks for your time!

When looking at https://github.com/TillAlex/ImGui.NET-nativebuild on the branch additional_libraries with the web interface of github, it is possible to see that imbui_tables.cpp is present, so that should not happen.
You could try using checkout instead of switch for accesing the branch (and then use git submodule update --init --recursive) before calling cmake

Yes, TillAlex fork is really outdated by now...
Unless I'm mistaken, yesterday's commit indeed does include changes to the managed side of implot but unfortunately still no cimplot.dll.
I've just forked cimplot in order to build it by myself and see how it goes🤞

Can you please just make a nuget package for them? I am really new to git and would definitely mess up in attempting to build and link everything myself. Having a nuget package for the other libraries would be a massive help for me and others.

Seconding the request for this. Installing the C++ tooling required to get the cimplot library built and referencing everything correctly is sufficiently complicated compared to pulling it down from Nuget.

Would be really good to have it. Also, as Silk.NET.OpenGL.Extensions.ImGui already uses Imgui.NET, replacing the libraries makes a mess


Reject DTag transfers

Feature description
Currently, during the DTag transferring process, there is no way for a user to reject a DTag request. This, together with the fact that trades are kept "suspended" if the sending user's DTag changes, can cause strange situations.
Let's consider the situation in which Alice has DTag first and Bob wants it. Then this happens:

Bob sends a request to Alice for her DTag.
Alice changes her DTag to second.

In this case the following would occur:

The initial Bob's request cannot be accepted anymore since Alice has changed her DTag.
Bob cannot send a new DTag request to Alice since the request is already opened.
Bob cannot delete the initial request to open a new one.

Implementation proposal
In order to solve this problem, I think we should implement the following processes:

If Alice's DTag changes, all the requests made towards her should be deleted.
Once that Alice accepts a DTag request, all requests made towards her should be deleted.

Also, we should implement two new message types:

MsgCancelDTagRequest
This can be used only by the user who started the request, and it cancels the process by deleting the request itself.
MsgRejectDTagRequest
This can be used only by the user who is asked for their DTag. This also cancels the process.

The 2nd point of the implementation proposal is already implemented.
The system deletes all the Alice and Bob requests after the acceptance of a request.
For everything else I'll start right now!


Popup shows "Vite server did not start"

Hey,
I created a repo from the template as suggested in the readme file, and tried to run this project locally for the first time.
I ran this project in dev mode, but I have an issue, no matter what I do I see "Vite server did not start" on the extension.
If I'm building the extension (using pnpm build) and then I try to load the extension, I can see the popup as shown in the readme file.
How can I solve it?
Edit:
While inspecting the plugin in Chrome devtools, I got the following error:

Thank you

I managed to solve the issue, I downgraded Vite to 2.4.4.