IndexError: tuple index out of range

Hi Jiawei,
I was trying Galore on TinyLlama-1B using the codebase  https://github.com/jzhang38/TinyLlama  on 4* A800-80GB. I encounter the following error:
[rank1]:     optimizer.step()
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/lightning/fabric/wrappers.py", line 74, in step
[rank1]:     output = self._strategy.optimizer_step(
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/lightning/fabric/strategies/strategy.py", line 207, in optimizer_step
[rank1]:     return self.precision.optimizer_step(optimizer, **kwargs)
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/lightning/fabric/plugins/precision/fsdp.py", line 142, in optimizer_step
[rank1]:     return super().optimizer_step(optimizer, **kwargs)
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/lightning/fabric/plugins/precision/precision.py", line 124, in optimizer_step
[rank1]:     return optimizer.step(**kwargs)
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/torch/optim/optimizer.py", line 391, in wrapper
[rank1]:     out = func(*args, **kwargs)
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
[rank1]:     return func(*args, **kwargs)
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/galore_torch/adamw.py", line 96, in step
[rank1]:     grad = state["projector"].project(grad, state["step"])
[rank1]:   File "/mntcephfs/lab_data/zhangyushun/anaconda/tinyllama/lib/python3.10/site-packages/galore_torch/galore_projector.py", line 15, in project
[rank1]:     if full_rank_grad.shape[0] >= full_rank_grad.shape[1]:
[rank1]: IndexError: tuple index out of range

I use galore as you suggested in  torchrun_main.py:
print('using galore')
galore_params = []
target_modules_list = [ "attn", "mlp"]
for module_name, module in model.named_modules():
    if not isinstance(module, nn.Linear):
        continue

    if not any(target_key in module_name for target_key in target_modules_list):
        continue

    print('enable GaLore for weights in module: ', module_name)
    galore_params.append(module.weight)

id_galore_params = [id(p) for p in galore_params]

# make parameters without "rank" to another group
regular_params = [p for p in model.parameters() if id(p) not in id_galore_params]
# then call galore_adamw
param_groups = [{'params': regular_params},
                {'params': galore_params, 'rank': 128, 'update_proj_gap': 200, 'scale': 0.25, 'proj_type': 'std'}]

optimizer = GaLoreAdamW(param_groups, lr=learning_rate)

Any idea why and how to fix it?
Thanks in advance!

do you solve it? i have the same error

do you solve it? i have the same error

not yet

I have some problem as well.

Same problem here, the structure of grouped parameters is:
List[Dict['params'], Dict['params', 'rank', 'update_proj_gap', 'scale', 'proj_type']]
where 'params' is a list of tensors. I'm trying with pretrained models from huggingface.

I found the error. For the projection in a lower rank, you need tensors of dimension 2 (matrix). If parameters of dimension 1 as LayerNorm are added to the galore_params, it would raise the error trying to access the second dimension.
Make sure that ALL the parameters sent to galore_params have a second dimension.

I found the error. For the projection in a lower rank, you need tensors of dimension 2 (matrix). If parameters of dimension 1 as LayerNorm are added to the galore_params, it would raise the error trying to access the second dimension.
Make sure that ALL the parameters sent to galore_params have a second dimension.

do u use the deepspeed and train on multi-node? i just select the attn and mlp modules for galore.

I'm just testing Galore on Local with only Pytorch; this is the function I've been using for grouping the parameters:
`
def galore_parameters(model):
    galore_params = []
    non_galore_params = []
    for name, param in model.named_parameters():

    if 'embeddings' in name and not 'LayerNorm' in name:
        galore_params.append(param)
        continue

    if 'layer' in name and 'weight' in name and not 'LayerNorm' in name:
        galore_params.append(param)
        continue

    if 'classifier' in name and not 'bias' in name:
        galore_params.append(param)
        continue

    else:
        non_galore_params.append(param)

param_groups = [{'params': non_galore_params},
                {'params': galore_params, 'rank': 128, 'update_proj_gap': 200, 'scale': 0.25, 'proj_type': 'std'}]   # 'proj_type': 'std', 'reverse_std','right', 'left', 'full'

for param in galore_params:
    if param.dim() != 2:
        raise ValueError('Galore only supports 2D parameters')

return param_groups

`
Consider the 'model' variable a pre-trained model loaded from Huggingface. I've checked the different layer names with the VSC debugger and set the 'if' statements accordingly, so you should change them for your specific model. For instance, 'classifier' applies only to classification heads on top of Language Models.
The test has been done with RoBERTa.

From my wacky understanding, GaLore only works with nn.Linear().weight.

Actually, it worked for me with the embeddings layers, which are from  nn.Embedding().
I only found the above-mentioned problem when the current layer has only one dimension in its tensors i.e size = [768] instead of [768, 768]

Specifically, the error comes from line 15 in galore_projector.py :
if full_rank_grad.shape[0] >= full_rank_grad.shape[1]:
For the standard projection type it will compare the first and the second dimension of each tensor given in galore_params. You would have the same error in every projection type that compares both dimensions.

I am facing the same issue. I am training using FSDP and use_orig_params=True, FSDP however still flattens the parameters. Has anyone faced this issue before and was able to fix it?


ceph-volume.py: add support for batch refactored code

See https://github.com/ceph/ceph/pull/34740 for the batch changes.
Signed-off-by: Jan Fajerski<EMAIL_ADDRESS>Note that this is backwards compatible. Intention is to backport this to stable-4.0 and newer.

@dsavineau i'm basically -1 on the reason that has led to this PR but I'm afraid we will have to merge this given ceph-volume leaves us no choice.

The sooner we get this fix out to users the lower the chance for friction with this update. I don't think its unreasonable to assume that users will update ceph with and up-to-date ceph-ansible release.

The sooner we get this fix out to users the lower the chance for friction with this update. I don't think its unreasonable to assume that users will update ceph with and up-to-date ceph-ansible release.

as you said, this is assumption only with no guarantee, this is exactly my concern.

The sooner we get this fix out to users the lower the chance for friction with this update. I don't think its unreasonable to assume that users will update ceph with and up-to-date ceph-ansible release.

as you said, this is assumption only with no guarantee, this is exactly my concern.

Perhaps a warning in the changelog could help users and give this more visibility? What do you think big?

The sooner we get this fix out to users the lower the chance for friction with this update. I don't think its unreasonable to assume that users will update ceph with and up-to-date ceph-ansible release.

as you said, this is assumption only with no guarantee, this is exactly my concern.

Perhaps a warning in the changelog could help users and give this more visibility? What do you think big?

adding a note in the changelog won't hurt for sure, but definitely not addressing this concern.
In any case, there's nothing more we can do at the ceph-ansible level so I don't see any reason to block this PR.


Migrate from os.path to pathlib in SVGMobject and other locations

Overview: What does this pull request change?

This pull request changes a number of instances of OS.path to Pathlib objects and functions. In addition, this PR modifies the SVGMobject constructor to accept both a Pathlib object or a string variable pathname its constructor.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

#485 #2685
Further Information and Comments

There is still about 57 other instances of OS.path that still need changes.

Reviewer Checklist

[X] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[X] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section

@Darylgolden just made the changes,  sorry about the wait!

Except the context manager thing though, that should be changed before merge imo since it seems unnecessary.

Running the sample code in the manual, it reports an error: SGMobject object has no attribute 'file_path', please help, thank you!
Manim version: Manim Community v0.16.0.post0

When running the SGMobject Example code in the manual, I always get an error: SGMobject object has no attribute 'file_path'.
Manim version: Manim Community v0.16.0.post0
Ask for help, thanks!


Short name and custom printer columns for the ClusterDeployment CRD

Adds the cd short name to the ClusterDeployment CRD so that we can do kubectl get cd.
Adds baseDomain and status.installed as custom printer columns so that the printer output looks like
$ kubectl get cd
NAME     BASEDOMAIN                                INSTALLED   AGE
ffranz   ffranz-cluster-deployment.openshift.com   false       4m7s

@csrwng @dgoodwin makes sense?

/test e2e

@ffranz it won’t pass e2e until #228 merges. I was hoping it would have merged by now. But for whatever reason it just says “in merge pool”

/test e2e

/retest

@fabianofranz looks like you need to rebase

/retest

/lgtm


Autocomplete for JavaScript (Neovim)

Hi there, I just bough Kite Pro and start to use it on my IDE (Neovim). Python is working great so far, but I can't get JavaScript to work for some reason. Can you guys help me out?
JavaScript is 90% of my work related language, and I would like to make this work as showing on the example below:
https://www.kite.com/javascript/
Thanks
-- Henry

@henryoliver , JS support for VIM is on its way and should be released next week.
https://github.com/kiteco/vim-plugin/pull/279 contains the changes and details how to enable when it's released.

Great @jansorg! How about Copilot?
Kite suggests JavaScript completions as you code in your editor. However, the Copilot does not have JavaScript docs.

By the way, congratulations on the awesome job you guys did on this tool. If that works I'm even considering drop entirely my current autocompletion plugin and my offline documentation tool. And of course, spread the word. :)
Thanks again!
-- Henry

@henryoliver Kite has supported JS for a few months now so I'm going to close this.  Please open a new issue if you have any further problems.  Thanks!


Bug 2090135: Propagate correct error message for an invalid index

Description of the change:
Propagate correct error message when an invalid index image is provider by the user that does not exist.
Motivation for the change:
With this fix, the error below would be as below:
▶ ./build/operator-sdk run bundle quay.io/olmqe/k8sstatus-bundle:v4.10 --index-image quay.io/kakatest/kkkkk:test
FATA[0005] Failed to run bundle: error determining whether index "quay.io/kakatest/kkkkk:test" is FBC or SQLite based: get index image labels: error pulling image quay.io/kakatest/kkkkk:test: error resolving name : unexpected status code [manifests test]: 401 UNAUTHORIZED
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

/cherry-pick v1.22.x


Angular 15, build failing "Cannot read properties of undefined (reading 'file')"

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
14.2.10
Description
Building a new Angular 15.2.9 project via @angular/cli fails.
Minimal Reproduction
ng build --configuration=production
Exception or Error
No response
Your Environment
Angular CLI: 15.2.8
Node: 16.13.0
Package Manager: npm 8.1.4
OS: win32 x64

Angular: 15.2.9
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1502.8
@angular-devkit/build-angular   15.2.8
@angular-devkit/core            15.2.8
@angular-devkit/schematics      15.2.8
@angular/cli                    15.2.8
@schematics/angular             15.2.8
rxjs                            7.8.1
typescript                      4.9.5

Anything else relevant?
No response

@meraj-markettime are you using Azure DevOps.
We are getting this issue on Angular 15 and Angular 16 builds.

no we are using AWS and Bitbucket pipelines

This seams to be related to https://github.com/angular/angular-cli/issues/25496

I just added this to package.json
"overrides": {
"@babel/traverse": "7.22.6"
}
As suggested here -
https://github.com/babel/babel/issues/15752

We are having the same problems. The same errors in angular 15 and 14. In new clean projects happends the same.

Duplicate of https://github.com/angular/angular-cli/issues/25496


npx zenstack generate doesn't work, maximum call stack errors.

I tried to add ZenStack to my existing NextJS project. It's brand new with create-next-app@latest.
All I do is run these 2 commands and it fails.
npx zenstack@latest init
Installing package<EMAIL_ADDRESS>with npm

added 121 packages, and audited 856 packages in 5s

200 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
Installing package "<EMAIL_ADDRESS>with npm

up to date, audited 856 packages in 1s

200 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
Sample model generated at: schema.zmodel

Please check the following guide on how to model your app:
    https://zenstack.dev/#/modeling-your-app.

Project initialized successfully!

npx zenstack generate

An unexpected error occurred:
 RangeError: Maximum call stack size exceeded
    at Rule.get (/Users/david/Developer/new-tech/node_modules/langium/node_modules/@chevrotain/gast/lib/src/model.js:46:23)
    at NonTerminal.get (/Users/david/Developer/new-tech/node_modules/langium/node_modules/@chevrotain/gast/lib/src/model.js:75:44)
    at block (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:68)
    at atom (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:130:16)
    at /Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:87
    at arrayMap (/Users/david/Developer/new-tech/node_modules/lodash/_arrayMap.js:16:21)
    at map (/Users/david/Developer/new-tech/node_modules/lodash/map.js:50:10)
    at block (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:61)
    at atom (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:130:16)
    at /Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:87

An unexpected error occurred:
 RangeError: Maximum call stack size exceeded
    at Rule.get (/Users/david/Developer/new-tech/node_modules/langium/node_modules/@chevrotain/gast/lib/src/model.js:46:23)
    at NonTerminal.get (/Users/david/Developer/new-tech/node_modules/langium/node_modules/@chevrotain/gast/lib/src/model.js:75:44)
    at block (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:68)
    at atom (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:130:16)
    at /Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:87
    at arrayMap (/Users/david/Developer/new-tech/node_modules/lodash/_arrayMap.js:16:21)
    at map (/Users/david/Developer/new-tech/node_modules/lodash/map.js:50:10)
    at block (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:61)
    at atom (/Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:130:16)
    at /Users/david/Developer/new-tech/node_modules/chevrotain-allstar/lib/atn.js:185:87

I'm on macOS if that matters.

I did some research and it might be a specific issue with ARM based Macs.
https://github.com/lovell/sharp/issues/3944
Someone had this error only on an arm Mac with Sharp

HI @daveycodez , could you help check the versions of "langium" and "chevrotain*" in your project? I suspect it's due to a version mismatch.
npm ls langium
npm ls -a | grep chevrotain

npm ls langium
npm ls -a | grep chevrotain
<EMAIL_ADDRESS>/Users/david/Developer/new-tech
└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  └──<EMAIL_ADDRESS>
│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├─┬<EMAIL_ADDRESS>│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ ├─┬<EMAIL_ADDRESS>│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ ├──<EMAIL_ADDRESS>│ │ │ ├──<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├──<EMAIL_ADDRESS>deduped invalid: "~10.4.1" from node_modules/chevrotain-allstar
│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├─┬<EMAIL_ADDRESS>│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ ├─┬<EMAIL_ADDRESS>│ │ │ │ ├──<EMAIL_ADDRESS>deduped
│ │ │ ├──<EMAIL_ADDRESS>│ │ │ ├──<EMAIL_ADDRESS>npm error code ELSPROBLEMS
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/@emnapi/core
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/@emnapi/runtime
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/@tybys/wasm-util
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/fs-monkey
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/memfs-browser
npm error extraneous<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/memfs
npm error invalid<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/@types/react
npm error invalid<EMAIL_ADDRESS>/Users/david/Developer/new-tech/node_modules/chevrotain
npm error A complete log of this run can be found in: /Users/david/.npm/_logs/2024-12-20T01_53_11_261Z-debug-0.log

Thanks for sharing this. It seems there're two versions of chevrotain installed, but I couldn't reproduce the issue locally after installing both. Do you have a sharable repro project?


fix typo 'AUTHOR' to 'AUTHOR_EMAIL'

fix typo of setup_cfg.py of package

Thank you so so so much!!!


Fix case-sensitivity for ChangeLog in readme.md

Updates 'ChangeLog' case-sensitivity in readme to match 'CHANGELOG.MD' filename
Before

Directs to using https://github.com/EvotecIT/PSWriteHTML/blob/master/ChangeLog.md

After

Direct to https://github.com/EvotecIT/PSWriteHTML/blob/master/CHANGELOG.MD

Thank you. Wasn't aware it's case-sensitive ;) Or maybe I renamed it


Cat gif example broken (api key banned)

The two cat gif examples are based on REST api request to giphy.com. The hardcoded key in use is "banned".
https://github.com/JordanMartinez/purescript-cookbook/blob/3bbeca8bfe23d73a5c02d978b1a47286a22df262/recipes/CatGifsReactHooks/src/Main.purs#L72
{
      "data": [],
      "meta": {
        "status": 403,
        "msg": "BANNED",
        "response_id": ""
      }
    }

It might work to create a new key and see how long it'll work. Depends on why the key was banned (revoked, because checked in a repository, because too many requests).

Hm, from what I remember, the API key was copied from the elm-lang.org/examples/cat-gifs example. I see that URL now re-directs to a different example for fetching quotes, and the cat GIFs example is missing. Maybe we should just replace the cat GIFs recipes with quotes recipes to keep parity with the Elm examples?

Also, looks like there's a stale comment in the README for that recipe from when it was broken for a different reason 😅 https://github.com/JordanMartinez/purescript-cookbook/blob/ed4b2c68cda476d1373a56ab177f570c2286f026/recipes/CatGifsReactHooks/README.md?plain=1#L5

Maybe we should just replace the cat GIFs recipes with quotes recipes to keep parity with the Elm examples?

It looks like they're hosting the quotes API and blocking cross-origin requests, so maybe we just need to find a free alternative that doesn't require API key / rate-limit requests. Something like https://dog.ceo/dog-api/documentation/random?

Cat gif elm links are broken also. They point to quotes example.

Could be a good first contribution if you're up for it @jgarte 🙂 . If not I can probably get around to fixing this sometime over the next couple weeks. Seems like we could just fetch a random dog image from dog.ceo.


Memory leak in Wgpu backend

Describe the bug
Memory leaks when using the Wgpu backend, but not when using the NdArray backend.
To Reproduce
A minimal reproduction is available at https://github.com/joshhansen/burnleak.
Check out the repository and cargo run --release on the master branch. Watch the memory usage. In my case, it climbs steadily upward at a rapid pace.
Then check out the master_ndarray branch and run it again. In my case, the memory usage does not climb.
Running on Wgpu but with the WgpuDevice::Cpu device slows but does not eliminate the memory leakage.
Expected behavior
The program should run without a memory leak on the Wgpu backend like it does on the NdArray backend.
Screenshots
n/a
Desktop:

OS: Linux Mint 21.3, kernel 6.5.0 x86_64
Burn: 0.13.2
Rust: 1.76.0
Nvidia driver 545.29.06-0ubuntu<IP_ADDRESS>

Additional context
Heaptrack memory leak profile:

I'm experiencing the same leak when I upgraded from burn 0.12 to burn 0.13.
I tried your repro repo using burn 0.12 as a dep and there is not an aggressive leak, so it seems like a regression.

This is what I saw with my personal hobby project monitoring

Thanks for the quick repro @kurtlawrence . I can confirm that downgrading to 0.12.1 results in much better memory usage - there are still leaks coming from wgpu but less by an order of magnitude. (82.6 MB leaks on 1.4 G of heaptrack samples vs. 2.1 GB of leaks on 626 MB of heaptrack samples)

I've been working on the memory management strategy currently implemented in the wgpu runtime on the master branch. The current approach results in higher average memory usage, which is intentional. The new strategy is designed to be lazier in freeing unused memory and more aggressive in reusing it. For dynamic memory workloads, this can lead to performance improvements of up to 60%.
Our assumption is that for most deep learning use cases, the GPU device will be primarily dedicated to the training or inference tasks being performed. Therefore, we've prioritized better performance at the cost of higher average memory usage. While we don't believe this strategy leads to significantly higher peak memory usage or more frequent out-of-memory situations, we recognize that this could be a potential issue.
If average memory usage is a concern, we could consider adding an option for users to configure the memory management behavior in the wgpu runtime.

@kurtlawrence Is it CPU RAM leakage or GPU memory?

@kurtlawrence Is it CPU RAM leakage or GPU memory?

CPU RAM leaking

@mepatrick73 The issue is not the level of memory usage, it's that the memory usage grows without bound. Eventually it would consume all system memory if I didn't terminate the program. I have 128GB system RAM and 4 GPUs with 48 GB VRAM. The task in my case is inference on a small model - each instance consumes 28 MiB of VRAM as per nvidia-smi.


Add telecom=exchange tag

This would make #23 much easier to solve

I add following to the list :
telecom=connection_point
telecom=distribution_point
telecom:medium=*

I add following to the list :
telecom=connection_point
telecom=distribution_point
telecom:medium=*

I concur. Would be great to see those included on the map.

Here is a demonstration with exchanges and connection_points in Orleans, France.
http://map.infos-reseaux.com/#12.4/47.8994/1.94604
Source is available : https://github.com/flacombe/oim-web/blob/master/src/style/style_oim_telecoms.js
Orange is for copper and green for fibre medium (telecom:medium key).

Wow, that's great, thanks for the link. Much better map representation for my purpose (mapping of fibre cabinets).

This is actually now being imported, I just need to render them. Hopefully that'll happen soon, it's a bit hectic here at the moment.

That's good news @russss
@MrPozor In which area are you mapping fibre cabinets?
Interested in feedbacks regarding proposed tagging

The ones in Villenave d'Ornon in France have been created by me:
http://map.infos-reseaux.com/#15.24/44.766423/-0.553253


Property page save bug. Issue 1265

Customer scenario
Editing profiles on the debug page can change the active profile, however, the debug drop down does not reflect the change. Thus when they run their application they think that are running say, profile1, when in fact they are running profile 2.
Bugs this fixes:
https://github.com/dotnet/roslyn-project-system/issues/1265
Workarounds, if any
The workaround is to change the selection in the debug dropdown however, it is not obvious that is the problem.
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
Low.  A simple change to the save function to keep the active profile stable. Only affects saving profiles
Performance impact
None. One or two small comparisons on save.
Is this a regression from a previous update?
Regression caused by the feature to make the debug property page extensible.
Root cause analysis:
Added units to cover this scenario.
How was the bug found?
Adhoc testing of the web debug page changes

Tagging @MattGertz for shiproom consideration.

I added the label prematurely.  @BillHiebert, how did we discover this, and how many customers do we think this will impact?

We were adhoc testing the web extensions to the page when this was discovered.  As to how many customers,, it is hard to say. Anyone who switches to a different profile in the property pages could run into it. I know Bala was very confused when he got in this state and wasn't sure what was going on since people expect whatever is in the debug dropdown to be the thing that is run.

@BillHiebert @natidea @srivatsn So let's take this, but let's make sure that the ASK template indicates the lack of data -- let's set it to "bar check."  I think this is an issue that will highly confuse people and keep them from using profiles (and hence reduce the usefulness of the functionality), which is why I initially tagged it to begin with, but without data it will be hard to make the case.  Let's see what JoC says; he may ask us to polla few customers.

Approved to merge via 371312

@BillHiebert please merge this in when ready


Have the keyless cosign sign flow use a single 3LO.

With this change, the keyless flow builds a single signer for all of the images, which means a single key and 3LO for all of the references we sign:
$ COSIGN_EXPERIMENTAL=true cosign sign ghcr.io/mattmoor/controller ghcr.io/mattmoor/webhook
Generating ephemeral keys...
Retrieving signed certificate...
Your browser will now be opened to:
https://oauth2.sigstore.dev/auth/auth?REDACTED
Successfully verified SCT...
tlog entry created with index: 693418
Pushing signature to: ghcr.io/mattmoor/controller:sha256-b10f4b2e04cde2e799e080068f162ef668c4db3099382798b5fe1a208023105d.sig
tlog entry created with index: 693420
Pushing signature to: ghcr.io/mattmoor/webhook:sha256-ed1b1c778685ae0739cd4c6354fa2d724351b01e998a019d1ddc2909c377483d.sig

Fixes: https://github.com/sigstore/cosign/issues/658
Signed-off-by: Matt Moore<EMAIL_ADDRESS>cc @dekkagaijin @dlorenc

LGTM once e2e_test.go is updated

Whoops done

Also once the latest commit is signed off on 😮💨

Whoops


double check there's no security stuff hanging out

it'd be bad to get pwned.
alternatively, see if websockets tolerates htaccess

refactor made webui RO, should be fine


cacerts.pem breaks ServerNameIndication for LetsEncrypt

When using the cacerts.pem file from this gem as the ENV['SSL_CERT_FILE'] (which is what many people who develop on Mac or Windows do to get SSL working, SNI will no longer work for the LetsEncrypt Certificates.
For instance in a Rails 4 app:
config/initializers/some_initializer.rb:
cert_path = Gem.loaded_specs['google-api-client'].full_gem_path+'/lib/cacerts.pem'
ENV['SSL_CERT_FILE'] = cert_path

which resolves to this (in my case I installed the gem to vendor/bundle):
"/home/user/appname/vendor/bundle/ruby/2.3.0/gems/google-api-client-0.11.1/lib/cacerts.pem"
After this trying to make HTTPS calls against certs provided by LetsEncrypt which require SNI (such as multiple ssl vhosts on one IP address) will throw this exception:
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=error: certificate verify failed

The bundle included here is intended only for connected to Google APIs.


Fix scroll progress percent

Scroll percent fix

The scroll progress was returning the wrong value when reach the bottom off element;

   /* - */  return this.options.scroll_top / (rows.length * this.options.item_height) * 100 || 0;
   /* + */  return this.options.scroll_top / (self.scroll_elem.scrollHeight - self.scroll_elem.clientHeight) * 100 || 0;

"The scroll progress was returning the wrong value when reach the bottom off element"
Hello, do you have demo reproducing the problem?

take a look
https://codepen.io/FeehGb/pen/wvgzjRj

I realized that opts.item_height = node.offsetHeight return wrong height;
I fixed height 30px; offeset height return 31px; I dont know why
In my file i created the item_height as options to fix it;


Missing dictionary for cs_CZ

AFAIK the last time I looked there wheren't czeck dictionaries available with OpenOffice. As their dictionaries are the base of the libs dictionaries I didn't include them.
As I'm currently on holiday I'll see to it as soon as Inreturn to a decent internet connection.
Should you find a dictionary I'd be more than happy for either a pulltequest or a hint to where to find them ;)
Cheers

Yes, I have dic file, but how should I make ini file?

I'm not sure currently. It's been a while since I wrote that. I'll have to dig through some code. Gimme a day please!

Finally :simple_smile:

Put the .dic file into the folder src/Org/Heigl/Hyphenator/share/files/dictionaries.
Take care that the filename of the .dic-file starts with hyph.
Call php tools/renderDicts

The last call should render all dictionaries into PHP-Files.
You might have to have a look at the renderDicts-Script and adapt that. It basically calls the Dictionary::parseFile-method.
I'd be absolutely happy when you could provide a PR at least with the dic-file in the appropriate folder. Please also quote the source of the file in the PR.
Thanks for your contribution!

I have created PR #28.


crypto/cipher: wasm: Cannot perform Construct on a neutered ArrayBuffer

I update the js/wasm builder from v8 to v12 and we now see:
https://storage.googleapis.com/go-build-log/643472f1/js-wasm_8d578b31.log
##### Testing packages.
ok  	archive/tar	5.361s
ok  	archive/zip	19.521s
ok  	bufio	5.000s
ok  	bytes	33.349s
ok  	compress/bzip2	1.545s
ok  	compress/flate	6.292s
ok  	compress/gzip	5.855s
ok  	compress/lzw	3.224s
ok  	compress/zlib	4.874s
ok  	container/heap	4.244s
ok  	container/list	4.117s
ok  	container/ring	4.176s
ok  	context	4.445s
ok  	crypto	3.836s
ok  	crypto/aes	3.900s
--- FAIL: TestXOR (0.24s)
panic: JavaScript error: Cannot perform Construct on a neutered ArrayBuffer [recovered]
	panic: JavaScript error: Cannot perform Construct on a neutered ArrayBuffer

goroutine 21 [running]:
testing.tRunner.func1(0x468f00)
	/workdir/go/src/testing/testing.go:830 +0x38
panic(0x4b6c0, 0x181e020)
	/workdir/go/src/runtime/panic.go:619 +0x20
syscall/js.Value.New(0x7ff800030000000d, 0x441dc8, 0x3, 0x3, 0x20)
	/workdir/go/src/syscall/js/js.go:357 +0x37
syscall/js.typedArrayOf(0x20340, 0x1810680, 0x29e00)
	/workdir/go/src/syscall/js/typedarray.go:85 +0x3d
syscall/js.TypedArrayOf(0x20340, 0x1810680, 0x1a4)
	/workdir/go/src/syscall/js/typedarray.go:57 +0x2
crypto/rand.(*reader).Read(0x2390a0, 0x181c1c0, 0x1a4, 0x1a4, 0x1a4, 0x0, 0x0)
	/workdir/go/src/crypto/rand/rand_js.go:23 +0x3
io.ReadAtLeast(0x80a00, 0x2390a0, 0x181c1c0, 0x1a4, 0x1a4, 0x1a4, 0x1a4, 0x0, 0x0)
	/workdir/go/src/io/io.go:310 +0x6
io.ReadFull(...)
	/workdir/go/src/io/io.go:329
crypto/cipher_test.TestXOR(0x468f00)
	/workdir/go/src/crypto/cipher/xor_test.go:28 +0x28
testing.tRunner(0x468f00, 0x63528)
	/workdir/go/src/testing/testing.go:865 +0xe
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:916 +0x2d
FAIL	crypto/cipher	4.573s
ok  	crypto/des	4.177s
ok  	crypto/dsa	4.368s
2019/05/02 22:01:34 Failed: exit status 1

Error: tests failed: dist test failed: go_test:crypto/cipher: exit status 1

Looks like the failure is actually from crypto/rand.

Another case of #31702 needing similar fix as https://go-review.googlesource.com/c/go/+/174304 ?

This is continuing to cause trybot failures for people elsewhere, most recently via crypto/x509 tests.
/cc @cherrymui @neelance


Remove jank

This PR fixes a lot of the jumping around and redrawing of the page when saving, publishing and rebuilding projects in autotune and fixes notifications occasionally overlapping the header.
Lots of visual bugfixes to the UI:

Views are now re-rendered using virtual dom, so instead of redrawing the entire page, we're applying a patch to change affected parts.
The app now checks to see if there are any displayed notifications before moving the header back up into place.
App no longer saves and updates scroll position between renders, because its no longer necessary.
The project edit view no longer recreates the alpaca form, pym preview and json editor on every page refresh, making it much faster.
Fix bug which prevents project page from rendering for bespoke projects.

@kavyasukumar and @yurivictor can you review?

👍


Unhandled Rejection (TypeError): (0 , _styledComponents.createGlobalStyle) is not a function

Hi, i'm try to install react-trello, but i got a error when i run yarn start
I installed with yarn: $ yarn add react-trello

Package.json:     "react": "^16.12.0"
code:
import React from 'react';
import Board from 'react-trello';

const Trello = () => {
  const data = {
    lanes: [
      {
        id: 'lane1',
        title: 'Planned Tasks',
        label: '2/2',
        cards: [
          {
            id: 'Card1',
            title: 'Write Blog',
            description: 'Can AI make memes',
            label: '30 mins',
            draggable: false,
          },
          {
            id: 'Card2',
            title: 'Pay Rent',
            description: 'Transfer via NEFT',
            label: '5 mins',
            metadata: { sha: 'be312a1' },
          },
        ],
      },
      {
        id: 'lane2',
        title: 'Completed',
        label: '0/0',
        cards: [],
      },
    ],
  };

  return <Board data={data} />;
};

export default Trello;

```jsx

Somebody can help-me ?

PS: I'm not fluent english yet

I also ran into this problem. Solved by installing the module npm i styled-components --save in my dependencies

I was running a missing context by styled-componets as well. installing styled as dependencies solved.


Initializing two dbContext data failed

when I initialized two dbcontext data ,it throw exception at the method of dbcontext's SaveChanges().
like that:
{"Table 'XXXXXX' was not found. The database was probably not initialized.\r\n\r\nIf using CodeFirst try to add the following line:\r\ncontext.Database.CreateIfNotExists()"}

Hi leewangq - sorry for the late response. Can you provide a little proof of concept code for your problem. Unfortunately this isn't going to be enough for me to reproduce.

sorry for the late response, I found the error was not caused by Effort, it was my framework's error, sorry for
that!

Hello @Jon,
This issue will be closed since it has been resolved by yourself ;)
Best Regards,
Jonathan

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus •  LinqToSql Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function


custom timeout on dump/create

I have a large database that takes more than 60 seconds to backup.
Is it possible to add custom timeout to prevent this to happen?
For now i have to edit manualy DumpController.php to change this...
Offending line : 73 version: 2.2.1.
By the way: great job!

Thank! So good? https://github.com/Beaten-Sect0r/yii2-db-manager#advanced-config

            // Process timeout
            'timeout' => 3600,


Can't build on ghc 7.8

I'd like to use this library but i need support at least ghc-7.8, currently build on ghc-7.8 result in errors like this:
src/TypeFun/Data/Peano.hs:16:30:
    Can't make a derived instance of ‘Typeable N’:
      You need DeriveDataTypeable to derive an instance for this class

It can be easily fixed by enable DeriveDataTypeable.
If you're willing to add dependency on type-compat, then we can even get gcc-7.6 support, i'd like to make a pr and setup travis to monitor building. Is this plan ok to you?

The simplest solution to make it build on ghc-7.8  is adding DeriveDataTypeable to cable file, since this doesn't require release new version. Can you please update cabal information on hackage when you get time?

I have fixed type-fun to work with ghc-7.8.4, it is in master now. You can add travis support and try to make it work with ghc-7.6 if you with, but I am not sure it is posible. I am using stack and it does not support ghc-7.6 so I can not check workability with old compillers. Also, supporting old compillers is not a primary feature for this experimental library and may be broken for some reasons.

thanks！please make a release ；）

http://hackage.haskell.org/package/type-fun-0.1.0
done.


cluster environment

when using node-cache in a clustered environment. obviously, it will create n number of caches based on how many forks we create. i am trying to look for a way for the forked processes to just use one cache, the initial idea is to instantiate the cache on cluster.js and try to send the cache to the forks by using worker.send. the problem here is
var string = JSON.stringify(message) + '\n';
                      ^
TypeError: Converting circular structure to JSON
    at Object.stringify (native)
    at ChildProcess.target._send (child_process.js:479:23)
    at ChildProcess.target.send (child_process.js:416:12)
    at Worker.send (cluster.js:64:21)

Of course one could think about this and let Node.js handle the propagation of all inserts/updates and deletes to the clustered environment. I guess that using a shared local memcached instance is the way to go here. Maybe it's a bit slower than Node but so much less headache.

I've got a work in progress wrapper for just this - please try it out and let me know how you get on
http://github.com/lvx3/cluster-cache

I had a similar problem and wrote a wrapper for lru-cache to handle clustered environments using a cache on the master thread and IPC calls from the workers. Here is a link in case it's helpful to anyone else: https://www.npmjs.com/package/lru-cache-for-clusters-as-promised

Closed due to inactivity.


Disable transaction syncing by default

Reverse the spring profile so that lost transaction syncing is off by default.
This will reduce load on a regular startup and only needs to be enabled under known conditions, in which case it can be started.
Part of https://github.com/jpmorganchase/tessera/issues/609

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #634   +/-   ##
=========================================
  Coverage     99.42%   99.42%
  Complexity     1863     1863
=========================================
  Files           289      289
  Lines          5782     5782
  Branches        273      273
=========================================
  Hits           5749     5749
  Misses            5        5
  Partials         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f54da...b5d6d76. Read the comment docs.


improvements on StampChangelogAction

Stamps section identifier with version instead of git tag
Reverses order of tags in diff link for bitbucket links

In my case, version and git tags were in the following format:
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
When applying a stamp with version: <IP_ADDRESS>.beta and git_tag: v.<IP_ADDRESS>.beta the changelog should look like:
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta
[<IP_ADDRESS>.beta]: https://bitbucket.org/.../compare/v.<IP_ADDRESS>.beta..v.<IP_ADDRESS>.beta

Thanks for contribution @sthwicked 2 things here:

could you please rebase onto master, which should fix the failing build
I would appreciate unit tests for your changes - both to ensure it works as you expect as well as document the functionality

Thanks for contribution @sthwicked - these changes are released now in version 0.14.0


Fix expired domain egoist.sh in readme

Fixes #7

@egoist seems like a quick win to merge this fix. the sponsors image is also broken in the readme!


[Explore]: Garbage collection

Background
As a Korifi installation gets older and older, some resources will accumulate without ever being cleaned up. This poses a problem, as the cluster will eventually be filled with unused resources.
Which resources could we clean up?

Leaked resources: resources that only make sense together, should be deleted together. Updating or deleting a resource should never result in its owned resources being leaked.
Propagated resources: a propagated resource should be deleted when the original resource is deleted.
Accumulating resources: things like builds/droplets, packages and tasks can potentially accumulate forever even if they're not used, as they're seldom explicitly deleted. We should have retention policies in place for these resources.

Let's:

Evaluate if we still have cases of leaked or propagated resources not being cleanup up properly.
Establish retention policies for accumulating resources:

builds/droplets: fixed number, configurable, 5 by default;
tasks: evaluate either a fixed number policy or a time-based one (it's 1 month by default on traditional CF).

Establish if there are other accumulating resources that I haven't listed above.

Acceptance Criteria
A proposal describing what needs to be done to prevent Korifi from silently accumulating resources over time.
Dev Notes

App Revisions

Root namespace CFUser bindings

Create stories for /v3/users endpoints list/create/delete/get
Don't worry about permission listing CFOrg in root namespace. It's necessary for kubectl users. Could be restricted better with OPA, for example.

Similar for builderinfo & domain, but it's not sensitive information, so needn't be restricted.

Builds / Droplets / Packages

Registry clean up

CF on VMs: cron-style clean up

https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/jobs/runtime/prune_completed_builds.rb
https://github.com/cloudfoundry/cloud_controller_ng/blob/main/lib/cloud_controller/bits_expiration.rb#L22
Runs every night

CF cleans up orphan blobs periodically

kpack does not delete build images when a build is deleted
we could add a finaliser to kpack builds to do that
similarly for packages

Tasks

The reconciler already deletes tasks older than a certain age


Add form plugin

This PR adds the form plugin and a single validation example.  This will allow us to do form field validation in a consistent way.
Message validation on submit
Filling in the form and hitting submit does validation.  Fixes made are updated on blur for a good UX.

Inline validation on blur
Validation can be done on blur.  Errors can also be shown inline with animations consistent with the framework.

Future Iterations
Future PRs will add more support, such as:

[ ] custom prop type validation for the form settings (customPropTypes.optionalShape({...})

Validates settings against valid Semantic UI form() settings

[ ] Generating validation rules from html attributes: minlength='2' => rules: [{type: 'minLength[2]}]
[ ] META extension to include Semantic UI transition types (for use in custom prop validation)
[ ] META extension to include behaviors section
[ ] full set of form validation examples in the designated Behaviors section

Note:
This PR uncovered an error with the Dropdown component.  It is not correctly handling the multiple attribute which also prevents it from being validated.  The Dropdown has been scheduled for reworking for a while, time we get to that I suppose.

Works like a charm! :sheep:


Minting POL token on L1 for the sequencer - max fee per gas less than block base fee

System information
Ubuntu 22.04 amd64
Commit id
af3798e
Description & steps to reproduce
Steps following the deployment of L1 in Sepolia with all configurations and changes mentioned in here
Also below are some more custom changes
"sequencer_type": "erigon",
"consensus_contract_type": "rollup",
"additional_services": ["blockscout"] - for both l1 and l2
"use_dynamic_ports": False,
"deploy_l2_contracts": True,
After the deployment of l1 contracts and granting the aggregator role to the agglayer so that it can also verify batches, it will throw the below error

Desired behavior
l1 deployed in Sepolia and sequence batch from l2
What is the severity of this bug?
Critical; I am blocked and Kurtosis CDK is unusable for me because of this bug.

@praetoriansentry anyb update on the above issue
I am able to deploy everything successfully just due to the above the sequencer does not get deployed and fails

@Sanketbhandari which component are you seeing that error from?
Just from the logs, try increasing the maxFeePerGas in your L1 txn.

@jhkimqd this is happening after contracts are deployed in l1 sepolia
Can you help me show how i can increase maxFeePerGas. I mean any file where i need to change


CVAE example errors

Dear ml5 community,
I found some errors in CVAE example, by @WenheLI and @Derek-Wds .
When I try to run CVAE_QuickDraw on Firefox it logs this error:
modelReady@about:srcdoc:46:21
e.default/</e[n]/<@https://unpkg.com/ml5@0.4.3/dist/ml5.min.js:124:28684
e.default/<@https://unpkg.com/ml5@0.4.3/dist/ml5.min.js:56:26142

On the other hand, running it on Chrome returns this error:
TypeError: cvae.labels is not iterable
    at modelReady (about:srcdoc:46:26)

    at https://unpkg.com/ml5@0.4.3/dist/ml5.min.js:124:28684

    at https://unpkg.com/ml5@0.4.3/dist/ml5.min.js:56:26141

Thanks, @juandspy !
I have inspected this example quickly. It seems that the manifest file is not loaded in this project.
I think it is a problem with the p5editor? cc @joeyklee
Have you tried if this works locally?


Add my personal website to the featured sites

https://grodziski.com

As it says in the readme, if you'd like to add your site, please add it to sites.md, not the readme. Please  open a new PR with the change. Thanks!


InvalidRequestError: Entity namespace for "outofstock" has no property "out_of_stock_item_id"

InvalidRequestError: Entity namespace for "outofstock" has no property "out_of_stock_item_id"
DELETE http://clochette.dev/api/v1/out_of_stock_item/1
Request headers

connection: close
host: clochette.dev
x-real-ip: <IP_ADDRESS>
forwarded: for=<IP_ADDRESS>
x-forwarded-for: <IP_ADDRESS>
x-forwarded-proto: https
x-forwarded-host: clochette.dev
x-forwarded-port: 443
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0
accept: application/json
accept-language: fr,fr-FR;q=0.8,en-US;q=0.5,en;q=0.3
accept-encoding: gzip, deflate, br
referer: https://clochette.dev/docs
origin: https://clochette.dev
dnt: 1
sec-fetch-dest: empty
sec-fetch-mode: cors
sec-fetch-site: same-origin

Request body

Exception traceback
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/sql/base.py", line 1694, in _entity_namespace_key
    return getattr(ns, key)
           ^^^^^^^^^^^^^^^^
AttributeError: type object 'OutOfStock' has no attribute 'out_of_stock_item_id'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/code/app/core/middleware.py", line 28, in dispatch
    return await call_next(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 80, in call_next
    raise app_exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/base.py", line 69, in coro
    await self.app(scope, receive_or_disconnect, send_no_error)
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/usr/local/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.11/contextlib.py", line 222, in __aexit__
    await self.gen.athrow(typ, value, traceback)
  File "/usr/local/lib/python3.11/site-packages/fastapi/concurrency.py", line 36, in contextmanager_in_threadpool
    raise e
sqlalchemy.exc.InvalidRequestError: Entity namespace for "outofstock" has no property "out_of_stock_item_id"

L'erreur vient de la :
https://github.com/Clochette-AbsINThe/clochette/blob/01c9d3add399ce70ac2fcc52e0c0ebfb5f5bd3ce/backend/app/api/v1/endpoints/out_of_stock_item.py#L69
Ça devrait être :
if out_of_stocks.query(db, limit=1, item_id=out_of_stock_item_id):


In the wild found a wav with 0 bits_per_sample in hound that audacity can play.

Someone I work with found a wav file that according to ffmpeg -i used the encoder (may have gone through other tools)
Adobe Premiere Pro CC 2017.1 (Windows)
But hound is returning that is has 0 bit samples.
audacity and ffmpeg can read it, but sox can't. soxi returns
"WAVE file fmt with padded samples is not supported yet"
It appears the extended header has wValidBitsPerSample set to zero. I'm guessing ffmpeg and audacity fall back to wBitsPerSample (16 in this case) when that happens.
It looks to be an easy enough change to hound to have such a fallback. But we've only found one example so far and I don't know if there maybe other reasons not to support that kind of fallback.

Thank you for taking the time to open an issue!
The wValidBitsPerSample field is redundant in most cases, where it is equal to wBitsPerSample, but wValidBitsPerSample can also be smaller than a multiple of 8. 0 bits per sample is silly, so it probably has a different meaning. The field in WAVEFORMATEXTENSIBLE is part of a union, but the docs don't say which value is valid in which case. It could be that Premiere interpreted the field as the wReserved field, which must be 0.
Your suggestion to fall back to the wBitsPerSample if wValidBitsPerSample is zero makes sense to me, and it could be done without breaking any files that are currently supported.
Would you be able to provide a test file for this, to confirm a fix, and to add as a regression test? It should be stripped of most audio data to keep the repository small and also to ensure there is no copyrighted audio in there. A file with ~10 samples or so would be ideal.

The original is about 177MB and I doubt I could share it, I could try to trim it but I suspect any tools I have that accept it would likely "fix" the header in the process. I can try to hexedit one of the current examples and see if it fails the same way on my end.


Exclude fixtures when publishing the crate

If I understand correctly, the fixtures are all used in the integration tests. To reduce unnecessary files (especially for those of us who mirror/vendor third-party crates), it'd be nice if the fixtures (and maybe the tests/examples?) were excluded when publishing. I realize that e.g. excluding examples will not allow a user to run cargo install --examples -- gimli, but I think that's of fairly little use.

I've previously seen feedback that people want to be able to run the tests on the published crate. Is there a common stance in the rust community for including or excluding tests?
It may not be common, but I can imagine people wanting to run cargo install --example dwarfdump gimli.

Ah, if you've had that feedback then I don't see an alternative (aside from downloading the files, either automatically or manually). Though I would be curious why those who say that aren't happy with running tests from a checkout of the repository.
The only sentiment on the matter that I've seen is that when publishing to crates.io, those files are intended to only be for crates.io and package resolution (and notably those files will persist "forever").

How about moving the tests that need these fixtures in a separately published crate?

I think it's fine to exclude fixtures and the tests/benchmarks that need them (which is all of test and benches currently).
I prefer not to exclude examples, but moving them to a separate crate is an option.

Is excluding fixtures enough to meet your immediate need?
For moving the examples, a similar thing was done for the object crate, so my default action would be to do the same thing here, but I'm open to suggestions for better ways to organise things. I think we should also start using object-testfiles for binaries for regression tests.

Yes, excluding fixtures will be sufficient (it cuts the crate size down ~44%).


File histories from commit view

Currently when the file history is requested,  git log runs against the current branch.  Thus if file history is requested for a file from a commit from another visible branch,  the selected commit does not show up in the history.  When the file was added in another branch and was not yet seen in the current branch,  the history view is just empty.
This PR makes the log run against the selected commit,  which makes most sense to me.
Another approach would probably be to find a first parent reference containing current commit and run log against that,  though to me it would be a bit counter-intuitive.

Hi, make sure your target branch for the PR is develop and not master.


Allow search results download

Proposal for #492 (Feature request: Download search results).
On the search page, the multiselect can only select photos, not albums.

It's not planned to add this feature to version 3.1. I will consider merging it after the release.

This PR will be closed because I'm not actively working on Lychee anymore. The repository of Lychee will stay available, but the main development continues under the Lychee Organisation. A fork maintained by the community.


Update regression tests artefacts for marriage-abroad

These differences were caused by
2583d8ec2fd113f5e9a06766d7b9f0cc531d20fd. I should've updated these
artefacts as part of PR #2307 but completely failed to do so. Sorry!

I've merged this despite not having anyone look at it because the risk is minimal and I want to get the regression tests passing again.


How to add support for TCP to ice4j

 Issue by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT
Originally opened as https://github.com/bgrozev/ice4j/issues/11

Hi

I intend to use add support for TCP for ICE[TURN/STUN] in ice4j. Kindly please
provide me some souce code or hint to proceed in order to add support of TCp in
ice4j for TURN and STUN. Kindly please also let me know till when the TCP based
ice4j support would be released.

Regards
Viks

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 Feb 2011 at 7:18

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

Original comment by<EMAIL_ADDRESS>on 24 Feb 2011 at 5:44

Added labels: Type-Task
Removed labels: Type-Defect

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

https://github.com/htwg/UCE is not accessible. Do you know any alternate link?

Original comment by<EMAIL_ADDRESS>on 12 Jun 2013 at 10:48

 Comment by GoogleCodeExporter
Monday Jul 13, 2015 at 21:30 GMT

I may be useful for anybody else that search for TCP for ICE: UCE!
https://github.com/htwg/UCE

Original comment by<EMAIL_ADDRESS>on 16 Apr 2013 at 8:31


AMFinder is not recognizing my photos as "valid archives"

I have the AMFinder downloaded to a HPC and am trying to run a prediction on 18 photos (which I have converted to JPEG images). When I run my command, the software recognizes the photos but comes back with an error saying they are not valid archives.

Hello, thanks for reporting this. The misleading error message is now corrected.
Are you trying to predict intraradical hyphal structures? If so, you first need to predict colonisation and convert your predictions to annotations using amfbrowser. A standard pipeline is as follows:

Predict colonisation with amf predict *jpg. Note: this will create an archive foo.zip next to image foo.jpg.
Convert computer predictions to annotations with the editor (amfbrowser). For instance, run amfbrowser foo.jpg. This requires a graphical environment (it won't work on an HPC).
Predict intraradical structures with amf predict -2 *jpg (or, if you want to specify the trained network to use, the command becomes amf predict -net your_trained_network.h5 *jpg).

Please let me know if that solves the problem. I will add more documentation to the README soon.

Hello,
Thank you for your response to my query. I was attempting to run the
prediction of colonization but the source still is not working even though
I have used the HPC script written on your github resource and assistance
from the IT department at the University of Georgia. I have attached the
command line and response below. I am using JPEG images but the error
states "TypeError: cannot unpack non-iterable NoneType object". I have
tried working with TIFF images and I get the same result. Do the images
need to be in a different format for the prediction? The team that runs the
HPC has the amf browser functioning within an interactive environment but
it is not useful until I have this first step working. Any suggestions you
may have would be greatly appreciated.
[image: image.png]
Best Regards,
Lauren Stupp
On Sat, Jun 12, 2021 at 1:37 AM Schornack lab @.***>
wrote:

Hello, thanks for reporting this. The misleading error message is now
corrected.
Are you trying to predict intraradical hyphal structures? If so, you first
need to predict colonisation and convert your predictions to annotations
using amfbrowser. A standard pipeline is as follows:

Predict colonisation with amf predict *jpg. Note: this will
create an archive foo.zip next to image foo.jpg.
Convert computer predictions to annotations with the editor (
amfbrowser). For instance, run amfbrowser foo.jpg. This requires a
graphical environment (it won't work on an HPC).
Predict intraradical structures with amf predict -2 *jpg (or, if
you want to specify the trained network to use, the command becomes amf
predict -net your_trained_network.h5 *jpg).

Please let me know if that solves the problem. I will add more
documentation to the README soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SchornacklabSLCU/amfinder/issues/9#issuecomment-860003050,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJ2BTPBWVJTQOGHQF6FV2DTSLXCFANCNFSM46RKOJPA
.

Hello,
Sorry to see it is not working yet. For some reason, I cannot access the attachment. Could you please copy/paste the script and error message again? Thanks.

I apologize for the lack of access to the photo. I have copied my script
below. Thank you for your help.
(amfenv) @.*** ~$ /work/jaalab/amfinder-2.0/amf/amf predict
--network CNN2v1.h5 /work/jaalab/LaurenStupp/inputfile/amfindertestfile/*
Using TensorFlow backend.
AMFinder script version 2.0

Input images: 18
Running in prediction mode
Pre-trained network:
/work/jaalab/amfinder-2.0/amf/trained_networks/CNN2v1.h5
Classes: arbuscules (A), vesicles (V), hyphopodia (H), intraradical
hyphae (IH).
Image Snap-1193.jpeg
WARNING: The file
/work/jaalab/LaurenStupp/inputfile/amfindertestfile/Snap-1193.jpeg is not a
valid archive.
Traceback (most recent call last):
File "/work/jaalab/amfinder-2.0/amf/amf", line 61, in
main()
File "/work/jaalab/amfinder-2.0/amf/amf", line 51, in main
AmfPredict.run(input_files)
File "/work/jaalab/amfinder-2.0/amf/amfinder_predict.py", line 231, in run
table, cams = predict_level2(path, image, nrows, ncols, model)
TypeError: cannot unpack non-iterable NoneType object

On Mon, Jun 14, 2021 at 12:56 PM Schornack lab @.***>
wrote:

Hello,
Sorry to see it is not working yet. For some reason, I cannot access the
attachment. Could you please copy/paste the script and error message again?
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SchornacklabSLCU/amfinder/issues/9#issuecomment-860838515,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJ2BTJFDRW4MW7LCBFDDO3TSYYDVANCNFSM46RKOJPA
.

I recommend you re-download the sources, the error message and few other things have been corrected.
Regarding your issue, you are using CNN2v1 which predicts intraradical hyphal structures (arbuscules, vesicles, intraradical hyphae). This won't work if you do not use CNN1 first (either CNN1v1 or CNN1v2). Once CNN1 prediction is done, you will get a file Snap-1193.zip next to Snap-1193.jpeg. Then, follow the steps I described in my previous message.

Thank you! Your suggestion worked perfectly. Such a silly error on my part.
When I am running the graphical interface, I am having trouble uploading
the prediction created by step one. Is this the reason the HPC will not
work with the GUI?
On Mon, Jun 14, 2021 at 1:21 PM Schornack lab @.***>
wrote:

I recommend you re-download the sources, the error message and few other
things have been corrected.
Regarding your issue, you are using CNN2v1 which predicts intraradical
hyphal structures (arbuscules, vesicles, intraradical hyphae). This won't
work if you do not use CNN1 first (either CNN1v1 or CNN1v2). Once CNN1
prediction is done, you will get a file Snap-1193.zip next to
Snap-1193.jpeg. Then, follow the steps I described in my previous message.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SchornacklabSLCU/amfinder/issues/9#issuecomment-860855989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJ2BTKN4RBZERNN24PDALLTSY3CDANCNFSM46RKOJPA
.

Excellent! To load predictions, you just need to run amfbrowser image.jpeg. To display predictions, you need to click on the button Import on the right. Usually, HPC are text-based only so you won't be able to run a graphical interface.

Hello, is your problem solved? Can I close the issue? Thanks.

Hello! Yes, I was able to run through all the steps this morning. Thank you
so much for all of your help.
On Tue, Jun 15, 2021 at 12:51 PM Schornack lab @.***>
wrote:

Hello, is your problem solved? Can I close the issue? Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SchornacklabSLCU/amfinder/issues/9#issuecomment-861664692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUJ2BTMAHSKWH5NCEV7F5MDTS6AKVANCNFSM46RKOJPA
.

You are welcome


Show an error message for invalid queries

e.g. entering o as the SMILES

(also be explicit when there are zero results)

(also be explicit when there are zero results)


⚠ Fetchers has degraded performance

In 576ac7d, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 279 ms

Resolved: Fetchers performance has improved in 2bf3955.


Execute on Start up

Hello,
Is it possible for you to make the malware/client code automatically start upon start up of a victims computer?
Thanks

in windows or linux ?

+)install python 3.10 in windows ( add to path)
+)in cmd type pip3 install pyinstaller && pip install pyinstaller
+)in foler /bot/ open cmd and type pyinstaller --onefile -w Client.py
+)and in folder dist create short cut with Client.exe
+)Finally, move this shortcut to C:\ProgramData\Microsoft\Windows\Start Menu\Programs\StartUp

if the victims computer have python3 installed then you can just rename the client file from client.py to client.pyw and send it to autorun. With .pyw the code will get executed by pythonw.exe which tells python to things in background.
If victims finds the client file then he can easily debug it and find the server ip.

Hey, I've done this in a forked project if you're still after this

can you simply use shutil to add it to the startup directory?


Argb image hdf5 write

Hi Adrian,
As discussed here is the pull request for your reference. I am still in pursuit to check if the contents of the image are correctly converted to ARGB/written as HDF5.

Hi Adrian, Review comments are incorporated and pushed.

Hi @imagejan, since we're on the topic, could you maybe shed some light on one issue I've discovered while testing @ASHISRAVINDRAN's PR.
I've tested the HDF5 export command with big tiff files. I loaded a 20GB tif stack of the shape (548, 3913, 4635) into Fiji with Bio-Formats and tried to export to HDF5. Fiji was silently crashing unfortunately, so I've passed JVM options to do a heap dump on OOM errors. Got the heap dump, analyzed it and it looks like Fiji really tries to load the whole 20GB into memory. I would expect the ImgPlus to stream the stack slice-by-slice internally, but instead it creates a list of 10003840 instances of net.imglib2.img.cell.Cell each containing 1000 shorts (uint16), which is roughly 20GB.

Since I wasn't able to hit (https://github.com/ilastik/ilastik4ij/blob/master/src/main/java/org/ilastik/ilastik4ij/IlastikExport.java#L60) while doing the remote debugging, it seems that this happens internally in one of the pre-processing steps in Fiji, before the command gets executed. I'm pretty sure there is a simple way of streaming the file slice-by-slice, e.g. I can easily be done with the Bio-Formats API:
        IFormatReader reader = new ImageReader();
        reader.setId("/media/Math-Clinic/brainForSegmentationOneSide.tif");

        for (int series = 0; series < reader.getSeriesCount(); series++) {
            reader.setSeries(series);
            for (int image = 0; image < reader.getImageCount(); image++) {
                byte[] bytes = reader.openBytes(image);
                ...
            }
        }

Do you know what needs to be done in order to stream the file slice-by-slice using ImgPlus interface? Thanks

@wolny did you have the image open as a virtual stack, or as a normal image window? It might be an issue with converting between the legacy ImageJ1 structures and your Dataset input.
I'd assume that the work done by @maarzt in https://github.com/imagej/imagej-legacy/pull/182 could help to improve this.

@imagejan thanks for a quick response. Yes, the tiff was opened as a virtual stack with Bio-Formats

So if I understands you correctly: the current Fiji version is internally converting from legacy ImagePlus to the new ImgPlus and that conversion is inefficient... I had a brief look at @maarzt PRs and looks like the (VirtualStackAdapter)[https://github.com/imglib/imglib2-ij/pull/12/files#diff-95c036951492c781899d6982cf00a0ff] would do the job. So when those changes are in the problem will most likely disappear, right?

@imagejan is there a way to work around this issue in currently? I'm asking cause the problem is that even if the user runs the export with the machine with enough RAM, the internal conversion is really slow and there is no indication to the user that it's happening under the hood (neither in UI nor in the console logs). I took a thread-dump while the conversion was running and it seems that it's also done in a single thread. Here's the thread-dump:

"SciJava-2e720162-Thread-1" #32 prio=5 os_prio=0 tid=0x0000000003629000 nid=0x6098 runnable [0x00007fbb6016b000]
   java.lang.Thread.State: RUNNABLE
        at net.imagej.legacy.translate.GrayPixelHarmonizer.updateDataset(GrayPixelHarmonizer.java:124)
        at net.imagej.legacy.translate.GrayDisplayCreator.makeDataset(GrayDisplayCreator.java:120)
        at net.imagej.legacy.translate.AbstractDisplayCreator.getDataset(AbstractDisplayCreator.java:73)
        at net.imagej.legacy.translate.GrayDisplayCreator.grayCase(GrayDisplayCreator.java:160)
        at net.imagej.legacy.translate.GrayDisplayCreator.makeDisplay(GrayDisplayCreator.java:130)
        at net.imagej.legacy.translate.AbstractDisplayCreator.createDisplay(AbstractDisplayCreator.java:64)
        at net.imagej.legacy.translate.DefaultImageTranslator.createDisplay(DefaultImageTranslator.java:101)
        at net.imagej.legacy.translate.DefaultImageTranslator.createDisplay(DefaultImageTranslator.java:85)
        at net.imagej.legacy.LegacyImageMap.registerLegacyImage(LegacyImageMap.java:273)
        at net.imagej.legacy.display.LegacyImageDisplayService.getActiveImageDisplay(LegacyImageDisplayService.java:119)
        at net.imagej.legacy.display.LegacyImageDisplayService.getActiveDataset(LegacyImageDisplayService.java:130)
        at net.imagej.display.process.ActiveDatasetPreprocessor.getValue(ActiveDatasetPreprocessor.java:72)
        at net.imagej.display.process.ActiveDatasetPreprocessor.getValue(ActiveDatasetPreprocessor.java:56)
        at net.imagej.display.process.SingleInputPreprocessor.process(SingleInputPreprocessor.java:85)
        at org.scijava.module.ModuleRunner.preProcess(ModuleRunner.java:105)
        at org.scijava.module.ModuleRunner.run(ModuleRunner.java:157)
        at org.scijava.module.ModuleRunner.call(ModuleRunner.java:127)
        at org.scijava.module.ModuleRunner.call(ModuleRunner.java:66)
        at org.scijava.thread.DefaultThreadService$3.call(DefaultThreadService.java:238)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

Sorry, I fear I'll be not of much help here. Is it required to have the image open as virtual stack? Or could you simply get the file location (either as a @Parameter File, or by asking the VirtualStack for its backing file(s)) and then use DatasetService or IOService to get the ImgPlus from disk, to avoid the legacy environment? It might require to explicitly use ImgLib2s Volatile*` structures however. I really don't know. Others might be able to advise, maybe you can open a discussion on the forum?

Please also see this related forum discussion: Wrap ImagePlus VirtualStack into imglib2

@imagejan @ctrueden thanks for the useful tips. Turns out that @ctrueden's suggestion, i.e. loading the tiff as File > Import > Image... works as expected (there is no in-memory conversion happening).
Just for completeness, previously I was loading the 20GB tiff file (tzyxc: 1x548x4635x3913x1) with Plugins > Bio-Formats > Bio-Formats Importer  and View stack with: Data Browser; Memory Management: Use virtual stack. Then Plugins > ilastik > Export HDF5 which was causing the in-memory conversion of the whole stack via net.imagej.legacy.display.LegacyImageDisplayService crashing my Fiji app.

Very glad to hear the SCIFIO approach works for you, @wolny.
Sorry that we didn't get the ImageJ Legacy improvements merged before the end of the hackathon. @tpietzsch and @maarzt are working on it—see imglib/imglib2-ij#12, which I anticipate will be merged soon. Then we just need imagej/imagej-legacy#182, which I will do my best to get reviewed + merged ASAP after June 11.

Thanks for letting us know @ctrueden. We'll keep monitoring those PRs and ideally build them ourselves and give them a go in order to check the interoperability with BioFormats and our plugin.
On another note @ASHISRAVINDRAN discovered some issues with SCIFIO approach while exporting 'big' tiff files via our plugin. This is related to our discussion but outside of the scope of this particular PR, so we'd double-check his finding and discuss it in a separate PR/issue.


Document how to update documentation

Description
I have bootstrapped the steps needed for local installation, building and editing of the documentation for this project.
Reference to official issue
This addresses the issue #41
Motivation and Context
This change enables developers to be able to edit the documentation locally. Since docker is the official development configuration, I used it to create the application and link it to the current development.
How Has This Been Tested?
Locally, when you run
$ docker-compose -f local.yml up
the documentation application will be running on (http://localhost:8002/)[http://localhost:8002/]
CLA

[x] I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

Hi @musale the PR looks good! I'll follow your instructions and see if I can successfully update the docs.

@reubano great! Kindly let me know of any changes that would improve the experience

@musale This is great, thank you.

I got as far as this....
(alcf) reubano@tokpro ⚡ docker-compose -f local.yml build
postgres uses an image, skipping
Building compile_docs
(alcf) reubano@tokpro ⚡ docker-compose -f local.yml up
Creating network "alcfprod_default" with the default driver
ERROR: failed to update bridge store for object type *bridge.networkConfiguration: open /mnt/sda1/var/lib/docker/network/files/local-kv.db: no such file or directory

Ok, getting further...
(alcf) reubano@tokpro ⚡ docker docker-machine rm default
(alcf) reubano@tokpro ⚡ docker docker-machine create --driver virtualbox default
(alcf) reubano@tokpro ⚡ docker docker-compose -f local.yml up
Creating network "alcfprod_default" with the default driver
Creating volume "alcfprod_postgres_data_dev" with default driver
Pulling postgres (postgres:9.6)...
9.6: Pulling from library/postgres
ad74af05f5a2: Pulling fs layer
...

hi @reubano, did you manage to get your docker up and running?

not quite yet...
(alcf) reubano@tokpro ⚡ docker-compose -f local.yml up
Starting alcfprod_postgres_1 ...
Starting alcfprod_compile_docs_1 ...
Starting alcfprod_postgres_1
Starting alcfprod_prediction_1 ...
Starting alcfprod_compile_docs_1
Starting alcfprod_compile_docs_1 ... done
Starting alcfprod_documentation_1 ...
Starting alcfprod_prediction_1 ... done
Starting alcfprod_interface_1 ...
Starting alcfprod_interface_1 ... done
Attaching to alcfprod_postgres_1, alcfprod_compile_docs_1, alcfprod_prediction_1, alcfprod_documentation_1, alcfprod_interface_1
postgres_1       | LOG:  database system was shut down at 2017-08-22 07:58:20 UTC
compile_docs_1   | make: Entering directory '/app/docs'
compile_docs_1   | make: Leaving directory '/app/docs'
postgres_1       | LOG:  MultiXact member wraparound protections are now enabled
compile_docs_1   | make: *** No rule to make target 'html'.  Stop.
postgres_1       | LOG:  database system is ready to accept connections
alcfprod_compile_docs_1 exited with code 2
interface_1      | Postgres is up - continuing...
interface_1      | python: can't open file 'manage.py': [Errno 2] No such file or directory
interface_1      | python: can't open file 'manage.py': [Errno 2] No such file or directory
alcfprod_interface_1 exited with code 2
prediction_1     |  * Serving Flask app "src/factory.py"
prediction_1     |  * Forcing debug mode on
compile_docs_1   | make: *** /app/docs: No such file or directory.  Stop.
compile_docs_1   | make: *** /app/docs: No such file or directory.  Stop.
compile_docs_1   | make: *** No rule to make target 'html'.  Stop.

trying the master branch now to see if I get the same errors...

@reubano Can't reproduce your failure. I wonder what's up...

@lamby I suspect I have deeper issues related to my docker setup. So I wouldn't worry too much about the above error.

@musale I guess this is good to go now. Can you rebase to master and squash to one commit? Thanks!

@musale I guess this is good to go now. Can you rebase to master and squash to one commit? Thanks!

Hey @musale, how are you getting on? :)

Just as a drive-by comment for next time, my experience is that whenever your commit message is a bulleted list of 'n' things that it changes, it should have been 'n' commits to begin with — so much easier to review for all involved!

Hey @musale, how are you getting on? :)

Hi @reubano and @lamby! I've been offline the past few days. I have come to a host of additional commits so I had some challenges rebasing and squashing. I have failing tests for both documentation and prediction. Can you check if it's good to go on your end?

@musale... hmmm, one option (if it is feasible) is to save your updates to a location outside of the git repo. Then do a git fetch and git reset --hard master. That will get you a clean slate to start from. Then reapply the previous changes. Be careful though git reset --hard will erase all of your work, so make sure those changes are saved elsewhere.

Then once it's looking good, you can git push -f back to your PR branch.

@reubano let me try this. I will update as soon as I'm done

Hi @reubano, I followed your recommendations and finally managed to fix this PR. Kindly check on your end 😀


[Announcement] AutomaticChallenge Usage

In ASP.NET Core each of the authentication middleware have an option named AutomaticChallenge. This option is used to indicate which middleware will be the default for issuing authentication challenges to un-authenticated users. This automatic challenge can be triggered either by the [Authorize] attribute on a Controller or Action, or by invoking HttpContext.Authentication.ChallengeAsync().
There should only be one component in the pipeline specified as the automatic/default challenge issuer. With the exception of a few compatible authentication types (Basic, Bearer, and NTLM, etc.), having multiple authentication middleware with AutomaticChallenge enabled can cause conflicts resulting in unexpected responses.  These conflicts are more likely after changes in 1.1. Due to the number of people impacted by these changes we will temporarily revert them in 1.1.1 and make a more comprehensive design change to address these issues for 2.0.
AutomaticChallenge is enabled by default for:

JwtBearer
OpenIdConnect
Identity
IdentityServer
Validation & Introspection
IISIntegration - The AutomaticChallenge functionality is merged with the AutomaticAuthentication option. In 1.1 this middleware has a built in mitigation to skip an automatic challenge if another component has already accepted that challenge.
WebListener is missing this flag, automatic challenges are always enabled if any Windows authentication schemes are configured. See WebListener/#284

If you add more than one of the above components in your application, including multiple instances of JwtBearer or OpenIdConnect, AutomaticChallenge must be disabled for all but one.
When the application has multiple authentication middleware and you need the non-default one to issue a challenge then that middleware must be invoked by specifying its AuthenticationScheme. E.g. For an application where Identity has AutomaticChallenge enabled and JwtBearer has AutomaticChallenge disabled, JwtBearer must be invoked by specifying it's AuthenticationScheme.  This can be done with  [Authorize(ActiveAuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme)] or HttpContext.Authentication.ChallengeAsync(JwtBearerDefaults.AuthenticationScheme). The Authorize call can be simplified by defining a policy for JwtBearer so you can say [Authorize("ApiPolicy")]
            services.AddAuthorization(options =>
            {
                options.AddPolicy("ApiPolicy", policy =>
                {
                    policy.AddAuthenticationSchemes(JwtBearerDefaults.AuthenticationScheme);
                    policy.RequireAuthenticatedUser();
                });
            });

The default behavior of [Authorize] can be changed to an AuthorizationPolicie that always specifies an AuthenticationScheme, bypassing AutomaticChallenge settings.  HttpContext.Authentication.ChallengeAsync() is not affected by AuthorizationPolicies.
            services.AddAuthorization(options =>
            {
                options.DefaultPolicy = new AuthorizationPolicyBuilder("Identity.Application").RequireAuthenticatedUser().Build();
            });

See IdentityCookieOptions.
This information will also be added to http://docs.asp.net.

Note: you can add the aspnet-contrib validation and introspection middleware to the list, 'cause they also enable automatic challenge by default (https://github.com/aspnet-contrib/AspNet.Security.OAuth.Extensions/blob/dev/src/AspNet.Security.OAuth.Validation/OAuthValidationOptions.cs#L18 / https://github.com/aspnet-contrib/AspNet.Security.OAuth.Extensions/blob/dev/src/AspNet.Security.OAuth.Introspection/OAuthIntrospectionOptions.cs#L20)

@PinpointTownes I saw those but wasn't sure if they were just diagnostic tools or something that would be used in a production app.

@Tratcher no no, those are real production middleware:

The validation middleware is Katana's OAuthBearerAuthenticationMiddleware equivalent in the vNext world (except it uses the ASP.NET Core Data Protection stack). It's primarily meant to be used with ASOS and OpenIddict.

The introspection middleware implements the OAuth2 introspection specification. It can be used with any server providing an introspection endpoint.

@PinpointTownes Updated

On a related note: AutomaticAuthenticate Usage
This option serves two purposes:

It indicates if the middleware should examine each request for credentials as it arrives, process them, and set HttpContext.User.
It indicates if the middleware should respond to HttpContext.Authentication.AuthenticateAsync(AuthenticationManager.AutomaticScheme).

Missing or invalid credentials will not fail the request or issue a challenge at this stage, that's for Authorization components determine later.
The following middleware have AutomaticAuthenticate enabled by default:

Cookies
JwtBearer
Identity (Cookies)
IdentityServer
Validation & Introspection
IISIntegration - The AutomaticAuthenticate functionality is merged with the AutomaticAuthentication option.
WebListener is missing this flag, the AutomaticAuthenticate behavior is always enabled if any Windows authentication schemes are configured.

AutomaticAuthenticate does not apply to OAuth, OpenIdConnect, or similar remote auth middleware, they only process requests on their designated CallbackPath's.
If multiple middleware have this option enabled and successfully produce a ClaimsIdentity, those identities will be combine into a single ClaimsPrincipal for HttpContext.User. This may confuse your authorization logic if there are conflicting claims. It is not recommended for clients to send multiple kinds of authentication on a single request, but if they do and you need to avoid conflicts then you can use the same approaches described above for AutomaticChallenge.
AutomaticAuthenticate may also be disabled as a performance optimization if clients send credentials on most requests but only a few of your actions require them. The credentials can be processed on demand by calling AuthenticateAsync, Authorize, or an AuthorizationPolicy with the correct authentication scheme name.

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.

Hello,
I try to use the both authentication scheme JwtBearerDefaults.AuthenticationScheme and Windows authentication. The user log in by calling an authentication controller which required Windows Authentication, the windows user's name is retrieved from http request and validated from database by using Identity framework. If the user is validated, a JWT is generated and send to the client and next I would like that the user navigation use only this JWT to access protected data.
So that IIS accepts incoming HTTP request with JWT , I enable Anonymous authentication in addition to Windows Authentication.
Now I would like to force Windows Authentication on authentication controller and use JWT bearer for all other controllers.
Does anyone can help me for that, I try so many thing but without success?

We're very likely to lose track of your bug/feedback/question unless you:

Open a new issue
Explain very clearly what you need help with
If you think you have found a bug, include detailed repro steps so that we can investigate the problem.

Chris, thank you so much for this issue. It help me so much.


Types Added

Summary
Closes #3

Test Plan
Let the CI pass

Checklist

Please merge this PR..

very much so

@jainkuniya Can you check over weekend??

@chakrihacker I've done some tests locally and found some errors with Picker.Item component types.
the type definition on DefinitelyTyped has been updated recently to fix those changes, so I've made some comments to reflect those changes in this PR as well ;)

@Naturalclar thanks, I will update them

LGTM! testing it locally worked fine for me.
@jainkuniya could you take a look at the PR? It would be nice to get some typescript support for this package 🤗

Merges it as https://github.com/react-native-community/react-native-picker/commit/cfb9b2d9c743b5a33edc45f138ed1c9e0c48ce41
Thanks again @chakrihacker! for working on this 🎉 .
Thanks @Naturalclar! for reviewing 🎉.


[FR] postgres_replication - Query a remote PostgreSQL server

Hello and thank you for the plugin, I've been searching for something similar for a long time!
Use case:
I have a server which holds PostgreSQL subscriptions to a remote server not under my control. I would like to monitor the subscription status.  I have access to the remote server via psql and can perform the needed query.
Proposal:
Add the possibility to specify a target server, port, user, database, subscription name filter for the psql execution defaulting to the current values.
The optional password may be specified inside a .pgpass file in postgres user home directory using the standard format.
The script could check for the existence of a configuration file in /etc/check_mk  and configure itself like it is performed here .
Do you see this feature fitting in the scope of the plugin? I'm not familiar with checkmk plugin development but I could propose a PR implementing the parsing of the config file in bash.

Hi Svalo,
of course, if it will not break existing stuff, of course it will fit.
We are always open to PR requests, what do you think would be needed to be changed in the CMK Plugin itself?
Normally, the PRs also contain the CMK Changes.
I need to know if that's in scope for free changes (if it is not much), or I have to give it to one of our Developers where we would have to send an offer to you because he has to be paid.
Regards,
Bastian

Hello, @Bastian-Kuhn sorry for the delay but I missed the answer.
I'll test the changes I plan to introduce on my instance shortly, if I do not break anything I will open a PR so you can evaluate the change.
I do not think that changes in the CMK part are required short of providing a template configuration file which I think I can handle. I was dreaming about configuring the remote parameter from the web interface but it may be better to just start with the essential.
Regards,
Valo


[ISSRE'2014] Quantitative Evaluation of Static Analysis Tools

Abstract: —This paper presents a quantitative comparison of
static analysis tools. First, we conduct a wide-ranging survey of
static analysis tools and select several promising tools qualitatively.
Second, we build test suites that contain a large variety of
defects and evaluate the selected tools with them. Third, we derive
several metrics for measuring tool performance and subsequently
clarify the characteristics of the said tools by using them. Finally,
we quantitatively identify the best tools from several different
viewpoints
To evaluate the performance of the selected static analysis tools, we need to create test suites wherein several defects are implemented intentionally.
The test suites can be found in https://github.com/regehr/itc-benchmarks
Authors emails:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

there is a widnow here
this is some text

abd here is a dot oint

Needs new context notes. See this example or this example as a reference.
Context notes are directly inserted into the actual repository (like this), so good context notes are necessary for putting the datasets into the repo in a timely fashion.

Where is data .......?


Question: Will this allow me to use sdl2 and send the output to arduino / matrix?

Just so I understand this repo correctly, this will allow me to write code with sdl2 and use arduino / matrix as the output? That would be exactly what I have been looking for then ;P
Cheers

Well, sort of.
It allows you to write effects generically, one of the possible outputs is SDL2. You yourself can't use SDL2 functions in the effects, but you can definitly write effects and run them both on a real matrix and on a virtual one.
We don't have an Arduino port, we have..

a WIP esp8266 port using ws2812b leds
an Arduino sketch for an esp8266 that receives pixel data via the network
raspberry pi support, simply attach ws2812b leds to a specific pin on the Pi, it'll work.
some other things as well..

One could probably send pixel data out to serial if you don't have an esp8266 or a raspberry pi.
Still needs a Linux machine to run the effects, though.

@vifino: I'm not sure whether that meets @JordyMoos' intention.
I read it as: "Can I write an effect (animation, game, whatever) in SDL2 while taking advantage of SDL2 functions and still transfer the result to an LED matrix".
This isn't quite how SLED is built, but it might be possible. Off the top of my head, this requires a new gfx module that initializes and takes care of its own SDL window; then reads the resulting pixels from that window and writes them into the SLED framebuffer using matrix_set(x,y,rgb). Then any out module of SLED can be used for display.
This might be slow, depending on the output size; however, it might be possible to write e.g. a matrix_memcpy() function to speed up the process of copying the framebuffer. This, however, would require the SDL framebuffer to run in the same memory model as the SLED framebuffer (and I'm not fluent enough in SDL to know whether this is possible at all).

@orithena Good point.
Not sure if that's much help, as there are only very limited algorithms implemented in SDL2/relevant to drawing pixels.
Drawing lines, rectangles and circles(?) is already supported with simple methods.
All the other actual drawing will still be done by some algorithm and setting the pixels, so it doesn't make much difference, in my opinion.

Hmmm... probably the most flexible solution would be to perpetually screenshot an SDL window maintained by another process. Don't know whether that works or is practical. This would only require a small gfx module on SLEDs side.

I think that's the simplest and most universal solution too.
One could just implement a grabbing-code on the app side, send frames every time SDL render is called.
We already have OpenPixelControl and Pixelflut support, so it should be doable. :)


Add 'Port' to the list of items supporting Arrays

Fixes #47

Coverage remained the same at 97.253% when pulling 9c35a4b3e89fe12e7b5512db19dbb006859cd0e2 on trevor-vaughan:fix-sshd-port-docs into 3776fd3c1f016bab44505b5af20768da3b7593b2 on hercules-team:master.

Coverage remained the same at 97.253% when pulling 9c35a4b3e89fe12e7b5512db19dbb006859cd0e2 on trevor-vaughan:fix-sshd-port-docs into 3776fd3c1f016bab44505b5af20768da3b7593b2 on hercules-team:master.


PHPORM-190: Update drivers-github-tools to v2

PHPORM-190

Reminder to look into whatever repository config interrupted the PHPC release yesterday. Worth checking that PHPLIB is also correctly configured, since you merged this there earlier in the week.

Yep, I did so immediately after discovering the problem yesterday 👍


Pass null to $microseconds for null $seconds

Passing null seconds and non-null microseconds will become deprecated in php 8.1.
See https://github.com/php/php-src/pull/6879/files#r615680892 of https://github.com/php/php-src/pull/6879

This is ready for another look - it requires two calls (or a variable length argument list) because php 7 doesn't allow passing in null to microseconds, but php 8 deprecates passing anything other than null to the optional parameter microseconds (tv_usec) when seconds (tv_sec) is null
https://php.net/stream_select

php 8.1.0alpha2 is out
@staabm this could use another look

Rebased to run the current GitHub workflows CI, which runs unit tests in all versions of PHP. Everything is passing.


format json output

format json output for better readability and version control.

Thanks, see version 2.0.4.


fix(org) use org-contrib from github emacsmirror

Installing from the original repo did not work due to SSL issues.
This PR adds the github emacsmirror repo to org's package.el
fixes #5655
ref:
https://github.com/hlissner/doom-emacs/issues/5655#issuecomment-954730677
https://github.com/hlissner/doom-emacs/issues/5207#issuecomment-877750996

Thanks for the PR! Unfortunately, a larger bump of :lang org was needed and the commit message needed to be modified to conform to our commit conventions, so I made this change in a4695b6b, which should resolve the linked issue. Thanks for bringing it to my attention!

Thanks for adding this and for your feedback.  One step at a time. :D


When I use tdlib in ios, I don't know the name of the type value and the name of the parameter that is requested to tdlib

When I use tdlib in ios, I don't know the name of the type value and the name of the parameter that is requested to tdlib.for example:
When I need to set the GetChat, I don't know the value of the type and what parameters are needed, as are other interfaces.like this:

I don't know if the key 'chatId' and 'getChat' are correct.
There are other requests, such as setProxy, getProxy, GetChat, etc.
Is there a document for each interface type and parameter?

See scheme td_api.tl or autogenerated HTML documentation for the list of all available TDLib methods and classes.

Ok,thank you.


The reconstruction quality on ScanNet dataset.

Hi, I have trained the model following the instruction python run_training.py --cfg configs/cra/train_cra_scannet.yaml. However, the PSNR metric is much lower than the paper reported.

The model doesn't seem to converge. Did you train enough steps?
Did you load the pretrained neuray model? Many photos in the scannet dataset have ghosting and black edges which are bad for the training process. Therefore, we larverage neuray for better rendering quality.

Thanks for reply. I'll double check the configure file.