[Bugfix][SpecDecode] kv corruption with bonus tokens in spec decode

Summary
https://github.com/vllm-project/vllm/pull/5765 enabled the bonus token by arranging model outputs with bonus tokens in mind. However, it only functions correctly when K=1 (num_speculative_tokens).
When K > 1(num_speculative_tokens), each generation step produces a token ID without considering the bonus token. This can lead to a token that is not equal to the bonus token, which may corrupt the KV cache.
The inconsistency in the token IDs resulted in a sharp drop in the average acceptance rate. This drop is unexpected because the average acceptance rate should have been similar to that when K=1.
I modified it to replace a token generated by a sequence without bonus tokens with a token generated by a sequence that has bonus tokens, as shown in the image below. ('B' stands for the bonus token in the image.)

Experiment

Target Model / Draft Model: llama3-70B / llama3-8B
TP: 4
Devices: A100 * 4
Total number of requests: 512
input length / output length: 1024 / 128
sampling parameter: repetition_penalty=1.0, temperature=1.0, top_p=1.0, top_k=-1
dataset: c4
batch size: 8
K: # of speculative tokens

as-is

K
decode e2e time
acceptance rate
system efficiency

1
215.72559
0.857
0.928

2
206.51253
0.772
0.806

3
201.51099
0.744
0.715

force disable_bonus_tokens

K
decode e2e time
acceptance rate
system efficiency

1
355.67701
0.862
0.5

2
258.0089
0.853
0.62

3
218.46093
0.845
0.647

to-be (applied this PR)

K
decode e2e time
acceptance rate
system efficiency

1
213.83354
0.859
0.929

2
194.5633
0.847
0.863

3
182.23656
0.836
0.803

Help needed

The logprob is not adjusted to account for changes in token IDs.
To apply this change to TP1DraftModelRunner.

Reference
https://github.com/vllm-project/vllm/issues/4212: This is a proposed issue about enabling the bonus token.
https://github.com/vllm-project/vllm/pull/5765: This PR implemented the functionality to enable the bonus token.
https://github.com/vllm-project/vllm/pull/8701: This PR removed the logic to disable the bonus token as part of a refactor.
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

I added experiment data with llama3 70B/8B

Thanks for the fix! I feel it's a tricky but important bug. It's hard to detect.... Really appreciate the fix!
Could you (1) add a test case to catch this bug? (2) I feel we need to add the TP1DraftModelRunner support since it's a must for spec dec to see performance gains. I can help with this if needed.
Some potential solutions:
(1) As @sroy745 suggested, we run the first step with expanded batch, and K-1 steps with the original batch.
(2) We modify the output token id on GPU here.
(1) might hurt the performance, but more clean and general.
(2) is hacky but might have less changes and will not hurt the performance.
@sroy745 @llsj14 What do you think?

Thanks for the fix! I feel it's a tricky but important bug. It's hard to detect.... Really appreciate the fix! Could you (1) add a test case to catch this bug? (2) I feel we need to add the TP1DraftModelRunner support since it's a must for spec dec to see performance gains. I can help with this if needed.
To add support for TP1DraftModelRunner, some potential solutions: (1) As @sroy745 suggested, we run the first step with expanded batch, and K-1 steps with the original batch. (2) We modify the output token id on GPU here.
(1) might hurt the performance, but more clean and general. (2) is hacky but might have less changes and will not hurt the performance.

If we were to go down the second path (2) won't we need to pass the indices of the original original rows to the advance_step function and use it in the advance_step kernel to update the output after every step? If so this might be more work than option (1) though this would definitely be more performant.
I feel option (2) is better because sd is very performance sensitive. However I think it would make the implementation complicated but if we are ok with that I would say option (2). What do you guys think?
@llsj14  please let us know if you need help with this.

@sroy745 @llsj14 What do you think?

Thank you for the feedback and solutions. Solution (2) sounds good if it improves performance. I'll first review advance_step_function and advance_step_kernel.

Thank you for the feedback and solutions. Solution (2) sounds good if it improves performance. I'll first review advance_step_function and advance_step_kernel. I'll also prepare test case to catch this bug.

Yeah (2) sounds good to me as well.

Thank you for the feedback and solutions. Solution (2) sounds good if it improves performance. I'll first review advance_step_function and advance_step_kernel. I'll also prepare test case to catch this bug.

Why do we need to modify advance_step function and use it in the advance_step kernel? Can we just modify the input to each draft runner step? I just pushed the minimum change, it's very similar to the current modification, let me know your thoughts.

Thank you for the feedback and solutions. Solution (2) sounds good if it improves performance. I'll first review advance_step_function and advance_step_kernel. I'll also prepare test case to catch this bug.

Yeah (2) sounds good to me as well.

Thank you for the feedback and solutions. Solution (2) sounds good if it improves performance. I'll first review advance_step_function and advance_step_kernel. I'll also prepare test case to catch this bug.

Why do we need to modify advance_step function and use it in the advance_step kernel? Can we just modify the input to each draft runner step? I just pushed the minimum change, it's very similar to the current modification, let me know your thoughts.

Sorry for the confusion. Yeah I think this will work and we don't need any changes in  advance_step kernel

so, the idea is to deliver the index of bonus tokens to the model_runner using the ‘set’ function and use this information to adjust the output tokens. This approach looks simple and great to me.

I just added a test for this fix, feel free to take a look! @llsj14 @sroy745

@LiuXiaoxuanPKU
The test you added looks concise and accurate. Do I need to add a test case for the multi-TP runner?

@LiuXiaoxuanPKU The test you added looks concise and accurate. Do I need to add a test case for the multi-TP runner?

Yeah please if you get time, really appreciate it!

@llsj14 Could you help check the correctness running the experiments you showed originally in this PR? (different Ks, acceptance rate, and decoding time)

@llsj14 Could you help check the correctness/performance running the experiments you showed originally in this PR? (different Ks, acceptance rate, and decoding time)

Sure, I’ll include the results in this PR!

I added the test results for the TP1ModelRunner case at the top. Similar to the TP>1 case, there was a drop in acceptance rate, and it was fixed after the commits added.
I'm sorry I couldn't add the unit test for the TP>1 case and include comments about logprobs.
Thanks again for your commits and reviews. @sroy745 @LiuXiaoxuanPKU


Manage org-wide app settings for Microsoft 365 Government (2)

The "Manage org-wide app settings for Microsoft 365 Government" section references GCC, GCCH and DoD environments multiple times as if these instructions work in all three but the note contradicts this by saying "In GCCH and DOD clouds, the third-party apps are not available.".
Microsoft support reps are using this article to say that we should be able to access third-party apps in GCCH.  The screen shots don't match and the settings are not there.  My belief is that GCCH and DOD should not be mentioned in this section, with the exception of the note.
This can be further verified by reviewing https://docs.microsoft.com/en-us/office365/servicedescriptions/teams-service-description where the first feature, "Apps, Bots & Connectors", has a footnote for the Yes under GCC-High and DOD:
1 Third-party applications and application publishing are not available in these clouds at this time.
The only apps that appear to be available in GCCH are the Microsoft published apps (first-party apps).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b51eda6c-168c-7d99-7cc1-992b3d8feef2
Version Independent ID: 118a1b8f-f4b7-a778-70b1-d3161fc548ab
Content: Manage app permission policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-app-permission-policies.md
Service: msteams
GitHub Login: @guptaashish
Microsoft Alias: guptaashish

Hello @ldickerson3 I am looking into this

Hello @ldickerson3 I could get information that org-wide app settings for GCC/H and DoD is under "Permission policies", I am now trying to confirm if that differs in GCC and if an update to the screenshot/instructions is needed.
Thank you

We have received confirmation that the article will be updated soon.

Thanks folks. The updates are published live at https://docs.microsoft.com/en-us/MicrosoftTeams/teams-app-permission-policies#manage-org-wide-app-settings-for-microsoft-365-government . Hope it helps. We are happy to do more enhancements as required - please keep the feedback coming.


Update index.yml

I changed some words.

@cwebster-99
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Typing from the parameter bag

Hello
I am faced with a parameter typing problem arising from the bag parameter.
I declared a boolean type parameter in the parameters.yaml file :
param: '%env(bool:MY_ENV_PARAM)%'

Below, the code from a controller which aims to retrieve a parameter :
$param = $this->parameterBag->get('param');
assert(is_bool($param));`

Following the execution of Psalm, here is the error generated :
ERROR: TypeDoesNotContainType - src/Contoller/MyController.php:150:10 - Type string for $param is never bool (see https://psalm.dev/056)
                assert(is_bool($param));

The problem is that it tells me that the type of $param is string, but I declared it as a boolean.
My goal is to delete my assert, and for Psalm to correctly detect the type.
I inspected the code, the ParameterBagHandler handler is loaded correctly.
Only in my App_KernelDevDebugContainer.xml, my parameter is in this format:
<parameter key="param">%env(bool:MY_ENV_PARAM)%</parameter>

In the handler ParameterBagHandler, the parameter type is tested with the gettype method, which does not work because the environment variables are not resolved, and the result is the same as stated in the configuration file.
What is tested is:
gettype('%env(bool:MY_ENV_PARAM)%')

instead of :
gettype(true)

If it helps, here is my Psalm setup:
<plugins>
<pluginClass xmlns="https://getpsalm.org/schema/config" class="Psalm\SymfonyPsalmPlugin\Plugin">
	<containerXml>var/cache/dev/App_KernelDevDebugContainer.xml</containerXml>
</pluginClass>
</plugins>

<extraFiles>
   <directory name="var/cache/dev/Symfony/Config" />
</extraFiles>

<stubs>
   <file name="vendor/symfony/dependency-injection/Loader/Configurator/ContainerConfigurator.php" />
</stubs>

Do you have any idea, I'm doing something wrong ?
Thanks

@fldv thanks for the report. Could you please check it with v5.2.2?

@fldv thanks for the report. Could you please check it with v5.2.2?

Thanks for the fix and for the feedback. Tested and approved


[CORE-1649] Update Go version to 1.20.4

This addresses three vulnerabilities.

think there is more than one place that needs to be updated for this old PRs that updated it. https://github.com/pachyderm/pachyderm/pull/8565
https://github.com/pachyderm/pachyderm/pull/8640


hovered card size should be little small and shadow of button should be less

Hello, I am Gssoc'21 participant . I would like to contribute on this project. Could you please assign me this issue.

Hey , I would like to work on this issue please assign to me .
I am a participant in GSSOC'21

Sure assigned for 3 days.

@anushbhatia


Configurable replica placement policy

Feature request
If we can config the replica placement, for example, second replica on the same rack with first replica, and third replica off the rack. It will provide better robustness.
Describe the solution you'd like
Let user config the different racks information, and SR place replicas in different racks according to configuration file.

Can you describe more info about racks, like, what's the feature of racks, IP prefix, or host name prefix, or other infos?

What I can see is,  the machines have name start with location name and end with serial number, e.g.  oklahoma-data-doris-be01.


Received data that exceeds Integer.max value

Hello,
I recently found this issue in Graphite 0.9.12 (after updated from 0.9.10). There is a value 'Available Memory Bytes' now keeps showing as "-2147483648.0" which seems like the actual values are exceeding Integer.Max. and the data type shouldn't be Integer in fact.
Could anyone help me about where and how should I check the relative data type setup in Graphite? At least I want to make sure whether this wrong data type was set in Graphite. Thanks
PS. the data source for this is windows performance counter, where I can see in its code it is using float as type to report to Graphite:
public float? ReportValue()
    {
        if (this.disposed)
            throw new ObjectDisposedException(typeof(PerformanceCounter).Name);

        try
        {
            // Report current value.
            return this.counter.NextValue();
        }

Regards
James

Hi any reason? will be fixed? not an issue? not true? but anything other than just close it?

Sorry, @Kapaski, I was not sure if that's still relevant.
Graphite supporting very big number as value, definitely. So, it can be bug or misconfiguration in Codahale / dropwizard, maybe together with 0.9.12, but I doubt so.
So, it's better to ask dropwizard guys.

@deniszh that's all right. wasn't complaining but curious
I'm happy to close and park this one now though as we are not using that old version any more, agree that it might be a legacy issue by now.

👍
Thanks!


Upgrade node and npm

Close https://github.com/jhipster/jhipster-lite/issues/2499
To be honest I don't know (at all) if this is a good idea / a good way to do that (not even sure that work, can't really test automatic dependabot updates on that)
@qmonmert any advice on that?

First time that I will see dependabot working on npm and node versions. The idea is good but I am afraid that tests are ok but the reality will be different 😅 but we can try

Yep, I really don't think that'll do but let's try...

🎸

Looks like it work: https://github.com/jhipster/jhipster-lite/pull/2984
BUT I don't know if we want to update to the latest versions (cc @pascalgrimaud)

Good but 18.0.7 is not a LTS ...

Yep, this is what bothering me...


Dev test: Masses And Springs Basics 1.0.0-dev.11

Masses-And-Springs-Basics is ready for the first round of dev testing. This dev test should foucus on catching bugs and any sim breaking behavior. This is a Phet brand sim and isn't instrumented for Phet-IO. Please report any bugs to https://github.com/phetsims/masses-and-springs-basics/issues.
Thanks, @ariel-phet and @arouinfar for the design input. Tagging @ariel-phet to mark priority or add further input.

General Dev Test

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.

General Dev Test Platforms

[ ] Latest macOS, Chrome, Firefox, and Safari
[x] Latest iOS, Safari
[x] Windows 10, all browsers
[ ] Latest Chrome OS, Chrome

Issues to Verify

[ ] Please determine if ghost images of sliders are present on platforms/browsers related to https://github.com/phetsims/masses-and-springs/issues/334

These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

Link(s)

Masses and Springs Basics

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

@Denz1994 the reset all pointer area may need another look.  See https://github.com/phetsims/friction/issues/65

Opening a new issue related to  https://github.com/phetsims/QA/issues/220#issuecomment-439101227.

Major browsers tested.  I'd like to keep this open a bit longer to see if we find anything new, but it looks like most major bugs have been found.  Lowering priority.

Didn't see https://github.com/phetsims/masses-and-springs/issues/334 while testing.  QA is done.

All sim related issues have been addressed. Related issues are either closed, fixed-awaiting-deploy for MAS maintenance release, or require verification in the next dev test. I'll close this issue and open a new issue for a second round of dev testing.


Replace TableInput LinearInterpolation with a smooth interpolator

When using LinearInterpolation for numberdensity and collisionfrequency fields of Species, the total runtime for a "Wait profile" is approximately twice the runtime for the same discretely sampled Wait profile with a CubicSplineInterpolation. This is likely because the DifferentialEquations solver is trying to resolve the "knees" between each piecewise linear segment.
Cubic splines may overshoot the local true density, so PCHIP interpolation is preferred, but there is no up-to-date Julia package for PCHIP right now. I have a private GitHub repo with three PCHIP algorithms but they can't be released under MIT license, so I'd rather not register them.

See the monotonic splines in Interpolations.jl. In particular, the FC method may be very close to Matlab's PCHIP.


Typo in log in message

When the app loads a web map requiring authentication, the message the user is prompted with has a small typo:

You must ~login~ log in to access this resource.

This web map id should prompt the message: 1300bf23f97f4a2bb6ede795dfab8b72

@mikewilburn this change has been merged into master. Can you verify?

Verified on master.


Investigate elide lifetimes

This PR is focused on getting rid of clippy nightly warnings based on redundant lifetimes. It aims to solve the issue listed in https://github.com/embassy-rs/bt-hci/issues/21.
I did find that I had to turn my format on save off when doing this PR as it would break my imports in some of the files resulting in a mess of errors.
The code still builds in both nightly and stable and clippy no longer has any warnings in either stable or nightly :)

Please revert all the formatting changes other than the lifetime changes (there are changes in some of the macros, the hex capitalization issue, some parentheses that went missing). This PR should only touch the lifetime issues flagged by clippy. Thanks!

Will do tomorrow! Thanks @alexmoon  :)


request(foxxie):  add ruffpuff1 for Financial

Which package is the feature request for?
foxxie
What type does this request pertain to?
documentation
Feature
all contributors

@allcontributors please add @Ruffpuff1 for Financial


send/invoke

I'm trying to integrate SCION with my project, looks like send or invoke is best variant, but i can't override send to call my code, how to do it? How to return values from my code to SCION?
https://github.com/jbeard4/SCION/wiki/Plugin-API-for-SCION-2.0-branch
Is this project alive?

There are a couple of ways to do this. The pattern that I prefer is to pass your APIs to the state machine instance on an explicit init event. Something like:
<scxml>
  <datamodel>
    <data id="api"/>
  </datamodel>
  <state id="initial_default">
    <transition target="idle" event="init">
      <assign location="api" expr="_event.data"/>
    </transition>
  </state>
  <state id="idle"/>
</scxml>

Then you can initialize the session by calling:
session.start()
session.gen('init', {run : function(){
  setTimeout( function(){ session.gen('success') }, 10 ); // do something asynchronous and generate success
}})

In the future, I may extend platform.eval to make it easier to inject functions into the session context.
Let me know if you have any other questions. If not, feel free to close the issue. Thank you.

Thanks!


JAPACCOE-2802 - Enabled the missing task in the build

Build commented out a few task like
collection-cert-pre-processor
collection-certificate-generator
metrics-data-transformer
However the kp flinkjob deployment was starting these jobs and failing. Enabled these jobs in the build.
Another change made was the bring up cloud-store-sdk to the top of the dependency. Else it was not picking up the presto classes. It was picking up hadoop classes first and failing
Type of change
Please choose appropriate options.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[X] Build job are packaging the missing jars
[X] KP flink jobs are getting deployed

please review https://github.com/Sunbird-Lern/data-pipeline/tree/master/lms-jobs/credential-generator
* collection-cert-preprocessor

* mertics-data-transformer
  as part of the credential-generator are now under Lern

Please re-confirm whether we should include them as part of kp-jobs

i think this job is not need as they have been commented out in the tags/release-5.2.0_RC5
we dont need to merge..we can close this PR


Shell command executed differently in a terminal and script!

I may have found another reason for the different results, why the installation works for one and not for the other.
If you look at the examples and explanation in the page linked below, you can see why.
So please check it out: https://unix.stackexchange.com/questions/464770/shell-command-executed-differently-in-a-terminal-and-script

Worth looking into https://github.com/koalaman/shellcheck .
You could also set this up for CI on each PR using GitHub Actions/workflows to ensure that all accepted code contributions are properly portable across shells, and therefore (hopefully) portable across distros.

^
https://github.com/marketplace/actions/run-shellcheck-with-reviewdog
and/or
https://github.com/marketplace/actions/shellcheck

But... which one does and which one doesn't it work in?

This shouldn't be an issue, the terminal and the launcher should be respecting the shebang (#!/bin/bash) at the beginning of the files. However, I just learned that when using source to launch a script, some shells (zsh mainly) don't.
This answer is more likely to provide more explanation: https://unix.stackexchange.com/questions/580124/does-zsh-respect-the-shebang-bin-sh-so-dash-can-be-used
I think that if we want to use bash, the launch command line should be changed to bash ./install.sh instead of ./install.sh.


Update screen_diff deps and goldens as stable Chrome version advances.

Also updated Python Tips

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @rohdesamuel
R: @pabloem
PTAL, thx!

retest this please

Run Python PreCommit

lint check has in fact passed: https://builds.apache.org/job/beam_PreCommit_PythonLint_Commit/4257/

Run Python PreCommit

Run PythonLint PreCommit

Run Python PreCommit

Run Python PreCommit

Thank you, Pablo!

Run Python PreCommit

Run Python PreCommit

let's have faith this time


Server Source Code

Hello,
is their anyway i can have the server source code ? as it seems this app can only work with the server code .
Thank You

Hi @Elqul, the server code is not available as it was not allowed to be open sourced at the time. Apologies for this, but it shouldn't be too difficult to create something similar given the sample mock responses you have available in the test code (e.g. https://github.com/EverestOpenSource/Everest-iOS/tree/master/KIF/Mocks/Mock Base Classes)


Touch friendly behavior

DPicker can be closed by clicking outside of the picker. This doesn’t work when touching outside of the picker. I tried implementing this by adding
document.addEventListener('touchend', this._events.hide);

after line 144 in dpicker.js. This does work, the only problem is, that the date/datetime input field is still focused after closing the picker, so all mobile OS are still showing the virtual keyboard.

Use document.getElementById(this.inputId).blur().

Want to pull-request on this or should I do it? I think this has to go in core.

index 022187e..85e4043 100644
--- a/src/dpicker.js
+++ b/src/dpicker.js
@@ -176,7 +176,13 @@ function DPicker(element, options = {}) {
   element.setAttribute('id', this._container)
   element.addEventListener('keydown', this._events.keyDown)

-  element.querySelector('input').addEventListener('blur', this._events.inputBlur)
+  let input = element.querySelector('input')
+
+  input.addEventListener('blur', this._events.inputBlur)
+  document.addEventListener('touchend', function() {
+    input.blur()
+  })
+
   return this
 }


Chest out/in

When the train drive over a chest in/out the train didn't do anything and the console:
[10:58:04 ERROR]: [Train_Carts] Failed to execute GROUP_ENTER for SignActionTransfer:
java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Set
at com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:473) ~[?:?]
at com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:454) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:194) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:177) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.findBlocks(TransferSignUtil.java:258) ~[?:?]
at com.bergerkiller.bukkit.tc.signactions.SignActionTransfer.execute(SignActionTransfer.java:79) ~[?:?]
at com.bergerkiller.bukkit.tc.signactions.SignAction.executeAll(SignAction.java:187) ~[?:?]

What version of TrainCarts and bkcommonlib are you running?
Op wo 21 okt. 2015 11:05 schreef FireF0re<EMAIL_ADDRESS>
When the train drive over a chest in/out the train didn't do anything and
the console:
[10:58:04 ERROR]: [Train_Carts] Failed to execute GROUP_ENTER for
SignActionTransfer:
java.lang.ClassCastException: java.util.ArrayList cannot be cast to
java.util.Set
at
com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:473)
~[?:?]
at
com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:454)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:194)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:177)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.findBlocks(TransferSignUtil.java:258)
~[?:?]
at
com.bergerkiller.bukkit.tc.signactions.SignActionTransfer.execute(SignActionTransfer.java:79)
~[?:?]
at
com.bergerkiller.bukkit.tc.signactions.SignAction.executeAll(SignAction.java:187)
~[?:?]
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29.

Train_Carts v1.75-SNAPSHOT BKCommonLib v1.66-SNAPSHOT

Try the latest from the resource page and check if its fixed.
Op wo 21 okt. 2015 11:17 schreef FireF0re<EMAIL_ADDRESS>
Train_Carts v1.75-SNAPSHOT BKCommonLib v1.66-SNAPSHOT
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-149831117
.

Did you mean from Spigot or a other side?

From Spigot.
Op wo 21 okt. 2015 11:25 schreef FireF0re<EMAIL_ADDRESS>
Did you mean from Spigot or a other side?
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-149833309
.

The version 1.75 is the newest yet.

Just redownload the version, I update a lot and don't change version
numbers often so there is a change that you have an outdated version.
Op wo 21 okt. 2015 12:01 schreef FireF0re<EMAIL_ADDRESS>
The version 1.75 is the newest yet.
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-149843752
.

I have redownloaded the version but the error is still there. I have also deleted the config.
[15:29:18 ERROR]: [Train_Carts] Failed to execute GROUP_ENTER for SignActionTransfer:
java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Set
at com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:473) ~[?:?]
at com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:454) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:194) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:177) ~[?:?]
at com.bergerkiller.bukkit.tc.utils.TransferSignUtil.findBlocks(TransferSignUtil.java:258) ~[?:?]
at com.bergerkiller.bukkit.tc.signactions.SignActionTransfer.execute(SignActionTransfer.java:82) ~[?:?]
at com.bergerkiller.bukkit.tc.signactions.SignAction.executeAll(SignAction.java:187) ~[?:?]

Use spigot and not bukkit.
Op wo 21 okt. 2015 15:30 schreef FireF0re<EMAIL_ADDRESS>
I have redownloaded the version but the error is still there. I have also
deleted the config.
[15:29:18 ERROR]: [Train_Carts] Failed to execute GROUP_ENTER for
SignActionTransfer:
java.lang.ClassCastException: java.util.ArrayList cannot be cast to
java.util.Set
at
com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:473)
~[?:?]
at
com.bergerkiller.bukkit.common.utils.BlockUtil.getBlockStates(BlockUtil.java:454)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:194)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.getBlockStates(TransferSignUtil.java:177)
~[?:?]
at
com.bergerkiller.bukkit.tc.utils.TransferSignUtil.findBlocks(TransferSignUtil.java:258)
~[?:?]
at
com.bergerkiller.bukkit.tc.signactions.SignActionTransfer.execute(SignActionTransfer.java:82)
~[?:?]
at
com.bergerkiller.bukkit.tc.signactions.SignAction.executeAll(SignAction.java:187)
~[?:?]
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-149894724
.

I use Spigot.

You don't, give me the output of /version
Op wo 21 okt. 2015 21:55 schreef FireF0re<EMAIL_ADDRESS>
I use Spigot.
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-150007595
.

[10:20:45 INFO]: This server is running CraftBukkit version git-Spigot-5f38d38-18fbb24 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)
[10:20:45 INFO]: You are running the latest version

See you are running Craftbukkit and not Spigot. Use the spigot.jar instead
of the craftbukkit.jar in buildtools
Op do 22 okt. 2015 10:20 schreef FireF0re<EMAIL_ADDRESS>
[10:20:45 INFO]: This server is running CraftBukkit version
git-Spigot-5f38d38-18fbb24 (MC: 1.8.8) (Implementing API version
1.8.8-R0.1-SNAPSHOT)
[10:20:45 INFO]: You are running the latest version
—
Reply to this email directly or view it on GitHub
https://github.com/bergerhealer/TrainCarts/issues/29#issuecomment-150142608
.

I use the spigot.jar from buildtools. When you do on your server (<IP_ADDRESS>:62515) /version it's the same.

I just looked into the source real quick and this bug has already been fixed, please download a new version of BKCommonLib please.

Okay, I have downloaded a new version of BKCommonLib and it works! Thanks!


⚠ Bofrost.be has degraded performance

In 63ec0a7, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2138 ms

Resolved: Bofrost.be performance has improved in 266f91c.


Write manual test cases for "KansasPage"

Please write a manual test case for "https://prayersconnect.com/regions/provinces?id=45&cid=1" which involves breaking down the functionality of the webpage into specific steps that can be tested.
KansasPage: https://prayersconnect.com/mosques/search/Wichita%252C%2520Kansas%252C%2520United%2520States/37.68717609999999%2C-97.33005299999999/37.68717609999999%2C-97.33005299999999
Please use this Google Sheet for your test cases.
https://docs.google.com/spreadsheets/d/1FT33mi7lZ9RcyDcln0vpu1PTX4RUNqeuBdA3uGEAOsE/edit?usp=sharing

Done.


[Ansible] Various fixes for the Windows Ansible tasks

Properly set packages Windows environment PATH via Ansible.
Downgrade Git version to 2.19.1. Fixes https://github.com/microsoft/openenclave/issues/1954.
Small Ansible task cleanup.

This pull request includes the fix for issue https://github.com/microsoft/openenclave/issues/1954 filled by @anitagov, and marked as v0.6, and some other two issues that I found during my testing:

Properly set packages Windows environment PATH via Ansible
Properly reboot Windows ACC VMs

/cc @johnkord @yakman2020

bors try

bors r+


Align dependency management + workflows for publishing and releasing

Summary
Align Dependency Management
We currently have two ways of managing dependencies for the DJ server: poetry (used to publish the server and client libraries to PyPi) and pip-compile-multi (used to generate the requirements used by tests and Docker). The DJ client only uses poetry.
Changes include:

Updating the DJ server's poetry dependencies (defined in pyproject.toml, locked to poetry.lock) to actually match what's used by pip-compile-multi, allowing us to setup and run both local and CI tests with poetry install followed by poetry run pytest ....
Updating the DJ client's test dependencies so that we can actually run tests in an independent environment from the DJ server. Originally these client tests were just piggy-backing directly off the server's dependencies.

tl;dr is that everything works with Poetry now, so if we wanted to, we can use poetry export --without-hashes --format=requirements.txt > docker.txt to export requirements for the Docker image and then remove everything for pip-compile-multi and move fully to Poetry.
Workflow Updates
These changes include:

Separated out the client and server tests. There's no reason for them to be run sequentially, especially when the server tests take significantly longer than the client tests.
Added a release github action, which can be run by specifying the version bump rule and the library to bump (either the server or client). This will then bump the version with poetry, create a tag, create a release in github, and finally publish to PyPi.

Test Plan

[ ] PR has an associated issue: #
[X] make check passes
[X] make test shows 100% unit test coverage

Deployment Plan
N/A

@cwegener would pdm's scripting ability be a viable replacement for make?

@cwegener Thanks for having a look! These are all great points.

pytest invocation
Agreed that they should be integrated into a single flow and not copied across these different places. I'm not a huge fan of tox, but I'll explore what it might look like with pdm.

Developer docs
I'll add some docs on this in another PR. I think putting them into the Hugo docs under the developer section makes sense.

Just confirming that the binary wheel that gets built is platform agnostic?
Yeah, it should be

@cwegener would pdm's scripting ability be a viable replacement for make?

The two things are very different (make and pdm user scripts) and not really interchangeable.
One thing that I can say is that in my experience there is a lack of knowledge in maintaining Makefiles in the real world. Not all engineers will be comfortable editing Makefiles, but that should not bar anyone ever from utilising Makefiles in their projects. :grin:
The current Makefile in dj is really very simple and can easily be folded into the existing new python specific toolchain of pdm + hatch, since the targets in the Makefile are quite simple task runners.
On the other hand though, I don't really see any urgent need to replace the Makefile. Keeping the Makefile doesn't add any new cost to the maintenance of the project (ignoring my comment about lack of experience in maintaining Makefiles)
I think the only thing we should do is to migrate  the developer related target definitions (test, integration, check, spellcheck) into pdm user scripts and change the Makefile to invoke those pdm user scripts instead.
And furthermore the release management related targets (version, release) are now probably 100% dependent onto GH Actions anyway and they should either be removed (therefore leaving GH actions as the only way to make a release) or the GH Actions should call the release management targets in the Makefile, thereby leaving a bit of flexibility for the case should the GH actions ever cause a problem during release management. So should the need for a fallback option ever arise one could craft a release "manually" (or in another CI runner) by simply executing the same Makefile targets without relying on GH actions. (presuming that PyPI upload privileges are available)


⚠ Bofrost.at has degraded performance

In d09d3a3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1865 ms

Resolved: Bofrost.at performance has improved in 239caa7 after 6 minutes.


Don't fail if a site can't place

My concern is that this just hides issues rather than solving the underlying problem (that the link location isn't returning properly).


Variant Exit not working.

The initial and enter work perfectly. Unfortunately, the fade-out before going to another page does not happen. Any idea what might be causing that?

Same here, also I cannot run my project as I get "Cannot read property 'pathname' of undefined"


OpenMTP <IP_ADDRESS> on Monterey 12.6.1 talking to Pixel4XL, Kalam Mode: app pulls about 150 files and crashes, pane goes grey. POSSIBLE WORKAROUND

Spoiler
This seems only to affect Kalam-mode transfers; I re-ran the transfer under "Legacy" mode, and it worked.
Describe the bug
I fired up the app for the first time in several months; it autoupdated and restarted.  Since the update, asking it to pull a DCIM folder from my phone to my desktop, it manages to pull about 150 files (variable per attempt) and then somehow crashes, leading to the OpenMTP pane blacking out although the menubar is still somewhat functional.
I repeated this 3x, same results each time.
I decided to try running it in a iTerm window, and the log is:
$ ./OpenMTP
objc[33898]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x7ffb4a47fec8) and /Applications/OpenMTP.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libGLESv2.dylib (0x1137829c8). One of the two will be used. Which one is undefined.
2022/12/09 23:59:32 fatal error LIBUSB_ERROR_NOT_FOUND; closing connection.
Checking for update
Update for version 3.2.0 is not available (latest version: 3.2.0, downgrade is disallowed).
2022/12/09 23:59:47 OpenSession failed: LIBUSB_ERROR_TIMEOUT; attempting reset
2022/12/09 23:59:47 fatal error LIBUSB_ERROR_NOT_FOUND; closing connection.
2022/12/10 00:00:04 fatal error LIBUSB_ERROR_NOT_FOUND; closing connection.
libc++abi: terminating with uncaught exception of type Napi::Error: readPointer: Cannot read from nullptr pointer

The fatal "libusb" errors don't appear to actually be fatal since it pulls about 150 files, but the null pointer error comes up when it crashes properly.
Steps to Reproduce (for bugs)
Provide a link to a live example or an unambiguous set of steps to reproduce this bug. Include code to reproduce, if relevant

Pull a large folder containing ~1100+ JPGs from an up-to-date Pixel phone, to a Monterey Mac, in Kalam mode.

Context
How has this issue affected you? What are you trying to accomplish?
File transfers of photos.  Came to a complete stop.

I have a similar situation to you.I have about 20,000 pictures to transfer, but every time I transfer thousands of pictures, the program will crash and turn gray.I tried issues#276 and nothing worked
I used your method to changed the mode to Legacy,and finally the transmission was successful.
This may a bug.

This seems like an issue with the node napi package that i am using. Unfortunately i am not getting enough time to find a fix for this issue.

Thanks @alecmuffett for the report. Looks like there has been a regression in ffi-napi package. I have reported the issue with them: https://github.com/node-ffi-napi/node-ffi-napi/issues/235.
Meanwhile I am looking into migrating the ffi package to something else which is stable.

OpenMTP v3.2.10-beta.1 is now rolling out.
Note: This a pre-release version and it might be unstable. ⚠
Features

Fixes - the app crash on older versions of macOS
Fixes - the app crash caused while transferring files a large number of files.

If you are on an older version of OpenMTP and have frozen the auto-app update option for the sake of preventing the app crash, you may re-enable it from Settings > Updates > Automatically Check for Updates
Note: We have now officially retired the support for Kalam Kernel on macOS 10.13 (OS X El High Sierra) and lower. Though the "Legacy" MTP mode will continue working on these outdated machines.
Read more: https://github.com/ganeshrvel/openmtp/tree/release/3.2.10-beta.1#system-requirements-and-support
Download:

Apple Silicon (mac M1/M2): openmtp-3.2.10-beta.1-mac-arm64.dmg
Intel Silicon (Older mac): openmtp-3.2.10-beta.1-mac-x64.dmg

Fixed the issue in https://github.com/ganeshrvel/openmtp/pull/314. Closing


f_startswith

When running diags,  f_startswith is frequently used. For eaxmple f_startswith('HadISST').  The problem in this case is that each of 'HadISST_PD_1', 'HadISST_PI_1', 'HadISST_1' starts with HadISST. So this particular case may or may not be computed. The latter appears to be happening. There are other cases of this for other experiments.  This is a significant issue.

f_startswith('foo') should be about the same as the shell expression "foo*".   For this situation, we need a different filter.   This particular case may work with things like f_startswith('HadISST_1'), but in general f_startswith cannot be a complete solution.  We could add more filters, or support traditional regular expressions, or let the shell expand an expression and take a (lengthy) file list instead  (that probably works already, but I'm not sure.)  For very complicated situations, I think that the best solution is for the user to set up more than one directory.

The kludge I'm pursuing is to rely on the name of the file to have some extra XXX as in the case of HadISST_PD_ and HadISST_CL_.  The other cases such as CERES follow this pattern.  This solution is easily defeated and we need to rethink it.

So you're thinking of a new filter.   The filenames we encounter are (at present, for ACME and obs only) very standardized, so I wouldn't call it a kludge if you're only targeting our present users.  Anyway, I'd give the new filter a new name.


Teensy 3.2 RX not working

Hello everyone,
I achieve to make Pro Mini 3.3V boards communicate and ranging between them quite easily. But I am facing an issue to do the same with Teensy 3.2 boards (which are also 3.3V).
I respect the testbed indicated in the Wiki (Teensy and Pro Mini have similar pins and the Teensy outputs 250 mA which is enough to power the DWM1000) and I manage to make the BasicConnectivityTest and BasicSender sketchs work.
With the BasicReceiver sketch, the interruption is raised but when the library is verifying if there is an error with the #isClockProblem() method, the CLKPLL_LL_BIT is set. If I artificially avoid this check, the message seems to be corrupted with unreadable special characters.
I saw that few persons have this same error with multiple devices based on the issue https://github.com/thotro/arduino-dw1000/issues/42 : Arduino Pro Mini as sender and Arduino Mega as receiver, Arduino Leonardo as sender and receiver, Arduino Uno as sender and Arduino Ethernet as receiver.
This is perfectly working for me with Pro Mini 3.3V boards, so this is certainly linked to a material issue (the fact that the processor on the Teensy 3.2 is not an ATMEL 328 ?).
Does anyone actually use some Teensy boards to communicate with DW1000 chips ?
Thanks in advance for any help about this subject.

Did you try it with patch #131?

Thanks to the last merge of the #131 patch, I am now able to send an receive messages with Teensy. But please note that I had to configure the IRQ pin as INPUT to make it work. I added this code in the ::begin function of the DW1000 class :
void DW1000Class::begin(uint8_t irq, uint8_t rst) {
    // generous initial init/wake-up-idle delay
    delay(5);
    // Configure the IRQ pin as INPUT
    pinMode(irq, INPUT);
    // start SPI
    SPI.begin();

Some clock errors are still raised time to time but I suspect that this is due to a wire on the breadboard so I will investigate on this point and complete my answer as soon as I have more informations.

I think the different implementations of the HAL cause the need of a pinMode(irq, INPUT);.
But I see no reason against an additional pinMode(irq, INPUT);, so may make a pull request? @HappyDr0id

The communication between Arduino Pro Minis is also working even if I add this pinMode configuration, so yes, I will make a pull request to add this and fix the Teensy problem.

I solved a similar issue on ESP8266 by changing the SPI max speed.
https://github.com/thotro/arduino-dw1000/blob/master/src/DW1000.cpp#L99
18Mhz seems an appropiate value with Teensy running at 72Mhz (SPI_CLOCK_DIV = 4).

@cimbalo hi I'm trying DWM1000 with ESP12E. I'm able to run basic connectivity program but unable to do basic sender and receiver programs.  How you made setup and what changes you made.

@sarwadenj as I wrote before I solved the issue by changing SPI max speed.
https://github.com/thotro/arduino-dw1000/blob/master/src/DW1000.cpp#L99
The value I used for ESP8266 is 20Mhz.

@cimbalo Please add your hint to the wiki. Thanks :)

Unfortunately I still get a lot of clock errors and they are not due to a bad contact or wires (the same breadboard and cables are working perfectly with Pro Mini boards). I think that there is still another implementation problem than the LDE load.
Futhermore I have to overclock my Teensy boards to 96Mhz (normal is 72Mhz) to have some working communications which is weird. I will investigate on the Decawave configuration part and update the issue if I get any details.

Hi Bro,
I am also working on this project as well. Can I ask have you work it out now?Thanks.


Update Paparazzi to 1.2.0

Codecov Report

Merging #752 (e9472c3) into main (4ae275b) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e9472c3 differs from pull request most recent head d0cb20a. Consider uploading reports for the commit d0cb20a to get more accurate results

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   70.28%   70.28%
=======================================
  Files         112      112
  Lines        5530     5530
  Branches     1108     1108
=======================================
  Hits         3887     3887
  Misses        888      888
  Partials      755      755

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


mono ?

With another obfuscator we had a lot of problems with a .net 4.7 program that runs perfectly without obfuscation. Any positive or negative experience with DotRefiner regarding mono?

Other obfuscation tools are not discussed here.

Sorry, I mixed up names, I meant to ask this for obfuscar. .. will post again.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Lex Li<EMAIL_ADDRESS>Sent: Saturday, April 6, 2019 2:41:10 PM
To: obfuscar/obfuscar
Cc: WGMaker; Author
Subject: Re: [obfuscar/obfuscar] mono ? (#193)
Other obfuscation tools are not discussed here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fobfuscar%2Fobfuscar%2Fissues%2F193%23issuecomment-480505078&data=02|01||8ba1640e96b64954924608d6ba9587dc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636901548715818272&sdata=0h66siMfvosm5Yn%2FrqlIja1RFNhF0iZcRUKQFvpw3Ac%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAImy8eLv_nQjdNURRXDe2BYxQG6nKSvaks5veKP2gaJpZM4cgJqg&data=02|01||8ba1640e96b64954924608d6ba9587dc|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636901548715828277&sdata=djJ86IipjosIr0XKDA9jdRZ2F%2F%2FfdSxCqHZIYm2%2BQCc%3D&reserved=0.


docs: fix wrong filename mentioned in INSTALL.md

SUMMARY
INSTALL.md mentions Dockerfile.from_tarball, but it's actually Dockerfile.from_local_tarball
ADDITIONAL INFORMATION

[ x ] Has associated issue: Fixes #14629

thanks @jeverling for this catch!


[Q]: Changing Team Type to Academic

Ask your question
You have exceeded 100% of your tracking hours. Please upgrade your plan to continue using W&B without disruption.
Today i want to check the result of my model and find this problem. How can i solve it?

Hi @lzl60109, thank you for writing in. I order to get your team to be academic, you will need to attach an academic email to it in user settings, in the top right corner of the UI. Could you send me your username so I can take a look into it?

Sure, my username is<PHONE_NUMBER>9, and i add my academic email<EMAIL_ADDRESS>for your help!

Hi @lzl60109! Thank you for the follow up! I have turned your org academic. Let us know if there is anything else we can help with.


Add conusl dns check

[#108474830]

Story link: https://www.pivotaltracker.com/story/show/108474830

Fixed this up and committed in 66c3620251e5ce713cec3c993b7d308a2a6898cc. Thanks Stefan!


HOSTEDCP-1436: Make nodepool.spec.aws.subnet required

What this PR does / why we need it:
Make nodepool subnet field required, as nodepools will fail to provision if subnet is not specified.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1436
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/area hypershift-operator

/remove do-not-merge/work-in-progress

/retest-required

/retest-required

/retest-required

/lgtm


🐛 inferred types for optional arrays of objects not working

Inferred types are coming through as undefined.
Sample
Given this format:
const MyMessage = new BinaryCoder({
  people: Optional([{
    id: Type.UInt,
    name: Type.String
  }])
})

the expected type inference is:
{
  people?: Array<{ id: number, name: string }>
}

but instead we get:
{
  people?: undefined
}

It does however work for all other combinations (optional array of plain values, optional object, arrays of objects etc.).
See relevant code

src/core/Type.ts (lines 75-81)

Optional arrays shouldn’t really be supported — an empty array is 1 byte


Update or remove install_os_dependencies.sh?

I saw people experiencing problems with this utility at PyCon.  There is also http://stackoverflow.com/questions/37467088/cant-run-migrations-when-setting-up-a-project-with-cookiecutter-django
The problem is maintaining global scripts like this is hard, I don't ever use them personally because they are so fragile. I don't teach people to use them for this same reason, in fact, I suggest they stay away from them.
Finally, it's possibly outside the scope of this project. A tutorial for setup is one thing, an official script is another.
Mitigations:

Have someone volunteer to actively maintain this particular script, and to resolve questions asked by users of the script. The problem is the nigh complete lack of incentive to do so.
Remove these utility scripts from the project, possibly linking to another optional project that includes them.
Remove them altogether and stay with tutorials.

Thoughts?

I think they should be removed.
I'have experienced many package not found errors when trying to install OS dependencies with them. And back that time I was running an up to date Debian Testing system. I tried it again recently with Ubuntu 16.04 (up to date) and it didn't work either.

I think it would be necessary to improve the entire mechanism (not removing it, because it's quite useful), including all the different names and versions of each package for each distribution (including debian, that actually doesn't works). That would resolve all this issues.

If anyone can help us out by submitting a pull request to do the following, we'll consider keeping it:

Update install_os_dependencies.sh
Document how to use install_os_dependencies.sh in a new document in docs/

as a historical reference:
I created this install_os_dependencies.sh script and requirements.apt file as part of the resolution of the issue https://github.com/pydanny/cookiecutter-django/issues/34 .
I needed to document the non-python dependencies, and rid our users (I'm included in this group) to have the tedious work to check which python dependencies have non-python compilation dependencies (like c/c++ libraries).
In requirements.apt, I also needed to document what Y libraries non-python is required by X python library. so I also needed comments in requirements.apt file .
however, I needed a simpler way to get all the package names on one line, to be easy to pass them as parameter to apt-get install. copy and paste was not being very productive due to comments.
install_os_dependencies.sh was created to solve this. parse requirements.apt file, get all package names and them pass as parameter to apt-get install
it only works with Ubuntu 14.04 and recently also with Ubuntu 16.04, but this is not a problem, since, undocumented restriction of this project only officially support Ubuntu (Ok, the generated project works perfectly on other operational systems without or almost without modification)
this was one of the reasons I have been against the https://github.com/pydanny/cookiecutter-django/pull/250 and https://github.com/pydanny/cookiecutter-django/pull/438
said that,
This https://github.com/pydanny/cookiecutter-django/pull/605 solves a problem that was introduced in https://github.com/pydanny/cookiecutter-django/commit/2f6315d606043a768356ad1c9f5a907b42576dba and solve #569

I see, thanks for the explanation @luzfcb. I think there was some confusion here on our part, sorry about that.
I like #605. I will try to get to reviewing it asap.

I'm closing this old issue. We've keeping this script up to date and, as far as know, there has been little to no complains with it.


Some CI builds are taking an unbelievably long amount of time

For some unknown reason, some CI builds regularly take ~6 hours to finish.

Slightly odd is some of them are taking longer to complete than the single job in the workflow. Here, Desktop only takes 21 minutes to complete, but the entire build takes 6 hours.


Queue.LfrQueue - unexpected size after adding same item twice

I'm not sure this is expected (are you not allowed to enqueue the same item twice?)
Minimal example:
empty |> enq 0 |> enq 0 |> size
--> 3

Trying it out in elm-repl:
> import Queue.LfrQueue exposing (..)
> empty |> enq 0 |> enq 0 |> size
3 : Int
> empty |> enq 0 |> enq 0
([0],[0,0]) : Queue number
>

The test that found this:
fuzz (Fuzz.list Fuzz.int) "empty+enq+size: behaves like stdlib queue" <|
    \items ->
        let
            lfrQueue =
                List.foldl enq empty items

            stdlibQueue =
                List.foldl (::) [] items
        in
        size lfrQueue
            |> Expect.equal (List.length stdlibQueue)

I'm guessing this should use left and right once each instead of using left twice
https://github.com/amenzwa/pfd/blob/main/src/Queue/LfrQueue.elm#L34

Martin, Okasaki's Standard ML implementation for left-right queue (which he calls BatchedQueue) on p.43 is  fun snoc ((f, r), x) = checkf (f, x::r), which I mistranslated into Elm as enq x ( f, r ) = checkF ( f, x :: f ). The correct translation is enq x ( f, r ) = checkF ( f, x :: r ). I just fixed this bug, and updated the test case, too.
Thank you so much for finding this bug.


disable restore postgres-operator-client

Thanks for developing such a user friendly tool postgres-operator-client, I love it. So I followed this page https://access.crunchydata.com/documentation/postgres-operator-client/0.2.0/reference/  to test some functions I often use.
I can do backup and restore with it successfuly.
after I restored successfully with oc pgo restore command, I want to disable the restore, so I issued command:
[zhaoch@~]$oc pgo restore disable pnst
Error: PostgresCluster.postgres-operator.crunchydata.com "pnst" is invalid: spec.backups.pgbackrest.restore.repoName: Required value
[zhaoch@~]$
[zhaoch@~]$oc pgo version
Client Version: v0.2.0
Operator Version: v5.3.0
[zhaoch@~]$
[zhaoch@~]$oc pgo restore disable -h
Update a PostgresCluster spec to disable restores.

This is recommended after your restore is complete. Running "pgo restore" will enable restores again.

RBAC Requirements:
    Resources                                           Verbs
    ---------                                           -----
    postgresclusters.postgres-operator.crunchydata.com  [get patch]

Usage:
  pgo restore disable CLUSTER_NAME [flags]

Flags:
  -h, --help   help for disable

Global Flags:
      --as string                      Username to impersonate for the operation. User could be a regular user or a service account in a namespace.
      --as-group stringArray           Group to impersonate for the operation, this flag can be repeated to specify multiple groups.
      --as-uid string                  UID to impersonate for the operation.
      --cache-dir string               Default cache directory (default "/home/zhaoch/.kube/cache")
      --certificate-authority string   Path to a cert file for the certificate authority
      --client-certificate string      Path to a client certificate file for TLS
      --client-key string              Path to a client key file for TLS
      --cluster string                 The name of the kubeconfig cluster to use
      --context string                 The name of the kubeconfig context to use
      --insecure-skip-tls-verify       If true, the server's certificate will not be checked for validity. This will make your HTTPS connections insecure
      --kubeconfig string              Path to the kubeconfig file to use for CLI requests.
  -n, --namespace string               If present, the namespace scope for this CLI request
      --request-timeout string         The length of time to wait before giving up on a single server request. Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't timeout requests. (default "0")
  -s, --server string                  The address and port of the Kubernetes API server
      --tls-server-name string         Server name to use for server certificate validation. If it is not provided, the hostname used to contact the server is used
      --token string                   Bearer token for authentication to the API server
      --user string                    The name of the kubeconfig user to use
[zhaoch@~]$

My postgrescluster pnst has below configuration after the restore.
spec:
  backups:
    pgbackrest:
      (ignore)
      restore:
        enabled: true
        options:
        - --type=immediate --set='20230323-073800F'
        repoName: repo1

Could you please let me know why I got this error message?
[zhaoch@~]$oc pgo restore disable pnst
Error: PostgresCluster.postgres-operator.crunchydata.com "pnst" is invalid: spec.backups.pgbackrest.restore.repoName: Required value

Hi Eric-zch,
Hi have tried to reproduce your problem. My current version is:
$> kubectl-pgo version
Client Version: v0.3.0
Operator Version: v5.3.0

To be in the same conditions, I created a crunchy cluster, made 3 backups:
stanza: db
    status: ok
    cipher: none

    db (current)
        wal archive min/max (14):<PHONE_NUMBER>00000000000001/000000010000000000000006

        full backup: 20230423-185330F
            timestamp start/stop: 2023-04-23 18:53:30 / 2023-04-23 18:53:39
            wal start/stop:<PHONE_NUMBER>00000000000002 /<PHONE_NUMBER>00000000000002
            database size: 33.5MB, database backup size: 33.5MB
            repo1: backup set size: 4.2MB, backup size: 4.2MB

        full backup: 20230423-185348F
            timestamp start/stop: 2023-04-23 18:53:48 / 2023-04-23 18:53:57
            wal start/stop:<PHONE_NUMBER>00000000000004 /<PHONE_NUMBER>00000000000004
            database size: 33.6MB, database backup size: 33.6MB
            repo1: backup set size: 4.2MB, backup size: 4.2MB

        full backup: 20230423-185450F
            timestamp start/stop: 2023-04-23 18:54:50 / 2023-04-23 18:54:55
            wal start/stop:<PHONE_NUMBER>00000000000006 /<PHONE_NUMBER>00000000000006
            database size: 33.7MB, database backup size: 33.7MB
            repo1: backup set size: 4.2MB, backup size: 4.2MB

Then restore the cluster with the kubectl pgo :+1:
$> kubectl-pgo restore source-cluster -n test-clone --repoName repo1  --options '--type=time --target="2023-04-23 18:53:57"'

when the restoration completed, I executed the command:
$> kubectl-pgo restore disable source-cluster -n test-clone
postgresclusters/source-cluster patched

May be you should upgrade to the latest version.

Hi @boris-lenzinger
May I know where I can get client version v0.3.0?
From https://github.com/CrunchyData/postgres-operator-client/releases, the latest version is v0.2.0

Hi @Eric-zch ,
I have rebuilt the repository. I didn't notice that the published version was 0.2 !
The version is in the file pgo.go in package cmd. You can check that it is now 0.3. Rebuilt is quite easy. Download Go, add the bin folder to the path and execute make build. This will produce the binary in the bin folder.

@Eric-zch Thanks for the kind words about the postgres-operator-client and @boris-lenzinger thanks for working through the issue!
This seems complete, so I'll close this issue, but feel free to reopen if there's something I missed.


Core: Improve internal async handling

Fixes gh-1016
Ref 1f00d5fa3b7064bdecec7b984fe9c15c38df2113
@trentmwillis: Sorry for essentially redoing gh-1017, but investigation of https://github.com/jquery/qunit/pull/1017/files#r69368544 got out of hand and I ended up doing a large chunk of the async cleanup we talked about. Let's call it a half rewrite, but it does resolve gh-1016 without introducing new properties (and in fact still removes resumed).

I'm fine with the overall changes. It's great to see this is getting a substantial fix and a collaborative work. :)
Waiting for @trentmwillis.

Excited to see this, will try to do an actual review tonight.

Looks good to me. Just to make sure I followed everything correctly: async control is now handled by internalStop() and later calling resume() except in recovery cases where we need to call internalRecover(). There shouldn't be any need to call begin() or internalStart() directly, right?
Also, would we want to consider exposing recover to help with stuff like #990?

Looks good to me, just a couple questions real quick. Just to make sure I followed everything correctly: async control is now handled by internalStop() and later calling resume() except in recovery cases where we need to call internalRecover(). There shouldn't be any need to call begin() or internalStart() directly, right?

Correct.

Also, would we want to consider exposing recover to help with stuff like #990?

Possibly. The public function would do something like internalRecover( config.current ).

Merged. @leobalter can you release a patch version?


Publish docs from main branch failing

Describe the bug
Publishing docs via GitHub Pages is currently erroring from the workflow on main branch
Steps to reproduce

Make change to mkdocs documentation
View the Publish docs via Github Pages workflow result after merge to main

Example:
https://github.com/microsoft/AzureTRE/runs/5479916535?check_suite_focus=true

Possibly now fixed with #1509

Added #1510 to enable manually running the docs publish to verify

https://github.com/microsoft/AzureTRE/runs/5550781660?check_suite_focus=true

😄


Button not appearing in some G-suite apps

OS version: macOS Catalina 10.15.4
Browser version: Chrome 81.0.4044.138
Extension version: 1.60.9

Relevant integration (if any):

Google Inbox - inbox.google.com
Google Mail - mail.google.com
Google Docs - docs.google.com
Possibly also Google Classroom - classroom.google.com
🐛 Describe the bug

After ticking mentioned apps from TB Integrations tab, button does not appear in the apps.
I'm unsure where to look for TB in Google Classroom as it's not included here (neither are Google Keep examples fyi).
Expected behaviour

Steps to reproduce

Steps to reproduce the behaviour:

Go to ...
...

Other details or context

Case reference

I think the integrations seem to be fine, but the integration list has some issues. It'll show all Google integrations as enabled even if you only enabled one of them - and the others will not work. Will look into it

I tested the integrations as well and Classroom isn't working, the selector we're using is out of date. @kadrihvl have there been any requests Classroom? I don't know where the button should be so if we had any user feedback that would be helpful. Or maybe we should drop it if no one is using it?
We also need to remove Inbox since that's no longer around.


Load data to persist asynchronously

Basically I want to load firebase remote config parameters when app starts and store it in app state while creating store.
So that whenever I need it I just fetch it from store and get remoteConfig value.
class App extends StatelessWidget {
// Get firebase remote config and store it in appState
---> final store = createStore();
App();
@override
Widget build(BuildContext context) {
return new PersistorGate(
persistor: persistor,
loading: new LoadingScreen(),
builder: (context) => new StoreProvider(
store: store,
child: new MaterialApp(
title: 'D11 Sport Predictor',
theme: defaultTargetPlatform == TargetPlatform.iOS
? kIOSTheme
: kDefaultTheme,
routes: getRoutes(context, store),
initialRoute: '/login',
)),
);
}
}
Create Store file -
Store createStore() {
Store store = new Store(
appReducer,
// store remote config in initial app state
initialState: new AppState(),
middleware: createMiddleware(),
);
persistor.load(store);
return store;

}

await persistor.load(store);
I also recommend putting the persistor declaration inside your main, and awaiting before doing runApp.


onCompleted() not fired in chunked downloads

Hi,
I've just started using Fetch and it seems exactly what I was looking for, but I'm facing a problem. I've seen that the library doesn't call FetchListener -> onCompleted() when downloading a file with an unknown length. The file is downloaded correctly, but the downloader doesn't know that it has finished. In my case, the server I'm connecting to is not including the header 'Content-Length' in the responses. Instead, it is including the header 'Transfer-Encoding' to 'chunked' (I've checked that this is the problem).
That should be not an issue, since I can make the same request using OkHttp3 without a problem. Because of this, I used fetch2okhttp as the downloader, but the result is the same, so I guess is a problem with the implementation of the class Downloader or I am missing something. Also, I'm not familiar with Kotlin, so I can't move through the code very easely.
Any hint?
Thanks.
FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(App.getContext())
                .setHttpDownloader(new OkHttpDownloader())
                .build();

Fetch fetch = Fetch.Impl.getInstance(fetchConfiguration);

String url = "https://www.httpwatch.com/httpgallery/chunked/chunkedimage.aspx?0.01891488106459449";
String file = App.getContext().getFilesDir() + "/" + "chunked.jpg";

Request request = new Request(url, file);
request.setPriority(Priority.HIGH);
request.setNetworkType(NetworkType.ALL);
fetch.enqueue(request, null, null);

fetch.addListener(new AbstractFetchListener() {
    ...   // onCompleted() is not fired
});

That should be not an issue, since I can make the same request using OkHttp3 without a problem
Try to use your okhttpclient that works:
OkHttpClient customOkHttpClient = new OkHttpClient();

FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(App.getContext())
                .setHttpDownloader(new OkHttpDownloader(customOkHttpClient))
                .build();

The OkHttp3 client that was working for me was exactly that, the default client with no further settings. Passing it as an argument for the constructor of OkHttpDownloader doesn't fix the problem, though.

@sysseon I was able to replicate this bug. Working on a fix

11-02 11:28:04.931 10640-10720/? W/OkHttpClient: A connection to http://mysite.sk/ was leaked. Did you forget to close a response body?
... if this helps

@sethchhim @sysseon Was on vacation. hoping to release the new version sometime today or tomorrow. Please check back later.

cheers, I tried to fix that, but I failed...need to get more knowledge on Kotlin, though...
anyways, as I googled, I noticed it's most importantly a server side issue, so we turned off gzip on it, and downloads now working...but if you found a way to resolve this issue with no ContentLength returned, that's brilliant...thank you!!!

Please update, it's a major problem that renders the library useless for us and I don't want to change libraries..

@sysseon @sethchhim @mariaanko @Shailevy Just released a new Fetch version. 2.3.0-RC1. This version has lots of fixes and breaking changes so be sure to check out the CHANGELOG.
`This bug should now be fixed for both Parallel and Sequential Downloaders. Please let me know if it works well for you.

Working perfect now! Thanks a lot Tonyo!


Login To Linux keyword sometimes fails over serial console

Device

RTE version

OSFV version
Develop branch, latest commit 2923c8f7da762b26c52e9853b2eca8751dc98de8
Affected component(s) or functionality
No response
Brief summary
Keword times-out
How reproducible
100%
How to reproduce
Run dasharo-compatibility/efibootmgr.robot
Expected behavior
Tests run or skip properly depending on the DUT
Actual behavior
Suite hangs on setup/teardown
Link to screenshots or logs

Additional context
Login To Linux keyword waits for "login:" string. This has failed due to unclear state of the DUT after other suites.
For example, when run with other suites, "login:" could not be found, however manual login to machine shows that it is already logged in with ubuntu user.
Even if user is not logged, connecting via telnet shows no prompt, unless machine is actively booting and we connect just in time to catch "login:" prompt.
Solutions you've tried
No response

@SebastianCzapla If you analyze what this keyword does, you will notice:

It enables power supply via sonoff (at this point Protectli already starts, as it boots on power applied)
It pressess the power buttin - powering down the unit.

The following diff lets this first test to be executed:
diff --git a/lib/options/uefi-setup-menu.robot b/lib/options/uefi-setup-menu.robot
index 0a5d056ee00e..ebd6642227e4 100644
--- a/lib/options/uefi-setup-menu.robot
+++ b/lib/options/uefi-setup-menu.robot
@@ -86,7 +86,7 @@ Measure Coldboot Time
     Log To Console    \n
     # Do one more iteration than requested, as we may hit first boot which is always longer.
     FOR    ${index}    IN RANGE    0    ${iterations}+1
-        Power Cycle On    power_button=${TRUE}
+        Power Cycle On
         Boot System Or From Connected Disk    ubuntu
         Login To Linux
         Switch To Root User

I think to properly resolve it, we need to implement the support of achieving desired power state in the osfv_cli: https://github.com/Dasharo/osfv-scripts/issues/69

erformance/boot-time-measure.robot
==============================================================================
Boot-Time-Measure
==============================================================================
qCBMEM001.001 Serial boot time measure: coreboot booting time after... ..

q(0) Boot time: 1.453645 s
(1) Boot time: 1.448787 s
(2) Boot time: 1.453494 s
(3) Boot time: 1.452893 s
(4) Boot time: 1.450988 s
(5) Boot time: 1.448356 s
.
Coreboot average booting time: 1.4509035999999997 s

.
Coreboot shortest booting time: 1.448356 s

.
Coreboot longest booting time: 1.453494 s

.
Coreboot booting time std dev: 0.002080637844508275 s

CBMEM001.001 Serial boot time measure: coreboot booting time after... | PASS |


power_monitor/voxlpm - add support for voxlpm v3 (INA231 sensors)

Describe problem solved by this pull request
This PR adds support or the voxlpm v3 (https://docs.modalai.com/power-module-v3-datasheet/)
This is very similar to the voxlpm v2 but instead uses INA231 sensors.
This PR also adds the deprecated BAT_* params that QGC complains about since we aren't using the battery_status module on this board.
Describe your solution
Detect at runtime which voxlpm is attached by querying the I2C bus for known addresses to determine which is attached to flight controller and initialize accordingly.
Describe possible alternatives
Possible alternatives is to create individual drivers for LTC2947 (voxlpm v2) and INA231 (voxlpm v3) and initialize each....  Since the driver work to talk to the INA231 and LTC2947 is very minimal and the 'application' portion of the support was larger, I decided to go with the approach in this PR.... I'm not against changing if needed.
Test data / coverage
Bench tested both voxlpm v2/v3, flight tested voxlpm v2 after updates, and planning on flight testing voxlpm v3 on 5/7 (hence this is a draft)

Flight tested both flavors with success.
For technical notes... our FlightController can't be powered off USB.
VOXLPM v2 has a DC jack, so you can do standard ESC cal by having the DC jack installed and then later insert battery and use QGC happily.
VOXLPM v3 doesn't have DC jack, so I have to do ESC cal via command line to get around the workflow of QGC, I've documented process here: https://docs.modalai.com/flight-core-pwm-esc-calibration/

@dagar anything I need to change to get this guy goin?

@dagar anything I need to change to get this guy goin?

I wanted to get rid of the duplicate parameters, but haven't looked into it in enough detail to know what the right thing to do is.

OK @dagar, what do you think here....  I'm trying to get this into v1.11.1
I can just kill those params on my end and accept the warning in QGC.


WDATP cohabitation with Intune Endpoint Protection

Can WDATP cohabit with Intune Endpoint Protection, or with other words, can MMA for WDATP cohabit with System Center Management, or is MMA able to talk to WDATP as well as Intune ? Thanks in advance,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc8aadae-3a51-93c6-8079-cbd0933471ae
Version Independent ID: c82444f6-186d-cbee-9b05-9d6d705f44b6
Content: Onboard previous versions of Windows on Windows Defender ATP
Content Source: windows/security/threat-protection/windows-defender-atp/onboard-downlevel-windows-defender-advanced-threat-protection.md
Product: w10
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Hi jmrita,
Thank you for the question. I'm not sure I understand. Are you asking if Microsoft Monitoring Agent can be used with SCCM? Can you help me understand the question better?
Thank you


Patching ScaledObjects in the operator when they already exist

In certain situations, a valid update to an HTTPScaledObject won't trigger any in-kind update to the corresponding ScaledObject
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[x] Any necessary documentation is added, such as:

README.md
The docs/ directory
The docs repo

Fixes #323
Fixes #20

@tpiperatgod I submitted this in favor over #324, FYI.


helm list -A does not show the correct namespace

Output of helm version:
v3.10.1+g9f88ccb
Output of kubectl version:
Client Version: v1.25.3
Kustomize Version: v4.5.7
Server Version: v1.25.0
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
minikube version: v1.27.0
commit: 4243041b7a72319b9be7842a7d34b6767bbdac2b

How to see the problem:

suppose to have a chart named "mychart"
create a file  namespace.yaml inside template such as  the following:
apiVersion: v1
kind: Namespace
metadata:
name: {{ .Values.namespace }}
in deployment.yaml as well as service.yaml specify the name space as part of metadata eg. the following:
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "mychart.fullname" . }}
namespace: {{ .Values.namespace }}
set namespace in values.yaml  for example to development as for the following:
namespace: development
now that you have a Chart ready to go execute helm:
helm install mychart
note: without to specify namespace due to the fact we have namespace.yaml for that.

Result:

namespace.yaml --- (OK) cause to create a new namespace "development" if we follow the example above
deployment.yaml --- (OK) application due to metadata is installed in the correct namespace and so under
service.yaml -- (OK) is installed accordingly with the namespace in metadata

so executing :
Kubectl get all -A
all seems to be in the correct place.
Instead executing:
helm list -A
mychart result under namespace "default" and not under namespace "development" as expected.
The workaround is to force the namespace calling helm with -n option, but I guess this result is inconsistent since de facto all have installed under a "development" namespace.
Also moving namespace.yaml as template no make anymore sense if I have to double it both in values.yaml as well as during installation.
So, expected result should be to have helm list -A reporting the installation namespace accordingly with the installation or report an error in order to avoid an inconsistent status and to force user to work correctly.

This is the correct behavior. You're installing the helm release in default by not specifying a namespace for the release. The kubernetes resources are installed in the namespaces you specified in the templates/values, but the helm release is in default.
To verify this, check out kubectl -n default get secrets and see the release secret that is stored there.

Dear Joe,
thanks so much for your answer! however, this not explain the inconsistency, may be I didn't explain well enough, so let's try again and hopeful this time you will get the point.
chart name  my-chart
file: namespace.yaml
apiVersion: v1
kind: Namespace
metadata:
name: {{ .Values.namespace }}
labels:
istio-injection: enabled
values.yaml
...
namespace: my-ns
....
then execute the following:
helm install my-chart -n my-ns --generate-name
Error: INSTALLATION FAILED: create: failed to create: namespaces "my-ns" not found

Well we have an error since "my-ns" will be create only when  "namespace.yaml" will be processed, this means that no make sense to have the "namespace.yaml" inside the chart.
the workaround
kubectl create namespace my-ns
kubectl label namespace my-ns istio-injection=enabled
NOW that we have the namespace and we can try again the command, but
helm install my-chart -n my-ns --generate-name
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: Namespace "my-ns" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm";  .....
OPS, we have a new error, then let's try to REMOVE "namespace.yaml" from the chart and then execute again the command
helm install my-chart -n my-ns --generate-name
This time it works.
CONCLUSION:

if you use to create a namespace in your chart in order to install all under such namespace, you cannot have the chart itself in this namespace since it is not jet created and then you should have the chart installed in any other namespace already existing
if you create the namespace before to install the chart, then you have to remove any "kind: Namespace" from your chart or this will generate an error. So, which is the sense to have "template" if we have to partially manage stuff with kubectl?

SUGGESTION:
Since namespaces have the highest priority, could be nice to check all namespace before to exit with an error, so coming back to the condition where we have "namespace.yaml" and we execute the command
helm install my-chart -n my-ns --generate-name
Before to exit with error, could be nice to search if the chart the creation for the same namespace provided as parameter for the installation and if yes, then continue, if not then in this case return an error.

I hope now is much more clear, anyway up to you to reopen or to keep closed the issue.

@fe-dagostino just faced the exact same issue with istio, thanks for explaining your workaround!


IPv6 support

Describe the bug
momentjs.com lacks IPv6 addresses and thus resources (JavaScript) from it can't be received using IPv6.
Since the CDN seems to be served by Cloudflare, which has great IPv6 support, it should hopefully be a simple fix by enable IPv6 in dashboard, as per their IPv6 documentation.
Thank you.
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version 90

Which CDN are you using?


Tamil is mainly not rendering on windows

The Tamil translation is not rendering properly on Windows.
Except for the title bar all you see is little squares.

For non-tamil users (that may not have Tamil characters loaded) I have replaced the Tamil writing system text for Tamil in the language drop down with a simple 'Tamil' (in English). This will prevent non-Tamil users seeing little squares in the language drop down and won't particularly affect Tamil speakers.
(It does not fix Tamil characters actually rendering properly)

This went out in the 0.1.2 release so closing.


cannot call method 'split' of undefined - ajax modal

Had an issue when i was calling a modal and loading a page via ajax..
The page had a datepicker which values was set via php
It worked the first time but if you closed the modal and re-opened it, it would lose the value of date which caused the date.split(format.separator) to fail which failed all other plugins.
Not sure why this was happening.
Had to revert to normal jquery datepicker as no time to mess around with it.

Thank you @songaal
Now after your hack and also playing around with z-index, the datepicker works great with bootstrap modals  :+1:

Thank you! Replacing the file with eyecon and it works!


Set environment variables for all VSCode child processes

Node accepts various settings through the NODE_OPTIONS environment variable, for example --stack-trace-limit or --max-old-space-size. I'd like to be able to configure NODE_OPTIONS such that all processes (including those spawned by first-party or third-party extensions, like the ESLint or TypeScript ones) are affected by it.
More generally, I'd like to set environment variables that apply to the whole VSCode context; Node is the primary use case, but many other tools let us tweak their behaviours this way, so it'd be more widely applicable than just Node.
For security (given the presence of --require in the list of flags allowed in NODE_OPTIONS), this feature should probably be reserved to trusted workspaces.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Update _client.py to allow server and port in the Client constructor

Simplify python client instance creation
pyuda.Client.server = 'my.server.hostname'
pyuda.Client.port = 56789
client = pyuda.Client()

Can now we replaced by
client = pyuda.Client('my.server.hostname', 56789)

Also, I think  __metaclass__ = ClientMeta is redundant in _client.py if we are using six.with_metaclass(..)

If we are not targeting Python2 anymore, maybe we can replace the six.with_metaclass(....) with the standard metaclass(...) and remove the six dependency?

Review for UDA v3.0


Minor: Improve parquet PageIndex documentation

Which issue does this PR close?
N/A
Rationale for this change
While reviewing https://github.com/apache/arrow-rs/pull/6011 from @etseidl I noticed that the ColumnIndexBuilder is not documented so I wanted to improve the situation
What changes are included in this PR?

Document ColumnIndexBuilder
Improve some documentation on the OffsetIndex / ColumnIndex structures as I always find them confusing

Are there any user-facing changes?
Doc changes only, no functional changes

I plan to merge this PR tomorrow unless there are any more comments from reviewers.
Thank you very much @progval  @jhorstmann and @mapleFU

Thanks again everyone