Extend API documentation

@arnauqb This issue is in reference to the JOSS Review https://github.com/openjournals/joss-reviews/issues/5776
Currently, the documentation website contains the API documentation to the submodules infer and models. Please also add the API documentation to all remaining functionality (e.g., blackbirds.simulate) to the docs.
Furthermore, there is no documentation for some code, such as the entirety of blackbirds.posterior_estimators. Please write docstrings and add that to the docs as well.
Thank you!

Should be addressed in https://github.com/arnauqb/blackbirds/pull/46/commits/6ef774955981b1606f51dc8e5965c56fb0bd60ad as part of https://github.com/arnauqb/blackbirds/pull/46


Keep track of latest commit id from responses

Is your feature request related to a problem? Please describe.
Knowing if the branch changed is hard without using the HTTP api directly, also if there is a need to listen to some other headers returned from the server. The immediate idea is to be able to introspect the latest branch commit tag returned in the calls.
Describe the solution you'd like
Idea is that TerminusDB response headers are parsed and the latest value seen of the terminusdb-data-version header is made accessible in the client. This would enable clients to check if there is a serverside change and know that it's time to invalidate data locally.
Describe alternatives you've considered
This would be hard to accomplish without playing nicely with the TerminusDB client. Injecting something into the http flow could be an option, or move to a pure local HTTP API, but that would not help the community.
Additional context
N/A

In this moment with the client we return only the response.data or {
result: response.data,
dataVersion: response.headers['terminusdb-data-version']
}
if getDataVersion is true
Could be useful have back the complete server response?
I mean the response without any filter so you can have the data result + all the headers and all the others info

I had not seen/thought of getDataVersion, thanks for the pointer. I believe I can make it work with it for most (if not all) cases. Effectively what I look for is already implemented and I think this should be closed. What was important was to get the version in this case. I don't have any immediate other headers that would be relevant, at least not at the moment.
It could be, to share the thought, interesting to inject a function into the dispatcher perhaps, to allow such "aspect-orientated" ways of handling requests and responses along the request pipeline, but no need for it at the moment from what I see.
I suggest to close the issue, but leave it open if you have any other thoughts. Thanks again for the pointer to getDataVersion!

Perfect!! I'm closing this. we can reopen it later if we need


AMG without magic compilers

With current AMG package definition and without magic wrappers, we are somehow linking to Fortran and getting the following error:
configure: error: linking to Fortran libraries from C fails

Possible solutions:

Disable fortran in amg2023 as in this commit
However, the likely fix needed is figuring out what library magic was linking to that we need to link to explicitly when not using magic compilers.

Subsumed by https://github.com/LLNL/benchpark/pull/270


Blank (gray) event frames in the output video

Hi,
I've been using the latest version of v2e and it seems that some frames are either blank (gray) or the event pixels are all less intense than the last frame. The object in the input video is moving consistently. The last good commit for me is 1edd9e3d2b30435edf4759ffc1c3703c572c73c0 where the event frames look consistent and I get no blank frames.
My run command is:
v2e -i frames --overwrite --input_frame_rate=10
--timestamp_resolution=0.1 --disable_slomo --auto_timestamp_resolution=False
--dvs_exposure duration 0.1 --output_folder=event_data --overwrite --pos_thres=.15 --neg_thres=.15
--sigma_thres=0.3 --dvs_text events.csv --output_width=1280 --output_height=720 --cutoff_hz=30 --avi_frame_rate=10
--refractory_period 0 --dvs_aedat2 None
What was changed after that commit that I could get blank frames?
Thanks

The only problem with commit 1edd9e3d2b30435edf4759ffc1c3703c572c73c0 is that I get 717 event frames output from an input of 720 frames. With the commits after that I do get 718 but then run into the issue outlined i.e some blank frames and some with less bright pixels even though the movement is consistent.
It looks like  the renderer outputs batches of 7 frames at a time and the first frame in each batch can either be blank or with 'muted' event pixel intensities. See attached side-by-side below of frame 00006.png and frame 00007.png.

Thanks for providing commit number. That commit only pushed changes to some synthetic input examples.
Did you check that you are using correct switch:
--dvs_exposure DVS_EXPOSURE [DVS_EXPOSURE ...]
                        Mode to finish DVS frame event integration:
                        	duration time: Use fixed accumulation time in seconds, e.g.
                        		--dvs_exposure duration .005;
                        	count n: Count n events per frame,e.g.
                        		--dvs_exposure count 5000;
                        	area_count M N: frame ends when any area of N x N pixels fills with M events, e.g.
                        		-dvs_exposure area_count 500 64
                        	source: each DVS frame is from one source frame (slomo or original, depending on if slomo is used)

In your case did you use --dvs_exposure source option?
Also, if you really disabled slomo upsampling, then
 --batch_size BATCH_SIZE
                        Batch size in frames for SuperSloMo. Batch size 8-16
                        is recommended if your GPU has sufficient memory.

should not have any effect.


Je/merge

@tgoyne Although the unittest seem to have passed here, I constantly get Realm accessed from incorrect thread in SharedRealm: get_shared_realm() with callback unit test. I belive it is because I don't know how the changes you made to RealmCoordinator::get_realm() in commit 1998e084ff8709f2aee0c08b7d80c635c2a34edc should be reflected in the Core-6 branch. Perhaps you can help here.

Just realized that the test fails in exactly the same way on the3e48b69764c0a2aaaa7a3b947d6d0dae215f9a09 commit, so no need to fix this here I guess.

The problem was fixed in the commits now merged.


Change order of label precedence in GitReleaseManager.yaml file

Right now, labels are ordered as follows:
- Bug
- Feature
- Improvement
- Documentation
- Breaking change

I think these should be ordered as follows:
- Breaking change
- Feature
- Bug
- Improvement
- Documentation

@cake-build/team thoughts?

agree :+1:


HUDI-1827 : Add ORC support in Bootstrap Op

What is the purpose of the pull request
HUDI-1827 : Add ORC support in Bootstrap Op
Brief change log

Modify SparkBootstrapCommitActionExecutor to support ORC
Modify HoodieSparkBootstrapSchemaProvider to support ORC
Provide new bootstrap data provider -SparkOrcBootstrapDataProvider
Supporting testcases

Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
TestOrcBootstrap - Tests orc bootstrap functionality
This change added tests and can be verified as follows:

By running HoodieSparkBootstrapExample
Manually verified the change by running a job on the docker
By running TestOrcBootstrap

Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[x] Commit message is descriptive of the change

[x] CI is green

[x] Necessary doc changes done or have another open PR

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vinothchandar Could you please review the PR

@manasaks : I assume this is the right patch and we can close out the older one (https://github.com/apache/hudi/pull/3275)? Also, can you rebase with latest master and update the patch. I will start reviewing in 2 to 3 days.

@manasaks : I spent sometime addressing the feedback I had. Can you check if the patch is good.

I will go ahead and land this in. If you have any follow up feedback, do put up a new patch. would be happy to review and get it in.
Thanks for the contribution :)


Bug: Filter wildcards ignore default methods

Describe the bug
Filters applied via app/Config/Filters.php $filters do a literal check versus the URL, which doesn't take into account default controller methods when resolving wildcards. This makes for confusing behavior - consider the following:
public $filters = ['login' => ['before' => ['account/*']]];

https://example.com/account/update - runs
https://example.com/account - does not run
https://example.com/account/index - runs

A workaround is to specify the wildcard like account* but that also possibly matches other Controllers (like accountants/index).
CodeIgniter 4 version
Latest develop
Affected module(s)
Filters, Routes
Expected behavior, and steps to reproduce if appropriate
I think a simple inclusion of {whatever}/ in * expansion should work.
Context

OS: Linux
Web server Apache
PHP version 7.3

This was the intended functionality. Much like routes, it works in a top-down method, so if you need to match accountants put that prior to account.


Re-enable continuous benchmarking

Describe the feature
Benchmarks have been added in #24846. It came with CodSpeed and a CI job that ran on every pull request to track performance.
However, it was disabled in https://github.com/nuxt/nuxt/commit/a39d311d3198415f32260010092833b934d3384b. The reason is that there were some performance regressions falsely reported in unrelated PRs due to the flakiness of some benchmarks.
The flaky benchmarks are those defined in https://github.com/nuxt/nuxt/blob/main/packages/kit/test/load-nuxt-config.bench.ts. The flakiness comes from the fact that they rely on file system access, which at the moment is not reliably supported in CodSpeed. You can see an example of the flakiness here: https://codspeed.io/nuxt/nuxt/benchmarks/packages/kit/test/load-nuxt-config.bench.ts::loadNuxtConfig::basic test fixture (types)
To re-enable the CI job, one of the following options could be done:

Remove those benchmarks entirely
Change those benchmarks, and the underlying tested functions, to not rely on File System access

I think the second option would be best, but it will require some changes to the https://github.com/nuxt/nuxt/blob/main/packages/kit/src/loader/config.ts file.
In the future, we plan on adding better support on CodSpeed for flaky benchmarks due to FS access, but that may take some time before it's available.
Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Hey @danielroe,
We just released a feature to ignore a benchmark on CodSpeed. An ignored benchmark is removed is still run, but its measure is removed from the performance report.
This feature should allow you to re-enable CodSpeed, ignore the flaky packages/kit/test/load-nuxt-config.bench.ts::loadNuxtConfig::basic test fixture (types) and start benefitting from CodSpeed again.
We will also be able to collect more data on the specific flaky benchmarks, which will help us find the source of it and fix 🤞
Let me know if you have any question 😉


chore: bigly tweak cypress config

Description
This PR makes Cypress more robust and improves CI dev experience.
Most salient:

Pulls environment variables for the CI build and Cypress from yarn env app. This means we'll no longer need to manually update these for CI, and our CI pipeline will always be in sync with production.
Changes the test environment so use the demo wallet, which lets us remove a lot of hacky logic and manually mocked data
Ups wait-on-timeout to 600 seconds, as this is causing a lot of our intermittent issues. TL;DR, our CI runner is significantly underpowered. A cold yarn dev takes me 21 seconds locally, but the CI runner takes 5 minutes and 20 seconds.

Additionally:

Optimises the test pipeline to move from 3 Cypress runners to 1 (3 was overkill, one of them literally did nothing except spin up and app and report that it had no tests to run)
Removes a redundant Cypress verification step
Adds config support for Cypress Studio
Removes a lot of commented-out tests we aren't going to add back in
Removes all manually mocked data
Updates auto-generated test data
Bumps Cypress one minor version

Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
If CI passed when this PR is opened we should be good.
Testing
CI should pass.
Engineering
As above.
Operations
N/A
Screenshots (if applicable)
N/A

@gomesalexandre if you get to this today we'll need to update the branch protection rules - we'll only require the first Cypress test to pass moving forward (the rest won't run).

I'll re-add a working version for swapper V2: https://github.com/shapeshift/web/pull/2773/commits/323e0b5c7e8f5960628e2f10299c8662c35b0719


Add Turkish translations

Hello there, i would love to help/maintain Turkish translations.
here are some open source contributions;
https://github.com/enesTufekci/flex-carousel
https://github.com/enesTufekci/color-bucket
react work;
https://github.com/systemaccounting/mxfactorial
Production
https://moebel.de/wohnen
http://arhiva.muzeultaranuluiroman.ro:3003/arhiva (Under construction)

Thanks for volunteering! I'll keep this open so others can join in as well.

Count me in too

Yay! @enesTufekci say the word and I can merge this in so you two can get started.

Hi. I can help Turkish translation for this project.
My wikipedia works are:
https://tr.wikipedia.org/wiki/Dart_(programlama_dili)
https://tr.wikipedia.org/wiki/SMPP
https://tr.wikipedia.org/wiki/Açık_ve_Gizli_Anahtarlı_Şifreleme
Also currently writing Turkish articles on devnot.com:
http://devnot.com/author/zafer-ayan/
ScreenToGif app translation:
https://www.screentogif.com/?l=tr_tr


RPP Audio Support HIP - Downmixing

Adds RPP audio support for Downmixing on HIP backend.
Adds relevant qa tests and performance tests.

@r-abishek - conflicts to be resolved

@kiritigowda resolved

@r-abishek please resolve merge conflicts.

@kiritigowda resolved, this could be merged too


Extend += to sliced container lvalues

Summary:
Compound '+=' statement causes a parser failure although the equivalent x = x + y works.
Description
None of the matrix slicing statements (container[int[]], container[int:int], etc.) are currently allowed on the left-hand side of assignments.
Reproducible Steps:
Try to parse
data {
  int N;
  int J[N];
}
parameters {
  vector[N] b;
}
model {
  vector[N] mu = rep_vector(0.0, N);
  mu[J] += b[J];
}

Current Version:
v2.17.1
[edit, Bob Carpenter:  I changed the title and added a description to clarify.]

Thanks for reporting.  I confirmed it's an issue and updated the issue title and generalized the issue.
To fix this, we'll need to implement a sliced matrix lvalue for +=, which shouldn't be a huge problem.  Maybe it's time to bite the bullet after the current refactor and build a proper lvalue expression template system.

uhm... I know I should file an issue for this, but there is another issue with sliced stuff: You cannot print them as there is no streaming operator overloaded. The model is parsed, but fails to compile...

This is related to the slices not having streaming output implementinations:  https://github.com/stan-dev/math/issues/792

thanks for creating the ticket.

#2513 - same issue, flagged as a bug

implemented correctly as of https://github.com/stan-dev/stan/pull/2678


Something went wrong Connection errored out. Loading checkpoint shards

After going to the url and selecting the model, after download, it breaks at checkpoint.
To create a public link, set `share=True` in `launch()`.
determined model type: falcon
Downloading (…)okenizer_config.json: 100%|█████| 220/220 [00:00<00:00, 25.0kB/s]
Downloading (…)/main/tokenizer.json: 100%|█| 2.73M/2.73M [00:00<00:00, 19.2MB/s]
Downloading (…)cial_tokens_map.json: 100%|██████| 281/281 [00:00<00:00, 230kB/s]
cpu mode
Downloading (…)lve/main/config.json: 100%|██████| 667/667 [00:00<00:00, 436kB/s]
Downloading (…)/configuration_RW.py: 100%|█| 2.61k/2.61k [00:00<00:00, 1.86MB/s]
A new version of the following files was downloaded from https://huggingface.co/tiiuae/falcon-7b-instruct:
- configuration_RW.py
. Make sure to double-check they do not contain any added malicious code. To avoid downloading new versions of the code file, you can pin a revision.
Downloading (…)main/modelling_RW.py: 100%|█| 47.5k/47.5k [00:00<00:00, 34.7MB/s]
A new version of the following files was downloaded from https://huggingface.co/tiiuae/falcon-7b-instruct:
- modelling_RW.py
. Make sure to double-check they do not contain any added malicious code. To avoid downloading new versions of the code file, you can pin a revision.
Downloading (…)model.bin.index.json: 100%|█| 16.9k/16.9k [00:00<00:00, 11.9MB/s]
Downloading (…)l-00001-of-00002.bin: 100%|█| 9.95G/9.95G [02:53<00:00, 57.3MB/s]
Downloading (…)l-00002-of-00002.bin: 100%|█| 4.48G/4.48G [01:18<00:00, 57.4MB/s]
Downloading shards: 100%|████████████████████████| 2/2 [04:12<00:00, 126.13s/it]
Loading checkpoint shards:  50%|█████████         | 1/2 [00:04<00:04,  4.98s/it]Killed

I see ubuntu logs and see this message when the checkpoint is Killed
Out of memory: Killed process 23122 (python) total-vm:16368736kB, anon-rss:12446840kB, file-rss:0kB, shmem-rss:4kB, UID:1000 pgtables:25712kB oom_score_adj:0

can you share your system info?

I am in cpu mode.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS

     *-cpu
          description: CPU
          product: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
          vendor: Intel Corp.

I changed the swappiness from 60 (default) to 80 and it seems to help me get past that error.
cat /proc/sys/vm/swappiness
Output
60

To change swappiness:
sudo sysctl vm.swappiness=80

More info here:  https://www.digitalocean.com/community/tutorials/how-to-add-swap-space-on-ubuntu-20-04
i am running it on the browser but it is super slow. maybe one word every couple of minutes. is this expected?

On CPU mode, yes
Maybe I will offer cpu optimized versions such as llama.cpp in the future
2023년 6월 11일 (일) 오후 3:58, javierxio @.***>님이 작성:

I am in cpu mode.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.6 LTS
 *-cpu
      description: CPU
      product: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
      vendor: Intel Corp.

I changed the swappiness from 60 (default) to 80 and it seems to help me
get past that error.
cat /proc/sys/vm/swappinessOutput60
To change swappiness:
sudo sysctl vm.swappiness=80
More info here:
https://www.digitalocean.com/community/tutorials/how-to-add-swap-space-on-ubuntu-20-04
i am running it on the browser but it is super slow. maybe one word every
couple of minutes. is this expected?
—
Reply to this email directly, view it on GitHub
https://github.com/deep-diver/LLM-As-Chatbot/issues/86#issuecomment-1586045146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGR4N6W2KJDA22BMA26SADXKVUCTANCNFSM6AAAAAAZCBPGQM
.
You are receiving this because you commented.Message ID:
@.***>


asciidoctor: fix dangling ascidoctor-safe symlink

as such a binary does not appear to be in the gem
Motivation for this change
i'm getting a warning about this seemingly every time i do anything with nix-env
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

 nix-review pr 87646
1 package marked as broken and skipped:
far2l

2 packages blacklisted:
tests.nixos-functions.nixos-test tests.nixos-functions.nixosTest-test

2 packages failed to build:
almanah rabbitvcs

118 packages built:
Sylk adapta-gtk-theme appimage-run asciidoctor atom atom-beta awesome bat-extras.batgrep btrbk calls cantata chrome-gnome-shell cinnamon.cinnamon-control-center clementine clementineUnfree deepin.dde-file-manager deepin.startdde deja-dup deltachat-electron dropbox-cli elementary-planner empathy esh evolution-data-server feedreader folks gfbgraph gnome-multi-writer gnome-online-accounts gnome-photos gnome-recipes gvfs gnome3.bijiben gnome3.cheese gnome3.evolution gnome3.file-roller gnome3.geary gnome3.gnome-applets gnome3.gnome-books gnome3.gnome-boxes gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-disk-utility gnome3.gnome-documents gnome3.gnome-flashback gnome3.gnome-initial-setup gnome3.gnome-maps gnome3.gnome-music gnome3.gnome-online-miners gnome3.gnome-panel gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-software gnome3.gnome-terminal gnome3.gnome-todo gnome3.gnome-tweaks gnome3.gnome-user-share grilo-plugins gnome3.gvfs libgdata libzapojit gnome3.nautilus gnome3.nautilus-python gnome3.pomodoro shotwell gnome3.totem tracker-miners gnomeExtensions.gsconnect hal-flash irccloud jitsi-meet-electron joplin-desktop ledger-live-desktop libblockdev libndctl marktext mate.mate-utils minetime newsboat notable pantheon.elementary-calendar pantheon.elementary-greeter pantheon.elementary-session-settings pantheon.extra-elementary-contracts pantheon.wingpanel-indicator-datetime pantheon.wingpanel-with-indicators pmdk psensor rapid-photo-downloader ripcord ripgrep ripgrep-all runwayml soulseekqt spaceFM ssb-patchwork standardnotes station styx tusk udiskie udisks unityhub usermount vifm-full weechat weechat-unwrapped wootility wsjtx xfce.gigolo xfce.gvfs xfce.thunar xfce.thunar-archive-plugin xfce.thunar-dropbox-plugin xfce.xfdesktop xmonad_log_applet zulip

almanah fails without this commit
rabbitvcs is marked as broken

[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)

used to be 337247856 is now 337247576

[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

ping @yacinehmito @nicknovitski since the bot hasn't done so

sorry about notifying the code owners, i should probably have converted to draft while switching my branch to staging

@GrahamcOfBorg eval


use server startup script in preparation for elifesciences/peerscout#75

Tried with Vagrant to avoid angering the RDS gods, but it fails in the same way (unrelated error, the peerscout user not being the owner of the public schema) /cc @lsh-0

cheers, @giorgiosironi . so, we either allow the app user the ability to modify (create/update/delete) the database, which gives it permissions on a level with the root user, or we use the root user to run any migrations. Or, we create a third user a 'super user' if you will, that has the same permissions as app user but also crud on the db.
we have a ticket somewhere about this, I'll link them up when I find it`


Add global 'show' function

Currently the playground and tests define their own show functions, and the CLI needs one. Instead of having every runtime implement their own show function, have a global show function in the prelude that delegates to an implementation defined in the global environment:
// Something like this; the default implementation would be an error
pub struct ShowFn(Rc<dyn Fn(&Value, &EnvironmentRef, &Stack) -> Result<()>>);

fundamental_env_key!(pub show for ShowFn { ... });

// in prelude
Environment::global().borrow_mut().set_variable("show", Value::of(Function::new(|value, env, stack| {
    Environment::global().borrow_mut().show().0(value, env, stack)?;

    Ok(Value::empty())
})));

Fixed by 9c54324


Updated logger to include rename of ContainerLogger::SubprocessInfo.

This PR is dependent on https://reviews.apache.org/r/57121/
Once this review lands, we should merge this.

Thanks for being on top of these changes @klueska!! I noticed that the Mesos-DC/OS CI broke today after the ContainerLogger changes landed in Mesos, so I opened a PR against DC/OS for testing purposes: https://github.com/dcos/dcos/pull/1309

Testing this PR in DC/OS with latest Mesos master here: https://github.com/dcos/dcos/pull/1343


adding more chocolate

added milk and dark chocolate chips to brownies recipe

this change is very much needed - looks good to me!


Update pytest-migration project duration

cc: @tinosulzer
also cc: @Saransh-cpp @arjxn-py
Please let me know if we should update the mentioned stretch goal too here or let the candidate(s) do so in their proposal?

Please let me know if we should update the mentioned stretch goal too here or let the candidate(s) do so in their proposal?

I am good with candidate(s) do so in their proposals considering the time left in the deadline tho totally open to add it if someone wants to.

@Saransh-cpp said outside of GitHub that we should be good to go (he isn't available to approve the PR right now). Merging this


Class modal-dialog-centered does not work on IE 11

This might an issue with Flexbox and IE 11.  In any case, opening up the modal does not vertically center it.
Easy to Reproduce:  In IE11, go to https://getbootstrap.com/docs/4.0/components/modal/  and click on the "Launch demo modal" button in the section "Vertically centered".
IF there is a workaround class or code, please advise.  Thanks.

Thank @larrybahr. It works for me.

Having the same issue with the modal-dialog-centred, as a work-around I am setting the "top" css rule on the modal.
At first I thought it was just what I was doing, so I loaded the example in the documentation on IE11 and it too had the same problem.


Correct QnA enablement key

Creating this PR to correct the extension manifest key name from enableqna to enablemarketplaceqna.

@shaaradmsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@chcomley how do we go about merging this PR? I don't have the merge rights here, is there a validation that's pending? Can you please guide?

#sign-off

Hi @shaaradmsft, needed a "#sign-off" and I've done that. It's now be reviewed and merged by the review team. Thank you for your updates!

#sign-off

@ktoliver This update isn't live. I assume it's due to the recent outage, but can this be confirmed please? Will this automatically be published once it's all back up and running? Thanks!

@chcomley The answers are yes and yes. I don’t have an ETA for the next publish cycle.


license.md is missing

...

It is not missing it is placed in the docs folder, however it can be placed at root


Set image pull policy to IfNotPresent by default

Is this a request for help?:

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Version of Helm and Kubernetes:
Which chart:
istio
What happened:
Set all of the image pull policy here https://github.com/kubernetes/charts/blob/master/incubator/istio/values.yaml to IfNotPresent
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:

/cc @lachie83

Would you like to raise a PR for this?

/assign @lachie83
Can you help review?

/assign @gyliu513

/unassign @lachie83


Clarify Create Unit Tests requirements

@HaythamAmairah : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off Thanks!


Add additional Z-Wave Bulbs to ZW098 Workaround

Description:
Add a few more multi-led bulbs to the workaround. The long-term fix here is to probably refactor rgbw and rgb+w+w lights into separate things.
Related issue (if applicable): fixes #18767
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

Color temperature slider shows up for my new Aeotec ZWA003 Bulb, clicking on the "left" half gets me the cool white LED, and the "right" half gets me the warm white LED.

It looks like travis is failing on a completely unrelated test (TestStatisticsSensor.test_initialize_from_database_with_maxage) - what is policy on fixing?


"§"/"&" consistency. old "&" utils code preserved bc haha yes

§ ON TOP, BABY!

also increased consistency with all the "---------------------" lines with the §m formatting code. now all of them look like actual lines :ooooo

Sure but why tho


Update README.md for Co Op translator 0.2.0

I have reviewed the changes and everything looks good.


Harden ref-counting concurrency semantics

Motivation
#8563 highlighted race conditions introduced by the prior optimistic update optimization in 83a19d565064ee36998eb94f946e5a4264001065. These were known at the time but considered acceptable given the perf benefit in high contention scenarios.
This PR proposes a modified approach which provides roughly half the gains but stronger concurrency semantics. Race conditions still exist but their scope is narrowed to much less likely cases (releases
coinciding with retain overflow), and even in those cases certain guarantees are still assured. Once release() returns true, all subsequent release/retains are guaranteed to throw, and in particular deallocate() will be called at most once.
Modifications

Use even numbers internally (including -ve) for live refcounts
"Final" release changes to odd number (equivalent to refcount 0)
Retain still uses faster getAndAdd, release uses CAS loop
First CAS attempt uses non-volatile read
Thread.yield() after a failed CAS appears to provide a net gain
New tests in AbstractReferenceCountedTest written by @normanmaurer

Result
More (though not completely) robust concurrency semantics for ref counting; increased latency under high contention, but still roughly twice as fast as the original logic. Bench results to follow

@netty-bot test this please

Benchmark results:
Pre- 83a19d565064ee36998eb94f946e5a4264001065:
Benchmark                           (delay)    Mode       Cnt         Score    Error  Units
retainReleaseContended                    1  sample  36460170      1152.856 ± 14.343  ns/op
retainReleaseContended·p0.00              1  sample                  37.000           ns/op
retainReleaseContended·p0.50              1  sample                 807.000           ns/op
retainReleaseContended·p0.90              1  sample                1858.000           ns/op
retainReleaseContended·p0.95              1  sample                2320.000           ns/op
retainReleaseContended·p0.99              1  sample                3524.000           ns/op
retainReleaseContended·p0.999             1  sample               16704.000           ns/op
retainReleaseContended·p0.9999            1  sample              250880.000           ns/op
retainReleaseContended·p1.00              1  sample            32309248.000           ns/op
retainReleaseContended                   10  sample  38184690      1119.333 ± 15.226  ns/op
retainReleaseContended·p0.00             10  sample                  45.000           ns/op
retainReleaseContended·p0.50             10  sample                 770.000           ns/op
retainReleaseContended·p0.90             10  sample                1748.000           ns/op
retainReleaseContended·p0.95             10  sample                2184.000           ns/op
retainReleaseContended·p0.99             10  sample                3312.000           ns/op
retainReleaseContended·p0.999            10  sample               16224.000           ns/op
retainReleaseContended·p0.9999           10  sample              258695.910           ns/op
retainReleaseContended·p1.00             10  sample            28803072.000           ns/op
retainReleaseContended                  100  sample  40444975      1040.120 ± 11.997  ns/op
retainReleaseContended·p0.00            100  sample                 229.000           ns/op
retainReleaseContended·p0.50            100  sample                 791.000           ns/op
retainReleaseContended·p0.90            100  sample                1482.000           ns/op
retainReleaseContended·p0.95            100  sample                1780.000           ns/op
retainReleaseContended·p0.99            100  sample                2540.000           ns/op
retainReleaseContended·p0.999           100  sample               14528.000           ns/op
retainReleaseContended·p0.9999          100  sample              184576.000           ns/op
retainReleaseContended·p1.00            100  sample            27295744.000           ns/op
retainReleaseContended                 1000  sample  29429689      2842.698 ± 26.030  ns/op
retainReleaseContended·p0.00           1000  sample                2164.000           ns/op
retainReleaseContended·p0.50           1000  sample                2444.000           ns/op
retainReleaseContended·p0.90           1000  sample                2520.000           ns/op
retainReleaseContended·p0.95           1000  sample                2588.000           ns/op
retainReleaseContended·p0.99           1000  sample                2820.000           ns/op
retainReleaseContended·p0.999          1000  sample               38912.000           ns/op
retainReleaseContended·p0.9999         1000  sample              535552.000           ns/op
retainReleaseContended·p1.00           1000  sample            29949952.000           ns/op
retainReleaseContended                10000  sample  24367466     25048.634 ± 56.891  ns/op
retainReleaseContended·p0.00          10000  sample               20736.000           ns/op
retainReleaseContended·p0.50          10000  sample               23616.000           ns/op
retainReleaseContended·p0.90          10000  sample               23744.000           ns/op
retainReleaseContended·p0.95          10000  sample               24352.000           ns/op
retainReleaseContended·p0.99          10000  sample               38144.000           ns/op
retainReleaseContended·p0.999         10000  sample              273680.896           ns/op
retainReleaseContended·p0.9999        10000  sample             2613248.000           ns/op
retainReleaseContended·p1.00          10000  sample            59965440.000           ns/op
retainReleaseUncontended                1  sample   7509511        55.367 ±  2.721  ns/op
retainReleaseUncontended·p0.00          1  sample                  35.000           ns/op
retainReleaseUncontended·p0.50          1  sample                  41.000           ns/op
retainReleaseUncontended·p0.90          1  sample                  52.000           ns/op
retainReleaseUncontended·p0.95          1  sample                  62.000           ns/op
retainReleaseUncontended·p0.99          1  sample                  98.000           ns/op
retainReleaseUncontended·p0.999         1  sample                 359.488           ns/op
retainReleaseUncontended·p0.9999        1  sample               18305.562           ns/op
retainReleaseUncontended·p1.00          1  sample             5824512.000           ns/op
retainReleaseUncontended               10  sample   6129780        73.046 ±  5.091  ns/op
retainReleaseUncontended·p0.00         10  sample                  43.000           ns/op
retainReleaseUncontended·p0.50         10  sample                  53.000           ns/op
retainReleaseUncontended·p0.90         10  sample                  68.000           ns/op
retainReleaseUncontended·p0.95         10  sample                  73.000           ns/op
retainReleaseUncontended·p0.99         10  sample                 106.000           ns/op
retainReleaseUncontended·p0.999        10  sample                2280.876           ns/op
retainReleaseUncontended·p0.9999       10  sample               18816.000           ns/op
retainReleaseUncontended·p1.00         10  sample             8978432.000           ns/op
retainReleaseUncontended              100  sample   6601891       279.857 ±  1.515  ns/op
retainReleaseUncontended·p0.00        100  sample                 219.000           ns/op
retainReleaseUncontended·p0.50        100  sample                 247.000           ns/op
retainReleaseUncontended·p0.90        100  sample                 273.000           ns/op
retainReleaseUncontended·p0.95        100  sample                 291.000           ns/op
retainReleaseUncontended·p0.99        100  sample                 337.000           ns/op
retainReleaseUncontended·p0.999       100  sample               13824.000           ns/op
retainReleaseUncontended·p0.9999      100  sample               21440.000           ns/op
retainReleaseUncontended·p1.00        100  sample             2428928.000           ns/op
retainReleaseUncontended             1000  sample   5385984      2354.879 ±  6.543  ns/op
retainReleaseUncontended·p0.00       1000  sample                1970.000           ns/op
retainReleaseUncontended·p0.50       1000  sample                2156.000           ns/op
retainReleaseUncontended·p0.90       1000  sample                2312.000           ns/op
retainReleaseUncontended·p0.95       1000  sample                2448.000           ns/op
retainReleaseUncontended·p0.99       1000  sample               15088.000           ns/op
retainReleaseUncontended·p0.999      1000  sample               20896.000           ns/op
retainReleaseUncontended·p0.9999     1000  sample               32793.696           ns/op
retainReleaseUncontended·p1.00       1000  sample             4546560.000           ns/op
retainReleaseUncontended            10000  sample   4314810     23143.254 ± 28.804  ns/op
retainReleaseUncontended·p0.00      10000  sample               19488.000           ns/op
retainReleaseUncontended·p0.50      10000  sample               21344.000           ns/op
retainReleaseUncontended·p0.90      10000  sample               26144.000           ns/op
retainReleaseUncontended·p0.95      10000  sample               35712.000           ns/op
retainReleaseUncontended·p0.99      10000  sample               50688.000           ns/op
retainReleaseUncontended·p0.999     10000  sample               65792.000           ns/op
retainReleaseUncontended·p0.9999    10000  sample              143492.838           ns/op
retainReleaseUncontended·p1.00      10000  sample            12255232.000           ns/op

Current (before):
Benchmark                           (delay)    Mode       Cnt         Score    Error  Units
retainReleaseContended                    1  sample  33617682       396.846 ± 12.371  ns/op
retainReleaseContended·p0.00              1  sample                  36.000           ns/op
retainReleaseContended·p0.50              1  sample                 267.000           ns/op
retainReleaseContended·p0.90              1  sample                 484.000           ns/op
retainReleaseContended·p0.95              1  sample                 558.000           ns/op
retainReleaseContended·p0.99              1  sample                 725.000           ns/op
retainReleaseContended·p0.999             1  sample                5232.000           ns/op
retainReleaseContended·p0.9999            1  sample              124544.000           ns/op
retainReleaseContended·p1.00              1  sample            40239104.000           ns/op
retainReleaseContended                   10  sample  30765523       422.296 ± 12.817  ns/op
retainReleaseContended·p0.00             10  sample                  45.000           ns/op
retainReleaseContended·p0.50             10  sample                 289.000           ns/op
retainReleaseContended·p0.90             10  sample                 479.000           ns/op
retainReleaseContended·p0.95             10  sample                 551.000           ns/op
retainReleaseContended·p0.99             10  sample                 728.000           ns/op
retainReleaseContended·p0.999            10  sample                5888.000           ns/op
retainReleaseContended·p0.9999           10  sample              140032.000           ns/op
retainReleaseContended·p1.00             10  sample            23265280.000           ns/op
retainReleaseContended                  100  sample  26334520       475.976 ± 13.347  ns/op
retainReleaseContended·p0.00            100  sample                 235.000           ns/op
retainReleaseContended·p0.50            100  sample                 353.000           ns/op
retainReleaseContended·p0.90            100  sample                 433.000           ns/op
retainReleaseContended·p0.95            100  sample                 462.000           ns/op
retainReleaseContended·p0.99            100  sample                 535.000           ns/op
retainReleaseContended·p0.999           100  sample               11152.000           ns/op
retainReleaseContended·p0.9999          100  sample              156300.262           ns/op
retainReleaseContended·p1.00            100  sample            26771456.000           ns/op
retainReleaseContended                 1000  sample  29409220      2954.896 ± 35.426  ns/op
retainReleaseContended·p0.00           1000  sample                2096.000           ns/op
retainReleaseContended·p0.50           1000  sample                2424.000           ns/op
retainReleaseContended·p0.90           1000  sample                2468.000           ns/op
retainReleaseContended·p0.95           1000  sample                2496.000           ns/op
retainReleaseContended·p0.99           1000  sample                2668.000           ns/op
retainReleaseContended·p0.999          1000  sample               56192.000           ns/op
retainReleaseContended·p0.9999         1000  sample              668672.000           ns/op
retainReleaseContended·p1.00           1000  sample            49283072.000           ns/op
retainReleaseContended                10000  sample  24335420     25097.878 ± 65.738  ns/op
retainReleaseContended·p0.00          10000  sample               21344.000           ns/op
retainReleaseContended·p0.50          10000  sample               23616.000           ns/op
retainReleaseContended·p0.90          10000  sample               23712.000           ns/op
retainReleaseContended·p0.95          10000  sample               24352.000           ns/op
retainReleaseContended·p0.99          10000  sample               38976.000           ns/op
retainReleaseContended·p0.999         10000  sample              253952.000           ns/op
retainReleaseContended·p0.9999        10000  sample             2793472.000           ns/op
retainReleaseContended·p1.00          10000  sample            58261504.000           ns/op
retainReleaseUncontended                1  sample   4484558        58.703 ±  1.546  ns/op
retainReleaseUncontended·p0.00          1  sample                  33.000           ns/op
retainReleaseUncontended·p0.50          1  sample                  39.000           ns/op
retainReleaseUncontended·p0.90          1  sample                  50.000           ns/op
retainReleaseUncontended·p0.95          1  sample                  65.000           ns/op
retainReleaseUncontended·p0.99          1  sample                  98.000           ns/op
retainReleaseUncontended·p0.999         1  sample                4296.000           ns/op
retainReleaseUncontended·p0.9999        1  sample               19889.411           ns/op
retainReleaseUncontended·p1.00          1  sample             1775616.000           ns/op
retainReleaseUncontended               10  sample   6199062        73.845 ±  1.339  ns/op
retainReleaseUncontended·p0.00         10  sample                  43.000           ns/op
retainReleaseUncontended·p0.50         10  sample                  53.000           ns/op
retainReleaseUncontended·p0.90         10  sample                  71.000           ns/op
retainReleaseUncontended·p0.95         10  sample                  87.000           ns/op
retainReleaseUncontended·p0.99         10  sample                 122.000           ns/op
retainReleaseUncontended·p0.999        10  sample                2643.748           ns/op
retainReleaseUncontended·p0.9999       10  sample               18752.000           ns/op
retainReleaseUncontended·p1.00         10  sample             1251328.000           ns/op
retainReleaseUncontended              100  sample   6570441       283.853 ±  5.069  ns/op
retainReleaseUncontended·p0.00        100  sample                 219.000           ns/op
retainReleaseUncontended·p0.50        100  sample                 244.000           ns/op
retainReleaseUncontended·p0.90        100  sample                 268.000           ns/op
retainReleaseUncontended·p0.95        100  sample                 280.000           ns/op
retainReleaseUncontended·p0.99        100  sample                 325.000           ns/op
retainReleaseUncontended·p0.999       100  sample               13952.000           ns/op
retainReleaseUncontended·p0.9999      100  sample               21856.000           ns/op
retainReleaseUncontended·p1.00        100  sample             9158656.000           ns/op
retainReleaseUncontended             1000  sample   5345561      2368.951 ±  4.646  ns/op
retainReleaseUncontended·p0.00       1000  sample                1970.000           ns/op
retainReleaseUncontended·p0.50       1000  sample                2112.000           ns/op
retainReleaseUncontended·p0.90       1000  sample                2268.000           ns/op
retainReleaseUncontended·p0.95       1000  sample                2376.000           ns/op
retainReleaseUncontended·p0.99       1000  sample               15424.000           ns/op
retainReleaseUncontended·p0.999      1000  sample               21184.000           ns/op
retainReleaseUncontended·p0.9999     1000  sample               30862.202           ns/op
retainReleaseUncontended·p1.00       1000  sample             2605056.000           ns/op
retainReleaseUncontended            10000  sample   4293861     23226.581 ± 20.925  ns/op
retainReleaseUncontended·p0.00      10000  sample               19488.000           ns/op
retainReleaseUncontended·p0.50      10000  sample               21344.000           ns/op
retainReleaseUncontended·p0.90      10000  sample               27968.000           ns/op
retainReleaseUncontended·p0.95      10000  sample               35840.000           ns/op
retainReleaseUncontended·p0.99      10000  sample               51776.000           ns/op
retainReleaseUncontended·p0.999     10000  sample               65408.000           ns/op
retainReleaseUncontended·p0.9999    10000  sample               98048.000           ns/op
retainReleaseUncontended·p1.00      10000  sample            12369920.000           ns/op

This PR (after):
Benchmark                           (delay)    Mode       Cnt         Score    Error  Units
retainReleaseContended                    1  sample  30710079       566.717 ± 13.469  ns/op
retainReleaseContended·p0.00              1  sample                  40.000           ns/op
retainReleaseContended·p0.50              1  sample                  82.000           ns/op
retainReleaseContended·p0.90              1  sample                 337.000           ns/op
retainReleaseContended·p0.95              1  sample                1972.000           ns/op
retainReleaseContended·p0.99              1  sample                8528.000           ns/op
retainReleaseContended·p0.999             1  sample               27488.000           ns/op
retainReleaseContended·p0.9999            1  sample              211200.000           ns/op
retainReleaseContended·p1.00              1  sample            40632320.000           ns/op
retainReleaseContended                   10  sample  33563252       584.657 ± 14.439  ns/op
retainReleaseContended·p0.00             10  sample                  48.000           ns/op
retainReleaseContended·p0.50             10  sample                  69.000           ns/op
retainReleaseContended·p0.90             10  sample                 223.000           ns/op
retainReleaseContended·p0.95             10  sample                1386.000           ns/op
retainReleaseContended·p0.99             10  sample               10288.000           ns/op
retainReleaseContended·p0.999            10  sample               39872.000           ns/op
retainReleaseContended·p0.9999           10  sample              217088.000           ns/op
retainReleaseContended·p1.00             10  sample            42663936.000           ns/op
retainReleaseContended                  100  sample  26297644       948.177 ± 18.478  ns/op
retainReleaseContended·p0.00            100  sample                 222.000           ns/op
retainReleaseContended·p0.50            100  sample                 386.000           ns/op
retainReleaseContended·p0.90            100  sample                1666.000           ns/op
retainReleaseContended·p0.95            100  sample                2928.000           ns/op
retainReleaseContended·p0.99            100  sample                6704.000           ns/op
retainReleaseContended·p0.999           100  sample               29472.000           ns/op
retainReleaseContended·p0.9999          100  sample              319488.000           ns/op
retainReleaseContended·p1.00            100  sample            55312384.000           ns/op
retainReleaseContended                 1000  sample  29410837      2857.274 ± 24.380  ns/op
retainReleaseContended·p0.00           1000  sample                1984.000           ns/op
retainReleaseContended·p0.50           1000  sample                2440.000           ns/op
retainReleaseContended·p0.90           1000  sample                2500.000           ns/op
retainReleaseContended·p0.95           1000  sample                2552.000           ns/op
retainReleaseContended·p0.99           1000  sample                4064.000           ns/op
retainReleaseContended·p0.999          1000  sample               57600.000           ns/op
retainReleaseContended·p0.9999         1000  sample              547754.189           ns/op
retainReleaseContended·p1.00           1000  sample            48758784.000           ns/op
retainReleaseContended                10000  sample  24728900     24539.149 ± 42.932  ns/op
retainReleaseContended·p0.00          10000  sample               20960.000           ns/op
retainReleaseContended·p0.50          10000  sample               23616.000           ns/op
retainReleaseContended·p0.90          10000  sample               23712.000           ns/op
retainReleaseContended·p0.95          10000  sample               24256.000           ns/op
retainReleaseContended·p0.99          10000  sample               37504.000           ns/op
retainReleaseContended·p0.999         10000  sample              212224.000           ns/op
retainReleaseContended·p0.9999        10000  sample             1312993.075           ns/op
retainReleaseContended·p1.00          10000  sample            45088768.000           ns/op
retainReleaseUncontended                1  sample   6955400        57.365 ±  0.557  ns/op
retainReleaseUncontended·p0.00          1  sample                  37.000           ns/op
retainReleaseUncontended·p0.50          1  sample                  43.000           ns/op
retainReleaseUncontended·p0.90          1  sample                  51.000           ns/op
retainReleaseUncontended·p0.95          1  sample                  58.000           ns/op
retainReleaseUncontended·p0.99          1  sample                  96.000           ns/op
retainReleaseUncontended·p0.999         1  sample                1542.000           ns/op
retainReleaseUncontended·p0.9999        1  sample               18496.000           ns/op
retainReleaseUncontended·p1.00          1  sample              245504.000           ns/op
retainReleaseUncontended               10  sample   6118153        69.344 ±  0.698  ns/op
retainReleaseUncontended·p0.00         10  sample                  43.000           ns/op
retainReleaseUncontended·p0.50         10  sample                  52.000           ns/op
retainReleaseUncontended·p0.90         10  sample                  64.000           ns/op
retainReleaseUncontended·p0.95         10  sample                  68.000           ns/op
retainReleaseUncontended·p0.99         10  sample                 104.000           ns/op
retainReleaseUncontended·p0.999        10  sample                2708.000           ns/op
retainReleaseUncontended·p0.9999       10  sample               18752.000           ns/op
retainReleaseUncontended·p1.00         10  sample              315392.000           ns/op
retainReleaseUncontended              100  sample   6545758       282.383 ±  1.654  ns/op
retainReleaseUncontended·p0.00        100  sample                 220.000           ns/op
retainReleaseUncontended·p0.50        100  sample                 243.000           ns/op
retainReleaseUncontended·p0.90        100  sample                 265.000           ns/op
retainReleaseUncontended·p0.95        100  sample                 275.000           ns/op
retainReleaseUncontended·p0.99        100  sample                 328.000           ns/op
retainReleaseUncontended·p0.999       100  sample               14112.000           ns/op
retainReleaseUncontended·p0.9999      100  sample               21997.571           ns/op
retainReleaseUncontended·p1.00        100  sample             2334720.000           ns/op
retainReleaseUncontended             1000  sample   5326852      2378.207 ±  6.946  ns/op
retainReleaseUncontended·p0.00       1000  sample                1972.000           ns/op
retainReleaseUncontended·p0.50       1000  sample                2104.000           ns/op
retainReleaseUncontended·p0.90       1000  sample                2244.000           ns/op
retainReleaseUncontended·p0.95       1000  sample                2312.000           ns/op
retainReleaseUncontended·p0.99       1000  sample               15488.000           ns/op
retainReleaseUncontended·p0.999      1000  sample               21088.000           ns/op
retainReleaseUncontended·p0.9999     1000  sample               30634.070           ns/op
retainReleaseUncontended·p1.00       1000  sample             5775360.000           ns/op
retainReleaseUncontended            10000  sample   4277948     23315.241 ± 15.261  ns/op
retainReleaseUncontended·p0.00      10000  sample               19488.000           ns/op
retainReleaseUncontended·p0.50      10000  sample               20736.000           ns/op
retainReleaseUncontended·p0.90      10000  sample               34688.000           ns/op
retainReleaseUncontended·p0.95      10000  sample               36992.000           ns/op
retainReleaseUncontended·p0.99      10000  sample               52544.000           ns/op
retainReleaseUncontended·p0.999     10000  sample               66432.000           ns/op
retainReleaseUncontended·p0.9999    10000  sample               95642.253           ns/op
retainReleaseUncontended·p1.00      10000  sample             7290880.000           ns/op

/cc @merlimat

@njhill please also do the same for AbstractReferenceCounted and also bring in my unit test:
https://github.com/netty/netty/pull/8574/files#diff-00bb99ce8fc83355821ed10e89e4f155R90

@normanmaurer sure, sorry I missed your new test somehow. I was thinking to hold off on the AbstractReferenceCounted update until this had been reviewed, but I will do it now given that test uses it.
Another thing which would probably be good to change - currently the count can actually go one further before "overflowing" (Integer.MAX_COUNT + 1). I tweaked the tests to reflect this but realized that when the count is in this state refCnt() will return a confusing (negative) value, so maybe it's best to just match the prior limit.
Finally I did also benchmark your PR #8574 on the same system; let me know if you would like me to add those results, I omitted them above for brevity.

@normanmaurer now updated with all the above

@normanmaurer kind of a tangent but I also see it's possible to de-duplicate the common refcount logic, see 7bd3278275dfe092b108e288cba415bc3bf7be05. If you think this is of interest I can open a follow-on PR.

@netty-bot test this please

@njhill de-duplicate as followup sounds good.

@njhill also please fix the check style error: https://ci.netty.io/job/netty-centos6-java12-prb/189/console

@netty-bot test this please

@njhill @normanmaurer Thanks for looking into this! And nice idea on skipping the CAS on one leg!

@netty-bot test this please

@franz1981 PTAL as well

@merlimat so does this fix your problem (I think it does but want to confirm) ?

@normanmaurer It does indeed. Thanks!

I would group all the uncommon paths into separate methods while leaving the common paths simple and clean: tomorrow I will take another look to the logic, nice work!

Re "Thread.yield() after a failed CAS appears to provide a net gain": it is just an apparent gain (as seen in other context). It will trade latencies to get more throughput and I suppose the percentiles would show that.
I think that using a mixed idle strategy would be better depending how much is expected to get a failed cas...

@franz1981 I thought an important aspect is that the yield doesn't affect the uncontented case. But you are right for contended it is improving tput at the expense of some more latency variance. By mixed idle do you mean e.g. alternating between yield and no yield?

@carl-mastrangelo anything else or can we ship it ?

@netty-bot test this please

@njhill yep using a max spin count of 0 when available processors <=2 or something similar (for old JVMs + docker it wouldn't be that good I admit).
Consider that using Thread.yield while being scheduled on a different Numa mode could be quite expensive AFAIK, but it is just fine tuning at the end.

Hmm, are we sure we want this amount of complexity for benefits on contended scenario? I never imagined reference counting would be that contentious so far. Wouldn't this make JVM have harder time optimizing retain/release() calls, like inlining? If contention is a real problem then perhaps a user can create a retained slide/duplicate which will practically make contention none?

@trustin i think it’s actually fine as it is still cheaper then a CAS.

I think what we could do is factor out the less common code path into an extra method to ensure inlining can happen

If contention is a real problem then perhaps a user can create a retained slide/duplicate which will practically make contention none.

@normanmaurer told me that a retained slice/duplicate of an unpooled buffer does not have its own reference count, but then why don't we just implement retainedSlice() and retainedDuplicate() properly like we did for pooled buffers?

I think what we could do is factor out the less common code path into an extra method to ensure inlining can happen.

That'd be nice if addressed in this PR.

I'm not super against the proposed change but I'm worried about:

losing half of the gain for less common cases even if we are still faster than before
the amount of code complexity it brings to us, i.e. more hand-written comments to maintain, more time to explain when someone tries to understand

@trustin I think we have two options here...

use a CAS and loose all the improvements
go with this change while make it more correct but also more complex.

I would vote for 2) that said I can also life with 1). I mainly think 2) is fine as this code usually does not need to get touched very often so the complexity does not worry me as much .

For sure it's better than reverting the optimization completely. :-) If we want correctness in the mentioned case, then (2) is the way to go. It'd still be nice if we could extract the slow path to a separate method.

@trustin sounds good to me! @njhill can you do this ?

@normanmaurer @trustin @franz1981 I've had a go at decomposing the release logic to facilitate inlining of fast paths, PTAL

@netty-bot test this please

These "after" numbers look slightly too good to me relative to those ran before. I ran on the same system as the prior ones but maybe there was less other stuff going on, I will repeat the before ones too when I get a chance.
Benchmark                           (delay)    Mode       Cnt         Score    Error  Units
retainReleaseContended                    1  sample  32728741       480.785 ±  6.210  ns/op
retainReleaseContended·p0.00              1  sample                  40.000           ns/op
retainReleaseContended·p0.50              1  sample                  81.000           ns/op
retainReleaseContended·p0.90              1  sample                 355.000           ns/op
retainReleaseContended·p0.95              1  sample                2072.000           ns/op
retainReleaseContended·p0.99              1  sample                8448.000           ns/op
retainReleaseContended·p0.999             1  sample               23136.000           ns/op
retainReleaseContended·p0.9999            1  sample               41088.000           ns/op
retainReleaseContended·p1.00              1  sample            10682368.000           ns/op
retainReleaseContended                   10  sample  35218697       529.245 ±  7.930  ns/op
retainReleaseContended·p0.00             10  sample                  49.000           ns/op
retainReleaseContended·p0.50             10  sample                  91.000           ns/op
retainReleaseContended·p0.90             10  sample                 354.000           ns/op
retainReleaseContended·p0.95             10  sample                2148.000           ns/op
retainReleaseContended·p0.99             10  sample                9520.000           ns/op
retainReleaseContended·p0.999            10  sample               26624.000           ns/op
retainReleaseContended·p0.9999           10  sample               51136.000           ns/op
retainReleaseContended·p1.00             10  sample            36700160.000           ns/op
retainReleaseContended                  100  sample  28391507       811.639 ± 10.042  ns/op
retainReleaseContended·p0.00            100  sample                 222.000           ns/op
retainReleaseContended·p0.50            100  sample                 391.000           ns/op
retainReleaseContended·p0.90            100  sample                1698.000           ns/op
retainReleaseContended·p0.95            100  sample                2980.000           ns/op
retainReleaseContended·p0.99            100  sample                6616.000           ns/op
retainReleaseContended·p0.999           100  sample               16368.000           ns/op
retainReleaseContended·p0.9999          100  sample               70528.000           ns/op
retainReleaseContended·p1.00            100  sample            34078720.000           ns/op
retainReleaseContended                 1000  sample  30531259      2523.372 ±  9.072  ns/op
retainReleaseContended·p0.00           1000  sample                1984.000           ns/op
retainReleaseContended·p0.50           1000  sample                2436.000           ns/op
retainReleaseContended·p0.90           1000  sample                2504.000           ns/op
retainReleaseContended·p0.95           1000  sample                2560.000           ns/op
retainReleaseContended·p0.99           1000  sample                3856.000           ns/op
retainReleaseContended·p0.999          1000  sample                9632.000           ns/op
retainReleaseContended·p0.9999         1000  sample               88320.000           ns/op
retainReleaseContended·p1.00           1000  sample            44040192.000           ns/op
retainReleaseContended                10000  sample  25534533     23492.988 ± 10.779  ns/op
retainReleaseContended·p0.00          10000  sample               21344.000           ns/op
retainReleaseContended·p0.50          10000  sample               23616.000           ns/op
retainReleaseContended·p0.90          10000  sample               23712.000           ns/op
retainReleaseContended·p0.95          10000  sample               23776.000           ns/op
retainReleaseContended·p0.99          10000  sample               27136.000           ns/op
retainReleaseContended·p0.999         10000  sample               55744.000           ns/op
retainReleaseContended·p0.9999        10000  sample              291328.000           ns/op
retainReleaseContended·p1.00          10000  sample            15155200.000           ns/op
retainReleaseUncontended                1  sample   4242912        53.613 ±  0.705  ns/op
retainReleaseUncontended·p0.00          1  sample                  36.000           ns/op
retainReleaseUncontended·p0.50          1  sample                  40.000           ns/op
retainReleaseUncontended·p0.90          1  sample                  43.000           ns/op
retainReleaseUncontended·p0.95          1  sample                  46.000           ns/op
retainReleaseUncontended·p0.99          1  sample                  53.000           ns/op
retainReleaseUncontended·p0.999         1  sample                1952.000           ns/op
retainReleaseUncontended·p0.9999        1  sample               18560.000           ns/op
retainReleaseUncontended·p1.00          1  sample               27360.000           ns/op
retainReleaseUncontended               10  sample   6325881        62.036 ±  0.524  ns/op
retainReleaseUncontended·p0.00         10  sample                  43.000           ns/op
retainReleaseUncontended·p0.50         10  sample                  51.000           ns/op
retainReleaseUncontended·p0.90         10  sample                  57.000           ns/op
retainReleaseUncontended·p0.95         10  sample                  60.000           ns/op
retainReleaseUncontended·p0.99         10  sample                  68.000           ns/op
retainReleaseUncontended·p0.999        10  sample                 257.000           ns/op
retainReleaseUncontended·p0.9999       10  sample               18432.000           ns/op
retainReleaseUncontended·p1.00         10  sample               26656.000           ns/op
retainReleaseUncontended              100  sample   7161320       251.660 ±  0.761  ns/op
retainReleaseUncontended·p0.00        100  sample                 219.000           ns/op
retainReleaseUncontended·p0.50        100  sample                 228.000           ns/op
retainReleaseUncontended·p0.90        100  sample                 248.000           ns/op
retainReleaseUncontended·p0.95        100  sample                 252.000           ns/op
retainReleaseUncontended·p0.99        100  sample                 268.000           ns/op
retainReleaseUncontended·p0.999       100  sample               13168.000           ns/op
retainReleaseUncontended·p0.9999      100  sample               20320.000           ns/op
retainReleaseUncontended·p1.00        100  sample              624640.000           ns/op
retainReleaseUncontended             1000  sample   5812948      2167.782 ±  1.965  ns/op
retainReleaseUncontended·p0.00       1000  sample                1970.000           ns/op
retainReleaseUncontended·p0.50       1000  sample                1986.000           ns/op
retainReleaseUncontended·p0.90       1000  sample                2164.000           ns/op
retainReleaseUncontended·p0.95       1000  sample                2176.000           ns/op
retainReleaseUncontended·p0.99       1000  sample                3768.000           ns/op
retainReleaseUncontended·p0.999      1000  sample               20672.000           ns/op
retainReleaseUncontended·p0.9999     1000  sample               25472.000           ns/op
retainReleaseUncontended·p1.00       1000  sample               70912.000           ns/op
retainReleaseUncontended            10000  sample   4667998     21369.149 ±  8.200  ns/op
retainReleaseUncontended·p0.00      10000  sample               19488.000           ns/op
retainReleaseUncontended·p0.50      10000  sample               19584.000           ns/op
retainReleaseUncontended·p0.90      10000  sample               21440.000           ns/op
retainReleaseUncontended·p0.95      10000  sample               34752.000           ns/op
retainReleaseUncontended·p0.99      10000  sample               50880.000           ns/op
retainReleaseUncontended·p0.999     10000  sample               59136.000           ns/op
retainReleaseUncontended·p0.9999    10000  sample               71936.000           ns/op
retainReleaseUncontended·p1.00      10000  sample              112128.000           ns/op

Still LGTM.

@njhill thanks a lot again!


Documentation: Console Output is Out of Date

The debugging page purports to show console output from debugging. What's on the page looks nothing like what's in the console.

Hi Joe, can you please be more specific?  What part of that looks wrong to you?

http_plugin.js:94 HEAD http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mp 404 ()
(anonymous) @ http_plugin.js:94
shaka.net.HttpPlugin @ http_plugin.js:36
shaka.net.NetworkingEngine.send_ @ networking_engine.js:357
(anonymous) @ networking_engine.js:285
string_utils.js:130 Unable to find byte-order-mark, making an educated guess.
http_plugin.js:69 HTTP error text:
http_plugin.js:94 HEAD http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mp 404 ()
(anonymous) @ http_plugin.js:94
shaka.net.HttpPlugin @ http_plugin.js:36
shaka.net.NetworkingEngine.send_ @ networking_engine.js:357
string_utils.js:130 Unable to find byte-order-mark, making an educated guess.
http_plugin.js:69 HTTP error text:

I also can't seem to get shaka.log.Level to change the output either.

When you copy from the JavaScript console and paste into a text editor, you lose all the formatting and it becomes unreadable.  This is why what's in the docs doesn't look exactly like what you pasted.
It looks like there are some updates to make, though.  For example, in the tutorial as it is today, we show examples of debug logs before we get to the part about log levels.

I'll also update the part about log levels to be more explicit about where to insert the call to change the level.

The tutorial text has been updated.  The updates will appear in the nightly build tomorrow, and will be released in v2.0.4 next week.


A new organization using groups

Thought it would be a good idea to create a PR to discuss this in particular (and maybe already merge it to make further work easier):
This PR creates an explicit thematic sorting for our documentation using the groups feature (more on that here: https://docs.gitbook.com/content-editing/pages-structure#using-groups). Internal was moved to be the last group of pages because I think it's the less interesting of them for the person who is looking for help immediately.
This doesn't change any  file except SUMMARY.md.

Fiscal hosts need their own section, not under Financial Contributors. It's a seperate thing.

"Expenses & Getting Paid" is also a seperate thing, not a type of Financial Contribution.

@alanna and @jaskirat2000 I addressed the changes you requested:

Fiscal Hosts and Expenses & Getting Paid now have their own group of pages
Pages related to Core Contributors were moved to Internal

And a final suggestion:

Moving Values from The Open Collective Way to About. Community Guidelines is already a part of About so it seems fitting to put it there.


Subnets are redundant

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 46723a24-75ac-f6e2-c172-d3827ca0b7d6
Version Independent ID: c975744e-e594-5667-14b3-c38824bbe24c
Content: Baseline architecture for an AKS cluster - Azure Architecture Center
Content Source: docs/reference-architectures/containers/aks/baseline-aks.yml
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @PageWriter-MSFT
Microsoft Alias: prwilk

@MarcosMMartinez
Thanks for your feedback! We will investigate and update as appropriate.

The name of those subnets is dictated by the services that are deployed into them.  Personally, I don't like the names of them either, but those delegated subnets must be named that for their respective deployments to work.  If you're speaking of something else, please clarify.  The Azure Bastion service cannot co-exist with the Azure Firewall service in the same subnet, so they must be separated.  The names of their respective subnets are checked at deployment time by the resource provider for each.  If this has answered your question/observation, feel free to close.  Thank you.

I'm referring to the subnet addresses. They're the same.

Oh, yes! I see that now (I missed the obvious there). We'll get it fixed up.

I've pushed an update to fix the typo, @MarcosMMartinez.  The change should be live within 30 hours.  The BastionSubnet will be showing <IP_ADDRESS>/26, as per the reference implementation.  Thanks for pointing out this mistake and clarifying my confusion at what was redundant.


Add --help for all commands.

Is this still considered a desirable addition? If so, maybe we can add a "help wanted" or "good first contribution" label? If not, then I guess we should close the issue. @nodejs/node-gyp

I think it's worth doing, and the standard that I've seen in other projects is to add a help subcommand, so you can do node-gyp help configure to get the help for configure.

Any progress here?

npx node-gyp --help produces meaningful output so I think this is finally close-able after more than 12 years?


Gorelease and Krew Added

Read then delete

Make sure to use a concise title for the pull-request.
Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Goreleaser added for managing kubectl-flyte build and release.
Krew added for Publishing kubectl-flyte to krew plugin manage for Kubernetes
Github action added for releasing the binary and publishing new version of krew
Added version package

Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/121
Follow-up issue
https://github.com/lyft/flyte/issues/120

cc @EngHabu who added goreleaser to flytestdlib

@kumare3 @EngHabu I removed krew changes from this PR. There is one constrain, for krew plugin publish we need to do it manually the first time and for creating PR in krew we need our binary in GitHub release

Codecov Report

Merging #164 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

I'm trying to figure out the best setup to make github actions run. I understand they won't run here but I think if you merge your changes to your own master, they should (e.g. https://github.com/evalsocket/flytepropeller/compare/evalsocket:master...evalsocket:fix-121?expand=1)
You will need to set a github secret in your fork called flytegithub_repo with value evalsocket/flytepropeller to be able to build and push images to your github docker registry.

@EngHabu I think, I know what's wrong there
on:
  push:
    branches:
      - 'master'
    tags:
      - 'v*'
  pull_request:

@EngHabu please review it https://github.com/lyft/flytepropeller/pull/170


Sub-parser for better help message in command-line tool

🚀 Feature Request
Commands like fairseq-train currently does not display the full list of options.
This can be improved upon by using sub-parsers.
Motivation
By refactoring the codebase with sub-parsers, we can

Improve the self-documentation of fairseq-cli though command-line help messages.
Remove the need for hacky and overly complicated functions like parse_args_and_arch.

Pitch
Convert arguments like --arch to use sub-parsers instead.
There are other examples like --criterion etc.
Alternatives
Alternatively, we can stick with the current code-style.
But personally, I think the current level of smell is sufficient to warrant a refactor.
The smellier it gets, the more effort will be needed in the future.
Additional context
I'm a willing contributor! I work as a software engineer on our machine translation experimentation platform at work.

Yes, I completely agree. We have an active effort to migrate away from argparse to instead use dataclasses and hydra. We hope to share more details soon.
cc @kevinmtian @alexeib


better support for Flaxbeard Steam Power Mod?

I noticed Flaxbeard Steam Power Mod is been always half supported and at the same time half broken . Some versions have support adding liquids but no melt or drop recipes, other versions support adding melt recipes or drop but not new liquids and other versions don't work at all.
I am interested in the ability to add new alloy liquids and the ability to add new clay molds and create new items in different shapes .

We have removed support for FSP, they add support themselves.

aight :)


Cannot resolve module 'react/lib/CSSPropertyOperations'

Module not found: Error: Cannot resolve module 'react/lib/CSSPropertyOperations' in /home/jsmankoo/Cluep/WebServer-Internal-v2/node_modules/react-dates/node_modules/react-portal/build
@ ./~/react-dates/~/react-portal/build/portal.js 17:29-71
The latest update for react broke this I believe<EMAIL_ADDRESS>

It should be fixed in v4.0.1 - which version of react-dates are you using?

well my package.json was set to "^3.6.0" when i ran npm update and thats when it broke.

That won't update to v4, because of the ^. You'll have to rerun the install script in our readme to update to v4.0.1 (check the changelog for the breaking changes)


How to completely disable SpoofDPI on macos Sonoma (M1)?

Version
v0.10.11
Operating System
macos Sonoma (M1)
How are you running SpoofDPI?

Description
I installed spoofDPI via brew.
Ran it in terminal spoofdpi -window-size 3
Twitter, Youtube and almost all blocked sites started working fine.
After stopping SpoofDPI (ctrl + c), the original state of the network settings was not restored as Twitter and Youtube continue to work.
I restarted the computer, checked the state of proxy settings (everything is turned off), turned proxy switches on/off in wi-fi network settings, uninstalled and reinstalled the wi-fi interface, but nothing helped, SpoofDPI works for Twitter and Youtube.
What is the problem, why does SpoofDPI not turn off completely?

Are you sure there are no any other factors in play? SpoofDPI does not do anything besides setting itself up as a system-wide proxy server.
You said that you got it from Homebrew. Did you run it as service with brew services start spoofdpi? If so, brew will launch it after restart.
What is the output of brew services info -v spoofdpi? Are there any active spoofdpi processes?

All VPNs and proxies are disabled. SpoofDPI has not been started as a service. The command brew services info -v spoofdpi shows that there are no active processes:
spoofdpi (homebrew.mxcl.spoofdpi)
Running: ✘
Loaded: ✘
Schedulable: ✘
File: /opt/homebrew/opt/spoofdpi/homebrew.mxcl.spoofdpi.plist ✔
Command: /opt/homebrew/opt/spoofdpi/bin/spoofdpi
Log: /opt/homebrew/var/log/spoofdpi/output.log
Error log: /opt/homebrew/var/log/spoofdpi/error.log

Please, provide outputs of:

ps aux | grep spoofdpi
scutil --proxy

     13990   0,0  0,0 410733264   1536 s000  S+    9:39     0:00.00 grep spoofdpi

 {
HTTPEnable : 0
HTTPSEnable : 0
ProxyAutoConfigEnable : 0
SOCKSEnable : 0
}

I've noticed that after clearing the Google Chrome browser's cache, Twitter and YouTube stop opening, but they work again after a while.

Judging from the outputs you provided, there are not any copies of SpoofDPI running, nor is there any system-wide proxy set up. I think, that what you are seeing is not related to SpoofDPI.

I have a similar problem, after disabling spoof dpi, the internet stopped working on my mac

I also have this problem on my Macbook

вы ебучие пидарасы!!!

I have a similar problem, after disabling spoof dpi, the internet stopped working on my mac

Look at Settings -> Wi-Fi -> Details -> Proxies
If you're using spoof-dpi, options Web Proxy (HTTP) and Secure Web Proxy (HTTPS) turned on.
Normally, when you stop using spoofing, these options are turned off.
However, sometimes they stay turned on 🤷♀ You can manually turn them off, and your internet should start working.
I hope this tip might be useful for you

Faced a similar problem


v0.4.3

:robot: I have created a release beep boop
0.4.3 (2024-10-23)
Maintenance

bump dependencies (025cc41)
bump packages, workflows & configs (b9968ae)

Tests

add context data, run fmt (09525f4)
enable AWS test with secrets (#10) (0a12da2)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.4.3
:sunflower:


Transpile in loose mode and specify correct babel runtime

Loose mode works well here. Small size improvement.
About babel runtime. It should be in sync with others versions because
with every next version it may be changed. You can't be sure even these
versions do not cause bugs just because it works right now.
Syncing version with mui doesn't make sense. Then mui will be updated
and won't be in sync with this project. It's better to update whenever
possible to the latest versions.
There are different problems which we may solve. Do not stuck on helpers
please. You won't win a lot here. They will be 100% fixed when babel 7 will be
relased.

Did you checked it?

Oliver, stop breaking babel without discussions.

What do you mean by breaking babel?

@oliviertassinari Read the topic please. babel runtime is upgraded for the reason.

Oh. I see the problem. Ok, let's go back to babel.42.

https://github.com/zeit/next.js/blob/54e152b11bedea0c88e1799d27ed815160b7b040/package.json#L61

47

Who cares next js?

https://github.com/mui-org/material-ui/blob/2e7da5b68b1f9b4ba178b4338e4913f34bcc8383/package.json#L63

I do care about Next. We use it for the documentation and to power our product at the office.

Better, I think that we can try to keep this entropy to stress test it. See if people report issues about ti.

Sticking to betas is a wasting of a time. As I said a few times. You won't win a lot here.
https://github.com/renatorib/react-powerplug/blob/master/package.json#L63

Shooting in the feet. :(

One more thought. If the link between babel-runtime and babel-transform-runtime was that important, we would need to use a fixed version of babel-runtime, not a scoped version (^). For instance, It's not what react-powerplug is doing, it's taking the risk to break on the next release of babel-runtime. So, I would rather be greedy, try to maximize deduplicate, and do a step backward if some people raise an issue.
How does that sounds?

package managers are already stick with prerelease versions so this is not a problem. (^) doesn't change anything.
Duplication is not a problem. We still win comparing to inlined helpers. Sticking to one version doesn't work. If the winner will be 47 all 42 helpers will be duplicated for all packages because the winner is hoisted and you can't do anything with this. Use the latest one and don't waste a time trying to sync these versions.

package managers are already stick with prerelease versions so this is not a problem. (^) doesn't change anything.

Not on a new installation

Use the latest one and don't waste a time trying to sync these versions.

Isn't what we do?
We use<EMAIL_ADDRESS>to transpile the source. Still, we are accepting older runtime.

@oliviertassinari Well, you can break the build doing this. There was a breaking change before 42. They changed helpers. You are saving a few KB but your project may crash with the next dependency upgrade.

You are right. Sticking is a good idea. That's my fault.

But sticking to different version can break one day.

sticking to different version can break one day.

I agree, it will break one day.
Following the same strategy, I try to keep the ^ scope as wide a possible on the package.json while always beeing up to date on the yarn.lock. I have found it to be a nice tradeoff between deduplication and "up-to-date-ness".

Duplication is not a problem

You were right, the overhead is minimal, it's a simple proxy to core-js

builtIns helpers don't use core-js


Add diagnostic logs to key vault

This adds a diagnostic setting to our Keyvault, as well as a storage account where we can keep the logs (retained for a year by default)

 Diagnostic logs in Key Vault should be enabled


Reversed Grünfeld

In this database, every other 'reversed' opening is called "Reversed Opening" not "Opening Reversed", e.g. "Reversed Alekhine", "Reversed Blumenfeld Gambit", ...
Also, in my opinion, this opening starts one move earlier, analogous to the non-reversed Grünfeld.

Thanks!


Some features missing

Just wanted to include this dataset in a teaching activity. I discovered that some cities miss some feature columns:
In [24]:
wf = pd.read_csv("https://zenodo.org/record/4980359/files/weather_prediction_dataset.csv?download=1")

In [25]:
len([ item for item in wf.columns if "cloud" in item.lower() ])
Out [25]:
13

In [26]:
len([ item for item in wf.columns if "temp_mean" in item.lower() ])
Out [26]:
18

Yes, that's correct.
For those I did not find data on http://www.ecad.eu
For the selection of cities I tried to find cities that had a large overlap in the features provided on ECAD, but the type and number of features varies quiet a bit across countries and cities.
Do you think that is an issue? Then, we could decide to drop those features altogether. Or, as an alternative, to add an overview table showing which features are present for which city.

Well, I was just playing around with kmeans clustering and while trying out several combinations, I basically saw that it turned out to be (rather) complex.
For example, I was trying to cluster coastal versus mainland cities. Here it proved somewhat hard to find features relating to rain/clouds and temperature. I'll keep searching.


Add development infrastructure

This pull request will add development infrastructure to vue-katex which will help guide the way for future development.
Features added:

Unit testing with jest
Linting with ESLint

Vue.js Recommended, ESLint Recommended, Google

Transpiling using babel
Minified bundle using Bili as the bundler

Bili provided smaller and more bundling options than Vue-cli
CommonJS, UMD, and ES modules bundles

Additional changes:

Added myself as a contributor inside of package.json
Incremented patch version from 0.1.3 to 0.1.4 in accordance with Semantic Versioning

No changes were made to the API and no functionality was added

If you agree with the changes here then please hit the merge button. If not, let me know and I'm happy to make some edits to this pull request :)
Merry Christmas!

This is so nice of you! I learned a lot from your pull request. Thank you! 🙏

I'm happy to help out! You've done great work with creating this project. I've been using vue-katex in some of my other projects and it has been tremendously useful. I just figured I would return the favor :)


Add some additional debug info on panic

Just adding some additional debug info which I found myself needing while debugging https://github.com/nextest-rs/nextest/issues/1090 and thought it might be useful for others!
If not, feel free to close

Thanks, I think I'm going to roll this into #148.

This is now part of #148. Thanks again for the PR!


fix image to match description (swap nodes b and c)

The code and the description now match the figure where a and c feed into b.

Thank you for your update/correction -- your commit is being merged.


fix: use original interpreter path as 'home' value in pyvenv.cfg

This is a follow-up of #226 to fix another place.

Hey guys! Was this fix ever released? I suspect this might be why the virtual environment I tried to created with py_venv is broken (for IDE).

I'm working on a release right now but it's a long process because we introduced Rust for writing tools and don't want to expose that dependency to users.
https://github.com/aspect-build/rules_py/releases - last release was november.
That said, I think we should just cut a release from before the rust toolchain introduction.

published https://github.com/aspect-build/rules_py/releases/tag/v0.6.0


Undefined array key "REDIRECT_URL" in /var/www/html/data/index.php on line 2

Undefined array key "REDIRECT_URL" in /var/www/html/data/index.php on line 2

[13-Nov-2022 04:34:25] WARNING: [pool www] child 96 said into stderr: "NOTICE: PHP message: PHP Notice:  Undefined index: REDIRECT_URL in /app/index.php on line 10"
[13-Nov-2022 04:34:25] WARNING: [pool www] child 96 said into stderr: "NOTICE: PHP message: PHP Notice:  Undefined offset: 1 in /app/index.php on line 14"
[13-Nov-2022 04:34:25] WARNING: [pool www] child 96 said into stderr: "NOTICE: PHP message: PHP Notice:  Undefined offset: 2 in /app/index.php on line 14"
[13-Nov-2022 04:34:25] WARNING: [pool www] child 96 said into stderr: "NOTICE: PHP message: PHP Notice:  Undefined offset: 3 in /app/index.php on line 14"

Seems to only work with Apache with RewriteEngine enabled. I have got a system using this now and no php error but csgo client fails to connect.
Using "php:7.4-apache" docker image with command "a2enmod rewrite". Any suggestions?

Found the issue it was related to the link generation not using relative pathing.


Support multiple function names in Firebase preset

Describe the feature
I'm currently using a regex to replace the name of the export { s as server }.
It would be nice to see a way to create different names in functions, allowing us to use Firebase project with multihosting out of the box
Additional information

[ ] Would you be willing to help implement this feature?

I was able to get this to work using this config option
replace: {
    'const server = functions.https.onRequest': 'const $NEW_NAME = functions.https.onRequest'
}

I would be interested in implementing this, but I'm not sure if there is a better option than using rollup replace. I was thinking of replacing export const server with something more distinct like export const $FIREBASE_FUNCTION_NAME and have $FIREBASE_FUNCTION_NAME replaced with server by default.

duplicate of #266
Let's move the discussion there.

duplicate of #266
Let's move the discussion there.


Don't have access to my bots from Bot Framework Portal

Issue Description
When I go to My Bots at Bot Framework Portal I can't find my bot.
Bot info of one of the already registered and working but now missing bots:
Bot Id: CINOLATeamsApp-local-debug
App ID: cb636e51-f9b3-49c6-8b94-66ad1a514d24
SDK Platform: .NET
The email that was associated is<EMAIL_ADDRESS>

Hi @amaroRafael
It appears I'm also not able to see all of my bots at https://dev.botframework.com/bots
I noticed my bots only show up after creating a new bot here https://dev.botframework.com/bots/new
Checking with engineers on this issue and will report back soon. Thanks.

Hi @amaroRafael
we confirmed your information and found you submitted a request of clean up your privacy data to us. So, we removed you from the bot's owner list. This change usually occurs when someone leaving the organization. Can we confirm that what happened in 8/31/2022 12:00:26 AM(UTC)?

Hi @moooyo
Thanks for replying to me.
Let me explain the situation.
My account was in two organizations, two different tenants.
And I removed this account from one of the tenants. However, the tenant that I left was not the same tenant who is the owner of the bots.
So, it shouldn't have removed me from the bots.
I can provide you with the tenant ids to confirm this information if you need it.

Hi, @armaansood. I apologize for the inconvenience for the situation. We've identified an issue around handling tenant information when a data clean up request is triggered and we are working on a fix for it. But unfortunately, we can't simply bring it back for you as our process requires a little bit confirmation to recover your ownership.
I would suggest two options

If your current tenant have a valid azure subscription. I recommend you go to azure portal and recreate a new "Azure Bot" and enable Teams channel. In fact, bot record is just a piece of metadata and you can easily point the new bot record's endpoint to your bot app (local or remote). Azure portal is a more modern and standardized solution which tracks resource ownership in tenant level than dedicated portal (dev.botframework.com) which tracks ownership by individual owner id.
If you really need that bot back. I'm afraid you have to use the owner email to send us an request to recover the ownership. You will need to cc your tenant's admin and get his\her approval and send it to<EMAIL_ADDRESS>
I will recommend the first approach. Apologize again for this issue.

Hi @boydc2014
I was the bot owner, sometimes I also add my Manager as the owner of bots, but I don't remember if I included him this time. Can you at least let me know if there is any email of the owner included that is from<EMAIL_ADDRESS>If it doesn't have any email there, this means that I was the only owner of this bot.
About the 1. suggestion.
When I use the Teams Toolkit, it will auto-create the bot in botframework.com.
If that bot is not there, when I try to run the project in Visual Studio, it will fail and say that I need to run the [Teams Toolkit] -> [Prepare Teams App Dependencies]
How can I solve this issue?
I am developing the project in Visual Studio 2022.
This is a C# project

Hi, @amaroRafael our log shows you were the only owner, thus there is no owner right now after clean up.
About suggestion 1. Yes, the approach you were using is basically Teams Studio calling Azure Bot Service(which is us) creating the record for you using your identify (individual identity) in dev.botframework.com and enabling Teams channel for that bot.  The functionality is the same when Teams creating it for you or you choose to create your bot by yourself in Azure Portal. It's the same service and feature sets.
In Azure Portal, the benefit is the resource ownership is tracked via tenant/subscription instead of individuals. The cost is you have to create via Azure Portal by yourself.  I recommend this approach for the long run.
The missing part is ownership to the metadata in service side, it's agnostic to which client language or IDE you use.
If you only doing local debugging, the most straightforward way is to re-create another bot, or to be specific, bot registration.  The bot registration should be lightweight and easy to recreate. You bot code written with VS is you bot app itself, which can work with any registration if you get the configuration aligned. Does that make sense?

Hi @boydc2014 ,
Is it possible to remove this bot from botframework.com so I can use the same application to create a new bot?
I am asking this because we have an environment where this application is already in use by some users.

Hi @boydc2014 ,
Is it possible to remove this bot from botframework.com so I can use the same application to create a new bot? I am asking this because we have an environment where this application is already in use by some users.

Yes, @amaroRafael we can do that. Can you help send a email with the original owner email (assume you still hold) to<EMAIL_ADDRESS>and we can do the clean up

Bot has been cleaned up.


Split .check()?

.check() can trigger a recurring check, but returns a single promise. The promise will resolve once, or reject once, even if the connection status changes later.
I think you'd be doing these for different reasons. The recurring check would likely be for some user notification. A one-time check is more likely in response to something, like an error.
I think maybe these two things should be separate. Like a .check() that returns a promise, and a .startChecking({interval, timeout}) to start getting the events.

good thinking, I think having two methods for one-time checks vs intervals makes it more clear. And with .startChecking({interval, timeout}) we can also add .stopChecking(). I'd say let's do that :)

connectionStatus.startChecking({
  interval: 30000, // ms
  timeout: 3000 // request timeout before aborting request
}) // returns undefined
connectionStatus.stopChecking() // returns undefined

I'll give this a shot!

done via 33d9e98


Allow tel as input time.

This is useful if you want to grant the user ability to display pad-like input for code

@chitezh not really get it, why not to use <input id="telNo" type="tel" /> ?

I want the keyboard on mobile to display as tel but Only types like: text, number, password are accepted.


Make option to push to Dockerhub

Purpose/implementation Section
What changes are being implemented in this Pull Request?
I need leanbuild to be updated so render will complete. #131
I'm attempting to add a manual trigger to the Docker build test GHA for just such occasions so a rebuild can be built and pushed on command.
What was your approach?
What GitHub issue does your pull request address?
#131 Hopefully
Tell potential reviewers what kind of feedback you are soliciting.

Also had to fix the install_github.R script because it was grabbing a GITHUB_PAT from the environment.

This is working so far. I'll be able to test the manual dispatch after I merge. So here we go.


[Bug]: When page name is bigger, tooltip is not popping up

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Enter a bigger page name and hover over the name, observe no tool tip is shown
Steps To Reproduce
Go to Pages
Enter a bigger name
Hover over the page name
Observe No tooltip is popped up
Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Appsmith v1.9.22-SNAPSHOT

Also can not create page name more than 30 characters.

This seems to have been solved


webpack 2 tutorial

Any chance of creating one for webpack2?

I've been thinking updating this tutorial for a while, and while I've made improvements, I've never published them. Webpack 2 might be what pushes me to finally update the tutorial with more quality content.
The biggest problem right now is that I've moved away from web development mostly, and I don't wish to teach from a position of inexperience.
So...yes I think I will finally update and refine this tutorial. I'll try to have it done by one month from now.

I would love to contribute here. Please do let me know if I can help. It will help me learn as well.

I'm bad at deadlines, but the new tutorial is coming soon.


Scale Ireland and London

What
Add 3 to London
Remove 12 from Ireland
How to review
See if you agree with the numbers

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Totally agree. I think Pivotal story #175872448 covers that, at least in part.