Get Receipt Lines - Error when adding from the same PO

1. Describe the bug
Issue with standard functionality, when creating a Purchase Invoice and trying to add extra lines via Line > Functions > 'Get Receipt Lines', if you select a receipt line that has the same PO as an existing line on the Purchase Invoice, you get the following error.

Debugger breaks on Codeunit 1173 Document Attachment Mngt, Copy Attachments function, Line 1175

2. To Reproduce
Step 1: Create a Purchase Order, and post lines making sure to just 'Receive'.
Step 2: Add attachments to the Purchase Order (attachment should go on the header, not the lines).
Step 3: Create a Purchase Invoice, use Line > Functions > 'Get Receipt Lines' function to add the first receipt line.
Step 4: Use the function again but select a different receipt line which originates from the same PO.
procedure CopyAttachments(var FromRecRef: RecordRef; var ToRecRef: RecordRef)
var
    FromDocumentAttachment: Record "Document Attachment";
    ToDocumentAttachment: Record "Document Attachment";
    FromFieldRef: FieldRef;
    ToFieldRef: FieldRef;
    FromDocumentType: Enum "Incoming Document Type";
    FromLineNo: Integer;
    FromNo: Code[20];
    ToNo: Code[20];
    ToDocumentType: Enum "Incoming Document Type";
    ToLineNo: Integer;
begin
    FromDocumentAttachment.SetRange("Table ID", FromRecRef.Number);
    if FromDocumentAttachment.IsEmpty() then
        exit;
    case FromRecRef.Number() of
        DATABASE::Customer,
        DATABASE::Vendor,
        DATABASE::Item:
            begin
                FromFieldRef := FromRecRef.Field(1);
                FromNo := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("No.", FromNo);
            end;
        DATABASE::"Sales Header",
        DATABASE::"Purchase Header":
            begin
                FromFieldRef := FromRecRef.Field(1);
                FromDocumentType := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("Document Type", FromDocumentType);
                FromFieldRef := FromRecRef.Field(3);
                FromNo := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("No.", FromNo);
            end;
        DATABASE::"Sales Line",
        DATABASE::"Purchase Line":
            begin
                FromFieldRef := FromRecRef.Field(1);
                FromDocumentType := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("Document Type", FromDocumentType);
                FromFieldRef := FromRecRef.Field(3);
                FromNo := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("No.", FromNo);
                FromFieldRef := FromRecRef.Field(4);
                FromLineNo := FromFieldRef.Value();
                FromDocumentAttachment.SetRange("Line No.", FromLineNo);
            end
    end;

    case ToRecRef.Number() of
        DATABASE::"Sales Line":
            if FromRecRef.Number() <> DATABASE::"Sales Line" then
                FromDocumentAttachment.SetRange("Document Flow Sales", true);
        DATABASE::"Sales Header":
            if FromRecRef.Number() <> DATABASE::"Sales Header" then
                FromDocumentAttachment.SetRange("Document Flow Sales", true);
        DATABASE::"Purchase Line":
            if FromRecRef.Number() <> DATABASE::"Purchase Line" then
                FromDocumentAttachment.SetRange("Document Flow Purchase", true);
        DATABASE::"Purchase Header":
            if FromRecRef.Number() <> DATABASE::"Purchase Header" then
                FromDocumentAttachment.SetRange("Document Flow Purchase", true);
    end;

    if FromDocumentAttachment.FindSet() then
        repeat
            Clear(ToDocumentAttachment);
            ToDocumentAttachment.Init();
            ToDocumentAttachment.TransferFields(FromDocumentAttachment);
            ToDocumentAttachment.Validate("Table ID", ToRecRef.Number);

            ToFieldRef := ToRecRef.Field(3);
            ToNo := ToFieldRef.Value();
            ToDocumentAttachment.Validate("No.", ToNo);

            case ToRecRef.Number() of
                DATABASE::"Sales Header",
                DATABASE::"Purchase Header":
                    begin
                        ToFieldRef := ToRecRef.Field(1);
                        ToDocumentType := ToFieldRef.Value();
                        ToDocumentAttachment.Validate("Document Type", ToDocumentType);
                    end;
                DATABASE::"Sales Line",
                DATABASE::"Purchase Line":
                    begin
                        ToFieldRef := ToRecRef.Field(1);
                        ToDocumentType := ToFieldRef.Value();
                        ToDocumentAttachment.Validate("Document Type", ToDocumentType);

                        ToFieldRef := ToRecRef.Field(4);
                        ToLineNo := ToFieldRef.Value();
                        ToDocumentAttachment.Validate("Line No.", ToLineNo);
                    end;
            end;

            if not ToDocumentAttachment.Insert(true) then;

            ToDocumentAttachment."Attached Date" := FromDocumentAttachment."Attached Date";
            ToDocumentAttachment.Modify();   ######### THIS IS THE LINE THAT BREAKS WHEN RUNNING IN DEBUG ########

        until FromDocumentAttachment.Next() = 0;

    // Copies attachments for header and then calls CopyAttachmentsForPostedDocsLines to copy attachments for lines.
end;

3. Expected behavior
The receipt line(s) selected should be added onto the Purchase Invoice, and any attachments should also be moved across onto the Purchase Invoice if they have not already been copied from a previous use of the 'Get Receipt Lines' function - if the attachments already exist then we should see just the new Purchase Lines added.
4. Actual behavior
The selected receipt line(s) is not added onto the Purchase Invoice, and the attachment(s) do not get moved across onto the Purchase Invoice if they were not previously added.
5. Versions:

AL Language: v11.0.827766
Visual Studio Code: 1.80 (current)
Business Central: 22.2.56969.57282

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.

@AndreiPanko answered the following on yammer:

This one was already reported and fixed. I'm not aware how it will be distributed (next minor update or hotfix).
Ref: 477621


Cannot build encrypted images on Zephyr

Describe the bug
mirror https://github.com/mcu-tools/mcuboot/issues/938

I'm working on a fix

upstream bugfix posted https://github.com/mcu-tools/mcuboot/pull/939


Update README.md pipy images

fix images to take url of github to render the images correctly on pypi
add badges

Thanks! I'll process this PR soon. I'm preparing a next release and will incorporate these changes in it.


Backport: Adds the default maven repositories if extra ones are added

Avoids the default maven repositories being removed from the maven settings by the new specified repositories

Release Note

When overriding the maven repository settings, the default repositories should still be retained to avoid losing the base
dependencies.

retest this please

retest this please

Can someone give the tests a nudge please?

retest this please

Can someone give the tests a nudge please?

Done

retest this please

Can someone give the tests a nudge please?

Done

Thanks!
Look like the tests on this branch are not going to get much better than this since many of the e2e test improvements haven't been backported. Other PRs on the release-1.8.x branch seem to be failing in the same way, eg. #3717

Yes, testing are not stable in this branch as we've started to give attention recently when we decided to use this as LTS. Merging.


fix: application deprecation

Fixes #3
I commented out the twonumbers href test for now. The link still exists, but the layout changed, and I don't know how to derive the proper N numbers. The way the test is written seems a little silly (and brittle, since it might break again in the next TypeDoc update).

since the author of this plugin doesn't seem to be around, i've forked the plugin and updated it to work with the latest version of typedoc with the help of gerrit, you can find it here: https://github.com/Zamiell/typedoc-plugin-not-exported/tree/publish


3D Modelling Showcase (Hard/Creative)

We would like to show our past modelling projects. This will be a more open-ended project.

In the modelling section of our website, I would like to replace the 2 "stock" images with 3 images placed horizontally with captions under them. These would be 3 past projects that we worked on. I will either send these images and descriptions in slack or in this comment. For mobile devices, these images should not stack but instead scroll horizontally off the screen. If you cannot figure out how to do the mobile bit, just make it so it crops out the first and last image on mobile devices


Got 'debugging connection was closed websocket disconnected reconnect when ready by reopening devtools' when accessing devtoolsFrontendUrl

Steps to reproduce
I launched a browser using
var browser = await puppeteer.launch({ headless: false,args:["--remote-debugging-port=9225"] });
I accessed http://[remote-ip]:9225/json/list and got 'devtoolsfrontendurl' from this.
And when I accessed this url I got this error
Expected results
I wanted to intereact with the pages in the remote browser.
Actual results
When I use puppeteer version higher than 19, this problem occurs.

If you want to open DevTools for the pages, set devtools: true in the launch arguments. If the devtoolsfrontendurl URL provided by the browser's JSON endpoints is not working, please file an issue at https://crbug.com/new.


why arent you using aoa in the decoder?

Hi. From your paper, you are using AoA in both the encoder and decoder. For the decoder, when you define
self.attention = MultiHeadedDotAttention(opt.num_heads, opt.rnn_size, project_k_v=0, scale=opt.multi_head_scale, use_output_layer=0, do_aoa=0, norm_q=1)
As seen, do_aoa  = 0, so its actually not happening in the decoder in this case.
Is that how it should be?

It may seem a bit confusing, but there is actually an aoa layer (self.att2ctx) after the attention.  We set do_aoa = 0 in order to make it easier to compare different decoding schemes.

Oh I see. Thanks!


[BEAM-10863] Change encoding of Pubsub sink to global window.

r: @chamikaramj

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM. Thanks.

Run Java PreCommit

cc: @lukecwik
Thanks, Cham!


update supabase policies for categories/sections/transactions

need ability to select/insert/update/delete categories on a shared budget

sections + categories are finished - need checked

transactions finished - need checked

Done and verifies


ghcjs-*: Expose the version of GHC used

Motivation for this change
This is more meaningful than the GHCJS version for most tasks.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

CC @ElvishJerricco

@Ericson2314 What's the purpose of this? Frankly I kinda wish bootPkgs weren't passed thru, since the boot GHC should be considered irrelevant to the GHCJS.

@Ericson2314 if it's supposed to indicate the version of GHC that this GHCJS represents, I think it's a coincidence that this works right now. There's no fundamental reason GHCJS 8.4 can't be built with GHC 8.2, I think it's just some buggy things preventing that from working right now.

@Elvishjerricco so first I was thinking exactly what you are. (Indeed I like the way your ghcjs-ng uses bootPkgs and separates booting from normal cabal2nix derivation a lot better.) But then I remembered that GHCJS is both using that GHC's executable component to build itself, and linking its library component for the early compiler stages. So insofar that it inherits behavior from the GHC library, it's not a coincidence.
Eventually with butter GHCJS (or webasm ;)) we'll be better, but I don't think it's worth messing with the boot process to get separate GHC exe and GHC library derivation dependencies.

and linking its library component for the early compiler stages

Huh? Not in 8.2 /  8.4. These versions brought the GHC source in-tree as a submodule and builds the GHC modules it uses itself. I believe you could literally build GHCJS 8.4 with GHC 8.2 right now, if you worked out a couple bugs, and you would get actual GHC 8.4 behavior.

Oh my bad. Well then let's redefine them for the latter two then. I made this for the earlier two since they had very different version numbers, and then coppied it to the latter two without checking so I could always get the version from GHCJS the same way.


Readme Improvement face biometric

https://github.com/akshitagupta15june/Face-X/tree/master/Facial_Biometric

hey,@akshitagupta15june I want to work on this issue. please let know

Assigning


android fecth TypeError: Network request failed(…)

when use fetch in android.
when have symbol '|'  in url
use fetch get a url like
fetch("/api?dates=2016-05-23|2016-05-24")
will catch a error TypeError: Network request failed(…)
in IOS it is ok..

you can try  encode url parms~

@jiangqqlmj ok thanks

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-fecth-typeerror-network-request-failed
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


[core-webpack-tools] rm .skip and regen snapshot file

Closing as this was done in, https://github.com/iTwin/itwinjs-core/pull/4159


Failed Test Sequence_with_dealloc

When I ran the test conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc on my end, the test failed because two operands got inverted:
FAIL: Open Neural Network Frontend :: conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir (1 of 324)
******************** TEST 'Open Neural Network Frontend :: conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir' FAILED ********************
Exit Code: 1

Command Output (stderr):

RUN: at line 1: /data00/yan.xu/onnx-mlir/build/Debug/bin/onnx-mlir-opt -O3 --shape-inference --convert-onnx-to-krnl --buffer-deallocation-pipeline  /data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir -split-input-file | /data00/yan.xu/llvm-project/build/bin/FileCheck /data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir
+ /data00/yan.xu/onnx-mlir/build/Debug/bin/onnx-mlir-opt -O3 --shape-inference --convert-onnx-to-krnl --buffer-deallocation-pipeline /data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir -split-input-file
+ /data00/yan.xu/llvm-project/build/bin/FileCheck /data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir
/data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir:52:15: error: CHECK-DAG: expected string not found in input
// CHECK-DAG: [[VAR_14_:%.+]] = affine.apply [[MAP_1_]](){{.}}[[VAR_12_]], [[VAR_dim_0_]]{{.}}
              ^
<stdin>:41:43: note: scanning from here
 %12 = arith.index_cast %11 : i64 to index
                                          ^
<stdin>:41:43: note: with "MAP_1_" equal to "#map1"
 %12 = arith.index_cast %11 : i64 to index
                                          ^
<stdin>:41:43: note: with "VAR_12_" equal to "%12"
 %12 = arith.index_cast %11 : i64 to index
                                          ^
<stdin>:41:43: note: with "VAR_dim_0_" equal to "%dim_0"
 %12 = arith.index_cast %11 : i64 to index
                                          ^
<stdin>:43:2: note: possible intended match here
 %14 = affine.apply #map1()[%dim_0, %12]
 ^

Input file: <stdin>
Check file: /data00/yan.xu/onnx-mlir/test/mlir/conversion/onnx_to_krnl/Sequence/Sequence_with_dealloc.mlir

I believe this test should be similar to test/mlir/conversion/onnx_to_krnl/Sequence/SequenceErase.mlir where you shouldn't check the affine map since it can differ on different machines? Any idea on this issue? @philass @tungld @AlexandreEichenberger

Hi @Connor-XY, I have not yet tried but am thinking about this: we still check affine maps, but do not check the order of operands in affine apply, e.g.
CHECK-DAG: [[VAR_14_:%.+]] = affine.apply [[MAP_1_]](){{.}}{{%.*}}, {{%.*}}{{.}}

I think this will do for my case!

Solved in https://github.com/onnx/onnx-mlir/pull/2680.


kopano meet broken with image version 0.20.0_0

With the old version of 0.19.1_0, i am able to login and to start simple calls. With the current version i get the following error printed in the web-view:
App start failed with error
Error: unexpected Content-Type

Das ist ein schwerwiegender Fehler und die App must neu geladen werden.

The chromium development tools are printing the following section:
app initialization failed - this is fatal Error: unexpected Content-Type
    at actions.js:114
(anonymous) @ Meet.js:65

Since this seems to be a problem with the meet module itslef, should i place this bug-report some-where else?

Hi @cguentherTUChemnitz,
yes I've noticed this error myself as well, but did not yet have the time to really dig into the cause of it.
Since this is not really about dockerising Meet, but an issue in Meet itself I would recommend to either open up a post on the Kopano Forum (preferred) or in its dedicated issue tracker here on Github.

Potential reason for this error (at least the is what I see in my environment) is that when the browser opens /api/config/v1/kopano/meet/config.json the content type of this file is text/plain instead of application/json.
This is probably something that needs to be fixed in the kweb.cfg in this repo after all.

I have not yet tried it personally, but the upstream docker image has been modified so that mime detection in the web container should work now.
On top of this I have configured travis to start a container build, if there has been no build on the master branch within last 24 hours (we'll to be exact it does a daily build, but only if there was no build within last 24h so practically I guess the longest time between builds could be something close to 48h).


Update MessageTracing documentation to reflect the current APIM Analytics

Description:
The documentation for message tracing[1] is still referring to DAS. It needs to update the newer versions of APIM Analytics as it refers to some files and instructions that does not exist in the current version. For example:

Copy the DAS_MESSAGE_TRACE_1.0.0.json file and add it to the ><APIM_ANALITICS_HOME>/repository/deployment/server/eventstreams directory to deploy the same definition in WSO2 API Manager Analytics.

We don't have this file anymore.
[1]https://apim.docs.wso2.com/en/latest/learn/api-gateway/message-tracing/#message-tracing
Suggested Labels:

Suggested Assignees:

Affected Product Version:
APIM 3.1.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:
https://github.com/wso2/docs-apim/issues/1608

In the 3.X releases we don't have a support for this.  Recommendation is to use Open Tracing and Observability  to achieve this. There's a discussion going onto decide whether this should be supported as is. Until a conclusion is made, doc will be removed.


Adding the icons

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Adding the icons for different sections such as home , data info etc:- on the navbar
Use Case
This would enhance the overall look of the website.
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Don't need it.


Atom does irrelevant word substitutions

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Atom most of the time gives irrelevant substitutions (suggestions) of typed words.
I think this kind of behavior annoys some users.
Steps to Reproduce

I types some word, for example: calculate
Atom gives some irrelevant suggestions

**Expected behavior:**give appropriate substitutions or not give at all
Actual behavior: irrelevant suggestions
Reproduces how often: 100%
Versions
Windows 8, 64 bit
atom version: 1.25.1

See the settings for the autocomplete-plus package for ways to customize what results are shown. Specifically, "Include Completions From All Buffers", "Use Strict Matching For Built-In Provider", and others.
Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

The Atom Flight Manual
The Atom FAQ on Discuss
Discuss, the official Atom and Electron message board
Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.


feat(BusStopChange): store alerts into an S3 bucket for posterity

Summary of changes

Asana Ticket: Implement Bus Stop Change Draft w/ Historical Data
Despite working on this application for years, this is my first time really tackling anything OTP-related.
Goal
We want to be able to display alerts relating to bus stop moves or closures from the past four ratings on the /bus-stop-changes page . We don't have great data readily available* for past alerts, and it seems easier to start saving and managing this data ourselves.
*(there's past alert information out there in various places, but if we want to use our typical functions for displaying alerts we'd have to convert the format, and if we wanted to group them by routes or stops we're SOL if those are absent from the V3 API)
Approach
It turns out we already have a GenServer that's fetching and parsing all the V3 API alerts every minute in Alerts.Cache.Fetcher. And since it's already structured using dependency injection, it was easy enough to swap out its arguments to construct an appropriate fetcher for this goal's use case:

Argument
Default value
This PR uses

Module/function/argument
V3Api.Alerts.all()
V3Api.Alerts.all(args)

Repeat (milliseconds)
60_000
3_600_000

Function to run on parsed alerts
Alerts.Cache.Store.update/2
Alerts.Cache.BusStopChangeS3.copy_alerts_to_s3/2

That last function will handle saving the alert by doing the following:

Filters the alerts to we actually care about (having an effect of :stop_closure or :stop_moved)
Converting each alert to a new structure, %HistoricalAlert{}, that includes some helpful metadata for later display (the routes, stops, and municipality the alert affects)
Saving to the S3 bucket, using the alert ID as the name. This gets rewritten on subsequent writes, ensuring that what ends up in S3 is always the latest revision of an alert.

There's also a function, Alerts.Cache.BusStopChangeS3.get_stored_alerts/0 for retrieving all saved alerts from S3.
I've also had to modify the template/view/controller for the /bus-stop-changes page to be able to handle displaying %HistoricalAlert{}.

General checks

[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
[x] Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
[ ] Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New endpoints, or non-trivial changes to current endpoints
* [ ] Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
* [ ] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

Thanks @paulswartz, I rebased this on the latest master (which had covered some of the ancillary stuff) and added one more commit to address the rest of your comments so far. ⚡

finally figured out the config; after adding the runtime config to the release and replacing the module attribute with a function, it finally writes alerts to the bucket correctly!


Improve usage as a library

Hi @common-nighthawk , I love this code you wrote! I wanted to use it for a CAPTCHA. I've made some changes and I'm putting them here. It will look like a lot of changes, but its not (for some reason your code wasn't gofmt-ed, so there's a ton of whitespace changes).
First of all, what is the license on your code? If its not open, its fine, I'll follow whatever you decide.
My changes:

I made one big change - that is to run go-bindata fonts/ and then add that to the repo. Now all of the fonts are built-in and you can import any fonts you want even if you use Windows (I use Windows so this was great for me).

I made a small change to add a String() method to the figure struct. That means that you can print a figure with just fmt.Println(myfigure) and also means that you can create strings from the figures (myfigure.String()) which is useful in my case since I want to use these in a captcha.

I added a test (tests are now easy since you can stringify things).

That's basically all the changes I made. The function newFontFromReader() is basically deprecated now, since its no longer needed to support adding random flf files, but I haven't deleted it in this.
I'm going to continue to tweak things a little bit for my CAPTCHA needs, and I'm happy to follow your API if you want PRs. However, if you don't want PRs, no problem, I'll just continue on my own way :)

Hi @common-nighthawk , done.
There's one weird thing though: check out the test for default. It's font is missing some left-space on the first line. I have no idea why. I removed the trimspace I put in and replaced with a trimright (https://github.com/common-nighthawk/go-figure/pull/6/commits/0a8e758e79c4756745b4814d8d21f492b7a908d8) but that didn't fix it. I'm not sure whats going on there, maybe you could take a look.

Awesome!  I'm glad we added that test!--looks like TrimSpace wasn't exactly correct.
I'm not sure what's going on with the test.  But if you edit the output to be what you'd expect (inserting 2 spaces on line 22), the test still passes.  I confirmed everything outputs as expected locally as well.
I'll go ahead and merge.  Thanks again!!


Update create-database-scoped-credential-transact-sql.md

@VanMSFT
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @NandanHegde15! We really appreciate your help! @rwestMSFT has pulled in your changes in a private PR, so we can close this for now. If there's anything else, please feel free to let us know.


Add GLES 3 support for GWT via WebGL2.

Currently still wip, but I'd appreciate some initial feedback :)

Looks good so far.
Good job!

Providing visualization of the change, this analysis can be done free of charge for all PR’s, just let me know and I’ll make it happen.

Providing visualization of the change, this analysis can be done free of charge for all PR’s, just let me know and I’ll make it happen.

Just wanted to get some feedback, I appreciate that and we will try to improve stuff and get this more useful in your context.

@villelaitila I don't need this.
Please remove your comments from this pull request.

@villelaitila please remove both your comments and bot comment from this PR.

Superseded by #7037


New feature to include method reference in RFC metric

Now the method reference calls are counted in the RFC metrics

I updated the pom to use Junit 5

This new version has a readable api and some useful things, such as @DisplayName, to declare more friendly names for test cases.
All old tests are ok with the new version of Junit, I had to change the package of some annotations, but everything works.

Hi, @maykon-oliveira! Thanks for the PR! The way it is now, it's just very hard to review, though :/
I would need you to:

Your IDE replaced tabs to spaces. This means you basically changed all files in the project.
Split the PRs in two. One that moves things to JUnit 5 (thanks for that), and another one that adds the new functionality to RFC. (Note that codecov says that coverage went down significantly, so I imagine some tests are not being run by the coverage tool anymore?)

Cheers!

Sure, it's better. I will create two pull requests, one with Junit update, and other that adds the new functionality to RFC.

@maykon-oliveira Now, we are ready for this PR, right?


Check out Zotero/Mendele/Citavi

While writing and reading important paper and blogs these apps can help to manage everything at the end.

@Mithunjack If you are planning on putting your thesis in git, check out https://github.com/JabRef/jabref. It's nice because it can directly edit a .bib file in your project dir :wink:

@lukashass Thanks man! I will definitely check it out while working.


Is this abandonware?

It appears this has been abandoned. Can you officially abandon it and recommend a better project?

It seems that this project has been dead...

I'm working on a more modern version here: https://github.com/LinusU/secure-remote-password
There is no crypto expert who has vetted it yet though, I would really like for that to happen

I have just released Thinbus SRP on NPM at https://www.npmjs.com/package/thinbus-srp the code is on GitHub at https://github.com/simbo1905/thinbus-srp-npm
It is based on the mature Java+JS version over at https://bitbucket.org/simon_massey/thinbus-srp-js which has been used in at least large e-commerce site.


Enhancement/ie button vertical align

Seems like you need to change the base branch to experiment/postcss-simple-vars for this PR to make sense, right?


✨ feat(#402): add login required component with custom redirect

Proposed Changes

Add <LoginRequired />-component
Add helper function for creating Feide logins with custom redirects
Replace text on EventDetails.tsx with an interactive button

Question: Should we somehow escape whatever gets sent as state to Feide?
Types of Changes

[x] New feature
[ ] Bug fix
[x] Enhancement/optimization
[ ] Refactor
[ ] Style
[ ] Build/dependencies
[ ] Other

Issue(s) fixed or closed by this PR

Closes #402

Checklist

[ ] I have added tests to cover my changes (for features/bugs)
[x] I am pleased with the readability of the code (if not, state where you need input)
[x] I have tested the changes and verified that they work and do not break anything (to the best of my ability)

Looks good!
If my suggestion above is accepted, can we also replace the now legacy log-in code in frontend/src/pages/forms/[...formId].tsx?

Yep, that should be possible, great catch!


Should this be initLoginFlow instead?

https://github.com/jeroenheijmans/sample-angular-oauth2-oidc-with-auth-guards/blob/c73b0f2feaf608e312b6faa67203f340de80c2ed/src/app/core/auth.service.ts#L179

Yes, that seems to be correct. Will double check later and merge, thx for this!

Thanks @maxisam, worked like a charm!


fix chat loading

@keybase/react-hackers should fix chat loading
cc: @buoyad re: waiting changes

This is the PR to fix the loading bars?

yes


vdom symbols exported

It seems that some symbols are deprecated from the source comments. I needed to programatically set skip, but the skip symbol isn't in symbols.js
I assume that it should be along with the others.

I'm curious of your use case and also how you're setting skip programatically.
If you're importing anything other than files in dist/, or using any API outside of src/api/, that's currently unsupported API, just FYI. If you're exposing $skip in hopes to import it and use it in your code, there might be a better way to workaround the issue you're having.
How are you using it?

I have an alternate implementation of the h() which supports custom elements inside, triggering the rendererDebounced on it.
        const node = vdom.elementOpenEnd(tname);

        // Skate Custom Elements without children are skipped and made to render themselves
        if (node[$rendererDebounced] && chren.length === 0) {
            node[$skip] = true;
            if (node[$rendererDebounced]) node[$rendererDebounced](); // render when element is closed
        } else {
            chren.forEach((ch) => {
                const ctype = typeof ch;
                if (ctype === 'function') {
                  ch(vdom);
                } else if (ctype === 'string' || ctype === 'number') {
                  vdom.text(ch);
                } else if (Array.isArray(ch)) {
                  ch.forEach(sch => sch(vdom));
                }
            });
        }

        return vdom.elementClose(tname);

Sure, but what is your h implementation solving? I'd like to drill down your use case further to see if there's a better way to do what you want. Why do you need to manually trigger rendering?

I render to the normal DOM, it doesn't work with nested custom elements without this. Otherwise I need to put a skip attribute on the JSX where I use the custom elements. That works as well, but it seems like an implementation exposed in interface for this use-case.

I really don't want to export these symbols as public API especially since that part of it is changing in 5.0. It really feels like a custom iDOM renderer should be used instead. Either that or your suggestion on using the skip attribute seems fine. It's not an exposed implementation detail, it's part of the 4.x API.


Does not follow reroutes when buckets are in a different region

The script didnt work with a bucket I have in the eu-west-1 region and gave the error error: [Errno 104] Connection reset by peer adding  --host=s3-eu-west-1.amazonaws.com seemed to make it work again

https://github.com/twpayne/s3-parallel-put/issues/21 author doesn't understand this.

See https://github.com/twpayne/s3-parallel-put/pull/23 - tiny change to support buckets in other regions.

^ Updated

Fixed by @mikeatlas in #24. Please re-open if this does not work for you.


Texture size isn't correctly updated on sprite displayed in editor

Godot version:
3.0/3.1-dev
Issue description:
When you change image size and a scene with Sprite using this image is being displayed, Godot reimports the texture and refreshes the sprite, but doesn't update the size until you refresh view.
Steps to reproduce:

Create Sprite node
Assign any texture (even icon.png on empty project)

Edit texture and change size
Re-focus Godot to reload texture
The texture appears glitched

Everything is fixed when you refresh scene (e.g. change scene tab)

CC @groud

Confirmed this in Win10 64-bit alpha 3.1 aad70d5
Texture doesn't refresh itself until moved or sometimes the scene has to be closed and re-opened if you don't want to upset your positioning.

I can still reproduce this with an ImageTexture, calling create_from_image using an image of different resolution.
Project:
TextureRectNotResizingIfTextureRecreated.zip

That would be worth a different issue, even if the symptoms are similar the cause is likely different (the original bug is fixed).


Outdated cask: appserver

Outdated cask: appserver.
Info:

version: 1.1.0-100.
appcast url: https://github.com/appserver-io/appserver/releases.atom.

Closing in favour of #19038.


operator project-quay (3.12.0-nightly.20240710)

Add 3.12.0-nightly.20240710 to community operators

/merge possible

/merge possible


Restart in Rider Aspire Plugin is unstable

When using the Aspire Rider Plugin (v6.0.1 and all earlier versions), the "Restart" button is unstable.
Most of the time, it fails to properly restart services and the Aspire Dashboard hangs, and the services do not start (see video 1). Also, after Aspire Preview 5 with the introduction of the login token, the restart fails to send the login token in the URL (see video 2) when restarting (works fine the first time).
In practice, my team and I have just gotten used to clicking stop, waiting a few seconds before starting again. I'm not sure, but it might be that if one starts things before everything is properly shut down, it fails, but I've not been able to find a conclusive pattern.

Thanks for the report, I'll check it out. Out of curiosity, in what cases do you need to restart the Aspire host?

I tried to reproduce your problem, but everything works fine on my side. But I added a hot reload and also these actions to reboot certain projects. So I think this should help in your case.

My colleague has the same problem. So I don't think it's something on my machine. Maybe it's just a more complex solution.
Maybe try to clone https://github.com/platformplatform/PlatformPlatform and then open the PlatformPlatform.sln in the /application folder.
I will be happy to help testing your fix.

Hi @rafaelldi,
I’ve tried the new version 0.7.1 of the plugin, and the restart in the main toolbar still has the same problem, and this is what people will use by default when restarting.
I did find the “restart” in the Dashboard. It’s really awesome that you can restart a single service… something that the Aspire team has not found a way to solve (should be part of the Aspire Dashboard).
I do have some feedback on this new feature:

It should be possible to restart all types of Aspire services. It looks like you can only restart .NET projects. Especially, I very often need to restart my frontend React SPA (added to AppHost using builder.AddNpmApp()).

It’s very hidden. I do not use this dashboard and it takes too long to find if I just have to restart something. It would be great if this were integrated into the main toolbar.

Hi! Thank you for the feedback. I'll check the main restart button (maybe it's a linux/mac specific issue?).
Unfortunately, I can't restart all resources. In general, Aspire doesn't support restarting resources. I made a hack inside the plugin to restart projects. But other types of resources Aspire handles on its own, not through the IDE, so I can't do the same. If Aspire adds some API to restart a resource, I will definitely support it.
The run-windget on the main toolbar isn't very customizable, so I don't think I can do much here either. This Services tool window is the preferred way to manage multiple projects (such as Docker or k8s) used in the Intellij platform.
About your restart problem, could you please collect logs and attach them? Here I have an instruction how to do that.

This problem seems to exist only on macOS. But after updating to dotnet SDK 8.0.3, dotnet aspire to 8.0.1 and a new version of the plugin (not yet released), the problem is no longer reproduced on my machine with your solution. I think something was in the Aspire itself. Please check this out.

Hi @rafaelldi,
Just some feedback on this issue. It’s running much more stable now in version 1.2, but it still fails to restart "sometimes". It’s a bit hard to reliably reproduce things, as it’s only 1 out of 4 times when it fails.
But one thing I did notice for sure is that the SQL Server is not stopped properly before the restart. So, I get this error:
/opt/mssql/bin/sqlservr: Another instance of the application is already running.
This is my AppHost setup.

Perhaps Aspire doesn't clean up resources properly after stopping. The plugin doesn't work with any containers, only with .NET projects; containers are entirely the responsibility of Aspire itself.

I just wanted to add that Aspire does support dotnet watch run.

Just linking this issue in .NET Aspire 9, where this problem has now also started to occur in "raw .NET". I don't know if the fix that the Aspire team will (hopefully) implement will also resolve this issue. Investigation and, hopefully, a fix are part of Aspire 9.1, so let's check back then.

@tjementum Thanks for mentioning it, I'll check


fix: update exports

Change all default exports to named export (except in index.ts)

closing this in favor of an upcomming PR


Load more button

PR Summary
[comment]: Summarise the problem and how the pull request solves it
Fixes a bug where the "Load more" button under Ecosystem >> Browse all protocols >> All categories >> NFT breaks when clicked consecutively.

Checklist

[NO ] There are breaking changes
[ NO] I've added/changed/removed ENV variable(s)
[Not necessary ] I checked whether I should update the docs and did so by updating /docs

Description
[comment]: #This pull request addresses the issue by introducing a guard to prevent the application of the .trimRight() method to the displayedText variable if its value is falsy. The guard ensures that the method is only executed when displayedText is truthy, reducing the potential for errors or issues that might arise when attempting to apply .trimRight() to falsy values. Furthermore, this adjustment enhances the stability of the "Load more" button functionality, particularly when clicked in quick succession is the said area.
This pull request addresses the issues raised in #996
#Ignore the package.json
https://github.com/scroll-tech/frontends/assets/64384345/fe053e8b-3b20-4708-bb9a-c8f9c1cb9906

Thank you very much for pointing out this issue. We’ll use another method to solve it.


Release notes reloaded when switching between tabs

When reviewing the release notes of the latest version of VSC, if you scroll down to a section or click on a link to take you to a place in the release notes, then tap on a tab containing your source code and then switch back to the release notes, the release notes reload and you lose the position you were last at. Don't reload the release notes when switching between tabs.

Reproduced in both 1.10.2 and latest insiders.

This sounds like a duplicate of #15214


Improve CI/QA process

Also see PRs #55, #57, #61 and #62.
I'd like to suggest expanding the automated CI/QA checks done via Travis to prevent the above mentioned issues and/or get earlier warning about them.
Suggestions for things to add to the Travis build:

Linting the code against all supported PHP versions.
An automated scan of the code with PHPCompatibility
Security check of the Composer dependencies.
Validation of the Composer file.

Linting the code against all supported PHP versions.

This has been extensively discussed in #65. Summary: I don't think this is necessary.

An automated scan of the code with PHPCompatibility

Nice to have.

Security check of the Composer dependencies

As a development-only library, so nothing that should leave local environment, I don't think this is much relevant. It does not hurt though, even because it does not need any additional code, just requiring a no-code meta package, so why not.

Validation of the Composer file.

Not necessary. Dependencies are installed in CI, and Composer does itself a validation  of composer.json (exactly same validation that could be done via composer validate) before installing dependencies.
Running validation separately would mean to do a double validation when the file is valid (most of the times) and will only cause an error to be discovered just a few milliseconds earlier. No real benefit and unnecessary slow down of build time (tiny, but still).

With merged #66 this can be closed. Thanks again @jrfnl


Zoom on pinch not working on Windows

Describe the Bug
Zoom on pinch does not appear to work when using Windows and panOnScroll is set to true.
Can be demonstrated in the Reactflow Figma-like example on the doc site.
This works on Mac.
Your Example Website or App
https://codesandbox.io/p/sandbox/thirsty-darkness-qdwrp6
Steps to Reproduce the Bug or Issue

Use a Windows machine (or Browserstack, or Parallels, etc), I tested on Windows 11
Load any browser (I tried Chrome & Edge)
Go to the Reactflow Figma-like example: https://reactflow.dev/learn/concepts/the-viewport#figma-like-viewport-controls
Try pinch to zoom

Expected behavior
Expected: Viewport zooms in and out
Reality: Viewport scrolls
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Chrome, Edge
Version: latest (Chrome: v120)

Additional context
We've had multiple support requests for this on our product, and it appears to be the case for all Windows users.
Setting zoomOnPinch={true} does nothing (as it is already the default).

Hey @aleib, are you using a trackpad to pinch zoom?

Hey @aleib, are you using a kind of trackpad to pinch zoom?

Hey @moklick, I'm using the built in macbook touchpad to pinch zoom (and simulating the issue in Windows through Browserstack & Parallels).
The users that reported the issue are using Windows laptops and their built in touchpads as far as I know.

@moklick @aleib Wanted to add that TypeForm's implementation of Reactflow does work even on Windows! However. I can confirm that neither my app nor the example in the documentation works. Any idea what it could be?

Just checking in on this. We're getting a lot of bug reports from users and it's making our product pretty tough to use on Windows 😬

Hello,
I have exactly the same issue.
Have you identified the problem?
Thanks !

👀

We did some extensive investigation into this issue.
On macOS pinch zooming on a trackpad generates wheel events with ctrlKey=true. Looking at ctrlKey is the only way to distinguish between normal scrolling and pinch zooming. As a side note, this is not an officially agreed upon standard and was a way for Apple to make pinch zooming work on the web.
On Windows however, both actions emit wheel events and we can't find a way to differentiate them. To add to the confusion, on certain setups (Windows Desktop PC + pinch zooming on Wacom tablet) a wheel event is emitted with ctrlKey set to true. We can assume that certain trackpad drivers (just guessing here) generate macOS like wheel events for pinch zooming.
@tubarao312 I was able to reproduce the same faulty behaviour on Typeform, with the 'pinch to zoom in and out' setting. Zooming also leads to erratic panning there. Maybe you have a setup where the wheel events are correctly dispatched?
You can check the wheel event with this codesandbox.
If anyone has some information regarding this issue, your help is greatly appreciated.

Do you have Windows setups where pinch zooming leads to wheel events with ctrl=true? Does the React Flow Figma example work for you on that machine? (Make sure you focus the example first)
Are your users able to zoom with ctrl + scroll regardless?
Are there any known workarounds?

@peterkogo
Sorry I took so long to reply. Here you go:

The code sandbox example you gave me correctly identifies when I'm pinching and when I'm just scrolling up or down.
The React Flow Figma example works but I zoom in very very slowly. I'm not sure how related that might be to the issue. On my platform, it doesn't work at all.
My users can zoom with ctrl + scroll regardless. Most newbies don't know about that shortcut though and it's probably the most common complaint about our platform.

@tubarao312 What Windows version do you use (10, 11) and what kind of input device & browser are you using? (Maybe the laptop make & model might also be an indicator, just poking around in the dark here)

Windows 11
Touchpad on a brand new Lenovo Legion with the latest drivers
I use Chrome but it doesn't work in Edge either. I tried with Firefox and everything turned out the exact same.

Also I realized in my last comment I said the Figma zoom on pinch example worked. My bad, I used the wrong example, it actually doesn't zoom in it all with pinch.

Do you guys have any leads on this? I'd be happy to help investigate the issue and try to open a PR.

@tubarao312 We currently hit a roadblock with this issue. Any help is greatly appreciated!

@tubarao312 We currently hit a roadblock with this issue. Any help is greatly appreciated!

Do you know anything other than what you posted in the thread?

No this is pretty much it. If it runs on one device, it does not mean it runs on another. I found that it never works on macOS through Browserstack (Windows) for me.

I checked this issue again with Windows 11 (via Paralles Desktop on a Macbook). The figma example should pinch but it pans. So it's definitely still an issue.
In our zoom pane we have an isMacOs and event.ctrlKey check that handles pinch zoom if true. When I remove the isMacOs condition, it works with my Windows setup, but I am not sure if this is the case because I am using it with a Macbook touchpad 🤔 However it would be awesome if anyone (@tubarao312 maybe :)) with a real windows machine could check if this works. For this you need to pull the v11 branch and then remove the isMacOs check here: https://github.com/xyflow/xyflow/blob/v11/packages/core/src/container/ZoomPane/index.tsx#L134
Could anyone double check?

We finally got a windows machine 🙌 This is fixed in 11.11.3 and will be fixed in 12.0.0-next.17.

hey, @moklick,  pinch zoom works on windows, but it's really slow. Look like you need to remove isMacOs check in the wheelDelta function as well

@moklick, zoomOnPinch works very very slow on Windows machines.


Error when using Otel Exporter

using OpenTelemetry

global_meter_provider(MeterProvider());

m = Meter("demo_metrics");
c = Counter{UInt}("fruit_counter", m)
c(2; name = "apple", color = "green")

r = MetricReader(OtlpHttpMetricsExporter())

=======
ERROR: MethodError: no method matching export!(::OpenTelemetryExporterOtlpProtoHttp.OtlpHttpExporter{…}, ::Base.IdSet{…})
Closest candidates are:
  export!(::ConsoleExporter, ::Any)
   @ OpenTelemetrySDK ~/.julia/packages/OpenTelemetrySDK/xNwnQ/src/exporter.jl:73
  export!(::InMemoryExporter, ::Any)
   @ OpenTelemetrySDK ~/.julia/packages/OpenTelemetrySDK/xNwnQ/src/exporter.jl:53
  export!(::DummyExporter, ::Any)
   @ OpenTelemetrySDK ~/.julia/packages/OpenTelemetrySDK/xNwnQ/src/exporter.jl:27

Thanks for reporting!
Seems like this exporter hasn't been tested for a long time, I'll fix it soon.


Implement API call to permanently delete (a deactivated) user

Looks like the ability to make an Okta API call [1] to permanently delete a ('deactivated') user isn't currently implemented.
This PR is a change to make that possible.
[1] https://developer.okta.com/docs/api/resources/users#delete-user

@a-sansom Thanks Alex, I will review it soon.

Hi @dakkusingh what's the status of this? Would be nice to see this merged in with a new tagged release. Thanks!

@a-sansom @nathandentzau Thanks. There is a new tag.

Thank you @dakkusingh!


organization id containing 18 digits changing last 2 to 00

I have organisation id's that are 18 digits long (example:<PHONE_NUMBER>81575100)
the first 16 are ok but the last 2 have changed to 00.
I think the bigint is not supported so the integer is modified and therefor no loner working

It seems like numerical values are processed before the request happens. Does passing a string of the same org id work?

well I already get them resulted wrong when I just request the different organisations with the dashboard.organizations.list()

I checked the docs and it seems like the org number is returned as a number, which means that the API itself is truncating the org id before sending the response to you. You should file a bug report to Meraki about this since this library is just a wrapper to the API.

is there no solution in interpreting the numbers as big integers as the results come back?

I can look into adding bigint for handling org ids. I'm actually in the process of adding tests so I'll look into this matter a bit later. But if the API itself is returning a different org id, then I can't do much.

My bad! I didn't see that the first time. I'll add some tests to fix this regression so stay tuned! In the meantime, you could probably wrap the org id in a BigInt and converting that to a string.

Sorry for the somewhat late comment but I've tested it and not it is working perfectly.
thanks for the quick change and response


Using the Tree.selection attribute with a custom Node applies blue line styles to the row of the selected node.

If you define a custom node and want to render the tree with an initial node selected, using the Tree selection attribute styles the row of the selected node with blue lines on the top and bottom.

Here's a demo where the blue lines appear on the first render and then disappear when you select other nodes by clicking.
https://codesandbox.io/s/the-simplest-tree-forked-x91wir?file=/src/App.tsx

That it the browser's default styles for an element that has focus. If you want to change the focus styles for a selected node, you can can target it with this css selector:
[role=treeitem]:focus-visible {}
[role=treeitem]:focus {}

For the differences between focus and focus-visible, see this article: https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible

Ahh, gotcha. Was your thinking that if a page is loaded with a large tree with a node selected, it should receive special treatment with focus-visible?

The browser chooses when to apply the "focus-visible" styles, but the heuristic is generally: if you are using the keyboard and pressing tab, style it with :focus-visible, but if you're using a mouse don't apply focus-visible, only :focus.

Got it. Thanks for the explanation. And also for the good work on this component! I'm very happy with it so far. It seems to be unique in its flexibility among draggable tree widgets. Nice work!

Thank you!


Typescript definition and inferring types from schema

Hi,
love your library. If someday you would like to add a typescript definition, the main struggle will be to infer typescript types from the schema. I've put together a simple example of how it could work. This might not be the only possibility, but it works pretty well and should help you get started!
// The base type map, mapping typenames ('string', 'number', 'foo') to typescript types
interface SchemaTypeFieldTypeMap {
  string: string;
  number: number;
}

// Schema field properties
type SchemaTypeField = {
  type: keyof SchemaTypeFieldTypeMap;
  isRequired?: boolean;
}

// Schema type
interface SchemaType {
  [s: string]: SchemaTypeField;
}

// Schema type to instance type {name:{type:'string'}} => {name: string}
type SchemaTypeConverted<T extends SchemaType> = {
  [P in keyof T]: SchemaTypeFieldTypeMap[T[P]['type']];
};

// Validate function
function validate<S extends SchemaType>(
  schema: S,
  obj: SchemaTypeConverted<S>
) {
  // do something meaningfull
  schema;
  return obj;
}

let output = validate({ name: { type: 'string' }, age: {type: 'number'} }, { name: 'Max', age: 21 });
if (output.name === 'Max' && output.age === 21) {
  console.log('yea');
}

Oh dang, didn't notice you weren't using strings for typenames, but instead classes/primitives. This might make things easier.

Hi @bkniffler ! Thanks for this! This is perfect! I need this done, so this is a great place to start.
Sidenode: Actually the library does support using strings as types, but it is not in the documentation. :)


Compensate for when schedule is returned as an Array instead of a String

This addresses issue #69 for me.

:+1: makes sense.

Released in v2.1.11


git.autofetch on AC power only

Hi,
I use VSCode mostly to manage infrastructure-as-a-code repositories and I have many of them opened simultaneously in one workspace. The problem starts when I use my laptop on battery as git.autofetch feature starts multiple processes that take a lot of CPU and causes quicker battery drain.
I suggest adding some additional switch that disables that behavior, when laptop is on battery power.
Best regards
Łukasz Tomaszkiewicz

With the introduction of VS Code profiles you can easily create a new profile in which you disable git.autofetch.
You can then easily switch to this profile when disconnecting from AC power.


Always evaluate datawarehouse_alerts

Since hawkular alerts are evaluated in an external system, each alerts coming into the system already represents a created alert. When they come into the system we should always pick them up.

@miq-bot add_label, providers/containers, bug

@moolitayer there are Travis failures to fix.
@miq-bot assign moolitayer

Prefer to go for a different approach (with out introducing a new feature)
Closing in favor of:

https://github.com/ManageIQ/manageiq-ui-classic/pull/678
https://github.com/ManageIQ/manageiq/pull/14318


MM-11759

Summary

Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/11759
Related Pull Requests

Has server changes (please link here)
Has redux changes (please link here)
Has mobile changes (please link here)

Screenshots

Thanks @NiroshaV for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Please review

/check-cla

DrawPluginWorkingUsecase.mp4.zip

@srkgupta Thanks for the review comments .
I will check on those and Revert back with the changes

@saturninoabril @srkgupta  , Working on API request to upload form data . Once this is done, Will use API to enable plugin

@srkgupta @saturninoabril   - > Configurations are done using API . Updated changes . Please review

/update-branch

Thanks @NiroshaV, looking at it now.


onelogin demo client with keycloak

I'm trying to set up the onelogin demo app as SP with a keycloak server as IdP. It's working so far that I'm getting redirected to my keycloak login page. The login works and keycloak creats a session but in the demo app it says "Not authenticated" and "invalid_response". Anyone here tried this with keycloak or can tell me why the app can't handle the response from keycloak?

When the debug is enabled on the settings of java-saml, the reason for the SAMLResponse to be invalidated is prompted.
Enable the debug at the settings

Thank you. That helped me. I fixed my problem now!


How to search a partial uuid?

My transactions table uses a uuid which is stored as bytes in the database.
I would like to know how to search for a partial uuid? Obviously, since we are using bytes, the data is stored as a binary in the table so in theory I need to convert the partial uuid string to a binary and then to search on that.
Is there anyway to do this natively with UUID?
If I had a full UUID, I am simply going to use something like so:
$qb->andWhere('transactions.uuid = :uuid')->setParameter('uuid', Uuid::fromString($options['transactionUuid'])->getBytes());
But to search a partial uuid, I am looking to do something as follows:
$qb->expr()->like('transaction.uuid', Uuid:fromString(':search')->getBytes()),
But obviously the fromString requires a correctly formed uuid string as apposed to a partial.
I am not sure this is possible and perhaps is one of the downfalls of using bytes in the table as apposed to string.

Hi @chateaux ,
you could use lower() and hex() to convert the transaction.uuid into something searchable.
$qb->andWhere('LOWER(HEX(transactions.uuid)) LIKE :uuid')->setParameter('uuid', '%f68f66cd%');

It is not a solution withing this library but it should work. Although I have not tested the above line.
Best
Sebastian


Cannot read property 'apply' of undefined

The addon looks exactly like what I need. But I am getting after starting the server:
TypeError: Cannot read property 'apply' of undefined
    at Class.module.exports.treeForApp (/data/node_modules/smoke-and-mirrors/index.js:86:38)
    at Class._treeFor (/data/node_modules/ember-cli/lib/models/addon.js:319:31)
    at Class.treeFor (/data/node_modules/ember-cli/lib/models/addon.js:289:19)
    at /data/node_modules/ember-cli/lib/broccoli/ember-app.js:371:20
    at Array.map (native)
    at EmberApp.addonTreesFor (/data/node_modules/ember-cli/lib/broccoli/ember-app.js:369:30)
    at EmberApp._processedAppTree (/data/node_modules/ember-cli/lib/broccoli/ember-app.js:631:25)
    at EmberApp.appAndDependencies (/data/node_modules/ember-cli/lib/broccoli/ember-app.js:916:10)
    at EmberApp.javascript (/data/node_modules/ember-cli/lib/broccoli/ember-app.js:1031:34)
    at EmberApp.toArray (/data/node_modules/ember-cli/lib/broccoli/ember-app.js:1389:10)

I am running Ember 2.12.0.

This addon is currently being split out into a set of smaller individual addons on the html-next org. The vertical-collection component is at 1.0.0-beta.1 right now: https://github.com/html-next/vertical-collection
Maintenance on this repo is on the backburner for now, we'll be revisiting it once the individual components are done (this repo will just pull the components back in). PRs are welcome, but we aren't sure when we'll have time to review.

Me too. I got that error.How to solve?Pls help me.

@bloodknight2010 check out the alternate repo I posted above, vertical-collection is now in Beta 2 and getting much more stable.

Should be fixed by updating to @html-next/vertical-collection (now re-exported by this lib)


shits broken

https://cdn.discordapp.com/attachments/744554460830760992/759837604802723940/unknown.png

Yeah, we are aware of that and are investigating. Somehow, some rogue item IDs have been entering players banks. I am testing everything I can to figure that out.

Use the issue template, and a proper title. I won't ask again.


[M03] Constraining slashing penalties

Description
Constrained the max penalty when calling performSlashing to be <= an account's maximum locked gold requirement.
Set in SlasherUtil so it only affects slashing via downtime and double signing, not governance so that this will be backwards compatible with a future change allowing slashing of pending withdrawals.
Tested
Added appropriate tests to double_sign and downtime tests.
Other changes
N/A
Related issues

https://github.com/celo-org/celo-labs/issues/266

Backwards compatibility
Yes

I'm not sure this actually fixes the "problem" (which I do not believe to be a problem in the first place).
The raised concern was that validators can avoid slashing by front-running the call to slashing by withdrawing locked gold, causing the slashing transaction to fail. I don't think this addresses that, the slashing transaction would just fail earlier.
However, I don't think this is a real issue, as the penalties should always be less than the minimum locked gold needed to run a validator, so validators would not be able to withdraw enough gold to avoid slashing unless they had already been not validating for >= 60 days (or whatever the current requirement duration is), which should be considered the statute of limitations on slashing.

Agree about not actually "solving" the problem - as we discussed last week, this PR only seeks to remove the possibility of setting a slashing penalty greater than the locked gold requirement for a validator. This is only a "sanity check" of sorts.
If you don't think we need to add this to move the issue's severity lower then I can close this PR.

Closing for now as it turns out we've already mostly implemented what we intended to here


Example errors out with "Cannot read property 'connect' of undefined"

I updated config.json, then I ran:
npm run examples

Then tried to serve examples/htdocs via static http.
bundle.js:106 Uncaught TypeError: Cannot read property 'connect' of undefined
    at bundle.js:106
    at bundle.js:10
    at bundle.js:13

I have the same issue ,do you handle this problem?

Either react-redux is not installed or the code referencing connect did not import { connect } from 'react-redux'

examples moved to react-cognito-example


Automated Package Upgrade

:tada: This PR is included in version 2.0.39 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Single form for create and update - create opens all inputs and update is one by one

I want to create a single form for create and update. When the form opens in create mode I want to show all the inputs editable (like the way when we click on edit). Similarly if I open the form for update (backed by exiting data) I want each input to be individually editable on click. In both cases the Save will update model and call backend API. Is this supported?
Do you have a forum where the authors look into and attend to questions? I did't see reference on the page.
Thank you

I don't think this is supported.  Maybe you can do something with an ng-if to setup an editable-form for create and then create individual editable elements for edit.

@amodpandey did you ever figure out a solution to your problem?

I did something similar but not exactly the same. Created a save button that works for create and update. I was happy to keep the create mode with editable links rather than form mode (but I could achieve this as well).
My solution won't work when we disable accessing scope from dom element (done in production)
function validateFormSubmit() {
  var status = true;
  var editables = document.querySelectorAll('[onbeforesave]')
  for (var i = editables.length - 1; i >= 0; i--)
  {
    var scope = angular.element(editables[i]).scope();
    if(scope.$editable.onbeforesave() !== true) {
      scope.$form.$show();
      scope.$form.$submit();
      status = false;
    }
  }
  return status;
}

With above I could achieve

Define validation for individual form element and use them with Submit
Have form save functionality with 'click to edit' ui behavior.

sure.

@eugef can you close this issue?


Create easy-to-understand and reliable instructions for installing the project on the developers mac or Windows computer

User Story: As a web developer, I want to automate the testing of my website's user interface and functionality, so that I can save time and ensure that my website is bug-free and functioning correctly.
Description: Automated test results identified issues and bugs which are fixed to make website more effective

Maybe this could include, or be, modification of the README to help with on-boarding to the project.


First item is inaccurate

Every single issue we've encountered where a user cannot log on to Teams has been when they are already logged into O365 and are able to successfully launch every other app.  Teams is absolutely doing something ELSE not shared with the rest of the O365 suite and we desperately need accurate documentation indicating what that is.  We've had several users that simply cannot log into Teams via web or app on a particular device and nothing we've been able to do has fixed it (browser cache, windows credential manager, teams app cache/reinstall, new windows user profile).  Our only success thus far has simply been getting the user onto another physical device.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf54bf5d-1748-46bf-a503-5e978f56126c
Version Independent ID: 5976a1df-52e9-eb19-fd41-c7b04fce74f8
Content: Sign in to Teams using modern authentication - Microsoft Teams
Content Source: Teams/sign-in-teams.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@jvolp Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @jvolp
How are you? Hope you are doing good.
First of all, thanks for your feedback.
I do not know exactly what is happening in your scenario, to be able to fix or add information to the documentation, is this related to Modern Auth?, for example.
Did you already checked this resource ? https://docs.microsoft.com/en-us/MicrosoftTeams/troubleshoot/teams
In case you do not find the answer on that resource, I think in this case, the best thing to do would be contact support directly in your tenant, as they will be able to help you in your exact scenario.
Hope I could help you.

Thanks for your follow-up.  What we have discovered via trial and error is that Teams logins will not work if the users Time Zone is incorrect on their device.  This is a simple fox, but it's not documented anywhere and our Azure portal reports the logins as "successful" even though they are not.  Again, this is not something we should need to discover on our own. The documentation regarding Teams authentication is inaccurate and states it is the same as all other O365 apps.  It is not.  This needs to be documented, especially with MS support staff.

Thanks for your follow-up.  What we have discovered via trial and error is that Teams logins will not work if the users Time Zone is incorrect on their device.  This is a simple fox, but it's not documented anywhere and our Azure portal reports the logins as "successful" even though they are not.  Again, this is not something we should need to discover on our own. The documentation regarding Teams authentication is inaccurate and states it is the same as all other O365 apps.  It is not.  This needs to be documented, especially with MS support staff.

Thanks for getting back and sharing that valuable feedback.
I will try to pass that message along as Teams Troubleshooting information is located on another repository where I am not currently a collaborator.
In case anyone else faces the same issue as you, they will be able to find your feedback here.
Thank you again

@jvolp  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Links for Invoice working

Invoice example
https://github.com/pondersource/peppol-php/blob/main/rules/examples/base-example.xml

Codelist
https://github.com/pondersource/peppol-php/blob/main/structure/codelist/ICD.xml
https://github.com/pondersource/peppol-php/blob/main/structure/codelist/eas.xml

Invoice response XSLT file
https://github.com/pondersource/peppol-php/blob/main/rules/examples/invoice-response.xslt


Missing git not detected message in certain scenarios on Windows

Setup:

Had git installed (ticking the option in the git installer to not add git to the default windows command prompt)
Installed elm 0.16 using windows installer
Made hello.elm file containing:

    import Html exposing (span, text)
    import Html.Attributes exposing (class)

    main =
        span [class "welcome-message"] [text "Hello, World!"]

Opened default windows command prompt at file location
executed 'elm-make hello.elm'
accepted the core language install prompt
executed 'elm-package install evancz/elm-html'
Nothing happens, no messages, no regaining control over prompt, it's just stuck
executing 'elm-package --version' DOES show there is no installation of git detected and requests me to download it

How I fixed it:

Downloaded git again
Ticked the options to use the default windows shell for git
Retried 'elm-package install evancz/elm-html'
Problem was gone

Git is no longer required in 0.17.1, so this should be resolved. Thanks for the report!


Wait for Interrupted of CompletableTask.cancel

Hi,
is there a way to wait for the CompletableTask (the Promise) to be Interrupted?
For example:
Promise<Void> task = CompletableTask.runAsync(() -> {
	try{
		//...
	} catch (InterruptedException e) {
		Thread.currentThread().interrupt();
		throw new CompletionException(e);
	}
}, EXECUTOR);
task.cancel(true);
//wait for interruption

immediately after task.cancel() (eiter trueor false) task.isDone() will be true and task.join() will throw CancellationException
how can I wait for the Runnable to actually finish or interrupt?
If i call task.cancel(true); I'd like to wait untill the Runnable get interrupted (and throws new CompletionException(e); in the example).
If i call task.cancel(false); I'd like to wait for the runnable to finish if already running (or get CancellationException if not started yet)
It might be also usefull to be able to get the result or the exception after it finish or interrupt.
The ratio behind this is that if i schedule several IO bound tasks (in a FixedThreadPool), at some point i might want to cancel them, but wait for the running ones to finish or gracefully interrupt.

It's not related to the library, but you may do smth. like this:
        CountDownLatch doneInAnyWay = new CountDownLatch(1);
        Promise<Void> task = CompletableTask.runAsync(() -> {
            try{
                //...
            } catch (InterruptedException e) {
                Thread.currentThread().interrupt();
                throw new CompletionException(e);
            } finally {
                doneInAnyWay.countDown();
            }
        }, EXECUTOR);
        task.cancel(true);
        //wait for interruption OR normal OR exceptional completion
        doneInAnyWay.await();

Thank you,
I've created this implementation i'd like to share:
I've not managed to create a InterruptableTaks, but only an InterruptableFuture that will suffice for my project
import java.util.concurrent.Callable;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Executor;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import java.util.function.Supplier;

import net.tascalate.concurrent.CompletableTask;
import net.tascalate.concurrent.Promise;

public class InterruptableFuture<T> extends CompletableFuture<T> {

	public static InterruptableFuture<Void> runAsync(Runnable runnable, Executor executor) {
		return submit(() -> {
			runnable.run();
			return null;
		}, executor);
	}

	public static <U> InterruptableFuture<U> submit(Callable<U> callable, Executor executor) {
		return new InterruptableFuture<>(callable, executor);
	}

	public static <U> InterruptableFuture<U> supplyAsync(Supplier<U> supplier, Executor executor) {
		return new InterruptableFuture<>(supplier::get, executor);
	}

	private final Promise<Void> task;
	private final Lock cancelLock = new ReentrantLock();

	protected InterruptableFuture(Callable<T> callable, Executor executor) {
		task = CompletableTask.runAsync(() -> {
			if (cancelLock.tryLock()) {
				try {
					complete(callable.call());
				} catch (Exception e) {
					completeExceptionally(e);
				}
			}
			//if tyLock fail cancel has been already called
		}, executor);
	}

	@Override
	public boolean cancel(boolean mayInterruptIfRunning) {
		boolean cancelled = task.cancel(mayInterruptIfRunning);
		if (cancelled && cancelLock.tryLock()) {
			// task not started yet
			super.cancel(false);
		}
		return cancelled;
	}
}

AtomicBoolean.compareAndSet will be a better choice than ReentantLock, IMHO.

 I've updated the code 👍


Can istio be used for RequestAuthentication for web sockets?

Describe the feature request
I am using istio for request authentication.
The problem is, my server also supports web socket connections as graphql subscriptions (via apollo)
This is the general flow at the network level.

an HTTP GET request is made to /graphql requesting an upgrade to use websockets. This request does not include any auth.
If the request is upgraded to websockets, an inital websocket message is sent from the client with the data including the auth details that looks like:

{
  type: 'connection_init',
  payload: {
     'Access-Token': '...'
  }
}

After the initial connection message is sent, a follow up message is then sent from the client with the subscription details in the message data:

{
  id: '...',
  type: 'subscribe',
  payload: {
    query: '<graphql-query>'
  }
}

messages are now sent back to the client

I think to make istio able to authorize this, we would need a way to specify something like fromSocketMessage and then we would need a way to drill into the message to access the property (similar to fromHeaders) like so:
jwtRules:
  - issuer: "my_issuer"
    jwksUri: "http://some-url/jwks.json"
    fromSocketMessage:
    - path: "payload.Access-Token"
    outputClaimToSocketMessage:
    - path: "payload.X-User-ID"
      claim: "data.user_id"

This would change the payload from:
{
  type: 'connection_init',
  payload: {
     'Access-Token': '...'
  }
}

to:
{
  type: 'connection_init',
  payload: {
     'X-User-ID': '...'
  }
}

Then maybe the AuthorizationPolicy could have support for something like this:
to:
    - operation:
        protocol: "ws"
        socketMessageData:
        - path: "payload.type"
        - value: "connection_init"

Meaning when a websocket message is sent, and the data contains the key payload.type and the value is "connection_init"
I am trying to do this in an agnostic way that could work with any type of web sockets, to authenticate based on the socket payload.
Affected product area (please put an X in all that apply)
[ X] Security

istio may not be able to intercept web-socket traffic easily. Wonder if it would be reasonable to have the client connected to istio and istio also connected to the main container as a middle man. That way istio receives the web-socket messages, can process them, then forward them to the main service on the second socket.

I don't think its like that Istio core is going to add support for parsing custom protocols (there is two layers here, understanding WS itself, and then understanding the graphql-ws protocol within it) out of the box. What is more likely is a custom extension that has this direct understanding.. things like https://github.com/aeraki-mesh/ are a good example of what has been done in this space


html attributes raises error when followed by some functions: Unexpected end of input in a macro argument

The following error is received when calling certain functions, e.g. \frac, immediately after a html attribute:
KaTeX parse error: Unexpected end of input in a macro argument, expected '}' at position....
Error occurs with:
\htmlId{id}\frac{a}{b}
but not with:
\htmlId{id}\sigma

This error does not occur when using KaTeX version 0.12.

@summersz This is a consequence of a change in how macro arguments get parsed; see #2490 (linked from the changelog). You now need to wrap the second argument, like so:
\htmlId{id}{\frac{a}{b}}

This change was made to better match how TeX actually parses arguments. I just confirmed that e.g. \textcolor{red}\frac{a}{b} does not work in LaTeX, even though \sqrt\frac{a}{b} does.


GitHub returned 404 when updating through HACS

Hello,
following error occurred while updating the DreamScreen Service:
An error ocoured while processing
GitHub returned 404 for https://api.github.com/repos/GregoryDosh/Home-Assistant-DreamScreen-Service/contents//manifest.json

Reinstallation is no longer possible via HACS due to the missing manifest.json
HACS | 0.21.6
System | HassOS 3.11
HomeAssistant  |  0.106.3

Could you try uninstalling the current dream screen component and restart HA and then install it again?
After these steps I'm able to use the reinstall.
I guess its because of moved manifest files in  commit https://github.com/GregoryDosh/Home-Assistant-DreamScreen-Service/commit/4c672c3c8e22ee246cc7e74190895b785754275c

Pinned, because this will probably happen to to all HACS Users. I'm sorry, but we now use the correct HACS folder structure, as HACS recommends

Thanks a uninstall, reboot and new install helped.
Work like a charm.


Add myself as maintainer to help

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Adding myself as maintainer as advice to help updating this package on conda

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge/core As adviced on gitter, I added myself as maintainer to help updating this package.


Allow the searching of child collections

Investigate the possibility of have SearchExtensions return a parent item if a match is found in a child collection.
A possible example might be:

Given I have a collection of Shops,
I want to return all shops that stock a product with a Name containing "football".

Additionally, support for non strings should be considered:

Given I have a collection of Shops,
I want to return all shops that stock a product with a Price greater than 10.

@bzbetty - does this adequately fulfill what you were lookng for?

That sounds perfect.

Hi @bzbetty,
I have just released an update to SearchExtensions which partly addresses this issue.  With version 1.7 you can now search child collections.  The reason this is only partly complete is because it is currently only enabled for IEnumerable collections meaning that the filtering is done in memory. IQueryable is still to come.
I have created a blog post explaining how to use the new feature, but in short, with the examples above in mind, you can now do something like the following:
var result = _shops.SearchChildren(s => s.Products)
                   .With(p => p.Name)
                   .Containing("football");

OR
var result = _shops.SearchChildren(s => s.Products)
                   .With(p => p.Price)
                   .GreaterThan(10);

I'll be working on supporting IQueryable next so that hopefully the server can do the work instead of doing the filtering in memory.

Awesome! Will try it out as soon as I get the chance.
On 22 Oct 2015 10:12, "John Nye"<EMAIL_ADDRESS>wrote:

Hi @bzbetty https://github.com/bzbetty,
I have just released an update to SearchExtensions which partly addresses
this issue. With version 1.7 you can now search child collections. The
reason this is only partly complete is because it is currently only enabled
for IEnumerable collections meaning that the filtering is done in memory.
IQueryable is still to come.
I have created a blog post explaining how to use the new feature
http://jnye.co/Posts/2045/search-extensions-search-within-child-collections-now-supported-in-v1-7,
but in short, with the examples above in mind, you can now do something
like the following:
var result = _shops.SearchChildren(s => s.Products)
.With(p => p.Name)
.Containing("football");
OR
var result = _shops.SearchChildren(s => s.Products)
.With(p => p.Price)
.GreaterThan(10);
I'll be working on supporting IQueryable next so that hopefully the
server can do the work instead of doing the filtering in memory.
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-150025733
.

Big news!  I have just made a second release which now supports searching on IQueryable.  This means that the filtering is all pushed down to the server meaning you only retrieve the matching records.
Blog post to follow

you are too awesome!
On Thu, Nov 5, 2015 at 1:21 PM, John Nye<EMAIL_ADDRESS>wrote:

Big news! I have just made a second release which now supports searching
on IQueryable. This means that the filtering is all pushed down to the
server meaning you only retrieve the matching records.
Blog post to follow
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-153913511
.

Is it possible to use a Search and a SearchChildren at the same time?  It
looks like chaining them in C# will perform a AND query instead of an OR
query?
eg
SELECT [Extent1].[Id] AS [Id]
-- Additional columns --
FROM [dbo].[Shops] AS [Extent1]
WHERE
[Extent1].Name like '%ball%'
or
EXISTS (
SELECT 1 AS [C1]
FROM [dbo].[Products] AS [Extent2]
WHERE ([Extent1].[Id] = [Extent2].[Shop_Id])
AND ([Extent2].[Name] LIKE N'%ball%')
)
On Thu, Nov 5, 2015 at 1:22 PM, Sam McKoy<EMAIL_ADDRESS>wrote:

you are too awesome!
On Thu, Nov 5, 2015 at 1:21 PM, John Nye<EMAIL_ADDRESS>wrote:

Big news! I have just made a second release which now supports searching
on IQueryable. This means that the filtering is all pushed down to the
server meaning you only retrieve the matching records.
Blog post to follow
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-153913511
.

Can you post the code you are using to try this? I think it should be possible with the current code base

Context.Invoices
.Search(invoice => invoice.Description).ContainingAll(searchTerms)
.SearchChildren(invoice => invoice.Client).With(client =>
client.Name).ContainingAll(searchTerms)
also tried
Context.Invoices
.Search(invoice => invoice.Description)
.SearchChildren(invoice => invoice.Client).With(client =>
client.Name).ContainingAll(searchTerms)
On Fri, Dec 18, 2015 at 8:45 PM, John Nye<EMAIL_ADDRESS>wrote:

Can you post the code you are using to try this? I think it should be
possible with the current code base
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-165704996
.

Hmmm, I would have thought the first option would have done the trick. I'll be on the train to work in a bit so will investigate. I'm pretty sure it should be possible though

it works but it requires both the invoice description and client name to
contain all the search terms, I was wanting to be able to do one or the
other.  Unfortunately i suspect that would require large changes.
On Fri, Dec 18, 2015 at 9:10 PM, John Nye<EMAIL_ADDRESS>wrote:

Hmmm, I would have thought the first option would have done the trick.
I'll be on the train to work in a bit so will investigate. I'm pretty sure
it should be possible though
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-165710540
.

Ah, I see, apologies.  Funnily enough, I have just replied to issue #6 asking for precisely the same thing.
As a workaround, you could potentially run them as 2 separate queries (which I know is not ideal).  What this does mean is that you only have to perform the second query if the first doesn't return any results.  Something like:
var description = Context.Invoices.Search(invoice => invoice.Description)
                                  .ContainingAll(searchTerms);

var client = Context.Invoices.SearchChildren(invoice => invoice.Client)

.With(client =>
client.Name).ContainingAll(searchTerms)

it's not actually a big deal in my case as normally the user knows which
field contains the data anyway so I've put 2 buttons in the UI.   2
searches + a union of some kind would work fairly well too.  Cheers for the
help.
On Fri, Dec 18, 2015 at 10:07 PM, John Nye<EMAIL_ADDRESS>wrote:

Ah, I see, apologies. Funnily enough, I have just replied to issue #6
https://github.com/ninjanye/SearchExtensions/issues/6 asking for
precisely the same thing.
As a workaround, you could potentially run them as 2 separate queries
(which I know is not ideal). What this does mean is that you only have to
perform the second query if the first doesn't return any results. Something
like:
var description = Context.Invoices.Search(invoice => invoice.Description)
.ContainingAll(searchTerms);
var client = Context.Invoices.SearchChildren(invoice => invoice.Client)
.With(client =>
client.Name).ContainingAll(searchTerms)
—
Reply to this email directly or view it on GitHub
https://github.com/ninjanye/SearchExtensions/issues/4#issuecomment-165718869
.

No probs, I will look at how we can maybe have an indicator in the searches to allow for an OR search across search types as it would clearly be useful since you and @sunflowerlab have both mentioned it.


multi-line errors a la lsp_lines.nvim

Does anyone know if this is possible in vscode? If so, it might make sense to build this as opt-in into error lens.
https://git.sr.ht/~whynothugo/lsp_lines.nvim

Awesome idea. I am waiting too.

Just to clarify: is this about "show multiple errors in the same line" or "better show mutli-line errors"? The later would be a duplicate of #47, no?


JSONModel loadData() with POST puts oParameters into Payload as urlencoded

OpenUI5 version:
V1.108
Browser/version (+device/version):
Chrome Version 122.0.6261.70
URL (minimal example if possible):
https://plnkr.co/edit/hahwVSW7pwqYlZ8K
Steps to reproduce the problem:

call JSONModel.loadData() with oParameters and method = POST
check the request sent using the Browser Developer Tools
observe that with POST, the oParameters are put into the JSON payload, but as url-encoded string instead of JSON

What is the expected result?
I would have expected that either
a) the oParameters always are attached to the target URL (as the official documentation indicates)
b) the oParameters are attached to the payload as JSON (and not as url-encoded String)
So from my perspective there are three possible solutions:

Update the documentation to indicate that when using POST, the oParameters will be put into the payload as urlencoded
Put the oParameters into the URL when using POST reqests too (however I think this is handled by Ajax, so not in our control)
When using POST, convert the oParameters into a JSON encoded string before passing them on to Ajax:
oParameters = JSON.stringify(oParameters)
This will prevent Ajax from converting it to url-encoding.

What happens instead?
The parameters passed with oParameters are put into the payload, but as url-encoded String.
Any other information? (attach screenshot if possible)
This is the Payload Section ("Nutzlast") in the Developer Tools when sending a POST request:

Hello @BenjyTec ,
Thank you for sharing this finding. I've created an internal incident DINC0085751 for follow-up. The status of the issue will be updated here in GitHub.
Regards,
Iliana

Hi @BenjyTec ,
the JSONModel.loadData function triggers the request via jQuery.ajax with the following settings object:
oParameters
{url: 'https://www.google.com/', async: true, dataType: 'json', cache: true, data: {…}, …}
async: true
cache: true
data: {username: 'MyUsername', password: 'MyPassword'}
dataType: "json"
error: ƒ ()
headers: {content-type: 'application/json'}
success: ƒ ()
type: "POST"
url: "https://www.google.com/"
[[Prototype]]: Object
According to the jQuery documentation https://api.jquery.com/jQuery.ajax/#jQuery-ajax-settings the data property is: "Data to be sent to the server. If the HTTP method is one that cannot have an entity body, such as GET, the data is appended to the URL."
So in your case the HTTP method is POST which can have an entity body and therefore the content of the data property does not get appended to the URL. jQuery.ajax also does not convert an object to JSON before putting it in the body but to a string that is not URL encoded.
We will update the documentation on the JSONModel.
Greetings,
Peter.

Hey Peter, thanks for the clarification!
You are correct, it is in actually not url-encoding that is happening. What I meant was that a JSON object passed in is converted to the notation param1=value1&param2=value2 instead of just being a normal JSON when put into the payload.
Updating the Documentation is a fine solution to me, Thanks again!

Hi @BenjyTec
"What I meant was that a JSON object passed in is converted to the notation param1=value1&param2=value2 instead of just being a normal JSON when put into the payload."
Well it looks like jQuery.ajax does not support this. We cannot simply add this "behavior" now as it would fundamentally change the behavior of JSONModel.loadData for all users.
Greetings,
Peter.

Documentation updated with SAPUI5 Version 1.122


Publish skrooge to pypi

Make it as simple as pip install skrooge
https://develop.sentry.dev/sdk/craft-quick-start/
### Tasks
- [x] Tag beginning of repository
- [x] Produce artifact
- [x] Set up craft
- [x] Create scripts/bump-version.sh
- [x] Create release workflow
- [x] Set up permissions
- [ ] Create first release!

Blocked by https://github.com/getsentry/publish/issues/3316


[BUG] Token unable to open door unless directly in front of it

Module Version: v2.1.18
Trying to configure the module to allow the token on diagonal to door to be able to open the door.  I can't find the setting to make this happen.  Increasing distance configuration settings well over 10 (feet) have no effect.
I believe this token is within 5' of the door, so expected it could open the door.  Increasing interaction distances to 7.5' should definitely accommodate the angle and allow interaction.

Browser:
Edge
Foundry Version:
9.245
Game System:
DND5e

Try out 2.1.20 add some more check... not sure about the result.

Seems to be solved. Thanks for quick fix!  These are the settings that work:  Global Max: 10'  Max Door: 7.5'.  The door is out of reach if Max Door is set to 5'.  With 7.5', the door is out of reach of any cells that aren't bordering the door.
Question:  does Global Max have to equal or exceed Max Door for Max Door to be respected?  i.e., if I leave Global max at 5', does that mean Max Door is capped at 5', even though I've set it to 7.5' ??

Update the labels on 2.1.22 , The "Max Door": Is the distance calculation used only for the 'Interaction door with the hotkey 'e'' module setting and is completely indipendent from the similar module setting 'Global maximum interaction distance measurement'.


IOU - In WS, request scan created with corrupted pdf able to view file.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.45
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4331496
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap on workspace chat
Tap plus icon near compose
Tap request money ---- Scan
Upload a corrupt file
Enter all details
Tap request
Tap on newly created expense
Enter all details
Tap on receipt

Expected Result:
In WS, request scan created with corrupted pdf must not be able to view file
Actual Result:
In WS, request scan created with corrupted pdf able to view file
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/615b00e1-ed45-4b77-9f68-7d6ed47217e1
View all open jobs on GitHub

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

@twisterdotcom  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

must not be able to view file

Why is this the expected behaviour? Why would we not show a corrupted file? I think this is fine, it's pretty obvious the file is corrupted.


Remove unwanted tables in the history verbose mode for XEMM and Arb strategies

Describe the bug
Unable to display all tables when running history --verbose for Arbitrage strategies and cross-exchange market-making strategy due to having multiple tables (13 tables).
Steps To Reproduce
Here are the steps to reproduce the issue (see attachments in the section below):

Create any of the following strategies: Arbitrage strategies and cross-exchange market-making strategy
Start the strategy and wait for an order fill.
Run history --verbose
...

Screenshots

Expected behavior:

Release version
Hummingbot 1.0
Attachments
WARNING: Do NOT publish any exchange API keys or your wallet's private key. Whoever has access to them may steal your assets!
Optional: your discord username:

Fixed on Hummingbot version 1.0.0