Fix GHCJS 7.10

Motivation for this change
Fixes the old version of GHCJS
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

/cc @dmjio

@GrahamcOfBorg build haskellPackages.ghcjs

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: haskellPackages.ghcjs
Partial log (click to expand)
Cannot nix-instantiate `haskellPackages.ghcjs' because:
error: attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: haskellPackages.ghcjs
Partial log (click to expand)
Cannot nix-instantiate `haskellPackages.ghcjs' because:
error: attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.ghcjs
Partial log (click to expand)
Cannot nix-instantiate `haskellPackages.ghcjs' because:
error: attribute 'ghcjs' in selection path 'haskellPackages.ghcjs' not found

@GrahamcOfBorg build haskell.compiler.ghcjs

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Failure on x86_64-darwin (full log)
Attempted: haskell.compiler.ghcjs
Partial log (click to expand)
/nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1/lib/ghc-7.10.3/package.conf.d/kan-extensions-5.1.conf
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1/lib
patching script interpreter paths in /nix/store/ffmg42gvar5iq0mkwh9dig29agbzlfzc-kan-extensions-5.1
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/llxldrfsddl3cwvzvj7s4if9brj2svwi-kan-extensions-5.1-doc
cannot build derivation '/nix/store/0546hkk3450yn4h07xdv5k8ixlzi5fyc-lens-4.16.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j3ddmwybr3hdykq7mjp5d98kvv1rlzqz-ghcjs-0.2.0.drv': 9 dependencies couldn't be built
error: build of '/nix/store/j3ddmwybr3hdykq7mjp5d98kvv1rlzqz-ghcjs-0.2.0.drv' failed

Success on x86_64-linux (full log)
Attempted: haskell.compiler.ghcjs
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/k1by43k0il5a4nj2b51qjmszw0zg9s07-ghcjs-0.2.0


feat(fscommerce): product promotions

Description

implemented the request to get details for product promotions

Test
Test together with PR:
https://github.com/brandingbrand/submarine/pull/314

@bweissbart / @Cauldrath
This PR along with https://github.com/brandingbrand/submarine/pull/314
is pretty high priority.
Client goes into final UAT on monday Jan25 so we need to try and get this in before then

@bweissbart / @Cauldrath
This PR along with https://github.com/brandingbrand/submarine/pull/314
is pretty high priority.
Client goes into final UAT on monday Jan25 so we need to try and get this in before then


status bug when start a parent coroutine when should yield child

If there are coroutine A and B.
Run ROOT->A.start()->B.start()->A.start()
Yes, it should be B.yield() when we want to switch back to A.But A.start will success and some data will have problem.(caller and other datas)

fixed


languages: Pages seem to use the projectConfig.defaultLanguage instead of current language

This bug happened in od_longuedistance_2023. I'm not sure it applies to evolution, but maybe it does.
The project's default language is french, but the participant did the survey in english.
Her browser was set to translate the french pages, so each english word that happened to have an equivalent in french were translated (for example car => because, while it meant auto).

No it seems fine... We should ask the person who reported it what was her setup. and how is it that her browser thought the page was in french...


not able to verify via SMS

Something wrong with twilio client

Actually this does not influence the operation of the exchange. It is just for customer data capture. But it is not necessary to import the openware key in new version.


Changes are not automatically detected

Issue Type: Bug
I'm reporting two issues together here because I believe they may be related.
Issue #1 - In a multi-root container, file changes are not consistently auto-detected in the source control tab. The are only detected after pressing the refresh button. This sometimes works for the folder that was mounted with "mounts" instruction the devcontainer.json but sometimes it doesn't. I couldn't find a pattern for when it does and when it doesn't.
Issue #2 - In this example folder2 is a Python module that is used by the module in folder1. When editing files in folder1 the intellisense is not aware of changes made to the module in folder2 after the initial load of teh container.
Steps to reproduce:

Create a worksapce folder.
Clone https://github.com/ekutner/home-connect-hass into a subfolder called home-connect-hass
Clone https://github.com/ekutner/home-connect-async into a subfolder called home-connect-async
Open the home-connect-hass folder in vscode. Let it build the container.
Add /workspaces/home-connect-async to the workspace
Save the workspace file to the local folder home-connect-hass
Close vscode and reopen the workspace.

Expected behavior:
File changes are automatically detected by source control and intellisense across root folders.
Actual behavior:
File changes are not auto-detected by git.
File changes in module2 (home-connect-async in the above example) are not reflected in module1 (home-connect-hass).
This issue may be related to #142694
VS Code version: Code 1.64.2 (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:02:28.252Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
47.93GB (18.92GB free)

Process Argv
--crash-reporter-id 90988990-5651-4903-8dfa-d0915a585e95

Screen Reader
no

VM
0%

Item
Value

Remote
Dev Container: Home Connect Alt Integration Development

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3695)

Memory (System)
23.44GB (17.00GB free)

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

vscode-drawio
hed
1.6.4

vscode-auto-open-markdown-preview
hnw
0.0.4

better-cpp-syntax
jef
1.15.13

jupyter-keymap
ms-
1.0.0

remote-containers
ms-
0.217.4

remote-wsl
ms-
0.64.2

material-icon-theme
PKi
4.13.0

material-theme
zhu
3.13.19

(3 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
testflightcf:30433671
vsc1dst:30438360
pythonvs932:30410667
wslgetstartedc:30433508
vsclayoutctrc:30437038
vsrem710cf:30416617
dsvsc009:30440023
vsbas813:30436447
vscscmwlcmt:30438805
helix:30440343

I have the same problem with issue 1, also a multi-root container. use [git add] or [git commit], file changes are not consistently auto-detected in the source control tab. The are only detected after pressing the refresh button.
version: 1.64.2. macOS: 12.2.1

This issue could originate from a problem with file watching. Let me explain how file watching works in VSCode first and then provide some details how to get more logging data from how file watching behaves in your case.
Synopsis
VSCode has different strategies for file watching depending on your workspace and setup:

no folder opened: files in opened editors are watched via node.js fs.watch
folder opened: folder is watched recursively for all changes via parcel, opened editors with files not within the folder are watched via node.js fs.watch

If you are connected to a remote (SSH, WSL, Docker), the file watcher will run within the target file system. As such, even though you maybe on Windows where VSCode runs, if the remote is Linux, the file watcher will run in the Linux environment.
Platforms
Depending on the platform you are on, file watching is differently implemented:

macOS: using fsevents services
Windows: using ReadDirectoryChangesW method
Linux: using inotify

Specifically on Linux, watching a large folder recursively can result in VSCode consuming too many file handles. If that is the case, you will see a warning notification with instructions how to solve that.
Limitations
File watching comes with a set of limitations:

symbolic links are not followed automatically but you can explicitly add symbolic links to be watched via the files.watcherInclude setting
mapped network drives or third party file system drivers are not guaranteed to produce file events
in general, the operating system may decide to drop file events at any time, there is no 100% guarantee

Settings
Please review your settings to see if maybe a folder is excluded by accident. Specifically, the files.watcherExclude setting is relevant.
Logging (local)
!!! This is ONLY when you open a local workspace, for remote see below !!!
We provide logging for file events when you enable verbose logging. Steps are:

open VSCode on the local workspace that shows the issue
select View | Command Palette...
select Developer - Set Log Level...
pick Trace
select Help | Toggle Developer Tools
select Console
filter the output by typing File Watcher into the filter box
attach the output when doing the operation that exhibits the issue

Logging (remote)
!!! This is ONLY when you open a remote workspace (WSL, Docker, SSH), for local see above !!!
We provide logging for file events when you enable verbose logging. Steps are:

open VSCode on the remote workspace that shows the issue
select View | Command Palette...
select Developer - Set Log Level...
pick Trace
select View | Output
select Log (Remote Server) from the dropdown
attach the output when doing the operation that exhibits the issue

I verified that the watcherExclude has only the default settings:
"files.watcherExclude": {
  "**/.git/objects/**": true,
  "**/.git/subtree-cache/**": true,
  "**/node_modules/*/**": true,
  "**/.hg/store/**": true
}

Here is the trace log. The log has two file edits, one in the "main" folder (home-connect-hass) and one in the mounted folder (home-connect-async), there are no file watcher events at all.
Note that the behavior is now a bit different than what I described above. Previously, changes were detected in the mounted folder/volume but not in the main folder/volume, where the devcontainer is. Now, changes are not detected at all, in either volumes. I'm not sure exactly what has changed but at least it's more consistent.

@ekutner can you run code --verbose from the command line and do the steps again, this time you don't have to change the trace level within the application as it will be in trace mode from startup. This ensures we print the initialization of the file watcher on startup, e.g. a message like this one:
[2022-03-02 19:41:34.284] [remoteagent] [trace] [File Watcher (parcel)] Request to start watching: /Users/bpasero/Desktop/test-ts (excludes: **/.git/objects/**,**/.git/subtree-cache/**,**/node_modules/*/**,**/.hg/store/**,/Users/bpasero/.vscode-server-oss-testresolver/extensions/**)
[2022-03-02 19:41:34.285] [remoteagent] [trace] [File Watcher (parcel)] Started watching: '/Users/bpasero/Desktop/test-ts' with backend 'fs-events' and native excludes '/Users/bpasero/Desktop/test-ts/.git/objects, /Users/bpasero/Desktop/test-ts/.git/subtree-cache, /Users/bpasero/Desktop/test-ts/.hg/store'

@bpasero
Here is the log. The file watcher is starting to watch the relevant folders but the file changes (at the end of the log) are not detected.

Yes, so it looks like /workspaces/home-connect-hass is watched recursively. Can you please do the following:

open vscode on that folder as usual
select "Duplicate as workspace in new window"
put the 2 windows side by side
open any file that is within /workspaces/home-connect-hass in both windows as text editor
make changes in the 1 window to that file and save
see if the file in the other way updates properly

Thanks

I tried that.
If I edit a file directly under workspaces/home-connect-hass or under workspaces/home-connect-async then those changes are detected immediately by the other window. However, if I edit a file in a subfolder of these folders then the change is not detected by the other window until I click into it and bring it into focus.
Interestingly, even when editing files in the root, which are automatically picked up by the other window, only git tab of the vscode window where the edit was made is reflecting that the file was changed.

Curious if you could attach the full logs for those scenarios just to see what is logged for when it works and when it does not work.

Here is the full log, the interesting stuff is at the end. Edited 4 files, one in each root folder and one in a subfolder of each root.
.

Yeah that is strange indeed. You mentioned https://github.com/microsoft/vscode/issues/142694 could be related, but in that case the sub-directory-structure is really created ad-hoc and does not exist on startup. If all folders are there right on startup, I would expect parcel to recursively attach itself to all folders within the workspace without problems.
So it does seem as if either:

parcel does not attach itself recursively to subfolders
no events are emitted from subfolders, maybe due to the fact that this is WSL

Next thing to try: if you explicitly add the sub-folders via the files.watcherInclude setting, does that work? One thing to note is that symbolic links are not automatically followed for watching, but not sure these subfolders would be symbolic links or not.

It didn't make any difference and none of these subfolders is a symlink.
I tried using fswatch to monitor the file system independently of vscode and found something interesting. When making changes to root level files (those that vscode also detects), fswatch detects the change and reports the full path of the file, however, when changing a file in a subfolder, fswatch also detects the change but only reports the directory path of the file, without the file name. This behavior is not related to the location of the watch, it behaves the same if I place the watch on /workspaces/home-connect-hass or on /workspaces . This makes me think that this is either a problem with docker itself or with the way the volume is mounted, because the file watching only works for the root of the two mounted volumes.
I'm not sure where to take it from here.

Yeah good findings, I was suspecting an upstream issue with the setup too and feel VSCode cannot really resolve them. I suggest to take this issue to them via https://github.com/microsoft/WSL/issues and continue the discussion there.

I can reproduce the issue with a clean container that I created manually, without vscode at all, so the root cause is definitely upstream. That said, I see that this is a known issue with WSL1 and there is a polling based workaround in vscode, since I'm using WSL2 I assume this workaround doesn't kick in, but maybe it would be a good idea to enable it for WSL2 as well.

@aeschli is there a way to force polling for file watching in WSL2?

@bpasero @aeschli
Looking into issues in the WSL project, this still seems to be a problem in WSL2. There is even a suggested workaround (https://levelup.gitconnected.com/docker-desktop-on-wsl2-the-problem-with-mixing-file-systems-a8b5dcd79b22), which I find unreasonable. Looks like polling would be a good temporary solution until it is resolved at the WSL level.

No, for WSL2 we don't offer to turn on polling.
WSL2 has a known issue of lack of events when the resources are on a mount (e.g. the /mnt/c/... mount): https://github.com/microsoft/WSL/issues/4739.
The problem with /mnt/c/... is that file accesses are much slower, so polling is running into performance issues.

@aeschli Since a lot of vscode functionality seems to depend on getting these events it seems that polling is the only option. Even  if it's done every 30 seconds , to overcome the performance issue, it's still much better than not having it at all. I would also guess that the slow performance is only noticeable with very large projects which, are probably not the majority of projects out there. Since the functionality already exists for WSL1 why not enable it for WSL2 as well?

The proper thing is if this is fixed in WSL. There are other tools besides WSL that depend on reliable file events. I've talked to the WSL team and they are aware of the request.


Display System names by default

It would be nice if there was an option to display system names by default instead of having to click
More technically: where would you add code to make that one work? Maybe I give it a look

Done, now I show object name on hover by default ;)
I just add two lines of code, already got a method to add text on object: HUD.addText(...)

Showing the names on-hover is good indeed, but I was also rather looking for a global option to set upon init to show/hide all system names by default in a certain range of the camera

ok I understand, I fear about performances for something like that,
actually there is only one single text object, I just move/change it according to mouse position.
As example on a map with all EDSM systems, if I show all systems names in a range around the camera, it will probably kill the app :) (huge system density).
I will try to made a test this evening, I could start with an option to show the 20-30 most close systems from the camera instead of using a range.

If you look at how Frontier circumvented the same problem in their galaxy map, you'll see that they have a bubble around the camera in which stuff is beeing display - if you leave that bubble, stuff gets flattened out.
Indeed the app is going to explode for databases such as EDSM - maybe stop displaying names/sprites at a certain distance X to the horizontal plane - routes on the other hand should still be visible from far outside.

The main concern is that the performance on WebGL aren't really the same as they are for a compiled application, doing the exact same things as they did in the game would be really performance killer

I just release a new option to show systems name near from camera, just set the "showNameNear" to true to test it ;) (I've add activate option in the demo_galnet.html)
At this time it's very experimental and should not kill the browser (not yet fully optimized),
it will show all names close to the camera with a limit of 50 systems to avoid issues on huge systems density. For performances I refresh names only every 1 second (less could cause lags).

As no feedback & work well on my side,
Close.


Update "List" function to support Module model

Implement new "list" function for modules

Support for listing modules implemented through merging PR #48.


Grammar fixes for tense, punctuation and wording.

Great guide, thanks for assembling all these resources. Just a few edits that clarify some of the language!

Thank you! There's just one minor issue and I can merge this after it is fixed (:

Thank you for your contribution!  It's a good way to contribute to Hacktoberfest 😎


add check for data length

fixes https://github.com/FormidableLabs/victory/issues/489

@DerekMaffett thanks for pressing me on that.


Fix Lint/NonAtomicFileOperation cop error on non-constant receiver

Follow-up to https://github.com/rubocop/rubocop/pull/13558
echo 'storage[:files].delete(file) unless File.exists?(file)' | rubocop --stdin bug.rb --only Lint/NonAtomicFileOperation -d

An error occurred while Lint/NonAtomicFileOperation cop was inspecting bug.rb:1:0.
undefined method `name' for an instance of Parser::Source::Map::Send
lib/rubocop/cop/lint/non_atomic_file_operation.rb:136:in `autocorrect_replace_method'
lib/rubocop/cop/lint/non_atomic_file_operation.rb:124:in `autocorrect'
lib/rubocop/cop/lint/non_atomic_file_operation.rb:109:in `block in register_offense'

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Feature branch is up-to-date with master (if not - rebase it).
[X] Squashed related commits together.
[X] Added tests.
[X] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[X] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


How to set local path phantomjs 2 bin ?

Hi !
How I can set local path to phatom 2 ? On win/linux/darwin.
Without download every time.
Thanks !

Set PHANTOMJS_BIN env to PhantomJs bin:
22:07:29 grzegorz@myhost:~/git/some-dir$ phantomjs -v
2.0.0
22:08:14 grzegorz@myhost:~/git/some-dir$ which phantomjs
/usr/local/bin/phantomjs
22:08:20 grzegorz@myhost:~/git/some-dir$ export PHANTOMJS_BIN=`which phantomjs`
22:08:42 grzegorz@myhost:~/git/some-dir$ gulp test
[22:08:49] Using gulpfile ~/git/some-dir/gulpfile.js
[22:08:49] Starting 'test'...
05 09 2015 22:08:49.292:INFO [karma]: Karma v0.13.9 server started at http://localhost:9018/
05 09 2015 22:08:49.298:INFO [launcher]: Starting browser PhantomJS
05 09 2015 22:08:50.740:INFO [PhantomJS 2.0.0 (Mac OS X 0.0.0)]: Connected on socket YAcKCXTDvg5w64PQAAAA with id 43811757
(...)

@grzegorz-dubicki Thanks for the fix!
I had ran into this issue on TravisCI's Ubuntu Trusty beta image. With the latest build images, the directory to PhantomJS was changed.
Error
INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
ERROR [launcher]: Cannot start PhantomJS
	Can not find the binary /usr/local/phantomjs/bin/phantomjs
	Please set env variable PHANTOMJS_BIN

Solution
export "PHANTOMJS_BIN=`which phantomjs`"

Tried to do that on windows, but couldn't get it to work. Karma stuck at Starting browser PhantomJS.
set PHANTOMJS_BIN=e:\phantomjs-2.0.0\bin
set PHANTOMJS_BIN=e:\phantomjs-2.0.0\bin\phantomjs.exe

The newly released 1.0.0 is able to use the latest phantomjs-prebuilt which brings phantomjs@2 easily into your setup.


Installing dependencies using pip requirements breaks in Python 3.12

From Python 3.12 disutils was removed (here) disutils was used for install requirements. From python 3.12 they started using setuptools.
All I did was replace the requirements.txt and bumped up the versions.
How do I raise a PR for the same?

I had found how to raise a PR for contribution. Here's how to do it, in case anyone needs to know.

Fork the repo you want to contribute to.
Make changes and push commits.
From your forked repo you will be able to raise PRs and it will show up in the source repos PR list.

Go on, make great PRs :+1:


[Feature]: Support for custom hex colors

What problem does this feature solve?
I would like to know if there is any possibility of supporting custom hex colors for theming the components, such as defining primary, secondary, tertiary and so on... colors.
Thanks in advance,
Regards,
Borja
What does the proposed API look like?
No response

You can change the colors that tremor uses via the tailwind config
colors: {
        // light mode
        tremor: {
          brand: {
            faint: "#eff6ff", // blue-50
            muted: "#bfdbfe", // blue-200
            subtle: "#60a5fa", // blue-400
            DEFAULT: "#3b82f6", // blue-500
            emphasis: "#1d4ed8", // blue-700
            inverted: "#ffffff", // white
          },
          background: {
            muted: "#f9fafb", // gray-50
            subtle: "#f3f4f6", // gray-100
            DEFAULT: "#ffffff", // white
            emphasis: "#374151", // gray-700
          },
          border: {
            DEFAULT: "#e5e7eb", // gray-200
          },
          ring: {
            DEFAULT: "#e5e7eb", // gray-200
          },
          content: {
            subtle: "#9ca3af", // gray-400
            DEFAULT: "#6b7280", // gray-500
            emphasis: "#374151", // gray-700
            strong: "#111827", // gray-900
            inverted: "#ffffff", // white
          },
        },
        // dark mode
        "dark-tremor": {
          brand: {
            faint: "#0B1229", // custom
            muted: "#172554", // blue-950
            subtle: "#1e40af", // blue-800
            DEFAULT: "#3b82f6", // blue-500
            emphasis: "#60a5fa", // blue-400
            inverted: "#030712", // gray-950
          },
          background: {
            muted: "#131A2B", // custom
            subtle: "#1f2937", // gray-800
            DEFAULT: "#111827", // gray-900
            emphasis: "#d1d5db", // gray-300
          },
          border: {
            DEFAULT: "#1f2937", // gray-800
          },
          ring: {
            DEFAULT: "#1f2937", // gray-800
          },
          content: {
            subtle: "#4b5563", // gray-600
            DEFAULT: "#6b7280", // gray-600
            emphasis: "#e5e7eb", // gray-200
            strong: "#f9fafb", // gray-50
            inverted: "#000000", // black
          },
        },
      },

However using custom hex classes in the components such as
<Icon icon={CashIcon} color="#0000FF" />

Won't work as firsly the color attribute is typed to only allow the colors in the tailwind config, these can be changed in your tailwind config but the names have to be changed.
It would be nice to allow for custom hex/rgb.. colors in the attributes however I don't this would be possible as tremor uses string interpolation to build the color classNames https://github.com/tremorlabs/tremor/blob/b041b1d67faed7cc8ef9cc3eb8a7c886ca61371b/src/lib/utils.tsx#L70C36-L70C36
And so tailwind wont pickup the colors and it will not be included in the CSS bundle. It could be allowed by allowing a safelist in the tailwind config, but this will make the bundle big. Or alternatively, you could use the same classNames in your application, but that seems like a bit of hack.
As far as using custom utility classes (primary, scendary ...) would be nice as tailwind would include them in the bundle as long as you define them in your config! However this would require modifying the Color type to a string, which isn't ideal caus we lose some nice intellisense

Hi all, I know this sounds super easy initially but it gets complicated quickly. This is due to two reasons:

If we start supporting custom hex colors, we have to implement that in every component (consistency)
There is much more "color" management under the hood than it seems at the start.

Let me give you a visual example:
Button. Variant: Outline

Alright, this button is blue. So I expect to have a property color, where I can input any hex color. This won't work.
If you look very closely, there are three shades of blue involved. Note: The shades are NOT differentiated by their opacity. There's a muted blue for the ring, a subtle blue for the border, and a brand blue for the icon itself. So, what should this icon look like if I input a yellow hex code (#ffcc33)? Should only the mailbox icon become yellow? How about the border and the ring? Should we add a function that calculates those shades?
We do this because we want to ensure if you use one of our 20+ colors, you get a nice and usable icon. This rings true for the icons, but also for the more complex components where color is involved (e.g. charts, progress bars, etc.)

Hi all,
Before anything else, thank you for your responses to this topic. Really appreciate them all.
Regarding the theming of tailwind, I already know it, but the main issue I have is that I am building a metrics package that exports several charts that are customizable.
I use charts from recharts and other charts packages. I found this package with lots of usefull utilites, and I wanted to add it to the library, trying to extend the options used in my package such as
"colors":  {
     "primary" : "#000000",
     "secondary: "#FFFFFF",
}
```

With the tailwind config I can't modify the theme "in-situ" since it compiles before the application starts.  So I was wondering if there is a way of supporting custom hex colors.

Regarding @severinlandolt  response, I understand the complexity you are mentioned, but you could start with some basic components such as line charts or area charts where you can only define the color of one datakey of the charts and so on.

But thanks for your responses!

Hi @adamhenson, we are planning to allow custom hex colors in our charts. For all other components, we will stick with our set of 22 base colors + the configurable brand color in the tailwind.config.
This is due to 5-6 associated colors for like hover, ring and other parts of components.

Thanks @severinlandolt! Any idea on timeframe for landing the custom hex colors in our charts? If not soon, any advice for someone to contribute? If I can find some time, I may be able to create a PR in this effort... unless you think I'd need a lot of core contributor knowledge.

I took a shot at one approach in supporting custom colors (custom theme colors or hex colors) in #836.


Make go-mask work properly when data contains cycles

Data that is passed to mask.Mask could be cycled in lot's of different ways.
When it happens call end up in panic due to the reaching stack limit.
This PR fixes behavior for this case, improving caching along the way.
Closes https://github.com/showa-93/go-mask/issues/4

@showa-93 , could you please take a look at this one too ?

Thank you for the PR!
I have reviewed your changes and found them to be very insightful.
LGTM
I'll merge it!


Accent marks render outside of LineEdit's text parameter in the inspector when many are added

Tested versions
v4.2.1.stable.official [b09f793f5]
System information
Ubuntu 20.04 LTS
Issue description
In the inspector. I held down Q for a while, so there are many accent marks.

The 2D scene looks correct though

For more comparison...
My browser URL bar (10 accent marks; it seems to stack them in-place)

VIM (10 accent marks; it seems to only show the first two)

Steps to reproduce
Open the MRP, open line_edit.tscn, click on the LineEdit node, and look at the inspector.
The steps I took to create the MRP:
Follow these instructions at your own risk since they involve installing and switching to a new key layout.

Ensure you can input Arabic.  On Ubuntu 20 Settings -> Region & Language -> Manage Installed Languages -> Install/Remove Languages... -> Choose Arabic and let it install.  Once it is done, close and reopen Settings.  Then go to Region & Language -> Click on the + sign -> Choose Arabic.  In your status bar, you should see en, click on it to switch to ar.
Create a LineEdit node
Type any character.  For this example I typed single-quote (') which produced ط in Arabic.
Type Q, this will add an accent above it, like this: طَ
Hold down Q, and this will continuously add more accents.  Watch it clip out of LineEdit.

Notice that the rendered text in the 2D scene looks correct, which may mean this is an issue with the editor's font.
Minimal reproduction project (MRP)
ArabicBug.zip

cc @bruvzg

I do not think stacking itself is a bug, the way how combining characters are placed is control by font, and if it's configured to stack it should stack.
But clipping should be added to prevent rendering out of bounds.


price tracker

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Pre-submission checks
Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #5394

Plagiarism check done

@khabdrick Kindly, do not make changes that will overwrite this review. Thanks

@khabdrick Kindly, do not make changes that will overwrite this review. Thanks

Do a git pull first to apply the edits made here - then make your changes after the git pull 👍

@khabdrick Kindly, do not make changes that will overwrite this review. Thanks

Do a git pull first to apply the edits made here - then make your changes after the git pull 👍

I don't have any edits to make.

Hello @hectorkambow this article has been in the pipeline for a while, but not final review.
Is it that the article is no good enough for the blog or is there something wrong with it?

Hello @hectorkambow this article has been in the pipeline for a while, but not final review. Is it that the article is no good enough for the blog or is there something wrong with it?

Not sure - the team has been going through our queue - we had a big backlog at the time.
@section-engineering-education/content-moderator-team

Jumping on this one now

Overall very nice job gents. This was easy to follow along 🚀


Adapt MitieFeaturizer to new GraphComponent interface

Proposed changes:

fix https://github.com/RasaHQ/rasa/issues/9453

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

It requires https://github.com/RasaHQ/rasa/pull/9523 to be merged first because it uses the new DenseFeaturizer class


"You are currently in preview mode. Join this server to start chatting!" what's the fix?

Acknowledgements

[X] I have checked that there is no other issue describing the same or
similar problem that I currently have, regardless if it has been
closed or open.

[X] This bug affects Discord website.

[ ] This issue is confirmed to be reproducible when WebCord is packaged
on at least all three latest supported Electron major releases.

[ ] This issue is reproducible in Chrome, Chromium or any
Chromium-based browser, e.g Brave or Edge (please write in
Additional Context which browser you have used if it is neither
Chrome nor unmodified Chromium).

[ ] There are no fixes done to master which resolves this issue.

[ ] My issue describes one of the unstable and/or not fully implemented
features.

[ ] I have found a workaround to mitigate or temporarily fix this issue
in affected releases (please write it in Additional context section
below).

Operating System / Platform
🐧 Linux
Operating system architecture
x64 (64-bit Intel/AMD)
Electron version
30.0.3
Application version
4.9.2
Bug description
When i try to join a server on discord i just get a loading button, and nothing happens after it loads for maybe 5 seconds.
Here are some posts online that describe the same issue.
https://www.reddit.com/r/discordapp/comments/1163xxs/help_im_stuck_in_preview_mode/
What's the fix? Thanks!
Additional context
No response

What's the fix? (...)

None on my side, because:

[X] This bug affects Discord website.

Closing this as wontfix.


Celo:

Describe your issue here.
Environment

Elixir Version: 1.9.0

Erlang Version: 22

BlockScout Version: da32f38df434fc457a5dd9a9d49cbc56aec84472

User Agent: Mozilla/5.0 (Linux; Android 11; Mi Note 10) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.66 Mobile Safari/537.36

Steps to reproduce
Tell us how to reproduce this issue. If possible, push up a branch to your fork with a regression test we can run to reproduce locally.
Expected Behaviour
Tell us what should happen.
Actual Behaviour
Tell us what happens instead.

Eu quero cancelar uma transferência


Derivation path, CashAddr, Cash Account

This update to BitcoincashJ now includes:

Standard derivation path m/44'/145'/0' for wallets, instead of m/0'
CashAddr support by default with Wallet.currentReceiveAddress and Wallet.freshReceiveAddress
Cash Account (https://cashaccount.info) sending support in SendRequest.to and SendRequest.emptyWallet

Can you cleanup the 100644 → 100755 non-changes?
Breaking this up into 3 pull requests would also be appreciated for ease of review.
Quick glance looks good otherwise!

The new commits were automatically added, and I thought I had git ignoring the non-changes, but I guess not. :/ Oops.

Two new pull requests for Cash Addresses and Key Derivation Path:
https://github.com/ProtocolCash/bitcoinj-cash/pull/3
https://github.com/ProtocolCash/bitcoinj-cash/pull/4
If you are you able to review these, that would be awesome.
A clean pull for Cash Accounts is still needed to.

For Cash Accounts all you need to do is copy these files:
https://github.com/ProtocolCash/bitcoinj-cash/pull/1/commits/a07d9e9d6a904bc1e33a5c78ac7e4bca59c8278c#diff-3e4047888c4159a9a6a5f7b57dd7b698
https://github.com/ProtocolCash/bitcoinj-cash/pull/1/commits/a07d9e9d6a904bc1e33a5c78ac7e4bca59c8278c#diff-713decd43083dc81281ee791be11019f
https://github.com/ProtocolCash/bitcoinj-cash/pull/1/commits/feb3bc1031dcf8138eefc80bc0f4eecfae947d7b#diff-4da3d48ebbe24f1835196b0ec02c184e
and
https://github.com/ProtocolCash/bitcoinj-cash/pull/1/commits/feb3bc1031dcf8138eefc80bc0f4eecfae947d7b#diff-58383b731b8af9dec0bff66846c2b704
There might be a few other files you need to change in the tests area. It'll tell you when compiling.
I'd make a new PR rn but I'm busy doing stuff around the house.


Force vcs installs to block to avoid race condition

Fixes #919

From an 👀-only check, this looks ok to me. I would like a maintainer or one of our regular contributors to verify this is a properly diagnosed bug before we merge though. I'll try to set aside some time in the next few days if no one else gets to it.

@nateprewitt I can verify that this is a bug.  This looks good to me, I'm going to merge!

need to write a test for this


fixed #137: wait_for replaced with wait_to in browser.should

Hi Yashaka,
This is my first pull request. I hope I created in the right way :)
Regards,
Bela

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   62.77%   62.77%
=======================================
  Files          25       25
  Lines        1131     1131
  Branches       94       94
=======================================
  Hits          710      710
  Misses        415      415
  Partials        6        6

Impacted Files
Coverage Δ

selene/browser.py
54.71% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adad198...20a671c. Read the comment docs.


Outdated cask: soundcleod

Outdated cask: soundcleod.
Info:

version: 1.1.0.
appcast url: https://github.com/salomvary/soundcleod/releases.atom.

Please do not run find_outdated_appcasts unless you are a maintainer.


[Native] NestedloopJoin with join criteria produces incorrect number of rows.

Bug description
Produces 1 addtional row more than the expected. Issue fails often on cluster with multiple workers.
java.lang.AssertionError: For query:
 SELECT * FROM (SELECT * FROM nation WHERE nation.nationkey%2=0)FULL JOIN (SELECT * FROM region WHERE regionkey%2=0) region ON region.regionkey = 2
not equal
Actual rows (up to 100 of 1 extra rows shown, 16 rows in total):
    [null, null, null, null, 2, ASIA, ges. thinly even pinto beans ca]
Expected rows (up to 100 of 0 missing rows shown, 15 rows in total):

System information
NA
Relevant logs
No response

@karteekmurthys : You mentioned that you need atleast 4 workers in your cluster to reproduce this problem. Does presto-cli using a cluster with 4 workers never hit this problem ?

There have been occasions where it fails on single worker as well. With new query involving nation and region I am able to reproduce lot more often even with single worker. We can clearly see filter has wrongly generated a build mismatch:
Actual rows (up to 100 of 1 extra rows shown, 16 rows in total):
    [null, null, null, null, 2, ASIA, ges. thinly even pinto beans ca]

Here regionkey = 2 satisfies the join criteria and must not have a null against it. CMIW

 SELECT nation.nationkey, region.regionkey, region.name FROM (SELECT * FROM nation WHERE nation.nationkey%4=0) nation FULL JOIN (SELECT * FROM region WHERE regionkey%4=0) region ON region.regionkey = 4
not equal
Actual rows (up to 100 of 9 extra rows shown, 9 rows in total):
    [0, 4, MIDDLE EAST]
    [4, 4, MIDDLE EAST]
    [8, 4, MIDDLE EAST]
    [12, 4, MIDDLE EAST]
    [16, 4, MIDDLE EAST]
    [20, 4, MIDDLE EAST]
    [24, 4, MIDDLE EAST]
    [null, 0, AFRICA]
    [null, 4, MIDDLE EAST]
Expected rows (up to 100 of 1 missing rows shown, 1 rows in total):
    [1]

Expected 8 rows but got 9.
 SELECT nation.nationkey, region.regionkey, region.name FROM (SELECT * FROM nation WHERE nation.nationkey%4=0) nation FULL JOIN (SELECT * FROM region WHERE regionkey%4=0) region ON region.regionkey = 4
not equal
Actual rows (up to 100 of 9 extra rows shown, 9 rows in total):
    [0, 4, MIDDLE EAST]
    [4, 4, MIDDLE EAST]
    [8, 4, MIDDLE EAST]
    [12, 4, MIDDLE EAST]
    [16, 4, MIDDLE EAST]
    [20, 4, MIDDLE EAST]
    [24, 4, MIDDLE EAST]
    [null, 0, AFRICA]
    [null, 4, MIDDLE EAST]
Expected rows (up to 100 of 1 missing rows shown, 1 rows in total):
    [1]

@karteekmurthys : This shows the behavior which was the hunch yesterday that the single row matching all rows is repeated with NULLs also.
Have you been able to see this with a single worker ?

Yes, I have been able to repro on single worker. Here is my finding, for the following query:
SELECT nation.nationkey, region.regionkey, region.name FROM (SELECT * FROM nation WHERE nation.nationkey%4=0) nation FULL JOIN (SELECT * FROM region WHERE regionkey%4=0) region ON region.regionkey = 4

The build side has 2 rows and 1 row is valid but the buildMatched_ vector has marked both invalid:
(lldb) p matched.isValid(1)
(bool) $0 = false
(lldb) p matched.isValid(0)
(bool) $1 = false

This variable is in getMismatchedOutput():
I tried to log the addresses of buildMatched_ member and it seems like it changes for the failures case:
I20230824 00:18:07.550011 1089194 NestedLoopJoinProbe.cpp:465] NestedLoopJoinProbe::doMatch() buildMatched obj at 0x600003885d70
I20230824 00:18:07.550037 1089194 NestedLoopJoinProbe.cpp:467] NestedLoopJoinProbe::doMatch() buildMatched at 0 0
I20230824 00:18:07.550056 1089194 NestedLoopJoinProbe.cpp:467] NestedLoopJoinProbe::doMatch() buildMatched at 1 1
I20230824 00:18:07.550103 1089194 NestedLoopJoinProbe.cpp:483] NestedLoopJoinProbe::doMatch() Final output size after filter 7
I20230824 00:18:07.550125 1089194 NestedLoopJoinProbe.cpp:171] NestedLoopJoinProbe::getOutPut after calling doMatch 7
I20230824 00:18:07.550144 1089194 NestedLoopJoinProbe.cpp:178] NestedLoopJoinProbe::getOutPut before exit 7
I20230824 00:18:07.550235 1089194 NestedLoopJoinProbe.cpp:164] NestedLoopJoinProbe::getOutPut hasProbedAllBuildData 0
I20230824 00:18:07.550253 1089194 NestedLoopJoinProbe.cpp:178] NestedLoopJoinProbe::getOutPut before exit 0

I20230824 00:18:07.581224 1089196 NestedLoopJoinProbe.cpp:132] NestedLoopJoinProbe::getOutput() buildMatched obj at 0x6000038f0180
I20230824 00:18:07.581323 1089196 NestedLoopJoinProbe.cpp:140] NestedLoopJoinProbe::getOutPut not hasProbedAllBuildData after getMismatchedOutput 2 <--- 2 Mismatches.

When the query succeeds, the buildMatched_ selectivity vector is unchanged yielding the correct results:
I20230824 00:15:23.333418 1084363 NestedLoopJoinProbe.cpp:465] NestedLoopJoinProbe::doMatch() buildMatched obj at 0x600003b687e0
I20230824 00:15:23.333437 1084363 NestedLoopJoinProbe.cpp:467] NestedLoopJoinProbe::doMatch() buildMatched at 0 0
I20230824 00:15:23.333454 1084363 NestedLoopJoinProbe.cpp:467] NestedLoopJoinProbe::doMatch() buildMatched at 1 1
I20230824 00:15:23.333503 1084363 NestedLoopJoinProbe.cpp:483] NestedLoopJoinProbe::doMatch() Final output size after filter 7
I20230824 00:15:23.333524 1084363 NestedLoopJoinProbe.cpp:171] NestedLoopJoinProbe::getOutPut after calling doMatch 7
I20230824 00:15:23.333540 1084363 NestedLoopJoinProbe.cpp:178] NestedLoopJoinProbe::getOutPut before exit 7
I20230824 00:15:23.333622 1084363 NestedLoopJoinProbe.cpp:164] NestedLoopJoinProbe::getOutPut hasProbedAllBuildData 0
I20230824 00:15:23.333640 1084363 NestedLoopJoinProbe.cpp:178] NestedLoopJoinProbe::getOutPut before exit 0
I20230824 00:15:23.336091 1083318 NestedLoopJoinProbe.cpp:132] NestedLoopJoinProbe::getOutput() buildMatched obj at 0x600003b687e0
I20230824 00:15:23.336154 1083318 NestedLoopJoinProbe.cpp:140] NestedLoopJoinProbe::getOutPut not hasProbedAllBuildData after getMismatchedOutput 1 <--- Correct result
I20230824 00:15:23.336174 1083318 NestedLoopJoinProbe.cpp:178] NestedLoopJoinProbe::getOutPut before exit 1

The root cause is a race condition between parallel NestedLoogJoinProbe operators. The common area for exchange of information between these probe operators is in beginBuildMismatch() method.
Let's say, if there are 2 probe operators P1 and P2. P1 processes all the build data and marks itself finished here, as other peers (P2) are still processing.
When P2 arrives at beginBuildMismatch, its peer P1 is marked finished and now it is the lastProbe_ alive and copies the buildMatched_  SelectivityVector from peer P1.
But, in our failure case, this breaks. After P1 marks itself finish, the driver seems to have terminated and probe P2 has no peers to copy buildMatched_ from. In our example query we have 1 result matched but the probe P2::buildMatched_ has 0 out of 2 rows unmatched. When P2::getOutPut is called, this time fetches all rows as mismatched rows from its own buildMatched_ SelectivityVector.
Some logs I printed out to help understand the flow:
14:12.462167 1890252 Task.cpp:1476] Task::allPeersFinished() numPeers 3 state.numRequested0
14:12.462172 1890229 NestedLoopJoinProbe.cpp:180] NestedLoopJoinProbe::getOutPut before exit 0
14:12.462188 1890252 NestedLoopJoinProbe.cpp:290] NestedLoopJoinProbe::beginBuildMismatch() set kFinish this 0x129b0d850
14:12.462199 1890249 Task.cpp:1476] Task::allPeersFinished() numPeers 3 state.numRequested1
14:12.462221 1890229 Task.cpp:1464] Task::allPeersFinished() entering
14:12.462232 1890252 NestedLoopJoinProbe.cpp:125] NestedLoopJoinProbe::getOutput isFinished
14:12.462247 1890249 NestedLoopJoinProbe.cpp:290] NestedLoopJoinProbe::beginBuildMismatch() set kFinish this 0x129b0ef30
14:12.462266 1890229 Task.cpp:1476] Task::allPeersFinished() numPeers 3 state.numRequested2
14:12.462306 1890249 NestedLoopJoinProbe.cpp:125] NestedLoopJoinProbe::getOutput isFinished
14:12.462316 1890229 NestedLoopJoinProbe.cpp:296] NestedLoopJoinProbe::beginBuildMismatch() set lastProbe_ this 0x129b10020
No Peers found ---> 14:12.462342 1890229 NestedLoopJoinProbe.cpp:300] NestedLoopJoinProbe::beginBuildMismatch() number of peers: 0
14:12.462364 1890229 NestedLoopJoinProbe.cpp:134] NestedLoopJoinProbe::getOutput() buildMatched:0x600000c80720 buildIndeX_:0 this:0x129b10020
14:12.462436 1890229 NestedLoopJoinProbe.cpp:142] NestedLoopJoinProbe::getOutPut not hasProbedAllBuildData after getMismatchedOutput 2
14:12.462456 1890229 NestedLoopJoinProbe.cpp:180] NestedLoopJoinProbe::getOutPut before exit 2
14:12.462527 1890229 NestedLoopJoinProbe.cpp:125] NestedLoopJoinProbe::getOutput isFinished

cc: @mbasmanova @aditi-pandit @majetideepak

CC: @xiaoxmeng @usurai

@karteekmurthys Thanks for catching and investigating on this!
Indeed, probe operators should wait for the last probe operator to take the mismatch data, instead of finishing.
Fix is #6326.

@mbasmanova  @usurai
Looks like we have more issues in nestedloop implementation:
Actual rows (up to 100 of 1 extra rows shown, 1 rows in total):
    [251]
Expected rows (up to 100 of 1 missing rows shown, 1 rows in total):
    [310]

        at org.testng.Assert.fail(Assert.java:110)
        at com.facebook.presto.tests.QueryAssertions.assertEqualsIgnoreOrder(QueryAssertions.java:251)
        at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:231)
        at com.facebook.presto.tests.QueryAssertions.assertQuery(QueryAssertions.java:106)
        at com.facebook.presto.tests.AbstractTestQueryFramework.assertQuery(AbstractTestQueryFramework.java:152)
        at com.facebook.presto.tests.AbstractTestQueryFramework.assertQuery(AbstractTestQueryFramework.java:147)
        at com.facebook.presto.nativeworker.AbstractTestNativeJoinQueries.testJoinsWithConstantFilterAndNoCriteria(AbstractTestNativeJoinQueries.java:132)

@karteekmurthys : Are you able to reproduce this problem with all of LEFT, RIGHT and FULL OUTER joins ? Or is it specific to some of these ?

@karteekmurthys : https://github.com/facebookincubator/velox/blob/main/velox/exec/NestedLoopJoinProbe.cpp#L302 should be updating probeMatched_ also right ?

In this query,  the actual matched rows are 251 and there must be 59 buildMismatched rows. Seems like after the recent change the buildMatched_ all are selected (Need to confirm this).
SELECT count(*) FROM (SELECT * FROM lineitem WHERE orderkey % 1024 = 0) lineitem RIGHT JOIN (SELECT * FROM orders WHERE orderkey % 1024 = 0) orders ON orders.orderkey = 1024

@usurai

In this query, the actual matched rows are 251 and there must be 59 buildMismatched rows. Seems like after the recent change the buildMatched_ all are selected (Need to confirm this).
SELECT count(*) FROM (SELECT * FROM lineitem WHERE orderkey % 1024 = 0) lineitem RIGHT JOIN (SELECT * FROM orders WHERE orderkey % 1024 = 0) orders ON orders.orderkey = 1024

@usurai

Could you share your dataset for this? I could not reproduce this with my handmade data. Thanks!

Please run the e2e tests here: https://github.com/prestodb/presto/pull/20381/files#diff-5ef1982fc26230a4150cc7fe37fbaebc7735cea470b2a09599ebd839f37ef369R124.
You can copy the test method testJoinsWithConstantFilterAndNoCriteria and just run it like any other e2e test.
I am not able to reproduce it locally either.

Here is the job that failed: https://app.circleci.com/pipelines/github/prestodb/presto/6974/workflows/ccf507fc-9314-4833-8211-0ecab8353b90/jobs/22350

@karteekmurthys Thanks for pointing to the failed test. Could you share the instruction to run the E2E test with command line(it's missing in presto-native-execution's readme) as I don't have access to Intellij IDEA.
Regarding the test failure, I think we first need to figure out what's the representation of the expression ON orders.orderkey = 1024 is in the system, a join condition or a filter. Please see my comment in the PR, thanks!

https://app.circleci.com/pipelines/github/prestodb/presto/6974/workflows/ccf507fc-9314-4833-8211-0ecab8353b90/jobs/22350
If no IntelliJ, you can run e2e by starting a docker container with image prestocpp/prestocpp-avx-centos:root-20230613 and follow steps here in this file .circleci/continue_config.yml.

I think this issue can be closed since the cause is not related to the nested loop join.


Docs.MS Readme Update.

Docs.MS Readme Update.

Docs Build status updates of commit 8187216:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/azure-docs-sdk-python, working directory: W:\aygu-s, target branch: smoke-test, target branch commit: c161229d8ee86867438299cd836b4e48422684f1, source commit: 81872169bbadd475c6a24d03c095af703f31d79c.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit dbbc11c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/azure-docs-sdk-python, working directory: W:\2m4j-s, target branch: smoke-test, target branch commit: c161229d8ee86867438299cd836b4e48422684f1, source commit: dbbc11c884cce69a1f2f107508159afd05ec191c.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit cc38b67:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because branch smoke-test-rdme has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/smoke-test-rdme

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Examples camera controller separated into a module

Objective
Unify flycam-style camera controller from the examples.
parallax_mapping controller was kept as is.
Solution
Fixed some mouse movement & cursor grabbing related issues too.

wrong branch


Replace or enhance existing commands to take a programmatic approach

Related #91
Is your enhancement related to a problem? Please describe.
Currently the commands we have take a UI approach. There are a few problems with this:

UI navigation is slow
Targeted HTML class names and IDs can change with WordPress versions, which means tests can fail on older WP versions.

We should avoid UI wherever possible. UI navigation should be for situations when we actually test UI features.
For example, to insert a paragraph block, instead of doing:

Click the inserter
Type in the name of the block
Click the block name
Type the paragraph content

We can directly call:
const paraBlock = wp.blocks.createBlock( 'core/paragraph', { content: '<CONTENT>' } );
wp.data.dispatch( 'core/editor' ).insertBlocks( paraBlock );

This will be a comparatively faster approach
Won't be affected by change of selectors in Block Editor
Reduce test sizes in most cases

We can also modify/create existing/new commands that can take both the programmatic and the UI approach as per requirement.
This was discussed previously but it was lost in comments:
https://github.com/10up/cypress-wp-utils/pull/62#issuecomment-1128453871
@10up/open-source-practice would be great to hear your thoughts on this.
Designs
No response
Describe alternatives you've considered
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

1. openDocumentSettingsPanel()
This command can be refactored to:
function openDocumentSettingsPanel( panelName ) {
	if ( ! wp.data.select('core/edit-post').isEditorPanelOpened( panelName ) ) {
		wp.data.dispatch('core/edit-post').toggleEditorPanelOpened( panelName );
	}
}

2. openDocumentSettingsSidebar()
function openDocumentSettingsSidebar() {
	if ( ! wp.data.select('core/edit-post').isEditorSidebarOpened() ) {
		wp.data.dispatch('core/edit-post').openGeneralSidebar( 'edit-post/document' );
	}
}

I'm in two minds about this, as I see pros and cons.
The big pro is the one you identify, we don't see breaks due to changes within the block editor's UI that affect backward compatibility. Presuming backward compatibility is maintained by the block editor packages, we won't need to update the commands used in the Cypress utilities.
The cons I see are that we'll miss UI problems introduced by custom CSS/JS. When migrating the Distributor tests, I noticed that the E2E tests failed as our custom CSS was blocking access to the button for closing the welcome screen. By using the UI, I could introduce a quick fix.
On balance, I think it's probably safer to continue using the UI so we don't miss bugs with the Core code introduced via the plugin.


Libraries.

How would one go about adding external libraries?
would it go in the lib folder?

Are you referring to the Ino library? Or Pathogen? I've outlined how to install the Ino library in the README and you can find instructions on installing Pathogen on their webpage.


libtasn1: 4.16.0 -> 4.17.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libtasn1/versions.
meta.description for libtasn1 is: "An ASN.1 library"
meta.homepage for libtasn1 is: "https://www.gnu.org/software/libtasn1/"
meta.changelog for libtasn1 is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.17.0 with grep in /nix/store/npbccp21z5h202hzswzrwv0483ny4p38-libtasn1-4.17.0

found 4.17.0 in filename of file in /nix/store/npbccp21z5h202hzswzrwv0483ny4p38-libtasn1-4.17.0

directory tree listing: https://gist.github.com/949a6e0f2de909c3ef89ce0db1f18bcf

du listing: https://gist.github.com/6f45e84ee2ea85cee91fbdd303bd3ccf

Rebuild report (if merged into master) (click to expand)

31227 total rebuild path(s)

10991 package rebuild(s)

10970 x86_64-linux rebuild(s)
9423 i686-linux rebuild(s)
1605 x86_64-darwin rebuild(s)
9229 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
AusweisApp2
CHOWTapeModel
DisnixWebService
EBTKS
EmptyEpsilon
MIDIVisualizer
MMA
OSCAR
OVMF
OVMF-CSM
OVMF-secureBoot
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_Pango
SDL_gfx
SDL_gpu
SDL_image
SDL_mixer
SDL_net
SDL_sound
SDL_stretch
SDL_ttf
Sylk
_1oom
_1password-gui
_20kly
_389-ds-base
_3mux
_90secondportraits
a2jmidid
abbaye-des-morts
abcde
abcl
abiword
abootimg
abuse
accountsservice
acoustidFingerprinter
acsccid
act
adapta-gtk-theme
adementary-theme
adlplug
adminer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/npbccp21z5h202hzswzrwv0483ny4p38-libtasn1-4.17.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libtasn1 https://github.com/r-ryantm/nixpkgs/archive/bccb97fe2cffde10e2e4e2ed63e0543ad0333615.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/npbccp21z5h202hzswzrwv0483ny4p38-libtasn1-4.17.0
ls -la /nix/store/npbccp21z5h202hzswzrwv0483ny4p38-libtasn1-4.17.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

Result of nixpkgs-review pr 123296 at bccb97fe run on aarch64-linux 1

906 packages marked as broken and skipped:

OVMF-CSM
adoptopenjdk-hotspot-bin-13
adoptopenjdk-hotspot-bin-14
adoptopenjdk-jre-hotspot-bin-13
adoptopenjdk-jre-hotspot-bin-14
agdaPackages.iowa-stdlib
aldor
ams-lv2
amuleDaemon
aqemu
...

6888 packages skipped due to time constraints:

AusweisApp2
CHOWTapeModel
DisnixWebService
EBTKS
EmptyEpsilon
MIDIVisualizer
MMA
OVMF
OVMF-secureBoot
R
...

2 packages built successfully:

libtasn1
p11-kit

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/libtasn1/default.nix:22:3:
   |
22 |   meta = with lib; {
   |   ^


[Feature]: Upgrade Cypress to Version 10

Please check the following

[x] Do the tests still pass? (see Run the Tests)
[x] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[x] Have tests been added to cover any new features or fixes?
[x] Has the documentation been updated accordingly?

Please describe additional details for testing this change

This is blocked by https://github.com/cuttle-cards/cuttle/pull/124 as it's causing test failures.


For elements added to model during maven discovery, the description is used instead of technology

If you look current produced container diagram, some of the containers are added with incorrect technology defined.

So, if I look into diagram source, I get
  Container(Aadarchi.sipocdiagramgenerator, "sipoc-diagram-generator", "Generates SIPOC (suppliers/inputs/process/outputs/consumers) diagrams in an asciidoc table, for each element.", $tags="")

And if I look into C4-PlantUML documentation, I can see that in Container diagram, technology is optional, but is defined before documentation.
Moreover, if I add a random technology text in the sipoc-diagram-generator, the text correctly appears as technology, and description is visible at the description place.
So problem seems two-fold.

[ ] A null technology generates a bug, while an empty technology String correctly puts the description in place
[ ] For elements dynamically added to the system, the description is correctly fetched from maven, but the technology isn't.

The second part seems to be due to the fact that no interesting dependency is found in the module. As a consequence we don't add Java as a technology, which in turn makes the technology string empty, which finally results in the string not being added to PlantUML and the rendering failing.

Okay ... it seems like hard injection of language was a mistake.
Indeed, to inject Java language, I first checked if some dependnecies were present and used that as an indicator of Java usage.
But it fails miserably when no dependency is important enough.
The method I will now use will be significantly harder.

Detect if some language runtime is detected in dependencies (by checking if dependency has the "language" tag)
If none is found, add a fake Java dependency (with the version) and link it to a fake mvnrepository artifact -the artifact will be created by https://github.com/Riduidel/aadarchi-technology-detector/issues/5


Question:  What to do when OneLogin is SP + IP

I have three applications that need to support Single Sign-on and we are looking into SAML.  It'd probably be easiest to just use OneLogin as a Service Provider and Identity Provider -- this makes sense, right?  All the demos I see are for creating a SP.  If I use OneLogin as my SP + IP, then these applications wouldn't be SPs, right?  How would I implement SSO via SAML using python-saml, then?
Thanks

Onelogin is able to act as an SP, in order to be connected with others Identity Providers, but at the end you will want to add SAML support to your 3 applications (build SPs) and connect it with Onelogin (IdP).
Possible scenario:
Salesforce IdP   ----- Onelogin (as SP) | Onelogin (as IdP) ----- app1
                                                                                |-----------app2
                                                                                |-----------app3

I recommend you to read how SAML works: https://github.com/jch/saml

@pitbulk, that's an excellent resource.  Thanks.  So, after reading, it's fairly clear that app1, app2, and app3 would be SPs here.
In looking at the demo-django I was expecting a little more (in terms of user provisioning via create_user), didn't see the logic in the templates, and got confused to what an SP actually was.
Thanks for your help and your work.  I'll likely be using this soon.

The demo-django is very basic and take care of the SAML stuff, logic to provision the user and other stuff is a task of the developer that integrates the django application.
But if you are using Django as your framework, take a look at:
https://github.com/KristianOellegaard/django-saml-service-provider
(it uses as base python-saml)


Setting the code in anaconda environment

Hi,
Could you give detail description of how to install and run polyply in anaconda environment (windows)?
I used pip install polyply and succesfully installed it. But, when I try to run on command line I get the following
'polyply' is not recognized as an internal or external command,
operable program or batch file.
I don't know how to fix it. Any suggestions ?

@NikPatsa I think it is the same problem as was discussed in #256. Can you have a look and see if this fixes your problem.


Fix runtime panic when trying to update operator controlled resources that don't have annotation or labels

Hi!
First of all, thanks for this awesome software, it helps us a lot (also Jaeger! :smile:).
This PR fixes the possibility of having runtime panics due to the operator trying to update annotations or labels on existing Kubernetes resources that don't have labels or annotations.
This happened to us when we upgraded from v1.11.0 to a newer version (v1.11.1 and v1.12.0), the operator listed the operator owned services and tried to update the annotations, it didn't have, so the map wasn't initialized and when updating it hit a panic due to the assignment on the map making the operator enter in crash loopback.
To fix it I initialized the annotation and label maps when they are nil, also I saw that this was on all the resources of the inventory, so I applied the same logic to all of the resources.
In the meantime, we managed to bypass the problem setting a dummy annotation on all the services controlled by the operator.
Here are tracebacks of the panic:
time="2019-05-23T11:48:16Z" level=info msg=Versions arch=amd64 jaeger-operator=1.12.0 operator-sdk=v0.5.0 os=linux version=go1.11.1
time="2019-05-23T11:48:16Z" level=info msg="Auto-detected the platform" platform=kubernetes
time="2019-05-23T11:48:16Z" level=info msg="Automatically adjusted the 'es-provision' flag" es-provision=false
E0523 11:48:18.127847       1 runtime.go:69] Observed a panic: "assignment to entry in nil map" (assignment to entry in nil map)
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/asm_amd64.s:522
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/panic.go:513
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/map_faststr.go:192
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/inventory/service.go:36
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/service.go:23
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:205
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:119
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:215
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/asm_amd64.s:1333
panic: assignment to entry in nil map [recovered]
        panic: assignment to entry in nil map

goroutine 503 [running]:
github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x108
panic(0x12ac620, 0x15b6ed0)
        /home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/panic.go:513 +0x1b9
github.com/jaegertracing/jaeger-operator/pkg/inventory.ForServices(0xc0002b4000, 0x3, 0x3, 0xc0002fc000, 0x3, 0x4, 0x0, 0x0, 0x0, 0x0, ...)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/inventory/service.go:36 +0x454
github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger.(*ReconcileJaeger).applyServices(0xc0006a6420, 0x1426656, 0x6, 0xc000a6e020, 0x13, 0xc0004657d0, 0x6, 0x0, 0x0, 0xc0004657e0, ...)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/service.go:23 +0x247
github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger.(*ReconcileJaeger).apply(0xc0006a6420, 0x1426656, 0x6, 0xc000a6e020, 0x13, 0xc0004657d0, 0x6, 0x0, 0x0, 0xc0004657e0, ...)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:205 +0x586
github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger.(*ReconcileJaeger).Reconcile(0xc0006a6420, 0xc0004657e0, 0x6, 0xc0004657d0, 0x6, 0x21be880, 0x1, 0xc00032cc00, 0xc000560d88)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:119 +0x93a
github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc000379720, 0x0)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:215 +0x18f
github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1()
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158 +0x36
github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc00039c0b0)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133 +0x54
github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc00039c0b0, 0x3b9aca00, 0x0, 0x1, 0xc000702360)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134 +0xbe
github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait.Until(0xc00039c0b0, 0x3b9aca00, 0xc000702360)
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
        /home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:157 +0x32a

Also happens on v1.11.1
time="2019-05-23T11:32:03Z" level=info msg=Versions arch=amd64 jaeger-operator=1.11.1 operator-sdk=v0.5.0 os=linux version=go1.11.1
time="2019-05-23T11:32:03Z" level=info msg=Versions arch=amd64 jaeger-operator=1.11.1 operator-sdk=v0.5.0 os=linux version=go1.11.1
time="2019-05-23T11:32:03Z" level=info msg="Auto-detected the platform" platform=kubernetes
time="2019-05-23T11:32:03Z" level=info msg="Automatically adjusted the 'es-provision' flag" es-provision=false
E0523 11:32:04.510526       1 runtime.go:69] Observed a panic: "assignment to entry in nil map" (assignment to entry in nil map)
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/asm_amd64.s:522
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/panic.go:513
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/map_faststr.go:192
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/inventory/service.go:36
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/service.go:23
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:205
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger/jaeger_controller.go:119
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:215
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/home/travis/gopath/src/github.com/jaegertracing/jaeger-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/home/travis/.gimme/versions/go1.11.1.linux.amd64/src/runtime/asm_amd64.s:1333
panic: assignment to entry in nil map [recovered]
        panic: assignment to entry in nil map

...

Thanks!

Ready for a new check!

@slok Thanks!


Feature request: save audio only

It would be very nice to be able to save audio track only.

Thanks for filing, but we don't intend to support this anytime soon. Can consider it down the road.