[VSCode] Microsoft AL Language support

Feature Request
Please consider adding the support for Microsoft AL Language.
Product and Version [VS/VSCode]: VSCode
OS Version [macOS/Windows]: Windows + macOS
IntelliCode Extension Version: for a future releases?
Target Platform or Language [e.g. Node.js]: Microsoft Dynamics Business Central / AL Language

Reopening due to erroneous bot closure. Apologies for any confusion


Exparams hierarchy

external_parameters was only available to the top level CloudFormation scope. Adding it to JSONable and using class hierarchy variables allows it to be accessed from within any block of the template.
Additionally, I added a few lines to cfndsl_spec.rb to ensure the params were being interpreted correctly.
Currently, this fails RuboCop because of the use of @@ class hierarchy variables. They can be replaced with the class_attribute pattern from activesupport. It's quite a lot of code to replicate the behavior, however.

Closed in favor of stevenjack/cfndsl#183


[TECHNICAl REQUEST] 20x AUI-2037 AUI-2038

Hi,
Here is my backport. My goal is to create an SDH based on this.
However, I have not tested it with portal yet. It works in Alloy-UI datatable demo.
Péter

https://github.com/peterborkuti/alloy-ui/pull/4


This is so awesome!

I know the issues page isn't really for this, but since private messages aren't a feature anymore...
I just wanted to tell you: You rock! I'm new to Xamarin development, and maintaining bitmaps for all those resolutions would have been a nightmare! So glad I found your project - keep up the good work!
Thanks,
Philipp

Thank you!
p.s. - I've moved the repo to https://github.com/jsmarcus/Iconize to improve CI


include secure reverse proxy setup

Updated gekko ui server install docs to include easy secure reverse proxy setup so people can securely access their gekko ui remotely from schoo.. i mean home or wherever =) I spent hours banging my head against a wall so figured I'd save people some hair as it wasn't so straight forward... for me anyways. Happy backtesting!

@generalectric Well done !
There is a missing  "}" at the end of your nginx config thought :)

Sorry for the delayed response!
Looks very good :)
One question: why the section on self signed certs? If people end up doing this they will only see flashing warnings in their browsers.

I added it so people that dont have a fqdn can still use dyndns with a self signed cert though it does produce a warning occasionally

Live here as well:
https://gekko.wizb.it/docs/installation/installing_gekko_on_a_server.html#Configuring-NGINX-as-a-reverse-proxy

We should have some instruction for EC2 / AWS too dealing with unsceure Nginx setups... AC2 makes it impossible to generate the SSL certificates!


Added "static" to inner BlockingQueueConsumer.DeclarationException

@panchenko , would be good if you'd provide some explanation of reason for such a change.
If we take a look to the source code around this BlockingQueueConsumer.DeclarationException, we'll see that there is no point which rethrows it to the caller - to the main start application Thread.
The reason not having it as a static do not allow to instantiate it without BlockingQueueConsumer - it's outer class.
So, I don't see reason to accept this change.
Thanks

@artembilan Inner classes without static have automatically generated field, referencing the outer class (and constructor to initialize it), if present it is used to access members of the outer class, but is not needed in this case. In byte code it looks like final BlockingQueueConsumer this$0. So the reason is a small optimization.
If an idea is restricting usage of it - I would suggest also changing visibility to package scope.

Ah! Yes. Good reason. Thanks!
No one day without a new knowledge!
However I can't merge your commit because it is based on the master branch.
Since this change is so simple I'm committing it to the master directly with my privileges..
For the future be sure that you create a new branch for changes.
And it would be better to start from JIRA ticket, rather than direct PR.
Merged as https://github.com/spring-projects/spring-amqp/commit/bc902e1c54af2adc2cdbc69bb46e9bb7e462d6ee


Cannot display holoviews plots with Panel in lightning.ai

Crosspost of https://github.com/holoviz/panel/issues/3643 as I don't know if this is a Panel/HoloViews issue or a lightning.ai issue
🐛 Bug
I'm trying to create a Panel+HoloViz crossfiltering example with lightning.ai. I can create other examples. See https://github.com/Lightning-AI/lightning/issues/13335, but the HoloViews one never serves.
To Reproduce
pip install panel==0.13.1 bokeh==2.4.3 lightning==2022.6.15.post2 holoviews==1.14.9

app.py
# Source: https://github.com/Lightning-AI/lightning/blob/master/docs/source-app/workflows/build_lightning_app/from_scratch.rst
# Source: https://github.com/Lightning-AI/lightning/blob/master/src/lightning_app/frontend/stream_lit.py
from __future__ import annotations

import pathlib
from typing import Callable, Dict, Union

import holoviews as hv
import lightning_app as lapp
import panel as pn
from bokeh.sampledata import iris
from bokeh.server.server import Server
from lightning_app.core import constants

Page = Union[Callable[[], pn.viewable.Viewable], str, pathlib.Path]

def page_crossfilter():
    pn.extension(sizing_mode="stretch_width")
    hv.extension("bokeh")
    scatter = hv.Scatter(iris.flowers, kdims=["sepal_length"], vdims=["sepal_width"]).opts(responsive=True)

    return pn.pane.HoloViews(scatter, sizing_mode="stretch_both")

class LitPanelPage(lapp.LightningWork):
    """Can serve a single page Panel app"""

    def __init__(self, page: Page, **params):
        """_summary_

        Args:
            page (Callable[[], pn.viewable.Viewable]): A function returning a Panel `Viewable`.
                Alternatively a path to a file containing a Panel application.
        """
        if isinstance(page, pathlib.Path):
            page = str(page)
        self._page = page

        self._server: Union[None, Server] = None

        super().__init__(**params)

    def run(self):
        """Starts the server and serves the page"""
        self._server = pn.serve(
            {"/": self._page},
            port=self.port,
            address=self.host,
            websocket_origin=self.websocket_origin,
            show=False,
        )

    def stop(self):
        """Stops the server"""
        if self._server:
            self._server.stop()

    def get_tab(self, name: str) -> Dict[str, str | "LitPanelPage"]:
        """Returns a *tab* definition to be included in the layout of a LightingFlow"""
        return {"name": name, "content": self}

    @property
    def websocket_origin(self) -> str:
        host = constants.APP_SERVER_HOST.replace("http://", "").replace("https://", "")
        return host + ":" + str(self.port)

class LitApp(lapp.LightningFlow):
    def __init__(self):
        super().__init__()
        self.lit_crossfilter = LitPanelPage(page=page_crossfilter, parallel=True)

    def run(self):
        self.lit_crossfilter.run()

    def configure_layout(self):
        return [
            self.lit_crossfilter.get_tab(name="Crossfiltering"),
        ]

if __name__ == "__main__":
    # lightning run app app.py
    app = lapp.LightningApp(LitApp())
elif __name__.startswith("bokeh"):
    # panel serve app.py --autoreload --show
    page_crossfilter().servable()

run with
$ lightning run app app.py
Your Lightning App is starting. This won't take long.
INFO: Your app has started. View it in your browser: http://<IP_ADDRESS>:7501/view
Launching server at http://<IP_ADDRESS>:62458

And see it loads forever

If instead I do
$ panel serve app.py
2022-06-23 07:33:25,018 Starting Bokeh server version 2.4.3 (running on Tornado 6.1)
2022-06-23 07:33:25,019 User authentication hooks NOT provided (default user enabled)
2022-06-23 07:33:25,026 Bokeh app running at: http://localhost:5006/app
2022-06-23 07:33:25,026 Starting Bokeh server with process id: 31292
2022-06-23 07:33:29,603 WebSocket connection opened
2022-06-23 07:33:29,603 ServerConnection created

It works

This works for me flawlessly on the latest version of Lightning (the one you posted should be). Screenshot of the running app:

It takes 1-2 secs for it to become visible on the UI after the spinner. Perhaps you need to manually reload the page?
Could you check your console (in the browser) for any errors (cmd+option+i on mac).

I'm on Windows. Could that make a difference.
The 1 min video below shows how it looks and that it never starts. My fan goes crazy while the server is running. So something is happening.
https://user-images.githubusercontent.com/42288570/175469514-7466e2c7-a2d7-431b-bfb5-73511ba8d605.mp4

I don't see any errors in the browsers console either

I would like to try out running it in Docker to see it working on Linux at least.
Dockerfile
FROM python:3.9.13-slim-bullseye

RUN pip install panel==0.13.1 bokeh==2.4.3 lightning==2022.6.15.post2 holoviews==1.14.9

ADD . .

ENTRYPOINT [ "lightning", "run", "app", "app.py" ]

docker build -f Dockerfile -t lightning .
docker run --expose 1-65000 lightning

How do I run the app on the address <IP_ADDRESS> instead of <IP_ADDRESS> to be able to access the app?

I can see that the function page_crossfilter starts running infinetely if I add a print statement
# Source: https://github.com/Lightning-AI/lightning/blob/master/docs/source-app/workflows/build_lightning_app/from_scratch.rst
# Source: https://github.com/Lightning-AI/lightning/blob/master/src/lightning_app/frontend/stream_lit.py
from __future__ import annotations

import pathlib
from typing import Callable, Dict, Union

import holoviews as hv
import lightning_app as lapp
import pandas as pd
import panel as pn
from bokeh.sampledata import iris
from bokeh.server.server import Server
from lightning_app.core import constants

Page = Union[Callable[[], pn.viewable.Viewable], str, pathlib.Path]

def page_crossfilter():
    print("creating plot")
    pn.extension(sizing_mode="stretch_width")
    hv.extension("bokeh")
    scatter = hv.Scatter(iris.flowers, kdims=["sepal_length"], vdims=["sepal_width"]).opts(responsive=True)
    return pn.pane.HoloViews(scatter, sizing_mode="stretch_both")

class LitPanelPage(lapp.LightningWork):
    """Can serve a single page Panel app"""

    def __init__(self, page: Page, **params):
        """_summary_

        Args:
            page (Callable[[], pn.viewable.Viewable]): A function returning a Panel `Viewable`.
                Alternatively a path to a file containing a Panel application.
        """
        if isinstance(page, pathlib.Path):
            page = str(page)
        self._page = page

        self._server: Union[None, Server] = None

        super().__init__(**params)

    def run(self):
        """Starts the server and serves the page"""
        self._server = pn.serve(
            {"/": self._page},
            port=self.port,
            address=self.host,
            websocket_origin=self.websocket_origin,
            show=False,
        )

    def stop(self):
        """Stops the server"""
        if self._server:
            self._server.stop()

    def get_tab(self, name: str) -> Dict[str, str | "LitPanelPage"]:
        """Returns a *tab* definition to be included in the layout of a LightingFlow"""
        return {"name": name, "content": self}

    @property
    def websocket_origin(self) -> str:
        host = constants.APP_SERVER_HOST.replace("http://", "").replace("https://", "")
        return host + ":" + str(self.port)

class LitApp(lapp.LightningFlow):
    def __init__(self):
        super().__init__()
        self.lit_crossfilter = LitPanelPage(page=page_crossfilter, parallel=True)

    def run(self):
        self.lit_crossfilter.run()

    def configure_layout(self):
        return [
            self.lit_crossfilter.get_tab(name="Crossfiltering"),
        ]

if __name__ == "__main__":
    # lightning run app app.py
    app = lapp.LightningApp(LitApp())
elif __name__.startswith("bokeh"):
    # panel serve app.py --autoreload --show
    page_crossfilter().servable()

$  lightning run app app.py
Your Lightning App is starting. This won't take long.
INFO: Your app has started. View it in your browser: http://<IP_ADDRESS>:7501/view
Launching server at http://<IP_ADDRESS>:52479
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
creating plot
...

https://user-images.githubusercontent.com/42288570/175474108-0fd33a2f-46dc-4654-ba82-fd01521c170d.mp4

Could it be @awaelchli that the lightning server requests a response from the Panel server, and that response is not coming as fast as anticipated, then it requests a response again and continues like that forever?
If I run the panel server in a separate process like below via Popen I would expect the server to run more independent on the lightning ai code. There should be no problems with threads etc. But I still see an infinite number of requests to see the Panel page.
app.py
from __future__ import annotations

import subprocess
from typing import Dict

import lightning_app as lapp

Page = str

class LitPanelPage(lapp.LightningWork):
    """Can serve a single page Panel app"""

    def __init__(self, page: Page, **params):
        """_summary_

        Args:
            page (Callable[[], pn.viewable.Viewable]): A function returning a Panel `Viewable`.
                Alternatively a path to a file containing a Panel application.
        """
        self._page = page

        self._server: subprocess.Popen = None

        super().__init__(**params)

    def run(self):
        """Starts the server and serves the page"""
        subprocess.Popen(
            [
                "panel",
                "serve",
                "app2.py",
                "--port",
                str(self.port),
                "--address",
                self.host,
                "--allow-websocket-origin",
                "*"
            ],
        )

    def stop(self):
        """Stops the server"""
        self._server.kill()

    def get_tab(self, name: str) -> Dict[str, str | "LitPanelPage"]:
        """Returns a *tab* definition to be included in the layout of a LightingFlow"""
        return {"name": name, "content": self}

class LitApp(lapp.LightningFlow):
    def __init__(self):
        super().__init__()
        self.lit_crossfilter = LitPanelPage(page="app2.py", parallel=True)

    def run(self):
        self.lit_crossfilter.run()

    def configure_layout(self):
        return [
            self.lit_crossfilter.get_tab(name="Crossfiltering"),
        ]

if __name__ == "__main__":
    # lightning run app app.py
    app = lapp.LightningApp(LitApp())

app2.py
# Source: https://github.com/Lightning-AI/lightning/blob/master/docs/source-app/workflows/build_lightning_app/from_scratch.rst
# Source: https://github.com/Lightning-AI/lightning/blob/master/src/lightning_app/frontend/stream_lit.py
print("starting")

import holoviews as hv
import panel as pn
from holoviews import opts
from bokeh.sampledata import iris

ACCENT = "#792EE5"
OPTS = {
    "all": {
        "scatter": {"color": ACCENT, "responsive": True, "size": 10},
        "hist": {"color": ACCENT, "responsive": True},
    },
    "bokeh": {
        "scatter": {"tools": ["hover"], "active_tools": ["box_select"]},
        "hist": {"tools": ["hover"], "active_tools": ["box_select"]},
    },
}

pn.extension(sizing_mode="stretch_width")
hv.extension("bokeh")

dataset = hv.Dataset(iris.flowers)

scatter = hv.Scatter(dataset, kdims=["sepal_length"], vdims=["sepal_width"]).opts(responsive=True)
pn.pane.HoloViews(scatter, sizing_mode="stretch_both").servable()

lightning run app app.py

https://user-images.githubusercontent.com/42288570/175478663-40108e14-16b8-4489-ab20-09e5ba00a3aa.mp4

Hey @MarcSkovMadsen.
Wow ! Awesome work with https://github.com/MarcSkovMadsen/awesome-panel-lightning.
In order to fix this bug, we need to increase the timeout here to 0.5: https://github.com/Lightning-AI/lightning/blob/15b64cf8bac457e47a19102dd8152ddfb1821b72/src/lightning_app/utilities/network.py#L51.
We are in the process of migrating the internal repo to the public, so it might take us an extra week, but I opened a fixed PR to the private repo.
Otherwise, do you have feedback on the Lightning App framework ? I think it would be interesting to use the dashboards to dynamically create some work with heavy lifting and use the results back in the UI.

Hi @tchaton
Thanks for your reply. Would it be possible for the application to change the timeout. Some applications like might need a timeout of several seconds. My experience from Panel and the Panel community is that for internal tools the time it takes to create and get the response is often not important. And also the applications in general might not be optimized for performance but instead to solve to bespoke domain problem for which there are no existing tools. And they are created by non-developers that don't have the skills to create performant applications.
I think lightning.ai looks promising for creating scalable apps and easily deploying them.
I would like to know how to run lighting in a Docker container to be able to test them on Linux (my laptop is windows). Basically I want to know how I can set the address to <IP_ADDRESS> instead of <IP_ADDRESS>.
I would also like to start understanding how I can use Panel to create an application that interacts with flows running in different processes. It should be easy to do with Panel as it is a reactive framework running on Tornado, using web sockets and supporting async, threading etc.


TTF for Featherity

Hi!
Is there any chance that Featherity can be compiled to TTF?
Thanks :hugs:

There may be a different way to do this but I can do this through an icon library tool I use called Nucleo. This includes eot, ttf, woff, woff2.
Nucleo-Fonts.zip

@rfbezerra created a script for generating Font files, maybe we check it out.
https://github.com/feathericons/feather/pull/608

@mishkaio That's really neat!
@ericfennis I don't have any of those tools installed locally, but we should be able to port it no problem 😄

Well, today I tried to build Featherity, to tell you if it works or not.
Maybe the tools have evolved since, so I'm able to build with 3 tools (without inkscape):

fontforge
sfnt2woff (npm)
fontcustom

It was build with success, with only one icon problem (icon-phone-call).
The same process worked well with Feather.
If you want to test, after install these tools, do a simple:
fontcustom compile ./icons -h -n Featherity -o build -F

I made a docker image to simplicate necessary steps to build a TTF font.
If u want to check, it is this project svg-to-ttf.
With that, its simple to build any ttf font from svg glyphs, e.g.:
docker run --rm -v "${PWD}":/fonts rfbezerra/svg-to-ttf -i ./icons -n Feather -u $(id -u)

@rfbezerra Sorry for the late reply. I was on vacation.
Thanks for your work on this! Looks awesome.
I'm currently working on the NPM package for featherity
First I want to release the package, including the subpackages for Vue and React, after that I will pick this up!

Just to know
Does the Workflow work correctly? 😅

I forgot to check, but it is working correctly!!
Link of the artifact.
I didn't test it yet.
But I don't know how we can publish this nicely?
My suggestion, maybe we need to add this to the new package, then we can serve it through unpkg.

Fixed by #100
Shortly I will create an solution for to download the icons


Smart client issue

Hi,
I have a Redis Cluster with 3 master nodes and 3 slave ones.
I'm using Predis version '1.0.1' and Redis 3.0.1
Here is my code below:
set('test','It works !') .PHP_EOL;
    echo "Successfully connected to Redis";

}
catch (Exception $e) {
    echo "Couldn't connect to Redis" .PHP_EOL;
    echo $e->getMessage() .PHP_EOL;
$pos =strpos((string)$e->getMessage(), 'MOVED');
        if ($pos === false)
        echo "Understood" .PHP_EOL;
else
        echo "Needs to relaunch with new server" .PHP_EOL;

$pattern = '/MOVED (\d+) ([\d\.]+)\:(\d+)/';
preg_match($pattern, (string)$e->getMessage(), $matches, PREG_OFFSET_CAPTURE);
$parameters = array((string)('tcp://' . $matches[2][0] . '/?password=secret'));
$redis = new Predis\Client(
        $parameters
        , $options));

echo $redis->set('test','It works !') .PHP_EOL;
?>
Here is what I'm getting when I launch my php code:
Couldn't connect to Redis
MOVED 15495 Z.Z.Z.Z:6379
Needs to relaunch with new server
OK
So I would like to know what I'm doing wrong for the client to automatically handle -MOVED or -ASK responses coming from Redis nodes please.
Thanks a lot !

Please don't open another issue when the very same matter is being dealt with in another one, albeit closed (see #259). Thanks.


exported custom resource exported fields use default values during _init()

Godot version
Godot Engine v4.0.beta4.official.e6751549c
System information
Kubuntu 20.04
Issue description
When a node has an exported field for a custom resource, exported fields in that resource refer to their default values when _init() is called in that resource.

When the same value is read in the owning node's _ready(), the correct value is returned.
Steps to reproduce
1)create a custom resource script with a field tagged with @export
2)create a node script with an exported field for the custom resource type.
3) assign non-default values to the exported resource's exported field in the inspector.
4)print the values of the fields- they'll be default rather than the inspector-assigned values.
This occurs whether the resource is local to the scene or saved in the file system.
Minimal reproduction project
customresourcetest.zip

Not a bug. _init is called when an object is initialized, right after it has been created. @export variables are filled after the object is initialized. Use _ready or NOTIFICATION_SCENE_INSTANTIATED if you need to access child nodes or exported values before the scene enters the tree.

I see.
I think this might be an issue with the docs, then. It's not clearly explained in the various places that the documentation mentions export. While the document about exports mentions that exported values are "saved with the scene", that doesn't imply this behavior to those who aren't aware of it. To those unaware, exported variables appear at face values to be overrides, or data that exists prior to running the project, so even if this behavior is intended it sure feels like a bug.

Not sure if this is still up for debate/consideration, but I would like to add my +1 for this functionality. Would be nice to support "derived" values in Resources. For example:
@export var vitality: int = 1

var health

func _init():
    health = vitality * 10

Maybe there is a better way to handle this, but right now my workaround is to use a getter (which I believe recalculates the value every time it is used):
@export var vitality: int = 1

var health:
    get:
        return vitality * 10

I think the problem reported here is really a bug. We need to be able to set the initial value of the Resource's properties.
My case is with a class that extends another class, like: Earth > Globe > Resource. Globe is a generic class with radius, but Earth needs to set this value to 6400000 and that must be done in Godot's editor. If I set the properties in the _init nothing happens and the property value is null in the tscn file. Since it's not possible to overwrite properties in the child classes, at least it should be possible to set them in the _init method.

A notification could be added for resources when they're done loading perhaps? Resources don't seem to receive the NOTIFICATION_POSTINITIALIZE notification, which could be used for the purposes people are wanting above I think.
`@export var vitality : int = 1
var hp
Example, does not work currently
func _notification(what: int) -> void:
if what == NOTIFICATION_POSTINITIALIZE:
hp = vitality * 10`

Seconding this. It may not be a bug, but it IS annoying.
My particular use case is, like most people I think, in a health component:
extends Resource
class_name HealthComponent

var health = 0
@export var health_max = 100

func _init():
	health = health_max

Here is a bare minimum for the custom health resource. I want to initialize my character's current health to their max health at scene start. I create a saved resource where I set health_max to 50 instead of the default 100. On scene start, it uses the default value defined in the script, rather than the exported value in the saved resource.
I would very much prefer if Resources had a _ready() function, like Nodes, to do this, particularly if _init() will continue to ignore inspector-defined values.

Adding a new notification should be discussed in a proposal, as feature proposals are tracked on the Godot proposals repository.

Is there a particular reason NOTIFICATION_POSTINITIALIZE never gets called in a Resource?

If I am understanding this correctly would this proposal close this issue for everyone? https://github.com/godotengine/godot-proposals/issues/5994

Stumbled on this multiple times while working with Resources in different scenarios.
My solution was to use call_deferred():
func _init() -> void:
	call_deferred("_ready") # To have default image shown. Otherwise magenta

func _ready() -> void:
	print("Network texture initialized. Setting default image ...)
	_set_image()

But it feels more as a hack and I have no idea how good it is and what problems it may bring in the future.

Hello, I'm having a similar problem with exported variable when initializing a dictionary with init
class_name StatModifiers extends Resource

var _MODIFIER_KEYS : Dictionary = GlobalVar.MODIFIER_KEYS

@export var modifier_base_dict: Dictionary = {}

@export var permanent_add: int = 0
@export var permanent_multiply: float = 1
@export var temporary_add: int = 0
@export var temporary_multiply: float = 1

func _init( _permanent_add: int = permanent_add,
	    _permanent_multiply: float = permanent_multiply,
	    _temporary_add: int = temporary_add,
	    _temporary_multiply: float = temporary_multiply) -> void:
	modifier_base_dict = {
					_MODIFIER_KEYS.PERMANENT_ADD:        _permanent_add,  # int
					_MODIFIER_KEYS.PERMANENT_MULTIPLY:   _permanent_multiply,  # float
					_MODIFIER_KEYS.TEMPORARY_ADD:        _temporary_add,  # int
					_MODIFIER_KEYS.TEMPORARY_MULTIPLY:   _temporary_multiply   # float
				}

Problem being when I use this from the inspector, I must create the instance of StatModifiers to be able to change the @export value, but by creating the StatModifiers it just initializes it with the default value, and changing the export variables doesn't change the dictionary anymore
Which honestly feels counter-intuitive as others have pointed before.

Isn't this what setters are for? It seems odd that the properties would be set before the constructor/_init is called. At least in C# the object needs to be constructed before the public properties are set so it makes sense why the behavior is this way.
In all of the examples in this thread, a setter function with an optional backing field would work fine to ensure that derived variables are set properly.
i.e. @Dinozor example:
class_name NetworkTexture
extends ImageTexture

var _default;
@export var default: Texture2D  :
    get:
        return _default
    set(value):
        _default = value
        set_image(value.get_image())

In my opinion, it's not really clear when _ready would be called. Would it be called again if properties change during runtime? That could be inefficient. Setters seem like the most straightforward way to guarantee that derived data is re-computed whenever that property changes.

Why would _ready be called again if properties change during runtime? It is used all over the place in Godot already and has a clearly defined place in the load hierarchy. It is called when a node "enters the tree"; in other words, as it is loaded into the scene. It occurs after _init, which happens when the node (or resource) is initialized into memory. What's confusing is that @export variables are only applied AFTER _init, which may be intentional but which leaves a gap in the initialization of Resources that should not have to be filled with getter/setter boilerplate or workarounds.
Also, in my particular use-case, I'm not looking for the derived data to be recomputed every time the property changes. I just want a default value that I can set in the inspector and which is applied to the resource when it is loaded (health that is set to max on scene load). You can do this already directly on nodes, but not Resources. Resources do not call _ready and do not trigger NOTIFICATION_POSTINITIALIZE. It's very unintuitive and contrary to the best practice Godot teaches you for Node scripts, and in my opinion it's a bug.
My personal workaround is I created my own _ready within the resource to initialize the defaults:
func _ready():
	health = health_max
	armor = armor_max

Which I then call within the Node's _ready:
func _ready():
	animator.play("idle")
	health._ready()

I'm not sure how that relates to this issue/discussion? Can you elaborate?

I'm not sure how that relates to this issue/discussion? Can you elaborate?

Well, most of the use cases people describe here are about assigning the value of an exported variable to another as soon as possible. Though in some cases it is modified.
Maybe this would be better?
@export field_name: String: # Field Name will become the name of the field in the editor, but not a variable
	var max_health = field_name
	var health = field_name / 2
	inherited_variable # at least until the support of interfaces

Though that basically makes field_name behave like a variable again. Then you could easily just make a setter.

No. I specifically want custom Resources to also utilize _ready, for parity with Nodes. This isn't about solving a specific use case (of which there are like 4 or 5 workarounds), it's about fixing Resources.

No. I specifically want custom Resources to also utilize _ready, for parity with Nodes. This isn't about solving a specific use case (of which there are like 4 or 5 easy workarounds), it's about fixing Resources. So your suggestion is not helpful.

I'm sorry that it isn't helpful and that I bothered you there. That wasn't my intention. As somebody else mentioned, there is a proposal to basically add a method that gets called when the resource and all variables have been initialized. As long as it isn't implemented, I fear that workarounds are the only solution we have. That's also why I suggested another one, because I until we get that method, finding the best workaround for each use case is the only thing we can do. And that I tried to help with, but apparently failed, so I'm again sorry for that.


cordova app crashes when calling the print method

Hello Sarah,
thanks on the good work on this project! I have an issue with this and hope you could help me out. I try to use this in the easiest way i could think of, but the app crashed (stops).
I use cordova 6.1.1 with android 5.1.0 and print-pdf 4.0.0
Pls find next some short snippet. The vars not in the code are filled (e.g. winTitle), so this is not the problem.
I have downloaded the file using file-transfer 1.5.0 into the cordova.file.externalDataDirectory + "myapp/" + filename.toInternalURL(). A test i use is e.g. filename = "cdvfile://localhost/files-external/myApp/File.PDF";
Can you help me with this?
Thanks in advance!
John
        if ( window.plugins.PrintPDF.isPrintingAvailable ) {

            window.plugins.PrintPDF.print({

                data: filename,
                type: 'File',
                title: winTitle,
                success: function(){

                    return true;

                },
                error: function(data){

                    data = JSON.parse(data);
                    helper.debug("Error", "printing failed:" + data.error);
                    return false;
                }
            });

        } else {
            return false;
        }

Hi
I seem to have this problem too, when testing on Android 6.0
I try to print PDF content that is a base64 encoded string.
I get no error code, my Cordova app just crashes.

Hey Guys, I am using version 6.2.0 for Android and it works well. It seems like maybe you are having a problem with the formatting of the pdf. How does the base64 string look? If its in the format data:application/pdf;base64,... the app will crash and so will the printing. To avoid this, remove that part of the string via, str.replace("data:application/pdf;base64,",  ""), it should run fine then. Maybe an example string should be added to the documentation

Hello David,
Thanks for the info. I will try and check back.
viele Grūsse Jens Döring
Mobil: 0173 54 55 150 eMail<EMAIL_ADDRESS>David --- Re: [sarahgoldman/cordova-print-pdf-plugin] cordova app crashes when calling the print method (#11) ---
Von:"David" notifications@github.comAn:"sarahgoldman/cordova-print-pdf-plugin" cordova-print-pdf-plugin@noreply.github.comKopie:"Shapeshifter70"<EMAIL_ADDRESS>"Author" author@noreply.github.comDatum:Di., 14.06.2016 17:50Betreff:Re: [sarahgoldman/cordova-print-pdf-plugin] cordova app crashes when calling the print method (#11)
Hey Guys, I am using version 6.2.0 for Android and it works well. It seems like maybe you are having a problem with the formatting of the pdf. How does the base64 string look? If its in the format data:application/pdf;base64,... the app will crash and so will the printing. To avoid this, remove that part of the string via, str.replace("data:application/pdf;base64,", ""), it should run fine then. Maybe an example string should be added to the documentation
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Did @dherre3's suggestion resolve this issue? I added a note about that to the README file. Thanks for catching that!

I am having a similar problem.  Android 6.0.1.  Ionic and Cordova in Visual Studio 2015.  Here is the code:
window.plugins.PrintPDF.isPrintingAvailable(function (isAvailable) {
if (isAvailable) {
window.plugins.PrintPDF.print({
data: document.body.innerHTML,
type: 'Data',
title: 'Printing',
success: function () {
alert('success');
},
error: function (data) {
data = JSON.parse(data);
alert('failed ' + data.error);
}
})
} ;
})
The print screen comes up in the background and it has "Preparing preview".  On top is an error box that says "Unfortunately, ionic-blankapp has stopped.".
If I follow the code this comes right after you send the print to the native function.
Any suggestions?
Thanks.

We dont use printing with base64 encoded data but a filename. The point was with us that the URI had to be different, e.g. we had to use the cdvfile-settings instead of absolute paths. It seems that the plugin crashes when the file is not a the expected place.
Please could someone remove my mail signature from the above answer?

Sorry Sarah, another senior moment.  I just realized that this plugin is for printing a pdf file that already exists.  I need one that creates the pdf from the web page.

I'm getting the same issue with this on Android 5.1.1 and the latest version of this plugin using cordova 6.0.0.
Printing works fine on iOS - just not android.
 window.plugins.PrintPDF.print({                                 data: btoa(pdfFile.output()),                                 type: 'Data',                                 title: 'Print Document',                                 success: function(){                                     Ext.Msg.alert('OK', 'Printing finished - please check your printer.');                                 },                                 error: function(data){                                     data = JSON.parse(data);                                     Ext.Msg.alert('OK', data.error);                                 }                             });
There is no data:application/pdf;base64, in the string. Has anyone made any headway on this issue - or have any suggestions?
Thanks.

Can i use printer without any printing selection options

What is your file path @mhk69 ? I am trying to use file type with filepath and my file is located in an expansion file, But I am not having any success.

@jbaartman
Our file path is hardcoded to be the same for each device. iOS and Android both exist at a folder called 'pdf'. There's a function that was written for us that given a directory and name will return a file path for that file.
All of our data is stored on the device (not SD card or external storage) - and at most is 1 pdf at a time. Each new generated pdf overwrites the old one in this given folder.
Have you tried looking at the File plugin (this plugin requires this)? There's more documentation here - https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-file/
Seems like there is some file.externallocations to store these. I'm forgetting if for printing I am passing in a cdvfile:// or a file:// type, though.

I am trying to print a simple string yet this won't work. Here's my code below:
`const dataString = 'Hello World!';
const encodedString = window.btoa(dataString); // data requires base64 encoded string
printer.print({
data: encodedString,
type: 'Data',
success: function() {
console.log('success');
return Plugins.STATUS_CODES.SUCCESS;
},
error: function(data) {
data = JSON.parse(data);
console.log('failed: ' + data.error);
return Plugins.STATUS_CODES.INTERNAL_ERROR;
}
});`
Also attaching a picture of the chrome debugger, proving that the data passed in print func is correct

Extra info:
Samsung Galaxy S7, Android version 8.0.0, Security patch level 1 Jan 2019


fix(@angular-devkit/architect-cli): fix package location

Reverting #445 seemed to get rid of the unrelated build failure here. Similar issue in #448 . FYI .

@akkumar correct, it is now fixed in master.


Lets do something about the Projects page

We should at least clean up the devclub github and have a link to that.
Are there any other projects that people think would do well in an open source format we could start development on?
Should we divide it into sections and have ".devclub projects" and "members projects" that way we can link to some of the stuff people in the club are working on?
I'm totally open to anything here so lets start this discussion!

For now It would be better to remove the link to the projects page, because navigating to it breaks the website and there's nothing there.  If we get a precedent of people coming to .devClub and presenting projects they're working on it would be a great place to showcase them though

Why do you say it breaks the website? I'd rather make it look good and have a link back to this github page possibly with a "Member Project Highlight" section that says coming soon than removing it. If you take a look at my website and how my projects are laid out with a little summary and a link that's what I have in mind. We could even put a list of contributors on each project. I don't know, I do not want to hide it until a later date though

Whoops, it actually broke the jekyll branch, not this one.  It goes back to index.html, not the github pages url

Noah Palansky would like to add Pencil Me In to the projects page

Tbh I posted the issue in the meeting to encourage people to post issues, but I think we could put in a good script to render a nice preview of people's repos, following the API here

I actually don't really like the way the github cards look. I'd much rather have something like what's on my website. www.landonbutterworth.com


blade create -t servicebuilder inside liferay-workspace doesn't create workspace build.gradle files

This pull request fixed we can't create short build.gradle file when we create a servicebuilder project under the liferay workspace.

Just started reviewing :) :octocat: Sent from GH.

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/lovettli/liferay-blade-tools/pull/1. :octocat: Sent from GH.

Pull request submitted to https://github.com/gamerson/liferay-blade-tools/pull/155. :octocat: Sent from GH.


iOS build error

info .../node_modules/react-native-pure-jwt/ios/RNPureJwt.m:3:9: fatal error
info
info : 'JWT.h' file not found
info #import "JWT.h"
^~~~~~~
info 1 error generated.
Build on iOS 12
Xcode 10.2.1
RN 0.59.5

Also just got this. Any fixes?

@zaguiini i've tried 1.5.x, 1.6.0 and 2.0.1 of this project, tried opening it in XCode, tried to install via Pods (though the instructions weren't very clear so I may not have done that correctly) and I either get that #import JWT or #import "JWT.h" cannot be found. Do you have any ideas? I'm kind of desperate, thanks in advance!

Have you added the dependency on the podfile and then run pod install?

@sarachicad you don’t need to manually link the project, only install it via pods

Thank you @zaguiini as I mentioned, I wasn't sure how to do that given that it's not in the docs, just add this to my Podfile? Thank you so much!!!
pod 'RNPureJwt', :podspec => '../node_modules/react-native/third-party-podspecs/RNPureJwt.podspec'

Thank you @zaguiini as I mentioned, I wasn't sure how to do that given that it's not in the docs, just add this to my Podfile? Thank you so much!!!
pod 'RNPureJwt', :podspec => '../node_modules/react-native/third-party-podspecs/RNPureJwt.podspec'

Quite close! That's the line:
pod 'RNPureJwt', :podspec => '../node_modules/react-native-pure-jwt/RNPureJwt.podspec'

Thank you guys.

@suthat could you please share your podfile / library version with me? i'm still having trouble, though the errors from this new approach are MUCH more promising lol. thank you!!

What errors are you having, @sarachicad?

Thank you @zaguiini I appreciate your interest & help -- I'll do a PR with documentation updates when I can figure this out to pay you back :)
This is my Podfile:
target 'app' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  use_frameworks!
  # Third party deps podspec link
  pod 'RNPureJwt', :podspec => '../node_modules/react-native-pure-jwt/RNPureJwt.podspec'

  # Pods for labl

end

This is my error:
### Error

Errno::ENOENT - No such file or directory @ rb_sysopen - /Users/sarainescalderon/Documents/docs/proj/node_modules/react-native-pure-jwt/RNPureJwt.podspec
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `initialize'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/external_sources/podspec_source.rb:19:in `block in fetch'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:86:in `titled_section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/external_sources/podspec_source.rb:11:in `fetch'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:825:in `fetch_external_source'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:804:in `block (2 levels) in fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:803:in `each'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:803:in `block in fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:64:in `section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:802:in `fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:107:in `analyze'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:266:in `analyze'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:174:in `block in resolve_dependencies'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:64:in `section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:173:in `resolve_dependencies'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:136:in `install!'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/command/install.rb:48:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/command.rb:52:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/bin/pod:55:in `<top (required)>'
/Users/sarainescalderon/.rbenv/versions/2.4.1/bin/pod:22:in `load'
/Users/sarainescalderon/.rbenv/versions/2.4.1/bin/pod:22:in `<main>'

Thank you @zaguiini I appreciate your interest & help -- I'll do a PR with documentation updates when I can figure this out to pay you back :)
This is my Podfile:
target 'app' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  use_frameworks!
  # Third party deps podspec link
  pod 'RNPureJwt', :podspec => '../node_modules/react-native-pure-jwt/RNPureJwt.podspec'

  # Pods for labl

end

This is my error:
### Error

Errno::ENOENT - No such file or directory @ rb_sysopen - /Users/sarainescalderon/Documents/docs/proj/node_modules/react-native-pure-jwt/RNPureJwt.podspec
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `initialize'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/2.4.0/open-uri.rb:37:in `open'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/external_sources/podspec_source.rb:19:in `block in fetch'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:86:in `titled_section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/external_sources/podspec_source.rb:11:in `fetch'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:825:in `fetch_external_source'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:804:in `block (2 levels) in fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:803:in `each'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:803:in `block in fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:64:in `section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:802:in `fetch_external_sources'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer/analyzer.rb:107:in `analyze'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:266:in `analyze'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:174:in `block in resolve_dependencies'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/user_interface.rb:64:in `section'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:173:in `resolve_dependencies'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/installer.rb:136:in `install!'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/command/install.rb:48:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/lib/cocoapods/command.rb:52:in `run'
/Users/sarainescalderon/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/cocoapods-1.6.2/bin/pod:55:in `<top (required)>'
/Users/sarainescalderon/.rbenv/versions/2.4.1/bin/pod:22:in `load'
/Users/sarainescalderon/.rbenv/versions/2.4.1/bin/pod:22:in `<main>'

Try doing pod setup and then running pod install.

Ok @zaguiini I did all that, but the Podfile wasn't showing up in the node_module folder so I cloned it from this repo, dropped it into the node_module folder and it's installing! But now I get this error:
Analyzing dependencies
Fetching podspec for `RNPureJwt` from `../node_modules/react-native-pure-jwt/RNPureJwt.podspec`
Downloading dependencies
Installing Base64 (1.1.2)
Installing JWT (3.0.0-beta.11)
Installing RNPureJwt (2.1.0)

[!] Error installing RNPureJwt
[!] /usr/bin/git clone git+https://github.com/zaguiini/react-native-pure-jwt.git /var/folders/k7/0jw3kdl14jjfc6j55sh0lxhm0000gn/T/d20190516-10954-14qnkes --template= --single-branch --depth 1 --branch 2.1.0

Cloning into '/var/folders/k7/0jw3kdl14jjfc6j55sh0lxhm0000gn/T/d20190516-10954-14qnkes'...
warning: Could not find remote branch 2.1.0 to clone.
fatal: Remote branch 2.1.0 not found in upstream origin

But the Podfile isn’t supposed to be in the node_modules folder? It is in the ios folder. Can you show me your Podfile?

Sorry, I mean the podspec file -- it didn't show up in the node_modules, so I had to add it manually. Then when I ran install it gave me the previous error.
Podfile:
  target 'labl' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for labl
  pod 'RNPureJwt', :podspec => '../node_modules/react-native-pure-jwt/RNPureJwt.podspec'
end

But the Podfile isn’t supposed to be in the node_modules folder? It is in the ios folder. Can you show me your Podfile?

Sorry, I mean the podspec file -- it didn't show up in the node_modules, so I had to add it manually. Then when I ran install it gave me the previous error.
Podfile:
  target 'labl' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for labl
  pod 'RNPureJwt', :podspec => '../node_modules/react-native-pure-jwt/RNPureJwt.podspec'
end

But the Podfile isn’t supposed to be in the node_modules folder? It is in the ios folder. Can you show me your Podfile?

Kinda strange it doesn't shows there. Can you please remove node_modules folder, retry yarn add react-native-pure-jwt and then pod install?

HOLY MOLY. That was 3 hours of my life I'll never get back.
Go back to the same dir that your package.json is in.
react-native unlink react-native-pure-jwt
cd ios/
rm -rf Pods/
pods install
cd .. && react-native run-ios

In Pod file of your project
Change this line
pod 'RNPureJwt', :path => '../node_modules/react-native-pure-jwt'
to this
`pod 'react-native-pure-jwt', :path => '../node_modules/react-native-pure-jwt/react-native-pure-jwt.podspec'
basically, the path is not right.
`


libboard: common: return FPGA_OK when skipping last interface in list

The current logic in print_eth_interface_info() to skip interfaces not
associated to the current board returns error when skipping the last
interface(s) in the list.
Avoid false errors being printed by resetting the result variable when
skipping an interface.
Signed-off-by: Martin Hundebøll<EMAIL_ADDRESS>

Coverage decreased (-0.004%) to 65.98% when pulling f2cebacdffc42f07bb87125cdb63270cc020a595 on hundeboll/eth-interface-info-fix into 8417202fb059af037dcddd66411036fd6b921103 on master.


AttributeError: module 'albumentations' has no attribute 'bbox_crop'

Thank you all for your hard work, I have encountered function not exist issue as follows, really looking forward to implement it!
Function not exist in import package, bbox_crop function is not found.
file:  fourm/data/modality_transfroms.py/DetectionTransform/bboxes_crop_resize/modality_transforms.py
code: line 689
package version:
# Name                    Version                   Build  Channel
albumentations            1.4.12                   pypi_0    pypi

import albumentations as A

bboxes = [tuple(A.bbox_crop(bbox[:4], x_min=xmin, y_min=ymin, x_max=xmax, y_max=ymax, rows=orig_height, cols=orig_width)) + tuple(bbox[4:]) for bbox in bboxes]

I found the following to work:
pip install albumentations==1.4.0

I solved this problem by reinstalling albumentations to old version too.

I solved this problem by reinstalling albumentations to old version too.


Revert back to version 0.6

Wikipedia has now withdrawn support for client side MathJax. Can you revert back to the version which did not rely on this version.

Can you please elaborate more on your problem? I see no issues with this extension so far.

Yes it does seem to look alright. I think my preferences were set wrong and it seems to need PNG mode. I've a feeling they may drop that node at some point in the future.

The PNG removal task is here: https://phabricator.wikimedia.org/T74240 This would break this extension.

Oh, I see what you mean now. But then either MathJax or some other vectorized rendering will be used and we will not need the extension at all.
Nevertheless, the Wikimedia config is now embedded to the extension (see texvc.js), so this PNG removal task should not affect functionality. Some of these settings have been used for a long time. I just made them more consistent in the last release.

There is a bit of a battle over the future of MathJax on wikipedia at the moment. https://phabricator.wikimedia.org/T99369 The devs don't want to support MathJax anymore instead preferring a MathML/SVG solution. Alas both don't look as good as MathJax, so there might be more people using extension. I've mentioned it at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Mathematics.
What might be nice is if it triggers when using the raw LaTeX preference option.


[MRG] Add phy/gui/static files

Fix bug with phy/gui/static/*.html files not installed.

Ready to merge @nippoo


[Game Request] Kono Ozora ni Tsubasa o Hirogete Cruise Sign (PlayStation 3)

I'm trying to extract some of the files from this version of the game so i could create a uncensored/restoration patch using material from Flight Diary (since i'm certain it's based on that when they made the PS3 port) but problem is, despite that some of the files outside the se.cpk and voice.cpk opens up just fine with their audio files intact, while the image files on the other hand refuses to be read so i can't do the replacements.
is there a way you can find a way to be able to read them and then able to repack back to .cpk after making the changes?
if you need the file to see it, i can send it over real quick: https://gofile.io/d/CkclZv

The files in bg.cpk and ev.cpk should be compressed using lzss stream. They can be extracted and added with spc or bip suffixes, and then opened as a zip using the current version of GARbro, which will give you the original files in their uncompressed state.
The even-numbered files in ev.cpk can be manipulated in this way to get a picture file that appears to be in RGBA format, but which has about 10% redundancy, and may be handled similarly to the BIP-PS2 format, but the two are not the same. bg.cpk contains files that may be encoded as DXT or something similar, and which are only a quarter of the size of the RGBA format. The image sizes for both are written in 0x88~0x8B, Little Endian, int16 or uint16.
I'm not sure what to do next.

Appreciate it, will give that tool a try, thank you very much


Update repository name from zettio to weaveworks

Replaced all occurrences of 'zettio/' with 'weaveworks/'.
Note that the DOCKERHUB_USER remains 'zettio', which is necessary until we release images under the new name.
The expected process for next release is:

build, test and push to zettio/weave:some_specific_tags
update the release script to change DOCKERHUB_USER to 'weaveworks'
build, test and push to weaveworks/weave:specific_tags
update the documentation to change the Docker image name from zettio to weaveworks
push the documentation change

bin/release has GITHUB_USER=${GITHUB_USER:-zettio}.  Sure about that?
That's the only remaining zettio reference that looks dodgy to me.

OK; I changed both the GITHUB_USER and the DOCKERHUB_USER since I couldn't think why they should be different.

Re-pushed with GITHUB_USER updated and DOCKERHUB_USER left at 'zettio', in case we want to do the next release to there.

I still wonder why  GITHUB_USER in bin/release is not changed to weaveworks.  According to my understanding of the purpose of that script, changing  GITHUB_USER (but not DOCKERHUB_USER) will give us the option of doing another release while the docker user name remains zettio.  It seems pretty unlikely that we'll want to do that, but it is a logical possibility.  To put it another way, I'm not sure what is special about the GITHUB_USER in bin/release that explains why it should not be changed.
It's obviously a minor thing.  All I'm asking for is a rationale.

I did change GITHUB_USER in bin/release, in 632cc3f

I did change GITHUB_USER in bin/release, in 632cc3f

Ah yes. ETOOEARLY.

LGTM. @dpw mind merging this? It's rather more urgent than I thought given that currently our beloved travis-ci builds are failing elsewhere (see, e.g. #534).

github pages updated


Chart content is overflowing constraining widget's boundaries

As the title says, the chart widget is overflowing if no margins are added manually to "fix it":

The blue background in the above image is set on the containing widget. As can be seen, the axis labels are properly distanced from the left and bottom boundaries of the container, but not from the top and right boundaries.

Any updates/ workaround on this one?

You can try to put padding around your chart with top and right values as a workaround.
But I agree we must fix it internally.

@imaNNeo
It seems that the default value of fitInside can solve this problem, so should this problem be turned off?
  const SideTitleWidget({
    super.key,
    required this.child,
    required this.axisSide,
    this.space = 8.0,
    this.angle = 0.0,
    this.fitInside = const SideTitleFitInsideData(
      enabled: false,
      distanceFromEdge: 0,
      parentAxisSize: 0,
      axisPosition: 0,
    ),
  });

@imaNNeo It seems that the default value of fitInside can solve this problem, so should this problem be turned off?

I think the default value works well for most of the use-cases.


Cannot read property 'container' of undefined

Versions:

VueJs: 2.5.16
Vee-Validate: 2.1.0-beta.8

Description:
console throws: Uncaught TypeError: Cannot read property 'container' of undefined
and this happens even only by adding vee-validate to the bundle
Any clues? any help?
Steps To Reproduce:

@logaretm Thanks for the response, renamed errorbag but no luck, only what I can find that error comes form here:

besides vee-validate I only use momentjs and vue-good-table
I have rollupjs bundling so not sure that I can reproduce it on jsfiddle as it won't be the same thing as on my env.

Sorry for the late response. You can create a minimal repository that reproduces the issue, I will take a look then.


Gh 1826 jackson 2.9

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@c59e14b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1858   +/-   ##
==========================================
  Coverage           ?   64.47%
  Complexity         ?     2011
==========================================
  Files              ?      729
  Lines              ?    23691
  Branches           ?     3092
==========================================
  Hits               ?    15275
  Misses             ?     7160
  Partials           ?     1256

Impacted Files
Coverage Δ
Complexity Δ

...a/uk/gov/gchq/gaffer/operation/OperationChain.java
64.02% <ø> (ø)
23 <0> (?)

...r/data/elementdefinition/view/NamedViewDetail.java
0% <ø> (ø)
0 <0> (?)

.../elementdefinition/view/ViewElementDefinition.java
62.5% <ø> (ø)
0 <0> (?)

.../gchq/gaffer/graph/hook/OperationChainLimiter.java
91.3% <ø> (ø)
0 <0> (?)

...va/uk/gov/gchq/gaffer/named/view/AddNamedView.java
77.41% <ø> (ø)
17 <0> (?)

...n/java/uk/gov/gchq/gaffer/operation/Operation.java
63.15% <ø> (ø)
12 <0> (?)

.../uk/gov/gchq/gaffer/graph/hook/UpdateViewHook.java
89% <ø> (ø)
0 <0> (?)

.../gchq/gaffer/data/elementdefinition/view/View.java
66.06% <ø> (ø)
0 <0> (?)

.../operation/handler/ScoreOperationChainHandler.java
80.32% <ø> (ø)
0 <0> (?)

...gchq/gaffer/named/operation/AddNamedOperation.java
92.1% <ø> (ø)
23 <0> (?)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59e14b...2f9ddd4. Read the comment docs.


HWKAPM-695 | Docker hub fails to build java-cassandra

https://issues.jboss.org/browse/HWKAPM-695
@objectiser could you please review?

@pavolloffay LGTM :+1:


feat - restructuring

Major restructuring
I think this should be considered a 'breaking' change. While nothing should change for 'users' of the documentation, some restructuring happened and people relying on overwriting elements may need to do something different.
CSS Grid
The basic layout is a 2D layout, that's what CSS grid is made for. I used Flexbox for this because I didn't understand how to combine everything I wanted (sticky header, off-canvas sidebar, etc.) with CSS grid. Now I do. This allows getting rid of a few unnecessary wrapper div elements that were only there to push one element away from another.
Alpine JS
Using Alpine, I can reduce the amount of custom JavaScript for simple interaction. This commit uses Alpine for showing the navigation menu and search pane on small screens. The rest is handled in further commits.
Restructuring
The aim is to allow easy overwriting of blocks with custom Jinja2 templates without breaking the overall structure of the theme. Needs testing.

The integration of alpine js is a little bit too ambitious for now. I'll separate the work for now.

The integration of alpine js is a little bit too ambitious for now. I'll separate the work for now.


Helm lookups are not executed

While doing some work on the Piped Helm Chart, I realised that it relies on the lookup Helm function, which by default does not run when helm template is executed. This requires the --dry-run=server flag to be passed to Helm when executing.
Ideally, we are able to activate this flag only when necessary, maybe with a dryRunServer or enableServer(?) parameter in https://github.com/hall/kubenix/blob/main/lib/helm/chart2json.nix.
I don't super love the idea of using this since it could break the reproducibility Nix offers, but some charts do rely on this and are incompatible with Kubenix.

You’d have to disable the sandbox and the process of generating manifests would no longer be pure and reproducible.

I feel that it will be hard to fix because runCommand runs in a nix builder which may or may not connect to internet and the credentials to the cluster can't be passed easily, too.
The only way to make this "declarative" would be to provide state from outside to helm, like in "fetch all the resources info from the cluster in a user ran script, then feed this file to kubenix and then helm". I don't think it is something supported by helm itself


Upgrade react-side-effect

Do you want to request a feature or report a bug?
Bug: currently the version of react-side-effect that's currently used is causing deprecated warnings to be thrown in react@16 due to its usage of componentWillMount.
What is the current behavior?
When mounting components in a react@16 or above environment, deprecated warnings are thrown.
If the current behavior is a bug,
please provide the steps to reproduce and if
possible a minimal demo of the problem.
Your bug will get fixed much faster if we can run your
code and it doesn't have dependencies other than React and react-helmet.
Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or
CodeSandbox (https://codesandbox.io/s/new) example below:
Use Helmet in a react@16 environment or above.
What is the expected behavior?
Warnings are not thrown.
Which versions of React and react-helmet, and which browser / OS are affected by this issue?
Did this work in previous versions of React and/or react-helmet?
React@16+

+1

+1

+1

+1


Update Release Notes to include info about PRs 2016/01/14 - /08/16.

Manual test script:

Go to /observer/news

Result: You should see one-liners about most of the 2016 PRs.

Coverage remained the same at 84.899% when pulling 1ecb5dfa543152bad774684f182e74d8dc6093f0 on JoeCohen:update-release-notes into 22deee6a65e5541d8428d9e6bd317fbe70d10229 on MushroomObserver:master.

Coverage remained the same at 84.921% when pulling 7b592fa5ec8ea7f3f7120ec04a7a70fed42e618a on JoeCohen:update-release-notes into 73137447c4363452b35f794f7815f6a251939ecb on MushroomObserver:master.


List the members of the batch (read BatchRegistry contract)

Goal
Show the current members of your batch in the app.

Show it on the main page or create a page (/builders) listing all the builders registered in the BatchRegistry contract (see #10)
Each builder should link to their personal profile (see #9)

Also I just made a simple list of addresses, that link to builder profile. Maybe we could extract the ENS profile picture and display some nice cards instead. What do you guys think?

@arjanjohan The BatchRegistry.sol contract allows to checkIn multiple times but only the first time it will send you the reward. If you use events for checking who checkedIn, you can filer for wasFirstTime param equals true.
const {
  data: events,
  isLoading: isLoadingEvents,
  error: errorReadingEvents,
} = useScaffoldEventHistory({
  contractName: "BatchRegistry",
  eventName: "CheckedIn",
  fromBlock: 31231n,
  watch: true,
  filters: { first: true },
  blockData: true,
  transactionData: true,
  receiptData: true,
});

You will get wallets not duplicated I think. Hope it helps

@arjanjohan can you submit a PR so I can help you with the development process? What do you think about it?

Hi, I started working on this issue. I will post a PR in case somebody else want to help :)


are created channels and shared files publicly visible and available + how to share ?

Hi just found out about the project and would like to test it out.
Created my own channel and shared a file.
Is this channel and its shared file publicly visible and available for anyone to download (i.e. without any security measures ?).
How do i inform the other party of the file i wish to share ?
Share him the channel name ?
Share the file hash ?

Its sort of public but not blatantly obvious, your channel name is public info on the blockchain. So anyone that would put in the effort can find it, and download the files you share there. To share the files with a someone else you would tell them the channel name indeed, they can then join and find the files.

ok so basically there's no real privacy and/or protection for the files shared, like f.ex. by protecting access to either the channel or the files by a password ?
i just tested a file download to make sure it works, but is there a way to interrupt it ?
Don't see any options for that.

ok well, maybe specific file sharing could be implemented as an option to the end user ?
There might be files i wish to make publicly available, others only to specific groups...
Also, when putting multiple files for sharing, is there a way for the downloader(s) to download them one by one and not all together ? Looks like all files get shared simultaneously which yields very low transfer speeds.

ok well, maybe specific file sharing could be implemented as an option to the end user ?
There might be files i wish to make publicly available, others only to specific groups...

Definitely possible.

Also, when putting multiple files for sharing, is there a way for the downloader(s) to download them one by one and not all together ? Looks like all files get shared simultaneously which yields very low transfer speeds.

The only way is not to queue them all at the same time, or pause the ones you dont want to simultanously download.

Definitely possible.
Thanks, that would be great !

The only way is not to queue them all at the same time, or pause the ones you dont want to simultanously download.
It would be nice though to be able to both batch download a given set of files, while having an option to limit the number of simultaneous downloads allowed, that'd be helpful when bandwith is an issue...

another thing that would come in handy (shan't start a new thread just for that) would be the ability to select several files at once for removal. For the moment this needs to be done manually one by one. I do can select multiple files at once with a right-click, but only to start or pauze sharing, not removing them.

any approximate ETA for those features ? I see the desktop app hasn't received any updates for almost 2 years now. Hope the app is still under active development.

I don't have an ETA for you, surge has been in development for over two years in total, from the initial proof of concept, to the first release, and the the completely redesigned frontend and backend for version 2. It has been well received but usage after the initial release surge has been virtually zero. So after our rather sizable effort we have dropped active development for it. We have opened up the license to a much more open license, and I will definitely review, work with and merge community efforts in form of pull requests. So if you want these features, the fastest course of action would be to open up a PR.


Respond to feedback on CIS scan docs

For this this PR:

I added the information about the new columns in the report
I validated the test descriptions against the 1.5.0 benchmark (they didn't change)
On the configuration page it now says the default profiles and benchmarks should not be edited. (It already said that in the benchmark configuration section, but now it also says that in the profile configuration section.)
It now says that all the tests that are skipped and NA - all will be counted as Not Applicable in the v2.5 report. The skipped test count will only mention the user-defined skipped tests.
The RBAC section says that in Rancher, only cluster-owner and global-admin have admin access by default.

lgtm


Should MVT tiles currently work?

TO REPRODUCE THE ISSUE, FOLLOW THESE STEPS:
Sample scene file excerpt:
import: https://mapzen.com/carto/refill-style/4/refill-style.yaml

sources:
    _dots:
        type: MVT
        url: "{z}/{x}/{y}.mvt"
        max_zoom: 14

RESULT:
Console log errors like:
Tangram v0.11.6 [warn]: tile load error(s) for _dots/15/2639/6359/14: skip@https://mapzen.com/tangram/0.11/tangram.min.js:7:8933
readFields@https://mapzen.com/tangram/0.11/tangram.min.js:7:5731
r@https://mapzen.com/tangram/0.11/tangram.min.js:8:17905
n@https://mapzen.com/tangram/0.11/tangram.min.js:8:15787
readFields@https://mapzen.com/tangram/0.11/tangram.min.js:7:5697
r@https://mapzen.com/tangram/0.11/tangram.min.js:8:15739
value@https://mapzen.com/tangram/0.11/tangram.min.js:13:30641
https://mapzen.com/tangram/0.11/tangram.min.js:13:21897
s@https://mapzen.com/tangram/0.11/tangram.min.js:2:8838
https://mapzen.com/tangram/0.11/tangram.min.js:2:8960
l@https://mapzen.com/tangram/0.11/tangram.min.js:1:31540
promiseReactionJob@[native code]

EXPECTED RESULT:
Dots matching what I’m seeing with GeoJSON tile content.
ENVIRONMENT:
Tangram v0.11.6, Safari Version 9.1 (116<IP_ADDRESS>), OS X 10.11.4 (15E65). The tiles are generated with Tippecanoe 1.15.1.
A sample tile response: http://mike.teczno.com/img/tangram-sample-tile-12-2637-6358.mvt

@migurski
I'd expect something more like:
import: https://mapzen.com/carto/refill-style/4/refill-style.yaml

sources:
    _dots:
        type: MVT
        url: http://mike.teczno.com/img/tangram-sample-tile-{z}-{x}-{y}.mvt
        max_zoom: 14

or
import: https://mapzen.com/carto/refill-style/4/refill-style.yaml

sources:
    _dots:
        type: MVT
        url: localhost:80/path/to/tiles/{z}/{x}/{y}.mvt
        max_zoom: 14

And check if your tiles are MVT or GeoJSON format (the extensions and type will need to match).

I tried making the URL fully-qualified and got the same errors in the console:
sources:
    _dots:
        type: MVT
        url: "http://<IP_ADDRESS>:5000/{z}/{x}/{y}.mvt"
        max_zoom: 14

So that didn’t help. I know that the data source works, because this is displaying dots correctly:
sources:
    _dots:
        type: GeoJSON
        url: "{z}/{x}/{y}.json"
        max_zoom: 14

Kerby dots!
On Mon, Jan 9, 2017 at 10:02 PM, migurski<EMAIL_ADDRESS>wrote:

I tried making the URL fully-qualified and got the same errors in the
console:
sources:
_dots:
type: MVT
url: "http://<IP_ADDRESS>:5000/{z}/{x}/{y}.mvt"
max_zoom: 14
So that didn’t help. I know that the data source works, because this is
displaying dots correctly:
sources:
_dots:
type: GeoJSON
url: "{z}/{x}/{y}.json"
max_zoom: 14
[image: screen shot 2017-01-09 at 10 01 41 pm]
https://cloud.githubusercontent.com/assets/58730/21795508/3b1d4bb8-d6b7-11e6-9080-70e19b2895ed.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram/issues/478#issuecomment-271493961,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO9Mv5wiymFsffvRus8yCZ65s8UL3ks5rQx7vgaJpZM4LfBbB
.

Yeah! 100% copied from Dotspotting down to the colors and radii. :)

All the Mapzen house styles are driven by Mapzen's MVT tiles, we periodically test against Mapbox-served tiles as well, and some users have created and used their own MVT tiles (Reuters lead map is an example), so yes -- they work.
No one that I'm aware of had tried tiles made with Tippecanoe with Tangram, which made me suspicious. We use Mapbox's own JS PBF decoder (https://github.com/mapbox/pbf) and MVT reader (https://github.com/mapbox/vector-tile-js). The error you are seeing is deep within the PBF decoder, which suggested an issue with the file encoding itself (or not matching the expected schema for decoding).
I noticed we are not running the most recent versions of those libraries in Tangram, so I tried upgrading locally but saw the same errors.
Looking more closely at your file (just eyeballing), it didn't look like what I'm used to seeing from others. I recalled that Tippecanoe outputs MBTiles (so I presume you extracted this from there), and that these are often further compressed w/gzip.
So I tried unzipping your tile file and it now loads fine for me locally.

Note that when you do render these, you should set collide: false (unless you actually want to make sure they don't overlap at all), and I'm also seeing some weird visual behavior (unrelated to this issue or MVT) that I've documented in #481 and will follow up on there.

Thanks; I had noticed the gzip as well and thought it was a convenience feature of MVT. Looks more like a convenience of MBTiles, maybe something to document as part of https://github.com/mapbox/mbtiles-spec/pull/46.

Also, definitely using collide: false based on Rhonda F's tutorial. My scene file is here if you have any other tips: https://github.com/openaddresses/dotmaps/blob/master/Tiler/templates/scene.yaml

Hm, I tried this with gunzipped MVT content from Tippecanoe. There are no more console errors, but also no data on the map. I tried two methods: decompressing the data and returning it raw, and leaving it compressed but passing a Content-Encoding: gzip header. Both showed identical behavior.

I suspect you may be missing a layer value in your data source, here: https://github.com/openaddresses/dotmaps/blob/master/Tiler/templates/scene.yaml#L28
When a file that is a single GeoJSON FeatureCollection is served, Tangram treats it as a single-layer data source, and will use that whenever the the source is specified with just data: { source: some-geojson-source }.
MVT always has named layers (even if there's only one), so that behavior currently doesn't apply: you have to explicitly indicate the layer name. I took a look at that file and it looked like it had a layer named dots, so I used that.
For example:
    _dots0:
        data: { source: _dots, layer: dots }

Alternatively, if not data source layer was specified, Tangram will use the scene layer name as a default value (because these often match). So this should also work:
    dots:
        data: { source: _dots }

Give that a try?

Works beautifully, thanks.

Yay
On Wed, Jan 11, 2017 at 2:26 PM, migurski<EMAIL_ADDRESS>wrote:

Works beautifully, thanks.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram/issues/478#issuecomment-271968588,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABBXaJUvXiTfd21xLCSmXMRyTaqQGQRks5rRSzPgaJpZM4LfBbB
.


basic changes

you should propose tihs change

We want to check if it is null because it's a good programming practice. It may return null in the future if Valve does something odd with csgo


Make better UI

Hello
I think Bagisto need better UI.
Please make modern UI for it.

@alighasemzadeh For sure.
We are making it better day by day on both frontend and backends, check for new releases.

@prashant-webkul
no it is really old.
sth like digikala.com is good

@alighasemzadeh We are understanding your concern. But if you see the code there is a separate module in packages called "Themes". By using this package you can make your own theme and publish it separately for your own storefront.


docs(samples): Update metadata and arguments

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #229


Strict compile contrib/backup

This PR fixes #

Pull Request Test Coverage Report for Build 236640007

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.066%

Totals

Change from base Build 236593911:
0.0%

Covered Lines:
18934

Relevant Lines:
44303

💛  - Coveralls


delete recursively

@chanseokoh @loosebazooka I think I found the missing piece that caused this to fail on Windows the last time we tried this.

@elharo is there a bug to link this PR to?

I don't think so, just a TODO

In that case perhaps just add more info about what this PR fixes to the change description?

FTR: https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/2880#issuecomment-370256930

Updated description

tldr; deleting directories has been a hole in Java's cross-platform story for 20 years and I trust the Guava team to have put more time and effort into thinking out the corner cases and working around them than we have.


output in turtle or trig

Hi, today we discussed whether output from CoW could be presented as turtle rather than nquads. @RoderickvanderWeerdt mentioned this might already exist in the code. if so it would be something to 'reactivate' AND activate in the cattle service. Moreover, 'trig' would be even better than turtle, so that we be awesome to have as well!

hi thanks to @RoderickvanderWeerdt we now have turtle.


File organization

Hi, really simple and useful plugin you made here!
If I could make a suggestion though, right now the file layout for this repo will pollute people's project ROOT, which is kinda bad practice and is how conflicts end up happening.
I would really recommend moving the example files you have in the root to something like root/addons/bmod_examples/
This way it won't pollute on default or automated installations and future updates of the addon, and it gives a singular folder for people to also uncheck inclusion of the example assets.
Thanks!

Hi! I think the proper way to address this issue is to edit .gitattributes so that Godot Asset Library ignores folders and files that are not part of the addon: https://docs.godotengine.org/en/latest/community/asset_library/submitting_to_assetlib.html#recommendations
I thought that I already did it but turns out I didn't. So I edited it and a new version on is on review in Godot Asset Store. The new version should be up whenever it's approved. Thanks for the feedback!


ReserveKey in CommitTransaction

Seems that reservekey is no longer needed in CommitTransaction

Reserve these parameter for possible usage on the original design


Auto Link Text does not always work

Seems to happen mostly when the app starts and opens existing tabs.
It also seems like the current implementation of Auto Link Text takes longer to run, and the moment when links get replaced is noticeable.
These problems didn't exist in the original implementation.
Potentially connected to the note cache and note resolution code.

Auto Link Text feature has been removed


Append to Marten event streams with StreamAction as a return value

Check this out a little bit first.

Nah, just use IMartenAction


oidc: add tcp keep alive to idp

This PR adds a tcpkeepalive to the IDP provider cluster of OIDC.
This is a workaround before retry is supported in Envoy upstream. https://github.com/envoyproxy/envoy/issues/33572
Fix: https://github.com/envoyproxy/gateway/issues/3178

id prefer to understand what is happening in the envoy side, and why its reusing the connection even after receiving an RST, so prefer if we collected cluster metrics and logs in debug/trace level before we proposed a fix

Here is a look at the metrics when we encountered this issue multiple times over one day. It seems like there is a strong correlation between instances of OAuth flow failed errors and the envoy_cluster_upstream_cx_destroy_remote_with_active_rq metric increasing. I've attached logs in debug level in the linked issue.


64bit Integer

The current decoder decodes msgpack's int 64 (0xd3) as a JS's Number which means double.
https://www.npmjs.com/package/node-int64

JavaScript Numbers are represented as IEEE 754 double-precision floats. Unfortunately, this means they lose integer precision for values beyond +/- 2^^53. For projects that need to accurately handle 64-bit ints, such as node-thrift, a performant, Number-like class is needed. Int64 is that class.

It looks fit for us as node-int64 has internal raw Buffer object with big endian byte sequence.

One problem found: node-int64 supports only signed int64. We need both signed and unsigned.

int64-buffer supports both Uint64 and Int64: https://www.npmjs.com/package/int64-buffer

0.1.18 published.

Hey @kawanet, I'm trying to use msgpack-lite in the browser and it seems that int64-buffer isn't working there for some reason. Here's what happens:
write-type.js:131 Uncaught TypeError: Cannot read property 'isUint64BE' of undefined

I'll dig into it and hopefully post a solution here.

Do you use browserify, webpack or  the pre-built version of dist/msgpack.min.js?

I'm using webpack.

Thanks. I check it with webpack then. It's tested with browserify but not with webpack in fact.

It seems it works with webpack as well. Try the most recent version of modules:
npm install --save<EMAIL_ADDRESS>npm install --save<EMAIL_ADDRESS># this is not needed

If you still fail, please add another issue to tell your webpack config etc.

Does this mean msgpack-lite can now encode 64 bit integers without monkey patching?

Does this mean msgpack-lite can now encode 64 bit integers without monkey patching?

Right. It uses int64-buffer the 64bit container object.
var Int64BE = require("int64-buffer").Int64BE;
var msgpack = require("msgpack-lite");

// sample big value
var bigstr = "18446744073709551615"; // 2^64-1
var bignum = parseInt(bigstr); //<PHONE_NUMBER>3709552000 (NG)
var bigbuf = new Uint64BE(bigstr);
console.warn(Uint64BE.isUint64BE(bigbuf)); // true
console.warn(bigbuf + ""); //<PHONE_NUMBER>3709551615 (OK)

// encoding
var encoded = msgpack.encode(big); // <Buffer cf ff ff ff ff ff ff ff ff>

// decoding to Double (per default)
var num = msgpack.decode(encoded);
console.warn(Uint64BE.isUint64BE(num)); // false
console.warn(num + ""); //<PHONE_NUMBER>3709552000 (NG)

// decoding to Uint64BE (with int64 codec)
var codec = msgpack.createCodec({int64: true});
var obj = msgpack.decode(encoded, {codec: codec});
console.warn(Uint64BE.isUint64BE(obj)); // true
console.warn(obj + ""); //<PHONE_NUMBER>3709551615 (OK)

Ok, thanks. The referenced project needs to serialize 64-bit integers, which is why I was asking.


Build Fail

Thats the error:
Showing Recent Issues:
diff: /../Podfile.lock: No such file or directory
diff: /Manifest.lock: No such file or directory
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

A screenshot here:

You need to run a pod install before attempting to compile
I've fixed another build issue with this PR: https://github.com/leonspok/Unsplash-Wallpaper/pull/5, you should now be able to build


Fetch is the 4th trending repo on the "Shell" category

We need to put it on the first place!
Seriously, great job Dylan and contributors!

Awesome! :)

Proof (for the lazy)

Great job!

Closing this as we're now way up the list.


I can't login to jsbin

Click on Login or Register.
Click on Login or Register via GitHub
It says: "Sorry, that GitHub account is linked to another JS Bin account."

I already registered though via GitHub.  Any help on how to login please.

Can you try an incognito window?
On Sat, 25 Mar 2017, 16:10 Eljam Sab Russell<EMAIL_ADDRESS>wrote:

Click on Login or Register.
Click on Login or Register via GitHub
It says: "Sorry, that GitHub account is linked to another JS Bin
account."

I already registered though via GitHub. Any help on how to login please.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jsbin/jsbin/issues/3016, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA1hD1oT_1BhnqU7TOMMo77VjMzQhUYks5rpTxsgaJpZM4MpH0T
.

Thank you, it works!  I just wonder why.

@remy I had this issue too, clearing my cookies fixed it. You should probably look into this. I've had the same issue on a project of mine which ended up sending 2 cookies with the same name to the server. It probably happens due to a change in the Set Cookie value, maybe a change in the path parameter: https://stackoverflow.com/questions/4056306/how-to-handle-multiple-cookies-with-the-same-name


Provide an IdeContextHeader component

Supports CP4I requirement for exposing context for users of multiple instances of the same product
Contributes to #
{{short description}}
Changelog
Use the following command to list changes or manually list out new, changed and
removed files.
{{git diff --name-status $(git merge-base head master)}}
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
New production dependencies

[ ] Verify the dependency has previously been
pedigree reviewed
[ ] Verify the dependency
doesn't contain any vulnerabilities
[ ] Verify the dependency bundle size is
acceptable
[ ] Verify the dependency is actively maintained

Approving, however, @chrisbygrave we will need to locate an appropriate designer for approval/review before it could move towards release.
They would need to publish the component https://pages.github.ibm.com/cdai-design/pal/ or on a similar Pal site.

Approving, however, @chrisbygrave we will need to locate an appropriate designer for approval/review before it could move towards release.
They would need to publish the component https://pages.github.ibm.com/cdai-design/pal/ or on a similar Pal site.


Allow to specify a different function to fetch results

This commit adds fetchingResult property to AutoCompleteElement;
That property can only be set using script;
If set the property will be call in autocomplete.ts#fetchingResult methods;

Hello @theinterned :wave: ! Thanks for you review!
I will try to be precise about the purpose of this feature :innocent:
Currently, the way data are fetched is implemented in the component.
The component will do an XHR request to url given by the src property, I found it a bit limited for some reasons.
This forces the developer to create a end point on its http server to send HTML <li> formated data.
With this new property, the developer can specify the way it wants the data to be fetched.
For instance, my options are stored in a global variable, I can tell the component to retrieve it this way.
Another example, I already have a end point that give a list of name as json, I can tell the component that the way to retrieve thoses names is to call this endpoint then map those data as <li>elements.
Also the developer could want to add headers or auth token to its request.
As long as the fetchResult returns a  Promise<string> it will works.
Hope I was clear thanks for your time ! :v:

Thanks for the feedbacks !
I did the changes you suggested ! I like the simplicity of the test :100: ! I overthinked it with the mock fetch :smile:

I do not know the way you want the commits to be; I thought of squashing them to only 1 commit.

Thanks again for your time !  It was great collaborating with you 😄

This is published now https://github.com/github/auto-complete-element/releases/tag/v3.2.0

This has been released https://github.com/github/auto-complete-element/releases/tag/v3.3.4


Fuel Codes | Delete a Saved Draft Fuel Code |1|

https://trello.com/c/fFORNzMF/952-fuel-codes-delete-a-saved-draft-fuel-code-1
Story:
As an IDIR user, I want to be able to "Delete" a Saved Draft of a Fuel Code so that I can remove drafts that are no longer needed.
Scenario:
GIVEN that I am an IDIR user
AND I am on the View fuel codes page Card 924.
WHEN I click on the Archive icon next to the Draft Fuel Code entry
THEN the Fuel Code entry is deleted (i.e. archived)
AND the entry is removed from the View fuel code table
Note: The archive icon should only appear for those fuel codes that are in the Draft state (not the Approved state); we do not want to archive approved fuel codes

 Fuel Codes | Delete a Saved Draft Fuel Code |1|


AttributeError: 'AvitoDataset' object has no attribute 'get_task'

The following code snippet from https://relbench.stanford.edu/databases/avito/:
from relbench.datasets import get_dataset
dataset = get_dataset("rel-avito")
task = dataset.get_task("ad-ctr")

fails with an error:
Traceback (most recent call last):
  File "/path/to/file.py", line 38, in <module>
    task = dataset.get_task("ad-ctr")
AttributeError: 'AvitoDataset' object has no attribute 'get_task'

The version I use is 1.1.0.

That URL is outdated and will be removed soon. Please see instructions on the Github README or the Start page of the website for loading tasks.


Documentation: Analyze, suggest refactoring, templates

Problems
Requirements
Tasks

[ ] Formulate problems + requirements
[ ] Formulate vision draft

High-Level Goals (for Improvement)

Emphasis on How-Do-Is (many How-Do-Is)
Emphasis on High-Performance Computing (once available)
Maybe put models into a separate place and make them updateable (like HF Transformers?)
Put demos into the docs (like in RASA and AllenNLP docs)
Better distinction between supported languages
Move Integration components into separate areas: integrating thirdparty skills (e.g., RASA bots), integrating with different systems (e.g., Google Assistant)
Move Deployment into a separate area

High-Level Goals (for Improvement)

Emphasis on How-Do-Is (many How-Do-Is)
Emphasis on High-Performance Computing (once available)
Maybe put models into a separate place and make them updateable (like HF Transformers?)
Put demos into the docs (like in RASA and AllenNLP docs)
Better distinction between supported languages
Move Integration components into separate areas: integrating thirdparty skills (e.g., RASA bots), integrating with different systems (e.g., Google Assistant)
Move Deployment into a separate area

Build Customer Journey Map/Path

Build Customer Journey Map/Path

Add GA/YM to individual doc pages

Add GA/YM to individual doc pages

CJMs:

CJM - find Open Source Conversational Platform - Public.xlsx
CJM - Use NER in own project - GitHub - Public.xlsx
CJM - Build goal-oriented skill
CJM - Build FAQ skill
CJM - Build AIML chit-chat skill
CJM - Use own data with DP Model

Vasily to describe real-life use cases for different components in our library

we need tutorials for each component


Issue 146 Rest Api CORS

Now the API includes headers inside the response.
Added issue template for github as it was missing before.

Resolve #146

Codecov Report

Merging #147 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   61.21%   61.07%   -0.15%
==========================================
  Files          15       15
  Lines        1712     1716       +4
==========================================
  Hits         1048     1048
- Misses        664      668       +4

Impacted Files
Coverage Δ

atm/api/__init__.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da5ab1...1d1bf9a. Read the comment docs.


feat(jellyfish-api-core):/add test case for dusd loan payback with dfi

What this PR does / why we need it:
Add test case for dusd loan payback using dfi
Which issue(s) does this PR fixes?:

Fixes #
https://github.com/DeFiCh/jellyfish/issues/960
Additional comments?:
current the precison in the payback dusd loan using dfi depends on the coin precision in the ain branch. this problem will be fixed in https://github.com/DeFiCh/jellyfish/pull/947

@chee-chyuan correction relevant ain branch does not include HPIC changes. so hold back changes related to #976 (comment) #976 (comment) #976 (comment)
until HPIC is merged. otherwise, we have to change again 🥲

agreed my thoughts exactly


Fix the node test after changing the "identifier" property of the nod…

…e collection to unique

@hohene this change won't cause any problems with older code

BUILD RackHD #1208 : ABORTED

** BUILD build-config-setup  #1201: SUCCESS
** BUILD CIT  #756: ABORTED
** BUILD FIT  #617: ABORTED


Keplr support

Is your feature request related to a problem? Please describe.
I really like Big Dipper, and I'd like to be able to use my Keplr wallet for staking on the Agoric chain.  Keplr is by far the easiest Cosmos-based wallet to install.
Describe the solution you'd like
It would be nice to add Keplr support to Big Dipper, as I don't have a Ledger.  Even if I did, I'd like to use it with Keplr.
Describe alternatives you've considered
I was recommended to install Lunie Light and use that with Keplr, but it doesn't have support for Cosmos SDK 0.43.
Additional context
https://keplr.app

Agoric may consider contributing to this implementation if there is a plan for how to do it.

I was able to get Lunie Light to work with some modifications at https://github.com/agoric-labs/lunie-light .
So consider this to be a wishlist item instead of something that is immediately blocking.


Meaning of parameters in rendering/camera_calibration.txt file for each shape

Hi, thanks for open sourcing your work! I would like to get the intrinsic camera matrix for each rendered view and I have noticed there is a rendering/camera_calibration.txt file for each shape. In this file, there are three parameters, but I can't understand their meaning. Can you help me to decode such values and build the 3x3 calibration matrix?

@morsingher , hello, where did you find the camera_calibration.txt file? After downloading and extracting the dataset, I cannot find this file, could you send me this file? Thanks a lot.

@zhanghm1995 Have you found the camera_calibration.txt?

@tpzou ，I cannot find these camera_calibration.txt files? So are you also cannot find these files?

In ShapeNet-ViPC, I rendered only the GT and partial point cloud.  The view data is inherited from ShapeNetRendering. For more information about ShapeNetRendering, you should check https://github.com/chrischoy/3D-R2N2 .


prometheus: log virtual memory limits

See https://github.com/prometheus/prometheus/issues/4392#issuecomment-407549933
       RLIMIT_AS
              This is the maximum size of the process's virtual memory
              (address space).  The limit is specified in bytes, and is
              rounded down to the system page size.  This limit affects
              calls to brk(2), mmap(2), and mremap(2), which fail with the
              error ENOMEM upon exceeding this limit.  In addition, auto‐
              matic stack expansion fails (and generates a SIGSEGV that
              kills the process if no alternate stack has been made avail‐
              able via sigaltstack(2)).  Since the value is a long, on
              machines with a 32-bit long either this limit is at most
              2 GiB, or this resource is unlimited.

If the process has limits on the virtual memory, it may fail with mmap: cannot allocate memory errors. Similarly to what we have for file descriptors, printing the virtual limits at startup will help troubleshooting.

Maybe it would additionally make sense to expose a metric on this?

:+1:

Maybe it would additionally make sense to expose a metric on this?

Makes sense. That should be tracked in the Prometheus client IIUC.
https://godoc.org/github.com/prometheus/client_golang/prometheus#NewProcessCollector

Absolutely right! Thanks!