Fix testsuite

Description
When I run the test-suite locally, I get errors unless I apply the proposed fixes. Curiously these errors don't seem to be showing up in GitHub - eg https://github.com/PHPCSStandards/PHP_CodeSniffer/actions/runs/7141889620/job/19450040728.
Suggested changelog entry
A changelog entry should not be necessary for this change.
Types of changes

Bug fix (non-breaking change which fixes an issue)

PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[x] I have verified that the code complies with the projects coding standards.

Thanks @fredden !


Consider accessibility

Very nice work. 2 points - consider adding an SVG  element with the function of the icon, eg

Green rectangle

And allow me to have contents in the div that gets the SVG added, eg
Home
for users without JS (firewalls, proxy browsers) etc. (The JS can remove that textual content)

Thank you Bruce!
About your second point: the library currently remove the innerHTML of the holder div. So you can achieve fallback in disabled JS situation.
Try this code in the root directory:

Unfortunately I don't understand your first point exactly. Sorry. Please explain me what is your goal with it.

Hey Bruce,
I think your comment about users without JS was worth to make a section in documentation. Thanks again! :)
http://hybicon.softwaretailoring.net/documentation.html#jsdisabled

@softwaretailoring thanks! My first point (github ate my markup) was to use the title element, as first child of the svg element,to say what the icon represents - it'll be read out by assistive technologies in the same way that alt text in an HTML img element is; see http://www.sitepoint.com/tips-accessible-svg/ for more information.

@brucelawson Okay, now I understand already. I have two questions about it.
Non-visible element
If I would implement a new data-hybicon-title attribute, the generated code would be:

        <svg xmlns="http://www.w3.org/2000/svg">
            <title>Go to documentation</title>
            ...
        </svg>

If I use the existing aria-label attribute on the holder div, the generated code:

        <svg xmlns="http://www.w3.org/2000/svg">
            ...
        </svg>

What is the difference?
Non-visible element and visible element together
I tested the title tag in Chrome, Firefox, Opera, IE and Safari. Firefox handle it as a tooltip, the others don't display this (unfortunately I don't have screen reader). So it would be a possible solution that data-hybicon-title attribute add a title tag to svg (for accessibility) and add a title attribute to holder div (for cross-browser tooltip). These two titles can work together seamlessly in assistive technologies?

AFAIK, aria-label on a div/ span isn't announced by a screenreader, whereas title in SVG is announced. So I'd use the SVG title (which is a "native" element) rather than an ARIA bolt-on. (I don't think a tooltip is necessary). I'll ask a friend of mine who's a screenreader user to adjudicate, however.

@brucel
You're right about aria-label not being recognised on
 or  elements.
The SVG <title> element is intended to provide the accessible name for its parent element. Screen reader support is inconsistent though:
http://svg-access-w3cg.github.io/svg-a11y-tests/title.html
You can use the aria-labelledby attribute to enforce <title> as the accessible name though. For example:
<svg aria-labelledby="title">
<title id="title">Go to documentation</title>
...
</svg>

This results in better support from screen readers.
http://svg-access-w3cg.github.io/svg-a11y-tests/title+aria-labelledby.html
The tooltip comes from the SVG spec itself as an optional visual rendering of the <title> element. AFAIK your results are correct - only Firefox impliments this (thankfully, since tooltips are notoriously poor for accessibility).

Thanks @LjWatson

@LjWatson @brucelawson Thanks! You helped me a lot!
I would like to make accessible hybicon, and I'll use the aria-labelledby attribute.
I know that somebody says about title attribute: "kill it with fire" :) and it is poor for accessibility, but I think the tooltip can be useful for non-screen reader situation. And the title element in svg is useful for screen reader. Both of them are a way to provide more information for users.
So when a developer sets the data-hybicon-title attribute this means that she/he wants to give text information to the icon. And it will be accessible too.
Is this approach an absolutely wrong way?

I don't think it's absolutely wrong if you want a tool tip; I just think it's unnecessary; some users will have the hover effect spoiled if a tool tip appears. and it's my belief that if an icon needs explaining to a sighted user, it shows that the icon needs re-thinking because it's "mystery meat". (Of course, there needs to be the accessibile title element in SVG & fallback for no-JS users, but that's alternate text, not additional info).
It's your project, so your call to make.

I agree. I don't want to mix the alternate text and the tooltip already. When somebody needs a tooltip it is available via title attribute of the holder div.
Finally I added a data-hybicon-alt attribute wich puts a title tag to svg and sets the icon role for it.
@LjWatson Thank you for your review! I placed a link to your article in documentation.
http://hybicon.softwaretailoring.net/documentation.html#accessibility
@brucelawson This was a great contribution! I learned a lot, thank you so much. Here is a sample page for you. :)
http://hybicon.softwaretailoring.net/samples/svgtitle.html

@softwaretailoring you're welcome, glad it's proved useful. Love from your friends at Opera!

@softwaretailoring
You're welcome anytime :)


Decimal: Signed Zero Support

The number 0 does not have a sign, so that −0, +0 and 0 are treated as identical. Current decimal support in Ion does not make this distinction where it ought to.

Part of #138

Fixed in #156 - This issue can be closed.


updated CG task condition and comment, renamed audit to analyze

Few changes based on the standardization for other repos for the Component Governance task

updated CG task condition
added CG comment
renamed job audit to analyze

@Azure/azure-sdk-eng

Can one of the admins verify this patch?


chore(main): release 0.3.0

:robot: I have created a release beep boop
0.3.0 (2024-12-14)
Features

add lexer helpers (b4edd04)
add lexing for subproc_tokens (b429e1b)
implement parsing subproc macros (f0775b0)
Lexer class interface (1d9fd70)
macros implement recursive nested (30be297)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.3.0
:sunflower:


[SE-0112] Provide default implementations for CustomNSError requirements

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves rdar://problem/23511842.

Provide default implementations for all of the CustomNSError requirements:

errorDomain: default to the name of the enum type
errorCode: default to the same thing "_code" gets, e.g., the enum tag or
raw value
errorUserInfo: default to empty

This makes it significantly easier to customize just one aspect of the
NSError view of an error type, e.g., just the user-info dictionary,
without having to write boilerplate for the others. This was actually
part of SE-0112, but I missed it in the original implementation and we
thought it was an amendment.
Fixes rdar://problem/23511842.

@swift-ci please smoke test and merge


The Firefox browser is incompatible

Attach (recommended) or Link to PDF file here:
Configuration:
testfile  A1.pdf

Web browser and its version: Firefox  106.0.2 (64 位)
Operating system and its version:  window 11
PDF.js version: v3.0.279
Is a browser extension: false

As shown below, there is a problem with rendering. Dom overlay misalignment.

Related(?) rendering problems in Goggle chrome inside textlayer div
Web browser and its version: Google Chrome v. 107.0.5304.88
Operating system and its version: window 11
PDF.js version: v3.0.279
Is a browser extension: false

WFM, using PDF.js 3.1.6 [e42e1cde6] in Firefox Nightly 108 on Windows.

PDF.js version: v3.0.279

Also, your screen-shot doesn't really agree with the quoted version number since it shows an older viewer (given the visible toolbar icons).


about transaction

Is it possible to use knex.transaction with Trilogy ?

If you use the default sqlite3 then you sure can. You might have to handle type casts yourself though since you're not going through trilogy's methods.
const Trilogy = require('trilogy')

const db = new Trilogy('./test.db')

;(async () => {
  await db.model('heroes', { name: String })

  let result = await db.knex.transaction(trx => {
    return trx('heroes').insert({ name: 'Superman' })
  })

  console.log(result)
  // -> [1]
})()


Android Performance Issues w/ Simple List/Detail App

Hey, I've been dabbling with Nativescript for awhile now, but I'm running into a pretty big issue right out the door now that I'm ready to make a real app.
I started by moving a slice of my complex Angular 2 web app to Nativescript, and had performance issues. So I created a simple list/detail app to try to figure out what the big issue was (no http calls or fancy services) with RadListView, but it still feels very sluggish transitioning from the list to the detail and back again. It feels like it freezes anywhere from 1-5 seconds every time it navigates.
I figured it must be the emulator I'm using (genymotion), so I tried deploying it to my Android device and it still has that same feeling. Tried enableProdMode() and still, same sluggish feeling.
Not sure about the iOS performance because I don't have a mac to build on yet.
I stuck my code up here: https://github.com/kronok/nativescript-performance-issue (sorry about the .js included)
One thing to note is the Nativescript code I've tested from other repos don't seem to have this issue for me, so there's something up with my simple code. Perhaps a router issue? I mimicked sample-Grocery's routing.
Tested on (emulated) Nexus 4 (api 19), Nexus 5 (api 22), Nexus 6 (api 23), Moto X (api 19) and my own Nexus 5 phone.
Bonus points: Try it out on an API 19 phone. Tends to be a bit crashy at times for such a simple app, especially if you leave it still for a few minutes and then touch something. I think it may be a RadListView issue, though.

Same issue here. Transitions to new screen - and navigate back- are so sluggish (taking 3-5 secs). Destination window is loaded but it keeps inaccessible behind a kind of white veil for mentioned time.
Here is demo app.
https://github.com/OscarLopezArnaiz/androidNavigation
Thanks

Same here, I need it to be fixed.. We are about to deliver the app :S

@OscarLopezArnaiz That "white veil" is a good description for the freezing. I've also had the "Skipping x frames!" warning, but after making it as simple as possible, it seems to have gone away, but making everything super simple obviously isn't a fix. The white veil transition is still there, though.

Hi guys.
I guess this is the same issue as NativeScript/NativeScript#2735.
The good news is that the issue is resolved so you can:

You can switch to using @next version of tns-core-modules (just add "tns-core-modules" : "next" in your package.json)
You can wait for the official 2.4.0 release of NativeScript which should come out within a week.

@vakrilov Definitely a significant improvement in performance when using @next version of tns-core-modules :)
Thanks so much!

Cool, I'll close this and re-check with 2.4.0.


Support for single-quoted object properties

Accidentally stumbled upon this, which is currently not allowed:
{
  'test': 34
}

Guess this should be relaxed, too.
Thanks!

yes, this should work too

Thank You!


How to get an array of header values now that getAll has been removed?

Major: remove headers.getAll(); make get() return all headers delimited by commas (per spec)

Server response (set-cookie) might include a comma, e.g.
Set-Cookie:              ASP.NET_SessionId=4pxd5fecgvg2vaq1nyetxk5z; domain=foo.com; path=/; HttpOnly
Set-Cookie:              SC_ANALYTICS_GLOBAL_COOKIE=a17765ea49144afdb045dac1294323ca|False; domain=foo.com; expires=Wed, 17 Mar
                         2027 17:12:37 -0000; path=/; HttpOnly
Set-Cookie:              UserSessionId=7c47a144-6a12-4ffc-907a-db8a281cca6a|10002|181845|161471|2017-03-17; domain=foo.com; path=/;
                         HttpOnly

How do I get individual set-cookie values? Breaking by comma as suggested in the change log note is going to produce malformed results.

CC @valeriangalliat (https://github.com/valeriangalliat/fetch-cookie/issues/12)

Interesting, in short, Fetch Spec doesn't seem to be dealing with it very well after deprecating getAll(). As browsers never have to expose set-cookie headers.
Ref:

https://github.com/whatwg/fetch/issues/506
https://github.com/whatwg/fetch/issues/189

So that's cost of following latest spec I guess...

Indeed, Set-Cookie headers don't follow ordinary HTTP rules, and Node.js has a special case for them.
A current work-around is .raw()['set-cookie'] though it's not optimal. Alternatively, we could resurrect getAll() (probably with a different name to disambiguate against the removed function), which provides special handling for Set-Cookie headers; or otherwise behave the same as headers.get().split(',').

I suspect my original implementation of getAll wasn't handling multiple set-cookie headers properly neither.
But I am not sure we should have a generic API similar to getAll, because Fetch Spec is trying VERY HARD to get rid of it. Should we just provide a custom function for accessing set-cookie headers by wrapping .raw()['set-cookie']? It tastes bad but it should be the only one per Node.js doc you linked.

A current work-around is .raw()['set-cookie'] though it's not optimal.

Will this work even if the original headers where in different cases?, e.g. Set-Cookie?

To answer my own question: yes.

because Fetch Spec is trying VERY HARD to get rid of it

Source?

.raw() returns corrupted data:
cookies { 'cache-control': [ 'private' ],
  connection: [ 'close' ],
  'content-encoding': [ 'gzip' ],
  'content-length': [ '15889' ],
  'content-type': [ 'text/html; charset=utf-8' ],
  date: [ 'Sat, 18 Mar 2017 13:42:35 GMT' ],
  server: [ 'Microsoft-IIS/8.5' ],
  'set-cookie': [ 'ASP.NET_SessionId=plhpebiilbz5pdclj1ue11s0; domain=foo.com; path=/; HttpOnly,SC_ANALYTICS_GLOBAL_COOKIE=6bf292f84dd542c9ab042382ec62d640|False; domain=foo.com; expires=Thu, 18-Mar-2027 13:42:36 GMT; path=/; HttpOnly,UserSessionId=3c0e9eae-b37d-45a6-8711-d25792ea04d6|10002|181845|160482|2017-03-18; domain=foo.com; path=/; HttpOnly' ],
  vary: [ 'Accept-Encoding' ],
  'x-content-type-options': [ 'nosniff' ],
  'x-frame-options': [ 'SAMEORIGIN' ],
  'x-serverid': [ 'con2, CON02' ],
  'x-xss-protection': [ '1; mode=block' ] }

I cannot see any workaround... node-fetch doesn't expose incomingMessage and raw() is as low level as Headers have data.

@bitinn FWIW, if we ever were to expose cookies in the API the idea would indeed be to give them some kind of special API that deals with their weirdness.

#253 is merged, but we still need to document this somehow, or add a specialized API...

Released as v2 alpha.4, better late than never...

I am unsure, how to solve this now. I can't figure out how to do this still ...

 Thank you.
Really annoying

@codler Thank you!  This is a very frustrating issue that I hope is officially resolved soon.

AFAIK, you can’t, due to security concerns. Which is why there isn’t an API  for it yet.
(From my phone)

On Oct 31, 2019, at 1:36, Oliver Joseph Ash<EMAIL_ADDRESS>wrote:

The raw workaround works for node-fetch, but how would you do this with browser fetch?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Bump gestalt to 0.73.0

Bumping the version and fixing the CHANGELOG file as it is not a major change leading to a major version increase.

Deploy preview for gestalt ready!
Built with commit e77829b9a559af476c73fe4a03909a5479514e7e
https://deploy-preview-250--gestalt.netlify.com

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   70.73%   70.73%
=======================================
  Files          46       46
  Lines         820      820
  Branches      189      189
=======================================
  Hits          580      580
  Misses        169      169
  Partials       71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049ab15...e77829b. Read the comment docs.


Set up encrypted boot

My disk isn't at all encrypted on boot now.
This isn't a huge priority issue but it would be helpful to encrypt everything, especially on my VPS - where the provider has the potential to access all of my data if it isn't.

https://gist.github.com/martijnvermaat/76f2e24d0239470dd71050358b4d5134
https://elvishjerricco.github.io/2018/12/06/encrypted-boot-on-zfs-with-nixos.html

https://gist.github.com/martijnvermaat/76f2e24d0239470dd71050358b4d5134
https://elvishjerricco.github.io/2018/12/06/encrypted-boot-on-zfs-with-nixos.html

This looks relatively straightforward and should go hand in hand with #15

This looks relatively straightforward and should go hand in hand with #15

The instructions here: https://github.com/Luis-Hebendanz/nix-configs seem to demonstrate the setup of LUKS

The instructions here: https://github.com/Luis-Hebendanz/nix-configs seem to demonstrate the setup of LUKS


Iris Support

Does the tool support Iris systems?

This answers it: https://www.youtube.com/watch?v=3AG_RST6o1Y.


Add test for tab_controller.1.dart API example.

This PR contributes to https://github.com/flutter/flutter/issues/130459
Description

Updates examples/api/lib/material/tab_controller/tab_controller.1.dart to properly remove the listener from the TabController
Adds tests for examples/api/lib/material/tab_controller/tab_controller.1.dart

Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
[X] All existing and new tests are passing.

@bleroux @TahaTesser thanks a lot for the review and merge!


RFC: add API to return library defaults

This RFC proposes to add an API to the standard for returning library defaults (e.g., dtypes and devices).
Currently, the standard requires that conforming array libraries explicitly state their default dtypes in their documentation; no guidance is provided regarding devices. The standard provides no APIs for querying library defaults.
The inability to query defaults requires manual workarounds, such as allocating a fresh array and checking the dtype or device attribute. This is less than ideal, especially for third-party array libraries wanting to generically extend an array library's namespace and adhere to the same default behavior (e.g., wrap library x to expose additional array creation functions for specialized matrices).
Prior art
PyTorch
torch.get_default_dtype() → torch.dtype

Returns the current default floating-point dtype.
JAX
jax.default_backend() -> str

Returns the platform name of the default XLA backend.
Proposal
defaults() -> dict[str, any]
defaults(device: device) -> dict[str, any]
defaults(name: str) -> any
defaults(name: str, device: device) -> any

If not provided an argument, the function would return a dictionary with the following keys:

device: default device.
dtypes.real_floating_point: default real floating-point dtype.
dtypes.complex_floating_point: default complex floating-point dtype.
dtypes.integral: default integral dtype.
dtypes.indexing: default index dtype.

More keys could be added in the future, depending on evolution of the standard.
If provided a device argument, the function would return a dictionary as described above, but specific to the specified device.
If provided a name argument, the function would return the default for the specific setting. E.g.,
>>> d = xp.defaults("device")

If provided both a name and device argument, the function would return the default for the specified setting for the specified device.
Notes

If we wanted to allow supporting a standardized means for configuring defaults (e.g., setting the default real floating-point dtype to float32, instead of float64), may want to rename the API to something like get_defaults() and then setting could be set_default().
When invoked without a device argument, the function would return default dtypes based on the current device context, as array libraries may have differing default dtypes, depending on the device. Accordingly, users should be advised to not assume that defaults are static.

Related

https://github.com/data-apis/array-api/issues/499

This RFC has been superseded by #640.


Refactor Flag functions

Overview
Starting work to support PK KRI per #1911. First steps included in this PR:

refactoring the Flag() function to be a bit more flexible per #1973.
removing Make_Timeline() per #1978
MakeBounds() doesn't bomb for "identity" analysis per #1919

Test Notes/Sample Code
See updated test-that tests for Flag() functionality.
Connected Issues

Closes #1973 #1978

@lauramaxwell @zdz2101 this is ready for an initial review once v2.2 is released.
cc: @samussiah


Pop-up windows return to their original position after swiping them

Pre-condition: User have wallet and logged in eWallet.
Steps:

Open the GoodDollar app
Go to the main screen page
Tap the any tile except first tile
Swipe the popups
Pay attention to the screen

Attual result: Pop-up windows return to their original position after swiping them
Expected result: Pop-ups switch after swiping them
Used devices:
iPhone XS // iOS 13.1.3
Environment:
eWallet ver. 0.10.6
Video: https://www.screencast.com/t/FH6avlfry15

@AnastasiiaOdnoshevna I can't reproduce this issue. I tested this issue on ewallet and locally from different simulators, also tested on a real device. It seems like everything working well.
So I moving this issue to QA stage.

Checked on QA and eWallet environments
Work as per requirements
https://www.screencast.com/t/FWvwlNOdr5n


Docs fix to #2449

Documentation fix.

Misagh, can you rerun this travis, so we can check output in doc?
https://travis-ci.org/apereo/cas/builds/211358884

Sure

Unfortunately, it did fail again:
Caused by: org.gradle.internal.resolve.ArtifactNotFoundException: Could not find opensaml-storage-api.jar (org.opensaml:opensaml-storage-api:3.3.0).
Searched in the following locations:
https://repo1.maven.org/maven2/org/opensaml/opensaml-storage-api/3.3.0/opensaml-storage-api-3.3.0.jar
Can you resolve that in artifactory and rerun build? Thanks!

Yes I am looking into this. Thanks for spotting it.
Travis is just being weird. It will eventually sort itself out. I know there were a few outages recently and I am not sure if it's still them or something CAS does that makes it go haywire. We'll figure it out.

It looks as though we are back in business. Keep watch please and as always, if you find anything else that is broken and needs attention, shoot over patches.


Artifact --help

Running buildkite-agent artifact --help just shows download help, but doesn't show the various sub-commands.
I tried buildkite-agent --help but that doesn't show it either.
$ buildkite-agent artifact --help
Usage:

   buildkite-agent artifact download [arguments...]

Description:

   Downloads artifacts from Buildkite to the local machine.

   Note: You need to ensure that your search query is surrounded by quotes if
   using a wild card as the built-in shell path globbing will provide files,
   which will break the download.

Example:

   $ buildkite-agent artifact download "pkg/*.tar.gz" . --build xxx

   This will search across all the artifacts for the build with files that match that part.
   The first argument is the search query, and the second argument is the download destination.

   If you're trying to download a specific file, and there are multiple artifacts from different
   jobs, you can target the paticular job you want to download the artifact from:

   $ buildkite-agent artifact download "pkg/*.tar.gz" . --job "tests" --build xxx

   You can also use the job's id (provided by the environment variable $BUILDKITE_JOB_ID)

Options:

   --job 					Used to target a specific job to download artifacts from
   --build 					Which build should the artifacts be downloaded from [$BUILDKITE_BUILD_ID]
   --agent-access-token 			The access token used to identify the agent [$BUILDKITE_AGENT_ACCESS_TOKEN]
   --endpoint "https://agent.buildkite.com/v2"	The agent API endpoint [$BUILDKITE_AGENT_ENDPOINT]
   --debug					Enable debug mode [$BUILDKITE_AGENT_DEBUG]
   --no-color					Don't show colors in logging [$BUILDKITE_AGENT_NO_COLOR]

I can't reproduce this, I tried it locally and it works correctly.

❯ buildkite-agent --help                                                                                agent/git/master
Usage:

  buildkite-agent <command> [arguments...]

Available comamnds are:

  start		Starts a Buildkite agent
  artifact	Upload/download artifacts from Buildkite jobs
  meta-data	Get/set data from Buildkite jobs
  help, h	Shows a list of commands or help for one command

Use "buildkite-agent <command> --help" for more information about a command.

❯ buildkite-agent artifact --help                                                                                agent/git/master
Usage:

  buildkite-agent artifact <command> [arguments...]

Available comamnds are:

   download	Downloads artifacts from Buildkite to the local machine
   upload	Uploads files to a job as artifacts
   shasum	Prints the SHA-1 checksum for the artifact provided to STDOUT
   help, h	Shows a list of commands or help for one command

Options:

   --help, -h	show help

❯ buildkite-agent artifact download --help                                                                                agent/git/master
Usage:

   buildkite-agent artifact download [arguments...]

Description:

   Downloads artifacts from Buildkite to the local machine.

   Note: You need to ensure that your search query is surrounded by quotes if
   using a wild card as the built-in shell path globbing will provide files,
   which will break the download.

Example:

   $ buildkite-agent artifact download "pkg/*.tar.gz" . --build xxx

   This will search across all the artifacts for the build with files that match that part.
   The first argument is the search query, and the second argument is the download destination.
...

Could be a bug on my end… will double check

Bug in my setup


Application as a new Maintainer

Hi @rbren
I recently discovered this project and saw that it has not been updated in a longer time and is looking for a new maintainer.
I kindly want to ask if you could add me as one.
A bit about myself:
I'm a computer science student, who is also working as a working student as a Mulesoft consultant.
I am a certified Mulesoft Developer and also a certified Ballerina Developer and work a lot with RAML and Open API Specs at my company.
While I may not have extensive experience as a maintainer of open-source projects, I believe that taking on this responsibility would provide me with invaluable learning opportunities.
You can also connect with me on LinkedIn if you want to discuss anything privately.

Hi @Shadow-Devil--if you want to start a fork that fixes some of the existing issues, I'd be happy to link to it!


Unable to publish to artifactory (414 Request-URI Too Large)

I am unable to publish to artifactory using a script which leverages Jfrog.  When using Jfrog 1.32.3 (on macOS - installed via brew), it fails with (for example):
[Error] [Thread 5] Artifactory response: 414 Request-URI Too Large

However, if I roll back and use Jfrog 1.32.1, the exact same command (to the exact same server) succeeds and uploads just fine.
The command I'm running is:
jfrog rt u --apikey="${ARTIFACTORY_KEYSTORE_PW}" --url="${ARTIFACTORY_URL}" \
                --build-name="${ARTIFACTORY_PROJECT}" --build-number="${VERSION}.${BUILD_NUM}" \
                --threads=10 --exclude-patterns="*.DS_Store*" \
                "${1}/(*)" \
                "${ARTIFACTORY_RELEASE_REPO}/${ARTIFACTORY_PROJECT}/${VERSION}.${BUILD_NUM}/{1}"

@toonetown,
I believe that this issue was resolved in version +.32.4. Can you please give it try and let us know?

1.32.4 appears to be working.  Thank you.


[place] Unable to open place page for American Samoa

Unable to load place page for "American Samoa" when trying on staging (http://staging.datacommons.org/place/country/ASM). Seems to be getting an error when retrieving data.

https://github.com/datacommonsorg/mixer/pull/331 will fix this


Update webapp manifest

This updates the default values in the webapp manifest. In browsers that respect the manifest (Chrome, Firefox), this improves the experience slightly. The app can be added to the homescreen/desktop and will use a nice icon, name, and theme color.
I'd be happy to update any of these values if they're not suitable. I just used the values I found in  for the icons and the CSS link color for theme color.

❤ thank you!


octant: Add version 0.4.1

octant is an augmented kubectl that provides detailed information about a Kubernetes cluster in a browser. Since it is not strictly a CLI tool, this PR is made to the extra rather than main bucket.
Let me know if this change can be made against main instead so that related tooling can installed from a single bucket.

@Ash258 Patch release bump since the last review


How to work with BIGSERIAL columns? There is no way of making them Optional

Hey :-) I´ve researched a while now, but it seems i dont really get it. I have a column defined as BIGSERIAL. I dont want to set this value on Create() (since it should auto increment), so i want to make it optional.
field.Int("insertion_order").
	Optional().
	SchemaType(map[string]string{
		dialect.Postgres: postgres.TypeBigSerial,
}),

This results in an error:
NOT NULL constraint is required for bigserial column
If i remove the optional,. i am forced to set this value, which i dont want, since it should auto increment.
On the other hand, i´m also not able to make an custom auto increment, since i see no option of creating sequences.
There is just one line i have to remove from code generation, then the example (without the optional) above is working:
if _, ok := pec.mutation.InsertionOrder(); !ok {
      return &ValidationError{Name: "insertion_order", err: errors.New(`ent: missing required field "PendingEvent.insertion_order"`)}
}

Maybe there is someone who can give me some hints on how to work with such a case :-)

@a8m Thank you for your fast response 🔥
I would be awesome if this is getting fixed until next year, because we´re currently building new services with ent & this is kinda blocking / annoying :-D
You guys doing a great job, have a nice day! 👍

Good morning & happy new year :-)
Any updates so far? Or any kind of schedule when this will be tackled? :-)

Thanks for the reminder. I created https://github.com/ent/ent/pull/3204 which should solve this issue. But there's another thing that needs to be done there and it's to read the generated database default values on creation. At the moment, calling T.Create().SaveX(ctx) won't load this info from the database.
I'll leave this issue open for now, and will send a patch to fix this soon.


Forcing response_format to json

The ChatLanguageModel interface provides a new method that can be implemented to force the use of response_format to json when an AiService method returns a pojo. This is something that can be done automatically by quarkus.
@Experimental
default ChatResponse chat(ChatRequest request) {
	throw new UnsupportedOperationException();
}

This should be a simple change to the AiServiceMethodImplementationSupport class, but all current providers will need to be updated to manage this new method.
Does this make sense?

I think it does

cc @langchain4j

@andreadimaio do you want to work on this?

@andreadimaio do you want to work on this?

Yes, I'll open a new PR

🙏🏽

The implementation is a little more complex than what I have in mind, for the simple thing that OpenAi also has another response_format option called json_schema (watsonx.ai only supports json_object).
If the json_schema option is enabled, the API will also take the schema of the object as input. In this case it is useful to create this schema at build time.

I'm not an expert on the OpenAi APIs, but I think that if response_format is equal to json_schema, it makes no sense to inject the message You must answer strictly in the following JSON format: ... into the prompt, because OpenAi will do something to make sure this happens. This message can be injected for all other types TEXT and JSON_OBJECT, but this is a detail that can for now be overlooked.

@andreadimaio it works like this in vanilla LC4j. If schema can be passed, we do not append extra instructions

But schema is now supported only by OpenAI and Gemini

There's something that's not clear to me. Looking at class DefaultAiServices.java there are these lines:
Response < AiMessage > response;
if (supportsJsonSchema && jsonSchema.isPresent()) {
    ChatRequest chatRequest = ChatRequest.builder()
        .messages(messages)
        .toolSpecifications(toolSpecifications)
        .responseFormat(ResponseFormat.builder()
            .type(JSON)
            .jsonSchema(jsonSchema.get())
            .build())
        .build();

    ChatResponse chatResponse = context.chatModel.chat(chatRequest);

    response = new Response < > (
        chatResponse.aiMessage(),
        chatResponse.tokenUsage(),
        chatResponse.finishReason()
    );
} else {
    // TODO migrate to new API
    response = toolSpecifications == null ?
        context.chatModel.generate(messages) :
        context.chatModel.generate(messages, toolSpecifications);
}

The chat method is invoked only when the provider supports the json_schema but what about the json_object? I would like to force the use of the chat method even in this case.  Maybe the class Capability should contain also this type.
Another note is about the default implementation of the chat method. It has all the parameters to call the generate method if the provider doesn't support the response_format. Isn't it better to have this kind of default implementation instead of throwing an exception? In this case it should be easier to handle the chat method for all model providers (maybe I'm missing something).
@langchain4j

Or your idea is to use RESPONSE_FORMAT_JSON_SCHEMA for both values (json_object, json_schema)? Maybe yes, because in the end the  logic inside the chat method can handle the variable passed to make the correct call to the endpoint.

Chat method is used only when Json capability is present because I had to rush this new chat API in order to enable structured outputs. Otherwise there was no way to pass the schema. WIP...

I was planning to add another Capability for json_object. It should be easy as we know which providers support Json mode.
Regarding the default implementation of the chat method, you're right, it should call the generate methods. I actually implemented it this way initially, but then rolled back because I had some doubts about it. This is work in progress, I plan to get back to this new API soon. Eventually generate methods will be deprecated and providers will need to implement only one method: chat.

Chat method is used only when Json capability is present because I had to rush this new chat API in order to enable structured outputs. Otherwise there was no way to pass the schema. WIP...

Thank you for clarifying!
@geoand what do you suggest to do regarding the implementation of this functionality in quarkus-langchain4j? I could go ahead and implement what is there today, or wait for a new release.

I could go ahead and implement what is there today

You can go ahead and do that here and when it feature langs in LangChain4j we can utilize it

I've been thinking about it and I am considering using tools (function calling) instead of JSON mode when return type is POJO and Structured Outputs feature is not supported (e.g. when LLM provider is not OpenAI or Gemini):

Tools are supported by 14 LLM providers, JSON mode only by 7: https://docs.langchain4j.dev/integrations/language-models/
Tools allow setting JSON schema in a standartized way (although no guarantee of 100% schema adherance)
Many models are fine-tuned to use produce valid JSON for tools
No need to modify original user prompt (to append "You must answer strictly in the following format...")

This is how it can work:
if (isStructuredOutputType(methodReturnType)) { // e.g. POJO, enum, List<T>/Set<T>, etc.
    if (chatModel.supportedCapabilities().contains(RESPONSE_FORMAT_JSON_SCHEMA)) {
        // Proceed with generating JSON schema and passing it to the model using structured outputs feature.
        // This will work for OpenAI and Gemini.
    } else if (chatModel.supportedCapabilities().contains(TOOLS)) {
        // Create synthetic tool "answer" and generate JSON schema for it
        if (configuredTools.isEmpty()) {
            // The "answer" is the only tool, so we will *force* the model to call this tool using tool_mode LLM parameter (will be available in the new ChatModel API)
        } else {
            // There are other tools that user has configured. It means that LLM could/should use one or multiple of them before providing the final answer.
            // I am not sure yet what is the best solution in this case. For example, we could add "final_answer" to the list of tools and hope that LLM will use it to provide the answer.
            // We could also append a hint to the prompt (e.g. "Use final_answer tool to provide a final answer").
            // Or we could call the LLM in the loop (if LLM decides to call tools) untill it returns a final answer in plain text, and then call it again only with "answer" tool available and force it to call it with tool_mode parameter.
            // There can be multiple strategies and we could make this configurable for the user.
            // Please note that this is probably pretty rate use case (when user needs both structured outputs and tools).
        }
    } else {
        // Fallback to appending "You must answer strictly in the following format..." to the prompt.
    }
}

WDYT?

We can also make "what to use to get structured output from LLM" as a configurable strategy that user can specify explicitly (e.g. USE_STRUCTURED_OUTPUTS, USE_TOOLS, USE_JSON_MODE, USE_PROMPTING, etc.)

If the provider returns an error when trying to use a model that does not support tools, then the consideration I made about using USE_TOOLS can be ignored.

I am not entirely sure how the tools would enforce valid JSON generation from the LLM in this context. Is the primary role of the tools to generate the schema, or is it used to handle response formatting after the model has generated the output?

When LLM support tools, you can provide a JSON schema and LLM will generate a valid JSON that follows the schema (in like 95% of cases ,depending on the complexity of schema). LC4j generates JSON schema from a @Tool-annotated method parameters automatically. Most modern LLMs are explicitly trained for "tool calling" use case to produce a valid JSON that follows the provided schema. Does this answer your Q?

I think we need to be cautious about tools' functionality. Some model providers, like Ollama, support tools, but not for all the hosted models. In these cases, the chatModel.supportedCapabilities().contains(TOOLS) could introduce issues when certain models do not fully support tools.

Good point, this is why we should make this behavior configurable.

Regarding the JSON mode, I think that combined with the "You must answer strictly in the following format..." can give good results even for "small" models. Today, models tend to return the JSON structure given in the prompt, but this does not mean that the desired structure is 100% present.

I agree that JSON mode works pretty good, but tools are more reliable than JSON mode by design. JSON mode feature just "guarantees" (in 95% of the times) that the returned text is a valid JSON. One can provide JSON schema in the free-form in the prompt, but there is no guarantee that LLM will follow it. Tools, on the other hand, "guarantee" (again, 95%) that returned text is not only a valid JSON, but also follows the specified schema. And in this case schema is specified in a standartized way (as a separate LLM request parameter) and not appended as free-form text to the user message. Since tool-calling LLMs are tuned to follow the schema, and there is only a single way to specify the schema, it is mroe reliable than appending schema as a free-form text to the user prompt.

I think we need to be cautious about tools' functionality. Some model providers, like Ollama, support tools, but not for all the hosted models. In these cases, the chatModel.supportedCapabilities().contains(TOOLS) could introduce issues when certain models do not fully support tools.

If the provider returns an error when trying to use a model that does not support tools, the consideration I made about using USE_TOOLS can be ignored.

Good point! I guess this concern is applicable mostly for Ollama, as all other LLM providers that support tools, usually support them for all their models (at least I see this trend lately). Ollama throws an error in case tools are not supported by specific model: {"error":"tinydolphin does not support tools"}, so we should be safe.

When LLM support tools, you can provide a JSON schema and LLM will generate a valid JSON that follows the schema (in like 95% of cases ,depending on the complexity of schema). LC4j generates JSON schema from a @Tool-annotated method parameters automatically. Most modern LLMs are explicitly trained for "tool calling" use case to produce a valid JSON that follows the provided schema. Does this answer your Q?

In part, I want to understand the actual use of tools to solve this problem. I have something in mind, but I don't know if we're on the same page. Suppose I have an LLM that needs to extract some user info, and this is the output pojo:
record User(String firstName, String lastName) {}

Your idea is to have a tool method like this to generate the correct JSON?
@Tool("Generates a response in the required JSON format.")
public User answer(String firstName, String lastName) {
    return new User(firstName, lastName);
}

Good point! I guess this concern is applicable mostly for Ollama, as all other LLM providers that support tools, usually support them for all their models (at least I see this trend lately). Ollama throws an error in case tools are not supported by specific model: {"error":"tinydolphin does not support tools"}, so we should be safe.

:+1:

@andreadimaio no, the idea is to automatically create
ToolSpecification.builder()
    .name("answer")
    .addParameter("firstName")
    .addParameter("lastName")
   .build()
``` under the hood of AI Service and inject it in the request to the LLM and force it to use this tool.

In this case user does not have to do anything, LLM will be forced to reply by calling `answer` tool and provide a valid JSON which we will deserialize into `User` object and return to the user.

Python version of LC is actually using tool calling as a primary way for structured outputs: https://python.langchain.com/v0.1/docs/modules/model_io/chat/structured_output/

In this case tools are kind of "misused" for returning structured output

@andreadimaio no, the idea is to automatically create
ToolSpecification.builder()
    .name("answer")
    .addParameter("firstName")
    .addParameter("lastName")
   .build()

under the hood of AI Service and inject it in the request to the LLM and force it to use this tool.
In this case user does not have to do anything, LLM will be forced to reply by calling answer tool and provide a valid JSON which we will deserialize into User object and return to the user.

Yes, it was just an example, of course everything will be automatic. So we are on the same page :)
Now it is clear to me, thanks!

Just to document this explicitly, here is the order (from best to worst) of strategies to get structured outputs is AI services (this is not implemented yet, jsut a plan):

Use Structured Outputs feature (currently supported only by OpenAI and Gemini, Azure OpenAI is in progress, I also foresee other providers implementing this feature in the future) and provide JSON schema in structured way.
Use Tools feature (currently supported by most LLM providers and is considered a standart feature) and provide JSON schema in a structured way.
Automatically enable JSON mode (if supported) and append JSON schema in a free-form text to the user message.
Append JSON schema in a free-form text to the user message.

User should be able to override this logic and explicitly specify which strategy to use.

cc @glaforge @jdubois @agoncal


Bump llvm revision to use bytecode machinery

Updated LLVM revision and rebuilt/tested. Looks like the display of #sparse_tensor.encoding has changed to no longer include pointerBitWidth and indexBitWidth.
This change will unblock StableHLO bytecode implementation.

Manually checked that the build is passing. Approving.


Edit styling of default this.$toast.success('message') ?

Are we able to edit the styling of the default this.$toast.success('message') and add icons?
OR
Do we have to make a custom toast to accomplish these things?

@MaxWeisen You can customize the styling by overriding the style but to add an icon for an existing type you need to register a custom toast.
Here is an example of overriding the success toast:
.toasted-container .toasted.toasted-primary.success {
    color: #267526;
    background: #DFF7DC;
}


WiX: package features.json for clang

Include features.json from clang to allow tooling to detect features supported by the C/C++ compiler.
Fixes: swiftlang/swift#74634

CC: @etcwilde @hyp @jakepetroules


BACKPORT 1-1: Implement the ZMQ_PROBE_ROUTER flag response.

Implement the ZMQ_PROBE_ROUTER flag response.
(original PR: https://github.com/hyperledger/sawtooth-core/pull/1858)

Turn easier to implement symmetrical topologies. The Java SDK has classes that can be used to implement clients or a validator without changing anything;

Using ROUTER <-> ROUTER, the topology completely decouple the messages for any particular worker. I don't know Go, but seeing the code, there is a map to hold references to the worker and a correlation ID being worked on. With the internal fanning proposed in the Java SDK, that isn't necessary at all. That way, long lived actions wouldn't stop a thread, giving the code a real async processing. This class holds the interesting bit.

This approach was taken from Freelancer and Majordomo protocols, that provides full async work, that I think is of interest to the project as a whole.

Closing this PR due to above comment.


Word change line 31

I change "no thresholds" to "any thresholds".

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks for the PR @alamsls2013, but this change is not necessary. We welcome future PR's from you - thanks and happy coding!


History mechanism breaking on page reload

The failure occurs in firefox 10.  Visit the nobelists example in the demos directory.  In the viewpanel, select the timeline view.  Reload a few times.  Intermittently, the reloaded page will fail to render it view; apparently the history (saying the timeline view is selected) is persisting over the reload and exhibit is attempting to invoke the timeline view before it has been fully loaded or initialized by the reload.  In particular, at the time of invocation Timline.DefaultEventSource is undefined, so the following error is thrown:
Error: Timeline.DefaultEventSource is not a constructor
Source File: http://api.simile-widgets.org/exhibit/3.0.0rc1/extensions/time/time-extension-bundle.js
Line: 1

That sounds more like a Timeline loading problem to me, which is basically a duplicate of #35.  I can keep trying to find neat tricks to get around the broken SimileAjax method of loading files, and extension loading definitely need some general work, but at some point #35 has to take place to really make this go away.

I don't think it's a timeline bug per se.  I think the problem originates from the fact that on reload the selected view stays stuck at view #2 (the timeline view) instead of resetting back to the default view #1.
Or looked at another way, even if there is something wrong with the timeline loader, it seems there may still be a problem with view selection in the history.

That behavior is a feature, not a bug.  Exhibit retains your place in browsing.


Fit GP prior and fix bugs

In this PR, I add the GP prior MLE fit and fix a couple of bugs.

Codecov Report

Merging #88 (27e302f) into master (838d4ee) will increase coverage by 0.78%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   67.63%   68.42%   +0.78%
==========================================
  Files          36       36
  Lines        2645     2714      +69
==========================================
+ Hits         1789     1857      +68
- Misses        856      857       +1

Impacted Files
Coverage Δ

src/algorithms/bayesian.jl
96.74% <93.05%> (-1.88%)
:arrow_down:

src/wrappers/ipopt.jl
87.21% <100.00%> (+2.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838d4ee...27e302f. Read the comment docs.


[.NET][InputValidation] Warning should be returned when an input is marked as required but doesn't have a label

Platform

.NET

Details
See issue #4356 for details. When an input is marked as required but does not include a label a warning should be returned to inform the card author that there will be no visual indication that their input is required.

@almedina-ms can you help with this as you look into the WPF bugs? Thanks


List items are tagged incorrectly

Good job on getting the first bit of homework done in issue #3, but theres a bit of a problem with that code you committed. Namely, the list items are tagged incorrectly on all three lists.
All of the content is great! Just take a look over your tags and see if you can't catch your mistake.
TO DO

[x] Create a new branch off of master called html-list-fix
[x] Edit the index.html file with the changes you think will resolve this issue.
[x] Create a pull request from the html-list-fix branch to the master branch.
[x] Title your pull request "List items are supposed to be list items."
[x] In the body of the pull request, write up what changes you made and how you discovered the changes. (bonus points: see if theres a way to reference this issue so that it automatically closes once your pull request gets merged into master)
[ ] Assign the pull request to me, put it on the Front End Foundations milestone, and give it a label of "bugfix".
[ ] If you got it right, I'll merge the request; if not, I'll comment and give you some more instructions.

i don't know wtf  i'm doing

i don't know wtf  i'm doing

@GeneralOutcast That's pretty impressive considering that you did it perfectly haha

@GeneralOutcast That's pretty impressive considering that you did it perfectly haha

okay well what did i do?!

okay well what did i do?!

You did Github flow!

You made a branch so that you should safely commit a change
You used your resources to find the change that needed to be made, then edited the file and made a commit explaining the change.
You used a pull-request to resolve the issue that brought the need for the change to your attention
I took a look at your changes and merged them into master so that everything is all up to date.

Does that all make sense?

You did Github flow!

You made a branch so that you should safely commit a change
You used your resources to find the change that needed to be made, then edited the file and made a commit explaining the change.
You used a pull-request to resolve the issue that brought the need for the change to your attention
I took a look at your changes and merged them into master so that everything is all up to date.

Does that all make sense?

yeahh!! whoo-hoo! :100:  :+1:  :boom:  :exclamation:

yeahh!! whoo-hoo! :100:  :+1:  :boom:  :exclamation:


Why are we cloning repos to pwd?

Wouldn't cloning repos to the pwd make it harder to check if something is already installed?
If we're installing themes, are we installing them to a particular directory depending on the project?
So, for example kitty themes we would want to install it at ~/.config/kitty/themes/ or something. Would it be worth having some confirmation of the default install location and you can provide an alternate location if you want?

Never thought of the confirmation before...we could do that!

Is this what you're already doing for the new command where you set the install locations? :eyes:

To an extent; it's really just used to fill in the .catppuccin.yaml.

Solved; closing.


add api feature request issue template form.

main aim: want auto attach kind/api label to them :)
just a propsal, will close it soon if no one like it. thanks!

Why did you close this PR?


Publish openjdk.test.jlm project into openjdk-systemtest Adopt repository

Publish openjdk.test.jlm project into openjdk-systemtest Adopt repository. This project can be built and run against both OpenJDK and OpenJDK-OpenJ9 SDKs.
Related Issue: https://github.com/AdoptOpenJDK/openjdk-systemtest/issues/88

Thanks Mesbah, I am going to look at this over the next few days.

Openj9 Issues reported via tests pertaining to this PR so far:
https://github.com/eclipse/openj9/issues/1566
https://github.com/eclipse/openj9/issues/1520

I recognize that this code is migrated, and so do not expect that we can address the inconsistent logging, asserting, and println approach at this time, but we may want an epic/issue at some point to consolidate it.

@mamatha-jv : I had posted links to some of the test runs in personal builds in the pr: https://github.com/AdoptOpenJDK/openjdk-systemtest/issues/88

@llxia - The code is not merged yet.

Related PR : https://github.com/eclipse/openj9-systemtest/pull/19


respawn

Hey sorry to bother you again
so I'm having an issue where the first time you die everything works fine
but after that you skip going to the death box and go straight to respawn but your body gets stuck behind any terrain/buildings between you and the respawn. you then can only move in one direction towards where your body had been stuck
any help / advice would be greatly appreciated :)
cheers CH

the issue is that are 3 different issues stacking on top of each other.

VRchat's networking is slow and thus the system puts players in a little box to allow all the damage to be applied
for some mystical reason, it doesn't do number 1
your issue, probably because of number 2 causing multiple teleports to happen within the same frame

I'm working on the system right now as it's had a fit for the millionth time now, but no matter how much I try to unravel those 3 issues in a trench coat, being one big issue it doesn't wanna play nice, the simplest solution would be to remove the death box system entirely, but that requires having some other way of making sure players don't spawn with less than max health
This can be done externally by you if the players are spawning in something like a lobby, with their health being hidden till the start of the next match, and their health is maxed out at that point instead of directly at respawn,
The health manager has an option to straight-up disable the respawn box if deemed necessary, but of course, it's recommended to do the above if you decide to do that.

Thanks for getting back to me
I understand, that's definitely frustrating I feel your pain. I wish i could help out but you are far more talented than me 😅
I only just started learning coding myself
it seems disabling the respawn box doesn't help with my issue of getting trapped behind stuff. could it be like you mentioned above trying to teleport to far in to such a short time frame?
also so what your saying is the problem is damage being dealt after respawn?. so in theory if the HP is maxed at 100 i could then heal players 100 a few seconds after respawn? to make sure all new players are at max HP?
I know its probably a lot harder than that though 😅

It seems disabling the respawn box doesn't help with my issue of getting trapped behind stuff.
after doing a little research it appears its a common bug with localPLayer.TeleportTo
the solution seems to be adding a sendcustomeventdelayed to give it time to catch up

that made it work fine, however it still suffered from the issue you mentioned taking delayed damage causing you to not have full hp on respawn
adding a second delay before you heal seems to have fixed all the issues ( 99% sure anyway) i have only tested it locally
Debug.Log("respawn Triggerd");
    localPLayer.TeleportTo(RespawnPoint.position, RespawnPoint.rotation);
    CurrentHunger = 100.0f;
    SendCustomEventDelayedSeconds("RespawnHealth", 0.1f);
	CurrentHealth = RespawnHealth;
    //localPLayer.CombatSetCurrentHitpoints(RespawnHealth);
    Dead = false;


Slimmer dependencies for client. #1443

Would this work? @devemux86 @boldtrn

Thanks @michaz !
BTW: to use the same versions for these things like dropwizard does - maybe we can utilize their "bom" project somehow? https://github.com/dropwizard/dropwizard/blob/master/dropwizard-bom/pom.xml#L15

Thanks @michaz now client-hc is much lighter to use!
BTW
Why not use the com.graphhopper.external:jackson-datatype-jts instead of com.bedatadriven:jackson-datatype-jts?
With bedatadriven cannot avoid the older com.vividsolutions:jts dependency due to JtsModule creation in Jackson.

GH core uses 1.14.0. To use the latest version 1.15.0 there was still an issue (but I think this should work now): https://github.com/graphhopper/graphhopper/issues/1039


Fix codestyle issues

grunt lint outputs these to issues.

@svbergerem can you rebase?

@lenovouser Done.

Travis CI error is unrelated. Thanks!


maybe/later: add button visible on hover to show quick facts/tips about the search engines?

Largely addressed with the Accordian and System Card at present.

More content is planned.


Question re. Throttling

Hi, this looks like an absolutely cracking project, so great work!  Saw it on DailyJS this morning.
Quick question re. throttling.  I have an application that is currently express based, but is basically an app that is 99% restful apis, and wanted to switch to this.  One of the big things I liked is the throttling, but had a question re. use.
e.g. I have a service (it does a form of click tracking) that can take over 1000 / tps, from users across the globe and is very high profile, hence we get lots of people often trying to break it.
The current throttling implementation looks like it will create an in memory hash for all of those users, that is never actually cleared by any background cleanup job?  Does this mean that over time it will eventually just fill up and fall over or am I missing something?
I was considering changing the implementation slightly to use a Redis backed set for the TokenBucket with a TTL on the key (e.g. of a minute), so it never got too large?  But if the above issue isn't correct I won't bother :)
Thanks,
Clifton

Hi Clifton,
Grr  - you are correct, this was one of those things on my whiteboard to fix that just sort of dropped into the ether.  Currently, it does just keep a table where the keys don't expire.
What I will do as part of this issue is actually refactor that a little bit to:

Allow you to insert your own storage layer for the table. I.e., redis, which is going to be useful if you have N API servers that you want to have enforce a "unified" request rate, as opposed to "good enough" if you assume uniform distribution (which, is currently what I do as I don't want a dependency on a shared redis - I've considered adding a gossip thing so that N servers do a better job than hoping for uniform request distribution. Obviously redis is easier).

Make the default in-memory store keys in an LRU, where you can set the max size (age doesn't seem like it will matter here at all).

That work?

Well - I chucked this in :)
If you can take a look at the changes and let me know if that works, I'll close this out, and it'll be in the next publish of restify (1.1.0).

Looks good, but will take me a little while to test, so happy for you to close this and I will re-open if I get stuck.
+10 marks for phenomenal response time :)
Clifton

hi Clifton,
Ok, I'll close this out - reopen if you see any problems when you get to it.


[MenuSubContent] Expose side prop

Description
Exposing the side prop on the MenuSubContent component.
Currently this just takes the side from the dir.

Wow I had just opened a feature request for this, what timing :)

@drKnoxy Do you mind running yarn version check --interactive so this gets captured in our changelog?


Docker standalone image build fail

Hi @GeoDerp.
The workflow for building the docker standalone image is failing.
I don't totally understand why.
We were previously building usin this image:
FROM python:3.11-slim-buster

That worked fine.
Any ideas to solve this if possible?

Tested everything and released new versions, everything works great!
But this workflow is failing.

No worries I'll have a look at this today 👍


chore(e2e): Update cypress 13.7.2 devDependencies in ui

Description
See if we can move forward again after downgrade from 13.2.0 to 12.17.4 to in #7920
https://docs.cypress.io/guides/references/changelog#13-7-1
https://docs.cypress.io/guides/references/changelog#13-7-2
Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed

yarn in ui
yarn start in ui
yarn cypress-open in ui/apps/platform

compliance/hideScanResults.test.js

Regression testing

yarn cypress-open in ui/apps/platform

Component testing

apps/platform/src/Containers/Clusters/DiscoveredClusters/DiscoveredClustersToolbar.cy.jsx TODO fails locally

Integration testing

vulnmanagement/clusterVCves.test.js
vulnmanagement/clusters.test.js
vulnmanagement/deployments.test.js
vulnmanagement/imageComponents.test.js
vulnmanagement/imageCves.test.js
vulnmanagement/images.test.js
vulnmanagement/namespaces.test.js
vulnmanagement/nodeComponents.test.js
vulnmanagement/nodeCves.test.js
vulnmanagement/nodes.test.js

gke-ui-e2e-tests failure:

Cypress verification timed out.

/test gke-ui-e2e-tests

gke-ui-e2e-tests has 2 failures at the following assertion:
https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/cypress/integration/vulnerabilities/exceptionManagement/ExceptionManagement.helpers.ts#L72
Retest to confirm pre-existing timing issues (that is, 2 out of 16 calls) and investigate separately.
/retest

ocp-4-12-ui-e2e-tests failure
Workload CVE Image Single page should display consistent data between the cards and the table test

Timed out retrying after 4000ms: Expected to find element: *:contains(1 result found), but never found it.

We will need to investigate whether this assertion is reliable, because data state can change.


Secret Handshake approach

Approach for Secret Handshake

@andrerfcsantos Thanks for the good catches! I need to give the Quality Control department in my brain a stern talking to. Should be ready to merge now.


Session::{fetch, uid_fetch}() fails to read full response and corrupts session

I'm not entirely sure what the issue is, however I have tried downloading a mailbox with thousands of mails and this occured: on a very big message, the result of session.uid_fetch(...).await?.try_next().await? returned None and the next request broke the connection with the error: io: inner stream closed. I did some further inspection with RUST_LOG=trace and found out that on every message I try to fetch which causes this error, the following happens:
[2022-12-17T16:05:25Z TRACE async_imap::imap_stream] decode: input: Ok("* 343 FETCH (INTERNALDATE ... some very long data and an HTML email ... </body>\r\n</html>\r\n UID ")
[2022-12-17T16:05:25Z TRACE async_imap::imap_stream] decode: incomplete data, need minimum 1 bytes

After that, it just return None and the next request returns an error. There seems to be an issue whenever the current input buffer ends with " UID ", because the only messages that ended with " UID " were the ones that caused this issue.

I'm seeing this too, but for non-UID fetches.

It has nothing to do with the sequence list.

How did you reach that conclusion?

Because in my case, the issue occurred without an empty sequence list. Sending an empty sequence list might possibly introduce a state corruption too, in that case this would be another issue, however in my case it happened with a non-empty sequence-list. If you look at my link above, it also has nothing to do with what is sent, rather than with what the library receives from the server.


[PAY-1757] Upgrade the Stripe SDK from 18 to 22

📲 What
Having done an investigation on how the existing Stripe/Apple Pay/Payment flows work inside the app, we have a lot of context describing the existing feature. This doesn't yet include any upgrades to Stripe/integration of the payment sheet/updates to apple pay/updates to the createBacking/updateBacking calls.
🤔 Why
We need to do this as not only technical debt/maintenance of the iOS application but to use the latest version of the Payment Sheet provided by Stripe.
🛠 How
Firstly we remove stripe-sdk 18 from carthage. Then we add it through SPM.
KsAPI and Library-iOS both compile fine and tests pass with new Stripe SPM version 22.
Kickstarter-iOS is the only remaining framework that fails to build. Here are some details about how the Stripes' changes effect our existing properties.
STP is the prefix Stripe uses, not us.
Case 1
Affected files:
AddNewCardViewController
AddNewCardViewModel
STPCardBrand has updated its enum case name from masterCard to mastercard:

Just a name change here.

STPAPIClient shared() to shared.  Objective-C singleton to Swift singleton on Stripes' side.

Just a name change here.

STPPaymentCardTextField has changed its return type of .expirationMonth and .expirationYear from NSUInteger to Int:

(Obj-C) to Int (Swift).
Existing CardDetails using Month and Year typealias, which was UInt, but Int is not convertible to UInt. So wrapping the Int value in NSNumber does not lose us any precision. That allows us to use the existing Month and Year properties of our in-app CardDetails PaymentDetails if they are changed from UInt to NSNumber.

With CardNumber and PaymentDetails updated for NSNumber now (because they use Month and Year) we a conversion of NSNumber to UInt inside where PaymentDetails is implement (createStripeToken uses STPCardParams which still uses Unit). That conversion is loss-less. UInt is larger than Int, and the NSNumber acts as a bridge between Int and UInt. Apple Docs info.

...more to come...
✅ Acceptance criteria

[ ] Existing pledge flows/Apple Pay/anything that touches a component of the Stripe library still works.

⏰ TODO

[ ] Fix all broken/uncompiling code, new conventions around the Stripe library.

SwiftFormat found issues:

File
Rules

Kickstarter-iOS/Views/Controllers/AddNewCardViewController.swift:363:1
warning: (indent) Indent code in accordance with the scope level.

  Generated by :no_entry_sign: Danger

merging this one before fully doing the acceptance testing so the alpha build can be tested on a real device.


[match] Add support for provisioning profile mapping for multiple app identifiers

Previously we didn't consider the use-case of having multiple app identifiers there
Fixes https://github.com/fastlane/fastlane/issues/9939

@KrauseFx Does this also possibly fix #9890? 🤔

Mh, not sure, what do you think?

@KrauseFx It looks like it might 😊  I will test out tomorrow morning 💪


btrfs driver seems to be unable to read filesystems

when testing using btrfs_x64 on my vm its unable to read my partitions saying "cannot get information of type {guid}"
when using OpenShell to see if the partitions are able to be accessed and going to /root the shell apparently seems to completely hang. dont know if this is an opencore compatibility problem with efifs yet

this is completely exclusive to btrfs i don't have this same problem on XFS

this is solved i just forgot to close it


Loan Disbursement Validation will now compare the disbursement date according to the timezone of the tenant.

Description
Loan Disbursement Validation will now compare the disbursement date according to the timezone of the tenant.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

[x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

[x] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.

[x] Integration tests have been created/updated for verifying the changes made.

[x] All Integrations tests are passing with the new commits.

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

I have done that.

@vorburger @vishwasbabu Can you please merge this?


Add a tile scrolling test to complex_layout app

complex_layout already has a nice scrolling test that contains many elements. I wanted to stress test the scrolling with a bunch of tiles with small images and lots of shadows (tiles are wrapped in Material with varying elevation). This has caused performance problems for Leafy in the past so I figure it would be a good addition to the micro benchmarks.

I like the idea of testing more.
cc @yjbanov @abarth for specifics though

Just a btw, this is what the benchmark looks like:

Since this aims to test shadow performance, I think it will be useful if @jason-simmons reviewed this PR too.

Ping. I would like to submit this as soon as possible so I can add it to the micro benchmark tests. Thanks!

Checked with @jason-simmons offline. It's good to go. I'll send a follow-up PR to add it to our dashboard.

Thanks for adding the benchmark!

FWIW, this change increased our memory usage and memory leakage on the benchmark, but had no measurable impact on the performance metrics themselves.

this change increased our memory usage and memory leakage on the benchmark

This is expected as the memory benchmark measures memory delta after all the application interactions are complete. After this change we have more code and more data, so a bump in memory usage is natural.

but had no measurable impact on the performance metrics themselves

Tile scrolling numbers are published under different names. I have yet to add them to the dashboard. They should not affect the original numbers.


"TypeError: 'float' object cannot be interpreted as an integer" in training.py line 63

I am on using python 3.6 and working on xgboost 1.2.0, following and I was facing following issue on fitting an instance of XGBClassifier to my training data.
TypeError: 'float' object cannot be interpreted as an integer
changing line 63 of training.py locally to the following resolves the issue for me:
 for i in range(int(start_iteration), int(num_boost_round)):
but this is a work around, I urge developer to resolve it a the root.

Did you pass num_boost_round as floating point?


How does PIM status impact Conditional Access policy

It's not clear what happens when a conditional access policy is filtered for specific roles, but the user is in the eligible state for that role, not the active state (using PIM).  Does conditional access get applied to users in the eligible state for a role?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cae7bc92-8489-ff66-9ce0-b4fab08eb7b8
Version Independent ID: 55dfcb5c-62cd-8485-7d55-de3459cb2854
Content: Users and groups in Conditional Access policy - Microsoft Entra
Content Source: articles/active-directory/conditional-access/concept-conditional-access-users-groups.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

They have to actively hold the role for policy to apply. Will clarify in doc.
#label:"assigned-to-author", "doc-enhancement", "triaged"
#reassign:@MicrosoftGuyJFlo


Hi, I encountered the following error while using this framework. Could you please advise on how to resolve it? My Redis is in cluster mode.

File "/data/tasks.py", line 177, in
scheduler = RedisScheduler(app=app)
File "/usr/local/lib/python3.9/site-packages/redisbeat/scheduler.py", line 48, in init
Scheduler.init(self, *args, **kwargs)
File "/usr/local/lib/python3.9/site-packages/celery/beat.py", line 257, in init
self.setup_schedule()
File "/usr/local/lib/python3.9/site-packages/redisbeat/scheduler.py", line 68, in setup_schedule
self.merge_inplace(self.app.conf.CELERYBEAT_SCHEDULE)
File "/usr/local/lib/python3.9/site-packages/redisbeat/scheduler.py", line 75, in merge_inplace
old_entries = self.rdb.zrangebyscore(self.key, 0, MAXINT, withscores=True)
File "/usr/local/lib/python3.9/site-packages/redis/client.py", line 2861, in zrangebyscore
return self.execute_command(*pieces, **options)
File "/usr/local/lib/python3.9/site-packages/redis/client.py", line 898, in execute_command
conn = self.connection or pool.get_connection(command_name, **options)
File "/usr/local/lib/python3.9/site-packages/redis/connection.py", line 1183, in get_connection
connection.connect()
File "/usr/local/lib/python3.9/site-packages/redis/connection.py", line 558, in connect
self.on_connect()
File "/usr/local/lib/python3.9/site-packages/redis/connection.py", line 655, in on_connect
if nativestr(self.read_response()) != 'OK':
File "/usr/local/lib/python3.9/site-packages/redis/connection.py", line 747, in read_response
raise response
redis.exceptions.ResponseError: SELECT is not allowed in cluster mode

Hi @tcxdgit , what kind of redis are you using?
And which type of redis cluster?


UE5.3 Preview?

Can you update the plugin so we can begin testing with UE5.3 Preview?

This support will be added over the next weekend, thanks for letting me know

If you can't download version 5.2 to automatically propagate to 5.3 Preview in your Epic Games launcher, you can download it from the sources here: https://github.com/gtreshchev/RuntimeAudioImporter/releases/tag/5.3.0
Alternatively, you can wait until Epic Games opens the door for updating the plugin for 5.3, as this version is currently not available for publishing the plugins on the Marketplace side.

Understood. Thank you so much! By the way, we really love your plugin. We're using it in our game, PinBuilder . It has become a vital piece of our game due the importance of allowing the player to import and use their own audio files with the pinball machines they create. Keep up the great work!


Better behavior when can't fetch node release index

What version?
0.41.1
Which command?
No response
What happened?
The site http://nodejs.org was briefly unreachable, causing proto to fail:
$ node
Error: plugin::call_func::failed

  × Failed to make HTTP request for https://nodejs.org/download/release/index.json.

I have the version set to node = "lts". The behavior in this case should probably be to either fail gracefully (as proto does when offline completely) or to print an error message suggesting to set the PROTO_OFFLINE environment variable.
Trace logs?
No response
Operating system?
Windows
Architecture?
x64

I'm not sure what the http libraries are doing under the hood, but my assumption also would be timeout related. Let me see what the current timeout is and if I can adjust it.

I had a quick look, and from what I could tell, unless you specify a timeout, the default is to not set a timeout...
This could likely be a quirk with running Windows within a virtual machine. Continuing to investigate. It's just strange that some tools install (like Node etc), and when accessing the URL directly within the VM using Edge, it loads fine, so not appearing like an SSL issue or the like, but just specifically with Rust executables not being able to connect... 🤔

Turns out this was a weird DNS issue on a Windows guest VM. I explicitly set Windows to use CloudFlare DNS and suddenly these connection issues stopped. Weird because accessing the URLs directly in the browser was fine within the VM. Annoying that the underling connection issue didn't mention DNS at all... but guessing that is down to reqwest?

In v0.42, we now cache requests for 12 hours. This should help avoid these hiccups.

In v0.42, we now cache requests for 12 hours. This should help avoid these hiccups.

That helps. Would it be simple to log a warning instead of fail outright? That would also help in the case of python where my desired version is "latest" but I want to use the latest locally installed version if indygreg hasn't updated the prebuilt yet.

The data from these requests are required, so we can't simply log a warning and proceed.

The data from these requests are required, so we can't simply log a warning and proceed.

Sure that’s the case when the tool doesn’t exist. in my case, it was doing an auto-install checking if there’s a newer lts. If there were no internet connection, it would skip the check, no?

It would require a bit of a rework to short-circuit out of the version resolve flow, especially only for an alias.


Fix failing test

Fix baseline for change made in #2942 that predated the verification tests being added.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.39%. Comparing base (7f7f46f) to head (abc90ad).
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2966   +/-   ##
=======================================
  Coverage   90.38%   90.39%
=======================================
  Files          72       72
  Lines        2851     2853    +2
  Branches      448      448
=======================================
+ Hits         2577     2579    +2
  Misses        274      274

Flag
Coverage Δ

Linux
90.39% <ø> (+<0.01%)
:arrow_up:

Windows
?

macOS
90.39% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cherry-picked into #2968.


Add tour guide to DSS editor

Purpose
Adding tour guide to DSS editor.

 All committers have signed the CLA.


C406 false positive

With something assigned to a two-tuple,dict([something]) incorrectly gets marked by C406 as something that can be converted to a dict literal.

I think it can only be turned into a dict literal when every element in the list is either a two-tuple or a two-list

although lists and tuples of other lengths would explode in the dict constructor, so when every element is either a tuple or list should be sufficient

dict([something]) # ok
dict([[]]) # bad
dict([()]) # bad
dict([("foo", "bar"), something]) # bad prefer -> {"foo": "bar"} | dict([something])
dict([{"foo", "bar"}] # bad (key-value lottery)
dict([{"foo": None, "bar": None}] # bad
dict([tuple((1, 2))]) # bad
dict([list((1, 2))]) #bad

I prefer to use
k, v = something
mapping = {k: v}


Fix shell_plus on python2.7

This should be compatible with all current python versions

Coverage remained the same at 52.847% when pulling 998c1a700dab50931aea42d83c0be959c1e335b3 on voidus:shell_plus_py27 into 300e46a5426dbdd1d34fbe3f8fa9bfd2d0790052 on django-extensions:master.

Looks like this is a dupe of #1175

Thanks for the PR ! and sorry for the inconvenience.
I merged #1175 only because it had a lower PR number ;-)

It's all good, just happy to see it fixed :)


Support use of ol package

OpenLayers is transitioning to ES6 modules and encouraging the use of a build tool such as Webpack or Rollup. I'm currently working on updating the ol3-layerswitcher, once I'm happy with the approach we'll need to do the same for ol-popup.

Happy to say that I've made some progress with this now.
WIP can be found in the ol branch, example here (currently Parcel only): https://github.com/walkermatt/ol-popup-examples

Looks like this might have been shipped, now https://github.com/walkermatt/ol-popup/commit/494a42c04d27319ef95e9c5abdd34f1289b43a72 Trying it out woooo!

Support for the ol package was added in https://github.com/walkermatt/ol-popup/releases/tag/v3.0.0.


books3_check_integrity.sh

This PR should help us do a weak check if the copies of our data match.

This integrity test may not be reliable because the disk usage may differ from system to system. E.g. yours already doesn't match mine. But an integrity check is necessary.
I propose we proceed as follows:

hash and compare the file_list npy files
load and merge all file names into one list of filenames, then load each book and keep a list of shapes in the same order as the list of filenames. Hash the list of shapes.

I'm working on a fresh install / download on a new machine to test this.

Out-of-band, we found that the download script is missing a manifest for one of the test splits, so a proposed check would miss that.
Let's bring in a new manifest and I'll update the hash.

Closing as this feature was added in commit e484843


[feature] Add some custom functions and how can I rebuild and republish it into npm?

I have added some custom functions , and I want to rebuild it, and republish it into private npm, but I don't hkow how to rebuild it , I try to exc yarn build  and I replaced the dist folder in my code , but it cant work .... I want to know how to di it

Closing this, check https://github.com/tldraw/tldraw for the latest! Not sure about build or publish issues, but the comments above should be helpful.


As an OSS developer, I can include an existing etcd v3 bosh release as part of my kubo-release

Tasks needed

CI already exists for ETCD. Make ETCD CI public
Remove failing tests that are no longer needed from CI

Tests to be removed:

everything consul release. We should use BOSH-dns or PowerDNS
rename test is not needed since we deploy on new BOSH only

Additionally, it would be nice to run tests on KuBOSH instead of custom BOSH.
On a side note, we can support only installation with TLS and thus remove upgrade from non-secure to secure cluster.

We are going to hold off on removing consul for now. The less we modify the release, the easier it will be to pull in upstream changes later on.
Also since consul is only required when using ssl, it makes more sense to remove it when we deal with the etcd ssl issues as a whole.

Infrastructure pipeline has bosh with 7 workers. This was breaking our current pipeline.
I changed this manually, now the split brain one leader [It] bubbles up a failure from consistency checker to bosh test is failing

tests are passing now, there was problem with BOSH cleanup

got extra debug output from develop branch of etcd release

etcd-turbulence tests failed.
We created issue for BOSH team: https://github.com/cloudfoundry/bosh/issues/1725

We were able to make etcd pipeline to pass with our environment.
Now we are working on renaming release to kubo-etcd.
Here is current pipeline for etcd
https://ci.kubo.sh/teams/main/pipelines/etcd/

We are working now on etcd-v3 branch that has been rebased on top of last etcd release. Currently turbulence job of the pipeline is failing. We disabled tests for now.  As soon as CI goes green, we plan to build final release from kubo-etcd and integrate it in kubo- deployment repo.

We have built the kubo-etcd release v2.


landing page: Footer page development

🛠 Fixes Issue
Closes #66

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x ] My code follows the code style of this project.
[ x This PR does not contain plagiarized content.
[x ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
I used CSS and Tailwind CSS for styling.

📷 Screenshots

@Basit46 kindly resolve your conflict to allow merging

Hey @Basit46 amazing work building the footer component. Can you resolve the merge conflicts by making sure your code is in sync and updated with the develop branch. Also render the footer component on the landing page.


ROX-14790: Enable log checks on nongroovy test

Description
Sets check_stackrox_logs=True in the openshift PostClusterTest for the nongroovy jobs to enable checking stackrox logs.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TBD

/test all

/test all

/retest-required

/test ?


Cannot Track Fish

I believe this is due to fish not having an instance of the BaseAI class. I don't have a proper development environment up to experiment with and try to fix this on my own. I've never setup a C# environment before or used visual studio. I was able to get ILSpy up and at least track this much down. I'm hoping this is a simple enough addition that it won't consume too much of your time if you're willing to add support.
Thanks!

Yes, currently the beam is only done for BaseAI. I could add it to fish too.


fallbackToIP causes error

If you prevent the use of location services in the browser, an error gets thrown when fallbackToIP is set to true.  "Cannot read property '_' of undefined"
It appears in the function
 notateGlobalObj: function notateGlobalObj(notation) {
		        notation = utils.trimDots(notation);
		        var levels = notation.split('.'),
		            o = window;
		        if (levels[0] === 'window' || levels[0] === 'document') {
		            levels.shift();
		        }
		        levels.forEach(function (note) {
		            o = o[note];
		        });
		        return o;
		    },

As the function iterates through the levels array, the variable o becomes undefined after the first iteration.  Also the notation variable has a value of "geolocator._.cb"  This code is trying to make an object key of '_' and I am not sure if that is intended.
thanks,

Pls see issue #42.
Pls try running the example in the same browser, conditions to see if it works.
Are you using a bundler?


TypeScript syntax highlighting breaks on "<{}>"

VSCode Version: Version 1.0.0 (1.0.0) 2016-04-13T10:59:46.727Z
OS Version: Mac OS X 10.11.4 (15E65)

The syntax highlighting in vscode gets confused by <{}> in a type declaration in a TSX file:
let root: React.ReactElement<{}>;
// syntax highlighting is broken for the rest of the file

For example, OK:

and broken (look at let and if):

This issue was moved to Microsoft/TypeScript-TmLanguage#161