Remove numpy implementation in test case?

I find, in most of test cases of Addons / tf.contrib, we are used to write a duplicated numpy function to verify the correction of our implementations. It's straightforward, but the drawbacks are:

both tf and numpy implications could be incorrect;
numpy might have a bug, or will introduce a bug in the future;
difficult to maintain test cases, and might also too complex to understand it.

Hence I propose to remove all numpy implementations, and replace them by explicit numerical value (and  add necessary comments to describe how to figure it out, say intermediate result of calculation) in test cases.
# No
def np_add(a, b):
    return a + b

self.assertEqual(np_add(1, 2), tf_add(1, 2))

# Yes
# Add some comments if necessary:
# c = a + b = 1 + 2 = 3
self.assertEqual(3, tf_add(1, 2))

cc @seanpmorgan @karmel

By the way, do we need to post those discussion needed issues to mailing list? Perhaps we could gain more attention, and collect more feedback there.

Some initial thoughts...

If possible I would prefer our unit tests not include another library
TF Keras testing does extensively use it, doesn't mean we have to but worth considering
I do think the likelihood of a bug in such fundamental pieces of numpy is probably low
Without having thoroughly checked all usages of np; I would be in favor of removing usage when there are TF equivalents.

I also think that emailing dicussion needed tags is a great idea. It could probably be made a bot if someone was willing.

I think the chances of hitting such a bug are quite low. (Of course as long as you stay with the „standard“ function and don’t do something crazy)
Implementing something wrong twice might happen. But it’s still better then implementing it once, since you have to express the algo in two different apis.
Also the amount of Tests you can create without numpy might be quite limited.
Of course the dependencie to numpy it self is bad, but in the usefulness of numpy is quite big.
Greets :)

If an input X is given, then its output Y has been determinate. We should explicitly claim what we want, and what the result should be.
Say, Y = f(X) =  X + 1, then Y is always 6 when X is 5. It looks strange that you create another function Z = g(X) = X + 1, then assert f(X) == g(X) when X = 5. Worse still, we have to maintain two functions here: f(X) and g(X).
Comparing keras.MeanSquaredErrorTest with addons.LiftedStructLossTest, I think keras.MeanSquaredErrorTest is more easy to understand, less error-prone.
My point is: we don't need to write a numpy python to calculate the result. Use assertEqual(Y, f(X)), rather than assertEqual(g(X), f(X)).

Also the amount of Tests you can create without numpy might be quite limited.

Would you mind giving an example to help us understand why?

Let's make it clear: take triplet_loss as an example, we implement it with tf ops. And numpy implementation meanstriplet_loss_np function we created by ourselves in its test python file.
Here the word "numpy implementation" used is for those functions created by addons, rather than for native tensorflow / numpy ops (like tf.exp and np.exp).

@facaiy
Hey Yan.
I think it is okay to use a function like that as long as you make sure that every subpart of the function is already tested.
For example if you have some transformation followed by a multiplication:
You could write tests for both parts (Multiplication and transformation) and make sure each part works correctly.
Afterwards I combine these parts into one separate numpy function to make it easier to test higher level functions for larger scale computations, edge cases or other weird stuff. Especially randomized initialization can become a problem here. I for example used a hybrid approach at normalizations where I initialised the weights with tf and used numpy to calculate the correct output afterwards.

But i get your point. It does not make sense to implement everything 2 times since both implementations could be wrong

The "correct" answer here may depend on context. In general, we tend towards just putting in numbers to avoid the tests getting cluttered. That said, that only works if the numbers are principled/understood in some way. That is, a classic bad habit is for a dev to run the code once, use the output as the test, and never validate that the produced output is actually the technically correct output. So, I would argue, as long as the derivation of the numbers is obvious enough that they can be re-derived, numbers are fine. If the way to derive the numbers in question is to run the same through numpy, may as well include that code for future devs, rather than having magic numbers in there. That said, all of this is opinion, and either way has advantages/disadvantages.

@facaiy Does it seem reasonable to replace numpy calls when it the expected values are understood (e.g. simpel matrix math), but to continue to use numpy when it is a pre-requiste to getting an answer? (e.g. large matrix math or as an input to a model evaluation)

Thanks for the great input, @Smokrow @karmel .
@Smokrow Yes, random data/variable is a good example, because its result is non-deterministic, so we have to write python function to calculate the result dynamically. Make sense for me, thank you!
@karmel

a classic bad habit is for a dev to run the code once, use the output as the test, and never validate that the produced output is actually the technically correct output.

Similarly, another bad habit here is that, developer writes a tf implementation and a corresponding numpy implementation, and then just check whether its results are same by feeding random data. I don't think it's fair to impute bad habit to method/tool.
And to avoid magic number, how about adding detailed comments to describe how to figure it out (say intermediate result of calculation) ? That's what I learned from https://github.com/tensorflow/tensorflow/pull/15443/files#diff-e37fe49087784a68c4a0d4417d941382R6730

What I think is not a good habit is, to use a numpy custom implementation with random data to verify the correctness of tf implementation, for example, TripletSemiHardLossTest. Those tests are what I propose to revise.
And I agree with @karmel @seanpmorgan @Smokrow: it depends on context. And the criterion is easy to understand and maintain.
Thank you all for your great feedback.
That's all what I can think of after the discussion:

Try to create a deterministic unit test if possible:

random data => replace it by: valid values + boundary values +  invalid values.
random variable =>

could we use a constant initial value?
set random seed.

For deterministic test case:

Try to write out the expected (numerical) value explicitly, rather than creating a duplicated numpy implementation to calculate the result.

If the value is too magic, try to write some detailed comments to explain how to get it.
If mathematical derivation is too complex / boring, and we find it can be replaced by numpy/scipy official (native) function easily. Use it for simplicity!

I don't know if this is overkill, but the test-numpy function could be implemented by a different developer. In that case we would have 2 different opinions of the same paper. The test implementation would be written first and afterwards somebody else implements the paper in Tensorflow. (Maybe even without looking at the test case)
Of course the drawback would be a lot of extra work. (both on organization and coding)

would be a lot of extra work. (both on organization and coding)

We have to take into account maintainability. If the numpy implementation is so good, I'm afraid it would be better to contribute it to numpy community.

We have to take into account maintainability. If the numpy implementation is so good, I'm afraid it would be better to contribute it to numpy community.

True 😄


Sort collection contents into collapsibles by field

Is your feature request related to a problem? Please describe.
Using the CMS for product listings can get overwhelming when there are dozens and dozens of items in one collection
Describe the solution you'd like
In the collection options, there would be an option to select a field that would be used for sorting. If there are multiple items with a field category and they repeat as Category 1 and Category 2, they'd show separately in the CMS UI in collapsible elements to only show those that the user currently wants to
Describe alternatives you've considered
Using sortable_fields kinda works, but it's still not really clear where each category starts/ends, and it still shows everything
Additional context
Mockup screenshot

I can't believe I missed that this feature actually exists pretty much exactly as I described - _ -
Don't try to reinvent the wheel at 1 am


fix: type change in flatMap

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Auto-assign address overwrites json options

Entries
        "ipbus_rel_path": "../../submodules/ipbus",
        "vip_ipbus_rel_path": "../../submodules/vip_ipbus",

disappears when running with option -a.

Closed with https://github.com/olagrottvik/bust/pull/68


Updated notebook setup guide for Kubeflow 1.0.0 UI

Fixes https://github.com/kubeflow/website/issues/1761
Fixes https://github.com/kubeflow/website/issues/1507
A number of options have changed in the notebook setup for Kubeflow 1.0.0. This PR updates the setup guide accordingly.

This change is

Preview: https://deploy-preview-1762--competent-brattain-de2d6d.netlify.com/docs/notebooks/setup/
@kimwnasptd Please would you review this PR and LGTM if you're happy with the updates?
/cc @kimwnasptd

/assign @abhi-g
@abhi-g Could you take a look at this PR or assign someone else to do so? I'm not having much luck finding a reviewer. :)

Sorry for the delay @sarahmaddox taking a look right now :)

/assign @kimwnasptd
/unassign @abhi-g
Thanks @kimwnasptd PTAL

/lgtm

Thanks @kimwnasptd !
/approve


Remove --with-dns support

This got a bit mangled when weaveDNS was merged into the router (see #1748) - it makes little sense now, so lets remove it:

From docs
From proxy

Removed from docs in 1d9ef76080116194c904420b4a4adf639d2ca9cc


JSON Schema $ref is not supported

Add support for self referencing $ref (reference is within the same document).
Identify level of effort for resolving HTTP(S) $refs. Then comment and collaborate to determine if level of effort meets benefit.

@awm33 I think we can probably close this as we now have basic $ref support. When we have a feature request/run into more advanced $refs usage, I think we can revisit our approach at that time.

Agreed


test: adding acess log utils for the integration test

Risk Level: n/a (test only)
Testing: added a sample test
Docs Changes: n/a
Release Notes: n/a

Originally intended to be part of #6542 only I realized a bit late I can't get the info I want out of access logs without sticking it in headers or doing some extra plumbing.
I still think it's a useful util, WDYT?


Android Production Deploys are failing

Keeping this issue internal since this requires Google Play access to confirm the builds show up in the internal track
cc @Expensify/mobile-deployers
Expected Result:
Android deploys such as this one should succeed
Actual Result:
Android deploys are failing with the following error message:
Track 'internal' doesn't have any releases
Action Performed:
This happens during the Run Fastlane step of the Build and Deploy Android
action
Platform:
Where is this issue occurring?

Android

For the run mentioned above, we see [22:53:31]: Found '1001004400' version codes in track 'internal' in the logs, and in the google play console we see that the 1.0.44-0 release is in the Internal Testing track, but for some reason fastlane still doesn't see the release.
Potentiall related: https://github.com/fastlane/fastlane/issues/18497

@roryabraham did you have any ideas or additional context on this one? Thanks!

Any @Expensify/mobile-deployers have any extra bandwidth to look into this?

Had a quick look at this today since the build failed again, going to create a PR to see if I can get it working. Notes:

Since version 2.135.0, it seems that Google Play automatically removes releases that are superseded (see check_superseded_tracks)
The code that throws this error is here
When we create the production build, we're re-using the previously used version, but we don't specify version_codes_to_retain in the upload_to_play_store config, which could be causing the issue
Looking at this failed build, the build fails at 00:42:00 whereas the next closest build uploads at 00:55:00, so it doesn't look like this is caused by a new build overwriting the old one

Or it could be b/c the version_code is just set to 0 🤦

Ok, not sure what the issue is here. Running the echo command that sets the output seems to be working find locally, and the path seems correct since we run similar commands that make it seem we're in the root. cc @AndrewGable in case you have any ideas since you wrote the regex

Looks like this is still happening here: https://github.com/Expensify/Expensify.cash/runs/2778864820?check_suite_focus=true

I believe we've narrowed it down to the regex doesn't work on Ubuntu and used to work on MacOS

After confirming that the current regex doesn't work in our ubuntu VMs, I found a variation that does seem to work in both ubuntu and macOS:
echo "VERSION_CODE=$(grep -e 'versionCode\s\+[0-9]\+' android/app/build.gradle | awk '{ print $2 }')"


Regex doesn't works

What are you trying to achieve?
I'm using regex to filter and don't run scripts whith @tag negated in regex
What do you get instead?
(?!.*@tagxyz) was unexpected in the moment.

Provide test source code if related
Feature('@ABC @tagxyz');

Run using: codeceptjs run --grep "(?=.@ABC)^(?!.@tagxyz)"
Reference: http://codecept.io/advanced/
Details

CodeceptJS version:  "^1.0.0",

NodeJS Version: "v6.11.2"

Operating System: Windows 10 Pro x64
*WebDriverIO: "^4.8.0"

@BrunoExterckotter Could you please provide error message from console?
I think that maybe you should escape several symbols in your script like this:
 codeceptjs run --grep "\(\?\=\.\*@ABC\)\^\(\?\!\.\*@tagxyz)"

The first command was accepted, but de second command was not. Apparently. Am I doing something wrong?

The first command was accepted, but de second command was not. Apparently. Am I doing something wrong?

@BrunoExterckotter Are you still have problems with the grep option?
I think this is a limitation of mocha as the --grep parameter is passed directly to mocha. Though you can use the --invert --grep '@tagxyz' which will match everything does not have the @tagxyz.
Otherwise I would recommend splitting up your tests into different folders and then define different codeceptjs config files for each. If you use the Dynamic Configuration then you can require common configuration and only change the grep field.

@reubenmiller I'm not sure if I should open a new issue for this, but I'm having similiar problem with grep option.
Although I don't use the inverse regex.
I've tried to debug the issue. I noticed that options.grep is passed to mocha, however it is overwritten with the first test file. It is overwritten after  return Mocha.prototype.loadFiles.call(mocha, fn); is called inside mochaFactory.js
https://github.com/Codeception/CodeceptJS/blob/72b46931dbcdc89b9a309b3748ad8db29fb7e8bf/lib/mochaFactory.js#L48
so for example, when I call npm run codeceptjs run --grep @stable the test first test from 'tests' glob is executed.
codeceptjs 1.3.2
node: 8.11.3
windows 10 64x


eslint (and sublime-linter-eslint) cannot resolve .scss files

Folder structure
src/
|-- styles/
|   |-- foo.scss
|
|-- containers/
|   |-- Foo.jsx
|
|-- modules/
    |-- foo.js

Foo.jsx
import styles from 'styles/foo'; <--- error: import/extensions: Missing file extension "scss" for "styles/foo"
import styles from 'modules/foo'; <--- no errors
...

webpack.config.js
{
  ...
  resolve: {
    extensions: ['', '.js', '.jsx', '.scss'],
    modulesDirectories: [
      path.resolve(__dirname, 'src'),
    ],
  },
}

package.json
"devDependencies": {
  ...
  "babel-eslint": "^7.1.1",
  "eslint": "^3.12.2",
  "eslint-config-airbnb": "^13.0.0",
  "eslint-import-resolver-webpack": "^0.8.0",
  "eslint-plugin-import": "^2.2.0",
  "eslint-plugin-jsx-a11y": "^2.2.3",
  "eslint-plugin-react": "^6.8.0",
  "extract-text-webpack-plugin": "^1.0.1",
}

.eslintrc
{
  "parser": "babel-eslint",

  "extends": "airbnb",

  "plugins": [
    "react",
    "jsx-a11y",
    "import"
],

  "rules": {
    "no-param-reassign": 0,
    "react/prop-types": 0
  },

  "settings": {
    "import/resolver": "webpack"
  }
}

I don't see why you'd need to import scss files in jsx.
import is used for importing other ecmascript files, not styles.

@soryy708 it's done so that bundlers (webpack) know when to include the relevant styles, and can link them together.

You have to configure your extensions setting as well.

@ljharb Can you please explain a bit more on what needs to be added to the settings?
I'm having the same problem with just the scss files!
// webpack config:
resolve: {
    extensions: ['.js', '.jsx', '.scss'],
    alias: {
      // aliases...
    },
    modules: [
      // src path, ...
    ],
  },

// .eslintrc
{
  "extends": [
    "eslint:recommended",
    "airbnb"
  ],
  "parser": "babel-eslint",
  "parserOptions": {
    "ecmaVersion": 2018,
    "sourceType": "module",
    "ecmaFeatures": {
      "jsx": true
    }
  },
  "env": {
    "es6": true,
    "browser": true,
    "node": true
  },
  "settings": {
    "import/resolver": {
      "webpack": {
        "config": "webpack.conf.js"
      }
    }
  }
}

And everything works for the .js and .jsx files, but with the scss files, if I omit the extension, I get this error:
 error  Missing file extension "scss" for "./App.styles"  import/extensions

Isn't the whole idea of defining webpack config as the import/resolver setting to prevent repeating the same settings in the eslint configs (for resolve and its options including aliases and extensions)?

Ok, found the problem!
It wasn't related to the "import/resolver"'s settings.
It's the expected behavior of the "import/extensions" rule. Because I was using the airbnb settings, and their rule only includes js, mjs and jsx:
    'import/extensions': ['error', 'ignorePackages', {
      js: 'never',
      mjs: 'never',
      jsx: 'never',
    }],

So I had to add scss's rule to my own .eslintrc...
    "import/extensions": [
      "error",
      "ignorePackages",
      {
        "js": "never",
        "mjs": "never",
        "jsx": "never",
        "scss": "never"
      }
    ]


Add course is not working

It's not possible to add new courses to the app. Sie submit button seems to have no effect

Seems to only be an issue in the deployed version on Azure. When running locally it works.

Maybe it has something to do todo how azure handles docker container. Maybe they suspend them when there is no activity. Is there a way to release the database access after some time of inactivity?

Currently working on multi DBMS support so we can use Azure's Sql #40
Will not investigae for now.


Timesheet - 28/04/2021 - Kristy Lee

Task 1
Designing lock history, lock panels, ideas for communicating locking and boosting concepts, fixing illustrations on the empty states. (On the side while designing: Had to review final landing page designs by Mr K, reorganizing figma files for better internal management, updating design board with newest progress**
Proof of Work

https://www.figma.com/file/k7D7Fwbz08hU6ZESPOsyvE/Governance-V2.0?node-id=185%3A16885

Time Spent
5 hours

Total Time Spent
5 hours
Account Number
a2d73cf3b37a62276ade44a96860495510d0e7d7c468950d4e49ac8a62b3d31d

Approved

Approved


Fixed url sanitization

URL sanitation was miss behaving leading to URLs with suffix .git that go-git doesn't accept causing errors when attempting to clone the repo. It was tested by adding unit tests  for all possible combinations and making sure smoke and accept tests passed.

Hey Jose, have you manually tested the whole flow and checked the status of the GitRepository? I remember that breaking without the .git.


Update mvd-using.md to improve 3270 and VT entries

Improves the 3270 and VT plug-in descriptions and makes them technically accurate, less confusing.

Is there a related issue for this PR?
Issue number: #977
Developer's Certificate of Origin (DCO)

@jasonenglish2039 @1000TurquoisePogs Hi Jason, Sean, could you review this PR? See issue #977 for the background of these changes. Thanks!

@ajinrocket can you look into making these updates. They don't look too difficult, but ask me any questions.

@1000TurquoisePogs this seems to me almost entirely a UI change. If I search the documentation for "TN3270" I get the simple description of the app (https://docs.zowe.org/stable/user-guide/mvd-using.html#tn3270), plus a couple of release notes. If I search on "3270" I get the plugin tutorial which refers to it (correctly, I think) as the "3270 Terminal application."

@jasonenglish2039 @1000TurquoisePogs Agree with Jason. This requires a UI change by renaming TN3270 to 3270 Terminal. IMO, if the docs are not quoting the exact UI label name, such as Click the TN3270 icon on the Zowe desktop, it should be good to call it just the ·3270 terminal` in descriptions. UI change should be added as a work item for a future release.

@sipples the changes you want to make here look fine to me, but @nannanli I do not think sipples can commit to directly to master right. They would need to change this to commit to docs-staging to get the edits into 1.9?

@jasonenglish2039 Sorry for the late comment. As 1.9 has already been published, now it's ok to merge this to master directly. I'm going to merge this PR now but feel free to raise any concerns or comments if any.

Any reason not to merge this? @jasonenglish2039 @nannanli

Merge it!


Microsoft.Data.SqlClient.SNI not deployed to _PublishedWebsites for an ASP.NET Web Application

Background
For ASP.NET Web Applications it is common to build them providing /p:OutDir=someDir  (or /p:OutputPath=someDir) parameter and then taking the _PublishedWebsites\WebApp contents and xcopy-ing them.
The custom SNI-deploying targets do support OutDir but not for a web app scenario - the SNI .dlls don't get copied to _PublishedWebsites\WebApp\bin.
Steps to reproduce
A repo with a blank ASP.NET Web App and steps to reproduce: https://github.com/mbakalov/SqlClientSniRepro1
To reproduce, in VS command prompt do:
msbuild /t:Build /p:Configuration=Release /p:Platform="Any CPU" Example.sln /p:OutDir=C:\temp\output

The SNI .dlls get copied to C:\temp\output, but not to C:\Temp\output\_PublishedWebsites\WebApp\bin
Expected behavior
Expected the SNI .dlls to be copied to the "bin" folder of the published website.
Further technical details
Microsoft.Data.SqlClient version: 2.1.1
.NET target:  net461
Related issue: https://github.com/dotnet/SqlClient/issues/441

Hi @mbakalov
Thanks for the repro. We'll investigate and get back to you soon!

@cheenamalhotra  - thank you for a quick response!
I'd worked around this for now by adding the below target to my webapp.csproj:
<Target Name="_CopySNIFilesToWebProjectOutputDir"
        AfterTargets="CopySNIFiles"
        Condition="'$(WebProjectOutputDir)' != ''">

	<Copy SourceFiles="@(SNIFiles)"
	      DestinationFiles="@(SNIFiles -> '$(WebProjectOutputDir)\bin\%(RecursiveDir)%(Filename)%(Extension)')"/>
</Target>

It works well enough for my scenario, but looking into the Microsoft.WebApplication.targets file, the correct fix is probably much more complicated.
Thanks again!

I can confirm. I have the exact same issue.
When publishing locally via visual studio, it works.
When publishing via teamcity it doesn't.

@cheenamalhotra - thank you for a quick response!
I'd worked around this for now by adding the below target to my webapp.csproj:
<Target Name="_CopySNIFilesToWebProjectOutputDir"
        AfterTargets="CopySNIFiles"
        Condition="'$(WebProjectOutputDir)' != ''">

	<Copy SourceFiles="@(SNIFiles)"
	      DestinationFiles="@(SNIFiles -> '$(WebProjectOutputDir)\bin\%(RecursiveDir)%(Filename)%(Extension)')"/>
</Target>

It works well enough for my scenario, but looking into the Microsoft.WebApplication.targets file, the correct fix is probably much more complicated.
Thanks again!

This workaround works for me.
Hoping has non-workaround fix soon.

For some reason, this is really biting me now. A number of production pushes now have resulted in failures due to this.

The problem occurs when using VS2022 (msbuild 17) to publish Web Applications using any version of Microsoft.Data.SqlClient, the files are not copied to OBJ folder and then not copied to final target folder.
If using VS2019 it works fine, in VS2019 build log we can see:
CopyAllFilesToSingleFolderForPackage:
  Creating directory "obj\Release\Package\PackageTmp".
  Copying all files to temporary location below for package/publish:
  obj\Release\Package\PackageTmp.
  Copying D:\362\s\packages\Microsoft.Data.SqlClient.SNI.1.0.19235.1\build\net46\x64\SNI.dll to obj\Release\Package\PackageTmp\bin\x64\SNI.dll.
  Copying D:\362\s\packages\Microsoft.Data.SqlClient.SNI.1.0.19235.1\build\net46\x64\SNI.pdb to obj\Release\Package\PackageTmp\bin\x64\SNI.pdb.
  Copying D:\362\s\packages\Microsoft.Data.SqlClient.SNI.1.0.19235.1\build\net46\x86\SNI.dll to obj\Release\Package\PackageTmp\bin\x86\SNI.dll.
  Copying D:\362\s\packages\Microsoft.Data.SqlClient.SNI.1.0.19235.1\build\net46\x86\SNI.pdb to obj\Release\Package\PackageTmp\bin\x86\SNI.pdb.

Lines above doesn't exist in VS2022 build logs.
Any updates @cheenamalhotra ?
Thanks

I did find this, and it's at least helped with the situation where IIS express can't deploy because of locked files.

Any update on this? @poychang 's workaround is not working. The only way I can get it to work is on each device after install, to manually copy and paste the x64 and x86 folders with SNI inside it to the application folder "C:\Users\Scott\AppData\Local\Apps\2.0\KD9YXEPJ.DKY\5QCR3OCQ.WRY\vent..tion_098ef6a925fa6387_0001.0009_35951381a6b516d2"
for each machine. I need to install this program often enough for this to be a hassle.
Any idea how I can streamline it better or find another workaround?
Thanks!

The experience is better in newer versions of Microsoft.Data.SqlClient. Try something newer than 1.x.

I get this error whenever I try to upgrade to 2.0.0:
Failed to add reference to 'Microsoft.IdentityModel.Logging'.
Error HRESULT E_FAIL has been returned from a call to a COM component.

The experience is better in newer versions of Microsoft.Data.SqlClient. Try something newer than 1.x.

I updated to Microsoft.Data.SqlClient 5.0.0 and Microsoft.Data.SqlClient.SNI 5.0.0 and still the same issue

I just ran the sample repro project from the original author of this post https://github.com/mbakalov/SqlClientSniRepro1 and upgrade the project from .NET Framework 4.6.1 to 4.6.2 since M.D.S 5.0 only support 4.6.2 and above and ran the
msbuild /t:Build /p:Configuration=Release /p:Platform="Any CPU" Example.sln /p:OutDir=C:\temp\output and the SNI.dlls (i.e. Microsoft.Data.SqlClient.SNI.x64.dll, Microsoft.Data.SqlClient.SNI.x86.dll and along with their pdbs) were copied into the output folder.

@Scott-VentsUS are you able to provide a different repro sample as the one provided from the original author works fine.

Just came across this issue and I can still reproduce it using the reproduction repo and the VS2022 build toolchain.
@lcheunglci I can see the files are copied to the build output folder as you mention, but the OP stated that they were actually copied there, they're missing from the published website folder though, in the _PublishedWebsites\WebApp\bin subdirectory. Do you mean that location in your comment?

@cheenamalhotra any progress on this issue? Are you waiting for anything?

another workaround:
  <Target Name="_CopySNIFilesForPublishPackage"
        AfterTargets="CopyAllFilesToSingleFolderForPackage">

    <Copy SourceFiles="@(SNIFiles)"
          DestinationFiles="@(SNIFiles -> '$(_PackageTempDir)\bin\%(RecursiveDir)%(Filename)%(Extension)')"/>
  </Target>

Hello,
This issue seems to be recurring (continuing to occur?) with VS 2022 & Microsoft.Data.SqlClient 5.2.2 / Microsoft.Data.SqlClient.SNI 5.2.0.
I've cloned mbakalov's original repo and updated it to net48 and Microsoft.Data.SqlClient 5.2.2, https://github.com/smaglio81/SqlClientSniRepro1
The output-reproduction.log shows the _CopyWebApplicationLegacy target runs before CopySNIFiles, and that none of the SNI specific files are copied into the _PublishedWebsites folder.
Work Around
It looks like mbakalov's original workaround is still very relevant. Unfortunately, luiz-soares's did not work for me.
I updated mbakalov's original workaround to use the Conditional statement from _CopyWebApplicationLegacy in Microsoft.WebApplication.targets and that seemed to be a working fix.
I placed it the .csproj file just below the <Import> of Microsoft.Data.SqlClient.SNI.targets:
  <!-- for people trying to implement the workaround, the Import line will already exist in your .csrpoj file -->
  <Import Project="..\packages\Microsoft.Data.SqlClient.SNI.5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.targets" Condition="Exists('..\packages\Microsoft.Data.SqlClient.SNI.5.2.0\build\net462\Microsoft.Data.SqlClient.SNI.targets')" />

  <!-- add this Target after the Import -->
  <Target Name="_CopySNIWebApplicationLegacy"
        AfterTargets="CopySNIFiles"
        Condition="!$(Disable_CopyWebApplication) And '$(OutDir)' != '$(OutputPath)'">

    <Copy SourceFiles="@(SNIFiles)"
          DestinationFiles="@(SNIFiles -> '$(WebProjectOutputDir)\bin\%(RecursiveDir)%(Filename)%(Extension)')"/>
  </Target>

Possible Fix
Adding mbakalov's workaround, to Microsoft.Data.SqlClient.SNI.targets seems to fix the issue.
I was unable to find Microsoft.Data.SqlClient.SNI.targets within this source control repository so I haven't been able to create a pull request with the update (sorry).
Example update to Microsoft.Data.SqlClient.SNI.targets:
  <Target Name="CopySNIFiles"
          Condition="'$(CopySNIFiles)' != 'false' And
                     '$(OutDir)' != '' And
                     HasTrailingSlash('$(OutDir)') And
                     Exists('$(OutDir)')"
          Inputs="@(SNIFiles)"
          Outputs="@(SNIFiles -> '$(OutDir)%(RecursiveDir)%(Filename)%(Extension)')">
    <!--
        NOTE: Copy "Microsoft.Data.SqlClient.SNI.dll" and all related files, for every
              architecture that we support, to the build output directory.
    -->
    <Copy SourceFiles="@(SNIFiles)"
          DestinationFiles="@(SNIFiles -> '$(OutDir)%(RecursiveDir)%(Filename)%(Extension)')" />
  </Target>

  <Target Name="_CopySNIWebApplicationLegacy"
        AfterTargets="CopySNIFiles"
        Condition="!$(Disable_CopyWebApplication) And '$(OutDir)' != '$(OutputPath)'">

    <Copy SourceFiles="@(SNIFiles)"
          DestinationFiles="@(SNIFiles -> '$(WebProjectOutputDir)\bin\%(RecursiveDir)%(Filename)%(Extension)')"/>
  </Target>

Hopefully, there will be an updated .targets file in the next release?


M001 is not working

With ruff v0.0.59 given a file like:
def foo() -> None:
    a = 1  # noqa: F401
    print(a)

Running:
ruff --extend-select M001 test.py

There are no errors

Interestingly I actually get:
∴ ruff --select M001 foo.py
Found 1 error(s).
foo.py:2:10: M001 Unused `noqa` directive for: F401
1 potentially fixable with the --fix option.

Does ruff --show-settings test.py have anything interesting?

Oh duh user error, I had a config file floating around...

Out of curiosity: what was the config file doing? Did it have an explicit ignore on M001? Something else?

Did it have an explicit ignore on M001?

Yes 🤦🏻 , I don't even remember why I put it in there. Embarrassing.

Not embarrassing at all! It's bad that it was confusing for you as the user. If you explicitly --select something that's ignored by the config, we should warn you.


:book: Documentation: Table of Contents navigation doesn't work

The menu on the right doesn't work. It seems there's a discrepancy in the use of capital letters. The reference to a section is case-sensitive, but the link after clicking on an entry in the table-of-contents is all lower case. I believe this is a known issue in mkdocs as it affects Datamol as well.

This seems to work again!


Downloading stash for Standard error

[Error] Downloading stash for Standard, details logged to DebugInfo.log
name: Darkcaster2
pc

We need more information to act on any errors. Specifically, the DebugInfo.log file. I would also venture a guess it might be the same as #1158.


test-suite instrumentation

This adds two important metrics to the the test-suite runner:
a) At the start of the test run, print the total number of serial and
parallel tests.
b) At the end of the test-run, print the total time taken for parallel
and for serial tests.

So the total overhead for the test instrumentation is about 10 seconds when using 12 cores on my Mac book.

@stuartarchibald how should we proceed with this one?

Is it ready for review? Seems like 10s extra on top of the hour run time is not worth worrying about?

@stuartarchibald yes, I think you can take a look at it, maybe you have some more ideas on how to tweak this?


Adding support to run tests with tox

The benefit of having a tox.ini is that you can test against multiple versions of python and django locally. So you will catch issues before they go to the CI server.
I also added pypy tests and tests for multiple versions of django to the travis tests to catch more issues. Like the one we experienced for #387, #386 and #384.
The branch also includes a few minor fixes that I encountered during various test runs along the way.
Please merge #388  before merging this pull request.

it is already fixed. thank you @galuszkak and @gregmuellegger .


[subplugin] Create initial nnstreamer trainer subplugin @open sesame 11/11 10:50

[subplugin] Create initial nnstreamer trainer subplugin

Create initial version
Modify meson.build and meson_options.txt

Self evaluation:

Build test:   [X]Passed [ ]Failed [ ]Skipped
Run test:     [ ]Passed [ ]Failed [X]Skipped

Signed-off-by: hyunil park<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2037. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @songgot, nnstreamer/tensor_trainer/tensor_trainer_nntrainer.cc does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @songgot, nnstreamer/tensor_trainer/tensor_trainer_nntrainer.cc does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @songgot, nnstreamer/tensor_trainer/tensor_trainer_nntrainer.cc does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2037-202211101213380.33570909500122-7d63dd9ed7d25b3edad9c8b2df8f45e765310dee/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2037-202211101403390.33939790725708-8e9598a01d5af4f2cc66b6785d72f698c537d851/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2037-202211111051110.51378893852234-8e9598a01d5af4f2cc66b6785d72f698c537d851/.

:octocat: cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2037-202211171411550.55965304374695-59e1f50cd04de89247a07a50353cedf84c759047/.

plz fix the ci

Removed


Add definition for Navigator.bluetooth

Documentation in https://developer.mozilla.org/en-US/docs/Web/API/Bluetooth/requestDevice

reported originally in https://github.com/Microsoft/TSJS-lib-generator/issues/294

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

Assuming this is fixed or irrelevant. Please file a new issue using the lib template


[request] Remove checkpoints and LFS from the repositories

It would be much faster, as well as more readily working if they were uploaded to a file sharing site. The LFS files seem to always fail to download, and for some reason bluescreen my computer. I have seen others with similar problems downloading, and so I think this would help fix some of the troubleshooting issues people have

Are you talking about this repository or the huggingface checkpoint? This repo should not contain any checkpoints, just a few small images

the hugging face checkpoint, apologies i should have specified

I'm not sure exactly what the problem is, but as I understand storing the checkpoint as a huggingface model is totally standard, so not inclined to change it. For example see the source model: https://huggingface.co/runwayml/stable-diffusion-v1-5/tree/main


wsl with ubuntu, vscode and devcontainers just to run this?

like we need more proof that microsoft hates python
cant even decide on what os to support

learn what poetry is and how to write multi stage docker files

and then this happens

honestly why would it work,. right

PLEASE HIRE SOME PYTHON SENIORS THIS APP IS RETARDED


Cannot find the application after installation

I hacked my N97 and installed the Dumber.sis successfully.
Then I can find Dumber.exe in C:\sys\bin\ but I cannot open it.
Also, I cannot find the entry of Dumber in the Menu.

Then I can find Dumber.exe in C:\sys\bin\ but I cannot open it.

That's weird. I think if there's no memory card the app will crash. Can you check that?

Also, I cannot find the entry of Dumber in the Menu.

It's supposed to be in a folder called "RnD Tools" on main menu. Have you checked that?

I do have an E drive, which is the phone's internal memory and has enough spare space.
I have checked all folders under main menu, but found nothing called "RnD Tools".
I just found that the sis files provided in repo and release page are earlier than the menu entry commit, are they updated? I have no idea on how to build the app.
BTW, are ".exe" files supported executables in symbian? Do they have any relation with windows exe files? I think the file explorer is complaining that exe is not a supported file and thus cannot be opened.


Display feature layers

This sample replaces 4 feature layer samples (feature service, geodatabase, shapefile, geopackage).
This PR implements `Display feature layers` in `feature` category.
Branch: [URL_TO_BRANCH](https://github.com/Esri/arcgis-runtime-samples-ios/tree/Viv/featureLayerSamples)

Linked Issue(s)
common-samples/issues/3245
How To Test
Use the bottom toolbar to view different feature layers from various sources.
To Discuss
During review, someone suggested that this sample be moved to the top of the list since it showcases foundational workflows. This also led us to discuss reorganizing the order of samples within their categories. So perhaps we can reorder this sample in another PR if we decide to reorder the samples.

Thanks everyone for the reviews!


[ scripts | brew | fix output when choose to not install a cask]

If we choose N for installing a specific cask, the output is always zsh-completions
Expected: output is the appropriate cask name

https://github.com/timausk/dotfiles/commit/5245abe3c9ef8a55044428c16c89e3c1a1e94e2d


The script k8s-get-cilium-pod.sh is not in repo

The script is used in this doc
http://cilium.readthedocs.io/en/latest/troubleshooting/#retrieve-cilium-pod-managing-a-particular-pod

It's pointing to the release bucket. It will be available when we release 1.1.


fix: exit code when failing in root test run

Explanation
Fix exit code when failing in root test run.

/cherry-pick release-0.2


Oppp

https://github.com/Meinne1/maik-meinne.onmicrosoft.com/issues/6

Not sure if I understand this issue. Can you please provide more information so we can try to help?


Some Latin characters cause to_ascii to return an empty result.

It's my understanding that STRATEGY_IGNORE should "add characters to result", which to me sounds like it should retain the character in the output if it isn't matched.
However, I cannot seem to retain my complete original input
import homoglyphs_fork as hgf
hg = hgf.Homoglyphs(strategy=hgf.STRATEGY_IGNORE)

'ß' in hgf.Categories.get_alphabet(['LATIN'])
>>> True

hg.to_ascii('ß')
>>> []

This is an issue because there are characters that, while not true homoglyphs, can still be used as them. Consider the German eszett, ß, which is a common stand-in for 'B' online.
Because of this, I'm unable to properly detect (as an example) the string 'Сaptchaß𝗈t' -- Cyrillic ES (homoglyph of latin C), German Eszett (leet-speak for latin B), and Mathematical o (normalized to latin o). The best I've been able to achieve is Captchaot with strategy LOAD and ascii_strategy REMOVE.
Is there a way to have homoglyphs simply pass-through any character that isn't matched?

I believe this is happening as ß is not considered as a confusable by the Unicode Consortium. While I believe that this shouldn't be the case, this is also outside the scope of this library as it seems to be basing everything from the confusables.txt file the Unicode Consortium is providing, which is parsed by generate.py to generate the confusables.json file that the library then parses for conversion to ASCII.

This has been fixed in v2.1.0
The issue was that the ignore strategy was being applied incorrectly and was effectively the same as the remove strategy.
You will need to now specify the ignore strategy so as not to break existing builds.
import homoglyphs_fork as hgf
hg = hgf.Homoglyphs(ascii_strategy=hgf.STRATEGY_IGNORE)


Overriding attributes on hidden field

I am trying to submit a form whenever the value of the combobox changes. My first approach would be to add an onchange listener to the input, but it seems like only the value of the hidden input changes when selecting a different value.
My naive approach, that isn't working:
<%= form.combobox :category_id, Transaction::Category.all, input: { onchange: "this.form.requestSubmit()" } %>

I believe being able to customize the attributes of the hidden field would allow for that:
<%= form.combobox :category_id, Transaction::Category.all, hidden_input: { onchange: "this.form.requestSubmit()" } %>

Is there are more obvious different approach that I am missing? If not I have a branch to add the hidden_input kwarg to HotwireCombobox::Component to override hidden input attributes that I am happy to open as a PR.

Interesting use case! I think supporting this makes sense.
I don't think adding onchange to the hidden input would do what you want because I believe change events for inputs only fire after losing focus — which the hidden input never had. I might be wrong though.
One thing we could do is emit a custom event in ._commitSelection() and/or in ._ensureSelection(). I'd have to do some thinking on which would be better.
Then you're free to listen for that event e.g. in a stimulus controller and auto-submit the form. Although I'd suggest you look into the accessibility implications of that.

You are right, onchange doesn't work here. I was able to get it working with my branch by adding a stimulus controller to the hidden field:
import { Controller } from "@hotwired/stimulus"

export default class extends Controller {
  connect() {
    this.observer = new MutationObserver(mutations => {
      mutations.forEach(mutation => {
        if (mutation.type === "attributes" && mutation.attributeName === "value") {
          this.submitForm();
        }
      });
    });

    this.observe();
  }

  observe() {
    this.observer.observe(this.element, {
      attributes: true
    });
  }

  submitForm() {
    this.element.form.requestSubmit();
  }

  disconnect() {
    this.observer.disconnect();
  }
}

I guess either having an event api or allowing custom stimulus controllers on the hidden and/or regular input would solve this problem.

I also tried adding  onchange: "this.form.requestSubmit()" hoping it would work. Given that it's the obvious API maybe we can make onchange work as expected?

I'm not sure it's obvious to everyone. There's more than one input state to consider here. Mainly the combobox input and the hidden input. And then there's the arguably less prominent dialog input to consider.
To someone who's familiar with the implementation, a custom onchange implementation might be confusing.
I need to do some more thinking about this. But we'll definitely have a way to hook into selection. I'm thinking it will most likely be through a custom event.
Open to input one way or the other.

I will have a similar use case and so far use https://www.stimulus-components.com/docs/stimulus-rails-autosave for that. It would be great if the interface offered here could feed into that stimulus rails autosave. From my understanding a custom event would allow that.

Let's continue this conversation in https://github.com/josefarias/hotwire_combobox/discussions/71

I need this too since I want to change the form_attributes of the hidden fields

It's supported! https://github.com/josefarias/hotwire_combobox/discussions/134#discussioncomment-8965235


revert in an if branch causes an IR verification error

Example:
script;

pub fn revert(code: u64) {
    asm(r1: code) {
        rvrt r1;
    }
}

fn main() -> u64 {
    if true {
        revert(0)
    } else {
        42
    }
}

Error:
error: Internal compiler error: Verification failed: Function main return type must match its RET instructions.

Basically, the type of the asm block resolves to () because revert() returns a (). But because revert(0) deterministically aborts, we don't emit a compiler error about mismatched types (i.e. type of 42 is different from the type of revert(0)). So this ends up being caught by the IR verifier.
Note that switching the bodies of if and else compiles fine. I expect the above to compiler with or without a semicolon after revert(0) AND with or without a semicolon after the asm block. See https://github.com/FuelLabs/sway/issues/2822 for another issue related to that.

Now that rvrt is not allowed in asm blocks, the reproducer looks like:
script;

fn main() -> u64 {
    if true {
        std::revert::revert(0)
    } else {
        42
    }
}

I think this is supposed to be handled by the is_diverging() stuff which Andrew added.  It's most likely just a missed case in the if compilation.

The issue is simply that the type of revert(0) is () because fn revert is defined as
pub fn revert(code: u64) {
    __revert(code)
}

so that's a conflict of types between the if branch and the else branch.

This issue appears to no longer occur in master.

Now that rvrt is not allowed in asm blocks, the reproducer looks like:
script;

fn main() -> u64 {
    if true {
        std::revert::revert(0)
    } else {
        42
    }
}

Added the above test case in #3285


ARROW-6263: [Python] Use RecordBatch::Validate in RecordBatch.from_arrays. Normalize API vs. Table.from_arrays. Add record_batch factory function

It was previously possible to construct invalid RecordBatch objects. This also makes the API the same between Table.from_arrays and RecordBatch.from_arrays, where the latter did not have an explicit "schema" option before. A pyarrow.record_batch factory function has also been added to go alongside pyarrow.table

Codecov Report

Merging #5189 into master will decrease coverage by 22.35%.
The diff coverage is 85%.

@@             Coverage Diff             @@
##           master    #5189       +/-   ##
===========================================
- Coverage   87.66%   65.31%   -22.36%
===========================================
  Files        1022      496      -526
  Lines      146446    67312    -79134
  Branches     1437        0     -1437
===========================================
- Hits       128383    43965    -84418
- Misses      17701    23347     +5646
+ Partials      362        0      -362

Impacted Files
Coverage Δ

python/pyarrow/__init__.py
71.25% <ø> (ø)
:arrow_up:

python/pyarrow/tests/test_cuda.py
1.58% <0%> (ø)
:arrow_up:

python/pyarrow/tests/test_table.py
99.62% <100%> (ø)
:arrow_up:

python/pyarrow/table.pxi
87.44% <80%> (-0.69%)
:arrow_down:

cpp/src/arrow/util/memory.h
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/date_utils.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/util/memory.cc
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/decimal_type_util.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/filesystem/util_internal.cc
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/compute/logical_type.h
0% <0%> (-100%)
:arrow_down:

... and 774 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a53e31...7514ea7. Read the comment docs.

+1


NameError: name 'total' is not defined

https://github.com/heartexlabs/label-studio/blob/6a05a3dce33cb2ca735da988477521ed22408cff/label_studio/data_import/uploader.py#L59
If number of files exceed the settings.TASKS_MAX_FILE_SIZE, this error will happen, clearly total variable is not defined here.
Should we change it to value ?

Hello Motionlife,
Yes, please. Try increase the size of this and see what happens.

I am getting this when importing files. It never happens when I import just one file, only when I drag and drop (or select) more than one file. And yet if I select the same files individually, or in other groupings, there is no error.

Is there a way to change this setting while running label studio through docker image?

It's a bug introduced by https://github.com/heartexlabs/label-studio/commit/1d3c9bf51f5ec6dbc8f7f29efa83745f68c96dcf#
I'll create a pr to fix this

I am getting this when importing files. It never happens when I import just one file, only when I drag and drop (or select) more than one file. And yet if I select the same files individually, or in other groupings, there is no error.

This is because when you select multiple files at once, their total size is greater than settings.TASKS_MAX_FILE_SIZE (or some other max size perhaps). The error occurs in the error message reporting, where it references a variable named total. The error message is Maximum total size of all files is {settings.TASKS_MAX_FILE_SIZE} bytes. For me, settings.TASKS_MAX_FILE_SIZE = 250 Mb

@uzahid by setting DATA_UPLOAD_MAX_MEMORY_SIZE in terminal - e.g. DATA_UPLOAD_MAX_MEMORY_SIZE=1073741824 to set the max upload size to 1 Gb (see https://github.com/heartexlabs/label-studio/blob/dab42819ce419a78a80c8ea738beb2eaf03af739/label_studio/core/settings/base.py#L445-L447)

I am receiving this error " name 'total' is not defined " when I try to import a video.
I run "label-studio start" from command line and enter a browser-based interface. It prompts me to import data. When I try to import my .avi file, I get this error.
I am not a python programmer.
Any suggestions for how to get my video to load?

Hi Micheal! This is the right issue for the problem. I've opened up a pull request to fix the issue with the weird error message, but the actual fix will be to do what I suggested above. Depending on how large your .avi file is, you'll have to adjust DATA_UPLOAD_MAX_MEMORY_SIZE to accommodate it.
So, if your .avi file is 500 Mb, you would want to adjust DATA_UPLOAD_MAX_MEMORY_SIZE to, say, 600 Mb for safety. So 600 * 1024 * 1024 = 629,145,600, so you would want to start label studio like so:
DATA_UPLOAD_MAX_MEMORY_SIZE=629145600 label-studio start

Thank you. This worked for me.

Despite trying @Axel-Jacobsen 's answer that worked for Michael. It did not work for me.  Still getting the [4fccf696-35c1-44e5-8eda-dc09cf02fcb1] name 'total' is not defined error. Do I need to rebuild the project somehow? Once I made the change in the code, I simply ran label-studio start. Maybe I missed something...?

Okay changing the code didn't work, but exporting the variable as environment variable did the trick.  Thanks @Axel-Jacobsen

Closed as a non-active issue, and it seems like it has been resolved.


Stackstorm Reddis cashe not starting and so the rest of the application can not start

Hi I try to install Stackstorm in a Kubernetes Cluster with helm.
But stackstorm-ha-1673617629-redis-node-0  always stops with error that helth probe not working. And because of this the Stackstorm Container all say wait for db.
Thank you for your help :)
NAME                                                           READY   STATUS             RESTARTS        AGE
stackstorm-ha-1673615479-job-st2-apikey-load-xc4r4             0/1     Init:0/3           0               8m45s
stackstorm-ha-1673617629-job-st2-apikey-load-bs4mp             0/1     Init:0/3           0               7m42s
stackstorm-ha-1673617629-mongodb-0                             1/1     Running            0               7m42s
stackstorm-ha-1673617629-mongodb-1                             1/1     Running            0               7m3s
stackstorm-ha-1673617629-mongodb-2                             1/1     Running            0               6m46s
stackstorm-ha-1673617629-rabbitmq-0                            1/1     Running            1 (2m39s ago)   7m42s
stackstorm-ha-1673617629-rabbitmq-1                            0/1     Running            0               2m17s
stackstorm-ha-1673617629-redis-node-0                          1/2     CrashLoopBackOff   5 (16s ago)     7m42s
stackstorm-ha-1673617629-st2actionrunner-547d775cd7-8rxbv      0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2actionrunner-547d775cd7-gn79r      0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2actionrunner-547d775cd7-jmnx6      0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2actionrunner-547d775cd7-mzsh7      0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2actionrunner-547d775cd7-wfsbv      0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2api-f7b5cd9b9-68lsx                0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2api-f7b5cd9b9-pkxjv                0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2auth-54dd7c7685-lwq2m              0/1     Init:0/3           0               7m42s
stackstorm-ha-1673617629-st2auth-54dd7c7685-s5g22              0/1     Init:0/3           0               7m42s
stackstorm-ha-1673617629-st2client-74bfd87b6-z9hjl             1/1     Running            0               7m42s
stackstorm-ha-1673617629-st2garbagecollector-998cb6856-5vnhc   0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2notifier-5c74474bb9-b8mt5          0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2notifier-5c74474bb9-gqdtc          0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2rulesengine-754bc4f6-7ztbg         0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2rulesengine-754bc4f6-wc7cw         0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2scheduler-5f49cc6f9f-h7j42         0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2scheduler-5f49cc6f9f-ln96q         0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2sensorcontainer-644c6c45c6-br5jn   0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2stream-7dbdd9fb96-4xt6d            0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2stream-7dbdd9fb96-slb45            0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2timersengine-d97864c9f-vsngg       0/1     Init:0/2           0               7m42s
stackstorm-ha-1673617629-st2web-9ff6bfb85-9m5bn                0/1     CrashLoopBackOff   6 (41s ago)     7m42s
stackstorm-ha-1673617629-st2web-9ff6bfb85-nddwl                0/1     CrashLoopBackOff   6 (44s ago)     7m42s
stackstorm-ha-1673617629-st2workflowengine-7cbb59cc8f-sdqk8    0/1     Init:0/2           0               7m41s
stackstorm-ha-1673617629-st2workflowengine-7cbb59cc8f-sx7qs    0/1     Init:0/2           0               7m41s
Logs:
[eco_adm@cg3a54d9ac-k8m-s301 ~]$ kubectl logs stackstorm-ha-1673617629-redis-node-0
Defaulted container "redis" out of: redis, sentinel
I am master
redis 13:48:54.97 INFO  ==> ** Starting Redis **
1:C 13 Jan 2023 13:48:54.979 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 13 Jan 2023 13:48:54.979 # Redis version=6.0.9, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 13 Jan 2023 13:48:54.979 # Configuration loaded
1:M 13 Jan 2023 13:48:54.982 # Not listening to IPv6: unsupported
1:M 13 Jan 2023 13:48:54.983 * Running mode=standalone, port=6379.
1:M 13 Jan 2023 13:48:54.983 # WARNING: The TCP backlog setting of 511 cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of 128.
1:M 13 Jan 2023 13:48:54.983 # Server initialized
1:M 13 Jan 2023 13:48:54.983 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with Redis. To fix this issue run the command 'echo madvise > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. Redis must be restarted after THP is disabled (set to 'madvise' or 'never').
1:M 13 Jan 2023 13:48:54.983 * Ready to accept connections
Describe Pod:
[eco_adm@cg3a54d9ac-k8m-s301 ~]$ kubectl describe pod stackstorm-ha-1673617629-redis-node-0
Name:             stackstorm-ha-1673617629-redis-node-0
Namespace:        default
Priority:         0
Service Account:  default
Node:             cg3a54d9ac-k8w-s301.sys.schwarz/<IP_ADDRESS>
Start Time:       Fri, 13 Jan 2023 14:47:46 +0100
Labels:           app=redis
chart=redis-12.3.2
controller-revision-hash=stackstorm-ha-1673617629-redis-node-7b59f7c97b
release=stackstorm-ha-1673617629
role=node
statefulset.kubernetes.io/pod-name=stackstorm-ha-1673617629-redis-node-0
Annotations:      checksum/configmap: 1c645cdf9207e1338f57f37eb3767b6d4111c0ad08636426d8164736561f72a7
checksum/health: 6cbc0d3c356accbd47af7290e9e50ff762e7d0977f3c9c0fc93a5dd43654cbeb
checksum/secret: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
cni.projectcalico.org/containerID: 8249d7addc2803f6246da9e1915b88a443da1cfaf3c99718e17316c751d056d5
cni.projectcalico.org/podIP: <IP_ADDRESS>/32
cni.projectcalico.org/podIPs: <IP_ADDRESS>/32
Status:           Running
IP:               <IP_ADDRESS>
IPs:
IP:           <IP_ADDRESS>
Controlled By:  StatefulSet/stackstorm-ha-1673617629-redis-node
Containers:
redis:
Container ID:  containerd://1fc1cdbca607a8e1e1e338eba4b09ec7cac6677bf25c4338f95d724354cbf05b
Image:         docker.io/bitnami/redis:6.0.9-debian-10-r66
Image ID:      docker.io/bitnami/redis@sha256:63caa0cd4c73961ae1c2f322d8352510f61036d326147b341b09ca27b3eabd79
Port:          6379/TCP
Host Port:     0/TCP
Command:
/bin/bash
-c
/opt/bitnami/scripts/start-scripts/start-node.sh
State:          Running
Started:      Fri, 13 Jan 2023 14:48:34 +0100
Ready:          True
Restart Count:  0
Liveness:       exec [sh -c /health/ping_liveness_local.sh 5] delay=30s timeout=5s period=10s #success=1 #failure=5
Readiness:      exec [sh -c /health/ping_readiness_local.sh 5] delay=5s timeout=10s period=10s #success=1 #failure=5
Environment:
REDIS_MASTER_PORT_NUMBER:  6379
ALLOW_EMPTY_PASSWORD:      yes
REDIS_TLS_ENABLED:         no
REDIS_PORT:                6379
REDIS_DATA_DIR:            /data
Mounts:
/data from redis-data (rw)
/health from health (rw)
/opt/bitnami/redis/etc from redis-tmp-conf (rw)
/opt/bitnami/redis/mounted-etc from config (rw)
/opt/bitnami/scripts/start-scripts from start-scripts (rw)
/var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-dhg2f (ro)
sentinel:
Container ID:  containerd://a58af9c647d5012736cdc7e16bde2dd04f365177df8917ee8ce64a065d882337
Image:         docker.io/bitnami/redis-sentinel:6.0.9-debian-10-r66
Image ID:      docker.io/bitnami/redis-sentinel@sha256:0b1a099fa2224096f42add10bce05e97935b44612ae20589c0ee5b16ec1d9dcc
Port:          26379/TCP
Host Port:     0/TCP
Command:
/bin/bash
-c
/opt/bitnami/scripts/start-scripts/start-sentinel.sh
State:          Waiting
Reason:       CrashLoopBackOff
Last State:     Terminated
Reason:       Error
Exit Code:    137
Started:      Fri, 13 Jan 2023 15:00:04 +0100
Finished:     Fri, 13 Jan 2023 15:00:59 +0100
Ready:          False
Restart Count:  7
Liveness:       exec [sh -c /health/ping_sentinel.sh 5] delay=5s timeout=5s period=5s #success=1 #failure=5
Readiness:      exec [sh -c /health/ping_sentinel.sh 5] delay=5s timeout=1s period=5s #success=1 #failure=5
Environment:
ALLOW_EMPTY_PASSWORD:        yes
REDIS_SENTINEL_TLS_ENABLED:  no
REDIS_SENTINEL_PORT:         26379
Mounts:
/data from redis-data (rw)
/health from health (rw)
/opt/bitnami/redis-sentinel/etc from sentinel-tmp-conf (rw)
/opt/bitnami/redis-sentinel/mounted-etc from config (rw)
/opt/bitnami/scripts/start-scripts from start-scripts (rw)
/var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-dhg2f (ro)
Conditions:
Type              Status
Initialized       True
Ready             False
ContainersReady   False
PodScheduled      True
Volumes:
redis-data:
Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
ClaimName:  redis-data-stackstorm-ha-1673617629-redis-node-0
ReadOnly:   false
start-scripts:
Type:      ConfigMap (a volume populated by a ConfigMap)
Name:      stackstorm-ha-1673617629-redis-scripts
Optional:  false
health:
Type:      ConfigMap (a volume populated by a ConfigMap)
Name:      stackstorm-ha-1673617629-redis-health
Optional:  false
config:
Type:      ConfigMap (a volume populated by a ConfigMap)
Name:      stackstorm-ha-1673617629-redis
Optional:  false
sentinel-tmp-conf:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
redis-tmp-conf:
Type:       EmptyDir (a temporary directory that shares a pod's lifetime)
Medium:
SizeLimit:
kube-api-access-dhg2f:
Type:                    Projected (a volume that contains injected data from multiple sources)
TokenExpirationSeconds:  3607
ConfigMapName:           kube-root-ca.crt
ConfigMapOptional:
DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
Type     Reason     Age                From               Message

Normal   Scheduled  15m                default-scheduler  Successfully assigned default/stackstorm-ha-1673617629-redis-node-0 to cg3a54d9ac-k8w-s301.sys.schwarz
Normal   Pulling    15m                kubelet            Pulling image "docker.io/bitnami/redis:6.0.9-debian-10-r66"
Normal   Pulled     14m                kubelet            Successfully pulled image "docker.io/bitnami/redis:6.0.9-debian-10-r66" in 45.36777825s (45.367795273s including waiting)
Normal   Created    14m                kubelet            Created container redis
Normal   Started    14m                kubelet            Started container redis
Normal   Pulling    14m                kubelet            Pulling image "docker.io/bitnami/redis-sentinel:6.0.9-debian-10-r66"
Normal   Pulled     13m                kubelet            Successfully pulled image "docker.io/bitnami/redis-sentinel:6.0.9-debian-10-r66" in 41.417869521s (41.417875397s including waiting)
Normal   Created    13m                kubelet            Created container sentinel
Normal   Started    13m                kubelet            Started container sentinel
Warning  Unhealthy  13m (x5 over 13m)  kubelet            Liveness probe failed:
Could not connect to Redis at localhost:26379: Connection refused
Normal   Killing    13m                 kubelet  Container sentinel failed liveness probe, will be restarted
Warning  Unhealthy  10m (x47 over 13m)  kubelet  Readiness probe failed:
Could not connect to Redis at localhost:26379: Connection refused
Warning  BackOff  6s (x33 over 8m11s)  kubelet  Back-off restarting failed container sentinel in pod stackstorm-ha-1673617629-redis-node-0_default(4bc531f0-9654-45fe-ba96-68e031024682)

For the Container of Stackstorm Services it self:
Events:
Type     Reason       Age                    From               Message

Normal   Scheduled    5m25s                  default-scheduler  Successfully assigned default/stackstorm-ha-1673617629-st2actionrunner-5489d74785-bj69h to cg3a54d9ac-k8w-s302.sys.schwarz
Warning  FailedMount  5m23s                  kubelet            MountVolume.SetUp failed for volume "st2-post-start-script-vol" : failed to sync configmap cache: timed out waiting for the condition
Warning  FailedMount  5m22s (x2 over 5m23s)  kubelet            MountVolume.SetUp failed for volume "st2-encryption-key-vol" : failed to sync secret cache: timed out waiting for the condition
Warning  FailedMount  5m22s (x2 over 5m23s)  kubelet            MountVolume.SetUp failed for volume "st2-ssh-key-vol" : failed to sync secret cache: timed out waiting for the condition
Normal   Pulled       5m19s                  kubelet            Container image "busybox:1.28" already present on machine
Normal   Created      5m19s                  kubelet            Created container wait-for-db
Normal   Started      5m18s                  kubelet            Started container wait-for-db
[eco_adm@cg3a54d9ac-k8m-s301 linux-amd64]$
I have try to disable redis in the chart too and deploy it manual.


normalSpeed compile error

First of all, congratulations on your excellent work, but I encountered a compilation error when using your open source code. I hope you can help. For this, I am grateful.
root@6ff4287af8c0:/mnt/txf/codes/FFB6D/normalSpeed/normalSpeed# python setup.py install --user
running install
running bdist_egg
running egg_info
writing normalSpeed.egg-info/PKG-INFO
writing dependency_links to normalSpeed.egg-info/dependency_links.txt
writing top-level names to normalSpeed.egg-info/top_level.txt
reading manifest file 'normalSpeed.egg-info/SOURCES.txt'
writing manifest file 'normalSpeed.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_ext
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
CMake Deprecation Warning at Cmake/FindNumPy.cmake:6 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
Call Stack (most recent call first):
CMakeLists.txt:14 (include)
-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/txf/codes/FFB6D/normalSpeed/normalSpeed/build/temp.linux-x86_64-3.6
[ 25%] Building CXX object CMakeFiles/normalSpeed.dir/pybind11.cpp.o
[ 50%] Building CXX object CMakeFiles/normalSpeed.dir/normal.cpp.o
In file included from /mnt/txf/codes/FFB6D/normalSpeed/normalSpeed/normal.cpp:1:0:
/mnt/txf/codes/FFB6D/normalSpeed/normalSpeed/normal.hpp:5:28: fatal error: opencv2/rgbd.hpp: No such file or directory
#include <opencv2/rgbd.hpp>
^
compilation terminated.
In file included from /mnt/txf/codes/FFB6D/normalSpeed/normalSpeed/pybind11.cpp:4:0:
/mnt/txf/codes/FFB6D/normalSpeed/normalSpeed/normal.hpp:5:28: fatal error: opencv2/rgbd.hpp: No such file or directory
#include <opencv2/rgbd.hpp>
^
compilation terminated.
CMakeFiles/normalSpeed.dir/build.make:75: recipe for target 'CMakeFiles/normalSpeed.dir/normal.cpp.o' failed
make[2]: *** [CMakeFiles/normalSpeed.dir/normal.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

I have solved this problem, after I recompile and install opencv and opencv_contrib.

But I have a new problem. After I have successfully compiled and installed normalSpeed0.0.1, the following error occurred when I run the program:
Traceback (most recent call last):
File "train_lm.py", line 33, in
from utils.pvn3d_eval_utils_kpls import TorchEval
File "/mnt/txf/codes/FFB6D/ffb6d/utils/pvn3d_eval_utils_kpls.py", line 10, in
from utils.basic_utils import Basic_Utils
File "/mnt/txf/codes/FFB6D/ffb6d/utils/basic_utils.py", line 9, in
import normalSpeed
ModuleNotFoundError: No module named 'normalSpeed'
Is this because of the version of the dependent library or the version of normalSpeed?

After I uninstalled and deleted the installed normalSpeed library, re-downloading and installing normalSpeed solved the problem.

What version of opencv have you installed? And using pip?

What version of opencv have you installed? And using pip?

https://github.com/ethnhe/FFB6D/issues/23#issuecomment-907598982

After I uninstalled and deleted the installed normalSpeed library, re-downloading and installing normalSpeed solved the problem.

how did you uninstalled the library? there is no library to uninstall. i have the same problem. succeed in building but failed to import.


⚠ DesiTorrents has degraded performance

In 23ca893, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 1750 ms

Resolved: DesiTorrents performance has improved in b4170ce after 10 minutes.


Azure App Configuration Request Metadata

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Read the contribution guide
[x] Commands include options for Linux, MacOS, and Windows within codetabs
[x] New file and folder names are globally unique
[x] Page references use shortcodes instead of markdown or URL links
[x] Images use HTML style and have alternative text
[x] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Added Azure App Configuration Request Metadata section as requested here: https://github.com/dapr/components-contrib/pull/2064#issuecomment-1248732150
Issue reference
Please reference the issue this PR will close: #2809

@cmendible - How can you use this label metadata from the SDKs? For example how would this code example change? https://v1-9.docs.dapr.io/developing-applications/building-blocks/configuration/howto-manage-configuration/#get-configuration-items-using-dapr-sdks
I suspect that this also need an optional parameter in each of the SDKs, in which case can you raise an Issue in each of the 5 of them?

The .NET SDK does allow setting metadata as part of the GetConfiguration method:
https://github.com/dapr/dotnet-sdk/blob/01cdc89710c16712442474afea97693f22c5852b/src/Dapr.Client/DaprClient.cs#L865
And implemented in the DaprClientGrpc:
https://github.com/dapr/dotnet-sdk/blob/01cdc89710c16712442474afea97693f22c5852b/src/Dapr.Client/DaprClientGrpc.cs#L1141


Module dividers

It would be nice to be nice to have some kind of divider between the various modules output.
Something like
Battery | Volume | Time
This way it is immediately clear what data is part of which module.
I guess it's possible to insert it in each module, but it would be nice to have a global setting.

You should just be able to insert that inside the xsetroot function, that's what actually sets the bar

Sorry, figured it out; I don't really know go...
However since it's joining all strings it will put a delimiters around modules without any output.
It is not a big deal for me, as I have none, but one could have a module that has output only in certain conditions, it would then be quite annoying.


[CLU] fix readme snippets

Resolves https://github.com/Azure/azure-sdk-for-python/issues/31363

API change check
API changes are not detected in this pull request.


Ellipsis on package page make long versions unreadable

Example: https://www.nuget.org/packages/Xamarin.Forms/

We should make the version text longer, and add tool tip with the full value.

This is merged to dev branch but has not been verified in any environment except my devbox.


Fails to detect SSE support properly

Original report (archived issue) by yurivict (Bitbucket: yurivict).

On my machine it prints
-- Searching for host SSE information
-- Could not find hardware support for SSE3 on this machine.
-- Could not find hardware support for SSSE3 on this machine.
-- Could not find hardware support for SSE4.1 on this machine.
-- Could not find hardware support for SSE4.2 on this machine.
-- SSE2 found
-- SSE4 disabled.

while https://gist.github.com/hi2p-perim/7855506#file-ssecheck-cpp prints
$ ssecheck
SSE:1
SSE2:1
SSE3:1
SSE4.1:1
SSE4.2:1
SSE4a:0
SSE5:0
AVX:0

I'm not able to reproduce this. SSE detection is handled by https://github.com/gazebosim/gz-cmake/blob/200de1b26edbad9ad1d7efd7c29dd4f2080edefa/cmake/GzCheckSSE.cmake, but it only works on Linux, macOS and Windows.


fix: Refresh EKS credentials after a lengthy docker build

The places we refresh seem arbitrary to me. I won't bug you with it now, but I think it'd be better if either refresh every time we need to use K8S or we catch an authorization error and refresh then. My other suggestion would be to only fresh after docker builds, which seem to be the longest running step.
Please add a description in your PR that includes the places you refresh now and why you are doing the refresh there.

Updated to refresh creds every time.


Support crop by percentage

Hi,
Seems like currently crop can only be done by giving width & height in pixel. Is it possible to also have an option to take percentage as input?

Hi Fang,
Could you give me an example use case for this?

We have a feature to show a zoomed in (by percentage) image. Currently when rendering, we download the original image, then use the percentage in request to zoom into that part (e.g. Starting from (0+20% x, 0 + 20% * y), zoom to 20% of the original width & height) and display the partial image.
By supporting cropping by percentage, we can directly download the cropped image.

Hey! I'm so sorry, I released crop by percentage in v2.16.0 and forgot to drop a comment here. Just use width/height <1 in the crop option, and imgproxy will treat this as a relative size. Ex: .../crop:0.5:0.5/... will crop image by half.


Mccalluc/just warn if imports fail

We want the failover logic to be the same regardless of python version. I'm also splitting it into separate chunks, so one failing import won't block all the rest.

Just a footnote: I'm sorry that this process has been drawn out. I've wondered if an end-to-end integration test with portal-visualization would make sense, but I'm not sure how to make that work without it being really kludgy. It would be something like:
cd /tmp
git clone .../portal-visualization
cd portal-visualization
pip install ... # list dependencies individually, because if we install everything, it gets a pinned version of vitessce-python
test.sh # Run portal-visualizations test suite, but using the version of vitessce-python here.

Besides being kludgy, it's just not working when I try it locally:
...
ERROR src/vis-preview.py - ModuleNotFoundError: No module named 'hubmap_commons'
ERROR test/test_builders.py - ModuleNotFoundError: No module named 'yaml'
ERROR test/test_builders.py
...
3 errors in 1.49s

$ pip freeze | grep commons
hubmap-commons==2.0.14

I don't get why python isn't seeing commons in this environment.
Anyway... I guess if you would be excited about having more of an integration test test here, I'll work on that, but that's not the direction I'm going right now... which might mean there is more back and forth until this works.

@keller-mark

I think once a first pair portal-visualization+vitessce-python versions is working, then we can add integration tests here where we pin the latest version of portal-visualization.

Yay, something like that. I think the usefulness of this would really depend on the complexity of behavior that needs testing, and the degree of test coverage here. It would be awkward, having a dependency in the wrong direction, even if it's only for tests, but it might be worth it if it helps spot problems over the horizon. Just something to consider for now.


image incomplete display

When I slid to the left, there was an incomplete display.

thanks for try and reply.
well, did you just running the example project? Can you give more detail or screenshots, because I've test the image display, it's all works well. :)

oh... something was wrong in my project, Sorry! The Reindeer is very useful, but it's the better if it can be custom pageController's style.

Thanks, good advice. I'm going to make it more stable first( the Reindeer is still the first version), then I'll add more feature. However, if you find any bug or have suggestion please tell me know.

Thanks, kept watching!


Failure to move with discrete commands if pushed off by (0.5,0.5)

Once something pushes you off of (0.5, 0.5) the agent is then unable to move any more for the remainder of the mission. It was found that using absolute commands resolves the issue.

Duplicate of 117.


It is possible to ignore generating of the time features please?

Can you please give some hints about the way to ignore the code which generates the time features?


unable to publish tx to celestia on celestia-develop-apr-24-392b8872 branch

I am seeing a constant and consistent error on op-proposer:
op-proposer_1  | t=2023-04-27T16:41:19+0000 lvl=warn msg="unable to publish tx to celestia"    service=proposer err="Post \"/submit_pfb\": unsupported protocol scheme \"\""
Full logs can be found in this Gist

Confirmed, can't see this error after 2000 blocks running off of #20


Request for Adding the "compile" function support in "react-native-webassembly"

Issue Description
I am trying to rebuild ffjavascript to run on React Native, and I need the compile function to be supported in react-native-webassembly.
Currently, the WebAssembly in browser engine  supports the compile function, which accepts a bytes parameter and returns a Promise<Module>.
  function compile(bytes: BufferSource): Promise<Module>;
    /** [MDN Reference](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/compileStreaming) */

I would like to request support for this function in react-native-webassembly to replace the following code in my project:
// threadman.js

import * as WebAssembly from "react-native-webassembly";

...

export default async function buildThreadManager(wasm, singleThread) {
  const tm = new ThreadManager();
  tm.memory = new WebAssembly.Memory({ initial: MEM_SIZE });

  // This line uses the compile function
  const wasmModule = await WebAssembly.compile(wasm.code);

  tm.instance = await WebAssembly.instantiate(wasmModule, {
    env: {
      memory: tm.memory,
    },
  });
}

Thank you so much! 🤩

Hey, thanks for reaching out.
Interesting. Um. Hm. Yeah we can probably do this.

Has this feature made any progress


[Bug] Render happens twice every view load/change

Every time the component is loaded, it rerenders itself an additional time when the view nav is changed from Month, Day or Week, but not when Today is clicked.
Steps to duplicate

Fork repo
Run npm run start
Replace https://github.com/aldabil21/react-scheduler/blob/1a1275fc9a3a31e5d44c0a7c82803768fffc2c01/src/App.tsx#L11 with

      getRemoteEvents={async () => {
         console.log("Getting Events at", new Date())
         return EVENTS;
      }}

I've tried running the profiler to see what is causing this, but no success. I can further see this happening if you insert a console.log into the stateReducer function here https://github.com/aldabil21/react-scheduler/blob/1a1275fc9a3a31e5d44c0a7c82803768fffc2c01/src/lib/context/state/stateReducer.ts#L8 you will see duplicate logs happening.
I haven't found a good work around as this calls external server duplicate times (which could be costly) when getRemoteEvents is passed as  prop.

Hi
Thx for the detailed issue. before I proceed with debugging, can you confirm if you are running the code with React StrictMode or not? If yes, can you try again after removing the StrictMode line https://github.com/aldabil21/react-scheduler/blob/1a1275fc9a3a31e5d44c0a7c82803768fffc2c01/src/index.tsx#L7

Good catch, this bug is only present with StrictMode enabled.

This is not a bug. Its just StrictMode work. Check: https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

Strict mode can’t automatically detect side effects for you, but it can help you spot them by making them a little more deterministic. This is done by intentionally double-invoking the following functions: ...


Significant lag when editing large documents

With this package enabled significant input lag is noticed when editing e.g. Bash.sublime-syntax, which has about 3.5k lines of code.

Thanks for reporting. Are you willing to experiment a little? (Sorry, I don't have much time myself right now...) I'm curious if adjusting the debounce interval to i.e. 4x higher would help. If it does, it might be worth scaling the interval according to the size of the file being edited, unless we can come up with better ideas 🙂

I did so. Outcome is https://github.com/keith-hall/SublimeYamlPath/pull/2


Not Used floatlabels.rebuild();

It is possible not to use float labels.rebuild (); after returning from ajax?
maybe run only once and automatically recognize an active field ?

For what reason? You only need to run rebuild if you are changing the form fields with ajax (i.e. swapping out fields with ajax when toggling payment methods in an ecommerce formpayment )

maybe it's a repetitive job, whenever there is a request, I have to rebuild it.
It would be a way to leave less manual labor!
If I return a json object from the request and want to fill in a Modal Bootstrap, for example, after filling in the modal, I need to rebuild.
if there is any way, I would like you to help me with any idea

If you are using ajax to fill in the field values of a form, you do not need to rebuild the float label DOM, you just need to manually trigger the input event (or change event with SELECT) .
el.value = "hello"; el.dispatchEvent(new Event('input'));


Initial command palette feature

Adds command palette UI & extension API (similar to what VS Code has). Also adds some common commands to global & cluster scope so that we can actually see the idea is working.

Fixes #1872

In overall, the palette working great. 2 things I noticed:

It doesn't close Preferences or Settings page if navigation command executed from Palette

Good catch! Fixed.

Shouldn't we go to last active cluster when workspace is switched from Palette?

Fixed.

In overall, the palette working great. 2 things I noticed:

It doesn't close Preferences or Settings page if navigation command executed from Palette

Good catch! Fixed.

Shouldn't we go to last active cluster when workspace is switched from Palette?

Fixed.

I would better to use background-color only for select-box area:
Before:

After:

I would better to use background-color only for select-box area:
Before:

After:

Looks better if we restrict background to  area only, wdyt?

Background is also used in other command UIs so it kinda needs to be there. I agree that it looks a bit ugly but we can fix that in a follow up PR.

@nevalla @aleksfront ptal again.

🎆


Lorna portfolio development

The first commit added the main introduction paragraph, and the images, and the second commit added more to this introduction.

Thanks Mostafa!
I'm not sure what you mean about adding the images to the pull request. Do you mean to attach the files? Or to make a commit the image folder?
Here's a screenshot showing the intro paragraph and the images.