[Bulk] Validation: Fixed issues in ODatadocs

This PR fixes 55 issues in ODatadocs.

Docs Build status updates of commit d9990fa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/connectedservice/generating-code-for-vb-clients.md
:warning:Warning
View
Details

Odata-docs/connectedservice/t4-templates.md
:warning:Warning
View
Details

Odata-docs/includes/appliesto-odataclient-v6.md
:warning:Warning
View
Details

Odata-docs/includes/appliesto-odataclient-v7.md
:warning:Warning
View
Details

Odata-docs/includes/appliesto-odatalib-v6.md
:warning:Warning
View
Details

Odata-docs/includes/appliesto-odatalib-v7.md
:warning:Warning
View
Details

Odata-docs/includes/appliesto-webapi-core-v7.5.md
:warning:Warning
View
Details

Odata-docs/changelog/aspnetcoreodata-8x.md
:bulb:Suggestion
View
Details

Odata-docs/changelog/odatalib-7x.md
:bulb:Suggestion
View
Details

Odata-docs/changelog/webapi-7x.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/accessing-endpoints-with-auth.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/choosing-what-to-generate.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/generating-multiple-files.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/getting-started.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/reference.md
:bulb:Suggestion
View
Details

Odata-docs/connectedservice/updating-generated-code.md
:bulb:Suggestion
View
Details

Odata-docs/extensions/migration.md
:bulb:Suggestion
View
Details

Odata-docs/changelog/odatalib-5x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odataopenapi.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/create-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/delete-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/derived-types-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/get-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/update-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/url-components.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-code-for-vb-clients.md

Line 21, Column 97: [Warning: file-not-found - See documentation] Invalid file link: '../getting-started'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/t4-templates.md

Line 95, Column 66: [Warning: file-not-found - See documentation] Invalid file link: '../updating-generated-code'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 15, Column 38: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /en-us/visualstudio/modeling/code-generation-and-t4-text-templates?view=vs-2019. Otherwise, remove the view parameter.
Line 17, Column 11: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /en-us/visualstudio/modeling/generating-files-with-the-texttransform-utility?view=vs-2019. Otherwise, remove the view parameter.

Odata-docs/includes/appliesto-odataclient-v6.md

Line 6, Column 2: [Warning: alt-text-bad-value - See documentation] Alt text 'yes' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 8, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'OData client v6 supported'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/includes/appliesto-odataclient-v7.md

Line 6, Column 2: [Warning: alt-text-bad-value - See documentation] Alt text 'yes' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 8, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'OData client v7 supported'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/includes/appliesto-odatalib-v6.md

Line 6, Column 2: [Warning: alt-text-bad-value - See documentation] Alt text 'yes' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 8, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'OData Core lib v6 supported'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/includes/appliesto-odatalib-v7.md

Line 6, Column 2: [Warning: alt-text-bad-value - See documentation] Alt text 'yes' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 8, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'OData core lib v7 supported'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/includes/appliesto-webapi-core-v7.5.md

Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'mandansr7' is not a valid GitHub ID.
Line 6, Column 2: [Warning: alt-text-bad-value - See documentation] Alt text 'yes' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 8, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'OData WebApi v7.5 for .NET Core'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/changelog/aspnetcoreodata-8x.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'OData WebApi 7.x changelog' is duplicated in 'changelog/aspnetcoreodata-8x.md(3,14)', 'changelog/webapi-7x.md(3,14)'.

Odata-docs/changelog/odatalib-7x.md

Line 1477, Column 3: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

Odata-docs/changelog/webapi-7x.md

Line 3, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'OData WebApi 7.x changelog' is duplicated in 'changelog/aspnetcoreodata-8x.md(3,14)', 'changelog/webapi-7x.md(3,14)'.

Odata-docs/connectedservice/accessing-endpoints-with-auth.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/choosing-what-to-generate.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/generating-multiple-files.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/getting-started.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/reference.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/connectedservice/updating-generated-code.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

Odata-docs/extensions/migration.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8d972aa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/connectedservice/generating-code-for-vb-clients.md
:warning:Warning
View
Details

Odata-docs/connectedservice/t4-templates.md
:warning:Warning
View
Details

Odata-docs/changelog/odatalib-7x.md
:bulb:Suggestion
View
Details

Odata-docs/changelog/aspnetcoreodata-8x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-5x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odataopenapi.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi-7x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/create-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/delete-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/derived-types-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/get-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/update-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/url-components.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/accessing-endpoints-with-auth.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/choosing-what-to-generate.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-multiple-files.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/reference.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/updating-generated-code.md
:white_check_mark:Succeeded
View

Odata-docs/extensions/migration.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-webapi-core-v7.5.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-code-for-vb-clients.md

Line 20, Column 97: [Warning: file-not-found - See documentation] Invalid file link: '../getting-started'.

Odata-docs/connectedservice/t4-templates.md

Line 94, Column 66: [Warning: file-not-found - See documentation] Invalid file link: '../updating-generated-code'.

Odata-docs/changelog/odatalib-7x.md

Line 1477, Column 3: [Suggestion: column-header-missing - See documentation] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 74fc11b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/connectedservice/generating-code-for-vb-clients.md
:warning:Warning
View
Details

Odata-docs/connectedservice/t4-templates.md
:warning:Warning
View
Details

Odata-docs/changelog/aspnetcoreodata-8x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-5x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odataopenapi.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi-7x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/create-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/delete-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/derived-types-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/get-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/update-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/url-components.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/accessing-endpoints-with-auth.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/choosing-what-to-generate.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-multiple-files.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/reference.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/updating-generated-code.md
:white_check_mark:Succeeded
View

Odata-docs/extensions/migration.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-webapi-core-v7.5.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-code-for-vb-clients.md

Line 20, Column 97: [Warning: file-not-found - See documentation] Invalid file link: '../getting-started'.

Odata-docs/connectedservice/t4-templates.md

Line 94, Column 66: [Warning: file-not-found - See documentation] Invalid file link: '../updating-generated-code'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c28c92d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/changelog/aspnetcoreodata-8x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-5x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odataopenapi.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi-7x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/create-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/delete-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/derived-types-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/get-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/update-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/url-components.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/accessing-endpoints-with-auth.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/choosing-what-to-generate.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-code-for-vb-clients.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-multiple-files.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/reference.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/t4-templates.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/updating-generated-code.md
:white_check_mark:Succeeded
View

Odata-docs/extensions/migration.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odatalib-v7.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-webapi-core-v7.5.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@xuzhg @odero This PR is ready for your final review. Please let me know if there are any issues or changes you would like. Thanks.

Docs Build status updates of commit bae59fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/changelog/aspnetcoreodata-8x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-5x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/odataopenapi.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi-7x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/create-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/delete-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/derived-types-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/get-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/update-data.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/url-components.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/accessing-endpoints-with-auth.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/choosing-what-to-generate.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-code-for-vb-clients.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/generating-multiple-files.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/getting-started.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/reference.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/t4-templates.md
:white_check_mark:Succeeded
View

Odata-docs/connectedservice/updating-generated-code.md
:white_check_mark:Succeeded
View

Odata-docs/extensions/migration.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v6.md
:white_check_mark:Succeeded
View

Odata-docs/includes/appliesto-odataclient-v7.md
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


A horizontally scrolling column view

VSCode Version: 1.11.1
OS Version: Windows 10

An editor view that ONLY has a horizontal scroll bar. Text is layed out in columns which are automatically sized to be as wide as the widest text in that column.
Motivation: Like many programmers I have a gigantic screen, but my ability to see a lot of a single source code file is limited by the vertical height of my screen, meaning I often use less than a 3rd of my screen real-estate. The proposed view would allow me to see much more of my file at once. Opening multiple views on the same file are harder to manage.
This is a feature request, since it doesn't seem possible to add this functionality as a plugin. Alternatively, consider adding enough functionality to the plugin API to make this feature possible.
Optionally: intelligent pagination. Inserting new lines would shift all columns, which may be disorienting. Instead, use the natural indentation of most text files to move text to the next column when the "page break" would be nested more deeply than a configurable amount of spaces. This would ensure most "functions" would be in a single column (not divided), and code would move around between columns much less while editing.
Example, current view, * marks the edge of the editor view:
***************************
* code                   S*
*   code                 C*
* code                   R*
*                        O*
* code                   L*
*   code                 L*
***************************

New proposed view, . marks unused space because of pagination:
***************************
* code     code     code  *
*   code     code         *
* code       code         *
*          code           *
* .....                   *
* S C R O L L B A R       *
***************************

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Feature request: Specify transclusion position

It would be great to specify where to include the content of a parent tag. Ie:

<form-group>

    { opts.label }
    { innerHTML }

</form-group>

<form>
  <form-group label="Field 1">
    <input type="text" name="field-1"/>
  </form-group>
</form>

.... producing ....

  Field 1
  <input type="text" name="field 1"/>

It would be useful to me too. +1

I created a plunk to demonstrate the concept (It may require some refresh to work due to plunker): http://embed.plnkr.co/QtPQCMUCsVDwRz1zV2C3/preview

Cool. What about using transclude for the tag name too, just to keep things consistent?
Another option, I don't know if you've thought about it, would be to use a function call, which could be overridden in some situations
Other stuff { transclude() }
.

I'd like to have a sort of poll about the name. I know transclusion is the correct technical term: but at the end of the day to it sounds really angularish. I would prefer to keep things understandable by everyone than to be absolutely technically correct. It's only my opinion so I accept alternative proposal for the name (alternative to transclusion).
For the "{ transclude() }" proposal: maybe it could be an alternative method? I like the tag because you are marking the insertion point inside an html template. But why not both. I'll take a look at that.

Another poll I have inserted two "compiler directives" here. "replacetag" and "transclude" and I took the opportunity to place them inside the opts object as it's already vehicolating correctly through the objects chain.
At a more architectural level It could be better to define that such possibility is offered by the framework in a more specific object. It could be called "api", "behaviour", "component" or other ideas?

Sorry, I wasn't implying to change the name of the tag to "transclude" just because I thought it the correct term. I just noticed that you had implemented both an option called "transclude" and a tag called "include" to create the one feature. Keeping them both the same would cause less confusion. And again, once you've decided on what to call the tag, the compiler directive's name will become obvious.
I know what you mean about "transclusion" sounding a bit "angular-esc", however, it is the perfect term as it describes exactly what's happening. "Include" sounds more like pulling an external source in to the document. So "transclude" would be my vote.
As for the object serving this feature, if you're going to be using the behaviour pattern, then "behaviour" is perfect. Otherwise I wouldn't say it would suit. Will it be serving an other features, or just this one?

This feature in "Ember.js", it provides the yield helper, is it a choice?

Actually, yeh. "Yield" also makes sense.

To such an object should be the way to activate framework features from the tag implementation to the framework. It should be general and work for every tag implementation.

So that for now we have:

Main term
Activator
Marker

Transclusion
transclusion=true
transclude

Yeld
yeld=true
yeld

I think tag could be the correct term:
with transclude
<alert>

 {msg} <transclude>

  opts.tag.transclusion = true,  // was transclude
  opts.tag.renderRoot = false  // was replacetag

  this.category = opts.category
  this.msg = opts.msg
</alert>

with yeld
<alert>

 {msg} <yeld>

  opts.tag.yeld = true,  // was transclude
  opts.tag.renderRoot = false  // was replacetag

  this.category = opts.category
  this.msg = opts.msg
</alert>

Remind me what opts.tag.renderRoot does?

yeld => yield

I was leaning towards "yield" until I saw it in practice. Now I'm back on liking transclude.

Ok, for now let's stay stick with transclude. If someone will came up with a good name we will update it later.
opts.tag.renderRoot allows to strip the custom tag from the generated markup.

Ah. Cool.

Ok done with transclusion / transclude.
<alert>

 {msg} <transclude>

  opts.tag.transclusion = true,  // was transclude
  opts.tag.skipRootNode = true  // was replacetag

  this.category = opts.category
  this.msg = opts.msg
</alert>

I've had following tag on the repository since the beginning:
https://github.com/muut/riotjs/blob/master/test/tag/inner-html.tag
It takes the inner html and appends more stuff to it upon "mount".
I think you can play more with this.root. Let me know how that works

I want to be able to define tags and use them like this:
(from twitter bootstrap http://getbootstrap.com/components/#navbar):
<navbar>
  <left>
    <brand src="logo.gif"></brand>
   <link href="#" active>text 1</link>
   <link href="#" active>text 2</link>
    <dropdown>
      <menuitem href="#">item 1</menuitem>
      <menuitem href="#">item 2</menuitem>
      ...
    </dropdown>
    <search></search>
  </left>
  <right>
    <dropdown>
      <menuitem href="#">item 1</menuitem>
      <menuitem href="#">item 2</menuitem>
      ...
   </dropdown>
  </right>
</navbar>

I don't want to define a navbar tag that uses these other tags, I want a palette of these tags that I can nest as shown in my page.  That is, I want to cobble together some number of navbars with many different options for brand, dropdown present or not, etc.
Compare that elegant looking code to the raw HTML:

Totally Agree with that. A sort of Riot-Bootstrap done that way would be wonderful!

I think this is best solved with a custom tag. Like this for example:
<some-tag>

Hello!

  <inner-html/>
</some-tag>

Here's the implementation for <inner-html>:
<inner-html>
  var p = this.parent.root
  while (p.firstChild) this.root.appendChild(p.firstChild)
</inner-html>

definitely a useful tag. Maybe we'll have a "core tags" library at some point where this would fit perfectly.
Thoughts?

Ah yes, that makes sense. Quite a simple approach.

In the tag layout for navigation I presented, the inner-tags have
this.parent === undefined.  I tried it, hence the reason for my comment
here.
On Sat, Feb 14, 2015 at 3:11 AM, Tero Piirainen<EMAIL_ADDRESS>wrote:

I think this is best solved with a custom tag. Like this for example:

Hello!

Here's the implementation for :

  var p = this.parent.root
  while (p.firstChild) this.root.appendChild(p.firstChild)

definitely a useful tag. Maybe we'll have a "core tags" library at some
point where this would fit perfectly.
Thoughts?
—
Reply to this email directly or view it on GitHub
https://github.com/muut/riotjs/issues/300#issuecomment-74371056.

I think the custom tag approach does a good job because It still leaves room for custom transclusion logic. But mschwartz does have a good point and I can see how this can get harry using custom tag logic if there is not an easy way to get at the riot level data and set the parent manually.

Actually from what I can tell with console logging when using the inner-html custom tag approach is that other nested custom tags look to know their parent before they are moved.

@mschwartz can you make a minimalistic jsfiddle where I can see this issue? Thanks!

I've found that I need to write the tag like so:
<inner-html>
  var p = this.parent.parent.root
  while (p.firstChild) this.parent.root.appendChild(p.firstChild)
</inner-html>

This only works 1 level deep. Any thoughts on how we can nest this feature?

I take that back... it kind of works. But we loose context on such things as opts and also the order of the tags gets mixed up.

I cannot make a jsfiddle because it simply wont't work.
However, this is how I had to implement a twitter bootstrap header nav using riots:
https://github.com/decafjs/decaf-examples/blob/master/riot/tags/navbar.tag
This is not how I want to express the code though.  I want to be able to:
<navbar>
  <navbar-header>
    <navbar-brand>Whatever site name</navbar-brand>
    <navbar-menu>
        <menuitem href="#">Text of menu item</menuitem>
        <menuitem href="#">Text of menu item</menuitem>
        <menuitem href="#">Text of menu item</menuitem>
    </navbar-menu>
  </navbar-header>
</navbar>

I could do something that to define the WHOLE navbar tag (see the URL/link), but I want to be able to radically customize navbar on every page as in the example I just created here.

To add to my previous comment...
How to deal with everything between  and ?  I mean not in declaring navbar tag, but in using it later on.
How to use navbar-header tag not inside  tag definition.  I mean I want to have a different navbar-header for multiple navbars throughout the application.
As is, the best I can tell, you have to define , , etc., for each navbar.
My suggestion allows me to create a library of reusable tags to create navbar for infinite applications.
If this is made to work, we could have a riotjs tag library for all of twitter bootstrap.
navbars
buttons
panels
&c

Also now getting a "TypeError: a is null" if I do not have any HTML in the inner-html tag (like an empty div).

Here's a working example, just one level deep
Here's an example 2 levels deep that I can't get to work

You can pass multiple levels via reading the inner html, then pushing it through opts, but it isn't exactly pretty. More of a hack really.

This seems to work well though:

    Test

        one
        two

riot.tag('inner-html', '', function (opts) {
    var p = this.parent.root;
    while (p.firstChild) this.root.appendChild(p.firstChild);
});

riot.tag('nav-bar', '
<inner-html></inner-html>
', function () {});

riot.tag('nav-head', '<inner-html></inner-html>', function () {});

riot.tag('nav-menu', '
<inner-html></inner-html>
', function () {});

riot.tag('nav-item', '
<inner-html></inner-html>
', function () {});

riot.mount('nav-bar');

Is this experimental code?

No, it works under 2.0.9.
http://jsfiddle.net/3x2wvv35/

Is this documented somewhere!
I like how it works, but I prefer the pre-compiled .tag format.  Would anyone ever define inner-tag to do something differently?  If not, it might be better to have it built in to the language/library.  IMO.
—
Sent from Mailbox
On Mon, Feb 16, 2015 at 6:57 PM, Jim Sparkman<EMAIL_ADDRESS>wrote:

No, it works under 2.0.9.
http://jsfiddle.net/3x2wvv35/
Reply to this email directly or view it on GitHub:
https://github.com/muut/riotjs/issues/300#issuecomment-74610076

riot.tag is the compiled form of a .tag, which is documented, if that's what you're asking. It's not recommended or the idiomatic form, but I was lazy.
The same would be accomplished as:

<inner-html></inner-html>

This is what I mean by nested tags getting messed up: http://jsfiddle.net/3x2wvv35/1/
If you were to use one of your tag (that's uses inner-html) within another... then the order gets a bit messy.

@johngeorgewright its looks like the mount('nav-bar') causes some issues for some reason but changing it to mount('*') brings out fixable errors. In this jsfiddle case (http://jsfiddle.net/tbem79bc/) the changes to how the <inner-html> moves the elements.

The previous link should have been http://jsfiddle.net/tbem79bc/1/

Also with that example change, because of how it does the move the children, you can now have the <inner-html> tag remove itself. Here is the addition for it to do that http://jsfiddle.net/tbem79bc/2/ and just does a this.root.remove() since it put the content before itself.

Only problem with this approach I see is that this.parent is lost for most of the nested elements done in the document when trying to make thing look right.

It's a bit of a trade off, but it certainly generates cleaner html.

I've used the modified inner-html from @sheastreet in this demo: https://github.com/jimsparkman/bootstrap-riot
There's so many little nuances/issues with trying to use riot tags as native html replacements, not to mention the render times. It's probably best to leave riot for the interactive bits, and plain html for the UI.

I am looking into this more to see if this can be dealt with cleanly so that this.parent is set to what is conceptually expected. I am wondering if this is the problem with the mixed usage of non-live (static) and live element traversal.

Well this issue has made me run the gamut riot to try to preserve this.parent on anything that would do anything like a "perfect" <inner-html>. Here is the jsfiddle (http://jsfiddle.net/759g80u4/) that comes out as visually intended and everything knows its conceptually correct parent.

I am not done studying this yet so there might be more examples or changes i continue to make.

What a popular topic! Looks like this needs to be nailed for the next release. I'll continue from @sheastreet 's version. Thank you for that!

Tero, even the possibility to strip the root node from the resulting html
would be appreciated. Otherwise it is very difficult to have a
compatibility with existing css frameworks. Just my 2 cents.
Il 19/Feb/2015 09:11 "Tero Piirainen"<EMAIL_ADDRESS>ha scritto:

What a popular topic! Looks like this needs to be nailed for the next
release. I'll continue from @sheastreet https://github.com/sheastreet
's version. Thank you for that!
—
Reply to this email directly or view it on GitHub
https://github.com/muut/riotjs/issues/300#issuecomment-75012620.

I'm totally aware of the need, but unfortunately it's not on top of my list because it's painfully hard.

what about a virtual - virtual dom? It's just an idea that I'm thinkg right
now while writing.
Anyway the hard part seems to be the binding between the component and the
html it generates. If you strip out the root.node you misd the position in
the html where you want to attach your content.
Il 19/Feb/2015 09:37 "Tero Piirainen"<EMAIL_ADDRESS>ha scritto:

I'm totally aware of the need, but unfortunately it's not on top of my
list because it's painfully hard.
—
Reply to this email directly or view it on GitHub
https://github.com/muut/riotjs/issues/300#issuecomment-75015002.

Haven't really thought about the implementation yet. Just my wild guess, that this is not trivial. But I'll work on this at some point. A promise.

I am looking into the possible usage of DOM Range(s) to still have the system be able to target things even if the custom tags are unwrapped.

To keep track of the place where you attached the content, why not use the approach suggested by @davidstan in issue #295, i.e. html comments, as used by other frameworks (Knockout for virtual elements, and Angular with directives using the "restrict: M" option)?

Well you still need two comments to define the block that is/was a custom tag and that is still a range concept.

I am having to look into this more but I believe the removal of the root.riot flag might have changed some behaviors with the my previous example approaches. I believe it was helping prevent reprocessing and execution on tags that got moved but now are being reprocessed for each level of the accumulated nested <inner-html>. Visually for the most general cases you don't have a change in pure HTML only uses but I can not confirm that fully yet. But say if you are adding comment tags before and after your custom tag in in your initial open
</pop>

<app>
  <pop name="won">
You Won! Congrats, { name }
</pop>
  <button onclick={ tags.won.show }>Roll?</button>

</app>

If that hasn't convinced, well, it's ok. Maybe if i'll have time i'll mess with the code a bit.
Thanks.

@eyy thanks for your complete answer. The thing is much more complicate than what you think. What happens to the content of the nested loops? .. And of the nested loops of other internal loops? If we start handling all this cases we will end up writing angularjs. We need to keep riot dry using the yield tag we can cover the most of transclusion cases in a clear and simple way, without expecting any surprise. I'am going to close this issue for now. And I would be really happy to dig it more this argument in another issue. Thanks to for all your useful examples you helped me a lot :v:

:v:


Wasm simd

This adds a SIMD implementation using simd-128, along with a small change to fix link errors for the wasm32-wasi target.  It speeds up the large_image benchmark by about 45%.
All tests pass except for large_image.jpg - the image dimensions overflow on 32-bit platforms.
In order to run benchmarks, Criterion needs to be updated to version 0.4, which makes Rayon an optional feature.  I didn't check in this change because I didn't want to mess with dependencies for a mostly unrelated change.
Sorry for making an unsolicited pull request!  I did this for a hobby project and thought it might be worth upstreaming.

Very nice. Definitely worth upstreaming! And 45%, that's just incredible :)

It's interesting that the load/store operations have no alignment requirements so we can avoid that stack buffer nonoverlapping copy we have in other implementations.

This was surprising to me too.  In the spec, it's possible to have a higher alignment, but Rust decided against making it the default. (side note: is it possible/worth it to align those slices for the other versions?)
This was almost all done by copying the SSSE3 implementation and find-and-replacing instructions (e.g. _mm_mulhrs_epi16 to i16x8_q15mulr_sat), with the exception of transpose() and the shuffle to RGB order in color_convert_line_ycbcr().  I admit I took the pointer arithmetic for granted 😅   I've gone through and added safety comments to all three unsafe blocks.

What about just using the Wide crate and letting the compiler do the rest? It does an amazing job picking the right instructions depending on what features you enable (SSE2,AVX,WASM) etc. Even the transpose is done surprisingly fast despite looking like it would be super slow.
Here's an example implementation:
https://github.com/microsoft/lepton_jpeg_rust/blob/main/src/structs/idct.rs

Sorry for forgetting to merge this after approvals.
@mcroomp Feel free to provide a PR with performance comparison but the experience with any auto-vectorization-based approach has, historically, not been amazing.


identifying successfully shared post status

How can I identify if user did really shared post or canceled it?  I get OK message in any circumstances.
Share.shareSingle(Object.assign(shareOptions, {"social": "facebook"}))
 .then((res) => {
       if (res.message == 'OK') {
             //........
       }
 })

+1

have the same question

anyone can solve this ?

Any update here??

promise resolve/reject?


Add testing

Would like to use tap -- seems like typescript support is coming in (https://github.com/tapjs/node-tap/pull/481). Open to other options as well.

Wait for this being merged to tap.


preLoadList files doesn't honor subDirPattern settings in folders

Thanks for this useful tool!
The issue is, for example, if there's a business_rules rule.js, with subDirPattern: collection/when, it would land at buiness_rules/table_name/after/rule.js if it's downloaded by search. However if it's included the in preLoadList, the file would end up at buiness_rules/rule.js. It wouldn't keep the same final downloaded folder file structures.
As a results of these, if I share a exported settings.json to other people, the resulting workspace folder would look quite different from mine which generated the settings.

Thanks for reporting this issue!
I see that the export/preLoad feature is lacking support to build the sub dir pattern properly. This is something I'll look into supporting. Does a --re-sync fix the issue?

I've added support and will push up a fix after I've done more testing.

Finally pushed up latest code. Please test and let me know if everything is great.

Assessing as closed.


fix: trace fixes for troubleshooting panel

Map trace-ID URLs to trace:id queries.
Add "select" set for common attributes.

Rules are not yet doing any correlation, will continue on this PR.

/lgtm

/cherry-pick release-0.3


How can I use the model and config from local path

Hi
I am trying to use layout-parser to parse the data from PDF. Because some network issue, I can't download the config from  'lp://PubLayNet/faster_rcnn_R_50_FPN_3x/config'. But I can down load the model_final.pth and config.yaml through my browser. After that I use following code to set up the config path and model path. However, Nothing can be parsed. Is there any thing wrong when I use local path?
model = lp.Detectron2LayoutModel(''config.yaml', "model_final.pth",
extra_config=["MODEL.ROI_HEADS.SCORE_THRESH_TEST", 0.8],
label_map={0: "Text", 1: "Title", 2: "List", 3:"Table", 4:"Figure"})

Can you confirm you have both files config.yaml and model_final.pth in the same directory as the python script?
If it still doesn't work, you might want to add ./ before the paths:

model = lp.Detectron2LayoutModel("./config.yaml", "./model_final.pth",
extra_config=["MODEL.ROI_HEADS.SCORE_THRESH_TEST", 0.8],
label_map={0: "Text", 1: "Title", 2: "List", 3:"Table", 4:"Figure"})

.
If not, please attach your error message in the next post. Thanks.

Thanks very much for your help. The problem is resolved and we can close the issue

Thanks very much, it helps me a lot.

where to download config and model


0.5.2 breaks in webpack

0.5.1 works fine.
After upgrading to 0.5.2 webpack fails to build with these errors:
Module not found: Error: Can't resolve './create-query-service' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'create-query-service.js'?
BREAKING CHANGE: The request './create-query-service' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

ERROR in<EMAIL_ADDRESS>15:0-105
Module not found: Error: Can't resolve './create-query-functions' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'create-query-functions.js'?
BREAKING CHANGE: The request './create-query-functions' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

ERROR in<EMAIL_ADDRESS>16:0-64
Module not found: Error: Can't resolve './create-unary-functions' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'create-unary-functions.js'?
BREAKING CHANGE: The request './create-unary-functions' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

ERROR in<EMAIL_ADDRESS>17:0-39
Module not found: Error: Can't resolve './utils' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'utils.js'?
BREAKING CHANGE: The request './utils' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

ERROR in<EMAIL_ADDRESS>18:0-66
Module not found: Error: Can't resolve './use-transport' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'use-transport.js'?
BREAKING CHANGE: The request './use-transport' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

ERROR in<EMAIL_ADDRESS>19:0-56
Module not found: Error: Can't resolve './create-unary-hooks' in '/Users/daniel/project/node_modules/@connectrpc/connect-query/dist/esm'
Did you mean 'create-unary-hooks.js'?
BREAKING CHANGE: The request './create-unary-hooks' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

webpack 5.88.2 compiled with 20 errors in 19953 ms

Manually editing<EMAIL_ADDRESS>and removing "type"="module" solves the issue
the client is generated with target=ts and then built to an internal module with typescript as a dual ESM/CJS package
I'm pinning the version to 0.5.1 for now

Hi @dstaver, I'm sorry you ran into this problem. We've investigated moving to Node16 module resolution to catch these problems but ran into some downstream dependency problems. In the meantime, I have a fix for this specific problem and will get that released soon.

🚀 Released in 0.5.3


Monitor resources working

Yay, new bug found! Don't merge this :D

Everything seems to be working now!


samples: add missing sample.yaml files

Some samples were without sample.yaml. This adds
them.
Fixes #27813
Signed-off-by: Jennifer Williams<EMAIL_ADDRESS>

From what I understand to be happening, the build failures are not necessarily introduced by this patch, but rather made visible in CI by adding the sample.yaml. The patch implements missing sample.yaml, which is correctly found by sanitycheck. So, unless I'm mistaken, I should submit a bug for these?

iotdk for samples/subsys/mgmt/osdp/
intel_s1000_crb for samples/boards/intel_s1000_crb/dmic/sample.board.intel_s1000_crb.dmic

* `intel_s1000_crb` for `samples/boards/intel_s1000_crb/dmic/sample.board.intel_s1000_crb.dmic`

this https://github.com/zephyrproject-rtos/zephyr/pull/27946 should fix it.

* `iotdk` for `samples/subsys/mgmt/osdp/`

this just needs a filter, has nothing to do with iotdk.
filter: dt_compat_enabled_with_alias("gpio-leds", "led0") and CONFIG_SERIAL should do it, but OSDP needs a fix as well, you can add it here as another commit:
diff --git a/subsys/mgmt/osdp/Kconfig b/subsys/mgmt/osdp/Kconfig
index 1b3aa3e1b8..a5b4de60c4 100644
--- a/subsys/mgmt/osdp/Kconfig
+++ b/subsys/mgmt/osdp/Kconfig
@@ -8,11 +8,8 @@ menuconfig OSDP
        bool "Open Supervised Device Protocol (OSDP) driver"
        select RING_BUFFER
        select SERIAL
-       select SERIAL_HAS_DRIVER
        select SERIAL_SUPPORT_INTERRUPT
-       select UART_INTERRUPT_DRIVEN
        select ENTROPY_GENERATOR
-       select TEST_RANDOM_GENERATOR
        help
          Add support for Open Supervised Device Protocol (OSDP)

I incorporated the suggestions to osdp/sample.yaml from https://github.com/zephyrproject-rtos/zephyr/commit/de6500d7d9c6f87b88d5f803504deacc6a70cf69 in https://github.com/zephyrproject-rtos/zephyr/pull/27949

Well, this certainly is finding a lot of problems in the samples....  This looks like it'll be good, but I'll wait until tests pass before reviewing for real.

I applied the filter (thanks for the tip!) and rebased now that the #27949 merged.

This looks like it'll be good, but I'll wait until tests pass before reviewing for real.

@pabigot Thanks for the review, glad this patch is helpful! Please take another look.


Remove branches after PR merge

This is a repo setting that will make it easier to maintain branches.

I left that checkmark in the options :+1:


chore(master): release 0.7.0

:robot: I have created a release beep boop
0.7.0 (2023-03-21)
Features

update whatauthorized implementation (25bf78f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/indykite/jarvis-sdk-go/releases/tag/v0.7.0 :sunflower:


fix(snack-bar): SimpleSnackBar not being exported

Fixes the SimpleSnackBar class not being exported.
Moves the MdSnackBarModule to the index.ts for consistency with other modules.

Fixes #3010.

It seems we aren't too consistent with this index.ts file when it comes to putting modules into it. Should we consider putting all component modules into their respective index.ts files?

I'd say so. I've had it on my backlog for a while.


chore: replace byComponent "by" By.directive

It does the same! However, our util was flakier, as it looked by the component selector. There have been some talking around to remove selectors. So using the DI system as By.directive does to look for the item is a stronger approach.

#896  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


jsforce typings for Typescript

Hello.
Do you have official typings definition for your library?
https://microsoft.github.io/TypeSearch/

I (attempted) to start working on a Typings library, but it is a lot of work and I have never created a typing library previously and have been trying to learn as I go.  I started with using dts-gen, which only generated typings for a few objects and I was attempting to fill in other interfaces using the API documentation.
This is still nowhere near close to being usable, but feel free to take a look.

Thanks!!!
I believe TS developers will join to us soon :)

I'm working on a TS project that uses JS force. Will try to contribute

I have just made typings for jsforce:
How to install:
npm install @types/jsforce --save

enjoy!
https://www.npmjs.com/package/@types/jsforce

Can perhaps close this?

@dolanmiu , thanks for your work! Any chance you can add missing methods for Bulk and Streaming?
Thanks in advance!

Will do! Give me a few days

@reflog Here is the PR:
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/25152
I added some tests for Bulk and Streaming from:
https://jsforce.github.io/document/#bulk-api
https://jsforce.github.io/document/#streaming-api
Let me know if there are any issues

@dolanmiu - When I was using the SalesforceDX plugin generator, I noticed that they are using your types and they are auto-included in the project - great job!
I came across a situation where I noticed that Record<T> was being returned from a query and noticed that the Id field is mandatory, which I ended up having to work around for my use case.
I was curious as to your reasoning for this design decision?  If I am creating a brand new record, the Id does not exist and I am forced to include a null value (assuming my tsconfig is not too strict), and I am in no way required to include the Id field from a SOQL query.
Aside from the question above, I think you have done an amazing job getting this thing created and I am glad that Salesforce started using it for SFDX!

I wasn't part of the design decisions for Record:
https://github.com/DefinitelyTyped/DefinitelyTyped/commits/master/types/jsforce/record.d.ts
@netes @baronfel Could you give some insight?

It's been a while (and I no longer work at the company that used this work, or in node for that matter!) but if I recall correctly there were some updates that we meant to contribute back that cleaned up some of those details. For example, on create/upsert method the inserted types would be Partial<Record<T>>, so allow a user to do partials.  Then Updates would just be Record<T> or something like that to show that you had to provide the id to do the merge with.  It's all a bit fuzzy now, to be honest.  The typings are really quite easy to update and more reflect the slice of usage we had rather than a true fully-fleshed out representation of the library (which is the case for far too many typings 😢  )

Hi There, How can I subscribe to streaming API with replayExtension in Typescript?
I am using below code for subscribing/unsubscribing streaming API

Login

conn = new jsforce.Connection({loginUrl: process.env.SALESFORCE_URL});
await conn.login(process.env.SALESFORCE_USERNAME, process.env.SALESFORCE_TOKEN);

Subscribe

subscription = conn.streaming
            .topic(`/event/${eventName}`)
            .subscribe(async () => {
                //do something
            });

unsubscribe

subscription.cancel();

In @types/jsforce, both streaming.subscribe and topic.subscribe method can return Faye Subscription, but I can NOT find a method to return a Faye client.
Can you let me know how I can add replay extension before creating the Faye subscription?

This should be fixed in v3, see: https://github.com/jsforce/jsforce/discussions/1529


prev issue 57 - 1: additional detail on CLIC M/S/U memory mapped regions

Separating previous issue #57 into multiple issues for better tracking

location
I want to reiterate the issue around knowing where a hart's CLIC M/S/U regions are located - I'd like to suggest that we probably need not just mclicbase but sclicbase/uclicbase (where appropriate) too - they're cheap because they're read-only

I don't think we need these CSRs.  Most embedded systems will compile in the CLIC memory map as a constant instead of dynamically querying this value and using as a variable.  Others are working on more general discovery mechanism for debug tools that would not need to chew up CSR address space.
The lower-mode base as seen by lower-mode code can be affected by address translation of lower modes.

can this be closed with pull #129 ?


⚠ sandbox-api.piste.gouv.fr healthcheck has degraded performance

In f7ce38a, sandbox-api.piste.gouv.fr healthcheck (https://sandbox-api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 4841 ms

Resolved: sandbox-api.piste.gouv.fr healthcheck performance has improved in 02b2c02.


broken links in README.md

Some of the links in README.md seems to be broken (see screenshot below).

Fixed by #256


add requirements for job_object_helper

This seems like it would be more at home in c-pal rather that c-util

Good point.  moving code.

In reply to:<PHONE_NUMBER>


Latest kedro load and save breaks mypy on datasets

Description

kedro_datasets/pandas/json_dataset.py:210: error: "AbstractDataset[Any, Any]" has no attribute "_load"; maybe "load"?  [attr-defined]

https://github.com/kedro-org/kedro-plugins/actions/runs/10181415594/job/28161510649?pr=786
The root cause is now dataset cannot find the _load method as it's looking for signature of AbstractDataset, while the _load is implemented in JSONDataset
Potential Fix
Use generic type instead of returing AbstractDataset in https://github.com/kedro-org/kedro/blob/8bbbfb6c7257005bef841143690308f05d4b829b/kedro/io/core.py#L403-L407

I'll update the datasets to use public load and save.


MH-12771 Document fields of External API 1.0.0

This PR attempts to improve the precision of the External API specification.
The main focus is on including all fields of all objects in the specification (rather than just in the examples).
Note that this PR should not change the External API 1.0.0 - it rather tries (based on the current state of branch develop) to describe it in more details. In case the specification added here deviates from the current implementation, that would be a bug in the specification.
Please also note that the specification also has more room for precision: So this is an attempt to improve the specification, not to make it perfect.

@staubesv: Is this a WIP PR?  Or are all the currently planned changes present?  I'm happy to review, but I'd really rather look at this once rather than have to keep coming back :)

@gregorydlogan This PR is ready for review. It does document the current state of the External API 1.0.0 based on the current state of the branch develop. Happy to have you as reviewer!


Behaviour when regex does not match

Good day @the-wright-jamie, thank you for your fork.
Is there any opportunity to do nothing when branch does not matches regex? I added this action to our action flow and from time to time we have branches like hotfix-whatever that does not matches provided regex. And, as we can see in description, action fails as expected. Any workaround for that?
Thanks!

Heya!
Yeah, there probably is something that can be done about that. It's been a while since I've worked on this, so I'm going to have to re-read what this actually does under the hood. I'll see what I can do for you.

Added a new option to error-on-fail - defaults to true.
Make sure your uses line looks like this:
- uses: the-wright-jamie/update-pr-info-action@master

API is unlikely to change too much, so using master should be safe.


Download FIle problem

In new Version , when I download a .php file from host , remore ftp create a folder instead .php file

+1

+1

I have the same problem. Please anybody helpme.

Same problem.

Same here.

+1

+1

I unpublished 1.1.4 version, try re-install.

Replated #925


[New] select variables which are used in regression

Summary of this new feature
With a new argument, we can select variables of extra datasets used in regression of Scenario.fit() method. At the current version, "Stringency_index" is removed when delay is None because this is used in calculation of delay period.

Usage will be Scenario.fit(removed_cols=["Tests"]). None is default value and indicators used to estimate delay period will be removed automatically.


test build page not found

StaxRip x64 <IP_ADDRESS> unstable test build
Help -> Website -> test build
https://github.com/stax76/staxrip/blob/master/md/test-build.md
page not found
maybe change address

Thanks for reporting, it's fixed in the next build, the new address is:
https://github.com/stax76/staxrip/blob/master/md/changelog.md

It's online now.
https://github.com/stax76/staxrip/blob/master/md/changelog.md


Symbol not being iterated when destructuring a Proxy

test/language/expressions/object/dstr/object-rest-proxy-ownkeys-returned-keys-order.js
fails with
Test262Error: Expected [foo, 0] and [Symbol(), foo, 0] to have the same contents.

Actually fixed by a88d78e02a29a01fcbc84aec8e6efecdf760b685 (the commit message is wrong)


Config occultism-server.toml is invalid, correcting

Describe the bug
Per #702 , I installed Minecraft 1.18.2, Forge 40.1.0, and Occultism  1.18.2-1.32.1 to test this out, along with AppleSkin, Controlling, Curios API, GeckoLib, JEI, Mouse Tweaks, The One Probe, and Patchouli.
Without making any changes to the occultism-server.toml config, I see this message in my logs on client startup:
[26Apr2022 15:02:30.338] [Thread-1/WARN] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Configuration file /Applications/MultiMC.app/Data/instances/1.18.2/.minecraft/saves/New World/serverconfig/occultism-server.toml is not correct. Correcting
Closing the client, editing the file to include names like "ATLGeek007" and "Charibades" then starting the client results in the same message, and the config file getting clobbered with the default config on startup.
To Reproduce

install forge/occultism/dependencies
Start client
See "correcting" message in logs
attempt to customize spirit names
see changes immediately reverted on file reload

Expected behavior
A custom list of spirit names in the config file, that spirits are named with.
Screenshots
If applicable, add screenshots to help explain your problem.
System (please complete the following information):

Occultism Version: 1.18.2-1.32.1
OS: MacOS
Minecraft Version: 1.18.2
Modpack Link and Version, or list of mods: Occultism, Patchouli, JEI, The One Probe, AppleSkin, Controlling

Huh, seems the config system somehow is picky about being given immutable lists as default value and always wants to correct back to empty. Not the most useful "feature" haha.
Will be fixed promptly!

Thanks a lot but I'm already happily occupied haha


debugging sieve script with a parser

how about a button to test how the script would work and see which results to expect?

I am working on something like that.
Problem is that there is no good sieve parser/lexer in RainLoop to convert sieve scripts in a (simple) visual editor.
There is a sieve parser by protonmail, but there is no JavaScript ui/parser (thunderbird plugin is standalone now).
The simple sieve editor in RainLoop relies on comments with base64 encoded json inside the script.
It is a lot of work to create an UI that supports (nested) identifier test commands with comparators properly.
Not to mention all extensions...
Take a look at the dovecot pigeonhole sieve lib for example.

i take it you mean of the second idea only, the one more related to the previous title...
so i edited the original and moved the first idea to a second issue... 😒😇
you win 😁
https://github.com/RainLoop/rainloop-webmail/issues/2051

My reply was for both.
To test you also need to parse the script.
Dovecot pigeonhole has sieve-test https://www.huge-man-linux.net/man1/sieve-test.html
Take a look at the source: https://github.com/dovecot/pigeonhole


features: Don't always build sctk

This should be handled by iced_sctk (and already is, iced_sctk enables iced_native/wayland, which in turn enables the sctk dependency). Allows building libcosmic without an unconditional sctk dependency.

looks good to me


How to output Logger.e to console when running junit test in android studio

Hi there,
The title is pretty obvious. I am be able to print log to console with e.printStackTrace() when running unit test in android studio but Logger.e(JsonUtils.class.getName(), jsonString, e).
Thanks in advance!

Hi, let me check this issue.

I too am curious how to log console output from junit test.  Any update on this?

This is something I'm working on but on a different level though. I'm trying to show the output log quite differently for unit tests.

Well, silly me.  One can just use System.out.println(), and it will log.

I'll add a built-in LogAdapter to support System logs.

With a custom LogStrategy it's doable. Long time that I couldn't check this issue. One of the earliest issues. Closing this one since It can be done easily with custom LogStrategy. Looks quite nice in tests.
val formatStrategy = PrettyFormatStrategy.newBuilder()
    .logStrategy { priority, tag, message -> println(message) }
    .build()
Logger.addLogAdapter(AndroidLogAdapter(formatStrategy))


Final Peer feedbacks

feature importance plot (lollipop chart for example) (Sree)
check the correlation between features (for example correlation heatmap,...) (Sirine)
remove the BMI VS age plot (Sirine)
split the BMI in 3 categories and treate it as a categorical variable (Sirine)
do a one side hypothesis test for the smoker VS non-smoker test (Karan)
add the line y=x on the actual VS predicted expenses (Sree)

The correlation heatmap is done

I removed the BMI VS age plot

I split the BMI in 4 categories and updated the corresponding charts

I have updated following to the project:

Makefile workflow
One Side Hypothesis Test
Added Test Case to EDA

We have addressed all of the above concerns in our Milestone 3. At this point in time, we have addressed TA feedbacks and Peer feedbacks too. We can close this issue now.


System status and monitoring

who will be monitoring
where are the logs
logs are then monitored
and then if logs are dead it does some sort of check

First draft sketched out
Suggest we add https://prometheus.io/docs/guides/cadvisor/ before closing this
Need to scope this to the minimum necessary i.e. 'what's working'
And decide if this is part of HyUI or HySys.
I suspect the latter but we will need a guide to allow users to instrument the applications sharing data

what would be simple, do-able, and worthwhile
for discussion and really just to decide what's worth doing in the last few days

Agreed that minimum monitoring on the HySys side is that recent data is coming through into HyFlow.
@jongillham adding a quick check for this and wrapping in a FastAPI endpoint


Empty images list when project integrate with Instabug

Expected Behavior
After granted storage permission, it should display images list
Actual Behavior
An empty image list with a snackbar  has empty message, only Ok button
Steps to Reproduce the Problem

Integrate with Instabug 10.5.0
Open ImagePicker
Granted storage permission

Specifications

Image Picker Version:  3.3.0..0-beta1
Android OS: 11
Phone: Samsung S21

This is related to https://github.com/esafirm/android-image-picker/pull/362.
This library checks whether "write permission" is granted or not,  but the "write permission" is ignored in Android 11.

Fixed in https://github.com/esafirm/android-image-picker/pull/431


Minor tweak to newline

Note that when two spaces are used at the end of a line, markdown does not employ line continuation.

Well spotted, thanks!


Rule proposal: Readability rule - Operator placement for wrapped expressions

(EOL = End of Line, BOL = Beginning of Line)
I think StyleCop should dictate (or at least try to dictate) the position of operators. An example:
this is on one line, and it's ok...
if (true && false)
{
}

But on two lines?
if (true &&
false)

or
if (true
&& false)

the same for +, -, *, /
And then there are ? (with :) and ??.
I think that these operators should be put at End of Line, so that if the second operand is a brace the line begins with the brace.
last but not least is the "." operator. Here I think it's easier. It should go on the new line for the same reason as the "this" that is necessary. When you press "." the vs shows you the list of the properties/methods/fields of the object.
So it should be:
var temp3 = new int[5]
.Cast<long>()
.Cast<int>();

Originally posted by xanatos http://stylecop.codeplex.com/workitem/6791

I agree there should be rule regarding this. But in my opinion operator should be placed always at the beginning of line. First, it is easier to see that this is continuation from previous line. Second, it allows to easy comment out part of expression - no dangling operator at the end of the line preceding commented out line. Third, it better suits mental model (at least mine) - I think "If something  and_something_else" not "if something_and something_else". You get my point here

I agree with placement at the beginning of the line.
I'm not sure how we would formally define this rule and present it to users. Perhaps "Binary operators must not be followed by a newline" or "Wrap binary expressions before the operator"?

I am not native English, so I don't feel competent enough regarding exact wording :)

Would it be possible to separate the rule for ? and ?? from the other operators? I'm with the original poster on this one, as visually I parse:
someCondition ?
  resultIfTrue :
  resultIfFalse

In the same manner as:
if (someCondition)
{
    resultIfTrue
}
else
{
    resultIfFalse
}

It's the level of indentation that most clearly delimits the blocks, whilst if we have:
someCondition
  ? resultIfTrue
  : resultIfFalse

I lose both the ability to immediately determine that someCondition is a boolean test (without my eye skipping to the next line) and the ability to clearly pick out resultIfTrue and resultIfFalse.
I know even amongst my team we're divided on this, so if rules were available to enforce both behaviours, with one enabled by default but the ability to adopt the other if we see fit, that would be fine.

Normally, I like the break with the dot operator on the start of the next line.
int foo = Bar
    .Baz
    .Blech;

However, the new null conditional operator is kind of a special case. This looks wrong:
int foo = Bar
    ?.Baz
    ?.Blech;

But I think this looks wrong, too, especially if you break before the dot otherwise:
int foo = Bar?.
    Baz?.
    Blech;

Apparently this is legal and I guess is ok, but the ?. is actually one operator and it now has a line break in the middle of it, so makes me queasy, too:
int foo = Bar?
    .Baz?
    .Blech;

Thoughts on breaking null conditional operators?

Why does
int foo = Bar
    ?.Baz
    ?.Blech;

look wrong to you?
It immediately gives you proper info that Baz and Blech are called conditionally. No need to scan end of previous line to see this.

I guess I could get used to it. Is this the consensus of how it should be done? I kind of feel that the ? belongs to the Bar, not the Baz.

@GregReddick I agree that I mentally think of the ? belonging to Bar, not Baz. But at the same time, when quickly glancing over code, it's a whole lot easier to see that ?.Bar is a null-check than if it's hidden at the end of the previous line.
I like the ?.Bar syntax for that reason, and because it's consistent with how I typically start lines with . already.

Okay. Having played with it, I agree that ?.Baz is the best choice of the three. It makes it consistent that operators should appear at the beginning of the line.
I prefer
someCondition
  ? resultIfTrue
  : resultIfFalse

to
someCondition ?
    resultIfTrue :
    resultIfFalse

And
a = b
    + c

over
a = b +
    c

The operator at the beginning of the line (plus the indenting) makes it easy to see that the line is a continuation.

I completely agree about all except the last two. I personally prefer
a = b +
      c

and
if (a &&
    b &&
    c)

myself, but it's just a personal preference. In these cases, I like the variables lined up vertically. I'm sure I could just get used to the change, though, if we decided that always starting a line with an operator was the way to go.
Should this be split into two rules? One dealing with .Baz and ?.Baz, while another deals with things like +-*/ and &&?

In our team we ran in to this issue due to assignment operator. Half of the legacy code has it placed on the next line like so:
var myVariable
    = "Hello world";

We would definitely like to invest in StyleCop to have a rule (+auto-fix for this), so that we can quickly clean in up. Was there ever a consensus on a particular set of operators and how majority of people would want them to be formatted?
From what I understand current preference is:
fooBar
   .Method()
   .SomeOtherMethod();

fooBar
    ?.Method()
    ?.SomeOtherMethod();

var myVariable =
    "Hello world";

Maybe we can start with this set and expand it later, once/if we reach an agreement?
As to the name, since we want some operators on the previous line and some on the next - I think we have two options:

Add one rule Binary operators should be placed correctly (or remove binary, as Elvis, aka ?:,  is not binary and we may include it in the future)
Add two rules:

one for Binary operators should be placed on the line with first operand
two for Binary operators should be placed on the line with second operand

My vote is for Operators should be placed correctly.

I understand people may have different preferences, but I thinking allowing people to choose how it should be formatted is defeating the purpose of common coding styles. Yeah, it works if you only care about your project, but if you work on multiple projects it doesn't help much with readability. Another problem is when you want to integrate two different code-bases together and they use different styles.
In my opinion, we want coding styles to be attached to the language, rather than the project.


Make log-cache walk delay configurable

In a recent pr we introduced a walk delay of 250ms each time log-cache returns no logs for a particular app, this was reduce performance issues the cf CLI was causing by hitting log-cache with a LOT of requests when there was no apps, without sufficiently waiting.  We want to make this timeout configurable.
This change will only effect v8

Not sure if we wanna do this actually


Change in the Iteration Path

{"System.IterationPath": "Area\Iteration 1", "System.AssignedTo": "Fabrikam"}
Only the above Iteration Path worked for us.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99771c68-5f45-887a-e926-9ea772021f99
Version Independent ID: 865109fc-64b8-ba77-2e10-8002886c46c7
Content
Content Source
Service: vs-appcenter

Hi @sprabhuraj, thanks for reaching out! Could you share more on what you are trying to achieve, and what is not working?

When we were configuring the Iteration Path with just Iteration 1, we got
an error saying Area\Iteration Path not found. Hence we had to specify as
Area\Iteration 1 in the Iteration Path, along with the escape character.
Hope this helps.
On Thu, Mar 1, 2018 at 6:22 PM, Amanda Chew<EMAIL_ADDRESS>wrote:

Hi @sprabhuraj https://github.com/sprabhuraj, thanks for reaching out!
Could you share more on what you are trying to achieve, and what is not
working?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/appcenter-docs/issues/35#issuecomment-369778008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APiqXQFLhLD9SXdB61rOi2TBZ0OeQ1UPks5taJDfgaJpZM4SXOQf
.

--

Keep Smiling :-)

Because SMILE is the first best thing you can do with your lips for nothing!

Hi @sprabhuraj thanks for clarifying! We're investigating this now, and will update again.

Hey @sprabhuraj, update, I've submitted a PR to edit the documentation for bug tracker and we're working on editing the UI in App Center.
The correct example for a default payload is {"System.IterationPath": "Area\\Iteration 1", "System.AssignedTo": "Fabrikam"}.
Thank you for bringing this to our attention!

Hi @sprabhuraj, updating on the progress: I've made the changes to reflect the correct example in the public documentation. Regarding the UI in the bugtracker wizard, we're working on editing this. Thanks!


Support data_only and return simplified matrix

as discussed #27 , now in a separate issue.

Thanks for the dedicated issue.
In terms of user interface, I think this option should essentially be a switch between a list (with full metadata, which is currently returned to the user) and a matrix.
The rationale is:

a chemometrician wanting to pull spectra to either calibrate a model or generate predictions would call read_opus with data_only = TRUE so a matrix is returned and can be pre-processed directly.
a more advanced user might turn data_only to FALSE for more advanced checks on the data, and a more thorough look at the metadata -- and could of course use a lapply call on that list to combine whatever piece of the data is interesting.

Finally, I'd suggest to change the argument name, and use a simpler and more common matrix = TRUE|FALSE.
Example call:
# Select all OPUS files from a range of folders
opus_fns <- list.files("some/project/folder/", pattern = glob2rx("my_project-*.0"), full.names = TRUE)

# Directly read and assemble MIR matrix from the selected files
mir_mat <- read_opus(
  opus_fns,
  matrix = TRUE,
  progress = TRUE
)

# Quick plot
matplot(t(mir_mat))

Thanks for the dedicated issue.
In terms of user interface, I think this option should essentially be a switch between a list (with full metadata, which is currently returned to the user) and a matrix.
The rationale is:
* a chemometrician wanting to pull spectra to either calibrate a model or generate predictions would call `read_opus` with `data_only = TRUE` so a matrix is returned and can be pre-processed directly.

* a **more advanced user** might turn `data_only` to `FALSE` for more advanced checks on the data, and a more thorough look at the metadata -- and could of course use a `lapply` call on that list to combine whatever piece of the data is interesting.

Finally, I'd suggest to change the argument name, and use a simpler and more common matrix = TRUE|FALSE.
Example call:
# Select all OPUS files from a range of folders
opus_fns <- list.files("some/project/folder/", pattern = glob2rx("my_project-*.0"), full.names = TRUE)

# Directly read and assemble MIR matrix from the selected files
mir_mat <- read_opus(
  opus_fns,
  matrix = TRUE,
  progress = TRUE
)

# Quick plot
matplot(t(mir_mat))

Thanks for the nice summaries of use cases. I would not rename to matrix, because it hides the intent what the function does. Yes, it does return a matrix, but it is not clean that this switch is for all parameters and data vs. final spectra only. @pierreroudier @ThomasKnecht I would suggest to either make matrix_spectra or matrix_spec in case we moved away from data_only

Because it is quite an important argument for controlling read_opus() behavior and user experience, these two steps seem important:

make clean in the argument name what the output is ( @pierreroudier above), and that only (final) spectra are returned.
document this argument really concisely.

currently it is possible to only parse the data. the combination to a matrix should in my opinion be made in an extra function.


test: migrate install* and inheritable_workspace_fields to snapbox

What does this PR try to resolve?
Part of https://github.com/rust-lang/cargo/issues/14039.
Migrate following to snapbox:

tests/testsuite/inheritable_workspace_fields.rs
tests/testsuite/install.rs
tests/testsuite/install_upgrade.rs

Feedback addressed! Thanks!

Thanks!
@bors r+

:pushpin: Commit 43ad0acb8f7907fd7ac3229cb9ba7447851de80a has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 43ad0acb8f7907fd7ac3229cb9ba7447851de80a with merge 1e4969831549e7a458b24ddcf15fb69d4d50de24...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 1e4969831549e7a458b24ddcf15fb69d4d50de24 to master...


I fixed the same bug with continue-targets already a long time ago (https://codereview.chromium.org//308053012), but missed the break-target case there.


[spring] Run pipelines on 1ES agents

@mikeharder, I'm going to pre-approve this PR but I believe that monitor-tests-job.yml requires the same change.


Implement ICS 721

Import proto from https://github.com/bianjieai/nft-transfer for ICS-721

@yito88 would you regenerate protos given that the proto compiler has been revised as of v0.40.0 release? Thanks!


Consider increasing number of attnets

One strategy to help mitigate the load of attestations on nodes is to actually split committees across multiple subnets.
For example -- split each committee across two subnets, thus doubling the total subnets from 64 to 128 in which the lower half of the committee is assigned to a different subnet than the upper half of the committee (ensuring aggregatability of each half). In such a design, you'd still need to assign the same number of target aggregators per subnet (rather than per committee), so the total load on the global aggregate attestation subnet would be 2x. Given that attnets load increases linearly with size of validator set while aggregate subnet has remained stable, the trade-off to put more load on the aggregate subnet is likely acceptable.
Note, the above is just an example parametrization, you could even do a partial overlap, where you do 1.5x subnets per committee where some are split and some are not (evening out the disjoint load over many repeated epochs).
The obvious issue/downside with such a design is that without sufficient nodes on the network, you might either reduce the number of nodes per subnet to dangerous levels or you need to increase the attnets backbone subscription count to counteract it, which would still put a similar load on nodes albeit potentially helping by creating different meshes/paths.
If we had 10x the number of nodes on the network, I think such a strategy would be a no-brainer. Given our current node counts, it's unclear if this is a worthwhile path. That said, I've been sitting on this idea for a while and wanted to make sure others were aware given all of the validator-load discussions.

The reason that we don't want to increase the number of committees together with the number of subnets is because we don't want to do hard-fork, right?
If the hard-fork is not the issue, I think increasing the number of committees and subnets (which, in turn, will reduce the size of the committee) probably makes more sense than distributing the members of the committees across the subnets.
That is, setting MAX_COMMITTEES_PER_SLOT and ATTESTATION_SUBNET_COUNT to be 128 looks quite cleaner. You can just change the configurations rather than designing the p2p network.
In addition, I guess that the only reason we have committees is that we want to mitigate the load on the network, so doing multiple subnets per committee sounds like solving the problem that's already solved.

That would be a more straightforward way to do so, but would have one side effect -- it would double the total number of messages that have to be included on chain, as yuo wouldn't get the final aggregatability of the two halves of a committee. Not a death sentence, but then you'd want to consider things such as MAX_ATTESTATIONS
Given the way this affects subnet message validity, you'd have to do it at a specific coordination point (e.g. activate at a particular epoch), regardless of if you just target network values or get into the consensus values

it would double the total number of messages that have to be included on chain, as yuo wouldn't get the final aggregatability of the two halves of a committee

That makes sense.
Another question. Who will be the ones who aggregate the two halves? the block proposers, right?


Does not work after upgrading Node-Red

Please be advised .. this node does not work if you upgrade Node-Red to 0.20.5 which automatically installs node.js 10.15.3, I had to reverted back to Node-Red 0.19.5 & node 8.11.3 to get it to works again.

Please check similar issue https://github.com/eschava/node-red-contrib-xiaomi-ble/issues/4

Should be fixed with 1.2.4


added isset validation for "inversedBy"

@kokspflanze Can you please add a test case?
Look more like a mapping issue than a Doctrine bug itself.

yes its a mapping error, thats generate a warning in the log.

Closing as incomplete


DBZ-585 Renaming 'initial_schema_only' snapshot mode for SQL Server i…

…nto 'schema_only'
https://issues.redhat.com/browse/DBZ-585

@jpechane, could you review and merge?

@gunnarmorling /home/travis/build/debezium/debezium/debezium-connector-sqlserver/src/main/java/io/debezium/connector/sqlserver/SqlServerConnectorConfig.java is failing due to wrong fromatting

Updated to remove the obsolete code and apply formatting.


error while creating mount source path '/var/lib/etcd': mkdir /var/lib/etcd: permission denied

Rancher versions:
rancher/rancher: latest (2018-06-08: v2.0.2)
rancher/rancher-agent: v2.0.2
Infrastructure Stack versions:
healthcheck: ?
ipsec: ?
network-services: ?
scheduler: ?
kubernetes (if applicable): ?
Docker version: (docker version,docker info preferred)
Machine 1: Debian Jessie, Docker 18.03.1-ce, hostname: banana, ip: <IP_ADDRESS>, purpose: rancher ui
Containers: 2
 Running: 1
 Paused: 0
 Stopped: 1
Images: 1
Server Version: 18.03.1-ce
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 14
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 773c489c9c1b21a6d78b5c538cd395416ec50f88
runc version: 4fc53a81fb7c994640722ac585fa9ca548971871
init version: 949e6fa
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux 8 (jessie)
OSType: linux
Architecture: x86_64
CPUs: 6
Total Memory: 3.777GiB
Name: banana
ID: OJVT:RUUO:7A3D:GCF7:3U57:VFO6:LZGN:4KJK:VA6X:O4SD:MULO:HC6L
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No memory limit support
WARNING: No swap limit support
WARNING: No kernel memory limit support
WARNING: No oom kill disable support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support

Machine 2: Ubuntu bionic, Docker 17.06.2-c2, hostname: honeydew, ip: <IP_ADDRESS> purpose: rancher agent
Containers: 5
 Running: 2
 Paused: 0
 Stopped: 3
Images: 4
Server Version: 17.06.2-ce
Storage Driver: aufs
 Root Dir: /var/snap/docker/common/var-lib-docker/aufs
 Backing Filesystem: extfs
 Dirs: 47
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 6e23458c129b551d5c9871e5174f6b1b7f6d1170
runc version: 810190ceaa507aa2727d7ae6f4790c76ec150bd2
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.15.0-22-generic
Operating System: Ubuntu Core 16
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.544GiB
Name: honeydew
ID: BADJ:GLYH:QN2J:QESQ:VEEP:ULGW:APNG:2D3P:MRVQ:EGO2:TZHM:HVV6
Docker Root Dir: /var/snap/docker/common/var-lib-docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 42
 Goroutines: 49
 System Time: 2018-06-08T07:30:05.458371774Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Machine 1: Debian Jessie, Docker 18.03.1-ce, hostname: banana, ip: <IP_ADDRESS> purpose: rancher ui
PRETTY_NAME="Debian GNU/Linux 8 (jessie)"
NAME="Debian GNU/Linux"
VERSION_ID="8"
VERSION="8 (jessie)"
ID=debian
HOME_URL="http://www.debian.org/"
SUPPORT_URL="http://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Machine 2: Ubuntu bionic, Docker 17.06.2-c2, hostname: honeydew, ip: <IP_ADDRESS> purpose: rancher agent
NAME="Ubuntu"
VERSION="18.04 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher/rancher + Single node rancher/agent
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
?
Steps to Reproduce:
Machine 1: Debian Jessie, Docker 18.03.1-ce, hostname: banana, ip: <IP_ADDRESS> purpose: rancher ui

run sudo docker run -d --restart=unless-stopped -p 80:80 -p 443:443 rancher/rancher
Add custom cluster, only give name according to Quick Start Guide
Select all three node roles, copy comand

Machine 2: Ubuntu bionic, Docker 17.06.2-c2, hostname: honeydew, ip: <IP_ADDRESS> purpose: rancher agent

run sudo docker run -d --privileged --restart=unless-stopped --net=host -v /etc/kubernetes:/etc/kubernetes -v /var/run:/var/run rancher/rancher-agent:v2.0.2 --server https://banana --token ...omitted... --ca-checksum d177d1abd136f16ea83e89bede2dcc1b24416854c055e1ce7d2685eefa5fb8f5 --etcd --controlplane --worker

Results:

While provisioning the first node on Machine 2(rancher agent), the rancher ui shows this:

The error message in rancher ui in plain text

This cluster is currently Provisioning; areas that interact directly with it will not be available until the API is ready.

[etcd] Failed to bring up Etcd Plane: Failed to start [etcd] container on host [<IP_ADDRESS>]: Error response from daemon: error while creating mount source path '/var/lib/etcd': mkdir /var/lib/etcd: permission denied

The logs in honeydew for the first docker image show:

...
-----END CERTIFICATE-----
time="2018-06-08T07:17:38Z" level=info msg="Option etcd=true"
time="2018-06-08T07:17:38Z" level=info msg="Option controlPlane=true"
time="2018-06-08T07:17:38Z" level=info msg="Option worker=true"
time="2018-06-08T07:17:38Z" level=info msg="Option requestedHostname=honeydew"
time="2018-06-08T07:17:38Z" level=info msg="Option customConfig=map[roles:[etcd worker controlplane] address:<IP_ADDRESS> internalAddress:]"
time="2018-06-08T07:17:38Z" level=info msg="Connecting to wss://banana/v3/connect/register with token ...omitted..."
time="2018-06-08T07:17:38Z" level=info msg="Connecting to proxy" url="wss://banana/v3/connect/register"
time="2018-06-08T07:17:38Z" level=error msg="Failed to connect to proxy" error="websocket: bad handshake"
time="2018-06-08T07:17:38Z" level=error msg="Failed to connect to proxy" error="websocket: bad handshake"
time="2018-06-08T07:17:48Z" level=info msg="Connecting to wss://banana/v3/connect/register with token ...omitted..."
time="2018-06-08T07:17:48Z" level=info msg="Connecting to proxy" url="wss://banana/v3/connect/register"
time="2018-06-08T07:17:49Z" level=info msg="Starting plan monitor"

The logs in honeydew for the second docker image show:

Found container ID: 2c61c2d7025f2e2c6866c6965303170a6a969044f40f075cbc6608f323f68e1c
Checking root: /host/run/runc
Checking file: 2867f2819704d2737e4a297410da547ce7791ee2186a9f0f5d13f315ac3ee260
Checking file: 2c61c2d7025f2e2c6866c6965303170a6a969044f40f075cbc6608f323f68e1c
Found state.json: 2c61c2d7025f2e2c6866c6965303170a6a969044f40f075cbc6608f323f68e1c
time="2018-06-08T06:47:50Z" level=info msg="Execing [/usr/bin/nsenter --mount=/proc/17508/ns/mnt -F -- /var/snap/docker/common/var-lib-docker/aufs/mnt/73146d21e8d85e7693f12549be6db0ea0cf341e59b9248feb6cb5f8b8b7f851e/usr/bin/share-mnt --stage2 /var/lib/kubelet /var/lib/rancher -- norun]"
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
Error response from daemon: {"message":"No such container: kubelet"}
Error: failed to start containers: kubelet
...

There is a known issue when using snap to install Docker, please use upstream packages and try again.

Thanks for the quick response! WIll try this

Documenting here for others that have these issues:
TLDR;

USE SUPPORTED OS VERSIONS, SUCH AS UBUNTU 16.04,
You can use debian with this fix

Longer
I see now why, I did not find the docker-ce package on the stable package repositories for Ubuntu 18.04, only in testing, but apt-get suggested snap and I tried that which ended me up with this error.
I tried to add a test package repository for ubuntu for now to enable installing docker-ce from there.
That way I could get hold of docker-ce, but only 18.05.0, not the required 17.03.2. So it seems Ubuntu 18.04 is a no go and that Ubuntu 16.04 or some other distro is the option in this case.
Using 18.05.0 rendered other errors since kubernetes only supports up to 17.12.0 currently

https://github.com/rancher/rancher/issues/13888

facing similar problem with zypper

any idea to fix this?

check if the docker is installed as snap package by
sudo snap list
if its a snap installation, remove docker using snap
once done, Please do a fresh installation using direct docker upstream. That should ideally solve

sudo snap remove docker
use this to remove docker


update the documentation on testing and debugging

https://docs.google.com/document/d/1BeLh_HKtVwmphKZZJyemtr8x5j1whLD8V4v6-QHj8TE/edit#heading=h.tav27sktyepa
Convert to AI2 and add better advice/information on debugging

File has been updated to AI2. Added a bit more about using Notifier and Labels to display values during debugging.

@kdclang Thanks.
closing the issue


[API] -  Roles

ATM only some routes are locked for simple user, we need to continue

after chatting with @Darkweak, I have to use symfony's "voter" and add the right annotations

done in #59


Enable ValueTemplateParamerters in the parser

Test ?

coming

done

I don't like having to reduce unittests when a specific thing breaks...

unitests just just be added and almost never be changed

What need to be reduced is not the test, but the diff that broke the test, so that's not an issue. Having a sludge of file makes it harder to run a selected set of tests.

okay I'll merge it with test0154

Done

When this is merged I can modify the test for is Expressions

Ok this looks good. Please change the comment and this gets in. Also, keep in mind that unless you comment, I don't have notification because, github is such a broken website.

Turns out I neede dthat so I did it? Turns out also that it is useless as this because ValueMatcher isn't casting, which makes me question how this was tested.

@deadalnix we needed that all along :)

Yes but here is the problem. Once again, I can't trust that you tested your code properly. A quick test on my side revealed that this is not working without a cast even is very trivial cases.


[BEAM-288] Improve UnboundedSource javadoc

R: @dhalperi

ping

PTAL

Not urgent, but ping so I can -d the branch.


[Backport v1.0] Improved resource reservation

This is a backport issue for https://github.com/harvester/harvester/issues/2347.

Verified this feature has been implemented.

Test Information

Environment: qemu/KVM 2 nodes
Harvester Version: v1.0-ec0bb4be-head
ui-source Option: Auto
ui-index: https://releases.rancher.com/harvester-ui/dashboard/release-harvester-v1.0/index.html

Verify Steps:

Install Harvester with any nodes
Login and Navigate to Hosts
CPU/Memory/Storage should display Reserved and Used percentage.
Navigate to Host's details
Monitor Data should display Reserved and Used percentage, and should equals to the value in Hosts.


Refactor permission claim labels reconciler

Summary

Using spec in admission plugin to drive update labels
Use empty patches in removing and adding resources
Using the same validation logic in the permission claims helpers
adding a new controller to update the labels, apart of installing
api bindings

Related issue(s)
Fixes #1500

/lgtm
/approve
:shipit:

/approve

/lgtm