upgrading to latest goodtables/frictionless-py

Overview
We'd like to work on upgrading ckanext-validation's goodtables dependency to a recent frictionless-py release so that we can work on adding l10n support to both this project and frictionless-py. Interested to know if there are any reasons that we can't upgrade this dependency.

Please preserve this line to notify @amercader (lead of this repository)

That's great news! And something we definitely would like to see but haven't been able to find the time for. My overall feeling is that there would be no major issues upgrading to fricitonless-py but @roll is the expert here and maybe able to point things to consider.
There are two main ways in which this extension leverages frictionless tools:

Of course calling goodtables.validate() here. I think that the parameters that we are passing should still work in the same way in frictionless-py,  but as for the other generic options that validate() accepts, have they change a lot on frictionless-py @roll? is it worth having some sort of mapping between old and new options or can differences just be documented? I assume the schema is unchanged as this is a standard Table Schema.
This stores a report object against the resource. Again, are there major differences between old and new reports that we should consider?
The reports are rendered on the UI using the [goodtables-ui(https://github.com/frictionlessdata/goodtables-ui) library, which IIRC has been superseded by more modern components, is that correct? If so that would need to be updated but the work would be straightforward (just replacing the libraries and adapting the calls)

Not directly related but just FYI, the two other main pieces of work I'd like to get done at some point is finalizing the Python 3 / CKAN 2.9 migration (#55) and once that is done, refactoring 1) the way validation jobs are invoked from resource creates/updates (which is really ugly) and 2) leverage package_revise when available to avoid race condition issues when updating the resources with the results

frictionless-py dropped python 2 support when it was renamed from goodtables and sadly we're a ways off from migrating our site to Python 3.
Now considering using the last goodtables release and doing the l10n work there for ckanext-validation. I'll need to find a matching goodtables-ui version of course. @roll would you accept new features on goodtables 2.5.4? It looks like there were major changes to the way error strings are stored so I don't think I can reasonably work from main branch and backport to 2.5.4.

Hi @amercader @wardi,
I think migration from goodtables to frictionless is reasonably simple. I can help with the mapping of the options (we anyway are going to write this migration guide for the frictionless docs). And for a new report, you can just use https://components.frictionlessdata.io/?path=/story/components-report--invalid (as Adria mentioned) so the migration is already covered client-side.
We accept fixes to goodtables so it's not a problem if you really can't migrate to frictionless yet (which is of course recommended because of a lot of fixes and improvements). Another question is that it might be more convenient to create a fork of goodtables (even putting it on PyPi) because honestly, we're really low on resources for supporting old libraries (our focus next year will be making frictionless fully robust/performant/etc) so I just don't to want to block you.
For example, we have an external team on the Frictionless org working on other old libraries - https://github.com/orgs/frictionlessdata/teams/while-true-industries/repositories. So you'd like we can do something similar for goodtables.

BTW we're currently working on a new generation of visual components that will allow providing a simple way to integrate validation options like editing Schema or validation Inquiry for the users

@roll Thanks a fork of goodtables would suit us nicely. I can't access https://github.com/orgs/frictionlessdata/teams/while-true-industries/repositories but if you would like to create the fork on the frictionlessdata org I'll make my pull requests against that version.

Hi @amercader @wardi,
I've created a fork - https://github.com/frictionlessdata/goodtables-py - and a CKAN team (you're invited too) with the maintain permissions on it.
I can assist going forward with the build and releases.


Cranelift: clean up generated callee-save FPR code

In isa/x86/abi.rs we have to save callee-preserved FPRs for some calling conventions. We save these to the stack and reload them before exiting, but at the moment the Cranelift IR operations stack_load and stack_store are not directly encodable. In other parts of a function, stack_load and stack_store would be legalized and then optimized into the assembly we'd like (movdqa [rsp + offset], xmm*), but prologue/epilogue addition happen after both legalization and register allocation.
When stack_load and stack_store can be directly encoded, we can switch to those, remove an explicit stack_address, and simplify x86 callee-preserved FPR machinery. #1198 adds these encodings.
For more, see this comment and this comment.

I think this is fixed with the new backend framework.


Automatic start

Could you add something for an automatic start of an already existing instance?
The problem is that my instance was shut down due to alleged inactivity. This means that if you don't react directly, you also face the problem with OOC.

That’s relatively easy to do in similar manner like I did here recently https://github.com/hitrov/oci-arm-host-capacity/compare/main...check-shapes#diff-53af6a127d6c5d991df138eafd7e93fa79e50297d138da3ac0180069e050ff2dR137 basically you only need to send POST request and change endpoint path to this https://docs.oracle.com/en-us/iaas/api/#/en/iaas/20160918/Instance/InstanceAction
good luck!

Thanks for the input. Unfortunately, I am a system integrator in the network area and not a programmer. Now I have even more question marks in my eyes. :D


Rename mutate to define

We have already differed from dplyr by using sift instead of filter. mutate seems like a misnomer-- we're not mutating an existing column, but rather we're adding a new column. We're changing the dataframe that is output, but we're doing that with all of the verbs.
To make things a little easier to understand for new users, we could rename mutate to define. We could also keep around mutate for the hardcore dplyr users.

+1. Curious to hear thoughts from @dgrtwo

I don't love mutate() either, but "define" is a crowded namespace in the land of software concepts. How about annex()?

I disagree. To the extent define has a common meaning, it's exactly the same meaning as is used here. The user is defining a new variable in terms of previously existing variables.

1 to define(). I think annex() is a bit too obscure.

On Sun, May 29, 2016 at 11:30 AM, Daniel Robinson<EMAIL_ADDRESS>wrote:

I disagree. To the extent define has a common meaning, it's exactly the
same meaning as is used here. The user is defining a new variable in terms
of previously existing variables.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dodger487/dplython/issues/46#issuecomment-222375341,
or mute the thread
https://github.com/notifications/unsubscribe/AAyvbT8W4ls2rssFw1C4KeweuYHxCAbnks5qGdtFgaJpZM4IokIm
.

I can get on board with that rationale, @danrobinson.


AwtWindow/FileDialog Closes When Parent Recomposes in Specific Situations

Describe the bug
When using a composable function that abstracts around AwtWindow/FileDialog and accepts a parameter for the FileDialog parent, any composition changes in the parent Window seem to cause the FileDialog to close (via setVisible(false)).
Affected platforms
Select one of the platforms below:

Desktop

Versions

Kotlin version*: 1.9.10
Compose Multiplatform version*: 1.5.3
OS version(s)* (required for Desktop and iOS issues): Windows 10
OS architecture (x86 or arm64): x86_64
JDK (for desktop issues): 17

To Reproduce
@Composable
fun FileDialog(
    parent: Frame,
    onCloseRequest: () -> Unit,
) = AwtWindow(
    create = {
        // Replacing `parent` usage here with `null as Frame?` prevents the bug from occurring.
        object : FileDialog(parent, "Load File", LOAD) {
            override fun setVisible(isVisible: Boolean) {
                if (isVisible) {
                    println("AWT FileDialog opening")
                }

                super.setVisible(isVisible)

                if (!isVisible) return

                println("AWT FileDialog closing")
                onCloseRequest()
            }
        }
    },
    dispose = FileDialog::dispose,
)

fun main() = application {
    Window(
        onCloseRequest = ::exitApplication,
        state = rememberWindowState(size = DpSize(width = 400.dp, height = 400.dp)),
        title = "AwtWindow Close On Recomposition Bug",
        resizable = false,
    ) {
        var count by remember { mutableStateOf(0) }
        var isFileDialogOpen by remember { mutableStateOf(false) }

        Column {
            // Commenting out the `Text` component prevents the bug from occurring.
            Text("$count")

            Button(
                onClick = {
                    println("Setting isFileDialogOpen to true")
                    isFileDialogOpen = true
                },
            ) {
                Text("Load")
            }
        }

        if (isFileDialogOpen) {
            LaunchedEffect(Unit) {
                delay(2000)
                println("Incrementing count")
                count++
            }

            // Replacing the `FileDialog` function call with its body will prevent the bug from
            // occurring.
            FileDialog(
                parent = window,
                onCloseRequest = {
                    println("Setting isFileDialogOpen to false")
                    isFileDialogOpen = false
                },
            )
        }
    }
}

Launch the program.
Click the "Load" button.
Wait two seconds.

Expected behavior
The FileDialog remains open while the main window behind it recomposes to display the updated count value.
Screenshots

Additional context
Any one of a few small tweaks to the code can prevent the bug from occurring. Each of these can be done independently of each other to work around the issue:

Don't observe count (comment out the Text component displaying its value).
Remove the FileDialog composable function and inline its body where it is used in the main Window's content.
Pass in null as Frame? to the java.awt.FileDialog constructor.

I've also set up a number of print statements to trace order of execution. Here's the output for a sample run:
Setting isFileDialogOpen to true
AWT FileDialog opening
Incrementing count
AWT FileDialog opening
AWT FileDialog closing
Setting isFileDialogOpen to false
AWT FileDialog closing
Setting isFileDialogOpen to false

This sounds like it's been fixed by https://github.com/JetBrains/compose-multiplatform-core/pull/863
Please try it in Compose 1.5.10-rc01

Yes! The issue no longer occurs in 1.5.10-rc01. Sorry for the extraneous issue, but thanks for your time!

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


请教一下

如何使用自定义配置呢producerConfig

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@macbookpro2016
Modify producerConfig's field before assign it to LogProducer.
ProducerConfig producerConfig = new ProducerConfig();
producerConfig.packageTimeoutInMS = 1000;
ProducerConfig producerConfig = new ProducerConfig();
LogProducer producer = new LogProducer(producerConfig);

You can open an issue next time rather than pull request. @macbookpro2016


Scrolling stops on child iframes (videos from vimeo and youtube embeds)

On both desktop and touch devices scrolling stops working when the mouse cursor (or touch point) is on an iframe. This is because the focus goes to the iframe. I've tried numerous ways to get around this by adding scrolling="no" and overflow: hidden to the iframe without success. Using css style="pointer-events: none" fixes the scrolling issue but then any mouse activity is also disabled on the iframe.

Environment

Browser: Chrome / FF / Safari / Mobile devices
Version of smooth-scrollbar: 8.3.1

Issue Summary
Iframe takes the focus making smooth scroll parent unresponsive / frozen.
Current Behavior
Mouse over iframe embed, smooth scroll stops working.
Expected Behavior
Scrolling should still function on the parent. A possible solution could be adding an attribute to the child iframe to indicate the scrolling should be ignored: <iframe data-scroll-disabled="true" ...> or maybe part of the scrollOptions when it's initialized.
Steps to Reproduce

Setup a container with smooth scroll
Embed a youtube or vimeo video
Attempt to scroll with your cursor over the video

Online demo
https://codepan.net/gist/654acec7bbbb3742a6fc5bc892315126

This is because events from iframe cannot be captured from the outer document. See #143


MudDrawer: Fix initialization behaviour

With this PR the initialization behaviour of MudDrawer is corrected - see #4585
Description
fixes #4585
How Has This Been Tested?
Unit Tests
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Any news on this PR?

Hi.
Sorry for a very long wait, 1 year and 10 months..
Next time feel free to directly ping MudBlazor members, since we can easily miss a PR, we don't get notification when someone submits a PR.
Thanks for your interest in MudBlazor. Seems like this problem still exist in the latest v6.19.1 version.
I checked your PR, and there are few problems.
One of the main problem, is that you directly write to the component's parameter:
https://github.com/MudBlazor/MudBlazor/blob/1a019f7874d2ed36a11b79d8b88a9741bb0f8e92/src/MudBlazor/Components/Drawer/MudDrawer.razor.cs#L318
this is incorrect in blazor https://learn.microsoft.com/en-us/aspnet/core/blazor/components/overwriting-parameters?view=aspnetcore-8.0
I know we have this in our codebase, but I'm slowly getting rid of this in MudBlazor,
The correct way would be to have a backing field and modify the Open through EventCallback<bool> OpenChanged and use two-way binding, this way your parent receive new value, re-render itself, and in turn cause your child component to be re-rendered with the new Open.
I will assign this on myself, and try to fix it based on your overall idea when I get some free time.


Fix issue with s3 cp command source location in environment hook

The signature for s3_copy() changed but the aws s3 cp command call didn't change to match. This fixes that issue. It also removes the broken bucket_region local var.

It's in line with the change at https://github.com/buildkite/elastic-ci-stack-for-aws/commit/ea06ca158b9ec26fdaad8c18db6575493cad0f90. The bucket_region var is never defined and causes an error.

Oh of course. that should be $AWS_DEFAULT_REGION, man I can't figure out how I so badly merged this changeset.

I think because initially I was getting the region from the bucket for https://github.com/buildkite/elastic-ci-stack-for-aws/pull/170, but then in master I used the simpler $AWS_DEFAULT_REGION.

The merge must have gotten half of each.

Let's merge this as is and address the region stuff subsequently.


Page title says Unified Service Desk rather than Omnichannel

https://docs.microsoft.com/en-us/dynamics365/omnichannel/customizer/create-agent-supervisor-configurations-unified-service-desk is in the Omnichannel documentation, but the title refers to USD, which is a different product as I understand.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a12b9e4d-1140-f837-cbd8-fc617d1b8521
Version Independent ID: e50ed133-8194-a746-f60c-9d569bea8765
Content: Create agent and supervisor configurations in Unified Service Desk
Content Source: ce/omnichannel/customizer/create-agent-supervisor-configurations-unified-service-desk.md
Service: dynamics-365-customerservice
GitHub Login: @kabala123
Microsoft Alias: kabala

@alex-mclachlan-silverbear : Thanks for reaching out to us. Omnichannel is available to used on top of Unified Service Desk. So, this configuration refers to the same. For now, resolving the comment. Thanks in advance.


Implement QAI functions directly into client

!blacklist, !casts, !chatlist, !explode, !flip, !google, !help, !hug, !join, !leave, !link, !move, !ping, !puppet, !reload, !slap, !streams, !taunt, !tourneys, !wiki
We could add a 'Search google for "word" ' and 'Search wiki for "word" ' as context menu options in chat
!tourneys I'll leave for @Technopeon when we create a framework for this

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

some of those commands only make sense, when others can see their results though - to link tech support, a wiki entry, raise public awareness for new casts and so on

We can directly integrate what is needed straight into chat without a bot.

Some of QAI's functionality should definitely be in the client. For others the advantage is, that it can be used regardless of the client (even with plain IRC)

Didn't you mention sheeo wanting to remove irc users completely? This would be a step towards that goal.

it's still client-independent. Sheeo even wants to try WebViews to take code away from a specific client.

I mean that would make it easier to transition to other chat protocols, but this is another issue. I guess for now we can just integrate the things that make sense. Imo those would be:
google, join/leave (already integrated), tourneys, maybe wiki?

The focus of this issue is too broad. Single features will be implemented into the client, but in general I'm not planning to integrate these commands anytime soon.


v2.0.7 download is missing

I noticed that Sketch is reporting that v2.0.7 should be available, but tapping "update" doesn't do anything.

It seems that the problem is that the 2.0.7 binary is missing:
https://github.com/rodi01/RenameIt/blob/master/RenameIt.zip?raw=true
...or at least that the file referenced in appcast.xml is a 404.

@chrismessina Thanks! It should be fixed.


Scan Module to hide "scan over layers" unpleasantness in gpt2

Fixes #105.
A "Stacked" wraps another module and produces a "stacked" version of it, where an input is applied to each instance of the stacked module in sequence. This is useful for e.g. transformers where you have multiple instances of the same transformer block and the input is applied in a fold/for loop in sequence.
It's similar in spirit to an equinox.nn.Sequential (or torch.nn.Sequential), but it must be homogeneous. In Jax, this is much cheaper to compile than a sequential (or moral equivalent), because Jax compiles the module's method once, instead of unrolling the sequential and compiling everything as a giant graph. In Jax, this pattern is often called "scan layers" or "scan over layers".

this is pretty in the weeds but might interest @Ivan-Zhou . Also happy to just merge.


Automated cherry pick of #5225

Cherry pick of #5225 on release-5.23.

#5225: - Mark 'me' messages as system messages in RHS as

/cc  @nevyangelova

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: c726740e8018ed33776f33e992d81285d33e3264


An option to automatically remove completed operations

What's the Problem?
No response
Solution/Idea
An option to automatically remove completed operations
Alternatives
N/A
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
No response
Windows Version
No response
Comments
No response

@alirezanoori1986 do you mean a button or a setting that will not show completed operations to begin with?

A setting that, if turned on, will automatically remove the completed task from the "ongoing tasks" section. So suppose you copy a file. During the copy process, it is shown on the "ongoing tasks operations" and the progress is shown. As soon as it's finished, it'll be removed.

@alirezanoori1986 I'm not against this, can you share a little more feedback though on why this would be useful for your workflow? We like to show completed tasks so users can check the speed graph (once it's added) and other relevant details about the completed operation.

So this is tied with the other feature that I requested. #7225. If I see the progress while it's running, I don't need to see the completed task hanging around anymore so I want it gone. (if you copy with native explorer, once it finishes, you don't see any trace of it).
This could be merged with that. So on the right-hand side of the panel, there would be an "auto-remove" or something like that switch that would automatically remove the finished tasks and hide the panel when no task is running to restore the real estate (to show more files).

Thank you for sharing your feedback. We don't have plans to implement this option right now, but we'll make sure to update the community if we decide to add it in the future.


prediction error plot to support pandas Series object

When reading dataset as a pandas dataframe, the prediction error plot throws error AttributeError: 'Series' object has no attribute 'reshape'.
This code can solve the issue:
    if isinstance(y_true, pd.Series):
        y_reshaped = y_true.values.reshape((-1, 1))
    else:
        y_reshaped = y_true.reshape((-1, 1))

Additionally add test case for dataframe input.

so the problem is that predicton_error supports numpy arrays but not pandas.Series, right?
would calling .values on the series object to get the underlying numpy aray work? sounds simpler than the solution you're proposing


Absolute UTC datetime a play occured on

I couldn't find this is the docs.  Is it possible to get this info?

I'd really really like this too, but I don't see anywhere this is available. The closest solution is to pull tweet time-stamps from the play by play twitter account. Please let me know if you found a better way.


fix(select): fixed text when reselect the item,

user DOM manipulation to update it

💡 What is the current behavior?
Label is not visible if text is removed from input.

GitHub Issue Number: #1191
🆕 What is the new behavior?

Now the label is visible if the item selected

🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):

[X] 🦮 Accessibility (a11y) features were implemented
[X] 🗺 Internationalization (i18n) - no hard coded strings
[X] 📲 Responsiveness - components handle viewport changes and content overflow gracefully
[X] 📄 Documentation was reviewed/updated (pnpm run docs)
[X] 🧪 Unit tests were added/updated and pass (pnpm test)
[X] 📸 Visual regression tests were added/updated and pass (Guide)
[X] 🧐 Static code analysis passes (pnpm lint)
[X] 🏗 Successful compilation (pnpm build, changes pushed)

👨💻 Help & support

🙋♂ Please don't ignore the checklist of the pull request after you already checked the points. There is no testcase added.

Upon review, I identified a minor error. When the select component is utilized with the editable property set to true, the add field fails to reset.

Code:
<ix-select editable value="1">
  <ix-select-item label="Item 1" value="1"></ix-select-item>
  <ix-select-item label="Item 2" value="2"></ix-select-item>
  <ix-select-item label="Item 3" value="3"></ix-select-item>
  <ix-select-item label="Item 4" value="4"></ix-select-item>
</ix-select>

Upon review, I identified a minor error. When the select component is utilized with the editable property set to true, the add field fails to reset.

Code:
<ix-select editable value="1">
  <ix-select-item label="Item 1" value="1"></ix-select-item>
  <ix-select-item label="Item 2" value="2"></ix-select-item>
  <ix-select-item label="Item 3" value="3"></ix-select-item>
  <ix-select-item label="Item 4" value="4"></ix-select-item>
</ix-select>

Hi,
I don't quite understand the issue, after you click the outside it resets the input, If you select the new item also it is working as expected. can you please share the requirement ?

Hi @ridvandmrc
In the given example, the 'add' field (+ abc) does not reset. This issue only arises when the ix-select is used in 'editable'. The requirement for 'editable' is to add a new value by clicking the + {NEW VALUE} button, which appears when a novel value is entered. However, the current problem is that this field remains even if the value is reset by clicking outside. For instance, in the example above, the field + abc persists even after resetting to Item 4. In this case no 'add' field should be visible, since Item 4 is not a novel value.

Hi @ridvandmrc
In the given example, the 'add' field (+ abc) does not reset. This issue only arises when the ix-select is used in 'editable'. The requirement for 'editable' is to add a new value by clicking the + {NEW VALUE} button, which appears when a novel value is entered. However, the current problem is that this field remains even if the value is reset by clicking outside. For instance, in the example above, the field + abc persists even after resetting to Item 4. In this case no 'add' field should be visible, since Item 4 is not a novel value.

Hi,
I see, I have just updated the PR, you can check it again.

Thank you, it looks good! Nonetheless, could you please add one more test for the editable case.

Hi @jul-lam @danielleroux ,
New test cases are added related editable select .


Rewrite of alpha, digit, hex_digit, ...

Rewrite of alpha, digit, hex_digit, oct_digit, alphanumeric,
space and multispace.
This is cleaner and should be faster in most cases (except for
empty input, which should be neglectable) as this eliminates the
index check in the character check in every loop trip.
I also played around with iterators and position:
pub fn alpha<'a, T: ?Sized, S: AsChar>(input:&'a T) -> IResult<&'a T, &'a T> where
    T:Index<Range<usize>, Output=T>+Index<RangeFrom<usize>, Output=T>,
    &'a T: IntoIterator<Item=S> {
  match input.into_iter().position(|x: S| ! x.is_alpha()){
      Some(n) => { Done(&input[n..], &input[0..n]) }
      None => { Error(Position(ErrorKind::Alpha, input)) }
  }
}

This ultimatly lead to nothing. Probably I'm to inexperienced with macros and traits. I guessed I'll leave this here as someone else might be more clever than me and enlighten me...

Coverage increased (+3.1%) to 84.369% when pulling d903eec57591efa12d7a0263b3002903a3e932aa on tstorch:alpha_etc into ec2c5fe5f400810133d352ec7bbeddb8ce1aca87 on Geal:master.

Additionally some clever mind should probably figure out how to write a macro which could generate all these just by giving

the function name, e.g. alpha
the "filter", e.g. is_alpha
the Error type, e.g. ErrorKind::Alpha

@Geal Hey, what about this patch (I know its pretty late to ask this)? This is just a small rewrite of some very similar and small functions. The Coverage decreased since the code is more compact. Could you give me a hint, why this was not merged?
Currently git will fail merging it (I'm not quiet sure why), but I wanted to ask, if I should rebase this on master and resubmit the PR or if you didn't plan on merging this anyway.

@tstorch I have to rewrite those functions for nom 2.0 (#323), to use the new input traits, so most of that code will be gone anyway, sorry.
I know that you've spent a lot of time trying to improve nom, but i have to give the priority to my current plans, before I integrate your changes. I don't have a lot of bandwidth to review big pull requests these days.

the rewrite for alpha and others ended with commit 7ee5d15. This PR matched the old behaviour of returning error on empty input, but now it retursn an incomplete.


Feature request to clone/copy stream details

I've started to create multiple streams rather than editing the stream information manually everytime. I would just opt to create streams in Multistreamer and different profile in OBS and switch accordingly depending on the game im playing.
If its possible, I would like to request the option to clone a stream (which accounts are active, all the information, etc.) since that would make everything easier by just cloning and doing minor edits than putting all values again over and over.
Another way to approach this is to use templates (like how Switchboard Live Cloud does it) so its easier to switch what type you're streaming with a single configuration for RTMP/keys.

Just pushed up version 12.2.0, which has export/import buttons under the stream's "advanced" tab.

Saw the feature but I think due to the fact that im importing/cloning one stream config, its rejecting it probably due to duplicate names.
Im thinking, is there a way to "import from" an existing to automate the JSON export and then JSON import and just ignore the stream name value or something?
Not that important though would improve quality of life.

I've been considering discontinuing this project for some time now. I'm sorry I couldn't solve your issue, but I just don't enjoy working on multistreamer anymore.

I've been considering discontinuing this project for some time now. I'm sorry I couldn't solve your issue, but I just don't enjoy working on multistreamer anymore.


GH1058: Added second trigger for tools folder

Relates to #1058

@devlead if you let me know when you merge my other PR, I will get this one rebased as well.  Assuming you are happy with the change :smile:

@gep13 waiting for Travis, but looks good on AppVeyor logs 👍
[00:00:06] Restoring "src\packages"...
[00:00:20] OK
[00:00:20] Restoring "tools"...
[00:00:20] Skip restoring as one of the dependencies (build.cake,tools\packages.config) changed

@gep13 I've rebased and merged this with 2bcab52b645e27891e2e15ee398a0836046a8255


ISPN-5328 DummyTransaction does not invoke afterCompletion() if some res...

...ource fails to prepare
Also fixes:
ISPN-2813 DummyTransaction do not commit is last resource transaction is read-only
ISPN-4167 DummyBaseTransactionManager doesn't clean up when rollback fails
JIRA links:
https://issues.jboss.org/browse/ISPN-2813
https://issues.jboss.org/browse/ISPN-5328
https://issues.jboss.org/browse/ISPN-4167

Needs rebase

rebased!

Integrated


textInput pass 3 - adding some styling for background, fix cursor \n issue, and some more cleanup

Linking
related to #513
pass1 was #524, pass2 was #546

all the rest of this section of the pr description is the same as in the #524 / #546 prs

[ ] fix selection index is always zero
[x] consolidate input handling if possible (up/down cursor special case)
[x] handle new line wonkiness
[x] background color niceness for visual

Required to Merge

[ ] PASS - all necessary actions must pass (excluding the auto-skipped ones)
[x] TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
[x] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.

https://github.com/Volumetrics-io/mrjs/pull/578#issuecomment-2052704184

[x] TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
[ ] BREAKING CHANGE

DOCUMENTATION: This includes any changes to html tags and their components

make a pr in the documentation repo that updates the manual docs to match the breaking change
link the pr of the documentation repo here: #pr
that pr must be approved by @lobau

SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates

make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
link the pr of the landing page repo here: #pr
that pr must be approved by @hanbollar

pausing on this for a short bit

todos:

[ ] need good default options for the inputs
[ ] selection index might be a dangling issue after this pr

if all is good - then this is enough to re-expose this as a tag and in documentation repo with future issues created off of this for more work

if all is good - then this is enough to re-expose this as a tag and in documentation repo with future issues created off of this for more work

future niceties include:

[ ] text change if a password input
[ ] red outline as something people can toggle (troika has an easy outline feature)
[ ] css change for if the field is disabled
[ ] ...

https://github.com/Volumetrics-io/mrjs/assets/19628643/2a550fcd-f3e0-435f-9fcf-09bf254d9f7b

Still looking at the code but the cursor seems a little higher than it should be. Also did you test with other font sizes?

Still looking at the code but the cursor seems a little higher than it should be. Also did you test with other font sizes?

the cursor looks higher because im sort of faking the background height (the coloring one) to fit it decently with like a slight offset for niceties, but that nicety can probably be improved compared to the quick way im doing it - it matches the specific text location
and tested with other font sizes - it doesnt scale exactly as i want atm, but it does at least start at the right top and width position - was leaving that as a future noodle to not be a blocker on this one

Overall it's pretty solid. I don't think you're blocking anything ATM so try and make the Shadow DOM changes we discussed.
Some notes for what I think we need by v1:

[ ] select cursor position (blocked by click events I think)
[ ] Text selection
[ ] copy/paste
[ ] bonus: spell check

Accidental caps but just noticed that text doesn't stay in the textarea if you type too far.

Accidental caps but just noticed that text doesn't stay in the textarea if you type too far.

yupyup - one of the few task for this was to add in a scrolling offset - so that the number of lines are only limited to what can show up in the main area but the text can be handled properly, so i didnt make a change to limit the height of it based on text (we also cant do mask of a mask either, so that wouldnt hv been worth it)
if that's a blocker for this pr lmk, but i had added in the todos within the code as a task after this pr

No blocker but let's prioritize it on the next pass. Good work!


Git repos created for typos, causing 'zinit update' 404s

Describe the bug
Plugins/Snippets/etc create repos in .zinit/ by name. The name can be wrong due to typos or keyword errors in .zinitrc. But after fixing the error in .zinitrc, the repo remains. Then 'zinit update' generates 404 errors as it tries to update erroneous repos.
To Reproduce
Steps to reproduce the behavior.

Edit .zinitrc and add:
zinit wait lucid for OMZL::colored-man-pages

Restart zinit:
Setting up snippet           OMZL::colored-man-pages
Downloading `OMZL::colored-man-pages' (with curl, wget, lftp)...
curl: (22) The requested URL returned error: 404 Not Found
curl: (22) The requested URL returned error: 404 Not Found
ERROR: Download failed.

Ok, that was wrong. It's a plugin. Edit .zinitrc and change to:
zinit wait lucid for OMZP::plugins/colored-man-pages

Restart zinit:
Snippet not loaded (OMZP::plugins/colored-man-pages)

Oh, that was also wrong. Don't need the 'plugin/' directory. Edit .zinitrc and change to:
zinit wait lucid for OMZP::colored-man-pages

Restart zinit:

Setting up snippet           OMZP::colored-man-pages
Downloading `OMZP::colored-man-pages' (with curl, wget, lftp)...
######################################################################## 100.0%

Success. Now try updating.
$ zinit update
...
Updating snippet OMZ::plugins/colored-man-pages
Downloading OMZ::plugins/colored-man-pages' (with curl, wget, lftp)... ##################################################################################################################################### 100.0% ... Updating snippet OMZL::colored-man-pages Downloading OMZL::colored-man-pages' (with curl, wget, lftp)...
curl: (22) The requested URL returned error: 404 Not Found
curl: (22) The requested URL returned error: 404 Not Found
ERROR: Download failed.
...
Updating snippet OMZP::colored-man-pages
Downloading OMZP::colored-man-pages' (with curl, wget, lftp)... ##################################################################################################################################### 100.0% ... Updating snippet OMZP::plugins/colored-man-pages Downloading OMZP::plugins/colored-man-pages' (with curl, wget, lftp)...
curl: (22) The requested URL returned error: 404 Not Found
curl: (22) The requested URL returned error: 404 Not Found
ERROR: Download failed.

Whoa. Two problems:
• It updated OMZP::colored-man-pages twice! Once as 'OMZP::colored-man-pages' and once as 'OMZ::plugins/colored-man-pages'
• It update the two repos based on wrong names, 'OMZL::colored-man-pages' and 'OMZP::plugins/colored-man-pages', failing both times.

Expected behavior
• Zinit should not create repos for typos or other errors.
• Zinit should not include erroneous repos when updating
Versions:

$ZSH_VERSION == .5.8
Operating system name and version (uname -a): Darwin Kernel Version 19.5.0

Notes:
• A related problem is that the git repos aren't culled when they're no longer used in the .initrc. Users will see monotonically growing update times as obsolete, unused git repos continue to be updated.
• It appears that a simple way to resync the repos to the correct set is to just delete the directories under .zinit/plugins. The repos matching the current .zshrc, without the extras, will be redownloaded the next time zinit starts.

• The same problem occurs for OMZL libraries. In my .zshrc file, I have:
    zinit wait lucid for OMZL::directories.zsh

In the $ zinit update output, I see:
Updating snippet OMZ::directories.zsh
Downloading `OMZ::directories.zsh' (with curl, wget, lftp)...
curl: (22) The requested URL returned error: 404 Not Found
curl: (22) The requested URL returned error: 404 Not Found
ERROR: Download failed.
...
Updating snippet OMZL::directories.zsh
Downloading `OMZL::directories.zsh' (with curl, wget, lftp)...
##################################################################################################################################### 100.0%

So a fail with one variation of the name, OMZ::directories.zsh', then a success with another, OMZL::directories.zsh.

Where are the repos for the OMZ* plugins stored?

The snippets are stored in ~/.zinit/snippets. The issue is now resolved for them. PS. You can delete any snippet by zi delete {id}.

Success! Thanks, Sebastian.
Re OMZ* snippets, I see. They're not git repos. This explains why I see them downloaded each time I do a zi update.


How to Determine RAM Consumption Performance Issues?

Type: Performance Issue
My machine says there's two processes using up 15GB each of RAM, yet when I open the VSCode Process Explorer it shows there's barely any RAM being consumed. I've checked through the "Performance Issues" article but it mentions nothing about RAM/memory. via: https://github.com/Microsoft/vscode/wiki/Performance-Issues
I was hoping to determine the source of the issue before restarting and losing it.

VS Code version: Code 1.81.1 (Universal) (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:20:33.924Z)
OS version: Darwin arm64 22.3.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
10, 9, 9

Memory (System)
16.00GB (0.03GB free)

Process Argv
--crash-reporter-id 70026821-dffa-44d0-829d-9cbf64e429ea

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   31	   147	 99223	code main
    8	    66	 99229	   gpu-process
    0	    16	 99230	   utility-network-service
   36	    98	 99309	shared-process
    0	    16	 99312	ptyHost
    0	     0	  1722	     /bin/zsh -il
    0	     0	  1882	       zsh ./start.sh
    0	     0	  1883	         mdbook serve --open --port 8088
    0	     0	  3652	     /bin/zsh -il
  115	     0	 99315	extensionHost [3]
  113	     0	 99320	extensionHost [7]
    0	     0	 99962	     <defunct>

Workspace Info
|  Window (some-file.ts — some-api)
|  Window (readme.md — some-book)
|    Folder (some-api): 5947 files
|      File types: ts(1946) map(1512) js(763) html(642) sql(149) json(20)
|                  graphql(20) zsh(13) log(12) yaml(8)
|      Conf files: package.json(3) github-actions(2) dockerfile(2)
|                  tsconfig.json(2) launch.json(1) settings.json(1)
|      Launch Configs: node(4)
|    Folder (some-book): 514 files
|      File types: png(148) md(88) html(86) msd(30) jpg(26) woff2(12) js(11)
|                  DS_Store(10) css(9) json(2)
|      Conf files: settings.json(1);

Extensions (99)

Extension
Author (truncated)
Version

terraform
4op
0.2.5

better-comments
aar
3.0.2

vscode-javascript-repl
ach
0.7.4

commit-message-editor
ada
0.25.0

vscode-sql-formatter
adp
1.4.4

vscode-css-formatter
aes
1.0.2

project-manager
ale
12.7.0

jest-snippets
and
1.9.1

tailwind-docs
aus
2.1.0

markdown-preview-github-styles
bie
2.0.2

vscode-intelephense-client
bme
1.9.5

vscode-tailwindcss
bra
0.9.12

phpserver
bra
3.0.2

vscode-opennewinstance
chr
0.0.12

path-intellisense
chr
2.8.4

vscode-css-modules
cli
0.5.1

gitignore
cod
0.9.0

dart-code
Dar
3.70.0

flutter
Dar
3.70.0

vscode-eslint
dba
2.4.2

githistory
don
0.6.20

gitlens
eam
14.2.1

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.1.0

figma-vscode-extension
fig
0.2.7

html-slim-scss-css-class-completion
gen
1.7.8

copilot
Git
1.103.338

vscode-github-actions
git
0.26.1

vscode-pull-request-github
Git
0.70.0

live-sass
gle
6.1.0

gc-excelviewer
Gra
4.2.58

vscode-graphql
Gra
0.8.17

vscode-graphql-execution
Gra
0.2.4

vscode-graphql-syntax
Gra
1.2.2

todo-tree
Gru
0.0.226

terraform
has
2.27.1

vscode-git-tags
how
1.4.4

dart-data-class-generator
hzg
0.5.4

reg
ion
1.1.0

vscode-env
Iro
0.1.0

vscode-edit-csv
jan
0.8.1

hungry-delete
jas
1.7.0

svg
joc
1.5.3

workspace-terminals
jos
0.3.2

blockman
leo
1.7.5

flutter-intl
loc
1.19.3

go-to-spec
Lou
0.1.3

call-graph
Luo
1.1.2

rainbow-csv
mec
3.7.0

vscode-language-babel
mgm
0.0.39

git-graph
mhu
1.30.0

dotenv
mik
1.0.1

vscode-scss
mrm
0.10.0

vscode-docker
ms-
1.26.0

remote-ssh
ms-
0.102.0

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.81.0

live-server
ms-
0.4.9

remote-explorer
ms-
0.4.1

test-adapter-converter
ms-
0.1.8

vsliveshare
ms-
1.0.5877

vsliveshare-pack
ms-
0.4.0

sqltools
mtx
0.28.0

php-docblocker
nei
2.7.0

vscode-auto-restart-typescript-eslint-servers
neo
0.0.5

gremlins
nho
0.26.0

react-proptypes-intellisense
OfH
1.0.3

docthis
oou
0.8.2

vscode-jest
Ort
5.2.3

vscode-versionlens
pfl
1.5.0

excalidraw-editor
pom
3.5.1

prisma
Pri
5.1.0

vscode-thunder-client
ran
2.10.2

vscode-rapidapi-client
Rap
1.10.2

vscode-services
rap
1.0.2

typescript-hero
rbb
3.0.0

vscode-xml
red
0.26.1

vscode-yaml
red
1.14.0

LiveServer
rit
5.7.9

flutter-riverpod-snippets
rob
1.2.2

vscode-coverage-gutters
rya
2.11.0

vscode-scss-formatter
sib
3.0.0

cody-ai
sou
0.6.7

code-spell-checker
str
2.20.5

vscode-stylelint
sty
1.2.4

svelte-vscode
sve
107.10.0

sass-indented
syl
1.8.27

vscode-open-in-github
sys
1.17.2

even-better-toml
tam
0.19.2

vscode-status-bar-format-toggle
tom
3.1.1

errorlens
use
3.13.0

vscode-icons
vsc
12.5.0

volar
Vue
1.8.8

vscode-todo-highlight
way
1.0.5

change-case
wma
1.0.0

pretty-ts-errors
yoa
0.5.1

markdown-pdf
yza
1.4.4

markdown-all-in-one
yzh
3.5.1

php-intellisense
zob
1.3.2

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30792226
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
282f8724:30602487
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
gsofa:30804715
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
dsvsc013:30795093
dsvsc014:30804076

The PIDs say that they're extension hosts, so the problem is one or more of your 99 (🤯) extensions. You'll want to use the extension bisect explained in https://github.com/Microsoft/vscode/wiki/Performance-Issues#run-with-extensions-disabled to diagnose this.

If this is an intermittent issue I do not have time to bisect extensions over days, or hope that this issue arises again, there must be a way to check what plugin/extension is causing this, or at least limit it down to some subset of extensions. It hasn't come back since restarting VSCode & my system.
It just seems odd to me that the process explorer shows I'm barely utilizing anything. That seems irrepresentative of the reality that something related to VSCode is using up plenty of RAM.
I understand that tracking down RAM consumption can be problematic to pinpoint when it's potentially shared memory, but it seems that documentation doesn't explain how to track it down.
Maybe this should be a feature request then?
I imagine this isn't impossible given that Chrome has a way to expose extension resource consumption in its task manager. I know it's obviously not the same code, but I figured they're both likely electron based or must be built upon some of the same fundamentals/infrastructure.

The memory not showing up is a bug, but it's pretty low priority as the built-in process manager is primary a tool for the team https://github.com/microsoft/vscode/issues/190687
Unfortunately the fastest way to check which extension is the problem is via the extension bisect since all extensions share a single extension host and we cannot measure which extension is taking up how much memory/cpu.

Thanks for the explanation and opening up a new ticket 👍


Switching Between Extended and Direct Requires steamvr.vrsettings Deletion

Hey Guys,
Having a bit of an issue with the OSVR/SteamVR driver when it comes to switching from Extended to Direct and vice versa.
I've been having to switch between Extended and Direct to try out a couple of applications and I now can't seem to get it working again and will most likely have to reinstall drivers if I can't figure out a method to get Direct Mode working again.
The previous workaround was to delete steamvr.vrsettings, disable Direct Mode, power cycle and restart, start server, start SteamVR, switch to Direct Mode, powercycle and restart and then things would work. Unfortunately, I can't seem to get this method working again...
Not sure what kind of info I can provide to help find a fix, but just let me know what you need to know and I'll get back to you asap.
NVidia Driver 368.39
Latest SteamVR Driver
EDIT: Figured out what was stopping the OSVR from connecting altogether, and it was that the OSVR wasn't positioned at 0 on the Y axis (aligned to the top of) beside my main monitor when in extended mode.

Sorry guys, it appears after further testing that a restart was needed after switching modes.
I'd tried restarting before and it wasn't working. I'm not sure what I was doing wrong before, but everything seems fine now after a restart.

So there is no need to delete steamvr.vrsettings as described in your latest steamvr-osvr driver video tutorial?


Why the refined results are worse than coarse results?

Hi, Thank you very much for your great work!
I am testing your pretrained model on the  example images you provided, but with the resolution of 256x256 (the original size is 512 but i want to test on 256). Here is my args:
python test.py --name celeba --img_file ./examples/celeba/img/ --mask_file ./examples/celeba/mask/ --results_dir ./results --model tc --coarse_or_refine refine --gpu_id 0 --no_shuffle --batch_size 1 --preprocess scale_shortside --mask_type 3 --load_size 256 --fine_size 256 --attn_G --add_noise
And here is the output results (all the images below are 256x256):

These are just 2 examples. I didnt modify any part of the code, I wonder why the refined results are worse than coarse results? Did I use the wrong args? I would be grateful if you can reply to my question, thanks in advance :)

Hi @Yang-Shiyuan Thanks for pointing out this issue. I have not tested the model on 256256 resolution. As our refined model is trained on 512512, the attention-aware layer is tamed on high-resolution features, which do not feed with 256256 images. Therefore, the refined model may perform worse on that resolution. You can directly evaluate the model on 512512 and then downsample the refined results to 256*256 resolution.

@lyndonzheng  Thank you for your swift reply！Yes I have also noticed the implementation details in your paper, the refined model is trained on 512x512 images, so working on 512-size should yield much more resonable results. Thank you again for your suggestions :)


i have successfully redesigned the Plantrip page, ensuring it is both responsive and visually appealing. The new layout adapts seamlessly to different screen sizes, providing an optimal user experience on desktops, tablets, and smartphones. Enhanced visual elements and intuitive navigation contribute to a cleaner, more user-friendly interface.

Solved the issue #415

Describe your changes

Issue ticket number and link

Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics?
[ ] Will this be part of a product update? If yes, please write one phrase about this update.

@apu52  now check the PR is fine or should I update it.


Dust phantom burning

-Light dust
-press undo
-its still lit even if you press undo alot of times

Copy of #55

Can you give more detailed instructions? I tried to recreate this and It doesn't happen any more

you have to use a large amount of dust, at least the max pen size times 4

oh yeah and the dust has to be cloning by cloner

I can reproduce this with just a cloner + dust, doesn't seem to require a certain amount of it:

Create a cloner line
apply dust to cloner line
add whatever other elements around to build up some undo steps
set fire to dust
undo [and repeat]

The dust keeps exploding right after each undo. Regardless of where you started the fire initially, the explosion after undo seems to emanate from the cloner line.

why does cloner cause this? I tested it with wall too, (cloner and wall both block wind) but wall+dust doesn't cause it


Handle 404 on docs with vue-router

When reaching an unknown path, we can display a 404 page or redirect to homepage /#.

I got this

Fixed with #47


Update RolesTypeEnum according to the open api

https://github.com/nemtech/nem2-openapi/pull/69

Job done


Modularization helper

As a developer, I want a way to include resource files and be notified when it has been loaded and evaluated
Acceptance criteria:

The api is named gpf.require.define, it accepts up to two parameters: a dictionary specifying the dependant resources and a factory function. The optional result of the factory function is associated to the resource file so that if the resource is required a second time, this result is recalled.
The api must a return a promise that is resolved (to the result of the factory function if any) on success or rejected if the require fails
Resources are referenced using their relative path. A root can be define through the API gpf.require.configure that is used for the first gpf.require call.
JSON resources must be evaluated to their parsed result.
A JavaScript resource may respect one of the following formats:

Use of require and module.exports from CommonJS. The resource is associated with the value assigned to module.exports.
Use of AMD's define operator. The resource is associated with the result value of the factory function.
Use of gpf.require. The resource is associated with the result value of the factory function.
None of the three formats above, no association will be made to the resource.

First version of documentation finalized.


Hue Says Unreachable HomeKit Says All Good

I added some Innr outlets to Hue hub.  Works great.  Sometimes though, the Hue app will say unreachable, but HomeKit things all is good.  Is it possible for the plugin to read the status of the device in Hue as unreachable and then to set to Not Responding in HomeKit.  Otherwise, it gives a false sense of security in thinking the device is on or off.  Thanks.

Possible, though not advised, see https://github.com/ebaauw/homebridge-hue/wiki/No-Response.


Improve installation instructions

Hey! I'm having a little trouble integrating with beta 9 (upgrading from a much older version, so it may not be a beta 9 specific issue).
Currently, Carthage is telling me the PINRemoteImage wants these things:
*** Checking out libwebp at "v0.5.1"
*** Checking out PINOperation at "1.0.3"
*** Downloading PINCache.framework binary at "3.0.1 Beta 4"
*** Downloading PINRemoteImage.framework binary at "Beta 9: Support for resuming downloads, faster operation queue"
*** xcodebuild output can be found in /var/folders/dz/30qkdl_13rb525_f_d70g3mr0000gn/T/carthage-xcodebuild.RL1rde.log
*** Building scheme "PINOperation" in PINOperation.xcodeproj
*** Building scheme "iOS" in PINCache.xcodeproj
*** Building scheme "PINRemoteImage" in PINRemoteImage.xcodeproj

I've integrated all 3 frameworks into my target (added to linked libraries & carthage copy-frameworks), but I'm getting a runtime error on launch, saying
dyld: Symbol not found: _PINDiskCachePrefix
  Referenced from: /Users/asb/Library/Developer/CoreSimulator/Devices/77E331CB-1C32-45DF-A704-0F665702520E/data/Containers/Bundle/Application/8FD99541-2F2F-4C63-A5BE-BAC7071F2965/wrytr.app/Frameworks/PINRemoteImage.framework/PINRemoteImage
  Expected in: /Users/asb/Library/Developer/CoreSimulator/Devices/77E331CB-1C32-45DF-A704-0F665702520E/data/Containers/Bundle/Application/8FD99541-2F2F-4C63-A5BE-BAC7071F2965/wrytr.app/Frameworks/PINCache.framework/PINCache
 in /Users/asb/Library/Developer/CoreSimulator/Devices/77E331CB-1C32-45DF-A704-0F665702520E/data/Containers/Bundle/Application/8FD99541-2F2F-4C63-A5BE-BAC7071F2965/wrytr.app/Frameworks/PINRemoteImage.framework/PINRemoteImage

and I'm not sure where it's coming from. Also, do I need to do anything with libwebp, or is that handled for me?
Any ideas why dyld cant find _PINDiskCachePrefix? I grepped and found the symbol PINCache, but I'm (almost completely) sure I've integrated PINCache correctly, so I'm not sure where the complaint is coming from.

libwebp is linked into PINRemoteImage automatically if you're using carthage.
I'm not sure why you're getting a runtime error, can you upload a sample project?

Yup! I'll try to repro today
On Wed, May 24, 2017 at 10:26 AM Garrett Moon<EMAIL_ADDRESS>wrote:

libwebp is linked into PINRemoteImage automatically if you're using
carthage.
I'm not sure why you're getting a runtime error, can you upload a sample
project?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/PINRemoteImage/issues/363#issuecomment-303794163,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo1dJsngihxknfcyAqt2vHn3LgygJJtks5r9Gg5gaJpZM4NkcTK
.

Hmm, so it seems like my Carthage setup is just super weird for the one project I'm working on. Anytime I run carthage update, it fails, but if I run carthage build --no-skip-current from inside pinterest/PINRemoteImage, and drag those binaries over to my project's Carthage/Build/iOS, it works for me.
The only difference is that when I build pinterest/PINRemoteImage I'm building the head, instead of 3.0.0-beta.9 in my project.
I'll try with pinterest/PINRemoteImage master soon

Ok, I'm going to close this for now, but report back and I'll re-open if necessary.

I have this issue also: dyld: Symbol not found: _PINDiskCachePrefix
I have included PINCache, PINOperation and PINRemoteImage correctly as normal too, a fresh checkout of my app and running carthage update gives me that missing symbol error when trying to run the app.

My fix was to clone PINRemoteImage and do a carthage build --no-skip....
Then drag the built stuff into my project
Good to see that this wasn't just a my-machine sort of problem, I feel as
if there's some weirdness with the exact checkout versions being built
On Thu, Jun 22, 2017 at 1:40 AM Robin Hayward<EMAIL_ADDRESS>wrote:

I have this issue also: dyld: Symbol not found: _PINDiskCachePrefix
I have included PINCache, PINOperation and PINRemoteImage correctly as
normal too, a fresh checkout of my app and running carthage update gives
me that missing symbol error when trying to run the app.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/PINRemoteImage/issues/363#issuecomment-310315474,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo1dKUE5CUqG1bL7u_jOx2pI28WuW-5ks5sGih8gaJpZM4NkcTK
.

Yea thanks very much for sharing, that did also work for me.
Related: PINRemoteImage is still awesome :)

PINRemoteImage is definitely still awesome


Drag and Drop feature

Is there any drag drop feature available for this plugin? or any way to integrate with other drag drop plugin?

Hello! I like this plugin but the drag and drop also missing for me. Is there any way to implement?

Do you guys mean drag and drop files outside the browser (ie.: from file explorer) into a defined area?  Like this? http://stackoverflow.com/questions/8006715/drag-drop-files-into-standard-html-file-input

Or this:
http://updates.html5rocks.com/2012/07/Drag-and-drop-a-folder-onto-Chrome-now-available

Or even better, this: http://stackoverflow.com/questions/2657653/drag-and-drop-file-upload-in-google-chrome-chromium-and-safari


Fix undefined symbol errors when rustup defaults to nightly rust

Description of changes:
The additions should be self-documenting. I deliberately want to be vague here so the PR reviewer understands just from the comments.
Resolved issues:

Resolves #1709

Call-outs:
This is exceptionally difficult to test. I haven't yet added a test case to this PR, and should before merging.
I think it'll have to be part of the "smoke tests" we run with with docker in CI, since we need to actually be running the cargo-kani proxy binary, which we don't run in dev.
Testing:

How is this change tested? manually for now, with unit tests for the filter

Is this a refactor change? no

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Please don't be vague in the description.

Updated description with the same text as the code, so as not to be vague on the pull request.

A test is now included.
Unfortunately this issue is near-impossible to test reliably: We move our rust toolchain every couple of weeks, and the issue only manifests with certain combinations of toolchain versions (where symbols are different, but library hashes are not).
Consequently, if this code/workaround is broken, we may be unable to observe that breaking immediately through this test failing, and it may not be until a few days or pull requests later when a new nightly version that does manifest the problem appears.
I can't think of any better way to test it, however.

Wouldn't it make sense to set RUSTUP_TOOLCHAIN env variable to ensure all calls are directed to the correct toolchain instead?

Hmm. Part of the trouble is that the cargo-kani proxy doesn't locally know what the correct toolchain is. But perhaps kani-driver can do that.

Ah but I'm slightly worried about the future when we invoke kani-compiler directly from kani-driver. There wouldn't be an intervening rustup invocation to reset environment variables again.

Sorry if I wasn't clear. I think you should set that variable inside the proxy before invoking kani-driver. I.e., in the exact same place that you are currently editing LD_LIBRARY_PATH. The proxy is already responsible for setting up the execution environment.
BTW, how did you manually test the fix?

I can look into adding RUST_TOOLCHAIN, it might be an improvement in its own right. But I still think we need to directly do something ourselves about LD_LIBRARY_PATH.
Setting RUST_TOOLCHAIN does not directly fix the problem. We'd be depending on a subsequent invocation of the rustup proxy to then prepend the correct paths to LD_LIBRARY_PATH.
So, if we just updated RUST_TOOLCHAIN as-is, we'd have to remove the code adding the toolchain to PATH (which, sure, maybe we should) because currently we're directly invoking cargo (not via rustup), so LD_LIBRARY_PATH would not be fixed. Removing the toolchain from PATH would mean we invoke a rustup proxy (for cargo) on the way to running kani-compiler, and so things would then work... for now.
But again, if we don't directly fix LD_LIBRARY_PATH, it leaves us (e.g. kani-driver) in a broken environmental state where we're no longer able to directly run kani-compiler, and that doesn't seem acceptable to me.

New commit:

Fix errant pub
Set RUSTUP_TOOLCHAIN
Remove the toolchain from PATH (so we're now relying on RUSTUP_TOOLCHAIN to select the right one instead)

Btw, I think adding the correct path to the beginning of LD_LIBRARY_PATH seems like a much less hacky and reliable way to fix this.

Do you want that change made or is merging fine? In some sense, we're sort of also doing that, since we set the environment variable and call the rustup proxy now for cargo now.
FWIW, while I agree trying to recognize them and remove this is a bit of a hack, I personally think rustup adding them in the first place is a bigger hack, and trying to clean up and remove them, well... it's a hack trying to undo damage from another hack? Oof.

Not a blocker that's why I approved it. Thanks Ted


(react) - Fetching state is not turning to 'true' while reexecuting a query

In our react app we updated urql to 2.0.10. We found out that the fetching state is not turning to true while reexecuting a query.
urql version & exchanges:
higher than 2.0.6
Steps to reproduce

Create a React useQuery hook (doesn't matter if it is paused or not).
Call the reexecuteQuery function (in 'network-only' mode) returned from the useQuery hook.

Expected behavior
The fetching state (in the result from the useQuery ) turns to true while calling the reexecuteQuery, than to false after the query is finished.
Actual behavior
The fetching state filps to true only the first time we calling the query, but never again, it remains false.

https://codesandbox.io/s/urql-reexecute-query-fetching-state-issue-egw2et?file=/src/Foo.jsx

I am still getting this exact problem on urql version: 3.0.3..
I am re executing a query with 'network-only' and fetching does not flip to 'true'..
I have been following the docs here and here which suggests that fetching should become true whilst the reexecution is happening.
However, I noticed that these docs are now deprecated but I cannot for the life of me find the suggested TSDocs in my editor!
@JoviDeCroock Please could you let me know exactly what I am missing? Thanks


make sure all cohort attributes will be available if reconnecting

If we reconnect to a database we should still have all the cohort attributes
library(omopgenerics)
#>
#> Attaching package: 'omopgenerics'
#> The following object is masked from 'package:stats':
#>
#>     filter
library(CDMConnector)
#>
#> Attaching package: 'CDMConnector'
#> The following objects are masked from 'package:omopgenerics':
#>
#>     cdmName, recordCohortAttrition, uniqueTableName
library(CohortConstructor)
#>
#> Attaching package: 'CohortConstructor'
#> The following objects are masked from 'package:CDMConnector':
#>
#>     intersectCohorts, unionCohorts

cdm <- mockCohortConstructor(nPerson = 10,
                             conditionOccurrence = TRUE)
con <- cdmCon(cdm)
cdm$cohort <- conceptCohort(cdm,
                            list(a = 1),
                            name = "cohort") |>
  requireAge(c(0,50))
#> ℹ Subsetting table condition_occurrence using 1 concept with domain: condition.
#> ℹ Collapsing records.
#> ℹ Creating cohort attributes.
#> ✔ Cohort cohort created.
attrition(cdm$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>
cohortCodelist(cdm$cohort, 1)
#>
#> ── 1 codelist ──────────────────────────────────────────────────────────────────
#>
#> - a (1 codes)

cdm_2 <- cdm_from_con(con, "main", "main",
                      cohort_tables = "cohort")
attrition(cdm_2$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>
cohortCodelist(cdm_2$cohort, 1)
#> Warning: No codelists found for the specified cohorts
#>
#> ── 0 codelists ─────────────────────────────────────────────────────────────────

Created on 2024-05-23 with reprex v2.1.0

@edward-burn  This is something we have to check, but probably CDMConnector is not reading the attributes:
library(omopgenerics)
#>
#> Attaching package: 'omopgenerics'
#> The following object is masked from 'package:stats':
#>
#>     filter
library(CDMConnector)
#>
#> Attaching package: 'CDMConnector'
#> The following objects are masked from 'package:omopgenerics':
#>
#>     cdmName, recordCohortAttrition, uniqueTableName
library(CohortConstructor)
#>
#> Attaching package: 'CohortConstructor'
#> The following objects are masked from 'package:CDMConnector':
#>
#>     intersectCohorts, unionCohorts

cdm <- mockCohortConstructor(nPerson = 10,
                             conditionOccurrence = TRUE)
#> ■■■■■■■■■■■■■■■■■■■■■■■■■ 80% | ETA: 1s
#>
con <- cdmCon(cdm)
cdm$cohort <- conceptCohort(cdm,
                            list(a = 1),
                            name = "cohort") |>
  requireAge(c(0,50))
#> ℹ Subsetting table condition_occurrence using 1 concept with domain: condition.
#> ℹ Collapsing records.
#> ℹ Creating cohort attributes.
#> ✔ Cohort cohort created.

attrition(cdm$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>
cohortCodelist(cdm$cohort, 1)
#>
#> ── 1 codelist ──────────────────────────────────────────────────────────────────
#>
#> - a (1 codes)

cdm_2 <- cdm_from_con(con, "main", "main",
                      cohort_tables = "cohort")
attrition(cdm_2$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>
cohortCodelist(cdm_2$cohort, 1)
#> Warning: No codelists found for the specified cohorts
#>
#> ── 0 codelists ─────────────────────────────────────────────────────────────────

listTables(con, schema = "main")
#>  [1] "cdm_source"           "cohort"               "cohort1"
#>  [4] "cohort1_attrition"    "cohort1_codelist"     "cohort1_set"
#>  [7] "cohort2"              "cohort2_attrition"    "cohort2_codelist"
#> [10] "cohort2_set"          "cohort_attrition"     "cohort_codelist"
#> [13] "cohort_set"           "concept"              "concept_ancestor"
#> [16] "concept_relationship" "concept_synonym"      "condition_occurrence"
#> [19] "drug_strength"        "observation_period"   "person"
#> [22] "vocabulary"           "og_002_1716543886"    "og_003_1716543886"
#> [25] "og_004_1716543886"    "og_005_1716543887"    "og_008_1716543893"

Created on 2024-05-24 with reprex v2.1.0

Reprocucing the bug, cohortcodelist was available when reconnecting
library(omopgenerics)
#>
#> Attaching package: 'omopgenerics'
#> The following object is masked from 'package:stats':
#>
#>     filter
library(CDMConnector)
#>
#> Attaching package: 'CDMConnector'
#> The following objects are masked from 'package:omopgenerics':
#>
#>     cdmName, recordCohortAttrition, uniqueTableName
library(CohortConstructor)
#>
#> Attaching package: 'CohortConstructor'
#> The following objects are masked from 'package:CDMConnector':
#>
#>     intersectCohorts, unionCohorts

cdm <- mockCohortConstructor(nPerson = 10,
                             conditionOccurrence = TRUE)
#> Note: method with signature 'DBIConnection#Id' chosen for function 'dbExistsTable',
#>  target signature 'duckdb_connection#Id'.
#>  "duckdb_connection#ANY" would also be valid
#> Warning: ! 6 casted columns in person as do not match expected column type:
#> • `gender_concept_id` from numeric to integer
#> • `year_of_birth` from numeric to integer
#> • `month_of_birth` from numeric to integer
#> • `day_of_birth` from numeric to integer
#> • `race_concept_id` from logical to integer
#> • `ethnicity_concept_id` from logical to integer
#> Warning: ! 1 casted column in observation_period as do not match expected column type:
#> • `period_type_concept_id` from logical to integer
#> ■■■■■■■■■■■■■■■■■■■■■■■■■ 80% | ETA: 1s
#>
con <- cdmCon(cdm)
cdm$cohort <- conceptCohort(cdm,
                            list(a = 1),
                            name = "cohort") |>
  requireAge(c(0,50))
#> ℹ Subsetting table condition_occurrence using 1 concept with domain: condition.
#> ℹ Combining tables.
#> ℹ Collapsing records.
#> ℹ Creating cohort attributes.
#> ✔ Cohort cohort created.

attrition(cdm$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>

cohortCodelist(cdm$cohort, 1)
#>
#> ── 1 codelist ──────────────────────────────────────────────────────────────────
#>
#> - a (1 codes)

cdm_2 <- cdm_from_con(con, "main", "main",
                      cohort_tables = "cohort")
#> Warning: ! 6 casted columns in person as do not match expected column type:
#> • `gender_concept_id` from numeric to integer
#> • `year_of_birth` from numeric to integer
#> • `month_of_birth` from numeric to integer
#> • `day_of_birth` from numeric to integer
#> • `race_concept_id` from logical to integer
#> • `ethnicity_concept_id` from logical to integer
#> ! 1 casted column in observation_period as do not match expected column type:
#> • `period_type_concept_id` from logical to integer
#> Warning: ! 2 casted columns in condition_occurrence as do not match expected column
#>   type:
#> • `condition_concept_id` from numeric to integer
#> • `condition_type_concept_id` from numeric to integer
#> Warning: ! 9 casted columns in cdm_source as do not match expected column type:
#> • `cdm_source_abbreviation` from logical to character
#> • `cdm_holder` from logical to character
#> • `source_description` from logical to character
#> • `source_documentation_reference` from logical to character
#> • `cdm_etl_reference` from logical to character
#> • `source_release_date` from logical to date
#> • `cdm_release_date` from logical to date
#> • `cdm_version` from numeric to character
#> • `vocabulary_version` from logical to character
#> Warning: ! 3 casted columns in concept as do not match expected column type:
#> • `concept_id` from numeric to integer
#> • `valid_start_date` from character to date
#> • `valid_end_date` from character to date
#> Warning: ! 1 casted column in vocabulary as do not match expected column type:
#> • `vocabulary_concept_id` from numeric to integer
#> Warning: ! 5 casted columns in concept_relationship as do not match expected column
#>   type:
#> • `concept_id_1` from numeric to integer
#> • `concept_id_2` from numeric to integer
#> • `valid_start_date` from logical to date
#> • `valid_end_date` from logical to date
#> • `invalid_reason` from logical to character
#> Warning: ! 2 casted columns in concept_synonym as do not match expected column type:
#> • `concept_id` from numeric to integer
#> • `language_concept_id` from numeric to integer
#> Warning: ! 4 casted columns in concept_ancestor as do not match expected column type:
#> • `ancestor_concept_id` from numeric to integer
#> • `descendant_concept_id` from numeric to integer
#> • `min_levels_of_separation` from numeric to integer
#> • `max_levels_of_separation` from numeric to integer
#> Warning: ! 9 casted columns in drug_strength as do not match expected column type:
#> • `drug_concept_id` from numeric to integer
#> • `ingredient_concept_id` from numeric to integer
#> • `amount_value` from logical to numeric
#> • `amount_unit_concept_id` from numeric to integer
#> • `numerator_unit_concept_id` from numeric to integer
#> • `denominator_unit_concept_id` from numeric to integer
#> • `box_size` from logical to integer
#> • `valid_start_date` from logical to date
#> • `valid_end_date` from logical to date
attrition(cdm_2$cohort)
#> # A tibble: 2 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason
#>                  <int>          <int>           <int>     <int> <chr>
#> 1                    1              7               7         1 Initial qualify…
#> 2                    1              7               7         2 Age requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>
cohortCodelist(cdm_2$cohort, 1)
#>
#> ── 1 codelist ──────────────────────────────────────────────────────────────────
#>
#> - a (1 codes)

Created on 2024-07-29 with reprex v2.1.1


Fix bug where coverage is not collected #632

This fixes the bug discussed in #632 where coverage is not being collected correctly when using collectCoverage.
@cyjia tracked down the cause in #632.  The onlyCollectFrom variable is an object, so !onlyCollectFrom always returns false instead of the intent of testing if the collectCoverageOnlyFrom configuration option is being used.

Wait, this is weird. When do you get an object instead of undefined? It should only be an object when the option is explicitly provided in your config. If it isn't provided, it should be undefined.

Should be fixed by #599. Thanks for your contribution.

I'm calling from a gulp task with...
jest.runCLI({}, __dirname, onComplete);
and
"collectCoverage": true,
In my package.json, with no collectCoverageOnlyFrom specified. The onlyCollectFrom variable then holds an empty object.

Ah, It looks like there was code in the test runner which assigned the object value.
https://github.com/facebook/jest/blob/0.8.2/src/TestRunner.js#L249
It looks like that is gone from the current master version of TestRunner.js.
Thanks.

You can try jest-cli@next and see if that fixes your issue. It'll also make your test runs 2-4x faster :)


[Sozialpass] Add multiple cards

As a user I want to be able to add multiple id cards to my device
Acceptance Criteria:

until 5 id cards can be added
each card can be deleted separately
it should be possible to navigate between cards and verify each of them

Technical Tasks:

add a button to delete a card
add a view where you swipe our navigate between multiple cards
adding a new card should not override an old card (as it is now)
each card should be verified when the app starts (self verification)
if 5 cards are already activated show an alert if the user wants to add another card instead of opening the camera
check if the same card was already added and show an alert

Small draft for the swipe area was added (has not to be used for design)

blocked by #1085


[Bug]: Search bar cursor control is broken with physical keyboard

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
Internal user reported several issues with moving the cursor in the search bar while using a physical keyboard.

[ ] Left key moves focus to the back arrow icon button. (Right key seems to work fine.)
[ ] Ctrl+Left sometimes does not move the caret back one word. (Ctrl+Right seems to work fine.)
[ ] Alt+Left and Alt+Right do not move the caret to the start/end of the line.

[ ] Alt+Left sometimes moves the caret one character left and sometimes moves focus to the back arrow icon button.
[ ] Alt+Right moves the caret one character right.

Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This seems to be a known bug with TextField generally, reported here: https://b.corp.google.com/issues/295666701

Regarding the desired behavior of Alt+Left and Alt+Right moving the caret to the start/end of the line, is that standard for text fields in Android apps? If so, I'm not able to find any information about it. That behavior also does not exist (at least not by default) with views; I made a quick replica using EditText and using the material TextInputLayout, and those shortcuts don't move the cursor.


Support more elements inside the directive, not just ngRepeat

Previous Title: "Empty item is inserted to array after reorder if there are non-sortable siblings"
If you setup ui-sortable to sort only some elements in the container (e.g. by configuring sortable with items: '> .sortable') and keep in sync with model via ng-model, there is a risk that new empty items will be inserted into the array.
Have a look at demo here. Grab the second item and put it before the first. The new empty item is created.

Fixed in v0.14 by #344


CMS 6 - Change sitetree search render default to false

ElementSiteTreeFilterSearch.render_elements default is true - it was created this way to maintain the existing CMS 5.0 behaviour
Switching this to false creates a large boost in the cms sitetree search performance
Unless not rendering elements results in a significantly worse, the default should be changed to false for CMS 6

My hope is that we'll have a proper search service soon and will be bale to power site search through this instead and this card will become redundant. But my hopes have been dashed before.


Scenario tests don't exit after crashing

See: https://ci.chromium.org/p/flutter/builders/try/Mac iOS Engine/9808?

/cc @dnfield @blasten @cyanglaz

Marking P2 since this looks like it is chewing up a lot of infra resources and for visibility.

We should reduce the overall time allowed for the bots. They shouldn't be allowed to run for 2.5 hours.
It's not clear to me where the crash is - it looks like the test harness is still running but stuck?

/cc @godofredoc and adding infra label for bot timeout.
@cyanglaz yes on presubmit. Note the shiny new 'team: presubmit flakes' label =)

We could also add a timeout on the step itself I believe.  @godofredoc WDYT? I would probably rather just have fewer individual timeouts though.
In this case, it looks to me like XCTest/xcodebuild have just hung. The process does not appear to be crashing. We shouldn't let it go this long, but again I think the root problem here is that the bots are allowed to run for so long.

I'll create a CL to have a max 1 hour execution time.

We may be hitting the same issue here as in the gtest harenss where tripping an assertion on a Dart VM managed thread does not take down the process because of the VM hijacking some signal handlers. In the gtest harness, we we have a per test case timeoout of 30s. We might need to do something similar here. Or, more precisely, figure out how to make VM no hijack signal handlers so we get the desired expected behavior. Lowering the priority of this issue because the timeout has been applied on the bot but will followup with the DartVM folks about the right fix for this.

In the scenarios case this is happening because we are running the script to build and test and we are killing the emulator after without a defer_results block which means if the test/build fails we are not killing the emulator. To fix it we can add api.step.defer_results(): to this context https://cs.opensource.google/flutter/recipes/+/master:recipes/engine/scenarios.py;l=101?q=scenarios.py&ss=flutter

@godofredoc are you doing that or do we need to find someone to do that?

I can send a CL for that during the day.

This issue is still being reported:

https://ci.chromium.org/ui/p/flutter/builders/try/Mac iOS Engine/11167

I believe this has not reoccurred recently, so I am closing this as stale.


add workflows for releasing helm chart

This PR publishes the Helm chart using GitHub pages on the current repo, making it easier for people to install. This way we at Plural can more easily keep the Touca installation up to date with the helm chart in this repository. For an example of how the repo will look after this you can have a look at our fork. https://github.com/pluralsh/trytouca
For this to work a new gh-pages branch needs to be created with the following 2 files before merging this PR:
index.html:

    <title>Touca charts repository</title>

Touca charts repository

Add this repository

      helm repo add argo https://trytouca.github.io/trytouca

index.yaml:
apiVersion: v1
entries: {}
generated: ""

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1204723999139649

Hi @DavidSpek, thanks for this. Are you proposing using GitHub pages simply because it's convenient to deploy to it from the CI? Wouldn't it be better if we deployed to somewhere like https://touca.io/install/helm?

Thanks again, @DavidSpek. We have a bit of CI logic that generates a template and uploads it to S3 (see here). But it's incomplete because certain values and parameters are hard-coded. It appears your PR is taking care of fixing that. My preference is to use your PR to update that CI logic (instead of adding a new GitHub Actions workflow and using GitHub Pages). I have nothing against using Pages but since this is a monorepo, it's not ideal to deploy helm to Pages.
Let me try to update our existing CI logic tonight and if that didn't meet Plural's requirements, we can revisit merging this PR as is.

Another option would be to have the helm chart live in a dedicated repo to avoid cluttering up this repo. Or just have the helm chart releases live in another repo where GH pages lives. However, I'm not sure what your opinions are about this and I couldn't create a PR for creating a new repo obviously.

@ghorbanzade Were you able to get around to implementing the logic from this PR for the existing setup already?


Fix upnp raw sensor state formatting when None

Description:
The state() method of the RawUPnPIGDSensor class will cause an exception if self._state is still None. The problem was reported in this forum topic:
Error doing job: Task exception was never retrieved - upnp/sensor.py
It was also noted in comments in these issues:
15257
20893
Reviewing history discovered this bug was introduced in release 0.80.0 by PR #16300 by this change. Prior to that (in release 0.79.3) self._state was checked before formatting, similar to what is now done in the state() method of the KBytePerSecondUPnPIGDSensor and PacketsPerSecondUPnPIGDSensor classes.
The fix in this PR is to check the state before formatting just like in the two other classes.
Related issue (if applicable):
This does not directly fix any currently open issues.
Pull request with documentation for home-assistant.io (if applicable):
N/A
Example entry for configuration.yaml (if applicable):
N/A
Checklist:

[ ] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

@robbiet480 should I request a review from someone else? Not sure if you're super busy with something else. This should be a relatively straightforward fix for a problem reported multiple times. Thanks!


URLs, replace or remove?

Replace or remove hard coded urls:

https://adoptadrain.sfwater.org/
https://github.com/sfbrigade/adopt-a-drain
https://github.com/sfbrigade/adopt-a-drain/wiki/Windows-Development-Environment
https://www.instagram.com/sfwater/
https://twitter.com/SFWater
https://twitter.com/sfwater?lang=en>@SFWater
https://twitter.com/hashtag/drainhero">#DrainHero
https://twitter.com/hashtag/adoptadrain">#AdoptADrain
https://twitter.com/hashtag/sfsewer">#SFSewer

I think we will host instructions, or other info about the program eventually at https://www.lgrow.org/
Facebook: [https://www.facebook.com/LGROW.org]
Instagram: [https://www.instagram.com/lgrow_org/]
Twitter: [https://twitter.com/LGROW_GVMC]

Proposed replacements:

~https://adoptadrain.sfwater.org/~
https://github.com/citizenlabsgr/adopt-a-drain
https://github.com/citizenlabsgr/adopt-a-drain/wiki/Windows-Development-Environment
https://www.instagram.com/lgrow_org/
https://twitter.com/LGROW_GVMC
https://twitter.com/LGROW_GVMC?lang=en>@SFWater
~https://twitter.com/hashtag/drainhero">#DrainHero~
~https://twitter.com/hashtag/adoptadrain">#AdoptADrain~
~https://twitter.com/hashtag/sfsewer">#SFSewer~


etcdserver: lost proposal on leader change doesn't time out

How to reproduce:

kill leader
immediately issue Put on follower
Put is dropped in rafthttp due to leader failure
client waits on Put forever (or until server is killed, which cancels the trigger)

I will take a look


Built-in contracts like vm and the create2 factory should be excluded senders in invariants

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (e7ef3c2 2023-01-24T00:14:27.601697Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
When running invariant tests with fail_on_revert = true, one must call excludeSender for all addresses with code. Otherwise you get the following nondescript error:
  [0] 0x0000000000000000000000000000000000000000::fallback()
    └─ ← ()

Ideally forge would automatically exclude contracts from its randomized sender generation. Barring that, users should be told to exclude the following built-in contracts, since they may be unaware of them:

0x7109709ECfa91a80626fF3989D68f67F5b1DD12D (vm)
0x4e59b44847b379578588920cA78FbF26c0B4956C (create2 factory, not documented in foundrybook afaict)

Arguably this is a feature request, but as far as I'm concerned it's unexpected/unexplained behavior so I'm submitting as a bug.

Ideally forge would automatically exclude contracts from its randomized sender generation.

I disagree with this: while a contract can't initiate a tx in reality, a contract can call other contracts, which is important to simulate
I do agree that forge should exclude a few addresses from being senders by default: the VM address, the console address, and the create2 factory address

a contract can call other contracts, which is important to simulate

I agree, but afaict forge is unable to actually simulate that case. When trying to initiate calls from any address with code, it fails with the error I posted above. See #3879


[Suggestion] Reroll relic's attributes

My suggestion is to add a way to reroll your relic's attributes using other item / using an anvil with a specific item (a bit like the tiered mod). Maybe the rerolling item could increase your chance for better attributes!
That's it, the mod is great thank you so much :)

Hi there,
I appreciate the suggestion, I'll keep it in mind for future development.
Thanks.


Update MD file on new branch 2017-30-06_09-12-51

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Data leakage through normalization on ground truth?

Hi @yuxumin,
First of all, thank you very much for this excellent piece of research!
While going through the code, I had a question concerning the way you normalize the ShapeNet data: it seems like you normalize the objects to be confined within the unit sphere as you load the training and test samples in the ShapeNet class. You then remove a part of that normalized point cloud and serve this as the input to the model. However, in real use-cases one would normalize the occluded input point cloud, and not the ground truth. Would this not result in the model expecting ground truths that remain within the confounds of the unit sphere, which would be impossible to guarantee when provided only with the occluded input pointcloud? Hence would this not lead to data leakage and reduced performance in cases where the ground truth does exceed the confounds of the unit sphere (which will often be the case since a large part of the ground truth is removed, hence resulting in a significant likelihood of reducing the size of the bounding sphere)?
I would love to hear your thoughts on this!
Many thanks in advance,
@anthonyrathe

Thank you very much for your quick reply!
Interesting thought to consider normalization as a possible constraint, as I fully agree that pointcloud completion has many possible solutions hence the model could be guided by these constraints to reduce the solution space.
Also, I noticed you had implemented some code to perform random scaling, so I wondered: have you tried randomly scaling the input to mitigate this normalization problem by forcing the model to become scale-independent?
Many thanks again!

Hi, sorry for the late reply.
Yes, we try it when we adopt our model on real-scan dataset KITTI. However, it only can make the model adapt to various scales in a limited space.


Vanilla example is not loading due to wrong urls

TanStack Table version
8.20.5
Framework/Library version
Na
Describe the bug and the steps to reproduce it
Go to the homepage, scroll down to "Take it for a spin!", press Vanilla and observe

The url to this repository is invalid.
Please make sure the folder path in the URL exists within the repo.
If you think this is a bug, please file an issue in our repo!

The link to file an issue also seems funky. Pressing it crashes the page and it also seems wrong: https://github.com/stackblitz/core/issues/new
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
Not code
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
None
Terms & Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Heyhey,
why is this marked as completed?
it seems to still happen with https://tanstack.com/table/latest

All the best,
Florian

Related #5821


dfvfs installed twice in worker docker image

The Dockerfile for the worker image install dfvfs with pip through the requirements but apt-get install plaso which will install dfvfs as a dependency. Installing two times does not make sense, we need to clean this up.

Fixed by #715


Mouse wheel scrolling cannot be disbabled by setting enabled=false

I want to disable all user inputs for scrolling a view to only scroll it programmatically.
However when I use
Modifier.horizontalScroll(scrollState, enabled = false)
// or
Modifier.verticalScroll(scrollState, enabled = false)

it is still taking mouse wheel scrolling events.
Is it a bug or do I get something wrong?
Minimal reproducible code
Kotlin: 1.6.10
Compose: 1.1.0
import androidx.compose.foundation.horizontalScroll
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.rememberScrollState
import androidx.compose.material.MaterialTheme
import androidx.compose.material.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.window.Window
import androidx.compose.ui.window.application

@Composable
fun App() {
    MaterialTheme {
        val scrollState = rememberScrollState(0)
        Box(Modifier.fillMaxSize().horizontalScroll(scrollState, enabled = false)) {
            Text(text = "abcdefghijklmnopqrstuvwxyz".repeat(100))
        }
    }
}

fun main() = application {
    Window(onCloseRequest = ::exitApplication) {
        App()
    }
}

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Cannot finish amplify configure with Admin UI on Windows

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v14.13.0
Amplify CLI Version
4.41.2
What operating system are you using?
Windows, macOS
Amplify Categories
auth
Amplify Commands
pull
Describe the bug
When I pull a backend setup by Admin UI, that shows a login page and makes an error when proceed. The error message was “Failed to communicate with the Amplify CLI”.
Expected behavior
Should success login.
Reproduction steps

Finish tutorial on https://sandbox.amplifyapp.com/start#datastore
Login AWS management console
Move to Admin UI
Enable Auth from Admin UI
Run displayed amplify pull
Open browser and login via Admin UI
See the error

Log output
Let me put screenshot instead since the error is captured in browser.

This issue is related to https://github.com/aws-amplify/amplify-adminui/issues/134. I debug the issue and turned out we do use express server in amplify-provider-awscloudformation to listen POST request from Admin UI login page. The default of hostname is localhost, <IP_ADDRESS> and <IP_ADDRESS> on macOS, but Ubuntu on WSL2 on Windows allows only localhost by default. Since <IP_ADDRESS> seems to be coded in Admin UI console, we can specify the hostname in CLI.
Refs: reported by a developer - https://ginpen.com/2021/03/02/failed-to-communicate-with-the-amplify-cli/

@watilde Thanks for reporting the issue and also providing the PR, we look into it and it gets into the next release!


Clean up the javadoc warnings

There are screeds of javadoc warnings when running the maven build.

This has a negative impact on productivity.
Developers are less likely to notice impactful warnings amongst the noise.
Our javadoc will tend to rot, as there'll be an assumption that we don't care about it.

We should clean up the warnings.
Run mvn verify and look for the screeds of yellow.
Originally posted by @k-wall in https://github.com/kroxylicious/kroxylicious/issues/195#issuecomment-1467944993

@racheljpg wondering if you could put this on your todo list as a low priority/background item.  Don't let it block the more important tasks.

Hello @k-wall ,
I am new to open source, can I work upon this?

Welcome, yes, go ahead.

Getting some error while pulling the code to my local, any idea on this?
" no marketplace entries found to handle kroxylicious-krpc-plugin:0.1.0-SNAPSHOT:generate-multi in Eclipse.  "

#259 chipping away


fix(sample): update path for kvm and sol

Codecov Report

Merging #211 (f4c3f73) into master (11c3ebb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   62.40%   62.40%
=======================================
  Files          58       58
  Lines        2865     2865
  Branches      595      595
=======================================
  Hits         1788     1788
  Misses        942      942
  Partials      135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c3ebb...f4c3f73. Read the comment docs.