incompatibily issue when using load_dataset with datasets==3.0.1

Describe the bug
There is a bug when using load_dataset with dataset version at 3.0.1 .
Please see below in the "steps to reproduce the bug".
To resolve the bug, I had to downgrade to version 2.21.0
OS: Ubuntu 24 (AWS instance)
Python: same bug under 3.12 and 3.10
The error I had was:
Traceback (most recent call last):
File "", line 1, in
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/load.py", line 2096, in load_dataset
builder_instance.download_and_prepare(
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/builder.py", line 924, in download_and_prepare
self._download_and_prepare(
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/builder.py", line 1647, in _download_and_prepare
super()._download_and_prepare(
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/builder.py", line 977, in _download_and_prepare
split_generators = self._split_generators(dl_manager, split_generators_kwargs)
File "/home/ubuntu/.cache/huggingface/modules/datasets_modules/datasets/mozilla-foundation--common_voice_6_0/cb17afd34f5799f97e8f48398748f83006335b702bd785f9880797838d541b81/common_voice_6_0.py", line 159, in _split_generators
archive_path = dl_manager.download(self._get_bundle_url(self.config.name, bundle_url_template))
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/download/download_manager.py", line 150, in download
download_config = self.download_config.copy()
File "/home/ubuntu/miniconda3/envs/maxence_env/lib/python3.10/site-packages/datasets/download/download_config.py", line 73, in copy
return self.class({k: copy.deepcopy(v) for k, v in self.dict.items()})
TypeError: DownloadConfig.init() got an unexpected keyword argument 'ignore_url_params'
Steps to reproduce the bug

install dataset with pip install datasets --upgrade
launch python; from datasets import loaad_dataset
run load_dataset("mozilla-foundation/common_voice_6_0")
exit python
uninstall datasets; then pip install datasets==2.21.0
launch python; from datasets import loaad_dataset
run load_dataset("mozilla-foundation/common_voice_6_0")
Everything runs great now

Expected behavior
Be able to download a dataset without error
Environment info
Copy-and-paste the text below in your GitHub issue.

datasets version: 3.0.1
Platform: Linux-6.8.0-1017-aws-x86_64-with-glibc2.39
Python version: 3.12.4
huggingface_hub version: 0.26.0
PyArrow version: 17.0.0
Pandas version: 2.2.3
fsspec version: 2024.6.1

Hi! I'm also getting the same issue - have you been able to find a solution to this?

From what I remember, I stayed at the "downgraded" version of dataset (2.21.0)


compose: Disable send button when upload/s are in progress.

Earlier, the send button's state was determined independently by the message length and the upload status. As the message length check was run on each character input, it often overrode the upload status check.
Now using the observer pattern we update the send button anytime message length or upload status changes, considering both of them together.
(The Save button when editing a message still works like before -- only dependent on upload status.)
Fixes: #21135.
Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Implementation lgtm; I'll wait for @alya to approve before merging.

When I test, I'm not able to send even after the upload is canceled, of if I start a new message. Reloading the page fixes it.

Also, the button looks disabled in dark theme, but not light theme.

We also need to change the cursor to disabled cursor, and add a tooltip. Something like:
"Cannot send message while files are being uploaded."

When I test, I'm not able to send even after the upload is canceled, of if I start a new message. Reloading the page fixes it.

@alya On cancelling all uploads the send button reactivates for me... Can you elaborate your specific use case with this bug a little more?
I'll work on the other issues you brought up in the meantime!

Well, for long messages we currently have a banner... It would probably be better to just have a tooltip on the "Send" button, and make "Send" look disabled. But I haven't tracked down the design discussion to see if we had a reason for the current approach.

We should probably have prioritization on the tooltips, since we don't want to show multiple ones, and we also have this:

A reasonable order would be:

The DM tooltip
The message length one, for which we can just use the current banner text: "Message length shouldn't be greater than 10000 characters." We can keep the current banner, and think about dropping it as a follow-up.
"Cannot send message while files are being uploaded."

In all these cases, we should have the button look disabled, with a disabled cursor.

For the other part, the behavior I experienced (and I don't know if there's something I'm not realizing about how to reproduce it) was that I canceled the upload, and I still couldn't send a message, nor send a brand new message until I refreshed.

@alya The tooltips have been fixed, and now the send button looks the same when its disabled irrespective of the reason:

For the other part, the behavior I experienced (and I don't know if there's something I'm not realizing about how to reproduce it) was that I canceled the upload, and I still couldn't send a message, nor send a brand new message until I refreshed.

I haven't been able to replicate this behaviour. Could you check if you still face this bug?

Works in my manual testing! @karlstolley perhaps you could review?

Looks like solid work to me, and does what it says :) I expect the next step for this is burn-in on CZO after @timabbott has cut the first 8.0 beta.

Thanks for the review @karlstolley ! For next time, it's helpful to remove the "maintainer review" label and add "integration review" when the PR looks good.

Merged, thanks @N-Shar-ma!


Add subdomain property to RouterRequest

This should be an array of subdomain strings.

I have implemented this feature in a separate branch. Should I add it to my current pull request or create a new one?
Here's the code and travis build for reference:
https://github.com/naithar/Kitura/blob/subdomain/Sources/Kitura/RouterRequest.swift#L46-80
https://github.com/naithar/Kitura/blob/subdomain/Tests/Kitura/TestResponse.swift#L353-398
https://travis-ci.org/naithar/Kitura/builds/131382000

Hey @naithar, thanks for the contribution! You should create a new PR so we can evaluate them separately.

@dfirsht done :)

This issue was completed in the PR.


Add additional commit message type "deps" to categorize dependency updates

The Telegraf project has a lot of dependencies, therefore we get a lot of pull requests that update the dependencies (such as this one https://github.com/influxdata/telegraf/pull/11266) and we are reporting these in the changelog in a separate section. I was hoping to find a way to categorize these types of pull requests so when we generate the changelog it gets sorted automatically.
@jacobmarble and @tysonkamp What do you think about extending the support "types" (e.g. feat,fix) to include something like "deps"? This definitely isn't a blocker, I think there are other approaches we can take, but curious to hear your thoughts on this possibility?

I'm fine with it, but I am no opinionated regarding commit messages.  @jacobmarble  I defer to you and other dev managers and dev teams. Thoughts?

I didn't know dependabot already had a convention with chore(deps), we can definitely work with that for automation. Thank you!


awair: display bar graph

Description
NOTE: this PR is based off of #2136, please review that one first.
This PR introduces an alternative display configuration for a "bar chart" view (in place of the default data table view).

showing temperature, humidity, CO2, VOCs, PM2.5 in the same order as the Awair device and app.
Copilot

copilot:all

@tabrindle Any objections to this approach (now that I think #2136 is planned for merge)? Again I tried to make sure existing configs would continue to work.


New package: Crossterm v0.1.1

Registering package: Crossterm
Repository: https://github.com/kdheepak/Crossterm.jl
Created by: @kdheepak
Version: v0.1.1
Commit: 72008ff9abd2bb0cc16bbf0971968e46cf86471d
Reviewed by: @kdheepak
Reference: https://github.com/kdheepak/Crossterm.jl/commit/72008ff9abd2bb0cc16bbf0971968e46cf86471d#commitcomment-122406299

[noblock] you can just re-trigger registration after you fix the compat issue

I got this warning on the commit comment:

Also, note the warning: This looks like a new registration that registers version 0.1.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

I've updated the version number back to v0.1.0. So this PR can be closed and I'm hoping I can get the other one to be merged.

I’ll make my comments on the other one non-blocking

Perfect! Thanks!


Add fusion regression

This PR should address issue #2595 if goes well.

Added a new script run_fusion_regression.py to handle fusion regression tasks. It behaves similarly to run_regression.py.
Included two test yaml files.
Tests could be performed following anserini/docs/fuse-regressions/test-setup.md.
Next steps in mind are

Implementing an auto-script to generate more yaml files for fusion based on current regression yamls (working on it)
Doing experiments to find out expected eval results for fusion on different runs with different fusion methods and parameters

Why don't we start with fusion robust04 BM25 and dense:
BM25: https://github.com/castorini/anserini/blob/master/docs/regressions/regressions-beir-v1.0.0-robust04.flat.md
BGE: https://github.com/castorini/anserini/blob/master/docs/regressions/regressions-beir-v1.0.0-robust04.bge-base-en-v1.5.flat.onnx.md
Accessible here: https://github.com/castorini/anserini?tab=readme-ov-file#beir-v100-regressions

Added corresponding yaml. Do you like the structure of the yaml and the namings? If so, I could start on generating more.

hey @Stefan824 this is good for merging, but I pinged you on Slack for improvements. Please work on that next. Thanks!


Update junit-jupiter-engine to 5.5.2

Updates org.junit.jupiter:junit-jupiter-engine from 5.0.3 to 5.5.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.junit.jupiter", artifactId = "junit-jupiter-engine" } ]

labels: semver-minor

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   80.86%   80.86%
=======================================
  Files         128      128
  Lines        3340     3340
  Branches       91       91
=======================================
  Hits         2701     2701
  Misses        639      639

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872a725...0e8a1ea. Read the comment docs.


Allows setting of instance status.

Uses the metadata field to set an instance_status key. The ZookeeperServerList will filter out instances who have a value set that is not UP.
fixes gh-112

/cc @grinfeld
Still needs tests.
echo -n OUT_OF_SERVICE | http POST :8081/service-registry/instance-status

Now you could set spring.cloud.zookeeper.discovery.initial-status=OUT_OF_SERVICE for new versions, then swap OUT_OF_SERVICE & UP with the actuator endpoint.

Closed via 30c610c91ed1549c9c202dd464248650a8bc1479


Can we stil make a PR contribution practice ?

Description
Hello i found this great repo and was trying to see how can i make a PR too but it seems like you delete the last PR delete the lines where people contributed. So is it still ok to contribute on this file?
Screenshots

Great initiatives by the way :-).

Hi @ManuSquall,
Thanks for raising this issue, that was actually a mistake and it has been resolved.
So, please you can go ahead to make your pull request now!
Thanks


editor visual refresh

Editor should cover entire screen when controls are closed. When they are open, it should get smaller to accommodate controls. No more overlap.

This is too slow. Would obviously be better not to reload the spectrograms. Maybe rethinking the non-caching situation would be appropriate.

This was implemented. But still not a perfect solution. The windows sometimes get in eachother's way, will end up covering up part of the editor at times.

editor has been overhaulsed


linkActiveClass isn't set on original link when visiting through alias

Vue.js & vue-router.js version
2.5.17 & 3.0.1
Reproduction Link
https://jsfiddle.net/8xrk1n9f/1279/
Steps to reproduce
router.map({
    '/foo': {
        component: Foo
    },
    '/bar': {
        component: Bar
    }
})

router.alias({
    '/baz': '/bar'
})

What is Expected?
The /baz path is alias of /bar, it should be active when i click /baz link.
What is actually happening?
nothing happened, but route to component Bar

I know that this enhancment was opened in the 1.x version, but it is still not present in the 2.x version
It would still be nice to have the alias-matching functionality in 2.x :-)

@LinusBorg would it be possible to add the 2.0 tag to this as well.

Any progress on this?

This went under my radar for too long. I will take a look tomorrow

Forgot to give an update. The current mechanism to compare route doesn't properly take into account aliases as it should compare records. There is a workaround to do it in userland but this depends on #2286 being merged

There is a workaround to do it in userland

@posva you mind sharing some example/links ?

It depends on that or to be merged first

Any progress?

I know it's probably not the most straightforward way to implement it but i have a workaround that might help some people here.
{
  {
    path: '/',
    beforeEnter: (to, from, next) => next('/actual-route'),
  },
  {
    path: '/actual-route',
  },
}

This wil redirect your alias to the intended route and setting the linkActivelass when visiting through an alias.

Any updates on the PR merge or other fix?

@posva are you sure this is fixed? Encountered this on v2.6.11

Any updates on this? Just hit it today, really can't use the alias feature without correct link highlighting.

Is there any update on planned date for 4.x release?

Is there any update on planned date for 4.x release?

The release was one month ago.
https://github.com/vuejs/vue-router-next/releases/tag/v4.0.0

The release was one month ago.
https://github.com/vuejs/vue-router-next/releases/tag/v4.0.0

You could probably do something I have done myself in other scenario.
In my case

I did not want the redirect to occur
routes should have different parameters

The actual use case is - you might want to have a page for viewing a list of something, another page for creation/editing and one for viewing a single something:

/users - this page does not need an ID
/users/1/edit - no NavLink for this route
/users/1/view - no NavLink for this route

From the example - the list of users does not need an ID.  However I still wanted the active class to shown on the other two pages..
Copy-paste my answer from: https://stackoverflow.com/a/69933108/1215913
using vuejs 3 in main app.vue I have routes defined. The routes are then parameter-injected into sidemenu component (which is not important in this example)
app.vue dependencies
import { ref, watch } from "vue";
import { useRoute } from "vue-router";

setup() method (using composition API):
setup() {
const route = useRoute();

const myActiveClass = ref(null);

const checkIfMustActivateRoute = () => {
  return {
    active:
      window.location.pathname.startsWith("/users/view/") ||
      window.location.pathname.startsWith("/users/edit/"),
  };
};

watch(
  () => route.fullPath,
  async (_) => {
    myActiveClass.value = checkIfMustActivateRoute();
  }
);

myActiveClass.value = checkIfMustActivateRoute();

const routes = ref([
  { id: 0, name: "Home", href: "/", icon: "fas fa-home" },
  {
    id: 1,
    name: "Users",
    href: "/users",
    icon: "far fa-clone",
    class: myActiveClass,
  },
]);

return {
  routes,
};
},

NavLinks are dynamically generated like so:

    <router-link :to="tab.href" class="nav-link" :class="tab.class">

        {{ tab.name }}

    </router-link>

Now whenever the router's path property changes I trigger the active class update function. This way we don't have to use aliases or any other trickery.
The result is - for all 3 paths I always enable active class.
Copy-paste END
Now, given that I just started learning JavaScript I suppose there could be some issues here :)


Overlap issue of responsive layout

Hey, looks like there is an issue of responsive layout feature.
"vue-grid-layout": "^2.3.1",
Version 69.0.3497
os: macOS High Sierra
Look forward to your reply

I am also facing same issue. Can any one please look into it.

Same problem, even with sync on layout.

Seems to be caused by layouts not clear in GridLayout ;)

Seems to be caused by layouts not clear in GridLayout ;)
Fixed by reset lastBreakpoint and layouts on change responsive mode or adding items :
lastBreakpoint = null;
layouts = {};

Can you show demo example?

Hi @Safirion,
Yes please, do you have an example of this?
Thanks!
Ed

Seems to be caused by layouts not clear in GridLayout ;)
Fixed by reset lastBreakpoint and layouts on change responsive mode or adding items :
lastBreakpoint = null;
layouts = {};

Can you show demo example?

I fixed doing the same thing he mentioned, getting this properties fetching the grid-layout with ref
<grid-layout ref="gridLayout"> </grid-layout>
and on mounted event I called this method
    resetGridLayout() {       this.$refs.gridLayout.lastBreakpoint = null       this.$refs.gridLayout.layouts = {}     }

I was having this issue due to externally updating layout multiple times when mouted. See here
https://github.com/jbaysolutions/vue-grid-layout/issues/269#issuecomment-617639202

I was having this issue due to externally updating layout multiple times when mouted. See here
#269 (comment)

Did you manage to find a workaround?

So this seems to be a very old issue but the problem is still not solved in the current version. The method described by mathewsjts doesn't work. Setting layout.sync works neither.
any ideas?

BTW https://github.com/gridstack/ have solved the issue.


Update "announcements" with new pymcon link

We should update the announcement cards with new pymcon website: https://www.pymc.io/welcome.html#announcements.
The announcements in the landing page need to be updated too
Originally posted by @OriolAbril in https://github.com/pymc-devs/pymc.io/issues/58#issuecomment-1339113746
This is continuation work from #58

what announcements do we want to have in the landing page now?
some options:

3x2 layout, keeping all current announcements. That would be adding pymcon announcement as the first one
2 rows, 1 element in the first and 3 in the 2nd. We could for example have pymcon be a larger and wider announcement, then have 3 older/smaller announcements in the 2nd row: pytensor, v4 and office hours?
keep proposing


Rework blending to make it more flexible

Close #302
cc #161
Breaking change: removes LerpBySourceAlpha. Replace by Addition { source: Alpha, destination: OneMinusSourceAlpha }.

Oops, meant to close #301 instead of #302


Update the docs for sqlite_unlock_notify

These cases are all I have found.
Some description of why sqlite_unlock_notify is needed might be helpful, but I am not capable of translating all the supported languages.

Codecov Report

Merging #5145 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5145      +/-   ##
==========================================
- Coverage   37.49%   37.48%   -0.01%
==========================================
  Files         309      309
  Lines       45782    45782
==========================================
- Hits        17164    17161       -3
- Misses      26157    26159       +2
- Partials     2461     2462       +1

Impacted Files
Coverage Δ

modules/process/manager.go
76.81% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce72d4...3481986. Read the comment docs.


Presentation Exchange & Credential Manifest Builders

Following the builder pattern to construct all PE and CM objects.

CM builders added in https://github.com/TBD54566975/ssi-sdk/pull/95


CodeGeex VSCode opens output panel on startup

It didn't used to be like this, but now this seems to happen to me whenever a new window loads the extension:
It opens the Output panel with Codegeex output and showing this:

Hi! We will fix this in the next version.


Update Get-CMDistributionStatus.md

Resolves #186

@baardhermansen : Thanks for your contribution! The author(s) have been notified to review your proposed change.


TypeScript as the main language for the jhipster-core

Overview of the request

TypeScript as the main language for the jhipster-core (and eventually generator-jhipster) module

Motivation for or Use Case

Hi "Jhipster Core" team,
First of all I'd like to commend:clap: your team on an awesome job with the Jhipster generator. I'm definitely among the several fans of the tool.
I've been following (and learning) the generator closely and would like to know if the team is considering (or would like to consider) TypeScript as the main language for the jhipster-core (and eventually generator-jhipster) module?
I know this will be a daunting task and would probably slow down the current planned releases. However, there are ways to prevent too much slowing down of planned work (e.g. it could be done on a parallel branch until the TS code catches up to the JS code).
Nevertheless, there are a lot of benefits that TypeScript will bring to the code. Here are few that I can think of:

this change will hugely help jhipster module devs (if not the core development team as well) to develop
the code will have stricter/more concise api (no more guessing which method parameters are optional and what their types should be)
this will be helpful in making the code maintainable when it grows
this will eliminate the need for writing code for classes like Set
a (more accurate) typescript definition (jhipster-core.d.ts, generator-jhipster.d.ts) can be easily made available to the plugin/module developers
catch/avoid bugs early in the stage of development
the list goes on...

I've taken a stab at converting v1.3.7 of core module (here) and would like to know what the JavaScript/TypeScript gurus on the team think about it.
Stay hip :bowtie: !
PS: Few things that are pending or need polishing (which I can further improve, once I get blessings of the core team):

Some of the components have been refactored (and the names might not be what you want), but the basic intent is to have a POC showing a cleaner implementation using TypeScript features (e.g. enums extracted into their own files)
The 'tslint'-ing needs to be finalized (what rules to apply, etc)
Few tests have been disabled since I could not figure out a way to get the deep object comparison to work in the typescript world

I'll develop my "thumb down" later, but for me it's a no.

We have other priorities, like React, OIDC, Couchbase, etc. Need more help there, than changing here to TypeScript.
So for me, as Matthieu, -1

Sorry, No from me too. I have been using Typescript on projects for a long time and I don't see it as that huge benefit for a Node project. It adds additional complexity of transpiling and slows down development for such projects.

Having said that if you would like to help then you could consider writing type definition files for the public API which will help with first 3 points you mentioned

this will hugely help jhipster module devs (if not the core development team as well) to develop
the code will have stricter/more concise api (no more guessing which method parameters are optional and what their types should be)
this will be helpful in making the code maintainable when it grows

@vivekmore Hi, sorry I didn't have time yesterday to write a correct comment.
My main issue with your proposal is your arguments (easy for me to say, I know). A "good" language doesn't always imply a "good" project. Your points about how stat. typed languages make for a better project are, in my opinion, just plain wrong. If a project isn't good enough in terms of quality, don't blame the project: just tell the developers who coded the project how you think the project would be better, they may learn. The same goes for bugs, a very well-structured project in a dyn. typed language (I don't say this project is, not yet anyway) shouldn't encounter type-related bugs (or very, very little of 'em). This project hardly does!
Anyway, thanks for your proposal.

@MathieuAA,
This proposal was not an attempt to say that

the project isn't good enough in terms of quality

in any way, shape or form. I apologize if it came across that way.
I'm also not saying that statically typed languages make for a better projects. There are and will always be bugs in any project/software. So far, I have only good things to say about the code quality of jhipster*    projects' quality.
However, I believe that using TypeScript (which is more than just a strictly typed language and built on the newer version of ECMAScript) would benefit the code base in the ways are already mentioned. I'm sure we can respectfully agree to disagree on this one.
I also understand (and appreciate) that the team has higher priorities on other stuff, and that fact would make this proposal less viable at this time (or even unnecessary like the team has decided).
Nevertheless, I respect your team's decision, and thanks for taking the time to ponder over my proposal and expressing your views.

@vivekmore no worries, we do respect your opinion. Thanks for your contributions and hope this doesn't affect your Future contributions. I have seen your TS repo and I wish you hadn't spent time on it without discussing it first so. Sorry that you lost time in that. Hope at least it was educational. If you are interested in making TS related contributions we would really appreciate it for our React and Angular code which is in Typescript. For the React part, we would appreciate more contributions to speed it up.

Would you be interested in using TypeScript for public APIs
While also validating the implementation inside JHipster-core matches the APIs.
Meaning maintaining the APIs in d.ts files inside this repo
and using some of the newer capabilities of TypeScript to check / annotate JS files?
This approach does not use any code generation and only uses TypeScript as a linter.
I want to create a  public repo implementing this pattern soon as it could interest many library authors.

@deepu105,
Thanks for your concern, but I wanted to do it for personal enrichment too 😉 - also I wanted to gauge the effort/complexity before I proposed anything.
I will definitely continue to contribute in the future.
Time permitting, I'll do some research on how to start maintaining type declaration files for any project and come back with questions or PRs.

If there is an interest in using typeScript for public APIs while staying a vanilla JS
project this pattern may be of interest.
https://github.com/bd82/typescript_for_public_apis

Personally I'm also against migrating the generator code to typescript. I personally think Typescript is great but I'm of the opinion that generator language or technology itself is not very important. More importantly the code should be simple and easy to contribute to.
However it could be valuable to help developers write modules in typescript.
You could contribute the following :

add typings files for the generator public API, maybe distributed as a separate package ?
contribute a typescript option to jhipster-module (the module to generate modules).

In the future, we could eventually reconsider migrating to typescript.

Sorry guys to comment here so late. I'm going to repeat some existing comments, but those are the 2 big arguments for me:

We have so many opened tickets at the moment, in no way can we do something this big. That would also block all improvements for several months, which is also not possible.
I want to keep JHipster simple and easy to use: the project works because it's really simple and anybody can easily contribute. So I don't want to switch the language: I don't want the best technology, and want the easiest for contributions.


AttributeError: 'PartA2' object has no attribute 'test_cfg'

Hi,
I'm trying to run an evaluation on the PartA2 model. However, when I try run it, I get following error:

Thanks in advance for the help!

Please follow the template for reimplementation problems to re-describe your issue. We will help reproduce and fix this bug.

add
self.train_cfg = train_cfg
self.test_cfg = test_cfg
after line 41 in parta2.py
and then the problem solved

I have fixed it in https://github.com/open-mmlab/mmdetection3d/pull/1538.


Add disk size option in the preference window

With https://github.com/code-ready/crc/pull/2439, disk size is now supported on macOS. We can add back the option in the tray.

Done in #116


this.nav.canGoBack() gives wrong result

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.01
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
this.nav.canGoBack() result is TRUE when open a Tab, perform NavPush, and return to previous (Tab)Page.
Expected behavior:
this.nav.canGoBack() result needs to be FALSE when open a Tab, perform NavPush, and return to previous (Tab)Page.
Steps to reproduce:

Open a TabRoot / Tabpage
Push to a new page. this.nav.push(ProfilePage, {profile}); Needs to be the same with different parameters.
Return to the TabPage
Detect in  ionViewWillEnter(){console.log(this.nav.canGoBack());}
Result is true while you are now back on the TabRoot.

Related code:

//Open this page first as root/tab
tab3Root: any = ProfilePage;

//Open a new ProfilePage with different parameters
goToProfile(profile) {
  this.nav.push(ProfilePage, {profile});
}

//Return to the ProfilePage TabPage root

ionViewWillEnter(){
  console.log(this.nav.canGoBack());
  //result is true, needs to be false
}

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.1
ios-sim version: 5.0.6
OS: macOS Sierra
Node Version: v7.5.0
Xcode version: Xcode 8.2.1 Build version 8C1002

Thanks for using Ionic, we will look into this.

Not sure if you are having these issues still, but we still are seeing this in our application. When console logging this.nav.length(), the output returns 2 even though you are on the tab root, which I'm guessing is why this.nav.canGoBack() keeps on returning true. Hopefully this helps narrow down the issue!

@jwjenkin did you found the reason for this problem?
I'm having an issue where for some reason canGoBack() returns true when I directly type the url on the browser after the app is loaded:

Load the application http://localhost:4200/home
Change the url on browser to http://localhost:4200/login (the login page have an redirect "back" if canGoBack, or setRoot otherwise)

The following error appears:
core.es5.js:1020 ERROR Error: Uncaught (in promise): navigation stack needs at least one root page
    at c (polyfills.js:3)
    at Object.reject (polyfills.js:3)
    at NavControllerBase._fireError (nav-controller-base.js:223)
    at NavControllerBase._failed (nav-controller-base.js:216)
    at nav-controller-base.js:263
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (core.es5.js:3890)
    at t.invoke (polyfills.js:3)
    at r.run (polyfills.js:3)
    at polyfills.js:3

I am having the same problem. After using setRoot to change the root page I still get 2 when running this.navCtrl.length()


Remove _checkPort() when getting flutter views

This change removes port checking code that failed most of the time and isn't necessarily helpful when it succeeds, per discussion with<EMAIL_ADDRESS>

Thank you for the review. What is the next step? (This is my first pull request ever.) Is there something more I need to do? Or is merging in progress? The sidebar says no reviewers. Confused.


ML models

Add Gaussian MADE, MAF, Autoencoder
Add Heun_step, Integrator, NeuralODEWrapper
all in flax

seems to be missing a custom loops module?


Supported a request with a story. My username & support came up but story didn't

Expected Behavior

expected my story to be used. Otherwise, how will an author know cries

Actual Behavior

Saying I support it, but doesn't say way.

Steps to Reproduce this bug

support a request with a story

Fixed


Images in documentation are not showing on readthedocs

Problem
Images in the documentation (e.g. https://github.com/3dgeo-heidelberg/py4dgeo/edit/main/README.md#-methods-provided-by-py4dgeo) are not showing on the compiled site on readthedocs (https://py4dgeo.readthedocs.io/en/latest/intro.html#methods-provided-by-py4dgeo).
Solution
Assumingly solved by putting image files in directory named _static, see https://github.com/readthedocs/readthedocs.org/issues/5709#issuecomment-1149041819. To be tested.

I learned an alternative way of dealing with the situation lately, that also makes the images display on the PyPI project page: Use absolute URLs to Github, see e.g. here: https://github.com/parafields/parafields/commit/cc5055f2aac1b47597d76fa37300ac0c5a34c5e6

Thanks! Nice solution.
I changed it to absolute URLs. Works for rendering in gitlab, I cannot yet verify it on readthedocs though.


Make easier to fork and add contribution guide

Setting bot options like the token, prefix, main server id, etc, should be easier, and there should be a file that documents what values should be set and where

Wouldn't it be more appropriate to store the setup guide in READMD.md, its own dedicated SETUP.md file, or a script to generate it? The CONTRIBUTING.md file is usually for developers contributing to the project through issues and pull requests.


Directory CSV not downloading properly in Safari

Originally created by Tom Smyth at 2017-06-09 09:02, migrated from redmine-#6620

Version set to 4.3

By Tom Smyth at 2017-07-06 16:30

Status changed from New to Closed

Estimate set to 0.20 h

By Tom Smyth at 2017-06-09 13:02


NameError: name 'requests' is not defined

NameError: name 'requests' is not defined
Request Type
Bug
Work Environment

Question
Answer

OS version (server)
Docker

OS version (client)
Docker

TheHive4py version / git hash
ed7c6370f009ece57d6a76f6a60006dcd681e18e

Problem Description
In file thehive4py/auth.py, you need to import requests. Else, an error occured
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/thehive4py/auth.py", line 24, in __call__
    req.headers['Authorization'] = requests.auth._basic_auth_str(self.username, self.password)
NameError: name 'requests' is not defined

Steps to Reproduce

Execute the fonction

Possible Solutions
import requests

Hello, how did you install thehive4py? The error means you don't have the requests dependency

It is install via pip inside Docker.
In my script, I have the requests dependency. The issue comes from file : thehive4py/auth.py
In line 24, the script is using requests, but the module is not imported at the beggining of the file.
You should add import requests before the line from requests.auth import AuthBase.
I have just created a pull requests : #168.


Chat

Hi
Would it be able get the In game chat ?
Like if someone call's for an admin ?

Unfortunately the chat is not handled via RCon, so there is no direct way for retrieving it.

Yes it is, server is broadcasting chat message to all connected RCon clients, but you need to stay connected to retrieve those, so it's not possible only in php (= ajax needed).

@Memphis017 Alright, thanks for this information. Ajax is not necessarily needed, you can use a demon and a websocket. Of course, this isn't the best solution for such a scenario, because there are, as you said, other programming languages, which do better. Anyway, this is propably the easiest way for a chat protocol fully done in PHP.

Hey @schaeferfelix , do I have to use getSocket() function to get the chat/rcon logs? I know it will return a stream resource but how do I make it constant? I have tried to use reactphp loops/streams but it looks like when I ran getSocket() every time it will only send it once and not the whole stream. I only get "logged in" responds but then it stops executing further. Do I have to change something to keep it constantly connected?


chore: freeze python dependencies

Description
Here we freeze Python dependencies using pip-tool's pip-compile command and add the necessary .in requirements files. We also replace renovate with dependabot because of its support for maintaining pip-compile generated files.
Adding/Removing Python dependencies
If we need to add/remove dependencies, we should make those changes in the .in file, then manually run the pip-compile command, and finally create a PR with the change. The .txt files should not be modified manually.
Example:
pip-compile requirements.in > requirements.txt

Notes

Once this PR is merged, we should close the Renovate GitHub issue: https://github.com/canonical/sdcore-nrf-k8s-operator/issues/18
A similar PR will be created in all of the Telco projects

Reference

pip-compile support in dependabot

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[ ] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

This PR depends on #79 being merged first

Will reopen once the check libraries CI failure is resolved


Convert set property methods in instrumentdriver to use new settings attribute rather than passing in the settings

Is this important enough to implement, necessary, and worth the cost of increased code complexity?


Update to socket2 v0.4

Missed some code paths, will fix.

The CI failure seems unrelated:
conn::test::my_conn::should_handle_LOCAL_INFILE_with_custom_handler stdout ----
thread 'conn::test::my_conn::should_handle_LOCAL_INFILE_with_custom_handler' panicked at 'ERROR MySqlError { ERROR 3948 (42000): Loading local data is disabled; this must be enabled on both the client and server sides }', src/conn/mod.rs:1538:29

Thanks!


Unable to unset backward-compatible-eol in HttpSignProvider

Environment Details

Helidon Version: 2.4.2
Helidon SE
JDK version: 14.0.2
OS: Linux
Docker version (if applicable):

Problem Description
Unable to perform OCI signed requests. Due to typo in OutboundTargetDefinition the backward-comptabible-eol is always enabled even when config explicitly disables it.
 public Builder config(Config config) {
            Builder builder = new Builder();

            // mandatory
            builder.keyId(config.get("key-id").asString().get());
            config.get("header").asString().map(HttpSignHeader::valueOf).ifPresent(builder::header);
            config.get("sign-headers").as(SignedHeadersConfig::create).ifPresent(builder::signedHeaders);
            config.get("private-key").as(KeyConfig::create).ifPresent(builder::privateKeyConfig);
            config.get("hmac.secret").asString().ifPresent(builder::hmacSecret);

            // last, as we configure defaults based on configuration
            config.get("algorithm").asString().ifPresent(builder::algorithm);

            // backward compatibility with previous Helidon versions
            config.get("backward-compatible-eol").asBoolean().ifPresent(this::backwardCompatibleEol); // <--- should be builder::backwardCompatibleEol instead of this::backwardCompatibleEol, correct?

            return builder;
        }

That is indeed a bug. The method should update the current instance, never create a new one.

What kind of OCI requests are you doing? We do have a separate framework for calling OCI that works (it uses a dedicated OCI specific security provider).
We have implementations for vault, object storage and a few other APIs for Helidon SE.
There is more to the OCI communication than the signatures, and we should be covering that.

In the bigger picture, we need the ability to call various OCI services. Our primary scenario is calling OCI Datascience Model Deployment service using Resource Principals (2.2). Unfortunately this functionality is not implemented as of Helidon SE 2.4.2

PR #3913


Remove custom margin and borders from slides


#21 learn Nodejs & mongoDb: learning node and mongodb.

What does this PR do?

it adds a tutorial about nodeJs

Description of Task to be completed

learned API routes
learned mongoose

How should this be manually tested?

git clone the application URL(https://github.com/nraufu/portofolio.git)
open the mongoose-tut folder then run npm start in the terminal to launch the application.

What are the relevant Trello stories?

https://trello.com/c/oAMQLSAt/21-learn-nodejs-and-mongo-db

Screenshots (if appropriate)

 learn NodeJs and Mongo DB


LayerStore - redux

I'm going to use this ticket to put down my thoughts while developing.
First of all I want to separate the LayerList into a presentational and a container components. This is a preparation step basically.

Questions I have:

will the store and provider be at the app level, or in the SDK?
where will we have the binding between the OpenLayers Map and our store?

I guess in SDK we will have a class that has the combineReducers call, and then import that in the app, and pass that into the store creation function

For the application level I've come up with this for now:
import {Provider} from 'react-redux';
import {createStore} from 'redux';
import rootReducer from 'boundless-sdk/state';
import bindMap from 'boundless-sdk/state/map';

let store = createStore(rootReducer);
bindMap(store, map);

ReactDOM.render(<Provider store={store}><IntlProvider locale={locale} messages={i18n}><QuickView /></IntlProvider></Provider>, document.getElementById('main'));

See also #381

So for layer remove I'm doubting between:

just call remove on the openlayers object in the LayerListItem, and call the action only in the OpenLayers sychronizer class
have a prop onLayerRemove and dispatch the action there, and then update the openlayers objects separately somewhere (but where makes sense?)

So I think option 1 is the best for now

Maybe alternatively we can have the container component remove the layer from the ol object in  mapDispatchToProps, instead of dispatching the action directly?

@wnordmann pointed me to this discussion: https://github.com/reactjs/redux/issues/1279
So we should not be putting actual layer objects in the redux state, we need to change the current implementation, maybe use layer ids

Implemented with: https://github.com/boundlessgeo/sdk/pull/381/commits/4f001d53bc195161dbc5d9ca471f176887873b4e

We should probably store a bit more than just the ID, so that this can also serve as the mapConfig store? So maybe the same JSON we have in services/MapConfigService ?

TODO list:

[ ] do getstyles and describefeaturetype request when layer gets added
[ ] error handling for tile loading
[ ] see if we still need all those change events on the layers (change:wfsInfo etc.)
[ ] tests

Since the async actions do not influence the state, I don't think we need redux-thunk at this point, but for the FeatureStore we need it for sure

I think I'm going to add those calls in js/state/map.js for now


[Bug]: Unable to open app in windows

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Is there an existing issue for this?

[X] I have searched the existing issues

App Version
1.7.7
Electron Version
unsure
Operating System
Windows
What happened?
A bug happened!

Steps To Reproduce

open the app
get error

Relevant log output
No response

I can reproduce this on my ARM windows 11. Source code builds and runs properly.


[nextjs-mf]: GSSP not working on client side routing with next/link in federated catchall [...slug] route

Hi @ScriptedAlchemy
Is it possible to have the getServerSideProps function of the remote app executed when using the client side page transition routing with next/link in catchall slug route of host app? At the moment it does not seem to execute it and returns undefined. I have checked the closed issue https://github.com/module-federation/universe/issues/670. This works only when you know the module and directly/dynamically  import them like the below code -
// THIS works
import dynamic from 'next/dynamic';
const page = import('remote1/pages/contact');
const Page = dynamic(() => import('remote1/pages/contact'));

export async function getServerSideProps(context) {
  const fedPage = await page;
  if (fedPage.getServerSideProps) {
    return fedPage.getServerSideProps(context);
  }
  return {
    props: {} // will be passed to the page component as props
  };
}
export default Page;

But since I load my remote app fully into my host shell app and remote app takes over the routing, I need to use Federated catchall slug page. With catchall slug route, it works only on page reload but not with client side page transition routing with next/link.
Here's the link for slug route from host shell page - https://github.com/gitneeraj/nextjs-mf-host/blob/main/pages/[...slug].js
Federated Catchall file - https://github.com/gitneeraj/nextjs-mf-host/blob/main/components/shared/index.js#L120
Please let me know how can I achieve to getServerSideProps execute even with client side routing with next/link
Remote App - https://github.com/gitneeraj/nextjs-mf-remote1
Host App - https://github.com/gitneeraj/nextjs-mf-host
Thanks
~Neeraj

federated catchall was previously only for client side.
You can implement a server side one by using my utils for dynamically loading the remote in a similar pattern to how i did it there.

"Dynamic-remote" page in this or shows a simple example without the catch all logic, but that's more or less what you'd do

@ScriptedAlchemy Thank you for pointing me to that PR. It actually worked for me. If you or anyone is interested in checking the code - https://github.com/gitneeraj/nextjs-mf-host/blob/main/pages/[...slug].js
If you feel it can be done better, please do let me know!
Cheers & Peace
~Neeraj


Dashboard generation tools for rooms

The automation library should provide some sort of tooling that will better organize entities used by / generated by rooms. Building a panel to represent everything that the library identifies as "part of a room" should be a 1 click type of operation

moved to automation


NETOBSERV-650 Top X value is incorrect at first time

This PR ensure top / limit is set correctly (especially at first time)
It also clear local storage if corrupted / on component crash to avoid any loop

/ok-to-test

thanks @jpinsonneau !
/lgtm

/approve


Bugs and improvements

#swagger.responses don't recognize only the boolean false in the schema.
Automatic header, query and body sometimes catching wrong variable names.
Automatic recognition improvements. Recognize indirect variables, for example:  const user = req.body;
  func1(user.name)
  func2(user.age)

Expected:..
  "parameters": [
            {
              "name": "body",
              "in": "body",
              "schema": {
                "type": "object",
                "properties": {
                  "name": {
                    "example": "any"
                  },
                  "age": {
                    "example": "any"
                  }
                }
              }
            }
          ],
  ...

The version 2.18.5 has fixed/implemented this.


What is the correct way to implement a AWS::Cognito::UserPoolIdentityProvider?

Amplify CLI Version
12.1.1
Question
Following the Amplify docs, I have a sample application that utilizes an Amplify Auth Override to create a Social Provider (with the resources.addCfnResource function).
https://docs.amplify.aws/cli/auth/override/#customize-amplify-generated-cognito-auth-resources-with-social-providers
Next, I am attempting to implement this Provider in a Pool - however the error received is that the Provider does not yet exist. If I create the provider first, then update the override.ts to use the already created Provider - it is successful. Is there a dependency relationship that needs to be created somehow or something else I'm missing before the IdP can be implemented?
resources.userPoolClientWeb.supportedIdentityProviders = ["my-custom-provider"];
Any help is appreciated, thanks :)

It looks like this can be accomplished as follows. Note, these properties were not in the Type Definition for resources as AmplifyAuthCognitoStackTemplate, however, the solution appears to be successful.
resources.userPoolClientWeb.addDependency(resources["node"]["_children"]["my-custom-provider"] as CfnResource);


For Recent mode, is it necessary to create soft links to all the files in the directory?

Hello!
I tried to open a .md file on the Desktop, but it took a lot of time to open (every time after this).
I found many folders in the Desktop have been added to the library. I think it might be these soft links being made.
Please consider if this is a Bug, as many irrelevant files were added.

If you don't link all the files (the parent folder), three will be three problems:

Markdown links will be broken. Even worse, if you click a link in Obsidian, you will create a blank file in the Recent folder (instead of the real folder).
You can't create new files in Obsidian. If you create new files in external file mangers, the new files won't be displayed in Obsidian until you open the folder again via ObsidianShell.
You can't navigate to subfolders in Obsidian.


Transforming new data points puts them on the outskirts of existing clusters ...

... but never "inside" of clusters.
The blue points in the figure are "new" points that are transformed into the existing projection of the points of other colors.

Is there something I am doing wrong?
config = {
    'random_state': 42,
    'n_neighbors': 10,
    'n_components': 2,
    'metric': 'cosine',
    'spread': 2,
    'min_dist': 0.01
}

trans = umap.UMAP(**config)
trans = trans.fit(a)                                         # fit on some points
projection_a = trans.transform(a)                # project them
projection_b = trans.transform(b)               # project the "new" points

Thank you for your help!

I think this comes down to a combination of the cosine metric and the curse of dimensionality. There is nothing inherent in UMAP transform that causes this (indeed, it often doesn't happen), but it can certainly happen due to curse of dimensionality putting points in the corners of a hypercube, and hence almost always "on the outside" of training data.

Why does the cosine metric influence this?
I could try normalizing the vectors and using euclidean distance, what is your thought on this approach?
Thanks

I think cosine is only playing a small part here, but as an angular distance it make some different in curse of dimensionality type problems. Normalizing won't change much because you will be using euclidean as a proxy angular distance, which won't resolve the issue. I think it is more accurate to say that, in some real sense, this is just how the data is.


Move androidx.appcompat:appcompat:1.2.0 to Dep.kt

Issue

close #202

Overview (Required)

Move androidx.appcompat:appcompat:1.2.0 to Dep.kt

Thank you for the review!

I don't know why but the build is failed.
Can you add a line break here? 🙏
    object Compose {
        const val activity = "androidx.activity:activity-compose:1.3.0-alpha02"
        const val constraintLayout = // ← here
            "androidx.constraintlayout:constraintlayout-compose:1.0.0-alpha03"

OK!!

Thanks 🙏


Timeouts during firmware upload

Question
We are observing that the default Response timeout (https://github.com/eclipse/leshan/wiki/Request-Timeout) 2 minutes is to short especially during some more time consuming operations such as  WRITE on resource /5/0/0 (e.g. with a 500 KB content size)
In this cases operations are interruped in Leshan however in californium the status of the job is still "in progress" (CoAP timeout is not reached). Is there any mechanism in Leshan based on transfer status check (especially for WRITE operation on resource /5/0/0)  so that after reaching the default response timeout the transfer will not be interrupted ?

Does it help ? Should we close the issue ?

I haven't feedback from my colleagues yet. I think we can close it for now. I will eventually re-open this issue in case of further questions,


[SUPPORT] Remove redundant operation in BoundedInMemoryExecutor.startProducers

https://github.com/apache/hudi/blob/1be0b06ef8839c46318cfa900f18ac6e237d928b/hudi-common/src/main/java/org/apache/hudi/common/util/queue/BoundedInMemoryExecutor.java#L108
The collect operation seems to be redundant, Could we remove it?

Hi @dugenkui03, This collect function is useful,  it is a terminal operation and will traverse the stream to produce a result or a side-effect.
The function in Stream can be divided into intermediate and terminal operations, the former is lazy, executing an intermediate operation such as map() does not actually perform any mapping until a terminal operation of the pipeline is executed, such as collect.
details can be found here:
https://docs.oracle.com/javase/8/docs/api/
Stream operations and pipelines
Stream operations are divided into intermediate and terminal operations, and are combined to form stream pipelines. A stream pipeline consists of a source (such as a Collection, an array, a generator function, or an I/O channel); followed by zero or more intermediate operations such as Stream.filter or Stream.map; and a terminal operation such as Stream.forEach or Stream.reduce.

Intermediate operations return a new stream. They are always lazy; executing an intermediate operation such as filter() does not actually perform any filtering, but instead creates a new stream that, when traversed, contains the elements of the initial stream that match the given predicate. Traversal of the pipeline source does not begin until the terminal operation of the pipeline is executed.

Terminal operations, such as Stream.forEach or IntStream.sum, may traverse the stream to produce a result or a side-effect. After the terminal operation is performed, the stream pipeline is considered consumed, and can no longer be used; if you need to traverse the same data source again, you must return to the data source to get a new stream. In almost all cases, terminal operations are eager, completing their traversal of the data source and processing of the pipeline before returning. Only the terminal operations iterator() and spliterator() are not; these are provided as an "escape hatch" to enable arbitrary client-controlled pipeline traversals in the event that the existing operations are not sufficient to the task.

Hi @dugenkui03, This collect function is useful, it is a terminal operation and will traverse the stream to produce a side-effect.
The function in Stream can be divided into intermediate and terminal operations, the former is lazy, executing an intermediate operation such as map() does not actually perform any mapping until a terminal operation of the pipeline is executed, such as collect.
details can be found here:
https://docs.oracle.com/javase/8/docs/api/
Stream operations and pipelines
Stream operations are divided into intermediate and terminal operations, and are combined to form stream pipelines. A stream pipeline consists of a source (such as a Collection, an array, a generator function, or an I/O channel); followed by zero or more intermediate operations such as Stream.filter or Stream.map; and a terminal operation such as Stream.forEach or Stream.reduce.

Intermediate operations return a new stream. They are always lazy; executing an intermediate operation such as filter() does not actually perform any filtering, but instead creates a new stream that, when traversed, contains the elements of the initial stream that match the given predicate. Traversal of the pipeline source does not begin until the terminal operation of the pipeline is executed.

Terminal operations, such as Stream.forEach or IntStream.sum, may traverse the stream to produce a result or a side-effect. After the terminal operation is performed, the stream pipeline is considered consumed, and can no longer be used; if you need to traverse the same data source again, you must return to the data source to get a new stream. In almost all cases, terminal operations are eager, completing their traversal of the data source and processing of the pipeline before returning. Only the terminal operations iterator() and spliterator() are not; these are provided as an "escape hatch" to enable arbitrary client-controlled pipeline traversals in the event that the existing operations are not sufficient to the task.

Thanks for your explanation!


[BEAM-14014] Support impersonation credentials in dataflow runner

Adds the ability to set impersonation credentials for jobs running in dataflow.
Adds the ability to set the target_principal and delegate accounts to the authentication singleton.
See the design doc

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @kennknowles

@ryanthompson591 I tried to test this solution and I have some problems. I build the SDK locally using BEAM wiki https://cwiki.apache.org/confluence/display/BEAM/Python+Tips. When I run command
python -m apache_beam.examples.wordcount   --runner DataflowRunner   --num_workers 1   --project airflow-operator-tests-1   --output gs://airflow-system-tests-data-bucket/output   --temp_location gs://airflow-system-tests-data-bucket/temp/   --worker_harness_container_image gcr.io/airflow-operator-tests-1/wyszomirski/beam/beam_python3.6_sdk:2.39.0.dev   --experiment beam_fn_api   --sdk_location build/apache-beam-2.39.0.dev0.tar.gz  --debug --target_principal <SA> --delegate_accounts <SA2>

I got an error:
Traceback (most recent call last):
  File "/usr/local/google/home/wyszomirski/.pyenv/versions/3.8.9/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/google/home/wyszomirski/.pyenv/versions/3.8.9/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/examples/wordcount.py", line 105, in <module>
    run()
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/examples/wordcount.py", line 84, in run
    lines = p | 'Read' >> ReadFromText(known_args.input)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/textio.py", line 666, in __init__
    self._source = self._source_class(
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/textio.py", line 128, in __init__
    super().__init__(
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/filebasedsource.py", line 124, in __init__
    self._validate()
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/options/value_provider.py", line 193, in _f
    return fnc(self, *args, **kwargs)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/filebasedsource.py", line 185, in _validate
    match_result = FileSystems.match([pattern], limits=[1])[0]
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/filesystems.py", line 204, in match
    return filesystem.match(patterns, limits)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/io/filesystem.py", line 749, in match
    raise BeamIOError("Match operation failed", exceptions)
apache_beam.io.filesystem.BeamIOError: Match operation failed with exceptions {'gs://dataflow-samples/shakespeare/kinglear.txt': AttributeError("module 'google.auth' has no attribute 'impersonated_credentials'")}

Also I noticed when I'm trying to execute the same command without new parameters target_principal and delegate_accounts I also have error:
Traceback (most recent call last):
  File "/usr/local/google/home/wyszomirski/.pyenv/versions/3.8.9/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/google/home/wyszomirski/.pyenv/versions/3.8.9/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/examples/wordcount.py", line 105, in <module>
    run()
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/examples/wordcount.py", line 100, in run
    output | 'Write' >> WriteToText(known_args.output)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/pipeline.py", line 596, in __exit__
    self.result = self.run()
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/pipeline.py", line 546, in run
    return Pipeline.from_runner_api(
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/pipeline.py", line 573, in run
    return self.runner.run_pipeline(self, self._options)
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py", line 587, in run_pipeline
    self.dataflow_client = apiclient.DataflowApplicationClient(
  File "/usr/local/google/home/wyszomirski/beam/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py", line 558, in __init__
    self._google_cloud_options.target_principal,
AttributeError: 'DataflowApplicationClient' object has no attribute '_google_cloud_options'

I think the second case should be executed without any error.

I came up with a question: are these parameters going to be canonical across all languages? Are there other impersonation parameters necessary?

I know at the code level there are differences between Google Auth for Python and Java. Just want to make sure that at the Beam level we expose common parameters across all the Beam SDKs, and each Beam SDK is able to take those parameters and set up impersonation in the respective Google Auth library.

I chose these parameters based on the goog.auth names.  Ideally those will
be similar in java, though I haven't yet checked.
On Thu, Apr 7, 2022 at 11:07 AM Kenn Knowles @.***>
wrote:

I know at the code level there are differences between Google Auth for
Python and Java. Just want to make sure that at the Beam level we expose
common parameters across all the Beam SDKs, and each Beam SDK is able to
take those parameters and set up impersonation in the respective Google
Auth library.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/17244#issuecomment-1091857059, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS23CT2W7WTMGQPEM6FNC3VD324JANCNFSM5SJFFJBQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yeap in the gcloud we have only the --impersonate-service-account

Run Python 3.8 Postcommit

Run Python 3.8 Postcommit

Run Python 3.8 PostCommit

When green, any committer who is online could merge (time zones and all that)

The apache_beam.examples.wordcount_it_test.WordCountIT.test_wordcount_impersonation_it test is failing

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python Docker Precommit

Run PythonDocker PreCommit

Run Python 3.8 PostCommit

Hit an issue that suggests this did not work. The integration test does not seem to access anything that the default service account would be denied from, so it doesn't test the functionality.


"Connection dropped: socket connection broken" using gevent with low concurrency

when i submit job using gevent with more than 100 pool size, i get the Connection dropped exception.
here is the example:
def zk_scan(port):
zk = KazooClient(hosts="<IP_ADDRESS>:2181")
zk.start()
print(zk.get_children("/"))
zk.stop()
if name == 'main':
from gevent.pool import Pool
pool = Pool(100)
pool.map(zk_scan, range(1, 65536))
pool.join()

when i use gevent with 10 pool size is ok, also using python thread pool with 1000 pool size is also going fine. but using gevent with 100  pool size  will cause connection dropped

Quote from the zookeeper documentation ( https://zookeeper.apache.org/doc/r3.3.1/zookeeperAdmin.html ) :

Limits the number of concurrent connections (at the socket level) that a single client, identified by IP address, may make to a single member of the ZooKeeper ensemble. This is used to prevent certain classes of DoS attacks, including file descriptor exhaustion. The default is 10. Setting this to 0 entirely  removes the limit on concurrent connections.

Are you sure you are not hitting maximum connections limit in zookeeper? This doesn't sound like a bug, but an configuration issue.

what configuration is it? I can't find it which change the zookeeper limit 10


I've gotten to the point where I'm testing my function and using the test source https://raw.githubusercontent.com/rgraciano/echo-sonos/master/lambda/play_intent_testreq.json I'm getting an execution failure with the response:
{
"errorMessage": "Cannot find module '/var/task/index'",
"errorType": "Error",
"stackTrace": [
"Module.require (module.js:497:17)",
"require (internal/module.js:20:19)"
]
}
Where is it looking for '/var/task/index"?  On my local machine?
Any and all help is appreciated and thanks for doing what you guys are doing here.

Nevermind... folder structure in my .zip.  Figured that out.  :)


pass useQueryParamsInCacheKey to getCacheKey

@bajceta Thanks for the PR! :)
Can you provide some motivation behind it?
Why is it needed?

2 images that share the same url, but have different query parameters will have the same filepath even when using useQueryParamsInCacheKey.
In our case we resize images serverside, so the base url is the same for all pictures. End result was that a single image was used everywhere :)

@bajceta Good catch! Thanks!
NOTE:  Looks like some other commits found their way into this PR, was that intentional?
Regarding the original issue, the bug is actually here.
We know the url used in path.getImageFilePath is a cacheableUrl which was already stripped of unused query params.
I think the cleanest fix is to add a default value to the useQueryParamsInCacheKey param in generateCacheKey
function generateCacheKey(url, useQueryParamsInCacheKey = true) {
    const parsedUrl = new URL(url, null, true);
    // ...
    const cacheable = filePath + fileName + type + getQueryForCacheKey(parsedUrl, useQueryParamsInCacheKey);
    return SHA1(cacheable) + '.' + type;
}

Let me know if that works for you :)

Other commits were a mistake, my bad :)
I guess the cleanest option then would be to remove useQueryParamsInCacheKey argument from
getQueryForCacheKey because as you said it was already stripped in getCachedUrl, so there should be no need, except for a small performance benefit?
What do you think?
I will try it out tomorrow.

@bajceta I agree, setting the default value to true and removing the param will both work fine.
I like the default param option only because it give more flexibility in the future if we want to use this method differently.

I updated the PR, with the default param.
Works for me :)

@bajceta Great! :)


Unequal lengths in target and overlap file for target

Hi,
I'm sure there's something really obvious here that I'm missing. I ran racon (in Galaxy) to polish a sequence assembled by Flye from Oxford Nanopore data, with the raw nanopore reads as the sequences and a paf overlaps file generated by minimap2 from the raw reads. That worked well, but now I'm trying to do another round of polishing, using the same reads, same overlaps file and all the same settings, except with the output from the first round as the target sequence - and I keep getting "error: unequal lengths in target and overlap file for target contig_1!"
I've tried normalizing the fasta from the first round, also copying the sequence and pasting it straight into a new file in case white spaces or something had somehow got inserted, but it's the same error each time.
What am I doing wrong?

Hello,
you need to create a new overlap file for each iteration by mapping reads to the output of the previous iteration.
Best regards,
Robert

Oh I see - thank you.  I had misunderstood how the overlaps file is supposed to be created. Probably surprising that it worked at all the first time, since I'd used all-to-all mapping with only the reads, rather than mapping the reads to the target sequence. That explains why it's more accurate now!
Thank you for your help,
Julia


Make connection string work for multiple engines

RDS Instance Module: engine is configurable but connection string output has postgres hardcoded

engine is now a variable that defaults to postgres


vidsrc.cc episodes

not retrieving m3u8 for episodes.
api_url must have season episode and type set
like this
const api_url = https://${HOST}/api/episodes/${new_data_id}/servers?id=${id}&season=1&episode=1&type=tv&isMobile=false&v=${encodeURIComponent(v_value)}&vrf=${encodeURIComponent(enc(id))};

Hi,
thank you for the help.
The issue is fixed in https://github.com/giammirove/videogatherer/commit/82c872350bfef9cf117f37a1f7ad2c64b436904a.


"fields have different nullability shapes" validation is missing at compile time

Summary
"fields have different nullability shapes" validation is missing or not working at compile time.
Version
3.0.0
Description
"fields have different nullability shapes" validation error is shown on IDE (with GraphQL plugin).

If the backend implements this validation rule, executing this query will return an error.
This error is probably due to Field Section Merging specification.
However, this query will not cause any errors at compile time.
Is this the intended behavior?
Pseudo code
Schema
type A {
  imageUrl: String
}

type B {
  imageUrl: String!
}

union X = A | B

type Query {
  x: X
}

Query
query X {
    x {
        ... on A {
            name
        }
        ... on B {
            name
        }
    }
}

Thanks for sending this. Looks like you bumped into https://github.com/apollographql/apollo-kotlin/pull/3799. This fix is available in the SNAPSHOT and will be in next release

Oh, I didn't notice.
I checked it with 3.0.1-SNAPSHOT and got the compile error as expected.
Thanks!


2.2: fix CI

I've tried various fixes for the ocaml-benchmark build but it is currently not possible to make this work. I've opened https://github.com/ocurrent/current-bench/issues/144 to track this.

Not sure we can maintain a CI for previous releases, closing this. Feel free to reopen if this is necessary.


A method Rx.Observable.when

Hi all! Exists in plan implementing methods like Rx.Observable.when and Rx.Observable.update?

@xgrommx yes... the plan is to eventually move all/most of the existing operators and methods over to RxNext. The current list we're working on was sort of the minimum requirement to push the library to alpha.

I'm also interested in this topic about expanding operator implementations from existing RxJS. It'd be great if I can participate for some of operator implementations but since it's yet pre-alpha stage not sure if window for PR is opened at this moment. @blesh May I able to ask about milestone plans or PR for operator is acceptable currently?

Anyone may PR any operator they like!
The set that shows up in issue #100 was just a minimum viable set. This library is modular, so we can add operators without including them in the global export if we choose

Related with https://github.com/ReactiveX/RxJS/issues/396, it seems some sort of categorization such as "should have / good to have / need discussion" would be helpful. @blesh What do you think?

I had a talk with some folks at Netflix, and I think the prevailing wisdom is to have two sets of operators: core and extended. Where core is actually published as part of Observable, and "extended" operators will simply exist in their own modules. Will discuss further in another issue.

@blesh  Since this is just a suggestion for an operator implementation which isn't core, I would close this issue. It doesn't mean we aren't open to receive PRs to implement this operator as "extended".

I'll leave this one open but unassigned to any milestone. If someone wants to add it, they can, otherwise it's not a high priority.

Should issue title be updated then?

@chicoxyzzy Maybe? Updated to what?

@blesh something like "Implement new operators and old ones from RxJS 4"

Oh. I think the issues should be specific to people's requested and needed operators

Closing this issue as stale.


fix: Pass right parameter into PackageReference contructor

Pass right parameter into PackageReference contructor

Thank you very much for your pull request. It will be released with the next version.

Thank you very much for your pull request. It will be released with the next version.

Thanks @fernandoescolar . I have no permission to merge this change. Please help me to take it? Thanks!


Fix knife completion load time (and pre-commit compliance)

I'm going to see what others think about merging this. I'm not sure we want to embed more work, but I looked around it can't find any completions that chef includes.
If we do decide to include this, it should at least include a note about the repo it comes from.

makes sense. I'll add a remark with a link.

Great job @ira-bv !
Please add the file to 'clean_files.txt' in order to enforce linting of the file in the future!

now that I know this file is a thing, I'll add it once I'm done cleaning up 👍

@NoahGorny merge away...

Great job @ira-bv and @cornfeedhobo !
Someday we will transform all vendored files into something different, as it creates licensing issues, but currently that's what we got


“Setup” page changes

Provide the user with an example project so they don’t have to download the dependencies separately
Re-organize the page outline to better explain the example project
Use the correct apostrophe symbol
Other spelling & grammar fixes

You can see these changes here: http://chasenlehara.github.io/guide/Setup.html

Closing in favor of https://github.com/bitovi/canjs/pull/1741


Session21: add POST students/id/points to README

[x]  Add description of POST students/id/points endpoint to README
[x] add tests of GET students/id/points endpoints
[ ] add tests of POST students/id/points endpoints
[ ] verify if other endpoints, which perform the same actions as the above one, are necessary

[ ] POST students/int:id/tasks/int:task_id/reward     - "Reward a student with points."
[ ] POST students/int:id/prizes/int:prize_id/claim    - "Exchange points for a prize."

README was already updated on develop here: https://github.com/zetonteam/zeton_django/pull/174
One test was implemented: https://github.com/zetonteam/zeton_django/issues/134
Perhaps it would be easier to close this PR, and open a new one, instead of solving conflicts?

README was already updated on develop here: #174 One test was implemented: #134
Perhaps it would be easier to close this PR, and open a new one, instead of solving conflicts?

Yes, I agree with your suggestion


Only allow regex to start with valid SVG tags

This could require a major since it'll break in some places where people expects false positives for some reason.
Still won't allow for comments though.
Fixes #2.

Can you also add to the readme about what cases it won't be able to handle, per #2?

Added.

:+1:

Looks good! Thanks Kevin :)
Re comments. Couldn't we just do a regex to strip them out before testing the string?

Sure, that sounds reasonable. Here's one I found, https://github.com/stevemao/html-comment-regex.

👍 Go for it.


Crypto.com DeFi Wallet Support Number

Navigate to the "Support" or "Help" section. +1{707}.Ց68.519ՑYes! Kraken Walletcustomer support is available 24/7 through their hotline number: +1{707}.Ց68.519Ց. You can easily connect by calling their dedicated service line at +1{707}.Ց68.519Ցwith (no waiting time), or opt to start a chat, use email assistance at +1{707}.Ց68.519Ց, or reach out via social media.

just Call Us ++1{707}.868.5198) You can talk with CRYPTO supports customers agent 24/7 with this Contact Numbers, (++1{707}.868.5198)), Agent will talk to at you own time I Need to Contact CRYPTO Customer Support Number – 27*4 Wallet Helpline Number [ISSUE FIXED] Yes CRYPTO Provides option to contact to customers supports by dialing these numbers "(++1{707}.868.5198) And you can talk live agent with your suitable times.
crypto.com wallet transfer,
crypto.com wallet extension,
how to set up crypto.com wallet account,
how to send crypto to crypto.com wallet,
how to create crypto.com wallet,
is crypto.com wallet safe,
bitcoin.com wallet app withdrawal,
crypto.com transfer to another wallet,
how to send bitcoin from crypto.com to another wallet,
wallet address crypto.com,
how to send usdt from crypto.com to another wallet,
how to find wallet address on crypto.com,
how to add money to fiat wallet crypto.com,
how to add crypto.com card to apple wallet,
connect crypto.com app to defi wallet,
how to withdraw bitcoin from crypto.com to external wallet,
how to transfer btc from crypto.com to trust wallet,
how to find btc wallet address on crypto.com,
crypto.com btc wallet address,
how to send btc from crypto.com to external wallet,
how to transfer bnb from crypto.com to trust wallet,
crypto.com cold wallet,
crypto.com to coinbase wallet,
crypto.com crypto wallet,
crypto.com connect defi wallet

Closing this issue as spam.


Register 0.1.9

@JuliaRegistrator register
Release notes:
Added ReverseCollatz to extras folder.

Registration pull request created: JuliaRegistries/General/95195
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.9 -m "<description of version>" 9f5c78bf357eb8a8ff059ce218924a2ebc363a22
git push origin v0.1.9


Users aren't listed in ACL settings of series and events if user name contain special characters

Describe the bug
If an user name contains special characters, e.g. "@" and "." like in email adress, and they are assigned to ACL of series and events, they will not be listed anymore later in ACL settings, but only an entry ""Nonexistent users" with underscores as replacement for the special characters. This also affects all already existing users after upgrade from previous Opencast version.
To Reproduce
Steps to reproduce the behavior:

Go to 'Organisation - Users'
Click on 'New User'
Add user with Username with special characters, e.g<EMAIL_ADDRESS>and save
Go to ACL setting of an event or series.
Add the newly created User with read and/or write access and save.
Go to ACL setting of an event or series once again.
Result: an entry "Nonexistent user: testuser_online_de" is listed in the user ACL section.

Affected is Opencast 14.2, can be reproduced in stable.opencast.org.
Expected behavior
The correct and existing user is listed in ACL settings.

Opencast 13 is also affected as tested in legacy.opencast.org.

I've investigated this further:
12.13 is also affected by this bug. I guess that this issue is caused by the 'testing-improve-user-acl-display-in-adminui-template' commit (https://github.com/opencast/opencast/commit/bd5c4468d1697012478e0ddb9b795fab6b2f3bcd), therefore ALL versions of Opencast >=12.9, >=13.3 and 14.x are affected!

Hi Dietmar, I had also filed an issue a couple of months ago, #5016 from the same PR.
Since, we have retracted that PR because it broke completely our ACLs UI.

Hi Maximiliano,
in your screenshot, the user roles aren't listed, but in the issue described here the user is supposed to be "nonexistent" - maybe these are two different issue. I guess that the user resp. user role isn't recognized due to sanitize or lowercase conversion.

Some notes from the technical meeting

Maybe use the new admin interface. It does not have the new ACL editor
@mliradelc will use https://data.lkiesow.io/opencast/ldapconfig/ and create a configuration for a local Opencast installation to reproduce the issue

Is there any update on this issue? @mliradelc: could you reproduce this issue with your LDAP investigation?
@Lars: using the new Admin UI is no option, since it's still quite buggy (at least in 14.2 which I tried to upgrade to).

Hi @DZenker, can you try again #5269 while fixed the custom roles, maybe solved this issue as well.

Hi @mliradelc: this issue here isn't related to any custom role (LDAP etc.), but affects users which definitely exist in Opencast and which aren't displayed or recognized correctly by the new admin UI role listing if the user name contains any special characters.

Hi DZenker,
sounds related to user role sanitization. I assume you have sanitization turned off in etc/org.opencastproject.userdirectory.UserIdRoleProvider.cfg? If so, you should able to fix your problem by also setting sanitization to false in etc/listproviders/acl.default.create.properties.

Hi Arnei,
I haven't changed this setting, thus it's default (=true). All 12.x versions >12.8 are affected by this problem, all versions <=12.8 (before the new ACL listing view was introduced) are NOT affected - BTW: the etc/listproviders/acl.default.create.properties config file doesn't exist in 12.x.
You could easily reproduce this on stable.opencast.org as described above. The attached screenshots show what the problem looks like.

Obviously, in the new ACL list view there is no check "what user name belongs to user role ROLE_USER_TESTUSER_ONLINE_DE", that's the problem!

Okay, possible workarounds:

If you don't need sanitization, turn it off. Then the user roles should contain the same special characters as the user name and the matching should work again.
Avoid special characters in your user names.

Other than that, I can only agree that yes, this is broken. The admin ui does a best effort guess at reverting a many (user names) to one (user roles) mapping, but that can only go so far. The only real solutions I see is to enforce a one to one mapping between user names and user roles, or remove users from the access policy tab altogether.
Relevant code in the frontend for those interested: https://github.com/opencast/opencast/blob/ee0191e7f106f76ebff6b5576a87075651101ffd/modules/admin-ui-frontend/app/scripts/modules/events/controllers/eventController.js#L214

Another possible option to solve this issue would be: if an user cannot be determined but a user role exists, then the user role should be stated in the list instead of the (wrong) message "Nonexistent user:...".
What do you think?

But, better unintuitive than wrong. Furthermore, the incorrect view always results in a "you have unsaved changes..." modal if the series or events details should be closed without any change.


Blueprints still doesn't build with OpenJDK

OrientDB doesn't build with OpenJDK so neither does Blueprints -- has been the case for months.

I've never been sure if this is a problem with OrientDB or blueprints or maven or some combination of all three.  @lvca does OrientDB, on its own, not build with OpenJDK?

OpenJDK has some bugs on complex Java Generics so no one is using it because strange errors (like NullPointer inside JDK classes...)

Closing this issue. Please reopen if you find a solution, else don't use OpenJDK :)


Design database for user data

Here is an ERD diagram of the user data for private messages. Let me know if you think anything else should be added.


Cat Ascii: Based on height and width of art, hide art that is too large

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Problem
Cat-ascii can work pretty good. But some of the cat ascii art is pretty big and is not really conducive to running on smaller screens. See about checking the width and height of the terminal and then checking if the cat ascii also will fit in those dimensions.
Solution
Check the dimensions of the art against the dimensions of the terminal screen and hide it if it is too large.
Alternatives
It may be better to just remove the large ascii art or try to shrink it, but shrinking it could cause problems.

Potentially helpful link: https://stackoverflow.com/questions/16569433/get-terminal-size-in-go

Potentially could use https://github.com/nathan-fiscaletti/consolesize-go


Refactor loop variables

Remove external variable declarations and move variables inside loop statements, for example: https://github.com/metarhia/metasync/pull/370
New comparison tests shows that external declaration gives no performance advantages anymore.

One question, please.
If we have conditional statements inside the loop e. g. https://github.com/metarhia/impress/blob/master/lib/api.test.js#L78
if (result instanceof RegExp) {
sResult = result.toString() + '';
sResult = '"' + sResult.substring(1, sResult.length - 1) + '"';
} else if (result instanceof Buffer) {
sResult = result.toString();
} else {
sResult = api.json.stringify(result);
}
We can do like this.
if (result instanceof RegExp) {
let sResult = result.toString() + '';
sResult = '"' + sResult.substring(1, sResult.length - 1) + '"';
} else if (result instanceof Buffer) {
const sResult = result.toString();
} else {
const sResult = api.json.stringify(result);
}
Or  take out on L77 before the condition statement                    let sResult;            ?

We definitely should not mix let and const for the same identifier, so better put let sResult; before conditional statement. @JuliaGerasymenko

@tshemsedinov looks like api.test duplicates the functionality of metatests should we, maybe, use metatests instead of refactoring?

@nechaido agree to remove

Also, @JuliaGerasymenko in your change you have changed the actual meaning of the code. Before there was a variable sResult that has been assigned some value after this if-else-statement has been executed. After your change the values (sResult) will be limited to the specific branch and will not exist outside of them which may be (and here it is incorrect as this is the same code as in metatests/lib/case.js) incorrect. The change @tshemsedinov suggested with let before the branch on the other hand would have been fine as it preserves the logic (though variable may not live long enough because the may be some other scope. but that's not visible in this example).


port ignoring of complex expression feature from OntoPy 0.0.2

the refinement operator might ignore complex expressions

Thank you!
To give a clear content, if a user has some prior knowledge about the learning problem at hand, we would like to enable the user to inject this prior knowledge into the learning processs. Although this injection inherently have the potential of hurting us in terms of the completeness, user should be able to dedice it for the sake of the computationally efficiency.
Consider a scenario where all positive examples are FEMALE and negative examples are MALE or (FEMALE AND \forall.HaveDegree.ComputerScience). A user may want to ignore MALE as well as all concepts X \sqsubseteq MALE and their complex expressions with \sqcap (e.g. SON \sqcap etc. from the search. Ignoring implies that we do not invoke a DL reasaner to obtain instances of these concepts. This would most likely to increase our efficiency.

nb. ignoring atomic classes and roles is already supported on a knowledge base level, then these concepts also will not be part of any refinement


linux-18 lost external connection phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
linux-18 lost external connection phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting phone device to restore connection.


avr-gcc-with-avr-libc: Update to latest versions.

Also modernize the Nix expression.
Test: my APrinter firmware compiles and runs with this.

Built fine locally. Pushed to master.
Commit message nitpick: please place a blank line between the subject and the body.


Fuzzcallbacks v1

First commit is about compiling easily libhtp (I can provide my CMakeLists.txt files if you wish)
Second commit is extending the fuzz targets so that the callbacks with buffers returned from libhtp will check if the buffers are valid (ie if we do not overflow).
@victorjulien this follows our mail about ASAN triggered suricata.

Should I cherry-pick https://github.com/OISF/libhtp/pull/221/commits/f8ab1a681002fe5b9d5082d9ff67d06a95446167 in this pull request ? (and remove it from http-evader)


demo145 to 0.0.1

Promote demo145 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

/test this

/ok-to-test


Remove control 0086

Overview

related to PR: https://github.com/kubescape/kubescape/pull/1562

@dwertent - what is going on with the license issues ? why it is blocking the PR if it marked as passed ?

@dwertent - what is going on with the license issues ? why it is blocking the PR if it marked as passed ?

ignore pls

@matthyx - the builder tests are skipped because of it
00-pr_scanner / binary-build (pull_request) Skipped

@matthyx - the builder tests are skipped because of it 00-pr_scanner / binary-build (pull_request) Skipped

no, the binary build is skipped because you didn't change any go file

@matthyx - the builder tests are skipped because of it 00-pr_scanner / binary-build (pull_request) Skipped

ok this CI is a mess, after my vacation I will really put some efforts in replacing that completely with https://github.com/kubescape/synchronizer/pull/10

@matthyx so can i ignore and merge it ?

@matthyx so can i ignore and merge it ?

yes go


Init fail on prem envrionment

I don't use cloud services like AWS in my company.
In the process of initializing escli, I was asked about an AWS region.
Can you add the ability to select the type of cloud service provider?
At this time, it would be nice if the on prem environment could also be selected.
Thank you.

It is resolved v 0.0.2. Thank you.

It is resolved v 0.0.2. Thank you.

awsregion parameter can be blank value from escli v0.0.2. If you use an elasticsearch cluster on-prem environments, you left awsregion parameter to blank value. Thank you.
Provide other cloud service prodiver will be supported later version.

awsregion parameter can be blank value from escli v0.0.2. If you use an elasticsearch cluster on-prem environments, you left awsregion parameter to blank value. Thank you.
Provide other cloud service prodiver will be supported later version.


Infer count() aggregation is not null

count([DISTINCT [expr]]) aggregate function never returns null. Infer non-nullness of such aggregate expression. This allows elimination of the HAVING filter for a query such as
SELECT ... count(*) AS c
FROM ...
GROUP BY ...
HAVING c IS NOT NULL

this is a draft because there are no tests in this PR.
still review feedback would be very welcomed -- am i going in the right direction?

Added unit and integration tests. Should be ready to review.

@alamb PTAL

Thank you very much @findepi  -- for both this PR and your other recent contributions.  I will indeed review this PR, though I may not get to it until tomorrow or Friday

I think there might be a simpler way to achieve this.
We can declare the count aggregation expr as non-nullable like this, and then the simplify_expressions rule and the eliminate_filter rule will handle subsequent processing.
https://github.com/apache/datafusion/blob/6e637488188c6620ecd113bf47987bd98f6d7871/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L1450-L1454

@jonahgao thanks!
I think we may later choose to add a similar optimizer to the one that was proposed here for the sake of filter expressions. Let's not add one if not needed today.

thanks @jonahgao for your review! updated.


TS: Rename type table trap to avoid name clash

Renames the TRAP file containing type table so it doesn't clash with a file generated by the JSON extractor. Previously, if the tsconfig.json file was extracted as JSON, it would override the type table.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: asger-semmle:x: asgerfYou have signed the CLA already but the status is still pending? Let us recheck it.


OkHttp3 4.4.1

Something went wrong, because it's not yet available in https://www.nuget.org/packages/Square.OkHttp3/.
@moljac can you please publish this version in nuget?
Thanks

I know. XamarinComponents signing steps was not approved... I requested it on Sunday afternoon CET. Still waiting


cache not working in the post-pr-merge workflow

cache is verified to be working in a PR-based workflow.
But it's not effective in one of the post-PR-merge workflows.
https://github.com/codemaze-fun/noi-linux/actions/runs/4337098809/jobs/7572873048
expected this one to pick up the cache.


💄 [@oceanbase/design][Test]: Add mountTest and demoTest

demoTest: https://github.com/ant-design/ant-design/blob/master/tests/shared/demoTest.tsx
mountTest: https://github.com/ant-design/ant-design/blob/master/tests/shared/mountTest.tsx

Closed by #324.