Intermittent RPC errors with message: "Unknown error invoking RPC"

Description

sent deployment transactions

[Request ID: ed2b0630-b17d-4e64-82e8-f7aea3196f82] Unknown error invoking RPC
[Request ID: 960839a7-76c3-4781-83d0-7345ce2e04d7] Unknown error invoking RPC
[Request ID: b916dea1-c3b4-4888-af04-a75378510a54] Unknown error invoking RPC

sent RPC requests to read data from a deployed SC

[Request ID: af5b1adf-8e0a-4792-b847-ca6328d21511] Unknown error invoking RPC

Steps to reproduce

send multiple deployment transactions of the exact same smart contract using ethersjs
send multiple read transactions (exact same ones) using ethersjs
observe that some fail while some pass, intermittently

Additional context
No response
Hedera network
testnet
Version
ethersjs v5
Operating system
macOS

Hey @bguiz are you trying to perform batch transactions? Can you provide some code snippets ?

 Can you provide some code snippets ?

nope @georg-getz - I'm actually doing individual transactions. EVM transactions with EVM accounts (not the Hedera-native type)

Closing this, as unable to reproduce in after last week's network upgrade


fix v1.19 download link

Upgrade to kubernetes version 1.19 the download link for crictl was broken

How it is broken?
$date; wget  https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.17.0/crictl-v1.17.0-linux-amd64.tar.gz
Tue Nov 10 12:09:03 EET 2020
--2020-11-10 12:09:03--  https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.17.0/crictl-v1.17.0-linux-amd64.tar.gz
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/80172100/dbf13000-200a-11ea-9e4a-7b34ab8cd6aa?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20201110%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20201110T100903Z&X-Amz-Expires=300&X-Amz-Signature=9133c222e56e010f60e2f7c30dcdc8113733017b0802e5c551dee364e1ad2722&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=80172100&response-content-disposition=attachment%3B%20filename%3Dcrictl-v1.17.0-linux-amd64.tar.gz&response-content-type=application%2Foctet-stream [following]
--2020-11-10 12:09:03--  https://github-production-release-asset-2e65be.s3.amazonaws.com/80172100/dbf13000-200a-11ea-9e4a-7b34ab8cd6aa?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20201110%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20201110T100903Z&X-Amz-Expires=300&X-Amz-Signature=9133c222e56e010f60e2f7c30dcdc8113733017b0802e5c551dee364e1ad2722&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=80172100&response-content-disposition=attachment%3B%20filename%3Dcrictl-v1.17.0-linux-amd64.tar.gz&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... <IP_ADDRESS>
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 12436234 (12M) [application/octet-stream]
Saving to: ‘crictl-v1.17.0-linux-amd64.tar.gz’

crictl-v1.17.0-linux-amd64.tar.gz                                      100%[============================================================================================================================================================================>]  11.86M  3.12MB/s    in 4.2s

2020-11-10 12:09:08 (2.85 MB/s) - ‘crictl-v1.17.0-linux-amd64.tar.gz’ saved [12436234/12436234]

/invite @danielfoehrKn

broken was the wrong word. My first change broke it.
I want to recommend with the update to kubernetes 1.19 to update to the latest release of crictl.
https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.19.0

was a wrong version number, my typo :-)

Is there a reason why crictl is included explicitly for chost?


Create Commons License

During the CloudNativeCon keynote, @dankohn mentioned a Creative Commons license, but the current license file looks like Apache 2.0

Updated the Readme to link to it. Thanks.


Drop repo

This repo is redundant.  It should be dropped in favor of www.openstreetmap.org and other APIs such as mapbox.com, https://market.trimbledata.com 💯

I'm not sure how we could replace this repo with one of those API's.
OpenStreetMap is an API for feature data, not imagery assets, and afaik there's no way to use it to refer to an image online and then search for it.
Mapbox.com has a number of API's, but none do search of imagery. The tilesets and datasets api's are perhaps the closest match, but they are more about returning particular datasets in a single account, they don't offer cross account search - like searching for all of the imagery that people have uploaded to mapbox. The rest of their API's are more about styling, directions, geocoding, etc. I do really like the MapBox API's, and they sent some people to the last in person meeting, and are interested in using the spec to consume satellite imagery.
I hadn't seen the trimbledata market API, it definitely looks the most similar. I'm not sure how we would just adopt it. The point of this repository is for various vendors to come together to figure out what's in common between their approaches. I'll reach out to trimble as it would be great for them to collaborate on a more standard API with us.
Vendors like Planet, DigitalGlobe, Boundless, Azavea, Google, Amazon, etc. are all coming together to collaborate on achieving interoperability on imagery search between their different ways of doing things. If there is another effort underway that is aiming at the same goals it would definitely be great to combine efforts.


Change public directory to project directory

Just an idea, i think it could simplify developing.

Cumbersome as it may seem, this is actually a good habit to get into, as most modern web frameworks use a similar file structure (Ruby on Rails, Ember.Js, etc.) The idea is that you (the superuser) always want to be able to go a directory above your website root - for instance, if you want to save backup archives or database dumps on the server - so you can make other folders that people can't access by typing www.mysite.com/backups/ or whatever.
Also, in the abovementioned frameworks & others, you generally work on a bunch of different files that get "mixed down" into a single three-file package (website.html, website.js, website.css), the way an entire 128 track recording session gets "mixed down" into a single stereo audio track for the CD. You as a builder need a lot more room to work than the website visitor, and the /public/ folder is where the build process spits out the compressed "final mixes" for fast, easy downloading.


linux: run the ollama system service as the current user

Run the ollama system service as the current user

resolves #613

This leaves around /usr/share/ollama/.... Do we want to keep that?

Removed the old ollama models directory, leaving the public key just in case.


JanosMathe.HardDiskSentinel version 6.20

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Possible duplicate package entry.
Similar installer SHA256 hash found in manifest:

InstallerSha256: 3ac9b9d5230d151d559344b0c8e40c94b6ae8b5be97678a6ad033c1ca5718ecf

manifests\h\HDSentinel\HDSentinel\6.20

Verify by hash.

This is probably the same situation as with https://github.com/microsoft/winget-pkgs/pull/166939


HNC: Deleting a subnamespace after creating resources in the parent namespace results in error

The following sequence doesn't work:

Creating a subnamespace by creating a SubnamespaceAnchor resource (the name of the parent ns is hnc-try, and the name of the subnamespace is hnc-try-sub-1).
Creating some RBAC resources in the parent namespace (role + rolebinding).
Deleting the SubnamespaceAnchor resource.

The subnamespace gets stuck in the middle of deletion, and I see the following log:
{"level":"info","ts":1600856582.4537065,"logger":"validators.Object","msg":"Handled","nm":"","resource":{"group":"rbac.authorization.k8s.io","version":"v1","resource":"roles"},"nnm":"hnc-try-sub-1","op":"DELETE","allowed":false,"code":403,"reason":"Forbidden","message":"Cannot delete object propagated from namespace \"hnc-try\""}

By adding some logging to the validator, I got that the username which issued the AdmissionRequest is system:serviceaccount:kube-system:namespace-controller. However, this user isn't exempted from the webhook, and only system:serviceaccounts:hnc-system is exempted. So the AdmissionRequest isn't automatically allowed, and then it is rejected as the resource has the label hnc.x-k8s.io/inheritedFrom: hnc-try (hnc-try is the name of the parent namespace).
I would suggest to exclude the same service accounts as atlasian excludes:
https://github.com/atlassian/voyager/blob/11ade5a733008770a7df4b12aee2399dc2af5d12/pkg/admission/server.go#L61
Environment
Kind version:
kind v0.7.0 go1.13.6 linux/amd64

Kubernetes version:
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2020-01-14T00:09:19Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Operator version - v0.5.2

Thanks for the bug report. I'm looking at this now at high priority (I have an idea what the cause is) and hopefully can push out a release with a fix tonight or tomorrow.

Whoops I missed the fact that you identified exactly what the cause is :) That seems like a good solution, I'll go with that. Thanks!

This doesn't appear to affect full namespaces. The reason seems to be that as the K8s controller deletes all the objects in the namespace, it also deletes the HierarchyConfiguration object, which orphans the namespace and hence deletes all propagated objects.
But for subnamespaces, even though the HierarchyConfiguration object is deleted, HNC knows right until the end that the subnamespace is a child of the parent, and so it never allows the object to be deleted.

Reproduced this with a simple e2e test

A short-term workaround is to remove the subnamespaceOf annotation in the subnamespace prior to deleting it directly. However, this requires higher privileges than should be required to deal with namespaces.

I've found a cleaner and more minimal fix for v0.5 (#1139), triggered by the fact that this only affected subnamespaces and full namespaces. Basically, we were preventing subnamespaces from being orphaned as K8s deleted their hierarchical configuration; by allowing them to be orphaned, all objects are removed naturally.
With that said, it's generally a good idea not to fight the K8s controllers (it's so annoying when you can't finish deleting a namespace), so I've filed #1140 to address this.

Fixed in v0.5 and master.
/close


twister: refine the twister test plan generation

(This patch is a refined version of https://github.com/zephyrproject-rtos/zephyr/pull/46052 to cater for recent twister refactoring.)
Due to the diverse coding styles and lack of preprocessing when
scanning for test cases, there are many unintended combinations
of yaml test scenarios and C test functions with the regex-based
test case discovery, which caused an inaccurate test plan and test
result stats.
This patch addresses this issue from 3 perspectives. And the
zephyr.symbols file is used as a reference.

remove the false test cases introduced by the regex-based
test case discovery
add the ones missed by the regex-based discovery (only for new
ztest fx)
adjust the stats logic

If regex-based discovery and old ztest fx are deprecated, 1) will
do nothing and test case discovery will be done solely by 2).
Because the zephyr.symbol is available only after build, the above
actions 1) and 2) are put right after the build stage of the pipeline
and before runtime test case collection happens.
For those test instances that don't go through the build stage,
such as those with "Skip filtered" reason before entering the pipeline,
they are not affected.
The stats logic also needs to be adjusted because the zephyr.symbols is
generated after build. So ExecutionCounter update is splitted and some
must be postponed until test execution is complete.
A test instance = a yaml scenario + a platform
"Test instance" and "test config" are synonyms in twister, unfortunately
excessive IMHO...
A test instance  can be filtered or skipped in 3 ways.
Let's define "runtime" as "after entering the execution pipeline".

static filterd (before runtime)
Such test instance is filtered by analyzing the yaml and never
enter the execution pipeline.
cmake filtered (runtime)
Such test instance enters pipeline and is filtered at cmake stage.
build skipped (also runtime)
Such test instance enters pipeline and is skipped at build stage.

All the test instances that enter the execution pipeline will go
through the report stage, where ExecutionCounter is updated accordingly.
The meaning of the fields of ExecutionCounter are:
.skipped_configs = static filtered + cmake filtered + build skipped
.skipped_runtime = cmake filtered + build skipped
.skipped_filter = static filtered
.done = instances that enter the execution pipeline
.passed = instances that actually executed and passed
Definition of the overall stats:
total_complete = .done + .skipped_filter
total = yaml test scenario * applicable platforms
complete percentage = total_complete / total
pass rate = passed / (total - skipped_configs)
Signed-off-by: Ming Shao<EMAIL_ADDRESS>

I forgot to change one variable name in the runner.py in last force push. But it still passed all the CI tests. Amazing...

Made chagnes and updated the commit message to reflect what's going on.

Compared with the old test plan with below command:

twister -p native_posix -T tests/lib/cmsis_dsp/matrix/ -vv

With the old test plan generation:

With the new test plan generation:

We can see a lot of false test combination are identified. They are like below:
{
    "identifier":"libraries.cmsis_dsp.matrix.unary_q7.arm_mat_solve_upper_triangular_f32",
    "execution_time":"0.00",
    "status":"skipped",
    "reason":"Test case not belong to the test scenario"
},

And also, with this PR, the No status messages like below can be eliminated.

@asemjonovs can you take a look too?

Further tested with below commands.
The numbers of the same color match.

twister -p qemu_cortex_m3 -T tests/lib/cmsis_dsp/matrix/

twister -p qemu_cortex_m3 -T tests/lib/cmsis_dsp/matrix/ -vv

Codecov Report

Merging #49619 (1bbe209) into main (2829de7) will increase coverage by 2.35%.
The diff coverage is 52.25%.

:exclamation: Current head 1bbe209 differs from pull request most recent head 0831fb9. Consider uploading reports for the commit 0831fb9 to get more accurate results

@@            Coverage Diff             @@
##             main   #49619      +/-   ##
==========================================
+ Coverage   48.02%   50.37%   +2.35%
==========================================
  Files         521      675     +154
  Lines       74501    84840   +10339
  Branches    17870    19997    +2127
==========================================
+ Hits        35777    42740    +6963
- Misses      32573    34939    +2366
- Partials     6151     7161    +1010

Impacted Files
Coverage Δ

include/zephyr/drivers/can.h
95.45% <ø> (ø)

include/zephyr/drivers/counter.h
5.35% <ø> (ø)

include/zephyr/sys/cbprintf.h
100.00% <ø> (+4.16%)
:arrow_up:

include/zephyr/sys/cbprintf_cxx.h
100.00% <ø> (ø)

include/zephyr/sys/cbprintf_internal.h
100.00% <ø> (ø)

include/zephyr/sys/ring_buffer.h
92.59% <ø> (ø)

kernel/idle.c
83.33% <ø> (ø)

lib/libc/newlib/libc-hooks.c
52.00% <ø> (ø)

subsys/bluetooth/host/conn.c
0.00% <0.00%> (ø)

subsys/bluetooth/host/id.c
7.84% <ø> (ø)

... and 292 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2829de7...0831fb9. Read the comment docs.

BTW, I added below info about test instances.
twister -p native_posix -T tests/lib/cmsis_dsp/matrix/

NFO    - Test instances brief:
INFO    - (1) 12 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix (filtered)
INFO    - (2) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q7 (passed)
INFO    - (3) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q7.fpu (passed)
INFO    - (4) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q15 (passed)
INFO    - (5) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q15.fpu (passed)
INFO    - (6) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q31 (passed)
INFO    - (7) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_q31.fpu (passed)
INFO    - (8) 12 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f16 (filtered)
INFO    - (9) 12 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f16.fpu (filtered)
INFO    - (10) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f32 (passed)
INFO    - (11) 18 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f32.fpu (passed)
INFO    - (12) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f64 (passed)
INFO    - (13) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.unary_f64.fpu (passed)
INFO    - (14) 13 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q7 (passed)
INFO    - (15) 13 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q7.fpu (passed)
INFO    - (16) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q15 (passed)
INFO    - (17) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q15.fpu (passed)
INFO    - (18) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q31 (passed)
INFO    - (19) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_q31.fpu (passed)
INFO    - (20) 12 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16 (filtered)
INFO    - (21) 12 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f16.fpu (filtered)
INFO    - (22) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f32 (passed)
INFO    - (23) 14 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f32.fpu (passed)
INFO    - (24) 13 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f64 (passed)
INFO    - (25) 13 cases in: native_posix/tests/lib/cmsis_dsp/matrix/libraries.cmsis_dsp.matrix.binary_f64.fpu (passed)

BTW, I added below info about test instances.

Please remove this, this might look helpful running on one test and one platform, but it will flood the screen when the numbers grow. For all of this, we have the test output that can always be looked at.

BTW, I added below info about test instances.

Please remove this, this might look helpful running on one test and one platform, but it will flood the screen when the numbers grow. For all of this, we have the test output that can always be looked at.

Removed.

Removed the amending logic.
Update the commit msg.


Implement network filter

Shouldn't we just block IP ranges instead of IP's:

<IP_ADDRESS>/12

<IP_ADDRESS>/24

<IP_ADDRESS>/16

<IP_ADDRESS>/15

These are all the private network IP ranges that Docker would most likely use for internal networking

@pixel5919 That's a better solution but would take more than 15 minutes to implement on the day of the expo ;)
If you want, give it a shot!


Edit to have back to table of Contents link

Closes #203
Also deleted 8th planned enhancement.

Run Jekyll locally and test it out before committing. It doesn't work.

I've updated it! Thank you for informing me, but could you check? it works for me and not sure how it look like for others.


Update PublishTestResults Task

Task name: PublishTestResultsV1
Description: Updated the azure-pipeline-tasks-library version
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

Closing this PR since the changes were corrupted, And raised a new PR to accommodate these changes


SWITCHYARD-2737 Missing support for X509Certificate from the transpor…

…t layer
reproducer:
https://github.com/igarashitm/switchyard/tree/SWITCHYARD-2737_reproducer
https://github.com/igarashitm/switchyard/commit/b6082ed1efe88d21edbbeddb497ab0be3c4685a7

Can one of the admins verify this patch?

ok to test

Processed on community branch and cherry-picked to product branch.


k8s flux install 3.0.0 error

Describe the bug
k8s use flux install helm 3.0.0 error.
k8s version: v1.24.6
To Reproduce
apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: HelmRepository
metadata:
  name: pulsar
spec:
  interval: 168h
  url: https://pulsar.apache.org/charts
---
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
  name: pulsar
spec:
  chart:
    spec:
      chart: pulsar
      reconcileStrategy: ChartVersion
      sourceRef:
        kind: HelmRepository
        name: pulsar
      version: 3.0.0
      interval: 168h
  interval: 10m
  values:
    initialize: true
    kube-prometheus-stack:
      enabled: false
      prometheusOperator:
        enabled: false
      grafana:
        enabled: false
      alertmanager:
        enabled: false
      prometheus:
        enabled: false

Expected behavior
install success
helm controler info
{"level":"error","ts":"2022-12-22T03:37:05.293Z","msg":"Reconciler error","controller":"helmrelease","controllerGroup":"helm.toolkit.fluxcd.io","controllerKind":"HelmRelease","HelmRelease":{"name":"pulsar","namespace":"iccip-dev"},"namespace":"iccip-dev","name":"pulsar","reconcileID":"7964bf69-04ce-44f6-86d5-9cee119560ec","error":"Helm install failed: unable to build kubernetes objects from release manifest: [resource mapping not found for name: \"pulsar-recovery\" namespace: \"\" from \"\": no matches for kind \"PodMonitor\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first, resource mapping not found for name: \"pulsar-bookie\" namespace: \"\" from \"\": no matches for kind \"PodMonitor\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first, resource mapping not found for name: \"pulsar-broker\" namespace: \"\" from \"\": no matches for kind \"PodMonitor\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first, resource mapping not found for name: \"pulsar-proxy\" namespace: \"\" from \"\": no matches for kind \"PodMonitor\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first, resource mapping not found for name: \"pulsar-zookeeper\" namespace: \"\" from \"\": no matches for kind \"PodMonitor\" in version \"monitoring.coreos.com/v1\"\nensure CRDs are installed first]"}

If you disabled kube-prometheus-stack and you don't have another prometheus stack installed, you probably miss the PodMonitor CRDs.


[WIP Do Not Merge] [GSB] Diagnose explicit constraints made redundant by inferred ones.

Extend the diagnosis of redundant constraints to also include explicitly-specified constraints made redundant by inferred constraints. The canonical example is something like:
func f<T: Hashable>(_: Set)
where the parameter of type Set<T> implies T: Hashable. With this PR, we start warning about the explicit T: Hashable constraint being redundant.
Note: I haven't updated tests nor tuned the diagnostics to my liking yet, so this shouldn't be merged now.

@dabrahams take a look at the second commit

@phausler I'd like your opinion on the Foundation commit: is the resulting code clearer or not?
@gribozavr You argued against this a while ago, with a crappy prototype of this warning. Now that I've gone through the exercise of doing the warning right and updating the standard library, I think I like it, but didn't want to put it in without giving you a chance to pipe up.

@swift-ci please smoke test

I'm going to go ahead and merge based on positive feedback from @dabrahams and my own experience working with this warning. We can back it out if we decide we don't like it.

The change to measurement makes sense to me, no Measurement can ever be anything but Unit. Furthermore the CoreData change looks good to me as well.

Very sad about this change. :-( This is definitely the opposite direction from what I'd want.


Image for Remote Assist "take a picture"  may not be correct.  Looks like image for "type a message"

Image for Remote Assist "take a picture"  may not be correct.  Looks like image for "type a message"
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43dbc679-c946-b3ea-b491-a8cf57bddcf1
Version Independent ID: aff224f3-bccd-130e-7934-65bc2c4df19c
Content: Take a photo and save it to a Dynamics 365 Field Service booking in Dynamics 365 Remote Assist - Dynamics 365 Mixed Reality
Content Source: mr-docs/remote-assist/take-snapshot-save-booking-hololens.md
Service: crm-online
GitHub Login: @sophiasysun
Microsoft Alias: sopsun

Hi all, I left this team in October. @Amara @.***>, a PM on Remote Assist, can point you to someone on the team who can update this documentation.
From: Bishal Goswami @.>
Sent: Friday, May 14, 2021 12:01 PM
To: MicrosoftDocs/dynamics-365-mixed-reality @.>
Cc: Sophia Sun @.>; Assign @.>
Subject: Re: [MicrosoftDocs/dynamics-365-mixed-reality] Image for Remote Assist "take a picture" may not be correct. Looks like image for "type a message" (#59)
Assigned #59https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-mixed-reality%2Fissues%2F59&data=04|01|Sophia.Sun%40microsoft.com|7e351450352d4c91461908d9170a9609|72f988bf86f141af91ab2d7cd011db47|0|0|637566156546542396|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=I0bvQMwaUA1gqeVIryBn24gxREYNnUq4pyDQ8ZbiPiI%3D&reserved=0 to @sophiasysunhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsophiasysun&data=04|01|Sophia.Sun%40microsoft.com|7e351450352d4c91461908d9170a9609|72f988bf86f141af91ab2d7cd011db47|0|0|637566156546552391|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=JNaErCtk4B1sdOHy4uPSDTfJqF%2B4dnCObNSd%2BHbNFpc%3D&reserved=0.

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fdynamics-365-mixed-reality%2Fissues%2F59%23event-4748487472&data=04|01|Sophia.Sun%40microsoft.com|7e351450352d4c91461908d9170a9609|72f988bf86f141af91ab2d7cd011db47|0|0|637566156546552391|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Pbgri5wyBDlCn7tRzyyCIsqibaaFtuvIOb8aHO78K5w%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE5DFWDJ5BLHAQ36YFDW353TNVXOBANCNFSM4445UFXA&data=04|01|Sophia.Sun%40microsoft.com|7e351450352d4c91461908d9170a9609|72f988bf86f141af91ab2d7cd011db47|0|0|637566156546562373|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=1dMb0%2F%2BgrqHD%2FmkHnp%2FgEAUPFMgQIMlCfKAyUUP9w3A%3D&reserved=0.


Update unit test regarding the fix for Java Core Issue 1569

Java Core PR: https://github.com/couchbase/couchbase-lite-java-core/pull/1577

This code change is unnecessary anymore.


Add backface-visibility support on Android

backface-visibility was only available on iOS and 3D transformations were lacking of this on Android.
Backface Visibility is computed from the decomposed matrix of transform prop with their rotation degree values.
MatrixDecompositionContext properties have been made public so we can access to decomposed matrix values from outside (ReactViewGroup).
I'm not sure if this is the best implementation, so if it's not let's discuss it.
cc @janicduplessis @foghina
Test Plan
Tested in https://github.com/charpeni/react-native-backface-visibility.
Before

Now

I could imagine this would be a good thing to have screenshot tests for on both ios and android to ensure it doesn't break in the future.

i think i did add an email for ios in RNTester. @charpeni would be nice to get that in for android too if it still exists

Yea screenshot test for this would amazing

I'll do the requested changes.

@chirag04 The example was already there for both platforms, I've updated the PR with RNTester screenshots.
@TheSavior @janicduplessis I can find snapshot tests, but I can't find anything related to screenshot tests, is this setup internally?

I think this link might be the right thing: https://facebook.github.io/react-native/docs/testing.html#screenshot-snapshot-tests

Oh I see, they're the same/bundle that's why screenshots were referring to snapshots. Thanks Eli!

any update on this issue?

I've added a test case without animation in RNTester for backfaceVisibility and updated reference screenshots.

@janicduplessis Can you review this, thanks.

Please, would be awesome to get backfaceVisibility working on Android.
Any updates on review of the last changes?

Actually, the initial issue with backface visibility is that the second view (back) was always drawn on the first view (front). So, the front view was showing the backface with a rotation as shown here:

So, if we can see the front view, it means the backface visibility should work or you don't have a backface.
Anyway, just to be sure have add both cases in RNTester, updated screenshots, and rebase on master.

error: undefined reference to 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)'

 ** Summary of failures encountered during the build **
Rule __REDACTED__ FAILED because Command failed with exit code 1.
stderr: __REDACTED__/folly/Conv.h:1515: error: undefined reference to 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Where did you get this error @hramos?
I'm not sure this is directly related to these changes, I've rebased on a working RNTester commit (e2f2e41f097a128b7a89f20bed916394666d4670) and I can't reproduce any Folly errors.

@hramos Any chance you can take another look at this? Much appreciated!


Fix example

Fixed npm run example

Coverage remained the same at 94.281% when pulling 2203c5273299978bb0d26fdf7e6900691dfa9958 on fix-example into 99e492cbacd514f327a91e688503fcd46a0f8f68 on master.


add Sequence method to compute character frequencies

It would be useful to have a way of computing the frequencies of characters (or a subset of characters) in a sequence. Currently the way to do this is seq.kmer_frequencies(k=1), which handles the frequencies of characters present in the sequence but does not support a subset of characters.
It could also be useful to have this functionality on Sequence because iterating over positions in an alignment will yield Sequence objects. See the TabularMSA RFC for potential Alignment API changes, which will not include the current Alignment.position_frequencies functionality.
@ebolyen and I propose adding the method Sequence.frequencies(chars=None, relative=False) where:

chars=None produces the frequencies of characters in the sequence. Equivalent to seq.kmer_frequencies(k=1).
chars will accept either a single-character string or a set of single-character strings indicating characters to include in the frequency calculations. We only support single-character strings to avoid confusion with substring matching (use Sequence.count or 'foo' in seq for this). We don't want users to run something like seq.frequencies(chars='ACGT') and expect to get a frequency distribution back for each character.
relative matches Sequence.kmer_frequencies, returning relative frequencies when True
the method returns the same type of output as Sequence.kmer_frequencies

+1

:+1:


Support for CanFulfillIntentRequest

The feature is in public beta
https://developer.amazon.com/docs/custom-skills/implement-canfulfillintentrequest-for-name-free-interaction.html
https://developer.amazon.com/docs/custom-skills/understand-name-free-interaction-for-custom-skills.html

I will add the implementation this week

+1

@orlylev any progress on this? Thanks for taking the lead here btw!

I did the development on fork version
It is ready
I am adding some changes to work without user is and session (this is Amazon requirements for this flow)
Will complete in a few days, probably this week

I completed the development
Tested with Alexa according to Amazon it can be tested with manual JSON in the simulator
There I can't remove the session object in the request (it fail in Amazon
We will add it to existing application and submit to Amazon


Replace aggregation controller client with non-caching client

This PR replaces the default cached client for the multiclusterStatusAggregation controller with a non-cached client. Addresses potential Out of memory issues with busy environments.

/lgtm


Make a page for Configuring Prometheus

So that we can link to it directly
It can also mention that you need to configure Prometheus to scrape metrics from your application (and maybe even include a diagram showing how it works).

We currently have: https://docs.autometrics.dev/configuring-prometheus/local and other subsites for configuring Prometheus in different environments (Fly.io and Kubernetes). Do you think we should expand it with, e.g. explaining how it works?

I just meant there should be an actual page for configuring-prometheus so that you can link directly to it (as opposed to one of the pages for local, etc)


Does not build on ARMv7

[main]     Step 5/7 : RUN npm install -g esy &&     esy install &&     esy build
[main]     /usr/local/bin/esy -> /usr/local/lib/node_modules/esy/_build/default/esy/bin/esyCommand.exe
[main]     ><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/esy/node_modules/esy-solve-cudf
[main]     > node ./postinstall.js
[main]     ><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/esy
[main]     > node ./postinstall.js
[main]     +<EMAIL_ADDRESS>
[main]     added 3 packages in 7.565s
[main]     /bin/sh: 1: esy: Exec format error
[main]
[main]     Removing intermediate container d239c1278268
[main]     The command '/bin/sh -c npm install -g esy &&     esy install &&     esy build' returned a non-zero code: 2

Thanks for the issue, @willswire . Just curious - is this issue specific to Revery, or do other projects like hello-reason fail to build as well?

@bryphe can confirm that the issue is with Esy
Cloning into 'revery-quick-start'...
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 296 (delta 5), reused 6 (delta 3), pack-reused 280
Receiving objects: 100% (296/296), 532.61 KiB | 3.41 MiB/s, done.
Resolving deltas: 100% (95/95), done.
bash-4.4# cd revery-quick-start
bash-4.4# esy install
bash: /usr/local/bin/esy: cannot execute binary file: Exec format error
bash-4.4#

Would love to use Revery on the RPi4.
esy has https://github.com/esy/esy/issues/88 open for cross compilation
Has anyone successfully built natively, at least?

Would you like to share your findings here? @EduardoRFS

Have you tested the last esy binary ?

Latest esy binary from an npm install, x86-64.

@shayne I did built it before the change to skia, you need to bootstrap esy yourself, then it will works, but right know it fails to build on skia, so we have work to do.
Previously esy wasn't building on ARM neither on 32bit platforms, now you can get it to work.

Thanks @EduardoRFS, made progress. esy is built and running on the RPi (albeit with a few hacks).
Building revery at 758631f -- found that #include <gtk/gtk.h> wasn't resolving /usr/include/gtk-3.0/gtk/gtk.h. Hacked around that in the Native dune file. Now the linker is failing, coming back to perhaps the pkg-config isn't working properly.
Any ideas?
/usr/bin/ld: src/Native/libRevery_Native_stubs.a(dialog_gtk.o): undefined reference to symbol 'g_strjoin'
/usr/bin/ld: //usr/lib/arm-linux-gnueabihf/libglib-2.0.so.0: error adding symbols: DSO missing from command line

Manually added the output of pkg-config --libs gtk+=3.0 to src/Native/dune c_library_flags. It builds. Success!
Revery on a Raspberry Pi

@shayne nice job, weird here I have problem with skia

Strangely I have the same problem on Ububntu on WSL 2

Done the same thing and it's working, thanks @shayne !
Posting here my src/Native/dune, I ran pkg-config --cflags --libs gtk+-3.0 and split the output: includes goes to c_flags and -l goes to c_library_flags
(library
    (name Revery_Native)
    (public_name Revery.Native)
    (preprocess (pps lwt_ppx))
    (library_flags (:include flags.sexp))
    (js_of_ocaml (javascript_files dialog.js))
    (c_names Revery_Native dialog dialog_cocoa dialog_win32 dialog_gtk notification notification_cocoa utilities ReveryAppDelegate ReveryProgressBar icon icon_cocoa icon_win32)
    (c_flags :standard -Wall -Wextra -Werror
        -pthread
        -I/usr/include/gtk-3.0
        -I/usr/include/at-spi2-atk/2.0
        -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0
        -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0
        -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/libdrm -I/usr/include/pango-1.0 -I/usr/include/harfbuzz
        -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0
        -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2
        -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount
        -I/usr/include/blkid -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
        (:include c_flags.sexp))
    (c_library_flags
        -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0
        -lglib-2.0
        (:include c_library_flags.sexp))
    (libraries sdl2))

(copy_files cocoa/*)

(rule
(targets flags.sexp c_flags.sexp c_library_flags.sexp)
(deps (:discover config/discover.exe))
(action (run %{discover})))


Support port mapping

I think the plugin will get told the port mapping; so it's possible we could support port mapping, and remove the need for adding a container to the bridge network.

Hmm actually it looks like libnetwork intends to do port mapping itself, and currently has a hack to make this happen: https://github.com/docker/libnetwork/issues/401


Differences between wkhtmltopdf and phpwkhtmltopdf

Somehow I come across some differences between using wkhtmltopdf directly via the command line and using the phpwkhtmltopdf wrapper (on the same server). I'd like to understand if I am not doing things right:
Similarities:

I am rendering a PDF from a html source (with quite some loadtime);
The only argument I am using in both cases is to make the output landscape;
The results is a 22 page PDF.

Differences:

wkhtmltopdf takes ~10 seconds, phpwkhtmltopdf takes more than 2 minutes;
wkhtmltopdf generates a ~560kB file, phpwkhtmltopdf generates a ~3,3MB file;
wkhtmltopdf result looks mostly like the html original, phpwkhtmltopdf result uses different fonts and font sizes than the html original.

Any pointers to what might cause/ solve this would be greatly appreciated.

Hmm, I have no idea. This wrapper is very lightweight, so it basically only calls wkhtmltopdf as you would on the command line. It only adds a temporary file internally where the created PDF gets stored to. Maybe try to get the command string with (string)$pdf->getCommand() and check if it makes sense or is different to your CLI command.

wkhtmltopdf result looks mostly like the html original, phpwkhtmltopdf result uses different fonts and font sizes than the html original.

This sounds really weird. Could it be that you have 2 different versions of wkhtmltopdf installed on your system? And that PHP is using a different version that you have on your command line?

Thanks for thinking along. It's crazy right? Even when I set the path to the binary of wkthmltopdf explicity (/usr/bin/wkhtmltopdf) in phpwkthmltopdf and then use the exact command string $pdf->getCommand() outputs in the CLI, i get very different results.

I'm now pretty sure this has nothing to do with your wrapper, but with the server config. When I use exec to run the exact command I get the following error: "Fontconfig error: Cannot load default config file". Thanks again!


Change in background of the Quiz Game

The quiz game has a black background that does not look good . So I would like to add a background image to it .
Please assign me this issue under LGMSOC .

Assigned @Amit-45


Are there plans to support multiple runtimes for rust client?

@lizhanhui PTAL

Hi @iamazy Having our library compatible with multiple runtimes is definitely beneficial. But we are still at the very early stage of development.
The current plan is to target Tokio at first as it is the de facto runtime standard, with a good eco-system and production ready. When we roll out the first release, discuss the outline and steps to make it runtime neutral.


Remove unnecessary shifts in gcd()

The a and b are shifted as a next instruction.

Thank you @findepi


SSH for git clone

Is there any way to get support for SSH for git cloning or 2FA from github? Currently this project is unusable without one of those two things.

Closed on Release 3.17


Search

It'd be great if we could search.

Chatted with @akashvbabu, here's our current plan:

[ ] Add a /api/search backend method. An option will select between custom link and target URL search.
[ ] Add a #search view for the /api/search method. Include a client-side control to search short links or target links.

We'll decide later whether we need any autocomplete capabilities.


Question about Figure 3 on your paper

If you calculate filter L2 norm on trained model, how did you calculate variance of filter norm ? (On figure 3)
Since the model is already trained, the filter is learned, so it is fixed.
Thus norm is just a value, without variance.
Am I right ?
Thanks.

Figure 3 illustrates the bias in weights at hidden layers with 512 filters, not the classifier. In that figure, we compare the naive model weights to the model with weight decay only, so L2 normalization was not used. Let me know if you have more questions!


Document likely "Resource not accessible by integration" error

https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/


video thumbnail can freeze

Those ones that are partially visible when loading  (based on slack comments)

will be solved by #231


KAFKA-2637: Cipher suite setting should be configurable for SSL

Enables Cipher suite setting. Code was previously reviewed by @ijuma, @harshach. Moving to an independent PR.

LGTM

+1


Create a package for WinGet

HandyWinGet GUI lets you create a package for WinGet.

Open to a pull request


font-face support?

Style referenced using link[rel=import][type=css].
@font-face declaration inside it is ignored in Chromium 44, there is even no HTTP request in Network panel of Dev Tools, but works fine in Firefox.
Shadow DOM.

Pretty sure this is due to a long ongoing issue with the scoping of certain at-rules in a shadow root (primarily @font-face). See this chrome bug discussing it.
Quick fix is to chuck @font-face rules in a separate <style> outside your dom-module. Just be aware that they'll be part of the global scope though.

I already did so just for @font-face, but it is quite ugly

Yup, agree. Only way around it AFAIK though.

Is there already a solution to use custom fonts in polymer?

Sadly this is an upstream bug of HTML imports in combination with @font-face (as @seaneking pointed out there is a discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=336876). To resolve this issue Chrome would need to fix the incompatibility. We can take another look once the issue would be fixed.


Create a visualisation tool that overlays parsed elements with semi-transparent boxes

Background
In the example below, a Semantic Segmentation model consolidates multiple individual pixels into a single, coherent Semantic Element within an image.

Similarly, sec-parser features a Semantic Segmentation algorithm that consolidates multiple HTML tags into a single, coherent Semantic Element within a page.
Task
We'd like to have a new python function that has one input (a list of semantic elements) and one output (a string of HTML source code that has all the semi-transparent overlays applied), for example:

The coloring should be based on the type of the semantic element (just an example code to clearly convey the idea).
colored_html = ""
for element in parsed_elements:
    if isinstance(element, TextElement):
        html = element.get_source_code()
        colored_html = colored_html + add_color('yellow', html)
    ...

Parsing into a SemanticTree is most likely not needed, you can just use the list of semantic elements.
Notes

You can retrieve the HTML to be modified directly from the semantic elements themselves. Therefore, the input of your function could be just ingesting a list of semantic elements (or a semantic tree).
It can be either part of the debug_dashboard or it can be a completely separate tool in the dev_utils folder.

Hey @Elijas just to confirm before creating a PR-
I made a new file inside debug_dashboard and have a function like this-
import sec_parser as sp

def visualize_elements(parsed_elements: list[sp.AbstractSemanticElement]) -> str:
    def add_color(color: str, html: str) -> str:
        return f'
{html}
'

    colored_html = ""
    for element in parsed_elements:
        html = element.get_source_code()
        if isinstance(element, sp.TextElement):
            colored_html += add_color('yellow', html)
        elif isinstance(element, sp.TitleElement):
            colored_html += add_color('blue', html)
        elif isinstance(element, sp.TableElement):
            colored_html += add_color('green', html)
        elif isinstance(element, sp.IrrelevantElement):
            colored_html += add_color('red', html)
    return colored_html

Can you give some feedback on this and point me in the right direction.
Otherwise if this looks fine, I can create a PR!

@kaustubh-s1, I'm so sorry for my interrupt. But I don't think it will work.
Especially, in case of the table, it won't work.

@kameleon-ad can you correct me along with some details?

Hello @kaustubh-s1 👋
Did you get a chance to join the Discord group? There is an active discussion on this issue! Discord link is: https://discord.gg/2MC3uJhBxs

Ohh i see @INF800. Lemme hop in. Thanks

@kaustubh-s1 Can you give some feedback on this and point me in the right direction? Otherwise, if this looks fine, I can create a PR!

Request for a demo
Thanks for taking a look at this issue! 🙌
Could you post a screenshot of how it looks when the HTML is viewed in the browser?
Code quality
Also, small code changes for efficiency and readability 👍 The original code example was just to convey the logic, sorry if I caused confusion.

Consider using a dictionary to relate colors to element types

colors = {
    TextElement: 'yellow',
    ...
}

Consider using a list, this will be more efficient than continuously appending to a string

colored_html_items = []
... # all the other code here
      colored_html_items.append(html)
... # all the other code here
colored_html = ''.join(colored_html_items)

Link to discussion
Here in discord we talked a bit about the visualization tool in case it's relevant
https://discord.com/channels/1164249739836018698/1164622878147346552/1172238413022376046

We're excited to inform you that @nnilayy is actively working on developing solutions for this PR. If you're interested in collaborating or contributing, we encourage you to reach out for potential collaboration. You can join the discussion on our Discord server:

Your input and contributions are highly valued, and we look forward to seeing your ideas and work!
cc @kaustubh-s1

Sure @Elijas , thanks for notifying on that!


Add more Fixes to help migration to Minimal API

This rule will trigger for every migration of MVC .Net6 application .Net7. It should at least give some pointer to help understand Minimal API, and give more usuals cases fixes.
For example this one already cover in a ticket https://github.com/dotnet/aspnetcore/issues/44959#issuecomment-1308223971.
And other like the properties of IEndpointRouteBuilder which are now internal and must be accessed like that
((IEndpointRouteBuilder)app).DataSources... instead of endpoints.DataSources... (unless there is a better solution).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 16b83e45-7b75-639c-dc8d-cc691fd40222
Version Independent ID: 16b83e45-7b75-639c-dc8d-cc691fd40222
Content: ASP0014: Suggest using top level route registrations
Content Source: aspnetcore/diagnostics/asp0014.md
Product: aspnet-core
GitHub Login: @safia
Microsoft Alias: safia

This rule will trigger for every migration of MVC .Net6 application .Net7.
Do you mean this rule is triggered for every update of ASP.NET Core 6 to 7? Can you provide the simplest possible repo?

If you're migrating Web API controllers to minimal APIs, you need to understand minimal API.

No, I mistake "top level route" to "Minimal API", sorry. I think this rule help should give more information about "top level route" and migration from "endpoint" style MVC to "top level route" style, like the example I give.
That said, as "top level route" and "Minimal API" can be mixed up, adding a link to Minimal API documentation would be helpful too.


Projects list should be derived from the transient symbol list ...

In the following screenshot, the RowanSample1 project was loaded into the DataCurator session (on the right), but because of the current way that projects are listed, the RowanSampe1 project shows up in the SystemUser project list (on the left):

Here's a picture of the System Browsers to prove that the RowanSample project should only show up for DataCurator (on right):

With this fix, the 4 standard projects are visible due to the fact that there are extension packages in Globals ... which is okay ...  at least the projects loaded by DataCurator do not show up in SystemUser's project list ...


[WIP] Alchemy docking deal with edgecases

deals with edge-cases during docking, ultimately letting them fail.
Developers certificate of origin

[x] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

@hmacdope can you have a looksy? this works on my end. Still need to build in a test, but it's possible we'll need to build in a time-out in another PR first because the test on this ligand series will take ~20 min

ok added a fast test, should be ready to go once upstream OFFTK issues are fixed @hmacdope

@JenkeScheen new test is failing. :(


Notify user when trying to add existing registered ring.

Closed with commit "About Window added and Duplicate Tag Registration Prevented"


Navigation improvements for responsive master/detail pattern in activities view

Tweak implementation of the responsive master/detail pattern to match what is recommended in the XamlMasterDetail sample.

Fixes #43


chore(release): 2.52.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 9afe4440d014c6fa53bf481aed89cdf4627e1b25
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: ccc5b8c639f0c6a37764af418f50e94976fc3440
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 467db426607db2c869c114a5ed1dc6269c1cd044
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


chore: update usage of Azure/karpenter

Description
This PR updates the usage of Azure/karpenter to be Azure/karpenter-provider-azure throughout the repository. It also cleans up several references that are no longer valid (reviewers: search for "/pull" in the changes).
How was this change tested?

make presubmit

Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.626%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35605

Relevant Lines:
36471

💛  - Coveralls


CR: implement "resolve conflicts manually" link

You should review #17491 first.

Also, you should only look at the second commit. The first one is showing because I marked this as to merge into master because I have rebased it more recently than the other PR so otherwise it would show lots of not-my commits.

I am aware that it looks visually awful right now, going to work on that as a revision to the other PR.

@songgao merged this for now into the main branch, so we can hopefully merge that soon and then rebase your branch on all that - lmk if you want me to do some of the rebasing - I know it's your branch but I feel like my being slow on these PRs has caused all of it to need to happen.
Then we can deal with any issues that still remain after the changes from your PR in a separate PR.


Input is unequal to value

Use-Case: Check for an empty String
Added function to check value is not equal to the input.

This feature looks like it is intended for validation, and that is not something I think this library should be responsible for. I believe that mapping JSON to TypeScript types and validating data are separate problems.


Error when trying to load a MDX file with mdx-bundler and next.js

Description of Bug
I have a create-next-app for which I installed mdx-bundler and was trying to load MDX files. Outside of Stackblitz, the MDX files are being loaded fine, but I am unable to do it in Stackblitz due to the following error:
TypeError: Failed to resolve module specifier 'xdm/esbuild.js'

According to a user in the Stackblitz Discord server, the issue is probably related to the following:
// xdm is a native ESM, and we're running in a CJS context. This is the
  // only way to import ESM within CJS
  const [
    {default: xdmESBuild},
    {default: remarkFrontmatter},
  ] = await Promise.all([
    import('xdm/esbuild.js'),
    import('remark-frontmatter'),
  ])

My Stackblitz project link:
https://stackblitz.com/edit/nextjs-bwcbzv
Steps to Reproduce

Open the Stackblitz project (https://stackblitz.com/edit/nextjs-bwcbzv)
Navigate to /post/test by directly modifying the URL

Expected Behavior
The page loads without any errors.
Screenshots/Screencast

I have moved this issue because it's related to WebContainer.

I have recriated the Stackblitz project and just thought later that the URL might be needed still. So this is it: https://stackblitz.com/edit/nextjs-zsxy8n
I have created the .stackblitzrc file and will test it now.

@d3lm I can confirm that the .stackblitz file with the content you provided makes it work like a charm! Thanks for the solution!

You are welcome. Glad it worked out for you. Sorry that it's an opt-in for CJS but it's a performance reason and we need to do some more work to make it fast by default without manually enabling it.


Minoston MP21Z Fails after Z-Wave JS 1.3.0 Update in Home Assistant

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Z-Wave JS UI version
v8.4.1
ZwaveJS version
10.3.0
Describe the bug
Minoston MP21Z Wall Plug had been working with Home Assistant Z-Wave JS UI until latest update. With the update, it's dead. Roll back, it's live again.
Home Assistant
Prior - working version: Z-Wave JS UI to v8.2.2
HA Z-Wave JS UI v1.2.1
Updated - failing version: Z-Wave JS UI to v8.4.1
HA Z-Wave JS UI v1.3.0
To Reproduce
With latest update tried rebooting RPI4, reloading, healing, re-interviewing, pinging, etc. Node was declared dead. All other zwave devices are working including locks, wall plugs (other brands), wall switches, etc. with no intervention needed, everything came alive on its own.
Rolled back to v8.2.2, wall plug was live again. Did the update and roll back again to verify the only change is the latest update.
Expected behavior
A seamless update...
Additional context
Noted:  [bug] "Last seen" is updated on dropped message zwave-js/zwave-js-ui#2800

I'm seeing this same behavior on the dead node after update. Not sure it's related to the node being dead in the first place

zwave-js-ui-store.zip
After turning on logs, went to the Control Panel with the intent to ping the dead node. It was alive before I could ping it. Didn't do anything else and Logbook shows it turned on while I was figuring out which settings to change to generate and download logs. Log attached, but I don't know why it started working

No clue, let's see if @AlCalzone can tell us more by checking logs. What's the node id?

zwave-js-ui-store Update and reboots.zip
Node 7 was the problem. In the attached I had rolled back, then updated and restarted. - now the node won't fail. I'll have to add turn on log to file as part of my zwave debug process. Unless you can see anything in the file, I'm OK marking this as Closed.
Thanks


Building for iOS Simulator for unsupported Swift architecture

YogaKit.framework/Headers/YogaKit-Swift.h:263:2: error: unsupported Swift architecture
#error unsupported Swift architecture

me too

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.


PR Add russian auto translation

Description of Changes

Issue(s) Resolved

Related to https://github.com/spyder-ide/spyder/issues/10672
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Hi @burrbull and @Qlogin, I added automatic (google) translation so you could start reviewing the work when you have some time :-)
Thanks!


[WIP] Application refactoring roadmap

Related to #401 this describes the roadmap to take for refactoring the Application in Gush 2.0.
The final goal is to decouple Gush from any framework or library.
To make this possible the application is designed with the adapter design-pattern whenever possible.
Layers architecture
Commands

Commands work similar to web Controllers, they are thin and function as a layer between the Console Application and underlying services.

Commands only communicate with an "API Adapter" or "Service" and never with any other system directly. So instead of running the php-cs-fixer executable directly this happens through a Service like "CsFixer" which invokes the php-cs-fixer and handles any output back to the Command.

System (Git commands) are always done using the GitSystem service (better name needed), complex operations like merging or rebasing are done using an Operation, the Command only configures the operator for execution.

Commands are decoupled from any 3rd part library.

Command handling is separated from the command definition (the command definition is an implementation detail of the used library).

We use our own IO interface instead of relying on the Console libraries implementation.

This handles all IO operations, including questions and table rendering.
The current StyleHelper will be moved to this interface.

Service layer
TBD.

this ticket must be broken down into actionables

I will work on some of the idea's and issues in the weekend ;)
Most of this is already done, I'm horrible at keeping my notes up-to-date :)


form的validateFields支持promise用法

原来的pr https://github.com/react-component/form/pull/187

@yesmeck

👍

@mushan0x0 Only validateFields ? Please add this feature for validateFieldsAndScroll.

@yoyo837 There's a return
https://github.com/react-component/form/blob/bdbd7b03e88b7d76ad58d39d978e5bce0c7abdf8/src/createDOMForm.js#L98

Wow, I really should read the source code about this.


IOS WebAudioPlugin Memory Leak

Hey, I'm finding a memory leak when using the web audio plugin on all IOS devices. After adding and removing 8 or 9 sounds, the safari browser will crash as it runs out of memory.
After switching to use the html audio plugin, this is no longer a problem as it correctly removes sounds from memory, however it breaks support for IOS6 and Ipad 3 devices. This makes me believe that the problem lies within the web audio plugin, and not my usage of it. This occurs on the current version, which I compiled myself yesterday from the repo.
My setup is very complex, using haxe compiled to JS to load and unload sounds, so I will get to work on a basic web application to reproduce it with the same sounds. Any help or knowledge on this would be appreciated as I am unable to find any solutions online.
Thanks

Related issue in the latest version of Chrome:
http://stackoverflow.com/questions/28400437/leaving-a-webpage-with-soundjs-causes-google-chrome-to-crash

Dunno if y'all are still tracking this, but we ran up against this pretty hard for our latest project (we don't use SoundJS, but it seems relevant). It seems that simply disconnecting and dereferencing the AudioBufferSourceNode object on iOS Safari isn't enough; you need to manually clear out the reference to its buffer, or the buffer itself leaks. (This implies the AudioBufferSourceNode obj itself leaks, but we didn't see this as a practical limit in our project.)
Unfortunately to do this, a 1-sample long scratch buffer needs to get created, as assigning to null will cause an exception. The statement must be try-catch wrapped, too, as Chrome/FF will throw when .buffer is reassigned at any time.
The solution that worked was:
var ctx = new AudioContext(),
    scratchBuffer = ctx.createBuffer(1, 1, 22050);

class WebAudioAdapter extends AudioAdapter {
    close() {
        if( this.__src ) {
            this.__src.onended = null;
            this.__src.disconnect(0);
            try { this.__src.buffer = scratchBuffer; } catch(e) {}
            this.__src = null;
        }
    }
}

Hope this helps y'all too!

Appreciate you sharing your solution. Feel free to implement in the Github source, and submit a pull request. Otherwise, we will definitely look at implementing

I took at stab at this, but I'm not familiar at all with SoundJS's organization. Near as I can tell, the scratch buffer itself should go into WebAudioPlugin.js, be generated in _generateCapabilities, used in playEmptySound then assigned into an instance of WebAudioSoundInstance.js and used during _cleanUpAudioNode. How's that sound?


Fix IlmBase linker warnings with LINKSTATIC on Windows.

Since d771ee8 OPENEXR_DLL is defined when LINKSTATIC=ON which I'm guessing was not an intentional change. This restores the behavior before the refactor, fixing a bunch of LNK4217 warnings when building with static IlmBase libraries.
The same fix is needed in OpenImageIO.

LGTM

This is only an issue in master and does not need any backport, right?

It is only an issue in master, created OIIO pull request here: OpenImageIO/oiio#1701


Bigquery  native path - S3 and GCS

Description
What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

closing this as i have created new PR with additional changes: https://github.com/astronomer/apache-airflow-provider-transfers/pull/66


publish<EMAIL_ADDRESS>

Requested by: @Lms24
Merge target: lms/test-merge-target-branch
Using Craft config from: lms/test-merge-target-branch
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).
Targets

[ ] npm
[ ] npm[whatever :)]
[ ] github

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

IGNORE

#retract


Gstreamer CRITICAL error (gst_audio_ring_buffer_set_channel_positions) during Playback on Raspberry Pi

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

I'm using AVS SDK version 1.20.1 on a Raspberry Pi 4 Model B Rev 1.4. I build SampleApp with PORTAUDIO and SENSORY Wakeword. While running the SampleApp, I observe the following.

For every Alexa response (TTS), "** (SampleApp:24920): CRITICAL **: 23:04:42.872: file gstaudioringbuffer.c: line 2045 (gst_audio_ring_buffer_set_channel_positions): should not be reached"
Music streaming does not work. If I ask 'Alexa, play music', I hear the response 'Playing music from iHeartradio ...', but no music is played. Before the TTS response, I see the same above gstreamer error.

I built this same SDK code on Ubuntu and this issue is not seen. Both TTS and Music work just fine.
What is the expected behavior?

Music should be played when I ask Alexa to play music. CRITICAL gstreamer error is to be resolved.
What behavior are you observing?

Music does not play and Gstreamer gives the error: '** (SampleApp:24920): CRITICAL **: 23:04:42.872: file gstaudioringbuffer.c: line 2045 (gst_audio_ring_buffer_set_channel_positions): should not be reached'
Provide the steps to reproduce the issue, if applicable:

Build SampleApp on Raspberry Pi 4 Model B Rev 1.4
Configure AlexaClientSDKConfig.json
Start SampleApp (./SampleApp/src/SampleApp ./Integration/AlexaClientSDKConfig.json DEBUG9)
Ask Alexa 'What time is it'. Alexa response is heard but you see the gstremer error: '** (SampleApp:24920): CRITICAL **: 23:04:26.933: file gstaudioringbuffer.c: line 2045 (gst_audio_ring_buffer_set_channel_positions): should not be reached'
Ask Alexa 'Play music'. Alexa TTS response (Playing music from iheart...) is heard but music is not played. The gstremer error: '** (SampleApp:24920): CRITICAL **: 23:04:26.933: file gstaudioringbuffer.c: line 2045 (gst_audio_ring_buffer_set_channel_positions): should not be reached' is seen before TTS response is played.

Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.20.1>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[X] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[X] Raspbian GNU/Linux 10 (buster)
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @sembhayy thanks for posting.
Can I ask what version of GStreamer your device is using? You can see the minimum required Gstreamer versions and dependencies required here: https://developer.amazon.com/en-GB/docs/alexa/avs-device-sdk/dependencies.html#mediaplayerinterface as well as instructions on how to download them for the Raspberry Pi here: https://developer.amazon.com/en-GB/docs/alexa/avs-device-sdk/raspberry-pi.html#set-up-your-raspberry-pi-environment

Hello, I checked the gstreamer version on my Raspberry Pi. It is 1.14.4
pi@raspberrypi:~/sdk-folder/sdk-build $ dpkg -l | grep gstreamer
ii  gir1.2-gstreamer-1.0:armhf             1.14.4-1                               armhf        GObject introspection data for the GStreamer library
ii  gstreamer1.0-alsa:armhf                1.14.4-2                               armhf        GStreamer plugin for ALSA
ii  gstreamer1.0-doc                       1.14.4-1                               all          GStreamer core documentation and manuals
ii  gstreamer1.0-gl:armhf                  1.14.4-2                               armhf        GStreamer plugins for GL
ii  gstreamer1.0-gtk3:armhf                1.14.4-1+rpt1                          armhf        GStreamer plugin for GTK+3
ii  gstreamer1.0-libav:armhf               <IP_ADDRESS>+git20180723+db823502-2        armhf        libav plugin for GStreamer
ii  gstreamer1.0-omx                       1.14.4-1+rpt1                          armhf        GStreamer OpenMAX plugins
ii  gstreamer1.0-omx-rpi                   1.14.4-1+rpt1                          armhf        OpenMax plugins for GStreamer
ii  gstreamer1.0-omx-rpi-config            1.14.4-1+rpt1                          armhf        OpenMax plugins for GStreamer
ii  gstreamer1.0-plugins-bad:armhf         1.14.4-1+b1                            armhf        GStreamer plugins from the "bad" set
ii  gstreamer1.0-plugins-base:armhf        1.14.4-2                               armhf        GStreamer plugins from the "base" set
ii  gstreamer1.0-plugins-good:armhf        1.14.4-1+rpt1                          armhf        GStreamer plugins from the "good" set
ii  gstreamer1.0-plugins-ugly:armhf        1.14.4-1                               armhf        GStreamer plugins from the "ugly" set
ii  gstreamer1.0-pulseaudio:armhf          1.14.4-1+rpt1                          armhf        GStreamer plugin for PulseAudio
ii  gstreamer1.0-tools                     1.14.4-1                               armhf        Tools for use with GStreamer
ii  gstreamer1.0-x:armhf                   1.14.4-2                               armhf        GStreamer plugins for X11 and Pango
ii  libgstreamer-gl1.0-0:armhf             1.14.4-2                               armhf        GStreamer GL libraries
ii  libgstreamer-opencv1.0-0:armhf         1.14.4-1+b1                            armhf        GStreamer OpenCV libraries
ii  libgstreamer-plugins-bad1.0-0:armhf    1.14.4-1+b1                            armhf        GStreamer libraries from the "bad" set
ii  libgstreamer-plugins-bad1.0-dev:armhf  1.14.4-1+b1                            armhf        GStreamer development files for libraries from the "bad" set
ii  libgstreamer-plugins-base1.0-0:armhf   1.14.4-2                               armhf        GStreamer libraries from the "base" set
ii  libgstreamer-plugins-base1.0-dev:armhf 1.14.4-2                               armhf        GStreamer development files for libraries from the "base" set
ii  libgstreamer1.0-0:armhf                1.14.4-1                               armhf        Core GStreamer libraries and elements
ii  libgstreamer1.0-dev:armhf              1.14.4-1                               armhf        GStreamer core development files
ii  libreoffice-avmedia-backend-gstreamer  1:6.1.5-3+rpi1+deb10u6+rpt1            armhf        GStreamer backend for LibreOffice
ii  phonon-backend-gstreamer:armhf         4:4.9.0-1                              armhf        Phonon GStreamer 1.0 backend
ii  phonon-backend-gstreamer-common:armhf  4:4.9.0-1                              armhf        Phonon GStreamer 1.0.x backend icons

Hi @sembhayy, would you be able to attach the DEBUG9 log?  Thanks!

Closing due to inactivity.  Please open a new issue if you are still having problems with it.


Reduce uploads to dd-ci-artefacts-build-stable

What does this PR do?
Stop uploading deb & OCI packages to dd-ci-artefacts-build-stable
Motivation
Both these kind of packages are already uploaded to dd-release-artifacts and are never read from dd-ci-artefacts-build-stable, which means we were uploading ≃2.1GB for no purpose in each pipeline.
BARX-612
dd-ci-artefacts-build-stable is only meant to contain binaries that are used as is in our docker images, not distribution packages.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
:warning: This means that we won't be able to rebuild an image for a given pipeline by simply restarting the job.
For pipeline containers, that seems OK.
For RCs/releases, this might be problematic. We would need to introduce a fallback to download from dd-release-artifacts for such pipelines.
Additional Notes

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

/merge


Text gets weird background

Love this tool, thanks for building it! I noticed that when I save a document as PDF and upload it, the text gets a weird background. Check out this original file and the processed version for example. Thanks for looking into this!

I figured out that this is caused by the +noise Multiplicative argument. Using Gaussian, Laplacian, or Uniform produced better results for me.

Thanks. I'm currently working on improving the code and this will be included!


Swift project XCode CocoaPods isn't working

I added pod 'KWStepper' to Podfile, ran pod install. Successfully imported import KWStepper to the file where I'm trying to use KWStepper. It can't find KWStepperDelegate and KWStepper even though the framework is attached.

Thanks for reporting this issue! Support for CocoaPods should be fixed in version 1.2.2. Please give it a try and let me know how it goes.

There are a couple of things about the code that are stopping me from trying it:

Swift 2.0 support will come in XCode 7. guard is a part of Swift 2.0. I've tried a pre-release version of XCode several times in the past and I don't want to try it for writing prod code again. Simply put - pre-release means it doesn't have to behave properly.

NSException is quiet odd in Swift world. Swift 2.0 error handling is about conforming to ErrorType protocol. NSException is a native exception and can only be caught from Objective-C. Of course, the community has developed some workarounds, like SwiftTryCatch which is discussed in that blog post.
Another approach to consider is assertionFailure. Two possible downsides of that:

it does nothing in release
there is no way to handle that (but how can you handle those cases in your code gracefully anyway?)

@sealemar I understand your position here.

You'll be pleased to know that Xcode 6.4 still works, as Swift 2.0 is no longer a requirement in version 1.2.2. I'm waiting until Xcode 7 is out of beta to use guard in a production release.

I agree and intend to update to Swift 2.0 error handling down the road. KWStepper only uses NSException in setters though. My understanding is that marking as "throws" isn't supported for setters. Hopefully, this will be implemented soon.

Anyway, I believe this issues is resolved, but please let me know if you encounter any problems.

As for the number 2 the protocol is not going to support setters since according to ErrorType protocol, a function must return a non-void result.


Facebook Bot for Automatic Media Posting

What features will my script have
Posting the media Automatically

@avinashkranjan
I would love to work on this issue as a part of GSSOC'21. Kindly assign me this issue

@vivek-2000 assigned to you

@vivek-2000 updates?

@vivek-2000 Issue unassigned due to no response from your side

Hey @kaustubhgupta
I am a participant at GSSoC 2021. I would like to contribute to this issue. Can you assign it to me. Also, I need more details as it is not clear for me right now.

@kaustubhgupta can I work on this??
And also please can you explain what exactly have to be done.

@kaustubhgupta since I have no more pending issues can I start working???

@amrzaki2000 sure!

@kaustubhgupta I asked for the issue first.

Apologies @Amit366 for seeing this message late! That's why I unassigned @amrzaki2000 as soon as I saw your message above

Apologies @Amit366 for seeing this message late! That's why I unassigned @amrzaki2000 as soon as I saw your message above

Sorry
I did not see it too


Integrate DfE::Analytics

Context
We now have https://github.com/DFE-Digital/dfe-analytics to replace custom code in all the apps.
Changes proposed in this pull request
Delete the old BigQuery code. Add DfE::Analytics. Retain the old worker so we don't fall over on jobs enqueued during the change.
Guidance to review
Use the log_only and async options in dfe-analytics.rb to satisfy yourself everything's working. DM me for BigQuery credentials if you need them.
Link to Trello card
https://trello.com/c/neK2rSqu/563-share-bigquery-client-code-across-bat-services-dfe-analytics
Things to check

[X] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[X] This code does not rely on migrations in the same Pull Request
[X] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[X] API release notes have been updated if necessary
[X] Required environment variables have been updated added to the Azure KeyVault

Validation error tracking depends on ApplicationHelper.service_key which somehow isn't in scope any more. I'm having to explicitly include ApplicationHelper in ApplicationController for some reason, which seems reasonable, but I'm now not sure why this worked in the first place. Investigating

It was included via EmitRequestEvents. This was obviously wrong. Fixed

Just conscious that the specs part of this PR is basically one big delete. Is there any way to add meaningful tests? While working on ttapi I thought maybe we should include some kind of spec helper in this project that abstracts out the test that we can include in the implementing service. e.g. have_sent_web_request_event:
    it "emits web request events using dfe-analytics" do
      expect {
        get "/test"
      }.to(have_sent_web_request_event)
    end

And then the app could decide whether to implement this in an example controller that inherits from ApplicationController, or wherever DFE::Analytics::Requests gets included, or to include it in tests for individual controllers.
It would also be a good idea to test that the DFE::Analytics is configured somehow. Just adding a spec to the app that tests whether DFE::Analytics.config.bigquery_table_name is set to something, for example, seems a bit redundant. Would it make sense for the generator to add a spec that tests that all the relevant DFE::Analytics configuration points are configured with non-nil values? This would trigger a test failure if the initializer isn't edited.

@misaka good points.
To the config one, DfE::Analytics will bail on send attempt if vital vars are missing: https://github.com/DFE-Digital/dfe-analytics/blob/main/lib/dfe/analytics.rb#L28
I agree we should have some sort of integration test in the app. I wonder if we should call DfE::Analytics::Testing.fake! and maybe that should count "requests"? Not sure if we should go all the way to the network boundary tho? (It does in the gem's own specs)

Do we still need Events::Event class or can we delete it with its corresponding spec?

Do we still need Events::Event class or can we delete it with its corresponding spec?

Good catch! I'll delete :+1:


Illegal ambiguous match on configurable attribute "deps" in //tensorflow/core:ops

System information

OS Platform and Distribution: macOS Catalina 10.15.1
TensorFlow installed from: source
TensorFlow version: 2.0.0
Python version: 3.7.4
Installed using: spack
Bazel version: 0.26.1
Compiler version: Clang 11.0.0
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the problem
I'm trying to build a minimal TF installation, but I don't seem to be able to disable GCP support. I get the following error during build time:
/private/var/folders/21/hwq39zyj4g36x6zjfyl5l8080000gn/T/Adam/spack-stage/spack-stage-py-tensorflow-2.0.0-ve5t7rb2qt4igekam6hdrwnm6vgts22q/spack-src/tensorflow/core/BUILD:1359:12: Illegal ambiguous match on configurable attribute "deps" in //tensorflow/core:ops:
//tensorflow:api_version_2
//tensorflow:no_gcp_support
Multiple matches are not allowed unless one is unambiguously more specialized.

Provide the exact sequence of commands / steps that you executed before running into the problem
First, I set the following environment variables:
TF_CONFIGURE_IOS=0; export TF_CONFIGURE_IOS
TF_DOWNLOAD_CLANG=0; export TF_DOWNLOAD_CLANG
TF_ENABLE_XLA=0; export TF_ENABLE_XLA
TF_NEED_AWS=0; export TF_NEED_AWS
TF_NEED_CUDA=0; export TF_NEED_CUDA
TF_NEED_GCP=0; export TF_NEED_GCP
TF_NEED_GDR=0; export TF_NEED_GDR
TF_NEED_HDFS=0; export TF_NEED_HDFS
TF_NEED_IGNITE=0; export TF_NEED_IGNITE
TF_NEED_JEMALLOC=0; export TF_NEED_JEMALLOC
TF_NEED_KAFKA=0; export TF_NEED_KAFKA
TF_NEED_MKL=0; export TF_NEED_MKL
TF_NEED_MPI=0; export TF_NEED_MPI
TF_NEED_NGRAPH=0; export TF_NEED_NGRAPH
TF_NEED_OPENCL=0; export TF_NEED_OPENCL
TF_NEED_OPENCL_SYCL=0; export TF_NEED_OPENCL_SYCL
TF_NEED_ROCM=0; export TF_NEED_ROCM
TF_NEED_S3=0; export TF_NEED_S3
TF_NEED_VERBS=0; export TF_NEED_VERBS
TF_SET_ANDROID_WORKSPACE=0; export TF_SET_ANDROID_WORKSPACE

Then, I ran:
$ ./configure
$ bazel --nohome_rc --nosystem_rc build --color=no --jobs=4 --config=opt --config=noaws --config=nogcp --config=nohdfs --config=noignite --config=nokafka --config=nonccl --config=v2 //tensorflow/tools/pip_package:build_pip_package

The bug seems to occur regardless of whether or not --config=v2 is added, as that is the default. Using --config=nogcp --config=v1 seems to work, and not using --config=nogcp also seems to work. Is GCP support required in v2?
Any other info / logs
build log
build environment
This work is being done in conjunction with https://github.com/spack/spack/pull/13112
I've seen #25644 #24447 #11807 #14522 and other similar issues, but they look specific to CUDA/NCCL or are due to older versions of Bazel.

This bug is no longer present in 2.1.0. I'll close this, but if anyone knows which commit fixed this, I can patch 2.0.0.

For the record, this bug seems to be present in 2.0.0 and 2.0.1, and seems to have been fixed by the following commit:
commit 837c8b6b35429ec99d977c609fe65c0e79f4569a
Author: Gunhan Gulsoy<EMAIL_ADDRESS>Date:   Wed Sep 4 13:43:49 2019 -0700

    Remove contrib cloud bigtable and storage ops/kernels.
    Thse have moved to github.com/tensorflow/io
    PiperOrigin-RevId: 267222179


Put JavaPreProc into utilities.jar

Need to add wrapper scripts
Then we can test with "tester" to catch regressions

The difficulty is that JavaPreProc is also an Ant task, thus it has dependencies on the Ant runtime .jar file(s), so adding it to our own would be hard.  One way around this would be to make JavaPreProc itself into more-or-less standalone code, and then add an Ant task wrapper around it.  This wouldn't be that hard....

I think the thing to do is this:

Create a PreprocException thrown by JavaPreProc
Create PreprocTask which extends Ant's Task class
Completely take out the Ant references in JavaPreProc, and throw the new exception, catch that inside PreprocTask which then throws BuildException from them

Actually I just let PreProc itself throw "normal" exceptions like IOException and IllegalArgumentException, and PreProcTask catch and then throw them as BuildException as planned.


Does not work for more than 6 layers

When checking the gerber files, only a maximum of 6 layers get pushed to the gerber file. A project I was working on uses 10 copper layers but not all of them get included in the gerber file.

The latest release (2.3.0) only has support for 6 layers, but https://github.com/bennymeg/JLC-Plugin-for-KiCad/commit/4a59fb0672f798ef9646803f915b3ed3bf244e96 has added support for 8 layers, and my PR #66 has added support for all 32 possible layers. Included in this message is the latest development version of the plugin which will allow you to successfully export your files, just open the plugin manager in kicad and click "Install from file" and select the zip below.
JLC-Plugin-for-KiCad.zip

will be available officially in the next release. closing for now.


IBIS power model cannot be set to 'external' via pyAEDT

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
Hello,
I am trying to use pyAEDT to script the DDR IBIS model scenario creation. I started with this example: https://aedt.docs.pyansys.com/version/0.7/examples/07-Circuit/Circuit_Transient.html. However, I am facing issue once I want to change IBIS model instance property 'power' from 'internal' to 'external'. This can be done manually from EDT GUI but not from pyAEDT. I attach a screenshot showing errors if two different approach to change the parameter are used. Other properties may be changed from pyAEDT. Even the 'power' property may be changed, but only 'external' -> 'internal' direction.
Can you confirm a bug or give an advice how to proceed? Customer service redirected me here.
BR,
Michael

Steps To Reproduce
In the screenshot.
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
Running directly from EDT pyAEDT console:
Python 3.10.9 (remotes/origin/4e018266dafe29ec2836492d71d245fcfd366d07-dirty:4e018266, Jan  3 2) [MSC v.1920 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.22.2 -- An enhanced Interactive Python. Type '?' for help.
Loading the PyAEDT Console.
Initializing new desktop!
PyAEDT INFO: StdOut is enabled
PyAEDT INFO: Log on file is enabled
PyAEDT INFO: Log on Desktop Message Manager is enabled
PyAEDT INFO: Debug logger is disabled. PyAEDT methods will not be logged.
PyAEDT INFO: {14084: 50051}
PyAEDT INFO: Launching PyAEDT outside AEDT with gRPC plugin.
PyAEDT INFO: Launching AEDT using the gRPC plugin.
PyAEDT INFO: Connecting to AEDT session on gRPC port 50051
PyAEDT INFO: AEDT installation Path C:\Program Files\AnsysEM\v241\Win64
PyAEDT INFO: pyaedt v0.7.0
PyAEDT INFO: Python version 3.10.9 (remotes/origin/4e018266dafe29ec2836492d71d245fcfd366d07-dirty:4e018266, Jan  3 2) [MSC v.1920 64 bit (AMD64)]
PyAEDT INFO: AEDT 2024.1.0 Build Date 2023-11-27 22:16:18

@Samuelopez-ansys, could a workaround be used here similar as you proposed in https://github.com/ansys/pyaedt/discussions/4374? So, I could move forward.

@mikevacany Ok great, if it is something that you would like to have in Pyaedt, please create an issue. And contributors will check it.

@Samuelopez-ansys, this bug is not resolved, I am just asking if there is a similar workaround, you provided in the other issue.

@Samuelopez-ansys, can you reopen this issue?

Hi @mikevacany ,
PyAEDT is an open-source code, if you know how to fix the issue, you could try :)
If you do not have time or you can not fix it, one contributor from the community will help, but there are other Issues in the backlog. Thanks


Remove redundant methods from ActivityLifecycleCallbacksAdapter SAMs

Less methods

Binary and source incompatible

I just had to try it and it worked!
Long term, all of the SAM interfaces probably shouldn't extend ActivityLifecycleCallbacksAdapter. The amount of method signatures is huge! Every one of the interfaces has a $DefaultImpls class with all the other methods.

I could probably just remove this all. Felt like a useful addition to have but not quite related to this lib. It's just that all projects  keep redefining this.


Add linter for python examples

seems make lint target was added: https://github.com/momentohq/client-sdk-python/blob/main/examples/Makefile


Do not add any timestamp to the cached file

I don't think there should be any timestamp in the cached file: It complicates the action's code as it has to lookup and cleanup, it still pollutes the cache, but what is this effort actually good for? Why would anyone want to keep old revisions of the ccache? It's a cache...

but what is this effort actually good for?

Nothing. But... will github actions cache service like that? The last time I checked, it wouldn't allow one to replace/update an existing cache entry so you either delete the old entry and create a new one (with the same key) or always create a new entry (with different keys). In short, the timestamp is a workaround for a 'defect' of the github actions cache service and I couldn't think of anything better...


demo: rename clearlinux-demo-opae to opae-nlb-demo

opae-nlb name is more descriptive about the content and becomes
base image agnostic.
Also, set ENTRYPOINT similar to what we did with other images
and deployment files.
Signed-off-by: Mikko Ylinen<EMAIL_ADDRESS>

travis is blocked?

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   70.79%   70.79%
=======================================
  Files          16       16
  Lines        1654     1654
=======================================
  Hits         1171     1171
  Misses        448      448
  Partials       35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fd36c...f596fc5. Read the comment docs.


[tlul,rtl] Weaken "known" assertion in tlul_adapter_sram.sv

The existing assertion was actually false because the response from the SRAM might have been unknown. Thank you, Jasper, for leading me to this!

I think it has landed and we got lucky :-) Merging.


Strange behaviors on MacOS

I've attempted to use this in both my own project and running the sample app in this repo. It does not appear to support rounded corners, gradients, borders, or in fact much of anything (see screenshot from sample app). Given that all of those are listed as "supported" for MacOS, I assume I've done something wrong, somewhere.
I am running and building on OS X Catalina 10.15.6 with Visual Studio Community 2019 for Mac 8.7.4. PancakeView is <IP_ADDRESS>0.
The only suspect thing I did for the sample app was to delete the UAP/UWP/WPF and Tizen projects and folders. For my own standalone app I just included the NuGet package as detailed in the readme, so that shouldn't be impacted by my messing around in the sample. Both exhibit the same behavior of not supporting any of the borders, corners, etc. which gives me some confidence that I didn't completely stuff it up. But there's clearly something wrong. I should also point out that the Android sample runs and looks awesome built on that same machine. I haven't been able to get the IOS version running yet.
Is there some critical step, dependency or something that I'm missing?

Apparently the trick is you need to reference the local (source code) project instead of the NuGet package. I thought I had targeted Xamarin.Mac full, but somewhere along the line that got switched back to Xamarin.Mac modern.
At least that got the sample project working. There is still some interesting stuff going on. For instance, the corner radius sample appears to have the top and bottom swapped, e.g. top left is actually changing the bottom left, and ditto for the right.

@colin-young You are very right regarding the corner radius. That is very odd that that's popping up. I see it in the sample too now so that's definitely a bug. I'm seeing a few more things working not as good as they once did, so maybe something along the way changed a bit. Do let me know if you find more things. In the meantime, I'll see what I can figure out.

Glad to hear it's not me this time (usually it is me). This is my first foray into Xamarin Forms on MacOS, so I'm still finding my way a bit. I'll let you know if I manage to figure out anything that makes things work reliably.
So far I've tried changing the target between Modern and 4.8 framework, including the library as a NuGet package vs. including the source with no luck.

Bit of an update: I may have messed something up in my message of 5 Sept. I am in fact able to use PancakView with rounded corners, etc it if I include the source as an additional project in my solution and reference it as a project dependency. The swapped corner thing is an issue as noted.
Not entirely sure what is going on. I am using the latest code from GitHub as of 70e5363db2d99a00437d42ea5783f3b6cb34c9e1, so maybe something has changed from the released NuGet that could be involved.

There's a new -beta version out too. Could you give that a try from the package repo?

Will check that out. Might take a couple days before I'm able to get to it though.


Add documentation for PredictKube scaler

This PR adds documentation for a new PredictKube Scaler.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Relates to https://github.com/kedacore/keda/pull/2418 & https://github.com/kedacore/keda/issues/2458

It looks like PredictKube is a service people need an API key for. I think it would be good if:

There is an introduction added before Trigger Specification clarifying that PredictKube is a service
Provide transparency on the data usage that is being sent to PredictKube. This can be as simple as adding a link to a privacy/legal page on your official docs but it should provide transparency if customer metrics are used to train the model as well

Thank you!

Thanks for this important point, Tom! We're currently working on our full policy to publish it in the nearest future.

Thank you! But I'd say this is a mandatory thing to have before we can merge this feature as it is pretty important for end-users to understand.

@daniel-yavorovich looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

done, thank you

looking good, could you please properly rebase this PR, so it contains only PredictKube related commits? Then we are good to go

done, thank you

@daniel-yavorovich I can see 32 commits in this PR and majority of them non related to this PR