TypeError: Cannot read property 'commentThreadCache' of undefined

Refs: https://github.com/Microsoft/vscode/issues/71103
I switched from a comment I typed (without submitting) to back to the PR description and got tons of errors in the console:
console.ts:134 [Extension Host] rejected promise not handled within 1 second: TypeError: Cannot read property 'commentThreadCache' of undefined (at d.then.t.onMessage.process.on.t.catch.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:729:916))
t.log @ console.ts:134
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
console.ts:134 [Extension Host] stack trace: TypeError: Cannot read property 'commentThreadCache' of undefined
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145567)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140735)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140512)
	at w.refreshExistingPREditors (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145256)
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145136)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140735)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140512)
	at getChildren.n._disposables.push.i.window.onDidChangeVisibleTextEditors.e (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145092)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at define.constructor._extHostDocumentsAndEditors.onDidChangeVisibleTextEditors.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575:198)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at u.$acceptDocumentsAndEditorsDelta (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:522:73)
	at d._doInvokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:622:11)
	at d._invokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:621:716)
	at d._receiveRequest (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:620:394)
	at d._receiveOneMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:619:141)
	at define.constructor._protocol.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:617:400)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:40:460)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at a (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172:467)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172:513)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at y._receiveMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:181:276)
	at define.constructor._socketDisposables.push._socketReader.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:178:415)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at f.acceptChunk (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:175:35)
	at define.constructor._register._socket.onData.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:174:410)
	at Socket.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:182:689)
	at Socket.emit (events.js:182:13)
	at addChunk (_stream_readable.js:279:12)
	at readableAddChunk (_stream_readable.js:264:11)
	at Socket.Readable.push (_stream_readable.js:219:10)
	at Pipe.onread (net.js:636:20) (at d.then.t.onMessage.process.on.t.catch.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:729:992))
t.log @ console.ts:134
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
mainThreadExtensionService.ts:60 [[object Object]]Cannot read property 'commentThreadCache' of undefined
$onExtensionRuntimeError @ mainThreadExtensionService.ts:60
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
mainThreadExtensionService.ts:61 TypeError: Cannot read property 'commentThreadCache' of undefined
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at w.refreshExistingPREditors (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at getChildren.n._disposables.push.i.window.onDidChangeVisibleTextEditors.e (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at define.constructor._extHostDocumentsAndEditors.onDidChangeVisibleTextEditors.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at u.$acceptDocumentsAndEditorsDelta (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:522)
	at d._doInvokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:622)
	at d._invokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:621)
	at d._receiveRequest (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:620)
	at d._receiveOneMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:619)
	at define.constructor._protocol.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:617)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:40)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at a (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at y._receiveMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:181)
	at define.constructor._socketDisposables.push._socketReader.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:178)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at f.acceptChunk (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:175)
	at define.constructor._register._socket.onData.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:174)
	at Socket.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:182)
	at Socket.emit (events.js:182)
	at addChunk (_stream_readable.js:279)
	at readableAddChunk (_stream_readable.js:264)
	at Socket.Readable.push (_stream_readable.js:219)
	at Pipe.onread (net.js:636)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:61
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
console.ts:134 [Extension Host] rejected promise not handled within 1 second: TypeError: Cannot read property 'commentThreadCache' of undefined (at d.then.t.onMessage.process.on.t.catch.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:729:916))
t.log @ console.ts:134
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
console.ts:134 [Extension Host] stack trace: TypeError: Cannot read property 'commentThreadCache' of undefined
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145567)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140735)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140512)
	at w.refreshExistingPREditors (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145256)
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145136)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140735)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:140512)
	at getChildren.n._disposables.push.i.window.onDidChangeVisibleTextEditors.e (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1:145092)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at define.constructor._extHostDocumentsAndEditors.onDidChangeVisibleTextEditors.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575:198)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at u.$acceptDocumentsAndEditorsDelta (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:522:73)
	at d._doInvokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:622:11)
	at d._invokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:621:716)
	at d._receiveRequest (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:620:394)
	at d._receiveOneMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:619:141)
	at define.constructor._protocol.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:617:400)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:40:460)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at a (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172:467)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172:513)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at y._receiveMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:181:276)
	at define.constructor._socketDisposables.push._socketReader.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:178:415)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:708)
	at f.acceptChunk (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:175:35)
	at define.constructor._register._socket.onData.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:174:410)
	at Socket.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:182:689)
	at Socket.emit (events.js:182:13)
	at addChunk (_stream_readable.js:279:12)
	at readableAddChunk (_stream_readable.js:264:11)
	at Socket.Readable.push (_stream_readable.js:219:10)
	at Pipe.onread (net.js:636:20) (at d.then.t.onMessage.process.on.t.catch.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:729:992))
t.log @ console.ts:134
$logExtensionHostMessage @ mainThreadConsole.ts:39
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
mainThreadExtensionService.ts:60 [[object Object]]Cannot read property 'commentThreadCache' of undefined
$onExtensionRuntimeError @ mainThreadExtensionService.ts:60
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636
mainThreadExtensionService.ts:61 TypeError: Cannot read property 'commentThreadCache' of undefined
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at w.refreshExistingPREditors (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at w.<anonymous> (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at Generator.next (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at new Promise (<anonymous>)
	at n (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at getChildren.n._disposables.push.i.window.onDidChangeVisibleTextEditors.e (/home/bpasero/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.79.0/media/extension.js:1)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at define.constructor._extHostDocumentsAndEditors.onDidChangeVisibleTextEditors.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at u.$acceptDocumentsAndEditorsDelta (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:522)
	at d._doInvokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:622)
	at d._invokeHandler (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:621)
	at d._receiveRequest (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:620)
	at d._receiveOneMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:619)
	at define.constructor._protocol.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:617)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:40)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at a (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172)
	at e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:172)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at y._receiveMessage (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:181)
	at define.constructor._socketDisposables.push._socketReader.onMessage.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:178)
	at u.fire (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at f.acceptChunk (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:175)
	at define.constructor._register._socket.onData.e (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:174)
	at Socket.t (/snap/code-insiders/98/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:182)
	at Socket.emit (events.js:182)
	at addChunk (_stream_readable.js:279)
	at readableAddChunk (_stream_readable.js:264)
	at Socket.Readable.push (_stream_readable.js:219)
	at Pipe.onread (net.js:636)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:61
_doInvokeHandler @ rpcProtocol.ts:399
_invokeHandler @ rpcProtocol.ts:384
_receiveRequest @ rpcProtocol.ts:304
_receiveOneMessage @ rpcProtocol.ts:226
_protocol.onMessage.e @ rpcProtocol.ts:101
fire @ event.ts:584
a @ ipc.net.ts:392
e @ ipc.net.ts:399
fire @ event.ts:584
_receiveMessage @ ipc.net.ts:678
_socketDisposables.push._socketReader.onMessage.e @ ipc.net.ts:549
fire @ event.ts:584
acceptChunk @ ipc.net.ts:212
_register._socket.onData.e @ ipc.net.ts:173
t @ ipc.net.ts:24
emit @ events.js:182
addChunk @ _stream_readable.js:279
readableAddChunk @ _stream_readable.js:264
Readable.push @ _stream_readable.js:219
onread @ net.js:636

Alternate repro steps:

Check out a PR
In the "GitHub Pull Requests" tree, open a file under the checked out PR (or switch from an opened file to something else)


Adjust the V2 API to exclude specific name types and use that to exclude the BN names in OrgBook

Please add to the V2 API for autocomplete that is being used by at least MOTI to allow the automatic filtering out of certain name types, and configure the feature in OrgBook BC to filter out BN names.  All clients calling the endpoint will automatically get the filtered list without altering their call to the endpoint.
If it is reasonable/easy, do the same for comparable endpoints in the V3 and later APIs, but don't activate the feature in OrgBook BC.

Specific API being used by MOTI that must be changed: http://registration.registries.ca/%7Bparam%7D/formatted
Other APIs might also need to be updated.


Allow using local vcpkg

As the title implies, there's no option to use locally installed vcpkg, instead of reinstalling vcpkg in every project.

This ensures that everyone is on the same version and I believe this is intentional.

This ensures that everyone is on the same version and I believe this is intentional.

this should be optional as it's really inconvenient with mutliple projects, lets say im using LLVM while i already have it compiled on my local vcpkg clone why would i have to compile for another 8 hours everytime i create a project that uses llvm with cmkr?

You should just use find-package directly in that case and set the right CMAKE_PREFIX_PATH.

i still believe it's redundant and disk consuming to have the same vcpkg packages installed in every project too 🤷♂


HTML content

You have to add all HMTL content, not just the h1

Do you wanna say every tag in HTML !?😅

Yesss 😅

@Just2sire can you add the entier content to HTML file ?

I don't think so😅. Threre are too many things


fakeroot 1.28 doesn't exists upstream anymore

https://github.com/BobBuildTool/basement/blob/b7c6482cf66c0c67f9e684a11ac5d8cb1b7df03d/recipes/devel/fakeroot.yaml#L4-L15
no idea, but they have removed it upstream... 🙄
what shall we do? upgrade to 1.29 or searching for a mirror?

The upstream repo seems to be https://salsa.debian.org/clint/fakeroot. I guess we should clone from there. Updating is certainly a good idea but should be a separate commit...

hm. i added a pull-request. but just updated the file version. i wouldn't change the recipe to git clone. hopefully they will not delete this version on fileserver again.

Ok. Let's hope for the best.


[WebApp] ReviewAfterRedemption functionality - added

https://www.notion.so/saladtech/Frontend-Share-Review-after-redemption-ee91894f785b498f809af4b7930e00d5?pvs=4
https://www.figma.com/file/3DISvTpocVhu34W5pUWbGu/Share-%2F-Review-TrustPilot-Modal?type=design&node-id=44-9427&mode=design&t=aofFlSafLLf4jnv7-0#referral

PR is created from the initial repo, not with fork - to resolve the permission pipeline issue, described here


Changes MediaUiModel to use Paintable

Continuation as part of #1868, to reduce dependency on uris across the library.

https://github.com/google/horologist/pull/2182 is going to merge conflict with this.  But also I much appreciate this model, can see why it's useful.


Release v2 SDK

Closes #18

This pull request is a draft pr. So, please dont merge it

Also added new to-do widget. Check out #18

#43

Needs to support vote check api
(Added to docs)
@zero734kr

Will only support svg format for the widget.
Needs action for it. Should convert it to png, jpg, webp etc.

Will only support svg format for the widget.
Needs action for it. Should convert it to png, jpg, webp etc.

Already done

Actions failing. Have to do something for it


Intellij IDEA support?

Hi thanks for the lib! I wonder whether there is a Intellij IDEA plugin? I cannot find one by searching...

I don't believe that an Intellij plugin exists, although there is a discussion started by someone who's working on one: https://github.com/casey/just/discussions/1097


FFI support for packed structs

Amazingly, it turns out that some Win32 structs are packed. (In my case, OPENFILENAMEW). I don't know how many Win32 structs are packed, but the lack of struct packing makes it difficult to interface with Win32.
Example:
class OpenFileNameW extends Struct<OpenFileNameW> {
  @Int32()
  int lStructSize; // DWORD         lStructSize;

  @IntPtr()
  int hwndOwner; // HWND          hwndOwner;

  @IntPtr()
  int hInstance; // HINSTANCE     hInstance;

  Pointer<Uint16 /* CWSTR */ > lpstrFilter; // LPCWSTR       lpstrFilter;

  Pointer<Uint16 /* WSTR */ > lpstrCustomFilter; // LPWSTR        lpstrCustomFilter;

  @Int32()
  int nMaxCustFilter; // DWORD         nMaxCustFilter;

  @Int32()
  int nFilterIndex; // DWORD         nFilterIndex;

  Pointer<Uint16 /* WSTR */ > lpstrFile; // LPWSTR        lpstrFile;

  @Int32()
  int nMaxFile; // DWORD         nMaxFile;

  Pointer<Uint16 /* WSTR */ > lpstrFileTitle; // LPWSTR        lpstrFileTitle;

  @Int32()
  int nMaxFileTitle; // DWORD         nMaxFileTitle;

  Pointer<Uint16 /* CWSTR */ > lpstrInitialDir; // LPCWSTR       lpstrInitialDir;

  Pointer<Uint16 /* CWSTR */ > lpstrTitle; // LPCWSTR       lpstrTitle;

  @Int32()
  int Flags; // DWORD         Flags;

  @Int16()
  int nFileOffset; // WORD          nFileOffset;

  @Int16()
  int nFileExtension; // WORD          nFileExtension;

  Pointer<Uint16 /* CWSTR */ > lpstrDefExt; // LPCWSTR       lpstrDefExt;

  @IntPtr()
  int lCustData; // LPARAM        lCustData;

  Pointer<Void /* OFNHOOKPROC */ > lpfnHook; // LPOFNHOOKPROC lpfnHook;

  Pointer<Uint16 /* CWSTR */ > lpTemplateName; // LPCWSTR       lpTemplateName;

  Pointer<Void /* EditMenu */ > lpEditInfo; // LPEDITMENU    lpEditInfo;

  Pointer<CString> lpstrPrompt; // LPCSTR        lpstrPrompt;

  Pointer<Void> pvReserved; // void          *pvReserved;

  @Int32()
  int dwReserved; // DWORD         dwReserved;

  @Int32()
  int FlagsEx; // DWORD         FlagsEx;
}

sizeOf returns 168, but in Godbolt with the actual comdlg headers, the result is 152. https://godbolt.org/z/6Tyt3h

I don't see any indication in the commdlg.h that the struct is not using the normal alignment rules.
However, I did notice that some of the fields are conditionally included:
#ifdef _MAC
   LPEDITMENU   lpEditInfo;
   LPCSTR       lpstrPrompt;
#endif
#if (_WIN32_WINNT >= 0x0500)
   void *        pvReserved;
   DWORD        dwReserved;
   DWORD        FlagsEx;
#endif // (_WIN32_WINNT >= 0x0500)

Are you sure you were correct to include these?

Ah sorry, my struct definition is incorrect, since the one in Win32 API docs don't match up. Thanks Microsoft. https://docs.microsoft.com/en-us/windows/win32/api/commdlg/ns-commdlg-openfilenamew
commdlg does include pshpack1.h which turns on byte packing on 32-bit targets, so 32-bit platforms are affected by it. https://godbolt.org/z/JAHfQ7

@ds84182 did using the correct struct definition solve your problem?

For reference: most compilers support a form of struct packing with pragmas or attributes.

GCC: https://gcc.gnu.org/onlinedocs/gcc-3.3/gcc/Type-Attributes.html
LLVM/Clang: https://releases.llvm.org/3.4/tools/clang/docs/UsersManual.html
MSVC: https://docs.microsoft.com/en-us/cpp/preprocessor/pack?view=vs-2019

@dcharkes Yep, it solved my problem on 64-bit Windows, but I know on 32-bit Windows it'll be an issue still. I can't find any open-source C libraries that use packed structs via github search right now,

@ds84182 Do you need packed structs in Win32, or is it just that the struct is different on Win32? You could work around the struct being different on 64 and 32 bit Windows by introducing a second struct just for win32, and duplicating the function signatures that use that struct. If that is really really un-ergonomic, that gives us a reason to address https://github.com/dart-lang/sdk/issues/35768.

Adding support for packed structs should be relatively easy. (1) We need to specify a way that a struct is packed, and (2) our offset and size calculations need to take this into account.
Possible syntax
@Packed()
class MyStruct extends Struct {
  @Int8()
  int x;

  @Int64()
  int y;  // Is 1-byte aligned rather than 8-byte aligned.
} // Has a size of 9 bytes, rather than 12 or 16 bytes.

However, we might want to add .valueUnaligned and .valueUnaligned = to support unaligned reads and writes. Otherwise these packed structs might be unusable on 32-bit arm.

An example of a packed struct that I've just hit on Win32 is TASKDIALOGCONFIG, and I'm blocked because of this issue.
Per the declaration in CommCtrl.h:
#include <pshpack1.h> // declares #pragma pack(1)

typedef struct _TASKDIALOGCONFIG
{
    UINT        cbSize;     // 4 bytes (Uint32)
    HWND        hwndParent; // 8 bytes on 64-bit (IntPtr)
...
}

#include <poppack.h> // declares #pragma pack()

The sizeOf() for this struct is ultimately 16 bytes too long because of alignment issues.


Deprecate admin permissions helper; move to Page model

Basically, migrating wagtail.wagtailadmin.utils.users_with_page_permission to wagtail.wagtailcore.models.PageBase. get_users_with_permission. Doing so makes it possible to override the default behaviour on Page subclasses.
Before merging, some discussion will be required on how this should be made consistent with Page.permissions_for_user - it seems the admin helper used some simplifying assumptions. Though it would be far slower, it seems that in order to get all users with an appropriate permission, we must fetch all users and test their permissions with permissions_for_user. Something like
def get_users_with_permission(self, permission, include_superusers=True):
    return [
        upp.user for upp in filter(
            lambda upp: permission in upp.permissions,
            self.permissions_for_user(user) for user in get_user_model().objects.all()
        )
    ]

In order to retain the include_superusers behaviour, the PagePermissionsTester would require some refactoring.
Something else to consider is the deprecation warning. If you're happy to deprecate the old helper, I don't know what the policy on which 'version' should be used for the warning (1.5?). The original helper wasn't used anywhere in the Wagtail code outside of the utils.py file,

Cheers @jimr! Will give this some more thought when I get chance, but my initial feeling is that we want to move towards permission logic being less coupled to the core models, not more - see #1384.

Ah, yep, I hadn't seen that, looks sensible. Our requirement is simply to have custom permissions around pages, so provided the mechanism is uniform and flexible, we'll take it :) I the meantime is there any merit in shifting this functionality around as above? If not, go ahead and close if you like.
Our immediate requirement was to prevent all moderators being spammed with an email whenever a page is submitted for moderation - in our implementation, we want everyone to have moderation permissions, but for specific moderators to be selected for each page.


Fix naming collision in dashboard app module.

Current coverage is 83.47% (diff: 100%)

Merging #2147 into master will not change coverage

@@             master      #2147   diff @@
==========================================
  Files           303        303
  Lines         15071      15071
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          12581      12581
  Misses         2490       2490
  Partials          0          0

Diff Coverage
File Path

•••••••••• 100%
src/oscar/apps/dashboard/app.py

Powered by Codecov. Last update 1f4d6f6...1bbd99a


Improve creation of additional variants in JvmEcosystemUtilities

These changes were originally made to support a CLASSES_AND_RESOURCES variant for an
upcoming compileElements PR, however plans changed and these changes are not required
for the upcoming PR. Nonetheless, they improve the current state of JvmEcosystemUtilities.
This PR makes the following notable changes:

Remove JvmPluginExtension/DefaultJvmPluginExtension. This extension is internal and is not
in use in production. It acts simply as a proxy to JvmPluginServices. The only use of this
extension was in tests, all of which have been refactored to reference JvmPluginServices directly.
In reality, these tests should be referencing public APIs, but updating these tests are out of
scope for this PR. The existence of this plugin hinders further modification/development of
JvmPluginServices, and since it is both internal and not in use, I opted for outright removal.

Improve DefaultSourceSetOutput's tracking of tasks which contribute to output directories.
The previous implementation tracked all tasks which contributed to any registered classes
directory, requiring a contributing task to be registered in a separate method call than when
the class directory itself is added. This meant we were not able to map which tasks contributed
to which classes directory. This change combines adding the classes dir and the contributing task
into a single method call, thus allowing us to remember which task contributes to which directories.

Update DefaultSourceSetOutput to track which task contributes to the resources output directory.
The previous implementation required out-of-band knowledge of how the resources directory was
generated, however this implementation updates resources to behave similarly to how classes worked
previously, in that the source set output is now aware of the task which contributes to the resources output.

Update configureClassesDirectoryVariant in JvmEcosystemUtilities to accept a Configuration instead of
the name of the configuration. This way we can avoid a configurations.all call which iterated through all
configurations, as each usage of the existing method was called after the configuration was created and thus
we already had access to the configuration in question when making the initial call.

Add a configureResourcesDirectoryVariant to JvmEcosystemUtilities to be consistent with the corresponding
method which configures the classes variant. Update runtimeElements to use this new method.

Update documentation of JvmEcosystemUtilities to assert this interface is intended for internal use as opposed
to use by plugin authors.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


double-beep: Watch cashfacts.de

double-beep requests the watch of the watch_keyword cashfacts\.de. See the MS search here and the Stack Exchange search here.

cashfacts\.de has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Changed images to links . Text fixed to explain images

closing since you added a new guide under Multiple


Fix encryption in IPAM ENI mode

The PR consists of two main fixes to make encryption functional on EKS -

Add routing rules for cilium_host ENI secondary IP address
Attach bpf_network program to the correct interface for decryption to work

Following is out of scope of the PR, and will be addressed in follow-up PRs to simplify backporting :

Refactor loader.Reinitialize(...)
Review back-and-forth type conversions for RoutingInfo
Writing datapath header defines (IPV4_ENCRYPT_IFACE and ENCRYPT_IFACE)

Release note
Make pod-to-pod encryption functional in the IPAM ENI mode.

test-me-please

test-me-please

test-me-please

GKE failure is same as https://github.com/cilium/cilium/issues/14915

/home/jenkins/workspace/Cilium-PR-K8s-GKE/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:461
Unable to restart unmanaged pod with 'kubectl -n kube-system delete pod kube-dns-66d6b7c877-gtctl': Exitcode: 1
Err: exit status 1
Stdout:

Stderr:
Error from server (NotFound): pods "kube-dns-66d6b7c877-gtctl" not found

test-gke

Re-run failed due to some infrastructure related issues - https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4307/console

test-gke

test-me-please

@joestringer FYI - I pushed a new commit with updated getting started guide.

@aditighag would you mind sending the docs changes out as a separate PR? I think the rest was almost ready to merge, but for the docs we may need to iterate a few times (and none of that will require triggering CI). Also would be good to specifically get John's input as I think there are some extra missing pieces that we haven't yet taken into account.

@aditighag would you mind sending the docs changes out as a separate PR? I think the rest was almost ready to merge, but for the docs we may need to iterate a few times (and none of that will require triggering CI). Also would be good to specifically get John's input on the docs side as I think there are some extra missing pieces that we haven't yet taken into account.

Yeah, that makes sense. We'll need to iterate over the document once endpoint-routes is set to to true by default anyway.

test-me-please

test-me-please

GKE job hit known flake #14915 , otherwise CI looks good.


PR Request for the Wiki: Added additional info on installation and lintr

PR for WIkis: GitHub doesn´t allow you to edit wikis or create PullRequests despite the fact that they are repos, I followed this guide I found on StackOverflow and am creating this issue as a stand-in instead.
Is your feature request related to a problem? Please describe.
As per the discussion here and the PR here I decided to also add the documentation changes to the Wiki, including the optional suggested lintr configuration mentioned in the comment.
Describe the solution you'd like
I edited the Code_linting markdown to be better suited for a guide on how to configure your lintr installation, reorganized some paragraphs and added optional suggested configuration. As mentioned in the discussion, this suggested configuration should be evaluated by the collaborators as the original user who posted it did not intend for it to be a default configuration, besides, the things that are turned off are his personal preferences, not necesarily something that should be suggested for all users, their value and inclusion should be approved by the people who have worked on this project.
Each linter edited has a comment on what warnings it is turning off.
Besides that, I edited all installation pages for all OS's to have an additional section for how to configure the linting package, which point back to the code_linting wiki.
Additional context
Here is the edited Wiki Repo (link)

I just noticed that the wiki can be edited -__-
Either way, I can go ahead and implement these changes directly on the wiki, but I'd prefer to wait for them to be reviewed first, especially the parts that are marked as optional to know wheter or not I should insert them in the Wiki.
Thanks :)


Geeting Error response from daemon: invalid mount config for type "bind": invalid mount path: 'config.yml' mount path must be absolute

Hi,
just checking out the framewark after watching your presenation at TDWI.
Using: Docker Desktop on Apple Silicon (ARM)
Using:
platys init --enable-services KAFKA,KAFKA_KSQLDB -s trivadis/platys-modern-data-platform -f
platys gen
Getting:
...
Error response from daemon: invalid mount config for type "bind": invalid mount path: 'config.yml' mount path must be absolute
Regards
Frank

Hi, just checking out the framewark after watching your presenation at TDWI.
Using: Docker Desktop on Apple Silicon (ARM)
Using: platys init --enable-services KAFKA,KAFKA_KSQLDB -s trivadis/platys-modern-data-platform -f
platys gen
Getting: ...
Error response from daemon: invalid mount config for type "bind": invalid mount path: 'config.yml' mount path must be absolute
Regards Frank

I receive the Error too. Appreciate any help
Regards
Pascal


feat(autoware): update architecture_type .webauto-ci.yaml

Description

cc. @h-ohta, @mitsudome-r
The architecture_type param of the .webauto-ci.yaml file needs to be updated to be able to run scenario_simulator in the AWF project in Autoware Evaluator. Currently, Autoware cannot recognize the traffic lights.
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 Thanks for the PR. However, this seems to be a duplicate PR of https://github.com/autowarefoundation/autoware/pull/4098 so I'm closing this PR.


Update productCategories and products.json

New seed and categories to match what Sue has outlined for categories

Will also have to update cypress tests that call on specific information of products/update the pantry to reflect new products seed. Will also have to change the pantry cypress tests that call on specific info.

Also need to change store selector to add RealFoodHub and Other Store options

The product categories and products.json have been upgraded.


feat(#17): register url prefix sampler for flamingo

closes #17

waits for https://github.com/i-love-flamingo/flamingo/pull/442


New Rule Proj2100: Private Assets

The purpose of the rule is simple: packages that benefit from begin added as private asset should be. The best way to state this in a (positive) sentence? No clue. I'm also thinking about solutions that scale better then a static list, but do not (often) lead to false positives.

Isn't there some intelligent way to determine if a dependency is an analyzer? Visual studio seems capable of doing this. That way all analyzers (and by extension code generators) would automatically be identified as such.

Isn't there some intelligent way to determine if a dependency is an analyzer? Visual studio seems capable of doing this. That way all analyzers (and by extension code generators) would automatically be identified as such.

I could not find how.


add ui for excluding numbers other than normal

hmm auto responding to premium sms doesn't make sense so get rid of this.


Dynamic header component in dashboards

Is your feature request related to a problem? Please describe.
The Header component is a great way to add titles to dashboards however the text is static.
Describe the solution you'd like
We would like to dynamically show the category selected by the user. For example in this dashboard a sector is chosen. The charts update accordingly. However it would be much clearer if the chosen category was clearly visible in a dynamic header component.
Describe alternatives you've considered
Did not find any alternatives.

@cccs-jc Is this issue still of interest to y’all? Tempted to close it as stale, but also willing to convert it to an “Ideas” thread if that’s relevant. Nielsen made it possible to add such dynamic dashboard components, but I’m not sure if that scratched the issue for you. If you do have such a feature built out, it might be an interesting OSS contribution!

Heard back that this isn't a priority for now, but since the framework for such a feature now exists, it'll get re-opened with updated context if it becomes a priority again.

Interested!

Interested also here!

We would love to have this capability

Hope to have this soon! <3

Interested!

Interested !!

Interested! The same for "Chart title" as well

interested


HIVE-19653: Incorrect predicate pushdown for groupby with grouping sets.

The two failed tests seem to be unrelated to the changes...

The two failed tests seem to be unrelated to the changes...

@jcamachor Can you take a look at the changes? thanks.


Native UI?

Toying with the idea of writing a native UI for Syncthing, based on the UI proposition that's floating around the forums.
Pros:

Slightly slicker
Greatly reduced memory footprint

Cons:

Cognitive dissonance for people coming from the web UI
Always playing catch-up with Syncthing
A significant undertaking, at the expensive of other work/features

Does anyone have any thoughts on this?

A good point - one I remembered on the forums but forgot here

Actually I think I might go for this. CEF's causing me way too much pain, see #37 for instance, and the Syncthing GUI isn't particularly complex

Actually, after mulling this over, I think I'm going to support both. I'll leave an option to switch between a native GUI / CEF

How does this look like? Reason I'm asking is I have 2 small issues with current UI, so if there will be both native GUI / CEF I will raise them but I don't want to bother you with them if you're going to drop CEF in month or 2.

I'm still undecided. I think I'll have to keep the CEF UI around, if nothing else because Syncthing's web UI is always going to be up to date, and I'm always going to be playing catch-up, so new features may not be available on the native UI.

Closing as inactive

I don't think that's a good idea. If you'd really implement this I would prefer it to be an option, as I personally would prefer to use the "working-solution", the already existent web-ui. Also I don't think, that the lower memory footprint really is that important, as systems get more and more ram over time and something like 4-8 GB is pretty common today. Of course it would be great to have a lower footprint, but I don't think it's worth the effort - especially if it's really implemented as an option.

I think I've come to the conclusion that there's not much point in doing anything here until syncthing hits 1.0 - there's too much risk of something breaking


Fixed broken link

Codecov Report

Merging #719 (1eaa660) into master (d32c85d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #719   +/-   ##
=======================================
  Coverage   93.54%   93.54%
=======================================
  Files          19       19
  Lines         837      837
  Branches      199      199
=======================================
  Hits          783      783
  Misses         38       38
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32c85d...1eaa660. Read the comment docs.


Li and kci factor order reduction

Reduce order of  Li1, Li2 to just Li and kci1, kci2 to just kc1; There is no point of having 2 separate seasons on the initial phase.

Done and updated on Part 1.


Template Store Header

Change in index.html
Added "Template Store" Header and linked it to listing page

Not required


added ping pong game

Hey @aryangarg08 can you please put a label Hacktober-Accepted on my PR.

@aryangarg08 thank you :)


Feature/turbine stream service

After upgrade to spring-boot 2, some users report about hystrix dashboard is not accessable due to IOException: Broken Pipe.
The fix is to separate turbine-stream from monitoring service. and after the fix Hystrix Dashboard is working fine and we can monitor services through turbine stream.

Codecov Report

Merging #41 into master will decrease coverage by 0.19%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##             master      #41     +/-   ##
===========================================
- Coverage     79.28%   79.08%   -0.2%
- Complexity      227      229      +2
===========================================
  Files            50       51      +1
  Lines           584      588      +4
  Branches         12       12
===========================================
+ Hits            463      465      +2
- Misses          119      121      +2
  Partials          2        2

Impacted Files
Coverage Δ
Complexity Δ

...a/com/piggymetrics/account/AccountApplication.java
33.33% <ø> (ø)
1 <0> (ø)
:arrow_down:

...ccount/client/StatisticsServiceClientFallback.java
50% <50%> (ø)
2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2880d...5cb4627. Read the comment docs.

@Dovchiproeng Fixed that. Turns out docker has changed docker login command, and that part of the build was silently failing for quite some time. Thanks for pointing that out!


Only test AWS Lambda

This is just experimental to update our secrets in Github Actions used by the AWS Lambda tests

Thanks for taking care of stripping down the perms! I'll close this since we no longer need it.


Versioning dctap-python

@nishad The current version number is 0.2, but that seems low. Can you point me to guidelines we might follow?

SemVer [1] is preferred. CalVer is an alternative, but I prefer SemVer for our use-case. If we are planning to adhere to SemVer, then 0.2 can be minor and major, so it doesn't break anything.
Along with versioning, I strongly advocate for maintaining a CHANGELOG.md as per Keep A Changelog [3] specification.
[1] https://semver.org/
[2] https://calver.org/
[3] https://keepachangelog.com

@nishad I want to become more disciplined about keeping a change log and versioning once DCTAP is presented to LD4 next week. I also want to improve the granularity and messages for my commits (do you have a good link to a style guide?) and optimize the pace and content of my pull requests (do you prefer to be asked for a review only for larger changes? Better focused and frequent, or broad and infrequent?).
In the meantime, we should make sure that by Friday, 23 January, the PyPI version is up-to-date with the latest version on Github. Currently, the version number (0.2.2) is recorded in __init__.py and cli.py -- not, for example, in pyproject.toml. Does PyPI read __init__.py?
If I wanted to update PyPI right now (would you suggest it?), I guess I would need to change the version (0.2.3).
Good idea?

There are a lot of examples and articles about the commit message practices. I am no that keen on following any conventions, though. Usually, I stick with something that mutually works for all collaborators. However, Linus's explanation of commit messages is popular and worth a read [1].
Reviews are good if something is suggestive and still under discussion. Usually, the collaborators will reach a convenient consensus about review requests at some point. But as a rule of thumb, for the projects with a small group of known collaborators with commit access, I request the project maintainers to review the PR to ensure that they are aware and agree with the changes. If I don't have commit access to the repo,  in most cases, I issue a PR without a review request and often request a review if the PR is updated based on the maintainer's feedback.
I prefer the version number to be maintained in a 'single source of truth' [2] and reuse it wherever required. So __version__ from __init__.py can be used everywhere else, including cli.py.
Since PyPI is our release channel, feel free to release all versioned tags from GitHub. The simple guideline is -- "release early, release often" [3].
[1] https://github.com/torvalds/subsurface-for-dirk/blob/a48494d2fbed58c751e9b7e8fbff88582f9b2d02/README#L88
[2] https://en.wikipedia.org/wiki/Single_source_of_truth
[3] https://en.wikipedia.org/wiki/Release_early,_release_often

Resolved - we are using SemVer.


Move test files and only write SystemJS configuration if there is a l…

…ib directory
Closes #116

Coverage increased (+0.03%) to 97.248% when pulling c467a6de84e6598c051990fb8db179ef23699da1 on system-lib-directory into e1d8ff099d70e752007cc29d04f55744eef5cda8 on master.

Coverage increased (+0.03%) to 97.248% when pulling 42f70c8bae1a3132fb31d6ee23514c0dd1a40b8f on system-lib-directory into e1d8ff099d70e752007cc29d04f55744eef5cda8 on master.

Coverage increased (+0.04%) to 97.26% when pulling ed865e7d58d0d13f4364c52f40881f25db1efc26 on system-lib-directory into e1d8ff099d70e752007cc29d04f55744eef5cda8 on master.


Use-after-free in safe code through delegate support

The way delegates work right now, it's possible to pass a closure that takes references to the local stack frame that will be invalidated when the closure is called. For instance:
use winit::event_loop::EventLoopProxy;
use bindings::windows::ui::xaml::controls::{Button, IButtonFactory};
use bindings::windows::ui::xaml::RoutedEventHandler;
use winrt::Object;
fn new_btn(el_proxy: EventLoopProxy<()>) -> winrt::Result<Button> {
    let next_btn = winrt::factory::<Button, IButtonFactory>()?.create_instance(Object::default(), &mut Object::default())?;
    next_btn.click(RoutedEventHandler::new(|_, _| {
        let _ = el_proxy.send_event(());
        Ok(())
    }))?;
}

When the next_btn is clicked, the closure will try to call send_event on el_proxy through a reference (since closures take by reference by default, el_proxy will still be owned by the new_btn stack frame and not moved to the closure). But el_proxy goes out of scope once that function returns, and now the Button has a click handler that will cause a use-after-free when it's called, all in safe code!
There's a full reproducer of the crash is at https://github.com/roblabla/ubuntu-installer/tree/crash-reproducer . Doing cargo run and clicking the button causes an access violation.
I believe this needs to be fixed by giving a lifetime to delegates (e.g. the *Handler types) and tying the closure lifetime to the delegate lifetime. Most functions would then require the handlers to have a 'static lifetime.

This is very easy to reproduce. Here's a simplified repro:
winrt::import!(
    dependencies
        os
    modules
        "windows.foundation"
);

fn main() {
    type Handler = windows::foundation::AsyncActionCompletedHandler;
    let mut data = vec![1];
    let d = Handler::new(|info, status| {
        data.push(2);
        Ok(())
    });
    drop(data);
    d.invoke(IAsyncAction::default(), AsyncStatus::Completed).unwrap();
}

This results in:
 process didn't exit successfully: `C:\$CODE_PATH\winrt-rs\target\debug\deps\delegates-d02c3afa680bc4c2.exe non_generic` (exit code: 0xc0000374, STATUS_HEAP_CORRUPTION)


Single CGC computation + locking on read

As discussed with @lkdvos
Instead of computing the CGCs of all s3 when encountering s1 x s2 => s3, we just compute the CGCs of the relevant s3.
Following discussion, I added a lock on reading the CGC file. I am relatively convinced it is not useful.
Finally, I slightly modified the dist_cache_info function so it does not crash if some pid file are still there, or if some files are corrupted. Instead it simply reports them. I added an option to clean these files. I did not test it enough (due to ownership shenanigans).

This looks great!
I just added some docstrings to reflect the changes, when the tests turn green I'll merge this and tag a new release.
I am also pretty sure the pidlock on read is not doing a whole lot, but in principle the scratchspace is shared per user, so if you would start up two sessions of Julia at the same time, it might still mess up? Honestly, I'd rather err on the cautious side with these things.

I also saw this, I am not sure if this is just the interplay with CI or an actual problem. Should I hold off on tagging, such that you can try it out for a while longer before I release this version?

Maybe let's wait the night.
On Wed, 31 Jul 2024, 17:39 Lukas, @.***> wrote:

I also saw this, I am not sure if this is just the interplay with CI or an
actual problem. Should I hold off on tagging, such that you can try it out
for a while longer before I release this version?
—
Reply to this email directly, view it on GitHub
https://github.com/QuantumKitHub/SUNRepresentations.jl/pull/20#issuecomment-2260817945,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXMRNR55UQAEHNNA6SJPHXTZPEAL5AVCNFSM6AAAAABLYCVF32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRQHAYTOOJUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Adds CORS possibility to nginx

defaults to * for vagrant and ansible_host otherwise

Hi Peter, thanks for the PR, I think it makes sense to add this!
I would however just use the existing variable mutalyzer_server_name since that is supposed to be the domain name for accessing the website and webservices. ansible_host is what is used by Ansible to connect to the machine, which can be very different.

Ah yes, I see, that does make more sense. I've updated the PR.

I'm sorry, I was confused. The Access-Control-Allow-Origin header should contain the origin (domain plus scheme) that is allowed to access the resource. It does not make sense to set it to the host that is serving the resource.
In case of Mutalyzer, non of the API responses are personalized (there is no authentication of any kind), so I would say it is safe (and easiest) to always set it to *. Also, if it is set to anything other than *, Mutalyzer should also include Origin in the Vary response header (see MDN).
In other words, if we want to enable CORS with the Mutalyzer JSON API, I think it's best to just include this header with a non-configurable value of *.

Sorry for the delay in replying. Ultimately it's up to you, but I wouldn't recommend forcing the CORS header to be *. It could be alright for a default, but I was looking in to deploying the API and using it alongside another piece of software and for that I would want to be able to configure the headers differently for development and production servers at least.

Well, the point of the same-origin policy is to not give third parties access to resources on the user's behalf (i.e., using it's cookies, HTTP auth, etc). This is irrelevant for resources that behave the same for all users (i.e., don't have any form of sessions). For those kind of resources, the * CORS origin is appropriate (and cookies etc are actually not even sent when using *).
This applies to the Mutalyzer JSON webservice. It has no state, no user sessions. The CORS headers are specific for the resource (path), so even if you host other resources on the same domain which do have user sessions, this should not be an issue.
One reason I can see to not implement this is the possibility for Mutalyzer to get sessions in the future. During development of such a feature, one could forget to change the * CORS allowed origin.
Regardless, I think the PR makes sense and could definitely be useful to people. I'm not the Mutalyzer maintainer anymore, so I'll leave it at that ;)


Add mpi4jax

See mpi4jax.

This looks great @PhilipVinc, thanks for adding it!

This looks great @PhilipVinc, thanks for adding it!


Good idea- but W10 only.

Hi,
We love the idea- but limiting it to stinky Windows 10 isn't a good idea. W10 is the most spying version yet. It should be extended at least as far back as 8 and 7.
We are a couple and we both took our 10 computers and switched to 10 only running in a VM once every blue moon. 10 SUCKS!!!

I'm sorry we haven't provided Windows compatibility to suit your needs. Our own access to non-W10 systems is currently limited due to the pandemic. Providing greater Windows compatibility is certainly on our future todo list.

If you care about privacy, you shouldn't be using Windows to begin with.


Fix android bg

Splitting this change from the async PR as the async PR no longer relies on background():
https://github.com/ARM-software/devlib/pull/569

@marcbonnici it looks like the branch was merged in master but this PR is still open, have you done it manually and should we just close the PR ?

Ah it looks like these changes was accidentally merged as part of #639 so it looks like we can close this for now.


how to navigate through a link when a button is choose by user?

Rasa Core version:
Python version:
Operating system (ubuntu):
Issue: I added up buttons in my yml file.In the example of mood bot buttons are implemented and image is displayed.I'm trying to do the same thing but instead of giving an image, I tried out a  link.
I'm not get any type of response when i give a link.when I replaced the link with image and put same info link , i'm getting only text response but not needed link and details of link.
Content of domain file (if used & relevant):
 utter_mg_query:
    - text : "Sorry i can't help you on that info. Please provide your details here"
      link: "https://xxxxxxxx/contact-us-form/

I connected my bot model to slack and testing my bot, please let me know, how can I display link instead of image.
& one more problem , if i'm trying to fix more than 5 buttons, then none of the buttons are shown in the slack,I'm just getting text message.
Thanks in advance

yeah ! I know that, all I need is to store the link in a word and when user clicks on the words it will navigate to that link in new tab.(Like anchor tags in html)

hi,
Even i also tried to display the links in my chat bot. Can anyone please help me on this.
Thanks in Advance.

I'm afraid there's no way to do that really - it'd kind of dependent on which platform it's deployed on. And as far as I know most of them don't offer that option

hdfc bot as that where all the matter in the blue text get navigates to new tab when we click on that

Sure, as I said it's platform dependent. So on Messenger or Telegram for example this isn't possible.


Add ability to get/set forced bed location. Resolves #955

Changes Vector3d to Tuple<Vector3d, Boolean>
See #955

@gabizou do you agree this should be represented as a Tuple<Vector3d, Boolean> or not?

This PR is now rebased on the bleeding branch

I'd personally open a new PR here, this is pretty much unreadable now because you don't see the actual file changes.

+1 to the above, this is just bad to look at at this point


Add ParseRequestLineSplitBufferWithoutNewLineDoesNotUpdateConsumed test back

Was removed as part of https://github.com/aspnet/KestrelHttpServer/pull/2234

https://github.com/aspnet/KestrelHttpServer/pull/2234/files#diff-babc5b9d34240d24428368005d81fe1aL373

@pakrym: I can take this one unless you already started.


Changelog update for stable branch.

Updates changelog on stable.  Updates here will be merged to master.

@jmagman and @reidbaker could you check the changelog entries for 3.24.5 to make sure they make sense?


add device, configuration and deviceconfiguration cupport

Coverage increased (+0.2%) to 96.024% when pulling b00b04aedc56661acd8e1f6a89c8b2c5d6efa0c1 on feature/configurations into ca3ee936552115cbc125f8efa0fe335b1990c89a on master.


Add detail to install node.js with brew

Description:
Added to the docs regarding downloading node.js with homebrew.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

[x] PRE-COMMIT. You ran pre-commit on all commits, or else, you
ran pre-commit run --all-files at the end.
[x] FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
Run cd webapp && yarn types while the back-end is running.
[x] USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
our users.
[x] DEV CHANGES.

Update the documentation if this PR changes how to develop/launch on the app.
Update the README files and our wiki for any big design decisions, if relevant.
Add unit tests, docstrings, typing and comments for complex sections.

@lindsaydbrin - don't forget this PR!


Remove deprecations

It seems like some deprecated functions were not removed in 0.19, e.g. https://github.com/mne-tools/mne-python/blob/b3f46657fad1599262b6290b0c97a14d264ffc78/mne/io/edf/edf.py#L30-L32 and https://github.com/mne-tools/mne-python/blob/76ee63ff92b0424a304a12532d0cb53c0833a0ec/mne/simulation/evoked.py#L84-L86 Does anyone already have a script to automate this? Otherwise, I can remove these things manually.

We're removing them in 0.20 then.
too late to fix after the release.

Made a quick PR for the first one in #6830, the second one was merged with #6825


Rename OuterProductElement -> TensorProductElement

This renaming has now happened in firedrake, so do the same here.

Looks familiar, merging.


JAMES-4840 refactor quota for cassandra: create cassandra DAOs

Please rebase :)

Approved but remembered this is still not solved: https://github.com/apache/james-project/pull/1673#discussion_r1295402581
Just put String for identifier , and I will be alright :)

09:50:13,857 [INFO] There is 1 error reported by Checkstyle 10.12.1 with checkstyle.xml ruleset.
09:50:13,859 [ERROR] src/main/java/org/apache/james/core/quota/QuotaCurrentValue.java:[24,8] (imports) UnusedImports: Unused import - org.apache.james.core.Username.


SWAP16 redundant with PKBT16 ?

Hello,
Isn't SWAP16 redundant when there is PKBT16 in the extension ? As far as I can tell, "PKBT16 a, b, b" is equivalent to "SWAP16 a,b".
Maybe SWAP16 should be made an assembly alias rather than have its own unary opcode ?

Yes. SWAP16 is redundant. I will make it an assembly alias to "PKBT16 rd, rs, rs". Thanks!

This issue has been resolved in the latest v0.9.7 release (0560ad6).


Native input box out of style from the rest of vscode

In the extensions viewlet we use a native input box.

It looks out of style compared to rest of vscode
It looks very bad on linux

#7946


STAR-987: make DD#setConfig public

STAR-987: add OBSOLETE FileType
STAR-987: add Descriptor.validFilename

rebased and applied review feedback

I started the PR build in Jenkins.

Test results show no failure.

the PR gate is blocking merge


Add More Server Cores for Minecraft

Hello! I would like to request the addition of more server cores for Minecraft. Currently, the options are limited to Paper, Spigot, and Purpur, which isn’t enough. For example, I specifically need BungeeCord for my setup. Expanding the selection of available cores would greatly enhance server performance and flexibility. Thank you for considering this request!

My personal need is Neoforged for modded java
https://neoforged.net/


quick fix for avoid_returning_null_for_void

This is a recommended lint but is missing a fix.
  void read(ElementImpl element) {
    if (_offset == -1) {
      return null; //<= no fix
    }
   ...
  }

Duplicate of https://github.com/dart-lang/sdk/issues/45920.


Stream Deck + dial support?

Is it possible to add support for the stream deck + dial buttons?
I'd like to bind the laser to one of my dials. If i can give any files/support whatever, feel free to reach out as i can understand you might not have access to a stream deck + right away

Elgato does not prove an sdk for the dials. So this is not possible
Also the game does not provide status information like laser level

Elgato does not prove an sdk for the dials. So this is not possible Also the game does not provide status information like laser level

Damn.  I tried assigning the mousewheel to a dial, but they don't support that (yet) either. Again, as in my other request, it's not about receiving laser levels from the game, just to operate it.

This plugin can't emulate a mousewheel
So if you can't switch to up/down keyboard buttons in the game settings then it's not possible


Multiple Conditions: IF(var1==1 && var2==2, 1, 2)

Is this supported?

I have the same problem. I think this is not supported because the "&&" operator is not defined (standing to what is written in the wik, at least). Maybe a custom functions will work in this case?

I will look to include support for "and" and "or". I assume this will cover the need?
Jace 0.9 addes improved support for writing custom funtions. The goal is to create a Jace 0.9.1 with a greatly extended list of functions. I also plan to improve the wiki information on the functions
Kind regards,
Pieter

I have added support for the 'and' and 'or' operations:
https://github.com/pieterderycke/Jace/commit/196dbec6d70fcdfd9abacfced068377716bae0ee
https://github.com/pieterderycke/Jace/commit/73c8a5e6df69b09eca4ce5aeeba49f8f68979871

Released as part of Jace v0.9.1


SCM: incoming/outgoing changes node should have primary actions

I was expecting to have actions to pull, push, sync on the node:

Thanks for the feedback. This is something that is currently under discussion. The main concern is that by default the actions are only visible on hover, yet if they are invoked by accident, they result in an operation that cannot be undone. Having said that, I would love to add them there.

Closing as the "Incoming/Outgoing" changes section has been removed.


Add Fractal version to each example

Once examples are transferred (see https://github.com/fractal-analytics-platform/fractal-demos/issues/9), add the fractal version they ran with to each. i.e. fractal-client==0.2.0, fractal-server=1.2.5, fractal-tasks-core==3.2.1

In each example folder, we should include whatever additional python script is needed (this is typically already the case), even if in the long-run there should be no additional python script at all. Moreover, most importantly, we should include a set of the three-packages versions used to successfully run an example. This could be a file like VERSIONS (in each example folder), with one or more lines like
fractal-client==0.2.0, fractal-server=1.2.5, fractal-tasks-core==3.2.1

Done for all the v1 examples


Missing support for GHC 8.2.1

I got an error related to the base library when using GHC 8.2.1 RC1. Bumped upper bound version of base to 4.11 fixed the issue.
CC'ing @jonaprieto.

I released scientific-<IP_ADDRESS> which support base-4.10.

Great! Thanks!


"remove dbg!" assist keeps unneeded parentheses

fn repro(a: bool, b: bool) {
    dbg!(!a) && b;
    dbg!(a) && b;
}

Remove dbg! assist removes the parentheses in the second case, but not the first one:
fn repro(a: bool, b: bool) {
    (!a) && b;
    a && b;
}

The code, determining whether to remove or retain the parentheses is here:
https://github.com/rust-analyzer/rust-analyzer/blob/343b14f7e06f3ec82a15b3648ba229e03e0b0583/crates/ide_assists/src/handlers/remove_dbg.rs#L148-L193
This particular issue most probably is caused by is_punct in
https://github.com/rust-analyzer/rust-analyzer/blob/343b14f7e06f3ec82a15b3648ba229e03e0b0583/crates/ide_assists/src/handlers/remove_dbg.rs#L185
We need to find a better heuristics (preferably) or add another symbol as an exception in the check.

Isn't it viable to do this properly? I would imagine you could see what expression was the contents of the macro call parsed as, and then what expression is the call itself contained in. Determining if the parentheses should be added is not possible from contents alone, dbg!(!a) && b does not need them, but dbg!(!a).field does.

It would be nice if we could just construct the intended AST and have a general function that inserts parentheses if necessary.


How to set up build envrionment?

A more complete explanation on how to setup the build environment would be nice. Can't get this to compile at the moment.

Same!

@MGlolenstine there's another project where we try to revive the mod: https://github.com/5zig-reborn/The-5zig-Mod
You could take a look as we have a working gradle build environment. Also, feel free to contribute!

Oh,  thank you so very much :)
I'll surely contribute, as there are a lot of things I wanted to add to 5zig :)


RsLedDriver for PhyVersoBSP

Describe your changes
This PR adds a module and necessary changes to PhyVersoBSP to steer the leds according to EvseManager state.
Issue ticket number and link
Issue ticket number and link
Checklist before requesting a review

[X] I have performed a self-review of my code
[X] I have made corresponding changes to the documentation
[X] I read the contribution documentation and made sure that my changes meet its requirements

How is this integrated on the MCU side and relating to which revision(s) of the phyVERSO hardware?
I am currently suspecting this implementation to be somewhat very specific to Qwellos use case and their homebrew firmware on the MCU side, which would not make it any useful for non-Qwello phyVERSO users/uses, that have the official firmware. Therefore it should not make its way into everest-core/main in my opinion.
Maybe we can have a talk on that topic next week when I'm back from vacation.

How is this integrated on the MCU side and relating to which revision(s) of the phyVERSO hardware?
I am currently suspecting this implementation to be somewhat very specific to Qwellos use case and their homebrew firmware on the MCU side, which would not make it any useful for non-Qwello phyVERSO users/uses, that have the official firmware. Therefore it should not make its way into everest-core/main in my opinion.
Maybe we can have a talk on that topic next week when I'm back from vacation.

So, generally phyVERSO hardware has GPIO pins and PWMs (or software PWM) which could be used to drive LEDs and set their brightness.
We have indeed integrated it on our side but I see this also useful to non-Qwello phyVERSO users. We can also contribute it there and make it configurable but this will take us more time.
Like every charging station has LEDs which are showing different colors depending on the state of evse, so this interface would be useful

HW Rev.1 has switched out the 4 user GPIOs in favor of 2 additional DC contactor outputs. I know you are only doing AC charging but other users of phyVERSO aren't. Of course you probably could re-use those outputs for driving LEDs (what are we talking about anyways, discrete RGB or WS21xx or something in that direction?) but then you will also have to implement signaling to the MCU that the normally DC contactor outputs will be reused for LED stuff.
If we are talking about LEDs with digital signaling then I would rather like to explore the idea of using some AM62 peripherals and using the unused outputs on the linux side of the phyVERSO.
Then it will be independent of if the charger is running Qwello FW or the official one.

Would you be fine with setting a compilation flag for this purposes? So, the PhyVerso code could have ifdefs that will use those DC contactor outputs as GPIOs, wdyt?


Issue with GSON on Ubuntu 16.04 with Jmeter 3.0

Hi.
Running this on the Digital Ocean Droplet. Installed JMeter 3.0, ES 2.4 and Kibana 4.4.1
Locally on a windows box, the script works fine. A basic script.
But on remote Ubuntu 16.04 gives me the following error.
2016/09/07 15:02:11 ERROR - jmeter.JMeter: Uncaught exception:  java.lang.NoClassDefFoundError: com/google/gson/GsonBuilder
at vadim.jmeter.listeners.ElasticsearchListener.handleSampleResults(ElasticsearchListener.java:107)
at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:269)
at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:241)
Caused by: java.lang.ClassNotFoundException: com.google.gson.GsonBuilder
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 3 more
When I stop the test and run again, it says ping unsuccessful.
Any ideas?

Error details suggest the required dependency (Gson library) is not in place. Can you please check that both the custom plugin and mentioned dependencies (Gson and Jersey 1.x libraries) are placed in corresponding JMeter directory.
Regards,
Vadim

Did that. But let me check again.
Get Outlook for Android
On Wed, Sep 7, 2016 at 9:04 PM +0530, "Vadim Klimov"<EMAIL_ADDRESS>wrote:
Error details suggest the required dependency (Gson library) is not in place. Can you please check that both the custom plugin and mentioned dependencies (Gson and Jersey 1.x libraries) are placed in corresponding JMeter directory.
Regards,
Vadim
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

worked. Not sure how I missed the GSON.

Hi krishnakanthpps,
I am trying to integrate Jmeter with ELK Stack.
So far, I am able to add Elastic Search Listner in jmeter . Also it is connected to Elastic Search server hosted locally. I am able to access ElasticSearch Server using port 9200.
While replaying the test script in jmeter, i am getting the same exception which you were getting.
ERROR – jmeter.JMeter: Uncaught exception: java.lang.NoClassDefFoundError: com/google/gson/GsonBuilder
at vadim.jmeter.listeners.ElasticsearchListener.handleSampleResults(ElasticsearchListener.java:107)
at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:269)
at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:241)
Could you please assist on this.

Place the gson jar file in the /lib/ext folder of the Jmeter.
Let me know if that helps.
Get Outlook for Androidhttps://aka.ms/ghei36
From: Tanwadh
Sent: Monday, 24 April, 3:59 p.m.
Subject: Re: [vadim-klimov/JMeter_ElasticsearchListener] Issue with GSON on Ubuntu 16.04 with Jmeter 3.0 (#2)
To: vadim-klimov/JMeter_ElasticsearchListener
Cc: Krishnakanth, State change
Hi krishnakanthpps,
I am trying to integrate Jmeter with ELK Stack.
So far, I am able to add Elastic Search Listner in jmeter . Also it is connected to Elastic Search server hosted locally. I am able to access ElasticSearch Server using port 9200.
While replaying the test script in jmeter, i am getting the same exception which you were getting.
ERROR – jmeter.JMeter: Uncaught exception: java.lang.NoClassDefFoundError: com/google/gson/GsonBuilder
at vadim.jmeter.listeners.ElasticsearchListener.handleSampleResults(ElasticsearchListener.java:107)
at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:269)
at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:241)
Could you please assist on this.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/vadim-klimov/JMeter_ElasticsearchListener/issues/2#issuecomment-296610403, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEZQWDLdI041hfgFSHlJcGrCPKg0nFJsks5rzHmAgaJpZM4J3Boz.

Hi krishnakanthpps,
Thanks for the above info.
Error in jmeter logs has been resolved with above suggestion.
Upon Running the script in jmeter and in parallel ES server is running , i cud see below message on the ElasticSearch.bat. Please find below screenshot for the same.

1.) Below message lines indicates that index has been created as expected.
[2017-04-24T17:08:26,726][INFO ][o.e.c.m.MetaDataCreateIndexService] [AA908517] [jmeter] creating index, cause [auto(bulk api)], templates [], shards [5]/[1], mappings []
[2017-04-24T17:08:27,326][INFO ][o.e.c.m.MetaDataMappingService] [AA908517] [jmeter/JQmhJ1uaTn2VbojPWi-mew] create_mapping [Demo]
2.) Below message line indicates some memory issue.
[2017-04-24T17:08:43,656][WARN ][o.e.c.r.a.DiskThresholdMonitor] [AA908517] high disk watermark [90%] exceeded on [RZwWlzgTSDO9iL4PYk2tBw][AA908517][C:\Users\twadhawa\Desktop\Projects\Learning\Jmeter
ELK\elasticsearch-5.3.1\elasticsearch-5.3.1\data\nodes\0] free: 229mb[0.1%], shards will be relocated away from this node
Could you please assist me on this and suggest further steps.

Thats a warning. You could ignore it. Else get a machine with more memory and CPU.

Hi krishnakanthpps,
Thanks for the above info.
While running kibana.bat from same local machine, command prompt window automatically closed instantly.
Is it because of less memory.
What are the next step to set up kibana for viewing the dashboard for jmeter test results.

Launch command line and start the kibana.bat from.the kibana folder. You might get to see the error message.
Based on that error message we can understand what's the issue.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Tanwadh<EMAIL_ADDRESS>Sent: Monday, April 24, 2017 9:53:29 PM
To: vadim-klimov/JMeter_ElasticsearchListener
Cc: Krishnakanth; State change
Subject: Re: [vadim-klimov/JMeter_ElasticsearchListener] Issue with GSON on Ubuntu 16.04 with Jmeter 3.0 (#2)
Hi krishnakanthpps,
Thanks for the above info.
While running kibana.bat from same local machine, command prompt window automatically closed instantly.
Is it because of less memory.
What are the next step to set up kibana for viewing the dashboard for jmeter test results.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/vadim-klimov/JMeter_ElasticsearchListener/issues/2#issuecomment-296728177, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEZQWNIziyWhd811nmMss5JKu6RjXaJGks5rzMyBgaJpZM4J3Boz.


Handling detection of NPM package binaries in scripts

I have a custom NPM script which uses nodemon, ts-node, and pino-pretty to watch and run a TypeScript module.
Knip does not detect the usage of any of these packages. What is the intended way to handle this in Knip?
This is my package.json, basically:
{
  "scripts": {
    "example:simple": "nodemon --exec 'ts-node --esm' ./example/simple.ts | pino-pretty --singleLine",
    "knip": "knip"
  },
  "devDependencies": {
    "knip": "^2.19.5",
    "nodemon": "^3.0.1",
    "ts-node": "^10.9.1"
  },
  "dependencies": {
    "pino-pretty": "^10.2.0"
  }
}

This is my knip.json:
{
  "entry": ["src/index.ts", "example/simple.ts"],
  "project": ["src/**/*.ts", "example/**/*.ts"]
}

Output:
$ pnpm knip

Unused dependencies (1)
pino-pretty  package.json
Unused devDependencies (2)
nodemon  package.json
ts-node  package.json
 ELIFECYCLE  Command failed with exit code 3.

:rocket: This issue has been resolved in v2.21.0. See Release 2.21.0 for release notes.

:rocket: This issue has been resolved in v2.21.0. See Release 2.21.0 for release notes.

Thanks @denizdogan, piping was not supported yet, same for nodemon's exec argument (so two fixes here).


View Public MP Info

As a user, I want to view public MP info.
Acceptance Criteria:
Given the user is in the public view
When the user selects Monitoring Plans
Then the global list of Facilities displays.

duplicate


Bug: Data & Query Views - Sorting directly on column applies to only Current Page and not to whole dataset

Clicking a column to sort it only applies to the data currently visually being shown on the page, but the expected behavior would most likely be to re-sort the entire dataset, which means rows from other pages may suddenly become visible.

Search rows in page is also causing the same issue but I think that was the intended behavior. It might actually be more valuable though to have it search in all pages.

It was indeed the intended behavior. I can look into the search rows through all pages and sorting on the entire dataset. Should be possible

This should be fixed in the latest release

Sorting seems to be working now but not the search. Search filter also needs to be applied again directly after running a new query.


[WIP] Break generator tests for more keys in example

As you can see, I added more keys and at the end they are sorted alphabetically. The strange behaviour that sometimes it just add key somewhere in the middle I cannot reproduce right know, but I will keep trying.

see #26

Thank you for the PR, @kafejo. I just had a look into your changes and made the following observations: Your test only proves that the genstrings command sorts by keys. But if I understood your scenario from #26 correctly, then this is your situation:

You already have a Localizable.strings file with (say) 3 keys: "A", "C", "E"
You add 2 new NSLocalizedString keys ("D" and "B") into your project and build
You observed:
The resulting Localizable.strings contains: "A", "B", "C", "D", "E"
You expected:
The resulting Localizable.strings contains: "A", "C", "E", "D", "B"

Your current test changes don't prove that your observations are actually the case though. They only prove that the newly added keys ("D" and "B") are sorted resulting in this (using the above example): "A", "C", "E", "B", "D". I hope you understand what I mean.
I think the right place to add such a test would be the currently empty CommandLineActorTests.swift file by testing the method actOnCode(path:, override:, verbose:, localizable:, defaultToKeys:, additive:) with a similar scenario like I explained above (so an existing .strings file which is being updated like in the StringsFileUpdaterTests).

Alright, I will look into that as soon as I have a little bit of spare time.

See my comment here – I've implemented the said test and couldn't reproduce the issue. You can go on from there – I hope we can find the issue and fix it soon! :)

I'm closing this since we have found out this was not actually the issue anyway. See #21 for more info.

Closing due to inactivity.


validate.py validation errors

Validation using python is yet to be a part of the regular validation procedure. The results and implementation needs further investigation before it becomes part of the standardized validation package .
Current error list generated by validate.py:
cp: ./test_capacitor_VAR_VOLT_ABC_indiv_dwell_NR.glm: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
sh: gridlabd.out: No such file or directory
FAIL /Users/alyona_slac/gridlabd/macosx/powerflow/autotest/test_capacitor_VAR_VOLT_ABC_indiv_dwell_NR/test_capacitor_VAR_VOLT_ABC_indiv_dwell_NR.glm exit 1
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
cat: gridlabd.out: No such file or directory
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
cat: gridlabd.out: No such file or directory

@aivanova5, is this still a problem?


Add field for files/directories to ignore when linting

@alvardsoler commented on Jul 19, 2018

what about this?
this isn't working for me with this configuration:
 "lint": { "filesToIgnore": ["dist/**/*"], "rules": ["polymer-1"], "ignoreWarnings": [ "databind-with-unknown-property", "undefined-elements" ] },
I tried to find other issue but this a little confusing...


Update FormRecognizer SDK to track2

Form recognizer track1 package "Microsoft.Azure.CognitiveServices.FormRecognizer"  is not supported for azure portal now. Because the api version is so old that now portal abandon it.
I'm not sure my change to process the result of formrecognizer's analysis  logic  whether is the same as track1. Because I can't run the project with track1 package.
Update file list:

./Source/TailwindTraders.ShippingManagement/Services/AnalysisService.cs
./Source/TailwindTraders.ShippingManagement/Services/Contracts/IFormReconigzedService.cs
./Source/TailwindTraders.ShippingManagement/Services/Contracts/IResponseService.cs
./Source/TailwindTraders.ShippingManagement/Services/ResponseService.cs
./Source/TailwindTraders.ShippingManagement/TailwindTraders.ShippingManagement.csproj

@jongio for notification.

@Tianyun-G - Is this ready for another review?

@jongio - Yes, is ready for another review.

@Tianyun-G
As per your comment:

I'm not sure my change to process the result of formrecognizer's analysis logic whether is the same as track1. Because I can't run the project with track1 package.

Is this solution runnable? Are you getting useful billing information extracted from the table?

@Tianyun-G thanks for all the changes! the code in the PR LGTM, but before I approve I will like to get an answer here:
As per your comment:

I'm not sure my change to process the result of formrecognizer's analysis logic whether is the same as track1. Because I can't run the project with track1 package.

Is this solution runnable? Are you getting useful billing information extracted from the table?

@maririos - When I ran the project, I had two problems.
First, when I deploy  resources by following the steps of readme, I have the same issue https://github.com/microsoft/TailwindTraders-ShippingManagement/issues/4.
Second, when I run the solution, get the exception:

I'm still investigating. Do you have any ideas?

I don't :( seems related to Azure functions/the project itself.
The FR part of the code looks good.
@jongio what is your recommendation here?

@Tianyun-G - Please continue to investigate the issue.  Thanks

You may just have to step through the code and see why obj not there.

@jongio - Thanks, I will continue to investigate the issue according to your comment.

@jongio - The NullReferenceException has been solved. At present, we pack up the image as Base64 and send it in program . The program ran to the end get incorrect result, some value not found. In case our sample image is incorrect, can you provide us a reliable image which has gone through this app. Thanks.
Here's the result:

@Tianyun-G could you share the sample image you are using? looking at the code, it is validating that the image contains the field Provider, that the Form Recognizer service correctly identified the field Provider, and that this code was able to parse the field Provider.
One of my guesses is that the service changed its output significantly between version 0.8 and 2.1 so maybe the parsing code here needs to be updated too. By looking at the response from the service (the whole content of the RecognizedFormCollection  object), we can figure it out.

@maririos - This is the image link I used.

Thank you! And do you know what the value is for _settings.FormRecognizedTrainningDataUrl https://github.com/microsoft/TailwindTraders-ShippingManagement/blob/ea398abe401392943980a531c32c5a72c3ad45cc/Source/TailwindTraders.ShippingManagement/Services/AnalysisService.cs#L40

@maririos - The _settings.FormRecognizedTrainningDataUrl value is Storage Container URL. Besides, we're trying to update the parsing code.

@maririos - I have updated some code, now the solution is runnable and can get information that we expected. One of my guesses is that the field Provider can't identified maybe the Form Recognizer service is instable or the image is not clear.

I have updated some code, now the solution is runnable and can get information that we expected.

So you are saying that now everything is working as expected?

The _settings.FormRecognizedTrainningDataUrl value is Storage Container URL. Besides, we're trying to update the parsing code.

The reason why I was asking for that is to be able to run this locally with the same files and therefore help with the parsing, but it looks like you did it :)

@maririos - Yes, everything is good.

@maririos - Does this PR need someone else to review it? If not, could you help us merge this PR?

@maririos - Does this PR need someone else to review it? If not, could you help us merge this PR?

I do not have permission in this repo to merge.
@jongio you know?

@isaacrlevin - Can you please review this?

@isaacrlevin - Could you help review this PR?

@acasquete @borjasanes please review


Enable NFS by default only for localhost mount.

Sample Exports file
for /mapr exports
 <exports_control>
#access_control -> order is specific to default
list the hosts before specifying a default for all
a.b.c.d,<IP_ADDRESS>(ro) d.e.f.g(ro) (rw)
enforces ro for a.b.c.d & <IP_ADDRESS> and everybody else is rw
special path to export clusters in mapr-clusters.conf. To disable exporting,
comment it out. to restrict access use the exports_control

/mapr (rw)

Done on maprdev61 branch


change css to work with scroll

closes #980

Im not noticing these on chrome on windows. Do you mean the top bar and alert on the bottom?
The table of contents are reamining in position for me at least on chrome

Nothing is fixed in Chrome in Linux. I can try updating my version, but its pretty current already.