Track usage of dragen workflows (Mem and CPU) usage

Track memory of dragen workflows for the purpose of understanding if we should be downgrading some of the hardware requirements.

Dragen Alignment (3.9.3)
Dragen alignment currently uses an FPGA medium instance (16 CPUs, 244 Gb Mem).
Scripts
get_usage_for_workflows.sh

Details
#!/usr/bin/env bash

set -euo pipefail

# Inputs
workflow_name_prefix="$1"
step_name="$2"
image_name="$3"
title_prefix="$4"
output_prefix="$5"

# Globals
MAX_ITEMS=0  # All workflows, all tasks

# Declare arrays
declare WORKFLOW_ARRAY
declare TASK_ARRAY
declare FILTERED_TASK_ARRAY

# Part 1
echo "Part 1 - get workflow list" 1>&2

# Get workflow list
readarray -t WORKFLOW_ARRAY <<< "$( \
  ica workflows runs list \
    --max-items="${MAX_ITEMS}" \
    --output-format json | \
  jq --raw-output \
    --arg workflow_name_prefix "${workflow_name_prefix}" \
    '
      .items |
      map(
        select(
          .name | startswith($workflow_name_prefix)
        )
      ) |
      map(.id) |
      .[]
    ' \
)"

# Part 2
echo "Part 2 - get tasks of interest from list of workflows" 1>&2
# Get tasks of interest from workflow id list
readarray -t TASK_ARRAY <<< "$( \
  for ica_workflow_run_id in "${WORKFLOW_ARRAY[@]}"; do
    ica-get-tasks-from-workflow-history \
      --ica-workflow-run-id "${ica_workflow_run_id}" | \
    jq --raw-output \
      --arg step_name "${step_name}" \
      '
        .[$step_name] |
        .task_id
      '
  done \
)"

# Part 3
echo "Part 3 - filter tasks to those of a specific image" 1>&2
# Filter tasks from lists
readarray -t FILTERED_TASK_ARRAY <<< "$( \
  for task_id in "${TASK_ARRAY[@]}"; do
    ica tasks runs get "${task_id}" \
      --output-format=json | \
    jq --raw-output \
      --arg image_name "${image_name}" \
      '
        if .execution.image.name == $image_name then
          .id
        else
          empty
        end
      '
  done
)"

# Convert to list of strings, truncate off last comma
filtered_task_str="$( \
  printf '%s,' "${FILTERED_TASK_ARRAY[@]}" | \
  sed 's/,$//g' \
)"

# Part 4
echo "Part 4 - ica plot tasks pod metrics" 1>&2
mkdir -p "$(dirname "${output_prefix}")"
cd "$(dirname "${output_prefix}")"
ica-plot-tasks-pod-metrics \
  --ica-tasks-list "${filtered_task_str}" \
  --output-prefix "$(basename "${output_prefix}")" \
  --title-prefix "${title_prefix}"

run_script.sh

Details
( \
  "./scripts/get_usage_for_workflows.sh" \
    "umccr__automated__wgs_alignment_qc" \
    "/run_dragen_step-job-0/run_dragen_alignment_step" \
    "699120554104.dkr.ecr.us-east-1.amazonaws.com/public/dragen:3.9.3" \
    "Dragen Alignment" \
    "plots/dragen_alignment/dragen_alignment" \
)

Plots
CPU

MEM

Conclusion
CPU is being over-allocated by a factor of 1X.
Expected Max CPU Usage for all alignment tasks is 16
Highest observed Max CPU Usage for all alignment tasks is 16.
Memory is being over-allocated by a factor of 6X.
Expected Max Mem Usage for all alignment tasks is 40 Gb.
Highest observed Max Mem Usage for all alignment tasks is 70 Gb.
FPGA medium is a partially appropriate hardware for this step.
FPGA small has 8 CPU and half the memory.
Assuming FPGA small takes twice as long, the iCredits are only half the price, so this would work out to be the same pricing anyway.  I don't think there is any reason to downgrade to FPGA small unless we think that this would mean more FPGA mediums would be available for other workflows.

Dragen Germline
Scripts
get_usage_for_workflows.sh

Details
#!/usr/bin/env bash

set -euo pipefail

# Inputs
workflow_name_prefix="$1"
step_name="$2"
image_name="$3"
title_prefix="$4"
output_prefix="$5"

# Globals
MAX_ITEMS=0  # All workflows, all tasks

# Declare arrays
declare WORKFLOW_ARRAY
declare TASK_ARRAY
declare FILTERED_TASK_ARRAY

# Part 1
echo "Part 1 - get workflow list" 1>&2

# Get workflow list
readarray -t WORKFLOW_ARRAY <<< "$( \
  ica workflows runs list \
    --max-items="${MAX_ITEMS}" \
    --output-format json | \
  jq --raw-output \
    --arg workflow_name_prefix "${workflow_name_prefix}" \
    '
      .items |
      map(
        select(
          .name | startswith($workflow_name_prefix)
        )
      ) |
      map(.id) |
      .[]
    ' \
)"

# Part 2
echo "Part 2 - get tasks of interest from list of workflows" 1>&2
# Get tasks of interest from workflow id list
readarray -t TASK_ARRAY <<< "$( \
  for ica_workflow_run_id in "${WORKFLOW_ARRAY[@]}"; do
    ica-get-tasks-from-workflow-history \
      --ica-workflow-run-id "${ica_workflow_run_id}" | \
    jq --raw-output \
      --arg step_name "${step_name}" \
      '
        .[$step_name] |
        .task_id
      '
  done \
)"

# Part 3
echo "Part 3 - filter tasks to those of a specific image" 1>&2
# Filter tasks from lists
readarray -t FILTERED_TASK_ARRAY <<< "$( \
  for task_id in "${TASK_ARRAY[@]}"; do
    ica tasks runs get "${task_id}" \
      --output-format=json | \
    jq --raw-output \
      --arg image_name "${image_name}" \
      '
        if .execution.image.name == $image_name then
          .id
        else
          empty
        end
      '
  done
)"

# Convert to list of strings, truncate off last comma
filtered_task_str="$( \
  printf '%s,' "${FILTERED_TASK_ARRAY[@]}" | \
  sed 's/,$//g' \
)"

# Part 4
echo "Part 4 - ica plot tasks pod metrics" 1>&2
mkdir -p "$(dirname "${output_prefix}")"
cd "$(dirname "${output_prefix}")"
ica-plot-tasks-pod-metrics \
  --ica-tasks-list "${filtered_task_str}" \
  --output-prefix "$(basename "${output_prefix}")" \
  --title-prefix "${title_prefix}"

run_script.sh

Details
( \
  "./scripts/get_usage_for_workflows.sh" \
    "umccr__automated__umccrise" \
    "/run_dragen_germline_pipeline_step-job-0/run_dragen_germline_step" \
    "699120554104.dkr.ecr.us-east-1.amazonaws.com/public/dragen:3.9.3" \
    "Dragen Germline" \
    "plots/dragen_germline/dragen_germline" \
)

Plots
CPU

MEM

Conclusion
CPU is being over-allocated by a factor of 1X.
Expected Max CPU Usage for all germline tasks is 16
Highest observed Max CPU Usage for all germline tasks is 16.
Memory is being over-allocated by a factor of 3X.
Expected Max Mem Usage for all alignment tasks is 80 Gb.
Highest observed Max Mem Usage for all alignment tasks is 90 Gb.
Like with the dragen alignment above, only reason to downgrade to FPGA small would be to allow more FPGA medium instances to somatic workflows.

Dragen Transcriptome
Scripts
get_usage_for_workflows.sh

Details
#!/usr/bin/env bash

set -euo pipefail

# Inputs
workflow_name_prefix="$1"
step_name="$2"
image_name="$3"
title_prefix="$4"
output_prefix="$5"

# Globals
MAX_ITEMS=0  # All workflows, all tasks

# Declare arrays
declare WORKFLOW_ARRAY
declare TASK_ARRAY
declare FILTERED_TASK_ARRAY

# Part 1
echo "Part 1 - get workflow list" 1>&2

# Get workflow list
readarray -t WORKFLOW_ARRAY <<< "$( \
  ica workflows runs list \
    --max-items="${MAX_ITEMS}" \
    --output-format json | \
  jq --raw-output \
    --arg workflow_name_prefix "${workflow_name_prefix}" \
    '
      .items |
      map(
        select(
          .name | startswith($workflow_name_prefix)
        )
      ) |
      map(.id) |
      .[]
    ' \
)"

# Part 2
echo "Part 2 - get tasks of interest from list of workflows" 1>&2
# Get tasks of interest from workflow id list
readarray -t TASK_ARRAY <<< "$( \
  for ica_workflow_run_id in "${WORKFLOW_ARRAY[@]}"; do
    ica-get-tasks-from-workflow-history \
      --ica-workflow-run-id "${ica_workflow_run_id}" | \
    jq --raw-output \
      --arg step_name "${step_name}" \
      '
        .[$step_name] |
        .task_id
      '
  done \
)"

# Part 3
echo "Part 3 - filter tasks to those of a specific image" 1>&2
# Filter tasks from lists
readarray -t FILTERED_TASK_ARRAY <<< "$( \
  for task_id in "${TASK_ARRAY[@]}"; do
    ica tasks runs get "${task_id}" \
      --output-format=json | \
    jq --raw-output \
      --arg image_name "${image_name}" \
      '
        if .execution.image.name == $image_name then
          .id
        else
          empty
        end
      '
  done
)"

# Convert to list of strings, truncate off last comma
filtered_task_str="$( \
  printf '%s,' "${FILTERED_TASK_ARRAY[@]}" | \
  sed 's/,$//g' \
)"

# Part 4
echo "Part 4 - ica plot tasks pod metrics" 1>&2
mkdir -p "$(dirname "${output_prefix}")"
cd "$(dirname "${output_prefix}")"
ica-plot-tasks-pod-metrics \
  --ica-tasks-list "${filtered_task_str}" \
  --output-prefix "$(basename "${output_prefix}")" \
  --title-prefix "${title_prefix}"

run_script.sh

Details
( \
  "./scripts/get_usage_for_workflows.sh" \
    "umccr__automated__wts_tumor_only" \
    "/run_dragen_transcriptome_step" \
    "699120554104.dkr.ecr.us-east-1.amazonaws.com/public/dragen:3.9.3" \
    "Dragen Transcriptome" \
    "plots/dragen_transcriptome/dragen_transcriptome" \
)

Plots
CPU

MEM

Conclusion
CPU is being over-allocated by a factor of 1X.
Expected Max CPU Usage for all germline tasks is 16
Highest observed Max CPU Usage for all germline tasks is 16.
Memory is being over-allocated by a factor of 3X.
Expected Max Mem Usage for all alignment tasks is 85 Gb.
Highest observed Max Mem Usage for all alignment tasks is 95 Gb.
Like with the dragen alignment and dragen germline above, only reason to downgrade to FPGA small would be to allow more FPGA medium instances to somatic workflows.

Dragen Germline
Scripts
get_usage_for_workflows.sh

Details
#!/usr/bin/env bash

set -euo pipefail

# Inputs
workflow_name_prefix="$1"
step_name="$2"
image_name="$3"
title_prefix="$4"
output_prefix="$5"

# Globals
MAX_ITEMS=0  # All workflows, all tasks

# Declare arrays
declare WORKFLOW_ARRAY
declare TASK_ARRAY
declare FILTERED_TASK_ARRAY

# Part 1
echo "Part 1 - get workflow list" 1>&2

# Get workflow list
readarray -t WORKFLOW_ARRAY <<< "$( \
  ica workflows runs list \
    --max-items="${MAX_ITEMS}" \
    --output-format json | \
  jq --raw-output \
    --arg workflow_name_prefix "${workflow_name_prefix}" \
    '
      .items |
      map(
        select(
          .name | startswith($workflow_name_prefix)
        )
      ) |
      map(.id) |
      .[]
    ' \
)"

# Part 2
echo "Part 2 - get tasks of interest from list of workflows" 1>&2
# Get tasks of interest from workflow id list
readarray -t TASK_ARRAY <<< "$( \
  for ica_workflow_run_id in "${WORKFLOW_ARRAY[@]}"; do
    ica-get-tasks-from-workflow-history \
      --ica-workflow-run-id "${ica_workflow_run_id}" | \
    jq --raw-output \
      --arg step_name "${step_name}" \
      '
        .[$step_name] |
        .task_id
      '
  done \
)"

# Part 3
echo "Part 3 - filter tasks to those of a specific image" 1>&2
# Filter tasks from lists
readarray -t FILTERED_TASK_ARRAY <<< "$( \
  for task_id in "${TASK_ARRAY[@]}"; do
    ica tasks runs get "${task_id}" \
      --output-format=json | \
    jq --raw-output \
      --arg image_name "${image_name}" \
      '
        if .execution.image.name == $image_name then
          .id
        else
          empty
        end
      '
  done
)"

# Convert to list of strings, truncate off last comma
filtered_task_str="$( \
  printf '%s,' "${FILTERED_TASK_ARRAY[@]}" | \
  sed 's/,$//g' \
)"

# Part 4
echo "Part 4 - ica plot tasks pod metrics" 1>&2
mkdir -p "$(dirname "${output_prefix}")"
cd "$(dirname "${output_prefix}")"
ica-plot-tasks-pod-metrics \
  --ica-tasks-list "${filtered_task_str}" \
  --output-prefix "$(basename "${output_prefix}")" \
  --title-prefix "${title_prefix}"

run_script.sh

Details
( \
  "./scripts/get_usage_for_workflows.sh" \
    "umccr__automated__wgs_tumor_normal" \
    "/run_dragen_somatic_step" \
    "699120554104.dkr.ecr.us-east-1.amazonaws.com/public/dragen:3.9.3" \
    "Dragen Somatic" \
    "plots/dragen_somatic/dragen_somatic" \
)

Plots
CPU

MEM

Conclusion
CPU is being over-allocated by a factor of 1X.
Expected Max CPU Usage for all germline tasks is 16
Highest observed Max CPU Usage for all germline tasks is 16.
Memory is being over-allocated by a factor of 1X.
Expected Max Mem Usage for all alignment tasks is 200 Gb.
Highest observed Max Mem Usage for all alignment tasks is 234 Gb.
FPGA Medium is an appropriate hardware choice for dragen-somatic workflows.

CTTSO Analysis Workflow Step
Scripts
get_usage_for_workflows.sh

Details
#!/usr/bin/env bash

set -euo pipefail

# Inputs
workflow_name_prefix="$1"
step_name="$2"
image_name="$3"
title_prefix="$4"
output_prefix="$5"

# Globals
MAX_ITEMS=0  # All workflows, all tasks

# Declare arrays
declare WORKFLOW_ARRAY
declare TASK_ARRAY
declare FILTERED_TASK_ARRAY

# Part 1
echo "Part 1 - get workflow list" 1>&2

# Get workflow list
readarray -t WORKFLOW_ARRAY <<< "$( \
  ica workflows runs list \
    --max-items="${MAX_ITEMS}" \
    --output-format json | \
  jq --raw-output \
    --arg workflow_name_prefix "${workflow_name_prefix}" \
    '
      .items |
      map(
        select(
          .name | startswith($workflow_name_prefix)
        )
      ) |
      map(.id) |
      .[]
    ' \
)"

# Part 2
echo "Part 2 - get tasks of interest from list of workflows" 1>&2
# Get tasks of interest from workflow id list
readarray -t TASK_ARRAY <<< "$( \
  for ica_workflow_run_id in "${WORKFLOW_ARRAY[@]}"; do
    ica-get-tasks-from-workflow-history \
      --ica-workflow-run-id "${ica_workflow_run_id}" | \
    jq --raw-output \
      --arg step_name "${step_name}" \
      '
        .[$step_name] |
        .task_id
      '
  done \
)"

# Part 3
echo "Part 3 - filter tasks to those of a specific image" 1>&2
# Filter tasks from lists
readarray -t FILTERED_TASK_ARRAY <<< "$( \
  for task_id in "${TASK_ARRAY[@]}"; do
    ica tasks runs get "${task_id}" \
      --output-format=json | \
    jq --raw-output \
      --arg image_name "${image_name}" \
      '
        if .execution.image.name == $image_name then
          .id
        else
          empty
        end
      '
  done
)"

# Convert to list of strings, truncate off last comma
filtered_task_str="$( \
  printf '%s,' "${FILTERED_TASK_ARRAY[@]}" | \
  sed 's/,$//g' \
)"

# Part 4
echo "Part 4 - ica plot tasks pod metrics" 1>&2
mkdir -p "$(dirname "${output_prefix}")"
cd "$(dirname "${output_prefix}")"
ica-plot-tasks-pod-metrics \
  --ica-tasks-list "${filtered_task_str}" \
  --output-prefix "$(basename "${output_prefix}")" \
  --title-prefix "${title_prefix}"

run_script.sh

Details
( \
  "./scripts/get_usage_for_workflows.sh" \
    "umccr__automated__tso_ctdna_tumor_only" \
    "/run_tso_ctdna_workflow_step-job-0/run_tso500_ctdna_analysis_workflow_step" \
    "239164580033.dkr.ecr.us-east-1.amazonaws.com/acadia-500-liquid-workflow-aws:ruo-<IP_ADDRESS>" \
    "ctTSO Analysis Workflow" \
    "plots/ctdna_analysis/ctdna_analysis" \
)

Plots
CPU

MEM

Conclusion
CPU is being over-allocated by a factor of 1X.
Expected Max CPU Usage for all analysis tasks is 16
Highest observed Max CPU Usage for all analysis tasks is 16.
Memory is being over-allocated by a factor of 4X.
Expected Max Mem Usage for all analysis tasks is 60 Gb.
Highest observed Max Mem Usage for all analysis tasks is 230 Gb.
Since we've seen some analysis exceed the usage for this workflow step, over allocating memory with an FPGA Medium instance is an appropriate choice.

Closing issue, dragen tools have been allocated memory appropriately.


Passing values with webhooks?

** Please describe which feature you have a question about? **
Amplify Incoming Webhooks
** Provide additional details**
Is it possible to add data to the JSON payload that gets sent when triggering the webhook and have it available in the build?
My use case is to build a tool to trigger builds with a bit of information that the build needs. Is this possible? How would I access the post body in the build?

@swaminator Any movement on this? We've built quite a hefty build system on top of Amplify and passing a payload through would make things a lot easier.

Hello - sorry for the delay here. I'm curious to learn a bit more about the use case? What type of data would you want to pass along? What would you like to accomplish?

One scenario is that build was done in a different environment and this was saved in an artifact repo.
On calling Webhook, amplify build step doesn't need to be triggered again from git branch, instead download the artifact.

@mauerbac
I have  a scenario where I want to avoid having to build my  web  application for every environment.
Instead I want to build once and change configuration on deploy time.
I want to do this for multiple reasons:

Decreasing the mean time of deployments allowing to switch pre-build artifacts without redundant compile times.
It allows us to  deploy the artifact build to run our acceptance test against it. Since the build doesn't change as its moved up the environments it gives us more confidence that what we tested remains in a good state (ignoring configuration).
This would allow developers to integrate code continuously more frequently and confidently.

I have tried a different approach to achieve this ideal workflow, but it has one problems which being able to send something like build id to the job would solve my problem.
Current scenario:
I've disabled auto build setting in the general setting of the AWS amplify app, and just call a job from our CI server using the aws-cli. (ideally this would just calling a webhook). The build artifact id is the git commit hash of our main branch.
version: 1
frontend:
  phases:
    preBuild:
      commands:
         - GIT_SHA=$(git rev-parse HEAD)
         -  aws s3 sync s3://bucket-name/$GIT_SHA ./build
    build:
      commands: []

  artifacts:
    baseDirectory: build
    files:
      - '**/*'

The problem we now face is this.
Say there are 3 commits back to back. Our ci server has some concurrency which will only run one at once. In this case will run the first and when it finishes will run the last one.
The first commit will trigger a build of the artifact, uploading it in our artifact store and triggering a build in the AWS amplify job.
Once it gets to AWS amplify build step its going to look for the most recent commit which is now a build that' hasn't been build and fail.
Having a build id in the webhook would solve this problem as I can tell AWS amplify exactly what build to deploy instead of relying on checking latest commit.


Adding changes related to voting

I added a new model called Poll to help with implementing the fucntionality of voting on chores and made small changes to the existing Vote model , i will also be pushing the front end related to voting later today, i need a user to be logged in for me to check if he already voted on a specific chore , also i need to create a new Vote specefic to the choice of the user logged in everytime a user votes with yes or no , other than that for this to function we need to create a new poll everytime we create a new chore, no tests yet, i need the signup and login functionalitys to be working then i will add the tests.
Signed-off-by: faezzangariya<EMAIL_ADDRESS>

I don't understand the utility this provides

i just added that model for better presentation of the voting on the front end , cause we need to present a single form of voting for each indivisual chore , for each chore we would have one poll for voting where every user votes, but for every chore there is multiple votes ,  i couldn't find a way to collect votes from multiple users on one chore without adding the new model , every time we create a new chore we need to also create a new poll witch manages and collects votes from all users per chore.
(the poll model is more for the visual side of things and the collection of user vote inputs)

I don't understand the utility this provides

i just added that model for better presentation of the voting on the front end , cause we need to present a single form of voting for each indivisual chore , for each chore we would have one poll for voting where every user votes, but for every chore there is multiple votes , i couldn't find a way to collect votes from multiple users on one chore without adding the new model , every time we create a new chore we need to also create a new poll witch manages and collects votes from all users per chore. (the poll model is more for the visual side of things and the collection of user vote inputs)

Why can't we attach to each chore a "Yes" & "No" button, and when the user clicks on it , it creates a new Vote instance?
If there's already a vote in the db then it won't show the buttons.
When separate users use the buttons, it creates a Vote instance with their own unique user_id, so multiple users can vote
What visual utility does this model provide that we can't supply with the Vote model?

I don't understand the utility this provides

i just added that model for better presentation of the voting on the front end , cause we need to present a single form of voting for each indivisual chore , for each chore we would have one poll for voting where every user votes, but for every chore there is multiple votes , i couldn't find a way to collect votes from multiple users on one chore without adding the new model , every time we create a new chore we need to also create a new poll witch manages and collects votes from all users per chore. (the poll model is more for the visual side of things and the collection of user vote inputs)

this way we can also add a feauture of adding custom polls where the title and the choices are customizable

I don't understand the utility this provides

i just added that model for better presentation of the voting on the front end , cause we need to present a single form of voting for each indivisual chore , for each chore we would have one poll for voting where every user votes, but for every chore there is multiple votes , i couldn't find a way to collect votes from multiple users on one chore without adding the new model , every time we create a new chore we need to also create a new poll witch manages and collects votes from all users per chore. (the poll model is more for the visual side of things and the collection of user vote inputs)

Why can't we attach to each chore a "Yes" & "No" button, and when the user clicks on it , it creates a new Vote instance? If there's already a vote in the db then it won't show the buttons. When separate users use the buttons, it creates a Vote instance with their own unique user_id, so multiple users can vote
What visual utility does this model provide that we can't supply with the Vote model?

we could do it like you said , but i am not the best with the frontend side of things , i could setup the background your way but Elias would have to continue with the frontend

I don't understand the utility this provides

i just added that model for better presentation of the voting on the front end , cause we need to present a single form of voting for each indivisual chore , for each chore we would have one poll for voting where every user votes, but for every chore there is multiple votes , i couldn't find a way to collect votes from multiple users on one chore without adding the new model , every time we create a new chore we need to also create a new poll witch manages and collects votes from all users per chore. (the poll model is more for the visual side of things and the collection of user vote inputs)

Why can't we attach to each chore a "Yes" & "No" button, and when the user clicks on it , it creates a new Vote instance? If there's already a vote in the db then it won't show the buttons. When separate users use the buttons, it creates a Vote instance with their own unique user_id, so multiple users can vote
What visual utility does this model provide that we can't supply with the Vote model?

we could do it like you said , but i am not the best with the frontend side of things , i could setup the background your way but Elias would have to continue with the frontend

Sounds good to me!

Closing Pr for now , We decided to go a diffrent route with the voting implementation.


Remove typechain cleanup 17

This PR represents the first time I'm trying to actually load the app in a browser since this whole project started.

@decentdao/engineering i could use some help with this code...

first thing I'm struggling with is getting the test to pass
second is trying to figure out why i'm getting a few ContractFunctionExecutionErrors in the console, for specific lines in the codebase but idk it doesn't make sense to me.


it's better that autocomplete without hotkey, and autocomplete include all project symbol.

it's better that autocomplete without hotkey, autocomplete include all project symbol.

No autocomplete in the new version of Nightcode, but I plan on adding it back later.


Bad indentation

Rustfmt yields
use leptos::*;

fn test2(cx: Scope) -> impl IntoView {
    let x = vec![1]
        .into_iter()
        .map(|i| {
            view! { cx,

                    {move || { i }}

            }
        })
        .collect_view(cx);
    let z = view! { cx,

            {move || { 0 }}

    };
    view! { cx,
{x}
 }
}

Running leptosfmt 0.1.11 afterwards yields
use leptos::*;

fn test2(cx: Scope) -> impl IntoView {
    let x = vec![1]
        .into_iter()
        .map(|i| {
            view! { cx,

                {move || { i }}

        }
        })
        .collect_view(cx);
    let z = view! { cx,

                {move || { 0 }}

        };
    view! { cx,
{x}
 }
}

We can see that the first view! leptosfmt actively unindents it while in the second view! it indents it even further

This is the same issue as #54

This is the same issue as #54

I think it's slightly different, and that this example is a more-minimal example. The example provided in #54 works just fine on my IDE. I have both rustfmt and leptosfmt on default settings (4 spaces). In the example above, it only breaks when view! is nested in some closure (such as map).

See https://github.com/bram209/leptosfmt/issues/54#issuecomment-1656851413

@awesomelemonade  can you try cargo install --git https://github.com/bram209/leptosfmt.git --branch fix-view-indentation-issues and let me know if that fixes your problem?

looks good to me, thanks!


ENDIF inside REPEAT is applied to wrong IF level

Reported by andrew wittenberg on 8 Sep 2009 15:01 UTC
Reported by Hella Riede on the User's Group mailing list, 9/8/09.
The third block of the following script issues an error:
**ERROR: invalid command: ENDIF can only be used in an IF clause
Looks like a parsing bug -- it seems the ENDIF inside the REPEAT is being applied to the outermost IF.  Note that the error goes away if we change the outer 0 to a 1.
\\can mode verify

say "test1"
if 0 then
  repeat/RANGE=1:2 (if 0 then; say "hello1"; endif)
endif

say "test2"
if 0 then
  repeat/RANGE=1:2 (\\
    if 0 then;\\
      say "hello2"; endif)
endif

say "test3"
if 0 then
  repeat/RANGE=1:2 (\\
    if 0 then;\\
      say "hello3";\\
    endif)
endif

set mode/last verify

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1681

Comment by andrew.wittenberg on 8 Sep 2009 15:05 UTC
Bug confirmed in Ferret v6.203, dated 6/26/09.  See also #1566.

Comment by ansley.b.manke on 9 Sep 2009 21:02 UTC
This is indeed a parsing error, fixed in get_command.F, and tested with the REPEAT falling inside simple IF blocks, as well as IF-THEN-ELSE and IF-THEN-ELIF_THEN_ENDIF blocks.

Comment by ansley.b.manke on 7 Oct 2009 22:04 UTC
This is better fixed in process_if.F; detect when the IF is part of a multi-line IF block even if that multi-line block is written as a set of semicolon-separated commands on a single command line.
The previous fix to this bug caused #1706. Revert to the previous code in get_command.F and parse_command.F, instead making this simpler fix in process_if.F

Comment by andrew.wittenberg on 20 Oct 2009 22:59 UTC
Similar problems still show up in v6.303 (dated 10/9/2009).  E.g. the following script
IF 1 THEN
   rep/i=1:3 (\\
      IF 1 THEN;\\
      ENDIF;\\
      )
ELSE
   rep/i=1:3 (\\
      IF 1 THEN;\\
      ENDIF;\\
      )
ENDIF

gives
 **ERROR: invalid command: ENDIF can only be used in an IF clause

Comment by ansley.b.manke on 28 Oct 2009 18:19 UTC
Fixed with a more robust fix in process_if.F.  More thorough testing in the Ferret benchmarks also added.

Comment by ansley.b.manke on 5 Nov 2009 00:11 UTC
Also added testing of the syntax in the LAS scripts which was going awry with the first fix to this bug.  The construction that had trouble was
IF (condition) THEN
  IF (some long-winded condition) THEN \\
    command
ENDIF

Which failed when the (condition) in the first command was false. The inner IF was getting treated as a block if when it's really just a one-line IF-THEN-ENDIF.

Comment by steven.c.hankin on 18 Dec 2014 17:39 UTC
modified the fix in the process of refactoring GET_FER_COMMAND, PROCESS_IF and PARSE_COMMAND


Create PR template for merging release branches into pre-release branches

Description:
Create a pull request when merging a release branch that adds or fixes something into a version pre-release release branch.
Example:
This PR template would be when merging a branch named release/my-prerelease-fix into release/v1.2.3

Acceptance Criteria:

[ ] PR template created
[ ] Make sure to add a todo list for things to do after the merge is complete

These will be things such as tagging

This has been added to issue #13 and has been changed.
Issue closed.


Add support for route53 IPv6

Major changes:

Add Route53 (v6) in supported service list
It shared the same code block as Route53, uses $this->_useIPv6 to determine maintaining A or AAAA records.

@kcyeu hi, thanks, looks good to me. Can you add a "Last Tested" line for the new service as well?

@fichtner Please check the new commit.

Looks good, thank you! Not sure if this will make it into 17.7.8, depends on the other item I want to fix (#382)


CNV-43245: Use template runstrategy

📝 Description
We want in the drawer to make the VM starting by default.
Instead of using Always as a starting default, lets use RerunOnFailures. If the template already have something else defined like Always or Once do not modify that. Keep that.

/lgtm


Remove inline javascript to comply with some CSP

Tested with https://download.kiwix.org/zim/videos/khan-academy-videos_ar_khws-l-dd_2021-12.zim
Every page has the following webp-polyfill related inline code :
<script>$(document).ready(function() { trigger_webp_polyfill(); });</script>

Wrong repo ; Should be kolibri2zim. FYI there is a Scrapers list


[Suggestion]: Release Update

General Info

[ ] I would like to propose new content
[ ] I would like to propose changes
[X] I would like to propose another thing

Suggestion Description
Please release update for 1.21.1
Thanks.

An update with what? there hasn't been any unreleased changes

An update with what? there hasn't been any unreleased changes

100 mb fix is still not released.

0.9.6 contains the fix and is available on curseforge


Pass Field object to the Randomizer

In Randomizer interface
Change method from:
public String getRandomValue()
to
public String getRandomValue(Field field)
This will make every randomizer more versatile.
For example a StringRandomizer could generate a random value with a prefix equal to the name of the field it is filling. This will help during debugging in checking the expected values.

Thank you for opening this feature request. What you are looking for is the ContextAwareRandomizer, which is an extension of Randomizer to make it aware of the current context (which contains the current field/object). Here is an example: https://github.com/j-easy/easy-random/blob/fc58f6129b385b7541a12235511cf5c0a6bc4eec/easy-random-core/src/test/java/org/jeasy/random/context/LastNameRandomizer.java
I am closing this issue for now as I believe the ContextAwareRandomizer is the way to go (no need to change the Randomizer#getRandomValue method), but feel free to add a comment if you need  more support on this.


pull request for e2e test at 12/09/2016 19:15:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[WFLY-17382] Upgrade legacy Undertow to 2.2.22.Final

Signed-off-by: Flavia Rainone<EMAIL_ADDRESS>Jira: https://issues.redhat.com/browse/WFLY-17382
    Release Notes - Undertow - Version 2.2.21.Final

        Sub-task

[UNDERTOW-1818] -         AbstractServletInputStreamTestCase.runTestParallel fails with bytes out of order

        Bug

[UNDERTOW-1988] -         undertow-servlet-jakartaee9 has a Java EE 8 dependency

[UNDERTOW-2031] -         protocol error with HTTP/2 and Expect: 100-continue

[UNDERTOW-2048] -         CVE-2022-2764 UndertowInputStream.close() blocks waiting to read= -1

[UNDERTOW-2069] -         Filter.destroy can deadlock with running filter on shutdown

[UNDERTOW-2081] -         RejectedExecutionException occurs during shutdown if an open websocket session exists

[UNDERTOW-2097] -         DMI_RANDOM_USED_ONLY_ONCE error reported by spotbugs

[UNDERTOW-2111] -         rewrite() handler doesn't guard against missing leading slash

[UNDERTOW-2123] -         AsyncContextImpl.dispatch  uses empty path sometimes

[UNDERTOW-2141] -         NPE in ServletContextImpl after session timed out

[UNDERTOW-2162] -         Query parameters should not be canonicalized in servlet path when get request dispatcher

[UNDERTOW-2163] -         Predicate Language cannot set attribute to empty string

[UNDERTOW-2166] -         When both IDLE_TIMEOUT and READ_TIMEOUT are configured the minimum of both should be used

        Task

[UNDERTOW-2167] -         2.2.x branch will provide Java EE API version only

        Enhancement

[UNDERTOW-1971] -         Change in handling of concurrent session creation with id reuse

    Release Notes - Undertow - Version 2.2.22.Final

        Sub-task

[UNDERTOW-2054] -         Buffer leak errors involving SslConduit on CI

        Feature Request

[UNDERTOW-2198] -         Add Option to force the SNIHostName

        Bug

[UNDERTOW-2123] -         AsyncContextImpl.dispatch  uses empty path sometimes

[UNDERTOW-2184] -         SessionListenerBridge doesn't properly implement sessionIdChanged

[UNDERTOW-2186] -         Application sub directories named WEB-INF or META-INF are no longer served

[UNDERTOW-2188] -         Adjust corner case of covered methods if no methods are  present

[UNDERTOW-2189] -         IOException thrown when trying to close already closed stream

[UNDERTOW-2190] -         DefaultServlet serves CSS and JS blobs even if directory listing is disabled

[UNDERTOW-2202] -         Cannot release the file handle in docker

[UNDERTOW-2206] -         IAE trying to decode a requestPath

        Enhancement

[UNDERTOW-2204] -         Add CODE_OF_CONDUCT.md

relates to https://github.com/wildfly/wildfly-core/pull/5313

Hi @fl4via
If https://github.com/wildfly/wildfly/pull/16349 is ok with you I'd like us to merge that and then we don't need this. The legacy version dependencies are just compile dependencies for the legacy javax code that we're removing; Kabir's PR removes the maven property along with the dependencyManagement use of it.

@bstansberry sure, it is okay with me! @kabir thanks for taking care of WFLY-17270!

Closing, now that https://github.com/wildfly/wildfly/pull/16349 was merged.


Powershell Command to register the resource provider is not correct for ARM mode...

Correct command is Register-AzureRmProviderFeature -Feature "hanabackup" -ProviderNamespace Microsoft.recoveryservices
For the command listed in the document we get the below error
Register-AzProviderFeature -FeatureName "HanaBackup" -ProviderNamespace Microsoft.RecoveryServices
Register-AzProviderFeature : The term 'Register-AzProviderFeature' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a
path was included, verify that the path is correct and try again.
At line:1 char:1

Register-AzProviderFeature -FeatureName "HanaBackup" –ProviderNamespa ...

  + CategoryInfo          : ObjectNotFound: (Register-AzProviderFeature:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc202f44-d2f7-3dee-5810-ae8d14805b6f
Version Independent ID: df1d2207-594a-4341-5461-2470f7b56379
Content: Back up an SAP HANA database to Azure with Azure Backup - Azure Backup
Content Source: articles/backup/backup-azure-sap-hana-database.md
Service: backup
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

reassign:pvrk

#reassign:pvrk

@prjhunjh Thanks for the comment. This issue has been assigned to the content owner to review and update as appropriate.

If you are using 'AzureRM' module, then you have to replace 'Az' in this command with 'AzureRm'. In the documentation, the command is explicitly given for 'Az' module since that is the recommended module by Azure PS.

@prjhunjh : As I said above, the documentation is given explicitly for 'Az' module. It is known that 'Az' commands can be run by replacing 'Az' with 'AzureRm'. Also, this requirement is removed, once the solution is GA in all regions. Hence, I hope I can close this issue.

Updated the above doc to provide the AzureRm command as well.

#please-close


zos transfer has some minor output issues

There is an extra dot after sent!. and it says to send transactions from but we are sending only one transaction. Are we?

This should be fixed in v2.4.0-rc.3 Which version are you using?

I am using latest code from master branch which returns 2.4.0-rc.1. npm says latest is rc.2. How do I install rc.3? From a branch?

I'm sorry, I meant rc.2 :joy: Master is not up to date with npm though, branch release/2.4 is.


Continuous constraints

I start coding something for constraints.
I want to deal separately with constraints which are not just boolean: constraints of the form g(x) >=0.
Not sure if I should
(a) modify cheap constraints so that _constraints_checkers is a list of mapping to Union(bool, float).
(b) or add a second list e.g. _continuous_constraints_checkers which is a list of mapping to float.
(c) like b, but in addition we add a boolean constraint for each continuous constraint, so that algorithms only dealing with boolean constraints don't have to worry about continuous constraints.
I would go for (c), unless someone tells me this is not the right pythonic way of dealing with that :-)

Is that in a hurry? I have plans to update the constraint management so I would rather not add more features just now.
However I'd need to understand the needs.
What is the aim here? you want the float as a source of information? How would you use it? because the way it is done, internal_ask is not supposed to access this information, it's only dealt with at the base optimizer level.
And as a choice I would tend to go for (a) which requires minimal changes, although that can lead to weird silent errors if people were sending floats instead of booleans.

Yes I want the float as a source of information.
I would use it for implementing many other methods for constraint management.
The simplest tool is penalization, with multiplicative factor growing from zero to +infinity as num_ask grows from 0 to budget.
Ok for (a) then.

in progress https://github.com/facebookresearch/nevergrad/pull/807/files

Done.


Node.js Foundation Community Committee Meeting 2018-09-20

Time
UTC Thu 20-Sep-2018 16:00 (04:00 PM):

Timezone
Date/Time

US / Pacific
Thu 20-Sep-2018 09:00 (09:00 AM)

US / Mountain
Thu 20-Sep-2018 10:00 (10:00 AM)

US / Central
Thu 20-Sep-2018 11:00 (11:00 AM)

US / Eastern
Thu 20-Sep-2018 12:00 (12:00 PM)

London
Thu 20-Sep-2018 17:00 (05:00 PM)

Amsterdam
Thu 20-Sep-2018 18:00 (06:00 PM)

Moscow
Thu 20-Sep-2018 19:00 (07:00 PM)

Chennai
Thu 20-Sep-2018 21:30 (09:30 PM)

Hangzhou
Fri 21-Sep-2018 00:00 (12:00 AM)

Tokyo
Fri 21-Sep-2018 01:00 (01:00 AM)

Sydney
Fri 21-Sep-2018 02:00 (02:00 AM)

Or in your local time:

http://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Community Committee+Meeting+2018-09-20&iso=20180920T16
or http://www.wolframalpha.com/input/?i=04PM+UTC%2C+Sep+20%2C+2018+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1GiFsvwJTNy6yYWIRuwWleVCt1Z2mTY0NJUWerqQl_bw/edit

Agenda
Extracted from cc-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/admin

JS Interactive & Node Community Corner - Questions? #211

nodejs/community-committee

Individual Membership Subgroup Meeting - September 4th, 2018 #366
Moderation Team Recertification #361
First pass at PARTNER_COMMUNITIES.md #352

Invited

CommComm Members: @nodejs/community-committee

Observers/Guests
Feel free to attend meeting as a guest. A zoom link will be shared here few minutes before meeting.
Notes
The agenda comes from issues labelled with cc-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: Will be added a few minutes before meeting starts
For those who just want to watch:
youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

Note to Observers: We will be starting the public session and YouTube stream about 15 minutes after the start of the meeting – see you in 45 minutes!

Join link: https://zoom.us/s/527273462

Work has always clashes with meetings. 😩 I missed another one. 😫

We missed you @codeekage! Next time 🙂


[UI Cleanup] Search box has 'Search AppMap' place holder text, no icon, and a less prominent border

The search box should integrate more cleanly into the visual language of the IDE.
Change the 'Search' placeholder to 'Search AppMap' in order to indicate the scope of the search.
The magnifying glass icon is not needed. In a mobile app or a web app an icon for search can be a good visual addition but in an IDE experience, it is extraneous and should be removed.
The search box itself should not be exceedingly taller than the text expected to be input, and should feel integrated into the IDE experience. Shrink the size of the text box, remove the color, and remove the corner radius.

The search box should be gray not bright white...


feat: generate postmessage client

fixes #8

Codecov Report

Merging #7 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master      #7   +/-   ##
======================================
  Coverage    1.58%   1.58%
======================================
  Files          26      26
  Lines         632     630    -2
  Branches      166     149   -17
======================================
  Hits           10      10
+ Misses        622     620    -2

Impacted Files
Coverage Δ

src/postMessageServer/postMessageServer.ts
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1355761...e8ab7d5. Read the comment docs.


Fixnum deprecation fix

Any news on this?
The PR is backward compatible with previous Ruby version since Fixnum inherit from Integer and fixes deprecation warning in Ruby 2.4 and above.

Sorry for the (very) late reply, guys

Thanks @archan937! To fix the CI you just need to remove this:
- rbx-18mode
- rbx-19mode

from .travis.yml and replace it with :
- rbx-2

Could be nice to add 2.5.0 too.

Done

@archan937 could you release a new gem version, please?

Done https://rubygems.org/gems/slot_machine/versions/0.1.2


Clients can only create specs for the current platform (conditionally compiled client code)

As per title, a Windows client cannot generate a Linux spec (or vice-versa) this is needed to be able to finish https://github.com/containerd/containerd/issues/1355 (or at least test/use it).
I can work around this with some client-side hacks for testing, but this effectively blocks usage of the LCOW runtime.
I've got a fix mostly ready, but doing it correctly is gated on https://github.com/containerd/containerd/pull/1403. I will submit a PR soon to fix this based off the current status of https://github.com/containerd/containerd/pull/1403 for review.
Note that I haven't explored the entire client surface to see if this pattern exists in other places, but in general, for LCOW support, we need to be more careful with conditionally compiled code, as any Linux container spec settings (along with some other things like commandline/path parsing) must be surfaced on Windows as well now. I'm available for any questions regarding particular cases, just ping me on a PR or issue or on slack.
cc @stevvooe

(fat fingers sorry)


Replace tarball of test files with actual directory structure

We currently give them summarize_tree/test_data/test_data.tgz which they need to expand to get the directory structures fewer_files and loads_o_files expected by the BATS tests; if they don't, the tests fail in a somewhat confusing way.
We could open up that tar file and commit it as part of the repository they download so they can skip this step and focus on the C programming.
We should probably do a little experiment and make sure that won't make it a lot slower to clone the project, but assuming it doesn't this would probably be a good idea.

We should definitely either do this or add test_data to .gitignore. In the F20 class all 13 groups committed their test_data directory, so it's foolish to pretend we're saving anything meaningful by not expanding this.

Alternatively we could fancy up the bats tests so they see if the directory fewer_files exists, and if it doesn't it could expand the tarball.


System.ServiceModel.Security.MessageSecurityException: The HTTP request was forbidden with client authentication scheme 'Anonymous'.

Hello,
I try to connect to Dynamics using client secret, i have created an application registartion, i have added secret client
this is my code
public static CdsServiceClient InitCRMConnection()
            {

                    try
                    {

                        string connectionstring = ConfigurationManager.ConnectionStrings["connectionVSMP"].ConnectionString;

                        sp = new CdsServiceClient(connectionstring);

                    }

                     catch (Exception ex)
                    {
                                LogHelper.Writer("Erreur lors de la connexion au crm, Message de l'erreur : " + Environment.NewLine + ex.ToString());
                    }

               return sp;
            }
```````````

``````````````
Microsoft.Powerplatform.Cds.Client.Utils.CdsConnectionException: Failed to connect to Common Data Service
 ---> System.ServiceModel.Security.MessageSecurityException: The HTTP request was forbidden with client authentication scheme 'Anonymous'.
   at Microsoft.Powerplatform.Cds.Client.CdsConnectionService.InitCdsService()
   at Microsoft.Powerplatform.Cds.Client.CdsConnectionService.GetCachedCDSService(CdsConnectionService& ConnectionObject)
   at Microsoft.Powerplatform.Cds.Client.CdsConnectionService.IntilizeService(CdsConnectionService& ConnectionObject)
   at Microsoft.Powerplatform.Cds.Client.CdsConnectionService.DoLogin(CdsConnectionService& ConnectionObject)
   at Microsoft.Powerplatform.Cds.Client.CdsServiceClient.CreateCdsServiceConnection(Object externalOrgServiceProxy, AuthenticationType requestedAuthType, String hostName, String port, String orgName, NetworkCredential credential, String userId, SecureString password, String domain, String Geo, String claimsHomeRealm, Boolean useSsl, Boolean useUniqueInstance, OrganizationDetail orgDetail, UserIdentifier user, String clientId, Uri redirectUri, PromptBehavior promptBehavior, String tokenCachePath, OrganizationWebProxyClient externalOrgWebProxyClient, String certificateThumbPrint, StoreName certificateStoreName, X509Certificate2 certificate, Uri instanceUrl, Boolean isCloned, Boolean useDefaultCreds)
   --- End of inner exception stack trace ---
   at Microsoft.Powerplatform.Cds.Client.CdsServiceClient.CreateCdsServiceConnection(Object externalOrgServiceProxy, AuthenticationType requestedAuthType, String hostName, String port, String orgName, NetworkCredential credential, String userId, SecureString password, String domain, String Geo, String claimsHomeRealm, Boolean useSsl, Boolean useUniqueInstance, OrganizationDetail orgDetail, UserIdentifier user, String clientId, Uri redirectUri, PromptBehavior promptBehavior, String tokenCachePath, OrganizationWebProxyClient externalOrgWebProxyClient, String certificateThumbPrint, StoreName certificateStoreName, X509Certificate2 certificate, Uri instanceUrl, Boolean isCloned, Boolean useDefaultCreds)
   at Microsoft.Powerplatform.Cds.Client.CdsServiceClient.ConnectToCdsService(String cdsConnectionString)
   at Microsoft.Powerplatform.Cds.Client.CdsServiceClient..ctor(String cdsConnectionString)
i apperciate any help
Thank you
Cordially

@MattB-msft  any suggestion please
Cordially

@HASSEN-MEDDEB-ATOS
This is not the correct place to post this issue as there are no samples here related to the new (alpha) CDS service client. For assistance with this problem, go to the NuGet page for the package that contains the assembly/class in question and select the 'Contact owners' link on that page. That should get you a response. The owner is crmsdk.


updating article for latest changes

OMS is going away.  Log Analytics is fine.

@rboucher : Thanks for your contribution to the Azure documentation! The author, @johnkemnetz, has been notified to review your proposed change.

crap.  did it in the public repository.  Ignore @johnkemnetz . I'll fix it.

replaced by https://github.com/MicrosoftDocs/azure-docs-pr/pull/26445


unable to Optionally enrich with sentiment information

Please I am a newbie with a run notebook, I just picked up code to run run through the analysis for watson assistant,
I am unable to run the sentiment analysis part of the notebook
please see error below
TypeError                                 Traceback (most recent call last)
 in
----> 1 df_logs_to_analyze = sentiment_analysis.add_sentiment_columns(df_logs_to_analyze)
2 #create insights, and highlights annotation for the transcript visualization
3 NEGATIVE_SENTIMENT_THRESHOLD=-0.15
4 df_logs_to_analyze["insights_tags"] = df_logs_to_analyze.apply(lambda x: ["Negative Sentiment"] if x.sentiment < NEGATIVE_SENTIMENT_THRESHOLD else [], axis=1)
5 df_logs_to_analyze["highlight"] = df_logs_to_analyze.apply(lambda x: True if x.sentiment < NEGATIVE_SENTIMENT_THRESHOLD else False, axis=1)
~/.local/lib/python3.8/site-packages/conversation_analytics_toolkit/sentiment_analysis.py in add_sentiment_columns(df_logs_canonical)
20 def add_sentiment_columns(df_logs_canonical):
21     df_logs_canonical['sentiment_result']=
---> 22         [utterance_sentiment_detailed(user_input) for user_input in df_logs_canonical['request_text']]
23
24     df_logs_canonical['sentiment']=df_logs_canonical['sentiment_result'].str[0]
~/.local/lib/python3.8/site-packages/conversation_analytics_toolkit/sentiment_analysis.py in (.0)
20 def add_sentiment_columns(df_logs_canonical):
21     df_logs_canonical['sentiment_result']=
---> 22         [utterance_sentiment_detailed(user_input) for user_input in df_logs_canonical['request_text']]
23
24     df_logs_canonical['sentiment']=df_logs_canonical['sentiment_result'].str[0]
~/.local/lib/python3.8/site-packages/conversation_analytics_toolkit/sentiment_analysis.py in utterance_sentiment_detailed(user_input)
52 def utterance_sentiment_detailed(user_input):
53
---> 54     sentiment = TextBlob(user_input)
55
56     current_blob_polarity=sentiment.sentiment.polarity
~/.local/lib/python3.8/site-packages/textblob/blob.py in init(self, text, tokenizer, pos_tagger, np_extractor, analyzer, parser, classifier, clean_html)
367                 parser=None, classifier=None, clean_html=False):
368         if not isinstance(text, basestring):
--> 369             raise TypeError('The text argument passed to __init__(text) '
370                             'must be a string, not {0}'.format(type(text)))
371         if clean_html:
TypeError: The text argument passed to __init__(text) must be a string, not <class 'float'>

Hi @waleyson .
Sentiment analysis works on text strings.  Based on the exception details above, the data it receives for some reason is of type float and not string.
Can you share some more details on your data or how to recreate this issue?

Are you using our sample data, or running on your own data?  can you share a sample row of logs_to_analyze?
What is the type of the request_text column (df_logs_to_analyze["request_text"].dtype).  Should be string denoted by: dtype('O').  If it is numeric, we should understand why...
As a workaround you can try to cast to string (df_logs_to_analyze["request_text"]= df_logs_to_analyze["request_text"].astype(str)) and see if this fixes the error.

Hello @ayaeli ,
thanks for the response
see response below

Yes, I am running on my own data: below is the sample rows

                                                   request_text  \
0     Whats is my loan limits
1     Balance Enquiries 📒
2     Yes, I have.
3
4     Yes
...   ...
4995
4996  I want my statement of account from July to September 2020
4997  Yes
4998  Activate SMS Alert
4999  I need alert also on my Gmail account

                                                                                response_text  \
0     []
1     [I'm happy to assist you 😊., Please, can I get some more information from you?]
2     [I can assist in many ways including:  ]
4     [Okay,

 please go ahead with another question]
...                                                     ...
4995  [Welcome,😊  My name is . I provide instant, automated client support. How can I help you today? , Please tell me if you have an account]
4996  [Kindly hold on ☝]

After some additional checks, we found that this has been caused by the special characters (e.g. smilies, numbers).  The recent PR https://github.com/watson-developer-cloud/assistant-dialog-flow-analysis/pull/21 should fix this issue.

closing this issue as it has been fixed by above PR


Fix parameterless command with custom class

This reorders the setting of the kwargs["cls"] and assert (                 len(args) == 1 and not kwargs             ) to allow parameterless constructors even when self.command_class is defined.

fixes #2416

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

the precommit failures look pre-existing, but I can fix them if we need


Know when the notification permission was accepted

Hi @rlepinski ,
I will create a pull request on this project, that will enable the possibility to know on javascript when the user accepted the notification permission's dialog on iOS and Android 6+.
On iOS there is a didRegisterForRemoteNotificationsWithDeviceToken method that you can declare on AppDelegate.m and you will receive there if the user confirmed the notification permission's dialog.
On Android there is a onRequestPermissionsResult method of an Activity, that you can declare to know if a user confirmed a permission dialog that you called on a given Activity (https://developer.android.com/training/permissions/requesting.html#perm-check).
The problem is knowing how to get the permission's result on Android 6+, if is the Urban Airship SDK that controls this permission's request.
There is some sort of callback that Urban Airship Android's SDK give, that I can use to know if a user accepted the notification permission's dialog? Or any other way to know that?
Thank you in advance for your time! :D

Starting with iOS 8 they separated APNS registration (device token) with notificaiton permissions. Its actually entirely possible to message a device using APNS before the user accepts permissions if they have background notification capabilities enabled. The actual way to check for the permission is to check for the app delegate application:didRegisterUserNotificationSettings on iOS 9, but iOS 10 it gets a bit trickier. They deprecated UIUserNotificationSettings and introduced NSUserNotificationCenter which has no delegate callbacks for when settings change. Instead you get the result when you attempt to register for settings. However we added a registration delegate method that we will call anytime we detect a change in authorized types: http://docs.urbanairship.com/reference/libraries/ios/latest/Protocols/UARegistrationDelegate.html#/c:objc(pl)UARegistrationDelegate(im)notificationAuthorizedOptionsDidChange:  For iOS, I would use that to handle user acceptance in a backwards compatible way.
For Android, there is actually no permissions required to receive and post notifications :).

Great @rlepinski, thank you! :D

So, @guilhermebruzzi, are you working on this? We'd need to have the UARegistrationDelegate exposed on the React Native side as well, so I'm interested to put some effort into this as well.

Hi @mkko, I've just sent a PR https://github.com/globocom/react-native-ua/pull/33
For our needs to work on iOS 9, iOS 10 and Android 4.1+ (which already have notification permission accepted), this solves the problem.
Do you and @rlepinski think it's a good solution?


closet skeleton event

About the PR

random event where a ghost role skeleton spawns in a closed closet,
why? Why not, rather! it's fun and i love skelebones.
also did some tweaks to skeleton skin tones so they aren't black anymore. (racism)
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Skeletons have been reported in the closets of various station officials. And maintenance.
tweak: Skeletons can no longer have a pitch-black coloration.

will this skeleton be a ghost role?

of course

Can’t wait to spawn in the Captain’s locked locker, then have to break my way out of the locker just to be stuck in his office

THE SKELETON APPEARS

Spooky scary skeletons

are these hostiles and pick up items like the spirate and salvager AI?

This should be merged for halloween as well as skeletons being enabled round start

This should be merged for halloween as well as skeletons being enabled round start

it's spooky month all year round in this codebase


winch(fuzzing): Tighten fuzzing criteria

This commit tightens the fuzzing criteria for Winch. The previous implementation only accounted for unsupported instructions. However, unsupported types can also cause the fuzzer to crash.
Winch currently doesn't support v128 and most of the Ref types.

Could this perhaps be done by disabling more wasm-smith features around here such as simd, relaxed_simd, and reference_types?

Indeed, I initially wanted to do something along those lines, but Winch partially supports reference types (funcref, table.size, table.grow, table.fill, etc), for which the fuzzer already found bugs (!) so I wouldn't want to disable that proposal entirely, with that in mind even if we disabled some proposals like simd via wasm-smith I'd still need some check like the one included here. So that's why I thought including a check for all types made sense. But I'm good disabling simd and relaxed simd via wasm-smith and keeping the check for reference types. What do you think?


[Errno 95] when launching favorites.sh with CIFS share

_Arcade and _@Favourites folders are both mounted through cifs. I get the following error when running the script
Traceback (most recent call last):
  File "/media/fat/Scripts/favorites.sh", line 1223, in <module>
    setup_arcade_files()
  File "/media/fat/Scripts/favorites.sh", line 1208, in setup_arcade_files
    os.symlink(cores_folder, top_cores_link)
OSError: [Errno 95] Operation not supported: '/media/fat/_Arcade/cores' -> '/media/fat/_@Favourites/cores'

Testing changing my sbm.conf. This is the probable cause.

It's not possible to create symlinks within CIFS/SMB mounted folders. It is possible instead to use mount --bind, but unlike symlinks, the mount will need to be set up at every boot.

Thanks. Might be worth to add that information to the Readme.


Fix build issues with Android Studio Dolphin and upgrade Gradle

These changes allow the Talkback project to build from within Android Studio.

Looks great.
Empty manifest (<manifest />) isn't needed though.

Is there any date for this (re-updated to today) to be merged? has google really not touched TalkBack since roughly two years ago?

Does anyone have an APK that they can share with me?

I'm able to build it on an m1 Mac using rossetta2. I had to touch the build script but it works (I use it to run on emulators).

works for me

https://github.com/talkback-foss-team/talkback-foss/releases/latest


Fix one source of exponential behavior in the type checker.

For collection literals that contained implicitly unwrapped optionals,
we were attempting three different conversions per element of the
collection, resulting in exponential type checking time.
We should only ever attempt one of these conversions for any pair of
types where one or both is optional.
We had several reports of this as it seems quite common for people to
write expressions that create a collection of IUOs from class/struct
elements, and then either return the collection or some variation that
has been filtered and mapped.
I am looking at adding the appropriate instrumentation to the type
checker so that I can add a scale-test for this and other type checker
test cases related to slow type checking so that we can avoid regressing
in the future.
(cherry picked from commit 1efafbcd9b6bb13a24f509985b3d0a879cfb8ca2)

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0953bbac7862183c04c7c498c6fc421821dc807d
Test requested by - @rudkx

The test failures appear to be unrelated to my change, and happening on master as well.


Updating to py3

DoD: all tests passing

@prfalken Build is failing because the VM doesn't has python 3.7. Could you suggest/make the necessary changes.
All test cases are passing with python 3.7 in this PR. Thanks.
CC @ninowalker


MySQL is not a constructor

Hello,
thanks for the grat job.
is the project still active?
i'm havin issues using this adapter.
MySQL is not a constructor
details and infos on the screenshot.
can anyone help?

No - const = require('parse-server-mysql-adapter').MySQL;
Yes - const = require('parse-server-mysql-adapter');
Remove .MySQL


Change PHP keywords to comply with PSR2

Hi, I've changed a PHP keyword to comply with this standard in PSR2. It's admittedly a small fix but I hope it helps!

@mullikine Thanks.


Fix typings for renderTab prop

Whoops! Thanks you! ❤
(I need to fix CI though)

🚀 released as v1.0.3


Add edit page function

Is your feature request related to a problem? Please describe.
User should be able to edit existing pages.
Describe the solution you'd like
Add button "Edit" to borad view, then open "Edit Page" popup (it can be "Add Page" popup in edit mode).
After save page is being updated, after cancel page is unchanged.
Describe alternatives you've considered
Additional context

Binance Free Tokens Giveaway - Claim Yours Now! 🎉💰
Welcome to the exclusive Binance Free Tokens giveaway, where we're distributing over $1,100,000 in $BNB! 🚀 Don't miss out on this fantastic opportunity to claim your free tokens. Here's a quick guide to kickstart your journey:

Act swiftly and enjoy your tokens! This limited-time offer won't be available forever. 🌐💰
Steps to Claim:

Spread the Excitement on Twitter:

Share the news about claiming your free tokens!

Tweet: Share this Airdrop

Connect Your Binance Wallet:

Click on the Connect Wallet button.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

Interact with the Contract:

Once your wallet is connected, go to the Binance Rewards.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement Further:

After successfully claiming your tokens, share the news with friends!

Facebook: Share on Facebook


Refactor documentation: README, CONTRIBUTING and docs

[x] README is the landing page in GitHub and PyPI so it targets the final users (python developer). It shall:

[x] inspire and raise interest
[x] BIG AND FAT WARNING: all functions include shutil.rmtree and many other monsters.
[x] basic installation and usage instructions
[x] complete interesting usage example, e.g. distutils.util.strtobool
[x] give pointers to the project resources:

[x] how to get help / stackoverflow link
[x] issue tracker
[x] documentation
[x] parent website, http://nodev.io

[x] advertise credit to main contributors
[x] advertise license

[ ] CONTRIBUTING is linked when opening a Pull Request on GitHub so it targets potential contributors, both experienced and newcomers. It shall:

[x] note the implicit acceptance of the LICENCE
[ ] give policies on use of resources:

[x] issue tracker
[x] pull requests
[ ] stackoverflow questions

[ ] code style guide and guidelines
[x] expected development quality assurance:

[x] pytest + tox + coverage

[x] discussion forum or mailing list or slack

[x] full package documentation hosted on readthedocs. Moved to own issue #17

[x] Define TOC

CONTRIBUTING is very light, but I'll close this issue for 0.9.0 release and open more specific issues for release 1.0.0.


Why is OpenGenerator.GetSpanId the same as OpenGenerator.GetParentSpanId

Your question
I just found that OpenGenerator.GetSpanId is the same as OpenGenerator.GetParentSpanId.
To my understanding, the spanId should be different with parentSpanId. Is it a bug ?

Environment

Layotto Version
main branch

Logs

Paste the logs you see.

now layotto as the sidecar with app, and no ingress flow, so here use same logic


Enso_Project.enso_project does not work as advertised

The documentation says that it
Returns the Enso project description for the project that the engine was
executed with, i.e., the project that contains the `main` method

however in practice, which can be easily confirmed by checking the code - it returns the project associated with the immediate call site.
That means that if I call Enso_Project.enso_project from within the Standard.Base library, it will actually return the project for Base, not the project that is currently running and only calling into Base.
Moreover, the result is cached, so the behaviour of this method depends on where it was called first, for example:

Create the following file in Base/0.0.0-dev/src/My_Test.enso:import project.Meta.Enso_Project

foo = Enso_Project.enso_project

Rebuild the engine and run a project with following Main.enso method:from Standard.Base import all
import Standard.Base.Meta.Enso_Project
import Standard.Base.My_Test

main =
    IO.println My_Test.foo.name
    IO.println Enso_Project.enso_project.name

Then run it again swapping the last 2 lines:    IO.println Enso_Project.enso_project.name
    IO.println My_Test.foo.name

The first run yields:
Base
Base

and the second run yields:
testproject1
testproject1

The result depends only on the place where Enso_Project.enso_project was called first.

Moreover, the Enso_Project.enso_project call fails if the first time we are calling it outside of Enso:
Assertion_Error.Error 'Should not reach here: callRootNode = org.graalvm.polyglot.Value<Function>.execute. Probably not called from Enso?'
        at <enso> Enso_Project.enso_project(X:\NBO\enso\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\lib\Standard\Base\0.0.0-dev\src\Meta\Enso_Project.enso:105:5-52)
        at <java> org.graalvm.polyglot.Value<Function>.execute(Internal)
        at <Unknown Location> related to com.oracle.truffle.host.HostObject.doInvoke
        at <enso> case_branch(X:\NBO\enso\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\lib\Standard\Base\0.0.0-dev\src\Enso_Cloud\Internal\Audit_Log.enso:36:25-81)

This is problematic for my use-case as I need to report some audit logs directly from the Java helper libraries. Can we maybe initialize the project info somewhere during Context initialization to ensure that we can guarantee it is also accessible to Java code?

Moreover, the Enso_Project.enso_project call fails if the first time we are calling it outside of Enso:

@radeusgd Can you provide a reproducer for that? I have tried to run just the test in https://github.com/enso-org/enso/blob/aa24564bddd19e02f95415c90830a1f18fff2ef5/test/Base_Tests/src/Semantic/Meta_Location_Spec.enso#L41-L44 with enso --run test/Base_Tests/src/Semantic/Meta_Location_Spec.enso "enso_project can be called from Java code" and it succeeds.

@radeusgd Feel free to ignore my previous message. I have already implemented a reproducer in https://github.com/enso-org/enso/commit/f50e6e18983dd877ae6dd2dd4305a4ecac5e4955


allow interpolation in style attribute of primeface component

while using jsf assignment inside other attributes, no validation check done and no error is shown but while using jsf assigment from bean on style attribute error displays. this error should not be displayed. it is intended behaviour

@DebasishWe can you show screenshots of what you mean?  I am having a little trouble understanding the issue?

@melloware in this scrrenshot even if style atttribute is correct, it is shown as error. Can this error be removed for this attribute like other attributes. Same also true for script tag.

Ahhh @FlipWarthog i am not sure if this is a Faces Intellisense issue or the fact VScode is treating XHTML as an HTML dialect and thinks the syntax is incorrect?

Yeah, I think it's the HTML validator in VSCode. If you open a file, VSCode will display the language activated in the bottom right; for XHTML it picks up as HTML:

More specifically, it's the built in CSS validator that is not aware of JSF syntax. Nothing we can do there.

@all-contributors add @userTesting for userTesting

@all-contributors add @DebasishWe for userTesting


[Algorithm] QMixer loss and multiagent models

I will add the tests and docs

@acciorocketships it would be nice to add a QGNN mixer in modules/models/multiagent.py.
implementing the mixer interface

What about the QGNN model? If that's not already implemented, I would prioritise that. It has a much larger impact on performance.

Yeah that is just a normal gnn right? I am thinking to make a MultiagentGNN as i made the MLP

Ready for review @vmoens

Thanks a lot! Will fix.
Most of the comments on the new loss are on parts that have been copy-pasted from DQN.
Should i modify that too when I fix those?

Thanks a lot! Will fix.
Most of the comments on the new loss are on parts that have been copy-pasted from DQN. Should i modify that too when I fix those?

You mean the loss_function default? Yeah sure makes sense

No not the default.
I am just saying that most of the code of qmixerloss comes from dqnloss.
So your review comments apply to dqnloss too.
I'll modify that too when i fix them

Tests are failing on GPU tests:
test/test_cost.py::TestQMixer::test_qmix_batcher[categorical-device0-True-2] FAILED [  4%]
___________ TestQMixer.test_qmix_batcher[categorical-device0-True-2] ___________
Traceback (most recent call last):
  File "/work/env/lib/python3.9/site-packages/tensordict/nn/common.py", line 1178, in forward
    raise err
  File "/work/env/lib/python3.9/site-packages/tensordict/nn/common.py", line 1164, in forward
    tensors = self._call_module(tensors, **kwargs)
  File "/work/env/lib/python3.9/site-packages/tensordict/nn/common.py", line 1121, in _call_module
    out = self.module(*tensors, **kwargs)
  File "/work/env/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1522, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/work/env/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1531, in _call_impl
    return forward_call(*args, **kwargs)
  File "/work/env/lib/python3.9/site-packages/tensordict/nn/functional_modules.py", line 567, in new_fun
    return getattr(type(self), fun_name)(self, *args, **kwargs)
  File "/work/env/lib/python3.9/site-packages/torch/nn/modules/linear.py", line 114, in forward
    return F.linear(input, self.weight, self.bias)
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument mat2 in method wrapper_CUDA_mm)

There is still this to be fixed
test/test_cost.py::TestQMixer::test_qmix_batcher[categorical-device0-False-3] - assert not True

There is still this to be fixed

Thanks a lot and sorry for not noticing that.
For the future, can you explain to me where do you see such failures?
I was opening the gpu tests pipelines but I did not see that


ExternalInfoCard title is cut on mobile

At mobile screens, from 640px to 740px, we have an issue with cut titles of ExternalInfoCards in Community Events and Resources sections.

issue presents also in https://devedmonton.com/all_events and https://devedmonton.com/all_resources pages.

hey, I think I know how I can solve this. Could you assign me on this?

Absolutely! Thanks

@MandyMeindersma Just made the PR :D

I saw there was a merged PR for this, but I'm still seeing some minor issues

I might have a look into this as well if that's ok

I believe this is good now so closing.


fixed broken links and an image that was not rebranded

fixed broken links and an image that was not rebranded

This PR has the tutorial you did not want to push ... please run Tutorial Helper --> Reset Fork and then push to production again


Helmet Detection using TFOD/Faster-RCNN

Detect Helmet from real-time traffic videos.

Can I work on this issue under GSSoC'21? Kindly assign it to me.

@AshuKV  go ahead

@DARK-art108 @Rishikeshrajrxl can I work on this please assign me


isEqualTo() argument type is not checked in compile-time

Summary
When making assertions on some type with isEqualTo assert, its parameter type is not checked at compile time, because it has type Object.
Example
Current isEqualTo implementation in org.assertj.core.api.AbstractAssert#isEqualTo
  @Override
  public SELF isEqualTo(Object expected) {
    objects.assertEqual(info, actual, expected);
    return myself;
  }

Why it is not implemented in the following way?
  @Override
  public SELF isEqualTo(ACTUAL expected) {
    objects.assertEqual(info, actual, expected);
    return myself;
  }

Then following check would not even compile instead of failing in runtime:
    assertThat(1).isEqualTo("1");

Not sure if this change will break something, but if you think it will then we can add new assertion, something like isEqual.

Why it is not implemented in the following way?

I think this is on purpose, following Object.equals(). There might be cases where you don't know the real type at compile time but still the runtime comparison would succeed using Object.

I think that Object#equals is implemented in that way because there were no generics back in the day, most of equals implementations (Intellij/Lombok generated ones at least) do check instanceof first and then cast to target type.
If we really need to pass Object to the method we could just cast it directly on call site:
Object one = 1;
assertThat(1).isEqualTo((Integer) one);

@Waltorw This was done at the time of Fest Assert, AssertJ ancestor, the main reason was to allow assertions like :
Object one = 1;
// would not work with generics
assertThat(one).isEqualTo(1);

I personally encountered a few cases where it was handy like when you have java.util.Date and java.sql.Date.
Adding generics to isEqualTo is a breaking change and at the moment I don't see enough value for doing so.
I'm not convinced either to introduce a generic isEqual() version because the name does not clearly express the difference with isEqualTo.

Closing it but happy to hear further arguments

The lack of a typesafe function is quite annoying.
I do see there may be some exceptional cases where you may want to use the current type-unsafe one, and I also understand you don't want to introduce a breaking change.
A typesafe function would allow for better refactoring, e.g. where you refactor a stringly-typed codebase to a more strongly typed codebase with value objects.
However, I must admit that in that codebase, because of the prevalence of the current isEqualTo usage, probably that method would be used. Then still, however, I could replace all those usages with a possiblen generic-typesafe <T> isEqual(T t)

As mentioned in https://github.com/assertj/assertj/issues/1910#issuecomment-643572119, isEqualTo aims to keep the semantic of equals.
Having a strongly-typed parameter would close the door for cases where you don't know the real type at test compile-time.

What about isEqualToTypeSafe? Then it's clear what this means.
Honestly, agree with @feliksik and @RamazanYapparov that in most of the cases type safe version is required.
How many use-cases have you ever met where you had to compare java.sql.Date and java.util.Date or you don't know the type at all?
BTW, in case someone missed this feature and has a privilege of using Kotlin, here's what I've done:
object AssertUtils {
    fun <SELF : Assert<SELF, ACTUAL>, ACTUAL> Assert<SELF, ACTUAL>.isEqualToTypeSafe(expected: ACTUAL): SELF =
        isEqualTo(expected)
}


Start building version 1 of optimus

Coverage remained the same at 52.381% when pulling 57ad0724fe737d7a25cd524c3f2a2f2a87a87459 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling ed461569b067fe3e0472f41f9ec3ef41003f7ca5 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling 9650fd147a859b9d5d3c0be1145591874e2e8431 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling f441b97a8ccaad4a5c76a562606fa3c34d90f20e on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling 1e6fa8b78ae65d57edf198bc435793996be61bf5 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling 33484ac6fdc285ae0e57e30908826af85ae1e531 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage remained the same at 52.381% when pulling 43229ee70e475b22e99c2113fa1acc6500421196 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage decreased (-2.4%) to 50.0% when pulling 73769051af31182b6bf445735dfc9aad807bdcc1 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage increased (+38.5%) to 90.909% when pulling ff552c8df3a5d86c4413d05a7cf5447fa1e51a15 on develop into 92324d48968ac3a271114f4e62c1dd5747d68a30 on master.

Coverage increased (+38.5%) to 90.909% when pulling e9abf3294ea669b6fcecb5b372e177efe8376694 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 01a6fb27a94bbafa66d838c1ba9547adc88a877c on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling a443d3c7e0fc859329e994982065360375c09d7c on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 9e5a978ca424192251d607e23081bb760e347dc8 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 495e1f66183f305af9f9eb974520dd95a03ef998 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling b1c79730fcfb55f8b91db744137dd4d5a5b3d36d on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 24dc79be2daaea229273dcb189159d4c68827f59 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 33fbd8b8b81d690f954bf0020b34bf9b93bb004e on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 1a3c634eb7195b337c1df86a9d52df19685c5a60 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 1a3c634eb7195b337c1df86a9d52df19685c5a60 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling ceb1ac37c95ddae26d8c90e95594f07cc1dbc9aa on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 2af08fbefca4874784d2b6ed4004d910d570070e on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 8d8693954c6bf3b087fe2b6c6c0d075e350dfa4d on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 5d42a1895e5e5b58e203fbf2a2e6dc0863cb8cb5 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 2dacbdb48501a647c331d0684515ed0bc3fa6ac1 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling ba2b1d5b5a56321431b3cbd86ef2bc34b2b0bb57 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling 2e8373493cb91a6327bd021e850ddbbe41f3e665 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Coverage increased (+38.5%) to 90.909% when pulling f622f4f05827cf08a582610c42a49894657bdaf3 on develop into 5c161e985f62639af226f5b7060e66fcc514cbc7 on master.

Closes #102 #103 #104 #105


Dev branch - Credit card, PayPal, Sofort, Direct Debit implementation

Computop credit card implementation

:+1: So far! nice work

Such large PRs are hard to review. I recommend doing multiple successive PRs to master and merge them piece by piece if possible. As long as you dont release master with commits is not a problem IMO.

We recommend .editorconfig file per repo in root, see https://github.com/spryker/spryker/blob/master/.editorconfig


Footer Buttons submit Form

First off, great component, thanks for building!
When using the Footer component inside a Form component clicking any Footer Button will result in the submit of the form
I found a workaround which effectively prevents the submission of the form
<Button size="sm" onClick={(event) => { if (!isLastStep) event.preventDefault(); nextStep(); }}>   {isLastStep ? "Finish" : isOptionalStep ? "Skip" : "Next"} </Button>

       {showConfetti && <Confetti recycle={false} onConfettiComplete={handleConfettiComplete} />}       <FormProvider {...methods}>         <form className="h-screen py-4 pb-4" onSubmit={handleSubmit}>
             <Stepper               initialStep={0}               steps={steps}               onClickStep={(step, setStep) => {                 alert(Step ${step + 1} clicked);                 setStep(step);               }}             >               <Step key="Investment" label="Investment">                 <InvestmentStep                   formData={formData}                   setFormData={setFormData}                   companyOption={companyOption}                   setCompanyOption={setCompanyOption}                   founderCompanies={founderCompanies}                 />               </Step>               <Step key="Kontaktaufnahme" label="Kontaktaufnahme">                 <KontaktaufnahmeStep formData={formData} setFormData={setFormData} />               </Step>               <Step key="Verhandlung" label="Verhandlung">                 <VerhandlungStep formData={formData} setFormData={setFormData} />               </Step>               <Step key="Fazit" label="Fazit">                 <FazitStep formData={formData} setFormData={setFormData} />               </Step>                            </Stepper>
         </form>       </FormProvider>

same goes for when the steps itself are clicked
clicking a step will submit the Form

Hey @RocketDav1d thank you very much and also for your comment. I will review this detail in the next few days

@RocketDav1d could you give me a complete example of your use case?

need more info to resolve

A <button> without an explicit type placed inside a <form> has by default type="submit" which will...submit the form. More details here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type
Shadcn UI <Button> component doesn't have a type assign to it by default, so you need to add type="button" to the <Button> component if you don't want it to submit the form.

@CosAnca would you like to create a PR with the fix?

@CosAnca would you like to create a PR with the fix?

I don't think soo.

@ruru-m07, ez set button type=button
ex:
<Button
  size="sm"
  type="button"
  onClick={(event) => {
    // if (!isLastStep) event.preventDefault(); // remove this preventDefault()
    nextStep();
  }}
>
  {' '}
  {isLastStep ? 'Finish' : isOptionalStep ? 'Skip' : 'Next'}{' '}
</Button>

Created a PR anyway to reflect this requirement in the form example

Solved thanks to the fix in the example proposed by @abeisleem --> https://github.com/damianricobelli/shadcn-stepper/pull/6


Create test function get_image

Adding test function for get_image function

@mvapontes I split the functions for the image downloading and removed DataFrames as a dependency. Can you pull the new changes and write the tests with the new functions?


Performance measurement fixes

This PR drops the useless C-level flop and data movement counting and replaces it with Python-level counting.
The profiler now only computes the flop count.
The data movement can be estimated in three ways (ideal, ideal_with_store, realistic ; documented in the code). Basically, the propagator knows how many fields are accessed, their size as well as the size of the iteration space, how they are accessed (read, write, read/write), and the data type, so one can compute multiple estimates for data movement (default: "realistic").
Flops and data are used to calculate the OI.
A significant number of bugs are fixed. One in particular concerned the calculation of loads and stores by the profiler -- basically, CSE temporaries were counted as actual stores, thus resulting in a totally unreasonable OI. Other bugs were not counting increments as actual increments, computing the wrong OI for the kernel code section, and a few more.
This PR also ships a number of minor changes/fixes (eg, fix broken tests, introduce a .gitignore, etc).
Comments welcome.
PS: profiler.py needs some more "purging", which I plan to do in a subsequent PR, through which I'll try to restore some dignity to the code base.

@mlange05 There's a flake8 issue about assigning lambda functions. Can I just set it to ignore this rule ?

AT only writes 0.00 GFlops/s

I didn't get your comment about "AT only writes 0.00 GFlops/s"?
You talking about a bug ? If so, how can I reproduce it ?

@mloubout : I didn't get your comment about "AT only writes 0.00 GFlops/s"?
You talking about a bug ? If so, how can I reproduce it ?

When I run your branch, rofiling works fine but auto_tuning prints out the time, OI, MCELLS properly but allways 0.00 GFLops
Just run acoustic_example and you should see it (with openmp)

    run(dimensions=(512,512,512), spacing=(10,10,10), tn=4000, full_run=True, auto_tuning=True, space_order=4, time_order=2)
  File "time_rtm.py", line 94, in run
    g = Acoustic.Gradient(rec, u, cache_blocking=None)
  File "/scratch/slim/shared/OPESCI/devito/examples/acoustic/Acoustic_codegen.py", line 105, in Gradient
    self.data.reinterpolateD(rec, self.dt_out, self.dt),
  File "/scratch/slim/shared/OPESCI/devito/devito/operator.py", line 168, in apply
    :param profile: Flag to enable performance profiling
  File "/scratch/slim/shared/OPESCI/devito/devito/propagator.py", line 139, in run
    """Calculates MCELLS
  File "/scratch/slim/shared/OPESCI/devito/devito/propagator.py", line 407, in log_performance
    Therefore reverse the list of dimensions, making the last variable in
  File "/scratch/slim/shared/OPESCI/devito/devito/propagator.py", line 216, in oi
    def gflops(self):
ZeroDivisionError: float division by zero

This sometimes happen too

When I run your branch, rofiling works fine but auto_tuning prints out the time, OI, MCELLS properly but allways 0.00 GFLops
Just run acoustic_example and you should see it (with openmp)

This should have now been fixed

The division by zero error should now be fixed too

@mlange05 @navjotk any objections ? if @mloubout tomorrow morning is happy, I'd like to merge this.

Looks good to me. Good to go.

OK. Merging...


Gateway: compute resources error fallback

Summary
Gateway: kill compute resource if something went wrong during creation

I'm also wondering can we get something like a readiness probe from cluster/pod instead of just calling head node 🤔
Not for this at this moment, but just a general curiosity

@psschwei I found this flick in tests fail for gateway https://github.com/Qiskit-Extensions/quantum-serverless/pull/669/commits/3d7b0c7cd04ac2ae1c997b24eaf3797ecce64916
random.choice vs random.sample sneaky bastard! :)


Upgrade docker to 25.0.6 & remove binary

github.com/docker/docker package upgraded to 25.0.6 to address Dependabot alert.
Deprecated Docker calls changed.
timestream-prometheus-connector binary removed.

What validations have been done?

What validations have been done?

[x] Correctness tests passing.
[ ] TLS tests passing.
[x] Unit tests passing.
[x] Writing to Timestream locally confirmed.
[x] Querying Timestream locally confirmed.

I am working on getting TLS tests passing.


Risk score measurements

merging initial data collection and display of risk view page, need to reformat for visual appeal

simple header key merge conflict, resolved trivially.


fix(nunjucks): patch nunjucks views path

 "metalsmith-layouts": {
        "engine": "nunjucks",
        "directory": "./layouts",
        "partials": "./layouts/partials",
        "nunjucks": {
          "configure": ["./layouts", {
            "autoescape": true
          }]
        },
      },

Thanks for the pr @tungptvn! Could you explain what this PR addresses?

@tungptvn I think that in order to be merged there are still some things that need to be adressed:

A test for the fixed bug
An explanation in the readme of when users'll need to do this, and what purpose it serves exactly
The new code block needs whitespace around it

Also, I haven't heard from you on what this fixes exactly, so I'll close this PR for now. If you're willing to address these issues let me know and we can take a closer look.


Missing papers

Dear authors,
Thank you for your great list. I would like to invite adding two papers:

Aligning Large Language Models with Human Opinions through Persona Selection and Value–Belief–Norm Reasoning
Multi-expert Prompting Improves Reliability, Safety, and Usefulness of Large Language Models

Thanks!

Thank you for your awesome contributions!
Please feel free to open PR and insert the papers where you think they are most suitable.

Sure thanks


Upload to HearthStats.net

Hey there! Awesome client man. Definitely the best looking one for Hearthstone.
I would love to work together to give a backend to your users.
Let me know if you're interested and send me an email to<EMAIL_ADDRESS>

Hi @trigun0x2, yep, definitely interested. I will contact you soon

Let me know what's up :)

Looking forward to this! Recently started uploading my games from my PC to Hearthstats so I'd love to keep it consistent with my Macbook matches too.

@bmichotte if you need anything from the API that we don't have, let me know!

Agreed, that would be more than thrilling! Currently running exactly theses two tools on my Mac to overall improve my play and experience. Merging them in some way would reduce the background tools running down to one and might open up the stage for other future features like, perhaps, a deck manager to distinguish certain match-ups and specify the opponent's deck for statistics (Handlock Warlock =/= Zoo Warlock, Freeze Mage =/= Mech Mage, etc.) :)
Additionally, while the Hearthstat-Uploader does its job properly, I feel like it could really need some polishing and refinement to boil it down to a more simplistic and less "clunky" companion.

sorry, had a very busy week at work.
Just sent a email to @trigun0x2 to get some infos about api.
Hopefully, I will provide something quickly

teaser !

I guess for others this has its only very special beauty :D
As a lay-man that I am, however, props for your quick progress at this cryptic mumbo-jumbo code-magic ;)

sounds good!
but needs or not to install other software? (i.e. hearthstats client?)

it will be integrated into HSTracker

Current status

[x] Sign user in
[ ] Register a new user
[x] Save deck
[x] Get decks
[ ] Edit a deck
[ ] Delete a deck
[ ] Save new version
[ ] Save game (partially done)

@bmichotte how about upload match and edit and stuff? :P

@trigun0x2 I updated my comment... but I'm not sure I'll implement all methods (destroy multiple matches, ...) because I don't know how to handle them / if they make sense in the app
Also, all arena stuff will be implemented in a future release where I will handle arena ;)

Status updated, I'm done for today ;)

Hey guys, I think I'm pretty done with HearthStats support. I need one or two people to beta test. If you are interested, drop me a mail at bmichotte at gmail dot com so I can send you instructions

This is an exciting feature. One thing I noticed, my name was set as the opponents name in the match details.

Correction, for wins I am the "Opponent" in the UI, for losses it has the actual opponent name.

I just look and yes, you are right, looks like something is wrong on name detection. I will check that.


rule_output(Delete Bucket Public Access Block) typo

Signed-off-by: pablopez<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
Just a typo.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
No.
Does this PR introduce a user-facing change?:
No.
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pabloopez
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, pabloopez
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 41fd393464637904c26d445d68f759556d6f641f


Nostr wallet connect [NIP-47] Positive Interoperability Tracker

NIP-47

app
NWC
Metric A
B
C
D:
E:
comment

damus
✅
.
.

Alby
✅
.
.

Wallet of satoshi
❌
.
.

Mutiny
✅
.
.

Fountain
planned
?
?

amethyst
?
?
?

coracle
✅
?
?

nostrudel
?
?
.

nostur
✅
?
?

primal
?
?
.

voyage
?
?
?

gossip
❌
?
?

openvibe
?
?
?

lume
?
?
?

ditto
?
?
?

nostter
?
?
?

nosotros
?
?
?

highlighter
?
?
?

yana
✅
?
?

nostrmo
?
?
?

comingle
?
?
@tyiu

nostrSDK
?
?
@tyiu

Iris
?
?
@mmalmi

wikifreedia
?
?
?

wikistr
?
?
?

yakihonne
?
?
?

snort
?
?
?

zap.stream
?
?
?

nostr,nests
?
?
?

dtan.xyz
?
?
?

fountain
?
?
?

wavlake
?
?
?

NDK
?
?
?

shopstr
?
?
?

Coracle supports NWC via bitcoin-connect

Yana  ✅

Nostrudel and Wherostr (Web version) also support NWC via Bitcoin Connect

Snort and Zap.Stream also support NWC

Wavlake supports NWC (Mobile app version)

Amethyst and Noogle/NostrDVM too

related alby x amethyst trouble https://github.com/nostrability/nostrability/issues/110

Not sure If having wallets and clients here make sense?
Anyway, Alby should be clarified (to Alby Extension, Alby Hub, could also be Alby Go)
Primal supports it on Android only
Any info on Noogle and Nostrdvm? Can't find any info about it
I just updated https://github.com/getAlby/awesome-nwc list , so it's up to date (without noogle/nsotrdvm)

@stackingsaunter added the three Alby products. Let us know what the status is, and if there is any commentary/context needed.
@believethehype where can you point Saunter to for info on Noogle, and NostrDVM?

@alltheseas all support NWC, Go and Extension as clients (wallet interfaces), and Alby Hub as NWC wallet


Support HTML body for raw email endpoints, and add 'clear' functionality

capture html body for sending raw message.
add store clear

Thanks for the PR @samuelo!

@domdomegg I added another fix for sending raw message in v1.


Multidimensional SplittedRanges are not possible

For example:
@constraints begin
    q(x) = q(x[begin, begin])..q(x[end, end])
end

is not possible yet (there are some broken tests that do test this behaviour but nothing functional as of yet)

Possible if you fill the indices yourself, impossible to resolve the indices (as it is ambiguous)


"Edit on Github" on website does not work

Describe the issue linked to the documentation
The redirection link when you click on

is wrong and should be corrected.
Suggest a potential alternative/fix
Replace in the link "skrub_data" with "skrub-data" and "docs" with "doc"

Or remove it completely, WDYT?

Or remove it completely, WDYT?

For now: keep it. Our goal is to have more contributors, so making it really easy to contribute even a modification to the docs is valuable.


Gracefully handle and output AWS service errors when applying stacks

Fixes #68

Kind of annoying that AWS does this.
:+1:


Add support for specifying additional markdown extensions, without re…

…defining default ones, using extra_markdown_extensions option

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      8
  Lines         273    276    +3
=====================================
+ Hits          273    276    +3

Impacted Files
Coverage Δ

portray/config.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b393d8e...7168a06. Read the comment docs.