Rpc for pending rewards

Closes #11830
polkadot companion: https://github.com/paritytech/polkadot/pull/5784
Polkadot address: 126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA

Still in progress.

@kianenigma Could you review this?

Also, needs a companion that adds it to Polkadot.

Also, needs a companion that adds it to Polkadot.

I will give it a try.

@kianenigma The errors are now handled.

@kianenigma I have added the rpc to the client.

Just needs to fix https://github.com/paritytech/substrate/pull/11831#discussion_r922851009

Can you provide your Polkadot address?

Can you provide your Polkadot address?

I have added my polkadot address, thanks.

\tip medium

/tip medium

@Szegoo can we also have a function here that returns the total pending reward of the pool?
I will make an example code of how to do it tomorrow. Would be good if you also add me as a collaborator to your fork so I can push directly.

@kianenigma Should I make a new PR when we merge this for the pool's total pending rewards endpoint?

@kianenigma Should I make a new PR when we merge this for the pool's total pending rewards endpoint?

I am not sure if it is possible, therefore I removed my comment.


Proposal for simple exit contract

Some loose ideas (more like brainstorming):

I was thinking about manual phase. I think we should avoid manual contract operations as those are prone to copy paste errors  and write script that would take data as csv file and do it automatically.
track addresses that would receive payout in manual process to not send eur twice to same address

this can be done offchain when preparing csv
this might be valid usecase so maybe we should not prevent it

Amount of EUR received from nominee will be known from start so it could be a constructor parameter and then validated when processing first transaction to make sure nominee would send correct amount
Idea for frontend app. Highlight minimum redeem amount and tx price to let people know that with current gas price it doesn't make sense. This depends of structure of GPR owners.
I wonder could we and if we can does it makes sense to incorporate redeem into manual payout. Then tx cost will be lower.
Add minimum payout phase period. Just nice blockchainy phase to show we do it "right" and can't control everything.


tls: removing exceptions from certs

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
https://github.com/envoyproxy/envoy-mobile/issues/176

/wait to resolve the conflictions.

/retest


Provide onInvalidate to register callbacks to call when Watcher gets updated (invalidated)

What problem does this feature solve?
Sometimes inside a Vue reactive context (Watcher) you have to read data from an external source. You might have to manage resource consumption of that external source so a way to know when is current has been notified of an update in a dependency is useful because you could cancel the external source. If current watcher is already pending a run there is no point in waiting for an external source to notify as well.
I have encountered this problem when I was implementing a reactive time formatting functions. In that case I setup a timeout until the next update to the formatted string (if currently timestamp is displayed as 1 hour ago the next update is in one hour to display 2 hours ago). But if something else triggers an update (like timestmap changing in the source) there is no point in that timeout to still be around. So ideally, that timeout should be cleared. But there is no way for that currently.
I could implement this with a reactive data source which I would modify every second and then in the formatting function use the data source  to compute the formatted string. But that would be very inefficient because it would rerun that formatting function every second when it would have to be rerun only in an hour. I could design it so that every formatting call registers its own data source which is updated only at a particular interval, but managing that would be very complex because it would not really be at regular intervals but the interval changes (for example, when string gets changed from 59 minutes ago to 1 hour ago).
What does the proposed API look like?
I would suggest Watcher gets a concept of invalidated state. That state would be set to true on the first update() on the watcher and reset back to false on the first next get(). If update() is called multiple times before get() is called, watcher continues to be in invalidated==true state.
Having that concept, I would suggest Vue.util.onInvalidate(callback) function which would register a callback for the current watcher context (Dep.target). That callback would be called when watcher gets invalidated (the first time  update() is called). If during onInvalidate is called on a watcher which is already invalidated, the callback would be called immediately.
Any callback is called only once. You have to re-register them by calling onInvalidate again if you want to get it called again.
Moreover, on watcher teardown, any pending onInvalidate callbacks would be called as well.
I have implemented this API inside this package, but I would prefer if it was added to the official API.

I think this is easier to just let the watcher callback return a function to be called on invalidation.

Can you elaborate? Not sure if I get your idea.

e.g.
this.$watch('foo', value => {
  const token = doSomethingAsync()
  return () => {
    // invalidated
    token.cancel()
  }
})

I see. So that would be an extension of API that returned callback can be used to invalidate and it would be called by the Watcher. I think this cold work, but it is very simplistic and hard to compose. If I have to cancel something deep inside doSomethingAsync I would have to propagate it all over to the top for be able to return. This makes it hard to compose reactive functions/data sources which I believe is one of the main advantages of this reactive approach.

One other problem with the approach of returning an "invalidation callback" is that it is really hard to extend this in the future. If you want to go this roue maybe returning {onInvalidate: () => token.cancel()} would be better.

I would avoid providing an overly complicated API just so that we can cater to cases where the majority of users probably won't ever encounter, especially when you've managed to implement it in userland. If you believe the API you are proposing does solve a common problem that the return callback API cannot deal with, I'd recommend writing a proper RFC for it.

I would avoid providing an overly complicated API just so that we can cater to cases where the majority of users probably won't ever encounter, especially when you've managed to implement it in userland.

I managed to implement it by monkey-patching Vue. I do not think this is very nice.

It's not - will probably be in the next minor


3.4.4 GLTF with separate textures and bin import inconsistency with GLB - tangents not imported

Godot version
3.4.4.stable
System information
Windows 10, GLES3, NVIDIA RTX 2060, driver 512.95
Issue description
Symptoms are very similar to #61685
To resolve file bloating due to embedded textures, I tried switching from exporting to .glb to .gltf with separate textures and .bin file in Blender.
The previous problem was from Godot auto-generating incorrect tangents on blend shapes, and was fixed by exporting tangents in the .glb file. Now that I replaced the .glb with separate textures and .gltf (.bin reimported to separate .mesh files), the same symptoms are back despite the export with tangents. This suggests that either:

Blender exported the .bin file without tangents even though it exports tangents to .glb correctly
Godot is not importing the tangents from the .bin correctly even though it imports tangents from .glb correctly

Picture of distorted tangents from blend shapes (side of a character's waist)

Steps to reproduce
Start with a 3D model with blend shapes in Blender, export to .gltf with separate texture and .bin file.
Import in Godot and adjust the blend shapes to see that progressively increasing blend shapes distorted the tangents more and more, leading to surface shading issues above.
Minimal reproduction project
No response

I am trying out these variations to narrow down the source of the problem:

export from Blender using .gltf, convert to .glb and import in Godot
export from Blender using .glb, convert to .gltf and import in Godot

The conversion will be done with an external tool (https://www.npmjs.com/package/gltf-import-export)

Both methods still lead to the same issues. For some reason, I can no longer replicate the fix I had for #61685

This seems to be a misreport - the underlying cause as discovered in https://github.com/godotengine/godot/issues/61685 was that the model was exported with non-deforming bones. Still unsure why extra non-deforming bones causes tangents on blend shapes to be distort, but the fix is to export only deforming bones.


[#12] Update component: Icon

Closes #12

Updates SVG icons to current bitstyles expected markup (focusable=false, aria-hidden=true etc)
Allows user to specify a pixel width & height, defaults to 16 to match the default icon size of 1em

Adds icon examples to the showcase file, which doesn’t yet render anything visible as the icon file is not available. The DOM is already correct though

This works except for the vital flaw that we’re waiting on the icons themselves — that’s dependent on the bitstyles repo, I’ll update here once that’s ready


policy: do not set policy to open door if none is provided

Currently hcsshim is setting an allow all open door policy if no security policy has been provided.
On the host side, the security policy is hashed and used as HostData when starting an SNP-uVM. However, guest receives the aforementioned "open_door" policy and computes hash over it. As a result, this has doesn't match the LaunchData which is returned by the attestation report and rightfully so, GCS rejects the security policy.
Fix this by not special handling empty security policy on the host side and let the guest decide what to do with it, thus ensuring that both host and guest compute the hash over the same thing.
Signed-off-by: Maksim An<EMAIL_ADDRESS>

This means that now we would have to set a default policy in one isnt provided in uvmboot, since the guest may default to something that isnt opendoor policy?

The guest should handle empty security policy and enforcer properly.


Booster does not work with drives formatted with 4K sectors

Forking discussion off this reddit thread https://www.reddit.com/r/archlinux/comments/reqxkn/comment/hohidou/?utm_source=share&utm_medium=web2x&context=3
A user has following GPT table
# gdisk -l /dev/nvme0n1
GPT fdisk (gdisk) version 1.0.8

Partition table scan:
  MBR: protective
  BSD: not present
  APM: not present
  GPT: present

Found valid GPT with protective MBR; using GPT.
Disk /dev/nvme0n1: 250051158 sectors, 953.9 GiB
Model: m.2 Smartbuy PS5012-2280 1024GB
Sector size (logical/physical): 4096/4096 bytes
Disk identifier (GUID): 4F509632-605D-4E61-AACA-E1B0951584D6
Partition table holds up to 128 entries
Main partition table begins at sector 2 and ends at sector 5
First usable sector is 6, last usable sector is 250051152
Partitions will be aligned on 256-sector boundaries
Total free space is 425 sectors (1.7 MiB)

Number  Start (sector)    End (sector)  Size       Code  Name
   1             256          131327   512.0 MiB   EF00  EFI system partition
   2          131328        16908543   64.0 GiB    8300  Linux filesystem
   3        16908544       174194943   600.0 GiB   8300  Linux filesystem
   4       174194944       241662544   257.4 GiB   8300  Linux filesystem
   5       241662720       250051152   32.0 GiB    8200  Linux swap

# blkid
/dev/nvme0n1p5: UUID="ca30eb5c-6d2b-435e-a04b-df49c8954ad8" TYPE="swap" PARTLABEL="Linux swap" PARTUUID="d053ca67-488c-4514-a89e-1f74bf56d7a1"
/dev/nvme0n1p3: UUID="062d43d4-eb60-431a-b7e7-50aef43126b7" BLOCK_SIZE="4096" TYPE="ext4" PARTLABEL="Linux filesystem" PARTUUID="e26e1e01-c708-475f-86dd-617de2d5ebe6"
/dev/nvme0n1p1: UUID="4A9C-B17A" BLOCK_SIZE="4096" TYPE="vfat" PARTLABEL="EFI system partition" PARTUUID="5301b67d-e872-468e-b487-469ad9bcc3c1"
/dev/nvme0n1p4: UUID="5482feff-4c59-45bf-bcaf-900eb55738a8" BLOCK_SIZE="4096" TYPE="ext4" PARTLABEL="Linux filesystem" PARTUUID="63dd8787-33ac-470e-9ae1-887578cf18bb"
/dev/nvme0n1p2: UUID="5e55a574-24c0-4f40-8255-c70a0f3d5dcd" BLOCK_SIZE="4096" TYPE="ext4" PARTLABEL="Linux filesystem" PARTUUID="50173cf6-3018-4924-8b91-a5e5d6e273ae"

For some reason it does not detect it as GPT.
cc @xshhhh

Here is the GPT detection logic https://github.com/anatol/booster/blob/f5424153991473595b2947808b30be0b80b21e47/init/blkinfo.go#L66

I'll duplicate here.
Partition table created as always:
# gdisk /dev/nvme0n1
- create new GPT table
- create 512M EF00 partition for fat32
- create 8300 root/home/etc partitions for ext4

> w

# mkfs.fat -F 32 /dev/nvme0n1p1
# mkfs.ext4 /dev/nvme0n1p2

This script works on all my UEFI machines.

So I have a unit test for GPT detection
https://github.com/anatol/booster/blob/f5424153991473595b2947808b30be0b80b21e47/init/blkinfo_test.go#L79
that creates a partition table as
gdisk assets/gpt <<< 'o
y
x
g
c26fcabe-8010-4bff-a066-8c73e76dbb32
m
n

+2M
cb3451b1-35b0-40f9-a0ea-8566ed05de6d
c
сектор1
x
c
53453a07-9bee-4397-a614-9e8fa3870a72
m
n

+2M
cb3451b1-35b0-40f9-a0ea-8566ed05de6d
c
2
hello
x
c
2
3ea18db9-691f-455e-a40d-20d426b1965f
a
2
60

w
y
'

$ gdisk -l gpt
GPT fdisk (gdisk) version 1.0.8

Partition table scan:
  MBR: protective
  BSD: not present
  APM: not present
  GPT: present

Found valid GPT with protective MBR; using GPT.
Disk gpt: 20480 sectors, 10.0 MiB
Sector size (logical): 512 bytes
Disk identifier (GUID): C26FCABE-8010-4BFF-A066-8C73E76DBB32
Partition table holds up to 128 entries
Main partition table begins at sector 2 and ends at sector 33
First usable sector is 34, last usable sector is 20446
Partitions will be aligned on 2048-sector boundaries
Total free space is 12221 sectors (6.0 MiB)

Number  Start (sector)    End (sector)  Size       Code  Name
   1            2048            6143   2.0 MiB     FFFF  сектор1
   2            6144           10239   2.0 MiB     FFFF  hello

The test/code works fine and detects the disk correctly as GPT.
The main difference I see is that your sector size is Sector size (logical/physical): 4096/4096 bytes while booster expects GPT sectors are 512 bytes. I'll need to test the code for sectors other than 512 bytes.

The rpi4 does not support booting on 4096 block devices, 512 only.

So GPT header information is located at the first sector. But the sector might be different at different systems. How does software expect to figure out the sector size? I am looking at https://wiki.osdev.org/GPT "Protective Master Boot Record" section but it does not tell what is the size of the partition.

gdisk tool uses following ioctl:

logical size ioctl(fd, BLKSSZGET, &blockSize)
physical size ioctl(fd, BLKPBSZGET, &physBlockSize)

and then operates with GPT sectors at logical size. It is what booster should do as well.

ah yes, I changed sector size to 4096b by nvme format

I was able to make a test that shows the problem with 4K logical sectors. And made a fix for this problem, it has been pushed to wip branch.
Please try branch wip and let me know if it fixes your problem @hxss

It works! And booster realy loads system 20% faster(from button press to cursor draw). Thank you for fast fix!
Unfortunately, booster does not really support the amdgpu module.

Thanks for the confirmation. The numbers actually say that booster is 8 times faster (initrd  stage 1350 ms vs 155 ms).
For the amd gpu please file a separate github issue and let's debug it there.


CO Filter - search by "Notes" field facet

Feature or enhancement
When I am in the CO Filter
Then I need to search in the "Notes" field.
Location
CO Filter
Screenshot, napkin sketch of interface, or conceptual description

Your role
Collection manager

Also needs With/out Notes facet.


helm install with multiple --set parameters (maybe missing documentation)

#values.yml
namespace: defaultnamespace
secrets:
   database: defaultdatabase
   password: defaultpassword

helm install mychart --set secrets.database=mydatabase --set secrets.password=mypassword
This will only change the value for password. database will still remain with "defaultdatabase"
This is the correct way to pass two values that lie under the same node in values.yaml
helm install chartsendis --set secrets.database=mydatabase,secrets.password=mypassword
What i found out later. Calling
helm install chartsendis --set secrets.database=mydatabase,secrets.password=mypassword --set namespace=anothernamespace
doesn't work either. In this case only "namespace" is set to "anothernamespace". both values from "secrets" remain in their default values.
If this happends by design, i maybe just did not find the documentation for this. If it is missing i could help you to make it more clear in the documentation.
Greetings,
Chucky

I learned that i need to write it like this:
helm install mychart --set secrets.database=mydatabase,secrets.password=mypassword


Error log home assistant 2024.12.3 with integration 2.3.1 maybe with recent fix #79

General information
Home Assistant
**Version:**2024.12.3
Installation method (according to instructions):
[ ] Operating System
[ ] Linux VM
[x] Container
[ ] Supervised
[ ] Core
Integration

Installation method:
[x] HACS
[ ] manual from release
[ ] manual from git
Integration version: 2.3.1
Root topic:
Application settings

topic:
[x] I can see MQTT messages from application at MQTT-server
How it works now?
 It works, but there is a ERROR in the log.
What do you expect?

No log ERROR
Steps to reproduce

Use Home assistant 2024.12.3
Via HACS install the integration 2.3.1
...

Debug log
ERROR (MainThread) [homeassistant.components.sensor] Error while setting up sleep_as_android platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 366, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/config/custom_components/sleep_as_android/sensor.py", line 50, in async_setup_entry
    await instance.subscribe_root_topic(async_add_entities)
  File "/config/custom_components/sleep_as_android/__init__.py", line 314, in subscribe_root_topic
    self._subscription_state = await subscribe_2022_03(
                               ^^^^^^^^^^^^^^^^^^^^^^^^
    ...<3 lines>...
    )
    ^
  File "/config/custom_components/sleep_as_android/__init__.py", line 278, in subscribe_2022_03
    result = subscription.async_prepare_subscribe_topics(
        hass=_hass,
        new_state=_state,
        topics=_topic,
    )
TypeError: async_prepare_subscribe_topics() got an unexpected keyword argument 'new_state'. Did you mean 'sub_state'?

Additional information

I'm not able to understand if it is related to #79

Left a note on #79 as well, but I just confirmed that changing the second if at custom_components/sleep_as_android/init.py at line 313 to elif seems to resolve the issue.
i.e.:
elif self._ha_version >= AwesomeVersion("2022.3.0"):

Left a note on #79 as well, but I just confirmed that changing the second if at custom_components/sleep_as_android/init.py at line 313 to elif seems to resolve the issue. i.e.: elif self._ha_version >= AwesomeVersion("2022.3.0"):

Thanks it works


Settings editor search results aren't sorted well

Ref https://github.com/microsoft/vscode/issues/187949#issuecomment-1636355066

Search test in the Settings editor in the User settings.
:bug: "Testing: Automatically Open Peak View" appears after "TypeScript > Preferences: Quote Style"? The "Testing" settings are not all grouped together, which could make users believe that there aren't as many Testing settings available as there really are.

Confirmed. The largest issue to me is that the setting typescript.format.insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces shows up as a search result.
I notice that some other test-related settings interject themselves between the Testing settings, but that happens because they contain whole-word matches for the word "test" elsewhere, such as in the description. CC @333fred

@rzhao271 I would like to work on this bug.

Hi @balaji-sivasakthi, thanks for offering to work on the issue.
However, I've a PR up (#190453) that interferes with the search result code. After that PR is merged, I plan to address this issue myself.
I recommend looking through the help wanted issues.

\closedWith 2db3132


Missing File and Parsing Error

Describe the bug
Setup the program Brain Simulator then tried running the program with the following result. A window saying, "Brain Simulator encountered an error--
Application: Brain Simulator Version 1.6.8. I see it also lists the time and date as 1/9/2000 12:00:00 AM
Screenshots

Desktop (please complete the following information):
-OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.19044 N/A Build 19044
Add any other context about the problem here.

I’m guessing that you have compiled the code yourself (rather than the binary download).

The order of building may have a bug.  Try recompiling.
Be sure that the build target is set to x64.

Let us know how it goes

had the same error, i've downloaded the installer


[ideal-nav] Fix iPad navigation

Details

We used getIsSmallScreenWidth to determine which type of layout is currently displayed in some navigation logic. It was incorrect assumption on the iPad because even if the screen width is beyond the threshold, the iPad always displays narrow layout.
With the new getIsNarrowLayout function everything should work the exactly the same on iPhones and iPads.
P.S. Since the changes apply to the iPad only, I recorded videos exclusively for this platform.
Fixed Issues

$ https://github.com/Expensify/App/issues/35753
$ https://github.com/Expensify/App/issues/35755
$ https://github.com/Expensify/App/issues/35752
$ https://github.com/Expensify/App/issues/35758
$ https://github.com/Expensify/App/issues/35759
$ https://github.com/Expensify/App/issues/35764
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

Test 1

Open app
Make sure you are on the home page
Tap on Profile icon on top right corner of the screen
Tap on back button
You should be on the home page again

Test 2

Open app
Tap on "Expensify" icon on top left corner
Tap on plus button
You should be on the workspace settings page

Open app
Tap on settings tab in bottom
Verify the user is in the Expensify All Settings page (You can see the Overview/ subscriptions etc)

Open app on iPad device
Tap on Expensify icon on top left corner
Tap on any listed workspace
Verify the user is navigated to the settings of the workspace

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/67908363/540e3bf2-40a0-46a8-b095-d1f377e75103

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mountiny I can review this for https://github.com/Expensify/App/issues/35758.

@situchan @mananjadhav please do not review this PR as-is.

Chatted with @mountiny, and I'm willing to let this go through as a temporary measure, but we want to follow-up soon to remove this and address the root cause(s) to get wide layouts to work on native and remove any code that assumes that native devices must be a narrow layout.
I stand by what I said above – that this PR codifies an unsafe assumption. As long as we acknowledge that and work to unwind this assumption, I'll remove my request for changes.
According to @adamgrzybowski here, the main reasons why wide layouts don't currently work on native is due to our uses of position: fixed and overflow: visible.
overflow: visible is the default for all views in React Native, so that seems like it should be solvable. position: fixed is more tricky – I'd suggest that we first look for pure RN solutions that don't require position: fixed, but failing that we could consider sponsoring someone to build support for position: fixed in Yoga.

I'm going to group these issues into a tracking issue and add it to the wave8 project.

The tracking issue if here https://github.com/Expensify/App/issues/35854 thanks Rory!

@situchan please feel free to resume the review

@situchan whats your ETA on this PR?

2 hrs

Tested all 6 issues.
Remaining bugs that were not fixed yet:

#35759

https://github.com/Expensify/App/assets/108292595/fffcc0c1-d987-42e7-b152-cae242c92d04

Thanks for catching this bug @situchan! It should be fixed now.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/108292595/67b667af-c4eb-4b6e-ab5f-c5068f3ef8ab

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Test 1

Open app
Make sure you are on the home page

This test case is not correct yet until https://github.com/Expensify/App/issues/35927 is done. Please fix.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.40-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌


Export email templates

fyi, #162 (https://github.com/heroku/force/commit/f1aa111ae0c2f8d9d8df9aa8f7b56e37e95853ed) contained support for additional metadata types that are contained within folders.

Hi @cwarden, I updated the PR to cover other metadata types included in folders.


unable to initialize RocksDB engine: IO error: While lock file: /opt/arangodb/data/engine-rocksdb/LOCK: Resource temporarily unavailable; Maybe your filesystem doesn't provide required features? (Cifs? NFS?)

CurrentBehavior
unable to initialize RocksDB engine: IO error: While lock file: /opt/arangodb/data/engine-rocksdb/LOCK: Resource temporarily unavailable; Maybe your filesystem doesn't provide required features? (Cifs? NFS?)

if you inspect your arangodb logfile, you will probably find several processes writing to it at the same time.
the PID of the processes can be observed in the square brackets [1234] - the one trying to write it and failing gave you above error.


Port pregel fixes

Acceptance Checklist
Scope & Purpose
Fix several issues related to the pregel module and the PREGEL_RESULT AQL function

[x] Bug-Fix for a dev branch

Related Information
no ticket or customer impacted
Testing & Verification
This change added tests and can be verified as follows:

[x] Added Regression Tests (Only for bug-fixes) in shell-pregel.js

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/6041/
Documentation
documentation was adjusted
https://github.com/arangodb/docs/blob/master/3.4/graphs-pregel.md

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/6041/EDITION=enterprise,STORAGE_ENGINE=mmfiles,TEST_SUITE=single,limit=linux&&test/artifact/testfailures.txt
Test failed with
* Test "shell_server"
    [FAILED]  tests/js/server/shell/shell-pregel.js

      "testPageRankAQLResult" failed: at assertion #74: assertEqual: (0) is not equal to (11)
(Error
    at assertEqual (/work/ArangoDB/js/common/modules/jsunity/jsunity.js:109:19)
    at Object.testPageRankAQLResult (tests/js/server/shell/shell-pregel.js:209:11)
    at Object.run (/work/ArangoDB/js/common/modules/jsunity/jsunity.js:532:23)
    at Object.Run [as run] (/work/ArangoDB/js/common/modules/jsunity.js:195:24)
    at tests/js/server/shell/shell-pregel.js:371:9
    at tests/js/server/shell/shell-pregel.js:377:3
    at RunTest (/work/ArangoDB/js/common/modules/jsunity.js:275:12)
    at source (eval at <anonymous> (unknown source), <anonymous>:4:52))

   Suites failed: 1 Tests Failed: 3

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/6049/


Add VA Internal CA Certs

This is in preparation for setting up new certs on the vets-api ELBs which are signed by the VA's internal CA certs rather than using the public cert there. This PR adds these VA CA certs to the saml-proxy deployment's docker containers so that it will trust SSL connections to internal VA https sites (including, before long, api.va.gov, dev-api.va.gov, staging-api.va.gov, etc)
Before you ask, I was unable to figure out a good way to put all the certs in one location and pull them into each docker container, because the containers can only copy in files within their context. Unfortunately, just putting all the certs into each container's directory seems like the best and most straightforward way to get this done.

I'm realizing now that perhaps the claims_v0 service won't trigger those alerts? If that's the case, then go ahead and dismiss my review and merge!


[wip] Refactor

more reponsibility in code
image upload validated
[x] added max file size setting (not yet in admin)
allowed other filesystems by using the native IoC bound filesystem
wrote an imgur adapter
[x] adapter should mutate the file_url attribute or create their own object based on the adapter (so we can delete files too later on)

this requires translations

I think it's better to move away from using the Filesystem adapter interfacing for this. We should probably create our own interface of which one adapter will use the Filesystem.

Misassumption, needs composer installer ^0.3.0 not flarum/core particularly


Create user serializer

Created user serializer, along with user view set and urls.
Returns user(s) without passwords. Currently, users created without a password are set an unusable password. We want to be able to then send that user a link to set their password. Admins are able to edit details of other admins except for password.
NEXT STEPS
finish tests
create separate flow to handle passwords (endpoint for user to set password via email, endpoint for user to change password given current password)
LoginView and UserView to return serialized user object (call user serializer on user object) or return a 401 if no one is logged in
QUESTIONS
How does LogoutView need to change?

Looks great so far!  I'm curious about the decision to return 401 instead of django.contrib.auth.models.AnonymousUser.  That will require a few tweaks to the front end if you want to return 401 instead, but they're easily done.

I think having UserView (/api/user) return an AnonymousUser if not logged in is a good idea; probably LogoutView as well.


Replace zoom links with room numbers

Zoom links have been outdated for over a year and room numbers would be a bit more useful (albeit not by much).

This replaces a field in the firestore db so additional work might have to be done there, though it seemed to add the field automatically in the emulator.

@MysticalApple I'd like to change some things but can't commit directly to this PR, is it ok if I close this and make my own PR with similar changes?

Shouldn't the "Allow edits by maintainers" option not allow you to commit to this PR? Feel free to go ahead and close it if it's easier though.

Closed in https://github.com/GunnWATT/watt/commit/80ab9106589277a7d21b2fde997f1554f8a2c255.

Shouldn't the "Allow edits by maintainers" option not allow you to commit to this PR?
I think I was having network connectivity issues that prevented me from cloning your repository. Should be good now though.


Switching IME language mid-input keeps non-committed text visible on Wayland

Tested versions
v4.3.1.rc.custom_build [ff9bc0422]
System information
Godot v4.3.1.rc (ff9bc0422) - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Wed Aug  7 16:19:28 UTC 2024 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XT (RADV NAVI31) - AMD Ryzen 9 7900X 12-Core Processor (24 Threads)
Issue description
On the Wayland version of the editor, on KDE with fcitx5 as IME, I can switch between French and Japanese. When typing Japanese, I have to commit text when converting kanji for instance; if I go back to French with non-committed text, this text will follow the caret (see video below).
https://github.com/user-attachments/assets/75878b5c-4884-4618-bd7a-d46ee6438f0a
On X11, non-committed text is deleted.
Steps to reproduce
Write text in multiple languages, with at least one requiring committing text (like Japanese, probably Chinese as well, I don't know about other languages), and switch between languages with some uncommitted text.
Reminder: the issue occurs on KDE, Wayland editor with fcitx5 IME.
Minimal reproduction project (MRP)
N/A

I don't know is the same issue,
but using fcitx to input chinese in TextEdit (linux mint 22 / godot 4.3 stable)
it will drain some character randomly.
and no keyboard event will triggered.
It both effects the game and editor.


⚠ Roblox TextFilter Api has degraded performance

In 368b60d, Roblox TextFilter Api (https://textfilter.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 6478 ms

Resolved: Roblox TextFilter Api performance has improved in 3834703.


DynamicDataSource caching causes problems when running tests in parallel.

After 2.2.4, as long as the values in data source are serializable, every row for the specific test case is considered a separate test case. If our assumptions break parallel test runs that's a regression. Is it possible for you to share a quick repro with us?

@Haplois I will share a complete project when I have more time, but in general, consider a test case like this:
[
  DataTestMethod,
  DynamicData(dynamicDataSourceName: nameof(GetData), DynamicDataSourceType.Method)
]
public async Task Create_Tasks_Requests_From_Invalid_Tasks_Definitions_Should_Return_BadRequest_Errors(Events.APIGatewayProxyRequest request, Requests.CreateTaskCommand.Arguments arguments)
{
    // test code
}

with GetData similar to this:
public static IEnumerable<object[]> GetData() =>
 new [] {
    new [] object {
         // initialize pair of objects
    },
    new [] object {
         // initialize pair of objects
    },
 }

If I run such test cases in parallel (method level parallelism)  then I see all kinds of exception suggesting that the the test framework attempts to pull the enumerable on different threads. I have plenty of data sources structured like this:
public static IEnumerable<object[]> GetData()
{
    yield new InputData {
       // ...
    };

    yield new InputData {
       // ...
    };

    // etc.
}

These obviously can't be pulled in parallel either.
Originally posted by @paul-michalik in https://github.com/microsoft/testfx/issues/871#issuecomment-874630277
AB#1408168

This class needs to be able work concurrently.
https://github.com/microsoft/testfx/blob/main/src/Adapter/MSTest.CoreAdapter/Helpers/DataSerializationHelper.cs#L16

@Haplois - just to add to this. I intermittently get this exception with 2.2.5:
  Message:
    Object reference not set to an instance of an object.

  Stack Trace:
    <>c__DisplayClass4_0.<GetSerializer>b__0(KeyValuePair`2 i)
    Enumerable.SingleOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
    DataSerializationHelper.GetSerializer(String typeName)
    DataSerializationHelper.Deserialize(String[] serializedData)
    TestMethodRunner.RunTestMethod()
    TestMethodRunner.Execute()

Changing the SerializerCache to a ConcurrentDictionary should fix this.

Fixed by #998


mathematical derivation of log likelihood and weight prior corresponding to code

@NickGeneva Thank you for sharing the code.
I am still very new to BNNs. When trying to understand the loss function, I could not match these code with the equations in the paper.

For the likelihood, the code is
https://github.com/cics-nd/rans-uncertainty/blob/7d99fd906a1d73526ad041e6a9d705355f1c57c2/invar-nn/nn/foamSVGD.py#L138-L144
The mathematics should be (my understanding)

For the weight prior, the code is
https://github.com/cics-nd/rans-uncertainty/blob/7d99fd906a1d73526ad041e6a9d705355f1c57c2/invar-nn/nn/foamSVGD.py#L146-L151
Haven't figured out why Eq.(17) should be calculated in this way ?
Could you do a more specific explanation or mathematical derivation to help understand the above code, please ?
Best,

Regarding the likelihood, you have made the assumption when taking the log that you can get rid of the normalizing factor (you call it a constant here). This is not correct, since the variance (sigma) is not constant. Thus you must keep this factor in the log likelihood which will result in that additional term.
Regarding the prior, as explicitly stated in the paper following equation 17: "The resulting prior has the density of a narrow Student’s T -distribution centered at zero." Take the log of a Student T distribution and you will arrive at what is written in the code. This is even commented in the code as well with a reference.
Hope this clears things up.

Regarding the likelihood, you have made the assumption when taking the log that you can get rid of the normalizing factor (you call it a constant here). This is not correct, since the variance (sigma) is not constant. Thus you must keep this factor in the log likelihood which will result in that additional term.
Regarding the prior, as explicitly stated in the paper following equation 17: "The resulting prior has the density of a narrow Student’s T -distribution centered at zero." Take the log of a Student T distribution and you will arrive at what is written in the code. This is even commented in the code as well with a reference.
Hope this clears things up.

Oh, thank you.

Oh, thank you.


Fixed crash when opening settings on iPad

Observed behavior
Tapping the settings button is crashing in all cases where the horizontal size class is Regular (all iPads, and iPhone 6+ in landscape).
Expected behavior
Obviously, shouldn’t crash.
Notes
Maybe a nicer fix can be done that preserves the animation, but I couldn’t immediately find out what was going on. Stack trace was all about UIKit internals and feels like this kind of presentation is just pooping on itself in this situation. So, disabled the presentation animation until the root cause of the crash is found, so that at least the app keeps working and you can change settings in these cases.

Awesome. I will take a look and merge in the next couple of days!

:+1: thanks!


replaced Cantabular healthcheck with a placeholder

What

Replaced Cantabular healthcheck Checker with a placeholder.
This needs to be done in order to release this service to production, where the Cantabular server is not running yet. Once it is running, we can undo this change and use the real Checker again.

How to review

Make sure code change makes sense
Make sure unit tests pass
(info) tested the/health endpoint locally and validated that a successful check with the placeholder text appears.

Who can review
anyone

closing because this is done as part of release 0.3.0


[Feature request] Context menu commands

Please add ability of running commands through context menu:

Then, in dropdown menu, should be visible only those commands that have property:
"ContextMenuCommand": true
also within settings should be acceceble built in property Current/ClickedFilePath and CurrentFolderPath. Say if I click on folder temp or temp/index.html the value of the CurrentFolderPath should be temp folder's path.
If you click on temp/index.html the value of Current/ClickedFilePath should be index.html file's path. Then I will use it into commands.
Context menu commands should also be grouped.

I think context menu of the explorer is not necessary.
You can run commando in opened file in editor now, so the difference of link to execution is just left click or right click.
If you have any more effective use case of context menu, please let me know.

If you have any more effective use case of context menu, please let me know.

i.e. creating Angular components and services. Angular Schematics has implemented it, but it is only for Angular. your extention could be for every frameworks / languages (React, .Net, ets...)

hmmm, I'm not familiar with Angular, but I think this is just make a new file to a selected path, isn't it?
Also, this interface requires dialog interface. As I said in #28, I reluctantto hierachical commands.
So, this feature will not be useful as you think.


Memory leak on yr_rules_scan_proc

YARA Version
Platform

3.9.0, 3.10.0
Ubuntu 16.04

When running processes scan using yr_rules_scan_proc function, a struct doesn't get freed if it can not attach to the process.
Simple POC:
#include <stdio.h>
#include <yara.h>

#define MAX_PIDS 32568

int main(int argc, char **argv)
{

   if (yr_initialize())
   {
      perror("Error initializing yara library\n");
      exit(1);
   }

   YR_COMPILER *compiler = NULL;

   if (yr_compiler_create(&compiler) != ERROR_SUCCESS)
   {
      perror("Error initializing yara compiler\n");
      exit(1);
   }

   YR_RULES *rules = NULL;

   if (yr_compiler_add_string(compiler, "rule dummy { condition: true }", NULL) != 0)
   {
      perror("Error on yr_compiler_add_string\n");
      exit(1);
   }

   if (yr_compiler_get_rules(compiler, &rules) != ERROR_SUCCESS)
   {
      perror("Error on yr_compiler_get_rules\n");
      exit(1);
   }

   printf("Yara initialized\n");

   int z;
   for (z = 0; z < MAX_PIDS; z++) {
      yr_rules_scan_proc(rules,z,0,NULL,NULL,0);
   }

   printf("Yara finalized\n");

   yr_compiler_destroy(compiler);

   yr_finalize();

   return 0;
}

Valgrind output:
==11936==
==11936== HEAP SUMMARY:
==11936==     in use at exit: 1,785,936 bytes in 32,393 blocks
==11936==   total heap usage: 103,273 allocs, 70,880 frees, 22,303,851 bytes allocated
==11936==
==11936== 56 bytes in 1 blocks are possibly lost in loss record 2 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E70454: yr_process_open_iterator (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E79AAD: yr_rules_scan_proc (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400AD5: main (main2.c:41)
==11936==
==11936== 13,472 bytes in 1 blocks are possibly lost in loss record 4 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E58D23: yr_arena_duplicate (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E5DEF6: yr_compiler_get_rules (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400A85: main (main2.c:31)
==11936==
==11936== 16,808 (112 direct, 16,696 indirect) bytes in 1 blocks are definitely lost in loss record 6 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E5DEDA: yr_compiler_get_rules (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400A85: main (main2.c:31)
==11936==
==11936== 1,755,600 bytes in 31,350 blocks are definitely lost in loss record 7 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E70454: yr_process_open_iterator (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E79AAD: yr_rules_scan_proc (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400AD5: main (main2.c:41)
==11936==
==11936== LEAK SUMMARY:
==11936==    definitely lost: 1,755,712 bytes in 31,351 blocks
==11936==    indirectly lost: 16,696 bytes in 1,040 blocks
==11936==      possibly lost: 13,528 bytes in 2 blocks
==11936==    still reachable: 0 bytes in 0 blocks
==11936==         suppressed: 0 bytes in 0 blocks
==11936==
==11936== For counts of detected and suppressed errors, rerun with: -v
==11936== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 0 from 0)

Seems like this function doesn't free the iterator struct if the result fails:
https://github.com/VirusTotal/yara/blob/v3.10.0/libyara/rules.c#L361
Thank you!

You need to call yr_rules_destroy for freeing the rules after the loop.
That's probably the cause of the leak, the iterator struct is allocated in
the stack and can't be leaked.
El mié., 29 may. 2019 15:22, Jose Rafael Cenit<EMAIL_ADDRESS>escribió:

YARA Version Platform
3.9.0, 3.10.0 Ubuntu 16.04
When running processes scan using yr_rules_scan_proc function, a struct
doesn't get freed if it can not attach to the process.
Simple POC:
#include <stdio.h>
#include <yara.h>
#define MAX_PIDS 32768
int main(int argc, char **argv)
{
if (yr_initialize())
{
perror("Error initializing yara library\n");
exit(1);
}
YR_COMPILER *compiler = NULL;
if (yr_compiler_create(&compiler) != ERROR_SUCCESS)
{
perror("Error initializing yara compiler\n");
exit(1);
}
YR_RULES *rules = NULL;
if (yr_compiler_add_string(compiler, "rule dummy { condition: true }", NULL) != 0)
{
perror("Error on yr_compiler_add_string\n");
exit(1);
}
if (yr_compiler_get_rules(compiler, &rules) != ERROR_SUCCESS)
{
perror("Error on yr_compiler_get_rules\n");
exit(1);
}
printf("Yara initialized\n");
int z;
for (z = 0; z < MAX_PIDS; z++) {
yr_rules_scan_proc(rules,z,0,NULL,NULL,0);
}
printf("Yara finalized\n");
yr_compiler_destroy(compiler);
yr_finalize();
return 0;
}
Valgrind output:
==11936==
==11936== HEAP SUMMARY:
==11936==     in use at exit: 1,785,936 bytes in 32,393 blocks
==11936==   total heap usage: 103,273 allocs, 70,880 frees, 22,303,851 bytes allocated
==11936==
==11936== 56 bytes in 1 blocks are possibly lost in loss record 2 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E70454: yr_process_open_iterator (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E79AAD: yr_rules_scan_proc (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400AD5: main (main2.c:41)
==11936==
==11936== 13,472 bytes in 1 blocks are possibly lost in loss record 4 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E58D23: yr_arena_duplicate (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E5DEF6: yr_compiler_get_rules (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400A85: main (main2.c:31)
==11936==
==11936== 16,808 (112 direct, 16,696 indirect) bytes in 1 blocks are definitely lost in loss record 6 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E5DEDA: yr_compiler_get_rules (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400A85: main (main2.c:31)
==11936==
==11936== 1,755,600 bytes in 31,350 blocks are definitely lost in loss record 7 of 7
==11936==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==11936==    by 0x4E70454: yr_process_open_iterator (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x4E79AAD: yr_rules_scan_proc (in /usr/local/lib/libyara.so.3.9.0)
==11936==    by 0x400AD5: main (main2.c:41)
==11936==
==11936== LEAK SUMMARY:
==11936==    definitely lost: 1,755,712 bytes in 31,351 blocks
==11936==    indirectly lost: 16,696 bytes in 1,040 blocks
==11936==      possibly lost: 13,528 bytes in 2 blocks
==11936==    still reachable: 0 bytes in 0 blocks
==11936==         suppressed: 0 bytes in 0 blocks
==11936==
==11936== For counts of detected and suppressed errors, rerun with: -v
==11936== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 0 from 0)
Seems like this function doesn't free the iterator struct if the result
fails:
https://github.com/VirusTotal/yara/blob/v3.10.0/libyara/rules.c#L361
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/VirusTotal/yara/issues/1070?email_source=notifications&email_token=AABMVGOW5V2F5AEGZ4IMWGTPXZ7RDA5CNFSM4HQMXOMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWPPVIA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABMVGP65VMRCSZ633EU3PLPXZ7RDANCNFSM4HQMXOMA
.

Hi @plusvic ,
the memory leak is still present even after calling yr_rules_destroy. Any thoughts on this?
Regards.

You're right, there was a memory leak when _yr_process_attach failed. The issue should be solved with #1075. Can you verify?

Hi @plusvic ,
the memory leak is fixed, thank you a lot!.
Do you have an ETA for including this on the https://github.com/VirusTotal/yara/tree/v3.10.0 tag?
Regards.

It has been merged in master and will be included in the next release, but I don't have an ETA for it.


Pass exit code through for --exec option

@benkehoe does this make sense to you, or would you prefer the exit code to not propagate as part of the os.system call?

This seems like a good idea, I just haven't gotten a chance to deal with it yet

Can you make a CONTRIBUTORS.md in the root dir like this one and put us both on it? https://raw.githubusercontent.com/benkehoe/aws-sso-util/master/CONTRIBUTORS.md

Surely... @benkehoe addressed I believe

Shipped in v0.15


Installing the Sidecar docs improvements

All the samples work fine, just a few clarifications that might be useful:

The example in Customizing injection doesn't work out-of-the-box. Should document that the istio-secret has to be created and annotate the example pod manifest with what each section does. Make it so that users can copy-paste the config and have it run (for example, add sleep to app container).
Should document pre-reqs for following the doc (installing control plane, etc).
Custom templates section could have user deploy a pod with the custom template and verify the environment variable was injected (both to make it more doc-testable and have users follow along).

Closing, meant to open in istio.io repo.


fix: UI fixes

Description

fixes https://github.com/aeternity/aescan/issues/910
fixes https://github.com/aeternity/aescan/issues/854

improved github output
replace --- for 'N/A'
remove duplicate ae logo
fetchTokenHoldersCount optimization
floor line chart to minimum value of 0 so -1 is not visible on Y axis
header STATE CHANNELS -> LATEST ACTIVE STATE CHANNELS
make Tabs semi transparent
highlight table row on hover

Demo

Checklist:

[x] Measure performance after removing booster

Small bugs:

question mark is shifted:

https://github.com/user-attachments/assets/8b343bbb-4f04-4d96-ab86-f466453c5f19

Line on chart is cropped:

https://github.com/user-attachments/assets/1989e4b6-a10b-4724-a4a7-c4b7104ce895

Double AE labels and data is shifted:

https://github.com/user-attachments/assets/6f7a86d5-e316-4688-97c7-cd5b8c651698

@Liubov-crypto 1,3 fixed
2 - Good catch! That unfortunately how the chart prints. I would say it's good enough

I found that we show more symbols after full stop, for example here: https://pr-934-aescan.stg.service.aepps.com/state-channels/ch_2VfzXmCRZepB3ichPf3WTt2uf8zMqsyY3cZWg8k1vt3xcu8L8V and in this case some data is showing in second row. Are this acceptable?
https://github.com/user-attachments/assets/faf7eed7-30a5-4a64-bf37-569e04afd018
The rest is fixed, LGTM

@Liubov-crypto yeah that was wrong. I overlooked that, thanks. It's fixed now. Can you check it again, please?

all good just need to open it in new PR before the merge to perform some checks. It's failing here


Finish out MediaVault entity pages (media, author)

Author page is quite complete, aside from any additions to the archive item entity box.
Media page doesn't yet exist. We should discuss what it needs to have.

For the media detail page we should have the following:

Stylized description of the claim and the fact check
MediaReview details (type of misinformation, etc)
Download MediaReview w/ ClaimReview

This isn't much, and really doesn't need to be too nice, remember this is for researchers so they'd prefer more data over style.

@cguess I opened #365 and #481 for those items.


Think through if there is a way to create priority follows?

In Overcast, you can create Priority Podcasts that when new podcasts from a specific feed come in, they all come in at the top of the feed, before any non-priority ones are listed.
I don't know if this is even possible in Indigenous and/or Microsub. But it seems like an interesting concept. It's kind of like the idea of Facebook's algorithm, except it is controlled by the user. Which is what the IndieWeb is all about.

One way to do this could be around using algorithm's such as the discussion from this session: https://indieweb.org/2018/indiealgorithm


v0.46.0 broke localstack config

What happened?
Using provider version v0.45.0 I can successfully test my compositions and managed resources against localstack, which locally simulates the aws api. Starting with provider version v0.46.0, I cannot. The error is also present in v0.47.1, and when I run against the current tip of main. When I revert 7a61c51f89e7a38c640250b68583765f030b6bda it works again.
All resources which use the no-fork reconciler get a Synced: False condition
    - lastTransitionTime: "2024-01-04T07:21:43Z"
      message: "observe failed: failed to observe the resource: [{0 reading IAM Role
        (sample-role): InvalidClientTokenId: The security token included in the request
        is invalid.\n\tstatus code: 403, request id: 201ef32d-6195-48ff-812a-317c6ec29b76
        \ []}]"
      reason: ReconcileError
      status: "False"
      type: Synced

The resources which still use the CLI based reconciler work fine.
Provider logs:
2024-01-04T07:23:43Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/iam.aws.upbound.io/v1beta1, kind=role", "request": {"name":"sample-role"}}
2024-01-04T07:23:43Z	DEBUG	provider-aws	Connecting to the service provider	{"uid": "afa9d5be-cd90-4641-8e0e-ef8bfac16423", "name": "sample-role", "gvk": "iam.aws.upbound.io/v1beta1, Kind=Role"}
2024-01-04T07:23:43Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/iam.aws.upbound.io/v1beta1, kind=policy", "request": {"name":"sample-user-policy"}}
2024/01/04 07:23:43 [WARN] AWS account ID not found for provider. See https://www.terraform.io/docs/providers/aws/index.html#skip_requesting_account_id for implications.
2024-01-04T07:23:43Z	DEBUG	provider-aws	Observing the external resource	{"uid": "afa9d5be-cd90-4641-8e0e-ef8bfac16423", "name": "sample-role", "gvk": "iam.aws.upbound.io/v1beta1, Kind=Role"}
2024/01/04 07:23:43 [DEBUG] Waiting for state to become: [success]
2024-01-04T07:23:43Z	DEBUG	provider-aws	Connecting to the service provider	{"uid": "f330b9b3-09c5-4b5e-afab-a37af7c6fc1f", "name": "sample-user-policy", "gvk": "iam.aws.upbound.io/v1beta1, Kind=Policy"}
2024/01/04 07:23:43 [WARN] AWS account ID not found for provider. See https://www.terraform.io/docs/providers/aws/index.html#skip_requesting_account_id for implications.
2024-01-04T07:23:43Z	DEBUG	provider-aws	Observing the external resource	{"uid": "f330b9b3-09c5-4b5e-afab-a37af7c6fc1f", "name": "sample-user-policy", "gvk": "iam.aws.upbound.io/v1beta1, Kind=Policy"}
2024/01/04 07:23:43 [DEBUG] Waiting for state to become: [success]
2024-01-04T07:23:44Z	DEBUG	provider-aws	Cannot observe external resource	{"controller": "managed/iam.aws.upbound.io/v1beta1, kind=role", "request": {"name":"sample-role"}, "uid": "afa9d5be-cd90-4641-8e0e-ef8bfac16423", "version": "1290", "external-name": "sample-role", "error": "failed to observe the resource: [{0 reading IAM Role (sample-role): InvalidClientTokenId: The security token included in the request is invalid.\n\tstatus code: 403, request id: 8bc110b9-c62f-4e25-919e-d99f2d474eec  []}]", "errorVerbose": "failed to observe the resource: [{0 reading IAM Role (sample-role): InvalidClientTokenId: The security token included in the request is invalid.\n\tstatus code: 403, request id: 8bc110b9-c62f-4e25-919e-d99f2d474eec  []}]\ngithub.com/crossplane/upjet/pkg/controller.(*noForkExternal).Observe\n\tgithub.com/crossplane/upjet@v1.1.0-rc.0.0.20231227120826-4cb45f9104ac/pkg/controller/external_nofork.go:475\ngithub.com/crossplane/upjet/pkg/controller.(*noForkAsyncExternal).Observe\n\tgithub.com/crossplane/upjet@v1.1.0-rc.0.0.20231227120826-4cb45f9104ac/pkg/controller/external_async_nofork.go:117\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v1.15.0-rc.0.0.20231215091746-d23a82b3a2f5/pkg/reconciler/managed/reconciler.go:903\ngithub.com/crossplane/crossplane-runtime/pkg/ratelimiter.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v1.15.0-rc.0.0.20231215091746-d23a82b3a2f5/pkg/ratelimiter/reconciler.go:54\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227\nruntime.goexit\n\truntime/asm_amd64.s:1650"}
2024-01-04T07:23:44Z	DEBUG	events	failed to observe the resource: [{0 reading IAM Role (sample-role): InvalidClientTokenId: The security token included in the request is invalid.
	status code: 403, request id: 8bc110b9-c62f-4e25-919e-d99f2d474eec  []}]	{"type": "Warning", "object": {"kind":"Role","name":"sample-role","uid":"afa9d5be-cd90-4641-8e0e-ef8bfac16423","apiVersion":"iam.aws.upbound.io/v1beta1","resourceVersion":"1290"}, "reason": "CannotObserveExternalResource"}
2024-01-04T07:23:44Z	DEBUG	provider-aws	Cannot observe external resource	{"controller": "managed/iam.aws.upbound.io/v1beta1, kind=policy", "request": {"name":"sample-user-policy"}, "uid": "f330b9b3-09c5-4b5e-afab-a37af7c6fc1f", "version": "1293", "external-name": "sample-user-policy", "error": "failed to observe the resource: [{0 reading IAM Policy (arn:aws:iam::000000000:policy/sample-user-policy): InvalidClientTokenId: The security token included in the request is invalid.\n\tstatus code: 403, request id: 0fe96847-5a23-4bf0-830e-2dee863945a2  []}]", "errorVerbose": "failed to observe the resource: [{0 reading IAM Policy (arn:aws:iam::000000000:policy/sample-user-policy): InvalidClientTokenId: The security token included in the request is invalid.\n\tstatus code: 403, request id: 0fe96847-5a23-4bf0-830e-2dee863945a2  []}]\ngithub.com/crossplane/upjet/pkg/controller.(*noForkExternal).Observe\n\tgithub.com/crossplane/upjet@v1.1.0-rc.0.0.20231227120826-4cb45f9104ac/pkg/controller/external_nofork.go:475\ngithub.com/crossplane/upjet/pkg/controller.(*noForkAsyncExternal).Observe\n\tgithub.com/crossplane/upjet@v1.1.0-rc.0.0.20231227120826-4cb45f9104ac/pkg/controller/external_async_nofork.go:117\ngithub.com/crossplane/crossplane-runtime/pkg/reconciler/managed.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v1.15.0-rc.0.0.20231215091746-d23a82b3a2f5/pkg/reconciler/managed/reconciler.go:903\ngithub.com/crossplane/crossplane-runtime/pkg/ratelimiter.(*Reconciler).Reconcile\n\tgithub.com/crossplane/crossplane-runtime@v1.15.0-rc.0.0.20231215091746-d23a82b3a2f5/pkg/ratelimiter/reconciler.go:54\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227\nruntime.goexit\n\truntime/asm_amd64.s:1650"}
2024-01-04T07:23:44Z	DEBUG	events	failed to observe the resource: [{0 reading IAM Policy (arn:aws:iam::000000000:policy/sample-user-policy): InvalidClientTokenId: The security token included in the request is invalid.
	status code: 403, request id: 0fe96847-5a23-4bf0-830e-2dee863945a2  []}]	{"type": "Warning", "object": {"kind":"Policy","name":"sample-user-policy","uid":"f330b9b3-09c5-4b5e-afab-a37af7c6fc1f","apiVersion":"iam.aws.upbound.io/v1beta1","resourceVersion":"1293"}, "reason": "CannotObserveExternalResource"}

How can we reproduce it?

Install localstack
helm repo add localstack-repo https://helm.localstack.cloud
helm upgrade --install localstack localstack-repo/localstack --namespace localstack --create-namespace

Set up the following providerconfig:
---
apiVersion: v1
kind: Secret
metadata:
  name: aws-creds
  namespace: upbound-system
type: Opaque
stringData:
  creds: |
    [default]
    aws_access_key_id =<PHONE_NUMBER>00
    aws_secret_access_key = nope
---
apiVersion: aws.upbound.io/v1beta1
kind: ProviderConfig
metadata:
  name: default
spec:
  credentials:
    source: Secret
    secretRef:
      namespace: upbound-system
      name: aws-creds
      key: creds
  s3_use_path_style: true
  skip_credentials_validation: true
  skip_metadata_api_check: true
  skip_requesting_account_id: true
  endpoint:
    source: Custom
    hostnameImmutable: true
    services:
      - iam
      - sts
    url:
      type: Static
      static: "http://localstack.localstack.svc.cluster.local:4566"

Run uptest on examples/iam/role.yaml (or anything else)
What environment did it happen in?

Crossplane Version:
Provider Version:
Kubernetes Version:
Kubernetes Distribution:  Kind

@mbbush thanks for reporting this, I've sent a PR for this, which I've locally validated the endpoint configuration is properly propagated. If possible, would you be willing to test with https://github.com/upbound/provider-aws/pull/1066 check if the fix works for you too?

Thanks for the quick fix! Yes, when I build and deploy #1066 it resolves the issue for me.

@mbbush many thanks for testing it, and glad that it is working 🎉  Could you also check that #1066 still works for CLI-based resources too in your localstack setup?

CLI-based resources work too. One of the resources I'm currently working with is UserPoolClient.cognitoidp, and that works fine with the build from #1066


Add node upgrade logic for the controller

Implementation of a simple node image upgrade mechanism that rebuilds and restrarts the node container if a new image can be pulled independent of the used orchestration tool such as docker-compose.

Is there a problem of starting two indy nodes on the same data dirs. Could it not be that the new container corrupt the indy data and than also the old container can't use the libindy data. Instead of spinning up the new container we should have a downtime in terms of shutting down the old and than starting the new one.

That is the current behavior. The old container is being stopped properly and then a new one is started. They cannot run at the same time anyway due to both port and container name conflicts. A few seconds downtime cannot be avoided.
The new container is only being created but not actually run before the old one is stopped. This order reduces the necessary downtime and avoids stopping and removing the old container in case the new one fails to be created for whatever reason leaving us with no node at all.

fixes https://github.com/IDunion/indy-node-container/issues/59


Tools required for developers

It would be helpful to mention which software and tools are required to successfully execute the instructions on:
https://bogl.engr.oregonstate.edu/technical/developing.html

Added a pre-requisite section to the dev page to clarify requirements & offer installation options.


Change card size with a slider.

We should create a slider that gives user an opportunity to change his recipe card default size.

https://github.com/angular-slider/angularjs-slider - looks pretty interesting.

It's bigger topic for me, about Little admin tool, we should disscus it before making this slider.


Added change_sunlight_settings service call

My first python project. New service call 'change_sunlight_settings'. allows scripts/automations to change sunlight settings at any time, without requiring a restart of Home Assistant.
Cons:

Yes I'm modifying a frozen dataclass and that's probably not what the devs had in mind when they originally constructed it.
Pros:

this service call doesn't require any modifications to the original code at all, allowing for easy addition to the main project.

Relatively lightweight

Use cases:
I work very odd hours that require me to wake up at a different time everyday, so I was looking for a way to adapt my lights throughout the day based on whenever my Home Assistant alarm runs. Unfortunately after a lot of searching it seemed like this simple feature didn't exist anywhere, so I decided to make it myself. I know next to nothing about python so my priorities were:

Getting the damn thing to work
Trying my best to 'add' the feature instead of rewrite the entire code, therefore allowing me to merge future updates into my fork.
Usability & Flexibility.

Check out the readme.md on https://github.com/th3w1zard1/adaptive-lighting for more information.

If anyone is reading this, please ignore this duplicate PR. this duplicate was created in an attempt to remove the clutter in the original PR 235


GameMaker Studio 2.3 Port?

would it be possible to have a GMS2.3 Port? as its much more updated and modern than GM8.1, and GM8.1 was cancelled 8 years ago.

if GMS2.3 supports loading from external DLLs on windows games, i might consider this in the future

it actually does support loading external DLLs! i wanted to try doing it myself but i have no idea what im doing

it actually does support loading external DLLs! i wanted to try doing it myself but i have no idea what im doing

I think it's possible through external_define(), at least for current GMS2 versions.

i can, at the very least, confirm that it runs in GMS1.4


Minor updates to  Securing Tiller Lab

Added a line to instruct users to change directory into the lab folder.
Updated the tiller-namespace-setup.sh script to use -d instead of -D for base64, because -D isnt supported in cloud shell.
fixes #109

Need to fix the PR. Will re-submit.


Support for pydantic exclude_none

Is your feature request related to a problem
I want to exclude from the output values set to None.
pydantic has support for this: <object>.json(exclude_none=true)
The solution you would like
Similar to the parameter response_model_exclude_unset but to exclude the Nones.
Describe alternatives you've considered
Not setting any None... Lot of boiler plate code.

In the latest versions you can set it in the path operation decorator with response_model_exclude_none=True.
The current latest version is 0.54.1.

Thanks 👍


Mono Repo version created (need some help for react) FIXED

@me-12 Thanks for creating this example. It was exactly what I was looking for.
One issue with running this sample is the process of going into each app and building / running it separately. To improve on that I have created a monorepo version of the same using lerna + yarn workspaces. The process of running it is just a two step process a defined in the README. I was planning to submit this as a PR but have run into one issue with the react app. I think I am missing something very basic here , but not able to figure it out. It would be great if you can provide me some incites.
Here is the project
https://github.com/tsukhu/single-spa-portal-example
Also once fixed , if you think it is ok , then I will submit this as a PR (after some fine tuning and getting the React app working)

I was able to fix the mono repo version and make it working for React as well.
Here are the new changes done to make it work https://github.com/tsukhu/single-spa-portal-example/commit/a096a05768be02dd706185bf544d3dd0202c9cc8
The main being using @babel/plugin-transform-runtime to isolate the react app

Hello tsukhu,
thank you for your work!
I created this repo to give an example on how to run different apps maintained by different teams with different technologies and still create a single website consisting of all those apps.
So basically, I expect that no one will use my repo exactly like it is. I think it is much more likely, that one team will work on only one app which has its own repo. In this scenario it wouldn't be necessary to use lerna.
I would also like to not add any more complexity to this repo since I think its already pretty complicated for new people.
Considering those points, I would rather not merge your Fork. But I still like your solution and if you want, I can add a link to your repo in the readme file.
What do you think?

@me-12 Thank you for your detailed response. It would be great if you could add a link in the Readme.

I have added a Link to your fork to the readme.md
https://github.com/me-12/single-spa-portal-example#forks


Add IS_FINE_GRAINED to listed inputs

added IS_FINE_GRAINED to listed inputs

Thanks @tsmith-rv! Closed in favor of https://github.com/BetaHuhn/repo-file-sync-action/pull/325


Aborted due warnings, but warnings are suppressed

Warnings are suppressed ignoreWarnings but still fail
    src: ['src/**/*.js', 'README.md'],
    options: {
        destination: 'doc',
        ignoreWarnings: true
    }

Command line result
grunt jsdoc
Running "jsdoc:src" (jsdoc) task
Warning: jsdoc terminated with a non-zero exit code Use --force to continue.

Aborted due to warnings.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26538718-aborted-due-warnings-but-warnings-are-suppressed?utm_campaign=plugin&utm_content=tracker%2F294645&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F294645&utm_medium=issues&utm_source=github).

could you please paste the result of running the tasks with the --debug flag

any update ?

Very sorry, I'm not engaged in the project anymore.


[BUG] crash in read_exif_tag

Describe the bug
I have a crash due to an image with a problem in the metadata.
Here is the message from exifTool
> exiftool myimage.jpg | grep -i warning
Warning                         : Bad InteropOffset SubDirectory start

To Reproduce
Steps to reproduce the behavior:

Use an image with problematic metadata
Call ImageBuf::read in a multi-threaded context
You got a crash with the following backtrace:

(gdb) bt
#0  0x00007ffff062ac7c in OpenImageIO_v2_0::read_exif_tag(OpenImageIO_v2_0::ImageSpec&, TIFFDirEntry const*, OpenImageIO_v2_0::span<unsigned char const, -1l>, bool, int, std::set<unsigned long, std::less<unsigned long>, std::allocator<unsigned long> >&, OpenImageIO_v2_0::pvt::TagMap const&) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#1  0x00007ffff062b392 in OpenImageIO_v2_0::pvt::decode_ifd(unsigned char const*, OpenImageIO_v2_0::span<unsigned char const, -1l>, OpenImageIO_v2_0::ImageSpec&, OpenImageIO_v2_0::pvt::TagMa
p const&, std::set<unsigned long, std::less<unsigned long>, std::allocator<unsigned long> >&, bool, int) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#2  0x00007ffff062b481 in OpenImageIO_v2_0::decode_exif(OpenImageIO_v2_0::span<unsigned char const, -1l>, OpenImageIO_v2_0::ImageSpec&) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#3  0x00007ffff062b853 in OpenImageIO_v2_0::decode_exif(OpenImageIO_v2_0::string_view, OpenImageIO_v2_0::ImageSpec&) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#4  0x00007ffff082b4fd in OpenImageIO_v2_0::JpgInput::open(std::string const&, OpenImageIO_v2_0::ImageSpec&) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#5  0x00007ffff082bf1d in OpenImageIO_v2_0::JpgInput::open(std::string const&, OpenImageIO_v2_0::ImageSpec&, OpenImageIO_v2_0::ImageSpec const&) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#6  0x00007ffff06c8924 in OpenImageIO_v2_0::ImageInput::open(std::string const&, OpenImageIO_v2_0::ImageSpec const*) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#7  0x00007ffff0664058 in OpenImageIO_v2_0::ImageBufImpl::read(int, int, int, int, bool, OpenImageIO_v2_0::TypeDesc, bool (*)(void*, float), void*) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0
#8  0x00007ffff066609b in OpenImageIO_v2_0::ImageBuf::read(int, int, bool, OpenImageIO_v2_0::TypeDesc, bool (*)(void*, float), void*) () from /apps/packages/cgDev/oiio/2.0.8/platform-linux/build-debug/lib64/libOpenImageIO.so.2.0

Expected behavior
Avoid crash even on problematic images. Other viewers and image editors manage to use them without crashing.
Evidence
The surprising thing is that it only crashes in a multi-threaded context (multiple calls to ImageBuf::read on different images from different threads).
I can provide an image but not publicly.
Platform information:

OIIO branch/version: 2.0.8
OS: CentOS 7.6
C++ compiler: g++ 4.9
Any non-default build flags when you build OIIO: No

Can you send me an image with the "problematic metadata"?

I have a similar issue that OpenImageIO is crashing when opening an image with a specific EXIF tag.
(with Natron Composing tool).
Where can I post you the image so you can have a look at it and maybe make a fix?
(can not make it public since its from a client....).

You can email it directly to lg AT openimageio.org

Can you try this on your end?
https://github.com/OpenImageIO/oiio/pull/2429

I believe #2429 addressed this, and since nobody ever replied the last time I asked if it was still broken, I'm going to close the issue.


Issues.list() does not work. XHR reference missing

Hi everyone. I'm having a frustrating issue. When I try simply code like this:
var Github = require('github-api');
var ghUsername = 'michael';
var ghRepo = 'github';

var github = new Github({
  token: TOKEN,
  auth: "oauth"
});

var issues = github.getIssues(ghUsername, ghRepo);
issues.list(null, function(err, issueList) {
    console.log(err);
    console.log(issueList.length);
});

I get an empty console response. I've narrowed it down to this line in github.js. It looks like axios no longer provides the xhr request in their response. The link header is obviously still there (can be verified by opening up this link and viewing the headers) but we apparently cannot rely on having access to xhr.
I can propose a fix for this (with a PR) but I wanted someone to validate my findings first.
Thanks,
Harrison

Hi.
axios never exposed the XHR object, that's why we're using our own fork. We do provide the XHR object as you can see on this line. The object is passed as the third argument since we implemented this feature.

When I go in and manually add a console.log(response.request) before calling cb I get undefined. I installed the module using npm install --save github-api. Did I do something wrong?

Note, I just tested my example on a clean install of github-api on a completely different computer and I have the same issue, no issues are returned.

I'm experiencing the same problem with both basic auth and oauth. No issues are returned in the callback.
The<EMAIL_ADDRESS>was freshly installed via npm

I've spent a bit of time on this issue and I'm not able to replicate it. Our test for the list() method is passing and working correctly. The only bit I was able to find out is that the _requestAllPages method was not forwarding the XHR object to the callback method provided by the user. However, this has been fixed in commit 5bcfa70cc4817b9c1b7e771537cc7f6553dae9d9.
My suggestion would be to adapt our test for Issues to your case and see what happens, or to create a JSFiddle that reproduces the issue. I'm closing this issue for now.


conda

create conda forge release

@pkrusche https://www.pyopensci.org/python-package-guide/tutorials/publish-conda-forge.html

Following this: https://github.com/conda-forge/staged-recipes

https://github.com/conda-forge/staged-recipes/pull/27124
@tcoroller can you confirm there you can be a maintainer?


Add LICENSE

First.
I don't mean to define the license of your project.
But as issues are disabled I can't open an issue so I had to resort to opening a pull request.
I want to publish this package in nixpkgs. But it needs a license. Hopefully some open license would be ideal. Apache 2.0, MIT, these sorts. But it is obviously not up to me.
Thanks for the project.

I have proposed this package as Non-Free (which is unfortunate):
https://github.com/NixOS/nixpkgs/pull/303202

ping @misak113

Thanks!


add dynamic view unwrapping

I am going to iterate on this PR.

This now also fixes the xtensor-blas issue: https://github.com/QuantStack/xtensor-blas/issues/66
@SylvainCorlay we discussed this yesterday and you were voting for a metafunction. I agree that a meta function and compile time propagation of the layout would be nicer.
One issue I see is that we can't check at compile time if the step of a stepped_range is 1 or not. If it's 1 then we could still propagate the layout.
This means we can either choose to not propagate the layout in this case, or fall back to this dynamic version.


Problem with hover on  ?

Hi,
I have a problem when using the toggle on an  element : the hover triggers when I come from below the element, but not from above or the sides.
You can see it here, try to hover "Products" in the top : http://wrap.dynamicweb-cms.com/home-2
Here is what the HTML looks like :

 Products

        Bikes

If I replace  by <button>, I don't have any problem. I have updated to the latest version locally but no luck.
Any idea where this could come from ?
Thanks !

Pssst: the link you give isn't working.

Hm, weird. I tried it in incognito mode and on my phone, and I don't have any problem accessing it.

This is related to #8, #16 and #27. In short, this isn't supported, but it's not a bug either. There are some hacky workarounds, and it's on the roadmap for v3, which is indefinitely stalled (see other v3 tickets for more on that).


Small update for outdated and wrong title in TOC within Microservices online eBook

Title
Small update for outdated and wrong title in TOC within Microservices online eBook
Summary
The title at the TOC was not changed so it doesn't match the title at the page itself.
Now it matches right.
Suggested Reviewers
Maira or Bill Wagner

@CESARDELATORRE,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Failing Github release assets upload action

This library has failed the last several github release upload actions. https://github.com/adafruit/Adafruit_CircuitPython_Wave/actions/runs/7152684527/job/19478284375
Error: Error: unexpected status code: 403

Speculatively changing a setting and re-running ... did a github default change or did was a step missed creating this repo?

That fixed it. I added an item to the FAQ of https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/releasing-on-github with the related error & solution.

Thank you!


Scrollbars

What happens if too many lists or tasks are added? These should still be visible by adding a scrollbar on each region.

Make the update task window scrollable


Improve unit tests

The new tests make use of some deltas and signatures generated by the
rdiff from the original librsync (the one written in C). The idea of
these tests is to make sure we are generating results that match those
of the original library.
Some of the test cases are disabled because they currently fail. They will be enabled in upcoming PR that fix these issues.

@balena-ci rebase

@balena-ci rebase


Great implementations of some common calibration losses ;)

Thank you, Jordy. I appreciate it.
I plan to improve some pieces of the code and add more instructions after the holiday season.
Let me know if you have any questions or advices.
Happy holiday.
Bingyuan


Reactivate user charge ?

Hello, in my AfterAuthanticate job  I check if the user is reinstalling his shop and I check the first activation date of the previous charge and the canceled day. For example, he deactivated the app 15 days before the recurring payment. How can I reactivate the same charge_id with 15 days trial?
I saw that Shopify has: Activates a previously accepted recurring application charge
/admin/recurring_application_charges/#ID/activate.json

You need to create a new charge, the old won't activate. There's logic in the billing controller to already pull their last charge details and work out the remaining trial days if any and create a new charge


Restraints

We need to have a way to enforce that all restraints that operate in the same phase have the same number of windows. For example, this won't work:
first.pull = {'target_initial'   : 0,  # angstroms (by definition, I guess)
             'target_final'     : 10, # angstroms
             'target_increment' : 1,  # angstroms
             'force_initial'    : 5,  # kcal per mol
             'force_final'      : 5,  # kcal per mol
             'force_increment'  : 1   # kcal per mol (but shouldn't matter)
            }
second.pull = {'target_initial'   : 4,  # angstroms (by definition, I guess)
             'target_final'     : 12, # angstroms
             'target_increment' : 1,  # angstroms
             'force_initial'    : 7,  # kcal per mol
             'force_final'      : 23,  # kcal per mol
             'force_increment'  : 1   # kcal per mol (but shouldn't matter)
            }

...because they are both pulling restraints with a different number of target values. It is also a problem if the number of targets and forces doesn't match. I think we need to stuff the error checking logic somewhere, perhaps restraints.initialize().

We need to find all the attachment windows, but not every restraint is going to be active during attachment. So how do we get the total number of attachment windows? Should we loop over all restraints, find the length of the attachment list, and just go with that? That seems... sloppy, but maybe with error checking in restraints.initalize() it will be okay.


Select all symbol highlights

VS Code provides commands to navigate between (next/previous) "symbol highlights". However, there is no command to select all symbol highlights.
This is not the same as "Select All Occurrences of Find Match" because that might select too many things. For example:
type Foo = {}
const Foo: Foo = {}
Foo;

In this example we only want to select the type declaration and annotation:

… but "Select All Occurrences of Find Match" would also select the const declaration and reference:

I also want the same for squiggles

anyone working on this? I'd like to give it a go if not

Hi! @jrieken Is it ok if I look into the issue? Seeing as the last comment is a year and a half ago, I'm probably not interrupting anyone's progress :)
I haven't worked on parts of VSCode before and am starting to work through reading the Wiki and code structure, so if you can give me some pointers to where relevant code would be, that would be great!
Thank you.

Almost done with implementation - what should the default hotkey be set to, if any?

@OliverJAsh @jrieken Done!
Since multiple squiggles don't appear to be counted as the same symbol, this doesn't work with squiggles unless we make a special case for it.

PR coming soon.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


Adding swhkd to nixpkgs and added WhenFreedom to maintainers.

Description of changes
Program
swhkd.
Homepage
https://github.com/waycrate/swhkd
Description
swhkd is a program which is a port of sxhkd to Wayland.

Things done
I have done a few tests of the program. The package compiles perfectly and runs on my system which is x86_64-linux.
Problems
The program requires to be run using pkexec. Due to NixOS's advanced system, I could not for the life of me figure out how to implement the policy file. During the build process, a script is executed which generates the policy file, but of course due to the nature of NixOS's system, even if the policy file is placed into the correct path, it won't work. I have spent hours of researching and trial and error, and to no avail.
I decided to just submit the package, because the program does in fact work.
I hope someone can enlighten me on how I might achieve to make the program work with pkexec.
Tests
I have in fact tested the program using a hacky method which is:
echo $$
pkttyagent --process <process-id>

To run the program, swhks must be run with:
swhks &

and swhkd on NixOS must be run with:
pkexec swhkd -c <path-to-swhkdrc>`

on the terminal with the same process ID entered into pkttyagent.
At least on my system, swhkd does not pick up the config, only when you point it to the config file it does.
Bare in mind, when the program is run, it will say "XDG_RUNTIME_DIR has not been set.", but program still works.
I made a test by entering a keybind "super + m" to open Firefox, and it worked amazingly.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

this is not the first time someone has tried to add this package: #255374 #276788

Closing in favor of #255374 as that is ready to be merged.