Fix intermittent stack overflow

This is the infinite recursion we may hit today intermittently:
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__DeadlockAwareAcquire
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__EnsureClassConstructorRun
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__CheckStaticClassConstructionReturnNonGCStaticBase
S_P_CoreLib_System_Threading_Lock__TryAcquireContended
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__DeadlockAwareAcquire
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__EnsureClassConstructorRun
S_P_CoreLib_System_Runtime_CompilerServices_ClassConstructorRunner__CheckStaticClassConstructionReturnNonGCStaticBase
S_P_CoreLib_System_Threading_Lock__TryAcquireContended

Thank you so much! Do you know when we could push this to the NuGet package? If very soon I can probably just move forward to the next build of CoreRT.

Do you know when we could push this to the NuGet package?

We do two builds per day. The next build in ~6 hours should have it!


STREAMLINE-750 Change comma separated string into an array for servic…

…eBundle API having type as array.string
@shahsank3t Please pull this and test and let me know. Thanks in advance!

@HeartSaVioR
+1, Tested the PR and it works fine.


Multisig wrapper should allow for sending a second tx with the same parameters

Expected Behavior
Multisig should submit a new tx if all matching txs have already been confirmed by the owner
Current Behavior
Multisig wrapper will try to re-confirm the tx

closing since aslawons pr seems to address this


[webview_cookie] cannot add cookie in iOS

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I use the latest version of webview_cookie, v4.2.2.

Open a new webview page, which is a StatefulWidget with flutter_webview.
On initState, initialize the webviewCookieManger and webViewController.
On changeDepencies, add cookies by reading cookiejar in Dio session, then add it. If all added, print out the cookies and request the page.

Expected results
I expect that all these cookies are added into the webview's CookieManager, and request the page with them.
Actual results
It not, only empty. When requesting page, only the page's cookie appears.
Code sample
Code Sample
import 'dart:developer' as developer;
import 'dart:io';

import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';
import 'package:watermeter/repository/network_session.dart';
import 'package:url_launcher/url_launcher_string.dart';

class WebView extends StatefulWidget {
  /// This is the page we want to request.
  final String domain;
  /// This is the page's name, shows in the appbar.
  final String name;
  /// We get the cookie from Dio CookieJar, using these url.
  final List<String> cookieDomain;
  WebView({
    super.key,
    required this.name,
    required this.domain,
    List<String>? cookieDomainList,
  }) : cookieDomain = cookieDomainList ?? [];

  @override
  State<WebView> createState() => _WebViewState();
}

class _WebViewState extends State<WebView> {
  var loadingPercentage = 0;
  late final WebViewController controller;
  late final WebViewCookieManager webViewCookieManager;

  @override
  void initState() {
    /// Init the cookieManager and WebViewController
    webViewCookieManager = WebViewCookieManager();
    controller = WebViewController()
      ..setJavaScriptMode(JavaScriptMode.unrestricted)
      ..setNavigationDelegate(NavigationDelegate(
        onPageStarted: (url) {
          setState(() {
            loadingPercentage = 0;
          });
        },
        onProgress: (progress) {
          loadingPercentage = progress;
        },
        onPageFinished: (url) {
          setState(() {
            loadingPercentage = 100;
          });
        },
      ));

    super.initState();
  }

  @override
  void didChangeDependencies() async {
    List<String> toIterate = List.from(widget.cookieDomain);
    for (var i in toIterate) {
      /// Read the cookies from cookieJar.
      /// cookieJar is PersistCookieJar from cookie_jar package.
      List<Cookie> cookies =
          await NetworkSession().cookieJar.loadForRequest(Uri.parse(i));

      for (var element in cookies) {
        /// log the cookies here.
        developer.log(
          "webview: ${element.name} = ${element.value} ${i.replaceAll(RegExp(r'^http(s?)://'), "")}",
          name: "MyWebView",
        );

        for (var element in cookies) {
          /// We add the cookies here, ios failed.
          await webViewCookieManager.setCookie(
            WebViewCookie(
              name: element.name,
              value: element.value,
              domain: "${i.replaceAll(RegExp(r'^http(s?)://'), "")}",
            ),
          );
        }
      }
    }

    /// Check the cookies in the webviewCookieManager
    await controller
        .runJavaScriptReturningResult(
          'document.cookie',
        )
        .then(
          (value) => developer.log(
            name: "MyWebView",
            "Set cookie: $value",
          ),
        );

    if (mounted) {
      /// If add cookies complete, request the page.
      controller.loadRequest(
        Uri.parse(widget.domain),
      );
      developer.log(
        "showld log page ${widget.domain}",
        name: "MyWebView",
      );
      super.didChangeDependencies();
    }
  }

  @override
  Widget build(BuildContext context) {
    return WillPopScope(
      onWillPop: () async {
        if (await controller.canGoBack()) {
          await controller.goBack();
          return false;
        } else {
          return true;
        }
      },
      child: Scaffold(
        appBar: AppBar(
          title: Text(widget.name),
          leading: IconButton(
            onPressed: () {
              Navigator.pop(context);
            },
            icon: const Icon(Icons.arrow_back),
          ),
          actions: [
            IconButton(
              onPressed: () {
                launchUrlString(
                  widget.domain,
                  mode: LaunchMode.externalApplication,
                );
              },
              icon: const Icon(Icons.link),
            ),
          ],
        ),
        body: Stack(
          children: [
            WebViewWidget(
              controller: controller,
            ),
            if (loadingPercentage < 100)
              LinearProgressIndicator(
                value: loadingPercentage / 100.0,
              ),
          ],
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () => controller
              .runJavaScriptReturningResult(
                'document.cookie',
              )
              .then((value) => developer.log(value.toString())),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[MyWebView] webview: route = Omitted because of privacy ids.xidian.edu.cn/authserver/
[MyWebView] webview: JSESSIONID = Omitted because of privacy ids.xidian.edu.cn/authserver/
[MyWebView] webview: CASTGC = Omitted because of privacy ids.xidian.edu.cn/authserver/
[MyWebView] webview: EncryptKey = Omitted because of privacy ids.xidian.edu.cn/authserver/
[MyWebView] webview: REFERERCE_TOKEN = Omitted because of privacy ids.xidian.edu.cn/authserver/
[MyWebView] Set cookie:
[MyWebView] showld log page https://ids.xidian.edu.cn/authserver/login?service=https%3A%2F%2Fids.xidian.edu.cn%2Fauthserver%2Foauth2.0%2FcallbackAuthorize%3Fclient_id%3D869608421533880320%26redirect_uri%3Dhttp%253A%252F%252Frepair.xidian.edu.cn%252Fappsys%252FxidianCasLogin%252FoauthLogin%26response_type%3Dcode%26state%3Dhome%26client_name%3DCasOAuthClient

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.5 22G74 darwin-arm64, locale
    zh-Hans-CN)
    • Flutter version 3.10.6 on channel stable at
      /Users/superbart/Downloads/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (5 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/superbart/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment Homebrew (build 17.0.8+0)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✗] Chrome - develop for the web (Cannot find Chrome executable at
    /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (2 available)
    • iPhone 14 Pro Max (mobile) • 837066F5-2A56-4417-8938-04E4FC23583F • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-arm64 • macOS 13.5 22G74 darwin-arm64

[!] Network resources
    ✗ An HTTP error occurred while checking "https://github.com/": Connection
      closed before full header was received

! Doctor found issues in 2 categories.

This bug is related to https://github.com/flutter/flutter/issues/115460.

Hi @BenderBlog. I see this is similar/related to https://github.com/flutter/flutter/issues/115460. Are there differences between this issue and the already existing one you'd like to point out. If yes, also attach  a minimal complete reproducible code sample that doesn’t include 3rd party plugins or complex production code (just a main.dart code file).
Thank you!

Since this is similar to https://github.com/flutter/flutter/issues/115460. We'd be closing this as a duplicate of the already open issue, kindly comment on that issue, upvote and follow up for updates. If you disagree with the similarity, kindly comment here with the code sample and I'd reopen this.
Thank you!


feat(eslint) Add fix option to npm run commands

npm test currently fails due to eslint errors. First part is to add a --fix option that can optionally be run.

Thanks, tests are not setup yet but this Will help the process of adding it!


non-current row versions update

Recommend that users query the history table directly when needing non-current data as CONTAINED IN does query both the current and history tables.

@billyswitzer : Thanks for your contribution! The author, @CarlRabeler, has been notified to review your proposed change.


Create custom iconset, remove iron-icons import

Fixes #121

Looks  exactly the same as #103 from April, however I'm happy it is finally merged!


[question] Would it be possible to project rasterized layers?

My application uses Mapsui to build maps with shapefile layers.  Shapefiles have their performance challenges.  I like the approach to rasterize the a shapefile but I need to project it similar to a vectorlayer.  How much work would it take to add projection support to  rasterized layers?  I would be willing to take on this feature but I need some direction.  Thanks.

I think there was an issue with this. In theorie it should be possible to project the shapefiles first so you don't have to project the rasters. I believe in practice the problem is that the rasterlayer gets the ITransformation set by the map while the vectorlayer behind it needs it.
I guess it should be possible to do some projection in code on the datasource to circumvent this.


rbac: Audit * verbs

What this PR does / why we need it:
It replaces all * verbs by individual verbs required to run all intended operations.
It drops the usage of * verbs, replacing them by individual verbs strictly required by the test suite, i.e. unit tests and functional tests. The auditing process has been split in the next action items:

Deploying the operator in a CRC cluster and running the unit and function test.
Deploying the operator in a 3 masters and 3 workers nodes and running the unit and functional tests.

jira-ticket: CNV-24031
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # https://bugzilla.redhat.com/show_bug.cgi?id=2223775
Special notes for your reviewer:
Release note:

Replace the `*` verbs by individual verbs

/retest-required

/retest-required

/retest-required

/retest-required

/retest-required

/retest-required

/retest-required

/cherry-pick release-v0.15


Switch to three-arg variant of unpack in most places

This library has a lot of places that involve packing up varargs into a table and using unpack to pull them back out. If those varargs have nil values in the middle, they'll get swallowed up!
Anywhere where we use unpack(t), we should instead use unpack(t, start, finish) and manually keep the length of the input varargs via select("#", ...). Perhaps polyfilling table.pack is the way to go.

Partially fixed by https://github.com/LPGhatguy/roblox-lua-promise/commit/6c6eef6a3ba6fcaccf6e26fd742fe8569cd3ff18


waf: fix cross-compilation

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Investigating https://github.com/NixOS/nixpkgs/pull/249251

This fixes evaluating pkgsCross.armv7l-hf-multiplatform.python3Packages.cairosvg. I'm currently checking whether it builds.

I am a bit afraid that Python3 should be propagated inside waf.hook.

libjack2 fails to build (both native and cross):
waf: error: no such option: --sbindir

On master I see:
configure flags: --prefix=/nix/store/dm1lsr8ywyc64x3wgriiqmd1mpsm532c-libjack2-1.9.22 --classic --autostart=dbus --dbus configure

Now, I see:
configure flags: --prefix=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22 --bindir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/bin --sbindir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/sbin --includedir=/nix/store/kp7l18845jvywbxbc6jh18gl5fncdkq4-libjack2-1.9.22-dev/include --oldincludedir=/nix/store/kp7l18845jvywbxbc6jh18gl5fncdkq4-libjack2-1.9.22-dev/include --mandir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/share/man --infodir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/share/info --docdir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/share/doc/libjack2 --libdir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/lib --libexecdir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/libexec --localedir=/nix/store/zf1b3sw1c4sy8i0fx94k6is9j6zaji98-libjack2-1.9.22/share/locale --classic --autostart=dbus --dbus configure

The root cause of this issue is that waf.hook breaks splicing. This fix makes things evaluate, but it almost certainly doesn't build correctly. stdenv.hostPlatform.system != stdenv.targetPlatform.system will be false and waf will be from the host platform.
Here is a diff of the waf hook derivations with this PR applied. broken.txt is what you get when you use waf.hook, while good.txt is what you get when you use the wafHook alias. Note that broken.txt doesn't include --cross-compile and references waf-armv7l-unknown-linux-gnueabihf-2.0.26 (built for the host platform).

Diff
diff --git a/good.txt b/broken.txt
index<PHONE_NUMBER>6f..33f1385f33c9 100644
--- a/good.txt
+++ b/broken.txt
@@ -1,5 +1,5 @@
 {
-  "/nix/store/86byz9qa5an1cy774aqbikn8cd7w4vq2-waf-setup-hook.drv": {
+  "/nix/store/d3l1w04pdk7jmy8f7bcfcrbvzlsqciv9-waf-setup-hook.drv": {
     "args": [
       "-e",
       "/nix/store/6xg259477c90a229xwmb53pdfkn6ig3g-default-builder.sh"
@@ -10,9 +10,9 @@
       "buildCommand": "mkdir -p $out/nix-support\ncp /nix/store/7hqndxkvykifrd4dbqvsi79xmxrpyxh0-setup-hook.sh $out/nix-support/setup-hook\nrecordPropagatedDependencies\nsubstituteAll /nix/store/7hqndxkvykifrd4dbqvsi79xmxrpyxh0-setup-hook.sh $out/nix-support/setup-hook\n",
       "buildInputs": "",
       "builder": "/nix/store/m36d29gn5gm9bk0g7fcln1v8171hvn95-bash-5.2-p15/bin/bash",
-      "cmakeFlags": "",
-      "configureFlags": "",
-      "crossFlags": "--cross-compile \"--cross-execute=/nix/store/lxrcjkl3angz4bm7ys1f2cywqlgj9ayk-qemu-8.0.4/bin/qemu-arm\"",
+      "cmakeFlags": "-DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=armv7l -DCMAKE_HOST_SYSTEM_NAME=Linux -DCMAKE_HOST_SYSTEM_PROCESSOR=x86_64",
+      "configureFlags": "--build=x86_64-unknown-linux-gnu --host=armv7l-unknown-linux-gnueabihf",
+      "crossFlags": "",
       "depsBuildBuild": "",
       "depsBuildBuildPropagated": "",
       "depsBuildTarget": "",
@@ -26,42 +26,40 @@
       "enableParallelBuilding": "1",
       "enableParallelChecking": "1",
       "enableParallelInstalling": "1",
-      "mesonFlags": "",
+      "mesonFlags": "--cross-file=/nix/store/liv5rkz44z1cy77w4a92fg2ibnf852ng-cross-file.conf",
       "name": "waf-setup-hook",
       "nativeBuildInputs": "",
-      "out": "/nix/store/zsfa3fvqinzllv8c1jiyjfjrlabdpzgi-waf-setup-hook",
+      "out": "/nix/store/ra8x0v1s6197y2k03wwggh11hmjhnzd4-waf-setup-hook",
       "outputs": "out",
       "passAsFile": "buildCommand",
       "patches": "",
       "propagatedBuildInputs": "",
       "propagatedNativeBuildInputs": "",
-      "stdenv": "/nix/store/x6rqmyq0ni35krzp3fs44k36dfin1zhn-stdenv-linux",
+      "stdenv": "/nix/store/ckraqx6fiwami5cg96gn5j266rdzqr7q-stdenv-linux",
       "strictDeps": "1",
       "system": "x86_64-linux",
-      "waf": "/nix/store/syn1dhm73zd4d0jng4krqc17akwsmvb6-waf-2.0.26"
+      "waf": "/nix/store/h5bv4b0a65byh2lfinwndmg0jxc4013k-waf-armv7l-unknown-linux-gnueabihf-2.0.26"
     },
     "inputDrvs": {
       "/nix/store/0sawbbskl41aq4ii9kl5w77r4m92das8-bash-5.2-p15.drv": [
         "out"
       ],
-      "/nix/store/1qxgnnxb8ggpgq84jhmgl8351a8v0h03-qemu-8.0.4.drv": [
+      "/nix/store/j0392zmavpa52y6yr32v6wi1v6n7grbc-waf-armv7l-unknown-linux-gnueabihf-2.0.26.drv": [
         "out"
       ],
-      "/nix/store/76krn5snp1b82i3d95sz11fpnqlkwrl3-waf-2.0.26.drv": [
-        "out"
-      ],
-      "/nix/store/ks92ys95hq4c5aq5rqncl4qn9nak7haf-stdenv-linux.drv": [
+      "/nix/store/kpmcs593zvgcdsblr6fb1v27nhijnpzp-stdenv-linux.drv": [
         "out"
       ]
     },
     "inputSrcs": [
       "/nix/store/6xg259477c90a229xwmb53pdfkn6ig3g-default-builder.sh",
-      "/nix/store/7hqndxkvykifrd4dbqvsi79xmxrpyxh0-setup-hook.sh"
+      "/nix/store/7hqndxkvykifrd4dbqvsi79xmxrpyxh0-setup-hook.sh",
+      "/nix/store/liv5rkz44z1cy77w4a92fg2ibnf852ng-cross-file.conf"
     ],
     "name": "waf-setup-hook",
     "outputs": {
       "out": {
-        "path": "/nix/store/zsfa3fvqinzllv8c1jiyjfjrlabdpzgi-waf-setup-hook"
+        "path": "/nix/store/ra8x0v1s6197y2k03wwggh11hmjhnzd4-waf-setup-hook"
       }
     },
     "system": "x86_64-linux"

You could work around these issues by adjusting the platform comparison and using more buildPackages, but this wouldn't solve the root splicing problem.

@ofborg build pkgsCross.armv7l-hf-multiplatform.libjack2

@ofborg build pkgsCross.armv7l-hf-multiplatform.python3Packages.cairosvg

@lopsided98 can you test it now?

jack2 pulls in a bunch of dependencies that are broken for other reasons, libjack2 is the minimal version that should work
@ofborg build pkgsCross.armv7l-hf-multiplatform.libjack2

Timeout failure :(

@ofborg build pkgsCross.armv7l-hf-multiplatform.libjack2

Yay, it worked!

@ofborg build pkgsCross.aarch64-multiplatform.tests.cc-wrapper
pkgsCross.aarch64-multiplatform.tests.cc-wrapper has a infinite recursion currently, hopefully this PR fixes it
$ nix build ".#pkgsCross.aarch64-multiplatform.tests.cc-wrapper" --show-trace
error:
       … while calling the 'derivationStrict' builtin

         at <nix/derivation-internal.nix>:9:12:

            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'cc-wrapper-test-aarch64-unknown-linux-gnu'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'buildCommand' of derivation 'cc-wrapper-test-aarch64-unknown-linux-gnu'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/test/cc-wrapper/default.nix:15:3:

           14|
           15|   buildCommand = ''
             |   ^
           16|     set -o pipefail

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/pkgs/test/cc-wrapper/default.nix:11:14:

           10|   staticLibc = lib.optionalString (stdenv.hostPlatform.libc == "glibc") "-L ${glibc.static}/lib";
           11|   emulator = stdenv.hostPlatform.emulator buildPackages;
             |              ^
           12| in stdenv.mkDerivation {

       … while calling 'emulator'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:248:20:

          247|
          248|         emulator = pkgs:
             |                    ^
          249|           if (final.emulatorAvailable pkgs)

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:249:15:

          248|         emulator = pkgs:
          249|           if (final.emulatorAvailable pkgs)
             |               ^
          250|           then selectEmulator pkgs

       … while calling 'emulatorAvailable'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:246:29:

          245|       in {
          246|         emulatorAvailable = pkgs: (selectEmulator pkgs) != null;
             |                             ^
          247|

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:246:36:

          245|       in {
          246|         emulatorAvailable = pkgs: (selectEmulator pkgs) != null;
             |                                    ^
          247|

       … while calling 'selectEmulator'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:216:26:

          215|       let
          216|         selectEmulator = pkgs:
             |                          ^
          217|           let

       … while evaluating derivation 'qemu-8.1.0'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'buildInputs' of derivation 'qemu-8.1.0'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:347:7:

          346|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          347|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^
          348|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;

       … while evaluating derivation 'pipewire-0.3.79'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'buildInputs' of derivation 'pipewire-0.3.79'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:347:7:

          346|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          347|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^
          348|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;

       … while evaluating derivation 'libjack2-1.9.22'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'nativeBuildInputs' of derivation 'libjack2-1.9.22'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:344:7:

          343|       depsBuildBuild              = lib.elemAt (lib.elemAt dependencies 0) 0;
          344|       nativeBuildInputs           = lib.elemAt (lib.elemAt dependencies 0) 1;
             |       ^
          345|       depsBuildTarget             = lib.elemAt (lib.elemAt dependencies 0) 2;

       … while evaluating derivation 'waf-setup-hook'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'crossFlags' of derivation 'waf-setup-hook'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/development/tools/build-managers/waf/hook.nix:16:5:

           15|     inherit waf;
           16|     crossFlags = lib.optionalString (stdenv.hostPlatform.system != stdenv.targetPlatform.system)
             |     ^
           17|       ''--cross-compile "--cross-execute=${stdenv.targetPlatform.emulator pkgs}"'';

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/pkgs/development/tools/build-managers/waf/hook.nix:16:18:

           15|     inherit waf;
           16|     crossFlags = lib.optionalString (stdenv.hostPlatform.system != stdenv.targetPlatform.system)
             |                  ^
           17|       ''--cross-compile "--cross-execute=${stdenv.targetPlatform.emulator pkgs}"'';

       … while calling 'optionalString'

         at /home/artturin/nixgits/my-nixpkgs/lib/strings.nix:243:5:

          242|     # String to return if condition is true
          243|     string: if cond then string else "";
             |     ^
          244|

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/pkgs/development/tools/build-managers/waf/hook.nix:17:44:

           16|     crossFlags = lib.optionalString (stdenv.hostPlatform.system != stdenv.targetPlatform.system)
           17|       ''--cross-compile "--cross-execute=${stdenv.targetPlatform.emulator pkgs}"'';
             |                                            ^
           18|   };

       … while calling 'emulator'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:248:20:

          247|
          248|         emulator = pkgs:
             |                    ^
          249|           if (final.emulatorAvailable pkgs)

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:249:15:

          248|         emulator = pkgs:
          249|           if (final.emulatorAvailable pkgs)
             |               ^
          250|           then selectEmulator pkgs

       … while calling 'emulatorAvailable'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:246:29:

          245|       in {
          246|         emulatorAvailable = pkgs: (selectEmulator pkgs) != null;
             |                             ^
          247|

       … from call site

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:246:36:

          245|       in {
          246|         emulatorAvailable = pkgs: (selectEmulator pkgs) != null;
             |                                    ^
          247|

       … while calling 'selectEmulator'

         at /home/artturin/nixgits/my-nixpkgs/lib/systems/default.nix:216:26:

          215|       let
          216|         selectEmulator = pkgs:
             |                          ^
          217|           let

       … while evaluating derivation 'qemu-8.1.0'
         whose name attribute is located at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'buildInputs' of derivation 'qemu-8.1.0'

         at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:347:7:

          346|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          347|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^
          348|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;

       error: infinite recursion encountered

       at «none»:0: (source not available)

Ofborg shows that it fails, but I tested and rebased to staging locally and it worked.

Actually, I'm trying this locally but still seeing infinite recursion issues.
nix build .#pkgsCross.aarch64-multiplatform.ffmpeg -L

~/nixpkgs$ nix build .#pkgsCross.aarch64-multiplatform.ffmpeg -L; echo $?
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'ffmpeg-aarch64-unknown-linux-gnu-5.1.3'
         whose name attribute is located at /nix/store/irskqk7rkl275n7v9ga3278qrlxafsk2-source/pkgs/stdenv/generic/make-derivation.nix:300:7

       … while evaluating attribute 'buildInputs' of derivation 'ffmpeg-aarch64-unknown-linux-gnu-5.1.3'

         at /nix/store/irskqk7rkl275n7v9ga3278qrlxafsk2-source/pkgs/stdenv/generic/make-derivation.nix:347:7:

          346|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          347|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^
          348|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: infinite recursion encountered

       at «none»:0: (source not available)

See also the ofborg log: https://github.com/NixOS/nixpkgs/runs/16592924618

@Mindavi
no mention of waf in the strace so that should be a separate issue
i rebased this branch on to 872e54e9e72665421ba81327780313b915272a8b (staging on sep6) and it worked but now rebasing on to 6f51712ed392baa5bd96f567864ce6b5dbbbd0cf it fails

likely caused by https://github.com/nixos/nixpkgs/commit/5b0ed68c106c1cbe3b573f3d1ca8c73eb203e346

https://github.com/NixOS/nixpkgs/pull/253913

https://nixpk.gs/pr-tracker.html?pr=252874 Shows that this still isn't in master or nixos-unstable which is blocking me. Is the PR tracker right?

Yes, it is.


feat: fileApi

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 17.83%. Comparing base (9a7e4a2) to head (a97f78a).

Files
Patch %
Lines

src/fileapi.rs
62.96%
10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   17.52%   17.83%   +0.30%
==========================================
  Files          25       26       +1
  Lines        3942     3969      +27
==========================================
+ Hits          691      708      +17
- Misses       3251     3261      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error while building 'UsdGeomMesh’ has no member named ‘CreatePrimvar’

Following the sdf instructions here (http://sdformat.org/tutorials?tut=install), I tried to build the sdf2usd convertor and failed and then found the readme in the sdformat github and through that found this github page.
Environment

OS Version: Ubuntu 20.04
Source build: Main branch and looks like commit number is 6fb572b5ed3c4cf165de158b193a33cace6ef2b5

Description

Expected behavior: Successful build and install
Actual behavior: During build, the following error was encountered: gz-usd/src/sdf_parser/Geometry.cc:376:34: error: ‘class pxrInternal_v0_22__pxrReserved__::UsdGeomMesh’ has no member named ‘CreatePrimvar’
376 |       auto coordinates = usdMesh.CreatePrimvar(

Steps to reproduce

USD: installation instructions
gz-usd
sdformat
Build gz-usd. The steps below follow a traditional cmake build, but gz-usd
git clone https://github.com/gazebosim/gz-usd

cd gz-usd
mkdir build
cd build
cmake ..

Output
/gz-usd/src/sdf_parser/Geometry.cc:376:34: error: ‘class pxrInternal_v0_22__pxrReserved__::UsdGeomMesh’ has no member named ‘CreatePrimvar’
376 |       auto coordinates = usdMesh.CreatePrimvar(
|                                  ^~~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/ignition-usd0.dir/build.make:102: src/CMakeFiles/ignition-usd0.dir/sdf_parser/Geometry.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1456: src/CMakeFiles/ignition-usd0.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
Other details

sdfformat version is sdfformat12 (was built from source)
usd release branch (1c2b097a48edd78abeffb0e7b4c8adfec4d14060) - built from source

Found out that this is because USD support is only for a particular branch. You have to clone the correct branch and build it otherwise gz-usd wont build. This is NOT documented. I will make a pull request in gz-usd.


Add option to disable all external HTTP requests

When running Cachet behind a firewall, Cachet may not have access to make requests out to the public internet. This can cause Cachet to timeout when requesting the API version endpoint or logging into the dashboard. This option should suspend all these requests so Cachet can still function without any allowed egress to the internet.

New option called CACHET_INTERNET_LOOKUPS created to allow disabling outbound HTTP requests for looking up things such as releases and credits. Defaults to true as in enabled. Set to false to disable.

New option called CACHET_INTERNET_LOOKUPS created to allow disabling outbound HTTP requests for looking up things such as releases and credits. Defaults to true as in enabled. Set to false to disable.


Doc updates.

Description:

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Documentation should be updated with the latest version.  below tag is missing. https://ballerina.io/learn/quick-tour/
documentation {
A resource is an invokable API method
Accessible at '/hello/sayHello
'caller' is the client invoking this resource
   P{{caller}} Server Connector
   P{{request}} Request
}

It looks like the syntax in this issue is already invalid. I just tested out the Quick Tour with the latest release and the code in the doc matches with what I see in the service. I'm closing this now, but please reopen if more clarification is required.


Craftcms v4

For review: Because the Craft CMS plugin store does not permit renaming of plugin handle names, we had to modify the plugin handle name to "websitetoolboxforum" for Craft CMS version 4. Added functionality to change domain.
Tester Name: Gopal Kumar
Note: This Pull request is for review only, no need to merge this with master.

We have created tag and realize it to make live on craftcms store. so this pull request doesn't require after code review pass.


python310Packages.google-cloud-logging: 3.0.0 -> 3.1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.google-cloud-logging is: "Stackdriver Logging API client library"
meta.homepage for python310Packages.google-cloud-logging is: "https://github.com/googleapis/python-logging"
meta.changelog for python310Packages.google-cloud-logging is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 3.1.1 with grep in /nix/store/ak4sknhkhsvqlp9r74akxj6rylb3yhgw-python3.10-google-cloud-logging-3.1.1
found 3.1.1 in filename of file in /nix/store/ak4sknhkhsvqlp9r74akxj6rylb3yhgw-python3.10-google-cloud-logging-3.1.1

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.google-cloud-error-reporting
python310Packages.google-cloud-logging
python39Packages.google-cloud-error-reporting
python39Packages.google-cloud-logging

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ak4sknhkhsvqlp9r74akxj6rylb3yhgw-python3.10-google-cloud-logging-3.1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.google-cloud-logging https://github.com/r-ryantm/nixpkgs/archive/60be290e1f3e198ae04713aa10684b9d8e17b9d2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ak4sknhkhsvqlp9r74akxj6rylb3yhgw-python3.10-google-cloud-logging-3.1.1
ls -la /nix/store/ak4sknhkhsvqlp9r74akxj6rylb3yhgw-python3.10-google-cloud-logging-3.1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-error-reporting
python310Packages.google-cloud-logging
python39Packages.google-cloud-error-reporting
python39Packages.google-cloud-logging

Maintainer pings
cc @SuperSandro2000 for testing.

Result of nixpkgs-review pr 174214 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-error-reporting
python310Packages.google-cloud-logging
python39Packages.google-cloud-error-reporting
python39Packages.google-cloud-logging


[Bug]: useEmblaCarousel initializes Embla with stale options in certain cases

Which variants of Embla Carousel are you using?

[ ] embla-carousel (Core)
[X] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-scroll
[ ] embla-carousel-solid
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-fade
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Steps to reproduce
The issues happens when useEmblaCarousel creates EmblaCarousel (emblaApi) at the same time when options have changed. It happens because of useEffect order
Here is an example: https://codesandbox.io/p/devbox/embla-carousel-stale-options-dw88yj
If you open the example on small viewport (less than 1024px in width) then the issue appears and Embla Carousel wrongly initialized with watchDrag: false instead of watchDrag: true.
https://github.com/user-attachments/assets/bb667a4b-f776-47ec-8960-7f948753aa61
Expected Behavior
Embla Carousel should be initialized with the latest options.
Additional Context
I have also tried...
What browsers are you seeing the problem on?
All browsers
Version
v8.2.0
CodeSandbox
https://codesandbox.io/p/devbox/embla-carousel-stale-options-dw88yj
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

I will open PR shortly.

@lesha1201 why aren’t you using the breakpoints option?

@lesha1201 thanks. I will look into this when possible.

@lesha1201 thanks. Your PR solves the problem.

@lesha1201 this bug fix was released in v8.2.1.


Overlaying HoloMaps

I've read the user guides but I haven't found any way to overlay multiple HoloMaps. I made two different functions hence HoloMaps to make two different lines that represent the axis of a Seismic Survey. What I have in mind, is to use this HoloMaps to explore the survey and to overlay them in the point of interest that's the interception of the lines mentioned above. Whatever I try, I still get this Exception: "One set of keys needs to be a strict subset of the other.".
I have no experience programming in this environment so I appreciate any advice that helps me to get experience in this matter.

HoloMaps should overlay just fine in normal cases.  Here the message indicates that your two holomaps have two different sets of key-dimension values, with neither one a subset of the other, so neither holomap's keys can be used as "the" set of keys for the overall holomap.  E.g. if one holomap has values for the keys 1, 5, and 9 and the other has values for 5, 7, and 11, the keys for the combined holomap would need to be 1, 5, 7, 9, 11, and it's not (currently) smart enough to figure that out.  Usually if this happens it's an error, in that you are overlaying two commensurate things, but it can happen when there is missing data, so it may be something that we could handle better if we saw a good motivating use case.  Meanwhile, you should be able to make one of the holomaps have values for all of the keys of the other.

if one holomap has values for the keys 1, 5, and 9 and the other has values for 5, 7, and 11, the keys for the combined holomap would need to be 1, 5, 7, 9, 11, and HoloViews is not (currently) smart enough to figure that out.

I don't think that is the case, what you describe should work fine. What I think the error is indicating is that the key dimensions are not overlapping, i.e. that you have one HoloMap which varies by time and another that varies by some other dimension, e.g. let's say by country. It therefore cannot figure out how combine these two things into a single HoloMap.

Ah, in that case the error message should be reworded to talk about key dimensions, and there's no limitation in HoloViews itself. Much better! :-)

if one holomap has values for the keys 1, 5, and 9 and the other has values for 5, 7, and 11, the keys for the combined holomap would need to be 1, 5, 7, 9, 11, and HoloViews is not (currently) smart enough to figure that out.

I don't think that is the case, what you describe should work fine. What I think the error is indicating is that the key dimensions are not overlapping, i.e. that you have one HoloMap which varies by time and another that varies by some other dimension, e.g. let's say by country. It therefore cannot figure out how combine these two things into a single HoloMap.

Yes, the two HoloMaps uses different key Dimensions. These are related to the axis of the seismic survey which not coincide with the XY axis of the plot. For you to imagine it, my key Dimensions are the height and width of a rectangle where each one of these were calculated using a function and a DataFrame of the seismic data.

If that's the case, I'm not sure what you are trying to achieve with overlaying them.  If two holomaps A and B share a key dimension, e.g. time, then overlaying them will overlay the frames from A and B that have the same time value.   But if holomap A is indexed over time, and holomap B is indexed over height; overlaying them doesn't mean anything -- there is no value for A that could ever match one in B.  Sounds like they should just be next to each other, as a layout not an overlay, as these are two independent things.


Rething the controllers approach?

I love this addon and think it's great. Integration only took 2 minutes. Then in my project I wanted to add a dynamic document title, which very strongly correlates to the final breadcrumb. If I have "Edit post" as the final breadcrumb then I would also like "Edit post" in the title. (Also the same dynamic segment, "Edit Hello world" if the post was called "Hello world")
I found this addon that does that:
https://github.com/kimroen/ember-cli-document-title
But they want the title logic in the Route. I think it makes sense because to put it in the Route because it sets up the model anyway. And it seems to be the way forward with the whole pods and routable components approach ember is moving towards. At least it would be nice to have a choice where to put it. What do you think? I'd be more than happy to make a pull request if you think it would make it in to master.
If not please forgive me, I'm kinda new to Ember!

That's a good point point – it seems like the breadcrumb info may need to be moved out of the controllers to be compatible with future versions of Ember.
I'm not sure yet what the right approach is. Personally, I'd like to see what routeable components look like, in practice, before I decide what approach to take. I will say I don't love the concept of putting this info on the route, because routes don't keep a reference to the model object by default.

+1 on this, since the intent is Ember will deprecate controllers. Perhaps a way to support both, with the roadmap to remove controller support?

Any chance that these could be added to the routes themselves?  Use this as a mixin to the router so you define the bread crumb with the route?


🚀 Feature: add sponsors page

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview

Brief blurb about both of our sponsors
Quick pitch on how to sponsor, what you get out of it
Contact us link goes to<EMAIL_ADDRESS>
Additional Info
No response

Chasen has claimed this issue! :-)


Add Array.from to polyfills

Fixes crash on book details page in IE11

This fixes https://github.com/GlobalDigitalLibraryio/issues/issues/463


Deleted Messages should be  by default

This was fixed as part of the rewrite for Minecraft 1.11.2.


No EOD Tokens in EleutherAI/pile-deduped-pythia-preshuffled

According to the 20B_tokenizer.json, the end of document (EOD) token has id 0 and is denoted <|endoftext|>. Some people have raised in ealier issues that there are no EOD tokens in EleutherAI/pile-deduped-pythia-preshuffled. This issue seems to be standing since January 2024. I processed the pile as instructed in the README.md based on EleutherAI/pile-deduped-pythia-preshuffled. However, I can confirm that there appear to be no EOD tokens in the dataset. Beyond using the batch_viewer.py, I also started a training loop and recorded x.min() at the beginning of my forward(x) function. Both methods show that the smallest token ID is 2. From this I conclude that there are no EOD tokens in this version of the dataset. This causes serious issues for both training and evaluating on other datasets that use the EOD token (which never got gradient updates for a model trained on EleutherAI/pile-deduped-pythia-preshuffled). Would it be possible to provide a tokenized pile with 2049 tokens per sequence that does separate documents with EODs?

This issues was mentioned without replies from the team here: https://github.com/EleutherAI/pythia/issues/123#issuecomment-1882232326


Add ReconnectPolicyBuilder to SignalR TS client

Epic #8797
See https://github.com/aspnet/AspNetCore/pull/8566/files#r266168117
var reconnectPolicy =  new ReconnectPolicyBuilder()
    .withExponentialBackoff()
    .withDelayIntervals(1,2,5,10, 30)
    .maxRetries(5)  //These last two options wouldn't be used with the withDelayIntervals option
    .withConstantDelay(10)
    .build()

We'd have to consider how to best handle conflicting options being configured.

Triage: This seems like it's a solution waiting for customer problems ;). As soon as we find a need for more configuration in our default policy, we can add this.


[Request] Create toml file on profile edit instead of on game launch

The item/enemy randomizer and the Fog gate randomizer have a merge other mod functionality that helps improve compatibility. They can accept a toml file, so creating a toml file before launching the game could allow someone to use that functionality for troubleshooting or compatibility reasons.

Sounds like a good idea, I'll try to add it to the next release


Removing DefaultRestoreManager

DefaultRestoreManager is renamed to DefaultRestoreOperator.
Removing this file.

Pull Request Test Coverage Report for Build 2093

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.338%

Totals

Change from base Build 2084:
0.0%

Covered Lines:
8230

Relevant Lines:
8918

💛  - Coveralls


Adds PubSub example for PHP

TODO: add tests

This library relies on https://github.com/google/google-api-php-client/pull/712 for the PubSub API calls

@SurferJeffAtGoogle @tmatsuo

this might be an overkill sample... there are calls made to datastore which clutter what we're trying to do.
I can split this into two samples - datastore and pubsub - and try to simplify the pubsub part.

It's not clear to me what the app does.  I don't know what data is being
stored where and why.  An overview in the README.md would help.
On Wed, Oct 28, 2015 at 3:33 PM, Brent Shaffer<EMAIL_ADDRESS>wrote:

this might be an overkill sample... there are calls made to datastore
which clutter what we're trying to do.
I can split this into two samples - datastore and pubsub - and try to
simplify the pubsub part.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/13#issuecomment-152017954
.

Plan for this example:

Split into 2 examples - pubsub and datastore
Add pull to the pubsub example
Make pubsub example store messages in memory only, and add note when on appengine that strange behavior may happen across multiple instances.

Could we please not lead users down the wrong path in step 3?  Isn't there
another example we could show?
I got really annoyed in the cloud training class when they said "build it
like this.  But, of course you could never build a production system like
this."
On Fri, Oct 30, 2015 at 3:38 PM, Brent Shaffer<EMAIL_ADDRESS>wrote:

Plan for this example:

Split into 2 examples - pubsub and datastore
Add pull to the pubsub example
Make pubsub example store messages in memory only, and add note
when on appengine that strange behavior may happen across multiple
instances.

—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/13#issuecomment-152667278
.

@SurferJeffAtGoogle That's not the same IMHO - we aren't building production software for the users, we are building simple examples. Our samples shouldn't be opinionated in implementation detail that varies for each application.


Move kedro catalog validation schema to kedro-datasets

Description
Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
https://github.com/kedro-org/kedro/blob/144323a05a708f0656f937858f8234386d6ac34f/static/jsonschema/kedro-catalog-0.19.json#L4
move kedro-catalog-0.19.json to kedro-datasets
Context
Why is this change important to you? How would you use it? How can it benefit other users?
most dataset has moved to kedro-datasets already, it makes sense to version against kedro-datasets instead of kedro so the schema can support different versions of dataset easily.
Automation of: https://docs.kedro.org/en/stable/development/set_up_vscode.html#configuring-the-kedro-catalog-validation-schema
In addition, it's also easier for plugin to integrate with it. The json file should be packaged with the libraries, so pip install kedro-datasets should also download the data. I already did a PoC to include this in a VSCode extension, this would make future support much easier.
Possible Implementation
(Optional) Suggest an idea for implementing the addition or change.

Automatic update it via CI
Move that to kedro-datasets

Possible Alternatives
(Optional) Describe any alternative solutions or features you've considered.

Explore if the schema validation works if we keep the core Kedro dataset (LambdaDataset) and move the remaining to kedro-datasets


Build fails on Gentoo

maks@maks-gentoo ~/src/polybar (master) $ sudo ./build.sh
** Fetching submodules
** Setting build options
** Enable i3 module ------- [Y/n]: n
** Enable volume module --- [Y/n]: Y
** Enable network module -- [Y/n]: n
** Enable mpd module ------ [Y/n]: Y
** Using compiler: clang++/clang
** Executing cmake command
-- The C compiler identification is Clang 3.7.1
-- The CXX compiler identification is Clang 3.7.1
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- No build type specified; using Release
-- Using supported compiler Clang
-- No preferred c++lib specified... linking against system default
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.28")
-- ---------------------------
-- Build type: Release
-- Compiler C: /usr/bin/clang
-- Compiler C++: /usr/bin/clang++
-- Compiler flags: -Wall -Wextra -Werror
-- + release flags:: -O3 -DNDEBUG -O3
-- Linking C++ library: system default
-- --------------------------------------------
-- Build testsuite OFF
-- Enable debug logger OFF
-- Enable extra tracing OFF
-- Enable ccache support OFF
-- --------------------------------------------
-- Enable alsa support ON
-- Enable i3 support OFF
-- Enable mpd support ON
-- Enable network support OFF
-- --------------------------------------------
-- Enable X RandR ON
-- Enable X Render OFF
-- Enable X Damage OFF
-- --------------------------------------------
-- ALSA_SOUNDCARD default
-- BSPWM_SOCKET_PATH /tmp/bspwm_0_0-socket
-- BSPWM_STATUS_PREFIX W
-- CONNECTION_TEST_IP <IP_ADDRESS>
-- PATH_ADAPTER_STATUS /sys/class/power_supply/%adapter%/online
-- PATH_BACKLIGHT_VAL /sys/class/backlight/%card%/brightness
-- PATH_BACKLIGHT_MAX /sys/class/backlight/%card%/max_brightness
-- PATH_BATTERY_CAPACITY /sys/class/power_supply/%battery%/charge_now
-- PATH_BATTERY_CAPACITY_MAX /sys/class/power_supply/%battery%/charge_full
-- PATH_BATTERY_CAPACITY_PERC /sys/class/power_supply/%battery%/capacity
-- PATH_BATTERY_VOLTAGE /sys/class/power_supply/%battery%/voltage_now
-- PATH_BATTERY_RATE /sys/class/power_supply/%battery%/current_now
-- PATH_CPU_INFO /proc/stat
-- PATH_MEMORY_INFO /proc/meminfo
-- PATH_MESSAGING_FIFO /tmp/polybar_mqueue.%pid%
-- PATH_TEMPERATURE_INFO /sys/class/thermal/thermal_zone%zone%/temp
-- --------------------------------------------
-- libpolybar_static
-- Boost version: 1.56.0
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Found Freetype: /usr/lib64/libfreetype.so (found version "2.6.3")
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib64/libX11.so
-- Found X11_XCB: /usr/lib64/libX11-xcb.so
-- Checking for module 'fontconfig'
-- Found fontconfig, version 2.11.1
-- Checking for module 'xcb-proto'
-- Found xcb-proto, version 1.12
-- Found PythonInterp: /usr/bin/python2.7 (found suitable version "2.7.10", minimum required is "2.7")
-- XCB[XCB]: Found component XCB
-- Found XCB_XCB: /usr/lib64/libxcb.so
-- XCB[ICCCM]: Found component ICCCM
-- Found XCB_ICCCM: /usr/lib64/libxcb-icccm.so
-- XCB[EWMH]: Found component EWMH
-- Found XCB_EWMH: /usr/lib64/libxcb-ewmh.so
-- XCB[UTIL]: Found component UTIL
-- Found XCB_UTIL: /usr/lib64/libxcb-util.so
-- XCB[IMAGE]: Found component IMAGE
-- Found XCB_IMAGE: /usr/lib64/libxcb-image.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so
-- Searching for xcbgen with python2
-- Found xcbgen in /usr/lib64/python2.7/site-packages
-- XCB[RANDR]: Found component RANDR
-- Found XCB_RANDR: /usr/lib64/libxcb-randr.so
-- Found XCB: /usr/lib64/libxcb.so;/usr/lib64/libxcb-icccm.so;/usr/lib64/libxcb-ewmh.so;/usr/lib64/libxcb-util.so;/usr/lib64/libxcb-image.so;/usr/lib64/libxcb-randr.so
-- xpp: including xcb proto randr.xml
-- xpp: including xcb proto xproto.xml
-- Found ALSA: /usr/lib64/libasound.so (found version "1.0.29")
-- Found LibMPDClient: /usr/lib64/libmpdclient.so
-- Configuring done
-- Generating done
-- Build files have been written to: /home/maks/src/polybar/build
** Building project
Scanning dependencies of target xpp
[ 1%] Linking CXX static library libxpp.a
list: size, ['red', 'green', 'blue']
list: size, ['red', 'green', 'blue']
[ 1%] Built target xpp
Scanning dependencies of target libpolybar_static
[ 3%] Building CXX object bin/CMakeFiles/libpolybar_static.dir/adapters/alsa.cpp.o
[ 4%] Building CXX object bin/CMakeFiles/libpolybar_static.dir/adapters/mpd.cpp.o
[ 6%] Building CXX object bin/CMakeFiles/libpolybar_static.dir/components/controller.cpp.o
In file included from /home/maks/src/polybar/src/components/controller.cpp:4:
In file included from /home/maks/src/polybar/include/components/controller.hpp:7:
/home/maks/src/polybar/include/components/ipc.hpp:12:31: error: direct list
initialization of a variable with a deduced type will change meaning
in a future version of Clang; insert an '=' to avoid a change in
behavior [-Werror,-Wfuture-compat]
static constexpr auto prefix{"cmd:"};
^
=
/home/maks/src/polybar/include/components/ipc.hpp:16:31: error: direct list
initialization of a variable with a deduced type will change meaning
in a future version of Clang; insert an '=' to avoid a change in
behavior [-Werror,-Wfuture-compat]
static constexpr auto prefix{"hook:"};
^
=
/home/maks/src/polybar/include/components/ipc.hpp:20:31: error: direct list
initialization of a variable with a deduced type will change meaning
in a future version of Clang; insert an '=' to avoid a change in
behavior [-Werror,-Wfuture-compat]
static constexpr auto prefix{"action:"};
^
=
/home/maks/src/polybar/src/components/controller.cpp:427:42: error: no
matching function for call to 'strlen'
string action = message.payload.substr(strlen(ipc_action::prefix));
^~~~~~
/usr/include/string.h:394:15: note: candidate function not viable: no known
conversion from 'const std::initializer_list<const char *>' to
'const char *' for 1st argument
extern size_t strlen (const char *__s)
^
4 errors generated.
bin/CMakeFiles/libpolybar_static.dir/build.make:110: polecenia dla obiektu 'bin/CMakeFiles/libpolybar_static.dir/components/controller.cpp.o' nie powiodły się
make[2]: *** [bin/CMakeFiles/libpolybar_static.dir/components/controller.cpp.o] Błąd 1
CMakeFiles/Makefile2:273: polecenia dla obiektu 'bin/CMakeFiles/libpolybar_static.dir/all' nie powiodły się
make[1]: *** [bin/CMakeFiles/libpolybar_static.dir/all] Błąd 2
Makefile:127: polecenia dla obiektu 'all' nie powiodły się
make: *** [all] Błąd 2
** Failed to build project

(Sorry for the partially-Polish error messages at the end.)
This happens regardless of compiler (tried both GCC and Clang), build method or branch.
I think I have all the dependencies installed (except those for the modules I don't need which I try to disable in build.sh anyway, as you can see).
Maybe I'm just missing something painfully obvious, but I don't know...

hi, I just pushed 002eb08 that fixes the build errors


NNLC: use substitute.toml for fallback nnlc lookup

This enables NNLC on many more cars based on Comma's substitute.toml file. If the user's car has a direct match, that model is used, or it looks for a substitute and loads a matching model for the sub. No UI changes are necessary. If a substitute match is made, the user will know because the model name in settings will not match their car.
Comma uses the substitute.toml file to load one car's torque parameters in place of another car. This change is based on the assumption that if that works for torque parameters, it should work for NNLC models.
Tested with @smarf's '16 Outback, which has no NNLC model and is in substitute.toml pointing to SUBARU_IMPREZA which does have a NNLC model. The Impreza model loaded correctly and here's the initial feedback:

Good to point that out @zorrobyte. Even more than with exact matches, YMMV with NNLC if a substitute match is used.
Even worse is that for some models, multiple generations are squashed into a single platform on OP despite differences in EPS. Chevy Bolt is the worst that I know of. I think this is an example of Comma choosing form over function, even though they've designed a system that allows for an arbitrary number of platforms that could easily handle all such variations.
If Comma would add in all these variations, then offline controls solutions like the current NNLC (including Comma's own NNLC implementation) could be more complete, hindered only by the availability of data to train models. Their approach (I speculate) is based on the assumption that torqued can adapt to fill the gaps between cars that have been squashed to a common platform. For NNLC, that means that the only reasonably complete solution is online training of NNLC models as you drive. Of course, that is the ideal solution regardless of how granularly Comma organizes platforms.
In the meantime, hopefully this will spread more of the NNLC love until online NNLC becomes a thing.


Add verbosity flag

This should be a global option for all commands --verbose or -v.

Now that cleo's here we already have this flag, but it needs to be integrated properly.


Docs/update build guide for jan 31 2021 version/4

closes #4

Converting PR to Draft, until STL files for the controller body get updated to v3


[8.x] Default authentication & dashboard using Laravel Breeze

coverage: 94.083% (-2.5%) from 96.629%
when pulling 4a28d914f67b6076644c08b0c77f149c52409836 on 8/auth
into 68a0042861ea4f9ace68d74a49e70aa5031244e7 on 8.x.


Test repo with TF 13

Ran tests locally with TF 13, everything passed. Only code change is to require 0.12.26 or above everywhere.

Thanks for the review! Merging now.


Found few emaill addresses that does not pass the test

admin@mailserver1
example@localhost
user@localserver
user@tt
Source : https://en.wikipedia.org/wiki/Email_address
(This might be my fault, Top level domains right??)

thanks for your observations.
those mails at least "admin@mailserver1" should work although am currently away from my development PC to confirm.
will review it when I have some time.
Regards.

My bad...
User error :)
Sorry 'bout that...
-Tee-


Bugfix: ... Changed timeout to 120 seconds in conf file - still timing out after 60 seconds using docker-compose

Describe the bug
I changed the timeout to 120 seconds using the ArchiveBox.conf file and pointed my docker-compose file to that env file, however it is still timing out after 60 seconds.
Conf file:
################################################################################
## General Settings
################################################################################

#OUTPUT_DIR="output"
OUTPUT_PERMISSIONS=755
#ONLY_NEW=False
TIMEOUT=120
MEDIA_TIMEOUT=3600
#TEMPLATES_DIR="archivebox/templates"
FOOTER_INFO="Content is hosted for personal archiving purposes only."

Docker-compose file:
version: '3'

services:
    archivebox:
        container_name: archivebox
        build: .                                   # replace this with nikisweeting/archivebox to use the docker-compose.yml file as a standalone file without avoid having to clone the repo
        stdin_open: true                           # needed to be able to input URLs directly after `docker-compose up`
        tty: true                                  # needed to be able to pipe in URLs via stdin to `docker-compose exec ...`
        env_file: /home/taubin/ArchiveBox/archivebox.conf   # this feature is available starting >v0.4
        # environment:
        #     - SHOW_PROGRESS=False                  # make docker logs nicer by not writing lots of progress bar lines
        #     - MEDIA_TIMEOUT=60                     # Change media timeout
        #     - TIMEOUT=120                          # Change timeout to 2 minutes
        # volumes:
            # - ./data:/data
        command: bash -c 'echo "https://github.com/pirate/ArchiveBox" | /bin/archive; tail -f /dev/null'  # archive the Github repo homepage as a starting point so the index doesn't just show an empty list to new users
        restart: unless-stopped
        volumes:
            - ./data:/data
            - /home/taubin/ArchiveBox:/archive

    nginx:
        container_name: archivebox-nginx
        image: 'nginx'
        ports:
            - '8098:80'
        volumes:
            - ./etc/nginx/nginx.conf:/etc/nginx/nginx.conf
            - ./data:/var/www
        restart: unless-stopped

Output:
[*] [2020-07-15 21:46:42] "https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff"
    https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff
    √ output/archive/1594849026.0
      > title
        Failed: Unable to detect page title
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594849026.0;
            curl https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff | grep <title>
      > wget
      > pdf
        Failed:TimeoutExpired Command 'chromium-browser' timed out after 60 seconds
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594849026.0;
            chromium-browser --headless "--user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36" --window-size=1440,2000 --timeout=60000 --print-to-pdf https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff
      > screenshot
        Failed:TimeoutExpired Command 'chromium-browser' timed out after 60 seconds
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594849026.0;
            chromium-browser --headless "--user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36" --window-size=1440,2000 --timeout=60000 --screenshot https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff
      > dom
        Failed:TimeoutExpired Command 'chromium-browser' timed out after 60 seconds
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594849026.0;
            chromium-browser --headless "--user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36" --window-size=1440,2000 --timeout=60000 --dump-dom https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff
      > media
      > archive_org
        Failed: Failed to find "content-location" URL header in Archive.org response.
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594849026.0;
            curl --location --head --user-agent "ArchiveBox/6c4c6862e (+https://github.com/pirate/ArchiveBox/)" --max-time 60 https://web.archive.org/save/https://www.redditstatic.com/desktop2x/fonts/redesignIcon/redesignFont.49673a028235b94b800c5f37667963e5.woff

Steps to reproduce

Installed archivebox using docker-compose per the instructions on website.

Copied conf.default file to .conf

Ran archivebox with the following (for testing)

taubin@taubinserver:~$ archivebox https://www.reddit.com/r/AskUbuntu/comments/hhtoay/ubuntu_20_cpu_threads_hit_100_network_drops/
Screenshots or log output
Output still showing 60 second timeout

[+] [2020-07-15 22:01:08] "https://www.reddit.com/register/?dest=https%3A%2F%2Fwww.reddit.com%2Fr%2FAskUbuntu%2Fcomments%2Fhhtoay%2Fubuntu_20_cpu_threads_hit_100_network_drops%2F"
    https://www.reddit.com/register/?dest=https%3A%2F%2Fwww.reddit.com%2Fr%2FAskUbuntu%2Fcomments%2Fhhtoay%2Fubuntu_20_cpu_threads_hit_100_network_drops%2F
    > output/archive/1594850467
      > title
      > favicon
      > wget
      > pdf
      > screenshot
      > dom
      > media
      > archive_org
        Failed:TimeoutExpired Command 'curl' timed out after 60 seconds
        Run to see full output:
            cd /home/taubin/ArchiveBox/output/archive/1594850467;
            curl --location --head --user-agent "ArchiveBox/6c4c6862e (+https://github.com/pirate/ArchiveBox/)" --max-time 60 https://web.archive.org/save/https://www.reddit.com/register/?dest=https%3A%2F%2Fwww.reddit.com%2Fr%2FAskUbuntu%2Fcomments%2Fhhtoay%2Fubuntu_20_cpu_threads_hit_100_network_drops%2F

Software versions

OS:                        Ubuntu 20.04
ArchiveBox version:        10799e4
Python version:            Python 3.8.2
Chrome version:            Chromium 84.0.4147.89 snap

Can you run archivebox config --get TIMEOUT and post the output here.

Using the django branch errors on me entirely:
taubin@taubinserver:~/ArchiveBox/bin$ archivebox config --get TIMEOUT
Traceback (most recent call last):
  File "/home/taubin/ArchiveBox/bin/archivebox", line 7, in <module>
    from .cli import main
ModuleNotFoundError: No module named 'archivebox'

git checkout django
git pull
pip install -e .
cd output
archivebox init
archivebox config --get TIMEOUT

Sorry about that.
taubin@taubinserver:~/ArchiveBox/output$ archivebox config --get TIMEOUT
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
[i] [2020-07-16 20:59:24] ArchiveBox v0.4.3: archivebox config --get TIMEOUT
    > /home/taubin/ArchiveBox/output

TIMEOUT=60

Ok good, and after this?
archivebox config --set TIMEOUT=3600
archivebox config --get TIMEOUT

That worked, thank you very much!


Update Gradle wrapper to 5.6.3

Summary
Gradle wrapper 5.6.3
Changelog
[Android] [Changed] - Gradle wrapper 5.6.3
Test Plan
Builds successfully.

please update template too

@dulmandakh - Oh yeah, of course! Thanks for the reminder! :+1:


[DUOS-2120][risk=medium] Implement Save for Dataset V3 Endpoint

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2120

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

This looks good but I'd love to confirm that we're not storing dates without timezones (just want to make sure we're not storing partial dates since that's tough/impossible to reconstitute)

👍, I made it default to UTC if not provided by the user


Option to show Real Name

Currently only the user names are shown, it would be nice to show the Real Name as an option on the board.  Also a way to choose a player based on their real name.  For our league we need to keep a separate spreadsheet that has both the user name and the real name so people can match up their games.

This could also be useful to match Challengeboards username to other software usernames, such as OCTGN


Change the default PVC size of 1Gi to 10Gi

/kind enhancement

Which functionality do you think we should update/improve?
It's 2019, even my phone comes with 32Gb already included ;)
I tried running: https://github.com/gothinkster/vue-realworld-example-app
and found that I encountered an error of running out of space within the Node.js application. I checked PVC and found that we only use 1Gi!
https://github.com/openshift/odo/blob/master/pkg/occlient/occlient.go#L1194
I suggest we:

Change the default to 10Gi
Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.
Remove the hardcoded variables of 1Gi!

Why is this needed?
Because 1Gi isn't enough at all

@cdrage do you have a suggestion on how the configuration should look like?

not sure about changing the default - see https://github.com/openshift/odo/issues/755

we can make this PVC Size configurable? maybe a preference? suggestion on param name ComponentVolumeSize

@kadel Yup. See initial description, I suggest we: Allow the ability to set the default PVC similar to how we can set the minimum CPU and memory size.

Then I would suggest to keep the PVC size to 1Gi and allow it to change. 10Gi is too big.

/close
in favor of https://github.com/openshift/odo/issues/2616


Composite viz built

Hi, @chrismattmann  Can you try this out?
Remember: you have already generated clusters.json and circle.json for this viz.
1. Click the red node(the center of the packing circle). Its cluster viz will show on the right.
2. The color of the circle shows how many attributes. The deeper color shows more same node with the same attribute.

I will talk to Kim about this and ask her for some advise.
Thanks.

Will try it now you rule thanks @dongnizh


Rage Room stylization change

Capitilizing "rage room" leads the reader to believe that the phrase is said loudly, which is untrue. Further, I refuse to believe that the vet in this story came up with the phrase rage room. He purposefully describes that they are frightened when he displays The Pipe Strip so we should assume that they are canonically sane.

I am considering italicizing "Rage Room," as it is a key, and potentially foreign, word. For now, I will merge your request.


Create one-line pip install for flash attention

Useful for running inside a notebook environment without having to cd.

As the latter two installation might cause some difficulties, we separate them and add some notes, and thus we do not use one-line installation.

Would you accept it if I break it up into lines but without the cd?


/tmp/downloads not exist

I didn't notice this bug until I was working on a machine behind proxy.
The first time when build.sh is run, it will pull portage tree then stage3 tarball and save them to ./tmp/downloads. While /tmp/downloads/ doesn't exist (maybe git ignored it as it was empty), the builder will try to pull portage tree inside container when building bob-core. There's no proxy configuration inside container so that emerge failed.
In ./inc/core.sh at line 41:
https://github.com/edannenberg/gentoo-bb/blob/956a25034bdf7f0ae3e7b2b580bf66159d845b38/inc/core.sh
[ -d ${DL_PATH} ] || mkdir ${DL_PATH}
mkdir missing -p here.
at line 88 -p is there for stage3 downloading so stage3-import is built correctly.

Oops. Thanks for reporting. Should be fixed by the weekend. Feel free to open a PR.


all rooms generate the following error : 'RoomMessagesError' object has no attribute 'chunk'

Hello again,
no matter the room i am trying to archive i get the following error:
'RoomMessagesError' object has no attribute 'chunk'
EXITCODE:1
Greetings PJ
running in docker "orangemeow/matrix-archive:1.6"

Tag 1.7 seem to have fixed it.
Thanks :)


[3.0] refactor to optimize the {@code AbstractInvoker#invoke()} code

Hi dubbo!
When reading the code of the {@code AbstractInvoker#invoke()}, find some places that can be optimized. These optimizations will make the code logic clearer.
E.g
1. Different expressions
These code in {@link AbstractInvoker#invoke()} line 151.
if (CollectionUtils.isNotEmptyMap(attachment)) {
    invocation.addObjectAttachmentsIfAbsent(attachment);
}

Map<String, Object> contextAttachments = RpcContext.getClientAttachment().getObjectAttachments();
if (contextAttachments != null && contextAttachments.size() != 0) {
    invocation.addObjectAttachmentsIfAbsent(contextAttachments);
}

We can use CollectionUtils.isNotEmptyMap instead of contextAttachments != null && contextAttachments.size() != 0, which helps to use the same expression.
2. Useless try-catch
These code in {@link AbstractInvoker#waitForResultIfSync()} line 211.
try {
    if (InvokeMode.SYNC == invocation.getInvokeMode()) {
        /**
         * NOTICE!
         * must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
         * {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
         */
        asyncResult.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
    }
} catch (InterruptedException e) {

For non-sync mode, entering the try-catch block has no meaning.
So it can be like this:
if (InvokeMode.SYNC != invocation.getInvokeMode()) {
    return;
}
try {
    /*
     * NOTICE!
     * must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
     * {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
     */
    asyncResult.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {

Although the performance of the two is not much different, the second way of writing will be more logically clear.
3. Lengthy function
The {@link AbstractInvoker#invoke()} code has 63 lines, which is close to the length of two screens, making it unclear to read.
But this part of the code is divided into three very clear parts:

adding parameters to the {@code Invocation} obj
executing the {@code doInvoke()} call and returning the {@code Result} obj
waiting for the result

So decomposing it into three sub-functions will clearly express the entire process, like:
// if invoker is destroyed due to address refresh from registry, let's allow the current invoke to proceed
if (isDestroyed()) {
    logger.warn("Invoker for service " + this + " on consumer " + NetUtils.getLocalHost() + " is destroyed, "
            + ", dubbo version is " + Version.getVersion() + ", this invoker should not be used any longer");
}

RpcInvocation invocation = (RpcInvocation) inv;

// prepare rpc invocation
prepareInvocation(invocation);

// do invoke rpc invocation and return async result
AsyncRpcResult asyncResult = doInvokeAndReturn(invocation);

// wait rpc result if sync
waitForResultIfSync(asyncResult, invocation);

return asyncResult;

The above are some optimization suggestions for {@code AbstractInvoker}, I am very happy to make my own contribution to dubbo's code quality.
Looking forward to your reply.

Thanks for your contribution. I have merged your PR.


Tutorial: Machine learning introduction

Lead: Ibrahim Alabi, Savalan Naser Neisary
Date: 20/08/2024
Start Time: 1045
Duration: 60
Description: An introduction to machine learning methods (e.g. Artificial Neural Networks, XGBoost) and applications for snow and hydrology
Details

Learning Outcomes

outcome1
outcome2
outcome3

People Developing the Tutorial (content creation, helpers, teachers)
Summary Description
Dependencies (things people should know in advance of the tutorial)
Technical Needs (GPUs? Large file storage? Unique libraries?)

Thank you for doing this, @spestana. I have a quick question: Do we assume everyone is familiar with ML basics and then move on to the methods (XGBoost, ANNs, etc)?

@Ibrahim-Ola  Thank you, Ibrahim, for these questions. We are planning a series of one-on-one meetings with the tutorial leads to discuss specific details. I am generally available Monday, Thursday, and Friday mornings. Please let us know what works for you.

@NCristea, pardon me for responding late. Friday morning is a good time for me.

@Ibrahim-Ola—Great. Would this Friday, the 5th, work for you, or are you taking some time off?

@NCristea, this Friday works for me.

Meeting on 7/5/24
Ibrahim, Nicoleta, Ziheng, Jessica, Anthony
Q: Will we assume people are coming in with basic ML knowledge?
A: Not necessarily, so it will be important to point people to introductory content in the week before the hackweek to help people prepare. We will not have time to teach the basics during the hackweek.
Our overall approach is to show what is possible with these tools and motivate people to explore. But to also say that if you want to use this for research, it's important to dig deeper and understand how things work, how to test and validate.


Enumerations do not work

When enumeration is defined, only the first value of enumeration is accepted
Example 1.
Issue: could not change from ExtraHighVolatge to HighVoltage neither via UI or API. In UI it just falls back to the first enumeration value and API gives an error that twin does not match schema.
data_model: https://github.com/Azure-Samples/digital-twins-explorer/blob/master/client/examples/PowerLine.json

Example 2.
Issue: Cant change phase code from http://iec.ch/TC57/2013/CIM-schema-cim16#PhaseCode.ABCN to anything else.
data_model: https://github.com/Haigutus/USVDM/blob/master/Tools/RDF_PARSER/entsoe_v2.4.15_2014-08-07_DTDL_V2/Terminal.json

Thanks for reporting this issue! We'll dig into it.

Thanks for reporting this issue! We'll dig into it.

Hi @Haigutus,
We have fixed the issue updating enums in the development branch. You should be able to update using the example above.
NOTE: We are working on a better UX experience for enums - but for now a string value will work.

Closing as the fix is now in the new default main branch here: https://github.com/Azure-Samples/digital-twins-explorer
Thanks again for reporting!


Fixes and enhancements. [8]

1. Fix sidebar author description for seo option in #1311.
Files modified:

Fix description for seo option in #1311.  …			e6ff3bf

What's this?
If seo is true main site description will be passed by config.subtitle option in main Hexo config.
But, there is duplicate of description by sidebar code (author & description).
So, we will separate main site description and author description and u may use theme.signature option for author description (signature).
How to use?
In Next theme config:
# Change headers hierarchy on site-subtitle (will be main site description) and on all post/pages titles for better SEO-optimization.
seo: true

In main Hexo config:
# Hexo Configuration
## Docs: https://hexo.io/docs/configuration.html
## Source: https://github.com/hexojs/hexo/

# Site
title:
subtitle:
description:
author:
signature: your Author signature here...

2. Fix VK_Like error at index page in #1381.
Files modified:

Fix VK.Widgets: object #vk_like not found.			aa4a1fb

What's this?
Uncaught Error: VK.Widgets: object #vk_like not found. on homepage if vkontakte_api.like option is enabled.

Thanks. :+1:


Add websocket support

Longpolling API remains in place but internal web client switches to web sockets for performance reasons.
Closes https://github.com/gonium/gosdm630/issues/13

Replaced by #39


In sync with latest versions of libraries

https://developer.android.com/preview/behavior-changes.html#behavior-apache-http-client
Change Log :
https://github.com/square/okhttp/blob/master/CHANGELOG.md
https://github.com/square/assertj-android/blob/master/CHANGELOG.md
http://developer.android.com/tools/support-library/index.html
http://developer.android.com/tools/revisions/gradle-plugin.html
http://developer.android.com/tools/revisions/build-tools.html
http://developer.android.com/tools/sdk/tools-notes.html
https://github.com/robolectric/robolectric/releases

What's problem with Travis?

Updated myself.