Add label check for Up-For-Grabs

Fixes some bot issues in applying the Resolution-No Activity Label to issues that already have an Up-For-Grabs label applied

PR Summary
Having many issues getting the Resolution- No Activity label applied to them even though there is an  Up-For-Grabs label applied to it
PR Context
Reduce unnecessary state changes to issues going forward
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@kilasuit Are there also plans to reopen closed issues which had the up for grabs label?

@ArmaanMcleod I expect so but that's not my decision to make at this time

For reference https://github.com/PowerShell/PowerShell/issues/21017#issuecomment-1879899256

@PowerShell/powershell-committee discussed this, we feel that 6 months is sufficient to get interest if someone in the community wants to submit a PR to fix an up-for-grabs.  However, one change we will be implementing is introducing a new manual process to query issues/PRs that have been closed as NoActivity and look for subsequent comments to decide if the issue/PR should be reopened and kept open.  Issues/PRs left perpetually open with no action is useful to anyone and only makes it harder to identify the real issues that need attention.


fix: ignore already evaluated extension modules

Pulled from https://github.com/denoland/deno/pull/19519. This is pretty much all it takes to replace init_ops() calls with init_ops_and_esm() without error, so snapshotting embedders can just use the latter whether they are creating a snapshot or consuming it.
(Using that might be a footgun without the rest of the changes from that PR because it leaves the JS source paths in the extensions list and if any were mistakenly omitted from the snapshot, the program will attempt to load them at runtime in production. That's what I attempted to address with the exclude_js_sources feature. But it was too complex and introduced differences in the test build. Maybe we can find a different safety for that which doesn't rely on conditional compilation.)

I realised it's not possible to share code between a crate's build.rs and its runtime code either way, so unifying init_ops() and init_ops_and_esm() doesn't create much deduping potential after all. Closing.


Change stipulated compatibility guarantees.

Change stipulated compatibility guarantees.
I believe the compatibility table is wrong. Taking what it currently says in the readme at face value e.g. rollbar-2.22.1 would support ruby-3.0.2. I'm pretty sure this is not what was intended, but why not be explicit?
Type of change

Maintenance

Checklists
Development

[X] Lint rules pass locally
[X] The code changed/added as part of this pull request has been covered with tests
[X] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

I'm realising that my fix is not the correct one either. Feel free to treat this as a bug-report that the compatibility table is wrong. My example in the description still holds.


Add acala and karura to landing page

File
treasury icons.zip
Add Pie chart color

#9E4ADF
#CA95F4

Preview

[ ] Biforst

[ ] Add Pie chart color

[ ] Light: #79CA47, #AFE48D

File
treasury icons 2.zip
Preview


Generate random mac address when virtual mac address is zero.

@zshi-redhat This generates a random mac address. Sending to you for review.

Hi @vrindle can you please give some info about this PR?
If I remember we copy the mac address from the interface attached to the kernel driver into the vf  mac address

Hi @vrindle can you please give some info about this PR?
If I remember we copy the mac address from the interface attached to the kernel driver into the vf mac address

I think the issue is the VF effective mac address is all zero for some vendor NICs.

@adrianchiris Could you review this PR as well? Thank you.

/lgtm

Hi, Can you provide more context in commit message on why this is needed ?

Hi, Can you provide more context in commit message on why this is needed ?

Hi, I will fix up the commit message, once the CI is passing. Essentially VF effective mac address is all zero for some vendor NICs, so we have to set the VF effective MAC address so that it passes our QE tests. I will change the commit message to make sure that it reflects why this change is necessary.

Hi, I will fix up the commit message, once the CI is passing. Essentially VF effective mac address is all zero for some vendor NICs, so we have to set the VF effective MAC address so that it passes our QE tests. I will change the commit message to make sure that it reflects why this change is necessary.

Which vendor ? why is the MAC address zero for VF netdev, this seems like a kernel (driver) bug.

iI a way (besides checking the mac) that the card is purposefully not setting the MAC? We've had other cases where the mac was not set unintentionally. With your changes, the mac will be set either way complicating the debug process.

iI a way (besides checking the mac) that the card is purposefully not setting the MAC? We've had other cases where the mac was not set unintentionally. With your changes, the mac will be set either way complicating the debug process.

Based on my dialogue with Pensando, the MAC address is not being set because it is not deemed to be necessary. The other vendors, however, do set the MAC address for the effective VF. In order to pass QE tests the VF effective MAC address must be set, hence this change.

I understand that we need to set the MAC to something, but to determine that you just check "if mac is zero, then we set it". Can we have something better than "if mac is zero", something like "if the kernel reports that the mac will not be set purposefully for this device, then we set it"?
Suppose that we have such a nob (the question here is if such a thing exists?), then we use it in place of the "if mac is zero" predicate.

I've discussed the idea to use something more clever for "if mac is zero" offline with @vrindle. At this point, we will go ahead but keep a note for future reference to come back to this


Add '_' as TriggerCharacter

Summary of the changes

I'm not totally sure how the interactions here work, but this seemed to fix it when I ran things locally. Best I could tell VSLanguageServerClient never called our endpoints because _ wasn't a valid trigger for completion to fire. Someone with a deeper understanding of Completion should let me know if this is the "right" fix though.

Fixes: https://github.com/dotnet/razor-tooling/issues/5629

Closing this since we talked offline and I'm pretty sure Taylor is correct. Thought including "_" as a trigger character does resolve the issue it's not the "right" fix.


Update sphere.py -- add pooling and max_pooling

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[ ] The documentation is up-to-date with the changes I made.
[ ] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.

Does it run ? This does not work as Torch is not in the dependencies.
I recommend not using torch, as it would imply a big dependency.
Also you need black.


Web form password

Is it possible to use a web form password, in addition to the internet and generic password types?
I'm not too sure of what the internals of the OS X security framework look like, is a web form password a variant of the internet password?

I don't think so. Apple has removed and locked down these APIs to the point that even Chrome has given up completely and deleted their Keychain integration:
https://bugs.chromium.org/p/chromium/issues/detail?id=466638


Specmatic uses auto-generated payload over examples specified in yaml

Description
As mentioned in the title while running specmatic contract tests against java spring api, instead of using the payload examples for request and response, specmatic uses auto-generated payload with random values.
Steps to reproduce

Implement a simple CRUD api in any language you prefer based on the attached yaml.
run following command java -jar specmatic.jar test src/main/resources/openapi.yaml --testBaseURL=http://localhost:3000  to test your api.
Observe the test payload that differes from the examples specified in the openapi.yaml file.

Expected behavior
Test payload equals what I specified in the examples section of the api description in the openapi.yaml file.
For the POST and GET endpoints I specified example payloads similarly as described in this article (chapter PetStore API Specification): https://specmatic.io/getting_started.html and expected my examples to be used for the test, resulting in success.

System Information:

Windows 10 Professional
Specmatic version: 2.0.20
Intellij 2023.1.4
JDK version: 19.0.1

Thanks a lot in advance and best regards

openapi.json

Hi @dennisko762 ,
Apologies for getting back to you so late. The issue stems from how the examples are structured in your OpenAPI specification. For Specmatic to use your predefined examples from reference instead of generating random values, the examples need to be:

Defined in the components.examples section
Properly referenced in both request and response with matching names

Here's how to modify your OpenAPI spec to make it work:
paths:
  /users:
    post:
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/UserInput'
            examples:
              FIRST:                                    # Example name must match response
                $ref: '#/components/examples/CREATE_USER'
      responses:
        '201':
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/User'
              examples:
                FIRST:                                  # Example name must match request
                  $ref: '#/components/examples/USER_SAVED'

components:
  examples:
    CREATE_USER:
      value:
        gender: male
        name: name
        dateOfBirth: '2024-11-13'
        email<EMAIL_ADDRESS>        username: username
    USER_SAVED:
      value:
        id: "123"
        gender: male
        name: name
        dateOfBirth: '2024-11-13'
        email<EMAIL_ADDRESS>        username: username
  schemas:
     User:
       ...
       ...

Key points to note:

Example names in request and response must match (e.g., "FIRST") for Specmatic to correlate them
Examples should be defined under components.examples, not inside schema definitions
Reference examples using $ref in your operations

After making these changes, Specmatic will use your predefined examples instead of generating random values during contract testing.
Please let me know if you need any further assistance. In case the problem resolved, I would request you to close the issue.
Thanks,
Pranav

Hi @dennisko762 ,
Hope you are doing fine! We are marking this issue closed, feel free to reopen it with any followup questions if needed


Registering protocol with associated types

Hey - I do have such protocols defined:
protocol SessionService {
    associatedtype T
}

class SessionServiceDefault : SessionService {
    typealias T = Int

}

I cannot find a way to register it properly.
container.register(SessionService.self) { _ in SessionServiceDefault() }
That returns an error:

Protocol 'SessionService' can only be used as a generic constraint because it has Self or associated type requirements

Thanks @grzegorzkrukowski for pointing out the interesting error.
This is a limitation of a protocol with associated types. You get the same error if you try defining a dictionary with that protocol like:
let dict: [SessionService: Any] // Generates the same error.

Swinject also cannot use a protocol with associated types unfortunately😢

@grzegorzkrukowski please feel free to reopen this issue or open another issue if you find more problems.

i encountered the same problem. Definitly unresolvable?

@jakubvano Do you know some workaround for this please?

@jakubvano Do you know some workaround for this please?

You can paste this directly to the playground in the Swinject project.
The idea is to use boxing and type erasing.
`import Swinject
protocol Animal {
associatedtype T
}
class AnyTypedAnimal: Animal {
typealias T = Any
}
struct Box<T: Animal> {
typealias U = T
let objectType: U.Type
let object: U

init(object: U) {
    self.object = object
    self.objectType = U.self
}

}
final class Cat: Animal {
typealias T = Int
}
final class Mouse: Animal {
typealias T = String
}
let container = Container()
container.register(Box.self) { _ in Box(object: Cat()) }
container.register(Box.self) { _ in Box(object: Mouse()) }
let myCatInstance = container.resolve(Box.self)
let mouseInstance = container.resolve(Box.self)
print(container)`

Protocols with associated types can directly be referenced only as generics constraints - thus you cannot reference them directly neither in Swinject nor constructor parameters.
As @radimhalfar pointed out, boxing is one way around that.
However in DI cases you would more likely need something like Generalized existentials, which I guess we will have to wait for for quite some time...
Until then I tend to use something like this:
protocol ServiceProtocol {
      associatedtype Model
      func doSomething(with model: Model)
}

class Service<Model>: ServiceProtocol {
    func doSomething(with model: Model) {
        fatalError()
    }
}

typealias IntService = Service<Int>

final class IntServiceImpl: IntService {
   func doSomething(with model: Int) {
      // real implementation
   }
}

container.autoregister(IntService.self, initializer: IntServiceImpl.init)

It is kinda ugly, doesn't work in all cases and can take a while to get used to, but it is the best I've came up with for tackling this kind of problem.

@radimhalfar @jakubvano Thanks guys 👍


Error: "Cannot lower to IR Expr" when using a function as a group's keys

I was trying to see if I could abstract out the group by keys into a function, and broke the compiler instead.
The following query in the playground:
func compute_keys row -> [row.x, row.y]

from T
group [(from | compute_keys)] (
  derive x = y + 1
)

Produces the following error:

"Cannot lower to IR expr: Expr { id: Some(13), kind: Closure(Closure { name: None, body: Expr { id: None, kind: FuncCall(FuncCall { name: Expr { id: None, kind: Ident(Ident { path: [], name: \"compute_keys\" }), span: Some(span-chars-64-76), target_id: None, ty: None, needs_window: false, alias: None }, args: [Expr { id: Some(10), kind: Closure(Closure { name: Some(Ident { path: [\"std\"], name: \"from\" }), body: Expr { id: None, kind: Literal(Null), span: Some(span-chars-968-972), target_id: None, ty: None, needs_window: false, alias: None }, body_ty: Some(table<[]>), args: [Expr { id: None, kind: Ident(Ident { path: [], name: \"_pip_val\" }), span: None, target_id: None, ty: None, needs_window: false, alias: None }], params: [FuncParam { name: \"default_db.source\", ty: Some(table<[]>), default_value: None }], named_params: [], env: {} }), span: Some(span-chars-57-62), target_id: None, ty: Some(func table<[]> -> table<[]>), needs_window: false, alias: None }], named_args: {} }), span: Some(span-chars-64-76), target_id: None, ty: None, needs_window: false, alias: None }, body_ty: None, args: [], params: [FuncParam { name: \"_pip_val\", ty: None, default_value: None }], named_params: [], env: {} }), span: Some(span-chars-56-77), target_id: None, ty: Some(func infer -> infer), needs_window: false, alias: None }"

Pretty sure this should just be some sort of parsing error, but if there's an actually supported way to do this, please let me know.

This error should say "expected a list of columns, found a closure".
You probably want this:
func group_xy pipeline rel -> (
    rel
    group [x, y] pipeline
)

from T
group_xy (
  derive z = rank
)

With #1397 this is now the output:
Error:
    ╭─[:61:8]
    │
 61 │ group [(from | compute_keys)] (
    ·        ──────────┬──────────
    ·                  ╰──────────── unexpected `<closure over `compute_keys <closure over `null` with 1/1 args>` with 0/1 args>`
    ·
    · Help: this is probably a 'bad type' error (we are working on that)
────╯

Not the most readable, but this will be improved when we improve typing.


feat: Support moduleResolution options NodeNext and Bundler

Currently waiting on the next release of sveltekit-superforms for a type to be exposed. Once that happens, we can merge this PR.


browser stuck: Something went wrong while generating images.

I had a stableswarmui setup working, but it started giving me
"Something went wrong while generating images."
I installed a NEW ONE in a NEW directory.
still got "Something went wrong while generating images."
nothing on the server console output, no nothing.
used anonymous brower, and that was clean.
So, there needs to be at minimum some "clear all your settings" button, if it isnt going to tell me what is actually wrong.
I'll leave my regular browser in broken mode if you want to ask me more stuff.

To clear browser cache: Control+F5
To reset params: Top right -> Quick Tools -> Reset Params to Default
If you have unexplained errors, either
A: Go to Server -> Server Configuration, set LogLevel to Debug. This will log any server issues more explicitly.
or B: Control+Shift+I to open your browser console, in case of client UI-side errors.

That indicates you had enabled the Scoring parameter (under advanced)

Huh!  Yup, that was it.
I have no idea how that could have got set???
I thought i left allthe advanced stuff alone :-(

Would be nice then, to either have a popup, "cant reach Scoring server", or better yet...
"Cant reach scoring server.. turning off scoring".


Install: kata-runtime installation fails on Ubuntu 18.04

Description of problem
My system:
4.15.0-88-generic #88-Ubuntu SMP Tue Feb 11 20:11:34 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

execute below scripts
ARCH=$(arch)
BRANCH=stable-1.9
sh -c "echo 'deb http://download.opensuse.org/repositories/home:/katacontainers:/releases:/${ARCH}:/${BRANCH}/xUbuntu_$(lsb_release -rs)/ /' > /etc/apt/sources.list.d/kata-containers.list"
curl -sL  http://download.opensuse.org/repositories/home:/katacontainers:/releases:/${ARCH}:/${BRANCH}/xUbuntu_$(lsb_release -rs)/Release.key | apt-key add -
apt-get update
apt-get -y install kata-runtime kata-proxy kata-shim

Expected result
about a weeks ago, it works, but now it doesn't work.
Actual result
the error I faced:
root@kube:/# apt-get -y install kata-runtime kata-proxy kata-shim
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 kata-runtime : Depends: kata-linux-container (= <IP_ADDRESS>-10) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

seems it depends on kata-linux-container (= <IP_ADDRESS>-10), but in the repository it has kata-linux-container (= <IP_ADDRESS>-9)

@jcvenegas - do we know of any recent packaging glitches that might have caused this?

I saw an old similar issue https://github.com/kata-containers/documentation/issues/485,
@grahamwhaley @jcvenegas can it be fix with similar ways?

Confirmed. Installed latest / master is fine, as is stable-1.10, but stable-1.9 fails as shown.
I've raised https://github.com/kata-containers/documentation/issues/629 as we need to have an explicit test for the last "n" supported stable branches.

I created a test to do the installation of OBS packages but it is running to use the latest master...I never tried with the branches https://github.com/kata-containers/packaging/blob/master/tests/run_obs_testing.sh and what this test is the installation of the packages and it runs a kata-runtime kata-env

This is an old kernel release (4.19) and the issue doesn't happen in latest guest kernel.

Closing - feel free to reopen if you hit this issue in newer versions of stable releases...


[Test] Fixes for layernorm in GQA cases (based on PR 394)

Test test...

Pipeline 9819250

Replaced with #434


[FEATURE REQUEST] Create release checklist

Is your feature request related to a problem? Please describe.
When making a release, I usually pick up on the fly which steps to go through based on previous experience. Sometimes I forget a step or tag a release incorrectly such that UPM doesn't pick it up.
Describe the solution you'd like
I'd like to formalize a release checklist on the wiki to make it easier to remember the steps to go through in the proper order to make a release.

This has been added to the Wiki here.


Fix ability to override pipeline name at submission

Pipeline naming determination order has been corrected
to first take in the user override name.
Fixes #2202

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Thanks for making this change Alan. So it's apparent that the front-end updates app_data.name in this situation (when the name is updated at submission) vs. just overriding the pipeline's name property at app_data.properties.name.
Rather than introduce the requirement that TWO locations for name be tolerated (with app_data.name taking precedence over app_data.properties.name and which the server will always need to check), why can't the front-end update app_data.properties.name at all times? Is this a remnant from when name was located only at app_data.name?
cc: @bourdakos1 @ajbozarth

Yea, this should probably be a frontend change


Consider setting ignoreFocusOut to false (the default) for quickpicks

I noticed that the Python extension sets ignoreFocusOut to true for all multi-step quick picks:
https://github.com/microsoft/vscode-python/blob/127ef2d331ec49892dd13fc23065627ca2e0a02c/src/client/common/utils/multiStepInput.ts#L133-L133
We usually say that you should only do this if you are copying and pasting into the quick or truly need it to be open while you're doing something else.
I don't think this is the case for the python quick picks so consider removing that (thus using the default value of false).

hey @TylerLeonhardt, can I work on this?

I don't think this is the case for the python quick picks so consider removing that (thus using the default value of false).

It is when using Enter Interpreter path... feature, hence closing this.


SITL drops logdata at the beginning

In SITL the logger (sdlog2) misses lots of data at the very beginning of the log.

I guess this can be closed as the trend is to switch to the new logger.


Prevent scheduled workflow from being automatically disabled

Context
The GitHub workflow docs state:

In a public repository, scheduled workflows are automatically disabled when no repository activity has occurred in 60 days.

List of affected workflows

status CI: manually re-enabled on 2024-09-10
Update GitHub project: disabled on 2023-02-07 (previous issue)
dengue ingest-to-phylo workflow: manually re-enabled on 2024-09-26

Possible solution

Keep manually re-enabling affected workflows as they are noticed to be disabled
Use the Keepalive Workflow action
Create our own workflow that runs some activity as the Nextstrain bot. I'm not entirely sure what counts as "repository activity" but a couple options:

Push dummy commit to main
Push dummy commit to a long term "keep-alive" branch
Create and delete a new branch
Create and close a new issue
Other ideas?

Manually re-enabled the workflow for now and it will run as scheduled in ~5mins

Similarly, I just re-enabled the dengue ingest-to-phylo workflow which got disabled due to repo inactivity.

Maybe also worth pointing out that I noticed the dengue workflow being disabled thanks to the status page's time-relative layout.

Any objection to adding a keepalive step to these workflows to avoid this?

^ that was one of the proposed solutions in https://github.com/nextstrain/project-board/issues/5. I've copied all the relevant parts of that issue's description into this issue's descrpition.

We should find a solution that doesn't require modifications to individual workflows. Ideally, there would be an org-wide setting provided by GitHub to customize the amount of days of inactivity before automatic disabling. I wouldn't be surprised if they provide that in the future, at which point we would have to go back and undo modifications to individual workflows if we were to use something like gautamkrishnar/keepalive-workflow.
I think there is a solution that uses the GitHub REST API for enabling/disabling workflows. There can be a central workflow (e.g. nextstrain/.github/.github/workflows/keep-alive.yml) that has a list of scheduled workflows we want to keep alive and will periodically invoke the REST API to disable/enable each workflow. I imagine this list will also change over time, so having this central list will make this easier. Of course, we may still run into the issue of that central workflow being disabled, but in that case it makes sense to use gautamkrishnar/keepalive-workflow for just the one workflow.

@victorlin I like the idea of a central workflow! Looks like gautamkrishnar/keepalive-workflow@v2 started using the GitHub API to enable workflows under the hood. Maybe we can just use gautamkrishnar/keepalive-workflow@v2 in a single action matrix to keep multiple repo workflows enabled?

I would avoid third-party code here. It feels like a risk that's not worth it.
I like Victor's idea of centralizing control over this rather than modifying each workflow.
A previous thought I'd had here, though it seems like I didn't express it, was to use Terraform run regularly to control this.

The API seems simple enough that we can call it directly and not through third-party code.
If folks are on board with the proposed approach (option 4), I'll move this issue to nextstrain/.github and make a PR there.

I'm mostly implementation-agnostic and generally agree a self-owned central workflow is probably better — the best overall solution is the one that will allow the issue to be closed 😉


Test suite is not working

Most of the unit tests are commented, we need to do an overhaul.

added more features for you to test

Added unit tests for all utilities


"An error occurred. Please, try again later."

All of your bots and your app are top notch and I'm thankful as hell for them as there's no real good alternative to them in my opinion, but, I don't know why, I simply can't convert this pack:

https://t.me/addstickers/Cat_MTHRK1

I even tried converting it manually, but no success

cached file_id was invalid. fixed now. please, try again


Negative "POA horizontal ratio" when sun behind array

Describe the bug
The function poa_horizontal_ratio gives negative values when the sun is behind the array.
To Reproduce
pvlib.irradiance.poa_horizontal_ratio(60, 90, 60, 270)
-0.99999999999999933
Expected behavior
pvlib.irradiance.poa_horizontal_ratio(60, 90, 60, 270)
0.0
Versions:

pvlib.__version__: '0.5.2'
pandas.__version__: '0.19.2'
python: 3.5.1

Additional context
Similar problems were fixed in other irradiance functions already (#526).

poa_horizonal_ratio was removed in #2021.  Shall we close this issue?


Accessing Data Outside Allocation

In the function o3d3xx::get_check_index(), it is accessing data beyond what has been allocated.  The problem is that the buffer includes the end sequence "stop\r\n".  This gets treated as another chunk in which the CHUNK_TYPE is the string "stop".  At the end of the while loop, it adds the CHUNK_SIZE to idx where this is composed of the two bytes "\r\n" and then two bytes passed the end of the allocated data.
One possible fix is to change the comparison at the beginning of the loop to buff.end()-6 to account for the extra data.
This problem was discovered by compiling the code with address sanitizer enabled.

Eyeballing the code and reading your analysis, this sounds right. As does your proposed fix. Could you:

Create a PR
In said PR, beyond the the fix, write a unit test that triggers this fix and ensures the correct behavior is happening.

Thanks for pointing this out.

I do work with other open source projects but think that it would be easier for you to write an acceptable unit test and include this one line fix.

Getting the unit tests to compile is a bit difficult without documentation.  The CMakeLists.txt file assume a default location of /usr/src/gtest with binaries in gtest_bin.  There also seems to be an assumption that you have an environment variable set to include the gtest/include directory implicitly in the compilation.  It might be easier to understand if CMakeLists.txt used:
find_package(GTest)
include_directories(${GTEST_INCLUDE_DIR})
target_link_libraries($(GTEST_LIBRARIES})

The a priori assumption of the location of GTest in /usr/src/gtest is a legacy artifact. The location should probably be made into a cache variable that can be overridden on the cmake command line. The presumed location is the location where the Ubuntu package libgtest-dev installs -- NOTE: when I originally wrote this library, the intention was to be used as a driver underneath the ROS package. At the time, using ROS implied Ubuntu. Again, legacy artifact -- but, it hasn't surfaced as an issue until now. If this is a real problem for you, please create a new issue for it, or better yet, submit a PR. If you do that latter, please keep reading...
Now, using the approach you are suggesting is something that I would not recommend. While it would work for local builds, it makes cross-compiling for embedded systems difficult. The intent in the approach employed by the library is that the gtest code gets built along with your source using your compiler (which may be for a different architecture). When cross-compiling for an embedded system, this lets us deploy the unit tests (along with a properly built GTest) to the embedded target to test directly on the H/W. The assumption is that your embedded target will not have a GTest library available.

On the gtest inclusion, I was just noting the difficulty in determining how you assumed it was configured on the computer and a suggestion to either document (since it is turned on by default) or an alternative.  By using find_package(GTest), the required entries will be visible in cmake-gui and can be modified.  The method mentioned is how I have included it in other projects and is just a suggestion.

Thanks @sgieseking for catching this bug. I have validated it using valgrind:
[...]

==31689== Conditional jump or move depends on uninitialised value(s)
==31689==    at 0x50FF71A: o3d3xx::get_chunk_index(std::vector<unsigned char, std::allocator<unsigned char> > const&, o3d3xx::image_chunk) (in /usr/lib/libo3d3xx_framegrabber.so.0.4.9)
==31689==    by 0x531AC10: o3d3xx::ImageBuffer::Organize() (in /usr/lib/libo3d3xx_image.so.0.4.9)
==31689==    by 0x5104B18: o3d3xx::FrameGrabber::WaitForFrame(o3d3xx::ByteBuffer*, long, bool, bool) (in /usr/lib/libo3d3xx_framegrabber.so.0.4.9)
==31689==    by 0x40BBAE: main (in /home/tpanzarella/dev/libo3d3xx/modules/examples/build/ex-cartesian_compare)

[...]

A patch has been applied on dev-0.4.9. This will (hopefully) get merged to the HEAD w/in 1 - 2 weeks.


rshell cp fails if connection is via UART

SD card contains only boot.py:
import pyb
pyb.usb_mode(None)
uart = pyb.UART(6, 115200)
pyb.repl_uart(uart)

Typical rshell session copying a 2.9KB file (I don't always get trace data: sometimes it just hangs)
/mnt/qnap2/data/Projects/MicroPython/micropython-micropower> cp ttest.py /flash
Traceback (most recent call last):
  File "/mnt/qnap2/python/rshell/rshell.py", line 1785, in <module>
    main()
  File "/mnt/qnap2/python/rshell/rshell.py", line 1782, in main
    shell.cmdloop(cmd_line)
  File "/mnt/qnap2/python/rshell/rshell.py", line 1084, in cmdloop
    cmd.Cmd.cmdloop(self)
  File "/usr/local/opt/python-3.4.3/lib/python3.4/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
  File "/mnt/qnap2/python/rshell/rshell.py", line 1115, in onecmd
    return cmd.Cmd.onecmd(self, line)
  File "/usr/local/opt/python-3.4.3/lib/python3.4/cmd.py", line 217, in onecmd
    return func(arg)
  File "/mnt/qnap2/python/rshell/rshell.py", line 1353, in do_cp
    if not cp(src_filename, dst_filename):
  File "/mnt/qnap2/python/rshell/rshell.py", line 364, in cp
    filesize, xfer_func=send_file_to_remote)
  File "/mnt/qnap2/python/rshell/rshell.py", line 933, in remote
    xfer_func(self, *args, **kwargs)
  File "/mnt/qnap2/python/rshell/rshell.py", line 622, in send_file_to_remote
    sys.stdout.write(chr(ord(char)))
TypeError: ord() expected a character, but string of length 0 found

This seems similar to using rshell with the WiPy: most functionality works except for cp.

ok - thanks - I'll look into this

Is this over a wireless link? Or using something like an FTDI connection?

Initial analysis suggests that the uart read buffer is getting messed up. The host side wrote 512 bytes.
I tried: modifying your boot.py to look like:
import pyb
pyb.usb_mode(None)
uart = pyb.UART(6, 115200, timeout_char=200, read_buf_len=600)
pyb.repl_uart(uart)

it got the first 198 bytes fine, and then it dropped 8 characters. I confirmed (using my logic analyzer) that the correct characters arrived on the Rx line.
I probably won't get much further tonight, so I thought I'd write this up to let you know what I found.

And it definitely looks like a software issue. I toggled a GPIO for each character received and the dropped characters were received.

Nope - I see some dropped IRQs. So that tells me that interupts were disabled or some higher priority handler was running.

Sorry for the delay getting back to you but we are separated by a few degrees of longitude :) I was testing using an FTDI adaptor lead connected by short jumpers to Pyboard UART6. The link seems reliable.

I opened: https://github.com/micropython/micropython/issues/1555
From my logic analyzer traces it looks like interupts are being disabled to do sdcard I/O and that's causing dropped characters.
I'm going to see if I can figure out how to do UART Rx using DMA.

This should be addressed by https://github.com/micropython/micropython/pull/1608

I'm still seeing this with a Pyboard connected via an FTDI adaptor. Rshell works fine except for copying files to the Pyboard SD card where it hangs. The card in a card reader shows a zero length file. This is with current firmware.

I stumbled across this last night as well on my NUCLEO 401 board. In that
case, it was copying to internal flash, and also over a non-USB serial link.
On Wed, Feb 10, 2016 at 5:07 AM, Peter Hinch<EMAIL_ADDRESS>wrote:

I'm still seeing this with a Pyboard connected via an FTDI adaptor. Rshell
works fine except for copying files to the Pyboard SD card where it hangs.
The card in a card reader shows a zero length file. This is with current
firmware.
—
Reply to this email directly or view it on GitHub
https://github.com/dhylands/upy-shell/issues/10#issuecomment-182364410.

--
Dave Hylands
Shuswap, BC, Canada
http://www.davehylands.com

@peterhinch Are you using rshell from this repository? This repository is now obsolete and has been replaced by: https://github.com/dhylands/rshell and you can now install rshell using pip.

Installing with pip sounds so easy. Unless you have boxes running rather old versions of Debian. I'll tackle that can of worms tomorrow.
On this relatively up to date laptop (Mint 17.1) I managed to install with pip3 (pip threw errors). The following presumably implies I'm running the right version:
axolotl adminpete # pip3 install rshell --upgrade
Requirement already up-to-date: rshell in /usr/local/lib/python3.4/dist-packages
Requirement already up-to-date: pyserial in /usr/local/lib/python3.4/dist-packages (from rshell)
Requirement already up-to-date: pyudev>=0.16 in /usr/local/lib/python3.4/dist-packages (from rshell)
Requirement already up-to-date: six in /usr/local/lib/python3.4/dist-packages (from pyudev>=0.16->rshell)
Cleaning up...
axolotl adminpete #

Version I'm running
[adminpete@axolotl]: ~
$ which rshell
/usr/local/bin/rshell
[adminpete@axolotl]: ~

Attempt to run
[adminpete@axolotl]: ~
$ rshell -p /dev/ftdi
Connecting to /dev/ftdi ...
Welcome to rshell. Use Control-D to exit.
/home/adminpete> cp rats9.py /sd
^CTraceback (most recent call last):
  File "/usr/local/bin/rshell", line 9, in <module>
    load_entry_point('rshell==0.0.1', 'console_scripts', 'rshell')()
  File "/usr/local/lib/python3.4/dist-packages/rshell/command_line.py", line 4, in main
    rshell.main.main()
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 2254, in main
    shell.cmdloop(cmd_line)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 1311, in cmdloop
    cmd.Cmd.cmdloop(self)
  File "/usr/lib/python3.4/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 1342, in onecmd
    return cmd.Cmd.onecmd(self, line)
  File "/usr/lib/python3.4/cmd.py", line 217, in onecmd
    return func(arg)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 1690, in do_cp
    if not cp(src_filename, dst_filename):
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 452, in cp
    filesize, xfer_func=send_file_to_remote)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 1107, in remote
    xfer_func(self, *args, **kwargs)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 738, in send_file_to_remote
    char = dev.read(1)
  File "/usr/local/lib/python3.4/dist-packages/rshell/main.py", line 1073, in read
    return self.pyb.serial.read(num_bytes)
  File "/usr/local/lib/python3.4/dist-packages/serial/serialposix.py", line 481, in read
    ready, _, _ = select.select([self.fd], [], [], timeout)
KeyboardInterrupt
[adminpete@axolotl]: ~
$
``` (It hung on the attempt to copy). Is there a way to get rshell to issue a version number?

Good question. I don't think that there is, but I'll figure out a way to do that.

I also discovered that if you have python3, you can run python3 -m ensurepip and that will get you pip3.

Thanks for the tip re pip3.
I'm puzzled you've closed this as I'm still experiencing the hanging problem. To try to settle the version issue I used pip3 to uninstall rshell and deleted the directories in /usr/local/lib/python3.4/dist-packages. I then reinstalled it with pip3 checking that the code had re-appeared in the same location. I then cloned your repository into ~/temp using
git clone https://github.com/dhylands/rshell.git

Finally I ran the following checks, which have convinced me I'm running the right version - but if I'm doing something dumb do please enlighten me!
[adminpete@axolotl]: ~
$ cd /usr/local/lib/python3.4/dist-packages/rshell
[adminpete@axolotl]: /usr/local/lib/python3.4/dist-packages/rshell
$ md5sum *.py
55537e0c645de5b4d323b1fb97873b4b  command_line.py
8671bdf67f2ff1a301d0cd0e49e901f4  getch.py
d41d8cd98f00b204e9800998ecf8427e  __init__.py
7656d1566097065c4250b531093fe2f3  main.py
da18a8d6d57694c55c1751cf53860f1d  pyboard.py
[adminpete@axolotl]: /usr/local/lib/python3.4/dist-packages/rshell

$ cd ~/temp/rshell/rshell/
[adminpete@axolotl]: ~/temp/rshell/rshell
$ md5sum *.py
55537e0c645de5b4d323b1fb97873b4b  command_line.py
8671bdf67f2ff1a301d0cd0e49e901f4  getch.py
d41d8cd98f00b204e9800998ecf8427e  __init__.py
7656d1566097065c4250b531093fe2f3  main.py
da18a8d6d57694c55c1751cf53860f1d  pyboard.py
[adminpete@axolotl]: ~/temp/rshell/rshell

$ which rshell
/usr/local/bin/rshell
[adminpete@axolotl]: ~/temp/rshell/rshell

$ alias rshell
alias rshell='rshell -p /dev/pyboard'
[adminpete@axolotl]: ~/temp/rshell/rshell
$

The closing wasn't intentional. I must have just clicked on the wrong button.

I just wanted to make sure you were using the pip installed version, because I seem to recall fixing a few issues. I'm homing in on the issue (I think). At least for me on the Nucleo. I suspect that your problem is somehow related. Could you try with --buffer-size=30 and see if that makes any difference?

Yes! A quick test was successful: I copied a small file to /sd, 'cat'-ed it and deleted it all OK.

What seems to be happening is that something slowed down a bit and rshell is no long processing buffers as quickly as it used to. rshell has a default bufer size of 512, however, the UART only has a buffer of 32. This host side sends a buffer of data and waits for an ACK before sending another buffer worth of data. If the micropython side processes the data quickly enough then it can deal with more than the UART buffer worth, however, it seems like we were really close to the edge of "running in real-time" and something has slowed down enough that the python side is taking more than a character time to process each character. All it takes is one character to be dropped and the file transfer grinds to a halt.
Now to figure out a workaround.

ctrl S ctrl Q flow control in the UART driver? Alas it would need a firmware change, but perhaps a useful option.
Another one I get occasionally on a USB connection is this "serial port /dev/pyboard closed". It's benign in that you can restart the link and carry on, but I thought it worth mentioning. The sequence below was just after dropping back from the REPL with ctrl X. After the error I hit ctrl D and fired up rshell again, without resetting the Pyboard.
/mnt/qnap2/data/Projects/MicroPython/micropython-micropower> cp upower.py /flash
serial port /dev/pyboard closed
/mnt/qnap2/data/Projects/MicroPython/micropython-micropower>
[adminpete@axolotl]: /mnt/qnap2/data/Projects/MicroPython/micropython-micropower
$ rshell
Connecting to /dev/pyboard ...
Welcome to rshell. Use Control-D to exit.
/mnt/qnap2/data/Projects/MicroPython/micropython-micropower> cp upower.py /flash
/mnt/qnap2/data/Projects/MicroPython/micropython-micropower> repl
Entering REPL. Use Control-X to exit.
>
MicroPython v1.6-35-ge372e83 on 2016-02-11; PYBv1.0 with STM32F405RG
Type "help()" for more information.
>>>


PHPUnit Test for Notifications

PHPUnit Test for OrderCheck
PHPUnit Test for Portfolio
phpcs fix

Coverage increased (+3.6%) to 55.395% when pulling eb67b76ad8537973eadb114cfc6136f5d13fc1dd on ljbergmann:master into 7b1ae94de1f1b65a45ee529cbb7a5f8342d3583a on Alpha-Trader:master.


EOS-24917: Update QSG with verification info

Problem: Quick-Start-Guide(QSG) page missing with page verification info.
Solution: Added a Testing_Verification_History page and linked it to QSG page.
Signed-off-by: pavankrishnat<EMAIL_ADDRESS>
View rendered README.md

@pavankrishnat, kindly elaborate the commit message, it does not state clearly what was missing and what was added.

@pavankrishnat, why do we need to add a Tested by section? isn't it a continuous activity? cc @knekrasov

@pavankrishnat, kindly elaborate the commit message, it does not state clearly what was missing and what was added.

Added

@pavankrishnat, why do we need to add a Tested by section? isn't it a continuous activity? cc @knekrasov

As per OVA and QSG Release Process after every PI QA need to test with GIT_TAG and add GIT_TAG info for records, based on that community team will start verify.


[UI] Login and authentication

Is your feature request related to a problem? Please describe.
As part of the migration of the unitycatalog-ui repo to unitycatalog (main), referring the original UI issue: Login and authentication #65

Describe the solution you would like

Additional context

FYI @jamieknight-db


libcamera: unstable-2022-09-15 -> 0.0.1

Description of changes
Libcamera had its first tagged release so let's see if we can stick to these instead of random commits from now on: https://git.libcamera.org/libcamera/libcamera.git/tag/?h=v0.0.1
Pipewire builds fine with this and so far appears to be the only (direct) user of this lib.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

And since libcamera is getting poked, #191595 would also be nice to get in.

Diff LGTM, but I have no hardware to actually test this on.

Based on some quick poking around with bin/cam from libcamera everything seems fine.

@mweinelt mind grabbing the linked PR as well?


admin: expose listener name/address through /listener admin endpoint

Description:
The current /listeners admin endpoint only returns a JSON-encoded list of addresses/ports. If a listener config binds to port 0, the endpoint will return the port that was assigned, but if there are multiple listeners binding to port 0, there's no way to tell which listener received which port.
This PR adds a proto that contains the listener's name and address. The /listeners endpoint returns this data in both text and JSON format, similar to the /clusters admin endpoint.
Risk Level: Low (according to #6959 the /listeners admin endpoint is only used for testing)
Testing:
I updated integration_admin_test.cc to test the new output formats for the /listeners endpoint.
I also updated the tools/socket_passing.py script that's used for integration/hotrestart_test. Currently in the process of testing this locally as I can't get hostrestart_test to pass on the master branch.
Docs Changes:

new inline docs in listeners.proto
updated the admin menu description of /listeners

Release Notes:
admin: /listener endpoint now returns :ref:listener.proto<api/envoy/admin/v2alpha/listeners.proto>
Fixes #6959

One high level question- would it be simpler to  add a new field in StaticListener and DynamicListener messages of ListenerConfigDump message some thing similar to listener_bound_address ?

@snowp WDYT about moving this to /config_dump' and add listener_bound_addresshere https://github.com/envoyproxy/envoy/blob/master/api/envoy/admin/v2alpha/config_dump.proto#L59 - so that we have a complete picture of what the configuration is and what Envoy did with that config? I am not against making this change - but slight preference to having it in/config_dump`?

I don't have a super strong opinion here, /listeners seems like the place for a short description of the listeners but I can understand why having the whole picture in /config_dump would be nice. Maybe @htuch has thoughts on this from an API perspective?

I guess this is in the same category as how we treat the health check status of endpoints in EDS clusters. For historical reasons, this eluded /config_dump and was given a dedicated /clusters endpoint. An argument could be made that for symmetry, we should pursue the same strategy and have a dedicated /listeners for runtime aspects. But, I can see @ramaraochavali point. CC @mattklein123 for config_dump philosophy.

CC @mattklein123 for config_dump philosophy.

I don't have a super strong opinion on this either. I guess my mild preference would be to add this to /listeners in the sense that this is runtime data vs. config time data, which I think is the differentiation.

runtime vs config time data seems to be a good differentiator. We are trying to add some runtime information about the management server identifier in config_dump in this PR https://github.com/envoyproxy/envoy/pull/6808 - Should we revisit that or is that fine?
In this specific case, should we add both listener config address and actual address here - just as additional info? Or should we just limit to the bound address?

Should we revisit that or is that fine?

I really don't have a strong opinion, in that case putting the management server ID that generated the config in the config dump seems reasonable.

In this specific case, should we add both listener config address and actual address here - just as additional info? Or should we just limit to the bound address?

I would probably do both to make it more easily consumable, but again no strong opinion.

Ok. Cool. Thanks.

In this specific case, should we add both listener config address and actual address here - just as additional info? Or should we just limit to the bound address?

I would probably do both to make it more easily consumable, but again no strong opinion.

@ramaraochavali @mattklein123 I wasn't able to find an easy way to get the original configured port for a listener in the current code because listen_socket_impl.cc overwrites the local_address_ if the configured port is 0. If there is, I'll be happy to add it to the proto.
If there are no strong opinions on this (@snowp?), I’m wondering if we could push this code as is and continue the discussion of adding an "original configured address" in the proto elsewhere. /config_dump contains this information in the meantime.
I could rename local_address in the proto to bound_address to make it clear that it represents the actual bound address for the listener if that's preferable.

@kaisen Sure. Let us move forward with this and we can add the configured address later if needed with the name change to avoid confusion.


fix: get history always return empty array

Description
fix getHistory always return empty array.
reason: the function defined in publishplugin interface is getHistory, not history.

Task Item
#minor
Screenshots

@VanyLaw looks good to me, please cherry-pick this to 1.2.2 branch as well

Coverage decreased (-0.008%) to 54.638% when pulling 10a508b6220f0966d5853b4dc876c22ec8e870a1 on wenyluo/fixHistory into a97e8e21dec23c3d6e9311875128d9f7dd7b68f9 on main.


separator for extract strategy

No need to add a separator for extract strategy. Output of extract strategy is already separated. Just need to add a separator for streamson-bin.


Enhancements

This is a broad update that addresses #139, #164, #166, #167, #168, #171, #173, and partly addresses #174 (report generation)
The Docker image has been simplified, with software updated.   Git pre-commit checks have been introduced, although broader unit testing hasn't yet been implemented.  Report scorecard generation has been introduced to the processing workflow, but the previous approach of report validation which relied on LaTeX via sphinx/readthedocs is yet to be ported over to the new template-based pdf generation system.
It has been tested with smaller and larger study regions, but because it addresses a couple of bugs related to outsider cases of study region definition (#167, #168), I am keen to merge this in sooner than later, so merging now.

In addition, a number of conventions and aspects of workflow were shifted around, which means previously processed regions may not work, or work as expected, with the new code.  If such issues were experienced and reprocessing wasn't desired I recommend using the previously tagged version from August 2022, https://github.com/global-healthy-liveable-cities/global_scorecards/releases/tag/0.1.


Initial changes to Unit testing

Changes within this PR include

Moving test cases from CloudhubV2ContextTest into RuntimeFabricContextTest
The only test left within CloudhubV2ContextTest  has to do with validating fields we manually override within CloudhubV2DeploymentRequest.grooy
Moved entire object validations from CloudhubV2ContextTest  to RuntimeFabricContextTest regarding the getCloudhubAppInfo call
Rearranged test order in RuntimeFabricContextTest to have two successful required and optional tests at the begining, then proceeded by failure testing

@djizatt-avio Any specific reason we are doing this?

Moving test cases from CloudhubV2ContextTest into RuntimeFabricContextTest
The only test left within CloudhubV2ContextTest  has to do with validating fields we manually override within CloudhubV2DeploymentRequest.grooy
Moved entire object validations from CloudhubV2ContextTest  to RuntimeFabricContextTest regarding the getCloudhubAppInfo call

The way the new CloudhubV2ContextTest is implemented implicitly presumes that CloudhubV2Context extends the RuntimeFabricContext, and RTF's test class verifies all that. Unless the ClouhubV2ContextTest has validation to assert the parent is RTF, I think It is safer to have tests in both classes instead of assuming something about the implementation and skipping tests.

@manikmagar This is based on discussions I had with Dan.  The duplication of tests previously was resulting in very unmaintainable tests, many of which were no longer correct so the goal is to reduce the number of tests but improve the quality of them.


booking-up-for-beauty: add link and improve task with AnniversaryDate()

Hi.
I have two questions/proposals:

Do you think it will be useful to add link to https://gobyexample.com/time-formatting-parsing as well? It was helpful for me to solve this task.
I think we can make it a bit harder for passing AnniversaryDate. For example, it can take a year as a parameter:

if this argument is empty, it should print the current year anniversary,
if it's not - print required year anniversary.

In my opinion it can be useful to do more calculations in terms of working with time resources.
Let me know what do you think :)

Do you think it will be useful to add link to https://gobyexample.com/time-formatting-parsing as well? It was helpful for me to solve this task.

Parsing time strings in Go can be confusing as it works differently from other languages, so more help is always welcome!

if this argument is empty, it should print the current year anniversary

Assuming the year parameter would be an int, what exactly do you mean by "empty"?
The task currently makes the student get the current year which is something new to the task and makes the student create a date from scratch using all parameters., which is also new in the task. If we were to add on this, I think we should make the student make something else with the date functions.
Alternatively, we can make a new task, especially if there's something the exercise currently doesn't talk about that you think it should.

Do you think it will be useful to add link to https://gobyexample.com/time-formatting-parsing as well? It was helpful for me to solve this task.

Parsing time strings in Go can be confusing as it works differently from other languages, so more help is always welcome! And Go By Example is always a great source to include.

if this argument is empty, it should print the current year anniversary

Assuming the year parameter would be an int, what exactly do you mean by "empty"?
The task currently makes the student get the current year which is something new to the task and makes the student create a date from scratch using all parameters., which is also new in the task. If we were to add on this, I think we should make the student make something else with the date functions.
Alternatively, we can make a new task, especially if there's something the exercise currently doesn't talk about that you think it should.

Thanks for reply. I'll create a PR with new link then.
Regarding improvement, I was thinking about something like that:
func AnniversaryDateV2(year ...int) time.Time {
	if len(year) == 0 {
		return ...
	}
	return ...
}

But it seems to be not ideal at all so maybe you're right and it's better to have a separate task in scope of working with time..
We can get inspired by example here: https://www.sohamkamani.com/golang/time/#duration---adding-and-subtracting-time, for e.g. we have scheduled appointment at the salon and we want to notify our client how much time has left before the appointment time.

@andrerfcsantos Can this issue be closed or is there something else open to be addressed?

@junedev While the first point for the link was addressed by #2246, there's still the question if we should add something to the exercise.

@junedev While the first point for the link was addressed by #2246, there's still the question if we should add something to the exercise.

Let me know if you have any thoughts about what I wrote here: https://github.com/exercism/go/issues/2243#issuecomment-1152218842

@junedev Okay, I don't have any objections.


docs: Recommend Debian 11 & fix Python CHIP Controller how-to

Problem
What is being fixed?  Examples:

Debian 10 fails with

  Setting up Python environment.....[|]============================================================
Unexpected Python version: Python 3.7.3

Following docs/guides/python_chip_controller_building.md venv source out/python_env/bin/activate doesn't exist

Change overview

Recommend Debian 11. Debian 10 brings Python 3.7 which isn't supported anymore.
Fix Python CHIP Controller how-to

Testing
How was this tested? (at least one bullet point required)

If unit tests were added, how do they cover this issue?
If unit tests existed, how were they fixed/modified to prevent this in future?
If new unit tests are not added, why not?
If integration tests were added, how do they verify this change?
If new integration tests are not added, why not?
If manually tested, what platforms controller and device platforms were manually tested, and how?
If no testing is required, why not?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


exerice 12/11

Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

we work together


Automated cherry pick of #4109: add associated_bills & modify meter version

Cherry pick of #4109 on release/2.12.
#4109: add associated_bills & modify meter version

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@54ced32). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #4110   +/-   ##
==============================================
  Coverage                ?   6.88%
==============================================
  Files                   ?     501
  Lines                   ?   84783
  Branches                ?       0
==============================================
  Hits                    ?    5834
  Misses                  ?   78455
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.88% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ced32...6886e20. Read the comment docs.

/lgtm

/approve


/hold

/hold
do not merge
Originally posted by @sftim in https://github.com/kubernetes/website/issues/23294#issuecomment-678259244

How
???
??
?
.
.
.

/close
This seems like an accidentally opened issue.
If there's an actionable issue with documentation, @Bubba420G, feel free to open another issue describing the specific issue you're having and the page of documentation you think needs improvement.


Some examples would go a long way

For developers trying to integrate this into their apps, it would be great to see some small snippets of how this code is used (Like Elm's List docs)

Please feel free to add a pull request. Or at least tell me what is unclear, as a lot of the function have examples.

Oops, I didn't see some of the examples. And honestly as I work with this library it seems straightforward.
I'm working on an interactive Elm Color Demo page showing off Core.Colors and this repo. If it turns out well, maybe you can link to it or add it to this repo eventually.
I still tried my hand at a PR. I will probably add more to the PR as stuff comes up. I'm new to open source contributions.
This issue can be closed since there already are examples.

Thanks for expanding the docs. I would real love to have some interactive docs, as well. Worked on it for while but never finished it.

Yeah that's what I'm going for! Definitely a good way to learn more Elm

The gif only shows a few blend modes and stuff but the demo I'm working on has more.
The idea is that the user gets 2 random colors when they load the page, they can change them with the color pickers. Eventually this demo can have all the features of Elm.Color and elm-color extra and they layout can be greatly improved. What do you think?


Set the namespace in the context config so that service account namespace isnt picked up

When running the agent inside of Kubernetes, the namespace of the agent pod is being interpreted as the namespace to deploy to in the target cluster because kubectl is picking up the namespace from the service account's projected metadata in the filesystem (/run/secrets/kubernetes.io/serviceaccount/namespace).

Let's close this issue when we release #66.

Thanks for the reminder. #66 was released with 0.5.0, so I'm going to close and comment.


Translate error messages

Hello, does anyone know where the section for translations of error messages is located?
For example: " u'dsds' is not of type 'number' "
The translations that I need to do are for the types, formats, maxLength, etc.
Thank you.

Hi, have a look at e.g. #111 and #20 and let me know if you have any additional thoughts.
Thanks.


Active Object's Template Case Naming not compatible with jki sm editor

Reproduce:
Create class with AO events
Open async sm vi
Open jki sm editor
CMD case has too few '-' to register as a section in jki sm editor.
Has 8 requires 10

I fixed this in the upcoming version


Skeleton moved successfully to cmd repo

This PR is for revel/cmd#52

This PR build fail is expected one. Since corresponding PR revel/cmd#58 is not yet merged.
Abort: Failed to open file /home/travis/gopath/src/github.com/revel/revel/skeleton/.gitignore: open /home/travis/gopath/src/github.com/revel/revel/skeleton/.gitignore: no such file or directory

[ ] First merge PR revel/cmd#58 into develop branch and trigger travis build manually
[ ] Merge this PR

These sort of cross package errors are to be expected. Looks good to me.

CI is passed, merging it.


[Bug] [Monitor] Audit Log not working

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

Dolphin Scheduler Audit Log in Monitor section does not work.
There is no record in t_ds_audit_log.

What you expected to happen

Audit Log feature should function properly.

How to reproduce

Already described above.

Anything else

Already described above.

Version
dev
Are you willing to submit PR?

[x] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thank @EricGao888 to bring this up, I add milestone 3.0.0-beta-2 and label help wanted to find someone interested of this issue

org.apache.dolphinscheduler.api.service.AuditService#addAudit is not used anywhere.

org.apache.dolphinscheduler.api.service.AuditService#addAudit is not used anywhere.

Yes, this feature is bring at SOC2021, the audit data ingest has not been implementation, are you interested to finish this?

org.apache.dolphinscheduler.api.service.AuditService#addAudit is not used anywhere.

Yes, this feature is bring at SOC2021, the audit data ingest has not been implementation, are you interested to finish this? @EricGao888

Thx for the information. Recently I have several other DS issues WIP, therefore, I will be appreciated if someone else could help with this issue. IMHO, this issue is kind of urgent because users can access audit in monitor section and if they find it not working, they probably get confused.

Seems no one else has started to work on this. Currently I'm working on the auditing feature of another project. Therefore, I would like to take a look on this issue. Could anyone please assign this to me? Thx~

We have extended the audit outside DS, using the Around aspect to collect the interactive data information of the API. But it is not based on the 't_ds_audit_log' in DS. @EricGao888

Hello @WangJPLeo , may I ask whether there is any progress on this issue? Thanks

Hello @WangJPLeo , may I ask whether there is any progress on this issue? Thanks

Sorry for replying so late. Currently, all types of API operation records can be supported, and the operation details have been saved to the database, including all available information such as requests and responses. Data as follows：
display:

detail in db:

Next, I will improve the content display of resource names and operations, and submit a PR this Thursday or Friday, more design content will be described in the first pr. Finally, a working release is expected by mid-October.

Hello @WangJPLeo , may I ask whether there is any progress on this issue? Thanks

Sorry for replying so late. Currently, all types of API operation records can be supported, and the operation details have been saved to the database, including all available information such as requests and responses. Data as follows：
display:  detail in db:
Next, I will improve the content display of resource names and operations, and submit a PR this Thursday or Friday, more design content will be described in the first pr. Finally, a working release is expected by mid-October.

@WangJPLeo That's pretty cool! Thanks for the detailed reply : )

yes,org.apache.dolphinscheduler.api.service.AuditService#addAudit is not used anywhere.
I use latest v3.1.0
I dont understand why has the feature with UI, we release every version must examine ,so it it apqche product

I use v3.1.3 deploy. but also can't find audit logs. so about this problem is resolved?