add script to run depth stream after succesful calibration

Usage: python3 calibrate_and_test.py
Functionality: On succesful calibration, depth stream is automatically opened for quality verification.

LGTM.  Sorry about delay.

Thoughts @Luxonis-Brian ?

Oh thanks for the ping @Luxonis-Brandon.
Yes, @szabi-luxonis, I've used your work here successfully several times now. I believe it is OK to be released.
Thank you.

Sorry, Chrome signed me in under the wrong account.
Oh thanks for the ping @Luxonis-Brandon.
Yes, @szabi-luxonis, I've used your work here successfully several times now. I believe it is OK to be released.
Thank you.


Allow-list netty experimental VM options lines

Those are out of our control and quarkus would need a netty update to deal with this.
Closes #190 and #201. Final piece of #188.

See also: https://github.com/graalvm/mandrel/actions/runs/6204415343/job/16846916054#step:11:18054


Generalizing well-foundedness libraries to be universe polymorphic and allowing the use of well-founded orders with provable equalities

In Issue #2560: FStar.WellFounded and related libraries are not universe polymorphic. This PR makes them so.
Additionally, when using decreases {:well-founded} it used to be that if the relation depended on invariant parameters in scope, this would be rejected.
For example:

assume
val get_previous (#a:Type) (r:well_founded_relation a) (x:a)
  : option (y:a { r y x })

let rec rel_parametric (r: ℕ → well_founded_relation ℕ) (y:ℕ) (x:ℕ)
  : Tot unit (decreases {:well-founded r y x})
  = match get_previous (r y) x with
    | None → ()
    | Some z → rel_parametric r y z

The function rel_parametric would be rejected with the cryptic error
(Error 208) Cannot build termination VC with two different well-founded relations r y and r y
1 error was reported (see above)

Since when building the termination check, we would previously complain that r y is not equal to r y' where y' is the name of the formal parameter of the recursively bound function.
Now, this code is accepted, and the termination check requires proving that at each recursive call, the relation r y == r v, where v is the argument substituted for y at a recursive call site.

fyi @jaylorch


Can shader-toy support relative local require for glslify?

#pragma glslify: value_noise21 = require("..\Include\value_noise21.glsl") // not working...
#pragma glslify: simplex_noise21 = require("F:\git\shadertoy\Include\value_noise21.glsl") //works...

I think local glslify module is useful to develop daily, thus it'll be very convinent if shadertoy support it. thanks!

I don't know how glslify resolves paths and I don't think it's reasonable for us to preprocess the glslify lines. How glslify works with glsl files directly is something I don't know either right now.
For glslify packages, you can look at the demo we have, you can see that it can work without absolute paths. Simply use npm install inside your project and you can use the module name from there.

Closing this, because after closer investigation this is neither possible nor a good idea. glslify is designed as a node.js style module system, so modules are installed with npm install and paths are resolved by glslify within a project folder, that's how it should be used.


fix(Accordian Indicator): Updating themeing

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


what's supported and what not?

I'm missing what exactly is supported/functional compared to regular RDP connections made using MSTSC or full desktop on regular RDWA website.
For example I've tried connecting using the rdwebclient and it offered me clipboard, audio and printer redirection, however no option to allow drive (and other devices) redirection.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38213294-2784-2341-ac3e-77d2b017e2a2
Version Independent ID: 8d30b4c5-68df-5fa2-d7e9-ede9b406527f
Content: Set up the Remote Desktop web client for your users
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-web-client-admin.md
Product: windows-server-threshold
GitHub Login: @Heidilohr
Microsoft Alias: helohr

I would also like to know if or when it is possible to have disk redirection. Is there some kind of documentation about this topic?


beta gcp root-credentials command doesn't utilize non-default regions

Which version of kubefirst are you using?
2.2.9
Which cloud provider?
Google Cloud
Which installation type?
CLI
Which distributed Git provider?
GitHub
What is the issue?
After creating a cluster in a non-default region, such as with the flag --cloud-region us-central1, the root-credentials command still posts an api call indicating it expects the cluster in the default us-east1 and there doesn't appear to be a flag to modify this.
$ kubefirst beta gcp root-credentials
se01
Error: could not build kubernetes config for gcp cluster se01: error getting container cluster: rpc error: code = NotFound desc = Not found: projects/project-082023/locations/us-east1/clusters/se01.
error details: name = RequestInfo id = 0xb0059c9aa5e723f0 data =

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for reporting this issue @cameronraysmith! As discussed in our community, @Claywd may be able to look into this soon.

Of note, workarounds such as
kubectl -n vault get secrets/vault-unseal-secret --template='{{index .data "root-token"}}' | base64 -d

are already documented here.

yeah please assign it to me


sails-mongo: found 49 vulnerabilities (47 low, 2 critical)

Sails version: 1.0.2
Node version: v11.0.0
NPM version: 6.4.1
DB adapter name: N/A
DB adapter version: N/A
Operating system: Mac OS X 10.14

npm install sails-mongo
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

+<EMAIL_ADDRESS>added 14 packages from 8 contributors and audited 1264 packages in 6.559s
found 49 vulnerabilities (47 low, 2 critical)

Please can you fix those 49 vulnerabilities?

Ok, fixed!

Hi @aldovincenti,
We are currently logging and looking at these vulnerabilities. A good number of them come from Sails.js using third party integrations but there are some on our end too (for example a good chunk of these are from Lodash).
This might not help much but I'll say that we use Sails.js for building real client work even with these over excited warnings popping up and we have yet to encounter any issues.

Hi @aldovincenti this is definitely on our radar for this summer: https://trello.com/c/W868yIWj. In order to tidy up the Sails issues I am going to close this one but rest assured we have our eyes on these warnings.


Add support for platform-native rolling app deployments

Cloud Foundry now has beta support for rolling app deployments in the platform as an alternative to the blue-green/red-black/venerable/etc. style of "zero-downtime" cf push today.
It is still an experimental feature (first enabled by default in cf-deployment v7.6.0, but is usable via the cf v3-apply-manifest and cf v3-zdt-push commands.
Would y'all consider a PR from us (CF CAPI team) that adds experimental support for it to this resource?

totes

In an ideal world someone from CF would take over this resource, by the way - just like how they took over the BOSH deployment resource. We don't really have the bandwidth or expertise to maintain this in the long run.


rpcmethods: provide a way to query broker's clients by SHV path

This should provide administrators with a way to identify clients on mounted path without needing to go trough all connected clients.
Implements Null argument removal from https://github.com/silicon-heaven/shv-doc/issues/7
Addresses https://github.com/silicon-heaven/shv-doc/issues/10

/close
Changes are too mangled. I will submit all at one PR.


404 Not Found

Getting 404 Not Found errors when running npm install via a GitHub job...Does anyone know why this would be occurring?
npm install
  shell: /bin/bash -e {0}
npm ERR! code E404
npm ERR! 404 Not Found - GET ***yoga-layout-prebuilt/-/yoga-layout-prebuilt-1.10.0.tgz
npm ERR! 404
npm ERR! 404<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

Oops, error on my part with npm credentials.


Fix precedence with binary expressions and fn calls

Fixes #153

Seems to hurt more than it helps :(


Simplify installation

Use more conda packages instead of pip github master installs
Only deploy docs for a tag (tag format not restricted; assuming for now we'll only push tags for releases).
Use ioamdoit's "develop_install" (earthsim's develop install task was empty, as it was added before there was a package to install)
Avoid apparently bad stevedore package from erdc channel
Started to categorize dependencies
Work around https://github.com/ioam/nbsite/issues/35

Build docs every commit, but only deploy on tag (note: are we prepared to wait for the docs to build every commit?)

I think doing it only when merging to master is fine.

Environment creation takes too long for travis. Try without -q; maybe…  …

HoloViews builds have slowed down massively to the point they sometimes time out. Might this be related? I think it's also in the environment creation.

HoloViews builds have slowed down massively to the point they sometimes time out. Might this be related? I think it's also in the environment creation.

I'd only be able to guess about the cause of that without doing some investigation. But it does seem to take an age on my laptop to create the earthsim environment.

I think doing it only when merging to master is fine.

I agree, and I'm not sure what my original PR message was talking about because it doesn't look like I made the change I said I did. I've updated the message.


Help building/Installing/Using

Can somebody (or anybody reading this comment) explain how to use and setup a teapot server and client? I've tried to run the code inside this repo in various ways with tclkit, and there is a ton of missing things (licensing files) or missing compilation steps (when compiling tclparser, I had to link to the tbcload directory for a file there). It started complaining of missing tcllib stuff (running with a tclkit as all the app entries need it) but I think it needs an older tcllib version- Newest version seems to be missing files teapot needs like fileutil::magic::mimetype.
Is there any documentation describing how to build this? I feel like I'm just compiling things because its uncompiled, I have zero idea what I need to be doing. Even if I somehow got it working, I wouldnt know how to use it- No documentation seems to exist on how to run a teapot server either!
Help?

Can I assume that teapot is abandoned at this point?

did you find the doc ?

I get an error when I try to run teapot.tcl and am confused by the docs (they did not seem to provide any setup steps, yet just instructions on using commands assuming they already work):
% ./app/teapot/teapot.tcl
can't find package repository::capp
    while executing
"package require repository::capp"
    (file "./app/teapot/teapot.tcl" line 46)

I am running on MacOS Catalina


GROOVY-5163: IncompatibleClassChangeError when running groovysh

I believe this is related to GROOVY-4838.  JDK7 added an additional protected constructor to the Exception class.  By converting the CommandException class to a java class the compile vs runtime mismatch can be avoided.
I tested by compiling master with jdk6 and jdk7 and then running groovysh with both versions to verify the IncompatibleClassChangeError was no longer produced.

Fixed in 1.8.6 and 2.0.0-beta-3, thanks!


Add ef core database drop support.

Resolves https://github.com/enisn/AbpDevTools/issues/1

If you think these outputs are too much, I can convert them to the live table view, as you did for other commands. Just let me know @enisn

Thanks for your contribution 🎉 🙏
I'll check and try to merge asap.

If you think these outputs are too much, I can convert them to the live table view, as you did for other commands. Just let me know

Yeah, an interactive table might be useful. Or a report at the end of the process might be enough


Failed to configure repo 'deb https://apt.dockerproject.org/repo ubuntu-xenial main

Without more, sounds like a networking problem. If you can provide logs that show otherwise please do so.

Incomplete due to Failures -- Success: 344, Failure: 196

List of Failures (first 10 only)

 NOTE: First failure is generally the root cause.

 IMPORTANT: If opening a ticket, please include this information.

  - ID: sift-docker-repo
    SLS: sift.repos.docker
    Run#: 2
    Comment: Failed to configure repo 'deb https://apt.dockerproject.org/repo ubuntu-xenial main': Error: key retrieval failed: Executing: /tmp/tmp.SBBO009QuC/gpg.1.sh --keyserver

hkp://p80.pool.sks-keyservers.net:80
--logger-fd
1
--recv-keys
58118E89F3A912897C070ADBF76221572C52609D
gpgkeys: key 58118E89F3A912897C070ADBF76221572C52609D can't be retrieved
gpg: requesting key 2C52609D from hkp server p80.pool.sks-keyservers.net
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
- ID: undefined
SLS: sift.repos
Run#: 15
Comment: One or more requisite failed: sift.repos.docker.sift-docker-repo
- ID: autopsy
SLS: sift.packages.autopsy
Run#: 24
Comment: Problem encountered installing package(s). Additional info follows:
errors:
- Running scope as unit run-reae25fc5739e4a23a3f36737114c6972.scope.
E: Unable to correct problems, you have held broken packages.
- ID: undefined
SLS: sift.packages.docker-engine
Run#: 44
Comment: One or more requisite failed: sift.repos.docker.sift-docker-repo
- ID: ettercap-graphical
SLS: sift.packages.ettercap-graphical
Run#: 52
Comment: Problem encountered installing package(s). Additional info follows:

I tried to install it on AWS instance, then it is giving this error.

Just to give some reference, At the start of installation also at the import PGP key step. It was failing with similar error for following command:
Import the PGP Key - gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys 22598A94
But when I removed hkp:// prefix and port 80 from the keyserver path and it imported the PGP key fine:
Import the PGP Key - gpg --keyserver pgp.mit.edu --recv-keys 22598A94
But as the installation progresses, I am not finding anyway to modify the similar command line for pgp key for dockerproject.

This is an ongoing discussion between a lot of people. With our without hkp and port 80 works for some, others require it. Why, I am not sure yet. The installation process handles pulling the key, you can try and install it manually head of time though and retry.

I tried pulling the key manually ahead of time. Now it is failing with below error:

Incomplete due to Failures -- Success: 346, Failure: 194

List of Failures (first 10 only)

 NOTE: First failure is generally the root cause.

 IMPORTANT: If opening a ticket, please include this information.

  - ID: autopsy
    SLS: sift.packages.autopsy
    Run#: 24
    Comment: Problem encountered installing package(s). Additional info follows:

errors:
- Running scope as unit run-rea89978268f4465e926ebe954c7875b7.scope.
E: Unmet dependencies. Try 'apt-get -f install' with no packages (or specify a solution).
- ID: docker-engine
SLS: sift.packages.docker-engine
Run#: 44
Comment: Problem encountered installing package(s). Additional info follows:

This is an known issue that I'm attempting to reproduce to troubleshoot. See https://github.com/sans-dfir/sift/issues/337

I'm new to sfit.
Trying to get SIFT runnning on a t2.large EC2 instance.
I'm using CIS Ubuntu Linux 16.04 LTS Benchmark v<IP_ADDRESS> - Level 1-2ba49cfb-babd-43d3-81f6-3657aeb0f101-ami-015ce07051469d4ab.4 - ami-0f335ce28b726f993
SSD Volume Type: gp2
Size: 80 GiB
Errored out the last three times as follows:

Incomplete due to Failures -- Success: 522, Failure: 20

List of Failures (first 10 only)

 NOTE: First failure is generally the root cause.

 IMPORTANT: If opening a ticket, please include this information.

  - ID: sift-docker-repo
    SLS: sift.repos.docker
    Run#: 2
    Comment: Failed to configure repo 'deb https://apt.dockerproject.org/repo ubuntu-xenial main': Error: key retrieval failed: Executing: /tmp/tmp.nXADsIqK1p/gpg.1.sh --keyserver

hkp://p80.pool.sks-keyservers.net:80
--logger-fd
1
--recv-keys
58118E89F3A912897C070ADBF76221572C52609D
gpg: requesting key 2C52609D from hkp server p80.pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
- ID: openjdk-repo
SLS: sift.repos.openjdk
Run#: 12
Comment: Failed to configure repo 'openjdk-repo': Unable to add PPA 'openjdk-r/ppa'. '['apt-add-repository', '-y', 'ppa:openjdk-r/ppa']' exited with status 1: 'gpg: keyring /tmp/tmpoatz0coe/secring.gpg' created gpg: keyring /tmp/tmpoatz0coe/pubring.gpg' created
gpg: requesting key 86F44E2A from hkp server keyserver.ubuntu.com
gpg: /tmp/tmpoatz0coe/trustdb.gpg: trustdb created
gpg: key 86F44E2A: public key "Launchpad OpenJDK builds (all archs)" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: undefined
SLS: sift.repos
Run#: 17
Comment: One or more requisite failed: sift.repos.docker.sift-docker-repo, sift.repos.openjdk.openjdk-repo
- ID: undefined
SLS: sift.packages.bulk-extractor
Run#: 34
Comment: One or more requisite failed: sift.repos.openjdk.openjdk-repo
- ID: undefined
SLS: sift.packages.docker-engine
Run#: 46
Comment: One or more requisite failed: sift.repos.docker.sift-docker-repo
- ID: undefined
SLS: sift.packages.openjdk
Run#: 139
Comment: One or more requisite failed: sift.repos.openjdk.openjdk-repo
- ID: undefined
SLS: sift.packages
Run#: 257
Comment: One or more requisite failed: sift.packages.bulk-extractor.bulk-extractor, sift.packages.openjdk.openjdk, sift.packages.docker-engine.docker-engine
- ID: undefined
SLS: sift.scripts.vshot
Run#: 441
Comment: One or more requisite failed: sift.packages.bulk-extractor.bulk-extractor
- ID: undefined
SLS: sift.scripts
Run#: 442
Comment: One or more requisite failed: sift.scripts.vshot.sift-scripts-vshot
- ID: sift-config-terminal-profiles-install
SLS: sift.config.user.terminal
Run#: 476
Comment: Command "dconf load /org/gnome/terminal/ < /usr/share/sift/terminal-profiles.txt" run
This time I tried
gpg --keyserver hkp://keyserver.ubuntu.com:11371 --recv-keys 22598A94
Errored out as follows:

Incomplete due to Failures -- Success: 452, Failure: 90

List of Failures (first 10 only)

 NOTE: First failure is generally the root cause.

 IMPORTANT: If opening a ticket, please include this information.

  - ID: sift-docker-repo
    SLS: sift.repos.docker
    Run#: 2
    Comment: Failed to configure repo 'deb https://apt.dockerproject.org/repo ubuntu-xenial main': Error: key retrieval failed: Executing: /tmp/tmp.DiKymb71FD/gpg.1.sh --keyserver

hkp://p80.pool.sks-keyservers.net:80
--logger-fd
1
--recv-keys
58118E89F3A912897C070ADBF76221572C52609D
gpg: requesting key 2C52609D from hkp server p80.pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
- ID: sift-gift-repo
SLS: sift.repos.gift
Run#: 4
Comment: Failed to configure repo 'gift': Unable to add PPA 'gift/stable'. '['apt-add-repository', '-y', 'ppa:gift/stable']' exited with status 1: 'gpg: keyring /tmp/tmpj16kwwlo/secring.gpg' created gpg: keyring /tmp/tmpj16kwwlo/pubring.gpg' created
gpg: requesting key 10C598B8 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmpj16kwwlo/trustdb.gpg: trustdb created
gpg: key 10C598B8: public key "Launchpad PPA for Google Investigative Forensic Toolkit" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: sift-repo
SLS: sift.repos.sift
Run#: 7
Comment: Failed to configure repo 'sift-repo': Unable to add PPA 'sift/stable'. '['apt-add-repository', '-y', 'ppa:sift/stable']' exited with status 1: 'gpg: keyring /tmp/tmp7_gyv5xs/secring.gpg' created gpg: keyring /tmp/tmp7_gyv5xs/pubring.gpg' created
gpg: requesting key 0744BEC3 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp7_gyv5xs/trustdb.gpg: trustdb created
gpg: key 0744BEC3: public key "Launchpad PPA for SANS Investigative Forensics Toolkit" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: sift-repo-noobslab-themes
SLS: sift.repos.noobslab
Run#: 10
Comment: Failed to configure repo 'noobslab-themes': Unable to add PPA 'noobslab/themes'. '['apt-add-repository', '-y', 'ppa:noobslab/themes']' exited with status 1: 'gpg: keyring /tmp/tmp3v149v1z/secring.gpg' created gpg: keyring /tmp/tmp3v149v1z/pubring.gpg' created
gpg: requesting key F59EAE4D from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp3v149v1z/trustdb.gpg: trustdb created
gpg: key F59EAE4D: public key "Launchpad PPA for NoobsLab" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: sift-repo-noobslab-icons
SLS: sift.repos.noobslab
Run#: 11
Comment: Failed to configure repo 'noobslab-icons': Unable to add PPA 'noobslab/icons'. '['apt-add-repository', '-y', 'ppa:noobslab/icons']' exited with status 1: 'gpg: keyring /tmp/tmp0wejl7n0/secring.gpg' created gpg: keyring /tmp/tmp0wejl7n0/pubring.gpg' created
gpg: requesting key F59EAE4D from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp0wejl7n0/trustdb.gpg: trustdb created
gpg: key F59EAE4D: public key "Launchpad PPA for NoobsLab" imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: openjdk-repo
SLS: sift.repos.openjdk
Run#: 12
Comment: Failed to configure repo 'openjdk-repo': Unable to add PPA 'openjdk-r/ppa'. '['apt-add-repository', '-y', 'ppa:openjdk-r/ppa']' exited with status 1: 'gpg: keyring /tmp/tmp7_t_mgkd/secring.gpg' created gpg: keyring /tmp/tmp7_t_mgkd/pubring.gpg' created
gpg: requesting key 86F44E2A from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp7_t_mgkd/trustdb.gpg: trustdb created
gpg: key 86F44E2A: public key "Launchpad OpenJDK builds (all archs)" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)'
- ID: undefined
SLS: sift.repos
Run#: 17
Comment: One or more requisite failed: sift.repos.openjdk.openjdk-repo, sift.repos.sift.sift-repo, sift.repos.gift.sift-gift-repo, sift.repos.noobslab.sift-repo-noobslab-icons, sift.repos.noobslab.sift-repo-noobslab-themes, sift.repos.docker.sift-docker-repo
- ID: undefined
SLS: sift.packages.bitpim
Run#: 28
Comment: One or more requisite failed: sift.repos.sift.sift-repo
- ID: undefined
SLS: sift.packages.bitpim-lib
Run#: 29
Comment: One or more requisite failed: sift.repos.sift.sift-repo
- ID: undefined
SLS: sift.packages.bulk-extractor
Run#: 34
Comment: One or more requisite failed: sift.repos.sift.sift-repo, sift.repos.openjdk.openjdk-repo
Is there a way to get SIFT running on EC2? Would it be an option to provide a pre-build AMI on AWS, that could be simply used on AWS marketplace?
Please adivse?
Thank you for your help.

Please do not comment on close issues. Please open a new issue.


Update Node tutorial references to "config.primaryKey"

A reference to copy and paste code below the "config.authKey" seemed out of date with the surrounding code samples and other references to call the object "config.primaryKey"

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@SpaceShot : Thanks for your contribution to the Azure documentation! The author, @AndrewHoh, has been notified to review your proposed change.

I also found later in the document it looks like the warning that creating a collection will incur charges calls out a function that was probably in the c# documentation.  I can add to this PR as well.

@AndrewHoh - Waiting on your review on this PR. Will ping you via email as well.

Thanks for the PR @SpaceShot! These changes look great!

@sign-off

#sign-off


Pass backend name to EnergyTracker in Training scenario

Seems there is a missing required backend parameter in EnergyTracker initialization in training scenario, which causes a value error.

Thanks, can you add energy=not rocm_system() here https://github.com/huggingface/optimum-benchmark/blob/main/tests/test_api.py#L67


Add list of allowed scenario names and include in validation script

This PR adds a list of allowed scenario names and includes the validation of submitted scenarios against this list.
The implementation is such that if any illegal scenario name is encountered, no scenario is processed (and imported to the IIASA Scenario Explorer database).

pinging @benke-pik for a review


[MINOR][PYTHON][TESTS] Add init file to pyspark.ml.deepspeed.tests

What changes were proposed in this pull request?
This PR proposes to add __init__.py file to pyspark.ml.deepspeed.tests
Why are the changes needed?
To make pyspark.ml.deepspeed.tests as a canonical Python package
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master for Apache Spark 4.0.0.


PERF: drop GIL during long-running proj database calls

These calls can take hundreds of milliseconds to access the PROJ databases, during which time no other Python code in any other thread can run. Use nogil to avoid this effect.
This should be safe for these calls as they all take a separate PROJ threading context.
It's quite probable there are other calls which could use this, but these negatively affected my application and I was able to identify them. I would welcome additions to the set of calls to wrap.

[ ] Closes #xxxx
[ ] Tests added
[ ] Fully documented, including history.rst for all changes and api/*.rst for new API

It doesn't improve execution time, just makes other threads in the process more stable. It's a really hard thing to benchmark and measure unfortunately. I just was able to observe the effect on my program, but I can't really share it here.

I don't know enough about the thread-safety of PROJ

PROJ does not deal with thread safety internally. It should be managed by the user via the "context". The same context must not be used simultaneously by two different threads.
(PROJ uses the "context" to keep there caches and any global initialization. So new context, new initialization. The access to the sqlite db -proj.db- is in read only mode, and managed by sqlite3 to avoid collisions)

Thanks @tpwrules 👍

I would be interested to see if doing this with proj_create calls helps as well.


⚠ TorrentLeech has degraded performance

In 5be7d13, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 2700 ms

Resolved: TorrentLeech performance has improved in 0ae4b1e after 10 minutes.


decompiler: fix loops with shifted structure offset

Ghidra decompiler is not displaying some array accesses as well as it could. For example, if our structures are defined this way:
struct ListStruct {
    ListElement* Data;
    int ArrayNum;
};

struct ListElement {
    int Element1;
    int Element2;
    int Element3;
};

, and we are given code:
        MOV        EAX,dword ptr [ESP + 0x18]
        MOV        EBX,EAX
        DEC        EBX
        JS         LAB_00487d2f
        LEA        ESI,[EBX + EBX*0x2]
        ADD        ESI,ESI
        ADD        ESI,ESI
        LAB_StartOfLoop
        MOV        EAX,dword ptr [ESP + 0x14]
        CMP        dword ptr [ESI + EAX*0x1 + 0x4],EBP
        JZ LAB_OverStuff
        // do stuff
        LAB_OverStuff
        DEC EBX
        SUB ESI,0xc
        TEST EBX,EBX
        JNS LAB_StartOfLoop

, then decompiler produces this result:
      iStack_88c = List.ArrayNum - 1;
      iVar2 = iStack_88c * 0xc;
      if (-1 < iStack_88c) {
        do {
          if (*(int *)((int)&(List.Data)->Element2 + iVar2) == 0) {
            // do stuff
          }
          iStack_88c = iStack_88c + -1;
          iVar2 = iVar2 + -0xc;
        } while (-1 < iStack_88c);
      }

While it should (with this fix) produce this result, which is much neater and readable:
iVar2 = iStack_88c;
for (; -1 < iStack_88c; iStack_88c = iStack_88c + -1) {
    if (List.Data[iVar2].Element2 == 0) {
        // do stuff
    }
    iVar2 = iVar2 + -1;
}

The issue was caused by RulePtrArith not finding the multiplication operation (by 0xc in this case) in the pointer arithmetic expression ESI + EAX*0x1 + 0x4 (ESI is the shifted structure offset here, EAX is List.Data and 0x4 is the offset to Element2). By letting RulePtrArith recognize certain cases through CPUI_MULTIEQUAL and transforming expressions, it can create a situation where it can find the multiplier and produce better results. The expression transformation involves taking the 0xc in this case out of the -= operator and the place where iVar2 is initialized and duplicating it in every place it's used. When multiplication by 0xc is right there in the pointer arithmetic expression, RulePtrArith can find it and generate CPUI_PTRADD (addition of a number to a pointer).
Another issue was ActionNodeJoin creating CPUI_MULTIEQUALs whose output type was unknown or undefined and then later RulePropagateCopy was taking those and putting them inside CPUI_PTRADD expressions in place of the base pointer which produced now an expression where the base pointer has unknown type, and then RulePtraddUndo would see that there's a CPUI_PTRADD in which the base pointer has size that doesn't match the original size with which CPUI_PTRADD was created, so it converts the CPUI_PTRADD back to CPUI_INT_ADD (addition of two integers). This is fixed by assigning a type to the output of CPUI_MULTIEQUAL in ActionNodeJoin because everyone else seems to just be doing their job.
EDIT: It seems this "shifted structure offset" rule that transforms expressions cannot be applied if the variable that holds the "shifted offset" is stored on the stack and there's a function call in the loop body, because that function call, if passed any arguments, could potentially write to it (you never know what it was passed and whether it's a pointer to that stack location). So it only works when the "shifted offset" variable is in a register.
EDIT: Even if the function was not passed any variables, guess what, global variables exist, and those could point to that stack location, you never know. So any presence of calls in the loop makes using this rule impossible if the offset is stored on the stack.

@kkots Continuing here from https://github.com/NationalSecurityAgency/ghidra/pull/6709#issuecomment-2387755704, which is more appropriate.
I have 2 comments:

Your updated PR includes some random build files in a folder called "Ghidra Decompiler New" or so. It breaks the build as a result.
After deleting the files in 1), your PR greatly improves array indexing for me, however it also introduces endless decompilation issues. You can read more about it in https://github.com/NationalSecurityAgency/ghidra/issues/7212.

With stock latest Ghidra, I don't get endless decompilation with any function but once I add yours, i get some.

@DualTachyon Thanks for pointing this out to me! I've removed the build folder I accidentally added and took a look at what Ghidra team has done in what was linked in "... closed as completed ..." in your issue: https://github.com/NationalSecurityAgency/ghidra/commit/8a170df554f78af34b2c21db6a9d2176af9ccbec#diff-77b97aaf8abc2e5d600bbceaab1937174d220f88cf488e34dd60f7a1d6003ce7R113
This comment seems to be replacing updateType with 3 arguments with updateType with just 1 argument. All that's different here is one function just does fewer checks. Is that the fix? I've done it on my branch and testing shows it works fine and I get no issues. I've also merged Ghidra's main into my branch. Can you take a look and see if this fixes anything for you?

I've tried this solution to fix #6805, but it doesn't.  @kkots should it have?

@DualTachyon Thanks for pointing this out to me! I've removed the build folder I accidentally added and took a look at what Ghidra team has done in what was linked in "... closed as completed ..." in your issue: 8a170df#diff-77b97aaf8abc2e5d600bbceaab1937174d220f88cf488e34dd60f7a1d6003ce7R113 This comment seems to be replacing updateType with 3 arguments with updateType with just 1 argument. All that's different here is one function just does fewer checks. Is that the fix? I've done it on my branch and testing shows it works fine and I get no issues. I've also merged Ghidra's main into my branch. Can you take a look and see if this fixes anything for you?

I haven't tried your new patch yet, but if your only change is removing the "false, false" from updateType, it doesn't make a difference. I had already tried it with and without.

@DualTachyon Okay I need a way to reproduce the infinite decompilation then so I can just go into debug and breakpoint my way through it and hopefully understand why its happening. Do you have an example that hangs for you? I've looked at #7212 and don't see any .gfz file there. Btw, what is a .gfz? It's some compiled program format, like exe, which Ghidra can open normally?

How can I provide you with a file? I'm reversing some firmware I extracted from a device, and I would rather not post it in public because one of the vendors has a tendency to be litigious, even though this falls under fair use, etc.

A .gzf file is a compressed Ghidra database for sharing/backup/etc.

How can I provide you with a file?

I will post my email here but all letters will be in reverse order so that webcrawlers can't just parse it and spam it:
moc.liamg@stonkko
May edit it out later if not needed anymore.

You can remove it... It's late here, so I will upload and send you the link tomorrow.

@DualTachyon I managed to find out why it was happening and fix it, at least in that particular case, in this commit: https://github.com/NationalSecurityAgency/ghidra/pull/6718/commits/0a891f344d776ef2eafcc76246d6f2fd0e06d42e Can't guarantee it won't freeze again because that was a pretty clutch, barely-work type of fix.
It was happening because RulePtrArith was failing to recognize the array index of course, so it was deciding that the offset into the struct is 4 * (a big expression tree here), so it was indexing into the KeyEven array of CaDescHandles which starts at 0x10. That made it calculate a -0xc offset from the start of the array to offset 4 of the whole struct. Later down the road, a different rule, called RulePtrsubUndo, would see that there's a 0x4 * (something) and start walking the entire tree. Somewhere in there, it would encounter a -4 and of course distribute the multiplication to it and get 0xfffffffc * 4 which is 0xcfffffff0. Since it can't handle negative values it would decide that that is greater than the size of a KeyEven and therefore the CPUI_PTRSUB is invalid, and undo it, which makes the whole algorithm repeat. Infinitely, RulePtrArith makes a CPUI_PTRSUB, and RulePtrsubUndo undoes it. Because one can produce negative numbers, and the other can't handle them. By making RulePtrsubUndo handle negative numbers I was able to stop the freeze.
The produced result is still garbled and wrong and that requires more work, because RulePtrArith can't handle the complicated way in which the 0x4c (the size of one array element) multiplication is being constructed. It's much simpler than that and expects more trivial things. I might get around to that some day but so far I have not encountered such problem in the programs I decompile, so I personally don't need this 0x4c recognition. But hey at least my PR is not freezing and is not causing new problems that weren't there before.
I think the 0x4c problem is caused by MIPS executing an instruction after a jump like in 0x800236b0. This instruction is duplicated in 0x800236f0, which means at the moment of 0x800236f8 it always has that shift << 2. However, in Ghidra they're seen as two separate operators coming from two different if branches, and that creates a CPUI_MULTIEQUAL situation which RulePtrArith can't handle, and my PR can only handle limited cases of it, which this does not fall under.

Thanks @kkots , your updated PR fixes all endless decompilation issues I could find. (I used FindPotentialDecompilerProblems.java to check if there were more).

 Thanks for that.


expose previous image pull policy as a flag

Fixes #412 supersedes #413.
@bparees ptal

[test]

lgtm [merge]
thanks @soltysh !


null is not an object (evaluating 'RNGestureHandlerModule.State')

i am getting the above error after installing react-navigation
below is my package.json
{
"name": "CricWallet",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"test": "jest"
},
"dependencies": {
"react": "16.6.3",
"react-native": "0.58.3",
"react-navigation": "^3.1.4",
"react-redux": "^6.0.0",
"redux": "^4.0.1",
"redux-saga": "^1.0.1"
},
"devDependencies": {
"babel-core": "^7.0.0-bridge.0",
"babel-jest": "24.0.0",
"jest": "24.0.0",
"metro-react-native-babel-preset": "0.51.1",
"react-test-renderer": "16.6.3"
},
"jest": {
"preset": "react-native"
}
}
Below is the full error stack trace
null is not an object (evaluating 'RNGestureHandlerModule.State')

    GestureHandler.js:55:37
loadModuleImplementation
    require.js:321:6

    Swipeable.js:11
loadModuleImplementation
    require.js:321:6

    index.js:1
loadModuleImplementation
    require.js:321:6

    StackViewLayout.js:19
loadModuleImplementation
    require.js:321:6

    StackView.js:4
loadModuleImplementation
    require.js:321:6

    createStackNavigator.js:3
loadModuleImplementation
    require.js:321:6
createStackNavigator
    index.js:9:18
createStackNavigator
    react-navigation.js:107:45

    AppNavigator.js:4:21
loadModuleImplementation
    require.js:321:6

    App.js:15
loadModuleImplementation
    require.js:321:6

    index.js:7
loadModuleImplementation
    require.js:321:6
guardedLoadModule
    require.js:199:45
global code
    :0

This is not the right repository to post this issue. Please refer to the official react-navigation repository.
That said, it's probably because you forgot to install RN-Gesture-Handler, which is requested, check the react-navigation installation guide


Support for Azure Functions?

TRex looks great but I'm guessing that there is currently no way way it will support Azure Functions?
Are there any plans to include this (if it's even possible)?

T-Rex is shipped in two parts:

The attributes themselves for decoration of your controller/model classes
The implementation of Swashbuckle filters to hook into Swashbuckle's swagger metadata generation

The attributes themselves could theoretically be used to decorate anything. However another library would have to be created to use those attributes to generate the appropriate metadata (given that Swashbuckle can't really work against an Azure function due to how it discovers the shape of the API). That said, there has been some amazing progress in this space recently, which you can read about here.
It wouldn't take much to extend that sample, add a few more conditionals checking for the T-Rex attributes that you want to use and emitting the proper metadata. I don't personally have plans to do that at the moment, but I would be super happy if someone else did.


Fix kube-state-metrics Service in manifests-all.yaml

Service kube-state-metrics is not being created because of typo.

Sorry, didn't see this PR before.
Thanks @it-svit


No Import option

Hello there
I've installed latest release of UnityGLTF via unitypackage file, but there are only export options under the tab there is no import option. Is there anything I need to do to enable import feature

Hi,
Import is done like any other assets, you just drag and drop them into the asset folder.
At runtime, please check the examples, they show how to load and import via code.
Are you experiencing issues with this?
Bye,
Jean

Import at runtime is working fine, but just drag and drop the folder containing the .gltf and .bin files is not working for me. Using Unity 2019.3

uhm, I only drag and drop .glb files, I am not sure if .gltf and .bin are supported as an editor drag and drop feature.

.glb is not working for me as well..
I can drag and drop it into the asset folder, i can see the file, but it is not converted. I cant do anything with the file.

Hi,
Have you tried with the project distributedby Khronos or is it on a project you created yourself and then imported the necessary files? you are likely missing some scripts.
Bye,
Jean

I tried both.
Its is working in the Khronos project, but only for .glb files.
.gltf is not working for me.

No support, switching to other plugin.

Sorry for calling up an old thread but I just encountered the same problem and it seems the issue is still open.

Please try the dev branch!

Works, howerver I think it doesn't mean the issue is solved based on this repo's master branch. I'll leave the decision to you. I guess the official team has some opinion on the IPO of Unity (the company). However driving people to use other engines by not supporting GLTF in one of the most popular game engine so far really doesn't sound like a good idea (assuming that's the case). 😭

I'll merge the dev branch back to main any day now, we just identified a couple runtime issues we wanted to address first. Thanks for confirming that the dev branch works for you, that's helpful!

Please update to the latest version and open a new issue if the problem persists. Thanks!


Deploy Checklist: Expensify.cash 2021-05-24

Release Version: 1.0.53-0
Compare Changes: https://github.com/Expensify/Expensify.cash/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/Expensify.cash/pull/3012
[ ] https://github.com/Expensify/Expensify.cash/pull/3027
[x] https://github.com/Expensify/Expensify.cash/pull/3048
[ ] https://github.com/Expensify/Expensify.cash/pull/3092
[ ] https://github.com/Expensify/Expensify.cash/pull/3105
[ ] https://github.com/Expensify/Expensify.cash/pull/3106
[ ] https://github.com/Expensify/Expensify.cash/pull/3109
[ ] https://github.com/Expensify/Expensify.cash/pull/3111

cc @Expensify/applauseleads

Starting QA!

Manually updated the version from 1.0.52-6 to 1.0.53-0 after that failed to happen automatically here

Regression is finished!
No issues found today.
PRs are finished too!
No comments added.
🎉 🎉
CC @roryabraham

:shipit:


Creating a new HttpClient for every request may use all available connections

This might be a problem here

You're right, and we're not ignoring this issue, we're just not quite ready to address it yet. We were already planning to refactor this library, it just didn't make it in time for 2.1


Can not build on KDE Neon (Ubuntu 16.04)

I tried to build dxvk, but had no success, here is the output:
[24/37] Compiling C++ object 'src/dxbc/dxbc<EMAIL_ADDRESS>FAILED: src/dxbc/dxbc<EMAIL_ADDRESS>/usr/bin/x86_64-w64-mingw32-g++  -Isrc/dxbc/dxbc@sta -Isrc/dxbc -I../../../../git/dxvk/src/dxbc -I../../../../git/dxvk/./include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -MMD -MQ 'src/dxbc/dxbc<EMAIL_ADDRESS>-MF 'src/dxbc/dxbc<EMAIL_ADDRESS>-o 'src/dxbc/dxbc<EMAIL_ADDRESS>-c<EMAIL_ADDRESS>In file included from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/dxvk_include.h:4:0,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/dxvk_shader.h:5,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_include.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_common.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_chunk_isgn.h:5,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_analysis.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_analysis.cpp:1,
from src/dxbc/dxbc@sta/dxbc-unity.cpp:1:
/home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/../util/log/log_debug.h:19:15: error: expected ‘{’ before ‘::’ token
namespace dxvk::debug {
^
/home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/../util/log/log_debug.h:19:17: error: ‘debug’ in namespace ‘::’ does not name a type
namespace dxvk::debug {
^
In file included from /usr/lib/gcc/x86_64-w64-mingw32/5.3-posix/include/c++/locale:41:0,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/../util/util_string.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/../util/util_env.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/dxvk_include.h:6,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/../dxvk/dxvk_shader.h:5,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_include.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_common.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_chunk_isgn.h:5,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_analysis.h:3,
from /home/alexey/work/dxvk/dxvk-master/build.64/../../../../git/dxvk/src/dxbc/dxbc_analysis.cpp:1,
from src/dxbc/dxbc@sta/dxbc-unity.cpp:1:
/usr/lib/gcc/x86_64-w64-mingw32/5.3-posix/include/c++/bits/locale_facets_nonio.h:59:39: error: ‘locale’ has not been declared
struct __timepunct_cache : public locale::facet
^
/usr/lib/gcc/x86_64-w64-mingw32/5.3-posix/include/c++/bits/locale_facets_nonio.h:59:47: error: expected ‘{’ before ‘facet’
struct __timepunct_cache : public locale::facet
^
/usr/lib/gcc/x86_64-w64-mingw32/5.3-posix/include/c++/bits/locale_facets_nonio.h:62:7: error: expected primary-expression before ‘static’
static const _CharT*  _S_timezones[14];
^
..............
Many thanks!
Alexey

That software is hopelessly outdated. You need mingw 5.4 and GCC 7.3 in order to compile this.


Event watcher returns "*v1.Status" instead of "v1.Event" sometimes

At kubevirt we are facing some issues at client-go after upgrading to k8s-1.19 https://github.com/kubevirt/kubevirt/issues/4239
At that code we ar doing some casting from from k8s.io/apimachinery/pkg/watch/event.Object to *v1.Event but look like
sometimes we receive *v1.Status instead
We are using k8s.io/client-go => k8s.io/client-go v0.16.4 and the cluster is k8s-1.19
Could this be related to client-go version ?

watches can receive status objects when event.Type == ERROR
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/reflector.go#L459-L465
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/api/errors/errors.go#L98-L119

Could this be related to client-go version ?

No, watches have always returned status objects in error conditions.


Team 2: fix adding reviews feature for guest users

This PR:

fix adding reviews (in restaurant/views.py) for guest users

Current Performance
when guest users (users that haven't logged in) trying to add a review, there would be a message informing them that in order to add reviews, please first login
Types of Changes

[x] bug fix

Pull Request Test Coverage Report for Build #203

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 93.971%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

restaurant/views.py
1
3
33.33%

Totals

Change from base Build #200:
0.002%

Covered Lines:
2977

Relevant Lines:
3168

💛  - Coveralls


Regexp accepted by ruby but rejected by regexp_parser

$ bundle exec irb -r regexp_parser
irb(main):001:0> Regexp::Parser.parse("\\99")
/home/mutant-dev/.gem/ruby/3.2.2/gems/regexp_parser-2.8.1/lib/regexp_parser/parser.rb:592:in `block in assign_referenced_expressions': Invalid reference 9 at pos 0 (Regexp::Parser::ParserError)
	from /home/mutant-dev/.gem/ruby/3.2.2/gems/regexp_parser-2.8.1/lib/regexp_parser/parser.rb:590:in `each'
	from /home/mutant-dev/.gem/ruby/3.2.2/gems/regexp_parser-2.8.1/lib/regexp_parser/parser.rb:590:in `assign_referenced_expressions'
	from /home/mutant-dev/.gem/ruby/3.2.2/gems/regexp_parser-2.8.1/lib/regexp_parser/parser.rb:45:in `parse'
	from /home/mutant-dev/.gem/ruby/3.2.2/gems/regexp_parser-2.8.1/lib/regexp_parser/parser.rb:22:in `parse'
	from (irb):1:in `<main>'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/gems/3.2.0/gems/irb-1.6.2/exe/irb:11:in `<top (required)>'
	from /home/mutant-dev/.rubies/ruby-3.2.2/bin/irb:25:in `load'
	from /home/mutant-dev/.rubies/ruby-3.2.2/bin/irb:25:in `<top (required)>'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `load'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:58:in `kernel_load'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/cli/exec.rb:23:in `run'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/cli.rb:492:in `exec'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
	from /home/mutant-dev/.rubies/ruby-3.2.2/lib/ruby/3.2.0/bundler/cli.rb:34:in `dispatch'
	... 7 levels...
irb(main):002:0> /\99/
=> /\99/

I suspect that regexp_parser has to be as lenient when it comes to backrefs as ruby itself?

@mbj
thank you for the report! i've just released v2.8.2 with a fix. there are more details in the commit message if you're interested. that was a nice exotic quirk you found there...

thank you for the report! i've just released v2.8.2 with a fix. there are more details in the commit message if you're interested. that was a nice exotic quirk you found there...

mutant found it when I updated the rubyspec corpus test to latest rubyspec ref ;)


Consumer group in warning state with no problems

My email notifications are firing saying my consumer groups are in WARNING status, but also says 0 partitions have problems:
The Kafka consumer groups you are monitoring are currently showing problems. The following groups are in a problem state (groups not listed are OK):

Cluster:  cluster1
Group:    consumer1
Status:   WARNING
Complete: false
Errors:   0 partitions have problems

----------------------------------------------------------------------
Cluster:  cluster1
Group:    consumer2
Status:   WARNING
Complete: false
Errors:   0 partitions have problems

Is this intended behavior? I would expect them to be in a OK state at this point.  How do I debug this?

I also facing same issue, and once checking /v2/kafka/cluster/consumer/group1/status/ it shows OK always.
consumer auto commit is 5 sec
Kafka Consumer 0.9
Kafka Broker 0.9
and here is the config
`
[general]
logdir=log
logconfig=config/logging.cfg
pidfile=burrow.pid
client-id=burrow-lagchecker
group-blacklist=^(console-consumer-|python-kafka-consumer-).*$
[zookeeper]
hostname=server11.example.com
hostname=server12.example.com
hostname=server13.example.com
port=2181
timeout=120
lock-path=/burrow/notifier
[kafka "cluster1"]
broker=server1.example.com
broker=server2.example.com
broker=server3.example.com
broker=server4.example.com
broker-port=9092
zookeeper=server2.example.com
zookeeper=server3.example.com
zookeeper=server4.example.com
zookeeper-port=2181
zookeeper-path=/
offsets-topic=__consumer_offsets
[tickers]
broker-offsets=60
[lagcheck]
intervals=10
expire-group=604800
min-distance=1
zookeeper-interval=60
zk-group-refresh=300
[httpserver]
server=on
port=443
[smtp]
server=localhost
port=25
<EMAIL_ADDRESS>template=config/default-email.tmpl
[emailnotifier<EMAIL_ADDRESS>group=cluster1,topic1
interval=3600
enable=true
[notify]
interval=600`

Tried to increase the interval and change zookeeper-interval but burrow keeps sending warning alarms.
My consumer goes negative count 1-2 times out of 15 refresh (checked on kafka-manager) but why it is keep sending warning, not considering it OK when it is -ve
How can we avoid such case?

I think it's a configuration issue (and missing documentation about the configuation).
You've not set any value for threshold for the email-notifier thus making the value 0.
The following code is used to check if the notification should be sent or not:
func (emailer *EmailNotifier) Ignore(msg Message) bool {
	return int(msg.Status) < emailer.Threshold
}

Since emailer.Threshold=0 every notification will be sent regardless of the status of the message.
const (
	StatusNotFound StatusConstant = 0
	StatusOK       StatusConstant = 1
	StatusWarning  StatusConstant = 2
	StatusError    StatusConstant = 3
	StatusStop     StatusConstant = 4
	StatusStall    StatusConstant = 5
	StatusRewind   StatusConstant = 6
)

Change your configuration to:
[emailnotifier<EMAIL_ADDRESS>group=cluster1,topic1
interval=3600
enable=true
threshold=2

And only messages with Warning or above will be sent.
Documentation should be updated accordingly, not sure if I have permission to edit the page in question...

Thank you @pliljenberg
Looks like default-email.tmpl also needs to be updated.
{{if eq 1 .Status}} WARN{{else if eq 2 .Status}}  ERR{{else if eq 3 .Status}} STOP{{else if eq 4 .Status}}STALL{{end}}

@pliljenberg The threshold works good but if using multiple cluster/group to send mail then it sends mail only if all groups have issue.
if one group has Error while Other group is OK, then no mail will be sent
[emailnotifier<EMAIL_ADDRESS>group=kafka1,consumer1
group=kafka2,consumer2
interval=1
enable=true
threshold=2
in this case alert comes only if none of them is OK status

So this particular issue is the threshold setting mentioned, but the issue with emails only sending if all groups match is probably the same as #165. This seems to be an issue with the new notifier system for both slack and email that will need some work to resolve.
I'm going to close this issue and maintain the other one.


Added MLP Mixer Model

Added the mlpmixer.py file which consists of the model as well as loading the weights from hugging face

Hi @juliagsy, can you please review this PR
Thanks!

Hi @juliagsy, I have made the changes as well as added the config.json file. I'll be adding the test file in another PR.
Do let me know if there are any more changes!


WebRTC Interfaces

There now seem to be .interface.jar builds of things like the PeerConnection class. Maybe we can use those for development (as dummy classes), so that the user can provide his own version of the concrete implementation.

Superseded by #26


moco stepwise lr scheduler (bug?)

I am looking at the stepwise lr scheduler as follows (ignoring cos lr scheduler):
def adjust_learning_rate(optimizer, epoch, args):
    """Decay the learning rate based on schedule"""
    lr = args.lr
    for milestone in args.schedule:
        lr *= 0.1 if epoch >= milestone else 1.
    for param_group in optimizer.param_groups:
        param_group['lr'] = lr

and the corresponding scheduler is this:
parser.add_argument('--schedule', default=[120, 160], nargs='*', type=int,
                    help='learning rate schedule (when to drop lr by 10x)')

my understanding from the above is that at epochs 120 and 160, the learning rate should be dropped by 10x.
However, I think what these lines do:
    for milestone in args.schedule:
        lr *= 0.1 if epoch >= milestone else 1.

is to drop lr at 121,122,123.... by 10x
It kind of does not make sense to me :( or am I missing something here?
I think it should be:
    for milestone in args.schedule:
        lr *= 0.1 if epoch == milestone else 1.

or is it intended to drop lr at each epoch from 120-->160 by 10x?

My bad (Sunday blues). It is using the lr from the args to slash the lr in subsequent epochs.

Closing it as it is not a bug or an issue.


BL808 SVD Updates

The BL808 SVD file is full of TODOs/Missing registers for peripherals, and it seems to be in a dead state
Can we expect any updates to it? Missing register info / half empty PAC makes it really difficult to develop for the BL808

I created the openbouffalo/svd repo with this problem in mind.
I wanted a place where the community can maintain the SVDs independently from Bouffalo Lab since they don't seem to have the resources to actively maintain it themselves.
We did a similar thing for the bl602.. But the goal of the new repo is to consolidate the effort for the various chips.
Currently the repo only contains some (old) scripts for parsing some generated C files from the SDK to help extracting info for the SVDs.


Update radio docs for legend param

What is the context of this PR?
Legend param is required for radios. This is to update docs to reflect that
How to review
Docs make sense

 Legend param should be documented as required for radios

 Legend param should be documented as required for radios


Compute rewards by folding/pulsing on stake credentials

Currently the reward calculation is performed by computing the rewards for a single stake pool each time a block is validated within a certain range (between slot 4k/f and slot 8k/f in the epoch). In practice, on mainnet, we finish the calculation with a lot of time to spare (about a day). Moreover, since some stake pools have many more members than other, the calculation has a lot of spikes.  This PR rearranges the calculation to instead compute numStakeCreds / (4k/f) stake credentials per block. We hope that this helps with  https://github.com/input-output-hk/cardano-node/issues/3167 This change will also be necessary when we move the stake credential maps on disk.
Additionally, I have started removing support for the reward provenance. It has, unfortunately, not been a usable feature for the wallet. I have talked this over with @HeinrichApfelmus to confirm that it is okay to stop populating some of the values. This lets me clean up some of the calculation.

@nc6 @lehins I've rebased this PR on master, and attempted to address all the comments. Plus, the benchmark tests look really good!

@JaredCorduan does this affect the actual rewards that stake keys would be awarded? I mean, is the old method and new method fully compatible in terms of rewards amount?

yes, the two algorithms produce the same rewards.


Firefox Issue: use pdfjs v2.4.456 version,Error:too much recursion

Configuration:

Web browser and its version: Firefox 80.0(64 bit)
Operating system and its version:
PDF.js version: V2.4.456
Is a browser extension:

Steps to reproduce the problem:

git checkout master
git checkout v2.4.456
gulp server
Refresh the browser a few more times,
F12,   Console,
Error: too much recursion
Instantiating http://localhost:8888/node_modules/core-js/modules/es.symbol.js
Loading http://localhost:8888/node_modules/core-js/es/symbol/index.js
Loading pdfjs/core/worker.js

git checkout v2.4.456

Does it work if you skip the above line?
Please note that in general all development happens (or should happen) against the master branch, and the version mentioned above is no longer under (active) development.

gulp server

Furthermore, there's one thing missing before this line: an invocation of npm install.
It's certainly possible that an older PDF.js version doesn't work all that well with the latest dependencies, so the first thing to do when checking out an older commit is to ensure that you test with its intended npm packages; note also https://github.com/mozilla/pdf.js#getting-the-code

Refresh the browser a few more times,
[...]
Error: too much recursion

Does this happen for every reload, or only intermittently?
If it's the latter, then it's very unlikely to be an issue that we can realistically fix. Besides, as already mentioned, version v2.4.456 is no longer under development.

Without additional information, i.e. answers to all of the questions above, it's probably not meaningful to keep this issue open.
/cc @timvandermeij


Transaction chaining after another transaction or after certain block hash

The problem that you wish to solve
If we have just received the block or transaction with a specific hash, and we want to make another transaction only if the previous has been confirmed.
Description
We would like to create or submit transaction after a fixed block number and hash, or after a fixed transaction id and block number.
In case of transactions, this is called transaction chaining and may greatly improve performance.
In case of blocks, this enables other blockchain players to react much quicker to certain blockchain events.
In both cases it would greatly improve performance, while allowing higher level of safety than submission of transaction without such dependency.
Implementation suggestions
This would require additional arguments to cardano-wallet CLI that would enable these.

Unfortunately, this feature is out of scope for cardano-wallet. There are various solutions for making multiple transactions, e.g. DripDropz.


Obscure is the way of adding instance extensions through .ini files

Hi,
His issue is related to my last one about all acceleration retrieved by GetRawSensorData being equal to zero.
I looked into OpenXR code. As a matter of fact, if AngularAcceleration is not in the code at all, we can find
at line 716 : "void* DeviceAccelerationPtr = bSpaceAccelerationSupported ? &DeviceAcceleration : nullptr;"
and line 1549 : "bSpaceAccelerationSupported = IsExtensionEnabled(XR_EPIC_SPACE_ACCELERATION_NAME);"
This means not only that acceleration can be enabled in OpenXR, but that it can be through a .ini file.
Would you mind sharing the syntax in a .ini file in order to enable acceleration ?
I personaly would find nice to have a documentation on available extensions and on the .ini syntax to add them.
Best Regards,
Renaud

This is not an OpenXR thing, OpenXR does not use ini files. That extension looks like an internal Epic (Unreal Engine) thing. Unfortunately I cannot transfer this issue outside of the org so I can't move it to unreal engine, but that would be the place to ask.

Hi,
I understand, but as concerned for this, Unreal Engine answered that OpenXR was concerned, not them.
Does this mean that I have to enable this extension in C++ code ? Unfortunately, the instance is not exposed in Unreal Engine 5 (sort of) C++ code, so I can't find a location to place the line:"openxr.enableExtension(name)"
Best Regards,
Renaud Maroy
Le mardi 1 octobre 2024 à 20:13:29 UTC+2, Rylie Pavlik @.***> a écrit :
This is not an OpenXR thing, OpenXR does not use ini files. That extension looks like an internal Epic (Unreal Engine) thing. Unfortunately I cannot transfer this issue outside of the org so I can't move it to unreal engine, but that would be the place to ask.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

To enable additional extensions in Unreal, you would have to write a plugin with a class that extends IOpenXRExtensionPlugin, and implement GetRequiredExtensions() or GetOptionalExtensions(). See the OpenXREyeTracker plugin for an example.
Note that XR_EPIC_space_acceleration is not a published OpenXR extension. It is unlikely that any runtime is currently supporting it, and even if someone does, there is no guarantee it will continue working. I wouldn't rely on it in any capacity.

The extension is for one of our internal OpenXR wrappers, and is not a real registered extension supported by any public runtimes.


mergerfs: 2.25.1 -> 2.26.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mergerfs/versions.
meta.description for mergerfs is: '"A FUSE based union filesystem"'.
meta.homepage for mergerfs is: '"https://github.com/trapexit/mergerfs"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.26.0 with grep in /nix/store/lcqlpfhwd7km02pyav29bnx6ivjmgjkk-mergerfs-2.26.0
directory tree listing: https://gist.github.com/d7b2769eefa6dbcb3c645af441331738
du listing: https://gist.github.com/4aef258a58ff89303e67ad7ae1829e7c

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
mergerfs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lcqlpfhwd7km02pyav29bnx6ivjmgjkk-mergerfs-2.26.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A mergerfs https://github.com/r-ryantm/nixpkgs/archive/3561ede7f6628385f2c66ef0be815d76ed92f7cd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lcqlpfhwd7km02pyav29bnx6ivjmgjkk-mergerfs-2.26.0
ls -la /nix/store/lcqlpfhwd7km02pyav29bnx6ivjmgjkk-mergerfs-2.26.0/bin

cc @jfrankenau @makefu for testing.

@GrahamcOfBorg build mergerfs mergerfs-tools

@c0bw3b thanks for testing! I was unable to do so because i was in holidays and the one host i use mergerfs is currently shut down

No problem.
There is new commands coming with the tools pkg and they don't seem to need additional bin in their path but you can give a second look at this just to be sure, if you want to.


As a user, I would like to be able to create an itinerary by searching for an address and adding it as a waypoint to the itinerary

Resolved in PR https://github.com/WanderWise-Inc/app/pull/230 and https://github.com/WanderWise-Inc/app/pull/251

Resolved in PR https://github.com/WanderWise-Inc/app/pull/230 and https://github.com/WanderWise-Inc/app/pull/251


[QUESTION] Is there any way to reduce adminlte.min.css size?

Is there any way to downsize o speed up css loading of the adminLTE ??  If I use adminlte.min.css is almost 2 minutes loading in my 4G network. And if I use laravel mix then is app.css the one that takes minutes to load. What am I doing wrong_?

Hi @831220 , I think the mainteiners of the AdminLTE package are working to reduce the adminlte.min.css on the next release. Check next link:
https://github.com/ColorlibHQ/AdminLTE/issues/3530
Unfortutately, we can't do nothing from this project without underlying support. Based on that link, on the future maybe we can define a new option on the config file to use  the slim file without the dark mode style.

@Shidersz Thanks, Now I guess a solution can be to copy+paste in a shorter file only the css clasess that I am actually using.
Will that be a titanic task, considering adminlte size?

@831220 Considering that this package uses the AdminLTE template classes to create the main layout, and other elements, I will be hard to check what classes do you really need and the work may take long time. I believe you should open a ticket on the AdminLTE project and ask if there exists a way to build the distributed files without certain features (like dark mode) from the current master branch.
If you can accomplish that, then you can replace the files under public/vendor/adminlte/dist/ laravel folder by the new ones. Or create a new public/vendor/adminlte-custom/ and put the new files there, then edit resources/views/vendor/adminlte/master.blade.php file of this project to include the new files.

Understood! @Shidersz Thanks a lot!
I guess enabling gzip compression on my nginx will also help


Implement the regex check for roll numbers

Does this regex work?
[0-9]{2}[A-Z]{2}[0-9]{1,3}[A-Z]*[0-9]{2}  And then post-process on it to check correct departments and micro courses. Ex - 16CH3PE34

No, we can't have any * characters, because we have an upper limit on the number of characters.
13AB879THYFHYFHY09 matches your regex.
A liberal length limited regex can be: [0-9]{2}[A-Z]{2}[0-9A-Z]{5}
or [0-9]{2}[A-Z]{2}[0-9]{1}[0-9A-Z]{4}
or [0-9]{2}[A-Z]{2}[0-9A-Z]{3}[0-9]{2}
If you are interested in working on this, just open the PR with a good length limited PR. Any other discussion can continue there. :slightly_smiling_face:
Note: In any case, even if someone adds a roll number that isn't real, they won't be able to verify unless they somehow get access to the leprechaun DB. But if they do manage to get fictional roll numbers verified, they can do some bad things with applications like voting systems. (Far-fetched scenario)

Oh. Yeah, Missed that. Cool. I'll open a PR. Thanks!


Improve UTF8 handling

Summary
While we fixed the issue for UTF8, there stills a problem when we have mixed strings and UTF8 cases. When we have  for example the following data:
a = {u'eñe': 1}
info = dict(info=a)
flatten(info)
return "{}{}{}".format(previous_key, separator, new_key)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf1' in position 1: ordinal not in range(128)

Bug Fixes/New Features

check for utf8 and use u"{}{}{}".format to transform everything to utf8.

How to Verify
I've added a specific test for this case.
Side Effects
Nope
Tests
test_one_flatten_utf8_dif <- the new test
Code Reviewer(s)

@teleyinex awesome. I'll keep this open for your new commit.

I think I explained myself badly, I used the if type() check before, see this commit but this was failing for python 3, as unicode type is not named like that but str. Thus, I removed those checks and used the current solution. Would that make sense now?


unexpectedly found nil while unwrapping an Optional value

[ x] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?
I am sending an API request through a library on iOS 9.
Alamofire is integrated via Cocoapods. The library is integrated as .framework
What did you expect to happen?

Successful call
no app crash

What happened instead?
The app crashed in line 166 of ResponseSerialization.swift.
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x000000010bfc8550 libswiftCore.dylib`function signature specialization <preserving fragile attribute, Arg[2] = Dead, Arg[3] = Dead> of Swift._fatalErrorMessage (Swift.StaticString, Swift.StaticString, file : Swift.StaticString, line : Swift.UInt, flags : Swift.UInt32) -> Swift.Never + 96
    frame #1: 0x000000010b07cf2a xxxx.getter : xx.xx + 90
    frame #2: 0x000000010b06ed59 xxx (__ObjC.UIViewController) -> ()).(closure #1) + 585
    frame #3: 0x000000010b07eecf xx`xxx.((xx in _CF81D5D1EEE60C510DA740982C983586) (Swift.String) -> ()).(closure #1) + 575
    frame #4: 0x000000010b05d347 xx`xx.xx.(xx (Swift.Dictionary<Swift.String, Any>, Swift.Dictionary<Swift.String, Swift.String>, (xx.xx, Swift.String) -> ()) -> ()).(closure #1) + 871
    frame #5: 0x0000000104fb20e4 Alamofire`thunk at ResponseSerialization.swift:0
  * frame #6: 0x0000000104fae0d5 Alamofire`DataRequest.(completionHandler=0x0000000104fb2130 Alamofire`partial apply forwarder for reabstraction thunk helper from @callee_owned (@owned Alamofire.DataResponse<Swift.String>) -> () to @callee_owned (@in Alamofire.DataResponse<Swift.String>) -> () at ResponseSerialization.swift, dataResponse=<unavailable>) -> ()) -> Self).(closure #1).(closure #1) at ResponseSerialization.swift:166
    frame #7: 0x0000000104f6f567 Alamofire`thunk at DispatchQueue+Alamofire.swift:0
    frame #8: 0x000000010c84bef9 libdispatch.dylib`_dispatch_call_block_and_release + 12
    frame #9: 0x000000010c86c49b libdispatch.dylib`_dispatch_client_callout + 8
    frame #10: 0x000000010c85434b libdispatch.dylib`_dispatch_main_queue_callback_4CF + 1738
    frame #11: 0x00000001056a73e9 CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
    frame #12: 0x0000000105668939 CoreFoundation`__CFRunLoopRun + 2073
    frame #13: 0x0000000105667e98 CoreFoundation`CFRunLoopRunSpecific + 488
    frame #14: 0x000000010d0d5ad2 GraphicsServices`GSEventRunModal + 161
    frame #15: 0x0000000108ce0676 UIKit`UIApplicationMain + 171
    frame #16: 0x0000000103154267 xxx`main at AppDelegate.swift:13
    frame #17: 0x000000010c8a092d libdyld.dylib`start + 1
unexpectedly found nil while unwrapping an Optional value

Note that it works on iOS 10.
I had a look on other similar issues, e.g. #1718 , but changing the optimization values did not help. I further have a project with the same embedded library and the same optimization flags, which works (also in iOS 9).
Have you got any hints what the problem could be?
Thank you very much
Tobias
Alamofire Environment
Alamofire version: 4.5.0
Xcode version: 8.3.3
Swift version: 3.1
Platform(s) running Alamofire: iOS 9, iPad and iPhone
macOS version running Xcode: 10.12.6
Demo Project

Actually, that crash log shows the crash originating through a closure in a view controller.  It's likely your response handler is force unwrapping something. If you post your code we can see, but other than that this doesn't look like an Alamofire issue.

found it. Thanks for the help! The failure was on my side.


feat(InteractableObject): StopInteracting not called on destroy

OnDisable calls ForceStopInteracting, which starts a Coroutine that
is not executed anymore when the object is being destroyed. This
causes some events (like ungrab/untouch) to not being fired, which
can lead to inconsistent controller or application states.
Instead, ForceStopAllInteractions is now called directly in OnDisable.

I'm going to start closing these, we can reopen them if anyone raises it


Render Pages

rendering the pages on the home page with the nav bar is not working properly!

completed


#45 Changes to save button in note component based on unsaved changes in the editor

This PR is to fix #45
Change: When there is any update done in the editor, the Save button at the top will change to green. Retained it to green instead of blue to maintain consistency with the hover action.
Currently, the above change is done only for the rich text editor but if needed I can implement it for any update done on the note component such as location, date, etc.,
As the code runs in demo mode, the color change on the save button is removed as soon as it is clicked. If I can get access to the actual code, the color change can be updated after the save operation is successfully done.

Unfortunately we have already moved on from the changes to the save button in the note component. If you'd like to work on issues in the future that would be great! Just let us know! We will have meetings from Wednesdays at 9:30 am to 10:30 am if you'd like to join please let us know! Best, Stuart


drivers: timer: load counter after checking for autoreload

Bug occurs when polling kernel uptime. Uptime was suddenly jumping because lptim counter was counted twice
(from CNT and ARR registers) in case reload happens between values are fetched.

DNM until @FRASTM has a chance to review


Allow createInstance to accept no args

Add an override of createInstance that accepts no arguments, in which case it passes nullptr to wgpuCreateInstance.
This is useful for the current version of Emscripten, which expects wgpuCreateInstance to always be passed with nullptr (see https://github.com/emscripten-core/emscripten/blob/585924b655cf0a064bb8729e18e0cf1534d90636/system/lib/webgpu/webgpu.cpp#L24).

Also resolves https://github.com/eliemichel/WebGPU-Cpp/issues/20.

Sorry I didn't get to that yet.  Thanks for reviewing and merging!


MNT Fix missing lapack_py3.pyx in MANIFEST.in  for v1.3.1

I'm currently trying to make a conda forge release for v1.3.1 in https://github.com/conda-forge/pykrige-feedstock/pull/1 and the Python 3 builds are failing because the .tar.gz on PyPi misses the lapack_py3.{pyx,pxd} files. This PR addresses this issue by adding them to MANIFEST.in. (Generally though maybe we shouldn't specify files one by one in MANIFEST.in and use wildcards instead).
@bsmurphy Once this is merged should we upload the fixed version on PyPi as 1.3.2? Since the current version will also fail to build with Cython on Python 3..
P.S: once someone reviews and merges this PR, I can make a new 1.3.X branch from the v1.3.1 tag and backport this commit there, then add another v1.3.2 tag..

ping @bsmurphy  )

Ugh sorry for taking so long on this... work on this project is unfortunately continuing to be put behind other things that keep popping up...
Anyways, if I'm understanding you correctly, AppVeyor tests are failing due to a few missing files? Yes, we can update the package on PyPI with these changes, and the versioning stuff you recommend sounds good. I trust you on all the code management stuff!

I do like the idea of using wildcards as well, you can merge this if you want, or you can swap in wildcards instead, whichever you prefer for now...

OK, I uploaded the 1.3.2 on PyPi with this fix, which corresponds to the 1.3.1 + this PR only. The corresponding code is in the 1.3.X branch. Conda package for 1.3.2 should also available soon.

Also @bsmurphy could you please disable Circle CI builds in https://circleci.com/gh/bsmurphy/PyKrige/edit (either the "stop building" or "delete project" button). We are not using CircleCi for tests anymore, and it being enabled results in in commits shown as failed on the master branch. Thanks!

Will do ASAP


render multi-line doc properly

see embassy-rs/stm32-data#476

I'm not sure if respecting \n in the input is going to lead to more readable rustdocs. The use of newlines varies wildly across SVDs:

sometimes the linebreaks are just word wraps, we don't want to keep those.: https://github.com/embassy-rs/stm32-data/blob/b1bd6e97d6999a5a8e885612a520b85e911123db/data/registers/saes_v1a.yaml#L287
sometimes they do make sense, we do want to keep them. https://github.com/embassy-rs/stm32-data/blob/f0532de10ae0c8ff6c8746beed0667ae9a2055ae/data/registers/cordic_v1.yaml#L28
sometimes it's a mix https://github.com/embassy-rs/stm32-data/blob/29a026e65266d777705f1184f6aa98d56fb899cd/data/registers/i3c_v1.yaml#L955
Seems sometimes newlines are completely lost. Not sure if they're missing in the SVD or it's our SVD->YAML conversion that lost them. example https://github.com/embassy-rs/stm32-data/blob/d4a97f60b182cc5da8852fa28bda1230caa1c296/data/registers/syscfg_u0.yaml#L196
Sometimes they use \r lol https://github.com/embassy-rs/stm32-data/blob/ee64389697d9234af374a89788aa52bb93d59284/data/registers/syscfg_wba.yaml#L89

If we convert \n to a <br/> always, we'll make the "linebreaks are just word wraps" case worse. I think those are more common than the case where newlines do make sense.
How about instead we "declare" that the description field in the YAMLs is markdown? In this case the YAML->Rustdoc conversion is correct as-is. There's no need to split it into multiple #[doc]s, rustdoc already parses \n inside it normally. For example #[doc = "foo\n\nbar"] generates two markdown paragraphs, one with foo and one with bar.
If we do this, we'd have to fix the existing YAMLs in stm32-data manually instead. In cases where we do want a paragraph break, change \n to \n\n. Cases where the \n is a word-wrap we can leave as-is.
Then perhaps we can improve the SVD->YAML conversion instead to "markdownify" the descriptions. I'm not sure if this is possible to do automatically if the SVDs themselves already do \n for word-wrap...

The word wrap and mix ones are actually comes from me "just copy the description from RM manually".
I guess you are right about on the totally lost newline in description.
For "we'll make the 'linebreaks are just word wraps' case worse.", at least VSCode doesn't do auto-wrap, it just put description in long one line. So I guess a "word wrap as newline" are ok?
For "'declare' that the description field in the YAMLs is markdown" and write "\n\n as a newline", we would introduce a new rule to YAML (description need to be a valid markdown), I don't know if future contributors will know this new rule easily, or follow it strictly.

I change my code, that it use only one #[doc=] to render multiline doc
#[doc = "Scaling factor.  \nInput value has been multiplied by 2^(-n) before for argument.  \nOutput value will need to be multiplied by 2^n later for results."]

And, omit any newline in description seems intentional?
https://github.com/embassy-rs/chiptool/blob/1c198ae678ebd426751513f0deab6fbd6f8b8211/src/main.rs#L194-L197
Should we change the rules to
([ \n]){2,} map to $1, \r+ map to \n, and \t+ map to   ?
But, if we change already generated yaml files could be a big project ...

CORDIC of stm32h562.svd, upstream output compare to my output
20c20,29
<     description: 'Function 2: Phase 3: Modulus 4: Arctangent 5: Hyperbolic cosine 6: Hyperbolic sine 7: Arctanh 8: Natural logarithm 9: Square Root.'
---
>     description: |-
>       Function
>       2: Phase
>       3: Modulus
>       4: Arctangent
>       5: Hyperbolic cosine
>       6: Hyperbolic sine
>       7: Arctanh
>       8: Natural logarithm
>       9: Square Root.
24,25c33,36
<     description: Precision required (number of iterations) To determine the number of iterations needed for a given accuracy refer to . Note that for most functions, the
< recommended range for this field is 3 to 6.
---
>     description: |-
>       Precision required (number of iterations)
>       To determine the number of iterations needed for a given accuracy refer to .
>       Note that for most functions, the recommended range for this field is 3 to 6.
29,30c40,42
<     description: Scaling factor The value of this field indicates the scaling factor applied to the arguments and/or results. A value n implies that the arguments have been multiplied by a factor 2-n, and/or the results need to be multiplied by 2n. Refer to for the applicability of the scaling factor for each function and the appropriate
< range.
---
>     description: |-
>       Scaling factor
>       The value of this field indicates the scaling factor applied to the arguments and/or results. A value n implies that the arguments have been multiplied by a factor 2-n, and/or the results need to be multiplied by 2n. Refer to for the applicability of the scaling factor for each function and the appropriate range.
34c46,48
<     description: Enable interrupt. This bit is set and cleared by software. A read returns the current state of the bit.
---
>     description: |-
>       Enable interrupt.
>       This bit is set and cleared by software. A read returns the current state of the bit.
38c52,54
<     description: Enable DMA read channel This bit is set and cleared by software. A read returns the current state of the bit.
---
>     description: |-
>       Enable DMA read channel
>       This bit is set and cleared by software. A read returns the current state of the bit.
42c58,60
<     description: Enable DMA write channel This bit is set and cleared by software. A read returns the current state of the bit.
---
>     description: |-
>       Enable DMA write channel
>       This bit is set and cleared by software. A read returns the current state of the bit.
46c64,66
<     description: Number of results in the CORDIC_RDATA register Reads return the current state of the bit.
---
>     description: |-
>       Number of results in the CORDIC_RDATA register
>       Reads return the current state of the bit.
50c70,72
<     description: Number of arguments expected by the CORDIC_WDATA register Reads return the current state of the bit.
---
>     description: |-
>       Number of arguments expected by the CORDIC_WDATA register
>       Reads return the current state of the bit.
54c76,80
<     description: Width of output data RESSIZE selects the number of bits used to represent output data. If 32-bit data is selected, the CORDIC_RDATA register contains results in q1.31 format. If 16-bit data is selected, the least significant half-word of CORDIC_RDATA contains the primary result (RES1) in q1.15 format, and the most significant half-word contains the secondary result (RES2), also in q1.15 format.
---
>     description: |-
>       Width of output data
>       RESSIZE selects the number of bits used to represent output data.
>       If 32-bit data is selected, the CORDIC_RDATA register contains results in q1.31 format.
>       If 16-bit data is selected, the least significant half-word of CORDIC_RDATA contains the primary result (RES1) in q1.15 format, and the most significant half-word contains the secondary result (RES2), also in q1.15 format.
58c84,88
<     description: Width of input data ARGSIZE selects the number of bits used to represent input data. If 32-bit data is selected, the CORDIC_WDATA register expects arguments in q1.31 format. If 16-bit data is selected, the CORDIC_WDATA register expects arguments in q1.15 format. The primary argument (ARG1) is written to the least significant half-word, and the secondary argument (ARG2) to the most significant half-word.
---
>     description: |-
>       Width of input data
>       ARGSIZE selects the number of bits used to represent input data.
>       If 32-bit data is selected, the CORDIC_WDATA register expects arguments in q1.31 format.
>       If 16-bit data is selected, the CORDIC_WDATA register expects arguments in q1.15 format. The primary argument (ARG1) is written to the least significant half-word, and the secondary argument (ARG2) to the most significant half-word.
62,63c92,95
<     description: Result ready flag This bit is set by hardware when a CORDIC operation completes. It is reset by hardware when the CORDIC_RDATA register is read (NRES+1)
< times. When this bit is set, if the IEN bit is also set, the CORDIC interrupt is asserted. If the DMAREN bit is set, a DMA read channel request is generated. While this bit is set, no new calculation is started.
---
>     description: |-
>       Result ready flag
>       This bit is set by hardware when a CORDIC operation completes. It is reset by hardware when the CORDIC_RDATA register is read (NRES+1) times.
>       When this bit is set, if the IEN bit is also set, the CORDIC interrupt is asserted. If the DMAREN bit is set, a DMA read channel request is generated. While this bit is set, no new calculation is started.
70c102,107
<     description: Function result If 32-bit format is selected (CORDIC_CSR.RESSIZE = 0) and two output values are expected (CORDIC_CSR.NRES = 1), this register must be read twice when the RRDY flag is set. The first read fetches the primary result (RES1). The second read fetches the secondary result (RES2) and resets RRDY. If 32-bit format is selected and only one output value is expected (NRES = 0), only one read of this register is required to fetch the primary result (RES1) and reset the RRDY flag. If 16-bit format is selected (CORDIC_CSR.RESSIZE = 1), this register contains the primary result (RES1) in the lower half, RES[15:0], and the secondary result (RES2) in the upper half, RES[31:16]. In this case, NRES must be set to 0, and only one read performed. A read from this register resets the RRDY flag in the CORDIC_CSR register.
---
>     description: |-
>       Function result
>       If 32-bit format is selected (CORDIC_CSR.RESSIZE = 0) and two output values are expected (CORDIC_CSR.NRES = 1), this register must be read twice when the RRDY flag is set. The first read fetches the primary result (RES1). The second read fetches the secondary result (RES2) and resets RRDY.
>       If 32-bit format is selected and only one output value is expected (NRES = 0), only one read of this register is required to fetch the primary result (RES1) and reset the RRDY flag.
>       If 16-bit format is selected (CORDIC_CSR.RESSIZE = 1), this register contains the primary result (RES1) in the lower half, RES[15:0], and the secondary result (RES2) in the upper half, RES[31:16]. In this case, NRES must be set to 0, and only one read performed.
>       A read from this register resets the RRDY flag in the CORDIC_CSR register.
77,79c114,121
<     description: Function input arguments This register is programmed with the input arguments for the function selected in the CORDIC_CSR register FUNC field. If 32-bit
< format is selected (CORDIC_CSR.ARGSIZE = 0) and two input arguments are required (CORDIC_CSR.NARGS = 1), two successive writes are required to this register. The first writes the primary argument (ARG1), the second writes the secondary argument (ARG2). If 32-bit format is selected and only one input argument is required (NARGS = 0), only
< one write is required to this register, containing the primary argument (ARG1). If 16-bit format is selected (CORDIC_CSR.ARGSIZE = 1), one write to this register contains both arguments. The primary argument (ARG1) is in the lower half, ARG[15:0], and the secondary argument (ARG2) is in the upper half, ARG[31:16]. In this case, NARGS must be set to 0. Refer to for the arguments required by each function, and their permitted range. When the required number of arguments has been written, the CORDIC evaluates the function designated by CORDIC_CSR.FUNC using the supplied input arguments, provided any previous calculation has completed. If a calculation is ongoing, the ARG1 and ARG 2 values are held pending until the calculation is completed and the results read. During this time, a write to the register cancels the pending operation and overwrite the argument data.
---
>     description: |-
>       Function input arguments
>       This register is programmed with the input arguments for the function selected in the CORDIC_CSR register FUNC field.
>       If 32-bit format is selected (CORDIC_CSR.ARGSIZE = 0) and two input arguments are required (CORDIC_CSR.NARGS = 1), two successive writes are required to this register. The first writes the primary argument (ARG1), the second writes the secondary argument (ARG2).
>       If 32-bit format is selected and only one input argument is required (NARGS = 0), only one write is required to this register, containing the primary argument (ARG1).
>       If 16-bit format is selected (CORDIC_CSR.ARGSIZE = 1), one write to this register contains both arguments. The primary argument (ARG1) is in the lower half, ARG[15:0], and the secondary argument (ARG2) is in the upper half, ARG[31:16]. In this case, NARGS must be set to 0.
>       Refer to for the arguments required by each function, and their permitted range.
>       When the required number of arguments has been written, the CORDIC evaluates the function designated by CORDIC_CSR.FUNC using the supplied input arguments, provided any previous calculation has completed. If a calculation is ongoing, the ARG1 and ARG 2 values are held pending until the calculation is completed and the results read. During this time, a write to the register cancels the pending operation and overwrite the argument data.

I still think use hard-linebreak in yaml file is better than write a bunch of \n\n, it better for editors to read and modify. For this reason, I still perfer "markdownify" description on rendering it to rust doc.


Components prefixing

So this is the proposal for the prefixing.
Steps for a foo component:

Create foo.old.js in the same directory and copy all the directives  and controllers to it. Be sure to update the module creation by removing the second parameter (dependencies).
Create a foo.old.spec.js under the test directory and copy all the tests.
Prefix the directive (and controllers) in foo.js and make the needed changes if any (for example check if there is any $watch using the old directive name)
Fix the tests, normally just change the elements to compile.
Add a value service into foo.old.js to suppress the deprecation warnings.
add an if like in this PR to log the deprecation.
Create a new describe in foo.old.spec.js to check that the suppression works.
Update the demo and docs to show the prefix.

For the commit title, it is more a feature than a bug fix (It features a prefix now).
When we decide to remove the old ones, we just need to delete the .old.js and be happy.
Here is the list in strict order (some component depend on other components). If you want to tackle one, edit this to add yourself.

[ ] Collapse (Foxandxss)
[ ] Accordion (icfantv)
[ ] Alert
[ ] Bind Html
[ ] Buttons
[ ] Carousel
[ ] Dateparser
[ ] Position
[ ] Datepicker
[ ] Dropdown
[ ] Modal
[ ] Pagination
[ ] Tooltip
[ ] Popover
[ ] Progressbar (put it like the others)
[ ] Rating
[ ] Tabs
[ ] Timepicker
[ ] Typeahead

Important: If there is any $ in a service / controller / directive, remove it.

About the $ thing, Angular guidelines states that $ is only for angular use.

I don't think we should remove the $ - pretty much any third party library still uses it, such as UI Router. In truth, I doubt Angular will remove support of this in service names.

@wesleycho check this https://google-styleguide.googlecode.com/svn/trunk/angularjs-google-style.html#dollarsign

I have seen that before, but I'm speaking of the reality of the ecosystem. It can be found in third party libraries all over the place.

That doesn't mean it is done correctly.
Personally I don't like them, adds nothing. But I don't mind leaving them anyway.

@BobbieBarker @wesleycho My schedule is getting back to normal, I can tackle Datepicker and Typeahead if you haven't started these yet.

@RobJacobs There is a PR for datepicker but @wesleycho tried to do a bit too much with it and well, it is more stuck. Typeahead is almost done I think.

If you want to fix the tests in my attempt at the datepicker one, you're more than welcome to :) .


Adding tests to make sure the reference gallery is complete

I thought it'd be useful to have a unit test that asserts that for every panel object (layout, widget, pane) there is a corresponding reference gallery entry.
Found that ToggleGroup, YT, and RGGPlot are missing. Allowing those ones to be missing for now.

The YT and RGGPlot ones have requirements that we are unlikely to want to fulfill for our usual website building, so I'm not sure how to handle those.  ToggleGroup seems like just an oversight; good catch!

ToggleGroup is a factory class which creates the appropriate widget type depending on two options. I'd be in favor of deprecating it to be honest.

Should we just have a list of exclusions?

The PR already has exclusions; just merge then?

I'll rebase and see if it passes.

Sorry I thought this got in a while ago. Seems like an unrelated failure. Should I merge?

Yes feel free to merge.

Sadly these tests don't work while packaging which means they are currently breaking releases.


Test read/transform/write with lots of workers

A full bam pipeline scattered n ways.

@lbergelson can you clarify what specifically needs to be done to consider this done.

This was about dataflow. I'd say it's done for both dataflow and spark. We've run with 20 executors and lots of cores.


[#102845416] Fix 500s for bad service ids

Should fix this bug: https://www.pivotaltracker.com/story/show/102845416
If parameters passed in URLs contain unicode characters then the .format method on raw strings will fail in Python 2. By specifying unicode literals we can avoid this possibility.

Is it worth abstracting-out the strings into a dictionary and then testing that the dictionary only contains unicode strings? Or is that over-engineering it?
My only worry is that it's pretty trivial to reintroduce this bug when writing a new method.

I can see your point, but it would be pretty ugly... it's nice that the individual API Client methods only know about and are responsible for the API endpoint that they interact with. To have them pick a URL out of a shared dictionary wouldn't be as nice.

I'll do it if you insist, but I'm not sure it's necessary.

Yeah, it's a trade off. I think your original approach is the most sensible. :+1: