Cannot find executable for \android\gradlew.bat

flutter_01.log
Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter run -v
exception
ArgumentError: Invalid argument(s): Cannot find executable for C:\Users\win10\Documents\calculator_f\android\gradlew.bat.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:127:5)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:43:30)
#2      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:413:27)
#3      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:431:35)
#4      buildGradleApp (package:flutter_tools/src/android/gradle.dart:364:35)
#5      _AndroidBuilderImpl.buildApk (package:flutter_tools/src/android/android_builder.dart:97:13)
#6      AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:522:28)
<asynchronous suspension>
#7      FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:450:54)
#8      _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
#9      _rootRunUnary (dart:async/zone.dart:1134:38)
#10     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#11     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#12     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#13     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#14     Future._completeWithValue (dart:async/future_impl.dart:524:5)
#15     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:32:15)
#16     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:290:13)
#17     ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart)
#18     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
#19     _rootRunUnary (dart:async/zone.dart:1134:38)
#20     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#21     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#22     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#23     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#24     Future._completeWithValue (dart:async/future_impl.dart:524:5)
#25     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:32:15)
#26     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:290:13)
#27     AndroidApk.fromAndroidProject (package:flutter_tools/src/application_package.dart)
#28     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
#29     _rootRunUnary (dart:async/zone.dart:1134:38)
#30     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#31     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#32     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#33     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#34     Future._completeWithValue (dart:async/future_impl.dart:524:5)
#35     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7)
#36     _rootRun (dart:async/zone.dart:1126:13)
#37     _CustomZone.run (dart:async/zone.dart:1023:19)
#38     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#39     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#40     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#41     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#42     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#43     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

flutter doctor
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18362.720],
    locale en-US)
    • Flutter version 1.12.13+hotfix.8 at C:\src\flutter
    • Framework revision 0b8abb4724 (7 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\win10\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio1\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[✓] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio1
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[✓] VS Code (version 1.43.2)
    • VS Code at C:\Users\win10\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

• No issues found!

Hey @VladyslavBondarenko were u able to solve the problem

Was https://github.com/flutter/flutter/pull/39145 (in v1.9.7) supposed to fix this?  See https://github.com/flutter/flutter/issues/39341.

\cc @blasten

This one seems like a slightly different issue. @Jatin-Goyal5 if you run flutter create -t app, there should be a android\gradle.bat file. If that is the case, something running on your system might have deleted that file in your app.

Gradle. bat file is present but system is unable to read at time of run

does gradlew.bat have exec permission? If not, try adding it. See this article for an example: https://www.online-tech-tips.com/computer-tips/set-file-folder-permissions-windows/

This one seems like a slightly different issue. @Jatin-Goyal5 if you run flutter create -t app, there should be a android\gradle.bat file. If that is the case, something running on your system might have deleted that file in your app.

First of all, I'm not sure if this gradlew.bat file exists in all my projects from the very beginning but this morning I don't know why, suddenly I can't do flutter run on all my projects with this output Oops; flutter has exited unexpectedly: "Invalid argument(s): Cannot find executable for ...\android\gradlew.bat."..
And on top of that, my normal flutter create command doesn't generate gradlew.bat file, is there something wrong with it?
As for my projects, after run flutter create -t app and copy the gradlew.bat, it works just fine.

How to copy gradle. bat

I just run flutter create -t app, then go to project-app\android. There's gradlew.bat file, just copy it.

Now sdk manager is not found is showing

@Jatin-Goyal5 That's probably https://github.com/flutter/flutter/pull/54133.

Sdkmangager is automatically deleted again and again

Sdkmangager is automatically deleted again and again

@Jatin-Goyal5 Can you explain what you mean?  The SDK manager isn't distributed by Flutter, it's Android Studio or however else you downloaded your Android SDK.  Flutter tooling just tries to figure out its path.
https://github.com/flutter/flutter/pull/54133 is in 1.18.0-dev.3.0, which is currently in master, dev, and beta channels.
But that looks unrelated to the original issue you filed.  I'm not sure why gradlew.bat was missing, you shouldn't need to generate a new project and copy it over.

The above issue is not solved so i tried to reinstall everything but wgen i run flutter doctor sdkmangager is automatically deleted and license are not acceptable

Can you explain what "sdkmangager is automatically deleted" means?

Now, it's fixed because of some virus this problem has occurred

Are you saying your antivirus app deletes sdkmangager from inside the Android SDK, and gradlew.bat from inside your Flutter app?

Maybe something like that after i format my laptop it's running fine

Okay we can use https://github.com/flutter/flutter/issues/56975 to track this issue.  Thanks!

Okay we can use #56975 to track this issue. Thanks!

Then closing current one as duplicate. Feel free to reopen if the issue is needed

Are you saying your antivirus app deletes sdkmangager from inside the Android SDK, and gradlew.bat from inside your Flutter app?

I spent two days chasing this on another user's system. In his case it was definitely AVG that was deleting / hiding sdkmanager.bat. Uninstalling AVG has removed that issue. However, today, his gradlew.bat in the project/android folder is doing the same. Even when copying it in Windows Explorer it simply disappears. I'm still trying to track down what is casing that.

This one seems like a slightly different issue. @Jatin-Goyal5 if you run flutter create -t app, there should be a android\gradle.bat file. If that is the case, something running on your system might have deleted that file in your app.

First of all, I'm not sure if this gradlew.bat file exists in all my projects from the very beginning but this morning I don't know why, suddenly I can't do flutter run on all my projects with this output Oops; flutter has exited unexpectedly: "Invalid argument(s): Cannot find executable for ...\android\gradlew.bat."..
And on top of that, my normal flutter create command doesn't generate gradlew.bat file, is there something wrong with it?
As for my projects, after run flutter create -t app and copy the gradlew.bat, it works just fine.
EDIT: As I wrote before, there is no gradlew.bat file in all my existing projects and when I run flutter run it returns Exception: Gradle task assembledebug failed with exit code -1 flutter, but after a single success flutter run (after I copied gradlew.bat to one of my projects), then suddenly all my projects are working fine even tho I haven't copied the gradlew.bat to the rest of the projects.

Pls give a exact solution

Sdkmangager is automatically deleted again and again

Hey @Jatin-Goyal5 , I am facing same problems and trying to resolve since FOUR days ):
Please help me what should I do ??
In my case :

Gradlew.bat files are missing, and if I run old projects having that file then,
Exception: Gradle task assembledebug failed with exit code -1 flutter

I tried to accept all licenses but as in your case, sdkmanager.bat file is deleting again and again.
Please help me.
Thanks in advance.

Are you saying your antivirus app deletes sdkmangager from inside the Android SDK, and gradlew.bat from inside your Flutter app?

I spent two days chasing this on another user's system. In his case it was definitely AVG that was deleting / hiding sdkmanager.bat. Uninstalling AVG has removed that issue. However, today, his gradlew.bat in the project/android folder is doing the same. Even when copying it in Windows Explorer it simply disappears. I'm still trying to track down what is causing that.
It appears that Windows Defender may be the cause, and of course we can't turn that off in Home edition. So it's a case of reinstalling AVG and adding exceptions in Menu -> Settings -> General -> Exceptions for the relevant folders, typically:
C:\Users[username]\AppData\Local\Android* and
C:\Users[username]\AndroidStudioProjects*
Finally! That seems to have done the trick. I also got him to turn off Resident Shield just in case. We then copied known good versions of gradlew and gradlew.bat from "C:\Program Files\Android\Android Studio\plugins\android\lib\templates\gradle\wrapper" into the project\android folder, and I uploaded my sdkmanager.bat so that he could put it in C:\Users[username]\AppData\Local\Android\Sdk\tools\bin. It all works now, and he built his first project!
HTH

Hey @SadSack963 , I am facing same problems and trying to resolve since FOUR days ):
Please help me what should I do ??
In my case :

Gradlew.bat files are missing, and if I run old projects having that file then,
Exception: Gradle task assembledebug failed with exit code -1 flutter

I tried to accept all licenses but as in your case, sdkmanager.bat file is deleting again and again.
Please help me.
Thanks in advance.

Well, (and I'm not being facetious here) if you have the time and inclination you should consider Linux as a free alternative operating system for your programming needs. I'm not kidding - I have never seen a post from a Linux (or Mac) user saying that this or that file has suddenly been deleted. This is specifically a Windows problem simply because it is so insecure.
Anyway, my point is that files don't just disappear for no reason. If a file is being deleted, then something is deleting it. You need to find that something - and there are so many candidates on Windows that no-one can offer specific help for you.
I can only suggest that you begin by installing IOBit Uninstaller. Have a look through the list of programs installed, check out any suspicious programs in your search engine, and remove anything you don't like the sound of. Specifically, you are looking for some kind of antivirus - usually something a bit obscure.
Such FREE(!) PUPs (potentially unwanted programs) are usually installed silently alongside some other quite legitimate program that you have downloaded from the internet. As an aside, I would recommend that if you do install something you download, then always use the Custom Install option, so that you can see if such things are packaged along with it.
If that still doesn't work, then open Task Manager (right click on the task bar) and search through the apps and background processes. Ignore Microsoft processes - you will not have a problem with those. Again, look up anything you don't recognise and that looks suspicious on the internet before deleting it. Also check if there are any specific procedures for removing the program, since some may have self-preservation locks which prevent you from removing them easily. If you right-click on the item and select Open file location, you could try renaming the offending file (or parent folder) if you're concerned about just deleting or uninstalling it.
I'm afraid there's not much more I can offer. Persevere and you will find the culprit. Good luck!

Try to install android sdk in local d or another directory

Well, (and I'm not being facetious here) if you have the time and inclination you should consider Linux as a free alternative operating system for your programming needs. I'm not kidding - I have never seen a post from a Linux (or Mac) user saying that this or that file has suddenly been deleted. This is specifically a Windows problem simply because it is so insecure.
Anyway, my point is that files don't just disappear for no reason. If a file is being deleted, then something is deleting it. You need to find that something - and there are so many candidates on Windows that no-one can offer specific help for you.
I can only suggest that you begin by installing IOBit Uninstaller. Have a look through the list of programs installed, check out any suspicious programs in your search engine, and remove anything you don't like the sound of. Specifically, you are looking for some kind of antivirus - usually something a bit obscure.
Such FREE(!) PUPs (potentially unwanted programs) are usually installed silently alongside some other quite legitimate program that you have downloaded from the internet. As an aside, I would recommend that if you do install something you download, then always use the Custom Install option, so that you can see if such things are packaged along with it.
If that still doesn't work, then open Task Manager (right click on the task bar) and search through the apps and background processes. (Also check the Services tab.) Ignore Microsoft processes - you will not have a problem with those. Again, look up anything you don't recognise and that looks suspicious on the internet before deleting it. Also check if there are any specific procedures for removing the program, since some may have self-preservation locks which prevent you from removing them easily. If you right-click on the item and select Open file location, you could try renaming the offending file (or parent folder) if you're concerned about just deleting or uninstalling it.
I'm afraid there's not much more I can offer. Persevere and you will find the culprit. Good luck!

Thanks for your time buddy, I will try it :)

Try to install android sdk in local d or another directory

I will try it :)


Plivo

Anyone ha tried it with Plivo ?

I have not.
Would Plivo offer any advantages over Twilio?

basically the same service but they have an open source code and they are a bit cheaper ,always better to have the possibility of being integrated with more than one supplier so users get the choice

Thanks for letting me know. This is not going to be a priority for the project but I'd happily accept a pull request if you want to add support for this.


Added a Semantic test for updates when unique attributes are present.

When updating multiple records based on a given find criteria there won't be an id specified in the object with the new values. This could make it tricky, when a model has attributes marked as unique, to establish whether an existing record with a duplicate value is actually the record being updated, which is not actually a violation.
The sails-memory adapter has such a bug, and this test was added to flag it. I will reference this PR from the one I submit with the fix for the bug on the sails-memory repo.

I see the Travis build fails now because this issue is present in a number of the adapters. If unique attributes aren't supported for all adapters, is there a way to detect whether it is for a given adapter and run this test only in that case?

Hi @marnusw, thanks for your PR. Indeed unique is not supported by all adapters, as described in the docs:

This is a database level constraint so in most cases a unique index will be created in the underlying data-store.

As to regards to detection I don't think there is currently a way to do it. In the future, a possible solution for this is by placing this test in a /features/unique folder and then add "features": ["unique"] to the adapter's package.json. Such functionality is not decided yet and is being discussed in PR #64. I suggest you subscribe to it and then adapt this solution depending on the outcome.

@marnusw, PR #64 has been merged, do you mind refactoring this as a "feature"? Thanks!

Will do.

I've refactored this to a feature test for the unique attribute option. Perhaps simply calling the feature "unique" is too vague? Let me know if it should change.
At present these tests pass for sails-disk, but will fail for sails-memory until balderdashy/sails-memory#19 is merged.

I've refactored this to a feature test for the unique attribute option. Perhaps simply calling the feature "unique" is too vague? Let me know if it should change.

Well... the flag is called unique in waterline and the related constraint has the same name in SQL so people will "hopefully" associate it with the right thing, given the context :)
The tests looks good :white_check_mark:
Have you tested this with any adapter besides sails-memory/disk?

I believe this is now ready to merge once #68, providing the '.' feature notation and knowledge of "core" folders, is merged.

@devinivy, can you take a second look please?

@dmarcelino Now that the "." notation is merged via #68 I'll run this test for all adapters as well and report back over/after the weekend! With that and @devinivy's go-ahead it should be ready too.

Nice, thanks! :beers:

So I ended up doing it now... :blush:
The feature wasn't enabled for Redis, but it was for all other adapters. It all seems good, and
sails-memory will be fixed with the PR I have open that side.
 -----------------------------------
| core modules            | version |
|-------------------------|---------|
| waterline               | 0.10.24 |
| - anchor                |  0.10.3 |
| - waterline-schema      |  0.1.17 |
| waterline-adapter-tests | 5656f2c |
 -----------------------------------

 ------------------------------------------------------------------
| adapter          | version | result | failed | total | wl-sequel |
|------------------|---------|--------|--------|-------|-----------|
| sails-postgresql | 30317cd | passed |      0 |   344 |     0.4.0 |
| sails-memory     | c7b0610 | failed |      1 |   319 |           |
| sails-disk       | e95628b | passed |      0 |   324 |           |
| sails-mongo      | 021ec02 | passed |      0 |   321 |           |
| sails-mysql      | 01c1a0e | passed |      0 |   349 |     0.4.0 |
| sails-redis      | 72ced91 | passed |      0 |   317 |           |
 -------------------------------------------------------------------

To be clear– in the test results that we're seeing, all those adapters were tagged with the unique feature aside from sails-redis, correct?  And all the tests pass Travis CI because none of the adapters are tagged with the unique feature currently.  Should we make issues on postgres, disk, mongo, and mysql?  And ensure the tag makes in into your PR on memory?
This PR looks good!

@devinivy that is correct.
And yes, I'll update my sails-memory PR with the tags, and I think adding issues for the others is a good idea. I'll do them all when I update the memory PR.

Thanks again @marnusw and @devinivy!
@particlebanana, can you please release a new version of waterline-adapter-tests so we can test autoIncrement and unique features on the adapters?


Feature/ light groups

Adding light group support

Patch derives from https://developer.blender.org/D3607
Addresses https://github.com/tangent-opensource/coreBlackbird/issues/33
Blender exporter needs updating still

@skwerner I didn't update the blender exporter code, should we do this?

How urgent is this one? Can this wait a couple of days until we have a 2.93 merge?

@skwerner I don't mind pushing this a bit if it's just a few days if it makes things easier to merge. Cheers!

Hey all, the latest changes I did:

Rebased on latest master
Fixed any int type occurrence to uint (thanks for pointing out @dedoardo )
Any 'lightgroups' plural is now just 'lightgroup', and removed any mention of bitfields as they are not being used now


Add basic web support

Goal
Adding basic web support.
Design
Wrapping the native module seemed like the right initial approach, open to other ideas.
Changeset
I wrote a tiny wrapper to the NativeModule and then wrote a version for the web specifically
Added
Removed
Changed
Tests
Tested manually and w/ the existing automated tests.
Discussion
Alternative Approaches
Outstanding Questions
Is this the right place to split?
Linked issues
Fixes #244
Review
For the submitter, initial self-review:

[X] Commented on code changes inline explain the reasoning behind the approach
[X] Reviewed the test cases added for completeness and possible points for discussion
[x] A changelog entry was added for the goal of this pull request
[X] Check the scope of the changeset - is everything in the diff required for the pull request?
This pull request is ready for:

[X] Initial review of the intended approach, not yet feature complete
[ ] Structural review of the classes, functions, and properties modified
[ ] Final review

For the pull request reviewer(s), this changeset has been reviewed for:

[ ] Consistency across platforms for structures or concepts added or modified
[ ] Consistency between the changeset and the goal stated above
[ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
[ ] Usage friction - is the proposed change in usage cumbersome or complicated?
[ ] Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
[ ] Concurrency concerns - if components are accessed asynchronously, what issues will arise
[ ] Thoroughness of added tests and any missing edge cases
[ ] Idiomatic use of the language

Hi @tberman thanks for the contribution. We already have a project underway to unify bugsnag-react-native with the other Bugsnag JS codebase which will supercede this. After that project is out of the way we'll consider how we can best support React Native Web.
Apologies but I'm going to close this off until then.

Hi @bengourley What's the latest status of the consolidation efforts? Is it ready/already in production?

Hi @SuhairZain,
We have prerequisites of updating the Android and iOS notifiers before the React Native consolidation can fully happen. The relevant Android update has been released and the iOS one is expected very shortly.  We do not have a definite timeframe for the React Native notifier update as yet but we are still working on it.


No native build was found for platform=darwin arch=arm64

I am working on Mac M1 chipset, after executing "prebuild-darwin-x64+arm64": "prebuildify -t 8.14.0 --napi --strip --arch x64+arm64",
I got this error:
No native build was found for platform=darwin arch=arm64 runtime=node abi=111 uv=1 armv=8 libc=glibc node=19.8.1

Hi, I'm facing similar problem.
When running classic-level on next.js there is an error:
Error: No native build was found for platform=darwin arch=arm64 runtime=node abi=108 uv=1 armv=8 libc=glibc node=18.14.0

I got the same issue with platform=darwin and arch=x64

I got the same issue with platform=darwin and arch=x64

I'm getting this too.

I had the same problem and solved it by adding serverExternalPackages to my next.config.ts:
const config: NextConfig = {
  ...
  serverExternalPackages: ["classic-level"],
  ...
}

export default config

See also:
https://nextjs.org/docs/app/api-reference/next-config-js/serverExternalPackages
Note that I'm using Next.js 15. If you're using an older version, this setting might be under experimental with a slightly different name. See here:
https://nextjs.org/docs/14/app/api-reference/next-config-js/serverComponentsExternalPackages
More information about externals:
https://webpack.js.org/configuration/externals/


Invoke-SSHStreamShellCommand is hanging.

Using this module to capture and back up running configs on various HP/Aruba network switches. It runs fine under my account, but when I change over to using the service account that is running it as a scheduled task, the Invoke step hangs indefinitely.
$formattedDate = get-date -format 'yyyyMMdd'
$backupPath = "tftp <IP-ADDRESS>"
$configFile = $switch + ".txt"
$logFile = "C:\TFTP\Logs\"+$switch+"_"+$formattedDate+".log"
$connection = New-SSHSession -ComputerName $switch -Credential $Cred -AcceptKey:$True -ErrorAction Stop -ConnectionTimeout 120
$session = Get-SSHSession -ComputerName $switch
$stream = New-SSHShellStream -Index $session.sessionid -TerminalName "dumb"
$sshCommand = @"
A
en
<OPERATORUSERNAME>
<OPERATORPASSWORD>
copy startup-config $backupPath $configFile
Logout
Y
Y
"@
$streamoutput = Invoke-SSHStreamShellCommand -ShellStream $stream -Command $sshCommand -Timeout 10
((($streamoutput -replace '\x1b\[[0-9;]*[a-z]', '').replace("","")).replace("","")).replace("","") | out-string | Out-File $logFile

Both accounts have the same permissions on the computer running the script and on the switch being backed up. I don't get any sort of output, just hangs.

When running as a schedule task I would proba use an iStore for the fingerprints since there is not user folder. But you say it hangs on execution .. in that case to be honest no clue.

When running as a schedule task I would proba use an iStore for the fingerprints since there is not user folder. But you say it hangs on execution .. in that case to be honest no clue.

I set a timeout of 10 seconds on the command and it does indeed time out. It says "returning output collected so far", but it's all blank except for a single line that's not even relevant to the command I'm running.
It's also stopped running fine under my account also, hangs at the first switch in the loop and returns the above.

sadly dont have access to that type of gear to test. Most of my coding is against Linux VMs or raspberry Pi’s. Have you looked in to using SFTP instead?
https://arubanetworks.com/techdocs/AOS-S/16.11/MCG/KB/content/kb/ena-scp-sft.htm


Add collaborator to Terraform file/s from Issue for angelanec

Hi there
This is the GitHub-Collaborator repository bot.
Please merge this pull request to add the outside collaborator to the Terraform files / GitHub.
If you have any questions, please post in #ask-operations-engineering on Slack.

Mick has approved the request via email.


Unique secret key

It is a good practice to check if a generated secret key is unique in the User DB table, that is not yet assigned to another user (statistically is improbable, but not sure).

Done, in master.


Question :: How to construct GoogleProviderSettings class if protected?

I am attempting to setup "native" authorization and following the example here, but since the GoogleProviderSettings class's visibility is "protected", the lines below aren't valid.  Am I missing something obvious?
GoogleProviderSettings googleSettings = new GoogleProviderSettings()             .googleClientId("google.api.client.id")             .googleClientSecret("google.api.client.secret")             .googleRefreshToken("google.refresh.token")             ;

You can instantiate it via the static method in the superclass:
GoogleProviderSettings googleSettings = ProviderSettings.google()
    .googleClientId("google.api.client.id")
    .googleClientSecret("google.api.client.secret")
    .googleRefreshToken("google.refresh.token") ;

That example should probably be corrected.

Many thanks for the quick reply!  That did the trick.  Thanks!


Having trouble npm install

Submit a feature request or bug report

[ ] This is a feature request
[ ] This is a bug report
[X] This request isn't a duplicate of an existing issue
[ ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the Roots Discourse forums

Replace any X with your information.

What is the current behavior?
X when doing npm install I get an error: code ELIFECYCLE when install node-sass
using ubuntu 14 node 5.0.0
What is the expected or desired behavior?
X npm install should install lib

Bug report
(delete this section if not applicable)
Please provide steps to reproduce, including full log output:
X clone and run npm install on ubuntu 14
Please describe your local environment:
WordPress version:  4.4.2
OS: ubuntu 14
NPM/Node version: 5.0
Where did the bug happen? Development or remote servers?
local host
Is there a related Discourse thread or were any utilized (please link them)?
X

Feature Request
(delete this section if not applicable)
Please provide use cases for changing the current behavior:
X
Other relevant information:
X


Update Blurb/Descriptions

Update "What is Hack?" Blurb
Update the empty Event Section blurb
Update school years of all team members

These are the update website blurbs
HomePage: "What is Hack" Blurb
We are a student-run organization whose mission is to empower the community by providing the means to build amazing things and explore what is possible through code. We teach quarterly workshops and host events for students to expand their knowledge and apply their creativity to projects. Our events are for coders of all skills levels, so whether you've been to 10 hackathons or you just learned "Hello World," we're happy to have you.
Homepage: Events Section when there are no events
💜 Stay tuned for future events
🚀 We look forward to seeing you
🙌 And we can't wait to see the amazing things YOU build
Team Page
for officer in team:
    officer.year += 1


can't add new actions with entities

Hello, every time i try to add a new action that uses entities I get the following error:
The 'getAppointments' action should accept 3 arguments: sessionId, context, callback. Learn more at https://wit.ai/docs/quickstart
Where is that defined? I already changed my story several times.
Thanks!

i figured out that because in the old wit.ai version everything had to go through merge first


make tar fails if $(HOME)/$(TAR_DIR) does not exist

See subject line, this is for Cori (cannot vouch for elsewhere). mkdir ~/tar_dir fixes the issue.

Works great! After removing the old directory, make tar was able to recreate and fully populate it.


Allow theming git stash chars

This PR allows to theme the git stash count and it keeps the same color as the git branch.

With this PR, the style of the stash count can be changed:

The PR introduces 2 new attributes: SCM_GIT_STASH_CHAR_PREFIX and SCM_GIT_STASH_CHAR_SUFFIX. I would prefer to keep consistency with the other git attributes, but this way it keeps compatibility with current themes.

Great - thanks!


Pull_request.filter is not a function error is thrown when there is a single value defined in on.pull_request.branches

It seems, that latest commit of actions-utils.js expects on.pull_request.branches to be an array, but this is not the case if your workflow on.pull_request.branches is defined e.g. like this:
branches: '*'
Workaround is to define branches always in yaml list-format, but for consistency also single value should work without runtime error.
Related code in actions-utils.js:
190: const difference = pull_request.filter((value) => !push.includes(value));

Thanks for bringing this up and sorry this affected you. There were some cases that we didn't account for. We've reverted the change that caused that bug on the v1 branch so your workflow should work again, and we'll work on a fix before that change gets merged in again.
I'll close this issue as the immediate bug should be gone, but if this still affects you please do let us know.


Feature request: Different icon for space with/without windows

Thanks for making this! It works great and is a godsend for someone used to having this on Linux (a shame that Mission Control doesn't have a checkbox to automatically expand the desktops view).
Is it possible to identify whether a desktop/space is empty or has windows in it? If so, it would be useful to use a different icon to convey whether a space is populated or not.

This would be amazing!

This would be great! @Jaysce Are you planning on implementing this anytime soon?


2.6.1 install(update) error

The command '/bin/bash -o pipefail -c apk add --no-cache nginx && if [ "${BUILD_ARCH}" = "aarch64" ]; then ARCH="arm64"; fi && if [ "${BUILD_ARCH}" = "armhf" ]; then ARCH="arm"; fi && if [ "${BUILD_ARCH}" = "armv7" ]; then ARCH="arm"; fi && if [ "${BUILD_ARCH}" = "amd64" ]; then ARCH="amd64"; fi && curl -L -s "https://github.com/portainer/portainer/releases/download/${BUILD_UPSTREAM}/portainer-${BUILD_UPSTREAM}-linux-${ARCH}.tar.gz" | tar zxvf - -C /opt/' returned a non-zero code: 1# Problem/Motivation
Running HA under Debian 10.

Maybe you could add some context on what you are trying to do, it would appear you are trying to build the addon, which isn't necessary, as the container is distributed.

I just saw an update available and did the update.  When that didn't work (message above), I uninstalled the addon, reinstalled it and got the same message.

Please post the full startup log

I'll actually close this out, looks like you have installed an addon from another repo, I am guessing this https://github.com/alexbelgium/hassio-addons/tree/master/portainer
Please report your issue there.


Implicit argument resolution failure in the projectors generated by a typeclass

Trying to use typeclasses a little... here is my minimal repro:
class block (index: Type0) = {
  // Astract footprint.
  state: index -> Type0;
  footprint: #i:index -> h:HS.mem -> s:state i -> B.loc;
}

trying to process this in the interactive mode gives me:
(Error) Failed to resolve implicit argument of type 'index' in the type of footprint ((#[FStar.Tactics.Typeclasses.tcresolve ()] d: Hacl.Streaming.Interface.block index)
  -> Prims.Tot
    (h: FStar.Monotonic.HyperStack.mem -> s: Mkblock?.state d (*?u10*) _
        -> Prims.Tot LowStar.Monotonic.Buffer.loc))

am I misusing the type class feature?
Thanks,
Jonathan

This is because we generate roughly the following for the footprint method:
let footprint' = fun (index:Type0) (#[tcresolve ()] d : block index) -> d.footprint

And it seems F* attempts to instantiate the implicit for d.footprint (the #i:index) eagerly. Adding an annotation would fix this, but the dependency makes it awkward. The underlying issue is this, I think:
assume val f : unit -> #i:int -> int

let g = f

let h () = f ()

g succeeds but h fails with Failed to resolve implicit argument ?3 of type int introduced for Instantiation of implicit argument. Possibly related to #1965.

Actually that very same workaround can be used for the method generating tactic. You can use this patch as a workaround for now (I might keep it too).
diff --git a/ulib/FStar.Tactics.Typeclasses.fst b/ulib/FStar.Tactics.Typeclasses.fst
index 53de970f59..6f6479b2de 100644
--- a/ulib/FStar.Tactics.Typeclasses.fst
+++ b/ulib/FStar.Tactics.Typeclasses.fst
@@ -118,11 +118,9 @@ let mk_class (nm:string) : Tac decls =
                   let sfv = pack_fv (ns @ [s]) in
                   let dbv = fresh_bv_named "d" cod in
                   let tcr = (`tcresolve) in
-                  let tcdict = pack_binder dbv (Q_Meta tcr) in
-                  let bs = ps @ [tcdict] in
                   let ty = pack Tv_Unknown in (* Just leave it to inference *)
                   let proj = pack (Tv_FVar (pack_fv (cur_module () @ [base ^ s]))) in
-                  let def : term = mk_abs bs (mk_e_app proj [binder_to_term tcdict]) in
+                  let def : term = mk_abs ps proj in
                   //dump ("def = " ^ term_to_string def);
                   //dump ("ty  = " ^ term_to_string ty);

This should now be fixed in master, I did add the annotation for the methods since it wasn't as hard as I thought. Keeping this open since I think the instantiation behaviour is wrong (and I have some work on that too, but it'll probably take a while).


added handling of response headers overrides by config

added possibility of overriding response headers based on config, assuming existing defaults when config is not present

Thanks for the contribution. I would like t simplify this.
keep bootstrap.php as it is and only update index.php:
header("Access-Control-Allow-Origin: ".$cockpit->retrieve('config/cors/allowedOrigins', '*'));
.
.
.

Ok, updated

Thanks!


1.0 Bug - while the light of transparent roofing is working, the shading is off.

This old. I kind I just like it but I am not going to say won't fix yet...


Login and Signup with Google

Path: /auth/
Authentication: Not Required
Requirements

[ ] Header Component
[ ] Sign in/Signup with google
[x] #10
[ ] Event Price and Goodies
[x] #11

implemented


Target coverage reporting updates

Minor updates and clean ups for the code related to the target coverage reporting:

Added "on padded target pct" hidden metric. It's the share of reads that map on regions extended by 200 base pairs. We look at this metric in AZ to spot issues when reads get piled up in the ends of exons (padded on-target is expected to be 1-2% higher than the standard on-target, otherwise somethings is going wrong). I made it hidden by default, we'll make it visible in our internal reports.
Add information about used coverage and variant calling regions in MultiQC. It may be not clear for a person who looks at MultiQC what meant by "target" in all kinds of metrics, so I added a couple of lines about that.
MultiQC general read statistics: making all reported by sambamba for consistency and for keeping a reasonable column order in MultiQC. Some metrics like "mapped rate" are calculated multiple times (by "samtools stats", by qualimap, by bcbio), and the final numbers may vary slightly in different tools, so it's safe to calculate all of them by one tool for consistency. Also, this way we can control the order of columns and make the report a bit cleaner, which is nice.
Simplified over-engineered offtarget save-retrieve code, made some code cleaner.
Fix "dt = _fix_duplicated_rate(dt)" in multiqc.py

I tested it against different kinds of inputs, here are examples of reports with different cases of input coverage/variant_regions:
Both variant_regions and coverage are specified:
http://quast.bioinf.spbau.ru/static/bcbio/cov_and_vcr_different.html

Only variant_regions are specified:
http://quast.bioinf.spbau.ru/static/bcbio/only_vcr.html

Both are specified, but with the same file:
http://quast.bioinf.spbau.ru/static/bcbio/cov_and_vcr_same.html

Only coverage regions are specified:
http://quast.bioinf.spbau.ru/static/bcbio/only_cov.html

Nothing is specified:
http://quast.bioinf.spbau.ru/static/bcbio/no_bed.html

Vlad -- this is awesome, thanks for all these improvements. It's so great to have better consistency across processes. The only thing I worry about here is the implicit caching in the sambamba module won't play well with CWL, where we need to explicitly define all of the files that are retained and passed. This makes an assumption of a shared filesystem so the cached files exist across processes, where in CWL it only brings in and uses explicitly defined files (like the offtarget_stats in the CWL defs). As we test this more with CWL in the next iteration we'll need ways to define and pass these cached files in a consistent way.

Thanks Brad for merging the PR and explaining how caching works with CWL for me. It's now more clear for me why some stuff looks over-engineered. Am I correct that we need to make sure that all files that we checked with utils.file_exists() or utils.file_uptodate() anywhere in the code in order to reuse them, need to be declared in defs.py? And that's all that needs to be done to address CWL caching in CWL?

Vlad;
In CWL every needed file is declared in defs.py and explicitly passed between functions. There is no assumption of a shared filesystem so it can work on cloud platforms where files get staged from places like S3. So that's right on, anything we depend on needs to be declared. I like the way you make things more transparent from the code side but we should also think of ways to define and retain these coverage cache files (or maybe convert to a single cache file that gets updated). I'm open to whatever works best from your perspective.


Latest version of agora is not working is gives me No identifiers allowed directly ater numeric litreal, stack:

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Dhaval1905 Sorry, I can not reproduce this with clean react-native app, can you give me more details?


TEST: build: run saucelabs in circleci

I wonder if it's worth running Saucelabs at all. This one is the only one that causes flakes 🤷♂


authentication of APIs of dbserver and agency is failed

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[x] 3.2
[ ] 3.3
[ ] self-compiled devel branch

Mode:

[x] Cluster
[ ] Single-Server

Storage-Engine:

[x] mmfiles
[ ] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[x] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[x] other: centos

[ ] Windows, version:
[ ] MacOS, version:

this is an API auth issue:
my arangodb started with  authentication = true.
some APIs on coordinator such like /_api/document/{document-handle} are authenticated successfully.
another APIs on agengcy/dbaserver(404 on coordinator) such like /_api/agency/config|/_api/replication/logger-follow are always return 401(unauthorized).
Is this a bug?

Hi @3rduncle,
sorry for the late reply. You mentioned using authentication = true. Did you use the the ArangoDB starter or another procedure to start the cluster? What is your current version (3.2.x)?
curl http://$SERVER:$PORT/_api/agency/config can only be executed using $SERVER:$PORT of your agency. Using $SERVER:$PORT of a dbserver or coordinator will result in {"error":true,"code":404,"errorNum":404,"errorMessage":"unknown path '/_api/agency/config'"}.
/_api/replication/logger-follow is not supported on a coordinator in a cluster, which is mentioned in the documentation. It is used for a master/slave replication.

Note: this method is not supported on a coordinator in a cluster.

NOTE this is one of the don't try this at home parts and not officially supported. End users should talk to ArangoDB via the Coordinator.
In order to talk to the backend components you need to work with JW-Tokens. Auth basic is not supported.
You can use jwtgen to generate the proper token, or use the openssl commandline tool:
jwtgen -a HS256 -s openSesame -c server_id=hans -c iss=arangodb

The startLocalCluster.sh which we use for internal development also demonstartes this.
at least in current devel arangosh learned to talk to the backend components.

Hi @3rduncle,
Just sending a quick follow-up, were the previous messages useful for you?
Best,

Hi @3rduncle,
i am closing this issue as solved for now since we have not received any feedback for a few months.
Please feel free to comment and reopen in case you have further questions.


updated common.py to explicitly map to the dynamic libraries and adde…

…d two for Mac to handle x86_64 and ARM architecture
Tests weren't running with just libmf6 in the path without extension (e.g. dll, dylib, or so) so I updated common.py to make that work. Probs need something similar for examples

Right on - just note that for the non-ARM test, might need to switch the check to darwin rather than mac


Fix infinite animation when smoothscroll destroyed before scroll completes

Note for me: Needs to get version update, compiler run, before merging.
This looks great. Thanks!

This was incorporated into v12, and should now be resolved.


[Feature Request] Add Callbacks for video events in NativeAd

Is the functionality described at https://developers.google.com/admob/android/native/video-ads for Java/Kotlin available in Flutter? I do not see any reference to a VideoLifecycleCallbacks class.
Everything described on this page, including, finding the aspect ratio/duration of the video ad, callback on video end do not seem to be available in Flutter. Would that be accurate?
The reason this is needed is to close the AdWidget and get back to the regular content/media automatically, when the video ad ends, without any user interaction.

Labeling this issue as a feature request for Native Ad. Thanks!

Labeling this issue as a feature request for Native Ad. Thanks!

Makes sense. Thanks.

Ack.


Fix create object url

Hello I also have this problem https://github.com/CrackerakiUA/ngImgCropFullExtended/issues/129, so I made this PR to fix the issue.

Don't know what that change, but it looks cool :)
Can you explain in few words?

Guys, this was a mistake, the window.URL is correct, and the way I fixed it is deprecated. Please revert this PR, I'm sorry, the problem I still have is with the signature in the blob passed in this function.

Done.

@aandresortiz where does the error occur? Can we / i help?

hi @rickerd I am using this directive inside a uib-modal and I was passing the image file from ngFileUpload but when was processing the result image I got a bad signature error, I fixed my issue in my custom directive moving back from a directive that used bindToController to a simple $scope, don't know what exactly was wrong, but in one intent passing an imageUrl instead of the image file, the crop was very slow. There is no problem using $scope and the file image directly. Thanks anyway!

If you don't need live view of cropping area somewhere, add blocking object. In that way you will get ALLOT better performance.


create doc2vec model for Deep AQAtik project

Implementation of the doc2vec model for the task of document similarity on Github issues and Jenkins Logs.
The objective is to have some results and their relevant plots with respect to different parameter setup e.g. window_size, pv-dm/pv-dbow, number of documents.

@smlambert @llxia @LongyuZhang
I'm working on this.


[WIP] [BC Break] Migrate to material-ui 1.0

[x] upgrade dependency (easy peasy)
[x] suffer
[x] make the example compile without error
[x] sweat
[x] make the example display the posts list without error
[ ] suffer again
[ ] Make the layout work in desktop
[ ] Make the layout work in mobile
[ ] cry
[ ] make the list views work
[ ] make the edit views work
[ ] make the show views work
[ ] remove useless components (like <Responsive>)
[ ] work hard
[ ] make the tests pass
[ ] rewrite documentation
[ ] regret
[ ] write upgrade doc (ha!)

Time currently spent: at least 4 hours
Current status:

Congrats on making that change. When do you feel it will be merged?

In a few weeks I guess

Just a question, but did you follow the discussions on the styling standard for material-ui, as highlighted in their doc, and is aor (or ra) going to also follow the same changes?

Oh yes I did, and if you look at the changes in this PR, you'll see that I started converting inline styles to classes. I expect to remove all inline styles from aor.

Now  I understand your pain :)

just a note: i noticed that they dropped datepicker component in material-ui 1.0
so i suggest adding to the todo:

[ ] find/write new datepicker component

No, we'll do as they do and fallback to native datepicker

About the autocomplete component, it might be worth checking https://github.com/paypal/downshift

Switching to RFR. I understand that this PR is impossible to review, so I'll merge it myself within a day anyway.

@fzaninotto I have been reading most of this pull request. I'm impressed by the effort you have put into it! Your effort won't be in vain. I will use this PR in order to improve the migration guide we have!


Need a command for retry /merge but do not run all tests again

This command would be /merge-without-tests which should be used after the committer re-trigger some failed tests.

If the all tests haven't been triggered yet for the current commit, this command should equal to /merge
If there are new commits, should restart all the tests.

@you06  Can I working on this?

@Rustin-Liu Sure, thanks for it, but you may start this work after #35 get merged.


Wallet Password in cleartext shown when entering

4.0.1
Not sure if there is option to **** password but default should in any case not be that the password is shown while typing. :/

Solved on commit
https://github.com/PascalCoin/PascalCoin/commit/8d7262a4f227f9bf6e3bdaacb2ea8f4ff06950fe


PowerShell script incorrect

The PS script shown above misses the first line:
function New-PowerAppsCheckerAzureADApplication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e92c215-b337-b864-3fee-b9542e4e30c8
Version Independent ID: 8f26538c-5863-6746-8c2c-ee4438165da4
Content: Build tools tasks - PowerApps
Content Source: powerapps-docs/developer/common-data-service/build-tools-tasks.md
Service: powerapps
GitHub Login: @mikkelsen2000
Microsoft Alias: pemikkel

@orangetoken Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


Different methods of instrumentation in Service Bus

Hi,
It'd be nice to have a page dedicated on how to enable different types of telemetry in service bus. Specifically, what does end-to-end tracing mean? What are the things we get in Azure Monitor? What kinds of diagnostic logs we get?
Difference between all three?
It is not clear what metrics we get from each of the following:
1> https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-end-to-end-tracing
2> https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-diagnostic-logs
3> https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-metrics-azure-monitor
Also, we need more clarification on exactly what kind of things are captured in App Insights when enabling end-to-end tracing. And to explain in detail how to enable them.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c3af764-3978-6abe-f756-2c2c4ef47e31
Version Independent ID: c4dca68a-1c95-42af-9eb3-e1dc9a66a692
Content: Azure Service Bus messaging overview
Content Source: articles/service-bus-messaging/service-bus-messaging-overview.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

Hi @Infinitism Thanks for your feedback. We will review and update as appropriate.

Hi @Infinitism I have assigned this to content author for further review and update.

These articles have been updated recently.
#please-close

These articles have been updated recently.
#please-close


Support install custom plugin

Reason
Look here, elasticsearch allow install custom plugin from url or file system，but it can't do it due to plugin validate
Changed

Remove plugin validate
Command elasticsearch-plugin use --batch options

PS: English is not my native language; please excuse typing errors.

Hey @OuYangJinTing, thanks for the PR. Agree it should support URLs/files. What issue are you seeing without the --batch option?

Hey @OuYangJinTing, thanks for the PR. Agree it should support URLs/files. What issue are you seeing without the --batch option?

If the --batch option is not passed, the following error will occur.
It needs user confirmation for the operation, but elasticsearch-plugin does not support a similar --assumeyes option. However, I found that its --batch option includes automatic confirmation.

Great, thanks. Let's keep the validation, but update the regex to /^\w\S+$/.

Awesome, thanks for adding / fixing this!


chore: refacto devcontainer

Describe the pull request
A full refacto from scratch of the devcontainer, dev environment with go-task, remove the vanity url for stability.
This will resolve issues:

Resolve #641
Resolve #614

Checklist

[ ] I have made the modifications or added tests related to my PR
[x] I have run the tests and linters locally and they pass
[x] I have added/updated the documentation for my RP

Self review ✅


pull request for e2e test at 01/26/2017 01:26:07

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[models] IntermediateLayerGetter doesn't handle well architectures with modules referenced multiple times

🐛 Minor trouble with IntermediateLayerGetter
Since IntermediateLayerGetter is using the .named_children method of torch.nn.Module, the accepted layers cannot be a layer that is referenced multiple times in the architecture. Using the private ._modules.items() method of the same object would fix it though. Happy to open a PR if you think it's a good idea
To Reproduce
from torch import nn
from torchvision.models._utils import IntermediateLayerGetter

act_layer = nn.ReLU()
mod = nn.Sequential(nn.Conv2d(3, 8, 3, padding=1), act_layer, nn.Conv2d(8, 16, 3, padding=1), act_layer)
layer_getter = IntermediateLayerGetter(mod, {"3": "0"})

raises
ValueError: return_layers are not present in model

Expected behavior
The above snippet should be working without raising any error
Environment

PyTorch / torchvision Version: 1.8.0 / 0.9.0
OS: Linux
How you installed PyTorch / torchvision: conda
Python version: 3.8
CUDA/cuDNN version: CUDA 11.1 / cuDNN 8.0.5
GPU models and configuration: GeForce RTX 2070 with Max-Q Design (driver 450.119.03)

While not directly fixed in IntermediateLayerGetter, the newly provided feature in https://github.com/pytorch/vision/pull/4302 should handle this case without problems.
As such, I'm closing this issue, but let us know if you face any problems with https://github.com/pytorch/vision/pull/4302

Apologies, I left those notifications to make sure I had time investigating the corresponding PR. Thanks a lot @fmassa, that looks exactly like what was needed :pray:


Add a requirements file

It will be good to have a requirements file for the application so that its easy to install the requirements easily !

@itsrifat added requirements file and included some other dependencies. Try it out and if it works, close this issue. Thanks!

I still couldn't get it running. There are some duplicate requirements in the file:

python-dateutil
nose
SQLAlchemy

After commenting out these duplicates having error on installing couple of packages thorugh requirements.txt which are:

GDAL
lxml

So I tried installing these two manually. After that running python models.py runserver from the app directory is giving import  error. The error looks like this:
ImportError: cannot import name current_app

Any thoughts?

I made a mistake in the README, it should be python manage.py runserver, run from the root directorty of the project.

Now getting this:
AssertionError: Config file /home/escenic/vwplatform/default.conf does not exist!

ok, sorry for not including this part in the README. Thanks again for working through this.
You need to edit default.conf.template and fill out user name, password, and virtual watershed address. You also need to write in the path to two directories that start with /PATH/TO/EDIT or something like that. Then save the edited file as default.conf. Don't add your default.conf to be tracked by git!

email me if you need a reminder for the user name and password. They are the ones we got in nm.

I didn't quite get what do you mean by editing default.conf.template ? Where do I need to edit that?

sorry, it should have been included, but it wasn't there.
I just pushed an update that includes default.conf.template in the root directory and two template files in the resources directory. There are two paths PATH/TO/VWPLATFORM where you need to substitute in the path to the project.

This is definitely overly complicated, but I haven't had time to improve it.

Can you also remove the duplicates from the requirements.txt file? And it would be nice to see how to install GDAL and lxml through requirements.txt. if you change and push I can check again if the requiremtns.txt is working properly

OK, done.

This seems to be working now, closing.


Changed build to run all npm builds before backend builds.

This makes yarn install and yarn build before any project builds. It still uses lerna as before.

I confirmed that a failed install makes the build fail.
I confirmed that a failed npm build makes the build fail.
I confirmed that it fixed the resource manager scripts missing from the final build.

The drawback of this approach is that one can no longer build only the persona bar in release mode without using cake. But for dev/debug, the current documented way with yarn start --scope ... is still valid.

/azp run


Sometimes last frame of animated keyframe value incorrectly goes to default value

This will be fixed in the next beta.


Add [vm.] section as syntactic sugar for proxmox users

This pull request improves the user experience for proxmox users by allowing to specify per-VM overrides using a new [vm.<id>]
section.
The usual way to do per-VM overrides was by creating a section like this (in the example for the VM with id 100):
[mdev.00000000-0000-0000-0000-000000000100]
frl_enabled = 0

Many users had problems with the long uuid string, and now they can do this instead (again, for a VM with the id 100):
[vm.100]
frl_enabled = 0

Now, proxmox users don't have to bother with any uuids anymore :)

When using this, I'm getting errors like
Jan 15 17:05:19 pve nvidia-vgpu-mgr[477123]: Failed to decode config: invalid type: string "202", expected u64 for key `vm` at line 11 column 1
Jan 15 17:05:19 pve nvidia-vgpu-mgr[477123]: Failed to apply profile override

My profile_override.toml, for reference:
[profile.nvidia-259]
num_displays = 1
display_width = 1920
display_height = 1200
max_pixels = 2304000
cuda_enabled = 1
#frl_enabled = 1
#framebuffer = 0x74000000
#framebuffer_reservation = 0xC000000

[vm.202]
#frl_enabled = 0
pci_device_id = 0x1E30
pci_id = 0x1E3012BA

@abraha2d I just fixed it in https://github.com/mbilker/vgpu_unlock-rs/pull/28


SSE endpoints are not delivered correctly

Dan and I observed a new bug in the SSE endpoint /projects/x/packfile-end. All responses are not delivered in real-time as they should be, and instead are buffered and delivered all at the end.
This causes two problems. One, the progress or other live events are not delivered to the user in a timely fashion, and two, the gateway will time out if the operation takes too long because no traffic is being sent.
You can observe this by adding time.sleep(1) to PackfilePlacer.finalize.
Ryan, my initial thought is this might be an gateway problem. Nginx response buffering?

@kofalt Which part of the stack is timing out, the web client (browser)?
 Something simple to rule out TCP buffering as a cause would be to run with socket option TCP_NODELAY. I'll confirm how to do that with our docker environment and get back to you.

tcp_nodelay is already enabled with our nginx. Looking at uwsgi next...

Nginx delivers a gateway timeout. You can trivially reproduce by adding import time; time.sleep(1) to this line and uploading a sufficiently large dicom set (mine happened with a series of ~250 dicoms).

I'm not sure what changed, because this definitely used to work. Maybe we should diff our uwsgi / nginx configs from 6 months ago or so? Bisect? :slightly_smiling_face:

@kofalt I can reproduce issue fine. I've confirmed that SSE responses are not flowing out of uwsgi until all responses are available. This is after applying the tcp-nodelay flag to uwsgi.
Command I'm using to inspect that traffic... docker run --rm --net=container:docker_uwsgi_1 crccheck/tcpdump -i any --immediate-mode -w - | wireshark -k -i -
Conclusion: Nginx is not the cause.

Nice!

Any update on this? The server will timeout large operations until this is fixed.


Move to CSSNano for minification

Move to using CSSNano to minify the CSS. It removes duplicate rules and can merge long-hand rules into short-hand for us. Along with a few other cool things if we want it.

Definitely worth checking out, but we need to be evaluate carefully (maybe we should spin up our visual tests for this). Features like “Rebasing z-index values” are not to be taken lightly in connection to our microsite e.g.

We can turn off the rebasing z-index. Already planning on that one due to dialogs and snackbars. I'm more worried about removing duplicate rules, super-minimizing of whitespace, combining selectors for things with exactly duplicate rules (just in case.) etc.
I'll go over the list again later and list out what I consider "safe", "possibly unsafe", and "hazardous" optimizations for us. We can turn off hazardous things, use the safe ones, and then analyze the middle ground for if they should get used or not.

Oh cool, there is a safe config option to handle that already. But we can ofc get more granular if something becomes a problem beyond that.

Webpack handles minification pretty well it seems like.

Webpack's actually uses CSSNano under the hood when optimizations are turned on 😄 .


Correctly deselect properties of TileDataCollisionEditor

Fixes #56251
This connects a method to the selected signal and deselects every EditorProperty of TileDataCollisionEditor::property_editors with a different name.

Thanks!


README: Remove IRC channel

Most questions on IRC are ignored, therefore it does not make sense to mention it in the README.

The questions are not ignored. There can be situations when no one is present when the question is asked.
I do not see the value of removing this from the README.

This year, I see 7 topics raised by contributors, only two were responded to. There is no development discussion otherwise, for example between you, Gris and Wen so pointing people in the README to a mostly non-functional IRC channel is not very helpful. Removing the IRC channel (and decommissioning it) will avoid that people join there unnecessarily.

@cathay4t what is your opinion?

I prefer removing IRC from README.


bosh() helper for hooks

We have an environment variable called GENESIS_BOSH_COMMAND, but that's annoying.
Can we have a bosh function that just runs that for us, with proper argument quoting?
i.e.
bosh() { $GENESIS_BOSH_COMMAND "$@"; return $? }

Also adding on for genesis() instead of $GENESIS_CALLBACK_BIN for same reason


Implement tags for transactions

It would be nice to have the ability to add multiple groups to transactions.
For example a transaction could be in the group "recurring payments" and "donations".
This would really help to organize transactions, which fit more than one group.

I now imagine groups entry in transaction dialog similar to the labels list here on github... Colored pill buttons, with a group name and small x button inside, circular + button on the right side of the list that opens a popup with a list of all groups. Yeah, looking at my contributions, it seems like I'm thrilled by colors, haha 🤣  Gonna make a mockup later.

Just to throw my two pence in: If we do implement this, then it would make the count up on the side more complicated, as the sum off all the groups would not equal your total money.

Just to throw my two pence in: If we do implement this, then it would make the count up on the side more complicated, as the sum off all the groups would not equal your total money.

Well the Total, income, and expensas of the account is calculated only from the transactions themselves and has nothing to do with groups, hence why they are two separate sections.

If we do implement this feature, this will create some other problems: the CSV will be almost impossible to do, unless each transaction is duplicated... It would look like that for a transaction that belongs to two groups Group1 and Group2:
1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);-1;Group1;Description 1
1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);-1;Group2;Description 2

This would ruin the ability to use the CSV in an external tool like Excel. Plus, from what I've seen in many apps, including my banking app, only one group is added to a transaction...

the CSV will be almost impossible to do, unless each transaction is duplicated...

Groups in CSV can be comma separated, so the only problem is to mask commas in groups' names and descriptions when exporting. Or it's possible to use another symbol as separator for groups in CSV (maybe |?) So your example will look like this:
1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);1|2;Group1|Group 2;Description 1|Description 2

Plus, from what I've seen in many apps, including my banking app, only one group is added to a transaction...

Sounds awesome to me, implementing a feature that other apps don't have! 😄

Came here to make the same suggestion about categories/tags, so thumbs up for this idea.
I'd like to add one more suggestion: make the description an optional field. At the moment it is mandatory, but I feel like categories/tags are quite self-explanatory and most of the time don't need a description (e.g. I have categories like 'insurance', 'groceries', ...).

make the description an optional field

#111

@fsobolev So how do we feel about doing this next? Do you want to make some mockups of how a tagging system would work (in conjunction with the current grouping system)?

This is my old mockup. Tbh I want to change it completely, but basically the idea and functionality can be the same: each transacion can have any number of tags, they're not in any way related or connected to groups. I don't think we have a good place in sidebar to always show tags there, but maybe we can show them somewhere when a user searches transactions, I have a few ideas, will do some mockups later and we'll see what looks best. I think we can make tags immutable, meaning once created they can't be changed, only deleted, this way we'll be able to have tags as comma separated list in Tags column in CSV, without Ids or other additional info.

https://github.com/NickvisionApps/Denaro/releases/tag/2023.8.0-beta3


Support for multi-query statements

The postgres protocol supports sending multiple queries across different tables/views (separated by semi-colon) in one request and receiving the results.  Currently Skunk explicitly does not support this:
From Query.scala
          case ReadyForQuery(_) =>
            new SkunkException(
              message   = "Multi-statement queries and commands are not supported.",
              hint      = Some("Break up semicolon-separated statements and execute them independently."),
              sql       = Some(stmt.sql),
              sqlOrigin = Some(stmt.origin),
            ).raiseError[F, Unit].whenA(multipleStatements)

Even if you have parallelizeable queries in a transaction, currently clients are forced to submit the queries one at a time, waiting for the results of the first query before submitting the second query.  If you have a lot of queries and a decent amount of latency between your app/db servers this can add up.
I'm interested in adding support for this and am digging around but wouldn't mind if anyone had any pointers or reasons why this could never work with the Skunk model.

How would you imagine it looking? What would the type of such a query be?

Hello, I had another use case for this, just to provide some input. I am trying to replace flyway that we use for forward-migrations only in our codebase using skunk and bootstrapped dumbo.
I started by reading the files which can contain multiple statements and then just fileContent.split(';') to split it into single-query statements which worked fine until I encountered cases with like CREATE FUNCTION statements having ; all over the place which made it more difficult to parse.
Later I found out that one can just send the whole file content to Postgres as it supports multi-query statements which made it much easier. In this case I was interested on running multiple statements within a transaction and don't really care about the output as long as it is not an error, similar to how Flyway would handle it. Flyway also doesn't care whether you run queries or commands in your migration script, as long as there is no error from Postgres it will execute it and update the migration state.
I currently applied a workaround, basically by changing the signature of finishUp to keep accumulating received backend messages instead of failing together with a multiple completion case case class Multiple(list: List[Completion]) extends Completion. It did the job for this case, but not sure about how this could be modelled well in skunk.
// from
def finishUp(stmt: Statement[_], multipleStatements: Boolean = false): F[Unit]
// to
def finishUp(stmt: Statement[?], messages: List[BackendMessage] = Nil): F[List[BackendMessage]]

Sources:

https://github.com/rolang/dumbo/blob/main/modules/core/shared/src/main/scala/skunk/net/protocol/Query.scala#L37
https://github.com/rolang/dumbo/blob/main/modules/core/shared/src/main/scala/skunk/data/Completion.scala

I believe I found a better solution for the case I described above :thinking:  Just raised https://github.com/typelevel/skunk/pull/1023


Added docker setup for local env

Description
Added docker and docker-compose setup to run the service locally.
$ make run-local
...
$ make stop-local

Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[ ] I have added at least 1 reviewer
[x] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[ ] I have tested this code with the official test suite
[x] I have tested this code manually

Hey @begmaroman,
Thank you for your first contribution to the Edge codebase 🙏
I've added our DevOps wizards @ZeljkoBenovic and @epikichi to also give feedback.
Please follow the instructions by the CLA bot, so the contributor list is maintained correctly:
https://github.com/0xPolygon/polygon-edge/pull/747#issuecomment-1253563420

I have read the CLA Document and I hereby sign the CLA


More idiomatic Rust

Benchmarking CI is still running in my fork, but the other one finished successfully.
This PR tries to make code more idiomatic in Rust in a few ways:

fn default() in some trait replaced with dependency on standard Default trait with corresponding re-duplication
Many data structures got derives (sometimes instead of manual implementation) for traits Debug, Clone, Copy, Eq
As the result of those changes clippy was able to find numerous places to complain about, those were changed accordingly

The only non-equivalent change is that this was effectively replaced with Self::new(0):
impl Poly<FsFr> for LPoly {
    fn default() -> Self {
        Self::new(1).unwrap()
    }

There was already Default was already derived for LPoly automatically (with empty coefficients, naturally). In this self-conflicting situation I decided to prefer derived implementation since that is how other implementations are done too.
The rest of changes are mechanical even though API has changed slightly.
There are absolutely still things to improve, but I think this is a decent progress deserving its own PR.

Thanks @nazar-pc !
@belijzajac could you double-check and merge?


The code does not work on items that pop in when you scroll to the bottom of a collection

On the item collections, when you scroll to the bottom new items pop in these items the code does not run on I assume there needs to be an event or MutationObserver that needs to be added to watch for the items.


[vcpkg baseline] Skip libgnutls:x64-osx in Ci testing

Related to https://github.com/microsoft/vcpkg/pull/16596#issuecomment-802405156
The libgnutls:x64-osx failed with following failures which is expected, skip it in CI testing.
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _aoGetsText in libcmd-serv.a(serv-args.o)
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [gnutls-serv] Error 1
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link'
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link/'
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _aoGetsText in libcmd-cli.a(cli-args.o)
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link'
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link/'
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [gnutls-cli] Error 1
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
      _aoGetsText in libcmd-srp.a(srptool-args.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [srptool] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

This LGTM, thanks!


Blacklisting a customer

Hi,
When we detect a fraud or have a commercial dispute, we cannot blacklist the customer TWINT/CC/Postfinance number as we never know it due to the PCI compliance.
Is there a way to blacklist a specific TWINT/CC/Postfinance number? So even if the user recreate an account with a different identity (phone number, ip, email, etc), they will not be able to make a transaction.
Thank you. :)

Hi
thank you for your request.
Please contact<EMAIL_ADDRESS>directly for your issue.
Have a great day.


pb with spectral_step UCD

There was a regression in the previous version on this point.
Should be em.freq;spect.binSize

fixed on 22/10 version


[TS Migration] Migrate storage, utils and OnyxCache to Typescript

Details
First TS migration that focuses on storage, utils and OnyxCache. I also had to adjust eslint configuration.
Related Issues
https://github.com/Expensify/App/issues/34340
Automated Tests
N/A
Manual Tests
General tests, clicking through the app and checking if data is saved correctly
Author Checklist

[x] I linked the correct issue in the ### Related Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android.webm

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/react-native-onyx/assets/46095609/c7b06aa3-5a46-4067-a04f-a2f3113c5ed0

iOS: mWeb Safari
https://github.com/Expensify/react-native-onyx/assets/46095609/87ab8c89-ac28-48f6-beb5-75b9c2553d91

MacOS: Chrome / Safari
https://github.com/Expensify/react-native-onyx/assets/46095609/d0aab833-57cd-449c-a8f3-6697ca0d66da

MacOS: Desktop
https://github.com/Expensify/react-native-onyx/assets/46095609/f0be5c60-6dea-4404-a119-76b1c4132f60

@pecanoro All yours!

Thank you for your patience!


ConfigurationContainerScope: Add property name extensions for resolva…

…ble, consumable and dependencyScope

Fixes #26601
Context

Contributor Checklist

[X] Review Contribution Guidelines
[X] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[X] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[X] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[X] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[X] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[X] Ensure that tests pass sanity check: ./gradlew sanityCheck
[X] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

Thank you for your contribution!
This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices.

At the moment, we don't want to add delegated properties for these new methods.  This makes the Kotlin and Groovy DSLs more different.
Thanks for your contributions.

How is this different to the existing tasks or DomainCollection delegated properties only provided for the Kotlin DSL without a groovy counterpart?

It's not different. We're not sure the existing ones were the best idea


V1.0.2 printing layout fix

Changes:

fixed trailing comma in package.json
updated gitignore to ignore compiled files
changed text. "Nav Coin" -> "NavCoin"
removed test encryption buttons when you print
changed window size to be correct
set print page width and height to be correct sizes

Whoops, will fix
On 3/03/2018 14:11, "alex v."<EMAIL_ADDRESS>wrote:

@aguycalled approved this pull request.
In css/print.css
https://github.com/NAVCoin/paper-wallet/pull/7#discussion_r171999135:

@@ -1,8 +1,15 @@
-.header, .form, .footer, .info, .paper-title, .pt-output {
+@page {

size: A4 portrait;
max-height:100%;
max-width:100%;

line 3 is indented with 2spaces, line 4 with tab
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NAVCoin/paper-wallet/pull/7#pullrequestreview-100956820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMFcMqpzJ6h7tzh5-ZRdEJSO4oQX9Vliks5tae3XgaJpZM4Sapvo
.


net context: write only the maximum payload net_pkt can hold

Attempt to fix #13211
@aurel32 , @pfalcon I could not get internet access to qemu. I have an heavy setup on my work laptop (vpn, proxies etc...) and it's probably getting on the way. Could you check?

@tbursztyka: You don't need internet access to reproduce the issue reported by @aurel32 originally. The sample dumb_http_server against which the regression was reported, works locally between qemu and host. Given that the previous "default" test, echo_server is gone, I propose that we standardize on dumb_http_server being the default test. Using it is simple:

Build/run samples/net/sockets/dumb_http_server.
If so desired, use telnet <IP_ADDRESS> 8080 to manually make an HTTP request (GET / HTTP/1.0\r\n\r\n) to see all details of working.
Otherwise, use curl http://<IP_ADDRESS>:8080/
Finally, put it under some load with ab -n1000 http://<IP_ADDRESS>:8080/ (watch for consistent response size and times in the report).

So, I tested it and indeed this patches fixes the issue. My output:
Server Software:
Server Hostname:        <IP_ADDRESS>
Server Port:            8080

Document Path:          /
Document Length:        2122 bytes

Concurrency Level:      1
Time taken for tests:   211.819 seconds
Complete requests:      10000
Failed requests:        0
Total transferred:      21810000 bytes
HTML transferred:       21220000 bytes
Requests per second:    47.21 [#/sec] (mean)
Time per request:       21.182 [ms] (mean)
Time per request:       21.182 [ms] (mean, across all concurrent requests)
Transfer rate:          100.55 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        2    5   2.5      4      42
Processing:     9   16   3.9     16     120
Waiting:        6   11   3.1     10      81
Total:         12   21   5.3     20     147

Percentage of the requests served within a certain time (ms)
  50%     20
  66%     21
  75%     22
  80%     23
  90%     25
  95%     30
  98%     36
  99%     43
 100%    147 (longest request)

Codecov Report

Merging #13246 into master will increase coverage by <.01%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master   #13246      +/-   ##
==========================================
+ Coverage   48.75%   48.75%   +<.01%
==========================================
  Files         319      319
  Lines       46871    46878       +7
  Branches    10835    10837       +2
==========================================
+ Hits        22850    22854       +4
- Misses      19394    19395       +1
- Partials     4627     4629       +2

Impacted Files
Coverage Δ

include/net/net_pkt.h
85.65% <ø> (ø)
:arrow_up:

subsys/net/ip/net_pkt.c
65.41% <66.66%> (+0.01%)
:arrow_up:

subsys/net/ip/net_context.c
58.92% <71.42%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaae57...b024789. Read the comment docs.

@pfalcon Actually socket based echo apps still exist (and are way much simpler than original echo app that were removed). I still use them for testing. But I agree, using dumb_http_server/big_http_download as an extra default for tcp would be nice. Thanks for trying the patches.

@tbursztyka Thanks for the patch. It works fine using QEMU, however it fails to work with the SAM E70 Xplained board. There is an improvement though, it blocks after downloading 1393 bytes. I do not have my IMXRT1020 board at hand to give a try, I can do that tonight.

I also only tested with qemu_x86. @aurel32: do you have any other networked hw besides sam_e70?

I also only tested with qemu_x86. @aurel32: do you have any other networked hw besides sam_e70?

Yes, I have a MIMXRT1020 board, but not at hand currently. I'll test tonight.

I have just tried with USB networking (CONFIG_USB_DEVICE_NETWORK_EEM=y) and it also doesn't fix the issue. Small payload (using #define USE_BIG_PAYLOAD 0) still works fine.

Is this the same issue (-ENOBUFS context_sendto_new) or something else?
Note there are a lot of issues around TCP. The new net_pkt API and packet flow has changed timings (it's much faster) and has revealed numerous concurrent access issues on net_context  and tcp objects. These last ones aren't protected actually (net_context got a mutex recently)
For instance, if you start echo server, and echo client and then stops echo client: when server finally closes the tcp connection it crashes.

Is this the same issue (-ENOBUFS context_sendto_new) or something else?

No from the application point of view, everything is fine, ie the 2181 bytes of payload passed to send() are send in two steps, first 1452 bytes on the first call to send() and 729 bytes on the second call.
Now looking at the traffic with tcpdump, only the first 1452 bytes packet actually arrives to the host.

Tried to test on frdm_k64f, but it's broken: https://github.com/zephyrproject-rtos/zephyr/issues/13251 , https://github.com/zephyrproject-rtos/zephyr/pull/13250

The second packet has the last frag with a zero len. It seems the GMAC driver isn't prepared for that. That said a quick and dirty fix to ignore that frag doesn't seems to fix the issue.

Actually my fix was to quick and dirty. The problem is indeed that the GMAC driver doesn't handle the case of a frag with zero length. I'll try to work on a clean fix later today. Should I base it on PR #13167?

@aurel32 nice. About USB, I think the MTU there is just wrong: 1522? That would explain why nothing goes through.

A quick look at the code shows that at least drivers/eth_dw.c also needs a fix to handle zero len frags. I am not sure about drivers/wifi/winc1500/wifi_winc1500.c, someone might need to have a look. Same for the ieee802154.c and openthread.c L2 code.

There are indeed places that still play directly with "frags", which is not nice. We might have to provide net_pkt.h helpers to do that. So the code going through the net_buf list would be at a unique place instead of scattered all around, reducing this kind of issues. That said, I wonder why there is a frag with len 0. Over allocation? Something worth to look at.

@aurel32 nice. About USB, I think the MTU there is just wrong: 1522? That would explain why nothing goes through.

I confirm that reducing NETUSB_MTU to 1500 fixes the issue. Now I wonder why it got increased to this value in 766101cf097f1e344f4516bc2a32937dba702746, ie a few days ago.

Indeed, that's a mix up of "physical MTU" and network MTU.

@aurel32, @tbursztyka: +1 for the hunch that there should not be fragments of size 0 fed into drivers. I hope @tbursztyka could look into it, perhaps he might need more info on how to reproduce it?

I hope @tbursztyka could look into it, perhaps he might need more info on how to reproduce it?

For me it's reproducible with the default dump_http_server sample. For example I configure it with:
cmake -GNinja -D BOARD=mps2_an385 -DCONF_FILE="prj.conf overlay-smsc911x.conf" ..
Then add the following debug code:
diff --git a/subsys/net/l2/ethernet/ethernet.c b/subsys/net/l2/ethernet/ethernet.c
index 408ba50a83..f8aec043cd 100644
--- a/subsys/net/l2/ethernet/ethernet.c
+++ b/subsys/net/l2/ethernet/ethernet.c
@@ -511,6 +511,7 @@ static int ethernet_send(struct net_if *iface, struct net_pkt *pkt)
        struct ethernet_context *ctx = net_if_l2_data(iface);
        u16_t ptype;
        int ret;
+       struct net_buf *frag;

        if (IS_ENABLED(CONFIG_NET_IPV4) &&
            net_pkt_family(pkt) == AF_INET) {
@@ -579,6 +580,12 @@ static int ethernet_send(struct net_if *iface, struct net_pkt *pkt)
        net_pkt_cursor_init(pkt);

 send:
+       frag = pkt->frags;
+       while (frag) {
+               NET_DBG("frag->len = %i", frag->len);
+               frag = frag->frags;
+       }
+
        ret = api->send(net_if_get_device(iface), pkt);
        if (ret != 0) {
                eth_stats_update_errors_tx(iface);

That should give you a log like that for the second packet:
[00:00:13.262,562] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 14
[00:00:13.262,565] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 40
[00:00:13.262,572] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 128
[00:00:13.262,575] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 128
[00:00:13.262,585] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 128
[00:00:13.262,588] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 128
[00:00:13.262,593] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 128
[00:00:13.262,599] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 89
[00:00:13.262,606] <dbg> net_ethernet.ethernet_send: (0x20000b84): frag->len = 0

@aurel32 thanks, now I know why. It's actually "nominal" as the allocator computes headers size on the maximum size it can take (On TCP that is). And because of fixed data size of buffer, it might be even for 1 byte of extra space computed, a net_buf will be allocated but never used.
I'll come with a fix for it, in this PR. Imo, it should not be up to each and every driver to handle this. net_pkt buffer should be trimmed at relevant place.

@aurel32 I believe the added commit should fix the !frag->len issue. I need to test it more thoroughly,  however

@aurel32 I believe the added commit should fix the !frag->len issue. I need to test it more thoroughly, however

Thanks for the additional patch, I confirm that it's possible to send big TCP payload with the GMAC driver again.

FYI, this patch also fixes DTLS communication over sockets.  I hadn't noticed it was broken till after the socket API changes were merged and have been debugging it for a few days.


Do profiling for mode_appt_constraints = 2 too

Perform profiling in #286 for mode_appt_constraints = 2 too

Hi @marghe-molaro - for this issue do you mean to produce SnakeViz plots like those in #286 for mode=2 automatically, or just as a one-off? If a one-off, I can set a run off this week and post the output here.
At present, the profiling workflow that runs weekly is running in mode 2 (http://github-pages.ucl.ac.uk/TLOmodel-profiling/profiling.html) and it outputs information about time spent in each function like this. This organises time spent in each function by the call-stack, rather than pooling the time in each function like in the plots of #286.
If you think it would be useful to produce such plots as part of the automated workflow (that gets published to the profiling page), just say so and I can look into it.

Hi @willGraham01, ideally as we move to mode=2 being used as frequently as mode=1 we'd have the entire profiling framework applied to mode=1 being applied to mode=2 also, and just as frequently. The issue though is one of resources being limited - both to do the profiling runs and to analyse/optimise the code based on those outputs - so I think how many of the available resources should be allocated to the mode=1 vs =2 analysis is one for @tbhallett to answer.


[Forwardport] Fix handler registration issue affecting access control

2.5 issue:

rancher/rancher#31982

Relevant PR:

https://github.com/rancher/rancher/pull/35172

The changes from the above PR need to be forwardported into 2.6. This issue: https://github.com/rancher/rancher/issues/34732 included the fix for the access control cache, but not the registration fix.
Repro steps for testing this can be found here: https://github.com/rancher/rancher/issues/31982#issuecomment-942221068

verified on v2.6-head 4375161

Created an rke1 cluster on HA rancher server
Created a custom role with deployment as resources and verbs get,list,create
Enabled openldap and assigned user1 in default project in the rke1 cluster
Logged in as user1 and verified user1 has access to deployments only.
Updated the roles to only have configmaps with verbs get,list,create and removed deployments
Refreshed the URL of user1 and verified only config maps can be accessed.