Roll Flutter Engine from f3d48be76630 to aee816771ef4 (8 revisions)

https://github.com/flutter/engine/compare/f3d48be76630...aee816771ef4
2024-01-28<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from GBTh3gOOgmndwT70X... to 5aijurFz23iIuRaMQ... (flutter/engine#50126)
2024-01-28<EMAIL_ADDRESS>[Impeller] Fix alpha management issues for advanced blends. (flutter/engine#50070)
2024-01-28<EMAIL_ADDRESS>Roll Skia from 0c1e352e87aa to 40205cafdb4e (1 revision) (flutter/engine#50124)
2024-01-27<EMAIL_ADDRESS>Roll Dart SDK from 422d048880a8 to 639cf51f4472 (1 revision) (flutter/engine#50123)
2024-01-27<EMAIL_ADDRESS>Revert "[Windows] Introduce egl::Surface and egl::WindowSurface" (flutter/engine#50104)
2024-01-27<EMAIL_ADDRESS>Roll Dart SDK from d0b48a008559 to 422d048880a8 (1 revision) (flutter/engine#50121)
2024-01-27<EMAIL_ADDRESS>Roll Skia from b9b80230c87b to 0c1e352e87aa (1 revision) (flutter/engine#50120)
2024-01-27<EMAIL_ADDRESS>Roll Dart SDK from 141ab6c14cd1 to d0b48a008559 (1 revision) (flutter/engine#50119)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GBTh3gOOgmnd to 5aijurFz23iI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Calculate route very slow

Hello,
I'm computing route from a central point and many points around it (between 200 and 300 points).
I've loaded a routerdb created with the idp tool for pedestrian vehicle (from geofabrik france-latest.osm.pbf).
For most of the calculate it's very fast but suddenly it took a long time.
I've put a stopwatch to track the time and here an example  :
50,28602 / 2,79988 vers 50,27105 / 2,798653 00:00:00.0245858
50,28602 / 2,79988 vers 50,27176 / 2,792633 00:03:54.8091899
50,28602 / 2,79988 vers 50,27185 / 2,792245 00:00:00.0296471
note :
- it seems that the garbage collector is doing something (maybe unrelated)
- if i put a breakpoint and retry the calculate on the faulty point, it's fast has hell
I've downloaded the src version and modified the basic sample to try it and i've the problem too.
I'll join the log file with all the points, if you want to give it a try.
i'm using itinero pre64 and itinero.osm pre64 with c#
Any help welcome because i'm in a dead end ....
Thanks
log 1.txt
Pseudo code :
              var routerDb = new RouterDb();
                using (var stream = File.OpenRead(routerFile))
                {
                    routerDb = RouterDb.Deserialize(stream);
                }
                router = new Router(routerDb);

for each point
{
   Result<RouterPoint> point2= router.TryResolve(profile, latitude, longitude);
                if (!pointTest.IsError)
                {
                    try
                    {
                        stopwatch.Start();
                        var chemin = router.Calculate(profile, point1, point2);
                        stopwatch.Stop();
                        logline = $"{point1.Latitude.ToString()} / {point1.Longitude.ToString()} vers {point2.Value.Latitude.ToString()} / {point2.Value.Longitude.ToString()} {stopwatch.Elapsed.ToString()}\n";
                        info = new UTF8Encoding(true).GetBytes(logline);
                        logstream.Write(info, 0, info.Length);

                        stopwatch.Reset();
                    }
                    catch (Exception)
                    {
                    }

                }
}

Thanks for the feedback, this is interesting. I'll try and have look soon, pretty crucial issue this.
This is also a good test to include in the functional testing. :+1:

@xivk , i've just downgraded to version 1.3.2 for routing and OSM and the problem does not occur in the same conditions ...
I'll try with other version soon ...
Hope this helps

@xivk , i've downgraded to version 1.3.2 for routing and OSM and it works flawlessly ...
May be something introduce in the 1.40 version ...
Can give a try to find when this has been broken ...

I was looking at this just now. I realized we are already testing for this scenario in the functional tests but we only test with a contracted graph. If I understand correctly this is happening after a long time and on random routes?
I just can't reproduce this issue. Are you running on .NET core or .NET framework?

Yes, i'm not using contracted route, i've uses idp tool with pedestrian parameter for france.
I'm using .net framework. In fact, I've injected my code into your source of itinero and try from there. So, basically I'm using the technology you're using :)

Thanks for the feedback, I'm still trying to reproduce this. Two questions:

It is always the same route that is slow?
Does the route succeed after those 3 mins, in other words, do you get a result?

I would advise you to contract the graph, it will be a lot faster.

Ok, thanks.
It's unlikely that this has something to do with garbage collection, probably something in Itinero. The only option I can think of is that sometimes Itinero doesn't handle routes that can't be found very gracefully. That has improved in the last version.
Closing this issue for now, feel free to reopen if you have this problem again.


ResNet50 segmentation model pre-trained on Imagenet

Hello, how to use the ResNet50 segmentation model pre-trained on Imagenet with stride=8

Please see https://hangzhang.org/PyTorch-Encoding/model_zoo/segmentation.html for details


qownnotes: 24.8.5 -> 24.8.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/pbek/QOwnNotes/releases.
meta.description for qownnotes is: Plain-text file notepad and todo-list manager with markdown support and Nextcloud/ownCloud integration
meta.homepage for qownnotes is: https://www.qownnotes.org/
meta.changelog for qownnotes is: https://www.qownnotes.org/changelog.html
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.8.6 with grep in /nix/store/fhkhw9f5znsjdzjjg7azm7d1lmxn8ckm-qownnotes-24.8.6
found 24.8.6 in filename of file in /nix/store/fhkhw9f5znsjdzjjg7azm7d1lmxn8ckm-qownnotes-24.8.6

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

qownnotes

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fhkhw9f5znsjdzjjg7azm7d1lmxn8ckm-qownnotes-24.8.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A qownnotes https://github.com/r-ryantm/nixpkgs/archive/8dd14b167b11af50b6b9498619489bf3f4cd0d0c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8dd14b167b11af50b6b9498619489bf3f4cd0d0c#qownnotes

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fhkhw9f5znsjdzjjg7azm7d1lmxn8ckm-qownnotes-24.8.6
ls -la /nix/store/fhkhw9f5znsjdzjjg7azm7d1lmxn8ckm-qownnotes-24.8.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qownnotes

Maintainer pings
cc @pbek @totoroot for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

qownnotes build failed on aarch64-linux : https://logs.ofborg.org/?key=nixos/nixpkgs.336920&attempt_id=c693886f-dc78-4abe-9dd6-4578f5a5cdd4
-- Found WrapAtomic: TRUE
-- Checking for module 'botan-2'
--   Found botan-2, version 2.19.5
-- Found Botan2: botan-2 (found version "2.19.5")
Botan2_INCLUDE_DIRS /nix/store/xqixjxhp2pk8zsm3p4hvbl3v0yzj4608-botan-2.19.5-dev/include/botan-2
CMake Error at cmake/FindBotan2.cmake:42 (set_target_properties):
  set_target_properties called with incorrect number of arguments.
Call Stack (most recent call first):
  libraries/botan/CMakeLists.txt:21 (find_package)
Non-debug build configuration detected
CMake Deprecation Warning at libraries/qhotkey/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.
  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

In this release? That's strange. Things changed (CMake) in the last release with https://github.com/pbek/QOwnNotes/issues/3076...
@NickCao, do you have an idea to get around that?

Per the error message, one of the variables here is undefined: https://github.com/pbek/QOwnNotes/blob/v24.8.6/src/cmake/FindBotan2.cmake#L43-L45. But there are not cmake related changed between these two releases? And this only manifests on aarch64.

Botan2_INCLUDE_DIRS is set, I would assume the same for Botan2_FullLibraryPath, but maybe Botan2_LDFLAGS_OTHER should have been Botan2_LDFLAGS?
https://cmake.org/cmake/help/latest/module/FindPkgConfig.html

Do you care to create a pull request to be tested in the next release?

So this is the difference between these two platforms. Maybe cmake is interpreting ; as a field separator?
aarch64: Botan2_LDFLAGS_OTHER -fstack-protector;-pthread
x64_64:  Botan2_LDFLAGS_OTHER -fstack-protector;-m64;-pthread

Quoting the variables works.
--- a/src/cmake/FindBotan2.cmake
+++ b/src/cmake/FindBotan2.cmake
@@ -40,9 +40,9 @@ if(Botan2_FOUND)
             UNKNOWN IMPORTED GLOBAL
         )
         set_target_properties(Botan2::Botan2 PROPERTIES
-            INTERFACE_INCLUDE_DIRECTORIES ${Botan2_INCLUDE_DIRS}
-            IMPORTED_LOCATION ${Botan2_FullLibraryPath}
-            LINK_FLAGS ${Botan2_LDFLAGS_OTHER}
+            INTERFACE_INCLUDE_DIRECTORIES "${Botan2_INCLUDE_DIRS}"
+            IMPORTED_LOCATION "${Botan2_FullLibraryPath}"
+            LINK_FLAGS "${Botan2_LDFLAGS_OTHER}"
         )
     endif()
 endif()

A better fix in https://github.com/pbek/QOwnNotes/pull/3090

A better fix in pbek/QOwnNotes#3090

Builds fine for me, thank you very much!

Should we wait for the aarch64 check and merge this or wait for the next release with https://github.com/pbek/QOwnNotes/pull/3090?

Since you are releasing very often (unlike some other projects...) I think waiting for the next is easier.

Since you are releasing very often (unlike some other projects...) I think waiting for the next is easier.

Fine with me. But I wonder if https://github.com/NixOS/nixpkgs/pull/334463 actually built on aarch64, I can't see any build results. Should we close this PR?

But I wonder if #334463 actually built on aarch64

Nope, same as this one: https://github.com/NixOS/nixpkgs/runs/28748442889

Should we close this PR?

Also nope, we shall keep it draft otherwise r-ryantm would promptly open a new one.

Thank you!

I'm closing this in favor of https://github.com/NixOS/nixpkgs/pull/338446.


Add extra nullcheck after null assignment

I wasn't quite sure if I should flip the nullcheck, but I figured I'd open a PR anyway to get the conversation started.
(I only managed to start the app pretty late, and these NPEs hit)

Thanks for the PR. That's polished and merged with 3781911.

Thanks for merging it!


Check and accept EULA in brkt-cli

This is an initial code review, just to validate the approach.  Before
merging, we need to finalize the EULA text and update the integration
tests to pass the username and password to the CLI.
Add --username (required) and --password (optional) arguments to brkt-
cli.  If --password is not specified, prompt the user for the password.
If the EULA has not been signed, prompt the user with the link to the
EULA text.  The user must type the word "yes" (case-insensitive) in
order to accept the EULA.
Add a new BracketService class for code that talks to the Bracket
service API.

The change to the version code in setup.py is cruft.  I'll fix it.

Will open another pull request with the latest code.


Don't count mouse WheelDown/Up as buttondn

If a mouse event is a scroll, either up or down, don't set the buttondn boolean to true, thereby ensuring buttons are cleared on subsequent mouse movements.
This resolves the issue where scrolling up/down and then moving the mouse causes further MouseWheel events.
See issue for more details:
closes #600

I'll try to run some tests to verify that this doesn't break anything -- I don't expect it will.


[bazel] Annotated disassembly

The disassembly produced by bazel is not annotated, i.e. it doesn't have the source code inline. We prefer annotated disassembly for reviews.
bazel-out/k8-fastbuild-ST-[...]/bin/sw/device/silicon_creator/mask_rom/mask_rom_fpga_cw310.elf.s

I have a draft that uses no-sandbox here: #13150


Update README.md

Fix missing / in install script

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thanks :)


Aggressive caching in OpenApi Normalizer

This caching is too aggressive:
https://github.com/highsidelabs/saloon-sdk-generator/blob/eacbcf7f53e9030bbcd5a2a92c0dd60ad7b2f51b/src/Normalizers/OpenApiNormalizer.php#L127-L129
as we treat properties as schemas, so if the items property is used anywhere before, then the second usage will get the cached value with the wrong schema reference:
See: https://github.com/jlevers/selling-partner-api/issues/726
The quick (and nasty) solution might be not to cache any "schema" starting with lowercase letter, something like:
$firstLetter = substr($name ?? '', 0, 1);

// We occasionally want schemas to be anonymous, like an inline schema in an allOf.
// There's no good way to name them, and we can parse them without a name
if ($name && $firstLetter === strtoupper($firstLetter)) {
    $this->normalizedSchemas[$name] = $schema;
}

but I guess there is a better option there. It was just my quick digging around what's wrong when trying to migrate to v6.

Thanks for point this out – fixed in v2.1.0.


Add maxCommits to CentralDogma.getHistory()

Motivation:
It would be nice if we can specify the number of maximum commits for history call
as we have in Go client.
Modification:

Add maxCommit parameter to CentralDogma.getHistory() and maxCommit setter to HistoryRequest.

Result:

You can now limit the number of commits when retrieving the commit history.centralDogma.forRepo("foo", "bar")
            .history()
            .maxCommits(5)
            .get(Revision.HEAD, Revision.INIT);

Thanks, reviewers. 😉


[Tab] inline tab spacing update

Adding the spacing-50 above and below the inline tabs (matching the main Tab variant). Figma spec: https://www.figma.com/file/wh4iwNOuVIpebbV1qgSnxP/Tabs-2?type=design&node-id=2445%3A16532&mode=design&t=JIHUyKhgdYEWLhdr-1.
Details by @bhoppers2008 @dplsek

from what I can see they already have the spacing, but the min-height is different to the main tab so I will raise a PR to amend that


Added ubuntu specific artifacts to build docker image

What changes were proposed in this pull request?
Added artifacts for Ubuntu image
How was this patch tested?
This image was used to run jenkins job for running spark integration tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

LGTM. Waiting for the answer here: https://github.com/lightbend/fdp-jenkins-jobs/pull/54

Replied at lightbend/fdp-jenkins-jobs#54


Consider using more contemporary positioning rules

Now that we have flexbox and grid, it ought to be possible to get rid of some of the frustrating psoitioning problems that often plague popcorn.

This might be better stated as, implement CSS modernization via

componentized plugin events with id and class attribues
reducuction of hard-coded CSS in plugins
where possible, use of flexbox, grid, etc.


What is the Plone 4 training Branch?

Hi @do3cc @pbauer
I need updated some translation for Plone 4 training...
Then I have a question:
What is the Plone 4 training Branch?
Maybe could be the following: https://github.com/plone/training/tree/plone4
Thanks you!

The branch is plone4


Router pod gets stuck if it has an open connection during BIG-IP failover

If the pod is in the middle of making an API call to the BIG-IP (i.e. had an open network connection) when the BIG-IP instance fail over to the next, it gets stuck, because during failover the BIG-IP takes down dataplane network links. And since the router pod does not have a timeout set for its HTTP requests, it gets stuck forever.
We need the pods to be able to handle the case of a BIG-IP failover (otherwise there is no reason for HA). Therefore we will implement a fix in the router pod, so that there is a timeout for the HTTP requests. If the failover happens when the pod have an open network connection to the BIG-IP, it will wait until the timeout runs out, which will be set to 60 seconds, and then continue. This will prevent the pod from getting stuck and will continue to process events after the failover.

Fixed in 52fc29f


How can I install version 0.3.0

I want to take advantage of the new enhancements in version 0.3.0 such as getting only selected fields rather than all of them and I have to install version 0.3.0 to do that but the line of code below installs version 0.2.0 which does not do what I mentioned above. How can I install version 0.3.0?
devtools::install_github("alexioannides/elasticsearchr")

@fissehab check out this link, section 3.1.1https://cran.r-project.org/web/packages/githubinstall/vignettes/githubinstall.html.  you'll want to set the ref to v0.3.0.

Thank you!


Add additional information to the worker list

The worker list here could have additional useful/interesting information added about workers: https://tinybots.net/artbot/info/workers

info - e.g. "Quadro P4000 8 GB"
nsfw - i.e. Does the worker allow NSFW images?
painting - i.e. Does the worker allow inpainting requests?
post-processing - i.e. Does the worker allow post processing requests?
trusted - i.e. Is the worker trusted?

All of these are in the worker data returned from the API endpoint here: https://stablehorde.net/api/v2/workers
Small extract example of which is here:
[
   {
      "max_pixels":262144,
      "megapixelsteps_generated":945099.0,
      "img2img":true,
      "painting":false,
      "post-processing":true,
      "requests_fulfilled":104860,
      "kudos_rewards":1118794.0,
      "kudos_details":{
         "generated":835725.0,
         "uptime":288350
      },
      "performance":"0.3 megapixelsteps per second",
      "threads":1,
      "uptime":3596070,
      "maintenance_mode":false,
      "info":"Quadro P4000 8 GB",
      "nsfw":true,
      "trusted":false,
      "flagged":false,
      "uncompleted_jobs":416,
      "models":[
         "Yiffy",
         "stable_diffusion",
         "Dreamshaper",
         "Realistic Vision",
         "ACertainThing",
         "Deliberate",
         "waifu_diffusion",
         "Liberty",
         "Anything Diffusion",
         "Dreamlike Photoreal",
         "PPP",
         "mo-di-diffusion",
         "Midjourney Diffusion"
      ],
      "team":{
         "name":null,
         "id":null
      },
      "bridge_agent":"AI Horde Worker:14:https://github.com/db0/AI-Horde-Worker",
      "name":"FiFo-001",
      "id":"23499b5a-48d3-40a1-8ddb-75cd6e576e1f",
      "online":true
   },

Thanks to @evguu ! This went live earlier today.


Pattern in words scan

To search words and count in text node you use pattern like this
https://github.com/nono/HTML-Truncator/blob/45382ea67c5cebd141863ab5a2f76e4a5fc5b727/lib/html_truncator.rb#L78
but it doesn't covers special charecters like NO-BREAK SPACE
I think pattern /[[:space:]]*[[[:punct:]][[:word:]]]+/ is better because also covers non-ASCII characters in utf-8

Hello, it looks like a good idea. Can you make a pull request with this change?


client go-generator should allow adding custom headers to outgoing requests

Currently, the generator for client.go writes code that initializes outgoing HTTP headers to an empty map, and adds only what it needs internally for its specific purposes (e.g. Credentials header/value and If-None-Match ETag type headers)
It would be good to allow custom headers to be added to each client on a per-request basis.

This would be a worthwhile enhancement.

Do we want both custom "sticky" headers like the current credentials, as well as per-request custom headers? The latter would most easily be done by modifying the API to take a map, which would create incompatibilities. The sticky headers would be trivial to add

In the case I'm thinking about, we would be ok with sticky credentials - so long as there was some way to "update" them (e.g. to refresh a header value).  Even if that meant calling "AddHeaders()" again, that would probably be ok.

Would probably need to add API to SetHeader instead of AddHeader (which will accumulate a list of values). Sticky headers is easy enough that I can see doing that now, per-request headers may require some API work, not quite ready to do that.

Why couldn't you do all this in a custom transport? We already do user-agent injection and other stuff like this using a custom transport.

Good point. The other reason I've dragged my feet is that headers are technically part of the API, and I'd prefer API details to be explicit in the RDL itself (an approach which also allows adding whatever headers you want in a more formal way).


Ability to export journal as single file

Hi, do you think it would be possible to add option to export journal/journals folder as single note?
This might be useful if you want to use some obsidian tts plugins to listen whole module / adventure as audio book.

I think it can be done fairly easily for individual journals - so that all pages are put into a single markdown file.
It would be more difficult to do a folder of journals, since the correct order of the journals in the folder isn't so easily determined.
Do the obsidian TTS plugins not allow you to read a folder of notes in order, rather than only working on a single note each time?

Do the obsidian TTS plugins not allow you to read a folder of notes in order, rather than only working on a single note each time?

haven't tried all of them, but aloud wouldn't do it at least i couldn't find how to


t.rejects unexpectedly triggers afterEach

Hi!
I'm using afterEach to register a cleanup hook that runs after each test.
When I use t.rejects in the middle of one of my tests, that creates an additional subtest. That means the cleanup fires in the middle of my test.
const { test, afterEach } = require('tap')

afterEach(done => {
  console.log('in after each!')
  nock.restore()
  nock.cleanAll()
  nock.enableNetConnect()
  nock.activate()
  done()
})

test('get with reply callback returning callback without headers', async t => {
  const scope = nock('http://example.com')
    .get('/')
    .reply(() => [401, 'This is a body'])

  await t.rejects(async () => got('http://example.com/'), {
    statusCode: 401,
    body: 'This is a body',
  })

  // afterEach runs once here ...

  scope.done()

  // ... and a second time after this function returns
})

This makes it impossible to make more assertions about the state after the t.rejects returns.
In the above example scope.done() is intended to check the post-reject, pre-cleanup state, but it's unexpectedly testing the post-cleanup state instead.
It seems like it would be less surprising for t.rejects not to trigger the hooks, though if there were a way to turn them off, that could work too.

Fixed in version 13 (coming as soon as node v6 hits EOL, so, in a few weeks.)

Amazing! Thanks so much!


[blake3] Add assembly implementations

What does your PR fix?
Adds assembly implementations of the library, which are significantly faster compared to intrinsics.
Measured single-threaded performance increase from ~2.7GB/s to ~3.6GB/s on AMD 3995WX, Windows, MSVC.

Which triplets are supported/not supported? Have you updated the CI baseline?
All, Yes

Does your PR follow the maintainer guide?

Yes

Thanks!


Improved the snippet generation by auto-importing needed classes

Fixes #517

I would still like this feature please (nearly 1 year on :-P )

@stof Are you going to address @everzet's suggestion? If not I think it's still usable as it is and should be merged


Reposition shooter and colorize

Reposition shooter on the correct side of the board
Add gradient color to shooter

Looks good. There is a weird bug with the gradient of the shooter, it doesn't follow the shooter when it moves but sits static in the center. Maybe something to look at next week.


exploitdb: 2023-06-05 -> 2023-06-07

Description of changes
update to 2023-06-07
commit tagged as 2023-06-07: https://gitlab.com/exploit-database/exploitdb/-/commit/ccfd0c515d364f5407082c26840219fc8235e9b0

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.


Add taskKillGracePeriod

Added ability to send taskKillGracePeriodSeconds to marathon libs from metronome.
Changed the name to include suffix Seconds which is consistent with parts of marathon:)
https://jira.mesosphere.com/browse/METRONOME-151
Jira:  METRONOME-151

Looking into what it takes... manually tested.. needs unit tests

I think we should test:

it is marshalled to proto (that one I already commited)
it is properly parsed in controller
it is passed to marathon (this one I am working on)

I think we don't need integration/SI test ... we can verify it is passed to marathon and we can expect that this is already tested in integration test in Marathon ... ? :)
I have a "JobRunExecutorActor" test already halfway ready - I will commit that one tomorrow.
Otherwise nice work @kensipe !

@kensipe I have submitted the tests so feel free to review if it makes sense to you like this


frame:false , maximize() will be enter fullscreen!!!

{
  "main": "index.html",
  "name": "nw-demo",
  "description": "demo app of node-webkit",
  "version": "1.0",
  "window": {
    "title": "node-webkit demo",
    "toolbar": false,
    "frame": false,
    "show": true,
    "fullscreen": false,
    "width": 1000,
    "height": 600,
    "position": "center",
    "min_width": 1000,
    "min_height": 600
  }
}

require('nw.gui').Window.get().maximize();

Window not maximize, it enter the fullscreen !!

I still see this in 0.11.5. The app goes over / under the taskbar on Windows.

Not for me, it works fine now, Windows 8.1.

@Gimmeaphatbeat weird, I'm on Windows 8.1 too.

@adam-lynch I used the 64-bit Node-webkit if that matters.

@Gimmeaphatbeat seems to happen with both for me.

This problem has come back for me in 0.12.0

@jtg-gg  could you please check this. Looks like related to the window style.

@rogerwang ok I am looking into it

This seems still to be a problem, when I'm on Windows 8.1 frame set to false and resizable set to false. I'm using version v0.12.0-alpha3

:+1:

I had a problem the same problem with it being hidden behind / going in front of the taskbar and double clicking on the draggable-area when maximised wouldn't restore back to normal.
It seemed to be caused by the resizable: false in the manifest. Removing that and using gui.Window.get().setResizable(false) on load is a fix.
A knock on effect is that the double clicking on a draggable area will maximum the window, even if setResizable is set to false, but that's probably a separate issue.
Hope this helps.

I am having this issue with 0.12.1.
No frame and maximize exposes part of window frame in taskbar on a little bit on the second monitor on Windows 8.1.


documentation & rotation

added documentation for drawcustom to readme
added rotation functionality on draw

Why was this PR closed?

i broke something. should now be fixed.

Thank you, merged. The preview image maybe could be a good use of the Image entity(https://developers.home-assistant.io/docs/core/entity/image/).


Feature/add optional volume size

I was just coming in to add this! Thank you! Here's hoping it gets merged...

@lcardno10 and @lamebear Thank you for this, can you see to that this is compatible with AWS SDK 3, ie this:
https://github.com/machulav/ec2-github-runner/releases/tag/v2.3.7


Enter the payment type for non-online payments

As an IAO analyst
I want to be required to enter the type of payment when a fee has been paid off line
so that I have a record of how the applicant paid the fee

Assumptions & Scope
What are the assumptions for this story?
Intake needs to enter the payment type when they manually enter a payment received offline (i.e., not by PayBC).
This could include an applicant dialling in by phone to pay by credit card.
Payment types are: Credit card, cheque, money order, and cash
Payment type can be edited (i.e., changed provided the form is approved and a manual entry has been paid)
What is IN scope?
A drop down with mandatory selection of how an applicant paid the request.
What is NOT in scope?
IAO can already do a manual entry when an applicant has paid.
Acceptance Criteria
Scenario 1: Payment Type dropdown on unapproved form

GIVEN a. user is an IAO analyst
WHEN the analyst is on an unapproved CFR Form
THEN the Payment Type dropdown will be uneditable and greyed out
AND the dropdown will be titled "Payment Type"

Scenario 2: No Payment Type dropdown for Ministry Coordinator

GIVEN a user is a ministry coordinator
WHEN the coordinator is on the CFR Form
THEN no Payment Type dropdown will appear

Scenario 3:  Payment Type dropdown on an approved form

GIVEN a user is an IAO analyst
WHEN the analyst is on an Approved CFR Form
AND no entry has been paid in the Paid Amount field
THEN there will be Payment Type dropdown
AND the dropdown will be uneditable
AND the dropdown will be titled "Payment Type"

Scenario 4: Editable Payment Type

GIVEN a user is an IAO analyst on an Approved CFR Form
WHEN I manually enter an amount in the amount paid field
THEN Payment Type dropdown will be editable
AND the Save button will be disabled until a Payment Type is selected

Scenario 5: Payment Type Options

GIVEN an IAO analyst has manually entered an amount in the amount paid field
AND the form is Approved
WHEN the analyst clicks on the Payment Type Dropdown
THEN the drop down will open
AND the choices will be: Credit card - Phone, Cheque, Money order, Cash

Scenario 6: Payment Type Options

GIVEN an IAO analyst has manually entered an amount in the amount paid field
AND the form is Approved
WHEN the analyst clicks on the Payment Type Dropdown
THEN the drop down will open
AND the choices will be: Credit Card - Phone, Cheque, Money Order, Cash

Scenario 7: Select Payment Type

GIVEN an IAO analyst has opened the Payment Type dropdown
WHEN the analyst clicks on a Payment Type (e.g., Cheque)
THEN the drop down will close
AND the payment type will be selected (e.g., Cheque)
AND the payment type will be displayed (e.g., Cheque)

Scenario 8: PayBC Payment Type

GIVEN an an applicant has paid a fee in full or as a deposit on PayBC
WHEN an IAO Analyst is on the CFR Form
THEN the Payment Type drop down will be uneditable
AND the payment type will be selected (e.g., Credit Card - PayBC)
AND the payment type will be displayed (e.g., Credit Card - PayBC)

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

@m-prodan, @arielleandrews, could you please review the AC above and make any changes required.
@arielleandrews, let us know if this is required for the Payment Release on Nov 10th or can come later?
cc @JHarrietha-AOT, @abin-aot

Thanks @lmullane. My preference would be to have this included in the first release. Tracking payments is quite a manual process right now and if we can drive the desired behaviour from the outset that will really help with the accounting responsibilities.

Thanks, @JHarrietha-AOT. Looks good.
Once change. Could we differentiate between online credit card payment and over the phone credit card payment?

@lmullane Dropdown is updated with additional options and Pay Online is greyed out - as it would not be available for user to select only auto-populated

@lmullane I have divided the dropdown in two based off of Arielle's recommendations.
https://jacklyn808742.invisionapp.com/console/share/3W2O64AP5C/912622803
She will let me know tomorrow if Money Order/Cheque should be combined into one options or separated into two. Will comment here when I hear back

Great. Looks good.
Thanks @arielleandrews and @JHarrietha-AOT

clarification to scenario 4 during standup - if amount paid was changed from $0, only estimate payment method will be mandatory. If amount paid was already greater than $0 and more was added, then balance payment method will be mandatory

Passed with the following notes:
Scenario 3: This function works only after the request has been put on hold. If the request is still in the "Fee Estimate" stage, the payment type options remain greyed out even though the form is "approved".
Scenario 6: Is a duplicate of scenario 5.


[Request] New animation

First of all thank you for developing this lib!
I'm trying to reproduce the heart rate "spark" in the gif below.
Any plans to implement an animation like this? Have you seen anything similiar? Or maybe if you could point me in the right direction on how to implement this. I don't even know where to start.
Thank you!

Check out the interface SparkAnimator which allows you to bring whatever Animator you want to your SparkView.

Hi @kojimasuki, this effect should be achievable with Spark. I'm not sure where your data is coming from, but assuming you get a callback with the new heart rate value every time it updates:
interface HeartRateCallback {
  void onHearRateUpdated(float heartRate);
}

I'd recommend storing the heartRate into a list of size, say 100. The first 100 values will fill up this list, then each value after that will push out the earliest value. Each time you get a new value, set this list on your SparkAdapter, and call sparkAdapter.notifyDataSetChanged(). This will trigger a redraw of your data. This should result in something close to the animation above.
And as @naturalwarren said, you can look into setting a custom SparkAnimator to have more control over how the sparkline animates each time you call notifyDataSetChanged(). By default it will just redraw the new sparkline immediately, but you could do a translation between the old path and the new path to make it a little less jerky. But I'd guess that the default behavior is pretty close to the above effect, so try that out first.
Hope that helps!


Fix fix leading left outer join join constraint collect problem

Proposed changes
cherry-pick pr #31387

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run p0

run buildall


Homepage: Create artwork for homepage

User story: As a user, I would like to see more visuals and less words.
Deliverable:
Create visuals/artwork for Find, Share, Write

Suggestion: Select & use illustrations from unDraw.co (customizable, open-source SVGs) - @nurmerey LMK if I should update the deliverable?

Suggestion: Can also make use of github pages - https://pages.github.com/


Improve dependency updates

Add a special workflow for updating requirements.txt.
Dependabot does not update requirements.txt anymore then, but only the development requirements.
In order to make this work, the requirements_dev.txt (development requirements) have been moved to a separate folder (/.dev).
All references to requirements_dev.txt have been updated accordingly (only used in CI/CD workflows and the development target for Dockerfile).
The new workflow checks out the ci/dependabot-updates branch, installs a set list of direct requirements (without versions), being eager in updating versions when installing, and then runs pip freeze to check against the current requirements.txt file.
If there are any changes, a PR against ci/dependabot-updates is created - similarly to what dependabot would otherwise do.
The workflow is scheduled to run every Monday morning - similarly to when dependabot runs.
Closes #38

Codecov Report

Merging #40 (3d77d8b) into master (a59389e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3d77d8b differs from pull request most recent head 38cf6fb. Consider uploading reports for the commit 38cf6fb to get more accurate results

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.49%   69.49%
=======================================
  Files           8        8
  Lines         295      295
=======================================
  Hits          205      205
  Misses         90       90

Flag
Coverage Δ

pytest
69.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59389e...38cf6fb. Read the comment docs.


Updating alias after each Umbrel update

Every time I update Umbrel I have to go back into the lnd.conf file and add the line alias=myaliasname
When updating to a new version, is it possible to merge the new lnd.conf file with the one the user is already using in the current umbrel version? Thanks.

Closing due to inactivity (I believe this was resolved as part of an update already)


Mistakes in documentation of the parameters

Some parameters are described inaccurately on http://messageix.iiasa.ac.at/. eg  "historical_emission" should be something like:

node | type_emission | type_tec | type_year

instead it reads:

node | emission | type_tec | year

I came across this while looking for documentation-related issues.
The docstring seems to correctly match the definition:
https://github.com/iiasa/message_ix/blob/154c58150755f1445ed48de028656daefccde995/message_ix/model/MESSAGE/parameter_def.gms#L483-L487
The parameter is used here:
https://github.com/iiasa/message_ix/blob/154c58150755f1445ed48de028656daefccde995/message_ix/model/MESSAGE/model_core.gms#L1701-L1708
As far as I can tell:

The historical emissions are added to projected emissions for each species—i.e. each member of the set emission, e.g. "CO2", "CH4", etc.—separately.
After this, emissions are summed across sets of species (e.g. "GHG"s) appearing in type_emission.
year_all is the set of all historical and future years.
Other parameters like bound_emission may be defined as applying not only to particular years, but to "cumulative" emissions; "cumulative" is a member of type_year with the special meaning "sum across year_all".
But, historical emissions are specific to particular years.

So the definition and description here seem to be correct.
Can @OFR-IIASA, @danielhuppmann or someone else confirm this is the right interpretation?

Hi @ClaraLuisa ,
have you found other innaccuracies like the one you presented here?

@ClaraLuisa I saw there are inconsistencies when defining the sets node and node_loc to describe dimensions of different parameters... Do you know which is the criteria of them? Please see my comment on this in the #275 for a detailed description of it.

@khaeru thank you for the explanation. I was confused as both definitions work for adding the parameter.

I'm closing this issue since @khaeru's understanding seems to be correct. As far as I can tell, @francescolovat tried adapting the parameter definition as suggested here, which didn't work. He then reverted the change because it "ha[d] no sense and [was] wrong", so if it is an actual error or if you find any new errors, please create a new issue for them :)


feat(emitter): implement emitMany helper to dispatch multiple payload

Closes #37

Add information about this into README.md


Straightening glitches

Description
Glitches in the output of sct_straighten_spinalcord. Seems to work better on the docker version than on the GitHub version.
Steps to Reproduce
OS: OSX mojave
0. Install SCT git version (git pull 02/04/2019)

sct_deepseg_sc -i ANU-005-t2.nii -c t2

sct_straighten_spinalcord -i ANU-005-t2.nii -s ANU-005-t2_seg.nii

open ANU-005-t2_straight.nii

File in Duke/sct_testing/issues/201904_issue_straighten_lurou/

issue might be related to the poor resolution in the RL direction.

Note from @lrouhier: the issue also appears when resampling the input data to 0.6mm iso

i can reproduce

The issue does not appear as much in v3.2.7. See below comparison v4.0.0-beta.2 vs. v3.2.7:

The problem was related to the bspline fitting, which captures outlier points:

When using polyfit (degree 10), this problem does not occur and the straightening is cleaner:

This raises concerns in having bspline being the default algorithm for important functions: sct_register_to_template, sct_straighten_spinalcord.
Further UT should be deployed.


Number 1: Separating Statistics changes into 3 PRs

Number 1 PR: graph section

@galaxybot test this

@galaxybot deploy this

This failure is my fault... I did a security upgrade on Jenkins mid-build and I didn't think it'd restart automatically (narrator: it did).

@galaxybot deploy this

Hi @natefoo, would you have time to look into this PR sometimes? I am hoping to make ML tools in Main match that of EU. Please let me know how I can help. Thx.

Hi @natefoo, would you have time to look into this PR sometimes? I am hoping to make ML tools in Main match that of EU. Please let me know how I can help. Thx.

Never mind @natefoo! Just realized you are out this week. We will chat later.

@galaxybot test this

Can you break this down into smaller pieces ?

Can you break this down into smaller pieces ?

Sure. Will do. May I know what the issue is?

@mvdbeek, created 3 PRs in place of this one.
https://github.com/galaxyproject/usegalaxy-tools/pull/376
https://github.com/galaxyproject/usegalaxy-tools/pull/377
https://github.com/galaxyproject/usegalaxy-tools/pull/378
Closing this PR now.


feat(anu-nuxt): improved nuxt module + nuxt DevTools support

✨ Enhancements

Fixed: Types for components
Fixed: Dev playground to work within the mono repo 💯
Removed: unocss.config.ts within playground since unocss fixed it in later verisons
Added: New module props initialTheme and themes to replicate what core does
Added: 😍 Added to Nuxt DevTools if enabled

Made installation basically simply without no need for additional setup. Making it super easy to install and work with it!
Take a look it's nice
https://user-images.githubusercontent.com/6619884/221991742-d15b3414-07c9-4e4d-b652-5d051d3626a2.mov
Thanks,
CP 🚀

Thanks 😇
This is pretty nice DX improvement 💯


Use string.Create instead of concatenation in PdhHelper

PR Summary

Use string.Create instead of concatenation in method ConnectToDataSource
Use for loop instead of foreach to avoid allocating an enumerator

PR Context
https://github.com/PowerShell/PowerShell/pull/13410#discussion_r469411428
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[NA] Experimental feature(s) needed

[NA] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[NA] Documentation needed

[NA] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[NA] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

I was skeptical of the enumerator for arrays allocating, so I ran a profile:
    [MemoryDiagnoser]
    public class LoopAllocationTest
    {
        public static void RunProfile()
        {
            BenchmarkRunner.Run<LoopAllocationTest>();
        }

        private byte[] _nums;

        [GlobalSetup]
        public void Setup()
        {
            _nums = new byte[1000000];
            new Random().NextBytes(_nums);
        }

        [Benchmark(Baseline = true)]
        public void RunForLoop()
        {
            for (int i = 0; i < _nums.Length; i++)
            {
                int k = _nums[i];
            }
        }

        [Benchmark]
        public void RunForEachLoop()
        {
            foreach (int k in _nums)
            {
                ;
            }
        }
    }

Results:
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19041.450 (2004/?/20H1)
Intel Core i7-8700K CPU 3.70GHz (Coffee Lake), 1 CPU, 12 logical and 6 physical cores
.NET Core SDK=5.0.100-preview.4.20258.7
  [Host]     : .NET Core 5.0.0 (CoreCLR <IP_ADDRESS>06, CoreFX <IP_ADDRESS>06), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR <IP_ADDRESS>06, CoreFX <IP_ADDRESS>06), X64 RyuJIT

|         Method |     Mean |   Error |  StdDev | Ratio | RatioSD | Gen 0 | Gen 1 | Gen 2 | Allocated |
|--------------- |---------:|--------:|--------:|------:|--------:|------:|------:|------:|----------:|
|     RunForLoop | 228.3 us | 1.41 us | 1.25 us |  1.00 |    0.00 |     - |     - |     - |         - |
| RunForEachLoop | 457.6 us | 4.10 us | 3.43 us |  2.00 |    0.02 |     - |     - |     - |         - |

So while it looks like a for loop is faster, neither loop allocates.

Sorry, just realised I for some reason assumed the backing data structure was an array.
Here's an updated benchmark:
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
using System;
using System.Collections.Generic;
using System.Collections.Specialized;

namespace CSharpPlayground
{
    [MemoryDiagnoser]
    public class LoopAllocationTest
    {
        public static void RunProfile()
        {
            BenchmarkRunner.Run<LoopAllocationTest>();
        }

        private StringCollection _stringCollection;
        private List<string> _stringList;

        [GlobalSetup]
        public void Setup()
        {
            _stringCollection = new StringCollection();
            _stringList = new List<string>();
            var random = new Random();
            for (int i = 0; i < 1000000; i++)
            {
                string s = random.NextDouble().ToString();
                _stringCollection.Add(s);
                _stringList.Add(s);
            }
        }

        [Benchmark(Baseline = true)]
        public void Run_For_StrCollection()
        {
            for (int i = 0; i < _stringCollection.Count; i++)
            {
                string s = _stringCollection[i];
            }
        }

        [Benchmark]
        public void Run_ForEach_StrCollection()
        {
            foreach (string s in _stringCollection)
            {
                ;
            }
        }

        [Benchmark]
        public void Run_For_List()
        {
            for (int i = 0; i < _stringList.Count; i++)
            {
                string s = _stringList[i];
            }
        }

        [Benchmark]
        public void Run_ForEach_List()
        {
            foreach (string s in _stringList)
            {
                ;
            }
        }
    }
}

Results:
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19041.450 (2004/?/20H1)
Intel Core i7-8700K CPU 3.70GHz (Coffee Lake), 1 CPU, 12 logical and 6 physical cores
.NET Core SDK=5.0.100-preview.4.20258.7
  [Host]     : .NET Core 5.0.0 (CoreCLR <IP_ADDRESS>06, CoreFX <IP_ADDRESS>06), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR <IP_ADDRESS>06, CoreFX <IP_ADDRESS>06), X64 RyuJIT

|                    Method |       Mean |     Error |    StdDev | Ratio | RatioSD | Gen 0 | Gen 1 | Gen 2 | Allocated |
|-------------------------- |-----------:|----------:|----------:|------:|--------:|------:|------:|------:|----------:|
|     Run_For_StrCollection | 4,057.7 us |  80.07 us | 135.97 us |  1.00 |    0.00 |     - |     - |     - |         - |
| Run_ForEach_StrCollection | 5,428.4 us | 105.20 us |  93.25 us |  1.32 |    0.04 |     - |     - |     - |      80 B |
|              Run_For_List |   699.2 us |  13.45 us |  11.23 us |  0.17 |    0.01 |     - |     - |     - |         - |
|          Run_ForEach_List | 3,019.0 us |  35.55 us |  33.25 us |  0.73 |    0.02 |     - |     - |     - |         - |

So it seems to be worth switching to List<string> and perhaps also keeping the for loop for such a dramatic speedup.

So it seems to be worth switching to List

We can not change public API.

And it is not hot path - I don't see a value from the PR.

We can not change public API.

It's on an internal class, no? If it's exposed publicly, then best not to change it. But this being on a native helper class, it feels like we can make that change.

And it is not hot path - I don't see a value from the PR.

I had assumed this was in a public API so I ignored the fact there are no references to ConnectToDataSource(StringCollection blgFileNames) in our codebase.

So it seems to be worth switching to List<string> and perhaps also keeping the for loop for such a dramatic speedup.

@rjmholt Given that this method appears to be unused, the performance I wouldn't think changing to List<string> justifies the hypothetical performance increase.
Thanks for your help with benchmarking though, it is good to confirm StringCollection performance is much worse then generic List<T>.

I have started PR to replace StringCollection with generic List in general.

We can not change public API.

It's on an internal class, no? If it's exposed publicly, then best not to change it. But this being on a native helper class, it feels like we can make that change.

@rjmholt Would there be value in a generall to PR to change method visibility from public to internal on internal class to avoid confusion like this?

Would there be value in a general PR to change method visibility from public to internal on internal class to avoid confusion like this? I have draft PR with these changes: #13436

Generally I personally prefer public methods on internal and private classes; a class/object has a public API and private methods, internal implies a secondary API and muddies thinking around the cohesion and contract around a class. However, in PowerShell there is a consideration that once you have an object, any public member on it is visible to PowerShell (even if the class itself is internal), which drives a lot of the other classes that have internal members on everything.

@iSazonov Do you any suggestions for CodeFactor issues here?

@xtqqczze I like the formatting. Please ignore these CodeFactor warnings.

Do we have a test for this code path? Want to make sure we would identify a regression

There appear to be no references to ConnectToDataSource(StringCollection blgFileNames). No tests either.

@rjmholt Maybe we could add tests and refactor double null-terminated string generation code to a NativeUtils class. We could then reuse the code in Microsoft.PowerShell.Commands.Management/commands/management/Service.cs

@xtqqczze Please resolve merge conflicts.

@xtqqczze Please resolve merge conflicts.

@xtqqczze Please resolve merge conflicts.

@xtqqczze Please resolve merge conflicts.

The PdhHelper.cs is not in the compile so we should close the PR.

The PdhHelper.cs is not in the compile so we should close the PR.

Assuming this is true, I'll close the PR. Let me know if there's something else we should be doing here.


Upgrade Scala 2.13.12 and fix compilation issues in reporters

Description
Bringing Scala 2.13.12 support by fixing reporters while maintaining backward compatibility with other Scala versions
Requires #1515 and #1518
Motivation
Closes #1514

@scoquelin please rebase/resolve conflicts

@scoquelin please rebase/resolve conflicts

Will rebase again when #1518 will be merged

@liucijus @simuons rebased and tested this version on a Scala 2.13.12 codebase :heavy_check_mark:
Will appreciate some review/feedback thanks!


⚠: Passing a string to ActiveRecord::Base.establish_connection for...

Running migrations on our app spits out this :warning:s on AR 4.1 and 4.2 (not sure on older versions).
https://github.com/rails/rails/blob/00f8e7357b16ea28103f82431c6e31205565a1f0/activerecord/lib/active_record/connection_adapters/connection_specification.rb#L225-L228

Thanks!


use AWS S3 notifications to kick off processing

Stop polling every hour to find changes. Use the built in amazon notification features of S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html

Don't quite understand. Why do this?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:35 AM -0800, "Steven McAdams" <notifications<EMAIL_ADDRESS>wrote:
Stop polling every hour to find changes. Use the built in amazon notification features of S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html

Reply to this email directly or view it on GitHubhttps://github.com/rllc/llc-archives/issues/56.

Currently we are kicking off a process once an hour to connect to amazon
s3, list all the files and compare the list with the metadata stored in our
database. Amazon has built in support for sending notifications when items
change on s3. This would eliminate the need to poll hourly for changes,
amazon would send us a notification of something changing and we could then
take action against it.
On Thu, Mar 3, 2016, 09:57 Dave Anderson<EMAIL_ADDRESS>wrote:

Don't quite understand. Why do this?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:35 AM -0800, "Steven McAdams" <
notifications<EMAIL_ADDRESS>wrote:
Stop polling every hour to find changes. Use the built in amazon
notification features of S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html

Reply to this email directly or view it on GitHub<
https://github.com/rllc/llc-archives/issues/56>.
—
Reply to this email directly or view it on GitHub
https://github.com/rllc/llc-archives/issues/56#issuecomment-191825871.

And this action would take place automatically?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:32 PM -0800, "Steven McAdams" <notifications<EMAIL_ADDRESS>wrote:
Currently we are kicking off a process once an hour to connect to amazon
s3, list all the files and compare the list with the metadata stored in our
database. Amazon has built in support for sending notifications when items
change on s3. This would eliminate the need to poll hourly for changes,
amazon would send us a notification of something changing and we could then
take action against it.
On Thu, Mar 3, 2016, 09:57 Dave Anderson<EMAIL_ADDRESS>wrote:

Don't quite understand. Why do this?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:35 AM -0800, "Steven McAdams" <
notifications<EMAIL_ADDRESS>wrote:
Stop polling every hour to find changes. Use the built in amazon
notification features of S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html

Reply to this email directly or view it on GitHub<
https://github.com/rllc/llc-archives/issues/56>.

Reply to this email directly or view it on GitHub
https://github.com/rllc/llc-archives/issues/56#issuecomment-191825871.

Reply to this email directly or view it on GitHubhttps://github.com/rllc/llc-archives/issues/56#issuecomment-192081524.

Read through the Amazon documentation I linked.
On Thu, Mar 3, 2016, 21:34 Dave Anderson<EMAIL_ADDRESS>wrote:

And this action would take place automatically?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:32 PM -0800, "Steven McAdams" <
notifications<EMAIL_ADDRESS>wrote:
Currently we are kicking off a process once an hour to connect to amazon
s3, list all the files and compare the list with the metadata stored in our
database. Amazon has built in support for sending notifications when items
change on s3. This would eliminate the need to poll hourly for changes,
amazon would send us a notification of something changing and we could then
take action against it.
On Thu, Mar 3, 2016, 09:57 Dave Anderson<EMAIL_ADDRESS>wrote:

Don't quite understand. Why do this?
Sent from Outlook Mobilehttps://aka.ms/qtex0l
On Thu, Mar 3, 2016 at 7:35 AM -0800, "Steven McAdams" <
notifications<EMAIL_ADDRESS>wrote:
Stop polling every hour to find changes. Use the built in amazon
notification features of S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html

Reply to this email directly or view it on GitHub<
https://github.com/rllc/llc-archives/issues/56>.

Reply to this email directly or view it on GitHub
https://github.com/rllc/llc-archives/issues/56#issuecomment-191825871.

Reply to this email directly or view it on GitHub<
https://github.com/rllc/llc-archives/issues/56#issuecomment-192081524>.
—
Reply to this email directly or view it on GitHub
https://github.com/rllc/llc-archives/issues/56#issuecomment-192081748.


Implement Dark Theme UI

Make UI look darker
Rename CommandBox -> OldCommanBox, NewCommandBox -> CommandBox

Codecov Report

Merging #98 into master will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6727f1...03aef92. Read the comment docs.

Looks good. Is it possible to have a toggle for this theme?

You mean something to switch to different themes?

The PR update modifies the Version variable in MainApp in fit the current milestone, and display that version number in UI.

Looks good. Is it possible to have a toggle for this theme?

You mean something to switch to different themes?

Yup

Ok, working on it now

Update PR to support UI theme switching.


The console is full of 404 errors after the safe creation

Title/Description
The console is full of 404 error after the safe creation
Environment

Browser: chrome
Safe: any new safe
Wallet: MM
App Version: 3.5.0
Environment:

production (mainnet)

Steps to reproduce

Go to add a new safe flow
Open console to see the errors
Go through the add safe flow
click Get started
###Current result: Many 404 errors for the new safe in the console

Expected result
No 404 errors
Screenshots

I just re-tested on Rinekeby prod v3.6.0  - the 404s persist.
For the user, there is no impact. But I assume it clutters the console and leads us to might miss any other important errors.
So I would leave this to you @liliya-soroka and @katspaugh to decide what to do with it.

I think we should catch and silence this error for this particular case.

I've double-checked, and it's now showing this error just once (which is fine), and after that the "waiting for client-gateway" message.


Verify that KDFa = KBKDF, KDFe = ConcatKDF, and point multiply = ECDH

Add tests to show that:

KDFa is equivalent to KBKDFHMAC implemented by python-cryptography
KDFe is equivalent to ConcatKDFHash implemented by python-cryptography
The point multiplication implemented locally is equivalent to ECDH implemented by python-cryptography

This shows that the local implementation of KDFa and KDFe can be replaced by the KDFs implemented in python-cryptography
EDIT: added a test case to show that the point multiplication implemented locally is equivalent to ECDH implemented in python cryptography

My goal with this PR was to provide a quick proof that we can replace the locally implemented crypto operations with the implementation from python-cryptography. There is no need to merge these tests.


Adds instructions for local deployment with microK8s

Thanks @claudiubelu for helping to write this tutorial.

cc @claudiubelu to add instructions on /etc/hosts files.


Movies Area Stuck in Getting Mediainfo

Version: 2.9.13
Build: 2018-07-23 18:42
OS: Windows 10 10.0
JDK: 1.8.0_191 amd64 Oracle Corporation
What is the actual behaviour?
In the Movies section the program is getting stuck in getting mediainfo, i have around 1900 movies and don't know if that might be the issue. but everytime i hit update sourses in the movie section, this happens. No issues on the tv shows section unless i use the movie section first then it won't do anything because it's stuck in the movies section getting mediainfo.
tmm_logs.zip
What is the expected behaviour?
Steps to reproduce:
Additional
Have you attached the logfile from the day it happened?

you log looks a bit confusing (it might be that you do several things at the same time?)
the last entry is from getting mediainfo of artwork - but I cannot remember if an artwork ever caused errors..
do you have iso files in your library?

since it hung both times on I:\Movies\Frozen (2010)-poster.jpg can you please upload that file?

Happy Thanksgiving to everyone

you log looks a bit confusing (it might be that you do several things at the same time?)
the last entry is from getting mediainfo of artwork - but I cannot remember if an artwork ever caused errors..
do you have iso files in your library?

"There is always a first time hehehehe"
No, i don't have any iso files just MP4, MKV and AVI files, the only other formats in the library is because of the trailers that the app downloaded.

since it hung both times on I:\Movies\Frozen (2010)-poster.jpg can you please upload that file?

That fixed the issue, i removed the file (but windows was able to see it just fine) and scraped it again and by some obscure elven sorcery everything works as intended again XD.
The app saw the file as having 0MB but i opened it in different programs and it was just fine ..... shit happens XD
Thank you for your time

nice to hear.. So I will close this issue


Topic/dev deps

Updates outdated dev dependencies.
Add small refactor (scripts used for the demo).
BREAKING CHANGE:
Drop node 0.12.x support.

:+1:


Update ocr_process.py

PR types
Bug fixes
PR changes
Others
Description
add index 0 for ocr process.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


enhace github pack

move the whitelist to the config, update readme, add PushEvent to the default whitelisted events, fix a small typo
@jfryman @Kami @lakshmi-kannan

I'm not sure that 'teh' was a misspelling. :wink:
Thanks for the enhancement and fix!

Thanks :+1:


Don't track LHASH op counts when tracing disabled

Fixes #17928.

I am not sure coupling this with trace enabled is the right thing. Perhaps another build time option should be added?

LHASH_STATS? Or just STATISTICS? I.e., no-statistics and OPENSSL_NO_STATISTICS so some further statistics could be enabled/disabled by it if we had any.

Updated to use a new option stats/OPENSSL_NO_STATS.

I'd be fine removing the statistics entirely.

Updated.

Approving for master. For 3.0 branch it would IMO need an OTC exception.

Doesn't it need an exception even for master since it won't be ABI compatible?

Doesn't it need an exception even for master since it won't be ABI compatible?

Well, the function printing the stats is kept, it just won't produce any useful output. But yeah.

The output of OPENSSL_LH_stats_bio changes, but I'm not sure that should be considered part of the "ABI".

That's the bit I'm worried about. It is entirely feasible that applications are relying on that output. That said I don't expect this to break very many applications if any - so I'm not against the change. But I do think it needs to be agreed. Incidentally we have a "Policy on API compatibility in minor releases" which says "No changes to existing public API functions and data are permitted":
https://beta.openssl.org/policies/technical/api-compat.html
Now that we try and apply that policy to this case it strikes me as a little vague and broad. Presumably we are allowed to fix bugs and refactor code - so "no changes" seems not quite right.

OTC to decide: The stats using atomics are really expensive, can we disable them by default and if so, on which branches?

That was meant to be public API function signatures and data.

I think at least the functional behaviour is expected to remain the same as well (excluding bugs).

INSTALL.md and CHANGES.md updated. I also updated the manpage.

Superceded by #17935.


Refactor ClickableLinkPlugin

The ClickableLinkPlugin needed a small refactor, because in its current implementation it cannot disable the clickability of links in read-only mode. Moving the activeness state to a prop and that prop replacing the internal isEditable, allows for full control on links behaviour in either editor state.

Why should link be disabled in read-only mode? And if that's the case, why not having this logic built-in into the plugin?

Why should link be disabled in read-only mode? And if that's the case, why not having this logic built-in into the plugin?

I want to replicate the link behaviour we have in edit mode, in read-only, which is on click to not open the link, but show the floating toolbar only without edit capabilities. I think makes sense even for the Playground, but thought this difference in behaviour was intentional so I kept it. I'd rather give more control to users via props, since this file is in the react package, not in the Playground.


Listen to title changes (Closes #1)

Added a field in config.json named notify_title_changed that contains the list of channels to which the user wants to be notified on stream title changes.
Implemented the functionality behind the notification.

Thank you!
I'll update the documentation and release a new version shortly.


Simple Hello World script fails due to globus trying to mkdir in read-only space (/home/user/)

0: Traceback (most recent call last):
0:   File "/mnt/lustre_fs/users/kavotaw/apps/anaconda/anaconda3/envs/parsl_py36/bin/process_worker_pool.py", line 19, in
0:     from parsl.version import VERSION as PARSL_VERSION
0:   File "/mnt/lustre_fs/users/kavotaw/apps/anaconda/anaconda3/envs/parsl_py36/lib/python3.6/site-packages/parsl/init.py", line 35, in
0:     from parsl.data_provider.files import File
0:   File "/mnt/lustre_fs/users/kavotaw/apps/anaconda/anaconda3/envs/parsl_py36/lib/python3.6/site-packages/parsl/data_provider/files.py", line 12, in
0:     from parsl.data_provider.data_manager import DataManager
0:   File "/mnt/lustre_fs/users/kavotaw/apps/anaconda/anaconda3/envs/parsl_py36/lib/python3.6/site-packages/parsl/data_provider/data_manager.py", line 8, in
0:     from parsl.data_provider.globus import get_globus
0:   File "/mnt/lustre_fs/users/kavotaw/apps/anaconda/anaconda3/envs/parsl_py36/lib/python3.6/site-packages/parsl/data_provider/globus.py", line 28, in
0:     os.mkdir(token_pa
0: th)
0: OSError: [Errno 30] Read-only file system: '/home/kavotaw/.parsl'
srun: error: compute0: task 0: Exited with exit code 1

This looks like globus.py is trying to write to the user home directory at the time it is imported, even if none of the other code from that file is used. As it is always imported, that means that the user home directory always needs to be writeable, even if globus transfers aren't used.
That initialisation code should probably move into an object initialiser or something like that.

This should be fixed by #781 which is merged into master now.


Add imessage to XcodeTarget

Adding in iMessage into XcodeTarget.swift

Thanks for the PR @jcpark89  LGTM!


Problem waking up myd-ya157c from standby with rtc

Hi, i'm trying to wake up myd-ya157c from standby when the wakeup source is RTC.
First, i make sure the only wakeup source is RTC by manually disabling everything except RTC and confirm it with this command:
root@myir:~# find /sys/devices/ -name wakeup | xargs grep "enabled"
/sys/devices/platform/soc/5c004000.rtc/power/wakeup:enabled
Then I put the board to sleep via this command:
echo +5 > /sys/class/rtc/rtc0/wakealarm && echo mem > /sys/power/state
It goes to sleep, but either doesn't wakeup after 5 seconds at all and is restarted by watchdog after a while:
root@myir:~# echo +5 > /sys/class/rtc/rtc0/wakealarm && echo mem > /sys/power/state
[ 4332.531090] PM: suspend entry (deep)
[ 4332.536835] Filesystems sync: 0.003 seconds
[ 4332.551517] Freezing user space processes ... (elapsed 0.001 seconds) done.
[ 4332.558764] OOM killer disabled.
[ 4332.562256] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[ 4332.569542] printk: Suspending console(s) (use no_console_suspend to debug)
NOTICE:  CPU: STM32MP157AAC Rev.Z
NOTICE:  Model: MYIRTECH MYD-YA157C-512D v2 Development Board
INFO:    Reset reason (0x214):
INFO:      IWDG2 Reset (rst_iwdg2)
INFO:    Using EMMC
INFO:      Instance 2
INFO:    Boot used partition fsbl1
NOTICE:  BL2: v2.2-r1.0(debug):v2.2-stm32mp-r1-17-g2681164a7
NOTICE:  BL2: Built : 13:24:33, Nov 28 2022
INFO:    Using crypto library 'stm32_crypto_lib'
INFO:    BL2: Doing platform setup
INFO:    RAM: DDR3-1066/888 bin G 2x2Gb 533MHz v1.44
INFO:    Memory size = 0x20000000 (512 MB)
INFO:    BL2 runs SP_MIN setup
INFO:    BL2: Loading image id 4
INFO:    Loading image id=4 at address 0x2ffed000
INFO:    Image id=4 loaded: 0x2ffed000 - 0x2ffff000
INFO:    BL2: Loading image id 5
INFO:    Loading image id=5 at address 0xc0100000
INFO:    STM32 Image size : 875362
INFO:    Image id=5 loaded: 0xc0100000 - 0xc01d5b62
WARNING: Skip signature check (header option)
NOTICE:  ROTPK is not deployed on platform. Skipping ROTPK verification.
NOTICE:  BL2: Booting BL32
INFO:    Entry point address = 0x2ffed000
INFO:    SPSR = 0x1d3
NOTICE:  SP_MIN: v2.2-r1.0(debug):v2.2-stm32mp-r1-17-g2681164a7
NOTICE:  SP_MIN: Built : 13:24:33, Nov 28 2022
INFO:    ARM GICv2 driver initialized
INFO:    stm32mp IWDG1 (12): Secure
INFO:    ETZPC: CRYP1 (9) could be non secure
INFO:    SP_MIN: Initializing runtime services
INFO:    SP_MIN: Preparing exit to normal world
U-Boot 2020.01-stm32mp-r1 (Nov 28 2022 - 12:54:26 +0000)
...
Or wakes up, but throws illegal access error and then waits till it's restarted by the watchdog:
root@myir:~# echo +5 > /sys/class/rtc/rtc0/wakealarm && echo mem > /sys/power/state
[  197.788998] PM: suspend entry (deep)
[  197.797025] Filesystems sync: 0.005 seconds
[  197.804233] Freezing user space processes ... (elapsed 0.001 seconds) done.
[  197.811466] OOM killer disabled.
[  197.814636] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[  197.822204] printk: Suspending console(s) (use no_console_suspend to debug)
NOTICE:  CPU: STM32MP157AAC Rev.Z
NOTICE:  Model: MYIRTECH MYD-YA157C-512D v2 Development Board
INFO:    Reset reason (0x810):
INFO:    System exits from STANDBY
INFO:    Using EMMC
INFO:      Instance 2
INFO:    Boot used partition fsbl1
NOTICE:  BL2: v2.2-r1.0(debug):v2.2-stm32mp-r1-17-g2681164a7
NOTICE:  BL2: Built : 13:24:33, Nov 28 2022
INFO:    Using crypto library 'stm32_crypto_lib'
INFO:    BL2: Doing platform setup
INFO:    RAM: DDR3-1066/888 bin G 2x2Gb 533MHz v1.44
INFO:    BL2 runs SP_MIN setup
INFO:    BL2: Loading image id 4
INFO:    Loading image id=4 at address 0x2ffed000
INFO:    Image id=4 loaded: 0x2ffed000 - 0x2ffff000
INFO:    BL2: Skip loading image id 5
NOTICE:  BL2: Booting BL32
INFO:    Entry point address = 0x2ffed000
INFO:    SPSR = 0x1d3
NOTICE:  SP_MIN: v2.2-r1.0(debug):v2.2-stm32mp-r1-17-g2681164a7
NOTICE:  SP_MIN: Built : 13:24:33, Nov 28 2022
INFO:    ARM GICv2 driver initialized
INFO:    stm32mp IWDG1 (12): Secure
INFO:    ETZPC: CRYP1 (9) could be non secure
INFO:    SP_MIN: Initializing runtime services
INFO:    SP_MIN: Preparing exit to normal world
ERROR:   Illegal access to 0xe0000000 in :
ERROR:          Non-Secure
ERROR:          Privilege
ERROR:          Read
PANIC at PC : 0x2ffefeb5
Exception mode=0x00000016 at: 0xc09200d4
I tried the same with stm32mp157A-dk1 board by ST and it works.
I found out the issue has probably something to do with your bsp not providing fip image - or more specifically firmware configuration with "firewall" rules for access to RAM (via TZC chip). Why is that? Especially since that's already implemented in DK1 board by ST. I'm now looking into what's needed to implement it to your board, but it doesn't seem to be simple (i don't have much experience with this stuff), so could you help me? Or do you plan to implement it yourself? Thank you.

Also, what i don't understand is it works ok during normal boot - the issue only occurs when waking up from standby sleep. If the "firewall" rules for TZC chip are missing, because of the missing fip file, shouldn't it throw the error also during normal boot?

Hi, any progress with this?

Hi, sorry, but this isn't the best support - company i work for already bought some devices from you, so we would appreciate your assistance (I also wrote to your official support email before opening this topic, but didn't get any reply yet). Thank you.

Hi,
You can directly send to the technical support email, and you will be able to reply. Sorry------------------------------------------------------------------
@.>
日　期：2023年01月16日 20:14:52
@.>
@.>; @.>
主　题：Re: [MYiR-Dev/meta-myir-st] Problem waking up myd-ya157c from standby with rtc (Issue #1)
Hi, sorry, but this isn't the best support - company i work for already bought some devices from you, so we would appreciate your assistance (I also wrote to your official support email before opening this topic, but didn't get any reply yet). Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: @.***>

Sorry, but what is your technical support email? I emailed you to your support mail, which i found in quick start guide for the board. I didn't get any reply to that email. Do you have any other technical support email? If yes could you point me to that? Thank you.

Hello, you can send your questions to the following email address.
@.***>
与 兴同乐
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "MYiR-Dev/meta-myir-st"                                                                                @.>;
发送时间: 2023年1月17日(星期二) 下午5:34
@.>;
抄送: "与<EMAIL_ADDRESS>主题: Re: [MYiR-Dev/meta-myir-st]  Problem waking up myd-ya157c from standby with rtc (Issue #1)
Sorry, but what is your technical support email? I emailed you to your support mail, which i found in quick start guide for the board. I didn't get any reply to that email. Do you have any other technical support email? If yes could you point me to that? Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: @.***>

The address is not readable - at least on my side, what i see in your messages is: @.***>

Hello ,as follows:
@.***>
---Original---
From: @.>
Date: Tue, Jan 17, 2023 17:59 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [MYiR-Dev/meta-myir-st]  Problem waking up myd-ya157c fromstandby with rtc (Issue #1)
The address is not readable - at least on my side, what i see in your messages is: @.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: @.***>

Sorry, but can't you see it doesn't work? I guess, it shows properly in your email program, but please, take a look a this thread directly on github, cause here, the email is unreadable. @licy007, I found your email address in the git repository logs and sent you an email could you send me the support address to that email as a reply? Thank you.

Hi. Is the address where i should send this issue<EMAIL_ADDRESS>

Hello, yes, this is the email of technical support.
与 兴同乐
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "MYiR-Dev/meta-myir-st"                                                                                @.>;
发送时间: 2023年1月18日(星期三) 晚上10:53
@.>;
抄送: "与<EMAIL_ADDRESS>主题: Re: [MYiR-Dev/meta-myir-st]  Problem waking up myd-ya157c from standby with rtc (Issue #1)
Hi. Is the address where i should send this issue: @.***?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: @.***>

Ok, i sent you email with this issue there.

Hi. I still didn't get any reply to my email i sent to your support email. Did you get to this issue?

Hi,
I am very sorry that we have received your question, but the engineer is on leave now because the Chinese New Year------------------------------------------------------------------
@.>
日　期：2023年01月30日 17:27:01
@.>
@.>; @.>
主　题：Re: [MYiR-Dev/meta-myir-st] Problem waking up myd-ya157c from standby with rtc (Issue #1)
Hi. I still didn't get any reply to my email i sent to your support email. Did you get to this issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Ok, so, could he let me know, when he gets back to this? Thank you.


⚠ Bofrost.at has degraded performance

In a3ae2e7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2402 ms

Resolved: Bofrost.at performance has improved in c59f575 after 7 minutes.


SSO login broken?

I have noticed that the SSO login doesn't seem to work properly
my believe is that the password hashing is not working correctly because the hash we currently calculate doesn't match the one the official game client sends to the server

Very much possible. S&F is currently working on rolling out and then immediately reverting a bunch of changes to auth and requests #96 in general. At this point in time I am not sure if they will revert everything, keep some legacy stuff around, or what they are going to do. This is certainly not a clean update on their side.
I am going to have a look at what they changed for SSO, but since I am not sure if they are reverting/changing their approach for this as well, so I am going to wait like a day or two for things to settle before I push any fixes for this


init script doesnt work at all on debian squeeze

tried everything, couldnt figure out why... no error, reports started even if app.js doesnt exist.

I changed this in 058b546. Thanks for your feedback!


New RSS Icon (in the style of SF Symbols)

Updated the icon again, now it should be correctly sized and positioned for Safari’s toolbar.

I confirmed that with the updated icon on this PR the built app extension produces an icon like this:

I think we should accept and merge this at @brentsimmons or @vincode-io 's convenience. Thanks @mantia for the idea to update the icon, and for sticking with the many revisions it took to defeat Safari's default image sizing/placement.


using gon in .js.erb ajax response

For ajax requests, I don't use haml files for the response and instead use .js.erb files. How do you include gon in these requests?
Using the following doesn't work because it creates script tags around the JavaScript:
<%= include_gon.html_safe %>

Hello, you can use need_tag: false option https://github.com/gazay/gon/wiki/Options#need_tag--true


Limitation with streaming operators

Yosys does not support streaming operators, which are used for operations like bit concatenation and repetition. This limitation means that constructs involving such operators cannot be synthesized with Yosys. To work around this, users will need to use alternative methods to achieve similar functionality in their designs.

https://github.com/AsFigo/yoYoLint/blob/main/sv_tests/synth_tests/test_8.sv


Build with system libjq (i.e. Debian libjq-dev or EPEL jq-devel)

As it is, it's not actually possible to "go get" this thing without a pre-constructed environment. This makes it work on reasonable systems. jq doesn't have a pkg-config or anything, so just assume that the includes and libs are in a global path (as indeed they usually are).

I think when I started this the version of JQ/libjq in deb/ubuntu was way to old, so I didn't bother.
I can still compile like this CGO_LDFLAGS="-L $PWD/jq-1.5/BUILD/lib" CGO_CFLAGS="-I $PWD/jq-1.5/BUILD/include" go build .


3171 describe get api v2 viz id viz

@rafatower , @Kartones CR this. Closes #3171, please.

Frontend tests were OK :+1: (details)

@javisantana CR you too, please, since I've also edited the function you used for url switching.

Frontend tests were OK :+1: (details)

looks ok :+1:

:es:

Looks good :+1:

Frontend tests were OK :+1: (details)


Notify the release manager & slack integration improvements

Proposed Changes
As discussed today in the morning, we want the release manager update to be explicitly notified to the team. This allows to react early in case the new release manager is not available. The PR is aiming to achieve that.
In the boy scout rule spirit, I also unified the slack integration in this repo to use the same version tag of the action, and consistently import the secrets from the vault.
Checklist
To ensure you provided everything we need to look at your PR:

[x] Brief textual description of the changes present
[ ] Visual demo attached
[ ] Steps to try out present, i.e. using the @bpmn-io/sr tool
[ ] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@misiekhardcore another good one for you to review.

Looks like there's no convention at time. How would you solve it? Is there any convention endorsed by GH?

How would you solve it?

I'm a fan of consistency, and would solve it using human readable labels, i.e. "Notify project channel" over "notifcyProjectChannel" or the like. GitHub allows actions to be human readable, and I'd use that.
Our conventions for workflows are that they are UPPERCASE.

For the human-readable label, we can use name property. The job ID cannot have spaces. GH seems to prefer snake_case: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#setting-an-id-for-a-job

Proposal:

keep using snake_case as in https://github.com/camunda/camunda-modeler/blob/develop/.github/workflows/RELEASE.yml
add human-readable names if necessary

Proposal:

keep using snake_case as in https://github.com/camunda/camunda-modeler/blob/develop/.github/workflows/RELEASE.yml
add human-readable names if necessary

Implemented in https://github.com/camunda/camunda-modeler/pull/4650/commits/a4b6c14ed13e6fa41044bd3c6b88eee420dc0042

I personally always try to add name describing the step in human readable form. What about job names themselves I don't have strong preferences as long as they are consistent

Merging this so we can build on top, i.e. with https://github.com/camunda/camunda-modeler/pull/4655.

maybe its a good candidate for a spring cleaning issue to standardize the naming in workflows in other repositories?

Yes, I'll have a quick look into diagram-js and bpmn-js, just so we have the changes in there.

Follow-up for core repositories:

https://github.com/bpmn-io/diagram-js/pull/945
https://github.com/bpmn-io/bpmn-js/pull/2254
https://github.com/bpmn-io/bpmn-io-demo/pull/192
https://github.com/bpmn-io/bpmn.io/pull/207
https://github.com/bpmn-io/internal-docs/pull/1078
https://github.com/bpmn-io/bpmnlint/pull/147
https://github.com/bpmn-io/bpmn-moddle/commit/870c42a67c3be0f20f1a4e332399ef299414e073
https://github.com/bpmn-io/moddle/pull/61
https://github.com/bpmn-io/moddle-xml/pull/76
https://github.com/bpmn-io/bpmn-js-token-simulation/commit/15c4504dea16525f60a609ac8d953adf28757365

I also propose to unifiy our CI workflow names, cf. https://github.com/camunda/camunda-modeler/pull/4657.
Looking forward to your @barmac and @misiekhardcore thoughts.

I reviewed all of them and left a comment on the names changes

Unfortunately, the automation I built in this PR did not work correctly today: https://github.com/camunda/camunda-modeler/actions/runs/11813602874/job/32910986873
I am investigating.

It looks that the same output was also not handled correctly in another flow: https://github.com/camunda/camunda-modeler/actions/runs/11254745468/job/31292835752
I checked the action logs, and the release_issue seems to never set issue output:
2024-11-13T08:41:41.3945913Z ##[group]Run bpmn-io/actions/release-issue@latest
2024-11-13T08:41:41.3946581Z with:
2024-11-13T08:41:41.3947117Z   template-path: docs/.project/RELEASE_TEMPLATE.md
2024-11-13T08:41:41.3947777Z   package-path: app/package.json
2024-11-13T08:41:41.3948431Z   token: ***
2024-11-13T08:41:41.3948869Z   labels: release,ready
2024-11-13T08:41:41.3949306Z ##[endgroup]
2024-11-13T08:41:44.9624967Z Evaluate and set job outputs
2024-11-13T08:41:44.9636905Z Set output 'assignee'
2024-11-13T08:41:44.9638378Z Cleaning up orphan processes


Variables markup table should have a description column

Detailed Description
bicep-docs version 1.0.1 has support to document variables, that's great!
It looks like this:

Name

varRouteTableName

However, as we cannot have @description('sometext') decorators for variables and have bicep-docs read it and generate the description automatically, we need to document it manually. In the main.bicep file we can use the line comment for that purpose.
// build naming convention based resource names
var varFortiRgName = '${parEnvironment}${parCustomerPrefix}-fw1-${parLocationPostfix}-rg'

If we want to document it using bicep-docs, we have to add the description text manually,

sidenote: knowing, that we could loose the manually added description, when running bicep-docs again

To add the description manually, it'd be very useful, if an empty markup table column with header description was added to the table. As of version 1.0.1 the variable markup table so far only holds the variables name.
Context

Possible Implementation

Name
Description

varRouteTableName
enter description nmanually

Your Environment

same environment as for issues 4

Thanks for your suggestion @winticloud. I added the Description column with empty values until metadata is supported variables. That should make it easier to fill in manually.
I am closing this issue, keep providing feedback to make bicep-docs even


Implemented GGN

This merge request closes #5
Implemented Generalized Gauss–Newton method (without support for mini-batching).
Achieved the same predictions as python counterpart.
Julia:

Python:

Implemented test suite for GGN.
Added a test to Empirical Fisher.
Set GGN as a default backend.

Overall, this is great code, well documented and tested. If there is one thing I would try adding, it's a notebook showcasing the comparison between GGN and Fisher speeds and precisions, so that we can confirm our analytical assumptions. This is just a nitpick however, as I believe otherwise the code is ready to be merged.

Overall, this is great code, well documented and tested. If there is one thing I would try adding, it's a notebook showcasing the comparison between GGN and Fisher speeds and precisions, so that we can confirm our analytical assumptions. This is just a nitpick however, as I believe otherwise the code is ready to be merged.

That's a valid point, thanks! Will do so for the next sprint

Besides the point Andrei made, which I think is a good one to keep in mind for most of our notebooks in the future, this is very well-written code! I believe tests could be somewhat improved to be more extensive, but since we were already planning to have separate pull requests for improving test suites anyway, I say this is ready to be merged. Well done!


create IMS.rc or JMS.rc directly on run_dir

It is not safe when multi ldas_setup run at the same time and using the same IMS.rc or JMS.rc. This PR creates the files on the run directory

this again had the wrong MAPL.  i just updated the branch at 9:57am

All nightly tests passed.

@gmao-rreichle , The two PRs are unrelated. This PR is continuation of the PR that was merged last night.