K8SPG-637: disable restore on pg-restore deletion

https://perconadev.atlassian.net/browse/K8SPG-637
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?
[ ] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[ ] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Config/Logging/Testability

[ ] Are all needed new/changed options added to default YAML files?
[ ] Are all needed new/changed options added to the Helm Chart?
[ ] Did we add proper logging messages for operator actions?
[ ] Did we ensure compatibility with the previous version or cluster upgrade process?
[ ] Does the change support oldest and newest supported PG version?
[ ] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

custom-extensions
failure

custom-tls
failure

demand-backup
failure

finalizers
failure

init-deploy
skipped

major-upgrade
skipped

monitoring
skipped

one-pod
skipped

operator-self-healing
skipped

pitr
skipped

scaling
skipped

scheduled-backup
skipped

self-healing
skipped

start-from-backup
skipped

tablespaces
skipped

telemetry-transfer
skipped

upgrade-consistency
skipped

upgrade-minor
skipped

users
skipped

We run 4 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/6388ada50abbc215efd1050cff8f8a261f5ce1c4
image: perconalab/percona-postgresql-operator:PR-950-6388ada50

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

major-upgrade
failure

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/37583ff3b89e99f2ea1d5869e68a859f310cb2e4
image: perconalab/percona-postgresql-operator:PR-950-37583ff3b

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

major-upgrade
failure

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/37583ff3b89e99f2ea1d5869e68a859f310cb2e4
image: perconalab/percona-postgresql-operator:PR-950-37583ff3b

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

major-upgrade
failure

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/2142774a3713ed1b698c987118c285e669ca8e22
image: perconalab/percona-postgresql-operator:PR-950-2142774a3

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

major-upgrade
failure

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/6e7cdfae0ed112e6be0db488e37306e9383a1c24
image: perconalab/percona-postgresql-operator:PR-950-6e7cdfae0

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 18 out of 18

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/a911406867cd9d5f785f9b436d0c392213db65e9
image: perconalab/percona-postgresql-operator:PR-950-a91140686

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/ecd0f95821dbc262f3f9dd6f5353a5518593ce84
image: perconalab/percona-postgresql-operator:PR-950-ecd0f9582

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/ecd0f95821dbc262f3f9dd6f5353a5518593ce84
image: perconalab/percona-postgresql-operator:PR-950-ecd0f9582

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
failure

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

sidecars
passed

start-from-backup
failure

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/117e762d895d346a681b283d4f73defe540011d9
image: perconalab/percona-postgresql-operator:PR-950-117e762d8

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

sidecars
passed

start-from-backup
failure

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/117e762d895d346a681b283d4f73defe540011d9
image: perconalab/percona-postgresql-operator:PR-950-117e762d8

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/0e32ee740fad62d6c512bb4ee0da067745e15d8b
image: perconalab/percona-postgresql-operator:PR-950-0e32ee740

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
failure

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/37af2e4929364b30632a0e482e18a3f1abae7cab
image: perconalab/percona-postgresql-operator:PR-950-37af2e492

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/2ebc2ffc9a377de881425403276866444057506a
image: perconalab/percona-postgresql-operator:PR-950-2ebc2ffc9

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
failure

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
failure

operator-self-healing
passed

pitr
failure

scaling
passed

scheduled-backup
failure

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
failure

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/950/commits/2ebc2ffc9a377de881425403276866444057506a
image: perconalab/percona-postgresql-operator:PR-950-2ebc2ffc9


Stop chunking requests to bugbug

It is no longer needed since mozilla/bugbug@6815875

Coverage increased (+0.02%) to 25.982% when pulling ba964999c12f88b74d7aed416da04cce19080510 on marco-c:stop_chunking into 4b47faf0b1c286530920c0f53a6bfb38c563c521 on mozilla:master.


Paradigm audio option

What's in this PR:
Fixes to the initial implementation of selecting whether or not you'd like to see audio in the paradigms. If the cookie wasn't set, it would return the audio. I made it so that no selection implies the user doesn't want to see paradigm audio.

Codecov Report

Merging #1059 (65fa847) into main (8bbcd95) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   78.82%   78.24%   -0.58%
==========================================
  Files         151      151
  Lines        5397     5397
  Branches      865      865
==========================================
- Hits         4254     4223      -31
- Misses       1011     1042      +31
  Partials      132      132

Impacted Files
Coverage Δ

src/CreeDictionary/CreeDictionary/views.py
61.25% <0.00%> (-18.75%)
:arrow_down:

...rc/CreeDictionary/CreeDictionary/paradigm/panes.py
87.46% <0.00%> (-0.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21800b3...65fa847. Read the comment docs.


Feature Request: List views for playlists, stations, artists, albums, and genres

Hello! First off I just want to thank you for building an amazing application. I just switched from Spotify and you made the transition much easier. Now here's my feature request:
I'm a power user and have thousands of artists in my collection. The grid view currently available in the above mentioned filters makes it frustrating to scroll through my collection when looking for music. Would it be possible to make it look a like a more traditional artist list instead of a grid? Similarly to how the song filter is laid out? That would be a huge help. Thanks!

This is the kind of request that you'll have to ask google for on their product forums we don't create or control that UI in any way 👍


Update README with gCloud

Update README with HB on gCloud Information.

Please also update webv2/README.md


(PUP-5097) Rename domainname trusted fact to domain

Renames the domainname trusted fact to domain, since the latter is what
we use for the Facter fact.

:+1:


Add an exit block

Should present an end-of-level screen with statistics
Optionally reroutes to another level

https://github.com/NinovanderMark/WebLabyrinth/commit/babd67b3e5218ce06eb14c4cea51c69286257302


canEvolve again not working after update

edit: also pkm->evolve() not work anymore.

You'd be more specific with your bug reports.
"Not work" can be anything from a wrong result over an Exception being thrown or a fatal error up to a segfault.

no errors. just they don't make their work no more.
the canEvolve() always give false/0
the evolve() simply don't evolve the pokemon.
just test yourself to evolve a pidgey and see?

Who needs unit tests? ;)
https://github.com/NicklasWallgren/PokemonGoAPI-PHP/commit/96076b57d7886970444397fb7b1d5af20ee6fe17

Sorry to say it but still not work

Currently i tested only canEvolve. I will try evolve asap

fixed


Update certauth.md

The default is in KB, not MB

Internal previews

📄 File
🔗 Preview link

aspnetcore/security/authentication/certauth.md
Configure certificate authentication in ASP.NET Core

Please backport as needed.


Limitation of entites

This PR includes protection against too big entities.
The limits are:

Action

Exec: 50M Characters
Parameters: 1M Characters (includes key and value)
Annotations: 1M Characters (includes key and value)

Package

Parameters: 1M Characters (includes key and value)
Annotations: 1M Characters (includes key and value)

Rule

Annotations: 1M Characters (includes key and value)

Trigger

Parameters: 1M Characters (includes key and value)
Annotations: 1M Characters (includes key and value)

Does nginx also provide any protection against uploading large entities?

@psuter I think nginx is already configured to reject too big requests.
But, on only blocking too big requests with nginx, the user can create an action, which is smaller than the nginx limit, and then he would be able to add a lot of annotations or parameters with an update.

The limits should be read from a configuration file rather than coded directly in scala. This will allow changes without having to rebuild the core.

I would add a trait that defines a size method and mix it with all the types for which you want to enforce a limit.

In the controller, I would try to gate any requirements as early as possible - so possibly not even reaching methods like create.

It would be good to update controller/src/main/resources/whiskswagger.json and mention the new error code.

looking good - minor nits left.

PPG 873 is green.

made one last pass - 3 minor bugs to address. I am marking ready (either will address as part of the merge or @ChrBi you might beat me to it).

Merged as https://github.com/openwhisk/openwhisk/commit/e97e22490c70ba4c94da967b220c09c5551e998d.


Customization of the logo

I would like to ask for the possibility to customize the logo in the top menu bar (also providing the possibility to consider two versions of the logo: the transparent version and the version visualized when the page is scrolled)
Great theme (I am waiting for the new section you are working on)

@domenicovistocco yes. I have plan to make the logo configurable. Just need some free time.


New aka.ms link

Aka.ms link name
ReleasePreviewLatest
Category (Optional. Select None to auto-select)
None

Thank you for submitting aka.ms/ReleasePreviewLatest. Your link already exists at akaSearch.net. 🙏✅

Thank you for submitting aka.ms/ReleasePreviewLatest. Your link already exists at akaSearch.net. 🙏✅


How to handle wm => AP u-quote-of?

Quoting a post on Mastodon ends up looking a bit odd (https://indieweb.social/<EMAIL_ADDRESS>as the original content doesn't get presented - is there something we can do to ie add the link to the post being quoted, rather than trying to embed it?

Hmm, interesting question!
Afaik Mastodon deliberately has no native quote feature, by design. Background in eg https://github.com/mastodon/mastodon/issues/20673, among others. We could try to construct it ourselves, manually, with text and minimal HTML inside content, but I'm always reluctant to do that kind of thing.
I wonder how other fediverse software supports quoting, if at all, that might be a good place to start.
BF currently converts mf2 quotation-of to AS2 attachment. Here's the log for this post. Mastodon's AP docs say attachment is for media, and don't say anything about quotes, nor do the AS2 core or vocab specs.

Sounds like the semi-standard way to do AP quotes is FEP-e232 (https://codeberg.org/fediverse/fep/issues/14, https://socialhub.activitypub.rocks/t/announce-activity/3129/4 ). Looks like it's a Note with a Link tag and content in content, eg:

{
    "type": "Note",
    "content": "This is a quote:<br>RE: https://example.com/objects/123",
    "tag": [
        {
            "type": "Link",
            "mediaType": "application/ld+json; profile=\"https://www.w3.org/ns/activitystreams\"",
            "href": "https://example.com/objects/123",
            "name": "RE: https://example.com/objects/123"
        }
    ]
}

I assume the RE: https://example.com/objects/123 part of the content is optional.

the RE: <url> is the part that gets replaced by tag[0]. basically name is the microsyntax. if you wanted to have explicit affordance for "quote tweet" style semantics, you can use rel.
for example, foundkey does this: https://akkoma.dev/FoundKeyGang/FoundKey/pulls/318 and expects at least one of the following rels:

https://misskey-hub.net/ns#_misskey_quote
http://fedibird.com/ns#quoteUri
https://www.w3.org/ns/activitystreams#quoteUrl

basically, at some point these three uris were used as JSON-LD properties for the same thing.

Oh wow interesting, microsyntax. Whee, and ugh. Thank you!

This is officially on Mastodon's roadmap: https://github.com/mastodon/mastodon/issues/309, https://joinmastodon.org/roadmap

Quotes are coming in Mastodon 4.4 - https://oisaur.com/@renchap/112299860209222424

The URL to the quoted post does get included when it comes to Misskey quote posts, though for some reason the URL is not a link. And they should be shown as quote posts in Bluesky anyway because it natively supports it.
Example: https://bsky.app/profile/mima.makai.chaotic.ninja.ap.brid.gy/post/3krmzapfowqg2
Original Misskey post: https://makai.chaotic.ninja/notes/9sv2d3tpar

This seems to be because Misskey doesn't attach a "Link" "tag" for the quote URL.
Which also explains why some clients fail to open these quoted posts natively, in my experience.
(Bridgy probably shouldn't require a "tag" for turning an <a> into a link, just for rewriting to a bridged object where available.)
Misskey instead attaches the quote URL under the canoncial IRI "https://misskey-hub.net/ns#_misskey_quote" directly to the post to enable quote presentation, which is documented here: https://misskey-hub.net/ns/
(I wouldn't use "https://www.w3.org/ns/activitystreams#quoteUrl".
That appears to be undocumented and is a potentially collision-prone way to extend the protocol.)

Btw quote posts from Bluesky to AP also seem to fail, I don't see any indication of a quote whether it's Mastodon or Misskey.
Mastodon example: https://yamabi.co/<EMAIL_ADDRESS>Misskey example: https://makai.chaotic.ninja/notes/9s5ccwqg2f
Original Bluesky quote post: https://bsky.app/profile/did:plc:cu33jkvtkoxyfd45wg7hrhra/post/3kq7qpwkces2q

I feel like Misskey quotes support would be nice as Threads added that as well!

Note to myself: Bluesky quote post app.bsky.embed.records aren't yet implemented in granary's bluesky.py. Need to do that first here. Would be a good starter project for anyone else interested in contributing!

This seems like it should get some priority cause how you have it now the feeds with people who are Quote posting a lot totally don't make any sense cause you don't have ANY indication of that they are talking about something else. No need to wait for mastodon to do anything, just include the url of the post they QP about

This would be a huge help for those of us following bridged Bluesky accounts from the fediverse. As it is, many posts simply don't make any sense.
Some Mastodon clients are already handling some version of quoting, even if it's not a part of the core Mastodon software, just by having a URL, and then doing link preview rendering. It's definitely effective, and would make the bridged messages a lot less confusing.

We could also do something like Threads. Threads will have a link to the quote post, but if you're on a software with quote post (for ex: Misskey) it will show as quotes. On software that dont like Mastodon will show as link and if someone quote post a post from someone who is not bridged it will also be a link no matter what software you're on.
English is not my first language, so i must apologize if my point seem not concise
(PS: I also kinda want quote post bridging from AP -> Bsky, I'm from Misskey (one of the many software that supports it) and it looks weird on bsky)

Progress. Here's how Bluesky quote posts now look in Mastodon (https://bsky.app/profile/snarfed.bsky.social/post/3kv6hsw44wk2q => https://indieweb.social/<EMAIL_ADDRESS>):

I'm still looking for a Misskey instance I can create an account on to test this. I've looked at https://misskey.io/ and https://quietplace.xyz/ , and neither of them can see<EMAIL_ADDRESS>so I can't enable the bridge on them. makai.chaotic.ninja, which @temtemy mentioned above, doesn't have open signups.
@AtiusAmy, any thoughts on where I can test this?

Ah, thank you! And on quietplace.xyz : https://quietplace.xyz/<EMAIL_ADDRESS>Any idea why it doesn't show up in user search on those instances? Or on eg the users tab of https://quietplace.xyz/instance-info/bsky.brid.gy ?

Useful thoughts from @qazmlp in https://github.com/snarfed/granary/commit/3fc6eb98f28b42f362e0a671d5a4a91d1504676d#commitcomment-143259713 :

Since posts can be edited, the pointed to post may change from the state it was quoted in. Bluesky appears to have laid some groundwork to detect this (I assume to display a notice in such cases, once editing lands and content can diverge).
Fediverse instances (unfortunately) don't do this, and it was only mentioned once in FED-e232: Object Links. The proposal linked there was also closed, so I'm just going to assume it's both not planned and, if it was, would look a bit more complex than what Bluesky is doing 🤷
The alternative is to detect and notify users when a post they've quoted changes, but that's neither reliable in a federated system nor would it work for quoters who don't use social media enough to react. Oh well. Someone might eventually go ahead and do it if it becomes a serious-enough problem.

It seems like current inbox delivery audience targeting could easily be extended to send post Updates to all known quote post authors, which could help with this. I don't know if any fediverse projects currently do that, though. I'm guessing now.

I've noticed this change today but not sure if something is maybe going wrong on the Mastodon side. This post (https://darkfriend.social/<EMAIL_ADDRESS>includes a link (https://bsky.brid.gy/convert/ap/at://did:plc:dhkmbru2x57gpmzwufafq6ef/app.bsky.feed.post/3kv7nbofcnp2x) that seems like it should be to the quoted post (https://bsky.app/profile/dannagal.bsky.social/post/3kv7nbofcnp2x) but if it's meant to do a redirect that's just not firing, and instead I'm left looking at some JSON.

Thanks for the nudge! You're right, that's not great, and not Mastodon's fault. I'll work on that.

It seems like current inbox delivery audience targeting could easily be
extended to send post Updates to all known quote post authors, which could
help with this.

This isn't really something that works unless you have an explicit idea of
a "quote post". Right now (and under e232), it's just a normal link like
any other. Having the linked resource change is not special, and adding a
notification mechanism for when any linked resource changes is pretty
firmly out-of-scope. This is the kind of thing that would be more likely to
be possible if there was an actual special collection of "quote posts",
which there currently is not (and I'm not sure there should be one, either
-- merely linking to a resource is not something that should be special
imo).
On Tue, Jun 18, 2024, 12:17 Ryan Barrett @.***> wrote:

Useful thoughts from @qazmlp https://github.com/qazmlp in
@.***#commitcomment-143259713
https://github.com/snarfed/granary/commit/3fc6eb98f28b42f362e0a671d5a4a91d1504676d#commitcomment-143259713
:
Since posts can be edited, the pointed to post may change from the state
it was quoted in. Bluesky appears to have laid some groundwork to detect
this (I assume to display a notice in such cases, once editing lands and
content can diverge).
Fediverse instances (unfortunately) don't do this, and it was only
mentioned once in FED-e232: Object Links. The proposal linked there was
also closed, so I'm just going to assume it's both not planned and, if it
was, would look a bit more complex than what Bluesky is doing 🤷
The alternative is to detect and notify users when a post they've quoted
changes, but that's neither reliable in a federated system nor would it
work for quoters who don't use social media enough to react. Oh well.
Someone might eventually go ahead and do it if it becomes a serious-enough
problem.
It seems like current inbox delivery audience targeting could easily be
extended to send post Updates to all known quote post authors, which
could help with this. I don't know if any fediverse projects currently do
that, though. I'm guessing now.
—
Reply to this email directly, view it on GitHub
https://github.com/snarfed/bridgy-fed/issues/461#issuecomment-2176599660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ5OX63CGV4TF2OJTFODPTZIBTSFAVCNFSM6AAAAAAWHSJFIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGU4TSNRWGA
.
You are receiving this because you commented.Message ID:
@.***>

Hi @trwnh! Sure, of course. We're squarely in e232-land here, and even then, you're right that there isn't necessarily a definition of a "quote post," even as a subset of linked resources.
I'm not seriously proposing or working on anything like update notifications for quote posts, it was just a casual hypothetical. If I was, a first pass could be:

A "quote post" is any object with an FEP-e232 attachment, notably one with mediaType=application/ld+json ... or application/activity+json.
When a quote post is created, it should be delivered to the quoted object's owner's (attributedTo or actor) inbox, if available, along with other appropriate inboxes.
AP servers track the objects that have quoted each object they own, similar to the existing replies, shares, etc collections. This could be a new externally-visible collection per object, or not.
When an object is updated and its server sends an Update activity, it sends that activity to each quote post owner's inbox too.

I'm sure this has problems, but it's at least a straw man. I don't plan to take it farther than this though. 😁

I'm still looking for a Misskey instance I can create an account on to test this. I've looked at https://misskey.io/ and https://quietplace.xyz/ , and neither of them can see<EMAIL_ADDRESS>so I can't enable the bridge on them. makai.chaotic.ninja, which @temtemy mentioned above, doesn't have open signups.
@AtiusAmy, any thoughts on where I can test this?

Misskey.art might work
https://misskey.art/<EMAIL_ADDRESS>

🎊🎉

Woo, awesome! Thank you for testing!

Woo, awesome! Thank you for testing!

I'm trying to see what a bsky quote would look on Sharkey, this post is not bridging tho...
https://bsky.app/profile/amyiscoolz.bsky.social/post/3kvakoqn3tc2m

Viewed on Sharkey/Misskey :D

Yes! I confirmed on Misskey just now too, https://quietplace.xyz/notes/9unjb8tho85n1rid

I expected Misskey to remove the RE: [URL] suffix, but oh well.

Yes! I confirmed on Misskey just now too, https://quietplace.xyz/notes/9unjb8tho85n1rid

I expected Misskey to remove the RE: [URL] suffix, but oh well.

Akkoma and Threads look just like this on Misskey as well, so it should be fine

OK, @hybridhavoc https://github.com/snarfed/bridgy-fed/issues/461#issuecomment-2176620836 should be fixed by ^ snarfed/granary@992e5b5, the RE: ... links should now work right in browsers.
Aaand I think that's it! Quote posts should now translate natively, both directions, if the quoted post's author has enabled the bridge. Otherwise, the post text will end with RE: ... with a link to the quoted post.
Phew, that took some work. Tentatively closing!

Hmmm. This looks kinda weird now:
https://fed.brid.gy/r/https://bsky.app/profile/did:plc:vzeclfzjqfezzecw543cafaq/post/3kvc5vutiol2v
That link in there is some tech data about the original post I think.

I'm seeing it on IceCubes and that renders links to other Mastodon posts inline for quotes.
However, if they don't I would've expected the link after Re: to send me to the original Bluesky post, but that link only leads to some sort of JSON representation.

Interesting! I expect IceCubes is using the Mastodon API to do that, which won't work with Bridgy Fed since it isn't Mastodon.
You're absolutely right that the link should work though! I thought I fixed that yesterday in https://github.com/snarfed/bridgy-fed/issues/461#issuecomment-2177434432 , but evidently that fix isn't always working. I'll look.

Thanks a lot for your work!

That's interesting because the link posted above (https://fed.brid.gy/r/https://bsky.app/profile/did:plc:vzeclfzjqfezzecw543cafaq/post/3kvc5vutiol2v) works for me, sends me to the Bluesky post. But I've seen some other bridged Bluesky posts today (like this one https://darkfriend.social/<EMAIL_ADDRESS>that still just have the link to the JSON.

My instance is Mastodon version 4.2.9. The quoted post is probably not itself bridged, so I don't know if that's actually the problem - that it's meant to display differently if it is bridged. If there is intended to be an embed, so far as I can tell that embed never appears for me.

@hybridhavoc  yes it does. I'm sorry. I thought it would lead to a Mastodon website for it, but bridgy (intelligently) directly forwards to BlueSky. What I originally meant was the link INSIDE that post, after the RE (see the screenshot above)

@hybridhavoc Mastodon doesn't support quote posts yet, so they won't show embeds at all. But you're also right that quoted posts that aren't bridged won't show as embeds even on platforms that do support them.
I think I've fixed the RE: links now. Example: https://bsky.app/profile/snarfed.bsky.social/post/3kvcdqj4vik2f => https://indieweb.social/<EMAIL_ADDRESS>, screenshot below. Please post here again if you see any new bridged quote posts created after ~11:30a PT today that still have the old bad links!

Yup, looking good, thanks @snarfed! 👏

Oh wow, nice, the link preview turns it into a hacky approximation of a quote post anyway, even on Mastodon. Love it.

https://bsky.app/profile/AmyIsCoolz.social.atiusamy.com.ap.brid.gy/post/3kvcmqcpywtt2
Does quote post not work with images on bsky or it can't fetch that specific post of mine (which was bridged afaik)

huh, when I quote post myself (without images) it does not seem to be bridged at all, I'll try again in a sec

Phew Not sure if I should create a new issue, but I narrowed down the problem!
https://social.atiusamy.com/@atiusamy
https://bsky.app/profile/atiusamy.social.atiusamy.com.ap.brid.gy

If I quote post a Bluesky user, it is bridged
If I quote post a Fediverse user (that is bridged) it will not be be bridged, however if I send an image in the quote post, it will be bridged just not the quote post.

Thanks for the investigation @AtiusAmy! Will look.

I can confirm that it works perfectly now. Thanks a lot for all your work, people! ♥

Thanks for the investigation @AtiusAmy! Will look.

Ok I found out something

The amount of post is the same on bsky and AP, despite having less post on the BSKY side (You can count). Not sure what's going on, maybe it is bridged but the appview won't render?

Noticed that my first quote hasn't rendered properly - maybe my MF2 markup?
Post: https://fed.brid.gy/r/https://www.jvt.me/mf2/2024/06/o0vwu/

Probably expected? Misskey supports native quote posting and they doesn't seem to show anything (aside from the weird unknown thing).

Interesting! We haven't really tested web => AP quote posting yet; we clearly need to. @jamietanna I think your mf2 here is probably fine, the (initial) problem here is that BF interpreted it as an article quote, which doesn't trigger the rest of its quote post pipeline. Clearly wrong, the quoted URL is an AP note, so we can do better.
This issue is pretty long and hairy, I'll create a new one.

(Oh and yeah @AtiusAmy is right, Mastodon itself doesn't support quote posts so you won't see it properly there anyway, but BF isn't quite working here regardless.)

Thanks for the investigation @AtiusAmy! Will look.

Ok I found out something

The amount of post is the same on bsky and AP, despite having less post on the BSKY side (You can count). Not sure what's going on, maybe it is bridged but the appview won't render?

@snarfed Do you might know the reason of that (the post that aren't bridged are the quote post of AP user)

@AtiusAmy I don't know for sure, but that's a good guess!

OK @AtiusAmy I think I've fixed this issue, bridging fediverse quote posts of bridged native fediverse posts to Bluesky. (Phew, that's a mouthful.) Feel free to try again!

OK @AtiusAmy I think I've fixed this issue, bridging fediverse quote posts of bridged native fediverse posts to Bluesky. (Phew, that's a mouthful.) Feel free to try again!

https://bsky.app/profile/atiusamy.social.atiusamy.com.ap.brid.gy/post/3kvrsg4xahiw2
Took a while to bridge but it works!

Great! Yeah we were backed up for a bit, but we're through the backlog now.

@snarfed  the problem with the link to the JSON representation instead of the quoted post somehow is back.

@dploeger yes! sorry about that, tracked in #1154. I fixed it last night but had to roll back the fix. Attempt #2 is deploying now.

Hello @snarfed ! I can confirm that your FEP-e232 implementation is correct.
You may also add rel property with value https://misskey-hub.net/ns#_misskey_quote. Some implementations do that to indicate that object link is a quote, though this is not required.


[WIP] Refactor operator to use the controller runtime

Aim is to solve #547.
Important: This a big refactoring and does not cover everything at the moment. Leader election, scheduled apps and the Volcano support are disabled. This is work in progress, goal is to get community feedback for moving forward with the refactoring.
Some important changes are:
a) proper support for the status subresource
b) support for contr runtime 0.2.0 GA
c) support for logr -zap log
d) use the certification manager for injecting the webhook ca
e) use a hash to overcome the restriction that comes with the controller runtime about accessing previous state, as described here https://github.com/kubernetes-sigs/kubebuilder/issues/37#issuecomment-532281117. Predicates could be used but might be too much work.
f) go mod support
Note: crds require some work to become of StructuralSchema I noticed several violations when running kubectl describe crd.
In order to test this:
$docker build --build-arg SPARK_IMAGE=gcr.io/spark-operator/spark:v2.4.4  -t skonto/operator:test -f Dockerfile .
#or use the following that requires to set GOPATH, go bin under PATH and GO111MODULE=on via export
$make docker-build SPARK-IMAGE=gcr.io/spark-operator/spark:v2.4.4 IMG=skonto/operator:test
$docker push skonto/operator:test
#setup minikube latest

$kubectl create namespace cert-manager
$kubectl label namespace cert-manager certmanager.k8s.io/disable-validation=true
$kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v0.10.1/cert-manager.yaml

# check in namespace cert-manager that all pods are running
# create crds
$kubectl apply -f manifest/crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml
$kubectl apply -f manifest/crds/sparkoperator.k8s.io_sparkapplications.yaml
# create Spark operator pod, service etc
$kubectl apply -f all.yaml
# check operator has started in namespace sparkoperator
# enable webhook service
$kubectl apply -f webhook.yaml

Run an application with the following spec spark-pi.yaml:
apiVersion: "sparkoperator.k8s.io/v1beta2"
kind: SparkApplication
metadata:
  name: spark-pi
  namespace: spark
spec:
  type: Scala
  mode: cluster
  image: "gcr.io/spark-operator/spark:v2.4.4"
  imagePullPolicy: Always
  mainClass: org.apache.spark.examples.SparkPi
  mainApplicationFile: "local:///opt/spark/examples/jars/spark-examples_2.11-2.4.4.jar"
  arguments:
    - "100"
  sparkVersion: "2.4.4"
  sparkConf: {}
  restartPolicy:
    type: Never
  driver:
    memory: "500m"
    labels:
      version: 2.4.4
    serviceAccount: spark-sa
    secrets:
      - name: mysecret
        path: /etc/config-secret
        secretType: generic
    configMaps:
      - name: myconfigmap
        path: /etc/config
  executor:
    instances: 2
    memory: "500m"
    labels:
      version: 2.4.4

To create the secrets use:
apiVersion: v1
kind: Secret
metadata:
  name: mysecret
  namespace: spark
type: Opaque
data:
  username: YWRtaW4=
  password: MWYyZDFlMmU2N2Rm

---
kind: ConfigMap
apiVersion: v1
metadata:
  name: myconfigmap
  namespace: spark
data:
  database: mysql
  database_uri: blablabla

#download file https://github.com/apache/spark/blob/master/resource-managers/kubernetes/integration-tests/dev/spark-rbac.yaml
$kubectl apply -f spark-rbac.yaml
$kubectl apply -f spark-pi.yaml

Log output of the operator can be found here for the app running to completion.
kubectl describe sparkapplications -n spark
Name:         spark-pi
Namespace:    spark
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"sparkoperator.k8s.io/v1beta2","kind":"SparkApplication","metadata":{"annotations":{},"name":"spark-pi","namespace":"spark"}...
API Version:  sparkoperator.k8s.io/v1beta2
Kind:         SparkApplication
Metadata:
  Creation Timestamp:  2019-09-30T00:59:22Z
  Generation:          1
  Resource Version:    1335
  Self Link:           /apis/sparkoperator.k8s.io/v1beta2/namespaces/spark/sparkapplications/spark-pi
  UID:                 d19b28af-7e48-4426-b805-5161ac5b4cd2
Spec:
  Arguments:
    100
  Driver:
    Config Maps:
      Name:  myconfigmap
      Path:  /etc/config
    Labels:
      Version:  2.4.4
    Memory:     500m
    Secrets:
      Name:           mysecret
      Path:           /etc/config-secret
      Secret Type:    generic
    Service Account:  spark-sa
  Executor:
    Instances:  2
    Labels:
      Version:            2.4.4
    Memory:               500m
  Image:                  gcr.io/spark-operator/spark:v2.4.4
  Image Pull Policy:      Always
  Main Application File:  local:///opt/spark/examples/jars/spark-examples_2.11-2.4.4.jar
  Main Class:             org.apache.spark.examples.SparkPi
  Mode:                   cluster
  Restart Policy:
    Type:  Never
  Spark Conf:
  Spark Version:  2.4.4
  Type:           Scala
Status:
  Apphash:  cc6a6c6866c7d67f763b633015903ea7594b5f044bfbde7f8d3e0377c45534fd
  Application State:
    State:  COMPLETED
  Driver Info:
    Pod Name:                    spark-pi-driver
    Web UI Address:              <IP_ADDRESS>:4040
    Web UI Port:                 4040
    Web UI Service Name:         spark-pi-ui-svc
  Execution Attempts:            1
  Last Submission Attempt Time:  2019-09-30T00:59:30Z
  Spark Application Id:          spark-94c375a44ad74291b55ae973fcc20e4d
  Submission Attempts:           1
  Submission ID:                 73cc8356-fd83-420f-9694-25a24a6bd4d5
  Termination Time:              <nil>
Events:
  Type    Reason                     Age   From            Message
  ----    ------                     ----  ----            -------
  Normal  SparkApplicationAdded      41s   spark-operator  SparkApplication spark-pi was added, enqueuing it for submission
  Normal  SparkApplicationSubmitted  33s   spark-operator  SparkApplication spark-pi was submitted successfully
  Normal  SparkDriverRunning         30s   spark-operator  Driver spark-pi-driver is running
  Normal  SparkDriverCompleted       17s   spark-operator  Driver spark-pi-driver completed
  Normal  SparkApplicationCompleted  17s   spark-operator  SparkApplication spark-pi completed

The following pass:
go vet ./...
go gmt ./...
go test ./...

just export GOPATH to be at your topdir, export GO111MODULE=on and add go binary to your path.
@liyinan926 pls review and let me know how you want me to proceed with this effort.
Usually a big refactoring like this, requires at some point to stop getting new PRs in
otherwise its hard to keep-up with all the changes happening.

@skonto thank you for this PR! Highly appreciate it. Just want to let you know that we have discussed and planned to address #610 and make the changes in branch multi-version-support part of v1beta3 next. I suggest you base this PR on the multi-version-support branch instead of the master. This will make our life easier merging both sets of changes.

@liyinan926 ok sure I will do that might close this one and create a new one will see thanks!

@skonto Thanks!

closing this in favor of https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/658


migrate from Jackson to DSL-JSON

Add parse methods to operate with bytes[] and output stream
remove ParseBuilder options (at least for this new version, it takes a big effort to keep this functionality with the new serializers and deserializers from DSL-JSON

implemented in 5.0 for serializing


text encoder is not fixed in first stage training

As the paper describe, in first stage the text and image encoder is fixed, only optimize the text tokens. However, in the code, it seems the text encoder is optimized during training. Could I ask if I misunderstand?

Have a look at solver/make_optimizer_prompt.py

Have a look at solver/make_optimizer_prompt.py

Encountered an issue while training stage1, 'AssertionError: No inf checks were recorded for this optimizer.' The printed output of loss is not a problem, and the problem may be that it does not cover all backpropagation model parameters. May I ask if the author has encountered this situation before.

Encountered an issue while training stage1, 'AssertionError: No inf checks were recorded for this optimizer.' The printed output of loss is not a problem, and the problem may be that it does not cover all backpropagation model parameters. May I ask if the author has encountered this situation before.

Did you change the model? Probably because the optimizer has no parameters fed into it, only the parameters in prompt_learner are fed into the optimizer in the first stage.


Train Model for translation

How to train Mistral 7b with files(json-jsonl-csv) for language translation

The Huggingface repo and this Github repo has multiple Google Colab notebook links
You can modify them accordingly.  Alpaca prompt format is used.

@erwe324 Oh thanks for all the help across issues - appreciate it :)


Can't fetch plugin

<!--
Have you read the plugins' Code of Conduct? By creating an Issue, you are expected to comply with it, including treating everyone with respect: https://github.com/tripflex/wifiwizard2/blob/master/CODE_OF_CONDUCT.md
-->
Prerequisites
Check all boxes if you have done the following:

[X] Checked that your issue isn't already filed: https://github.com/tripflex/wifiwizard2/issues
[X] Make sure you fill out the Issue Type below

Issue type
Select all that apply

[X] Bug
[ ] Enhancement
[ ] Task
[ ] Question
[ ] Other

Description
Can't fetch plugin from cordova anymore
Steps to Reproduce

with the command line cordova plugin add cordova-plugin-wifiwizard2

Expected behavior: should download the plugin
Actual behavior:  `ionic cordova plugin add cordova-plugin-wifiwizard2

cordova plugin add cordova-plugin-wifiwizard2 --save
Failed to fetch plugin git+https://github.com/tripflex/wifiwizard2.git via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module
[ERROR] An error occurred while running subprocess cordova.

    cordova plugin add cordova-plugin-wifiwizard2 --save exited with exit code 1.

    Re-running this command with the --verbose flag may provide more information.

`
Reproduces how often: 100%
Versions
3.1.0
Additional Information

Has this problem been solved? If not solved, try using this cmd code
cordova plugin add https://github.com/tripflex/WifiWizard2.git

Very happy to help anyone, good luck!

Its not working for me. I am using cordova android 8.0.0
ionic cordova plugin add cordova-plugin-wifiwizard2 gives me
ionic cordova plugin add cordova-plugin-wifiwizard2 > cordova plugin add cordova-plugin-wifiwizard2 --save (node:13860) UnhandledPromiseRejectionWarning: CordovaError: Failed to fetch plugin git+https://github.com/tripflex/WifiWizard2.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Failed to get absolute path to installed module


Image links using link references render incorrectly?

Describe the bug
First, thanks so much for flexmark-java!
We've been using it for ages to render markdown for cljdoc.
One of our users reported that an .md doc he had authored was rendering image links oddly.
To Reproduce
I thought maybe we might just not have the right options set for flexmark-java.
And that might still be the case.
Here's a minimal reproduction of what we are seeing using flexmark-all v0.64.0:

import com.vladsch.flexmark.html.HtmlRenderer;
import com.vladsch.flexmark.parser.Parser;
import com.vladsch.flexmark.util.data.MutableDataSet;
import com.vladsch.flexmark.util.ast.Node;

import java.util.Arrays;

public class Main {

    public static void main(String[] args) {
        MutableDataSet options = new MutableDataSet();
        Parser parser = Parser.builder(options).build();
        HtmlRenderer renderer = HtmlRenderer.builder(options).build();
        Node document = parser.parse("""
                    [![alt text][img-url]][target-url]

                    [target-url]: http://www.example.com/index.html
                    [img-url]: https://picsum.photos/200
                    """);
        String html = renderer.render(document);
        System.out.println(html);
    }
}

Expected behavior
I would have expected to see:

This is how GitHub renders this (I pasted the example above here):

and also how the CommonMark demo/try-it feature does.
Resulting Output
But I see instead:

[]target-url

What do you think?
Are we missing some config option/extension?
Is the markdown technically valid?
Many thanks in advance for any help you can provide.

Any tips on what flexmark-java extension points I would need to explore to add support for this syntax?

I stumbled on babelmark3 and noticed that it shows flexmark-java is rendering as I would expect, but it is using flexmark-java version 0.50.44.
I'll retry my test above with this old version and report back.

Ah interesting:
expected:

flex-mark v0.5.44 :heavy_check_mark:

flex-mark v0.64.0 :x:

[]target-url

I'll sample some other releases:
flexmark v0.50.50 :heavy_check_mark: (the last 0.50.x release)

flexmark v0.60.0 :heavy_check_mark: (the first 0.60.x release)

flexmark v0.60.2 :heavy_check_mark: (the last 0.60.x release)

flexmark v0.61.0 :heavy_check_mark: (the fist 0.61.x release)

flexmark v0.61.34 :x: (the last 0.61.x release)

[]target-url

Ok, it looks like the expected behaviour last occurred for:
flexmark v0.61.24 :heavy_check_mark:

And first changed to current behaviour for:
flexmark v0.61.26 :x:

[]target-url

Relevant commit log: https://github.com/vsch/flexmark-java/compare/0.61.24...0.61.26

@vsch I am happy to help in any way that makes sense to you here.
When you find a moment, please let me know what you think.

Oops me referencing this issue in a commit closed it, re-opening!

@vsch I'm wondering if I should take a stab at a PR here, but before I invest that effort:

do you agree this is a bug?
would you be interested in a PR?


[release-2.6] Code coverage increase

Signed-off-by: dislbenn<EMAIL_ADDRESS>

/test test-e2e


Test prow do not merge

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test all

/retest

/retest


Add debug output for cfg options

spend a couple of time in finding why the error:
Cloud provider could not be initialized: could not init
cloud provider "openstack": Authentication failed
turn out if we can log those with -v flag it will be helpful

I signed it

"I signed it"

/ok-to-test

with this code in this PR, this will be added to be executed always. As I see it this is not needed always. And should we really print passwords to log even in debug cases? (its not that difficult to check cloud-config file)

you are right, I removed the password stuffs
but the log output is helpful to debug as I actually spent some time in sync open rc and cloud conf and figure out the issue, if I can log it then it should be much easier

/hold

/ok-to-test

@jichenjc please update with suggestion inline.

/test cloud-provider-openstack-format

@adisky the code changed upstream and created a merge conflict. I manually fixed the conflict with the inline github editor, which explains the additional commit (and why I'm the author of it).

should this ready to merge? seems not find something block this PR?

/lgtm

/retest

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/test cloud-provider-openstack-acceptance-test-flexvolume-cinder

/lgtm

/hold cancel


Separate modules

Proposal
Recently @mattkrick and I were hunting down a bug between our codebase and react-look. react-look's repository directory structure made this more clunky than it should have been for a couple of reasons:

We couldn't use npm link and instead had to symlink in react-look and react-look-core into our project manually

More importantly, once we committed our fix to our fork, we were unable to use npm at a specific commit within our private repository. For example, linking to https://github.com/jordanh/react-look/tree/develop/packages/react-look is a no no.

I'd like to propose breaking react-look into fours separate modules:

react-look
react-look-core
react-look-test-utils
and react-look-native.

Certainly a sign of project maturity!
Of course, open to any comments to the contrary as well. Perhaps there are advantages of keeping these together I do not see...

So you'd like to have 4 different repositories or am I getting that wrong?

Yep, so react-look would depend on react-look-core, similar to how webpack has a bunch of external dependencies that are only used by webpack itself (https://github.com/webpack/webpack/blob/master/package.json). Or alternatively how socketCluster has a core repo that depends on a server and client repo. https://github.com/socketcluster/socketcluster/.
In addition to being symlink/github-package friendly, it'd also be more inviting to PRs since we could call npm run test from the root and only run the necessary tests. In the early days, I could definitely see where the monolithic structure makes sense (a PR requires a change to both react-look and react-look-core), but now that it's on the cusp of 1.0.0, I'd say it's stable enough to draw that line between modules.

Hmm yeah, I think it does not matter how it is structured as long as we have multiple modules, which right now is the case, but I actually did not do the structure well as I did not know how to do it at all.
I'd do it much better by now, but still keep the single repository pattern. Actually if there's a change/bug/request it often needs changes to more than one package, so we'd need to have issues for every repository which is not nice I guess.
But ofc you might convince me why it'd be better at all. I am right now really busy with studies and other projects, so feel free to improve it :P Actually I am working on "new" package for styling with takes advantage of all experience I gained with Look, but is more universal, less complicated and much smaller. It might replace Look at the long term, but that ofc does not mean I will ignore Look nor stop improving it :P I just might need some extern help

What's your vision for a more modular single repo? I'm definitely no expert on repo management, so it'd be great to learn from.
Also, I'd be interested in checking out your new package! What's it sacrifice to get the size down?

Basically how I did it with the new package. Everything is inside a single modules folder, the main package (e.g. react-look-core) provides everything via npm and subpackages only require e.g. react-look-core/lib/dom and export it. Then you have different packages only including what they actually need, but yet can do unified testing and have a great overview of all files.
And of course feel free to check it out. It's called Fela (https://github.com/rofrischmann/fela). I am not sure if there is any sacrifice, but its yet not ready for production (but should be soon). It only has 2kb because is does not require React nor wrap any third-party rendering cycle. It just works stand-alone and is dynamic by default. Also the React bindings are kind of "simple", but should be enough to do everything. We also like to chat about it at Gitter (link in the repo).
First I was trying to use Fela as Look's new "core", but it turned out that it actually would be harder to get everything done with Fela but to keep Look's APIs compared to just create React bindings for Fela itself.

@rofrischmann: first of all love the look of Fela (Any intentional reference to Fela Kuti?). It looks like the in-line style library of my dreams. I particularly like how now I'm in charge of the renderer singleton!
Back to repository layout for react-look. Here's the friction:
Let's say we've got some production code based on react-look and we find a bug in one of the modules. We're good OSS citizens so we fix it and submit a PR. Meanwhile, we can't wait for the module to be integrated, so we deploy our package.json like so:
"react-look": "github:jordanh/react-look#bugfix-tag"

With the current directory structure, we're unable to do that. First, we might say, "we'll shoot, just reference the subdirectory." So we try changing our package.json to:
"react-look": "github:jordanh/react-look/packages/react-look#bugfix-tag"

...but this will also fail as npm disallows reference sub-paths of github repositories.
It'd be nice not to repeat this in Fela. To manage the chaos of versioning and publishing together, it could be a good case to use git submodules.
You could use the following structure:
+ fela-bundle (docs, & build tools)
   |
   + docs
   + examples
   + scripts
   + packages
      Submodules:
      |
      - fela-core (replacing "modules", npm link'ed from the others for development)
      - fela-beautifier
      - fela-logger
      - fela-perf
      - ...
      - fela
   + ...

It seems like a hassle, but then we get npm link and npm install github:user/fork. Otherwise, we've got to continue working around the monolithic directory structure...
Know in either case we'll be happy and supportive users and are very grateful for all your work!

(p.s. I'll be in Leipzig for the summer if you want an in-person jam session!)

I believe within Fela we do not need to use submodules as you can always just bump a patch version and auto update the other packages too. This works as all the code is provided by a single npm module though.
I'd love to use the same strategy at Look, but I am really not having the time. Actually I might need someone to maintain Look or to somehow get the ppl to move to Fela if possible.
And thanks for your kind words about Fela :) and it has nothing to do with Fela Kuti, but with a fictive character from a novel, I will add some infos about the name to the repo soon :P
PS: Feel free to ping me when you're there! Leipzig is quite some hours away, but maybe I'll be there somehow sometime :P

Hi from Leipzig!
Fair enough. It's a design choice, and one we can certainly live with.
When we've encountered a bug in react-look and made local modifications we've been building our own binaries and adding them to our package.json like this:
  /* ... */
  "react-look": "file:./.mod_bin/react-look-1.0.0-beta9.tgz",
  /* ... */

We can close this issue.


[Marathon. Task page] Picture does not follow its place when changing resolution

Environment: Windows 10, Google Chrome Version 91.0.4472.124 (Official Build) (64-bit)
Reproducible: always
Build found: last commit
Preconditions
Go to https://speak-ukrainian.org.ua/dev
Steps to reproduce

Сlick 'Челендж'
Click on 'Мовомаратон'
Scroll down to 'Завдання челенджу'
Сlick 'Крок 3. Знайомтеся українською'
Change resolution to 824x792

Actual result

Expected result
Picture should not overlap with text.
User story and test case links
E.g.: "User story #

Bug is still reproducible at resolution 824x735


[feature-request]: Have default color theme be colour-blind friendly

What feature would you like to request?
Accessibility is an important topic, one of which is colour themes that work for those with color blindness (of some degree). The default for anything we make should be colour-blind friendly.
Optional: Suggest a solution
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

As I'm moving the colour scheme over to the websites, I realise our current colour scheme isn't very colour blind friendly, especially in relation to the complimentary "purple" colour. This complimentary colour choice is important for contrasting things like links. There are a few websites, like
this and this that get into and show some good colours to use. I'll make use of what I can, but this will probably have to take a bit more thought and work.

@signekb did you say you had some links to websites detailing colourblind friendly website building? If so, could you add the links here?

I haven't used any for website building, but I used this one when I created the colour theme for visualisations in my thesis (and assignments in general) at uni


CSV Injection

Description:
CSV Injection on the lis api:

/engagement/{id}/edit -> param: name
/product/{id}/new_engagement -> param: name
/product/{id}/ad_hoc_finding -> param: name
/finding/{id}/edit -> param: title
/finding/{id}/edit -> param: component_name
/product/type/add -> param: name
/product/type/{id}/edit -> param: name

of Defectdojo version 2.37.3 (https://github.com/DefectDojo/django-DefectDojo) allow remote attackers to insert malicious code. When user execute export product with type csv. When executed open file immediately malicious code is executed.
Proof of Concept:

Add or edit the above API list with malicious script tags at Param malicious.
Export type csv corresponding to the api
Open the csv file that was just downloaded. The malicious code is immediately executed.

Impact:
Execution of Malicious Code

Maybe I understand this wrong, but isn't this rather a problem within the csv editor you use?

What is your opinion @mtesauro ?

Maybe I understand this wrong, but isn't this rather a problem within the csv editor you use?

no bro. anyone can do this. this is a vulnerability. you can refer to CWE-1236 which has a description of this

@minhquan202
First, as someone reporting security issues to any software producer, please look for and honor the requested reporting process.  DefectDojo's is on the repo's main README.md file under the title of "Security" and points to our disclosure policy at https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/SECURITY.md. From looking at Hackerone, someone with a similar username submitted there as well but, if that was you, the Hackerone submission should have been the only one. In this case, there's no issue for the DefectDojo community but we have the bug bounty in place with Hakerone to allow the larger DefectDojo community to get a needed fix quickly and ideally before the issue is disclosed publicly.
As for this specific issue, I'm sorry but this is not an issue for DefectDojo to fix. This is an issue with the program which takes in a CSV as input data and executes it instead.
I'd not blame the attacker nor ask them to fix a XSS or SQL-i by only sending data which DefectDojo can safely process - why should DefectDojo be expected to alter it's output to accommodate downstream applications which fail to validly treat data as data and instead execute it.
The earliest example of this I can find is from 2017 and located at https://georgemauer.net/2017/10/07/csv-injection.html which was a reference from OWASP's page on CSV Injection. Ironically, the CWE you reference links to that OWASP page.

what is program which take CSV? and So I want to know, when this vulnerability will be fixed.

The program which takes the CSV is whatever program a person wants to use - MS Excel, LibreOffice Calc, Google Spreadsheets, Apple Numbers - any program which reads in CSV data and treats it like code would need to fix this issue.
Are you going to submit a similar issue for Vim? Vim can create CSVs like you reference above but I won't expect it to have anything to do with how another program uses the data Vim created. What about Notepad, VS Code, nano, any text editor?
DefectDojo does not consider this an issue it has any ability to fix as it has no control how various spreadsheet apps read in and handle CSV data. DefectDojo will not be doing any code changes in how it creates CSVs as this represents a vulnerability in other software not DefectDojo.
Please consider filing issues with the various spreadsheet software I've listed above and any others you might know of - that's how what you put here will get fixed.

No bro, I think you are misunderstanding the issue here. The problem is that any user exporting information as CSV and opening it will execute the malicious code, regardless of the software used. This is a vulnerability that attackers exploit through commands allowed in the CSV file to execute malicious code. The fault does not lie with software like MS Excel, LibreOffice Calc, etc., but rather with your own website. This happens because the website does not handle the attacker's input correctly during the CSV file export process. Any web application exporting files of type CSV must validate the special characters in the data, such as '=', '+', '@', and '-'. They usually validate by adding a single quote (') or double quote (") before the special characters so that when the CSV file is opened, the malicious commands injected into the columns will not execute and will be interpreted as a string instead. Please refer to some of the following reports to see how they fix these errors.: https://www.wizlynxgroup.com/security-research-advisories/vuln/WLX-2020-010

bro, you read my answer. I just want you to understand the importance of these vulnerabilities. Contribute to protecting users from the consequences of vulnerabilities.


POL-232 Wizard's name depends if we are creating new or editing

Works great and tests cool. LGTM.


Defining more points along span wise to Blade ED file

Hello,
Is it possible to discretize the blade ED file more (0.1 m apart) to study the effect of elasticity? For this purpose, does the linear interpolation work among properties already available in the file? What are the settings I need to be careful to avoid any imbalance? It would be helpful if anyone could guide me.
Regards,

I tried discretizing the Elastodyn file from 51 to 1001. I wanted to check the modal coefficients with BModes but it cannot allocate the array (See the following error). Instead of discretizing uniformly, can I discretize the a smaller portion of the beam where I want to change the stiffness?
Running BModes (v3.00.00, 20-Mar-2008, compiled using double precision).
Linked with the NWTC Subroutine Library (v1.01.08, 26-Sep-2007).
Unable to allocate array, gm, in main program.
Aborting BModes.

Dear @PaulKSmith,
You can increase the number of structural analysis nodes in ElastoDyn by increasing BldNodes; the table of distributed blade mass and stiffness properties in the ElastoDyn blade file will be linearly interpolated to these nodes.  That said, given the limited number of blade degrees of freedom in ElastoDyn (two flapwise bending and one edgewise bending), there is little benefit of increasing the number of structural analysis nodes to 1000.
Likewise, I don't see any need to increase the resolution of finite elements in BeamDyn so high, but BeamDyn certainly allows you to specify a nonlinear distribution of finite elements if you want to discretize finer in specific areas of the blade.
Best regards,

Dear @jjonkman,
Thank you for your kind reply and confirmation.
You are right that there will be a little benefit to increase the nodes up to 1000. I just need to adjust the local stiffness of the blade. As the discretized length is more than 1.5m currently, I cannot adjust the stiffness locally. So, the goal is to discretize finer so that I can adjust stiffness over a length of my choice (for example 0.5m).  So, I will keep original discretization fixed except for the region in interest. Probably ElastoDyn  allow it? I see you mentioned BeamDyn allows the non-linear distribution.
Is there any restriction on no of nodes on BModes  to calculate modal coefficients? for 1000 elements it throws an allocation error. Please see the first comment for error.
In my current setup, I only have ElastoDyn file. Do you think I can convert it to use in BeamDyn as well? I am working with DTU10MW.
Regards,

Dear @PaulKSmith,
Internally within ElastoDyn, the blade structural analysis nodes can be discretized nonuniformly; however, there is no input file setting for that, so taking advantage of this capability will require a small source code change and recompile.
Regarding the BModes error, sounds like an allocation error (likely due to the large memory requirement of 1000 finite elements), but I'm not familiar with the BModes source code to to comment.  To get around this error, I would suggest lowering the number of blade elements (nselt) to something more reasonable and use a nonuniform element distribution.
BeamDyn requires additional information beyond what ElastoDyn does, including torsional and axial stiffness, mass/elastic offsets, and coupling terms.  While not in ElastoDyn, this data should exist for the DTU 10-MW RWT.  If you are using the IEA Wind version of the DTU 10-MW RWT, you can find an OpenFAST model with BeamDyn here enabled here: https://github.com/IEAWindTask37/IEA-10.0-198-RWT/tree/master/openfast.
Best regards,

Dear @jjonkman
Thank you for clarification. For my existing setup, the Blade ElastoDyn file looks like it has non-uniform distribution. Therefore, I suppose it linearly interpolates this data again inside code before proceeding further? My model is the old DTU10MW, not sure I am naming it correctly (Got it from another lab member who does not have BeamDyn file as well). For IEATask37 the blade length and other properties are different.
See the Different column, which is BlFract(i) -BlFract(i+1).

I am quite beginner to this field, therefore changing the source code and recompile would take some time. Is there any guide on how to do that?
For my problem I just need to change the flap and edge stiffness at some locations for a element size of [0.1, 0.5, 1.0]m . Would you suggest any possible way out of this situation ? Appreciate your feedback.
Regards,

Dear @PaulKSmith,
Yes, ElastoDyn will linearly interpolate the distributed blade property inputs from the blade file to the structural analysis nodes, which are then used in the calculation.
Guidance on compiling OpenFAST can be found here: https://openfast.readthedocs.io/en/main/source/install/index.html#compile-from-source.  If you are using Windows, I would install the Intel Fortran compiler and Visual Studio, which are both free.
The uniform distribution of blade analysis nodes is set within SUBROUTINE SetBladeParameters() of ElastoDyn.f90 (p%DRNodes and p%RNodes); that calculation is the only thing you'll need to change.
Best regards.

Dear @jjonkman,
Thank you for your guidance.
Before attempting to compile the source code, I was checking the BeamDyn input files for IEATask37. From what I noticed, it needs stiffness and mass matrices for individual segments, which can be derived using VABS, BECAS, or NuMAD/BPE. To run NuMAD/BPE I need to have yaml file for the blade. I am not sure for BECAS, probably it also needs 3D FEM blade model. Please correct me if I am wrong. Without having access to yaml/ 3D FEM model it is difficult to discretize finer (more h-refinement) in specific area and alter any parameters. In that case, even if I had BeamDyn file for DTU10MWRWT it would not help unless I have yaml file. Please correct me if I am wrong.
Regards,

Dear @PaulKSmith,
I agree that you'll need more information to run VABS, BECAS, and/or NuMAD/BPE.
But as far as I can tell, you have the beam properties needed to populate the 6x6 mass and stiffness matrices, at least the two sets of 3x3 matrices, assuming the bending-axial terms are uncoupled from the shear-torsion terms.  See the following document for more information on how to derive the BeamDyn mass and stiffness matrices from the beam properties you already have: https://openfast.readthedocs.io/en/main/_downloads/fd7a8bc10f2371a50828391f75170032/beamdyn_inputs_sectional_props.pdf.
Best regards,


make timeout configurable from e2e tests

What this PR does / why we need it:

Due to the resources (CPU) crunch in the GitHub actions VM, we have limited CPUs in e2e tests. As a result of this, the execution time of jobs has increased.
Currently PyTorch test job is taking around 10 mins to complete. Because of this PyTorch test job fails sometimes. We have a timeout period of 10 mins in the wait_for_job_conditions functions.
One approach is if we somehow reduce the running time of the PyTorch job. But for this, we will need to build a new image and push it on docker. This can create issues in CI because of the docker pull rate limit.
In this PR, I have made timeout configurable from the e2e test and increased the timeout to 15 mins for PyTorch job.

Checklist:

[ ] Docs included if any changes are user facing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+27.0%) to 39.353%

Files with Coverage Reduction
New Missed Lines
%

pkg/controller.v1/mpi/mpijob_controller.go
4
76.79%

Totals

Change from base Build<PHONE_NUMBER>:
27.0%

Covered Lines:
2726

Relevant Lines:
6927

💛  - Coveralls

Thanks @tenzen-y for the pointers. For now, we can work with higher timeouts in case tests run longer.
/approve


Improve game look feel

Now we have all-svg (loads fast) images that are all the same color, and that are all the same size.

I also fixed some of the game prompt stuff (initialized materialize field) and added an additional instruction.


Add console helper to report users with late tasks

We have to generate this manually so that the users can be contacted and told that their tasks are overdue via GOVUK Notify.

Closing as https://github.com/dxw/DataSubmissionServiceAPI/pull/263 is basically doing the same job.


Add support for simple type classes on nested types

Show, Ord, and alike on lists, tuples, Maybe and more.
depends on PR #191

Other than some OO nitpicks this looks marvelous :+1:


#17170 - DATEDIFF Week Implementation

Resolve #17170

DATEDIFF always uses Sunday as the first day of the week to ensure the function operates in a deterministic way.

kkk, I climbed my last test, was testing some possibilities.
I was sure it was sunday.

@ralmsdeveloper thanks for your effort, could there's a parameter to specific the the first day of week, the Monday is the first day of the week for China in most cases

@smitpatel Note that this isn't a priority; we're not taking this for 3.0.

could there's a parameter to specific the the first day of week, the Monday is the first day of the week for China in most cases

No. That is not possible. According to SqlServer documentation
SET DATEFIRST is used to configure first day of the week. DATEDIFF function has nothing to do with it. And as @ErikEJ mentioned above, it does not have any effect on DATEDIFF.
If you add such parameter then there is no SQL translation for it.

could there's a parameter to specific the the first day of week, the Monday is the first day of the week for China in most cases

No. That is not possible. According to SqlServer documentation
SET DATEFIRST is used to configure first day of the week. DATEDIFF function has nothing to do with it. And as @ErikEJ mentioned above, it does not have any effect on DATEDIFF.
If you add such parameter then there is no SQL translation for it.

@shimingsg thanks for your info, got it from the docs here

Specifying SET DATEFIRST has no effect on DATEDIFF. DATEDIFF always uses Sunday as the first day of the week to ensure the function operates in a deterministic way.

@ralmsdeveloper agradecimentos para seu esforço, poderia lá é um parâmetro a específico o o primeiro dia da semana, a segunda-feira é o primeiro dia da semana para China em a maioria de casos

We can't do this, sql server uses deterministically Sunday, that means the translation will not match the SQL Server result.
Besides the DATEDIFF function does not have the parameter to define what would be the first day of the week.
https://docs.microsoft.com/pt-br/sql/t-sql/functions/datediff-transact-sql?view=sql-server-2017
@WeihanLi
But if you really have this need you can build a custom function for yourself.

Need more testing as requested.

Done!

Merging to release/3.1 in #17726
@ralmsdeveloper - Thank you for contribution.


🐛  AclRequestsResponseModel in API

:bug:  I just found a problem with the updated types / API by chance.
AclRequestsResponseModel describes
"acl_ip" : {
    "type" : "array",
    "items" : {
        "type" : "string"
        }
   },

which in our types translates to a string array (that can be empty, but will always be an array).
The ACL request with req_no 1219  ("MischasSecondTopic") is null. Since TS tells us it's always an array, the code looks the way, which breaks functionality on runtime (in this case it does not open the details modal)
Recording error
https://user-images.githubusercontent.com/943800/225906675-0f5d0bb0-69c8-448f-ab07-5340900db4d5.mov

I believe this may be because the changes to the APIU have not yet been deployed to staging?

The one time I think about creating an issue right away instead of starting the convo in Slack and then opening the issue... :D Will close when I've checked it again after staging update!

The staging environment being redeployed fixed the issue, closing.


Using Postgresql Database

Hi.. I have laravel application that run with pgsql database. is it possible to using it? in aws I will use RDS. how to integrate with it?
Thanks in advice.

yes, when I run it, the apps return "error could not find driver", is bref support pgsql database?

should I modify the dockerfile on vendor?

Hum... You're right, we should compile the pgsql driver for php to be used in bref.

@mnapoli would you like to add enhancement for this issue? thank you

@nurwin I do not need that at the moment so I will not work on that. However feel free to send a pull request to add PostgreSQL support, that would be great!

You just have to add the --with-pdo-pgsql into the Dockerfile isn't it?

I think so, I have never used it so I'm not 100% sure if it needs other dependencies though.


Update babel-plugin-cmz-names to fix Windows issue

Creating this just so that we don't forget.
Details of the resolved issue here:
https://github.com/joshwnj/babel-plugin-cmz-names/pull/1
Already tested successfully in my Windows environment with this repo.

Also tested this and it looks fine. Merging this.


Always match cookies with a wild card domain

Cookies instantiated without a domain get their domain property set
to "*" by default, which seems to imply that they should match any
domain, but matchDomain() did not treat them as such.

Change matchDomain() to return true for cookies with domain of "*"

Nice, thanks @intron!


🐛 [BUG]: Selection key code gets reset after switching browser tabs

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
When the window gets blurred and focused again, the selection key code true value is lost, and the behaviour goes back to panning.
Expected Behavior
When the window gets blurred and focused again, the selection key code true should remain, and selection should be default behaviour instead of panning.
Steps To Reproduce
Reproduction: https://stackblitz.com/edit/sb1-mhrbpx?file=src%2FApp.vue

Set selection-key-code to true
Works as expected
Switch browser tabs
The behaviour is now back to panning instead of selecting

Relevant log output
No response
Anything else?
No response

Does this issue happen for you in the examples of the next-release? https://vue-flow-docs-git-next-release-burak-cakmakoglus-projects.vercel.app/
I can't seem to reproduce it there anymore.

Nvm I noticed that this value gets reset once a blur or contextmenu is event is detected 😄
Will be fixed in the next release 👍

Awesome! Thank you so much 🙏

Fixed with 1.41.3


Broken link in docs

The "View Source" link on Directional Property is currently broken, linking here. I think I should be going to this file.

Thanks for the heads up!


Fix power admin down up test

For every Fabric & Linecard reboot, validate Before & After Interfaces and their OperStatus.
For ControllerCard reboot, wait until the primary supervisor becomes switchover-ready after power down up.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.896%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1320

Relevant Lines:
2756

💛  - Coveralls

/gcbrun

/gcbrun


Modal appears behind some react-bootstrap elements

Summary:

The modal appears to sit behind certain kinds of elements, the most obvious being input addons.
I'm not totally sure if this is an issue with react-modal, react-bootstrap or both, so I've created a ticket on react-bootstrap also. If this is totally not your fault and I should take it up with someone else please let me know. My css-fu is very much lacking so forgive my ignorance in that area.
Steps to reproduce:
I've made a basic repo as seen in the screenshot above.

git clone https://github.com/zensavona/bootstrap-modal-repro
cd bootstrap-modal-repro
npm install && npm run start
Take a look in your browser

Let me know if there's something else I can provide to help with this, it's a pretty nasty bug(?).

@Zensavona Sorry for the delay on getting to this.
It appears that you have some styles that are making those inputs show up with a higher z-index.
Specifically I was looking at .input-group .form-control.  It sets z-index: 2 which brings it higher than the modal (that doesn't default to anything).
You can fix this specific case by sending in style={{overlay: {zIndex: 3}}} or any other z-index higher than 3.  When I tested it... I used 10.
As this is unrelated to the modal itself, I'm going to go ahead and close the issue.  Thanks!


development: add tilt file

Introduce Tilt to simplify the development process.
Note: the .dockerignore file had to be renamed to allow Tilt to properly build its container image

I'm a big fan of Tilt!

This was a demo PR, I'm going to open a proper one against the real target repository


Duplicate input types created

I'm unable to really track down how this is happening, but it's presenting issues with our schema.
The issue is when an input type is a field of another input type.  In these cases, it's mostly working correctly and represented correctly in the schema except it creates two input types.  Consider the following:
class Factory
{
    /**
     * @Factory()
     */
    public function makeCreateCategory(string $name): CreateCategory {}

    /**
     * @Factory()
     */
    public function makeCreateProduct(
        string $name,
        Money $price,
        CreateCategory $createCategory
    ): CreateProduct {}
}

In this case above the CreateCategory will result in 2 input types in the schema, CreateCategory and CreateCategoryInput.

Weird! I would have expected it to fail....
You can have many @Factory returning the same type, but all of them expect one must be marked as "non-default" and a name must be explicitly given.
In your example, I would expect this to work:
class Factory
{
    /**
     * @Factory(default=true)
     */
    public function makeCreateCategory(string $name): CreateCategory {}

    /**
     * @Factory(default=true, name="SomeOtherName")
     */
    public function makeCreateProduct(
        string $name,
        Money $price,
        CreateCategory $createCategory
    ): CreateProduct {}
}

I'll write some more test cases to see how we can improve this.
Also, I'll be on holiday for the next week so do not be surprised if you don't get any news!

@moufmouf enjoy your holiday!  We've got a hack in place for the moment, but noticed a lot of phantom output types in our schema as well - be great to get that cleaned up.


Should we use Discussions for each Community Call post?

Discussions can be pinned, which makes them quite visible.
The Q&A threaded format feels easier to manage separate threads (often there are quite a few different Q&As going on). This may also make it easier to keep track of covering everything in the call itself.
We could still have a "Community Call sign-up" issue which is pinned & locked to link to the latest Discussion.

Will do, starting next month!


[BUG] Helm 3.2.2 and 3.2.3 upgrade fails because service of spec.clusterIP

My helm upgrade fails with version 3.2.2 and 3.2.3 but works with helm 3.2.0.
Command:
helm upgrade sense adx/sense --set=global.waiter.service_account.create=false -f values.yaml -f ../global.yaml --no-hooks --force --install Error: UPGRADE FAILED: failed to replace object: Service "catalog" is invalid: spec.clusterIP: Invalid value: "": field is immutable
The helm chart template:
apiVersion: v1
kind: Service
metadata:
  name: catalog
spec:
  selector:
    {{ .Values.global.control.cluster_label }}: catalog
  ports:
    - name: catalog
      port: {{ .Values.catalog.port }}
      targetPort: {{ .Values.catalog.port }}
  type: ClusterIP
  sessionAffinity: None

Running a helm template with version 3.2.3
# Source: sense/charts/catalog/templates/catalog-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: catalog
spec:
  selector:
    greymatter.io/control: catalog
  ports:
    - name: catalog
      port: 9080
      targetPort: 9080
  type: ClusterIP
  sessionAffinity: None

Running a helm template with version 3.2.0 (same as 3.2.3)
# Source: sense/charts/catalog/templates/catalog-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: catalog
spec:
  selector:
    greymatter.io/control: catalog
  ports:
    - name: catalog
      port: 9080
      targetPort: 9080
  type: ClusterIP
  sessionAffinity: None

Output of helm version:
helm version version.BuildInfo{Version:"v3.2.3", GitCommit:"8f832046e258e2cb800894579b1b3b50c2d83492", GitTreeState:"clean", GoVersion:"go1.13.12"}
Output of kubectl version:
kc version Client Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.6-beta.0", GitCommit:"e7f962ba86f4ce7033828210ca3556393c377bcc", GitTreeState:"clean", BuildDate:"2020-01-15T08:26:26Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"darwin/amd64"} error: You must be logged in to the server (the server has asked for the client to provide credentials) oc version oc v3.11.0+0cbc58b kubernetes v1.11.0+d4cacc0
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AWS

duplicate of https://github.com/helm/helm/issues/7956.

Actually, your issue is different. You are using the --force flag. This tells Helm to make a PUT request to kubernetes rather than a PATCH. Certain fields are auto-populated by Kubernetes, including the service IP. Once it is assigned, it cannot be changed. This is working and intended behaviour from kubernetes' standpoint.

Thanks @bacongobbler!


Admin # 1271 Show RTF for ASC questions

What's included?
Rich text display of ASC details.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Ensure Rich text is displayed to candidates when viewing ASC questions. - See screen below
Risk - how likely is this to impact other areas?
🟠 Medium risk - Here we are using v-html to manipulate the DOM directly, we are doing this elsewhere but its worth noting.
Additional context

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Sent to UTG today for re-testing after changes.


[To new_sync][IOTDB-2630] new_sync branch, enhance class SenderService etc.

Description
Content1 ...
Content2 ...
Content3 ...

This PR has:

[ ] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@HTHou  Could you help merge this PR?


[$1000] workspace picture not update in report screen

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to Settings > Workspaces
create new workspace
close the modal
click on workspace chat in LHN
go to Settings > Workspaces
change the workspace picture
check the workspace picture in report screen

Expected Result:
should show updated workspace picture in report screen
Actual Result:
does not show updated workspace picture in report screen
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.17-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/20d696a3-0503-4de9-be64-156c5b933941
https://github.com/Expensify/App/assets/43996225/2960b16a-ddbe-413a-81fa-f62f1722797d
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684772113159839?thread_ts=1684126449.749049&cid=C049HHMV9SM
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018c5cb09414a1b64c
Upwork Job ID:<PHONE_NUMBER>655844864
Last Price Increase: 2023-05-26

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace picture not update in report screen
What is the root cause of that problem?
Problem came from here:
https://github.com/Expensify/App/blob/7a42755a79737314edf702ce17bf0647dd8c41fb/src/pages/home/report/ReportActionsView.js#L172
Since the icons doesn't exist in this.props.report this will make this condition always return false. That's why when we updated the avatar, the avatar of ReportActionItemCreated isn't updated.
What changes do you think we should make in order to solve the problem?
Add the icons props to ReportActionsView and change the condition of shouldComponentUpdate:
const currentReportData = (isTaskReport || !isThread) && props.report.parentReportID ? props.parentReport : props.report;
const icons = ReportUtils.getIcons(this.props.report, this.props.personalDetails);

                                <ReportActionsView
                                    reportActions={this.props.reportActions}
                                    report={this.props.report}
                                    isComposerFullSize={this.props.isComposerFullSize}
                                    isDrawerOpen={this.props.isDrawerOpen}
                                    parentViewHeight={this.state.skeletonViewContainerHeight}
                                    personalDetails={this.props.personalDetails}
                                    icons={icons}
                                />

and the condition of shouldComponentUpdate inside ReportActionsView:
return !_.isEqual(lodashGet(this.props, 'icons', []), lodashGet(nextProps, 'icons', []));

What alternative solutions did you explore? (Optional)
N/A
###Result
https://github.com/Expensify/App/assets/16502320/23dae7e9-3879-492f-9b8e-a47a2f7b5fcf

Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace picture not update in report screen
What is the root cause of that problem?
Problem came from here:
https://github.com/Expensify/App/blob/7a42755a79737314edf702ce17bf0647dd8c41fb/src/pages/home/report/ReportActionsView.js#L172
Since the icons doesn't exist in this.props.report this will make this condition always return false. That's why when we updated the avatar, the avatar of ReportActionItemCreated isn't updated.
What changes do you think we should make in order to solve the problem?
Add the icons props to ReportActionsView and change the condition of shouldComponentUpdate:
const currentReportData = (isTaskReport || !isThread) && props.report.parentReportID ? props.parentReport : props.report;
const icons = ReportUtils.getIcons(this.props.report, this.props.personalDetails);

                                <ReportActionsView
                                    reportActions={this.props.reportActions}
                                    report={this.props.report}
                                    isComposerFullSize={this.props.isComposerFullSize}
                                    isDrawerOpen={this.props.isDrawerOpen}
                                    parentViewHeight={this.state.skeletonViewContainerHeight}
                                    personalDetails={this.props.personalDetails}
                                    icons={icons}
                                />

and the condition of shouldComponentUpdate inside ReportActionsView:
return !_.isEqual(lodashGet(this.props, 'icons', []), lodashGet(nextProps, 'icons', []));

We can keep the old condition above the new condition if we want but we need to change it toif condition:
if (!isEqual(lodashGet(this.props.report, 'icons', []), lodashGet(nextProps.report, 'icons', [])) {
return true;
}

What alternative solutions did you explore? (Optional)
In case we don't wanna pass a new props, we can also calculate the icons inside shouldComponentUpdate of ReportActionsView:
  const icons = ReportUtils.getIcons(this.props.report, this.props.personalDetails);
  const nextIcons = ReportUtils.getIcons(nextProps, this.props.personalDetails);

return !_.isEqual(icons, nextIcons);

Result
https://github.com/Expensify/App/assets/16502320/23dae7e9-3879-492f-9b8e-a47a2f7b5fcf

Reviewing this now

@hungvu193's Root cause is correct and the proposal is also working fine while testing.
I like the alternate solution since I think its better to not create a new param just to solve this issue.
🎀👀🎀
C+ Reviewed
cc: @iwiznia

@hungvu193  Just a minor note, in the alternate solution const nextIcons = ReportUtils.getIcons(nextProps, this.props.personalDetails); should have nextProps.report

I also like the alternative.

https://github.com/Expensify/App/pull/19750 is ready for review!

Nice, just waiting on responses to @abdulrahuman5196 in the PR @hungvu193

Bugzero checklist:

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

This isn't a regression. But a miss from the original implementation and we didn't get to know of this issue until now.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Very minor case only present in large screen devices. So I don't think regression test is beneficial in this case.

Okay, all offers sent. Sorry for the delay.

@twisterdotcom  accepted, Thanks!

@twisterdotcom  accepted

Wow, you're all online! Great. Okay, we didn't get the "bonus" issue comment, but just double checking, there isn't one due.
Assigned: https://github.com/Expensify/App/issues/19550#event-9370255567 - May 29th, 2023 @ 4:38 PM GMT +1
Merged: https://github.com/Expensify/App/pull/19750#event-9436231511 - June 5, 2023 @ 6.12 PM GMT +1

I think if this solved another issue too, your "bonus" is the payment for that issue as well.


gold/silver price api implementation added

🎯 Title and Issue Number
Gold-Silver Live price Tracker
i have used goldapi.io for getting data i have shown implemenntation of this api and printed on frontend html
Closes #166

Screenshot of data and html view

🗒 Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x]  I have gone through rules of when PR will get merged.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have followed proper file structure.
[x] I have gone through CONTRIBUTING GUIDELINES.md.

Thank you for contributing!❤
Don't forget to show some love by ⭐ the repository!

Hey @Yashgabani845, Thank you for creating PR! We will review it super soon. 😇❣
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣

@dishamodi0910 kindly review my PR asap

/gssoc24

@Yashgabani845 We're thrilled to inform you that your pull request has been successfully merged into the APIverse🚀🎁
Your hard work, dedication, and expertise have made a significant impact on our project, and we couldn't be more grateful for your contributions.😇
Your code will now be a part of our growing ecosystem, helping developers worldwide to create exceptional APIs.❣🔥
Happy Coding! ✨
Will See you soon❣