Change the integer-literal type from Int2048 to IntLiteral

Part of SR-290 / rdar://25100871.
The type was implemented in https://github.com/apple/swift/pull/20200.
Runtime support was added in #20177.

@swift-ci Please test.

Build failed
Swift Test OS X Platform
Git Sha - 8a26656ee4f8e843757f598b0b88de7e72911037

@swift-ci Please test.

@swift-ci Please test source compatibility

@swift-ci Please test OS X.

@swift-ci Please smoke benchmark.

@swift-ci Please benchmark

Okay, all those source-compatibility failures are there on the main bots.

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

CStringLongAscii
3526
3282
-6.9%
1.07x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Improvement

CStringLongAscii
3528
3278
-7.1%
1.08x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Improvement

DictionaryCompactMapValuesOfCastValue
123656
97884
-20.8%
1.26x

WordCountUniqueASCII
8167
6935
-15.1%
1.18x

ArrayOfGenericPOD2
1236
1067
-13.7%
1.16x (?)

ArrayOfPOD
858
782
-8.9%
1.10x

MonteCarloE
1231361
1144667
-7.0%
1.08x

MonteCarloPi
5656060
5279794
-6.7%
1.07x

Code size: Swift libraries

TEST
OLD
NEW
DELTA
RATIO

Improvement

libswiftCore.dylib
3911680
3813376
-2.5%
1.03x

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

StringHashing_abnormal
1311
1430
+9.1%
0.92x

CStringLongAscii
3282
3540
+7.9%
0.93x

Improvement

UTF8Decode_InitFromBytes
1387
1185
-14.6%
1.17x

StringWordBuilder
1887
1739
-7.8%
1.09x (?)

FloatingPointPrinting_Float_description_small
5561
5173
-7.0%
1.08x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

StringHashing_abnormal
1305
1434
+9.9%
0.91x

CStringLongAscii
3280
3534
+7.7%
0.93x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayOfGenericPOD2
1066
1236
+15.9%
0.86x (?)

UTF8Decode_InitDecoding_ascii
843
927
+10.0%
0.91x

ArrayOfPOD
785
861
+9.7%
0.91x (?)

CStringLongAscii
3367
3638
+8.0%
0.93x

Improvement

CharIteration_tweet_unicodeScalars_Backwards
624239
498797
-20.1%
1.25x

CharIteration_chinese_unicodeScalars_Backwards
229660
190255
-17.2%
1.21x

CharIteration_russian_unicodeScalars_Backwards
251977
209430
-16.9%
1.20x

CharIteration_japanese_unicodeScalars_Backwards
362111
301470
-16.7%
1.20x

CharIteration_korean_unicodeScalars_Backwards
292831
243863
-16.7%
1.20x

CharIteration_punctuated_unicodeScalars_Backwards
66138
55310
-16.4%
1.20x

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
52510
44078
-16.1%
1.19x

CharIteration_utf16_unicodeScalars_Backwards
249009
219512
-11.8%
1.13x

DictionaryCompactMapValuesOfCastValue
109579
99017
-9.6%
1.11x

MonteCarloE
1236852
1147753
-7.2%
1.08x

ArraySubscript
115102
107035
-7.0%
1.08x

MonteCarloPi
5643028
5257793
-6.8%
1.07x

Code size: Swift libraries

TEST
OLD
NEW
DELTA
RATIO

Improvement

libswiftCore.dylib
3911680
3813376
-2.5%
1.03x

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB


Duplicate DeepL Recipe

Hi Peter
I would kindly ask you to retract your DeepL workflow which you merged two days ago.
The download recipe is an incomplete duplicate of andredb90's downloader and we added a working munki recipe without duplicating any recipes which were reported by autopkg search deepl on Monday.
Best wishes
jutonium

@Jutonium, I am honestly a little surprised by your request.
Could you please explain why you believe our recipe is an "incomplete duplicate" of that andredb90's download recipe? I just compared them and cannot find much difference at all... Truth to be told, I was not even ware of its existence. We wrote our DeepL recipes on Sept 12 2019, when there wasn't anything available at all - however, we did not bother uploading them until later.
I have no general objection retiring ours and using that download recipe instead and do - of course - support the "one recipe" approach that autopkg is mandating. Yet, I am wondering why you came up with another DeepL.munki.recipe when ours existed already... and the suggested approach would have been a pull request, e.g. with a reference to that andredb90 download recipe.

@Jutonium, I am honestly a little surprised by your request.
Could you please explain why you believe our recipe is an "incomplete duplicate" of that andredb90's download recipe? I just compared them and cannot find much difference at all... Truth to be told, I was not even ware of its existence. We wrote our DeepL recipes on Sept 12 2019, when there wasn't anything available at all - however, we did not bother uploading them until later.
I have no general objection retiring ours and using that download recipe instead and do - of course - support the "one recipe" approach that autopkg is mandating. Yet, I am wondering why you came up with another DeepL.munki.recipe when ours existed already... and the suggested approach would have been a pull request, e.g. with a reference to that andredb90 download recipe.

Hi Peter
We ran autopkg search deepl before we started to write a workflow and found only andredb90's download and filewave workflows. After merging our recipes yours started showing up as well. Maybe a caching error.
I would suggest that we deprecate and retract ours. Could you add a variable for the filename or use andredb90's downloader?
The edit would look like this:
<dict>
    <key>Arguments</key>
    <dict>
        <key>filename</key>
        <string>%NAME%.dmg</string>
        <key>url</key>
        <string>%DOWNLOAD_URL%</string>
    </dict>
    <key>Processor</key>
    <string>URLDownloader</string>
</dict>

Thank you

Hi Peter
We ran autopkg search deepl before we started to write a workflow and found only andredb90's download and filewave workflows. After merging our recipes yours started showing up as well. Maybe a caching error.
I would suggest that we deprecate and retract ours. Could you add a variable for the filename or use andredb90's downloader?
The edit would look like this:
<dict>
    <key>Arguments</key>
    <dict>
        <key>filename</key>
        <string>%NAME%.dmg</string>
        <key>url</key>
        <string>%DOWNLOAD_URL%</string>
    </dict>
    <key>Processor</key>
    <string>URLDownloader</string>
</dict>

Thank you

@jutonium, sorry that took some time. I updated our recipe to use andredb90's download recipe as requested by you.


Electron: Super expression must either be null or a function

When using the Electron to build a node based application, calling import jsforce from 'jsforce' or equivalent imports causes the following error to be thrown:
Uncaught TypeError: Super expression must either be null or a function
    at _inherits (jsforce.js?v=729c22ad:29589:51)
    at jsforce.js?v=729c22ad:30483:3
    at jsforce.js?v=729c22ad:30507:2

Other environmental factors: running in babel in ES6 module, vite for React
Screenshot in case helpfuls

Have you looked at why this common "Super expression must either be null or a function " error occurs? Your anti-pattern cannot be solved by jsforce community (unless they start making react components)
https://www.dhiwise.com/post/fix-the-super-expression-must-either-be-null-or-a-function
https://stackoverflow.com/questions/30116430/reactjs-giving-error-uncaught-typeerror-super-expression-must-either-be-null-or

@gmillerd sorry if there was confusion. This error isn't coming from any code I've written, it's happening when I attempt to import jsforce in a es6 js file. The screenshot isn't of code I've written, but of the source of the error identified at runtime from the jsforce package.


[Inference] keyError when loading other versions of bloom model

I have try bloomchat and tigerbot-7b-sft, but they all got the keyError
deepspeed --hostfile hostfile inference-test.py --name "TigerResearch/tigerbot-7b-sft" --dtype float16 --use_meta_tensor --replace_method "auto" --use_kernel --checkpoint_path "TigerResearch/tigerbot-7b-sft" --ds_inference

KeyError: 'ln_f.weight'
Tigerbot's index file https://huggingface.co/TigerResearch/tigerbot-7b-sft/blob/main/pytorch_model.bin.index.json
"transformer.ln_f.bias": "pytorch_model-00003-of-00004.bin",
"transformer.ln_f.weight": "pytorch_model-00003-of-00004.bin",
Origin bloom index file https://huggingface.co/bigscience/bloom/blob/main/pytorch_model.bin.index.json
"ln_f.bias": "pytorch_model_00072-of-00072.bin",
"ln_f.weight": "pytorch_model_00072-of-00072.bin",
How to use inference-test.py to do the inference of both bloomchat and Tigerbot?

Hi @YuxiangJohn,
Thank you for bringing this issue to our attention. I was able to reproduce the issue and created a fix in this PR:
https://github.com/microsoft/DeepSpeed/pull/3885
Can you kindly try on your side to see if this fix works for you as well?
Thanks,
Lev


doc note on curl dependency

added a note on curl dependency to the documentation. I kept forgetting when setting up new ubuntu 10.04 servers which don't have curl installed by default.

Thanks, but I think the curl requirement is incidental.


support doris please.

It would be great to use dbt-fal with Doris, a popular open source data warehouse.

no need, support all DW


Support of new API for Google Maps, caching improvements, rearrangement of finders

Yandex Maps disabled free quotas for their API, so we have to use Google Maps and OSM only.
To not outreach the free quotas of Google API, let's use the cache more aggressively and store everything in Redis.
Also, let's update teloxide and other libraries.

I would create a trait for requesting a location by name. It would have different implementations—for Yandex, Google, etc.
There is also a cache implementation, which takes an instance of another implementation and stores its responses in the cache. At the same time, it doesn’t even know which implementation it is, thanks to generics or dyn.
You could also make the requester trait contain a getter for the name in one form or another, and make the cache itself obtain this information. Maybe also a getter for a recommended by APi owners cache TTL...

I would create a trait for requesting a location by name. It would have different implementations—for Yandex, Google, etc.

LocFinder already exists :)

There is also a cache implementation, which takes an instance of another implementation and stores its responses in the cache. At the same time, it doesn’t even know which implementation it is, thanks to generics or dyn.

I agree, taking all customizations, done in this PR, into account, it would be better to implement a manual cache of parsed and transformed responses, not as an HTTP client middleware. However, we have to not forget about different search chains for different regions.

recommended by API owners cache TTL

This is a controversial topic. Some providers officially forbid to cache their responses in any form and
do everything they can to prevent such caching. And I don't really want to reimplement all RFC logic about such semantics for OpenStreetView only.
I'll create a new issue on this topic, but this is not a serious problem now, I think.


Remove unnecessary dependency on jmespath

This is fairly straightforward manipulation to do with standard Jinja features, there's no need to use a non-default library.

This needs a rebase to get the tests to pass.

Or, maybe something else is broken. :frowning_face:

Ahh, I think I see what's going on. molecule is not creating the role symlink because it's a PR from a fork. Boo.

Or, maybe something else is broken.

This is a brief window of time during which the latest newest ansible-compat is broken.
Change test-requirements.txt:
# temporarily lock versions of molecule and ansible-compat to avoid a bug:
ansible-compat==0.5.0
molecule==3.5.2

Ok, fixed HEAD. Please rebase again.

@SuperQ Looking a little better, but it's still complaining about the Mergify configuration, and I'm not sure what's up with the failure for test-2.9-default.

mergify strict mode is end-of-life
circleci config file, should run on large instances.  resource_class: large


Jittery acceleration when going downhill. OP will bounce on Max speed matching.

Describe the bug
When setting a max speed and coasting downhill with Openpilot, openpilot seems to overcompensate for the coasting and decrease your speed too much. This results in bouncing between max speed and 1mph below max speed. It can be felt in the car and seen on the tachometer
How to reproduce or log data
enable autopilot at any max speed. Proceed towards a road decline. If the decline would increase your speed above the openpilot max speed, then the issue seems to occur every time. This did not happen with stock ACC.
log data made public
Expected behavior
open pilot will pick a speed for the decline and stay there. Rather than bouncing around.
Device/Version information (please complete the following information):
Device: C2
Dongle ID: f080b0eff75e609f
Route: f080b0eff75e609f/1623112435320/1623113870691
Timestamp: f080b0eff75e609f|2021-06-07--19-33-55--16
Version: 0.8.4
Car make/model: 2019 Honda Odyssey

Additional context

I would second this issue is annoying.

@pd0wm This cannot be optimally fixed without introducing road slope into op long calculation.
road slope = (long ax from intertial sensor) - (ax from wheel). with some filtering?
final_accel = (road slope + output_gb)
eg.
on a 10% slope downhill, or a ~1m/s2 effective acceleration due to slope, the braking should start form (output_gb < 1m/s2) and not (output_gb <0 m/s2) like it is set up to do now. the current setup will cause a inital high error(1m/s2 step) in the brake controller causing it to over brake and release and oscillate.
if we want to maintian a constant speed on a downhill slope, the braking accel to the brake controller should be equal to effective accel(g*sin(theta)) due to roadslope.

The Honda Odyssey tuning is being addressed in https://github.com/commaai/openpilot/issues/21697.


Can not attach volume from VM sidebar

Steps to reproduce

Open VM sidebar and go to storage tab
Click create a new one (Attach a volume card)
Create new volume
Go to the same VM and storage tab.

Actual result

You can not attach a volume to a virtual machine, even if there are spare ones.
Expected result

Be able to attach a spare volume.
Environment

Browser:
- [ ] Chrome version XX
- [ ] Firefox version XX
- [ ] Safari version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

Connected feature ID

vm_disk_attach
Screenshots

Test on:
tamazlykar/1100-attach-volume
Regression:
vm_disk_attach

Tested on tamazlykar/1100-attach-volume
If you simultaneously attach/detach multiple disks to the VM, then the operation of the first repository is displayed indefinitely. Only after reloading the page is a successful result.
Steps:

Log in and go to VM
Make sure that you have a VM and several free storages
Go to sidebar VM in Storage tab
Simultaneously attach or detach two storages to VM

Actual result: Operation of first storage is displayed indefinitely without refresh page.
Expected result: Operations of all storages age ending without refresh page.

Tested on tamazlykar/1100-attach-volume


Test users v2

Codecov Report

Merging #83 (05c1f2d) into main (68faf9e) will increase coverage by 3.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   48.19%   51.33%   +3.13%
==========================================
  Files         239      239
  Lines        5895     5895
==========================================
+ Hits         2841     3026     +185
+ Misses       3054     2869     -185

Impacted Files
Coverage Δ

...APIKit/APIv2/Users/Requests/GetUserRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...PIKit/APIv2/Users/Requests/GetUsersRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...Kit/APIv2/Users/Requests/GetUsersByRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...Kit/APIv2/Users/Requests/GetUsersMeRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

.../APIv2/Like/Requests/PostUsersLikesRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...PIv2/Like/Requests/DeleteUsersLikesRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...2/Like/Requests/GetUsersLikedTweetsRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

...2/Users/Requests/GetUsersByUsernameRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

.../Like/Requests/GetTweetsLikingUsersRequestV2.swift
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68faf9e...05c1f2d. Read the comment docs.


Typo in string reactive commands

Hello!
Small one, I think it was a typo :)

Thank you for your contribution. That's merged, polished, and backported now.


PLEASE DO NOT APPROVE. Testing for security issues. fwbtqv

PLEASE DO NOT APPROVE. Testing for security issues. fwbtqv

Build succeeded (check pipeline).


feat: take Fragments and Arrays into account for Switch

This PR fixes #154.
I open it in case the ideas discussed in #154 are accepted. This adds a flattenChildren method used inside the Switch component to gracefully handle Arrays and Fragments as children of Switch. This opens up nicer patterns for static fallback routes with dynamically defined siblings.
This PR also adds two tests for the Switch component, validating its handling of Arrays and Fragments.

Great work!


(bugsbash)Package "prometheus/prometheus/pkg/labels" imported twice

Signed-off-by: aSquare14<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x ] Change is not relevant to the end user.

Changes
Fixes ST1019 : package "github.com/prometheus/prometheus/pkg/labels" is being imported more than once

Verification

Thank you @asquare14! Could you please sign the DCO (hint git commit --amend --signoff) and push again?

Ahh there's an issue with my laptop and by mistake I removed all the CLI tools. Waiting for some software to get installed. Will signoff in an hour or so. Meanwhile looking at how to signoff using GitHub UI. Thanks for the review !

@squat Done !


Undo event handler to trigger undo or redo without keyboard event.

Feature
I want to handle the Undo and Redo using a custom button inside or outside the editors,
Describe the solution you'd like
If there will be an event handler for undo library that would be very helpful.
If you have any existing solution for this, please tell me, I am not able to find it so far.

temporary solution I found,
const handleUndo = (e, isUndo = true) => {     try {       e.preventDefault();       const event = new KeyboardEvent("keydown", {         // bubbles: true,         cancelable: true,         key: "z",         metaKey: /(Mac)/i.test(navigator.platform) ? true : false,         ctrlKey: /(Mac)/i.test(navigator.platform) ? false : true,         shiftKey: !isUndo,       });       document.getElementById("editorjs").dispatchEvent(event);     } catch (error) {       console.error("Error while Undo/Redo ", error);     }   };

@cptiwari20 Thank you for reporting the issue. To utilize the 'Undo' and 'Redo' functions outside of the plugin, you can assign a variable to the 'Undo' instance within the onReady() callback. Then, you can employ this variable anywhere within your code. For a practical example, please refer to the CodeSandbox demonstration provided.
Code Sandbox example


Complete functionality of SparseTensor.mul

System information

TensorFlow version (you are using): 2,3
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
Currently SparseTensor.mul is limited to multiplication between a sparse tensor and a dense tensor. Broadcasting is only supported from the dense side to the sparse side, as per the documentation: https://www.tensorflow.org/api_docs/python/tf/sparse/SparseTensor#mul
My request is to expand this behaviour to also include multiplications between two sparse tensors, and to allow broadcasting in both directions. This will complete the functionality and make the use of sparse tensors similar to that of dense tensors.
Will this change the current api? How?
The current options should of course still be supported, but more tensor combinations should be supported. This is purely the removal of a limitation that is already stated in the API.
Who will benefit with this feature?
Anyone who uses SparseTensors will want to manipulate them using the basic functions like multiplication and division (which can probably be added at the same time). This is certainly true for my own use in Graph Neural networks, but sparse tensor calculations are needed in many other applications as well.
Any Other info.
I have written a pure python implementation of broadcast multiply between two sparse tensors, which is shared in this stackoverflow question: https://stackoverflow.com/questions/63023958/how-to-efficiently-broadcast-multiply-two-sparse-tensors-in-tensorflow. However, as noted there, it is not memory efficient enough to be really useful. I expect that a C++ implementation is needed, and unfortunately I do not know how to write that. If I can contribute any more code, I would be happy to, but my knowledge of C++ and CUDA is limited.

We have also https://www.tensorflow.org/api_docs/python/tf/raw_ops/SparseMatrixSparseMatMul for SparseTensor (CSR).

We have also https://www.tensorflow.org/api_docs/python/tf/raw_ops/SparseMatrixSparseMatMul for SparseTensor (CSR).

Thank you, Yes, I have looked at that as well and it is very different from what I reference here. Note that matrix multiplication is a different operation than regular tensor multiplication with broadcasting. The fact that both are called multiplication is actually a little misleading, but that's the fault of mathematics terminology I guess.

You are right. I have re-read your ticket description and yes you was specifically requesting broadcasting in both directions.

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Updated React and Webpack.md to fix the error thrown by tslint

Hi there,
I have added the typedef to the const in the stateless functional component code on line 125.  tslint was complaining about the expected typedef for the const variable .

Thanks
Rajiv

I do not think every stateless component needs to have a type declaration. this seems excessive. I would say either disable the lint rule, or file a bug on the tslint side.

@mhegazy sounds good 👍 .


Previous/ Next button while watching video

Can we add a little button and the left and right of each video to go to the next or previous video, In this way you can keep watching videos without going back and fort to the homepage.

Okay, now we know how the buttons will look like, perfect! But how will the action look like? What will exactly happen as soon as a user clicks on one of those buttons?

Right got to next, left to te previous video? And them preferably from the same category as you are currently looking at on the homepage. So it makes sense which movie comes next.

@davehakkens Hehe, yep. I've already understood what you want it to do. But what we still need to think about is how the transition between the current movie and the next/previous movie will work. There are many ways to do this:

Close the detail view and open it with the next/previous video?
Just replace the video, the title and the rating

Those are just examples. What do you think?

Ah like that.
Preferably the “light” one. That uses little CPU. Like it when this goes quick.
Not sure which one that is, but probably with little transitions.
Op dinsdag 6 oktober 2015, om 22:01 heeft Leonard het volgende geschreven:

@davehakkens (https://github.com/davehakkens) Hehe, yep. I've already understood what you want it to do. But what we still need to think about is how the transition between the current movie and the next/previous movie will work. There are many ways to do this:
Close the detail view and open it with the next/previous video?
Just replace the video, the title and the rating
Those are just examples. What do you think?
—
Reply to this email directly or view it on GitHub (https://github.com/hakkens/hopper/issues/7#issuecomment-145980940).

Okay!
But just so you know: You could develop a whole game with thousands of JavaScript effects on your site before a regular device starts lagging. Please don't worry about speed.
I guess I will fade both the title, the movie and the rating out and fade them back in as soon as the next/previous video was set.


Update CONFIG.md

Thanks, but this is autogenerated, you'll need to modify the documentation in the respective luafile, and docgen will update config.md after you file the PR.

Thanks, but this is autogenerated, you'll need to modify the documentation in the respective luafile, and docgen will update config.md after you file the PR.


Update WRITING_PLUGINS.md

Names should be CamelCase, types should be snake_case.

I think you missed a name in the extending agent section

Thanks, done.


ImportError: cannot import name 'create_connection' from 'websocket'

I ran pip install gemini_python but when I try to run the following simple script to place an order:
import gemini
import secrets

def main():
    r = gemini.PrivateClient(secrets.api_key, secrets.api_secret)
    r.new_order("XTZUSD", "250", "6.6281", "buy")

if __name__ == '__main__':
    main()

I get the error:
Traceback (most recent call last):
  File "/Users/sergeiwallace/PycharmProjects/GeminiAPI/main.py", line 1, in <module>
    import gemini
  File "/Users/sergeiwallace/PycharmProjects/GeminiAPI/venv/lib/python3.9/site-packages/gemini/__init__.py", line 3, in <module>
    from .basewebsocket import BaseWebSocket
  File "/Users/sergeiwallace/PycharmProjects/GeminiAPI/venv/lib/python3.9/site-packages/gemini/basewebsocket.py", line 9, in <module>
    from websocket import create_connection, WebSocketConnectionClosedException
ImportError: cannot import name 'create_connection' from 'websocket' (/Users/sergeiwallace/PycharmProjects/GeminiAPI/venv/lib/python3.9/site-packages/websocket/__init__.py)

I've explicitly run pip install websocket-client but it says it's already installed.
Anyone know what the issue is?

Running pip install websocket-client==0.44.0 fixed it for me

I'm still getting this exception even when using websocket-client version 0.44.0.

Running pip install websocket-client==0.44.0 fixed it for me

This worked for me as well, thanks.


⚠ Mobitopup has degraded performance

In d0553e3, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5901 ms

Resolved: Mobitopup performance has improved in 9612b8a.


[v.1.36.0] $ within inline-javascript cannot be used

Describe the bug
Adding a $ (dollar sign) within the ${} for inline-javascript for use as a string does not work as expected. It works with just a regular plain string e.g. "$100" but if you need to use it with an env variable then it goes awry.
Case 1: - evalScript: ${console.log('$')}
Case 2: - text: '${"$" + ENV_VARIABLE + "+"}'
This was mentioned in Slack as well.
To Reproduce
0. Write the test with the single line

Start the simulator
Run maestro test ...
The step is run without an issue but no log is actually sent to the terminal

Expected behavior
For cases written above:

Gets logged to the terminal with the dollar sign and the value of the env variable
assertVisible etc works as expected with this while parsing the screen as usual

Screenshots
N/A
Environment information (please complete the following information):

Maestro version [v.1.36.0]
Platform: [iOS 17.0.0+]
Framework: [React Native with Expo]
Device model and OS version: [iPhone 14+]
Simulator
Host [Mac]

Workspace (if applicable)
N/A
Bugreport output (if applicable)
N/A
Additional context
N/A

I was able to reproduce this:
flow
appId: com.example.example
---
- launchApp
- evalScript: ${console.log('Hello!')}
- evalScript: ${console.log('Hello money! $')}
- evalScript: ${console.log('$')}

output
Running on emulator-5554

 ║
 ║  > Flow
 ║
 ║    ✅  Launch app "com.example.example"
 ║    ✅  Run ${console.log('Hello!')}
 ║         Log messages:
 ║           Hello!
 ║    ✅  Run ${console.log('Hello money! $')}
 ║    ✅  Run ${console.log('$')}
 ║


Is not possible move to the left

It doesn't. make sense to have this functionality because is not possible to move to the left. I suggest to remove the functionality

It's not a bug!!!!


Validation of the option for text line width is incorrect

The test for the value of text line width option is the wrong way around at https://github.com/crossjoin/PreMailer/blob/master/src/Crossjoin/PreMailer/PreMailerAbstract.php#L135
if ($value >= 0) {

It should be
if ($value <= 0) {

Thank you. I fixed the bug and will create a new release soon.


Route : tasks/:username for getting tasks of user

Create new route tasks/:username for getting all tasks of a particular user when username provided as a parameter

I will work on this issue. Please assign it to me.

@swarajpure Are we good to close this?


Rails/MigrationClassName suggests identical name when number is in name

Expected behavior
When a migration name has a number in it, rubocop reports a failure and suggests the the same name.
Actual behavior
Should not be a failure to have a number in the name.
Steps to reproduce the problem

rails generate migration some_thing_4_whatever_2
rubocop db/migrate

Rubocop suggests the names that are already there:
db/migrate/20220316152916_add_whatever_4_think.rb:1:7: C: [Correctable] Rails/MigrationClassName: Replace with AddWhatever4Think that matches the file name.
class AddWhatever4Think < ActiveRecord::Migration[7.0]
      ^^^^^^^^^^^^^^^^^
db/migrate/20220316152933_add_whatever_2.rb:1:7: C: [Correctable] Rails/MigrationClassName: Replace with AddWhatever2 that matches the file name.
class AddWhatever2 < ActiveRecord::Migration[7.0]
      ^^^^^^^^^^^^
db/migrate/20220316153056_add_whatever_2_something_4.rb:1:7: C: [Correctable] Rails/MigrationClassName: Replace with AddWhatever2Something4 that matches the file name.
class AddWhatever2Something4 < ActiveRecord::Migration[7.0]
      ^^^^^^^^^^^^^^^^^^^^^^

RuboCop version
1.25.1 (using Parser <IP_ADDRESS>, rubocop-ast 1.15.2, running on ruby 3.0.2 arm64-darwin21)
  - rubocop-rails 2.14.1
  - rubocop-rspec 2.9.0

This issue is a dup with #667. Thank you for your feedback.


[Feature]: Change Currency from $ to INR or ₹

The current default currency for all products listed on the store is set to $. It may be beneficial to change this to INR or ₹ to ensure that the pricing is geographically accurate.

want both pricing or just INR? @trishanu-init

want both pricing or just INR? @trishanu-init

only INR "₹"

okayy assign it me! i can work on this issue @trishanu-init

assign it to me! i will work on it
@trishanu-init

@avayyyyyyy I am assigning this to you.Please revert back with acknowledgment.

@trishanu-init Assign it to me sir i will resolve it ASAP

@UtkarshBirla28 You have been assigned !!

@trishanu-init is this good sir ?

@or should i calculate it i mean if something is for $500 then i should calculate it by doing some calculation like 500*83.49 =41745
but 41 k is toomuch :) for a T-Shirt

@UtkarshBirla28 Please create a pull request and push a commit so that I can review the changes!!


Imports not properly formatted in generated file

I'm trying to annotate a ViewModel like this with both @KoinViewModel and @Scope
@KoinViewModel
@Scope(ExampleFragment::class)
class ExampleViewModel: ViewModel()

The project has already been using koin-android 3.1.5 successfully. I have done no other change in the code except the ones mentioned in the readme.
The imports in the resulting generated code are not properly formatted:
package org.koin.ksp.generated

import org.koin.core.KoinApplication
import org.koin.core.module.Module
import org.koin.dsl.*import org.koin.core.qualifier.StringQualifierimport org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.androidx.viewmodel.dsl.viewModel
fun KoinApplication.defaultModule() = modules(defaultModule)
val defaultModule = module {
	scope<com.example.ExampleFragment> {
			viewModel(qualifier=null) { com.example.ExampleViewModel() }
	}
}

Koin project used and used version:
koin-android version 3.2.0-beta-1
koin-annotations version 1.0.0-beta-1

@AdeelTariq How were you able to fix this issue? I'm also seeing the same thing when trying to use @KoinViewModel annotations

Using the newest version should fix it
On Sat, 23 Apr 2022, 7:20 pm joey, @.***> wrote:

@AdeelTariq https://github.com/AdeelTariq How were you able to fix this
issue? I'm also seeing the same thing when trying to use @KoinViewModel
annotations
—
Reply to this email directly, view it on GitHub
https://github.com/InsertKoinIO/koin-annotations/issues/13#issuecomment-1107500016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA52ELQK52EN7FJQXEE5SQ3VGQBMHANCNFSM5THBZBMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Odd. I'm using the latest versions of ksp(1.6.21-1.0.5), koin annotations(1.0.0-beta-2) and koin (3.2.0-beta-1) but still have the error. Could you share which versions you're using in your gradle file?


Events present in the documentation not working

cy.nodes().on("expandcollapse.afterexpand", function(event) { var node = this; ... })

won't worked while
cy.nodes().on("afterExpand", function(event) { var node = this; ... })

worked fine.
in your code you are triggering  node.trigger("afterExpand");
Please update your documentation :)
Thanks !

@abeersaqib I tested it seems that
cy.nodes().on("expandcollapse.afterexpand", function(event) { var node = this; ... })

is working.
I think that I forgot to update browserified file before releasing v3.0.0. If you are using v3.0.0 you may have this problem. However, it must be fixed in v3.0.1.
If v3.0.1 is working well for you we can close the issue.

@metincansiper we have bit modified your library since there were memory reference issues when library is used in Desktop mode instead of browser mode.
I don't know whether those changes were added in version 3.0.1 or not.


Fix phpstan build

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (726dd2b) to head (376b24c).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##                main      #242   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       648       648
===========================================
  Files             57        57
  Lines           1998      1996    -2
===========================================
- Hits            1998      1996    -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ARTEMIS-2111 ManagementContext can leak

I couldn't find a way to write a test for this so I tested manually using the forceFailover() management method on the ActiveMQServerControl.  If anybody has any clever ideas I'd love to hear them.

@franz1981, thanks for the suggestion, but I don't think this is that kind of leak.  I came up with a way to test it and updated the PR.

I have managed to reproduced this issue on VM by simply adding extra hdd, formatting it, and making Artemis to use it for bindings, journal, (etc..). Started broker, waited for all components to go up and simply deleted hdd from virt-manager.

@michalxo, in your test is it the management context that's leaking or something else?


Fixed #380 -F9 should close menu as well as open it

Fixes https://github.com/migueldeicaza/gui.cs/issues/380

Mhm, I mess this one  up

https://github.com/migueldeicaza/gui.cs/pull/391

Applied the there one


Cannot run tests

After I update to latest version, after my experiments with #445 I observe following

I can run plugin inside IDE
but I cannot run tests inside Idea.

./gradew test

produces for example
org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':detachedConfiguration12'.
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.rethrowFailure(DefaultConfiguration.java:1524)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.access$3700(DefaultConfiguration.java:159)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$DefaultResolutionHost.rethrowFailure(DefaultConfiguration.java:2174)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$ConfigurationFileCollection.visitContents(DefaultConfiguration.java:1496)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.visitContents(DefaultConfiguration.java:510)
        at org.gradle.api.internal.file.AbstractFileCollection.getFiles(AbstractFileCollection.java:129)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration_Decorated.getFiles(Unknown Source)
        at org.jetbrains.intellij.utils.DependenciesDownloader.downloadFromMultipleRepositories(DependenciesDownloader.kt:70)
        at org.jetbrains.intellij.utils.DependenciesDownloader.downloadFromRepository(DependenciesDownloader.kt:33)
        at org.jetbrains.intellij.utils.DependenciesDownloader.downloadFromRepository$default(DependenciesDownloader.kt:32)
        at org.jetbrains.intellij.dependency.IdeaDependencyManager.resolveSources(IdeaDependencyManager.kt:123)
        at org.jetbrains.intellij.dependency.IdeaDependencyManager.resolveRemote(IdeaDependencyManager.kt:363)
        at org.jetbrains.intellij.IntelliJPlugin$configureSetupDependenciesTask$1$1.call(IntelliJPlugin.kt:1524)
        at org.jetbrains.intellij.IntelliJPlugin$configureSetupDependenciesTask$1$1.call(IntelliJPlugin.kt:114)

and tests seems to be does not run. Not sure what to do.

Side node. I mostly C# developer by trade, and I would appreciate that process of running tests for Java would be documented. Probably the same for C# part, since if Java develop decides to contribute it may suffer same problem as me.

This is a recent issue, and should be fixed in either gradle-intellij or in the Rider SDK. I've reported it internally and will post a workaround if one is found before the fix.
Just a side note: the most of the tests are written in the .NET part of the plugin, and Java part contains only a few of them, mostly integration ones. For the most of the time you're probably interested in running tests in the ReSharper.FSharp solution instead.

My experiment consist of implementing custom keywords for F#, so I would like to run everything I have. Also I would be happy to know what’s canonical way to run tests, so I at least can improve docs in this area

This has been fixed.


Provide option to boot into installed image.

Once resctl-demo installation is finished, a new dialog prompt will be launched giving option to either shutdown or boot into new OS.
This facility can be used with drive that aren't detected by certain firmware, so we can use flasher image to boot from that drive.

@htejun @obbardc Pinging for review


Create JamesBrandon.toml

Description
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging to draft

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present

I hope you will add me to the pregenesis guys
https://github.com/anoma/namada-testnets/pull/527
https://github.com/anoma/namada-testnets/pull/735
https://github.com/anoma/namada-testnets/pull/942
https://github.com/anoma/namada-testnets/pull/1215
https://github.com/anoma/namada-testnets/pull/1364


[Feature]: change widget's properties from other widget's action

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
For example, I use a checkbox to control datepicker's ablility. If the checkbox is isChecked == true then i want to disable the datepicker.

I tried, but it seems dosen't work.
Why should this be worked on?
I think, it's a normal use case.

@kzerozero0 Appsmith is based on a reactive paradigm so instead of assigning this property onCheckChange, you just need to assign the disabled property of the datepicker to {{ Checkbox1.isChecked }} and this will disable it if it is checked.


update chinese translation for <IP_ADDRESS>

in case you wanna work on this upcoming file:
PathOfTheYeoman-en.txt

in case you wanna work on this upcoming file:
PathOfTheYeoman-en.txt

Subclass/&PathOfTheYeomanTitle in this text is "Path of the Savagery".Maybe it should be "Path of the yeoman" instead?


DS-3850 Create new submissions from files or identifiers

https://jira.duraspace.org/browse/DS-3850
Complete the WorkspaceItem endpoint

add findByEPerson search method
introduce pre and post functions to allow one step to react to changes done/requested to other steps/sections
implement the pre/post functions in the Describe step to support automatic enhancement of a submission looking to the uploaded files (the grobid integration will be a separate PR) or provided metadata (identifiers)
implement the creation from a bibliographic file (bibtex via BTE)

This PR has been extracted from #2102 and not really tested. IT for the enhancements will be added in the next days but I will appreciate early feedback and help from other in testing/review

My impressions of the PR are in line with Tim's review.
After a detailed review of the code in this PR, the code is looking good, but it seems that the functionality in this PR is almost entirely focussed on changes for the automatic enhancement of a submission.
The implementation strategy that was used here (this interpretation is based on the code only due to the lack of comments which were mentioned by @tdonohue ) is:

PreProcessing functions are created to initialize the listeners for automatically adding the metadata
PostProcessing functions are created to actually add the automatic metadata

But these PreProcessing and PostProcessing are embedded deeply in the submission backend, and currently don't allow any changes to trigger user interaction. A sample when uploading a file can be seen at https://github.com/DSpace/DSpace/blob/c0066d2a2fa4afacadba2bf36f20d94cd818217c/dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/WorkspaceItemRestRepository.java#L244 where the PostProcessing is not supposed to happen prior to user interaction. Similar behavior is used when editing item metadata at https://github.com/DSpace/DSpace/blob/c0066d2a2fa4afacadba2bf36f20d94cd818217c/dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/WorkspaceItemRestRepository.java#L316
As mentioned during the DSpace 7 meeting and described in DS-4002, the metadata is automatically included in the item and there's no track on the metadata being created automatically. The user just suddenly sees the metadata appear without having neither control nor explanation of the reason why the metadata was created
Can you please explain how this functionality can be altered to give the user the choice on whether the metadata is included in the item?
I don't see any issues for the findByEPerson search method.

I should have addressed all the comments above. Please note that javadoc has been added on the interfaces. Where there was not significant information to provide on the implementation classes only the class javadoc is provided as the interface javadoc is automatically inherited.
@benbosman the two different upload methods are used to bulk create submission or add file to a specific submission, a method was missing in the RestResourceController to make use of them, javadoc provided so it should be more clear now, thanks to note.
A quite large number of ITs have been provided to cover all the proper use of the endpoint, some outstanding issues have been postponed (I hope you agree) to separate tickets see
https://jira.duraspace.org/browse/DS-4042
https://jira.duraspace.org/browse/DS-4043

@abollini : I haven't done a full re-review yet, but I do see that two classes are still missing requested Javadocs: ExtractionStep and MetadataStep (which also includes a FIXME near the start of the class that says to "move to ExtractionStep").
Beyond that, glad to see the large number of new Integration Tests (increased 1.5% coverage!!!) and added javadocs.  I'll give this a closer look later today

good point @tdonohue sorry to miss that in my previous comment. As you noted the classes missing javadoc are mostly empty. The real classes are the underlying interface AbstractProcessingStep (almost unchanged from the existent code)  and the concrete implementations and new interfaces in the REST maven project org.dspace.app.rest.submit.step.ExtractMetadataStep
org.dspace.app.rest.submit.step.DescribeStep
org.dspace.app.rest.submit.UploadableStep
these have javadoc but please correct me if I'm wrong.
Please note that the step classes in the dspace-api are now mostly empty and unneeded, this was expected as these classes were put in the dspace-api to provide a common layer between JSPUI and XMLUI but now this common layer (among any future UI) is just the REST API.
This is eventually a subsequent cleanup task, do you agree?

@tdonohue I have created https://jira.duraspace.org/browse/DS-4045 to remind about the cleanup

@benbosman : do you have any objections to merging this?  It looks good to me now, and I believe @abollini has answered all the questions (via the comments above, and the various new tickets linked off of this PR).


Add check against min safe integer

Related issue https://github.com/CartoDB/carto-vl/issues/1047

This was broken, see examples/editor/index.html#eyJhIjoiU0VMRUNUICosIE5VTEw6Om51bWVyaWMgYXMgaG9sYSBGUk9NIHNwZW5kX2RhdGEiLCJiIjoiIiwiYyI6ImNhcnRvdmwiLCJkIjoiaHR0cHM6Ly97dXNlcn0uY2FydG8uY29tIiwiZSI6IndpZHRoOiA3XG5jb2xvcjogcmdiKDIwNCwwLDApIFxuZmlsdGVyOiAoaXNOYU4oJGhvbGEpKSBcbkB3YWR1czogdmlld3BvcnRGZWF0dXJlcygkaG9sYSwgJGFtb3VudCkgIiwiZiI6eyJsbmciOjIuMTY0NzE5NTI1MDcxNzQ2LCJsYXQiOjQxLjM5NzY5MTgxNDMyNzY4Nn0sImciOjEyLjM2OTIyMTY0MjU4MTYsImgiOiJEYXJrTWF0dGVyIiwiaSI6InF1ZXJ5In0=

I hope to have fixed it, but this still needs tests

I think we should do the following (apart from the existing fixes on this branch):

[ ] Support categorical properties
[ ] Rename to isNull
[ ] Add tests

I think this is ready for CR, @elenatorro if you have time it would be great if you could take a look too


Carts can phase through blocks

BkCommonLib version: 1.15.2-v3
TrainCarts version: 1.15.2-v2-SNAPSHOT
Spigot version: Paper 1.15.2 273

Problem or bug: Carts can phase through blocks, resulting in many redstone contraptions using carts to break entirely.
Expected behaviour: Carts are properly handled and do not phase through blocks.
Steps to reproduce: Place two rails with a block on either end. Slowly but surely push the cart into the block, eventually it will fall off the track and begin phasing through the block.

Please use /train version to give us the actual versions (Including build)
Also, you may check your trains behaviour by shift-left clicking it and then run /train info.
This will usually list what the train would do when colliding with entities and blocks.

My apologies, I had just used the versions from my previous bug report as I was reporting this in somewhat of a hurry. Now that I've taken care of the, erm, situation, here's the correct info:
BKCommonLib: 1.15.2-v4 Build 791
TrainCarts: 1.15.2-v1 Build 585 (however, in my other server where we were using the latest v2 snapshot, it was also an issue, though I can't get the exact build on that now since we've updated to 1.16 and temporarily removed TrainCarts)
Spigot: Paper 1.15.2 Build 283
Here's a short gif showing the issue

And here is the train info while the train is inside of a block:

I cannot really reproduce this bug despite trying it on my own 1.15 test server with the exact same settings, so it must be something on your end...
(And yes, I changed properties to also take in entities later and that didn't change anything)

Train_Carts.zip
Here are my configuration files. I wonder if it's something I've set somehow?

Related to #319, seems like it's not truly fixed completely.

Can you verify using 1.16.1-v1 for BK and TC so we know whether this is still relevant or not?

Appears to be fixed as of TrainCarts 1.16 v2 Build 698 w/ BKCommonLib 1.16 v1 Build 838, using PaperMC 1.16.1 Build 117
Further testing might need to be done on the newest v1, however.

I would say that result is recent enough to be called resolved, however, if you do find it reappearing, feel free to reopen this.

This issue is still apparently an issue as on BKCommonLib 2 build 944 and TrainCarts 2 build 749 on Paper 1.16.4 build 282. We have found that the issue is easier to reproduce if, instead of putting two rails, put one rail between two blocks. It will almost always phase through the blocks. At a terrible guess, I would assume that it is because of the custom collision physics modifying the hitbox to be bigger than a block? But that's a random guess.
I can't re-open the issue because you closed it, but I think it needs to be re-opened.

There is no BKCommonLib 2 and TrainCarts 2.
I assume you mean the latest 1.16.4 releases?
Also, could you provide steps to reproduce this and a list of all used plugins?

Steps to reproduce are provided in the original posts. The full plugin list of my production server can be found here.

Sorry for the late response, I know this has been a while, but check the latest development builds and see if it is fixed there, so I can confirm whether this is still relevant.

@bbayu123 I should be able to get to it in the next couple of days, I will report back here with the status.

Sorry for the late response, I know this has been a while, but check the latest development builds and see if it is fixed there, so I can confirm whether this is still relevant.

I had an admin look into it and it does still appear to be an issue.

Labelling issue as important since you confirmed it is still an issue, and it doesn't appear to have been fixed yet.


Alt trait for array

Currently the branch::alt() only deals with tuples with at most 21 elements(#1144, #994) , so I write this pr trying to change it.
Trait Alt has been implemented for &'a mut [P] where P: Parser as a result, but due to the limition of my ability and rust compiler, I failed to implement the trait for [P]  and P must have the same type.
For example, the code as  follows failed to be compiled:
use nom::branch::alt;
use nom::character::complete::{alpha1, digit1};
fn main() {
fn parser(input: &str) -> IResult<&str, &str> {
  alt([alpha1, digit1])(input) // using an array
};

Coverage decreased (-0.2%) to 82.52% when pulling 28265cbd80361ba057352592af52522029ce82b7 on snylonue:alt_trait_for_array into c5090ef1e2a1704851b1773169653728b0761d9c on Geal:master.

I did not implement that trait for arrays for that exact reason. Even if some parsers have the same input, output and error types, their actual type might be different due to heavy use of closures and impl trait returns

I did not implement that trait for arrays for that exact reason. Even if some parsers have the same input, output and error types, their actual type might be different due to heavy use of closures and impl trait returns

I don't think it is a good idea now

I don't think it is a good idea now

I did not implement that trait for arrays for that exact reason. Even if some parsers have the same input, output and error types, their actual type might be different due to heavy use of closures and impl trait returns

What about for parsers have no impl types and are completely identical? You are forbidding a use case just because it is uncommon. :(


Static Page doesn't pass fb opengraph validators and twitter card validators

It works with a regular post which just grab my post's cover image when I share it on facebook or twitter
but if I turn it to a static page. I got errors both from facebook debugger and twitter card validator

Warnings That Should Be Fixed
Inferred Property    The 'og:url' property should be explicitly provided, even if a value can be inferred from other tags.
Inferred Property    The 'og:title' property should be explicitly provided, even if a value can be inferred from other tags.
Inferred Property    The 'og:description' property should be explicitly provided, even if a value can be inferred from other tags.
Inferred Property    The 'og:image' property should be explicitly provided, even if a value can be inferred from other tags.

this is from the facebook debugger
and this from Twitter card validator

The card for your website will look a little something like this!
Unable to render Card preview
Log
INFO:  Page fetched successfully
INFO:  14 metatags were found
WARN:  Not whitelisted

Hi @vasinl124,
Thanks for taking the time to raise this. We are aware of the issue - it's being tracked in #6534.
Not sure anyone is working on that particular task at the moment, so it's free to pick up.


Added 'advanced example'

Hi Yoshi,
I've created an 'advanced' example for this project. If you're interested, please consider adding it :)

Thanks for the pull request.
I would like to make it a separate document from README.md and link it from README.md.
I would like to put the file in the same hierarchy as README.md.

Done, please check.

Thank you very much.
LGTM


when codeblock is breaking, eats too much space after

example :
#{
  5
}

content

becomes
#{
  5
}
 content

Replacing space with . for clarity
Spacing after codeblocks have an unwanted effect :
#{
  5
}.
.
content

becomes
#{
  5
}.
content

but
#{
  5
}.
.
content

becomes
#{
  5
}.
content

false alert, bug in my PR of typst-lsp


Bundle adjust --initial-transform

The bundle_adjust --initial-transform flag should be able to work with --input-adjustments. The logic here is that instead of starting with no adjustments, bundle_adjust can start with some initial adjustments (say from a previous run), and then on top of it apply a pc_align transform from a previous run. This makes for more versatile workflows and was suggested by a user. Should be a simple fix.

Fixed. Also added the ability to handle scale as part of --initial-transform, both pinhole cameras and for the general case when we write .adjust files.


how to upgrade umbrella-chart's dependency charts one by one

Hi Experts,
I have a problem needs your help, thanks in advance.
we want to separate  our services into into 3 umbrella charts: service-app(includes the services developed by our team, are same type: deployment ), statefulset-app(includes the statefulset services developed by our team) and infra (includes DB/kafka etc. common infrastructure sservice),  these 3 charts are just served for dependency charts upgrade, doesn't include any service itself.
when trigger a helm upgrade, all the dependency charts will be upgraded at the same time, is there a way to upgrade them one by one?
another issue found that sometimes these services' pod not recreated at all after upgrade
Output of helm version:
Client: &version.Version{SemVer:"v2.13.0-rc.2", GitCommit:"b0d4c9eb82e036c52d130fcb031e788dffe5a5dd", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.0-rc.2", GitCommit:"b0d4c9eb82e036c52d130fcb031e788dffe5a5dd", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:13:03Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:00:59Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
bare mental server installed kubernetes

The idea with an umbrella chart is to manage the entire suite of dependencies in one package. By upgrading chart dependencies individually, you break the assumption that a chart released as one version will always contain the same dependency tree.
If you want to upgrade dependencies one-by-one, then you'll need to bump them in your umbrella's requirements.yaml and cut a new release with that updated version. You can then upgrade to that new version of the umbrella chart which will upgrade its dependencies.
Alternatively, you can manage the individual dependencies with their own release process by releasing them as a separate chart.
Hope this helps.

I'm going to close this ticket due to inactivity, but please re-open if this still needs to be addressed. Thanks!


Production Release R&D (+ Document -> Page)

This is research that can span milestones as ideas are gathered for what is required for the first and subsequent production releases.
Main R&D is around the document to page refactor
Notes in the harbor.wiki

[ ] Review Mobile

Converted research into tickets for 1.0


IEEE 488.2-2004:7.7.6  indefinite format

In the specification, there is possible to have arbitrary data without definig length.
#0<UNLIMITED BINARY DATA><NL><^END>

Hi,
I am not sure this is the correct issue to comment on, a new issue might be better.
I noticed recently support for binary data transfers was added, which allows for receiving/sending data without making a copy, by providing pointers to binary data. This allows for low memory overhead in case of large data blocks. The limitation here is if data requires modifications before being sent or after being received, then a copy of the whole data block might still be needed somewhere.
For example if the data is stored in binary/raw form on the server, but the SCPI client is requesting voltages in floating point format. Then it would be an advantage to be able to construct a response in small segments of the requested block. This would reduce the memory overhead to what is required for data conversion of a small segment instead of the whole block.
A similar problem would be streaming data using SCPI (although the standard is not designed for it). For example sending an audio file to a signal generator. Where the generator would not have enough memory to handle the whole file, but would be able to process it in chunks. Another example would be an oscilloscope or logic analyzer sending a stream of samples to the client, where the size of the stream is larger then the servers memory. In the case of streaming proper backpressure is also needed, this is provided by TCP/IP or UART flow control on the lower layers and by blocking pipes in application layer.
This could be achieved by allowing the application using the SCPI parser library to parse and send data without any predefined formatting. Headers or delimiters would be handled by the application, not the parser.
Regards,
Iztok Jeras

There are more then one task resulting from your request. I just want to sumarize it if I understand it correctly - please comment, if there are some problems in following text.
In the following text ARB represents "ARBITRARY BLOCK PROGRAM DATA".
ARB is implemented only in experimental branch. Reading ARB parameter in master branch is not possible (it is not possible to do it right) because of bad design of the parser.

add output streaming function for definite or indefinite ARB. This could be implemented by 3 new functions. This is easy to implement. It is covered by IEEE 488.2-2004:8.7.9 and 8.7.10.
function to output just ARB header with 0 for indefinite format or with some nonzero number for definite format

function to output binary data until the count or until there are some data. This function can be called repeatedly.
function to finish indefinite ARB (write \n)

add input streaming function - this is hard to implement for me now
To handle definite ARB correctly, I must have full command line and input buffer must be as long as longest possible input message. There is no way for me to support input streaming now.

To handle indefinite ARB, there must be some hack to stop calling SCPI_Parse and pass all incomming data to current indefinite ARB handler.
I don't know, what is <^END> event. For me, it is just calling SCPI_Input with zero length data.

I can implement 1.i, 1.ii and 1.iii.
I would like to find some solution for 2.ii.
Solution for 2.i is not currently possible for me. In the future, after stabilising "experimental" branch, I will look in the way, how to solve this.
I need some advice for 2.iii.

Hi,
I was already looking at the experimental branch, I noticed some ARB code was there, but is still required a pointer to a buffer for an entire transfer. And there are other features in experimental I am interested in.
It took me some time to get hold of the IEEE standards. For now I will only read the strictly related sections.
Comments:
1.i. - A function which outputs an ARB header is what I expected. I do not mind if this function is also able to create other header types, so could be used to create non ARB responses (if there are any non ARB responses with a header).
1.ii. - I might be missing something but I do not think there are other options to detect end of data then count. Otherwise yes, this is what we need.
1.iii. - This one is not clear to me. '\n' is only part of the  the second one is '^END', which is handled by a control channel not the main data channel. So only interfaces with a separate control channel can handle it. For example this is defined for GPIB, and it should be possible to implement over USB, but probably not using UART/RS232 or TCP/IP sockets over Ethernet. So availability of indefinite ARB depends on the underlying transfer interface.
2.i. - So as you describe it, currently definite ARB can not be processed in chunks, instead data is provided as a pointer with all data already loaded. What if instead of providing a memory pointer a file pointer for the pipe (UART tty*, TCP/IP, socket, ...) would be provided. The parser would still handle the header, but not the data. I do not know the architecture of the parser enough to know if this can be done. On the other hand, in most cases it makes sense for the parser to handle the pipe and return a memory pointer, so a method for choosing between memory and pipe handlers should be available.
2.ii,iii. - Again only some protocols would be able to provide <^END>, this would probably be handled as some kind of interrupt to the OS. I do not know enough here to comment.
Regarding what is <^END> and how to handle it, It is part of the IEEE 488.1 (GPIB http://en.wikipedia.org/wiki/IEEE-488 maybe pin 5 'EOI') standard. I made a quick search for GPIB Linux drivers but did not find anything obvious, probably the proper search phrase changes between standards and implementations. I would tentatively suggest not implementing indefinite transfers for now.
Regards,
Iztok Jeras

Another idea how to find out about <^END>, you could post a question to http://sigrok.org/ developers on their mailing list https://lists.sourceforge.net/lists/listinfo/sigrok-devel
Their focus is on the client side, but they also have experience with USB and firmware on the instrument side.
Or maybe developers of other GPIB, VISA, SCPI, ... client libraries could help.

Thank you very much for important informations.
For now, I can implement output streaming of definite ARB.
I forget, that it is possible to generate <^END> on controll channel on TCP. I have already an example with control channel, so maybe, this could be also a way.
My technique of parsing is to read message until the terminal character. After that, I call command callback and allow parameters parsing.
I can create new type of parser, that can read just command header and after that call callback. In this type of parser, streaming is possible, but it is not easy to implement it for me. Reason is, that direct reading of  input data is not allways available.

I hope I'm not hijacking this issue, but I think my problem is covered in your discussion. I am currently working on a system with limited memory where I would like to be able to fill up most of the RAM with binary data send with the ARB command. As far as I understand the library by now it always needs to have the whole data block in memory for parsing, which requires as much parser buffer as data storage buffer.
I see two ways to solve that. Either a function for the arbitrary data which doesn't require the whole data to be available from the beginning and can be called repeatedly to get the remaining data. Or a function which just parses the header and returns the length and the current parser positions. Then one could hack something around which would copy the incoming ARB data and then calls SCPI_Parse again.
Could you implement something like that or give me a hint on how to implement that myself?

You are right. You need full buffer in the memory for parsing.
If you are using some processor like AVR with dedicated RAM and program space, you can save some RAM by moving constant definitions to program memory. Take inspiration in avr_progmem branch from Martin Vladic. 16bit+ processors are not affected by this issue.
Your proposed solutions are right but they are not so easy to implement as they sounds.
Straightforward solution is possible in multitasking environment, where we can wait for parameter in the command callback function - so just parse the command header and directly call the callback which will wait for parameters and which will handle them part by part.
Implementing this approach as state automaton or protothread will lead in very complicated solution and completely new way, how to define command callbacks.
So the hack. You can somehow tell the parser, that some commands will be processed differently (eg. by tag value). There is point after calling findCommandHeader, where the current command header is known. You must also exchange scpiParser_detectProgramMessageUnit in SCPI_Parse and SCPI_Input by some other function detecting only program header using scpiLex_ProgramHeader. You can hijack the program flow, process command and parameters by yourself and return to parser.
This is something that I don't want to do.
I don't know other solution so this is the reason why it is not part of current version.
If you come with better solution, I will be happy to incorporate it.

I've now managed to build a version with just minimal changes to the library. I disabled the range check in scpiLex_ArbitraryBlockProgramData which gives me the parsed length and a pointer to the beginning of the data even if the data is not existent yet. With that information I read the remaining data outside of the library and call SCPI_Parse again on the next chunk of data.
The only way I can think of a proper solution would be to change the parser in a way that it doesn't get a complete buffer, but instead a function which it can use to request more data. Then one could split the SCPI_ParamArbitraryBlock into one header function and one body function. The header function returns the length and the body function expects a buffer of that size as a parameter in which it memcpys the incoming data.

Nice hack and this is the reason why the parser is open-source.
Your hack will work only if the ARB parameter is the last. If you can somehow detect <^END> of command, you can easily handle also ARB indefinite format. Anyway, this is not the type of hack I would like to incorporate to current sources. :-(


Update default page transition to Android 10 transition

Description
As new OEM behaviors are created, we should be staying up to date. This PR introduces a breaking change that sets the default MaterialPageRoute transition to the Android 10 transition.

To keep previous behavior, one would need to modify the PageTransitionsTheme in their MaterialApp theme as follows:
      theme: ThemeData(
        pageTransitionsTheme: PageTransitionsTheme(
          builders: {
            TargetPlatform.android: FadeUpwardsPageTransitionsBuilder(),
          },
        ),
        // rest of theme
      ),

Related Issues
Fixes https://github.com/flutter/flutter/issues/43277
Tests
I added the following tests:

Updated previous tests to check if the default MaterialPageRoute uses the ZoomPageTransitionsBuilder

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

The change is breaking some tests, such as:

"Destination hero scrolls mid-flight" in heroes.dart, which scrolls mid-flight. since the new transition involves a scaling transition, I assume that this drag ends up scrolling/dragging the hero more or less than expected.
"selection handles are rendered and not faded away", which takes into account that a single FadeTransition exists in a MaterialApp, which existed because of the previous transition.

I will need to spend some time fixing up these issues and making sure we're not breaking more than meets the eye before proceeding with this change.

Also fixes https://github.com/flutter/flutter/issues/34675

I'm closing this for now since I have not had the bandwidth to make this happen. I'll re-open this when I have the opportunity to revisit this change.

Hi @shihaohong, do you know if the tests this was breaking are still an issue? (the PR is closed so there aren't any Cirrus logs)

@Zazo032 I made an effort to fix the tests within the framework (https://github.com/flutter/flutter/pull/51150). However, this might still need to go through the standard breaking change process (checking to see if it breaks customer tests, internal tests, and sending an email out to make sure there isn't any issues we're missing out on).

Closing in favor of https://github.com/flutter/flutter/pull/51538 since the presubmits seem to keep failing. It's likely due to the PR being this old


proxy / vps list tor usage for c2 servers

is it possible to use proxys or vps  from lists or use tor for c2 communication to bots

It is possible to use proxies for the C2 , but its gonna be hard , as the whole terylene infrastructure relies on zeromq communication. Its not really easy to just forward zmq packets using normal TCP proxies, since zeromq sockets are heavily optimized version of TCP and tricky to work with (https://rfc.zeromq.org/spec/23/). I would hopefully add a zmq proxy in the future , to protect the C2 ip. However, this whole infrastructure is decentralized, so i wont see the big use of that.

No response, closing the issue


Create cloud-provider-cloud-director app

Create the app to install the CSI and the CPI in CAPVCD clusters.
https://github.com/giantswarm/cloud-provider-cloud-director-app

The Helm chart works.
At the moment the CSI and CPI are installed in the cloud-init script.
-> To check when working on CAPVCD

released as v0.1.0, requires work as detailed above but this is done for the initial implementation.


Filter out 0-length tokens when generating syntax model nodes

swift::tokenize() with TokenizeInterpolatedString set to true produces an empty string literal token between directly adjacent interpolations, e.g. in "\(1)\(1)". The syntax model relies upon it to determine whether the next left paren is a string interpolation anchor or not, but there is no need to to include a corresponding empty SyntaxNode in the syntax model. 0-length syntax nodes don't really make sense and may break assumptions in client SyntaxModelWalkers.

Resolves rdar://problem/33601932.

@swift-ci Please smoke test


chore: add script to auto update unicode-alias

This PR adds a script to automatically update unicode-alias.
I also added a GitHub Action to periodically check for updates.

You can use action to create PR https://github.com/sindresorhus/get-east-asian-width/blob/61a40a00326ec6924a143d0fd0a01f3618714115/.github/workflows/update.yml#L18

Very interesting! Can I see PRs created using that peter-evans/create-pull-request?
It looked like that repository didn't have it yet.
https://github.com/sindresorhus/get-east-asian-width/pulls?q=is%3Apr+is%3Aclosed

The data has not been updated yet.. See another repo  https://github.com/sindresorhus/globals/pull/245

@fisker Thank you! I opened a PR to use it.


Please help: Unknown column 'NaN' in 'field list'".

CODE: https://pastebin.com/EuTd0n5S
ERROR: https://pastebin.com/ncE6H26k
Thanks for helping!

The error is because in a query you are sending to the server contains a field name of NaN, which is not a field in the table you are querying against. I'm sure you don't mean to use a column name of NaN, so likely one of the variables you are building your SQL with is NaN. If you add debug: true to your createPool function, re-run and post the output, we can identify what query is being built wrong.

Lol, you helped me a lot, dude.
With debug true I could see what column was NaN.
2 columns were NaN because I tried to column1++; and column2++;, but the variables were:
var column1; and var column2; that's why, and I switched to var column1 = 0; and var column2 = 0;, and now it's working. Thanks!

No problem! Glad yo got it working :)

Maybe the generated query string contains NaN for a column value (not column name).  this also throw error:Unknown column 'NaN' in 'field list'"


Crafting Grid Duplication

Issue description:
The newest version seems to have a weird duplication glitch where when you are crafting and you run out of something, the crafting grid magically makes more. Seen here when trying to craft seeds from Mystical Agriculture, but I have seen it with other mods/items too...
https://youtu.be/O-r4xGaOJyQ
This does NOT happen all the time though... I have had it happen with Mystical Agriculture recipes, Actually Additions recipes, and once while making vanilla iron pickaxes, but it is infrequent.
What happens:
Crafting Grid makes additional ingredients for recipes when you run out.
What you expected to happen:
You can't craft any more when you are missing ingredients.
Steps to reproduce:
Unsure... It only happens occasionally. See video above.
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12
Forge: 1.12-<IP_ADDRESS>3
Refined Storage: 1.5.17

Does this issue occur on a server? [yes/no]
Haven't tried, I don't have a server.

Might be a crossmod issue... (like MouseTweaks or InvTweaks messing up the inventory)

That could be. I do have Inventory Tweaks. Do you want a list of all the mods I'm using?

Wouldn't be of much use, that would be like finding a needle in a haystack.

I'm having this kind of item duplication simply by pulling all the items out from a external storage connected drawer controller with compacting drawer attached.
This happens a lot when multiple empty not-locked compacting drawers are attached to a drawer controller.
But not all the times.

Sorry for those long images.
Through some basic testing.
This can be done intentionally.

setup a controller with a grid.
connect a external storage to a drawer controller with a compacting drawer attached.
place 1 iron ingot into the system, which will go into the compacting drawer.
pull the iron ingot out, will result in 127 iron ingots.

I'm not even sure if this is an RS issue, RS just calls the SD API method:
https://github.com/raoulvdberge/refinedstorage/blob/mc1.12/src/main/java/com/raoulvdberge/refinedstorage/integration/storagedrawers/StorageItemItemRepository.java#L58-L68

I just tried AE2 with the exact setup, it doesn't duped items but items were disappearing.
Like RS, when the compacting drawer is locked, everything works fine.
Looks like this is SD's issue.

It was an SD problem, and it's fixed in 5.3.1.  Thanks for reporting.

Nice, closing this as it is fixed of SD's side.


Add support for new configration interface to AuthenticaionTls

Motivation
AuthenticationTls only supports the old configure interface but we should the new one as preparation for 2.0
Modifications

Adds EncodedAuthenticationParameterSupport interface to
AuthenticationTls and AuthenticationDisabled.
Mark some methods deprecated as preparation for 2.0

Result
Authentication plugins are ready for 2.0.

retest this please

Reverted the Map interface for auth factory and admin client.

retest this please

@maskit It appears there's a genuine test failure:
https://builds.apache.org/job/pulsar-pull-request/1506/

AuthenticationTls used wrong config parser (JSON). It should be fixed.


Route 53 Compliance Review

Describe the issue
We want to do a security review for Route 53 on AWS. Route 53 is AWS' domain name and routing service.
Additional context

This one is tricky because it handles DNS which is pretty core to government.
There is likely reusable Security and Privacy compliance already done on this available from Mark from the GDX Analytics team (see CRM app for details)

Definition of done

Get prior compliance work from Mark
Route53 Compliance work is complete

no longer relevant


Need help calculating task overall metric scores

Hi scib team,
I'm recently working on new integration methods and have been using scib to evaluate the outcomes. Thanks for the well packaged tool!
One problem I just encountered is that I couldn't reproduce the overall scores from the published scores of the tasks in the scib paper. I tried it with the sheet for human immune task from supplementary file 1. So if I take the five batch removal scores from the second row (the first task), I couldn't reproduce the same number for the overall batch correction score, with the method mentioned in the Method section of the paper (average of min-max scaled scores). Can you please clarify the calculation of this part so that I can have overall scores calculated for my integration methods and know how they ranks with existing methods you've evaluated?
Thanks!
Yichen

Oh I got it now after one night sleep. For one task (e.g. human immune), you put all scores of all integration in a table. Then by min-max scaling you actually did it column-wise with NAs ignored. And finally the min was taken for each integration run each category (i.e. bio/batch).


How to track stateful methods

I have built a service fabric application with stateless and stateful service. I want to do profiling API and stateful service methods. How can we track stateful service methods profiling?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96e73b70-d4f7-2525-3500-33d0e498b93e
Version Independent ID: b906b85a-67cd-37e0-3a11-461f446def26
Content: Write code to track requests with Azure Application Insights
Content Source: articles/azure-monitor/app/profiler-trackrequests.md
Service: application-insights
GitHub Login: @cweining
Microsoft Alias: cweining

@balukantu Thank you for your question, will get back to you shortly on this.

@balukantu
In order to profile requests in ServiceFabric services, you need to do two things:

Wrap the code that you want to profile in a StartOperation using statement as shown in this article.
Install the profiler in your ServiceFabric cluster as described in this article: https://docs.microsoft.com/en-us/azure/azure-monitor/app/profiler-servicefabric

Once you have done that, you should be able to see your operations in the Application Insights Performance page. After the profiler has had a chance to run, profiler traces will be available from the Performance page also.
If you are still have trouble, please check our troubleshooting page: https://docs.microsoft.com/en-us/azure/azure-monitor/app/profiler-troubleshooting
Please let us know if there are more questions we can answer.

Thank you @cweining for your response.
@balukantu Hope the above information helps you. Will go ahead and close the issue for now, however if you have any further queries please feel free to tag us in your reply and will be more than happy to take the conversation forward. Thanks


[FEATURE (Dependency)] Upgrade client to newest version

Upgrade the client to the latest version of the BTP CLI, redo the testing and check the compatibility

New Version is 2.48.0

[ ] Analysis of delta between 2.38 and 2.49
[ ] Decision how to handle delta
[ ] Re-record test fixtures

Delta of new btp CLI version:
Role Collection assignment
The parameter -create-user-if-missing  is optional and defaulted to true.
We have set the value to TRUE in  facade_security_role_collection.go. Due to backwards compatibility no changes needed. Making this setting explicit in the code helps us when analyzing issues
No change needed in provider
New parameter in btp set config
It is possible to configure a default behavior of the btp login command. e.g. making single sign-on through a browser default  via btp set config –login.sso browser.
No change needed in provider
Display and update the security settings for global account or subaccount
The management of the security settings is now possible via the BTP CLI as described here
The addition of this functionality to the provider is tracked via issue #399 and not seen as essential for the GA version of the provider.
Created dedicated issue

Waiting for open PRs around fixes and new entities to be merged to re-record the test fixtures in one run and have a consistent base


Montior network activity

I am trying to get the cookies the browser sends in a post request

see the docs at https://playwright.dev/dotnet/docs/network#network-events specifically the Page.Request event (here https://playwright.dev/dotnet/docs/api/class-page#page-event-request)


Allow export template to skip adding the root path

This PR will add a new skip_root_path property to sources that are defined under outputs of export templates. This will allow data modelers to include other paths unrelated to the current table/row.
For example, you can dump all the vocabularies in your deployment alongside the data of the current table. Or you could even store the schema document alongside the data.
P.S. We always add a ?limit=none to the end of query paths. We need to discuss whether we should continue to do so or skip doing that when this flag is set. We could add another flag for this.

We decided to improve the code related to the limit=none I mentioned in the description.

Instead of blindly adding ?limit=none, the code will check for ? in the path and use &limit=none instead.
We will add the limit=none query parameter only if all the following are met:

The used API is entity, attribute, attributegroup, or aggregate (by checking the start of the computed query_path. so it handles defining api explicitly, or having the api as part of path).
limit query param is not already part of the path (by doing a reg exp test).
skip_limit is not set to true (a new property that we've added to source).


Selectively run CI environments outside Bors

Motivation
CI is currently slow, both in providing feedback on PRs, and in clearing through
Bors requests.
The issues compound when a PR branch is updated, causing a flurry of jobs to be
executed, right before Bors is instructed to merge, as both are competing for
jobs to be scheduled, under a shared concurrency limit.
Main changes

Skip “expensive” environments (FreeBSD, macOS) on immediate PR feedback.
They still run under Bors, enforving tests pass there, but we avoid consuming
scarce, free CI time.

Use PPB's compute credits for test tasks Bors is waiting on.

We've also been discussing just getting our own mac, so we have guaranteed CI capacity there.

We've also been discussing just getting our own mac, so we have guaranteed CI capacity there.

That seems orthogonal to what this PR does?  Even assuming the macOS CI jobs are immediately scheduled, they take several minutes more than the Linux and Windows jobs.
Moreover, we have multiple macOS jobs, so they'd probably have to execute sequentially, even assuming no other PR is submitted concurrently.

bors r+

@AstraLuma Looks like Cirrus must be using a custom YAML parser that recognises true but not yes  >___>'

bors retry

Not exactly
https://cirrus-ci.com/build/6237841507221504

Not exactly
https://cirrus-ci.com/build/6237841507221504

Ayup, but previously the thing didn't even go that far (on this PR) only got an error message about failing to evaluate the config  :3
Please keep us posted if/when Cirrus' support replies though  <3

We got an update this morning: Apparently blocking application builds is a security thing and they'll lift the restriction once they fix the whole thing.


Error calling function when saving to variable

I am trying to do this:
var randomBool = require('chance')().bool;
// ...
var bool = randomBool();
But I get the error:
Uncaught TypeError: this.random is not a function
    at Chance.bool (...\node_modules\chance\chance.js:146:21)
If I do like this, then everything works fine:
var bool = require('chance')().bool()
What is the reason?

I found that this happens even with the built-in modules of node.js. this in this case is not what it should be.
It’s better to do this:
var chance = require('chance')();
var bool = chance.bool();

Sorry for disturbing.


Data-oriented Construction System

It's new, it's powerful and it's data-oriented!
Fixes #2155, fixes #1977, fixes #1569, fixes #1372, fixes #1371, fixes #917, fixes #672
Requires https://github.com/space-wizards/RobustToolbox/pull/1304
This construction system relies on graphs and allows for complex construction steps to be defined entirely in YAML. Refer to the HackMD document for information on the specifications (might not be up to date, ping me about it)
Future PRs:

Make material system less shit
Make construction graphs use the material system instead of stacks.

TODO:

[x] Reinstate item construction
[x] New construction UI!
[ ] Fix recycler I'll open an issue, sorry :pray:
[x] Port all some recipes to use this new system
[ ] Fake walls another PR maybe
[x] Plasteel
[x] Actually allow changing sprite state from step to step/node to node
[x] Events for when entities go from one construction node to another.
[x] Component that works like BreakableComponent but it forces a node change (for computer/wall destruction, etc)
[x] COMPUTERS

Ready for review.


Challenge http://www.freecodecamp.com/challenges/waypoint-uncomment-html has an issue

Deleting the  uncomments the HTML code (and gives context highlighting in the text editor) but does not show on the preview, or allow the code to pass the requirements.
Found a workaround of deleting and retyping a part of the code (even one character will suffice).
Using Chrome 42.0.2311.152 on Linux Mint 17.1.

I can't produce this, can you attach a screenshot?

tis complete broken in chrome
i think its the asserts have an extra parenthesis

It's the same in the 'fill in with lorem ipsum placeholder' a few challenges on: copy in the new text, and it doesn't refresh. Delete and retype a bit of the HTML tags, and it'll refresh.


[BUG] ProfileParameterValidator handles nullable types incorrectly

Expected Behavior
Validation of id string should pass when value of id is null
Current Behavior
It fails because validator expects string, but null is an object

Fixed by #87


Update the curl dependency: 8.6.0 -> 8.11.0.

Due to multiple security vulnerabilities CVE-2024-2004, CVE-2024-2379, CVE-2024-2398, CVE-2024-2466, CVE-2024-6197, CVE-2024-7264, CVE-2024-8096 and CVE-2024-9681

Closed PR: https://github.com/tensorflow/tensorflow/pull/79897, created this new PR with master as base as requested

@mihaimaruseac could you tell me why the feedback/copybara check failed? It seems to point to a non public domain, so I am not able to see what is the current problem is

I think there is an error on XLA ARM builds: https://btx.cloud.google.com/invocations/05f8db5c-2420-41ad-bd86-11f2ec4ef231
In general, the process is described in https://github.com/tensorflow/tensorflow/blob/master/CONTRIBUTING.md but I think that needs to be updated now that XLA and TFLite and so on have been split to their own repos.

ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: missing input file '@curl//:lib/curl_sha512_256.h'
ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: missing input file '@curl//:lib/cw-out.h'
ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: missing input file '@curl//:lib/request.h'
ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: missing input file '@curl//:lib/vssh/curl_path.h'
ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: missing input file '@curl//:lib/vtls/cipher_suite.h'
ERROR: /root/.cache/bazel/_bazel_root/fe5629ecf2d7463ba41a493eca1bfee8/external/curl/BUILD.bazel:26:11: Middleman _middlemen/@curl_S_S_Ccurl-cc_library-compile failed: 5 input file(s) do not exist

@mihaimaruseac Thanks for supplying these details, that clarifies what is going wrong. There are currently 4 TLS tests that fail. All of them seem to use libcurl. The current TLS codebase does seem to use the same old vulnerable Curl version (i.e. https://github.com/google/tsl/blob/d08db918df887dd9ed17ad35fe59063f1df4889e/workspace2.bzl#L329). The fix will most likely be that the Curl version for TLS also needs to be upgraded. I am willing to create a PR for TLS as well, but unfortunately (because of the current restructuring) PR's are not accepted for TLS. Tensorflow itself also no longer seems to contain TLS, so I am currently stuck in this catch 22. The fix for TLS will be very similar as this PR, so could you please advice how I can move forward with this one?

@MichaelHudgins @jakeharmon8 Is the only way to fix TSL to import this and then patch the imported change? Can you advise here?
(I think I saw another PR that landed and then had to be reverted because the TSL parts were not changed)

@MichaelHudgins @jakeharmon8 Is the only way to fix TSL to import this and then patch the imported change? Can you advise here?

That is my understanding of the current state, there is work going on to make this properly updatable from XLA but right now patching the import is the easiest way.

Cherry-picking in https://github.com/tensorflow/tensorflow/pull/80068


Severe performance regression

As expected, the latest changes from https://github.com/direct-connect/go-dc/pull/8 lead to severe performance regression:
benchmark             old ns/op     new ns/op     delta
BenchmarkReader-4     13904844      93300098      +570.99%

benchmark             old allocs     new allocs     delta
BenchmarkReader-4     6              7              +16.67%

benchmark             old bytes     new bytes     delta
BenchmarkReader-4     4950          35372         +614.59%

So it's ~6 times slower and allocates ~6 times more.
It should be fixed before we tag a new version.
CC @gswly
(updated to use the same max message size as before)

Sorry about that, but zlib support had to be added in order to create a common library.
A solution consists in taking the previous code and use it to create a "fast" buffered reader, then replace bufio.Reader with this fast reader and see if this improves things.
Unfortunately i have a high-priority work to finish, but if you share the source of the benchmark i'd be happy to work on in when i have spare moment again.

No worries, I will try to fix it today.


Refresh email list on load buffer

When we read a new email, then come back to the listing, the email is still seeing as new.

Using events like BufEnter or BufWinEnter was too heavy. So I decided to make the list buffer not persistent (hidden mode disabled). This way, we just need to recall the command :Himalaya to get a fresh updated list without polluting the buffer list.


Can I run scrcpy on aarch64

Hi there,
I would like to run scrcpy on aarch64 for Linux. I can not use apt-get install command. How can I do that?
Thank you in advance

Install it manually: https://github.com/Genymobile/scrcpy/blob/master/BUILD.md#simple

Thank you for your response.
The apt install command is not available on the system I am using, so I cannot install required packages such as libavformat. What can I do about these packages?

If they're not available, you must compile them from sources.

Firstly, thank you for your patience
I would like to run scrcpy on aarch64 and for this, I generated a Makefile using CMake but I got some error.
Also, I tried manually installation but I could not compile all packages from sources.
What is the best way to do this? Can you suggest me a solution?

I have never done this, but if you want to run on aarch64, then you need all the code (dependencies included) compiles for aarch64. If the dependencies are not packaged, then you have to compile them.

I tried it on Ubuntu 22.04 in a terminal. I did not really install it as I already have it on macOS, but it should work.
sudo apt install scrcpy
[sudo] password for klaas:
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  adb android-libadb android-libbase android-libboringssl android-libcrypto-utils android-libcutils android-liblog
  android-sdk-platform-tools-common scrcpy-server
The following NEW packages will be installed:
  adb android-libadb android-libbase android-libboringssl android-libcrypto-utils android-libcutils android-liblog
  android-sdk-platform-tools-common scrcpy scrcpy-server
0 upgraded, 10 newly installed, 0 to remove and 14 not upgraded.
Need to get 987 kB of archives.
After this operation, 2,925 kB of additional disk space will be used.
Do you want to continue? [Y/n]


When i use android sdk then get error in code which from documentation

Describe the bug
A clear and concise description of what the bug is.
When i add below line in my android kotlin project
 val output = AnySigner.sign(signerInput, CoinType.ETHEREUM, Ethereum.SigningOutput.parser())         println("Signed transaction: \n${signerOutput.encoded.toByteArray().toHexString()}")
then i get this error:

ype mismatch: inferred type is wallet.core.jni.proto.Ethereum.SigningInput! but wallet.core.jni.proto.Any.SigningInput! was expected

Too many arguments for public open fun sign(p0: Any.SigningInput!): Any.SigningOutput! defined in wallet.core.jni.AnySigner

Unresolved reference: encoded

To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

The document is a bit outdated, will update it soon, please check latest tests under android folder