feature request pipeline to fetch upload data to hugging face

Description
add CRUD of hugging face's datasets/records
Motivation and Context
close #1213

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of example)

Implemented Tasks

[ ] Subtask 1
[ ] Subtask 2
[ ] Subtask 3

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide. (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly. (required for a bug fix or a new feature)
[ ] I have updated the documentation accordingly.

Can we support picture-type data and examples？

https://huggingface.co/docs/hub/datasets-adding

Thanks @koch3092 ! Added one commit here 9f82a29 to simplify the code structure and did some update based on comment below, feel free to review the change and merge this if there's no question

Thanks @Wendong-Fan , It looks good to me.


[BUG][WEBJS] -get chats error

/api/session_9p7hs/chats?limit=10&offset=0
{
"statusCode": 500,
"timestamp": "2024-07-18T10:15:03.417Z",
"exception": {
"stack": "Error: Evaluation failed: TypeError: Cannot read properties of undefined (reading 'getChats')\n    at pptr://puppeteer_evaluation_script:2:38\n    at ExecutionContext._ExecutionContext_evaluate (/app/node_modules/whatsapp-web.js/node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:229:15)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ExecutionContext.evaluate (/app/node_modules/whatsapp-web.js/node_modules/puppeteer-core/lib/cjs/puppeteer/common/ExecutionContext.js:107:16)\n    at async WebjsClient.getChats2 (/app/dist/core/engines/webjs/WebjsClient.js:19:23)\n    at async WebjsClient.getChats (/app/dist/core/engines/webjs/WebjsClient.js:16:16)",
"message": "Evaluation failed: TypeError: Cannot read properties of undefined (reading 'getChats')\n    at pptr://puppeteer_evaluation_script:2:38",
"name": "Error"
},
"request": {
"path": "/api/session_9p7hs/chats?limit=10&offset=0",
"method": "GET",
"body": {},
"query": {
"limit": "10",
"offset": "0"
}
},
"version": {
"version": "2024.7.4",
"engine": "WEBJS",
"tier": "PLUS",
"browser": "/usr/bin/chromium"
}
}

I'm using the PLUS version, but I can't log in to the email, I only have the docker key

hi! What is the status of the session? Could you stop it and start it again? If it doesn't help - /logout and scan QR one more time

Could be related to https://github.com/devlikeapro/waha/issues/444

After pulling the 2024.7.6 version, deleting sessions and creating sessions will be fine


System.Random is not cryptographically safe to use!

System.Random must be avoided anywhere that requires a secure random number generator, this class is not designed for that purpose. If you don't want to deal with RNGs at this point then at least use System.Security.Cryptography.RNGCryptoServiceProvider instead.
You also should try to avoid using RNGs altogether in places such as this, instead use deterministic methods such as RFC6979.

Thanks for your message, we are aware of it, it is on our internal TODO list, I'll do a commit soon to use the RNGCryptoServiceProvider


Impossible to enable Access-Control-Allow-Origin with parameter (or other response header params)

header parameters set in emitResponse function (src\Server\Helper.php) are hardcoded and is not possible to add some new params.  In order to enable Access-Control-Allow-Origin, I've added a new row in the function but could be very helpful if they can be passed as parameters to the method.

It is quite easy to compose the methods in StandardServer and Helper for more advanced use cases. Enhancing emitResponse in that way would complicate the simple methods in there unnecessarily.


This does not appear to be a dataframe

I have just completed the install of ikuyadeu.r including radian etc as directed. I'm running vscode on Mojave 10.14.6 and have installed the grapecity.gc-excelviewer extension. However, I cannot view a dataframe. I am trying to view the "cars" dataframe but get an error in the bottom right saying that "This does not appear to be a dataframe". Any help would be appreciated, thanks!
Originally posted by @tbkw in https://github.com/Ikuyadeu/vscode-R/issues/96#issuecomment-671453426

Hi @tbkw, when you are trying to view the cars dataframe, what text are you selecting? Or, if you aren’t selecting any text, what word is the cursor over?
That error happens if the extension thinks that the selected text or the word the cursor is on couldn’t correspond to an R variable name (e.g., because it contains a space).

Hi @andycraig, I have tried selecting the entire variable in the text editor or in the terminal and get the same effect. "This does not appear to be a dataframe". The same effect also occurs if I place the cursor in the middle of the word without selecting it, right click, click command palette and then try to preview dataframe. Interestingly, preview environment works and produces a tab showing that the dataframe I am attempting to preview is a variable in my environment.

Hi @tbkw, thank you for the additional details. What you’re describing should work, so it may be that this command has broken. I will look into it.

After playing around I've found that I can get the dataframes to display but only if the variable name is a single letter. E.g. if I assign iris to the variable "a", I can the get it to display by either placing the cursor at the beginning of the variable or selecting the letter then going to command palette to view. This brings up the preview as expected. However, assigning the same dataframe even to a variable "aa" will now produce the same error as before: "This does not appear to be a dataframe" whether I put the cursor at the beginning or select the entire "aa". Hope this information helps and I am not doing something to cause such an odd error.

Wow, that’s very strange! Thank you for that additional info, it definitely helps.

I have replicated this.
Problem is that I changed getWordOrSelection from returning an array of strings to returning a string, but didn't update its use in previewDataframe here: https://github.com/Ikuyadeu/vscode-R/blob/c9070661b1ee7a9bb79095ccea7c176f6c059725/src/preview.ts#L33

Hi, when will this fix be released in a new version?


Add prefix to SVG id/class attributes

Currently the svg minifier (make svg) rewrites all id and class attributes in svg files. Every file gets the ids a, b, .... If multiple svgs with ids are used on a page these ids are conflicting and the results are broken images.

minified ids
unique ids

This PR adds a prefix (the filename) to every id/class.
Follow up problem: Because we embed svg images there are duplicated ids if one svg image is used multiple times on a page. As those ids refer to the same content it may be no real problem because browser handle that fine.

How about removing id and class attributes instead? The inlineStyles rule is enabled so there shouldn't be an issue with stuff like embedded CSS that targets these ids/classes.

Is it possible to inline a linearGradient element as in the GitHub image?

Should be possible using a datauri, but if svgo can not do it, I guess it's not worth it and your solution is better.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@e14b52e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #16997   +/-   ##
=======================================
  Coverage        ?   45.14%
=======================================
  Files           ?      765
  Lines           ?    86300
  Branches        ?        0
=======================================
  Hits            ?    38964
  Misses          ?    41027
  Partials        ?     6309

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14b52e...edc179d. Read the comment docs.

I think this needs a backport


Add support for specifying User-Agent in CLI

Hey there, thank you for the PR.
Would it not work to just add the user agent to conf.py?

Hi @dolevf , thank you for this tool. It runs very smooth. I'll test it more extensively and can contribute more in future.
You are right, conf.py works but it is not very automation friendly. I randomize user agents, and reading a python file, parsing it, rewriting it each time I want to change user agent is painful. I also plan to run your tool on thousands of web pages massively in parallel, when it comes to parallel execution configuration through file gets even harder requiring heavy complex logic. Most of mature recon tools (if not all) have --user-agent option for quickly configuring this when calling CLI, or allows overrides header as CLI parameter. This helps with automation, parallelism and enables easier consumption for other use cases.

Very fair point, thanks for contributing.


v7: schema compilation is safer but significantly slower than v6 - using standalone validation code

In Serverless Framework we've just upgrade AJV from v6 to v7, and observed that ajv.compile(schema) execution time for very same schema jumped from ca 0.15s to 0.8s.
Is this a known issue?
It can be observed by running any Serverless Framework command, and measuring execution time at this line:
https://github.com/serverless/serverless/blob/bcbbd47fa09b7d99d7f8da3f11150215d1203bba/lib/classes/ConfigSchemaHandler/index.js#L106
What version of Ajv are you using? Does the issue happen if you use the latest version?
v7.0.3
Ajv options object

{ allErrors: true, coerceTypes: 'array', verbose: true, strict: false }

JSON Schema

It's a large dynamically generated schema, if needed I can export it to JSON and provide a link
Your code

const Ajv = require('ajv').default;
const ajv = new Ajv({ allErrors: true, coerceTypes: 'array', verbose: true, strict: false });
ajv.compile(schema);

v7 has the same (or, in many cases, more effective) generated validation code, but the code to generate this code is definitely substantially slower - the decision is to optimise for the safety of the code generation against injection via untrusted schemas, for maintainability of the code and for the reduced size of the bundle, at the cost of slower schema compilation.
In most cases, when you compile schema once and then use it many times in server side environment, the time it takes to compile is not important, it usually happens at application start-up. If it compiles on demand, or - what would be much worse - on every API call, it has to be changed - the only reason to compile schema to code is to compile once and execute many times.
You can reduce the schema compilation time by turning off optimization (it would reduce time by about 30% I think), but even 0.15 sec per validation (if it was the case with v6) is very slow - validation itself is much faster than compilation. The solution could be to compile schemas once, and save standalone validation code (either during the build or into the database, alongside the schema).

v7 has the same (or, in many cases, more effective) generated validation code, but the code to generate this code is definitely substantially slower - the decision is to optimise for the safety of the code generation against injection via untrusted schemas, for maintainability of the code and for the reduced size of the bundle, at the cost of slower schema compilation.
In most cases, when you compile schema once and then use it many times in server side environment, the time it takes to compile is not important, it usually happens at application start-up. If it compiles on demand, or - what would be much worse - on every API call, it has to be changed - the only reason to compile schema to code is to compile once and execute many times.
You can reduce the schema compilation time by turning off optimization (it would reduce time by about 30% I think), but even 0.15 sec per validation (if it was the case with v6) is very slow - validation itself is much faster than compilation. The solution could be to compile schemas once, and save standalone validation code (either during the build or into the database, alongside the schema).

Some docs that should be helpful:
For the context, the change in code generation: https://github.com/ajv-validator/ajv/blob/master/docs/codegen.md
Standalone validation code: https://github.com/ajv-validator/ajv/blob/master/docs/standalone.md
While v6 had inconsistent support for standalone code via a separate package ajv-pack, it is now included in this package as a separate file (that is Ajv itself does not use it but all schema tests are run both via Ajv API and via standalone code).

@epoberezkin great thanks for explanations, that information is very helpful. I think going with standalone approach, might be a solution for us. One question though, document indicates that:

Ajv package should still be a run-time dependency for most schemas

Does it meant, that standalone is not really a "standalone" and still will require an ajv to be installed and accessible for generated code?
I'm asking as I was thinking about storing standalone results in cache folder that's outside of package context (and without access to it's dependencies as ajv), therefore if it'll require ajv internally, requiring it obviously will fail
Additional side note. I believe there's an error in doc. Following I think doesn't work anymore:
const Ajv = require("ajv") // version >= v7.0.0

As AJV moved to ESM we've noticed we need to require it as:
const Ajv = require("ajv").default

@epoberezkin great thanks for explanations, that information is very helpful. I think going with standalone approach, might be a solution for us. One question though, document indicates that:

Ajv package should still be a run-time dependency for most schemas

Does it meant, that standalone is not really a "standalone" and still will require an ajv to be installed and accessible for generated code?
I'm asking as I was thinking about storing standalone results in cache folder that's outside of package context (and without access to it's dependencies as ajv), therefore if it'll require ajv internally, requiring it obviously will fail
Additional side note. I believe there's an error in doc. Following I think doesn't work anymore:
const Ajv = require("ajv") // version >= v7.0.0

As AJV moved to ESM we've noticed we need to require it as:
const Ajv = require("ajv").default

Does it meant, that standalone is not really a "standalone" and still will require an ajv to be installed and accessible for generated code?

Please see the rational behind it here: https://github.com/ajv-validator/ajv-cli/issues/98#issuecomment-754127642
It is indeed has to be installed/available, but it should not be an issue, as Ajv would not be initialised / executed - only specific files.

I'm asking as I was thinking about storing standalone results in cache folder that's outside of package context (and without access to it's dependencies as ajv), therefore if it'll require ajv internally, requiring it obviously will fail

You can still do it with any other tool that would bundle the dependent files in, replacing any requires - it's just extra compilation step, but it would give you completely isolated function(s).

Following I think doesn't work anymore: const Ajv = require("ajv") // version >= v7.0.0

Yes - it have slipped through...
I don't like this .default compromise but I didn't figure out a better solution - see here: https://github.com/ajv-validator/ajv/issues/1381#issuecomment-756635396

Does it meant, that standalone is not really a "standalone" and still will require an ajv to be installed and accessible for generated code?

Please see the rational behind it here: https://github.com/ajv-validator/ajv-cli/issues/98#issuecomment-754127642
It is indeed has to be installed/available, but it should not be an issue, as Ajv would not be initialised / executed - only specific files.

I'm asking as I was thinking about storing standalone results in cache folder that's outside of package context (and without access to it's dependencies as ajv), therefore if it'll require ajv internally, requiring it obviously will fail

You can still do it with any other tool that would bundle the dependent files in, replacing any requires - it's just extra compilation step, but it would give you completely isolated function(s).

Following I think doesn't work anymore: const Ajv = require("ajv") // version >= v7.0.0

Yes - it have slipped through...
I don't like this .default compromise but I didn't figure out a better solution - see here: https://github.com/ajv-validator/ajv/issues/1381#issuecomment-756635396

It has indeed to be installed/available, but it should not be an issue, as Ajv would not be initialised / executed - only specific files.

Also, it depends on which keywords you are using - most keywords won't have any dependencies, specifically it is uniqueItems that depends on equal and minLength/maxLength that depends ucs2lenght plus any formats you might be using from ajv-formats would be required in "standalone" code.

It has indeed to be installed/available, but it should not be an issue, as Ajv would not be initialised / executed - only specific files.

Also, it depends on which keywords you are using - most keywords won't have any dependencies, specifically it is uniqueItems that depends on equal and minLength/maxLength that depends ucs2lenght plus any formats you might be using from ajv-formats would be required in "standalone" code.

@epoberezkin would you consider adding an option to optimize codegen assuming all schemas are trusted?
For context, I work on a codebase with hundreds of jtd schemas. We chose to generate standalone validators because otherwise it would take tens of seconds to compile schemas on server startup time, which is not really reasonable. But generating standalone validators at build time is also tricky because it takes >1s to import ajv and compile a single validator.
By contrast, we write all our jtd schemas so they are all trusted, and it's unfortunate to have to take a big hit in compile time performance for no benefit. Let me say I appreciate all the work done to make this library performant when validating schemas; it would also be great to have compile-time performance considered of secondary (but not negligible) importance.


Duplicate long typedef disallowed

Duplicate typedefs should be allowed if they're equal. This one is weird; it seems it only happens for long (not long int or unsigned long or any other specifier):
typedef long foo;
typedef long foo;

test.c:2:17: error: expected identifier or '('
typedef long foo;
                ^

Happens because the existing typedef we find here: https://github.com/Vexu/arocc/blob/8ab72a4b1a4ff445b39b1f6d23fe2cbe59f37763/src/aro/Parser.zig#L2069
Gets combined with long to form a long long specifier here: https://github.com/Vexu/arocc/blob/8ab72a4b1a4ff445b39b1f6d23fe2cbe59f37763/src/aro/Parser.zig#L2070
That also led me to suspect other patterns could trigger it:
typedef double foo;
typedef long foo;

test.c:2:17: error: expected identifier or '('
typedef long foo;
                ^

Is there error message here also considered a bug? It seems pretty vague - like I wouldn't understand it by default.

The bug here is that there shouldn't be any errors.


amd-blis: init at 2.2

Motivation for this change
Add the AMD fork of BLIS. This provides a BLAS-compatible library that is optimized for AMD CPUs. A counterpart to MKL, but open source :).
Tested by recompiling numpy with AMD BLIS through the new BLAS overlay mechanism.
After this PR, I'll also do a PR for AMD's libflame, so that we have a full AMD BLAS/LAPACK as an alternative.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

CI builds fail.

CI builds fail.

Hmpf. SIGILL (Illegal instruction) on x86_64. Either it's misdetecting the features of the VM's CPU, or the features supported by CPUID are not permitted by the VM. Unfortunately, blis does not offer the possibility to override the architecture with e.g. an environment variable. I'll think a bit about the fix. Perhaps something along the lines of:
https://github.com/flame/blis/pull/345/commits/e22ab9dd0057dfd3d7b7590f41e41bce6ffbeb14

@ofborg build amd-blis

@ofborg build amd-blis

@ofborg build amd-blis

I figured it out. There is an error in the selection of CFLAGS that causes the zen kernels (which are also used on some Intel CPUs) to be compiled with Skylake X optimizations when the x86_64 configuration is chosen. This introduces some AVX-512 instructions in the kernel (vextractf64x2), interestingly, this does not fail on my Zen 2 machine.
The reason that the kernel selection fails is that x86_64 does not actually contain zen, so the kernel cannot be compiled with -march=zen. Adding zen (and zen2) to the amd64/x86_64 kernel leads to another error. I'll try to see if this is easily fixable.


Reformatting, Preliminary Code Completion, and Snippets for Preprocessor Directives

Hi Oldes,
I've fixed the formatting on some of the files.  Added an initial list for code completion (which will need revised anyways), and snippets for the preprocessor directives.
~Thomas Royko

Thanks a lot, can I make a new tag, so it would be public or should I wait for more changes?

Sorry I didn't respond back sooner.  You can go ahead and make a new tag.  I don't have any changes right now on the horizon.


New Wiki

Wiki topics

[x] How to do proxy
[ ] Deployment options
[ ] How to map from Bot API methods to our interface methods
[ ] What is diff on our API (e.g. sending files)
[x] Login widget
[ ] Passport
[ ] Getting started with callback queries and maintaining chat context

Docs are now moved to https://github.com/TelegramBots/book .


UI: improve tables with gray out for fixed fields and highlight of output fields

Adding highlighted columns is implemented in:: https://github.com/arise-insights/arise-predictions/pull/17


Not working on Heroku

Not returning anything while scrapping from Google on Heroku platform.
images are scraped finely in my local environment, but when code is deployed in Heroku nothing is happening no error no result from promise.

same here, It doesn't work

I am using a translator.
This is a problem in which Nightmare does not work in Linux.
I found your answer on the link below.
https://stackoverflow.com/questions/34795037/nightmare-js-not-working-as-expected-on-ubuntu-linux-cloud-server

I'm just posting this for posterity.
Below is the bash script to install nightmarejs with node (4.2.4) on a clean Ubuntu Linux machine. I've tested this on a DigitalOcean droplet running 14.04.

Apt-get-y update
Apt-get-Y Upgrade
Apt-get-y -- force - make the in-grow tk- ++ li- cy fb bg - - sl- il xk- bil ts- ononts xfonts - 100 100onts - 75 xfon onon ts
Mkdir src
Cd src
Wget https://nodejs.org/dist/v4.2.4/node-v4.2.4.tar.gz
Tar xzf node- v4.2.4.tar. gz
Cd node- v.2.4
. / Configuration
Make - j 2
Make install
CD ..
Mkdir nightmarejs
Cd nightmarejs
Npm-f init
Npm install -- save nightmare voltage

Then you simply create the .js file (e.g. hello_nightmare.js) (in the same directory where nightmarejs is installed) and then run it using the command below (as already mentioned in @yoz's answer):

xv fb-run node-harmony hello _ nightmare.js.
good luck!


Improve Documentation

Supported scenarios and unsupported scenarios are not well explained outside the example on the README.
Improve Documentation with more examples and explanations of what will/won't work.

[ ] Set up Github Pages site with great documentation

[ ] Improve  & Update README

[ ] XML  tags on classes & methods.


[Bug] Hiding the title bar multiple times will result in an error

Python: 3.12.0
OS: Windows 11
hPyT: 1.3.2

Running the following code will result in an error:
import tkinter

import hPyT

root = tkinter.Tk()
hPyT.title_bar.hide(root)
hPyT.title_bar.unhide(root)
hPyT.title_bar.hide(root)
root.mainloop()

Error message:
OSError: exception: access violation reading 0xFFFFFFFFFFFFFFFF
Exception ignored on calling ctypes callback function: <function title_bar.hide.<locals>.handle at 0x00000268A202FF60>
Traceback (most recent call last):
  File "C:\Software\Python312\Lib\site-packages\hPyT\hPyT.py", line 80, in handle
    return call_window_proc(*map(ctypes.c_uint64, (globals()[old], hwnd, msg, wp, lp)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

After forcibly ending the program:
Exception ignored on calling ctypes callback function: <function title_bar.hide.<locals>.handle at 0x00000268A202FF60>

The error message is output in a loop, and the interface program cannot be closed by normal means

Hello @Xiaokang2022 , thank you so much for pointing this issue out, I will take a look soon and try to solve it as soon as possible

Hello @Xiaokang2022 , I fixed the bug and pushed a new release acknowledging it.  I am closing this issue, if you need any help, please feel free to re-open this issue or create a new issue.


Updated Readme.md of final project

I forgot to add the screenshots of the project in the final project. I have added it now.

@siddhi-244  please merge it now. Sorry for the inconvenience caused. And thanks a lot for your wonderful guidance throughout the cohort.


Test CAPA cluster creation in a different account

Task
Test CAPA cluster creation in a different account.
TODOs

[x] Get AWS account to use for testing;
[ ] Test cluster creation in a different account;

I created a  new AWSClusterRoleIdentity named default2 in grizzly  which points to account<PHONE_NUMBER>95 (atm known as gauss workload cluster account)
roles are created as well so testing should be possible

I created a  new AWSClusterRoleIdentity named default2 in golem  which points to account<PHONE_NUMBER>95 (atm known as gauss workload cluster account)

I’ve created a cross account public cluster named bear . These are the things that I’ve checked for on AWS (using the specified gauss account) and the cluster itself.
Checklist on AWS

[x] Instances
[x] VPC - 1
[x] Roles - 4
[x] Subnets - 6
[x] Hosted zones - 1
[x] Routing tables. - 6
[x] Security group - 4
[x] Load balancers - 1
[x] Nat gateways - 3

Checklist on Cluster

[x] Pods health state - pods look good
[x] Login
[x] Nodes - Healthy

I tried to create a private cluster on golem but the aws-network-topology-operator is saying that AWS can't find an existing subnet when the transit gateway is attached:
1.6710229132236247e+09  INFO    Reconciling     {"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"alextest36","namespace":"org-giantswarm"}, "namespace": "org-giantswarm", "name": "alextest36", "reconcileID": "6686176c-118c-48b7-9ae2-19166a0f4e64"}
1.6710229133360448e+09  INFO    transitgateway-registrar        Got TransitGateway      {"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"alextest36","namespace":"org-giantswarm"}, "namespace": "org-giantswarm", "name": "alextest36", "reconcileID": "6686176c-118c-48b7-9ae2-19166a0f4e64", "transitGatewayID": "tgw-034e681b2d0288423"}
1.6710229134554205e+09  ERROR   transitgateway-registrar        Failed to create transit gateway attachments    {"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"alextest36","namespace":"org-giantswarm"}, "namespace": "org-giantswarm", "name": "alextest36", "reconcileID": "6686176c-118c-48b7-9ae2-19166a0f4e64", "transitGatewayID": "tgw-034e681b2d0288423", "vpcID": "vpc-0e9d440dc6831956a", "error": "operation error EC2: CreateTransitGatewayVpcAttachment, https response error StatusCode: 400, RequestID: 93f6dbfb-b2de-454c-9913-7c93aabeb13f, api error InvalidSubnetID.NotFound: The subnet ID 'subnet-0545a88f6cbcbef1d' does not exist"}
1.6710229134735894e+09  INFO    Done reconciling        {"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"alextest36","namespace":"org-giantswarm"}, "namespace": "org-giantswarm", "name": "alextest36", "reconcileID": "6686176c-118c-48b7-9ae2-19166a0f4e64"}
1.6710229134736302e+09  ERROR   Reconciler error        {"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"alextest36","namespace":"org-giantswarm"}, "namespace": "org-giantswarm", "name": "alextest36", "reconcileID": "6686176c-118c-48b7-9ae2-19166a0f4e64", "error": "operation error EC2: CreateTransitGatewayVpcAttachment, https response error StatusCode: 400, RequestID: 93f6dbfb-b2de-454c-9913-7c93aabeb13f, api error InvalidSubnetID.NotFound: The subnet ID 'subnet-0545a88f6cbcbef1d' does not exist"}

The cluster was created with the following config:
---
apiVersion: v1
data:
  values: |
    aws:
      region: eu-west-2
      awsClusterRole: default2
    bastion:
      enabled: false
    proxy:
      enabled: true
      http_proxy: "http://internal-a1c90e5331e124481a14fb7ad80ae8eb-1778512673.eu-west-2.elb.amazonaws.com:4000"
      https_proxy: "http://internal-a1c90e5331e124481a14fb7ad80ae8eb-1778512673.eu-west-2.elb.amazonaws.com:4000"
      no_proxy: "test-domain.com"
    clusterName: alextest36
    controlPlane:
      replicas: 1
    machinePools:
    - instanceType: m5.xlarge
      maxSize: 10
      minSize: 3
      name: machine-pool0
      rootVolumeSizeGB: 300
      availabilityZones:
      - eu-west-2a
      - eu-west-2b
      - eu-west-2c
    network:
      vpcCIDR: <IP_ADDRESS>/16
      topologyMode: GiantSwarmManaged
      availabilityZoneUsageLimit: 3
      vpcMode: private
      apiMode: private
      dnsMode: private
      subnets:
      - cidrBlock: <IP_ADDRESS>/18
      - cidrBlock: <IP_ADDRESS>/18
      - cidrBlock: <IP_ADDRESS>/18
    organization: giantswarm
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: alextest36
  name: alextest36-userconfig
  namespace: org-giantswarm
---
apiVersion: application.giantswarm.io/v1alpha1
kind: App
metadata:
  labels:
    app-operator.giantswarm.io/version: 0.0.0
  name: alextest36
  namespace: org-giantswarm
spec:
  catalog: cluster
  config:
    configMap:
      name: ""
      namespace: ""
    secret:
      name: ""
      namespace: ""
  kubeConfig:
    context:
      name: ""
    inCluster: true
    secret:
      name: ""
      namespace: ""
  name: cluster-aws
  namespace: org-giantswarm
  userConfig:
    configMap:
      name: alextest36-userconfig
      namespace: org-giantswarm
  version: 0.20.2
---
apiVersion: v1
data:
  values: |
    clusterName: alextest36
    organization: giantswarm
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: alextest36
  name: alextest36-default-apps-userconfig
  namespace: org-giantswarm
---
apiVersion: application.giantswarm.io/v1alpha1
kind: App
metadata:
  labels:
    app-operator.giantswarm.io/version: 0.0.0
    giantswarm.io/cluster: alextest36
    giantswarm.io/managed-by: cluster
  name: alextest36-default-apps
  namespace: org-giantswarm
spec:
  catalog: cluster
  config:
    configMap:
      name: alextest36-cluster-values
      namespace: org-giantswarm
    secret:
      name: ""
      namespace: ""
  kubeConfig:
    context:
      name: ""
    inCluster: true
    secret:
      name: ""
      namespace: ""
  name: default-apps-aws
  namespace: org-giantswarm
  userConfig:
    configMap:
      name: alextest36-default-apps-userconfig
      namespace: org-giantswarm
  version: 0.12.3

The subnet subnet-0545a88f6cbcbef1d exists:

All the operations in the operator are done from the perspective of the management cluster. There are only 2 places where the GetAWSRoleIdentity function is called:

one for the ec2Client;
one for the snsClient.

The transit gateway attachment needs to be executed from the workload cluster's perspective.

The transit gatway and the prefix list needs to be shared with the workload cluster account before the cluster is created. I manually attached the transit gateway and updated the route tables. The cluster was able to start:
 #: kubectl get pods -A
NAMESPACE     NAME                                                                  READY   STATUS      RESTARTS        AGE
giantswarm    chart-operator-79d7b7567b-4rxd2                                       1/1     Running     0               8m38s
kube-system   aws-pod-identity-webhook-app-66fd9f9b55-6zwk8                         1/1     Running     0               9m45s
kube-system   aws-pod-identity-webhook-app-66fd9f9b55-jf4wv                         1/1     Running     0               9m45s
kube-system   aws-pod-identity-webhook-restarter-27850445-hvkd5                     0/1     Completed   0               99s
kube-system   capi-node-labeler-2sgf9                                               1/1     Running     0               16m
kube-system   capi-node-labeler-452jv                                               1/1     Running     0               16m
kube-system   capi-node-labeler-82f2n                                               1/1     Running     0               16m
kube-system   capi-node-labeler-fcnvb                                               1/1     Running     0               16m
kube-system   cert-exporter-daemonset-7cwnr                                         1/1     Running     0               12m
kube-system   cert-exporter-daemonset-9mvt9                                         1/1     Running     0               12m
kube-system   cert-exporter-daemonset-tgpq2                                         1/1     Running     0               12m
kube-system   cert-exporter-daemonset-whnnb                                         1/1     Running     0               12m
kube-system   cert-exporter-deployment-85c658c656-kvppj                             1/1     Running     0               12m
kube-system   cert-manager-cainjector-6dc9c79bfd-swh79                              1/1     Running     0               10m
kube-system   cert-manager-controller-7b7c4c77c4-5hqcp                              1/1     Running     0               10m
kube-system   cert-manager-webhook-6bf4c564bb-m62b4                                 1/1     Running     0               10m
kube-system   cert-manager-webhook-6bf4c564bb-p6lwr                                 1/1     Running     0               10m
kube-system   cilium-ctwdg                                                          1/1     Running     0               14m
kube-system   cilium-jfqsb                                                          1/1     Running     0               14m
kube-system   cilium-kl7l4                                                          1/1     Running     0               14m
kube-system   cilium-operator-58bcdb44cb-vg2mf                                      1/1     Running     0               14m
kube-system   cilium-operator-58bcdb44cb-wgtlq                                      1/1     Running     0               14m
kube-system   cilium-wkkfr                                                          1/1     Running     0               14m
kube-system   coredns-controlplane-564bffc48d-w4hwz                                 1/1     Running     0               12m
kube-system   coredns-workers-8666c764cd-fvfvb                                      1/1     Running     0               12m
kube-system   coredns-workers-8666c764cd-p8r6k                                      1/1     Running     0               12m
kube-system   ebs-csi-controller-67c4cf5496-q5txj                                   5/5     Running     0               11m
kube-system   ebs-csi-node-9l6vr                                                    3/3     Running     0               11m
kube-system   ebs-csi-node-hc5sz                                                    3/3     Running     0               11m
kube-system   ebs-csi-node-qpjtl                                                    3/3     Running     0               11m
kube-system   etcd-ip-10-20-101-216.eu-west-2.compute.internal                      1/1     Running     0               17m
kube-system   external-dns-76b8fb8586-4dj2m                                         2/2     Running     2 (7m19s ago)   12m
kube-system   hubble-relay-79bfdd4c6c-brbgx                                         1/1     Running     0               14m
kube-system   kiam-agent-f6tsl                                                      1/1     Running     2 (7m33s ago)   7m36s
kube-system   kiam-agent-tkm59                                                      1/1     Running     2 (7m33s ago)   7m36s
kube-system   kiam-agent-zbzkd                                                      1/1     Running     2 (7m33s ago)   7m36s
kube-system   kiam-namespace-annotation-kube-system-5l9b6                           0/1     Completed   0               9m53s
kube-system   kiam-server-fpvsp                                                     1/1     Running     0               7m37s
kube-system   kube-apiserver-ip-10-20-101-216.eu-west-2.compute.internal            1/1     Running     2 (17m ago)     17m
kube-system   kube-controller-manager-ip-10-20-101-216.eu-west-2.compute.internal   1/1     Running     1 (17m ago)     17m
kube-system   kube-scheduler-ip-10-20-101-216.eu-west-2.compute.internal            1/1     Running     1 (17m ago)     17m
kube-system   kube-state-metrics-6b89676dbf-bqsrq                                   1/1     Running     0               10m
kube-system   metrics-server-7cdb8d8cd8-mjfbs                                       1/1     Running     0               12m
kube-system   metrics-server-7cdb8d8cd8-xcfm2                                       1/1     Running     0               12m
kube-system   net-exporter-2vcfh                                                    1/1     Running     0               12m
kube-system   net-exporter-6h9nm                                                    1/1     Running     0               12m
kube-system   net-exporter-cj4wn                                                    1/1     Running     0               12m
kube-system   net-exporter-j2sq5                                                    1/1     Running     0               12m
kube-system   node-exporter-v1-3-1-4n7vd                                            1/1     Running     0               14m
kube-system   node-exporter-v1-3-1-lh9p9                                            1/1     Running     0               14m
kube-system   node-exporter-v1-3-1-tbg6s                                            1/1     Running     0               14m
kube-system   node-exporter-v1-3-1-wkvgh                                            1/1     Running     0               14m
kube-system   prometheus-operator-app-operator-f6b45b859-qfqvz                      1/1     Running     0               11m
kube-system   prometheus-prometheus-agent-0                                         2/2     Running     0               11m
kube-system   vertical-pod-autoscaler-admission-controller-556558c8d9-ffc5d         1/1     Running     0               11m
kube-system   vertical-pod-autoscaler-admission-controller-556558c8d9-z6spl         1/1     Running     0               11m
kube-system   vertical-pod-autoscaler-recommender-67b5d54d5f-lgvb6                  1/1     Running     0               11m
kube-system   vertical-pod-autoscaler-updater-7bdddf5b-jgk8t                        1/1     Running     0               11m

Blocked until https://github.com/giantswarm/roadmap/issues/1801 is fixed.

instruction how to create a role is here https://github.com/giantswarm/giantswarm-aws-account-prerequisites/tree/master/capa-controller-role  - use INSTALLATION_NAME goat
we should create the role in the was account<PHONE_NUMBER>95 and then just create another AWSClusterRoleIdentity, using the default CR in the goat  as a reference
.

Blocking again on https://github.com/giantswarm/roadmap/issues/1801 as the transit gateway needs to also be shared with the account automatically

can this one be moved out of the blocked column into the sprint backlog now that https://github.com/giantswarm/roadmap/issues/1801 is closed?

thunder / dev00 was recreated in a separate account.


Hello there，how does the client use multiple threads?

How does unimrcp client work when using multiple threads? And how does the client use multiple threads?

The response is posted in this thread.


Crash. If you select two node CollisionPolygon.

Operating system or device - Godot version:
Ubuntu 16.04, Godot 2.1
Issue description (what happened, and what was expected):
Crash. If select two node CollisionPolygon.
Link to minimal example project (optional but very welcome):

Confirmed on Windows10

Backtrace for CollisionPolygon:
Program received signal SIGSEGV, Segmentation fault.
0x0000000001b0cdf0 in CollisionPolygon::get_depth (this=0x0)
    at scene/3d/collision_polygon.cpp:259
259		return depth;
(gdb) bt
#0  0x0000000001b0cdf0 in CollisionPolygon::get_depth (this=0x0)
    at scene/3d/collision_polygon.cpp:259
#1  0x00000000015b459b in CollisionPolygonEditor::_notification (
    this=0x8969410, p_what=17)
    at tools/editor/plugins/collision_polygon_editor_plugin.cpp:51
#2  0x00000000015ba83e in CollisionPolygonEditor::_notificationv (
    this=0x8969410, p_notification=17, p_reversed=false)
    at tools/editor/plugins/collision_polygon_editor_plugin.h:47
#3  0x000000000224b530 in Object::notification (this=0x8969410,
    p_notification=17, p_reversed=false) at core/object.cpp:908
#4  0x00000000018eccf2 in SceneTree::_notify_group_pause (this=0x43fb8a0,
    p_group=..., p_notification=17) at scene/main/scene_main_loop.cpp:900
#5  0x00000000018eb14e in SceneTree::idle (this=0x43fb8a0, p_time=0,13333334)
    at scene/main/scene_main_loop.cpp:528
#6  0x0000000000cdc7d9 in Main::iteration () at main/main.cpp:1597
#7  0x0000000000cbe92b in OS_X11::run (this=0x7fffffffda00)
    at platform/x11/os_x11.cpp:1921
#8  0x0000000000cb6735 in main (argc=4, argv=0x7fffffffdf08)
    at platform/x11/godot_x11.cpp:41

Backtrace for GridMap:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000f2927a in Node::is_inside_tree (this=0x0)
    at ./scene/main/node.h:211
211		_FORCE_INLINE_ bool is_inside_tree() const { return data.inside_tree; }
(gdb) bt
#0  0x0000000000f2927a in Node::is_inside_tree (this=0x0)
    at ./scene/main/node.h:211
#1  0x0000000001ba44d8 in Spatial::get_global_transform (this=0x0)
    at scene/3d/spatial.cpp:265
#2  0x0000000000ff49f8 in GridMapEditor::_notification (this=0x8da63d0,
    p_what=17) at modules/gridmap/grid_map_editor_plugin.cpp:1032
#3  0x0000000000ffb0e2 in GridMapEditor::_notificationv (this=0x8da63d0,
    p_notification=17, p_reversed=false)
    at modules/gridmap/grid_map_editor_plugin.h:43
#4  0x000000000224b530 in Object::notification (this=0x8da63d0,
    p_notification=17, p_reversed=false) at core/object.cpp:908
#5  0x00000000018eccf2 in SceneTree::_notify_group_pause (this=0x43fb0a0,
    p_group=..., p_notification=17) at scene/main/scene_main_loop.cpp:900
#6  0x00000000018eb14e in SceneTree::idle (this=0x43fb0a0, p_time=0,13333334)
    at scene/main/scene_main_loop.cpp:528
#7  0x0000000000cdc7d9 in Main::iteration () at main/main.cpp:1597
#8  0x0000000000cbe92b in OS_X11::run (this=0x7fffffffda00)
    at platform/x11/os_x11.cpp:1921
#9  0x0000000000cb6735 in main (argc=4, argv=0x7fffffffdf08)
    at platform/x11/godot_x11.cpp:41

It seems to be a problem with editor plugins. The editor plugin is accessing a null pointer of the object it's supposed to be editing. It may have something to do with #4174

Hum... is this still valid on master?

2.1.3 unchanged

valid on 1a92906b681735a5a2acfd98e3d6a4c75a7f6115

The fix for this case is pretty simple. I'm trying to see if I can come up with a fix for the general case of this though. Maybe it will just be a giant pile of extra null checks at many _notification() methods.

There doesn't seem to be, I'll make a PR for this particular issue. I'll see if I can find more manually.


Map Movement Events Missing

When navigating to a party, the target party is not synchronized to all clients. Needs to be looked into.

There's a property MobileParty.DefaultBehaviorNeedsUpdate that is currently not being tracked in Coop.Mod.Patch.CampaignMapMovement. I also never look into the besieging stuff, that uses some other fields as well.
I think the way to solve this bug is to further look into MobileParty and identify:

All the methods & property setters that are used to manipulate any map movement state
All the internal fields that are actually relevant for the map movement
And then update CampaignMapMovement accordingly.

Might also be related to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/issues/17

I dont think it is directory related to #17. I noticed desync between the host and client with a looter party. Could be an attack event that is not tracked.

There is an issue when a client party is moving to the host party. This is most likely due to the hosts party being the Campaign.MainParty, so the game supresses movement events.

To be more precise: MapScreen.HandleLeftMouseButtonClick:
PartyBase party = PartyBase.FindParty(visualOfSelectedEntity.PartyIndex);
if (party == PartyBase.MainParty || party == null)
{
    MobileParty.MainParty.SetMoveModeHold();
}
else
{
    // ...
}

So it's technically not a missing movement sync, but rather that no movement is generated by the game  at all. This might be a reoccuring issue because MobileParty.MainParty is used all over the place.

I couldn't really figure out much so far. But just so it doesn't get lost, here are my current findings.
Movement is sent to all clients
The following is a log output of a host + connected player when moving the hosts party to the connected players party:

Thread 7 is the hosts game instance
Thread 31 is the hosts server instance
Thread 10 is the connected players game instance
To explain the log messages in order:

Hosts game generates the move request
Server ACKs the move request and broadcasts it
Hosts game receives the move from the server
Connected players game receives the move from the server
In the hosts game instance, the his party arrived at the other players party. So a hold is generated. The following events are again the broadcasting of the hold and applying it on all clients including the time stop since no party is moving anymore.

Things to note:

The move is received by all clients and written to the MobileParty, but apparently it has no effect
Usually when moving a player party, the game will automatically unpause. In step 4 this does not happen.
MobileParty.SetMoveModeHold is not called on the connected players end, i investigated this already.

Engaging the main player party with a client party requires an explicit update of both AIs on both game instances - otherwise, it will just not apply.


Release 3.5.1

Feature or improvement description
Pull request to merge rc-3.5.1 into main and create a tagged release for v3.5.1.
See the milestone and project pages for additional information
https://github.com/OpenFAST/openfast/milestone/10
https://github.com/orgs/OpenFAST/projects/4

Test results, if applicable
See GitHub Actions
Release checklist:

[ ] Update the documentation version in docs/conf.py
[ ] Update the versions in docs/source/user/api_change.rst
[ ] Verify readthedocs builds correctly
[ ] Create a tag in OpenFAST
[ ] Create a merge commit in r-test and add a corresponding tag
[ ] Compile executables for Windows builds

[ ] FAST_SFunc.mexw64
[ ] OpenFAST-Simulink_x64.dll
[ ] openfast_x64.exe
[ ] DISCON.dll (x64)
[ ] AeroDyn_Driver
[ ] AeroDyn_Inflow_C_Binding
[ ] BeamDyn_Driver
[ ] HydroDyn_Driver
[ ] HydroDyn_C_Binding (x64)
[ ] InflowWind_Driver
[ ] IfW_C_Binding (x64)
[ ] MoorDyn_Driver
[ ] FAST.Farm (x64)

Changelog
General
Build systems
#1586 CMake: Remove openfast_cpp target if BUILD_OPENFAST_CPP_API not selected
#1647 Fix adding OpenMP flags to CMAKE_Fortran_FLAGS
#1818 VS-build updates for rc-3.5.1 and other minor updates.  Includes truing up some Types files.
Documentation
#1788 Readthedocs configuration changes
Solvers
FAST.Farm
#1648 Fix bug with Mod_AmbWind=3 -- hub point wasn't shifted.
Module changes
AeroDyn
#1657 AD Driver: stack size for 64 bit solutions (see #1260)
#1658 AD/TailFin: Bug Fix: remove chord in fy (see #1653)
#1659 AD: Adding rtest for TailFin polar-based model
#1679 AD: nodal outputs in different coordinate systems (new feature)
#1700 Remove deleted variables BlFB and BlMB from AeroDyn_AllBldNdOuts_IO
BeamDyn
#1771 Change BD states to follow the blade root reference frame.  Small performance improvements around azimuth=180.
#1796 Resolve BeamDyn initial strain for rotated blade.  Backport of #1663
ElastoDyn
#1654 fix segfault when BldNd_BladesOut==0 (Also for AeroDyn)
HydroDyn
#1621 [BugFix] HD wave visualization with 2nd order waves
#1780 [BugFix]  AddF0 for multiple potential-flow bodies with NBodyMod/=0 (backport of #1776)
#1768 new feature: Visualization of HydroDyn Morison mesh (also MoorDyn lines)
InflowWind
#1620 [BugFix] ServoDyn inputs for Lidar allocated twice, and a few other minor issues
#1655 [BugFix] InflowWind was not setting InitOut MWS data.
#1748 [BugFix] compute vel avg profile when exceed allowed
#1759 [BugFix] InflowWind Flow Field fails to calculate AvgVel for large wind files when using Intel Compiler
#1769 [BugFix] Add additional modulo in IfW_FlowField to correct error with exhausted field from Grid3D on long simulations (see #1746 and PR #1730)
MAP++
#1752 MAP++ linear spring approach improvement (@rbergua)
MoorDyn
#1768 MoorDyn line visualization (see HydroDyn above)
#1727 MoorDyn updates and bug fixes (naming, catenary solve improvement, output channels, bugs with added mass, rods, and comment typos
#1815 MoorDyn dynamic relaxation and fixed bodies
#1816 Fixed drag coefficient scaling
NWTC-Library
#1731 Blade Pitch input to ElastoDyn drifts during solution if ServoDyn is not active (improvements to Extrap/Interp routines)
SubDyn
#1802 Increase SubDyn output to allow NMOutputs up to 99.  Backport of features from dev (multiple commits)
Regression tests
#1581, #1593  Update floating MHK case input files
#1694 Improved linearization file comparison
#1695 AD: adding linearization tests for aerodyn continuous-states model
#1801 Add Mod_AmbWind=3 regression test to the CI
Input file changes
No input files change with this release, as this only includes minor bugfixes.
Full list of changes: https://openfast.readthedocs.io/en/main/source/user/api_change.html
Full input file sets: https://github.com/OpenFAST/r-test/tree/v3.5.1 (example input files from the regression testing)

@RyanDavies19, @hkross, @luwang00, @bjonkman -- if you have time, could your review changes from PR's of yours that are included in this release?

Live documentation for this PR: https://openfast.readthedocs.io/en/rc-3.5.1/

@andrew-platt All looks good on the MoorDyn side aside from three erroneous print statements left behind from debugging. I just created a PR to this release that removes them.

@RyanDavies19, good catch!  Thanks for fixing that.

Note: the OC3Trpd case fails sporadically. There is likely an uninitialized variable or two that is causing this.  Since a significant amount of the code that could contribute to this is getting rewritten in 4.0, so we won't fix it here.

@RyanDavies19, @hkross, @luwang00, @bjonkman -- if you have time, could your review changes from PR's of yours that are included in this release?

@andrew-platt Looks good to me!

@andrew-platt For HD, there is also the recent PR #1806 which fixed some existing bugs with the strip-theory loads and updated the radiation convolution integral to 2nd order. Should we point that out in this PR as well?

@jjonkman, after everyones comments, I'll tag r-test -- then the link will be correct.
@luwang00, I missed that one in putting together the summary. I'll add it to the list.


Switch with string output payloads gets confused when driven by input messages.

This is a follow on from Issue #311 point 4, which still seems to a problem.
To replicate, the sequence of operations must be followed carefully.
After importing the flow below:

Exercise the switch using the Dashboard UI. The On and Off messages show in the debug pane.
Leave the switch in the Off position
Click the 'On' Inject button.  The switch correctly changes state in the UI and the node status shows On. No message is sent as the node is configured to Not pass through
Click the 'Off' Inject button. Again the switch and status correctly change state to Off
Click the switch in the UI. The switch changes state to On, but the message sent is 'Off' and the switch status still shows Off.
Click the switch in UI again, it changes to off, the message sent is again Off and the node status stays at off
Click the switch in the UI again, it switches to On, and everything is back in sync again

Using Dashboard version 0.11.1, NR 3.1.3, nodejs 20.5.1
[{"id":"110215ae25dce479","type":"inject","z":"997da33a0beedade","name":"","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"On","payloadType":"str","x":230,"y":600,"wires":[["2af9e1f4faedb5e5"]]},{"id":"2af9e1f4faedb5e5","type":"ui-switch","z":"997da33a0beedade","name":"Test switch alpha values","label":"Test switch alpha","group":"7545fdb22e4a388c","order":2,"width":0,"height":0,"passthru":false,"topic":"some/topic","topicType":"str","style":"","className":"","onvalue":"On","onvalueType":"str","onicon":"","oncolor":"","offvalue":"Off","offvalueType":"str","officon":"","offcolor":"","x":490,"y":640,"wires":[["ffe6f81a81da5d34"]]},{"id":"7595adbe1da58d19","type":"inject","z":"997da33a0beedade","name":"","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"Off","payloadType":"str","x":230,"y":660,"wires":[["2af9e1f4faedb5e5"]]},{"id":"ffe6f81a81da5d34","type":"debug","z":"997da33a0beedade","name":"debug 26","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":690,"y":640,"wires":[]},{"id":"7545fdb22e4a388c","type":"ui-group","name":"D2 tests","page":"d7fcdd33578e5d34","width":"6","height":"1","order":-1,"showTitle":true,"className":""},{"id":"d7fcdd33578e5d34","type":"ui-page","name":"d2","ui":"ID-BASE-1","path":"/d2","layout":"flex","theme":"4bff2b59c4c518e1","order":-1,"className":""},{"id":"ID-BASE-1","type":"ui-base","name":"Dashboard","path":"/dashboard"},{"id":"4bff2b59c4c518e1","type":"ui-theme","name":"Another Theme","colors":{"surface":"#ffffff","primary":"#0094ce","bgPage":"#eeeeee","groupBg":"#ffffff","groupOutline":"#cccccc"}}]

Thanks @colinl key piece I missed was the disabling of pass through when testing this. Will take a look in new year

I am also seeing an issue which may be caused by the same thing as this, if you have a switch and you refresh the browser, the first time it is turned on it will send the off string, this seems to reliably happen the first time after a refresh but functions normally after.
I noticed it because I was trying to update the switches status with the device status because there is more than one place it can be controlled but was unable to turn it on from the browser as it would feed back automatically to the off state.

I can confirm @prunes-git comment, that, after refreshing the browser the initial message when clicking the switch is always Off. This applies with payloads of type string and of type object.
I had hoped that Dashboard version 0.11.4, which includes some fixes for operations with Object type payloads would fix the issues here, but it seems not.

Thanks for confirming @colinl - I thought I had fixed this, but apparently not, will make it a priority now.

The flow I posted in the first post shows the problem, I believe.


Tasks collection and creation improvements

Checklist before merging

[X] I added an appropriate entry to CHANGELOG.md

Closes #169
Closes #342

On tasks collection it is now possible to add/remove pinned packages versions:

On single task creation it is possible to upload an args schema file. The content is validated both to be a valid JSON and a valid JSON schema (using ajv):

I've also improved the handling of validation errors received from the server:

Great, that looks very useful to have in Fractal web! And very nice validation!
Now that the functionality is getting more complex, we should add a bit more structure to it.
I'd like to tackle the following problems:

Make it clear what is required and what is optional. We can go with bold vs. regular. Or we can make the Advanced Options only show when one clicks on expand on them.
Reason: Most people won't need to use pinned package versions, so we don't want to always deploy options that are just needed for some use-cases.

I would prefer a manual separation of arguments, because we support different use-cases. e.g. for "Collect tasks from a package", it supports PyPi packages & whls. Whls don't require the version, I'd encourage specifying it for PyPi packages though.
=> would be good to show Package & version always, have the rest as "advanced options"
For single task, I see Task name, Command & Source as the main options to show. The others are advanced options

Add some helper info the the fields. See discussion here on adding a pop-over for the package: https://github.com/fractal-analytics-platform/fractal-web/issues/349
If you can draft some, I can review and suggest text for any missing info box or changes to the text where needed

I would add a radio button to distinguish between the 2 cases, so that when the user want to collect a wheel package we can hide the version input field and expand the package path input field:

The advanced options can be put inside an accordion:

If the layout looks too nested we can simply separate them in this way:

Let me know what you prefer.

Oh, I love the PyPi vs. Whl toggle!! And super useful to have the short descriptions below the fields.
While I requested the accordions, I'd say the bottom option actually looks better! Let's go with that!

Thanks Sonia! Slightly unrelated, but while testing this feature I noticed the following minor issues on the tasks page.

I think that we should make the separation between "Collect tasks from a package" and "Add a single task" more clear. When we are collecting a task package, the "Add a single task" section appears very similar as yet another option of the same panel (note the white background of the "Add a single task" header):

Also related: I think that expanding one of the two panels should always make the other one collapse, so that we don't have them both open at the same time (which is currently possible).

https://github.com/fractal-analytics-platform/fractal-web/issues/366

Points 1 and 2 make me wonder whether the current organization of the two panels is optimal, or whether we could do something similar to the radio button in https://github.com/fractal-analytics-platform/fractal-web/pull/364#issuecomment-1849656518 also to separate the two task-creation procedures.

More specific comments on your proposals:

I do like the "PyPI vs local package" radio button, with different forms depending on the choice.

It's true that the "extras" argument is optional and advanced, but it's also an argument that we will very often include (this is always true for fractal-tasks-core). I suggest we don't hide it behind too many clicks. That is: I suggest we avoid yet another accordion (the one for "Advanced options"), and I'd rather see it as a static form. We are looking at 4/5 arguments, not a thousand ;). OK, I see that now also @jluethi seems to agree (https://github.com/fractal-analytics-platform/fractal-web/pull/364#issuecomment-1851496111).

Hi, related to this discussion, I was wondering if it makes sense to also allow the user to provide the meta.json file and the args schema version (e.g., pydantic v1.0) when adding a single task? Whenever I create a task on the web interface I still have to add these things to the task with the fractal client via the command line before I can use the task.
Also, it might be nice to have a field for a description when adding single tasks. There is currently a field for "Docs Info" but it can't be edited on the web interface and I think it's not exposed to the fractal client?

Hi there, thanks for chiming in.

I was wondering if it makes sense to also allow the user to provide the meta.json file and the args schema version (e.g., pydantic v1.0) when adding a single task?

As for the args_schema_version attribute: thanks, we actually missed it! This is how it should work: If the user provides an args_schema attribute (by uploading a JSON schema file) for a task, then they also must specify the args_schema_version attribute, which is a string (typical value: "pydantic_v1").
Note: setting args_schema and not setting args_schema_version is an invalid behavior, that fractal-web could prevent before an error takes place in fractal-server.

I was wondering if it makes sense to also allow the user to provide the meta.json file

It does make sense, I think. This is how it should work: an additional button "Upload a meta file" lets the user upload a JSON file (note: this is not a JSON Schema, just any JSON file), and the corresponding object is used as the meta property of the request body.

Also, it might be nice to have a field for a description when adding single tasks. There is currently a field for "Docs Info" but it can't be edited on the web interface and I think it's not exposed to the fractal client?

Sure. This is how it could work: an additional text prompt, where the user can write a (possibly long-ish, like one or two paragraphs) description of the task, which will be part of the docs_info request-body property. This will be eventually rendered in markdown: if there is a simple way of having syntax highlighting, that would be nice (but not if that includes any validation or rendering!).
As @jluethi mentioned above, if we expose all these options we shoukd make sure that "advanced/optional" options are clearly marked as such.

Points 1 and 2 make me wonder whether the current organization of the two panels is optimal, or whether we could do something similar to the radio button in https://github.com/fractal-analytics-platform/fractal-web/pull/364#issuecomment-1849656518 also to separate the two task-creation procedures.

I like the idea of just having an "Add tasks" section, with 3 options:
PyPi package, Local package, Single task
And with the "Optional Arguments" version, not the expand advanced option seems good.

Thanks @adrtsc for adding these additions from your recent experience with the task addition!
I think it does show the limits of adding single tasks (the amounts of extra info that needs to be provided) and I'd like to steer people towards using the task template package to add those, so it's not adding all of those manually on the web interface each time. But the API is there, so it should also be exposed in Fractal web!

Sure. This is how it could work: an additional text prompt, where the user can write a (possibly long-ish, like one or two paragraphs) description of the task, which will be part of the docs_info request-body property. This will be eventually rendered in markdown: if there is a simple way of having syntax highlighting, that would be nice (but not if that includes any validation or rendering!).

Let's keep it simple for the time being: There is a text-box that the user enters the optional doc-info. For a better experience, use the task template package (=> PyPi or local package via whl).

To summarize, those are the options to be added:

[ ] args_schema_version: Can we make it default to pydantic_v1 for the moment, e.g. show that string and the user could change it?
[ ] "Upload a meta file" for the meta.json
[ ] docs_info text box

Some more screenshots of the updated UI.
PyPi:

Local:

Single:

Notice that input type and output type are required fields.
I've also added the docs_link input field. To reduce the used space the args_schema_version field appears only when an args schema file is selected and I've put the documentation fields inside an accordion.

Thanks, I think this is an improvement!
Probably the top-menu "Single" label should read something like "Single task".
Second minor comment: does args_schema_version only appear upon adding a valid JSON-Schema file? Otherwise I'm confused about why it is missing in one screenshot and present in the following one.
Other than that, we can probably iterate forever about details but I don't see any major missing/unexpected functionality, so I'll refrain from more comments for now ;)

Second minor comment: does args_schema_version only appear upon adding a valid JSON-Schema file? Otherwise I'm
confused about why it is missing in one screenshot and present in the following one.

The args_schema_version field appears only when an args schema file is selected. I did that to reduce the number of fields always visible to the user. The file is validated when the user clicks on the "Create" button though.

This looks great!!

Probably the top-menu "Single" label should read something like "Single task".

Agreed, "Single task" is good.
I'd also say this look like a very good improvement now. I'll run some local tests (hopefully tomorrow) to provide a final round of feedback and see if any behaviors are not as expected. We can always improve on it more later of course :)

Running task collection for the fractal-tasks-core package locally has quite a long delay between clicking "Collect" and the task collection section appearing below. I initially thought it wasn't working, but it just took a few seconds.
I remember that being a faster interaction. Any idea what could slow it down? It did appear faster when I then collected a second package with the section already present on the page

Besides this performance question, all looks good to me! Great improvement to the task collection interface and awesome that we reach feature parity here with the CLI client! And the new task list is much easier to keep an overview on!
And I can't always reproduce this performance issue exactly with e.g. different versions of fractal-tasks-core or with starting a fresh server and collecting again. Is it dependent on a response from pypi? I noticed that when I request a package that isn't available, I get a 422 error server side. This error is shown above the task collection, not as a failed task collection. Does the server do validation of the request before confirming it?
The thing I want to avoid: Users pressing task collection 3x, because "nothing is happening". If we want to keep the PyPI validation of package names (I can see that this is useful!), we can also address this by e.g. making the Collect button not clickable until we get a response from the server.

In some occasions I experienced slow responses for that endpoint too. We are checking with pip if the package exists and I think that slow responses might depend on PyPi repository server being temporary overloaded.
I can disable the button and add a small spinner inside it while the API call is in progress to improve the feedback to the user and avoid multiple clicks.

Great, let’s go with that then! :)

Ah, one last thing: Could we make the statuses on the task collection auto-update easily? I like the auto-updates on the job page, would be neat to have them here as well :)

After that, I'll stop adding requests to this PR and we can merge it & release Fractal web 0.7.1 :)

I implemented the task collection auto-update. Would you like also that the tasks table is refreshed when a task moves from installing to ok status?

I implemented the task collection auto-update. Would you like also that the tasks table is refreshed when a task moves from installing to ok status?

That would be very nice!

Just tested the spinner & the auto-updating, both are very nice!
If you also add the refreshing of the task list once a collection is done, let's merge that and release as 0.7.1 :)

I think we can also remove the refresh buttons from the tables. Do you agree?

If it auto-refreshes, then yes! :)

Done :)

Tested it. It's awesome!
Let's update the Changelog to represent the additional changes, merge and make this the 0.7.1 Fractal web release! :)


1.5

What's this PR do?
Refactor gem to only support v1.5
Where should the reviewer start?
Regaliator gem
How should this be manually tested?

Create a regaliator client with a valid configuration
Use the methods and everything should work as expected

Any background context you want to provide?
Implementing the same versioning system as rails (branching)
Questions:

Question 1

Consult works:
irb(main):001:0> c 37,<PHONE_NUMBER>
=> {"account_number"=>"5558150612", "biller_id"=>37, "bill_amount"=>659.0, "bill_amount_currency"=>"MXN", "fx_rate"=>0.01, "bill_amount_usd"=>65900.0, "bill_amount_chain_currency"=>65900.0, "payment_transaction_fee"=>3.0, "payment_total_usd"=>65903.0, "payment_total_chain_currency"=>65903.0, "invoice_number"=>nil, "invoice_date"=>nil, "name_on_account"=>nil, "due_date"=>nil}

Payment works:
irb(main):002:0> p 37,<PHONE_NUMBER>, 100.00
=> {"id"=>22658, "external_id"=>nil, "biller_id"=>37, "account_number"=>"5558150612", "bill_amount"=>100.0, "bill_amount_currency"=>"MXN", "fx_rate"=>0.01, "bill_amount_usd"=>5.25, "bill_amount_chain_currency"=>100.0, "payment_transaction_fee"=>3.0, "payment_total_usd"=>5.41, "payment_total_chain_currency"=>103.0, "chain_earned"=>2.33, "chain_paid"=>100.67, "starting_balance"=>9999991.28, "ending_balance"=>9999890.61, "hours_to_fulfill"=>48, "sms_text"=>nil, "created_at"=>"2017-10-17T21:47:03Z", "bill_amount_local_currency"=>100.0, "local_currency"=>"MXN"}

Account:
irb(main):003:0> Regaliator.account.info.data
=> {"name"=>"ElGranSuspiro", "balance"=>9999890.61, "minimum_balance"=>0.0, "currency"=>"MXN"}


Deprecated calendars

Currently there's an islamicc calendar that's accepted by Intl but is deprecated according to MDN:

Warning: The islamicc calendar key has been deprecated. Please use islamic-civil.

Furthermore, the spec currently describes a calendar named ethiopic-amete-alem while the current name of this calendar is ethioaa. If the intent of this proposal is to rename this calendar, then ethioaa will presumably join islamicc in being deprecated.
Should the spec enumerate these deprecated name(s) and describe how they should be handled?

islamic-civil is the BCP-47 canonical name of islamicc, and ethioaa is the BCP-47 canonical name of ethiopic-amete-alem.

Should the spec align to those canonical names? Currently it does not.


Bower Package Missing

I didn't find any bower packages of your project. Is there any reason for that?

IMHO, that's not quite the type of library you can expect to find on Bower. However, the project not being published and not having a bower.json file doesn't stop you from using it:
bower install git@github.com:RSamaium/CanvasEngine.git --save-dev
bower install git@github.com:RSamaium/RPG-JS.git --save-dev

In your HTML file:
<script src="bower_components/CanvasEngine/canvasengine-1.3.2.all.min.js"></script>
<script src="bower_components/RPG-JS/rpgjs-2.0.0.min.js"></script>

Aight, thank you very much.


Create Discussion tab feature

Right now everything has to be reported in issues creating the discussions tab will be helpful.

We really do not have the bandwith to tend to GH discussions right now, and we also have the telegram channels for any minor discussion, so for now I think we'll stay with issues—we can get to those faster, but I like the suggestion!
Closing for lack of appettite


error: 'tf.TensorListSetItem' op is neither a custom op nor a flex op while trying to quantize the model into int8

Hello,
I am trying to learn about quantization so was playing with a github repo trying to quantize it into int8 format. I have used the following code to quantize the model.
modelClass = DTLN_model()
modelClass.build_DTLN_model(norm_stft=False)
modelClass.model.load_weights(model_path)

converter = tf.lite.TFLiteConverter.from_keras_model(modelClass.model)
converter.experimental_new_converter = True
converter.optimizations = [tf.lite.Optimize.DEFAULT]
converter.target_spec.supported_ops = [
    tf.lite.OpsSet.TFLITE_BUILTINS,
    tf.lite.OpsSet.SELECT_TF_OPS
]

converter._experimental_lower_tensor_list_ops = False
converter.target_spec.supported_types = [tf.int8]
converter.representative_dataset = lambda: generate_representative_data(num_samples)

tflite_model = converter.convert()

with open('saved_model.tflite', 'wb') as f:
    f.write(tflite_model)

And for the representative data, I have converted the data into numpy, saved them as .npy and then used the following code to use them as representative data.
But after I run the code I get the following error:

error: 'tf.TensorListSetItem' op is neither a custom op nor a flex op

I have tried to follow the doc and some github issues like https://github.com/tensorflow/tensorflow/issues/34350#issuecomment-579027135 and also went through a similar question Issue with tf.ParseExampleV2 when converting to Tensorflow Lite : "op is neither a custom op nor a flex op"
But none of those seemed to be helpful in my case.
Can anyone help me figure out what I am doing wrong? Thanks in advance.
I am adding the full error in my first comment.

The full error:
error: 'tf.TensorListSetItem' op is neither a custom op nor a flex op
error: failed while converting: 'main':
Some ops are not supported by the native TFLite runtime, you can enable TF kernels fallback using TF Select. See instructions: https://www.tensorflow.org/lite/guide/ops_select
TF Select ops: Angle, Exp, IRFFT, TensorListReserve, TensorListSetItem, TensorListStack
Details:
        tf.Angle(tensor<?x?x257xcomplex<f32>>) -> (tensor<?x?x257xf32>) : {device = ""}
        tf.Exp(tensor<?x?x257xcomplex<f32>>) -> (tensor<?x?x257xcomplex<f32>>) : {device = ""}
        tf.IRFFT(tensor<?x?x257xcomplex<f32>>, tensor<1xi32>) -> (tensor<?x?x512xf32>) : {device = ""}
        tf.TensorListReserve(tensor<2xi32>, tensor<i32>) -> (tensor<!tf_type.variant<tensor<?x128xf32>>>) : {device = ""}
        tf.TensorListSetItem(tensor<!tf_type.variant<tensor<?x128xf32>>>, tensor<i32>, tensor<?x128xf32>) -> (tensor<!tf_type.variant<tensor<?x128xf32>>>) : {device = "", resize_if_index_out_of_bounds = false}
        tf.TensorListStack(tensor<!tf_type.variant<tensor<?x128xf32>>>, tensor<2xi32>) -> (tensor<?x?x128xf32>) : {device = "", num_elements = -1 : i64}

Traceback (most recent call last):
  File "/home/palak/Projects/Personal_Projects/integration/main.py", line 50, in <module>
    tflite_model = converter.convert()
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/lite.py", line 1139, in wrapper
    return self._convert_and_export_metrics(convert_func, *args, **kwargs)
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/lite.py", line 1093, in _convert_and_export_metrics
    result = convert_func(self, *args, **kwargs)
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/lite.py", line 1601, in convert
    saved_model_convert_result = self._convert_as_saved_model()
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/lite.py", line 1582, in _convert_as_saved_model
    return super(TFLiteKerasModelConverterV2, self).convert(
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/lite.py", line 1371, in convert
    result = _convert_graphdef(
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/convert_phase.py", line 212, in wrapper
    raise converter_error from None  # Re-throws the exception.
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/convert_phase.py", line 205, in wrapper
    return func(*args, **kwargs)
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/convert.py", line 984, in convert_graphdef
    data = convert(
  File "/home/palak/Projects/Personal_Projects/integration/integration_test/lib/python3.10/site-packages/tensorflow/lite/python/convert.py", line 366, in convert
    raise converter_error
tensorflow.lite.python.convert_phase.ConverterError: Could not translate MLIR to FlatBuffer.  See instructions: https://www.tensorflow.org/lite/guide/ops_select
TF Select ops: Angle, Exp, IRFFT, TensorListReserve, TensorListSetItem, TensorListStack
Details:
        tf.Angle(tensor<?x?x257xcomplex<f32>>) -> (tensor<?x?x257xf32>) : {device = ""}
        tf.Exp(tensor<?x?x257xcomplex<f32>>) -> (tensor<?x?x257xcomplex<f32>>) : {device = ""}
        tf.IRFFT(tensor<?x?x257xcomplex<f32>>, tensor<1xi32>) -> (tensor<?x?x512xf32>) : {device = ""}
        tf.TensorListReserve(tensor<2xi32>, tensor<i32>) -> (tensor<!tf_type.variant<tensor<?x128xf32>>>) : {device = ""}
        tf.TensorListSetItem(tensor<!tf_type.variant<tensor<?x128xf32>>>, tensor<i32>, tensor<?x128xf32>) -> (tensor<!tf_type.variant<tensor<?x128xf32>>>) : {device = "", resize_if_index_out_of_bounds = false}
        tf.TensorListStack(tensor<!tf_type.variant<tensor<?x128xf32>>>, tensor<2xi32>) -> (tensor<?x?x128xf32>) : {device = "", num_elements = -1 : i64}

https://github.com/SaneBow/PiDTLN

Hello @StuartIanNaylor . Thank you for your reply. But I am not sure how this helps in my case. Will you please explain me if possible? Sorry for the inconvenience.

Hello @StuartIanNaylor . Thank you for your reply. But I am not sure how this helps in my case. Will you please explain me if possible? Sorry for the inconvenience.

Kudos to the cool tool tflite2tensorflow made by PINTO0309. I used it to convert DTLN-aec tflite models to quantized version.
Quantised models here using pinto's tools as quantising was problematic
https://github.com/SaneBow/PiDTLN/tree/main/models


Ramone/remix deploy

Added new section for Remix deployment and interaction with smart contracts

@Ramone-HL This is the error

17:15:12.928 | Executing user command: bash ./ci/build.sh
-- | --
17:15:12.938 | bash: ./ci/build.sh: No such file or directory

Can you rebase git rebase origin/main?

Yes, I agree that without having the actual EONWorkspace that contains the
example .js files the value of this work is diminished. John Camardo is
aware of this and said it is not needed to illustrate the smart contract
interaction. Once the gist link is created for the EONWorkspace, we can
revise the document.
Thanks,
Ramone
[image: Horizen Labs] https://horizenlabs.io/
www.horizenlabs.io https://horizenlabs.io/
Ramone EspanolTechnical Writer
Office Locations:
New York, NY
Milan, Italy
Discord: Ramone#6136
[image: Twitter] https://twitter.com/horizenlabs [image: LinkedIn]
https://www.linkedin.com/company/horizenlabs/ [image: Facebook]
https://www.facebook.com/Horizen-Labs-271089196878308/
On Tue, Apr 11, 2023 at 9:43 AM Yuriko Inaba @.***>
wrote:

@.**** commented on this pull request.
In docs/deploy.md
https://github.com/HorizenOfficial/evm-documentation/pull/52#discussion_r1163082819
:

+If any issues arise, the Remix IDE will provide a status notification before confirming the operation.
+
+
+
+3. In the expanded function (setP), enter a desired value in the value field.
+

Note: Initially, the fields, setP and setNP display uint256. This indicates that it is expecting an unsigned integer (256 bit) type to store non-negative integers.

+4. Click transact. The Terminal panel displays a success status for the interaction with your smart contract.
+
+
+
+### Interaction with Sample Contract
+
+To illustrate interaction with smart contracts, the EonWorkspace is created in Remix. This workspace provides a set of script files to perform specific tasks, such as displaying information or executing a transaction within the blockchain.
Sounds good @Ramone-HL https://github.com/Ramone-HL .
Do you know when we can be expecting that? Without it, referencing the .js
files doesn't have much value.
Could you also add a ticket to track this work? Both for the link and
updating to the docs
—
Reply to this email directly, view it on GitHub
https://github.com/HorizenOfficial/evm-documentation/pull/52#discussion_r1163082819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY5REHGTXAN6X6BQBLMTPTTXAWC37ANCNFSM6AAAAAAWV4S7XY
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
The information contained herein may be confidential and privileged
attorney-client information or work product intended only for the
individuals or entity to whom it is addressed. Any unauthorized use,
distribution or copying of this communication is strictly prohibited. If
you have received this communication in error, please notify me immediately.


Tool - Helm : Webapi is not connecting with patroni database.

https://helm-digital-journeys.apps.silver.devops.gov.bc.ca/
On above new server we are not able to test form, It fail with 500 error.
Project: e66ac2-test
On Patroni it has below error message.
2024-01-08 18:14:54.192 UTC [1700975] FATAL: password authentication failed for user "app"
2024-01-08 18:14:54.192 UTC [1700975] DETAIL: Password does not match for user "app".
On Webapi pod we can see the same error.
connection to server at "patroni" (<IP_ADDRESS>), port 5432 failed: FATAL: password authentication failed for user "app"

@bhumin-fw  Changed the "app" user password in the web api config map to match up with the password defined in Patroni Statefulset. Api logs look fine so far. Please validate.

Looks good Kunal. We can close this ticket. Thanks for the quick fix on it.


Bump dependencies to handle security alerts

Might need to swap rollup-plugin-uglify with rollup-plugin-terser

done


Simple Review Pipeline (Server)

Motivation and context
The pull request introduces simple validation pipeline to annotations quality control and some basic features for that

New REST API endpoints:
DELETE /api/v1/reviews/<review_id>
POST /api/v1/reviews
DELETE /api/v1/issues/<issue_id>
GET /api/v1/issues/<issue_id>/comments
PATCH /api/v1/issues/<issue_id>
POST /api/v1/comments
PATCH /api/v1/comments/<comment_id>
DELETE /api/v1/comments/<comment_id>
GET /api/v1/jobs/<job_id>/issues
GET /api/v1/jobs/<job_id>/reviews
How has this been tested?
Not tested yet
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage decreased (-0.04%) to 60.585% when pulling adf3f892cfe1c8006b49b5a88d56d237045a50b8 on bs/review_pipeline into df2dcc0209e899fbd83b001e0afa86af5c48c81e on develop.

May I know when this feature will be available?

May I know when this feature will be available?
Is there any way I can try this feature?

You can try the feature building cvat from the branch bs/review_pipeline_2

May I know when this feature will be available?

Is there any way I can try this feature?

You can try the feature building cvat from the branch bs/review_pipeline_2

I tried the review_pipeline_2 build (yesterday), and faced an issue that , in the review mode, after provide the comments on frame A then move to the next frame and return back frame A, the comments disappear. I need to switch to standard view and switch back to review view to have those comments visible again...
Please try those steps to see if it's a valid issue.

May I know when this feature will be available?

Is there any way I can try this feature?

You can try the feature building cvat from the branch bs/review_pipeline_2

I tried the review_pipeline_2 build (yesterday), and faced an issue that , in the review mode, after provide the comments on frame A then move to the next frame and return back frame A, the comments disappear. I need to switch to standard view and switch back to review view to have those comments visible again...
Please try those steps to see if it's a valid issue.

Thanks for the report, looks like a small code issue. I will fix it

Additionally, it would be great if we can support shortcut - pressing N for a new issue/comment.
Current behavior is to click the issue icon and select the shape then click again the icon for next shape..

@s3298230
Done.

@bsekachev , let's discuss REST API design principles which are described in the PR: https://github.com/openvinotoolkit/cvat/pull/2427. I will vote to finalize them and use in the PR.

DELETE /api/v1/reviews/<review_id>. It is OK.

DELETE /api/v1/issues/<issue_id>. It is OK

POST /api/v1/issues/<issue_id>/comments/create. It should be POST /api/v1/comments.

PATCH /api/v1/issues/<issue_id>/resolve. It should be PATCH /api/v1/issues/<issue_id>.

PATCH /api/v1/issues/<issue_id>/unresolve. It should be PATCH /api/v1/issues/<issue_id>.

GET /api/v1/issues/<issue_id>/comments. It should be GET /api/v1/comments?issue=id (but it is OK with the current REST API design).

PUT /api/v1/comments/<comment_id>. Do you really need PUT or PATCH is enough?

PATCH /api/v1/comments/<comment_id>. It is OK.

DELETE /api/v1/comments/<comment_id>. It is OK.

GET /api/v1/jobs/<job_id>/issues. It should be GET /api/v1/issues?job=id (but it is OK with the current REST API design).

GET /api/v1/jobs/<job_id>/reviews. It should be GET /api/v1/reviews?job=id (but it is OK with the current REST API design).

GET /api/v1/jobs/<job_id>/reviews/summary. Probably it should be removed.

POST /api/v1/jobs/<job_id>/reviews/create. It should be POST /api/v1/reviews.

@nmanovic

PUT /api/v1/comments/<comment_id>. Do you really need PUT or PATCH is enough?

Actually it was auto generated with mixins.UpdateModelMixin

GET /api/v1/jobs/<job_id>/reviews/summary

Do not we need to have review summary feature on UI? I explained why we should not perform this logic client-side requesting all the reviews above. Or do you believe it doesn't matter?
Will try to fix others.

@nmanovic

PUT /api/v1/comments/<comment_id>. Do you really need PUT or PATCH is enough?

Actually it was auto generated with mixins.UpdateModelMixin

Need to have only PATCH in the case. Please find a workaround. I believe in the past I already did something similar. Probably you can list which methods are supported by a view.

@nmanovic
Updated, new list of methods in description.

HI, when this feature will be available

@nmanovic Can we merge the PR?

@bsekachev , I will do that today if I don't see any other issues.

https://github.com/opencv/cvat/pull/2338#issuecomment-728863618

Do not we need to have review summary feature on UI? I explained why we should not perform this logic client-side requesting all the reviews above. Or do you believe it doesn't matter?

Hi @bsekachev ,
Is this the UI connected to the review pipeline mentioned above?

If we consider the above image as the UI for reviewing. The reviewer will go through the image in case they find any issues in an image they will mark the issue and reject the whole job. This might be fine for the case when only one person is reviewing a part of the data (referred as a job in cvat), i.e. not crowdsourced.


endeavouros_small

Description
"_small" variant logo for EndeavourOS
Features

Issues
TODO

sorry... trying to figure out how to submit my addition.


how can I adapt maml on my own environment?

Hi, thanks for your excellent work!
I want to know how can I adapt maml on my own environment, is there any methods that I must add in my env class, such as sample_tasks, reset_tasks?

Thank you for the kind words. You can use this code on your own environments, and indeed the only thing necessary is to add a sample_tasks and reset_tasks to your Gym environment.


#84: style the component library

resolves #84
wip screenshots

@rymorgan I'll post screenshots here of my WIP on this

@rymorgan I need styles for what links, hover links, other type stuff should look. Should I just pull them from the docs site style guide?

@aldeed Do you know why the CSS class name numbers randomly change? For example, .rsg--header-11 changed to .rsg--header-29 or some other number, after I refreshed. It makes it hard to overwrite the CSS.
Or should I be overwriting the CSS somewhere else?

@machikoyasuda I think for those you may have to use the styles object described here: https://react-styleguidist.js.org/docs/cookbook.html#how-to-change-styles-of-a-style-guide
They are from React components that use JSS. You can either overwrite the whole component (which may eventually have to do for some) or you can overwrite just some styles in styleguide.config.js in styles object. This seems a bit annoying to me because you need to restart the app whenever you change that file.
It's not very well documented, so you might have to use React devtools browser extension to see what the component names are and then find them in the codebase in GitHub. Hopefully most of what you need to change can be done in the theme, though.

@aldeed @rymorgan  So far :point

@machikoyasuda As long as you git remove and gitignore everything in styleguide/reaction-component-library before merging, I'm fine with merging this whenever you and Ryan think it's ready.

Considering it is iteration 1, and it's not public, I think we can merge now as well.

@aldeed I renamed the build folder to dist, and it's getting git-ignored correctly 👍

:tada: This PR is included in version 0.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Glob patterns ending in '/' work differently inside and outside joins

Via slack:
"If I run pachctl glob file A@master:/(*) and then pachctl glob file A@master:/(*)/, though, they both return the same thing, which implies that /(*) and /(*)/ are equivalent."
However, when using /(*)/ as a capture pattern to join two inputs, we see the cross of the two repos rather than the inner join.

It's probably out of scope for the current PR, but I was curious about how users can debug joins. Their description of the bug was that a cross happened instead of a join, which was really a join on the empty string. It seems like both the key being the empty string and multiple data (do we say datums?) from one input having the same key could be clues to something being broken - could it make sense to validate/warn on one of these conditions, or expose some way (unless there already is one) to see the capture results, like an extra --joinOn argument` to glob?

I was the one who raised this in Slack.
I couldn't tell what seemed to be going on until I ran pachctl inspect job and saw the datums that were getting worked on and did some math to figure out where it may have got the total number of datums.
Being able to use pachctl glob and see just one datum instead of all files matched would help for debugging issues like this.
Possibly something like pachctl glob file --random-datum "iccat_by_date@master:/(*)/:$1" "hycom_sst@master:/(*)/:$1" for debugging joins.

@jdoliner I believe you and I discussed expanding list datum to include functionality like what @abkfenris is talking about above. Not sure if this would replace glob completely or not.  I see a note in #3709, but don't see any issue/rfc that came from it.


Custom downloads layout changes

Type

[x] Bug fix
[x] New feature
[x] Improvement to existing feature

Related JIRA Issue(s)

Incorporate species selector into custom download:
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-155

Replace results preview with attributes accordion and remove tab buttons
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-356

Introduce result cards in the preview downloads screen
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-358

Display selected filters in the permanent block after folding the accordion
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-359

Description

Update the UI to match the new design provided by Andrea
Incorporated the species selector
Fixed on minor bug with the Accordion shared component

Views affected
Custom Downloads

A general remark: the two columns of content in Custom download are positioned using position: absolute in a zero-height container, which does not look like a very good layout technique choice. Display: grid will more robustly represent the layout intention here. Perhaps even display: flex could do the job.

Don't know if this should be changed specifically in this PR, but I do think this should be changed.

A general remark: the two columns of content in Custom download are positioned using position: absolute in a zero-height container, which does not look like a very good layout technique choice. Display: grid will more robustly represent the layout intention here. Perhaps even display: flex could do the job.

I've updated it to use grid.


[Swift 4.2] Update K-Means

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description
Contribution to issue #748

K-Means doesn't have a Playground, so I only updated the Tests.xcodeproj to Swift 4.2
Using Double.greatestFiniteMagnitude instead of DBL_MAX
Updated Tests.xcodeproj with the Xcode's suggested configurations and added IDEWorkspaceChecks.plist file

Thanks for the update 💯


Cluster points

Many points are at exactly the same zip code. We'll need to deal with this on a UI level, either by clustering with markercluster or mapbox gl js clustering.
Current tactic has been Leaflet, because it's easier for interactivity. Going to give markercluster a shot.

Done - clustering points with MarkerCluster.


Add macOS plugin.

I added a first version of a macOS plugin.
Basically its a copy of the iOS plugin with the smallest adoptions for macOS.
It would probably make sense to reuse the same code for macOS, but I wanted to share something now.

Thanks!
I will take a look

hello! what is a status of this PR?

Linked to #106

Hey @schmidp  I tried adding:
NSUserNotificationAlertStyle: alert to my Resources/info.plist but my notifications are still acting as banners. Any idea why?
Thanks

Any new thoughts on this?

I've noticed that upon starting my app, I need to enter my password 3-5 times to unlock my keychain, and each time I'm selecting "always allow"

@mpfaff that is probably because you call the request to get the key from keychain 3-5 based on different keys? I store everything under one key in JSON to avoid this.

Yeah @mpfaff I got a POC working with go-flutter on MacOS (using go-keychain under the hood) and the reason is that, in my implementation, each key represents a different account as @maxisme suggested. What is weird though is that whenever creating a new key/value in the keychain, the flutter app is supposed to be the owner of it, hence not requiring the user to enter his keychain password to grant the app access to it (as from Apple documentation). Even weirder, it seemed during development that every time I made changes to the code and recompile, I had to re-enter my keychain password for every single key/value entry (no matter selecting "always allow") : I'm missing something out of the picture, like maybe rebundling code changes makes my app look like a different app to the OS ? By the way the policy I use when I manipulate the entries is kSecAttrAccessibleAfterFirstUnlock.

In case it helps other beginners like me :sweat_smile: I got some feedback from Flutter/Swift developers who actually confirm that, since I just develop locally as-is (using self-signed certificate under the hood probably), rebuilding the app makes it appear as a different app to the OS, hence why it asks the password after each code changes/recompiling. Solution for this is to sign the app with an Apple generated certificate.

Thank you for that solution @Roms1383

@mogol We can close this one since its code is very similar to #181 but with some breaking changes.


Checking the formatting _config.yml will report an error!

Have you checked that your issue isn't already filed?

[X] I read through FAQ and searched through the past issues, none of which addressed my issue.
[X] Yes, I have checked that this issue isn't already filed.

Bug description
First of all, I set [baseurl :] in _config.yml to empty, and deployed without error, but when I clicked on the name in the web page, it navigated to an error page, so I changed it to [baseurl :/], but in actions it would report an error.  Prettier Check 🔎 Run npx prettier . --check   npx prettier . --check   shell: /usr/bin/bash -e {0} Checking formatting... [warn] _config.yml [warn] Code style issues found in the above file. Run Prettier to fix. Error: Process completed with exit code 1. But the page opens without any problem, I want to know why? I want the page to open in actions without reporting errors.
How to reproduce the bug

Error messages and logs
Actions
Prettier Check 🔎
Run npx prettier . --check
  npx prettier . --check
  shell: /usr/bin/bash -e {0}
Checking formatting...
[warn] _config.yml
[warn] Code style issues found in the above file. Run Prettier to fix.
Error: Process completed with exit code 1.

What operating system are you using?
Mac
Where are you seeing the problem on?
Running locally without Docker
More info
No response

This is my github page : https://chenjunyan1.github.io/

baseurl should be set to empty, which looks like this:
baseurl:

You can check that by looking at the code of some of the sites generated from this template that have open source code.

About prettier errors, check our FAQ.