Create React App is broken by lack of default polyfills in Webpack 5

Edit by @jordansexton:
To anyone looking for a very good workaround right now, don't use Create React App. Just use the react-ui-starter or material-ui-starter projects with Parcel, or the nextjs-starter project with Next.js, save yourself a huge hassle, and get much faster builds with SWC instead of Babel.

Describe the bug
Broken build with CRA v5, unable to resolve modules.
To Reproduce
Steps to reproduce the behavior:

Initialize a new CRA project. npx create-react-app my-app-test
Install and use any wallet-adapter packages
See error

BREAKING CHANGE: The request './adapter' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

Solution
Relative imports must include a file extension to follow ESM strict mode requirements introduced in Webpack 5. It's valid typescript to include .js extensions as part of the import path 🤯 :
example.ts
import { Example } from './example.js';

compiles to
example.js
import { Example } from './example.js';

It's worth noting that yarn lint is also currently broken.

I discovered this when I started working on adding check for import extensions to eslint: https://github.com/solana-labs/wallet-adapter/commit/7b443655c9b8c196fa952a9cf904ba1e200f3e9d

I am facing similar issues in /packages/starter/react-ui-starter.
/Users/labstorus/Documents/github/torus/wallet-adapter/packages/core/base/lib/esm/signer.js 19:16
Module parse failed: Unexpected token (19:16)
File was processed with these loaders:
 *<EMAIL_ADDRESS> * ../../../node_modules/react-scripts/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|           ...sendOptions
|         } = options;
>         signers?.length && transaction.partialSign(...signers);
|         transaction = await this.signTransaction(transaction);
|         const rawTransaction = transaction.serialize();

Recommended solution seems to be:

You must use a .js extension in relative imports even though you're importing .ts files.

Full breakdown: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

It's worth noting that yarn lint is also currently broken.

🧐 this is unrelated. Fixed this by removing react-app/jest from material-ui-starter/package.json and react-ui-starter/package.json
 "eslintConfig": {
        "extends": [
             "react-app",
-            "react-app/jest"
        ]
    },

I'm experiencing this in a CRA v5 app as well.

I am facing the same issues and I am using node

Need to fix this asap

Linting and the starter projects are fixed thanks to @cogoo in #245.
This issue is otherwise blocked until Craco fully supports CRA 5 / Webpack 5 and we can configure Webpack to build with ESM modules that don't use .mjs extensions.
Until then, please use one of the starter projects that use Next.js or CRA 4. They work right now and don't require additional configuration.
Instructions to run the React UI + CRA4 starter project are here:
https://github.com/solana-labs/wallet-adapter#build-from-source

Any recommendation to those who have already started a project?  I'd rather not remake my project and just want to fix this to continue working

Nope, there's no good workaround at this time, sorry. CRA 5 is not supported.

It's relatively straightforward to take your code from your CRA 5 app and drop it into the CRA 4 based react-ui-starter project though.

fair enough, thanks

Hey guys, I got it to work. I uninstalled the libraries listed below and downloaded them again with these specific versions:
"@solana/wallet-adapter-base": "^0.7.1",
"@solana/wallet-adapter-react": "^0.13.1",
"@solana/wallet-adapter-react-ui": "^0.6.1",
"@solana/wallet-adapter-wallets": "^0.11.3",
<EMAIL_ADDRESS>"^1.31.0",
...
"react-scripts": "4.0.3",

@Malai237 you don't need to downgrade the packages to get this to work with CRA 4. The react-ui-starter project works out of the box with the latest versions of the packages using CRA 4.

Just published:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
These packages include #245 and should work with CRA4 / Craco.

Instructions to run the React UI + CRA4 starter project are here:
https://github.com/solana-labs/wallet-adapter#build-from-source

I was not able to get the starter projects to work.
Since there is a parent directory to the src directory, nothing works if you build the project and then move the src to your other project.  I don't want all the other stuff - literally just the front end app is what I want.
For example:
The instructions in https://github.com/solana-labs/wallet-adapter#build-from-source
Clone the project:
git clone https://github.com/solana-labs/wallet-adapter.git

Install dependencies:
cd wallet-adapter
yarn install

Build all packages:
yarn build

Run locally:
cd packages/starter/react-ui-starter
yarn start

Then I moved the react-ui-starter folder to my app, and it does not work, since it is dependent on the parent folder's node_modules

@Malai237 you don't need to downgrade the packages to get this to work with CRA 4. The react-ui-starter project works out of the box with the latest versions of the packages using CRA 4.

I can't even get this to work with CRA 4.  Jest tests break:
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export * from './useWalletModal';
                                                                                ^^^^^^

    SyntaxError: Unexpected token 'export'

So I have learned that the issue is specifically with WalletModalProvider breaking jest tests, even with CRA 4.  I have decided to just not use it and make my own UI.

Then I moved the react-ui-starter folder to my app, and it does not work, since it is dependent on the parent folder's node_modules

This is because of Lerna + Yarn workspaces linking the dependencies locally.
If you move react-ui-starter out of the project directory, run yarn install from the react-ui-starter directory. This should install the dependencies locally in the node_modules of that directory instead of hoisting them.

Jest tests break

What tests are you running? The only Jest tests that ship with this project right now are in the React package. This shouldn't affect your starter project running, right?

As for the Jest tests that ship with the React package, they run and pass:
➜  react git:(master) yarn test
yarn run v1.22.17
$ jest
...
Test Suites: 2 passed, 2 total
Tests:       45 passed, 45 total
Snapshots:   0 total
Time:        6.412 s
Ran all test suites.
✨  Done in 7.91s.

If you move react-ui-starter out of the project directory, run yarn install from the react-ui-starter directory.

I just did this and it works.

Perhaps we should configure the starter projects to disable hoisting since they are supposed to run standalone. Comes at the expense of initial install time, but maybe worthwhile?
cc @cogoo

Just to add my experience, the packages don't work with the latest Next.js version (12.0.7) in a project I created via CNA. Downgrading to Next.js 11 as used in the starter seems to have worked though. Next.js now uses SWC instead of webpack by default, so might this also be part of the problem? I'm not familiar with the details at all so please forgive me if this is a dumb question, but it seems like using mjs extensions for the esm exports has the broadest compatibility and resolves the issue, so is there a reason not to do that?

@gpoole https://github.com/solana-labs/wallet-adapter/issues/246 is probably related to the Next.js issue. I'm also not familiar with it and haven't tested with Next 12.

it seems like using mjs extensions for the esm exports has the broadest compatibility and resolves the issue, so is there a reason not to do that?

@cogoo you spent a good bit of time trying out different builds, wdyt?

@gpoole #246 is probably related to the Next.js issue. I'm also not familiar with it and haven't tested with Next 12.

it seems like using mjs extensions for the esm exports has the broadest compatibility and resolves the issue, so is there a reason not to do that?

@cogoo you spent a good bit of time trying out different builds, wdyt?

It looks like most bundlers are now enforcing strict ESM imports which are where the errors occur. To my knowledge the .mjs extension wouldn't help since the ESM build is picked up correctly. The issue is that we are not using full file paths for imports.
i.e. import { someModule } from './module needs to be import { someModule } from './module.js

I've mentioned this on #246 but I noticed in Next.js 12 just changing the extension to .mjs seemed to be enough. It looks like Next or maybe SWC is using esm loader which does say about its strict mode:

"strict" to treat only .mjs files as ESM.

So maybe that's it, or maybe I'm misreading. Looking around I noticed the Webpack docs say:

Imports in ESM are resolved more strictly. Relative requests must include a filename and file extension.

And the Node docs also say:

A file extension must be provided when using the import keyword to resolve relative or absolute specifiers. Directory indexes (e.g. './startup/index.js') must also be fully specified.

I wasn't familiar with this change. Sorry for the diversion!

I didn't originally understand your earlier comment about using ".js" for imports in ".ts" files @cogoo but now I realised that's the formal decision on how this is handled by TypeScript:

[code] will have to be rewritten to use the extension of the output of foo.ts - so bar.ts will instead have to import from ./foo.js.

I thought it was going to be fixed by a compiler option or something. Strange!

Unfortunately we tried changing the source code to do this, and it has a number of problems we don't have a good solution to yet. I think a better solution may be to find a way to output .mjs files in the ESM build, and also reference those extensions in the build, without modifying the TS source.

https://www.npmjs.com/package/typescript-esm looks promising

https://www.npmjs.com/package/typescript-esm / https://github.com/kristoferbaxter/typescript-esm looks promising

When you add the tsc-esm compiler following the conclusion of TypeScript's output, this compiler will remap all generated files to use '.mjs' extensions for locally resolved items and rename every output's extension to '.mjs'.

Sounds like what we want?

This looks like it will do the job! I'll play around with this today

https://www.npmjs.com/package/typescript-esm / https://github.com/kristoferbaxter/typescript-esm looks promising

When you add the tsc-esm compiler following the conclusion of TypeScript's output, this compiler will remap all generated files to use '.mjs' extensions for locally resolved items and rename every output's extension to '.mjs'.

Sounds like what we want?

Experimented with this. Unfortunately, it doesn't work out of the box. After installing the package, the lerna build script fails on the packages/starter/example repository;
lerna ERR! yarn run build exited 1 in '@solana/wallet-adapter-example'
lerna ERR! yarn run build stdout:
$ yarn clean && next build && next export
$ shx rm -rf .next out
info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
info  - Checking validity of types...
info  - Creating an optimized production build...
info  - Using external babel configuration from /Users/cogoo/LocalHost/GitHub/solana_projects/wallet-adapter/packages/starter/example/.babelrc.js
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run build stderr:
Failed to compile.

ModuleNotFoundError: Module not found: Error: Can't resolve '@solana/wallet-adapter-react-ui' in '/Users/cogoo/LocalHost/GitHub/solana_projects/wallet-adapter/packages/starter/example/pages'

> Build error occurred

I'll be more comfortable adding the extension manually (prebuild) as that's the accepted convention.
https://www.typescriptlang.org/docs/handbook/esm-node.html

I've seen that build error before, I don't know that it's related to this or unresolvable.
For the reasons we discussed before, I'm not comfortable with adding the extension to the source. It increases maintenance burden and eslint doesn't work for it yet. I'm also not convinced yet that this is a reasonable convention to follow when I haven't seen it used a single time in the wild.
I'll pick this up and work on it today.

#254 will fix this when merged.

Published:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
These packages now have strict ESM exports (.mjs files). This fixes Next.js 12-based projects which use Webpack 5 with strict ESM imports.
It doesn't fix CRA 5-based projects because of a semi-related issue: Webpack 5 doesn't include polyfills for Node.js APIs by default, so it breaks with buffer and crypto imports.
Even though this issue was about strict ESM imports, I'll leave it open until CRA projects work.

To anyone looking for a very good workaround right now, don't use Create React App. Just use the nextjs-starter project, save yourself a huge hassle, and get even faster builds with SWC instead of Babel.

The react-ui-starter and material-ui-starter projects have been updated to use Parcel instead of CRA.

Can anyone having trouble with the Solana wallet adapter and Create React App 5 patch in #264 and let me know if that solves your build issues? If you find another missing module, let me know what it is (paste in the build failure message if possible).
cc/ @cogoo, @Eliascm17, @Malai237, @dan-garay, @kevinforrestconnors

It appears as though the CRA team's position is pretty clear: if we depend on a package and that package is designed to work in the browser, then they must produce a browser build that does not depend on Node APIs.
Read more about this here: https://github.com/facebook/create-react-app/issues/11756#issuecomment-996464456
In the meantime, some are suggesting to monkey patch your CRA5 Webpack config using react-app-rewired to add the Node polyfills back: https://github.com/facebook/create-react-app/issues/11756#issuecomment-1013246173. This is slightly less nuclear an option than ejecting from CRA or downgrading to CRA4.

Thanks for digging into this @steveluscher. I think react-app-rewired for now, or Craco once it supports CRA 5, is probably the way to go.
To anyone following this issue, my current recommendation is still just to use Parcel if you want something quick and lightweight (e.g. without server side rendering, which most dapps don't need), or Next.js if you want something heavier (SSR, API functions, etc.)
I realize that's not very satisfying, but unless you are already using some of the distinctive features of CRA like service workers, Jest, etc. you may not need it right away, and a simpler tool can help you build what you want.

Any volunteers want to try out @steveluscher's promising solution @ https://github.com/solana-labs/wallet-adapter/pull/264#issuecomment-1015981946
Would love to know if this works for more people!

Any volunteers want to try out @steveluscher's promising solution @ #264 (comment)
Would love to know if this works for more people!

I'd be more than happy to test this, but I'm a bit ignorant to how. After I create-react-app, how do I install Steven's packages instead of "yarn add @solana/wallet-adapter-base ... etc." ?

@dewittalex thanks! @steveluscher probably has better advice than me, but I think if you build his branch from source and then locally reference the packages from your CRA app, it might work.
Maybe something like "@solana/wallet-adapter-react": "file:/../wallet-adapter/packages/core/react" for all the relevant packages you depend on?
And then you might want to use https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/ or something to make sure that the internal dependencies also resolve to those since the directory structure will be a bit weird.

Another option, actually -- stick your CRA package inside the starters directory of his branch after building it from source. Then you can run yarn from the base directory, and it should link your local dependencies without all that mess.

You can link local NPM packages and use them as though they're the published versions. See if you can get something like this working:
# Check out and build my PR
git clone https://github.com/steveluscher/wallet-adapter.git
cd wallet-adapter
git checkout polyfill-node-apis-for-webpack-5
yarn install && yarn build

# Link my PR's versions into your package manager
(cd packages/wallets/ledger && yarn link)
(cd packages/wallets/torus && yarn link)

Then go back to your project…
cd myproject
# Use the linked versions of these packages in your project
yarn link @solana/wallet-adapter-ledger
yarn link @solana/wallet-adapter-torus

And try to build.
You can unlink everything when you're done. Make sure to follow the instructions that appear.
yarn unlink @solana/wallet-adapter-ledger
yarn unlink @solana/wallet-adapter-torus

…or if yarn link doesn't understand how to propagate that package.json dependency down to the main project.

I sort of suspect that's true: https://github.com/yarnpkg/yarn/issues/2914#issuecomment-358055934
Maybe we should #yolo merge this, publish it, and see?

Published:

@solana/wallet-adapter-ledger => 0.9.3
@solana/wallet-adapter-torus => 0.11.4

Using these dependencies should fix the polyfill / CRA problems with no additional config required.
Huge thanks to @steveluscher for his heroic effort debugging and fixing this both here and in upstream projects.

(And if this doesn't fix all the CRA issues, at least we're a bit closer)

Reopened -- #264 has been reverted by #275. It looks like the polyfills may be breaking the Next and Parcel starters.

Maybe we should #yolo merge this, publish it, and see?

@steveluscher lol

@jordansexton What's holding #276 back from being merged in? I'm trying to do work in a repo where my coworkers and I are using Webpack 5 and this is blocking us from moving forward. There are manual fixes that we've tried that work but those are not satisfactory for shipping of course.

@TomLisankie thanks for understanding. #276 just needs to be tested before merging (I rushed to publish its predecessor #264 and broke all the packages) and I haven't had time to test it yet.

@TomLisankie thanks for understanding. #276 just needs to be tested before merging (I rushed to publish its predecessor #264 and broke all the packages) and I haven't had time to test it yet.

Got it, thanks.

Anyone have issue with latest wallet adapter with cra 4.0 ?
I am trying clone https://github.com/exiled-apes/candy-machine-v2-mint
then replace the wallet adapter with  "@solana/wallet-adapter-wallets": "^0.14.2"
and hit error below when run npm start
<EMAIL_ADDRESS>Can't import the named export 'BitKeepWalletAdapter' from non EcmaScript module (only default export is available)

been a month of not being able to properly use this

Can someone please document what the correct work around would be?

Anyone have issue with latest wallet adapter with cra 4.0 ?

See #265!

Published:

@solana/wallet-adapter-react => 0.15.3
@solana/wallet-adapter-example => 0.18.1
@solana/wallet-adapter-material-ui-starter => 0.13.1
@solana/wallet-adapter-nextjs-starter => 0.8.1
@solana/wallet-adapter-react-ui-starter => 0.9.2
@solana/wallet-adapter-ant-design => 0.11.3
@solana/wallet-adapter-material-ui => 0.16.4
@solana/wallet-adapter-react-ui => 0.9.5
@solana/wallet-adapter-bitkeep => 0.3.3
@solana/wallet-adapter-blocto => 0.5.3
@solana/wallet-adapter-clover => 0.4.3
@solana/wallet-adapter-coin98 => 0.5.3
@solana/wallet-adapter-coinhub => 0.3.3
@solana/wallet-adapter-ledger => 0.9.5
@solana/wallet-adapter-mathwallet => 0.9.3
@solana/wallet-adapter-safepal => 0.5.3
@solana/wallet-adapter-slope => 0.5.3
@solana/wallet-adapter-solflare => 0.6.3
@solana/wallet-adapter-solong => 0.9.3
@solana/wallet-adapter-tokenpocket => 0.4.3
@solana/wallet-adapter-torus => 0.11.6
@solana/wallet-adapter-wallets => 0.14.3

Please try these packages using CRA 5! And huge thanks to @steveluscher for your tireless work on this.

Amazing! Thanks

This is fixed via #299 but you'll need to use react-app-rewired with config here to do the polyfills correctly. See the new create-react-app-starter project. The key parts are the config-overrides.js file and npm:process dependency.
The core issue is that the Torus and Ledger JS libraries don't correctly polyfill and incorrectly use globals, and this isn't handled by Webpack 5 without additional configuration, which you can't add with CRA5 alone. We use react-app-rewired to override, as Craco doesn't support CRA5 yet.
Published:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

@jordansexton  thanks for all of this. I took my CRA project and just copied over the releveant parts from the package.json (devDependencies) and config.json into my existing project and all is well

I got the error message
<EMAIL_ADDRESS>Can't import the named export 'BitKeepWalletAdapter' from non EcmaScript module (only default export is available)
Sorry I didn't find the right solution，Tried the upgrade version to no avail， Can someone tell me how to fix it， thanks

Did anyone manage to fix this issue?
<EMAIL_ADDRESS>Can't import the named export 'AnimationMode' from non EcmaScript module (only default export is available)

working with solana has been the worst experience of my programming life


Uncaught TypeError: Cannot read property 'fps' of undefined

With the last version of the library (https://github.com/liabru/matter-js/blob/master/build/matter.min.js), when I run the engine, I always get the following error in the console:
Uncaught TypeError: Cannot read property 'fps' of undefined
every single frame of the animation. The message is only visible when I render the engine with the flag showDebug: true, so it is not fatal, but still annoying. Anybody knows the reason?
Thanks,
Jesús

Well, I don't know exactly how to fix it, but I see that in commit dcdc43d475879f73681a139f03edaa2968f39823 the fps attribute was moved from the Engine class to the Runner class.
As of df5f16ca5f16ab2aabf71641341823f88dd15490 the error is on line 269 of src/render/Render.js:
text += "fps: " + Math.round(metrics.timing.fps) + space;

where metrics is defined as var metrics = engine.metrics
Apparently Render.debug needs to be updated to use Runner.fps instead.

What's confusing is that when you run the demo it works just fine. But after a bit of spelunking I found this on line 81 of demo/js/Demo.js:
// pass through runner as timing for debug rendering
demo.engine.metrics.timing = demo.runner;

So the demo code hacks its way around the problem by passing in a reference to the runner.

Really it seems that the only problem here is that Render.debug is trying to display information it has no business knowing about. Since the game loop is decoupled from the engine, it should be the programmer's job to display an FPS counter if they want one, since they're in charge of driving the game loop themselves.
I propose that the fps counter simply be removed from Render.debug in the release version.

fa86527302e43a082ee3a1305c7d8b24fe9c0045

Looks like I didn't properly maintain backwards compatibility when I refactored this.
I've added a check that should prevent this error.
@anthropomorphic you're right about this and it's something I hope to address when I get around to working on decoupling the renderers, but this should at least prevent the errors for the time being


Q: Where does the theme store completion status icons?

...and, is it possible to change them? Set an icon for an added (custom) completion status?
Thanks!

The icons are part of the font used by Playnite, you can change them only by editing the constant file in the theme installation folder.
The lines where it can be changed are:
Constants.xaml
The font can be downloaded here, and from windows charmap you can copy to the file.
icofont

Thank you for the quick response! That's perfect.


Pass selector project level to .apos-area-widget-wrapper

It would be helpful to be able to pass a project level selector to .apos-area-widget-wrapper so that you could use CSS adjacent sibling selectors for area/widget layouts.
https://github.com/punkave/apostrophe/blob/cf79201825bd11d23adaa31d8278d520c73ab182/lib/modules/apostrophe-areas/views/widget.html#L5

We had an ask for this at one point
https://github.com/punkave/apostrophe/pull/952/commits/5fc84163617434f03839753e25518525101a8cde

Was there a reason why we opted for not implementing?

See also #1162


[GOAL] Pass 100+ Ecommerce Components

The aim is to pass 100+ ecommerce components by December. As can be seen here https://www.hyperui.dev/api/stats the ecommerce component offering is lacking.
I'll use this issue as a dumping ground for ideas and progress tracking.

[x] Product Cards (Update)
[x] Product Cards (New)
[x] Collection Cards (New)
[x] Product Collections (Update)
[x] Carts (Update)
[ ] Carts (New)
[x] Checkouts (Update)
[x] Quantity Inputs

OK, so it's looking like 100+ won't be reached by December, but 75+ could/should be doable.

I've merged in #213 which added 51 components, this bring the number of ecommerce components to... 🥁

😶

Hi @markmead !
75+ still looks doable.
I'd love to contribute to the same.
If I'm reading the issue right, the project is lacking components for the cart in the e-commerce section.
But what's with Carts (Update) and Carts (New)? What is it about?
Once I have a clear vision of this, I'd start working on designing and developing new components.

Hi @ishaanbedi 👋
It's not doable as we're now in December and the goal was by December.
It was lacking ecommerce components in general but that has been improved. I've used the checkboxes to track what needs to be done, therefore, it is showing that new cart components have not been added.

@markmead: It's not doable as we're now in December and the goal was by December.

Ah, my bad! I skim-read it to be by end of December, so sorry for that.
By the way, I've designed a full screen cart component, but due to the implication of styling rule container: flex justify-center p-8 in ecommerce-carts.mdx, I'm unable to make it stretch throughout the component box.
Can you please help me with it so that I can proceed with the PR for the same?
Should I open an issue/discussion for it so future contributors can also benefit from there?

Hi @ishaanbedi 👋
Not a problem! That's easy to do, if you look at this - https://raw.githubusercontent.com/markmead/hyperui/main/src/data/components/marketing-popups.mdx
You can see that the container can be overridden at a component level. I usually do container: relative when it needs to be full width.

It needs to be a PR if you want me to review it @ishaanbedi


refactor: rewrite DAPI Client from the scratch

Issue being fixed or feature implemented

Messy code with on  huge class-monolith and mess/bugs in the tests slows down Client testing and development
In some cases, we need more flexible connection strategies (i.e. connect to specific node)
Retry logic exclude IPs only for the current retry session and don't keep ban status for further request
Light client implementation requires pluggable and reusable DML logic
DAPI Client doesn't provide default configuration for connection options (the seeds option is required)

What was done?

[x] Introduced flexible connection logic with DAPI Address providers
[x] Reworked MNDiscovery logic to DMLAddressProvider
[x] Introduced dependency injection for better testing and flexibility
[x] Simplified transport logic: removed the transport manager and additional instances of GrpcTransport
[x] Improved retry logic: keep ban state for the further request and exponentially increment ban time in case of repeated failures
[x] Updated npm dependencies

How Has This Been Tested?

With integration and unit tests.
Breaking Changes

DAPIClient options are changed
Core and Platform methods moved to specific namespaces (ie. client.platform.getIdentity())

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

@shumkov What do you think about adding https://www.npmjs.com/package/eslint-plugin-jsdoc while doing this refactoring? Too much maybe :man_shrugging: Just a thought :slightly_smiling_face:

@thephez done

Wow ! Exciting and clean !
And finally, seeds 🥳


GitHub CI/CD

[x] Automatic Worker(s) deployments on main branch
[ ] Complete testing on every PR and all branches
[ ] Port all Secrets and ENV into new repo

Should be amazing if Cloud flare has the possibility to deploy to "cloud flare pages" using GitHub actions

It does! Cloudflare Pages will be added in Phase 2 (#2) and we'll make use of the Pages integration then, but going to rely on GitHub Actions until that point.

Hang on wait, you can CI in GH Actions and push to pages w/o using CF's CI?

No, there's no Pages integration at all until Phase 2.

sorry for hijacking, but not talking about this project at all. Just missed the memo where CF Pages no longer requires you to use their ci, so commented about that 😞

All good, but Pages doesn't accept raw file uploads yet. I'm just saying that all CI/CD stuff is going to happen within GitHub Actions until Phase 2, because Phase 2 adds a client/UI layer, which will prompt the Pages integration and its GitHub installation.

hey there, just checking if there are any updates on ETA for phase 2.  thx


Update generate-version-info.sh

Issue #, if available:
It seems like install-worker makes kubelet and aws only accessible to the root user. When running this packer build as ec2-user, I get the following errors.
2024-01-03T12:23:22-05:00: ==> amazon-ebs: Provisioning with shell script: /Users/varun.shivakumar/code/fedramp/ami/packer-al2/scripts/generate-version-info.sh
2024-01-03T12:23:23-05:00:     amazon-ebs: /home/ec2-user/script_9031.sh: line 19: /usr/bin/kubelet: Permission denied

2024-01-03T12:32:11-05:00: ==> amazon-ebs: Provisioning with shell script: /Users/varun.shivakumar/code/fedramp/ami/packer-al2/scripts/generate-version-info.sh
2024-01-03T12:32:13-05:00:     amazon-ebs: /home/ec2-user/script_1670.sh: line 26: aws: command not found

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

What base AMI are you using?

Looks like this is a duplication of PR: #1513
https://github.com/awslabs/amazon-eks-ami/pull/1513

What base AMI are you using?

I'm using this AMI: CIS Amazon Linux 2 Benchmark - Level 2
https://aws.amazon.com/marketplace/pp/prodview-wm36yptaecjnu


Implementing progress bar

Fixes #9
This pull introduces/changes:

A progress bar for downloads
Removed httparty dependency, replaced with open-uri

Pings:
@cheerfulstoic
@subvertallchris

It fails also on master, I think 😞
However, here's a preview!

Hrmmm, I wouldn't be surprised if the failures were just issues with the specs.  They were kind of difficult to get working in the first place.
Exciting about removing the progress bar and the dependency on httparty though!

@cheerfulstoic should I fix them? They fail on master as well... Maybe I should open a new PR for it.

Exciting about removing the progress bar and the dependency on httparty though!

What do you mean for removing the progress bar?

You're welcome to look into fixing the specs, though you don't have to spend a lot of time on it ;)  Happy to have that as part of the PR.  I'd also be happy to merge the PR if the specs are failing in the same way as on master (though obviously that's not ideal).
And I think I meant to say "adding the progress bar" ;)

@cheerfulstoic I fixed the specs! It was easier than I though
However, if it's ok for you, please merge 😉

Released as 0.6.0!  Thanks!


Updated imported docs with ./update-imported-docs.sh

With https://github.com/kubernetes/kubernetes/issues/35203  in I was able to update the imported docs accordingly, to address 2nd part of the problem from #1439, about api-reference.
@wernight @erictune fyi, since you asked about it
@janetkuo || @devin-donnelly ptal

This change is

Rebased. @devin-donnelly are we good with having this in?


SQL*Plus: Add SHOW EDITION support

In addition to the existing SHOW commands

This has now been implemented.


New version: LinwoodCloud.Butterfly.Nightly version 2.1.0-rc.2

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

2024-05-06 07:09:50.807 [REPO] Failed to open available source: msstore
2024-05-06 07:09:58.384 [REPO] Failed to open available source: msstore
2024-05-06 07:09:59.305 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.38.33135.0

(Automated response - build 880.)


rust-analyzer panics when trying to add import

When I try to add a missing import using the quick fix in VS Code, i.e. clicking on the light bulb and clicking Import std::borrow,
nothing happens.
The expected behaviour would be that the import is added at the top of the file.
When I look at the language server output, I can see that a panic occurred:
thread '<unnamed>' panicked at 'can't resolve local ptr to SyntaxNode: SyntaxNodePtr { range: 3242..3515, kind: FN }', crates/syntax/src/ptr.rs:32:2

Full Rust Analyzer output
This happens with the nightly version: 80bee14e1 2021-04-30 nightly

Could you share more details, some example/project where that is reproducible?
I'm trying to trigger the import on a sample project this way:

and it works for me, adding an import.

It is reproducible with the following project: https://github.com/Tiwalun/probe-rs/tree/rust-analyzer-crash-repro-8700
The error happens on the following line:
https://github.com/Tiwalun/probe-rs/blob/17b3bc0bfa9539738d920ca99a5ff995f6204481/probe-rs/src/architecture/arm/core/m33.rs#L143

When I try to add the import, the file is unchanged, and the panic output can see in the Rust Analyzer output.
I will try to see if I can find a smaller example.

Can reproduce it, thank you.
Minimized example:
pub trait CoreInterface {
    fn reset_and_halt(&mut self);
    fn step(&mut self);
}

pub struct M33;

impl CoreInterface for M33 {
    fn step(&mut self) {
        todo!()
    }

    fn reset_and_halt(&mut self) {
        String::from("dsds").borrow();
        todo!()
    }
}

fn main() {}

The actual culprit is not the import assist, but the reorder_impl one that's responsible for the "Sort methods" menu item on the screenshot, full trace show that:
thread '<unnamed>' panicked at 'can't resolve local ptr to SyntaxNode: SyntaxNodePtr { range: 185..276, kind: FN }', crates/syntax/src/ptr.rs:32:28
stack backtrace:
   0: _rust_begin_unwind
   1: std::panicking::begin_panic_fmt
   2: syntax::ptr::SyntaxNodePtr::to_node::{{closure}}
   3: syntax::ptr::SyntaxNodePtr::to_node
   4: ide_assists::assist_context::AssistBuilder::make_mut
   5: ide_assists::assist_context::Assists::add
   6: ide_assists::handlers::reorder_impl::reorder_impl
   7: ide_assists::Assist::get
   8: ide::Analysis::assists_with_fixes::{{closure}}
   9: std::panicking::try
  10: ide::Analysis::assists_with_fixes
  11: rust_analyzer::handlers::handle_code_action_resolve
  12: <F as threadpool::FnBox>::call_box

I see two issues here:

rather weird, that we resolve other assists but the import one after selecting the import-related menu item: we need to apply the import assists and that's it
the actual issue with the reorder_impl assist that's unable to find the syntax node pointer for some reason

Not sure what's happening in both issues, but the last one seems to be related to rowan, so CC @matklad just in case.

Regarding point 2 the problem is that we mutate the ast while we are trying to traverse it, traversing happens with make_ast_mut call by mapping the nodes to their mutable countparts here: https://github.com/rust-analyzer/rust-analyzer/blob/e1bef531095f152649a7e20e992cf97ba6b3f990/crates/ide_assists/src/handlers/reorder_impl.rs#L82-L84
We need to collect all make_ast_mut call results first I believe before actually replacing the nodes.

I've fixed the point 1 in https://github.com/rust-analyzer/rust-analyzer/pull/8711 and let the rest of the task to you @Veykril , since you're assigned :)

2 is addressed with https://github.com/rust-analyzer/rust-analyzer/pull/8712
reorder_fields actually didn't have that problem


Add hasAnyRole function to validate multiple roles for a given resource

In this commit, a new function called hasAnyRole was added to check if a user possesses any of the specified roles for a given resource. This function accepts a resource and an array of roles as input parameters and returns true if the user has at least one of the roles, or false otherwise. The implementation builds on the existing hasRole function, iterating through the array of roles to perform the necessary validation.

@luizjr  Could you please add some test and provide a minimal docs for README.? Thanks!

@robsontenorio Do I need to do anything else to unlock this new functionality?


Yorkie UI PoC

Current Yorkie UI Overview
The current Yorkie UI, a collaborative effort between KAIST NIL and Hivelab, is good for existing pages but encounters challenges in component reusability. Key issues include difficulty expanding to new pages and outdated technology stack hindering maintenance.

Design Reference: Figma Design
Yorkie UI Repository: GitHub
Current Result: Yorkie Dev

Current Challenges:

Difficulty in expanding to new pages and lack of component reusability.
a. Lack of abstraction in CSS and Figma.
b. Poor workflow from Figma to Yorkie UI.
Outdated technology stack (e.g., Node 14) posing maintenance challenges

Goals for Yorkie UI 2nd Iteration
The primary goal of the 2nd iteration is to enhance Yorkie UI by addressing existing challenges and expanding functionality seamlessly to the Dashboard and Homepage.
Requirements for the Goal
A. Managing design tokens directly in Figma: SSOT(single source of truth)
We can consider managing design tokens directly in Figma to preserve design intent and structure and be able to extract them as data(JSON). For this, we need to research Figma plugins and features for managing and extracting Design Tokens in Figma.
B. Employ headless UI components and layout system
We need to be able to extract design tokens from Figma and get implementations of the layout system and components we will use. For this, a headless UI Framework is needed.
Candidate solution: Park UI
We need to research Park UI Design System for those requirements: https://park-ui.com/
Workflow
We need to investigate ParkUI to see if it can be used in the workflow below.
Step 1. Park UI(Arc) Components to Figma
Initializing Existing Components (Approximately 35) from Park UI to Figma.
https://park-ui.com/docs/panda/overview/figma
Step 2. Preparing tokens directly in Figma and Extracting them to PandaCSS
After modifying tokens such as themes in Figma, we need to be able to extract them as style files(PandaCSS).
Step 3. Convert them into StoryBook
We need to be able to run StoryBook from style files extracted using the Headless UI framework.
References

Park UI: https://park-ui.com/
Ark: https://github.com/chakra-ui/ark
PandaCSS: https://panda-css.com/
Figma Variables: https://help.figma.com/hc/en-us/articles/15339657135383-Guide-to-variables-in-Figma

hi @hackerwins
We have a problem with duplication Park UI Figma
We can't get a local variable on Figma Community and We won't know how they've configured the system because Figma duplication shows name variables (spacing & radii/10). When we can edit the file we can get permission to look at it.

I think we need sync the design system Yoirke with Park UI so we are able to extract them into style files forStep 2.

For now, it seems more realistic to organize the existing SaaS-based UI rather than apply the new Yorkie UI to Homepage and Dashboard. I will close this issue for now.


Docs don't mention that UAMI cannot be used to connect to AKV's that are not publicly accessible

It would be great if the documentation could include the fact that connectivity isn't currently possible if trying to connect to a network restricted Key Vault when enabling TD from a User Assigned Managed Identity attached to Azure SQL. System Assigned identity does work, but I spent a long time trying to work out why connectivity wasn't working for my UAMI!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83b6d066-9a0d-ebdb-7432-fb4ae7a82794
Version Independent ID: 645e4ba4-7898-c2ec-bbb4-c39aecb7e21f
Content: Common errors with customer-managed keys in Azure Key Vault - SQL Server
Content Source: docs/relational-databases/security/encryption/troubleshoot-tde.md
Product: sql
Technology: security
GitHub Login: @shohamMSFT
Microsoft Alias: shohamd

@Jaffacakes82 -- Joe, thank you for your well-researched feedback.
@shohamMSFT -- Shoham, please look into this issue.

@Jaffacakes82 thanks for the feedback! The current limitation that UAMI cannot be used with TDE when key vault is behind a Vnet or firewall is documented here - https://docs.microsoft.com/en-us/azure/azure-sql/database/transparent-data-encryption-byok-identity?view=azuresql#limitations-and-known-issues .
This is a limitation of the UAMI feature that is in preview currently and will be removed by GA.

#please-close


⚠ Mobitopup has degraded performance

In 8be47c1, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 16776 ms

Resolved: Mobitopup performance has improved in 0fb5b46.


Worker healthcheck to exclude nodes annotated with node.machine.sapcloud.io/not-managed-by-mcm="1"

How to categorize this issue?

/area ops-productivity
/kind enhancement
What would you like to be added:
The nodes annotated with node.machine.sapcloud.io/not-managed-by-mcm="1" to be excluded from the health checks ran by the worker controller.
Ref: https://github.com/gardener/machine-controller-manager/pull/612
Why is this needed:
There is a possibility a node not managed by MCM, respectively Gardener, to be joined in a shoot cluster. In such cases, these nodes could be reported that their cloud-config is outdated or that there is other issues with them that are out of scope of Gardener.

/assign


use Bootstrap classes

Today, I have used Script: Run Options for the very first time and noticed this:

I fixed this by using the default Bootstrap classes for modals (Atom uses Bootstrap to style its components):

(I just noticed: it still needs the separators between footer and body)
If you agree with these changes, I will continue to style the other views so we can rid of some of the classes in the script style-sheets.

I'm a fan, keep it coming and feel free to :shipit:.


Android Basics: LiveData

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-livedata?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-3%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-livedata#3
In which task and step of the codelab can this issue be found?
Task 4, Step 3
Describe the problem
The text explaining the step should read "Change the backing field currentScrambledWord" instead of "Change the backing field of currentWordCount".
Additional information
Include screenshots if they would be useful in clarifying the problem.

Thank you so much for reporting this issue. This is fixed and will be published soon.


react-ts template use useParams will test error

Describe the bug
Test snapshots will report an error when use Params appears on a page component.
Reproduction
https://github.com/Spencer17x/vitest-demo.git
System Info
System:
    OS: macOS 12.3.1
    CPU: (8) x64 Apple M1
    Memory: 27.79 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.3.2 - ~/.nvm/versions/node/v14.16.1/bin/npm
  Browsers:
    Chrome: 100.0.4896.60
    Firefox: 99.0
    Safari: 15.4
  npmPackages:
    @vitejs/plugin-react: ^1.3.0 => 1.3.1
    vite: ^2.9.2 => 2.9.5
    vitest: ^0.9.3 => 0.9.3

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

To be sure, this is not vitest's problem, but the routing single test logic is not written correctly.


Properly decode lists with the integer 0

Without checking if the pop() variable is undefined, any integers that are 0 on the list will not be there on the decoded object. I'm guessing the same goes for empty strings because Javascript considers them "false" too.
  var data = 'li0ee';
  var decoded = benc.decode(data);
  assert_obj("List with 0", [0], decoded);

Thanks a lot! Strings are fine, they were already tested. Happy Holidays,
-tim


Academic Project Filter Toolbar Colour Illegible

Hi there,
I have searched through the Issues listed here on GitHub and several forums and not encountered someone else facing this issue, so this might be user-error.
The Issue
I have migrated my website from wordpress to an RStudio-based workflow with the help of the academic template. While almost all of the migration has gone over flawlessly, I am struggling with the filter bar on my project widget.
The colour of the filter bar does not lend itself to reading on my end. Here are examples:

In Light-Setting:

In Dark-Setting:

Expected behavior

Light-Setting: I would expect the text colour on untoggled buttons to be black on white background.
Dark-Setting: I would expect white text colour on untoggled buttons.

Proposed Solution
Unfortunately, I am not very savvy as far as html code goes. With a bit of inspiration from #697, I would guess that the file \themes\github.com\wowchemy\wowchemy-hugo-modules\wowchemy\layouts\project\single.html might be the solution here by adding colour definitions where the text coplour of buttons is set to the inverse of the background?
Technical details:

Link to your GitHub project:
Wowchemy Version: 1.15
Hugo Version: 0.79.1
Browser: Firefox & Edge
Wowchemy Template: Academic
Template Theme: Forest
R version 4.0.2 (2020-06-22)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Cannot reproduce on the current starter-academic template with theme = "forest". May be related to RStudio or not using the official installation: https://wowchemy.com/docs/getting-started/install/
Can you provide steps to reproduce by following the official Wowchemy installation guide on the current starter-academic template, direct with Hugo (without using R/RStudio), and then provide a link to that fresh repo? If so, may reopen.

Cannot reproduce on the current starter-academic template with theme = "forest". May be related to RStudio or not using the official installation: https://wowchemy.com/docs/getting-started/install/
Can you provide steps to reproduce by following the official Wowchemy installation guide on the current starter-academic template, direct with Hugo (without using R/RStudio), and then provide a link to that fresh repo? If so, may reopen.

After quite a bit of trial and error, I identified the issue. I had added a custom button specification as an object called btn in the hero widget which subsequently affected my filter toolbar.

After quite a bit of trial and error, I identified the issue. I had added a custom button specification as an object called btn in the hero widget which subsequently affected my filter toolbar.


Tweak GitHub logo

Small improvements to best match the official GitHub brand mark.

Fix Octocat’s tentacle - not quite thick enough.
Minimal geometry changes made with ‘Yqnn/svg-path-editor’, no change in file size.
Correct background colour to better match official vector artwork.

Comparing current artwork to official vector files, shows that the tentacle needed tweaking.

From checking GitHub brand guidelines, there doesn't seem to be a background colour explicitly given.
Inspecting the official .png bitmap images gives:
#171516 - RGB(23, 21, 22)
Whereas, the official vector artwork (.ai and .eps) gives:
#181717 - RGB(24, 23, 23)
Currently we have (changed by #112):
#1B1817 - RGB(27, 24, 23)
Originally we used:
#171515 - RGB(23, 21, 21) ... which is closer.
This PR applies the vector artwork colours, as presumably this best matches the design intent.
--> #181717 - RGB(24, 23, 23)
(In reality, this is barely visible to most users).

Updated PNG reference image and Android VectorDrawable.
... Hoping for a Gold Star ;-)

🌟🌟🌟🌟🌟


[doc] fix routing for command-reference redirects

Added redirect_from, for all links in command-refernce page

Signed-off-by: Arun Et<EMAIL_ADDRESS>Description
This PR fixes #4565
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit d85799d84a078b3203925f59eb08b8c9aec8cd1b at: https://618b78e8bf23b69306033efa--meshery-docs-preview.netlify.app


Temporary fix for 1072 resolution.

This is just temporary until this fixed completely.

Curious, what would be considered "fixed completely"?

the m3u8 file contains all resolutions like this:
#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=3067759,RESOLUTION=1280x720,FRAME-RATE=24.000,CODECS="avc1.640028,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xx.mp4/index-v1-a1.m3u8?...
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=6308896,RESOLUTION=1920x1072,FRAME-RATE=24.000,CODECS="avc1.640028,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xx.mp4/index-v1-a1.m3u8?...
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1204462,RESOLUTION=854x480,FRAME-RATE=24.000,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xx.mp4/index-v1-a1.m3u8?...
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=590507,RESOLUTION=640x360,FRAME-RATE=24.000,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xx.mp4/index-v1-a1.m3u8?...
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=434663,RESOLUTION=428x240,FRAME-RATE=24.000,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xx.mp4/index-v1-a1.m3u8?...

As you can see we have:
1280x720
1920x1072
854x480
640x360
428x240

What I mean by completely is that it should:
1 - fetch all resolutions.
2 - order them by height so it should be like this:
1920x1072
1280x720
854x480
640x360
428x240

then if the user selected 1080p or best it should look for it, if it didn't it should look for the next lower value which is 1072.
the issue is that it does not look at anything outside this array:
https://github.com/simplymemes/crunchyroll-dl/blob/bc5d7ef94b229cf647078f19b9a591490893ee5c/index.js#L253
this cause it to download 720p.
What I think "completely" means that this app should look for the qualities inside m3u8 file instead of that array, because crunchyroll not necessarily follows those resolutions or aspect ration (like what happend with "GTO the animation")
then instead of comparing it to the array, it should compare it to the m3u8 resolutions.

I have just pushed 1.3.4 which will rely on the values returned from Crunchyroll rather than the array.

Thank you, I will update it and try it right now.

It works like a charm, now I won't worry about any resolution, even if crunchyroll added 2k or 4k it should be able to handle it.


Change links into buttons

Closes #709

Nice! they look like real buttons now :)
what do you think about also converting this to a button?
https://github.com/SatcherInstitute/health-equity-tracker/blob/b84ac6d5ace72d7f6b6538af11e60759c6ad276f/frontend/src/App.tsx#L94-L101

Nice! they look like real buttons now :)
what do you think about also converting this to a button?
https://github.com/SatcherInstitute/health-equity-tracker/blob/b84ac6d5ace72d7f6b6538af11e60759c6ad276f/frontend/src/App.tsx#L94-L101

I updated the logo but I thought the text looked kinda odd as a button so I left it alone

I just realized playing around with the deploy preview - using buttons causes the whole page to reload, whereas the links were instant changes. This seems like a pretty bad side effect - site navigation is much slower.

The LinkButton suggested here https://stackoverflow.com/a/49439893 seems like a pretty good solution. (a very similar version here: https://usehooks.com/useRouter/)


chore: Add pnpm workspace configuration and VSCode settings

chore: Add pnpm workspace configuration and VSCode settings
chore: Add pnpm workspace configuration and VSCode settings
chore: Update dependencies and fix CSS styling
chore: Update dependencies and configure Tailwind CSS
feat: Add authentication functionality to homepage
This commit adds authentication functionality to the homepage component. It imports the necessary dependencies and sets up the authentication logic using the useAuthenticator hook from the @aws-amplify/ui-react-core package. It also adds a modal for authentication and a sign out button for authenticated users.  It also fixes the authentication logic in the homepage component by importing necessary dependencies and setting up the authentication logic using the useAuthenticator hook from the @aws-amplify/ui-react-core package. Additionally, it adds a modal for authentication and a sign out button for authenticated users.  It also Dockerizes the React app by adding a Dockerfile and a .dockerignore file. The Dockerfile sets up the base image, installs the necessary dependencies, copies the code into the container, builds the app, and sets the command to run the app. The .dockerignore file specifies the files and directories to exclude from the Docker build context. These code changes include the addition of the .dockerignore file, the Dockerfile, and modifications to the uploadbox component and the tsconfig.json file.
Merge pull request #1 from BalajiSriraman/setuptailwind
chore: Update dependencies and fix CSS styling

#2  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BalajiSriraman and the rest of your teammates on  Graphite


⚠ Mobitopup has degraded performance

In 71f6c1a, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 6508 ms

Resolved: Mobitopup performance has improved in 51991c4.


Optimism Gateaway - MAINNET QA

Review Info

Description
Info

Subgraph Reviewed
https://subgraphs.messari.io/subgraph?endpoint=https://api.thegraph.com/subgraphs/id/QmayRkPM3wyaTJEzJXNRb5E8Pt53m4Ytk8dSAeBPsgmQhg&tab=protocol

Schema Version
1.1.0

Subgraph Version
1.0.0

Methodology Version
1.0.0

Evidence Spreadsheet
https://docs.google.com/spreadsheets/d/1lyrlXGcY9_MXgHYjCA8yunNJ21sMm3SN/edit?usp=share_link&ouid=104027705798814439445&rtpof=true&sd=true

Metric to Review
TVL

The TVL subgraph data is not mathematically aligned with Dune Analytics data as it shows a 5-day average discrepancy of -45.45%. This is probably due to some large pools missing in the subgraph. For example, the OP token pool which currently has a TVL of about $693 million, is missing from the subgraph data.

February 6, 2023:

Subgraph - 5-day average TVL
Dune Analytics - 5-day average TVL
Absolute difference
Difference %

1,246,131,990.32
2,284,425,000.00
-1,038,293,009.68
-45.45%

Refer to the sheet 'Protocol'

Total Pool Count and Total Supported Token Count

The official website only shows 100 pools/supported tokens, while the subgraph data has 124 pools.
Refer to the sheet 'Protocol'

Pool Overview - TVL

Out of the subgraph's top 10 pools by TVL, only three have shown large discrepancies with the Dune Analytics data, and these pool tokens are DAI, sUSD, and SNX.
Three of the top 10 pools in the Dune Analytics dashboard by TVL are not shown in the subgraph data. It includes OP, KWENTA, and VELO which have TVL USD amounts of 692.87m, 86.35m, and 61.82m.
This explains why there is a large discrepancy in the overall TVL of subgraph data compared to Dune Analytics data.
Refer to the sheet "Pool_Overview" for detail

Please refer to the attached worksheet for more details.

@spitko QA for OP gateway here!

Thanks for the QA, a few comments below:

TVL

The TVL subgraph data is not mathematically aligned with Dune Analytics data as it shows a 5-day average discrepancy of -45.45%. This is probably due to some large pools missing in the subgraph. For example, the OP token pool which currently has a TVL of about $693 million, is missing from the subgraph data.

February 6, 2023:
Subgraph - 5-day average TVL	Dune Analytics - 5-day average TVL	Absolute difference	Difference %
1,246,131,990.32	2,284,425,000.00	-1,038,293,009.68	-45.45%

Refer to the sheet 'Protocol'

The Dune Analytics chart is for total Optimism on-chain value while the subgraph TVL only counts the value of tokens locked in escrow on Ethereum mainnet.
There is no OP token pool, because OP is a native L2 token and does not exist on mainnet.

Total Pool Count and Total Supported Token Count

The official website only shows 100 pools/supported tokens, while the subgraph data has 124 pools.
Refer to the sheet 'Protocol'

The official website is just a convenience, tokens can be bridged also without using the website. The subgraph counts all unique tokens bridged as separate pools.

Pool Overview - TVL

Out of the subgraph's top 10 pools by TVL, only three have shown large discrepancies with the Dune Analytics data, and these pool tokens are DAI, sUSD, and SNX.
Three of the top 10 pools in the Dune Analytics dashboard by TVL are not shown in the subgraph data. It includes OP, KWENTA, and VELO which have TVL USD amounts of 692.87m, 86.35m, and 61.82m.
This explains why there is a large discrepancy in the overall TVL of subgraph data compared to Dune Analytics data.
Refer to the sheet "Pool_Overview" for detail

OP, KWENTA and VELO are all native Optimism tokens and cannot be bridged through Optimism Gateway.

@pietydespises Could you take a look at this when you get the chance?

@pietydespises Also if the above is fine, can you give the OP deployment a quick one over and then we can mark this as prod?

Agreeing with @spitko here, this looks good to go.


Any license?

Wow its so great. Could u plz add a license so that  i can use it?

well I don't think this library has been completed yet. The encryption part is not finished and the whole library hasn't been tested in production environment.
This project originated from Tnze/go-mc but the maintenance has temporarily stalled because I'm busy with my other works. I'll add MIT license later but there are something to attention:

The library hasn't been uploaded to Maven so you should download it by yourself.
Not tested, use at your own risk.
Issues and PR are welcome but issues may not receive fixes in a short time.
Have a good day! XD


feat: add dependency injection

This was considerably easier than I thought it would be.
Just DI for now. No extension API yet.

Used TSyringe. Very lightweight (1 already used dependency)
Used symbols for interface based injectables. Maybe we want to use base classes later on to make it easier, but I wanted to keep most of the current working intact. Just replace it with DI
Use @scoped(Lifecycle.ContainerScoped) for injection. This is basically a singleton, however only for the current DI container. This means a child container won't share the same instance. Two reasons:

The tests were not happy with a singleton (could have bypassed this however)
This allows to run two agents side by side and don't have problems with the singletons

Instead of using Repository<RecordClass> we're now using RecordRepository. It was very hard to use this pattern. Maybe we can simplify it later on. For now it was easiest to just create a separate repository per record type.

Let me know what you think. I think this will make extension a lot easier moving forward.
Fixes #211

Codecov Report

Merging #257 (7f173b0) into main (e07b90e) will decrease coverage by 0.33%.
The diff coverage is 99.19%.

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   88.96%   88.63%   -0.34%
==========================================
  Files         178      189      +11
  Lines        3381     3492     +111
  Branches      389      390       +1
==========================================
+ Hits         3008     3095      +87
- Misses        373      397      +24

Impacted Files
Coverage Δ

src/agent/Agent.ts
96.96% <96.00%> (-3.04%)
:arrow_down:

src/agent/Dispatcher.ts
96.77% <100.00%> (+0.34%)
:arrow_up:

src/agent/EnvelopeService.ts
100.00% <100.00%> (ø)

src/agent/MessageReceiver.ts
81.48% <100.00%> (-4.24%)
:arrow_down:

src/agent/MessageSender.ts
93.33% <100.00%> (+1.02%)
:arrow_up:

src/modules/basic-messages/BasicMessagesModule.ts
89.47% <100.00%> (+2.80%)
:arrow_up:

src/modules/basic-messages/index.ts
100.00% <100.00%> (ø)

...asic-messages/repository/BasicMessageRepository.ts
100.00% <100.00%> (ø)

src/modules/basic-messages/repository/index.ts
100.00% <100.00%> (ø)

...les/basic-messages/services/BasicMessageService.ts
92.30% <100.00%> (+0.64%)
:arrow_up:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07b90e...7f173b0. Read the comment docs.

Errors fixed, tests added

So it essentially means modules are singletons, except that agents have their own singletons (which I think make sense IMO).

Exactly!

This allows to run two agents side by side and don't have problems with the singletons

Yes, this is important to preserve 👍

I didn't merge it just for the case you want to merge it in some order with other PRs :)

One more thing. Perhaps it's not necessary but have you tested if it works with React Native? I know it should but TSyringe docs say something about Babel transform setup. It could be worthy to be sure it works and eventually describe what to do in our docs here. What do you think, @TimoGlastra ?

Good point @jakubkoci. We need a way to easily test if the framework works in RN (not sure if bifold is already the easiest to to do that)

TSyringe docs say something about Babel transform setup

This is only when using babel to do TS compilation. We use the native TS compiler and publish that to NPM so it should already include the TS metadata. But would be good to check

Definitely a good point @jakubkoci! I think Bifold would be the easiest to do that--and I'd like to get it updated as necessary anyways. So, I could test this out later today if that'd be helpful.

Definitely a good point @jakubkoci! I think Bifold would be the easiest to do that--and I'd like to get it updated as necessary anyways. So, I could test this out later today if that'd be helpful.

That would definitely be helpful @JamesKEbert! Thanks. It still needs to be updated to use the NPM package right? If we make that update it will be easier to quickly test new releases


proposal: rename cosmos-ui to voyager

Let's rename this repository to https://github.com/cosmos/voyager
And all of the associated files in the same way:
package.json
README.md
etc

[ ] rename all the things
I'm pushing ahead on this issue instead of the sprint because we need to get the /voyager page up and running on the website.

i got confirmation from bucky, jim, and christine. they all thought it was great.


Changing the way the uber-merge-strategy works

What we want is the ability to cherry pick empty changes for SQ.
Initially we went with the merge strategy instead of cherry picking. But for release branches this is not ideal as you would end up picking up commits that are not in the release branch's history as they diverge a lot from the master branch.

change looks good. nit on subject and description
subject: Use cherry-pick for uber-merge-strategy
description:

change merge strategy from merge to cherry-pick, this is to support release branch
add handle for blank merge


Switch to CodeMirror for static code highlighting

Switch to CodeMirror for static code highlighting, so I only have to write one more syntax highlighter for Squiggle.

Performance on this was really bad, so I'm just gonna write a highlighter for Rouge.
https://gist.github.com/wavebeem/253c9775bb04fd0aecf0


Add nanogpt and training function

Adapted NanoGPT and make modifications in order to work with TextDataLoader classes

Thanks so much @nateburley  for the comments, I will close this one and create a new PR from latest main. Thanks!


Stream processing of results not working for entity views

Description
We updated to 1.6.4 because there was a bugfix included for getResultStream() since this was throwing an exception for us earlier on #1393. The fix included in #1394, seems to have introduced this odd behavior.
Expected behavior
When using getResultList().stream(), we get the following response:
[ {
  "businessUnitId" : null,
  "typeIds" : [ 1 ],
  "presentCount" : 0,
  "validatedCount" : 0,
  "createdDate" : "2022-01-14T15:16:59.905673Z",
  "dataTypeIds" : [ 11 ],
  "rId" : 12601,
  "id" : 1,
  "risk" : "TESTING",
  "riskScore" : 0.36666667,
  "reasonDetail" : "Created",
  "relevantControlCount" : 13,
  "test" : "TESTING",
  "score" : 0.36666667,
  "status" : "TESTING",
  "userId" : 1,
  "userName" : "Test"
}, {
  "businessUnitId" : null,
  "typeIds" : [ 1 ],
  "presentCount" : 0,
  "validatedCount" : 0,
  "createdDate" : "2022-01-14T15:17:22.026997Z",
  "dataTypeIds" : [ 11 ],
  "rId" : 12601,
  "id" : 2,
  "risk" : "TESTING 2",
  "riskScore" : 0.36666667,
  "reasonDetail" : "Modified",
  "relevantControlCount" : 13,
  "test" : "TESTING 2",
  "score" : 0.36666667,
  "status" : "TESTING 2",
  "userId" : 2,
  "userName" : "Test 2"
} ]

This is the expected output
Actual behavior
When using getResultStream(), we get the following response:
[ [ 1, null, 1, 0, 0, "2022-01-14T15:16:59.905673Z", 11, 12601, "TESTING", 0.36666667, "Created", 13, "TESTING", 0.36666667, "TESTING", 1, "Test" ], [ 2, null, 1, 0, 0, "2022-01-14T15:17:22.026997Z", 11, 12601, "TESTING 2", 0.36666667, "Modified", 13, "TESTING 2", 0.36666667, "TESTING 2", 2, "Test 2" ] ]

Steps to reproduce
Reproduced in Project: https://github.com/dsarlo-viso/blaze-web-implementation-issues
Just have to hit the following endpoints:
Create a user POST http://localhost:8080/api/web-mvc
With the body:
{
    "firstName": "Blaze",
    "lastName": "Entity"
}

Get user profiles (ResultStream) GET http://localhost:8080/api/web-flux
You should see something like this:
[
    [
        "cbaec5bb-8641-47f6-8584-cf53e383b325",
        "Test",
        "Test",
        null,
        null,
        null
    ],
    [
        "15c2b3c8-8f3c-4a26-acbe-c9e3d0e6c138",
        "Blaze",
        "Entity",
        null,
        null,
        null
    ]
]

Environment

Version: 1.6.4
JPA-Provider: Hibernate 5.4.32.Final (Spring Data JPA 2.4.13)
DBMS: PostgreSQL 13.3
Application Server: Spring Boot 2.4.13

Well, what would you expect here? You are join fetching a collection which increases the cardinality by N for every output object, so real streaming doesn't work. Should this throw an exception or maybe consume the whole stream to produce a correct result? I think an exception might be best here. What do you think?
If you change UserProfileView to use any fetch strategy other than JOIN for links, it will work
@Mapping(fetch = FetchStrategy.MULTISET)
List<LinkView> getLinks();
void setLinks(List<LinkView> links);

I actually think throwing an exception here is the proper thing to do so a user knows that something has to be changed in order for streaming to work, so I implemented that as part of https://github.com/Blazebit/blaze-persistence/pull/1424


Nlog 5 dosen't work with Graylog

Good day
I used NLog 4 to log information to Graylog and also write it in a file in file system and it worked great.
However with Nlog 5 the logged information only gets written on file system but not on Graylog.
Can you please look into it.
Thank you

Have you tried to use NLog.GelfLayout like this (Supports TCP / UDP / HTTP):
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" throwConfigExceptions="true">
  <extensions>
    <add assembly="NLog.Layouts.GelfLayout" />
  </extensions>

  <targets async="true">
	<target xsi:type="Network" name="GelfHttp" address="http://localhost:12201/gelf">
		<layout type="GelfLayout">
			<field name="threadid" layout="${threadid}" />
		</layout>
	</target>
  </targets>

  <rules>
    <logger name="*" minlevel="Debug" writeTo="GelfHttp" />
  </rules>
</nlog>

See more examples here:  https://github.com/farzadpanahi/NLog.GelfLayout#sample-usage-with-nlog-network-target-and-http

Good day
Using NLog InternalLogger I found the problem.
It was in configuration related to breaking changes made in NLog 5 compare to NLog 4 LoggingRule Filters DefaultAction changed to FilterResult.Ignore
Thank you for help


[Automation] Generate Fluent Lite from recoveryservicessiterecovery#package-2022-10

[Automation] Generate Fluent Lite from recoveryservicessiterecovery#package-2022-10

/azp run prepare-pipelines

/azp run prepare-pipelines

/azp run java - recoveryservicessiterecovery - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-recoveryservicessiterecovery

This is duplicate of https://github.com/Azure/azure-sdk-for-java/pull/32881. Closed.


Website screenshots

Ability to take, store and retrieve website screenshots
Use this API:
https://www.mashape.com/handtrix/website-screenshot

Not too much in demand


could not find module 'Mixpanel' for target 'arm64-apple-ios-simulator'

I have set EXCLUDED_ARCHS[sdk=iphonesimulator*] = arm64 in the pod file for other important libraries to work (Razorpay).
Any workaround to fix this issue?
I am using Macbook M1 Air.

bump

same

@PaRaDoX50 are you still experiencing this issue? If so, can you please update to the latest version (v1.5.0) and let us know it still persists?

Any update on this?

Same issue happens to me as well

Any update on this?

@PaRaDoX50 are you still experiencing this issue? If so, can you please update to the latest version (v1.5.0) and let us know if it still persists?

I have dropped that project, so I won't be able to assist you with more information.

@jaredmixpanel I'm also getting this error. I'm using the latest Flutter version (3.7.9), Xcode 14.3 and mixpanel_flutter 2.1.1. This only happens when building in debug mode for ios simulator. Can you please help?

I solved it by applying the architectures to be excluded when pod install is running as shown below.
post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
    target.build_configurations.each do |build_configuration|
          build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64 i386'
    end
  end
...


Fraud Prevention - How do we ensure users don't share accounts

One of the cornerstones of success in this project is to ensure that a given account is verifiable as a unique individual, as bolstered by various third-parties. However, if person A shares their OMPIS account with person B, and person B is then able to act on behalf of person A, then we reduce many of the important guarantees that are necessary for this app to function.
One of the most important use-cases is in-person validation of data. How do we prevent person B from logging into person A's account and having person A's data validated instead of their own? Even if we do something along the lines of "locking down" the application to a single account per device, what's to prevent someone from sharing that device?

For the in-person use-case, requiring they use Face ID/fingerprint scanning or some other biometric reading would prevent device sharing. This would need to be in conjunction with a "single account per device" model, or else the same device could sign into multiple accounts. We'd also need to enforce a "single device per account" model to ensure that a user does not simply associate their account with multiple devices that are actually owned by other people.
For users that don't have any sort of biometric authentication on their phone, we could potentially use photographs to help with verification. This poses a number of follow-on problems, though - how do we ensure the photographs identify the person in question? We definitely don't want to store those photographs ourselves, but if we just pull them from i.e. Facebook, we don't have a guarantee (without some user intervention) that they're sufficient for identifying the person in question. In addition, if the place where the photos were stored allowed for the easy change of said photographs, the photo-verification piece could easily be manipulated by changing the photos to ones of the person wanting to use the account in real-time.

This also needs to consider usability as a first class feature- in the use case of testing, not overburdening the user during login is important.


Tests are failing by default

Hi everyone,
I'm trying to develop a plugin using this template. I followed the instructions of the README and tried to run the tests. Those failed however and yielded the following error:
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-8.3.2, pluggy-1.5.0 -- /home/###/###/nomad-example/testplugin/bin/python3
cachedir: .pytest_cache
rootdir: /home/###/###/nomad-example/testplugin
configfile: pyproject.toml
plugins: anyio-4.4.0
collected 3 items / 1 error

==================================== ERRORS ====================================
________________ ERROR collecting tests/parsers/test_parser.py _________________
ImportError while importing test module '/home/###/###/nomad-example/testplugin/tests/parsers/test_parser.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/parsers/test_parser.py:4: in <module>
    from nomad_foobar.parsers.myparser import MyParser
E   ModuleNotFoundError: No module named 'nomad_foobar'

The system I used is Linux with the latest PopOS! distro. The ### are inserted by me, since it contains personal information about me.
Can somebody help me to resolve this issue? Thanks in advance.

Hi.
The error suggests to me that the package may not have been installed.
Are you in the correct virtual env where the you ran the pip install command?

nomad_foobar.
The last step described here.
Could you share the .cruft.jsonfile? I can try to reproduce it locally then

I installed the newest version as described in your link and now it works. So this issue can be closed. Thank you very much!


Minor: Avoid an unecessary contruction in map_children some extra plan construction

Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/pull/5630
Rationale for this change
As suggested by @mingmwang https://github.com/apache/arrow-datafusion/pull/5630#issuecomment-1486169300 we can save a copy here
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?

LGTM.
An empty iterator will return false for the iter().any(), this is exptected.

LGTM


fix typo in tests

This will get a different meaning in 1.7. (ref https://github.com/JuliaLang/julia/pull/33697)

Tyvm and sorry about the noise.


Hyperlink check problem

Describe the bug
Hello I was initially useing botium-cli version of June with LINK feature working well.
Recently I updated to botium-cli 0.5.4 and noticed that probably this keyword has been removd and replaced with HASLINK keyword provided by botium-asserter-basiclink.
Now I got the error Cannot read property 'includes' of undefined ,  maybe caused by other npm WARN in installation phase.
Before running the test I run npm install --save botium-asserter-basiclink in my botium folder and added in my botium.json under myCapabilities:
"ASSERTERS": [{
"ref": "HASLINK",
"src": "botium-asserter-basiclink"
}]
I also checked https://npm.community/t/cannot-read-property-match-of-undefined/203
In my convo I have ..
#bot
HASLINK https://myURLToCheck
Screenshots and Log files
INSTALL PHASE
.
.
npm WARN saveError ENOENT: no such file or directory, open '/app/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/app/package.json'
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN app No description
npm WARN app No repository field.
npm WARN app No README data
npm WARN app No license field.

<EMAIL_ADDRESS>added 14 packages from 11 contributors and audited 28 packages in 1.558s
found 0 vulnerabilities

TEST
.
.

Botium Test-Suite
BOT_TEST:
TranscriptError: BOT_TEST/Line 6: assertion error - Cannot read property 'includes' of undefined
at async.waterfall (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/Convo.js:225:25)
at wrapper (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:272:20)
at next (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:4584:24)
at /usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:325:20
at runConversation (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/Convo.js:203:15)
at async.mapSeries (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/Convo.js:437:9)
at err (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:252:13)
at wrapper (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:272:20)
at iterateeCallback (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:417:21)
at /usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:325:20
at _iteratee (/usr/local/lib/node_modules/botium-cli/node_modules/async/dist/async.js:249:17)
at convoStepDone (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/Convo.js:269:11)
at scriptingEvents.assertConvoStep.then.catch (/usr/local/lib/node_modules/botium-cli/node_modules/botium-core/src/scripting/Convo.js:395:28)
at
at process._tickDomainCallback (internal/process/next_tick.js:229:7)
botium-asserter-basiclink

Botium Version
botium-cli 0.5.4

tryed with new 0.0.55 and HASLINK. Seems to work well. The only problem is that if I put only a substring of the link provided from the chatbot, the test passes and passes also if it leads to 404 in a normal browser
I'm using "SCRIPTING_MATCHING_MODE":"include" but I didn't thought it affects link checking feature

botium-asserter-basiclink is for assertions that a hyperlink matching the pattern is part of the bot reponse, nothing more. It uses the same matching logic as the text asserter.
asserting that the link is actually pointing to a valid URL resource is part of the paid botium box plans.

But for valid , didn't mean that response code is not 4xx as well?

no, it just asserts if the link is part of the bot response


Upload to packagist?

Looks like https://packagist.org/search/?q=timber-starter-theme yields nothing, and I'm having trouble getting it to install with the vcs option in composer.

Actually... looks like it's trying to require wpackagist-plugin/timber-library 0.21.* but that's out of date

Done!
https://packagist.org/packages/upstatement/timber-starter-theme

Woop, thanks!


Remove jargon from problem descriptions

We should be mindful of the amount of jargon in the problem descriptions. Might be good to read through the warmup and beginner problems and get rid of any jargon.

I think I've tried to work on this issue and there's no actionable item so I'll close it.


XunitPerformanceHarness prints unwanted Console output

Issue ported from comments in https://github.com/dotnet/coreclr/pull/16353:

XunitPerformanceHarness has hard-coded console writeline usage inside it and I wanted all that output spew in a file to keep the console output clearer. I wound up hijacking Console.Out whenever using XunitPerformanceHarness in order to capture and redirect the logging.

Repro:
Write code such as...
using(var harness = new XunitPerformanceHarness(args))
{
    harness.RunScenario(...)
}

Goal: Provide someway to redirect the console logging this does into a stream, or ideally a callback
Actual: Output will be written to the console

You can  redirect the console logging manuallyb y using cmd.exe > operator

@noahfalk  Why doesn't Xunit.Performance just use ITestOutputHelper abstraction in Xunit core for tests, and IMessageSink for general purpose output?
https://xunit.github.io/docs/capturing-output

@jzabroski - I wasn't the person who wrote xunit.performance so I can't give a definitive answer why the authors made particular design choices. I can say that in my use-case I wasn't using this library from an xunit test so if the authors had done that it would have made it a little awkward for me.

Closing prior to archive.

Closing prior to archive.


Project credential bug

If Super Admin will change his role in the project to Viewer - he will lose an access to this project

Note: a second opening of the page (not reloading) restores the Super Admin role

I am pretty sure the same problem was mentioned in https://github.com/saveourtool/save-cloud/issues/1085

I am pretty sure the same problem was mentioned in #1085

@sanyavertolet I think not - #1085 is about the first render when the role hasn't been fetched yet. This one is about changing the role and some sort of corruption of component state afterwards


Removed deprecated reference to ElasticMesos from Mesos Getting-Started-Guide.

We will add a new section about setting up such cluster using vagrant-mesos. The goal here is just to remove the deprecated reference asap.

there's still a link "[5]" that points to google.mesosphere.com (and related link in the text)

@jdef PTAL

Moved to:
https://github.com/GoogleCloudPlatform/kubernetes/pull/9252


add react and react dom as peer

fixes #997

add ./idea to gitignore for webstorm users
update all the examples

I added react and react dom to all the examples(even preact) to avoid bugs with shrinkwrap in npm v3 https://github.com/npm/npm/issues/12909
I'm kind of confused because the tests aren't failing - we don't have react anymore, so it should error out because react is missing or am i wrong?
I actually thought I had to do sth like:
"prepublish": "npm install react react-dom && npm run test && npm run release"

locally tests are failing without this.

I think we should add react and react-dom to devDependencies.

Additionally, I believe we have to remove settings of babel-plugin-module-resolver from babel.

@nkzawa not entirely sure what you mean by:

Additionally, I believe we have to remove settings of babel-plugin-module-resolver from babel.

We use babel-plugin-module-resolver to be able to use on your apps like this.
https://github.com/zeit/next.js/blob/master/server/build/babel/preset.js#L23
https://github.com/zeit/next.js/blob/master/server/build/webpack.js#L178
We have to remove them.

@nkzawa okay i removed it :) please ping me if there's anything left i have to do.

This looks great to me.
Thanks @sakulstra


Save button is not disabled even when User has not edited anything in Edit Workspace

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to newDot
Go to any Workspace page
Edit workspace
Even without editing anything "Save" Button will be active

Expected Result:
Button should be disabled when nothing has change
Actual Result:

Workaround:
Visual issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal

I'll disable the button if the values aren't changed

        const isButtonDisabled = this.props.policy.name === this.state.name.trim();

on hold, will revisit in a week-ish

still on hold.. likely coming off soon..

@aman-atg , I think we should wait til people are allowed to create new workspaces on staging then check to see if the save button is still highlighted with no text in the box. I just tried to create a new workspace with no luck, it might be because I'm the 'Expensify' account though.

Well, we can do that but the issue was "Save" Button being highlighted even when no editing was done.
Like for Profile and all other forms if user hasn't edited anything it should kept disabled.

Ok, I think I'm seeing it now. It's a low value issue but, we should be consistent between having the save button not highlighted in edit workspace if there are no changes like it is in profile edit.
Moving along to an engineer for more eyes.

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

This seems fairly trivial. And not really that important, but if we do it in the rest of the app, then consistency is nice. Sure, go ahead.

Triggered auto assignment to @timszot (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Job posted - https://www.upwork.com/jobs/~018a28b490d8741d12
@timszot , can you review @aman-atg 's proposal here https://github.com/Expensify/App/issues/4490#issuecomment-894612560

I'd like to highlight that I was asked to resolve this as a part of this PR.
https://github.com/Expensify/App/pull/4801

Looks good to me! @mallenexpensify let's hire @aman-atg for his proposal.

@mananjadhav are you suggesting that if we put this issue on hold, it'll end up being fixed by one/both of the issues you linked above?

Yes, @mallenexpensify.  Save button is enabled only when the image or title is changed. It was just merged today.
@aman-atg and @timszot  can also confirm. Following is code change that handles it.
 const isButtonDisabled = policy.isAvatarUploading
                                              || (this.state.avatarURL === this.props.policy.avatarURL
                                                     && this.state.name === this.props.policy.name);

Cool, this can be closed now. (As the issue is already fixed by another PR)


Enh #15226: Auto generate placeholder from fields

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
#15226

Thank yu


'dev site' link not working in Readme.md

The dev site link is not working. Can someone take a look into this?

Hello,
Is this issue still active?
I would like to work on this.
Best Regards.

its active i think since no one solve the issue go on if you want


Update strongbox_fixity.py - utf-8 fixes

Do not merge until tested :)

Testing has been successful with the additional two lines you had previously mentioned (48 and 51) also being altered. I will commit these changes as well :)

Merged, congrats on first ifiscripts contribution!


What is the data transmitted to the classify function?

I am not sure how the data transmission needs the class part. Help me please

I have added an example in the README.md
$testingData = [
  'outlook' => 'sunny',
  'windy' => 'false',
  'humidity' => 'high',
];

echo $tree->classify($testingData); // prints 'no'

In summary, the data array passed to the classify function is an array in the format :
[
   'attribute` => 'value'
]

Thank you so much!

I forgot to say, but you must execute composer update first. There is an update for CSV reader dependency. Also, please confirm if your problem has been resolved so I can close this issue.

I have handled it. Thank you!


⚠ Bofrost.lu has degraded performance

In 9426fcf, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 808 ms

Resolved: Bofrost.lu performance has improved in 9f92c4b after 14 minutes.


Prep notetaking and analysis space for stakeholder interviews

When [Situation]?
We're going out to our partners to discuss feasibility
I want to [Motivation]
Track those conversations
So I can [Expected Outcome]
set us up to do some analysis in the mural board

Made a mural called "Dogwood Stakeholder Interviews"


👑 [exercise] - User workload monitoring

Observability

Module: User Workload Monitoring

📝 Description
Learners should extend their pet-battle infra with the grafana chart. This is done for each team as it is namespaced. Probs need one for test & stage. Then via argocd override, we can enable ServiceMonitor. Teams should discuss what are important measures eg api response time or uptime etc and build a simple query for their dashboard to show this.
🥤 Additional Info
grafana from pb-infra here
service monitor on chart is here
✅ A/Cs

[x] Big Picture Updated (if applicable)
[x] Facilitator notes updated (if applicable)
[x] Exercise peer reviewed / tested with one other region member
[x] Addition of new exercise does not affect previous exercise (maintain modularity)

@springdo and I are tackling this one 🚀

@springdo @ckavili Proposed some changes after my review.

LGTM


Unproccessable Entity Error when creating a T4C instance without license server or rest api host specified

Right now, we only have a validation that check whether the license server and rest api fields contain a "http(s)://" but when just providing "http://" or "https://", we receive an "Unproccessable Entity" error from the backend. Even thought it does not make much sense to just input these values into the field we should still extend the field validation (i.e., at least check that there is anything after the "http(s)://".

It


Add name anchors to state headers

This will allow users to bookmark/refresh and keep a specific state in view.

We already do this: https://alex.github.io/nyt-2020-election-scraper/battleground-state-changes.html#north-carolina unless I misunderstood the request?

Yep, that's the functionality I was looking for.  I didn't realize ID was a valid anchor ref (https://www.w3.org/TR/html401/struct/links.html#h-12.2.3).  I've clearly been carrying the name only practice around for waaay too long (https://www.w3.org/MarkUp/1995-archive/Elements/A.html)


Opening a modal gives html like : ng-class="size ? 'modal-' + size : ''". Is this correct?

Hi,
I was playing with the Modal demo (https://angular-ui.github.io/bootstrap/)
I saw as result of clicking on a button to launch a modal dialog following html code:

I'm a modal!

                    item1

                    item2

                    item3

            Selected: item1

            <button ng-click="ok()" type="button" class="btn btn-primary">OK</button>
            <button ng-click="cancel()" type="button" class="btn btn-warning">Cancel</button>

Forgotten to include the code in {{ }}?

Forgotten to include the code in {{ }}?

Why do you say so? @ericvb is there any particular problem that you are seeing? Could you clarify what is the issue here?

It seems not to be a problem to use the modal.
I was just curious about this piece of code. What's the meaning of it?

I was just curious about this piece of code. What's the meaning of it?

It is an expression evaluated by the ngClass directive:

Expression to eval. The result of the evaluation can be a string representing space delimited class names, an array, or a map of class names to boolean values. In the case of a map, the names of the properties whose values are truthy will be added as css classes to the element.

We are in the "a string representing space delimited class names" case here.

Thanks to clarify this.
We don't stop to learn ;-)


Increase coverage

Some Refactoring and some more tests.
Also closes #54.

93% Coverage

Why is this a draft? Can I help you to get it ready for merging?


Slow rendering of detail grid

I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request

Current behavior
Slow rendering of the detail rows
Expected behavior
Should be the same speed as the master grid
Minimal reproduction of the problem with instructions
Plunker: https://plnkr.co/B0fXvdiaAXCdskmxwZdo
What is the motivation / use case for changing the behavior?
The grid is not usable anymore as it is slow in use
Please tell us about your environment:
Does not apply as it is shown in the plunker

ag-Grid version: 11.0.0

Browser:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Language: [TypeScript 2.1.1]

Hi
Thanks for reporting this - Ive raised AG-613 our side to track this. We'll update this thread with updates as soon as we have any
thanks

Hi
Having taken a further look we can see that this is because the detail grid is massive - try setting the detail grid to be smaller (it'll then have a scrollbar) and it should render fine

Hi,
This is really a problem as it is not very user friendly to have a scrollbar inside a grid with also a scrollbar. Can this be solved as this is a major blocker?

@seanlandsman is there any solution for this?


[d3d9] Artificial Academy 2 male semi transparent body explosion.

If "Render 2" is enabled in the game settings, the semi-transparent male body (silhouette) will explode in love scenes.
The following creature-like silhouette should properly take the form of a man.

Software information
Artificial Academy 2 (with AA Unlimited)
System information

CPU: i7 6700
GPU: Nvidia GeForce GTX 1070
Driver: 536.40
DXVK version: 2.2

Apitrace file(s)
https://drive.google.com/file/d/1aIgi_sFUIkpen--B2RyNq996hSPuTUtZ/view?usp=sharing
Log files

log update. sorry wrong log.

@Arkblade2015 Could you add a disclaimer above the apitrace link that it contains nsfw sexual content?
I can reproduce the issue when replaying the trace both with dxvk on Windows and on Linux with radv.
It happens at the end where you will see the silhouette of the man is almost a big blueish blob instead of a human figure.
Below are a couple of censored screenshots taken on Windows with and without dxvk so it's easier to compare.

Screenshots (SFW)
dxvk

Native

I am very sorry.
I will add a note of caution.

Fixed by commit https://github.com/doitsujin/dxvk/commit/7f1e52703d921e957057e21a02079619f05d8f67


Fixed packet/package typo, added brew instructions

I think it would be an improvement since Homebrew can also be used on Linux.

I think it would be an improvement since Homebrew can also be used on Linux.

Ah, I didn't know about that. Yes, then that change would be welcome 🙂

I changed it for you, hope that's ok for you.
Thanks for the fix, @cam8001!