Responsive layout support

Having something like the Bootstrap grid makes development of responsive layouts super-easy. I suppose this could be integrated into Flexx relatively easy by providing a property on Widgets with which you can set flex-wrap, or by providing properties with which you can set the breakpoint from which they hold (like Bootstrap's col-md-2 etc.).
This will probably require some discussion! We could alternatively look into enabling the use of systems like Bootstrap, although I don't see a short path to get there...

Gave this some more thought and wrote some things down. It's quite a lot, apologies in advance for that.
In order to realize a semantically correct HTML/CSS based layout without jumping through hurdles, we'd need to borrow a bit more from react.js, in the sense that we need to be able to provide class names, and that widgets should map directly to HTML elements. E.g. to implement a comment box widget using Bootstrap, we'd need something like the following, where a new html module is introduced that has widgets which map 1:1 to HTML elements. This html module can live independently from the ui module, allowing two methods of constructing an interface to users.
class Comment(ui.Widget):
    @event.prop
    def author(self, val):
        return val

    @event.prop
    def date(self, val):
        return val

    @event.prop
    def content(self, val):
        return val

    def init(self):
        with html.Div(className="row comment-meta"):
            self.author_div = html.Div(className="col-md-6 comment-author")
            self.date_div = html.Div(className="col-md-6 comment-date")
        with html.Div(className="row comment-content-container"):
            self.content_div = html.Div(className="col-xs-12 comment-content")

    @event.connect('author')
    def on_author(self, *events):
        self.author_div.text = events[-1].new_value

    @event.connect('date')
    def on_date(self, *events):
        self.date_div.text = events[-1].new_value

    @event.connect('content')
    def on_content(self, *events):
        self.content_div.text = events[-1].new_value

We can place it in a page like this and our Bootstrap layout should work:
class Page(ui.Widget):
    @event.prop
    def comments(self, val=None):
        if val is None:
            val = []
        return val

    def init(self):
        with html.Div(className="container") as self.comment_container:
            self.comment_widgets = []
            for comment in self.comments:
                self.comment_widgets.append(widgets.Comment(author=comment['author'], date=comment['date'], content=comment['content']))

    @event.connect('comments')
    def on_comments(self, *events):
        for w in self.comment_widgets:
            w.parent = None
        self.comment_widgets = []
        for comment in self.comments:
            self.comment_widgets.append(widgets.Comment(author=comment['author'], date=comment['date'], content=comment['content']))

Borrowing render() from react.js would allow state management to simplify. Flexx can tell when a property changes, and thus know when to re-render the widget:
class Comment(ui.Widget):
    @event.prop
    def author(self, val):
        return val

    @event.prop
    def date(self, val):
        return val

    @event.prop
    def content(self, val):
        return val

    def render(self):
        with html.Div(className="row comment-meta"):
            html.Div(className="col-md-6 comment-author", text=self.author)
            html.Div(className="col-md-6 comment-date", text=self.date)
        with html.Div(className="row comment-content-container"):
            html.Div(className="col-xs-12 comment-content", text=self.content)

react.js has reduced boilerplate by giving widgets an automatically evented props property (and state too, which is like props but private), and providing a method where you can provide the initial state:
class Comment(ui.Widget):
    def init(self):
        return dict(author=None, date=None, content=None)

    def render(self):
        with html.Div(className="row comment-meta"):
            html.Div(className="col-md-6 comment-author", text=self.props.author)
            html.Div(className="col-md-6 comment-date", text=self.props.date)
        with html.Div(className="row comment-content-container"):
            html.Div(className="col-xs-12 comment-content", text=self.props.content)

class Page(ui.Widget):
    def init(self):
        return dict(comments=[])

    def render(self):
        with html.Div(className="container"):
            for comment in self.props.comments:
                widgets.Comment(author=comment['author'], date=comment['date'], content=comment['content'])

The react.js tutorial provided some key insights that lead to this post.

The default style prevents vertical scrollbars on the window. I had to make some changes to the default Flexx styling. This particular example has min-height equal to the viewport-height (using vh units), so that the footer element will stick to the bottom, even if there isn't enough content to push it all the way down. If there's more content than can fit the window, you'll get a vertical scrollbar, as desired for a responsive layout.
from flexx import app, ui

class ResponsiveApp(ui.Widget):
    CSS = """
    body {
      /* make sure the page has _at least viewport height_ so that the footer sticks to the bottom, even if there
         is not enough content
      */
      display: flex;
      min-height: 100vh;
      flex-direction: column;
      /* reset flexx default style */
      height: auto;
    }

    .flx-main-widget {
      /* this magic widget needs to stretch to fit <body>, to allow the footer to stick to the bottom of the viewport */
      flex: 1;
      /* reset flexx default style */
      width: auto;
      height: auto;
    }
    """

    def init(self):
        with ui.VBox():
            ui.Label(text="Header.")
            with ui.Widget(flex=1):
                self._content = ui.Label(text="Some content.", wrap=True)
            ui.Label(text="Sticky footer.")

Notes after discussion:

Scrolling can be implemented on a widget (using overflow-y:scroll), which will make the case above much easier (no fiddling with the CSS of body).
A ui.Div element would help web developers a lot to "do their thing" inside a Flexx app.
Additionally, a ui.html object that can be used to do ui.html.Ul(...) to generate Div elements of specific types would make things even easier (and scales better than implemening a separate Widget for each possible html element).
As mentioned elsewhere, the docs on how to load additional assets should be improves.
A section in the docs on how to use Flexx as a web dev would be nice.


Test the client package with an existing Eris bot in typescript

Bots Tested:

[x] NayuBot (https://github.com/AwesomeStickz/Nayu-Bot)

Untested

[ ] https://github.com/Member-Counter/bot
[ ] Gamer-eris repo (private repo @Skillz4Killz )

If anyone knows any other eris bots(in typescript), please link them below


name change in Maternity/parental leave on Careers & MyHR

Looks like this one has been done - https://www2.gov.bc.ca/gov/content/careers-myhr/all-employees/leave-time-off/maternity-parental-pre-placement-adoption/maternity


Move prettier from devDep to dep

Fixes #24

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   82.08%   82.08%
=======================================
  Files           3        3
  Lines          67       67
=======================================
  Hits           55       55
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa33bd7...670075c. Read the comment docs.

ok if you fix the PR title :) you actually move prettier from dev to devDep, not the vice versa.


[BEAM-562] Add DoFn.setup and DoFn.teardown to Python SDK

DoFn.setup and DoFn.teardown is currently supported in Java but not Python. These methods are useful for performing expensive per-thread initialization. This change adds those methods to make the Python SDK more consistent with the Java SDK. It also modifies the direct runner to invoke these methods.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@charlesccychen PTAL

Hi @kennknowles, would you be willing to be the primary reviewer on this since @charlesccychen is unavailable for a while?

Sure, I would be happy to.

Thank you! Could you also let me know which of your previous review comments are still actionable?

I cannot reply to this comment in place

If self._perform_dofn_pickle_test is false, it looks like it is not cloned but comes directly from self._appliedptransform.transform.dofn. Is the whole appliedptransform clone per bundle?

applied transform will be a new instance for each bundle (for direct runner). (See: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/direct/executor.py#L366)

That line does not show a cloning of appliedptransform...
On Fri, Apr 19, 2019 at 3:44 PM Ahmet Altay<EMAIL_ADDRESS>wrote:

I cannot reply to this comment in place
If self._perform_dofn_pickle_test is false, it looks like it is not cloned
but comes directly from self._appliedptransform.transform.dofn. Is the
whole appliedptransform clone per bundle?
applied transform will be a new instance for each bundle (for direct
runner). (See:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/direct/executor.py#L366
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/7994#issuecomment-485031290, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEMO6ONQUU57D4336BHZS3PRJDNRANCNFSM4G36BRSA
.

That line does not show a cloning of appliedptransform...
…
On Fri, Apr 19, 2019 at 3:44 PM Ahmet Altay @.***> wrote: I cannot reply to this comment in place If self._perform_dofn_pickle_test is false, it looks like it is not cloned but comes directly from self._appliedptransform.transform.dofn. Is the whole appliedptransform clone per bundle? applied transform will be a new instance for each bundle (for direct runner). (See: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/direct/executor.py#L366 ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7994 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEMO6ONQUU57D4336BHZS3PRJDNRANCNFSM4G36BRSA .

You are right, I confused by evaluator.  perform_dofn_pickle_test defaults to True, and there is only one path that is setting to false related to sdf evaluation.
I think we should clone by default, probably by getting rid of that flag. I am not sure why we had the flag in the first place, but I am guessing there will be an underlying issue.

If self._perform_dofn_pickle_test is false, it looks like it is not cloned but comes directly from self._appliedptransform.transform.dofn. Is the whole appliedptransform clone per bundle?

I added some pdb breakpoints and confirmed that the DoFn is cloned during the test and that the lifecycle methods are called on the clones. See this thread for where the cloning occurs.
(I am also unable to reply to this comment for some reason.)

Added a test to ensure that shutdown is called on DirectRunner. PTAL
I discovered that metrics counter increments during setup and teardown will not be registered in the pipeline result metrics. I'm not sure if this should be considered a bug, since setup and teardown may could happen outside the pipeline run (it happens within the pipeline run for DirectRunner, but not necessarily for other runners) I looked at the metrics API, but could not figure out how to set up the metrics environment correctly for those stages. @aaltay do you have any suggestions on how to handle this?

@pabloem or @ajamato will likely have a more informed opinion than myself. Pablo, Alex, what is the expected behavior for metric in setup/teardown?

Hmm my initial gut reaction is to think that metrics are computed / committed as part of a bundle, and setup/teardown are not part of bundle execution.
on the other hand, I can imagine user wanting access to metrics from setup/teardown... So perhaps I'd say to file a bug so we figure out what's necessary to make metrics available there...

@pabloem Your correct that setup/teardown are not part of bundle execution but are part of the DoFn lifecycle.
Metrics outside of a bundle do make sense since you may want to capture something like memory usage, CPU utilization, caching stats, ... that cross bundle boundaries or are global. A lot of this falls under worker "health" though.

@yifanmai In addition to filing a bug related to metrics, could this PR move forward?

Yes, I think so. I will open a bug to track the fact that metrics in shutdown. (I will do it after this PR otherwise the bug will not make sense.)
I have addressed the earlier feedback regarding adding tests to make sure that shutdown is called; @aaltay could you and @kennknowles take another look?

The change LGTM. But there are test errors. Please take a look at those.
(If you need help with py3 compatibility, cc: @tvalentyn could help.)
One I found in the logs is the following, there might be other errors as well:
6:57:54 FAILED (SKIP=448, errors=24, failures=5)
16:57:54 ERROR: InvocationError for command '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py35/build/srcs/sdks/python/target/.tox-py35-cython/py35-cython/bin/python setup.py nosetests' (exited with code 1)
16:57:54 ___________________________________ summary ____________________________________
16:57:54 ERROR:   py35-cython: commands failed
16:58:01   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
16:58:01     self.run()
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/local_job_service.py", line 245, in run
16:58:01     self._pipeline_proto)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py", line 281, in run_via_runner_api
16:58:01     return self.run_stages(*self.create_stages(pipeline_proto))
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py", line 357, in run_stages
16:58:01     stage_context.safe_coders)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py", line 521, in run_stage
16:58:01     data_input, data_output)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py", line 1227, in process_bundle
16:58:01     result_future = self._controller.control_handler.push(process_bundle)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py", line 842, in push
16:58:01     response = self.worker.do_instruction(request)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py", line 342, in do_instruction
16:58:01     request.instruction_id)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py", line 382, in process_bundle
16:58:01     self.bundle_processor_cache.discard(instruction_id)
16:58:01   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py", line 314, in discard
16:58:01     self.active_bundle_processors[instruction_id].shutdown()
16:58:01 AttributeError: 'tuple' object has no attribute 'shutdown'

@kennknowles @aaltay tests are passing now. PTAL?

Run Python PostCommit

Fails with a py3 error, not sure how it is related:
22:36:06   File "/usr/local/lib/python3.5/site-packages/apache_beam/runners/worker/sdk_worker.py", line 613, in _blocking_request
22:36:06     raise RuntimeError(response.error)
22:36:06 RuntimeError: java.lang.ClassCastException: java.lang.String cannot be cast to [B

Run Python PostCommit

The shutdown assert is breaking in Dataflow also (because it only works for in-process). Can I delete that assert, or disable it for Dataflow?
14:22:11 Traceback (most recent call last):
14:22:11   File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python3_Verify_PR/src/sdks/python/apache_beam/transforms/dofn_lifecycle_test.py", line 90, in test_dofn_lifecycle
14:22:11     self.assertTrue(_global_teardown_called)
14:22:11 AssertionError: False is not true

The shutdown assert is breaking in Dataflow also (because it only works for in-process). Can I delete that assert, or disable it for Dataflow?
Let's delete it. I do not think it will be easy to assert just for Dataflow runner.

Run Python PostCommit

Failing at :beam-sdks-python:crossLanguageTests, which is suspicious since it works for me when run locally.
13:26:16 [grpc-default-executor-0] ERROR org.apache.beam.runners.fnexecution.jobsubmission.InMemoryJobService - Encountered Unexpected Exception for Invocation job_de1c9355-5fa3-48c7-bedd-29035031739a
13:26:16 org.apache.beam.vendor.grpc.v1p13p1.io.grpc.StatusException: NOT_FOUND
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.Status.asException(Status.java:534)
13:26:16 	at org.apache.beam.runners.fnexecution.jobsubmission.InMemoryJobService.getInvocation(InMemoryJobService.java:341)
13:26:16 	at org.apache.beam.runners.fnexecution.jobsubmission.InMemoryJobService.getStateStream(InMemoryJobService.java:262)
13:26:16 	at org.apache.beam.model.jobmanagement.v1.JobServiceGrpc$MethodHandlers.invoke(JobServiceGrpc.java:770)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:171)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.PartialForwardingServerCallListener.onHalfClose(PartialForwardingServerCallListener.java:35)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.ForwardingServerCallListener.onHalfClose(ForwardingServerCallListener.java:23)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.ForwardingServerCallListener$SimpleForwardingServerCallListener.onHalfClose(ForwardingServerCallListener.java:40)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.Contexts$ContextualizedServerCallListener.onHalfClose(Contexts.java:86)
13:26:16 	at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:283)

Run Python PostCommit

Thank you @yifanmai !

Thanks @aaltay, @kennknowles and @charlesccychen for your help!
I added https://issues.apache.org/jira/browse/BEAM-7340 to track the issue related to metrics in DoFn.teardown, as discussed earlier.

@yifanmai is this also expected to work for unbounded sources? I don't get it to work when reading from pubsub....

@NikeNano it should work with all dofns regardless of the types of sources. If that is not working, please file an issue.

OK, thanks @aaltay. Will investigate further and file an issue if i don't get it to work.

Created issues for DoFn.setup, https://issues.apache.org/jira/browse/BEAM-7885


Remove Microsoft.AspNet.WebApi.Client dependency

This dependency is used in only one place to parse query parameters and can be easily avoided.
Also this lib works only for net45 and this generates annoying warning.

@Soarc,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

thanks! This warning indeed annoyed me ;)


Weather Info Source

Hello,
This is just a friendly suggestion based on my experience. I want to suggest that it would be smart to let people know where you are sourcing weather details for this project to work.
I was frustrated in having to dig into your code in order to find out that your using wttr.in. Which in turn uses WMO (World Meteorological Organization) and NWS (National Weather Service) from what I'm hearing.
Reason this is important is that I live in a place where it's harder to predict accurate weather. And different weather organizations do better with their predictions then others. Not having this detail upfront would be one strong reason for me to walk away from using your project.
Adjustments could be something simple as putting a line or two in the main README for this projects repo.
I hope that this helps. Thanks for taking time to read this.

Hai! Thank you so much for this. Will do!

After looking at wttr.in's source, it seems that the project uses World Weather Online though, as noted from this function.

Ah, Interesting. I saw something else in a different file. I'll see if I can dig that up in case that is useful for you. Thanks for looking into this.

Also, just as a side note, here is where I found that your lib used wttr.in:
See: python-weather/python_weather/client.py (line 87).
https://github.com/null8626/python-weather/blob/3b5f8fe31733643fe840b37159d4a8e43a043d57/python_weather/client.py#L87)
Which I believe is your current for your main branch for that file.
I'm curious now where I saw that it was WMO and not WWO for my source of info. If I find it and it seems useful or helpful, I likely share that info.


Help please

I need to add new json file or new filed to existing data , how to do it ??

Unfortunately standalone UI is still under initial development and #292 is required to be implemented to do that.
Duplicates #292


Possible issues with Docker setup

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem

Description
Can't seem to receive any mail to any of the aliases whatsoever. In the logs it shows that during the time postfix processes emails something can't access database? I may be completely off but could it be related to https://github.com/anonaddy/docker/blob/3de44c7adf9088d6ae5928bc4fc3cbfd1af696f5/rootfs/etc/cont-init.d/15-config-postfix.sh#L22 ?
Expected behaviour
All emails successfully received by all aliases.
Actual behaviour
No emails received, getting 451 4.3.5<EMAIL_ADDRESS>Recipient address rejected: Server configuration problem
Steps to reproduce

create compose using file content in Docker Compose config step
create any random alias name
test send email swaks --to<EMAIL_ADDRESS>--from<EMAIL_ADDRESS>--server mail.xxx.yyy --ehlo mail.xxx.yyy or just using any client to that alias

Docker info
Client: Docker Engine - Community
 Version:    25.0.2
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.12.1
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.24.5
    Path:     /usr/libexec/docker/cli-plugins/docker-compose

Server:
 Containers: 12
  Running: 4
  Paused: 0
  Stopped: 8
 Images: 8
 Server Version: 25.0.2
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  apparmor
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.5.0-21-generic
 Operating System: Ubuntu 23.10
 OSType: linux
 Architecture: x86_64
 CPUs: 1
 Total Memory: 1.866GiB
 Name: mail.xxx.yyy
 ID: 98be9f38-8158-4cb9-89b7-4dd92fd97192
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

Docker Compose config
name: anonaddy
services:
  AnonAddy:
    depends_on:
      MariaDB:
        condition: service_started
        required: true
      Redis:
        condition: service_started
        required: true
    deploy:
      resources:
        limits:
          memory: "536870912"
    environment:
      ANONADDY_BANDWIDTH_LIMIT: "10485760000"
      ANONADDY_DKIM_SIGNING_KEY: /data/dkim/xxx.yyy.private
      ANONADDY_DOMAIN: xxx.yyy
      ANONADDY_ENABLE_REGISTRATION: "false"
      ANONADDY_HOSTNAME: mail.xxx.yyy
      ANONADDY_SECRET: ggggggg
      ANONADDY_SIGNING_KEY_FINGERPRINT: ggggggg
      APP_KEY: base64:ggggggg
      APP_NAME: xxx.yyy
      APP_URL: http://mail.xxx.yyy:8000
      DB_DATABASE: anonaddy
      DB_HOST: mariadb
      DB_PASSWORD: ggggggg
      DB_USERNAME: anonaddy
      MAIL_FROM_ADDRESS<EMAIL_ADDRESS>      MAIL_FROM_NAME: AnonAddy
      POSTFIX_SMTP_TLS: "true"
      POSTFIX_SMTPD_TLS: "true"
      POSTFIX_SMTPD_TLS_CERT_FILE: /certs/live/mail.xxx.yyy/fullchain.pem
      POSTFIX_SMTPD_TLS_KEY_FILE: /certs/live/mail.xxx.yyy/privkey.pem
      REDIS_HOST: redis
      RSPAMD_ENABLE: "true"
      RSPAMD_WEB_PASSWORD: ggggggg
      TZ: Europe/Vilnius
    image: anonaddy/anonaddy:1.0.9
    networks:
      anonaddy: null
    ports:
      - mode: ingress
        target: 25
        published: "25"
        protocol: tcp
      - mode: ingress
        target: 8000
        published: "8000"
        protocol: tcp
      - mode: ingress
        target: 11334
        published: "11334"
        protocol: tcp
    restart: unless-stopped
    volumes:
      - type: bind
        source: /home/ubuntu/anonaddy/anonaddy/data
        target: /data
        bind:
          create_host_path: true
      - type: bind
        source: /home/ubuntu/certbot/certs
        target: /certs
        bind:
          create_host_path: true
  MariaDB:
    deploy:
      resources:
        limits:
          memory: "134217728"
    environment:
      MYSQL_DATABASE: anonaddy
      MYSQL_PASSWORD: ggggggg
      MYSQL_ROOT_PASSWORD: ggggggg
      MYSQL_USER: anonaddy
    expose:
      - "3306"
    image: mariadb:11.0.3
    networks:
      anonaddy: null
    restart: unless-stopped
    volumes:
      - type: bind
        source: /home/ubuntu/anonaddy/mysql/data
        target: /var/lib/mysql
        bind:
          create_host_path: true
      - type: bind
        source: /home/ubuntu/anonaddy/mysql/tune.cnf
        target: /etc/mysql/conf.d/tune.cnf
        bind:
          create_host_path: true
  Redis:
    command:
      - redis-server
      - --save
      - 60 1
    deploy:
      resources:
        limits:
          memory: "33554432"
    expose:
      - "6379"
    image: redis:7.0.12-alpine3.18
    networks:
      anonaddy: null
    restart: unless-stopped
    sysctls:
      net.core.somaxconn: "65535"
    volumes:
      - type: bind
        source: /home/ubuntu/anonaddy/redis/data
        target: /data
        bind:
          create_host_path: true
networks:
  anonaddy:
    name: anonaddy_anonaddy

Logs
AnonAddy-1  | Feb 29 21:34:51 mail postfix/smtpd[911]: connect from xxx.xxx[yy.yy.yy.yy]
MariaDB-1   | 2024-02-29 19:34:51 17 [Warning] Access denied for user<EMAIL_ADDRESS>(using password: YES)
MariaDB-1   | 2024-02-29 19:34:52 18 [Warning] Access denied for user<EMAIL_ADDRESS>(using password: YES)
AnonAddy-1  | Feb 29 21:34:52 mail postfix/smtpd[911]: warning: problem talking to server private/policy: Application error
AnonAddy-1  | Feb 29 21:34:52 mail postfix/smtpd[911]: NOQUEUE: reject: RCPT from xxx.xxx[yy.yy.yy.yy]: 451 4.3.5<EMAIL_ADDRESS>Recipient address rejected: Server configuration problem<EMAIL_ADDRESS><EMAIL_ADDRESS>proto=ESMTP helo=<mail.zzzz.com>
AnonAddy-1  | Feb 29 21:34:52 mail postfix/smtpd[911]: disconnect from xxx.xxx[yy.yy.yy.yy] ehlo=1 mail=1 rcpt=0/1 quit=1 commands=3/4

### Additional info

This is instance with IPv6 and IPv4 attached

Are you able to access and login to the web application?

yes, absolutely, everything works from web app

@willbrowningme anything else I could help with while debugging? I can mount some debug-able files if needed to pinpoint the issue.

It is related to user=anonaddy argv=php /var/www/anonaddy/postfix/AccessPolicy.php. Are you able to check the contents of storage/logs/postfix-access-policy.log (I'm not sure where this is stored for the Docker image).

OK, I've found the bug. Try setting db password with # in docker compose....

It's already wrapped in docker-compose.yml. And If I enter container I can see the env variable with printenv, only in PHP there are issues. And what's weird is that only with this AccessPolicy.php as web app works without any issues.
All in all I've just destroyed database and run a new container with new password.

# is used for comments in .env files - https://github.com/vlucas/phpdotenv?tab=readme-ov-file#comments
If I enter DB_PASSWORD=secret#123 then dump $_ENV['DB_PASSWORD'] it returns secret missing out everything after the hash.
But if I enter DB_PASSWORD="secret#123" and then dump $_ENV['DB_PASSWORD'] it correctly returns secret#123.


Add IPv6 support to snapshot socket

Hi.
This PR adds IPv6 support to snapshot socket:
$ python
>>> import socket
>>> s = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
>>> s.bind(('::1', 8082, 0, 0))
>>> s.listen(5)
zsh: suspended  python3
$ sudo ig snapshot socket --host
CONTAINER                                                                PROTOCOL LOCAL                                  REMOTE                                STATUS
...
                                                                         TCP      ::1:8082                               :::0                                  LISTEN
...

Best regards.

While you're working on this, it would be nice to print the v6only bool from IPv6 sockets.
sk->__sk_common.skc_ipv6only

See https://github.com/inspektor-gadget/inspektor-gadget/issues/1776#issuecomment-1603030119
(could be done in a different PR)

I'll suggest to rebase this on top of https://github.com/inspektor-gadget/inspektor-gadget/pull/1895, the result code will be much simpler IMO.

I don't have any issue.

I also can implement ipv6 support on top of https://github.com/inspektor-gadget/inspektor-gadget/pull/1895, so we don't waste time reviewing this.

From my point of view, it makes much more sense to rebased this on top of the refactoring introduced in https://github.com/inspektor-gadget/inspektor-gadget/pull/1895, which IMO, is ready to go.


Fixed image issues

I resized the image to 50% of its size, cropped out the shadow/window border and converted it to a jpg for better compression. I also made it actually show up on the website (fixed the capitalization issues). Sorry about the shoddy first PR, my browser is case-insensitive when loading files, as it turns out.

Thanks, I thought it may be something like that.


fix broken links

i think the first entry was incorrectly modified ... it should read
something like:
Log queries are used to retrieve any log data from Azure Monitor. Whether
you’re analyzing data in the portal
https://docs.microsoft.com/en-us/azure/azure-monitor/log-query/portals
or configuring
an alert rule
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/alerts-metric
to
be notified of a particular condition, you will use a query to specify the
data you want.
Note the word *and  *formatting changes.

for the ksonnet post, i believe the link should just be removed and have
the plain text "announced" ... the link currently shows is abt corp
structure, not OSS projects.
On Sat, Apr 1, 2023 at 10:29 AM susan evans @.***>
wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/pulumi/pulumi-hugo/pull/2639
Commit Summary

05e74f8
https://github.com/pulumi/pulumi-hugo/pull/2639/commits/05e74f8b8a3f95bf953d5945f73d0d5d18a90a2c
fix broken links

File Changes
(9 files https://github.com/pulumi/pulumi-hugo/pull/2639/files)

M
themes/default/content/blog/create-aks-clusters-with-monitoring-and-logging-with-pulumi-azure-open-source-sdks/index.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-7a9a9f0c493e86149617c1f4c9debbe5a893d7ea6282a42053277fc691d68ff7
(3)
M
themes/default/content/blog/how-webiny-built-a-serverless-application-framework/index.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-2aa52b5cc3298161bfb1624efe5145d6ac09e125170d8d1bb5af3cff72fd7a59
(2)
M
themes/default/content/blog/if-you-liked-ksonnet-youll-love-pulumi/index.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-32d8a61da81b4420d07c16edeca5aeb138ee9e9f084b77ff196a3ff5f718b870
(2)
M themes/default/content/blog/pinpoint/index.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-dd3f433f6c364a943f8a65140f7da034edcdada92354114daa7cd8369d42198f
(4)
M themes/default/content/challenge/deployments.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-9a794199c9e3c8f98e5b26ab06e96908b5586192701f3220b78824028995b833
(2)
M themes/default/content/docs/intro/deployments/reference.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-3b2ff0b13bc72864f74f5716eb3badfbcd6df3c258d2896a4f8bc5385e1937a5
(2)
M themes/default/content/templates/kubernetes/gcp/index.md
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-f55380a112cbf38fbd289a63e601120aab2546984d2bb7076a3021e2f32665a5
(2)
M themes/default/data/newsroom.toml
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-351856870c2a1e3d8a19b04724e2a42ef3f18a696621802516e585755cd02962
(3)
M themes/default/layouts/page/newsroom.html
https://github.com/pulumi/pulumi-hugo/pull/2639/files#diff-d672307621015c8748e13c3bf9631b9c29185003f8bbc6dd557120cea8e585c5
(4)

Patch Links:

https://github.com/pulumi/pulumi-hugo/pull/2639.patch
https://github.com/pulumi/pulumi-hugo/pull/2639.diff

—
Reply to this email directly, view it on GitHub
https://github.com/pulumi/pulumi-hugo/pull/2639, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB77TQUWTSAXRLDJJFW5543W7BQWXANCNFSM6AAAAAAWPYE45E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


updated the style file for project section

#91

This code doesn't works, Watch the deploy preview  @Priyanshu-su30

Have u merged the css file??

@Priyanshu-su30 The deployed preview shows the changes a after merging

This code doesn't works, Watch the deploy preview @Priyanshu-su30

but this link shows the old file


action: use a different base imgae

gcr.io/distroless/static:nonroot does not allow us to run bash scripts, since with available crd we are capturing the exit via a bash script, moving to use
registry.access.redhat.com/ubi9/ubi-minimal as the base

Testing:
[rewantsoni scripts] ko logs ocs-client-operator-controller-manager-c5564f548-gxckj
2024-10-14T09:37:31Z    INFO    setup   setting up webhook server
2024-10-14T09:37:31Z    INFO    setup   registering Subscription Channel validating webhook endpoint
2024-10-14T09:37:31Z    INFO    controller-runtime.webhook      Registering webhook     {"path": "/validate-subscription"}

just for posterity #253, #256 and #257 is part of single feature.

Testing:

did you check the functionality as well, like manager is restarted on specific exit and container is restarted for any other reasons?

Testing -
2024-10-14T12:31:20Z    INFO    CustomResourceDefinition was Created.        {"controller": "storageclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClaim", "StorageClaim": {"name":"ocs-storagecluster-cephfs"}, "namespace": "", "name": "ocs-storagecluster-cephfs", "reconcileID": "09dc1867-2802-4401-bc5b-f241de34a741", "StorageClaim": {"name":"ocs-storagecluster-cephfs"}, "CustomResourceDefinition": "drclusterconfigs.ramendr.openshift.io"}
2024-10-14T12:31:20Z    INFO    Reconciling StorageClaim.       {"controller": "storageclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClaim", "StorageClaim": {"name":"drclusterconfigs.ramendr.openshift.io"}, "namespace": "", "name": "drclusterconfigs.ramendr.openshift.io", "reconcileID": "1e416f5d-4e86-4b8a-974f-7a245fd2bb5b", "StorageClaim": {"name":"drclusterconfigs.ramendr.openshift.io"}}
2024-10-14T12:31:20Z    INFO    setup   setting up webhook server
2024-10-14T12:31:20Z    INFO    setup   registering Subscription Channel validating webhook endpoint
2024-10-14T12:31:20Z    INFO    controller-runtime.webhook      Registering webhook     {"path": "/validate-subscription"}
2024-10-14T12:31:20Z    INFO    setup   starting manager

2024-10-14T12:31:55Z    INFO    CustomResourceDefinition was Deleted.        {"controller": "storageclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClaim", "StorageClaim": {"name":"ocs-storagecluster-cephfs"}, "namespace": "", "name": "ocs-storagecluster-cephfs", "reconcileID": "58fb61d5-acae-4f8e-aeb8-95550aac63c4", "StorageClaim": {"name":"ocs-storagecluster-cephfs"}, "CustomResourceDefinition": "drclusterconfigs.ramendr.openshift.io"}
2024-10-14T12:31:55Z    INFO    Reconciling StorageClaim.       {"controller": "storageclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClaim", "StorageClaim": {"name":"drclusterconfigs.ramendr.openshift.io"}, "namespace": "", "name": "drclusterconfigs.ramendr.openshift.io", "reconcileID": "2c9c5a37-91e2-49ac-9f7d-bbe2559d48e3", "StorageClaim": {"name":"drclusterconfigs.ramendr.openshift.io"}}
2024-10-14T12:31:55Z    INFO    setup   setting up webhook server
2024-10-14T12:31:55Z    INFO    setup   registering Subscription Channel validating webhook endpoint
2024-10-14T12:31:55Z    INFO    controller-runtime.webhook      Registering webhook     {"path": "/validate-subscription"}
2024-10-14T12:31:55Z    INFO    setup   starting manager
2024-10-14T12:31:55Z    INFO    controller-runtime.metrics      Starting metrics server
2024-10-14T12:31:55Z    INFO    starting server {"name": "health probe", "addr": "[::]:8081"}

Testing:

did you check the functionality as well, like manager is restarted on specific exit and container is restarted for any other reasons?

Yes, I checked it for any other exitcode/panic it restarts the container. For the restart exit code it restarts the manager


Implement function call results and feedback

This adds function call results to the messages stream and feeds back the results to GPT.
With this PR, CopilotKit can now:

retrieve information from the backend for context
present this information or use it in another function call
chain multiple function calls together and use results of previous function calls

For now, this is implemented by extending the OpenAI streaming protocol. The code needs cleanup by properly implementing our own streaming protocol between client and server.
fix #141

Hey @ataibarkai !
We need to add the scope field because the client does not know that the server has already executed the function. But we do need the function call and result from the server for the chat history.


Make AuthorizationCodeTokenGranter follow rfc6749

According to rfc 6749, redirect_uri is required on access token request.
And i add a simple test case for token request with no redirect_uri.

I misunderstood


Modify oops to use filecache

Modify oops, including spicedb, hosts, and golden tests, to use the new rms-filecache package.

This was fixed by #138


Fix exception message

Description
The exception message used the wrong attribute on the exception. This has never worked before.
I also added the url it tries to make the logs more clear.
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in b108a4edf5524883a0e93935121aed7b666ba08b

Processing #6671.


[docs]{WIP} aiconfig usage guide

[docs]{WIP} aiconfig usage guide

Reformatted structure as discussed offline with @saqadri

Python code snippets, needs updates to TS snippets as well
Extension section doesn't use an extension, just shows generic how to. Needs updating once packages are ready to be installed


TransformerUI: add initial macOS UI

This is modelled after the Windows UI, and looks very similar.  This
actually helps demonstrate the point that the usage of the model is
extremely similar.  This sets an initial starting point for
improvements.
The biggest issue with the implementation currently is the NSTextView
does not update frequently enough resulting in the text appearing at the
end.
The differences from the Windows implementation include the fact that
\n does not need to be replaced with \r\n, the scrollview for the
textview needs to be constructed manually, and the coordinate system
uses a different origin.

CC: @texasmichelle @BradLarson

I think it would be really useful to have an Xcode project within the Transformer/UI/macOS directory, so that people could quickly open that and build the application. For the application bundle to work right, we might need to set up a Copy Files build phase to copy the appropriate libraries into the bundle and maybe a rewrite rule to get the paths set right.
If you'd like, I could create this and push that in.
Additionally, we'd probably want to update the Readme with both CMake and Xcode build instructions for the macOS UI application.

I think that setting it up with SPM and having that generate the Xcode project or just using cmake to generate the Xcode project would be nicer than adding all the Xcode project cruft.
I can update the instructions in a follow up change :)

Working with Tony, we were able to get SwiftPM to build and run a functional AppKit application from this. To do so, you can add to Package.swift a product of
        .executable(name: "TransformerMacOSUI", targets: ["TransformerMacOSUI"]),

and a target of
        .target(
            name: "TransformerMacOSUI", dependencies: ["Transformer"], path: "Transformer",
            exclude: ["UI/Windows/main.swift", "main.swift"],
            sources: ["UI/macOS/main.swift", "TransformerLoop.swift"],
            linkerSettings: [
                .unsafeFlags(
                    [
                        "-Xlinker", "-sectcreate", "-Xlinker", "__TEXT", "-Xlinker", "__info_plist",
                        "-Xlinker",
                        "./Transformer/UI/macOS/Info.plist",
                    ], .when(platforms: [.macOS]))
            ]),

Currently, there's a conflict in that TransformerLoop.swift is used both by the TransformerDemo and this  TransformerMacOSUI target. PR #363 should solve this when it is merged, and we might want to get that one in before this.

@BradLarson I think that the file being re-used is not a real issue - the file is already being used by two targets, this is creating a third.  None of them actually change the behaviour or contents of the file, merely add an additional reference to it.  I think that it should be safe to merge this without impacting the work that @texasmichelle is working on.

@compnerd - Oh, by a conflict I mean that the same file is referred to as being part of two targets in SwiftPM, which the package manager throws errors about. If you add the above code in to insert this new target, you'll hit that error. Again, won't be a problem once that file is part of a shared library.

Ah, right, s-p-m cannot handle that case, CMake handles that just fine


add offline dictionary

Thank you for your help, and congrats on your first pr to this repo!!🎉
If you like this repo don't forget to 🌟.

My pleasure and Thank you


Update spring-boot version to 2.1.0-RC1

@jzheaux I do not see the 2.1.0.RC1 available in maven repository. Can you please confirm if the release process was ok?
Thanks

@DanielFran thanks for checking.
We moved the release to Monday to give some extra time on an issue that we didn't want to push past RC1. You should see it in maven on Monday.


Preserve Dataset.pipeline

Ensures that functionality relying on Dataset.pipeline (e.g. linked brushing) works with hvPlot output.

Coverage decreased (-0.09%) to 80.742% when pulling c58dca9b59404e23a6de5e7f7ef18533720de2fb on preserve_pipeline into 8dc94cb64791d5be3294cc6c964d4ceddf14a09c on master.


MM-35678 Detox/E2E: Add e2e for channel link and scrolling

Summary

Ticket Link

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates

Device Information
This PR was tested on:
Screenshots

Release Note

Hello @NotAnny,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers


Giving commands.

So, i knew the bots token which is of a bot in a server with admin perms. But im banned from that server. Can i give commands to the bot via the command panel?

@Phloraxx You cant, sorry.


Feature/add authz with opa to lab6

I have just realized that the language used in the docs points to we. The recommended way is to use you since we might lead to confusion: does we include me as a reader or only to the writers? i.e. From istio docs: https://istio.io/latest/docs/releases/contribute/style-guide/#avoid-using-we
I think it should be in another PR to not mess things up. What do you think?


Behave similarly to offline when server is not online.

Currently offline deactivates parts of the UI (add, edit, delete), however if the browser is online but the server is not those parts are enable.

This is to deal with the situation that the browser can connect to the server, but for some reason the server can't connect to GCP or its datastore? You think we should do something more than displaying internal server errors in this case?

Speaking in a more generic way, we need to account for the LieFi case (eg: timeout for resources form the server).

yes, that and that the server may be down but the user has connectivity.


Segmentation Fault

Hi, i'm completely new to flask sockets and sockets in general.
I installed flask_sockets successfully, copied the example code from the readme
i got a segmentation error when i ran it.

This is very strange, and I suspect an issue with gevent. Perhaps update to the latest version of gevent / play around with an older version if needed and see if the problem persists.

P.S. That's a crazy terminal font! I don't think I'd be able to get any work done with that at all. Is it a dyslexic-easing typeface? Doesn't look monospaced at first glance, but I think it actually is. Interesting.

My gevent is up to date -- says pip.
I'll play around with older versions. You mind suggesting any particular version?

Also, here's a link to my font. I see you are interested in it "too".
Hangyaboly - http://www.dafont.com/hangyaboly.font

This also happened to me.  Downgrading from gevent 1.2.0 to gevent 1.0.2 made the segment fault go away.  This happened only on my MacBook Air (not on some other Ubuntu computer I own).
The original problem for me was that using the flask_sockets.worker gunicorn worker made gunicorn to keep binding/creating workers indefinitely (with new pids each).  That is, 'gunicorn -k flask_sockets.worker app:app' would spam 'Binding worker ....', while 'gunicorn app:app' would correctly only bind 1 worker.  Again, this only happened on my Mac (on my Ubuntu it gevent 1.2.0 worked fine).
Anyhow, not sure what the real problem is, just thought I'd share my experience!  I'm staying on gevent 1.0.2 for the time being.


Publish 8.5-20231109013054+0000

Publish 8.5-20231109013054+0000

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Add UWA (Pheme)

"Pheme is the UWA Access Management System, a place where you can set a password for your central university account giving you access to a range of services."

Thank you!


no syntax highlight on pug

here's example output from aye mirage

I've optimized pug with the same syntax highlighting logic as css. You can now update this extension and see if you are satisfied with it.

Closed since I haven’t received a response for too long, and I personally think this problem has been solved.


Ambassador should support sending x-request-id

Please describe your use case / problem.
Today, if you use Ambassador as your front API gateway then it is the first service to receive any request. As a result, if tracing is enabled then it is responsible for starting a trace as well as the first span. If Ambassador has an issue (either itself or with a downstream service) then ideally it should send the x-request-id back to the client so it can be used to search for relevant traces. Today, Ambassador does not.
Describe the solution you'd like
Ambassador should support sending x-request-id
Describe alternatives you've considered
Using something that supports x-request-id in front of Ambassador
Additional context
https://www.envoyproxy.io/docs/envoy/latest/configuration/http_conn_man/headers#config-http-conn-man-headers-x-request-id states that it is beyond the scope of Envoy to provide this functionality. This means Ambassador would need to implement something.

Possible duplicate of #968...

Yeah, closing as a dup of #968; copying additional context here into that issue. Thanks!


bugfix: remove usages of TRANSFER_SERVER and TRANSFER_SERVER_SEP0024

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[x] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Remove all usages of sep6_enabled and TRANSFER_SERVER, since SEP-6 is currently not supported.
Remove unnecessary usages of and TRANSFER_SERVER_SEP0024, since SEP-24 support is part of the SDK but not officially part of the platform yet.
Why
Close #326
Further work
We need to do the same in stellar/kube.

Reference Server Preview is available here:https://anchor-ref-pr329.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr329.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr329.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr329.previews.kube001.services.stellar-ops.com/


feat: Support -n flag

In most shells there's a -n flag for checking syntax, but not executing any of the input the shell gets, e.g. https://media.discordapp.net/attachments/761279800312332328/838790971617312858/unknown.png
Hilbish should also support this, and check all the lua that the user entered (+ maybe the bash input?).
This flag can be used for checking shell scripts for basic syntax errors, without risking to having to run a script.

Whoops, didn't see that you updated it

checking both lua and sh input won't work well (or wouldn't at all)

copy pasting what I said in discord:
hilbish in interactive mode executes lua but if it errors it just runs input as sh
but since with -n ur deliberately checking if there's syntax errors having the single switch for both doesn't work


operator uma-operator (2024.4.2)

/test skip check_pruned_graph

/ok-to-test

@mn660971: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

/ok-to-test

/pipeline restart operator-hosted-pipeline

/test skip check_pruned_graph

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test


Matrix element

As per #297

@rultor merge

@rultor merge

@vssekorin OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@vssekorin Oops, I failed. You can see the full log here (spent 11s)
+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 3889870
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Mon 08 Aug 2022 11:44:59 PM CEST
+ uptime
 23:44:59 up 41 days,  1:46,  0 users,  load average: 0.00, 0.02, 0.00
+ cat
.rultor.yml file must be present in root directory of vssekorin/home, see https://doc.rultor.com/reference.html#assets
+ exit -1
'cid' file is absent, most probably the Docker container wasn't started correctly

@rultor hello

@rultor hello

@vssekorin Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)


modules/clock: improve ux when calendar_shift is used

I've tried to improve ux in the clock module when calendar_shift is used:

Alter only the date, not the time (see the difference in the videos below).
Use shifted values only in the tooltip; when scrolling, the date will change only there.
When the mouse leaves (the popup closes), the shift is reset.

current waybar 0.9.16
https://user-images.githubusercontent.com/449375/209773492-5af428ba-6e22-4ddd-9085-5c181590162c.mp4
after proposed changes
https://user-images.githubusercontent.com/449375/209773501-fae54cc5-7ad6-43e1-bbd9-73ebeaea0c27.mp4

Thx!


Documentation edits

Adds a new page on generic problem of importing tabular data including new feature for handling Antelope called DatascopeDatabase.  Also fixes a number of small errors sphynx detected I didn't notice earlier.
Note sphynx is still throwing some errors that are related to two issues:

Some formatting errors in docstrings it is cross referencing
References to functions or classes not yet in master as the additions are in pending pull requests.

The error from cmake seems to be a bug in their latest release and it has been fixed. Basically, it was giving the wrong path to the pybind11 we installed.


Meltano UI does not remember connection used in Meltano Analyze

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/804
Originally created by @iroussos on 2019-07-17 10:01:48

Meltano UI does not remember the user's selection of the connection used.
Way to reproduce:

Set a connection to postgres
Go to any model.design
Select the postgres as the connection and generate a query
Go back to the design selection by clicking Analyze on the header or Models on the Analyze top bar.
Select again the same design (or any other for what is worth)
The connection is switched to sqlite and you get an error when you add any attribute.

Not remembering the selection of which connection a user uses is at least an annoyance and it could result in many users not understanding that they have to set the connection up there on the right.

View 3 previous comments from the original issue on GitLab


How to deblur a single motion blurred image?

Thanks for your work. I want to use code to deblur a single motion blurred image. I have studied the fmo_deblurring_benchmark.py script, and it seems that it needs the ground truth information of the gt_bbox box. How can I modify it to skip this supervision information and deblur a single motion blurred image?

Dear @jiachen0212 ,
The bounding box is there since it is required by the benchmarks. You actually do not need to provide a bounding box.
The deblurring and trajectory and shape estimation happens from [https://github.com/radimspetlik/SI-DDPM-FMO/blob/217a300bf7999d8518468e3bc7c272f96aa1a3ab/fmo_deblurring_benchmark.py#L166](the line 166 in fmo_deblurring_benchmark.py) and the image sequence is created on [https://github.com/radimspetlik/SI-DDPM-FMO/blob/217a300bf7999d8518468e3bc7c272f96aa1a3ab/fmo_deblurring_benchmark.py#L247](the line 247).
Hope this helps...


Make a test transaction periodically

Codecov Report

Merging #387 (bc346f8) into develop (55034e9) will increase coverage by 16.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #387       +/-   ##
============================================
+ Coverage    71.15%   87.18%   +16.02%
============================================
  Files           68       34       -34
  Lines         2330     1116     -1214
  Branches       351      160      -191
============================================
- Hits          1658      973      -685
+ Misses         672      143      -529

Flag
Coverage Δ

batch-submitter
?

contracts
87.18% <ø> (ø)

core-utils
?

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ices/l1-ingestion/handlers/transaction-enqueued.ts

...h-submitter/src/batch-submitter/batch-submitter.ts

...ices/l1-ingestion/handlers/state-batch-appended.ts

packages/core-utils/src/coders/sequencer-batch.ts

packages/core-utils/src/watcher.ts

packages/core-utils/src/l2context.ts

packages/core-utils/src/common/test-utils.ts

packages/core-utils/src/common/hex-strings.ts

packages/batch-submitter/src/utils/index.ts

...ubmitter/src/batch-submitter/tx-batch-submitter.ts

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55034e9...bc346f8. Read the comment docs.


[Feature]: Restore command support tighter integration with S3

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Currently the appsmithctl restore command only lists the local backup archives, and not the ones on S3. In order to restore one from S3, users are expected to download the file from S3 themselves and then use the restore command.
A tighter integration where the restore command checks S3, lists the available archives, downloads the chosen one, and then restores would create a more seamless experience.
Why should this be worked on?
This will make using the restore command with S3 integration much easier.

I believe this is solved now. Slack discussion


Correct gitflow graphic for contributing doc

Switched from a static PNG to using Mermaid to generate a gitGraph, and had the graph match our release process. Also updated a few details of the release process, including branch naming, and added the idea of a bugfix branch. Closing #11

The rendered Mermaid document can be viewed in the branch doc: https://github.com/DataONEorg/hashstore/blob/feature-11-contributions-doc/CONTRIBUTING.md

Confirming no further feedback from @taojing2002 and @robyngit


Restore postsb

Fixes #
Changes proposed in this pull request:

Improved progress reporting
Fixed am issue with strange paths coming through
Fixed some unwanted red message potentials
Better verbose output
And it's totally 100% more videogenic that the original!

How to test this code:

[ ]
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

hahahah videogenic!
This is GORGEOUS! Made one change.


require the application to handle 0-RTT rejection

Fixes #2067. Depends on #3073.
Implementing the proposal made in this issue, without the wrapper for the easy / common case.

Hi, I noticed the correct http3 client would not handle the "0-RTT rejected" correctly. The http3 client will only raise the error to the user if it received this error and will not resend the request.
Or do I have the wrong expectation for the http3 client? Should It be defined as an application? If it shouldn't be considered as an application, as an end-user when I received the "0-RTT rejected" error from the http3 client, should I manually call the "Do" function again?
In this case, will the first data packet be the "1-RTT" case, or actually the "2-RTT" case?


Fix for black text on iOS 7 and up

When textStorage is used, the textColor and font have no effect when no
text is set when the view is initialised. Therefore the attributes need
to be set explicitly.

tnx!


Update progress.json to show oldest file

will be good to keep track of how often everything get's updated

Started work here: https://github.com/LukePrior/nbn-upgrade-map/commit/0472f5a266db77df7f955753db4235b714499a7f

Where's your unit-test bro? :)

It will come :)
(making me write good code...)

I know it's your project, but maybe you should use PRs too :P

Where is this at?


Is there a way to Enable offline data

As seen on the official docs, Cloud firestore enables you to use the cache when you loose the internet connection so that the app does not break.  Is there an easy way to configure this here?
You can check out the article here: firestore enable persistence link
It would be great to be able to easily manually disable and enable network access programmatically as seen on that page as well.
Thank you.

You can inject the firebase service and setup whatever you need from there.

Closing issue as question has been answered


Adding About section in main page

I'm a contributor to GSSOC'23 please assign this issue to me as a part of GSSOC'23. @anmode

I want to contribute in this


delete files

I've set up the uploading just fine, but I want to give the option to users to remove the uploaded file and when they use that option, I want to really remove it from disc.
How should I do this?

In ActiveRecord, Refile will automatically delete the file from disc once the object has been destroyed. For that to happen callbacks need to be run, so you must use object.destroy and not object.delete. There's an open patch #362  to customise this behaviour, but it has not been merged yet.

I wanted to delete only the file, not the model containing it. But your link helped me find the solution, I user user.picture.delete, where user has an attachment picutre_id, I also had to set the user.picture_id to nil.

I think this would be a great option for those of us doing backups so we can just store file_id and backup images in s3.


Why is not there a SelectFilter method: what is the equivalent ?

Filtering relative entities with InfuldeFilter is very useful, but I cannot achieve it in my simple case.
My database model is a panel:

linked with many many states,
linked with devices that are linked to many many status

I need to query for a panel with last state, and all devices with their last status.
I can filter panels with IncludeFilter, but I don't see how can I filter device's status.  How can I do it without a SelectFilter method ?
var panelQuery = actiContext.Panels.Where(conditionExpression)
    .OrderByDescending(p => p.AliveTimeStamp).Take(1)
    .IncludeFilter(
        p => p.Devices
            .SelectFilter(d => d.DeviceStatus // I just need the last status, there are too many status
                .OrderByDescending(s => s.TimeStamp).Take(1)))
    .IncludeFilter(p => p.PanelStates.OrderByDescending(ps => ps.TimeStamp).Take(1));

.. but SelectFilter does not exist.

Hello @AnthonyBr ,
What's SelectFilter? You could simply use a normal Select like this:
var panelQuery = actiContext.Panels.Where(conditionExpression)
    .OrderByDescending(p => p.AliveTimeStamp).Take(1)
    .IncludeFilter(p => p.Devices)
    .IncludeFilter(p => p.Devices.Select(d => d.DeviceStatus.OrderByDescending(s => s.TimeStamp).Take(1)))
    .IncludeFilter(p => p.PanelStates.OrderByDescending(ps => ps.TimeStamp).Take(1));

Be careful, you must include all paths. By example, you include Device than in another IncludeFilter, you include the DeviceStatus.
Let me know if that's working.
Best Regards,
Jonathan

It works perfectly !

Be careful, you must include all paths. By example, you include Device than in another IncludeFilter, you include the DeviceStatus.

Yes otherwise there is no device at all.
It is not obvious because with the basic "Include" method, there is no need to add devices in another Include method.
Thank you very much for help.

Yup,
This summer, we will probably review all our features and try to improve them. We currently have all the code needed to make it work without people having to include child entities. We already support it in IncludeOptimized when an option is enabled.
Best Regards,
Jonathan

Closing Comment: Help has been provided & confirmed


Porcupine Issue:

Make sure you have read the documentation, and have put forth a reasonable effort to find an existing answer.
Expected behaviour
Have the initialization work as documented.
I think React example differs from Github and Official docs.
https://github.com/Picovoice/porcupine#react
https://picovoice.ai/docs/api/porcupine-react/#start
Actual behaviour
     const initEngine = async () => {
        await init(
          "*****ACCESSKEY*****",
          {
            "base64": HeyMyModel,
            "label": "Hey My Wake"
          },
          {base64: modelParams}
        );
        console.log(error);
        start();
      }

But yields

Porcupine has not been initialized or has been released
at _callee2$ (index.js:5076:1)
at tryCatch (index.js:202:1)
at Generator. (index.js:290:1)
at Generator.next (index.js:231:1)
at asyncGeneratorStep$2 (index.js:47:1)
at _next (index.js:66:1)

Is the access key really being passed correctly. Other code example suggest not.
Steps to reproduce the behaviour
(Include enough details so that the issue can be reproduced independently.)

Creating my model:

npx pvbase64 \
	-i ./porcupine_params.pv \
	-o ../src/lib/porcupine_params.js

npx pvbase64 \
	-i ./Hey-My_en_wasm_v3_0_0.ppn \
	-o ../src/lib/hey_my.js \
	-n HeyMyModel

Hi @frippe75, you've mentioned a few things in this issue. What is the exact nature of the issue you are facing?

Cannot get the exemple to work. But I got an email my account was marked as fishy so I have been blockad from further testing.
But mic permissions are never requested from the lib. The term model and parameters are somewhat confusing.

Does it work if you use the official provided demo: https://github.com/Picovoice/porcupine/tree/master/demo/react

Cant test it since my account got canned somehow... AI anomaly detection....

Guess I'm moving on to other solutions...
An account registered with 'frippe75' has been removed by the Picovoice Audit System. Accounts can be removed in cases of Picovoice Terms of Use violations, such as suspicious activities, creating multiple accounts, or providing false information. If you believe this is a mistake, please send an email to<EMAIL_ADDRESS>with your name, surname, country, city, and project details, and we will investigate further.


Device does not have Google Pay but initGooglePay success

Describe the bug
Device does not have Google Pay but initGooglePay success, and when i continue to call presentGooglePay function, it return presentForSetupIntent() may only be called when Google Pay is available on this device. error
Smartphone (please complete the following information):

Device: [OnePlus 5]
OS: [Android 10]

@preflower thanks for flagging, there was a bug in initGooglePay method, now it's gonna be resolved with an error if google pay is not available on the device. https://github.com/stripe/stripe-react-native/pull/546/files


Asset Pipeline

I noticed on #7 that you mention being able to dynamically load templates and assets, and that got me wondering about how you imagine cargonauts users will handle assets.
I recently released a crate for embedding entire directory trees in your binary, so kinda like include_str, but on steroids. Would something like that be useful for when people want to deploy their apps to production?
On the dynamic reloading side of things, it sounds like you want something which can watch a directory, caching resources which you've served in the past, and reloading them when they are changed (presumably with notify). Have you started work on any of the asset pipeline stuff yet? I'd be keen to help out.

cargonauts currently has only one mode regarding this: it builds all assets and templates into the compiled binary, so you just have to ship that file to the server and turn it on (modulo env vars).
There's a library in this repo called asset_pipeline which enables users to hook in any precompiler for their assets (such as if they're in a language that compiles to JS, or they want to minify them, so on).
However I want to also have a feature which will read the files off disk when requested, instead of pre-building them. The goal here is to let users avoid recompiling their projects every time they change an asset.
How to make this compatible with the user defined asset pipeline step is unclear. I wasn't even thinking about automatically reloading them when they change; that seems like overshooting the goal right now.


Mocha OPTS

How can I include the module on Mocha config file (mocha.opts)?
-r, --require <name>                    require the given module

This will not work
--require('app-module-path').addPath('../');

This will work, but how to define the root?
--require app-module-path

I'm not sure if this is the right thing, but take a look at what I did:
app/test/mocha.opts
--require test/bootstrap.js
--recursive

app/test/bootstrap.js
var path = require('path');
require('app-module-path').addPath(path.resolve());

app/test/my-module
require('my-module/my-file.js');

Where my folders are:
- app
  - my-module
    - js files...
- test
  - my-module
    - js files...

Hi @rochapablo, I think what you did looks great. I'll have to use that trick in my projects. I'm closing the issue because I like your solution, but let me know if you still think we should make changes to app-module-path. Thanks for sharing your solution.

Thank you @patrick-steele-idem.

Nice solution @rochapablo, it worked like a charm!

What if I want to require modules from the app folder into my test folder. it didn't work for me :/


Is it possible to run a screensaver via the override option even when a game registered with Playnite is running?

If you have a game that requires this option and you can get information about the game you are playing on Playnite
If you don't increase the _activeGameCount value, it seems like the screensaver will run.
In general, mmorpg games should always be on
Some games have a tray mode, so the screen stays down even when it's running. So I need this option.

The 'Disable ScreenSaver While Playing' toggle in the addon settings, if disabled, should allow the plugin to display when a game is running. If it's not, then that's a bug.

If you're curious where that count comes into play: https://github.com/cnapolit/ScreenSaver/blob/main/Services/State/ScreenSaver/ScreenSaverManager.cs#L167

Thanks for your reply.
I thought that the screen saver execution prevention would be unlocked if I didn't increase the activeCount value.
The condition to disable the screensaver when playing the game is checked.
Even if checked, the game I am playing is running in tray mode.
So, in my opinion, _activeCount is set to 1 or more, so I inquired whether the screen saver could not be executed.
I checked the code you linked to earlier. So I inquired about _activeCount.
Anyway, thanks for the nice answer to my question.


Move the block reward from the header to the block itself

The tests passed, so assuming that we had enough coverage before, all important invariants aren't broken. I don't mind adding more tests if you point out to me what exactly should be tested, though.

I see some relatively major issues with this as it stands.
First, we might want to impose some limit on the rewards output size. It is still subject to the total block size limit as far as I can tell. However previously, it was subject to block header size limit which is much tighter. This should be enforced by consensus (and maybe some limit should be in p2p as well to avoid sending a ton of data just to be rejected).
Second, and more importantly, I don't see the block rewards vector being committed to in the header. It includes a merkle root of transactions but not rewards. Do we want a separate merkle tree for rewards or do we want to include them somehow in existing ones (would require a new abstraction). Maybe just a plain hash of the rewards vector would be good enough? That would be the simplest way to start with. Either way, the rewards vector has to be committed to somehow and included in the header and the integrity has to be checked.
Also, it would be nice to test the issues mentioned above first. For example, you can generate a block, check it verifies, modify the rewards vector somehow (decrease the amount for example) and check it no longer verifies. In general, I'd say the scenarios where a block is supposed to be rejected are somewhat undertested but no less important than processing a well-formed block.

Merkle roots in the header should not be optional anymore, and in the absence of transactions, the hash of the reward should go in them.
There's no need to imposed a specific size for the reward because that's already done in the total block size.

Merkle roots in the header should not be optional anymore, and in the absence of transactions, the hash of the reward should go in them.

I think this requires a bit more thought. do we treat rewards + transactions as one vector the merkle tree is superimposed upon? If so, an abstraction that captures the either reward or transaction concept has to be introduced, even if it's as simple as just hashing the two with the same hash function.

There's no need to imposed a specific size for the reward because that's already done in the total block size.

Ok, just pointing out that the limit has been implicitly relaxed by making this change. If block rewards taking up the whole block is fine, we can keep it like that.

Merkle roots in the header should not be optional anymore, and in the absence of transactions, the hash of the reward should go in them.

Does that mean that we shouldn't allow blocks without the reward?

Does that mean that we shouldn't allow blocks without the reward?

Nope. Just hash the serialized block reward.


feat: Cleanup old browser test matchers

Cleanup old browser test matchers in our testing code. This helps with having less outdated matchers to worry about when writing tests.

Overview
Cleanup old browser test matchers in our testing code. This helps with having less outdated matchers to worry about when writing tests.
Notable changes to the browser matchers (which take into account our current and future supported browsers) include:

All supported browsers support the fetch API, both basic and extended
All supported browsers support ES2022 (used in testing NPM agent)
All supported browsers support back/forward cache. Edge browser has it enabled for the latest 10 browser versions.
All supported browsers support First Contentful Paint timing
A couple of unused browser matchers were removed (supportsMultipleTabs, notFirefox, notMobile)

All of the browsers in the matchers are reorganized in alphabetical order.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-283061
Testing
Make sure tests pass, especially LambdaTest and integration tests. The agent code itself isn't changed at all.

This looks good, but can you change the feat: to a chore:.  I dont think this one needs to end up in the changelog since it only affects test runners (imo)


This module breaks type checking and crashes studio

Recently iv been getting reports that type checking no longer works for my module when it did in the past
full module can be found here: https://create.roblox.com/marketplace/asset/11671168253
So I went into my module and started deleting every line that was not the culprit for breaking type checking and I was left with this module
local CloseTask, DestroyTask, Unlock, Save

export type Constructor = {
	new: (name: string, scope: string, key: string?) -> DataStore,
	hidden: (name: string, scope: string, key: string?) -> DataStore,
	find: (name: string, scope: string, key: string?) -> DataStore?,
	Response: {Success: string, Saved: string, Locked: string, State: string, Error: string},
}

LockTask = function(runningTask, proxy)
	local dataStore = getmetatable(proxy)
	if dataStore.TaskManager:FindLast(CloseTask) == nil and dataStore.TaskManager:FindLast(DestroyTask) == nil then StartLockTimer(proxy) end
	if dataStore.__public.SaveOnClose == true then Save(proxy, 3) end
	dataStore.__public.StateChanged:Fire(false, proxy)
end

CloseTask = function(runningTask, proxy)
	local dataStore = getmetatable(proxy)
	if dataStore.__public.SaveOnClose == true then response, responseData = Save(proxy, 3) end
	Unlock(dataStore, 3)
end

DestroyTask = function(runningTask, proxy)
	local dataStore = getmetatable(proxy)
	if dataStore.__public.State == false then
		if dataStore.__public.SaveOnClose == true then response, responseData = Save(proxy, 3) end
		Unlock(dataStore, 3)
	end
	dataStore.__public.StateChanged:Fire(nil, proxy)
end

return Constructor :: Constructor

Now the strange thing is removing any line from the above module fixes type checking
not only that I also notices that changing the 3 in the function DestroyTask would crash studio and this is reproducible
Steps to reproduce

open studio
start new baseplate project
copy above code into a modulescript in serverstorage
wait a few seconds
try to delete the 3 in DestroyTask
studio crashes

Issues with Roblox Studio should be reported on Roblox developer forum: https://devforum.roblox.com/c/bug-reports/10
For example, this crash happens inside a Roblox Studio component.

I want to note that this issue will be fixed, but we are not going to track its state in this repository.


Mailing list not open to the public?

When attempting to follow the link to the mailing list that is provided in the README, I get the following error message in my browser:
You do not have permission to access this content. (#418)

Sorry - I tried to lock down the list access control but obviously took it too far. Should be visible again!
Please reopen if it isn't fixed.

Thanks! I can get in now.


update: readme index

PR for issue no: #166

If we can add the extra place holder in the pull request, and add:
"Collaborating with Live Share "
as per the #166 then this can be merged.

Sure

If we can add the extra place holder in the pull request #165, and add: "Collaborating with Live Share " as per the #166 then this can be merged.

Done :+1:


Adds operator disconnected overlay

Final bit for #1527 and #1513.

        1 Error

  </th>
 </tr>

:no_entry_sign:
There were snapshot errors

        2 Warnings

  </th>
 </tr>

:warning:
Needs testing on a Phone if change is non-trivial

:warning:
Detected some Swift building time outliers

Time | Class | Function |
| --- | ----- | ----- |242.4ms | AuctionViewController.swift | @objc dynamic func showRefineTappedAnimated(animated: Bool)
185.5ms | SwiftyJSON.swift | get {}
163.6ms | WebSocket.swift | private func processRawMessage(buffer: UnsafePointer, bufferLen: Int)
71.5ms | Observable.swift | private final func nextTokenHash() -> Int
68.7ms | LiveAuctionsAdminViewController.swift | @objc override func viewDidLoad()
66.2ms | AuctionLotMetadataStackScrollView.swift | required init(viewModel: LiveAuctionLotViewModelType, sideMargin: String)
65.4ms | RefinementOptionsViewController+Private.swift | func stackView() -> ORStackView
63.8ms | UIViewController+BlurredStatusView.swift | func ar_presentBlurredOverlayWithTitle(title: String, subtitle: String, buttonState: BlurredStatusOverlayViewCloseButtonState = default)
61.8ms | UIViewController+BlurredStatusView.swift | (closure)

  Generated by :no_entry_sign: danger

Hmm! Legit failure.

Okay, so instead of having two subscriptions (one for operator connected state, another for socket connected state), I've merged them into one and mapped it so: we hide the overlay if and only if both the socket is connected and the operator is connected. This should be ready for review.

🍏

Good to merge post-typos


How to add standard container like bootstrap?

Appreciated if yoy can guide me to add container-like bootstrap for this MDL. I'd tried to add css container but the nav drawer didn't display correctly.

Support questions should be asked on StackOverflow and use the material-design-lite tag along with any other appropriate tags.


Replace alerts with Tip Callout Component

Problem statement
A new Tip Callout component was created and needs to be added into the existing pages that use it.
This ticket is to standardize that component and add it to the API Documentation Pages, File Validator, and Public Key tool.
What you need to know
Tip callout components to update to the new standard component (alert-tip):

API Documentation Pages
File Validator
Public Key Tool

Acceptance criteria

[ ] Create a Tip Callout component that can be re-used around the site
[ ] API Page: Replace alerts with Tip Callout component
[ ] File Validator Tool: Replace alerts with Tip Callout component
[ ] Public Key Tool: Replace alerts with Tip Callout component

To do

[ ] ...

Needs to determine with Etan if a completely new component was created for his version, or if he dressed up an existing USWDS component. Will add as an agenda item to upcoming WebX engr sync.

Need to bring it up in Eng sync 06/13 to discuss it with the team

Carry over to next sprint. Will not finish this sprint.

Consensus was reached around how to solve/approach this solution from an engineering perspective.
Will be wrapping around an existing Trussworks component.

@jpandersen87 After creating this Tip Callout Component, we will need to go back in and replace the other areas it is used (File Validator Tool and Public Key Tool) on the site, correct? Meaning, create a separate ticket for that work in the future?

From @jpandersen87 :

PR under review also covers updating the two pages to use the new alert

I have updated the AC's accordingly to reflect that.


new(event_table): add a new plugin category

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR adds a new event category called EC_PLUGIN
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
new(event_table): add a new plugin category

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 4f9c9d1e035890e055db2dcfde75d2d416065ddf

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

just amended the last commit to refresh the CI

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Missing RPC methods

Implement missing RPC methods:

[x] Genesis
[ ] BlockchainInfo
[x] NetInfo
[ ] DumpConsensus
[ ] State
[ ] ConsensusState
[ ] ConsensusParams
[x] Health
[ ] Block
[ ] BlockByHash
[ ] BlockResults
[ ] Commit
[ ] Validators
[ ] Tx
[ ] TxSearch
[ ] BroadcastEvidence
[x] UnconfirmedTxs
[x] NumUnconfirmedTxs

Resolves #49

Replaced by #85.


feat(protocol-designer): update StepSummary render logic and copy

Overview
This PR updates when StepSummaries show and updates copy to reflect final decisions. The intended behavior is to only show StepSummary when a step is hovered or selected, but not when the step form is open. Hovered StepSummaries take precedence over those of selected steps. I also add an optional second element to StepSummary that will display the step's notes if they exists.
Test Plan and Hands on Testing

Select a step without opening step form edit toolbox and move cursor off the timeline toolbox. Verify that the step summary under the deck map describes the selected step
With step still selected, hover over a different step in the timeline and verify that the step summary describes the hovered step
Add a description to a step by opening step form edit toolbox and clicking rename to open rename modal
Save the step form, produce the step's summary by hovering the step, and verify that the step description shows

https://github.com/user-attachments/assets/1cb8a0c2-3f36-4a7b-9973-3ac13d9036c5
Changelog

fix logic for which step summary if any shows
add step description to step summary

Review requests
see test plan
Risk assessment
low

ooh @ncdiehl11, i think you also addressed this ticket! https://opentrons.atlassian.net/browse/AUTH-886 (fyi @syao1226)


Is it possible to use autolayout for buttonBarItem width?

Hi!
I'm trying out your lib, and I was wondering if it is possible to use auto layout to calculate the width of the current buttonBarItem. Currently I am using BaseButtonBarPagerTabStripViewController and specify buttonBarItemSpec with my custom nib file like following example:
buttonBarItemSpec = .nibFile(nibName: MyTabCell.reuseIdentifier, bundle: Bundle(for: MyTabCell.self)) { itemInfo in
            return 120
}

Unfortunately the width of my bar items will change while using the app, because I want provide some dynamic data to these items. Is there a way, to auto calculate and update the width using autolayout in the nib file?
Thanks in advance,
phillipp

HI phillipp, did you manage to solve the issue?

Hi @ahsanaasim!

I changed the visibility of cachedCellWidths and calculateWidths() in BaseButtonBarPagerTabStripViewController and write a layoutTabItems() method, that I have to call every time, any of these cells content is updated:
    /// Workaround for dynamic tab item width
    ///
    /// BaseButtonBarPagerTabStripViewController was modified to make
    /// `cachedCellWidths` and `calculateWidths` accessible
    /// This modification has to be made again after pod updates.
    fileprivate func layoutTabItems() {
        cachedCellWidths = calculateWidths()
        buttonBarView.reloadData()
    }

I have used this extension to easily get the estimated width of a given string depending on the font :
extension UIFont {
    func sizeOfString(string: String, constrainedToHeight height: Double) -> CGSize {
        return NSString(string: string).boundingRect(
            with: CGSize(width: .greatestFiniteMagnitude, height: height),
            options: .usesLineFragmentOrigin,
            attributes: [.font: self],
            context: nil).size
    }
}

Then, in my BaseButtonBarPagerTabStripViewController subclass :
    init() {
        super.init(nibName: nil, bundle: nil)
        buttonBarItemSpec = ButtonBarItemSpec.cellClass(width: { info in
            let title: String = info.title ?? ""
            let maxHeight: CGFloat = 60.0
            let font: UIFont = UIFont.customFont(forTextStyle: .body)
            let size: CGSize = font.sizeOfString(string: title, constrainedToHeight: maxHeight)
            return size.width + (12 * 2)
        })
    }

I made my workaround  to calculate width for button bar items based on title content
// Calcualtion dynamic width through title
extension string {
func width(usingFont font: UIFont) -> CGFloat {
let fontAttributes = [NSAttributedString.Key.font: font]
let size = self.size(withAttributes: fontAttributes)
return size.width
}
}
// usage
buttonBarItemSpec = ButtonBarItemSpec.nibFile(nibName: Cell_identifier, bundle: Bundle(for: Cell.self), width: { info in
guard let title = info.title else { return 0 } // Handle nil title if necessary
// dynamic width here and also your padding if you want
let dynamicWidth: CGFloat = title.width(usingFont: // your font) + // padding here
return dynamicWidth

I made my workaround to calculate width for button bar items based on title content
// Calcualtion dynamic width through title
extension string {

  func width(usingFont font: UIFont) -> CGFloat {
let fontAttributes = [NSAttributedString.Key.font: font]
let size = self.size(withAttributes: fontAttributes)
return size.width
}

}

// usage
buttonBarItemSpec = ButtonBarItemSpec.nibFile(nibName: Cell.identifier, bundle: Bundle(for: Cell.self), width: { info in
guard let title = info.title else { return 0 } // Handle nil title if necessary
// get width and add your padding if you want
let dynamicWidth: CGFloat = title.width(usingFont: UIFont.bodySMedium()) + 50
return dynamicWidth
    })


Use time.Since rather than time.Now().Sub

Use time.Since rather than time.Now().Sub.

Thanks @rghetia for the super fast merge!


Can't quantize to int4 and can't compile on RTX2080Ti

I have tried gpt-fast on RTX2080Ti.
I could run using int8 quant and without compilation.
However, it seems can't do the int4 quant and compile on RTX2080Ti.
For int4 quant
It shows:
RuntimeError: CUDA error: named symbol not found
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
For compile, it seems the kernel is compiled to use the bf16 calculation, and RTX2080 can't support bf16 calculation, so it may be the case.
But is it possible to solve the int4 quantization on RXT2080Ti?

2080 is Turing and that unfortunately does not have int4 support https://en.wikipedia.org/wiki/Turing_(microarchitecture)
I come to this Wikipedia page often to see what's supported where

Thx!

Hi @kaizizzzzzz, @msaroufim
I’m encountering the same issue when using the following function:
c = torch.ops.aten._weight_int4pack_mm(x, weight_int4pack, groupsize, scales_and_zeros)
The error message I receive is:
Expected A.dtype() == at::kBFloat16 to be true, but got false. (Could this error message be improved? If so, please report an enhancement request to PyTorch.)
I’ve made sure that everything is set to fp16, but the issue persists. I'm running on a V100 GPU and using PyTorch version 2.4.1+cu121.
Any suggestions or advice on how to resolve this would be greatly appreciated.
Thank you!


add collections handson

Added generic class handson
Added data structures handson
Added recursion handson

@hdyhlm it seems the code in both solution and training folder are the same. Is this intended?

@yh-sm made some changes, requesting for review.

Approved for merge.
Chosen merge operation: Rebase and merge.

@hdyhlm you may delete this branch.


Typing Of Monaco On Version 12

Hi,
I work with ngx-monaco-editor version 12 and with angular 12.
I am trying to implement my one language with this component, after I finish the flow for connect the component to my project as was explain on https://www.npmjs.com/package/ngx-monaco-editor.
First when I tried to influence on the monaco by:
 monaco.languages.register({         id: 'test',     });
I got error that says "Cannot find name 'monaco'", for solve this I added
declare let monaco: any;
And it start to work, but I saw on some example that works on 9 version that not need to do this declare.
So I walked to the project's node modules and found there a monaco.d.ts folder with monaco name space with all the needed classes and interfaces, and on version 12 this folder not exists.
This typing is very helpful for understand the component.
What wrong did I do?

Having the same issue as well.

Yah, there was monaco.d.ts before. Where did you lose it?

It's located inside monaco-editor
But how to import it from there?

As workaround I installed latest version of ngx-monaco-editor, which had monaco.d.ts: 9.0.0
But don't import monaco build from there, it's outdated. Import it directly from monaco-editor:
{
  "glob": "**/*",
  "input": "node_modules/monaco-editor/min",
  "output": "./assets/monaco/"
}

Alternative way is to just add import to every file:
import * as monaco from 'monaco-editor'


Implement remote distribute configuration push in case of token session.

the title explain

the current implemetation push the configuration update to any client, so this allow also client that use the tocken to get the configuration update.
no need to implemet it closing


Let user override locale

So they'll have things in another language e.g. on the web, it now automatically detects the language

You can now use locale="YOUR_TWO_LETTER_LOCALE" as prop to override default detection


Add parallel topology tests and pin unittest-xml-reporting version

Addresses #52
Addresses #156
Supersedes #157
It seems to work, although topology tests fail pretty frequently when running with --concurrent-test-executor-count 4 (I'm guessing because this spawns 20 containers). On the plus side, might be a good way to more reliably reproduce errors seen with sporadic test failures recently.
Still need to test with a plugin to make sure that hasn't gone sideways. Core tests, unit tests, and federation tests are working.

I tried running with --concurrent-test-executor-count 4 with a commit based on 4-2-stable and only 2 tests failed, which appear to be real. The test run completed in 2 hours and 42 minutes!

Very nice. Is this ready for review?

Yes, ready for review.

Other than the review comments I just resolved, I don't think so. One of the things holding up #157 was that we wanted to test with MySQL, which I haven't done. Maybe I can give that a try.

Unit tests passed for main against ubuntu-2004-mysql-80, so I'll call that a success

awesome


refactor: refactor implementation of supervisor strategy

BREAKING CHANGE:

WithSupervisorDirective: removed from the actor system option
WithSupervisor: removed from the SpawnOption

closes #552

The last work item is the Escalate directive and clean up the documentation regarding Supervisor Strategy