fix: Pass file_format values as-is in external table configuration

Common use of FILE_FORMAT within CREATE EXTERNAL TABLE includes specifying
a previously created format name (FORMAT_NAME = 'NAME') or the various
type options (TYPE=CSV FIELD_DELIMITER='|').
Both of these require defining string literals with the single quote
character (') that should not be escaped (\').
This change removes the escaping of single quotes performed for the
file_format values to allow them to be specified without failing
the query compilation.
Some examples have also been added to the documentation
to make it easier to understand how values for file_format
need to be passed for external tables.
Test Plan

[x] acceptance tests (make test-acceptance with env-vars set to a trial account)
[x] unit tests (make test)
[x] manual test with FORMAT_NAME = 'NAME'
[x] manual test with TYPE = CSV FIELD_DELIMITER = '|' NULL_IF = ('0', '')
[x] executed modified example

References

Fixes #1046
Snowflake Docs: CREATE EXTERNAL TABLE

will this break existing use cases that utilize the string escape currently? if so, may need to add backward compatability for that.

Thank you for taking a look @sfc-gh-swinkler!
I checked all of the format options displayed in the following documents:

https://docs.snowflake.com/en/sql-reference/sql/create-external-table.html#required-parameters
https://docs.snowflake.com/en/sql-reference/sql/create-file-format.html#syntax

For existing file format names that may have included a ' character in them, the escapes would have prevented it from working unless one was oddly relying on the backslash injection:
  file_format  = "FORMAT_NAME=$$FOO'BAR$$"
  # Desired: FOO'BAR
  # Would look instead for FOO\'BAR (different identifier with 8 characters instead of 7)

For file format names that may include a \ character the .tf file will require an escape during definition so the second escape would break the name. There's a chance one could be relying on this doubling effect but then it'd be a user-error because a \\ in the .tf files is an escaped single \.
  file_format = "FORMAT_NAME=$$identifier\\with\\slashes$$"
  # Desired: IDENTIFIER\WITH\SLASHES, with \\ required to write \ in .tf files
  # Would look instead for IDENTIFIER\\WITH\\SLASHES (different identifier with 25 instead of 23 characters)

For other values that accept string/character literals through the use of ', it would simply never have worked due to the unnecessary escaping leading to \' (2 characters instead of 1) appearing in the generated SQL.
Please let me know if I've missed something.

Okay so that makes sense. Two things:

need to run make docs to rebuild docs
I am wondering if we should make this a more complex object like:
file_format = {
name =
type  =
options =
}

I've added the missing doc changes.
The complex object would certainly be nicer to define, perhaps something equivalent to the file_format resource which has an exhaustive-looking options list: https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/file_format

would it make sense to deprecate file_format for extenral table and then add support for external table to the file format resource? for example we could refactor the file_format resource to accept an external table id:
resource "snowflake_file_format" "example_file_format" {
  object_name = snowflake_external_table.external_table.name
  object_type = "EXTERNAL_TABLE"
  format_type = "CSV"
}

we do something similiar for the tag_association resource https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/tag_association

It does make sense to do it that way since external tables do always need a format specified. However, not all of the file format options available to SELECT FROM @STAGE or COPY INTO TABLE are supported in CREATE EXTERNAL TABLE according to https://docs.snowflake.com/en/sql-reference/sql/create-external-table.html (for example, NULL_IF = (…) support appears absent for TYPE=CSV) so it could cause some user confusion?

what i will do is merge this for now and then make a note to revisit this later. I don't know that users would be too confused as long as it is well documented. however i could also see creating a resource such as "snowflake_external_table_file_format" if the file format features supported are sufficiently different than "snowflake_file_format".

/ok-to-test sha=4b82042


Problems with "constraints" using flex - RN 0.40

Description:
I want to design a screen that have two parts:
1-  a button at the right end of the screen.
2-  Logo, then text and then another image icon.
The text suppose to grow until it reaches the right screen icon and then stop and replace the end of the text with "...".
I tried it using the online editor in this site:
https://facebook.github.io/react-native/docs/flexbox.html
Reproduction:
This is the code:
return (
    <View style={{flexDirection: 'column', height:120}}>
  <View style={{flex: 1,alignItems:'center', flexDirection: 'row'}}>
    <View style={{flex:1,alignItems:'center', flexDirection:'row', backgroundColor: 'powderblue'}}>
      <View style={{backgroundColor:'red', width:60, height:40}}></View> //Logo
      <Text style={{fontSize:24}} numberOfLines={1}>very long text</Text> //Long text
      <View style={{marginLeft:8,backgroundColor:'red', width:60, height:40}}></View> //Icon
    </View>
    <Text>Here goes my right icon</Text> //Right icon
          </View>
    <View style={{width: 50, height: 50, backgroundColor: 'steelblue'}} />
    </View>
);

There  it works excellent.
The problem is that when i copy/paste that code into my project, it doesn't works.

React Native version: 0.40
Platform: Android
Operating System: MacOS

We're cutting down on the number of outstanding issues, in order to allow us to focus. I'm closing this issue because it has been open for over 60 days with no activity. If you think it should still be opened let us know why. PRs are always welcome.


Mexc - Unable to use any market pair

Describe the bug
When checking mexc, we are able to add the connector API successfully and fetch balance ok however when selecting market pair on strategy (v1) it does not seem to be displaying the list fetch from exchange

Already added the API keys so it should return or display market pairs on autocomplete
Not display anything related to USDT nor USDC

The balance command seems to be working ok

Start strategy on v2 using pmm_simple controller and getting the following errors:

Unhandled error in background task..KeyError:...2024-08-16 18:46:53,419 - 19789 - hummingbot.client.hummingbot_application - INFO - Creating the clock with tick size: 1.0
2024-08-16 18:46:53,421 - 19789 - hummingbot.client.hummingbot_application - INFO - start command initiated.
2024-08-16 18:46:54,028 - 19789 - hummingbot.strategy.script_strategy_base - WARNING - mexc is not ready. Please wait...
2024-08-16 18:46:54,271 - 19789 - hummingbot.connector.exchange.mexc.mexc_exchange.MexcExchange - INFO - Network status has changed to NetworkStatus.CONNECTED. Starting networking...
2024-08-16 18:46:54,363 - 19789 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: 'TORN-USDT'
Traceback (most recent call last):
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/core/data_type/order_book_tracker.py", line 180, in _init_order_books
    self._order_books[trading_pair] = await self._initial_order_book_for_trading_pair(trading_pair)
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/core/data_type/order_book_tracker.py", line 173, in _initial_order_book_for_trading_pair
    return await self._data_source.get_new_order_book(trading_pair)
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/core/data_type/order_book_tracker_data_source.py", line 65, in get_new_order_book
    snapshot_msg: OrderBookMessage = await self._order_book_snapshot(trading_pair=trading_pair)
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/connector/exchange/mexc/mexc_api_order_book_data_source.py", line 113, in _order_book_snapshot
    snapshot: Dict[str, Any] = await self._request_order_book_snapshot(trading_pair)
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/connector/exchange/mexc/mexc_api_order_book_data_source.py", line 52, in _request_order_book_snapshot
    "symbol": await self._connector.exchange_symbol_associated_to_pair(trading_pair=trading_pair),
  File "hummingbot/connector/exchange_base.pyx", line 97, in exchange_symbol_associated_to_pair
    return symbol_map.inverse[trading_pair]
  File "/Users/rapcomia/miniconda3/envs/hummingbot/lib/python3.10/site-packages/bidict/_base.py", line 524, in __getitem__
    return self._fwdm[key]
KeyError: 'TORN-USDT'

Unexpected error occurred subscribing to order book trading and delta streams...2024-08-16 18:46:54,458 - 19789 - hummingbot.connector.exchange.mexc.mexc_api_user_stream_data_source.MexcAPIUserStreamDataSource - INFO - Successfully obtained listen key 2b3cce36d57af7d262e816190e1b9ae248df3b8f6e9660c0749b551dcbeb365c
2024-08-16 18:46:54,712 - 19789 - hummingbot.connector.exchange.mexc.mexc_api_user_stream_data_source.MexcAPIUserStreamDataSource - INFO - Subscribed to private order changes and balance updates channels...
2024-08-16 18:46:54,774 - 19789 - hummingbot.connector.exchange.mexc.mexc_api_order_book_data_source.MexcAPIOrderBookDataSource - ERROR - Unexpected error occurred subscribing to order book trading and delta streams...
Traceback (most recent call last):
  File "/Users/rapcomia/github/hummingbot/hummingbot/staging/hummingbot/connector/exchange/mexc/mexc_api_order_book_data_source.py", line 76, in _subscribe_channels
    symbol = await self._connector.exchange_symbol_associated_to_pair(trading_pair=trading_pair)
  File "hummingbot/connector/exchange_base.pyx", line 97, in exchange_symbol_associated_to_pair
    return symbol_map.inverse[trading_pair]
  File "/Users/rapcomia/miniconda3/envs/hummingbot/lib/python3.10/site-packages/bidict/_base.py", line 524, in __getitem__
    return self._fwdm[key]
KeyError: 'TORN-USDT'

This also return the same traceback on the following errors found on the attach log file:

Unexpected error occurred when listening to order book streams. Retrying in 5 seconds...
Unexpected error while fetching account updates.

Steps to reproduce

Add mexc connector, runing balance command should display the assets on account if successfully added
Setup v1 pure market making, select mexc as spot connector and check autocomplete list or add any tokens to use
Setup v2 pmm_simple then start, observe the errors mentioned above

Release version
development 2.0.1
Type of installation
Source
Attach required files
logs_conf_pmm_mexc1.log

Got the same bug, tried to remove filtering of valid trading pair and solved. However v1 strategy then froze without even error log

Got the same bug, tried to remove filtering of valid trading pair and solved.
def  _initialize_trading_pair_symbols_from_exchange_info(self, exchange_info: Dict[str, Any]):

        mapping = bidict()

        # for symbol_data in filter(mexc_utils.is_exchange_information_valid, exchange_info["symbols"]):

        # this filter failded some how

        for symbol_data in exchange_info["symbols"]:

However v1 strategy then froze without even error log

Solved, MEXC changed their exchange info API, the status attribute now return 1 instead of ENABLED
def is_exchange_information_valid(exchange_info: Dict[str, Any]) -> bool:
    """
    Verifies if a trading pair is enabled to operate with based on its exchange information
    :param exchange_info: the exchange information for a trading pair
    :return: True if the trading pair is enabled, False otherwise
    """
    return exchange_info.get("status", None) == "1" and "SPOT" in exchange_info.get("permissions", list()) \
        and exchange_info.get("isSpotTradingAllowed", True) is True

Thanks for your participation, @Kaiwen0418. The fix has been merged to latest development branch and will be available in hummingbot version 2.0.1.


Rewrite the ZeroMQ tests to speed them up

The ZeroMQ tests are long-running system tests that slow down CI and local testing. They should be rewritten.
The current tests throw up and connect a ZeroMQ socket in a subprocess and then sleep for several seconds, waiting for it to start. This is very slow and potentially unreliable.
Possible Solution
Some ideas:

More functionality could be tested with mocking and unit-style tests, which are much faster
There could be a single system test alonside the unit tests, to test against a real socket while minimizing the long-running tests
Rather than kickoff in a subprocess and wait 5 seconds, could make use of a multiprocessing Event to synchronise on

In terms of acceptance criteria, I have run the ZMQ tests locally a few times (tox -e tests -- src/bluesky/tests/test_zmq.py) and they seem to take about 1:40 seconds to run on average, which is a long time! Ideally we want a few seconds but maybe 30s as a maximum.

One of the tests is also not doing cleanup properly, resulting in this rather unsightly message being printed in the middle of pytest's results:
src/bluesky/tests/test_zmq.py::test_zmq_components Exception ignored in: <function Context.__del__ at 0x7fd10671fb50>
Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/zmq/sugar/context.py", line 136, in __del__
    warn(
ResourceWarning: Unclosed context <zmq.asyncio.Context() at 0x7fd09c200860>
Exception ignored in: <function Socket.__del__ at 0x7fd10671e5f0>
Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/zmq/sugar/socket.py", line 179, in __del__
    warn(
ResourceWarning: Unclosed socket <zmq.asyncio.Socket(zmq.SUB) at 0x7fd09c1e6ce0>
Exception ignored in: <function Context.__del__ at 0x7fd10671fb50>
Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/zmq/sugar/context.py", line 136, in __del__
    warn(
ResourceWarning: Unclosed context <zmq.asyncio.Context() at 0x7fd09c2009f0>
PASSED                                                                                [ 40%]

I wouldn't be surprised if this is actually happening in most of the tests, but we don't see it as it's happening in subprocesses.
p.s. code coverage should also be investigated here; test_zmq_components explicitly notes it exists because code coverage would miss the code in separate processes, but pytest-cov should cover this case and should already handle this for us. PErhaps see here

Reviewers: @vshekar @callumforrester

https://github.com/bluesky/bluesky/pull/1672 has a fix for not closing resources.


Add native build workflow

Mostly a copy of https://github.com/ppy/SDL2-CS/blob/master/.github/workflows/build.yml with minimal modifications such as to the versioned soname.
Example run seen here: https://github.com/smoogipoo/SDL3-CS/actions/runs/8586568747

Hold off on this one for a sec.


juno exponent bug?

This should be  100.000000 JUNO not 100,000,000.00000000 JUNO
83d489354a5f350158f8a400dec18397183b546bcd595386c0ff00919457a92f

20230502175202-juno-events.csv

I figured this one out:

We have a unique constraint on the DenomUnit model Name column - source
Osmosis has a definition for "juno" exponent 6 for their IBC - source
Juno also provides the same Name field - source
We ran Osmosis first, storing

Denom: ID: 45,Base: ibc/46B44899322F3CD854D2D46DEEF881958467CDD4B3B10086DA49296BBED94BED,Name: Juno,Symbol: JUNO
DenomUnit: ID: 89, DenomID: 45, Exponent: 6, Name: juno

We indexed Juno next, storing:

Denom: ID: 27822,Base: ujuno, Name: Juno, Symbol: JUNO
We then tried storing DenomUnit juno with exponent 6 and ran into the unique constraint, causing nothing to be inserted

Transactions with Denom ID 27822 now have no 6 exponent to calculate the symbol value on CSV export

The DenomUnit table is not terribly well thought out. I will need to rework how the table works.


should utils/densepose.py change its file name?

when I run util/densepose.py, there is a error: ModuleNotFoundError: No module named 'densepose.structures'; 'densepose' is not a package.
The file name conflicts with the package name.
After I changed the file name to densepose_utils.py, Everything goes well.

I followed you but still get the error:
ModuleNotFoundError: No module named 'densepose'.
Then I just move the file densepose_utils from utils/ to detectron2-main/projects/Densepose/, so it can see the package 'densepose', and everything goes well again   #


Error on private client subscribe

import asyncio
from kraky import KrakyApiAsyncClient, KrakyWsClient

async def get_web_sockets_token():
    kraken_api_key = ""
    kraken_secret = ""
    kraky_api_client = KrakyApiAsyncClient(
        api_key=kraken_api_key, secret=kraken_secret
    )

    ws_token = await kraky_api_client.get_web_sockets_token()
    return ws_token

async def public_handler(response):
    print(response)

async def private_handler(response):
    print(response)

async def main():

    interval = 30

    ws_pairs = ["XBT/USD", "ETH/USD"]

    ws_token = await get_web_sockets_token()

    kraky_public_ws_client = KrakyWsClient("production")
    kraky_private_ws_client = KrakyWsClient("production-auth")

    asyncio.create_task(
        kraky_public_ws_client.connect(public_handler, connection_name="public")
    )

    asyncio.create_task(
        kraky_private_ws_client.connect(private_handler, connection_name="private")
    )

    await kraky_public_ws_client.subscribe(
        {"name": "ohlc", "interval": interval},
        ws_pairs,
        connection_name="public",
    )

    await kraky_private_ws_client.subscribe(
        {
            "interval": interval,
            "token": ws_token,
            "name": "Balance",
        },
        connection_name="private",
    )

if __name__ == "__main__":
    loop = asyncio.get_event_loop()
    loop.create_task(main())
    loop.run_forever()

When I try to get my account balance, I get the following error printed twice:
2023-02-19 17:55:46,891 kraky.ws     ERROR    Public market data subscriptions are unavailable on this endpoint. Try ws.kraken.com
2023-02-19 17:55:46,891 kraky.ws     ERROR    Public market data subscriptions are unavailable on this endpoint. Try ws.kraken.com
The public stream works fine, though. I don't think it's a issue with the API key as it works normally when using krakenex.
I removed the API key & secret in the code above.
Thanks

Hi, it used to work. I am working on fixing the API/WS code.

@testingmediation You cannot check your balance with websockets: https://docs.kraken.com/websockets/#overview
If you want to check it, you can use the REST API.
Also do note that krakenex does not support Websockets while this library does.

Hello, is there also an issue when sending orders through the websocket as I get no response when using add_order:
import asyncio
from kraky import KrakyApiAsyncClient, KrakyWsClient

async def get_web_sockets_token():
    kraken_api_key = ""
    kraken_secret = ""
    kraky_api_client = KrakyApiAsyncClient(api_key=kraken_api_key, secret=kraken_secret)

    ws_token = await kraky_api_client.get_web_sockets_token()
    return ws_token

async def public_handler(response):
    print(response)

async def private_handler(response):
    print(response)

async def main():

    interval = 30

    ws_pairs = ["ETH/USD"]

    ws_token = await get_web_sockets_token()

    kraky_public_ws_client = KrakyWsClient("production")
    kraky_private_ws_client = KrakyWsClient("production-auth")

    asyncio.create_task(
        kraky_public_ws_client.connect(public_handler, connection_name="public")
    )

    asyncio.create_task(
        kraky_private_ws_client.connect(private_handler, connection_name="private")
    )

    await kraky_public_ws_client.subscribe(
        {"name": "ohlc", "interval": interval},
        ws_pairs,
        connection_name="public",
    )

    await kraky_private_ws_client.add_order(
        token=ws_token,
        pair="BAT/USD",
        type="buy",
        ordertype="market",
        volume=100.0,
        validate="True",
    )

if __name__ == "__main__":
    loop = asyncio.get_event_loop()
    loop.create_task(main())
    loop.run_forever()

@testingmediation Did you passed the argument connection_name="private" to the function add_order() ?
I will probably put a warning/error to the documentation to precise that for each WS function you call, you have to pass the connection_name to distinguish between the public and private websockets.
If you only use one connection, either the public one or private one, you can simply leave it out and it will be "main" by default.

Yeah, that was my mistake, I added the connection name and the order went through!
Thanks again!

No problem, I will close it then !


[stable/prometheus-operator] Alertmanager config not loaded / crashloopback

Kubernetes version: v1.11.8 (GKE)
Helm/Tiller version:  v2.13.1
Which chart:
stable/prometheus-operator
What happened:
Alertmanager is crashing, can't find the configurations we loaded into the values.
Configuration:
global:
      smarthost: ****
      auth_username: ****
      auth_identity: ****
      auth_password: ***
      resolve_timeout: 5m
      slack_api_url: 'https://hooks.slack.com/***'
      send_resolved: true

The alertmanager keeps crashing with the following error:
msg="Loading configuration file failed" file=/etc/alertmanager/config/alertmanager.yaml err="yaml: unmarshal errors:\n line 2: field auth_identity not found in type config.plain\n line 3: field auth_password not found in type config.plain\n line 4: field auth_username not found in type config.plain\n line 6: field send_resolved not found in type config.plain\n line 8: field smarthost not found in type config.plain"
What you expected to happen:
Alertmanager to load
How to reproduce it (as minimally and precisely as possible):
Basically did nothing but installing the helm chart, but since I couldn't find any documentation and/or other errors I guess something must have gone wrong.
Anything else we need to know:
I checked the secret - it got created successfully with the correct data as base64.
Appreciate any help on the matter.

facing same issue

Not stale 😑

Not stale... although the repo might be

Nope.
On Fri, 26 Jul 2019 at 10:41 stale[bot]<EMAIL_ADDRESS>wrote:

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Any
further update will cause the issue/pull request to no longer be considered
stale. Thank you for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/helm/charts/issues/13109?email_source=notifications&email_token=ABHPBIT2DQWR75FZJ6SCROLQBKTA3A5CNFSM4HGSW4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23YZFA#issuecomment-515345556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHPBIXMDHJTK6URV4K4TOLQBKTA3ANCNFSM4HGSW4GQ
.

Has this been resolved? I am facing the same issue.


Read registry value for downloads folder

Read the registry value for the downloads folder to address #173 if this does not address it please inform me so I can make the necessary adjustments.

hey @yaichenbaum I see you are using if-else here. I would suggest change that to switch statement because that will be quick and efficient. if-else will hit every if statement to see if the condition is met, switch directly goes to the identifier based on value passed in switch.

@avknaidu I have never done it that way before but would be happy to learn from this, @duke7553 will be finishing the work on this PR when he gets some time, so this might be something for him to do once he is in those files anyways.


Why the accuracy rate is so low from your model?

Hi guys,
I've download the evaluation_data and model you supported, and verify the test result by the command
python src/launcher.py --phase=test --visualize --data-path=evaluation_data/svt/test.txt --data-base-dir=evaluation_data/svt --log-path=log.txt --load-model --model-dir=model --output-dir=results --target-embedding-size=10
(BTW. should add --target-embedding-size=10 option or else it will fails by "Assign requires shapes of both tensors to match. lhs shape= [39,20] rhs shape= [39,10]")
But the result log.txt shows "188.780794 out of 647 correct" which means only 29% accuracy rate you get. Why is it so bad? Or Did I something wrong?

I had the same issue whith exactly 188.7
It was solved  by dow-grading keras to v1.0.1.
Maybe authors could add a note in readme, as something goes wrong in the decoder with new keras version

Hi gorinars, thanks!
After I downgraded Keras to v1.01, the result shows "437.192016 out of 647 correct" which means 68% accuracy. Much better!
But I have to say, it's still very poor comparing to other paper's result.
Hope the authors can tell us the best result they got.

I agree. There was partial explanation from the authors here https://github.com/da03/Attention-OCR/issues/3
I tried several setups, but unfortunately was not able to reproduce state-of-the art 80% on SVT data set

@gorinars  Now, what is your highest accuracy?

@gorinars @striversist Do you know what is the point of the  downgrade the version of keras to 1.0.1?

I came up with 68 percent on svt. No idea why downgrading helps. It just workerd

Hi gorinars, could you tell me what's your training parameters?
Strange, I can't get the accuracy by self training.
See my new issue #14

@da03
follow instructions under "Test and visualize attention results"
data-clear@dataclear:~/dev/tensorflow-playground/Attention-OCR$ docker run  -it --rm --name  attention-ocr  -v `pwd`:/home/work  dc/tensorflow-playground  /bin/bash

root@bdcd70cd18b0:/home/work# python -c "import keras; print keras.__version__"
Using TensorFlow backend.
1.1.1
root@bdcd70cd18b0:/home/work# python -c "import tensorflow as tf; print tf.__version__"
0.11.0

#!/usr/bin/env sh
python src/launcher.py --phase=test --visualize --data-path=evaluation_data/svt/test.txt --data-base-dir=evaluation_data/svt --log-path=log.txt --load-model --model-dir=model --output-dir=results

what i got is really confusing
 perplexity: 13.937011
2016-11-25 05:29:14,096 root  INFO     21.000000 out of 634 correct
2016-11-25 05:29:14,277 root  INFO     step_time: 0.179516, loss: 2.263902, step perplexity: 9.620557
2016-11-25 05:29:14,286 root  INFO     21.000000 out of 635 correct
2016-11-25 05:29:14,417 root  INFO     step_time: 0.128888, loss: 3.065607, step perplexity: 21.447473
2016-11-25 05:29:14,423 root  INFO     21.000000 out of 636 correct
2016-11-25 05:29:14,544 root  INFO     step_time: 0.120134, loss: 3.372941, step perplexity: 29.164180
2016-11-25 05:29:14,548 root  INFO     21.000000 out of 637 correct
2016-11-25 05:29:14,666 root  INFO     step_time: 0.117341, loss: 2.897969, step perplexity: 18.137276
2016-11-25 05:29:14,669 root  INFO     21.000000 out of 638 correct
2016-11-25 05:29:14,794 root  INFO     step_time: 0.123457, loss: 2.392969, step perplexity: 10.945946
2016-11-25 05:29:14,797 root  INFO     21.000000 out of 639 correct
2016-11-25 05:29:14,896 root  INFO     step_time: 0.097963, loss: 2.654452, step perplexity: 14.217194
2016-11-25 05:29:14,897 root  INFO     21.000000 out of 640 correct
2016-11-25 05:29:15,021 root  INFO     step_time: 0.122504, loss: 3.273077, step perplexity: 26.392437
2016-11-25 05:29:15,025 root  INFO     21.000000 out of 641 correct
2016-11-25 05:29:15,180 root  INFO     step_time: 0.151728, loss: 1.636524, step perplexity: 5.137279
2016-11-25 05:29:15,188 root  INFO     21.000000 out of 642 correct
2016-11-25 05:29:15,367 root  INFO     step_time: 0.177205, loss: 1.791313, step perplexity: 5.997324
2016-11-25 05:29:15,372 root  INFO     21.000000 out of 643 correct
2016-11-25 05:29:15,556 root  INFO     step_time: 0.181739, loss: 2.187555, step perplexity: 8.913390
2016-11-25 05:29:15,564 root  INFO     21.000000 out of 644 correct
2016-11-25 05:29:15,727 root  INFO     step_time: 0.161122, loss: 2.385032, step perplexity: 10.859412
2016-11-25 05:29:15,734 root  INFO     21.000000 out of 645 correct
2016-11-25 05:29:15,830 root  INFO     step_time: 0.095012, loss: 3.402723, step perplexity: 30.045791
2016-11-25 05:29:15,832 root  INFO     21.000000 out of 646 correct
2016-11-25 05:29:15,966 root  INFO     step_time: 0.133317, loss: 3.468472, step perplexity: 32.087675
2016-11-25 05:29:15,973 root  INFO     21.000000 out of 647 correct

Add flag --old-model-version. The reason is that keras changed its definition of parameters, and the model we provided is of an older version and needs addtional conversion.

root@bdcd70cd18b0:/home/work# ./test-visualize-attention-result-old.sh
Using TensorFlow backend.
usage: launcher.py [-h] [--gpu-id GPU_ID] [--use-gru] [--phase {train,test}]
                   [--data-path DATA_PATH] [--data-base-dir DATA_BASE_DIR]
                   [--visualize] [--no-visualize] [--batch-size BATCH_SIZE]
                   [--initial-learning-rate INITIAL_LEARNING_RATE]
                   [--num-epoch NUM_EPOCH]
                   [--steps-per-checkpoint STEPS_PER_CHECKPOINT]
                   [--target-vocab-size TARGET_VOCAB_SIZE]
                   [--model-dir MODEL_DIR]
                   [--target-embedding-size TARGET_EMBEDDING_SIZE]
                   [--attn-num-hidden ATTN_NUM_HIDDEN]
                   [--attn-num-layers ATTN_NUM_LAYERS] [--load-model]
                   [--no-load-model] [--log-path LOG_PATH]
                   [--output-dir OUTPUT_DIR]
launcher.py: error: unrecognized arguments: --old-model-version

when i update source code through  git pull  ,it works now
2016-11-25 10:00:36,928 root  INFO     197.000000 out of 628 correct
2016-11-25 10:00:37,043 root  INFO     step_time: 0.112366, loss: 3.656601, step perplexity: 38.729476
2016-11-25 10:00:37,048 root  INFO     197.000000 out of 629 correct
2016-11-25 10:00:37,144 root  INFO     step_time: 0.093842, loss: 1.202595, step perplexity: 3.328745
2016-11-25 10:00:37,146 root  INFO     197.000000 out of 630 correct
2016-11-25 10:00:37,238 root  INFO     step_time: 0.091346, loss: 0.692998, step perplexity: 1.999701
2016-11-25 10:00:37,240 root  INFO     197.000000 out of 631 correct
2016-11-25 10:00:37,334 root  INFO     step_time: 0.092255, loss: 0.195785, step perplexity: 1.216265
2016-11-25 10:00:37,336 root  INFO     198.000000 out of 632 correct
2016-11-25 10:00:37,426 root  INFO     step_time: 0.088780, loss: 4.159286, step perplexity: 64.025793
2016-11-25 10:00:37,428 root  INFO     198.000000 out of 633 correct
2016-11-25 10:00:37,541 root  INFO     step_time: 0.111132, loss: 0.520379, step perplexity: 1.682666
2016-11-25 10:00:37,544 root  INFO     198.000000 out of 634 correct
2016-11-25 10:00:37,642 root  INFO     step_time: 0.094887, loss: 2.293780, step perplexity: 9.912332
2016-11-25 10:00:37,646 root  INFO     198.000000 out of 635 correct
2016-11-25 10:00:37,759 root  INFO     step_time: 0.111603, loss: 0.103224, step perplexity: 1.108739
2016-11-25 10:00:37,761 root  INFO     199.000000 out of 636 correct
2016-11-25 10:00:37,865 root  INFO     step_time: 0.102322, loss: 0.360526, step perplexity: 1.434083
2016-11-25 10:00:37,868 root  INFO     199.000000 out of 637 correct
2016-11-25 10:00:37,983 root  INFO     step_time: 0.111453, loss: 1.082935, step perplexity: 2.953334
2016-11-25 10:00:37,988 root  INFO     199.000000 out of 638 correct
2016-11-25 10:00:38,141 root  INFO     step_time: 0.151684, loss: 1.953241, step perplexity: 7.051508
2016-11-25 10:00:38,148 root  INFO     199.000000 out of 639 correct
2016-11-25 10:00:38,256 root  INFO     step_time: 0.106356, loss: 0.196389, step perplexity: 1.217000
2016-11-25 10:00:38,259 root  INFO     200.000000 out of 640 correct
2016-11-25 10:00:38,372 root  INFO     step_time: 0.112090, loss: 0.869567, step perplexity: 2.385877
2016-11-25 10:00:38,376 root  INFO     200.000000 out of 641 correct
2016-11-25 10:00:38,485 root  INFO     step_time: 0.107597, loss: 3.044632, step perplexity: 21.002300
2016-11-25 10:00:38,488 root  INFO     200.000000 out of 642 correct
2016-11-25 10:00:38,641 root  INFO     step_time: 0.151425, loss: 1.001689, step perplexity: 2.722876
2016-11-25 10:00:38,647 root  INFO     200.000000 out of 643 correct
2016-11-25 10:00:38,742 root  INFO     step_time: 0.094533, loss: 0.338087, step perplexity: 1.402263
2016-11-25 10:00:38,744 root  INFO     200.000000 out of 644 correct
2016-11-25 10:00:38,843 root  INFO     step_time: 0.093424, loss: 2.399895, step perplexity: 11.022021
2016-11-25 10:00:38,848 root  INFO     200.000000 out of 645 correct
2016-11-25 10:00:38,959 root  INFO     step_time: 0.108594, loss: 0.217461, step perplexity: 1.242917
2016-11-25 10:00:38,963 root  INFO     201.000000 out of 646 correct
2016-11-25 10:00:39,053 root  INFO     step_time: 0.088361, loss: 3.017737, step perplexity: 20.444971
2016-11-25 10:00:39,055 root  INFO     201.000000 out of 647 correct

Yep I'm afraid that's indeed the exact match accuracy that the provided model can achieve. The model structure is not heavily tuned, and it's not trained until convergence. From my experience, using vanilla sgd with learning rate decay and gradient clipping can achieve a better optimum than adam (although we need to tune initial learning rate, decay and clipping threshold in that case). My repository torch-attention-ocr can train a model acieving state-of-the-art performance, though it's written in torch and does not come with a documentation at this time point.

thx for your help ,i will try torch  later

@striversist this problem solved now?

hi @gorinars @striversist  i got the same result with yours,but when i check the results folds,i only find about 170 fold in correct fold which means accuracy is below 30%..,i have downgraded the keras version.so do you have the same problem?thanks  a lot .


ARTEMIS-3175 - implement address setting management-message-attribute…

…-size-limit to sensibly limit data returned by list/browse/filter management ops

along with the feature, there were a few little bug fixes, like byte[] properties not being parsed to json or small message bodies on text messages being null. Those scenarios are covered in the tests.

This looks quite risky in change of core messages etc, if scope is meant just for management console/cli etc,  Not sure we need to change such core internals just for management api layer. Surely it can be handled at a layer above.

I think this is good to go. the core api remains intact and the overrides with limits are used from the jmx/control points to enforce the limits that can protect the broker and UI's. Thanks for the feedback!


Outage Message - ECMPS

As an ECMPS beta user, I want to be informed when there is a system outage in ECMPS so that I understand that the functionality is not available due to maintenance activities
Acceptance Criteria:
Given I am an ECMPS user accessing the application
When there is a maintenance activity in progress (beta deployment etc)
Then I see an informational message on the screen
'The background color for the banner is Light Blue'
Informational Message:
Please be aware that ECMPS shall be unavailable due to a scheduled maintenance activity starting Friday, March 4th at 11:30 am to Sunday, March 6th 9:00 am
Notes:

Add a outagewindow.json folder on the Home page (https://github.com/US-EPA-CAMD/easey-content/tree/master/dev/ecmps/home)
USWDS Site Alert Component: https://designsystem.digital.gov/components/site-alert/

Test Case: TC638
Test Passed


proposal for consistent release pkg names

Hey! I'd like to propose that pkg releases follow a pattern that doesn't change between releases. I see that 1.8 had Mist.1.8.pkg, yet 1.9.1 has mist-cli.1.9.1.pkg. I like the mist-cli.{VERSION}.pkg format a lot and would love for that to be the standard so I can easily automate changing the download URL when new versions of mist are released.
Thanks!

Sunds great!
Version 1.8 > 1.9 of mist-cli was around the time Mist.app was released, so the change in release names was established to minimise confusion.
Moving forward, mist-cli will continue to follow the mist-cli.{VERSION}.pkg filename format 👍


Add support for setting tabs/spaces preference in Tools->Options

Summary of the changes

Adds support for tabs/spaces user settings, i.e. when you go into Tools->Options now, you should now see a nifty new Razor (ASP.NET Core) section. This replaces the existing ASP.NET Core Razor Language Services in Tools->Options, which previously wasn't hooked up to anything.
A big part of this PR is @ajaybhargavb's work from #1606, so thank you Ajay!
This PR also should go in with:
VS PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/309612 (needs to go in first before this PR)
Roslyn PR: https://github.com/dotnet/roslyn/pull/52044
ASPNetCore PR: https://github.com/dotnet/aspnetcore/pull/31211

A couple of notes about what currently doesn't work:

UPDATE: This seems to be working now. In the lower right-hand corner of the editor, the correct current TABS/SPC option is displayed. However, switching between tabs and spaces by clicking on a different option is still not currently supported, and the current option isn't "checked" like it should be. I'm not sure why, but this will probably take more time digging into the VS side to investigate. I don't think this is is a major blocker since users can just set their preference in Tools->Options, but it's something we should look into in the future. https://github.com/dotnet/aspnetcore/issues/28003 has already been created for this.

In the Tabs page of Tools->Options there's an "Indenting" section (see first screenshot). None of these options actually do anything, since Razor uses language-configuration.json to power indenting. All three radio buttons should probably be disabled, but current VS infrastructure seems to only support disabling "Smart" indent specifically, so I left all three for now. Created follow-up issue here: https://github.com/dotnet/aspnetcore/issues/31184

Fixes:
https://github.com/dotnet/aspnetcore/issues/30254
https://github.com/dotnet/aspnetcore/issues/27101
https://github.com/dotnet/aspnetcore/issues/28003

@dotnet/razor-tooling @NTaylorMullen I've pushed some changes that update the behavior in the TextViewConnectionListener. Would appreciate any feedback!
Also, I mentioned in the PR description that the active spaces/tabs option (https://github.com/dotnet/aspnetcore/issues/28003) wasn't working, but it seems I was mistaken. The user just has to type a bit in the document before being able to freely toggle between tabs/spaces. (The same behavior is observed in C#.) I've updated the PR description accordingly.


recipe for upgrading the mvcJpa project to spring boot

What needs to be done
Why it needs to be done
Acceptance Criteria
/info panel
Given precondition
When action
Then result
Additional Information

The issue lacks detail. Please provide enough detail and reopen.


(🎁) Add "Search terms" to the new issue template

typescript has this super useful section in the issue template where you list searchable terms:
- type: textarea
    id: search_terms
    attributes:
      label: '🔎 Search Terms'
      description: |
        What search terms did you use when trying to find an existing bug report?

        List them here so people in the future can find this one more easily.
      placeholder: |
        List of keywords you searched for before creating this issue. Write them down here so that others can find this bug more easily and help provide feedback.

        e.g. "function inference any", "jsx attribute spread", "move to file duplicate imports", "discriminated union inference", "ts2822"
    validations:
      required: true

Oh, that's a nice idea.


Returnhook

Issue #, if available: #748
Description of changes: Adds functionality for callbacks to be implemented by any plugin that amplify supports (both 3rd party and 1st party plugins can be supported with this). This just builds on top of the callback for frontend development and adds support for the categories.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kaustavghosh06 Fixed. Sorry about that.

How does one access this hook when creating a plugin? Would be great to include it in here Plugins

@derrick3192 We are working on updating the docs but to use it you just need to add this code to your index.js file.
async function onAmplifyCategoryOutputChange(context) {
  //callback code
}

Awesome! Appreciate the replly cheers.


Add arguments required by IE for createTreeWalker

Internet Explorer requires all four arguments be passed to the document.createTreeWalker method. Thus, Util#getTextNodes was throwing an uncaught error in IE. This fixes that by passing default values for the missing arguments.

Thanks!


[0.29.x] IpythonMagic: Replace deprecated imp.load_dynamic() with importlib

Backport of #4941. Related to #5285.

Thanks


Update MANUAL_INSTRUCTIONS.md

begining -> beginning

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


[Impeller] Playground failing on Mac.

% out/host_debug_unopt_arm64/impeller_unittests --gtest_filter="*AiksTest.ColorWheel*" --enable_playground
[INFO:test_timeout_listener.cc(76)] Test timeout of 120 seconds per test case will be enforced.
Note: Google Test filter = *AiksTest.ColorWheel*
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from Play/AiksTest
[ RUN      ] Play/AiksTest.ColorWheel/Metal
[FATAL:flutter/impeller/base/validation.cc(47)] Break on 'ImpellerValidationBreak' to inspect point of failure: Pipeline for command and the render target disagree on sample counts (target was 1 but pipeline wanted 4).
zsh: abort      out/host_debug_unopt_arm64/impeller_unittests  --enable_playground

I just tested this on ToT with validations and it seemed to be fine. I suspect this was due to the patches regarding sample counts near head recently. Can you pull and try again?


Update to latest Sylvan packages.

Modest gains for the next round, whenever that might happen. Happy new year, Joel. Enjoy your leave.

Thanks Mark!


Create a basic inventory management module

🚀 Feature Proposal
This issue is to create a very basic inventory module. When this issue is finished, I would expect to be able to:

create a new inventory item
view a list of all inventory items
view a single inventory item

Technical Notes
Model Name InventoryItem defined as:
{
  id: string
  name: string
  rank: string
  type: clothing|equipment|medication
  crossReference: string
  reorderPoint: number
  distributionUnit: ampoule|bag|bottle|box|bundle|capsule|case|container|cream|each|gel|nebule|ointment|pack|pair|pallet|patch|pcs|pill|plastic|polyamp|rollset|spray|suppository|suspension|syrup|tablet|tray|tube|vial
  pricePerUnit: number
  note: string
}

id should be auto-generated
There should be a text box which allows me to search for inventory items
Add the ability to filter the search by type, including the ability to show all types
The table of matching items should show the following fields:
name, type, reorder point, distribution unit, price per unit

Permissions

Add new set of permissions for viewing and adding inventory items

Menu / Sidebar

Add a sidebar link named Inventory below the Incidents link
Underneath the Inventory sidebar menu, add "Add Inventory Item" and "Inventory Items" options
Add "Add Inventory Item" to quick create button in the Navbar as the last item

Hi @blestab @fox1t @tehKapa @jackcmeyer @morrme, could I please take this on?

Sure @gcrt0701 thank  you

Is this still assigned and being worked on? Otherwise im interested in taking it.

Sorry for the delay. I've completed the code entirely but I'm still in the process of testing.

Np @gcrt0701. take your time

@gcrt0701 Hello. Any updates on this?

Hello, some students from my team at Stanford are planning on finishing the testing. @anthonyaperez can give you their names.

@tehKapa @jackcmeyer @fox1t I can confirm that @aaronlwan and @Bri-Guy would like to be assigned this task.

@tehKapa @jackcmeyer @fox1t I can confirm that @aaronlwan and @Bri-Guy would like to be assigned this task.

I need their comment to assign them to this issue

@tehKapa Hello! Yes, I'd like to be assigned this issue. Thank you!

@tehKapa I would also like to be assigned. Thanks!


[Proposal] allow configuration through synthetics.config.js

Suite params options is super useful for passing down params for every journey files, however it becomes difficult when there are multiple environments involved like staging, ci and production and the whole suite level params keep changing for each of those environments. The proposal address that by allowing a configuration file which lets users inject params depending on the environment.

module.exports = {
  // defaults to development
  params: {
    url: 'http://localhost:8080',
  },
};

// To change params based on environment, users can return
// a function

module.exports = env => {
  if (env === 'development') {
    return {
      params: {
        url: 'http://localhost:8080',
      },
    };
  }
  return {
    params: {
      url: 'http://elastic.co',
    },
  };
};

Note: params is explicitly kept as key to allow extending this configuration in the future.
This setup and validation of config would be done before invoking any journeys and we would pass down these parameters to the individual journeys.
beforeAll(({ params }) => {
  let server;
  if (params.env === "development") {
    server = await startServer();
  }
});

afterAll(({ params }) => {
  if (params.env === "development") {
    server.stop()
  }
})

journey('journey1', ({ page, params }) => {
  step('step1', async () => {
    await page.goto(params.url);
  });
});

Purposefully this model exists as we don't want to support any other way of loading configs, By that I mean we don't want to support .json, .yml or any other extensions. Let's stick to a single way of doing config loading.

I love this proposal except one question: why make the user write conditional logic to determine which programs to return for which environment? What if we just had an object that was keyed by environment name so they didn't have to write the else logic? Development would be the default environment.
I'm open to this approach but I just like to hear your thoughts on this method versus the one I mentioned above.

Actually, I'm fine with the proposal as-is, no need to nitpick

I thought about that approach and went away from it due to two reasons

As we allow users to already to configure environment using -e flag, it felt more natural to pass down that config, instead of asking users to manually bookkeep it, Assuming users are invoking this script in package.json

"scripts": {
    "test:synthetics": "npx @elastic/synthetics -e 'staging' --config test/synthetics.config.js"
}

Users have to somehow sync the -e flag with the params, passing down the environment felt like a natural choice here.

Small nitpick: Functions felt more composable and extendable than the plain JSON object.

This looks like a good option to me


Update get-resource-changes.md

Removed json error

@ljtill : Thanks for your contribution! The author, @DCtheGeek, has been notified to review your proposed change.

@ljtill Thanks for catching that!  I missed it.  #sign-off


Item after last cloned item is not visible while stagePadding is active

Item after last cloned item is not visible while stagePadding is set to anything other than zero (0). Loop option is set true here. Check my screenshot. Rightmost image show is the last cloned item. The next item is not visible till you swipe or autoplay triggers.

Can someone verify that this is still an issue?

The issue reproduces.
I used files from the latest development.
Example
http://codepen.io/anon/pen/vNyJQP

The reason this happens is that the function responsible for creating the clones does not take stagePadding into account and creates too few clones in certain cases (specifically where # items <= # items displayed at once). It is still an issue in 2.1.4.


[Bug]: Table cell and text colour pickers do not get updated after changing app theme colour

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Table cell and text colour pickers do not get updated after changing app theme colour
Steps To Reproduce

Change app theme colour on an a table widget on the Anvil instance
Drop a table widget on the canvas and connect to some data
Navigate to the style tab and notice colours listed under theme colours and application colours

Public Sample App
No response
Environment
Production
Severity
Low (Inconsistent UI/UX)
Issue video log
https://www.loom.com/share/7aef9641655147b9bbc3a36cd9119737
Version
cloud

@jsartisan should we keep this open still when this property no longer exists on the table?

Seems like not relevant already. @ramsaptami could you check this please?


Add cusignal notebooks to skip list

Per request from @awthomp, these notebooks should be added to the skip list.

related to this PR: https://github.com/rapidsai/cusignal/pull/442


E5108: Error executing lua ...nfig/nvim/pack/packer/start/fzf-lua/lua/fzf-lua/core.lua:248: ...nfig/nvim/pack/packer/start/fzflua/lua/fzf-lua/core.lua:98: table index is nil

Following up on https://github.com/ibhagwan/fzf-lua/issues/59#issuecomment-907883990
I'm still getting
E5108: Error executing lua ...nfig/nvim/pack/packer/start/fzf-lua/lua/fzf-lua/core.lua:248: ...nfig/nvim/pack/packer/start/fzflua/lua/fzf-lua/core.lua:98: table index is nil
Press ENTER or type command to continue

I lost track of this because it was discussed in a totally different issue, so just to iterate, this happens only when running inside the encrypted repo correct?
Does it work when you disable git_icons? you can quickly test that with:
:lua require('fzf-lua').files({ git_icons = false })

Also, can you please provide me with a sample output of the command git diff --name-status --relative HEAD run inside your encrypted repository with a few modified files?
The regex you provided on the other issue (/^(M|U|D|A|R)\s(.*)/g) might work but unfortunately lua does not support regex and instead has it's own version of regex like pattern matching, I'll have to convert to lua-regex and make sure it works before I commit this.

this happens only when running inside the encrypted repo correct?

yes, correct.

Does it work when you disable git_icons? you can quickly test that with:
:lua require('fzf-lua').files({ git_icons = false })

This runs fine

Also, can you please provide me with a sample output of the command git diff --name-status --relative HEAD run inside your encrypted repository with a few modified files?

*** WARNING : deprecated key derivation used.
Using -iter or -pbkdf2 would be better.
M       config/.ssh/config
M       config/nvim/lua/_/config/telescope.lua
M       config/nvim/lua/_/packer.lua
M       config/weechat/sec.conf
M       nix/hosts/pandoras-box.nix
M       nix/modules/shared/shell.nix

Just committed a fix, update your plugin and let me know if this works for you?

It works fine now

Great! I'll have a fix for your other issue very soon, just testing.


Make csp_queue internal

Just like semaphore (#333), we'd like to make csp_queue internal and remove from our API.

Absolutely yes.
In fact, i might go as far to include a simple OS independent queue implementation. I think i have mentioned this before. A basic linked list with a simple protection scheme depending on the use case and OS.
For barebone / non-os, we can simply disable interrupt. FreeRTOS has a method of entering a critical section (because it's single threaded, and will suspend the interrupt, the task cannot be preepted). Posix will use a mutex, with an infinite timeout. I presume Zephyr has an equally simple method to protection as FreeRTOS. Furthermore, the protection is only necessary when manipulating the list, so it's for a very short duration only.
On FreeRTOS a queue is a quite large construct, with mutex and everything. This takes up a lot of memory on itself because that needs to be pre-allocated. Furthermore, the work done in the critical section of a linked-list, is much quicker and usually done before the FreeRTOS queue call has even started. It's quite costly to do context switching, and in my opinion it's just better to use a critical section to do the work of the list manipulation. If we think about it, a FreeRTOS context switch involved moving a task pointer from one linked list (the run queue, to the suspended queue) and vice versa for another one. So a full-on FreeRTOS queue is probably like 10x-100x times slower than necessary.


VMware: VM operations fail after inter-cluster storage migration

ISSUE TYPE

Bug Report

COMPONENT NAME
VMware

CLOUDSTACK VERSION
4.15

CONFIGURATION

Advanced networking
Vmware 6,5 datacenter

2 clusters
1 host per cluster

2 NFS cluster-wide storage pools (1 per cluster)

OS / ENVIRONMENT
SUMMARY
After performing a storage migration of a VM from one cluster to another, it is not possible to start a VM
STEPS TO REPRODUCE
Create VM on cluster 1 (host 1, pool 1)
Stop VM
Migrate instance to pool 2
Start VM

EXPECTED RESULTS
VM is running

ACTUAL RESULTS
VM disk cannot be found

2021-03-17 17:09:26,591 INFO  [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-14:ctx-6c9cf0b4 job-73/job-75 ctx-e05b0cda) (logid:4dd5fc60) Unable to contact resource.
com.cloud.exception.StorageUnavailableException: Resource [StoragePool:4] is unreachable: Migrate volume failed: copy volume from primary to secondary failed due to exception: Exception: com.sun.xml.ws.fault.ServerSOAPFaultExc
eption
Message: Client received SOAP Fault from server:
Required property fileName is missing from data object of type VirtualDiskFlatVer2BackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk.FlatVer2BackingInfo
at line 1, column 331

while parsing property "backing" of static type VirtualDeviceBackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk
at line 1, column 233

while parsing property "device" of static type VirtualDevice

while parsing serialized DataObject of type vim.vm.device.VirtualDeviceSpec
at line 1, column 193

while parsing property "deviceChange" of static type ArrayOfVirtualDeviceConfigSpec

while parsing serialized DataObject of type vim.vm.ConfigSpec
at line 1, column 187

while parsing call information for method ReconfigVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method reconfigure
on object of type vim.VirtualMachine
at line 1, column 0 Please see the server log to find more detail regarding exact cause of the failure.

        at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.migrateVolume(VolumeOrchestrator.java:1119)
        at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.prepare(VolumeOrchestrator.java:1543)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1151)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5464)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
        at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5631)
        at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)

@nvazquez were you able to check the behaviour with master and 4.14. I think 4.14 might be having a similar problem and this should be fixed in master with #4385

@nvazquez I'm able to reproduce this on 4.14.1 as well,
2021-03-18 10:47:51,161 DEBUG [c.c.a.t.Request] (AgentManager-Handler-1:null) (logid:) Seq 6-5096948878276558866: Processing:  { Ans: , MgmtId:<PHONE_NUMBER>4547, via: 6, Ver: v1, Flags: 10, [{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"result":false,"details":"copy volume from primary to secondary failed due to exception: Exception: com.sun.xml.ws.fault.ServerSOAPFaultException\nMessage: Client received SOAP Fault from server: \nRequired property fileName is missing from data object of type VirtualDiskFlatVer2BackingInfo\n\nwhile parsing serialized DataObject of type vim.vm.device.VirtualDisk.FlatVer2BackingInfo\nat line 1, column 331\n\nwhile parsing property \"backing\" of static type VirtualDeviceBackingInfo\n\nwhile parsing serialized DataObject of type vim.vm.device.VirtualDisk\nat line 1, column 233\n\nwhile parsing property \"device\" of static type VirtualDevice\n\nwhile parsing serialized DataObject of type vim.vm.device.VirtualDeviceSpec\nat line 1, column 193\n\nwhile parsing property \"deviceChange\" of static type ArrayOfVirtualDeviceConfigSpec\n\nwhile parsing serialized DataObject of type vim.vm.ConfigSpec\nat line 1, column 187\n\nwhile parsing call information for method ReconfigVM_Task\nat line 1, column 110\n\nwhile parsing SOAP body\nat line 1, column 102\n\nwhile parsing SOAP envelope\nat line 1, column 38\n\nwhile parsing HTTP request for method reconfigure\non object of type vim.VirtualMachine\nat line 1, column 0 Please see the server log to find more detail regarding exact cause of the failure.\n","wait":0}}] }
2021-03-18 10:47:51,162 DEBUG [c.c.a.t.Request] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Seq 6-5096948878276558866: Received:  { Ans: , MgmtId:<PHONE_NUMBER>4547, via: 6(s-3-VM), Ver: v1, Flags: 10, { CopyCmdAnswer } }
2021-03-18 10:47:51,165 DEBUG [o.a.c.s.m.AncientDataMotionStrategy] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) copy to image store failed: copy volume from primary to secondary failed due to exception: Exception: com.sun.xml.ws.fault.ServerSOAPFaultException
Message: Client received SOAP Fault from server:
Required property fileName is missing from data object of type VirtualDiskFlatVer2BackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk.FlatVer2BackingInfo
at line 1, column 331

while parsing property "backing" of static type VirtualDeviceBackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk
at line 1, column 233

while parsing property "device" of static type VirtualDevice

while parsing serialized DataObject of type vim.vm.device.VirtualDeviceSpec
at line 1, column 193

while parsing property "deviceChange" of static type ArrayOfVirtualDeviceConfigSpec

while parsing serialized DataObject of type vim.vm.ConfigSpec
at line 1, column 187

while parsing call information for method ReconfigVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method reconfigure
on object of type vim.VirtualMachine
at line 1, column 0 Please see the server log to find more detail regarding exact cause of the failure.

2021-03-18 10:47:51,177 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) getCommandHostDelegation: class org.apache.cloudstack.storage.command.DeleteCommand
2021-03-18 10:47:51,177 DEBUG [c.c.h.XenServerGuru] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) We are returning the default host to execute commands because the command is not of Copy type.
2021-03-18 10:47:51,178 DEBUG [c.c.a.t.Request] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Seq 6-5096948878276558867: Sending  { Cmd , MgmtId:<PHONE_NUMBER>4547, via: 6(s-3-VM), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.storage.command.DeleteCommand":{"data":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"63a1d382-a940-4fa7-8883-d43b7ec81568","volumeType":"ROOT","dataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"NFS://<IP_ADDRESS>/acs/secondary/ref-trl-578-v-M7-abhishek-kumar/ref-trl-578-v-M7-abhishek-kumar-sec1","_role":"Image"}},"name":"ROOT-5","size":2147483648,"volumeId":5,"vmName":"i-2-5-VM","accountId":2,"chainInfo":"{\"diskDeviceBusName\":\"ide0:1\",\"diskChain\":[\"[84fbeee887b0381ea9a174e230cdf243] i-2-5-VM/ROOT-5.vmdk\",\"[84fbeee887b0381ea9a174e230cdf243] 882af2a1543c3d2c82cc671824a30f86/882af2a1543c3d2c82cc671824a30f86.vmdk\"]}","format":"OVA","provisioningType":"THIN","id":5,"deviceId":0,"hypervisorType":"VMware","directDownload":false}},"wait":0}}] }
2021-03-18 10:47:51,221 DEBUG [c.c.a.t.Request] (AgentManager-Handler-2:null) (logid:) Seq 6-5096948878276558867: Processing:  { Ans: , MgmtId:<PHONE_NUMBER>4547, via: 6, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":true,"details":"Object with null install path does not exist on image store , no need to delete","wait":0}}] }
2021-03-18 10:47:51,222 DEBUG [c.c.a.t.Request] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Seq 6-5096948878276558867: Received:  { Ans: , MgmtId:<PHONE_NUMBER>4547, via: 6(s-3-VM), Ver: v1, Flags: 10, { Answer } }
2021-03-18 10:47:51,223 WARN  [o.a.c.s.d.ObjectInDataStoreManagerImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Volume 5 is not found on image store 1, so no need to delete
2021-03-18 10:47:51,231 WARN  [o.a.c.s.d.ObjectInDataStoreManagerImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Unsupported data object (VOLUME, org.apache.cloudstack.storage.datastore.PrimaryDataStoreImpl@a881511), no need to delete from object in store ref table
2021-03-18 10:47:51,240 DEBUG [c.c.r.ResourceLimitManagerImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Updating resource Type = volume count for Account = 2 Operation = decreasing Amount = 1
2021-03-18 10:47:51,243 DEBUG [c.c.r.ResourceLimitManagerImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Updating resource Type = primary_storage count for Account = 2 Operation = decreasing Amount =<PHONE_NUMBER>
2021-03-18 10:47:51,249 DEBUG [o.a.c.s.v.VolumeServiceImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Marking volume that was never created as destroyed: Vol[7|vm=null|ROOT]
2021-03-18 10:47:51,252 ERROR [o.a.c.e.o.VolumeOrchestrator] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Migrate volume failed:copy volume from primary to secondary failed due to exception: Exception: com.sun.xml.ws.fault.ServerSOAPFaultException
Message: Client received SOAP Fault from server:
Required property fileName is missing from data object of type VirtualDiskFlatVer2BackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk.FlatVer2BackingInfo
at line 1, column 331

while parsing property "backing" of static type VirtualDeviceBackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk
at line 1, column 233

while parsing property "device" of static type VirtualDevice

while parsing serialized DataObject of type vim.vm.device.VirtualDeviceSpec
at line 1, column 193

while parsing property "deviceChange" of static type ArrayOfVirtualDeviceConfigSpec

while parsing serialized DataObject of type vim.vm.ConfigSpec
at line 1, column 187

while parsing call information for method ReconfigVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method reconfigure
on object of type vim.VirtualMachine
at line 1, column 0 Please see the server log to find more detail regarding exact cause of the failure.

2021-03-18 10:47:51,252 INFO  [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-11:ctx-c13d51d0 job-45/job-47 ctx-2b7429c1) (logid:c09c0bd8) Unable to contact resource.
com.cloud.exception.StorageUnavailableException: Resource [StoragePool:4] is unreachable: Migrate volume failed: copy volume from primary to secondary failed due to exception: Exception: com.sun.xml.ws.fault.ServerSOAPFaultException
Message: Client received SOAP Fault from server:
Required property fileName is missing from data object of type VirtualDiskFlatVer2BackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk.FlatVer2BackingInfo
at line 1, column 331

while parsing property "backing" of static type VirtualDeviceBackingInfo

while parsing serialized DataObject of type vim.vm.device.VirtualDisk
at line 1, column 233

while parsing property "device" of static type VirtualDevice

while parsing serialized DataObject of type vim.vm.device.VirtualDeviceSpec
at line 1, column 193

while parsing property "deviceChange" of static type ArrayOfVirtualDeviceConfigSpec

while parsing serialized DataObject of type vim.vm.ConfigSpec
at line 1, column 187

while parsing call information for method ReconfigVM_Task
at line 1, column 110

while parsing SOAP body
at line 1, column 102

while parsing SOAP envelope
at line 1, column 38

while parsing HTTP request for method reconfigure
on object of type vim.VirtualMachine
at line 1, column 0 Please see the server log to find more detail regarding exact cause of the failure.

	at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.migrateVolume(VolumeOrchestrator.java:990)
	at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.prepare(VolumeOrchestrator.java:1408)
	at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1133)
	at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5287)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
	at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5454)
	at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
	at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:603)
	at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
	at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
	at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:551)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

Checking on master. Should happen there :crossed_fingers:

@nvazquez working fine on the master. I'm not able to reproduce there,
Storage pools
(localcloud) SBCM5> > list storagepools filter=id,name,clusterid,clustername,scope,
{
  "count": 2,
  "storagepool": [
    {
      "clusterid": "b246199b-174b-4881-acdd-e1614554c883",
      "clustername": "<IP_ADDRESS>/Trillian/p1-c2",
      "id": "9c8729f3-8885-3e25-afae-6e8ba31fc48b",
      "name": "ps2",
      "scope": "CLUSTER"
    },
    {
      "clusterid": "8f2bb91a-cb1a-4f52-9b5a-5d8f53bb4042",
      "clustername": "p1-c1",
      "id": "d655eab5-8199-3cc7-95ac-e5ffa68da70b",
      "name": "ps1",
      "scope": "CLUSTER"
    }
  ]
}

VM
(localcloud) SBCM5> > list virtualmachines id=c0043b7d-93b8-475f-8ff4-8c04a79be69f  filter=id,name,hostid,hostname
{
  "count": 1,
  "virtualmachine": [
    {
      "hostid": "c3590057-9726-449c-9268-caabf15c92c9",
      "hostname": "<IP_ADDRESS>",
      "id": "c0043b7d-93b8-475f-8ff4-8c04a79be69f",
      "name": "t1"
    }
  ]
}

Host details to find cluster
(localcloud) SBCM5> > list hosts id=c3590057-9726-449c-9268-caabf15c92c9 filter=id,name,clusterid,clustername,
{
  "count": 1,
  "host": [
    {
      "clusterid": "8f2bb91a-cb1a-4f52-9b5a-5d8f53bb4042",
      "clustername": "p1-c1",
      "id": "c3590057-9726-449c-9268-caabf15c92c9",
      "name": "<IP_ADDRESS>"
    }
  ]
}

Stop VM
(localcloud) SBCM5> > stop virtualmachine id=c0043b7d-93b8-475f-8ff4-8c04a79be69f filter=id,name,state
{}

Storage migration
(localcloud) SBCM5> > migrate virtualmachine virtualmachineid=c0043b7d-93b8-475f-8ff4-8c04a79be69f storageid=9c8729f3-8885-3e25-afae-6e8ba31fc48b
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "52%",
    "created": "2021-03-18T12:23:45+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "ide"
    },
    "diskioread": 57,
    "diskiowrite": 34,
    "diskkbsread": 2209,
    "diskkbswrite": 255,
    "displayname": "t1",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "61567101-87de-11eb-a346-1e00b6000460",
    "guestosid": "615cf7b8-87de-11eb-a346-1e00b6000460",
    "haenable": false,
    "hypervisor": "VMware",
    "id": "c0043b7d-93b8-475f-8ff4-8c04a79be69f",
    "instancename": "i-2-5-VM",
    "isdynamicallyscalable": false,
    "memory": 512,
    "memoryintfreekbs": 393216,
    "memorykbs": 524288,
    "memorytargetkbs": 524288,
    "name": "t1",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "extradhcpoption": [],
        "gateway": "<IP_ADDRESS>",
        "id": "004fd0b6-68b0-46ff-9588-dc4ebef28358",
        "ipaddress": "<IP_ADDRESS>",
        "isdefault": true,
        "macaddress": "02:00:17:78:00:01",
        "netmask": "<IP_ADDRESS>",
        "networkid": "64dfde30-152d-40bc-be15-a480e09ef36f",
        "networkname": "test",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.3 (64-bit)",
    "ostypeid": "615cf7b8-87de-11eb-a346-1e00b6000460",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "423053f5-0195-4196-9544-f30cf843d755",
    "serviceofferingname": "Small Instance",
    "state": "Stopped",
    "tags": [],
    "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "templateid": "61596d4f-87de-11eb-a346-1e00b6000460",
    "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "userid": "76aa39e8-87de-11eb-a346-1e00b6000460",
    "username": "admin",
    "zoneid": "6607b15e-5ca2-4d99-af51-3b1590698754",
    "zonename": "pr4378-t173-vmware-65u2"
  }
}

Start migrated VM
(localcloud) SBCM5> > start virtualmachine id=c0043b7d-93b8-475f-8ff4-8c04a79be69f
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "52%",
    "created": "2021-03-18T12:23:45+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "ide"
    },
    "diskioread": 57,
    "diskiowrite": 34,
    "diskkbsread": 2209,
    "diskkbswrite": 255,
    "displayname": "t1",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "61567101-87de-11eb-a346-1e00b6000460",
    "guestosid": "615cf7b8-87de-11eb-a346-1e00b6000460",
    "haenable": false,
    "hostid": "877fff60-d5c8-415e-82ad-65330a845a11",
    "hostname": "<IP_ADDRESS>",
    "hypervisor": "VMware",
    "id": "c0043b7d-93b8-475f-8ff4-8c04a79be69f",
    "instancename": "i-2-5-VM",
    "isdynamicallyscalable": false,
    "jobid": "1b8e7636-6444-4884-a91c-547c069bd442",
    "jobstatus": 0,
    "memory": 512,
    "memoryintfreekbs": 393216,
    "memorykbs": 524288,
    "memorytargetkbs": 524288,
    "name": "t1",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "broadcasturi": "vlan://1951",
        "extradhcpoption": [],
        "gateway": "<IP_ADDRESS>",
        "id": "004fd0b6-68b0-46ff-9588-dc4ebef28358",
        "ipaddress": "<IP_ADDRESS>",
        "isdefault": true,
        "isolationuri": "vlan://1951",
        "macaddress": "02:00:17:78:00:01",
        "netmask": "<IP_ADDRESS>",
        "networkid": "64dfde30-152d-40bc-be15-a480e09ef36f",
        "networkname": "test",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.3 (64-bit)",
    "ostypeid": "615cf7b8-87de-11eb-a346-1e00b6000460",
    "passwordenabled": false,
    "pooltype": "NetworkFilesystem",
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "423053f5-0195-4196-9544-f30cf843d755",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "templateid": "61596d4f-87de-11eb-a346-1e00b6000460",
    "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "userid": "76aa39e8-87de-11eb-a346-1e00b6000460",
    "username": "admin",
    "zoneid": "6607b15e-5ca2-4d99-af51-3b1590698754",
    "zonename": "pr4378-t173-vmware-65u2"
  }
}

Thanks @shwstppr! Closing it

Hi @nvazquez
why will this issue not going to be fixed in 4.15.1. after all, even it is classified as BLOCKER and a fix is already available?

We closed this as compared to 4.14 this wasn't found out as a regression. However, our colleague @andrijapanicsb did some testing and confirmed it as a regression compared to 4.11.3. Re-opening this on Andrija's remark. We'll track this against 4.15.1.

Fixed in https://github.com/apache/cloudstack/pull/4895


version 0.8.0

Hi, I noticed that v0.8.0 is the latest version according to npm info vite-plugin-solid-svg, but v0.7.0 is the latest according to the changelog and the main branch.
Also, TS is unable to find the appropriate types in v0.8.0 because in package.json exports['.'].types doesn't exist.
I'm not sure if 0.8.0 is an unintentional/unsupported release, or if the main branch of this repo is somehow out of date. Either way, I think something is off here.

Thank you very much,
I forgot to push the latest changes.
The types are working for Node 16 ESM and bundler. I don't know how to make all of them work, so I fixed the modern ones instead of the older ones. If you can help me, PRs are welcome.

source: https://arethetypeswrong.github.io/?p=vite-plugin-solid-svg%400.8.0


Uncaught TypeError when deleting a shared vertex

If you select multiple features and delete a shared vertex, you'll see an error like:
Uncaught TypeError: Cannot read property 'closure_uid_45707381' of null

In the modify interaction, we're calling source.removeFeature(null).
I haven't done a git blame, but this works in the 3.6.0 release and not in 3.7.0.  The modify features example demonstrates the problem.

Though the "problem" existed before, prior to 53d5d8c1d9a050ff99755703b16239a6e48a4750 an error wasn't raised because calling overlay.removeFeature(null) doesn't throw (collection.remove(null) doesn't throw.  Looks like the right fix is to check for null before calling source.removeFeature() (as is done elsewhere in the modify interaction).


Bump to layer 179

Now looking at Telethon (since that also needs to handle the invited users thing), I've noticed it handles a few more types:
https://github.com/LonamiWebs/Telethon/blob/1974b663a29bbd97ff70bd249f49d899a5cf765e/telethon/network/mtprotosender.py#L693-L697
Those are probably also needed in grammers. Maybe best to leave that correction to a separate PR and just fix messages.InvitedUsers here.


React native “fontFamily is not a valid style attribute”

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
  React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
      Memory: 361.27 MB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 10.13.0 - /usr/local/bin/node
      Yarn: 1.12.1 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.6.0 => 16.6.0
      react-native: ^0.57.4 => 0.57.4
    npmGlobalPackages:
      react-native-cli: 2.0.1

Description

I've been getting this error today in my react native/expo project. I have tried clearing cache and re-installing packages, etc.
My package.json is the following:
{
  "name": "empty-project-template",
  "main": "node_modules/expo/AppEntry.js",
  "private": true,
  "scripts": {
    "start": "expo start",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "eject": "expo eject"
  },
  "dependencies": {
    "@firebase/app": "^0.3.4",
    "babel": "^6.23.0",
    "babel-plugin-module-resolver": "^3.1.1",
    "babel-preset-env": "^1.7.0",
    "babel-preset-expo": "^5.0.0",
    "eslint": "^5.8.0",
    "expo": "^31.0.0",
    "expo-cli": "^2.2.5",
    "firebase": "^5.5.7",
    "for": "^0.1.0",
    "lodash": "^4.17.11",
    "me": "^0.3.0",
    "moment": "^2.22.2",
    "react": "^16.6.0",
    "react-native": "^0.57.4",
    "react-native-blur": "^3.2.2",
    "react-native-elements": "^0.19.1",
    "react-native-keyboard-aware-scrollview": "^2.0.0",
    "react-native-material-textfield": "^0.12.0",
    "react-native-platform-touchable": "^1.1.1",
    "react-native-scrollable-tab-view": "^0.9.0",
    "react-native-snap-carousel": "^3.7.5",
    "react-native-swiper": "^1.5.13",
    "react-native-tab-view": "^1.2.0",
    "react-native-vector-icons": "^6.0.2",
    "react-navigation": "^2.18.2",
    "react-redux": "^5.1.0",
    "redux-persist": "^5.10.0",
    "redux-thunk": "^2.3.0",
    "windows": "0.0.8",
    "worked": "^0.0.2",
    "ws": "^6.1.0"
  },
  "devDependencies": {
    "@babel/cli": "^7.1.2",
    "@babel/core": "^7.1.2",
    "@babel/preset-env": "^7.1.0",
    "babel-core": "^7.0.0-bridge.0",
    "babel-plugin-transform-object-rest-spread": "^6.26.0",
    "babel-preset-react": "^6.24.1",
    "redux": "^4.0.1",
    "remote-redux-devtools": "^0.5.13"
  },
  "resolutions": {
    "babel-core": "7.0.0-bridge.0"
  }
}

My use cases for font family are similar to the following:
export default StyleSheet.create({
    container: {
      borderRadius: 4,
      borderWidth: 0.5,
      borderColor: '#d6d7da',
    },
    title: {
      textAlign: 'center',
      fontSize: 30,
      marginBottom: 0,
      fontFamily: 'mainFontBold',
    }

where mainFontBold is a custom font loaded in my app.js. This has been working fine before today, and I'm not sure what could have happened to cause this change.
I can't figure out why it would be giving me this error? The expo docs clearly state that fontFamily is a valid style attribute for text, see:
https://facebook.github.io/react-native/docs/text-style-props#fontfamily
Does anyone have any idea how I might be able to fix this, or what might be causing this error?
Thanks!

Maybe full-text search for styles.title , to see if you are applying that style to a non-Text component somewhere?

Hey @Jmask ,
Can you fix the problem??

The problem was related to React native versioning. I changed my version in package.json from
    "react-native": "^0.57.4",

to
    "react-native": "https://github.com/expo/react-native/archive/sdk-31.0.1.tar.gz",

and the problem resolved itself!

Encountering the same issue with this printing out to the Terminal
fontFamily is not a valid style attribute
- node_modules/react-native/Libraries/StyleSheet/StyleSheet.js:347:23 in setStyleAttributePreprocessor
- ... 22 more stack frames from framework internals

Package.json here:
{
  "name": "cirv",
  "version": "0.1.0",
  "private": true,
  "devDependencies": {
    "jest-expo": "~27.0.0",
    "react-native-material-ui": "^1.30.1",
    "react-native-scripts": "^1.14.0",
    "react-test-renderer": "16.6.0-alpha.8af6728",
    "reactotron-react-native": "^2.0.0"
  },
  "main": "./node_modules/react-native-scripts/build/bin/crna-entry.js",
  "scripts": {
    "start": "react-native-scripts start",
    "eject": "react-native-scripts eject",
    "android": "react-native-scripts android",
    "ios": "react-native-scripts ios",
    "test": "jest"
  },
  "jest": {
    "preset": "jest-expo"
  },
  "dependencies": {
    "@expo/vector-icons": "^6.3.1",
    "expo": "^31.0.0",
    "native-base": "^2.8.1",
    "npm": "^6.4.1",
    "react": "16.6.0-alpha.8af6728",
    "react-dom": "^16.6.1",
    "react-native": "https://github.com/expo/react-native/archive/sdk-31.0.1.tar.gz",
    "react-native-button": "^2.3.0",
    "react-native-datepicker": "^1.7.2",
    "react-native-elements": "^0.19.1",
    "react-native-fetch-blob": "^0.10.8",
    "react-native-gesture-handler": "^1.0.9",
    "react-native-gifted-chat": "^0.4.3",
    "react-native-google-places": "^2.5.2",
    "react-native-image-picker": "^0.27.1",
    "react-native-map-link": "^2.0.5",
    "react-native-maps": "^0.22.1",
    "react-native-material-design": "^0.3.7",
    "react-native-material-ui": "^1.30.1",
    "react-native-modal": "^6.4.0",
    "react-native-snap-carousel": "^3.7.2",
    "react-native-vector-icons": "^4.6.0",
    "react-native-web": "^0.9.6",
    "react-navigation": "^2.0.4",
    "react-redux": "^5.0.7",
    "redux": "^4.0.0",
    "uglify-es": "^3.2.2",
    "watchman": "^1.0.0"
  },
  "resolutions": {
    "uglify-es": "3.2.2"
  }
}

My only idea here would be your dependency of
    "react": "16.6.0-alpha.8af6728",

Try using
    "react": "16.5.0",

instead

I have the same issue and I updated to :
"react": "16.5.0",
 "react-native": "^0.57.4",

This is happending to me with Expo only.
My package.json relevant dependencies are:
"expo": "^31.0.5",
"react": "^16.6.3",
"react-native": "https://github.com/expo/react-native/archive/sdk-31.0.1.tar.gz",
"schedule": "^0.4.0",

Expo's version of React Native is currently using schedule v0.4.0. The code reads require('schedule/tracking'), while the version installed by the version of React I'm using is scheduler v0.11.2 and the code to require the same module would be require('scheduler/tracing'). Notice that schedule and scheduler are not exactly the same. They are wo different NPM packages.


Timestamps inconsistent in token list page

Originally reported by @blakestier
Overview
On the API Tokens page, the created_at timestamp shows time on a 24-hour clock but also shows am/pm. For example: 18:11pm.

fixed in #1751


CmdGen breaks with Python v3.9

A typical example:
rpi4$ ck run cmdgen:benchmark.image-classification.tflite-loadgen \
--model=resnet50 --mode=performance --scenario=singlestream \
--library=armnn-v21.11-neon --sut=rpi4 --target_latency=300
<...>
CK error: problem converting text to json (__init__() got an unexpected keyword argument 'encoding')!

rpi4$ python3 --version
Python 3.9.7

This is one of the reasons we are still using Python v3.7 and v3.8 with CK-QAIC.
See similar problems elsewhere e.g. https://github.com/Tribler/tribler/issues/5744.

The minimal example that still works in python3.8 and fails in python3.9 seems to be:
ck version "@@@{'meta':{}}"

Hmm. I didn't use Python 3.9 with CK yet. Need to check.
@ens-lg4 - I didn't see your message on Slack. Did you use #ck channel in the MLCommons slack? All other Slack channels are deprecated since last summer.
Also, I suggest to open a ticket on https://github.com/mlcommons/ck/issues because I use/check it more often ...
Thanks!

@gfursin No problem, please see https://github.com/mlcommons/ck/issues/184

Cool! THank you @ens-lg4 . Let me check it ...

Did you use #ck channel in the MLCommons slack? All other Slack channels are deprecated since last summer.

In fact, MLCommons no longer use Slack either, having switched to using Discord:

MLCommons uses Discord for group collaboration and communication.
The invite code for our Discord server is https://discord.gg/emD2ge5EjG and the server name is “MLCommons”.

I believe this issue should be fixed in V2.6.1.
@psyhtest - I sometimes go to MLCommons at Discord but we still use Slack for most of our projects so there are more chances that I will spot new messages on Slack than on Discord ;) ...

@gfursin Same here. since MLCommons just ban using Slack, should be go back to the good old collective-knowledge.slack.com?


Support option implications

I have a CLI option that implies another option, so in my Runnable::run I start with
if (foo) {
  bar = true;
}

This seems a bit out of place here. I'd like picocli to support the following instead:
class Options {
  @Option(name="--foo", implies="--bar")
  private boolean foo = false;
  @Option(name="--bar")
  private boolean bar = false;
}

Expected semantic: if Options.foo == true then Options.bar == true as well.

I'm not convinced this should be added to the library; as your example code demonstrates, the application can easily accomplish this with the current version of picocli.
What picocli will offer from version 4.0 is argument groups, that can be used to define mutually exclusive options and mutually dependent options. This allows you to create commands where the --bar option becomes required if the --foo option was specified. The relationship between such options is visually shown in the synopsis of the usage help message:
# mutually exclusive
mycommand (--foo | --bar)

# mutually dependent
mycommand (--foo --bar)

And additionally groups can be shown together in the option list in the usage help message with a dedicated heading.
I know this is not what you are asking for, but this is to illustrate the kind of features I am focusing on adding to the library: features that are less easy to provide for with custom application code.

Closing this ticket. Feel free to reopen if you want to discuss further and don't hesitate to create other tickets.


[Enhancement] (nereids)implement showStoragePolicyCommand in nereids

showStoragePolicy command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following showStoragePolicy command in nereids:
unsupportedshowStoragePolicyStatement
SHOW STORAGE POLICY (USING (FOR policy=identifierOrText)?)?

@starocean999 @LiBinfeng-01 @morrySnow Please assign this issue to me


Fixes issue with page icons #196

Fixes #196
I have re-designed the UI of the page icons at the base of the circuitverse website.

These are the screenshots of the final output,if my code is merged with the main CSS file.
And here is the code.
page.txt

Lots of changes in files and conflicts. You might want to rebase/merge your branch with our master.

Sorry Sir,I cannot get what you are telling.I just re-designed the icons as
in a separate stylesheet.I did not make any change to the cloned version of
the master code.
On Sat, 23 Mar 2019, 14:59 Satvik Ramaprasad<EMAIL_ADDRESS>wrote:

Lots of changes in files and conflicts. You might want to rebase/merge
your branch with our master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CircuitVerse/CircuitVerse/pull/293#issuecomment-475854961,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ap5hpPfPB4bL519_ZrMnpUNmaKOGrZDmks5vZfQUgaJpZM4cDKff
.

Sorry Sir,I cannot get what you are telling.I just re-designed the icons as in a separate stylesheet.I did not make any change to the cloned version of the master code.
…
On Sat, 23 Mar 2019, 14:59 Satvik Ramaprasad, @.***> wrote: Lots of changes in files and conflicts. You might want to rebase/merge your branch with our master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#293 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/Ap5hpPfPB4bL519_ZrMnpUNmaKOGrZDmks5vZfQUgaJpZM4cDKff .

You might want to read on how to rebase your git repository. For now since you have used a separate stylesheet, maybe you can just backup your work and send another PR from scratch.


start ipfs daemon for go-test workflow

This PR contains all the changes that are necessary for https://github.com/ipfs-shipyard/git-remote-ipld/pull/35 to be mergeable.
This PR:

sets up ipfs daemon in go-test-setup action
cherry-picks https://github.com/ipfs-shipyard/git-remote-ipld/pull/38
restores file closing changes and Badger upgrade done by @aschmahmann
excludes ipld_test from execution on win32 runners

Testing

[x] go-test -> https://github.com/galargh/git-remote-ipld/actions/runs/1578454834
[x] go-check -> https://github.com/galargh/git-remote-ipld/actions/runs/1578454831

Codecov Report

:exclamation: No coverage uploaded for pull request base (web3-bot/sync@df2b232). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             web3-bot/sync      #39   +/-   ##
================================================
  Coverage                 ?   39.20%
================================================
  Files                    ?        9
  Lines                    ?      977
  Branches                 ?        0
================================================
  Hits                     ?      383
  Misses                   ?      511
  Partials                 ?       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2b232...d4c9337. Read the comment docs.

I moved the changes introduced in this PR to https://github.com/ipfs-shipyard/git-remote-ipld/pull/41 and I intend to merge it to the Unified CI sync PR.
The win32 tests are disabled - the reason for it is included as a code comment.


refactor(date): improve type hints

introduce types for internal date tables
introduce some helper to encapsulate interaction with os api

@kristijanhusak As promised here the cleaned up type hints in Date.
The failing test is unrelated, but when I had a look at it, it seems to be a flaky candidate. I don't think it can be made 100% deterministic, but at least if we cache the current time right after the command (before vim.wait we can reduce the probability to fail:
https://github.com/nvim-orgmode/orgmode/blob/ac9a6e0eac2d298a27ab4f59511e60897cb61a08/tests/plenary/ui/mappings/todo_spec.lua#L343-L357


[SPARK-5601][MLLIB] make streaming linear algorithms Java-friendly

Overload trainOn, predictOn, and predictOnValues.
CC @freeman-lab

Test build #26922 has started for   PR 4432 at commit 1f662b3.

This patch merges cleanly.

Test build #26922 has finished for   PR 4432 at commit 1f662b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26922/
Test PASSed.

Looks good, but not too familiar with this class

Test build #26943 has started for   PR 4432 at commit 2d7b357.

This patch merges cleanly.

@mengxr nice patch! I left two pretty minor comments about expanding the tests, otherwise looking good.

Test build #26955 has started for   PR 4432 at commit 6a79b85.

This patch merges cleanly.

Test build #26943 has finished for   PR 4432 at commit 2d7b357.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26943/
Test PASSed.

Test build #26955 has finished for   PR 4432 at commit 6a79b85.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26955/
Test PASSed.

Merged into master and branch-1.3.


Admin Console displays failure to sign in to Azure error

Under this: https://docs.microsoft.com/en-us/sccm/core/plan-design/security/enable-tls-1-2
Admin Console displays failure to sign in to Azure

If the Azure Services onboarding dialog box immediately fails after you click “Sign in” when you try to create Azure AD applications, verify that .NET Framework is updated and that strong cryptography is enabled. A restart is required for these changes to take effect.

Can we add this, for better discoverability of the related issue:
The SMSAdminui.log may contain an error similar to the following:
Microsoft.ConfigurationManager.CloudBase.AAD.AADAuthenticationException
Service returned error. Check InnerException for more details
at Microsoft.ConfigurationManager.CloudBase.AAD.AADAuthenticationContext.GetAADAuthResultObject(String clientID, Uri redirectUri, String authority, PromptBehavior promptBehavior)
at Microsoft.ConfigurationManagement.AdminConsole.CloudServicesManagement.AAD.AADDataHandler.GetAuthResultObject()
at Microsoft.ConfigurationManagement.AdminConsole.CloudServicesManagement.AAD.AADDataHandler..ctor(ConnectionManagerBase connectionManager, AzureEnvironment azureEnvironment, IAzureEnvironmentInformation environmentInformation, CloudServiceAssociatedAADData selectedCloudApp, String appName, String identifierUrl, String homepageUrl, String replyUrl, SecretKeyExpiryPeriod expiryPeriod)
at Microsoft.ConfigurationManagement.AdminConsole.CloudServicesManagement.Dialogs.AADAppDetailsDialog.SignIn_OnClick(Object sender, EventArgs e)
Microsoft.IdentityModel.Clients.ActiveDirectory.AdalServiceException
Service returned error. Check InnerException for more details
at Microsoft.IdentityModel.Clients.ActiveDirectory.AuthenticationContext.RunAsyncTask[T](Task`1 task)
at Microsoft.ConfigurationManager.CloudBase.AAD.AADAuthenticationContext.GetAADAuthResultObject(String clientID, Uri redirectUri, String authority, PromptBehavior promptBehavior)
System.Net.WebException
The underlying connection was closed: An unexpected error occurred on a receive.
at System.Net.HttpWebRequest.GetResponse()
at Microsoft.IdentityModel.Clients.ActiveDirectory.HttpWebRequestWrapper.d__2.MoveNext()
In the System EventLog, SChannel EventID 36874 may be logged with the following description: An TLS 1.2 connection request was received from a remote client application, but none of the cipher suites supported by the client application are supported by the server. The TLS connection request has failed.

Thanks @MSFTJerryAb for the suggestion! I just added it, which is why the issue is now closed. But note it won't see the light of day until Monday's daily publishing (3 June) around 11am Pacific time.


Semver & compatibility matrix

Is it fair to say the project is following semver? In regards to the various sdks/agents is a compatibility matrix needed?

@benquinteros yes, you are right
using the same major version guaranties full compatibility
difference in minor version could be some features added/modified
patch version is about hot fixes
I'll make a WIKI page on this matter

Page with basic information is created, let me know if you think is not enough
release notes for SDK versions is not always updated so we gonna automate this process #111
https://github.com/Visual-Regression-Tracker/Visual-Regression-Tracker/wiki/How-to-choose-right-SDK---agent-version


WIP Fix 641

Add stack to all error reporting methods that could be found using this command:

find . -name "*.go" -exec sed -i -e 's/return\(.*\) err$/return\1 errors.WithStack(err)/g' {} \;

This basically replaces:

return err with return errors.WithStack(err),
return nil, err with return nil, errors.WithStack(err),
and so forth.

Added github.com/pkg/errors to glide and imported it in Go as errs (most of the time) in order to avoid confusion.
Use github.com/pkg/errors.New() instead of standard errors.New() wherever possible
Use errors.Errorf() instead of fmt.Errorf() wherever possible
Use errors.Cause(err) in tests that check for a particular error type to get the github.com/almighty/almighty-core/errors errors

Error type switch based oncause := errors.Cause(err)
switch cause.(type) {
// ...
}

TODO
Decide on a strategy to enrich return values like these in order to provide good stack traces for errors that bubble up:
return errors.NewInternalError("blabla")
return errors.NewNotFoundError("work item ID", wiIDStr)

Do we want to wrap those calls like so?
return errs.WithStack(errors.NewInternalError("blabla"))
return errs.WithStack(errors.NewNotFoundError("work item ID", wiIDStr))

Or do we want to reduce the verbosity and have errors.NewInternalError and the other error constructors do that for us? IMHO I would like to change the constructors anyway so that we can pass along any existing error to them.
See #641

Current coverage is 69.39% (diff: 30.34%)

Merging #642 into master will decrease coverage by 0.50%

@@             master       #642   diff @@
==========================================
  Files            74         74
  Lines          4263       4274    +11
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           2980       2966    -14
- Misses          999       1017    +18
- Partials        284        291     +7

Powered by Codecov. Last update 3089db4...5edccb7

[test]

[test]