Add status controller to Galley.

Add a new controller to the kube source that can read & update status fields.
Wire-up the analyzers to the snapshot generation, so that Galley can analyze snapshots.
Wire-up the controller so that the analysis results can be reflected as CRD status fields.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-security-k8s-tests

integ-mixer-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-security-k8s-tests

integ-mixer-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-mixer-k8s-tests

integ-framework-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-framework-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-security-k8s-tests

integ-mixer-k8s-tests_istio
556974566e7087984263c7520fc1e846574b6843
link
/test integ-mixer-k8s-tests

e2e-simpleTestsMinProfile_istio
556974566e7087984263c7520fc1e846574b6843
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7ca139d6655ae7cd480a2942f7fc620d426ccc1e
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7ca139d6655ae7cd480a2942f7fc620d426ccc1e
link
/test integ-security-k8s-tests

integ-pilot-k8s-tests_istio
7ca139d6655ae7cd480a2942f7fc620d426ccc1e
link
/test integ-pilot-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
f8f5a76a7b7efa4ddaaf2ab269ba11cc149b5114
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
f8f5a76a7b7efa4ddaaf2ab269ba11cc149b5114
link
/test lintmodern

lint_istio
f8f5a76a7b7efa4ddaaf2ab269ba11cc149b5114
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
f8f5a76a7b7efa4ddaaf2ab269ba11cc149b5114
link
/test lintmodern

lint_istio
f8f5a76a7b7efa4ddaaf2ab269ba11cc149b5114
link
/test lint

integ-mixer-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

e2e-simpleTests-distroless_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test e2e-simpleTests-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

e2e-simpleTests-distroless_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test e2e-simpleTests-distroless

e2e-simpleTestsMinProfile_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7e2ab72803df2c2268e6ece8819d05dd4acea1ff
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

integ-pilot-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-pilot-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

integ-pilot-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-pilot-k8s-tests

integ-new-install-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

integ-pilot-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-pilot-k8s-tests

integ-new-install-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-new-install-k8s-tests

e2e-simpleTestsMinProfile_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

integ-pilot-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-pilot-k8s-tests

integ-new-install-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-new-install-k8s-tests

e2e-simpleTestsMinProfile_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test e2e-simpleTestsMinProfile

e2e-simpleTests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

racetest_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-mixer-k8s-tests

integ-security-k8s-tests_istio
bc7fba1dfcb84801394bb0a00a8a8d9d7637599d
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


feat: resolve JSONSchema refs (planners)

Description
This PR adds compatibility to the JSONSchema notation $defs and $refs which allow to re-use objects across a schema.
This allows projects like  https://github.com/stillmatic/gollum or https://github.com/jxnl/openai_function_call compatible.
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

far from perfect, but good for a first round of implementation


Bio.SeqIO issue in biopython 1.77

Just installed and ran through the RNA-seq pipeline, encountered this error:
[2020-06-25T14:16Z] Converting /bcbio/genomes/Hsapiens/hg38/rnaseq/ref-transcripts.gtf to FASTA format.
Traceback (most recent call last):
  File "/bcbio/tools/bin/bcbio_nextgen.py", line 245, in <module>
    main(**kwargs)
  File "/bcbio/tools/bin/bcbio_nextgen.py", line 46, in main
    run_main(**kwargs)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 50, in run_main
    fc_dir, run_info_yaml)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 91, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 254, in rnaseqpipeline
    samples = rnaseq.quantitate_expression_parallel(samples, run_parallel)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/pipeline/rnaseq.py", line 226, in quantitate_expression_parallel
    run_parallel("run_salmon_index", [to_index])
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"], batch_size=1, backend="multiprocessing")(joblib.delayed(fn)(*x) for x in items):
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 1029, in __call__
    if self.dispatch_one_batch(iterator):
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 847, in dispatch_one_batch
    self._dispatch(tasks)
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 765, in _dispatch
    job = self._backend.apply_async(batch, callback=cb)
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 206, in apply_async
    result = ImmediateResult(func)
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 570, in __init__
    self.results = batch()
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 253, in __call__
    for func, args, kwargs in self.items]
  File "/bcbio/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 253, in <listcomp>
    for func, args, kwargs in self.items]
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/utils.py", line 55, in wrapper
    return f(*args, **kwargs)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/distributed/multitasks.py", line 76, in run_salmon_index
    return salmon.run_salmon_index(*args)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/rnaseq/salmon.py", line 149, in run_salmon_index
    salmon_index(gtf_file, data, salmon_dir)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/rnaseq/salmon.py", line 169, in salmon_index
    kmersize = sailfish.pick_kmersize(files[0])
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/rnaseq/sailfish.py", line 199, in pick_kmersize
    readlength = fastq.estimate_read_length(fq)
  File "/bcbio/anaconda/lib/python3.6/site-packages/bcbio/bam/fastq.py", line 293, in estimate_read_length
    in_handle.close()
AttributeError: 'FastqPhredIterator' object has no attribute 'close'

i opened up /bcbio/anaconda/lib/python3.6/site-packages/bcbio/bam/fastq.py, saw this:
def estimate_read_length(fastq_file, quality_format="fastq-sanger", nreads=1000):
    """
    estimate average read length of a fastq file
    """

    in_handle = SeqIO.parse(open_fastq(fastq_file), quality_format)
    read = next(in_handle)
    average = len(read.seq)
    for _ in range(nreads):
        try:
            average = (average + len(next(in_handle).seq)) / 2
        except StopIteration:
            break
    in_handle.close()
    return average

and simply commented out the close operation like this:
def estimate_read_length(fastq_file, quality_format="fastq-sanger", nreads=1000):
    """
    estimate average read length of a fastq file
    """

    in_handle = SeqIO.parse(open_fastq(fastq_file), quality_format)
    read = next(in_handle)
    average = len(read.seq)
    for _ in range(nreads):
        try:
            average = (average + len(next(in_handle).seq)) / 2
        except StopIteration:
            break
#    in_handle.close()
    return average

and things worked fine after that :  )
maybe FastqPhredIterator no longer has a close method associated with it?

Hi @choosehappy !
Thanks for reporting!
This function works for me, and in_handle has close() attribute.
What is your biopython version?
conda list | grep biopython
biopython                 1.76             py36h516909a_0    conda-forge

you may also try if it works in (bcbio) python for you:
>>> from Bio import SeqIO
>>> from bcbio.bam.fastq import open_fastq
>>> in_handle = SeqIO.parse(open_fastq("test_1.fq.gz"), "fastq-sanger")
>>> read = next(in_handle)
>>> in_handle.close()

Sergey

root@0fe8d464e16e:/# /bcbio/anaconda/bin/conda list | grep biopython
biopython                 1.77             py36h8c4c3a4_0    conda-forge

error exists directly in python:

Same issue here with a new install. Downgrading biopython to 1.76 removed the error message:
/usr/local/share/bcbio-nextgen/anaconda/bin/conda install -c conda-forge -c bioconda biopython=1.76

@choosehappy Are you able to finish your rnaseq analysis? I assume that you made a recent installation. I end up with errors like this:
[2020-06-27T13:46Z] Loading tximport.
[2020-06-27T13:46Z] Error in library(tidyverse) : there is no package called \u2018tidyverse\u2019
[2020-06-27T13:46Z] Execution halted
[2020-06-27T13:46Z] Uncaught exception occurred
Traceback (most recent call last):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command '/usr/local/share/bcbio-nextgen/anaconda/bin/Rscript --vanilla -e library(tidyverse);salmon_files = list.files("/bioinf-data/bcbio/work/salmon", pattern="quant.sf", recursive=TRUE, full.names=TRUE);tx2gene = readr::read_csv("/bioinf-data/bcbio/work/inputs/transcriptome/tx2gene.csv", col_names=c("transcript", "gene")); samples = basename(dirname(salmon_files));names(salmon_files) = samples;txi = tximport::tximport(salmon_files, type="salmon", tx2gene=tx2gene, countsFromAbundance="lengthScaledTPM");readr::write_csv(txi$counts %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/bioinf-data/bcbio/work/bcbiotx/tmpbgyu1qro/tximport-counts.csv");readr::write_csv(txi$abundance %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/bioinf-data/bcbio/work/bcbiotx/tmp4qr6l5zr/tximport-tpm.csv");
Error in library(tidyverse) : there is no package called \u2018tidyverse\u2019
Execution halted
' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/usr/local/bin/bcbio_nextgen.py", line 245, in <module>
    main(**kwargs)
  File "/usr/local/bin/bcbio_nextgen.py", line 46, in main
    run_main(**kwargs)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 50, in run_main
    fc_dir, run_info_yaml)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 91, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/pipeline/main.py", line 261, in rnaseqpipeline
    samples = rnaseq.combine_files(samples)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/pipeline/rnaseq.py", line 482, in combine_files
    tximport = load_tximport(data)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/pipeline/rnaseq.py", line 549, in load_tximport
    do.run([rcmd, "--vanilla", "-e", render_string], f"Loading tximport.")
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 26, in run
    _do_run(cmd, checks, log_stdout, env=env)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python3.6/site-packages/bcbio/provenance/do.py", line 106, in _do_run
    raise subprocess.CalledProcessError(exitcode, error_msg)
subprocess.CalledProcessError: Command '/usr/local/share/bcbio-nextgen/anaconda/bin/Rscript --vanilla -e library(tidyverse);salmon_files = list.files("/bioinf-data/bcbio/work/salmon", pattern="quant.sf", recursive=TRUE, full.names=TRUE);tx2gene = readr::read_csv("/bioinf-data/bcbio/work/inputs/transcriptome/tx2gene.csv", col_names=c("transcript", "gene")); samples = basename(dirname(salmon_files));names(salmon_files) = samples;txi = tximport::tximport(salmon_files, type="salmon", tx2gene=tx2gene, countsFromAbundance="lengthScaledTPM");readr::write_csv(txi$counts %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/bioinf-data/bcbio/work/bcbiotx/tmpbgyu1qro/tximport-counts.csv");readr::write_csv(txi$abundance %>% as.data.frame() %>% tibble::rownames_to_column("gene"), "/bioinf-data/bcbio/work/bcbiotx/tmp4qr6l5zr/tximport-tpm.csv");
Error in library(tidyverse) : there is no package called \u2018tidyverse\u2019
Execution halted
' returned non-zero exit status 1.

yes,brand new install
and yes mine finished with no additional issues after correcting this small issue and this one:
https://github.com/bcbio/bcbio-nextgen/issues/3278
the latter one clearly indicates that tidyverse was successfully installed, not sure why you would be in that situation

Thanks @gabeng and @choosehappy for digging into the issue!
I think for now we'd pin biopython=1.76 and follow the comments in biopython.
S

Hi again @gabeng  and @choosehappy !
I've fixed the handle in bcbio/bam/fastq and reverted the biopython pinning.
Please let me know if that fixed the issue for you.
Sergey

The fix makes sense - I still don't understand how the old code might have worked on older Biopython 🤷

Thanks @chris-rands for the explanation: https://github.com/biopython/biopython/issues/3015#issuecomment-651356739
I'd missed the fact the using a generator functions means you automatically have a .close() method: https://docs.python.org/3/reference/expressions.html#generator.close


Make Scan button at BottomNavigationView open XZingScannerScan directly

I overridden the BottomNavigationView's way of changing fragments. It should now open the scanner class directly now.

merge into dev instead

.conflicts


[suggestion] Store datasets and models in a data archive

It would be great if you could store generated models and datasets that you collected in an archive like Zenodo. Zenodo would give the dataset (which requires a bit of metadata) a DOI for easier citation and it provides stronger long-term promises than Google Drive or Dropbox. (IMHO providing Google Drive links for important data looks phishy, although I know many other projects do the same.)
Thanks for your consideration!

Hi @bencomp, thanks for the great suggestion, I will definitely try to do it when I have some free time (likely beginning of March)


Alexander kotlyar upgrade to htmlunit 2.27

fixed merge conflicts in PR #585

Coverage increased (+0.1%) to 64.64% when pulling ae9d317773c9490c13010d89465501aca8298dd1 on alexander-kotlyar-upgrade-to-htmlunit-2.27 into d4ba1d2ea73f42991030c6fba37c18c6b8fc6c3c on master.

Codecov Report

Merging #609 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #609      +/-   ##
============================================
+ Coverage     60.85%   61.04%   +0.18%
- Complexity      758      760       +2
============================================
  Files           147      147
  Lines          2698     2698
  Branches        257      257
============================================
+ Hits           1642     1647       +5
+ Misses          958      954       -4
+ Partials         98       97       -1

Impacted Files
Coverage Δ
Complexity Δ

...e/selenide/impl/WebDriverThreadLocalContainer.java
80% <0%> (+3.44%)
31% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ba1d2...ae9d317. Read the comment docs.


WinUI for Desktop

This issue has been moved from a ticket on Developer Community.

[regression] [worked-in:16.7.0 Preview 2]
Using Visual Studio 2019 16.7.0 Preview 2
using Windows 10 pro 2004 19041.329
I did try to convert UWP app's to WinUI UwP this work for app not using MapControl or WebView2
I did try the same for WINUI for Desktop
When i create an app WinUI for Desktop nothing change and compile is ok.
But then by run it crash (error as Attachment)
I mean the app should open the MainWindow and showing the button isn'i it ?
What is wrong ?

Original Comments
Visual Studio Feedback System on 6/24/2020, 02:06 AM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions
(no solutions)

I don't see any attachments. Can you please provide more details or provide a repro app. This issue is not actionable without more information.

The error is attached.
Thanks

Looks like a dup of this issue
https://github.com/microsoft/microsoft-ui-xaml/issues/2679


update: add FP cleanup for the generated client VIs

[x] This contribution adheres to CONTRIBUTING.md. (Required)
[ ]  Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Implemented logic to programmatically cleanup the Front Panel of the generated client VIs.

Why should this Pull Request be merged?

To clean up the FP of the client VIs generated by the Measurement Plug-In Client Generator.

What testing has been done?

Manually tested by generating client and verified the FP cleanup

Update Control from Metadata.vi
Diff image:
Before:

After:

Update Measurement from Metadata.vi
Diff image:
Before:

After:


ios: Add workaround for package:firebase_messaging when building with Xcode 16

Without this workaround iOS build currently fails with the following error:
Lexical or Preprocessor Issue (Xcode): Include of non-modular header inside framework module 'firebase_messaging FLTFirebaseMessagingPlugin':
'/Users/rajveer/Projects/zulip-flutter/ios/Pods/Headers/Public/Firebase/Firebase.h'
/Users/rajveer/.pub-cache/hosted/pub.dev/firebase_messaging-15.0.4/ios/Classes/FLTFirebaseMessagingPlugin.h:11:8

Upstream issue and the workaround comment:
https://github.com/firebase/flutterfire/issues/13323
https://github.com/firebase/flutterfire/issues/13323#issuecomment-2355013360
Docs: https://developer.apple.com/documentation/xcode/build-settings-reference#Allow-Non-modular-Includes-In-Framework-Modules
The documentation states that enabling this setting may result in issues later on, which is why this workaround should only be temporary until firebase_messaging is patched with the correct fix.

Chat thread:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Can't.20compile.20for.20iOS.20on.20macOS.2015.2E0.20.28latest.29.20and.20Xcode.2016.2E0/near/1944045

LGTM, and I've tested on Xcode Version 15.4 (15F31d) and it works there too.
An alternative that should also work, and worked in my testing, is to add a line
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES

in ios/Flutter/Debug.xcconfig and ios/Flutter/Release.xcconfig, and leave project.pbxproj untouched. This might be nicer, because the project.pbxproj is hard to read, and there's a lot in there. Putting this setting in an uncrowded file, with a helpful comment saying it's a temporary workaround for a specific issue, seems helpful.
The Xcode GUI lets you see how the final value for this setting is resolved.
Here's with the PR as-is, with the additions in project.pbxproj:

And with my proposal:

In my proposal, the prevailing "YES" value comes from the config-file column, instead of the target ("Runner") column.
I wasn't sure which of Debug.xcconfig and Release.xcconfig would control the "Profile" configuration, or if neither of them would, and I found experimentally that it's Release.xcconfig. I'm not finding the place in the Xcode GUI that tells me that, but this looks like the spot in project.pbxproj:
		249021D4217E4FDB00AE95B9 /* Profile */ = {
			isa = XCBuildConfiguration;
			baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */;

ios/Flutter/Debug.xcconfig and ios/Flutter/Release.xcconfig, and leave project.pbxproj untouched.

Neat, I like that option. @rajveermalviya would you try that and confirm that it works for you?
It looks like those files also accept comments, with //. (See Generated.xcconfig in the same directory for an example.) That'd be good for mentioning that it's a workaround which should be temporary, and linking to the chat thread and that upstream issue https://github.com/firebase/flutterfire/issues/13323 .

Thanks for the reviews @chrisbobbe and @gnprice!
Yes, adding the flag to ios/Flutter/{Debug.xcconfig, Release.xcconfig} does result in a successfull build as well.
I've pushed a new revision which does that via Zulip.xcconfig (new file) and #include-ing that in both Debug.xcconfig and Release.xcconfig.

Thanks for the review @PIG208, pushed a new revision.
Additionally, added references for Zulip.xcconfig so that it becomes visible in XCode (without them it's not).

Thanks for the review @gnprice! Pushed a new revision, PTAL.

Thanks! Looks good — merging.


UN SDG ingest

I've added json files which describe the units and dimensions available in the dataset. These often change so ideally should be kept as snapshots.
Incidentally the data has been updated since I started moving the import over. Is it possible to remove the 2022-05-26 index and work from 2022-07-07 instead?

Incidentally the data has been updated since I started moving the import over. Is it possible to remove the 2022-05-26 index and work from 2022-07-07 instead?

Sure, just remove it from owid/walden/index/un_sdg/... and commit here. I can delete the file from S3 if you don't have access yet.

Sure, just remove it from owid/walden/index/un_sdg/... and commit here. I can delete the file from S3 if you don't have access yet.

Ah okay - have removed it from owid/walden/index/un_sdg/...  but don't think I have access to S3 yet

but don't think I have access to S3 yet

We'll have to wait for Lars. Removed those files myself for now. (It has been approved, so merge whenever you feel like it)


docs: fix branches keyword in MR approval rules

It ain't much but it's honest work.

Thank you very much for this update.


Initial Draft Disclaimer

The current version of the AI-Lab website has a one-sentence disclaimer stating that it is not an official CFIA website. To make this more prominent and ensure that visitors clearly understand the site's unofficial status, replace the one-sentence disclaimer with a popup that appears when a user first lands on the site.

We can't miss this one


Add lib unit tests

This PR adds unit tests to the lib package. Beside that I added a config interface and fixed up some possible nil pointer dereferences I found during the test creation.

/ok-to-test

Mocking of the runtimeImpl is not possible any more on the latest master since the interface made private. @sboeuf I know this change was intended and from the current perspective it totally makes sense. Unfortunately only public interfaces can be mocked in go. How do we want to proceed here?

@saschagrunert oh I completely missed this, I'm truly sorry. I didn't realize this was used for mocking (which is a great way to test IMO), that's why I simply made it private.
Now that there's a use case for this to be public, let's move it back to public then :)
/cc @mrunalp

Sounds good to me.

On Mar 11, 2019, at 9:51 AM, Sebastien Boeuf<EMAIL_ADDRESS>wrote:
@saschagrunert oh I completely missed this, I'm truly sorry. I didn't realize this was used for mocking (which is a great way to test IMO), that's why I simply made it private.
Now that there's a use case for this to be public, let's move it back to public then :)
/cc @mrunalp
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mrunralp @sboeuf Alright, I will make it public again. thanks for the fast response! :)

Great, and sorry for the extra workload here...

/test e2e_fedora

Needs rebase @saschagrunert .
Changes LGTM

/test e2e_rhel

/lgtm

@rhatdan @mrunalp @umohnani8 needs approved label
(is it possible to add approved label if an approver does /lgtm ?)

/approve


Raise Ram DT torque limits to 350

Description [ Raise the torque limit to 350 for Ram DT. This allows us to go from 2.0m/s2 of lateral accel to 2.5m/s2 of lateral accel.]
Verification [We have been running this for over a year at these values. Anything over 350 will cause an eps fault.]

Merged the increase to panda (https://github.com/commaai/panda/pull/1284), so you can run it on your fork if you want. However, we need to improve the tuning before bumping up the limit in openpilot. Converting to draft until that happens.

adeebshihadeh

What can I do to help with tunning?

Closing until we have a new tune to go along with it.


Assembly Copyrights

Updating the copyrights and company to Microsoft Corporation.

@dotnet-bot test Windows / Release Build


Missing progressCallback on higher functions

Looking at the NEP2 implementation (nice work, thanks!) I noticed that encrypt and decrypt had progressCallbacks (which have since been removed in #17 ).
Given that they can take a while, especially on low-powered machines:
a) Why weren't they passed to higher functions for more convenient use?
b) Why have they been removed altogether?

@snowypowers I guess you might be able to answer this 😄

How it works is that you pass in the callback and the decrypt function will call it at intervals  passing in the progress. This is helpful if you were using the async version of scrypt.

The arguments were copied directly from my implementation of NEP2. Neon chose to use another version of scrypt which did not support such an arg. Furthermore, the method we are calling is the sync version and does not support callbacks. Thus, we remove it to clean up the code.

That makes sense. I wish it was there though 😛


Update legend to clarify the Fastest Growing Lineages in Canada different dots?

It just dawned on me that, though, the excellent Fastest Growing Lineages in Canada plot clearly states the point of the thicker line around those points reflecting lineages growing in multiple provinces in Canada, this really needs to be noted in the legend for the Canada plot for clarity. Welcome thoughts on the best way to do this, but perhaps just have two rows for each dot type indicating that the larger one is "Positive selection in multiple Provinces" and the other is "Positive selection only one province to date"? Happy to discuss!

Thick border indicates multiple provinces In the title instead of part of the plot.


Pr/process-id

Fix #7
I tried to use the new Remote Repositories feature in vscode and I couldn't really figure it out, so there is a blank commit it seems (https://github.com/microsoft/vscode-remote-repositories-github/issues/3) Also, it seems my editor made a couple minor whitespace changes.

@davidwhitney I'm just wondering if this PR is likely to ever be merged as I see it's been sitting here for a year? I've recently started using your library, which is really handy, but this bug makes it unusable for me. Thanks

@davidwhitney like @rossbp this bug is making the library unusable for me also.  Any idea as to whether or not it shall be merged?

Holy necromancy Batman!
This PR long lost in my infinite GitHub notifications was just brought to my attention by email - I'll try shave the yaks and get this merged and out if it's still useful to anyone.


Hover / goto def do not work for symbols from external packages

... as documented by the tests titled type constructor from other package, value from other package and external class is signature.
To be precise, hover does work for external values, but not types. Note that hover and goto def do not work for internal types (#248) and internal classes (#249) either, so fixing those is likely to be required to fully resolve this.

The tests mentioned are:
https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2211-L2212
https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2220

I've just test this and goto def to external packages does not work but hover on external values/types does


adding ntp-service.vester.ps1 to test ntpd service

Simple ntp service Vest to test ntp daemon "Running" state and set to desired state if -Remediate is passed.  Ran -Remediate in both directions with success.

This file is also included in #110 😛 I'll review it there.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Coverage remained the same at 97.619% when pulling c8da0c9ecf3f7044e379da07aab6e329c958b5db on template-sync-1 into 7777a5365c2cbc3a8c292b1fcd1ede0d914ca44c on master.

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #511   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7777a53...37a0d49. Read the comment docs.


[gaia-x] update dyn_type to include some arithmetic and logical operations on Primitives and Object

What do these changes do?
As titled.
Related issue number
None issue. This is a part of Gaia-x integration.

@BingqingLyu How to fix the ci issue?

@BingqingLyu How to fix the ci issue?

It seems that the failed cases is not caused by this pr.


Moving out of the *.k8s.io API group

Kubernetes is moving to protect the *.k8s.io API group, which for reasons we have been using since the start of cert-manager.
We need a plan to migrate off of certmanager.k8s.io and onto another group name.
I'm hoping we can work out a way to do this whilst minimising pain for users, either through a managed backup/restore process, thorough instructions, or some other clever mechanism 😄
ref https://github.com/kubernetes/enhancements/pull/1111
/area api
/priority important-longterm

https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/FTDK-90gGRA

https://github.com/vmware/crd-migration-tool could be useful..

Thanks. I was going to let you know, but happy to see that you noticed.  Reach out to SIG API Machinery if you have questions.

Since you seem to own cert-manager.io, I recommend using that.

Thanks!


Update franklinkim.newrelic role to use new weareinteractive namespace role

Issue Type

Feature Idea

Your Environment
N/A
Your OS
N/A
Summary
It looks like the franklinkim.newrelic is now here: https://github.com/weareinteractive/ansible-newrelic — it is still at version 1.7.2.

Upstream issue: https://github.com/weareinteractive/ansible-newrelic/issues/22

Actually, closing this... upstream issue is tracking the namespacing oddity. It's still available at the same name.

Namespace changed now, so updating:
$ ansible-galaxy install --force weareinteractive.newrelic
- downloading role 'newrelic', owned by weareinteractive
- downloading role from https://github.com/weareinteractive/ansible-newrelic/archive/1.8.0.tar.gz
- extracting weareinteractive.newrelic to /Users/jgeerling/Dropbox/Development/GitHub/drupal-vm/provisioning/roles/weareinteractive.newrelic
- weareinteractive.newrelic (1.8.0) was installed successfully


Reverse Signed vs Unsigned detection, json2csv

Add a small script to convert the tbl2json.py JSON files to CSV tables, for easy browsing of large tables.

Also fixes the bug I introduced fixing the original signed vs unsigned bug by replicating the fix in packer.py


How do i enforce a different architecture?

I have an image that is built for both linux/arm64 and linux/amd64 - how do i enforce using it on a mac?
❯ bacalhau docker run docker.io/bacalhauproject/python-runner:2<IP_ADDRESS>5
Job successfully submitted. Job ID: j-c0bfb29e-a0d8-4875-a90a-32142a543bf6
Checking job status... (Enter Ctrl+C to exit at any time, your job will continue running):

 TIME          EXEC. ID    TOPIC            EVENT
 11:57:56.800  /           Submission       Job submitted
 11:57:56.815  e-53c4c1c1  Scheduling       Requested execution on n-ccc40057
 11:57:56.838  e-53c4c1c1  Exec Scanning    rejected bid: this node does not support the available image platforms [linux/amd64] (supports
                                            [linux/arm64])
 11:57:56.849  e-d7265374  Scheduling       Requested execution on n-5a8a7e9e
 11:57:56.867  e-d7265374  Exec Scanning    rejected bid: this node does not support the available image platforms [linux/amd64] (supports
                                            [linux/arm64])
 11:57:56.877  /           Scheduling       Error: not enough nodes to run job. requested: 1, available: 2, suitable: 0.
                                            • 2 of 2 nodes: job rejected

Error: job failed

To get more details about the run, execute:
	v1.5.0/bacalhau job describe j-c0bfb29e-a0d8-4875-a90a-32142a543bf6

To get more details about the run executions, execute:
	v1.5.0/bacalhau job executions j-c0bfb29e-a0d8-4875-a90a-32142a543bf6

This is mostly going to be addressed post v1.5.0 as most likely an existing behaviour. It worked on my arm mac, but that just means there is no deterministic behaviour on how we select the right architecture for images


Feature/#558 rating distribution

Orders the 1v1 rating distribution by score and filters out players with very few games to make it look better #558
Before:

After:

I just realised that I'm doing the filtering too early. With the filtering active in the service it affects the ("out of X Players") display too. Will fix that and add a test for it.

If you like, you can also try marking the rating bar that matches the current player's rating with a different color (e.g. yellow) and label it "You". Or you can set a label node instead that says that.

Good idea, looks like someone already tried that, there is a pseudo-class being set for the bar node with the players score, only the css part was missing.

Hi @NiklasKopp really well done, you might consider joining our slack -> https://github.com/FAForever/downlords-faf-client/wiki/Mentor-program ;)

Yeah, that someone was me :) I thought having "You" in the legend would be nice, but I realize now that's not possible. But could you try a data.setNode(new Label(...)) saying "You" and see how that looks?

@micheljung haha okay^^ Got the label to work, not as easy as I thought but it looks ok, I think.

I'm not used to rebasing, (I'd normally just merge the develop branch into mine now) so what I need to do is checkout my feature branch and go "rebase develop"?
@axel1200 thanks, I guess I'll do that as soon as I get to it :)

Im rather afraid that players who just dont play ladder are also included in that calculation. Regarding the big deviation from the normal distribution for players with 0 rating, they are more likely to distort the whole thing than the amount of accs with <10 ladder games.

I dont think that "You" label is even needed there, the different colour says it all

Inactive players aren't included, BUT I couldn't find that the server sets players inactive, so I guess that's the root cause of the high number of players with rating 0.

I set all players inactive that haven't been online for 3 months, how does it look now? :)

Please clamp displayed rating values to the [0;3000] interval as well -- values outside this range are meaningless.

There are more players with 10 games or more with -100 rating. than there are of any single bracket over 1400. So I'd say it is relevant?

No. Negative rating simply means, the player has not enough games for a "proper" rating. The high uncertainity makes the value go negative.

Ok. But then shuld this not be solved by excluding everyone that does not have enough games for a propper rating? How many games does one need?

It's not correct that values outside [0;3000] are meaningless, and assuming values like 0 and 3000 isn't correct either because these values depend on the TrueSkill parameters and number of skill classes. Negative values also don't mean that there aren't enough games, nor is it caused by high uncertainty.
Please keep it like it is.
http://www.moserware.com/assets/computing-your-skill/The Math Behind TrueSkill.pdf

Looks like this now:

So excluding inactive players didn't really change a lot.

Idea from me again. Is there a variable(if not maybe one can be calculated?) that the server keeps how "accurate" the rating is based on the table provided from @micheljung. Maybe sort on that then instead of an arbitrary number of games played?
And its starting to look a bit thin, maybe have a toggle to show only active, or all?
Sorry for just throwing out ideas but no real solutions :) I must say it is looking really good

These high amount of 0 rated players are players who havent played a single ladder game, and have 0 rating because of that.
are players set as inactive who havent played a ladder game, or a game in general?

@Androish I guess instead of "sort" you meant "filter"; yes we could filter out people who's uncertainty is higher than X, but I don't think we're actually winning something here. You don't want to disappear from the leaderboard just because the system is uncertain of your skill, and we don't want this graph to be different from the leaderboard either.
@NiklasKopp that's a very good catch, didn't think of it. All players with a rating less than 0 should be rounded down instead of up (-1 falls into the -100 category).
@OCGDFS the "wasn't online for 3 months" was a temporary cleanup for a currently broken system. Eventually I will implement "hasn't played ladder for 3 months" correctly, but this needs another database and software update first (scheduled for 2017-10-23).

Corrected the rounding of the ratings:

@micheljung If there is nothing else (after fixing the codacy issue) I guess I'll rebase on develop and force-push this?

It's not correct that values outside [0;3000] are meaningless, and assuming values like 0 and 3000 isn't correct either because these values depend on the TrueSkill parameters and number of skill classes. Negative values also don't mean that there aren't enough games, nor is it caused by high uncertainty.

Yes, it's correct precisely because of our parameters. The rating space is given by the normal distribution with 1500 as the mean and 500 as the deviation (mu and sigma-squared respectively). This puts values outside of the interval [0;3000] outside of the distribution, and hence invalid.

No, it's not. It's not how TrueSkill works. What we are displaying here is the leaderboard rating, which is different from the skill, as you surely know. The rating is skill - 3*dev and TrueSkill doesn't prevent you from having a skill of 100 with a deviation of 50.  Otherwise, if your skill was 0, your deviation needs to be 0 in order to have a rating of at least 0. But you'll never get a deviation of 0.
Let's look at our current values.
Initial mean/deviation
Our initial mean is 1500 and our initial deviation 500. Those are called initial values because that's exactly what they are. It does not mean that those values set the boundaries of our TrueSkill system.
Beta
Our beta is set to 240, which is the skill class width. Meaning that if one player has 240 more skill points than another, he has a 76% chance of winning. If all of our players were similarly good, everyone would have a 50% chance of winning against any other player. We had exactly 1 skill class and all skill points would be about 1400-1600.
However, the more the skill of the worst and best players differ, the more skill classes we have. This is something we cannot possibly predict without looking at data! There could be 3, 5, 10, or 20 different skill classes. As a matter of fact, our best active ladder1v1 player has a skill of 2457 while our worst active ladder1v1 player has a skill of -10 (yes, even that is a sensible value), giving us a difference of 2467 skill points, divided by 240 equals to 10.28 skill classes in FAF.
A very simple example
Using the values above, let's take 2 totally new players A and B with skill/dev 1500/500. They play a game, A wins, B loses. We do the math and the result is the following.
A: 1765.51/429.19
B: 1234.49/429.19
Both skills changed by 265.51 and deviation got reduced by 71.81.
Now let's do the math:
Rating of A: 1765.51 - 3*429.19 = 477.94
Rating of B: 1234.49 - 3*429.19 = -53.08
Now, what happens if Player B loses against another player, C, which the exact same stats as B? Player B will drop to 839/311, resulting in a rating of -94.
This totally makes sense because the deviation does not get smaller as a player approaches 1500-3500 or 1500+3500.
And if you still don't believe me, go to Microsoft's Official TrueSkill calculator and calculate the outcome yourself (Spoiler: Bob gets a Rating of -0.909 after playing against the same-skilled Alice).
What they do, however, is if( trueSkill<0 ) trueSkill = 0; to display data. Doesn't change the fact that the actual rating is still negative, and that players with a negative rating don't necessarily have the same skill.


Allow to maximize windows of web UI

Similar to https://swe-agent.com/demo, we want to have an expand button on the top right of the three sub-panes that opens a larger popup of the same window.
Here's the code from swe-agent.com/demo (look for TerminalPanel.js etc.)
swe-agent-website.tar.gz

[!tip]
General tips for frontend contributors:

Please open a separate PR for every issue that you address. Try to keep PRs small and concise (if you're thinking of bigger refactorings, please let us know)
In the web UI under "Extra Settings" there's a switch to run without needing API credits for testing purposes
Please install pre-commit (pip install pre-commit && pre-commit install) to ensure that your submission follows the styling guidelines

this would be cool


Error message

[ ] Using latest version as provided on the master branch
[ ] Searched for similar issues including closed ones

What is the purpose of your issue?

[ ] Script won't run
[ ] Encountered bug
[ ] Feature request
[ ] Question
[ ] Other

System information

Your python version: python 3.x
Your operating system: Ubuntu 16.04

Description

When I use the command line
python3 spotdl.py --help
I get the massage
ImportError: No module named 'spotipy' root@ubuntu:/home/mb/spotify-downloader#

See, we are busy developers maintaining this in our free time. So please make our lives a little easier.

Why haven't you checked any of these?

Which exactly?
Ans, as I told you this is not our fault. Follow the instructions from the readme, install all the dependencies correctly and it will work fine.

Thanks

@clock17 FYI, run pip3 install -r requirements.txt to install necessary dependencies.


Flutter Web Performance issues

I have gone through some flutter web page speed insights and analysis.
Page Insights for Flutter web App
Found that most of the time the Analysis fails and hence we are not able to get proper insights from Page Speed Insights
In most of the cases the insights are pretty much the same. It seems the tree shaking is not performant enough, The web page analysed here has almost all of the content as Constants and almost no usage of resources.
Need Preload and prefetch for static contents

Hi @akashgkrishnan This looks similar to https://github.com/flutter/flutter/issues/56759, can you take a look at this comment to see if it answers your question https://github.com/flutter/flutter/issues/56759#issuecomment-626261669 ?

I have made all the possible Optimisations.
The given website is hosted on Github Pages.

It would be more useful to break down the list of issues uncovered by this benchmark into individual Github issues. We cannot address them all at once. I will deduplicate this issue with https://github.com/flutter/flutter/issues/76248 as it seems the biggest contributor. Other issues should be filed separately.


When I write a commit message in my editor, and save and close it, if the message fails commitlint, I have to recreate everything I wrote (re-gather reference URLs, re-copy any supporting evidence for the reasoning in the commit, etc), from scratch.
It would be great if commitlint could keep a record of the last failed commit, so that a fresh git commit opens it up automatically, and you can make the (usually minor) necessary changes to pass commitlint.

I like that idea... I just had the same annoying experience. I wrote a lengthy commit message, commitlint said NO, and my  long commit message was gone.
Unfortunately I think it is not commitlint, but git itself, that removes the temporary file with the commit message.
I guess it might be possible to create a copy of the file by simply adding a .bak to the filename if commitlint is called with a filename (and not reading the commit message from stdin.).
If commitlint exits with an OK, it removes the .bak otherwise it prints the path to the file, so that you can recover the contents for the next attempt.

I wrote a lengthy commit message, commitlint said NO, and my long commit message was gone.

It's SO frustrating!
Your .bak file approach sounds workable. Even if (in the case of a "bad" commit message) you have to manually open the file and copy in its contents, and manually delete the file, it's far preferable to the toilet-flush that you experience this way.

Another idea might be a little more intrusive, but more helpful ... :thinking:
If we decide to fiddle about with git-config, we might save the "bad" message in a file and put its location in config.template ... Thus making git commit automatically open that file and put it in the editor :grin:


read all jira issues in chunks of 50

Description

Read all tickets for the jira query in chunks of 50
Add jira key to document description

Type of Change
Please delete options that are not relevant.

[ ] New Loader/Tool
[x] Bug fix / Smaller change
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have added a library.json file if a new loader/tool was added
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

@jerryjliu,
I have made the change you requested. I can see that 2 workflows awaiting approval and only those with write access can merge. What's pending to be able to merge this to run_llama:main ?


Values Table have duplicate data for _id and _lastUpdated

Values Table have duplicate data for _id and _lastUpdated. To reduce the usage, add filtering logic to keep from the persistence layer.

refactor: Values Table have duplicate data for _id and _lastUpdated #1388

FHIRPersistenceJDBCImpl filters the codes in the extractParameterValues step and keeps the parameter values from hitting the corresponding tables

PR is forthcoming


Any example regarding how to "Get the 2D gaze position on a predefined 3D plan(s) allowing to understand what the user is looking at."?

Thank you very much for sharing your valuable effort.
As stated in the title of the issue, it would be really great if you could provide more information and an example regarding how to "Get the 2D gaze position on a predefined 3D plan(s) allowing to understand what the user is looking at".

Well, that's exactly what this library is about.
I've buit it to play with my daughter by putting masks on faces, face swapping, deep faking... And one of the games was chacing objects on a screen by the face.
So yes, there is a way to define a 3D plan, then determine the 2d position of the intersection between the gaze line and the plan. In the example, I use the face vector as it is more precise and easy for the game purpose, but you can just change it with the eye gaze vector. You may change a parameter at the beginning of the file (use_eyes=True). There is also a Kalman filter to filter out any disturbance.
Good luck.
You just need to take a look at face_chacer examples (either in pygame or sqtui).
There are valuable helpers to do 3D eucledian geometry in helpers.geometry.euclidian. There you'll find functions to define a plan and detect intersection between a line and a plan. I've done the calculations myself remembering what I've leaned at school years ago. It sould work.

To help you more here are the keys:
Build a plane by providing 3d coordinates of 3 points
Here is the screen plane (the z is 0 assuming the camera in in op of the screen)
main_plane  =    get_plane_infos(np.array([0,0, 0]),np.array([100,0, 0]),np.array([0, 100,0]))
then you can get the face or eye vector (a vector going out of the face or the eye)
li  =    get_z_line_equation(face_pos, face_ori)
Fuinally, use this function to get 3D postion of the intersection of the gaze vector and the planne as well as the 2D position :
p, p2d   =    get_plane_line_intersection(main_plane, li)
I hope this helps.

Thank you very much for your kind help.
Unfortunately I do not have Windows, so it will take a while before I can devote a time slot to port face_chacer.py to Linux. I will post here when I do.

The latest code should work on linux. I have removed the dependency on Direct show. It is not necessary at all. Just pull the latest master update and it should work.

Hello @ParisNeo , I pulled the latest master, built it, installed it and ran the example face_chacer.py.
Unfortunately I still get an error:
$ python face_chacer.py
pygame 2.1.2 (SDL 2.0.16, Python 3.8.10)
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "face_chacer.py", line 21, in <module>
    from FaceAnalyzer.helpers.ui.pygame import Widget, Button, Label, ProgressBar, ImageBox, WindowManager, Sprite
ModuleNotFoundError: No module named 'FaceAnalyzer.helpers.ui'
$

Is there anything I'm still missing?

If you look at the last version, you'll find that the ui helper does exist.
Now this is a new thing as for the old versions there were no sphesticated helpers and they were all placed in the same Helpers.py file.
Make sure you install the latest version of the code from pypi
pip install --upgrade FaceAnalyzer
I suspect that you have an old version somewhere on your system and the interpreter is trying to access it.
The new version is completely incampatible with the first ones as many upgrades and code reorganizations have been added.

I uninstalled everything, cleaned up, re-installed the package again with pip. No changes, I still get the same error.
I also tried to clean everything, clone the repository, build and install. Same results. Sorry, I guess I'm missing something.
The only examples I can run are those with OpenCV. They now run out of the box, as you removed the references to DSHOW.

Have you installed pygame?
I just added pygame to the requirements for version 0.1.13 so that it gets installed automatically when you install FaceAnalyzer.
I'm sorry as I couldn't test it on Linux yet.

Sooorrrry, I think I've figured it out.
I forgot to add a init.py to the ui subfolder. I think that's what was causing the error.
Upgrade to V 0.1.14 and it should work.

There is a problem in your error message:
The version you have is:
0.1.12
The current version is:
0.1.14
You should try to do this:
pip install --upgrade FaceAnalyzer
This will upgrade the library to the latest version and it should work

Did you update the git repository? I'm still receiving the same version as 6 days ago

Sorry forgot to push :)
But the Pypi was uptodate.

I'm still getting errors, maybe some other init.py is missing?
$ python face_chacer.py
pygame 2.1.2 (SDL 2.0.16, Python 3.8.10)
Hello from the pygame community. https://www.pygame.org/contribute.html
/home/ianni/.virtualenvs/FA/lib/python3.8/site-packages/FaceAnalyzer-0.1.14-py3.8.egg/FaceAnalyzer/Face.py:1507: SyntaxWarning: assertion is always true, perhaps remove parentheses?
/home/ianni/.virtualenvs/FA/lib/python3.8/site-packages/FaceAnalyzer-0.1.14-py3.8.egg/FaceAnalyzer/Face.py:1507: SyntaxWarning: assertion is always true, perhaps remove parentheses?
Traceback (most recent call last):
  File "face_chacer.py", line 26, in <module>
    from examples.Pygame.face_chacer.Chaceable import Chaceable
ModuleNotFoundError: No module named 'examples'

That one is eazy, change this
from examples.Pygame.face_chacer.Chaceable import Chaceable
to this
from Chaceable import Chaceable
My editor (vscode did this automatically because I am running the examples from the root folder)
I've corrected this in the last version 0.1.15
Sorry again.

If I may add one more suggestion, you might want to add pyqt5 as a dependency for your software. I had some hard time in order to detect also this small issue.
pip install pyqt5

The QT library is just for spome examples. The core do not need those libraries.
I may add this to the header of each of these files in the examples
And in case you did not realize, the library examples use my other library SQTUI that requires either PyQt5 or PySide.
The idea here is to give the user the opportunity to use both PyQt or PySide. In fact, PyQt5 has two options for licences:

A paid licence
A copyleft licence (GPL3).

The problem with GPL3 is that it contaminates your code, so basically anything you build with it becomes GPL3. I prefer MIT for all my licences as it is not contaminitaing and allow the user to use the library in commercial products without forcing the need to open every bit of code.
Of course, MIT licence still obligates the user of the library to mention in its products that he used this library and provide a link to the source code, but the code using the library can be closed and the MIT licence is totally respected.


Decrapify appears to report crapware found when none is found

Having red text in this response is confusing. Could we remove the red text if no crapware is found?

Yeah, now that I see the picture, I always end up with totally different Clippy editions here 😬

https://github.com/builtbybel/Winpilot/releases/tag/3.3.0


fix proxy authentication #344

this just adds test for referenced issue

Current coverage is 85.47%

Merging #348 into master will decrease coverage by -0.17% as of 561e76e

@@            master    #348   diff @@
======================================
  Files           40      40
  Stmts         4655    4655
  Branches       632     631     -1
  Methods          0       0
======================================
- Hit           3987    3979     -8
- Partial        150     151     +1
- Missed         518     525     +7

Review entire Coverage Diff as of 561e76e

Powered by Codecov. Updated on successful CI builds.

I've definitely seen proxy auth working. Do you have an idea when it works, so that we can add a test for that as well?

I've definitely seen proxy auth working.

sure I've seen it working too. It worked pretty well. I need to check since when it started to malfunction, I'm guessing that some changes in Qt5 perhaps? Have you seen proxy auth working under Qt5?

@kmike I added fix for missing authentication headers, I went with manually setting auth headers in createRequest in NAT.
Alternative approach is setting authentication on ProxyAuthenticationRequired as in  here: https://github.com/scrapinghub/splash/pull/346 but as @Youwotma noted this way we can't deal with invalid proxy credentials being passed. If there are invalid credentials passed in Signal QT will just keep emitting signal again and again, filling up retrying request all the time with bad credentials. We probably dont want that.
Drawback of current solution is that it handles only Basic authentication and not other forms of proxy-auth, but at least it does handle the most common form of authentication.
TODO list would involve adding tests for proxy authentication in HTTP API, I'm not sure if this works ok now, but if we can do review and testing of this on other PR that would be cool.

Thanks @pawelmhm and @Youwotma!


Use ID of subsegment created for SDK request in trace header.

*Issue #104 *
Description of changes:
Crate the XRay subsegment for the AWS SDK request before creating the trace header.  This will allow the ID of the subsegment to be used as the ParentId in the trace header.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I spent more time than I care to admin trying to figure out how to write a unit test for this.  I can't figure out how to access the execution context or the request from within tests.  If someone wants to point me in the right direction, I'll be happy to revisit and add tests.


internal/compile: optimize the encoding

The gob encoding was showing up in profiles.
This change replaces it with a simple hand-written binary encoding
using strings and varints.  Strings and byte slices are allocated
in one contiguous block to reduce allocations.
The new encoder and decoder are about 5x faster with 10x fewer allocs.

benchmark

This should probably be fuzzed too.

Fuzzing the parse/resolve/compile/encode/decode pipeline sounds good, but I'm not interested in fuzzing the decode function directly, or in making it robust for arbitrary or malicious inputs. The three additional checks you mention are just the tip of that iceberg; this is not a Java class loader. It is the application's responsibility to ensure that the input to Decode comes from the output of Encode at the same version. The magic and version checks are just to flag common accidental mistakes.

Hmm.. is there an easy way to generate a huge number of complex starlark programs? Although running it across the internal bazel rulesets at Google would probably cover everything. Just need to be mindful of the few Go-implementation-specific language tweaks and ensure they're handled correctly.

Hmm.. is there an easy way to generate a huge number of complex starlark programs?

Not really. Each application's set of predeclared built-ins in effect defines a different dialect, and the Go implementation provides even more language options, so existing programs need some tweaking to work in the core subset, as was the case for testdata/paths.bzl.


[WIP] Quantization dev main add rewrite utils make pad allow dynamic

Allow a dynamic padding value but return a tensor with static shape. Currently if a dynamic padding value is used, the output tensor has a dynamic shape even if it can be statically calculated via static pad_widths.
Run:
python python/tvm/relay/transform/quantization/quantized_operators/conv.py
Get:
tensor type `float32` has 0 dimensions, while `Tensor[(1, 2, 5, 5), float32]` has 4 dimensions
The Relay type checker is unable to show the following types match.
In particular `Tensor[(1, 2, 5, 5), float32]` does not match `float32`
The type inference pass was unable to infer a type for this expression.
This usually occurs when an operator call is under constrained in some way, check other reported errors for hints of what may of happened.
The type inference pass was unable to infer a type for this expression.
This usually occurs when an operator call is under constrained in some way, check other reported errors for hints of what may of happened.
note: run with `TVM_BACKTRACE=1` environment variable to display a backtrace.

Thanks Matthew for helping out for this! I'm going to make a new branch to merge this into main.


Document Aliases to be used in cipher-tool encryption

Description:
Since arbitrary password aliases cannot be given in cipher tool encryption process please consider documenting then properly.
Related Issues:
https://github.com/wso2/product-apim/issues/4343

@msm1992 , is it possible to provide all the expected aliases for cipher tool, so that we can document it.

The latest documentation has been updated with the relevant details


Some gltf items are not rendered properly

Hi, I have problems trying to convert from gltf to sfb.
Original in gltf viewer

Sfb in AndroidStudio viewer

Using default matrial in Gradle pluging.
This are files:
files.zip
Why color of materials are so differents? and What are these  black blocks?

The colors are probably different because the two viewers are using different environment lighting.
The black blocks appear to be from NaNs stored in the glTF's tangents and bitangents. The Sceneform converter uses those attributes, while the online viewer ignores them and regenerates them on its own, which is why there's a difference. Notice that there's a significant amount of errors present in the glTF file as reported by the glTF validator.

The colors are probably different because the two viewers are using different environment lighting.

How can i setup this in ArCore sceneform?

The black blocks appear to be from NaNs stored in the glTF's tangents and bitangents. The Sceneform converter uses those attributes, while the online viewer ignores them and regenerates them on its own, which is why there's a difference.

Yes we don't export tangents and bitangest, but why you don't do the same as online viewer and recreate them? i know is not the best solution. But it's better than drawing black blocks, right?

Notice that there's a significant amount of errors present in the glTF file as reported by the glTF validator.

We created the gltf from an automatic process reading a database where we saved our building objects. About errors, we are working to solve them. But we don't think this is the problem. Most of them are information that is not in use or precission problems when we write to text and what is saved as binary.
Thanks!

We should definitely detect NaNs and generate our own tangent/bitangent in that case.

That's my mistake, I looked at the output which contained NaNs and assumed they came from the input buffer, but none of the primitives appear to be specifying tangents/bitangents. Sceneform should be generating them, and it appears to be a bug that it's generating NaNs.

This is fixed as of Sceneform 1.7


Train the data for Multiple fonts

I am trying to tackle the problem to detect cars with multiple fonts and length of number of characters on licence varies from 5 to 7 and in once case i have two line license plate with alphabets on top and numbers below ..
First issue i want to resolve is of multiple font. Currently this system is designed to be trained with single font , in current scenario it is "UKNumberPlate.ttf" , how can i add multiple ttf files..

I've put mor font in font folder, and its work!
It take all font


Building libCHIP.a via the Xcode build connector seems to involve codegen

There shouldn't be anything in libCHIP.a that depends on codegen, but what chip_xcode_build_connector.sh does right now (skipping some bits that I am pretty sure are irrelevant):
declare -a args=(
    'default_configs_cosmetic=[]' # suppress colorization
    'chip_crypto="boringssl"'
    'chip_build_tools=false'
    'chip_build_tests=false'
    'chip_enable_wifi=false'
    'chip_log_message_max_size=4096' # might as well allow nice long log messages
    'chip_disable_platform_kvs=true'
    "target_cpu=\"$target_cpu\""
    "target_defines=$target_defines"
    "target_cflags=[$target_cflags]"
    "mac_target_arch=\"$target_arch\""
    "mac_deployment_target=\"$LLVM_TARGET_TRIPLE_OS_VERSION$LLVM_TARGET_TRIPLE_SUFFIX\""
)
...
    args+=(
        'target_os="mac"'
    )
...
    gn --root="$CHIP_ROOT" gen --check out --args="${args[*]}"
    exec ninja -v -C out

ends up failing if ZAP is not installed.  What's not clear to me is what about that command line is really saying "just build libCHIP.a", but the net effect is that there is just a libCHIP.a in out/lib (well, and libmbedtls.a for some reason and  libnlunit-test.a) and no executables in out.  So clearly the build is in fact just building things that should not depend on codegen.
We need to figure out two things:

Do these things in fact depend on codegen?  If so, we need to fix that.  But I suspect they do not in practice.
Is the build system just confused about whether they depend on codegen?  If so, we need to fix that.

@mspang @andy31415

Looks like the dependency here may be through libChipController which uses CHIPClusters.h.  Going to see if I can just remove that dependency.


Split up rest.go into /web and implement PupRouter

PupRouter not yet hooked up but as this is a very large refactor I think we should merge to avoid drift


Could not validate request HMAC

Issue summary
I am building a merchant-facing app to onboard merchants to my marketplace. After setting up shopifyApp from @shopify/shopify-app-express, the app it keeps giving the following error:
Webhook request is invalid, returning 401: Could not validate request HMAC
Failed to process webhook: Error: Could not validate request HMAC

Complete setup (removed key and secret to paste here):
// Shopify.ts
export const shopify = shopifyApp({
  api: {
    apiVersion: LATEST_API_VERSION,
    restResources,
    ...env(),
  },
  auth: {
    path: "/api/auth",
    callbackPath: "/api/auth/callback",
  },
  webhooks: {
    path: "/api/webhooks",
  },
  sessionStorage: new SQLiteSessionStorage(DB_PATH),
});

// GDPR.ts
import { DeliveryMethod } from "@shopify/shopify-api";
import { WebhookHandlersParam } from "@shopify/shopify-app-express";

export const webhookHandlers: WebhookHandlersParam = {
  CUSTOMERS_DATA_REQUEST: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("CUSTOMERS_DATA_REQUEST", webhookId);
    },
  },

  CUSTOMERS_REDACT: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("CUSTOMERS_REDACT", webhookId);
    },
  },

  SHOP_REDACT: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("SHOP_REDACT", webhookId);
    },
  },

  APP_UNINSTALLED: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("APP_UNINSTALLED", webhookId);
    },
  },

  PRODUCTS_CREATE: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("PRODUCTS_CREATE", webhookId);
    },
  },

  PRODUCTS_DELETE: {
    deliveryMethod: DeliveryMethod.Http,
    callbackUrl: "/api/webhooks",
    async callback(topic: any, shop: any, body: any, webhookId: any) {
      const payload = JSON.parse(body);
      console.log("PRODUCTS_DELETE", webhookId);
    },
  },
};

@shopify/shopify-app-express version:^2.2.2
Node version:v18.16.0
Operating system:Windows

Expected behavior

shopifyApp should setup correctly and link it provides should work

Actual behavior
Giving error:
Webhook request is invalid, returning 401: Could not validate request HMAC
Failed to process webhook: Error: Could not validate request HMAC

Steps to reproduce the problem

git clone https://github.com/yanglee2421/shopify-app-demo.git
yarn && yarn dev
yarn shopify webhook trigger

Hi, any update on this, I have the same issue and I tried different solutions but nothing works

To ensure that a webhook was sent from Shopify, you need to verify its authenticity by calculating a digital signature. Shopify includes a header x-shopify-hmac-sha256 with the request, which contains a base64-encoded HMAC-SHA256 hash of the request body. This hash is generated using the secret key you set in your webhook settings.
You can find more details here.
Here's an improved example in JavaScript:
function verifyWebhook(data, hmacHeader, CLIENT_SECRET) {
  const encoder = new TextEncoder();
  const keyData = encoder.encode(CLIENT_SECRET);

  return crypto.subtle.importKey('raw', keyData, { name: 'HMAC', hash: 'SHA-256' }, false, ['sign'])
    .then(key => crypto.subtle.sign('HMAC', key, data))
    .then(signature => {
      const calculatedHmac = btoa(String.fromCharCode(...new Uint8Array(signature)));
      return calculatedHmac === hmacHeader;
    });
}

const clonedRequest = request.clone()
const hmac = clonedRequest.headers.get('x-shopify-hmac-sha256')

if (isShopifySignature)
  return new Response('Invalid Signature', { status: 401 })

const CLIENT_SECRET = "YOUR_SHOPIFY_SECRET"
const body = await clonedRequest.arrayBuffer()
const isValid = await verifyWebhook(body, hmac, CLIENT_SECRET)

if (!isValid)
  return new Response('Invalid Signature/HMAC', { status: 401 })

// Continue with your logic

// return shopify 200 response
return new Response('OK', { status: 200 })

This code performs the following steps:

Imports the client secret key for HMAC signing.
Signs the request body with the imported key.
Converts the signature to a base64 string.
Compares the calculated HMAC with the HMAC received in the request header.
Returns a 401 response if the HMAC verification fails or a 200 response if it succeeds.

I hope this helps! Let me know if you have further questions.


The aws-mfa tools strips comments from the ~/.aws/credentials file

In our environment, we auto generate a number of profiles and we use a comment
START of Generated Lines
To separate out the generated profiles from the non-generated one.  Unfortunately, everytime we run the aws-mfa tool, it removes that comment.

it is indeed. But this is due to configparser see https://github.com/python/cpython/blob/96a60ae90c291d94c058c80351fa38b6d73eda92/Lib/configparser.py#L567


Source link on PR environments is incorrect for GitLab

Describe the bug
When pull requests are enabled in Lagoon, and the git repo is on GitLab the "source" link shown on the Lagoon PR environment overview page is incorrect. It gives a 404 from GitLab when clicked.
To Reproduce
Steps to reproduce the behavior:

Create a MR in GitLab
Go to the PR Environment Overview page in Lagoon
Click on the link under the Source heading
Get 404 error page on GitLab

Expected behavior
Clicking the link should take you to the MR page on GitLab.
Screenshots

Additional context
The link in the CI channel of Rocket Chat is correct and does not give a 404.

@kmbremner for your example can you provide what the correct gitlab link is?

@rocketeerbkw sure! The (working) link in rocket chat was https://gitlab.com/one_young_world/oyw-website-d8/merge_requests/34

After the recent update to 0.22.1, we see a : added before the GitLab group name in the source link. For example:
https://projects.govcms.gov.au/:sandbox/someproject/tree/master
...when it should have been:
https://projects.govcms.gov.au/sandbox/someproject/tree/master

@klonos I have raised #1066 to address the problem you are seeing

fixed in #1066


Conditional widget is broken

Getting an error when adding a conditional widget to the template:
AssertionError: path should be a string

NOTE: I still need to back port the fix to  ^1.5. I'll provide an update soon.


Migrate to Docusaurus frontmatter & change all heading levels to use markdown

https://docusaurus.io/docs/markdown-features#front-matter
https://docusaurus.io/docs/markdown-features#standard-features

Preview URL: https://pr-9.neoforged-docs-previews.pages.dev

Well, I think I finished the work.
For links, it will be better to do that in a separeted PR (for easy reviews), this PR is already big enough

Why are we removing the titles and only sticking it in the metadata? We can just leave the title as is since it'll be consumed by the parser. The one I think should probably be in the metadata is the description if the first sentence doesn't accurately describe the page.

Hey! Sorry for the delay for my reply. I did it out of reflex because I think it's more "cleaner" (as generally, front matters are used for page headers). But, if It's needed to change it, I can.

All good. Though I think its better with the title since it stands out to me that I've clicked the correct page. Since we normally have  a quick description of each page below the header, it makes sense to have it there imo.

So I should use h1 for the title?

Yep, wrote up a whole style guide if you need it: https://docs.neoforged.net/contributing#style-guide

@ChampionAsh5357 It's changed ^^

There's not a file for this, but there likely needs to be a _category_.json file at the top level to order the folders.

Directly in docs folder ?

We could also change from an autogenerated solution to modifying the sidebars.js so that everyone doesn't have to modify the position of every file.

We could also change from an autogenerated solution to modifying the sidebars.js so that everyone doesn't have to modify the position of every file.

I think it's the better solution ^^.

Go for it. We'll probably need to change the contributing guidelines too to match that

Go for it. We'll probably need to change the contributing guidelines too to match that

Resolve the merge conflicts and this should be good to go. We'll see when new pages are added whether autogenerated subfolders make sense, or if we should do it manually.

Closing as completed by #65.


Update steps to deploy DeepStream Module to accommodate all customer environments

It appears that not all customer environments have access to deploy IoT Edge Modules from the Azure Marketplace, it may be advised to update documentation to reflect manual steps to accommodate this situation.  This would impact steps 14 & 15 here.
I will update this issue shortly with a proposed workaround / PR.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6ed06ba-9f13-a2e5-59b3-645cdd2e2821
Version Independent ID: de5caca5-1d3e-aaf0-3aa5-aadd2abff270
Content: Attach a GPU to a Linux VM in Azure Stack HCI - Azure Stack HCI
Content Source: azure-stack/hci/manage/attach-gpu-to-linux-vm.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @khdownie
Microsoft Alias: v-kedow

@toolboc Thanks a lot for bringing this to attention and also helping fixing the document with a PR. Thank you

@toolboc Thanks for the feedback! It looks like your PR request was merged, so I am going to close this issue.
@khdownie FYI


"Lozna" , "Cormeniș" , "Preluci" , "Valea Leșului" , "Valea Loznei" are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and city, according to the law
Preconditions : the  website is up and runing. After every step delete the text you typed from the search bar.

Step 1
Write in the search bar "Lozna"

Expected results
The location appears in the drop-down menu as "Sat Lozna, SĂLAJ (Lozna)"

Step 2
Write in the search bar "Cormeniș"

Expected results
The location appears in the drop-down menu as "Sat Cormeniș, SĂLAJ (Lozna)"

Step 3
Write in the search bar "Preluci"

Expected results
The location appears in the drop-down menu as "Sat Preluci, SĂLAJ (Lozna)"

Step 4
Write in the search bar "Valea Leșului"

Expected results
The location appears in the drop-down menu as "Sat Valea Leșului, SĂLAJ (Lozna)"

Step 5
Write in the search bar "Valea Loznei"

Expected results
The location appears in the drop-down menu as "Sat Valea Loznei, SĂLAJ (Lozna)"


[6.0.2] [Windows] Fix incorrect TimeZone.current lookup logic

Explanation: Fixes lookup of the current timezone on Windows
Scope: Only impacts TimeZone.current on Windows
Original PR: https://github.com/swiftlang/swift-foundation/pull/975
Risk: Low - restores Swift 5.10 behavior and scope is minimal
Testing: Testing done via swift-ci testing and local testing
Reviewer: @parkera @compnerd

@swift-ci please test


NestedScrollView not supported by ScrollTo ViewAction

Steps to reproduce:

Create a layout with a nested scroll view
Create a test that calls scrollTo on a view within that layout

Observed Results:

Error is thrown that the scrollTo action failed
androidx.test.espresso.PerformException: Error performing 'scroll to' on view '(with id: [view id])'.

Expected Results:

UI test scrolls to the relevant view

Possible Workaround:
Currently using the solution from here, which just adds NestedScrollView as one of the assignable objects for ScrollToAction
https://stackoverflow.com/questions/35272953/espresso-scrolling-not-working-when-nestedscrollview-or-recyclerview-is-in-coor

Hi there! Thank you for raising this problem.
I'll see what I can do to improve.


Shortcuts mentioned in the menu are not in sync with the actual shortcuts

VSCode Version:

Version 1.9.0-insider
Commit 2cdc2b3da8f0fd5322b48747241584cf9dd98f8f
Date 2017-01-13T07:03:18.620Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

OS Version:

Ubuntu
Steps to Reproduce:

I have installed IntellIj keybinding plugin & it resets Goto symbol in workspace to a shortcut of Ctrl+N
But if I go to vscode menu File, New file option shows that Ctrl+N is mapped it.
But in reality when I press Ctrl+N, I am shown Goto symbol dialog.

@thekalinga does this problem fix itself when you quit and restart VS Code?

No it does not. This is persistent even after many restarts

@thekalinga awesome catch 👍


Error: Handshake inactivity timeout

I was trying to use node version v4.2 and the plugin does not work, I get the error above.  Is this already known?

This is a bug in Node.js 4.2.0. It is fixed in 4.2.1, if you want to upgrade to get the fix :)

I use version v4.2.1, It often Unhandled rejection Error: Handshake inactivity timeout.


ng new installation fails using npm 7

🐞 Bug report
Command (mark with an x)

[x] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Unknown

 Yes, the previous version in which this bug was not present was: ....
Description
ng new angular-tour-of-heroes results in an NPM error regarding the version of jasmine-core Angular wants and the version karma-jasmine-html-reporter wants when using npm 7.
 A clear and concise description of the problem...
🔬 Minimal Reproduction

Install npm 7
Run ng new angular-tour-of-heroes with all default values.

🔥 Exception or Error

⠏ Installing packages (npm)...npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/jasmine-core
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/karma-jasmine-html-reporter
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\Jeroen\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR!      C:\Users\Jeroen\AppData\Local\npm-cache\_logs\2021-05-25T12_22_51_638Z-debug.log
✖ Package install failed, see above.
The Schematic workflow failed.
Ivy Workspace:

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1102.12 (cli-only)
@angular-devkit/core         11.2.12 (cli-only)
@angular-devkit/schematics   11.2.12 (cli-only)
@schematics/angular          11.2.12 (cli-only)
@schematics/update           0.1102.12 (cli-only)

Anything else relevant?
npm: 7.11.2

Workaround:

Run ng new angular-tour-of-heroes with all default values.
Let the command error
Run cd angular-tour-of-heroes
Run npm i --legacy-peer-deps

Please update to the latest patch release for v11 (currently 11.2.13). Alternatively, v12 is also available.

If you are still encountering this issue after updating, please let us know.


Installation Arybo via pip on Windows, 'ssize_t': redefinition

Hi, I install Arybo via pip and Python 3.6.5 32bit on Windows and receive this error:

C:\Program Files (x86)\python36-32\include\pyconfig.h(174): error C2371: 'ssize_t': redefinition; different basic types
include\pa/compat.h(32): note: see declaration of 'ssize_t'

After I comment the lines defining ssize_t in pyconfig.h, I could install Arybo via pip.

Is this still the case with arybo 1.1.0 under Windows/Python 32 bits ?

Yes, it's still the issue with arybo 1.1.0 under Windows Python 3 32 bits because it failed to build pytanque. I could install Arybo with Python 3 64-bit BTW.
python37\include\pyconfig.h(167): error C2371: 'ssize_t': redefinition; different basic types
    include\pa/compat.h(32): note: see declaration of 'ssize_t'


Topic Search

Whenever we go through topic section and choose one option for information and return to the topic tab the page get reloads and dosen't save the past state ie. We need to scroll down again to find the topic where we left.

Hi, I believe this is a question about GitHub.com, the website. This issue tracker is for a command-line utility called hub, not the website itself. For reporting bugs and requesting features for GitHub the website, please go to https://github.com/contact or visit https://github.community. Thank you!


Added new visual characteritics to the HLGs to highlight the size traits of each layer

[ ] Tests added / passed
[ ] Passes black dask / flake8 dask / isort dask

/cc @martindurant @GenevieveBuckley
Hi. I created this PR to add new size features to the HighLevelGraphs Graphviz depiction based on the amount of tasks each HLG layer has.
This is a follow-up to the information found at https://github.com/dask/dask/issues/7847/.
For now, I have just added a simple implementation of just a trivial case (n_tasks > 5 :: color = gray)
At this point in the code, adding new conditions and loops is simple and quick. All that remains is to decide how we want to display this information on the HLG.

Oh! I kind of pulled some changed in an incorrect fashion. So, it seems as if I authored those changes. I will fix this and open a PR again.
Sorry for this.


osqp: fix cmake config install path for headers

The current version of osqp does appends the install prefix twice which does not allow for downstream packages to use cmake.
Description of changes
remove the redundant install prefix.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

There already is osqp/osqp#481 however it has been in active for a while and will not be released until 1.0. I just posted a response on the PR and will try to get an upstream fix merged


Update license year

TO DO:

[x] Wait to the next year (100% done, depends on timezone)
[ ] Merge!

:octocat:

Signed!

Thanks for the PR, but I don't think this is necessary. My understanding is that the year of first publication is sufficient.
If you'd like to contribute, take a look at the Issues tracker for stuff that needs help. Looking forward to your contribution!

Coverage remained the same at 100.0% when pulling e6eab03a3076d8b9f4b00d8ca6db1a5b8ae609f2 on m1guelpf:patch-1 into 022b6d266fcf8015a789c6fd270adc25b050465c on google:master.


remove aliasing of this

closes #102

solved the 1st level this aliasing by passing through the index in each .each() loop and comparing the indices rather than comparing the elements (aliased this) themselves
otherwise follows suggestion in https://github.com/RMI-PACTA/pacta-dashboard-svelte/issues/102#issuecomment-2515396572

I will push a style commit to get the linter passing


[Bug]: Manually Setup LN connection to LND3 didn't return funds

Describe the bug
After closing a LN connection with LND3 that was setup using the Manual Setup flow, Bitkit told me that "Your funds have been transferred. You are able to use these funds immediately." yet there is no trace of an activity showing the funds have been returned. The closed connection has a Closure reason "ProcessingError".
Using sparrow, I can confirm there is no onchain transaction sent to this wallet, so perhaps I need to wait longer.
bitkit_ldk_logs_1727763581718.zip
Reproduce

Go to Advanced settings -> Lightning Connections -> Add Connection
Establish a new connection to a known usable LN node, such as LND3 03816141f1dce7782ec32b66a300783b1d436b19777e7c686ed00115bd4b88ff4b@<IP_ADDRESS>:9735
Once the transaction is confirmed and transfer is complete, close the channel using the normal Transfer to Spending flow.
Once the flow gets to the "FUNDS MOVED TO SAVINGS" "Your funds have been transferred. You are able to use these funds immediately." page, tap Continue button.
Observe that no Transfer from Spending activity appears.
Observe in Lightning Connections that the closed connection has Closure reason "ProcessingError"

Screenshots / Recording

Operating system
Android 14
Bitkit version
1.0.5 (136)
Log output
No response

The force close is unfortunate, not sure how we're ever going to get nodes we don't control to agree on fees.
2024-10-01 06:05:00 UTC ERROR (LDK): Closing channel 59e11f494092ecde6545be97bf9fa2d4ce5f0f26b6efcb7c236659eec8fa15dd due to close-required error: Unable to come to consensus about closing feerate, remote wants something (308 sat) lower than our min fee (361 sat) (lightning::ln::channelmanager 7236)
2024-10-01 06:05:00 UTC ERROR (LDK): Force-closing channel: Unable to come to consensus about closing feerate, remote wants something (308 sat) lower than our min fee (361 sat) (lightning::ln::channelmanager 9483)
2024-10-01 06:05:00 UTC DEBUG (LDK): Finishing closure of channel due to Channel closed because of an exception: Unable to come to consensus about closing feerate, remote wants something (308 sat) lower than our min fee (361 sat) with 0 HTLCs to fail (lightning::ln::channelmanager 3245)
2024-10-01 06:05:00 UTC INFO (LDK): Applying force close update to monitor 59e11f494092ecde6545be97bf9fa2d4ce5f0f26b6efcb7c236659eec8fa15dd with 1 change(s). (lightning::chain::channelmonitor 2891)

Logs show these are your funds that should be good to be swept if you open the wallet again. Confirmation height was 30 hours ago.
{"confirmation_height":863746,"type":"ClaimableAwaitingConfirmations","amount_satoshis":99457}
@catch-21 can you check this wallet again?

I can confirm the funds have been returned onchain. We have https://github.com/synonymdev/bitkit/issues/2270 and https://github.com/synonymdev/bitkit/issues/2273 to improve communication to the user when force close occurs. So I will close this ticket now. Thanks @Jasonvdb.


DataType decimal

When Create model with this type DECIMAL it return js native Number, but sequelize (with postgres) return js type String

Hi
Maybe this issue is related to  #15  ?  Where we have to specify some transform steps due to sequelize loading fixtures ?
Regards

Close due to no more feedbacks