Nuitka compiled binary miscalculates formula containing Modulo

Nuitka 0.8rc9 (from source)
CPython 3.7.13 on Windows 7 SP1
GCC+MinGW64: 11.2.0 with MinGW64 master from early April 2022
also tested MSVC 2015U3
Given is the following reproducer:
python -m nuitka --standalone --disable-ccache ..\test.py
def reduceAngle(deg):

    return ((deg + 180.) % 360.) - 180.

for i in range(-1000,1001):
    print(str(i) + ": " + str(reduceAngle(i)))

Running the code in CPython 3.7.13 gives an expected output. Values returned shall be in the range [-180..180), which means v >= -180 up to v < 180.
test-CPython.txt
The output after compiled with Nuitka gives back different values when the input is negative and lower than a certain threshold. It is outside the expected range (seems to be between -539 and 179 in this example).
test-Nuitka.txt

Interesting. Can confirm that the output of that script is different on CPython vs Nuitka.
0.7.6
Commercial: None
Python: 3.8.10 (default, Nov 26 2021, 20:14:08)
Flavor: Debian Python
Executable: /usr/bin/python3
OS: Linux
Arch: x86_64
Distribution: Ubuntu (based on Ubuntu) 5.24

Wow, thanks for the report, that is the worst kind of bug.

This uses BINARY_OPERATION_MOD_OBJECT_OBJECT_FLOAT as it knows the right hand side statically, which then seeks to specialize, with float check and float % float code, but I suspect now that the handling of sign is somehow wrong.

This is fixed on factory, it seems positive module of negative values were wrong. I made a mistake when I created the Jinja2 template for the modulo and divmod code, confusing left and right argument in a check, and CPython test suite apparently didn't find it, nor did I. Thanks for the report.

Looks good now, thanks.

This is now on develop and will be in 0.8 release.

Part of 0.8 release that I just made.


Rewrite mod commands and add softban command

In the pursuit of PEP 8 you made it unreadable

At least my build doesnt fail ;)

+1


Themes for PowerToys Run

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
It would be wonderful if PowerToys Run were themeable and/or had the ability to apply a transparency setting like what is available in Wox. This would allow the UI to better "fit" with any themes or desktop backgrounds applied to the desktop UI.
If you'd like to see this feature implemented, add a 👍 reaction to this post.

This request is tracked by https://github.com/microsoft/PowerToys/issues/4794

This request is tracked by https://github.com/microsoft/PowerToys/issues/4794


Netflix addon error: KeyError

Bug report
Describe the bug
Addon does not start anymore and gives a message with

Netflix Add-on Error
The add-on encoutered the following error:
Exception: KeyError
Error details have been written to the Kodi log file. If the error
message does not provide guidance on how to resolve the issue or
you continue to receive this error, please report it on GitHub by
following the Readme instructions.
In Kodi logfile I found:
2020-05-24 19:52:05.744 T:139660835669760   ERROR: [plugin.video.netflix (0)] IPC callback raised exception: u'lolomo'
2020-05-24 19:52:05.744 T:139660835669760   ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 183, in make_return_call
result = call(instance, func, data)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 207, in call
return func(instance)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession_base.py", line 37, in ensure_login
return func(*args, **kwargs)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 84, in fetch_initial_page
api_data = self.website_extract_session_data(response, update_profiles=True)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 267, in website_extract_session_data
return website.extract_session_data(content, **kwargs)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/logging.py", line 148, in timing_wrapper
return func(*args, **kwargs)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/api/website.py", line 104, in extract_session_data
lolomo_root = falcor_cache['lolomo']['value'][1]
KeyError: u'lolomo'
2020-05-24 19:52:05.827 T:139659420763904   ERROR: [plugin.video.netflix (1)] IPC call fetch_initial_page returned KeyError: u'lolomo'
2020-05-24 19:52:05.828 T:139659420763904   ERROR: [plugin.video.netflix (1)] Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 207, in run
route([part for part in g.PATH.split('/') if part])
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 38, in lazy_login_wrapper
return func(*args, **kwargs)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 72, in route
_execute(nav_handler, pathitems[1:], g.REQUEST_PARAMS)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 100, in _execute
executor(pathitems=pathitems)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/navigation/directory.py", line 59, in root
common.make_call('fetch_initial_page')
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/logging.py", line 148, in timing_wrapper
return func(*args, **kwargs)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 87, in make_call
return make_addonsignals_call(callname, data)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 160, in make_addonsignals_call
_raise_for_error(callname, result)
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 173, in _raise_for_error
raise Exception(result['error'])
Exception: KeyError
2020-05-24 19:52:10.089 T:139659370407680   ERROR: GetDirectory - Error getting plugin://plugin.video.netflix/
2020-05-24 19:52:10.105 T:139662369941632   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.netflix/) failed
Until last week the addon was running without problems. I also tried downgrading to 1.3.0 and 1.3.1 but I always get the same error.
Your Environment

Netflix add-on version: 1.3.2
Operating system version/name: LibreElec 9.2.2
Device model:  x86/x64

Used Operating system:

[ ] Android
[ ] iOS
[X] Linux
[ ] OSX
[ ] Raspberry-Pi
[ ] Windows

Expected behavior
start Netflix add-on
Actual behavior
does not start
Steps to reproduce the behavior
I can reproduce it by just starting the Netflix add-on
Debug log
The debug log can be found from this link:
https://paste.ubuntu.com/p/htNSpczmGb/

I'm having the same problem with a OSMC install on raspberry pi

Same issue here !

with 1.4.2 is also happening.

V1.5.0 was released today.


[R] factored dependency 'magrittr' out of R package

@Laurae2 in this PR, I propose that we completely factor out the dependency magrittr, in the interest of reducing lightgbm's dependency footprint. I know magrittr itself has minimal additional dependencies, but in general I think we should strive to keep lightgbm as light as possible and I feel this particular dependency isn't providing a lot of value.

Just rebased this to master to keep up with recent changes.

@jameslamb Can we merge this? If so, I'll be able to remove magrittr dependency from #2176, which is going to be merged this weekend.

@jameslamb Can we merge this? If so, I'll be able to remove magrittr dependency from #2176, which is going to be merged this weekend.

Seems that one file is in conflict. Let me rebase and run the tests manually (because I haven't done #2335  yet).

Ok we currently have 4 failing tests:
══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 33 | SKIPPED: 0 | WARNINGS: 3 | FAILED: 4 ]
1. Error: training continuation works (@test_basic.R#71)
2. Failure: Feature penalties work properly (@test_parameters.R#36)
3. Failure: Feature penalties work properly (@test_parameters.R#37)
4. Failure: Feature penalties work properly (@test_parameters.R#38)

The "training continuation" one exists on master, but I think the other three are problems I've introduced in this PR. I don't feel comfortable merging until I address those three. WIll try to do it today.

Ok we currently have 4 failing tests:
══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 33 | SKIPPED: 0 | WARNINGS: 3 | FAILED: 4 ]
1. Error: training continuation works (@test_basic.R#71)
2. Failure: Feature penalties work properly (@test_parameters.R#36)
3. Failure: Feature penalties work properly (@test_parameters.R#37)
4. Failure: Feature penalties work properly (@test_parameters.R#38)

The "training continuation" one exists on master, but I think the other three are problems I've introduced in this PR. I don't feel comfortable merging until I address those three. WIll try to do it today.

Alright I've figured out the three test errors I introduced. R unit tests now all work. I need to fix the "training continuation works" one but this PR doesn't need to wait on that.
@Laurae2 could you take one more look at this PR and let me know if I could merge?

@jameslamb Please remove this dependency from here as well.
https://github.com/microsoft/LightGBM/blob/e77658205d3b1bc5c19e4ba3821f4222f5be8c05/docs/conf.py#L232

@jameslamb Please remove this dependency from here as well.
https://github.com/microsoft/LightGBM/blob/e77658205d3b1bc5c19e4ba3821f4222f5be8c05/docs/conf.py#L232

done. Good catch, I forgot we do that. I did a git grep magrittr just to be sure there are no other uses in non-standard places, did not find any.

@jameslamb

done. Good catch, I forgot we do that. I did a git grep magrittr just to be sure there are no other uses in non-standard places, did not find any.

Thanks!

I just rebased this PR to master.
Tests for the R package are passing locally (see below)
export CXX=/usr/local/bin/g++-8 CC=/usr/local/bin/gcc-8
Rscript build_r.R
cd R-package/tests
Rscript testthat.R

Once all CI checks pass, I'm going to merge this.


Problems when using webrtcbin with omxh264enc

Hi guys, I am fairly new to webrtc and still learning. I am trying to use omxh264enc instead of x264enc in my pipeline.
When I use x264enc, I can see the video is running fine. However with omxh264enc, video just freezes at the first frame.
Here is the pipeline I am using:
receiver_entry->pipeline =
gst_parse_launch ("webrtcbin name=webrtcbin stun-server=stun://"
STUN_SERVER " "
"videotestsrc is-live=true pattern=smpte ! video/x-raw,width=1280,height=720,framerate=15/1 ! "
"omxh264enc control-rate=2130706433 num-slices=1 periodicity_idr=60 target-bitrate=5000 qp-mode=2 gop-mode=5 interval-intraframes=1 ! "
"video/x-h264,profile=high,alignment=nal,stream-format=byte-stream,level=(string)4 ! "
"queue max-size-time=100000000  ! h264parse ! "
"rtph264pay config-interval=-1 name=payloader ! "
"application/x-rtp,media=video,encoding-name=H264,payload="
RTP_PAYLOAD_TYPE " ! webrtcbin. ", &error);
Any clue what could be the problem?

Using omxh264enc is outside the scope of these examples.  Please use the #gstreamer IRC channel on freenode or the gstreamer-devel mailing list for these kinds of support questions.
These examples have moved to https://gitlab.freedesktop.org/gstreamer/gst-examples/-/tree/master/webrtc and this repository will not be updated further.


Restructuring Gradle Build #3 - Taking care of OSGI building

This builds upon #6378.
Main features:

OSGI attributes & module.xml

For Ceylon-specific modules, the attributes/headers are added at the time the JAR is built. THe module.xml files are transformed at the same time (They still remain in runtime as the source folder for the time being in order to be comaptible with the Ant build). A ceylon extension block is added to the jar task to customise as need be.
For external-dependencies, the tranformation is done in the runtime project as part of the setupRepo. One task per JAR and one task per module.xml are auto-generated in the runtime subproject.

BUILDID file is now generated.
Addressed issues mentioned by @quintesse in #6378.

Addition of LICENSE etc. files to root of distribution folder
Addition of ceylon-format.plugin to bin subfodler of distribution folder

Outstanding:

proxy-bundle, ide, sdk
A number of TODOs are still listed in gradle-migration.adoc.

Known issues:
After a .gradlew clean from the top the first build will fail iin language. A subsequent build will pass. This has something to do with the way the ANT task jat is being made available on the classpath.

gradle-migration.adoc still mentions a

Can one of the admins verify this patch? (see README)

Just to make sure we don't forget about this one:

Another thing is that the Ant build creates a BUILDID file in the distribution folder that contains the (short) Git commit id of the current HEAD of the Git repository that is being used to build things. The same ID is also replaced in the common/src/com/redhat/ceylon/common/Versions.java file.

The BUILDID file is now generated, we still need to do the same for the Versions.java file.

The BUILDID file is now generated, we still need to do the same for the Versions.java file.

Will be fixed by fdce376 & 8923b81

The ceylon.runtime-1.2.3.jar (and .jar.sha1, .src, .src.sha1) are mistakenly called com.redhat.ceylon.runtime-xxxx
There is a ceylon-bootstrap-1.2.3.jar in distribution/repo/com/redhat/ceylon/compiler/java/1.2.3
There is a classes folder in distribution/repo
The 3rd party modules (eg. com.github.lookfirst.sardine, com.google.guava, etc) are missing their .sha1 files
The empty _version_ folders are still there

Especially the first point is important because it prevents code from running. For the rest everything looks good!

The empty version folders are still there

Dis you clean before the build. It might be worthwhile just doing rm -rf builtByGradle and building again. It will probably fail at language build the first time, but the second time it will pass. This is still something I need to investigate.

The 3rd party modules (eg. com.github.lookfirst.sardine, com.google.guava, etc) are missing their .sha1 files

Will be fixed by ccdce465dce30e3ba1d55b4ffdd6d7c47b981dd9 in next PR

There is a classes folder in distribution/repo

Will be fixed by 004a446 in next PR

The ceylon.runtime-1.2.3.jar (and .jar.sha1, .src, .src.sha1) are mistakenly called com.redhat.ceylon.runtime-xxxx

Will be fixed by c7309c8 in next PR

Dis you clean before the build

I did but it turns out it doesn't delete the entire builtByGradle folder as I had expected. (Shouldn't it?)
After deleting the folder manually the problem is indeed gone. Thx!

There is a ceylon-bootstrap-1.2.3.jar in distribution/repo/com/redhat/ceylon/compiler/java/1.2.3

Will be fixed by 9723574 in next PR

I did but it turns out it doesn't delete the entire builtByGradle folder as I had expected. (Shouldn't it?)

I modified the top-level clean to now do that as to avoid confusion. It is also in PR #6395.


Expose "Copy link to post" menu item in Post Dropdown menu

Some Android users are having problems copying post links using the native app because Bluesky currently relies on using the native share dialog to provide such functionality. However, not all Android flavors allow you to copy links from the native share dialog.
Here's an example I shared in the original issue from a user with a Xiaomi device running HyperOS:
Screenshot of the HyperOS share dialog

To solve this UX issue, this PR adds a new "Copy link to post" for all platforms.
While this isn't needed on iOS and some Android flavors, it reduces the amount of presses the user needs to make to copy the link to a publication from 3 to 2.
Fixes #5912.
Manual tests
Android
https://github.com/user-attachments/assets/82c9733a-055a-4fc3-8e58-8530c7496a88
Web
https://github.com/user-attachments/assets/8a89b0a3-28d0-42d2-a4bd-408f18eedd4e

As an iOS user, this would be great to have as it simply makes copying the URL easier and faster.
But of course more importantly, it seems like it would solve a big issue for some Android users.
I hope the team are able to take a look at this soon and hopefully get it merged 🙏

Thank you for this! We're actually planning on going a different route and adding a dedicated share menu, which would include the option to copy to clipboard


Weird Face buttons appearing on screen

Type
GPU
Operating System
Windows
OS Version
Windows 10
Bug description
Weird face buttons appeared on main screen today, not sure why, they seem to disappear when I click off runescape then re-appear when I tab back in.
Still appeared when I closed then ran in safe mode.
Screenshots or videos

RuneLite version
Runelite version: 1.10.35
Oldschool version: Rev 223
Launcher Version: 2.7.1
Logs
client.log
launcher.log

It looks like the emoji icon from Discord, does disabling the Discord overlay remove them?

Yes must be something on discord's end then, disabling the discord runelite plugin does nothing.
But shutting down discord itself stops it.


Would it be helpfull using Tabs instead of dropdown for  Integrated Terminal windows And feature for switching between the tabs.

VSCode Version: 1.5.3
OS Version: Ubuntu 16.04
Current:

Same as Editor windows for Integrated terminal

Duplicate https://github.com/Microsoft/vscode/issues/10546
You can set keybindings to move to the next and previous terminal already, this is what mine look like:
{ "key": "ctrl+shift+j",    "command": "workbench.action.terminal.focusNext" },
{ "key": "ctrl+shift+k",    "command": "workbench.action.terminal.focusPrevious" },


MS5: BE Set up Collaboration Service

Feature: Integrating Collaboration Service
Description
This feature involves developing a real-time collaboration service, enabling two users to work together in a shared coding environment.
User Story
As a user preparing for technical interviews, I want to collaborate with another user in real-time on coding questions so that we can solve problems together and improve our coding skills.
Acceptance Criteria

The user should be able to see real-time code changes made by the other user.
The code editor should synchronize changes within seconds between both users.
The system should handle concurrent code changes and maintain consistency.
The collaboration service should integrate smoothly with the existing application.
The Docker Compose setup should be updated to include the collaboration service container.
The service should be resilient against connectivity issues, maintaining synchronization after brief disconnects.

Technical Requirements

Implement a shared code editor using WebSockets for real-time communication.
Ensure edits are synchronized across two users in real-time with operational transformation (OT) or conflict-free replicated data types (CRDTs).
Code changes should be stored and maintained using EventStoreDB to enable event-driven handling of changes.

Dependencies

The user authentication and room creation service must be fully functional.
The event-driven architecture (EventStoreDB) should already be set up to store and replay code change events.
The WebSocket service for handling live updates between users must be implemented.

#107


After refreshing the invoice detail page, I'm prompted to switch networks even though I created the invoice on polygon.

Only appears on instant invoices.


Update install.sh

EasyMail will no longer ask for admin password

Please resolve conflicts :)

Comment resolved. Please merge.


[GKD] Set custom EOS tokens in generation config

What does this PR do?

This PR exposes aligns the eos_token_id attribute from transformers.GenerationConfig in GKD to support distillation of Llama 3 models which use special tokens <|eot_id|> and <|eom_id|> instead of the EOS token <|endoftext|> to indicate the end of a turn or message. We do this by checking the model's generation_config attribute and including the eos_token_id values in the GKD trainer's GenerationConfig.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

The generation arguments are part of the training arguments. So I think it's more natural to include them in training args.

Can you please also update tests/test_trainers_args.py?

The generation arguments are part of the training arguments. So I think it's more natural to include them in training args.

Are you referring to my suggestion to use the model's gen config as the default then override with the user config if required?

No sorry, I was answering to

Should we expose the full GenerationConfig to users for all online trainers? If so, should it be part of the config classes or a separate arg in the trainer?

@edbeeching @qgallouedec I found a cleaner approach that doesn't require one to expose this arg to the end user and simply reads it directly from the model's generation_config.json.
Let me know what you think!


feat(traffic-light-rviz-panel): select traffic light ID from Combobox

Description
The PR modifies tier4_traffic_light_rviz_plugin so the user can select the ID of traffic light from pull-down menu, unlike directly setting the number from the input button previously.
cc: @kminoda @shmpwk
Related links
link
This link is work in progress, but I'm working on to add this planning with traffic light recognition page to the Advanced section of Autoware tutorial and exhibit the image attached below.
Tests performed
You can select and set/publish traffic light status like in the attached pic.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[X] There are no open discussions or they are tracked via tickets.
[X] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Could you add information about this nice feature in README?

Great work :+1:
Almost OK, but I think it is better to remove unnecessary namespace, if you use alias.
Please check above suggests.

Now it's ready.
I update the README (+ mkdocs.yaml to upload gif file to universe documentation)

There are two commits which have been merged. Could you rebase your branch in order to clean up ?

https://results.pre-commit.ci/run/github/429651616/1654472358.QOJCe3t7SiK01N6XsxB-Jw
What's wrong with pre-commit.ci ? :thinking: cc @kenji-miyake

@satoshi-ota It's resolved by https://github.com/autowarefoundation/autoware.universe/pull/1040.

@satoshi-ota It's resolved by #1040.

@kenji-miyake I see. Thanks for your quick comments !

It is hard to find taget traffic light id when we use this plugin in huge environment that has a lot of traffic light like odiaba. :sweat_smile:
So, could you modify the implementation to sort these id ?

I'm trying out this setting https://stackoverflow.com/questions/50789605/how-to-add-a-scrollbar-to-a-qcombobox

I'm changing the box to a scrollable one and sorting the IDs. I'm also trying to limit the size of the box if possibl

e

I'm changing the box to a scrollable one and sort the IDs. I'm also trying to limit the size of the box if possible
How do you think about this ?

Great :+1:

I'm also trying to limit the size of the box if possible.

Yeah, I think that it is nice idea, too.

@satoshi-ota I couldn't find the resource for how to set fixed size of item list in combo box (maybe I can set fixed number height in px units, but I do not think it's a good idea), but anyway the IDs are sorted and the user will be able to scroll up/down to find desired traffic light ID.

@satoshi-ota I couldn't find the resource for how to set fixed size of item list in combo box (maybe I can set fixed number height in px units, but I do not think it's a good idea), but anyway the IDs are sorted and the user will be able to scroll up/down to find desired traffic light ID.

OK, it looks good to me :+1:


Added tests for complex types in ArgminDot impl of vec types

Codecov Report
Base: 92.42% // Head: 92.55% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (67d0e67) compared to base (f4d5aee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   92.42%   92.55%   +0.12%
==========================================
  Files         119      119
  Lines       18137    18273     +136
==========================================
+ Hits        16764    16912     +148
+ Misses       1373     1361      -12

Impacted Files
Coverage Δ

argmin-math/src/vec/dot.rs
100.00% <100.00%> (+4.74%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Front and Retro Camera issues

Hello,
i was searching a solution for automatic retro camera selection but i have found many solutions, so i try to organize all the issues related to the topic:
Front or Rear Camera Selection ----> https://github.com/jeromeetienne/AR.js/issues/86
Upgrade Browser or use a Polyfill --> https://github.com/jeromeetienne/AR.js/issues/96
Automatic Camera Selection -------> https://github.com/jeromeetienne/AR.js/issues/178 , https://github.com/jeromeetienne/AR.js/pull/180
Related to https://github.com/jeromeetienne/AR.js/issues/74 , https://github.com/jeromeetienne/AR.js/issues/86 , https://github.com/jeromeetienne/AR.js/issues/96, https://github.com/jeromeetienne/AR.js/issues/117 , https://github.com/jeromeetienne/AR.js/issues/178 , https://github.com/jeromeetienne/AR.js/pull/180 , https://github.com/jeromeetienne/AR.js/issues/198

I close as not a real issue, but thanks for this, it will be helpful for people struggling with this :)


Spelling Mistake in District Name [West Bengal]

Describe the bug
The district 'Darjeeling' in West Bengal is wrongly spelt as 'Darjiling'.
To Reproduce
Steps to reproduce the behaviour:

Go to the home page.
Click on the state of West Bengal.
Scroll to the topmost district.
See error

Expected behaviour
The name of the district should be 'Darjeeling'.
Screenshots

Desktop (please complete the following information):
All versions.
Smartphone (please complete the following information):
All Versions.

Please assign it to me. Have already fixed this.

@shuklaayush Kindly check PR #479

This should be resolved by fix #521


gui-for-clash: init at 1.8.9

GUI.for.Clash, A GUI program developed by vue3 + wails. https://github.com/GUI-for-Cores/GUI.for.Clash

Related https://github.com/NixOS/nixpkgs/issues/287770

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Bot-wxt1221 Could you test it locally?

Works for me.

@Aleksanaa


Need help with assigning weights to words or labels in BGEM3FlagModel for dense vector creation

Hello everyone, I really need your help. How can I assign weights to words or labels when creating dense vectors using the BGEM3FlagModel? For example, I have the phrase: "apple iphone 14 pro red." When creating dense vectors, I want the words "iphone" and "14" to have higher weights compared to other words. This is so that when searching for similar models, the emphasis is on "iphone 14". Thank you!

A possible method is to add these words at the beginning of the sentence. It can even be repeated multiple times to increase the weight.


Hotfix: GAE computation for TRPO/PPO1/GAIL

fixes #385
rename some keys so they are more meaningful

~After some quick test, I did not see any big differences in the performance.~
EDIT: after more tests, it looks like there are improvements in performance =)

@hill-a @AdamGleave @erniejunior I consider this one as a hot fix, so I would appreciate if one of you could review it soon ;).


Modify filename PR_TEMPLATE to CONTRIBUTING.md

An Explanation of Your Changes :speech_balloon:
Change the PR_TEMPLATE name to CONTRIBUTING, makes more sense

@ivannieto the reason it's PULL_REQUEST_TEMPLATE is because this is what is automatically rendered in the PR body when someone opens a pull request. It has to be called PULL_REQUEST_TEMPLATE for GitHub to be able to do this. Renaming the file to CONTRIBUTING would mean we no longer have this functionality. Happy to reopen if I have missed what you mean.

Oh, I see now how it works. BTW, It's somewhat confusing to not have a main CONTRIBUTING file. Maybe it's my perspective... 👍


Work item service refactored and unit tests added

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"
Mandatory

[ ] What does this PR do?

[ ] What issue/task does this PR references?

[ ] Are the tests Included?

Optional

[ ] Is the documentation Included?

[ ] Are the Release Notes included?

[ ] @mention(s) to expected reviewer(s) included

Can one of the admins verify this patch?

[test]

Somehow this PR is triggering a build, thus closing it.


Implement type hints for most functions

Implemented type hints. Couple are missing, but most functions are covered.
Requires Python 3.11+, so I took it upon myself to tag a 3.0.0 version in the changelog, as 2.0.0 supports 2.7+.
Fixed some wrong documentation types and names.
Removed python setup.py install instructions and added venv req flag to pip calls.
Also bumps up the requests dependency, so this supersedes #6.

@santiher Are you interested in continuing to maintain this project? I see last commit was 5 years ago.
I could take over this repo + PyPI if you're uninterested, better that than having to fork it :)


Cupy support in anndata

Splitting out from:

https://github.com/scverse/anndata/issues/355

Mostly implemented in

https://github.com/scverse/anndata/pull/1066

Opening this issue to discuss what else is needed for cupy support in anndata.
Priority follow up

[ ] "How to" example of usage

Other

[ ] "How to" example of direct GPU IO
[ ] Look into refactoring for more array-api support

Is this in the case where the scipy matrix has 64 bit index types? I think this would make sense there.

Yes there are 64 bit indptr for scipy matrices. If you go above the limit the indptr will become negative and you run into issues with converting the matrix etc.

What would this do? I was hoping that it would let us move things between CPU and GPU, but I don't think that's consistent with the semantics of cupy and numpy. Maybe it can be handled on the array level for now?

Indeed, we could let the user handle this, and the syntax would likely be more similar to pytorch. I really came to like a simple oneliner that moves everything over to RAM and not manually converting every layer.

For now could this just be "whether it's a cupy type or not"? I don't think I'd want to add a property to the AnnData object for this if you can do isinstance.

Using isinstance is entirely sufficient. I was just considering the scenario where someone wants to run a scanpy function on GPU AnnData or an rsc function with a scipy matrix. I'm currently making all my rapids-singlecell functions compatible with CPU AnnData and was contemplating such a flag.

@ivirshup I have a PR (https://github.com/scverse/rapids_singlecell/pull/42) ready to go once the anndata 0.10.0 comes out. The only things I'll have to do is rerun the notebooks with benchmarks and depreciate cunndata and change the docs with the usage principle. So I think I can have the updated out at most 2 days after you publish.

That’s awesome!

I'll split the others off into new issues, but will point to rapids-single cell for usage examples. Almost closable

You can point to the documentation notebooks in https://rapids-singlecell.readthedocs.io/en/latest/notebooks.html


[Proof of concept] Circuit profiling for foreign field elliptic curve scaling

This PR adds a simple test for elliptic curve scaling using the foreign field gates in kimchi.
Since these gates are not currently implemented, they is simulated with Zero gates, for the purposes of generating the circuits and counting the constraints.
Checklist:

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

@mrmr1993 @rbonichon can we move this back to the backlog?

This was a PoC. Closing.

damn, I wasn't aware of this gem!
the Zero constraint actually seems useful, but ok easy to add when needed


Make deployment artifiacts with a consistent name pattern.

Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

@leseb @gman0 @Madhu-1 ptal

@Madhu-1 @ShyamsundarR comments are addressed. PTAL .Thanks.

@humblec can you send this PR to master branch instead of csiv1.0 branch?

Changing the PR base branch has brought in more changes than just what was intended in the PR (or I am mistaken). The file list and commit list are now showing more deltas than required.
@humblec please address the same, for now marking this as DNM as I do not want the bot to merge the same.

@ShyamsundarR rebased or removed unwanted commit, this should be good now! PTAL


Nightscout back fill configs

Nightscout doesn't automatically back fill CGM data even when Share does.  If your routine includes gaps in transmitter connectivity and data uploads, this may affect your calculations.
I suggest that we include instructions on best practices in configuring NS to backfill.  Opening issue to discuss what the best practice recommendations would be.

I use @ecc1 https://github.com/ecc1/backfill with a Dexcom G4. Don't know if it also works for G5. I am planning to write a buffered-curl command for CGM=G4-upload that will also upload missed cgm later when the rig is online.

👍 added https://github.com/openaps/docs/pull/852 into the docs

Closing, since referenced in the docs.


cheeseburger.py fails to load

The cheese burger prompt doesn't load

Any errors?

Any errors?

yeah; failed to load cheeseburger.py

fixed

Why did I do this 😭


Use pinned maven dependencies in this repository

Try running REPIN=1 bazel run @unpinned_maven//:pin and force push with updated maven_install. It seems that all CI fails on this.


[CI Problem] Merge to main branch is not blocked on Github Actions

Looking at this file, it seems that we only block merge on Jenkins flows. This issue has caused problem before where the committer missed Github Action builds and accidentally merged a PR.
Since we are using more Github Action flows, we should block merging based on those actions.
cc @driazati @gigiblender

maybe just add  tvm-ci/pr-head in the end?  https://github.com/apache/tvm/commit/7bc90ef6f327bbfb12d09a2d7b7b11ec0ec233a5


Add example in Schedule docs

Objective
Fixes #3980
Solution
Added examples to show how to run a Schedule, one with a unique system, and another with several systems

Changelog

Added: examples in docs to show how to run a Schedule

bors r+


Fix minor typo

@radujipa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@radujipa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @radujipa.

Looks good; thanks @radujipa.


Searching for nodes where query must match a value in an array in the body

I'm looking to do something like this
from simple_graph_sqlite import database as db
dbfile = "db.sqlite"

db.initialize(dbfile)

db.atomic(dbfile, db.add_node({'name': 'foo', 'type':['company', 'start-up']}, 1))
db.atomic(dbfile, db.add_node({'name': 'bar', 'type':['cat', 'apple']}, 1))

db.atomic(apple, db.find_nodes({'type': 'apple'}, db._search_like, db._search_starts_with))

But I don't think the last statement works

Hi @rajarshi
You're right, the current search statements do not introspect the json object correctly; looking at the sqlite json docs, it seems that statement need to use json_each.value LIKE ... or json_tree.type IN ... instead.
I can tinker with this some more, to see how to introduce those; ideally, I'd like to include them as statements in the sql so they're usable by any programming language that supports sql bindings, rather than coming up with a python-specific solution.

Got it, thanks

Hi @rajarshi
I've recently revamped the search functions for allow for this; see the test and the updated example for how it works now, using the search templates.


Config file load - init.d

Hi Team,
Apparently the init.d script dont take the config from /opt/influxdb/current/config.toml but from /opt/influxdb/shared/config.toml.
is it normal it's based into shared folder ? what that will be keep in 0.9 also ?
Julien.

No clear action to take.


Better error diagnosis

Hi, thank you for a nice library.
Version of Boost
1.75
In general, when I input 500kB of data into computer and it just says "syntax error", that make me wanna throw a brick at computer.
I would like information from parser which is enough to produce message like this:
Syntax error at line 20:
{ "foo, 100 }
      ^-----

So far, only information I can get from parser seems to be an error code. I want location (line and column). Calculating line number from position after received a parse error would be difficult, considering escaped newline in strings.
Parser will need to track line number and beginning of line during parsing to produce such information. It might hurt benchmarks a bit, but I believe it is necessary cost.

On second thought, JSON can't have newline in string. That means only position will do.

And I just found out parser::write seems to return the position error occur.
So I can have enough information. I am going to close this.


panic: invalid error map[code:1 message:The parameter at 1 has wrong type

It can successfully add the file and download it, but with this error, of course no status back after running into the error.

the same issue, resolved? @distance00

I'm trying this library for the first time with the README example, and I'm also getting this error.
The error comes from the Client TellStatus method and the aria2 log only has these (not very useful) log messages:
2022-02-23 21:24:54.735307 [INFO] [../../aria2-release-1.36.0/src/rpc_helper.cc:103] Executing RPC method aria2.tellStatus
2022-02-23 21:24:54.735384 [DEBUG] [../../aria2-release-1.36.0/src/RpcMethod.cc:101] Exception caught
Exception: [../../aria2-release-1.36.0/src/RpcMethodImpl.h:67] errorCode=1 The parameter at 1 has wrong type.
2022-02-23 21:24:54.740051 [DEBUG] [../../aria2-release-1.36.0/src/WebSocketSession.cc:109] Exception caught

Any idea of what might be wrong?

I'm trying this library for the first time with the README example, and I'm also getting this error.
The error comes from the Client TellStatus method and the aria2 log only has these (not very useful) log messages:
2022-02-23 21:24:54.735307 [INFO] [../../aria2-release-1.36.0/src/rpc_helper.cc:103] Executing RPC method aria2.tellStatus
2022-02-23 21:24:54.735384 [DEBUG] [../../aria2-release-1.36.0/src/RpcMethod.cc:101] Exception caught
Exception: [../../aria2-release-1.36.0/src/RpcMethodImpl.h:67] errorCode=1 The parameter at 1 has wrong type.
2022-02-23 21:24:54.740051 [DEBUG] [../../aria2-release-1.36.0/src/WebSocketSession.cc:109] Exception caught

Any idea of what might be wrong?

My first suspicion was that it's simply a change in the RPC protocol, but I took a look at the documentation and that doesn't appear to be the case. Can you verify that the gid you're passing to the method is valid?
Also, which keys are you requesting?

I'm not yet sure how to see what you've asked.
I've put the example at https://github.com/rgl/use-go-arigo. Can you please take a look?

Ah I see you're using the download helper method. The gid looks good so I don't think that's the issue.
We might be dealing with a serialization issue.
Can you try the following code:
gid, err := c.AddURI(uris, options)
<-gid.WaitForDownload()
status, err = gid.TellStatus("status")

This is basically what c.Download does internally but instead of running gid.TellStatus() it's gid.TellStatus("status"). If this works it means the other case is encoded to the wrong JSON type (perhaps null instead of []).
Please bear in mind that this library has been unmaintained for at least a year so you might need to fix a few things to get it working again.
It looks like the aria2 RPC protocol hasn't changed so the issues are probably language or library related.

That worked!

That worked!

Cool, in that case the fix should be pretty straightforward, if you're interested.
This line here:
https://github.com/myanimestream/arigo/blob/master/client.go#L215
Needs to check whether args is nil and if it is, it should allocate an empty slice and return that instead.
Right now the nil value is passed through which results in the parameter sent to aria being null instead of [], hence the type error.

BTW, the issue should also go away if you activate authorization on aria2, because - as you can see in the snippet above - there's always at least one parameter for the token.

Cool, in that case the fix should be pretty straightforward, if you're interested.

I'm interested!
Will you commit a fix for it? Or do you want me to do a PR with that change?
Oh... and thanks for the help!

I currently don't have the setup to test the change so I would very much appreciate a pull request :)

Its too late today, but I'll do it tomorrow or so.
Is there a CI for this repository? Does it make sense to migrate (or create) it to GitHub Actions?
BTW, is there any chance to publish a new version of this package? v0.1.0 does not have ExitStatus.String method.

This repo doesn't have any kind of CI (unless I forgot). Adding github actions would be a welcome addition.
As for the new version, seems like a good point to release a new version after the fix.

I've added the GitHub Actions CI build at https://github.com/myanimestream/arigo/pull/5. You can see an example at https://github.com/rgl/arigo/actions.


⚠ BCR Bot has degraded performance

In 88be6ff, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 988 ms

Resolved: BCR Bot performance has improved in 2b8d06f.


Update sql-database-elastic-scale-shard-map-management.md

Adding information about PowerShelll module.

Hi @SilviaDoomra, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@sidneyh
FYI


unable to modify an instance

I am degrading an instance, as it will only be used for testing purposes. When I run plan/apply I see the following change diff:
  # module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0] will be updated in-place
  ~ resource "aws_db_instance" "this" {
        address                               = "db-1.1111.ap-southeast-2.rds.amazonaws.com"
        allocated_storage                     = 20
        allow_major_version_upgrade           = false
        apply_immediately                     = false
        arn                                   = "arn:aws:rds:ap-southeast-2:1111:db:db-1"
        auto_minor_version_upgrade            = true
        availability_zone                     = "ap-southeast-2c"
        backup_retention_period               = 1
        backup_window                         = "03:00-06:00"
        ca_cert_identifier                    = "rds-ca-2019"
        copy_tags_to_snapshot                 = false
        db_subnet_group_name                  = "db-1-1111"
      ~ deletion_protection                   = true -> false
        enabled_cloudwatch_logs_exports       = []
        endpoint                              = "db-1.1111.ap-southeast-2.rds.amazonaws.com:3306"
        engine                                = "mysql"
        engine_version                        = "5.7.26"
        final_snapshot_identifier             = "k8s-00-DeveloperEx-sydney-aws-db-1-final-snapshot"
        hosted_zone_id                        = "1111"
        iam_database_authentication_enabled   = false
        id                                    = "db-1"
        identifier                            = "db-1"
      ~ instance_class                        = "db.t2.medium" -> "db.t3.small"
        iops                                  = 0
        kms_key_id                            = "arn:aws:kms:ap-southeast-2:1111:key/1111"
        license_model                         = "general-public-license"
        maintenance_window                    = "mon:00:00-mon:03:00"
        max_allocated_storage                 = 0
        monitoring_interval                   = 0
      ~ multi_az                              = true -> false
        option_group_name                     = "db-1-1111"
        parameter_group_name                  = "db-1-1111"
        password                              = (sensitive value)
        performance_insights_enabled          = false
        performance_insights_retention_period = 0
        port                                  = 3306
        publicly_accessible                   = false
        replicas                              = []
        resource_id                           = "db-1111"
        security_group_names                  = []
        skip_final_snapshot                   = true
        status                                = "available"
        storage_encrypted                     = true
        storage_type                          = "gp2"
        tags                                  = {
            "Environment" = "staging"
            "Name"        = "db-1"
            "eksCluster"  = "k8s-00-DeveloperEx-sydney-aws"
        }
        username                              = "admin"
        vpc_security_group_ids                = [
            "sg-1111",
        ]

        timeouts {
            create = "40m"
            delete = "40m"
            update = "80m"
        }
    }

So it should change the instance size and make it not multi az.
I then see:
module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0]: Modifying... [id=db-1]
module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0]: Still modifying... [id=db-1, 10s elapsed]
module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0]: Still modifying... [id=db-1, 20s elapsed]
module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0]: Still modifying... [id=db-1, 30s elapsed]
module.cluster.module.db_1.module.db_instance.aws_db_instance.this[0]: Modifications complete after 31s [id=db-1]

but I can quiet clearly see in the console, nothing has changed.

ah, ok. Its 'pending modification'....

oh, I see. Apply immediately...
go me.


fixIframeContentWindow method writes to log "TypeError: Cannot redefine property: createElement"

fixIframeContentWindow method writes to log "TypeError: Cannot redefine property: createElement".
To Reproduce
Run non-headless and load https://www.example.com.
Expected behavior
No warnings in console log.
System information:

OS: MacOS
Node.js v16.14.0
Puppeteer v15.1.0
fingerprint-injector v2.0.6

For me the issue happens in non-headless mode, so I'm not sure how it works in the headless mode.
I haven't seen an issue with fixPluginArray, but since both fixIframeContentWindow & fixPluginArray methods are called from the runHeadlessFixes method, I wonder if the issue in the first place is that the runHeadlessFixes method is being called in non-headless mode too.
In the fixIframeContentWindow method, the issue is basically this line _iframe.srcdoc = newValue where srcdoc, which is set with writable: false (read only), fails to receive a new value.

Sorry for taking so long, this issue must have slipped my attention! Unfortunately, I didn't manage to replicate this issue, but I just got rid of the warning message at the very least. The headless fixes were made to be "idempotent" - in a way that they don't do anything if run in headful mode. I'll close this issue, but will keep an eye on this - and as always - feel free to reopen it if unsure abt sth :)


how to config Drainage simulation control ?

Dear Dr. Sedahmed ,
Thanks for your work !  I am doing some multiphase flow study now with MF-LBM-CUDA. Your examples is Imbibition, it works well and run fast, but the drainage seems not good. it drainage slow and finally there is only a little process. Finally, the non-wetting fluids satuation is only 3%, i want to know how to config a   Drainage simulation control? or could you show me more information of ' simulation control '

this is the txt file :
##
#          CONTROL FILE FOR MULTIPHASE FLOW SIMULATION IN MF-LBM                #
##
#=========================== simulation_status ====================================
value stored on job_status.txt
new_simulation                - new simulation
continue_simulation           - continue previous simulation
simulation_done               - previous simulation is finished. stop
simulation_failed             - previous simulation failed. stop
simulation_reached_max_step   - previous simulation reached maximum step. stop
else                          - wrong status. stop
#=========================== simulation setup =====================================
Initial fluid distribution option:
1 - fluid1 (nonwetting phase) at inlet: drainage
2 - fluid2 (wetting phase) at inlet: imbibition
3 - a fluid1 (nonwetting phase) drop attached to y=1: contact angle measurement
4 - a fluid2 (wetting phase) drop attached to y=1: contact angle measurement
5 - a fluid1 drop located in the center of the domain: surface tension measurement
6 - fluid1 and fluid2 raondomely distributed in the pore space with desired fluid1
saturation: steady state relative perm measurement
0 or else - error!
initial_fluid_distribution_option 1
Benchmark_cmd:
0 - regular simulation
1 - benchmarking simulation (obtain computational performance in MLUPS)
benchmark_cmd 0
Necesssary modifications for extreme large simulations:
nxglobalnyglobalnzglobal may be too large.
parallel I/O for visualization files are needed.
recommended for grid points > 1 billion.
0 - no; 1 - yes
extreme_large_sim_cmd 0
Breakthrough check option:
currently only works for drainage simulation by detecting nonwetting phase
fluid1 near outlet.
0 - do not check; 1 - check
breakthrough_check 0
Steady state option:
0 - non-steady state simulation (complete based on target injected PV or ntime_max)
1 - steady state simulation (complete based on capillary pressure)
2 - steady state simulation (complete based on phase field)
3 - steady state simulation (complete based on saturation)
steady_state_option 3
Convergence_criteria:
used in steady state simulation.
default is 1d-6, use 1d-4 or 1d-3 instead for steady-state-option 3 to reduce simulation
time and deal with fluctuation
convergence_criteria 1e-4
output field data precision (simulation is always double precision):
0 - single precision; 1 - double precision
output_fieldData_precision_cmd 0
Modify_geometry_cmd:
0 do not modify geometry; 1 modify geometry in the code (hard coding, Misc.cpp)
modify_geometry_cmd 0
Use external geometry cmd:
0 - no; 1 - yes
external_geometry_read_cmd 1
choose type size of dimension variables saved in the geometry binary file:
4 - 4 bytes (int, uint, ..etc.); 8 - 8 bytes (long long, unint64, ...etc.)
(0) would be used in relatively small geometries (nxGlobalnyGlobalnzGlobal < 384^3), while (1) would be used in relatively large geometries (nxGlobalnyGlobalnzGlobal >= 384^3)
geometry_dims_type_size 4
Geometry preprocess cmd:
0 - process the geometry boundary infor during the simulation (not recommended for
large simulations);
1 - load external pre-processed geometry boundary info data
geometry_preprocess_cmd 0
Place a porous plate along the flow direction:
0 - no; 1 - block fluid1; 2 - block fluid2
example 1: injecting fluid2 (wetting) during imbibition cycle and block fluid1 from
exiting the inlet.
example 2: injecting fluid1 (nonwetting) during drainage cycle and block fluid1 from
exiting the outlet.
This option should only be used when you fully understand how it works.
porous_plate_cmd 2
Location of the porous plate along flow direction (Z):
placing the porous plate a couple of lattices before or after rock sample is recommended.
example 1 (near outlet): Z_porous_plate = inlet_buffer_layers + nxsample + 2
example 2 (near inlet): Z_porous_plate = inlet_buffer_layers + 1 - 2
only effective when porous_plate_cmd = 1
This option should only be used when you fully understand how it works.
Z_porous_plate 252
Change inlet fluid phase for Z < initial_interface_position:
0 - do nothing
1 - 100% fluid1
2 - 100% fluid2
Use case:
After the completion of the drainage simulation, one can use current fluid distribution
as the starting point to perform imbibition simulation. To reduce the simulation time, one
can eliminate unecessary fluid displacement in buffer zone and numerical artifacts from
open boundary conditions by change the inlet fluid to pure fluid2 (wetting phase).
This option should only be used when you fully understand how it works.
change_inlet_fluid_phase_cmd 0
#=================================  geometry ======================================
Lattice dimensions nxGlobal, nyGlobal, nzGlobal, must be integral multiple of
npx, npy and npz, respectively
#lattice_dimensions 240,240,260
nxGlobal	102
nyGlobal	102
nzGlobal	122
inlet/outlet zone excluded in the bulk properties calculation
1<=k<=n_exclude_inlet and nzglobal-n_exclude_outlet+1<=k<=nzglobal
does not affect simulation
#excluded_layers 10,10
n_exclude_inlet		10
n_exclude_outlet	10
domain_wall_status at xmin and xmax, status: 1 - wall; 0 - no wall
#domain_wall_status_x 1,1
domain_wall_status_x_min	1
domain_wall_status_x_max	1
domain_wall_status at ymin and ymax, status: 1 - wall; 0 - no wall
#domain_wall_status_y 1,1
domain_wall_status_y_min	1
domain_wall_status_y_max	1
default flow direction, domain_wall_status at ymin and ymax, status: 1 - wall; 0 - no wall
#domain_wall_status_z 0,0
domain_wall_status_z_min	0
domain_wall_status_z_max	0
periodic BC indicator, 1 periodic, 0 non-periodic
currently, x direction can not apply periodic BC
#periodic_indicator 0,0,0
iper	0
jper	0
kper	0
#==================================== CUDA information ========================================
Number of threads in a thread block, in each direction
Preferred to be a multiple of 32 (warp size)
block_Threads_X		128
block_Threads_Y		1
block_Threads_Z		1
#===================================== MPI information ========================================
mpi process numbers along each axis: npx, npy, npz
x direction domain decomposition disabled: npx = 1
#MPI_process_num 1,1,1
npx	1
npy	1
npz	1
Number of halo nodes used in overlaping computation and communication.
x direction domain decomposition disabled and must be 0
This option should only be modified when you fully understand how it works.
#MPI_async_layers_num  0,4,4
ix_async	0
iy_async	4
iz_async	4
#=============================== fluid property ===================================
fluid viscosity
fluid1_viscosity 0.04
fluid2_viscosity 0.4
surface tension
surface_tension 0.03
Contact angle (measured through fluid 2):
It should always be less than 90 degree due to the particular numerical scheme used in this
code to form desired contact angle. Therefore, fluid 1 is always the nonwetting phase, while
fluid 2 is always the wetting phase.
Imbibition simulation can be performed by injecting fluid 2 instead of fluid 1
theta 20
beta in RK recolor scheme - control the sharpness of the interface (from 0.9 to 0,95 is recommended)
RK_beta 0.95
#============================= injection conditions ===============================
inlet_BC selection (overridden by z (flow) direction periodic BC): 1-velocity; 2-pressure
inlet_BC 2
outlet_BC selection (overridden by z (flow) direction periodic BC): 1-convective; 2-pressure
outlet_BC 2
Injecting fluid saturation:
1: pure fluid1 injection (drainage)
0: pure fluid2 injection (imbibition)
0<sa<1: mixed injection
saturation_injection 1.0
Option to stop simulation based on reaching target fluid injection:
It is enabled by modify ntime_max based on injection rate.
The value is in PV (pore-volume).
It is not very precise considering LBM compressibility error.
A negative value will disable target_inject_pore_volume – simulation continues until existing ntime_max
target_inject_pore_volume -1.0
Initial interface position along z direction or initial drop radius for drop test
initial_interface_position 8.0
Capillary number, based on viscosity of fluid1
capillary_number 100e-6
initial value of body force or pressure gradient along z direction
body_force_0 1e-4
override loading inlet density value from the checkpoint file and use a new value based on the pressure gradient
rho_in_new	1
use the BC density value for the outlet density
rho_out_BC	0
Target fluid1 saturation:
used in steady state relative permeability measurement
randomly distribute fluid1 and fluid2 with target fluid1 saturation
target_fluid1_saturation 0.4
#================================== timers ========================================
timer: max iterations, will be modified if target_inject_pore_volume > 0
max_time_step 1000000
timer: max iterations for benchmarking
max_time_step_benchmark 100
timer: when to output detailed visualization data - overridden by d_vol_detail if d_vol_detail>0
ntime_visual 5000000
timer: when to output animation (phase info only) data - overridden by d_vol_animation if d_vol_animation>0
ntime_animation 10000
timer: when to output bulk property data - overridden by d_vol_monitor if d_vol_monitor>0
monitor_timer 10000
timer: when to output profile data along flow direction (Z)
monitor_profile_timer = monitor_profile_timer_ratio * monitor_timer
monitor_profile_timer_ratio 5
timer: gaps used to record computation time
it is also used to check the checkpoint data saving status
computation_time_timer 10000
timer: when to display time steps
display_steps_timer 10000
timer: interval to save checkpoint data based on wall clock time, in hours
checkpoint_save_timer 1.0
timer: time interval used to save secondary checkpoint data based on wall clock time, in hours
use a large value to reduce the storage size
checkpoint_2rd_save_timer 5.5
timer: simulation duration in hours
save checkpoint data and exit program after simulation_duration_timer
simulation_duration_timer 168
timer: when to output animation data - based on injected pore volume
only effective for constant velocity BC, disabled if it is a negative value
d_vol_animation -0.05
timer: when to output full field data - based on injected pore volume
only effective for constant velocity BC, disabled if it is a negative value
d_vol_detail -1.0
timer: when to output bulk property data - based on injected pore volume
only effective for constant velocity BC, disabled if it is a negative value
d_vol_monitor -0.01

Dear xiangWu-WW,
Thank you for reaching out. I hope the code is helpful for your studies.
The drainage displacement process needs a larger pressure gradient than the imbibition displacement process. Hence, to reach a larger fluid saturation, the pressure gradient must be increased. To do so, you must modify the value of "body_force_0" in the simulation control file (simulation_control.txt) line 220.
Also, please take a look at lines 203 & 209 in the file (Init_multiphase.cpp), where the pressure gradient is related to the input density value of the boundary condition. Those lines will indicate the "body_force_0" suitable for your simulation. For instance, in a simulation domain of length (nzGlobal= 122), try the pressure gradient value (body_force_0) in the order value of 1-e3.
Regards,

Dear xiangWu-WW, 亲爱的 xiangWu-WW，
Thank you for reaching out. I hope the code is helpful for your studies.感谢您的联系。我希望该代码对您的学习有所帮助。
The drainage displacement process needs a larger pressure gradient than the imbibition displacement process. Hence, to reach a larger fluid saturation, the pressure gradient must be increased. To do so, you must modify the value of "body_force_0" in the simulation control file (simulation_control.txt) line 220.排水驱替过程需要比渗吸驱替过程更大的压力梯度。因此，要达到更大的流体饱和度，必须增加压力梯度。为此，您必须修改模拟控制文件 （simulation_control.txt） 第 220 行中 “body_force_0” 的值。
Also, please take a look at lines 203 & 209 in the file (Init_multiphase.cpp), where the pressure gradient is related to the input density value of the boundary condition. Those lines will indicate the "body_force_0" suitable for your simulation. For instance, in a simulation domain of length (nzGlobal= 122), try the pressure gradient value (body_force_0) in the order value of 1-e3.另外，请查看文件（Init_multiphase.cpp）中的第203行和第209行，其中压力梯度与边界条件的输入密度值有关。这些行将指示适合您的模拟的 “body_force_0”。例如，在长度为 （nzGlobal= 122） 的仿真域中，尝试以 1-e3 的顺序值计算压力梯度值 （body_force_0）。
Regards, 问候

Dear Dr. sadahmed,
Thanks for your timely reply!   It works well, amazine!
Another question: how can i change the viscosity in the LBM to fit the real physics, like the viscosity of brine water is 1 cp, and the ScCO2 is 0.03 cp?  Addtionally, i attempt to set the viscosity of fluid 1 as 0.004 and fluid 2 is 0.4, it does not work, i think should i change the surface tension or the caplliary number, i tried, but it does not work also.
Finally, My GPU is RTX 3060（6GB）, but the GPU memory is only used 388M , i tried improve the block_Threads, but it does not work too, the  product of X, Y and Z of block_Threads can only be less than 128.
Best regards.

Dear xiangWu-WW,
I am glad your drainage simulation now works.
Matching the physical viscosity ratio in LBM simulations will require matching the viscosity ratio in LBM with the physical viscosity ratio. However, please note that selecting small LBM viscosities such as 0.004 results in small relaxation times in the collision model and approaches the edge of the stability limit of the model. Very low relaxation times result in instabilities in LBM simulations. Hence, it would be better to select a higher viscosity value and try different fluid-1 & fluid-2 viscosity combinations to reach a stable simulation while keeping the targeted viscosity ratio of 100.
As for your final question on the (block_Threads) parameter, its size, and limitations are related to CUDA and the kernel properties. It has a maximum size in CUDA of 1024 threads (block_Threads_x * block_Threads_Y * block_Threads_z <= 1024). However, the maximum size is affected by the number of registers allocated for the kernel as well. Hence, for kernels with many registers, the maximum size is reduced (e.g., 128 threads, as you experienced).
Regards,

Dear Dr. sadahmed,
Thanks for your patient and timely reply again!
I kind of know what you mean, i know the relationship between viscosity and relaxation time.

I tried the parameter of Dr. Yu Chen,

but it warning that 'Simulation failed due to NAN of saturation or capillary number'

The fluid property like this :
#=============================== fluid property ===================================
fluid viscosity
fluid1_viscosity 0.339
fluid2_viscosity 0.009
surface tension
surface_tension 0.04
Contact angle (measured through fluid 2):
It should always be less than 90 degree due to the particular numerical scheme used in this
code to form desired contact angle. Therefore, fluid 1 is always the nonwetting phase, while
fluid 2 is always the wetting phase.
Imbibition simulation can be performed by injecting fluid 2 instead of fluid 1
theta 50
beta in RK recolor scheme - control the sharpness of the interface (from 0.9 to 0,95 is recommended)
RK_beta 0.95
#============================= injection conditions ===============================
inlet_BC selection (overridden by z (flow) direction periodic BC): 1-velocity; 2-pressure
inlet_BC 2
outlet_BC selection (overridden by z (flow) direction periodic BC): 1-convective; 2-pressure
outlet_BC 2
Injecting fluid saturation:
1: pure fluid1 injection (drainage)
0: pure fluid2 injection (imbibition)
0<sa<1: mixed injection
saturation_injection 1.0
Option to stop simulation based on reaching target fluid injection:
It is enabled by modify ntime_max based on injection rate.
The value is in PV (pore-volume).
It is not very precise considering LBM compressibility error.
A negative value will disable target_inject_pore_volume – simulation continues until existing ntime_max
target_inject_pore_volume 1.0
Initial interface position along z direction or initial drop radius for drop test
initial_interface_position 8.0
Capillary number, based on viscosity of fluid1
capillary_number 100e-6
initial value of body force or pressure gradient along z direction
body_force_0 1e-3
override loading inlet density value from the checkpoint file and use a new value based on the pressure gradient
rho_in_new	1
use the BC density value for the outlet density
rho_out_BC	0
Target fluid1 saturation:
used in steady state relative permeability measurement
randomly distribute fluid1 and fluid2 with target fluid1 saturation
target_fluid1_saturation 0.4
I think that i should change the viscosity according to my domain size and capillary number, but i do not know how to config that. Finally, to simulate  the viscosity of brine water is 1 cp and the ScCO2 is 0.03 cp in LBM, we only consider the viscosity ratio is OK?
Best regards!

Dear xiangWu-WW,
Viscosity ratio is only one of the parameters that you match in your simulation of a physical system. There are more parameters and conversion factors that you should set. Please check the following paper for a comprehensive guide on this topic.
https://www.researchgate.net/publication/384110993_Wetting_and_pressure_gradient_performance_in_a_lattice_Boltzmann_color_gradient_model
Regarding the warning and the simulation crash that you had, it could be due to a number of reasons, such as the geometry details, simulation parameters and boundary conditions. Also, it seems that the simulation crashed at the first simulation check, and that may indicate that it actually crashes much earlier due to many possible reasons. I would suggest reducing the interval of simulation checks to try monitoring the case closely before the crash. That may help you to investigate the reason. Also, I suggest starting with more simplified cases and testing your set of simulation parameters and boundary conditions before proceeding with a full porous media simulation and high viscosity ratios.

Dear Dr. sadahmed,
Thanks for your reply and your article, i learned a lot in it. I have three questions now.

Can i set real viscosity according to the surface tension ratio, like the picture:

Why the viscosity in Dr. Yu.Chen in MF-LBM is inversed? And is that too small?

3.During the imbibition, i simulated the different contact angle , does the finally water saturation decrease with the contact angle? The result is not. I want to how to explain it:

The follow pics contact angle is 10 30 50 70 90.

Best regards!

Dear xiangWu-WW,
I am glad you found the article helpful for your work.
Regarding your first question, yes you can start with assuming the LBM surface tension value, as the equations shown in the paper (40-44) are flexible and you can use them in different ways. But you may end up with relaxation time values that result in making the simulation unstable. I would suggest starting from investigating the physical system and determining the physical kinematic viscosity and the physical surface tension, then, assume a reasonable relaxation time, and that would result in obtaining the time conversion factor and LBM surface tension value. It could be an iterative process to obtain a stable set of simulation parameters, so keep trying with different sets of parameters. For the mentioned value of 10 for LBM kinematic viscosity, yes it could be a bit high, but again, that depends on the simulation case and the stability of the whole simulation, it may work in some cases.
Regarding your second question, the shown values of the LBM kinematic viscosities are indeed small, but I think in that paper it was intended to select such small values to demonstrate the high stability of the model. You don’t have to select the same set of parameters or such small values.
Regarding your third question, in the imbibition process, where the wetting fluid is displacing the non-wetting fluid, it becomes harder for the wetting fluid to invade the pores at the same capillary pressure as the contact angle increases (the non-wetting fluid becomes more wetting). Hence, the wetting fluid saturation is expected to decrease with increasing the contact angle. You can check the following paper for more details
https://www.researchgate.net/publication/358285695_An_improved_multicomponent_pseudopotential_lattice_Boltzmann_method_for_immiscible_fluid_displacement_in_porous_media
However, those physical effects may not be observed in your simulations due to the relatively small 3D simulation domain (100 x 100 x 100) and its relatively high porosity (as I hardly notice from the snapshots you provided). The domain size, scale, and details may not be enough to capture the imbibition physical phenomena.
Regards,


Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[X] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: KDE e.V.
Publisher Url: http://kde.org
Package Name: KDE.Elisa.Release
Description: http://apps.kde.org/elisa
Package Version: master-936
Installer URL: http://binary-factory.kde.org/view/Windows 64-bit/job/Elisa_Release_win64/lastSuccessfulBuild/artifact/elisa-21.12.0-976-windows-msvc2019_64-cl-sideload.appx
Current Package Identifier (for new versions): master-936

Duplicate of #39190
Please post your KDE requests here


added @types example

this fixes #867

Other information:

in response to @gdi2290 comment on #867

perfect, thanks!


how does the location field work?

does the posting location field require coordinates or can I just enter any text I want or how does it work?

It does not work yet, didn't get around to it


Creating the details of tracks, on click as shown in Mockup.

Consider this for reference https://github.com/fossasia/open-event-webapp/issues/268

@championswimmer  Solved here #291


no-shadowed-variable breaks with exports from namespaces

Bug Report

TSLint version: 5.7
TypeScript version: 2.5
Running TSLint via: VSCode

TypeScript code being linted
export namespace Foo {
  export const ANSWER = 42;
}
export const ANSWER = Foo.ANSWER;

with tslint.json configuration:
"no-shadowed-variable": true

Actual behavior
Getting
[tslint] Shadowed name: 'ANSWER' (no-shadowed-variable)
const Foo.ANSWER: 42

Expected behavior
No error.

@ajafff's options for disabling the check for some cases also doesn't seem to cover this case. I cannot silence the error from above.

I'm also running into this now. Is this a regression?

I'm stuck with an ancient version of tslint because of this.

This is basically a duplicate of #3078. The option requested there will also fix this issue. I'll submit a PR shortly.


made stickers on search query clickable

Its a bug in my code. Writing another jquery is bad for performance. I'll fix the bug soon.


Timeout between each click event

Hi,
I've wanted to ask - if there is a possibility to slow down click events? I don't want to use regular time.sleep() methods, but maybe configure this in driver.
I have already added implicit.wait for 5 seconds - but still my tests are trying to click buttons before even loading. Or maybe should I try to use "EC.presence_of_element_located" before any click events.

Yes


Respect canonical predicate direction

Most details in #475. Currently, BTE responds using query direction. If it's not overly complicated, we should assemble our response to use the Biolink canonical direction for predicates.

Copied from internal Slack:

Jackson: BTE is supposed to respond in canonical direction, but currently just responds in query direction. This means that we must have canonical templates until we can start assembling responses in canonical direction, which is a relatively low-priority fix.

Andrew: Identified by Tyler at today's standup meeting. Agreed that this is a low priority issue, and that the simple change of adjusting the creative mode templates is more than sufficient for the moment...

Colleen: I'm providing what I remember as the reasons why we decided not to bother with “always return canonical predicates”.
I remember it as being a super confusing/hard problem.

Colleen

we previously decided not to care about canonical predicate direction since it could mean that some KG Edges are in opposite directions of the corresponding QEdge. Which makes results binding and edge-directionality all sorts of messed-up

At least…that's what I remember? Theoretically people won't give QEdges that result in non-canonical predicates. However, I doubt that the situation I described above never happens. Like if you ask for Gene X -> Disease (no predicate). Is it true that the KG Edges (part of answers/results) will only be canonical predicates? I think it could easily be non-canonical predicates if one has to stick to that QEdge direction (Gene X affected_by Disease Y)

Plus. The flipping of some Edges to fit canonical predicates….would it negatively affect the ability to go from one hop to another (confusing input with output, subject with object) ?

One way I can see “canonical predicate only” responses code working is if:

We do it at the end (like maybe after result assembly). That would allow our current code to do its thing without bugs / worrying about flipping records / edges
We could process the biolink-model and have an object where the keys are non-canonical predicates and the values are the inverses (the canonical predicates)
Then go through all the KG Edges. If the predicate for a KG Edge is a non-canonical predicate (matches a key), replace it with the canonical predicate (value) AND flip the subject and object of the Edge.

I think this allows us to mutate any Edges with the canonical-predicate problem without adversely affecting query execution/results assembly

Andrew:

Colleen, I think your other notes here are about how we enforce using canonical predicates, regardless of what's stated in the query?  If yes, this is a very very very low priority at the moment.  Feel free to add notes to #476 that Jackson created, but I don't think we need to discuss/brainstorm further until we actually get around to addressing it.  Please correct me if I'm missing something...

From Jackson / me convo 2022-10-19:

having edge-attributes for the original subject/object names and relationship could be useful when we move to canonical directions. This can be through x-bte annotation, but coding could provide original subject/object IDs and biolink-model predicates...

Our policy is that we'll respect whatever direction we're given; In terms of Translator requirements: We'll never receive a non-canon direction request, so we'll never return a non-canon direction answer.


Added recursive lookup to SPF advice

Added advice for SPF:
-DNS lookup limit
-Cyclic lookups

Improved SPF advice


chore(TCOMP-447): test performance plugin

Add running performance test to check performance plugin on jenkins.

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Performance test should run and create the .xml report file, which should be analyzed by performance plugin and results must be published to jenkins.
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...


wait to trigger href action until the child animation end

http://codepen.io/team/mozvr/pen/RrxgwE

This is not a normal web behavior though, we need more evidence to make sure what behavior is right for webVR

dup of #5


Enable automatic kubernetes api monitoring by default in samples

Set feature flag for all samples that use kubernetes monitoring capability

Won't do for now, so default scopes of apiToken don't change


Stop Query String from Being Decoded prior to being sent to server

I need to pass an encoded URL with a query string to the server as part of the query string of the main request
PhantomJS decodes everything before it goes out therefore confusing the server as to what the query string is.
Thanks.

Note I got around this by double-encoding the URL being passed.
Here's an example of my problem:
phantomserver.com/scrape?page=<pageurl>

If pageurl is /path/to/article?page=2&per_page=2 (%2Fpath%2Fto%2Farticle%3Fpage%3D2%26per_page%3D2 encoded) then in Phantom's request object passed, request.url is:
phantomserver.com/scrape?page=%2Fpath%2Fto%2Farticle%3Fpage%3D2%26per_page%3D2

but it decodes it before giving access to request.url so the only value given is
phantomserver.com/scrape?page=/path/to/article?page=2&per_page=2

So is per_page part of the page= variable or is it part of the main phantom request querystring? Impossible to tell.
Note that I worked around this by double-encoding the page, so it's actually %252Fpath%252Fto%252Farticle%253Fpage%253D2%2526per_page%253D2 when it gets passed to phantom, and then decodes into %2Fpath%2Fto%2Farticle%3Fpage%3D2%26per_page%3D2.


Add info to restart bash if verification not working in verification section

Just added the info to restart the bash terminal if command -v nvm does not ouput anything or gives an error after installation. It was mentioned somewhere earlier but when I read it, I just took note of the verification section, not the part before where the info was mentioned.

I think all the installation methods already mention this:
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

Right?

Just wanted to give a reason why to restart the bash for non-experienced users instead of just saying to restart the bash for no reason. Or what do you mean?

Actually the comment after the 2nd and 3rd line explains it?

Do you mean the whole addition? "Note: Please note that if nvm is not outputted or with the error nvm: command not found, you might want to restart the bash and try it in a fresh bash terminal again, since there are a few variables exported which need to be initialized in a fresh bash."
Or just the part , since there are a few variables exported which need to be initialized in a fresh bash. ?
When I installed nvm the verification command -v nvm did not show nvm as output because I had to restart my bash.

For example, here is the installation message from the scripting method:
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

It clearly mentions to restart the terminal or run those 3 commands, right?

Okay, I see. But the problem I see is that you provide a readme with an installation guide, so a user (I am one of them) will probably just use the instructions from the readme and will not take much note about the installation echos (I am just watching for errors and warnings in this case). In the readme within the installation section there is a header called "Verify installation" so the user will type in the command to  verify if everything worked properly and, of course, nvm won't show up.
I ran into the same issue and just restarted the bash due to the experience I have that this might be the reason. Others might not and then will be confused because there is nothing more mentioned in the Verify installation section even though it is the expected behaviour that nvm won't show up without restarting the bash or running the command you mentioned.
Therefore I would either move the note from few lines above the "Verifiy installation" section to this section or add the stuff I added to it. The note I mean is:

"Note: On Linux, after running the install script, if you get nvm: command not found or see no feedback from your terminal after you type:
command -v nvm
simply close your current terminal, open a new terminal, and try verifying again."

I'm not sure if we should maintain the prompt at multi places, see what does @ljharb say.

@asab-se are you not interested in updating this?

Oh sorry, had to clean up a bit after having had a complete mess by having different accounts. I can update this ofc if interested. Smh thought I did this a while ago actually 🙈


Remove empty CSS

There is no benefit in loading the stylesheet when it's only referring to an empty file.

laravel/nova-issues#3474

Thanks! It will be available on next release 🎉


SSO with WinForms and Windows Authentication

I've a working WinForms sample application using IdentityModel.OidcClient2 login into IS4. It shows a browser window where I can choose "Windows" as external Provider.
How can I achive a login using the current logged in Windows User without showing any UI?

By sending an idp hint via an acr_value, e.g.
append acr_values=idp:Negotiate to the authentication request

Is this correct?
var result = await _oidcClient.LoginAsync(IdentityModel.OidcClient.Browser.DisplayMode.Hidden, extraParameters: new { acr_values = "idp:Negotiate" });

Then I recieve a "HttpError". And the browser window will still be shown.

Couple of orthogonal issues:

passing in the acr_values is correct - I verified that
your windows provider might not be called negotiate - you need to go through the code where the view model for your login page gets created to see the internal name (depends a bit on host configuration)
hiding the browser is not implemented in the sample - you would need to add that yourself.

Maybe I found the error.
When I add the  acr_values value the request fail because of to much redirects. It ends in a loop in AccountController from Login/ExternalLogin -> ChallengeResult to Login/ExternalLogin again..
I have "fixed" this issue by removing the acr_values from value from the return url in AccountController.       ExternalLoginCallback().
...
// delete temporary cookie used during external authentication
await HttpContext.Authentication.SignOutAsync(IdentityServerConstants.ExternalCookieAuthenticationScheme);

// remove the acr_values in order to get redirected correctly
if (returnUrl.Contains("&acr_values"))
	returnUrl = returnUrl.Substring(0, returnUrl.IndexOf("&acr_values"));

// validate return URL and redirect back to authorization endpoint
if (_interaction.IsValidReturnUrl(returnUrl))
{
	return Redirect(returnUrl);
}
...

Now it work's fine.
Is this a bug or "by design"?

Do you set the idp claim to the right name (the same value used on the acr_values) at signin time?

No I never set an idp claim. Should I? Where?

When the client request a certain idp - the server must set the idp claim - you can do that when calling SignInAsync in your external callback.

I've added following code right before SignInAsync
// very rough code -> ONLY for testing
if (returnUrl.Contains("&acr_values="))
{
	var pairs = returnUrl.Substring(returnUrl.IndexOf("&acr_values=") + 12).Split(';');

	foreach(var pair in pairs)
	{
		var values = System.Net.WebUtility.UrlDecode(pair).Split(':');
		additionalClaims.Add(new Claim(values[0], values[1]));
	}
}

This adds a new "idp" claim with "Negotiate". But it does not help. I've to remove the  acr_values from the return url in order to get this working.

The SignInAsync method has an identity provider parameter - try setting that to Negotiate.
Also check the logs. I think we would emit an error if the claim has not the right value.

That worked. Setting the provider name to "Negotiate" (instead of "Windows") prior calling SignInAsync works, no error message.
if (returnUrl.Contains("&acr_values="))
{
	var pairs = returnUrl.Substring(returnUrl.IndexOf("&acr_values=") + 12).Split(';');

	foreach (var pair in pairs)
	{
		var values = System.Net.WebUtility.UrlDecode(pair).Split(':');

		if (values[0] == JwtClaimTypes.IdentityProvider)
			provider = values[1];
	}
}

// issue authentication cookie for user
await HttpContext.Authentication.SignInAsync(user.SubjectId, user.Username, provider, props, additionalClaims.ToArray());

Your parsing looks wrong to me ;)
Use the IIdentityServerInteractionService for turning the returnUrl into a object model


Azure Functions project template references out-of-support packages

When I do "File -> New Project -> Azure Functions" and select a target framework I expect to get project that references the "best" version of packages for that framework.
However I notice the following problems:
Microsoft.Azure.Functions.Worker references Microsoft.Extensions.Hosting: 5.0.0 - now out of support.
Microsoft.Azure.Functions.Worker.ApplicationInsights references Microsoft.ApplicationInsights.PerfCounterCollector references Microsoft.Extensions.Caching.Memory: 1.0.0 which is the very first version of this package from the .NETCore 1.0 release, long out of support.
Microsoft.Azure.Functions.Worker.Grpc references Grpc.Net.ClientFactory references Microsoft.Extensions.Http: 3.0.3 which is also out of support.
While it's fine for packages or libraries to reference older versions of packages - applications should not.  They should reference the latest to ensure they're running on supported and patched dependencies.
Since AzureFunctions provides an application template here it needs to ensure it's starting folks off on a supported and up-to-date set of dependencies.  This should either be done in the templates themselves or in the packages.

Closing as this was addressed through templates updates that have gone out since this item was opened.


Thank you!

Just wanted to say thank you to all the creators and maintainers. This is one of the best libraries for .NET I have used, and your work is very much appreciated!

Appreciate hearing this! Thanks!

Thanks!


Add hello-world exercise

I decided to copy the skeleton from the Bob exercise. Will Bob still need it in this case?
Completes Javascript for the hello world list: https://github.com/exercism/rossconf/issues/2

No, Bob probably won't need the skeleton, but we can leave it in for now, I think.
The build is failing:
running tests for: hello-world
cp: cannot stat `hello-world/hello-world_test.spec.js': No such file or directory
make[1]: *** [test-assignment] Error 1
make: *** [test] Error 1

What do you get if you run make test locally?

I had the file names wrong. I updated them to match conventions and make test passed locally.

Excellent, thanks.


[BugFix] Using json as TxnFinishState serde

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #15248
Problem Summary(Required) ：

Originally, TxnFinishState is serialized using protobuf(baidu jprotobuf) and using the existing field reason in TxnState, when upgrading from version before 2.4 to 2.5, TxnFinishState serialized as binary string will be treated as reason string in older not upgraded FE, and the serialization of reason string will replace illegal chars in the string, which will corrupt TxnFinishState. So serialization using binary format is dangerous, and this PR change serialization format from protobuf to json.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:disappointed: fail : 40 / 55 (72.73%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/transaction/TransactionState.java
11
23
47.83%
[800, 801, 803, 804, 805, 806, 807, 818, 819, 822, 823, 824]

:large_blue_circle:
com/starrocks/transaction/TxnFinishState.java
29
32
90.62%
[94, 95, 116]

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 11 / 22 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/transaction/TransactionState.java
9
20
45.00%
[801, 802, 804, 805, 806, 807, 808, 815, 816, 819, 820]

:large_blue_circle:
com/starrocks/transaction/TxnFinishState.java
2
2
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4


ci: add CodeQL workflow for GitHub code scanning

:tada: This PR is included in version 1.4.49 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Wrong width of text-input for iOS (in modal)

ionic/src/components/input/input.ios.scss
For wider screens with iOS (iPad) text-input field does not stretch to the width of parent container (fills only about a half of the width).
.text-input class width is calculated the following way:
width: calc(100% - #{$text-input-ios-margin-right} - #{$text-input-ios-margin-left});
However, the default value for $text-input-ios-margin-left is 0 - and this is actually causing the problem. Lets assume, that $text-input-ios-margin-right equals 8px.
The result is:
width: calc(100% - 8px - 0); - which is invalid property value.
Solution - replacing:
$text-input-ios-margin-left:               0 !default;
by
$text-input-ios-margin-left:               0px !default;
Expected result:
Text-input field filling all available space of parent container (minus paddings)
Ionic : 2.0.0-beta.10
Platform: iOS

Thanks for the issue! Could you paste some sample html markup that I can use to reproduce this? Thanks. :smile:

yes, sure . here is the plunker:
http://embed.plnkr.co/yaqTLbYZ8JtF9J7kVa7K/

Hello @adam-sokolowski ! Is this still an issue with beta.11? Thanks!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

Yes, this still an issue.