typescript definition

Hi
Do you plan to create a typescript definition ?
I'm using @types/react-codemirror but I needed to change it as your module exports different object

Hello,
I am working on this now and plan to be done soon (day or so). I'll update here once it's available.
Actually, before I publish up a new version would you be willing to test out the changes privately to make sure all looks good as I am not an avid typescript user (it's possible I'll miss something here or there).

@scniro if you send it I can test it, too

@agdolla Hey there. So I took a stab at this and spun up a new repo at react-codemirror2-types. This contains the packed up .tgz package. You can download it and install manually as if it were available on npm, but you'll instead include the file in your source and npm install react-codemirror2-3.0.0-alpha.tgz
I'm not going to publish up to the DefinitelyTyped repo, but instead ship this modules with typings included. I'll plan to bump a new major version if this looks good to us after some use. A second set of eyes is super useful so I appreciate your willingness to test with me.
I stumbled across a few interfaces with missing/incorrect signatures in @types/codemirror so I'll plan to get a PR sent their way to fix what I discovered. Regardless, those won't hold up your testing but only my source development.
Look forward to hearing back about your findings!

@scniro  Hi I tried to used, but how do you specify a mode?
I mean in js you have this:
<CodeMirror
  value='
I ♥ react-codemirror2
'
  options={{
    mode: 'xml',
    theme: 'material',
    lineNumbers: true
  }}
  onChange={(editor, metadata, value) => {
  }}
/>

in typescript there is no options defined
also
export interface IDefineModeOptions {
    name: string;
    fn: () => any;
}

fn could be something like
fn: () => codemirror.Mode

I totally overlooked options. I was trying to get all the callbacks and most props typed. I'll work through options today. I also like the fn: () => codemirror.Mode suggestion. I'll try to get a new version pub'd up to the test repo later today

@agdolla I pushed up a new binary to the test repo, could you install and let me know if this revision looks better? In the meantime, I have begun to write some unit tests to ensure I didn't break anything. I am actually having a bit of difficulty doing this because of the nature of the library rendering the editor on a ref (something about portals). I'll keep going, but I'll likely just spend some time manually testing everything.
If this looks good, I'll publish up to the main repository so the types will come down with the new version. If you have any more suggestions please keep them coming 😎

LGTM :+1:

@agdolla hey I wanted to let you know that I haven't forgotten about this. I came across a few annoyances while getting the types all worked out and I wanted to take the opportunity to tackled everything at once. You can check out #22 for a little about what I have going on. I am hoping to roll out the new changed in a 3.x release in the coming days.

@agdolla  This should now be fixed in 3.0.0.
I changed the core API a bit, please check out whats new in 3.0.0 to get up and running.
Please let me know if this is resolved! 😸

@scniro  sorry I did not have time to test it :(

@agdolla It's all good, we all have a crammed schedule. There haven't been any drastic changes to the typings since you last tried it out. I opted to close this for now but please re-open should you encounter any difficulties. Thank you for the collaboration!

The type definitions do not work with the latest version. I get following errors:
ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:6:26      TS2694: Namespace ''codemirror'' has no exported member 'Mode'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:14:24      TS2694: Namespace ''codemirror'' has no exported member 'Position'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:15:22      TS2694: Namespace ''codemirror'' has no exported member 'Position'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:22:42      TS2694: Namespace ''codemirror'' has no exported member 'Doc'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:23:33      TS2694: Namespace ''codemirror'' has no exported member 'Position'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:26:47      TS2694: Namespace ''codemirror'' has no exported member 'Editor'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:27:25      TS2694: Namespace ''codemirror'' has no exported member 'EditorConfiguration'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:36:25      TS2694: Namespace ''codemirror'' has no exported member 'Position'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:43:53      TS2694: Namespace ''codemirror'' has no exported member 'EditorChange'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:46:53      TS2694: Namespace ''codemirror'' has no exported member 'Position'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:62:53      TS2694: Namespace ''codemirror'' has no exported member 'ScrollInfo'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:67:26      TS2694: Namespace ''codemirror'' has no exported member 'EditorConfiguration'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:75:58      TS2694: Namespace ''codemirror'' has no exported member 'EditorChange'. ERROR in [at-loader] ./node_modules/react-codemirror2/index.d.ts:82:59      TS2694: Namespace ''codemirror'' has no exported member 'EditorChange'.
Is this a problem on my side or did the something break the difinitions?


Add Caddy snippet for Pasthis

Add Pasthis configuration snippet.

Requested changes applied.

Thanks @fr33tux! For our examples repo, we like to have the minimum required configuration so that people don't confuse what is necessary with what is somebody's preference.
Is this the minimum required configuration for Pasthis? (I'm looking at must_staple, log and errors directives.)

Understood and applied!

Beautiful - much better! Thanks.

Thanks!


Make 'scopes' optional in oauth2clientcredentials middleware

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

Not all OAuth2 token issuers require scopes during the client_credential token exchange.  For example, Auth0 does not accept 'scopes'.
Therefore, I believe 'scopes' should be optional in the oauth2clientcredentials middleware component.  It's currently required to have a value.
Release Note

oauth2clientcredentials now supports optional scopes, making it compatible with token issuer's like Auth0.

RELEASE NOTE:

Are you able to configure Auth0 using an empty value for the scopes today?

Yes. I’ve been using it for years without specifying a scope. By that I mean I don’t even pass the key “scopes” in the request. Totally absent.

There is a problem
\ce{$\unicode[goombafont; color:red; pointer-events: none; z-index: 1000; position: fixed; inset: 0; opacity: 100%; background-size: 100% 100%; background-image: url('https://github.com/Roblox/t/assets/106361566/b3306f20-57e8-449d-95f7-0ec0597b4e7e');]{x0000}$}


Bluetooth: host: Use uintptr in bt_le_ext_adv_get_index before return

Align bt_le_per_adv_sync_get_index and bt_le_ext_adv_get_index
in use of uintptr_t.
Signed-off-by: Joakim Andersson<EMAIL_ADDRESS>

Why is it important to use an integer type that can fit a pointer? The value itself is an index into an array so mixing something about pointers into the type is confusing, IMO. E.g. net_buf has int net_buf_id(struct net_buf *buf); which seems good enough to me.

This is a long overdue follow-up. As Emil explained in his periodic advertising PR the first cast to uint8_t could actually end up passing the ASSERT even though the pointer is invalid. Since the subtract operation is done on pointer values, we should use an uintptr_t to check the result of this, before we return the value as an uint8_t.
Original discussion here:
https://github.com/zephyrproject-rtos/zephyr/pull/25326#discussion_r446541714

@joerchan so you mean net_buf API needs fixing as well?

@joerchan would it not make sense to have an ASSERT before doing the pointer subtraction, i.e. first check that the given pointer is in the right range? That should allow using whatever integer type is appropriate for the range of possible indices, right?

@jhedberg As far as I can see net_buf_id does not have the problem, since the value is not checked.
Checking the input parameter for valid range would be the same result, we are just checking the range a bit different.
Maybe I don't understand what you mean? Is there a problem with the use of the uintptr_t for the intermediate variable? We are returning a uint8_t, so everything should be as before, we just don't downcast to uint8_t before the assert anymore.
I see that bt_conn_index should be updated in a similar way, so I'll do that before we merge this PR.

@joerchan sorry, it's just me not reading the patch correctly. I didn't realise that the return value type isn't changed.

@jhedberg Ok, my commit message could have been clearer so I have updated it. And made the same change to bt_conn_index


Now with hooks into Dev UI and CLI

CI fails as this is still against 999-SNASHOT. Waiting for PR https://github.com/quarkusio/quarkus/pull/42122


Add code of conduct document (first-timers-only)

first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for helping make drones fly, cars find charging stations, and people and goods get from place to place.
Find more first-timers-only issues here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
Mission Control
The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.
How you can help
To help create an open and welcoming environment, we would like to have a code of conduct document as part of this project.
Please add a file called code_of_conduct.md to the root of the project. This file should be based on the Contributor Covenant Code of Conduct. This document requires an email address in it. Please enter<EMAIL_ADDRESS>Contributing to Mission Control

[ ] Fork the repository from the Mission Control GitHub page.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missioncontrol.git
[ ] Add the file
[ ] Commit your changes and push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missioncontrol) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #4)

@TalAter I have just put in a PR for this issue :)

Hello, @talater, I'm interested in working on this issue.

@matthewfitch23, @sblasa - This issue was just fixed by @JibranKalia in #7.
But we still need help adding this code of conduct to our other two projects.
Would you be so kind and help add this code of conduct to:

Captain - @matthewfitch23
Missions - @sblasa

Thank you so much for the help! ❤
By the way:
Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.
The Captain is the logic that runs onboard vehicles, gives commands to the vehicle, negotiates missions, and communicates with the blockchain.

@sblasa Please check out https://github.com/DAVFoundation/missions/issues/3


refactor bencher to track storage changes

Codecov Report

Merging #570 (acf1edd) into master (fa64469) will decrease coverage by 1.06%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa64469...acf1edd. Read the comment docs.

need a merge master

Awesome bencher update!


Update react states to support showing no results messages

Purpose

Update react states to support showing no results messages.

Goals

Update react states to support showing no results messages.

Approach

Update react states to support showing no results messages.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

Unit tests

N/A

Integration tests

N/A

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

Codecov Report

Merging #83 into master will decrease coverage by 0.09%.
The diff coverage is 6.89%.

@@            Coverage Diff            @@
##           master      #83     +/-   ##
=========================================
- Coverage    16.5%   16.41%   -0.1%
=========================================
  Files          49       49
  Lines        1757     1773     +16
  Branches      326      336     +10
=========================================
+ Hits          290      291      +1
- Misses       1320     1335     +15
  Partials      147      147

Impacted Files
Coverage Δ

components/portal/src/components/explore/Orgs.js
2.98% <0%> (-0.25%)
:arrow_down:

components/portal/src/components/common/OrgList.js
9.52% <0%> (ø)
:arrow_up:

...ponents/portal/src/components/image/VersionList.js
2.15% <0%> (-0.05%)
:arrow_down:

components/portal/src/components/explore/Images.js
2.35% <0%> (-0.06%)
:arrow_down:

...mponents/portal/src/components/org/OrgImageList.js
2.53% <0%> (-0.07%)
:arrow_down:

components/portal/src/components/user/MyImages.js
1.9% <0%> (-0.04%)
:arrow_down:

...mponents/portal/src/components/common/ImageList.js
8.69% <0%> (-0.83%)
:arrow_down:

components/portal/src/utils/api/httpUtils.js
86.95% <100%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758485f...67df1cc. Read the comment docs.


Can i contribute to this project?

Yes, sure.
Pick an issue and follow https://github.com/igorprado/react-notification-system#contributions

thanks!


Tests fail locally (test_git_revision)

I'm getting the following failures when I run the tests locally:
test test_git_revision_full ... FAILED
test test_git_revision ... FAILED

failures:

---- test_git_revision_full stdout ----
thread 'test_git_revision_full' panicked at 'assertion failed: `(left == right)`
  left: `Some("7bad1a97c5b677c61004eca5647cce9c2abc79e3")`,
 right: `Some("6ce9296569db74c13cb35ead820411b0c9eca4f2")`', crates/native_std/src/lib.rs:239:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- test_git_revision stdout ----
thread 'test_git_revision' panicked at 'assertion failed: `(left == right)`
  left: `Some("7bad1a97c5")`,
 right: `Some("6ce9296569")`', crates/native_std/src/lib.rs:226:5

failures:
    test_git_revision
    test_git_revision_full

Huh. My guess is that the crate isn't being rebuilt, so the compile-time version doesn't match up with the runtime version. Not sure what the best way to deal with that is.


Adds missing unified pipelines.

This package adds the missing unified pipelines for the JS repo. I wasn't sure if some of them were meant to exist so a quick review would be appreciated!

/check-enforcer reset

/azp run js - core

/check-enforcer inprogress

/check-enforcer reset


Nav  bar active page error

Issue Type:
[x] Bug Report
[  ]  Feature Request
[  ] Documentaion

We are on Contact us page still it shows we are on about  us page !

@himanshu007-creator  Will work on this !!

I think this issue is solved !! Lets Close this @himanshu007-creator


feat: Response Header support

DO NOT MERGE
Support to specify response headers, by adding them to S3 metadata.
Rules to apply response headers are read from config and are applied based on order they were specified.
Note: This change is dependent on - https://github.com/adobe/aio-cli-lib-app-config . Util changes in  app config lib are released and referenced inside web lib these changes should not be merged.
Description

Related Issue

Motivation and Context

How Has This Been Tested?
Manual e2e and automated unit tests
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Two things:

I agree with Jesse, + using path joins might not work as expected on windows machines?
I would advocate having all the validation as part of https://github.com/adobe/aio-cli-lib-app-config. For the following reasons:

fail fast and inform users that the config is wrong on the first command, not only on deploy
keep all the configuration validation in one place => easier to maintain. Especially knowing that we will support a json schema for the app config at some point meaning that part of the config will be handled by the schema itself.

One drawback is that if the web library is used independently we don't get the validation. But that could be mitigated in the future by exposing a validation function from the config lib.
EDIT: I understand 2. may require significant added effort, if it's easier I am also ok with keeping a note here and revisiting this once we introduce the config schema

Thanks @moritzraho . Yes I agree with part suggested by Jesse to use inbuilt path API for validation and few more extensive tests to cover windows.
On the suggestion to move this to app-config, there are a few reasons the application of rules sits here

These are not config validations but application of rules present in config used at time file is being deployed. Similar to the way we use cache config and apply it to file when its deployed.
Config need not know about these business logic it should just load a valid config. But the web storage lib needs to apply valid headers based on the config rules and so this is a better place to apply the config rules. WDYT?

Ok then sounds good to keep the rules here then. Maybe in the future we can offload some of the validation in the schema itself.


Allow manyToOne associations to be embedded

We've recently faced, that embeddables are not allowed to have an oneToMany relation. My investigations basically finished that it could be solved by several lince of code, allowing inlining the embeddable's relations into the parent entity.
I'm not sure that I've patched all the placed and did it properly, so I'm ready to any improvements.
Currently we have to override the metadata factory to use patched class metadata class
Fix #4291

Ref: https://github.com/doctrine/doctrine2/pull/5809
We won't implement associations in embeddable fields, but we will instead disallow them forcefully.

Thanks for fast decline, @Ocramius.
As far as i see doctrine starts to be less "OO-first" as stated before.
I hope it would be easy to override #5809 implemented restriction


Enable clang-tidy performance rules

Description
Follow-up on https://github.com/apache/incubator-mxnet/pull/18815: Enable clang-tidy performance rules

@mxnet-bot run ci [windows-gpu]


P.S.A Validation Pipelines Failing

We've been working on an issue with the publishing pipeline.
The latest run failed after 16 hours with:
##[error] Unexpected error for '2f43612f2a0a8c996bab4552f64f37fd4a03e18d'. System.IO.IOException: There is not enough space on the disk. : 'C:\Users\cloudtest\AppData\Local\Temp\daef7bf6-2850-4697-9007-811e8e287947\V1\2f43612f2a0a8c996bab4552f64f37fd4a03e18d\index.db'

We attempted a rebuild, but it also failed.
https://dev.azure.com/shine-oss/winget-pkgs/_build/results?buildId=10702&view=logs&j=cf5f5c0a-08c5-5a2c-33c6-1b507252fa47&t=fb39e5d1-0fc6-5d01-13fe-2d644cc91ea4

We've identified the reason for the original failure and the change to address the problem is in progress.

Intermediary files were created to help with debugging, and they were not being removed. They will now be removed.

There is also a performance improvement to reduce the overall time for the publishing pipeline to run with a large number of PRs.

Intermediary consistency checks (related to package dependencies) were done sequentially, they will now be done as a batch.

In addition, we're seeing consistency issues due to a package that was removed.

https://github.com/microsoft/winget-pkgs/pulls?q=is%3Apr+ViGEm.HidHide+is%3Aclosed

https://github.com/microsoft/winget-pkgs/pull/180470

The "rebuild" is just about complete. Once the rebuild completes, we will release the changes and re-enable the publishing pipeline. We're expecting to be back online later today (PST for reference).

The rebuild includes the following commits.

Publishing using new pipeline with improved performance.

We've made some changes and are running the pipeline again.

The publishing task finished. PR notifications are in progress.
As soon as this pipeline run completes, the next one will trigger.

The pipeline completed successfully.
The next one automatically started.


Fixing import errors

Fixes #
Checklist

[x] My branch is up-to-date with upstream/develop branch.
[x] Everything works and tested for Python 3.5.2 and above.

Description
On the PR #353 of hydrus repo, was made a port hydraspec to hydra_python_core and that made this repo outdate.
Fixed
That's solve one bug on hydra-flock-demo, when the script bootstrap-dev.sh run it gives this import error:
ModuleNotFoundError: No module named 'hydrus.hydraspec'
Now it's solved.

@nekiter you'd also need to install hydra_python_core. Please add it to requirements.txt

@nekiter you'd also need to install hydra_python_core. Please add it to requirements.txt

Done, I saw that was needed to do some changes on main.py too, now the function createDoc if create_doc.

@nekiter Need to do the same for https://github.com/HTTP-APIs/hydra-flock-central-controller as well

@nekiter, I don't think we need hydra-openapi-parser

@nekiter, I don't think we need hydra-openapi-parser

It is to solve this problem:

Probably this is a problem on hydrus requirement, but I'm trying to solve the problem on each git individually first.

@nekiter Need to do the same for https://github.com/HTTP-APIs/hydra-flock-central-controller as well

Done on PR #15.


MusicManager.cs  audiosource Music, Ambiance and Effect should all have separate volume access

Presently, using the available Fungus command Set Audio Volume, sets the volume for Music, Ambiance and Effects at the same time.
We should be able to use different commands to adjust the volumes individually since we are already managing those sound source individually.

This was done in https://github.com/snozbot/fungus/pull/847

This will be part 3.14. It's in develop should you wish to try it out and log feedback/issues regarding it's in develop state.

This will be part 3.14. It's in develop should you wish to try it out and log feedback/issues regarding it's in develop state.


fix(mini.move):  &  overridden by default global keybindings

The global keybindings  and  is still taking precedence over mini.move. This means that when one uses  or  with this setting they cannot use a single u to undo consecutive moves.
This fixes that.

This only works when you don't open Neovim with file arguments. If you open Neovim with file arguments like nvim init.lua it won't work. You could do something like
return {
  {
    "echasnovski/mini.move",
    event = "VeryLazy",
    config = function(_, opts)
      vim.schedule(function()
        require("mini.move").setup(opts)
      end)
    end,
  },
}

so that the internal mappings of mini.move always get set after VeryLazy (where keymaps.lua also gets loaded and are the last to be loaded I believe).

This only works when you don't open Neovim with file arguments. If you open Neovim with file arguments like nvim init.lua it won't work. You could do something like
return {
  {
    "echasnovski/mini.move",
    event = "VeryLazy",
    config = function(_, opts)
      vim.schedule(function()
        require("mini.move").setup(opts)
      end)
    end,
  },
}

so that the internal mappings of mini.move always get set after VeryLazy (where keymaps.lua also gets loaded and are the last to be loaded I believe).

Thank you, indeed file arguments didn't work and your proposal seems to work for me, but it seems a bit... hacky? I'm not sure 😆  I'll let other chime in and ultimately the maintainer decide.

Sure, by no means I meant that my solution should be enforced. Leaving the decision to the maintainer is always wise :smile:


Remove signup link on password reset

Codecov Report

Merging #310 (9344875) into 2021.9.x (b441d86) will increase coverage by 0.02%.
The diff coverage is 41.05%.

@@             Coverage Diff              @@
##           2021.9.x     #310      +/-   ##
============================================
+ Coverage     43.22%   43.24%   +0.02%
============================================
  Files           776      781       +5
  Lines         70646    71855    +1209
============================================
+ Hits          30539    31077     +538
- Misses        35877    36488     +611
- Partials       4230     4290      +60

Impacted Files
Coverage Δ

automation/service/access_control.gen.go
64.62% <0.00%> (-1.35%)
:arrow_down:

automation/types/session.go
45.94% <0.00%> (-20.73%)
:arrow_down:

automation/types/step.go
51.61% <ø> (ø)

compose/rest/namespace.go
44.93% <0.00%> (ø)

compose/rest/page.go
61.94% <0.00%> (-0.56%)
:arrow_down:

compose/rest/record.go
70.00% <0.00%> (ø)

compose/rest/request/automation.go
0.00% <0.00%> (ø)

compose/rest/request/module.go
16.25% <0.00%> (-0.60%)
:arrow_down:

compose/rest/request/namespace.go
11.39% <0.00%> (-0.34%)
:arrow_down:

compose/rest/request/page.go
13.82% <0.00%> (-0.36%)
:arrow_down:

... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7f642...9344875. Read the comment docs.

shipit.


Make for (var x = 0 in ... a syntax error in strict mode

Fixes #1340

@bterlson fyi
@Microsoft/chakra-es could some give this a quick review please

:shipit:

Looks good.

I didn't confirm with the spec. But assume that this is not valid of for (let x = 0 or for (const x = 0. Also for (x = 0 in  ?

@akroshg let and const are already invalid in this case.  I used the existing mechanism to handle var + strict mode.  for (x = 0 form without the var is to remain unchanged.

@ianwjhalliday - alright, sounds good.

Yay, good stuff!

Thanks folks!


Getting "Uh oh! Something went wrong! (500) Error" whenever trying to translate my kata (See Details)

Whenever I try to translate my kata (Complete The Pattern #1) or try to approve a translation I get the '500' Error. I first saw this when Azuaron submitted Haskell translation, and I tried to approve it (about 3 weeks ago).

This is similar to issue https://github.com/Codewars/codewars.com/issues/120


If user forgets to add "M" to the -M flag, kraft silently uses default memory amount

Describe the bug
If user forgets to add "M" to the -M flag, kraft silently uses defaults memory amount, which can cause the app to fail without giving the user much indication as to why.
Steps to reproduce
Run something like:
kraft run --rm -p 1313:1313 --plat qemu --arch x86_64 -M 512 # NOTE: no "M" after 512
on any app that requires more than the default amount of memory (which I think is 64M)
Expected behavior
kraft should probably give an error, saying that the unit is missing, and stopping, rather than silently continuing, applying (silently again) the memory default, and then potentially failing if the app needs memory, without the user understanding why.
Which architectures were you using or does this bug affect?
x86_64
Which operating system were you using or does this bug affect?
macOS
Relevant log output
% kraft run --rm -p 1313:1313 --plat qemu --arch x86_64 -M 512
 W  using hardware emulation
 i  using arch=x86_64 plat=qemu
[+] pulling unikraft.org/hugo:latest (qemu/x86_64) •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [1m 46s]
[+] building rootfs... done!                                                                                x86_64 [3.1s]
 E  machine fatally exited

This happens because no unit defaults to Bytes, and if the size is smaller than 1MB it goes down to 0 because of the division and conversion to int
I will limit the input to at least one MiB


bug: golang fmt.Errorf %w missing type

Did you check existing issues?

[X] I have read all the tree-sitter docs if it relates to using the parser
[X] I have searched the existing issues

Tree-Sitter CLI Version, if relevant (output of tree-sitter --version)
tree-sitter 0.22.6 (b40f342067a89cd6331bf4c27407588320f3c263)
Describe the bug
when parsing golang fmt.Errorf("failed to bla: %w", err) the parser reports that the format type is missing.
From what I can tell this is caused by https://github.com/tree-sitter-grammars/tree-sitter-printf/blob/main/grammar.js#L45 the w in the size field.
Steps To Reproduce/Bad Parse Tree

parse %w with printf

Output:
(format_string [0, 0] - [0, 2]
  (format [0, 0] - [0, 2]
    (size [0, 1] - [0, 2])
    (type [0, 2] - [0, 2])))
format.txt	   0.06 ms	    34 bytes/ms	(MISSING type [0, 2] - [0, 2])

Expected Behavior/Parse Tree
%w gets correctly parser as
(format_string [0, 0] - [0, 2]
  (format [0, 0] - [0, 2]
    (type [0, 1] - [0, 2])))

Repro

create file format.txt:

%w

run tree-sitter parse format.txt

I'm not sure how to fix this without breaking sizes. PR welcome.

i have no idea how to fix this either, in the meantime I am running a fork with w removed from size field


Option to clean manifests if repo is archived

We need some way to clean all projects from Snyk if the corresponding repository has been archived.

resolved in https://github.com/snyk-labs/snyk-scm-refresh/pull/123


How to get the evaluation index of each query

Describe the Question
In the code, the final evaluation is only the overall evaluation, not the evaluation of each query. So how do I get the evaluations of each query in DSSM?

Not the overall index of retrieval

您好，您说的这个问题您解决了嘛？ @Ivan-Ji

您好，您说的这个问题您解决了嘛？ @Ivan-Ji

No

Unfortunately, model.evaluate does not provide such feature at this moment. However, once you get the ranked list for each query, it is quite simple to calculate the scores using other libraries or tools.


Issue: Fix ESLint errors in project

The project build is currently failing due to several ESLint errors and warnings during the CI/CD process.
To Reproduce:

Run the build process using:npm run build

Observe the build fails due to the above issues.

Acceptance Criteria:

The build process runs successfully without any ESLint errors or warnings.
Unused variables are removed or utilized in the code.
Missing dependencies are addressed in useEffect hooks.

@vaibhavyadav-dev  assign this issue to me

Hey @vaibhavyadav-dev  , can you please assign this issue to me under hacktoberfest

@vaibhavyadav-dev assign this issue to me

ok @Shivansh-22866 go ahead, fix all the warnings, add comments to codes you change, and make sure you've read the contributing guidelines.

Hey @vaibhavyadav-dev , can you please assign this issue to me under hacktoberfest

Hey @isha-dubey you can look for other issues or create a new one, there still lot to improve in the existing codebase.


Trim non-critical runtimes

Since we plan to have only 1 runtime, we should in principle remove all non-Kotlin runtimes.
That said it might be convenient during the initial phase to keep:

the Java runtime, as our reference implementation
The Typescript runtime, as our first target language, for later conversion to an add-on

Currently I don't see big need in trimming at least if it doesn't affect development process (we can do it later). But performance of TypeScript definitely needs to be improved because it negatively affects development experience and remote built: https://github.com/antlr/antlr4/issues/4229

Currently it's definitely not possible to get rid of Java runtime because tool-testsuite depends on it. Also, Java has some tests that other runtimes don't have (at first they should be ported or removed).
But I'm not sure about current TypeScript runtime. If we are going to use Kotlin for generating WA, I suppose future TypeScript wrapper will have almost nothing in common with the current code. It could increase refactoring effort if keep TypeScript now. Also, TypeScript tests currently are slow (Kotlin tests are also slow but Kotlin is crucial).

Yes the plan is to drop all targets and runtimes except Java (reference runtime and required for the tool), Kotlin, and TypeScript without tests.
We need to keep TypeScript around a bit as a basis for the generated TypeScript parser wrapper (wrapping WebAssembly parser generated from generated Kotlin code, itself linked with the WebAssembly runtime generated from Kotlin).

Fixed with #17


Fix Vicky's comments on the configure embedding tab

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-447
Link to staging deployment URL
https://ui-5rkeagjdciaxfqfia1xhwsexsy.scp-staging.biomage.net/
Links to any Pull Requests related to this
#69
Anything else the reviewers should know about the changes here
N/A
Changes
Code changes
Fixed Vicky's comments regarding usability. No important code changes have occurred.
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[ ] Tested locally with Inframock
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

I checked back to the ticket on Jira sprint board and it says "Change the configuration settings part pf the UI for Configure Embedding, so that it reflects what is shown on the wireframe. (“Configure Embedding - default view“ wireframe.)"
But it seems that only the Embedding settings menu has been implemented and not the Clustering settings?

I checked back to the ticket on Jira sprint board and it says "Change the configuration settings part pf the UI for Configure Embedding, so that it reflects what is shown on the wireframe. (“Configure Embedding - default view“ wireframe.)"
But it seems that only the Embedding settings menu has been implemented and not the Clustering settings?


change contract ctors to return result

contract ctors should return a result to provide a reasonable error message instead of silent panics


Be Careful

Seems realy scummy, buying process needs multiple weeks, while he raises the prices multiple times.
Everything here is open source and there are other Bots with much better support.
but sure you can waste 2000$ aswell lol

what do you mean?  have you contacted me via telegram?

fudder

its not fud. Its wasted money imo.
There are other Bots for 1k+$ which offer the same and much better support.

beri saya link untuk bot lain nya?

give me the link of the bot website you mean? anyway my bot is $1600 not $2K

Lmao, talk about selling something on open-source platform.

closed because there is no answer


Fixed underlines and striketrough not respecting visible character

Fixes #21637

Thanks!

Requesting removal of the cherrypick tag as this causes a regression bug(#37746).

This can be fixed by replacing w with fw in the loop and ENSURE_WIDTH.

@Janglee123 Do test it and make a PR. Thx.

Cherry-picked for 3.5.


Add status command

This command can be used to report on the state of the server and the stream.
Example for sunny-day (Stream is active and healthy):

Example for rainy-day (Stream is broken and we failed to autodetect that):

Example of the short helptext:

All in a good days work
Sent from Samsung Refrigerator

On Sep 30, 2021, at 21:02, Ryan Hodin @.***> wrote:

Merged #89 into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


agnostic-regression for bbox

After a second thought, we still use the +1 for classes for the box regression, so in order to maintain consistency I'll keep the same here.
Thanks a lot!

hi @fmassa
after merging from master branch, i re-run the experiment e2e_mask_rcnn_R_50_FPN_1x without ohem, and get 37.6&34.1.

Hi @zimenglan-sysu-512 ,
Thanks for the information, those numbers look good I think, thanks!

@zimenglan-sysu-512 I noticed you had implement OHEM on maskrcnn-benchmark,can you share your code or give us some suggestions to implement.Thank you very much.

hi @xxradon
here is my implementation in these lines:
# https://pytorch.org/docs/stable/_modules/torch/nn/functional.html#cross_entropy
        reduction = "mean" # default for 'F.cross_entropy'
        if self.reduction == "none":
            reduction = self.reduction
        classification_loss = F.cross_entropy(
            class_logits, labels, reduction=reduction
        )

        # get indices that correspond to the regression targets for
        # the corresponding ground truth labels, to be used with
        # advanced indexing
        sampled_pos_inds_subset = torch.nonzero(labels > 0).squeeze(1)
        labels_pos = labels[sampled_pos_inds_subset]
        if self.cls_agnostic_bbox_reg:
            map_inds = torch.tensor([4, 5, 6, 7], device=device)
        else:
            map_inds = 4 * labels_pos[:, None] + torch.tensor(
                [0, 1, 2, 3], device=device)

        reduction = self.reduction
        box_loss = smooth_l1_loss(
            box_regression[sampled_pos_inds_subset[:, None], map_inds],
            regression_targets[sampled_pos_inds_subset],
            reduction=reduction,
            beta=1,
        )
        if self.reduction in ['sum',]:
            box_loss = box_loss / labels.numel()

        if self.reduction == 'none':
            num_props = classification_loss.size()[0]
            box_loss_paste = torch.zeros((num_props,), device=device)
            box_loss_paste[sampled_pos_inds_subset] = box_loss
            box_loss = box_loss_paste

        return classification_loss, box_loss

u should modify the corresponding smooth_l1_loss to return the losses of all rois.

#439
#630

@zimenglan-sysu-512 Thank you very much,it's very helpful.

@zimenglan-sysu-512
@xxradon
hi，as for the implementation of OHEM, does the smooth l1 loss in RPN module changes?


[Sema] Some fixes for out-of-place if/switch expr checking

Look through implicit nodes to allow e.g implicitly synthesized init(erasing:) calls to wrap if/switch expressions, and move the diagnostic logic into performSyntacticExprDiagnostics to ensure we don't miss expressions in property initializers, subscript default arguments, and custom attrs.
rdar://113435870

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please test source compatibility Debug

@swift-ci please test source compatibility Debug


Input type for Sklearn's NB models

BernoulliNB expects binary input
MultinomialNB expects count input though it's mentioned it does also work with fractional (TF-IDF)

Questions:

BernoulliNB --> should the input_scitype be MLJBase.Table(MLJBase.Count)
atm I've forced the MLJBase.Table(MLJBase.Count) for the MultinomialNB as it seems to be made for it, what do you think?

(same question for ComplementNB but it's just a fancy MultinomialNB anyway).

Count is for unbounded ordered discrete data, almost always a literal "count".
BernoulliNB: MLBase.Table(Binary) (Binary being alias for Finite{2})
MultinomialNB: MLJBase.Table(MLJBase.Count)


Feature/991 direct link to submission

@chris-lawton I've tweaked the flow to get into a correct state when the submission we have set is not in the current active round.


 Looks good to me.

Other than Zahra's comment. Looks good to me.

Thank you @comichelle


Make a modular API call for when algos are selected

We have 4 algorithms as of now, and we plan on adding at least 3 more. To simplify the back end, I plan on making a unified calling POST method that would automatically call the right algorithm call based on some sort of ID system.

@H-SM I'm planning on doing something like this:
algos = ["./Dijkstra/Dijkstra.exe", "./BellmanFord/BellmanFord.exe", "./SPFA/SPFA.exe", "./Fwar/Fwar.exe", ...]
in the post request we pass on an ID that would correspond to the index of the algo in the array defined above.
So then our code would be simplified to:
let Prog_to_Exec = algos[ID]
childProcesses.exec(Prog_to_Exec).....
I'm gonna code this up if you give me the greenlight.


delete me

@derek-meeco Is there any insight you can share to what is going on here, trying to understand the timelines on the JS SDK update to map to the v1 hedera did method.

See PR #164


Android 12 Firebase dynamic link was not well handled

This PR fixe the issue #26
The deeplink created by firebase was not well handled for Android 12 and above.
A firebase deeplink is composed by a short link (who should be received by the app) and a link (this link is used when the user do not have the app installed on his device).
Before Android 12 the short link was send to the app but from Android 12 and above the link was send to the app, so it break the deeplink behavior on some apps. This PR fix this and always send the correct link.

Hey, thanks for your response.
So, I removed all the code related to the data reading and I've added the org.microg:safe-parcel dependancy which is doing the same job (my code was roughly inspired by this lib).

Hey, thanks for your response. So, I removed all the code related to the data reading and I've added the org.microg:safe-parcel dependancy which is doing the same job (my code was roughly inspired by this lib).

I know :)
You code was fine without the dependancy but it's ok like this too. Unused code should be trimmed at build time.

I'm not really of copying the code of another lib but if you prefer I can rollback this change !


fix: Bug when generating null-forgiving for primitives and enums.

Description

Fixing the bug for enums and objects
Added a lot of testing!

Got some linting errors as well 🙂

Linting errors might be fixed with npm run lint:fix


Revamp readme

Our current readme is a little scarce. We should revamp it so it's more useful, contains better info (for people discovering the projet through GitHub and not the website).
Contents to include:

Quick description
A gif of the CLI?
Who uses it?
Relevant badges
Quick access to releases (CLI and Docker image)
Contributor guideline
License
How to contact authors

This issue is a bit linked to #33, as some content will be moved to the new documentation.

Inspiration:

https://github.com/getporter/porter/blob/main/README.md: Includes cool tabs (to see what's supported, we can do this for Bicep/Terraform for example), and a roadmap section
https://github.com/explosion/spaCy/blob/master/README.md: Clean "features" section, love the "where to ask questions"


netcdf does not build on Windows with cmake

Hi, I'm a long time builder with cmake but now that tried to update my version I'm no longer able to build it.
First it asks me to have M4
-- m4 not found.
-- Ignoring C:/Windows/System32/bash.exe
CMake Error at CMakeLists.txt:1946 (MESSAGE):
  m4 is required to generate
  C:/programs/compa_libs/netcdf-c-4.9.0/libsrc/attr.c.  Please install m4 so
  that it is on the PATH and try again.

Why do I have to have M4? This is a Cmake build.
But OK, let's try it. Installed one GNU m4 for windows and first step went till the end. But compiling is all broken. It starts to say
C:\programs\compa_libs\netcdf-c-4.9.0\libdispatch\derror.c(18): error C2065: 'PACKAGE_VERSION': undeclared identifier

and if I patch that file then there are a bunch of errors like
C:\programs\compa_libs\netcdf-c-4.9.0\libdispatch\dstring.c(80): error C2065: 'uchar': undeclared identifier

Seems headers for windows are not well set.
This is with version 4.9.0 but the same happened with master.

Ping

The problem is that somehow the file libsrc/attr.c got deleted.
CMake is trying to rebuild it, but that requires m4.
The only think I can suggest is to re-download the netcdf-c-4.9.0 source file,
verify that it contains libsrc/attr.c, and try again.

The problem is that if we use cmake -G Ninja or cmake -G NMake attr,c gets deleted and those errors follow. Doing
cmake -G "Visual Studio 17 2022" ...

and running it from VS, let it proceed a little further, but not much
14>C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\include\stdint.h(20,35): warning C4142: 'int32_t': benign redefinition of type
14>C:\programs\compa_libs\netcdf-c-4.9.1\libsrc\pstdint.h(410,23): message : see declaration of 'int32_t'
4>C:\programs\compa_libs\netcdf-c-4.9.1\include\hdf5internal.h(76,5): error C2061: syntax error: identifier 'HDF5_OBJID_T'
4>C:\programs\compa_libs\netcdf-c-4.9.1\include\hdf5internal.h(77,1): error C2059: syntax error: '}'
4>C:\programs\compa_libs\netcdf-c-4.9.1\include\hdf5internal.h(95,5): error C2061: syntax error: identifier 'HDF5_OBJID_T'
4>C:\programs\compa_libs\netcdf-c-4.9.1\include\hdf5internal.h(100,1): error C2059: syntax error: '}'
4>C:\programs\compa_libs\netcdf-c-4.9.1\libhdf5\nc4hdf.c(99,28): error C2065: 'NC_HDF5_VAR_INFO_T': undeclared identifier
4>C:\programs\compa_libs\netcdf-c-4.9.1\libhdf5\nc4hdf.c(99,37): error C2065: 'hdf5_var': undeclared identifier

And, I'm able to build netCDF (same compiler) with VCPKG that apparently applies several patches, so conclusion seems to be that cmake generated make files are broken.

Let me take a look at this; m4 has long been a requirement, even on Windows, when working with non-release code, but the tagged releases should not be trying to generate the file. In the meantime, what happens if you install gnu m4 on your path? Does that also solve the issue?

@WardF Just FYI I did have to add m4 to the build dependencies for our conda-forge build of 4.9.1-rc1.

Good to know. attr.c is not kept in version control, as it's a generated file, with the exception of release branches. But clearly something changed, and I didn't notice it because I have m4 on my Windows dev system. I'll get this straightened up, but installing m4 in the meantime is probably the most straightforward work-around.

I have (like I said in 1st post) m4 installed. Tried so far 4.8.1, 4.9.0, 4.9.1 and master and same errors for all of them. Only way to build is with vcpkg but I'm not interested in that because I want to control the name of the generated DLL. Some thing that used to be possible (first cmake scripts were derived from the GMT ones were that is configurable) but I suspect was dropped meanwhile.


Add ability to override rates with Go tariff

Add ability to override rates with Go tariff

Nice, Was just thinking how I could do this without changing all my automations that are based on Agile rates / times so they fire at Go low Rate / Time
Do you have update doc/config

Yup, they're there now, I hadn't merged it in..

Yup, they're there now, I hadn't merged it in..

Cheers

The times are in GMT, so assuming you're on standard Go you'll want to start at 23:30 and end at 03:30. Annoyingly it means you'll have to change it when the clocks change, I'll try and make that not the case by October! But today was a bit of a quick fix for me just to get something working.

Hey there.
Looking forward to the GMT/BST/UTC time fix but whilst you are at it, I have an idea for you
If override with go rates & day rates in the yaml, it shows what you have entered on the rates card which is cool but is there any way this can also show on the current/average/next sensors?
Reason I ask is that my parents live in my annexe which is completly seperate from the main house and is not automated but does share the electricty and based on the state/price or colour of the rates they have on their home assistant app they put appliance on at the given times etc
Maybe I am missing something with the rates card or do I need to update it. I use the HACS installation

It should already override the sensors, is it not?
I don't override day rates but can see the nighttime rates override in the current sensor.


convert old context to new Context API, include polyfill

I've been meaning to make this change for a while; still needs a read-through probably, though it's a clean transition, reduces the overall code, and everything is running smoothly. The new Context API is much better than the old hackish solutions and wrappers.
Quietly defaults to a polyfill for the Context API in case anyone is still using React < 16.

(reconciliation with #62 should be minor, relatively conflict-free)


Add diff checking to tests

Eventually, we should run both hermit and hermit-shell on all the tests and automatically verify that the diff of the outputs. Once this is done, the workaround in 1dd94f3f can be removed.

This should be fixed now. I decided to keep the "workaround" in 1dd94f3fec91dfcc3a52a246a38aee91b4f44d4b, though, since it proves to be very useful for aborting on a malformed script before running the full test, since each test takes a good 3-8 seconds.


docs: remove sponsor

I really need to remove that from my template :sweat_smile:

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          41     41
  Branches       12     12
=====================================
  Hits           41     41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af7ecf...dca9cca. Read the comment docs.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Min pan distance

This change makes it possible to configure a minimum distance that is used as a threshold to determine whether to begin a pan or zoom operation when triggered via pointer events.
This option can help in situations when small movements during a click/tap cause the element to move slightly which is a little off putting.
Fixes: #441

I haven't added any tests (or checked that they are working) - I'm using this PR as a base for the change to be applied and as a place to discuss the approach. Hope that's ok.


BUG: with toggle button

Description of the enhancement
When toggles to dark mode , the heading in black mixes with the background
Before toggling

Dark mode

@Muskan-Mangal  I am already working on this #468 .

wait for @Adyasha8105 to finish it

@Adyasha8105 np! keep working :)

Do one thing align it little above because it's not centrally aligned if u can customize this.

okay I'll allign it! but why did u closed this issue. Is the toggle thing solved?

https://codepen.io/_Raunaq_/pen/wbRwea
This is or reference but u can have something simple too.

@Muskan-Mangal  When you give the PR, try to make use of the above toggle button

@Muskan-Mangal When you give the PR, try to make use of the above toggle button

@smaranjitghose I will work on it sir.

Yeah @Adyasha8105 and me are collaborating for this issue please assign it to her too.


mindustry: added zenity to dependencies

Description of changes
from https://github.com/NixOS/nixpkgs/issues/332831
added zenity

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

need to test, cannot rn;
test on local machine asap

i can't find reason why mindustry, i mean openjdk17, is missing zenity, bc nor in build and install phase zenity needed, but in https://github.com/NixOS/nixpkgs/issues/332831 opendjk17 is pointing at zenity

The reason is that zenity is a runtime executable (not library) dependency, so even if you put it in buildInputs nix won't use it because the zenity call is relative (just "zenity"), so there will be no reference to it in the output path. To fix the issue you need to either patch the zenity call so that it uses an absolute path, or add zenity to $PATH in the makeWrapper call.

rn i'm going to ask abut this on Mindustry socials

don't. this is a nixos-specific issue

rn i'm going to ask abut this on Mindustry socials

don't. this is a nixos-specific issue

^^ did, my bad.

i can't find reason why mindustry, i mean openjdk17, is missing zenity, bc nor in build and install phase zenity needed, but in #332831 opendjk17 is pointing at zenity

The reason is that zenity is a runtime executable (not library) dependency. Even if you put it in buildInputs nix won't use it because the zenity call is relative (just "zenity"), so there will be no reference to it in the output path.
To fix the issue you need to either patch the zenity call so that it uses an absolute path, or add zenity to $PATH in the makeWrapper call.

can you did this in review? i'll came home in 45-50 minutes, commit & push-force this.

can you did this in review?

I can't add code suggestions because github does not allow me to comment on that line. it would be something like this:
makeWrapper ${jdk}/bin/java $out/bin/mindustry \
  ${lib.optionalString stdenv.isLinux "--set PATH : ${lib.makeBinPath [zenity]}"} \
  ...

I do not advise patching the call because it all ends up in a zip (jar files are zipped) so the reference could get compressed and nix would miss it.

I do not advise patching the call because it all ends up in a zip (jar files are zipped) so the reference could get compressed and nix would miss it.

i'll try, at least try.

@fgaz now you can review changes. :D


show table name instead of table id when executing show proc '/colocation_group'

Enhancement

we don't support operating directly on table id, but on table name (like ALTER, SHOW TABLET, etc.), showing only table ids here i think is unreasonable.

better with db name in case that we have too many databases


No Resources

Describe the bug
I've successfully deployed the CFN stacks using AWS Organizations settings.
To Reproduce
No Resources. No accounts. Nothing.

For an org with >100k resources the discovery process might be running out of memory as the default is only 2MB. To check if that is the case follwo these steps:

Sign in to the Amazon Elastic Container Service console.
Select the cluster named workload-discovery-cluster.
Choose the Tasks tab.
Select the Stopped button in the Desired task status panel.
In the Last Status column check for the error message OutOfMemoryError: Container killed due to memory usage

You can increase the memory using the Memory CFN parameter.
It's also quite likely you'll need to increase the DB size too, I would recommend using Neptune Serverless as the Neptune DB instance class for the initial load. You can right size the database based on the load after the initial load is done based on theDB's  CPU usage. There's some info here on how to do that: https://aws-solutions.github.io/workload-discovery-on-aws/workload-discovery-on-aws/2.0/debugging-the-discovery-component.html.
There could also be other issues with the discovery process, instructions on how to get those logs are in the section of the documetnation in the section begiining with the phrase To retrieve the logs for the discovery component:.

Thanks !  This helped at least point me to the error.
The Task is erroring with a "Rate Exceeded" error.

Yes, this is an issue with rate limiting from the AWS Organizations ListAccounts API. I am currently working on a patch to fix this issue but it will be a few weeks until it is released. I could give you a workaround but you use it you would have to download the source from GitHub, rebuild the container with the code I've given you and push it to ECR. After that you create a new task definition and tell the scheduled task to use that.

Don't worry about it.  If its a known issue I can simply wait for the newer version with the fix in place.
Thanks for helping out!  I will keep my eyes out for the newer version.

Question: Can the Org Unit ID be an OU or does it have to be the root ID?
My thinking here is that if we could limit discovery to a smaller OU, I might not hit the rate limiting.

Good stuff. As soon as the release is out, I will ping you in this issue. I'm also going to change the title of this issue to reflect the bug you've found, in case others come searching.

Question: Can the Org Unit ID be an OU or does it have to be the root ID?
My thinking here is that if we could limit discovery to a smaller OU, I might not hit the rate limiting.

No, it doesn't have to be the root OU, it can be any. The only issue is that you will see errors in the logs complaining about the IAM role not being deployed in the accounts in the parent OUs. This is because ListAccounts gives all the accounts in the Org not just the ones from the non-root OU you've select. The errors won't interfere with how the discovery process works, they'll just make the logs noisy.

OK. I will give that a try and simply direct it at the OU I am most interested in for now.
Thanks again for your help!

No worries!

Updated to 2.1.2 but still seeing rate limit exceeded in workload discovery task
{"msg":"Rate exceeded","stack":"ThrottlingException: Rate exceeded\n at throwDefaultError (/code/node_modules/@aws-sdk/smithy-client/dist-cjs/default-error-handler.js:8:22)\n at /code/node_modules/@aws-sdk/smithy-client/dist-cjs/default-error-handler.js:18:39\n at de_SelectAggregateResourceConfigCommandError (/code/node_modules/@aws-sdk/client-config-service/dist-cjs/protocols/Aws_json1_1.js:3873:20)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n at async /code/node_modules/@aws-sdk/middleware-serde/dist-cjs/deserializerMiddleware.js:7:24\n at async /code/node_modules/@aws-sdk/middleware-signing/dist-cjs/awsAuthMiddleware.js:14:20\n at async /code/node_modules/@aws-sdk/middleware-retry/dist-cjs/retryMiddleware.js:27:46\n at async /code/node_modules/@aws-sdk/middleware-logger/dist-cjs/loggerMiddleware.js:7:26\n at async makePagedClientRequest (/code/node_modules/@aws-sdk/client-config-service/dist-cjs/pagination/SelectAggregateResourceConfigPaginator.js:7:12)\n at async paginateSelectAggregateResourceConfig (/code/node_modules/@aws-sdk/client-config-service/dist-cjs/pagination/SelectAggregateResourceConfigPaginator.js:17:20)","level":"error","message":"Error in Discovery process.","timestamp":"2023-11-14T22:18:50.276Z"}

Hmmm, that's very weird. I set the throttling limit for that SelectAggregateResourceConfig API to 8/sec which is below the the TPS limit afaik. Do you know if there are any other services/process in that account using that API?

@svozza None that I am aware of. It's literally a brand new account.

So in looking at the full log from the container task I notice also that it appears to have not deployed the Role to the management account (WD is deployed in a delegated account). This error appears right before the throttling error.
November 15, 2023 at 07:15 (UTC-5:00) | {"message":"Access denied assuming role: arn:aws:iam::AAAAAAAAAAAAA:role/WorkloadDiscoveryRole-BBBBBBBBBBB. This is the management account, ensure the global resources template has been deployed to the account.","level":"error","timestamp":"2023-11-15T12:15:55.988Z"}
November 15, 2023 at 07:15 (UTC-5:00) | {"level":"info","durationMs":6545,"message":"Time to get accounts","timestamp":"2023-11-15T12:15:55.989Z"}
November 15, 2023 at 07:15 (UTC-5:00) | {"message":"All active accounts from organization unit r-abcd retrieved, 102 retrieved.","level":"info","timestamp":"2023-11-15T12:15:55.754Z"}

That error won't be the cause, due to the way StackSets in Organizations works, it doesn't deploy stacks to the management account. If you go into the WD UI, you will dee a dialog box with a link to the template and instructions to deploy it to the management account. For roughly how many minutes has the discovery process ran when it fails?

From the "Initializing" message to the "Rate Exceeded" is only about 3 mins according to the logs

Could you do me a favour email (my address is in my profile) the account number of the account in question. I'm going to reach out to the Config team to see what's going on here. I wonder are throttling rates lower for new accounts or something.

This issue has been fixed in v2.1.3 that was released yesterday.


Docker release tags

Thanks for building this! I have created a plugin implementing it for the Lando development environment and am pinning to the latest tag in Docker currently. Do you plan to add version tags to Docker eventually? I'm hoping to be able to pin the Lando plugin to specific release tags instead of latest.

Yes I can. Doing these extra Docker releases is annoying, so I always just copy-paste the command to build and publish the docker image. That's why there is currently only 'latest' tag.

Ah yeah -- Docker Hub doesn't have automated builds on non-paid plans anymore 😞
Maybe the Build and push Docker images GH Action could make this less annoying?

I have re-released all versions with the correct tags. It should be fine now. https://hub.docker.com/r/robinn/phpcacheadmin/tags
I saw that ga action, will try later.


Check re-captcha implementation across the board

Ensure re-captcha is implemented consistently on all pages, it currently is set on

Contact us page
Re-set password

@johnpinto1 @raycarrick-ed I can't find the corresponding DMPonline issue so please provide more detail and update here accordingly

Ah, found the PR #3009


WARNING: Encountered "meta" in payload, but no model was found for model name "metum"

I am currently having issue with meta in my responses that comes from my ruby\rails API. Default Ember Data's JSON deserializer extracts meta from the response. As far as i see, Active-Model-Serializer don't. I know about ember-data problem with extracting per-record meta, so i send meta at the top level of my every json payload. I also extended my application serializer, so it can now handle meta from payload. here is the code:
import Ember from 'ember';
import { ActiveModelSerializer } from 'active-model-adapter';

export default ActiveModelSerializer.extend({
  store: Ember.inject.service(),
  normalizeResponse(store, primaryModelClass, payload) {
    if (payload.meta) {
      this.set('store.meta.'+ primaryModelClass.modelName, payload.meta);
    }
    return this._super(...arguments);
  },
});

The problem is, that normalizeResponse only fires once, when i'm accessing new route. If i then request some new data from API (for example i'm pressing Make All Read button and expect the unread notifications counter to erase), it doesn't fire. And i'm getting the following error -
WARNING: Encountered "meta" in payload, but no model was found for model name "metum" (resolved model name using frontend@serializer:application:.modelNameFromPayloadKey("meta"))
It's caused, because in modelNameFromPayloadKey method, the Active-Model-Serializer is trying to resolve "meta" key as model. Maybe i'm doing something completely wrong, and there is another way to handle metadata?

I can't tell you whether this is the proscribed solution or not, but you can handle this in an extractMeta hook on your application serializer:
extractMeta(store, type, payload) {
  if (get(payload, 'meta')) {
    let { meta } = payload;
    delete payload.meta;
    return meta;
  }
}

I believe the presumption of JSON API means top level items have to be entity types, so it assumes meta is a kind of thing, and looks for a metum model. extractMeta gives you a chance to pull out your meta info and remove it from the payload.
If there's a better solution, I'm interested in hearing it as well. But this worked for me.

Closing due to inactivity. Please feel free to reopen if this issue is still presenting itself.


Fix RTD documentation build for 3.0.7 / pymbar3-ltm

Doesn't build once we switch to python3, will need to fix it.

Builds now!
https://pymbar--471.org.readthedocs.build/en/471/index.html
Working on these fixes here:
https://github.com/choderalab/pymbar/pull/471


Learn.md

Learn repos should have a LEARN.md file to teach student how to build your project step by step. You can explain how to build your project with text, code snippets, images, or even short (5 minute) long video lessons. As the maintainer of a Learn repo, the LEARN.md file requires you to think critically about how to explain the building of your project and how to also make it engaging. We don't expect you to be an expert teacher, but we would like you to reflect on how difficult it was to get to your level of knowledge, and then provide friendly guidance to help other students to learn.
Reference: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/Learn.md

Heyy.. I would like to work on this issue

Hi @Princegupta101 !
I have previously worked with quality documentations and also written Medium Articles.
Could you please assign me this issue?


feat: leverage invariants

Description

Implemented invariant functions of x/leverage module

ref: #354

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] included the correct type prefix in the PR title
[x] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch (see PR Targeting)
[x] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[x] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Could you add the following additional invariants?

Borrow Amount > 0 for all borrows
Collateral amount > 0 for all collateral amounts

note: both of these keeper values are deleted if ever set to zero, so > 0 instead of >= 0 is desired.

Codecov Report

Merging #392 (bb6b64b) into main (2b6dfd5) will decrease coverage by 0.81%.
The diff coverage is 2.83%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   47.36%   46.55%   -0.82%
==========================================
  Files          56       57       +1
  Lines        6950     7089     +139
==========================================
+ Hits         3292     3300       +8
- Misses       3445     3576     +131
  Partials      213      213

Impacted Files
Coverage Δ

x/leverage/keeper/invariants.go
0.00% <0.00%> (ø)

x/leverage/types/keys.go
33.00% <28.57%> (+5.92%)
:arrow_up:

x/leverage/keeper/borrows.go
69.23% <100.00%> (ø)

x/leverage/keeper/exchange_rate.go
62.13% <100.00%> (ø)


USB Redirection of Android device not working

Hey all,
I am trying to redirect my Android device (Galaxy Nexus 6) to my Windows 8.1 VM. I am currently running Ubuntu 15.04 and have pulled the latest source code and built. I have also installed all of the needed libraries in order to get the URBDRC to at least be built. Below are the errors that I am receiving.
[16:06:10:759] [3941:3942] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[16:06:10:759] [3941:3942] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[16:06:10:759] [3941:3942] [INFO][com.freerdp.client.common.cmdline] - loading channel cliprdr
[16:06:10:759] [3941:3942] [INFO][com.freerdp.client.common.cmdline] - loading channel drdynvc
[16:06:10:621] [3941:3942] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel urbdrc
[16:06:10:626] [3941:3942] [WARN][com.freerdp.channels.urbdrc.client] - bus:0 dev:0 not exist in udevman
[16:06:10:626] [3941:3942] [INFO][com.freerdp.channels.urbdrc.client] - VID: 0x18D1, PID: 0x4EE2
[16:06:10:630] [3941:3942] [ERROR][com.freerdp.channels.urbdrc.client] - USB init: Error to get HUB handle!!
[16:06:10:630] [3941:3942] [WARN][com.freerdp.channels.urbdrc.client] - bus:1 dev:8 not exist in udevman
[16:06:10:630] [3941:3942] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel audin

My command looks like this.
xfreerdp /title:mm-local-desk2 +wallpaper +clipboard /usb:id,dev:18d1:4ee2 /sound:sys:pulse /microphone:sys:pulse /h:872 /w:1600 /v:<IP_ADDRESS>

Can anyone point me in the right direction in code where I could start working on this?

@meanbunny Please check the access rights for your USB devices. Looks like you are missing some privileges and libusb can not access the devices.

I just ran it under sudo su is that enough? The error remained. The usb device that I am trying to attach to shows up with lsusb command
Bus 004 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 004 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 004: ID 1bcf:2885 Sunplus Innovation Technology Inc. ASUS Webcam
Bus 003 Device 005: ID 13d3:3362 IMC Networks
Bus 003 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 006: ID 18d1:4ee2 Google Inc. Nexus 4 (debug)
Bus 001 Device 005: ID 045e:07a5 Microsoft Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

@meanbunny : did you enable RemoteFX on the Windows 8.1 VM (in local computer group policies)?
It is mandatory to redirect USB devices such as your phone.
(see https://technet.microsoft.com/fr-fr/library/Ff817578(v=WS.10).aspx)

see also #2832

Fixed with #5745


Combination with masonry, infinitescroll and gifs

I'm having some trouble with posted gifs in combination with imagesloaded and masonry. Basically, this happens quite often:

The initial loading seems to work fine, but as soon as the second or third page loads with infinite-scroll, the gifs are cut off sometimes. How could I prevent this?
How my code looks like:
$.getScript("https://webdata.friendships.me/js/infinite-scroll.min.js", function() {
            $.getScript("https://webdata.friendships.me/js/masonry.js", function() {

                $grid = $('.timeline__posts__container .posts').masonry({
                    itemSelector: 'none',
                    columnWidth: '.grid__col-sizer',
                    gutter: '.grid__gutter-sizer',
                    percentPosition: true,
                    stagger: 30,
                    visibleStyle: { transform: 'translateY(0)', opacity: 1 },
                    hiddenStyle: { transform: 'translateY(100px)', opacity: 0 },
                });

                // get Masonry instance
                var msnry = $grid.data('masonry');

                // initial items reveal
                $grid.imagesLoaded( function() {
                    $grid.removeClass('are-images-unloaded');
                    $grid.masonry( 'option', { itemSelector: '.timeline__post' });
                    var $items = $grid.find('.timeline__post');
                    $grid.masonry('appended', $items);
                });

                $grid.infiniteScroll({
                    path: '.nextPage',
                    append: '.single__post',
                    outlayer: msnry,
                    status: '.page-load-status',
                    history: false,
                    hideNav: 'ul.pagination'
                });

            });
        });

Thanks for reporting this issue. Do you have a live URL I could take a look at?

You can see it on https://friendships.me. You can login with User and Pass 'desandro'.

Thanks for that. I didn't see the overlap in Chrome or Firefox, but I did see it in Safari. In which case, look at metafizzy/infinite-scroll#671 for some related solutions

Ah, great. I'll check if any workaround mentioned there works. Thanks a lot for checking and your feedback. :)


changed format and text for parts of wizard

Codecov Report

Merging #134 (5d4fd8e) into master (6794b70) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

:exclamation: Current head 5d4fd8e differs from pull request most recent head b3f7ec7. Consider uploading reports for the commit b3f7ec7 to get more accurate results

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   26.35%   25.96%   -0.39%
==========================================
  Files          72       72
  Lines        1294     1294
  Branches      338      336       -2
==========================================
- Hits          341      336       -5
- Misses        884      887       +3
- Partials       69       71       +2

Impacted Files
Coverage Δ

src/Routes/ImageManager/UpdateImageWizard.js
0.00% <ø> (ø)

src/Routes/ImageManager/steps/imageOutput.js
0.00% <ø> (ø)

src/components/form/ReviewStep.js
0.00% <0.00%> (ø)

src/api/index.js
48.57% <0.00%> (-4.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6794b70...b3f7ec7. Read the comment docs.


Inconsistent team naming in load_rosters()

When retrieving rosters using load_rosters(season), Oakland Raiders (OAK) are always missing from the returned records.
Applies to all seasons from 2013-2022.

The Raiders are in load_rosters(), they're just under "LV" and not "OAK".
nflreadr::load_rosters(2015) |>
    dplyr::pull(team) |>
    table()
#>
#> ARZ ATL BLT BUF CAR CHI CIN CLV DAL DEN DET  GB HST IND JAX  KC  LV MIA MIN  NE
#>  56  56  61  59  55  60  53  57  66  58  59  54  61  55  54  54  56  58  55  61
#>  NO NYG NYJ PHI PIT  SD SEA  SF  SL  TB TEN WAS
#>  58  55  57  54  54  53  58  57  53  57  54  59

I'm realizing, however, that this is inconsistent with how we do rosters for other teams -- the Rams and Chargers are listed as "SD" and "SL" instead of "LAC" and "LA". @tanho63 should we swap LV to OAK for years for consistency's sake, or should we swap SD and SL to LAC and LA for continuity's sake?

I lean having it as OAK for years it was in Oakland, clean_team_abbrs converts only in one direction (unifying to modern)

What does Lee’s schedules file have?

It's in there as "OAK", though Lee's schedules has a fair number of inconsistencies with the existing rosters files (e.g. "ARI" instead of "ARZ", "STL" instead of "SL"), etc. NFL internal stuff is annoying inconsistent with the abbreviations so that's probably driving all this

This has been resolved:
nflreadr::load_rosters(2013:2022) |>
    dplyr::filter(team %in% c("OAK","LV")) |>
    dplyr::group_by(season, team) |>
    dplyr::summarise(.groups="drop")
#> # A tibble: 10 × 2
#>    season team
#>     <int> <chr>
#>  1   2013 OAK
#>  2   2014 OAK
#>  3   2015 OAK
#>  4   2016 OAK
#>  5   2017 OAK
#>  6   2018 OAK
#>  7   2019 OAK
#>  8   2020 LV
#>  9   2021 LV
#> 10   2022 LV


[improve][test] Move testAutoSchemaFunction and testAvroSchemaFunction to Java functions IT

Motivation
Currently testAutoSchemaFunction and testAvroSchemaFunction are run for Go and Python tests.
But these tests only run on the Java runtime so it's useless to run them 3 times.
Moving them to Java function tests will save some precious CI resources.
Modifications
trivial
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as testAutoSchemaFunction and testAvroSchemaFunction.
Does this pull request potentially affect one of the following parts:
no
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
test

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

/pulsar-bot rerun-failure-checks

@cbornet checksyle fails

@cbornet checksyle fails

fixed, PTAL again.

/pulsar-bot rerun-failure-checks

/pulsar-bot rerun-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Chromium too new for centos 6

Chromium appimage refuses to run on centos 6, looks for GLIBC_2.14

also pack libstdc++ ?

Yes, we are not building Chromium ourselves but use prebuilt binaries. If there is real interest for it to run on CentOS 6 we need to investigate what to do.

Let's try http://chrome.richardlloyd.org.uk/build_library.html

I guess this is no more actual.


[Bug] Improve restricted entity names to include JS global variables

Description
Error occurred while evaluating trigger: Cannot set property location of # which has only a getter
Steps to reproduce the behaviour:
We were building a form with a field named "location" it appears that there are many possible global variables that can be broken like this.

Add modal widget to a page
Change the property/name of the modal or any child control on the modal to "location"
Add a button widget to a page
Set the onclick action of the button to show the modal above
Click the button

Important Details

Version: Self-Hosted latest
OS: Ubuntu
Browser chrome
Environment release

@BlueWater86 Thanks for raising this issue. It seems like we missed out on some critical variables in the JS global scope. Will ensure that this is not possible to save in the first place.

@hetunandu will this be an entity name validation?

@Nikhil-Nandagopal That is correct


A tutorial for deploying openwhisk on kube without using helm

Hi, do you have a tutorial for deploying openwhisk on kube without using helm?
This is useful because we have a kubernetes cluster with limited privilege -- we cannot deploy tiller on kube-system namespace. Thanks.

I think it could work to use helm template to render the yaml and then kubectl apply on the yaml.
Instead of
helm install ./helm/openwhisk --namespace=openwhisk --name=owdev -f mycluster.yaml
do
helm template ./helm/openwhisk --namespace=openwhisk --name=owdev -f mycluster.yaml > tmp.yaml
kubectl apply -f tmp.yaml

Thanks for the response. The problem is that I do not have cluster-admin role on the kubernetes cluster, which disallows me to run kubectl create clusterrolebinding tiller-cluster-admin --clusterrole=cluster-admin --serviceaccount=kube-system:default.
I want to confirm: can we run openwhisk on a kubernetes cluster without cluster-admin role?

I think it could work to use helm template to render the yaml and then kubectl apply on the yaml.
Instead of
helm install ./helm/openwhisk --namespace=openwhisk --name=owdev -f mycluster.yaml
do
helm template ./helm/openwhisk --namespace=openwhisk --name=owdev -f mycluster.yaml > tmp.yaml
kubectl apply -f tmp.yaml

You'll need some level of privilege to deploy OpenWhisk on Kubernetes because the OpenWhisk invokers need to be able to create additional containers to execute the user's functions.
When using the DockerContainerFactory, this is done by mounting several Docker-related volumes via hostPath mounts into the invoker container (see https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/helm/openwhisk/templates/_invoker-helpers.tpl#L5-#L21)
When using the KubernetesContainerFactory, this is done by giving the Invoker Pod increased privileges so it can create pods itself (see https://github.com/apache/incubator-openwhisk-deploy-kube/blob/master/helm/openwhisk/templates/invoker-role.yaml).

Closing as I don't think we can support deploying OpenWhisk onto a cluster where the user deploying OpenWhisk does not have at least some admin capabilities as noted in my previous comment.


Rename ProblemId.getParent() to ProblemId.getGroup()

This change increases comprehensibility of the API.

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


Possibility to add/change user password given by file

For the admin tool I have added a possibility to set the password from a file instead from command line. The password is imported as JSON, so it needs to be enclosed in quotes, and the file must be a .json file.
The --password option may still be used and has priority over --password-file.
Also see #109.

Thanks a lot!

For the admin tool I have added a possibility to set the password from a file instead from command line. The password is imported as JSON, so it needs to be enclosed in quotes, and the file must be a .json file.
The --password option may still be used and has priority over --password-file.
Also see #109.

Nice Brotha I'm gona Full Sail this


Not working on YouTube Music

Seems something changed and the keys are not sent/recognized by YouTube Music today.

I did not work out how to test it but it seems the selector in keysocket-youtube-music.js needs to be adjusted. Simply removing the 'paper-icon-button' token was enough to make that work in the console at least.

Yes confirmed with a local install, that is sufficient.

Yes confirmed with a local install, that is sufficient.

Hi. How to fix the problem yourself locally please? Thanks

After I modified keysocket-youtube-music.js to reference these selectors:
('#left-controls .next-button')
('#left-controls .play-pause-button')
('#left-controls .previous-button')
and then load it locally I was able to get it to work.

Has this just been abandoned? There's a clear fix for this and it's been almost a year with no implementation.

Facing the issue still with youtube Music,
For Other Platform it's working fine.


Add javadoc for Talon SRX library

There is a javadoc provided in the Talon library zip, could we could include that so it is available from gradle?
Also, it may be better to call it something like CTRLib, instead of talonSRX in the gradle file since it is actually more general than just the Talon SRX.

I'll take a look at JavaDoc publishing.
I think talonSrx is just fine (most people only use it for talon srx), however I can add an alias

Yeah, the name is fine. Thanks for looking into it.

Since CTRE has since released Pheonix which breaks backward compatibility and adds wayyyy more stuff than just the CANTalon libraries, I think a renaming of the dependency, even if it is an alias, is absolutely necessary.

I should mention this has already been done in the queued 2018 refresh of GradleRIO
https://github.com/Open-RIO/GradleRIO/blob/refresh2018/src/main/groovy/jaci/openrio/gradle/wpi/WPIDependencies.groovy#L85-L88

Awesome!

This is now in the vendor's hands with https://github.com/CrossTheRoadElec/Phoenix-frc-lib/pull/5


Not able to launch the kernel

Describe the bug
Can't connect to the kernel:
Error message: "The kernel has stopped due to the following error: The first packet is not a InputNamePacket; packet=$Failed
Expected behavior
No error message.
Screenshots

Environment (please complete the following information):

Operating system: Windows 11
Mathematica/Engine: 13.1
VS Code: 1.79.2
Version:

Additional context
I was able to run the kernel right after installation, but after then I was not able to re-launch it.

Do you have the official Wolfram language extension installed? If you have it, disable it. It already calls a wolfram kernel on startup interfering with this extension.

Ah, I see. Thank you for the suggestions! It worked.


DCOS-46438 - Synchronize integration test requirements with panda package versions.

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot override-status teamcity/dcos/test/aws/onprem/static/group3 DCOS-48351

@orsenthil would you be able to apply the override here?

Hi @jbarrick-mesosphere  - The PR description is helpful. We have to update our PR template too.

I triggered the flaky test. I want to make sure if that is a flaky, not something that is related to change in dependencies being introduced here.


Port following/followers to GraphQL

          1 Warning

:warning:
Please provide a linked tracker story for this PR in the description

  Generated by :no_entry_sign: Danger

Stale, closing this.


[cxx-interop] Add UnsafeCxxMutableRandomAccessIterator protocol

This will be used to provide a safe overload of std::vector::erase in Swift.
std::vector::erase is not currently imported into Swift because it returns a C++ iterator.
rdar://113704853

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test Linux


feat: add parse alignment for p tag

#39
@pavittarx could you please review this PR, if you have any concerns please let me know. Thanks

Thanks, @LanceRabbit. :+1:

Thanks, @LanceRabbit. 👍

Thanks for your review @pavittarx, but only you can merge this PR. Still need your favors to finish this process.

@LanceRabbit I did the Review, but have not been able to test it. I'll merge and get it ready for a release, once done.

@pavittarx @LanceRabbit Any update on this? I see that the last release is from Jun 27, 2021. I also really need support for text alignment in the HTML of the editor


JSON_PARSE_ERROR from listFinancialEvents

Hey @amz-tools, we've been experiencing one of the known issues that is mentioned on your repo/library.
We've utilized the raw response option but we're pretty lost on how to actually handle the parsing properly.
Any idea what the best way to handle these type of errors?

Hi @arontolentino,
what we do is a regex replace on the raw body and then we are able to parse it:
let unknown_chars = {
  '\\\\\\\\xf6':'ö',
  '\\\\\\\\xe4':'ä',
  '\\\\\\\\xfc':'ü',
  '�':'ü',
  '"':'',
  '\\\\–':'-'
};
for (let unknown_char in unknown_chars) {
  res.body = res.body.replace(new RegExp(unknown_char, 'g'), unknown_chars[unknown_char]);
}
let finance_doc = JSON.parse(res.body.replace(/\n/g, ''));

Not very beautiful and I am not sure if this really replaces everything correct, but for our case it works fine, as we don't need the titles etc. but only the financial values and SKUs. So basically the idea for us was to just make it parseable.

@amz-tools
We had a breakthrough as well right after I created this issue.
Our solution is very similar to your solution. We utilized str.replace(/[^\x20-\x7E]/g, '') to remove any non_ascii values before we JSON.parse() the processed string.
Same goal as your team - we just needed to get access to the financial values to do some calculations.
Side note: You and your team are amazing. Thank you for all your help so far! I would love to buy your team some coffee on behalf of my team. If there is anyway we can do that, please let me know how.

@arontolentino,
great! Yours looks a bit nicer than ours though. We might adopt that.
Thanks for the nice feedback! We are definetly coffee junkies, so feel free to send as a pack of coffee, we'd much appreciate it. :-)
Don't know where you're located, you can find our address in our imprint on amz.tools, we are based in Germany.

@amz-tools You got it! We're from Toronto, Canada. I'll look for some local coffee products and have it delivered to you. I'll notify you once the order has been placed!

The same error when there are double quotes in the text

My solution for double quotes, i'm just replace ProductDescription to another text witout double quotes.
router.get('/finances/:operation', async (req, res) => {
    try {
        let result = null;
        let sellingPartner = initSellingPartner();
        let finances = new Finances(sellingPartner);
        let options = req.query.options ? req.query.options : {};

        if (req.params.operation) {
            result = await finances.callMethod(req.params.operation, options);
        }

        res.send({
            status: true,
            data: result
        });
    } catch (e) {
        if (e.code === 'JSON_PARSE_ERROR') {
            try {
                let jsonResult = JSON.parse(e.message.replace(/\"ProductDescription\"\: \"(.*)\"/g, '"ProductDescription": "deleted"'));

                console.log('jsonResult')

                return res.send({
                    status: true,
                    data: jsonResult.payload
                });
            } catch (e) {}
        }

        res.send({
            status: false,
            msg: e
        });
    }
});

As this is only an issue for finance documents prior to May 2020 and the finances operation only returns data for a maximum of two years of historic data this will be "autofixed" in May 2022.


HSV Lerp

This PR allows the ability to lerp colors using HSV.
~Currently, it assumes the values in the pointData are in HSV format.~
~Simply put, it lerps the values and then converts them to RGB.~
The values are in RGB format. When the next point (pointR) is marked hsv, the values will be lerped using HSV values and converted back to RGB internally
Usage:
"color": [
[1.0, 0.0, 0.0, 1.0, 0.0],
[0.0, 0.0, 1.0, 1.0, 1.0, "hsv"]
]

Evidence of the PR working as intended https://imgur.com/a/dE7h5lO


Feature workspace

Hi man, this PR is a feature proposal. The mixed dependence is a interesting proposal but, by  my self, I prefer yarn workspaces.
But configure and manage a Yarn workspace with Typescript is boring. That proposal use the simplicity of uni.yml to configure a entire Yarn Workspace with TypeScript, Jest and Lint by replacing index property to folder property. All of your code still compatible.
All unis created files like package.json, tsconfig, jest.config,
eslintrc files are in .gitignore because uni.yml will generante them
things to do:

[ ] A initoption to guid developer create uni.yml
[ ] Allow tsconfig.json settings changed by dev
[ ] Options to configure importante parameters like minimal test coverage (currently is fixed in 90%)
[ ] more uni tests and examples
[ ] husky
[ ] ...

I'll continue helping that amazing project.
I hope you like that idea.
Extra: This PR also have VSCode devcontainer suggestion. Maybe itcan facility bring new contributors to uni team.

Hi @teintinu,
Glad you're excited! This is a lot of code here and there's a lot of ideas swirling around in your message. It's going to be pretty difficult for us to review this, so maybe we could take a step back and try to nail down what problems you're solving and how before we dig in to the code.
For starters, what problem are you trying to solve by introducing Yarn?
Thanks,
Brandon

Hey @teintinu, Judging from the commits you've just pushed, it looks like you're preparing for a fork over to github.com/teintinu/monoclean - Unirepo is MIT Licensed, so you're free to do that. I'm going to close this PR for our tracking purposes. Good luck with your project.


Add thee dots menu

fixes #513

Should also add Claim to the dropdown. cc @CedrikNikita

Is this ready for review? cc @CedrikNikita