[Request] Hue and Saturation for Yeelight Color bulb

According to someone from the Xiaomi Yeelight staff there is an interface to change hue and saturation for the Yeelight Color bulbs. Would be nice if this could be added to the YeelightColor class next to the setRGB (which seems to be undocumented in the device documentation).
My Yeelight Color bulb is still on transport from China so cant check if this interface is exposed though.

Yeah, I think there is a call for setting those values. I saw a reference to it when I implemented the first version of the API for the Yeelights.
I have color bulb on the way as well so haven't been able to implement and test it yet. Looks like it might arrive this week though so shouldn't take long after that to add support for this.

Nice, if there is anything I can do to help (once my bulb arrives) let me know.

Well, I just found out that there are no seperate calls for hue and saturation but there is a set_hsv that allows to set hue and saturation in a single call, but only if color_mode is set to 3.
You probably are already aware of this but everything is pretty well described here: https://www.yeelight.com/download/Yeelight_Inter-Operation_Spec.pdf
I'm not much of a programmer so I'm hoping you can work with this and implement it in a future release.

Not sure if this is a bug or if I'm doing something wrong. I was trying to test the set_hsv methode through the CLI but I cant get any params to work. I tried a couple of different syntaxes for the params but they all end up with mostly the same error.
I have tried:

miio --control <IP_ADDRESS> --method set_hsv --params '[255,45,"smooth",500]' (as documented)
miio --control <IP_ADDRESS> --method set_hsv --params '["255","45","smooth","500"]'
miio --control <IP_ADDRESS> --method set_hsv --params [{255,45,"smooth",500}]

All end up with something like:
(node:13768) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): SyntaxError: Unexpected token ' in JSON at position 0
or
(node:20424) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): SyntaxError: Unexpected number in JSON at position 2
Could you point me into the right direction?

It might be that the Yeelight does something special with its responses. I haven't had the chance to unpack and have a look at mine yet. Hopefully soon.
You can try running miio with debug on and see if that makes more sense:
DEBUG=miio* miio --control <IP_ADDRESS> --method set_hsv --params '[255,45,"smooth",500]'

I think it mentions somewhere in the manual that these bulbs silently drop requests if they don't have an "id" prop. And requests must end with: \r\n\.

I'm closing this issue, you can control the Yeelights directly through their open API. No need for this library.


http_status: 200, error: 1005, SystemException, Client id invalid when using find_videos_by_ids

Hi, can you check the youku.find_videos_by_ids method?
while using youku.find_videos_by_ids(ids) I'm getting
http_status: 200, error: 1005, SystemException, Client id invalid
the same client ID  works fine with uploading
my
ids = ['XMzg3NzcwNjEwNA==']
thank you

I simply test api.youku.com , it doesn't support old find_video_by_id method. But you can use find_video_detail_by_id method instead, it is ok, I updated it last time.

It looks like only these two methods are currently supported
http://cloud.youku.com/docs/doc?id=43

Thank you find_video_detail_by_id works fine.


Consolidate roles and permissions with Admin App

Users with the dashboard editor role should only see their own
dashboards, not all
Introduced admin and dashboard-editor roles and permissions

See story: https://www.pivotaltracker.com/story/show/97212736

@leenagupte we have a set of resource based roles e.g. you can do anything to do with dashboards and now task based roles e.g. I want to edit dashboards or I am an admin who wants to do everything

It would be good to write a little bit about the permissions given to the different roles, especially about the Dashboard POST permission

Updated commit message to elaborate on the differences between admin and dashboard-editor roles, and to mention why dashboard-editor requires the Dashboard resource POST permission.


TEXT-172: Failing test case to escape apastrophe

Failing test case for the JIRA TEXT-172

Closing the PR. As the corresponding JIRA has been closed.


Remove "THIS CODE IS GENERATED" comments 12 of 12

same as https://github.com/opensearch-project/opensearch-java/pull/235 but broken down into different commits / branches.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

closing in favor of one PR with all the commits #263


Basic image upload

A user needs to

be able to easily upload an image to an article
specify where in the article the image should appear

Acceptance criteria

[ ] User can click "upload", navigate to an image file (png, gif or jpg), and it should be included by default at the top of the article
[ ] File browser should not show non-image formats
[ ] User can move the image up or down in the article

For first pass, it's fine that the image is exactly the size that was uploaded (scaled to fit 100% inside the container element).

It could be great to add an image directly from the markdown editor

It's implemented but not yet merged. Check out https://github.com/netlify/netlify-cms/pull/82

Great ! thank you very much

Great ! Thank you


Milvus_cli GPU_IVF_FLAT is not supported. Please fix the bug.

I just want to test Milvus on GPU server with milvus_cli. But there is no any GPU_IVF_FLAT option to create index. The output is like that:                                                                                Milvus cli version: 0.4.0
Pymilvus version: 2.3.0
Learn more: https://github.com/zilliztech/milvus_cli.
milvus_cli >
milvus_cli > create index
Collection name (docs_general, car): car
The name of the field to create an index for (id, vector, color, brand): vector
Index name: idx_vct
Index type (FLAT, IVF_FLAT, IVF_SQ8, IVF_PQ, RNSG, HNSW, ANNOY, AUTOINDEX, DISKANN, ) []:

@mjafar84 Hi, sorry for the late reply. I already support GPU_IVF_FLAT in last version. You can try it again.


Add getAuth stub

Adds the getAuth stub to Java

Current coverage is 81.27% (diff: 100%)

Merging #455 into disco_head will not change coverage

@@           disco_head       #455   diff @@
============================================
  Files             183        183
  Lines            6971       6971
  Methods             0          0
  Messages            0          0
  Branches          909        909
============================================
  Hits             5666       5666
  Misses           1033       1033
  Partials          272        272

Powered by Codecov. Last update 51f8f4f...e6a472f

LGTM


Pipe Shell Command (M-|) should be prefixed by C-u

Pipe Shell Command needs to be more like Emacs:

M-| by itself should show the output in the minibuffer
To replace the text in the buffer it should require C-u M-|
C-u is currently mapped to delete backwards which is not correct

This is not implemented well. Instead of setting an editor configuration attribute cu_prefix, I should instead have C-u read as a first key stroke just as C-x is. Then recognize M-| in there as a second one. Call editorPipeCmd with a new argument cu_prefix.


Configure for Flask

Instructions: http://flask.pocoo.org/docs/0.12/tutorial

Recommended directory structure:
/flaskr
    /flaskr
        /static
        /templates

closed ref #2 #3


Feature/bai 363 add model favouriting tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ARADDCC011:x: ARADDCC013ARADDCC013 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove vulnerabilities from js includes

Library Version
Vulnerability Count
Highest Severity

<EMAIL_ADDRESS>1
Medium

<EMAIL_ADDRESS>1
Medium

updated jquery, bootstrap is maybe customized so I won't change it


Automatically remove non-init attributes from dataclass hash/eq/repr

Codecov Report

Merging #1546 (d605d73) into main (1dfc64b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:exclamation: Current head d605d73 differs from pull request most recent head 2330c3f. Consider uploading reports for the commit 2330c3f to get more accurate results

@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
+ Coverage   82.73%   82.75%   +0.02%
==========================================
  Files          68       68
  Lines        5572     5579       +7
==========================================
+ Hits         4610     4617       +7
  Misses        962      962

Impacted Files
Coverage Δ

flax/linen/linear.py
98.38% <100.00%> (ø)

flax/linen/module.py
93.23% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfc64b...2330c3f. Read the comment docs.


Derive tuple labels for rest elements from array binding patterns

While working on #58243, a community member asked if we could label the tuple we use to properly type arguments to the next() methods of iterators and generators. A brief experiment showed that directly labeling the tuple element resulted in the creation of thousands of new types in some tests since iterator/generator instantiations would produce new named tuple elements since named tuple elements are cached far less frequently.
An alternative to that approach would be to use an additional source for the label when the label comes from a rest parameter whose name is actually an ArrayBindingPattern:
declare function a(...args: [] | [number]): void;
a(1); // quickinfo shows `(args_0: number)`

declare function b(...[value] : [] | [number]): void;
b(1); // quickinfo now shows `(value: number)`
      // quickinfo previously showed `(__0_0: number)`

Since this is merely treated as an additional labeling source, there is no need to synthesize additional types for named tuple elements.
This also improves label inference in other cases such as elision and object assignment pattern elements:
declare function a(...[x, , z]: [number, number, number]): void;
a(1, 2, 3); // quickinfo shows `(x: number, arg_1: number, z: number)`
            // previously showed `(__0_0: number, __0_1: number, __0_2: number)`

Related https://github.com/microsoft/TypeScript/pull/58243#discussion_r1586225461
Fixes #56289
Supersedes #57619

@typescript-bot test this

@typescript-bot test it

Seems fine to me, but does need a sync from main and baseline update.


Footer

add Dan

Designed by @amablex for common navigation. Will need documentation and code for design system.


Problems with form-action CSP behind load palancer

[x] I read and understood how to enable logging

This issue is similar to #1811. After upgrading from 2.0.3 to 2.0.4 the callback to the client is broken with
Refused to send form data to 'http://tesmar4-qa.chg-meridian.com/' because it violates the following Content Security Policy directive: "form-action https://tesmar4-qa.chg-meridian.com".

The problem is, that no configuration says that http should be used. Everything should be running on https.
The response header of the callback page (https://xy.com/connect/authorize/callback?client_id=tesma&redirect_uri=https%3A%2F%2Ftesmar4-qa.xy.com%2Fsignin-oidc&response_mode=form_post&response_type=code%20id_token&scope=openid%20leaseService%20documentService%20assetService%20masterdataService%20datacontext&state=OpenIdConnect.AuthenticationProperties%3D0HwTJ...)
defines following CSP (Content-Security-Policy)
default-src 'none'; frame-ancestors https://tesmar4-qa.chg-meridian.com; form-action https://tesmar4-qa.chg-meridian.com; script-src 'sha256-VuNUSJ59bpCpw62HM2JG/hCyGiqoPN3NqGvNXQPU+rY=';
The callback page returns the correct HTML:
<form method='post' action='https://tesmar4-qa.chg-meridian.com/signin-oidc'><input type='hidden' name='code' value='fe8cbe360aef6e2b5f4fb4f10bf3f1dd954eddcf30d503681894bdc6e8189b63' />
<input type='hidden' name='id_token' value='ey...' />
<input type='hidden' name='scope' value='openid datacontext leaseService documentService assetService masterdataService' />
<input type='hidden' name='state' value='OpenIdConnect.AuthenticationProperties=0HwTJ...' />
<input type='hidden' name='session_state' value='TNH2qF4vQwLxUBFdcdOLaYkebWTC1NT5iV6yZts_HwY.73d9d792d4cdc5fc98bb636c1e6cda48' />
</form><script>(function(){document.forms[0].submit();})();</script>

What might be a root of this issue is, that we're running behind a load balancer doing SSL offloading. Therefor we already set the PublicOrigin and IssuerUri option to the public url.
I guess the bugfix #1748 (which introduced the form-action CSP) might be a problem. I can reproduce it with Chrome (64).

I'm the author of #1811,
After  publishing, we're having the same issue where it works fine on localhost.
Refused to send form data to 'https://abc.edu.tr/connect/authorize?client_id=sabis.adabis.mvc&redirect_uri=https%3A%2F%2Fadabismvc.sakarya.edu.tr%2Fsignin-oidc&response_type=code%20id_token&scope=openid%20profile%20offline_access&response_mode=form_post&nonce=636487535314992627.M2YzNDAzYTMtNzg5YS00MzIwLTkyYjQtMjk5NDY3MmQ5YmMxZGYyYjk2ZDQtYjQ2ZS00N2E2LTllYWQtYjkyYjdhNDhmNTU0&state=CfDJ8KEMmXMUTTpNhx0xZPiKaIbS1v2vzr_t_InIpmYv6VXUUeH76kZoTj9seLB-kEd4OznfO8BTZUgI9EmY-XlOXDJbZEMAc8-c4DzuTckGCf3J6wr_8Ix4vEraiZeLUXSupVdvC3oV8VT7NkC0p4pdQO2MzfvUhm6QLDavzdMwXVlD2uJGifkTcVnPhod0f_Ahc_pfRVqL9k-bAnkPVaZoFfjM8pPg1dZsbo-gFYtsUS5HmH6Uq7dd8XRY1WFNdkPXVcSreWEQxUbgXyzcV1dUu59e-CODSUu_vU8nHvF_VoAK4nGiSsj4xn21KbwiJibDSBUDgO0yC8vyF7qHlbzd020b5IpaHvc-ukHK9ZhJ9jM6&x-client-SKU=ID_NET&x-client-ver=<IP_ADDRESS>' because it violates the following Content Security Policy directive: "form-action https://adabismvc.sakarya.edu.tr".

callback response header:
Content-Security-Policy:default-src 'none'; frame-ancestors https://adabismvc.sakarya.edu.tr; form-action https://adabismvc.sakarya.edu.tr; script-src 'sha256-VuNUSJ59bpCpw62HM2JG/hCyGiqoPN3NqGvNXQPU+rY=';

And this is identityserver:
<PackageReference Include="IdentityServer4" Version="2.0.3" />

I still couldn't check client logs but not sure if I'll find the solution there.

We've also been running into this issue in IdentityServer4 2.0.5 and 2.0.4, though through a different workflow.  CSP is blocking the redirect to RedirectUrl after successfully logging in with no load balancer or other infrastructure in place.  For a temporary workaround (before realizing we could just downgrade) we found that if we enabled the consent screen (RequiresConsent=true), everything worked fine and the issue was avoided.
As for the actual error, this is what is what we get:
Refused to send form data to 'http://localhost:64062/' because it violates the following Content Security Policy directive: "form-action http://localhost:5000".

Downgrading to IdentityServer4 2.0.3 fixes the issue.

@zapatodefuego

Refused to send form data to 'http://localhost:64062/' because it violates the following Content Security Policy directive: "form-action http://localhost:5000".

This tells me your CSP is on the login page, right? Did you happen to update it to the latest CSP we issue in the quickstart UI? https://github.com/IdentityServer/IdentityServer4/blob/release/src/Host/Quickstart/SecurityHeadersAttribute.cs

I have removed the form-action that was added in the 2.0.4 release. Can you test against the myget feed that contains our dev builds? http://docs.identityserver.io/en/release/intro/packaging.html
Thanks.

Actually, to make it easier to test we pushed a 2.0.6-preview1 to NuGet. Have a look, please.

I have upgraded the identity server from 2.0.5 to the 2.0.6-preview1 and the error is gone. Though I am still puzzled as to why this has been happening to me.
I will describe my case FWIW. We did not have a load balancer.
Puzzling fact #1: The error only appeared if the client application hit my OnRemoteFailure event which redirected to Home page like this
context.HandleResponse(); context.Response.Redirect("/Home");
Puzzling fact #2: All the header values were equal to the those if no error was occurred.
P.S. Firefox had been ignoring the error and just redirected.
P.P.S I used OnRemoteFailure for an unrelated thingy (nonce stuff).

I have seen odd behaviors in Chrome when there are several redirects involved and it seems like the CSP from the last visible and rendered page is what's honored.

With the 2.0.6-preview1 version the error is gone.

@twenzel  I have same issue with 2.2.0 version

I don't want to open new issue so i wrote here. I am facing the same problem too with IdentityServer4.AccessTokenValidation (version 2.6.0)


Fix for Issue #12410:Issue/uma tflite

There was a flaw in uma_lower (see issue #12410) that lead in some case to a different  argument ordering of the  cached_func and the Relay function. This results in an incorrect  lowering of the primfunc and eventually a wrong result of a run-time error, in some cases.
This commit adds code to correct the described misbehavior and a unit test case to check this end-to-end functionality with a TFLITE model.

@areusch  @cgerum @manupak   this is a fix to bug #12410

@mbaret wondering if you know the answer to this one (see attached PR)?

@areusch, you are referring to the question from https://github.com/apache/tvm/issues/12410, right?
"
Seems the bug is in the lowering step from relay_prim_func to tir_prim_func.
When collecting the input arguments, the order gets messed up. By replacing the function _get_tensors here
https://github.com/MichaelJKlaiber/tvm/blob/issue/uma-tflite/python/tvm/relay/backend/contrib/uma/api/lower.py#L83
by
            return list(te_cached_func.inputs) + list(te_cached_func.outputs)

everything works perfectly fine for all the test case we provided including the tflite import
Does anyone know if it is sufficient to rely on the .inputs parameters from te_cached_func ?
"

@manupak, could you also review? There are some minor changes in aot.py, as well

Thanks @MichaelJKlaiber!


Serverside StyledComponents for many @Html.React calls

Hello,
What is the best way to use StyledComponentsFunctions and ChainedRenderFunctions for multiply components?
Currently i'm trying something like
    var component1StyledComponentsFunctions = new StyledComponentsFunctions(); var component2StyledComponentsFunctions = new StyledComponentsFunctions();
@Html.React("Component1", new { initialData1 }, clientOnly: clientOnly, renderFunctions: new ChainedRenderFunctions(component1StyledComponentsFunctions))
@Html.React("Component2", new { initialData2 }, clientOnly: clientOnly, renderFunctions: new ChainedRenderFunctions(component2StyledComponentsFunctions))
@Html.Raw(component1StyledComponentsFunctions.RenderedStyles) @Html.Raw(component2StyledComponentsFunctions.RenderedStyles)
But in this case I have two

If the generated styles are overwriting each other, you may need to make your style definitions unique. Hard to say without an example. It should “just work”..

Just to add to this, there isn't a good way to deduplicate the styles with multiple component renders. I'd recommend consolidating your components together if possible, or disabling server-rendering and using React portals to render into specific divs if you have a lot of other non-React view code in your app :)


Foldable[T].traverse_ exercises accepts wrong answer as correct

On the exercise of Foldable traverse, it accepts a wrong answer as proper:
import cats.implicits._

def parseInt(s: String): Option[Int] =
  Either.catchOnly[NumberFormatException](s.toInt).toOption

Foldable[List].traverse_(List("1", "2", "3"))(parseInt) should be(Some(42))

Since traverse_ returns G[Unit], correct answer should be Some(()). But it is accepting Some of anything. Maybe it is even a bug on scalatest since on a workspace:
Foldable[List].traverse_(List("1", "2"))(parseInt) == Some(())
Foldable[List].traverse_(List("1", "2"))(parseInt) == Some(42)

Outputs:
true
false

This also applies to the last Traversable exercise:


Race condition when installing node

Use case: using pyright in CI ; job runners run on the same machine and same user (but different workspaces). Node is not installed yet. You just sent two commits to be type checked at the same time. It will easily trigger the following race condition:
export PYRIGHT_PYTHON_GLOBAL_NODE=0 PYRIGHT_PYTHON_NODE_VERSION=16.20.1
pyright &
pyright

More details:
 * Install prebuilt node (16.20.1)  * Environment already exists: /home/anisse/.cache/pyright-python/nodeenv
 * Install prebuilt node (16.20.1) ......... done.

Traceback (most recent call last):
  File "/tmp/pyright/lib/python3.10/site-packages/nodeenv.py", line 652, in copytree
    shutil.copytree(s, d, symlinks, ignore)
  File "/usr/lib/python3.10/shutil.py", line 559, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "/usr/lib/python3.10/shutil.py", line 457, in _copytree
    os.makedirs(dst, exist_ok=dirs_exist_ok)
  File "/usr/lib/python3.10/os.py", line 225, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/home/anisse/.cache/pyright-python/nodeenv/bin'

During handling of the above exception, another exception occurred:

I am not sure it is nodeenv's role to work around that since it is pyright-python that choses the install directory. A potential workaround would be to use a file lock in $XDG_CACHE_HOME/pyright-python-<node-version>.lock

I'm going to close this as the next release will add support for nodejs-wheel as an alternative to nodeenv which should be more reliable and will be the recommended way to use pyright going forward.
It should also avoid this race condition you're running into.
You can try it out today with
python -m pip install 'git+https://github.com/RobertCraigie/pyright-python.git#egg=pyright[nodejs]'

When released, it will be
pip install pyright[nodejs]

Please let me know if you run into any issues with this new setup.


mirrord shows loopcrashbackoff pods as possible targets

Hey, I'm interested in picking this one up :)

Hey, I'm interested in picking this one up :)

You got it! Let us know if you need any help (:

Closed with #1669


future should not be blanket-ignored in py3

I have a project using python-jose and future is omitted in py3 with no recourse, but it does install fine in py3.
pip-compile does properly add it. and there is no mechanism to override this from the py3 ignore list.
Was added as an ignore in https://github.com/peterdemin/pip-compile-multi/commit/2d2ef07dd0be4cf58c55ad785db349e6eb94e856  perhaps add it as a p3 only default for ignore (and let us specify a blank ignore list?)

I see, sorry for the need to build workarounds.
I just tried to install future in Python 3.4, 3.5 and 3.6.
Originally this condition was added to work around a bug in pip: https://github.com/zulip/zulip/blob/master/tools/update-locked-requirements#L23
Apparently, this is no longer needed. I'll release a fixed version at the earliest convenience.
Thanks for reporting!

I released 1.2.2 with the fix.


Refactor how to set extra_vars for playbook

All user defined variables must be placed under extra_vars argument in the action section.
Variables from a static file are not automatically included in extra_vars set to a playbook. They however can be referenced in user defined extra_vars section.
Rulebook automatically inserts fact/facts/event/events variables under the common top level variable ansible_eda.

Resolves AAP-8088 and AAP-7760

Will add a new doc to explain in detail how to set extra vars and how to reference them in playbooks.

Added extra_vars.rst with explanations and examples.

@mkanoor I now set the prefix key in the beginning. Refactored a test to include the variable substitution.

@bzwei @Alex-Izquierdo It might make sense to capture the rule name and the ruleset name in our extra vars along with event/events/facts/fact.

@bzwei @Alex-Izquierdo It might make sense to capture the rule name and the ruleset name in our extra vars along with event/events/facts/fact.

What would be the usecase? logging purposes?
Probably it could be added to the event.meta, don't?

e2e tests fails because the playbook points to {{event}}

@bzwei @Alex-Izquierdo It might make sense to capture the rule name and the ruleset name in our extra vars along with event/events/facts/fact.

What would be the usecase? logging purposes?
Probably it could be added to the event.meta, don't?

@Alex-Izquierdo It completes it, since the playbook or job template knows which ruleset/rule triggered an action. It's up to the playbook/job template if they want to use it. We are capturing it on our side in the event log and sending it to eda server. I think it would be  root key in the ansible.eda{ruleset=abc,rule=xyz,event=...,events=...,fact=...,facts=...}


Sticky Layer can't be imported and is missing in node_modules

Hey, I am on Version 0.5.2 and I am unable to import the StickyLayer component so I looked up the node_modules and there the StickyLayer.svelte component is also missing, I tried to reinstall svelte-parallax, but this also did not fix it.

hi!
its my fault for not making it clearer -- but the version with StickyLayer has not been released yet.
i'm away from my computer until tuesday, but i'll publish a new version then!

@Nico-Mayer StickyLayer is now available with version 0.6.0.


BZ#1442616-Update translations on master to lastest from zanata

https://bugzilla.redhat.com/show_bug.cgi?id=1442616
Updates translations of current master, restores localeName string, f release translations didn't have this, it was an issue when building available languages
see, only the ones we have translations for!

Just translation updates, nothing to review.  No UX changes.  Merging.

@AllenBW The BZ was opened against a build in Fine branch. Which PR fixed this in Fine?

oh! @simaishi sorry didn't see this sooner, https://github.com/ManageIQ/manageiq-ui-service/pull/739 👍


Cannot make adjustment to container style for mobile screens.

I a trying to make the chat box size look bigger on mobile screen, and maintain it's current size on bigger screen. There is no provision for different media queries sizes

Hi @PreciousNiphemi.
Could you elaborate on what you mean by chat box size look bigger on mobile screen, and maintain it's current size on bigger screen.
If you want to use different styling based on the device you are using e.g. web vs mobile, you can add conditional styling values to the chatStyle. This may vary depending on the Framework you are using, but here is a simple example:
if (isMobile()) {
  chatElementRef.chatStyle = {width: '100wh', height: '100vh'};
} else {
  chatElementRef.chatStyle = {width: '400px', height: '300px'};
}

If you want the style to be more dynamic - I recommend checking out the max-width, max-height properties along with calc values.
If you really insist on using media queries, you can use them with the !important value in your app's css style which will overwrite the styles used in Deep Chat. However we do not recommend going in this direction as using !important is a little bit of an anti-pattern in general terms of css and overwriting some Deep Chat styles carries a chance of disrupting internal Deep Chat styling functionality - so use this at your own risk:
@media (max-width: 1478px) {
  deep-chat {
    width: 400px !important;
  }
}

@media (max-width: 400px) {
  deep-chat {
    width: 100% !important;
  }
}

Let me know if these options work for you. Thanks!

I will be closing this issue since there has been no further communication. Feel free to comment below or for anything else create a new issue. Thanks!


Add ci

Add CI to the backend of openenclave/oeedger8r-cpp against multiple platforms and compilers.

bors try

Statuses are not working correctly 👎

bors try

bors try cancel

bors try-

One thing I see is that the Windows Logs show as if the pipeline stopped at build and did not execute the tests:
https://oe-jenkins-dev.westeurope.cloudapp.azure.com/blue/organizations/jenkins/oeedger8r-cpp/detail/trying/3/pipeline/16

bors try

bors try-

bors try


Testing presigned url Api

Create a Simple curl command to make sure the presigned url functionality is working .
Also, set up how we are going to do the smoke tests:
create a new plan_apply template to use in the data platform workflow https://github.com/ministryofjustice/modernisation-platform-environments/blob/eccbab9f34d16a1d78491452f5281970ab4ca659/.github/workflows/data-platform.yml#L47
the new workflow should run some tests, but only for the development account.
Ideally, the apply should only run for development upon completion of the terratest code
Definition of Done
Should be able to upload the data and query in Athena

I have a working script for this. It's not clear how this script is automated/if it is yet

Increasing the 1000 invocations limit for lambda requires a request https://repost.aws/knowledge-center/lambda-concurrency-limit-increase
Probably not something we want to bother with

https://github.com/ministryofjustice/modernisation-platform-environments/pull/3346


Bug: $ban not deleting the messages of the given timespan

Bug Type
Function
Bugged Function
$ban[guild;user;days;reason]

Not deleting the messages given in the deletionDays argument (of the given time span).
https://discord.com/channels/773352845738115102/1123918875751370905

Version of aoi.js
v6.2.6 - v7.0.0
Version of Node.js
v18.14.0 (LTS)
Excepted Output
The "bot" deleting the messages of the given user of the last 7 days or so.
Relevant log output
N/A

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The issue is days has been deprecated in discord.js, it should be replaced with the deleteMessageSeconds parameter.
* https://discord.js.org/#/docs/discord.js/main/typedef/BanOptions

yes indeed it got deprecated, but that is not the issue
issue is that property name is changed from days to deleteMessageDays
which is why it didn't delete it
but yes it has to be changed to deleteMessageSeconds

Entirely rewrote the function to support 7 to interpret as 7 days.
Resolved in commit: https://github.com/AkaruiDevelopment/aoi.js/commit/5b98b6f8f601cddadc2314ae9ef59de979f30104


Update Pages “home”

Automatically generated by Netlify CMS

👷 Deploy Preview for shimmering-marigold-4f5b4a processing.

Name
Link

🔨 Latest commit
2dc173a460c22f60ff9d1d7efddb882b4ba1b8b7

🔍 Latest deploy log
https://app.netlify.com/sites/shimmering-marigold-4f5b4a/deploys/633806fe0c7b080008a45402


Doesn't build out of the box: casting &T to &mut T

I currently get the following build failure:
mini-me@virtucon ~/h/c/hyperon-experimental ((v0.1.5))> cd lib
mini-me@virtucon ~/h/c/h/lib ((v0.1.5))> cargo build
    Updating crates.io index
   Compiling proc-macro2 v1.0.66
   Compiling libc v0.2.147
   Compiling unicode-ident v1.0.11
   Compiling memchr v2.6.3
   Compiling regex-syntax v0.7.5
   Compiling log v0.4.20
   Compiling termcolor v1.2.0
   Compiling humantime v2.1.0
   Compiling mopa v0.2.2
   Compiling smallvec v1.11.0
   Compiling aho-corasick v1.0.5
   Compiling quote v1.0.33
   Compiling syn v2.0.31
   Compiling atty v0.2.14
   Compiling regex-automata v0.3.8
   Compiling ctor v0.2.4
   Compiling regex v1.9.5
   Compiling env_logger v0.8.4
   Compiling hyperon v0.1.5 (/home/mini-me/home/cellar/hyperon-experimental/lib)
error: casting `&T` to `&mut T` is undefined behavior, even if the reference is unused, consider instead using an `UnsafeCell`
  --> src/space/mod.rs:75:25
   |
75 |         let cell = &mut *(&*self.0 as *const RefCell<T>).cast_mut();
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[deny(cast_ref_to_mut)]` on by default

error: could not compile `hyperon` (lib) due to previous error
mini-me@virtucon ~/h/c/h/lib ((v0.1.5)) [101]>

This build failure is all the more surprising as hyperon-experimental/lib DID build out fine out of the box with cargo build. It does not build anymore now out of the box for some weird reason.

Fixed: In between the two builds, I somehow got into rust nightly. Rust stable is necessary.
rustup default stable

The above fixes it.


Error: Cannot find module './app'

Do you upload the complete source code?

代码还在整理，一周内一定会上传
I will upload the complete code within one week

Already upload finished


Update landscaper to version v0.56.0

What this PR does / why we need it:
Update landscaper to version v0.56.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Update landscaper to version v0.56.0

I will close this PR to not  get confused. I just triggered a new release of the landscape with the required changed of the go version.


libxml2: 2.9.9 -> 2.9.10, libxslt: 1.1.33 -> 1.1.34, addressing CVE-2019-18197

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2019-18197
libxslt 1.1.34 requires libxml2 2.9.10. To get libxml2 2.9.10 building successfully I had to disable a couple of the python tests. These tests had actually always been failing on previous versions with python >= 3.5 - the results had just been previously ignored by the makefiles. We're also not the only ones to have had this problem: https://mail.gnome.org/archives/xml/2017-August/msg00014.html
I also checked the new libxslt does indeed include the fixes for the patches I removed in the bump.
Anyway, I clearly have not done a full rebuild - I OOM'd my laptop just trying to compute the rebuilds.
Supersedes #72549
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build libxml2 libxslt xmlstarlet python37Packages.lxml


Update to Symfony 7

I don't understand the failing test. It says:
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run `composer update` or `composer update <package name>`.
- Required package "symfony/phpunit-bridge" is not present in the lock file.
This usually happens when composer files are incorrectly merged or the composer.json file is manually edited.
Read more about correctly resolving merge conflicts https://getcomposer.org/doc/articles/resolving-merge-conflicts.md
and prefer using the "require" command over editing the composer.json file directly https://getcomposer.org/doc/03-cli.md#require-r
Error: Process completed with exit code 4.

BUT, symfony/phpunit-bridge is in the lock file:
https://github.com/symfony/demo/pull/1457/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5R8898

@javiereguiluz this seems related to https://github.com/sebastianbergmann/phpunit/issues/5578 and fixed by https://github.com/symfony/symfony/pull/52846
Maybe try using composer require symfony/phpunit-bridge "7.0.x-dev as 7.0.1" --dev to see if it works then

@dmaicher it worked! Thanks a lot 🙇


Namadillo: disconnecting only from the specified origin

Before this PR, Namadillo was disconnected after removing any origin in the extension. Now we pass the removed origin in the revoke event.
Fixes #898

Closing because, as talked internally, handling the revoke connection this way might lead to a security breach


Using a string as an argument in a custom function.

Hi,
I would like to make a function which would allow me to pass a string in the argument - what's the best way to do this?
eg..
Moles("Ca(OH)2")
Any help would be extremely gratefully received.

I also would love such a feature. 😉

@patricks fortunately, it's in! Quoted strings show up as Variable tokens, and it's up to you to supply a numeric value for it at evaluation time.

@davedelong that sounds amazing, but my test code fails:
let a1function = Function(name: "a1") { (state) -> Double in
    let arg1 = try state.evaluator.evaluate(state.arguments[0], substitutions: state.substitutions)
    return 0
}

let evaluator = Evaluator()

try! evaluator.registerFunction(a1function)
let expression = try! Expression(string: "a1('hello')")
let result = try! evaluator.evaluate(expression)

Can you tell me what I did wrong? I get the following error message:
Fatal error: 'try!' expression unexpectedly raised an error: MathParser.MathParserError(kind: MathParser.MathParserError.Kind.unknownVariable("hello"), range: Range(3..<10))

@patricks your let arg1 = ... line is attempting to evaluate the value of the $hello variable, but the substitution dictionary is empty, and so it's throwing an error saying "I don't know the value of $hello".
If you provide a substitutions: parameter to the .evaluate(...) call, or you provide a dynamic variable resolver, then it'll work just fine.

VariableResolver didn't also know nothing about this dynamic resolvers 👍. But I think this can't resolve my use case.
I would like to have custom functions which can import Strings and convert them into numbers. As Example
"1 + a1('B') + roman('XXX')"
In this example function a1 should use the of index the character B in the alphabet and function roman should convert the roman numeral XXX.
I hope this is understandable 😄. Or would you suggest that I should precalculate this functions into normal variables first, and use this one with DDMathParser?

In the a1 vs roman situation you describe, that'd be ideal for a custom function. You'd want the implementations to assert that the state.arguments array has one element that's a variable expression, and then you'd pull out the expression.kind.variable value to get the raw String? representation. From there you'd implement whatever evaluation logic you want.

I think the mystery is solved! 😀 Thanks so much for you help!


Just a test

This just adds a space to the schedule.md file - no need to merge, just want to check whether the deployment issues are due to the changes to the schedule or if it's an unrelated issue.

There were a couple of files Hugo started to dislike. Deleted them, all works now.

Brilliant, thank you! 🙂


add synthetic sugar to addcompletion

makes it nicer to add completion in the callback

This looks good - I just have a quick question about the __metatable property on the completion type metatable.

while at it, i wonder if i should add a compat header at top:
#if LUA_VERSION_NUM < 502
#define luaL_setfuncs(L, funcs, unused) luaL_register((L), NULL, (funcs))
#endif

and then just use luaL_setfuncs. makes code look a bit nicer.

That does look nice, but I think I prefer the #if switch in the luaopen_linenoise call, just so the code is more obviously 5.1 compatible to newcomers reading the code.

Then I think it should be ready for to merge. I fixed the __metatable protection.

Looks good, thanks!


Fix logrotate URL and sha1

fedorahosted.org was retired on March 1st, 2017.

@mesosphere-mergebot bump-ee

Yikes, it looks like that 3.9.1 is not identical as stuff involving 3dt and logs just failed. @darkonie @malnick can you take a look and find a version that works?  I think these are some insane AWS flake-outs here. Sorry to have bothered you. :grimacing:


feat: add can_transfer_local_files to executor plugin interface

Some plugins that don't assume a shared filesystem are capable of managing their own file transfers from the workflow host to the remote execution points. An example of this is HTCondor, which rarely assumes a shared filesystem between the access point and the execution point, and where HTCondor is responsible for transferring the files.
The can_transfer_local_files flag indicates the plugin -- and not snakemake -- is responsible for managing file movement between these two locations.
QC

[ ] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[ ] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester, we briefly discussed this parameter when I mentioned that I'm working to make the HTCondor executor work with non-shared filesystems. I've gotten things to work locally, and I'm starting to clean things up to merge things back upstream, and after working on the executor, these were the places I found that interfered with allowing the executor to manage its own file transfers when passing --shared-fs-usage none. However, this is my first real traipse around the Snakemake source code, so let me know if I should change approach or if I missed something else.
The value is added to the executor interface in https://github.com/snakemake/snakemake-interface-executor-plugins/pull/67


Release workflow

I was able to test everything up to publishing to npm. It is trying to do automatic changelog tracking as well.
There are two steps involved:
prepare release
finalize release
You run prepare first and then finalize when ready. This is the best documentation I've found https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_repo.html#initial-release-workflow
But it is still a bit lacking. Will need to setup the trusted publisher once merged

@sujen1412 I'm going to be out for a bit but this is what I have so far


Please notify the license clearly

As you can see, there are 2 LICENSE files in this repository. Thus, I am confused about the license of the noto font family. I want to know whether the noto font family is OFL or not, therefore please notify the license clearly. For example, you can add an extra explanation to README.md file.

Google distributes this font on the Google Fonts website with the OFL (SIL) license. One assumes Google is understanding things and distributing this correctly. But yes, it would be good if the underlying Github repository clarifies the license details.


tour: import "math/cmplx" not needed

Context: https://tour.golang.org/basics/11
Hi, I am running the example locally and it doesn't seem to need "math/complx".
user@ubuntu:~/go/src/lab01$ cat lab01.go
package main

import (
  "fmt"
)

var (
  ok bool = false
  maxInt uint64 = 1<<64 - 1
  z complex128 = complex(.5, 14.13)
)

func main() {
  fmt.Printf("Type: %T Value: %v\n", ok, ok)
  fmt.Printf("Type: %T Value: %v\n", maxInt, maxInt)
  fmt.Printf("Type: %T Value: %v\n", z, z)
}
user@ubuntu:~/go/src/lab01$ go run lab01.go
Type: bool Value: false
Type: uint64 Value:<PHONE_NUMBER>3709551615
Type: complex128 Value: (0.5+14.13i)
user@ubuntu:~/go/src/lab01$

But does in the playground for some reason.

On line 11 of https://tour.golang.org/basics/11 the cmplx.Sqrt() function from the math/complx package is being used (https://golang.org/pkg/math/cmplx/#Sqrt) so this package is being imported.
In the code you've pasted above this line has been replaced with z complex128 = complex(.5, 14.13) which uses the builtin complex function; https://golang.org/pkg/builtin/#complex
As it is a builtin function nothing needs to be imported to use it.
Hope this helps explain the discrepancy? If it does, would you consider closing the issue? Thanks!

Thanks @robphoenix , not sure why that wasn't clear to me before.


Edit hdinsight-use-mapreduce.md

Edit complete. In addition to suggestions in the article, sent this to Larry:
Please check the links at the bottom of your page to see if you want to update the titles.

Hi @ClarityQueen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-diree). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


added my name to the list with my github username and link

My info has been added. If you guys could also do a PR on my repo, it's called midterm project! please and thank you!! 👍  😄

Hello @briangx92   This file has been deprecated in recent PRs, but you can add your name here https://github.com/HacktoberfestinAba/HacktoberfestinAba.github.io/blob/master/CONTRIBUTING.md
You can git pull the repo to sync the updates and send in a new PR/ Re-Open this PR

Hello @briangx92 This file has been deprecated in recent PRs, you however can add your name here https://github.com/HacktoberfestinAba/HacktoberfestinAba.github.io/blob/master/CONTRIBUTING.md
You can git pull the repo to sync the updates and send in a new PR/ Re-Open this PR


Explicit Codable & CodingKey Derived Conformance

What's in this pull request?
This PR integrates preliminary compiler work to support derived conformance for the newly introduced Codable and CodingKey types which are part of #8124.
This PR focuses on internal compiler features for improving the experience of using the features provided in #8124.
A swift-evolution proposal will be introduced momentarily and will link to this PR.
NOTE: This PR should not be merged until #8124 is.
This work is not complete. Remaining top-level features which will be iterated upon:

[ ] Need to not generate decode expressions for immutable vars with default initializers
[ ] Provide failure diagnostics
[ ] Add unit tests:

[ ] Imported types
[ ] Collections (when possible)
[ ] Generic types
[ ] Nested types

[ ] Synthesize CodingKeys type even w/o other derivation

@slavapestov Thanks for the review! As for the generic tests, absolutely — that's on the to-do list above.

I think you can merge this whenever you're ready -- we can sort out the remaining issues later. I hope you get some time to work on the various TODO comments too :)

@slavapestov It seems I don't have write access for this repo — do you mind running a CI test please?

@swift-ci Please smoke test

Wait, don't we have to merge the other PR first?

I don't want to merge this, though, until #8124 lands as well

Yeah, we definitely shouldn't merge. Does the smoke test run the unit tests? Those will fail because the Codable and CodingKey protocols won't actually be in Foundation...

Yes, the smoke tests run the tests, that's the whole point of presubmit testing :)

Duh, yeah. Then this will almost certainly fail ¯_(ツ)_/¯

Now I am talking about adding this to the top of the file:
//===--- test.cpp ---------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//

On Mar 17, 2017, at 11:36 AM, Itai Ferber<EMAIL_ADDRESS>wrote:
commented.
Reply to this email directly, view it o https://github.com/apple/swift/pull/8125#discussion_r106718681

Ah, got it — will do!

@itaiferber If you are unfamiliar with git-clang-format, it will take care of a ton of the issues I brought up, but it only does it on the git-diff of what you changed, so you don't have to worry about changing other pieces of code you didn't touch.

@gottesmm Thanks for all of these — I will address them and re-run through git-clang-format.

@itaiferber Btw, of the changes I mentioned, git-clang-format will handle the 'Type*' => 'Type *' transformations. So I would just let it handle those for you

@gottesmm Already fixed those manually. :) Any idea why it wouldn't catch those in DerivedCodableCodingKeys.cpp? I have similar violations in there (CastStmt* → CastStmt *) but running the tool (../clang/tools/clang-format/git-clang-format --binary (which clang-format) --diff -- lib/Sema/DerivedConformanceCodingKey.cpp) reports no changes to be made. What am I missing? Adding --style LLVM doesn't affect it

@gottesmm That last push should've address most if not all of your concerns, hopefully. Refactored a lot of code in DerivedConformanceCodingKeys.cpp that should shorten it up considerably. Unit tests pass as they did before, and clang-format has nothing to complain about but the indentation of function calls (most of which I find unreadable once it formats them)

On Mar 20, 2017, at 2:42 PM, Itai Ferber<EMAIL_ADDRESS>wrote:
@gottesmm https://github.com/gottesmm That last push should've address most if not all of your concerns, hopefully. Refactored a lot of code in DerivedConformanceCodingKeys.cpp that should shorten it up considerably. Unit tests pass as they did before, and clang-format has nothing to complain about but the indentation of function calls (most of which I find unreadable once it formats them)

I will look at this later today, I gotta finish debugging something first. Even so, I noticed while looking at this real quick that the change in lib/AST/Decl.h I don't think has been addressed.
Michael

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apple/swift/pull/8125#issuecomment-287907432, or mute the thread https://github.com/notifications/unsubscribe-auth/AAee37jSzFQ-GHuhZRDrzpWvir9cnX3Iks5rnvLcgaJpZM4Memyu.

BTW, I'm currently working on shuffling PRs (this and #8124) so that all the Swift stdlib/derived conformance stuff will be part of one PR and can land together, and the Foundation bits can land separately. This should NOT be merged.

The work put up here has been subsumed into #9004.


ENH: Require Python 3.5 or newer on all platforms

Related Discourse thread: https://discourse.itk.org/t/dropping-legacy-python-support-support-for-python-3-5-and-newer-with-itk-5-1/1998


Unknown state after changing opereting mode to "Cooling for several days"

Good morning,
the integration worked fine until i changed the operating mode from winter to summer. In particular, for the summer period, I have to set the operating mode to "Cooling for several days". Since that day, the sensors of entity "SENSOconfort" are in an unknown state. I attach the log below.
Thanks a lot.
log.txt

This seems to be a general issue. For me the integration stopped working entirely as soon as cooling mode kicked in.

@MP14588 @CommanderROR9 this should be fixed in the latest release (+ the latest beta release of the Home Assistant component)

It seems to be working a bit better now in terms of entities and modes, instead the method to change the hot water temperature has somehow changed. It broke my automation, but I think I found a way to make it work again by using the hot water entity instead of the device...🤷♂
Since myVaillant itself is terribly limited and unreliable it's rather difficult to say where the issue lies exactly...might my myVaillant or the Integration.


How to add new category?

What is the  scenario for adding a new category ?

From what I understood, we need a new dataset in .jsonl with text and labels.
Could you share datasets that this was trained on? Especially for not_news.
By reading the telegram contest I see that for russian content they mostly used lenta.ru archive.
But what about ukrainian?

Thanks, I have found train_clf.py already and tried to train it with a single category but then on send.sh classificator failed probably because of "not_news" missing..
I have taken a dataset for Ukrainian news website which tagged their news, grouped only related to corruption and gotten about 700 entries which I united with categories_train.jsonl.
And after training I've became getting much worse results: many from war/politics became triggering corruption now and resulting as "unknown".
I have found out that in the added dataset the median text size is 1000+ characters when in yours about 450.
So I have a few questions about the hints for a dataset for the new category:

Does smaller article size improves accuracy?
Do multiple labels for the new category (like ["corruption", "war"] or ["corruption", "politics"]) will increase accuracy?
What was your strategy (or was it random?) in news selection for your training dataset:

Labels sorted by Count:
politics: 1200 occurrences
war: 1062 occurrences
economy: 760 occurrences
incident: 699 occurrences
not_news: 451 occurrences
entertainment: 426 occurrences
tech: 418 occurrences
sports: 324 occurrences
science: 138 occurrences
other: 37 occurrences

What are the other hints you might suggest?


Version 3.0

This is a series of compact commits which propose to modernise the solution and improve portability by fully embracing the new .NET Core tools! I saw there was some talk of a v3 in the issues tracker, but nobody appears to be committed so I offer this for consideration. :)
All tests run and pass on all targets, after only small changes: The tests for unpacking to temp dirs are no longer needed, and one test was modified because of a change in Read() (which could be argued is the correct behaviour).
Changes in this PR:
Support for .NET Core, projects consolidation
The packages are now built with .NET Core tools in Visual Studio 2015 and targets net20, net45 and netstandard1.1. (afaik netstandard1.1 is compatible with .NET Core, net451 and newer, Win8+, Windows Phone, Xamarin/Mono/Android/iOS etc)
The repository was consolidated and restructured to take advantage of the new tools. All tests now use NUnit. This should make it easier for people who wish to contribute to the project.
New package ExcelDataReader.DataSet
The base library no longer depends on System.Data and removed the built-in support for DataSets. This package implements AsDataSet() as an extension method consuming the reader interface, so current code will continue working (also for net20). Existing users of the dataset interface need to reference the ExcelDataReader.DataSet package to keep using the AsDataSet() methods.
The DataSet package is NOT intended for .NET Core projects: It has a "polyfill" of DataSet which is meant to make the tests work rather than actual usage. Users on .NET Core should consume the reader interface which was updated to support everything in the dataset interface.
No more temp files
The OpenXml parser no longer uses temp files for unzipped data, but reads straight from the zip file. This has no impact on the library's memory footprint.
Behavioural changes in the reader interface
In version 2.X the FirstRowAsHeaders flag only affected the DataSet methods, but now it also affects the reader interface.
When FirstRowAsHeaders is enabled:
- IExcelDataReader.Read() skips the first row
- IExcelDataReader.GetName(i) returns the name at the index in the skipped row
Existing users of the reader API need to verify their column header handling code if FirstRowAsHeaders was used.
New Reset() method on the reader interface
IExcelDataReader adds a Reset() method to restart the reader from the first row on the first sheet. This was required by AsDataSet() to pass all tests.
Notes on usage under .NET Core
Strings in binary Excel documents are typically encoded with Windows codepages such as "windows-1250". These encodings require a dependency and additional code in .NET Core clients:
Your project.json should have dependencies like so for netcoreapp/netstandard based targets:
"dependencies" : {
    "ExcelDataReader" : "<IP_ADDRESS>",
    "System.Text.Encoding.CodePages": "4.0.1"
}

Then register the codepage provider in your application initialisation code:
System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);

Note that System.Text.Encoding.CodePages targets netstandard1.2 while ExcelDataReader targets netstandard1.1. In practise that means clients need at least netstandard1.2 to use ExcelDataReader because of the CodePages dependency! Clients can likely work around this limitation with a custom codepage encoding provider.
TODO
I deleted the exceldatareader.snk file. I guess it should be added back and referenced from project.json.
Issue #74: Fix inconsistencies with convertOADate and AsDataSet(). Solution: remove the parameter from AsDataSet() and dont change the flag there - it is already available as factory parameter and a property on the reader. This is a breaking change and some tests will likely need updating.
Rename namespace "Excel" to "ExcelDataReader": makes the name of the project, package, directory and namespace the same.
Whitespace normalisation.

Is it possible to have "duplicated" columns names using .NET Core?
I saw you no longer handle them reading "headers", this way you can move implementation of "duplicates" to the new extension methods. Am I wrong?
public bool NextResult()
...
m_cellsNames[i] = value.ToString();

@wizardgsz You understand correctly how it works: The handling of duplicate column names is now implemented on the "dataset side". This means that the reader's GetName() returns the underlying column name, which could be a duplicate. And if GetOrdinal() were implemented, it can only return the first matching index in case of duplicates.
I would rather keep it this way unless there are good arguments the other way. It keeps the parsers clean and low level, and it is the same behaviour seen in e.g SqlDataReader which implements the same interfaces IDataReader/IDataRecord.
On the other hand, the duplicate names handling could be moved to a lower level in the engine. That would cause GetName() to return the unique column names as well. And if GetOrdinal() were implemented, it can look up any column. It would complicate the parsers only slightly, and the base interface would need a new method GetOriginalName() to populate DataColumn.Caption.

@wizardgsz You understand correctly how it works: The handling of duplicate column names is now implemented on the "dataset side". This means that the reader's GetName() returns the underlying column name, which could be a duplicate. And if GetOrdinal() were implemented, it can only return the first matching index in case of duplicates.
I would rather keep it this way unless there are good arguments the other way. It keeps the parsers clean and low level, and it is the same behaviour seen in e.g SqlDataReader which implements the same interfaces IDataReader/IDataRecord.
On the other hand, the duplicate names handling could be moved to a lower level in the engine. That would cause GetName() to return the unique column names as well. And if GetOrdinal() were implemented, it can look up any column. It would complicate the parsers only slightly, and the base interface would need a new method GetOriginalName() to populate DataColumn.Caption.

I would like to restart my own development the data reader using the version 3.0 code and hope to contribute.  Does the message at the bottom "This branch has no conflicts with the base branch" mean that if I issue a pull request from the base that I will get the modifications above or do I need to request for a specific branch?
Sorry if this is a noob question as I am a github noob.
Thanks

@SteveHolle, I can't quite parse your question, but if you wish to work on the "3.0" code you should fork my retool branch at https://github.com/andersnm/ExcelDataReader and work on that. Then, you can either

submit PRs against my branch, and if I accept they'll be become part of this PR, or
wait and hope the developers of ExcelDataReader accept this PR, after which you can do some git magic (???) and submit PRs against the main development branch instead

Regarding pt 1 please note this PR focuses mainly on structural changes/cleanups in the solution to take advantage of the new tools and does not attempt to fix anything beyond that. The new binaries produce mostly the same output from the same set of Excel spreadsheets as before.
Beware I'm just a random guy making some suggestions and I don't know if this PR will be accepted. I assume it's still under review and the people with commit access are busy or on holiday still. Also it is quite a large PR and I'm the first to admit nobody likes when a stranger comes in from the outside and rewrites everything :)
I still plan to address the issues mentioned in the TODO above, but at the moment I await some kind of acknowledgement if it is worth to proceed. I am happy to answer any questions.

Any comments from the ExcelDataReader Authors on this?

Anyone opposed if I go ahead and merge this? I have the power to merge! :)

go for it
On Fri, Jun 2, 2017 at 8:08 PM, andersnm<EMAIL_ADDRESS>wrote:

Anyone opposed if I go ahead and merge this? I have the power to merge! :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/pull/139#issuecomment-305883710,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATdSTEq61o7m68HkqqJTEVlGm0YHBB5ks5sAF3BgaJpZM4JYzUD
.

--
Ian Cox
C.T.O.
System Sync
https://www.linkedin.com/company-beta/5113533?pathWildcard=5113533
https://www.payroll.pensions.market
m:            Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w:            http://www.systemsyncsolutions.com
http://www.releasemobile.com/
Registered in England as systemsync solutions ltd.
Number: 9326325 VAT: 202729923


PR-SCTP issue if start fragment of a data chunk goes missing

Hi,
I will try to describe the problem I have using an unordered channel either with
DATA_CHANNEL_RELIABLE_UNORDERED or with DATA_CHANNEL_PARTIAL_RELIABLE_REXMIT_UNORDERED.
My SCTP implementation sends:
DataChunk0Fragment0    TSN=0  Start/End
DataChunk1Fragment0    TSN=1  Start
DataChunk1Fragment1    TSN=2  End
DataChunk2Fragment0    TSN=3  Start/End
DataChunk3Fragment0    TSN=4  Start
DataChunk3Fragment1    TSN=5  End
DataChunk4Fragment0    TSN=6  Start/End
DataChunk5Fragment0    TSN=7  Start
DataChunk5Fragment1    TSN=8  End
usrsctp receives: (TSN=1 goes missing which is a start fragment)
DataChunk0Fragment0    TSN=0
DataChunk1Fragment1    TSN=2
DataChunk2Fragment0    TSN=3    (express delivery, highest_tsn_inside_nr_map=3, cumulative_tsn=0)
DataChunk3Fragment0    TSN=4    (Start Flag, fsn_included=4, top=4)
DataChunk3Fragment1    TSN=5
DataChunk4Fragment0    TSN=6    (express delivery, highest_tsn_inside_nr_map=6, cumulative_tsn=0)
DataChunk5Fragment0    TSN=7
DataChunk5Fragment1    TSN=8
I (sender) get following SACK Messages:
CumTsnAck CumTsn=0 Gap Start=2 End=2
CumTsnAck CumTsn=0 Gap Start=2 End=3
CumTsnAck CumTsn=0 Gap Start=2 End=4
CumTsnAck CumTsn=0 Gap Start=2 End=5
CumTsnAck CumTsn=0 Gap Start=2 End=6
CumTsnAck CumTsn=0 Gap Start=2 End=7
CumTsnAck CumTsn=0 Gap Start=2 End=8
My problem is that I have no idea what to send in the ForwardTSN message. I think I tried every possible combination but I never get the right DataChunks.
I would expect to get DataChunk2, DataChunk3, DataChunk4 and DataChunk5 but I get

DataChunk2 and DataChunk4 always since they are unfragmented.
DataChunk5 depending of Tsn in ForwardTSN Message
DataChunk3Fragment1 which is wrong since SCTP is configured reliable. SCTP must ensure the integrity of the data chunks.

Could you please give me some advice about the ForwardTSN Message? According to the RFC3758 cumTsn+StartGap-1 should be ok for the receiver.
Best Regards,
Sergio
EDIT: I finally found a working case and this is when I select DATA_CHANNEL_RELIABLE and I send Data Chunks with the Unordered Flag unset.
In this case the receiving queue will not be processed if a fragment gets lost and my ForwardTSN Message (cumTsn+StartGap-1) does what I expected.

You wouldn't send a FORWARD-TSN chunk in case of a DATA_CHANNEL_RELIABLE_UNORDERED data channel or a DATA_CHANNEL_PARTIAL_RELIABLE_REXMIT_UNORDERED with a Reliability Parameter > 0. In both cases you would retransmit TSN=1 after receiving the third loss indication:
CumTsnAck CumTsn=0 Gap Start=2 End=4

This is describes as Fast Retransmission in RFC 4960.
Only for DATA_CHANNEL_PARTIAL_RELIABLE_REXMIT_UNORDERED with a Reliability Parameter = 0 you would send a FORWARD-TSN chunk in the above example. In that case you would abandon TSN=1 and TSN=2. So the New Cumulative TSN would be 2 and the stream identifier listed would be the one of the DATA chunk with TSN=1 and TSN=2. See the description in RFC 3758.

Hi,
thank you very much for you reply.
the problem is that usrsctp library ignores my TSN=1 and TSN=2 because the library received TSN=4 before (start of a fragmented data chunk)
When the library gets my TSNs, the function sctp_flush_reassm_for_str_seq is called and following condition is checked:
if (!asoc->idata_supported && !ordered && SCTP_TSN_GT(control->fsn_included, cumtsn)) {
control->fsn_included is equal to 4 and cumtsn is equal to 2 and the Forward-TSNs are apparently ignored.
Another question is why you implemented express delivery for unfragmented data chunks but not for DataChunk3 or DataChunk5 is the example above since they were received completely. I think there is no reason to keep these data chunks in the queue.
Best regards,
Sergio.

Hi,
thank you very much for you reply.
the problem is that usrsctp library ignores my TSN=1 and TSN=2 because the library received TSN=4 before (start of a fragmented data chunk)
Wasn't TSN=1 dropped on the wire? Are you saying TSN=2 is dropped by the SACK even though it was acked in a GAP?
When the library gets my TSNs, the function sctp_flush_reassm_for_str_seq is called and following condition is checked:
if (!asoc->idata_supported && !ordered && SCTP_TSN_GT(control->fsn_included, cumtsn)) {
control->fsn_included is equal to 4 and cumtsn is equal to 2 and the Forward-TSNs are apparently ignored.
fsn_included means fragment sequence number. Why are you referring to FORWARD-TSN?
Another question is why you implemented express delivery for unfragmented data chunks but not for DataChunk3 or DataChunk5 is the example above since they were received completely. I think there is no reason to keep these data chunks in the queue.
The implementation might not be optimal...

Best regards
Michael

Best regards,
Sergio.

Hi Michael,
I think it is difficult to explain the problem in this way. I will reproduce the problem again and send you the call stack of the usrsctp library after receiving each fragment.
But this should be easily reproduced:

Send a sequence like the example above without waiting for SACKs (all fragments at once)
Drop DataChunk1Fragment0 (Start Fragment) on the wire
Use ForwardTSN to tell the receiver to ignore DataChunk1 and keep processing the received data

At the receiving side:

I expect DataChunk0, DataChunk2, DataChunk3, DataChunk4, DataChunk5

I actually get DataChunk0, DataChunk2 and DataChunk4 (fragment data chunks are not processed)

Hopefully the call stack adds some clarity to the problem.
Best regards,
Sergio.

Hi Michael,
I think it is difficult to explain the problem in this way. I will reproduce the problem again and send you the call stack of the usrsctp library after receiving each fragment.
But this should be easily reproduced:

Send a sequence like the example above without waiting for SACKs (all fragments at once)
Drop DataChunk1Fragment0 (Start Fragment) on the wire
Use ForwardTSN to tell the receiver to ignore DataChunk1 and keep processing the received data

At the receiving side:

I expect DataChunk0, DataChunk2, DataChunk3, DataChunk4, DataChunk5

I agree.

I actually get DataChunk0, DataChunk2 and DataChunk4 (fragment data chunks are not processed)

OK.
I can write a packetdrill script in the next days and test it on the FreeBSD kernel stack, which should behave identical to the usrsctp stack.
I'll post it here and will report whether it reproduces the issue you are seeing.
Best regards
Michael

Hopefully the call stack adds some clarity to the problem.
Best regards,
Sergio.

The following packetdrill shows how the stack currently behaves:
 0.0 `sysctl -w net.inet.sctp.ecn_enable=0`
+0.0 `sysctl -w net.inet.sctp.pr_enable=1`
+0.0 `sysctl -w net.inet.sctp.asconf_enable=0`
+0.0 `sysctl -w net.inet.sctp.auth_enable=0`
+0.0 `sysctl -w net.inet.sctp.reconfig_enable=1`
+0.0 `sysctl -w net.inet.sctp.nrsack_enable=0`
+0.0 `sysctl -w net.inet.sctp.pktdrop_enable=0`

+0.0 socket(..., SOCK_STREAM, IPPROTO_SCTP) = 3
+0.0 fcntl(3, F_GETFL) = 0x2 (flags O_RDWR)
+0.0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+0.1 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+0.0 > sctp: INIT[flgs=0, tag=1, a_rwnd=..., os=..., is=..., tsn=1, ...]
+0.1 < sctp: INIT_ACK[flgs=0, tag=2, a_rwnd=1500, os=1, is=1, tsn=0, STATE_COOKIE[len=5, val=...]]
+0.0 > sctp: COOKIE_ECHO[flgs=0, len=5, val=...]
+0.1 < sctp: COOKIE_ACK[flgs=0]
+0.0 getsockopt(3, SOL_SOCKET, SO_ERROR, [0], [4]) = 0
// First complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1468, tsn=0, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1452
// First fragment of second message is missing.
+0.0 < sctp: DATA[flgs=UE, len=1116, tsn=2, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:2], dups=[]]
// Third complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1416, tsn=3, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:3], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1400
// Fourth fragmented message is received. Could be delivered, but isn't.
+0.0 < sctp: DATA[flgs=UB, len=1416, tsn=4, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:4], dups=[]]
+0.0 < sctp: DATA[flgs=UE, len=1416, tsn=5, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:5], dups=[]]
+0.0 recv(3, ..., 3000, 0) = -1 EAGAIN (Resource temporarily unavailable)
// Fifth complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1316, tsn=6, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:6], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1300
// Sixth fragmented message is received.  This is a limitation of the current implementation. I can try to look at removing this limitation...

Hi,
you write "Missing first fragment of second message is received."
What if this message really gets lost?
Did you try to use ForwardTSN? The library should deliver queued messages after processing ForwardTSN message but it doesn't.
In my tests, using ForwardTSN, the fragmented messages get never delivered, probably because the missing messages never arrive.
Thanks again for testing this issue.

The point is if the first fragment is lost, it is retransmitted by the peer, if it is not abandoned.
However, if it is abandoned, you are right, there is a bug. The following scripts does NOT run:
 0.0 `sysctl -w net.inet.sctp.ecn_enable=0`
+0.0 `sysctl -w net.inet.sctp.pr_enable=1`
+0.0 `sysctl -w net.inet.sctp.asconf_enable=0`
+0.0 `sysctl -w net.inet.sctp.auth_enable=0`
+0.0 `sysctl -w net.inet.sctp.reconfig_enable=1`
+0.0 `sysctl -w net.inet.sctp.nrsack_enable=0`
+0.0 `sysctl -w net.inet.sctp.pktdrop_enable=0`

+0.0 socket(..., SOCK_STREAM, IPPROTO_SCTP) = 3
+0.0 fcntl(3, F_GETFL) = 0x2 (flags O_RDWR)
+0.0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+0.1 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+0.0 > sctp: INIT[flgs=0, tag=1, a_rwnd=..., os=..., is=..., tsn=1, ...]
+0.1 < sctp: INIT_ACK[flgs=0, tag=2, a_rwnd=1500, os=1, is=1, tsn=0, FORWARD_TSN_SUPPORTED[], STATE_COOKIE[len=5, val=...]]
+0.0 > sctp: COOKIE_ECHO[flgs=0, len=5, val=...]
+0.1 < sctp: COOKIE_ACK[flgs=0]
+0.0 getsockopt(3, SOL_SOCKET, SO_ERROR, [0], [4]) = 0
// First complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1468, tsn=0, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1452
// First fragment of second message is missing.
+0.0 < sctp: DATA[flgs=UE, len=1116, tsn=2, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:2], dups=[]]
// Third complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1416, tsn=3, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:3], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1400
// Fourth fragmented message is received. Could be delivered, but isn't.
+0.0 < sctp: DATA[flgs=UB, len=1416, tsn=4, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:4], dups=[]]
+0.0 < sctp: DATA[flgs=UE, len=1416, tsn=5, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:5], dups=[]]
+0.0 recv(3, ..., 3000, 0) = -1 EAGAIN (Resource temporarily unavailable)
// Fifth complete message is received.
+0.0 < sctp: DATA[flgs=UBE, len=1316, tsn=6, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:6], dups=[]]
+0.0 recv(3, ..., 2000, 0) = 1300
// Sixth fragmented message is received. Could be delivered, but isn't.
+0.0 < sctp: DATA[flgs=UB, len=1216, tsn=7, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:7], dups=[]]
+0.0 < sctp: DATA[flgs=UE, len=1216, tsn=8, sid=0, ssn=0, ppid=53]
+0.0 > sctp: SACK[flgs=0, cum_tsn=0, a_rwnd=..., gaps=[2:8], dups=[]]
+0.0 recv(3, ..., 3000, 0) = -1 EAGAIN (Resource temporarily unavailable)
// Second message was abandoned by peer.
+0.0 < sctp: FORWARD_TSN[cum_tsn=2, ids=[{0,0}]]
+0.0 > sctp: SACK[flgs=0, cum_tsn=8, a_rwnd=..., gaps=[], dups=[]]
// Fourth reassembled message gets delivered.
+0.0 recv(3, ..., 3000, 0) = 2800
// Sixth reassembled message gets delivered.
+0.0 recv(3, ..., 3000, 0) = 2400
// Tear down the association
+0.0 close(3) = 0
+0.0 > sctp: SHUTDOWN[flgs=0, cum_tsn=8]
+0.1 < sctp: SHUTDOWN_ACK[flgs=0]
+0.0 > sctp: SHUTDOWN_COMPLETE[flgs=0]

It hangs at the recv() call for the fourth message. Will look into it.

That is exactly the problem I am having, nice that you could also reproduce it.


Pilot fails after package is successfully uploaded to iTunes Connect.

Issue Description
Recent changes on iTC compliance break pilot step. It finishes with the following error:

You must provide an answer for this question.

Despite the pilot step being able to successfully upload and wait for Apple to process the build, it will fail with the above error without giving any more information.
Relevant output
[10:47:11]: -------------------
[10:47:11]: --- Step: pilot ---
[10:47:11]: -------------------
[10:47:11]: Login to iTunes Connect (<Apple ID>)
[10:47:19]: Login successful
[10:47:19]: Ready to upload new build to TestFlight (App: <app_id>)...
[10:47:19]: Going to upload updated app to iTunes Connect
[10:47:19]: This might take a few minutes, please don't interrupt the script
[10:47:22]: [Transporter]: INFO: Transporter is skipping bundle update check: Already checked recently.
[10:47:22]: [Transporter]: INFO: Logging configured successfully.
...
[10:47:51]: [Transporter]: DBG-X: Returning 0
[10:47:52]: ------------------------------------------------------------------------------------------------------
[10:47:52]: Successfully uploaded package to iTunes Connect. It might take a few minutes until it's visible online.
[10:47:52]: ------------------------------------------------------------------------------------------------------
[10:47:52]: Successfully uploaded the new binary to iTunes Connect
[10:47:52]: Waiting for iTunes Connect to process the new build
...
[11:03:11]: Waiting for iTunes Connect to process the new build
[11:03:41]: Waiting for iTunes Connect to finish processing the new build (2.2 - 91)
[11:03:41]: Successfully finished processing the build
[11:03:41]: You can now tweet:
[11:03:41]: iTunes Connect #iosprocessingtime 16 minutes
[11:03:41]: Distributing new build to testers

[11:08:02]: Variable Dump:
[11:08:02]: <Prints variables with right values.>

**[11:08:02]: You must provide an answer for this question.
**
+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | opt_out_usage                       | 0           |
| 2    | Verifying required fastlane version | 0           |
| 3    | default_platform                    | 0           |
| 4    | increment_version_number            | 0           |
| 5    | Switch to ios build_app lane        | 0           |
| 6    | sigh                                | 5           |
| 7    | gym                                 | 59          |
| 8    | pilot                               | 1245        |
| 9    | is_ci                               | 0           |
| 10   | say                                 | 5           |
| 11   | clean_build_artifacts               | 0           |
| 12   | slack                               | 0           |
+------+-------------------------------------+-------------+

[11:08:02]: fastlane finished with errors
/Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/tunes_client.rb:221:in `handle_itc_response': [!] You must provide an answer for this question. (Spaceship::TunesClient::ITunesConnectError)
	from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/tunes_client.rb:541:in `update_build_trains!'
	from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/build_train.rb:118:in `update_testing_status!'
	from /Library/Ruby/Gems/2.0.0/gems/pilot-1.4.1/lib/pilot/build_manager.rb:124:in `distribute_build'
	from /Library/Ruby/Gems/2.0.0/gems/pilot-1.4.1/lib/pilot/build_manager.rb:26:in `upload'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/actions/pilot.rb:18:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:129:in `block in execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:128:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:128:in `execute_action'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/fast_file.rb:149:in `method_missing'
	from Fastfile:122:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/lane.rb:36:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:52:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:46:in `chdir'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:46:in `execute'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/bin/fastlane:38:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.36.9/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/bin/fastlane:156:in `run'
	from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/bin/fastlane:162:in `<top (required)>'
	from /usr/local/bin/fastlane:23:in `load'
	from /usr/local/bin/fastlane:23:in `<main>'

Environment
fastlane version (fastlane -v): 1.63.1
Not using bundler, rbenv nor rvm.

Ok, we have solved the issue now, but I will still post here what was causing it and how we fixed it in case it is helpful for someone else.
After debugging Spaceship::TunesClient in order to be able to log the response received from iTunes, we have just realised that the error `` comes from the sectionErrorKeys array. Causing Fastlane to fail the step, although the statusCode is returned as SUCCESS.
 {"data"=>
  {"sectionErrorKeys"=>["You must provide an answer for this question."],
   "sectionInfoKeys"=>[],
   "sectionWarningKeys"=>[],
   ...
  }
 "messages"=>{"warn"=>nil, "error"=>nil, "info"=>nil},
 "statusCode"=>"SUCCESS"}

Then, digging a bit more on the response, we realised that the exportComplianceRequired was set to true and the exportComplianceState was missing. At this point, if we go to iTC front-end (TestFlight tab), we see all the latest builds marked as Missing compliance.
Therefore, we have managed to solve the above issue, by specifying the following key ITSAppUsesNonExemptEncryption as false in the project's Info.plist to avoid having this issue.
In Apple words...

If your encryption doesn't change, use the following key in your Info.plist so you don't have to provide export compliance information with your next build:
<key>ITSAppUsesNonExemptEncryption</key><false/>

:bulb: It might be worth making Fastlane aware of this behaviour, so it can propose the above solution when this situation happens.


Set single S3 lambda to run in VPC

For security S3 IP restriction policy is set on the TDR Export S3 bucket
To continue to allow the S3 custodian policies to run against the IP restricted buckets need to run the custodian lambdas in the relevant VPC: https://cloudcustodian.io/docs/tools/c7n-mailer.html?highlight=security_group#standard-lambda-function-config
Other S3 Custodian lambdas to be updated in other commits

Closing until decision made on how to proceed


Removed TCL dependency to build Redis

Description
Removed TCL dependency to build Redis
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[x] Configuration Update
[ ] Bump-up dependent library

/lgtm
/approve

/approve


Check the issue of fee extra fee being automatically added

please check and research how can we sort this issue out because it adds extra fee

just for the complement we can do it like the way we for usecs


Changed webpack local config to use source maps

Fix for #1999.
Updated local webpack config to use source maps, according to this doc:
http://webpack.github.io/docs/configuration.html#devtool
Re-builds might be slightly slower, but breakpoints should work properly now. Also fixed webpack config file linting errors, which caused in-editor linters to freak out.
@foot Could you take a look at this?

Nice one, lgtm.


[Investigation] Tools for template-based code generation

What
Determine the toolchain for the auto-generation of C, C++ and Python code from a common JSON declaration
Why
See #388
ACs

Avoid custom implementation where possible.
Any dependencies must be cross-platform & FOSS
Able to make fully working:

pip installable Python packages
C/C++ libraries compilable using cmake.

[usdGenSchema](https://github.com/PixarAnimationStudios/USD/blob/release/pxr/usd/usd/usdGenSchema.py) uses https://jinja.palletsprojects.com/en/3.1.x/

A thought - It'd be good if whatever we go with is easy to install so we can make the tooling a fairly seamless part of the distribution.

Given our relatively simple requirements per-file, plus fairly complex requirements in creating a directory/package structure, Python + Jinja2 seems like the best fit and satisfies the ACs. See 7c95c4cb4d03a8d4a1b86996672e7b418b353bbc for a prototype using this approach.
Hence we're going to pursue that route to codegen, so I'll close this issue.


Support ChainerX in word2vec example

Part of #6661
Merge #6768 first.

Could you rebase?

Rebased.

Jenkins, test this please.

Jenkins CI test (for commit 627bd452d2af6b5e660915221bd46ae4a041c744, target branch master) failed with status FAILURE.

Jenkins failure is unrelated to this PR. LGTM.


Only run tests for modules affected by a PR

Cont'd from https://github.com/GoogleCloudPlatform/google-cloud-node/pull/1576#issuecomment-245700733
We now have 3 OSes to run tests for 3 different versions of Node. Running the system tests takes a big portion of the time, the other is the installation of all of our dependencies. I have improved the performance somewhat by forcing Travis to use npm 3, which flattens the dependency tree before downloading.
I think there might be room to improve if we only run the system tests for the module that the modified files affected, e.g., a merge that only changed Storage files wouldn't run Bigtable tests.
@callmehiphop any ideas on tooling that might exist for this? I know we've indirectly used things like this for Grunt/Gulp pipelines.

Cool, I like this proposal.

Not sure if Grunt or Gulp would really help us here, usually they use some kind of local caching mechanism to figure out which files have changed and which to test against.
We could probably solve this with a shell script? Not sure if this is gross or not, but we can get a list of files that have changed pretty easily
git remote add googs git@github.com:GoogleCloudPlatform/google-cloud-node.git
git fetch
git diff --name-only HEAD googs/master

At which point we could probably match the changed file to an exact unit test file (I believe we're 1:1 on those?)
This would also allow us to conditionally run system tests on PRs, but I'm not sure how I feel about that - especially since this issue was opened directly in response to Travis jobs taking forever to run.

but I'm not sure how I feel about that

Why the uncertainty?

They have the tendency to run a lot slower than unit tests, not to mention for common package changes we would probably want to test against everything, so those kind of PRs would take even longer.

This would also allow us to conditionally run system tests on PRs,

Oh, it just clicked that I was talking about running system tests on PRs. We definitely don't want to do that, sorry. We should conditionally run sections of the unit tests on merges, not PRs. I'll edit my post.
For PRs, can you think of anything we can do to speed them up?

So, I've been playing with this and here is my naive attempt - I'm not the greatest at Bash 😢
# we'll use this remote to do our diff
git remote add googs https://github.com/GoogleCloudPlatform/google-cloud-node.git

# create a unique array of modules that have been updated
MODULES=$(git diff HEAD googs/master --name-only --exit-code | grep "packages" | cut -d \/ -f 2 | sort -u)

function get_test_files {
  for i in ${MODULES}; do
    echo "packages/$i/$1/*.js"
  done
}

if [ -n "$MODULES" ]; then
  # unit tests
  mocha --timeout 5000 --bail $(get_test_files "test")

  # system tests
  mocha --no-timeouts --bail $(get_test_files "system-test")
fi

I think the most glaring issue with this is that modules that have dependencies on other modules are obviously not being tested, but we could easily expand on this to add some rules..?
WDYT? I can make a PR if it looks ok to you guys.

PR it up 👍

I think the most glaring issue with this is that modules that have dependencies on other modules are obviously not being tested, but we could easily expand on this to add some rules..?

Just an idea, we could read the package's package.json to see if it depends on the affected module and add it to the mocha test pattern.

Just an idea, we could read the package's package.json to see if it depends on the affected module and add it to the mocha test pattern.

Sure could! What's the scope of this? PR only? Or merges as well ..?

Both, both!


[Feature Request] Add a texture for the controller rail on Create mod (please ; - ;)

Describe your idea in depth.
in depth my idea has no depth, it is only what i said in the title, you're welcome for the in depth description.

Added Create support in 1.7


Consider moving LocalCommandLineCodeExecutor to autogen_ext to follow pattern of other impls

Should we move all impls out of core and into ext?

I tend to agree. LocalCommandLineCodeExecutor shouldn't be cautiously used anyway.

Done.


Rendering failure?

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
2.0.1
Link to runnable example
No response
Steps to reproduce

init a new npm repo
install dependencies: micromark and micromark-extension-directive
create a JavaScript file say index.js, put the example code from README here:

import fs from 'node:fs'
import {micromark} from 'micromark'
import {directive, directiveHtml} from 'micromark-extension-directive'

const output = micromark(fs.readFileSync('example.md'), {
  extensions: [directive()],
  htmlExtensions: [directiveHtml({abbr})]
})

console.log(output)

function abbr(d) {
  if (d.type !== 'textDirective') return false

  this.tag('')
  this.raw(d.label || '')
  this.tag('')
}

inside example.md, input all the text from the SYNTAX section in README
run node index.js and get output in the console

Expected behavior
Directives in blocks and containers should get rendered, but the output is an empty string.
Actual behavior
Below is the actual output:

Directives in text can form with a single colon, such as .
Their syntax is :name[label]{attributes}.

Leafs (block without content) can form by using two colons:

Their syntax is ::name[label]{attributes} on its own line.

Containers (blocks with content) can form by using three colons:

The name part is required.  The first character must be a letter, other
characters can be alphanumerical, -, and _.
- or _ cannot end a name.

The [label] part is optional (:x and :x[] are equivalent)†.
When used, it can include text constructs such as emphasis and so on: x[a *b* c].

The {attributes} part is optional (:x and :x{} are equivalent)†.
When used, it is handled like HTML attributes, such as that {a}, {a=""},
, {a=''} but also {a=b}, {a="b"}, and {a='b'} are equivalent.
Shortcuts are available for id= ({#readme} for {id=readme}) and
class ({.big} for {class=big}).
When multiple ids are found, the last is used; when multiple classes are found,
they are combined: {.red class=green .blue} is equivalent to
{.red .green .blue} and {class="red green blue"}.

† there is one case where a name must be followed by an empty label or empty
attributes: a text directive that only has a name, cannot be followed by a
colon. So, :red: doesn’t work. Use either :red[] or :red{} instead.
The reason for this is to allow GitHub emoji (gemoji) and directives to coexist.

Containers can be nested by using more colons outside:

The closing fence must include the same or more colons as the opening.
If no closing is found, the container runs to the end of its parent container
(block quote, list item, document, or other container).

You can see containers and blocks are omitted, by my memory they should have got rendered.
Runtime
Node v14
Package manager
npm v7
OS
Linux
Build and bundle tools
No response

Hey!
I think the idea here is that unknown directives are ignored by default. As they could be turned into anything: dangerous html, youtube videos, embed of other stuff, math, you name it.
Just rendering something is probably not the best outcome.
So, the example JS code works with the example MD code, but not with the syntax explanation. That requires more code.
Does that make sense?

Oh, I am clear about it now. So it requires similar code like:
function abbr(d) {
  if (d.type !== 'textDirective') return false

  this.tag('')
  this.raw(d.label || '')
  this.tag('')
}

to render the containers and blocks right?

Yes, you need to write your own handlers to deal with containers in the way you want!

closing as it’s more a question that doesn’t need any code changes!


atr sometimes wrong

Version: 0.3.02b
Describe the bug
Sometimes I get atr(14) even if I call atr(3)

I guess the error is here in atr.py:

probably it has to be:
atr = ATR(high, low, close, length)
Thanks!

Hello @bonusguy,
Doh! 🤦🏼 Nice catch!  Would greatly appreciate it. 😎 If not, no worries.
Kind Regards,
KJ

I'm using the latest version (0.3.2b0) my ATR is wrong and length is ignored.  It looks like its always 14 days. I assume this is the same issue? Only 10hrs old any thoughts on the fix for this? I assume there would be a new build, I would need to install/build?  Thank you

Hello @schwaa,

I assume this is the same issue?

If you have TA Lib installed as well, then it is the same Issue.

Only 10hrs old any thoughts on the fix for this?

It's on the near term to do list. However, there is nothing to prevent you from editing your local copy to temporarily patch the Issue until the fix is in. Furthermore, I am open to contributions for Issues or additional Features to help speed the process along.
Kind Regards,
KJ

I'm pretty sure I can make the change, but not sure how to commit the code. ie like I know how to commit -a and git push, but not in a project like this.

@schwaa,
You have to be authorized to do pushes. However you can try a pull request. If you can not figure it out, not worries, at least you have a fixed local version for the time being. I typically inform people when Issues have been corrected and the main branch has been updated.
Thanks,
KJ

@bonusguy,
It is now available on the development branch if you want to check it out before I update the main branch.
$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Thanks for your patience,
KJ

Hi Kevin,
thanks for notifying me and sorry that I didnt make the change. It was my
first issue and never did a pull request so far. For the next bug I promise
to provide the fix.
Thanks for sharing your nice library,
Urban
Am Sa., 10. Juli 2021 um 19:39 Uhr schrieb Kevin Johnson <
@.***>:

@bonusguy https://github.com/bonusguy,
It is now available on the development branch if you want to check it
out before I update the main branch.
$ pip install -U @.***
Thanks for your patience,
KJ
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twopirllc/pandas-ta/issues/330#issuecomment-877674863,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFKUKRNVQFH4DFRPOSYUL4DTXCAU3ANCNFSM476NTNXQ
.

@bonusguy,
No worries. Thanks for using the library and helping to improve it.
Kind Regards,
KJ

Hello @bonusguy ,
New stable version v0.3.14b should help resolve this Issue. Please let me know otherwise.
$ pip install pandas_ta

Thanks,
KJ

Hello @bonusguy,
I assume by no response that the solution provided was sufficient. Thus I will be closing this issue in a few days.
Kind Regards,
KJ


Using google maps provider, widget dataview first petition could request an invalid bbox

Basically, fixing the bug related to https://github.com/CartoDB/cartodb/issues/11894, I have checked that sometimes widgets are not working properly due to they request the data using the not correct bbox, check image below:

Seems like Google Map is not ready and it returns [[0, 0], [0, 0]] for the current bounding box, and return data for that is empty, that's why the widget appears without anything :(:
…
  _getBoundingBoxFilterParam: function () {
    var result = '';
    var boundingBoxFilter;

    if (this.get('sync_on_bbox_change')) {
      boundingBoxFilter = new WindshaftFiltersBoundingBoxFilter(this._map.getViewBounds());
      result = 'bbox=' + boundingBoxFilter.toString();
    }

    return result;
  },
…

It is likely we will need to "wait" until map provider is ready before requesting data from dataview models.
This bug is related to https://github.com/CartoDB/cartodb/issues/11894.
cc @rochoa @jorgesancha

It is a bit random, because sometimes it works. Depends on if GMaps initialization is fast or slow.

This is hopefully fixed by https://github.com/CartoDB/cartodb.js/pull/1653. Let's reopen it if we see this problem again.

🤞