AppConfig.name is used instead of AppConfig.label for importing packages

As it is stated in Django documentation AppConfig.name is responsible for storing the full Python path to django app: https://docs.djangoproject.com/en/3.2/ref/applications/#django.apps.AppConfig.name
I have this project structure:
core/__init__.py
       settings.py
       ...
apps/__init__.py
        myapp/__init__.py
                   infrastructure/__init__.py
                                        apps.py

So when running the old implementation Django would try to import "myapp.infrastructure.apps.MyappConfig" instead of "apps.myapp.infrastructure.apps.MyappConfig"

Are you adding the default_app_config param into myapp/__init__.py? it should be something like:
default_app_config = "myapp.infrastructure.apps.MyAppConfig"

Given that you have your app listed on your settings.INSTALLED_APPS


Cannot run REPL using flabbergast-compiler module resolved from Maven Central

Resolved flabbergast-compiler:0.8 from Maven Central (with a fixed dependency declaration for flabbergast-runtime)
Executed java -cp "flabbergast-compiler-0.8.jar:asm-5.0.3.jar:jline-2.12.1.jar:flabbergast-runtime-0.8.jar:commons-cli-1.2.jar" flabbergast.MainREPL
Exception in thread "main" java.lang.NoClassDefFoundError: jline/Completor
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2625)
	at java.lang.Class.getMethod0(Class.java:2866)
	at java.lang.Class.getMethod(Class.java:1676)
	at sun.launcher.LauncherHelper.getMainMethod(LauncherHelper.java:494)
	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:486)
Caused by: java.lang.ClassNotFoundException: jline.Completor
	at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)

Indeed, jline-2.12.1 does not have a jline.Completor class. Is a different JLine version required than that listed in the flabbergast-compiler POM?
PS: The flabbergast-compiler Jar has a hardcoded Class-Path (/usr/local/share/java/flabbergast-runtime-0.8.jar /usr/sha  re/java/asm4.jar /usr/share/java/commons-cli.jar) in its MANIFEST.MF (which even lists a different ASM version), which is probably not desirable.
PPS: A smoke test for the Maven modules seems to be missing.

The build happens against Debian's Java packages, rather than what is on Maven Central. I have no idea how to use Maven, so it's all build through make. I think the problem is that Debian is using JLine 1.x and Maven Central only has JLine 2.x.
This is why there are no smoke tests. There's no Maven build. If you'd like to create a proper Maven build, I'd be very appreciative. Otherwise, I'm not sure how to proceed.

Unfortunately I can't contribute to OSS at the moment (even though I have a strong OSS background). The best I can do is file accurate bug reports.
Which JLine version is required? Maven Central has all versions since 0.9 (http://search.maven.org/#search|gav|1|g%3A"jline" AND a%3A"jline"). Apparently there was no 1.x, but they went from 1.0 straight to 2.6 (I've double-checked this on their SourceForge page).

Hmm. 1.2 is the version Debian has. There are JLine 2.11 libraries for Debian. I'll try porting to those.

Switching to JLine 1.0 worked for me.

Okay. I'll still try to port to a new version.


Upload the Diagrams for the classes

the class diagrams and use case diagrams must be added to the project.

This task has been completed.


Parallelize the shutdown of VMs

Currently, the shutdown process of VMs can take a very long time for
large environment since the task wait for the VM to go down before
shutting down the next. Here the shutdown is Parallelized and wait
for default timeout of 300 seconds before forcefully powering off
the VMs.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@tiraboschi @machacekondra can you please review?

@tiraboschi, thank you for reviewing. Modified as per the recommendation.

I do not know this code at all.
I'd suggest an improvement, though - can be in a later patch.
Sometimes you want to stop a set of VMs before another set of VMs. Say you have appvm1 and appvm2, and dbvm1, where both apps use the same db. You want to first shutdown the apps, then the db. We can allow the user to control this by getting a list of search patterns, and then loop over the list, in each round shutdown all the VMs that match the pattern.

@tiraboschi added to master on Mar 6 where he updated to register ovirt_vm_info result due to ansible 2.9, where result has to be explicitly registered. @nijinashok are you going to update this branch and also merge this branch to master?
I was also wondering if similar project exist which can only start the VMs which were 'up' prior to shutdown.
I am planning to connect libreNMS via SNMP to monitor power failure and trigger the parallel shutdown and when power is up, bring up ovirt with only VMs that were in 'up' state before. If you know of any existing working work that already perform all these steps or separately, please share.

This repo is deprecated and moved to ovirt-ansible-collection.
In case this PR is still required, please adjust it to fit ovirt-ansible-collection repo or open an RFE.


Use the  tag in activities

This is how time-related stuff is supposed to be displayed on a web page.
Moreover, I've also added a title for each element so the user can read the
absolute time in which the activity was created.
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

A snapshot:

Classy! :)
I'm merging because the test failure is not related with this PR. Please take a good care of master


latest unstable release

is there a latest unstable release available?
this is very old? Jan 2018.
https://github.com/boo-lang/boo/releases/tag/unstable
can some one build the linux binaries for boo and add it as a release?
Thanks,
Anish

I think that would require Mono to build it specifically on Linux, but recent versions of Mono fail to build the code.
However, I think you should be able to run the latest unstable with Mono, however I haven't tried.


Other port

It would be nice to be able to change the port RK uses. This would at least prevent some very simple attacks.

Not too fond of that. It would mean a lot of hassle to implement and in the end it probably doesn't get used.


Session Host Operator Content in Documentation

In https://docs.microsoft.com/en-us/azure/virtual-desktop/rbac#:~:text=Windows Virtual Desktop uses Azure,roles to users and admins.&text=The standard built-in roles,%2C app groups%2C and workspaces page, the Session Host Operator description is incorrect as the content is about Session Host Contributor role. By using Session Host Operator role we cannot create, update and remove session hosts and we can change drain mode that too single session host only and we cannot change drain mode to multiple session hosts.
Please review the description and attached file and please update us if any changes made.

Thanks in Advance.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4dfda11-b9d8-d493-ffe0-5e1d8859e7b9
Version Independent ID: d468d73d-d708-0e4d-4f4e-e776abb0e321
Content: Built-in roles Windows Virtual Desktop - Azure
Content Source: articles/virtual-desktop/rbac.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@phanikumarsharma
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

This has been corrected to say operator instead of contributor. Microsoft.DesktopVirtualization/hostpools/sessionhosts/* is correct and you can find that in the Azure portal in the JSON for the built-in role. It allows read, write and delete actions.  The text is correct in that an operator still cannot add session hosts as they don't have write permissions on hostpools (i.e. the next level up), but if they have the Virtual Machine Contributor role too, they can add session hosts outside of the Azure portal (not using the Azure portal).
#please-close


undefined control sequence in latex

@jstac could you please help to fix this?
orth_proj.rst
! Undefined control sequence.
l.472 \hat y := \argmin
_{z \in S} |y - z|
?
! Undefined control sequence.
l.775 ...span}} X := \mathop{\mathrm{span}} {\col
_1 X, \ldots, \col_k X }
?
! Undefined control sequence.
l.992 \argmin
{b \in \mathbb R^K} \sum{n=1}^N (y_n - b' x_n)^2
?
! Undefined control sequence.
l.1124   (x_j := \col
_j (X))\
?
rational_expectations.rst
! Undefined control sequence.
l.655 h(y, Y) := \argmax
_{y'}
?

@AnjuJoon are these latex warnings or errors? Are those lines contained inside of a math environment of some kind?

adding these commands in preamble solves the issue-
\newcommand{\argmax}{\operatornamewithlimits{argmax}}
\newcommand{\argmin}{\operatornamewithlimits{argmin}}
\DeclareMathOperator{\col}{col}


native event bubbling on custom component

Version
3.0.0-beta.3
Reproduction link
https://codepen.io/xty1992a/pen/abvmXXN
Steps to reproduce
focus then input
and here the code
 const { createApp, defineComponent, ref } = Vue

  // did`t emit event
  const Counter = defineComponent({
    props: {value: Number},
    template: `<input type="text" :value="value">`,
  })

  // setCount invoked
  const App = defineComponent({
    components: {Counter},
    setup() {
      const count = ref(0)
      const setCount = value => {
        count.value = value
      }
      return {
        count,
        setCount
      }
    },
    template: `
      <div>
        <Counter :value="count" @input="setCount"/>
      </div>
    `
  })

  createApp(App).mount('#app')

What is expected?
custom component scould not catch native events
What is actually happening?
it did that

is it a bug ?
I did`t see any feature about this.

https://github.com/vuejs/rfcs/blob/master/active-rfcs/0031-attr-fallthrough.md


TypeError in /clan/rainbow-bright-llpppr8v

Error in ClashLeaders
TypeError in /clan/rainbow-bright-llpppr8v
Cannot read property 'field' of undefined
View on Bugsnag
Stacktrace
https://www.clashleaders.com/static/js/details-page.c6a195c9a433e19704ec.js:1 -

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
TypeError in /clan/rainbow-bright-llpppr8v


embark simulator -p 8545 ignores port argument

Bug Report
Summary
embark simulator -p 8545 ignores port argument
Current behavior
the command  embark simulator -p 8545 runs ganache with the follow arguments:
$ embark simulator -p 8545
> running: ganache-cli -p 8555 -h localhost -l 8000000 -a 10 -e 100
> Ganache CLI v6.2.3 (ganache-core: 2.3.1)

How to reproduce
embark simulator -p 8545
Expected behavior
port would be 8545 instead of 8555
Please provide additional information about your system
OS: macOS  10.14.4
Embark Version: 4.0.2
Sometimes issues are related to Embark's installation. Can you provide information on how Embark was installed?
npm -g install embark

Hi @NoahMarconi . Thanks for reporting this issue.
Just to give some light on the issue, this is because Embark uses a proxy between the blockchain node and itself (in this case between the simulator and itself). The proxy is set to the port specified either in the blockchain config (defaults to config/blockchain.js) or by what is specified in the option. After that, Embark starts the actual node to that port number + 10. So in your case 8545 + 10 = 8555.
All in all, this is not really a problem, because as said above, the port 8545 is still opened by the proxy, which makes sure the node gets all the requests and responses. The proxy also adds some features like logging transaction results.
So in the end, you have 2 options:

Keep on working as is and ignore the fact that ganache is started with a port + 10. Everything will still work and you will have the features of the proxy.
Go in the blockchain config and turn off the proxy by putting proxy: false. This will make sure that Ganache is started at the port you specified.

I hope my explanations are clear enough. Don't hesitate to ask more questions if it isn't.

There might be a second problem in there.
When creating with embark new [folder name] --template typescript --contracts-only there's no proxy as far as I can tell.
The only way I can get it to run is to edit the contracts.json file to point to port 8555
This is after running:
$ embark simulator

Then in second console
$ embark run

Ok, I just tested and you are right, there are two issues.
First, --template typescript and  --contracts-only are mutually exclusive. Meaning that only one of those will apply (in our case, only the contracts only template got installed). This means you don't have the typescript template.
For this issue, we should show an error message when those two are used at the same time.
Basically, --contract-only tells embark that you will only have contracts, thus no JS files, so it doesn't even have a pipeline, so you won't have the typescript part.
The second issue is inside the --contracts-only. It doesn't have a blockchain config file, so it falls back to default configs, but something is wrong in Embark because it starts the simulator using the proxied port, but when embark starts, it isn't able to connect to that port. So this is an issue we should fix.
As for solutions for you, I'd suggest creating your project with embark new [folder name] --template typescript for now. If you don't need storage, communication or naming, you can go in the respective config file and put enabled: false.
If you really only want contracts only (and the typescript part was a mistake), I'd suggest copying this file (https://github.com/embark-framework/embark/blob/master/dapps/templates/boilerplate/config/blockchain.js) to your project and changing in embark.json the folliwing line  https://github.com/embark-framework/embark/blob/master/dapps/templates/simple/embark.json#L7 to "blockchain": "blockchain.js",. It should make the connection work. You can even turn the proxy off if it doesn't.
Sorry for the inconvenience. I'll make sure to add those to our issue list and fix as soon as possible.

awesome, thanks for helping so quickly!

No problem.
If the techniques I mentioned above, please tell me and we'll figure it out

@NoahMarconi did you give this a spin again? Can this issue be closed?

I haven't had a new project to test with but was able to get mine working. Good to close, can open a new one and reference this if I run into the problem again


async added

Description
I had raised issue regarding Old avatar being set and not able to get new one here : https://github.com/psk907/fluttermoji/issues/21
Fixes # (issue)
https://github.com/psk907/fluttermoji/issues/21
Type of change
adding async in flutterMojiSaveWidget.dart
adding Future return in flutterMojiController.dart

this pull is not available in pub.dev ???


how to get children/ancestors till particular level or at particular level?

I am using gedmo tree - closure strategy for hierarchical data. I have requirement where I want to fetch children/ancestors till particular level/depth. and at particular level. e.g.
I have region hierarchy global regions -> region -> country -> city .
From city I want to get

its ancestors till regions. So it should return country <- region.
I want to get only region in which city comes under. (at particular level)

same for children,

If I have global region, I want to get all children till country. (no cities) - till particular depth

If I have global region, I want to get all countries only which comes under global region.

In ClosureTreeRepository->childrenQueryBuilder I can see
   if ($direct) {
      $where .= 'c.depth = 1';
   } else {
      $where .= 'c.descendant <> :node';
   }

Depth is hard-coded to 1 for direct. So i can't pass depth from outside. To be able to pass from outside might help.
There is no way to get "till depth". Can anybody please help on achieving this.

you can customize a query builder in your repository, if we put that as an option it may have too many options. it is not hard to copy this code and make it custom for specific query you need

Thanks. Customized it in my repo. Worked.


go/parser: missing object for composite lit types identifiers beginning statements

In the following snippet, the obj identifiers in statements beginning with the composite literal obj{} are not resolved to the obj declaration.
type obj struct {}

func _() {
  obj{}
  obj{}.run()
}

The reason for this is that, while in the middle of parsing, LHS logic is pretty tricky to get right. Specifically, it's non-trivial to differentiate this case of a composite literal from, for example, the ok { in if _, ok := m[k]; ok {....
See also #45104: this is easy to fix when post-processing the AST, but it's nearly impossible to match the broken behavior (because it relates to source layout rather than syntax).
Filing as a separate issue as I'm going to fix it prior to #45104, so that I can match behavior exactly with the new resolution logic.
CC @griesemer

It might be easier to reproduce this bug in the new code than trying to fix the old code. Than you can still do exact behavior matching, and afterwards "fix the bug".

It might be easier to reproduce this bug in the new code than trying to fix the old code.

I have a fix for the old code. Reproducing in the new code would actually be quite tricky, because once parsed into a tree it's difficult to know if the CompositeLit you're looking at is at the start of an ExprStmt (this is what I meant above by "it relates to source layout rather than syntax").


Feature/z-alert: created z-alert component and use it in z-card-alert

I may approve the introduction of the z-alert but I am totally extraneous to the changes to the z-card-alert 😞
I think that this case would need a revision with the design team, but I understand the need to merge this PR in order to better tackle technological debt in the future. I'm conflicted.


feat: exchange asset

Description
Implementing the handling of ExchanceAsset xcm instruction
Adding custom XcmExecuteFilter to allow Transfer-And-Swap functionality and filter out non-desired xcm messages.
NOTE: The filter and exchange asset won't be configured for now in hydra runtime. First we want to enable this in basilisk to test it out.
Leftover TODOs:

[x] integration test for transfer and swap including 4 hops
[x] clippy and version updates

Main issue i have here that i am not a fan of this feature being part of omnipool pallet.
it feels like it should be somwhere else.

lgtm.
although , one question : how this is integrated into runtime ? i see no changes in the runtime xcm config but there are already integration tests.

It's not yet. Going to basilisk first (see https://github.com/galacticcouncil/Basilisk-node/pull/639). Integration will look very similar.

This is the implementation, but we want to test on Basilisk first, so it doesn't actually add it to the runtime, yet. I Imagine it will be a two step process with another PR. Same pattern as XCM rate limiter.

seems like we don't need to redefine the parameter, no?

this was about the particular review comments I left about implementation details, don't worry about it.


net.filebot.util.prefs.sync=true

Current Behavior
net.filebot.util.prefs.sync=true should be set on systems where the FileBot Desktop application is not typically closed via the X button, and likely to be killed suddenly via SIGKILL instead.
See https://www.reddit.com/r/unRAID/comments/1fu8q8i/filebot_saved_presets_not_saving/ for details. The user suggests that FileBot does not persist user settings if the container is stopped, which would be expected behaviour if FileBot is killed suddenly as user settings are only stored to file on close by default. The net.filebot.util.prefs.sync=true system property will instruct FileBot to sync settings to file immediately.
e.g.
-Djava.util.prefs.PreferencesFactory=net.filebot.util.prefs.FilePreferencesFactory \
-Dnet.filebot.util.prefs.file="$APP_DATA/prefs.properties" \
-Dnet.filebot.util.prefs.sync=true \

An orderly shutdown via SIGTERM or simulated "close window" events would be preferable of course but that might not be feasible.
Expected Behavior
No response
Steps To Reproduce
No response
Environment

OS:
OS version:
CPU:
Docker version:
Device model:
Browser/OS:

Container creation
x
Container log
x

Container inspect
No response
Anything else?
No response

Does this mean that FileBot doesn't handle the SIGTERM ?

I would assume that SIGTERM works, but you'll want to run a test to confirm. I didn't write the Java runtime, so I can neither confirm nor deny.
I'd be more interested in how docker handles container shutdown. Does it send SIGTERM to all processes running inside the container, and then wait a few seconds? Does this work as expected (i.e. close all windows) if the "main process" is a Desktop environment?
I don't even know how the user shuts down the container, presumably via some kind of Stop button of some kind of web interface. That said, the behaviour described in the original report does suggest that FileBot is killed suddenly, and not gracefully with SIGTERM.

When a container is stopped or restarted, the SIGTERM signal is sent to PID 1 inside the container. With this container, PID is the process manager, who then takes care of terminating all other processes that are running.
I did many tests and FileBot handles the SIGTERM correctly. I tried to change multiple settings inside FileBot. I'm then stopping or restarting the container (e.g. via docker stop <container name> or docker restart <container name>) and every time all settings are persisted.
I also tried with unRAID and I didn't see any issue. I'm not able to reproduce what the user is experimenting.

I guess that adding the net.filebot.util.prefs.sync=true system property would improve robustness in certain situations, but I'm not sure this will fix the user's issue.

When a container is stopped or restarted, the SIGTERM signal is sent to PID 1 inside the container. With this container, PID is the process manager, who then takes care of terminating all other processes that are running.
I did many tests and FileBot handles the SIGTERM correctly. I tried to change multiple settings inside FileBot. I'm then stopping or restarting the container (e.g. via docker stop <container name> or docker restart <container name>) and every time all settings are persisted.
I also tried with unRAID and I didn't see any issue. I'm not able to reproduce what the user is experimenting.

Thanks for looking into that. Sounds like everything is working as it should. Thanks for running tests to confirm. That means the user is likely just killing the process / doing a hard power of / etc. net.filebot.util.prefs.sync=true will definitely increase robustness for this corner case.

Closing this issue: the net.filebot.util.prefs.sync=true system property has been added.


Write a R program to add two matrices

Description
Write a R program to add two matrices
Matrix addition is the process of adding two matrices by adding the corresponding elements of the two matrices. Two matrices must have an equal number of rows and columns to be added.
Input  :
1 2 3
4 5 6
7 8 9

1 2 3
4 5 6
7 8 9

Output :
2 4 6
8 10 12
14 16 18

How to contribute

Save the solution in program/add_two_matrices.r file
Add add_two_matrices.r file in add-two-matrices folder

!assign


shared library incomplete

Hi,
when installing the shared library my bazel-genfiles are just symbolic links to ./cache. I was able to fix it by hand, but maybe its a good idea to adjust the skript.
cheers.

Hi, thank you for the report. I believed I have fixed it in the most recent master branch (~14 days ago). Have you pulled the most recent commit?

Must have been an older version. Started from start and all is well. Thanks for your work, I really appreciate it.


IstioEndpoint Record ResourceVersion

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)
Describe the feature request
Istio Config CRs have resourceVersion, but istioEndpoint doesn't have resourceVersion.
So we don’t know which version of K8s Endpoints, IstioEndpoint corresponds to
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

IstioEndpoint do not always come from Endpoints, or even from a Kubernetes object, or even from a single Kubernetes object (sometimes its multiple). So I don't see how we can do this.

Yes,
But can these scenarios be left to the developer to define the semantics themselves?

What do you need it for?

I used it for watch K8s Endpoints current ResourceVersion, it can make me know "Which K8s Endpoints ResourceVersion has been ACK by envoy“
In this observational scenario of xDS, k8s Generation is a better choice. Unfortunately, k8s endpoints do not have such a thing.
so i am implementing a feature for our istio,
K8s Endpoints(with newer ResourceVerison)->Istio EndpointController->endpointsByServiceAndSlice.
EndpointMetadata get information by MetadataClone()/Metadata() from IstioEndpoint, it also will including ResourceVerision,
then we can insert ResourceVersion in EnvoyMedata by AppendLbEndpointMetadata().
if EnvoyMetadata.ResourceVersion == K8s Endpoints ResoureceVersion (other sources),
then we can acually know dynamic_endpoint_config of dataplane has been synced with K8s Endpoints.
Tks for your reply!

Another backgroup,
i also want to use config_distribution to track PUSH/ACK or xDS, but its postion of record seems not correct, in  https://github.com/istio/istio/issues/48679 .
Before this,i also found EDS lost nonce in config_distribution. record https://github.com/istio/istio/issues/4898

I don't think it makes sense to plumb complex data through OSS Istio codebase in order to support a closed source vendor fork (IIUC). If you want to maintain a fork, that is fine, but IMO you should be responsible to do the work to add features in your fork, not push the maintenance burden onto OSS with no benefit to OSS.

Thanks for your reply. I hope that in the future I can contribute useful abilities to the entire community.:-p


[AzureMonitorExporter] Refactor Environment Variables

Move environment variables to a constants class and document their use.

API change check
API changes are not detected in this pull request.


entities of class PERSON_TYPE but referring to other entities (e.g. newspaper, problems,  etc.)

There are some concept like Zionist, Jewish that are referred to people,
Zionism
From wikipedia: Zionism is the national movement of the Jewish people that supports the re-establishment of a Jewish homeland in the territory defined as the historic Land of Israel [...]

Zionist if we refer to a person, should be PERSON_TYPE.
In this case Zionist is referred to newspapers, would be corrected to annotate it as CONCEPTUAL?

See example:
Articles	O
from	O
European	B-NATIONAL
Zionist	B-CONCEPTUAL
newspapers	O
,	O
1901	B-PERIOD
-	PERIOD
1931	PERIOD

Another example (Zionist events):
Issue	O
of	O
Haolam	B-MEDIA
newspaper	O
with	O
excerpts	O
on	O
Zionist	B-CONCEPTUAL
events	O
in	O
Europe	B-LOCATION
at	O
the	O
time	O
.	O

Jews/Jewish
Another example is referring to the Jews. In this chunk is referred to problems, it has been tagged as NATIONAL but it's incorrect, because the subject is not the nation or the place.
What would be a more correct tag?
 The fact that we have newspapers, dishes, event or sport from/for this group of people does not make the group of people a different entity, it's just a modifier.
However Zionism would be CONCEPTUAL.
We could think of linguistic tests like substitutions to make the choice more systematic, for instance can we change Zionist with other group of people.

What wouls be a valid sustitution for zionist? Is it more like communist? I was thinking in fact more something like liberal or laburist.

For me any of this, but it could be blond people, diabetics, etc. A newspaper for blond persons or muffin lovers does not make it conceptual?

OK, I have one last example I forgot to add:
When you have Zionist movement, can be considered like an ORGANISATION, as it's defined as Zionist movement - a movement of world Jewry that arose late in the 19th century with the aim of creating a Jewish state in Palestine
Here how we annotated:
He	O
was	O
one	O
of	O
the	O
outstanding	O
activists	O
in	O
the	O
Zionist	B-ORGANISATION
movement	ORGANISATION
in	O
Bulgaria	B-LOCATION

or should be more like:
the	O
Zionist	B-PERSON_TYPE
movement	O

Sorry, this is really the last example :-)
How Central committee of the zionist union  should be annotated?
Here how we did it:
he	O
served	O
as	O
a	O
member	B-TITLE
of	O
the	O
Central	B-ORGANISATION
Committee	ORGANISATION
of	O
the	O
Zionist	B-ORGANISATION
Union	ORGANISATION
in	O
Bulgaria	B-LOCATION

but we had the doubt of going for the whole match:
Central	B-ORGANISATION
Committee	ORGANISATION
of	ORGANISATION
the	ORGANISATION
Zionist	ORGANISATION
Union	ORGANISATION

Yes the entity (largest mention) is the organisation here, so I would say first one.

you mean second one ?

@kermitt2 there are two comments from me before (sorry for the confusion): I'm not sure what you refer to.

Sorry I mixed up everything ! the entity (largest mention) is the organisation here, so I would say SECOND one.


Powershell Script - Same issue as #13559

I am having the same Powershell failure as #13559.  My Powershell version is shown below.

Thanks for the feedback! We are currently investigating and will update you shortly.

@jklein68 What is the OS version you are using ? is it windows server 2016 ?

This is 2012 R2.
Jason
On Oct 5, 2018 12:11 AM, SaurabhSharma-MSFT<EMAIL_ADDRESS>wrote:
@jklein68https://github.com/jklein68 What is the OS version you are using ? is it windows server 2016 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/16214#issuecomment-427248257, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ap0zMugu_AkqfmnD9yRrvJhJ6YPvS1sUks5uhuoCgaJpZM4XIaqa.

@jklein68 ok, please refer to `New-SelfSignedCertificate document which has correct syntax  for 2012 r2 version.  You don't have to pass "-Subject" parameter to 2012 r2 version of New-selfsignedcertificate cmdlet

@jklein68 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Support installation via Chocolatey

Chocolatey - is a nice windows package manager, so it will be cool if that software can be distributed by it.
I have the experience to distribute packages through chocolatey, so if you do not mind with that - I willing to create and maintain that package in future

Hey @picolino, sorry for the late response, this one slipped through the cracks somehow.
If you're still interested, I'd be stoked to merge Chocolatey support for this repo!

I've added sqlbench on the Chocolatey package manager. You can download it here:
https://chocolatey.org/packages/sqlbench
Also, @felixge, I recommend sharing the link to that package at the readme file
I will maintain that package in the nearest future and will watch for sqlbench releases to update the package accordingly

@picolino thank you so much for this! I just added some instructions for it to the README, PTAL: https://github.com/felixge/sqlbench/commit/6459970eb2a9bf6a65aa1dad2b68647a579a2b63


Rename generate-jwt to make-jwt

Change the name of the generate-jwt subcommand to make-jwt, per Adam's
suggestion.  "Make" is shorter and consistent with the existing
make_user_data command in cephalopod.

LGTM
(thanks!)


Extend m365 status command with appId and tenantId

Extend m365 status command with appId and tenantId. Closes #3818

Thank you. I am going to review it shortly

Hi @plamber
I'm still waiting for the reply of Waldek because I misunderstood the tenant part of the assignment 🙂

Merged manually


Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input

Details
Added shouldEnableMaxHeight prop to the ScreenWrapper component to float the Next/Save button up to get rid of extra empty space when keyboard gets opened(mWeb - ios safari).
Fixed Issues

$ https://github.com/Expensify/App/issues/22661
PROPOSAL: https://github.com/Expensify/App/issues/22661#issuecomment-1631384298
Tests

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)
Home Address page(Goto Settings -> Profile -> Personal Details ->Home Address)

Security Flow

Close account page(Goto Settings -> Security -> Close account)

[X] Verify that no errors appear in the JS console

Offline tests

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)
Home Address page(Goto Settings -> Profile -> Personal Details ->Home Address)

Security Flow

Close account page(Goto Settings -> Security -> Close account)

QA Steps

For mWeb(safari), Verify the form submit button floats up for the below screens when the keyboard gets opened for any form input

Task Flow

New task details page(Click Fab icon -> Assign Task)
New task title page(Click Fab icon -> Assign Task -> Fill details and next -> Select Title)
New task description page(Click Fab icon -> Assign Task -> Fill details and next -> Select Description)
Task Report title page(Open any task report -> Select Title)
Task Report description page(Open any task report -> Select Description)

Workspace Flow

Workspace settings page(Goto Settings -> Workspaces -> Select any workspace -> Settings)

Profile Flow

Display name page(Goto Settings -> Profile -> Display Name)
New contact method page(Goto Settings -> Profile -> Contact methods -> New contact method)
Legal name page(Goto Settings -> Profile -> Personal Details -> Legal name)
Home Address page(Goto Settings -> Profile -> Personal Details ->Home Address)

Security Flow

Close account page(Goto Settings -> Security -> Close account)

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari
https://drive.google.com/file/d/1L4-_BHX9MHVxQhNnRApLDMFoB5pzGNpk/view?usp=sharing

Desktop

iOS

Android

Home Address: Button is not visible

Close account page: Extra empty space

@Pujan92 On the home address page I can't find the button at all, even scrolling down, it just vanished :sweat_smile:. On the close account page, that seems like a regression, I think we had an issue reported for that before, you can also see the header is not visible either.

@s77rt Seems for scrolling content when we open keyboard for bottom inputs, somehow the View is not assigning correct maxHeight. Not sure yet about exactly what causes this issue.

I think this is related to https://github.com/Expensify/App/issues/8731

@Pujan92 Yes, let's revert those pages

@Pujan92 Yes, let's revert those pages

Reverted.

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


First pass at WebVTT

This allows me to easily import subtitles from YouTube.
It uses the annevk/webvtt library to parse the subtitles. This library seems somewhat unsupported, but it works.
Alternatively Mozilla has https://github.com/mozilla/vtt.js, which seems more complex and requires access to the DOM (or something DOM-like)

Thanks for this! Using annevk/webvtt seems good, I don't see any libs that look better for this.
I'm doing a big overhaul in a branch which changes this part of the code, so I've manually merged this into that branch and will close this.


"Legacy Network" not translate-able on transaction window window

Expected behaviour
When transaction comes from migration, Send Address is "Legacy Network" and it's non-translateable, there is no string on crowdin. Please add the string to translate to the crowdin.

This is in the crowdin translations now.


Glue (Sled) pinning disk

In the process of making & testing #513 I noticed that Glue pins the disk at full usage.
It seems to halt too, perhaps because of disk waits.
This occurs when inserting and doing operations on >200K rows (using SledStorage).
nb. MultiSQL is fine with this so it isn't a Sled issue.

First of all, I decided that it was close to a bug, so I added a bug label.
Please let me know if there are "improvements" that you need an option for.(If you need to label improvements)

I'd consider this a bug too.
Not sure what the cause is.

Anyone recommend some rust profiling tools?  That may help in figuring out where the bottleneck is.

Anyone recommend some rust profiling tools? That may help in figuring out where the bottleneck is.

I have no experience with profiling, but...

https://nnethercote.github.io/perf-book/profiling.html
https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb

I think I usually use something like this:

Here's a profiler that might be of interest:
https://github.com/EmbarkStudios/puffin if anyone is interested.

It seems to me (without good backing) like these closures might be a pretty notable issue. Perhaps it could be done a better way.
https://github.com/gluesql/gluesql/blob/1cdcef9759f9d8cfeb208dc5b22d51ad6f63a1f8/core/src/executor/evaluate/mod.rs#L34-L39

Hmm... Does the perf test look similar with something like:
SELECT 1
FROM A
INNER JOIN B
  ON B.fk = A.pk
GROUP BY A.pk

Here's the perf report after I changed to the select 1 query above:

Yeah so looks to me as though the closures are a problem and occur for all sorts of evals, which is a problem for grouping, and is used in aggregation, which is a big problem.
This could probably easily be fixed by just changing these high-use closures into functions (or, if desperate, macros).

@panarch
Probably an area with some really easy fixes that would massively boost perf.


Example does not build on windows

It looks like the variable static const std::string section; is not being exported in the dll causing linking error. I tried several things but not sure how to resolve the issue so the build of the example is disabled for windows.

Per our conversation, I think we can try changing this to a static function that returns a string instead of being a member variable

Should we incorporate the example back into a unit test now?


Uncaught ReferenceError: process is not defined

Subject of the issue
The VFile constructor references process directly. In a vanilla browser environment, this throws an error. However, many build systems polyfill process so this may have gone unnoticed in most applications -- process is mocked by default by Webpack, and Browserify does something similar.
Your environment

OS: Mac OSX 10.14.5
Packages<EMAIL_ADDRESS><EMAIL_ADDRESS>(via<EMAIL_ADDRESS>Env:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Chrome v76.0.3809.132

Steps to reproduce
In an environment without a global process object (e.g. a vanilla browser, a webpack build with the process mock disabled):

Call vfile(), either as a standalone function (which redirects to call as a constructor) or as a constructor (new VFile()).
or call ☝from e.g. processor.parseFile()

Expected behaviour
The VFile() constructor instantiates an object.
Actual behaviour
The VFile() constructor throws.

Correct, vfile depends on process, so the mocking of process in other environments is indeed expected. I see it as expected behaviour, not as an issue 🤷♂

vfile claims to work in the browser. From the README:

Plus, they work in the browser.

It does work in the browser, but only if process (specifically, process.cwd()) is polyfilled. This is a non-obvious gotcha.
How is VFile.cwd used by vfile consumers? Browsing the source (via GH search, which can yield spotty results), I don't see it referenced in either vfile or unified...

Btw, we talked about this with rexxars from react-markdown already: https://github.com/vfile/vfile/issues/16#issuecomment-305017819

It does work in the browser, but only if process (specifically, process.cwd()) is polyfilled. This is a non-obvious gotcha.

This is indeed how it is intended: it depends on certain aspects, which are available in Node, and typically available in bundlers as well. Unless explicitly turned off.

How is VFile.cwd used by vfile consumers? Browsing the source (via GH search, which can yield spotty results), I don't see it referenced in either vfile or unified...

file.cwd is used because file.path can be relative, in which case, it should be read relative to file.cwd. Indeed, GH search isn’t great, but searching across the collective yields more results.

There are several downsides for touching/changing/removing cwd, as outlined in the issue mentioned above, but also: It’s breaking. vfile itself was downloaded 100m times this year. In total, the projects in the collective are downloaded more than 2B times a year. These numbers are multiplying manyfold per year. Breaking stuff that’s used so much has consequences.

Understood. Thanks for the context. For our project, I've restored the Webpack process polyfill that our framework removes. Probably safe to close this as a wontfix given the risk involved in a change.

Sweet, thanks for raising this and for understanding!
Best

Heads up that Webpack is considering removing default polyfilling, so this may become more of an issue moving forward.
You might consider leaving them feedback if you have thoughts (they're asking for feedback on the decision).

Ah thanks for mentioning that! I found an issue where other module authors already voiced my concerns. I’m interested in seeing what the actual behaviour will be: when warnings show up, we’ll address them somehow!

@wooorm
FIY - current webpack 5.0.2-beta behaviour is following:
ERROR in ./node_modules/unified/node_modules/vfile/core.js 3:11-26
Module not found: Error: Can't resolve 'path' in 'c:\Frontend\node_modules\unified\node_modules\vfile'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need these module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add an alias 'resolve.alias: { "path": "path-browserify" }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.alias: { "path": false }
 @ ./node_modules/unified/node_modules/vfile/index.js 4:12-32
 @ ./node_modules/unified/index.js 6:12-28
 @ ./node_modules/react-markdown/lib/react-markdown.js 13:14-32
 @ ./src/vendor.js 38:0-23
 @ dll vendor vendor[0]

In case anyone comes across this after upgrading to webpack 5, the way to shim process in the browser (following instructions from here https://webpack.js.org/guides/shimming/ ):
package.json
  "devDependencies": {
   ...
    "process": "0.11.10",
  }

webpack.config.json
module.exports = {
  ...
  plugins: [
      new webpack.ProvidePlugin({
             process: 'process/browser',
      }),
  ],
}

ProvidePlugin works, but it shims process to all the modules. I've seen some modules using the existence of process to test if the environment is browser or node, in this case we might prefer not providing process to those modules.
To only shim vfile, you can use imports-loader instead (as introduced here: https://webpack.js.org/guides/shimming/#granular-shimming):
module.exports = {
  module: {
    rules: [
      {
        test: /node_modules\/vfile\/core\.js/,
        use: [{
          loader: 'imports-loader',
          options: {
            type: 'commonjs',
            imports: ['single process/browser process'],
          },
        }],
      },
    ],
  },
};

In case anyone comes across this after upgrading to webpack 5, the way to shim process in the browser (following instructions from here https://webpack.js.org/guides/shimming/ ):
package.json
  "devDependencies": {
   ...
    "process": "0.11.10",
  }

webpack.config.json
module.exports = {
  ...
  plugins: [
      new webpack.ProvidePlugin({
             process: 'process/browser',
      }),
  ],
}

This solution defines the process object, but it doesn't load my .env variables
any idea why?

@facuescobar please direct new questions to https://github.com/vfile/vfile/discussions


ISSUE:

Describe the bug
Environment (please complete the following information):

OS: Home Assistant Core
Type of device: Xeon Workdstation
Home Assistant version:  Core: 2024.11.1, Supervisor 2024.11.2, Frontend 20241106.2
Hassio/Docker/Core? Docker
Component version: [e.g. 0.1.2]

Logs
Logger: homeassistant.util.loop
Source: util/loop.py:136
First occurred: 12:58:52 PM (1 occurrences)
Last logged: 12:58:52 PM
Detected blocking call to load_default_certs with args (<ssl.SSLContext object at 0x7f11c4e433d0>, <Purpose.SERVER_AUTH: _ASN1Object(nid=129, shortname='serverAuth', longname='TLS Web Server Authentication', oid='<IP_ADDRESS>.<IP_ADDRESS>.1')>) inside the event loop by custom integration 'mail_and_packages' at custom_components/mail_and_packages/helpers.py, line 122: context = ssl.create_default_context() (offender: /usr/local/lib/python3.12/ssl.py, line 713: context.load_default_certs(purpose)), please create a bug report at https://github.com/moralmunky/Home-Assistant-Mail-And-Packages/issues For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#load_default_certs Traceback (most recent call last): File "", line 198, in _run_module_as_main File "", line 88, in _run_code File "/usr/src/homeassistant/homeassistant/main.py", line 223, in  sys.exit(main()) File "/usr/src/homeassistant/homeassistant/main.py", line 209, in main exit_code = runner.run(runtime_conf) File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run return loop.run_until_complete(setup_and_run_hass(runtime_config)) File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete self.run_forever() File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever self._run_once() File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once handle._run() File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run self._context.run(self._callback, *self._args) File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 556, in start task = asyncio.Task(coro, loop=loop, eager_start=True) File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 477, in _handle_request resp = await request_handler(request) File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 559, in _handle return await handler(request) File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 117, in impl return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 86, in ban_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 242, in auth_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 32, in headers_middleware response = await handler(request) File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle result = await handler(request, **request.match_info) File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 81, in with_admin return await func(self, request, *args, **kwargs) File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 222, in post return await super().post(request, flow_id) File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 74, in wrapper return await method(view, request, data, *args, **kwargs) File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 122, in post result = await self._flow_mgr.async_configure(flow_id, data) File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 367, in async_configure result = await self._async_configure(flow_id, user_input) File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 414, in _async_configure result = await self._async_handle_step( File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 517, in _async_handle_step result: _FlowResultT = await getattr(flow, method)(user_input) File "/config/custom_components/mail_and_packages/config_flow.py", line 322, in async_step_user valid = await _test_login( File "/config/custom_components/mail_and_packages/helpers.py", line 122, in _test_login context = ssl.create_default_context()
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I was just trying to get the mail and packages going again after the last update said the file path was invalid for the camera entity to show the image.  I removed it and was adding it back in, but haven't got it going again, and saw this in the logs and it said to send a bug report, so here it is.

You can ignore this message.


[Bug]: Winston won't create log file using File transport

🔎 Search Terms
Won't Create File
The problem
I can get the console transport to work and this create the Logs directory, but it doesn't create any log files and doesn't provide any error information.
What version of Winston presents the issue?
v3.8.2
What version of Node are you using?
v19.2.0
If this worked in a previous version of Winston, which was it?
No response
Minimum Working Example

const logger = createLogger({
    level: 'debug',
    exitOnError: false,
    format: format.combine(format.splat(), format.simple(), format.json()),
    transports: [
        new transports.File({ filename: `${global.__basedir}/logs/error.log` })
    ]
});

logger.add(new transports.Console({
    format: format.combine(
        format.colorize(),
        format.simple()
    )
}));

module.exports = logger;

// Example logs
logger.log('info', 'Hello simple log!');
logger.info('Hello log with metas', { color: 'blue' });

Additional information
No response

Do you get what you expect if you console.log(${global.__basedir}/logs/error.log) at the top of the file?

I think I just observed a similar or related error as well:

When I try to log to /var/log/script.log (with sudo permissions mind you) no log-file is created.
In addition to that the program stalls after an equal number of console-transport logs for no apparent reason, my guess is that the file-transport buffer is full, which causes any further logging operation to stall the whole program
When I instead try to log to script.log or even </path/to/script>/script.log a log-file is created and progam continues without being stalled after a while

So the issue (at least on my part) seems to stem trying to log to a directory outside the script directory.

Workaround confirmed to work:
const logger = createLogger({
    level: 'debug',
    format: format.combine(format.splat(), format.simple(), format.json()),
    transports: [
        new transports.File({
            filename: 'error.log',
            dirname: `${global.__basedir}/logs`,
        })
    ]
});

logger.add(new transports.Console({
    format: format.combine(
        format.colorize(),
        format.simple()
    )
}));

module.exports = logger;

// Example logs
logger.log('info', 'Hello simple log!');
logger.info('Hello log with metas', { color: 'blue' });

Wanted to note that I ran into this as well and adding the dirname property to go along with the filename property for the transport fixed my issue. Given that dirname was not in the docs for the File transport, would not have known to try this.

PR even just for docs would be greatly welcomed and appreciated!!!


[Feature Request] Task level health check should supported

Firstly, RUNNING state task doesn't mean that task is ready to serving request, so I think additional state might be needed to represent state of microservices within a task, and the state should reflect result of health check with attempts within a time period, and also I think the health check should impose on task level instead of services level as a health services doesn't mean every of its tasks are all health.

This is being handled here: #24139, at least as the first step.

is this a duplicate of https://github.com/docker/docker/issues/23962 ?

This is a more general case, and there will likely be a number of things to update.
The mentioned PR is just the first step, then there's making update work with healthchecks, and probably routing mesh as well.

http://mesosphere.github.io/marathon/docs/health-checks.html
Above link is how Mesos Marathon address this issue, hope it can add some help.


npm run watch doesn’t work due missing dependencies

I’ve tried it with both npm 2.x and 3.x with the same result.
npm install
...
npm run watch

><EMAIL_ADDRESS>watch /Users/jimmy/Temp/mermaid
> source  ./scripts/watch.sh

./scripts/watch.sh: line 3: watchify: command not found
./scripts/watch.sh: line 4: live-server: command not found
module.js:339
    throw err;
    ^

Error: Cannot find module 'brace-expansion'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/jimmy/Temp/mermaid/node_modules/eslint/node_modules/minimatch/minimatch.js:10:14)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)

npm ERR! Darwin 13.4.0
npm ERR! argv "/usr/local/var/lib/nodenv/versions/4.2.3/bin/node" "/usr/local/var/lib/nodenv/versions/4.2.3/bin/npm" "run" "watch"
npm ERR! node v4.2.3
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>watch: `source  ./scripts/watch.sh`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>watch script 'source  ./scripts/watch.sh'.
npm ERR! This is most likely a problem with the mermaid package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     source  ./scripts/watch.sh
npm ERR! You can get their info via:
npm ERR!     npm owner ls mermaid
npm ERR! There is likely additional logging output above.

Thanks. Will add them!

No longer relevant.


CP-121: Django 1.9 Upgrade (backwards incompatible changes)

See an overview of the changes [here] (https://github.com/vikingco/mvne-platform/pull/4798).

We removed this as a dependency, closing.


Install pigz for parallel decompression in docker pull

Docker added some support for slightly improving docker pull performance if unpigz is available, see the notes here: https://github.com/moby/moby/issues/37957#issuecomment-426633293

/cc @toolmantim :)

🎉


add binded sql to kysely instance

Basically a convenience property to not have to import sql separately nor specifying any argument on execute method.
Please let me know if there's a way to get rid of the cast in
// src/raw-builder/raw-builder.ts [line 34]
this.#executor = executor as (B extends true ? QueryExecutor : undefined)

and the redundant type guard on
// src/raw-builder/raw-builder.ts [line 133]
if (executor === undefined) {
  throw new Error('Unreachable code')
}

I don't think this is a good idea. Having two different sql functions will cause confusion. Kysely used to have a bound method like this but I specifically removed it for simplicity.


Expansion panel

What is the expected behavior?
https://screenshots.firefox.com/O3sRlUPyEIUxmlf4/app.zeplin.io
I was expecting the above behavior ( i.e once the user clicks on create the post button, The respective button should get disappear and the expansion panel data alone should highlight ) below screenshots will give you the picture of current behavior.
What is the current behavior?
https://screenshots.firefox.com/otRRfJduqoK3PTB0/localhost
When the user clicks on the above-mentioned button ( i.e create the post ) the panel expansion takes place.
https://screenshots.firefox.com/fkXIWy9nRHVgVsoG/localhost
The above-mentioned screen gives you the picture of the panel expansion.
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular version: 6 plus
Angular Material: 6 plus
OS: Linux ( 16.04 )_
TypeScript: 2.9
browsers: chrome, firefox
Is there anything else we should know?
Please team give me some sort of suggestions to overcome expected behavior.

Your screenshots are no longer loading, can you update them?

Closing because this issue has been inactive for 2 weeks or more after follow up was requested.


minifix(gui): Only enable Kiosk Mode when FULLSCREEN is set

This fixes the kiosk setting always being true, and causing
the operating system's desktop to disappear.
Change-Type: patch

This is what was happening; note the missing bar at the very top


Medusa strike

Wow, the grapple mechanic is really impressive! Do you think that you would be able to add medusa strike as a monk bonus feat?

You mean Medusa's Wrath?

I just realized - Feats from style feat chains can work without the style itself? So you can take feats from different styles and they work together?

Ah, you are right, I meant medusa's wrath.  In TT, it's offered as a bonus feat (not requiring the previous feats in the chain) t level 10 and doesnt require the previous feats in the chain to activate RAW.  I can't think of others off the top of my head but I assume if the feat RAW doesn't mention needing the other feats to activate then it should be fine.  However, you would still need the other feats to choose it as an option if not offered as a bonus feat.  You can compare pummeling bully to medusa's wrath to see the difference in the text: https://www.d20pfsrd.com/feats/combat-feats/pummeling-bully-combat/ vs https://www.d20pfsrd.com/feats/combat-feats/medusa-s-wrath-combat/

Looks pretty cool! I won't be adding the first two feats though, maybe merging it with another style while being a monk bonus feat lol


SSL handshake error reported for shields.io domain

Are you experiencing an issue with...
shields.io
🐞 Description
I'm seeing repeated CloudFlare error pages when trying to access shields.io (from the UK, but tried on various VPN and with alternate network routes).
🔗 Link to the badge
No response
💡 Possible Solution
No response

Thank you for reaching out. Our certs have expired, apologies for the inconvenience

Things should be back to good working order, but will keep this open for a bit longer just in case

They work for me again, thanks!

Looking good here, thank you Caleb!

The same problem happened again through Cloudflare Frankfurt.


[Security] Workflow npm-publish.yml is using vulnerable action actions/checkout

The workflow npm-publish.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

Fixed in c06fbaa.


Updated repository description and graphics

Since the app gets a huge update now, here's a refreshed version of project description. Please check it out and edit if/where needed.

Thank you @ux-git. Exciting updates... 😄😄

:tada: This PR is included in version 2.112.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[release-1.4] minor optimization in service entry conversion

This is an automated cherry-pick of #18328

@rshriram You will need to do a @googlebot I consent to satisfy the CLA bot.


VectorImageLayer with ClusterSource disappears after loading

Describe the bug
I'm using version 6.0.0-beta.3 in my Angular app and have the following map:
this.clusterSource = new ClusterSource({
    distance: 10,
    source: this.broSource,
    geometryFunction: feature => new geom.Point(extent.getCenter(feature.getGeometry().getExtent()))
});

this.clusterLayer = new VectorImageLayer({
    source: this.clusterSource,
    style: new style.Style({
        image: new style.Circle({
            radius: 10,
            stroke: new style.Stroke({
                color: '#fff'
            }),
            fill: new style.Fill({
                color: '#3399CC'
            })
        }),
        text: new style.Text({
            text: '3',
            fill: new style.Fill({
                color: '#fff'
            })
        })
    })
});

this.map = new Map({
    target: 'map-canvas',
    layers: [this.clusterLayer],
    view: this.view,
    interactions: interaction.defaults({mouseWheelZoom: false})
});

When the cluster layer is loaded, the features in the layer can be briefly seen, after which they disappear again.
I've noticed the same behaviour when I use a VectorLayer instead of a VectorImageLayer,
A javascript version (5.3.0) with the exact same clustered layer is working correctly.
Expected behavior
For the cluster layer to remain visible.

Can you please provide a minimal example in a CodePen or similar that shows the issue ? Thanks

Is there a hosted version of the v6.0.0-beta.3 release somewhere that I can use in a CodePen?

That's actually not needed: this issue can be reproduced with the cluster example. The features disappear  as soon as the slider is changed.

Ah, so it seems to be an issue with 5.3.0 as well?

Ah, so it seems to be an issue with 5.3.0 as well?

No, the example in version 5.3.0 works:
https://openlayers.org/en/v5.3.0/examples/cluster.html
But not the master version:
https://openlayers.org/en/master/examples/cluster.html

The change in the pull request #9329 fixes the cluster example.

@jippeholwerda The fix is now merged into master and will be available in the next (beta) release.
I'm closing this issue, if your problem still persist after using the new upcoming version please open a new issue.


[Feature]: Stop support react 16, 17

Package Scope

[x] Add to an existing package
[x] New package

Package name: @suspensive/react @suspensive/react-query
Overview

remove use-sync-external-store/shim
plan in v2
easier maintainance

Describe the solution you'd like

Additional context

@minsoo-web @okinawaa @ojj1123
Finally, we remove react v16 v17 and use-sync-external-store in #631 It will be released in<EMAIL_ADDRESS>


Comparison with 99designs/keyring

Hey there! It appears to me that 99designs/keyring supports more backends compared to go-keyring. Other than that, are there any differences between both of them? Looks like 99designs/keyring also supports KWallet as well custom keyring names while go-keyring has open PRs for a while now.

Hey there! It appears to me that 99designs/keyring supports more backends compared to go-keyring. Other than that, are there any differences between both of them? Looks like 99designs/keyring also supports KWallet as well custom keyring names while go-keyring has open PRs for a while now.

zalando/go-keyring uses pure go implementation but 99designs uses C bindings so you have to use the CGO flag to use it properly. I've experienced lots of problems while using it so I went back to use this library.

99designs uses C bindings

At least for Linux, this is untrue, try CGO_ENABLED=0 GOOS=linux go build in https://github.com/99designs/keyring and it will work, there's no code within 99designs/keyring that uses cgo, what OS are you building it for?

99designs uses C bindings

At least for Linux, this is untrue, try CGO_ENABLED=0 GOOS=linux go build in https://github.com/99designs/keyring and it will work, there's no direct code within 99designs/keyring that uses cgo, what OS are you building it for?
What other problems have you experienced aside from failing to enable cgo at build time?

I haven't had any other problem. I use GoRelaser to build it for Windows, macOS and Linux

We switched to 99designs/keyring but now are switching back to this package

On macOS, 99designs/keyring uses CGO to access the keychain while zalando/go-keyring shells out to the security command.
The disadvantage of zalando/go-keyring's approach is that if the user grants "Always Allow" access to security, any process including a bash script can read keychain items without a password prompt.
Because 99designs/keyring accesses the keychain directly through CGO instead of shelling out, an "Always Allow" grant only gives access to the specific binary using 99designs/keyring. So 99designs/keyring's approach is more secure, assuming the binary has a smaller attack surface area than security.

On macOS, 99designs/keyring uses CGO (via https://github.com/99designs/go-keychain) to access the keychain while zalando/go-keyring shells out to the security command.
The disadvantage of zalando/go-keyring's approach is that if the user grants "Always Allow" access to security, any process including a bash script can read keychain items without a password prompt.
Because 99designs/keyring accesses the keychain directly through CGO instead of shelling out, an "Always Allow" grant only gives access to the specific binary using 99designs/keyring. So 99designs/keyring's approach is more secure, assuming the binary has a smaller attack surface area than security.

On macOS, 99designs/keyring uses CGO (via https://github.com/99designs/go-keychain) to access the keychain while zalando/go-keyring shells out to the security command.
The disadvantage of zalando/go-keyring's approach are:

When prompting for a password the process using the keychain is obfuscated and reported as security, eg:

If the user grants "Always Allow" access to security, any process including a bash script can read keychain items without a password prompt.

Because 99designs/keyring accesses the keychain directly through CGO instead of shelling out, an "Always Allow" grant only gives access to the specific binary using 99designs/keyring. So 99designs/keyring's approach is more secure, assuming the binary has a smaller attack surface area than security.


Exclude HN site from search-engine indexing

As mentioned in discord, having so many non-svelte results show up when searching for svelte related content can negatively impact people's ability to find the content they are looking for

I probably would have implemented this by adding a robots.txt in the static/ directory. It will save a few bytes of traffic for all our real users and also increase our Lighthouse score, which I believe checks if you have defined a robots.txt. Since this is an example site, it's probably worth trying to be a little extra pedantic in following the practices we'd like to promote
I'm curious, what searches is hn.svelte.dev showing up for where we'd like it to be excluded?

The problem with using robots.txt is that it blocks the search engines from being told to remove entries. For a new site it's correct but you need to allow the spiders access to learn that the entries need to be removed (but it could be added after they are)
The example given was for "svelte fuzzing", which for me also brings up a totally non-svelte related page from the hn site:

Looks like there are about 8,250 pages indexed from it.

The problem with using robots.txt is that it blocks the search engines from being told to remove entries.

wtf! well that explains why I haven't gotten svelte.dev/tutorial out of the search results yet (in favor of learn.svelte.dev). I just requested to remove it in the google search console, but I suppose I'd need to do the same for bing, etc. so this is probably still the better solution in that case so that the other search engines are handled


v1.9.1 has no way to access http responses of get requests.

when using the conn to run a raw http request jsforce has no way to access things like headers, or status code. makes pulling out content types of a request difficult along with other basic http work.

Strange that no one responded yet on a valid question here.


Duplicate and non-trimmed genes in matrix_constructor.py output

Hi guys,
I have a weird issue with duplicated genes in the final concatenation after running matrix_constructor.py, using a small subset of genes. Looking at matrix.fas they also don't appear to be trimmed, and the duplication is also documented in indices.tsv:
Gene	Start	Stop
BTUB	1	456
BTUB	457	912
GRC5	913	1130
GRC5	1131	1348
NSA2	1349	1610
NSA2	1611	1872
PSMD6	1873	2306
PSMD6	2307	2740
RPL12	2741	2907
RPL12	2908	3074
RPL13A	3075	3298
RPL13A	3299	3522
RPL17	3523	3712
RPL17	3713	3902
RPL19	3903	4113
RPL19	4114	4324
RPL21	4325	4498
RPL21	4499	4672
RPL30	4673	4788
RPL30	4789	4904
RPL7A	4905	5148
RPL7A	5149	5392
RPPO	5393	5715
RPPO	5716	6038
RPS12	6039	6178
RPS12	6179	6318
RPS15	6319	6470
RPS15	6471	6622
RPS17	6623	6759
RPS17	6760	6896
RPS26	6897	7008
RPS26	7009	7120

Background is: I have a dataset from which I generated a final concatenation before with matrix_constructor.py, and ran IQTree on that a while ago. No duplicated genes and everything is as it should be.
I then noticed that some of my single-gene trees used in this process had a paralogy/contamination issue with one of the taxa, so I went through the single-gene trees again with parasorter and sorted it out (haha). I then used apply_to_db.py with the updated *_parsed.tsv files using the original fisher.py output. Selecting taxa and orthologs also worked without issues, as did prepping the final dataset (although using the same completeness-cutoff with select_orthologs as before now gives me a different, bigger selection of genes). When I run matrix_constructor.py it seems to finish ok, but the output in matrix.fas is a) not trimmed and b) has each gene twice.
The logs for trimal and divvier in the matrix_constructor output are empty for each gene, the ones for prequal and mafft are there and seem fine to me.
I was using version 1.2.6 at the time and that is what I am currently sticking to as well for version consistency and tractability in the final paper. I ran my single-gene trees via IQTree, not RAxML, in case that matters.
I'm really not sure what's going on – I reran everything several times now, including with version 1.2.6 and 1.2.13, same result. Any idea of what the issue might be?
I'll happily give you any output files and folders (prefer not public if possible).
Cheers,
Gordon

Hi Gordon,
Apologies for the inconvenience as always. Robert and I have a PhyloFisher meeting scheduled for noon Wednesday, we will put this on the list of talking points and get back to you ASAP.
Alex
Get Outlook for iOShttps://aka.ms/o0ukef

From: Gordon Lax @.>
Sent: Monday, January 15, 2024 7:06:58 PM
To: TheBrownLab/PhyloFisher @.>
Cc: Subscribed @.***>
Subject: [TheBrownLab/PhyloFisher] Duplicate and non-trimmed genes in matrix_constructor.py output (Issue #112)
This email originated outside TTU. Please exercise cautionhttps://askit.ttu.edu/phishing!
Hi guys,
I have a weird issue with duplicated genes in the final concatenation after running matrix_constructor.py, using a small subset of genes. Looking at matrix.fas they also don't appear to be trimmed, and the duplication is also documented in indices.tsv:
Gene    Start   Stop
BTUB    1       456
BTUB    457     912
GRC5    913     1130
GRC5    1131    1348
NSA2    1349    1610
NSA2    1611    1872
PSMD6   1873    2306
PSMD6   2307    2740
RPL12   2741    2907
RPL12   2908    3074
RPL13A  3075    3298
RPL13A  3299    3522
RPL17   3523    3712
RPL17   3713    3902
RPL19   3903    4113
RPL19   4114    4324
RPL21   4325    4498
RPL21   4499    4672
RPL30   4673    4788
RPL30   4789    4904
RPL7A   4905    5148
RPL7A   5149    5392
RPPO    5393    5715
RPPO    5716    6038
RPS12   6039    6178
RPS12   6179    6318
RPS15   6319    6470
RPS15   6471    6622
RPS17   6623    6759
RPS17   6760    6896
RPS26   6897    7008
RPS26   7009    7120
Background is: I have a dataset from which I generated a final concatenation before with matrix_constructor.py, and ran IQTree on that a while ago. No duplicated genes and everything is as it should be.
I then noticed that some of my single-gene trees used in this process had a paralogy/contamination issue with one of the taxa, so I went through the single-gene trees again with parasorter and sorted it out (haha). I then used apply_to_db.py with the updated *_parsed.tsv files using the original fisher.py output. Selecting taxa and orthologs also worked without issues, as did prepping the final dataset (although using the same completeness-cutoff with select_orthologs as before now gives me a different, bigger selection of genes). When I run matrix_constructor.py it seems to finish ok, but the output in matrix.fas is a) not trimmed and b) has each gene twice.
The logs for trimal and divvier in the matrix_constructor output are empty for each gene, the ones for prequal and mafft are there and seem fine to me.
I was using version 1.2.6 at the time and that is what I am currently sticking to as well for version consistency and tractability in the final paper. I ran my single-gene trees via IQTree, not RAxML, in case that matters.
I'm really not sure what's going on – I reran everything several times now, including with version 1.2.6 and 1.2.13, same result. Any idea of what the issue might be?
I'll happily give you any output files and folders (prefer not public if possible).
Cheers,
Gordon
—
Reply to this email directly, view it on GitHubhttps://github.com/TheBrownLab/PhyloFisher/issues/112, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADA4OK5LMMNAUE4QNZTXRK3YOXHDFAVCNFSM6AAAAABB4ACF22VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DEOBWGAZTGNA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thanks as always Alex! And no worries – this stuff is bound to happen with something as complex as Phylofisher.
Cheers,
Gordon

Hi Gordon,
We caught and cured the bug that created the duplicated genes a while back in v. 1.2.6. We have not noticed it still being a problem in v. 1.2.13 and we have made quite a few matrices lately. Will you just double check that you were actually using 1.2.13. Maybe even install it in a fresh environment and confirm the issue is still present?
Alex

Hi Alex,
Ah turns out if I use version 1.2.13 it actually works now! No duplicate genes and they were trimmed prior to concatenation. Sorry about this, apparently I did not use 1.2.13 during troubleshooting.
Thanks again for dealing with this so quickly, I appreciate it!
Cheers,
Gordon


Spinner while loading autocomplete results

Describe the problem
Is there an elegant way to implement a spinner while the results are loaded?
Are there any event listeners to network request fire/return? I see there are listeners for errors/timeout and not found but this is not enough...
Additional context

Library Version: 1.8.0

React Native Version: 0.63.3

[X] iOS

[X] Android

[ ] Web

If you are using expo please indicate here:

[X] I am using expo (bare)

@FaridSafi
@eyalyoli
I created a PR that handles this #720

Please has this been published to npm

I was wondering about this is well. It would be easy to implement if we had an "onCallback","onSuccess" etc callback. But we dont. We have onFailure, onEmpty, etc, but not onSuccess.

There was a loading related PR that was merged recently. It need to go through proper testing, and I haven't had the time. Consider using patch-package in the interim.

I was wondering about this is well. It would be easy to implement if we had an "onCallback","onSuccess" etc callback. But we dont. We have onFailure, onEmpty, etc, but not onSuccess.

This can be good. But i think the spinner ui should be handled internally since it is logically a part of the internal ui


i18n: init using react-i18next

This adds an i18n framework using react-i18next. Using this by:

import { translate } from 'react-i18next';
Wrap the component using translate("category")(...) and use t("name", { ...options }) for texts to be translated.
Add the required translation name in locales/lang/category.json.

@dulanov How will this PR be dealt with? Seems right now we've got conflicts. Should I push this at a later time or it is possible to start translation now?

Always resolve conflicts firstly, @elaineo answer please, is it ok to merge it now?

Ah! Is this a followup to the discussion on slack about adding language support? Everything looks fine to me, but I assume this will be a work in progress, right?

I've got the framework in. It's working. 😂  So in my opinion it's okay to merge. After that we can gradually replace hard-coded texts with t(...) and add translations.
I'll resolve the conflicts now.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


lpod-python: init -> 1.1.5

Judging from the Travis build log this package doesn't seem to be compatible with Python 3.x. Could you fix this? Aside from that this looks good.

Indeed, I think some work was done once on adding Python 3 support, but I don't think it was finished.

Could you rebase and squash your commits. Then it's ready to be merged.

@leenaars I think something has gone with the rebasing

@FRidh Eeks. Yes, it did. Okay now...

thanks


share/availability/light: Unmarshalling of failed sample results in false-positive error

2024-11-15T15:58:13.262Z	ERROR	das	das/worker.go:134	failed to sample header	{"type": "retry", "height": 3089050, "hash": "F2D6B3C115227531BB89B525073451475ABA4D997445043622A7A336196218F8", "square width": 2, "data root": "8F86D0659F5D39A08F3064E0352F64C5EA1558AA8C607A428A8722108268F090", "err": "invalid sampling result: expected 16 samples, got 4", "finished (s)": 0.00136031}
2024-11-15T15:58:13.262Z	ERROR	das	das/worker.go:134	failed to sample header	{"type": "retry", "height": 3089855, "hash": "C6805A02F90C480BA5422D419BDFCA044427F6CE6A2BAF34EB0B6DA18190D035", "square width": 2, "data root": "DAD2887B6E3BC2FB4E27ED6ADBD350744CB1121AA3C9E2F60D87BE57522517E7", "err": "invalid sampling result: expected 16 samples, got 4", "finished (s)": 0.00147832}

with corresponding non-empty block:
https://mocha.celenium.io/block/3089855?tab=transactions
This is because of https://github.com/celestiaorg/celestia-node/blob/main/share/availability/light/availability.go#L106
While we allow for smaller sampling set when generating the randomised coordinates, we still throw error if it doesn't align with the default amount (16). So if some retries occur on a block that looks like this, this error will happen.

On second thought, we shouldn't sample all 4 quadrants of the square - one is sufficient and should be considered as an optimisation.


chore: bdd-ghfjxy-import-1585970338 to 0.0.1

chore: Promote bdd-ghfjxy-import-1585970338 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


⚠ ClamAV has degraded performance

In d1fcbae, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 52 ms

Resolved: ClamAV performance has improved in 592be08.


wrong behavior when making cluster_group assignment with only one cluster selected

It should move that cluster to its new place in the list, and auto-advance you to the next one in the list from where you were. E.g. In KV if you had one cluster selected and pressed "delete", it would move to MUA and you'd move to the next.

Actually this is more general than I thought - when I am using the wizard with two clusters selected, I am also not getting the right behavior. When I assign best unsorted to good, nothing happens (though the console reports moving the cluster to good).
If I merge two clusters, it shows me the new one, but pressing enter does not pin it, instead it pins the first cluster (even if I had already sent that to good).

yeaah i changed this for merges because it was broken, but I might have forgotten to do it for cluster group changes (this is a new bug, right?)

Yes, I think it worked before.
On Jun 26, 2015 7:53 PM, "Cyrille Rossant"<EMAIL_ADDRESS>wrote:

yeaah i changed this for merges because it was broken, but I might have
forgotten to do it for cluster group changes (this is a new bug, right?)
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/433#issuecomment-115831821.

this will be properly unit-tested after the big testing refactoring I have to do for 0.3.0

hmm sorry this was a serious regression :( it should be all fixed in PR #418


Can you add examples having a button in each row and a modal will be created if the button is clicked?

I can not find such example:
There is a button column in table, each row has a button. When user click one of the button, a simple modal will be created.

Hi @kliu4 did you find a solution for this. You can see issue #544.


Unable to use addPushDeviceToken()

I'm unable to use addPushDeviceToken() in my nativescript IOS application, it is throwing following exception: "libc++abi.dylib: terminating with uncaught exception of type NSException"
I'm using following verisons
│ Component            │ Current version │ Latest version │ Information      │
│ nativescript           │ 2.5.3           │ 2.5.4          │ Update available │
│ tns-core-modules │ 2.5.0           │ 2.5.2          │ Update available │
│ tns-android            │ 2.5.0           │ 2.5.0          │ Up to date       │
│ tns-ios                    │ 2.5.0           │ 2.5.0          │ Up to date
How do I register a device in nativescript ios application so that I can perform push notifications using mixpanel.

Hello, can you please try the latest version (2.0.1) and let me know if you still have problems? Also an example project would help...closing this for now but please reopen it in case you still have problems...cheers