2 Digit Locale breaks date filter

Current behavior
In the scenario where a locale is only 2-digits (e.g. 'en'), separatorIndex has a value of -1. The line const languageCode = separatorIndex ? storeLocale.substr(0, separatorIndex) : storeLocale checks the "truthiness" of that value, which according to MDN, -1 is actually truthy. This resulted in a series of errors because languageCode was an empty value which caused dayjs to complain about dayjs().locale().locale().
Expected behavior
The value of separatorIndex should be checked that it is greater than -1.
Steps to reproduce the issue

Set a store's locale to be a 2-digit code without a dash (such as 'en' or 'fr').
Go to a view which uses the date filter, such as Order History.
View console for all the errors.

Can you handle fixing this bug by yourself?

[x] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Node: 10.16
Code Version: v1.10.2

Thanks @rain2o :)


Build Script Updates

Porting changes from the InfluxDB and Telegraf build scripts to build.py. There are quite a few changes here, namely:

Structure of script was changed to make it easier to port future changes. All project-specific variables and functions should go at the top of the file, while the bottom portion of the file should not change (unless it changes across all projects).
tar package output has a kapactor-<version> base directory (instead of the root package filesystem)
Modified the package output for 32-bit builds to use i386 instead of 386 designation for easier integration with package managers (doesn't apply to Kapacitor at the moment)
Moved boto import to upload function. Also enabled folder hierarchy when uploading packages to S3 ( can upload to kapacitor/folder1, etc).
A few more CLI options were added (--no-get, --debug, --goarm=, --pkgarch)
Added --no-vet to circle.yml since it was causing builds to break, and I believe it's unneeded for Kapacitor.

@nathanielc I believe this is ready for your review. I've tried to push all project-specific code to the top of the file to make it easier to port features across the different projects in the future, but let me know if you think there may be any issues with that approach.

@rossmcdonald  I am trying this branch out locally. I am making a few small changes. I'll post them soon.

@rossmcdonald I have pushed up my changes.
I added a --no-stash option. Now go_get will first check for local changes and if no-stash was provided it will error out the script. This has a few nice benefits.

No longer possible to accidentally build a package off non committed code. This is important since we want to always know what code is in a published package.
The build will fail if the generated code is out of date. Since generate is run first and if it changes anything then changes will stop the build. Again back to the first point we want to know exactly what code makes it into a published package.

Sorry for all the whitespace changes hopefully this change is beneficial to all projects and not too difficult to port later.
I am still working on the go vet issue....

@rossmcdonald For the go vet I am using different options to the command. So I turned the command into a project specific option so that each project can control what go vet does. Sound good?

@nathanielc That sounds great. I was wondering why I was receiving so many errors when from the vet output, so that makes sense.


[Soc2014] Official meta API

I've just completed a survey of all the outstanding comments on this PR, creating a TODO list for merge:

[ ] Revert import reorganisation in django/contrib/admin/checks.py
[ ] Remove redundant has_relation from django/db/models/fields/related.py
[ ] Cleaned up docstring text in django/db/models/options.py
[ ] Refactor get_field() to use explicit many_to_many argument.
[ ] Resolve use of local_* in django/db/models/base.py
[ ] Resolve bad reference in releases/1.8.txt,
[ ] Resolve use of local_fields etc.
[ ] Add migration guide to releases/1.8.txt
[ ] Add tests for new field types (UUIDField, etc)
[ ] Resolve Location for FieldDoesNotExist exception?
[ ] Add documentation for is_reverse_object (or remove completely?)
[ ] Move related flags to ForeignKey, rather than ForeignObject
[ ] Final flake8 check
[ ] Final python -Wall runtests.py check

I've just completed a survey of all the outstanding comments on this PR, creating a TODO list for merge:

[ ] Revert import reorganisation in django/contrib/admin/checks.py
[ ] Remove redundant has_relation from django/db/models/fields/related.py
[ ] Cleaned up docstring text in django/db/models/options.py
[ ] Refactor get_field() to use explicit many_to_many argument.
[ ] Resolve use of local_* in django/db/models/base.py
[ ] Resolve bad reference in releases/1.8.txt,
[ ] Resolve use of local_fields etc.
[ ] Add migration guide to releases/1.8.txt
[ ] Add tests for new field types (UUIDField, etc)
[ ] Resolve Location for FieldDoesNotExist exception?
[ ] Add documentation for is_reverse_object (or remove completely?)
[ ] Move related flags to ForeignKey, rather than ForeignObject
[ ] Final flake8 check
[ ] Final python -Wall runtests.py check

@timgraham Regarding your point 3 about ForeignObject - GenericRelation does reverse some of the flags, and ForeignObject is undocumented - but it is tested, and if you take those flags out, some tests fail. So - my inclination is to leave the flags on ForeignObject as they are; yes, they're going to be altered by some subclasses, but they're reasonable defaults, and easy to change if the default value isn't right.

@timgraham Regarding your point 3 about ForeignObject - GenericRelation does reverse some of the flags, and ForeignObject is undocumented - but it is tested, and if you take those flags out, some tests fail. So - my inclination is to leave the flags on ForeignObject as they are; yes, they're going to be altered by some subclasses, but they're reasonable defaults, and easy to change if the default value isn't right.

Changes, mostly cosmetic: http://dpaste.com/2WDN0F1
There is one TODO that needs to be addressed in the docs however.
Other notes:

I didn't follow the discussion on the mailing list closely, but there are some places that now read related.related_model as opposed to related.model. Just wanted to double check that "the related model of a related object" as the code now indicates is more accurate description of what should be there.
Should we name model_meta/test.py -> tests.py for consistency with the rest of the test packages?

Two things to add to the checklist:

Investigate why the tracebacks on ref/models/meta.html render twice.
squash commits

Changes, mostly cosmetic: http://dpaste.com/2WDN0F1
There is one TODO that needs to be addressed in the docs however.
Other notes:

I didn't follow the discussion on the mailing list closely, but there are some places that now read related.related_model as opposed to related.model. Just wanted to double check that "the related model of a related object" as the code now indicates is more accurate description of what should be there.
Should we name model_meta/test.py -> tests.py for consistency with the rest of the test packages?

Two things to add to the checklist:

Investigate why the tracebacks on ref/models/meta.html render twice.
squash commits

buildbot, test this please.

@timgraham Can you elaborate on how/where you're seeing duplicated tracebacks in ref/models/meta.html? I'm rendering the docs locally, and not seeing any duplicates.
I'm also not sure what you're referring to about the TODO in the docs - I can't find any todo markers, and there isn't any obvious dangling text to be addressed.
Other notes:

I've renamed model_meta/test.py for consistency
Closing the loop on the ForeignObject discussion - on IRC, @timgraham deferred judgement, so let's leave the flags on ForeignObject.
The related.model vs related_model thing is a part of the refactor that came from removing parent_model. There will sometimes be multiple paths to get to a model (since both "ends" of a relation know the model and the related model); requests for related.related_model could probably be formulated in other ways, but it's just as valid.  I'll do a final audit to make sure that model and related_model are all set correctly, but otherwise, I don't think there's anything needing attention.

I've just audited the related_model/model code, and  - essentially rel.related_model == rel.field.model, rel. model == rel.field.related_model. This is the price we pay for being able to query related_model and model on any relation-like object.
There is a small bug with reference resolution (string references to models aren't being resolved correctly), but the right models are being referenced. I'll clean up the string references (item added to TODO list), but I think we can close off this issue.

@PirosB3 Did you ever open a ticket (or find an existing ticket) for this feature? I seem to recall there was one, but I can't find it in Trac.

buildbot, test this please.

@freakboy3742 is this a good ticket? https://code.djangoproject.com/ticket/12663

@freakboy3742 @carljm looking at removing local_* in base.py

ok @carljm @freakboy3742 unfortunately looks like we can't just replace local_* calls in models/base.py. The reason is because, as get_fields() call the relation tree, apps is obviously not ready at that point.
We can, however, replace local_* calls to _get_fields() (the internal API). Any thoughts?

RE removing is_reverse_object.
I have just being doing an evaluation on this, and the answer is: yes, we can remove is_reverse_object but only with one additional flag: this flag is called “auto_created”. “auto_created" basically means that the field is created dynamically and is not defined by the user. This flag is far more generic than "is_reverse_object" and I think it can benefit both externally and internally.
Update: "auto_created" already exists, we need to find another, better, name.

buildbot, test this please.

@freakboy3742 nice! so it looks like is_reverse_object has been removed from the code base! This has been possible by using the already existing auto_created flag.

buildbot, test this please.

buildbot, test this please.

Should Field.auto_created should be documented in "Attributes for fields"?

@timgraham RE  Field.auto_created:
There already exists a documentation for auto_created, I think it would be beneficial to move it, or at least to link it there. What do you think is the most appropriate solution?

merged in fb48eb05816b1ac87d58696cdfe48be18c901f16


Data Visualisation with Olympics and Manipulation (but with JQ, SQL)

this one's for you @natefoo . also, spoilers, includes the hints of a wip SQL version.

oh nice! I was thinking of doing another olymics tuto but for visualisation too

Nice! Would be good for viz too, yeah. I'm thinking of making this a 'series' in the data science topic and covering: jq, bash, R (tidyverse), python, etc but of course depends on my time a bit.

@shiltemann requested #4210 and fixing a table in sql


Fix handling of namespaces in the node tree

Fixes the addition and removal of nodes.
Before

After

Please consider backporting it

@nlamprian What all distros you're hoping to have this in?

I think we should always try to backport to all supported distros, so Humble and Iron if I am correct.

@quarkytale any news?


photoflare: 1.6.11 -> 1.6.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/PhotoFlare/photoflare/releases.
meta.description for photoflare is: A cross-platform image editor with a powerful features and a very friendly graphical user interface
meta.homepage for photoflare is: https://photoflare.io
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.12 with grep in /nix/store/vw6qmq7fr88fz7mv7bd1y0nd3vdn9g4q-photoflare-1.6.12
found 1.6.12 in filename of file in /nix/store/vw6qmq7fr88fz7mv7bd1y0nd3vdn9g4q-photoflare-1.6.12

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
photoflare

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vw6qmq7fr88fz7mv7bd1y0nd3vdn9g4q-photoflare-1.6.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A photoflare https://github.com/r-ryantm/nixpkgs/archive/042d45c00d7c6b1c294fee0842dc4ef77b687f5f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vw6qmq7fr88fz7mv7bd1y0nd3vdn9g4q-photoflare-1.6.12
ls -la /nix/store/vw6qmq7fr88fz7mv7bd1y0nd3vdn9g4q-photoflare-1.6.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

photoflare

Maintainer pings
cc @omgbebebe for testing.

@ofborg eval


NPE in TypeHashVisitor when use null in union-type

Description:
NPE occurs in TypeHashVisitor when the compiled source contains a function type with a parameter of union-type that defined as follows
public type TestType string|int?[]|null;

public function doThis(TestType res) {

}

Steps to reproduce:

Include the above code into the ballerina project. Build it and push it to the local repository
Create a ballerina file and try using the doThis function by passing it to a function call. (see the example below)

import org/testType;

public function main() {
    func1(testType:doThis);
}

function func1(function (testType:TestType resp) callback) {
}

Run

Affected Versions:
Ballerina 2201.0.0 (Swan Lake) Snapshot build 1, stage-swan-lake branch
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/34578


How to get a token?

The README in this repo is seemingly out of date, as the webhook URL format is now https://hooks.slack.com/services/xxxx/xxxx/xxxx
So how do I get an integration token now?

the readme could do with restructuring, but follow this:
https://github.com/jenkinsci/slack-plugin#bot-user-mode

Is there no way. to use webhooks anymore?

there's an advanced option and you can use it, it's an undocumented feature

@timja and.... can you share that information please?

in the configure page click advanced in the slack doc

It still wants some credentials?
And, not being funny, but the info in the advanced section for the configuration isn't that helpful.
Can you please explain how to set up this pluign to use webhooks?

@paul-uz the feature is undocumented. I would suggest you follow the well documented path 😅

@paul-uz I was facing the same issue and I came up with the below solution:
Given a webhook like this https://hooks.slack.com/services/xxxx/yyyy/zzzz:

On "Manage Jenkins > Credentials" I created a "Secret text" credential using zzzz as "Secret". I set the ID to slack-webhook.
On "Manage Jenkins > Configure System" on the Slack section I chose the "Credential" created at step one slack-webhook and set the "Override url" to https://hooks.slack.com/services/xxxx/yyyy (without the /zzzz part of the URL).

In order to come up with the above solution, I had to add some extra logging and I could see in the logs that the Override url and the Secret text part were being URL joined. This issue helped me to understand how to add extra logging in Jenkins: https://github.com/jenkinsci/slack-plugin/issues/728
I don't guarantee that this might work for you but you could give it a go.


Use advanced-issue-labeler action for issue labeling

Description
Update Issue-text.yml to be more secure and use more suitable action.
Type of change
Instead of actions-ecosystem/action-add-labels action I added redhat-plumbers-in-action/advanced-issue-labeler action that is more suitable for use with issue forms. It provides so useful helpers to label issues based input provided via issue form.
Also please have a look at: https://github.com/stefanbuck/github-issue-parser/issues/24 - echo '${{ steps.issue-parser.outputs.jsonString }}' is not "safe" to use. There for I removed run echo stuff. Json will be still visible since it is passed as argument to redhat-plumbers-in-action/advanced-issue-labeler action.

[x] New feature (non-breaking change which adds functionality)

Note I added Other Browser option to block list, so if user will chose this option no label will be set. Do you prefere original behavior?

recheck

If you would like to try out advanced-issue-labeler action, you can use this template repository: @redhat-plumbers-in-action/issue-forms-automation

@andrewstech can you please look into this


help with converting 6D SAMPL to CHAMP input

Hi, I'm taking the output of a motion diffusion model (24 SMPL joints; 6D coordinate system and converting it to the a champ motion input.
I am taking two steps

dropping the the first point and inputting it as global orientation
converting from 6D to rotation matrices. (gram schmidt process)

However, some conversion is wrong, and the angles look wrong. Does anyone have any suggestions?
This is the screenshot of the incorrect conversion:

This is what what it should look like:

Hi @jitsm , we have released our Blender scripts for SMPL smooth here. You can also run it as a script inside Blender windows step by step to visualize the result. Hope it helps👋


Material DatePicker doesn't show

The Datepicker on 0.5.8-pre. 194 does not show up.
Steps to Reproduce
class SomeScreen extends StatefulWidget {

  @override
  State<StatefulWidget> createState() {
      return new SomeScreenState();
  }
}

class SomeScreenState extends State<SomeScreen> {
  DateTime selectedDate = DateTime.now();

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      body: Container(
        child: RaisedButton(
          child: Text("Select Date"),
          onPressed: () => _selectDate(context)
        ),
      )
    );
  }

   Future<Null> _selectDate(BuildContext context) async {
    final DateTime picked = await showDatePicker(
      context: context,
      initialDate: selectedDate,
      firstDate: DateTime.now(),
      lastDate: DateTime.now().add(Duration(days: 30))
    );

    if (picked != null && picked != selectedDate) {
      selectedDate = picked;
    }
  }

}

Logs
No Errors in the Debug Console
Flutter Doctor
Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, v0.5.8-pre.194, on Microsoft Windows [Version 10.0.17134.165], locale en-CA)
[√] Android toolchain - develop for Android devices (Android SDK 28.0.0)
[√] Android Studio (version 3.1)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code, 64-bit edition (version 1.25.1)
[√] Connected devices (1 available)

• No issues found!

Does this mean the same code worked in earlier Flutter versions?

I am not sure in what version it broke, but it was working in the beta version.
The Picker still works, but the date picker is broken as far as I can tell.
Should this be marked as regression?

After a few rebuilds it started working. I am really confused why it wasn't working before. My code did not change. Either way, I will close this issue for now and monitor it. Will re-open if it occurs again or if I find a concrete way of reproducing it.

I have just ran in the same issue, date picker does not show up if it was called in a separate method, note how it works on the RaisedButton and does not work on the FloatingActionButton:

import 'dart:async';

import 'package:flutter/material.dart';

void main() => runApp( DatePickerTask());

class DatePickerTask extends StatelessWidget {

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        floatingActionButton: Theme(
          data: Theme.of(context).copyWith(
            primaryColor: Colors.amber,
          ),
          child:  Builder(
            builder: (c) => FloatingActionButton(
                child:  Icon(Icons.date_range),
                onPressed: () => _handleDatePicker(c)),
          ),
        ),
        appBar: AppBar(title: Text('Date Picker Example')),
        body: Center(
            child: Builder(
          builder: (con) => RaisedButton(
                textColor: Theme.of(context).accentTextTheme.display1.color,
                color: Theme.of(context).primaryColor,
                child: Text('Choose a starting date'),
                onPressed: () => showDatePicker(
                      context: con,
                      initialDate:  DateTime.now(),
                      firstDate:
                           DateTime.now().subtract( Duration(days: 30)),
                      lastDate:  DateTime.now().add( Duration(days: 30)),
                    ),
              ),
        )),
      ),
    );
  }

  Future<Null> _handleDatePicker(BuildContext floatContext) async {
    final dateResult = await showDatePicker(
        context: floatContext,
        firstDate: DateTime.now(),
        initialDate: DateTime.now().subtract(Duration(days: 30)),
        lastDate: DateTime.now().add(Duration(days: 60)));

    //prints the chosen date from the picker
    print(dateResult);

  }
}

output of flutter doctor -v:
[√] Flutter (Channel master, v0.5.9-pre.17, on Microsoft Windows [Version 10.0.17134.165], locale en-US)    • Flutter version 0.5.9-pre.17 at D:\Development\Flutter\fluttersdk\flutter    • Framework revision 5d8771d18d (12 hours ago), 2018-08-10 21:18:10 -0700
    • Engine revision e54bc4ea18
    • Dart version 2.0.0-dev.69.5.flutter-eab492385c

[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at D:\Development\androidsdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = D:\Development\androidsdk
    • Java binary at: D:\Development\Android\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.0)
    • Android Studio at D:\Development\Android
    • Flutter plugin version 22.2.1
    • Dart plugin version 171.4424
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2017.1)
    • IntelliJ at D:\Installed\IntelliJ IDEA 2017.1.5
    • Flutter plugin version 23.2.1
    • Dart plugin version 171.4694.29

[√] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API
27) (emulator)

• No issues found!

One difference that I can see between the raised button and the FAB is that with the Raised button you are calling the datepicker without an await. However, in your FAB you're calling the datepicker with an await inside the method.
From I understanding, the await implementation is the correct one. I am currently calling the datepicker with an await from inside another method and it is working (on master, 0.5.8-pre.286).
Try running clean, and rebuild then try again. If the problem persists I suggest you open a new issue as it is unlikely the team will see this closed issue.

Without a closer look I'd guess it is related to BuildContext. Perhaps the context available in FAB doesn't have a reference to the router.
Is there an error output in the console if you click the FAB?

@shadyaziza In _handleDatePicker
        initialDate: DateTime.now(),
        firstDate: DateTime.now().subtract(Duration(days: 30)),

initialDate and firstDate are mixed up which causes
E/flutter (20987): [ERROR:flutter/shell/common/shell.cc(181)] Dart Error: Unhandled exception:
E/flutter (20987): 'package:flutter/src/material/date_picker.dart': Failed assertion: line 1082 pos 10: '!initialDate.isBefore(firstDate)': initialDate must be on or after firstDate

@codigopher not sure what your point is, but the order of named parameters doesn't matter.
You might want to store the value of DateTime.now() and pass this variable for firstDate and initialDate

this code will solve your problem
   ```

context: context,
initialDate: DateTime.now().add(Duration(hours: 1)),
firstDate: DateTime.now(),
lastDate: DateTime(2101));

This is best Solution 👇🏼
final DateTime picked = await showDatePicker(
      context: context,
      initialDate: DateTime.now(),
      firstDate: DateTime.now().subtract(Duration(days: 1)),
      lastDate: DateTime.now().add( Duration(days: 1095)),
    );

DateTime picked;
if (toDate != null) {
picked = await showDatePicker(
context: context,
firstDate: new DateTime(fromDate.year, fromDate.month, fromDate.day),
initialDate: toDate,
lastDate: new DateTime(DateTime.now().year + 2),
);
} else {
picked = await showDatePicker(
context: context,
initialDate: DateTime.now(),
firstDate: new DateTime(fromDate.year, fromDate.month, fromDate.day),
lastDate: new DateTime(DateTime.now().year + 2),
);
}

after flutter updates this is a common problem, you can solve it but using asyn

Hello Everyone,
I wanted to know if the showdatepicker method can be reused from other classes. can somebody help me out with this?

How To Use Date Picker in Flutter


Updated pyyaml to version 6

Describe changes
Just changed pyyaml to be at least version 6, as I experienced issue with other packages which were using higher versions.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[x] If my change requires a change to docs, I have updated the documentation accordingly.
[x] If I have added an integration, I have updated the integrations table and the corresponding website section.
[] I have added tests to cover my changes. (Cannot really create a test for this )

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X ] Other (add details above)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Hadi Salameh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Manual occurrence point editing/deleting/adding

In GeoCAT the user can add, remove and edit points in the map viewer. If analysis is on, any edits to points should be reflected instantaneously on the map.

Solved in Mapping branch


fix for issue OPTIONS parsing issue

I think this should fix the issue reported in 112. The issue with the OPTIONS request is that there is a carriage return on the last line, which makes the loop here go one more time with empty data, which causes r to be undefined and the whole function returns undefined.
You'll notice I added the OPTIONS header as a plain variable in the test, but we will need to do is add the extra carriage return OPTIONS to the sip-message-examples repo to get the test passing correctly for the current setup. I already made a pull request for that https://github.com/davehorton/sip-message-examples/pull/3. Once that is merged, I can update the test so it uses the message from sip-message-examples.

you can update to<EMAIL_ADDRESS>now


💡[FEATURE]: option Pricing Using Genetic Algorithm

Is your feature request related to a problem? Please describe.
Design and optimize options trading strategies using machine learning and genetic algorithms.
Describe the solution you'd like
Steps
Data Collection
Collect historical option prices and underlying asset prices.
Initialize Population
Create an initial population of random parameters for the option pricing model.
Fitness Function
Define a fitness function to minimize the difference between the model prices and market prices.
Selection, Crossover, Mutation
Implement genetic algorithm operations.
Iterate and Evaluate
Iterate through generations to find the best-fit parameters.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

pls assign it me I want to work on it @Akshat111111 I'm Gssoc'24 contributor


[SPARK-36835][FOLLOWUP][BUILD][TEST-HADOOP2.7] Fix maven issue for Hadoop 2.7 profile after enabling dependency reduced pom

What changes were proposed in this pull request?

Fix an issue where Maven may stuck in an infinite loop when building Spark, for Hadoop 2.7 profile.
Why are the changes needed?

After re-enabling createDependencyReducedPom for maven-shade-plugin, Spark build stopped working for Hadoop 2.7 profile and will stuck in an infinitely loop, likely due to a Maven shade plugin bug similar to https://issues.apache.org/jira/browse/MSHADE-148. This seems to be caused by the fact that, under hadoop-2.7 profile, variable hadoop-client-runtime.artifact and hadoop-client-api.artifactare both hadoop-client which triggers the issue.
As a workaround, this changes hadoop-client-runtime.artifact to be hadoop-yarn-api when using hadoop-2.7. Since hadoop-yarn-api is a dependency of hadoop-client, this essentially moves the former to the same level as the latter. It should have no effect as both are dependencies of Spark.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

N/A

let me test both Hadoop profiles here

Test build #143608 has started for PR 34100 at commit 4456fc1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48120/

It looks reasonable to me. I believe we need @gengliangwang 's sign-off with Hadoop 2.7 testing.

retest this please

Thank you for the fix @sunchao

Test build #143611 has started for PR 34100 at commit 4456fc1.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48120/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48120/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48123/

Test build #143608 has finished for PR 34100 at commit 4456fc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48123/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143608/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48123/

Thanks @JoshRosen ! it's interesting that this error is not reported in the CI jobs. So the enforcer rule is only executed in install phase but not package?
Let me double verify locally and add the changes to all the necessary modules.

Test build #143611 has finished for PR 34100 at commit 4456fc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143611/

updated the PR to use different name for hadoop-client-runtime.artifact, which is probably a simpler approach. Verified locally with:
build/mvn clean install -DskipTests -Phadoop-2.7 -Phive-2.3 -Pmesos -Phive-thriftserver -Pyarn -Pspark-ganglia-lgpl -Pkinesis-asl -Pkubernetes -Phadoop-cloud -Phive

and the build is successful.

Test build #143615 has started for PR 34100 at commit d73562e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48127/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48127/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48127/

Test build #143615 has finished for PR 34100 at commit d73562e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143615/

Test build #143618 has started for PR 34100 at commit 0c358b3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48130/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48130/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48130/

Test build #143618 has finished for PR 34100 at commit 0c358b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143618/

I tried build/mvn -DskipTests -Phadoop-2.7 clean install and it works now. Shall we merge this and start RC5?

Is there any change in your previous opinion, @JoshRosen ?

https://github.com/apache/spark/pull/34100#discussion_r715946127

branch-3.2 also seems to need this fix

Merging to master/3.2. Thanks all!

Thank you!

@sunchao Unfortunately, the build without Hadoop failed after this one.
$ ./build/mvn clean package -DskipTests -B -Pmesos -Pyarn -Pkubernetes -Psparkr -Pscala-2.12 -Phadoop-provided

[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala:30: object MiniYARNCluster is not a member of package org.apache.hadoop.yarn.server
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala:61: not found: type MiniYARNCluster
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala:104: not found: type MiniYARNCluster
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:37: object resourcemanager is not a member of package org.apache.hadoop.yarn.server
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:38: object resourcemanager is not a member of package org.apache.hadoop.yarn.server
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:39: object resourcemanager is not a member of package org.apache.hadoop.yarn.server
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:40: object resourcemanager is not a member of package org.apache.hadoop.yarn.server
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:250: not found: type RMContext
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:252: not found: type RMApp
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:261: not found: type RMApplicationHistoryWriter
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:263: not found: type SystemMetricsPublisher
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:267: not found: type RMAppManager
[ERROR] [Error] /opt/spark-rm/output/spark-3.2.0-bin-without-hadoop/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:272: not found: type ClientRMService

Could you fix it?

@gengliangwang will take a look - is it caused by this PR?

oooh I see, it is because only one active profile is allowed, and thus when hadoop-provided is activated, hadoop-3.2 will not be, and the Hadoop dependencies will not be found.

I think adding -Phadoop-3.2 should make it work but let me think how to fix this.
build/mvn clean package -DskipTests -B -Pmesos -Pyarn -Pkubernetes -Psparkr -Pscala-2.12 -Phadoop-provided -Phadoop-3.2

@sunchao Yes it is caused by this one. Again, thanks for looking into this.

There are two ways to fix this:

move spark.yarn.isHadoopProvided to Spark parent pom, so that -Phadoop-3.2 can become the default profile in the YARN module's pom. I don't see any side effect on this - ideally this property can be more general such as spark.isHadoopProvided.
move hadoop-client-runtime.artifact out of the -Phadoop-3.2 profile. It should fix the build issue but someone that's using -Phadoop-provided to test Hadoop 3.2 could still fail.

I'm inclined to option 1) here but let me know if you have any thoughts on this.

@sunchao yes let's try option 1


[FEA]: Replacing md issue templates with yml forms

Replaces the existing markdown issue templates with more feature-rich yml forms. Replaces #396

@gpucibot merge


Cut body to 1024 chars. Fix #775

Not sure this is the solution as we might miss something in the log or perhaps I'm missing something.

It's only cutting down the body information, which is entire files or entire pages worth of html. It doesn't cut out any of the debugging info.

cool, thanks.

Coverage increased (+0.01%) when pulling 79ad0599df99091f7fa2b68ddcd4fd66be3adf97 on squirrelo:fix-huge-log-problem into dec4c04780d09773469d82a84511620844e80874 on biocore:master.

I think this is fine :+1:

:+1:

I realize this is now closed, but often the first part and the last part of an error are the most useful, but this approach removes all of the tail end of the message

This only cuts the body of the file that caused the error, not the error log.

ah, okay, thanks


QG 4 checks (Release 3.2)

QG checks
Please keep this issue open until QG 4 is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues, this issue here is for the Overview of the Checks!
Please keep this issue open until QG 4 is concluded!
Product Owner: @jjeroch
Dev SPOC: @evegufy
Helm Chart Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB)
App Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB)
QG5 Approval: yes/no
Check of Tractus-X Release Guidelines
This QG 4 Check is depending on the mandatory information from our current Release Guidelines.
TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[x] TRG 1.02 appropriate INSTALL.md
[x] TRG 1.03 appropriate CHANGELOG.md

TRG 2 Git

[ ] TRG 2.01 default branch is named main

[ ] TRG 2.03 repository structure

Checks within TRG 2.03

[ ] TRG 2.03 /docs directory contains detailed product related documentation for the Tractus-X product
[ ] TRG 2.03 /charts directory contains the Helm chart for the Tractus-X product IF available
[ ] TRG 2.03 AUTHORS.md file (optional) (TRG 2.03)
[ ] TRG 2.03 CODE_OF_CONDUCT.md file (TRG 2.03)
[ ] TRG 2.03 CONTRIBUTING.md file (TRG 2.03)
[ ] TRG 2.03 DEPENDENCIES file(s) with up to date content (Dash tool generated) (TRG 2.03)
[ ] TRG 2.03 LICENSE file (TRG 2.03)
[ ] TRG 2.03 NOTICE.md file (TRG 2.03)
[ ] TRG 2.03 SECURITY.md file (TRG 2.03)

[ ] TRG 2.04 Leading product repository

Checks within TRG 2.04

[ ] TRG 2.04 repository name must be productname without prefix or suffix
[x] TRG 2.04 should contain the release
[x] TRG 2.04 references/urls to the product's other repositories
[x] TRG 2.04 might contain product helm chart(s)
[x] TRG 2.04 README.md: contains the urls for the underlying applications

[x] TRG 2.05 .tractusx metafile in a proper format

TRG 3 Kubernetes

[x] TRG 3.02 PersistentVolume and PersistentVolumeClaim is used when needed

TRG 4 Container

[ ] TRG 4.01 semantic versioning and tagging

[ ] TRG 4.02 top level README.md file, that contains information about the used base image

[ ] TRG 4.03 Image has USER command and Non Root Container

Checks within TRG 4.03

[ ] TRG 4.03 deployment.yaml has runAsUser and allowPrivilegeEscalation: false properly set

[ ] TRG 4.05 released image must be place DockerHub as mandatory container registry; remove GHCR references

[ ] TRG 4.06 Notice File for DockerHub has all necessary information

Checks within TRG 4.06

[ ] TRG 4.06 Link to the source of your base image (Container registry and GitHub if available)
[ ] TRG 4.06 Link to your product image on DockerHub
[ ] TRG 4.06 Link to your repository on GitHub
[ ] TRG 4.06 Direct link to the Dockerfile used to build your image
[ ] TRG 4.06 Link to LICENCE file in your repo as Project License (make clear, that this is the PROJECT licence, not an image license

TRG 5 Helm

[ ] TRG 5.01 Helm chart must be released

Checks within TRG 5.01

[ ] TRG 5.01 appropriate semantic versioning for version and appVersion has to be used in Chart.yaml
[ ] TRG 5.01 must not contain any environment specific values-xyz.yaml
[ ] TRG 5.01 values.yaml file must contain proper default values/placeholders
[ ] TRG 5.01 No hostname provided for ingress
[ ] TRG 5.01 Ingress is disabled
[ ] TRG 5.01 No references to any secret engine service (e.g.: Hashicorp Vault)
[ ] TRG 5.01 Dependencies should be prefixed with the nameOverride and/or fullnameOverride properties
[ ] TRG 5.01 Image tag is set to the Chart.yaml appVersion property
[ ] TRG 5.01 must be deployable to any environment without overwriting default values with a simple helm install command
[ ] TRG 5.01 dependencies have to be declared in Chart.yaml NOT requirements.yml

[ ] TRG 5.02 Helm chart location in /charts directory and correct structure

Checks within TRG 5.02

[ ] TRG 5.02 each file must contain the Apache 2.0 Licence
[ ] TRG 5.02 latest tag is not used in helm chart be default

charts/
    chartNameA/
      Chart.yaml
      ...
    chartNameB/
      Chart.yaml
      ...
AUTHORS.md
DEPENDENCIES.md
LICENCE
README.md

[ ] TRG 5.04 CPU and memory limits and requests are properly set

[ ] TRG 5.06 application must be configurable through the Helm chart

[ ] TRG 5.07 dependencies are present in the Chart.yaml they are properly configured

[ ] TRG 5.08 a product has a single deployable helm chart that contains all components

Checks within TRG 5.08

[ ] TRG 5.08 name of the Chart should be just the product-name without prefix or suffix
[ ] TRG 5.08 values file should contain all available variables (even from subcharts) with default values and comments about what they do
[ ] TRG 5.08 helm install command should successfully install the chart to any supported Kubernetes version cluster (without overwriting default values)
[ ] TRG 5.08 helm test runs without errors

[ ] TRG 5.09 Helm Test running properly

Checks within TRG 5.09

[ ] TRG 5.09 A GitHub action exist which builds or uses the helm chart which gets released
[ ] TRG 5.09 The GitHub action can be triggered manually through Github WebUI manually running a workflow
[ ] TRG 5.09 Helm test verifies that the application is up and running

[ ] TRG 5.10 Products need to support 3 versions at a time

Checks within TRG 5.10

[ ] TRG 5.10 latest (K8s version 1.25)
[ ] TRG 5.10 latest - 1 (K8s version 1.24)
[ ] TRG 5.10 latest - 2  (K8s version 1.23)

[ ] TRG 5.11 Upgradeability PRERELEASE

Checks within TRG 5.11

[ ] TRG 5.11 Based on the Helm test workflow, you must provide a GitHub action which takes the latest released helm chart, does an installation of it and then execute the upgrade to the current / new version.

TRG 6 Released Helm Chart

[ ] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[ ] TRG 7.01 Legal Documentation

[ ] TRG 7.02 License and copyright header

[ ] TRG 7.03 IP checks for project content

[ ] TRG 7.04 IP checks for 3rd party content

Checks within TRG 7.04

[ ] TRG 7.04 DEPENDENCIES file is up-to-date and reflects the current use of the 3rd party content
[ ] TRG 7.04 all libraries listed there should have the status "approved"
[ ] TRG 7.04 no libraries with status "rejected"
[ ] TRG 7.04 for libraries with status "restricted", the according IP issues must be present (issue number in the source column)

[ ] TRG 7.05 Legal information for distributions

[ ] TRG 7.06 Legal information for end user content

[ ] TRG 7.07 Legal notice for documentation

Hints
Information Sharing

Hi @evegufy , @jjeroch
This is an issue related to QG4, can you please provide details/confirm on below:
Product Owner:
Dev SPOC:
Helm Chart Version:
App Version:
Confirm on all repositories which belong Portal product:

https://github.com/eclipse-tractusx/portal-cd
https://github.com/eclipse-tractusx/portal-frontend
https://github.com/eclipse-tractusx/portal-frontend-registration
https://github.com/eclipse-tractusx/portal-assets
https://github.com/eclipse-tractusx/portal-backend

Hi @tomaszbarwicki
sorry for the delay, I was off due to a public holiday.
Here the information;
Product Owner: @jjeroch
Dev SPOC: @evegufy
Helm Chart Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB)
App Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB)
The following repositories belong Portal product:

https://github.com/eclipse-tractusx/portal-cd
https://github.com/eclipse-tractusx/portal-frontend
https://github.com/eclipse-tractusx/portal-frontend-registration
https://github.com/eclipse-tractusx/portal-assets
https://github.com/eclipse-tractusx/portal-backend
https://github.com/eclipse-tractusx/portal-shared-components (see https://github.com/eclipse-tractusx/portal-cd/pull/68)

Hi @evegufy,
Thanks for the list of repositories, the NOTICE.md lists also https://github.com/eclipse-tractusx/portal-iam but doesn't list https://github.com/eclipse-tractusx/portal-shared-components. Is that any recent change and the file will be amended?

Hi @evegufy,
Thanks for the list of repositories, the NOTICE.md lists also https://github.com/eclipse-tractusx/portal-iam but doesn't list https://github.com/eclipse-tractusx/portal-shared-components. Is that any recent change and the file will be amended?

I'll add portal-shared-components in the notice file, I forgot that in this repo, thanks for pointing that out!
Regarding portal-iam: the keycloak instances are a separate product from the portal and used by (almost) all components of the data space but maintained by the us, the portal-team, and therefore the repository is listed in the notice file.
As mentioned yesterday, it makes sense to open such a QG checks issue also in portal-iam.

Hi @tomaszbarwicki
sorry for the delay, I was off due to a public holiday.
Here the information;
Product Owner: @jjeroch Dev SPOC: @evegufy Helm Chart Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB) App Version: 1.6.0-RC7 (available by the end of this week, August 18, 2023, EOB)
The following repositories belong Portal product:

https://github.com/eclipse-tractusx/portal-cd
https://github.com/eclipse-tractusx/portal-frontend
https://github.com/eclipse-tractusx/portal-frontend-registration
https://github.com/eclipse-tractusx/portal-assets
https://github.com/eclipse-tractusx/portal-backend
https://github.com/eclipse-tractusx/portal-shared-components (see chore(shared-components): update tx metadata #68)

As discussed last week regarding version, could be please change to the following in the descrption of the issue:
Helm Chart Version: 1.6.0-RC8 (available by August 22, 2023, EOB)
App Version: 1.6.0-RC8 (available by August 22, 2023, EOB)

Checks completed, issue closed.


Functions for finding SD/variance of voxels

Assumes .nii file is given as absolute path.

Tests for new functions should be added before this can be approved and merged.


Switch Icons for JXTabbedPane

Hello @vincenzopalazzo
I would show the ">" icon when it is opened (expanded) and the down arrow when it is closed (collapsed). Currently it is the other way round.

Hello @Reap00r,  I'm preparing a pull request, the bugs were resolved.
The pull request it will be published on Wednesday evening
Stay tuned :P

Hello @vincenzopalazzo, thanks for the update. I will be out of town from today until sunday. So unfortunately I can't test your changes right away when they are released.

Hi @Reap00r,
No problem, If are present the new bugs, we will fix it :)

Finally got my laptop screen fixed, thank you for fixing this issue @vincenzopalazzo!! I'll close this issue if everythings working

@atarw I'm happy for your screen.
I saw that you closed all the problems of my fixes, and I assume that everything worked, right?
I wanted to ask you if you'd like me to help you develop the look and feel and maybe work together on developing new skills :)


Algolia travis variables

Coverage decreased (-0.002%) to 26.155% when pulling c8467439c912b1847e982e9955085e81030013df on Jskobos:algolia-travis-variables into 0f5d4c860b818182e4ccecec478cde8e2a7605c7 on linode:develop.

Coverage decreased (-0.002%) to 26.155% when pulling c8467439c912b1847e982e9955085e81030013df on Jskobos:algolia-travis-variables into 0f5d4c860b818182e4ccecec478cde8e2a7605c7 on linode:develop.


feat: api

close #45

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

106 of 113 (93.81%)  changed or added relevant lines in 18 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.4%) to 93.243%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/nostr/nostr.module.ts
0
2
0.0%

src/main.ts
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main.ts
1
0.0%

src/nostr/nostr.module.ts
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>3:
0.4%

Covered Lines:
594

Relevant Lines:
653

💛  - Coveralls


Enhancement : Not compatible with spark session object

Cannot use APIs with Spark Session object.
Hence to use it i have to forcibly create SQL context object

Thank you @poojankothari-gep . Unfortunately, this connector is not actively maintained. I recommend you evaluate and hopefully adopt the newer connector which is active. Closing this issue.


Fix sequential parallel

Thanks for looking into this. I've pushed version 0.8.1 to crates.io.

Thanks!


Use the maven release plugin

To keep the current version in the repo be latestrelease+1-SNAPSHOT

I see you started using the release plugin 🙂

Indeed #151


Help list isn't updated upon enabling/disabling a plugin.

http://i.imgur.com/qrJv7eJ.png?1

Thanks, this should now be fixed in the OTA fix: https://github.com/DeathCradle/Open-Terraria-API/commit/56eced541880d73c122c0c8a3fd347317377aa40


[main-dl to main] New components added, SQL Operation updated

New Components

ContextMenu Added
StatusBar Added
Shortcuts Added
Updated Column Defs
Before

After

Added Multiple Row Selection

SQL Operations

Obtain schema with "Describe" SQL instead of from information_schema.

GitHub-Page

Launched Demo in github pages

#12 #25


HTTP Basic Auth not working with pixi

It seems to me that HTTP basic auth is not working in pixi.
Unfortunately, I don't have access to an artifactory / basic auth instance outside of corporate infrastructure so I could only reproduce this issue inside of corporate infrastructure.
Following setup:
{
  "my.quetz.instance":
    {"CondaToken":"***"},
  "repo.prefix.dev":
    {"BearerToken":"***"},
  "my.artifactory":
    {"BasicHTTP":
      {"username":"my-user","password":"***"}
    }
}

These commands work:
rattler-build build -r recipe/recipe.yaml -c https://my.artifactory/artifactory/conda-forge
pixi search -c https://my.quetz.instance/get/custom-channel private-package
pixi search -c https://repo.prefix.dev/setup-pixi-test private-package

This command doesn't work:
pixi search -c https://my.artifactory/artifactory/conda-forge polarify

So rattler-build is able to use the basic auth credentials from .rattler/credentials.json but pixi is not capable of doing so.
The credentials.json is read from pixi since otherwise the other pixi search commands would fail.
pixi search -c https://my.artifactory/artifactory/conda-forge polarify fails with the following error message:
Having an end-to-end test for HTTP basic auth, quetz api keys and repo.prefix.dev would probably help with debugging this issue.

Fixed by #994


Setting MTU on Server/Client

How does one set MTU, possibly different on the Server/Listener and the Client?
I'm tunneling inside existing protocol of different types, and the MTU for each is different, applies to both Server and Client. On the client, sending can be as low as just 150 bytes, and on the receiving it can be about 300 bytes.
Is this a possible setup for quick-go?
Thanks.

Currently, we're sending packets with a maximum size of 1350 bytes (set in protocol.MaxPacketSize). This is the value that Chrome is using at the moment.
The QUIC protocol, as it is being standardized by the IETF, will not support MTUs smaller than 1280 bytes (see https://quicwg.github.io/base-drafts/draft-ietf-quic-transport.html#rfc.section.9).
A peer can send larger packets when it does Path MTU Discovery (we have an issue for that, #94), but there won't be a way to go below that vlaue.

Alright, thanks. That clarifies things.


Fix 404 (Not Found): skull image

Just a quick link adjustment! I went through the other links in the README to make sure that they are all working as well; other links are working. I'd be grateful for any feedback if linking raw.githubusercontent is not the right way to go about this.
Description
Fix for autostereogram skull image.
Proposed Changes
Changed the https://github.com/DominiqueMakowski/Pyllusion/docs/img/depthmask.png skull link (results in 404: Not Found) to https://raw.githubusercontent.com/RealityBending/Pyllusion/master/docs/img/depthmask.png.

nice catch, cheers!

Cool project!


docs(MenuExampleSecondaryPointing): Missing Menu Labels

Missing content in Menu.Item

This is intentional.  The "Start Cased" name prop will be used for the child content if there is not one.  See the example at http://react.semantic-ui.com/collections/menu#menu.


Rule request: no overly large if statements

This code has a lot of stuff in the if statement:
function doSomething() {
    if (condition) {
        doSomethingA();
        doSomethingB();
        doSomethingC();
        doSomethingD();
        doSomethingE();
        doSomethingF();
        doSomethingG();
        return;
    }

    doSomethingZ();
}

It could be useful for a rule that requests if statements don't get unnecessarily large, since this unnecessary amount of nesting could be easily reduced by inverting the if.
function doSomething() {
    if (!condition) {
        doSomethingZ();
        return;
    }

    doSomethingA();
    doSomethingB();
    doSomethingC();
    doSomethingD();
    doSomethingE();
    doSomethingF();
    doSomethingG();
}

The backing logic could be that if an if statement takes up more than (configuration: half, # of lines, combo of both) a function, it should be flagged?

I feel like you'll end up with a lot of suppressed warnings in the code. Is length of the branch really how you decide what goes inside the if statement and what goes outside?

I can't think of a better way. Perhaps allowing a ratio and/or minimum statement count as a rule config?

💀 It's time! 💀
TSLint is being deprecated; therefore, it and tslint-microsoft-contrib are no longer accepting pull requests for major new changes or features. See #4534. 😱
If you'd like to see this change implemented, you have two choices:

Recommended: Check if this is available in ESLint + typescript-eslint ✅
Not Recommended: Fork TSLint or tslint-microsoft-contrib locally 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!


ConnectWallet v3 updated Playground

📝 Changed routes:

…hboard/wallets/connect

(view full size)

Commit 74f9713fd7cc5cc9f444c24f19282063ba65fd4f (https://thirdweb-c5p5y6nm8.thirdweb-preview.com).


Example improvements to PolygonsToLines tool

If you are not keen in having many XML files in the root folder (I have asked the ESRI community about that here) then you need to make the tools smarter by validating the inputs. It is very easy to provide data that WBT cannot process, for example a file geodatabase featureclass. I don't think its good enough to say well it does say that in the manual.  The tools need to proactively ensure the correct inputs are going to WBT especially if you don't want to document them via the item description approach. It quickly becomes irritating and frustrating if one tries to input data that WBT throws an error at and there is no guidance other than delving into an online manual.
So I have worked up some sample code for the PolygonsToLines tool that could easily be embedding into your automation script that checks for 2 properties, it has a coordinate system and its a shapefile. This code is in the updateMessages function and by setting error warning you 1) stop the tool from trying to execute with bad data for WBT and 2) provide feed back as to why its wrong so the user can correct it, no need to go hunting in a manual.
This defensive approach makes the tools way more robust and the user experience much slicker!
For other tools, I've already blown up WBT by providing it rasters that were ESRI grids and rasters that did not have a coordinate system.  So at the minimum the tools need to be testing for data type and presence of coordinate systems.
Clearly tools that take numeric values need to know if negative numbers are acceptable.

@Hornbydd Excellent suggestions! And thank you for taking the time to raise the question in the ESRI community. I will improve the automation script to include the updateMessages() function for validating input raster/vector based on your sample code.

I've spotted an issue with allowing the tools to access layers directly from within the map. Tools that edit  the schema of an input dataset, e.g. AddPointCoordinatesToTable don't refresh the layer so you don't see the new fields. A brute force approach is to remove the layer from TOC then add the layer back and then you see them, but that clearly is not acceptable for usability. I will looking into how to solve this. Being to access FeatureLayers as well as the data source makes the tools so much more accessible and they behave just like the standard system geoprocessing tools.

Actually the schema refresh is not specifically related to a layer, if you access the data source via the browse button, same issue occurs, in that if the dataset is a layer in ArcMap it does not know about the new fields...hmmm


Stage-3 code about ppo loss may have something wrong

In applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/main.py, critic_loss and actor_loss are strangely added to each other. I am so confused about it.

@LuciusMos thanks a lot! It won't affect the training but indeed affect the training log. Would you like to create a PR to resolve the issue. Thank you so much.

@LuciusMos  which dataset u used.
How is labelling done for step2 & 3 ?


Conditional types of callables distribute union types in an unhelpful way.

TypeScript Version:  3.0.0-dev.20180605
Search Terms: union of callables, union of functions, conditional types
Code
type MyResponse =
	| string
	| number

type SENTINEL = { __varargs_hack_sentinel: '__varargs_hack_sentinel' };

type Callback<Param=SENTINEL> =
    Param extends SENTINEL ? () => void
    : (param: Param) => void

const testFunction = (onClose: Callback<MyResponse>) => {
    return onClose('test')  // <-- ERROR OCCURS HERE
}

Expected behavior:
onClose should have type (arg: string | number) => void.  It should be possible to call it with both string and number parameters.
Actual behavior:
onClose has type (arg: string) => void | (arg: number) => void.  It is not possible to call it with any parameters, as union types are not callable.
I'm using conditional types to create a sort of generic function vararg-y thing.  Essentially, the Callback type can be used to describe a no-args function (Callback), or a one-arg function (Callback<ArgType>), and can be extended to as many arguments as you like.  I've done this because I'm writing React code, and a lot of prop definitions will include callbacks.  By defining something similar to the Callback type here, I save myself a bit of faff every time my prop definition includes one or more callback-like properties.  By using conditional types, I don't need to worry about creating a separate CallbackN type for each number of arguments that I want to pass to the callback.
My aim in this bit of code is to create a callback that can accept a parameter in a union of types - here, either a string or a number.  However, because conditional types are distributive, the two types are distributed separately, and the type is transformed into a union of two different callbacks.  This type then cannot be called, because unions of callables are not themselves callable.
Ideally for me, when the conditional type expression distributes union types, it should be cleverer about handling unions in callables (either not distributing them, or "inverting" the distribution to (a: A) => void & (b: B) => void); or unions of callables with compatible signatures should be callable; or there would be better documentation of this issue.
Playground Link: here

The underlying issue here is that union signatures are not callable.. that is tracked by https://github.com/Microsoft/TypeScript/issues/7294
For the details on why it is a union, Callback is a distributive conditional types on Param. i.e. if the type is instantiated with a union type, the result is the union of applying the conditional types on every constituent. you can find more about distributive conditional types at: https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#distributive-conditional-types.
To prevent the type from distributing you could define it as:
type Callback<Param=SENTINEL> =
    [Param] extends [SENTINEL] ? () => void
    : (param: Param) => void

Thanks, that's a very neat way of preventing the type from distributing!  That fixes my particular problem, and given you've already got #7294, I'll just close this.


Fix FileUtils not found error

Fixes https://github.com/blacktm/ruby-wasm/issues/1

Thanks @gumb0!


Stabilized the cypress test for fix CI-nightly runs

Motivation and context

The test issue_1568_cuboid_dump_ annotation.js failed sometimes in CI-nightly run. The video of test show that the file does not download in the default 5 seconds, I increased the timeout.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Tests

Improved test reliability by adding a mechanism to intercept and wait for specific network requests during test execution.

Please, explain the changes

Please, explain the changes
I changed the solution here, the video shows that the file does not download in the default 5 seconds, I increased the timeout.


authentication upon loading(no login button)

First of all, thanks for this great library. I have a SPA that requires the users to authenticate upon loading without having to click on the login button. Is there a way to achieve this? My code pretty much looks similar to the example shared.
index.tsx

const oidcConfig = {
authority: "",
client_id: "",
redirect_uri: ""
}
ReactDOM.render(
<React.StrictMode>
<AuthProvider {...oidcConfig}>

</React.StrictMode>,
document.getElementById('root')
);
Thanks for your help.

With auth.isAuthenticated you can check if already authenticated. With auth.signinRedirect() you can sign-in. A combination with React.useEffect might do the trick for you...


Cloning a project results in an invitation email

 Issue by kbrandwijk
Thursday Aug 17, 2017 at 08:15 GMT
Originally opened as https://github.com/graphcool/api-bugs/issues/234

What is the current behavior?
When I clone a project, I receive an invitation email for the cloned project.
What is the expected behavior?
I don't get one.

 Comment by marktani
Thursday Aug 17, 2017 at 08:21 GMT

Thanks, we'll look into this one.

That's really happen 🙁


Information leaks through padding

I was examining on-device state left by LFS and was surprised to find some pieces of data that were not supposed to be on the FS at all. Turns out, these were pieces of heap that hitched a ride to the persistent storage as padding for writes.
This is not supposed to happen and it's a pretty serious issue. I was able to put a quick bandaid on by adding memset right after the buffer mallocs, so at least non-filesystem data doesn't make it through.
However, more careful approach is needed to ensure that there is no cross-contamination within the filesystem - e.g. parts of file_a data do not end up in padding for file_b or some directory structure and thus live long after file_a is gone.

Does this look good to you? https://github.com/ARMmbed/littlefs/pull/69

Actually, I think it may be flawed to assume removing file_a completely erases the data from the disk. As a copy-on-write filesystem, many copies of your data may end up on different places on the disk and it would be prohibitively expensive to erase these.
Can you think of another reason cross-contamination within the filesystem would be a problem? I'm having a hard time coming up with a situation that would actually be an issue.
Agree that leaking data from malloc is a problem.

As a copy-on-write filesystem, many copies of your data may end up on different places on the disk and it would be prohibitively expensive to erase these.

yeah, i understand that. however, that should be ok as long as these blocks are not reported as used. then scrubbing free space after deleting files that are supposed to be wiped would be ok, which is what i intend to do. it will only be done on factory reset, so it's ok if it takes some time. however, if the information ends up in a used block, e.g. as part of padding for a live file, then this won't work.
so, LFS should ensure that used blocks are not cross-contaminated and scrubbing free blocks should be left to the user if they wish.

Ah interesting. How does that work with the metadata stored in directory blocks? Right now this is only the file location and size, but with inline files this could be the entire file.

well, that'd be a problem then. basically, i would like to have a way of scrubbing the fs, even if it's expensive. perhaps, introduce a "gc" process for this purpose that would relocate and scrub entries that contain such garbage? as a utility function, perhaps, so if you don't use it, it doesn't increase code size.

as an example, SPIFFS has a SPIFFS_gc function that will erase a bunch of unused blocks.
currently, to scrub the FS i just repeatedly invoke it until it makes no further progress.

Hmm, I'll have to think about that. It would definitely be expensive and stress inducing for the block device.
Another option is we could add an optional LFS_O_NOINLINE flag that would let you force sensitive files into their own blocks.

this has the disadvantage that we'd have to know upfront which files are
sensitive which is not necessarily the case...
On Fri, Jul 6, 2018, 22:08 Christopher Haster<EMAIL_ADDRESS>wrote:

Hmm, I'll have to think about that. It would definitely be expensive and
stress inducing for the block device.
Another option is we could add an optional LFS_O_NOINLINE flag that would
let you force sensitive files into their own blocks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ARMmbed/littlefs/issues/67#issuecomment-403121934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgbayYsGPB-NBLg_OQX_9iVo0IEX6PJks5uD7XEgaJpZM4VDiQ_
.

--
Deomid "rojer" Ryabkov,
Software Engineer
Cesanta Software Ltd.

Sorry didn't mean to close this. I think there's still an interesting discussion to be had about a potential scrub function.


if test inside switch default clause gives compiler error

An if test inside the default clause of a switch statement causes a compiler error:
Code:

Red/System []
print ["started" lf]

dm: 12
dd: 31

switch dm [
    2 [
      if dd > 29 [print [8 lf]]
    ]
    4 6 9 11 [
      if dd > 30 [print [8 lf]]
    ]
    default [
      if dd > 31 [print [0 lf]]
    ]
]

print [0 lf]

print ["finished" lf]

Compiler output:
Compiling /Users/peter/Code/Red-System/test.reds ...
Script: "Red/System IA-32 code emitter" (none)
*** Compiler Internal Error: Script Error : size-of? expected type argument of type: word block
*** Where: get-width
*** Near:  [emitter/size-of? value: case [
type [operand]
'else [
value: first compiler/get-type operand
either value = 'any-pointer! ['pointer!] [value]
]
]
value
]

This code compiles and runs correctly:

Red/System []
print ["started" lf]

dm: 12
dd: 31

switch dm [
    2 [
      if dd > 29 [print [8 lf]]
    ]
    4 6 9 11 [
      if dd > 30 [print [8 lf]]
    ]
    default [
      print [0 lf]
    ]
]

print [0 lf]

print ["finished" lf]

This code compiles and runs fine here. I cannot reproduce the issue. Are you sure you have pulled the #198 bug fix? (It is in master branch only for now).

Sorry I must have run my test with the float-partial branch checked out. As you say it is fine with the master branch.
On 16 Jan 2012, at 18:02, Nenad Rakocevic wrote:

This code compiles and runs fine here. I cannot reproduce the issue. Are you sure you have pulled the #198 bug fix? (It is in master branch only for now).

Reply to this email directly or view it on GitHub:
https://github.com/dockimbel/Red/issues/199#issuecomment-3508486


Cannot install hapi-swagger using yarn

Context
yarn add hapi-swagger
yarn add v0.24.5
info No lockfile found.
[1/4] Resolving packages...
error Couldn't find manifest in "git+https://github.com/glennjones/hapi-swagger.git".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
What result did you get?
see above
What did you expect ?
no error msg, hapi-swagger module installed (just like with npm)
note:
in the same project (i.e. using same pacakge.json)
npm i
works
yarn
does not and issues above message...

Interesting I am using yarn to install hapi-swagger. It works.

Hi @miqui, I think I know you...
As I know the context of your question, I know that the version of hapi-swagger that you are trying to install indirectly (child dependency) is based on a direct reference PR #396 submitted to this repo as we don't manage to get any feedback from @glennjones or whoever is now maintaining this repo.
The problem between npm and yarn is that they don't support the same syntax to refer to a PR:

npm: glennjones/hapi-swagger#pull/396/head
yarn: glennjones/hapi-swagger#396/head (no "pull")

Note also that as this isn't published to npm, the PR will be fetched using git.
This is what must be causing your problem.


askForPermissions always shows permission popup

I have added appintro library in my app and asked for some permission from user but the problem is it always shows permission popup no metter user granter permission or not.
I should check if the asked permissions are granted already or not.
I am showing all the tutorial in the intro screens so user can visit it whenever he wants every time user visits i gets permission popup.

This should be closed since it ignored the template. BUT...let me solve your issue real quick: AppIntro does not query whether the permissions have been asked for before because it's an intro...of course they haven't been asked for before.
And if you've given your users a way to open the intro again, this presents them with another opportunity to choose which permissions they want and don't want, without having to reset your app.


Feat/crypto hash

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.05%. Comparing base (4f5bab3) to head (981c47d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   96.87%   90.05%   -6.83%
==========================================
  Files           1        5       +4
  Lines          32     5228    +5196
  Branches        9       41      +32
==========================================
+ Hits           31     4708    +4677
- Misses          1      520     +519

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement a new data table widget

The built-in widget is ok, but its data structures are super inefficient, which limits us to about 10k rows. It shouldn't be too bad(?) to fork the current widget and represent each row as a tuple of its data.

Arrow would be the perfect backend for this -- should be able to just slice() the arrow table to the rows in the scroll region


CLI requires explicitly passing in "true" to switch options

This broke somewhere between 0.6.3 and 0.7.2. If you use the --mozjpeg option for example, squoosh will crash:
file:///home/asaveau/IdeaProjects/personal-website/.build/node_modules/@squoosh/cli/src/index.js:173
        encParam.toLowerCase() === 'auto' ? 'auto' : JSON5.parse(encParam);
                 ^

TypeError: encParam.toLowerCase is not a function
    at Command.processFiles (file:///home/asaveau/IdeaProjects/personal-website/.build/node_modules/@squoosh/cli/src/index.js:173:18)

So $ squoosh-cli ... --mozjpeg fails, but $ squoosh-cli ... --mozjpeg true works. It looks to me like the default case is being parsed as an actual boolean whereas the explicit case returns a string.

Same with --webp option.
cli/src/index.js#L176
☝ encParam is true (boolean) and not a string. 💥🙂

Same. To be clear for onlookers who are searching based on the TypeError: encParam.toLowerCase is not a function error,
squoosh-cli --oxipng --quant 50 blah.png
will fail, and:
squoosh-cli --oxipng true --quant 50 blah.png
will succeed.

Unfortunately, due to a few people leaving the team, and staffing issues resulting from the current economic climate (ugh), the CLI and libsquoosh packages are no longer actively maintained. I know that sucks, but there simply isn't the time & people to work on this. If anyone from the community wants to fork it, you have my blessing. The squoosh.app web app will continue to be supported and improved.


Package request: Add which to stdenv

Project description

Metadata

homepage URL:
source URL:
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

Add a :+1: reaction to issues you find important.

Oops, opened too early


View all projects based on recent activity

As a user looking for projects to join, or a staff member making sure that projects are active, it would be good to see projects sorted by recent activity. Activities could include:

Check-ins at hack nights
Written updates
Code check-ins for github-hosted projects (see #73)

Basically, we can be generous for what counts as an 'update' but still rank by date of most recent activity.

Only view projects in active stages - 'Hibernating' projects are still showing up in the list


Luck critical modifier too powerful

It has been brought up luck modifies crits to too high a number, removing crits from luck removes the stat mostly from gameplay, so I propose a middle ground.
Let luck modifier be determined by a *2 instead of *4, let it still modify crits, (10% at lvl 10) then crits are still affected negatively as well by dumping the stat,  but I also proposed we let it add to either reflex or initiative. If you build your character unlucky, they go first less in combat, on the contrary, a lucky person might go first more, but again this modifier would be a bonus of 10 at 10 luck, still under the soldier bonus. and could stack with the soldier bonus.

Initiative would make more sense from a mechanics point of view, but not from a logical one. In my opinion this idea should be tested, I believe it would add usefulness to a stat and make an area of the game more dynamic.

The branch was merged before the change could be made. @1sourcecontrol could you finish up this change and we'll merge it again?

Per our conversation, @bleehu, I propose that we close this issue. I think we should leave crits the way they are, for now. I see a lot less potential for abuse now that nanite-regen is being redone and automatic weapons can't crit.

I think we should make a cap that says you can't increase crit range beyond a roll of 80+ even in the case of temporary luck, etc. I think Wildlovelies could still abuse crits.

Why don't we have lovelies try?
My thoughts:
There are two ways, that I know of, that could possibly abuse crits.

Criticals cause bonus damage.
Even if a player got 100% extra-crit on every roll, which is +20 damage constantly, he can't use it during automatic fire. It matters for beating armor DR, so they would be better at dealing with high armor targets; however, the virtual double or triple damage automatic fire can get compared to +20-60% damage, that could be attained by single-fire 100%-crit, makes criticals far more insignificant, imo, for higher HP targets or targets with less than 100% armor coverage.
Critical's interactions with other abilities and feats.
Side note, I haven't studied every ability in the game, mostly engineer and medic, so I can't say for sure (plus my class is Human and I make mistakes lol) but here are all the interactions I know of: Double Tap, First Shot Counts, and Nanite Regen. (I left out Never Tell Me the Odds because it just adds to crit chance).

Double Tap, double damage on all hits would be a major concern, but the player's apples to apples DPS would still be much lower than an automatic weapon. Fortunately, double damage only occurs in extra crit range, which can be maxed out somewhere around 25% chance (10% from LUCK mod + 5% base chance, 5% weapon skill trees, 5% other feat) with the current abilities and using a single fire carbine, I believe.
First Shot Counts: +20 damage every time you reload looks like a below average feat to take, to me (even if you had 100% chance of crit'ing). The only abuse I could see is a single shot break-barrel shotgun, always getting a crit. And frankly, since the shotgun gets far less DPS than a 30rnd mag automatic weapon, I think it nullifies the concern.
Nanite Regen: getting balanced. Since you can't crit with an automatic weapon, half the battle is already won (maybe the whole battle). Make it so nanite regen steals from the pool of the target, and then you have a hard cap on max regeneration from a single target. Another possibility is to limit it to a certain number of procs per turn. There are a lot of options for dealing with this feat.
Final thought , as I'm sure you all know, what may be a key decider in determining whether having a high crit range is balanced is to compare what the player has to give up. Giving up 2-3 feats and 50 skill points (weapon skill trees), and maxing LUCK to get maximum crit chance is a high price.

I agree with what @1sourcecontrol has brought up. Recent changes (especially the automatic fire negating crits) have drastically lowered the possibility for abuse of the crit system.
I do believe that he has also brought to light that First shot counts (and Last shot counts) could use some buffing, as they add 20 damage on 10% of reloads. I'm going to create a separate issue for that so we can debate it there and not fill this thread up.

I still think the *4 multiplier is a bit high, but let's see how it plays out in the next versions. Closing it out =)

Thanks Mike, I'm sure we'll find out soon enough.


Detected master does not get added or synchronized

We are running into an issue where a ROS master will get detected by another master but does not get added (or synchronized).
 Its topics are never pulled in and it doesn't shows up in the /master_discovery/list_masters output.
I believe I know what the issue is but this is just a theory based on code analysis.
When a remote ROS master is detected and a new DiscoveredMaster object is created, it will run DiscoveredMaster::__retrieve_masterinfo() which in turns will execute the monitor URI XML RPC call masterContacts, which in turn calls MasterMonitor::getMasterContacts().  If this happens to be run after the master monitor has started but before it has actually set it's state (self.__master_state), the master URI, name, discoverer name and monitor URI will be returned with a timestamp of 0.  As a result, the code that sets the DiscoveredMaster mastername and masteruri isn't executed and they remain None (master_discovery.py:341-370).  It also doesn't cause the "Added" message to be logged which explains why we see "Detected" but not "Added".  Furthermore, since neither the mastername nor the masteruri is set, it is never included in the /master_discovery/list_masters output (master_discovery.py:1045), and when a heartbeat is added for that remote ROS master it never generates a state change (master_discovery.py:174), which also means it never gets synchronized.  The end result is the remote ROS master is invisible.
Unfortunately we haven't been running logging at DEBUG level, so I don't have the output of that XML RPC call to confirm this theory.  I will look at changing that but in the meantime, would like to get your feedback on whether this seems like the likely culprit.
If it is then I believe the solution is very simple: retry the __retrieve_master_info() function when the timestamp is 0 on the assumption that on the next go, the remote master monitor will have completed it's state update.

Hi,
thank you for detailed description of the possible problem. I added some warnings and also reconnects. I hope it solves the problem or shows why the master was not added after MasterMonitor::getMasterContacts()
regards

Awesome - I can confirm that fixed the issue. Than you!
FYI I was able to repro by hacking master_discovery.py files on one of my robots so that the check ROS timer started after the heartbeat i.e. master_discovery.py:579 was changed to "self._timer_ros_changes = threading.Timer(2.0, self.checkROSMaster_loop)".

Thank you for testing of this fix and also for the hint with self._timer_ros_changes = threading.Timer(2.0, self.checkROSMaster_loop)!
I let this issue still open because it seems to be a problem on start of the master_discovery. It should not report a zero timestamp or send heartbeat while no local MasterState is available.

No problem. Would it be possible to get a tag that includes this fix so we can get that into our build?
Admittedly my repro is a bit fake.  It may be possible that the UDP heartbeat is arriving at a ROS master A from an earlier execution of ROS master B, rather than it's sending a heartbeat before the state is ready.  In the rare times I have managed to catch this situation, it is usually couple with a network outage.  I could potentially see a situation where ROS master B is running at 1:00:00, sends a heartbeat, at 1:00:01 terminates due to some other issue, then starts up again at 1:00:02.  If the heartbeat at 1:00:01 happens to reach ROS master A at 1:00:2 and ROS master B XML RPC server is up but checkState hasn't run yet, it might be the case this is what is triggering the query before MasterState is ready.  But that's theory.  If I happen to find evidence of this happening again and can gather more information I will let you know.

Nevermind what I said above! I realize now that what you're saying is my repro shouldn't have worked.

ok, I added a new tag 0.6.0-1

So I figured out what is triggering the heartbeat when no master state is available.
In our setup the HEARTBEAT_HZ is 0.02 and as a result, there are 3 requests sent on startup.  Those requests do not rely on master state so they are being sent, which in turn are resulting in the detection on the other end.

Can we also get a version on the multimaster_fkie-release?  I realize this is a minor but this bug is proving to be a blocker for us when we hit it.

thank you for the debugging! I added a new fix; the requests are now sent and replied only if own state is available. In my tests it works and I hope in yours, too.
I am also created a new version 0.6.1


DO NOT MERGE: Investigate dind startup failure in CI

Signed-off-by: Alexandre Beslic<EMAIL_ADDRESS>

Failure due to cgroup mounting removal in docker/docker#18023
/cc @aluzzardi @vieux

Back to normal.
Pushed the updated swarm-env-test to the Hub.
We still have issues with tests being inconsistent on Jenkins while it's running fine locally though...
/cc @docker/swarm-maintainers

LGTM.


Consider adding a base forc tx command for constructing arbitrary transactions from the CLI

Currently forc-client provides:

forc deploy for constructing Create transactions (for deploying contracts).
forc run for constructing Script transactions (for executing scripts).

Conceptually these cover all main types of transactions, however both are currently very limited compared to constructing Create or Script transactions using one of the SDKs directly.
I wonder if it might be useful to take a step back, and think about how we can provide a nice CLI experience for constructing arbitrary transactions in general, perhaps via a forc tx command.
Constructing transactions (forc tx)
Here is a very rough example of how an invocation might look:
# Create a `Create` type transaction.
forc tx create \
    --bytecode ./out/debug/my-contract.bin \
    --storage-slots ./out/debug/my-contract-storage-slots.json \
    --salt ... \
    --gas-price 1 \
    --gas-limit 10 \
    --maturity 1 \
    --inputs "./inputs.json" \
    --outputs "./outputs.json" \
    --witness ... \
    --witness ...

I'm glossing over significant details like inputs.json and outputs.json here, but the general idea is to provide a more comprehensive mapping to whats possible in the spec (and in turn the Rust SDK).
We could limit the role of forc tx to actually constructing the transaction. By default, it could pretty print the result in JSON to stdout, or accept a flag for writing it to a file.
Arguments like --bytecode and --storage-slots could be omitted and inferred if running the command within a forc project, as there are standard locations within the project where we can fetch these values (i.e. ./out/<profile>/...).
Submitting transactions (forc submit)
We could then use another command like forc submit my-transaction.json to submit the full transaction to a network, allowing to specify a custom URL and other network-related args.
forc deploy, forc run
Commands like forc deploy and forc run would then become thin, higher-level wrappers around a combination of forc tx create/forc tx script and forc submit.
Why care about exposing this from a CLI?
Benefits of having a purely CLI approach include:

Just about every OS comes with Bash out of the box.
No need for Sway devs to install or learn potentially unfamiliar languages (like Rust or TS).
Easier to write custom deployment/execution scripts without the need to build/compile them.
Be more Unix friendly.

I'm really liking the direction this is going!
If possible, it would be really cool if the final transaction could (in addition to being printed to stdout/written to file) be output as the corresponding raw bytecode. This would allow us to do things like eth_sendRawTransaction and "keyless transactions"("Nick's method")

Closed via #3582, though improvements around signing and bug fixes (i.e. #3886) to come.


Add damn slides

It took me a while, but I wanted to include a link to the preprint, data set and code.

@jonas-schulze Thanks for sharing your slides. Changes look good. I'll merge right away.


FR: Random Quote

Would love to have on the "At Glance" part a function for Random Quote as for motivation:

appears only if no meeting, music, playing, alarm in place
ONLY for short quotes
one sample location: https://wisdomquotes.com/short-quotes/ ;they are brilliant

If no such fetch feature from web / database:
Alternative1: ability for user defined text file (read random lines)
Alternative2: utilization of "Custom notes" WITH ability to a multi-line (CR)

Comments, feedback?

I searched for a few short-quotes API services but I didn't find out anyone with documentation.
I've updated the custom notes UI to show two lines in the widget.

Excellent alternate, thx!


NO-ISSUE: Add Enrollment config endpoint

After creating and approving CSR, you can use this new command to generate an enrollment config
Run flightctl enrollmentconfig --private-key myeckey.pem --csr mycsr to get the enrollment-config file

Thank you @rawagner
I think this may need to grow a /{name} field so that the user can get it for a specific device - like we have for the CSRs - since this will basically be a "last step" on top of the CSR steps. So it would match https://github.com/flightctl/flightctl/blob/main/api/v1alpha1/openapi.yaml#L1468 . Though this may imply some shared namespace  or naming convention between this API and the CSR API.

Also would change NO-ISSUE to MGMT-18170

This version is working as expected for me with the CLI command. :rocket:

thanks @lkatalin . I've updated the code as you suggested. The EnrollmentConfig endpoint now expects a name of approved CSR.


Force Server to Follow Loadout Rules

Players are able to modify their loadout and turn pro_screen slot into other mods, also allowing them to equip threat_scope without losing a mod.
This pull request add a check on server-side to prevent players from doing these

is there any reason you do this when setting the mod rather than in loadout verification functions?

is there any reason you do this when setting the mod rather than in loadout verification functions?

the function GivePilotLoadout() uses loadout.primaryMods for giving weapons instead of loadout.primaryMod1, loadout.primaryMod2, loadout.primaryMod3, and it's defined in UpdateDerivedPilotLoadoutData() for the function Loadouts_TryGivePilotLoadout()(used by loadouts_mp.gnut), UpdateDerivedPilotLoadoutData()is called beforeGivePilotLoadout(), but other loadout functions like SetActivePilotLoadout()is called after it, which means add the check intoSetActivePilotLoadout()won't take any effect, so I chose to add check inUpdateDerivedPilotLoadoutData()`

will it be better to move the checks to ClientCommandCallback_SetPersistentLoadoutValue()?

it should probably be failing these checks when you try to set an invalid mod, i think https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L390

interestingly enough it does seem like respawn considered the potential issues with threat scope, they just never gave them a particularly good check https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L416

it should probably be failing these checks when you try to set an invalid mod, i think
https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L390

yes, the invalid mods won't appear on weapons, but the extra mods will

it should probably be failing these checks when you try to set an invalid mod, i think
https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L390

yes, the invalid mods won't appear on weapons, but the extra mods will

sorry, what i mean is that you should change this pr to fail validation in that function when extra mods are added

it should probably be failing these checks when you try to set an invalid mod, i think
https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L390

yes, the invalid mods won't appear on weapons, but the extra mods will

sorry, what i mean is that you should change this pr to fail validation in that function when extra mods are added

oh I get it, thanks!

interestingly enough it does seem like respawn considered the potential issues with threat scope, they just never gave them a particularly good check
https://github.com/R2Northstar/NorthstarMods/blob/9c6b08e7c56e34e93e8abae85cb94dd870c60b04/Northstar.CustomServers/mod/scripts/vscripts/sh_loadouts.nut#L416

I also added a check about this in FailsLoadoutValidationCheck(), works fine now


Autocomplete: snippet inserted text is wrong when insertText contains $ and there are placeholders

monaco-editor version: 0.20.0
Browser: Chrome
OS: Windows
Playground code that reproduces the issue:
function getSuggestions(range) {
    return [
        {
            label: 'newDateTime',
            kind: monaco.languages.CompletionItemKind.Function,
            insertText: '$aaa.newDateTime()',
            insertTextRules: monaco.languages.CompletionItemInsertTextRule.insertText,
            range: range
        },
        {
            label: 'power',
            kind: monaco.languages.CompletionItemKind.Function,
            insertText: "$aaa.power(${1:n}, ${2:m})",
            insertTextRules: monaco.languages.CompletionItemInsertTextRule.InsertAsSnippet,
            range: range
        }
    ];
}

monaco.languages.register({id: "custom-language"});
monaco.languages.registerCompletionItemProvider('custom-language', {
    provideCompletionItems: function(model, position) {
        return {
            suggestions: getSuggestions(null)
        };
    }
});

monaco.editor.create(document.getElementById("container"), {
    language: "custom-language"
});

Writing newDateTime and choosing the correspondent completion item, it works fine. The text "$aaa.newDateTime()" is added to the model
However, writing power and choose the correspondent completion item, it fails. Fails. The text added is .power(n, m) and it should be $aaa.power(n,m)

I tried to escape the first $ char inside the insertTextstring but it did not work.

Using a double slash, I am able to escaping the $ char in order to avoid being consider a variable name.
insertText: "\\$aaa.power(${1:n}, ${2:m})",

Considering the workaround above, I am not sure if I should close this issue or not...


g++

g++ -Wno-multichar -Isrc -std=c++14 -fno-rtti -o LZCBDecompressor.o -c src/LZCBDecompressor.cpp
src/LZCBDecompressor.cpp:141:59: error: conflicting declaration 'constexpr const std::array<unsigned int, FrequencyTree<T>::levels()> FrequencyTree<T>::_levelOffsets'
  141 | constexpr std::array<uint32_t,FrequencyTree<T>::levels()> FrequencyTree<T>::_levelOffsets;
      |                                                           ^~~~~~~~~~~~~~~~
src/LZCBDecompressor.cpp:134:49: note: previous declaration as 'constexpr const std::array<unsigned int, FrequencyTree<T>::levels()> FrequencyTree<T>::_levelOffsets'
  134 |  static constexpr std::array<uint32_t,levels()> _levelOffsets=makeArray(makeLevelOffsetSequence(std::make_integer_sequence<uint32_t,levels()>{}));
      |                                                 ^~~~~~~~~~~~~
src/LZCBDecompressor.cpp:144:59: error: conflicting declaration 'constexpr const std::array<unsigned int, FrequencyTree<T>::levels()> FrequencyTree<T>::_levelSizes'
  144 | constexpr std::array<uint32_t,FrequencyTree<T>::levels()> FrequencyTree<T>::_levelSizes;
      |                                                           ^~~~~~~~~~~~~~~~
src/LZCBDecompressor.cpp:135:49: note: previous declaration as 'constexpr const std::array<unsigned int, FrequencyTree<T>::levels()> FrequencyTree<T>::_levelSizes'
  135 |  static constexpr std::array<uint32_t,levels()> _levelSizes=makeArray(makeLevelSizeSequence(std::make_integer_sequence<uint32_t,levels()>{}));
      |                                                 ^~~~~~~~~~~

BTW https://stackoverflow.com/questions/45918292/gcc-equivalent-of-wshorten-64-to-32

This seems to be non-standard behavior from gcc, which enables c++17 static member behavior even when c++14 standard is defined from command line.
I added #ifdef to the code, it should now compile cleanly if you change the standard to c++17 from the Makefile. Also changed the narrowing flag


Add user groups to requirements page

Describe who the target user groups are and how each user group is expected to use the software differently.

3236e5879cd83b53a3b86b36154d6c41c78280a4