Fix exit-time destructor warning

This snippet from immer/immer/detail/hamts/champ.hpp causes an exit-time destructor warning from clang:
    static const champ& empty()
    {
        static const champ empty_{
            node_t::make_inner_n(0),
            0,
        };
        return empty_;
    }

I'll create a pull request to suggest addressing it similarly to what's discussed in this stack-overflow question.

Thanks! While the warning is mostly incouous (it may have an effect though if empty maps or sets are created in the global destruction sequence) it makes sense to fix it.
Hmmm. Beware of creating an unnecessary intermediate node for the champ. I think this is simplest and most performant:
    static champ empty()
    {
        static const auto node = [] {
            auto n = node_t::make_inner_n(0);
            n->inc();
            return n;
        }();
        return {node, 0};
    }

You may encounter the need for a similar fix in rbtree.hpp and rrbtree.hpp.

What I'd propose would follow that question I mentioned previously (the only change is in the 3rd line):
    static const champ& empty()
    {
        static champ& empty_ = *new champ{
            node_t::make_inner_n(0),
            0,
        };
        return empty_;
    }

So nothing would change as for the creation of the object except for using the heap to avoid the destructor call. What do you think?
Thanks for the pointer to the other files; I'll check them too.

@chuim yes, looking at the link you sent, I assumed that was gonna be your suggestion :)
However, my solution uses the fact that we are now ok with never deallocating the object to slightly improve the performance of this function. The previous solution (and your suggested) touches the refcount of the node_t created there whenever empty() is used to create a new map or set, because the champ object is copied in the caller. With my suggestion we allow RVO to happen and not touch the refcount of the node_t at all :slightly_smiling_face:
Anyway, too many details... I'd suggest just using my snippet. I could maybe even try it myself if you wanna, or I'll just wait for your PR so you can make sure it really fixes your warning and it does not break anything on your end.

I tried using your code verbatim on champ.hpp but that causes tests failures. I also tried mimicking it for rbtree.hpp and rrbtree.hpp and got more failures. As I'm not an actual user of immer code so I'm just trying to "pattern match" what you did and am lost on how to fix these errors.
As you offered to try addressing this yourself, I'd be happy to let you take over. Alternatively I could send a PR with the sub-optimal heap-based implementation.

Hi @chuim, addressed in #163

For the record, your suggested solution sadly did not work either, since it caused problems when libgc is used (because the allocated object is unknown to libgc so it would deallocate the nodes...). I ended up doing something different. Give it a try and let me know if it works for you!

Thanks so much for doing this! Once issue #162 gets resolved I'll integrate both changes back into our internal codebase and report back.

FYI all looks good after the integration. Thanks a lot for your assistance addressing these somewhat nit-picky issues.


Coin Change Problem

📚 Documentation
Adding article on Coin Change Problem
Have you read the Contributing Guidelines on Pull Requests?
Yes

A PR for this issue already exists.


Preload web fonts

Details
This PR does a few things:

Adds the webpack-font-preload-plugin plugin to preload fonts. This helps to ensure that fonts are loaded faster and prevent FOUT, but causes fonts to be downloaded with higher priority than the app JS bundle, which can delay the initial render time of the main app. It was minor but noticeable, especially on slower connections. To optimize this trade-off for our mainline use cases, only the .woff2 font are preloaded. .woff fonts are not, which means that the preloading optimization won't benefit internet explorer the same as other browsers.
Updates the splash screen JS to ensure that we wait until fonts are loaded before rendering the main app, which should completely eliminate FOUT and make it so that we don't need to think about web-safe fallback fonts that look similar to our brand font. Note that there are some independent problems with the splash screen itself.
Also removed deprecated file-loader webpack plugin (no longer needed since webpack 5 introduced asset modules)

Fixed Issues
$ https://github.com/Expensify/App/issues/12267
Tests (web)

With the network console open, load the site. You should see that the .woff2 fonts are downloaded right away.

Verify that once the site loads (takes about 60 seconds), you do not see a flash of unstyled text (FOUT)
For good measure, go to https://localhost:8080/statements/202301 and verify that the statements modal is visible in the RHP (this is testing that react-native-webview still works despite no longer using deprecated file-loader.

Tests (native)
Just regression tests – all the existing fonts should continue to display as expected.

[x] Verify that no errors appear in the JS console

Offline tests
None.
QA Steps
Same as Tests. Marked as Internal QA because the testing steps are just a bit more technical than usual. Note that the splash screen also isn't working on production due to another unrelated issue.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/47436092/216790121-2deec90d-f621-444a-ad15-107c3c318211.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://user-images.githubusercontent.com/47436092/216790572-62b35c94-3782-479b-9ad8-e1d824d2ce93.mov

iOS
iOS unaffected by this web-only change.

Android
Android unaffected by this web-only change.

Note to self and reviewers:
Preloading both the woff and woff2 files was noticeably slower. woff2 works on all browsers except IE, so we just preload woff2. We could still end up seeing FOUT on IE with this PR. We could probably configure webpack to provide the url of the woff fonts to JS via ProvidePlugin, then in splash.js check if the browser is IE and load the woff fonts with JS and wait for that to finish before hiding the splash screen. Didn't bother for now because IE at EOL

We could still end up seeing FOUT on IE with this PR

I don't think we support IE. We are not even trying to workaround Firefox bugs so IE seems out.

I don't think we support IE. We are not even trying to workaround Firefox bugs so IE seems out.

100% agree, IE is officially EOL

After chatting with @Luke9389 I'm going to put this on HOLD for https://github.com/Expensify/App/pull/12656#pullrequestreview-1198239877

put myself down as a reviewer bc I have context

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Are we planning to do a follow-up issue to clean up the font family names too?

🚀 Deployed to staging by https://github.com/Luke9389 in version: 1.2.67-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@shawnborton yep that's still on my radar. Issue here.

This passed internal QA:

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.67-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Attribution imports not working with basic create-react-app usage

Versions
| => npm -v
10.5.0

| => node -v
v18.20.1

| => npm ls @honeycombio/opentelemetry-web
<EMAIL_ADDRESS>/.../.../.../repro-app
└──<EMAIL_ADDRESS>
| => npm ls @opentelemetry/auto-instrumentations-web
<EMAIL_ADDRESS>/.../.../.../repro-app
└──<EMAIL_ADDRESS>
Steps to reproduce

npx create-react-app repro-app --template typescript
cd repro-app
npm install @honeycombio/opentelemetry-web @opentelemetry/auto-instrumentations-web
Add code to src/index.tsx:

import { HoneycombWebSDK, WebVitalsInstrumentation } from '@honeycombio/opentelemetry-web';
import { getWebAutoInstrumentations } from '@opentelemetry/auto-instrumentations-web';

const sdk = new HoneycombWebSDK({
  apiKey: 'api-key-goes-here',
  serviceName: 'your-great-browser-application',
  instrumentations: [getWebAutoInstrumentations(), new WebVitalsInstrumentation()], // add automatic instrumentation
});
sdk.start();

npm start

Browser console error:
web-vitals-autoinstrumentation.js:134 Uncaught TypeError: (0 , attribution_1.onCLS) is not a function
    at WebVitalsInstrumentation.enable (web-vitals-autoinstrumentation.js:134:1)
    at enableInstrumentations (autoLoaderUtils.ts:75:1)
    at registerInstrumentations (autoLoader.ts:42:1)
    at HoneycombWebSDK.start (base-otel-sdk.js:75:1)
    at ./src/index.tsx (index.tsx:14:1)
    at options.factory (react refresh:6:1)
    at __webpack_require__ (bootstrap:22:1)
    at startup:7:1
    at startup:7:1

Additional context
tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react-jsx"
  },
  "include": [
    "src"
  ]
}

I am also seeing this error.
I even get it when I set instrumentations to an empty array

OK - for those who are struggling with this, you can put in a temporary workaround by adding this as an option to the SDK constructor:
webVitalsInstrumentationConfig: {
    vitalsToTrack: [],
  }

Thanks @ethangodt for opening this issue and @dancrumb for chiming in. Our team is going to take a look at this one!

The reason this is happening is that the web-vitals package has chosen a named export for web-vitals/attribution that leads to a file with the extension .cjs.
The webpack.config.js of Create React App treats that as a non-source file (i.e. the way it would an image or .css) because it is not configured to treat .cjs as source. As a result the require/import of web-vitals/attribution is transpiled to a download url path and not the real module.
I'm not sure that this project can do anything besides warn folks about Create React App.


Prevent hooks failures in newest cordova versions

Since 5.3.4 cordova won't contain ConfigParser and xml-helpers modules so hooks will became broken. For more details and repro steps see corresponding JIRA issue: https://issues.apache.org/jira/browse/CB-9834

LGTM, merging. Thanks.


Promise never ends

Hello.
I have a problem running simple-ldap-get in node environment.
It seems that once the client is created, it is never destroyed, causing node to hang forever.
Am I missing something ?
Thank you.

It seems possible to call ldap.client.client.destroy() in the final then()
But how to know when all the results have been piped in the Stream example ?


Update nodejs for build

We are moving away from the ancient tool versions, updating nodejs to a version we're still keeping on the new infrastructure,

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   73.44%   73.44%
=======================================
  Files          53       53
  Lines        3592     3592
  Branches      644      644
=======================================
  Hits         2638     2638
  Misses        954      954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcef717...de4ffff. Read the comment docs.


🐛 Consideration for non-unix paths

Use joinpath in includes for consideration for non-unix paths

@ronisbr, sorry for the delay—busy week.
You’re absolutely right—tested on a Windows machine, and the unix paths work.
I did some digging, and the reason for this is because I believe it uses abspath or normpath.
When include is called (whose method is in base/client.jl), Base._include is called (defined in base/loading.jl).  To get the path name, it calls Base._include_dependency (also in loading.jl), which calls abspath or normpath, both of which are defined in base/path.jl (here and here respectively), and both of which will correct the path separators.
Sorry about this!  All the best,
Jake.


[ustc] retry of job as TRANSIENT_CONFLICT

job retry:

am log:

job config:

task log

The diagnoistic is enough to debug.
For doc please check:
https://github.com/Microsoft/pai/blob/master/subprojects/frameworklauncher/yarn/doc/USERMANUAL.md#exitstatus-convention
https://github.com/Microsoft/pai/blob/master/subprojects/frameworklauncher/yarn/src/main/java/com/microsoft/frameworklauncher/common/model/ExitType.java

Append this info to this issue:
// A special TRANSIENT_NORMAL which indicate the exit due to resource conflict
// and cannot get required resource to run.
TRANSIENT_CONFLICT,

I see you specified gpuType fawda.
Have you set up the gpu types in your cluster?
Please check.
http://{LauncherAddr}/v1/LauncherRequest/ClusterConfiguration
And please check (and provide) the AM log to help debug why not enough resource.

i am not sure, this is ustc's cluster feedback. They just give us pai access acc

@yqwang-ms  from meeting's suggestions, it is better to give user more clear method to debug retry issues.
How about expose the comment like this expose at log? this will make user more clear to identify the root case and avoid to check the source code?
// A special TRANSIENT_NORMAL which indicate the exit due to resource conflict
// and cannot get required resource to run.

The comment is too general, and the diagnostic is already explian all I know:

ok


why \Facebook\WebDriver\Firefox\FirefoxProfile() does not support a file path construction?

in java or c# version selenium driver, they all support a profile path to construct a FirefoxProfile object.
but in php-webdriver, it does not support. I really need this feature.
could you tell me how to do this?
thanks!

Do you mean something like that?
zip -r profile 3rkomsuo.selenium
openssl base64 -in "profile.zip" -out "profile.zip.b64"

...and then in your code:
$session = $web_driver->session('firefox', array(
    'firefox_profile' => file_get_contents("profile.zip.b64")
));

(copied from #42)


fix(Codegen): Improvement to statement output.

Skip loop iterations where TS syntax would of been output.
Working towards https://github.com/oxc-project/oxc/issues/2038

Replaced by https://github.com/oxc-project/oxc/pull/2460


fix: Display "No max." If there is no max voting period

Summary

If a space doesn't have a max voting period, we don't display anything
This PR will make it similar to min voting period, where we show text

Before:

After

How to test

Go to your space, change settings to have no min and no max

I guess we could merge it, but I think there is bigger issue - if there is no max voting period proposal won't be active at all, it will end as soon as it starts - with this in mind it might actually be inaccurate to show No max. in this case - rather 0m will be more accurate.

Is there some way we could enforce max. Voting period to be greater than 10 mins or something? Don't think someone want to allow proposals that end immediately 😅

We can validate it there:
https://github.com/snapshot-labs/sx-monorepo/blob/06f238e71ab8cfb2ac35c5413f40b77b35028129/apps/ui/src/views/Space/Settings.vue#L126-L132

@ChaituVR do you want to proceed with this PR somehow?

do you want to proceed with this PR somehow?

Was waiting for https://github.com/snapshot-labs/sx-monorepo/pull/610
Will display 0m instead of "No max."

Any ideas on how much the minimum we can allow for maximum voting period? maybe 5 minutes?

5 minutes might be too little for Starknet where it takes quite a bit of time for transaction to process (and EVM as well, but for different reason -> IPFS resolve takes time on TheGraph).

Less says we wouldn't need a ristrict,
https://discord.com/channels/955773041898573854/1031838169282392144/1278302832025407611
maybe we can continue with displaying 0m for now?


Updated doc README Grafana dashboard section

Added context to doc/README.md grafana dashboard topic.

/cc @clyang82 @bjoydeep


Remove useless iptables rule

By default, traffic is handled by the iptables rule generated by calico.
And this rule blocks working NetworkPolicy when FELIX_CHAININSERTMODE is Append.

Hi @jungeonkim we put this rule there so packets can be forwarded properly. Can you give me a step by step setup or a script showing when this rule becomes a problem?

@ktsakalozos As I said in the original article, traffic is forwarded by the iptables rule that calico is created by default.
By default, packets are accepted or dropped by calico's rule before reaching this rule. So it's not a problem.
However, if  change FELIX_CHAININSERTMODE`` to Insert```` in order to apply the user-defined rule first, All packets are allowed by this rule before calico's rule is applied. So networkpolicy doesn't work properly.


Deprecated features used with Chef: 12.5.1

Deprecated features used!
  install_dir nil currently does not overwrite the value of install_dir. This will change in Chef 13, and the value will be set to nil instead. Please change your code to explicitly accept nil using "property :install_dir, [MyType, nil]", or stop setting this value to nil. at 1 location:
    - /var/cache/chef/cookbooks/redisio/recipes/install.rb:35:in `block in from_file'
  Using an LWRP provider by its name (Ark) directly is no longer supported in Chef 12 and will be removed.  Use Chef::ProviderResolver.new(node, resource, action) instead. at 1 location:
    - /var/cache/chef/cookbooks/ark/resources/default.rb:26:in `initialize'
  chef_gem[chef-vault] chef_gem compile_time installation is deprecated at 1 location:
    - /var/cache/chef/cookbooks/mascherano/recipes/default.rb:10:in `from_file'
  chef_gem[chef-vault] Please set `compile_time false` on the resource to use the new behavior. at 1 location:
    - /var/cache/chef/cookbooks/mascherano/recipes/default.rb:10:in `from_file'
  chef_gem[chef-vault] or set `compile_time true` on the resource if compile_time behavior is required. at 1 location:
    - /var/cache/chef/cookbooks/mascherano/recipes/default.rb:10:in `from_file'

compile time true also caused problem when you need to use a private gem repo.  .gemrc file can't be writen at compile time so the gem install fails.  If gem is installed at converge as oposed to compile gemrc can be put in place first.
What is the comiple time need for the gem?

The gem has been moved to metadata.rb which eliminates the warnings which apply to this cookbook (a few of those don't).


Respect api_location setting when creating a HTTP Function

Current behavior:
When a user clicks "Create HTTP Function" it is always created in the /api directory.
Suggested behavior:
When a user clicks "Create HTTP Function" it should be created in the directory specified by the api_location setting in the workflow .yml file. If this setting is invalid/blank we can fallback and create the function in the /api directory.

Duplicate of #107 🤦


Consider using ISO8601 for date component

https://github.com/neuroinformatics-unit/SWC-Blueprint/blob/4699e3c4d95e0265d7f06fcf40c75af8a4107a7c/docs/source/specification.md?plain=1#L60
It can sometimes happen that an experimenter wants to run multiple sessions of the same subject on the same day, so it would be nice to standardize an optional time component for the BIDS path.
A widely used option which would be backwards compatible with the current one is ISO 8601. The current date string format is already a valid ISO 8601 string. This has the further advantage that it can be immediately parsed with the new datetime.fromisoformat class method from python 3.11.
The proposal would be to extend date into datetime and simply allow for any valid ISO 8601 string that the fromisoformat method would also accept. Examples below adapted from their docs:
from datetime import datetime
datetime.fromisoformat("20230810")
datetime.fromisoformat("20230810T1453")
datetime.fromisoformat("20230810T145328Z")
datetime.fromisoformat("2023-08-10")
datetime.fromisoformat("2023-03-07T115528Z")

All the above strings are parsed successfully by the method (my bias, I particularly like the last format since it makes for a more human-readable datetime string which is still file-system compatible and standards-compliant).

Thanks a lot @glopesdev for taking the time to read the specification and to raise this issue.
I like the idea of merging the date and time fields into one. As you said, multiple sessions per day are common in systems neuroscience, unlike in neuroimaging - where the BIDS standard came from. I think it would make things simpler to have 1 field.
Regarding the specific formatting, I do love YYYY-MM-DD as it is the most human-readable and unambiguous way of writing dates. The only problem is that in BIDS (and in SWC-Blueprint), the dash - character signifies the separation between keys and values in folder/file names, i.g. key1-value1_key2_value2. This makes it very easy to parse such strings into dictionaries.
That's why we went for the YYYYMMDD version of  ISO8601, even though it's less human-readable.  So it's essentially a conflict between human-readability and compatibility with BIDS 🤷🏼♂
The options below would not break the key-value convention:
datetime.fromisoformat("20230810")
datetime.fromisoformat("20230810T1453")
datetime.fromisoformat("20230810T145328Z")

But these are not very friendly to human eyes (especially the last two).
Let's have @JoeZiminski also weigh in, as he has implemented relevant functionality in datashuttle.

Hey @glopesdev thanks a lot for this, that's a very useful suggestion to use ISO8601 formatting for datetime, previously I have been stuck on the best way to represent this.
Currently in datashuttle there are keywords (@DATE@, @TIME@, @DATETIME@) to create a date, time or datetime key in the foldernames. An example foldername with all three key-value pair types:
sub-001_date-20230811_time-165900_datetime-202308_165900

The datetime format in datashuttle (as above) actually needs fixing, because it breaks BIDS, so ISO8601 format is perfect.
I would suggest to maintain flexibility, separate date, time, datetime keys are allowed in SWCBlueprint, but specify that the datetime value must be in ISO8601 format. Unfortunately as Niko mentioned the most readable ISO8601 formats cause some problems with BIDS key-value pair formatting. In this case for reaseachers can choose between more human-readable (sub-001_date-20230811_time-165900) vs. machine readable (sub-001_datetime-20230811T165900) . The SWCBlueprint can be updated to include these date / time / datetime key-value pairs. What do you think?

@niksirbi @JoeZiminski thanks for the feedback, it's interesting that when I first read the BIDS Specification the only mention of separation was the _ character. Then they only mention key-value pairs in the format key-value.
If this was the principle, then actually there wouldn't be any parsing problems in accepting values with multiple -, since you first parse for _, then you look for the first - to separate key from value, but then it would be fine to have multiple - characters in the name, it wouldn't be ambiguous.
However, I now realize they do say that values must be "alphanumeric" so I guess that excludes any symbols. It's interesting since further down in the specification they do mention that date time information "MUST be expressed in the following format YYYY-MM-DDThh:mm:ss[.000000][Z]" but I guess this must be for file contents since : is not a valid path character.
Anyway, I agree your proposal may be the best compromise if indeed other BIDS parsers do not understand values with multiple dashes.

Hey @glopesdev thanks a lot for this, I didn't know that about the date time information formatting for BIDS, that is quite confusing. I agree it must be specifically for the sidecar json metadata as it cannot be for folder / filenames.
I agree to err on the side of caution and avoid non-alphanumeric characters in case they case problems down the line with BIDS parsers, even though in theory it would not be an issue to have a parsing scheme. Another benefit is that it is easier to researchers to remember the key-value formatting rule if there are no exceptions.
I'll make an issue on datashuttle to fix the datetime formatting as we discussed. Thanks again for your feedback and if any other suggestions come to mind it would be great to hear!

closed with #38  Thanks @glopesdev!


Bubblesort R implementation

Hey @tsik1 , just checking in on these R PRs? Are you planning to work on them again? I am only asking because we have a duplicate PR #636 .

Already completed in #655 sorry for the trouble!


Reddit/Post -> Collapsing Reddit comments seem to have slight delay when clicking on the arrows

Visible when there are 100+ comments.

Actually performance issue is only when using auto in grid-template-* so it's chromium bug.
Once they fix it, issue will be closed.


API in create  adds excess double quotes

Portainer Community Edition 2.15.1
When I use the 'create' API with the body content as below (headers and auth are correctly configured), result is, the CMD content is wrapped in single quotes, so the nmap command does not execute properly because looks like that:
$ nmap '-A -T4 <IP_ADDRESS> -oX /data/result.xml'
instead:
$ nmap -A -T4 <IP_ADDRESS> -oX /data/result.xml
Details:
URL: https://<IP_ADDRESS>:9443/api/endpoints/2/docker/containers/create?name=NmapTest
Body:
{
    "Image": "instrumentisto/nmap",
    "Tty": true,
    "HostConfig": {
        "AutoRemove": false,
        "Binds": [
            "/home/nmap:/data"
        ]
    },
    "Cmd": [
        "-A -T4 <IP_ADDRESS> -oX /data/result.xml"
    ]
}

Command is wrapped in extra single quotes
This can only be seen in edit mode. If I remove the apostrophes in edit mode then everything works fine.

Working CLI equivalent:
$ sudo docker run --mount type=bind,source="$(pwd)"/,target=/data --rm -it instrumentisto/nmap -A -T4 <IP_ADDRESS> -oX /data/result.xml

@BlaiseDee
Can you post your API command for review?  I wanted to confirm this is the body of the .yml file in your API command?
{
   "Image": "instrumentisto/nmap",
   "Tty": true,
   "HostConfig": {
       "AutoRemove": false,
       "Binds": [
           "/home/nmap:/data"
       ]
   },
   "Cmd": [
       "-A -T4 <IP_ADDRESS> -oX /data/result.xml"
   ]
}

Is CMD called out in the image Dockerfile?
Thanks!

This is exactly what has worked for me now.
curl --location --request POST 'https://<IP_ADDRESS>:9443/api/endpoints/2/docker/containers/create?name=NmapTest' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer eyJhbGcixxxxx_lv1_Y' \
--data-raw '{
    "Image": "instrumentisto/nmap",
    "Tty": true,
    "HostConfig": {
        "AutoRemove": false,
        "Binds": [
            "/home/nmap:/data"
        ]
    },
    "Cmd": [
        "-A",
        "website.com",
        "-oX",
        "/data/result.xml"
    ]
}'

Please note the way I wrote "Cmd" each parameter as a separate item in the array
"Cmd": [
    "-A",
    "website.com",
    "-oX",
    "/data/result.xml"
]

instead:
"Cmd": [
"-A -T4 <IP_ADDRESS> -oX /data/result.xml"
]
And this is how it works, but when cmd is not split into individual elements, the command does not execute.
I think you can close this issue, it is only worth adding this description in the documentation.

Thank you for the update.  I am glad to hear you are able to move forward.  And, noted.
Thanks!


Networkx TypeError

Nuitka version, full Python version, flavor, OS, etc.:

0.9.2
Commercial: None
Python: 3.9.0 (default, Nov 15 2020, 08:30:55) [MSC v.1916 64 bit (AMD64)]
Flavor: Anaconda Python
Executable: C:\***\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10

How did you install Nuitka and Python

Installed nuitka via pip into a conda environment.

The specific PyPI names and versions

networkx @ file:///home/conda/feedstock_root/build_artifacts/networkx_1655215393654/work

Also supply a Short, Self Contained, Correct, Example

Minimal code is below.
import networkx as nx
g = nx.DiGraph()
print('Hiyer!')

Output (captured via nx_tester.exe > nx_tester.txt && type nx_tester.txt) below. I've removed some file and path info.
Traceback (most recent call last):
  File "C:\***\nx_tester.py", line 1, in <module>
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "C:\***\lib\site-packages\networkx\__init__.py", line 59, in <module networkx>
    from networkx import utils
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "C:\***\lib\site-packages\networkx\utils\__init__.py", line 3, in <module networkx.utils>
    from networkx.utils.random_sequence import *
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "C:\***\lib\site-packages\networkx\utils\random_sequence.py", line 24, in <module networkx.utils.random_sequence>
    @py_random_state(2)
  File "C:\***\lib\site-packages\networkx\utils\decorators.py", line 850, in __call__
    func.__defaults__ = f.__defaults__
TypeError: Nuitka doesn't support __defaults__ size changes

Provide in your issue the Nuitka options used

python -m nuitka --follow-imports nx_tester.py

This seems another case of function copying, that hopefully can be avoided with a source modification in anti-bloat mechanism too.

I am doing the anti-bloat work here first, seems a big compilation, that somehow pulls in unittest and we cannot have that happen, can we.

Part of the 1.0.1 release that is immanent.


Pop idle connections from the front of the pool

Version: 0cf98f921
Pop idle connections from the front so the pool behaves like a queue instead of a stack. go-redis performance is significantly better when the Redis cluster is under memory pressure (evicting data due to LRU). Most of the errors were read timeout errors from net.Conn.Read with a 1s deadline set, and they go away with this change. My theory is that conns are more uniformly used and the Redis server likes this better
Testing Setup
AWS ElastiCache Redis Cluster setup:

Engine 3.2.10 (Reproduces on 5.0.3 too)
3 shards
3 nodes per shard
cache.r4.xlarge node type

Redis cluster client configuration:
dialer := net.Dialer{
  Timeout:   1 * time.Second,
  KeepAlive: 30 * time.Second,
}

client := redis.NewClusterClient(&redis.ClusterOptions{
  Addrs:        []string{"addr"},
  MaxRedirects: 1,
  ReadOnly:     true,
  DialTimeout:  1 * time.Second,
  ReadTimeout:  1 * time.Second,
  WriteTimeout: 1 * time.Second,
  PoolSize:     30,
  Dialer: func(ctx context.Context, network string, addr string) (net.Conn, error) {
    return dialer.DialContext(ctx, network, addr)
  },
  IdleTimeout:        -1,
  IdleCheckFrequency: -1,
})

There are 30 Go application processes running with the above client, and cumulatively generating 80K GET/s and 15K SETNX/s. When Redis starts evicting data due to memory pressure, I see read timeouts and higher latency.
At 0:57 in the graph below is the switch to use this change

Just to make sure - you use the same redis.ClusterOptions with your change? Specifically IdleTimeout and IdleCheckFrequency is -1 in both deploys?

Just to make sure - you use the same redis.ClusterOptions with your change? Specifically IdleTimeout and IdleCheckFrequency is -1 in both deploys?

Yes, both times use the same Idle settings

@vmihailenco What do you think about making this an option?

I need to reproduce your results first. Locally in benchmarks your change does not make any measurable difference. Are you able to reproduce this locally?

I haven't been able to reproduce this locally. I can reproduce this in a AWS environment. Do you  have access to an AWS environment?

@vmihailenco Bump on the above question

I just tried to run benchmarks  go test -run=NONE -bench=BenchmarkRedis. on AWS environment with and without your change and I can't spot any difference. That does not prove much since they only measure CPU time - not latency and each run gives slightly different results.
If you want to move this forward you have to provide instructions how to reproduce your results. E.g. some program that can be run and that demonstrates the difference.

Closing since there is no way to say whether this improves anything or not.


Control for legacy monitoring agents in default policy assignments

Issue
There is a recommended migration from the older Log Analytics agents (MMA/OMS) to the new Azure Monitor Agent. The older agent will be retired on August 31, 2024.
Some of the existing default policy assignments install the older agent. Also there is a enableAMA property for the Dependency agent when deployed with the AMA rather than the MMA. Example for the Linux version:
{
  "properties": {
    "publisher": "Microsoft.Azure.Monitoring.DependencyAgent",
    "type": "DependencyAgentLinux",
    "typeHandlerVersion": "9.5",
    "autoUpgradeMinorVersion": true,
    "settings": {
      "enableAMA": "true"
    }
  }
}

Policy
I haven't done a full review, but the default policy assignments include these policy initiatives:

Policy Initiative name
Description

55f3eceb-5573-4f18-9695-226972c6d74a
Legacy - Enable Azure Monitor for VMs

75714362-cae7-409e-9b99-a8e5075b7fad
Legacy - Enable Azure Monitor for Virtual Machine Scale Sets

Suggestion
I suggest that initially a new parameter is added to control whether those "Legacy" policies are assigned.
I understand there is a longer term plan for the introduction of the new Preview policy initiatives such as [Preview]: Enable Azure Monitor for Hybrid VMs with AMA (59e9c3eb-d8df-473b-8059-23fd38ddd0f0), plus new policies to audit for the older ones.

Thanks @richeney for the issue. Have transferred to the Enterprise-Scale repo as all our policies in all implementations are sourced here 👍
Also looping in @paulgrimley as he is leading the PM effort on our migration to AMA with PG. @paulgrimley will leave this to you to handle, but may be worth consolidating into the issue #1055 and closing this one to keep things tidy.

Agree to close in favour of #1055.


fix: Use conventional structure for middleware file

We noticed that staging was not deploying correctly and did notice an this exception:
expected file /Users/jon/code/convection/lib/middleware/jwt_middleware.rb to define constant Middleware::JwtMiddleware, but didn't (Zeitwerk::NameError

After some tinkering I was able to reproduce locally like this:
$ RAILS_ENV=production ./bin/server

And now that I'm typing this out that error message is actually pretty good! It's telling us that Zeitwork is expecting one thing but we're doing another. Our choices were to:

do what Zeitwork is expecting and add a Middleware namespace to that file
move that file out of the middleware folder so that Zeitwork wouldn't expect a namespace at all
add lib/middleware to the list of "roots" that Zeitwork knows about
revert back to the classic mode of Zeitwork

I decided to just move that damn file. 🤷
Lots more chatter here: https://artsy.slack.com/archives/CA8SANW3W/p1611231374001500

Thanks @jonallured !

Thanks @jonallured !


[AIRFLOW-3459] Move DagPickle to separate file

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-3459
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Move the DagPickle class to a separate file as part of the big models.py refactor (/airflow/models/dagpickle.py).
As a result of the refactoring, I also split off models.Base into a separate file.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Only moved code around, nothing new.
Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

[x] Passes flake8

Codecov Report

Merging #4370 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #4370      +/-   ##
==========================================
+ Coverage   78.12%   78.14%   +0.01%
==========================================
  Files         202      204       +2
  Lines       16483    16496      +13
==========================================
+ Hits        12878    12891      +13
  Misses       3605     3605

Impacted Files
Coverage Δ

airflow/utils/db.py
32.53% <0%> (ø)
:arrow_up:

airflow/__init__.py
80.43% <100%> (+0.43%)
:arrow_up:

airflow/bin/cli.py
64.52% <100%> (+0.04%)
:arrow_up:

airflow/models/__init__.py
92.72% <100%> (+0.04%)
:arrow_up:

airflow/jobs.py
77.41% <100%> (+0.02%)
:arrow_up:

airflow/api/common/experimental/delete_dag.py
88% <100%> (ø)
:arrow_up:

airflow/models/base.py
85.71% <85.71%> (ø)

airflow/models/dagpickle.py
94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6acbf...3a5d770. Read the comment docs.

@BasPH Why did you close this? :-)

Spotted a mistake in my code, closed the issue to fix it first, then discovered I couldn't re-open because I done a force push... when will the Airflow project change its contributing policy? ;)

I didn't know about this restriction, happy to change it :-)

This page describes the exact same thing I experienced: https://github.com/isaacs/github/issues/361. Doesn't sound like something that can be configured from the repository end.
However, I think squashing commits by the Airflow committers would help prevent lots of force pushes.

Squashing is the default merge strategy, 99% of the merged PR's are merged using Github's Squash and merge. Only when the PR is too big to stuff everything into one commit, we rebase and merge.

The contributing guide states to squash all commits into a single commit yourself with message like [AIRFLOW-XXX] ..., so you're saying that's not needed?
If so, I could update the contributing guide.


acs commons error

Required Information

[6.2 ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: CFP10_______
[3.6.2 ] ACS AEM Commons Version: _____
[ ] Reproducible on Latest? yes/no

Hi , I am using AEM Ver 6.2 CFP10, Im migrating data from File Data store to S3 , and using a S3 connector of 1.4.8 I have one Author and 2 Publishers all of them running ( AEM Ver 6.2 CFP10) , I m getting the following errors . with regard to "acs commons".
16.03.2018 14:59:55.506 ERROR [<IP_ADDRESS> [1521226795503] GET /bin/acs-commons/dam/custom-components.json HTTP/1.1] org.apache.sling.servlets.resolver.internal.SlingServletResolver Calling the error handler resulted in an error
java.lang.Error: Unresolved compilation problems:
Only a type can be imported. com.day.cq.commons.inherit.InheritanceValueMap resolves to a package
com.day.cq.commons.inherit.InheritanceValueMap cannot be resolved to a type
com.day.cq.commons.inherit.InheritanceValueMap cannot be resolved to a type
at org.apache.jsp.apps.sling.servlet.errorhandler._404_jsp.(_404_jsp.java:10)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
Expected Behavior
When we test the images the meta data error shouldn't occur.
Actual Behavior
When we upload a image see the metadata errors.
Steps to Reproduce
Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to
any supporting assets, e.g. content packages, below
Links
I have attached the logs at the following location
https://files.acrobat.com/a/preview/a3d3ebbf-e884-4a2b-b534-cc34f131abe2
Links to related assets, e.g. content packages containing test components

This stack trace looks like a problem in your 404.jsp, not an issue with ACS AEM Commons.


Cannot Remove Account

If your issue relates to the Discovery Process, please first follow the steps described in the implementation guide Debugging the Discovery Component

Describe the bug
Attempting to remove an account or region hangs on the 'Remove Account' popup and produces the following error:
"o
2 validation errors detected: Value '[]' at 'accountAggregationSources.1.member.awsRegions' failed to satisfy constraint: Member must have length greater than or equal to 1; Value '[]' at 'accountAggregationSources.1.member.accountIds' failed to satisfy constraint: Member must have length greater than or equal to 1"

To Reproduce
Steps to reproduce the behavior:

Go to '/accounts'
Click on 'Remove'
Click 'Delete'
See error

Expected behavior
The account is removed
Screenshots
If applicable, add screenshots to help explain your problem.

Browser (please complete the following information):

Name chrome, safari
Version 107.0.5304.87, 16.0

Additional context
Add any other context about the problem here.

Does this happen for any account you try to remove? Does the account you tried to remove still exist in the Settings DynamoDB table? The table will have a long name like this: <your-WD-stack-name>-SettingsResolversStack-<ID-string>-PerspectiveSettingsTable-<ID-string>.

The account exists in the DDB table.  I do not have another account to test this with.

Yeah, I've bee able to reproduce this. What's happening is that if you've only one account and try to remove it we're sending an empty array to AWS Config for the number of regions to to scan, hence the validation error. As a workaround, you can just delete the account directly from the DynamoDb table.

Thanks!

I'm going to keep this issue open because I need to fix it on my end. I will close it when we've shipped the fix.

This issue has been fixed in the new v2.0.1 release. You can download the updated template here: https://aws.amazon.com/solutions/implementations/workload-discovery-on-aws/.


Implement more minimal health check

Currently the is_valid function uses SELECT 1; to check on the health of a connection but this can be improved a bit by replacing it with an empty query. I believe this accomplishes the same thing as the current state of code and saves the query from needing to go the planning stage in the postgres server.
See psycopg's implementation for example:
https://github.com/psycopg/psycopg/pull/791

Thanks!


Don't throw an error when focusing a newly created text-field

Connects to #269
Requires first this to be merged and released: https://github.com/vaadin/vaadin-control-state-mixin/pull/47

This change is

1: With this fix it will behave the same way as native input document.createElement('input').focus()
2: That is mentioned in PR description


Isometric Offset Problem

Thank you for the detailed reply in last post. I decide to use Isometric.
I try layers function in Isometric. However, I find out the game scene is different from the "Tiled Editor" scene.
I find out for Isometric, there is 2 extra fields "offsetx" & "offsety" in the "Tiled Editor" output json file. I try to search "grid-engine" source and find nothing on these 2 fields. Maybe this causes the problem.
Tiled Editor Scene:

Game scene:

Best
e.g. isometric.json
"layers":[         {          "data":[0, .....],          "height":20,          "id":1,          "name":"Tile Layer 1",          "opacity":1,          "type":"tilelayer",          "visible":true,          "width":20,          "x":0,          "y":0         },          {          "data":[0, ......],          "height":20,          "id":2,          "name":"Tile Layer 2",          "offsetx":0,          "offsety":-80,          "opacity":1,          "type":"tilelayer",          "visible":true,          "width":20,          "x":0,          "y":0         }],

The representation of the tilemap in phaser is completely independent of GridEngine. GridEngine however, is responsible for placing and moving your characters. If the characters seem to be off, that could be solved by using offsetX and offsetY: https://annoraaq.github.io/grid-engine/api/config.html#characterdata
If layers are not shown correctly from Tiled, make sure you are using https://photonstorm.github.io/phaser3-docs/Phaser.Tilemaps.Tilemap.html correctly (loaded all the assets and created all the layers). Also keep an eye on the console output for errors coming from Phaser regarding the tilemap.

@jtopaz1 Can I close this issue?


Add cmake options to change dbus service name and object path

This used to be in settings, but even then was only partially functional.
Now using the cmake options DOBBY_SERVICE and DOBBY_OBJECT, we can set
the dbus service name and object path across the project.

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Dobby/35/rdkcentral/Dobby

Commit: a52a40ed1e573c8912d2a8299305d30c1973d2b6

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/Dobby/35/rdkcentral/Dobby

Commit: a52a40ed1e573c8912d2a8299305d30c1973d2b6

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: Approved in scanning tool

Commit: a52a40ed1e573c8912d2a8299305d30c1973d2b6

Tested build on Xi1 with the following dobby.bbappend:
# Sky XiOne build
EXTRA_OECMAKE_append_skyxione = "-DDOBBY_SERVICE=com.sky.dobby -DDOBBY_OBJECT=/com/sky/dobby"

# Sky Llama build
EXTRA_OECMAKE_append_llama = "-DDOBBY_SERVICE=com.sky.dobby -DDOBBY_OBJECT=/com/sky/dobby"

# We use the cmake standard install, however it doesn't seem to correctly
# add the symlink for the systemd service, so here we do it as a post
# install step

# For sky builds, install the service file as sky-dobby.service
skyinstall () {
    rm ${D}${sysconfdir}/systemd/system/multi-user.target.wants/dobby.service
    mv ${D}${base_libdir}/systemd/system/dobby.service ${D}${base_libdir}/systemd/system/sky-dobby.service

    echo "Enabling service in ${D}${sysconfdir}/systemd/system/multi-user.target.wants/sky-dobby.service"
    install -d ${D}${sysconfdir}/systemd/system/multi-user.target.wants
    ln -sf ${systemd_system_unitdir}/sky-dobby.service ${D}${sysconfdir}/systemd/system/multi-user.target.wants/sky-dobby.service
}

do_install_append_skyxione () {
    skyinstall
}
do_install_append_llama () {
    skyinstall
}

FILES_${PN} += "${systemd_system_unitdir}/sky-dobby.service"
FILES_${PN} += "${sysconfdir}/systemd/system/multi-user.target.wants/sky-dobby.service"


Unstick sidebar content when going to a hash

When going directly to a hash very far down on a page (for example) the sidebar content in the PageLayout component should not stick, but it does.

@davidtheclark I'm wondering if it's a matter of the order in which things are happening because as soon as I scroll on the page the Sticky component snaps up to where it should be. Is there something I could do in componentDidMount if there is a hash in the URL? Or maybe it's more of an issue with the Sticky component we're using? Let me know if you have any thoughts that I could further 🕵♀ .
https://github.com/mapbox/dr-ui/blob/2e874553edb374e68988688c3c6c6ab6578459f4/src/components/page-layout/page-layout.js#L31-L34
cc @samfader

Batfish's auto-scrolling (either to a hash or to a saved scroll location) happens here: https://github.com/mapbox/batfish/blob/503064de33ebffa407bbdf5d20e44a8c71964ccd/src/webpack/router.js#L70-L75 — in the Router's componentDidMount.
I'm not sure right now whether the Router's componentDidMount will be called before or after its children's componentDidMounts (PageLayout will be a child of Router, I think). You could look into that.
When Batfish autoscrolls, it uses element.scrollIntoView() (see https://github.com/mapbox/batfish/blob/503064de33ebffa407bbdf5d20e44a8c71964ccd/src/webpack/scroll-to-fragment.js). Chances are the Sticky component does not register that because it may not trigger a scroll event. You may want to set the PageLayout to automatically adjust the Sticky component's stickiness (if that's possible) after a short delay to allow fo the page to programmatically scroll first.


Fix initial threashold for k!=10,100,1000

Initial threashold is not set correctly is k is not 10,100 or 1000

This looks fine, but would it be preferable to use the next highest score if one exists?
For example, a user wants $k = 50$ - can't we use the 100 threshold?


I140 make leaderboard page

Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]

Added a total_mileage field to the user and team models

If you achieve some mileage and then join a team, the already achieved mileage does not go towards your team's total. However, once you join the team, all mileage you achieve from then on will be counted.

Added signals to respond to any updating, creating or deleting mileage model instances by modifying the total_mileage field accordingly

This could have been done in the post_mileage view instead, but the advantage of using signals is that the total_mileage field will also be updated if the admin messes with users' mileage

Added a view in the backend to calculate the user and team leaderboards (just the top 100). If a user or team is passed with the request, the individual ranking of the passed user/team is also calculated (even if they're not in the top 100)
Made the leaderboard page on the frontend. It's pretty similar to the design on figma

Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
[Is there anything in particular in the review that I should be aware of?]
Related Issue

Resolve #140

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

Hmm, so calling get_mileage() for every user rather than simply accessing the total_mileage field? The latter option should be a lot more efficient I think.

Might have to merge main into your branch. You could change how you get the total mileage since you have it stored in the user table

Hmm, so calling get_mileage() for every user rather than simply accessing the total_mileage field? The latter option should be a lot more efficient I think.

Yeah I agree, the graph PR didnt have a total_mileage field so yours works well i think :)

However, in the teams case, I realise there is the potential for there to be a discrepancy between the value of total_mileage in the team model, and the sum value obtained by get_mileage(). This is because total_mileage doesn't count mileage achieved before a user joined the team, whereas get_mileage() does. So for consistency, maybe get_mileage() should return the value of total mileage in this case. We wouldn't want the total km value in the team dashboard to be different to what is shown on the leaderboard. The downside to this is that the total implied by the team mileage graph wouldn't match with the total given in the team dashboard. Not sure what to best thing to do is...

Perhaps the solution is for the mileage model to have a nullable team field, which records the team (if any) the user was in when the mileage was achieved. I think that will fix everything
...assuming that what we want to do is only count mileage achieved when the user is part of the team

Think I'm done now


Fix ApplicationLog

Fixes #152

This will require https://github.com/neo-project/neo/pull/1315 ?

No.

Tested, eventlogs appear. However, issue still exists on Base64 encoding.

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0x2b03f7a8db3649c9e2cb6d429dd358819b3fd536825d2a698e19de237583e60a",
        "trigger": "Application",
        "vmstate": "HALT",
        "gas_consumed": "0",
        "stack": [],
        "notifications": [
            {
                "contract": "0x43cf98eddbe047e198a3e5d57006311442a0ca15",
                "state": {
                    "type": "Array",
                    "value": [
                        {
                            "type": "ByteArray",
                            "value": "VHJhbnNmZXI="
                        },
                        {
                            "type": "Any"
                        },
                        {
                            "type": "ByteArray",
                            "value": "0wzwBoLXDacAgxEkGaxxo1Ezxh4="
                        },
                        {
                            "type": "Integer",
                            "value": "100000000"
                        }
                    ]
                }
            },
            {
                "contract": "0xa1760976db5fcdfab2a9930e8f6ce875b2d18225",
                "state": {
                    "type": "Array",
                    "value": [
                        {
                            "type": "ByteArray",
                            "value": "VHJhbnNmZXI="
                        },
                        {
                            "type": "Any"
                        },
                        {
                            "type": "ByteArray",
                            "value": "0wzwBoLXDacAgxEkGaxxo1Ezxh4="
                        },
                        {
                            "type": "Integer",
                            "value": "3000000000000000"
                        }
                    ]
                }
            }
        ]
    }
}

You see, "VHJhbnNmZXI="  base64 decoding => "Transfer", it's correct.
But what's "0wzwBoLXDacAgxEkGaxxo1Ezxh4="? It can't be base64 decoding.
@erikzhang

{
  "type": "ByteArray",
  "value": "0wzwBoLXDacAgxEkGaxxo1Ezxh4="
}

This is a ByteArray. So you can decode it to a byte[]. In this case, then you convert it to an UInt160 or address.

{
  "type": "ByteArray",
  "value": "0wzwBoLXDacAgxEkGaxxo1Ezxh4="
}

This is a ByteArray. So you can decode it to a byte[].
In this case (I mean Transfer), then you convert it to an UInt160 or address.

I know what you said, but the issue is that this toAddress: 0wzwBoLXDacAgxEkGaxxo1Ezxh4 is not illegal for Base64 decoding! So can you try it? "0wzwBoLXDacAgxEkGaxxo1Ezxh4=" base64 decoding? From myside, it's not able to be done.

This is a byte array, not a string.


How a trained model with  xgboost4j-spark becomes a web service

I've used xgboost4j-spark trained a xgboost model, and spark ml trained a LR model. But in product i have to pass the results which were predicted by the model to the web service.  Could you mind tell me how to deploy the trained xgboost model as a web service ? And extract the results from spark dataframe is very slow, so it can not solve the problem . Appreciate!

@CodingCat

@tqchen

@zyq11223 Consider using dmlc/treelite. If you are looking for managed solutions, you can look into using Amazon SageMaker. See this example for deploying pre-trained XGBoost model as web endpoint.

Closing this for now. Feel free to post at https://discuss.xgboost.ai/


Remove not really needed constraints in workflows

docker_integration waiting for docker in community is just making overall execution time longer
docker_integration in enterprise can run on dependabot (nexus and github secrets are available)

I would have done the opposite (allow dependabot PR in comunity but not in enterprise).

the only reason for skipping dependabot is when the workflow requires secrets, but secrets needed there are already available, so I don't see why skipping it

Also why are the roles tests needed in ent. and not in comunity?

Not sure what you mean, the other change I did is because strictly speaking there is no need to execute docker integration tests after basic role tests.

I would have done the opposite (allow dependabot PR in comunity but not in enterprise).

the only reason for skipping dependabot is when the workflow requires secrets, but secrets needed there are already available, so I don't see why skipping it

Are you sure? It seems to me aws secrets are not available to dependabot.

Also why are the roles tests needed in ent. and not in comunity?

Not sure what you mean, the other change I did is because strictly speaking there is no need to execute docker integration tests after basic role tests.

I mean that the dependency needs["docker"] is still present in enterprise workflow.


update readme from node6.x to 8.x

got this error when trying installation with Node.js 6.9.5
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "8.x".
error Found incompatible module

Thank you!


Link1s

Domain
https://link1s.com/RCVFvNFy
Link
https://drive.google.com/file/d/1c_XsEAoepm_UTyNUYzANuGMd-wISnvZk/view
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
No response
(Optional) Anything else?
https://rodjulian.com/vienna-vacation-is-the-most-beautiful-place-to-visit/
Code of Conduct

[X] I agree to follow this project's Code of Conduct

crowd bypass, afaik

To implement crowd bypass on link1s we'll have to use presistHash() on google.com as well because they make you search a blog, I really don't want to do that. We'll have a huge problem if it ever misbehaves

So I added a new API which can be used for cross site storage, it will be an easy bypass once https://github.com/FastForwardTeam/FastForward/pull/260 makes its way to all the browser stores

Looks like google finally accepted the update on Chrome web store. link1s bypass very soon:tm:

@NotAProton any updates?

They changed it to http params in a 302 request, if someone knows a way for the extension to parse them please help

you want to know if its a 302 result? then i suggest using fetch, instead of just doing like: fetch(url).then(r => r.json()).then(result => {}); you should check in the first then like:
fetch(url).then(r => { if (302 === r.statusCode) { /* its the 302 do something here */} else {return r.json()}).then(result => {})

yep can confirm its buggy

Ah, thanks for confirmed. It made me frustated for hours, LOL


Bug fix #3495

Type

[ ] Bug Fix #3495

Related Issues?
Fixes ##3495

Excellent, thank you @reshmee011 !


fix(security): address CVE-2021-3749 - axios >=0.22.0

Ensured that axios is updated to >=0.22.0 in all packages that use it.
The only place where it was not possible to upgrade it through upgrading
transitive dependencies was the ubiquity connector package so for that one
I forced the issue through the resolutions section of the root package.json.

The GitHub Cacti security advisory: https://github.com/hyperledger/cacti/security/dependabot/361
The general GitHub security advisory: https://github.com/advisories/GHSA-cph5-m8f7-6c5x
Weaknesses

WeaknessCWE-400
WeaknessCWE-1333

CVE ID: CVE-2021-3749
GHSA ID: GHSA-cph5-m8f7-6c5x
Fixes #2790
[skip ci]
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>Pull Request Requirements
[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

LGTM @petermetz I've approved it, but there are some conflicts, please resolve it in order to merge it.

@sandeepnRES Thank you for the review! I'm on it!


add remove collection command

Nice and simple. But what happens if the es index is missing?

Right, added ok_missing


Re-enable flask master tests.

This PR turns on testing for the Flask master branch.

Looks like one suite is still failing for pypy3 on master


Analyse UI performance, fix low-hanging-fruit items

I think some of the design choices in the UI implementation have bad performance characteristics.  For example, we update the I/O and Alarm status panels after every instruction.  This could be the reason why it takes the simulator several seconds to read the 360 lines of the "hello.tape" example program even though (1) the data is in memory, and (2) the simulated tape reader should be able to do this in under a second.
I'd like this code to be usable on portable devices (e.g. tablets) and it needs to not eat battery.

The obvious performance bottlenecks are

I/O status updates (~2ms per tick)
Rust tracing code (~0.2ms per tick)
JavaScript marshalling (for values returned from WASM to JS) (also ~0.2ms per tick).

The UI update performance issue can be mitigated by reducing UI update frequency to, say, once every 100ms.  The overhead of the tracing and WASM/JS marshaling infrastructure is much less tractable.  But it is important, as we would want the time taken for the simulator to emulate an instruction to be comfortably less than the time taken by the original machine, so that we can reliably run at the same speed as the original machine.


[BUG] Multiple files on swagger not work

Describe the bug
I'm trying to upload multiple files as documentation explaied:
@router.post("/uploadfile/")
def create_upload_files(files: List[UploadFile] = File(...)):
    return {"filenames": [file.filename for file in files]}

Expected behavior
then I test it on a swagger and expect to return names of files but I got this error:
422 | Error: Unprocessable Entity
Response body
{
"detail": [
   {
   "loc": [
    "body",
    "files",
     0
   ],
    "msg": "Expected UploadFile, received: <class 'str'>",
   "type": "value_error"
  }
  ]
 }

Environment:

OS: [Windows]
FastAPI Version [0.20.0], get it with:

pip list

Python version [3.7.3], get it with:

python --version

Additional context
When I upload a single file as the code below:
@app.post("/uploadfile/")
async def create_upload_file(file: UploadFile = File(...)):
    return {"filename": file.filename}

the swagger works fine but when I use the code of multiple it's not working

see the note in the docs : https://fastapi.tiangolo.com/tutorial/request-files/#multiple-file-uploads
you can use the HTMLResponse provided there

Yep, check the note linked by @euri10. It's a bug in Swagger UI. FastAPI supports it, and if you send multiple files it would work, but Swagger UI is not able to show the UI for that properly at the moment.

@muklah another work around is to copy the curl request shown in the swagger UI and manually add additional -F arguments on the end with the desired filenames -- that worked for me.

Thanks all for your answers


Unable to install JS Themis on Windows

Describe the bug
Unable to install JS Themis on Windows
To Reproduce
Steps to reproduce the behavior:

Run npm i jsthemis on an empty folder

See the following error:

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  addon.cpp
  errors.cpp
  secure_message.cpp
  secure_keygen.cpp
  secure_session.cpp
  secure_cell_seal.cpp
  secure_cell_context_imprint.cpp
  secure_cell_token_protect.cpp
c:\users\pedro\node_modules\jsthemis\errors.hpp(22): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory (compiling source file ..\addon.cpp) [C:\Users\pedro\node_modules\jsthemis\buil
d\jsthemis.vcxproj]
  secure_comparator.cpp
c:\users\pedro\node_modules\jsthemis\secure_session.hpp(24): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory (compiling source file ..\secure_session.cpp) [C:\Users\pedro\node_modu
les\jsthemis\build\jsthemis.vcxproj]
..\secure_message.cpp(21): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory [C:\Users\pedro\node_modules\jsthemis\build\jsthemis.vcxproj]
c:\users\pedro\node_modules\jsthemis\secure_keygen.hpp(24): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory (compiling source file ..\secure_keygen.cpp) [C:\Users\pedro\node_module
s\jsthemis\build\jsthemis.vcxproj]
  win_delay_load_hook.cc
..\secure_cell_context_imprint.cpp(23): fatal error C1083: Cannot open include file: 'soter/soter.h': No such file or directory [C:\Users\pedro\node_modules\jsthemis\build\jsthemis.vcxproj]
..\secure_cell_seal.cpp(23): fatal error C1083: Cannot open include file: 'soter/soter.h': No such file or directory [C:\Users\pedro\node_modules\jsthemis\build\jsthemis.vcxproj]
c:\users\pedro\node_modules\jsthemis\errors.hpp(22): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory (compiling source file ..\errors.cpp) [C:\Users\pedro\node_modules\jsthemis\bui
ld\jsthemis.vcxproj]
..\secure_cell_token_protect.cpp(23): fatal error C1083: Cannot open include file: 'soter/soter.h': No such file or directory [C:\Users\pedro\node_modules\jsthemis\build\jsthemis.vcxproj]
c:\users\pedro\node_modules\jsthemis\secure_comparator.hpp(24): fatal error C1083: Cannot open include file: 'themis/themis.h': No such file or directory (compiling source file ..\secure_comparator.cpp) [C:\Users\pedro\nod
e_modules\jsthemis\build\jsthemis.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\MSBuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\pedro\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\pedro\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\pedro\node_modules\jsthemis
gyp ERR! node -v v12.18.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok

Expected behavior
Should install
Environment (please complete the following information):

OS: Windows 7
Hardware: 64-bit
Themis version: 0.13.0 (latest at the time of this writing)
Installation way:

[x] via package manager
[ ] built from source

Hi @papb! Thanks for reporting this issue.
JsThemis requires Themis Core library to be installed in the system. This is an additional native library which npm cannot install. It seems that it is not installed, its headers are missing, and the builds fails because of that.
The bad news is that Windows support is still experimental. You will have to build Themis Core from sources for now. Here are instructions on how to build Themis Core for Windows using MSYS2. That should produce an installer which installs Themis Core into a location known by JsThemis.
At some point we want to provide proper binary builds of Themis Core for Windows. However, right now you will have to build it yourself 😞 That is, if you wish to use JsThemis specifically. (There are valid reasons for that. Performance is one of them.)
However, there is also WasmThemis which supports JavaScript apps and Node.js as well. It should work on Windows as is, without Themis Core. The API is mostly similar to JsThemis (but there are slight differences). You can install it with
npm install wasm-themis

Here are the docs on WasmThemis for further reading.
Maybe it will be a better fit for Windows development.

Thank you for the fast and detailed response, @ilammy!! I just tried wasm-themis and it works perfectly!! Thank you very much.
Question: is there any situation/reason for someone to prefer jsthemis over wasm-themis? Is there anything that jsthemis can do that wasm-themis can't?

JsThemis is intended for server-side deployment with Node.js (and Node.js only). It is designed to use the shared Themis Core library, with an intention of making it possible to update Themis Core independently of JsThemis or applications. For example, if a security vulnerability is discovered and fixed in Themis Core then with JsThemis you only need to update Themis Core in the system. You do not have to update JsThemis, rebuild applications, etc.
WasmThemis is intended for Web deployment and it uses WebAssembly (so it works in browsers, as well as with Node.js, and it's easier to use with Electron). It is designed on the premise that the user gets the entire application with all dependencies. In order to update WasmThemis the application should be rebuilt and redeployed.
The shared library aspect of JsThemis becomes less and less relevant as more applications turn to sandboxing. On Windows shared libraries were never popular in the first place. macOS is mostly sandboxed nowadays too. On Linux server-side software is often deployed in containers, and desktop software often uses sandboxes like Snap, Flatpak, Electron bundles, etc.
Feature-wise, JsThemis and WasmThemis are identical. All Themis features are available in both of them. The API is different in some cases, but anything you can with WasmThemis is possible with JsThemis as well (or any other language wrapper).
JsThemis uses native binary code, executing with the maximum possible performance. That means that it has to be compiled for a specific machine and a specific version of Node.js that will be running the code.
WasmThemis uses portable WebAssembly which is usually JIT-compiled before execution, but the compiler is not that efficient right now. I don't remember the exact benchmark numbers, but as a result WasmThemis is usually 2–3 times slower than JsThemis.
Basically, use WasmThemis if you

write a web app for browsers
want a simpler deployment (not have to mess with native libraries)
need to deploy portable code

Use JsThemis if you

need more performance than WasmThemis can offer now
want to be on the safe side with security updates for servers
target primarily servers or desktops

Awesome, thank you very much!!


Make all endpoints protected behind authentication

If the app is hosted on a public server, I expect most users would not want the app data publicly available. This will be especially important if we decide to later include volunteer data.

As a temporary solution it may be possible to block IPs on heroku, so we could block all IPs but ours and VOA for the MVP testing.

Once this is implemented, we should create another issue for the front-end to support this. I think most of the routes should be OK with this change, but some may break. Best to test on another branch before merging to master.

Closed via #132


X1 video feed not rendering correctly

Almost looks like the issues from the WIP to remove the black bar. Was this merged by mistake?

I think I did a bad local git command, ignore


Test Model 7 on DNS data

As the performances of the Model 7 #60
and enough robustness #61
We can think about testing this agent on data generated using Direct Numerical Simulation (DNS)
For this we can use the models with the best tilings found so macro 5x5 and micro 5x5; and, macro 9x9 and micro 7x7.

The tests can be performed with simulations done with the sources being places in the 12 following different source positions:

We need to test different observation threshold as the way the odor propagates carries widely with different thresholds:

Each layer is a different time-slices

With a wide variety of model subdivisions, we get the following convergences:

And speeds:

And for model 9x9, subdivision 7x7, by environment we have:

And speed:

Environments:

Implemented October 1st


[PIP 97][SASL Authentication] Remove Deprecated SASL AuthenticationDataSource#authenticate Implementation

Master Issue: PIP 97 https://github.com/apache/pulsar/issues/12105
Motivation
When the SASL Authentication Provider was created in https://github.com/apache/pulsar/pull/3821, it introduced an authenticate method into the AuthenticationDataSource. This method is not necessary, and was marked as deprecated in PIP 97: https://github.com/apache/pulsar/issues/12105. This PR breaks the SASL Authentication Provider's reliance on the AuthenticationDataSource#authenticate method.
As an added benefit, the AuthenticationDataSource is only a data source now. It is no longer overloaded as a data source and a means of authenticating data.
I plan to submit a subsequent PR to remove the SaslAuthenticationDataSource. This change is valuable by itself because it removes the reliance on AuthenticationDataSource#authenticate.
Note also that SaslAuthenticationState#authenticate is also deprecated in PIP 97. I want to first get this merged before moving to the async variant.
Modifications

Update SaslAuthenticationDataSource to remove unnecessary method declarations.
Update constructor for SaslAuthenticationState to only take the PulsarSaslServer as a parameter.
Update implementation of several methods in SaslAuthenticationState so that they no longer rely on the SaslAuthenticationDataSource.

Verifying this change
This change is internal to the SASL provider itself. It is covered by existing tests.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

[x] no-need-doc

This is a completely internal update, so no docs need updating.

@jiazhai, @merlimat, @eolivelli - PTAL

/pulsarbot run-failure-checks


Match weekend days properly

Set 'xdsoft_weekend' class on date only if it's weekend or matches to options.weekends array.

This is not merged into master.


[Bug] Notification about pinned message is not displayed

Your Rocket.Chat app version: 1.1.0
Your Rocket.Chat server version: 0.61.0
Device (or Simulator) you're running with: Motorola Moto G

If a user pins a message via web, an Android user will see an empty message
Web:

Android:

Thanks for reporting this issue!
This issue is fixed on upcoming v. 2.0.0.


how to deal this question

FileNotFoundError: [Errno 2] No such file or directory: 'models/scaler.dump'

Sorry for the late response. It's because python is trying to save the scaler to that directory but it doesn't exist. Either create the directory or update the save location.


Bug in 1.9 Beta

./tesla_dashcam /Volumes/TESLA/TeslaCam/
New release v0.1.8 is available for download (https://github.com/ehendrix23/tesla_dashcam/releases/tag/v0.1.8). You are currently on v0.1.9b0. Use --check-for-update to get latest release notes.
GPU acceleration is enabled
Discovered 1 folders with 2 clips to process.
Processing 2 clips in folder /Volumes/TESLA/TeslaCam/RecentClips (1/1)
Processing clip 1/2 from 04/21/19 18:37:22 and 27 seconds long.
Traceback (most recent call last):
File "tesla_dashcam/tesla_dashcam.py", line 1444, in
File "tesla_dashcam/tesla_dashcam.py", line 1440, in main
File "tesla_dashcam/tesla_dashcam.py", line 716, in process_folders
File "tesla_dashcam/tesla_dashcam.py", line 448, in create_intermediate_movie
UnboundLocalError: local variable 'camera_1' referenced before assignment
[19838] Failed to execute script tesla_dashcam
Trenzalore-2:tesla_dashcam_19beta spoo$

I get the same error

Fixed in new beta: https://github.com/ehendrix23/tesla_dashcam/releases/tag/v0.1.9b1


Error: Cannot find module 'react/lib/ReactDOMServer' | (devDependency installation)

When I install this module locally to the project as a devDependency, running flow-coverage-report with my custom flags yields:
Error: Cannot find module 'react/lib/ReactDOMServer'

However, if I install this module globally and run the same command, it works. Ideas? My app uses...
    "react": "^15.4.2",

@joncursi It looks like there was a problem with react v15.4.1, https://github.com/facebook/react/issues/8588, but it was resolved with 15.4.2.
Try updating flow-coverage-report to the master branch. It has had it's dependencies updated!

@ryan953 When you install from github:rpl/flow-coverage-report#master, there is another issue, because the npm run build is called only in prepublish, sot the dist directory doesn't exist, I think that it should be called in postinstall i will open PR and we will see


[#1160] Generated bots can't run in dotnet 5.0 - Migrate Experimental to NET6

Addresses # 1160
#minor
Purpose
This PR migrates the experimental skills projects to NET6.
Changes

Change netcoreapp3.1 with net6.0 in all experimental skill projects and test projects.
Upgrade Microsoft.AspNetCore.Mvc.NewtonsoftJson references to version 6.0.7.

Tests
Here we can see the unit tests passing after the changes:

/promoted 1398


[Linter] Secure Parameter hardcoded defaults rule does not work with decorator with a namespace

Bicep version
0.4.451
Describe the bug
Secure parameters should not have hardcoded defaults (except for empty or newGuid()).bicep corehttps://aka.ms/bicep/linter/secure-parameter-default rule does not work when decorator with a namespace (@sys.secure()) is used.
To Reproduce
@secure()
param mySecret2 string = 'test' //warning here

@sys.secure()
param mySecret3 string = 'test' //no warning here

output exposed2 string = mySecret2
output exposed3 string = mySecret3

Nice catch. cc @marcusfelling as FYI

I just found that this might be duplicate of #2773

Agreed - gonna close this once since we have the other tagged as top10 already


Don't automatically instantiate one to one dependencies.

If an object is new and a method is called to get a child object, then it should return null instead of automatically generating the child object.  Currently, an uninitialize child is created which is an undesirable side effect.

done in January 2021


AIX passes 3.8 tests

AIX passes master and 3.8 - as is. The 3.7 backports are finished and awaiting review and merge.

Hi - these are the PR (backports) needed to also have 3.7 in the green. At least asof a month ago.
[3.7] bpo-34373: Fix time.mktime() on AIX (GH-12726)
CLA signed awaiting review
#14242 opened 26 days ago by aixtools
updated 26 days ago
[3.7] bpo-34720: Fix test_importlib.test_bad_traverse for AIX (GH-9391)
CLA signed awaiting review
#14238 opened 26 days ago by aixtools
updated 26 days ago
[3.7] bpo-11192: Fix test_socket.py for AIX (GH-8954)
CLA signed awaiting review type-tests
#14237 opened 26 days ago by aixtools
updated 26 days ago
[3.7] bpo-34711: Return HTTPStatus.NOT_FOUND if path.endswith(/) and not a directory (GH-9687)
CLA signed awaiting review
#14197 opened 27 days ago by aixtools
updated 27 days ago
[3.7] bpo-35704: Fix test_shutil result for 32-bit AIX when MAXDATA < 0x20000000 [GH-11500]
CLA signed awaiting review type-tests
Thanks for your consideration!

I'm not ready to merge this change if there are still changes to be merged to 3.7 for tests to pass there.  I'm fine with enabling 3.8; not 3.7 until those PRs are merged.

I'm not ready to merge this change if there are still changes to be merged to 3.7 for tests to pass there. I'm fine with enabling 3.8; not 3.7 until those PRs are merged.

Modified the master.cfg to ignore both 2.7 and 3.7 branches.

Requesting this gets merged. The longer the wait the greater the chance a regression gets missed.

Sorry for the delay, I finally found a minute to get this merged and deployed.


Android: Replace Sceneform with Sceneview

As stated here https://stackoverflow.com/questions/62453399/google-sceneform-is-it-deprecated-any-replacement there is a replacement for Sceneform (which as we know is deprecated).
The successor seems to be https://github.com/SceneView/sceneview-android
I think it would make sense to switch them out.

Hello, thanks for your post.
We know about some successors on Sceneform, but, however, this library is dependent on official Xamarin.Forms bindings. But, Xamarin.ArCore is being updated regularly, so there is no delay on new features.
I am not aware that there are some recent news from Xamarin, regarding replacement of Sceneform.
However, if you have some info, we will be happy if you want to share it with us.
Regards,
Miki


GIF with diffusion noise only

Got any ideas where I should start looking to figure out why the resulting GIF is just jittery diffusion noise and nothing else? Much appreciated!

Could this issue be related to the sampler being used? Is there a possibility to choose a different sampler?
cc @talesofai, that's related to this fork - https://github.com/talesofai/AnimateDiff
P.S. I'm facing this with original repo too

Same, what is causing this?

normally it's caused by image inverse noise with too much diffusion loops

Was fixed after switching models I think

Resolved by itself after some time. I can't provide any resolution steps unfortunately.


Upgrade from eos 2.5.1 to 5.0.0

This PR upgrades trento to use the latest available version of the EOS design system. Since this also comes with a bump in the bootstrap version, some issues are expected.

Removing the draft flag as it seems to be working decently enough.

woops! I planned to add the screenshots when removed the draft flag but I forgot. Here I go:
Notice the difference in the fonts and the outlined icons in the menu (which now follows the eos design guidelines). Also notice that the feedback for a selected section in the menu is also slightly different; following also the EOS design template.

I also took the opportunity to use this from the EOS template to make the alert counts look a bit better:

Tables look good as well.


RSS feed for advisories

Initially posted here (before I've found the project on GitHub): https://bugs.archlinux.org/task/52218
RSS feed for advisories would be greatly appreciated for automated notifications.

@DragoonAethis sure, why not. can we close the one on the archlinux tracker?

Yep, no problem.

Seems werkzeug has an atomfeed lib http://werkzeug.pocoo.org/docs/0.11/contrib/atom/

thanks to @jelly we have this ready, will be available after next deployment via /advisory/feed.atom

I cannot seem to find anywhere this feed is advertised.
(I also thought it was common practice to take an url, e.g. https://security.archlinux.org/advisory and append .atom to make a feed, not append /feed.atom -- so eve testing random hopeful urls is not necessarily going to find the existing feed.)

I don't see a link to the Atom feed in the body of the document, but it is properly advertised to clients in a machine friendly fashion already, and has been for months. The atom feed for advisories has the appropriate <link> tag so browsers and other HTTP clients can react appropriately. (For instance, Firefox's feed button will light up on the page indicating the presence of a RSS or Atom feed. If you're using Chrome, there may be an extension that suits you.)

Ah yeah it's documented here, I think we can add a  to the body of the relevant pages. But there should also be an RSS icon somewhere on the page itself.

Machines can already read the  tag: view-source:https://security.archlinux.org/advisory


guild_view() does not launch the Guild View application

I have installed the package on R-Studio (2022.07.1) with R 4.2.2 w/o any error message under Windows 10. guild_run runs smoothly with the example you provided. When I run guild_view() nothing happens.
I already did some checks: I specified a port for guild_view but it looks like that the port is not in use afterwards. I can however start the script "guild view" which opens a page in the web-browser but does not find any runs. I can also see the add-in in Rstudio. I also turned off the firewall completely w/o any effect.
Do I need to adapt some more settings?

Welcome! I think you're running into two issues here, one with GUILD_HOME, another with background processes on windows.
For the GUILD_HOME issue, the quickest fix for you will be to set the env var GUILD_HOME to a path somewhere, e.g., "~/my-project/.guild" or "~/.guild". Then launched runs will be stored there, and guild view will look there when presenting runs.
For the background-process-on-windows issue, it'll require a fix on the package end to use processx:: instead of system2() to keep the "view" process alive. For now, please use the "guild view" launcher that works for you already, or call export_guild_cli() and call guild view from cmd.exe.
Note both these are temporary workarounds, until the required fixes are implemented.

Thx. Thomas: Setting the GUILD_HOME variable as propsed made my day 👍


Update reply image && Add reply URL

Calling msg.say(hd_file_box) will report an error Wechaty - ERROR - internal error <'utf-8' codec can't decode byte 0xff in position 0: invalid start byte>, but reading the image from local file will fix it.
Also, added an example to the reply URL, vaild for WeChat articles.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Link to https://github.com/wechaty/PMC/issues/16


Session attributes

Part of OEP https://github.com/rancher/opni/blob/main/enhancements/gateway/20230130-distinguishing-central-agent.md

This PR should be squashed when merging