$serviceName is not used.

Provide a narrative description of what you are trying to accomplish:

[x] Are you fixing a bug?

[ ] Detail how the bug is invoked currently.
[ ] Detail the original, incorrect behavior.
[ ] Detail the new, expected behavior.
[ ] Base your feature on the master branch, and submit against that branch.
[ ] Add a regression test that demonstrates the bug, and proves the fix.
[ ] Add a CHANGELOG.md entry for the fix.

[x] Is this related to quality assurance?

The $serviceName is never used.
I was trying to test the aplha version of zend-expressive on https://github.com/harikt/dms-expressive-example . I came across a strange issue that there is no longer injectRoutesFromConfig in Application and recommends using Zend\Expressive\Container\ApplicationConfigInjectionDelegator.
I missed to see how to use it, so this is how I modified
    // config/routes.php
    $delegator = new \Zend\Expressive\Container\ApplicationConfigInjectionDelegator();
    $delegator($container, null, function () use ($app) {
        return $app;
    });

I have not seen anything searching on the code base ApplicationConfigInjectionDelegator whether it is used. Only one instance of file is seen currently.
So the parameter seems not needed here.
Thank you.

It's there for compatibility with zend-servicemanager:
https://github.com/zendframework/zend-servicemanager/blob/master/src/Factory/DelegatorFactoryInterface.php#L23-L39
Implementing the DelegatorFactoryInterface directly would cause an extra zend-servicemanager dependency which is not really needed if you use another container.

@xtreamwayz hm... .So do you think we can keep something like $serviceName = null here ?
Also I am wondering if the usage I shown regarding this is right or not. Can you confirm the same ?

No you can't use null as you will always have a callback. Without the callback the delegator doesn't work. See: https://github.com/harikt/zend-expressive/blob/1e2bc4bd0fdb9ace75acd2c3f5fa62405d17f845/src/Container/ApplicationConfigInjectionDelegator.php#L33

Why do you want to pass the application itself when the container can get the application ?
Looking at the public/index.php
$app = $container->get(\Zend\Expressive\Application::class);

I am not really sure about the need for the callback itself. I have not ever looked at zend service manager nor used it , may be this is only there for the zend service manager ?
As I mentioned the reason I am questioning is the ApplicationConfigInjectionDelegator is called inside the project only once by me. There is no other usages I noticed in the search ( Either the search is giving wrong result ) .

I haven't used this myself and I can't find it in the docs. But I think you have to register this in your config:
public function getDependencies()
{
    return [
        'delegators' => [
            \Zend\Expressive\Application::class => [
                \Zend\Expressive\Container\ApplicationConfigInjectionDelegator::class,
            ],
        ],
    ];
}

If you register it like that, then it should inject all the configured routes and the pipeline for you. This is also where the DelegatorFactoryInterface is needed if you use zend-servicemanager.

There are a number of reasons for the argument order and for each argument being present.
The container is present so that the delegator can pull additional dependencies as needed.
The service name is provided to allow users to determine what service was originally requested. This can be used to prevent cyclical lookups, or to compare the service provided by the $callback (more on that) to what it was requested for (e.g., to see if the service returned is an instance of the service requested).
The callback is present because of when and how delegators are executed.
Delegators are only executed during initial creation of a service. You provide a list of delegators, and the container is expected to pass the results of one to the next. However, in actual usage, you may not want a delegator to execute if a previous one has raised an exception; alternately, you may want to be able to catch such exceptions and provide a substitute. As  such, we pass a callback to each delegator. Invoking that callback returns the service.
But it doesn't, actually. It returns the return value of the previous callback. In the case of the first delegator, this means it returns the result of a factory or abstract factory. In the case of the second, it returns whatever the first delegator returns.
You can actually think of delegators as middleware for containers. The last delegator on the list is executed first, and it calls on the callback to get the result of the previous, and so on. If one of the delegators returns an alternate service without ever calling on the callback passed to it, then those previous layers, including the original factory, are never executed.
This is why you cannot call $container->get(Application::class) within the delegator; you're already within such a call, which would lead to a recursive cycle. It's also because a delegator may choose to return a different instance entirely.

You can actually think of delegators as middleware for containers.

That's a nice description.


Install Lite from source in legacy checkpoint CI

What does this PR do?
Fixes https://github.com/Lightning-AI/lightning/actions/runs/3379363550/jobs/5611027254.
> Run pip install -e . -f https://download.pytorch.org/whl/cpu/torch_stable.html
...
ERROR: Could not find a version that satisfies the requirement lightning-lite==1.8.0.post1 (from pytorch-lightning) (from versions: 1.8.0rc0, 1.8.0rc1, 1.8.0rc2, 1.8.0)
ERROR: No matching distribution found for lightning-lite==1.8.0.post1

See successful runs: https://github.com/Lightning-AI/lightning/actions/workflows/legacy-checkpoints.yml?query=actor%3Aakihironitta+branch%3Aci%2Flegacy-checkpoint-lite
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[n/a] Did you verify new and existing tests pass locally with your changes?
[n/a] Did you list all the breaking changes introduced by this pull request?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @borda

Closing this since #15489 resolved the Lite installation issue in the legacy checkpointing CI.


Fix wrong path generation in Tag.php when adding namespace paths for classLoader

Hi @juergenweb,
past time I was getting quite a lot of warnings in TracyDebugger log panel and finally was able to track it down:
The dot in front of path was throwing errors:
is_file(): open_basedir restriction in effect. File(./home/.../mydomain.app/public_html/site/modules/FrontendForms/FormelementsFrontendForms/Home.php) is not within the allowed path(s): (/home/.../mydomain.app:/tmp:/usr/share/pear) in /home/.../mydomain.app/public_html/wire/core/WireClassLoader.php:354

The WireClassLoader.php:354 code is checking with is_file() and the dot in front makes the path not valid.
Also appending __DIR__.'FrontendForms' at the end is also wrong, as the current __DIR__ path already includes this directory. Actually it's /FrontendForms/Formelements/ as that's where the Tag.php is located.
It appears that making these changes might have fixed it. Although this error was happening quite randomly and I had not much success reproducing it myself, but I was seeing such log entries few times per day.
Not sure the __DIR__ (like /home/.../mydomain.app/public_html/site/modules/FrontendForms/Formelements/) is the correct path in this file context, but I hope you will be able to take a look into this.
Thanks!

Hello @donatasben
I have merged your pull request. I have tested it and I have not discovered any problems. Thank you for reporting this edge case issue. I will bump up the version and then we will see, if problems occur.
Best regards Jürgen


Refresh the branding data before starting the daemon

Currently, when the bot is starting up, it will think that we changed the branding assets due to its lack of data, and change the server icon. This can be solved by adding a call to self.refresh() in this function
https://github.com/python-discord/bot/blob/9e1dd9d6ddcf1bbf4762cac34745a5748787e887/bot/exts/backend/branding/_cog.py#L140-L143

hi, im hoping to start this as my first open source project, can i get it assigned to me?

Hey, thanks for your interest. I've assigned the issue to you. Be sure to check out the contributing guide on the website to learn how to setup the bot, and the CONTRIBUTING guide  here to see the rules we expect you to follow.
If you have any questions, feel free to ask in the dev-contrib channel.

can i work on this?

Sorry @rijusougata13, @liorsanders has already requested this to be assigned to them. Feel free to reach out to them on discord to offer your assistance though!

ok np

@liorsanders are you still planning to implement this?

#1463 solves this.


Streams for file downloads

Do you plan to add support for Streams in files/:file_id/content endpoint? I am using GridFS for storing files on my side, and it would be more convenient to have a ReadStream in client.accounts(:account_id).files(:file_id).content().

I just realized that I can get a file URL requesting a files/:file_id/content endpoint with as_link parameter then request a file content with a tool of my choice, including a http(s).request which will give me a Stream instance.
Sorry for disturbing.

No worries! Always appreciate feedback on our client libraries. Have a great day.


aufs rootfs discovery error for crawler in container

When we run crawler inside container, it is failing with new mount path discovery method in dockerutils.
  File "/crawler/dockercontainer.py", line 109, in __init__
    self.root_fs = get_docker_container_rootfs_path(self.long_id)
  File "/crawler/dockerutils.py", line 306, in get_docker_container_rootfs_path
    raise DockerutilsException('Failed to get rootfs on aufs')
DockerutilsException: Failed to get rootfs on aufs

This occurs because, now we need /var/lib/docker mounted inside container for discovering.

Yeah, we need to fix this: https://github.com/cloudviz/agentless-system-crawler/issues/108
Are you volunteering to give it a try? :D

for now, we can just mount /var/lib/docker inside container at same location.

that works, yes

Issue is tracked at #108


[FORMS] Form calls ->removeValidation() on validator, but may not always be defined.

On this line: https://github.com/silverstripe/silverstripe-framework/blame/3.2/forms/Form.php#L683
        // We have to remove validation, if the fields are not editable ;-)
        if($this->validator)
            $this->validator->removeValidation();

However, if you create your own implementation of Validator there's no contract (abstract definition) to inform you that you must also implement a ->removeValidation() method on your validator. I'd suggest either defining this as a default method on the Validator abstract class or, better yet, set this up as an abstract method so that it will fail earlier so that results are more consistent and predictable (since you may not realize this will fail until it's too late and already in production).
Thankfully I haven't had taht issue just yet, but I didn't realize this method was needed until months after I ended up disabling all the fields on my DataObject :)

FYI, this affects 3.1.x and 3.2 from what I can tell.

It looks like this was fixed in #4542 which has been available since 4.0; closing


Tag query change

Hey, first of all - amazing work, thanks so much, love this repo and it was exactly what I was looking for when moving to Paperless-ngx. And some of the stuff being developed looks great too.
When querying documents from PL, it doesn't perform correctly when using 'api/documents/?query=tags:paperless-gpt' or 'api/documents/?query=tags:paperless-gpt-auto'. It returns 0 results.
Paperless Version (docker:latest): 2.13.5
Scenario:

Querying tags sometimes works when PL has just started
When querying documents that are automatically tagged using workflow this does not work
When querying document manually also does not work
When you manually tag a document with 'paperless-gpt' or 'paperless-gpt-auto' it sometimes works
So, in total, automatic tagging does not work

When I started diagnosing, I used the 'Filters' button at the top of the '/api/documents' and this gives a different query to use. Specifically 'api/documents/?tags__name__iexact=<insert_tag_here>' - note, no 'query=' or 'tags:' and since this change, this has worked as expected.
Hope this works as expected for you as well.
Thanks, Chris

Hey @ccrlawrence! 😄
Awesome contribution. 🚀  Thanks for finding this. It didn't come up on my setup so that was kinda a blind spot.
Feel free to reach out if you find any other issue.


treat unassigned bjorn/crown slots differently from those assigned to $familiar[none]

This fixes the issue described here:
https://kolmafia.us/threads/assigning-the-buddy-bjorn-a-bonus-while-using-buddy-bjorn-results-in-failure.27419/
and obviates the earlier fix done here:
https://github.com/kolmafia/kolmafia/pull/662
Essentially, the root issue is that the value FamiliarData.NO_FAMILIAR was being used to communicate two distinct ideas: bjorn-slots that were unassigned (which is now assigned a value of null), and bjorn-slots that were actively set to $familiar[none] (which are now continued to be called FamiliarData.NO_FAMILIAR). This allows the maximizer to better handle $familiar[none] as though it was a regular familiar.
I've unfortunately been unable to write a failing test for the buggy behavior I've experienced, but screenshots in the linked forum thread show the weird behavior we currently get. With this fix, I'm now getting the expected behavior, and no tests have flipped to failing. Testing with this built at home has shown nothing funky.
I swear to god this is the last PR I write about this.

I have a reproducing example for "unequip bjorn":
  @Test
  public void keepFilledBjornEquippedWithBonus() {
    equip(EquipmentManager.CONTAINER, "Buddy Bjorn");
    KoLCharacter.setBjorned(new FamiliarData(FamiliarPool.DICE));

    assertTrue(maximize("adventures, -buddy-bjorn, +25 bonus Buddy Bjorn"));
    recommendedSlotIs(EquipmentManager.CONTAINER, "Buddy Bjorn");
  }

(Namely, bjorn needs an inhabitant.)
Looking for a reproducing test case for the CoT case.

I have a reproducing example for "unequip bjorn":
  @Test
  public void keepFilledBjornEquippedWithBonus() {
    equip(EquipmentManager.CONTAINER, "Buddy Bjorn");
    KoLCharacter.setBjorned(new FamiliarData(FamiliarPool.DICE));

    assertTrue(maximize("adventures, -buddy-bjorn, +25 bonus Buddy Bjorn"));
    recommendedSlotIs(EquipmentManager.CONTAINER, "Buddy Bjorn");
  }

(Namely, bjorn needs an inhabitant.)
Looking for a reproducing test case for the CoT case.

Interestingly, this build seems to be failing that test. I'll investigate why. Under what circumstances does maximize typically return false?
Testing it in my built copy appears to be succeeding fine with or without a familiar currently in the bjorn.

And, reproducing example for "illegal bjornification":
  @Test
  public void keepFilledBjornEquippedAndUnchangedWithCrownAndBonus() {
    canUse("Crown of Thrones");
    canUse("time helmet");

    KoLCharacter.addFamiliar(new FamiliarData(FamiliarPool.DICE));
    equip(EquipmentManager.CONTAINER, "Buddy Bjorn");

    assertTrue(maximize("adventures, -buddy-bjorn, +25 bonus Buddy Bjorn"));

    recommendedSlotIs(EquipmentManager.HAT, "time helmet");
    recommendedSlotIs(EquipmentManager.CONTAINER, "Buddy Bjorn");
    // Fuzzy dice adds +10 to all stats. Make sure we didn't just equip it.
    assertEquals(0, modFor("Muscle"), 0.01);
  }

Would be good to make sure that your fix addresses both of these cases.

Under what circumstances does maximize typically return false?

Per the code, two cases: Mafia encountered an error (!KoLmafia.permitsContinue()), or the recommended maximization failed.

Fiddling around with this, it seems like recommendedSlotIs just doesn't work for things that are already equipped?
I fiddled around with keepEmptyBjornEquippedAndUnchangedWithCrownAndBonus, and tested a few cases:

using canUse instead of equip for the bjorn was a success
adding a recommendedSlotIs for the time helmet did not add a failure (that is, it failed later, when it got to the bjorn's recommendedSlotIs
adding a recommendedSlotIs for the time helmet and equipping it instead of using canUse got us a failure

Prior to adding these tests, the only place recommendedSlotIs gets used on this file is for the basic meat fez in noTiePrefersCurrentGear, which does not start off equipped.
That being said, I'm not sure how actually to test it if we can't use recommendeSlotIs. KoLCharacter.hasEquipped seems not particularly useful because my understanding is that the maximize function we're calling doesn't equip anything.

If you debug the test and freeze it at the end, you can inspect Maximizer.boosts to see what Maximizer is recommending. That's how I wrote the helper functions in the first place.

If you debug the test and freeze it at the end, you can inspect Maximizer.boosts to see what Maximizer is recommending. That's how I wrote the helper functions in the first place.

I ended up hashing this out in the forums with heeheehee. (This may be an incorrect number of hees). The new setup should be appropriate.


browserStorage.delete triggering Expected identifier error in IE 6,7,8

Line 82 / browserStorage.delete - triggers expected identifier error in IE 6,7,8. Fix by replacing the function name from browserStorage.delete to browserStorage.deleteKey and replace all calls within the file.

@webraptor  thank you for report, fixed


[firebase_admob] Call AdView lifecycle methods in Android activity lifecycle callbacks

It's not clear in the AdView  documentation about when to call destroy(), resume(), or pause(). Their documentation only states that they should be called in their respective Activity method. (e.g. adview.pause() called in activity.onPause()), but we have only been calling destroy() in the dispose() method.
I should also note that neither Banner, Interstitial, or Native ads examples talk about using these.
https://developers.google.com/admob/android/banner.
We should investigate if calling these methods is recommended and if so, support activity lifecycles in the Android Admob implementation.

First discussion: https://github.com/FirebaseExtended/flutterfire/pull/169#discussion_r386658814

The firebase_admob plugin will be deprecated in April 2021 in favor of Google Mobile Ads SDK for Flutter.
Google Mobile Ads SDK for Flutter is a new Flutter plugin that supports more Ads formats than firebase_admob does. Google Mobile Ads SDK for Flutter currently supports loading and displaying banner, interstitial (full-screen), native ads, and rewarded video ads across AdMob and AdManager. It also supports displaying banner and native ads as Widgets as opposed to being overlayed over all app content.
We're now recommending projects currently using firebase_admob migrate to Google Mobile Ads SDK for Flutter following the instructions outlined here.
Issues with migrating or with using the new package should now be raised over on the Google Mobile Ads SDK for Flutter repository.


Allow to set an icon to display on loading screen instead of Frigate logo

While the Frigate logo is amazing, I don't think its colors fits my dashboard well.

If I had the option to choose, I would choose displaying an MDI icon centered on the screen.
I could just build an image with the icon myself, upload it and set the card to use its URL, but having this option would be better since it would not require to download any image.

Just trying to understand the usecase: Why is the bird image showing up there? Is that screensaver mode?

I honestly don't understand either, but it does show up occasionally.
There is one specific situation in which I can make it show up consistently, which is when I exit the editor mode for example.
But I'm not in home right now so I can't really share details.
My assumption is that, perhaps, it shows up whenever fetching the images from HA fails?

My assumption is that, perhaps, it shows up whenever fetching the images from HA fails?

Yes. It will show up when it is asked to render an image, but no other image is available for whatever reason. Sounds like it is in these temporary cases you'd like to be able to show something else. If yes -- got it.

The behavior in v5 beta1 should be different if you are using the go2rtc provider and don't have the show still image option set while loading.
For birdseye you need to set a Custom Birdseye Icon in frigate to get ride of its black and white logo.

Using this card with frigate on an proxmox lxc container. While frigate is running flawlessly i got that logo flashing every 5 min. On my dashboard for my 3 camera card at same time. Not sure if i have to open another specific issue for this case.
I though it was due to my fully kiosk tablet using wifi but its not.
I tried a couple of changes like setting go2rtc or webrtc but i didn't got any result.
So what can cause this every 5 min?

To be honest, I have a feeling that the stream restarts in the Frigate card on every 5 minutes indeed. Let me double check it.

+1, please open a new issue if you can reproduce this as it does not seem at all related to this feature request. Thanks.


Compare async/await to ContinueWith

Hello,
As far as I understand, async/await is just syntactic sugar over the Task function ContinueWith. For instance, if we have a Task t and a function f, then X x = await t; return f(x); is the same as t.ContinueWith((x) => { return f(x.Result); });.
Then instead of comparing synchronous code versus async/await code, I would recommend to compare asynchronous code by ContinueWith to asynchronous code by async/await. In the particular breakfast example of this webpage, we would see 2 almost identical codes, because all async methods have only one or two awaits.
The async/await notation is called "monadic do-notation" in functional programming, and it is most useful when there are 3 or 4 monadic values to combine in a single function. Here that would mean 3 or 4 awaits in a single function, then we would see a big simplification compared to intertwined lambda functions inside ContinueWiths.
Moreover, the discussion of synchronous code might be skipped altogether in this page. The difference between monothread and multithread algorithms has become common these days, people are probably already familiar with them.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17d27a0d-c072-8c9f-7e31-3de60bee9ae8
Version Independent ID: e0c09794-e712-19ff-cb9f-12648d60d4f6
Content: Asynchronous programming in C#
Content Source: docs/csharp/programming-guide/concepts/async/index.md
Product: dotnet-csharp
Technology: csharp-async
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

This would be a good to do because in fact they aren't identical. async/await should be preferred(it's extremely optimized, especially in .NET 5) compared to ContinueWith

Thanks for writing this @VincentSe
We agree this should be covered.  I'll recommend we do that on a different page where we we compare different ways to express asynchronous algorithms. That would help readers know how to translate between different them and choose the best practice for their use case.

Always use async/await 😄

Always use async/await 😄

That's the short version.

@BillWagner @davidfowl Thanks, I am looking forward to seeing more details about the differences between async/await and ContinueWith. For instance, I was recently trapped by ContinueWith adding the continuation in the child thread, whereas async/await posts back into the message pump of the calling thread. This difference made my GUI crash in one case, and work in the other, that's somewhat confusing.


Exception thrown in batch() after await inside createEffect leaves the app unresponsive.

Describe the bug
Similar to #1452, but now inside a createEffect. When we have a batch() call which throws an exception after an await, then the app remains unresponsive. This happens with or without the batch call being wrapped inside runWithOwner. The same code without batch() runs fine.
Your Example Website or App
https://playground.solidjs.com/anonymous/5266c783-a247-411e-a39a-b12be0c1e16d
Steps to Reproduce the Bug or Issue

Click on the button. The button count becomes '1' and the message gets updated to 'Dummy error runWithOwnerOnly'
Click on the button again. The button count becomes '2'  but the message is not updated.
The app is now unresponsive

Expected behavior
Since the exception is handled, I would expect the app to continue responding to click events and state updates.
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Chrome
Version:  109.0.5414.75

Additional context
No response

minimal repro https://playground.solidjs.com/anonymous/a08c9e79-72ec-4110-9323-b29b90e5c688
batch isn't cleaning up Updates handling error


NLTK Tokenizer Crashes

NLTK was working fine but it started crashig above are the commands i used for downloading the nltk Package.
below is the error i am getting.

Same error for me too. It started recently

@orajson, your error is different from @SesaYash, which was about the now deprecated "punkt" package.
It has been replaced by "punkt_tab". Have you tried to download it using nltk.download("punkt_tab"), as suggested in the error message?

@ekaf Yes. same error even with nltk.download("punkt_tab")

Can you download other packages, for ex. "names"?

Yes I can download both punkt_tab and names but still getting weird error. It was working OK before but suddenly the error started.

The weird est is that the  "/root/" folder is a very unusual place to store nltk_data, and you shouldn't even be allowed to read its contents. So I suspect that NLTK is not set up to search there. Is that folder mentioned in the error message,among the places searched? Does it exist and contain /root/nltk_data/tokenizers/punkt_tab.zip?

I'm running this code in Databricks and it searches various directories as shown below

Can you do:
ls -l /root/nltk_data/tokenizers/punkt_tab.zip?

Adding blow to explicitly define download location in the code resolved the error for me.
nltk.download('punkt_tab', download_dir='')
nltk.data.path.append('')
The code used work without above before but now it is required for some reason.
Thank you so much for your assistance in this matter. Much appreciated @ekaf

Explicitly defining ‘nltk==3.8.1’ in the requirements.txt file works for us

Explicitly defining ‘nltk==3.8.1’ in the requirements.txt file works for us

Please don't do that, as it binds you to an obsolete and insecure NLTK version. You should rather  update to 3.8.2.

Adding blow to explicitly define download location in the code resolved the error for me. nltk.download('punkt_tab', download_dir='--Download Location--') nltk.data.path.append('--Download Location--')
The code used work without above before but now it is required for some reason.

Hello, is it planned to fix this (e.g. in version 3.8.3)? We use nltk in a bunch of modules and adding the above two lines everywhere would be a lot of effort.

@mhuels  I ran into this error (https://github.com/nltk/nltk/issues/3287#issuecomment-2282644527) in Databricks environment where muti Spark nodes are running. I guess nltk.download() might have downloaded packages on master node only but worker nodes ( or the other way around) and that is why the "Not Found" error raised.  When I added below two lines (https://github.com/nltk/nltk/issues/3287#issuecomment-2282656550) for a shared location across all nodes including master / workers, the issue is gone. I guess my error is isolated to such as distributed cluster environment.

@mhuels, of course this should be fixed, and not by adding two lines everywhere. A solution could be for NLTK to have a specific treatment for the distributed cluster situation, which can also cause #3248.

one question: whats difference btw punkt and punkt_tab?

Thanks @ekaf . Just wonder cant we just have one single data-package called punkt instead of separating them as punkt(older) ang punkt-tab(latter)? So that user wont confused?

Thanks @ekaf . Just wonder cant we just have one single data-package called punkt instead of separating them as punkt(older) ang punkt-tab(latter)? So that user wont confused?

@hteeyeoh, that is a nltk_data issue.

Any update @SesaYash? In principle, it should not crash with the latest NLTK 3.9.1.

alright. thanks

Modifying my path for storing
nltk.data.path.append("/usr/share/nltk_data")

But after a few run for few instance it still fails

@SesaYash, what error message do you get?

"LookupError",
"Cause": "{"errorMessage":"\n**********************************************************************\n  Resource \u001B[93mpunkt_tab\u001B[0m not found.\n  Please use the NLTK Downloader to obtain the resource:\n\n  \u001B[31m>>> import nltk\n  >>> nltk.download('punkt_tab')\n  \u001B[0m\n  For more information see:
https://www.nltk.org/data.html\n\n
Attempted to load \u001B[93mtokenizers/punkt_tab/english/\u001B[0m\n\n  Searched in:\n    - '/usr/share/nltk_data'\n    - '/home/sbx_user1051/nltk_data'\n    - '/var/lang/nltk_data'\n    - '/var/lang/share/nltk_data'\n    - '/var/lang/lib/nltk_data'\n    - '/usr/share/nltk_data'\n    - '/usr/local/share/nltk_data'\n    - '/usr/lib/nltk_data'\n    - '/usr/local/lib/nltk_data'\n    -

@SesaYash,  have you tried to download punkt_tab as suggested in the error message?
import nltk
nltk.download('punkt_tab')

Yeah tried it but i havent updated my version as i containerize my application and every few weeks it updates so i wanted to go back to roll back of previous version of NLTK module which was more reliable 3.8.


NuGet package 2.3.2 is missing Windows Phone 8.0 / 8.1 Silverlight assemblies

Version 2.2.9 of the ZXing.Net.Mobile.Forms NuGet package contained Windows Phone 8.0 / 8.1 Silverlight assemblies:

ZXing.Net.Mobile.Forms.2.2.9

lib

MonoAndroid403
portable-net45+netcore45+wpa81+wp8
UAP10

wp8

ZXing.Net.Mobile.Forms.dll
ZXing.Net.Mobile.Forms.WindowsPhone.dll

Xamarin.iOS10

But version 2.3.2 of the ZXing.Net.Mobile.Forms NuGet package completely lacks the Windows Phone 8.0 / 8.1 Silverlight assemblies:

ZXing.Net.Mobile.Forms.2.3.2

lib

MonoAndroid403
portable-net45+netcore45+wpa81+wp8
UAP10
Xamarin.iOS10

Is this intended or just a packging mistake?
Thanks in advance & best regards!

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


[QUERY] What is the syntax for creating generic resources?

Library name and version
Azure.ResourceManager 1.0.0
Query/Question
The way I did this on the old fluent API:

        var insights = await ResourceManager
      .Configure()
      .Authenticate(creds).WithSubscription(subscriptionName)
      .GenericResources.Define(deploymentName)
      .WithRegion(regionName)
      .WithExistingResourceGroup(rgName)
      .WithResourceType("typeOfRg")
      .WithProviderNamespace("Microsoft.XXX")
      .WithoutPlan()
      .WithApiVersion("2020-06-01-preview")
     .WithProperties(propertiesJSON)
     .CreateAsync();

I am unable to figure out how to do this on this new API version and have been trying to guess how to do it. The closest I could find was this file https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/resources/Microsoft.Azure.Management.Resource/src/Customizations/Models/GenericResource.cs

    /// <summary>
    /// Initializes a new instance of the GenericResource class.
    /// </summary>
    /// <param name="id">Resource ID</param>
    /// <param name="name">Resource name</param>
    /// <param name="type">Resource type</param>
    /// <param name="location">Resource location</param>
    /// <param name="tags">Resource tags</param>
    /// <param name="plan">The plan of the resource.</param>
    /// <param name="properties">The resource properties.</param>
    /// <param name="kind">The kind of the resource.</param>
    /// <param name="managedBy">ID of the resource that manages this
    /// resource.</param>
    /// <param name="sku">The SKU of the resource.</param>
    /// <param name="identity">The identity of the resource.</param>

But I can't determine what the one to one mapping is from the old API to this new one. I also can't find any examples of this in the repo. Can someone please assist?
Environment
No response

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'ARM:0.34759727,Compute:0.107822575,Storage:0.054388307'

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @ar1950, sorry for the delayed response. For GenericResource in Azure.ResourceManager 1.0.0, you can find the corresponding source code for create method here.
Here is the sample code to use this method to create a Vnet:
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Azure.Core;
using Azure;
using Azure.Identity;
using Azure.ResourceManager;
using Azure.ResourceManager.Resources;
using JsonObject = System.Collections.Generic.Dictionary<string, object>;

ArmClient armClient = new ArmClient(new DefaultAzureCredential());
SubscriptionResource subscription = await armClient.GetDefaultSubscriptionAsync();
var lroRg = await subscription.GetResourceGroups().CreateOrUpdateAsync(WaitUntil.Completed, "testRg", new ResourceGroupData(AzureLocation.WestUS));
ResourceGroupResource rg = lroRg.Value;
GenericResourceData input = new GenericResourceData(AzureLocation.WestUS2)
{
    Properties = BinaryData.FromObjectAsJson(
        new JsonObject()
        {
            {"addressSpace", new JsonObject()
                {
                    {"addressPrefixes", new List<string>(){"<IP_ADDRESS>/16" } }
                }
            }
        })
};
ResourceIdentifier vnId = rg.Id.AppendProviderResource("Microsoft.Network", "virtualNetworks", "testVnet");
var lroGenericResource = await armClient.GetGenericResources().CreateOrUpdateAsync(WaitUntil.Completed, vnId, input);
GenericResource genericResource = lroGenericResource.Value;


[CINFRA] Disable a fuilrePoint test for Replication1 if run with Replication2

Scope & Purpose
TestOnly change. The test changed here is using the FailurePoint "FollowerInfo::add" which prohibits Replication1 from reporting a follower to the Agency. This Failure Point is not reached in Replication2 and the behaviour tested here does not exist anymore. Hence I disabled the "current" part of the test. (that the create works without failure point is tested somewhere else)

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.11: (Please link PR)
[ ] Backport for 3.10: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

The one Red test could not be caused by this PR


[Request] Wildcard/Folder Support for Images when generating NPC

As a DM I would like to pull from a group of random images from a directory or a regular expression so that each type (race/class) doesn't always come up with the same image.

I second this. Using a wildcard would also allow me to more easily manage a library of images, where more often the race and gender is embedded inside the token file name, rather than having to always put them into very specific folders.

directory paths already include all subdirectories, so I added regex support for file names!


Narrative

From a DM standpoint it would be nice to manage the game narrative.  My mind waivers back and forth from simple to complex.
Simple
Can be as simple as "Chapter" title and narrative.
Complex
Might be cool to have "Chapter" title and narrative with the potential to "branch" in the narrative based on PC actions.  My initial thought is that it could build some form of a decision tree associating "encounters" with the narrative.
Maybe the decision tree idea is too complex which means we might be able to just "link" encounters from within the text taking us back to simple with the ability to handle "special" encounter links.
Thoughts?

I'm leaning towards punting on complexity and going with "Simple with encounter linking"

I also like the idea of "links" within these types of things that might trigger events for PC users (i.e. Sounds, Images or map transitions/actions) which would be useful for sethtrain/marvin#19

Another cool thing would be for the DM to have the ability to call for a roll (with certain modifiers) from the PCs.   So at any point the DM clicks the certain link and it drops an action into the PC view which when clicked would trigger /roll (and maybe one day gathering the results back in Narrative view for handouts or additional narrative bonuses)

Definitely prefer the simple option to the complex one. I think the complex one takes this into the realm of a video game and not tools to manage a table-top campaign. It could even be something as simple as DM "notes" where notes have a title & body. Could even be expanded to notes/journal entries for players too. Or even in-game notes, like a letter found on a bookshelf.

Right, if we have the ability to do Markdown plus linking something as simple as notes would be good enough, might be work having the ability to "jump to" headings in the notes but should be fine.

There's also a danger here of re-implementing a wiki or, worse: wordpress :)

:truestory:

We should probably come up with a rubric for deciding what fits in marvin and what doesn't. I'll start another ticket.

OK, sounds good.

https://github.com/sethtrain/marvin/issues/27

So I am going to official propose...
Narrative Notes:

TItle
Body (formatted with Markdown)

If we want to extend it in any way we can do that with front-end "tricks":
Chapter 1
This is the narrative behind chapter one.

Here is a quote which means you actually say this to the players.

[E: "Encounter 3"] (or some derivative) would be interpreted on the front-end and "linked" to trigger an action that displays "Encounter 3 narrative".

I only wonder if we should split it up or just have one notebook per game.

I'm also now wondering if we should include a type (Story, Encounter) and keep the Narrative in one table.  Thoughts?

I like
{
  "title": "Chapter 1",
  "body": "markdown\nwith **stuff**"
}

type always strikes me as a smell. it normally means you're trying to express something that your model can't. I wonder if we could use the counter system to tag a note? i mean it's an object like anything else. "story" or "encounter" are just tags.
So maybe: /counter "Chapter One" "enounter" 0 (the number would be meaningless...probably...up to the DM though). Also, tags can overlap, so you could also apply /counter "Chapter One" "social" 0


Initial pre-commit hooks and documentation

Closes https://github.com/nltk/nltk/issues/2744
I'd like to try a few simple pre-commit hooks with some documentation, see if it goes okay, and then add more

@dannysepler please let me know if you would like to be a team member, with permission to accept pull requests. I'm keen to "empower the players" :)

Cool. Sure thank you!


feat(auth): add cookieOptions for underliying auth client

allow customize cookie options on auth client

Thank you! I was just hitting this issue myself.
An example ro illustrate the benefit of these changes to others:
I'm working with supabase auth and next.js. The client-side session is stored in local storage and is valid for up to a week. The session cookies lifetime on the other hand is always eight hours. The server-side auth validation is therefore "out of sync" after eight hours and will prompt the user to log in again, even though the session is still valid.
I expected the cookie to be "synced" with the local storage session.

@soedirgo can we merge this PR?


Adds customStyleMap for more control over inline style ranges #342

cc @hellendag
Note, I also considered making customStyleMap and customStyleFn mutually exclusive, where if the latter were specified, then the former would materialize a function with the current behavior and only pass down customStyleMap to the leaf component -- but, then you'd lose the default behavior, which seems a little aggressive.
I think as long as it's clear that customStyleFn will execute after any customStyleMap additions then this is fine.
The downside here, is that just specifying a customStyleFn means that the default draft styles will always apply and you'd have to overwrite them to stop it (which is the current situation anyway).

I like this, and I think that in the long term, this approach will make sense as a replacement for the style map given the superior flexibility.

@hellendag comments addressed. Thanks

@hellendag anything needed further on this PR for merge?

LGTM. Let's do it.


Explicitly disallow empty services

What does this PR do?
Explicitly disallow empty services when values are set this way:
providers:
  kubernetesCRD:
    allowEmptyServices: false
  kubernetesIngress:
    allowEmptyServices: false

Motivation
The bug is if we don't explicitly set the cmdline flags to false, they will always default to true:

https://github.com/traefik/traefik/blob/v3.2/pkg/provider/kubernetes/ingress/kubernetes.go#L52
https://github.com/traefik/traefik/blob/v3.2/pkg/provider/kubernetes/crd/kubernetes.go#L62

More

[ ] Yes, I updated the tests accordingly
[ ] Yes, I updated the schema accordingly
[x] Yes, I ran make test and all the tests passed

Thanks for your PR. Could you add the corresponding unit tests ?

@darkweaver87 added

@MaximilianMeister I updated this PR title following conventional commit.
Feel free to update my edit if I missed something.

There is a tiny indentation space missed. Otherwise, LGTM. Thanks 👍

thanks, i rebased with your suggestion, please have another look


recreate test based on naming & consistency with previous test

fixes broken test 2.1

Merged. Thanks!


Kokopelli issue

Great project except kokopelli does not work on OSX10.11 el capitan (impossible to install wxpython and there for to compile sources...too). therefore we have a great project and useless file in obsolete file format. :(
no hardware usable too :(
If you want open source.
why don't you've used svg for gears as for the card?
and why no standart file format for pcb (fritzing is cool)... all your work become effortless and lost for community. It's sad.
and there is no picture too, a bit complexe to understand how to build.
please take some time to update project with usable file.
regards
éric

The idea is porting the project to openscad and freecad for mechanical and
kicad for electronics. And upload the pics also. They got lost when I
killed wordpress.
Regarding that problem you have with kokopelli. If you haven't taken the
fab academy class I recommend you to step back. Even if you manage to
install it you will spend quite a lot of time trying to learn the basics
and using it. I love it but most people hate it. And you seem one of the
last.
Also have a look at the forks. Maybe someone has been already doing what
you are looking for.
Fran
On 18 Nov 2016 16:53, "mrbbp"<EMAIL_ADDRESS>wrote:

Great project except kokopelli does not work on OSX10.11 el capitan
(impossible to install wxpython and there for to compile sources...too).
therefore we have a great project and useless file in obsolete file format.
:(
no hardware usable too :(
If you want open source.
why don't you've used svg for gears as for the card?
and why no standart file format for pcb (fritzing is cool)... all your
work become effortless and lost for community. It's sad.
and there is no picture too, a bit complexe to understand how to build.
please take some time to update project with usable file.
regards
éric
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TheBeachLab/BeachLab_flip_flap/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFQOcPk1p6FHvDtqH0-Rodbp5ctFegL_ks5q_cnbgaJpZM4K2oFe
.


autoDrag

Hi! how we can change size dynamic. for example if  inside div width  is 300 then [size] = 20, if div widht is 400 then [size] = 30
tnx

Hi, you can provide size values depending on whatever you want by yourself, sorry that's out of the library scope.


[REQUEST] Custom trained model to support cryptomatte and depth pass

It would be great if we could use cryptomatte and depth passes generated from a rendering engine i.e. blender, and to use their combined information to inform the final "rendering" via controlnet.
This would be somewhat similar to a combination of depth and segmentation maps as they are currently implemented.

I think we would need at least 200k examples of cryptomatte and depth passes and a target image to train a controlnet model to do that.

In theory it would be easy to automatically generate images for training.
Blender has a good coverage with python APIs and after some initial setup all steps can be automatic.
We could prepare a small but diverse set of scenes (there are many made available by the blender foundation).
For each of them we need to set up many vectors for the camera to be moved and aligned to.
We enable the two passes we are interested in, and profit.

Edit: this was a reply to a post later removed.
In theory it would be easy to automatically generate images for training. Blender has a good coverage with python APIs and after some initial setup all steps can be automatic. We could prepare a small but diverse set of scenes (there are many made available by the blender foundation). For each of them we need to set up many vectors for the camera to be moved and aligned to. We enable the two passes we are interested in + the normal full rendering, and profit.

All we need is 200k of these examples.

512x512? It is feasible, even more so with few cards supporting OptiX.
Actually eevee got support for Cryptomatte few years ago, so we could avoid Cycles.
The main concern would be tagging the final images.

512x512? It is feasible, even more so with few cards supporting OptiX. Actually eevee got support for Cryptomatte few years ago, so we could avoid Cycles.
The main concern would be tagging the final images.

Automated captioning by BLIP or whatever?

I don't have any experience with it, but its seems good from what I have seen.

Wouldn't it be possible to have a more detailed caption? "FF0000: gray car, 00FF00: glass, 0000FF: parking lot"

Basically a material list exported from blender with at least albedo and the material label?

also see "double control" discussion here https://github.com/lllyasviel/ControlNet/discussions/30


Type-safe intersections?

export type StepBase = { id: string; blockId: string; outgoingEdgeId?: string }
const stepBaseSchema: JSONSchemaType<StepBase> = {
  type: 'object',
  properties: {
    id: { type: 'string' },
    blockId: { type: 'string' },
    outgoingEdgeId: { type: 'string', nullable: true },
  },
  required: ['id', 'blockId'],
}

export type StartStep = StepBase & {
  type: 'start'
  label: string
}
const startStepSchema: JSONSchemaType<StartStep> = {
  type: 'object',
  properties: {
    ...stepBaseSchema.properties,
    type: { type: 'string', enum: ['start'] },
    label: { type: 'string' },
  },
  required: [...stepBaseSchema.required, 'label'],
}

Is there a way to create a schema for an intersection type without repeating the code?
The above code says: The types of 'properties.id' are incompatible between these types.
For union type we can use anyOf but what about intersection types? I tried using allOf but it doesn't seem to be appropriate?

Type-level intersection produces a type that JSONSchemaType cannot process, unfortunately.

@epoberezkin following up here, couldn't you do something like:
type UncheckedJSONSchemaType<T, IsPartial extends boolean> = (
  | // these two unions allow arbitrary unions of types
  {
      anyOf: readonly UncheckedJSONSchemaType<T, IsPartial>[]
    }
  | {
      oneOf: readonly UncheckedJSONSchemaType<T, IsPartial>[]
    }
  | {
      allOf: readonly UncheckedJSONSchemaType<T, true>[]
    }
...

where the allOf field is explicitly marked as Partial? Yes, it's not perfect -- typescript won't catch if you've actually captured all of the relevant fields -- but it gives some amount of confirmation that the fields you do have are correct, which is better than nothing.
(Either way, it is probably worth updating the docs to make it clearer that this not feasible / what the correct workaround should be, probably SomeJSONSchema)


AttributeError: 'NoneType' object has no attribute 'split'

Trying to download good-parts-javascript-web (https://frontendmasters.com/courses/good-parts-javascript-web/)
I am running this:
python frontendmasters-dl.py --mute-audio --id USERNAME --password PASSWORD --course good-parts-javascript-web

This is a big course (I think there is a timeout problem), It works for other smaller courses.
It appears that the signature and expire parameters expire by the time the app starts to download the links.
The download fails at the download section with the following error:
Downloading: Two_Systems
Traceback (most recent call last):
  File "frontendmasters-dl.py", line 24, in <module>
    downloader()
  File "c:\python27\lib\site-packages\click\core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "c:\python27\lib\site-packages\click\core.py", line 697, in main
    rv = self.invoke(ctx)
  File "c:\python27\lib\site-packages\click\core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\python27\lib\site-packages\click\core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "frontendmasters-dl.py", line 17, in downloader
    spider.download(course, high_resolution, video_per_video)
  File "C:\OS_FrontendMaster-dl-master\extractor\spider.py", line 56, in download
    self.download_course(course_downloadbale)
  File "C:\OS_FrontendMaster-dl-master\extractor\spider.py", line 219, in download_course
    self.download_video(i1, i2, subsection, section_title, course_path)
  File "C:\OS_FrontendMaster-dl-master\extractor\spider.py", line 227, in download_video
    i1, i2, subsection, section_title, course_path
  File "C:\OS_FrontendMaster-dl-master\extractor\helper.py", line 16, in get_local_file_path
    extension = get_file_path_from_url(subsection['downloadable_url'])
  File "C:\OS_FrontendMaster-dl-master\extractor\helper.py", line 43, in get_file_path_from_url
    return url.split("?")[0].split(".")[-1]
AttributeError: 'NoneType' object has no attribute 'split'

Also get this error message:
[0120/141913.667:WARNING:audio_sync_reader.cc(172)] ASR: No room in socket buffer.: The pipe is being closed. (0xE8)

yep

No issues with other courses but this one: css3-in-depth
Everytime after the links have been collected and the download starts, it will crash.
Traceback (most recent call last):
  File "frontendmasters-dl.py", line 24, in <module>
    downloader()
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "frontendmasters-dl.py", line 17, in downloader
    spider.download(course, high_resolution, video_per_video)
  File "/Users/x/Documents/05_CODING/OS_FrontendMaster-dl/extractor/spider.py", line 56, in download
    self.download_course(course_downloadbale)
  File "/Users/x/Documents/05_CODING/OS_FrontendMaster-dl/extractor/spider.py", line 219, in download_course
    self.download_video(i1, i2, subsection, section_title, course_path)
  File "/Users/x/Documents/05_CODING/OS_FrontendMaster-dl/extractor/spider.py", line 227, in download_video
    i1, i2, subsection, section_title, course_path
  File "/Users/x/Documents/05_CODING/OS_FrontendMaster-dl/extractor/helper.py", line 16, in get_local_file_path
    extension = get_file_path_from_url(subsection['downloadable_url'])
  File "/Users/x/Documents/05_CODING/OS_FrontendMaster-dl/extractor/helper.py", line 43, in get_file_path_from_url
    return url.split("?")[0].split(".")[-1]
AttributeError: 'NoneType' object has no attribute 'split'

user  --video-per-video i tested it, it will fix the problem

use  --video-per-video i tested it, it will fix the problem

Closing the ticket, please try the new version and reopen the ticket if the issue is still unsolved.


Readme mentioning HTTPS requirement would be useful

I couldn't make service workers work. Probably because I haven't figured out how to use HTTPS on my local development environment.
If this is the reason I couldn't make service workers work, it would be nice if a readme could mention this requirement.

This is a good idea, thanks! I've added a readme to help with this.


typescript declaration files

could you create some?

Hi, yes typescript bindings would definitely be useful.
I'm a bit crushed with work at the moment-- I'll get to this when I have a chance. In the meantime feel free to submit a pr.

https://github.com/weicracker/-types-koa-body
this is my using

@weicracker on https://github.com/weicracker/-types-koa-body/blob/master/index.d.ts#L41 you wrote onerror but it seems to be onError. Is this a problem?
@dlau I will add a PR for this issue

@dlau  @naxmefy How's the ts definition PR going through? I see the PR is a month-old now. Is there something I can help with?

@andyblaesus i dont know - @dlau have to merge it if he wants it

Sorry for the delay, merging!

Live in 2.4.0

@dlau Hmm, when I npm install koa-body, I don't get the index.d.ts. I did get the 2.4.0 version though. Am I doing something wrong? Thanks!

Never mind, it seems to work now. Thanks you for the efforts!


⚠ Turnos 24x7 has degraded performance

In 5b112d3, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 962 ms

Resolved: Turnos 24x7 performance has improved in 2632f81.


Build 8.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

@conda-forge-admin, please rerender

All the builds are failing while trying to set up docker.

Error response from daemon: Head "https://quay.io/v2/condaforge/linux-anvil-cos7-x86_64/manifests/latest": received unexpected HTTP status: 502 Bad Gateway

Now it's building.

Looks like the issue is still going on but it is building https://github.com/conda-forge/openmm-feedstock/runs/19069468387

All builds passed.  I think the Github issue is resolved.


Separate hooks for media queries and pseudo selectors

Vast majority of calls don't need them, but end up incurring the cost for the checks anyways. Ergonomics of doing className={useStyles() + useMediaQueryStyles() + usePseudoClassStyles()} isn't all that worse compared to nesting in the same object.
Can probably beat emotion and styled components once we do this.

Also, we can manually make media queries take precedence over regular styles by using a separate stylesheet.


Transform cursor to pointer when hovering over a collapsible

Demo

Fixes #362

What do you use to create screenshot gifs @algomaster99 ? Those are useful 😃

@jorgeorpinel I use Simple Screen Recorder for recording screens but its output is .mp4. You can easily convert it into .gif using this link.

I see. You may want to try cmd+shift+5 if you're on Mac in that case. ezgif.com/video-to-gif is nice too but I like to convert videos with https://handbrake.fr/ (downloaded)


[Android] Change the library load logic for embedded application.

For embedded application, it loads the library from "app-lib" at first,
if that failed, then loads library from "/data/data/". This will also be
failed when the architecture is inconsistent and lead to crash.
So architecture should be checked before library loaded from "/data/data/".
BUG=XWALK-5804

@axinging @fujunwei @wuhengzhi @xzhan96 @XiaosongWei PTAL, thanks.

This PR should be back ported to Crosswalk-16.

Can you rephrase the commit there is some mistakes in english. Also it would be nice to add a test.

yeah, I also think it better to rephrase the commit log.

Please don't merge this PR.


SyntaxError: invalid syntax

Pretty sure i'm doing this wrong but heres how it goes,

python

timesearch.py get_submissions -r subredditofchoice

Output:
File "", line 1
timesearch.py get_submissions -r subredditofchoice
===================^
SyntaxError: invalid syntax
(Ignore the  =====================s they're just there as spacers since GitHub doesn't like spaces}.

Yeah, the way to do it would not to be to run Python first, as that just puts you in the shell.
You'll want to run it as python timesearch.py get_submissions -r subredditofchoice, in one command.

Thanks @WAUthethird for responding.
@liner601, William is right, Timesearch is run from your terminal / command prompt, not from within the Python interpreter. Make sure to cd into the Timesearch folder so that you can run python timesearch.py as William described. Here's a screenshot:

I'll take a look at improving the readme to help people who are new to running Python programs. Feel free to close this issue when you get it working 👍

Yeah, the way to do it would not to be to run Python first, as that just puts you in the shell.
You'll want to run it as python timesearch.py get_submissions -r subredditofchoice, in one command.

Whenever I try to use 'python timesearch.py get_submissions -r subredditofchoice'
It returns a blank output, as if the command hast been run.

I'm sorry about that, I haven't heard of this problem yet so let's try to figure it out.
Firstly, what does it show when you run python --version? Do you have multiple versions of Python installed, and the default is not 3+? Did you have any issues during the setup described here?
What happens if you do python timesearch.py --help? Then python timesearch.py get_submissions --help? Please try poking around a bit with commands like this and see if you can get some output. Try some of the other commands too. Screenshots would be appreciated if you're able to provide them.

I'm sorry about that, I haven't heard of this problem yet so let's try to figure it out.
Firstly, what does it show when you run python --version? Do you have multiple versions of Python installed, and the default is not 3+? Did you have any issues during the setup described here?
What happens if you do python timesearch.py --help? Then python timesearch.py get_submissions --help? Please try poking around a bit with commands like this and see if you can get some output. Try some of the other commands too. Screenshots would be appreciated if you're able to provide them.

Thanks for the quick response!
Python shows my version to be 3.7.0, no duplicate installs.
Setup was actually quite easy, no hiccups there.
http://prntscr.com/s4bhd2
Theres a screenshot of my cmd prompt.
Although I've found one odd thing that may be the issue, timesearch.py was 0kbs and when I opened it with visual studio it appears theres no code within it.

Although I've found one odd thing that may be the issue, timesearch.py was 0kbs and when I opened it with visual studio it appears theres no code within it.

Yep, that sounds like a problem alright!
Here's that file: https://github.com/voussoir/timesearch/blob/master/timesearch.py
If that's the only 0kb file, then copy-pasting this code back into the file should work. If any other files look broken, you can always re-download everything from the main page.
This kind of thing tends to happen when using > in the command prompt, like echo hello > timesearch.py will put the world hello into the file but delete everything else. Since my readme file uses > timesearch.py to visually represent the command prompt, I can see how this would easily cause confusion and create problems. I will make the readme more clear. Thank you for opening this issue.

Although I've found one odd thing that may be the issue, timesearch.py was 0kbs and when I opened it with visual studio it appears theres no code within it.

Yep, that sounds like a problem alright!
Here's that file: https://github.com/voussoir/timesearch/blob/master/timesearch.py
If that's the only 0kb file, then copy-pasting this code back into the file should work. If any other files look broken, you can always re-download everything from the main page.
This kind of thing tends to happen when using > in the command prompt, like echo hello > timesearch.py will put the world hello into the file but delete everything else. Since my readme file uses > timesearch.py to visually represent the command prompt, I can see how this would easily cause confusion and create problems. I will make the readme more clear. Thank you for opening this issue.

Seems like it worked! Thanks for the quick responses and the amazing tool, Good day.


Better upstream (SVN) branches

Currently, all the source code is imported via git svn to a branch named opendss-official-svn, as documented in https://github.com/dss-extensions/dss_capi/blob/5969d756faeafcc2c181548ad276d1e039484035/docs/upstream_branch.md
Since OpenDSS version 8+ (folder Version8) is the main implementation, it might be useful to import the two folders Version8 and Version7 into two separate branches here, e.g. opendss-official-svn-v8 and opendss-official-svn-v7.
Besides that, since OpenDSS on SourceForge is a monorepo which includes every single file (docs, binaries, etc.), a lot of commits result in empty changesets when we import here. Filtering out those empty branches would be useful (currently I do that temporarily in my local copy).
Something similar could be done for the dss-extensions/electricdss-tst repo.

Pushed the two branches to test the idea. Still want to try adjusting git svn directly later. For now, this was done with:
git checkout opendss-official-svn
git branch opendss-official-svn-v7
git branch opendss-official-svn-v8

git checkout opendss-official-svn-v7
git filter-branch --subdirectory-filter Version7 --prune-empty -f
git filter-branch --tree-filter 'rm -rf Source/CMD_Lazz Source/DDLL Version7/Source/CMD_Lazz Version7/Source/DDLL Version8/Source/CMD_Lazz Version8/Source/DDLL' --prune-empty -f

git checkout opendss-official-svn-v8
git filter-branch --subdirectory-filter Version7 --prune-empty -f
git filter-branch --tree-filter 'rm -rf Source/CMD_Lazz Source/DDLL Version7/Source/CMD_Lazz Version7/Source/DDLL Version8/Source/CMD_Lazz Version8/Source/DDLL' --prune-empty -f

git push -u github opendss-official-svn-v7
git push -u github opendss-official-svn-v8

It seems to work fine: https://github.com/dss-extensions/dss_capi/commits/opendss-official-svn-v8
This will help comparing the implementations and generating the changelog.
One related idea: since some commits only change formatting, try to apply a code formatting tool (likely a variation of JCF) to keep a canonical copy of each file. It seems JCF (JEDI Code Format) is integrated with Lazarus, and I found this repo (maybe not up-to-date) of a CLI tool based on that: https://github.com/git-bee/jcf-cli
If the tools still works, the idea is feasible.

Hm... JCF indeed works. The version from Lazarus doesn't seem to include extras, I got the same issues with some .pas  files as before. I don't see the need for that JCF-CLI version, maybe it was useful in the past.
We could add the JCF binary to the current Docker image...

Probably can close now. I added an extra folder to the filter to reduce the noise and there haven't been too many commits.
In the past 6 months, there were around 60 commits to the filtered SVN repo, so it's fine to do the process manually when required. Of those, 25 were related to the CIM export, 8 were actions like version string or README updates, and several other commits simply do not apply to us anymore since the property system was rewritten. A handful of the remaining were related to bug fixes, and many of the rest are features under development (e.g. DynamicExp.pas).

Oh, and JCF doesn't correctly reformat many of the files.

Update: since v7 is retired and we will support the official OpenDSSDirect.DLL (DDLL subfolder), some tweaks, assuming Linux:
git checkout opendss-official-svn
git branch -D opendss-official-svn-v8
git branch opendss-official-svn-v8
git checkout opendss-official-svn-v8
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --subdirectory-filter Version8 --prune-empty -f
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --tree-filter 'rm -rf Source/CMD_Lazz Version7/Source/CMD_Lazz  Version8/Source/CMD_Lazz Source/CMD Source/CommandLine Version8/Source/CommandLine Version7/Source/CommandLine Source/EXE Version8/Source/EXE Version7/Source/EXE Source/Forms Version8/Source/Forms Version7/Source/Forms Source/ProgressEXE Version8/Source/ProgressEXE Source/epiktimer Version8/Source/epiktimer Source/ParallelLib Version8/Source/ParallelLib' --prune-empty -f

# fix some files with mixed line-endings
find ./ -name '*.pas' -exec sed -i 's/\r\n/\n/g' {} \;

# apply JCF
#...

git add Source JCFSettings.cfg
git commit -m "Reformat code"

git push --force-with-lease -u github opendss-official-svn-v8


[context] Consuming context with @consume() does not notify that the context has changed.

Which package(s) are affected?
Lit Core (lit / lit-html / lit-element / reactive-element), Context (@lit/context)
Description
When using @consume the changed properties Map does not reflect that the context has changed.
@consume({ context, subscribe: true })
_context = {}

willUpdate(changed){
  console.log(changed)
}

I expect changed to contain "_context" when the parent changes the context however nothing is provided.
I can't really tell that the update is based on the context being altered.
Reproduction
Simply press the button in the example and check the log. Expected the Map to contain "_context" but the Map is empty.
https://lit.dev/playground/#gist=a66aa11f0c04f7207a19050b5ea5a1a9
Workaround
The controller based API provides the callback configuration
_context
constuctor() {
  super()
  new ContextConsumer(this, {
    context,
    subscribe: true,
    callback(ctx) {
      this._context = ctx
      console.log('The context has changed')
    }
  })
}

Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
2.3.0
Browser/OS/Node environment
Chrome Version 120.0.6099.225 (Official Build) (64-bit)

So properties that hold context provided values with @consume() are not considered reactive properties so are not include in the changed properties of life cycles.
A workaround if you want to tie context to the element's reactive life cycle is to also add @state() decorator to it too:
@consume({ context, subscribe: true })
@state()
_context = {}

willUpdate(changed){
  console.log(changed) // this will now contain `_context` if a new context value is set
}

The posted workaround of using the ContextConsumer controller doesn't add it to the changed properties map, but works for a place to add additional logic when the a new context value is set.
Currently @consume() is a thin wrapper around the ContextConsumer controller where the callback function just syncs the class field with the context value.
We could consider expanding the consume decorator to also accept a callback option. I did find it a bit awkward that the object passed to @consume() is missing that compared to the option for ContextConsumer.

We could consider expanding the consume decorator to also accept a callback option. I did find it a bit awkward that the object passed to @consume() is missing that compared to the option for ContextConsumer.

The idea with the decorator is that it gives the controller a callback for you: one that sets the property. If you want your own callback, I think you might just want to use the controller directly.

I need to be able to tell that the context has changed in order to reset some other state. If I do this though a callback or through the lifecycle is not that important.
The fact that @consume does not  have a callback configuration leads me to believe that I would get notified of the change through the lifecycle but I am not. Even if it's not a bug per se it is perceived as a bug.
I would be happy with @consume() just having a callback configuration. We are actively working towards removing the ContextConsumer controller in favor of @consume() so I am not thrilled about having to add it again.

@filimon-danopoulos-stratsys what do you think about adding the @state() decorator along side the @consume() decorated field? This allows you to put all element level change detection in one place, within element lifecycles.
We had a bit of discussion around where the reactivity belongs and I think there's some history behind the separation of concerns here. The callback for the context subscription won't have information about the rest of the reactive properties (besides their current value, I suppose).

I guess we could use @state() but I think I would rather use the controller in that case. In the guidelines we have defined internally for writing Lit code we have defined @state() as  specifically private internal state and @consume() as injected state.
At least in our code the following "looks odd".
@consume({ context, subscribe: true })
@state()
_someContext

If I am not wrong altering _someContext manually will result in the consuming component being updated which in turn could lead to confusion as to why the provided state does not update.

Using the controller directly as shown in the original issue workaround seems like a lot when it could just be
@consume({
  context,
  subscribe: true,
  callback: () => { console.log('The context has changed'); }
})
contextValue;

Would something like this be super egregious? 6361432

I could see doing this. To match what you get with @state() I think we'd want to see new value and old value arguments.


recommendations for disabling features: Terminal, Debugger, Marketplace

Description
My organization would like to host a couple of these web ide servers, but have raised concerns around security. Is there any way to disable some of the more potent features of vscode, such as terminal, debugger, marketplace? Do you have any recommendations on how to approach this problem?
Related Issues

I'm digging through the VSCode docs now, and I'm not seeing anything that would allow that at a quick glance.
Has your team considered setting up the code-server instances to be run as limited permission users? I believe you might be able to manage the permissions in such a way where users would be unable to access a lot of things in the terminal, as well as render them unable to download additional extensions.

Thanks for the quick response and thanks for checking!
Indeed, we're going to restrict user permissions, outbound connections, as well as limiting instance cpu / ram.
Ideally, we would like to disable the user interaction with these components in the front end as well. Looks like it might be a long hard journey though :)

Maybe running it in separate docker containers would be a good option? If you build a custom docker image without a shell, access would be very limited, probably.
That would also facilitate limiting cpu and ram.

I don't think this issue is wholly solved by running the VS Code server in a separate container. For one, if we'd like the code server to run using HTTPS, we need the code-server launcher to have access to a valid SSL certificate. Even if the VS code server runs on a container that has no other valuable data, the certificate itself allows an attacker to impersonate this server and cause much more damage.
I would love to see either the ability to disable the terminal, or for the terminal to run as a different (more restricted) user than the one that launched code-server, and that doesn't even have access to that cert. Alternatively, allowing the terminal to re-authenticate the user would be useful too.

if we'd like the code server to run using HTTPS, we need the code-server launcher to have access to a valid SSL certificate. Even if the VS code server runs on a container that has no other valuable data, the certificate itself allows an attacker to impersonate this server and cause much more damage

Just do ssl termination in a reverse proxy

@fbartels A termination proxy is a good suggestion (which I'm going to try on my personal cloud VM), but I don't think that takes away from the feature request.
I would love to see code-server as a simple secure-by-default binary that you can run on your machine, rather than a tool that gives remote execution capabilities and requires installation and configuration of another web server to work securely.


Feature request: add search

It would be really nice to be able so search for a movie name. Otherwise great app!

Hello @Pauler221 thanks for the feedback. I tried integrating search in this app. I even have a branch here: feat/search
The thing is TMDB discover endpoint didn't have query parameter at that time. I have a commit with this message:
BLOCKED (You cannot have query parameter at tmdb discover endpoint)
I will read TMDB API documentation more and will inform you if there is another way around.

Hello @yasinkacmaz thanks for your comitment. The search function is  also something I will love to see.
I think maybe this endpoint https://developers.themoviedb.org/3/search/search-movies is what you are looking for ?
Keep up the good work !

@Didiloy I saw search-movies endpoint as well, thanks. With what I found so far, I have 2 options:

Add a search layout to appbar and go to search endpoint when a query is entered, otherwise, go to discover endpoint
Have a search button/layout and open a different search UI when clicked like Google does for example in Keep Notes.

Which one you would prefer?
A quick note: TMDB includes TV movies only for these two endpoints. TV series have their separate endpoint

I am more leaning towards the first approach, it may require some adjustments though. For example, filters should not be applicable to the search.
It will contain only movies now. I am planning to add TV series in the future.

Hey @Pauler221 @Didiloy, I've created a pull request for the search feature.  Here you can see the details: https://github.com/yasinkacmaz/jetflix/pull/196

That's really great thank you !


Craig simpson log main

Simpson's rule in logSpace. Passes tests, MCMC runs about 13,000 times faster. Down to 30ms iterations.

Excellent, looks good to me! Once the merging conflicts are resolved I will approve the pull request.


WIP - Add test with marshal/unmarshal with and without name sapce

Almost forgot this. I'm merging and then it may be removed later on.


Rigidbody with collider tracked to head?

Does anyone know how to have a rigidbody with a capsule collider placed directly under the camera / player head?
I've tried using the bodycollider object in the player prefab, however this doesn't work when gravity comes into effect as it isn't a parent of the rest of the rig.
Naturally, the next thing to try is adding the rigidbody and collider as a component of the player prefab parent rather than the bodycollider object. However, this results in an offset with the capsule collider, I have no idea what's causing it. It's in place if the headset is in dead center of the playspace. However, as you move outwards, the collider follows but at a much slower rate, so by the time you move a metre or so you have become completely detached from it.
Please help, I'm driving myself crazy trying to figure out what's wrong here.

I worked through this while building my game. I believe all that's needed for this configuration is

RigidBody attached to the top level Player prefab (and remove the existing one that's attached to the BodyCollider)
CapsuleCollider attached to the BodyCollider (which will update its own position to be underneath the head due to the BodyCollider script)

This isn't really the correct forum for questions like this. Please see: https://steamcommunity.com/app/250820/discussions/7/


[Feature request] Add MLC Web-LLM

Could be great to add support for MLC-AI Web-LLM
This allows to execute LLMs in the browser via WASM/WebGPU
https://github.com/mlc-ai/web-llm

Yes this would be incredible!

I don't know much the codebase of langchain, does the suggestions of the bot are correct ?
Does this would "require significant changes to the current architecture" as the bot says, or it may be easy implementing this, as for HF's transformers.js ?

@pacoccino Have you worked on this significantly? I am willing to pick this up.

@pacoccino Have you made significant effort towards this? I'm willing to pick this up.

I ended up adapting his PR on another repo here:
https://github.com/jacoblee93/fully-local-pdf-chatbot/blob/main/app/lib/chat_models/webllm.ts
Still a few rough edges but if you're down to refine it we'd welcome the addition!

Awesome. I'll take it on.

Hey! I tried running latest implementation that @jacoblee93 put together, but when compiling I am getting an import error for 'Engine' from the "@mlc-ai/web-llm" library from what looks like the webllm.ts file in the langchain-community library. The webllm.ts file appears to use 'webllm.Engine()' in initialization, yet when I looked into the "@mlc-ai/web-llm" library I notice they export a 'MLCEngine' class instead of 'Engine'. Is this a known issue/discrepancy with a resolution?

I think there was a breaking change in a recent WebLLM version a little while ago - what version did you install?

For the "@mlc-ai/web-llm" library, I tried a sweep from 0.2.38 thru 0.2.30, and several below - including some 0.1.x releases- but didn't find any change in the error. (I did the sweep for both "@langchain/community" 0.2.0 and 0.2.1 versions)


Update README

Our README should comply to our best practices.

Please have a look at f44373d2 and specify what you're missing.


How can I use the autoPlay property?

Plz help anyone?
thank you.

Have a look https://github.com/oliviertassinari/react-swipeable-views/issues/46#issuecomment-210997639.

How about Native?

@KevinHu2014 that's exactly the same. This HoC is logic pure and do no depend on react-dom nor react-native. I'm gonna improve the doc.


Does not support detecting paths other than ~/.steam/root/compatibilitytools.d (Steam installed via Flatpak, "global" paths, or STEAM_EXTRA_COMPAT_TOOLS_PATHS)

Add support for detecting the primary installation path without necessitating manual configuration if only one exists on the system.
Steam search order:

/usr/share/steam/compatibilitytools.d
/usr/local/share/steam/compatibilitytools.d
Colon-separated global paths in $STEAM_EXTRA_COMPAT_TOOLS_PATHS
~/.steam/root/compatibilitytools.d (steam install folder symlink)

(ref: https://github.com/ValveSoftware/steam-for-linux/issues/6310#issuecomment-511630263)

Note that this issue is only a problem if you don't manually configure the global variable sGE_INSTALL_PATH inside the script.
This issue is purely related to detecting better defaults.

https://github.com/toazd/ge-install-manager/commit/907fdb33ad934f0a24a01da7bf0a977cfc82877a
Now supports (on first install or if install_path=auto in the configuration file) detecting the following Steam installation paths:
$HOME/.steam/root
${XDG_DATA_HOME:-$HOME/.local/share/Steam}
/usr/share/steam
/usr/local/share/steam
$HOME/.var/app/com.valvesoftware.Steam/data/Steam
$HOME/.var/app/com.valvesoftware.Steam/.local/share/Steam
$HOME/.var/app/com.valvesoftware.Steam/.steam


Alarmo not appears in itegration menu

Alarmo Version
v1.8.4
HA Version
2022.2.3
Bug description
I've downloaded alarmo and card from HACS and rebooted home assistant. I go to integration menu and search alarmo but it not appears in list and i can't continue.

.
Steps to reproduce
No response
Relevant log output
No response

Duplicate of #387


Edit to enable multiple file upload per field

As discussed, here is my solution that enables multiple uploads on a single field.
My approach is to loop the array of files. When an entity hasMany images or photos the patchEntity creates an array of Objects, therefore the behavior loops the objects. But a single file upload is just a flat single array so in this case I push the array into another array so that the structure of the two upload types is matched. There are also some changes to how the path and filename are extracted from the data which is submitted, looks like you were operating on the object directly. In my edits you will see that I work on the var which the foreach creates.
Not sure my solution is the most elegant or efficient but it work and I am able to upload multiple files on the single field as well as single uploads when the relation is a hasOne.
Be interested to have your feedback! TY!

Please can you also fix the code so that it maintains backwards compatibility. The existing tests should still pass.
You'll also need to fix the PHP CS errors, by fixing the formatting of the code.
Please can you also resubmit your pull request to the develop branch.
I'll close this one, so you can make the changes, and submit to the develop branch.

Relates to #207

I've tidied the code as requested and added some logic. Hopefully it's now in better shape. For testing I used the following:
Single FIle Upload
Product hasOne ProductImage
$this->Form->input('product_image', ['type' => 'file']);
Multiple FIle Upload
Product hasMany ProductImage
$this->Form->input('product_images[]', ['type' => 'file', 'multiple' => true]);
In both cases the related entity was saved in 'product_images'.

Hi - I see that the latest version now support multiple image uploads, did any of my code make the final cut?

No sorry @spacebiscuit you didn't respond, so I made the amends myself.


repeat ie more lack repeating stuff chat.

blacklisting will support it too, so if someone tries to bypass the filter, they will be blacklisted under that type, either in guild level or global level
(this will not allow spam, use at your own risk)
Basically stuff like "balls" can be said here, and will use the default censorship again.

https://github.com/JDJG-Holding-Team/Sincroni/blob/e4c1f68404c8c2968429f697fae82559813b084b/utils/database/connection.py#L180
blacklist likes needs a new type.
https://github.com/JDJG-Holding-Team/Sincroni/blob/e4c1f68404c8c2968429f697fae82559813b084b/utils/database/models.py#L57
may add more to global.
update this for sure:
https://github.com/JDJG-Holding-Team/Sincroni/blob/e4c1f68404c8c2968429f697fae82559813b084b/utils/database/models.py#L70

This will require updating a bunch of references with blacklist.

https://github.com/JDJG-Holding-Team/Sincroni/commit/3ea74debf44306b2288678dee3cc3874ea68ffe5
This should be addressed at least here.

Done with repeat, at least i Think so?


Detect other operators

https://issues.redhat.com/browse/AUTH-136
This Pull Request introduces a mechanism for detecting other operators installed in the cluster. The discovery mechanism scans for predefined Deployments (I'm open for better ideas).

/hold
Needs some more testing. Will unhold when ready.

/hold
Putting this on hold as we need to agree how to report the status.

/unhold
Together with @s-urbaniak we decided to go forward with this one.

Closing this as we decided to push this responsibility to OLM. Once we add CRDs into the Bundle, OLM will automatically detect other owners of the CRDs.


UI: "Read settings from OVA" is shown before Format=OVA is selected.

Enhancement Request / Bug

Minor enhancement with VMware/OVA format - to actually make sense...
When hypervisor is chosen - the filed "format" is still NOT populated (OK, fine), but there is by default the "Read settings from OVA" slider available - this should also be hidden until the Format=OVA is selected (seems like the correct solution - because in future we might support other formats as well)
OR
If we keep the default to show "Read setting from OVA" after the hypervisor=VMware is selected, then let's also populated automatically the format=OVA when "Read settings from OVA" is checked - short video:
http://somup.com/cr12FxqgmO

@nvazquez can you explore if it's a quick UI fix?

Fixed, thanks.


Change default location of ANCM debug logs in site extensions

Based on docs conversation: https://github.com/aspnet/Docs/pull/9180#discussion_r227580128, we should remove the value attribute which would change the default log location to %HOME%\LogFiles\aspnetcore-debug.log. https://github.com/aspnet/AzureIntegration/blob/master/extensions/Microsoft.AspNetCore.Runtime.SiteExtension/applicationHost.xdt#L13. Also amcm is misspelled, but that will be removed 😄

That file is not used anymore and debug setting is removed:  https://github.com/aspnet/AspNetCore/blob/master/src/SiteExtensions/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/applicationHost.xdt


Shelljs

Closing this because I don't see an actual question or bug report. Please file a new issue (with all template fields completed).


nested filters can't be handled because of bug in reg-ex

The Java OData Generator sometimes generates and filter strings which are nested like this:
(((a eq '1') and (b eq '2')) and (c eq '3'))

In odata-helper.js this filter is split into
((a eq '1')
(b eq '2'))
(c eq '3'))

which do not match the regular expressions in applyFilter() because these can only handle one open or close parenthesis.

fixed by #63


Documenting FOCUS | Es: FOCUS :[R]#1:[0]App

Can You please document the synopsis FOCUS logs actually present in the console?
Example:
FOCUS :[R]#1:[0]App
Which do the square brackets mean?

It represent the path to the the component that has focus: https://github.com/WebPlatformForEmbedded/Lightning/blob/a6a83d35ceaa4fe5edaa033130bd9c2d75c7ab58/src/tree/Element.mjs#L1108
[R]=> means root
[0..n] => Means child index
We will add this to the documentation


Catalog - Location plugin

location plugin is different on iOS and Android (a bit more advanced on Android)
There was some errors when merging the location plugin :

[ ] web master should work for both platforms
[ ] web develop should work with latest android version
[ ] android master should have same behavior that iOS
[ ] android develop should have new functionnalities
Android Catalog sample submodule for web part should changed accordingly
Android Catalog sample submodule for android part should changed accordingly
Web Catalog sample submodule for web part should changed accordingly
Web Catalog sample submodule for android part should changed accordingly

added to 0.5.1 and master today


Remove unused classes

Remove many classes that are generated by Thrift that are not used
anywhere.

LGTM.

Current coverage is 64.46% (diff: 100%)

Merging #779 into master will increase coverage by 0.02%

@@             master       #779   diff @@
==========================================
  Files           739        739
  Lines         34601      34596     -5
  Methods           0          0
  Messages          0          0
  Branches       5327       5326     -1
==========================================
+ Hits          22297      22303     +6
+ Misses        10743      10734     -9
+ Partials       1561       1559     -2

Powered by Codecov. Last update f145bdf...fd2009b


Include --native-subdirectory support

This should help in publishing libs/headers in appropriate folders. Helps cross compilation support as well.
Note The CI should pass once https://github.com/dotnet/cli/pull/675 is ready to go.
Cc @gkhanna79

@dotnet-bot test this please

@dotnet-bot test this please