Panic when connecting to the result of gum filter

What happened?
When I execute:
sesh connect $(
        sesh list -i | gum filter --limit 1 --placeholder 'Pick a session' --height 60 --prompt='⚡'
)

within a tmux session. I expect the same behaviour as when I run it as part of alacritty/tmux keybinding but I get a panic saying out of bound exception
Version
sesh version 1.1.1
Relevant log output
sesh connect $(
sesh list -i | gum filter --limit 1 --placeholder 'Pick a session' --height 60 --prompt='⚡'
)
panic: runtime error: slice bounds out of range [4:3]
goroutine 1 [running]:
github.com/joshmedeski/sesh/connect.Connect({0x16ced2f5d, 0x3}, 0x7?, {0x0, 0x0}, 0x0?)
/home/runner/work/sesh/sesh/connect/connect.go:21 +0x2f4
github.com/joshmedeski/sesh/seshcli.App.Connect.func1(0x140000fd958?)
/home/runner/work/sesh/sesh/cmds/connect.go:38 +0x14c
github.com/urfave/cli/v2.(*Command).Run(0x14000130160, 0x140000aa480, {0x1400009e6c0, 0x3, 0x3})
/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/command.go:279 +0x754
github.com/urfave/cli/v2.(*Command).Run(0x14000130580, 0x140000aa340, {0x140000aa040, 0x4, 0x4})
/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/command.go:272 +0x964
github.com/urfave/cli/v2.(*App).RunContext(0x1400012c000, {0x1031612d8?, 0x1032ddac0}, {0x140000aa040, 0x4, 0x4})
/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:337 +0x534
github.com/urfave/cli/v2.(*App).Run(0x1030b7f61?, {0x140000aa040?, 0x0?, 0x0?})
/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:311 +0x3c
main.main()
/home/runner/work/sesh/sesh/main.go:14 +0xb0
Reviewed

[X] Reviewed existing issues and made sure this bug has not already been submitted.
[X] I have read the documentation and understand how sesh works before submitting this bug

Can you show me your tmux keybinding specifically?

Can you show me your tmux keybinding specifically?

I was not running it as part of a tmux keybinding but as part of a terminal script

This is due to sesh list -i pre-pending the nerd font icon in front of the path, causing sesh connect to try to look for a path with an icon in front of it. If you remove -i in your command, the command will work fine.

tmux for some reason does not have problems with the prepended icon as I saw this behavior as well (not exactly sure why, it should still panic since the command passed to sesh connect still contains the icon).

That does make sense it's odd about it not happening when calling it through tmux but I guess the change needed is here
https://github.com/joshmedeski/sesh/blob/72f844199fef95b8cce388bcac795d933ae09469/cmds/connect.go#L31
we need to split the session name and pick the last part or something like that. I can raise a quick fix for this

actually that's what in theory we are doing after 🤔
func Connect(
	choice string,
	alwaysSwitch bool,
	command string,
	config *config.Config,
) error {
	if strings.HasPrefix(choice, icons.TmuxIcon) || strings.HasPrefix(choice, icons.ZoxideIcon) || strings.HasPrefix(choice, icons.ConfigIcon) {
		choice = choice[4:]
	}

so the reason it's failing is because some shells sends the response in a funny way
sesh via  v1.22.3
 go run github.com/joshmedeski/sesh connect  frontier

sesh via  v1.22.3
 go run github.com/joshmedeski/sesh connect " frontier"

with the current version the first way it does not work because the icon and the session name are different args but in the second one it's only one and the strings.HasPrefix can catch it.

Just raised a PR for this, if you like the solution I can add some tests!
https://github.com/joshmedeski/sesh/pull/116

Cool, I'll look over the PR.
I recommend wrapping commands in quotes so it's one argument. There are examples in the README for wrapping quotes from a tmux command.

Nice catch. I see what's going on now.
sesh connect "icon_placeholder frontier" passes the entire string "icon_placeholder frontier" as one argument to sesh connect so it handles the strip properly
sesh connect icon_placeholder frontier gets parsed as 2 arguments so the code panics when trying to strip the first argument (which is the icon)`
I guess the proper way to call it in the CLI is using
sesh connect "$(
sesh list -i | gum filter --limit 1 --placeholder 'Pick a session' --height 60 --prompt='⚡'
)"

Yep, we may change the behavior soon but for now connect command expects one argument, so wrapping the sesh list in quotes is best.

👋🏻 @joshmedeski this bug was re-introduced as part of v2
 sesh connect $(sesh list -i | gum filter --limit 1 --placeholder 'Pick a session' --height 60 --prompt='⚡')
panic: runtime error: slice bounds out of range [4:3]

goroutine 1 [running]:
github.com/joshmedeski/sesh/icon.(*RealIcon).RemoveIcon(0x140001288c0?, {0x16f916fad, 0x3})
        /home/runner/work/sesh/sesh/icon/icon.go:55 +0x128
github.com/joshmedeski/sesh/seshcli.App.Connect.func1(0x1400018f958?)
        /home/runner/work/sesh/sesh/seshcli/connect.go:70 +0xb4
github.com/urfave/cli/v2.(*Command).Run(0x140001be2c0, 0x140001288c0, {0x14000111350, 0x3, 0x3})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/command.go:279 +0x754
github.com/urfave/cli/v2.(*Command).Run(0x140001be6e0, 0x14000128780, {0x14000128040, 0x4, 0x4})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/command.go:272 +0x964
github.com/urfave/cli/v2.(*App).RunContext(0x1400016a200, {0x1008088b8?, 0x100a05320}, {0x14000128040, 0x4, 0x4})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:337 +0x534
github.com/urfave/cli/v2.(*App).Run(0x10070cec7?, {0x14000128040?, 0x0?, 0x0?})
        /home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:311 +0x3c
main.main()
        /home/runner/work/sesh/sesh/main.go:14 +0xb0


calendar events: add RSVPs/attendee list

example event link: https://njump.me/naddr1qqjrzwpcx3zyzsee95my23pj956y2djy94pyzs6x95ursv6zxcmyzw29xuc52qg5waehxw309aex2mrp0yhxgctdw4eju6t0qgsv8e5c93le8ezrmx0j6gkr6m7xhfs5wkh3r08j38uj0faeqhllu5grqsqqql9nuj2mtp
what happens
Speaker is listed,  and host is listed.
suggestion

[ ] Add attendee list (in this case @tyiu RSVP'd and is not listed)

bonus points

[ ] Improve UX by listing npub's respective PFP. Currently only beginnign and end characters of npub string are displayed.

In case of larger events consider displaying e.g. five (5) attendees, and display "M, N, X, Y, Z, and 16 others are attending".
Consider applying e.g. fiatjaf npub's WOT rating across attendees, and display first attendee with highest WOT score, second with second highest etc.

I don't know if we should, that is more the task of real clients, we just try to display a single event at a time and doing that would require fetching multiple events and interpreting them in complicated ways (ok, not so complicated this time).
It's the same reason why we don't display replies to posts, for example.
But maybe we should consider that.

The particular use case I have in mind is having multiple ways for non-nostr people to learn about events. Ideally without having to download an app find more info about an event.
Right now I have no idea which website I can plug into my browser to investigate a calendar event outside njump. I imagine its the same for a non-nostr person.
See meetup front page for a particular geography:

There's a link to Flockstr on njump that you can click and browse.
Maybe we should add something like "see more information about this on these clients" @dtonon
This could apply to every event because dedicated clients will always have some better context.


PLANNER-431: Migrate upgrade recipes to AsciiDoc

The Upgrade recipe file should be removed too (important because never move anything without deleting the original - because then the rest of your time will still edit the original file and you'll have effectively forked it while bring a lot of pain when the mess is discovered years later. This can get so bad that often one is taken as canonical and the other's file changes are simply lost. Instead, delete the original and let git do it's job as a backup)
Actually let's not remove it, but empty it out completely and just put a link to the new URL location. This way it's still there in the download zip assemblies, so long-time users can still find it.

And I did just that already :) See e5f508d


Breaking change in Guzzle 6 when receiving a 204 No Content response with no body

After upgrading a client application to use Guzzle 6 (from our previous Guzzle 3), I've found an issue with how Guzzle handles responses with no content.
When we send a POST request to a specific API endpoint, we are expecting a 204 No Content response; in Guzzle 3, this is treated as successful. In Guzzle 6, the request is retried 3 times and then an exception is thrown:
[GuzzleHttp\Exception\RequestException]
  cURL error 0: The cURL request was retried 3 times and did not succeed. The most likely reason for the failure is that cURL was unable to rewind the body of the request and subsequent retries resulted in the same error. Turn on the debug option to see what went wrong. See https://bugs.php.net/bug.php?id=47204 for more information. (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)

This is happening because the API isn't just sending back an empty response - it's sending back no body content at all, as seen in the debug data I've captured:
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8765 (#0)
> POST /api/v1/general/controllers/3781220536545016/general/messaging/displayMessage HTTP/1.1
Host: <IP_ADDRESS>:8765
Content-Length: 70

* upload completely sent off: 70 out of 70 bytes
* HTTP 1.0, assume close after body
< HTTP/1.0 204 No response
< Server: FontHTTP/1.0 Python/2.4.3
< Date: Fri, 18 Mar 2016 09:36:18 GMT
< Access-Control-Allow-Origin: *
* Closing connection 0

That causes us to run afoul of the change made in https://github.com/guzzle/guzzle/commit/15557b1523bf556a7d2ca8915a8a18cc261f06d4#diff-d158f796e08161a3de3578283a4298daR90.
The issue here is in how Guzzle handles responses which are technically invalid, but have worked in previous versions. We're unable to fix the API we're communicating with - it's a third-party system - so an ideal solution for us would be for Guzzle to treat these empty responses in the same way as it did prior to the above change.
For now, we've downgraded to version 5.3.0, which doesn't have this problem.

I'm guessing the problem is that the server is closing the connection before sending the final "\r\n\r\n". This trips up the CurlFactory because it never knows when the headers are finished and doesn't create a response: https://github.com/guzzle/guzzle/blob/master/src/Handler/CurlFactory.php#L512.
Given a server that does send the final "\r\n\r\n", Guzzle is able to work correctly. I don't know what the solution to this would be, but I'm open to suggestions.

Yeah, that sounds like exactly what we're seeing. It may just be that we have to ask the third-party to fix their API.

Ok, I've been unable to get the results I was hoping for from PHP, so I've resorted to a very simple Python script.
This is available from the repo I've just created here: https://github.com/stephenorr/guzzle-1432-error-app
Hope that helps - I'll have a go at fixing the issue myself in a PR when I get chance.

Sweet! Thanks for putting that together, and thanks for offering to help fix this!

@stephenorr did you have the chance to take a look at this?
To be honest I am not 100% sure how to proceed with this. If the headers are not properly terminated we cannot be sure that the all the headers are actually properly received or the connection has just been terminated for any reasons. My concern is that accepting responses not complying with the HTTP spec might end up in a series of other weird bugs and issues. (Really network terminated connections with incomplete headers for instance)

Although these responses are technically invalid according to the HTTP spec, they were treated as acceptable by versions of Guzzle prior to 6.0

I think that was only a side effect. Technically this is not a breaking change not only because of semver, but also because of this being a side effect.
So I am not sure this is bug (at least in Guzzle) and if it can be solved.

Sadly, I've had no time whatsoever to try and take a further look at this.
I'm inclined to agree that it shouldn't be fixed; it is a regression, but as you say that's a side effect more than anything else. I'll try to work around it in our own application.

All right, I am closing the issue then. Thanks for bringing it up, hopefully it can serve as a reference in the future. If you find a workaround, let us know, maybe we can place it in the docs or just leave it here. Thanks again.

Hello! How can I process this situation?

[GuzzleHttp\Exception\RequestException]
cURL error 0: The cURL request was retried 3 times and did not succeed.

Is there some solution how to get response?

@sagikazarmark I think we need some way to work with such incorrect responses.

@itelmenko your problem is unrelated to this issue.
Looking at the error message, this is probably an environmental issue.
Please open a separate issue and provide details of your environment.
After googling your problem this popped up: https://stackoverflow.com/questions/46323867/url-error-0-the-curl-request-was-retried-3-times-and-did-not-succeed
Any chance it might be related?

@sagikazarmark problem cause is that server doesn't send the final "\r\n\r\n". And Guzzle stops with such error.


Windows GUI: Add LegacyStreamDisplay option

Note: I did not implement translations for this preferences option.

@cjee21 FYI I had to recreate the dfm file in BCB11 because it keeps crashing with your version. fix.
(and at the same time I remove the hint for reloading because it is not the only one and at long term I'll handle such issue differently)


Improve the loadingParams functionality in the API

Move the definition of the loadingParams Object, to simplify the code.

Add a unit-test, since none existed and the viewer depends on this functionality.

/botio-linux integrationtest

Sorry, I ran the tests here but I thought I were in an other PR...

/botio-linux test


Error on try run on godot 4.3

Hello,
im testing this asset on 4.2 but 4.3 have some improvements. But when I try to start on 4.3 the extension break with no log. there any way to enable it so I can at last see why it don't work on 4.3?

Thanks for reporting this issue.
I will try to re-compile with Godot 4.3 later today.

@edson-dev
I have closed the PR, but still need to create the release.
When the release is created, I will re-test it, and you'll be able to download the compiled libraries from the release page.
I need to update the asset on Godot Asset Store too, but that requires approval from Godot moderators, so it could take a couple of days before you can download it from the asset store.


Exception making migrations with a SortedOneToManyField

After adding a SortedOneToManyField to my model and running makemigrations I see the following exception.
Traceback (most recent call last):
  File "./manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/core/management/__init__.py", line 338, in execute
    django.setup()
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/__init__.py", line 27, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/apps/registry.py", line 108, in populate
    app_config.import_models()
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/apps/config.py", line 202, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 978, in _gcd_import
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load
  File "<frozen importlib._bootstrap>", line 950, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/Users/rconnon/src/test_project/test_app/models.py", line 9, in <module>
    class B (models.Model):
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/db/models/base.py", line 162, in __new__
    new_class.add_to_class(obj_name, obj)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/django/db/models/base.py", line 331, in add_to_class
    value.contribute_to_class(cls, name)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/sortedm2m/fields.py", line 265, in contribute_to_class
    rel.through = self.create_intermediate_model(cls)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/sortedm2m/fields.py", line 410, in create_intermediate_model
    return self.create_intermediate_model_from_attrs(klass, attrs)
  File "/Users/rconnon/.virtualenvs/bin/django/lib/python3.6/site-packages/sortedm2m/fields.py", line 386, in create_intermediate_model_from_attrs
    base_classes = (self.base_class, models.Model) if self.base_class else (models.Model,)
AttributeError: 'SortedOneToManyField' object has no attribute 'base_class'

When converting a field from Django-sortedm2m to Django-sortedone2many, I encountered this error upon migration also.
Python 3
Django 1.11.6
django-sortedm2m 1.5..0
django-sortedone2many 0.2.2
You'll probably want to fix this, since most users coming from Django-sortedm2m are going to experience this.

Even deleted the old sortedm2m field via a migration, and making a new migration won't work. That's no good.

I'm probably just going to axe sortedm2m and make a weight/page column and sort through that. Can't deal with the headaches.


VIT - S46878467

I had an approved late submission of 1 week, submitting on time. Regards

This is an initial inspection, no action is required at this point
Difficulty: Hard
Readme:

Missing model details. Need to explain what the model structure is and how it works to show your understanding of it.
Only the test accuracy plot is shown. No training accuracy and validation accuracy.

Commit messages: good, need more detail on which has been modified instead of just uploading files.
Code:

Uses Vision transformer
Comments mainly in the model design. Less comments in the data loader training loop and prediction file.
Good design

Functionality/Performance:

No patient-level split
Model is overfitting
Accuracy is only 0.53

General comments:
PR is in the main branch
Solves the problem appropriately although performance is poor
No patient-level split so the model is overfitting. Also need to do some hyperparameter search which hasn't been shown in the report.

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks missing -1
Recognition Problem
Solves problem poor performance < 0.6 -1
Driver Script present
File structure present but code needs to be in own folder -2
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage, no patient level split -1
Difficulty: Hard
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe acceptable, no refs -1
Model/technical explanation missing -1
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in InCorrect Branch) -2
Feedback required, need to move code into own folder and use correct branch -2
Request Description minimal -1

Feedback marks possible +2 if the requested changes are made (see above).


Bump version to 2.1.14

@bricelam - can you merge this PR (branch is protected)

I'm the Brice you're looking for 😈

Brice is disguise.

Let's be honest, Doug handles most of my merging these days since I blocked @dotnet-maestro-bot


Removing need for ReorientTetMesh [no-tet-reorder-dev]

This PR adds a DofTransformation class which performs a linear mapping of degrees of freedom on triangular faces to enable Nedelec basis functions to align properly regardless of the relative orientation of the elements.
With the addition of DofTransformation, the methods [Par]Mesh::ReorientTetMesh are no longer needed.  This PR currently comments out these methods rather than removing them.  Unless someone makes an argument for keeping them in the library I think we should remove these methods before merging this PR.
The test_eigs.cpp and test_eigs_nd.cpp programs were used to validate the new DoF ordering scheme for all triangle face orientations at a variety of basis function orders.  These programs don't need to be part of this PR but they may be useful as part of the test suite.  Edit: a version of test_eigs.cpp has been added as a unit test in tests/unit/fem/test_eigs.cpp.
The ex_nd_amr_p.cpp program can be used to test the new code in an AMR context.  This code implements an exact solution which is only valid on square or cube-shaped domains.  It can be run on any 2D or 3D mesh but the solution errors will only be correct on squares or cubes.
This PR has the potential to interfere with any code that uses high order Nedelec basis functions on tetrahedral meshes.  Unfortunately, we don't have that many relevant test cases in our examples/miniapps/unit tests.  I've invested a lot of time testing this branch with the unit tests, autotest, and custom examples but I know there are pieces of code that have not been covered by these tests.  I would really appreciate it if the reviewers could test this code further if they know of any suitable test cases.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1046
@mlstowell
@tzanio
@jakubcerveny + @psocratis
02/09/21
⌛due 02/23/21
⌛due 03/02/21

Hi @mlstowell, can we call Refinement method after a call to this new method? As we know, Refinement does not work after a call to ReorientTetMesh method, so high-order tetrahedral Nedelec elements can not be refined anymore.

Hi @mlstowell, can we call Refinement method after a call to this new method? As we know, Refinement does not work after a call to ReorientTetMesh method, so high-order tetrahedral Nedelec elements can not be refined anymore.

Yes, this new scheme should remove that restriction.

Hi @mlstowell, can we call Refinement method after a call to this new method? As we know, Refinement does not work after a call to ReorientTetMesh method, so high-order tetrahedral Nedelec elements can not be refined anymore.

Yes, this new scheme should remove that restriction.

Yeah, I've tried this branch and I can refine high-order tetrahedral elements now. Hope this branch can be merged in the next period. Thanks for your contributions.

@jakubcerveny, can you check if this resolves https://github.com/mfem/mfem/issues/1874?

Please update CHANGELOG

I checked #1874 and the unsupported orientation error is gone, however the solution is not right. I'm not sure if this is a problem directly with no-tet-reorder-dev or indirectly with something else.
When running mpirun -n 4 ./ex3p -m ../data/inline-tet.mesh -o 2 on a conforming mesh:

When EnsureMesh(true) is called after loading the mesh:

Thank you Jakub!
@mlstowell ny ideas what can be wrong?

Thank you Jakub!
@mlstowell any ideas what can be wrong?

No, but I'll take a look at it.

Oh, one possibility is that this branch does require re-linking or perhaps rebuilding GLVis.

It seems I had only tested conforming AMR with tetrahedral meshes.  There could be any number of things in the non-conforming case that need addressing.  Where do we begin?
I have modified the ex_nd_amd_p.cpp test code so that the user can switch between conforming and non-conforming simplex meshes.  The conforming case seems to run fine both in serial and parallel.  The non-conforming case seems to work correctly in serial but not in parallel.
I'll try to look into this further but if you have any suggestions, @jakubcerveny , I'd really appreciate your insights.

@jakubcerveny , while stepping through the code in a debugger one line caught my eye:
https://github.com/mfem/mfem/blob/d2d8908df3e4ab3836cc0752a85bc680aa487ebf/fem/pfespace.cpp#L173
I think this will over count the ghost face dofs on a tetrahedral mesh.  Could this be a problem? Do we need to loop over faces and check the element type of each face (thinking ahead to prism meshes)?

This should be fine IIRC. Since the ghost DOFs are not real, I cheated a bit when supporting triangular faces and reserved more ghost DOFs than necessary... It does bug me though that the NC tets are broken, I think they used to work

This should be fine IIRC. Since the ghost DOFs are not real, I cheated a bit when supporting triangular faces and reserved more ghost DOFs than necessary... It does bug me though that the NC tets are broken, I think they used to work

I'm sure we can get it working again. I just don't understand how face orientations are handled in the NC code.
I'm wondering now if the trouble might be here:
https://github.com/mfem/mfem/blob/d2d8908df3e4ab3836cc0752a85bc680aa487ebf/fem/pfespace.cpp#L2339
The identity matrix returned on the next line could probably encode the linear operator which is produced by the DofTransformation class. I'm not sure how to incorporate it here. Does this sound reasonable?

@mlstowell, I was busy with a paper review today but I'll study this branch tomorrow and will think about the NC orientations.

I have a general comment: there are a lot of similarities between this PR and the variable-order PR (#1817) in terms of the necessary generalizations in the FE space. The approach used here (as far as I understand it -- I have not looked at it very carefully) for the handling of arbitrary-oriented tets for H(curl) spaces, can also be used to handle the variable-order case. And vice-versa, the approach used in #1817 (once again, as far as I understand it) can be used here.
I think, it is worth considering the use of a unified approach to reduce the code complexity. Maybe, after some consideration, it will turn out that such unification will not require a major re-write of either of the two PRs.

@v-dobrev, maybe I am missing something but at first sight the two problems don't have that much in common IMO. var-order-space-dev is mostly about allowing multiple DOF sets on edges and faces and the constraints are then handled by the P matrix. Here GetElementDofs (and the like) return an additional transformation that needs to be done on a DOF vector, an element matrix, etc. It is true there is a conflict because in var-order-space-dof, GetElementDofs now returns an int, whereas here it's the DofTransform, but I'm sure we can fix that somehow.

The identity matrix returned on the next line could probably encode the linear operator which is produced by the DofTransformation class. I'm not sure how to incorporate it here. Does this sound reasonable?

This part of the code is only executed for NC interfaces (for slave edges/faces). I'm not saying there can't be a problem here but ex3p fails even if all interfaces are conforming. I would first look at pfespace.cpp:2133 (NeighborRowMessage::Decode) where shared face orientations are handled (the "NC" way).

@v-dobrev, maybe I am missing something but at first sight the two problems don't have that much in common IMO. var-order-space-dev is mostly about allowing multiple DOF sets on edges and faces and the constraints are then handled by the P matrix. Here GetElementDofs (and the like) return an additional transformation that needs to be done on a DOF vector, an element matrix, etc. It is true there is a conflict because in var-order-space-dof, GetElementDofs now returns an int, whereas here it's the DofTransform, but I'm sure we can fix that somehow.

In both cases what one needs to do is match dofs on faces/edges from different adjacent elements where the matching is not a simple permutation with optional sign flip. In the case of var-order-space-dev this is done by embedding the matching in the P matrix. In this branch/PR the matching is done by generalizing GetElementDofs to return the "matching matrix" as a DofTransform.

The identity matrix returned on the next line could probably encode the linear operator which is produced by the DofTransformation class. I'm not sure how to incorporate it here. Does this sound reasonable?

This part of the code is only executed for NC interfaces (for slave edges/faces). I'm not saying there can't be a problem here but ex3p fails even if all interfaces are conforming. I would first look at pfespace.cpp:2133 (NeighborRowMessage::Decode) where shared face orientations are handled (the "NC" way).

It looks like the Encode/Decode methods process one row at a time. Am I correct in thinking that each row corresponds to a single dof? If so, I'm not sure how to proceed.  I'll need to process triangular face dofs in pairs so that I can form the necessary linear combinations.

In both cases what one needs to do is match dofs on faces/edges from different adjacent elements

This may be true formally, but I don't see a practical consequence. Matching adjacent shapes with AMR style constraints would substantially increase the number of DOFs, and using DofTransformation for AMR would require a complete overhaul of the NC AMR in (Par)FiniteElementSpace. I still can't see much overlap between var-order-space-dev and no-tet-reorder-dev.

@mlstowell you are right, the DOFs are processed one by one, it's a different style from the conforming code. I don't think there is a quick solution, perhaps we should just disable ND spaces on NC tets for the time being (by checking and stopping with MFEM_VERIFY) and resolve the problem separately.

@mlstowell you are right, the DOFs are processed one by one, it's a different style from the conforming code. I don't think there is a quick solution, perhaps we should just disable ND spaces on NC tets for the time being (by checking and stopping with MFEM_VERIFY) and resolve the problem separately.

I'm certain that I'll need your help with that. Unfortunately, I suspect this feature will be needed. Do you think you'll have time to take a closer look at this anytime soon?

In both cases what one needs to do is match dofs on faces/edges from different adjacent elements

This may be true formally, but I don't see a practical consequence. Matching adjacent shapes with AMR style constraints would substantially increase the number of DOFs, and using DofTransformation for AMR would require a complete overhaul of the NC AMR in (Par)FiniteElementSpace. I still can't see much overlap between var-order-space-dev and no-tet-reorder-dev.

The practical consequence is that we are adding two different solutions to the same problem -- this is unnecessary complexity.
I agree that handling NC AMR (with its potential long-range dependencies) using DofTransformation will not be practical and that is not what I'm talking about.
What I'm talking about is the local mappings between adjacent elements (think conforming mesh). In var-order-space-dev these local mappings go in the P matrix (in the decomposition A=P^T G^T B^T D B G P, see https://mfem.org/performance) while in this branch they go in the G matrix, or you can think of them as an additional matrix between G and P. Making G non-boolean or adding another matrix between G and P has implications for all assembly levels and their implementation. Of course, adding NC AMR on top of this makes things even more complicated. (Also, what if in the future we want to support variable-order Nedelec spaces on tet meshes?) That is why I'm proposing we take some time now to consider these choices and how they will impact us in the future.

I'm certain that I'll need your help with that. Unfortunately, I suspect this feature will be needed. Do you think you'll have time to take a closer look at this anytime soon?

I think I can help, but have to talk to Tzanio first.

What I'm talking about is the local mappings between adjacent elements (think conforming mesh). In var-order-space-dev these local mappings go in the P matrix while in this branch they go in the G matrix, or you can think of them as an additional matrix between G and P.

Right, but matching the shapes with the P matrix will substantially increase the size of the "cut" space, basically all interfaces (even conforming) would become cut, can we afford that?

After talking with Tzanio I think I finally understand @v-dobrev's idea. Since the problem only occurs on Nedelec triangular faces of high enough orders, it makes sense to pay the (hopefully not too high) price of disconnecting all such triangular faces and constraining the two sides by the P matrix in the same style as the hp faces in var-order-space-dev (just choose the "true" side and "interpolate" the other). This would save us all the extra code that needs to be added after each call to GetElementDofs (and similar). It is of course another complication for the P matrix construction code but at least the complication is localized. We would probably get in trouble with code that does averaging of discontinuous functions on such faces but I tend to like the idea. Is my understanding correct?

So, the proposal is to treat all triangular face dofs for Nedelec elements as a special case in the FiniteElementSpace. Does anyone have time to implement this? I would volunteer but I don't fully understand what would need to be done nor how long it might take.

Another possibility to make this PR more palatable might be to create GridFunction::Get/Set/AddElementVector methods which could hide the interactions with the new DofTransformation class (and similar methods to the BilinearForm class). This would also reduce code duplication in existing MFEM classes.

I think it will be most productive to discuss any potential changes (related to unification with https://github.com/mfem/mfem/pull/1817) in a telecon.

Here is a recent paper that has some relevant discussion: https://arxiv.org/pdf/2102.11901.pdf

Here is a recent paper that has some relevant discussion: https://arxiv.org/pdf/2102.11901.pdf

If I understand this correctly the approach the paper is advocating is to create the same DofTransformation object that I implemented in this branch which they call M, see equation 6. In section 3.4 they propose applying this transformation operator "at cell level during the finite element assembly process". This is precisely what this branch does. They also state that while M could be implemented as an assembled dense matrix this is typically not necessary. This also agrees with the implementation of the DofTransformation class.
The only difference I see between the paper's proposed method and the method in this branch is the way that entity orientations are determined. The paper proposes setting up a convention for the orientation of each entity type based on global vertex indices. MFEM, on the other hand, uses orientations determined by conventions inherited from the reference elements. As an MFEM mesh is traversed, the orientation of an entity, the first time that entity is encountered, becomes the global orientation for that entity.
  As I understand it, MFEM requires that all shared faces must have outward pointing normals so that GLVis can display a single mesh partition as if it were a serial mesh. This means that shared faces have normals which point outward from each partition. As a consequence the DofTransformation needs to be applied during parallel assembly, in the P matrix, rather than during element level assembly.
Clearly this branch takes a hybrid approach where some face orientations are handled at the element level and some are handled in P. This is an unfortunate complication. I tried to implement a version where all orientations were handled at the element level but this violated the assumption made by GLVis. I remember discussing this with @tzanio at the time and I was advised to not mess with the GLVis assumptions (I'm paraphrasing here). I believe the approach proposed by @v-dobrev is to handle all face orientations with the P matrix. I like the fact that this would not be a hybrid approach in the sense that all faces would be handled in the same manner. However, it would require building and applying a P matrix for a Nedelec field of order >= 2 when there are triangular faces present (even in serial).

@mlstowell, @psocratis and @v-dobrev -- can you please review the proposed alternative in #2145?

This should be ready for review again. Thanks @mlstowell!

@mlstowell, I see an assertion failure when testing the Hcurl projection problem with ./rates -m ../../data/inline-tet.mesh -sr 1 -prob 1 -o 2 in ./tests/convergence.  I also tested on master after adding mesh->ReorientTestMesh() in rates.cpp and it works fine. Same issue with the parallel case (prates.cpp). Here is the output of the debugger.
lldb -- ./rates -m ../../data/inline-tet.mesh -sr 1 -prob 1 -o 2
(lldb) target create "./rates"
Current executable set to '/Users/petrides1/Work/software/mfem/tests/convergence/rates' (x86_64).
(lldb) settings set -- target.run-args  "-m" "../../data/inline-tet.mesh" "-sr" "1" "-prob" "1" "-o" "2"
(lldb) r
Process 56621 launched: '/Users/petrides1/Work/software/mfem/tests/convergence/rates' (x86_64)
Options used:
   --mesh ../../data/inline-tet.mesh
   --order 2
   --problem 1
   --sigma -1
   --kappa -1
   --jump-scaling 1
   --serial_ref 1
   --visualization

Assertion failed: (height == y.Size() && width == x.Size()) is false:
 --> incompatible dimensions
 ... in function: virtual void mfem::DenseMatrix::Mult(const mfem::Vector &, mfem::Vector &) const
 ... in file: linalg/densemat.cpp:183

Process 56621 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fff2041392e libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fff2041392e <+10>: jae    0x7fff20413938            ; <+20>
    0x7fff20413930 <+12>: movq   %rax, %rdi
    0x7fff20413933 <+15>: jmp    0x7fff2040dad9            ; cerror_nocancel
    0x7fff20413938 <+20>: retq
Target 0: (rates) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fff2041392e libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fff204425bd libsystem_pthread.dylib`pthread_kill + 263
    frame #2: 0x00007fff20397411 libsystem_c.dylib`abort + 120
    frame #3: 0x000000010003f459 rates`mfem::mfem_error(msg="Assertion failed: (height == y.Size() && width == x.Size()) is false:\n --> incompatible dimensions\n ... in function: virtual void mfem::DenseMatrix::Mult(const mfem::Vector &, mfem::Vector &) const\n ... in file: linalg/densemat.cpp:183\n") at error.cpp:183:4
    frame #4: 0x0000000100092943 rates`mfem::DenseMatrix::Mult(this=0x000000010bc05128, x=0x00007ffeefbfe7a0, y=0x00007ffeefbfe7c8) const at densemat.cpp:182:4
    frame #5: 0x00000001005fc389 rates`mfem::FiniteElementSpace::RefinementOperator::Mult(this=0x000000010bc04ff0, x=0x00007ffeefbfe918, y=0x00007ffeefbff230) const at fespace.cpp:1609:16
    frame #6: 0x000000010062c7ca rates`mfem::GridFunction::Update(this=0x00007ffeefbff230) at gridfunc.cpp:185:10
    frame #7: 0x0000000100006146 rates`main(argc=9, argv=0x00007ffeefbff548) at rates.cpp:244:9
    frame #8: 0x00007fff2045df5d libdyld.dylib`start + 1
    frame #9: 0x00007fff2045df5d libdyld.dylib`start + 1````

@mlstowell, I see an assertion failure when testing the Hcurl projection problem with ./rates -m ../../data/inline-tet.mesh -sr 1 -prob 1 -o 2 in ./tests/convergence. I also tested on master after adding mesh->ReorientTestMesh() in rates.cpp and it works fine. Same issue with the parallel case (prates.cpp). Here is the output of the debugger.

@psocratis, I'm not in the habit of running these codes but I should be. They will be very useful for something else I'm working on now. In any case, I think I tracked down the cause of the problem. Thanks!

https://github.com/mfem/mfem/blob/89301ba3cadbd95a513a54c35beea720a4cccaa5/mesh/mesh.cpp#L7642-L7647
Hey @mlstowell , would this map above still be needed?

Maybe this comment can be removed now as well
https://github.com/mfem/mfem/blob/89301ba3cadbd95a513a54c35beea720a4cccaa5/mesh/pumi.hpp#L88

Maybe this comment can be removed now as well
https://github.com/mfem/mfem/blob/89301ba3cadbd95a513a54c35beea720a4cccaa5/mesh/pumi.hpp#L88

I'm impressed that you even found that.

https://github.com/mfem/mfem/blob/89301ba3cadbd95a513a54c35beea720a4cccaa5/mesh/mesh.cpp#L7642-L7647
Hey @mlstowell , would this map above still be needed?

That is an excellent question. This member function and most of this class's member data are inadequately documented. I've tried to map out which member data are modified or accessed by which member functions in this class but it seems like a hopeless task. We could try commenting out this map and the code that populates and accesses it and see what breaks. However, I suspect we don't have sufficient test coverage to identify all the consequences of that removal.
We could expand this comment and mention that this map may no longer be needed.

I think it looks really good!

Thanks, @psocratis! I really appreciate all the feedback on this.

Merged in next for testing...

Please document in CHANGELOG

Re-merged in next for testing ...

I re-merged in next, but it looks like the last commit broke the build

I re-merged in next, but it looks like the last commit broke the build

Yes, the new deletion is duplicated if the RefinementOperator is created. This was caught by the unit tests but I didn't rerun these before committing. I pushed a fix (the unit tests now pass locally) and I'm waiting for the checks to pass.

I re-merged in next, but it looks like the last commit broke the build

@tzanio, it looks like the checks are passing now. This should be ready to re-merge. Sorry for the trouble.

Re-merged in next for testing ...

Re-merged in next for testing ...

Re-merged in next for testing ...


Hotfix: Moodle Email Syncing

:tada: This PR is included in version 4.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


params is deprecated

Getting this warning message when using nssm. Looks like params will no longer be a valid parameter name for a resource.
       Deprecated features used!
         Property `params` of resource `nssm` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:

A PR with params renamed to args would be welcome!

I wonder if set is a valid attribute name...

Or maybe commands?

Could always spell out parameters too. I'll put together a PR. I'm also looking at solving the idempotency issue in the other ticket as well.
Love this cookbook btw. Saved my bacon while trying to install consul-template.

Parameters would be fine.  Thanks for the kudos!

Released v3.0.0

I can't work out what happened, but this change seems to have gone missing in v3.0.0.
The master version of the resource still has params (https://github.com/dhoer/chef-nssm/blob/master/resources/default.rb#L7) and that's what I'm seeing in the source when I download 3.0.0 from the supermarket.

Looks like merge didn't go so well.

I will try to get this back in

v3.0.1 fixes this


Fix empty configuration file cases

Feel free to hijack this PR if it needs correction before merge as I'm on vacation starting tomorrow.

:+1:


Add a function to decoding.py that returns xarray

This will make decoding work in very similar way to the rest of the package and will simplify the decoding example.

done


Memory cannot handle 2 reads at the same addres during the same clock cycle

Failing test:
#[test]
fn rcomb_base() {
    const X_PTR: u64 = 42;
    const Z_PTR: u64 = 142;
    const A_PTR: u64 = 1142;
    let asm_op = "begin rcomb_base end";

    let stack_inputs = [1,2,3,4,5,6,7,0,0,X_PTR, Z_PTR, A_PTR];
    let test = build_test!(asm_op, &stack_inputs);
    let _last_state = test.get_last_stack_state();
}

Interesting! I though we used it for Falcon signature verification - but I guess we do not.

Interestingly, we do

From the error I am seeing, I think might be because the memory read is happening at 0-th cycle and hence we are getting an subtraction with overflow. In the other tests, with overwhelming probability, this will not happen.

From my understanding, the overflow is triggered when we attempt to read the same memory location in the same cycle - not terribly useful, but could happen due to user error (as mentioned in https://github.com/0xPolygonMiden/miden-vm/pull/1561#discussion_r1826016543)

Are you sure that the input stack is in the right order for RCOMBBASE?

From my understanding, the overflow is triggered when we attempt to read the same memory location in the same cycle - not terribly useful, but could happen due to user error (as mentioned in #1561 (comment))

Yeah, maybe it is worth adding a disclaimer to the op to specify that the Z_PTR and A_PTR should be different

Yes, the stack input is not in the expected order i.e., the pointers are not in their correct place. This explains why Falcon tests didn't raise any errors as when the pointers are provided in their right place on the stack and the Z_PTR and A_PTR are different then everything should work well.
Thus the problem is only when by mistake the two aforementioned addresses are equal and this is what should be addressed here and in any future ops.

Thus the problem is only when by mistake the two aforementioned addresses are equal and this is what should be addressed here and in any future ops.

Yup, exactly.

Yeah, maybe it is worth adding a disclaimer to the op to specify that the Z_PTR and A_PTR should be different

I don't think so - they're obviously different from the documentation (i.e. one is randomness, the other is $T_i(...)$ etc). As mentioned a few times here, this issue here only addresses the case where there's a use error with RCOMBBASE (and potentially future ops).


Remove sbt 0.13.x support and syntax improvements

Removes sbt 0.13.x support since its ancient, syntax improvements, use sbt slash syntax and also use lazy val's

Why not replace
https://github.com/sbt/sbt-osgi/blob/0973c606b8d4352f94dde26f7c0605008a3a42b8/src/main/scala/com/typesafe/sbt/osgi/SbtOsgi.scala#L38
with
https://github.com/sbt/sbt-osgi/blob/0973c606b8d4352f94dde26f7c0605008a3a42b8/src/main/scala-sbt-1.0/com/typesafe/sbt/osgi/SbtCompat.scala#L9
and delete src/main/scala-sbt-1.0/com/typesafe/sbt/osgi/SbtCompat.scala?
Also that lines needs to be changed to the newer sbt slash syntax anyway.

@mkurz Done, thanks

@mkurz Sorry for pinging you but can you review this PR? I have another fix coming through and I coded it against these changes (see https://github.com/apache/incubator-pekko/issues/1039#issuecomment-1909123323 for context)


After running npm install and then ng new, It says teams-angular collection not found

command:  ng new teams-app --collection teams-angular
Output: An unhandled exception occurred: Collection "teams-angular" cannot be resolved.
See "/tmp/ng-VFFe60/angular-errors.log" for further details.

Hi! Did you run the command npm install -g teams-angular before trying to use the collection?

I am having the exact same issue.  Yes, I did run the command npm install -g teams-angular.

Could you give more details about your configuration? Like OS/Version, Node and npm version, how you installed Node (NVM or other) and the content of your angular-errors.log file?

Clean install of npm appeared to fix the problem.

I am having same issue and clean install of npm didn't help.
I am using windows 10 with node 14.17.6 and npm 6.14.15 and also tried with node 16.14.0 and npm 8.5.5 (using the nvm 1.1.9)
[```
error] Error: Collection "teams-angular" cannot be resolved.
at SchematicEngineHost.resolve (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\tools\node-module-engine-host.js:75:19)
at SchematicEngineHost._resolveCollectionPath (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\tools\node-module-engine-host.js:80:37)
at SchematicEngineHost.createCollectionDescription (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\tools\file-system-engine-host-base.js:118:27)
at SchematicEngine._createCollectionDescription (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\src\engine\engine.js:162:40)
at SchematicEngine.createCollection (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\node_modules@angular-devkit\schematics\src\engine\engine.js:155:43)
at NewCommand.getCollection (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\models\schematic-command.js:147:35)
at NewCommand.initialize (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\models\schematic-command.js:66:37)
at async NewCommand.validateAndRun (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\models\command.js:121:22)
at async runCommand (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\models\command-runner.js:228:24)
at async default_1 (C:\Users\i.sinadinos\AppData\Roaming\npm\node_modules@angular\cli\lib\cli\index.js:70:31)

I added a note in the readme regarding this issue.
If you're having the same error, please try running these commands:
npm uninstall -g @angular/cli teams-angular
npm cache clean --force
npm install -g npm@latest
npm install -g @angular/cli teams-angular


Too coupled with NPM (for karma at least)

Since the webpack config is using npm_lifecycle_event it's impossible to run karma without the npm scripts.
I think it's better to have different webpack config files, one for each environment.
(I think this issue would help to someone to understand why can't run karma out of npm scripts and if you're agree i can try to do a PR)

I think they want this starter to be simple as much as possible. Check this https://github.com/preboot/angular2-webpack/pull/124

I'll move to webpack 2 soon and fix that
El 27 sept. 2016 1:02 PM, "Jon Concepcion"<EMAIL_ADDRESS>escribió:

I think they want this starter to be simple as much as possible. Check
this #124 https://github.com/preboot/angular2-webpack/pull/124
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/preboot/angular2-webpack/issues/194#issuecomment-249845156,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCZ1UElrwHVIInig9DU8kZujOoA6VIfks5quQXfgaJpZM4KHemd
.

I moved, I didn't fix. I will fix it shortly tho in an experimental branch.


#login issue fix

Just check this.
https://github.com/Grover-c13/PokeGOAPI-Java/commit/dcaa79355792ab260a5f6534d081e72b6549ef55

From just the link I can conclude that this is Java, where this bot is written in Python, so I dont think its too applicable, unless the method is converted to Python.

Literally, all that guy did was add delay between the requests.
This is not applicable here, since there is no issue with login other than issues with Pokemon GO servers, which will automatically be retried as of a recent commit to the dev branch.
You should be ok to close this issue now.


Minor improvements (string interpolation in the C# example, removes some blanks)

Description
It does change the C# example to use string interpolation instead of string.Format and removes some blank lines that are indicated by visual studio code.
Which issue(s) this PR fixes
#127
#126
How Has This Been Tested?
I tested it on my local machine.
Types of changes
Minor improvements.

Hi, just to check is<EMAIL_ADDRESS>a valid email?

How Has This Been Tested?

Please show some evidence of the testing.

Hi, just to check is<EMAIL_ADDRESS>a valid email?

Hi. Yes, this is a catch-all address I use to track spam send to my addresses.

How Has This Been Tested?

Please show some evidence of the testing.

Yes. I deployed the faas-stack locally with your deploy_stack.sh.
Then I created a new directory. Copied the from the repo templates (I did not use template pull) into it.
Then I did a
$ faas-cli new --lang chsarp helloworld-new
$ faas-cli build -f helloworld-new.yml
$ faas-cli deploy -f helloworld-new.yml
$ echo "foobar" |faas-cli invoke helloworld-new
Hi there - your input was: foobar

I also did that for the python3 template.
$ faas-cli new --lang python3 helloworld-python
$ faas-cli build -f helloworld-python.yml
$ faas-cli deploy -f helloworld-python.yml
$ echo "foobar" | faas-cli invoke helloworld-python
foobar

I have not tested the arm ones but the only functional change is done to the csharp temlates. The other changes are just cosmetic changes.

How Has This Been Tested?

Please show some evidence of the testing.

Ah sorry, I accidentally pushed the close button.

Thanks for your PR


Identifying characters don't work on some occassion

Several combinations of character slot positions and/or whether they are selected or not makes them cannot be identified.
Here's what I found:

Character
Slot 1
Slot 2
Slot 3
Slot 4

Chongyun (on-field)
✅
❌
✅
✅

Chongyun (off-field)
✅
❌
❌
✅

Keqing (on-field)
❌
✅
❌
❌

Keqing (off-field)
✅
✅
✅
✅

Diluc (on-field)
❌
❌
❌
❌

Diluc (off-field)
✅
❌
❌
✅

Sucrose (on-field)
❌
❌
❌
❌

Sucrose (off-field)
❌
❌
❌
❌

Samples screenshot of identifying characters when Keqing selected vs not selected:

Just tried v0.0.35, still the same.
Does the graphic setting affect this feature? Here is my setting. (Brightness is set to default)

I'm not using a filter or something like that.

Just tried v0.0.35, still the same.
Does the graphic setting affect this feature? Here is my setting. (Brightness is set to default)
I'm not using a filter or something like that.

Aha, your resolution may be too low, switch to a resolution of 1600 * 900 or more try it

I see.
Unfortunately, I can't try this.
1366 x 768 is the highest resolution I can set. 1600 x 900 doesn't even show up as an option.
And I just found out that the minimum resolution is mentioned on docs, so it's my fault for not realizing this.
Thx for the clarification.


CNPHI Export - Travel History

Incorrect mappings for travel history.
DataHarmonizer: destination of most recent travel (city)
is mapping to...
CNPHI: Country of Travel
DataHarmonizer: destination of most recent travel (country)
is mapping to...
CNPHI: City of Travel
BEFORE (DataHarmonizer format):

AFTER (CNPHI export):

Good catch. I'll fix today.


ansible-runner/ansible 2.9.12

Status
In-Progress
Related Issues
N/A
Description
Required container image for my Automation Rising 2020 SOAR Hackathon submission.
Two Python packages (ansible, and it's dependency docutils) do not pass verify_licenses.py. However I'm unclear if GPL is a approved OSI license type or not. it is not present in known_licenses.json nor approved_licenses.json.
My submission does not link to the Ansible python libraries, so I do not believe the GPL Automatic Inheritance applies to my submission (if that was a concern), and even if it did I intend on making my hackathon submission available to the community.
Using the python ansible module is merely a convenient way to get a specific version of Ansible install into the container that I have tested my work against. The Debian Buster ansible package is quite a few versions out of date from what I would like to use, but the Debian Bullseye is one patch level ahead. If use of the ansible python module is not allowed, I am happy to use the Debian ansible package as an alternative.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Serge Bakharev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@SergeBakharev Thanks for your submission. Please accept our CLA so we can proceed. See the comment: https://github.com/demisto/dockerfiles/pull/2772#issuecomment-700571555

@glicht Not sure it is saying that the CLA is not signed. I signed it when I submitted the PR, and if I re-visit the link it shows as signed for me. Is there something else I need to do?
https://imgur.com/a/VaeTSgk

@SergeBakharev your commit is not linked to your github user. See instructions here on how to fix: https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

Thanks @glicht . I've resubmitted the PR with the a fresh commit that is properly linked!


not found evidence_for_delex.json

python generate_inputs.py
Loading image_classes.json...
Loaded image_classes.json to <class 'dict'> object
Loading ../dataset/evidence_for_delex.json...
Traceback (most recent call last):
File "generate_inputs.py", line 27, in
data = load(path + 'evidence_for_delex.json')
File "~/MMConv/MMDST/utils/json_utils.py", line 41, in load
with open(path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '../dataset/evidence_for_delex.json'

Thanks, we have uploaded.


CB-22061 Multi AZ config in FreeIPA should be populated as part of environment creation

Multi AZ config in FreeIPA should be populated as part of environment creation
See detailed description in the commit message.

retest this please


refactor(localization_error_monitor): rework parameters

Description
Removed default parameters in the C++ codes in localization_error_monitor.
Tests performed
It is able to build localization_error_monitor locally.
It is also confirmed that the logging_simulator on the tutorial works fine.
Effects on system behavior
Less prone to unexpected behavior when parameter definitions are incomplete.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SKT-r Please fix the PR title refactor(localization_error_monitor): rework parameters.
I think that the correct title is  refactor(yabloc_monitor): rework parameters.


[ENH] test for two fit calls with different argument

The current test test_fit_idempotent did not catch the bug in https://github.com/alan-turing-institute/sktime/pull/1595 because the test checks two calls to fit with the same arguments.
This fails to catch the case where, for instance, the resulting estimator behaves like after the first, but not the second fit call.
A better test would call fit twice, but with different arguments.
The resulting estimator should behave like the estimator fitted only by the second fit call.
This should be a new test, or a change to test_fit_idempotent.

Hi, I would be glad to help with this. Is there anyone already working on it?

I don't think so, please feel free to go ahead! You should be able to use the _make_args helper functions to get this done easily.
@ltsaprounis, FYI


[Bug] A libcurl function was given a bad argument (68 MAXREDIRS)

Insomnia Version: v5.9.6
Operating System: Arch Linux (libcurl-compat 7.56.1-1)

Details
After updating libcurl I can no longer make request without receiving this message.
#558 might be relevant

This was reported by another user via email, is already fixed, and will be deployed this week.
As a temporary workaround, you can set max redirects to 0 (instead of -1) in the Insomnia preferences.

This is fixed now in v5.10.1


Contact Page

This form will help users to send messages directly to the GitHub support email.

Why do we need this?  I don't think it is necessary

Why do we need this? I don't think it is necessary

I think it will help users to get support directly and not to search for the specified contact page; also if they want to report any bugs or errors and are not familiar with git they can help.

I Understand. In this case I am the support and need to funnel things
through issues.  Ideas are welcome in how to do this without increasing the
maintenance burden
Cheers
On Sat, May 9, 2020 at 9:23 AM Keyur Patel<EMAIL_ADDRESS>wrote:

Why do we need this? I don't think it is necessary
I think it will help users to get support directly and not to search for
the specified contact page; also if they want to report any bugs or errors
and are not familiar with git they can help.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/github/covid19-dashboard/pull/384#issuecomment-626200654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALKJES5UVJDP7FKCP4NV23RQV7PNANCNFSM4M4BA6UA
.

I thought about this mroe and will reopen this PR while I think about how to integrate this into the page a bit more

I think what I'll do is just put a link to opening an issue on the About page, I spoke to some people and<EMAIL_ADDRESS>is not an appropriate mechanism to use here.
Thanks for the input, though!

Can you please tell me what email should be put up there so that I can fix it.

you need to open an issue there is no support email


fix: center contributors image

Hi,
Here's what's changing in a more visual way:

Mobile
Old:

New:

Desktop
Old:

New:

I hope this helps.
Best,
G.

Thank you @gokaygurcan !


False negative on org.hibernate:hibernate-validator:6.0.10.Final

CVE-2019-10219 might be false negative on library for org.hibernate:hibernate-validator:6.0.10.Final .
CPE- cpe:2.3:a:hibernate:hibernate-validator:-:::::::*
CVE Description:
A vulnerability was found in Hibernate-Validator. The SafeHtml validator annotation fails to properly sanitize payloads consisting of potentially malicious code in HTML comments and instructions. This vulnerability can result in an XSS attack.
<dependency>
    <groupId>org.hibernate</groupId>
    <artifactId>hibernate-validator</artifactId>
    <version>6.0.10.Final</version>
</dependency>

Appears to be caused by an incorrect affected software entry at the NVD. I've sent them a notice and am awaiting their response.

Should be resolved when today's updates in te NVD are propagated through their datastreams.

Solved by NVD analysis update


Comment removed from JSX even with --removeComments false --jsx preserve

TypeScript Version:  2.2.1 / nightly (2.2.0-dev.201xxxxx)
Code
a.tsx
/* comment */

    {/* comment */}

Expected behavior:
Output same as input.
Actual behavior:
a.jsx
/* comment */

;

Couple reason

We omit the empty JSX Expression so we may not need to emit the comment

"{" is not stored in tree so it will be impossible to get the comment out unless we store it some how


fix(lint/useTemplate): correctly handles parenthesized expressions and respects type coercions

Summary
Closes #1192.
useTemplate now correctly handles parenthesized expressions and respects type coercions.
It also fixes cases where the string literal was 'too deeply' nested, e.g.:
1 + (2 + "a")

-`${2}a`
+`${1}${2}a`

Test Plan
Tests included.
I can't think of any other edge cases. If you do, let me know!

Hi @n-gude, are you still interested in completing the PR?

@ematipico Yeah, I'm still trying to get one edge case right after rewriting the logic to avoid the double traversals. There were in fact a lot of double traversals...

Let us know if you need any help

Thanks, but I finally got it!
I noticed that the rule doesn't report expressions with an interpolated template literal and non-string expressions:
`a${1}` + 2;

Because the equivalent ESLint rule reports that case, I assume this is a bug, right?
I created a fix for that. Is it ok to put it in this PR or should I create another for that?

Thanks, but I finally got it!
I noticed that the rule doesn't report expressions with an interpolated template literal and non-string expressions:
`a${1}` + 2;

Because the equivalent ESLint rule reports that case, I assume this is a bug, right? I created a fix for that. Is it ok to put it in this PR or should I create another for that?

It is ok to include the fix. Also, It could be nice to open an issue to keep some trace of this.

Thanks for this fantastic contribution! This is just in time for the upcoming release ❤

@Conaclos Thank you for these detailed reviews! They really help me catch those things myself in the future (hopefully 😉).


Support multiple --config options in Git.clone

Makes opts[:config] in Git.clone accept an Array of = pairs
so that multiple --config options can be passed to the clone command.
A single config entry can still be passed as a String.
Signed-off-by: Marco Rüdisüli<EMAIL_ADDRESS>

Just here because I got the stale bot message, maybe a maintainer can merge or decline this? @jcouball

It would be nice with this PR being merged to next release.

Since I need to make a change or two to the implementation and documentation, I have re-implemented this PR in #653


Add Analytics Page

Add overall analytics page which shows progress of Top students as the website shows.
Features:

Display the Profile pics of Top Students.
Display other students in tabular form.

Maybe add some CSS styling to the table.

New Course Analytics Page added which shows Top 3 students profile pic and a table shows under 50 students.
Commit: 268e46e


Blade multiple subviews doesnt work

Laravel Version: 7.17.2
PHP Version: 7.4.5

Description:
I am including 2 subviews in my blade view and I see the first one repeated.
Steps To Reproduce:
I have the following views: views.zip
├── layouts
│   └── section.blade.php
├── sections
│   ├── one.blade.php
│   └── two.blade.php
└── welcome.blade.php

Sections one and two both extend the layout file, and welcome includes both one and two:
welcome.blade.php:
<!DOCTYPE html>
<html>
    <body>
        @include('sections.one')
        @include('sections.two')
    </body>
</html>

I just get the contents of one repeated:

I couldnt see a different way of doing this in the docs.

Using the @overwrite directive seems to make it work.
two.blade.php:
@extends('layouts.section')

@section('title')
    Two
@overwrite

@section('description')
    Info about section 2
@overwrite


Unable add Revision label of traffic 0% in Azure Container Apps

Please provide us with the following information:

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
I can’t add Revision label with Azure CLI in Azure Container Apps.
$ az containerapp revision label add -n dapr-frontend -g <rg name> --label staging --revision dapr-frontend--v2
Please specify a revision name with an associated traffic weight.

Revision traffic of "dapr-frontend--v2" is 0%.
But I can add Revision label to traffic 0% with Azure Portal.
https://docs.microsoft.com/en-us/azure/container-apps/revisions#revision-labels
Which specification is correct, CLI or Portal?
Steps to reproduct

2 container revision running.(100% / 0%)
execute Azure CLI.

@thara0402 , please verify that this is issue is resolved for you

@torosent
I succeeded in verification using v0.3.6.
Thank you so much.


Don't terminate search if begin_key doesn't fit (Fixes #33034)

Previously this code would continue onto the next iteration of the loop if the line was smaller in size than begin_key, meaning that a situation where begin_key.length() > end_key.length() would cause weird behavior with newlines. Now both the checks for begin_key and end_key are in their own condition and do not skip the entire iteration if they can't be found.
Fixes #33034

Thanks!


bug: change in the size of authWrapper

Describe the bug
change in the size of authWrapper in MediumCoreStyles and LargeCoreStyles file.

Closing as @Swrnv-qc is looking into this issue


Set up zuul

All travis builds are red right now.
You need to add SAUCE_USERNAME and SAUCE_ACCESS_KEY to Travis as detailed in https://github.com/defunctzombie/zuul/wiki/Travis-ci.
Personally, I prefer to add them in travis's repo settings page (contrary to zuul's docs) to keep your .travis.yml clean:

Ya I missed that this morning. They've been passing for a while now though: https://travis-ci.org/dekujs/deku/builds


issues on creating installer file on VS2017

Your code works well while creating normal exe file. But I want to create a setup file for my project so I added Visual Studio Installer --> Setup Project. Upon trying to build a setup file it came up with these warnings.

You may refer my cpp program here.

It's not a really trouble. You can disable it with it: https://stackoverflow.com/questions/12204116/strcpy-error-in-visual-studio-2012


Cannot read property 'match' of undefined

Version
4.5.7
Environment info
Environment Info:

  System:
    OS: Windows 10 10.0.19041
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.19.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 85.0.4183.121
    Edge: Spartan (44.19041.423.0), Chromium (85.0.564.68)
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-helper-vue-transform-on:  1.0.0-rc.2
    @vue/babel-plugin-jsx:  1.0.0-rc.3
    @vue/babel-plugin-transform-vue-jsx:  1.1.2
    @vue/babel-preset-app:  4.5.7
    @vue/babel-preset-jsx:  1.1.2
    @vue/babel-sugar-functional-vue:  1.1.2
    @vue/babel-sugar-inject-h:  1.1.2
    @vue/babel-sugar-v-model:  1.1.2
    @vue/babel-sugar-v-on:  1.1.2
    @vue/cli: ^4.5.7 => 4.5.7
    @vue/cli-overlay:  4.5.7
    @vue/cli-plugin-babel: ~4.5.6 => 4.5.7
    @vue/cli-plugin-eslint: ~4.5.7 => 4.5.7
    @vue/cli-plugin-router:  4.5.7
    @vue/cli-plugin-vuex:  4.5.7
    @vue/cli-service: ~4.5.7 => 4.5.7
    @vue/cli-shared-utils:  4.5.7
    @vue/cli-ui:  4.5.7
    @vue/cli-ui-addon-webpack:  4.5.7
    @vue/cli-ui-addon-widgets:  4.5.7
    @vue/compiler-core:  3.0.0
    @vue/compiler-dom:  3.0.0
    @vue/compiler-sfc:  3.0.0
    @vue/compiler-ssr:  3.0.0
    @vue/component-compiler-utils:  3.2.0
    @vue/preload-webpack-plugin:  1.1.2
    @vue/reactivity:  3.0.0
    @vue/runtime-core:  3.0.0
    @vue/runtime-dom:  3.0.0
    @vue/shared:  3.0.0
    @vue/web-component-wrapper:  1.2.0
    eslint-plugin-vue: ^6.2.2 => 6.2.2
    typescript:  3.9.7
    vue: ^2.6.12 => 2.6.12 (3.0.0)
    vue-cli-plugin-apollo:  0.21.3
    vue-cli-plugin-tailwind: ^1.5.0 => 1.5.0
    vue-codemod:  0.0.4
    vue-eslint-parser:  7.1.0
    vue-hot-reload-api:  2.3.4
    vue-loader:  15.9.3 (16.0.0-beta.8)
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.6.12 => 2.6.12
    vue-template-es2015-compiler:  1.9.1
    vue2-ace-editor: ^0.0.15 => 0.0.15
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
I can post a link to the github repo if necessary, it's a private one but I can make it public. The repo in question is a very small vuejs project, with the follow package file:

{
  "name": "tailwind-converter",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "serve": "vue-cli-service serve",
    "build": "vue-cli-service build",
    "lint": "vue-cli-service lint"
  },
  "dependencies": {
    "clone-deep": "^4.0.1",
    "core-js": "^3.6.5",
    "css-inliner": "^2.0.0",
    "deepmerge": "^4.2.2",
    "dns": "^0.2.2",
    "extract-css": "^1.5.5",
    "juice": "^7.0.0",
    "module": "^1.2.5",
    "net": "^1.0.2",
    "setimmediate": "^1.0.5",
    "vue": "^2.6.12",
    "vue2-ace-editor": "^0.0.15"
  },
  "devDependencies": {
    "@vue/cli": "^4.5.7",
    "@vue/cli-plugin-babel": "~4.5.6",
    "@vue/cli-plugin-eslint": "~4.5.7",
    "@vue/cli-service": "~4.5.7",
    "babel-eslint": "^10.1.0",
    "brace": "^0.11.1",
    "eslint": "^6.8.0",
    "eslint-plugin-vue": "^6.2.2",
    "tailwindcss": "^1.8.10",
    "vue-cli-plugin-tailwind": "^1.5.0",
    "vue-template-compiler": "^2.6.12"
  },
  "useEslint": false,
  "eslintConfig": {
    "root": true,
    "env": {
      "node": true
    },
    "extends": [
      "plugin:vue/essential",
      "eslint:recommended"
    ],
    "parserOptions": {
      "parser": "babel-eslint"
    },
    "rules": {}
  },
  "browserslist": [
    "> 1%",
    "last 2 versions",
    "not dead"
  ]
}

What is expected?
Everything was running fine then I think this happens after I upgraded some plugins.
What is actually happening?
When I run npm run serve , from the browser I get an error
polyfills.js?a0a3:31 Uncaught TypeError: Cannot read property 'match' of undefined
at patch (polyfills.js?a0a3:31)
at patch (graceful-fs.js?0da7:104)
at Object.eval (graceful-fs.js?0da7:96)
at eval (graceful-fs.js:356)
at Object../node_modules/graceful-fs/graceful-fs.js (chunk-vendors.js:9379)
at webpack_require (app.js:849)
at fn (app.js:151)
at Object.eval (index.internals.js?898b:9)
at eval (index.internals.js:124)
at Object../node_modules/gulp-sourcemaps/src/init/index.internals.js (chunk-vendors.js:9436)

I think I need the repository to see what's actually going wrong. Seems something from the server-side was accidentally bundled into the client chunk.

Hello, the code is here:
https://github.com/Nilead/tailwind-converter
I was a bit hesitate to publish the link because it's not ready for use in production yet...

@sodatea Thank you. Thanks to your insight, I went to each file and commented out code. Found that somehow this line got into a file and caused the issue:
import { RuleTester } from "eslint";


Add fake client that cleanly implements the Client interface instead of using GRPC libraries.

Add fake client that cleanly implements the Client interface instead of using GRPC libraries.

/gcbrun


Apply the shorten null coalescing operator

Changed log

It should shorten null coalescing operator and make it readable.

That feature isn't available on PHP 7, which this package still supports.

As far as I know, the feature is available since the PHP 7.4 version is released.
Please look at the reference.

Seems like PHP 7 is better than I thought!
Thanks!


Add firewalld reload service

Add a new service command which listens on for the firewalld reload dbus event and then re-adds all firewall rules back.
The unit file is written so that it is only started and stopped with firewalld so it never runs unless needed. The new unit is called netavark-firewalld-reload.service.
Tests have been added to ensure it is working as expected.
This required more changes that I would have liked but it is important to only write the minimal firewall config to disk to not waste memory as the config dir is on tmpfs.
Fixes https://issues.redhat.com/browse/RHEL-3079

@mheon @baude @flouthoc PTAL
@mheon I expect this to cause quite a few conflicts with you nftables work. I am happy to rebase that for you because I think that may be faster as I know what changes I had to make.

LGTM

/lgtm


Invalid device ordinal

Hi, i was training the Pointpillars on Nuscenes, but it shows cuda runtime error: invalid device ordinal，does anyone know how to solve it?

thanks，i have solved it !!!

hi @Gang-Chen-China,  could you please share your solution to this problem, thanks a lot~

hi @Gang-Chen-China, could you please share your solution to this problem, thanks a lot~

yeah , i train with single GPU and change the train.sh . kile this:
python3  ./tools/train.py ./examples/point_pillars/configs/original_pp_mghead_syncbn_kitti.py --work_dir=$PP_WORK_DIR


Tensor Interface

I'm very frustrated with this approach in terms of how it's generalizing to vector spaces and other things, and I'm not sure this is the proper way in which to be doing this. I want to be able to have the laws work for me, not me work for the laws, and it seems like in a language with no proof system I have no way of achieving this. I'm going to look into Liquid Haskell and their new claims of proof reflection to see if I can make this more rigorous.

Don't have time to deal with this, postponing work on this package for now


Test this project with Rails 4.1.9.rc1

Hi team,
we just released Rails 4.1.9.rc1. To help us to find regressions, and make the final release
awesome for everyone, I'm here humbly asking you to test your project with this
Release Candidate.
We are planing the final release to 2015-01-06, so it would be great if
you test it before this date.
If you find any regression please open an issue on GitHub mentioning me and with the title starting
with:
[Regression 4.1.9.rc1]
Thanks in advance.

on it :heart:

We're actually on 4.2 now :grin: https://github.com/codetriage/codetriage/blob/master/Gemfile#L6

OMG! So I'll only notify the project on 4.2 releases.

ahahha =)


When I set serve.http2 to true, I can't get correct response

Hello
I love webpack-serve, HMR works well without http2 on.
But when I set serve.http2 to true, I can't get correct response.
Anybody have the same problem?

Operating System: macOS High Sierra Version 10.13.4
Node Version: v9.11.1
NPM Version: v5.6.0
webpack Version: v4.6.0
webpack-serve Version: v0.3.1

This issue is for a:

[ ] bug
[ ] feature request
[ ] modification request

Code
CLI Command
$ yarn dev
or
$ npm run dev

Work Directory
$ tree
.
├── package.json
├── src
│   ├── index.js
│   └── templates
│       └── index.html
└── webpack.config.js

webpack.config.js
const path = require('path');
const webpack = require('webpack');
const internalIp = require('internal-ip');
const HtmlWebpackPlugin = require('html-webpack-plugin');

const isDev = process.env.NODE_ENV === 'development';
const isProd = process.env.NODE_ENV === 'production';
console.log(`Running webpack in the ${process.env.NODE_ENV} mode`);

const PATH = { base: __dirname };
PATH.src = path.resolve(PATH.base, 'src');
PATH.dist = path.resolve(PATH.base, 'dist');
PATH.templates = path.resolve(PATH.src, 'templates');
PATH.entry = {
  bundle: './src/index.js',
};
PATH.pages = [
  {
    filename: 'index.html',
    template: path.resolve(PATH.templates, 'index.html'),
    chunks: ['bundle'],
  },
];

module.exports = {
  mode: process.env.NODE_ENV,
  context: PATH.base,
  entry: PATH.entry,
  output: {
    path: PATH.dist,
    filename: isProd ? 'js/[name].[chunkhash:10].js' : 'js/[name].js',
  },
  resolve: {
    alias: {},
    extensions: ['.js', '.json'],
  },
  plugins: [],
};

if (PATH.pages && PATH.pages.length !== 0) {
  module.exports.plugins = module.exports.plugins.concat([
    ...PATH.pages.map(page => new HtmlWebpackPlugin(page)),
  ]);
}

if (isDev) {
  module.exports.serve = {
    hot: true,
    open: true,
    // http2: true,
    // host: internalIp.v4.sync(),
    // port: 8080,
  };

  module.exports.plugins = module.exports.plugins.concat([
    new webpack.HotModuleReplacementPlugin(),
  ]);
}

package.json
{
  "name": "wsk",
  "version": "1.0.0",
  "description": "Web starter kit for agile web font-end development.",
  "main": "src/index.js",
  "repository": "https://github.com/laozhu/wsk",
  "license": "MIT",
  "scripts": {
    "dev": "cross-env NODE_ENV=development webpack-serve -w -d --bail",
    "build": "cross-env NODE_ENV=production webpack -p --bail",
    "clean": "rimraf dist .eslintcache npm-debug.log yarn-error.log"
  },
  "devDependencies": {
    "cross-env": "^5.1.4",
    "html-webpack-plugin": "^3.2.0",
    "internal-ip": "^3.0.1",
    "rimraf": "^2.6.2",
    "webpack": "4.6.0",
    "webpack-cli": "^2.0.14",
    "webpack-serve": "^0.3.1"
  }
}

index.js
console.log('hello world');

index.html
<!DOCTYPE html>

  <title>Home</title>

Hello World!

Expected Behavior
When I set http2 to false, everything is OK like screenshot below.

I want get the same result with setting http2 to true.
Actual Behavior
When I set http2 to true, webpack runs well, but I get ERR_INVALID_HTTP_RESPONSE
response in the browser.

Below is the webpack console ouput.
$ ritchie at MacBook-Air in ~/D/wsk
↪ yarn dev
yarn run v1.6.0
$ cross-env NODE_ENV=development webpack-serve -w -d --bail
Running webpack in the development mode
(node:85675) ExperimentalWarning: The http2 module is an experimental API.
ℹ ｢hot｣: webpack: Compiling...

How Do We Reproduce?
$ yarn
// Set serve.http2 to true
$ yarn dev

Thanks for any help.

Thanks for the issue :beer: Unfortunately this isn't a support forum, and unless you can point at a specific cause, this isn't a bug report but a request for support. webpack-serve uses koajs directly, and that setting is passed onto koa without modification or interference. However, as with any HTTP/2 setup, you must provide an SSL Cert (https) to use with HTTP/2. Please do try Stack Overflow, Gitter, or the Koa documentation for getting this working properly.

You have solved my problem, maybe I need use https and http2 together, thank you!


add twitter account to website

Why are these changes needed?

This adds a Twitter account to the Website
Related issue number

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto-checks have passed.

Codecov Report

Merging #150 (047de37) into main (24adfb0) will decrease coverage by 2.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   41.03%   38.73%   -2.30%
==========================================
  Files          17       17
  Lines        2091     2091
  Branches      469      469
==========================================
- Hits          858      810      -48
- Misses       1156     1200      +44
- Partials       77       81       +4

Flag
Coverage Δ

unittests
38.73% <ø> (-2.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


fix(semantic-release.yaml): switch to default GITHUB_TOKEN

Fixes the access token to use the default GITHUB_TOKEN in the action context
Signed-off-by: Toni Tauro<EMAIL_ADDRESS>

Switching to a docker build based action instead of going for goreleaser for now, we need to fix this later tho


Plex automatic subtitle detection support?

i see asbplayer currently supports automatic subtitle detection for both Emby and Jellyfin, can we have that for Plex too? 😢

Plex external subtitles are supported as of 1.6.0
Let me know if thats not what youre looking for

Plex external subtitles are supported as of 1.6.0
Let me know if thats not what youre looking for

Oh, no. I'm talking about internal subtitle detection.


404 error of link in endoscopic_inbody_classification bundle

The link of 20 samples for the bundle seems failed
https://drive.google.com/uc?id=1rQQfHcZFs74OG0uJsL4vg7YqMWXV-s4k

Hi @binliunls  may need your help to double confirm it, thanks in advance!

Hi @yiheng-wang-nv ，
Thank you for your feedback. The samples have been uploaded to monai and the link is shown below.
https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/inbody_outbody_samples.zip
Thanks,
Bin


Dynamic theme is using colors from default theme.

Steps to reproduce

Select dynamic theme as you theme.

Expected behavior
App uses colors from your wallpaper.
Actual behavior
App is still using the default theme.
Crash logs
No response
Mihon version
r6499
Android version
Android 14
Device
Samsung S21FE
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Would like to add, I'm currently having the same issue here
Mihon Version
Stable 0.16.3
Android Version
Android 14
Device
Samsung Galaxy Z Flip 5

facing it here too
Mihon Version
Stable 0.16.3
Android Version
14
Device
Samsung Galaxy Z Fold4

Dynamic Theme works fine for me. Provide me with some screenshots, if you could.

0.16.3:
appearance menu in settings with dynamic theme selected
about menu
after downgrading to 0.16.2:
appearance menu in settings with dynamic theme selected
about menu

0.16.3: appearance menu in settings with dynamic theme selected about menu
after downgrading to 0.16.2: appearance menu in settings with dynamic theme selected about menu

Yeah, works fine for me.

what device are you using?

what device are you using?

Redmi Note 9 Pro, running an Android 14 custom ROM.

could be only affecting samsungs then

I'm on Samsung (S23 ultra) and I don't have this problem. I think I know what's going on here. The dynamic theme doesn't directly use wallpaper colors. It uses system colors, which are taken from the wallpaper. That means that you should make sure that you changed the color palette in your phone's settings. And yeah, I tried the pre-release version, and it still works.

it's an issue with the newer compose material 3 versions on One UI 6 (and 6.1), but it seems to work fine on older version of One UI like 4 and 5

Seems to be due to a change in implementation of surface colors as seen in this commit to fix this same issue https://github.com/jarnedemeulemeester/findroid/commit/0a1582f47b33147c6c797c76f674bdedad4a4909


Documentation Issue

In the installation guide tutorial*, this is mentioned:

Note: Please make sure both the static and media subfolder exist in your project and are writable.

But why is it that someone should make the static folder writable? Normally it is intended to be static :)
*) http://docs.django-cms.org/en/latest/getting_started/tutorial.html

Yeah, I would assume this is for manage.py collectstatic as well.  However, I can not find any docs explicitly saying to make it writable.  In writing my docs I just wanted to mirror the note in getting_started/tutorial.html for consistency.

yes for collectstatic STATIC_ROOT must be writable.


Optimizing css watch to only reload css files (stream)

Signed-off-by: Chris Roelsgaard Rasmussen<EMAIL_ADDRESS>

This will make the livereload stream only reload css files.
Since most browsers support reloading css files without doing a full reload of the page, css changes can be seen imidiatly without page reload, causing forms and inputs to be cleared.


Updated calculation for dynamic load

Updates in: Dynamic load calculation ; charging voltage increased, charging method and absorbation time

Updates in: Dynamic load calculation ; charging voltage increased, charging method and absorbation time.
Open: CAN timing issues


执行vue webpack 命令,cmd闪退，是什么原因？

操作系统： win10 64
node：v6.6.0
vue-cli:2.0.5
执行 任何 vue 命令就闪退了。why？

我也遇到这个问题...

Can you explain this in English with more details, please? The translator says that the command flash backs which I cannot understand

@posva that means the commander crash(run 'vue init xxxx' then command disappear),
i also meet the trouble

@Jeesoong In that case, can you give more details about how to reproduce and in which circumstances it occurred? Thanks!

@posva Input vue command, CMD will snap closed. No log, no tip.

@sherryPrincess  We'll need the log of the CMD. Can you please provide it?

@sherryPrincess  vue  [options] only for init and list command

i am have this question too
i type this commd
                 vue init >>1.txt

this window close
so i open 1.txt
get this messing

C:\Users\Administrator>"$basedir/../../Users/Administrator/AppData/Local/Yarn/config/global/node_modules/.bin/vue.cmd"   "$@"
C:\Users\Administrator>exit $?

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.


Use mock for CSS-files

Summary:
Missing CSS files cause failing tests, this is problematic when using a
preprocessor such as SASS.
Test plan:

Create a project
Delete src/App.css.
Run yarn test.

Verify the test passes and does not fail with a Cannot find module './App.css' from 'App.js'-error.

I prpose this change because I use a CSS-preprocessor with create-react-app, this leads to problems with tests failing on CI. The preprocessor is not run before the tests are executed, therefore the CSS files are missing.
Currently I have a pretest-hook, that builds our assets. This slows down test-execution and adds another step that could possibly fail.
A build of a project will still fail, when a CSS file is missing.


Add async tests

As discussed with @tim-schilling in #1828 a good start towards adding async support is adding tests involving async views and async ORM usage.
Unfortunately, none of the automated tests showcase the problem described in #1828 as there is no ASGI equivalent of LiveServerTestCase and the issue seems to be specific to running an actual ASGI server.
Therefore, despite all tests are green, async support is still not there. Running the example app with an ASGI server using ASYNC_SERVER=true python example/manage.py runserver and visiting http://<IP_ADDRESS>:8000/async/db-concurrent/ does exhibit the deadlock though.
See also #1819.

Closing in favor of #1938. Thank you for pushing this forward @salomvary! Your work here was helpful to the GSoC project to push the toolbar forward with async compatibility.

Nope, I was wrong. This still has value.

Rebased on main

@salomvary could you confirm that the deadlock issue is not a problem in this version? @salty-ivy removed the sql panel from async installations which seems to have resolved that issue. Granted, now the issue is that the toolbar doesn't have a SQL panel for async apps, but at least it doesn't lock up.

@salomvary could you confirm that the deadlock issue is not a problem in this version? @salty-ivy removed the sql panel from async installations which seems to have resolved that issue. Granted, now the issue is that the toolbar doesn't have a SQL panel for async apps, but at least it doesn't lock up.

I think it was more a django ORM issue rather than the toolbar itself. @salomvary  mentioned it here
https://forum.djangoproject.com/t/are-concurrent-database-queries-in-asgi-a-thing/24136/2

Weird, on my machine it was executing them concurrently (I think). Or at least they didn't result in a deadlock.

Thank you @salomvary for this! I'd still like your confirmation the deadlock has been handled when/if you have time.

Yep, the deadlock was very likely not cause by the Debug Toolbar, it is a Django issue. As far as I can remember I was later able to reproduce the deadlock with Debug Toolbar not even installed.


Installation on ITER clusters of tofu 1.4.1

Seems like there is an import error in ITER clusters:

TypeError: C function tofu.geom._basic_geom_tools.compute_hypot has wrong signature (expected arrayobject *(__Pyx_memviewslice const , __Pyx_memviewslice const , struct __pyx_opt_args_4tofu_4geom_17_basic_geom_tools_compute_hypot *__pyx_optional_args), got arrayobject *(__Pyx_memviewslice, __Pyx_memviewslice, struct __pyx_opt_args_4tofu_4geom_17_basic_geom_tools_compute_hypot *__pyx_optional_args))

This was probably resolved with #222
Could not recreate the error and was able to load and use tofu in imas without any problems.
For both 1.4.0 and 1.4.1


Submit to PyPI

Hi, I was wondering if you could submit this package to PyPI so that I could add it to my requirements.txt with the rest of my dependencies? Thanks for this library!

FYI, I forked the repo and submitted it to PyPi: https://pypi.python.org/pypi/airtable


Hassio reports stability issue

Logger: homeassistant.util.async_
Source: util/async_.py:159
First occurred: 18:35:47 (7 occurrences)
Last logged: 18:49:52
Detected blocking call to sleep inside the event loop. This is causing stability issues. Please report issue to the custom integration author for tuya_local doing blocking calls at custom_components/tuya_local/device.py, line 78: self._api = tinytuya.Device(dev_id, address, local_key)

Version 2023.5.1

Duplicate of #407


Fix attribute error in default payload handler.

If the authentication handler returned a dictionary rather than an
object then the default payload handler would throw an AttributeError
as no default value was supplied for getattr().

Coverage remained the same at 95.652% when pulling e4bd8e3a17d16cde919d5afdfc0fe2878f554e5c on badlydrawnrod:master into c27084114e258863b82753fc574a362cd6c62fcd on mattupstate:master.

Coverage remained the same at 95.652% when pulling ca7506cba6c397b3685cfaed175c83a8d7bb6193 on badlydrawnrod:master into c27084114e258863b82753fc574a362cd6c62fcd on mattupstate:master.

Coverage remained the same at 95.652% when pulling 021cf94966f601f5bd65d61cfa06894a25895a91 on badlydrawnrod:master into c27084114e258863b82753fc574a362cd6c62fcd on mattupstate:master.

Already fixed by #63 and many others.


Add basic OpenAI API text completion support.

Allow Deliberate Lab to talk to any model endpoint that supports the OpenAI text completion API.
This is configured by setting environment variables on the functions emulator:

OPENAI_BASE_URL: Controls whether to use the OpenAI API, and the base URL to use. If empty, use the Gemini API instead.
OPENAI_API_KEY: API key. May be empty, e.g. for local Ollama.
OPENAI_MODEL_NAME: Model name. May be empty, e.g. for local servers that only serve one model.

For example, to use an API endpoint that requires an API key but not a model name:
OPENAI_BASE_URL=http://hostname:port/v1 OPENAI_API_KEY=key firebase emulators:start --import ./emulator_test_config
Once #350 is merged, we can use its configuration interface to configure this API.

Looks good and minimally invasive as-is; happy to merge pending @vivtsai's review.
Side note: The console logging for APIs is getting a little out of hand (not your fault, this is the way we do things currently)! I've filed https://github.com/PAIR-code/deliberate-lab/issues/382 as an idea on how to surface this to the experimenter.


Support writing RDF formats

Once the DataValue refactor is through, implementing RDF output should be straightforward.

Works now


Pod's Detail page UI issues

Rancher versions: 2.0 master 3/21
Steps to Reproduce:

Create a workload with at least 1 pod
Click on Pod name to go to details page

Results:

[x] "Connecting...." text floating by pod name

[x] No darker blue line to break up Image and Ip address (like we have for workloads)

[x] Image is blank

[x] Type: None floating in middle of page

[x] "Environment Variables From Source" is at bottom of page

Version - 2.0 master 3/22
Verified fixed


Demo page is broken when opened via https

https://sandywalker.github.io/webui-popover/demo/ looks like this:

Popover doesn't work on it.

Wow, I found it. Now the bug is fixed, thank you very much!


Change API URIs to long form

Description
As a user of the API
I want to see the hierarchy in the API URIs
So that I can see how the resources fit
Acceptance criteria

[ ] Change GET /api/workspace-services/{services_id} to /api/workspaces/{workspace_id}/workspace-services/{services_id}
[ ] Change GET /api/workspace-services/{service_id}/user-resources to /api/workspaces/{workspace_id}/workspace-services/{service_id}/user-resources
[ ] Change GET /api/user-resources/{resource_id} to /api/workspaces/{workspace_id}/workspace-services/{service_id}/user-resources/{resource_id}
[ ] Validate the chain in all cases - i.e. validate that the resource_id actuall belongs to service_id and that service_id actually belongs to workspace_id -- else 404

We can shorten the long form if we go with the initial design as proposed in #12
GET /workspaces/{workspace_id}/services/{workspace_service_id}/resources/{resource_id}, for instance

Looks nice and clean @christoferlof - let's check with @marrobi when he gets back -- I can do the longer version now, the switch to the shorter (services vs. workspace-services etc.) can be done in a separate PR pretty easily