Memory Leak

Issue details, reproduction steps/code
On the Android, when the application is restarted multiple times using back button (destroys activity but not application), despite calls to destroy, activity, reportfragment and some google class leaks remain in the memory dump.
If you remove the final attribute from the activity inside class PurchaseManagerGoogleBilling and assign activity to null in the destroy(), then the leaks disappear.
Version of gdx-pay and/or relevant dependencies
1.3.7
Stacktrace

Please select the affected platforms and payment service implementation

[ ] Amazon
[x] googlebilling
[ ] googlepay
[ ] apple robovm
[ ] Huawei

Good catch, feel free to open a pr

Good catch, feel free to open a pr

I'm not sure that this is a good solution to the problem, rather temporary workaround in my project, it turns out that the PurchaseManagerGoogleBilling instance itself remains registered in memory, it might be better to delete it on destroy.

Do you also have the problem in libgdx app as created by gdx setup with
just gdx pay added?
If yes, can you share the project?
Op do 27 jun 2024 om 19:09 schreef Animan2010 @.***>

Good catch, feel free to open a pr
I'm not sure that this is a good solution to the problem, rather temporary
workaround in my project, it turns out that the
PurchaseManagerGoogleBilling instance itself remains registered in memory,
it might be better to delete it on destroy.
—
Reply to this email directly, view it on GitHub
https://github.com/libgdx/gdx-pay/issues/264#issuecomment-2195237460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGS5XUIFWNWIVCZOEJ6VALZJRBLLAVCNFSM6AAAAABJ6OAPUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGIZTONBWGA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

If yes, can you share the project?

Of course, I created an almost empty project using the current gdx-setup and gdx-pay, the result is the same, leaks if restarting the game on the Android emulator (api 28) multiple using the back key.
https://github.com/Animan2010/GdxTest


Attempt to use a destroyed view when focus on ion-input on Android device

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Running on an actual Android device. On an app with 4 tabs (one of the tabs shows a virtual scroll list) I push a view into one of the tabs. The view contains an input box and I click inside the input box to give it focus. The keyboard opens and the uncaught exception is thrown. The app becomes unstable after that.
This happens in 4-5 different components where I do no navigational manipulation, just clicking inside an ion-input box triggers the error.
This could be related to #8693 but it happens on any ion-input not just the search box.
Expected behavior:

Click inside an input box, keyboard opens, write some text, leave the textbox without error.
Steps to reproduce:

This only happens in an actual android device.
Related code:
Component with the input box:
<ion-header no-shadow>
  <ion-navbar>
    <ion-title>Hello</ion-title>
  </ion-navbar>
</ion-header>
<ion-content>
  <ion-input type="text" name="fullName"   placeholder="No Name"></ion-input>
</ion-content>

Other information:

the exception reads:
Error: Attempt to use a destroyed view: detectChanges
    at e.Error (native)
    at e [as constructor] (file:///android_asset/www/build/main.js:16:15178)
    at new e (file:///android_asset/www/build/main.js:43:17890)
    at e.t.throwDestroyedError (file:///android_asset/www/build/main.js:3:12908)
    at e.t.detectChanges (file:///android_asset/www/build/main.js:3:11471)
    at t.detectChanges (file:///android_asset/www/build/main.js:43:22443)
    at t.renderVirtual (file:///android_asset/www/build/main.js:21:21159)
    at file:///android_asset/www/build/main.js:21:20778
    at e (file:///android_asset/www/build/main.js:21:20172)
    at t.update (file:///android_asset/www/build/main.js:21:20686)

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Cordova CLI: 6.4.0
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2 Build version 8C38

Just completed a test case where confirmed that this only happens if a Virtual Scroll component is used in one of the tabs, but it affects any ion-input in any "child" page or modal of any of the tabs.

Hello @masimplo ! Thanks for opening an issue with us! Would you mind trying this with RC4? We did alot of good fixes for virtual scroll in this release which may help here.

So happy RC4 is out, I noticed that is has a lot of virtual scroll fixes. Will try updating and will let you know asap.

After upgrading to RC4 tried the same scenario on two devices and it seems to have been resolved. Thanks jgw96 for the suggestion. Closing this.


Build OpenCV 4.6.0 from source with Visual Studio 2022 (cpp)

This might help alleviating the compiler cl1 internal error C1001 encountered while instantiating class OpenCV cv::Map in c++20 module gui::items::view.ixx.
Found great how-to explanations at https://visp-doc.inria.fr/doxygen/visp-daily/tutorial-install-win10-msvc17.html (Visual Servoing Platform - ViSP - installation web page) from French research entity INRIA.

Completed. Done for Release and Debug configurations, and for x64 and Win32 platforms.
Unfortunately, this does not alleviate the compiler cl1  internal error C1001 encountered while instantiating class OpenCV cv::Map in c++20 moudule gui::items::view.ixx.


Nightly Rust for ARMv6

Hi @dlecan, thanks for this! I'm struggling to get a nightly version of this going. I forked your Docker image, ran rustup toolchain install nightly-x86_64-unknown-linux-gnu, which succeeded. But when I run cargo +nightly build, I get this permission error for all packages:
root@ae3587e98f45:/source# cargo +nightly build
error: unable to get packages from source

Caused by:
  failed to unpack package `crossbeam-channel v0.3.3`

Caused by:
  failed to open: /root/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.3.3/.cargo-ok

Caused by:
  Permission denied (os error 13)

When try cat /root/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.3.3/.cargo-ok, it prints an empty file with no permission error.
Is cargo +nightly running as a different user perhaps?
Any help would be appreciated.
So then I

@theronic Here's how I built a nightly version for myself. Hope this helps: https://github.com/marikka/rust-crosscompiler-arm/commit/c96f8be499650c39197bfc2ee214b049d7b2975a


Enhance Documentation on Theme-Specific Image Display with Illustration and  Tag Clarification

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Article Affected
Basic writing and formatting syntax
Section Affected
Specifying the theme an image is shown to
Issue Description
The current section lacks an illustration of the image behaviour based on the theme, and the purpose of the <img> tag is not clearly defined. These additions would improve understanding and clarity for readers.
Screenshot Of The Section

What part(s) of the article would you like to see updated?
What part(s) of the article would you like to see updated?
The section titled “Specifying the theme an image is shown to” should be updated. Specifically:

Add an Illustration: Include images to demonstrate how the sun appears in light mode and the moon in dark mode.
Clarify the <img> Tag: Explain the purpose of the <img> tag as a fallback for browsers that don’t support the prefers-color-scheme feature.

Why should the docs be changed? What use cases does it support?
These updates will make the documentation clearer and more practical. Visual aids help users quickly understand the concept, and clarifying the <img> tag’s role will reduce confusion for developers implementing theme-specific images.
What is the expected outcome or behavior?
Users will better understand how to apply theme-specific images with confidence, improving their projects’ appearance across light and dark modes.
Additional information
No response

@syed-ateeb-naveed Thank you for raising this issue! I'll get this triaged for review :sparkles: Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@syed-ateeb-naveed Thank you for opening an issue and linking it to your PR! ✨


Support indy 1.16 predicate restrictions

Still to work out:

general WQL (+ "$and") for restrictions in proof request requested attributes/predicates
not necessarily relying on these being a list: they can be a (WQL statement) dict or a list of (WQL statement) dicts, each (WQL statement) dict possibly being its own compound WQL statement; e.g., this is a valid restriction:

{
  "$and": [
    {
      "$or": [
        {
          "schema_name": "membership"
        },
        {
          "schema_name": "members"
        }
      ]
    },
    {
      "$neq": {
        "schema_version": "0.1"
      }
    },
    {
      "issuer_did": "abc123"
    },
    {
      "$not": {
        "$in": {
          "attr::name::value": [
            "joe",
            "dolly",
            "bill"
          ]
        }
      }
    }
  ]
}

Reference: https://hyperledger-indy.readthedocs.io/projects/sdk/en/latest/docs/design/011-wallet-query-language/README.html
But "$and" is in the code where it's implicit in the standard.

Codecov Report

Merging #1213 (a0c1236) into main (2b54294) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   98.47%   98.47%   -0.01%
==========================================
  Files         456      456
  Lines       25431    25428       -3
==========================================
- Hits        25042    25039       -3
  Misses        389      389


tensorflow object detection issue

i developed the custom object detector with some 96 images (train 76 and test 20) after trained 200k steps my losses(1) goes down correctly....after that i create the interference graph all ok..........but my question is when i run my code to detect the object from video it not able to find the correct object ........ thanks in advance.....
actually i think we have a enough image for the dataset...because my dataset can able to detect the object from pre built video....so....it can detect the object from webcam also but not ...i dont kw the exact problem.....i think the resolution may b differ...thats y it not able to detect the object....
use predefined "object detection" code with my own data set
ubuntu 16.04
tensorflow installed in anaconda environment
tensorflow 1.4.0
bazel 0.4.5
cpu version

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Creating object map from union of literals

Given the following union:
const TimeUnit = Union(
  Literal('minute'),
  Literal('hour'),
  Literal('day')
);

I'd like to get an object map with each key having the literal value:
const TimeUnitMap = {
  minute: 'minute',
  hour: 'hour',
  day: 'day',
}

What I'm doing right now is using this function:
function getObjectMap<T extends string>(union: { alternatives: Literal<T>[] }) {
  return union.alternatives.reduce((acc, val) => {
    acc[val.value] = val.value;
    return acc;
  }, {} as Record<T, T>)
}

It works but the type of each value is 'minute' | 'hour' | 'day'. I would like the type of the value to be the literal value, so type of TimeUnitMap.minute is 'minute', similar to a string enum.
Is this possible? The only way I can think of doing it is having the object created first and then the union from the object's keys.

For any type which is a union of string literals,
type X = 'a' | 'b' | 'c' | ...;

you can get the corresponding record type
type Y = {
  a: 'a';
  b: 'b';
  c: 'c';
  ...
};

by defining
type Y = { [K in X]: K extends X ? K : never };

So you just want to make that the return type of getObjectMap:
function getObjectMap<T extends string>(union: { alternatives: RT.Literal<T>[] }) {
  return union.alternatives.reduce((acc, val) => {
    // not totally sure why the cast is necessary here
    (acc as any)[val.value] = val.value;
    return acc;
  }, {} as { [K in T]: K extends T ? K : never });
}

Cheers that works!


Chapte 12: Models - Quantization

On Google Colab
Even after the installation of the following
!pip install "bitsandbytes==0.43.1"
!pip install accelerate
#!pip install -U bitsandbytes
running "Models - Quantization", still can't go on. We got the following:
ImportError                               Traceback (most recent call last)
 in <cell line: 15>()
13
14 # Load the model to train on the GPU
---> 15 model = AutoModelForCausalLM.from_pretrained(
16     model_name,
17     device_map="auto",
2 frames
/usr/local/lib/python3.10/dist-packages/transformers/quantizers/quantizer_bnb_4bit.py in validate_environment(self, *args, **kwargs)
64             raise ImportError("Using bitsandbytes 4-bit quantization requires Accelerate: pip install accelerate")
65         if not is_bitsandbytes_available():
---> 66             raise ImportError(
67                 "Using bitsandbytes 4-bit quantization requires the latest version of bitsandbytes: pip install -U bitsandbytes"
68             )
ImportError: Using bitsandbytes 4-bit quantization requires the latest version of bitsandbytes: pip install -U bitsandbytes

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.
Still can't find way to work it through, please help

Thank you for sharing this issue! It seems that the pip installations were missing for the Google Colab notebooks. I'll make sure to add them either today or tomorrow. For now, the following should work:
%%capture
!pip install -q accelerate peft bitsandbytes transformers trl sentencepiece

What happened is that I removed the pip installations from the notebooks in the repo as those are meant for local usage. However, we are directly opening those notebooks in Google Colab. As such, I will add a section that allows you to get the right packages in each Colab notebook.

Thanks!, It works now by uploading the requirements.txt and  install it with "!pip install -r requirements.txt"

Awesome, glad to hear that it worked! I added additional instructions for installing the related packages when you are using Google Colab, so it should be more straightforward now.


Clarify interaction of mstatus.MPRV and Zicfiss

Can you please clarify the interaction of mstatus.MPRV with Zicfiss?
The Privileged Specification says:
When MPRV=1, load and store memory addresses are translated and protected, and endianness is applied, as though the current privilege mode were set to MPP.
And the Zicfiss specification has this kind of text for the new MOP instructions:
The SSPUSH and C.SSPUSH instructions perform a store identically to the existing store instructions, with the difference that the base is implicitly ssp and the width is implicitly XLEN.
This implies to me that instructions such as SSPUSH can be executed in M-mode if mstatus.MPRV indicates a lower-level mode with Zicfiss enabled. However, the Zicfiss specification also says:
Activating Zicfiss in M-mode is currently not supported.
Is it intended that mstatus.MPRV enables use of Zicfiss instructions in M-mode, if they are enabled at the target privilege level implied by mstatus.MPRV? If so, I think it would clarify things to state this explicitly and adjust the wording of that last sentence to Activating Zicfiss for M-mode loads and stores is currently not supported, or something like that.
Thanks.

Activating Zicfiss in M-mode is currently not supported.

That is correct. When sspush and sspopchk (and their compressed equivalent) are executed at M-mode, these instructions execute as MOPs (Zimop or Zcmop) and thus do not make a load or store and hence MPRV does not affect them. The ssamoswap is not a MOP. When executed in M-mode, it performs a memory access using the effective privilege mode as determined by MPRV and MPP.

Thanks for that - closing.


Separate configuration and functionality

Move Frontman to frontman.go
Move log_levev to MinValuableConfig
Initialize defaults from within init()
Signed-off-by: Artur Troian<EMAIL_ADDRESS>

@troian This needs a rebase now.


Ephemeral invocations

Is your feature request related to a problem? Please describe.
I want to run jobs in a throw-away jail that is reset to a previous state on exit.  In most container systems, this is accomplished with an ephemeral layer over the top of a container image.
Describe potential alternatives or workaround you've considered (if any)
I currently wrap the pot invocation in a loop the rolls back to the previous snapshot each time.  This isn't great for three reasons:

I want to be able to upgrade the immutable base image periodically and I can't do that while the jail is running.
Rolling back is a synchronous operation and so I can't restart the jail until it's finished, whereas destroying a clone can happen concurrently with taking a new clone of the same base FS.
I have to be really careful to make sure I do the rollback in all possible failure modes of the script.

Describe the feature you'd like to have

[] An ephemeral variant of pot start that cloned the filesystem, ran from the clone, and destroyed it at the end.  If these clones live in a fixed part of the zpool namespace then pot can clean them up easily at the end.
[] A pot rename command so that I can atomically replace the immutable base image when I upgrade.
[] A mechanism to specify the zfs quota property for the ephemeral filesystem.

While not being packaged in a feature, you can do something like this already, which should improve the situation:
# create base pot
pot create -p immutable -t single -b 13.0

# snapshot and clone
pot snapshot -p immutable
pot clone -P immutable -p mutable

# start derived pot
pot start mutable

# change stuff in immutable
echo "Changed some things" >/opt/pot/jails/foundation/m/blabla

# resnapshot and create new clone
pot snapshot -p immutable
pot clone -P immutable -p mutable_new

# stop alt clone and move new clone into place
pot stop -p mutable
pot rename -p mutable -n mutable_old
pot rename -p mutable_new -n mutable
pot start mutable

# destroy old clone
pot destroy -p mutable_old

Thanks, that sounds like it's enough for what I need.  I missed the clone and rename commands.

I've now done this.  It would be nice to have an atomic destructive rename that pot protected from concurrent clones, but I can work around this by wrapping the rename in a script that I run while holding the same lock file that I hold while doing the clone.

This actually doesn't do quite what I need, because the cloned invocation is linked to the original and so I can't replace the base one without stopping the running ones (which I don't want to do, I want them to gracefully exit).
A pot promote would do what I need, I believe.  I can hack around this by doing the promote myself, but now I'm hard-coding pot's use of ZFS.

This actually doesn't do quite what I need, because the cloned invocation is linked to the original and so I can't replace > the base one without stopping the running ones (which I don't want to do, I want them to gracefully exit).

Is this a way of saying "I want to be able to rename a running pot"?

p.s. Can't you simply use clone + unique jail names (e.g., using uuids)? That's what the nomad plugin does when invoking "pot prepare".

Is this a way of saying "I want to be able to rename a running pot"?

That might work.

p.s. Can't you simply use clone + unique jail names (e.g., using uuids)? That's what the nomad plugin does when invoking "pot prepare".

I was using UUIDs, but now it's some extra metadata I need to communicate and I can't use well-known names of the pots to check if they're running, send them signals, and so on.
The UUID doesn't actually help here though.    I can fix that with an explicit zfs promote, but now I'm manipulating pot-owned ZFS datasets underneath pot, which doesn't sound like a good idea.

But why would you want to destroy pot A? You can simply change/update/whatever in it and then do a new snapshot you can clone a new pot from (while keeping the old snapshot and running clones in place). Managing metadata is an extra burden for sure (but also not that hard). It’s all a bit theoretical without knowing more about what you’re actually trying to achieve.

But why would you want to destroy pot A?

Because it's no longer required.  To make things more concrete:

I create a pot containing a configured GitHub Actions runner and all of the dependencies for the tested code.
I create an ephemeral clone of this runner
It runs a single action, leaving it in a state where it's full of junk I want to throw away.
I delete the ephemeral clone and loop from step 2.

At the same time, I create a new base pot containing updated versions of compilers and things, and an updated base system with security vulnerabilities fixed.  I want this to be picked up by the ephemeral pot as soon as it finishes running one job (I also prod it to exit if it's in the long-poll state and not currently running anything).
As soon as the new base image is ready and the runner has finished, the base dataset is no longer required and should be deleted.  If the ephemeral pot's dataset is promoted, this is trivial (ZFS handles the reference counting of any blocks that are still referenced by both).

I would simply run a prune script for that :), but maybe @pizzamig has more inspiration/ideas?

Hi everyone, sorry, I'm a bit late.
If I understood it correctly, we have:

a base pot, used as base to create/run ephemeral pot
ephemeral pot, used as runner instance

Do you have one ephemeral per base or multiple ephemeral per base?
My observations:

you don't need to re-create the base pot from scratch all the times, you can just run local upgrade and take a new snapshot
the ephemeral pot is created cloning a snapshot. When a new base pot is available, you can simply create a new ephemeral pot cloning the new snapshot of the base pot
if you only have on instance of the ephemeral clone, you can take a snapshot before to run it for the first time and rollback, instead of destroy the pot

pot snapshot uses the UNIX epoch as snapshot
pot purge-snapshots can help to remove old snapshots
I can add a feature to clone (pot clone -s latest) to use the oldest/latest available snapshot, to avoid the external management of snapshot tags.

Do you have one ephemeral per base or multiple ephemeral per base?

I have a single ephemeral one, other uses cases would want multiple ones.

you don't need to re-create the base pot from scratch all the times, you can just run local upgrade and take a new snapshot

That's definitely what I'd have done 10-20 years ago but it's definitely not recommended practice for modern operations.  Container deployments are supposed to be deterministically created from a declarative recipe, not continually evolving.

the ephemeral pot is created cloning a snapshot. When a new base pot is available, you can simply create a new ephemeral pot cloning the new snapshot of the base pot

Yup, that's what I'm doing now, but I need to run a zfs promote on the underlying dataset, which means I need to rely on implementation details of pot.

if you only have on instance of the ephemeral clone, you can take a snapshot before to run it for the first time and rollback, instead of destroy the pot

That's what I was doing but rollback is a synchronous operation whereas destroying a clone can happen in the background.

I don't understand the need to run a zfs promote (I guess you want to promote the origin to the new snapshot)
Why the re-cloning of the ephemeral pot using the new snapshot is not enough? What am I missing?

I've just installed and successfully start a runner using with your scripts.
Now I understand your use case with upgrade:

deterministically create a new base (with sufiix -tmp)
zfs promote the ephemeral pot to remove its dependency from the old base snapshot
destroy the old base
rename the new base without the suffix -tmp
gracefully shutdown the ephemeral pot and the run-actions-runner with automatically recreate it

In other words, you would need a way to recreate the base (with the same name), without shutting down the ephemeral pot.
the zfs promote solution, however, could be complicated with multiple ephemeral pot (you would need to destroy the promoted ephemeral pot as the last one)

It seems that you can rename the pot base while the ephemeral pot is running (the zfs origin is updated accordingly).
So the upgrade process could be:

rename the base with suffix -old
deterministically create a new base (no suffix)
gracefully shutdown the ephemeral pot (and let run-action-runner recreate it using the new base
destroy the -old base

I will test it the entire process later this week (maybe submitting a PR to your project), but the pot rename -p base -n base-old seemed to work

Thanks.  The zfs promote thing prevents the cloned dataset being marked as a child of the original, which allows the original to be deleted without needing to synchronise with the running invocation.  I'd rather avoid any serialisation here - CI jobs can be up to 6 hours with the standard GitHub policy, having the rename operation block for 6 hours would not be great.

Hi @davidchisnall, do you think it would make sense to revisit this requirement? (we made quite some progress structurally this year, so we might be in a better position to implement to feature now).

Now that there's support for OCI containers on FreeBSD, I plan on moving my things over to that, so feel free to close this if no one else needs it.


TrueKey fails to login

POST request to 'https://id-api.truekey.com/sp/oob/v1/son' failed with error (E6000: 'OOB Error')

Even though this looks like a 2FA bug, this happens with or without email 2FA configured.

Fixed in 5577f408c76a216b5a0e526e3873a92026492df0


add seekCur command

Implements the seekcur command from the protocol through seekcur.
Also, creates newtype Sign to create MPDArgs's that need a sign before them,
as otherwise only negative numbers will get a sign (used in seekcur for relative seeking).

@iyefrat LGTM. Can you update changelog: https://github.com/vimus/libmpd-haskell/blob/master/changelog.md ? It should have a new section with v0.9.2.

Done

@iyefrat Thanks for the PR and the associated tests!


loadshedder is slightly broken.

This is because resize retains the latest half of response latencies: https://github.com/komuw/ong/blob/4277c1deb3099ed809474cb4af7114f12bb4cd2b/middleware/loadshed.go#L123
However, the percentile func sorts the slice of latencies thereby mutating them. This means that the latest half latencies is not the latest but the largest once.

Two ways I see;

in  percentile func, deep copy the slice; and only sort the copy.
find percentile without doing a sort first.

Using the clone approach introduces a perf hit;
func BenchmarkPercentile(b *testing.B) {
	var r time.Duration

	lq := newLatencyQueue()
	for i := 1; i <= 5*maxLatItems; i++ {
		lq.sl = append(
			lq.sl,
			time.Duration(i)*time.Minute,
		)
	}

	b.ReportAllocs()
	b.ResetTimer()
	for n := 0; n < b.N; n++ {
		r = percentile(lq.sl, 90, len(lq.sl))
	}

	// always store the result to a package level variable
	// so the compiler cannot eliminate the Benchmark itself.
	result2 = r
}

New:
700_155 ns/op   1 allocs/op
Old:
235_458 ns/op    0 allocs/op

The second approach of using a different way to do percentile, probably also involves doing a slice clone; https://github.com/montanaflynn/stats/blob/a1456057d3769f934e58d431c2d1687bdaa68d90/percentile.go#L7-L23


fix: use filepath instead of path when calling before handler

Hi there! I noticed this small issue when using the lib.
The filepath parameter was always undefined on the before handler. This PR fixes the issue :+1:

Awesome, thanks for catching this and contributing a fix @wagoid! I'm going to merge this and add a test to help ensure this doesn't get broken again. I'll post again once I publish a new version on NPM with this fix included.
Thanks again!


Make zenburn style

Notepad++ has a zenburn style. This adds an import which is pretty close to that.

I basically imported yours, made all the changes, and re-exported the new one.

many thanks! Sorry it took so long... I haven't been using rust on windows lately, so I couldn't test

cool


fix: html xss

Change Summary

修复用户自定义应用时填入的名称和描述导致的界面 xss 相关的问题
Related issue number

Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
[ ] Some cases need DASHSCOPE_TOKEN_API to pass the Unit Tests, I have at least pass the Unit tests on local
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

lint check not pass

lint check not pass

fixed


Improved Documentation

[ ]  Particle filtering and reinvigoration
[ ] Belief Updating

Will add a notebook to show your options for this


Ability to run without previously cached image

While running merlin benchmarks, we use external tool merl-an. It is installed as in here:
https://github.com/ocaml/merlin/pull/1640/files
When I add a changes to merl-an, the image is cached, so I have to change something in dockerfile in order to force it's build. Is there other way to do this?

Currently, current-bench doesn't have a way to specify that the docker cache should be ignored for a particular benchmark run.
But, as a work around to rebuild the image when there are changes in the merl-an repository, you can use a hack like this, in your Dockerfile:
ADD https://api.github.com/repos/pitag-ha/merl-an/git/refs/heads/main .merl-an-info

This would ensure that the layers starting from the clone of the repo are rebuilt, whenever the merl-an repo has changes.We also use this hack for supporting the feature where the benchmarks repository is different from the repository being benchmarked.

Thanks @punchagan !


Revise image links in docs

#9

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


FT: Add changes for replication with GCP

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

@ironman-machine r+

Hello @bennettbuchanan
"r+": Success

@ironman-machine r-

Hello @bennettbuchanan
"r-": Success

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
r+

Hello @bennettbuchanan
"RUN_BACKBEAT_CRR_TESTS=1": Success
"r+": Success

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
try

Hello @bennettbuchanan
"RUN_BACKBEAT_CRR_TESTS=1": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/21086' with the following env. args:
{
    "RUN_BACKBEAT_CRR_TESTS": "1",
    "DEFAULT_BRANCH": "master",
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/ZENKO-158/add-gcp-support-for-one-to-many"
}

:broken_heart: :umbrella: circleCI test failed.

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
try

Hello @bennettbuchanan
"RUN_BACKBEAT_CRR_TESTS=1": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/21087' with the following env. args:
{
    "RUN_BACKBEAT_CRR_TESTS": "1",
    "DEFAULT_BRANCH": "master",
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/ZENKO-158/add-gcp-support-for-one-to-many"
}

:sunny: :+1: circleCI test succeeded!


Get postcommits green and unsickbay go test

In https://github.com/apache/beam/pull/24228 we applied a general fix for some classes of flink failures - this cleans up some previous attempts to work around the issues and unsickbays a go test. I tried applying the same fix to the other flink postcommits and ran into some issues with OOMs (see https://github.com/apache/beam/pull/24254)
Part of https://github.com/apache/beam/issues/21094

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Go Flink ValidatesRunner

R: @Abacn


Implement FGetObject

Fixes #267

FPutObject is not implemented yet, do not merge.  It will be subsequently added right here.

FPutObject is also implemented, but requires a lot of testing, i will confirm once it starts working properly.

FPutObject and FGetObject are implemented and working - please review.

should we auto detect contentType as we have the file extension type?

No it is not that straightforward, it is better for user to set.


Which framework should we use?

Alright time to choose which framework to work in, here is the list: https://www.pythondiscord.com/events/code-jams/11/frameworks/
If you have experience with any of these frameworks, please go into detail and also what you like or dislike about the framework(s).
Otherwise so please let us know why the framework you have chosen is the best, is it safer? is it faster? is it easier to use?
If we all can't agree we will vote on the matter.

My vote goes to discord.py, mainly because that's what I have experience with and can go full speed with it.
As for other frameworks, I simply haven't tried them to know their pros/cons.

I have done some research and discord.py seems like a solid option. And it was updated pretty recently to 2.4 which added some features. Do you know if it is discord api v10 compatiable, since I couldnt fine any mentions of that?

I'd also suggest discord.py as it's the de-facto standard of Python-Discord communication. There's tons of help for it available online and I also have hands-on experience with it.

Do you know if it is discord api v10 compatiable, since I couldnt fine any mentions of that?

I found this buried in the repo which suggests dpy does support v10.

I'd be fine with any framework, but since discord.py seems to be the most popular option (both in this team and in general) it might be best to go with that, especially since some already have hands-on experience with it.

I don’t really have much to say, since I don’t have too much experience making discord bots, so I guess I’ll look into discord.py then.


Fictional proxy update that will cause rework

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

Closing. Pushes work.


Fix issue #1443.

As pointed out in the bug report the correct way of aligning the win_cert pointer to the next 8-bytes boundary is not correct. If the previous certificates ends at 0x1234000A, the next one should start at 0x12340010, not at 0x1234000c which is not aligned to 8 bytes.

@wxsBSD do you have some file with multiple certificates that could be used for a test case?

Let me do some digging tonight and see what I can find.

7c3f863cbff4db18689d6f0dde31e0f1c320763a30c802490709e166c859d39b has two WIN_CERTIFICATES in it. The first one starts at 0x150ae0 and the second one starts at 0x152ce0.

This doesn't seem to affect that one test case I mentioned, but I think it should be right.


Add preconditioner for TorchANI

Adjusts the last layer of the ANI output network such that the standard deviation and mean match the training data. Fixes #25

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

52 of 52 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 94.414%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
524

Relevant Lines:
555

💛  - Coveralls


Allow selecting workload entries from k8s services

@rshriram: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

lint_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test lint_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

unit-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

release-test_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test release-test_istio

integ-operator-controller-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test gencheck_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-multicluster-k8s-tests_istio

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-local-tests_istio

integ-telemetry-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
ec61b825b55c1f30dace5c528c5cad964a75cb2a
link
/test integ-multicluster-k8s-tests_istio

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

unit-tests_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

unit-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

unit-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test unit-tests_istio

release-test_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

unit-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test unit-tests_istio

release-test_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
07bbd30014906b972914e1e56c062ee043b6572f
link
/test lint_istio

unit-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test unit-tests_istio

release-test_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test unit-tests_istio

release-test_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-local-tests_istio

lint_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
fabe5356654f4a021331b30bd6d4238af29d5598
link
/test integ-local-tests_istio

unit-tests_istio
37173ee00561ad12cd07b0d3cf908a118915ce1f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram I donot understand why we need k8s native service to slect WLE.  We have already implemented SE selecting pods and WLE.  It seems this is kind of duplicate.

@hzxuzhonghu I think it may be needed during migration from VMs -> K8s?

@googlebot I consent.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
37173ee00561ad12cd07b0d3cf908a118915ce1f
link
/test unit-tests_istio

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
37173ee00561ad12cd07b0d3cf908a118915ce1f
link
/test unit-tests_istio

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
37173ee00561ad12cd07b0d3cf908a118915ce1f
link
/test unit-tests_istio

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-mixer-k8s-tests_istio

lint_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-mixer-k8s-tests_istio

lint_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test lint_istio

integ-galley-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-mixer-k8s-tests_istio

lint_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test lint_istio

integ-galley-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-security-k8s-tests_istio

integ-local-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-local-tests_istio

release-test_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test release-test_istio

unit-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-operator-controller-tests_istio

integ-mixer-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-mixer-k8s-tests_istio

lint_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test lint_istio

integ-galley-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
44b95de85dd839782c7b4dbd62fb17cfda794122
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Not sure, why those all failed. Everything passes locally, looking into it.

@hzxuzhonghu , and @ramaraochavali this should be ready for re-review if you could. Thanks!

@rshriram: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu / @ramaraochavali / @howardjohn PTAL. I fixed the issues, but we still have a bug in that GetProxyServiceInstances for a workloadentry should return the k8s services and service entries for that workload. But today, it only returns the service entries.
Overall, the code that we have today for handling the entire eds, after the workload entry change, is very clunky. We are firing events from one registry into another, and doing a bunch of co-ordination. I would suggest we rework this code in the light of workload entry changes, such that we treat pods and workload entries as just one pool of endpoints uniformly, with common functions for activities like proxyServiceInstances, servicesForEndpoint (used during endpoint events), endpointsForService (used during endpoint events and instancesByPort).

@rshriram totally agree on the refactoring. This is useful for endpoint slice as well

I have one doubt, with k8s service selecting workload entry, do we still really need service entry selecting pods? I am mainly concerned with the performance related.
Maybe I should file an issue to discuss.


Update failedpython.py

AI Pull Request Summary:
The pull request made the following changes to the file failedpython.py:

Removed: The line import random was removed.
Added: The line impfort random was added, which appears to be a typographical error.

Summary:
This pull request introduces a bug where the correct import statement for the random module has been incorrectly modified. Instead of fixing a bug, this change introduces an error in the code. Therefore, this version does not contain any corrections or bug fixes.


test(cdk-experimental/menu): fix test failure

Fixes a test failure that seems to be due to a couple of overlapping PRs landing at the same time.
cc @andy9775


use react-i18next useTranslation hook

:lock: PR author to merge via git-multi-pr merge

Closing, not ready yet


Add GPU_Persistent map

Adds support for a persistent GPU map, that can be used to fuse kernels. It allocates a fixed number of thread blocks (a configurable fraction of #SMs on the device multiplied with a fixed multiplier to control occupancy).
The GPU_Device maps inside a GPU_Persistent map are implemented as loops, in case the device map has a larger range than the number of threads allocated.

@JanKleine you know you could have applied all the updates in one batch, right? Now our CI is overloaded... I'll cancel the older builds.

Oh, I'm Sorry about that, I only realised that later, won't happen again


Are we documenting our testsuites, and usage ? E2E has no license.

Describe the bug
Ref #1896 ... Criteria ...

The project MUST use at least one automated test suite that is publicly released as FLOSS (this test suite may be maintained as a separate FLOSS project). The project MUST clearly show or document how to run the test suite(s) (e.g., via a continuous integration (CI) script or via documentation in files such as BUILD.md, README.md, or CONTRIBUTING.md)

Issues

[x] The https://github.com/epinio/epinio-end-to-end-tests has no license information
[x] Unclear if we document how to run the make targets for testing. Especially for outside of CI.
[x] Unclear if us having GH CI flows is also a Met The Criteria.

We are documenting our tests in docs/howtos/acceptance_tests.md of the epinio repository.
Wait on the e2e readme tweaks before closing this.


[#6938] Rename agent config

Codecov Report

Merging #6939 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6939      +/-   ##
==========================================
- Coverage   39.33%   39.32%   -0.01%
==========================================
  Files        3222     3222
  Lines       95061    95062       +1
  Branches    11891    11891
==========================================
- Hits        37391    37387       -4
- Misses      54683    54686       +3
- Partials     2987     2989       +2

Impacted Files
Coverage Δ

.../navercorp/pinpoint/bootstrap/config/Profiles.java
0.00% <ø> (ø)

...rp/pinpoint/bootstrap/agentdir/AgentDirectory.java
43.18% <0.00%> (ø)

...pinpoint/profiler/instrument/AccessorAnalyzer.java
57.14% <0.00%> (-8.58%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.00% <0.00%> (-3.13%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.90% <0.00%> (-1.94%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
72.50% <0.00%> (-1.67%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.92% <0.00%> (+0.70%)
:arrow_up:

...profiler/context/compress/GrpcSpanProcessorV2.java
57.14% <0.00%> (+0.77%)
:arrow_up:

...ofiler/monitor/metric/gc/GarbageCollectorType.java
100.00% <0.00%> (+20.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb197b1...48d0ec3. Read the comment docs.


Clarify the doc about getting set up with Google Cloud Monitoring

with respect to where Container Engine metrics will be. Multiple users
have been confused by this doc.
@vishh

Can one of the admins verify this patch?

LGTM


fix(semantic-release): run npm install inside the dist folder

Description
This PR updates the place where the action runs the npm install. The place where it was being run was where there was already
a package.json file that was interfering with the dependencies that were getting installed when the action runs (to support a different semantic version).
By running the npm install in the dist folder we are adding the dependencies in a folder with a package.json with no dependencies, allowing
to trully use any semantic release version that we want.
This is the error that the action was producing before:

Changes

fix(semantic-release): run npm install inside the dist folder

🚀 PR created with fotingo

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 89.189%

Totals

Change from base Build<PHONE_NUMBER>5:
0.1%

Covered Lines:
46

Relevant Lines:
49

💛  - Coveralls


sliders with more than one handler. (feature request)

It would be nice that the sliders could have 2 or more values.
for example, i need for my application an slider with 2 values: one for the minimum of a given variable and the other for the maximum.
there are a react component called react-slider that does that https://cell303.github.io/react-slider/
but there are not too much developers in that project.
thank you in advance, you work is awesome. :)

Thanks @mercuriete - dupe of #779


[WIP] Add secio & move to pull-streams

Not finished yet
Closes #63

I'm pretty close to passing tests, there is just one issue left to fix. When initiating the secio protocol multistream-select seems to loose one message, which is very unfortunate.

Adding the below snippet to https://github.com/diasdavid/js-multistream/blob/master/src/listener.js#L62
      if (handlers[msg]) {
        // Protocol supported, ACK back
        encode.write(new Buffer(msg + '\n'));

        if (conn.cork) {
          conn.cork()

          setTimeout(() => {
            conn.uncork()
          }, 100)
        }
        console.log('listener ready')
        return handlers[msg](conn);

fixes the issue.

Depends on

https://github.com/libp2p/js-libp2p-secio/pull/8
https://github.com/dignifiedquire/pull-length-prefixed/pull/3
https://github.com/multiformats/js-multistream/pull/19
https://github.com/libp2p/js-libp2p-spdy/pull/16
https://github.com/libp2p/js-libp2p-tcp/pull/20
https://github.com/libp2p/js-libp2p-identify/pull/2

@dignifiedquire just to confirm, this just depends on merges and releases, all the rest is 👌 ?

What was the magic to not need node-forge anymore?

@dignifiedquire just to confirm, this just depends on merges and releases, all the rest is 👌 ?

Secio yes, but some of the other tests do not yet pass with all the new pull-stream things. Especially webrtc as that isn't migrated yet, and I'm having some issues with websockets, probably due to the halfOpen issue.

What was the magic to not need node-forge anymore? libp2p-crypto? It doesn't require to be injected every single time anymore? @haadcode will be happy :)

This: https://github.com/libp2p/js-libp2p-swarm/blob/56e558ea86c1eb5b5355ade8cda9652d1589c408/.aegir.js#L9-L12

This: https://github.com/libp2p/js-libp2p-swarm/blob/56e558ea86c1eb5b5355ade8cda9652d1589c408/.aegir.js#L9-L12

Almost @haadcode, almost :) :D

All tests are now ported and mostly passing. Only some related to websockets are still failing:

https://github.com/libp2p/js-libp2p-swarm/blob/ea9c93c48e08f4d9c6f6bd53e1721f9f688aef26/test/09-swarm-with-muxing.node.js#L165
https://github.com/libp2p/js-libp2p-swarm/blob/ea9c93c48e08f4d9c6f6bd53e1721f9f688aef26/test/browser-02-swarm-with-muxing-plus-websockets.js#L49

Started doing some fixes for the websocket problems in

https://github.com/pull-stream/pull-ws/pull/14 and
https://github.com/libp2p/js-libp2p-websockets/pull/18/commits/d6c6aeaf196c8399abc5f7e00549eeace94d6382

@dignifiedquire having an hard time getting the stream muxing tests to pass:
    stream muxing with spdy (on TCP)
      ✓ add
      3) handle + dial on protocol
      4) dial to warm conn
      5) dial on protocol, reuse warmed conn
      6) enable identify to reuse incomming muxed conn
      7) with Identify, do getPeerInfo
      - make sure it does not blow up when the socket is closed
      - blow up a socket, with WebSockets
      ✓ close one end, make sure the other does not blow (1006ms)

Last things before merge

[ ] point to lib instead of source
[ ] add documentation about pull-streams (same as libp2p-tcp)
[ ] make the encrypted channel be a option set by a func just like connection.reuse - https://github.com/libp2p/js-libp2p-swarm/pull/67#discussion_r77364562

make the encrypted channel be a option set by a func just like connection.reuse

This is done, needs the new secio api: https://github.com/libp2p/js-libp2p-secio/pull/17

All tests pass locally when using the above mentioned secio branch plus https://github.com/libp2p/js-libp2p-webrtc-star/pull/19

Changes Unknown when pulling 6091e94eaa3f06b181813761bcac28ee627b53a2 on secio into ** on master**.

Changes Unknown when pulling 6091e94eaa3f06b181813761bcac28ee627b53a2 on secio into ** on master**.

@dignifiedquire why do we have coveralls badges all over again?

Changes Unknown when pulling 6091e94eaa3f06b181813761bcac28ee627b53a2 on secio into ** on master**.

@dignifiedquire why do we have coveralls badges all over again?

trying to disable them one at a time, but they are enabled by default :(


Improved payload (Attempt 3)

The biggest highlight is that it supports refreshes.  Some additional bug fixes are included.  See commit descriptions.

Thanks, I merged the PR and refactored the payload generation into separate function so that I could use it in Migen simulation.
The code for simulation is here. You can try playing with it, it may be helpful for testing the payloads, altough it is very slow and not suitable for real payload sizes.
> python tests/test_payload_executor.py 8 10 12
Using generated target files in: build/zcu104
Generating payload:
  tRAS = 5
  tRP = 3
  tREFI = 977
  tRFC = 45
  Payload size =  0.04KB /  4.00KB
  Payload per-row toggle count =  0.00M  x3 rows
  Payload refreshes (if enabled) = 100
Payload length = 1024

Simulating payload execution ...
PC =   1023  LC =      0
Finished

Info:
  cycles = 8147
  read_count = 0
  overflow = 0

DFI commands history:
ACT  x   1: start_time = 78 group_time = 5
PRE  x   1: start_time = 83 group_time = 3
ACT  x   1: start_time = 86 group_time = 5
PRE  x   1: start_time = 91 group_time = 3
(...)
ACT  x   1: start_time = 7094 group_time = 5
PRE  x   1: start_time = 7099 group_time = None
Total execution cycles = 8147

One important note is that the NOOPs at the end of a payload always get executed. I think this was the reason why I slighlty miscalculated execution time when we were discussing it. You have to keep this in mind or we can try reserving a new RETURN instruction (e.g. NOOP with maxium value of timeslice) that would terminate the execution earlier. If you think this would be required please open an issue so that we can discuss the format of such instruction.

Thanks, I merged the PR and refactored the payload generation into separate function so that I could use it in Migen simulation.
The code for simulation is here. You can try playing with it, it may be helpful for testing the payloads, altough it is very slow and not suitable for real payload sizes.
> python tests/test_payload_executor.py 8 10 12
Using generated target files in: build/zcu104
Generating payload:
  tRAS = 5
  tRP = 3
  tREFI = 977
  tRFC = 45
  Payload size =  0.04KB /  4.00KB
  Payload per-row toggle count =  0.00M  x3 rows
  Payload refreshes (if enabled) = 100
Payload length = 1024

Simulating payload execution ...
PC =   1023  LC =      0
Finished

Info:
  cycles = 8147
  read_count = 0
  overflow = 0

DFI commands history:
ACT  x   1: start_time = 78 group_time = 5
PRE  x   1: start_time = 83 group_time = 3
ACT  x   1: start_time = 86 group_time = 5
PRE  x   1: start_time = 91 group_time = 3
(...)
ACT  x   1: start_time = 7094 group_time = 5
PRE  x   1: start_time = 7099 group_time = None
Total execution cycles = 8147

One important note is that the NOOPs at the end of a payload always get executed. I think this was the reason why I slighlty miscalculated execution time when we were discussing it. You have to keep this in mind or we can try reserving a new RETURN instruction (e.g. NOOP with maxium value of timeslice) that would terminate the execution earlier. If you think this would be required please open an issue so that we can discuss the format of such instruction.

Or maybe it would be better to use NOOP with timeslice 0 and to change interpretation of timeslices to be exactly timeslice cycles instead of timesclice + 1 cycles as it is now. This way instruction of value 0 (after encoding) would terminate the execution, which seems sensible.

Or maybe it would be better to use NOOP with timeslice 0 and to change interpretation of timeslices to be exactly timeslice cycles instead of timesclice + 1 cycles as it is now. This way instruction of value 0 (after encoding) would terminate the execution, which seems sensible.

I think an explicit return statement is a cleaner interface, as we don't have to worry about the exact number of cycles in the NOOP and account for them.  I think NOOP with time slice 0 sounds like a good way to do it.

I think an explicit return statement is a cleaner interface, as we don't have to worry about the exact number of cycles in the NOOP and account for them.  I think NOOP with time slice 0 sounds like a good way to do it.


We ship old copies of files to users as part of the migration script

Cause
As part of the migration script, we check if files in a user's prototype match any of the files we released in older versions of the kit. To do that comparison we include copies of the old files in our npm package.
Consequences
Our npm package is larger than it needs to be.
Impact of debt
Low
Effort to pay down
Medium

Comparing checksums should be sufficient for this.

Alternatively, we could consider just removing the migration script...


add some test files

Hi dear
this is only testing for creating another MD file and sending a merge request to another person.
plz reject it, I just wanna see how it works.
Many tnx

Please don't use public repositories followed by thousands of people for your experiments.


Added permission policy on ecr repos to permit another AWS account to ecr:* actions

Added a new parameter on aws-kubernetes module to add a permission policy on all the ECR repos managed.
This way another account can pull/push etc on the ecr repos

I will hold this PR.
We defined this module as the minimal setup required to spin up a Kubernetes Cluster. I think we do not need ecr permission to deploy it. If i am wrong, please let me know ;)

The ecr access is enabled only if you set the variable ecr-additional-pull-account-id . We need it when working with multiple cluster for the same customer on multiple aws account

The ecr access is enabled only if you set the variable ecr-additional-pull-account-id . We need it when working with multiple cluster for the same customer on multiple aws account

I don't know what @ralgozino and @phisco thinks about it, but it sounds like something that Delivery team has to setup in clients infra repository instead of being part of the Kubernetes module itself.

If we are creating ECR repository with the module (with lifecycle policy, iam user access and so on), i think we should cover "Delivery team" customization use case.

If we are creating ECR repository with the module (with lifecycle policy, iam user access and so on), i think we should cover "Delivery team" customization use case.

Maybe the ECR part should not be there. @phisco and @ralgozino are doing an assessment to address this kind of situation

@angelbarrera92, we definitely have to decide what should and should not be part of the module, you are absolutely right! That's clearly something we should address and will benefit of our assessment, meanwhile I think that using correctly the provided registry by any cloud provider should be one of our requirements. So I think this PR can be merged.

one more approval and we can merge it.


Fix spelling of “DigitalOcean”

Digital Ocean → DigitalOcean
DigitalOcean is the correct spelling as can be seen on digitalocean.com.
I intentionally did not update any keywords or URLs as well as the console output in the DigitalOcean example.

Deploy preview for docsdocker ready!
Built with commit 00330b5ba06366351d2afec897a5206ad195632b
https://deploy-preview-8938--docsdocker.netlify.com


Is it possible to use with apollo server?

I see inside examples, it needs some metadata to be defined in graphql scheme. So I am just wondering if it may be difficult use with apollo server.

Closing issue because its a duplicate of #25.


Mahou Daisakusen freezes when pausing

I set game port 0 to game pad by host keyboard. After the loading screen and intro, press S, then A. Then select ship with arrows and x keys. Go past dialogue with the x key. Press S key to pause the game. Game then freezes. On the bottom GUI, the CD icon keeps flashing.
Game needs to unpause when pressing the S key after pausing

The problem was CDDA status was not put back to PLAYING after CDDA RESUME command.  I've pushed the source with a fix.
Thank you for finding it!


Fix Close() to also wait for view transactions and fix tests as well

For more details about the bug see here:
https://github.com/coreos/bbolt/issues/90

can you also change the documentation to make this clear?

I could, but IMHO the documentation is pretty clear already:
https://github.com/coreos/bbolt/blob/master/db.go#L448
Close releases all database resources. It will block waiting for any open transactions to finish before closing the database and returning.
What do you propose to change it to?

ah. ok.
@gyuho can you get this merged?


Simplify installing and referencing authentication services

Overview
With the changes proposed in #2288 , we should have a way to easily deploy and install the standard authentication service for EnMasse service admins. A controller managing the provisioning and installation of the standard authentication service would simplify the work of an EnMasse service admin.
In addition, a service admin might want to be able to control which authentication services are available to a tenant. And the tenant should not have to care about authentication service details such as location of CA cert secrets.
Requirements

As a service admin, I want to install the standard authentication service independently of the 'core' EnMasse system
As a service admin, I want to configure the authentication services available to the messaging tenant
As a messaging tenant, i want to list the available authentication services
As a messaging tenant, I want to reference an authentication service when creating an address space

Design
Installation of standard authentication service
Design doc: https://github.com/EnMasseProject/enmasse/blob/01255db111ec553a0fdbd575d51c62634f47cf1c/documentation/design/proposals/auth-service-controller.adoc
The existing keycloak-controller logic that creates realms in the standard authentication service will be moved to the address-space-controller. The address-space-controller already deals with configuration related to an address space, and is already checking for realm availability in Keycloak.
The keycloak-controller component will be changed to watch StandardAuthenticationService resources, and create the standard authentication service as specified by the resource. Some of the logic of creating keycloak resources already exists, but will now be created based on the creation of a StandardAuthenticationService instead of by default.
Defining authentication services
Design doc: https://github.com/EnMasseProject/enmasse/blob/01255db111ec553a0fdbd575d51c62634f47cf1c/documentation/design/proposals/auth-service-resource.adoc
Tasklist

[x] Move existing per-address space keycloak-controller logic into address-space-controller
[x] Create CRD for the StandardAuthenticationService resource and modify keycloak-controller to create deployment and resources needed for keycloak based on it
[x] Remove standard-authservice templates, and move keycloak-specific templates to a new keycloak-controller that is included in the default install bundles
[x] Create CRD for the AuthenticationService and have keycloak-controller create that
[x] Modify address-space-controller to watch AuthenticationService resources and look for them in the AddressSpace definition.

@rgodfrey, @k-wall,
Now that I’m in the implementation of this, I wonder if it would be better to unify the AuthentiationService and StandardAuthenticationService types.  This is to avoid another NoneAuthenticationService type and pollution of the operator UI.
Instead, I’d like to add a type field and per-type properties in the AuthenticationService spec. This will make it easier to manage for the admin I think, and also easier to reconcile the resources. The status field can be used to provide a unified “run-time” view of host, port, certs etc

@lulf I'm fine with this - reducing the number of resources is generally a good idea I think

New format:
apiVersion: admin.enmasse.io/v1beta1
kind: AuthenticationService
metadata:
  name: myservice
spec:
  realm: myrealm // Optional, default is to use one unique to the address space
  none:
    certificateSecret: // Optional: creates on by default if not specified
      name: none-authservice-cert

apiVersion: admin.enmasse.io/v1beta1
kind: AuthenticationService
metadata:
  name: myservice
spec:
  realm: myrealm // Optional, default is to use one unique to the address space
  standard:
    credentialsSecret:
       name: keycloak-credentials
    certificateSecret: // Optional: creates on by default if not specified
      name: standard-authservice-cert
    datasource: // Optional; By default uses embedded h2 database
      type: postgresql
      host: postgresql-service
      port: 6666
      database: mydb
      credentialsSecret:
        name: dbcredentials

apiVersion: admin.enmasse.io/v1beta1
kind: AuthenticationService
metadata:
  name: myservice
spec:
  realm: myrealm // Optional, default is to use one unique to the address space
  external:
    host: example.com
    port: 5671
    caCertSecret:
      name: ca-secret
    clientCertSecret:
      name: client-secret

In addition, all resources will have the following status section:
status:
  host: hostname
  port: port

Fixed in #2415


Notifications on the desktop and dual-monitor

Hi. I have two monitors. Primary and secondary. The notification displayed on a secondary monitor that is disabled.
Archlinux. DE: Cinnamon 3.0.7. Messenger 1.5.0.beta 1

Thats probably a setting on your side. The notification always display in the primary monitor as set in your settings.
There is nothing we can do for you.

the same problem and Skype. because the the notification is not displaying means of DE

Sorry to tell you but your sentence makes no sense...
Cinnamon probably as a setting to specify which screen to use when displaying notifications.

V1 not supported anymore


What about docs?

Hey I need help creating the Documentation

[ ] Create docs folder
[ ] Create new index.md document
[ ] Turn on github pages
[ ] Decide if we want something more complex


How to retrieve contact normal vectors for collisions (Possibly via SDF gradient)?

We want to retrieve the contact normal vector at each contact point. Currently, the contact information includes geom_a, geom_b, link_a, link_b, positions, and forces, but not the contact normal. The direction of the normal is often crucial for tasks like manipulation, friction modeling, or force distribution.
Is there a built-in way to access contact normals? If the geometry is stored or represented via a Signed Distance Function (SDF), it seems possible to compute the local surface normal from the gradient of the SDF at the contact point. However, I haven’t found a direct API for that.
Is there a recommended approach or workaround to obtaining the contact normal? If so, could you point us toward any relevant documentation or methods? If not, do you have plans to expose the contact normal in a future release? Any guidance is appreciated.

There's a function here drawing visualizing rigid contacts. contact_data.normal reflect the normal of this contact pair.


Change the name of the dangerfile test case file.

Cookbook version
all of them
Chef-client version
Any
Platform Details
Doesn't matter
Scenario:
test/fixtures/cookbooks/test/templates/dangerfile* - change the name of test dangerfiles.  We use a Dangerfile for linting and the names are getting confused.

Fixed by #168


Get rid of undesired "Description" headings

This fixes about 60 instances of #117 in the Beast project, such as this method page and this overload page.
And many more instances of #109 in json, Beast, and URL.

oh this is nice