Discussion: Settle on Tags for Blog Posts

Now that we have a pretty well set UI for the web site, I'd like to see about settling on some tags for blog posts.  I've gone through all 43 of the tags on the current site.  A chunk of them have no posts, and another chuck have less than 5 posts.  There are actually only a few tags that have more than 20 posts (so at least 3% of the total number of posts).  Based on all that poking around, I'd like to suggest the following tags.  NOTE: This list has been updated based on conversations below
Community (shown as Community Updates)
Conferences
Deep Dives
DevCon
Developer (shown as Developer Updates)
Prerelease (shown as Prerelease Announcements)
Release (shown as Release Announcements)
April Fools (this is force sorted to the bottom of the list)
We probably have space to have one more tag without making the index pages look strange. So if there are other tags we feel we really want, we can add them. I'd also like to suggest that blog posts not have more than three tags. After three the tag list on the index card almost always wraps to a second line. It's not the end of the world, but it does look funny.
I've tried a few different things to get the old tags out of Drupal, but I haven't found anything that will give them to me. I suspect by the time I write something to map the old tags to the new tags and insert that into the markdown files that we could just go through the 600 blog posts by hand and tag them anyway.

We could perhaps merge DevCon into Conferences, which would also then encompass RC3, User Groups, LinuxTag, whatever. I don't have any feeling for what people might search for, and thus whether it muddies the water to mix internal and external conferencing; it might be that nobody really uses the tags anyway (except me, to find old announcements), after all.
We've had long-standing desires to have Feature Friday or similar, in which we could maybe dive into a specific aspect of Kodi. Whether this remains an unattainable goal matters less here than how we'd tag such articles: Feature? Focus? Deep Dive? Under the Hood? Hints and Tips? We have a couple of Addon focus articles that would fall into this bucket.
Scrolling through the last few pages of blog posts, and seeing what's there... where would we put sponsor announcements, or calls for donations? News? General?
No problem with a limit on multiple tags. It looks like we're perhaps heading for tags-as-category-labels, anyway, in which case most things should really fall into a primary category of some kind.

I saw the Feature Friday tag, and I like that idea if we're gonna do it.  I'd definitely go with something more generic, and I kind of like Deep Dive.  I just don't want a tag that has like 2 posts from 5 years ago. I'd say sponsor announcements and call for donations could go under Community Updates.  If we add Deep Dive and April Fools, then we still easily have space for one more tag.  I wouldn't do something like General or News though. That's kind of what the All News link is for.  But at the end I really want these to feel right for the folks doing content management. So I'm also OK with scrapping the whole list and using a different one.
And yes, I think the tags now are a bit more like categories, and we could rename them if we wanted to.
I think the tags can be useful (and used) if they have some meaning and are well surfaced on the site. The dropdown box on the current site doesn't really help with that now, especially if you try a couple and find no posts or just a couple of old ones.  It's one of the things I like about the new layout. The tags listed are only those in use, and the number gives you a sense of how much content you'll find there.

I like the idea of DevCon having it's own tag.  I've updated the proposed list in the initial issue post to reflect the addition of Conferences and Deep Dives tags.

I have created a blog-cleanup branch and tagged posts going back to 2010 (and some older than that for things like releases).  https://kodi-tv-staging.netlify.app now has the updates from this branch.

The updates have been reviewed and OK'd. Merged with staging.


No Restic use possible

I use restic backup program.
Anytime i tied to get snapshots listing from the Mounted AMAZON DRIVE  i got a error "unable to open repo: wrong password or no key found".
If i tried the same with EXPANDDRIVE (mount to another Drive) no problem. I got the snapshotlisting.
Simple FileCopy to Drive is no problem.
I use Windows 7
has install DokanInstall_0.8.0
1.6.2 Restic verison.

This project is not using version 0.8.0 almost half a year.

correction
The settings of ACD Dokan.net show´s me Version <IP_ADDRESS>

Should be ok in 1.7.2. Spent whole night trying to test it with constant Amazon timeouts.

I got <IP_ADDRESS> now and still no succes. I used a small subfolder within 25kb (not the 180GB i tried before) but the same error appears right after i enterd the password.
I download the folder no problem. I used the password to this copyed folder no problem. I can still see the snapshot. but on the mounted volume, no succes.


SUGGESTION: add supress variable to data object of select_node event

It would be handy to know in the select_node event if the change event was supressed.
Suggestion:
line 3619
this.trigger('select_node', {
                   'node': obj,
                   'selected': this._data.core.selected,
                   'event': e,
                   'supress': supress_event
               });

Please open a PR for this.


Add a 'condensed' mode that absorbs cached adds/deletions into mods

Cached adds and deletions are essentially equivalent to cached modifications, as you know that you've staged them for a commit.  The un-staged additions/deletions are the interesting ones ;)  This is mostly to reduce the clutter a little bit in preparation for displaying multiple tags on the same commit.

you sir are awesome!

I've just been maintaining a lot of changes for my own workflow, I'm glad to hear that someone else appreciates them :)


NavigationView UI looks off when changing high contrast modes

Describe the bug
When changing high contrast modes, you can see weird patches in the NavigationView.
Steps to reproduce the bug

Start in High Contrast White
Change to High Contrast Dark

Expected behavior
It shouldn't look like screenshot 2 and should look like 3.
Screenshots
1

2 (look at the white patch)

3 (this is how it should look)

Version Info
WinUI 2.4
NuGet package version:
Microsoft.UI.Xaml.2.4_2.42005.18002.0

Windows 10 version
Saw the problem?

Insider Build (xxxxx)
Yes

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

related internal issue

Potentially related issues on this repo: #1437 #2138.
Agree with Stephen's assessment above that while this is definitely broken, it is a less common user scenario so thankfully it isn't seen often.


added new script for simple crc usage

Its my first commit for hacktober fest. Please let me know if you have any suggestion to code or a way i did PR.
Cheers

@sobelek  Thank you for contributing, please star our repository.


Initial Challenge Setup - Payment Split Contract

The setup is like this; eth-tech-tree is a CLI for downloading, submitting and managing which challenges a user has completed. The repo that houses all the challenges in called eth-tech-tree-challenges. Each challenge is a new branch on that repo.
Follow the example left by the Token Wrapper WETH challenge and see how that challenge is configured in the challenges.json file in the eth-tech-tree repo.
{
    "type": "challenge",
    "level": 1,
    "name": "token-wrapper-weth", // Branch name
    "label": "Token Wrapper - WETH",
    "repo": "https://github.com/escottalexander/scaffold-eth-2",
    "testHash":"cdef2b9c0051c45a8ce2c1ec14a7446419496a018a6dc114735cce9de3a4f249",
    "testFileName":"WrappedETH.t.sol",
    "tags": ["DeFi"]
  },

Here are the steps for adding a new challenge:
Creating a new challenge

Fork and download the eth-tech-tree-challenges repo
Create a new branch based on the main branch (which is set up to be a template for any challenge) with the name of the challenge e.g. 'percentage-payment-splitter'
Write out a solution to the challenge in solidity using best industry standards as generically as possible by editing Challenge.sol and changing it's name to match the challenge
Write tests that cover the most common pitfalls and guarantee the contract operates as expected (Challenge.t.sol) - change it's name to match the contract
Update README in your challenge to give the user clarity about what they must accomplish and also any helpful resources (see the token-wrapper-weth challenge for an example)
Commit and push your changes to your remote repo, creating a new branch on your remote git push
Submit a PR to the main eth-tech-tree-challenges repo pointed to the branch that matches your challenge name e.g. 'percentage-payment-splitter'

Later, in another task, we will erase your specific solution code from the git history for your new branch in eth-tech-tree-challenges.

Percentage Payment Splitter challenge specifics
This challenge is a direct descendant of the multisend challenge so you might consider inheriting some design choices from that challenge: https://github.com/BuidlGuidl/eth-tech-tree-challenges/tree/multisend
This challenge will require users to learn the gotchas of splitting payments by percentages in a contract. They should be forced to think about precision and overflow errors. I envision that the contract will receive a request to send ETH or tokens along with an array of recipients and an array of uints that specify the percentage that goes to each recipient. Feel free to re-imagine things if you feel that it serves the purpose better.
Feel free to ask any questions or express any ideas that will help the end user learn through this challenge.

I'll take this on


Fix typo in spec

Fix typo in spec - 'Failed to update package depencencies'

Please move this commit into the other PR.


Add ButtonsGroup component

Thanks for your work <3
I reworked it quite a lot. This component was a nightmare to get right.


Intermittently all Products load in webpart

Describe the bug
Some Products are hidden in configuration in SitePages/CustomLearningAdmin.aspx. Sometimes all products load in webpart when page load (/SitePages/Get-started-with-Microsoft-365.aspx). Other times only products that are not hidden load.
To Reproduce
Intermittent issue, sometime page loads correctly with selected products hidden as required
Expected behavior
Only products not hidden should show.
Screenshots
Incorrect behavior

Correct Behavior

Learning Pathways version number
<IP_ADDRESS>
Additional context

I see that you are on the latest version. Does the Learning Pathways installation use multiple languages, or only a single language?

I see that you are on the latest version. Does the Learning Pathways installation use multiple languages, or only a single language?

Multiple languages is turned on but not bring used.

Thanks - some further questions:
Is this something that end users see, or only administrators?
How frequently does this occur?
Would users in your organization have a browser or user profile set to a default other than English?
When did the issue begin?

Thanks.
The issue is happening intermittently, might not happen for days, then more frequently for a few hours. It affect admins and standard users.
Browsers would be set to English as default, many users utilise Citrix desktops, so standard setup. A user might have the page load correctly one day and not later that day.
I'll turn off multi language on the site and see if it occurs less.

This is a good next step. Language settings will change the user experience based on their default or selected language from the LP landing page. As this is intermittent and others have not reported the same in the latest version, we are unable to reproduce the behavior at this time.  I will watch out for updates.

To me this implies that you have multiple caches with the same parameters... I would clear the cache out... i.e. delete all entries in the main sites CustomConfig list with a title of "CustomConfig"... so don't delete any entries with a title of CustomCDN or CustomSubCategories.  After deleting all those entries return the the CustomLearningAdmin.aspx page and refresh it which will reset the cache and see if that doesn't fix it.

Thanks @juliemturner and @FormerlyJelly
I've set the site to just English and deleted the CustomConfig files, so now there is just one newly create CustomConfig file for us-en.
I'll monitor page loads and see how it goes.

I'm going to close this due to lack of activity.  If you're still having issues, please feel free to open a new issue and reference this one providing more details.


Question

I am using firebase realtime database and example "AutomaticPlantWatering.ino". Compilation gives  following error
sketch\AutomaticPlantWatering.ino.cpp.o:(.literal._Z5setupv+0x88): undefined reference to bool FB_RTDB::set<FirebaseJsonArray>(FirebaseData*, char const*, FirebaseJsonArray)' sketch\AutomaticPlantWatering.ino.cpp.o: In function setup()':
Also when i want to use following function
FirebaseData fbdo1;
FirebaseData fbdo2;
Firebase.RTDB.set(&fbdo2, path + "/Dimmer" + j + "Speed", 0);
program throw following error
no matching function for call to 'FB_RTDB::set(FirebaseData*, StringSumHelper&, int)'
Please help and at least add one example to set and read a variable from realtime database

Due to missing the & operator, please edit this line 217 from
https://github.com/mobizt/Firebase-ESP-Client/blob/52e29812b23357d354fa51d866af62027c2126f3/examples/RTDB/AutomaticPlantWatering/AutomaticPlantWatering.ino#L217
to
Firebase.RTDB.set(&fbdo2, Path.c_str(), &scheduleConfig);

Don't join the string with + operator. It's not give the string literal or pointer to const char as accepted by the second parameter of that function. You should do like this.

String node = path + "/Dimmer" + String(j) + "Speed";
Firebase.RTDB.set(&fbdo2, node.c_str(), 0);


Implement Patch.ne for Python 2

This is a subtle problem that I only exposed when writing a test case for something else. A test function I was trying assumed that patch_a != patch_b would be consistent with patch_a == patch_b. But in Python 2, the != operation was not implemented, and two patch objects that were supposed to be equivalent would be seen as unequal.
Also factor out the Python 2 compatibility into quilt.utils._EqBase.

I am really not sure if _EqBase should be a "private class" as indicatined with the underscore.
For now I am ok with it. But maybe in future a more common base class should be introduced which uses _EqBase as a mixin.

Just to be clear, I use a leading underscore to indicate that something (class, function, constant, etc) is an implementation detail, rather than a public API of the library. So in this case if we decide to change or remove the quilt.utils._EqBase class, there should not be a compatibility concern with external code depending on it. I figure it is safe to mark something as being internal, but as soon as you mark it as a public API, it is less safe to take it back.

Yes that's my understanding of using underscore names too. Functions, methods, classes, arguments, ... starting with underscore are not part of a "public" api and can be removed every time in future.


fix typo in readme opennff -> openff

Had an extra n

Codecov Report

Merging #48 (26d11b3) into main (6106be8) will decrease coverage by 44.00%.
The diff coverage is n/a.

Additional details and impacted files


Made code more intutive

Proposed changes

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build (changes that affect the build system)
[ ] Docs (documentation only changes)
[ ] Test (adding missing tests or fixing existing tests)
[ ] Other... Please describe:

Checklist

[ ] I have read the CONTRIBUTING documentation
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Codecov Report

Merging #10 into master will increase coverage by 1.11%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #10      +/-   ##
=========================================
+ Coverage   96.69%   97.8%   +1.11%
=========================================
  Files          52      52
  Lines        1693    1596      -97
=========================================
- Hits         1637    1561      -76
+ Misses         56      35      -21

Impacted Files
Coverage Δ

src/helpers/helpers.h
100% <ø> (ø)
:arrow_up:

src/api/one/peers/one_peers.cpp
86.66% <0%> (-2.23%)
:arrow_down:

src/api/one/delegates/one_delegates.cpp
80% <0%> (-1.58%)
:arrow_down:

src/http/os/http.cpp
92.3% <0%> (-0.88%)
:arrow_down:

src/api/one/one_api.h
100% <0%> (ø)
:arrow_up:

src/api/two/two_api.h
100% <0%> (ø)
:arrow_up:

src/api/two/blocks/two_blocks.cpp
100% <0%> (ø)
:arrow_up:

src/api/two/delegates/two_delegates.cpp
100% <0%> (ø)
:arrow_up:

src/api/api_base.h
100% <0%> (ø)
:arrow_up:

src/api/two/peers/two_peers.cpp
100% <0%> (ø)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9057c...7536f9b. Read the comment docs.

uin64_t (balances, supply, etc) are too large a container for the String()-type on Arduino.
Using the templated method on large integers consistently results in undefined behavior.
I’d be in favor of a unified method for handling this.
Extra kudos if the solution drops the Arduino String construction in favor of string.
Best would be a single method that supports all platforms.

Ah, didn't catch the Arduino string.  You can do this:
`
#include
template
std::string toString(T val) {
std::ostringstream ss;
ss << val;
return ss.str();
}
`

ostringstream still uses heap but it is freed quickly.  This pattern can be further expanded with template specialization to provide more efficient conversions for T: integer, T: real using snprintf using local fixed buffers and not doing the dynamic memory allocation.
I thought some of the IoT boards provide the std::to_string functions which essentially do this.
This could also be solved by the pattern used in ark-iot/ark-cpp where we provide a limited implementation of the STL for platforms that don't have it.  Then the code can be written to the C++ STL standard.  That would be a larger change.

std::to_string isn’t available on Arduino because doesn’t include the STL.
The consensus is that it’s too expensive for most IoT platforms.
I’d be interested in how the sstream solution holds up. I think a unified method that maintains IoT support would be preferred over including the STL.

The thing is we use the STL on IoT.  ESP32 and ESP8266 support it (some more than others).  The STL is not expensive.  Some things in it are.  I would wager that more platforms will support it over time, espeically as C++11/17/21/xx become more ubiquitous.
In the current code base we are providing  and  implementations when not provided.  They are not expensive in any way.  They just provide additional convenience and safety.
For the purpose of this change, I would definitely leave anything std::to_string out of it and just focus on the potential removal of the function in question.
We can take the other discussion offline if you like.

Thems fighting words.
I’ll see you next to the monkey bars after school 💪
32 & 8266 support STL,
the Arduino IDE does not include it.
The compiler flag for c++11 can be added with PlatformIO.
Many Arduino boards aren’t as powerful as the Espressif chips though too.
There don’t seem to be many cases where we absolutely need it.
So why include it if we don’t have to?

I would submit we use it when ever possible due to convenience.  Without the STL, C++ is just fancy C.
We are already using it on 8266 and 32 and those products work in the Arduino IDE.  The STL is at the board support level, not within the IDE like Arduino or PlatformIO.
We only include what we need from the STL.  It is not all or nothing.

Arduino basically is fancy C,
but is closest to C++ if anything else.
It uses avr-libc.

http://www.nongnu.org/avr-libc/user-manual/FAQ.html#faq_cplusplus

You can also see this by trying to use to_string.
You’ll get a ’to_string’ is not a member of std. compiling error.
Vectors, strings, and ptr are used,
but it’s not the full c++11 STL, or we wouldn’t need to include it.
The full STL not being included is why it’s not officially considered C++.
And the reason is that while it’s perfect for desktop environments, it’s too big for microcontrollers.
Not that it won’t fit, but that it’s too lax with memory handling to be consistent and stable on IoT.

I can agree with some of that.
For to_string, a lot of that is just compilers and libraries lagging behind the bleeding edge.
The implementation of to string is not inefficient for most things like integers.  Under the hood it will just be a snprintf, which is C and reasonably efficient.  to_string is just nicer.
I think we can have our cake and eat it took.  For our current platforms, this is not a concern.  I think we should look at the problem on a case by case basis as we bring new boards online.
My vote is that we don't solve a problem until we have it and we don't hamstring development by limiting tools when we don't have an explicit reason to.
We leverage everything on every platform we can.  We provide implementations for stuff we want and don't have that is easy and makes sense like std::array and std::unique_ptr.

Given the above and the following, I see your point:
https://github.com/ArkEcosystem/cpp-crypto/pull/11
I’d be in favor of adding arduino/STL to Client & Crypto,
and dropping the toString helper methods so long as it maintains consistent support (no reason it shouldn’t).

We should probably close this out.
OP issue of while... isn’t necessary,
and these helper methods will more than likely be dropped.

Closing this PR, as the former issue isn't much necessary.
If you feel those functions aren't necessary,.. Open a new PR/issue.


napari applications tutorials

Following napari/napari.github.io#42 we are adding an Applications section that can contain more advance tutorials highlighting specific applications.
As discussed with @tlambert03 it's probably good to have these separate from the more basic introductory tutorials so that new comers and beginners aren't overwhelmed.
I also see these as slightly different from blog posts as I'd like them to be maintained and updated with time (as following a napari breaking api change), whereas a blog post I see as more capturing the state at a moment in time (though obviously they can be updated too).
I'd also love for these to be community contributed as much as possible too, so maybe after we have a couple more example ones in we could make a Contributing Guide to set expectations. I see these as more didactic and in-depth then just here's cool data viewed in napari, for that I'd like to have some form of community contributed gallery, as discussed with @jni
How does this sound to everyone?
To also keep the convo going here are a couple ideas for posts:

[x] lazy loading and compute with dask - see napari/napari.github.io#42
[ ] lazy parameter sweep with dask - see gist
[ ] custom mouse functions + 1D plots - see https://github.com/napari/napari/pull/675#issuecomment-553672258
[ ] napari + binder remote desktop - see repo
[ ] napari + omero - see tweet
[ ] painting labels + custom segmentation code - see repo
[ ] naparimovie animation example

@sofroniewn curious which ones on the list you think would be good to add to the documentation, given the development over the past few years? 😁

hmm, i'm not sure - we now have a many more plugins to draw on too curious what others think here? We could bring this convo to zulip / twitter for more folks to make requests too. Maybe we could do a poll?


Add Cluster Service Principal enrich

Which issue this PR addresses:
Fixes stale data in customer get when cluster SP is rotated.
What this PR does / why we need it:
In the case of rotation flow, we need to make sure cluster service principal is shown, one which is being used in the cluster as a primary source. Database data might be stale.

I am not sure I like this approach, I think this change can create confusion. After the cluster creation, we do use SP from RP database in some cases (check/fix permissions, start VMs, etc). This PR tries to catch the case when cx has updated secret on the cluster but has not run update on RP (which we don't have at the moment). Merging this, we will tell the customer and SRE what is the SP that the cluster thinks is, but on the actions we will be acting on a different SP. We as SRE will have no idea and no way of telling what is the SP as RP sees it, and we will not be able to advise customer in this case. At least the way it is now we can ask customer what they see in the cluster and we can check what we see in  the RP.
Even when we implement "az aro update" to pass on SP data, how can we identify that the cx has actually ran it?

I am not sure I like this approach, I think this change can create confusion. After the cluster creation, we do use SP from RP database in some cases (check/fix permissions, start VMs, etc). This PR tries to catch the case when cx has updated secret on the cluster but has not run update on RP (which we don't have at the moment). Merging this, we will tell the customer and SRE what is the SP that the cluster thinks is, but on the actions we will be acting on a different SP. We as SRE will have no idea and no way of telling what is the SP as RP sees it, and we will not be able to advise customer in this case. At least the way it is now we can ask customer what they see in the cluster and we can check what we see in the RP.
Even when we implement "az aro update" to pass on SP data, how can we identify that the cx has actually ran it?

The challenge with our database is that it will never be atomically matching cluster configuration. It just not possible in this architecture. We already have out of sync objects like worker profile and version.
And there are no reasons why customers can't rotate the credentials from the cluster itself incase they are following RedHat documentation and not Azure docs. Same pattern as with our worker profiles. If this happens, without something like this we will not be able to operate with up to date data in CLI.
From the RP context, we should never be using cluster credentials from the database to access the cluster or impersonate it in anyways. We do this currently only in the install phase where we expect that state matches and we can operate with it. And only real credentials is in the cluster, not database.
The ideal situation would be to somehow keep the database in sync, but this is not only expensive but fragile too.
I think this is not perfect, considering where we are, but I think is least bad options at this point in time

The key thing that I haven't picked up from the proposal is the intention to enable end users to rotate creds either by updating relevant secrets in the cluster OR by the means of "az update" when we implement it. My assumption was that ultimately the user will have to run "az update" so that we update the RP database and it is a required step (with or without cx updating the secrets themselves).
Also Jim has explained to me that enriched data gets written back to the DB if it is invoked on PUT or PATCH action. This is not a very intuitive flow, but the way it works is that we first enrich the doc, then we do the dynamic validation and the fixing permissions stuff that I was worried about, and at the end of the action enriched data gets written to the DB. It's confusing and non-obvious but this is how it works. We don't read this data from DB at all, even though in the code it will still appear as api.OpenShiftCluster...ClientID, you'd think it's from the DB, but it is not. The only reason it is in the database is to pass it from frontend to backend upon creation.

we should never be using cluster credentials from the database to access the cluster or impersonate

My intention is not impersonation, but the usage of ClientID for permission validation and automatic repair on update. My mention of starting VMs as an example was plain wrong, obviously it is not done with SP.

/azp run e2e


Refactored IPC classes

Codecov Report

Merging #44 (3b01714) into main (9fb151e) will increase coverage by 44.30%.
The diff coverage is 39.43%.

@@            Coverage Diff             @@
##            main      #44       +/-   ##
==========================================
+ Coverage   0.00%   44.30%   +44.30%
==========================================
  Files         16       17        +1
  Lines        906      905        -1
==========================================
+ Hits           0      401      +401
+ Misses       906      504      -402

Impacted Files
Coverage Δ

hikari_clusters/ipc_server.py
24.48% <15.78%> (+24.48%)
:arrow_up:

hikari_clusters/ipc_client.py
26.01% <18.75%> (+26.01%)
:arrow_up:

hikari_clusters/callbacks.py
39.34% <25.00%> (+39.34%)
:arrow_up:

hikari_clusters/task_manager.py
33.96% <33.33%> (+33.96%)
:arrow_up:

hikari_clusters/brain.py
32.71% <42.10%> (+32.71%)
:arrow_up:

hikari_clusters/events.py
52.77% <50.00%> (+52.77%)
:arrow_up:

hikari_clusters/server.py
44.87% <50.00%> (+44.87%)
:arrow_up:

hikari_clusters/ipc_base.py
52.38% <52.38%> (ø)

hikari_clusters/cluster.py
38.82% <60.00%> (+38.82%)
:arrow_up:

hikari_clusters/commands.py
50.00% <66.66%> (+50.00%)
:arrow_up:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd6ed5...3b01714. Read the comment docs.

Thanks @trag1c


Promise 'then' incorrect?

I believe that
https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L2569
and
https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L2572
should be this.constructor
If you implement the shim and run the tests for subclass they will fail as this.mine = 'yeah' is not defined on the returned subclassed promise.
https://github.com/paulmillr/es6-shim/blob/master/test/promise/subclass.js#L27

Those lines match the spec, eg: https://www.ecma-international.org/ecma-262/6.0/#sec-promise.prototype.then
I believe the real issue is that the ES.SpeciesConstructor method is broken -- and I bet it has something to do with your runtime environment partially implementing Species support and thus fooling the shim.  What platform are you running the tests on?

I'm on Node 8.11.4, but I tried on 10 and 12 too.  What I did was at
https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js#L2624
I added globals.PromiseShim = PromiseShim;

This give me the implementation on the global.
then in subclass.js
I replaced Promise with PromiseShim to use the implementation.

The shims are not designed to be manually installed; if you just replace the global Promise, many things won't work - since that full replacement is only meant to be used on nodes that never had it to begin with.

In other words, the es6-shim must be used in its entirety, or not at all.

I appreciate that the library is to be used n its entirety. This is something that I came across while experimenting. Still, I find it strange that this should fail, and I thought it was worth mentioning.

So it seems that Node 8, 10 and 12 have no Symbol.species on a Promise instance. And neither does the latest Chrome or Firefox. So not sue what that means.

Ok, so PromiseShim does not define Symbol.species. That seems to be the answer?

Sure - I assume because that symbol already exists where Promise needs to be wholesale replaced.

Yep, I added to PromiseShim
    if (supportsDescriptors) {
      Object.defineProperty(Promise, symbolSpecies, {
        configurable: false,
        enumerable: false,
        get: function() {
          return this;
        }
      });
    } else {
      object[symbolSpecies] = function() {
        return this;
      };
    }

and now all tests pass.
So my question is answered. I'm not saying anything is broken in the shim, as it works, but worth a note.

If you’re suggesting there’s an engine which, after including the entire es6-shim, has Symbol.species but doesn’t have it on Promise, then i would consider that a bug.

No, I'm not. I was just running the raw implementation (which as you said, is not designed for this purpose) for interest sake and came across this and was curious as to why it was failing. Now I understand why, and learnt some stuff in the process. As you rightly point out, this case should never happen within the design of es6-shim.


SameDiff: need download for TFIDF

In SameDiff results page > In "Difference" > In "Tabular"
There should be a way to download the TFIDF result words as a CSV file. Function to download should already be there.

Not priority for today


Updating home page URLs

What does this PR do?
Currently in the dev branch even when the prefix is removed in the UI, the home page URLs still append a prefix with the country code. Additionally, the URLs for the home page are using global $language, when they should instead be going through the dosomething_get_language() function which respects the following precedence:

URL prefix
User's account language if published
System default language if published
Node's default language

The home page URLs are now using the prefix as defined in the language object returned by language_list().
I've also updated the title and the CTA to use the same precedence so that URLs are in sync with the title and CTA. I did some debugging, and it doesn't look like the $node->language changes to the appropriate language on node_load(). It works fine for now in dev, but it doesn't seem to show the correct CTA when there are multiple translations.
How should this be manually tested?
Visit the home page and observe the URLs, titles and CTAs for the tiles. You can also change the prefix manually to make sure that the translations and URLs change properly with the addition of a prefix.
@mshmsh5000 @DFurnes

I think this seems okay! :ship:


@types/mocha dependency in 2.3.6 breaks when using jest

What are you trying to achieve?
I am using jest as my unit test framework for a typescript project and wish to use codeceptjs to run browser tests. I am able to run both with<EMAIL_ADDRESS>but upgrading to<EMAIL_ADDRESS>causes breaks when building my application.
It looks like the inclusion of @types/mocha as a dependency in the 2.3.6 release is conflicting with my local @types/jest definitions.
What do you get instead?
When attempting to build the project I get lots of the following errors:
node_modules/@types/mocha/index.d.ts:2680:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'beforeEach' must be of type 'Lifecycle', but here has type 'HookFunction'.

2680 declare var beforeEach: Mocha.HookFunction;
                 ~~~~~~~~~~

  node_modules/@types/jest/index.d.ts:34:13
    34 declare var beforeEach: jest.Lifecycle;
                   ~~~~~~~~~~
    'beforeEach' was also declared here.

node_modules/@types/mocha/index.d.ts:2698:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'afterEach' must be of type 'Lifecycle', but here has type 'HookFunction'.

2698 declare var afterEach: Mocha.HookFunction;
                 ~~~~~~~~~

  node_modules/@types/jest/index.d.ts:36:13
    36 declare var afterEach: jest.Lifecycle;
                   ~~~~~~~~~
    'afterEach' was also declared here.

node_modules/@types/mocha/index.d.ts:2714:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'describe' must be of type 'Describe', but here has type 'SuiteFunction'.

2714 declare var describe: Mocha.SuiteFunction;

Provide test source code if related

branch using 2.3.6
https://github.com/diversemix/bootstrap-typescript-starter/tree/codeceptjs-2.3.6-upgrade
branch using 2.3.5
https://github.com/diversemix/bootstrap-typescript-starter/tree/master
run:
yarn
yarn build
Details

CodeceptJS version: 2.3.6
NodeJS Version: v10.15.3
Operating System: OSX10.15.1
Configuration file:

exports.config = {
  tests: './tests/*.js',
  output: './output',
  helpers: {
    Puppeteer: {
      url: 'http://localhost:8080',
      show: true
    }
  },
  include: {
    I: './steps_file.js'
  },
  bootstrap: null,
  mocha: {},
  name: 'bootstrap-typescript-starter'
}

You can add skipLibCheck for your tsconfig.json and it solved problem)

As possible solution -  create inside folder with e2e tests one more tsconfig file, where modules will be listed, which used in e2e tests only

You can add skipLibCheck for your tsconfig.json and it solved problem)

While this will let me build with version 2.3.6, its a bit to heavy handed of a work around which I wouldn't want to have in my master branch, for now I've just left the project at 2.3.5.

As possible solution - create inside folder with e2e tests one more tsconfig file, where modules will be listed, which used in e2e tests only

Thanks for the suggestion, I suppose having a sub-package.json in my /tests directory would prevent my build from being affected by the codeceptjs type dependencies.
I'm new to codeceptJS so not 100% familiar with the whole API, does the inclusion of @types/mocha mean that it's exposing the whole unwrapped mocha library? If not is there was any way that the type defs could be namespaced out 🤔

I would use a different package.json for such case. Mocha and jest both testing frameworks and their globals may intersect

I'll close this as the consensus is to have a separate package.json for e2e tests. I did find https://medium.com/@elenasufieva/handling-type-declarations-clash-in-typescript-b05b10723f47 a useful read and possible solution to the problem of needing both jest and mocha with types in one project. I haven't implemented myself for though.

I open this issue because if the tests are in different folders (next to the component as an example) the package.json won't help.

There is not even about different package.json. @types/... should not be in dependencies section, it's used only to builing package, not in runtime
So, it's definitely a bug

@oceandrama I will fix this issue !


Develop upstream sync 230912

Please retest Ubuntu-CPU

Retest Ubuntu-CPU please

Retest Ubuntu-CPU please


[WIP] Conversion infrastructure

I'm doing dialect conversion in OmniZK, so I'm drafting a pass infrastructure in pliron that resembles MLIR's. I'm using mostly the same names for types and functions.
It's still WIP and is not ready for review yet. I want to get your feedback. Let me know what you think of it.

I'm doing dialect conversion in OmniZK, so I'm drafting a pass infrastructure in pliron that resembles MLIR's. I'm using mostly the same names for types and functions. It's still WIP and is not ready for review yet. I want to get your feedback. Let me know what you think of it.

Thank you !. Please give me a couple days to get back to you on this.

I'm doing dialect conversion in OmniZK, so I'm drafting a pass infrastructure in pliron that resembles MLIR's. I'm using mostly the same names for types and functions. It's still WIP and is not ready for review yet. I want to get your feedback. Let me know what you think of it.

Thank you !. Please give me a couple days to get back to you on this.

I'm going through what / how MLIR does it in more detail. Also a friend pointed me to https://mlir.llvm.org/docs/Dialects/PDLOps/, something that MLIR is doing more recently.

I'm doing dialect conversion in OmniZK, so I'm drafting a pass infrastructure in pliron that resembles MLIR's. I'm using mostly the same names for types and functions. It's still WIP and is not ready for review yet. I want to get your feedback. Let me know what you think of it.

Thank you !. Please give me a couple days to get back to you on this.

I'm going through what / how MLIR does it in more detail.

Sure. Initially, I tried to keep API closer to MLIR but some features (typed ops, etc) I was unable to implement in Rust, so I dropped them for now.

Also a friend pointed me to https://mlir.llvm.org/docs/Dialects/PDLOps/, something that MLIR is doing more recently.

This is so cool! I'm going to dig into it. Thanks!

What is your vision for error handling? I see that errors are used only in Verify trait with unwraps and asserts everywhere else.

The way I see it, unwraps and asserts, when they fail means that it's a bug in the core infrastructure. It shouldn't happen at all (ideally).
Recoverable errors are for when it isn't a bug in pliron. For example, something's wrong with the input program that it fails verification, or there's a syntax error in parsing etc. Conversion errors could be in that category too, i.e., not a compiler bug.
When I suggested that we do thiserror and anyhow::Error for the whole project, I meant wherever we deal with CompilerError (i.e., recoverable errors).

Ideally, we can even forbid unwraps on the crate level and use explicit #[allow... where unwraps are necessary.

That's extreme and may make it very difficult at a lot of places. Definitely not for Options, but if only for Errors, then maybe at some point. But right now I had only our current uses (and the ones in your PR) of CompilerError in mind.

I've been looking at MLIR's pattern rewriter infrastructure, and the whole thing (how it works, what it provides, and how it provides that - the API) is quite complex.
The rewrite drivers (greedy / dialect conversion etc) collect the operations and then the applicator applies the max benefit pattern. The rewrite drivers, if I understand correctly, in a way is provided by the walker in your PR.
Before we attempt to implement this complex system, do you think it's a good idea to try and write a conversion manually? See what difficulties, repetitions we face and then see how a system to "automate" that can be designed? If you can point me to your code which needs conversion, I can try playing with it too. That'll give us more clarity.
Ideally I'd want something much simpler than what MLIR has. Like maybe just a walker that allows modifications of the graph during the walk. But if we don't have anything good, we can go for what you're attempting - the MLIR way.
Thoughts?
btw, are you on a timeline / deadline by when you want something done or are more free to explore solutions?

I've been looking at MLIR's pattern rewriter infrastructure, and the whole thing (how it works, what it provides, and how it provides that - the API) is quite complex.
The rewrite drivers (greedy / dialect conversion etc) collect the operations and then the applicator applies the max benefit pattern. The rewrite drivers, if I understand correctly, in a way is provided by the walker in your PR.
Before we attempt to implement this complex system, do you think it's a good idea to try and write a conversion manually? See what difficulties, repetitions we face and then see how a system to "automate" that can be designed? If you can point me to your code which needs conversion, I can try playing with it too. That'll give us more clarity.
Ideally I'd want something much simpler than what MLIR has. Like maybe just a walker that allows modifications of the graph during the walk. But if we don't have anything good, we can go for what you're attempting - the MLIR way.
Thoughts?

My initial idea was to take a simplified version of MLIR infra and use it as a starting point. However, during this journey, I scratched my head many times, trying to understand the MLIR's design but plowed on. So, yes, it's pretty complex, and we might not need it as is.
I'm only beginning to implement my conversions, and I'm unsure how much of the MLIR infra I'll actually need. I agree with you to keep it as simple as possible. For now, I see "match and rewrite" and legalization parts of it as quite useful, even at this early stage. As I progress with my conversions in this PR, I'll better understand what I found useful and ditch the rest.
Here is the code where I'm implementing the conversions - https://github.com/greenhat/omnizk/blob/add-miden-new-ozkir/crates/ir-transform/src/miden/lowering.rs

btw, are you on a timeline / deadline by when you want something done or are more free to explore solutions?

I'm not on a deadline, it's my side project, and I'm free to explore solutions.

What is your vision for error handling? I see that errors are used only in Verify trait with unwraps and asserts everywhere else.

The way I see it, unwraps and asserts, when they fail means that it's a bug in the core infrastructure. It shouldn't happen at all (ideally).
Recoverable errors are for when it isn't a bug in pliron. For example, something's wrong with the input program that it fails verification, or there's a syntax error in parsing etc. Conversion errors could be in that category too, i.e., not a compiler bug.

This makes total sense. I agree.

When I suggested that we do thiserror and anyhow::Error for the whole project, I meant wherever we deal with CompilerError (i.e., recoverable errors).

Will do.

Ideally, we can even forbid unwraps on the crate level and use explicit #[allow... where unwraps are necessary.

That's extreme and may make it very difficult at a lot of places. Definitely not for Options, but if only for Errors, then maybe at some point. But right now I had only our current uses (and the ones in your PR) of CompilerError in mind.

I agree. It's quite extreme, and I choose the wording ("Ideally") poorly. :)


Missing required prop: "message"

I'm getting this:
vue.js:634 [Vue warn]: Missing required prop: "message"
I see the same message on your demo.
Thanks!

Hi, @davellanedam! Thank you for your issue!
fixed in 84fffeb5f04e049265cbcf725cf0932c761692ce
please update to 0.2.4 version

Awesome work! Thank you so much, working great now.


Aes func cover

This has the initial steps for functional and code coverage for aes.
no attempt has been done to close coverage at this point and should only serve as the skeleton for AES - and as an example for the other xcelium driven IP

This looks great and is almost ready to go in. Just need a few more questions addressed. Thanks!

@sriyerg so I think we finally got all the way through..
thanks @weicaiyang @sriyerg @tunghoang290780  for your feedback.
let me know if you have any more comment. If not please approve


bug: ingress controller does not register ingressClass and also does not watch Ingress objects

Current Behavior
I have deployed apisix ingress controller from latest Helm chart 2.0.0 and am playing with it for a few days now. CR objects like apisixRoute work fine but Ingress objects don't work.
I noticed that "kubectl get ingressclass" does not list apisix as an ingress class.
I also noticed that Ingress objects with spec: ingressClassName: apisix do not work.
namespace_selector is set to "" so I believe it should work for all namespaces.
I have checked possible missing helm chart settings for both apisix/apisix chart as well as apisix/apisix-ingress-controller chart but did not find any setting that would relate specifically to the ability to support Ingress objects.
Also, the docs do not list any special requirements: https://apisix.apache.org/docs/ingress-controller/tutorials/proxy-the-httpbin-service-with-ingress/
I am sorry that I cannot offer any specific information as there are no error messages whatsover, it just does not work at all.
Some information regarding my environment: k8s is AWS EKS 1.24, helm is 3.10.3
Expected Behavior
Ingress objects should be "watched" and acted upon by apisix ingress controller if they specify ingressClassName apisix
Error Logs
error   ingress/ingress.go:472  failed to get APISIX gateway external IPs       {"error": "resource name may not be empty"}

Steps to Reproduce
Install APISIX ingress controller via Helm chart.
Create Ingress object with ingressClassName apisix
Environment
chart-version: apisix/apix 2.0.0 with app-version 3.3.0 installs deployment- and statefulset-objects using the following container images:
apache/apisix-ingress-controller:1.6.0
apache/apisix:3.3.0-debian
bitnami/etcd:3.5.7-debian-11-r14
helm chart is deployed at a AWS EKS 1.24 cluster.

Assign this to me please

@sebschlue APISIX ingress controller currently doesn't deploy the IngressClass CR so you won't see that in the output of kubectl get ingress. By default, Ingress doesn't work cross-namespace and it will forward traffic to services in the same namespace in which Ingress resource is deployed. For cross namespace, use the annotation k8s.apisix.apache.org/svc-namespace:<namespace>.
Can you provide the Ingress configuration as well as the output of kubectl get all -A

Now I get an error message when creating an Ingress object with spec: ingressClassName: apisix
error   ingress/ingress.go:472  failed to get APISIX gateway external IPs       {"error": "resource name may not be empty"}

But Ingress object does not work --> external address is empty.
$ kubectl get ingress -A
NAMESPACE      NAME       CLASS    HOSTS                                             ADDRESS                                                                      PORTS
foo      foo    nginx    foo.tld       xxx.eu-central-1.elb.amazonaws.com   80
bar      bar     apisix   bar.tld                                            80

@sebschlue Can you provide the Ingress CR configuration once?

This is the ingress object:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: bar
  namespace: bar
spec:
  ingressClassName: apisix
  rules:
  - host: bar.tld
    http:
      paths:
      - backend:
          service:
            name: bar-service
            port:
              number: 80
        path: /
        pathType: Prefix

please refer to https://github.com/apache/apisix-ingress-controller/blob/e809cfbaaad6f6c3cbd23f5ec8e93bc1d87f543d/conf/config-default.yaml#L40


View Layouts for Frontend Pages #60

Is there more documentation somewhere on the big picture?  There's not enough in issue #60 to fully understand what you are trying to achieve or how all of this would work in Laravel.

@pdbreen Could you add a type on Layout with Enum so that each model can have its own Layout designs? We'll need the following in here:

Page
Post
Topic
Series

Could other packages then add new Types to that list for the models in their packages that need layouts?
I'll create stub Layouts for each of those models in the views directory and will also add them in data migration in the regular migrations folder.

Added LayoutManager singleton (and facade) along with a LayoutViewCreator that allow establishing a layout context for the view and making sure context is injected in every view.   Will add testing after some different layouts are added.

@pdbreen THANK YOU! I kept tripping over myself with this code.


[WIP][ZWave][Lock] Further improvements to zwave lock platform

Description:
Attempt to further improve the stability and user experience with the zwave lock platform.
This will add a lock_status attribute that will contain a string with the lock status.
The usercode slot used to unlock the lock will also be present in this attribute.
Also some more checks for state updates are don checking the alarm_type command_class for state.
This needs to be tested by someone with a schlage, kwikset or yale lock, as these use the alarm_type for reporting.
The lock I have got does not have these features.

Looks good! :dolphin:


Ctrl-P for searching files really slow after upgrade

As of few weeks ago after an upgrade when doing Ctrl-T to find a file and typing part of filename the search takes much-much longer (5-10 seconds) vs previously it was instant.
My codebase has about 1500 files in ~20 folders.
This is a recent degradation of performance.

ctrl+T or P? These commands are implemented differently.


fixes #574 - checks for cachedir trailing slash

This does not support windows operation systems. They use '' instead of '/'.
I suggest to change to something like:
private function getCacheDir($file, $forWrite)
{
  // use the first 2 characters of the hash as a directory prefix
  // this should prevent slowdowns due to huge directory listings
  // and thus give some basic amount of scalability
  $storageDir = rtrim($this->path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . substr(md5($file), 0, 2);

// ...

Windows has accepted the forward slash since Windowns NT. But I do like your solution better.

Okey. Thank you for the link. I did not know that.

On 20 Nov 2015, at 18:13, Brent Shaffer<EMAIL_ADDRESS>wrote:
Windows has accepted the forward slash since Windowns NT. But I do like your solution better.
—
Reply to this email directly or view it on GitHub.

LGTM


syn::custom_keyword as &'static str, to compare it to an ident.

syn::custom_keyword is useful, but I can't find a way to get the keyword as a str. This makes it impossible to compare a custom keyword to an Ident.
In my code I've found this workaround:
macro_rules! custom_keyword {
    ($ident:ident) => {
        syn::custom_keyword!($ident);
        impl $ident {
            #[allow(dead_code)]
            pub const STR: &'static str = stringify!($ident);
        }
    }
}

mod kw {
  custom_keyword!(set);
}

// To view the custom keyword as an `&str`
kw::set::STR

Your macro looks good to me. I don't think this needs to be built into this crate.


Review request for paper

Question or discussion topic.
This is the paper I started back in 2020 with my internship at ORNL. Will requested I get this paper submitted to a journal by the end of December, so there is still a decent bit of time for review. The Nuclear Science and Engineering formatted paper (with template from here) is here.
As a side note, regeneration of the figures/data is difficult since I did not write the scripts with much documentation back when I made them. I have noticed that some of the figures have titles, which could be removed by cropping the images if that is suggested.
How can this issue be closed?
I make changes to the paper based on the suggestions offered.

My various scribbles are complete. We can talk through them as needed. Some are likely to require discussion.

Hi Luke! Attached is my first round of comments. I found myself needing some clarification in places, so perhaps we can discuss in a future meeting.
single_col_paper-mm.pdf


Tensor name "resnet50_v1d/C1/conv0/BatchNorm/beta" not found in checkpoint files /tank/newhome/liuyi/Documents/RotationDetection-main/dataloader/pretrained_weights/resnet50_v1d.ckpt

tensorflow.python.framework.errors_impl.NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
Tensor name "resnet50_v1d/C1/conv0/BatchNorm/beta" not found in checkpoint files /tank/newhome/liuyi/Documents/RotationDetection-main/dataloader/pretrained_weights/resnet50_v1d.ckpt
[[node save/RestoreV2 (defined at /tank/newhome/liuyi/enter/envs/rod/lib/python3.5/site-packages/tensorflow_core/python/framework/ops.py:1748) ]]

not found in checkpoint files /tank/newhome/liuyi/Documents/RotationDetection-main/dataloader/pretrained_weights/resnet50_v1d.ckpt

not found in checkpoint files /tank/newhome/liuyi/Documents/RotationDetection-main/dataloader/pretrained_weights/resnet50_v1d.ckpt

杨博士您好：
Tensorflow pretrain weights: resnet50_v1, resnet101_v1, resnet152_v1, efficientnet, mobilenet_v2, darknet53 (Baidu Drive (1jg2), Google Drive).
我在原文的这个地方点击了resnet50_v1，下载了resnet_v1_50.ckpt。我复制到RotationDetection-main/dataloader/pretrained_weights。改名为resnet50_v1d.ckpt。但是还是显示找不到。

resnet50_v1d要从第二个下载地址下载，你要使用resnet_v1_50的话就把cfgs里的resnet50_v1d改成resnet_v1_50就行。但是建议使用resnet50_v1d。


importCode throwing NoClassDefFoundError

Joern importCode getting stuck for a specific repository.
Repo link: https://github.com/paypal/PayPal-Java-SDK

cc @tuxology

Thanks for reporting!
The root cause is that we marked 'gradle-tooling-api' as a non-transitive dependency in x2cpg.
There are a few alternatives to fixing this, e.g. make it an explicit dependency of javasrc (https://github.com/joernio/joern/pull/1430) or make it a regular dependency in x2cpg (https://github.com/joernio/joern/pull/1431).

I just remembered: we made it a non-transitive dependency because it's not on maven central and is only relevant for a few frontends. Let's go with #1430 then.


[cf]-added-destinations-back

Description
Added destinations back to redirects for streaming links
How Has This Been Tested?
Tested in mitlify dev env

[ ] Test A
[ ] Test B

Checklist

[X] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[X] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[X

] I have made corresponding changes to the documentation

cc:
@johnson-mage

@colefreeman what happens if you just remove those redirects? Cuz redirecting to itself seems unnecessary? The source and destination are all the same.

@johnson-mage removed redirects for streaming sources and destinations

@colefreeman Is this being used anywhere? If not, please remove, but make sure you check the docs to see if it's used anywhere first.
{
      "source": "/guides/streaming/overview",
      "destination": "/streaming/overview"
    },

@johnson-mage added back links, they are working in the dev env

@johnson-mage removed streaming overview, did not find it anywhere in the docs


Instructions for building in Windows.

I tested this instructions while building the client on my laptop. I was able to successfully build a working EXE.
The one thing that might be missing is installing WinPcap (the software, not the developer files), as I've already had that installed due to Wireshark. Please let me know if I should add this in as well.
All feedback is appreciated.

@Regner : I updated the README to include a link to the Windows guide, and I've cleaned up the steps around using Glide instead of go get. Thanks for the clarification earlier!

LGTM


full dump reporting

We need to have better reporting on how many unique records are in the full dump, possibly how many per file, how many files make up the full dump, how many, if any, duplicates in the materialized view, etc. This could help us with troubleshooting issues, such as POD only getting 5.4 million unique records and duplicates occurring across files.
With previous full dump from Symphony, we'd get an email at sul-unicorn-devs list of counts. Maybe consider this when the full dump selection dag finishes.

In the logs for number_of_records task, we could pull out into an email:
[2024-08-17, 02:04:30 UTC] {full_dump_marc.py:45} INFO - Record count: 9785445
[2024-08-17, 02:04:30 UTC] {python.py:202} INFO - Done. Returned value was: 9785445

In the calculate_start_stop tasks, the logs in the mapped tasks show:
[2024-08-17, 02:09:41 UTC] {full_dump_retrieval.py:103} INFO - Output in calculate_start_stop {'start': 0, 'stop': 2000000}
[2024-08-17, 02:09:41 UTC] {python.py:202} INFO - Done. Returned value was: {'start': 0, 'stop': 2000000}
[2024-08-17, 02:04:40 UTC] {full_dump_retrieval.py:103} INFO - Output in calculate_start_stop {'start': 2000000, 'stop': 4000000}
[2024-08-17, 02:04:40 UTC] {python.py:202} INFO - Done. Returned value was: {'start': 2000000, 'stop': 4000000}

☝ this might be the cause of some duplication? Shouldn't the next mapped task have start: 2000001 ?
I see in the logs for transform_marc_records_add_holdings task, we get stuff like that might be good to pull out for a reporting email:
[2024-08-17, 04:11:40 UTC] {transformer.py:111} INFO - Writing 4,537 modified MARC records to /folio-data-export-prod/data-export-files/full-dump/marc-files/5000_10000.mrc
[2024-08-17, 04:11:57 UTC] {transformer.py:111} INFO - Writing 4,519 modified MARC records to /folio-data-export-prod/data-export-files/full-dump/marc-files/10000_15000.mrc

For the transform_marc_records_clean_serialize task, this stuff in the logs might also be good to add to an email report. For the serializing and removing fields logging, maybe add the filename and skip pulling out of the log the smart_open call.
[2024-08-17, 05:27:29 UTC] {s3.py:1054} INFO - smart_open.s3.MultipartWriter('folio-data-export-prod', 'data-export-files/full-dump/marc-files/5000_10000.mrc'): uploading part_num: 1, 8711374 bytes (total 0.008GB)
[2024-08-17, 05:27:30 UTC] {transforms.py:131} INFO - Serializing 4537 MARC records as xml
[2024-08-17, 05:27:35 UTC] {s3.py:1054} INFO - smart_open.s3.MultipartWriter('folio-data-export-prod', 'data-export-files/full-dump/marc-files/5000_10000.xml'): uploading part_num: 1, 22124796 bytes (total 0.021GB)
[2024-08-17, 05:27:38 UTC] {transforms.py:102} INFO - Removing MARC fields using AWS S3 with path: /folio-data-export-prod/data-export-files/full-dump/marc-files/10000_15000.mrc
[2024-08-17, 05:27:40 UTC] {transforms.py:107} INFO - Removing MARC fields for 4,519 records


Remove use of Client Secret

No longer need to use client secret to intialize sdk.
Test: Run demo app just by updating client id and account token (no more client secret is needed) and see if everythings run smoothly.

Sounds good @diegoserranoa, ok I will take a look into and see how I can make both works with new method addition. Thanks for your review and suggestion.

Sounds good @diegoserranoa, ok I will take a look into and see how I can make both works with new method addition. Thanks for your review and suggestion.

@diegoserranoa I have tried to add new method and update related codes, let me know more about the changes!

Thanks for such a good review and your time @diegoserranoa. Also thanks to @prabhatjha for getting into this.


Improve matching of different image update channels

Be explicit in the matching of each of the update channels according to our rules:

Stable channel is always the latest with prerelease==false
Testing channel is always teh latest with prerelease==true and no bracket tags (i.e. not having [CHANNEL] in the name)
Unstable channel is always the latest with prerelease==true and the [UNSTABLE] bracket tag.
Also allow for custom update channels as needed by adding bracket tags. Even more than one tag can be used on the same release if needed.

Tha last match of the function will catch all cases with [CHANNEL-NAME] in bracket tags. That includes the unstable update channel.
Modify tests to match the rules: each channel should look into itself regardless of newer versions on other channels. That will allow more flexibility to the user to choose between channels and will work as a "What you get is what you meant" measure.

Yeah, I'm a little iffy on pinning to unstable uneqivocally also. I think unstable should only be pinned for a specific version and when they get to stable they should have to select unstable again to move to the next version's unstable builds (which would also have them skipping our dash releases). I realize some people are addicted to being in unstable,  but I'd prefer to ask them to confirm it each time... and remind them that it really is unstable. Just my two cents.

I concur. Too many people who should not be on unstable are already on unstable. We should be pushing people into stable and making a conscious decision to switch back to limit the number of folks using unstable.

Ok. Fair points. So the proposed method can check latest stable always. Compare that to the latest one from the required channel (testing or unstable or any other) and check if the stable one is newer based on dates. In that case override the channel to stable.
That seems to be the desired behaviour?
Point out that all channel switches are a conscious decision by the user, either by running frzr-deploy chimeraos/chimeraos:unstable on a TTY or by running through hoops in developer mode on the Steam client. Also we don't push updates on the user without their interaction (they need to specifically click the "Apply" button in the client) since we disabled frzr-autoupdater.service. But it is ok to have some kind of friction to stay on a potentially broken update path.

I added a force to come back to stable after a successful update to whatever the channel is. That adds one more hoop for users to jump into if they want to update to a broken state by either:

Selecting the channel in the drop-down each time they want to update
Running # frzr-deploy chiemraos/chimeraos:broken-channel at a TTY

The client and frzr-deploy run with no arguments will always show the latest stable as the next update.

We should make sure the documentation is up to date on this

We should make sure the documentation is up to date on this

Updated top comment to reflect the intention and latest changes.

Change match of dates from created_at to published_at date-time. The date the release is viewed in the site.

I think this is a problem. I have noticed that GitHub displays releases incorrectly some times. Even when the release is newer and should be the top release, it is shown below others.


Crash with undetected-chromedriver version

main.py -v -f cookies.json https://nowsecure.nl
[02:19:58] [INFO] Launching headless browser...
Traceback (most recent call last):
  File "<path>\main.py", line 332, in <module>
    main()
  File "<path>\main.py", line 250, in main
    with CloudflareSolver(
         ^^^^^^^^^^^^^^^^^
  File "<path>\main.py", line 84, in __init__
    self.driver = Chrome(options=options)
                  ^^^^^^^^^^^^^^^^^^^^^^^
  File "<path>\Python\Python312\site-packages\undetected_chromedriver\__init__.py", line 372, in __init__
    options.binary_location = (
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "<path>\Python\Python312\site-packages\selenium\webdriver\chromium\options.py", line 54, in binary_location
    raise TypeError(self.BINARY_LOCATION_ERROR)
TypeError: Binary Location Must be a String

Are you using the latest versions of selenium and undetected-chromedriver? Try running pip install -r requirements.txt

It made no difference. I already had the matching versions installed according to pip list.
Testing on Windows 11 machine with Python 3.12.6

You need to download and install Google Chrome.


Portals do not render through portals

I believe the mod automatically enabled Compatibility Rendering Mode because you turned on shaders. You can turn it off, but I think it will get enabled again if you dont turn off shaders.
Btw last time I used ImPt with shaders I remember that the switch for compat mode was still off, so I had to turn it on and off again for it to render portals in portals at least without shaders.


Polish translation of your app

Hello!
I find your app very helpful and really appreciate your work, and would like to thank you for that.
I prepared Polish versions of strings and would like to ask you if you can implement them to make the app available in Polish?
pl-PL.zip
If anything else is required for that, just let me know. I will try to deal with Readme and Installation files next.
Best regards,
Arek Deliś

Hi,
I have added your values. Can you verify it:
GDH_<IP_ADDRESS>.zip
The changes can be found here:
https://github.com/pachi81/GlucoDataHandler/pull/81/commits/d3c061d729b6ebba9b3438bc1ecb1c13c99579ef
For "Colored AOD" I´m using "Kolorowy AOD". Correct?
Regards, Michael

Hi!Thanks for reply! Great! Kolorowy AOD will be great. I am now away from my computer, so I will take a look at it when I can at home. BestArek
-------- Oryginalna wiadomość --------Od: pachi81 @.> Data: 28.06.2023  15:24  (GMT+01:00) Do: pachi81/GlucoDataHandler @.> DW: froster82 @.>, Author @.> Temat: Re: [pachi81/GlucoDataHandler] Polish translation of your app (Issue #80)
Hi,
I have added your values. Can you verify it:
GDH_<IP_ADDRESS>.zip
The changes can be found here:
d3c061d
For "Colored AOD" I´m using "Kolorowy AOD". Correct?
Regards, Michael
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hi!
I have checked the apps on both phone and watch and they look all right.
Thanks again for great work!
I have one more question, though :)
Can you somehow make the phone version show delta and trend in the status bar? I use Juggluco and I really miss this feaure on the phone. I am really glad you made it possible to see reliably the trend arrow and values on the watch, but it would be great to have those options also on the phone.
Best,
Arek

Hi Arek,
thank you for the feedback.
If you did not find any problems, I will create a pre-release 9.2 on monday.
A permanent notification will be not a big thing, as I already use it for Android Auto.
I also thought about a small widget for the phone.
But at the moment with the beautiful weather I only have less time 😉
So it will take a while...
Regards, Michael

Great, much appreciated!
And I totally understand and agree with time issues :)
Best,
Arek

Fixed with version 0.9.2

I re-open it, as there is more translation todo.
I also gave you access to this repo, so can add change for translation directly to the files.
At the moment, I´m working on the notification, which has some new settings.

Hi! When you have your final English version, I will look at it and see what has changed. I haven't had time to get a hold of Github functionality yet, so if I cannot upload my updated versions, I will just drop them here.

I created a new PR: https://github.com/pachi81/GlucoDataHandler/pull/83
I think, you can edit the pl-strings.xml file direct in the browser, so you do not have to upload anything. Maybe this is the easiest way for you.
Here is the current version, so can see the settings in the app.
GlucoDataHandler_<IP_ADDRESS>.zip

I usually uplod the current version of the English file into my CAT tool, and can easily trace all changes. I will try to deal with this as soon as possible, but my day-to-day work orders come first ;)

Yes no problem, it is not time critical ;-)
I also have limited time, so I know this situation very well :-D

Hi! I have dealt with the strings file from mobile folder. The easiest way for me to do that is to upload it to my CAT tool, so I will just attach it here. Can you paste it where you need to, or do I have to do it as part of review proces? I have never used Github before, that's why I am not sure of the procedure :)
strings_pl.zip

Thank you! No problem, I can put it in the code as well, if you do not have experience using github.

Can I just paste the whole code into strings in PL folder? Or maybe can I copy the file? How to do it best? For future reference.

Great, thanks for that. I appreciate it, because in the future I will not have to take your time to do that.

No problem, the replacement of the strings is not a big thing, so I can also do it. Only with the translation to polish, I have some problems ;-)
Thank you for supporting my app.

I just installed the version you provided above and I think I found 2 minor bugs. In the notification, between the glucose value and the trend arrow, I think there is a space missing. In the app itself, those are separated ok with a space and it looks better. Also, the trend arrow in the status bar (when it is up- or downwards) gets cut on the right-hand side. Both of these can be seen in the scrrns.

I am on Samsung galaxy s9 with Android 10. Maybe this is the reason for this difference. Also - would it be possible in some future version to get in the status bar a trend arrow with delta value at the same time? Just as one of the options on the wear app. (I know, I know - I can be a pain the a## :) ).

Oh, I just like throwing some crazy ideas around, because sometimes they are found to be quite good. And on other occassions they are not so good. I am just trying to achieve the same level of functionality on the phone, as I now have on my watch. With your "trend arrow + delta value" complication I am now able to determine better the rate of glucose increase or decrease. People without the watch do not have this really helpful feature now.

At the moment I'm implementing a widget:

Maybe then you do not need an additional notification.
Would you use a second notification, for having an additional status bar icon?

Now this is a wonderful news and takes care of all the things I wrote above. With a widget we have all the information needed. Great! Thanks!

If you like, you can try it:
GlucoDataHandler_<IP_ADDRESS>.zip
It would be interesting for me, if you have also some problems with space between value and arrow.

Everything looks fine on my device.

But it looks different as on my device... The arrow is more in the middle and not on the right border as on your device.
Maybe I can improve it...

Hi,
here is a new version, where I have adjust the notification:
GlucoDataHandler_<IP_ADDRESS>.apk.zip
Can you check, how it looks, now.
For the widget, I do not have so much influence in Android 10. In higher version I can change the width of the images dynamically.
Maybe I will find another solution.

Hi!
I attached screens from yeasterday (99) and from today (109) so you can see how the things changed.
Screens.zip
Wider than 1x1 widget in Android 10 is still alligned to the right, but that is not something which is troublesome.

Great! Now it looks much better!
I found some other solution for setting the layout.
I will play around with that.

Hi,
I have changed the layout-implementation of the widgets to be more dynamically independent of the android version.
Would be great, if you can test it and send me a screenshot, how it looks on your device.
GlucoDataHandler_<IP_ADDRESS>.apk.zip
Thank you!
Regards, Michael

1x1 looked better in the previous version with bigger value.
1x2 is I think more in the centre.

I think both looks better, now. If you resize the widget to the right, the delta and time will be move the right.
But I recognized, that your status bar icon is still cut off.
I have to change it again...

So, now the status bar icon should work...
I also did some smaller changes to the widget layouts.
GlucoDataHandler_<IP_ADDRESS>.apk.zip

Yes, this would be no big deal.

Here are 2 additional widgets:
GlucoDataHandler_<IP_ADDRESS>.apk.zip

Yes, I know. I haven't yet time to create new previews.

Hi,
there are 2 new text lines in the strings. xml:
https://github.com/pachi81/GlucoDataHandler/pull/84/files#diff-bd6311cc0b6875d4350bc94577a3598d016c2287731d2a5d9036cde4c9640ac6R71
-> line 71 and 72
I added an option for a bigger statusbar icon, so you do not have the cut one and I can have a bigger one :-)
Now, you can try to edit it direct in the commit ;-)

I edited those on my phone, but it seems it worked. You should now have them ready for approval.

Hi,
I added some more strings for the second notification - config.
Now you can have a second notification with delta value:
GlucoDataHandler_<IP_ADDRESS>.apk.zip

Thank you! Here is the version with your translation to verify:
GlucoDataHandler_<IP_ADDRESS>.apk.zip

Hi! I spotted and corrected one more mistake and commited the change. Widgets with previews look great. Secong and bigger icons also work fine on my device.

Also the bigger trend icon? It isn´t cut off? I´m surprised :-)

Ok, wrote too soon :D The tip is a bit cut off when the arrow goes up

OK, one more thing translated - as promissed Readme and Install instruction in Polish :) I had some time, and could finish it. But without Polish screens yet.
Readme and Installation - PL.zip

Wow, great!
I'm not at home this weekend. I will have a look next week.

Hallo pachi81,
Der Trendpfeil zeigt in die falsche Richtung. Ist auch auf deinen Screenshots zu sehen. Ansonsten funktioniert das und sieht bei mir genauso aus, wie bei dir. Habe ein S23+

Korrektur:
Jetzt ist es Richtig.  Ist auch auf deinen Screenshots zu sehen. Ansonsten funktioniert das und sieht bei mir genauso aus, wie bei dir. Habe ein S23+

Was genau meintest du mit "falsche Richtung"? Das eine ist der Trendpfeil und das andere der Delta Wert, die können schonmal unterschiedlich sein, während der Trend noch steigend ist, kann das Delta schon negativ sein. Das kann entweder an einer kurzen Schwankung liegen oder an einer Trendwende...

I think the trend direction and delta values might be a bit misleading in the beginning, but probably it is just as you described above.
Coming back to Polish version - I have one question about one sentence regarding "rate (trend)".
"arrow rotate dynamically between +2.0 (↑) and -2.0 (↓)" - do you refer here to mmol/l or just the mathematical rate? Because in the Polish version I wrote "+36 (+2,0) (↑) a -36 (-2,0)(↓) " and now I am not sure if it was necessary to convert this value to mg/dl.

No, this is the mathematical rate. I don´t know, how this is calculated, because I got this value from Juggluco or xDrip+ and do not calculate anything on my side.
I will change it in your polish version.

OK, thanks. I saw values wtih decimals, so I automatically converted them. Only later I thought that these may be mathematical.
I corrected this and pasted Polish screens to Readme.
pl-PL.zip

Hi Arek,
can you check the result:
https://github.com/pachi81/GlucoDataHandler/blob/develop/README_PL.md
https://github.com/pachi81/GlucoDataHandler/blob/develop/INSTALLATION_PL.md
Thank you!

Hi! Looks fine! I only forgot to attach screenshot from Wear in the ZIP file, and pasted it inside docx.
Here it is:

Done

The only thing that can still be changed is the first capital letter in "wersja polska", Otherwise everything looks ready to go.

Done

Thanks!

Hi,
I have two new strings for translation:
https://github.com/pachi81/GlucoDataHandler/pull/90/files#diff-bd6311cc0b6875d4350bc94577a3598d016c2287731d2a5d9036cde4c9640ac6
After the last Android Auto update, the dummy media player does not work. So I have to simulate selecting a "song" to still have the value in the overview. Now it looks like here:

Because I´m not sure, if this have any influence to other media player apps, one have to activate it in the settings...

New strings are available:
https://github.com/pachi81/GlucoDataHandler/pull/92/files#diff-bd6311cc0b6875d4350bc94577a3598d016c2287731d2a5d9036cde4c9640ac6
and
https://github.com/pachi81/GlucoDataHandler/pull/92/files#diff-53aead5c1105150732f126121569424fd9ac595640a45fc4ea67942b08ed5f6d
I created a floating widget and added some tasker state events.

Hi! When I have a moment, I will have a look at them.

Thank you! You have time, I´m still testing and maybe I will change some more things.

I close this ticket, as I contact you direct in the merge. So this ticket is obsolete.
Thank you very much for your support!!!


Collect response bodies and headers

It seems to me that Vegeta collects and groups response only by HTTP response code.
I propose to add feature to extract and collect custom headers, (even body parts with help of  regex).
I understand It's a lot of work ( and sorry if it doesn't correspond to the spirit of the project.)

What's the use case?

under high load various artefacts could appears in response (especially if race condition take place), sript could extract and check some text with expected one.
some of the API implementations always return http 200 but and provide error messages in body or in custom http headers.

this is just first what come to mind.
I'm shure there is could be many more cases like:
check if load balancing works properly- collect and group node num avilable in response. etc.

Yes. I've seen that one before. A 200 response, but an error message in the body. But is that not a SUT design flaw?

But is that not a SUT design flaw?

this is the question for another holywar topic.
anyway sometimes you just have to deal with what you've been asked.

This is out of scope of a load testing tool.

We have two use cases where we also need to analyze the response body:

GraphQL load testing - GraphQL always responds with HTTP 200. In case of an error, it also returns HTTP 200 and the error messages in the body.
We also have a case when we need to test the race condition under a high load; in this case, we have to analyze the response. It seems like a similar use case that @Loofort brought up.

Can you please reconsider and open the issue?

@machulav: This has been implemented since. Just pipe vegeta attack to vegeta encode and you'll see the response body and headers.


Nvidia/translation ModuleNotFoundError: No module named 'strided_batched_gemm'

The directory fairseq has some cpp or cu files which cannot be imported.

Also, the fairseq used in your project is totally different from the one I git clone from pytorch/fairseq. Could you please tell me which version you use? Thanks


Add a property for storing cloud account ID in client key

This is just a draft to verify if approach is correct

Closing as not needed


New rule idea for consideration: No Long Tuples of Primitives?

Hello,
Sometimes we see things in our codebase like:
type DataRecord = (String, String, String, String, String, String, String, Int, String,String, Long, Long, Long, Long, Long, Long, Long, Long, Long, Int)
I think it's fair to say this is a mistake waiting to happen. Quick! what's the 4th string represent? or the 8th Long?
I think a great rule to add would be one where you can set a limit on how big your tuples can be (eg, only up to 6-Tuples). This could apply to any tuple, or maybe only tuples with mostly primitive fields.
What do you think?
Thanks!
Alex

I think that would be a good rule to add. Would you like to do the PR?


white

Hello, after I followed the steps, I found that the display part cannot be displayed normally, the entire screen is only white, and the touch screen responds but there is no response.

You must have incorrect wiring. Try the TouchPaint example in the examples -> ILI9341 folder of Mini_Grafx library.
You can share SCK (TFT) & T-CLK (touch), and T_DIN (touch) & SDI(MOSI)!


simple-websocket-server: Init at 20180414

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python27Packages.simple-websocket-server python36Packages.simple-websocket-server

Success on aarch64-linux (full log)
Attempted: python27Packages.simple-websocket-server, python36Packages.simple-websocket-server
Partial log (click to expand)
Successfully installed SimpleWebSocketServer-0.1.0
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yd9mkf9m2hijkqg88jidin558lwbs2ph-python3.6-simple-websocket-server-20180414
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yd9mkf9m2hijkqg88jidin558lwbs2ph-python3.6-simple-websocket-server-20180414/lib
patching script interpreter paths in /nix/store/yd9mkf9m2hijkqg88jidin558lwbs2ph-python3.6-simple-websocket-server-20180414
checking for references to /build in /nix/store/yd9mkf9m2hijkqg88jidin558lwbs2ph-python3.6-simple-websocket-server-20180414...
/nix/store/b1jfb981al5371ddbgjvsgh20mh5lw0v-python2.7-simple-websocket-server-20180414
/nix/store/yd9mkf9m2hijkqg88jidin558lwbs2ph-python3.6-simple-websocket-server-20180414

Success on x86_64-darwin (full log)
Attempted: python27Packages.simple-websocket-server, python36Packages.simple-websocket-server
Partial log (click to expand)
Processing ./SimpleWebSocketServer-0.1.0-py3-none-any.whl
Installing collected packages: SimpleWebSocketServer
Successfully installed SimpleWebSocketServer-0.1.0
/private/tmp/nix-build-python3.6-simple-websocket-server-20180414.drv-0/source
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/dvr9yh988q6af793fhiz95300qm923km-python3.6-simple-websocket-server-20180414/lib
patching script interpreter paths in /nix/store/dvr9yh988q6af793fhiz95300qm923km-python3.6-simple-websocket-server-20180414
/nix/store/cn4yfw08wrwnf8ajl7p8a8daz8zn5r4s-python2.7-simple-websocket-server-20180414
/nix/store/dvr9yh988q6af793fhiz95300qm923km-python3.6-simple-websocket-server-20180414

Success on x86_64-linux (full log)
Attempted: python27Packages.simple-websocket-server, python36Packages.simple-websocket-server
Partial log (click to expand)
Successfully installed SimpleWebSocketServer-0.1.0
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6faaxpn8qjf8ba0ary3bb3qa0h3139sc-python3.6-simple-websocket-server-20180414
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6faaxpn8qjf8ba0ary3bb3qa0h3139sc-python3.6-simple-websocket-server-20180414/lib
patching script interpreter paths in /nix/store/6faaxpn8qjf8ba0ary3bb3qa0h3139sc-python3.6-simple-websocket-server-20180414
checking for references to /build in /nix/store/6faaxpn8qjf8ba0ary3bb3qa0h3139sc-python3.6-simple-websocket-server-20180414...
/nix/store/0zj0hmpp7naf4phkbplmb27ms31nrr68-python2.7-simple-websocket-server-20180414
/nix/store/6faaxpn8qjf8ba0ary3bb3qa0h3139sc-python3.6-simple-websocket-server-20180414


Pod install in Example app

Getting error:
[!] Unable to find a specification for `SDWebImage (~> 3.7)` depended upon by `ImageSlideshow/SDWebImage`

Hi, I tried the example app and it works correctly to me. Please specify Xcode and CocoaPods version you are using.


Additional labels for quote matching

Currently, yargy doesn't understands that text can contain different types of quotes, like 'classic': " and ' and a lot of different typographic quotes: « » / „ “ / “ ” / ‘ ’ / „ ” / and so on
There should be special label(s?), that checks some quote-related stuff:

Type: opening, closing or generic quote
Same type as opening quote (for matching closing quotes)
Same group as opening quote (because without that, « (opening) and “ (closing) quotes, will be matched together)

OK, added some description.

Предлагается работать с текстом кавычках через генерацию правил, см. https://nbviewer.jupyter.org/github/natasha/yargy/blob/master/docs/cookbook.ipynb#Генерация-правил


Release a new version

Please release a new version that contains the fix for the global addresses leak.

A new version has been released (0.2.9)


Avoids log4j-over-slf4j recursion

sla-personalization depends on tower4clouds:rules, which
depends on log4j-over-slf4j. This leads to an exception at runtime
described in http://www.slf4j.org/codes.html#log4jDelegationLoop
This commits adds the exclusions needed to work around the problem. Although it is not affecting the SLA in SeaClouds (I don't know why), it has affected in other contexts, and therefore may affect SeaClouds SLA in the future.
The exclusions may be added to the parent pom instead of sla-personalization, but I would need agreement from the other modules.
@andreaturli , @kiuby88 , @adriannieto , @MicheleGuerriero : WDYT?

Current coverage is 36.92%

Merging #253 into master will increase coverage by +0.19% as of 62b42a8

@@            master    #253   diff @@
======================================
  Files          329     329
  Stmts        12064   12069     +5
  Branches      1548    1551     +3
  Methods          0       0
======================================
+ Hit           4432    4456    +24
+ Partial        449     443     -6
+ Missed        7183    7170    -13

Review entire Coverage Diff as of 62b42a8

Powered by Codecov. Updated on successful CI builds.


KAFKA-4331: Kafka Streams resetter is slow because it joins the same group for each topic

bug-fix follow up
Resetter fails if no intermediate topic is used because seekToEnd() commit ALL partitions to EOL

@guozhangwang @miguno @theduderog

LGTM

LGTM

@miguno @theduderog Added a test that coveres the missing scenario.

@guozhangwang @miguno What is the status of this?

Other than my comment about testNo I'm +1.  Up to you folks to decide whether you like the testNo setup or not.

Call for review @dguy @enothereska

LGTM. Merged to trunk and 0.10.1.


iOS Engine

Describe your problem here. If you are modding, please try testing your problem in a clean version of the engine instead, this ensures the problem is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
Hi Jordan Santiago I Have A Problem When Open The App Only have a Black Screen Pls For Update Greetings
Are you modding a build from source or with Lua?
Lua
What is your build target?
iOS
Did you edit anything in this build? If so, mention or summarize your changes.
No response

i don't develop the mobile version, sooo uh

can you try this?
https://github.com/JordanSantiagoYT/FNF-JS-Engine/actions/runs/10941033233/artifacts/1953088074

@JordanSantiagoYT @moxie-coder if this user doesn't respond for 1 week, close this issue as resolved

got it babe
On Fri, Sep 20, 2024 at 12:15 PM Lily @.***> wrote:

@JordanSantiagoYT https://github.com/JordanSantiagoYT @moxie-coder
https://github.com/moxie-coder if this user doesn't respond for 1 week,
close this issue as resolved
—
Reply to this email directly, view it on GitHub
https://github.com/JordanSantiagoYT/FNF-JS-Engine/issues/593#issuecomment-2364075234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5VHQKUEZYE53V5QCWZ4JUTZXRCYTAVCNFSM6AAAAABOO4M2ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRUGA3TKMRTGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

this should be closed by now

closing due to 1 week of inactivity


The IPFS bootstrap nodes seem to use 1024 bits RSA keys

While 2048 bits keys are default and would be preferred.
cc @diasdavid

@lgierth @kyledrake what's the main reason why we don't use 1024 bits keys in our Infrastructure nodes?

Ping @lgierth and @kyledrake

Historic reasons -- we bumped the default to 2048 at some point.
There are a few 2048 bit peerIDs in the default bootstrap list that I added like 9 months ago - we should:

start using them, i.e. start the respective nodes.
remove the QmSoL nodes from default bootstrap.
hopefully in a year or five be able to shut the QmSoL nodes down.

@lgierth can we have a list of all the nodes and their keys here?

New nodes (not running yet, just PeerIDs):

/dnsaddr/bootstrap.libp2p.io/ipfs/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN
/dnsaddr/bootstrap.libp2p.io/ipfs/QmQCU2EcMqAqQPR2i9bChDtGNJchTbq5TbXJJ16u19uLTa
/dnsaddr/bootstrap.libp2p.io/ipfs/QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb
/dnsaddr/bootstrap.libp2p.io/ipfs/QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt

Old nodes:

QmSoLPppuBtQSGwKDZT2M73ULpjvfd3aZ6ha4oFGL1KrGM (in default bootstrap)
QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z
QmSoLueR4xBeUbY9WZ9xGUUxunbKWcrNFTDAadQJmocnWm
QmSoLSafTMBsPKadTEgaXctDQVcqN88CNLHXMkTNwMKPnu (in default bootstrap)
QmSoLju6m7xTh3DuokvT3886QRYqxAzb1kShaanJgW36yx
QmSoLV4Bbm51jM9C4gDYZQ9Cy3U6aXMJDAbzgu2fzaDs64 (in default bootstrap)
QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd (in default bootstrap)
QmSoLMeWqB7YGVLJN3pNLQpmmEk35v6wYtsMGLzSr5QBU3

@lgierth is it possible we could have a similar schema as the old QmSoL? Maybe a different one, but was handy to immediatly see if a node was a bootstrap node or node. Same with the gateways.

They're already in go-ipfs's default bootstrap. I also think that at one point we'd break from that scheme anyway when there's a situation where we need to quickly add new nodes (brute-forcing these took a day or three).

I got hit by this:
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2a03:b0c0:0:1010::23:1001/tcp/4001] dial tcp6 [2a03:b0c0:0:1010::23:1001]:4001: connect: network is unreachable
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2a03:b0c0:0:1010::23:1001/tcp/4001] dial tcp6 [2a03:b0c0:0:1010::23:1001]:4001: connect: network is unreachable
2019/09/22 14:18:39 failed to dial QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb: no good addresses
2019/09/22 14:18:39 failed to dial QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN: no good addresses
2019/09/22 14:18:39 failed to dial QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt: no good addresses
2019/09/22 14:18:39 failed to dial QmQCU2EcMqAqQPR2i9bChDtGNJchTbq5TbXJJ16u19uLTa: no good addresses
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2604:a880:1:20::203:d001/tcp/4001] dial tcp6 [2604:a880:1:20::203:d001]:4001: connect: network is unreachable
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2604:a880:1:20::203:d001/tcp/4001] dial tcp6 [2604:a880:1:20::203:d001]:4001: connect: network is unreachable
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2604:a880:800:10::4a:5001/tcp/4001] dial tcp6 [2604:a880:800:10::4a:5001]:4001: connect: network is unreachable
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip6/2604:a880:800:10::4a:5001/tcp/4001] dial tcp6 [2604:a880:800:10::4a:5001]:4001: connect: network is unreachable
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 failed to dial : all dials failed
  * [/ip4/<IP_ADDRESS>/tcp/4001] failed to negotiate security protocol: rsa keys must be >= 2048 bits to be useful
2019/09/22 14:18:39 Connected to QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ

It seems that in the default boostrapper list, only one node has a key >= 2048 and support IPv4, which makes it a fairly brittle and slow bootstrap process.
Note: I'm using libp2p directly, which has a 2048 minim length required, unlike go-ipfs (512).

Got hit too, I will try to expedite a fix

For legacy compatibility, the 'old' bootstrap nodes with small keys are essentially stuck in-place, and are deprecated by the 'new nodes', under bootstrap.libp2p.io/IPFS/... which have been running for a while now.
Closing as resolved, but please reopen if you run into issues.

@mburns it might be worth making an announcement so that people update their IPFS/libp2p configs + checking where those old nodes show up (in the default configs + examples) and updating them to only show the new ones.

indeed. I'll track some notes and the announcement here: https://github.com/ipfs/infra/issues/496