Intermediate certificates may not be renewed when APIM certificates are renewed.

[Enter feedback here]
Intermediate certificates may not be renewed when APIM certificates are renewed.
[certificate chain].

example.com < - CN1 < - Root
example.com < - CN1 < - CN2 < - Root
In the above case, if you try to change the flow from 1 to 2, but the CommonName is the same name, the intermediate certificate will not be renewed.

The problem is that we currently don't allow customers to remove certificates from the actual windows store to prevent unexpected problems with the windows machine.
Can you describe how to avoid a situation where you cannot fix it yourself?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e20660e-86ff-b872-628b-4b61c2bb63fe
Version Independent ID: 6e7a2f4d-207b-2c9d-675c-c7b1c26bb39d
Content: Add a custom CA certificate - Azure API Management
Content Source: articles/api-management/api-management-howto-ca-certificates.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@v-ryamada - Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can update the document accordingly.

Thanks for raising this issue in Azure documentation. Unfortunately, at this time we have been unable to review or resolve your issue in a timely manner and we sincerely apologize for the delayed response. We have captured your feedback for consideration in future documentation updates and are now closing this issue. To discuss further, you can also get answers from community experts in Microsoft Q&A. If you have a support plan and you need technical help, create an Azure support request.
#please-close


How to receive Voice messages?

Hi I've been following the format described in the docs, I have a valid Bot API Token and file ID for the voice message received in the message object but this URL still returns 404. I would assume that I can just visit that url and the download of the voice file would start but nothing happens.
"https://api.telegram.org/file/bot#{bot_api_token}/#{voice_file_id}"

I've been trying also with the getFile method by specifying the voice_file_id as string parameters but no luck...
Is there anything I'm doing wrong?

This stackoverflow solution answered my question: https://stackoverflow.com/a/32679930
first I need to get the file_path info with this url:
https://api.telegram.org/bot<bot_token>/getFile?file_id=<the_file_id>
then I'll download the actual file with:
https://api.telegram.org/file/bot<token>/<file_path>
It wasn't super clear from the docs or previous issues opened on this repo. Hope that'll clear things up for future reference.


[ALLUXIO-3339] Address job master scalability

https://alluxio.atlassian.net/browse/ALLUXIO-3339
Approach in this work for addressing scalability of job master is mainly to improve concurrency of worker heartbeats. With these changes worker heartbeats will run concurrently and synchronize on registration of a new worker and removal of an existing [lost] worker.
Also, write path for JobInfo object is merged with JobCoordinator and synchronized there.

alluxio-bot, check this please

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/581/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/595/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/613/
Test PASSed.


Cannot Compile with G++ due to GCC G++ bug

This bug
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57158
Causes this error when compiling mx
/usr/include/c++/4.8/bits/vector.tcc:146:5: note:   candidate expects 2 arguments, 1 provided

FYI, this bug is marked as fixed on bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57158

Closing because this ancient gcc bug is surely gone from the world.


Fix dungeon themes + Light2D and occluders

The first commits fixes the theme range to use the new tile ids.
However after finishing I realised I had missed adding one of the pics to the tileset, and so the second commits changes the themes to rely on a list of specific tiles instead of a range.
This allows for easier mixing between themes and is more forgiving of messy tilesets.

I also fixed the Light2D nodes and added occluder shapes to the tileset, so now the light cones for the player and objects work as before.
If you get the chance to approve these changes and merge them soon I'd appreciate it, since I need to add more changes on top of these with the normal maps for the tileset and the remake of all the particle effects.


[TA] Added Classify Custom Category Action

Hey folks.
This PR contains the implementation of the ClassifyCustomCategory API interface as very carefully explained in #24061. (closes #24061)
It is only a draft PR because I have yet to do the following:

Create DocStrings for all exposed properties
Run the tests on the PPE that was discussed in today's scrum (Monday, 20th of September)
Update the ChangeLog

However, I would be happy with feedback if any reviewer gets the chance to take a look. I also wanted to specifically ask about two issues that I had internally discussed with @ZulaMostafa :

The model factory has two functions for creating AnalyzeActionResult objects. I assume the reason for this was to introduce the summary extraction feature without causing breaking changes to the initial factory function. In our case, we will need to add three lists (Custom Entity, Custom Category, Custom Categories); should those all be added in a third overload of AnalyzeActionsResult so as not to cause breaking changes? Or should they be added to the already present newer overload considering that the summary extraction feature is also new?

How should we handle the project name and deployment name in the case of samples and tests? My first intuition was to treat them similarily to the Endpoint and APIKey and have them as environment variables that are fetched in the TestEnvironment object.
However, when looking at the projectNames and deploymentNames that were give to us to test with (the PPE credentials), it seems that they are different for each new feature. (there are seperate project names for custom entities, custom category and custom categories). Should they just be local variables to each test class ? Do we care about keeping these variables secret?

Thanks in advance!

I don't get the option to add reviewers (not sure why), so I'll manually mention @maririos and @kinelski .

I don't get the option to add reviewers (not sure why), so I'll manually mention @maririos and @kinelski .

So weird. I added us. Thank you!

The model factory has two functions for creating AnalyzeActionResult objects. I assume the reason for this was to introduce the summary extraction feature without causing breaking changes to the initial factory function.

You're correct. You can see we made the older one have EditorBrowsableState = Never so it does not appear in IntelliSense.

In our case, we will need to add three lists (Custom Entity, Custom Category, Custom Categories); should those all be added in a third overload of AnalyzeActionsResult so as not to cause breaking changes? Or should they be added to the already present newer overload considering that the summary extraction feature is also new?

You can add them to the newer overload since we can introduce breaking changes in features still in preview. This method was firstly introduced in the 5.2.0-beta.1 SDK version, and we haven't gone GA since then.

model factory question =>  Or should they be added to the already present newer overload considering that the summary extraction feature is also new?

You are right. Just adding it to the newer overload as that one was added on the latest beta we can still make modifications to it

How should we handle the project name and deployment name in the case of samples and tests?

Great question. I do think having them as TestEnvironment variables will not escalate because of what you said.
It doesn't look like they are secrets as you can't do anything with those 2 values only. You will always need the endpoint and the key for the endpoint.
Curious, what are other languages doing? @deyaaeldeen @mssfang @kristapratico

model factory question =>  Or should they be added to the already present newer overload considering that the summary extraction feature is also new?

You are right. Just adding it to the newer overload as that one was added on the latest beta we can still make modifications to it

How should we handle the project name and deployment name in the case of samples and tests?

Great question. I do think having them as TestEnvironment variables will not escalate because of what you said.
It doesn't look like they are secrets as you can't do anything with those 2 values only. You will always need the endpoint and the key for the endpoint.
Curious, what are other languages doing? @deyaaeldeen @mssfang @kristapratico

Agree that not much can be done with those values w/o endpoint/key. We have similar values in metrics advisor and we use env vars but don't sanitize recordings IIRC.

model factory question =>  Or should they be added to the already present newer overload considering that the summary extraction feature is also new?

You are right. Just adding it to the newer overload as that one was added on the latest beta we can still make modifications to it

How should we handle the project name and deployment name in the case of samples and tests?

Great question. I do think having them as TestEnvironment variables will not escalate because of what you said.
It doesn't look like they are secrets as you can't do anything with those 2 values only. You will always need the endpoint and the key for the endpoint.
Curious, what are other languages doing? @deyaaeldeen @mssfang @kristapratico

Either way works. But since projectName and deploymentName could be different for all three new features. I am doing hard code in each tests.

@AhmedLeithy I will suggest going similar to Java but instead of having the variables in each test, have them at the test class level like we do with the documents variables

@maririos I was considering that but then I realized that the samples won't have access to them. What I ended up doing was having constant strings in the TextAnalyticsTestEnvironment, one for the project and deployment name of each feature. I feel like this semantically makes sense since these are actual variables of the testing environment that we're using.
What do you think?
Also thanks everyone for the input!

What do you think?

:shipit:


Replace tabs with spaces (and fix indent) of YAML in code blocks

In order to be viewed properly on GitHub.

@nota-ja
Thank you for submitting the PR.
Regards
Shash

Although the sentiment that spaces are preferred over tabs is acknowledged, this commit actually broke the formatting for most of the YML blocks it changed.

Thank you for merging.
But I have one question.
@shalako, what do you mean with "broke the formatting"?
The right images in the following table are the rendered view of the README.md of my commit ( 966729c5256a37b1986bd1750b24f60126684b53 ).
The left images are the one of the previous commit ( a4287e8cfe6eeb54a00f1235620f632556c008f3 , the HEAD commit of develop branch when this pull request made) as well.
All of them were captured with Chrome 56.0.2924.87 (64-bit) on Mac.

commit
a4287e8cfe6eeb54a00f1235620f632556c008f3 (older)
966729c5256a37b1986bd1750b24f60126684b53 (this)

image

partially enlarged

The last row contains enlarged images for each commit. I will use them for the following explanation.
As you see in this example deployment manifest, the right structure of the part of the YAML is:

properties

uaa

ssl

port

sslCertificate
sslPrivateKey

However, the rendered view of the old commit is seen as:

properties

uaa

ssl

port

sslCertificate
sslPrivateKey

As I thought this was wrong, I made this pull request.
Actually the rendered view of my commit is seen as:

properties

uaa

ssl

port

sslCertificate
sslPrivateKey

So I think my commit did not "break" the formatting.

I must have been looking at the wrong branch. Develop looks look. Thank you.


Support task instance policy

policy only modifies the operator (not task instance) during DagBag loading and a task can be executed multiple times in between. To achieve routing a task to different queue during retries, we need a way to mutate the task instances before each execution. Therefore, adding a new task_instance_policy that is applied to the task instance right before it is queued by the airflow scheduler.
Did some testing with the following setup:
airflow_local_settings.py:
def task_instance_policy(task_instance):
    if task_instance.try_number == 0:
        task_instance.queue = 'py3'

DAG:
from __future__ import print_function
from builtins import range
import airflow
from airflow.operators.python_operator import PythonOperator
from airflow.models import DAG

import time
from pprint import pprint
from datetime import timedelta

args = {
    'owner': 'airflow',
    'start_date': airflow.utils.dates.days_ago(2),
    'retries': 1,
    'retry_delay': timedelta(seconds=1),
}

dag = DAG(
    dag_id='test_route_switch', default_args=args,
    schedule_interval=timedelta(minutes=1))

def print_context(ds, **kwargs):
    print('hello world')
    raise Exception('oops')

and confirming that the task got routed to different queues during retries
[2020-05-07 17:08:42,340] {jobs.py:1131} INFO - Sending to executor (u'test_route_switch', u'print_the_context', datetime.datetime(2020, 5, 5, 0, 0)) with priority 1 and queue py3
...
[2020-05-07 17:08:50,780] {jobs.py:1131} INFO - Sending to executor (u'test_route_switch', u'print_the_context', datetime.datetime(2020, 5, 5, 0, 0)) with priority 1 and queue default

@astahlman @bhanuvikasr @lyft/dp-tools-viz

Codecov Report

Merging #198 into data-platform-upgrade will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           data-platform-upgrade     #198      +/-   ##
=========================================================
- Coverage                  68.67%   68.51%   -0.16%
=========================================================
  Files                        143      143
  Lines                      11411    11415       +4
=========================================================
- Hits                        7836     7821      -15
- Misses                      3575     3594      +19

Impacted Files
Coverage Δ

airflow/executors/base_executor.py
91.66% <100.00%> (ø)

airflow/jobs.py
73.71% <100.00%> (-0.57%)
:arrow_down:

airflow/models.py
85.94% <100.00%> (-0.04%)
:arrow_down:

airflow/settings.py
91.35% <100.00%> (-2.32%)
:arrow_down:

airflow/utils/state.py
86.66% <0.00%> (-13.34%)
:arrow_down:

airflow/executors/__init__.py
64.70% <0.00%> (-2.95%)
:arrow_down:

airflow/www/app.py
94.11% <0.00%> (-2.36%)
:arrow_down:

airflow/utils/dag_processing.py
85.77% <0.00%> (-0.82%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e56d54...35634db. Read the comment docs.

👍


Some questions about the endorsement policy.

"endorsement-policy": {                                                          "identities": [         {           "role": {             "name": "member",             "mspId": "Org1MSP"                                                           }                                                                            },         {            "role": {             "name": "member",                                                              "mspId": "Org2MSP"                                                           }         },         {            "role": {             "name": "admin",             "mspId": "Org1MSP"                                                           }                                                                            }       ],       "policy": { "2-of": [{"signed-by": 0}, {"signed-by": 1}]}                    }

Why Org2 don't contain the "admin" role?
What's the meaning of "2-of"? Does this mean "AND" or "OR"? And how to express "AND" "OR" "N-OutOf" ?
And what's the meaning of "signed-by": 0 and "signed-by": 1 ? What is "0" and "1"?

Oh，I have known the answer of these questions. These endorsement policies are the expression of the SDK, and have some differences with the CLI's expressions. I would close this issue.

@cao0507 , could you give me a specification about these questions you mentioned above? I am also confused about them. Or any net referred to? thank you.


Support VRRP-ish

If we're going all multiprotocol with RIP, we should also implement VRRP. Or more specifically, "traffic steering using unsollicited ARP responses", not actually VRRP.
The way VRRP normally works is that the speakers ping each other over the network, and whoever wins takes ownership of the virtual router MAC address. This works well for stateless routers where failover can be transparent, but for endpoints, having a virtual MAC that you need to teach the kernel about is cumbersome and doesn't really help you that much.
What we really want is to just make the LB IPs portable, and we can do that with unsollicited ARP response pinging. The general idea: a new arp-speaker (could be a deployment or a daemonset) runs leader election through kubernetes. The winning leader sends periodic unsollicited ARP responses saying that "service-ip is-at node-mac-addr". It additionally runs an AF_PACKET socket (with appropriate BPF program attached) to listen for ARP who-has for service IPs, and responds to those as well.
The net result is that the local L2 segment will send service IP traffic to the elected cluster node, which will then LB.
This routing mode only really works with the cluster LB policy.

Past trauma with VRRP prevent me to thing clearly.. but couple of questions:

. The general idea: a new arp-speaker (could be a deployment or a daemonset) runs leader election through kubernetes.

Why does this need leader election? ReplicaSet of 1 replica should do it? Life cycle managed by k8s control plane - any short downtime shouldn't matter?

The winning leader sends periodic unsollicited ARP responses saying that "service-ip is-at node-mac-addr".

How do you get a MAC address of a node?
kubectl describe pod coredns-4025136029-ctj3k -n kube-system show the node
kubectl describe node gke-coredns-cluster-default-pool-d327f287-g3hl describes the pod. Then arp-lookup from the InternalIP?

It additionally runs an AF_PACKET socket (with appropriate BPF program attached) to listen for ARP who-has for service IPs, and responds to those as well.

Why?

Canonical arp lib is: https://github.com/mdlayher/arp

sigh k8s networking... do we need to mac address of a node or of the pod?
(I need to read more)

re: DaemonSet, you're right, a single-replica deployment is enough. We might have to add leader election later to avoid issues with "phantom" replicas, but that can be a separate bug.
We need the machine's MAC address. From the network's POV, the pod network and all the stuff k8s does with virtual networking doesn't exist. We just need to convince the network to send the VIP traffic to the physical node, and from there kube-proxy's netfilter rules does the rest.
To get the MAC address, we will need a small dance:

Run the deployment with hostNetwork: true, so that the pod has direct access to the machine's network stack. Otherwise, by default it gets sandboxed and low-level protocols like ARP don't get forwarded to the real network.
Using the pod Downward API, tell the deployment the IP of the node it's running on. The BGP speaker already does this, so we can just copy/paste.
In the binary, use net.Interfaces() to list network interfaces, find the one that owns the node IP, and use that HardwareAddr (and also only do ARP stuff on that interface)

Re: BPF program, our ARP traffic has to convince 2 separate consumers: switches in the L2 segment, and end hosts.
For switches, they just need to learn the port to use for the destination MAC. For that we use unsollicited ARP responses.
But, unsollicited ARP is not necessarily enough to make end hosts work. They are not required to cache information from unsollicited responses, or they could evict the cache entry in a large network if they're not yet talking to the VIP. So, I think we need to speak normal request/response ARP as well, to ensure that the clients can find the VIP. WDYT?

Oh, it looks like mdlayher's ARP package doesn't need to do BPF magic to listen for ARP, it's a supported protocol family. I thought we would have to do the same hacks I did for listening to DHCP efficiently, using x/net/bpf.

But, unsollicited ARP is not necessarily enough to make end hosts work. They are not required to cache information from unsollicited responses, or they could evict the cache entry in a large network if they're not yet talking to the VIP. So, I think we need to speak normal request/response ARP as well, to ensure that the clients can find the VIP. WDYT?

sgtm; but I (still) don't understand the BPF requirement. If we make a arp listeners that just programs the hosts arp cache woulnd't that also do it? Or is BPF doing the same and easier?

BPF just lets you filter a raw AF_PACKET socket (that receives all traffic on an interface) in-kernel, so it's more efficient.
But mdlayher's ARP package lets you listen for ARP only, so it's not necessary.

Tentatively marking this for v0.2.0. It's possible I will get impatient and push out 0.2.0 while kubecon and CoreDNS stuff occupy your time. If that happens, we can release 0.3 with this and RIP support as the major features :)

ok have the (very minimal) https://github.com/miekg/karp which allows me to play with sending unsolicitated ARPs. But (again) I'm wondering how to test - my router doesn't seem to accept unsolicated ARPs.

It's possible you'll have to support both sollicited and unsollicited responses before things will work well. Check in wireshark (a) if the unsollicited packet is being transmitted, and (b) if you're seeing arp-who-has requests for your VIP. If you are, you need to implement responses to those as well so that end hosts know where to forward stuff.

Ok, succesfully spoofed an ARP, flipped some arguments, but I'll need to double check what is the right thing to do.
Actually writing to the arp cache requires a ioctl on a socket; that should be fun to do in Go :)

Um, why do you need to write to the ARP cache? You only need to convince other machines to send you traffic, not the local machine?

ah, true you're right. Misread the second half of your inital comment.
Well, then. ship it :)

Ok, https://github.com/miekg/arp-speaker/ is coming along nicely.
I figured that I don't have to do any unsolicated ARPs, just start responding when you see an ARP request for the new virtual IP whenever a VIP is going to be announced. This will be using the MAC addr of the node we're running on.
I do need one new config item I think (next to the ability to switch protocol), which is the interface we should use.

Next up:

[ ] integrate with metallb
[ ] actually compile metallb locally
[ ] find out if minikube on my laptop can send ARPs on my LAN

Unsollicited ARP is still necessary when you're doing a live failover. Say you have an arp-speaker on node A, it has sent some ARP responses, and then it goes down. arp-speaker on node B takes over, but the upstream switches are still forwarding the VIP traffic to the port of node A. The clients all have the IP→MAC mapping in their ARP cache, so they are just transmitting immediately without sending ARP requests... And then the switch forwards those ethernet frames to node A instead of node B.
I think the unsollicited ARP on failover is requires to teach the switches that the VIP has moved to a new egress port.

Ack, noted. None of my Linux machines seem to accept to ARP responses. But it easy to add goroutine that just spams the network with these every N seconds.

Iinitial code has been merged, https://github.com/google/metallb/issues/28 for follow up TODO list.


Why is audio max duration is 29s?

Looking here I cannot help but notice https://github.com/ConsistencyVC/ConsistencyVC-voive-conversion/blob/620266afe2432a2be9847400bbc920ed065c8dea/preprocess_ppg.py#L20
What if source is longer than 29s? Should it be split by 29s duration, converted one-by-one, and the joined back?

same question, How can I extend the running time, I change this line but get error

This is the problem of Whisper...

So @skol101 you are right, it should be split by 29s duration, converted one-by-one, and then joined back

Understood. Thanks!

Hello everyone, I make a simple change to the whisper convert py file, you can use this file to convert the long audio.


Fixing typo for Panorama.

As the title susgests. Panorama is not really PAYG in comparison to the Bundle 1 and 2. So this fixes that up.

Thank you :-)


Add: Kibris Kanal T

Channel Name
Kibris Kanal T
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
CY
Subdivision (optional)
No response
City (optional)
Nicosia
Broadcast Area
c/CY
Languages
tur
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
http://www.kanalt.com/
Logo
https://www.lyngsat.com/logo/tv/kk/kanal-t-kibris-tr-cy.png
Notes
No response

https://iptv-org.github.io/channel?id=KibrisKanalT.cy


Update deprecated method index(of:) to firstIndex(of:)

change deprecated method index(of: for firstIndex(of:

Thank you for contributing.


Detectability: Bot does not fetch Pokestop details but collects items

Niatic engineers could spot this bot by searching for players that have activated stops without ever attempting to fetch the details.
This is somewhat of a tradeoff between speed and detectability, but I think this is easy enough for them to do that we should fix it.
Expected Behavior
In the retail app, when you tap on a pokestop, it fetches the details of it.
Actual Behavior
When the bot spins a stop, it doesn't request the stop's details
Steps to Reproduce
Run the bot and have it spin a stop.

I think it could be there as an optional setting. For instance stop_fetch_details at the config. Some people want speed not security.

It does.
line 27: self.api.fort_details(fort_id=self.fort['id'],latitude=lat,longitude=lng)
Waits 2 seconds and:
line 41:  self.api.fort_search(fort_id=self.fort['id'], fort_latitude=lat, fort_longitude=lng, player_latitude=f2i(self.position[0]), player_longitude=f2i(self.position[1]))

Excellent, this must be relatively new since I don't believe it was doing so when I looked into it a couple of days ago (although that would have been on master, not dev).

https://github.com/PokemonGoF/PokemonGo-Bot/blob/19639921f9006972d7a60bd5a8b24de8ea7fadcb/working.py
Has been there since day one.

Oh cool! By bad then. I'll make sure to investigate further before opening new issues.

This issue has been resolved, closing this.
/closed


Occurring  "Media" property in Message

I couldn't get the media object eventhough "IsMediaMessage" is "true". It occured  what I appended "VideoMediaItem" object..

@iroas2  JSQMessagesViewController was updated a month ago.  Hopefully this will resolve your issue.


[ENH] Add control over the score method of classification and regression

Closes #1062

Nice work, althought I would suggest that rather listing some/all metrics for a task, you could use a sklearn defined method such as get_scorer. Then you could do the following to get back the metric function from the scorer
from sklearn.metrics import get_scorer
get_scorer('accuracy')._score_func(y_true, y_pred)

Thought on this @hadifawaz1999 ? ( as you raised the issue )

We could do something like this to also accept callable and deal with parameterization ?
def score(self, X, y, metric="accuracy", metrics_params=None):
  ...
  if metrics_params is None:
    metrics_params_ = {}
  # let score func raise error if metrics params is not right format
  if isinstance(metric, str):
    return  get_scorer(metric')._score_func(y_true, y_pred, **metrics_params_)
  elif callable(metric):
    return  metric(y_true, y_pred, **metrics_params_)
  else:
    # throw an error

@baraline
What about the cases where y_pred is predict_proba(X) instead of predict(X)?

I'm not sure, but I see your point, it is indeed a problem.
For example roc_auc_score would handle probabilities estimates but not accuracy_score according to docs.
To summarize:

If the metric support probabilities, we want to support both probabilities estimate and predicted class as input
Otherwise, we only accept predicted class as inputs.

This raise the question of how should the user be able to use probabilities estimates over predict class (i.e. score with the output of predict_probas instead of predict).
One easy solution is to introduce another parameter in the score function, something like a boolean use_probabilities_estimate to determine wheter predict_probas should be used over predict. Then let sklearn raise the error if the metric does not support probabilities estimate.
I'm pretty sure there might be a better way to do this though...

I'm not completely sure but we could do something along the following lines?
scorer = get_scorer(metric)
try:
        return scorer._score_func(y_true, predict(X))
    except:
        try:
            return scorer._score_func(y_true, predict_proba(X))
        except:
            # throw an exception

I think, for now, wouldn't supporting a few scoring methods be a good idea? Since we already claim that aeon is sklearn compatible so it wouldn't be much of an issue if someone wants to use another scoring method.

I think the string and callable input with use_probabilities_estimate or however you name it is fine. Changes to base classes should be more strictly curated IMO so better to get it correct now.

I think the string and callable input with use_probabilities_estimate or however you name it is fine. Changes to base classes should be more strictly curated IMO so better to get it correct now.

Sounds Good! I'll change it accordingly.

I've done the needed changes. @baraline Thankyou for reviewing.


Update README and add script for local CI

Codecov Report

Merging #437 (158c3de) into master (b5029d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   79.34%   79.34%
=======================================
  Files          72       72
  Lines        6198     6198
=======================================
  Hits         4918     4918
  Misses       1280     1280

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(ci): install doc builder explicitly

It cannot be added to pyproject.toml, otherwise it raises issues when uploading to pypi.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Cannot get correct scroll on last item

Hi! I picked up Kent's work on useCombobox and react-virtual and came up with this: https://codesandbox.io/s/epic-morse-jffe1.
Released an alpha for Downshift to fix some things, and now it should work, apart from this use case: highlighting from first item to last (using ArrowUp) is not bringing the item into view. Scroll somehow fails (unless I pass {align: 'start'} to the scroll function. However I don't want to do that for all cases.
Last item is scrolled correctly when moving from second to last to last (using ArrowDown).
Any idea why I get this bad scroll in the use case above? Thanks!

Looks like a bug I'll find a fix in the morning 👍

Also looked into it a bit more. It seems that, with the example above, on arrow up from the first item, react-virtual returns virtualItems but without the last one. useCombobox will have highlightedIndex as 25, but last item from react-virtual comes as 24.
Not sure if it's a react-virtual bug or the example bug. Hope this helps in fixing it. If this will get fixed then the useCombobox - react-virtual combination should work (y)

Just pushed a fix for this. And better yet, it fixes some other edge cases with dynamic virtualization as well. Update your sandbox dep and you should be good to go :)

This almost does it: https://codesandbox.io/s/reverent-goldwasser-g6muv
Hit up and it does scroll down, but not far enough.

Updated it to use onStateChange rather than stateReducer (because the user-provided state reducer should be pure): https://codesandbox.io/s/dreamy-gareth-yeyxq
However, same issue.

Did you get @tannerlinsley fix? I see it's still 2.1.8, update to 2.1.9.

Oh duh! Nice. Thanks both of you 🎉 Looks like it's working like a charm :)

Weird thing happened. I had the menu open, then I changed tabs to send that comment, and when I went back, I saw this:

Any ideas?

Figured it out. I think it's a bug in downshift. But if you make it so there's no items left (type gibberish) and then arrow down, there's a "highlightedIndex" change which triggers me to call scrollToIndex to 0, but there's no item at index 0 because there are no items.
I think the solution would be in downshift to not update the highlighted index to an index that doesn't have an associated item.

Yeah, I had a safeguard against this to just return early in RV, but I think this is an error you'll want to see if you're trying to scroll to an index that doesn't exist.

I think the problem is right inside the method calculating the next highlighted index, I also need to check if items.length is 0. Will fix and write a test in the PR already opened.
nit: you can use onHighlightedIndexChange @kentcdodds so you don't have to perform that check inside the onStateChange.


Sending FancyMessage's

I was using this library in one of my plugins, and its been working, but for some reason, it just stopped working and is giving me this error:
02.05 17:23:21 [Server] WARN java.lang.NoSuchFieldException: playerConnection
02.05 17:23:21 [Server] WARN at java.lang.Class.getDeclaredField(Class.java:2070)
02.05 17:23:21 [Server] WARN at net.amoebaman.util.Reflection.getField(Reflection.java:147)
02.05 17:23:21 [Server] WARN at mkremins.fanciful.FancyMessage.send(FancyMessage.java:616)
02.05 17:23:21 [Server] WARN at mkremins.fanciful.FancyMessage.send(FancyMessage.java:605)
02.05 17:23:21 [Server] WARN at me.thatcurlyfry.showitem.Main.onChat(Main.java:159)
02.05 17:23:21 [Server] WARN at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
02.05 17:23:21 [Server] WARN at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
02.05 17:23:21 [Server] WARN at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
02.05 17:23:21 [Server] WARN at java.lang.reflect.Method.invoke(Method.java:498)
02.05 17:23:21 [Server] WARN at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300)
02.05 17:23:21 [Server] WARN at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74)
02.05 17:23:21 [Server] WARN at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
02.05 17:23:21 [Server] WARN at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:501)
02.05 17:23:21 [Server] WARN at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:483)
02.05 17:23:21 [Server] WARN at net.minecraft.server.v1_8_R3.PlayerConnection.chat(PlayerConnection.java:1111)
02.05 17:23:21 [Server] WARN at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1026)
02.05 17:23:21 [Server] WARN at net.minecraft.server.v1_8_R3.PacketPlayInChat$1.run(PacketPlayInChat.java:39)
02.05 17:23:21 [Server] WARN at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
02.05 17:23:21 [Server] WARN at java.util.concurrent.FutureTask.run(FutureTask.java:266)
02.05 17:23:21 [Server] WARN at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
02.05 17:23:21 [Server] WARN at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
02.05 17:23:21 [Server] WARN at java.lang.Thread.run(Thread.java:745)
PS: line 159 in my main class is just fancymessage.send(player)

What server software are you using? It looks like the Player instance doesn't contain a playerConnection field, which is causing Fanciful's reflection hackery to fail.

I'm using PaperSpigot 1.8.8

It looks like Spigot's implementation of the Bukkit Player interface has diverged enough from the CraftBukkit implementation against which Fanciful was originally written that FancyMessage.send won't work on Spigot servers. I'd recommend using the Chat Component API instead of Fanciful if you're writing plugins for Spigot servers – the API is pretty similar to Fanciful's and it should be better supported.


Suggest x <$ y instead of const x <$> y (#546)

This pull request adds the hints I proposed in #546.

Thanks for the PR. This fails with:
INPUT: yes = pure alice <$> [1, 2]-- alice <$ [1, 2]
OUTPUT: C:\projects\hlint\.stack-work\install\9b4c8a4d\share\x86_64-windows-ghc-8.6.1\hlint-2.1.10\hlint.yaml:1:7: Suggestion: Use <$
Found:
  pure alice <$> [1, 2]
Perhaps:
  alice <$ [1, 2]
WANTED: <failure>

Is it possible you need a space before the --? I wrote the test generator, and certainly all my other examples have the space there.

Yes, that was a typo, which I've now fixed.
For some reason, that failure didn't show up when I ran stack exec hlint test (as suggested by the README.) I'm not sure why that is.


fixed the issue for first stake button not working

This branch was made off of staging. To keep our branches in sync, create features off of dev and then merge to dev. From there, the change can be promoted to staging and then prod. This ensures all of the environments reflect the progression of the app respectively.
I am closing this PR and rebasing the branch with dev and promote the change through to prod.


Support perform_action feature of the fleet adapter

The 22.02 release of RMF introduced a perform_action activity that forwards a custom command to the robot. Any users that depend on free fleet won't have access to this feature unless we integrate it into the free fleet pipeline.
One aspect of this feature that will be very tricky is allowing custom logic to decide whether or not to accept a task with a custom action. We may need to introduce a plugin system to free fleet for the task approval feature to be fully leveraged.

Is there any progress regarding this feature? this would really help a lot of developers in implementing custom action regarding their robots


get refresh token renew access token

Hello, is it possible to get a refresh token and renew the access token with this sdk?
If yes how to do that?

Greetings.
It is possible, see.
An enhancement is planned to make direct use of token management more convenient; no timeline on that.


Format Document for vscode extension

Proof of concept implementation for allowing use of the Format Document command to sailfish templates containing HTML code.

Click here for screenshots
Before:

After:

Independently of this, it would also be nice if the extension supported all other HTML language features in vscode, like snippets and auto-closing HTML-tags - if there's enough interest I could also add these to the language-configuration (at runtime).

@ambiso Thank you for your contribution! I have updated the link to the latest published extension page. If you would like to add some of the mentioned other HTML language features, I would imagine that they would also be appreciated! Thanks again!


Unused method BulkFixProcessor.producableFixesForError?

Two things regarding this method:

Is producable correctly misspelled, shouldn't it be producible?
It seems producableFixesForError is not used at all.

https://github.com/dart-lang/sdk/blob/a6cc772b670034f355c626e28ce11d1555f97e24/pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart#L239

@DanTup I suspect that this was added for the original LSP support but is no longer needed. Can you confirm that?

@bwilkerson correct - it should've been removed with the code that used it in 8f9cdb3b2f846a146ea29d41f1c7b79e9b280c4e.
Feel free to remove if convenient, otherwise I can do it tomororw. Thanks!

https://dart-review.googlesource.com/c/sdk/+/212293

Thanks!


[FLINK-21256][FLINK-21257] Add Restarting and Executing state for declarative scheduler

What is the purpose of the change
Declarative Scheduler consists of a number of internal states.
Note that this change is currently not usable as-is, as the other parts of declarative scheduler are not merged yet (See for the prototype this PR is based on: https://github.com/tillrohrmann/flink/tree/declarative-scheduler)
Verifying this change

The change is adding unit tests.
Note that integration tests for the declarative scheduler will cover additional functionality.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation
Will be handled in a separate PR.

Thanks a lot for this thorough review and the good comments! I believe I addressed all of your comments!
I did not move this one class to the correct commit, because there's still an open discussion whether we need it or not. If this get's approved as is, I'll clean it up before committing (I also committed a log4j properties change)

Thanks a lot for your patience reviewing my changes. I hope I really addressed every concern this time.

Thanks a lot for your careful review! I pushed another update.

Thanks a lot for the approval! I addressed the remaining comments and will merge this now.


Editing gui title/items

nice to have 👍
it will be cool with combinding with #6 :D

Hey, I don't think this is in scope of this plugin but will see. No more information or ETA for now because I want to focus on other features first.

I haven't been able to do much in the project lately but after 1.5.0 is released (hopefully tomorrow), I will most likely start working on editing GUI titles/items in between editing more scoreboard stuff.


Added some error checks

Describe the PR
Improved error handling a bit by adding missing err checks

Codecov Report

Merging #411 into master will decrease coverage by 0.94%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   84.71%   83.76%   -0.95%
==========================================
  Files           7        7
  Lines        1341     1349       +8
==========================================
- Hits         1136     1130       -6
- Misses        119      127       +8
- Partials       86       92       +6

Impacted Files
Coverage Δ

gen/gen.go
58.33% <0%> (-10.56%)
:arrow_down:

parser.go
82.52% <15.38%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b534de4...24bc7ee. Read the comment docs.


CDH add unwrapkey API

Support decrypting image for CDH.
Let's continue this PR in v0.9.0 cycle.

A few comments. Looks pretty good overall. I had expected this PR to remove support from the AA, but I guess that will be done separately?

Yes. I want to put a final PR to remove all useless things when all are ready.

@fitzthum Can we merge this before we think of a better way to hide the concrete KMS type used to encrypt the image?

Can we merge this before we think of a better way to hide the concrete KMS type used to encrypt the image?

Yeah probably. I will take another quick look at this PR.


Issues in Service Fabric Queryable extensions

am working on integrating the Queryable extensions of ReliableIndexDictionary and facing few challenges on querying the Reliable Dictionary. Below are the exception details with respect to the query I am performing.
Reliable Indexed Dictionary:
var dictionary = await this.StateManager.GetOrAddIndexedAsync<Guid, File>(
                       "FileDictionaryName",
                      new FilterableIndex<Guid, File, string>(nameof(File.FriendlyFileName), (k, v) => v.fileName),
                        new FilterableIndex<Guid, File, long>(nameof(File.FileSizeInBytes), (k, v) => v.FileSizeInBytes.GetValueOrDefault()),
                       new SearchableIndex<Guid, File>(nameof(File.FileName), (k, v) => v.fileName)).ConfigureAwait(false);
Queryable Indexed Dictionary:

var queryableDictionary = new QueryableReliableIndexedDictionary<Guid, File, File >(dictionary, this.StateManager);

NOTE: We are unable to get all the records in the collection.
Can anyone please help out on this?
I have posted a question in stack over flow below is the link and issue details,
https://stackoverflow.com/questions/53482969/service-fabric-queryable-extensions-facing-issues-while-performing-linq-queri

Note that to use this extension, you must use the Queryable dictionary when adding/updating/removing entries to the dictionary (i.e. use queryableDictionary and not dictionary in your code above).  Otherwise, the underlying index will be out-of-sync with the contents of the reliable dictionary.  Can you confirm that you are doing this?

We are using the same querable dictionary for creating updating deleting an retrieving

We are using the same querable dictionary for creating updating deleting an retrieving.
Issues am facing documented in below link , could you please check and help me out to fix this issue
https://stackoverflow.com/questions/53482969/service-fabric-queryable-extensions-facing-issues-while-performing-linq-queri

The LINQ implementation was a contribution.  I suspect the LINQ implementation is not complete.  You can see and attempt to fix the code here:
https://github.com/jessebenson/service-fabric-queryable/blob/master/src/ServiceFabric.Extensions.Services.Queryable/LINQ/ReliableIndexedDictionaryQueryContext.cs
The alternative is to use the OData syntax to query ...

Thanks, Jesse for your suggestions.
We can't use OData in our application, which will fetch entire data and perform querying on that. It will impact our performance(our collections will have huge data). Correct us if we are wrong.
And coming to the extension of Linq features, do you have any plan to implement them in the future? If yes can you provide us the release plan for the above issues? Such that we can plan our development on extending this features.

The OData syntax is just a particular string format (no need to include OData packages/etc.) on how you structure the queries - i.e. rather than using LINQ.  It's something to consider.
The LINQ provider was a contribution, so I welcome additional contributions if you would like to take a stab at the fix!  I don't have a timeline for a fix or investigation, unfortunately.


KeyError: 'vehicles'

Describe the issue
BMW Connected Drive integration shows "unavailable" within any Lovelace cards.
Expected behavior
Integration should connect successfully and create the regular set of sensors and entities for the following vehicles within my account G05 (2019 BMW X5) and F55 (2020 MINI 5-Door)
Home Assistant version
Home Assistant 0.108.6
Last version: Not relevant as issue is independent of HA version.
Screenshots
Log Output:
2020-04-18 11:33:24 WARNING (MainThread) [homeassistant.setup] Setup of bmw_connected_drive is taking over 10 seconds.
2020-04-18 11:33:28 ERROR (MainThread) [homeassistant.setup] Error during setup of component bmw_connected_drive
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 175, in _async_setup_component
component.setup, hass, processed_config  # type: ignore
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/init.py", line 51, in setup
accounts.append(setup_account(account_config, hass, name))
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/init.py", line 79, in setup_account
cd_account = BMWConnectedDriveAccount(username, password, region, name, read_only)
File "/usr/src/homeassistant/homeassistant/components/bmw_connected_drive/init.py", line 126, in init
self.account = ConnectedDriveAccount(username, password, region)
File "/usr/local/lib/python3.7/site-packages/bimmer_connected/account.py", line 61, in init
self._get_vehicles()
File "/usr/local/lib/python3.7/site-packages/bimmer_connected/account.py", line 230, in _get_vehicles
for vehicle_dict in response.json()['vehicles']:
KeyError: 'vehicles'
Your config.yaml
# BMW ConnectedDrive Integration
bmw_connected_drive:
  name:
    username: see below
    password: see below
    region: rest_of_world

username/password as proven to work on BMW ConnectedDrive portal and iOS App.
Output of bimmer_connected fingerprint
I'm using the out-of-the-box integration from https://www.home-assistant.io/integrations/bmw_connected_drive/ so not so sure how to run the fingerprint.
NOTE: It might take me a while to respond on GitHub (I only maintain this in my free time), but I will respond.

Did the component work earlier for you? Or is this a new setup for you?
And are the BMW and Mini linked to the same Connected Drive account?

Hi Gerard
Yes - has been working for a while already, a few months at least.
Yes, both vehicles are linked to the same CD account. I first had the G05 against my account and it worked fine in HA. I logged into the MINI Connected app with the same username/password and added the F55 to my account once I'd taken delivery of it. The F55 entities appeared the next time I rebooted my HA install.

You have probably already tried, but can you restart HA to see if that solves the issue?
No changes have been made to bimmer_connected in the last HA releases and the BMW API has some hickups every now and then. Normally that's automatically solved, but maybe you did a HA restart during those issues and then your account can't be setup correctly.

Yep - have restarted HA a number of times for other purposes (pick up new integrations as example).
How can I run a fingerprint from my HA install on a RPi ?

When you connect to your RPi via SSH or directly in the terminal of the RPi you should be able to execute the fingerprint code as mentioned in the readme.

@whitwocb if you are running Home Assistant (formerly known as hassio), you can install the SSH & Web Terminal add-on. Once installed you can open the webui and install bimmer_connected as mentioned here.
After that you can run the fingerprint command.

Also "command not found"

I see I have protection mode disabled in the add-settings. Can you try that?

Yep, okay.. Dumb mistake. Wasn't using the community add-on, rather the similarly named Official one. Give me a few minutes..

Yeah you need the community one indeed.
When you have successfully run the command
bimmerconnected fingerprint <username> <password> <region> you can copy the files being made to the share folder with
cp /usr/lib/python3.8/site-packages/bimmer_connected/vehicle_fingerprint/2020-04-23_20-25-53/* /share
The share folder should then contain a files status_0.txt and vehicles_0.txt.

vehicles_0.txt
status_0.txt
status_1.txt

I've updated the Supervisor version too in case this helps... Let me check the entities again.

The data looks good and as the fingerprint command was able to get it, so should the Home Assistant integration be.

Its all lit back up like a Christmas tree so I must have had larger problems than just this integration. Maybe it was the most visible one for me? Anyway - all is well now and I'm sorry for wasting your time.

No problem. Good to hear it’s working and happy to see your Mini is working nicely with the integration together with your BMW.


Wrong types in query.finished.failure

How to correctly describe the type of Error when Validate is triggered in Query?
example sandbox

found one way to avoid problem, check  fail instanceof Error


Add automated pipeline for pulling, processing, and saving to HF/GCP/Wherever

Detailed Description
Instead of relying on someone to manually run the data pipeline to get more satellite data, we should try automating it, so the dataset just grows on its own.
It could be something like with Prefect, or Airflow, use the current app, or something else? But adding support for that would probably be quite self-contained compared to the rest of the codebase
Context
I manually pull new data every once in awhile, but keeping it standardized and on a schedule would probably keep the data more up to date and easier to add more strict checks than me looking at random examples and the simple checks of no NaNs, etc.
Possible Implementation
We would want to make sure the data is sensible, so maybe add something like https://github.com/great-expectations/great_expectations to check data before its added to the Zarr store.

Another great one to try would be to use Pangeo forge https://pangeo-forge.org/ which is used for a lot of NWP and climate data already and would seemingly work for all our datasets, other than maybe PV


[WIP] *: dump snapshot to file

I think I should not change kvproto and Snapshot format, at least not for now.
I think I make things complex than it should be.

Coverage increased (+0.003%) to 85.359% when pulling 3b313f6478eadef9d4ada344d1b0753691980a87 on tiancaiamao/snapshot-file into 51f79fd6aecd07451d2cece9525117e96a6b5e1b on master.

Coverage decreased (-16.0%) to 69.377% when pulling 7458e6aa1cb5b203bca848ad87e84ce20a271926 on tiancaiamao/snapshot-file into 51f79fd6aecd07451d2cece9525117e96a6b5e1b on master.

will be include in https://github.com/pingcap/tikv/pull/648


[BUG] O BLOXSTRAP MENU SIMPLISE DOESN’T EXIST

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
When I try to open the menu (which doesn't exist, even though I'm looking everywhere) it simply opens the Roblox launcher to start playing, even uninstalling and installing again I still can't open the Bloxstrap Menu. Please Help!!

Do Windows Key + R and paste in
%LocalAppData%\Bloxstrap\Bloxstrap.exe -menu

Do Windows Key + R and paste in %LocalAppData%\Bloxstrap\Bloxstrap.exe -menu

You can also copy this into a shortcut.

https://github.com/pizzaboxer/bloxstrap/wiki/Opening-the-Bloxstrap-menu


Spinnaker integration

What does this PR do?
PR includes Spinnaker integration including all assets like dashboards, image, README content, etc.
Motivation
This is beta release of agent integration and is intended for internal testing before going live.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Squashing Commits: PR is now here.

PR is here: https://github.com/DataDog/integrations-core/pull/19145


fix: DEV-3427: View slider follows the playhead

if playhead is ahead of indicator and view, pull view back to playhead

Codecov Report
Base: 9.39% // Head: 9.39% // No change to project coverage :thumbsup:

Coverage data is based on head (f8d90cc) compared to base (e778b43).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1071   +/-   ##
======================================
  Coverage    9.39%   9.39%
======================================
  Files         109     109
  Lines        7782    7782
  Branches     1954    1954
======================================
  Hits          731     731
  Misses       5905    5905
  Partials     1146    1146

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allows to create tax settings with more than 100% tax.

Screenshots

Should keep limit of 1000%.

Lesser than 1000 now

Allows to enter more than 1000. So, validation message should be displayed. @mitulpanch

Allows to type more than 1000, but on click of save btn server throws validation message.


Using required/optional should not be allowed in a when block

I would like to check in a mapping the value of one entry only if another entry has a specific value.
E.g. if 'A' is set to 'a' then 'B' should set to 'a' as well. This is a logical implication and I thought this could be expressed in dry-validation using "when".
I provide here some minimized code and I am quite sure that this code should be evaluated to false. However I got true. But why?
Did I understood the "when" method wrong? Or is this a bug?
require 'dry-validation'

TEST = { 'A' => 'a', 'B' => 'B' }

validator = Dry::Validation.Schema do
  required('A').filled(:str?).when(eql?: 'a') do  # => true
    required('B').filled(:str?).value(eql?: 'a')  # => false
  end
end                                               # should end in false (according to implication truth table)

puts validator.call(TEST).success?                # However, it is evaluated to true, why?

You need to define all keys, always, even when they are optional. We should not allow required in the context of a when block, as it just doesn't work the way you expected. Your case can be expressed using high-level rule:
Dry::Validation.Schema do
  required('A').filled(:str?)
  required('B').filled(:str?)

  # using abstract rule syntax
  rule(a_eql_b: %w(A B)) do |a, b|
    a.eql?('a').then(b.eql?('a'))
  end

  # or using custom block
  validate(a_eql_b: %(A B)) do |a, b|
    a == 'a' ? b == 'a' : true
  end
end

I'm actuallly not happy with when syntax, we came up with it as a nice syntax sugar but it introduced a couple of challenges in the internals and I'm not sure if it's really worth the effort.

Hmm, it is not quite clear to me, why required should not be allowed in a when block?
What ist the reason for this?
To check implications is a common tasks in validations I think. There are a lot of use cases to check only b if a is set. So, there should be a pragmatic way to express this.
I love dry-validation but implication handling is not really convincing in dry-validation from my point of view.

Because when block should deal with values, not keys. In dry-v you define a schema, including required and optional keys, missing key is also an error, and we want to validate that too. So, first of all a schema defines a structure, then it defines individual values. High-level rules are applied only when the structure is valid and individual values that a given high-level rule depends on are valid too. With this approach, various rules won't be even applied when keys are missing, and the only check that would be applied is key?.
If we allowed defining required('A').filled(:str?) inside that when block, it would mean that you only expect that key to present, and its value to be a string, when A's value equals "a" - and it is not what you want to check, because you do expect both A and B to be present in the data structure, and then you have certain rules for the values.
Validating structures is something that other validation libraries don't do, so it's something to learn and understand.
btw - under the hood, that when block creates a high-level rule, as I mentioned, it's just a syntax-sugar.

You explained exactly the problem I have to validate. In a JSON definition format some keys must be only present if another key value pair is existing. Think of JSON structure like this one here.
[
{
   'type': 'district',
   'provider': 'AWS',
   'aws_access_key_id': 'akid',
   'aws_secret_access_key': 'secret',
  ....
},
{
  'type': 'district',
  'provider': 'GCE',
  'gce_secret_key_file': 'path/to/secrete/key.file',
  ...
}
]

In this example the keys 'type' and 'provider' must be set. The keys 'aws_...' must be only set and validated if provider == AWS and keys 'gce_...' must be only set and therefore validated if provider == GCE. It is still a schema but some parts depend on other parts!
Do you really think these kind of problems are uncommon and must not be validateable by dry-v?

I would validate this in two steps, first validate the common ones type and provider and then lookup a second validation schema based on the provider field value. This "pattern" could also easily be turned into a reusable class/component.
PROVIDER_SCHEMAS = {
  'AWS' => Dry::Validation.Form{
    required(:aws_access_key_id).filled
    required(:aws_secret_access_key).filled
  },
  'GCE' => Dry::Validation.Form{
    required(:gce_secret_key_file).filled
  }
}.freeze

base_schema = Dry::Validation.Form{
  required(:type).filled
  required(:provider).filled(included_in?: PROVIDER_SCHEMAS.keys)
}

base_result = base_schema.call(params)

if base_result.success?
  provider_schema = PROVIDER_SCHEMAS[base.to_h[:provider]]
  provider_result = provider_schema.call(params)
  if provider_result.success?
    # merge results or do whatever
    return base_result.to_h.merge(provider_result.to_h)
  else
    raise 'validation error'
  end
else
  raise 'validation error'
end

Thank you very much. That is basically how I refactored my solution getting to know that when does not work as intended.
So, that is fine for my current situation.
However, the downside of this solution is, that schema validation logic has to be coded partly outside the schema definition. I do not think that this is intent of dry-validation?
Therefore, I would propose to refactor when completely being able to handle logic implications in a way of my initial comment.

That's a missing feature, please stick to the workaround for now. I'll be adding support for this before 1.0.0.

@solnic do you still think this is a bug?

See also https://github.com/dry-rb/dry-validation/issues/383

when was removed in dry-schema, so this is not going to be addressed.


Ey - The location of the job is Cluj Napoca instead of remote

ENVIRONMENT: production
URL: https://solr.peviitor.ro
Browser: Microsoft Edge
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in the browser
Search for "Ey" Company
Check the locations for the jobs: Junior Direct Tax HUB Team Leader  and External Audit Manager
Open https://careers.ey.com/ey/job and check the jobs locations

EXPECTED RESULTS:
The jobs are remote
ACTUAL RESULTS:
The location of the jobs is Cluj Napoca instead of a remote

Fixed!

Jobs are fixed as remote


Make getting started more user friendly

After installing ansible on the machine that will run jetlag playbooks, the user doesn't need to install anything else manually.
The system packages, pip packages and ansible galaxy packages are all handled by the playbooks as necessary.
Additionally we check to see if we need to deal with the Supermicro tools based on presence of the nodes.

Should update the docs alongside this PR...


Add support for Suptronics x920 DAC

Hi there
Could you please add support for this DAC ?
http://www.suptronics.com/miniPCkits/x920.html
Thanks!

Superseded by #439
I believe this board is supported already, can you try following this guide with dtoverlay=iqaudio-dacplus?

Also, I'm closing the issue because going forward we will use #439 to centralize DAC requests. Please refer to that issue. If you have trouble or if you want to confirm this dtoverlay works feel free to add a comment over there. Thanks!


sushiclient: BR1 with only print ISBNs in data has no ISBN output

When a BR1 is fetched with sushiclient, and only Print_ISBN elements are provided, no ISBN appears in the output report.
(It's unclear from the COUNTER COP whether the "ISBN" field on reports is intended to be Online_ISSN only, but in the case where only 1 is available it seems reasonable to me to include it. At any rate having it totally missing makes matching in my ERM impossible...)

Fixed in 25dac6a51d24bcb1bf4ee8b3d5ef32b2b17e4a6f


Profile

Added Profile Button in the header
Closes #420
Description
State Variables: Added state variables for name, email, and phone to store user profile details.
Dropdown Menu: Added new items to the dropdown menu for displaying the user's name, email, phone, your orders, rewards, and your coupons.
Profile Details: Displayed profile details using .
Grid Layout: Used Row and Col from Bootstrap for responsive grid layout, adjusting column sizes for different screen sizes (md, lg, etc.).
Form Styling: Improved form input styling with Bootstrap classes and custom CSS.
File Upload: Added file upload functionality with an input element.
CSS Styling: Included basic CSS styles to enhance visual appeal and responsiveness.
Added state variables for phone, age, dob, and gender.
Modified useEffect to fetch these fields from the database.
Updated Onsubmit, addUser, and updateUser functions to handle these new fields.
Added new input fields for Phone Number, Age, Date of Birth, and Gender in the form.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@dinxsh can you review it


Unary shape helper under broadcast shape helper

Changed the ShapeHelper hierarchy. Before, Unary and Binary shape helper were unrelated. This caused code duplication as we had to generate two different ways to do SIMD (and possibly kernel merging).
Now, Unary is a specialization (subclass) of Binary, where calls such as "Is broadcast present" always return false as there is never any broadcasting for unary operations.
As a result, the code generating the SIMD code was reduced to one case.

Jenkins Linux amd64 Build #11123 [push] Unary shape helper under... started at 00:29

Jenkins Linux s390x Build #11132 [push] Unary shape helper under... started at 01:29

Jenkins Linux ppc64le Build #10179 [push] Unary shape helper under... started at 01:34

Jenkins Linux amd64 Build #11123 [push] Unary shape helper under... passed after 1 hr 22 min

Jenkins Linux s390x Build #11132 [push] Unary shape helper under... passed after 1 hr 33 min

Jenkins Linux ppc64le Build #10179 [push] Unary shape helper under... passed after 1 hr 53 min


Remove "Settings" From Resource Manager Display for Users Without Permission

Per the below linked discussion, we need to stop the HTTP 401 errors that appear with the file manager whenever it is granted access for users that do not have access to add/edit folder types etc.
Originally posted by @DNNMonster in https://github.com/dnnsoftware/Dnn.Platform/discussions/5436

I am testing in a non standard fashion by compiling the develop branch and installing the DNNCE_ResourceManager_09.11.00_Install module manually.  Test environment only.
I believe I am still seeing an http 401.
When authenticated as a non admin and the RM in user mode, the dnn-rm-folder-mappings component is calling out to the GetAddFolderTypeUrl endpoint which returns a 401.  It's DnnAuthorize attribute access level is set to Admin so this make perfect sense.
I think we may need to prevent this request from being made by non admins or find an alternate solution..??
https://github.com/dnnsoftware/Dnn.Platform/blob/295a0ecc28aa34a8c8455dc5d8c72a3dd700812d/DNN Platform/Modules/ResourceManager/ResourceManager.Web/src/components/dnn-rm-folder-mappings/dnn-rm-folder-mappings.tsx#L28

It was no longer calling that API when we tested during development. Did you pull develop branch after this PR got merged ?

There should now be a call to CanManageFolderTypes before that component even renders and it does not render and not call GetAddFolderTypeUrl if the user is not an admin or host.

You are right...  I did a yarn build on the web folder and then I compiled the install.  I am now seeing it's glory. Doh.


Add datetime start to chainermn

add datetime_start to chainerrm and base trial class

Merged the PR. Thanks for your contribution @tanapiyo !


bug[next]: Fix shift inside scan pass

WIP

The test failures seem to be a result of removing https://github.com/GridTools/gt4py/pull/1280/files/d4160bb32c7e091e94afe983fbe747c32c9f7514#r1250968455 again.


chore: Update changelog and bug template with v2.11.2

Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to https://github.com/kedacore/keda/issues/4795

/skip-e2e


Replace local license checks with the SymbiFlow/actions/checks@main action

https://github.com/SymbiFlow/fpga-tool-perf/blob/3b4f079fd13ffe89d5703bf3a995031ecf32b923/.github/workflows/ci.yml#L27-L31
https://github.com/SymbiFlow/actions/tree/main/checks

Example at https://github.com/SymbiFlow/symbiflow-rr-graph/blob/master/.github/workflows/licensing.yml


another DBus exception error.

Hi, I saw that you add support for newest supegfxctl, but upon installlation when I run program I got this:
Traceback (most recent call last):
  File "/usr/local/bin/asusctltray", line 335, in <module>
    TrayIcon()
  File "/usr/local/bin/asusctltray", line 109, in __init__
    self.build_menu()
  File "/usr/local/bin/asusctltray", line 118, in build_menu
    self.add_graphics("Graphics")
  File "/usr/local/bin/asusctltray", line 174, in add_graphics
    current_graphics = self.get_current_graphics()
  File "/usr/local/bin/asusctltray", line 194, in get_current_graphics
    mode = self.gfx_proxy.Mode()
  File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 72, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/python3/dist-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
  File "/usr/lib/python3/dist-packages/dbus/connection.py", line 652, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.UnknownMethod: Unknown method 'Mode'

Did I miss something again?
Environment:
OS: Debian GNU/Linux bookworm/sid x86_64
Host: ROG Zephyrus G14 GA401QM_GA401QM 1.0
Kernel: 5.15.0-3-amd64
DE: Plasma 5.23.5
WM: KWin

Would you mind sending the output of supergfxctl --version?

Supegfxctl does not return anything (there is no version switch)
Asusctl -v returns:
App and daemon versions:
      asusctl v4.0.6
        asusd v4.0.6

Component crate versions:
    rog-anime v1.3.0
     rog-aura v1.1.0
     rog-dbus v4.0.2
 rog-profiles v1.1.3
rog-supported v4.0.0

Product family: ROG Zephyrus G14
Board name: GA401QM

Sounds like you have a very outdated version of supergfxctl. The --version arg used to work in 3.x too. Since the dbus API was changed rather drastically in v3 - v4 the script doesn't work until you update supergfxctl.

Following your advice, I recompiled again asusctl. and it bumped it to version 4.0.7, but then I remembered that supergfxctl is separate project and you were right, I had really old version.
Somehow I thought/remembered that supergfxctl is part of asusctl (don't ask me why.)
Anyway, with new supergxctl everything works.
Again, thank you on really quick answers.


Add manual migration

Describe your suggested feature
Add an option to just use normal migration like in mihon, since it's very difficult to use it to migrate since it only shows one manga
Other details
Please
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an request for a feature in the original Tachiyomi, I am opening because multiple versions of Yōkai have been released without this feature.
[X] If this is an issue with an extension, or a request for an extension, I should be contacting the extensions repository's maintainer/support for help.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have checked through the app settings for my feature.
[X] I will fill out all of the requested information in this form.

Wdym? It's already there even before I forked J2K. Browse -> Migration -> Select the source (Not the all button, the source name/icon). Alternatively you can just go to the individual entry's page, tap the triple dots -> Migrate Manga/Manhwa/Manhua.


Save access_token in users table?

I have a user logging in fine and saving all of their info (id, name, email, etc) to the DB, but it does not seem to be saving the access_token? Isn't it supposed to be? I am not sure why it isn't saving that portion in the DB...I can't tell if it is a bug, or something I need to configure so that it saves correctly.

You'll need to save it separately.
When you receive user's information from Facebook and save it using Model, it does not contain access_token in response, that is why it isn't saving the access token.
But you can do it this way...
// update access token in user's profile
$user->access_token = $token;
$user->save();

I am using the example that had been give: https://github.com/SammyK/LaravelFacebookSdk#user-authentication-example
After reading through: https://www.sammyk.me/best-practice-for-facebook-login-with-the-javascript-sdk-and-php-sdk-v4-1
It looks like I do not need to save the access_token unless I am accessing their data when they are offline, which I am not.
REMAINING QUESTIONS:

What I am not understanding is where the access token is actually saved when I use the above example? Is it being saved into the JS or the PHP session? I var dumped the session data and it did not seem to be in there...

I can get a user to log in, but when I try to make Graph requests while they are logged in it throws this error: Method Facebook\Entities\AccessToken::__toString() must return a string value
I am not sure where it is trying to pull the access_token from, so it is difficult to troubleshoot and it seems like the code should already convert it over. This is the code I am trying to execute in my controller:
$friends = Facebook::edge('user_friends')->fields('id', 'name')->limit(5); $user = Facebook::object('me')->fields('name', $friends)->get();

I am using the example that had been give: https://github.com/SammyK/LaravelFacebookSdk#user-authentication-example
After reading through: https://www.sammyk.me/best-practice-for-facebook-login-with-the-javascript-sdk-and-php-sdk-v4-1
It looks like I do not need to save the access_token unless I am accessing their data when they are offline, which I am not.
REMAINING QUESTIONS:
-1. What I am not understanding is where the access token is actually saved when I use the above example? Is it being saved into the JS or the PHP session? I var dumped the session data and it did not seem to be in there...
-2. I can get a user to log in, but when I try to make Graph requests while they are logged in it throws this error: Method Facebook\Entities\AccessToken::__toString() must return a string value
I am not sure where it is trying to pull the access_token from, so it is difficult to troubleshoot and it seems like the code should already convert it over.
This is the code I am trying to execute in my controller:
$friends = Facebook::edge('user_friends')->fields('id', 'name')->limit(5); $user = Facebook::object('me')->fields('name', $friends)->get();

Ok, I figured it out, looks like I needed to add something in to actually set the token to the session:
Session::put('FacebookAccessToken', (string) $token);
And then when making a request, I needed to retrieve it from the session and re-set it:
$token = Session::get('FacebookAccessToken'); Facebook::setAccessToken($token);
This wasn't super clear in the info give, I would maybe update to make this part clearer. It seemed like this was take care of by the package when setting the token was implemented. I read through the README.md of both SammyK/LaravelFacebookSdk and SammyK/FacebookQueryBuilder and this was not clear at all, I was only able to figure it out after reading this issue: https://github.com/SammyK/LaravelFacebookSdk/issues/24
It could be that this would be super obvious to most developers attempting to work with the SDK, but I would recommend updating the description to include info on this.
Thank you everyone for your work on getting this SDK together!

I would maybe update to make this part clearer.

You're right, I get asked this question all the time. I'll update the docs to outline this better. Thanks! :)
@jagdeepsinghmundi Thanks again for helping troubleshoot this! :)


[ISSUE #22] codeCov for mqtt.cs.session

continuously submit for #22

Codecov Report

Merging #90 (8ab5d78) into main (4f3f127) will increase coverage by 2.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   33.38%   35.66%   +2.28%
==========================================
  Files          98       98
  Lines        4233     4231       -2
  Branches      670      669       -1
==========================================
+ Hits         1413     1509      +96
+ Misses       2562     2451     -111
- Partials      258      271      +13

Impacted Files
Coverage Δ

...a/org/apache/rocketmq/mqtt/cs/session/Session.java
52.89% <100.00%> (+13.04%)
:arrow_up:

...he/rocketmq/mqtt/cs/session/match/MatchAction.java
72.61% <0.00%> (+22.61%)
:arrow_up:

...che/rocketmq/mqtt/cs/session/infly/PushAction.java
57.89% <0.00%> (+27.36%)
:arrow_up:

...rg/apache/rocketmq/mqtt/cs/session/QueueFresh.java
90.00% <0.00%> (+90.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3f127...8ab5d78. Read the comment docs.


bug(macos):  Unable to move background with with_movable_by_window_background

https://github.com/atom/atom/pull/10208
There's a bunch of history regarding this one in the Electron world on how to "hide decorations but keep the traffic lights around."
I think a slight tweak in the flags would allow two types of decorations (title bar, and the traffic lights).

Do we need to propagate drag and drop event from wkwebview to nswindow like https://stackoverflow.com/a/54987061 ?

@keiya01 worth giving it a try I guess. I'm not fond of additional drop handler either.


Disable all parsers and processors by default

I have a need to disable all parsers and processors by default, while selectively enabling only a fixed subset of supported features.  The use-case I need to address is "only support ** and _" , while disabling all other Markdown syntax features.
For instance:
final MutableDataSet options = new MutableDataSet();

// Disable everything I don't need; not sure this is "everything"...
options.set(Parser.BLOCK_QUOTE_PARSER, false);
options.set(Parser.FENCED_CODE_BLOCK_PARSER, false);
options.set(Parser.HEADING_PARSER, false);
options.set(Parser.HTML_BLOCK_DEEP_PARSER, false);
options.set(Parser.HTML_BLOCK_PARSER, false);
options.set(Parser.INDENTED_CODE_BLOCK_PARSER, false);
options.set(Parser.LIST_BLOCK_PARSER, false);
options.set(Parser.THEMATIC_BREAK_PARSER, false);
options.set(Parser.REFERENCE_PARAGRAPH_PRE_PROCESSOR, false);

// Then, only enable a tiny subset of processors I need.
options.set(Parser.ASTERISK_DELIMITER_PROCESSOR, true);
options.set(Parser.UNDERSCORE_DELIMITER_PROCESSOR, true);

This works fine, afaict, but I'm left to enumerate all of the parsers and processors I can find and disable them.
The documentation at https://github.com/vsch/flexmark-java/wiki/Extensions#parser says:

Unified options handling added which are also used to selectively disable loading of core parsers and processors.

Is there a convenient way for me to "go the other way" and disable everything by default while only selectively enabling the features I need?
It would be great if the "feature enablement" configuration DataKey's were split into their own class so it's at least obvious what needs to be disabled if one intends to turn off a "feature".
((I've considered implementing my own DataHolder and the corresponding getOrCompute method therein to blindly return "false" on any DataKey I don't recognize.  That of course, only works for boolean keys.))
CC // @larrysteinke

@markkolich, at the moment there are no option to disable individual inline parser elements, other than a few exceptions like the delimiters, since inline parsing is implemented as one big chunk of code with many interdependencies which would be a nightmare to debug and test if some were allowed to be disabled. It would also pepper the code with additional if/else blocks making it error prone and harder to maintain.
The data keys you are interested in are all in the Parser since others are in extensions or the HtmlRenderer.  The latter works with whatever nodes are in the AST and extensions are not included by default.
If you disable everything then there is no markdown parsing left and all you have is text with ** and _ markup. It would seem to be simple enough to create a simple parser to handle these without the need for the rest of the library.
As an alternative you can either create custom node renderer that will render other special elements as their plain text content, which effectively removes their specialness out of rendered output.
A better alternative is to create a node post processor which will go through the AST and replace all inline nodes which you do not want with a Text node having the characters of the node you are replacing. This AST can then be rendered by the library renderers for HTML, DOCX or PDF.
I have not put effort into options for disabling everything because it is for limited and rare use cases. I do not want to complicate the code base more than necessary thus adding more maintenance to my plate which is not justified by special cases which can and should be addressed by custom code.

Thanks for the followup, @vsch.

which would be a nightmare to debug and test if some were allowed to be disabled. It would also pepper the code with additional if/else blocks making it error prone and harder to maintain.

Understood.

It would seem to be simple enough to create a simple parser to handle these without the need for the rest of the library.

I considered that, but given much of the initial legwork has already been done in the form of this library, I'd rather leverage as much as I can as opposed to writing & maintaining additional custom code.  I already bumped up against a need to support + for underlined text (HTML rendered using an <ins> tag), to which I've conveniently written my own UnderlineExtension:
options.set(Parser.ASTERISK_DELIMITER_PROCESSOR, true);
options.set(Parser.UNDERSCORE_DELIMITER_PROCESSOR, true);

options.set(Parser.EXTENSIONS, Arrays.asList(UnderlineExtension.create()));

This works beautifully.

If you disable everything then there is no markdown parsing left and all you have is text with ** and _ markup.

Right, I just wanted to build an options object that effectively "disables everything" to start and then subsequently enable only the parsing/processor features I need.  I wholeheartedly understand that in doing so, other Markdown syntax/features won't "render" and simply present themselves as raw tokens (>, #, etc.) in the rendered output which is, in fact, exactly what I want.  My use-case only requires support for **, _, and + (for underlined text) and nothing else — as such I want to strictly ignore other Markdown tokens.

As an alternative you can either create custom node renderer that will render other special elements as their plain text content, which effectively removes their specialness out of rendered output.

I'm going to "disable" as much as I can and leave it at that, unless your expert knowledge here strongly advises against that.
That said, is what I presented earlier sufficient to disable the "primary" parser/processor features?
options.set(Parser.BLOCK_QUOTE_PARSER, false);
options.set(Parser.FENCED_CODE_BLOCK_PARSER, false);
options.set(Parser.HEADING_PARSER, false);
options.set(Parser.HTML_BLOCK_DEEP_PARSER, false);
options.set(Parser.HTML_BLOCK_PARSER, false);
options.set(Parser.INDENTED_CODE_BLOCK_PARSER, false);
options.set(Parser.LIST_BLOCK_PARSER, false);
options.set(Parser.THEMATIC_BREAK_PARSER, false);
options.set(Parser.REFERENCE_PARAGRAPH_PRE_PROCESSOR, false);
// ... other import ones I missed?

Thanks for the help & consideration.

@markkolich, disabling the block parsers is stable and will work.
Disabling delimiters and reference paragraph pre-processor will also work. The latter will also disable rendering of all ref links and ref images which is what you want.
Wiki links are disabled by default so this is not an issue.
The real issues are with disabling link [text](url), image link ![text](url), inline code  (text in back ticks). These can be easily handled by a node post processor to replace the specific nodes with just text. I will add a code sample to the flexmark-java-samples module to show how to do that.
There are also hard line breaks (two or more spaces before an EOL in paragraphs) but these can be addressed by setting the desired rendering string for these. Default is <br> but you can put an empty string so they don't render.
Other than that you should be good to go.

I will add a code sample to the flexmark-java-samples module to show how to do that.

That would be great, thanks a ton!

@vsch thanks for the tip on the NodePostProcessor!
I was kicking the tires on it, and at least for the replacing of [foobar](http://example.com) with just foobar this seems to work:
import com.vladsch.flexmark.ast.Document;
import com.vladsch.flexmark.ast.Link;
import com.vladsch.flexmark.ast.Node;
import com.vladsch.flexmark.ast.Text;
import com.vladsch.flexmark.parser.block.NodePostProcessor;
import com.vladsch.flexmark.parser.block.NodePostProcessorFactory;
import com.vladsch.flexmark.util.NodeTracker;
import com.vladsch.flexmark.util.options.DataHolder;

public class AnchorLinkReplacerPostProcessor extends NodePostProcessor {

    public AnchorLinkReplacerPostProcessor(DataHolder options) { }

    @Override
    public void process(NodeTracker state, Node node) {
        if (node instanceof Link) {
            final Link link = (Link) node;

            final Text text = new Text(link.getText());
            final Node previous = node.getPrevious();
            if (previous != null) {
                previous.insertAfter(text);
            } else {
                final Node parent = node.getParent();
                parent.prependChild(text);
            }

            node.unlink();
            state.nodeRemoved(node);
        }
    }

    public static class Factory extends NodePostProcessorFactory {
        public Factory(DataHolder options) {
            super(false);

            addNodes(Link.class);
        }

        @Override
        public NodePostProcessor create(Document document) {
            return new AnchorLinkReplacerPostProcessor(document);
        }
    }

}

[foobar](http://example.com) -> foobar
I can extend this for the remaining cases as well.
If you'd like a PR, I'm happy to contribute my resulting example NodePostProcessor's to the flexmark-java-samples package.

@markkolich, for replacing a node you can just do link.insertAfter(text) or link.insertBefore(text) before unlinking the node. Both have the same effect since the link node is  unlinked afterwards. No need to check previous or use parent node since the node you are replacing already specifies the insertion point.
You should also do a state.nodeAdded(text) just to keep up house keeping.
Other than that it is quite easy to handle the other nodes and gives you the flexibility of replacement.

for replacing a node you can just do link.insertAfter(text) or link.insertBefore(text) before unlinking the node.

Ah, right, that's a lot botter — thanks @vsch!
Looks like I've got everything working.  Per your advice, I implemented a custom "SanitizerPostProcessor" that strips out and gracefully replaces elements of type Link, Image, and Code.  I've also got a custom UnderlineExtension wired up that adds underline (<ins>) support for tokens wrapped with +.
I'll clean this up a bit and submit a PR shortly for flexmark-java-samples.

@markkolich, I am glad you decided to kick the tires instead of waiting on me. I will add your sample when you make it available.
This can even be enhanced into a generic post-processor extension with extension options selecting which inline nodes to replace with their text content or some other part of their element's text, like you did for links. It can then be used by others to disable individual inline elements which cannot be disabled at parse time.
Thank you for persisting in the discussion to help arrive at a clean, re-usable solution which does not require chewing up the inline parser. Previous requests for a similar feature ended shortly after asking/expecting me to do the work. These tend to discourage my interest and participation. I am swamped with OSS projects, supported after work hours. I have to prioritize where I invest my effort.

@vsch, if https://github.com/vsch/flexmark-java/pull/288 looks good, feel free to close this out.  Thanks again for the help!


Email validation for user to check  whether owns that email or not

I was able to register an account with<EMAIL_ADDRESS>and we can send an email  to the user claiming an email with a magic link that has a jwt token

you already addressed this concern in your previous issue!