Add typings for module and submodules

Adds typings for the main module and submodules.

The DX of these hooks with typings feels pretty rough. Open to suggestions

Thank you for working on a PR adding typings, @stramel. I see there's already been a request for this in https://github.com/GoogleChromeLabs/react-adaptive-hooks/issues/27. I would like to keep this open to give (1) more users a chance to signal if typings are important to them and (2) more reviewers a chance to chime in on DX.

I think to fix the DX of using types, we always return unsupported as a boolean  instead of conditionally returning the value or unsupported. useSaveData already functions similarly to this.

Rebased and updated to match the hook definitions

@stramel cc @addyosmani
Once we've landed https://github.com/GoogleChromeLabs/react-adaptive-hooks/pull/44, I think we can proceed with this PR.
@stramel
Could you please check my comments?

@stramel
According to typescript handbook, they recommend publishing to the [@types organization](https://www.npmjs.com/~types) on npm rather than bundling with your npm package as long as the package is not written in Typescript.

Thank you for taking the time to work on typings support for the module and submodules, @stramel. I also appreciate the review here, @anton-karlovskiy.
My personal take is that given the package is not written in TypeScript and we have no short-mid term plans to rewrite it in TS for now, it would make more sense for typings to be published in the @types organization rather than bundling it with this package.
@stramel I think this is a reasonable compromise as it unlocks typings for users that want it. Wdyt?

@addyosmani I can do that

Cool. Thank you! With this in mind, I'm going to go ahead and close this PR. Let's follow up with a PR adding a link/note in the README to the typings package once it lands in the types organization? :)

Added a draft PR for the typings. I need to clean up the typings and add tests.
Is there anyone who would want to help maintain these types?
@addyosmani @anton-karlovskiy


Pact resume server (review-only PR)

This is to allow ongoing review of Linda's work on resume

@slpopejoy this is ready for review/merge. Is it supposed to be passing the CI builds?

Travis CI are supposed to pass yet. It would appear the new regression tests are not terminating.
Also, you should look at the logging config for the tests to suppress logging, they're blowing up the test output.

@slpopejoy the Travis CI are passing


Replace english content with slovakian in package/README file

https://github.com/slovensko-digital/navody-frontend/blob/master/package/README.md still contains content from the forked govuk-frontend project.
As this folder is packaged for NPM, the content appears on https://www.npmjs.com/package/navody-digital-frontend
You might want to change that, so that your users don't get confused.

@kr8n3r Thanks for the heads-up! I've updated the README file to link to our repo/github/etc.


chore: bdd-sbhg-import-1592925695 to 0.0.1

chore: Promote bdd-sbhg-import-1592925695 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Store confidence level when even when hmean < 2/3

What is the expected behavior?
A comment from @oliverdial in private communication: Is there a reason to not also store the confidence interval if hmean < 2/3?  It’s still well defined, as there’s a probability that the average HOP < 2/3 but the actual is greater (thinking mostly about the first couple circuits here) ..  It’s a really minor point, but might help w/ figures like the one in the QV paper (QV64 paper figure 2a)

closing since some of it was done in #482, and the plots will be handled by @HuangJunye in as part of #213 and #224.


MINOR: [Dev] Remove Dane from collaborators list

Rationale for this change
Dane is a new committer.
What changes are included in this PR?
Remove the collaborator list.
Are these changes tested?
Not required.
Are there any user-facing changes?
No

Thanks, Raul! Great idea ;)

🎉

@raulcd How can I regain access to github actions? https://github.com/apache/arrow/pull/42113#issuecomment-2161733022

You have to make your apache org status public, it's hidden by default: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/publicizing-or-hiding-organization-membership

Thank you!!


Support probing MIPS64 n64 targets

Another step towards #814. This is relatively easy, whew.

Thanks!


Images not rendering from URL when source is HTML string

Bug description:
Images from URLs not loading when trying to set HTML string in the "source". The IMG tag is not loading when src is set to URL but works with base64. Also, images set as "background-image" aren't loading.
Here is my HTML string: link
Here is my function to render the webview:
`const render_webview = (htmlSource) => {
const insert_img_style = "
setTimeout(() => {
var sheet = document.createElement('style');
sheet.innerHTML = ".image_resized { width: ${fullWidth}px !important; height: auto !important; object-fit: contain !important;} img { width: ${fullWidth}px !important; height: auto !important; object-fit: contain !important;}";
document.body.appendChild(sheet);
}, 500);"
return (
  <WebView
    ref={webviewRef}
    style={{ marginTop: 20 }}
    source={{
      html: htmlSource,
    }}
    originWhitelist={["*"]}
    javaScriptEnabled
    injectedJavaScript={insert_img_style}
    domStorageEnabled
    allowFileAccessFromFileURLs
    allowUniversalAccessFromFileURLs
    startInLoadingState
    mixedContentMode="compatibility"
    ignoreSslError
    onNavigationStateChange={handleWebViewNavigationStateChange}
  />
);

};`
Expected behavior:
Images should be loaded from the URL like the one below.

Screenshots/Videos:
But the images are not loaded.

Environment:

OS: IOS
OS version: 10.14.6 Mojave
react-native version: 0.60.5
react-native-webview version: 6.9.0

same issue facing any solution on it ?

anyone?


Unicode support

The functions btoa and atob used for the encoding to get the link don't support unicode, which is a pity since MathJax does 😅
Here is a fix (tested locally, it works like a charm) which supports unicode.

Interesting... I didn't know atob and btoa do not support UTF-8. Thank you very much for the pull request!


Kubernetes and Consul Integration question

Hello,
I am using Ocelot as an API gateway in AKS with Consul deployed inside the cluster for service discovery. I am using connect sidecar injection with ACL tokens for my pods. So my question is how to best integrate Ocelot with Consul in this scenario. This issue references what I am trying to do but doesn't lay out a preferred route. I see three potential solutions.

Annotate the ocelot pod for connect injection and provide the list of required services to the connect-service-upstreams. This would create localhost bindings for each service and then I would use Ocelots normal configuration (without consul integration)

{
    "DownstreamPathTemplate": "/api/posts/{postId}",
    "DownstreamScheme": "https",
    "DownstreamHostAndPorts": [
            {
                "Host": "<IP_ADDRESS>",
                "Port": {servicePortConfiguredInUpstreams},
            }
        ],
    "UpstreamPathTemplate": "/posts/{postId}",
    "UpstreamHttpMethod": [ "Put", "Delete" ]
}

Don't use connect inject on the Ocelot pod, use the Consul integration as defined in the configuration

"ServiceDiscoveryProvider": {
 "Host": "consul",
 "Port": 8500,
 "Token": "{aclToken}",
 "Namespace": "{consulns}"
}

Use connect inject and the consul integration. In this scenario connect-inject is setup, but the service being injected is the consul service.

{
      "DownstreamPathTemplate": "/api/{everything}",
      "DownstreamScheme": "http",
      "ServiceName": "{requestedService}",
      "UpstreamPathTemplate": "/api/c/{everything}",
      "UpstreamHttpMethod": [],
      "AuthenticationOptions": {
        "AuthenticationProviderKey": "IdentityApiKey",
        "AllowedScopes": []
      }

"ServiceDiscoveryProvider": {
      "Host": "<IP_ADDRESS>",
      "Port": 8500,
      "Token": "{aclToken}",
      "Type": "Consul"
    }

Of the three I think I prefer the first option as it allows consul to manage it's ACL tokens, but is there a recommended best practice for this scenario?
Thanks!

Hi @csnance !
Thanks for your interest in Ocelot!
I know my feedback is a bit late after these long 4 yesrs of your waiting...
To understand the correctness of your Consul provider configurations you need to have Ocelot logs.
I hope attached PR 1366 will help you totake your solution to the next level.
Let me know if you have any further questions!

@csnance Let me know if your question is still actual.


Optional use of Jekyll templates for samples

R: @addyosmani @ebidel @PaulKinlan all
This modifies the recommended starting template to use a Jekyll-based template which takes care of most of the boilerplate.
Existing samples can stay as-is, since Jekyll will serve any page without frontmatter verbatim. (At some point, it would be nice to go back and update the ones that can be migrated easily.)
I've migrated a couple of samples over to the new template-based approach to illustrate the process:

https://github.com/jeffposnick/samples/blob/gh-pages/report-validity/index.html (live version)
https://github.com/jeffposnick/samples/blob/gh-pages/image-rendering-pixelated/index.html (live version)

One of the benefits of using the new templates is that we can easily show the relevant CSS/JS/HTML inline in the page with syntax highlighting in addition to using it in the source, which you can see in action in the live versions linked to above.
This also simplifies the master styles, removing some that were never used.
This closes #84

Is there any plan to add an index page for this?

The index page is being tracked in #37 and this PR doesn't address that.
I'm actually not sure whether putting together a full index page here makes the most sense vs. creating a new samples-focused page hosted on chromestatus.com. The advantage of hosting it on chromestatus.com is that it could use of all the metadata that we have about each feature (the category, the chrome release version, etc.) and of the App Engine datastore's ability to filter and search for entries. That might lead to a richer user experience than anything static we could host here.
Anyway, we can discuss more in #37 and potentially in a new issue in https://github.com/GoogleChrome/chromium-dashboard

Reviewed


Better dialogue system with localization

Current Popochiu dialogue system is pretty limited. The goal is to introduce a more complete and full-featured one, with the following features:

Good localization support, ideally based on GetText and po files which are industry standard and allow translators to use serious tools like POEdit instead of spreadsheets. CSVs are still a nice addition, tho.
Not limited to dialogues: starting a dialogue should allow the dev to just fire a complete, full-featured Popochiu script, allowing for everything from state changes, to cutscenes, to animations. Declarative dialogues are easy to jot down but very limited in scope.
Smooth integration with the GUI subsystem, allowing the devs to customize dialogue interactions the way they see fit, for example using icons instead of text for dialogue navigation (much like Sam&Max Hit the Road) or inventing new patterns. Ideally the dialogue system should be unopinionated about how a dialogue script is triggered or shown to the user.
Strong decoupling from other engine featues, so that there are no strict dependencies in the engine.

There are two good inspirations to draw from:
Dialogue Manager 2.0 addon
Pros:

based on an easy-to-understand DSL, with specific, well-integrated file format
built-in localization support (both CSV and PO)
less than 2000 lines of code and very well integrated with the editor
may be more than an inspiration for just the dialogue system and inspire a full Popochiu scripting interpreter (I may regret writing this :smile: )

Cons:

there are overlaps with game scripting that may end up distributing code between dialogs and other parts of the game scripts
a bit too opinionated
partly declarative, partly "touring-complete" approach
lacking dependency management, using it directly in Popochiu is impossible, we should rewrite our version of it

PowerQuest dialogue system
Pros:

Very loosely coupled with other framework systems, it's basically just a very convenient way to catalog lines or icons that trigger game scripts in a dedicated GUI
Powerful API allowing for inline dialogs, return values to branch script execution, catalogs inspection and more
Good editor UI to manage dialogues catalogs

Cons:

Localization (as a whole) is working but "fragile", based on source files scraping (it got better over time and I consider it stable ATM)
Localization doens't support multiple languages voiceover
Localization does not use uuids for strings, makes it hard to re-process the whole game in various phases, making it easier to introduce error without spotting them
Editor UI is easy but a bit cumbersome. It may be a pain for large games and it's not an option (Unity prefab, you can edit YAML yourself but at your own risk - :skull_and_crossbones: )

What are dialogue catalogs and catalogs inspection?

This issue must be split in two separate parts: localization is a broader topic than dialogs.

Maybe a duplicate of #42 ; I'll check and close if it's the case.

Everything mentioned in this issue is already done. An issue to improve the UX of dialog items is already filed (#260) as well as one for the localization support (#40)
Closing this epic


Implementing the state persistence

My goal is to allow more than single data model and abstract them out. For someone who has wallet db from GRIN++ could just use it directly. Someone else might want to have a hot wallet with MySQL storage. I am also considering the core wallet files support.


Whole sentence visualization in Fig.4 and Fig10

Hello！ I want to produce Grad-CAM visualizations for Whole sentence.
I have change  ---->Compute GradCAM as follow:
with torch.no_grad():
mask = text_input.attention_mask.view(text_input.attention_mask.size(0),1,-1,1,1)
  grads = model.text_encoder.base_model.base_model.encoder.layer[block_num].crossattention.self.get_attn_gradients().detach()
  cams = model.text_encoder.base_model.base_model.encoder.layer[block_num].crossattention.self.get_attention_map().detach()

  cams = cams[:, :, :, 1:].reshape(image.size(0), 12, -1, 24, 24) * mask
  grads = grads[:, :, :, 1:].clamp(min=0).reshape(image.size(0), 12, -1, 24, 24) * mask

  gradcam = cams * grads
  gradcam = gradcam.mean(1).mean(1)

How to get the Visualize GradCam for Whole sentence?
Could you give me full code of Visualize GradCam for Whole sentence? (I do not similar to GradCam)

To obtain the gradcam for a sentence, we simply average the gradcams across all text tokens

Thanks!

Hi! Have you considered or empirically tested if the CLS token works as well for whole sentence visualization?


fix the BlockEvent deserialization

The serialization function is currently incorrect, since the Decode in SerializedBlock expects a cbor tag to be there, but it's not part of the buffer itself. It's only included when calling Encode. Since SerializedBlock doesn't have a public constructor, this is the more direct way.
Also, for some reason serde_json seems to be calling visit_seq instead of visit_bytes, so I added that method to the visitor.
We will probably remove the storage from the multiverse later, but in the meantime, this prevents restarting.

we still need a test :)
good way to overcome the custom serde stuff

a test of what though? testing the derive doesn't really make sense.
you mean a test of BlockEvent::from_serialized_block?


Changes for the week of May 27

don't treat [xxx][xxx] as a bookmark in code blocks `xxx`

Approved on the 5/30 call


[WFRP4e System] Chaos star still missing in Firefox

Sorry but this is still missing. Latest versions of VTT, WFRP 4e and Firefox installed.From: .turnstarfoundry: 11.308wfrp4e: 7.0.1wfrp4e-up-in-arms: 4.0.0Active Modules: dice-so-nice, foundryvtt-simple-calendar, lib-wrapper, mythic-gme-tools, party-overview, pings, popout, settings-extender, tabletop-rpg-music, torch, forge-vtt

Works for me on FF and self-hosted Foundry:

For me also working

Closing this as I won't pursue a fix (if one is still needed)


Feature: add two tools in barchart toolbox (table view and latex view)

Related to #426 UI Optimization Plan

It would be nice if statistics existing in these histograms could be exported.

New Feature
This PR adds two tools in the bar chart toolbox.

barchart in Tex format
table view

These two buttons will open up LatexViewModal and TableViewModal respectively. Screenshots are shown below.
Screenshot of  LatexViewModal and TableViewModal

Comments
In LaTex, I added legend style={at={(0.5,-0.2)},anchor=north,legend cell align=left}, to place the legend at the bottom. I also added the following lines to remove the second bar in legend. The screenshots of the before and after are shown below. The after screenshot is also the compiled graph you would see in latex.
\pgfplotsset{
    legend image code/.code={
        \draw [#1] (0cm,-0.1cm) rectangle (0.6cm,0.1cm);
    },
}

@noelchen90 Hi, just a quick comment: could we also make this table exportable as a file such as excel? The reason is sometimes users must want to get the table data, and they will draw based on it using tools they are familiar with.

After an offline discussion with @lyuyangh, we decided to roll back to "text" for the codeblock. The Unhandled Rejection (Error): Language tex not supported error that pops up during dev also pops up in production. And it also doesn't show any syntax highlighting in production as well.
react-code-blocks seems like a loosely maintained repo, with a lot of similar opened issues. We may need to find another package that supports latex + python syntax highlighting in the future.

@lyuyangh Hmm, I don't see that error from my end. I added rowKey for each item in my data source after your previous recommendations, I thought that already solved the problem. Have you pulled my latest commits?
https://github.com/neulab/explainaboard_web/blob/feat/export-latex/frontend/src/components/Analysis/BarChart/TableViewModal.tsx#L54


runtime: fatal error: timer data corruption

#!watchflakes
post <- pkg == "runtime && log ~ `fatal error: timer data corruption`

Existing failure from https://github.com/golang/go/issues/55308#issuecomment-1536774114: https://build.golang.org/log/83ab44e57523849b0c1ce7a9c63644943c54fbfd
fatal error: timer data corruption

runtime stack:
runtime.throw({0xa4296a?, 0x0?})
	/workdir/go/src/runtime/panic.go:1077 +0x5c fp=0x7f531fffeb78 sp=0x7f531fffeb48 pc=0x47169c
runtime.badTimer()
	/workdir/go/src/runtime/time.go:1143 +0x1f fp=0x7f531fffeb98 sp=0x7f531fffeb78 pc=0x495b3f
runtime.siftdownTimer({0xc0001ca100, 0x10, 0x0?}, 0x0)
	/workdir/go/src/runtime/time.go:1102 +0x65 fp=0x7f531fffebc0 sp=0x7f531fffeb98 pc=0x495945
runtime.dodeltimer0(0xc000038500)
	/workdir/go/src/runtime/time.go:426 +0xe6 fp=0x7f531fffebf0 sp=0x7f531fffebc0 pc=0x4940c6
runtime.runtimer(0xc000038500, 0x1c9cea19f9)
	/workdir/go/src/runtime/time.go:813 +0x177 fp=0x7f531fffec20 sp=0x7f531fffebf0 pc=0x494f57
runtime.checkTimers(0xc000038500, 0x7a?)
	/workdir/go/src/runtime/proc.go:3475 +0x11b fp=0x7f531fffec68 sp=0x7f531fffec20 pc=0x47a9bb
runtime.stealWork(0xc000036000?)
	/workdir/go/src/runtime/proc.go:3087 +0x1b2 fp=0x7f531fffece8 sp=0x7f531fffec68 pc=0x479d32
runtime.findRunnable()
	/workdir/go/src/runtime/proc.go:2796 +0x32a fp=0x7f531fffedf0 sp=0x7f531fffece8 pc=0x47920a
runtime.schedule()
	/workdir/go/src/runtime/proc.go:3376 +0xb1 fp=0x7f531fffee28 sp=0x7f531fffedf0 pc=0x47a6f1
runtime.goexit0(0xc000505a00)
	/workdir/go/src/runtime/proc.go:3703 +0x266 fp=0x7f531fffee68 sp=0x7f531fffee28 pc=0x47b606
runtime.mcall()
	/workdir/go/src/runtime/asm_amd64.s:458 +0x4e fp=0x7f531fffee80 sp=0x7f531fffee68 pc=0x4af98e

One more result from greplogs. Failing in approximately the same place:
2023-04-18T15:42:18-56c4422/freebsd-amd64-race

In triage, we'll wait for more failures.

In triage, we'll wait for more failures.

Note that you have to add the issue to the Test Flakes project for watchflakes to triage it. 😅

This trybot failure is very likely to be the same root cause: https://storage.googleapis.com/go-build-log/345b5fc2/linux-amd64-race_40fbb72b.log. It's in the same benchmark as the other failures, and it's much more likely the timer.pp got stomped than runtimer moved to another P.

Note that commit 095cfba8 is on release-branch.go1.20 (#59483). This was fixed in 1.21?
(Would it make sense to backport the fix?)

`fatal error: timer data corruption
runtime stack:
runtime.throw({0x7ff6b52f0949?, 0x0?})
D:/Go/go/src/runtime/panic.go:1077 +0x65 fp=0x66ac7ff408 sp=0x66ac7ff3d8 pc=0x7ff6b47541e5
runtime.badTimer()
D:/Go/go/src/runtime/time.go:1143 +0x1f fp=0x66ac7ff428 sp=0x66ac7ff408 pc=0x7ff6b4775c7f
runtime.siftupTimer({0xc000046f40, 0x4, 0x66ac7ff498?}, 0x3)
D:/Go/go/src/runtime/time.go:1076 +0x65 fp=0x66ac7ff450 sp=0x66ac7ff428 pc=0x7ff6b4775925
runtime.doaddtimer(0xc00004ca00, 0xc00007c910)
D:/Go/go/src/runtime/time.go:303 +0x125 fp=0x66ac7ff4a8 sp=0x66ac7ff450 pc=0x7ff6b4773d05
runtime.runtimer(0xc00004ca00, 0x167f4db2cb8)
D:/Go/go/src/runtime/time.go:814 +0x1ae fp=0x66ac7ff4e0 sp=0x66ac7ff4a8 pc=0x7ff6b47750ee
runtime.checkTimers(0xc00004ca00, 0x0)
D:/Go/go/src/runtime/proc.go:3693 +0x15f fp=0x66ac7ff538 sp=0x66ac7ff4e0 pc=0x7ff6b475ce5f
runtime.stealWork(0x0)
D:/Go/go/src/runtime/proc.go:3293 +0x1e6 fp=0x66ac7ff5b8 sp=0x66ac7ff538 pc=0x7ff6b475c1c6
runtime.findRunnable()
D:/Go/go/src/runtime/proc.go:2999 +0x2fc fp=0x66ac7ff6d8 sp=0x66ac7ff5b8 pc=0x7ff6b475b6bc
runtime.schedule()
D:/Go/go/src/runtime/proc.go:3582 +0xbd fp=0x66ac7ff710 sp=0x66ac7ff6d8 pc=0x7ff6b475cafd
runtime.park_m(0xc000084540?)
D:/Go/go/src/runtime/proc.go:3745 +0x105 fp=0x66ac7ff740 sp=0x66ac7ff710 pc=0x7ff6b475d065
traceback: unexpected SPWRITE function runtime.mcall
runtime.mcall()
D:/Go/go/src/runtime/asm_amd64.s:458 +0x53 fp=0x66ac7ff758 sp=0x66ac7ff740 pc=0x7ff6b4785473`

go version go1.21.5 windows/amd64：Error with go thread stack extension

Another Go 1.21.5 crash: https://github.com/minio/minio/issues/19531 - amd64, linux. See issue for trace.
I can't guarantee this isn't a timer race. But adding it here in case it helps.


Grafana dashboard shows wrong panels

For some reason the performance dashboard is malformed. It seems grafana reads the panel JSON, then modifies it which breaks it. Specifically, the cpu/1k req is gone, and there is a big gap where the panel should be. See https://snapshot.raintank.io/dashboard/snapshot/VHHseSJlZMDRgh89xppQIotff0T9CL98?orgId=2

Fixed in https://github.com/istio/istio/issues/14163


Can't save snps object generated from VCF

Hi,
I am trying to read and output a VCF file using the SNPs library. I would like to do this to check that the VCF is valid and remap if the file is not from the GRCh37 reference genome.
However, I am getting the error: no data to save... when I try and save the my SNPs object to a file.
To replicate issue
Download data:
# download small VCF data
wget https://lifebit-featured-datasets.s3-eu-west-1.amazonaws.com/modules/beagle5/test/subsampled/FR07961001.pass.recode.subsampled.vcf.gz
gzip -d FR07961001.pass.recode.subsampled.vcf.gz

Run SNPs:
from snps import SNPs
import logging, sys

# for logging
logger = logging.getLogger()
logger.setLevel(logging.INFO)
logger.addHandler(logging.StreamHandler(sys.stdout))

input_file = 'FR07961001.pass.recode.subsampled.vcf'
snps = SNPs(input_file)
snps.save_snps()

Output:
no data to save...
The snps object does seem to be empty:
df = snps.snps
df.columns.values
# array(['chrom', 'pos', 'genotype'], dtype=object)
len(df)
# 0

However, I also tried reading the input VCF line by line with SNPs using the following:
with open(input_file, 'r') as f:
  snps = SNPs(f.read().encode('utf-8'))

And then when I outputted this object it seemed to have the data:

But I'm not sure if there are any issues with reading the format of the VCF:

Any ideas what might be going wrong. Any help would be much appreciated.
Many thanks in advance,
Phil

Hi @PhilPalmer - I've investigated this and it seems that the VCF you have linked to is unannotated (nothing in the IDs column) so the snps package is unable to create retrieve any rsids from the file. You'll need to annotate this file before loading it into snps. We could potentially have some better logging so that it is clearer that this is what is going on!

In your case, to find out what rsids are available in the snps object, you can use snps.snps.

Okay, that's easy to fix. Thanks @willgdjones for the prompt reply!


Midea's "Inventor" brand de-humidifier additional controls missing (if supported)

Hello @hillaliy first of all, warm thanks for your great work. It was very hard to trace a device-controlling solution to you as I could not find the the appliance maker INVENTOR (www.inventor.ac) was part of MIDEA solutions and services...
So I am using latest Homebridge on an OpenMediaVault small sever (via Docker) I added your main plugin (just published, v1.6.10) via its Search interface and then added my Inventor iOS application credentials that were accepted, to my great surprise.
I selected (as part of testing) to use the "MideaAir" application in Settings and later, created a "child bridge" as Homebridge prompted me to do.
Reference: https://www.inventorairconditioner.com/dehumidifiers/eva-ii-pro-wi-fi-evp-wf
Model: Eva II Pro (EVP-WF20L) Dehumidifier with Wi-Fi
a) Is a child bridge necessary? If not, perhaps you could kindly consider to mention it in the first page README.md? Should I remove everything and re-install without a child-bridge?
b) When I saved and restarted HomeBridge (as needed) my "Inventor" account was accepted and was logged in and I was surprised to see that my appliance was also detected, including my assigned appliance name! Well done:
[11/13/2022, 11:46:34 AM] Homebridge v1.5.1 (HAP v0.10.4) (Homebridge Server) is running on port 53307
[11/13/2022, 11:46:34 AM] [homebridge-midea-air] Launched child bridge with PID 1351
[11/13/2022, 11:46:35 AM] Registering platform 'homebridge-midea-air.midea-air'
[11/13/2022, 11:46:35 AM] [homebridge-midea-air] Loaded homebridge-midea-air v1.6.10 child bridge successfully
[11/13/2022, 11:46:35 AM] Homebridge v1.5.1 (HAP v0.10.4) (homebridge-midea-air) is running on port 59342
[11/13/2022, 11:46:36 AM] [homebridge-midea-air] Created device: Eva II Pro, with ID: XXXXXXXXXXXXXX, and type: 161

(the ID I have obviously obfuscated, above)
On the devices list, the config icon shows the following and when long-pressing the tile, I get some options (that are not really related, i.e. the device is only a dehumidifier and does not have a humidifier function (perhaps the orange button does nothing?)
At the moment, the only thing that can be done, is to turn ON/OFF and see the reported humidity level (with some delay, compared to the device display, next to me).

Is there a way by providing some logs or tweaking the MideaAir config (that seems added successfully) to be able to control dehumidification modes, or fan speeds, or Ioniser ON/OFF etc.?
Or can I  provide specific logs to check with you whether the appliance does allow more to be controller, via your great plugin? Please kindly point me to the right direction, and I will try getting the log(s) necessary.
Many  thanks again.
P.S. What is the purpose of parameter "supportedSwingMode": "both" ? For A/C devices that "swing"? What are other options that I can manually set for this parameter as the appliance doesn't have any swings? Thanks!
P.S. How could I increase the responsiveness between the appliance-reported humidity and Homebridge UI?

Hi it's very difficult to fix all the problems. There are many models and Midea use an old and new protocol.
Also I don't have a dehumidifier to make tests.
If You can give me access to your device I could try to make some adjustments

Hi @hillaliy thanks for replying.
A small request for text-label correction: Please on the report page above, do change the type label to Humidifer-Dehumidifier with a dash between the two types, so that people can understand a little better (like me 😄 )
How do I give you temporary access to my device? Via the Homebridge UI itself? Or provide the login credentials to the application?
Thanks.

About the label it's Homebridge label. Can't change it.
If you can send me your credentials.
My Discord user: Yossi#1563

Request to connect, sent. Many thanks

Fix on version 1.7.0


johndanz/ch14586/add-filter-and-sort-to-markets-list-page

https://app.clubhouse.io/augur/story/14586/add-filter-and-sort-to-markets-list-page

no markets come up I get this error on mainnet


Only validate changed fields

Say I have a user model like this:
class User {
	public static $rules = [
		'email'			=> 'sometimes|required|unique:users,email|email',
		'firstname' 		=> 'sometimes|required|min:1',
		'lastname' 		=> 'sometimes|required|min:1',
	];

}

The user is already saved in database, but without e-mail, firstname, or lastname.
The user wish to update ONLY his e-mail. When he sends the request, only containing an e-mail field, the validation will fail, because he did not provide an firstname and lastname.
How can I avoid that? I.e. only validate the fields that are sent in the request; so if firstname is not sent, Ardent will not validate it, and instead only validate the fields that are present.

My current workaround
/**
 * Only validate the changed fields
 * @return [type] [description]
 */

	public function validateChangedFields() {

		$rules = [];

	    foreach($this->getDirty() as $attribute => $value){
	        $original= $this->getOriginal($attribute);
	        //echo "Changed $attribute from '$original' to '$value'<br/>\r\n";

	        $rules[$attribute] = static::$rules[$attribute];
	    }

	    return $this->validate($rules);
	}


v0.5.0 error: Not Found for every command

With version 0.5.0 I cannot execute any commands other than ping, has there been some change to how I need to call it?
Tested with kong versions 1.1.2 and 1.2

Duplicate issue: https://github.com/hbagdi/deck/issues/59


[3.x] Overhaul the theme editor and improve user experience

Backport of #49388 (including #49772). ~Depends on #49512 being merged first.~ Rebased following the merge.
It's the same except for the part about picking custom theme types from controls, as they don't exist in 3.x and cannot be backported to 3.x without breaking compatibility somewhat (see #47544). If at a future point we decide to backport #47544 in some form, this functionality can be easily restored by changing one line of code.

Thanks!


Extract rar with password does not work

In my app I need to Extract rar with password but I cant find any thing in google help me.

I tried like that here https://github.com/adamhathcock/sharpcompress/issues/25
but I got error in RarArchive.Open that say
**Error	2	No overload for method 'Open' takes '3' arguments	C:\Users\hamza\Documents\Visual Studio 2008\Projects\TryToUnRarfiFles\TryToUnRarfiFles\Form1.cs	40	38	TryToUnRarfiFles
**
-And I tried like that here https://github.com/adamhathcock/sharpcompress/issues/213
but I got error again in  --new ReaderOptions()--  and said
Error	2	The type or namespace name 'ReaderOptions' could not be found (are you missing a using directive or an assembly reference?)	C:\Users\hamza\Documents\Visual Studio 2008\Projects\TryToUnRarfiFles\TryToUnRarfiFles\Form1.cs	130	64	TryToUnRarfiFles
...
Please if any one can help me ...

Did you try looking at the options or tests instead of copy/pasting other things?
You're likely looking at old samples as the API surface changed

Yes I think that. but I need any way to Extract rar with password may you help..

Just look at the tests.  Dig a little.
https://github.com/adamhathcock/sharpcompress/blob/master/test/SharpCompress.Test/Rar/RarArchiveTests.cs#L16


allow for haml like data: {tag1: "foo", tag2: "bar"} syntax

From @catmando on December 11, 2015 21:46
current you have to write
div "data-tag1" => "foo", "data-tag2" => "bar", "arial-labeledby" => "file-menu"
instead it seems natural to say
div data: {tag1: :foo, tag2: :bar}, arial_labeledby: file_menu similar to haml.
Copied from original issue: zetachang/react.rb#99

From @catmando on December 21, 2015 17:10
yes no problem

From @ajjahn on December 21, 2015 15:55
@catmando are you able to take a stab at this?


Make Possible to Exp show up as a token bar

In GitLab by @brunocalado on Mar 16, 2021, 08:38
Make Possible to Exp show up as a token bar

In GitLab by @Asacolips on Apr 4, 2021, 03:21
Resolved in 0.7.0


update AssemblyScript & as-pecr. Fix string comparisions

[x] use == instead === for string comparison. See docs
[x] some refactoring for better readability
[x] remove some duplicate flags during setup fd_rights in FileSystem.open
[x] add yarn.lock

Thank you Max!
(Not a big fan of while(true) though. It’s too long)


Fix parameter names for RSA private key example

While using the param builder functionality i noticed that the examples for importing a RSA private key did not work.
This PR changes the parameter names in the example to match the ones in https://github.com/openssl/openssl/blob/master/include/openssl/core_names.h#L359
Checklist

[x] documentation is added or updated

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

I now realized you've used CLA: trivial to submit this PR. Although this might be really uncopyrightable we have quite strict requirements on what is acceptable with CLA: trivial and this seems to me to be outside the limits. Would you please consider submitting a CLA?

@mattcaswell what do you think?

Personally I would be ok with this as a trivial change since it seems "obvious". But its probably border line.

If its a problem Im fine submitting a CLA.

If its a problem Im fine submitting a CLA.

Please submit it.

The CLA was submitted and got a reply that it's now added to the CLA database. The instructions said that i needed to close and reopen the PR but seems that force pushing the FT (with the cla: trivial comment removed) also did the trick, or?

but seems that force pushing the branch (with the cla: trivial comment removed) also did the trick, or?

yes, that works too

@mattcaswell please re-approve

This pull request is ready to merge

Merged to master, 3.0, and 3.1 branches. Thank you for your contribution.


[request] make link previews in tweets optional

hi again,
as already stated here, i would kindly like to ask if it is possible to have link previews in tweets optional as it would safe bandwidth and as they are mostly visually huge compared to the initial tweet content itself, it could let someone be more focused without them. well, hopefully.
if you are already tired of me, feel free to close (:
thanks.

for comparsion reasons pictures attached.
v3.1.0 clean feed here
v3.1.6 link previews feed here

Version 3.1.7 has changed the Leaner feeds option from not displaying quotes to not displaying preview links.
To test it, first be sure that the option is activated, then don't forget to flush the cache of the main feed or your group by scrolling down the feed from the top.

that was quick. work of art. its perfect. thanks a lot. superb support.


pairotbed -type both output

Hi, this question here explains the issue I wanted to report: https://www.biostars.org/p/203415/
Basically, output of pairtobed -type both includes the columns from the -b file (this doesn't happen with -type neither or -type notboth, haven't tested other options).

I have the similar issue where -type both reported results that are supposed to be in -type either. Is there a bug or fix to this?
I used v2.28.0 and v2.17.0. They all have the same issue.

The both option simply requires that both sides of the pair overlap 1 or more records in the BED file, not the same record. I could look into a new option called "bothsame" which requires that both ends of the A record overlap the same B record.  Also, changing the output of "both" to report the cartesian product of the matches would allow you to easily filter for the type of record you want.

@arq5x I see. Thanks for your reply!
I think it would be great to have the "bothsame" option.

I will work on implementing this for either the next release or the release after that.


[Bug] Adding exports section to Saved query causing parse failure

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
In some cases, adding an exports section to an existing saved query definition would cause parsing to fail with error
Compilation Error
  'dbt.artifacts.resources.v1.saved_query.Export object' has no attribute 'unrendered_config'

Two things making this a tricky bug:

We can not reproduce this using the example project https://github.com/dbt-labs/jaffle-sl-template.
The traceback is swallowed so we do not know where this happening.

Community thread: https://getdbt.slack.com/archives/C046L0VTVR6/p1719218667823979
Expected Behavior

dbt parse would work all the time when correct exports being defined.
dbt does not swallow traceback with certain flag enabled, so we can trouble shoot problems easier.

Steps To Reproduce
I can not reproduce this right now
Relevant log output
No response
Environment
- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?
No response
Additional Context
No response

Thanks for trying all of that @rasmushemph!
If you start with an empty dbt project and add the minimal number of metrics, etc to the project, do you still get this error?

I now removed pretty much everything  in my project and still had the problem with only one staging model so figure the problem was on my side... Finally found this macro running silently in the background. We added it a while back to override the schema-name for dev runs but now apparently fails for this node type that does not have a unrendered_config..
I changed the if-logic a little bit and I hope that should clear it out. If you have a better suggestion please let me know.
Thanks for the kind help again!
ORIGINAL
{% macro generate_alias_name(custom_alias_name=none, node=none) -%}
{# Code adapted from https://github.com/dbt-labs/dbt-bigquery/issues/1038 /rmh #}
    {%- if custom_alias_name is none -%}
        {%- set table_name = node.name -%}
    {%- else -%}
        {%- set table_name = custom_alias_name | trim -%}
    {%- endif -%}

    {%- if target.name != 'prod' -%}
        {#- Get the custom schema name -#}
        {%- if node.resource_type == 'snapshot' -%}
            {%- set schema_prefix = 'artifacts' -%}
        {%- else -%}
            {%- set schema_prefix = node.unrendered_config.schema | trim -%}
        {%- endif -%}
        {#- Highlight if schema hasn't been assigned right -#}
        {%- if not schema_prefix -%}
            {%- set schema_prefix = 'NO_ASSIGNED_SCHEMA' %}
        {%- endif -%}
        {{ schema_prefix ~ "__" ~ table_name }}
    {%- else -%}
        {{ table_name }}
    {%- endif -%}
{%- endmacro %}

NEW:
```yml
{% macro generate_alias_name(custom_alias_name=none, node=none) -%}
{# Code adapted from https://github.com/dbt-labs/dbt-bigquery/issues/1038 /rmh #}
    {%- if custom_alias_name is none -%}
        {%- set table_name = node.name -%}
    {%- else -%}
        {%- set table_name = custom_alias_name | trim -%}
    {%- endif -%}

    {%- if target.name != 'prod' -%}
        {#- Get the custom schema name -#}
        {%- if node.resource_type == 'snapshot' -%}
            {%- set schema_prefix = 'artifacts' -%}
        {%- elif node.resource_type  in ('model','source') -%}
            {%- set schema_prefix = node.unrendered_config.schema | trim -%}
        {%- endif -%}
        {#- Highlight if schema hasn't been assigned right -#}
        {%- if not schema_prefix -%}
            {%- set schema_prefix = 'NO_ASSIGNED_SCHEMA' %}
        {%- endif -%}
        {{ schema_prefix ~ "__" ~ table_name }}
    {%- else -%}
        {{ table_name }}
    {%- endif -%}
{%- endmacro %}

You're welcome @rasmushemph !
Glad that you were able to isolate it to your generate_alias_name macro -- you should be able to modify that macro as-needed until the error message goes away.
raise_compiler_error can also be handy If there's particular edge(s) you want to catch and raise an exception for (like where you are doing the NO_ASSIGNED_SCHEMA part).
Since it looks like we've found the root cause, I'm going to close this issue -- just let me know if that's not the case and we can re-open.


change local server file path

i'm wondring whether the file path that bot creates on the local server can be changed before download the file or not?
For example, can I transfer a file to a subdomain before download it?

The path can't be changed. Between what do you mean by "transfer a file to a subdomain"? Bot API server has nothing to do with domains.

Any way to use an R2 cloudflare bucket as the file store?


Invoke-Build doesn't  work when nuget.exe is absent

Invoke-WebRequest http://nuget.org/nuget.exe -OutFile $nugetExe

this code get nuget 2.8 but not latest.
Additionally
First call failed with "I want nuget 2.12+"
But next fail at complation stage because it want System.Runtime.InteropServices.RuntimeInformation.4.3.0

solution:
diff --git a/PSReadLine.build.ps1 b/PSReadLine.build.ps1
index 8f5db1f..685b790 100644
--- a/PSReadLine.build.ps1
+++ b/PSReadLine.build.ps1
@@ -35,7 +35,7 @@ task CheckNugetInstalled `
         $script:nugetExe = "${env:TEMP}/nuget.exe"
         if (!(Test-Path $nugetExe))
         {
-            Invoke-WebRequest http://nuget.org/nuget.exe -OutFile $nugetExe
+            Invoke-WebRequest https://dist.nuget.org/win-x86-commandline/latest/nuget.exe -OutFile $nugetExe
         }
     }
 }

Feel free to submit a PR of you have it fixed.


[$500] Web - Draft was added to ~20 chats without any action taken by the user

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

User walked away from their computer for 10 minutes
They returned and refreshed NewDot
They noticed about 20 chats that showed the draft pencil icon
They opened each chat and the text box said iH.

Expected Result:
Drafts should not be added to chats unless the user starts typing a message in that chat.
Actual Result:
Duplicate drafts were added to multiple chats without any action by the user.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693447325495479
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cad2d13ff8aa958d
Upwork Job ID:<PHONE_NUMBER>544651264
Last Price Increase: 2023-09-05

This happened to me as well -
I left my computer ~11;50am NZT
Returned to my computer ~13:05 NZT
found that some of my chats had the draft pencil icon and the messaging m'l
(I don't know why some chats had the draft and not others - as it affected some of my pinned chats but not others, one of my unread messages but not others)

Interesting, thanks @sophiepintoraetz !
Hmm I wonder if this might be related to the speed of typing in New.Dot? Sometimes when I'm typing pretty quickly, I notice New.Dot has a lag, and then when it "catches up", I notice jumbled words that show as drafts - almost like New.Dot has caught up with the typing, but since you've already sent the message, it has these extra excess letters.
I probably sound crazy, but I definitely think there's a huge lag in New.Dot atm. Making this External!

I don't see how it could be related though - I hadn't typed anything at the time, just simply opened up my newdot and observed that there were drafts.

I also just had this happen! I was showing Ben how to use newdot about an hour ago, I just went back to newdot and I have three drafts. Two say ram and one says rarm.

I have absolutely no idea where or why I would have been typing ram or rarm

I think this is related to the app lagging while typing. I tried typing lol damn and then after some serious lag, it output the following:

Also a similar reports:

https://expensify.slack.com/archives/C049HHMV9SM/p1694119295980249 cc @danielrvidal
https://expensify.slack.com/archives/C049HHMV9SM/p1694130035779309 cc @cead22

Proposal
Please re-state the problem that we are trying to solve in this issue.
Drafts should not be added to chats unless the user starts typing a message in that chat.
This bug can simply be reproduced by:

Clicking on a workspace, then click on the workspace header (to trigger a blur event for the chat composer)
Start typing on your keyboard (without focusing on any input fields)
Click outside the workspace detail to close it, then click anywhere in the workspace outside the chat composer
Again, start typing on your keyboard without focusing on any input fields
Click on another workspace, and repeat step 1 - 4

What is the root cause of that problem?
replaceSelectionWithText that is responsible for text insertion at selection point is excessively called within focusComposerOnKeyPress which is a handler for various event including navigation blur/focus. This is unnecessary because replaceSelectionWithText is already being executed in an useImperativeHandle hook.
https://github.com/Expensify/App/blob/fc8adf99a11a41154ec276d44495485958e43a7d/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js#L387-L390
What changes do you think we should make in order to solve the problem?
Remove replaceSelectionWithText from focusComposerOnKeyPress event handler, on line 388:
                   focus();
            // Remove this: replaceSelectionWithText(e.key, false);
        },
        [
            checkComposerVisibility,
            focus,
            // Remove this: replaceSelectionWithText
        ],

What alternative solutions did you explore? (Optional)
N/A

@mountiny For the moment https://github.com/Expensify/App/pull/26826 this PR solves the issue. Although RCA is different but ultimately we should never focus on the composer if the route is not focused. I have tested this bug report https://expensify.slack.com/archives/C049HHMV9SM/p1693995458316799 with the above PR seems it's not re-produceable.

Bumo @mananjadhav to check out the above PR please!

Put it on hold for your Pr and we can see if it will be fixed @b4s36t4

Changing the labels since it's on hold atm

https://github.com/Expensify/App/pull/26826 has been deployed last month. I don't know how to repro this - it seems to happen randomly to some people. It hasn't happened to me in the last month.
Should we close this @mountiny ?

I dont think this was reproed since then really so yeah I think we can close this


Allow custom sqlite files

By exporting a function that gives access to the database, rather than a set of functions that are normally provided, developers can specify different database files to store data. Running the function allows you to set the file, which is json.sqlite if no file is provided, and will return the normal methods such as set, get, push, delete, etc. This would be great for large systems where it needs multiple files, or if there are multiple programs running in the same directory.

You should fix the readme to properly reflect on the changes made here.
as well as fixing spec/test.js to go along with this.

You should fix the readme to properly reflect on the changes made here.
as well as fixing spec/test.js to go along with this.

Okay, I updated README.md and spec/test.js.


scrcpy: 1.25 -> 2.0

Description of changes
https://github.com/Genymobile/scrcpy/releases/tag/v2.0
This currently does not build on macOS, opening as draft while I investigate that.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

../app/src/screen.c:821:13: error: expected expression
            bool ok = sc_screen_init_size(screen);
            ^
/nix/store/dkgjv2srx116b0f9qnp9vcy3jjk5f39q-clang-wrapper-11.1.0/resource-root/include/stdbool.h:15:14: note: expanded from macro 'bool'
#define bool _Bool
             ^
../app/src/screen.c:822:18: error: use of undeclared identifier 'ok'
            if (!ok) {
                 ^
1 warning and 2 errors generated.
ninja: build stopped: subcommand failed.
error: builder for '/nix/store/aisij7hlj1ssbcbnfwmm2pggrlrymxdz-scrcpy-2.0.drv' failed with exit code 1;

I don't know, seems upstream is not really testing darwin support. I would myself just mark it broken.


How do I set the random seeds for the training?

How do I set the random seeds for the training?
Thanks!

You can add torch.manual_seed(seed) and np.random.seed(seed) to fix the seed during training.


WSL emjoy is ？？？

I jumped to kaili in the wsl system (ubuntu) of windwos10, I got emjoy expression turned into? ?

At the same time, any of my input will be invalid.

Why are you launching ubuntu via powershell?
If I had to guess, something's happening where the encoding of the text is getting mixed up piping the output of one wsl instance through powershell then back to wsl before going to the terminal.
@miniksa might have other ideas.

This is a curious case that we can't do anything about.
The version of conhost that ships along with Windows Terminal has been updated to support sending emoji (and other high unicode characters) from the connected command-line application to the terminal. When you run a Windows .exe from WSL, you're using the inbox conhost.exe as the console translator, and that version of conhost doesn't support high unicode.
The fix for this will naturally roll out as part of Windows, and it may already be available in Insider Fast builds.


Windows shortcuts misconstrue Ctrl and Windows key

The toolbar shows these commands, but it seems actual command is i.e. Ctrl + Shift + G, not Windows

PR welcome!


Replacing controller's variables when using controller as syntax

Here is the code
http://plnkr.co/edit/i4Ohhh8llS7WN68sLX5q?p=preview
If 2 variables have the same name on different controllers, the second controller will have its variable replaced by the remote call made on first one when using controller as syntax.

My error, should i use var when declaring variables.


tradeoff analytics response problem

Hello.
I downloaded the sample code for tradeoff analytics and was trying it on my local machine. I could run the code (index.jsp) file properly. When I clicked on Analyze button the following screen showed up. I think there is some problem with the css file. Could you please guide me on this issue ?

When I refreshed the page and clicked on Analyze again, nothing showed up . Some guidance regarding this will be a great help !

Did you follow the steps and update the DemoServlet.java with the credentials? Do you see errors in the web developer console?

Yes . I followed the steps mentioned and updated the DemoServlet.java file with the credentials. No I do not see any errors on the console. I checked the response status, it was 200 . So I think the response is proper but there is something missing in the UI part.

@boazdavid do you know what is that error?

It is indeed a CSS problem.
did you pass a customCssUrl in the taClient.start() options? What value did you pass?
If it is a CSS generated from LESS - you may have to re-generate it according to the new structure (GA version)

@germanattanasio @boazdavid the problem is style sheet is being accessed over HTTP and not HTTPS in index.js

@germanattanasio @boazdavid the problem is style sheet is being accessed over HTTP and not HTTPS in index.js

Thanks @tparikh

Thank you ! It solved my problem !!


Feat: Added support for HGETALL

https://github.com/DiceDB/dice/issues/257

@JyotinderSingh  Could you please review it

Some tests are failing, could you please take a look?

On local they are passing, don't know what's going wrong.. let me double check

earlier the test were failing because all test run simuntaniously for same port, and some key clash were there.. leading to invalid results. as of now i have changed the key name for my test.. but i am thinking should there be any other way around. @JyotinderSingh

@JyotinderSingh  please review

@JyotinderSingh  please reivew


How to know folder size?

Hi!
Command

gdrive info 0B-4gZiRL4tGXTkdoR29QSmltemM

doesn't show size of folder.

$ gdrive info -b 0B-4gZiRL4tGXTkdoR29QSmltemM
No valid arguments given, use 'gdrive help' to see available commands

bump


Require image for ARM64 architecture

Hi Team,
I am trying to use the maven-resource image on arm64 platform but it seems it is not available for arm64.
I have successfully built the image using the command docker build -t image_name . on the arm64 platform without any changes in the Dockerfile.
Do you have any plans on releasing arm64 images?
I am curious on how the amd64 image is getting published on Dockerhub as I am not able to access the current CI build
It will be very helpful if the image is released with ARM64 support. If required, I am happy to contribute.

Very interesting, this is the first request I've seen about arm64 support.  I didn't know that Concourse even supports arm64 workers (I don't see any arm64 binaries available on the Concourse releases page).
Can you share how you are using arm64 workers on Concourse?
I'd imagine that the best way to support this would be to provide another version of the maven-resource docker image that uses something like the arm64v8/openjdk Docker image.  In that case, you'd specify the architecture in the version of the resource config:

I have built the image for arm64 on my arm64 local machine. As you have mentioned that you are using concourse and arm64 binary is not available for concourse, even I was unable to build and test image for arm64 on concourse.
It seems it is a little complex to add arm64 builds in concourse until an official release is provided. So, I have tried another solution for this issue which is to use Travis CI just for arm64 builds. I built the image using Travis-ci and pushed it to Dockerhub.
Commit Link - https://github.com/pheobe07/maven-resource/commit/6367f7dda80cf20e6da5738740222e185dced020
Travis Link - https://travis-ci.com/github/pheobe07/maven-resource/builds/212670278
Docker Hub Link - https://hub.docker.com/r/odidev/maven-resource/tags?page=1&ordering=last_updated
Can you please suggest your opinions on this? If required I will raise a PR.

I have built the image for arm64 on my arm64 local machine. As you have mentioned that you are using concourse and arm64 binary is not available for concourse, even I was unable to build and test image for arm64 on concourse.
It seems it is a little complex to add arm64 builds in concourse until an official release is provided. So, I have tried another solution for this issue which is to use Travis CI just for arm64 builds. I built the image using Travis-ci and pushed it to Dockerhub.
Commit Link - https://github.com/pheobe07/maven-resource/commit/6367f7dda80cf20e6da5738740222e185dced020
Travis Link - https://travis-ci.com/github/pheobe07/maven-resource/builds/212670278
Docker Hub Link - https://hub.docker.com/r/odidev/maven-resource/tags?page=1&ordering=last_updated
Can you please suggest your opinions on this? If required I will raise a PR.


[Feedback] Don't remove left and right for the time being

Upgrading from alpha to beta I usually don't expect anything suprise me, but it did.
I use ml- and mr- a lot. This convention rename seems too hurry to me. Honestly I don't even like the new convention e or s because it's kinda not obvious to me (or it's just that i'm not used with it yet).
I appreciate the new RTL support, but to me the cost of this compatibility break is much higher than actually supporting RTL itself, especially when i'm expecting that my website is not even be seen by RTL userlands. I've been using bootstrap for years and I kinda afraid this change will affect my working performance (imagine telling your co-workers that why ml-/mr- not working anymore over and over).
My suggestion is, please support both convention left-right and start-end, and mention that left-right is deprecated and will be removed in the future (6.x or somewhere when usage is low). Font-awesome already doing this when they want to deprecate fa in favor for fas.

@ffoodd How likely is it that we could actually support something like this? Should we add aliases or no? We've had a few issues opened up asking about it.

@ffoodd How likely is it that we could actually support something like this? Should we add aliases or no? We've had a few issues opened up asking about it.

imagine telling your co-workers that why ml-/mr- not working anymore over and over

Yeah I imagine quite well actually, since you're not the first one I'll explain this again. 😄
@mdo I added to the docs several ways to either rename utilities, add aliases for such cases or even wrap our entire code base with .ltr/.rtl.
Regarding arguments, please read the related discussion or any other issues this one duplicates.
If you're using a custom build, you're able to add those aliases.
On our side, adding them would only:

make things really confusing for everyone, having two classes for rhe same thing;
would for sure prevent anyone from using them, and making this discussion happen again in v6;
add hundreds of duplicate utilities (bloating codebase and dist files);
kinda defeat the point of supporting RTL;
this is a major release, there's no better moment to introduce breaking changes.

IMHO, documenting how-tos is done and enough. One can very easily get its oldish v4 names, and I already suggzsted someone could make release the utilities overrides as a side-project.
Related discussion already explains and details the whole topic.
Your call @mdo if you want to make something else in our core, but looking at our current doc should help.

imagine telling your co-workers that why ml-/mr- not working anymore over and over

Yeah I imagine quite well actually, since you're not the first one I'll explain this again. 😄
@mdo I added to the docs several ways to either rename utilities, add aliases for such cases or even wrap our entire code base with .ltr/.rtl.
Regarding arguments, please read the related discussion or any other issues this one duplicates.
If you're using a custom build, you're able to add those aliases.
On our side, adding them would only:

make things really confusing for everyone, having two classes for rhe same thing;
would for sure prevent anyone from using them, and making this discussion happen again in v6;
add hundreds of duplicate utilities (bloating codebase and dist files);
kinda defeat the point of supporting RTL;
this is a major release, there's no better moment to introduce breaking changes.

IMHO, documenting how-tos is done and enough. One can very easily get its oldish v4 names, and I already suggzsted someone could make release the utilities overrides as a side-project.
Related discussion already explains and details the whole topic.
Your call @mdo if you want to make something else in our core, but looking at our current doc should help.

Closing per last comment.

Agreed ! the *-l &&  *-r mechanism is "core" to my base (incomplete) knowledge of BS - I have been using that convention for YEARS ! Imagine getting into a car and the steering wheel is now two levers for STARBOARD and PORT SIDE ?  :)


chip-tool needs to log the URL for custom commissioning to the command line

Problem
chip-tool needs support for Custom Flow commissioning for test case [TC-DD-3.9] Commissioning Flow - Custom Flow.
Steps 1-3 all require that chip-tool read an Onboarding Payload from a DUT accessory and fetch data from a Distributed Compliance Ledger (DCL) to assist the user in commissioning the DUT to chip-tool

Test Case
[TC-DD-3.9] Commissioning Flow - Custom Flow
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/devicediscovery.adoc#339-tc-dd-39-commissioning-flow---custom-flow

@raju-apple We spoke about the onboarding payload at some point. This can be done without chip-tool at the moment, is that correct ? If so, we need to update the priority of this issue.

Given above, moving to post V1.


TLS support limit

What problem does this PR solve?
TiSpark doesn't support TLS now, so add limit in readme

PTAL @birdstorm @zhangyangyu

/cherrypick release-2.4

/cherrypick release-2.5

/run-all-tests

/merge


Stop logging HttpResponseExceptions in RestProxy classes

Description
Fixes #36673
This changes how RestProxyBase implementations propagate HttpResponseExceptions to have them not be logged. HttpResponseExceptions aren't exceptions that happen due to runtime problems but represent the service call made wasn't proper and shouldn't be logged as a runtime error in the SDKs.
This also makes a change to HttpResponseException instantiation to return an HttpResponseException if the type fails to be created instead of the previous IOException. This aligns better with how UnexpectedExceptionInformation works in the default behavior being HttpResponseException as the default exception type.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

Hi @alzimmermsft and @lmolkova I tested the version https://mvnrepository.com/artifact/com.azure/azure-data-tables/12.3.18 and I'am still getting the error Status code 409

Sorry @alzimmermsft I didn't copy all the logs. So I am receiving these logs every time I call createTableIfNotExists:
c.a.c.i.http.rest.RestProxyBase          : Status code 409, "{"odata.error":{"code":"TableAlreadyExists","message":{"lang":"en-US","value":"The table specified already exists.\nRequestId:bf6206e5-8002-0049-027d-4909ec000000\nTime:2024-01-17T19:43:38.5963411Z"}}}"
c.a.c.i.http.rest.RestProxyBase          : Status code 409, "{"odata.error":{"code":"TableAlreadyExists","message":{"lang":"en-US","value":"The table specified already exists.\nRequestId:bf6206e5-8002-0049-027d-4909ec000000\nTime:2024-01-17T19:43:38.5963411Z"}}}"
c.azure.data.tables.TableServiceClient   : Status code 409, "{"odata.error":{"code":"TableAlreadyExists","message":{"lang":"en-US","value":"The table specified already exists.\nRequestId:bf6206e5-8002-0049-027d-4909ec000000\nTime:2024-01-17T19:43:38.5963411Z"}}}"

So I think it might be related to the issue in this PR. I already tried some workarounds but without success

@serafimpinto when calling this API, does it also throw an exception as well? Or, does it just have these errant logs?
I'll need to do some investigation on why this is happening as TableServiceClient shouldn't be logging an exception when calling createTableIfNotExists and the error code is 409 TableAlreadyExists, which can be seen here:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceClient.java#L484
And the only time RestProxyBase, SyncRestProxy, and AsyncRestProxy should log a message is when there is an IOException when handling the request, which is doesn't seem is the case here.
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/rest/RestProxyBase.java#L131
Could you include a mvn dependency:tree of your project to make sure azure-data-tables 12.3.18 is being resolved? And that azure-core 1.45.1 is being resolved.

Hello @alzimmermsft,
After inspecting the dependencies, I noticed that azure-core version 1.45.1 was not present. This change effectively resolved the issue with the logs from the RestProxyBase class. Thank you for addressing that.
However, I've observed that the TableServiceClient still logs 409 errors. I understand this might not be directly related to this particular issue, but I wanted to bring it up for visibility. As a temporary workaround, I've added logging.level.com.azure.data.tables.TableServiceClient=off to my application.properties to prevent flooding my logs with these errors. While this might not be the optimal solution, it provides a stopgap measure.
Thanks for your attention to this matter.

Hello @alzimmermsft,
After inspecting the dependencies, I noticed that azure-core version 1.45.1 was not present. This change effectively resolved the issue with the logs from the RestProxyBase class. Thank you for addressing that.
However, I've observed that the TableServiceClient still logs 409 errors. I understand this might not be directly related to this particular issue, but I wanted to bring it up for visibility. As a temporary workaround, I've added logging.level.com.azure.data.tables.TableServiceClient=off to my application.properties to prevent flooding my logs with these errors. While this might not be the optimal solution, it provides a stopgap measure.
Thanks for your attention to this matter.

@serafimpinto, glad to hear the RestProxyBase logging was resolved. For the logging in TableServiceClient could you file an issue for that?


Why no semicolons?

Curious why the choice was made to skip semicolons?

We use the Standard guidelines for this repo:  https://github.com/feross/standard.


Cannot use latest docker image

Good morning,
I am trying to use the latest image but I am ending up having this issue when running it:
standard_init_linux.go:228: exec user process caused: no such file or directory
Anybody experiencing the same?
Is it known?
Thanks :)

Hi,
That's my bad. I forgot to disable CGO when building. Please pull the latest and try again.
Cheers,
Bert

Hey Bert,
it is actually working!
I must say I am impressed and didn't expect an answer so fast... Thanks, really! :)
Jacques


Refractor type checkers

There are two type checkers, src/Futhark/TypeCheck.hs for the internal language and src/Futhark/Representation/External/TypeChecker.hs for the external language.
Why not put the internal under src/Futhark/Representation/ and the external under src/Language/Futhark/, so it matches the file structure of everything else (ie. the AST)

My original idea was to eventually factor Language.Futhark into its own separate library, which would be suitable if all you want is to generate Futhark code, without pulling in a full compiler.


Update config tile for cost management in learning resources hccdoc-2089

https://issues.redhat.com/browse/HCCDOC-2089

/ok-to-test


Invert direction of dependency between @faststore/core and @faststore/cli

What's the purpose of this pull request?
This PR aims to make @faststore/core a dependency of the @faststore/cli. It just makes sense. Someone can fork @faststore/core and never need to use the CLI, but there's hardly any usefulness to the CLI without @faststore/core.
How it works?
The only thing linking Core to the CLI was the generate-graphql command on the CLI. It just called back 4 scripts on core's package.json: generate:schema, generate:codegen, format:generated and generate:copy-back. The copy-back command was only needed to improve the DX of customers customizing their GraphQL schema [ref] and it was the only part of the script that needed information available at the CLI level only.
Since it was only a DX improvement, all that was needed was, during the faststore dev execution I had to generate the new schema, copy the files to the correct node_modules dir, and then start the NextJS dev server. In order to do this I split the dev script into predev, dev, and dev-only*. From the FastStore CLI I could now call yarn predev, copy the files to the correct place, and then run yarn dev-only to start the NextJS dev server.
Someone developing on the faststore monorepo (us VTEX developers, or someone contributing to our project) will continue to run core via yarn dev. npm, yarn, and pnpm support the lifecycle scripts out of the box. I did the same thing to build for equivalence.
One thing that can be up to discussion is the existence of runCommandSync util. It was only used on generate-graphql and can be easily removed (in this PR or in a future one).
How to test it?
Add this PR @faststore/cli from codesandbox as a dependency of the starter store, remove @faststore/core as an explicit dependency, and @faststore/cli as a devDependency. Run your store and see that everything still works fine. Or go to the starter preview [PR] here and see the store running in "production".

@eduardoformiga

It's very uncommon to remove the core dependency because some functions from @faststore/core are used in our features as API extensions, Section Overrides etc.

but since the CLI depends on Core, it will always be there :)


Hashset to bitmap

Description
Fixes issue #337 in Lind_project
Previously the dispatcher will convert fd_set into hashsets before calling select_syscall, which leads to severe overheads, and the adhoc hashsets are very short-living. So I made select and epoll to use bitmaps. As a fd_set is just a bitmap in itself, we don't need to convert anything now. The dispatcher treat original fd_set as a pointer to a mutcbuf and pass it into select_syscall. The helper functions to check and edit the bitmaps are implemented in types.rs
The unit tests were updted for the new select syscall. Notably, having a faster select reveals a concurrency issue of the tester, where the server doesn't wait for client threads to connect. This is also fixed with std barriers.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

Great fix. As @justyoyo123 said, it would help improve the performance of the select_syscall to help avoid unnecessary stalls in applications like Postgres.


store: crashing after upgrade to 0.3.0

Hi
thanos, version 0.3.0 (branch: HEAD, revision: 837e9671737698bf1778a4a9abfebbf96117a0be)
  build user:       root@986454de7a63
  build date:       20190208-15:23:51
  go version:       go1.11.5

I have 24h storage in prometheus and thanos for long-term. After upgrade thanos to 0.3.0 querying interval more then 24 crashing tanhos store:
 level=debug ts=2019-02-10T06:54:56.452875653Z caller=bucket.go:653 msg="Blocks source resolutions" blocks=6 mint=1549608897000 maxt=1549781697000 lset="{environment=\"prod\",replica=\"A\",service=\"sys\"}" spans="Range:<PHONE_NUMBER>000-1549771200000 Resolution: 0"
 panic: runtime error: slice bounds out of range
 goroutine 981 [running]:
 github.com/improbable-eng/thanos/pkg/store.(*bucketChunkReader).loadChunks(0xc05f438900, 0x127d1e0, 0xc003f29080, 0xc01ac84280, 0x4, 0x20, 0x0, 0x5f48c8305ecfa1d, 0x0, 0x0)
         /go/src/github.com/improbable-eng/thanos/pkg/store/bucket.go:1573 +0x6d3
 github.com/improbable-eng/thanos/pkg/store.(*bucketChunkReader).preload.func3(0x4346e9, 0x11757b0)
         /go/src/github.com/improbable-eng/thanos/pkg/store/bucket.go:1544 +0xb2
: github.com/improbable-eng/thanos/vendor/github.com/oklog/run.(*Group).Run.func1(0xc08bdd0c60, 0xc08bdd0b40, 0xc0686b08e0)
         /go/src/github.com/improbable-eng/thanos/vendor/github.com/oklog/run/group.go:38 +0x27
 created by github.com/improbable-eng/thanos/vendor/github.com/oklog/run.(*Group).Run
         /go/src/github.com/improbable-eng/thanos/vendor/github.com/oklog/run/group.go:37 +0xbe

Did it happen pre-0.3.0? Are you sure you have enough RAM in that box to execute this query?

I'm try set sysctl -w vm.overcommit_memory=2, with no success. I have lot of free memory.
Also I'm try downgrade thanos on store node to 0.2.1 and it works fine, no crash on queries.

Also seeing the same panic with Thanos Store after upgrading to 0.3.0:
goroutine 978 [running]:
github.com/improbable-eng/thanos/pkg/store.(*bucketChunkReader).loadChunks(0xc4218485a0, 0x11e87c0, 0xc4f9cbd280, 0xc45c5f6800, 0x2f, 0x100, 0x1, 0x1e9185281e8dc144, 0x0, 0x0)
	/go/src/github.com/improbable-eng/thanos/pkg/store/bucket.go:1573 +0x6bf
github.com/improbable-eng/thanos/pkg/store.(*bucketChunkReader).preload.func3(0x0, 0x0)
	/go/src/github.com/improbable-eng/thanos/pkg/store/bucket.go:1544 +0xab
github.com/improbable-eng/thanos/vendor/github.com/oklog/run.(*Group).Run.func1(0xc43e7d8180, 0xc43e7d80c0, 0xc43f936510)
	/go/src/github.com/improbable-eng/thanos/vendor/github.com/oklog/run/group.go:38 +0x27
created by github.com/improbable-eng/thanos/vendor/github.com/oklog/run.(*Group).Run
	/go/src/github.com/improbable-eng/thanos/vendor/github.com/oklog/run/group.go:37 +0xa8

I can see that Store uses a fair amount of memory during bucket initialisation and then drops off to a more conservative usage. As you can see below it does not run out of memory at the moment it crashes (7.61GB / 20GB @ 11:08:30):

Hm.. the code path that is problematic looks exactly like this: https://github.com/improbable-eng/thanos/pull/816
This means that we ask for more bytes in object storage and reader gives us less. We probably need some check anyway (like mentioned in discussion in linked ticket). But the overall state looks lile malformed block. Why would index point to non existsing bytes? Unless we have bug in posting code, which was touched recently.
This happens on particular block or all of them? How often?

In my case all queries to remote storage in 0.3.0 crashes. I'm downgrade to 0.2.1 only store node and all working fine now

I have also downgraded by storage processes to 0.2.1 and all is fine now (have left query, and compactor running as 0.3.0)

Is the block that this is happening a partially uploaded block?
From the code, this should only happen if we are trying to get data that we expect would be in the block but has not been written.

No it's not. I don't have partially uploaded blocks (at least on the sidecar or compact logs). But in one s3 bucket (local minio cluster) I have blocks from multiple prometheus with different tags (replica,dc,service) and store queries to all of them failed on thanos 0.3.0, but it work fine on version 0.2.1.
I downgrade to 0.2.1 only store service. Sidecar, query and compact are working on 0.3.0.

What @R4scal says almost exactly mirrors my issue as well. Although I had 2 separate environments (different buckets etc) and 0.3.0 failed store queries so I downgraded that to 0.2.1 and all ok. Everything else is at 0.3.0. I can switch versions at will really if anything needs testing.

Yes would be nice to know, if particular block is wrong or just all. If
0.2.1 works then it seems like it has to be something with upgrade of tsdb
and posting refactor we had ):
On Mon, Feb 11, 2019, 12:38 Paul Seymour<EMAIL_ADDRESS>wrote:

What @R4scal https://github.com/R4scal says almost exactly mirrors my
issue as well. Although I had 2 separate environments (different buckets
etc) and 0.3.0 failed store queries so I downgraded that to 0.2.1 and all
ok. Everything else is at 0.3.0. I can switch versions at will really if
anything needs testing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/improbable-eng/thanos/issues/829#issuecomment-462421206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGoNuyRp7o2UkFQSf-7v1b-Ys6Y0PZp3ks5vMaqlgaJpZM4ay7M7
.

Doesn't seem tied to a particular block. But it's hard to say for sure. Anything I can run to point to ? Running it in debug shows a bunch but nothing to indicate a problem with any of them.

I think this is related to this change: https://github.com/improbable-eng/thanos/pull/753

Important question. What queries are you doing exactly?

Example queries that crash thanos 0.3.0 from grafana in my case:
telegraf_internal_gather_metrics_gathered{input="disk",environment="$env",ms="$ms",service="mon"}
rate(net_bytes_recv{ms="$ms",host=~"$host", interface=~"bond[0-9]+$",environment="$env",service="sys"}[$inter])*8

Thanks for all info! In just couple of days after release we found and hopefully fixed this: https://github.com/improbable-eng/thanos/pull/837
(: We need to fix some issues with negative matcher and then we will do patch release to add this.

Fixed by this: https://github.com/improbable-eng/thanos/pull/837 (:


parse_csv action crashes in grade_entry_form controller

upload_csv should gracefully fail on non-csv file with .csv extension, but right now it throws an exception. upload_csv only checks for correct file extension and passes the file to parse_csv which cannot candle non-csv files.

Thanks, @MatakuT. @paymog this is basically the same error as before.

Sounds good. Wanna assign it to me?

I've fixed this problem but one of the tests is now failing. Specifically, a test in grade_entry_forms_controller_test.rb which should 'have invalid values in database after an upload of an ISO-8859-1 encoded file parsed as UTF-8'
I must be misunderstanding something because it seems that the test is expecting to DB to have invalid values when the user messes up. Surely this isn't what's actually desired.

Yes, you can remove the test.


implement social auto registration feature

Related to #574
I added a setting to allow auto silent registration of user when social auth is used.
Few things to be aware of:

enabling this setting would disable email verification for social auth but it's described under the setting + I think email verification for social auth is useless.
if domain restriction is enabled => the auto social registration process respect it.
Missing: translation & probably better wording (my english is not perfect)

Missing: check of wording + translations

@ssddanbrown do you know why the unit tests are failing only for PHP: 7.0.20

test

retest

Anyone would like to review this? @Abijeet @ssddanbrown happy to discuss

Sounds good; would be handy if you could restrict to only allow registration from social auth (restricts control of authentication to your github org or as configured in azure)

Thank you for this pull request @ibrahimennafaa. It is now merged although be aware I have made some changes to the system since which can be seen here:
https://github.com/BookStackApp/BookStack/commit/e60d11ee04161d16875d706110876c31f9064565
I thought there's quite a good chance that trust in a social service may differ between services so admins may want more control over this kind of registration logic. Therefore I changed the global setting in the interface for a set of .env options.
For each $service you can now set a {$service}_AUTO_REGISTER and a {$service}_AUTO_CONFIRM_EMAIL option your .env file.

AUTO_REGISTER will allow registration from login, even if registration
is disabled.
AUTO_CONFIRM_EMAIL indicates trust and will mark new registrants as
'email_confirmed' and skip 'confirmation email' flow.

As part of my updates I also removed the additional registration logic from the SocialAuthService to reduce duplication so now send users down the normal registration flow at the controller-level.
Massive thanks for getting this started, Will be in the next release which I'm hoping will be done in the next few days.

@ssddanbrown thanks for the updates! They all make sense to me.
Do you happen to know in which version this will be deployed?
Thanks!


Mountebank hosted on a different server

In regard to the comments in the docs:

If you need to change the server location, you will have to setup the application locally.

I'm not sure if I understand the guidance. I'm able to get disguise working locally using the proxy.conf.json settings, but I'd like to update the production deployment to point to my remote Mountebank server. Is this possible?
Thanks!

There is a file src/proxy.conf.json that has the 'target' for the /api calls in it. You'd need to change that and build/run Disguise.
The only sticking point would be that the browser would send CORS requests to the mb server, since it is the browser calling into mb directly.


[Help needed] traccar: init at 4.2

Motivation for this change
Package for Traccar: https://www.traccar.org/
After this works, I'd like to add a traccar service to NixOS.
This is still work in progress, and any help would be greatly appreciated. I have no idea how to build with Maven on NixOS.. This is the build failure I'm now getting:
$ nix-build '<nixpkgs>' -A traccar
these derivations will be built:
  /nix/store/vng60wpg616h5mpkwyzn4aq5z94rfawz-traccar-4.2.drv
building '/nix/store/vng60wpg616h5mpkwyzn4aq5z94rfawz-traccar-4.2.drv'...
unpacking sources
unpacking source archive /nix/store/2bj2wyj2lsc8cmh8hgwk9v37d6fwz7ma-source
source root is source
patching sources
configuring
no configure script, doing nothing
building
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------< org.traccar:traccar >-------------------------
[INFO] Building traccar 4.2-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-enforcer-plugin/1.4.1/maven-enforcer-plugin-1.4.1.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.377 s
[INFO] Finished at: 2019-01-19T11:07:48Z
[INFO] ------------------------------------------------------------------------
[ERROR] Plugin org.apache.maven.plugins:maven-enforcer-plugin:1.4.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-enforcer-plugin:jar:1.4.1: Could not transfer artifact org.apache.maven.plugins:maven-enforcer-plugin:pom:1.4.1 from/to central (https://repo.maven.apache.org/maven2): repo.maven.apache.org: Name or service not known: Unknown host repo.maven.apache.org: Name or service not known -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
builder for '/nix/store/vng60wpg616h5mpkwyzn4aq5z94rfawz-traccar-4.2.drv' failed with exit code 1
error: build of '/nix/store/vng60wpg616h5mpkwyzn4aq5z94rfawz-traccar-4.2.drv' failed

Official build instructions: https://www.traccar.org/build/
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Any progress?

@veprbl No, I haven't looked into this in a while. I'd be interested in traccar service though. When/if I find time, I'd continue with this, but I have no idea when that might happen. Should I close this or keep open as the packaging request for traccar is still valid?

Should I close this or keep open as the packaging request for traccar is still valid?

I would suggest closing the PR if you don't have a change that you'd like to incorporate to nixpkgs. You can open an issue to track this, we provide a template for packaging requests.

Ok, thanks!

Oh, I had totally missed that someone had provided some help on my fork: https://github.com/jluttine/nixpkgs/pull/1. Just linking it here for reference. Perhaps I'll try that out soon! If so and I can make it work, I'll re-open the issue.


Simulator crashes after user has deleted their profile

In the simulator all database references are gone after a deletion of a profile. Therefore the simulator crashes because all values are null or undefined.

Fixed. Will create a PR later.


To support java17 runtime, substitute wrapper handler for original in exec command line

The new java17 runtime appends the configured handler to the command line of the launched java process as an additional app-level argument, and appears to prefer that over the _HANDLER environment variable.  This means that our wrapper approach for Java instrumentation stops working since it overrides that variable.  I've fixed this by applying some (gnarly looking) bash string substitution on the command line (preserving spaces, argument order, etc.) to swap out this extra argument, and verified that our wrapper gets called again.

I notice that the CI didn't run any tests?  I thought of switching the runtime of one of the java tests to java17 just to get a little coverage on this.  Another option would be to matrix out the tests across all applicable runtimes, though that might get to be too large of a refactoring for one PR.  Thoughts?

(I don't think the java project here has any unit tests... Open to suggestions or contributions for how we might add useful tests without having AWS infrastructure to test against?)

(I don't think the java project here has any unit tests... Open to suggestions or contributions for how we might add useful tests without having AWS infrastructure to test against?)

We (Splunk) test against real AWS infra; because of stuff like this (PR) I think it'd be best to focus on similar for upstream otel-lamba as well.  I realize that's a major task, what with figuring out funding/credentials management/etc. but I think it would be a huge win for this component.  Mocking things out just wouldn't uncover these kinds of issues.
Regardless, it appears that's outside the scope for now.  Please merge when ready.

Ping!  This has been here a while...

We are currently in limbo between maintainers... The previous maintainers have stepped down but new maintainers haven't been approved yet (#968).
cc @trask

sorry for the limbo, I just pinged @open-telemetry/technical-committee to request merging #968 and updating permissions


backwards update

:tada: This PR is included in version 9.7.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 9.9.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add yadm

Checklist for submitting a pull request to Terminals Are Sexy:

[X] I have carefully read and comply with the Contributing Guidelines of this repo.
[X] I have searched the PRs of this repo and believe that this is not a duplicate.

Title: yadm - Yet Another Dotfiles Manager
Link: https://thelocehiliosan.github.io/yadm/
Category: Tools and Plugins
Description: Seamless git-based management of your dotfiles.

yadm is a dotfile management tool with 3 main features: Manages files across systems using a single Git repository. Provides a way to use alternate files on a specific OS or host. Supplies a method of encrypting confidential data so it can safely be stored in your repository.

I've updated the URL to be the official yadm.io address.

Thanks! Could you please also squash your commits into one?

Sure, I've also rebased this on top of master.

I just noticed that you changed the link to yadm.io instead of github.com/TheLocehiliosan/yadm. Could you please change it to the GitHub repo page? Thanks.

Yes, I used yadm.io because that's the official website for yadm. In the future, the source code might switch to a different site, but the official site will always be yadm.io.


Support for other keyboard layouts

Hi, are you planning on adding other keyboard layouts to the web app? (i.e. spanish, french, maybe even dvorak layout, etc)
I have a Spanish keyboard layout, and while I can use the web app with its US configuration, it would be much much nicer if I could have my own setup. (Also, some keys from the Spanish layout are missing in the US layout).
If you are not planning on doing this, then let me know and I might do it myself and submit as a pull request in case you want to include it in the app.

I'm thinking about implementing the ability to switch keyboard layouts for this app. Should drastically improve the user experience. Most likely won't implement other layouts than German and English myself though.

Hey, are you working on this? I would like to help you. (Right now I grabbed a new gamer keyboard, with a few special keys, and I'm about to hardcode the changes in my local app. But if you're working on the keyboard layouts system, I would love to help either finishing it or loading some keyboard layouts).

Well. In fact I do have some time to code stuff today. Haven't touched the keyboard thing yet, but give me some hours or a good idea how to do it and I think I can come up with a system that easily allows custom keyboards. In fact I think I got a good idea already. I'll try to find a JSON format to store layouts in and parse them. Should be fairly easy then to create a pull-request with an additional layout.

This is my current idea:
{
	"language": "en-US",
	"name": "Default Layout (English)",
	"rows": [
		{
			"type": "row",
			"keys": [
				["empty"],
				["Esc", "ESC"],
				["empty", false, 1.5],
				["F1", "F1"],
				["F2", "F2"],
				["F3", "F3"],
				["F4", "F4"],
				["empty", false, 0.25],
				["F5", "F5"],
				["F6", "F6"],
				["F7", "F7"],
				["F8", "F8"],
				["empty", false, 0.25],
				["F9", "F9"],
				["F10", "F10"],
				["F11", "F11"],
				["F12", "F12"],
				["empty", false, 0.5],
				["Print", false],
				["Lock", "SCROLLLOCK"],
				["Pause", "PAUSE"],
				["empty", false, 4.5]
			]
		},
		{
			"type": "separator"
		},
		{
			"type": "row"
		},
		{
			"type": "row"
		},
		{
			"type": "row"
		},
		{
			"type": "row"
		},
		{
			"type": "row"
		}
	]
}

Tell me if you find anything wrong with it. I think it should be able to describe every usual keyboard layout.

That's perfect. The third parameter on a key, I assume is the width, with 1 being the normal key width, correct? And that parameter can be used in both empty but also in bound keys, right?
That JSON looks perfect to me.
Let me know how I can help. For example, I can transcribe the current layout to JSON format and post it here. It's a small task, but I want to help, hah.

That would be nice. I'll work on the parsing part then. Hate doing repetitive stuff. :)

Cool. I'm on it. A couple regular expressions take the repetitive part out of it, btw. For example I just transcribed most regular keys using:
/<Key name="([^"])" span="[^"]" identity="([^"]*)"/>/["\1", "\2"]/g

Could you push the layout soon? The parser is ready, but I can't do much more without having the complete layout.

Yup. I'm validating, one sec.

Allrighty:
http://pastebin.com/RwiATAWc
I haven't triple checked, but it should be OK. I cannot lint the JSON because of the bool and number within the objects, but I think it has no errors.

Updated link, direct raw content:
http://pastebin.com/raw.php?i=ReiDkgTW
Also, is there a reason why = was bound to KEYPAD_= ? that has not worked for me. (I changed it to =, feel free to revert that)

Okay, this mostly looks alright. Only thing I noticed is that space is 1 key wide, which it shouldn't be. Other than that it's okay if you just submit this as a pull request now. I can fix/fine tune it once it's in the project files.

Cool, I fixed that, and also noticed that I was missing all the widths for non-empty keys that had a width different than 1. Fixed that too. Pull-requesting now...

Nice, thanks.

Ok, pull requested.

Oops, I added the file to the root folder, I didn't see you had added a keyboard layouts folder. Remember to move that when you need to test. :)

Yeah, already working on it. Also fixed the \ being unescaped.

If you want to you can work on the Spanish layout and submit it as web/source/keyboard-layouts/es-es.json. I'm trying to implement a layout switcher and ajax loading of the .jsons in the meantime.


Shap Values do not sum up to the models output (are all zero) for LSTM

Hallo,
first of all great approach to tackle the black box problem, I'm really hyped to use your approach in my thesis. Sadly, there seems to be a problem when calculating the shap_values using the DeepExplainer for my LSTM predicting a Time Series.  I get the error:
"AssertionError: The SHAP explanations do not sum up to the model's output! This is either because of a rounding error or because an operator in your computation graph was not fully supported. If the sum difference of 0.050865 is significant compared the scale of your model outputs please post as a github issue, with a reproducable example if possible so we can debug it."
If I add  check_additivity= False and print the shap_values, they are all zero and in a strange shape.
I had several issues when using the DeepExplainer (disabling eager execution solved that tho) it seemed to work with the GradientExplainer but the values made no sense.
Reproducible Example: https://colab.research.google.com/drive/14zWFLO8bbGSvANpb9roo-vjWdPO8Ta7s?usp=sharing
I hope you guys can help me out, thanks in advance!
Greetings,
Nick

Addition:
adding: tf.compat.v1.disable_v2_behavior() directly after importing tensorflow seems to handle the problem, so after reading through a lot of the related issues it seems to be a general problem with tensorflow V2 and up.
So by adding that I do get values from the DeepExplainer, although I'm not sure they are correct, as
np.abs(shap_values[0].sum(1) + explainer.expected_value - y_hat[:1]).max()
is not zero, so the calculated values could be wrong.


Implement inactivity timeout on WS connection

To be able control stale connection would be nice to implement possibility to close connection in case provided inactivity period is reached.

implemented as part of #27


[ALLUXIO-2479] Improve comment style in WebInterfaceBrowseLogsServlet

https://alluxio.atlassian.net/browse/ALLUXIO-2479

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14106/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14107/
Test PASSed.

Merged build finished. Test PASSed.


Enable compass in project

I sugest to implement compass support for this project. Many peopole who use sass would like to use their compass mixins and functions too.
In this moment when i try to use @import 'compass' it can not resolve.
I think to do this we need config.rb but i have no idea how to properly configurate it in this files structure.
In my opinion that gulp-compass should be implemented in gulp's task but i simply don't know when and how to do this.
Any idea how to overcome this right now ?

You will probably need to pipe though the compass plugin in process.scss.ts and add the gulp-compass plugin to devDependencies.
I am not too sure about importing compass, can have a bit of a look later in the week maybe.

I will be very glad for your help. I expecially would like to use Compass mixin for vendor prefixes.
I think that Autoprefixer should do the same trick, but right now it isn't working corretly for my css output.
Should i make something special to activate Autoprefixer in building app proces ?

Well, the autoprefixer was not being called in the correct place and with correct files. I just fixed this. Now we are tightly controlling the process of scss transformation so that autoprefixer is being called right after the sass preprocessor is run. Please try again and let me know if you see any issues.

Would this affect people that do not want to have compass?
I want to keep my css library minimal without external libraries of any size (even if they don't get loaded in production).

@Kunepro, I agree with you. Not going to add compass - if someone can document the steps to do the integration, we can happily put it on our wiki.
Since the autoprefixer part of this issue is now working, I am going to close it for now.