VAD Speech boundaries fails using basic .wav file.

Following the examples, I am getting errors with just three lines :(
The below yields a shape error.
from speechbrain.pretrained import VAD
VAD = VAD.from_hparams(source="speechbrain/vad-crdnn-libriparty", savedir="pretrained_models/vad-crdnn-libriparty")
audio_file = "20211229030727-000-vocals-split006.wav"

returns this error.
RuntimeError: Given normalized_shape=[40], expected input with shape [*, 40], but got input of size[160000, 1, 40, 2]

Just had to reshape/resample 😬
Found some helpful code here
Working code looks like this... would be nice if I didn't have to resave, but i didn't see how that was immediately possible through the VAD api.
waveform, sample_rate = torchaudio.load(audio_file, normalize=True)
transform = transforms.Resample(sample_rate, VAD.sample_rate)
waveform = transform(waveform)
waveform = waveform[0].unsqueeze(0)
output_file = "foo.wav"
torchaudio.save("foo.wav", waveform, VAD.sample_rate)

boundaries = VAD.get_speech_segments(output_file)

Hi! It looks like your input audio has two channels, right? As far as I
remember the model expects just one. You can just read it and save it as
single channel audio.
On Fri, 31 Dec 2021 at 01:31, Steven Tobias @.***>
wrote:

Following the examples, I am getting errors with just three lines :(
The below yields a shape error.
from speechbrain.pretrained import VADVAD = VAD.from_hparams(source="speechbrain/vad-crdnn-libriparty", savedir="pretrained_models/vad-crdnn-libriparty")audio_file = "20211229030727-000-vocals-split006.wav"
returns this error.
RuntimeError: Given normalized_shape=[40], expected input with shape [*, 40], but got input of size[160000, 1, 40, 2]
—
Reply to this email directly, view it on GitHub
https://github.com/speechbrain/speechbrain/issues/1220, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA2ZVQCC5GRBJ6YZF7NYLDUTVE55ANCNFSM5LA3Q42A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Stopping dev server cause all chrome windows and tabs get closed

Is this a bug report?
I think so
Did you try recovering your dependencies?
I did dependency installation both with npm and yarn (separately, once npm install try,  delete lock and node_modules, yarn install try ). Also this happens on a freshly created project.
npx create-react-app myApp --typescript
Which terms did you search for in User Guide?
typing the title resulted in one similar topic, but that issue was  closed with the mainly answer "open a chrome instance before running server"
Environment

the app is created with CRA npx create-react-app myApp --typescript which uses all the latest versions by today. react-scripts 2.1.3

OS, Ubuntu 18.04 LTS

Yarn 1.12.3 (I am using yarn)

node,npm versions, 8.12.0  and 6.8.0

chrome 73.0.3683.86 (Official Build) (64-bit) with react, mobx, CSS peeper, and an adblocker plugin extension

VSCode 1.32.3  (I use the VSCode terminal)

Expected Behavior
When there are other chrome windows/tabs open and starting dev server yarn start should open a new tab in the most recent instance. And on the Ctrl+c to stop the server should only close that specific tab.
Actual Behavior
All the chrome windows' (tabs) get closed even if there are two chrome windows are open with two different accounts

This should be fixed in<EMAIL_ADDRESS>If it's still not working for you with that version please let us know.


Experimental RFC 436 - import type extending generic appears as "unused" by TS

I've added experimental RFC 436 to my project because I really needed generic components. It works pretty well, but for some reason when my generic extends an imported type, that type appears as "unused" by TypeScript. With eslint, I get the following warning message:

I made a public repo to showcase the issue. The generic component is TheWelcome. Please note this repo is shared with https://github.com/johnsoncodehk/volar/issues/2192 (separate branches).

This is ESLint report we can't fix, but we will have complete ESLint support in the future, please track https://github.com/DrJume/vue-volar-eslint/pull/1.


Update client3:core to 3.10.0

About this PR
📦 Updates com.softwaremill.sttp.client3:core from 3.3.18 to 3.10.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3", artifactId = "core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.client3", artifactId = "core" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #1299.


Migrate to Vite + Vitest

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages (more info).
[ ] Added or updated documentation.
[ ] Tests for new functionality and regression tests for bug fixes.
[ ] Screenshots or videos attached (for UI changes).
[x] All your commits have a Signed-off-by line in the message (more info).

fb94ea6f82ad643d96c61237b0bc8c26b59ceb1e exists due to https://github.com/dequelabs/axe-core/issues/4458

Another note: Usage of act throws  Warning: The current testing environment is not configured to support act(...) but this is "expected" and not an issue as also shown in https://github.com/testing-library/react-testing-library/issues/1061

For discussion: We could replace rollup too with https://vitejs.dev/guide/build.html#library-mode

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

Not sure for vite/vitest, but for eslint we can make a ruleset and use that just like we do with other eslint plugins. There is already a ticket for this.

Did/can you check if any of the warnings produces by yarn check are relevant to this PR?

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

cd example-widget-mui && yarn preview:https results in an empty page (and widget)

cd example-widget-mui && yarn preview:https results in an empty page (and widget). am i holding it wrong?
i guess i need to yarn build first. maybe that should go in the docs.

Yup first build. And yes I should append the docs

is there a reasonable way to sync certain configs across projects? e.g. I see parts of eslint config changed here to include the same options as standalone (but also more) and also options are in a different order.

see NEO-689

cd example-widget-mui && yarn preview:https results in an empty page (and widget). am i holding it wrong?
i guess i need to yarn build first. maybe that should go in the docs.

Yes. Preview does serve the build files.

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Vite should resolve port conflicts. You get an URL in the shell when running it. Will double-check anyway.

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Vite should resolve port conflicts. You get an URL in the shell when running it. Will double-check anyway.

Can confirm. Vite looks for the next free port and prints it to the shell.

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Vite should resolve port conflicts. You get an URL in the shell when running it. Will double-check anyway.

Can confirm. Vite looks for the next free port and prints it to the shell.

That isn't the point:
I want to yarn dev the mui demo widget and add it to my test toom at $port and if i tomorrow start the neoboard widget first and the demo widget second, the demo widget should still appear on $port so it is in the room i added it to and i don't need to set everything up from scratch again.

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Did get it wrong „should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?“ reads like change default ports or auto resolve collisions (what vite does) :D

should we change the default ports for vite in the neotoolsuite so the different things don't collide (or autoresolve the collision, mixing up the order every time)?

Vite should resolve port conflicts. You get an URL in the shell when running it. Will double-check anyway.

Can confirm. Vite looks for the next free port and prints it to the shell.

That isn't the point, I said I do not want to autoresolve the conflicts: I want to yarn dev the mui demo widget and add it to my test room at $port and if i tomorrow start the neoboard widget first and the demo widget second, the demo widget should still appear on $port so it is in the room i added it to and i don't need to set everything up from scratch again.

Ports for the example widget and preview are now: 5173 (http) and 5174 (https).

please update containers/widget-server/README.md regarding CRA. there is another mention in the ADRs which I think we can keep.

done


Unauthorized to sign block at reset level

Currently, the app cannot sign block at reset level.
Is this an expected behaviour ?
See: https://github.com/trilitech/ledger-app-tezos-baking/pull/18#discussion_r1474029889

Accusing
Here is my understanding of when an operation/block can be accused:
Operations
If an accuser retrieves, at any time, from the same attester, two attestation (resp. two pre-attestations) with :

the same chain_id, level and round and
different payload_hash, slot or branch

Then the accuser can accuse the attester with a Double Attestation Evidence (resp. Double Pre-Attestation Evidence).
This happens no matter if the accuser retrieves the operation from the mempool or from a block.
Block
If an accuser retrieves, at any time, from the same baker, two block with :

the same chain_id, level and round and
different hash

Then the accuser can accuse the baker with a Double Baking Evidence.
In our app
We choose to :

only check chain_id, level and round :

this allowed to make fewer checks without authorizing non-valid operation/block.
but prevents to sign some valid operation/block from the same chain_id, level and round.

only keep one chain_id : see https://github.com/trilitech/ledger-app-tezos-baking/issues/19.
from a same chain_id, only check if the level/round is not lower than the last level/round seen :

this allowed us to only retain one level/round without authorizing non-valid operation/block.
but prevents to sign older operation/block that are still valid.

prevent signing a pre-attestation after an attestation at the same level/round but the opposite is possible.
prevent signing a block after an attestation/pre-attestation at the same level/round  but the opposite is possible.

The RESET instruction

Proposition:
Change 4.iii into:

prevent signing a block if another block or an attestation/pre-attestation has already been seen.

Proposal:
Keep the conditions as they are, but prevent signing at the same level as the reset (whatever the round).
This implicitly implies the previous proposal.

Final decision:
Do not change the current behaviour, as the baker most often resets at level 0 and does not bake at level 0.


Reopen - Duplicate Numbers #175

On Android, many contacts return duplicate phone numbers, formatted slightly differently.
It seems to have to do with other apps storing the number again, for example WhatsApp Business storing the same number under 'Video call', 'Voice call' and 'Message'.
It is super annoying and basically not usable in production without filtering.
I suggest the library should:

Filter and compare each contact's phone numbers
If duplicates exist, only return ONE instance

Issue #175 was closed by a bot without resolution.

On Android, many contacts return duplicate phone numbers, formatted slightly differently. It seems to have to do with other apps storing the number again, for example WhatsApp Business storing the same number under 'Video call', 'Voice call' and 'Message'.
It is super annoying and basically not usable in production without filtering.
I suggest the library should:

Filter and compare each contact's phone numbers
If duplicates exist, only return ONE instance

Issue #175 was closed by a bot without resolution.

Same issue i m currently facing...any solution for that?


Bugs

If you are good in html and/or JavaScript, consider helping
Bugs:

Doesn't submit the form
Strange behavior on mobile (tested on iPhone)

@Roguemaster do you have html/js knowledge? Because this is very close to being finished.
Or if you know someone who could help, please let me know.
Thanks

Hey there 👋,
I'd be happy to help out! I'm experienced with HTML and JavaScript. Could you please provide more details about the what are you trying to do in the discordnano.html . This will help me better understand your project and how I might be able to contribute effectively.
Looking forward to collaborating with you!

Hi,
thank you for your offer to help, I am glad somebody wants to help out.
I am currently on vacation and don’t have a computer with me, but I will provide you some information:
There are some bugs I noticed, but the major two are: the form does not submit when clicking on submit (the flipper does not receive any form data). And second: On mobile (I only tested it on my iPhone using my flipper), the background image has 100% width wich means the user can/has to scroll horizontally and the input fields are aligned in the very center, as the form background is aligned on the left. -I will attach a screenshot at the end.
Some other bugs:

Darkreader (Darkmode) overwrites the background

Thank you again for your help, and if you have other question, both about the project and technically, feel free to ask.
@

Thanks
I think i can redesign and make it responsive. I will also remove the javascript for background svg because once its decrypted there is no need to decrypt again and again.
I will submit once I am done.

Is there a loop? I didn't noticed that, I am not a pro in JS and still learning.
Thanks for your help, this will definitely speed things up!

I mean once svg is decrypted ,you have printed svg on console. So you can copy paste that in a svg file and then use it as a background.
I am working on it. Currently this is what i have build.
Tell me if you like it.
Current issues (maybe):

font style and size
padding and margins

mobile view

Could you open a temporary pull request, so I can test it on an iPhone?

Now size is around 6k because I hosted the svg online. If there is something wrong with my method, let me know I will try something else.

Unfortunately this is not possible.
Like I said previously, the evil portal project for the flipper zero has some big limitations: Everything must be available offline AND in the one html file, no external images or anything, also the character limit is 20k. This was really tricky, so I decided to use the gzip method and I think this is the best solution to this problem.


BSO Add Imbued (Mage Arena) Max cape to CoX boosts

🐛 Bug Report
I bought one and not just for me, but I thought it would be fair if those capes would give at least the same boosts as a regular imbued  mage cape.
Write a description of the bug here, give all the information you can about what it is, how it happened.

#706 will fix this issue.

a temp solution merged #761


SSUI - Adding application wide loading indicator

This helps the user to know that a request is being made.


Documentation is not built by CircleCI

CircleCI does not build the documentation. Nor does it update the gh-pages branch when building the documentation on master.

Duplicated from #61


Add HealthCheck if license usage has exceeded limit

Veeam Backup for Microsoft 365 version
7
Description
Add HealthCheck if license usage has exceeded limit
Additional Context
No response
Before submitting

[X] I have read the documentation, and referred to the known issues before submitting this change request.
[X] I have checked for previously opened & closed issues before submitting this change request.

https://github.com/VeeamCommunity/veeamcommunity-2023-Team-4/issues/15
$vbolicense = Get-VBOLicense
if ($vbolicense.usednumber -gt $vbolicense.TotalNumber) {
write-host "VBO license exceeds limit" -ForegroundColor Red
}
else
{
write-host "VBO Licensed : OK" -ForegroundColor Green
}

Code:
if ($OutObj) {
    Section -Style Heading2 'Licenses' {
        Paragraph "The following table summarizes the licensing information within $VeeamBackupServer backup server."
        BlankLine
        if ($chartFileItem -and ($sampleData.Values | Measure-Object -Sum).Sum -ne 0) {
            Image -Text 'License Usage - Chart' -Align 'Center' -Percent 100 -Base64 $chartFileItem
        }
        BlankLine
        $OutObj | Table @TableParams
        if ($HealthCheck -and ($Licenses.UsedNumber -gt $Licenses.TotalNumber)) {
            Paragraph "Health Check:" -Bold -Underline
            BlankLine
            Paragraph {
                Text "Best Practice:" -Bold
                Text "Warning: Your license has exceeded its user limit."
            }
            BlankLine
        }

        # Per user license information
        if ($InfoLevel.Infrastructure.License -ge 2) {
            Get-AbrVB365InstalledLicenseUser
        }
    }
}


feat: made the customize columns to appear in Portal for same line

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Motivation and Context

How did you test it?

Checklist

[x] I ran npm run re:build
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible

 Is this expected?


std.variant should be usable in @safe

greensunny12 reported this on 2018-01-03T04:35:28Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=18183
CC List

schveiguy (@schveiguy)

Description

schveiguy (@schveiguy) commented on 2019-10-28T22:23:01Z
Fully agree. Would it be reasonable to have a SafeVariant type that excludes any types which cannot run all the variant code with @safe?

I'm running into this, because I'm trying to make everything in mysql-native safe, and it uses Variant a lot.

It's going to be really hard to make Variant safe "when it needs to be", since you can't overload based on @safe, and you can't detect whether the caller is asking for a safe call in a template.


How can I send a tweet including a hyper link?

Just put it in the status text:
t.statuses.update(
    status="How can I send a tweet including a hyper link? https://github.com/sixohsix/twitter/issues/289")

The link will counted as something like 21 characters for HTTP and something like 22 characters for HTTPS.
Have you tried that? What happened?

Looks closable, @erogol please reopen if necessary


Avoid pulling in C++ library bloat for little gain (i.e. streams, facets, localization)

Sol uses std::to_string, which uses streams internally, which use the whole heavyweight internationalization framework from the standard library. This can inflate the executable considerably, which can be painful on embedded systems.
I think this pulls in way too much code for what it actually does in sol. There should at least be a simple way to avoid it. Perhaps std::to_chars from C++17 can help.

I could probably drop this, but from_chars and to_chars is still lacking good implementation in some places. If I can find a replacement, I'll totally go for this.

Just so we're clear here, std::to_string does not use streams (i.e. std::stringstream and friends). libstdc++v3 uses std::sprintf and friends, as does libc++.

You're right, I put the blame on the wrong thing. Still, sol pulls in the stream stuff somehow. I need to work harder to track down how exactly that happens.

Maybe this could help:  https://github.com/include-what-you-use/include-what-you-use

News: I tracked down a bug that causes most of this bloat:
There's a wrong preprocessor condition around the #include <iostream>. The same mistake happens a few lines down around the 3 lines where std::cerr is used. It causes <iostream> to be always included, even when it isn't used. Just including it, even when not using its content, increases the size of the .text segment by 184664 bytes in my case.
This is apparently because it instantiates std::cout, std::cin and friends, and with it the whole internationalization ulcer gets pulled in.
In the single header sol.hpp v2.20.2 the fix affects two lines: 5790 and 5808, which need to be made the same as everywhere else where SOL_PRINT_ERRORS is used. Quite obvious when you look at it, no need for a patch.

This is already fixed, I just haven't pushed yet because other fixes.

Good. Thanks!


Add a new Level 1 report graph to display WSE, slope, and sinuosity

The Level 1 report could be improved by adding a graph of WSE, slope, and sinuosity. All of these metrics are able to be calculated at the Level 1 stage. After running the "Flowline Points" tool, a user would run the "Gradient" tool to calculate the slope and sinuosity. This plot would display WSE (smoothed?), slope, and sinuosity. It would be added to the Level 1 report after the XS longitudinal profile plot.

Add both WSE and smoothed WSE. See https://github.com/orgs/FluvialGeomorph/projects/1#card-44714313

3db18415b06392aafff748468dbd6a9c5eba5d3f


Implemented test for the type returned by the repository create method

Looks like this actually being addressed in https://github.com/wovalle/fireorm/pull/16. Closing.

Hey @jonesnc, thank you for your pull request!
Yes, unfortunately I already implemented that test in #16, want to do some more testing before merging.
If you still want to collaborate, you can take a look at the roadmap many nice features are coming!

Hi @wovalle! I'm interested in collaborating, I'll look at the roadmap to see what I can help out on.
This project looks really interesting, I'd like to help it get to 1.0.
Thanks!


The search box text is not vertically centered

It happens on a Samsung Galaxy J5. I'll fix it for sure before ending the week if no one else fixed it before :·)

Solved with PR #27

Thanks @ferranpons !

@rocboronat You're welcome! 😉


dockerfile

# Use an official Node.js runtime as the base image
FROM node:17.8.0

# Set the working directory in the Docker image
WORKDIR /usr/src/app

# Clone your GitHub repository into the Docker image
RUN git clone https://github.com/XcmSend/app-v0.0.1.git

# Set the working directory to your React project folder
WORKDIR /usr/src/app/app-v0.0.1

RUN npm install -f

# Expose the port your React app will run on (usually 3000)
EXPOSE 5173

# Define the command to start your React application
CMD ["npm", "run", "dev"]

Thank you for sharing your Dockerfile. I'll do my best to help you with any issues you might encounter.
The Dockerfile you've shared looks generally correct for setting up a Node.js-based project. However, I have a few suggestions and questions:

Package Lock File: Before running npm install, it's advisable to include your package-lock.json file in the Docker context to ensure consistent dependencies across builds. You can add it using COPY package*.json ./ followed by RUN npm install.

Authentication: If your GitHub repository is private or requires authentication, make sure to configure Git credentials within your Docker image to avoid authentication errors during the git clone step. You can use a tool like git-credential-helper for this purpose.

Exposed Port: You mentioned exposing port 5173, but your comment suggests running your React app on port 3000. Ensure that your React app is indeed configured to run on port 5173, or update the EXPOSE statement and your React app accordingly.

Environment Variables: Depending on your React application's configuration, you may need to set environment variables within the Docker image for things like API endpoints or other runtime configuration. You can use the ENV instruction in your Dockerfile for this purpose.

Production Builds: If you plan to use this Dockerfile for production, consider creating a production build of your React application before deploying it. This typically involves running npm run build instead of npm run dev and serving the static files with a lightweight HTTP server like serve.

Please provide more details or context about any specific issues you're facing so that we can offer more targeted assistance. Additionally, consider including any error messages or unexpected behaviors you've encountered.

@SimardeepSingh-zsh if you have a problem with the docker file, open an issue, or check documentation


Meeting nimutes

Please run
git fetch upstream
git merge upstream/master
git checkout -b S2E17

and then make changes

Thx for helping me. I am preparing for sth exciting~


Apache License (2.0)

strip common clause license condition v1.0

Checking with someone knowledgeable about relicensing, I would suggest to ask all contributors for confirmation.
If you're in this list, you've contributed to mark. Could you please respond with "I agree to change the license from Commons-Clause v1.0 to Apache-2.0"?

[ ] @beeme1mr
[ ] @bernd
[ ] @brnv
[ ] @camielwnzl
[ ] @carnei-ro
[ ] @chrisjaimon2012
[ ] @ChrisRu82
[ ] @csoutherland
[ ] @datsickkunt
[ ] @dauc
[ ] @dreampuf
[ ] @eitchugo
[ ] @elgreco247
[ ] @emead-indeed
[ ] @EppO
[ ] @Fethbita
[ ] @GezimSejdiu
[ ] @gmarraff
[ ] @guoweis-work
[ ] @Hi-Fi
[ ] @JAndritsch
[ ] @jay-stillman
[ ] @jcavar
[ ] @jevfok
[ ] @jfreeland
[ ] @joyfulrabbit
[ ] @klauern
[ ] @klysunkin
[ ] @lucasoskorep
[ ] @lukasriegel
[ ] @lukiffer
[ ] @MattyRad
[ ] @mmiranda
[ ] @monti-python
[ ] @nyarly
[ ] @oradwell
[ ] @PhilippReinke
[ ] @princespaghetti
[ ] @prokod
[ ] @recrtl
[ ] @rofafor
[ ] @seletskiy
[ ] @Skeeve
[ ] @snejus
[ ] @stephenpaulger
[ ] @Taldrain
[ ] @teopost
[ ] @tillepille
[ ] @ToruKawaguchi
[ ] @tyler-copilot
[ ] @vpommier
[ ] @wbh1
[ ] @willgorman
[ ] @xiu
[ ] @zackerydev

Pinging the folks separately as I run out of pings in the list.
@vpommier
@wbh1
@willgorman
@xiu
@zackerydev

I agree to change the license from Commons-Clause v1.0 to Apache-2.0
On Tue, Aug 20, 2024, 14:04 Manuel Rüger @.***> wrote:

Checking with someone knowledgeable about relicensing, I would suggest to
ask all contributors for confirmation.
If you're in this list, you've contributed to mark. Could you please
respond with "I agree to change the license from Commons-Clause v1.0 to
Apache-2.0"?

@beeme1mr https://github.com/beeme1mr
@bernd https://github.com/bernd
@brnv https://github.com/brnv
@camielwnzl https://github.com/camielwnzl
@carnei-ro https://github.com/carnei-ro
@chrisjaimon2012 https://github.com/chrisjaimon2012
@ChrisRu82 https://github.com/ChrisRu82
@csoutherland https://github.com/csoutherland
@datsickkunt https://github.com/datsickkunt
@dauc https://github.com/dauc
@dreampuf https://github.com/dreampuf
@eitchugo https://github.com/eitchugo
@elgreco247 https://github.com/elgreco247
@emead-indeed https://github.com/emead-indeed
@EppO https://github.com/EppO
@Fethbita https://github.com/Fethbita
@GezimSejdiu https://github.com/GezimSejdiu
@gmarraff https://github.com/gmarraff
@guoweis-work https://github.com/guoweis-work
@Hi-Fi https://github.com/Hi-Fi
@JAndritsch https://github.com/JAndritsch
@jay-stillman https://github.com/jay-stillman
@jcavar https://github.com/jcavar
@jevfok https://github.com/jevfok
@jfreeland https://github.com/jfreeland
@joyfulrabbit https://github.com/joyfulrabbit
@klauern https://github.com/klauern
@klysunkin https://github.com/klysunkin
@lucasoskorep https://github.com/lucasoskorep
@lukasriegel https://github.com/lukasriegel
@lukiffer https://github.com/lukiffer
@MattyRad https://github.com/MattyRad
@mmiranda https://github.com/mmiranda
@monti-python https://github.com/monti-python
@nyarly https://github.com/nyarly
@oradwell https://github.com/oradwell
@PhilippReinke https://github.com/PhilippReinke
@princespaghetti https://github.com/princespaghetti
@prokod https://github.com/prokod
@recrtl https://github.com/recrtl
@rofafor https://github.com/rofafor
@seletskiy https://github.com/seletskiy
@Skeeve https://github.com/Skeeve
@snejus https://github.com/snejus
@stephenpaulger https://github.com/stephenpaulger
@Taldrain https://github.com/Taldrain
@teopost https://github.com/teopost
@tillepille https://github.com/tillepille
@ToruKawaguchi https://github.com/ToruKawaguchi
@tyler-copilot https://github.com/tyler-copilot
@vpommier
@wbh1
@willgorman
@xiu
@zackerydev

—
Reply to this email directly, view it on GitHub
https://github.com/kovetskiy/mark/pull/487#issuecomment-2299762327, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AILTUGGYCDSTQIXLUQ5JJ4DZSOVOPAVCNFSM6AAAAABMT5AWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZG43DEMZSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

fwiw, my experience with this suggests that the maintainer can change the license at will that will apply to the current state (HEAD) and all contributions thereafter. If the maintainer is a governing body (such as a foundation or steering committee) that body would need to vote to make the change.
If you're talking about retroactively changing the license (for the entire history of the project) the approach you're taking is likely correct.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I'm fine with relicensing my contributions to Apache 2.0.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

@lukiffer My understanding is that every "release" is provided under the then-active license. The upshot is that if the license is changed, consumers can continue to use old copies under the previous license - and since often those licenses allow for derivative works with minimal restrictions, forks to retain the old license are common.
This is a different case, and the difference is intimately tied to how licensing works. Regardless of the license, the right to choose how rights are granted to consumers of a work derives from the copyright - in effect, the creator of a work (usually) holds a legal right on how it's used. A license is a formal statement about that use.
So the trick here is not how the license will bind people, it's who has the right to decide what the license shall be? One argument: the Licensor: Egor Kovetskiy statement in the LICENSE file is an assertion of copyright by Egor, and all us contributors should've understood that when we issued PRs. (I'm fine with that reading, in general, personally.)
But, we might argue that we retain copyright over our contributions, and since there wasn't a clear statement one way or the other, it's a reasonable position to hold. Thus, this (I fear, quixotic) attempt to get agreement from everyone who's ever contributed to the project.
I've contributed to projects that required a GPG-signed "contributor covenant" before they'd accept PRs, to avoid situations like this. A CONTRIBUTING file that asserts something similar might also be useful. (essentially, add a paragraph to CONTRIBUTING that says something like "I transfer whatever copyright I have to my contributions to the project owner(s) by making a pull request")
Like a lot of OSS licensing stuff, most of this hasn't seen a legal test, so who knows what matters.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0
Classification: PROTECTED
From: Manuel Rüger @.>
Date: Wednesday, 21 August 2024 at 9:04 AM
To: kovetskiy/mark @.>
Cc: Camiel Devleeschauwer @.>, Mention @.>
Subject: Re: [kovetskiy/mark] Apache License (2.0) (PR #487)
CAUTION: This email originated from outside of the Westpac Group. Do not click links or open attachments unless you recognise the sender and know the content is safe.
Checking with someone knowledgeable about relicensing, I would suggest to ask all contributors for confirmation.
If you're in this list, you've contributed to mark. Could you please respond with "I agree to change the license from Commons-Clause v1.0 to Apache-2.0"?

@beeme1mrhttps://github.com/beeme1mr
@berndhttps://github.com/bernd
@brnvhttps://github.com/brnv
@camielwnzlhttps://github.com/camielwnzl
@carnei-rohttps://github.com/carnei-ro
@chrisjaimon2012https://github.com/chrisjaimon2012
@ChrisRu82https://github.com/ChrisRu82
@csoutherlandhttps://github.com/csoutherland
@datsickkunthttps://github.com/datsickkunt
@dauchttps://github.com/dauc
@dreampufhttps://github.com/dreampuf
@eitchugohttps://github.com/eitchugo
@elgreco247https://github.com/elgreco247
@emead-indeedhttps://github.com/emead-indeed
@EppOhttps://github.com/EppO
@Fethbitahttps://github.com/Fethbita
@GezimSejdiuhttps://github.com/GezimSejdiu
@gmarraffhttps://github.com/gmarraff
@guoweis-workhttps://github.com/guoweis-work
@Hi-Fihttps://github.com/Hi-Fi
@JAndritschhttps://github.com/JAndritsch
@jay-stillmanhttps://github.com/jay-stillman
@jcavarhttps://github.com/jcavar
@jevfokhttps://github.com/jevfok
@jfreelandhttps://github.com/jfreeland
@joyfulrabbithttps://github.com/joyfulrabbit
@klauernhttps://github.com/klauern
@klysunkinhttps://github.com/klysunkin
@lucasoskorephttps://github.com/lucasoskorep
@lukasriegelhttps://github.com/lukasriegel
@lukifferhttps://github.com/lukiffer
@MattyRadhttps://github.com/MattyRad
@mmirandahttps://github.com/mmiranda
@monti-pythonhttps://github.com/monti-python
@nyarlyhttps://github.com/nyarly
@oradwellhttps://github.com/oradwell
@PhilippReinkehttps://github.com/PhilippReinke
@princespaghettihttps://github.com/princespaghetti
@prokodhttps://github.com/prokod
@recrtlhttps://github.com/recrtl
@rofaforhttps://github.com/rofafor
@seletskiyhttps://github.com/seletskiy
@Skeevehttps://github.com/Skeeve
@snejushttps://github.com/snejus
@stephenpaulgerhttps://github.com/stephenpaulger
@Taldrainhttps://github.com/Taldrain
@teoposthttps://github.com/teopost
@tillepillehttps://github.com/tillepille
@ToruKawaguchihttps://github.com/ToruKawaguchi
@tyler-copilothttps://github.com/tyler-copilot
@vpommier
@wbh1
@willgorman
@xiu
@zackerydev

—
Reply to this email directly, view it on GitHubhttps://github.com/kovetskiy/mark/pull/487#issuecomment-2299762327, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARDQVYSCWDFFD7KNYENG4RTZSOVOPAVCNFSM6AAAAABMT5AWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZG43DEMZSG4.
You are receiving this because you were mentioned.Message ID: @.***>
The contents of this email and any attachments are confidential and may be legally privileged. If you are not the intended recipient please advise the sender immediately and delete the email and attachments. Any use, dissemination, reproduction or distribution of this email and any attachments by anyone other than the intended recipient is prohibited.
Classification: PROTECTED

I agree👍🏻

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0.
Thank you!

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0
That being said, why the switch to a license with commercial use?

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

Responding to a few comments here:

fwiw, my experience with this suggests that the maintainer can change the license at will that will apply to the current state (HEAD) and all contributions thereafter. If the maintainer is a governing body (such as a foundation or steering committee) that body would need to vote to make the change.
If you're talking about retroactively changing the license (for the entire history of the project) the approach you're taking is likely correct.

To my knowledge, a license change to a more permissive model (which Apache-2.0 over Commons Clause + Apache-2.0 is) is something that all copyright holders would need agree to. Previous releases will still be under Commons Clause.

@lukiffer My understanding is that every "release" is provided under the then-active license. The upshot is that if the license is changed, consumers can continue to use old copies under the previous license - and since often those licenses allow for derivative works with minimal restrictions, forks to retain the old license are common.
This is a different case, and the difference is intimately tied to how licensing works. Regardless of the license, the right to choose how rights are granted to consumers of a work derives from the copyright - in effect, the creator of a work (usually) holds a legal right on how it's used. A license is a formal statement about that use.
So the trick here is not how the license will bind people, it's who has the right to decide what the license shall be? One argument: the Licensor: Egor Kovetskiy statement in the LICENSE file is an assertion of copyright by Egor, and all us contributors should've understood that when we issued PRs. (I'm fine with that reading, in general, personally.)
But, we might argue that we retain copyright over our contributions, and since there wasn't a clear statement one way or the other, it's a reasonable position to hold. Thus, this (I fear, quixotic) attempt to get agreement from everyone who's ever contributed to the project.
I've contributed to projects that required a GPG-signed "contributor covenant" before they'd accept PRs, to avoid situations like this. A CONTRIBUTING file that asserts something similar might also be useful. (essentially, add a paragraph to CONTRIBUTING that says something like "I transfer whatever copyright I have to my contributions to the project owner(s) by making a pull request")
Like a lot of OSS licensing stuff, most of this hasn't seen a legal test, so who knows what matters.

Asking all contributors to agree to a license change is the best option, because that allows contributors to raise concerns and make suggestions. We could fall back on the option that @kovetskiy is the Licensor, if needed. I would suggest doing that only after evaluating other options.

That being said, why the switch to a license with commercial use?
Common Clause is not Open Source software, which is why some distributions can't package it, see: https://github.com/kovetskiy/mark/issues/295

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

Thanks for the quick responses everyone!
Responding to a few comments here:

fwiw, my experience with this suggests that the maintainer can change the license at will that will apply to the current state (HEAD) and all contributions thereafter. If the maintainer is a governing body (such as a foundation or steering committee) that body would need to vote to make the change.
If you're talking about retroactively changing the license (for the entire history of the project) the approach you're taking is likely correct.

To my knowledge, a license change to a more permissive model (which Apache-2.0 over Commons Clause + Apache-2.0 is) is something that all copyright holders would need agree to. Previous releases will still be under Commons Clause.

@lukiffer My understanding is that every "release" is provided under the then-active license. The upshot is that if the license is changed, consumers can continue to use old copies under the previous license - and since often those licenses allow for derivative works with minimal restrictions, forks to retain the old license are common.
This is a different case, and the difference is intimately tied to how licensing works. Regardless of the license, the right to choose how rights are granted to consumers of a work derives from the copyright - in effect, the creator of a work (usually) holds a legal right on how it's used. A license is a formal statement about that use.
So the trick here is not how the license will bind people, it's who has the right to decide what the license shall be? One argument: the Licensor: Egor Kovetskiy statement in the LICENSE file is an assertion of copyright by Egor, and all us contributors should've understood that when we issued PRs. (I'm fine with that reading, in general, personally.)
But, we might argue that we retain copyright over our contributions, and since there wasn't a clear statement one way or the other, it's a reasonable position to hold. Thus, this (I fear, quixotic) attempt to get agreement from everyone who's ever contributed to the project.
I've contributed to projects that required a GPG-signed "contributor covenant" before they'd accept PRs, to avoid situations like this. A CONTRIBUTING file that asserts something similar might also be useful. (essentially, add a paragraph to CONTRIBUTING that says something like "I transfer whatever copyright I have to my contributions to the project owner(s) by making a pull request")
Like a lot of OSS licensing stuff, most of this hasn't seen a legal test, so who knows what matters.

Asking all contributors to agree to a license change is the best option, because that allows contributors to raise concerns and make suggestions. We could fall back on the option that @kovetskiy is the Licensor, if needed. I would suggest doing that only after evaluating other options.

That being said, why the switch to a license with commercial use?

Common Clause is not Open Source software, which is why some distributions can't package it, see: #295

Really appreciate the clarifications!

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0
Il gio 22 ago 2024, 00:32 Matt Radford @.***> ha
scritto:

I agree to change the license from Commons-Clause v1.0 to Apache-2.0
—
Reply to this email directly, view it on GitHub
https://github.com/kovetskiy/mark/pull/487#issuecomment-2303176967, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AATUITLGMRN3Y3CO557KP3TZSUIQ7AVCNFSM6AAAAABMT5AWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBTGE3TMOJWG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0.
I think this is a good change for Mark too, more frequently used licenses are often easier for people to contribute to during their working time.
I'm also happy for copyright for my past commits to be assigned to the project or its owner(s).

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

Thanks again for all the responses!
Trying to ping the folks who have not responded yet here. :)
@chrisjaimon2012
@datsickkunt
@dauc
@emead-indeed  / @emead (I believe this is the non-work account)
@guoweis-work / @guoweis (same here)
@jay-stillman
@jevfok
@klysunkin
@mmiranda
@tyler-copilot
@vpommier

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

El 25 ago 2024, a las 20:30, Manuel Rüger @.***> escribió:
Thanks again for all the responses!
Trying to ping the folks who have not responded yet here. :)
@chrisjaimon2012 https://github.com/chrisjaimon2012
@datsickkunt https://github.com/datsickkunt
@dauc https://github.com/dauc
@emead-indeed https://github.com/emead-indeed / @emead https://github.com/emead (I believe this is the non-work account)
@guoweis-work https://github.com/guoweis-work / @guoweis https://github.com/guoweis (same here)
@jay-stillman https://github.com/jay-stillman
@jevfok https://github.com/jevfok
@klysunkin https://github.com/klysunkin
@mmiranda https://github.com/mmiranda
@tyler-copilot https://github.com/tyler-copilot
@vpommier https://github.com/vpommier
—
Reply to this email directly, view it on GitHub https://github.com/kovetskiy/mark/pull/487#issuecomment-2309039905, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT5P4YCPZQIP5XLVW6J2L3ZTJSJVAVCNFSM6AAAAABMT5AWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGAZTSOJQGU.
You are receiving this because you were mentioned.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

I agree to change the license from Commons-Clause v1.0 to Apache-2.0

From the contributors who haven't responded, I reviewed the changes they made.

Name
Contributions
Classification

@datsickkunt
https://github.com/kovetskiy/mark/commits?author=datsickkunt
Doc, 7 lines

@elgreco247
https://github.com/kovetskiy/mark/commits?author=elgreco247
Code, 4 lines

@emead-indeed
https://github.com/kovetskiy/mark/commits?author=emead-indeed
Code, 13 lines

@jay-stillman
https://github.com/kovetskiy/mark/commits?author=jay-stillman
Code, 6 lines

@tyler-copilot
https://github.com/kovetskiy/mark/commits?author=tyler-copilot
Code, 9 lines

According to GNU, we can consider changes with less than 15 lines of code as not legally significant for copyright and thus the license change.
I encourage everyone mentioned to still respond and agree to the change.
I will proceed on September 6th 2024 with the PR, if there are no further responses.

I agree to change the license from Commons-Clause v1.0 to Apache-2.0 for all code committed towards Mark

Thanks to everyone for their contributions and for their quick support with the relicensing!


New resetted Android 6.0.1 can't continue on "Risk identification"

On a newly resetted Android 6.0.1, when Playstore is updated and app is installed, on appstart you can confirm ""privacy statement", but on "Risiko-Ermittlung Aktivieren" the button is pressed but nothing happens - no feedback.
After a while URSACHE: 9002 Etwas ist schiefgelaufen" apears with details:
k0.b.a.a.c.k.k. Missing c {name=nearby_exposure_notification,version=2}
at k0.b.a.a.k.l.e.handleMessage(com.google.android.gms:play-services-base@@<IP_ADDRESS>)
...
android.os.HandlerThread.run(HandlerThread.java:61)

In background I see notification:
"Google play-Dienste aktualisieren: Corona-Warn wird nur ausgeführt wenn Du die google Play-Dienste aktualisierst", but pressing on this notifiaction shows playservices but nothing to update there.
So it seems it updates somehow in background but the app can't use these new functions instantly
Perhaps a simple message (not error) should be shown In-App too, so that enduser knows what 9002 means and one has to update playstore/Play-Services prior to continue and perhaps close the app at this point.

Android 6.0.1
wifi activated
bluetooth off (has not been asked by app at this point)
location service off (has not been asked by app at this point)

Update: After a while without updateing manually and NOT closing the app (just going back-and-forth) , the button "Risiko-Ermittlung Aktivieren" works and the next message "Benachrichtigungen zu mögl. Begegnungen...." apears.

We'll note that as a bug but also as an example for more helpful error messages (linking #472 )

Hi, thanks for your issue report! Does the issue still persist? Can you replicate?

Well as I wrote, it was a factoryresetted 6.0.1  phone, that just updated the Google services after/while first start of the app. So replication is not really what I(!) want atm :)
And as I wrote in "update:", it worked after a while without leaving the app.
I guess it was due to Google service not already been updated, or app did not straight recognise the already available APIs. Both is also mentioned in other threads.
My recommendation would be to check for API availability straight at app-start perhaps even prior to showing privacy policy (at least NOT as late as on pressing the RISK-Button)
Then in errorcase give the enduser a meaningful message to update the g-servcies, perhaps even link to the updateable play services app and close the CW-app afterwards or have the API check done better, to manage a parallel-install of services update in background.
My case (factoryreset) could be rare but
Well as I wrote, it was a factoryresetted 6.0.1  phone, that just updated the Google services after/while first start of the app. So replication is not really what I(!) want atm :)
And as I wrote in "update:", it worked after a while without leaving the app.
I guess it was due to Google service not already been updated, or app did not straight recognise the already available APIs. Both is also mentioned in other threads.
My recommendation would be to check for API availability straight at app-start perhaps even prior to showing privacy policy (at least NOT as late as on pressing the RISK-Button)
Then in errorcase give the enduser a meaningful message to update the g-servcies, perhaps even link to the updateable play services app and close the CW-app afterwards or have the API check done better, to manage a parallel-install of services update in background.
My case (factoryreset on 6.0.1) could be rare but service not updated could be the case quite often.
That's my 2cents on it.

Btw. My stacktrace looked very similar top this one https://user-images.githubusercontent.com/29229062/84778555-74309780-afe3-11ea-975e-9e7511add8fc.jpeg
from that issue
https://github.com/corona-warn-app/cwa-app-android/issues/543
But my root cause line was 61 not 65 and I always had an google account in that phone.

We hope that this issue will fade out as new devices will automatically already include the GMS required to run the App. This should thus only be temporary. We will not be able to fix this bug on our own as the issue relies on GMS Updates that we do not control.
As such I will close the issue.


tidy up the PR description

move remaining work to an issue, rather than the PR description

added to https://github.com/guardian/csnx/issues/1326


Generate field

Replace hardcoded field with generated one.

Basically, I want to use Edge to solve this problem. Current Tile is cut of the four (possible) edges. This helps to construct field with partial edges, but it is difficult to build normal ones. Instead, if we use Edge, which is "connection" between tiles, it would be more easy to define original structure of the field. Then, we can convert this field of Edges to field of Tiles, where we can rotate tiles.

I need to save some ideas, so I will do it here.

pairwise/unpairwise. Will help convert edges to tiles.
plainField/plainRow. Another solution to convert edges to tiles.
Use random. For random place of edges.

May be helpful:
https://pursuit.purescript.org/packages/purescript-unfoldable/6.0.0/docs/Data.Unfoldable1#v:replicate1A


Openshift GitOps for springpetclinic-dev stucks in wait sync up of ArgoCD

GROUP               KIND        NAMESPACE      NAME              STATUS     HEALTH   HOOK  MESSAGE
                    Service     devsecops-dev  spring-petclinic  Synced     Healthy
apps                Deployment  devsecops-dev  spring-petclinic  OutOfSync  Healthy
route.openshift.io  Route       devsecops-dev  spring-petclinic  Synced
time="2021-11-03T08:34:01Z" level=fatal msg="Operation has completed with phase: Running"

Due to the Openshift GitOps 1.3, the operation is stuck because of the AutoSync feature. Disabling the autosync seems to be working again the full pipeline

Fixed in https://github.com/rcarrata/devsecops-demo/commit/ebc30f302f1198b65017406a2145fa1af0e0f793 in develop branch. Ready to test and to PR to master.

Tested and working. Closing the Issue


Changed ACL

what

Removes bucket ACL from s3_bucket resource
Adds public access block resource
Adds object ownership control resource

why

Module no longer works

references
closes #84

@woz5999 @jamengual Can I get a review on this when you guys have a chance?

Hey @JohnShortland i'm looking into what's up with the checks

Hey @JohnShortland i'm looking into what's up with the checks

Sounds good, re-ran the readme steps but no changes this time.


Deprecation of body-parser.md

This body-parser is already deprecated. Use  app.use(express.json()); instead

The body-parser module is in no way deprecated. If it was, it would be clearly stated in the readme. The express.json is just a convient short cut to using the module directly, which may be necessary if you need a different version.


Add documentation

Added documentations for Dataset and RasterBand, and fixed cfg() for some of the open_ex flags (it wasn't enabled on gdal 3.0 and above).
Open question:  how to refer to GDAL documentations from our docs?  For many functions, the relevant docs are doxygen links (eg. GDALOpenEx) which could break if it is regenerated upstream (and annoying to update).

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

cool!more  documentation is always good. I don't have an answer to the doxygen links. I guess we could link the doxygen startpage and leave the user to find the method?

Broken links lead to the start page (via a 404) anyway;  hopefully the text of the link tells the user what to search for.  Let's take a call when any of these links break.

Excellent - Thank you @rmanoka!


Add retry on k8s object collisions

Added
retryErr := retry.RetryOnConflict(retry.DefaultRetry, func() error {
		// Retrieve the latest version of Deployment before attempting update
		// RetryOnConflict uses exponential backoff to avoid exhausting the apiserver
	})

https://github.com/kubernetes/client-go/blob/master/examples/create-update-delete-deployment/main.go#L118
To Every object update on the code.

Done https://github.com/k8s-nativelb/k8s-nativelb/pull/8


Overlay network broken when outside network mtu is smaller than default (1450)

Symptoms
Could not figure out why overlay network just did not work. There was some connectivity, but transiently nothing worked.
Related Issues
As far as I understand, these issues are likely completely the same if not only related:
https://github.com/moby/moby/issues/41775
https://github.com/moby/moby/issues/43551
https://github.com/moby/moby/issues/43359
https://github.com/moby/moby/issues/16841
https://stackoverflow.com/questions/52409012/docker-swarm-mode-routing-mesh-not-working-with-wireguard-vpn
https://www.reddit.com/r/docker/comments/u7tq2e/issue_with_docker_overlay_network_not_connecting/
Setup
Two machines A and B connected over a wireguard link with mtu of 1350. Wireguard is proven to be correctly configured and works perfectly for any other access.
A is swarm manager and B is worker.
The only thing deployed is a basic swarmpit setup https://dockerswarm.rocks/swarmpit/.
First clue: swarmpit was unable to receive statistics from B to A. The http post would very slowly (~10min) timeout.
Actual Problem
Clearly the overlay routing mesh does not work. A simple test is curl localhost:<port of swarmpit> on machine B which I used.
According to https://github.com/moby/libnetwork/blob/master/docs/images/network_flow_overlay.png and empirically the connection will route:

B - docker_gwbridge
B - netns ingress_sbox
B - wg0
A - wg0
A - netns <random hash for the routing netns>
A - netns <container>

Since it was HTTP, the request was 80 bytes and the reply was 3500 bytes. The reply had to be fragmented. A tcpdump dump in <random hash for the routing netns> of eth0 (<IP_ADDRESS>/24) revealed:
tcpdump: listening on eth0, link-type EN10MB (Ethernet), snapshot length 262144 bytes
19:17:28.188672 IP (tos 0x0, ttl 63, id 5141, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.57910 > <IP_ADDRESS>.8090: Flags [F.], cksum 0x0029 (correct), seq 616815329, ack<PHONE_NUMBER>, win 128, options [nop,nop,TS val 303267193 ecr 28263940], length 0
19:17:28.189099 IP (tos 0x0, ttl 64, id 14358, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.57910: Flags [F.], cksum 0x8d38 (correct), seq 2721, ack 1, win 502, options [nop,nop,TS val 28290269 ecr 303267193], length 0
19:17:28.255852 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto TCP (6), length 40)
    <IP_ADDRESS>.57910 > <IP_ADDRESS>.8090: Flags [R], cksum 0x9a48 (correct), seq 616815330, win 0, length 0
19:17:29.130169 IP (tos 0x0, ttl 63, id 48126, offset 0, flags [DF], proto TCP (6), length 60)
    <IP_ADDRESS>.58002 > <IP_ADDRESS>.8090: Flags [S], cksum 0x991e (correct), seq<PHONE_NUMBER>, win 65535, options [mss 1460,sackOK,TS val 303268135 ecr 0,nop,wscale 9], length 0
19:17:29.130201 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 60)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [S.], cksum 0x1382 (correct), seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 64308, options [mss 1410,sackOK,TS val 28291210 ecr 303268135,nop,wscale 7], length 0
19:17:29.195983 IP (tos 0x0, ttl 63, id 48127, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.58002 > <IP_ADDRESS>.8090: Flags [.], cksum 0x3c8f (correct), seq 1, ack 1, win 128, options [nop,nop,TS val 303268201 ecr 28291210], length 0
19:17:29.196012 IP (tos 0x0, ttl 63, id 48128, offset 0, flags [DF], proto TCP (6), length 131)
    <IP_ADDRESS>.58002 > <IP_ADDRESS>.8090: Flags [P.], cksum 0x78e1 (correct), seq 1:80, ack 1, win 128, options [nop,nop,TS val 303268201 ecr 28291210], length 79
19:17:29.196022 IP (tos 0x0, ttl 64, id 10157, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], cksum 0x3a88 (correct), seq 1, ack 80, win 502, options [nop,nop,TS val 28291276 ecr 303268201], length 0
19:17:29.203989 IP (tos 0x0, ttl 64, id 10158, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], cksum 0x9ccb (correct), seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28291284 ecr 303268201], length 1398
19:17:29.203992 IP (tos 0x0, ttl 64, id 10159, offset 0, flags [DF], proto TCP (6), length 1374)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [P.], cksum 0xba84 (correct), seq 1399:2721, ack 80, win 502, options [nop,nop,TS val 28291284 ecr 303268201], length 1322
19:17:29.204011 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum da41 (->dbf4)!)
        IP (tos 0x0, ttl 64, id 10158, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28291284 ecr 303268201], length 1398
19:17:29.204017 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum 4105 (->3921)!)
        IP (tos 0x0, ttl 64, id 10159, offset 0, flags [DF], proto TCP (6), length 1374)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [P.], seq 1399:2721, ack 80, win 502, options [nop,nop,TS val 28291284 ecr 303268201], length 1322
19:17:29.346302 IP (tos 0x0, ttl 64, id 10160, offset 0, flags [DF], proto TCP (6), length 1374)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [P.], cksum 0xb9f6 (correct), seq 1399:2721, ack 80, win 502, options [nop,nop,TS val 28291426 ecr 303268201], length 1322
19:17:29.346322 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum 3f05 (->3921)!)
        IP (tos 0x0, ttl 64, id 10160, offset 0, flags [DF], proto TCP (6), length 1374)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [P.], seq 1399:2721, ack 80, win 502, options [nop,nop,TS val 28291426 ecr 303268201], length 1322
19:17:29.636280 IP (tos 0x0, ttl 64, id 10161, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], cksum 0x9b1b (correct), seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28291716 ecr 303268201], length 1398
19:17:29.636351 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum d841 (->dbf4)!)
        IP (tos 0x0, ttl 64, id 10161, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28291716 ecr 303268201], length 1398
19:17:30.196303 IP (tos 0x0, ttl 64, id 10162, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], cksum 0x98eb (correct), seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28292276 ecr 303268201], length 1398
19:17:30.196333 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum d841 (->dbf4)!)
        IP (tos 0x0, ttl 64, id 10162, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28292276 ecr 303268201], length 1398
19:17:31.289626 IP (tos 0x0, ttl 64, id 10163, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], cksum 0x94a5 (correct), seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28293370 ecr 303268201], length 1398
19:17:31.289657 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto ICMP (1), length 576)
    <IP_ADDRESS> > <IP_ADDRESS>: ICMP <IP_ADDRESS> unreachable - need to frag (mtu 1300), length 556 (wrong icmp cksum d841 (->dbf4)!)
        IP (tos 0x0, ttl 64, id 10163, offset 0, flags [DF], proto TCP (6), length 1450)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [.], seq 1:1399, ack 80, win 502, options [nop,nop,TS val 28293370 ecr 303268201], length 1398
19:17:32.078835 IP (tos 0x0, ttl 63, id 48129, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.58002 > <IP_ADDRESS>.8090: Flags [F.], cksum 0x30ba (correct), seq 80, ack 1, win 128, options [nop,nop,TS val 303271084 ecr 28291276], length 0
19:17:32.079120 IP (tos 0x0, ttl 64, id 10164, offset 0, flags [DF], proto TCP (6), length 52)
    <IP_ADDRESS>.8090 > <IP_ADDRESS>.58002: Flags [F.], cksum 0x1960 (correct), seq 2721, ack 81, win 502, options [nop,nop,TS val 28294159 ecr 303271084], length 0
19:17:32.149975 IP (tos 0x0, ttl 63, id 0, offset 0, flags [DF], proto TCP (6), length 40)
    <IP_ADDRESS>.58002 > <IP_ADDRESS>.8090: Flags [R], cksum 0x93ea (correct), seq<PHONE_NUMBER>, win 0, length 0

Now as I understand the checksum fail will cause the packet that tells at what mtu to fragment to be dropped [correct me if I am wrong]. Which then causes TCP packets to be retried endlessly until the connection fails.

Setting mtu of eth0 @ <random hash for the routing netns> to be equal to the wg0 mtu entirely fixes the problem. This of course needs to be done on every machine for every network that goes over the vxlan.
Notes
The way I found  <random hash for the routing netns> is by running for f in /run/docker/netns/*; do echo $f:; nsenter --net=$f ip a; done and finding the ip range of the target service (<IP_ADDRESS>/24 in my case).
A /etc/docker/daemon.json solution of
{
  "mtu": 1350
}

seems to have no effect on swarm.
Seems same problem has been an issue in docker-compose a long time ago: https://mlohr.com/docker-mtu/
General inquiry
If docker / docker swarm could out-of-the-box work with different mtus (even such as checking outbound network interfaces and using the max(config value, min(interfaces' mtu)) would be nice, or at least for the config value to work. Because there is too many other issues open such as this and it's definitely non-trivial to figure out (if you don't know what you're looking for).
I really feel this should just work out of the box (just like all other internet infrastructure).

Code from here is mostly moved to moby/moby (look #2665 ) and that would be probably better place to report this as well.
However when using non-default MTU it is critical to make sure that it gets used on all interfaces. I don't have wireguard  on my lab so was not able to reproduce issue however I managed to get smaller MTU to all interfaces so documenting it to here (new environment setup).

A /etc/docker/daemon.json solution of
{
  "mtu": 1350
}

seems to have no effect on swarm.

This affects only default bridge and containers which are using it.
First of all you need modify docker_gwbridge on all nodes by running these:
docker network rm docker_gwbridge
docker network create --driver bridge --opt com.docker.network.driver.mtu=1350 docker_gwbridge

Then you initiate swarm and modify ingress
docker network rm ingress
docker network create --driver overlay --opt com.docker.network.driver.mtu=1350 ingress

Finally you create test network and test service to it which start one container to all nodes:
docker network create --driver overlay --opt com.docker.network.driver.mtu=1350 test
docker service create --name test --network test --mode global bash sleep infinity

Now you can start shell inside of those container and verify that MTU values are correct:
$ docker exec -it db06ebe1eb83 bash
bash-5.1# ifconfig
eth0      Link encap:Ethernet  HWaddr 02:42:0A:00:02:05
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP BROADCAST RUNNING MULTICAST  MTU:1300  Metric:1
          RX packets:1 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:54 (54.0 B)  TX bytes:0 (0.0 B)

eth1      Link encap:Ethernet  HWaddr 02:42:AC:13:00:02
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP BROADCAST RUNNING MULTICAST  MTU:1350  Metric:1
          RX packets:10 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:876 (876.0 B)  TX bytes:0 (0.0 B)

lo        Link encap:Local Loopback
          inet addr:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

You can also see that eth0 MTU value is actually 1300 instead of 1350. That is because VXLAN header size is 50 bits.

I really feel this should just work out of the box (just like all other internet infrastructure).

Agreed. However I would like to understand how you actually configure wireguard to understand what would be best way to handle this?


[FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

What is the purpose of the change
Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics to avoid infinite waiting in case of a source reporting bad metrics value
Brief change log
use flink.core.testutils.CommonTestUtils.waitUtil(condition, timeout, delay, message) instead of flink.runtime.testutils.CommonTestUtils.waitUntilCondition(condition) in SourceTestSuiteBase#testSourceMetrics
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

linking to the timeout discussion on the other PR: #21037 (comment)

@zentol you wanted to avoid using a timeout. Do you want that I change the timeout to a number of retries as proposed above ?

@flinkbot run azure

@flinkbot run azure

@zentol what do you want that we do with this PR?
Having no safe guard in the test waiting loop seems dangerous to me: during the implementation of a source, it could happen that the metrics counter is incorrect leading to infinite wait. IMHO I think we should merge this PR or with an alternative stop condition if we don't want the timeout.

@zentol friendly ping

@MartijnVisser, I'm resuming this PR that has been stale for a log time.
Do you have any thoughts about the discussion here ?

@tzulitai Also any thoughts on this one?

@tzulitai WDYT ?

@zentol what do you want that we do with this PR? Having no safe guard in the test waiting loop seems dangerous to me: during the implementation of a source, it could happen that the metrics counter is incorrect leading to infinite wait. IMHO I think we should merge this PR or with an alternative stop condition if we don't want the timeout.

@tzulitai I'm a bit confused here, I know that we are trying to avoid timeouts as much as possible but in this particular case a timeout is still better than an infinite waiting loop in case of incorrect metrics. WDYT ?

Closing because is goes against the no timeout current philosophy :shrug:


Cache the latest ACME account private key hash on Issuer status

In https://github.com/cert-manager/cert-manager/pull/5949 we fixed an issue where after an ACME issuer's account key gets changed and points to a different account, the account URL is not updated on issuer status, see https://github.com/cert-manager/cert-manager/issues/5948
The current fix is to store the last verified key hash in the in-memore issuer registry. When the issuers control loop runs, it retrieves the account key from a cluster Secret and compares with the hash in registry. If the hash is not available in registry or is different, the account gets re-verified.
This means an extra call to ACME server for each issuer every time cert-manager controller starts up and the in-memory registry is empty.
We could improve this by storing the latest private key hash on issuer status same as we already do with latest known registered email.
The implementation would be roughly along the lines of:

add a new ACME issuer status field to track the private key hash here and here, see also https://cert-manager.io/docs/contributing/crds/
Set the new status field to the key hash when needed, similar to how we do it with last registered email
Change the functionality that verifies that key hash is the same to use the status field instead
(?) don't store the hash in memory
add tests as needed
test manually that it works as expected (observe the calls to ACME with --v=5 flag to cert-manager controller

/kind cleanup

I'm labelling this as a good first issue, the scope of what needs to be done is quite clear, but whoever picks this up should have enough Go knowledge to understand the issuer setup code works https://github.com/cert-manager/cert-manager/blob/master/pkg/issuer/acme/setup.go and have some idea how to add new test case if needed here https://github.com/cert-manager/cert-manager/blob/master/pkg/issuer/acme/setup_test.go

I would like to work on this issue, please.

/assign @vidarno
We've some contributing docs here https://cert-manager.io/docs/contributing/
Do reach out if you run into issues

This was implemented in #6006


Add command line wrapper and argument processor

Add command line wrapper so that user can run a specific script instead of running node index.js command
Add argument processor that is compatible with 1.0 bridge, e.g. --port, --address, --retry_startup_delay, --fragment_timeout and etc.

Started to work on this one.

https://github.com/RobotWebTools/ros2-web-bridge/commit/d77c77b18ea49011b3cb52569a7bc12668f938e4 has landed, so close this issue.


JSFiddle throws: Uncaught RangeError: Maximum call stack size exceeded

When you type in some text in the AirMode example, change one char to bold and click outside the editor we get : Uncaught RangeError: Maximum call stack size exceeded

Sorry I forgot to release new version. I will release it soon.
I fixed in #62

Yeah !


Securing Your Clusters = missing cert-manager.yaml file

https://www.kubeflow.org/docs/gke/private-clusters/
It seems that this documentation is not compatible with KFv1. Following the instructions step 7 under Deploy Kubeflow with Private GKE
Remove components which are not useful in private clusters:
cd ${KF_DIR}/kustomize
kubectl delete -f cert-manager.yaml
There is not such a file -> cert-manager.yaml

/assign @zhenghuiwang
Assigning this to @zhenghuiwang as he's working on an update to the docs for private GKE clusters.


Validate both in and notin the same way

This commit fixes the following error
Model.search_for("id !^ (2,3)") fails with
ScopedSearch::QueryNotSupported: Value '2,3' is not valid for field 'id'
It does it by splitting value for both in and not in

Could we get a test for this?

Could we get a test for this?

Updated


Barcode types and data returns undefined

Describe the bug
When I try to get barcode type and data it returns undefined.
To Reproduce
Steps to reproduce the behavior:
  const [scanned, setScanned] = useState(false);
  const handleBarCodeScanned = ({ type, data }) => {
    console.log('Type: ' + type + '\nData: ' + data)
  };

 <CameraScreen
        scanBarcode={true}
         onReadCode={scanned ? undefined : handleBarCodeScanned}
          showFrame={true}
          laserColor="red"
          frameColor="white"
          />
  {scanned && <Button title={'Scan again?'} onPress={() => setScanned(false)} />}

Expected behavior
should return barcode type and barcode itself

https://github.com/teslamotors/react-native-camera-kit/pull/633
I have added codeFormat please test and let know if any issues


Add assets and use assets folder

The assets should be a part of the repo, and be placed in its own directory. Only superficially tested watermark and coverphoto commands.
Resolves #15, resolves #16

Tested a multitude of combinations for commands watermark and coverphoto. Functionalilty is intact. Merging into master branch.


Inconsistent gene expression positions before and after integration

Hi，I used software paste(paste.center_align) to integrate two identical slices，then, the expression of a certain gene before and after integration was plotted, and it was found that the expression position of this gene was inconsistent.
The above figure shows the result of a gene before integration, while the following figure shows the result of a gene after integration.

When you say identical slices, how exactly are they identical. It looks like the gene expression is slightly different? And when you say inconsistent, what do you mean by that. What do you expect?

identical slices means: exactly the same without any differences, I'll take a slice and integrate it.
inconsistent：there is a significant difference in the expression position of a certain gene between the original section and the integrated section.

So PASTE center align computes a Non-negative matrix factorization (NMF) which is why there should be a difference, although in this case it is surprising it is quite different. I'm not sure off the top of my head what could be causing this. Have you tried looking at the mapping between slices to see if it is consistent?

ok, I'll give it a try.
Thank you.


Website URL in MELPA meta info is wrong

I think you meant matrix-emacs-theme not matrix-theme-emacs.

@kamoii Thank you, I've messed this up in the commentary header. Should be updated with the correcct URL when Melpa pulls from origin/main.


feat: move elements outside of label

There is a question added to #352 relating to this PR.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (79bd6f6) compared to base (e29e11b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.6      #387   +/-   ##
=============================================
  Coverage       100.00%   100.00%
=============================================
  Files               44        44
  Lines             1005      1005
  Branches           391       391
=============================================
  Hits              1005      1005

Impacted Files
Coverage Δ

src/multiUpload/MultiUpload.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix ReactMentions props and fix tests that stop local linting

💬 Description
Newer ReactMentions have changed what props you need to pass to what component, this fixes that.
I also had errors in these tests when linking locally, so i've just fixed the imports for those too

How come the afterEach has to be imported when it doesn't look to be used?

@webknit it is used 😅 https://github.com/Bynder/gathercontent-gather-ui/pull/1298/files#diff-14214aaac303045d2a034883a558bd72326ec00e0698886dfe25e3eb7cd6e4f0R22 same for all the files i've imported it in. used to be globally available when we had jest, but no longer with vitest. thats why its suddenly an issue


Code formatting and .editorconfig

A recent pull request and a comment about spaces versus tabs had me thinking about establishing a standard editor configuration for this project.
http://editorconfig.org/ outlines the file format for defining such a standard. I was thinking of at the very least using spaces, four to a tab, for indenting purposes. Another idea was to enforce the trimming of trailing whitespace.
I'm conflicted on the former idea since the project seems to use spaces and tabs almost evenly. A subsequent update could be done to convert to all of one or the other for consistency.
Any opinions on this?

I wouldn't enforce strict rules as it can turn people off from submitting pull requests. However we can still accept some standard formatting and adjust pull request whitespace after it has been merged. Using 4 spaces instead of a tab is fine with me.

With the provided file, editors which support editorconfig should automatically insert spaces instead of tabs, strip trailing whitespace, and ensure that each file ends with a newline.


Get "title" of current route

Hi
is possible get the "title" (the result of breadcrumb inside map) for the current route?

Hi @TutoDS 👋 - I'm not sure I understand what you're trying to do. Could you please elaborate a little more, or maybe a code example?

I have /admin route, but I want change Admin to Dashboard on breadcrumbs.
Any way to do that?

Hi @TutoDS, sure, but you need to dive into the Advanced section of the docs. From what I understand so far there are at least 2 ways to do this:

If you only display breadcrumbs on a small number of pages, then maybe this will suffice:

// define custom breadcrumbs for certain routes.
// breadcumbs can be components or strings.
const routes = [
  { path: '/admin', breadcrumb: 'Dashboard' },
];

// map & render your breadcrumb components however you want.
const Breadcrumbs = () => {
  const breadcrumbs = useBreadcrumbs(routes);
  // [...]
}

If you are using<EMAIL_ADDRESS>and a RouteObject, you can specify the breadcrumbs directly in the RouteObject and pass that into the breadcrumbs hook, like so:

const routeObject = [
  { path: '/admin', element: <AdminPage />, breadcrumb: 'Dashboard' },
  // ...rest of your routes
];

const Routes = () => {
  const element = useRoutes(routeObject);

  //... return your layout which renders {element} at some point
};

const Breadcrumbs = () => {
  const breadcrumbs = useBreadcrumbs(routeObject);
  // [...]
}

Note how routeObject is passed to both hooks, saving some boilerplate code. I went with this option and it works perfectly.
@icd2k3 I only stumbled upon this package a few hours ago, so have i missed anything?
Great job on this library, works like a charm! Thank you for your time! 👍

Thanks for responding @steodor! That's exactly right.
@TutoDS by default this package will create breadcrumbs for you based on the route path section (admin -> "Admin"), but you can manually set any of these by providing a route config array to the hook (like in @steodor's example).

OK, so this way, I create a json object and use to the routes and the breadcrumbs?

How you transform this routes into the object?

And for example the route :category/:slug, I don't have the :category route, is possible remove the link for that "link"?

OK, so this way, I create a json object and use to the routes and the breadcrumbs?

Yep, use-react-router-breadcrumbs accepts an array of route objects to override the default generated ones. There's an example of a config array in the advanced section of the docs.

And for example the route :category/:slug, I don't have the :category route, is possible remove the link for that "route"?

If I understand correctly, you only want to display the slug part, correct? For example, a path of /some-category/some-slug would only result in a single breadcrumb of "Some Slug"?
If that's the case you'd probably want to disable the breadcrumb for :category. There are a few ways of doing this, but the easiest would be to just include a route config object of { path: ':category', breadcrumb: null }.

Closing because over a month old, but will re-open if needed!


AppState.removeEventListener is deprecated and causes crash

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-countdown-component/index.js b/node_modules/react-native-countdown-component/index.js
index b546b82..3127250 100644
--- a/node_modules/react-native-countdown-component/index.js
+++ b/node_modules/react-native-countdown-component/index.js
@@ -51,12 +51,12 @@ class CountDown extends React.Component {
   }

   componentDidMount() {
-    AppState.addEventListener('change', this._handleAppStateChange);
+    this.subscription = AppState.addEventListener('change', this._handleAppStateChange);
   }

   componentWillUnmount() {
     clearInterval(this.timer);
-    AppState.removeEventListener('change', this._handleAppStateChange);
+    this.subscription.remove()
   }

   componentDidUpdate(prevProps, prevState) {

This issue body was partially generated by patch-package.

Thanks a lot, @ArthurSouzaC! You just saved my day.


Implement a CLI

Description:
To streamline the integration of AgentGenesis code snippets into user projects, we propose implementing a CLI (Command Line Interface) package similar to the shadcn-ui package. This CLI will provide commands to fetch and integrate copy-paste code snippets from AgentGenesis directly into users' projects, eliminating the need for manual copy-paste and setup.
Objective:

Simplify the integration of AgentGenesis code snippets into user projects.
Enhance the developer experience by providing an easy-to-use CLI.
Reduce the potential for errors associated with manual copy-pasting of code.

Reference:

shadcn-ui package

Impact:

Improved developer experience and productivity.
Simplified integration process for AgentGenesis components.
Reduced potential for errors and inconsistencies in code integration.

Approval:

Approval from relevant stakeholders is required before proceeding with the implementation.

@DeadmanAbir , can build it up. lemme know the requirement of it

@DeadmanAbir , can build it up. lemme know the requirement of it

Currently, all components in AgentGenesis require manual setup, where developers follow instructions to copy and paste the code. We want to implement a CLI with various NPX commands that developers can use in their terminal to add AgentGenesis components to their projects automatically. For example, ShadCN UI offers both manual setup and NPX commands for automatic component setup.
Try to explore ShadCN's ui package and try to understand their CLI flow. We have to implement something similar.

Hello @DeadmanAbir I wanted to share that I've created a simple CLI tool that is somewhat similar to Shadcn's CLI, although it's still in its early stages. You can check it out on my GitHub—it's pinned at the top.
I'd love to hear your thoughts on it! If you find it interesting, we could collaborate to improve it further and potentially add it to the main repo to enhance its functionality.

I will check it out and will get back to you!

Hello @DeadmanAbir I wanted to share that I've created a simple CLI tool that is somewhat similar to Shadcn's CLI, although it's still in its early stages. You can check it out on my GitHub—it's pinned at the top.
I'd love to hear your thoughts on it! If you find it interesting, we could collaborate to improve it further and potentially add it to the main repo to enhance its functionality.

I will check it out and will get back to you!

Hey!!!
I have build a CLI tool recently!
Will be glad if you also assign this issue to me!! Eager to contribute to your repo!!
And i am also a project admin in GSSOC'24 Extended program.I can also do code reviews if you give access to your repository!!
Excited to contribute and also do code reviews on this project.Very Very nice project I have come across recently.


work on updating python and django versions compatibility

should I remove the unsupported versions?

Looking good :+1:
Also required: README.md and docs/index.md

should I remove the unsupported versions?

Which unsupported versions?

Which unsupported versions?

I presume @auvipy means unsupported Django versions. I'd say "Yes, remove them".
On the test failures:

Remove the --use-mirrors flag to pip. https://github.com/tomchristie/django-vanilla-views/blob/master/.travis.yml#L19
Python 3.2 will need coverage==3.7.1 (IIRC) since 4.x drops support.

Ok guys

Note some test cases still failing.

https://github.com/tomchristie/django-vanilla-views/pull/50 new PR


docs: add an initial development guide

OK, I may have been too wordy, but its a start.
Let's treat this as something to build and improve on in the future rather than the end-all-be-all doc. ;-)

The plan is to merge this on 2021-06-19 unless major issues are raised. Since this is "only" a doc there's no reason why we can't merge it and then iterate on it afterwards.


Windows title and index are too close

I didn't know what I have done ,now the title seems too close to the next number,

but before that I remember it should look that,

Does anyone know what configuration controls this layout?

Hello @willzhqiang 👋
You likely played with window-status-separator. Set it back to space with
$ tmux set -g window-status-separator " "

Hello @willzhqiang 👋
You likely played with window-status-separator. Set it back to space with
$ tmux set -g window-status-separator " "

Yes, you are right, fixed it, thanks!


Remove deprecation warnings (close #30)

Hi, @dongjoon-hyun Could you please review this PR for issue #30? Thanks.

Hi, @weiqingy . Overall, it looks good to me. I left a comment about closing spark session. After your fixing the code, I'll run the test.

Hi, @dongjoon-hyun I have updated the PR.

Thanks for the review, @dongjoon-hyun.


Implement craft locale:install command

This command should install all the needed files for i18n.
Usage $ craft locale:install
Tasks

[x] Command must create a resources/lang/default directory if not found
[x] Command must create a default/__init__.py file based on a snippet if not found
[x] Command must create app/config/locale.py file based on a snippet if not found
[x] Implement tests

Improved filesystem operations with
https://docs.pyfilesystem.org/en/latest/index.html
Improved tests with
https://the-py.github.io/the/
https://docs.pytest.org/en/latest/
Added linter
http://flake8.pycqa.org

The command was changed to lang
and used the namespace install:lang

The command seems fine. I will close this for now

command is now lang:install


Mark DNP parts on schematic as DNP and remove 3D models

03:54 < esden> Heh, all right so the rule is: custom field named "DNP", with no value for "Populate" or "DNP" value for "Do Not Populate".

Done


can not use with vue-grid-layout

thanks for html2canvas,
I am using the lastest html2canvas now,I try to use html2canvas and vue-grid-layout to get img of my layout,but it do not success,
do you have any resolution?
i am tring on jsfiddle,here
https://jsfiddle.net/hujie/4furwb08/3/

+1