Tip pick-up issues

overview
[Ed: based on a mis-conception as per MCous below]
Specifically, at the moment I have to place the tip significantly above the top of the tips when calibrating my P200X8 gen 1 with OpenTrons P200 filter tips. A similar issue was raised on Twitter with me too:
https://twitter.com/pedrosaurio/status/1189606442740924418
More generally, the amount one needs to move down into a tip to pick it up is a feature of the tip, rather than a general property of the pipette model. Conceivably one could have two different tip racks with two different brands of tip on a run (one might be a special purification tip for example) and these might require different pick_up_distances. And generally, at present there is no way to specify the pick_up_distance in for example the Protocol Designer, so it would need to be a feature of the tip rack.
current behavior
pick_up_distance is a property of the pipette and one has to fake-calibrate the tip_rack to take account of its pick_up distance.
expected behavior
Tip_racks have a new labware parameter of pick_up_distance which says how far the pipette has to move down from being flush with the top of the tip to being firmly on the tip.

Actually IMO the lower-effort and more robust fix for this is to revert to calibrating the pushed-down-onto-tip position of the pipette, rather than the flush-with-the-top-of-pipette position.

The pickup process for the OT2 is fundamentally different than with the OT1. The pick-up distance is not the same as the amount of tip overlap. Tip overlap is specific to a given pipette / tiprack combination, but also isn't involved in a tip pickup.
The OT2 picks up tips by:

Attempting to move down in Z by tipPickupDistance mm from the top of the tip
Bottom out on the tip before the pipette actually moves tipPickupDistance, thereby skipping steps and losing its known Z position

This is to create a good seal by continuing to push into the tip even after the pipette bottoms out

Home the z-stage of the pipette to re-establish its position

Tip pickup distance should be read more like tip pickup "distance", in that it's never intended to actually move that far. If you're finding your pipette is unable to pick up tips reliably, does increasing the pickup "distance" in the pipette's settings page help?

Thanks @mcous , that's extremely useful - it would be great to document the fact that it is meant to miss steps (apologies if I've missed that). I think I've found on occasion that my robot has been crushing tips against the bottom of the rack by pushing too hard. Maybe I need to lower the current? Now that I understand the system I'm in a better position to troubleshoot this. @open3dgenome - what happened when you started your tips too low? Was it just that you were scared by how much it was pushing down?
I also have a suspicion that something weird is going on with this in APIv2 calibration as I was having a lot of problems with tipracks and getting Z-limit hit errors. I'll investigate further in due course.

Thanks for those gifs, @mcous (it has been a month of no real support via email and this took just a few hours, I really appreciate it).
@theosanderson : In our case, the arm was ramming 3x (each time stronger) and picking up the tips. It looked awful. The problem was that after this point there was a terrible screeching noise and the Z-axis would then somehow stall and lose the relative coordinates of the axis, rendering the whole downstream steps meaningless (e.g. would not pick up tips on the next round or would aspirate 10 cm above the plates, etc).
I had prepared some slides when I first contacted support via email. It will be much clearer there since there are videos and examples.
I finally detached the cover of the carriage arm to see whether I had damaged the unit. Fortunately I didn't and by removing the cover the sound stopped!!  Still, the problem of having to adjust the tip pickup somewhere around 7-8mm above the tips persists.

I would like to piggyback: we are having issues with the calibration of the Z-position of the magnetic module, just in case it is related (when I have time I will open a proper issue and link it back here).
For example, when calibrating the tip, I tell the robot that the plate is 15cm above (just as a control), this position gets ignored and the protocol uses always the same -perhaps- hardcoded Z-positions. This translates into bent tips when I use different plates for the magnetic unit.

@open3dgenome we're tracking issues with the calibration of plates on magnetic modules in #4046. Feel free to sound off in that thread with your specific experience; more data is always helpful

@open3dgenome , in case it wasn't clear the message on pipettes seems to be that:

the "ramming" seems to be normal behaviour (even though I agree it feels alarming)
The Z-axis is then meant to re-find its coordinates again by homing (and I can see it doing that in your video (though I believe you when you say it did get lost).

I'll let you know how I get on after implementing this.

OK - have just managed calibration on PAPIv2 without any issues ( except calibrate-to-bottom as elsewhere). The deck flexes quite a bit with P200x8 pickup but it works. I also remember getting a scary sound early on as with @open3dgenome and worrying that something was broken (although it cleared up sooner). I wonder if it's something about the pipette mount adjusting itself as it receives force from the bottom for the first time. Anyway, closing this issue - thanks a lot for the explanation.


[BEAM-2333] Remove Pipeline reference from TransformHierarchy

This change removes a direct dependency cycle between Pipeline and
TransformHierarchy. There is still an indirect cycle through PValues, but that
is slightly less problematic.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

R: @tgroh

Coverage decreased (-0.0004%) to 70.669% when pulling 218d090e5f92814dbb0c6ab7cbcd24ada3bc7df6 on kennknowles:TransformHierarchy into 64cea06b1c1cbb1413b0ec570d675975bbbc20ba on apache:master.

Coverage increased (+0.006%) to 70.676% when pulling 71ace1ceae2e3c9369f279ece125dff6ff6bcb4f on kennknowles:TransformHierarchy into d7a4e4943bfc201cafa3ac52310f7561d71c16d6 on apache:master.

Noting that https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/11652/ appears to be a success but had an issue in Jenkins finalizing the job.

retest this please

Coverage decreased (-0.01%) to 70.658% when pulling 71ace1ceae2e3c9369f279ece125dff6ff6bcb4f on kennknowles:TransformHierarchy into d7a4e4943bfc201cafa3ac52310f7561d71c16d6 on apache:master.

retest this please

Coverage increased (+0.003%) to 70.662% when pulling 5e9fcebc07725de368391914781e5b4d5f9c4a19 on kennknowles:TransformHierarchy into 6a68e656a4b226b1921c307822d4b0ccbd847952 on apache:master.


Add metrics queries

An extra query used for shard count experiments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use AWS_REGION instead of VIP_DP_AWS_REGION

This brings us more in line with AWS environment variables and allows us to only have to specify the AWS region once in the deployment configuration.
References

VIP-20

@tank157 I considered that, and since you mention it I think I should just go ahead and do it. For the future, though, ideally we'd be sourcing credentials from the environment rather than passing them explicitly so we could make use of EC2 instance profiles, assumed roles via aws-vault, etc. without any code changes, so that's the direction we'd want to go in.

@gws If that's the case, then we could skip the interim update and just wait until we could make that better improvement instead. Ideally we'll just get data-processor into a relatively steady state where we don't need to make many changes to it for the time we're working on the replacement, so I suppose the question becomes one of whether or not any improvements we make now are to achieve that stability or are we still in a mindset of improving for the long term, when that long term does have a hopefully defined endpoint now?

@tank157 Excellent! I'm not aware of this improving the stability of data-processor, so I may just close this one out later today. I'll bring it up at our upcoming tech meeting.


[Feature] Tooltip: can set position fixed mode optional?

I think it can add a option to set the tooltip toggle as position:fixed and append it to body.

But it need a new way to calc the button position.

I think user can add a custom option in here. And the option will inject to createTooltip  function.

I think it's better to calculate the toolbar's position like the slash plugin, if there's no enough space on top, we can just render it below the block. Something like this:


missing tzdata for windows release

gotz doesn't output correctly on the windows release (and I think I know why).
Here is a screenshot of a default configuration running with the local time being Eastern Standard:

Here is a command-line bork on a manual entry:

Now, I'm not a go developer but it's a lovely language and easy to follow. In configuration.go and in args.go there is use of the time::Location.LoadLocation(name) function.
Docs state:

LoadLocation looks for the IANA Time Zone database in the following locations in order:

the directory or uncompressed zip file named by the ZONEINFO environment variable - on a Unix system, the system standard installation location - $GOROOT/lib/time/zoneinfo.zip - the time/tzdata package, if it was imported.

Windows doesn't have an IANA database and also doesn't run a ZONEINFO env var. But, what's this about time/tzdata?

This package will be automatically imported if you build with -tags timetzdata.

I think the easiest fix is in your build script, if you add -tags timetzdata to line 23? Maybe you don't want to do that for unix systems, maybe add another variable and add it with the name change on line 19?
In any case, I love simple TUI command-line tools and yours is spiffy. I love using them as practice to learn or reinforce languages and I'm porting gotz to .NET in F# and C# and I hope to have the F# port done in another day or so.  :)

Good point. I think it's worth integrating the data directly in any case. Thank you for collecting the information!
Can you check whether this binary solves your problem?
gotz_windows.zip
Or you can run the buildscript from #9 to compile yourself.
Also, I fully agree with implementing small projects for learning a new language. :relaxed:

I tried the binary you compiled and ran a local build -- both success!
Excellent work overall. Closing #8.
(Your repos are all a pleasure to read through. I love sardine-can and geomove. Finally, someone else who understands the pain of calculating through great circle distance.)


ChallengeResult("Auth0", returnUrl ?? Url.Action("Index", "Purchase")); Syntax Error.

Current Readme.Text File

Challenge the Auth0 middleware when the user logs in or out:

public class AccountController : Controller
{
public ActionResult Login(string returnUrl)
{
return new ChallengeResult("Auth0", returnUrl ?? Url.Action("Index", "Home"));
}
[Authorize]
public void Logout()
{
    HttpContext.GetOwinContext().Authentication.SignOut(CookieAuthenticationDefaults.AuthenticationType);
    HttpContext.GetOwinContext().Authentication.SignOut(new AuthenticationProperties
    {
        RedirectUri = Url.Action("Index", "Home")
    }, "Auth0");
}

}
returnUrl ?? Url.Action("Index", "Home" creates an error as ChallengeResult is expecting a controller.
public ChallengeResult(string loginProvider, ApiController controller)
Which is correct? or Which should be changed?

This would be a question better asked of Auth0 if this is in their readme. GetOwinContext isn't even a function in asp.net core, this is from older versions of asp.net


Scala 2.13 release

Amy plans for a Scala 2.13 release? Or would this be non-trivial?

Possibly blocked by https://github.com/milessabin/macro-compat/issues/87

Looks like macro-compat will not be released for scala 2.13 (https://github.com/milessabin/macro-compat/pull/85#issuecomment-500201690).
Would it be possible to drop the use of macro-compat from contextual?

Contextual for Scala 2.13 is already available at Maven Central

libraryDependencies += "com.propensive" %% "contextual" % "1.2.1"


Update README.md for deploying Stackrox via GitOps

I have found trying to do this without a walkthrough has been insanely tough, mainly because you need output from central before installing the other chart. If someone has installed this via Declarative Ops (where you can configure the values file ahead of time) then can you please post a walkthrough for it.
I believe this won't just help me but will help with team adoption in a secure manner. Thanks ahead of time and hope this gets scoped in.

It's not an easy problem to solve in the general case (i.e. installing across multiple k8s clusters), but we did briefly have support for automatically generating an init bundle for use by secured cluster components in the same cluster. However we had to revert it because of UX issues.
Would a single-cluster solution be enough for your use case @Cr0n1c ?
For multi-cluster I guess we'd have to integrate with something like RHACM (stolostron) - which should be relatively easy, or support "bring your own CA", which would be significantly harder.


Track downloads separately from static files

It is useful to be able to track pdfs, docs, mkv, mp3 etc separately from css,js etc. It would also be useful to make use of a logged mimetype instead of just using extensions. Ideally it would be nice to combine this with custom panels (#515) so I could have a docs panel, video panel + whatever other combination of ext, mimetype, url?
AWStats has a downloads section.

I agree that having the ability to add custom panel would be great, and probably would solve your suggestion above.
As far as tracking pdfs, etc, you already should be able to add your custom extensions to your config file, please take a look at this section. Thanks.

Hi. Thanks I know I can add extra extensions. I should have made the requirements clearer. I need to track downloads like docs in a way that doesn’t include css/js etc which aren’t really downloads. So if I take out css/js etc from static file extensions I would get what I want right? Does that affect any other stats if I do this?

You can certainly remove them from your config file and they will appear in the requests panel instead of the static panel. Like you said, implementing #515 will let you add custom panels.

Closing this since it'll be addressed on #515. Feel free to reopen it if needed.


[CI] Go dependencies: upgrade meshery pkgs

Signed-off-by: leecalcote<EMAIL_ADDRESS>Description
This PR is maintenance.
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Should be good now

Thank you, @acald-creator. What blocker or what remains left that we need to do to get to the latest versions of each?


HTTPS client

With TLS client available it should be possible to modify the existing HTTP client functionality to also support TLS. Note that it's hardcoded to only accept TLS v1.2 which is the current most widely used standard.

Implemented with https://github.com/hioa-cs/IncludeOS/pull/1728 by @AndreasAakesson


How long does BTTR take to train?

Hi, thank you for great repository!
How long does it take to train for your experiment in the paper?
I mean training on CROHME 2014/2016/2019 on four NVIDIA 1080Ti GPUs.
Thanks,

About 6~7 hours

Thank you for your quick response!


Memory leak

Saw this in the logs in version 0.8.5.
2018-08-08 16:33:38.925 3721-3721/net.suivideflotte.drivercompanion.debug E/ActivityThread: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@181a6ef that was originally bound here
    android.app.ServiceConnectionLeaked: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@181a6ef that was originally bound here
        at android.app.LoadedApk$ServiceDispatcher.<init>(LoadedApk.java:1532)
        at android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:1424)
        at android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1605)
        at android.app.ContextImpl.bindService(ContextImpl.java:1557)
        at android.content.ContextWrapper.bindService(ContextWrapper.java:684)
        at com.firebase.jobdispatcher.ExecutionDelegator.executeJob(ExecutionDelegator.java:110)
        at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleStartMessage(GooglePlayMessageHandler.java:98)
        at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleMessage(GooglePlayMessageHandler.java:67)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Seconded.
I've seen this quite frequently with 0.8.5 in the last few weeks or so.  The symptoms will be an onStopJob() is called on a currently executing job and when I check my background worker thread, the thread appears healthy but stuck (see below example A).  Then, when I check logcat, I can see the aforementioned stacktrace which precedes the onStopJob by 8ms (see below example B).  The Firebase JobService itself seems to have gone away.
Is there a conflict between Firebase Job Dispatcher 0.8.5 and Google Play Services?  I've observed the issue on a Nexus 5 w/5.0, an LG G6 w/8.0, a Pixel w/8.1, and a Pixel 2 w/9.0.  All of the devicces would have been updated to the most recent version(s) of Play Services.
Example A:
Application log snippet (in UTC time) on a Pixel w/8.1:
[2018/08/14-13:51:13.817] Java: NetworkService [1534254673817] onStopJob - current running job stopped.  Thread is alive and not interrupted, state = RUNNABLE
com.firebase.jobdispatcher.GooglePlayDriver.createSchedulerIntent(GooglePlayDriver.java:143)
com.firebase.jobdispatcher.GooglePlayDriver.createCancelRequest(GooglePlayDriver.java:110)
com.firebase.jobdispatcher.GooglePlayDriver.cancel(GooglePlayDriver.java:96)
com.firebase.jobdispatcher.FirebaseJobDispatcher.cancel(FirebaseJobDispatcher.java:99)
com.devicescape.connectsdk.NetworkService$2.run(NetworkService.java:1058)
java.lang.Thread.run(Thread.java:764)
Example B:
Logcat snippet (in US-East time) on Pixel w/8.1:
08-14 09:51:13.809 11467 11467 E ActivityThread: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@387b55 that was originally bound here
08-14 09:51:13.809 11467 11467 E ActivityThread: android.app.ServiceConnectionLeaked: Service com.firebase.jobdispatcher.GooglePlayReceiver has leaked ServiceConnection com.firebase.jobdispatcher.JobServiceConnection@387b55 that was originally bound here
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.app.LoadedApk$ServiceDispatcher.(LoadedApk.java:1532)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.app.LoadedApk.getServiceDispatcher(LoadedApk.java:1424)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.app.ContextImpl.bindServiceCommon(ContextImpl.java:1605)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.app.ContextImpl.bindService(ContextImpl.java:1557)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.content.ContextWrapper.bindService(ContextWrapper.java:684)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at com.firebase.jobdispatcher.ExecutionDelegator.executeJob(ExecutionDelegator.java:110)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleStartMessage(GooglePlayMessageHandler.java:98)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at com.firebase.jobdispatcher.GooglePlayMessageHandler.handleMessage(GooglePlayMessageHandler.java:67)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.os.Handler.dispatchMessage(Handler.java:106)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.os.Looper.loop(Looper.java:164)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at android.app.ActivityThread.main(ActivityThread.java:6494)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at java.lang.reflect.Method.invoke(Native Method)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
08-14 09:51:13.809 11467 11467 E ActivityThread: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

I'm getting this too on 0.8.5, any chance for this to be fixed? Thank you!

Just saw this on version 0.7.0 (on Pixel 2 running 9.0)

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


feat: add money currency formatting package

Description
A new package to format Shopify price value to human readable value using Shopify Currency formatting options

Hi @IliasHad, thanks for your contribution. At this time, this doesn't seem like the appropriate place to maintain this additional package. We'd suggest instead creating and using a package of your own on the NPM registry


Integration with 'selenium-stealth'

Hello,
Is there a way to use it with https://pypi.org/project/selenium-stealth/ ?
I tried to use it in the parse function
def parse_realEstate(self, response):

    driver = response.meta['driver']

    stealth(driver,
            languages=["en-US", "en"],
            vendor="Google Inc.",
            platform="Win32",
            webgl_vendor="Intel Inc.",
            renderer="Intel Iris OpenGL Engine",
            fix_hairline=True,
            )

but it doesn't work.
I tried with the script argument but without success.
       yield SeleniumRequest(url=realEstate, callback=self.parse_realEstate,                                   wait_time=60,                                   wait_until=EC.visibility_of_element_located                                   ((By.XPATH, '//*[@id="__next"]/main/div[*]/div[*]/header/strong')), script="...")
Any suggestion to make it work?
Thanks.

Hi! Purely personal opinion... Maybe try to use stealh(*args, **kwargs) when initializing middleware? I had a similar experience with playwright-stealth and there it was enough to create a custom middleware and in it add necessary methods to the driver like this.

As I am no expert with Python, the solution I opted for was to grab clone the repository and added the code needed for the library 'selenium-stealh' after the creation of the driver. This repo is not being updated so this way if I need a future new improvement I can update it myself. Thanks for the suggestion anyway.


Time field on DateTime still editable (UI only) in Readonly mode

@volkanceylan Time field on Date Time still editable in UI Read-only mode LoggingRow.cs#L30. Please see the screenshot below.

In code, Insertable(false), Updatable(false) attributes are set
Please fix this.

Fixed in #5208 next serenity update will include this fix.


Svelte

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.057%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
494

Relevant Lines:
581

💛  - Coveralls


Implement Ledger support

Closes #16
Ledger Nano S/X is now supported.
Add Helpers:

Get publickey from Ledger device
Sign a transaction with Ledger

Additionally add missing prompt for signer public key during manual transaction construction.

Also, while I was working on it a newer version of slip10 was released (included all @frol ) fixes you were relying on, so I updated the Cargo.toml


W-14316969-Create-MUnit-3-0-branch-CP

This branch has been published so the PR is no longer needed.
Closing PR


pull request for e2e test at 12/07/2016 03:26:01

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


LoginNexus

A REST API-based authentication and registration extension
Unlock the REST API-BASED authentication/registration for games
Any ideas or feedback? Tell me 💡

(Sorry for reuploading a extension,  its due to the conflicts)

API keys are a touchy area as they are unsafe and can be easily stolen. Please see AI extensions for reference as they require an API key and have been touched on a lot for this matter.

Api keys?

API keys are a touchy area as they are unsafe and can be easily stolen. Please see AI extensions for reference as they require an API key and have been touched on a lot for this matter.

Api keys?

Oh, I checked the code, I did a spelling mistake

!format

!format


How to save best policy snapshot during training?

Sorry for the spam. Wrong repository to post the issue :)


Host the ocp.tgz bundle on our GitHub releases instead of in the docs build

Description

Currently, this is handled as part of the docs build. However, when we switch to the new docs infrastructure, the docs will no longer be in this repository and we want to decouple product artifacts from documentation.
So instead, this PR has us build ocp.tgz at release time and host it on our GitHub release.
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

ocp.tgz now hosted on GitHub

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@caseydavenport Are you cherry-picking these changes to 3.25 and 3.24?

Thanks, @caseydavenport


Markdowns content publishing how-to session for the Cupcake website stream (part two)

User Story

As a user role below:
DDS Cupcake website content creator

I need to:
understand the Gatsby theme and know how to publish content with the theme

so that I can:
publish content efficiently.

Additional information

Gasby theme can be viewed here.
Part one training detail can be viwed here
Trainer: @jeffchew

Acceptance criteria

[x] Jacob, and Jenny know how to publish website content with the Markdowns.

Thank you, again @jeffchew.


There's a white line below bottomBar

I don't understand what's the issue with this one. Maybe its because is in a Fragment? :

And my code is :
     bottomBar = BottomBar.attach(view, savedInstanceState);
    bottomBar.noNavBarGoodness();
    bottomBar.setMaxFixedTabs(2);
    bottomBar.setItemsFromMenu(R.menu.menu_bottom_bar, new OnMenuTabClickListener() {
        @Override
        public void onMenuTabSelected(@IdRes int menuItemId) {
            Log.i(TAG, "onMenuTabSelected: " + menuItemId );
        }

        @Override
        public void onMenuTabReSelected(@IdRes int menuItemId) {
            Log.i(TAG, "onMenuTab- RE - Selected: " + menuItemId );
        }
    });

    bottomBar.mapColorForTab(0, ContextCompat.getColor(getActivity(), R.color.bottom_bar_background));
    bottomBar.mapColorForTab(1, ContextCompat.getColor(getActivity(), R.color.bottom_bar_background));
    bottomBar.mapColorForTab(2, ContextCompat.getColor(getActivity(), R.color.bottom_bar_background));

I'd really appreciate any help.

I was right, it was a problem from using the bottomBar inside a Fragment. I moved it to Activity and now everything is ok.


[BUG] Front-End has undefined in the events URL

Description
Failed to parse URL from undefined/events/
Steps to Reproduce
I added an event in the backend but the front-end says Failed to parse URL from undefined/events/

Expected Behavior
To load the events added in the backend
Actual Behavior
No events are being listed
Additional Context
Is there anything more that need to be setup post initial setup for events to appear ?
Affected Area
Frontend
Version
No response
Browser (if frontend)
No response

Hey there, i would like to work on this issue, can it be assigned to me?

My .env.local has  only this :
NEXT_PUBLIC_FRONTEND_URL=http://localhost:3000

These are incorrect, can you have a look at our contributing guide and make sure that all the envs are correct? Plus the file name should be .env not .env.local


Autoloading .twig template ignores Woocommerce PHP overrides

Hi, first thanks for your work.
I'm starting using your integration and I'm experimenting something confusing.
I'm using the 'if present, automatic loading / parsing template.twig file' feature, but I needed to change some basic php logic. I noticed that if i want to both override, for example woocommerce/single-product/add-to-cart/simple.php AND templates/woocommerce/single-product/add-to-cart/simple.twig, the twig template has the priority over the php and my woocommerce override would never be executed.
Am I the only on experiencing the situation ? And is it possible to :

load .twig file is php template doesn't exists,
otherwise loads the php template overrided ?

I'm open to discuss, thank you !

Hey @tomablan
I think I won’t change how this works. If you add a Twig file, it’s meant to replace the default WooCommerce logic instead of a PHP file.
It’s not possible for me to run the PHP file first and then render the Twig file. If you look at the code, you’ll see that I render the Twig file and then return an empty PHP file. WooCommerce will then include that file:
https://github.com/mindkomm/timber-integration-woocommerce/blob/345e711378cf89f156b5e7eaeaaf76f66c8725b0/lib/WooCommerce.php#L196-L202
So any logic that you would change in the PHP file would actually run after the Twig file. And I can’t tell WooCommerce to not run that logic.
But you have other ways to solve this:

Change the logic in the Twig file.
Change the logic in your PHP file and call Timber::render() with your Twig template.

single-product/add-to-cart/simple.php
<?php

// Some logic changing code.

Timber::render( 'woocommerce/single-product/add-to-cart/simple.twig' );

But I see that there’s no easy way to generate the context for that template file. I might have to add a function so you could do something like this:
<?php

// Some logic changing code.

Timber::render(
	'woocommerce/single-product/add-to-cart/simple.twig',
    // This function doesn’t exist yet.
	\Timber\Integration\WooCommerce::get_template_context()
);

To understand better whether this would be a good solution: Could you tell me more about the logic that you wanted to change in PHP? Maybe there’s even a simpler way to solve this.


[joy-ui][Divider] Color mismatch

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
The color of the Divider component mismatch with the one used for the input borders.

Current behavior 😯
No response
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎
No response

Hey @marcpachecog, thanks for opening this issue! That's a good catch, but I'm curious: why were you expecting them to match? Not saying that they shouldn't; just want to know more.

Hey @danilo-leal, using a different tint for the divider when all borders of library components have the same tint, including Buttons and Inputs, appears visually inconsistent.

For sure, yeah. If everything uses the same border color, that makes a lot of sense. @zanivan has a PR working on the default palette and can probably work that out real soon! Thanks for reporting it! 👍

@zanivan has a PR working on the default palette and can probably work that out real soon! Thanks for reporting it! 👍

Exactly, this should be fixed on #38416

@zanivan + @marcpachecog just checking if the above-mentioned PR solved this issue?
If yes, @zanivan feel free to close this!


Develop

Make ensure_index be bson.

There are problems with some private functions. They are used incide module, but compile does not think so.
Need to investigate this issue before merging.


Reference::flag method should return ReferenceFlag, not &ReferenceFlag

ReferenceFlag is Copy. Reference::flag method should return ReferenceFlag (1 byte), not &ReferenceFlag (8 bytes).
See also #4991 - I also propose renaming this method.

When you make this change, could you add a re-export of ReferenceFlags as ReferenceFlag and mark it as deprecated? This will give downstream consumers time to update their code.

Fixed in #5019.


Can't set a value for a field in a interface

Describe the bug
I'm trying to set a value to an object from an interface that has a mapType configured.
I know that we can't use Instancio directly from an interface:
@Test
void shouldReturnNullWhenCreatingAnObjectFromAnInterface() {
    var obj = Instancio.create(FooBarBazInterface.class);
    assertThat(obj).isNull();
}

But It's possible if we configure a mapType:
@Test
void shouldCreateObjectWhenInterfaceIsMappedToConcreteClass() {
    var obj = Instancio.of(FooBarBazInterface.class)
        .withSettings(
            Settings.create()
                .mapType(FooBarBazInterface.class, ImmutableLombokFooBarBaz.class)
        )
        .create();
    assertThat(obj).isNotNull();
}

Unfortunately, we can't set a value, even that mapType is configured, because the reflection is done in the interface class and there, this field doesn't exist.
@Test
void shouldBeAbleToSetValue() {
    var obj = Instancio.of(FooBarBazInterface.class)
        .withSettings(
            Settings.create().mapType(FooBarBazInterface.class, ImmutableLombokFooBarBaz.class)
        )
        .set(Select.field("bar"), null)
        .create();

    assertThat(obj).isNotNull();
    assertThat(obj.getBar()).isNull();
}

Expected result
I expect that with mapType the reflection is done in the concrete class, not the interface and set works as expected.
Actual result
Error creating an object
 -> at ***.shouldBeAbleToSetValue(InterfaceTest.java:34)

Reason: invalid field 'bar' for interface ***.FooBarBazInterface

Java version: 20.0.2
Instancio version: 3.2.0

@lucasfsousa when the field name is specified without a class, Instancio assumes that the field is declared in the root class, for example:
var obj = Instancio.of(FooBarBazInterface.class)
    .set(Select.field("bar"), null)

is a shorthand for
var obj = Instancio.of(FooBarBazInterface.class)
    .set(Select.field(FooBarBazInterface.class, "bar"), null)

If you specify the class explicitly, it should work as expected:
var obj = Instancio.of(FooBarBazInterface.class)
    .set(Select.field(ImmutableLombokFooBarBaz.class, "bar"), null)

@armandino thanks for the quick response (again).
I just tested and it works as you explained.


How to set qid when predict in LGBMRanker?

In python, qid can be set to group in fit(X, y, group), but  predict() has no parameter group, so where to set qid?

qid is not needed in prediction. LightGBM will predict the relevant score, and you should rank the result by yourself.

@guolinke is it possible to elaborate more on this? Shall one make predictions on each group separately? What is the output of the LGBM.predict() method? The docs are very short on the subject and examples in the tests and elsewhere address rnker fit, but not prediction

@mlisovyi qid have no effects on ranking predictions in lgb.predict, as the predicted results are the relevant scores. And you can use the relevant scores to get the correct ranking order results by yourself, and qid is needed in this step.

@mlisovyi the same, you can just sort by prediction values.

@guolinke could you please elaborate on how does one convert the result of lgb.predict (M relevant scores) into M x N ranks, i. e. how to sort documents using these scores? Thanks.

but, not in same query group, is the scores can be comparable?

@nonva theoretically, they could be comparable.

@guolinke Can I put several different qid data together in test data, when lgb.predict()? Shoud I predict by each qid?


repo don't support refs/changes/... in XML

Hi,
It seem that this repo not support refs/changes/... in XML, while it's supported by Android.
Such construction is required when doing Jenkins continuous integration on patch submitted to gerrit.
Applying such patch fix (inspired from Android):
$ git diff
diff --git a/git_config.py b/git_config.py
index 8a9b46c..e45a265 100644
--- a/git_config.py
+++ b/git_config.py
@@ -652,6 +652,10 @@ class Remote(object):
         for spec in self.fetch:
             if spec.SourceMatches(rev):
                 return spec.MapSource(rev)
+
+        if not rev.startswith(R_HEADS):
+              return rev
+
         raise GitError('remote %s does not have %s' % (self.name, rev))

     def WritesTo(self, ref):
diff --git a/project.py b/project.py
index 5d9a4a6..a4b8cec 100644
--- a/project.py
+++ b/project.py
@@ -1675,9 +1675,9 @@ class Project(object):
             branch = self.revisionExpr
             if is_sha1:
                 branch = self.upstream
-            if branch.startswith(R_HEADS):
-                branch = branch[len(R_HEADS):]
-            cmd.append(('+refs/heads/%s:' % branch) + remote.ToLocal('refs/head
+            if not branch.startswith('refs/'):
+                branch = R_HEADS + branch
+            cmd.append(('+%s:' % branch) + remote.ToLocal(branch))

         ok = False
         for _i in range(2):

Is it possible to integrate it in master branch ?
Thanks & Best regards,
JP

Agree that is a missing feature. Will need it on Jenkins...

hey there, thanks for the issue (and push-comment ;)),
we are currently rebuilding the whole project with the stuff we learned in this version and put it on the base of the current android git-repo. We will push it for testing in a few days, so then the proposed feature will be available. I will add a comment here, when it is finally pushed.
Best Regards

pushed on branch stable, could you verify that the feature is now available elsewise reopen the issue? Thank you


Server blocks when connection is closed before end of stream

Server doesn't close the connection when kaldigrpc_client disconnects before the end of stream. This has been noted both in the programmatic use, when we run the ILSPASRClient.streaming_recognize method, as well as when running kaldigrpc-transcribe --streaming from the cli.
Expected Behavior
Streaming recognition works, and when we stop streaming audio and break the client print loop, the server worker disconnects from the grpc channel and is available again.
Current Behavior
Streaming recognition still works, but when we stop streaming audio and break the client print loop, the server worker doesn't disconnect from the grpc channel, and stays blocked for at least 30 minutes.
Possible Solution
Close the connection on the server side too. Possibly redefine the meaning of "end_of_stream"?
Steps to Reproduce

Run a kaldigrpc-server container, and note the number of max_workers, e.g. 5
Run a streaming recognition task and cancel it while it is being executed. E.g. on chomsky, run kaldigrpc-transcribe --streaming --port 1234 geopar.wav and then Ctrl-C it after some seconds
Repeat above step as many times as the number of max workers plus 1, e.g. 5+1
Note that the last run doesn't connect to the server at all.

Context (Environment)
In the context of Virtual Assistants, where we need to perform an action when we recognize certain commands, we should be able to close the grpc channel abruptly.
Looking forwrard to further discussion and will be happy to assist in the implementation of a solution!

Also, it could be useful to add a deadline to the connection. https://grpc.io/blog/deadlines/

I will try again with the env variable GRPC_VERBOSITY=DEBUG

TODO: Add verbose logs / error handling / connection deadline

Fixed: https://github.com/georgepar/kaldi-grpc-server/pull/13


[BUG] Bitcoin Jungle wallet instructions are incorrect

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When attempting to connect Bitcoin Jungle wallet to Alby, it presents these instructions:

These instructions do not work for Bitcoin Jungle wallet as we do not display the access token on the developer settings screen. We never have. I think this was a copy/paste from the upstream project, Blink.
Users must obtain their token by receiving an SMS/WhatsApp message with a 6 digit code and providing that code in exchange for a token.
Screenshots [optional]
No response
Steps To Reproduce

Visit Alby Extension
Click Add New Account
Under Bring Your Own Wallet, click Connect
Click Bitcoin Jungle Wallet
You are prompted to locate an access code which cannot be found

Expected behavior
After step 4, the user should be prompted to enter their phone number, including country code, and decide whether they want the message over SMS or WhatsApp. They should then enter the 6 digit code to obtain a token.
Alby information

3.6.0
Firefox
Installed from store

Device information
No response
Additional context
No response
Are you working on this?
None

@openoms Do we need to separate the connectors for Galoy / Bitcoin Jungle here then?
@leesalminen Are there any plans to upgrade to this new flow / auth tokens in future?

The state of the galoy connector for Bitcoin Jungle was preserved as it was previously, so the instructions might have been never right. In the recent changes I have been focusing on not breaking the existing connections using the access token.
I think at this point it would make sense to diverge the two connectors as the Blink API has different authentication method, updated calls and possible Stablesats integration: https://github.com/getAlby/lightning-browser-extension/issues/2730


Move fails for file which is under the root folder

java.lang.RuntimeException: An error occurred while executing doInBackground()                                                                         at android.os.AsyncTask$3.done(AsyncTask.java:309)                                                                         at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)                                                                         at java.util.concurrent.FutureTask.setException(FutureTask.java:223)                                                                         at java.util.concurrent.FutureTask.run(FutureTask.java:242)                                                                         at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)                                                                         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)                                                                         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)                                                                         at java.lang.Thread.run(Thread.java:818)                                                                      Caused by: java.lang.NullPointerException: Attempt to invoke direct method 'void com.github.mjdev.libaums.fs.fat32.FatDirectory.init()' on a null object reference                                                                         at com.github.mjdev.libaums.fs.fat32.FatDirectory.move(FatDirectory.java:612)                                                                         at com.github.mjdev.libaums.fs.fat32.FatFile.moveTo(FatFile.java:200)

Can you maybe provide some additional information regarding the move.

The operation crashes when moving a file which is under the root to another folder two levels under the root.
Crashes when performing this move operation
Root > File
Root > FolderA > File

Can you check current develop if this issue is resolved?

@mjdev looks like it's solved 👍

Very nice!


Authentication, some samples, and e-mail author

Hi,
Do you have some usage samples available? And authentication sample as well?
Do you mind dropping me an e-mail on my username @ gmail.com?
@raghupallavi

There are unit tests in the project. They should give good idea on how to use the API.


fix tests

After making the tests not run, here is the fix, including some py.test (ing)
Will continue to migrate tests to test the pierre module independently and the endpoints only for the relevant stuff
@alvarocavalcanti please review

check

I'm a little behind on this, sorry, but it's been a busy week. I should get to these soon.


Crash after screen orientation change on Nexus 5X

Tangram is consistently crashing for me on my nexus 5x when changing the device orientation (portrait <-> landscape). I managed to reproduce it in a way that hopefully will work for you:
Fire up the simplemap demo with a Nexus 5X emulator.
Zoom in somewhere (you have to move the camera).
Rotate the screen and you should crash:
01-05 16:51:01.228 3803-4095/com.mapzen.tangram.demos.simplemap A/libc: Invalid address 0xdf611000 passed to free: value not allocated
01-05 16:51:01.228 3803-4095/com.mapzen.tangram.demos.simplemap A/libc: Fatal signal 6 (SIGABRT), code -6 in tid 4095 (GLThread 196)
I used the x86_64 Lollipop and Marshmallow images with Google APIs and was able to reproduce it.  I was not able to reproduce it using a Nexus 6 or 5 configuration, which makes me think it is something unique with the 5x. This happens on my actual device as well (Nougat), so I don't think it's an emulator issue.  I've also seen less predictable crashes occasionally during onDestroy going in and out of the activity; I'm not sure if it's related.

Hi @placz ,
Do you mind giving a try at this branch and see if this crash happens on your device?
https://github.com/tangrams/tangram-es/tree/gl-context-loss

That seems to have done the trick; I haven't been able to make it crash on my device by rotating it - thank you!

Ok thanks for testing! The fix should be in https://github.com/tangrams/tangram-es/pull/1234.


typo in stable release

:OpenSSL_1_0_1-stable
--- openssl-1.0.1r/CHANGES
+++ b/CHANGES
@@ -1570,7 +1570,7 @@
      most recently disabled ciphersuites when "HIGH" is parsed).

      Also, change ssl_create_cipher_list() (using this new
-     funcionality) such that between otherwise identical
+     functionality) such that between otherwise identical
      cihpersuites, ephemeral ECDH is preferred over ephemeral DH in
      the default order.
      [Bodo Moeller]
--- openssl-1.0.1r/CHANGES.SSLeay
+++ b/CHANGES.SSLeay
@@ -29,7 +29,7 @@
 7-Jan-98
     - Finally reworked the cipher string to ciphers again, so it
       works correctly
-    - All the app_data stuff is now ex_data with funcion calls to access.
+    - All the app_data stuff is now ex_data with function calls to access.
       The index is supplied by a function and 'methods' can be setup
       for the types that are called on XXX_new/XXX_free.  This lets
       applications get notified on creation and destruction.  Some of
--- openssl-1.0.1r/doc/crypto/EVP_PKEY_cmp.pod
+++ b/doc/crypto/EVP_PKEY_cmp.pod
@@ -23,10 +23,10 @@
 The function EVP_PKEY_copy_parameters() copies the parameters from key
 B<from> to key B<to>.

-The funcion EVP_PKEY_cmp_parameters() compares the parameters of keys
+The function EVP_PKEY_cmp_parameters() compares the parameters of keys
 B<a> and B<b>.

-The funcion EVP_PKEY_cmp() compares the public key components and paramters
+The function EVP_PKEY_cmp() compares the public key components and parameters
 (if present) of keys B<a> and B<b>.

 =head1 NOTES
--- openssl-1.0.1r/doc/crypto/EVP_SignInit.pod
+++ b/doc/crypto/EVP_SignInit.pod
@@ -32,7 +32,7 @@

 EVP_SignFinal() signs the data in B<ctx> using the private key B<pkey> and
 places the signature in B<sig>. B<sig> must be at least EVP_PKEY_size(pkey)
-bytes in size. B<s> is an OUT paramter, and not used as an IN parameter.
+bytes in size. B<s> is an OUT parameter, and not used as an IN parameter.
 The number of bytes of data written (i.e. the length of the signature)
 will be written to the integer at B<s>, at most EVP_PKEY_size(pkey) bytes
 will be written.
--- openssl-1.0.1r/crypto/bn/bn_x931p.c
+++ b/crypto/bn/bn_x931p.c
@@ -192,8 +192,8 @@
 }

 /*
- * Generate pair of paramters Xp, Xq for X9.31 prime generation. Note: nbits
- * paramter is sum of number of bits in both.
+ * Generate pair of parameters Xp, Xq for X9.31 prime generation. Note: nbits
+ * parameter is sum of number of bits in both.
  */

 int BN_X931_generate_Xpq(BIGNUM *Xp, BIGNUM *Xq, int nbits, BN_CTX *ctx)
--- openssl-1.0.1r/crypto/ec/ec.h
+++ b/crypto/ec/ec.h
@@ -911,7 +911,7 @@
 EC_KEY *d2i_ECParameters(EC_KEY **key, const unsigned char **in, long len);

 /** Encodes ec parameter and stores the result in a buffer.
- *  \param  key  the EC_KEY object with ec paramters to encode
+ *  \param  key  the EC_KEY object with ec parameters to encode
  *  \param  out  the buffer for the result (if NULL the function returns number
  *               of bytes needed).
  *  \return 1 on success and 0 if an error occurred.

:OpenSSL_1_0_2-stable
--- openssl-1.0.2f/CHANGES
+++ b/CHANGES
@@ -2044,7 +2044,7 @@
      most recently disabled ciphersuites when "HIGH" is parsed).

      Also, change ssl_create_cipher_list() (using this new
-     funcionality) such that between otherwise identical
+     functionality) such that between otherwise identical
      cihpersuites, ephemeral ECDH is preferred over ephemeral DH in
      the default order.
      [Bodo Moeller]
--- openssl-1.0.2f/CHANGES.SSLeay
+++ b/CHANGES.SSLeay
@@ -29,7 +29,7 @@
 7-Jan-98
     - Finally reworked the cipher string to ciphers again, so it
       works correctly
-    - All the app_data stuff is now ex_data with funcion calls to access.
+    - All the app_data stuff is now ex_data with function calls to access.
       The index is supplied by a function and 'methods' can be setup
       for the types that are called on XXX_new/XXX_free.  This lets
       applications get notified on creation and destruction.  Some of
--- openssl-1.0.2f/doc/crypto/EVP_PKEY_cmp.pod
+++ b/doc/crypto/EVP_PKEY_cmp.pod
@@ -26,7 +26,7 @@
 The function EVP_PKEY_cmp_parameters() compares the parameters of keys
 B<a> and B<b>.

-The function EVP_PKEY_cmp() compares the public key components and paramters
+The function EVP_PKEY_cmp() compares the public key components and parameters
 (if present) of keys B<a> and B<b>.

 =head1 NOTES
--- openssl-1.0.2f/doc/crypto/EVP_SignInit.pod
+++ b/doc/crypto/EVP_SignInit.pod
@@ -32,7 +32,7 @@

 EVP_SignFinal() signs the data in B<ctx> using the private key B<pkey> and
 places the signature in B<sig>. B<sig> must be at least EVP_PKEY_size(pkey)
-bytes in size. B<s> is an OUT paramter, and not used as an IN parameter.
+bytes in size. B<s> is an OUT parameter, and not used as an IN parameter.
 The number of bytes of data written (i.e. the length of the signature)
 will be written to the integer at B<s>, at most EVP_PKEY_size(pkey) bytes
 will be written.
--- openssl-1.0.2f/crypto/bn/bn_x931p.c
+++ b/crypto/bn/bn_x931p.c
@@ -192,8 +192,8 @@
 }

 /*
- * Generate pair of paramters Xp, Xq for X9.31 prime generation. Note: nbits
- * paramter is sum of number of bits in both.
+ * Generate pair of parameters Xp, Xq for X9.31 prime generation. Note: nbits
+ * parameter is sum of number of bits in both.
  */

 int BN_X931_generate_Xpq(BIGNUM *Xp, BIGNUM *Xq, int nbits, BN_CTX *ctx)
--- openssl-1.0.2f/crypto/ec/ec.h
+++ b/crypto/ec/ec.h
@@ -920,7 +920,7 @@
 EC_KEY *d2i_ECParameters(EC_KEY **key, const unsigned char **in, long len);

 /** Encodes ec parameter and stores the result in a buffer.
- *  \param  key  the EC_KEY object with ec paramters to encode
+ *  \param  key  the EC_KEY object with ec parameters to encode
  *  \param  out  the buffer for the result (if NULL the function returns number
  *               of bytes needed).
  *  \return 1 on success and 0 if an error occurred.

Thank you,
Hiroyuki YAMAMORI
P.S. revised openssl-1.0.1r/crypto/bn/bn_x931p.c

I searched master for paramter - no matches.

not worth fixing in the released code. thanks for reviewing tho.


[CELEBORN-1705] Fix disk buffer size is negative issue

What changes were proposed in this pull request?
Fix disk buffer size is negative issue.
Before, when writing for PartitionDataWriter with memory file storage

if isMemoryShuffleFile is true, increment the memory file storage counter
check if evict is needed, if that, flush the buffer and then set isMemoryShuffleFile to false
add data into flushBuffer
if memory file storage evicted, the data buffer would be released as disk buffer finally.

Then the disk buffer size would be negative finally, and memory file storage would be always positive.
In this PR, we update the counter after evict finished.
Why are the changes needed?
After no active running application in the celeborn cluster, I found that, it is abnormal per the celeborn worker log.
24/11/09 23:30:50,474 INFO [worker-memory-manager-reporter] MemoryManager: Direct memory usage: 276.0 MiB/40.0 GiB, disk buffer size: -748726.0 B, sort memory size: 0.0 B, read buffer size: 0.0 B, memory file storage size : 731.2 KiB

disk buffer size: -748726.0 B
memory file storage size : 731.2 KiB

Both of them are expected to be 0.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration testing.

cc @FMX @RexXiong

After this PR, the MemoryFileStorage size is 0 finally, but the disk buffer size is not, I wonder that we should set the flusher be volatile.
https://github.com/apache/celeborn/blob/9083dd401c717708881ae3a47271a1889a55f133/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java#L613-L627


Resize emoji SVG images to be larger

SVG images currently are 128x128 since that's the png image size, and originally they were intended for building a version of NotoColorEmoji using SVG for the glyphs.  Consider using a larger size to facilitate web use.

Does this matter? Isn't the SVG size nominal anyway?  I ask because I'm thinking of the path simplifier code we need to develop, and the absolute size becomes relevant there.  So, thinking of 128px still being the level of detail we should keep sounds reasonable.

so often on web the svgs are opened in image tags. and get rasterized by browser.
in that process width and height in the svg tag will define the size of details that will get rasterized.
you can keep viewbox at 0 0 128 128 and current path data and specify width and heigth as big as you want

viewBox != web size.


Question about point cloud render method

The 2D renderings of the point clouds in your paper's image look very beautiful.
Could you please share how to generate such images?
I have just started working with 3D point clouds, and I appreciate your help !

I have updated the repo. Please see
https://github.com/CuiRuikai/Partial2Complete/blob/main/render.py
You can also use blender to render point clouds like what we did in our recent paper: https://arxiv.org/pdf/2403.18241 Figure 4
It is more controllable than using the rendering script.
The instruction of blender is https://blog.csdn.net/qq_44324007/article/details/131499010

Thank you !


Fix ATZSegmentedControl's focus ring and click area

Fixes #226.
This PR fixes the ATZSegmentedControl's focus ring by drawing it around the blue text background. This also fixes the click area, which for some of the segments was not aligned with the custom drawn button (ie. by clicking on the far left and right ends of one segment you'd actually activate another segment).

A couple of points:

This is probably a bit more hacky than the previous implementation:

ATZSegmentedControl's initWithCoder: is overridden to work around an IB bug (https://mikeash.com/pyblog/custom-nscells-done-right.html);
ATZSegmentedCell's _drawBackgroundWithFrame:inView: is overridden to do nothing, in order to disable the NSSegmentedCell's implementation, which draws the classic OS X NSSegmentedControl background;

This is better than before, but still not perfect. I had a hard time getting the focus ring just right, so I gave up and left a bit of padding (mainly vertically) instead of adding a bunch of code to have it pixel-perfect.
Merging this will probably cause a conflict with #303 on ATZPluginWindowController.xib. The version of the xib in this PR should be preferred as it also includes #303's changes.

As always, comments and code review are welcome :)

Thanks @guillaume-algis and sorry for the delay! Totally missed this one


Add tutorials from Okta Developer Blog

Corrected some typos and add Okta Developer blog tutorials that use this library

Thx for this Matt. Very appreciated. Took a bit longer to merge this b/c of a busy "conference season".


Cache get method can still return null

The get method used to get rules and TLDs can return null as a default value. This will cause a type error from json_decode which wants a string. So to fix the issue, I just added a cast to string before both function calls.

@carlalexander thanks for using the library. I think that I understand your issue but the patch your are trying to apply will hide a more important problem. If you are getting a type error in my opinion it means that you have an issue with your cache system. Maybe you can no longer cache your data because the only way for the get to return null is that your local cache is empty and it's refresh has silently fail. My 2 cts

I also see what you mean. The issue here was that I ran into the issue populating the cache for the first time. So the cache was in fact empty like you describe, but I couldn't populate it without having this error first. I only resolved it by copying the class wholesale and adding that code.
It's possible it's a weird interaction with the SimpleCache implementation. I'm not sure. I'll close this.


Introduce df.spark.local_checkpoint()

Codecov Report

Merging #1878 into master will decrease coverage by 1.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
- Coverage   94.18%   92.45%   -1.74%
==========================================
  Files          40       40
  Lines        9862     9773      -89
==========================================
- Hits         9289     9036     -253
- Misses        573      737     +164

Impacted Files
Coverage Δ

databricks/koalas/spark/accessors.py
93.71% <100.00%> (-0.45%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/accessors.py
86.13% <0.00%> (-6.94%)
:arrow_down:

databricks/conftest.py
93.22% <0.00%> (-6.78%)
:arrow_down:

databricks/koalas/__init__.py
83.33% <0.00%> (-6.67%)
:arrow_down:

databricks/koalas/generic.py
90.56% <0.00%> (-4.79%)
:arrow_down:

databricks/koalas/namespace.py
79.57% <0.00%> (-3.45%)
:arrow_down:

databricks/koalas/testing/utils.py
78.57% <0.00%> (-1.95%)
:arrow_down:

databricks/koalas/typedef/typehints.py
90.35% <0.00%> (-1.76%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003a936...26bdc72. Read the comment docs.


Add files via upload

The maricopa.edu domain includes 10 colleges within the network of Maricopa Community Colleges.
For a list of compuses, see: https://www.maricopa.edu/colleges
All campuses operate under the maricopa.edu domain.
Here is the Bachelor of Applied Science (BAS) in Information Technology (IT) which is expected to take 8 terms to complete.
https://www.maricopa.edu/degrees-certificates/computer-information-technology/information-technology-9302-bas

@DeepHop I am sorry, the domain maricopa.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Type missmatch

Hello, I think there is something wrong with the typing:
Issue summary

Rules implements PublicSuffixList
its has this methodpublic function resolve($host): ResolvedDomainName

But the interface signature is different:public function resolve(Host $host): ResolvedDomainName;

It might not be a big deal, but when we use the PsRStorageFactory:
public function createPublicSuffixListStorage(string $cachePrefix = '', $cacheTtl = null): PublicSuffixListStorage

and PublicSuffixListStorage:
public function get(string $uri): PublicSuffixList;

So, since we don't use Rules directly but an interfaces, there are an error when calling with a string as stated in the README.
System informations

Information
Description

Pdp version
6

@lyrixx thanks for using the library.
Do you get an actual PHP error or is it that you think that there's an error. What you just described is called parameter widening and it is supported in PHP since PHP7.2 if I'm not mistaking. Unless I fail to understand your issue in which case a code snippet would help me understand it.

Indeed, there are no PHP error, but linter (vscode, phpstan) fails

strange that phpstan fail to that since this package uses PHPStan as one of it's static analysis tool and it never reacted to that 🤔 . Anyway, this is an expected behaviour since PHP7.2 so there's nothing I can do 🤷♂

so there's nothing I can do

Actually, you can :) You can change the typehint of the PsRStorageFactory :)

@lyrixx Why would I do that ? It returns Rules which is an implementation of the PublicSuffixList interface. IMHO It should not typehint on a specific implementation ? When using the factory you should only care about the interface never about any specific implementation. Unless you consider the factory to be specific to the Rules 🤔

Actually, I don't really know. I manage to make it work by using a Domain instance instead of a string.
But this was mentioned nowhere in the README that we could do like this.
May be a sentence in the README would be enough to fix this design issue (no offence!!).
I said design issue, because a lib should not leverage the contravariance rule internally ; this rule existe only for librairie wanting to update there signature to add typing without breaking code that use it. This is not the case here.

I need a code snippet to understand what we are talking about because I'm a bit lost. Is your issue around the storage services or around how the PublicSuffixList/Rules works ?
In my mind:

if you typehint with PublicSuffixList you should feed resolve with a Host object
if you typehint with Rules you can feed resolve with anything that may be accepted like it is explained in the README file

The Storage Facility should always be used with Interface and the fact that PublicSuffixListPsr18Client happens to return a Rules object is just an implementation detail.

According to the README, I could write:
$result = $publicSuffixList->resolve('www.PreF.OkiNawA.jP');

And I have the following class:
<?php

use Pdp\Domain;
use Pdp\Storage\PsrStorageFactory;

class DomainChecker
{
    private PsrStorageFactory $factory;

    public function __construct(PsrStorageFactory $factory)
    {
        $this->factory = $factory;
    }

    public function isSameDomain(string $firstDomain, string $newDomain): bool
    {
        $storage = $this->factory->createPublicSuffixListStorage('pdp_', new \DateInterval('P1D'));

        $publicSuffixList = $storage->get(PsrStorageFactory::PUBLIC_SUFFIX_LIST_URI);

        $currentRegistrableDomain = $publicSuffixList->resolve(Domain::fromIDNA2008($firstDomain))->registrableDomain()->toString();
        $newRegistrableDomain = $publicSuffixList->resolve(Domain::fromIDNA2008($newDomain))->registrableDomain()->toString();

        return $currentRegistrableDomain === $newRegistrableDomain;
    }
}

As you can see I had to write
Domain::fromIDNA2008($firstDomain)

Instead of
$firstDomain

(BTW: Am I using your library well?)
My point is:

There is a mismatch between the code we can find in the README and the code I have to write
There is a type mismatch between Rules and its interface PublicSuffixList. I know you are using "Parameter Type Widening" feature of PHP. But IMHO this is a wrong usage of this feature, since its primary goal is for adding a parameter in a library without breaking the BC.

I may be wrong about 2/, but this is what is stated by the RFC:

Implementing this RFC would allow libraries to be upgraded to use type declarations in their method signatures. Currently adding types to a method of a class in a library would break any code that extends that class.

This would provide an easier upgrade path for libraries to start using scalar types, to replace manual checks being done inside the methods, without requiring an update for all sub-classes.

Here, it seems you are using this feature internally, to allow more input type in the resolve() method, for ease the usage of the lib (which is super nice).
Anyway, thanks a lot for taking time to discuss about this issue which is not really important :)
Feel free to close it, if it's OK for you.
But, here is a list of options to address this issue if you want to:

use the same signature between the interface and the Rules class
add a new method (like resolveString(string $host)) in the Rules class that accept only a string. This method will use the resolve() internaly
update the README to emphasis this mismatch

Ok now I understand your concern so,
in your example what I would do is this
<?php

use Pdp\Domain;
use Pdp\Storage\PublicSuffixList;

class DomainChecker
{
    private PublicSuffixList $publicSuffixList;

    public function __construct(PublicSuffixList $publicSuffixList)
    {
        $this->publicSuffixList = $publicSuffixList;
    }

    public function isSameDomain(string $firstDomain, string $newDomain): bool
    {
        $currentRegistrableDomain = $this->publicSuffixList->resolve(Domain::fromIDNA2008($firstDomain))->registrableDomain()->value();
        $newRegistrableDomain = $this->publicSuffixList->resolve(Domain::fromIDNA2008($newDomain))->registrableDomain()->value();

        return $currentRegistrableDomain === $newRegistrableDomain;
    }
}

And the PsrStorageFactory would never appear in the code only in the DI configuration file.
Since you are typehinting with the Interface I find it OK to call Domain::fromIDNA2008 since that's how it should be used with the interface.
Now If you typehint against the Rules implementation I think that a smart DI container will do the resolution for you but then again in the README I do write the following:

TIP: Always favor submitting a Pdp\Domain object for resolution rather that a string or an object that can be cast to a string to avoid unexpected format conversion errors/results. By default, and with lack of information conversion is done using IDNA 2008 rules.

Which I think covers your use case. Granted this is written when talking about domain i18n conversion but it is written in bold.
Last but not least, note that in your case I use Domain::value instead of Domain::toString simply because it is more strict and avoid any typecasting issue.
Hope this clarify your issue... or I'm off topic.

Anyway, thanks a lot for taking time to discuss about this issue which is not really important :)

When designing version 6.0 I wanted to make it super DX-friendly so I do take into account remarks when people do actually use the lib and submit constructive questions/enquiries. If it can be improve let's improve it with interesting feedbacks like your ;)

OK, so to resume this issue:
I should always use the a Domain::fromIDNA2008() and not a raw string :)
Thanks for your help. We can close the issue

@lyrixx forgot to mention... I would call either the toAscii or  toUnicode method before calling the value method just to be sure that both domains are is the same representative mode

One last thing... Did you happen to use the lib in a previous release? And how do you rate the DX ? That's my curiosity speaking

Yes, I used the lib in the previous version, the DX was really simple.
And TBH, I was a bit lost during the upgrade (mainly because of this issue).
I read the README, and tell myself, ok it should be quite easy.
But then, after the cache was setup, I got the mismatch typehint.
Oh, and another thing: I the readme you talk about "The Public Suffix List" and "The IANA Top Level Domain List" but it's not obvious what is it. Maybe add a description for each + a sentence to help the dev to make a choice
I almost forgot, you lost me also with: $publicSuffixList = Rules::fromPath('/path/to/cache/public-suffix-list.dat'); => where does this list come from? when reading the whole readme, we understand how to get that with a cache. But I guess you know how developper are: lazy :p They like to copy paste code :) So I would rework a bit the readme with file_get_contents(...). It'll show even more the need for a cache layer
Thanks a lot for this discussion 👍🏼


The Mongo Shell loops in the installation

Type: Bug
I've updated to the newest version of ADS . I just connected to a Mongo cluster by using the provided Mongo settings . When I click on Open Mongo Shell the system is looping on Downloading the MongoShell see the log
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Done installing MongoShell
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Done installing MongoShell
Installing MongoShell to .azuredatastudio\extensions\microsoft.azure-cosmosdb-ads-extension-0.3.3\local-resources\v0.3.0\mongoshell\Windows
Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)Downloading https://github.com/Azure/azure-cosmosdb-ads-extension/releases/download/v0.3.0/mongoshell-1.6.0-win32-x64.zip
(34,679 KB)
Azure Data Studio version: azuredatastudio 1.44.1 (8f53a316fa00a98264f1ab119641cd540b5af25c, 2023-06-01T02:12:48.765Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.60GB (13.75GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

agent
Mic
0.49.0

arc
Mic
1.8.0

azcli
Mic
1.8.0

azure-cosmosdb-ads-extension
Mic
0.3.3

azuredatastudio-dma-oracle
Mic
4.1.2

azuredatastudio-oracle
Mic
0.1.3

azuredatastudio-postgresql
Mic
0.3.1

dacpac
Mic
1.13.0

import
Mic
1.5.5

net-6-runtime
Mic
1.1.0

profiler
Mic
0.12.2

schema-compare
Mic
1.19.0

sql-assessment
Mic
0.6.4

sql-database-projects
Mic
1.1.1

@languy I don't see the cosmosdb extension repo in my transfer issue target, could you please give me access to your repo so that I can transfer issues in the future?

@languy I don't see the cosmosdb extension repo in my transfer issue target, could you please give me access to your repo so that I can transfer issues in the future?

Done.

@languy I still don't see it, could you please do the transfer?

@alanrenmsft That's because it's in a different Org
Note: You can only transfer issues between repositories owned by the same user or organization account. A private repository issue cannot be transferred to a public repository.
@DavideDelVecchio I'm going to close this one, please reopen an issue in https://github.com/Azure/azure-cosmosdb-ads-extension so the owners can look at it there.

@Charles-Gagnon  done! https://github.com/Azure/azure-cosmosdb-ads-extension/issues/87


OrderedDictionary<TKey, TValue>

Ordering by key, should receive its IComparer<TKey> on construct, use default or use addition order

Bock? @moodl


chore(deps): upgrade all packages versions

Description

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (no code change)
[ ] Refactor (refactoring production code)
[x] Other

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have formatted the code with rustfmt.
[x] I checked the lints with clippy.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

I'd rather have this more explicit by updating the versions in Cargo.toml as well. Did you just run cargo update?

@orhun Yes, I just run cargo update to upgrade Cargo.lock. My main purpose is upgrade libc to 0.2.155 to build and run systeroid on loongarch64-alpine-linux-musl.

I see, then can you make the necessary changes in Cargo.toml (e.g. env_logger) or make this PR only scoped to update libc?


Build Networking Page

This page will show people in your network. It should show sent pending status and received request accept or deny. You should also be able to search for a user by name or email.

@Ronnie018 Did you want to take this one since you built this figma. I'm not %100 sure what all of your thought were behind this design. If not would you update this issue to explain what you would like here.

All right, i'll just try the video problem a while, and i jump right into it

@4-Leafs-Code, im pretty sure you asked me about how i did this somewhere, here it is;

i used a clip-path as a mask and positioned a ::before element absolute;

      .left-content {
        box-shadow: 1px 1px 15px #046b6b28;
        background-color: #ebebeb;
        height: 100%;
        width: 100%;
        position: relative;
        .header-container {
          & ::selection {
            background-color: #ebebeb;
            color: #077a7a;
          }
          &::before {
            content: "";
            position: absolute;
            width: 20px;
            height: 20px;
            background-color: #077a7a;
            bottom: -10px;
            left: 0;
            transform: rotateY("45deg");
            clip-path: polygon(56% 0, 55% 100%, 3% 51%, 4% 0);
          }

u can use https://bennettfeely.com/clippy/ to create clip-path masks.

You should add this to my book marks repository. That's kind of what I made it for. Originally it was to clean up my GitHub repositories but my book marks are crazy with all kinds of random cool coding trick sites. I was going to explore your code until I figured it out but I haven't had the chance.
Thank you Ronnie! I just was assigned a temporary laptop for the weekend. I don't have my software but can work in a code space as long as I have time in the space. Hopefully I'll get my regular laptop back on Monday. I've got  4 different courses I need to catch up on the work in so I'm cramming for the weekend but I'll have github open while I catch up on my schooling.

@Ronnie018 the page is coming a long lovely :heart_eyes: You can have my card pop up too.

@Ronnie018 I found these linter errors this morning. I was not sure if this was a work in progress thing or if these can be removed. Please let me know when you have a moment. Thank you so much!
src/components/Network/index.jsx
Line 4:10:   'UserImage' is defined but never used            no-unused-vars
Line 22:19:  'setFilters' is assigned a value but never used

Not sure about this last one, but it is a work in progress. i didnt know i had pull requested code with the context provider. Ill fix it now

You might want to give me a few minutes with these bot request before you work on the site incase I have to back track. Ill look at the commit number when I open codespace in a minate.

Gitlens information about this commit and PR is: last week via PR #275   (January 23rd, 2023 4:14 PM)
create private messages


Link to https://baconjs.github.io/ in the headline

At the moment the headline only contains the text "FRP (functional reactive programming) library for Javascript". Please consider adding a link to https://baconjs.github.io onto that same line – the GitHub UI provides an "Edit" button for the project maintainers. You can use that button to enter the github.io URL.

Done!


Capybara::Poltergeist::StatusFailError: check DNS and/or server status

Related to #677 and #791.  Since both are closed, I'm opening a new discussion.
Problem
When running tests, some will randomly fail.  The error is:
Capybara::Poltergeist::StatusFailError: Request to '<app sign_in page, port: 50994>' failed to reach server, check DNS and/or server status

Output with debug: true:
{"id":"76baef53-619e-405a-b940-18d680081839","name":"set_debug","args":[true]}
{"command_id":"76baef53-619e-405a-b940-18d680081839","response":true}
{"id":"206cb602-92fc-404a-a74c-4e70ad516795","name":"set_url_whitelist","args":["<required third party domain>","<local app domain>"]}
{"command_id":"206cb602-92fc-404a-a74c-4e70ad516795","response":true}
{"id":"04221ae6-0769-4b8f-b573-7a75bcf4dbc9","name":"visit","args":["<local sign in page, port: 50994>"]}
{"command_id":"04221ae6-0769-4b8f-b573-7a75bcf4dbc9","error":{"name":"Poltergeist.StatusFailError","args":["<local sign in page>",null]}}

Links redacted for brevity and privacy.
The code it fails on is always visit <path name>
Versions

phantomjs - 2.1.1
poltergeist - 1.14.0
capybara - 2.7.1
options - url_whitelist: %w(<3rd party> <local testing domain>) I have to redact the links.
os - OS X 10.11.4

Things I've Tried

Downgrading phantom
Precompiling assets in test env
Adding a timeout from 30-120 seconds
Adding ['--ignore-ssl-errors=yes','--load-images=no']

Other Comments
Some people say it only fails on their first test.  For me, it's seemingly random as to what tests fail.
There are no iframes on the pages that fail.

Solved!
We were using a custom domain that pointed back to localhost to test subdomains.  Adding that domain and subdomains to our hosts file as <IP_ADDRESS> solved the issue!

Glad to hear you solved it - I was in the middle of answering this, so I'll leave the explanation in place for others that come to this issue.
The only place StatusFailErrors can come from is https://github.com/teampoltergeist/poltergeist/blob/master/lib/capybara/poltergeist/client/browser.coffee#L111
That shows it can come from either timing out while there are open requests (but the second parameter in your log is null so it's not that), or from the request actually failing.  The null parameter would tend to indicate it is because the request is actually failing.

Oh, and is there a specific reason you're still on Capybara 2.7.1??  That's a pretty old version.

This is literally my first day of work at a new company and I was trying to get everything set up.
So I don't really know why we're using that version of Capybara, but I'll update as soon as I can!
Thanks for the swift reply


Fix pregroup swap rotation

Closes #257

You should have received an invite to become a collaborator of the repo so you can approve the PR and merge to main!

Worked!


Add boilerplate for nextjs react template

Add a boilderplate for nextjst react template. More input params (e.g. auth0 integration) incoming.

Template initially generated by npx create-next-app@latest
Tailwind css is replaced with plain css + MUI - instead of designing Tailwind+MUI base with freedom, we wanna stay with Material UI
Next Eslint is replaced with GTS eslint/prettier

Yes we'll need the content security policy :)


Remove Obsolete bt-semaphore

If I'm not mistaken, bordeaux threads has semaphores built in and the bt-semaphore library is obsoltete.

Oh! I wasn't aware of the deprecation notice, thanks for pointing out, I'll change the code to reflect the changes :+1:


Fix #384 (Invalid query on empty insert/select in)

Check if a queryresult would be empty

do not execute such queries, because they are invalid, instead simply
return nothing

Fix #384

Oh, nice! Do we handle empty arrays anywhere else? Can you add a test for this?

I realized that this fixes the issue only partially. I will try to add tests and provide a better fix for this in the next few days.

I've updated the implementation to handle more cases. Also I realized that this could also fix #384.
I'm not sure if I've implemented is_empty in all places where it is needed.

@weiznich I just remembered that I tried fixing that and @sgrif and I discussed an implementation in https://github.com/diesel-rs/diesel/pull/385, which resulted in our idea to refactor the error handling instead of introducing an is_empty method for this one case.

I think using a custom error for this would be problematic, because I think a user expect such queries to succeed. Furthermore with using an is_empty method we can save a call into the database, because we can reason about situations where the query would be illegal.

Any news on this? It's annoying and error prone to check in every place where you use eq_any or insert for an empty input.

@weiznich As mentioned, I'd prefer an implementation that looked something like https://github.com/diesel-rs/diesel/pull/385#issuecomment-236690138. The query would still succeed from the user's point of view, as we'd handle the error in the connection itself. See the discussion on the linked thread.

Going to tackle this tomorrow

@sgrif I've opened a pullrequst to @killercup repo which rebases and improves his pull request.


Check if current standard accomodated MPM/hMRI required metadata

Action for @christophephillips to map the metadata that is required for the hmri toolbox into the BEP001 recommendations and to check whether we're all covered.

How do you get BandwidthPerPixelRO? I know about BandwidthPerPixelPhaseEncode, but it is along the other axis.

Is PhaseEncodingDirectionSign the same as PhaseEncodingDirectionPositive (in Siemens)? I am not sure whether it is available in DICOMs from other vendors.

Some notes from the conversation on 9 October.

Can we match up each of these metadata fields to the dicom tags that they allign to?

We have an action going forwards to harmonise the current terms with the additional metadata terms. Plan is to clearly define the needed information first.

Are there some metadata fields listed above that are actually collections of other metadata from the scanner? We decided that it makes most sense to define the fields that come off the scanner rather than calculated ones.

Search for the "Method-specific priority levels for qMRI metadata" and "qMRI applications that can be derived from an existing grouping suffix" sections in the https://github.com/bids-standard/bep001/blob/indexable_metadata/src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md file

It would be great to be clear about which of the metadata fields are required vs desirable.

I have updated the list of parameters, see here, for the MPM sequence.
Good news: most of them fit with the current BEP001, only a handful should/could be added. And since BIDS relies on the 80/20 Pareto's principe, this may not be needed actually.
The description of the field maps, or raw data leading to the estimation of these field maps to be more precise, remains open to discussion at the moment, cf #51, #67, #73, #80.

Thank you @ChristophePhillips! I was just updating the MPM description on the suffix table and adding a link to the protocols suggested by hMRI (https://owncloud.gwdg.de/index.php/s/iv2TOQwGy4FGDDZ) :)


Some user services have undeclared dependencies on X

The Redshift user service needs X to be running before it can start. Currently it works because it simply fails repeatedly, and usually the delay between restarts is enough that after a while X happens to have started.
Probably the right thing to do is to depend on the new graphical-session user target in systemd 232.
This also affects the arbtt service, and perhaps others.

I think this commit is relevant https://github.com/NixOS/nixpkgs/commit/882391a1620f5179eab0f9f4b96f85af875cbb34
cc @fpletz

Yeah, the problem is that we can't depend on X directly when the user session starts. The new systemd 232 has graphical session targets which we have to try to integrate in order to fix this.

@fpletz the problem with wantedBy = [ "default.target" ]; is that a user instance spawned for root would also trigger the running of redshift which we do not want.
Have you done any work on converting the DE's to run via proper systemd targets?

@peterhoeg Exactly. I haven't done any testing so far but here is some context: https://github.com/systemd/systemd/pull/3678 (also look at the linked mailing list thread).

I know about that - I have some done some work here to make the kde services systemd activatable via dbus and use the new units in 232 to work like what Martin mentions in that PR but it is still very much work in progress and most definitely will not make it for 17.03.

Fixed some time ago.


[CI-CD] Set Up Automated Code Quality Checks with ESLint and Prettier

Desired Behavior
Integrate ESLint and Prettier into the CI/CD pipeline for consistent code quality and formatting checks across the codebase.
Proposed Solution

Add ESLint and Prettier configuration files.
Modify .github/workflows/ci-cd.yml to run ESLint and Prettier checks on each pull request.
Ensure that the pipeline fails if there are any code quality or formatting issues.

Hello @visheshrwl , can you assign me this task?

@Emilio-PdeA amazing work.
Consider starring the repo and hoping for more PR's from your side.


[Agent] Being able to access server through public IP, but have agents behind firewall.

Refer to https://github.com/rancherio/rancher/issues/55
In this issue, @feliksik has comments on overriding the CATTLE_AGENT_IP.
He is comment:
"Be aware of the following: The url that is generated by the server UI and should be executed on agent host, in order to start agent, seems te be based on the host/ip used by the browser. The agents will then try to contact the server on same socket.
This is not necessarily the way people want to use rancher. I envision accessing the server through a public IP, and having the agents behind a firewall, contacting the server on an internal network."

It looks like this is fixed for the docker orchestration functionality (although not for the networking) -- so this should be closed? I leave it to a developer that can actually judge it properly.

Is this really closed? From the answer it's not clear the initial intention is covered. Can rancher sit in a private network and tHe ui is exposed on a public one. may via a reverse proxy or load balancer?

Rancher is pretty flexible in its network configuration.
Breaking it down...
The UI needs to be able to hit the Rancher API in order to function, so the host needs to be exposed to your users. That can be over the internet, intranet, etc...
The nodes need to be able to register, which can be a separate IP address from the UI and websocket-proxy. The registration IP would need to be on the Rancher server still. So the server would need to be multi-homed or nat'd typical of cloud providers.
In order for the UI to fully work with logs, stats, and console access to the containers, all hosts will need access to the websocket-proxy AND all of your users will need to be able to access the websocket-proxy as well.
With this model, you can lock down the hosts running your applications. They only need UDP ports 500,4500 between them and outbound access to the websocket-proxy and Rancher registration endpoint. The ports on the control plane are well known, and can be ACL'd as you would any other network port.
Hopefully, that helps? :)


we should suggest to use @types/moment

as we use TypeScript 2 and @types we should suggest to use @types/moment instead of typings

Current coverage is 90.39% (diff: 100%)

Merging #1020 into development will not change coverage

@@           development      #1020   diff @@
=============================================
  Files               26         26
  Lines              781        781
  Methods            142        142
  Messages             0          0
  Branches           115        115
=============================================
  Hits               706        706
  Misses              75         75
  Partials             0          0

Powered by Codecov. Last update 4208f52...b2f9689

It works for me but you have a typo in npm

Agreed! But I though moment.js is already including typings
broken one, but still enough


No licence

Hey,
I want to use the code or parts of it in https://github.com/guysoft/fedigroup/
What license is it? Can I use it in a GPL/MIT project?
I can provide attribution the the project too.
Thanks!

Hello,
Sorry for the late response.
Sure you can use it. I am releasing a big Update to the code this weekend.
Hope this helps. Would love to see this project being used.
Kind regards,
Tim Ofenbach
Am 21. Apr. 2023, 10:31 +0200 schrieb Guy Sheffer @.***>:

Hey,
I want to use the code or parts of it in https://github.com/guysoft/fedigroup/
What license is it? Can I use it in a GPL/MIT project?
I can provide attribution the the project too.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

you can check out the dev branch for more features
ive also added a license for you to reference

Thanks for clarifying.
BTW the design element I need is the tweet card. which does not seem to be visible in the dev branch.

@guysoft
The tweetcard code is still present in the dev.
I've added an example usage on the front page.
I will recode the tweet card today to use the new cat design code structure fyi.


Maximum recursion depth exceeded for requests[security] introduced in 1.0.0b4

[x ] I am on the latest Poetry version.
[x ] I have searched the issues of this repo and believe that this is not a duplicate.
[x ] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: OSX 10.14.5
Poetry version: 1.0.0b4
Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/tonysyu/82b3fc28b01e0fec6e53cece29adc7db

Issue
While testing out the extras export fix for https://github.com/sdispater/poetry/issues/1313, I tried setting up a new project (with the pyproject.toml linked above) and ran into the following issue:
$ poetry --version
Poetry version 1.0.0b4

$ poetry add -v3 requests[security]
The currently activated Python version 2.7.13 is not supported by the project (^3.6).
Trying to find and use a compatible version.
Using python3 (3.6.5)
Using version ^2.22.0 for requests

Updating dependencies
Resolving dependencies... (13.7s)
Resolving dependencies... (13.8s)
[RuntimeError]
maximum recursion depth exceeded while calling a Python object

Running the same command on 1.0.0b3 works as expected
Running poetry add requests (without the extras) works as expected

I know where the issue is coming from and it has been introduced in https://github.com/sdispater/poetry/pull/1555.
I'll try to make a fix as soon as possible.
Sorry for the regression!

I don’t know if this is related, but it is happening on two projects of mine:
poetry update
Updating dependencies
Resolving dependencies... (4.2s)

[TooManyRedirects]
Exceeded 30 redirects.

Updated to 1.0.0b5 and confirmed the fix. Thanks!


refactor(card,modalbox): rewrite spacing modifiers for first/last children, whitespace formatting, doc updates for modalbox

fixes https://github.com/patternfly/patternfly-next/issues/672

Deploy preview for pf-next ready!
Built with commit 558aa98d99e99fd97e0987d774c9745a1ca77956
https://deploy-preview-673--pf-next.netlify.com

:tada: This PR is included in version 1.0.35 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Streaming server autogenerated port conflict with apiserver generated nodePort

Description
As described in title, we occasionally encounter this issue, restart containerd and regenerate a random port can solve this issue, using a fixed port for streaming server can fix this issue as well, but this is still a potential bug.
I'm thinking about using net.ipv4.ip_local_reserved_ports to avoid generating ports conflicting with apiserver. Or adding a configurable reserved port range in userspace.
Steps to reproduce the issue
No response
Describe the results you received and expected
Advices on solving the describe issue
What version of containerd are you using?
1.5.8
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

the default value of stream_server_port is zero, which means that the go runtime net.Listen will pick available port to use.
You can choose one port number not in the service-node-port-range. It will be fine.

Yea stream_server_port can perfectly solve the problem, but when 0 is used, port collision might happen which is not the expected behavior. net.Listen will pick a port which is not unused, since nodePort is written as a ipvs rule redirecting traffic, and ipvs rule has higher precedence. That means whenever ipvs rule is applied, port collision might happen.

Maybe the same with this issue: https://github.com/kubernetes/kops/issues/6342

but when 0 is used, port collision might happen which is not the expected behavior.

It should be scheduled before launch k8s cluster. :) It is not containerd's issue. Closing


Adding support for "insert ignore into"

These changes add support for insert ignore simply by copying and modifying the insert functions. This allows for the use of "insert ignore into" which is the same as an insert but suppresses errors for duplicate entries of unique keys.

I've created a package for UPSERT and INSERT IGNORE queries:
https://github.com/staudenmeir/laravel-upsert


Doesn't work inside modal windows

What is required for these to work in terms of divs around them?
This plugin will not work when placed inside a modal window... which is a big problem for me. I'm using fancybox, and need to find a way of displaying these sliders to take up the full width of the modal window.

I am having the same issue on Bootstrap 3

Also doesn't work when the div is hidden onLoad.
I tried this but doesn't work:
  $(".openthis").click(function() {
    $("#content").show("slow");
    $("#container1").twentytwenty();
  });

no one?


Fix missing owns in octavia controller

The Octavia controller was missing the Owns() field for the amphora controllers causing some amphora controller reconciliations to result in misconfigured pods.

Applying the hold tag for the sole purpose of discussing with team to make sure we are good to include this at this time.

/retest-required

/retest-required


”SĂLIȘTE”, ”Aciliu”, ”Amnaș”, ”Crinț”, ”Fântânele” are listed in the drop-down menu

Description:
When user writes ”SĂLIȘTE”, ”Aciliu”, ”Amnaș”, ”Crinț”, ”Fântânele” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "SĂLIȘTE"

Expected results
The location appears in the drop-down menu as "Oraș SĂLIȘTE, SIBIU (SĂLIȘTE)".

Step 3
Write in the search bar "Aciliu"

Expected results
The location appears in the drop-down menu as "Sat Aciliu, SIBIU (SĂLIȘTE)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Crinț"

Expected results
The location appears in the drop-down menu as "Sat Crinț, SIBIU (SĂLIȘTE)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Fântânele"

Expected results
The location appears in the drop-down menu as "Sat Fântânele, SIBIU (SĂLIȘTE)".

ENVIRONMENT: ui.orase
URL: https://peviitor-ro.github.io/ui.orase/
Browser: Google Chrome
Device: Laptop
OS: Windows 10 PRO
STEPS TO REPRODUCE:
Check TC: ”SĂLIȘTE”, ”Aciliu”, ”Amnaș”, ”Crinț”, ”Fântânele” are listed in the drop-down menu #5658 / Step7
Open URL in browser.
Type "Crinț" in the search bar.
EXPECTED RESULTS:
The location appears in the drop-down menu as "Sat Crinț, SIBIU (SĂLIȘTE)".
ACTUAL RESULTS:
"Sat Crinț, SIBIU (SĂLIȘTE)"  is missing in the drop-down menu and the follow message is displayed:  "Locatia nu a fost gasita!"

Fixed! Poti sa retestezi!