Remove unused file ExtensionTextureBasisU

Removes CesiumGltf/include/CesiumGltf/ExtensionTextureBasisU.h
The actual file is CesiumGltf/generated/include/CesiumGltf/ExtensionKhrTextureBasisu.h
Possibly caused by a merge conflict mistake between https://github.com/CesiumGS/cesium-native/pull/402 and https://github.com/CesiumGS/cesium-native/pull/443

Thanks @lilleyse!


Fixes #93 - Rendered resize handlers in wrapper (optional)

Proposed solution
Wrap handler divs in a wrapper if a custom class / style is provided.
Testing Done

Added a test case for handlerClass
Using in production code

Based on #93 issue

Thanks for your PR :)
But I still do not understand the issue...
Could you provide your rotated project minimized?

Unfortunately I'm unable to show you the code, but made GIF with real example. With wrapped span/div I can rotate the bars and still support resizing from sides as user expects. When I rotate whole resizable div the resize logic is opposite (for user un-logical). If you watch closely, you can see that I'm setting different rotate values for resize wrapper (also width/height to enable portrait resize).

Best regards,
Martin

@pionl Thanks for your reply 😄  Unfortunately I can not see the GIF image. Could you please re-link it??

Ok, github was unabel to fetch the gif. I've updated the comment and also inserting it here

Your explanation really helped!

HI @bokuweb , sorry I was out I missed the comment. I see you already made the change. Thank you!

@pionl Hi! I've merged this PR. Then I'm gonna release this change as v3.0.
https://github.com/bokuweb/react-resizable-box/tree/3.0
you can try it  by npm i -S re-resizable for now. (I'm gonna rename this package to re-resizable ).
Resizers wrapper is default on v3.0.0. you can pass handleWrapperStyle and handleWrapperClass props for resizers wrapper.
thanks.


Directory in Instructions doesn't work at least in my Arch Install

I run Arch, I went with the instructions on the page https://draculatheme.com/grub.
The Theme didn't work, it also was not detected with grub-customizer.
It was only when I used the Dir /boot/grub/themes that it automaticly appeared in the customizer and after that worked and looked great:)

Thanks! I tested and confirmed the same , now INSTALL.md file is updated to include correct documentation.Sorry for the inconvenience cause.


currency_pair gets back BTC instead of ETH price

If i use client.get_buy_price(currency_pair = 'ETH-EUR') i get back the BTC price instead of the ETH price. Am i doing something wrong or is this a bug?

@Alkhemeia did you get any updates on this issue?

If you hit https://api.coinbase.com./v2/prices/ETH-EUR/buy it will return a response with the right prices. The client should be building the same URI.
what kind of prices are you seeing?

@sh6khan Does it also work for ETH-US? Could I just hit https://api.coinbase.com./v2/prices/ETH-US/buy because I don't see a response now.

@iregina it would be ETH-USD not ETH-US.

Thank you! @sh6khan

I have this same issue too. Is this a bug?

I fixed this by going into the client.py file and modifying the code to look like this. Works just fine now, however would be nice for the files to come like this. But it's a simple fix that you can do on your own.
def get_spot_price(self, **params):     """https://developers.coinbase.com/api/v2#get-spot-price"""     if 'currency_pair' in params:         currency_pair = params['currency_pair']     else:         currency_pair = 'BTC-USD'     response = self._get('v2', 'prices', currency_pair, 'spot', data=params)     return self._make_api_object(response, APIObject)
And now the command works like so:
eth_price = client.get_spot_price(currency_pair = 'ETH-USD')

This is fixed in master by f9ed2249865c2012e3b86106dad5f8c6068366ed.

Doesn't the simpler:
currency_pair = params.get('currency_pair', 'BTC-USD')

Do the same thing as the if: ... else: condition but doesn't pop:
currency_pair = params.pop('currency_pair', 'BTC-USD')

make more sense. You don't need to send it with data if you have passed it as part of the url.

I think this has been fixed, but the pip and easy_install packages haven't been updated to reflect it.
This should probably be tagged as a dupe of #35.

So what is the best way to update this fix? Pull Master? Also, is there a schedule for updating the pip package with the fix?

2.0.7 was released January 26th 2018.


Swedish translation (reports)

No description needed

Some testing, thats why there is upload and deleting

Great to see more translations being added!


chore: Release v1.8.0

name: 'Release Checklist Template'
about: 'Checklist to create and publish a Zebra release'
title: 'Release Zebra (version)'
labels: 'A-release, C-trivial, P-Critical :ambulance:'
assignees: ''

Prepare for the Release

[ ] Make sure there has been at least one successful full sync test since the last state change, or start a manual full sync.
[x] Make sure the PRs with the new checkpoint hashes and missed dependencies are already merged.
(See the release ticket checklist for details)

Summarise Release Changes
These steps can be done a few days before the release, in the same PR:
Change Log
Important: Any merge into main deletes any edits to the draft changelog.
Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.
We use the Release Drafter workflow to automatically create a draft changelog. We follow the Keep a Changelog format.
To create the final change log:

[x] Copy the latest draft changelog into CHANGELOG.md (there can be multiple draft releases)
[x] Delete any trivial changes

[x] Put the list of deleted changelog entries in a PR comment to make reviewing easier

[x] Combine duplicate changes
[x] Edit change descriptions so they will make sense to Zebra users
[x] Check the category for each change

Prefer the "Fix" category if you're not sure

README
README updates can be skipped for urgent releases.
Update the README to:

[x] Remove any "Known Issues" that have been fixed since the last release.
[x] Update the "Build and Run Instructions" with any new dependencies.
Check for changes in the Dockerfile since the last tag: git diff <previous-release-tag> docker/Dockerfile.
[x] If Zebra has started using newer Rust language features or standard library APIs, update the known working Rust version in the README, book, and Cargo.tomls

You can use a command like:
fastmod --fixed-strings '1.58' '1.65'

Create the Release PR

[x] Push the updated changelog and README into a new branch
for example: bump-v1.0.0 - this needs to be different to the tag name
[x] Create a release PR by adding &template=release-checklist.md to the comparing url (Example).
[ ] Freeze the batched queue using Mergify.
[x] Mark all the release PRs as Critical priority, so they go in the urgent Mergify queue.
[x] Mark all non-release PRs with do-not-merge, because Mergify checks approved PRs against every commit, even when a queue is frozen.

Update Versions and End of Support
Update Zebra Version
Choose a Release Level
Zebra follows semantic versioning. Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]
Choose a release level for zebrad. Release levels are based on user-visible changes from the changelog:

Mainnet Network Upgrades are major releases
significant new features or behaviour changes; changes to RPCs, command-line, or configs; and deprecations or removals are minor releases
otherwise, it is a patch release

Zebra's Rust API doesn't have any support or stability guarantees, so we keep all the zebra-* and tower-* crates on a beta pre-release version.
Update Crate Versions
If you're publishing crates for the first time, log in to crates.io,
and make sure you're a member of owners group.
Check that the release will work:

[x] Update crate versions, commit the changes to the release branch, and do a release dry-run:

# Update everything except for alpha crates and zebrad:
cargo release version --verbose --execute --allow-branch '*' --workspace --exclude zebrad --exclude zebra-scan --exclude zebra-grpc beta
# Due to a bug in cargo-release, we need to pass exact versions for alpha crates:
cargo release version --verbose --execute --allow-branch '*' --package zebra-scan 0.1.0-alpha.4
cargo release version --verbose --execute --allow-branch '*' --package zebra-grpc 0.1.0-alpha.2
# Update zebrad:
cargo release version --verbose --execute --allow-branch '*' --package zebrad patch # [ major | minor | patch ]
# Continue with the release process:
cargo release replace --verbose --execute --allow-branch '*' --package zebrad
cargo release commit --verbose --execute --allow-branch '*'

Crate publishing is automatically checked in CI using "dry run" mode, however due to a bug in cargo-release we need to pass exact versions to the alpha crates:

[x] Update zebra-scan and zebra-grpc alpha crates in the release-crates-dry-run workflow script
[x] Push the above version changes to the release branch.

Update End of Support
The end of support height is calculated from the current blockchain height:

[x] Find where the Zcash blockchain tip is now by using a Zcash explorer or other tool.
[x] Replace ESTIMATED_RELEASE_HEIGHT in end_of_support.rs with the height you estimate the release will be tagged.

Optional: calculate the release tagging height

Add 1152 blocks for each day until the release
For example, if the release is in 3 days, add 1152 * 3 to the current Mainnet block height

Update the Release PR

[x] Push the version increments and the release constants to the release branch.

Publish the Zebra Release
Create the GitHub Pre-Release

[ ] Wait for all the release PRs to be merged
[ ] Create a new release using the draft release as a base, by clicking the Edit icon in the draft release
[ ] Set the tag name to the version tag,
for example: v1.0.0
[ ] Set the release to target the main branch
[ ] Set the release title to Zebra  followed by the version tag,
for example: Zebra 1.0.0
[ ] Replace the prepopulated draft changelog in the release description with the final changelog you created;
starting just after the title ## [Zebra ... of the current version being released,
and ending just before the title of the previous release.
[ ] Mark the release as 'pre-release', until it has been built and tested
[ ] Publish the pre-release to GitHub using "Publish Release"
[ ] Delete all the draft releases from the list of releases

Test the Pre-Release

[ ] Wait until the Docker binaries have been built on main, and the quick tests have passed:

[ ] ci-unit-tests-docker.yml
[ ] ci-integration-tests-gcp.yml

[ ] Wait until the pre-release deployment machines have successfully launched

Publish Release

[ ] Publish the release to GitHub by disabling 'pre-release', then clicking "Set as the latest release"

Publish Crates

[ ] Run cargo login
[ ] Run cargo clean in the zebra repo (optional)
[ ] Publish the crates to crates.io: cargo release publish --verbose --workspace --execute
[ ] Check that Zebra can be installed from crates.io:
cargo install --locked --force --version 1.minor.patch zebrad && ~/.cargo/bin/zebrad
and put the output in a comment on the PR.

Publish Docker Images

[ ] Wait for the the Docker images to be published successfully.
[ ] Un-freeze the batched queue using Mergify.
[ ] Remove do-not-merge from the PRs you added it to

Release Failures
If building or running fails after tagging:

Tag a new release, following these instructions...

Fix the bug that caused the failure
Start a new patch release
Skip the Release Preparation, and start at the Release Changes step
Update CHANGELOG.md with details about the fix
Follow the release checklist for the new Zebra version

I set the ESTIMATED_RELEASE_HEIGHT to ~ Monday.

PRs excluded from the changelog:

change(deps): Initializes cargo vet in Zebra (#8641)
fix(lint): fix a new lint for the last clippy version (#8611)
deps(orchard): Update orchard for zebra-consensus (#8529)
deps(zcash_proofs): Update zcash_proofs from 0.13.0-rc.1 to 0.14.0 (#8527)
feat(build): use Docker Build Cloud for image build (#8374)
fix(ci): Add missing jobs to workflows patch (#8578)
fix(ci): do not silently fail integration tests (#8631)
fix(codespell): typos (#8612)
build(ecc):Upgrade remaining ECC dependencies (#8568)
ref(ci): Use a single CI workflow for tests (#8575)
build(deps): bump the devops group with 2 updates (#8590)
build(deps): bump the prod group with 2 updates (#8571)
build(deps): bump the prod group with 5 updates (#8519)
build(deps): bump the prod group with 7 updates (#8557)
build(deps): bump tokio-util from 0.7.10 to 0.7.11 in the prod group (#8509)
build(deps): bump curve25519-dalek from 4.1.2 to 4.1.3 in the cargo group (#8625)
build(deps): bump the devops group across 1 directory with 5 updates (#8574)
build(deps): bump the devops group across 1 directory with 6 updates (#8545)
chore: Bump zcash_primitives, orchard and zcash_proofs (#8615)
chore: Manually update dependencies (#8643)
chore: Update checkpoints (#8652)
chore: Update the PR template (#8591)

I added the do-not-merge label. We should not merge this PR until the full sync tests are green.

Rebased onto main.

The non_blocking_logger() test failed in the Windows coverage tests, likely due to a port conflict:
https://github.com/ZcashFoundation/zebra/actions/runs/9716184252/job/26819276525#step:12:7731
Re-running the Windows coverage tests and opened https://github.com/ZcashFoundation/zebra/pull/8658 to address the port conflict issue in the non_blocking_logger() test (it was missed in https://github.com/ZcashFoundation/zebra/pull/8624).

Thank you for the thorough suggestions. I applied all of them.


fix(content): remove cooldown on charge spell

https://youtu.be/CqzZ_Qsw7RE this video shows charge had no cooldown. This video shows him packeting, which is why the charges are 'queued' up

Do you want to unassign the varp as well?

Do you want to unassign the varp as well?

%charge_god_spell is checked for the god spell maxhit


EvalError vs dynamic language exception causes

The purpose of EvalError is designed to abort script when syntax or language errors occur which are considered unrecoverable. These are meant to include the JAVA equivalent of conditions which normally result in compile time errors.
There were arguments raised by @drosenbauer and @opeongo that while BeanShell aims to be a dynamic scripting language it enforces unnecessarily strict conditions by conforming to all the same language parameters as JAVA does. There may be some of the static typed exceptions which should not apply to a dynamic typed language in general.
BeanShell affirmed its policy on the JAVA likeness #501 which clarified that while BeanShell aims to "work like java" it must not be mistaken to also mean that BeanShell will "break like java does". Which implies that should BeanShell not fail like JAVA for the conditions of a certain compile time error it would not be in violation of the policy including where StrictJava compliance is concerned.
For the purpose of finding an appropriate BeanShell centric solution the scope of the problem needs to be clearly defined by producing a comprehensive list of all the causes that previously were considered EvalError, identifying clear distinctions and associate appropriate types which may lead to the allocation of the appropriately typed dynamic language exceptions.
The initial analysis of the previous errors can be collected at the BeanShell EvalError list google docs sheet. Anyone who wants to assist can email me for write access.

Updated the working spreadsheet to include all throw new EvalError instances in source code.
UtilEvalError also results in EvalError and needs to be mapped as well. Some of the non AST eval errors thrown should probably be UtilEvalError and needs to be investigated.
ReflectError as produced by Reflect.java also appears to result in EvalError which needs to be investigated as well.

This is not so bad, your spreadsheet lists that there are only 54 of them.  This is not unmanageable.
Is the issue here to go through this list and for each case determine if the error is truly non-recoverable, or if it is not so bad and that if caught then the intepreter could continue?  Do I understand this correctly?
If so, then we will need a new type of Exception that is less serious than EvalError that is catchable within scripts.  If we could start from scratch I would suggest that we use

NonrecoverableEvalError instead of the existing EvalError, and
EvalException for situations that could be dealt with.

However, legacy code... so maybe keep EvalError as is and add EvalException.  It is almost too similar to EvalError but it does indicate a lesser severity.  (Note that EvalError is actually a subclass of Exception, so out of whack from the beginning).
Can I get write access to the spreadsheet to add some annotations to it?  How can I pm you my email address?

From #262
The parser error is a separate issue, this is valid java and should parse.
What the OP is actually after is for beanshell to report an incomparable types error.
Ex:
jshell> new Double(1) == "test"
|  Error:
|  incomparable types: java.lang.Double and java.lang.String
|  new Double(1) == "test"
|  ^---------------------^

Bad operand types may also suffice:
jshell> 1 == "test"
|  Error:
|  bad operand types for binary operator '=='
|    first type:  int
|    second type: java.lang.String
|  1 == "test"
|  ^---------^

Edit: Although this treads close to "will not fail like java does"

I am getting started to have a look at this one. As mentioned previously the approach will be:

create a new exception named EvalException.  This will be used for exceptions arising within BeanShell that do not corrupt interpreter state and where recovery within the calling script is possible.
examine each location where EvalError is currently being thrown and asses the impact of the error.  For example, a name not being found during a lookup does not corrupt the interpreter.  It does mean that evaluation of the current statement/block cannot continue.  Annotate the list of source locations with the result of the assessents.
change EvalError to EvalException in these locations.
change the handling within BSHTryStatement.java so that catch and finally blocks are run for EvalException's

I made some progress working through the working spreadsheet of EvalError sites.  I was working off of the master branch so a few of the call sites and locations have changed.  It is slow but easy going to have a look at what is happening at each site.
Many of the call sites are handling runtime issues of syntactical or semantic errors, or name lookup misses as the code is being dynamically executed.  For these I have added a column to the spreadsheet with a snippet of code to trigger the error.  It is easy to see what is happening:  the dynamic evaluation comes across an error (e.g. name not found) and processing of the node cannot continue so an exception is thrown.   Nothing else is wrong in the interpreter.  These are the sites that can be converted in to recoverable exceptions.
Other call sites are covering issues that cannot normally be triggered by user code.  I suspect that some of them cover conditions that will never occur.  For example, in BSHMethod there is a test to make sure not to invoke an abstract method, but I cannot figure out a way to trick the interpreter into doing this.  There are also exceptions guarding locations that cannot be reached, like BSHArrayInitializer.eval().  There are many other sites guarding against utility methods throwing exceptions which normally should not happen.  These are the sites that should be left alone as non-recoverable exceptions.
Since this will only changed audited sites there is no real big damage if I miss some recoverable problems on this first go around.  In other words, if I don't capture 100% of the recoverable errors it is no big loss.  These can always be picked up and added later.  The thing to watch for is to not mark any non-recoverable errors a recoverable.  So false negatives are ok, but false positives are not acceptable.
So for the handful of confirmed site where the node cannot be evaluated but nothing else is wrong we can change the EvalError to be an EvalException.
The signature for Node.eval() is
    Object eval(CallStack callstack, Interpreter interpreter) throws EvalError;

The easiest way to make this conversion is to make EvalException extend EvalError, then the signatures throughout the code base do not have to change.
Then in BSHTryStatement add a catch for EvalException and allow this to be handled in BeanShell code.  EvalError exceptions will be handled as before.
Any comments so far?

Awesome great job, thanks for the work you put into this. I am merging #758 but if I understand correctly we are leaving this open for a round 2? Please advise...


Export xyz files

Export the cloud points in the XYZ file. The file can be open in CloudCompare to be mixed and eventually make a 3d object.
I think it keeps to code simple (as this code is for demo purpose) but makes this app useful too.
Eventually (maybe in another app?) give the possibility to capture multiple point cloud before sharing ...
By the way, thank you to make the code made by google simpler and understandable.

👍


[BUG] 403 error on rr get-binary

Our backend is running on roadrunner, inside a Docker image. During the build phase, after installing composer packages, we download the roadrunner binary (RUN ./vendor/bin/rr get-binary). This works locally, but fails in CI (BitBucket pipelines in our case):
Step 13/48 : RUN ./vendor/bin/rr get-binary
 ---> Running in 38967a8f42ad
 Environment:
   - Version:          2.*
   - Stability:        stable
   - Operating System: linux
   - Architecture:     amd64
In CommonResponseTrait.php line 178:

  HTTP/2 403  returned for "https://api.github.com/repos/spiral/roadrunner/re
  leases?page=1".

get-binary [-o|--os [OS]] [-a|--arch [ARCH]] [-f|--filter [FILTER]] [-l|--location [LOCATION]] [-s|--stability [STABILITY]]
The command '/bin/sh -c ./vendor/bin/rr get-binary' returned a non-zero code: 255

I suspect this is the GitHub API rejecting unauthorized requests or rate limiting me, but I'm not sure and there's no way to check. The only references to this issue I could find come from some obscure chinese websites with roughly similar content (eg. https://segmentfault.com/a/1190000040071984/en).
I know this isn't strictly related to Roadrunner, but I can't be the only one downloading the binary like this in a CI pipeline.
Could you extend the error message here, by including the response body for example? GitHub has pretty well defined response body for errors, that could help.
Even better would be to set an authentication header if GITHUB_TOKEN is set as an environment variable... I'd be happy to help troubleshooting here!
The version of RR used: 2.0
The operation system used: Linux
RR configuration file content:
not applicable
Errortrace, Backtrace or Panictrace:
not applicable

Hey @Radiergummi. Moved to the RoadRunner-cli from the RR.
CC: @wolfy-j @SerafimArts

Dang! I only had COMPOSER_AUTH configured for that repository. Setting GITHUB_TOKEN works fine. Thank you for pointing this out!


CORS error

When I try to access http://www.homecaredaily.com/feed/ in the demo is says CORs error even though it works fine, can this be worked around? Thanks!

@shaunc869  I had same issue with feedburner rss. I created a workaround and raised PR. Please see https://github.com/RSSapp/vue-rss-feed/pull/2 .
@max01app  Can you check feasibility of merging the PR?


BrowserWindow.webContents: Improve will-navigate event for HTML5 History API

Feature Request:
The will-navigate event does not trigger on pushState or replaceState which is a critical feature of many HTML5-based apps.
It would be great to also have will-navigate trigger or have a new event to support the History api.

It is possible to get events when an in-page navigation happens, but there is no way to prevent that, and it would probably require a big patch in Chromium to achieve this.
So I suggest just overriding pushState in preload script.

@zcbenz, my app is using angular, so I just send an IPC message at the moment when navigation occurs. I'm not really interested in preventing navigation though...
I tried will-navigate, but it does not trigger it with pushState...

@KevinMartin You can use navigation-entry-commited event for now, which is not public yet, the parameters are (event, url, inPage, replaceEntry).


DUPLO-17034 Mount targets details are missing in TF state file

Fix for mount_targets details are missing in TF state file for duplocloud_aws_efs_file_system resource
This PR does the following:

Added API that returns details for mount_targets schema attribute for resource duplocloud_aws_efs_file_system
...

Testing performed

[ ] Using unit tests
[ ] Manually, on my local system
[✓ ] Manually, on a remote test system

Describe any breaking changes

...

Task linked: DUPLO-17034 TF Provider:efs_file_system: Mount targets details are missing in TF state file

/'update_changelog --pr_update_changelog.push_changelog_changes=true'

/review

/describe


NIFI-9601 Upgrade nifi-bootstrap to Jakarta Mail 2

Description of PR
NIFI-9601 Upgrades nifi-bootstrap from javax.mail 1.4.7 to jakarta.mail 2.0.1 following the same approach as changes to the PutEmail processor. Additional changes include removing an unused test class and adding a basic unit test for the Email Notification Service to exercise initial property configuration handling.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

+1, thanks @exceptionfactory


[Bug]: Exporting result sets in Excel format without column headers is invalid

ODC version
odc423
OB version

What happened?

What did you expect to happen?
Result set without column header
How can we reproduce it (as minimally and precisely as possible)?
Export Excel result set, select not including column headers, export
Anything else we need to know?
No response
Cloud
No response

pass


Add support for GL-C-007 2ID version

GL-C-007 2ID have issue when on destination endpoint 15 is used source endpoint other than 1.
Quirk is probably not perfect, but at least both lights are working (on/off, dimmable, rgb selection)
Issue: CCT light part have RGB selection and not color temperature selection.

What is the problem that it is fixing?
What do you mean by "GL-C-007 2ID have issue when on destination endpoint 15 is used source endpoint other than 1." ?
What radio are you using?
Can you provide logs?
Cause I don't understand how this fixes the issue, as it effectively kills any ZCL cluster general command like Read Attributes, Write Attributes etc

It fix problem with second light (on endpoint 15), see logs: https://pastebin.com/rA4x5uBp
The issue is following: when I want to communicate with the light on endpoint 15, then I must use source endpoint 1. Unless it fails (see pastebin)
When I use the source endpoint 1, then it is successful, see: https://pastebin.com/rT44yfku
Radio: TI CC2531 USB CDC
If you have another suggestion how to solve this problem, then I will be happy.

Ah, ok. Yes, there's a problem, but the problem is with zigpy_cc library.  I'd recommend switching to zigpy_znp library for TI radios and give it a go. Pretty sure that would fix the problem without requiring this quirk.

You are right. I did not believed, but tried to force the znp in HA and now it works.
Many thanks!


Packagist/composer not pulling 0.1.6

For some reason the latest version is not pulling in properly via composer. It simply removes the package completely unless I peg it to a previous version.

Looks like the tag is 0.1.6 but it should be v0.1.6.
https://packagist.org/packages/signifyd/signifyd-php

The tag in git is v0.1.6. I'll see if we can force push the latest release.

Fixed - packagist was using the version number in composer instead of from the tags of the release.


Improve collision performance

Have you done performance testing to see if this actually improves performance? I'm not convinced this would be faster, it might even be slower because more branching is used.
In practice, most checks will have an x, y and z component. This new code would require 9 branches for the most common collision check, while the current method requires 1.
Your code has a max stack size of 3 due to nesting, while the current code has a max stack size of 1. This means more overhead.
I'm unsure why you removed final from the points.

Thanks for the feedback. I've did performance testing, and it shows improvements of 5-90% (on average 40%) in CPU usage and 550% in RAM usage. If the changes are indeed slower, I'd be glad to close this PR.

After checking performance, this does actually appear to be a significant performance improvement. Not sure how, but it's definitely better. Good work, I'll merge this


Feature Request: Collaborative Tagging

Hello,
It would be great if VoTT could be expanded to allow for Collaborative Tagging. There are multiple parts that I would imagine would be required:

Identification of different taggers (user profiles)
Comparing the tagging between taggers and tag validation
General metrics on the tagging efficiency
Quick updates to new/additional tags created
Project permissions
Communal tagging standard (share examples of what to tag within the project, might be a MD style document?)

+1 especially for larger projects is needed

Implementing Collaborative tagging could also be done by simplifying the vott file.
For example, instead of using the security tokens and things like that, simple relative paths could be used. This would allow the users of this tool to upload the whole dataset to source control (e.g. git).
I think currently the tool tries to do more then is required. In my oppinion it should help do tagging and then allow for exporting in a specific format. Also copying the images again to the export directory is also now always the thing you want. For example if you want to have a simple CSV file that contains images + locations of the tags it would be way simpler to just generate that file with relative paths to the images.

@devedse I don't think that we need a simplier vott file, what we would possibly need is a mapping function inside of vott that allows us to map the location of the data relative to the local machine/user. i.e. one computer might have a network drive mapped to "P" while another machine might have it mapped to "K".
There is also the ability to be doing this all through a web portal and having a login screen before hand that handles the security aspect of it, then it would access different blobs/storage containers hosted on Azure. This would be an ideal situation for a "hosted" solution.
When you say upload to git, do you mean all the raw data (i.e. images), or do you mean all the marks/tags that you have selected in the text based formats?
A simple way of doing this would allow us to do merging of projects, i.e. we divide the data to be tagged, we create a tag file that has all the different tags that we will use, and when we are done, we merge the project, at that point we could get the metrics. The hard part as an end user of VoTT in this would be ensuring that people get an even split based on their workloads, speed of processing/tagging, and how you would do near realtime QA/QC of the tagging.
In addition, how you would manage conflicts with tags (same image, same object, different tag position), or how you would handle completly different tagging of in the same image. i.e. one image, one person tags 4 objects, the other person tags 6 objects etc.

@skywalkerisnull, I think having mappings and all that stuff just makes the whole process way more complex then it already is.
In my oppinion the VOTT tool is going past it's purpose of being a tagging tool and tries to do way more things then it should. Currently a lot of data is also duplicated (e.g. the id is in 3 places right now).
I guess I'll leave it up to the developers of the tool itself to make a decision but I think a short "re-evaluation" meeting might be in place.
To me something like this would make way more sense:
Project.vott:
...
"Images\Img1.png" {
   ....
}
...

Directory Structure:
Project.vott
Images (Folder)
    Img1.png
    Img2.png

This makes everything instantly portable for a file system.
If you want to focus more on colaboration as well I'd suggest not storing the images in the vott file at all, as you'd have multiple writes to the same file then at the same time.
In the .vott file only the root path of the images would be configured whereas the images itself could then be in a seperate directory with equally named .json files which contain tagging information. (They already do exist but are partial duplicates of the information in the .vott file).
Another solution could be is storing all the data in a cloud database but in my oppinion this would make the integration with any of the cloud platforms too tight.
Final note, I know this is not a final solution, but in my oppinion some re-evaluation might be needed to make the best out of this tool :)


Prefer TLS connections

The current Neon onboarding starts by a suggestion to import my data. Yet as far as I can see, all of the current Neon documentation guides developers to use unencrypted connections.
I see from the Certificate Transparency logs that you already have a Let's Encrypt wildcard certificate for *.cloud.neon.tech.
I think it makes sense to have secure defaults. Please switch the psql -h pg.neon.tech command and all of the example connection strings in the documentation and in the code samples to use TLS.
Great to see Neon take shape! You're building an exciting service.

Makes sense. So far, password flow (<project>.cloud.neon.tech) is using only TLS -- even if you try to connect without TLS our proxy will not allow this. But pg.neon.tech is a bit different and configured without TLS now. Will fix


Setup SSO across apps

I'm still unsure of how it can be done, but I think it should be based on OAuth2+Open ID while ideally still supporting LDAP for backward compatibility.
Possible products:

Authelia
Authentik
Keycloak

Cancelling this issue as the number of services is still growing and most of them do not offer enough flexibility for this kind of feature

This has actually been done now, using Authelia


Localization with Transifex

The sources of the project have been uploaded to https://www.transifex.com/projects/p/web-pycones-2015/. Docs and more info in PR commits.

@python-spain/pycones-2015 any suggestions?


sui move prove -- --verify does not respect pragma verify

Steps to Reproduce Issue

sui move new mre2
Create the following module sources/five.move:module mre2::five {
    public(friend) fun five(): u256 { 5 }

    spec five {
        pragma verify = true;
        // this function never aborts
        aborts_if false;

        // purposefully wrong!
        ensures result == 4;
    }
}

Run (cd mre2; sui move prove)
Run (cd mre2; sui move prove -- --verify none)

Expected Result

sui move prove will successfully ignore mre2::five::five, and verify the "rest" of the package
sui move prove -- --verify none will fail to verify mre2::five::five

Recall that sui move prove -- --help outputs
$ sui move prove -- --help
The Move Prover

Usage: package [OPTIONS] [PATH_TO_SOURCE_FILE]...

Arguments:
  ...

Options:
      ...
      --verify <SCOPE>
          default scope of verification (can be overridden by `pragma verify=true|false`) [possible values: public, all, none]
      ...

Meaning that sui move prove -- --verify none  should only run the Move Prover for the mre2::five::five function due to its pragma verify = true, and therefore fail with its incorrect specification.
Actual Result
Verification with sui move prove -- verify none succeeds, as pragma verify = true is unable to override the --verify none option.
System Information
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.6 LTS
Release:        20.04
Codename:       focal

$ rustc --version
rustc 1.73.0 (cc66ad468 2023-10-03)

$ sui --version
sui 1.12.0-1b5f809a1

Support for the prover is being sunset, so this can be closed; see #15480


Details about Guided Anchoring

I notice a detail in Section 4.1 in the Paper: 'In the multi-task loss function, we simply use λ1 = 1, λ2 = 0.1 to balance the location and shape prediction branches.'
However, all config files in 'configs/guided_anchoring/' show that loss_weight of both loss_shape and loss_loc are 1.0.
Could you give me some hints?

In the original implementation, there are some minor differences with the hard coded numbers, thus the value of loc loss is 10 times larger than current implementation. In the released version, the loss weight is simply set to 1.0, which is equivalent to the original implementation with loss weight 0.1.
BTW, this loss weight actually has very limited affects to the performance.

Thanks for your explanation.


Add become: yes to ansible/roles/*/handlers/*yml

A few handlers are missing become: yes

This is fixed.


Support for local LLM

Hey,
Great work !
Is there a way to use local models instead of chatGPT ?
Would an openAI compliant API server work ?
Thx,

Any OpenAI compliant API server should work, you just need to include a base_url to your model spec when setting your KAIT_OPENAI_KEY e.g.
[
      {
          "model": "<MODEL NAME>",
           "base_url": "http://localhost:8000/v1",
           "api_key": "_"
      }
]

I'll update the docs with details on setting this up.
I quickly tested it with llama-cpp-python and FastChat and both work, but I'll need to do a bit more testing on which models give the best output.


Unicode ligatures in variable names (suggestion)

▶ Weird unicode ligatures behaviour
Python interpreter interprets unicode ligatures as two or more characters they are made of. If we explicitly declare variables using globals() it doesn't switch. This example uses ﬁ ligature
https://en.wikipedia.org/wiki/Ligature_(writing)#Latin_alphabet
Output (python 3.9):
>>> ﬁg = 4
>>> fig
4
>>> globals()
{'__name__': '__main__', '__doc__': None, '__package__': None, '__loader__': <class '_frozen_importlib.BuiltinImporter'>, '__spec__': None, '__annotations__': {}, '__builtins__': <module 'builtins' (built-in)>, 'fig': 4}
>>> globals()['ﬁg'] = 6
>>> ﬁg
4
>>> globals()['ﬁg']
6

Variable named ﬁg with ligature ﬁ gets saved with both the name of the ligature and "normal" letters.
We can also use ligatures on previously "normally" defined variables:
>>> fis = 9  # normal f i s
>>> ﬁs  # ligature
9

💡 Explanation:

Unfortunately I cannot explain  as I came up with this on my own. Probably am not the first.

Tried it on 3.9.7. Worked as expected:

foo = 6
globals()['foo']
6
globals()['foo'] = 7
foo
7

@soft9000 Not sure if I understand your comment correctly. @IamMusavaRibica point is, that this behaviour you describe does not work if the variable contains ligatures.
I can confirm the behaviour on Python 3.8. Maybe report this as bug at https://bugs.python.org/ instead to check if it's intended behaviour?

Tried it on 3.9.7. Worked as expected:

foo = 6

globals()['foo']

6

globals()['foo'] = 7

foo

7

he used ligature ﬁ (check this link for more details https://graphemica.com/ﬁ ) instead of normal fi. Basically, they don't have the same characters, so the result must be different.

Tried it on 3.9.7. Worked as expected:

foo = 6

globals()['foo']

6

globals()['foo'] = 7

foo

7

He used ligature ﬁ (check this link for more details https://graphemica.com/ﬁ ) instead of normal fi. Basically, they don't have the same characters, so the result must be different.

Exactly. My guess is that interpreter takes it as two separate characters. Which is entirely incorrect to me because len() of a ligature is 1. If globals are modified directly then the ligature is retained


Productivity and Flow...

Hey , thank you for your extension , it's really usefull for me to do my work in social media whilst avoiding their cunning distractions really good Job!! ,however there is minor problem , the qoutes are ditracting me while I am working and is killing my flow , How do you think you can solve this issue?

Hi @Revanth736,
We can add an option to display custom text instead of quotes. The custom text can be HTML or left blank to show nothing. Would that solve your issue?


Using Reflux without mixins [question, usage]

What's the best way to go about using things like connect and some of the other mixins in a non-mixin manner? As I understand it, the react team is moving away from mixins in the future and I'm hoping not to rely on them too deeply.

Reflux doesn't depend on React. Mixins used in reflux won't break if React removes mixin support. Reflux provides Actions and Stores, and let's you provide your own "component" implementation.  The mixins provided are just convenience methods available, that use the existing React component lifecycle.
For example of connecting to stores within a React component using the lifecycle directly (instead of via the mixin), check out this example from the README.md

Sorry, you're correct. Was confused by some of the documentation at the time; are there plans to clean that up or better unify it? If there are or there aren't, I'm happy to help/get that started. Thanks!

Are you referring to the "[Mixins in stores]" section? Any thoughts on what could be improved?

Yeah, but maybe just more overall. Maybe it was just my being really new to flux and react, but I find some of the overalls organization a little confusing. I'll put some more structured thoughts together on it.

It is a fair departure from the typical flux implementation, and is designed to be a reactive approach to the flux paradigm.
Having a good understanding of reactive programming will make things go down a bit easier i think. The FRP style is a key part of how stores and actions make themselves observable, which is what decouples Reflux from React.
Facebook's Flux library is also independent of React, as it can be used as a architecture design pattern or framework for any front end library, but Flux uses a more immutable/isomorphic approach to achieve cohesion w/Flux -> React.


Remove VS 2012 adapter code

As part of dropping VS 2012 projects, can clean up the following code:

Remove C4005 disable for stdint.h (workaround for bug with VS 2010 + Windows 7 SDK)
Remove C4481 disable for "override is an extension" (workaround for VS 2010 bug)
Remove DIRECTX_STD_CALLCONV std::function workaround for VS 2012
Remove DIRECTX_CTOR_DEFAULT / DIRECTX_CTOR_DELETE macros and just use =default, =delete directly (VS 2013 or later supports this)
Remove DirectXMath 3.03 adapters for 3.06 constructs (workaround for Windows 8.0 SDK)
Make use of std::make_unique<> (C++14 draft feature supported in VS 2013)
Remove some guarded code patterns for Windows XP (i.e. functions that were added to Windows Vista)
Make consistent use of = {} to initialize memory to zero (C++11 brace init behavior fixed in VS 2013)
Remove legacy WCHAR Win32 type and use wchar_t

February 2016 release dropped VS 2012 projects.

April 2016 release includes some adapter code cleanup.

Finished code cleanup for upcoming June 2016 release


account pkg - impl waitForTranaction

See https://www.starknetjs.com/docs/API/classes/AccountInterface#waitfortransaction
depends https://github.com/NethermindEth/starknet.go/pull/302

Was addressed in #389


DCA setup and deployment for VEOIBD

Deploy DCA on shinyapps.io, after we confirm with @calkinsh that VEOIBD's demo will use synthetic/non-PHI data.

AC: DCA's test, staging and production instances have been deployed on shinyapps.io and tested.

@calkinsh have provided a summary of the VEOIBD Synapse project setup here

A testing instance has been deployed


Poetry doesn't resolve on MacOs Mojave

[x] I am on the latest Poetry version.

[x] I have searched the issues of this repo and believe that this is not a duplicate.

[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: MacOs Mojave

Poetry version: 0.12.12

Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/wilfredinni/8e51c186d7b352d506933380349c7c7a

Issue
poetry update command doesn't work on my Mac. Just stay in resolving dependencies. My machine with Manjaro Linux, a 7 years old laptop, resolves in 8 seconds the same pyproject.tom.

Tried this out because I'm also running Mojave on my Mac, but I wasn't able to repro. I got the following output:
Package operations: 24 installs, 0 updates, 0 removals

Writing lock file

  - Installing pytz (2019.1)
  - Installing sqlparse (0.3.0)
  - Installing appdirs (1.4.3)
  - Installing atomicwrites (1.3.0)
  - Installing attrs (19.1.0)
  - Installing click (7.0)
  - Installing django (2.2)
  - Installing entrypoints (0.3)
  - Installing mccabe (0.6.1)
  - Installing more-itertools (7.0.0)
  - Installing pluggy (0.9.0)
  - Installing py (1.8.0)
  - Installing pycodestyle (2.5.0)
  - Installing pyflakes (2.1.1)
  - Installing six (1.12.0)
  - Installing toml (0.10.0)
  - Installing black (19.3b0)
  - Installing coverage (4.5.3)
  - Installing django-debug-toolbar (1.11)
  - Installing flake8 (3.7.7)
  - Installing mistune (0.8.4)
  - Installing psycopg2-binary (2.8.2)
  - Installing pytest (4.4.1)
  - Installing python-decouple (3.1)

I am on Poetry 0.12.11, though; what happens if you downgrade? Perhaps a bug was introduced in the newest release.

@tuchandra the first time I install the dependencies I have no problem either. Can you try to use poetry update and see what happens now? Thank you.

Running it again works fine:
Updating dependencies
Resolving dependencies... (0.3s)

Nothing to install or update

:/

Removed Poetry, all the virtualenvs and cleaned the cache folder, then reinstalled it. All is good now.

@wilfredinni sounds about right
Here is a related issue, which may offer a bit of explanation (TLDR has to do with cachecontrol/filelock libs)
https://github.com/sdispater/poetry/issues/832#issuecomment-480708729

@wilfredinni  Since this seemingly is not about OS, and since there are known resolutions, could you  edit the ticket title and/or close the ticket?

@wilfredinni Since this seemingly is not about OS, and since there are known resolutions, could you edit the ticket title and/or close the ticket?

Sure.


Remove unused @Slf4j annotations and imports

The following script was used to remove the offending instances, run from the root of the project:
foo="$(git ls-files ./*.java)"
while IFS='' read -r file || [[ -n "$file" ]]; do
  if grep --quiet -F '@Slf4j' "$file"; then
    if ! grep --quiet -F 'log.' "$file"; then
      sed -i -r -e '/^@Slf4j/d' -e '/^import lombok\.extern\.slf4j\.Slf4j;/d' "$file"
      git add "$file"
    fi
  fi
done <<< "$foo"

Can you double check if this is still catching all of the unused ones after recent changes?

Good call, looks like the last commit of the image removal PR removed a lot of log statement calls from IOException handling. I've rebased for the most recent run of that script.


[SEDONA-36] Parquet reader & Writers

Is this PR related to a proposed Issue?
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-36
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-14
The issue is realted to serializing & deserializing Spatial RDDs into Parquet files with a schema
What changes were proposed in this PR?
Serializing & Deserializing issues in Spatial RDDs into Parquet Files.
How was this patch tested?
Unit Test cases & Integration tests are in place. Not touching existing code flow thus previous functionalities should not get affected
Did this PR include necessary documentation updates?
Yes

Does this follow the https://github.com/geopandas/geo-arrow-spec arrow geo spec? Will it be possible to store metadata about the used projection (CRS) inside the parquet file (like geo-package). I believe geo-pandas is doing this as well.

@swamirishi Thanks for your contribution. However, currently, Sedona DataFrame can be saved and loaded as Parquet files. I am not sure if we need this function for RDD. We have the adapter to travel between RDD and DataFrame.
Could you elaborate more about the purpose of this PR?

@swamirishi Thanks for your great work. This PR sounds interesting to me. However, this seems to be a big PR so we need to have a thorough review for this.
So far, this PR contains many file changes: 47 files changed so far. Can you avoid changing POM files unless it is necessary? Currently, you duplicate the dependencies to different Sedona modules. Please only keep your changes to Sedona core module if possible. This will be helpful for us to review.
Can you also make your PR pass our CI test?
@Imbruced @netanel246 @Sarwat Folks, please take a look when you have time.

@swamirishi Thanks for your great work. This PR sounds interesting to me. However, this seems to be a big PR so we need to have a thorough review for this.
So far, this PR contains many file changes: 47 files changed so far. Can you avoid changing POM files unless it is necessary? Currently, you duplicate the dependencies to different Sedona modules. Please only keep your changes to Sedona core module if possible. This will be helpful for us to review.
I had to shade Avro Parquet as there is a conflict with the Sernetcdf library. I have moved modules into dependency management. Those are not duplicate now a module would use only the libraries it would require. Thus making the dependency requirement for the project uniform throughout.
Can you also make your PR pass our CI test?
Yeah have fixed the issue will push the code. Some issues after rebasing my branch with the master
@Imbruced @netanel246 @Sarwat Folks, please take a look when you have time.

@jiayuasu Is there a code base for org.datasyslab:sernetcdf? I see a bunch of classes google.common classes coming as part of libraries. This has version conflicts with the parquet library due to which I am getting runtime exceptions. In order to do away this I had to shade Parquet libs which isn't possible with the existing pom structure. Dependency management was the way to go about to circumvent the issue without touching the sernetcdf code. If there is a code base for sernetcdf can we look into changing the pom there?

@swamirishi The codebase of SerNetCDF is here: https://github.com/jiayuasu/SerNetCDF   which is owned by me. I think you can exclude some libraries in SerNetCDF dependency by using "" tag.
I guess the problem is caused by the dependency in SerNetCDF: https://github.com/jiayuasu/SerNetCDF/blob/master/pom.xml#L46

@geoHeil  @jiayuasu @Sarwat  I have fixed all build errors and also have reverted the pom changes. Please take a look at the PR.

This PR is massive, need some time to review it fully.

What about essential documentation updates ? Am I missing them ?

What about essential documentation updates ? Am I missing them ?

@Imbruced I have pushed the changes containing Documentation Comments

@jiayuasu @Imbruced @netanel246 @Sarwat Did you take a look at the PR? I would like to get this merged as soon as possible so that I can start working on the second phase.

Would this PR support multiple geometry columns in the parquet file? But one designated one for calculating the statistics at the row-group level?

Would this PR support multiple geometry columns in the parquet file? But one designated one for calculating the statistics at the row-group level?

Currently only one single geometry column per record. We can go ahead and support such features in later versions

Would this PR support multiple geometry columns in the parquet file? But one designated one for calculating the statistics at the row-group level?

Currently only one single geometry column per record. We can go ahead and support such features in later versions. The stats are stored on Schemas Column Path. So for multiple Columns the Stats stored would be stored on different paths.

@swamirishi
Thank you again for your patience! I traveled back to WSU and the new semester just started. So I was kind of overwhelmed by many things on my plate. Now I am ready to work with you!
I personally are very excited about this PR but I think the reason why several committers hesitate to approve this PR is that
(1) it does not have a detailed proposal to explain the proposed file structure and how it works. We know the overall idea of having a geospatial Parquet file and it is an awesome idea for sure. But it is unclear to us how this is achieved in this PR.
(2) it contains 44 file changes which are too many to be reviewed by a human... It touches several critical places in Sedona. For instance, it adds a new module called Parquet, adds some Sedona exceptions, change some dependencies. More importantly, it changes the core/SpatialRDD.java file which will affect many places.
Therefore, I believe here are some action items
(1) would you please add a Sedona website doc in this PR to explain
* The usage of Sedona Parquet reader and writer
* The structure of the proposed geo Parquet file, especially the metadata structure
* the algorithm: how it skips irrelevant data chunks by comparing the spatial query predicate and Parquet metadata
You can put this doc at https://sedona.apache.org/tutorial/ as a programming guide for geospatial Parquet
(2) for the file changes themselves
* please fix the comments raised by @Imbruced
* Please address my comment for SpatialRDD change
* please remove all whitespace file changes, and changes that just include "re-formatting the code"
Once these changes + doc are done and we fully understand what this PR is doing exactly, I will approve this PR. Let the customers give it a try. I believe once this PR is accepted, your follow-up PRs for the Parquet file will quickly pass our review.
Thank you again for your contribution. We really appreciate your contribution!
Jia Yu

@Imbruced I have addressed the review comments. Can you check if I need to change something else

@swamirishi
Can you also address my comments? Then we can move to accept this PR.

Once these changes + doc are done and we fully understand what this PR is doing exactly, I will approve this PR. Let the customers give it a try. I believe once this PR is accepted, your follow-up PRs for the Parquet file will quickly pass our review.

@jiayuasu @Imbruced Please take a look at the PR now. I have made the required changes for supporting Generic Geometry Type SpatialRDD. I have added a section pertaining to SpatialRDD - parquet Deserialization & Serialization in the file docs/tutorial/rdd.md.

@swamirishi
Thank you for your contribution!
I will accept this PR into a separate branch: parquet-io. I will need to make some changes to this PR myself such as how to package dependencies.
Meanwhile, you can submit new PRs to the sedona/parquet-io branch to continue your next phase implementation.
Thanks,
Jia


[WIP] blockbench: fix darwin build

Description of changes
Testing the OfBorg build

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build blockbench

@ofborg build blockbench

@ofborg build blockbench

@ofborg build blockbench

@ofborg build blockbench

@ofborg build blockbench

@ofborg build blockbench

[x] tested on x86_64-darwin, ventura, /nix/store/mvs3ydmp9x50p3kb47rjz900fj5mc18n-blockbench-4.10.0

Result of nixpkgs-review pr 313183 run on aarch64-darwin 1

1 package built:

blockbench


Save a cursor as a .cur file

I saw the todo to send the cursor to the brower as a .cur file instead of an ico.
See this code https://github.com/MathewSachin/NIco/blob/master/Models/Cur.cs to save a cursor to a .cur file. It's basicly an Icon file with a different header and the hotspots are in the Plane / BitsPerPixel fields.

Thanks! I guess you're refering to https://github.com/cedrozor/myrtille/blob/master/Myrtille.Web/GetCursor.aspx.cs#L73 (and the  CreateCursor method); I'll try this asap (if I can have the mouse cursor working for IE, it would be nice :))

Implemented into myrtille 1.6.0 (to be released soon).
I went into a slightly different way, adapting the code I found here: https://gist.github.com/darkfall/1656050 to create a .cur instead of .ico, following the outline described here: https://en.wikipedia.org/wiki/ICO_(file_format)#Outline
Mouse cursors are now working fine into IE (all versions) :)
Thanks again!

Great work!


Improved logging when process exits and php select exceeds file descr…

Improved shutdown logging to display signal code.
Echoing in default PHP select event wasn't triggering any error handler.

Thanks


Deploy issue of sysvad

I can rebuild the sysvad solution, but when deploy it, below error is reported. And I cannot find solution by Google, even cannot understand it. And it is urgent for me to solve it. Anyone could help?
System.IO.FileNotFoundException: Could not load file or assembly 'WDTF.Interop, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified. File name: 'WDTF.Interop, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'at Microsoft.DriverKit.DefaultDriverPackageInstallationClass.PerformDefaultDriverPackageInstallation()

Hi, I recently ran into this exact problem and was just as desperate as you. After an eternity of troubleshooting, I gave up and re-installed the latest windows 10 version on the test PC, then updated it to the latest version using windows update. After that I follow Microsoft's provisioning procedure and if just works like a charm. I guess there was some issue with the old Windows version that we both ran into.
I hope this helps although by now you probably have solved this problem.
Cheers!


[pnnl/SHAD#34] added a simple C++ runtime API implementation

This mapping should be the default one
Simple, single thread/single locality implementation
Mappings have been grouped in a folder under include/runtime

@VitoCastellana : did you receive my comment on this pull request?


Replace Ansible Tower with Automation Controller

Codecov Report

Merging #33 (3675b6f) into main (64b3209) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   27.02%   27.02%
=======================================
  Files          55       55
  Lines         629      629
  Branches      133      133
=======================================
  Hits          170      170
  Misses        407      407
  Partials       52       52

Impacted Files
Coverage Δ

src/messages/messages.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b3209...3675b6f. Read the comment docs.


Feature Request: in article view, add extra space to solve partial-page scrolling when near the end

I have no idea how to do this. We can’t just blindly add space in the rendered HTML without causing other problems.

I don't think I know what I'm looking for here.

Oh, when scrolling a page at a time. Got it.


MH-13034: Add lis_person_sourcedid back as LTI source field for the username

MH-12840 (ef7bc8e94936b426bec5cb52f846d81c8c903657) change the use of the LTI field lis_person_sourcedid to ext_user_username which is Moodle specific. This adds lis_person_sourcedid back in case ext_user_username does not exist.

I'll /review/ this.

also affects version 4.4 (and possibly 3.6)

@olabri it affects both. @gregorydlogan should I redirect this PR to the 3.x branch?

@mtneug, yes please. @slampunk, I don't have the knowledge base or support systems to review lti PRs so once you're happy with this I'll merge it to 3.x and then bring it forwards.

I updated the PR. @gregorydlogan shouldn't #378 then be merged in 3.x as well? Also, I could not update the Jira issue to include 3.7 to the fixed versions as it is not yet available.

@mtneug does #378's ticket affect the 3.x branch?  It's not listed in the affects version.  I'll create 3.7 in JIRA shortly and update MH-13034.

Sadly yes (see ef7bc8e94936b426bec5cb52f846d81c8c903657). Both issues were caused by the same commit (it seems I had a bad day writing the original patch 😢)

@mtneug fair enough.  Can you file a PR with the fix from #378 against 3.x then please?

@slampunk have you had a chance to take a look at this?
@mtneug I'm waiting on that PR right?  Or do I just cherry pick https://github.com/opencast/opencast/commit/ef7bc8e94936b426bec5cb52f846d81c8c903657 ?

@gregorydlogan , yep. didn't want to bother @mtneug since he's involved with external api work.
Short circuiting the highly trusted keys check (fixed by #378) resolves the issue, and OC uses lis_person_sourcedid as the external username (for Sakai at least... it should, in theory, apply to Canvas as well).

Sorry @gregorydlogan for the hold up. I just now came around to file the PR #403.


[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner)

When I try to use the plugin on ios it works however on android I get:
E/flutter (19227): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner).
I am using the latest version of flutter and dart to date I don't know if this has something to do with it, and I'm starting the application on a physical device with android version 11
Samsung galaxy a30s
To Reproduce

install the package
in your method:  String barcodeScanRes;
try {
barcodeScanRes = await FlutterBarcodeScanner.scanBarcode(
'#33E9FF', 'Cancel', true, ScanMode.QR);
VibratorPlugin.checkVibration();
print(barcodeScanRes);
} on PlatformException {
barcodeScanRes = 'Failed to get platform version.';
}
execute the method.

When I try to use the plugin on ios it works however on android I get:
E/flutter (19227): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: MissingPluginException(No implementation found for method scanBarcode on channel flutter_barcode_scanner).
I am using the latest version of flutter and dart to date I don't know if this has something to do with it, and I'm starting the application on a physical device with android version 11
Samsung galaxy a30s
To Reproduce

install the package
in your method:  String barcodeScanRes;
try {
barcodeScanRes = await FlutterBarcodeScanner.scanBarcode(
'#33E9FF', 'Cancel', true, ScanMode.QR);
VibratorPlugin.checkVibration();
print(barcodeScanRes);
} on PlatformException {
barcodeScanRes = 'Failed to get platform version.';
}
execute the method.

did you specify the android minSdkVersion and targetSdkVersion also compileSdkVersion?

you can use this one until the fix is merged
  flutter_barcode_scanner:     git:       url: https://github.com/JortdeBokx/flutter_barcode_scanner-1.git


[ai-text-analytics] Test pipeline failures for LRO

The Text Analytics nightly test pipeline is failing for the nightly test runs. The issue is being investigated with the service team in an email thread. The test will be skipped for now.
For reference, the issue for the failing pipeline is documented here

The service has fixed the issue.

This has been addressed.


Make sure users are prompted to install the PWA

On chrome android I am not being asked to install the PWA even though it is not one of my apps.
This is a regression from all previous versions.
I don't know what the installation dialogue window looks like but, if it's an option, if people decline to install the PWA three times then we can stop offering it.

No popup but it can be installed from a dropdown menu

@jbeard4 not fixed

it depend on some device, for some specific device it won't work.

This isn't working at the moment - if you are on yourpeer on mobile it should suggest adding it to the desktop

Works.


use ocw-hugo-projects course starter and remove localdev version

In ocw-studio, we are currently using localdev/configs/ocw-course-site-config.yml as a course site starter for importing legacy OCW courses and testing. Recently, we have been working on the ocw-hugo-projects repo to store Hugo and ocw-studio starter configs for OCW related projects.  One of the starters we've created there is the course site starter that should be used moving forward.  Rather than maintaining a separate yaml file in this repo, we should use the starter from ocw-hugo-projects moving forward.
Acceptance Criteria

Upon provisioning ocw-studio, the Github webhook code is fired and the starters from ocw-hugo-projects are pulled in and imported if they do not exist, or are updated if they are out of date
The course starter used in OCW legacy course import and testing should be configurable with a slug that is matched against what is pulled in from ocw-hugo-projects
The localdev/configs/ocw-course-site-config.yml file should be removed

if we transition to the .yml file in ocw-hugo-projects, what's the workflow for adding a new configuration option and developing locally with that change look like?

@aliceriot Locally, you can set GITHUB_WEBHOOK_BRANCH to any branch you create in ocw-hugo-projects and expose your local instance of studio with ngrok or something similar and every commit you make will fire a webhook that will trigger studio to ingest the starter configs there. You can then make a PR with your changes in ocw-hugo-projects and as it goes through the paces (release-candidate to release) the webhooks will file and automatically update the RC and prod instances respectively. It's not as convenient as just having the local yaml file just there in ocw-studio, but since the configs in ocw-hugo-projects are what we'll be using for Concourse builds moving forward it creates an awkward situation where legacy courses are imported and assigned to this other starter with a different slug that has to be updated manually to reflect changes merged in ocw-hugo-projects. I'm not exactly sure what the perfect solution is, but having these two starters with different slugs that aren't automatically in sync with each other feels sloppy and prone to human error.

For testing local changes to the starter, you could also import the config from Github into your local instance as is and then manually copy / paste your changes as you're testing them into Django admin.  Then when you're ready, make the PR in ocw-hugo-projects to update the config and as it goes through the release process the starters will automatically be updated across envorinments.

Another thought; maybe we could have a management command to manually update a starter by slug and point it to a local file specifically?  Something like ./manage.py update_starter <STARTER_SLUG> <STARTER_PATH>?  That way you could make the changes in your local copy of ocw-hugo-projects and updating it in your local instance of studio would be as simple as having a terminal open with that command ready and up->enter to refresh it?

Any way this could be automated and not require fiddling about with git URLs or messing around in another repo to try out a little config change would be good in my book I think. Editing the .starter JSON field on a Website record can work I think, but it would be nice to have some well-documented management commands or admin functionality for fetching things from ocw-hugo-projects and whatnot as well.
One thing we should be sure of I think, is that if we make a change to work with the ocw-hugo-projects starters by default we should put some time and effort into the tooling so that it's as painless as possible for local development, so that things are explained well and easy to configure, work by default, and so on.

@aliceriot FYI you can define local starter projects: https://github.com/mitodl/ocw-studio/tree/master/localdev. This lets you define your own configs then "import" them via management command

Another thought; maybe we could have a management command to manually update a starter by slug and point it to a local file specifically?

@gumaerc If I'm understanding correctly, the override_site_config already takes care of that


Proof of address for boats

On another topic: the boats stuff - we will not accept boat licenses, too much of an administrative task. Users who don't have council tax records, will need to upload proof of address with the name of mooring on it, if they don't have that, we will request users to upload a letter-headed declaration from the mooring provider - Name, address, mooring type, permanent resident of the boat.

Confirmed proofs


Very large mongodb database issues

Hello
I've been struggling with this problem a few days ago and cannot find a good solution, I have a mongodb table with more than 6 millions of records and I want to use yajra's datatables to show this data.
I'm using jenssegers/mongodb plugin
Code snippet of problem
(inside a controller)

       //model user
       $data = User::query();
        $dt = Datatables::of($data);

        return $dt->make(true);

And I get this message:
FatalThrowableError in QueryBuilderEngine.php line 119: Call to a member function wrap() on null
in QueryBuilderEngine.php line 119
at QueryBuilderEngine->wrap('row_count') in EloquentEngine.php line 57
at EloquentEngine->count() in QueryBuilderEngine.php line 89
at QueryBuilderEngine->totalCount() in BaseEngine.php line 499
at BaseEngine->make(true, false) in QueryBuilderEngine.php line 79
at QueryBuilderEngine->make(true) in UserController.php line 105
at UserController->indexData()
at call_user_func_array(array(object(UserController), 'indexData'), array()) in Controller.php line 55
at Controller->callAction('indexData', array()) in ControllerDispatcher.php line 44
at ControllerDispatcher->dispatch(object(Route), object(UserController), 'indexData') in Route.php line 203
at Route->runController() in Route.php line 160
at Route->run() in Router.php line 559
at Router->Illuminate\Routing\{closure}(object(Request)) in Pipeline.php line 30
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in SubstituteBindings.php line 41
at SubstituteBindings->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in VerifyCsrfToken.php line 65
at VerifyCsrfToken->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in ShareErrorsFromSession.php line 49
at ShareErrorsFromSession->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in StartSession.php line 64
at StartSession->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Router.php line 561
at Router->runRouteWithinStack(object(Route), object(Request)) in Router.php line 520
at Router->dispatchToRoute(object(Request)) in Router.php line 498
at Router->dispatch(object(Request)) in Kernel.php line 174
at Kernel->Illuminate\Foundation\Http\{closure}(object(Request)) in Pipeline.php line 30
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in TransformsRequest.php line 30
at TransformsRequest->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in TransformsRequest.php line 30
at TransformsRequest->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in ValidatePostSize.php line 27
at ValidatePostSize->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in CheckForMaintenanceMode.php line 46
at CheckForMaintenanceMode->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline\{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing\{closure}(object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Kernel.php line 149
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 116
at Kernel->handle(object(Request)) in index.php line 53

Passing a collection is not an option because is really slow (as the collection is really huge)
System details

Operating System Ubuntu server 16.04
PHP Version 7.0.13
Laravel Version 5.4
Laravel-Datatables Version 7.1.4 (latest)

Any help is REALLY appreciate!
Thanks

@manuel-binpar I think the problem here is on the mongodb driver package. wrap method is a standard function in Laravel's database which escapes the columns for sql injection protection. I think the issue should be raised on that said package? Thanks!


Request changes in the engineering product

[Enter feedback here]
While creating engineering change order requested by details are coming as empty , dur to this we cant move forward on change order management scenarios

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b14b6f89-ec69-0681-a1c0-0610d86d5093
Version Independent ID: 8d263a48-f14f-c68c-cce6-0cdc15086ea9
Content: Engineering change management feature walkthrough - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/engineering-change-management/engineering-scenarios.md
Service: dynamics-365-supply-chain
Product: ****
Technology: ****
GitHub Login: @t-benebo
Microsoft Alias: benebotg

Bug 803592 has been logged to address this issue.

@SajeerAssiz, thanks for contacting us. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, consider one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 community page to get help with your questions from the Dynamics community.


footer icons are modified

Related Issue
#1444
Fixes:  #(issue no.)
Description
before the icons are not redirected to desired pages,i have added that and modified  the newsletter part in the footer as it was a bit clumsy!
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[X] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
BEFORE:

AFTER:

Checklist:

[X] I have made this change from my own.
[ ] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

Hello @RishabhDhawad @anuragverma108 Kindly review the changes please!


feat(ingest/unity): Use ThreadPoolExecutor for CLL

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

We really need to add some databricks connector tests, if it's to be a high-ish priority source. There's some unit tests but their coverage is not great


Added a health care application to the Applications page

There is a strong history of using Bayes Nets in health care applications, so I thought I'd highlight one of the more famous ones from LDS hospital in Salt Lake City, Utah.

Also added some more specific details about how to do pull requests for Windows users. As it turns out, running jekyll on Windows is actually a real pain in the neck. But hopefully this will give some insight to other students who want to make pull requests so that won't have to wander aimlessly like I did trying to figure out how to make things work.


Possible to use relative paths for outputFormatters names?

I'm working on using cli2 in a CI/CD Pipeline (specifically Azure DevOps Pipelines).  A tl;dr is that this would be slightly easier if the name for the formatter I'm using (junit specifically, but all of them that write a file seem to use the name value in the same way) would accept/understand an absolute path rather than always treat it as a relative path.  I'm not sure offhand how difficult it would be to implement that, so it's not a deal-breaker if it's not possible/too difficult/introduces too much complexity.
A longer explanation:
Azure DevOps (and many other CI CD tools) have system variables that represent the places where stuff goes.  This makes your pipeline more dynamic, and prevents you from relying on assumptions about file system layouts (layouts that could change at some point).  As an example, Azure DevOps checks out the repository to something like /home/vsts/work/1/s.  This is also the working directory that scripts execute from.  There is a separate directory for test directory, something like /home/vsts/work/TestResults, represented by the variable Common.TestResultsDirectory.  If I want to put my test results there, I have to specify a name value of something like ../TestResults/Test-$(Build.SourceVersion).xml.  Then later on when I ingest the test results I can specify a path of $(Common.TestResultsDirectory)/Test-$(Build.SourceVersion).xml.  But this only works if the assumption continues to be true that TestResults is a folder that exists in the same directory as the working directory.  If I try to specify a name of $(Common.TestResultsDirectory)/Test-$(Build.SourceVersion).xml in my config file, the formatter treats it as "relative" rather than absolute.  The actual string value ends up being something like /home/vsts/work/1/TestResults/Test-99aa992c60de7d7e44d77e7c4d84359174b61d65.xml but the formatter looks in /home/vsts/work/1/s/home/vsts/work/1/TestResults/Test-99aa992c60de7d7e44d77e7c4d84359174b61d65.xml.

It might be as simple as using path.resolve() instead of path.join() and removing the reference to directory entirely here: https://github.com/DavidAnson/markdownlint-cli2/blob/79c5e552066e7ad28aca449e7f2eed692a603abf/formatter-junit/markdownlint-cli2-formatter-junit.js#L45
My guess is directory is being set to the present working directory somewhere else.  I know you've said in the past that directory is used for some "internal" stuff possibly related to the vscode integration, so I'm not sure what implication, if any, there would be in not using it in the formatters.

I agree with your assessment that path.resolve is more appropriate. directory should probably remain to support relative paths. This applies to the JSON and JUnit formatters.

It looks like the behavior of resolve is that if multiple absolute paths are passed, the last one will be returned.  And if no absolute path is passed, it will construct it based on the current working directory.  I'm not sure in what situation directory would not be the current working directory in a formatter, but whatever directory, if the name is an absolute path, path.resolve should figure it out.  I'll make a PR!

The change should be quick, testing may need special handling because absolute paths can't be hard coded due to cross-platform CI. There should be precedent, either run the test from code OR use a JS config that determines the absolute path at runtime.

Specifically, I'm thinking of another test directory like this: https://github.com/DavidAnson/markdownlint-cli2/tree/main/test/outputFormatters-params
Except use a JS file for config and populate the name parameter with something like path.resolve(__dirname, "custom.xml"). It may be necessary to further tweak that for Windows.
You'll use npm run update-snapshots to update the tests after adding an entry to the JS test file (don't forget to delete the output files as in the example I use).

I'm a little confused on how to actually implement a failing test. Not being much of any knowledge of the specific testing tools in use here, I've been able to surmise that the snapshots are going to be snapshots of a passing test, and the actual tests are going to compare the test results against the snapshot (though it is possible to modify the test cases so the snapshots fail).  So I'm not sure how to get a snapshot of a successful test that my fail can be compared against.
I was able to user your suggestion and copied output-Formatters-params.  I created a test case like this in markdownlint-cli2-test-main.js
testCase({
    "name": "outputFormatters-params-absolute",
    "args": [ "**/*.md" ],
    "cwd": directoryName("outputFormatters-params-absolute"),
    "pre": copyDirectory,
    "post": deleteDirectory,
    "usesRequire": true
  });

(I haven't pushed this up to GitHub yet, I can if you like).  I know from playing around that the execution is failing the way I expect it to.  For example, if I add a stderrRe to the test case I can confirm that the error is being written to stderr.  But it looks like that "failure" is being written into the snapshot and becomes the "expected" result that tests validate against.

I've published new versions of both formatters with your change:
+<EMAIL_ADDRESS>+<EMAIL_ADDRESS>

Sorry that I didn't have a chance to come back to this, but the tests I wrote look basically identical to what you ended up committing.
The workflow felt a little odd due to the "snapshot".  As far as I could tell the workflow to verify that a test fails is:

Make the change
Write a test that you believe tests the change, and take a "snapshot"
Remove the initial change
Run test, at this point it should fail

In the past where I've seen instances of test-driven-development you're able to immediately write a failing test before you write any code, but here it appears you need to actually implement your fix before you can make a test fail, because you need it to succeed before it can fail.

The workflow is a little bit weird because of how snapshots behave. You can update them at any time, so it's not that you are locked into the initial behavior, but yes, I did something like what you describe where I reverted your change to make sure that the test and snapshot would have failed without it.


When JSX is used, automatically import 'react' appropriately

Now if they use JSX, it will transparently import react and correctly reference the right createElement(). No more awkward import React from 'react';.
Before
import React from 'react';

const App = () => (

hello world

);

export default App;

var _react = __webpack_require__(35);

var _react2 = _interopRequireDefault(_react);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

var App = function App() {
  return (0, _react.createElement)(
    'div',
    null,
    'hello world'
  );
};

exports.default = App;

After
const App = () => (

hello world

);

export default App;

var _react = __webpack_require__(35);

var App = function App() {
  return (0, _react.createElement)(
    "div",
    null,
    "hello world"
  );
};

exports.default = App;

Anyone I show this ability to so instantly says "omg why didn't I use this earlier", so I imagine it is a welcome addition; but perhaps some will say it's "too much magic"...but let's be real, JSX is magic.
I could not find a test suite for create-react-app; I assume there isn't currently a test suite for the cli/scripts?

Thanks for the PR!
There is an end-to-end test in tasks/e2e.sh, it passed.
I think that, however, we won't take this. I'm worried that while this is great for a single project, it hurts the ecosystem. People will copy and paste their project code into StackOverflow answers or Gists but those won't work without that setting. Unlike CRA users, those who paste those files might not have a linter so they won't understand what's causing the issue.
If we change how this works we should do it consistently across the ecosystem.

@gaearon's point is pretty fair, but now the question is: can we fix the ecosystem?
I agree, that import React into module when this is not mentioned directly is wrong, because now every code-linting tool should assume that React is actually used however it looks like doesn't. It is actually a hack, that should not exist.
So, can we start to move the whole ecosystem towards the right direction at some point? This project seems like a good starter.

People use React in variety of situations including global UMD builds. The plugin doesn’t consider this use case (it emits an import but maybe the user wants a global access).
If you think it should be the default behavior of React JSX transform, please raise an issue with babel-preset-react in Babel repo, and let’s discuss it there. I don’t have enough context about the original decision to do it this way to give you a good reply.

@jayphelps maybe you could add a doc on how to add this feature (if this is possible without ejecting) ?

@sylvainbannier no way. It is not possible to add any babel plugin without ejecting


Refactor AWSSigV4 auth to support different AWSCredentialProviders

Description
Refactored sigv4auth support to use credential Providers.
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1389 (dfe1b83) into 2.x (a32bcbe) will decrease coverage by 0.10%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #1389      +/-   ##
============================================
- Coverage     98.38%   98.28%   -0.10%
+ Complexity     3698     3513     -185
============================================
  Files           345      316      -29
  Lines          9113     8531     -582
  Branches        585      535      -50
============================================
- Hits           8966     8385     -581
+ Misses          142      141       -1
  Partials          5        5

Flag
Coverage Δ

sql-engine
98.28% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...etheus/authinterceptors/AwsSigningInterceptor.java

...l/prometheus/storage/PrometheusStorageFactory.java

...h/sql/prometheus/storage/PrometheusMetricScan.java

...rage/querybuilder/TimeRangeParametersResolver.java

...metheus/storage/PrometheusMetricDefaultSchema.java

.../planner/logical/rules/MergeFilterAndRelation.java

...ql/prometheus/storage/PrometheusStorageEngine.java

...us/storage/querybuilder/StepParameterResolver.java

...rage/querybuilder/SeriesSelectionQueryBuilder.java

...thinterceptors/BasicAuthenticationInterceptor.java

... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


CAS-477 Relocate all components view to server views components

Context
Changes in this PR
Relocate all components from server/views/temporary-accommodation/components to server/views/components.
This is to help us have one location for all view components and better control over what we class as a view component.
Once this is merged, all developers should manually delete server/views/temporary-accommodation/components as it will still be present but will not contain any components

Given there are 2 versions of a few of the form field macros, would it be worth reducing the duplication and removing those that already exist in another form?


RigidBody in character mode

Godot version
3.5.1
System information
Ubuntu 22.04
Issue description
can't move with move and slide or add force, i can move in with set translation but it don't collide , there is someone that have create some custom move and slide for doing that?
Steps to reproduce
we set the rigidbody on character mode in order to continue to detect collisions (with kinematic body it doesn't work)
mode=RigidBody.MODE_CHARACTER
Minimal reproduction project
just set rigidbody to character and try to move and slide it

Related to https://github.com/godotengine/godot/issues/65808.

With Lock Rotation options, do you even need to switch to character mode?

Closing due to lack of response. Please comment if you can still reproduce this bug on the latest Godot version.
PS: Since no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.


#386 Feature Request: Notification Privacy

#386 Feature Request: Notifications format option which does not reveal name and message received
Adds two options under View / Pop-Up Notification:

'Show message in notifications'
'Show username in notifications'

Credit to @averissimo for most of this work.

Would it be possible to add functionality that would mute popup notifications but still mark the "#" on the dock?
When do these PR's typically get merged? There seems to be quite a few open.

They were usually merged quite fast up until the last one.
Hopefully someone with project privileges will have some time soon enough :)


FullOuterJoin with GroupBy

Added a example how to use full outer join with groupby clause

@omjain1 Thanks for contributing to this repo! pls share with your friends & enjoy the hacktoberfest✨🔥.


BAH-1755 | Added Orthopaedic examination json and updated concepts

created Orthopaedic examination with concepts revised by Akhil

need to have desk check with Akhil before moving forward

Please confirm if Akhil has approved the form elements. Will approve it here then.

have done desk check with Akhil yesterday and Gokul, they verified the form and approved it @gsluthra


Update Vulkan headers to 1.3.290

This PR updates the external/Vulkan-Headers submodule to v1.3.290
CI output here

CI gfxreconstruct build queued with queue ID 216911.

CI gfxreconstruct build # 4429 running.

All changes are in external files or generated files. CI tests passed. Looks good.