[BUG] Weird behaviour while using backlinks

Please confirm

[x] I am running the latest version of this plugin

Describe the bug
Fresh installion of the plugin, nothing customized at all.
Running on macOs, but besides that everthing is as recommended.
To Reproduce
Steps to reproduce the behavior:

Start nvim
Go to a note that has backlinks
Call the backlink function
A weird path appears on the telescope searchbox instead of the filename correctly.

Expected behavior
The list of files that links to the current file should appear
Screenshots

Operating system (please complete the following information):

macOs

Looks like the the full path of the file is included in the grep string. Maybe you telekasten home is not set properly in your initialization.
I just had a problem where backlinks did not work and the reason was that I used obsidian to when creating the files and it does not use subdirectories for the links. In my telekasten config, however, I had  subdirs_in_links = true, which caused the the backlinks search to include the subfolder and no files were shown. Once I fixed the config, chaning  subdirs_in_links = false, I properly get backlinks.

Setting subdirs_in_links = false also corrected this problem for me when I was playing around with (even though there was a subdir in the link, so not sure if that's the right behaviour or not.
But thanks @bergtholdt for the pointer!

@reisnobre Considering the inputs of @bergtholdt and @wakatara , should we still keep this open?

this fails for me due to the regexp formatting and escaping of brackets.
I can't find information in the telescope git on whether or not it supports regexp search patterns or how to enable/disable regexp parsing of search terms.
may be relevant: I'm using the telescope-fzf-native extension

@alexander-gabriel any new information on that? Does the issue still persist? Did you find a solution?

I have the same issue on Windows. When subdir_in_links is true, the entire path of the current file is included in the backlink regex. Setting subdir_in_links to false results in the correct pattern, but backlinks should add subdirs starting from the home directory.
Home for me should be set correctly:
		{
			"renerocksai/telekasten.nvim",
			cmd = "Telekasten",
			opts = {
				home = vim.fn.expand("C:/Users/me/Documents/Notes"), -- Put the name of your notes directory here
    },
},
			},

Find notes and find daily notes commands start at the correct directory.


Not able to bind ng-repeat values in my custom directives?

Hi,
I have created custom-directive called displayId. Using ng-repeat rendered custom-directive and bind id from ng-repeat data. Unfortunately not able to get id of element within custom directive.
    app.directive('displayId', function(){
          return {
                  restrict: 'EA',
                    compile: function(element){
  	                      alert(element.attr("id"));  //id displaying as op.id
                     }
         };
        });`

find the issue reproducible plnkr below.
https://plnkr.co/edit/3a8HBApCtbmYlGIfWyzM?p=preview

Hi, your issue reads like a support question. This github repo is only for bug reports and feature requests. Please try one of the listed Support Channels. Thanks!

@Narretz  yes i have tried and i can get id of element but can't view id in my dom element.
  app.directive('displayId', function(){
return {
  restrict: 'EA',
  compile: function(){

    return {
      pre: function ($scope, $elm, $attrs) {

      },
      post: function ($scope, $elm, $attrs, controllers) {
        console.log($elm);
      }
    }

  }
};
 });

i m getting element as like <display-id id="{{op.id}}"> </display-id> but i need like <display-id id="Title1"> </display-id> how to achive this at sample side


Slight tweaks to ipykernel util and tests

Current dependencies on/for this PR:

main

PR #10   👈

PR #11

This stack of pull requests is managed by Graphite.


ecom v2 - translations needed

@jprzybylski4 test page - https://ecommerceberlin.com/bmaptest (booths t1, t2, t2)

done


fix one-liner command

... since the URL returns a 301 with "Moved Permanently" HTML without the https.
Of course, I'm sure we'd prefer if the DNS got fixed and we don't need to type the full "https://" and we can throw this away.

Also tried pkgx.dev and that also yields a 301 page.

Thanks, indeed, this was an error


arguments are an array

Great stuff! I learned a few things.
I noticed you have written function's arguments variable as an object, but it is an Array.

@temi

The arguments object is an Array-like object corresponding to the arguments passed to a function.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments

Actually there's no big difference, you can test the following lines:
var fun = function(){
  console.log(arguments);
  console.log(typeof(arguments));
}
fun('hello', 'world');
// node v0.12.0
// { '0': 'hello', '1': 'world' }
// 'object'

// Chrome - Console
// ["hello", "world"]
// 'object'

It's not actually an instance of Array. It's "array-like" It has a length property and properties that are numbers for each argument, but it doesn't have any of the methods that arrays have, for example, it doesn't have a forEach() method.

I knew it as a special array. nodejs notation confused me. thanks!


Collect team vote and feedback on CDS Web Assessment

Done when votes and feedback are collected for

[ ] Adrianne
[ ] Luwam
[ ] Amy
[ ] Ravina
[ ] Nick
[ ] Dylan
[ ] Daine
[ ] Ethan
[ ] Melanie
[ ] Brock
[ ] Sam
[ ] Mario
[ ] Matilde


[Suggestion] Recosting & Rebalacing Spells (Fractional Costs and Cost Rebalancing)

As discussed with Wiresegal awhile ago (and now that I can type) I wanted to formally suggest a broad recosting of many of the spells we currently have. We discussed 3 goals:

Make some spells dramatically less expensive once you have acquired a flask.
Encourage the use of early game ciphers and trinkets rather than simply delaying the use of the mod until a Craft Phial scroll, some Chorus Fruit and a record have been found.
Make some spells less expensive overall to encourage their use.

WireSegal suggested setting a base cost expected (e.g., for break block it would be 1 dust) and then adding +0.125 to that cost. This is a trivial amount of power for a flask or trinket, but for non-flask casting effectively doubles the cost.
Spells that I propose are currently too expensive and should use a reduction (coupled with the extra overhead) include:

Blink: It's very expensive and unlike Impulse cannot be Thoth-chained. Recommended to reduce cost by half.
Explosion & Fireball:  Initial cost should be made fractional, reduce amplification cost somewhat. For mining, this spell is tricky to use. For PvE fights, this spell is less effective in most cases than using Impulse, except against the Ender Dragon.
Place Block: Recommend a trivial cost of 0.125 Dust.
Break Block: Recommended: 1.125 Dust.
Overgrow: Increase cost to 1.125 Dust. As it stands, this spell is so good it and Conjure Light are reasons to start using the mod.
Extinguish Area: Recommended to reduce cost to 1.2 Amethyst Shards
Recharge Item: Recommended to reduce cost, but I'm not sure by how much.

I hope I didn't forget anything. I compiled this list by looking over the Discord history for various conversations I and others have had, to try and collect feedback.

These all sound good! To be honest I really need to sit down and do a playthrough of the game with my mod ... but you sound like you know what you're doing.


[WIP][SPARK-29848][SQL] PostgreSQL dialect: cast to long

What changes were proposed in this pull request?
To make SparkSQL's cast as long behavior consistent with PostgreSQL when spark.sql.dialect is configured as PostgreSQL.

Why are the changes needed?
SparkSQL and PostgreSQL have a lot different cast behavior between types by default. We should make SparkSQL's cast behavior be consistent with PostgreSQL when spark.sql.dialect is configured as PostgreSQL.

Does this PR introduce any user-facing change?
Yes. If user switches to PostgreSQL dialect now, they will

get an AnalysisException if they try to cast to long from TimestampType and DateType.

How was this patch tested?
Test cases to be added

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thank you for contribution, @amanomer . But, unfortunately, we decided to remove PostgreSQL dialect via SPARK-30125 (#26763). Sorry about that. I'll close this PR.


Canvas typescript error

Description
Multi required prop of canvas element
Version
0.1.165
Steps to reproduce
use Canvas on .tsx file
Snack, code example, screenshot, or link to a repository

I understand that this feel like an easy reproduction on your side but there are a lot of variables we need to look at (ts version, react version, tsconfig, etc) and a git repository to reproduce the issue would be the optimal way for us to help.


All topics and users deleted

Describe the bug
In last week, two times I found all topics and users deleted from the cluster. The cluster was also in inoperable state (broker unable to start), I will create a separate bug for that.
Steps to reproduce the issue:
I do not know what triggered this problem.
Additional context
Using operator 0.2.3 installed via helm in GKE (1.14.7-gke.14) . KafkaCluster named 'kafka' is installed in 'infra' namespace, while KafkaTopic and KafkaUser objects are created in 'backend' namespace.
At some point (1-2 days after creation of the cluster), garbage collector suddenly deletes all topics and users. From the GKE audit log:
A 2019-11-05T23:01:23.950598Z Kubernetes Apiservice Requests update backend:audit-events system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.update","resource":"kafka.banzaicloud.io/v1alpha1/name… Kubernetes Apiservice Requests update backend:audit-events system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:23.959102Z Kubernetes Apiservice Requests update backend:audit-events system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.update","resource":"kafka.banzaicloud.io/v1alpha1/name… Kubernetes Apiservice Requests update backend:audit-events system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:23.967825Z Kubernetes Apiservice Requests update namespaces:kafkatopics:status system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.status.update","resource":"kafka.banzaicloud.io/v1alph… Kubernetes Apiservice Requests update namespaces:kafkatopics:status system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:24.167920Z Kubernetes Apiservice Requests update backend:twilio-api-delivery system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.update","resource":"kafka.banzaicloud.io/v1alpha1/name… Kubernetes Apiservice Requests update backend:twilio-api-delivery system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:24.197560Z Kubernetes Apiservice Requests update backend:twilio-api-delivery system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.update","resource":"kafka.banzaicloud.io/v1alpha1/name… Kubernetes Apiservice Requests update backend:twilio-api-delivery system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:24.216953Z Kubernetes Apiservice Requests update namespaces:kafkatopics:status system:serviceaccount:infra:kafka-operator-operator {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:infra:kafka-operator-operator"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.status.update","resource":"kafka.banzaicloud.io/v1alph… Kubernetes Apiservice Requests update namespaces:kafkatopics:status system:serviceaccount:infra:kafka-operator-operator
A 2019-11-05T23:01:36.007443Z Kubernetes Apiservice Requests update kafkatopics.kafka.banzaicloud.io system:serviceaccount:cert-manager:cert-manager-cainjector {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:cert-manager:cert-manager-cainjector"},"authorizationInfo":[{"granted":true,"permission":"io.k8s.apiextensions.v1beta1.customresourcedefinitions.update","resource":"apiextensions.… Kubernetes Apiservice Requests update kafkatopics.kafka.banzaicloud.io system:serviceaccount:cert-manager:cert-manager-cainjector
A 2019-11-05T23:03:39.901775Z Kubernetes Apiservice Requests delete backend:audit-events system:serviceaccount:kube-system:generic-garbage-collector {"@type":"type.googleapis.com/google.cloud.audit.AuditLog","authenticationInfo":{"principalEmail":"system:serviceaccount:kube-system:generic-garbage-collector"},"authorizationInfo":[{"granted":true,"permission":"io.banzaicloud.kafka.v1alpha1.kafkatopics.delete","resource":"kafka.banzaicloud.io/v1alp…   Kubernetes Apiservice Requests delete infra:kafka-cruise-control-topic system:serviceaccount:kube-system:generic-garbage-collector

The operator explicitly allows KafkaTopic/KafkaUser object to reference cluster in another namespace, but is it actually supported by kubernetes? According to documentation ( https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/ ) ownerReferences only work in the same namespace (and for cluster-wide resources).  There is also an open bug ( https://github.com/kubernetes/kubernetes/issues/65200 ) that makes cross-namespace ownerReferences behave in non-deterministic way. For example deleting all owned resources on restart of controller which might be happening in my case.

I haven't tested this personally on K8s 1.14.x, but on 1.15.x I was able to create a cluster in a kafka namespace and topics/users in the default namespace without issue. So I had assumed this functionality was solid. But looking at the doc you posted you are probably right that owner references should not be crossing namespaces.
A branch or two ago I switched it to placing labels on children KafkaTopic and KafkaUser resources, and using those to find resources to cleanup on a KafkaCluster deletion. I think it might be possible to take those owner references out now as they are redundant and it might take care of this.

You can create such cluster  and it will run without issue - for a time. The kubernetes bug I linked mentions that cross-namespace references should be immediately treated as missing. Instead it kind of works, until garbage collector controller restarts and it happens to process KafkaTopic/KafkaUser before processing KafkaCluster (so cluster's UID is not yet cached) - so we have non-derministic behaviour triggered by a race condition after controller restart.

Tasty. Well yea previous possible solution still stands. I can probably get this taken care of in the next day or two 😄. The owner references between users and their certificates will remain (as they are always in the same namespace), but the one between the cluster and topics/users is not really necessary anymore.

Update, I am going to take care of this on the PR I currently have open.
Someone might correct me on this, but if I understand correctly, that branch will split into two release tracks. There will be a point release on 0.7.x that contains the bugfixes and remains on cert-manager v0.10.x, and a new 0.8.x that runs on cert-manager 0.11.x. The update process between the two is a small PITA so it made sense to try to support both for a bit.

The PR #180  @tinyzimmer mentioned is in on both branches(master and 0.7.x). For multiple cert manager support we are going to support two releases, like you just said.

We just released Operator version 0.7.2 and 0.8.0 which contains the fix for this.


Add GHA script for deploying demo + Add barebones GH Tool for deploying arbitrary repo to AWS

Add GHA script that deploys demo to staging on push into (gha_staging for now, main later)
Add polling for DeployToAWS to check if its created service is launched
Create GH Tool for pulling repo + deploying it

Removed deploy from dind-builder container.
Implemented deploy_image from image uri in DeployToAWS tool.
Refactored GHA script to deploy using DeployToAWS._deploy_image.

TODO:

Fix implementation of dind-builder building + push to ecr.

Use this tool to push to ECR rather than letting GHA do it.

Does this PR update the same deployment or create a new deployment each time?

Updates, creating if dne

lmao idk why this is posting now


Doesn't Work

I've really tried everything, and I don't know why it doesn't work. I've used the default config file, changed repository visibility and no go. No external collaborator gets removed. How can I troubleshoot?

Found the issue. It was a case sensitivity issue with the CC line.


feat: trivial nontrivialities for free (constructions)

This adds some Unique and Nontrivial instances for free constructions, and some simp lemmas of the form of x ≠ 0.

Looks good to me, thanks!
Please imagine I insert Johan's copypasta about hitting bors merge when the build passes. :)
bors d+

bors merge


Localizer interception not smooth and consistent

Originally reported by @Fechulo in #711. Further detail available from n8rzz#66, n8rzz#86.

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


[Monitor] Extract Profiler as a separate tool

Profiler is part of the Monitor. It makes it difficult to use it, because it opens inside of the GT world, so it is not easy to profile GT itself.

Added Profiler to the home screen:

Which opens in a separate window:

And allows users to see the composition layers of the scene


RuntimeError: CUDA out of memory. Tried to allocate 22.00 MiB (GPU 0; 10.91 GiB total capacity; 10.03 GiB already allocated; 18.12 MiB free; 10.17 GiB reserved in total by PyTorch)

gpu  have enough space,but it always show this matter

剩余空间不足 调低batchsize 或者下载apex

原因找到啦：不能直接pip install apex 卸载从源码安装
pip uninstall apex
git clone https://www.github.com/nvidia/apex
cd apex
python setup.py install

How you solved Out of memory problem. I am still struggling with this even though I have GPU 1080Ti and I installed apex

原因找到啦：不能直接pip install apex 卸载从源码安装
pip uninstall apex
git clone https://www.github.com/nvidia/apex
cd apex
python setup.py install

大哥能否仔细说哈。。。


debug logging into seperate file for every vhost

Hey,
I see ngx_pagespeed itself do logging only to server_context file (global). Is it possible somehow to bypass this and set debug log for every vhost?
I tried to look into the source code, but there also is mentioned that debug is done in global error_log file only. I can change that this error_log file could be changed on request, but it will work not as expected.
Is it possible that this feature will be in later versions of ngx_pagespeed?
D.

Closing as a duplicate of MPS#500.


Enable ADC A-channels in K22F and K64F

In Kinetis chips some ADC channels have both A and B channels available.
This commit enables both of them. Previously only B-channels were available for use.
Added also some missing ADC channels to PinMap table.
Pull request solves the first issue of this question: https://developer.mbed.org/questions/58514/mbed-cant-handle-all-ADC-pins-in-Freesca/
Tested the functionality with following code using FRDM K22F
AnalogIn adc0_se15(PTC1); //SW button
AnalogIn adc1_se4a(PTE1);
AnalogIn adc0_se7b(PTD6);
while (1)
{
    Thread::wait(1000);
    printf("readings: PTC1: 0x%x, PTE1: 0x%x, PTD6: 0x%x\n",
                    adc0_se15.read_u16(),
                    adc1_se4a.read_u16(),
                    adc0_se7b.read_u16());
}

The output is as following:
readings: PTC1: 0xfe75, PTE1: 0xffea, PTD6: 0xeff3

... Button pressed
readings: PTC1: 0x0, PTE1: 0xffec, PTD6: 0x8d1f

... PTE1 pulled down externally
readings: PTC1: 0xfe70, PTE1: 0xf, PTD6: 0xeff0

... PTD6 pulled down externally
readings: PTC1: 0xfe3e, PTE1: 0xffeb, PTD6: 0x0

Can you please sign http://developer.mbed.org/contributor_agreement/ ? And share the nick, I could not locate any veltsup on mbed

I cant recall why only B channels were available back then, will review this soon

I'm "bro" in mbed. I have signed the contributor agreement. Tried to change the user name for something sensible, but it's not possible.


[SR-4806] huge json load

This PR adds ignore_json_size option in http header, which could skip the json body size checking.

We should support multiple json object in one stream load. In this way, it will be better to solve the problem.


DNS API not included

Current SDK Version
6.1.11
Use-cases
Automatically create DNS Zones/Records with the SDK
Attempted Solutions

Proposal
Please include the API from https://api.ionos.com/docs/dns/v1/ into the SDK, currently they have to be used with a standard REST client.
References
https://api.ionos.com/docs/dns/v1/

Hi,
Yes, the name sdk-go is misleading as it is used only for a subset of features(compute). It is an older name and could have been picled better at the time.
Thanks for creating this. We already have a generated dns sdk, but it's here.
If you wish to have multiple go sdks bundled in the same repo, we have them also here.
Let us know if there is anything you would like to see improved.


[#170704347] Expose Redis cache cluster node metrics from paas-metrics

What
This makes paas-metrics expose a aws.elasticache.cluster.nodes.count metric, giving the number of nodes in each Elasticache (Redis) cluster as well as some related Elasticache and CF metadata.
How to review

See if the tests pass;
Code review;
Deploy in a dev env and try with varying elasticache cluster sizes.

Who can review
Not @46bit @AP-Hunt.

The contents of this PR are covered in #2224 too, because this is branched from it. I'm closing the PR so that the reviewer can review one PR with many small commits.


Thread Collapsing

A thread collapsing feature could be implemented to allow users to easily navigate through comment threads by collapsing and expanding them as needed. This feature should include:

A mechanism for collapsing and expanding threads, such as:

Clicking on the vertical line to the side of the comments, representing the thread hierarchy.
Clicking on a button, like an arrow icon, that toggles between an arrow pointing to the side (collapsed) and an arrow pointing down (expanded).
Maybe long tap for mobile.

A user setting for default thread collapsing behavior, allowing users to set a nesting level threshold. This would enable users to see only the least nested comments by default while still having the option to expand threads as needed. Maybe ask which level people prefer and make it the default. I personally would set the threshold at 2.

Just wondering if there's any update on this one, since it got labeled as planned over a year ago.

I really like the way the Boost for Lemmy/Reddit app does this, maybe it could be done in a similar way?
https://github.com/user-attachments/assets/d254c183-684f-4c30-aa3c-efb6e78cccc8

I would really love some way to easily collapse replies. It is really what makes or breaks a good reply browsing system for me .


Add Create Vm Template wizard

VM Template List shows template provision source/os/flavor

requires https://github.com/kubevirt/web-ui-components/pull/134

@rawagner , please rebase, so we can include this in today's release

@mareklibra rebased


Bug: Indentation Error in method docstring

I have been experiencing a weird bug, and this is the most minimal example I have been able to come up with
test.py:
"""Minimal example of pydocstyle bug."""

class Bug:
    """Seems to only happen with method inside of a class."""

    def do_something(x):
        """Do something.

        Args:
            x: some value
        """
        print(f"""{x}
""")

If I run
pydocstyle test.py
I get
$ pydocstyle test.py
Traceback (most recent call last):
  File "ENVIRONMENT_PATH/bin/pydocstyle", line 8, in <module>
    sys.exit(main())
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/cli.py", line 68, in main
    sys.exit(run_pydocstyle())
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/cli.py", line 45, in run_pydocstyle
    ignore_decorators=ignore_decorators))
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 969, in check
    ignore_decorators):
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 123, in check_source
    for error in errors:
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 917, in check_docstring_sections
    yield from self._check_google_sections(lines, definition, docstring)
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 903, in _check_google_sections
    yield from self._check_google_section(docstring, definition, ctx)
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 796, in _check_google_section
    yield from cls._check_args_section(docstring, definition, context)
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 748, in _check_args_section
    yield from ConventionChecker._check_missing_args(docstring_args, definition)
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 762, in _check_missing_args
    function_args = get_function_args(definition.source)
  File "ENVIRONMENT_PATH/lib/python3.7/site-packages/pydocstyle/checker.py", line 1002, in get_function_args
    function_arg_node = ast.parse(textwrap.dedent(function_string)).body[0].args
  File "ENVIRONMENT_PATH/lib/python3.7/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 1
    def do_something(x):
    ^
IndentationError: unexpected indent

But the file parses fine by the Python interpreter, and it goes away if I either omit the multiline string literal, omit the Args: block of my docstring, or add a Returns: or Raises: block after the Args: block (adding other stuff there does not seem to fix the issue).
My environment details
Python 3.7.7 on Linux (though have also seen on other versions)
$ pip freeze
certifi==2020.6.20
pydocstyle==5.0.2
snowballstemmer==2.0.0

This is fixed on the master. We are preparing a new release soon

https://github.com/PyCQA/pydocstyle/pull/441

Can you retry with the master and see if you can replicate the error? Try pip install git+https://github.com/PyCQA/pydocstyle

Confirmed that it is fixed on master!


'ScrollableState' is missing implementations

Hi @hgraceb, I'm seeing the following error when trying out your library. Could you please help?
../../.pub-cache/hosted/pub.dev/nested_scroll_views-0.0.7/lib/src/flutter/widgets/scrollable.dart:367:7: Error: The non-abstract class 'ScrollableState' is missing implementations for these members:
 - ScrollContext.devicePixelRatio
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class ScrollableState extends State<Scrollable> with TickerProviderStateMixin, RestorationMixin
      ^^^^^^^^^^^^^^^
../../fvm/versions/3.12.0/packages/flutter/lib/src/widgets/scroll_context.dart:47:14: Context: 'ScrollContext.devicePixelRatio' is defined here.
  double get devicePixelRatio;
             ^^^^^^^^^^^^^^^^
../../.pub-cache/hosted/pub.dev/nested_scroll_views-0.0.7/lib/src/nested/widgets/scrollable.dart:57:7: Error: The non-abstract class '_OverscrollScrollableState' is missing implementations for these members:
 - ScrollContext.devicePixelRatio
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class _OverscrollScrollableState extends ScrollableState {
      ^^^^^^^^^^^^^^^^^^^^^^^^^^
../../fvm/versions/3.12.0/packages/flutter/lib/src/widgets/scroll_context.dart:47:14: Context: 'ScrollContext.devicePixelRatio' is defined here.
  double get devicePixelRatio;
             ^^^^^^^^^^^^^^^^
Restarted application in 2,113ms.

Turns out I was using the beta version of Flutter i.e. 3.12.0, downgrading to the latest stable version i.e. 3.10.5 made the error go away 👍🏻

The issue is now on stable channel as of version 3.13.0

I have created a pull request for the issue.

I have created a pull request for the issue.

Thank you very much. The issue has been fixed in version 0.0.8.


✨ refactor: clean up (#872)

Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for new/updated/fixed functionality.
[ ] I have updated/added dartdoc comments with ///.

Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

Related Issues

Codecov Report

Merging #872 (341d036) into main (4814958) will decrease coverage by 0.29%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   81.86%   81.57%   -0.29%
==========================================
  Files         247        3     -244
  Lines        3137       38    -3099
==========================================
- Hits         2568       31    -2537
+ Misses        569        7     -562

see 244 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Changed default method to post

Changes the default method to POST so that calling fetching a schema will actually work.
Without this change simply trying to fetch the schema with this config :
"schema": {
    "http": {
      "url": "https://rickandmortyapi.com/graphql"
    }
  }

Will fail because you can't write to the request stream of a GET request.

Codecov Report

Merging #332 (c01a8d9) into master (a302732) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   92.26%   92.26%
=======================================
  Files          66       66
  Lines        4601     4601
  Branches      520      521    +1
=======================================
  Hits         4245     4245
  Misses        356      356

Impacted Files
Coverage Δ

src/schema-manager/request-introspection-query.ts
64.28% <100.00%> (ø)

Codecov Report

Merging #332 (c01a8d9) into master (a302732) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   92.26%   92.26%
=======================================
  Files          66       66
  Lines        4601     4601
  Branches      520      521    +1
=======================================
  Hits         4245     4245
  Misses        356      356

Impacted Files
Coverage Δ

src/schema-manager/request-introspection-query.ts
64.28% <100.00%> (ø)

Thx!

Thx!


Mismatch between implementation of modulo operation in gringo AG specification

In gringo 3/-2 is -1 while in AG it is defined as 3/-2=-2. (Also affects the modulo operation.)

@tortinator, @mgebser I am very much inclined to not change the implementation. It is possible to work with either way of rounding and both have advantages/disadvantages. And most importantly not changing means not breaking any existing encodings.

If no one replies, I keep the old behavior and simply close this. :smiley:


can't get shortcut guide to open

Microsoft PowerToys version
v0.41.4
Running as admin

[X] Yes

Area(s) with issue?
Shortcut Guide
Steps to reproduce
PowerToysReport_2021-07-22-22-34-38.zip
✔ Expected Behavior
to see the shortcut guide open when pressing the combination of keys i chose to be a shortcut for opening it
❌ Actual Behavior
Can't get the shortcut guide to open regardless of what shortcut is used. Running powertoys as administrator and shortcut guide is on.
Other Software
No response

Hi, from what I see in the logs, you're trying to register the shortcut to other shortcuts that are already registered for other functions:
[2021-07-22 22:08:17.664415] [p-10384] [t-10716] [info] runner logger is initialized
[2021-07-22 22:08:20.954322] [p-25216] [t-20944] [info] runner logger is initialized
[2021-07-22 22:08:20.965381] [p-25216] [t-20944] [info] Runner is starting. Elevated=true
[2021-07-22 22:08:21.090416] [p-25216] [t-20944] [trace] UnRegister hotkey action for FancyZones
[2021-07-22 22:08:21.107606] [p-25216] [t-20944] [trace] UnRegister hotkey action for File Explorer
[2021-07-22 22:08:21.150930] [p-25216] [t-20944] [trace] UnRegister hotkey action for Image Resizer
[2021-07-22 22:08:21.180596] [p-25216] [t-20944] [trace] UnRegister hotkey action for Keyboard Manager
[2021-07-22 22:08:21.238732] [p-25216] [t-20944] [trace] UnRegister hotkey action for PowerToys Run
[2021-07-22 22:08:21.238766] [p-25216] [t-20944] [trace] Register hotkey action for PowerToys Run
[2021-07-22 22:08:21.259634] [p-25216] [t-20944] [trace] UnRegister hotkey action for PowerRename
[2021-07-22 22:08:21.310295] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:08:21.311840] [p-25216] [t-20944] [warning] Failed to add win+  shortcut. Hot key is already registered.
[2021-07-22 22:08:21.352454] [p-25216] [t-20944] [trace] UnRegister hotkey action for ColorPicker
[2021-07-22 22:08:21.352476] [p-25216] [t-20944] [trace] Register hotkey action for ColorPicker
[2021-07-22 22:08:21.371752] [p-25216] [t-20944] [trace] UnRegister hotkey action for Awake
[2021-07-22 22:08:21.754590] [p-25216] [t-27276] [trace] Version is up to date
[2021-07-22 22:08:52.624260] [p-26244] [t-21356] [info] runner logger is initialized
[2021-07-22 22:09:35.119746] [p-17272] [t-16672] [info] runner logger is initialized
[2021-07-22 22:11:56.102560] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:11:56.103041] [p-25216] [t-20944] [warning] Failed to unregister win+  shortcut. Hot key is not registered.
[2021-07-22 22:11:56.103125] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:16.585567] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:16.585691] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:16.585749] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:28.987559] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:28.987708] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:28.987769] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:46.786944] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:46.787132] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:46.787230] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:12:57.362246] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:57.362453] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:12:57.362567] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:13:14.896302] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:13:14.896505] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:13:14.896570] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:15:07.776216] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:07.776314] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:15:07.776367] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:20.719824] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:20.720182] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:20.720345] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:23.334540] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:23.335104] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:23.335358] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:43.100611] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:43.100833] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:43.100946] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut registered
[2021-07-22 22:16:14.000056] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:14.000120] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut unregistered
[2021-07-22 22:16:14.000146] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut registered
[2021-07-22 22:16:33.050836] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:33.050915] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut unregistered
[2021-07-22 22:16:33.051024] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:16:49.198840] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:49.199050] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:16:49.199171] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:20:06.651545] [p-27280] [t-13744] [info] runner logger is initialized
[2021-07-22 22:20:15.479777] [p-13996] [t-24928] [info] runner logger is initialized
[2021-07-22 22:21:38.445956] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:21:38.446491] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:21:38.446667] [p-25216] [t-20944] [warning] Failed to add win+ shortcut. Hot key is already registered.
[2021-07-22 22:23:00.257020] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:23:00.257275] [p-25216] [t-20944] [warning] Failed to unregister win+ shortcut. Hot key is not registered.
[2021-07-22 22:23:00.257357] [p-25216] [t-20944] [warning] Failed to add win+ shortcut. Hot key is already registered.
[2021-07-22 22:28:35.678836] [p-3760] [t-22508] [info] runner logger is initialized

Shortcut Guide won't override other shortcuts that are defined already.
How does it work on shortcuts that are not defined for anything else (the default Win+Shift+~, for example?

I tried Win + backspace and Win + Shift + ~ but shortcut guide didn’t open with either of them.
Thanks,
Kelly

On Jul 23, 2021, at 11:12, Jaime Bernardo @.***> wrote:

Hi, from what I see in the logs, you're trying to register the shortcut to other shortcuts that are already registered for other functions:
[2021-07-22 22:08:17.664415] [p-10384] [t-10716] [info] runner logger is initialized
[2021-07-22 22:08:20.954322] [p-25216] [t-20944] [info] runner logger is initialized
[2021-07-22 22:08:20.965381] [p-25216] [t-20944] [info] Runner is starting. Elevated=true
[2021-07-22 22:08:21.090416] [p-25216] [t-20944] [trace] UnRegister hotkey action for FancyZones
[2021-07-22 22:08:21.107606] [p-25216] [t-20944] [trace] UnRegister hotkey action for File Explorer
[2021-07-22 22:08:21.150930] [p-25216] [t-20944] [trace] UnRegister hotkey action for Image Resizer
[2021-07-22 22:08:21.180596] [p-25216] [t-20944] [trace] UnRegister hotkey action for Keyboard Manager
[2021-07-22 22:08:21.238732] [p-25216] [t-20944] [trace] UnRegister hotkey action for PowerToys Run
[2021-07-22 22:08:21.238766] [p-25216] [t-20944] [trace] Register hotkey action for PowerToys Run
[2021-07-22 22:08:21.259634] [p-25216] [t-20944] [trace] UnRegister hotkey action for PowerRename
[2021-07-22 22:08:21.310295] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:08:21.311840] [p-25216] [t-20944] [warning] Failed to add win+  shortcut. Hot key is already registered.
[2021-07-22 22:08:21.352454] [p-25216] [t-20944] [trace] UnRegister hotkey action for ColorPicker
[2021-07-22 22:08:21.352476] [p-25216] [t-20944] [trace] Register hotkey action for ColorPicker
[2021-07-22 22:08:21.371752] [p-25216] [t-20944] [trace] UnRegister hotkey action for Awake
[2021-07-22 22:08:21.754590] [p-25216] [t-27276] [trace] Version is up to date
[2021-07-22 22:08:52.624260] [p-26244] [t-21356] [info] runner logger is initialized
[2021-07-22 22:09:35.119746] [p-17272] [t-16672] [info] runner logger is initialized
[2021-07-22 22:11:56.102560] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:11:56.103041] [p-25216] [t-20944] [warning] Failed to unregister win+  shortcut. Hot key is not registered.
[2021-07-22 22:11:56.103125] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:16.585567] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:16.585691] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:16.585749] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:28.987559] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:28.987708] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:28.987769] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:12:46.786944] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:46.787132] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:12:46.787230] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:12:57.362246] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:12:57.362453] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:12:57.362567] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:13:14.896302] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:13:14.896505] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:13:14.896570] [p-25216] [t-20944] [warning] Failed to add win+K shortcut. Hot key is already registered.
[2021-07-22 22:15:07.776216] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:07.776314] [p-25216] [t-20944] [warning] Failed to unregister win+K shortcut. Hot key is not registered.
[2021-07-22 22:15:07.776367] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:20.719824] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:20.720182] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:20.720345] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:23.334540] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:23.335104] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:23.335358] [p-25216] [t-20944] [warning] Failed to add shift+win+S shortcut. Hot key is already registered.
[2021-07-22 22:15:43.100611] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:15:43.100833] [p-25216] [t-20944] [warning] Failed to unregister shift+win+S shortcut. Hot key is not registered.
[2021-07-22 22:15:43.100946] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut registered
[2021-07-22 22:16:14.000056] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:14.000120] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut unregistered
[2021-07-22 22:16:14.000146] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut registered
[2021-07-22 22:16:33.050836] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:33.050915] [p-25216] [t-20944] [trace] shift+ctrl+K shortcut unregistered
[2021-07-22 22:16:33.051024] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:16:49.198840] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:16:49.199050] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:16:49.199171] [p-25216] [t-20944] [warning] Failed to add win+S shortcut. Hot key is already registered.
[2021-07-22 22:20:06.651545] [p-27280] [t-13744] [info] runner logger is initialized
[2021-07-22 22:20:15.479777] [p-13996] [t-24928] [info] runner logger is initialized
[2021-07-22 22:21:38.445956] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:21:38.446491] [p-25216] [t-20944] [warning] Failed to unregister win+S shortcut. Hot key is not registered.
[2021-07-22 22:21:38.446667] [p-25216] [t-20944] [warning] Failed to add win+� shortcut. Hot key is already registered.
[2021-07-22 22:23:00.257020] [p-25216] [t-20944] [trace] UnRegister hotkey action for Shortcut Guide
[2021-07-22 22:23:00.257275] [p-25216] [t-20944] [warning] Failed to unregister win+� shortcut. Hot key is not registered.
[2021-07-22 22:23:00.257357] [p-25216] [t-20944] [warning] Failed to add win+� shortcut. Hot key is already registered.
[2021-07-22 22:28:35.678836] [p-3760] [t-22508] [info] runner logger is initialized
Shortcut Guide won't override other shortcuts that are defined already.
How does it work on shortcuts that are not defined for anything else (the default Win+Shift+~, for example?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Can't seem to repro. It works for me on shortcuts that are not attributed to anything else.
Could you perhaps send another bug report to see if it's the same error message?
So, it's not working for any shortcut you set, is that right?


fade between pages

:O

https://github.com/framer/motion/issues/626
https://github.com/framer/motion/issues/1375


the build fail because of generated frontend code

When I try to build a production ready jar file using
 mvn package -Pproduction
or
mvn clean package -Pproduction
or even in the dev mode an error keep showing in the dev tools saying that the generated methods for http status code starts with a number like 4xxClientError() and 3xxClientError()... is there any way I can solve this or just ignore the error during build because I've ignored it in dev mode and was working with no problems.
frontend/generated/org/springframework/http/HttpStatusCode.ts(2,6): error TS1351: An identifier or keyword cannot immediately follow a numeric literal.
Screenshot
errors in console

generated code by hilla

Versions:
- Vaadin / Hilla version:
- Node version: v18.16
- Java version: java 11
- OS version: fedora workstation 38
- Browser version (if applicable):
- Application Server (if applicable):
- IDE/Editor (if applicable): Intelij

A TypeScript function name cannot start with a number. According to the ECMAScript specification, function names must start with a letter, an underscore (_), or a dollar sign ($).
Looks like we should have some check for that.
As a workaround, maybe you can prefix your method names, like getHttp5xxServerError

I can't prefix them. the names are generated by hilla plugin. may be I just don't know how. any way I will be grateful if you could guide me sir.

They are generated based on the methods in your Java class, you need to change them there.

I don't have methods for http status code. maybe because I return Response entity each time? if so is there any way I can fix that without changing the return type in all the methods?

You can think of Hilla endpoint methods as RPC. You should not return Response entities from them, only the actual return value.
Instead of checking HTTP statuses for errors when calling, you can look at the exception type https://hilla.dev/docs/lit/guides/endpoints/#error-handling

Thank you sir for your help. I'll consider refactoring my backend code.


New Razor Page doesn't have Intellisense

After creating a new Razor Page using the Razor Page item template in VS 2017 15.3.0 and Microsoft.AspNetCore.All v2.0.0, the .cshtml file is opened but Intellisense does not work until you close the file and re-open it.

Hey @jchadwick sorry to hear that! Although the item template vs. scaffolding are slightly different beasts I believe this is related to https://github.com/aspnet/Scaffolding/issues/514.
@Eilon where do we file item template issues?

@NTaylorMullen you mean issues w/ the contents of item templates?

@NTaylorMullen you mean issues w/ the contents of item templates?

Sorry, no. Issues with how they result in the editor being opened.

The contents are fine.  If you close the view and re-open it again everything works fine.

@NTaylorMullen - talk to @barrytang to find out where to file.

@phenning, I believe this is fixed in 15.3. Can you confirm?
/cc @mlorbetske @balachir

Are you talking about VS?  I'm using 15.3.0.

i have the same issue, there is no Intellisense with the new Razor pages

@barrytang
I was not able to repro this on latest builds when starting with a new Razor web application and creating new pages in the Pages folder.
I was able to repro this though if I started with an MVC template and create new razor pages without first adding a @namespace directive to either the cshtml file itself or via a _ViewImports.cshtml file.
The workaround of closing and reopening does not appear to work for me unless the namespace is present though.
If I update/add the expected namespace to the _ViewImports.cshtml before creating the item template, the issue does not reproduce either.

@phenning  I have that issue with @namespace as well, but that's a different issue in addition to this. :)

I talked to Phil and Mike offline and this is fixed in 15.4 not 15.3. I ported the issue to https://developercommunity.visualstudio.com/content/problem/108727/new-razor-page-doesnt-have-intellisense.html. If you follow it, you will get notified when 15.4 is available publicly.

Ok sounds like this issue can be closed then.


Equivalent to react?

Is there a library like this for react?

Thanks for bringing this up. I don't use React myself. Feel free to port if you'd like.


Add multi instance test suite and namespace scoped deployments

closes #121
Update local-setup for namespaced deployments
Allow local-setup to create x number of namespaced deployments of the dns operator in a single cluster.
Adds new options to control the behaviour of the deployment:
DEPLOYMENT_SCOPE=cluster|namespace (default is cluster)
DEPLOYMENT_COUNT=2 - Number of instances to deploy (namespace deployment
scope only)
make local-setup DEPLOY=true DEPLOYMENT_SCOPE=namespace DEPLOYMENT_COUNT=2
...
kubectl get deployments -l app.kubernetes.io/part-of=dns-operator -A
dns-operator-1   dns-operator-controller-manager-1   1/1     1            1           14s
dns-operator-2   dns-operator-controller-manager-2   1/1     1            1           14s

When using the namespace deployment scope, kustomization overlays are generated and used to deploy the desired resources. These could eventually be used against any cluster and not limited to local kind clusters, and can be found in the default overlays dir:
tree tmp/overlays/kuadrant-dns-local/
tmp/overlays/kuadrant-dns-local/
├── kustomization.yaml
├── namespace-dns-operator-1
│   ├── dns-operator
│   │   └── kustomization.yaml
│   ├── kustomization.yaml
│   └── managedzones
│       └── kustomization.yaml
└── namespace-dns-operator-2
    ├── dns-operator
    │   └── kustomization.yaml
    ├── kustomization.yaml
    └── managedzones
        └── kustomization.yaml

7 directories, 7 files

tests: Add multi instance e2e test suite
Adds a multi instance test suite intended to test scenarios where multiple instances of the dns operator are running each reconciling DNSRecord resources contributing to the same shared dns zone.
The suite allows runtime configuration to alter the number of instances that are under test allowing stress testing scenarios to be executed using more extreme numbers of instances and records.
In a local development kind setup, the following local-setup and test commands can be used:
Create kind cluster with four dns operator deployments each watching their own namespace, and each containing the default managedzones (dev-mz-aws and dev-mz-gcp)
make local-setup DEPLOY=true DEPLOYMENT_SCOPE=namespace DEPLOYMENT_COUNT=4

Run the multi instance test suite using the aws zone:
make test-e2e-multi TEST_DNS_MANAGED_ZONE_NAME=dev-mz-aws TEST_DNS_NAMESPACES=dns-operator DEPLOYMENT_COUNT=4

Notes:

Currently an issue if you use a large amount of instances, the endpoint don't always get deleted correctly. This is because of the ownership/registry and the way it currently works. We will need to look into changing this in follow on tasks.
Additional assertions required in the loadbalanced test scenario to ensure the records are created correctly in the provider.
New test suite is doing a similar test to the current multi record test in the normal e2e test suite. When we get to a point where the multi test suite is dong the same assertions and invoked by the GH actions we can probably remove this.
Follow on task required to improve the overlay generation tasks to allow them to be used more easily outside of local setup.

@ficap you may also be interested in this from a QE persepective


Add Responsiveness to Cart Page

Add Responsiveness to Cart Page

Deploy preview is not working, can't see UI changes.

Deploy preview is not working, can't see UI changes.

It's working
https://deploy-preview-13--gardenkart.netlify.app/pages/cartpage/cartpage


Branch selector combo in custom dialog

Is there the way to reuse branch selector combo in custom dialog?
Like "Based on" field in "Create a branch" dialog:

I found a point:
module "TFS/VersionControl/Controls";
export module GitVersionSelector


Remove ability to upload folders into the file upload area

As part of hierarchical file support, we are moving to a model where users upload a single ZIP, which is then expanded on the server to provide access to the internal structure.  So we do not want to allow users to upload folders in H2.

Why not? The current functionality allows a user to quickly add a set of files. How does this conflict with the proposed new functionality?

We discussed and have the following reasons:

unless we can show the hierarchical structure in the drag/drop file upload area this same as is shown in #2843, we will end up having two separate views of incoming hierarchy, which may be confusing
related: files uploaded in the drag/drop area allow for descriptions/individual deletions, which is different than what will happen in #2843 for the zip upload
we could end up with potential filename clashes if two folders are uploaded separately
potential browser incompatibilities?

Basically, for the various reasons we decided to move to a single ZIP upload...

Currently, a user can drag-and-drop a folder and the files will be extracted. We don't have the ability to stop a user from dragging-and-dropping. How do want it to behave?

I thought we added something to allow dropping folders, didn't realize it just worked by default.  Perhaps there is nothing we can/should do then.  We will now prevent dupe filenames via #2800, so it may just work fine if they happen to drop a folder?  @amyehodge can help decide

AFAICT, @justinlittman is correct that users are free to drag-and-drop folders and have always been able to. When they do so, no path information is recorded; just the filenames.
We could look into beginning to prevent this, but I'm not sure that's what's been asked for. What do you think, @amyehodge ?

I'm gonna defer on answering this until after some discussions today about the workflows for everything. I'm hoping we can simplify some things.

@amyehodge Any new thoughts on this or should we pause a while and revisit later?

@mjgiarlo I'd like to wait until we discuss the new mockups with the team, but I'm thinking we will likely not do this.

Sounds good. :)

After talking to Justin L this morning, this ticket may be a no-op.  The current behavior allows users to drag a folder into that area and it will simply flatten the list of files present if you do this.  This would match the expected behavior for that upload  mechanism.

That sounds right to me.

@peetucket @amyehodge Not to pester too much... shall we close this issue?

I believe we can close this.


FlowAggregator e2e tests sometimes timed out.

Describe the bug
When we run /test-ipv6-e2e to trigger our CI job jenkins-ipv6-ds-e2e, the TestFlowAggregator sometimes times out. It's kind freaky.
For example, http://<IP_ADDRESS>:8080/job/antrea-ipv6-ds-e2e-for-pull-request/279, this is triggered by PR #2034, which only fixes some small bugs in the TraceFlow test. But all tests under TestFlowAggregator/ fails.
The related log is below:
=== RUN   TestFlowAggregator/IPv4
=== RUN   TestFlowAggregator/IPv4/IntraNodeFlows
    flowaggregator_test.go:390: Network Policies are realized.
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:152
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv4/IntraNodeFlows
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv4/InterNodeFlows
    flowaggregator_test.go:388: Error when waiting for Network Policy to be realized: unable to upgrade connection: container not found ("antrea-agent")
    flowaggregator_test.go:390: Network Policies are realized.
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:175
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv4/InterNodeFlows
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv4/LocalServiceAccess
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:186
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv4/LocalServiceAccess
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv4/RemoteServiceAccess
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:196
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv4/RemoteServiceAccess
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv6
=== RUN   TestFlowAggregator/IPv6/IntraNodeFlows
    flowaggregator_test.go:390: Network Policies are realized.
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:154
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv6/IntraNodeFlows
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv6/InterNodeFlows
    flowaggregator_test.go:390: Network Policies are realized.
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:177
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv6/InterNodeFlows
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv6/LocalServiceAccess
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:188
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv6/LocalServiceAccess
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== RUN   TestFlowAggregator/IPv6/RemoteServiceAccess
    flowaggregator_test.go:226:
        	Error Trace:	flowaggregator_test.go:226
        	            				flowaggregator_test.go:198
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFlowAggregator/IPv6/RemoteServiceAccess
        	Messages:   	IPFIX collector did not receive the expected records and timed out with error: timed out waiting for the condition
=== CONT  TestFlowAggregator
    fixtures.go:319: Deleting 'flow-aggregator' K8s Namespace
    fixtures.go:208: Exporting test logs to '/var/lib/jenkins/workspace/antrea-ipv6-ds-e2e-for-pull-request/antrea-test-logs/TestFlowAggregator/beforeTeardown.Apr06-23-30-51'
    fixtures.go:309: Error when exporting kubelet logs: error when running journalctl on Node 'antrea-ipv6-7-0', is it available?
    fixtures.go:330: Deleting 'antrea-test' K8s Namespace
--- FAIL: TestFlowAggregator (409.90s)
    --- FAIL: TestFlowAggregator/IPv4 (105.62s)
        --- FAIL: TestFlowAggregator/IPv4/IntraNodeFlows (21.91s)
        --- FAIL: TestFlowAggregator/IPv4/InterNodeFlows (37.18s)
        --- FAIL: TestFlowAggregator/IPv4/LocalServiceAccess (21.29s)
        --- FAIL: TestFlowAggregator/IPv4/RemoteServiceAccess (22.15s)
    --- FAIL: TestFlowAggregator/IPv6 (153.10s)
        --- FAIL: TestFlowAggregator/IPv6/IntraNodeFlows (21.98s)
        --- FAIL: TestFlowAggregator/IPv6/InterNodeFlows (21.88s)
        --- FAIL: TestFlowAggregator/IPv6/LocalServiceAccess (84.81s)
        --- FAIL: TestFlowAggregator/IPv6/RemoteServiceAccess (21.33s)

@srikartati could you help take a look?

Sure Zhecheng.
There are two aspects here. One is the failure itself and the timeout values when the failure happens.

These failures were observed on the dual-stack cluster in PR #1904 as well. Yiou fixed this in her PR. She observed that the test is passing consistently after the fix. Could you confirm this @zyiou?
Timeout values: collectorCheckTimeout value of 10s is high. This can be reduced to flowAggregator export interval value. This will reduce the typical 20s to 15s. However, the following values are very surprising:

    --- FAIL: TestFlowAggregator/IPv4/InterNodeFlows (37.18s)
    --- FAIL: TestFlowAggregator/IPv6/LocalServiceAccess (84.81s)

I could not reproduce this locally but I am suspecting wait.Poll condition takes a long time. There could be issues when grabbing the kubectl log output fromipfix-collector'. Maybe the pod is in a messed up state, so added an option --pod-running-timeout=xx`.
Fixing the timeout values by opening a PR now.

These failures were observed on the dual-stack cluster in PR #1904 as well. Yiou fixed this in her PR. She observed that the test is passing consistently after the fix. Could you confirm this @zyiou?

The failure I had was kinda different: wait.Poll condition got passed but incorrect number of records were received (expecting 2 or more but only 1 was received). So I changed the wait condition to pass when 2 or more valid records are found.
I found this error message might be the reason:
flowaggregator_test.go:388: Error when waiting for Network Policy to be realized: unable to upgrade connection: container not found ("antrea-agent")

Since all tests are failing, probably flow exporter does not start correctly.

Thanks, Yiou. This seems like an intermittent issue--I did not hit this when running tests as part of PR #2039. Tried running this multiple times with count argument locally as well.
I see that previous test cases have passed but as you pointed out in the following error that the Antrea agent is missing, but the same error was not there when configuring network policies in the other three test cases, where they are required.

flowaggregator_test.go:388: Error when waiting for Network Policy to be realized: unable to upgrade connection: container not found ("antrea-agent")

Focusing on timeout values, the above error may or may not incur some extra delay but the TestFlowAggregator/IPv6/LocalServiceAccess (84.81s) do not have any network policy configuration. Not sure where the extra time is coming here from.
With PR #2039 , we try to cut down any possible delay when waiting for flow records from the ipfix-collector pod logs.

For reproducing this issue on dual-stack cluster as per discussion here: https://github.com/vmware-tanzu/antrea/pull/2039#issuecomment-815454616
@lzhecheng Is it possible to get a jenkins setup for dual-stack clusters?
@dreamtalen Do you know of ways to get a local setup with dual-stack cluster? I believe the vagrant setup has only single IPv6 cluster setup.

I see some intermittent e2e test errors in other testsuites as well. I was able to get the logs on one of the runs and found the backtrace where flow aggregator crashes.
https://jenkins.antrea-ci.rocks/job/antrea-e2e-for-pull-request/2382/consoleFull
E0414 17:21:26.168044       6 aggregate.go:144] Callback execution failed for flow with key: {<IP_ADDRESS> <IP_ADDRESS> 6 60160 10350}, records: {0xc0001461f8 true true}, error: error when sending data set: error when sending message on the connection: write tcp <IP_ADDRESS>:54482-><IP_ADDRESS>:4739: write: connection reset by peer
E0414 17:21:26.168674       6 flowaggregator.go:352] Error when sending flow records: error when sending data set: error when sending message on the connection: write tcp <IP_ADDRESS>:54482-><IP_ADDRESS>:4739: write: connection reset by peer
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x119a432]

goroutine 15 [running]:
github.com/vmware/go-ipfix/pkg/entities.(*dataRecord).GetMinDataRecordLen(0xc000010468, 0xc0000f3e00)
	<autogenerated>:1 +0x32
github.com/vmware/go-ipfix/pkg/exporter.(*ExportingProcess).SendSet(0xc0002a8040, 0x1673460, 0xc0002e76e0, 0x13a0100, 0x0, 0x0)
	/go/pkg/mod/github.com/vmware/go-ipfix@v0.4.7/pkg/exporter/process.go:168 +0x2a2
github.com/vmware-tanzu/antrea/pkg/ipfix.(*ipfixExportingProcess).SendSet(0xc000146160, 0x1667c60, 0xc0002ee4c0, 0x40, 0xc000440100, 0x0)
	/antrea/pkg/ipfix/ipfix_process.go:48 +0x48
github.com/vmware-tanzu/antrea/pkg/flowaggregator.(*flowAggregator).sendTemplateSet(0xc0001eb2c0, 0x1667c60, 0xc0002ee4c0, 0x0, 0x9a41db2e, 0x0, 0x0)
	/antrea/pkg/flowaggregator/flowaggregator.go:453 +0xa47
github.com/vmware-tanzu/antrea/pkg/flowaggregator.(*flowAggregator).initExportingProcess(0xc0001eb2c0, 0xc00006aef0, 0x2)
	/antrea/pkg/flowaggregator/flowaggregator.go:299 +0x355
github.com/vmware-tanzu/antrea/pkg/flowaggregator.(*flowAggregator).Run(0xc0001eb2c0, 0xc0001626c0)
	/antrea/pkg/flowaggregator/flowaggregator.go:343 +0x354
created by github.com/vmware-tanzu/antrea/cmd/flow-aggregator.run
	/antrea/cmd/flow-aggregator/flow-aggregator.go:107 +0x3de

After closely examining the backtrac, I found that records in fa.set are not reset properly. We use the same set for both template and data records. Following is the code of set.Reset() in go-ipfix.
func (s *set) ResetSet() {
	s.buffer.Reset()
	s.setType = Undefined
	s.records = s.records[:0]
}

I read in the go documentation and also on stackoverflow s.records = s.records[:0] may not be picked by GC and the safest way to do this is by using s.records = nil. I will fix this in go-ipfix through a patch release and will upgrade the package version in Antrea.


Added encoding.md

Making this a draft until the content has been rewritten. Add that point please mark it “Ready for review”.

Closing as the substantive portions of this are contained within https://github.com/cloudflare/workers-docs-engine/pull/62.


Can't make images while anything is in the lora folder

Everything starts up fine, and I'm able to view and select loras in the webui, but when I try to generate images, it stops.
Error completing request Arguments: ('task(20axz6z16rmkjiu)', '', '', ['test'], 37, 0, False, False, 3, 2, 17.5, -1.0, -1.0, 0, 0, 0, False, 512, 512, False, 0.7, 2, 'Latent', 0, 0, 0, [], 0, False, False, 'positive', 'comma', 0, False, False, '', 1, '', 0, '', 0, '', True, False, False, False, 0) {} Traceback (most recent call last):   File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/call_queue.py", line 56, in f     res = list(func(*args, **kwargs))   File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/call_queue.py", line 37, in f     res = func(*args, **kwargs)   File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/txt2img.py", line 56, in txt2img     processed = process_images(p)   File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/processing.py", line 486, in process_images     res = process_images_inner(p)   File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/processing.py", line 584, in process_images_inner     extra_networks.activate(p, extra_network_data) UnboundLocalError: local variable 'extra_network_data' referenced before assignment

I am not getting any errors, apart from the loras not working. They are there, when I refresh the lora tab they show up, but they don't work.


Offline Promise doesn't seem to work

Offline Promises doesn't seem to work:
Example code
Service
  updateCustomer(customerKey: string, customer: Customer | any) {
    return this._auth.authState
      .switchMap(({ uid }) => {
        const { street, zip, city, region, country } = customer.address
        if (navigator.onLine) {
          return this._geocoderService
            .geocode(street, zip, city, region, country)
            .switchMap(latlng => {
              customer.latlng = latlng
              return this._db
                .object(`customers/${uid}/${customerKey}`)
                .set(customer)
            })
        } else {
          return this._db.object(`customers/${uid}/${customerKey}`).set(customer)
        }
      })
      .first()
      .toPromise()

Component
  updateCustomer(customerKey: string, customer: Customer) {
    return this._dataService
      .updateCustomer(customerKey, customer)
      .then(() => this._router.navigate(['../read'], { relativeTo: this._route }))
  }

When online, promise complete and navigation is tiggered.
When offline, promise never complete, but data is updated locally and then sync with firebase on reconnect, however since the promise never completes, navigation isn't triggered.
AF2O: 4.3.0
AF2 v4.0.0-rc1
Angular 4.3.3
Angular-cli 1.3.0

It is the expected behavior ? (Seems not since 4.3.0 changelog says that offline promises are supported)
If yes, do you have a recommended work-around ?
Thanks for your amazing work on this package !

hm, hm, my excuses, didn't see the updated readme... (leave in silence...)


add svelte-chota to UI Kits

Wonderful project, thanks for submitting!
One change request - currently every link points to the source repo, not the docs like in the PR. We're in the process of converting this readme into a website, and using the docs link means the automated script will have to handle that special case, or we'll have to manually fix it. However once the website is ready, the docs/demo link will be given similar priority to the source repo link, so this is just a temporary quirk. Thank you!

No problem, corrected it

Cool thank you!


component list placeholders

fixes #270
placeholders will be added to component lists if they're empty
organized the placeholder logic a little better
placeholders will be destroyed when adding components to lists
also fixed a font issue in simple-list

Changes Unknown when pulling 45108e702a93ed6dbaa697bbe2a4a0cfbdc87d47 on component-list-placeholder into ** on master**.

Changes Unknown when pulling 6834f4469f701d36c828af427dcbfd665c14094f on component-list-placeholder into ** on master**.

+1


Calling Collector from non-ESRI apps

Hello,
We often integrate both ESRI and non-ESRI apps into our workflows, and one of the apps we use a lot is iFormBuilder. (For some use-cases we prefer Survey123, and in other cases we'll go with iFormBuilder.)
Not sure if it's the same behavior on all platforms, but on iOS the iForm app throws an error when trying to launch any arcgis-collector:// URL scheme... is this ESRI blocking iFormBuilder from opening Collector (i.e., is there a whitelist of apps that can actually call Collector via the URL scheme), or is it an issue with iFormBuilder?
If ESRI does restrict certain apps from calling Collector, how would we go about requesting apps be added to the whitelist? If there is no such restriction, it would be helpful for me to know and I'll take up the issue again with iFormBuilder. Many thanks!

We don't explicitly restrict apps from calling us, so as you suggest the problem is likely on the iFormBuilder side. Let us know if you reach a resolution on this.

Great - thank you for confirming, Doug! I'll re-open my ticket with iFormBuilder and will post an update on what I hear back before closing this issue.

OK - iFormBuilder confirmed they need to allow the arcgis-collector:// URL scheme (which they are currently not doing). I have a call with them this week to discuss having them allow this workflow. I'll go ahead and close this issue - thanks again for the quick response, Doug!


KN doesn't work on Llama model

When I try to run your code on Llama-7B model using knowledge-neurons(KN)  method, the program throw error "AttributeError: 'Parameter' object has no attribute 'weight'" on ./easyeditor/models/kn/knowledge_neurons/knowledge_neurons/knowledge_neurons.py line 810. Does your framework support the llama model?

If you encounter any further issues, please feel free to contact us.

Well,I think there are some problems with KN
code in modify_weights function in knowledge_neurons.py
def unpatch_fn():
            # reverse modified weights
            for idx, (layer_idx, position) in enumerate(neurons):
                output_ff_weights = self._get_output_ff_layer(layer_idx)
                if self.model_type == "gpt2":
                    output_ff_weights[position, :] = original_weight_values[idx]
                else:
                    output_ff_weights[:, position] = original_weight_values[idx]

        if undo_modification:
            print("undo modification")
            unpatch_fn()
            unpatch_fn = lambda *args: args

        return results_dict, unpatch_fn

And in editor.py, the code looks weird, weights_copy() is a function, where is the items() attribute?
  with torch.no_grad():
                #print(help(weights_copy))
                # import pdb; pdb.set_trace()
                for k, v in weights_copy.items():
                    nethook.get_parameter(self.model, k)[...] = v.to(f"cuda:{self.hparams.device}")

the error is here:
for k, v in weights_copy.items(): AttributeError: 'function' object has no attribute 'items'

I have fixed this bug ,you can pull the newest code.If you encounter any further issues, please feel free to contact us

Have you solved your issue?

Have you solved your issue?
Sure, it works. thx


Sudden hiccups during benchmarking

While doing benchmarking, we've observed sudden and sorta random dips in performance.
[0712/103533.128980:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 8, Returned in time: 8.
[0712/103533.583837:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 16, Returned in time: 16.
[0712/103534.120373:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 32, Returned in time: 30.
[0712/103548.869642:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 64, Returned in time: 64.
[0712/103549.496886:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 128, Returned in time: 121.
[0712/103557.274973:ERROR:cert_verify_proc_builtin.cc(559)] No net_fetcher for performing AIA chasing.
Cronet(Throughput): Total Spawned: 256, Returned in time: 256.

See dips in 32 and 128 marks. Errors are due to #10 . This issue may affect reports in #3 .

It's rather common that the benchmarks results are a statistical distribution in nature.
We might want to add a repeat command line argument and report the min/max/median when repeat is more than 1.


Make DeviceAttestationRevocationDelegate a subclass of DeviceAttestationVerifier

This would not be needed if DeviceAttestationRevocationDelegate was a subclass of DeviceAttestationVerifier

Originally posted by @tcarmelveilleux in https://github.com/project-chip/connectedhomeip/pull/33651#discussion_r1682797811

Had a discussion with @tcarmelveilleux, since DeviceAttestationRevocationDelegate is an interface, implementor can implement both, DeviceAttestationVerifier and DeviceAttestationRevocationDelegate.
So, this is not required, Closing!


buildRustCrate: Replace hyphen with underscore in env variables

This fixes a bug that prevents encoding_c from building.

Motivation for this change
I tried to use crate2nix to build a Rust package that depends on mozjs. This depends on encoding_c, which passes this output from build.rs:
cargo:include-dir=$PWD/includes

Which gets rewritten to this env file:
export DEPS_encoding_c_INCLUDE-DIR=$PWD/includes

This is invalid; nix doesn't allow environment variables to contain hyphens. In any case, it also doesn't match up with how mozjs is trying to reference it here. The mozjs build script expects it to be spelled DEPS_ENCODING_C_INCLUDE_DIR, with all of it in SCREAMING_CASE.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg build buildRustCrateTests

I couldn't find any good docs on this, so just as a note, here's how I actually ran that test suite. Is there a better way?
$ nix repl
Welcome to Nix version 2.3.4. Type :? for help.

nix-repl> pkgs = import ./default.nix {}

nix-repl> :b pkgs.buildRustCrateTests.test
builder for '/nix/store/dclsb1rmh2n8miqbagvxcr48csqfqqwd-rust_bar-0.1.0.drv' failed with exit code 1; last 10 log lines:
  1 | fn main() { println!("cargo:include-dir:{}/src", std::env::current_dir()); }
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^ `std::result::Result<std::path::PathBuf, std::io::Error>` cannot be formatted with the default formatter
    |
    = help: the trait `std::fmt::Display` is not implemented for `std::result::Result<std::path::PathBuf, std::io::Error>`
    = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
    = note: required by `std::fmt::Display::fmt`

  error: aborting due to previous error

  For more information about this error, try `rustc --explain E0277`.
cannot build derivation '/nix/store/vvjiwlwmz37l5i4f1m6syja6q9cxyi1c-rust_foo-0.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jwjjpii1dkinksiyj37g536cdixp92dq-run-buildRustCrate-foo-test.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/01vghx569vgqs0v2y3pyg4in3cbp7gh7-buildRustCrate-tests.drv': 1 dependencies couldn't be built
[1 built (1 failed)]
error: build of '/nix/store/01vghx569vgqs0v2y3pyg4in3cbp7gh7-buildRustCrate-tests.drv' failed

nix-repl>

@ofborg build buildRustCrateTests

Looks like all the tests are passing, and there is now a regression test… let's merge :)

@andir Do you think this should be backported? I'm a bit cautious about it, seeing as it's infrastructure, but on the other hand as it's a quite significant bug…?

Yeah, back porting sounds good.
On Tue, May 26, 2020, 8:53 PM Léo Gaspard<EMAIL_ADDRESS>wrote:

@andir https://github.com/andir Do you think this should be backported?
I'm a bit cautious about it, seeing as it's infrastructure, but on the
other hand as it's a quite significant bug…?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/88054#issuecomment-634211798, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE365C6SGYLAPO7LPF56WTRTQF3XANCNFSM4ND4TNGQ
.

Done :)


Fix content encoding

Codecov Report

Merging #105 (0ccc390) into master (ad0539b) will decrease coverage by 16.16%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #105       +/-   ##
===========================================
- Coverage   84.44%   68.29%   -16.16%
===========================================
  Files          66       66
  Lines        6738     6743        +5
  Branches      714      714
===========================================
- Hits         5690     4605     -1085
- Misses        794     1919     +1125
+ Partials      254      219       -35

Impacted Files
Coverage Δ

...asticmagic/transport/ElasticsearchKtorTransport.kt
85.24% <100.00%> (-4.23%)
:arrow_down:

...o/elasticmagic/transport/ElasticsearchTransport.kt
83.64% <100.00%> (+2.89%)
:arrow_up:

... and 37 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Simply tests in test_cohort_filter.py

Description
Unifying the true_y and predicted_y tests.
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #1772 (400bf62) into postga (d0d338e) will decrease coverage by 8.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           postga    #1772      +/-   ##
==========================================
- Coverage   84.07%   75.29%   -8.79%
==========================================
  Files          48        9      -39
  Lines        2776      255    -2521
==========================================
- Hits         2334      192    -2142
+ Misses        442       63     -379

Flag
Coverage Δ

unittests
75.29% <ø> (-8.79%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

raiutils/raiutils/dataset/dataset.py

raiwidgets/raiwidgets/fairness_dashboard.py

...iwidgets/raiwidgets/model_performance_dashboard.py

raiwidgets/raiwidgets/explanation_dashboard.py

raiutils/raiutils/models/__init__.py

raiwidgets/raiwidgets/responsibleai_dashboard.py

erroranalysis/erroranalysis/_internal/utils.py

raiutils/raiutils/common/__init__.py

...is/erroranalysis/_internal/surrogate_error_tree.py

raiwidgets/raiwidgets/cohort.py

... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Rosterizer support

Would be great to get support for Rosterizer,

Does rosterizer use the same XML-based format as Battlescribe?

It uses JSON

Please attach a sample JSON file, I can see if it's easy to add support. What game system are you interested in

Warhammer_40k_Genestealer_Cults_Genestealer_2k.zip
Thanks for looking into it. I've zipped up a json file and attached it. It'd be Warhammer 40k I'd be interested in support for :)

Thanks, this looks reasonable. Please also provide a corresponding battlescribe roster that exactly matches the rosterizer file -- this will help make sure the two inputs output the same thing.

Thanks, super helpful. It'll take me several days to commit something working, once that's in I'll let you know and we can iterate on bug fixes

Amazing, thanks!


Best way to run Winappdriver test cases?

Hi I have created the task in task scheduler to launch the batch file which is written to run the test cases.
When the Test Cases runs it gives exception "unknown error occurred in the remote end while processing the command"
When we manually run the task (Right Click -> Run) it is not giving that exception.

I get this error when the system is locked, please check while running UI tests the system should not get locked.

You mean to say WinAppDriver has dependency on system lock? Means should always in ON state?

Yes the system should always be in unlock mode.

Is there any way to bypass that one?

That's the ground rule for any UI automation even web applications using selenium needs the PC to be unlocked unless you are running in a headless mode.


Ping shows 0ms (linux, wine)

I appear to be having this previous issue
PingPlugin: <IP_ADDRESS>
Wine: lutris-fshack-6.21-5
The IP shows correctly but the ping shows 0ms.
Pinging the IP from my terminal shows expected response, ~100ms

$ ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=51 time=122 ms

In my case it was working a few months ago (sorry not sure exact dates) but after a game update, if I remember correctly, it started reporting 0ms.
At that time I left it but would like to get it working if possible.
I see it was previously resolved by updating sigScanner.ScanText https://github.com/karashiiro/PingPlugin/commit/4b59642af013c10ce5abcaf59175a81b20256a96, but I don't know enough about how this works to figure out if that is the problem now or what it should be if so.
Happy to provide any more information if it helps.
Thanks for the plugin!

That ping tracker was removed for a variety of reasons, including that it was a huge time sink to fix when it broke on patches. I'll look into fixing this some other way.

Possibly fixed in v2.3.0

on <IP_ADDRESS> and Im getting 0ms

Manual configuration was added in v2.4.1; try setting the tracker to use game packets manually if it's still not working.

There seems to be an issue where if "Server bar" is chosen as the display mode, it will show 0ms ping. In the other display modes (and the graph) it shows the non-zero ping value.

It's now behaving slightly differently for me. Instead of showing 0ms, it's now continuously increasing forever!

If you aren't already, could you try setting the detection mode to use game packets instead of auto-detection? I'm using game packets + server bar display on Mac/Wine and it's working fine.

@karashiiro With detection mode on game packets, it shows correctly in all views except the server bar.


add windows

Can I create multiple Windows

@guoyanyunyan666 You could use a package like https://pub.dev/packages/desktop_multi_window

But will https://pub.dev/packages/desktop_multi_window work with bitsdojo?


feat: improved the auto disposal code [ci]

Coverage decreased (-0.002%) to 97.368% when pulling ccbb08cba9f761ce68556795cd7ec6a8a8a903a2 on better_disposal into 989af542c6e63a6074e03efc60656bc20fb0e211 on main.


Add checkbox in config allowing JavaScript usage in badges/summaries

I know that allowing JS can cause script injections, but is there a possibility to leave this choice to Jenkins users?
I've been using some JS in previous version of Badge Plugin and with new version it's impossible to add any script tag (or maybe I'm unaware of a way to do so).

I go a security issue from jenkins and had to disable JS. See https://jenkins.io/security/advisory/2018-06-25/#SECURITY-906
Can not do much about it. Sorry

Now I understand...
Do you know any other way to add custom JavaScript scripts to Jenkins' builds?

Unfortunately not, sorry


Running pipeline on local workstation & with profile docker

Hi,
This morning I was trying to run the pipeline on my local workstation, 16GB ram and Docker. From my understanding, and according to the docs, I have to provide the --profile docker parameter on the command line. In doing so, I get this error:
WARN: Access to undefined parameter genomes -- Initialise it to a default value eg. params.genomes = some_value
ERROR ~ Cannot get property 'GRCh37' on null object
-- Check script 'main.nf' at line: 113 or see '.nextflow.log' file for more details
after checking the config files I saw that when using the docker profile, all the genome references in the igenomes.config are not loaded, so the error above.
Of course, I run nextflow with the --genome GRCh37 as command line parameter.
Hope you can help
thx

Hi,
I think it's related to #33
You might need to specify -profile standard,docker

You are right, now it's running.
Thx a bunch

I was glad to be of help ;-)


nuke proposal prefixes

As discussed, this PR removes the numeric prefixes from the proposals directory, including the template. Existing unmerged PRs will need to be updated.

Suggestion to use ISO date format YYYYMMDD as the proposal short name prefix.


kernelBetainc incorrect documentation and drops argument

Checklist

Please ensure the following tasks are completed before filing a bug report.

[x] Read and understood the Code of Conduct.
[x] Searched for existing issues and pull requests.

Description

Description of the issue.

The documentation and the source code disagree on the order of the boolean arguments to kernelBetainc.
docs last arguments are: regularized, upper
code last arguments are: invert, normalized
code documentation that invert means upper, and normalized means regularized
Additionally, the code for the case where storage is newly allocated drops the last argument.
The numerical cases code agrees with the main.js code and disagrees with the website documentation.
The non-kernel function is documented as regularized, upper.
The non-kernel function's code correctly reverses the arguments to match kernelBetainc's code. Additionally it statically allocates storage, so the bug in the "allocate new storage" is not seen.
The name "invert" for "upper" may also cause confusion with inverse distribution. "upper" and "regularized" seem like fine names to use consistently in both the documentation and the code.
Related Issues

Does this issue have any related issues?

I did not see any.
Questions

Any questions for reviewers?

No.
Other

Any other information relevant to this issue? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

No
Demo

If relevant, provide a link to a live demo.

No.
Reproduction

What steps are required to reproduce the unexpected output?

out1=[0,0];
out1 = kernelBetainc( out1, 0.2, 1.0, 2.0, true, true );
out2 = kernelBetainc( 0.2, 1.0, 2.0, true, true );

Expected Results

What are the expected results?

out1 and out2 should be (exactly) equal.
Actual Results

What are the actual results?

Not equal
Environments

What environments are affected (e.g., Node v0.4.x, Chrome, IE 11)? If Node.js, include the npm version, operating system, and any other potentially relevant platform information.

all environments where the code can run

@jackschmidt Thanks for reporting this bug! We'll work to get a fix shortly.

@Planeshifter Can you look into this?

@Planeshifter We should also add additional tests here.

Thank you for filing this issue!
We can confirm the errors in the documentation as well as the inconsistent naming and will fix it shortly.
But you be able to please elaborate a bit more on the unexpected output you are seeing?
When running your example code
out1=[0,0];
out1 = kernelBetainc( out1, 0.2, 1.0, 2.0, true, true );
out2 = kernelBetainc( 0.2, 1.0, 2.0, true, true );

I see both out1 and out2  having the values [ 0.64, 1.6 ].
From what I can tell, the implementation doesn't drop an argument; it's just that the names do not align when only five arguments are supplied and the output array is omitted:
function kernelBetainc( out, x, a, b, invert, normalized ) {
	if ( arguments.length === 5 ) {
		return compute( new Array( 2 ), out, x, a, b, invert ); // here `out` is `x`, `x` is `a`, `a` is `b` etc.
	}
	return compute( out, x, a, b, invert, normalized );
}

Thank you!
My apologies. Yes, the variables are simply renamed. No code error, just disagreement with docs.
Thanks again! I am looking for a stable version of the upper binomial cdf (my simple 1 - summation has returned negative probabilities) and I think your project will work well.

No worries, thanks for the confirmation!
Will post here once the documentation is updated.
With respect to a binomial CDF, just a pointer that we have statistical distributions including functions like PDF, CDF, and quantiles living at https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists.

With commit 384f5d0ed2fefa7dad236c1e2f39110e5117dd38, we have now updated the documentation and changed the parameter order of kernelBetainc to match both @stdlib/math/base/special/betainc and the documentation of  @stdlib/math/base/special/kernel-betainc. Closing this issue, but please let us know in case you encounter any further issues. Thanks again!


The docs for Analyze said plot_bars for plot_kde as well.

make sure that all tests are passed
create some unit tests and update testing procedures accordingly
make PR to dev (or daily-dev)

Thanks! :)


Error: Failed to obtain profile data for , does this account own minecraft?

Started experiencing this error today when launching my docker container. The account does indeed has minecraft.
at Object.authenticate (/usr/src/app/node_modules/minecraft-protocol/src/client/microsoftAuth.js:31:40)
at processTicksAndRejections (node:internal/process/task_queues:96:5)

no idea what can cause that seems like this error comes from the mineflayer package that is used for the minecraft bot

Just to answer this issue, this error happens when you get a suspension on your gmail account and try to login. Just incase you'd like to catch the error and give a more detailed explanation.


Use an arm64 runner for CI

Let's see where the issues are

@DivineDominion
Now it builds on arm64 as well.
Next upcoming thing could be a release pipeline, with an autogenerated changelog

Thank you for powering through this! Just have one question real quick to maybe remove redundant instructions. But we're good to merge either way.

I solved the conflict

Sorry for the delay! With our toddler at home, I just didn't notice that so much time has passed. Thank you for your work on this!


TracingConnectionFactory

The library lacks TracingConnectionFactory class for tracing ConnectionFactory.
You're creating TracingConnection only in the one place:
https://github.com/opentracing-contrib/java-jms/blob/3aa4af830745624e9bb593e6bd6b6a08e6bddbcc/opentracing-jms-spring/src/main/java/io/opentracing/contrib/jms/spring/TracingJmsTemplate.java#L47-L50
Where super.createConnection() uses ConnectionFactory under the hood.
So, in case of JmsTemplate tracing will work properly. But in all other cases not. I've noticed this issue when was trying to use DefaultMessageListenerContainer and it didn't work well. It uses Connections, where correct behavior is to use TracingConnections.
Instrumentation based on ConnectionFactory seems to be more correct approach (it's also used in Brave, for example).

@berserkk please submit a PR for adding TracingConnectionFactory if you are interested in it.

@malafeev I'll try to do PR in the nearest time.

@malafeev created PR, please review.

Solved with #40.