Bug 80609: Text fields too big for outlook

Change max length values as suggested in task AB#80609

I think we should add a migration script so the restrictions are added to columns in db as well. I can show you at some point


player stops playing after 10s

This is my simple test app:
public class MainPageViewModel
{
    readonly IAudioManager audioManager;

    public MainPageViewModel(IAudioManager audioManager)
    {
        this.audioManager = audioManager;
    }

    public IAsyncRelayCommand PlayAudioCommand => new AsyncRelayCommand(PlayAudio);

    public async Task PlayAudio()
    {
        using var stream = await FileSystem.OpenAppPackageFileAsync("Dopamine.mp3");
        var audioPlayer = audioManager.CreatePlayer(stream);

        audioPlayer.Play();
    }
}

<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:viewModel="clr-namespace:MauiAppAudioPlayer"
             x:DataType="viewModel:MainPageViewModel"
             x:Class="MauiAppAudioPlayer.MainPage">

    <ScrollView>
        <VerticalStackLayout
            Spacing="25"
            Padding="30,0"
            VerticalOptions="Center">

            <Label
                Text="Play"
                SemanticProperties.HeadingLevel="Level2"
                SemanticProperties.Description="DISCO PURPLE MASCHINE - Domapine"
                FontSize="18"
                HorizontalOptions="Center" />

            <Button
                x:Name="playButton"
                Text="PLay"
                SemanticProperties.Hint="Playes DISCO PURPLE MASCHINE - Domapine"
                Command="{Binding PlayAudioCommand}"
                HorizontalOptions="Center" />

        </VerticalStackLayout>
    </ScrollView>

</ContentPage>

The mp3 file started to play and stops after around 10s and no errors.
At the console the only output is:
[MediaPlayer-JNI] MediaPlayer finalized without being released

Try the solution in here:
https://github.com/jfversluis/Plugin.Maui.Audio/issues/43

public class MainPageViewModel
{
    private readonly IAudioManager audioManager;
    **private IAudioPlayer audioPlayer;**

    public MainPageViewModel(IAudioManager audioManager)
    {
        this.audioManager = audioManager;
    }

    public IAsyncRelayCommand PlayAudioCommand => new AsyncRelayCommand(PlayAudio);

    public async Task PlayAudio()
    {
        using var stream = await FileSystem.OpenAppPackageFileAsync("Dopamine.mp3");
        **this.audioPlayer** = audioManager.CreatePlayer(stream);

        this.audioPlayer.Play();
    }
}

The correct answer:
Holding a reference to it at the class level and see if that solves your issue? It might be that the garbage collector thinks the player instance is no longer being used by anything and tidying it up.

That's it yeah. Did that solve your issue?

Yes
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
06/16/23,
01:22:30 PM
On Fri, Jun 16, 2023 at 1:21 PM Shaun Lawrence @.***>
wrote:

That's it yeah. Did that solve your issue?
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/issues/58#issuecomment-1594522915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ65RO7PHJENIWXCX3UZSR3XLQ6VLANCNFSM6AAAAAAZI6P5DQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Great!
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&
06/16/23,
03:20:42 PM
On Fri, Jun 16, 2023 at 2:56 PM Shaun Lawrence @.***>
wrote:

Closed #58 https://github.com/jfversluis/Plugin.Maui.Audio/issues/58 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/jfversluis/Plugin.Maui.Audio/issues/58#event-9551272907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ65ROYZTWOO7VAR42NAT2LXLRJYJANCNFSM6AAAAAAZI6P5DQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Marker shading is inconsistent with the shading of all other geometry in the 3D view

Steps to reproduce
Load any model with markers and look at it.
Expected result
Spheres are shaded with light source in common with all other objects.
Actual result
Spheres appear to be magically illuminated from below (that is from the floor up).

Environment and GUI version
OpenSim 4.0 on Mac and Windows

There was an old issue about this. IIRC, the issue was that the back faces were being drawn rather than the front faces. It looks like an open hemisphere is being drawn, and the light from above the model is reflecting off the inside of the hollow bottom.


MP3 seeking

MP3 seeking to specified time doesn't work correctly. It compares specified position (computed from bitrate) with position in compressed stream  - IMHO it's not correct. After my own some changes it still not works :(

Guessing you are using VBR mp3s? I could see variable bit rate being a problem here. I know it is in other audio libraries.
If you are using variable bit rate, could you try with a fixed bit rate mp3 and see if the problem persists?

This issue has been open for 3 months. I did some testing and im sure it is due to VBR mp3s. Current we use a external library to do our mp3 decoding and seeking the library is mpaudec. Going to close this issue for the time being.


vim-tidal with remote peers

Hi there, I hope you all are well and fine.
This is not an issue, but a question. Before I start to cross-posting this everywhere I thought I should start with this plugin I use and love for a long time already.
I'm trying to find a way to livecode tidal using (neo)vim with remote peers.
I have achieved almost the same but with SuperCollider, mixing this tools:
Instant to share the buffers and write together + HyperDisCo for the SC part + scnvim as it should.
In that way I'm using two remote servers, one for Instant and the other for HyperDisCo.
So, I would like to make the tidal side of it working.
My first thought was to put the tidal part in the loop I already have, so the OSCRouterClient (part of HyperDisCo) would receive and re-transmit the OSC messages from Tidal as is, and the SuperDirt on the other side wouldn't even be aware this had come from a remote source. (I can send my small [unsucceded] experiments in that direction).
Then I thought that, mediated by a server (how should it be?), one instance of Tidal in tidal-vim could send the OSC to the ghci instance in the REPL from the remote peers. I'm probably not accurate with the terms here.
That's all I have. I have found some inspiring random stuff on the internet but I don't know exactly what is worth.
Thank you in advance for any insights
best regards,
Gil

Time to cross-post


Replace google-oauth-java-client with google-auth-library-java

Fix #495

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e8e5db8). Click here to learn what that means.
The diff coverage is 55.55%.

@@            Coverage Diff            @@
##             master     #496   +/-   ##
=========================================
  Coverage          ?   78.44%
  Complexity        ?      664
=========================================
  Files             ?       73
  Lines             ?     1888
  Branches          ?      281
=========================================
  Hits              ?     1481
  Misses            ?      230
  Partials          ?      177


Update axoloti-runtime to 1.0.12-1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 2f78738859777b52447293e1a757924392a8a923. Your contribution is still credited to you.


Images showing as code samples in migration API doc

Issue Summary
In the Troubleshooting section of the migration API docs there are two code samples shown but it looks like these should be images?

To Reproduce

Open https://docs.ghost.org/api/migration/#troubleshooting

@JohnONolan I believe you migrated these API docs - can you take a look at Kevin's comments and confirm if these code samples are meant to be images instead?

yes kevin is right, you can see by opening the image urls in the codeblock, ^ that one above is:


ImageImportControllerConfig: support the number of workers

https://issues.redhat.com/browse/IR-462
/cc @flavianmissi @dmage

Looking good. We need a matching PR on the openshift controller manager side that makes use of this new field too before we can merge this one right? I think the api change and the functionality need to go in together (as much as possible).

Looking good. We need a matching PR on the openshift controller manager side that makes use of this new field too before we can merge this one right? I think the api change and the functionality need to go in together (as much as possible).

Thanks for the review. I got a question as a first time PR author to api repo. :)
How can we compile openshift-controller-manager without upgrading its dependency of api including this new field?

How can we compile openshift-controller-manager without upgrading its dependency of api including this new field?

You can't. What you can do is temporarily upgrade/replace it to your fork's branch with the changes in this PR. Something like (untested):
replace github.com/openshift/api => github.com/hongkailiu/api IR-462

Then run go mod tidy && go mod vendor. Once you know everything is working on both ends and the changes in this PR merge you can remove the replace and do a proper bump of openshift/api.

Thanks for the pointer. I will try it out.

/close
As hinted in slack discussion, this might not achieve what I wanted: more workers to do the imports which are handled by the api-server eventually. The workers here might be something else.


PVGeo installation for Paraview integration

Unfortunately the procedure described in Getting Started fails, after activation of pvgeoenv the installation of PVGeo runs into an error, as imageio requires Python >=3.5. Any workaround?

at this time, I do not have a good workaround for this. I currently only have the bandwidth to support PVGeo with PyVista at this time.
With that said... have you tried updating ParaView? I have v5.9 locally which bundles Python 3.8.6 which should be compatible

Hi,
Is there any solution to this issue now?? or, there is no way to use PVGeo with Paraview??
Cheers

PVGeo can still be used in ParaView, I just need to update the installation instructions. I'll see if I can get around to this soon

Ok, thanks for your quick answer. Looking forward to it!!

Working on this... currently blocked by https://github.com/pyvista/pyvista/issues/3224

FYI https://github.com/Kitware/ParaView/blob/master/Web/Python/paraview/web/venv.py

I have dropped support for ParaView, please use PyVista instead: docs.pyvista.org


General question about simdpp vector types

Hi,
From what I think I understood, in order to use the simdpp optimized functions, you must use the libsimdpp vector types.
So suppose I already have two float arrays, if I want to add them using libsimdpp, I have to create two vectors and copy the arrays in the vectors, is it right ?
Meaning that you cannot directly use the functions on stl vectors for instance ?
Thanks

Hi,
You will need to load the data into the SIMD vectors, do the operations and store the data to the stl vector. This copying is not overhead -- one will need to load data to and from SIMD registers regardless of what API one uses -- be it intrinsics, assembler or libsimdpp.
For example, to add data in two arrays:
void add_arrays(const float* a, const float* b, float* c, unsigned size) {     // assuming a, b and c are correctly aligned and that size is a multiple of N     using namespace simdpp;     const unsigned N = 4; // one might want to set this to 8 on AVX     for (int i = 0; i < size/N; ++i) {         float<N> ia = load(a); a+=N;         float<N> ib = load(b); b+=N;         ia = add(ia, ib);         store(c, ia); c+=N;     } }
The above is the simplified example. In real world you will want to handle misalignment and any size, not only a multiple of N. I guess I'll add a real-world example to the repository.

Ah ok, thanks. The vector types are used to represent the quaternions of floats for example.
I thought there were STL-like vectors that you had to use to be able to use your simd-optimized functions.
It makes more sense.


log sidecar log external IP?

Hi Guys
I've enabled sidecar logging controller.logs.enabled: true but in the request logs I see the IP address of the haproxy ingress pod (<IP_ADDRESS> in my case) and not the external IP. I run the ingress on two different types of clusters:

Behind AWS application load balancer (which sets X-Forwarded-For)
On bare metal using a floating IP (Hetzner Cloud) with no load balancer

I tried setting this configuration, but nothing changed:
controller:
  config:
    forwardfor: ifmissing

Any ideas?

Hi, any step forward on this? Note that a L4+ load balancer will always change the source IP, but you should see the lb IP instead of the pod itself. x-forwarded-for isn't used for logging the source ip, you'd need to customize the log to use the header value instead. If AWS lb supports proxy protocol (I think it supports) you can use it to propagate the client IP to haproxy, so configure use-proxy-protocol, doc here.
 Maybe you have some sort of nat in your node but it's not clear to me how this could happen and what to suggest.

Hi.
For AWS I can confirm, I see the IP address of the load balancer, so you are right, I will need to log the X-forwarded-for header, apologies, I mistook the IP of the load balancer for the pod (similar looking subnets)
However, in Hetzner cloud the node is directly on the internet. We are running k3s clusters, so I did a bit of digging - it seems that the k3s traffic manager Klipper actually manages the node ports 80 and 443 using Iptables rules and haproxy is bound to higher ports. In my case the haproxy service HTTPS port is on nodeport 32192.
What I see is, if I connect (from the internet) to https://myserver:32192, haproxy sets the correct x-forwarded-for header, but if I connect to https://myserver:443 haproxy sets the pod IP as the header.
I don't know enough about Kubernetes overlay to explain what is happening here or how to see the real IP. Any suggestions?

I don't know k3s enough to provide a proper suggestion, and in a quick test I can apparently see the source IP correctly. As a simple test you can try to remove the haproxy-ingress service (the type: LoadBalancer one) - Klipper uses this service to provision a pod that configures the route between port 80/443 to the pod - and configure the controller to bind to the host network. controller.hostNetwork in the helm chart. This should solve the problem or give you some evidence that the problem is elsewhere in the topology. Note that the controller publicly binds some ports that you will not want to make public, so properly configure a security group if you choose to leave it as the final configuration.

The test as you suggested was successful. I removed the service and changed controller.hostNetwork to true and now see the correct IP address (at the very least correctly in x-forwarded-for which is fine).
But I'm not sure about running this as a final configuration: for one thing I believe the ingress controller would need to run on every node (fine for a small install, but a 50 node install doesn't need 50x haproxy instances) which is IMHO why a service is better, but I can live with this set up (any other ports are blocked by firewalld anyway).
However the other "problem" is that the service will always return if the Helm chart is reconfigured or updated - there isn't an option to turn it off I could create an issue there to make this optional?

Hi, unfortunately I cannot help that much on why Klipper is changing your source IP, maybe a small reproducer with echoserver in the rancher forums or issue tracker might help.
Regarding the deployment you can configure the controller.service.type as ClusterIP - although a type None would be very welcome to remove the whole service manifest. I'll take care of this.
Regarding the hostNetwork you can use a daemonset with node selector and label the nodes you want the controller should be running, so you'll know what IPs you should for example configure in your DNS.


Nested group components are not showing when deleting a previously added repeating group index. Stopped working in v.4.8

Description of the bug
When adding two repeating group indexes (includes nested groups) and you delete the first added repeating group index, the nested group information in the second repeating group index will not show, unless you do a hard refresh.
What it looks like in the second repeating group index in the nested group after deleting the first repeating group index:

When adding a new index to the nested group:

After hard refresh:

Note that this is only happening when deleting an earlier repeating group index. E.g. if you have index 1 and 2 and delete index 1.
I tried different versions of frontend and noticed that this works fine in v.4.7.0, and stops working when using v.4.8 and above/including preview versions.
Steps To Reproduce

Add a repeating group with one or more nested repeating groups.
Add two indexes of the repeating group with information in the nested groups
Delete the first index.

Additional Information
No response

Confirmed to have been fixed in v4.8.2: https://digdir.slack.com/archives/C0760NPT2BE/p1726655063015979?thread_ts=1726214295.152349&cid=C0760NPT2BE


How can i change height of your datepicker component?

I put it inside of my parent div and my div is 30px height, but your default height is 35px.

Either by using css variables or overriding the classes


does your vgg16 code train the sift feature

Hello, I want to ask a question, does your vgg16 code train the sift feature, and haven't had time to look at it.

No just use existing vgg model to extract features


Webm to MP3 or other format

Hi everyone.
I thank you for the package which is super easy to use but I wonder how I can get a mp3 or other version to support the audio for the ios safari etc.

The only solution comes to me which is to convert it using external services or build an microservice for it.
Is there any workaround?

PS:
const output = await youtubedl(url, {
		dumpSingleJson: true,
		noCheckCertificates: true,
		noWarnings: true,
		preferFreeFormats: true,
		addHeader: ['referer:youtube.com', 'user-agent:googlebot'],
		extractAudio: true,
		audioFormat: 'mp3'
	});

I installed ffmpeg but it didn't work ( I could not find the url).

youtubedl just get the audio from the source. In order to convert it into a different format, you should to use a specific software for that


Syntax improvements

-Remove Clear keyword from variables and functions for more consistent (via mambo)
-Move function lexicon evaluation above predefined functions for alias functionality?

Fixed in next version:
-Clear and All keywords have been removed in favor of Variables, Functions, and Unfunction.
--To clear all variables, call (Remove (Variables)).
--To clear all functions, call (Unfunction (Functions))
Lexicon evaluation before keyword evaluation will not be implemented, as there is too much of a risk of softlocking the interpreter.


Test can't find a popup menu item by type

I have a menu item whose text is identical to text elsewhere on the page, and I want a test to specify which text it taps. However, I'm unable to select a popup menu item by type.
void main() {
  testWidgets('Find menu item by type', (WidgetTester tester) async {
    await tester.pumpWidget(MaterialApp(
      title: textFor('app_title'),
      home: Scaffold(
        appBar: AppBar(
          title: Text("Title"),
          actions: [
            PopupMenuButton<int>(
              itemBuilder: (cx) => [
                PopupMenuItem(value: 0, child: Text("UniqueTerm")),
                PopupMenuItem(value: 1, child: Text("NonUniqueTerm")),
              ],
            )
          ],
        ),
        body: Text("NonUniqueTerm"),
      ),
    ));

    await tester.tap(find.byIcon(Icons.more_vert));
    await tester.pumpAndSettle();

    // Each of the following lines fails no matter which is run.
    await tester.tap(findTextForType(AppBar, "NonUniqueTerm"));
    await tester.tap(findTextForType(PopupMenuButton, "NonUniqueTerm"));
    await tester.tap(findTextForType(PopupMenuItem, "NonUniqueTerm"));
    await tester.tap(findTextForType(PopupMenuEntry, "NonUniqueTerm"));
  });
}

Finder findTextForType(Type type, String text) {
  return find.descendant(
    of: find.byType(type),
    matching: find.text(text),
  );
}

The test always fails with "No Element", no matter which of the above types I use. If there is another way to select the menu item, I'm thinking it should be documented, because the obvious thing to try isn't working.
PopupMenuItem does appear in the dev tools tree.
As an aside, I'd also love to know how we're supposed to find the overflow menu in a platform-independent way. The above is hard-coded to the Material design Icons.more_vert icon.
Target Platform: Testing on the desktop with macOS 10.12.6.

I'm now having a similar problem trying to automate testing of a DropdownButtonFormField. I have a dropdown field called "Type". It contains a few options, one of which is "Quote".
Before the test taps on the "Quote" option, there is only one widget on the page containing the string "Quote". After I tap on this option, there are two such widgets on the page. Presumably, the new widget is the value that the form now displays for the DropdownButtonFormField.
I don't know how to verify that the field now displays the value "Quote", except to look for two widgets containing this text. I'd rather explicitly check the value shown in the field. I realize that in this particular case I should just trust Flutter to work properly and not check for the value.
This seems like something that people would do often, so I'm now doubting that I'm doing things properly. Surely the Flutter team would have encountered this.

Okay, I've found the problem, if not the solution. The types have to be parameterized to properly find them. I'm closing this to go off and find another way.


Logging

Logging works and the client transmits errors to the server for it to log.

Logging should work in its own goroutine. Seperate logging operations cannot execute concurrently because log blocks while writing, which is why a single goroutine which reads from a channel is probably smarter.

Server sided logging is done.

Done.


Made few changes to README.adoc

@ArpitLekhwar Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

This change is not necessary.


Unexpected push_back result

#include <iostream>
#include <cstdlib>
#include "tinyutf8.h"

int main()
{
    tiny_utf8::utf8_string str;
    str.push_back(U'a');
    std::cout << str.size() << "\n" << str[0] << "\n" << str << "\n\n";

    std::string str1;
    str1.push_back('a');
    std::cout << str1.size() << "\n" << str1[0] << "\n" << str1 << "\n";
}

outputs
1
a
a

for the std::string as expected, but
1
0

for tiny_utf8::utf8_string (using Clang 10). It seems \0 is getting appended instead of a.

Hi Alexey,
Thank you for the bug report and for the minimal example. It made it really easy for me to spot the bug!
I just fixed the issue in the last commit 😃
Cheers,
Jakob


Point Cloud Interface

Add a basic point cloud interface and ETI infrastructure for libraries.

@sslattery watch your C++ format...

dude its WIP

Yep but if you don't, then you either will have to squash everything on one gigantic commit or you will have intermediate commits violating the format and one that enforces it and touches all files...

i thought you wanted to squash PRs anyway?

No, we only squash when we want to slightly edit history before we merge into master.  We certainly don't want to turn every PR in a single commit.

ok - we need to fix the thing that fails to pull the clang format on my box then.

OK Ready for review

Current coverage is 95.71% (diff: 100%)

Merging #161 into master will increase coverage by 0.01%

@@             master       #161   diff @@
==========================================
  Files           375        379     +4
  Lines         27983      28090   +107
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          26778      26885   +107
  Misses         1205       1205
  Partials          0          0

Powered by Codecov. Last update d68b998...31ba973

I'll take a look at it later today.

The code does not compile for me:
../../DataTransferKit/packages/Kokkos/src/DTK_PointCloud_def.hpp:206:12: error: prototype for ‘DataTransferKit::PointCloud<SC, LO, GO, NO>::global_id_view Dat
aTransferKit::PointCloud<SC, LO, GO, NO>::globalIds() const’ does not match any in class ‘DataTransferKit::PointCloud<SC, LO, GO, NO>’
 const auto PointCloud<SC, LO, GO, NO>::globalIds() const -> global_id_view
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from DataTransferKit/packages/Kokkos/src/DTK_PointCloud_DOUBLE_INT_UNSIGNED_LONG_SERIAL.cpp:59:0:
../../DataTransferKit/packages/Kokkos/src/DTK_PointCloud_decl.hpp:95:26: error: candidate is: const global_id_view DataTransferKit::PointCloud<SC, LO, GO, NO>
::globalIds() const
     const global_id_view globalIds() const;
                          ^~~~~~~~~
In file included from DataTransferKit/packages/Kokkos/src/DTK_PointCloud_DOUBLE_INT_UNSIGNED_LONG_SERIAL.cpp:60:0:
../../DataTransferKit/packages/Kokkos/src/DTK_PointCloud_def.hpp:214:12: error: prototype for ‘DataTransferKit::PointCloud<SC, LO, GO, NO>::coordinate_view Da
taTransferKit::PointCloud<SC, LO, GO, NO>::coordinates() const’ does not match any in class ‘DataTransferKit::PointCloud<SC, LO, GO, NO>’
 const auto PointCloud<SC, LO, GO, NO>::coordinates() const -> coordinate_view
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from DataTransferKit/packages/Kokkos/src/DTK_PointCloud_DOUBLE_INT_UNSIGNED_LONG_SERIAL.cpp:59:0:
../../DataTransferKit/packages/Kokkos/src/DTK_PointCloud_decl.hpp:98:27: error: candidate is: const coordinate_view DataTransferKit::PointCloud<SC, LO, GO, NO
>::coordinates() const
     const coordinate_view coordinates() const;
                           ^~~~~~~~~~~

Not sure why - it compiles for me, in the docker, and the CI server

Will add more doxygen

OK this should be ready to merge after checks run

@sslattery Maybe clean up the branch?

OK - @dalg24 @aprokop should i do a single commit squash or break up some other way?

@sslattery I'd do two: 1. ETI infrastructure, and 2. Point cloud

ok - so would i first reorder in an interactive rebase and then squash twice?

I'd say do  git reset master and then do git add on selected files as I think they are independent.

ok branch is cleaned


Implement cancel previous CI build for PRs

We might push frequently to the PRs which will cause CI builds to trigger for each push. In order to prevent the unnecessary usage of resources, we need to implement a way to cancel previous builds for Github action.
There is a Github action exactly for this: https://github.com/marketplace/actions/cancel-workflow-action

@saw-jan I would love to work on this. But it will take a bit long time to research and implement this. (Need self-research + guidance)


vmware-guest module: work under aarch64

Description of changes
Fixes #147650

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I don't have an aarch64 system where I can test this. It's just a guess based on feedback and looking at code.

Successfully tested in #147650


[notification] notification.is_permission_granted not allowed on window main

I am trying to use the notification plugin and I am getting this error: Uncaught (in promise) notification.is_permission_granted not allowed on window main, webview main, allowed windows: , allowed webviews: , referenced by .
Here are my main.json cabalitities file:
{
  "$schema": "../gen/schemas/mobile-schema.json",
  "identifier": "mobile-capability",
  "windows": ["main"],
  "platforms": ["iOS", "android"],
  "permissions": [
    "nfc:allow-scan",
    "notification:allow-is-permission-granted",
    "notification:allow-notify"
  ]
}

And i am trying to use the plugin in my Vue app:
import {
    isPermissionGranted,
    requestPermission,
    sendNotification,
} from '@tauri-apps/plugin-notification';

export default {
    async mounted() {
        let permissionGranted = await isPermissionGranted();
        if (!permissionGranted) {
            const permission = await requestPermission();
            permissionGranted = permission === 'granted';
        }
        if (permissionGranted) {
            sendNotification('Tauri is awesome!');
            sendNotification({ title: 'TAURI', body: 'Tauri is awesome!' });
        }
    },

Finally, I also register the plugin:
pub fn run() {
    tauri::Builder::default()
        .plugin(tauri_plugin_shell::init())
        .plugin(tauri_plugin_nfc::init())
        .plugin(tauri_plugin_notification::init())
        .invoke_handler(tauri::generate_handler![greet])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

duplicate of https://github.com/tauri-apps/tauri/issues/9502

facing same issue, any fix on this yet


Fix SIGSEGV when running newsboat -r

While investigating #1163, I found that newsboat -r segfaults for me with the following backtrace:
#0  0x000056442a4a8976 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::size (this=0x98) at /usr/include/c++/10/bits/basic_string.h:2833
#1  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_check (__s=0x56442a705270 "basic_string::substr", __pos=0, this=0x98) at /usr/include/c++/10/bits/basic_string.h:312
#2  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::substr (__n=6, __pos=0, this=0x98) at /usr/include/c++/10/bits/basic_string.h:2835
#3  newsboat::RssFeed::is_query_feed (this=0x0) at include/rssfeed.h:142
#4  newsboat::Reloader::reload (this=0x56442bd73690, pos=1, max=567, unattended=<optimized out>, easyhandle=0x7f031bffe978) at src/reloader.cpp:67
#5  0x000056442a4a994b in newsboat::Reloader::reload_range (this=0x56442bd73690, start=<optimized out>, end=<optimized out>, size=567, unattended=false) at src/reloader.cpp:253
#6  0x00007f03249a7c60 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7  0x00007f0324ecfea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
#8  0x00007f03246b1eaf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Note that this pointer is zero in frame 3.
I failed to create a sufficiently small reproducible example; looks like one needs my cache file to trigger this, and also use more than one reload thread.
I also failed to pinpoint the exact reason for the segfault. However, while reading the code I noticed that:

FeedContainer stores a vector of feeds, and that vector is public;
the vector is protected by a private FeedContainer::feeds_mutex, which is used in all relevant methods of FeedContainer;
Controller has its own feeds_mutex and uses it every time it accesses FeedContainer::feeds.

I guess this is a leftover from a refactoring we made a few years back, when we split Controller into smaller classes — that's when we introduced FeedContainer (https://github.com/newsboat/newsboat/pull/216).
This fixes the segfault for me. If newsboat -r segfaults for someone else, please check out these changes and see if they fix it for you, too.
Reviews welcome! I'll merge this in three days, provided the CI is green and no issues are raised.

Oh, turns out we already had an issue about making FeedContainer::feeds private: https://github.com/newsboat/newsboat/issues/1027. Merging this PR will close that issue.

Coverage decreased (-0.007%) to 57.102% when pulling 9ef1c453f9cd92db0c8b63b20463eac868255eac on bugfix/segfault-on-dash-r into e0e76c34bf3713a9e3c94d97c388120c31ad76b3 on master.

Both are definitely issues, thanks for spotting them! I'm working on the fixes now.

Thanks! I'm squashing the fixup and force-pushing; will merge once all the CI checks pass.


 I already feared that the data in the report were not enough, but that's all I had from the wireshark dump of the app <-> crate traffic.

Hello @cweiske,
I'm closing this issue. The fix will be available in 1.0.2 release.
Thanks again for reporting!


Some Authentication is still performed even without calling app.UseAuthentication()

This is probably an strange quirk of Identity system vs MVC.
This document says that Authentication is inserted into the middleware pipeline by calling app.UseAuthentication() at the appropriate place in your Startup.Configure() method.  Well, in our app we want the ability to disable authentication with an environment variable for testing purposes.  We thought we could do this by simply surrounding the call as follows:
public void Configure(IApplicationBuilder app)
{
    if (authEnabled())
    {
        app.UseAuthentication();
    }
}

And of course, all our controllers are tagged with the [Authorize] attribute.  Well, it turns out that MVC adds a default AuthorizeFilter with a DenyAnonymousAuthorizationRequirement even if you intentionally leave out app.UseAuthentication().  This means some level of auth is still required even though we were expecting it not to be...
Might be worth calling this out in the docs?  Or working with the MVC team to change this behavior?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94bfd895-d2af-390b-0801-428b36a27ff4
Version Independent ID: 0e0d870e-e49a-e16c-c259-68d58e701b8f
Content: Introduction to Identity on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

If you use [Authorize], you get the behavior you mention. You need to remove that too. You can do that with #if


feat(Chromium): roll Chromium to r510141

This roll includes the following important revisions:

https://crrev.com/509990 - DevTools: Allow location to be specified in
Input.dispatchKeyEvent
https://crrev.com/509486 - DevTools: fix extra HTTP headers not sent
on browser navigation request

References #877, references #777

@JoelEinbinder: FYI


[Impeller] The ListView background image keep flashing when scroll

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
flutter_app.zip

download flutter_app.zip
exact it and run it with flutter 3.10.6 on iOS (simulator or real device)
scroll up/down the page.

Expected results
I hope the backgroud image can scroll with the list view, It goes well when turn off the Impeller.
Actual results
the Listview item scroll well, but the decorated background keep flashing and not scroll with the list view.
Code sample
Code sample
CustomScrollView(
        slivers: [
          SliverToBoxAdapter(
            child: Container(
              height: 200,
              width: MediaQueryData.fromView(WidgetsBinding.instance.platformDispatcher.views.first).size.width,
              color: Colors.green,
            ),
          ),
          SliverToBoxAdapter(
            child: Container(
              decoration: BoxDecoration(
                image: DecorationImage(
                  image: Image.asset('assets/bg.webp').image,
                  alignment: Alignment.topCenter,
                  fit: BoxFit.fitWidth,
                  repeat: ImageRepeat.repeatY,
                ),
              ),
              child: ListView.builder(
                physics: const NeverScrollableScrollPhysics(),
                shrinkWrap: true,
                itemBuilder: (context, index) {
                  return ListTile(
                    title: Text("hello $index"),
                  );
                },
                itemCount: 100,
                itemExtent: 100,
              ),
            ),
          )
        ],
      )

The core code is DecorationImage, when turn off Impeller on iOS, it works well, but when turn on Impeller, background image keep flashing when scroll.
please use this demo code to run directly:
flutter_app.zip
Screenshots or Video

Screenshots / Video demonstration
Flashing video:
https://github.com/flutter/flutter/assets/20474091/51fc9297-b502-4f56-98c0-c539c1be1000
When turn off Impeller, work well video:
https://github.com/flutter/flutter/assets/20474091/900e4028-838c-4d69-8e11-5901cef2f527

Logs
No logs for this, please just run the demo code.
Flutter Doctor output
Doctor output
Last login: Fri Aug 11 15:49:07 on ttys014
qxy9763@LSCN954535 ~ % flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.5 22G74 darwin-x64, locale en-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] IntelliJ IDEA Community Edition (version 2023.2)
[✓] VS Code (version 1.81.0)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!
qxy9763@LSCN954535 ~ %

Hi @techwn
This issue seems to have been fixed on the latest master channel as I cannot reproduce it there on my device: iPhone 7, iOS 15.7.2.

Demo
https://github.com/flutter/flutter/assets/104349824/bdda28b5-f5dd-4d00-bdfb-e4e7d0a00d42

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.10.6 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (3 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-beta.app/Contents/Developer
    • Build 15A5195m
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 115.0.5790.114

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.14.0-3.0.pre.32, on macOS 13.5 22G74 darwin-x64, locale en-VN)
    • Flutter version 3.14.0-3.0.pre.32 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 653187668a (60 minutes ago), 2023-08-10 22:12:34 -0400
    • Engine revision 578a8e8aab
    • Dart version 3.2.0 (build 3.2.0-58.0.dev)
    • DevTools version 2.26.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.70.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 13.5 22G74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 115.0.5790.170

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I'll close this issue as fixed on the latest master channels. If you still experience this issue, kindly leave a comment below and I will reopen this. Thank you!

@huycozy,  I also try the master channel, it works fine.
but with stable channel it works not fine.
So will this fix cherry-pick to stable channel as patch fix like: 3.10.7?
We are upgrading our app to latest stable patch fix: 3.10.6, if fix of Impeller not cherry-pick to stable channel, we will need to wait for another 6 months to take the advantage of Impeller in our production.

Please see Will a particular bug fix be provided in a hotfix release?


[tlse] tls for GlanceAPI pod configuration

Public/Internal service cert secrets and the CA bundle secret can be passed to configure httpd virtual hosts for tls termination. The certs get direct mounted to the appropriate place in etc/pki/tls/certs/%s.crt|key and a CA bundle to
/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem . Job deployments for bootstrap/cron get the CA bundle added if configured.
Also indexes the named input resources for password, CA bundle, and endpoint secrets to be able to watch them for a change and reconcile.
Depends-On: https://github.com/openstack-k8s-operators/lib-common/pull/384
Jira: OSPRH-1233

needs a rebase for the glanceapi change

/test glance-operator-build-deploy-kuttl

/test glance-operator-build-deploy-tempest

/test glance-operator-build-deploy-kuttl

error: build error: Failed to push image: trying to reuse blob sha256:07a64a71e01156f8f99039bc246149925c6d1480d3957de78510bbec6ec68f7a at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": net/http: TLS handshake timeout

/test glance-operator-build-deploy-kuttl

error: build error: Failed to push image: trying to reuse blob sha256:07a64a71e01156f8f99039bc246149925c6d1480d3957de78510bbec6ec68f7a at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp <IP_ADDRESS>:443: i/o timeout

/test glance-operator-build-deploy-kuttl

/test glance-operator-build-deploy-kuttl

/test glance-operator-build-deploy-kuttl

/test glance-operator-build-deploy-kuttl

logger.go:42: 16:21:34 | glance_split/3-scale-down-glanceapis | Error from server (InternalError): Internal error occurred: failed calling webhook "mglance.kb.io": failed to call webhook: Post "https://glance-operator-controller-manager-service.openstack-operators.svc:443/mutate-glance-openstack-org-v1beta1-glance?timeout=10s": no endpoints available for service "glance-operator-controller-manager-service"

/test glance-operator-build-deploy-kuttl

/test glance-operator-build-deploy-kuttl


adds resuming playback after interruption

I noticed 2 scenarios that the Looping Video would stop playback:

When returning to the app after it had been put in the background: the willEnterForeground  notification handles this

Occasionally when switching views if the Video was in a TabController: willMove(toWindow) handles this.

this fix seemed specifically relevant to the GIF-like videos, so it is only handled if isLooping is true.
Fixes #44

Thanks, @AndyMeagher. I appreciate it.


File *.svelte is not a module is thrown when using TypeScript preprocessor

File /path/to/file.svelte is not a module is thrown when using the TypeScript preprocessor.
Here's my svelte.config.js
module.exports = {
  preprocess: require('svelte-preprocess')(),
};

tsconfig.json
{
  "compilerOptions": {
    "types": ["svelte"]
  }
}

What am I doing wrong?

it compiles correctly using svelte-preprocess and rollup-plugin-typescript2

Might need to define the module for .svelte files in VSCode.
Try adding this file to your project:
// svelte.d.ts
declare module "*.svelte" {
  const value: any; // Add better type definitions here if desired.
  export default value;
}

@cajames solution did not work for me. I tried both adding "svelte" to types in tsconfig and adding a type definition for *.svelte, neither worked.
Still getting "no default export" or "not a module" error, but only in VSCode.
Same with @pyoner/svelte-ts-preprocess

Same here. Also, duplicate of #64.

Any updates to this?


refactor(themes): apply variables to :root instead of the body class

@antlio pointed out that we could use :has to apply our color variables to the :root instead of body.light-mode which I think is a good idea. It seems like :has has good support and this allows CSS variables to be used anywhere including on the html.
While I was in there I also did some tidying of themes and updated our theme snapshots to make sure these changes didn't break anything (which I'm pretty they haven't).

Does this increase the precedence of variables applied at root?
If so does it break any custom themes?

Does this increase the precedence of variables applied at root?
If so does it break any custom themes?

All of this stuff still get added in a css layer so it shouldn't be able to break any themes


Standardize LSIF capabilities vertex

C# and TypeScript LSIF generators both have support for capabilities vertex. This doesn't yet appear to be referenced in the spec, however.
Such capabilities nodes look like:
{
  "hoverProvider": true,
  "declarationProvider": false,
  "definitionProvider": true,
  "referencesProvider": true,
  "typeDefinitionProvider": false,
  "documentSymbolProvider": false,
  "foldingRangeProvider": true,
  "diagnosticProvider": false,
  "semanticTokensProvider": {
    "tokenTypes": [
      "namespace",
      "type",
      "class",
      "enum",
      "interface",
      "struct"
    ],
    "tokenModifiers": [
      "static"
    ]
  },
  "id": 1,
  "type": "vertex",
  "label": "capabilities"
}

This is a requirement for #1754 which replies on the tokenTypes and tokenModifiers arrays above to decode encoded semantic tokens into token type names.
Open Questions:

Is this entry a vertex or not - In C#, it's not explicitly declared, in TypeScript it is.
Where in the file is it - In C# it's the first line. In TypeScript it tends to be 2nd or 3rd. If not first, what is the criteria for finding it, what if anything can come before it, and what is the expected consumer behavior when it is absent?

It is a vertex and it describes which capabilities (in terms of LSP capabilities the dump supports). This allows LSP servers that surface a LSIF graph to provide the right capabilities on the intialize response.
The constraint I would add to the spec is that the vertex needs to be emitted BEFORE that first project vertex is emitted.


[0] Error while fetching list of available targets

    **Version:**
    1.4.2

    **OS:**
    <!-- Add your hosting platform e.g Microsoft Windows, WSL, MacOs or Linux -->

    **Stack :**
    No available targets to attach.

    **Additional context:**
    <!-- Add any other context or about the problem or screenshots here. -->

Thanks for reaching out, but it would be great if you could please provide more information about your environment and the steps you took when this problem occurred.
As it stands now, we cannot really investigate this bug without knowing more.

I unfortunately will have to close this issue as there is not enough information to help the team investigate and fix a potential issue. Feel free to comment back with more info.


Don't fail for loops

We should not fail for loops where we loop over cfds to process state updates based on information we learned / restart.
We use a macro to wrap all fallible code in the loop to just print an error and continue.
Note: I went over the codebase in search of other for loops, maybe someone else can do another grep :)

bors r+


Comments positioned wrong in function declarations

// comment  `
var f = function(){};

expands to
var // comment  `
f = function(){};

This looks like a bug to me, but maybe it's a style choice?
Personally I would expect it to output the same as the input, and this is true if we instead do:
// comment
var x = 10;

If this is a style choice, it would be nice with an option for it.

Could you show me the AST with comments?
escodegen's comment generations depend on it.

Sure, here's the AST. Generated with the online demo of esprima:
{
    "range": [
        15,
        36
    ],
    "type": "Program",
    "body": [
        {
            "range": [
                15,
                36
            ],
            "type": "VariableDeclaration",
            "declarations": [
                {
                    "range": [
                        19,
                        35
                    ],
                    "type": "VariableDeclarator",
                    "id": {
                        "range": [
                            19,
                            20
                        ],
                        "type": "Identifier",
                        "name": "f",
                        "leadingComments": [
                            {
                                "type": "Line",
                                "value": " testComment",
                                "range": [
                                    0,
                                    14
                                ]
                            }
                        ]
                    },
                    "init": {
                        "range": [
                            23,
                            35
                        ],
                        "type": "FunctionExpression",
                        "id": null,
                        "params": [],
                        "defaults": [],
                        "body": {
                            "range": [
                                33,
                                35
                            ],
                            "type": "BlockStatement",
                            "body": []
                        },
                        "generator": false,
                        "expression": false
                    }
                }
            ],
            "kind": "var"
        }
    ],
    "comments": [
        {
            "type": "Line",
            "value": " testComment",
            "range": [
                0,
                14
            ]
        }
    ]
}

@ggVGc
In this case, the comment is attached to Identifier.
So if you attach leadingComments to VariableDeclaration, I think you can get the expected output.

I see. So this is actually a bug in esprima?

@ggVGc correct


Increased aiofiles version to suppress warnings

With Python 3.8 the usage of this @asyncio.coroutine in aiofiles 0.5.0 raises warnings since the @asyncio.coroutine has been deprecated since Python 3.8. This PR suppresses those warnings by increasing the aiofiles version to 0.7.0.
The lines (aiofiles/os.py) of aiofiles in version 0.5.0 (Notice the @asyncio.coroutine):
def wrap(func):
    @asyncio.coroutine
    @wraps(func)
    def run(*args, loop=None, executor=None, **kwargs):

The lines (aiofiles/os.py) of aiofiles in version 0.7.0 (Notice the async def):
def wrap(func):
    @wraps(func)
    async def run(*args, loop=None, executor=None, **kwargs):

Is there a reason why this PR is not merged yet? If any more work is needed, I'd be happy to jump in.

In the meantime version 0.7.0 has been released. I recommend upgrading againt.

@wavenator The version of aiofiles has been increased to 0.7.0. Thank you for the recommendation.

All reviewers have approved this pullreq.  What's blocking the workflows?

@hongqn, A maintainer (@tiangolo) needs to approve workflows and/or merge the pull request.

I came looking to open this PR today, good to see some activity. I can pitch in the changelog from aiofiles, from here.
https://github.com/Tinche/aiofiles/blob/aea353ebdd2771f2e4ae934077eceb12daaa3481/README.rst#L174-L189

Thanks @zevisert!

Thanks for your contribution @SnkSynthesis! :cake:
And thanks for the discussion everyone, in particular @zevisert for all the investigation and report. :detective:
I updated the range required to also include 0.5.0 as it still works, there's no need to force everyone to upgrade to the most recent one (and to avoid any possible conflicts with other packages depending on aiofiles).
On the other hand, just as a note, I'll soon upgrade to the latest Starlette, based on anyio, which provides the same functionality, so aiofiles will no longer be needed. :tada:
I'm making a release with these changes first just in case that's useful in the transition for anyone.


Revamp the conda/schemas repository

Note: I was going to post this in conda/schemas directly but I can't tag the steering team from there, hence the issue here.

We have a few CEPs coming up (see #51 #8 #50) where it has been suggested that we document the proposed standards with an accompanying JSON schema in the conda/schemas repo.
As I start writing some of these schemas down, I will be using pydantic to write reusable models that can auto export JSON documents. I wonder if there's an interest in doing this retroactively for existing models that have not been standardized yet, so if this catches up, I'd like to propose the following repository structure:

examples/: Real-life examples of the documented file types, that can be used in test suites if necessary.
schemas/: Publishable JSON schema documents.
models/: Python scripts that generate JSON schemas into schemas/. Most likely using pydantic.
scripts/: Other helper utilities (e.g. refresh all JSON schemas from their models, publish to a HTML tree, etc).
tests/: Automations to make sure the proposed models actually implement the existing "standards" (as in examples/), but also reject non-compliant files (e.g. extra keys due to typos).

Eventually I can foresee how the models directory becomes a collection of well structured modules with no extra dependencies (other than Pydantic) that would be best served as an importable Python package. Downstream packages (maybe including conda!) could benefit from using these models to transparently add typing their code paths, or at least compare their custom implementations to accepted community standards in their test suites.
I'd love to hear thoughts from @conda-incubator/steering! Thanks!

👍 Good idea!

I noticed that the .condarc file is not currently listed in the https://github.com/conda/schemas repositories, but if you would like to add that too, I have actually already done a lot of the work. You can check it out here:

https://github.com/travishathaway/conda-config/blob/6b41c7d378428358d79d8663ee64bb3581296f18/conda_config/condarc.py#L119

Lol I was just tagging you in the PR. Thanks for the tip!

For reference, Microsoft seems to have some schemas for conda here too: microsoft/vscode-python@main/schemas

😬


Modifications to files below ignored directories are not being ignored on OSX

With the latest version of chokidar I am noticing that modifications to files below an ignored directory are not being ignored. I'm not sure why your test cases aren't catching the problem, but I created a really simple project that you can test with to easily reproduce the problem on OSX:
https://github.com/patrick-steele-idem/chokidar-bug/
I also tested with the latest code on master and I am seeing the same problem. If I switch back to the pre-1.0 version of chokidar the problem does not exist.
Please let me know if you need more details. Thank you for looking into this problem!

Haven't tried to run it yet, but I think I see what's happening in reviewing your code. Your ignore definition is very specific to the directory itself, as opposed to being defined as a regex or glob that would match on all the directory's contents.
The directory's path is being filtered out by the initial readdirp scan, so it's never tested against your ignored setting, so the code that ignores all children of an ignored dir does not kick in. If you were to create the directory after the watcher was instantiated (after the ready event), it would probably work as you expect.
So if all my assumptions are correct, then yes I agree it's a bug. But one that should be pretty easy to fix.

Thanks for the quick response @es128! I look forward to trying out the fix as soon as it is ready. I hope the project I shared makes things a little easier for you, but let me know if I can help in some way.
FYI, this bug broke the ignoring-watcher module that I use as the basis for various modules. That module uses .gitignore-style ignores that match directories (not individual files) so ignoring directories is important.

:+1:


Automated merging requirements met check remains stuck in queued for PRs that do not modify specs because SDK automation is skipped

If only Automated merging requirements met check is stuck in queued and other checks have finished:
Be aware that Automated merging requirements met check will remain in queued state as long as not all checks marked as required have finished. This includes situation when a required check did not finish because it was skipped.
Notably, this may happen for PRs that do not modify any specs, like e.g. specs PR 29296, because SDK Automation will conclude it has no work to do and the required check SDK azure-sdk-for-go will be skipped:

Note to self: I need to try to repro it, e.g. by editing PR dsecription template file.

OK looks like I misdiagnosed the problem. Here is a counter-example where the SDK check was skipped but the All automated merging requirements met check has succeeded:

https://github.com/Azure/azure-rest-api-specs/pull/29615


Enhancements

I think the new enhancements I made on your awesome plugin will be of help to others and is good to have in your plugin.
note: all the changes are backward compatible. I also wrote about the changes in the commit messages if you want to know what they are.

Sorry, but there is a big gap in the versions. Could you kindly merge your suggestions in the new release, please?


Update Unit Tests for RuleSet to include new dunder methods

Need to update the tests for RuleSet to include tests for __getitem__, __len__, __iter__, __missing__ methods

Complete


generate a python ndarray as a matrix containing all the Clebsch-Gordan coefficients for a given spin state

Implemented in this commit.


Add option to Verification page dropdown menu

On the Verification page, add an option to the "Verification Scope" field dropdown menu. This option is called "Emissions report"
For context

Reporting operations are not part of OBPS so if users see the option "BC OBPS annual report", they will be confused. That's why we need to create a new dropdown option just for them called "Emissions report"
Decision recorded here

@patriciarussellCAS tagging for your visibility of this new ticket!

Thanks @zoeyli-46 - I like this as a solution. I do wonder (now that I see it) if this will add confusion to Regulated Operations. Let's chat about this when we have a minute.

For certain. We could also call it "Emissions report (non-regulated operations)"


187 fix nested async bug with uniprot query

Codecov Report

Merging #188 (e895ec0) into main (a3081d3) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   69.91%   69.91%
=======================================
  Files          61       61
  Lines        2646     2646
=======================================
  Hits         1850     1850
  Misses        796      796


Issues on coreos and kubernetes versions

Hi, apparently the old patched tag for snap-plugin-collector-docker is not working anymore, it doesn't collect any data anymore, i tested the 9th tag from intelsdi-x and it did push data into my graphite deployment.
Is there a chance you could patch up the new tag to contain the namespace fixes? (the fs fix is already included in the release).
(I took an attempt for a fix, as you can see, but i can't manage to build a version that runs well)
Thanks in advanced.

The snap-plugin-collector-docker is a bit of a sad story. It got refactored and the new version from intel uses a ton of memory which makes it unusable for us. We are planning to replace it with cAdvisor and I think one of the guys on the Grafana Labs - Hosted Metrics team is going to start on it this week.


Detector runs slow on Nvidia board

The detector code seems to run pretty slow on the Nvidia board. The solution is to port the code to use the CUDA cores on the board. This might need a rebuild of OpenCV however.

We did some timing tests and we noticed that the total processing time for each detector loop is around 30 milliseconds, which is much lower than what we're seeing.


Add "sec_fraction" (fraction part) to "seconds" (epohc second) in parsing timestamps: Fix #1033

Details are discussed in #1033.
Can you have a look? @sakama @kamatama41 Cc: @hiroyuki-sato

Hello, @dmikurube
Thank for fixing an issue.
The test-scripts worked well. Thank you!.
example
embulk-0.9.8-SNAPSHOT.jar preview conf.yml
2018-09-11 15:32:58.061 +0900: Embulk v0.9.8-SNAPSHOT
+-----------------+-----------------------------+------------+-------------+
| key_name:string |               day:timestamp | value:long | name:string |
+-----------------+-----------------------------+------------+-------------+
|   2 new_clients | 2018-04-06 11:06:02.001 UTC |          1 |           a |
|   3 new_clients | 2018-04-06 11:06:03.001 UTC |          2 |           b |
|   4 new_clients | 2018-04-06 11:06:04.001 UTC |          3 |           c |
+-----------------+-----------------------------+------------+-------------+

Rebased from e43ed7db3c0ac72c68bc58197e2c90dede137740 to fix typo in the commit message, and then fixed cases of negative epoch seconds. Jfyi: @kamatama41

Thanks!

big thanks to the team!


Switch to C99 printf macros

Switch to C99 printf macros defined in inttypes.h (i.e. PRIu8, PRIu16, PRIu32, PRId32, PRId64) to avoid compilation warning with gcc.

Thank you Olivier and please be careful with the generated C code. Work in progress. The error handling is not done yet.


No source dependencies

cpp_polyfills was released into rolling and humble. This removes the repos file for source dependencies, removes upstream workspace from docker, and updates CI.

Closing in favor of one pushed into branch on this repo so I can kick of docker builds from it.


Improvements to job type

This implements the method as mentioned in the comments previously in the type to return all the jobs in one go.
It also adds support for printing a checksum of the config change, and a diff.

@damoxc It's fantastic to see someone working on the new types!  Are you willing to take a stab at rspec tests?

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jhoblitt Gladly! If I don't get time to look over the weekend then I'll have a look on Monday. Would you like the git history rewritten to include less of my experimentation? Could probably squash it down into a single commit realistically.

@damoxc I'm pretty aggressive about squashing in my own workflow, so that a commit is more or less a single feature or bugfix.  Doing so makes it a bit easier to track down the rational for a change with git blame.  That said, it is certainly not a requirement for getting a PR into this module, unless there was something like revert commits or tons of "fix typo" commits (in such cases, the maintainer will often fixup the PR anyways).
TL;DR -- appreciated by not mandated

@jhoblitt  I'll add the rspec tests and rebase into a single commit, or perhaps two (one for the helper, one for checksums/diffs). There's far too much mess I in this I wouldn't want to pollute the mainline repo with.

@damoxc I've been using git's rebase.autosquash=true feature since around the start of the calendar year, after a particularly ugly squash/re-split session.  This lets me throw in a fixup! <original title> or squash! <original title> while I'm working without having to squash changes I'm unsure of but also makes it easy to squash down the branch in something suitable of merge.  It's a bit of extra work but I think the reward is worth it -- might be worth a try if you haven't experimented with it before.

@jhoblitt I haven't tried autosquash yet, I've always just used rebase -i, although I'll look into autosquash now I'm aware of it, cheers.

@damoxc ping

@jhoblitt Sorry, had a bit of a hectic week last week (job + travels). I started hacking on the rspec tests but going to have to do some more learning around how to test the config property properly, hopefully have some time at the start of this week if all goes well.

@damoxc ping I would really like to see this go in.  I actually got a few lines into implementing a show_diff before I remember it was already in this PR.

@jhoblitt I had a look yesterday and I'm actually struggling to get the spec tests to run, are there any expected conditions and the environment for them to function?  Current error is
Could not autoload puppet/type/user: Could not autoload puppet/provider/user/openbsd: loginclass is not a valid attribute for user on node ***
# ./spec/classes/jenkins_slave_spec.rb:83:in `block (3 levels) in <top (required)>'

@damoxc That is an odd error.  Are you running the tests on openbsd?

@jhoblitt No, it's on Arch. It goes away if I use Puppet 4.X but then that brings its own slew of issues :smile:

@damoxc Are all of your changes pushed?  I've just run into problem (#541) that this should essentially fix.  I am planning to try to deal with this tomorrow morning.

@jhoblitt all my changes are pushed at the moment, that I can see at least.

@damoxc I have a working branch but I need to clean it up before merging.

@damoxc I have opened PR #544, which consists of this PR + fixes.  I squashed your history and my fixes/refactoring down to a single commit each, so it should be easy to see what changes were required to get this working.
My best guess at this point as to the source of the odd error message you saw, is that it were caused by a puppet methods invoked by your changes that needed to be stubbed out for unit testing.
Thanks for all your hard work!


fix for extractAvroPaths traversal of arrays within union

fixes issue #435 - extractAvroPaths does not traverses arrays
with the '[]' notation when array is part of a union

Thanks for the contribution! I committed a fix that pinpoints the issue a bit more precisely, here: https://github.com/kite-sdk/kite/commit/50781c4ddca9763304119185d6caf86f6b1f6ef1


SOLR-15243: Update MoreLikeThis docs

This PR makes major revisions to morelikethis.adoc:

examples of how to configure each option
examples/explanation of the output of each MLT approach
default values for all parameters are provided (using a new approach I first introduced in solr-tracing.adoc change 2f45a31fbd0c5f46b9fa1431bb374cc24d43076a) - this needs validation from someone who knows the code
reorganization of sections
moved MLTQParser docs to morelikethis.adoc leaving a link to new location in other-parsers.adoc

Still waiting here for someone to confirm if what I think I found in the code for defaults for the parameters is correct if anyone has a moment....


Unable to install

While adding package nate-strauser:select2:
error: no such package
I was able to install with meteor add natestrauser:select2

I saw this, too.  Does meteor add<EMAIL_ADDRESS>work?

fixed!
can just do meteor add natestrauser:select2


Index reported as Extra in Database, but it is also in the model.

Hi, I am using SQL Server, and I am getting the following errors.
EXTRA IN DATABASE: Index 'AuthorityStandards', index constraint name. Found = IX_AuthorityStandards_ExtId
EXTRA IN DATABASE: Index 'AuthorityStandards', index constraint name. Found = IX_AuthorityStandards_GradeLevelId
EXTRA IN DATABASE: Index 'AuthorityStandards', index constraint name. Found = IX_AuthorityStandards_SubjectId
EXTRA IN DATABASE: Index 'AuthorityStandards', index constraint name. Found = IX_AuthorityStandards_AuthorityId_SubjectId_GradeLevelId_Name_YearAdopted

My entity class is decorated accordingly

The GradeLevelId and SubjectId are there because they are FK to another table.

As I was writing this bug report I thought that maybe this had to do with another bug report I created earlier.
Errors when using JSON columns
Since the error in both bug reports happen to be in tables where both have a JSON column. So I went ahead and removed the JSON column with a migration from this table AuthorityStandards and the error reported above went away! In other words these errors are reported only when there is a JSON column present in the table.
I hope this helps

I have a similar issue when I use a value object. I have simplified my project and recreated this issue here. I subsequently created another branch which removed the ShippingAddress field off of the Order entity here.

Hi @urielzen,
Do try version 8.1.0, which supports Json Mapping, and close this if it works. Thanks.


Theme names should not be case-sensitive

@secrettriangle if you are referring to the theme name in the URL, I have created a pull request with a fix for the same.

For reference, uppercase is not allowed in NPM package names https://github.com/npm/npm-www/pull/410#issuecomment-27717029

@mchelen yes, that is correct. We cannot have those using jsonresume to provide the theme names in small case letters, simply because they do not or need not care where the server is running or what/how it shows the ouput.
Thoughts?

If NPM dose not allow uppercase published theme names, then this will never been an issue for us.