Fix: Replace sqllineage with openmetadata-sqllineage

Describe your changes :
I have updated the sqllineage used until now with openmetadata-sqllineage, which adds an option to extract lineage by using sqlfluff as the parser and considers the dialect of the query. Since it is a recent change, we will use the sqlfluff parser option as a fallback for the usual lineage extraction.
In addition, the LineageParser now supports the dialect parameter to use sqllineage with sqlfluff.
Type of change :

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
Ingestion: @open-metadata/ingestion

Hello @nahuelverdugo . How are we publishing the openmetadata-sqllineage python package ? Is that something we need to do for every release ? Can you please share some details for the same here. Thanks.

Hello @nahuelverdugo . How are we publishing the openmetadata-sqllineage python package ? Is that something we need to do for every release ? Can you please share some details for the same here. Thanks.

We have created a repo for that https://github.com/open-metadata/openmetadata-sqllineage, and there is an action that releases when a release is created. It is a fork of the sqllineage library that we did to start testing a change done in the used parser for the queries. We don't need to do it on each release, and we hope the repo is temporary until we merge https://github.com/reata/sqllineage/pull/326.


Midea AC filter cleaning sensor

Device type and model (or SN)
Midea AirConditioning
The description of new feature
Hi, now in Midea app it shows alerts when an AC requires the filter to be cleaned (after 250h of usage as standard), so it should be great if this sensor could be exposed to Home Assistant, so we create some automations when this sensor is trigged.
Thanks,
Leonardo

Is that from the new SmartHome app?
I've got a Dust Sensor in the current midea_ac_lan integration but have never seen it trigger.

Mine has a sensor exposed that says binary_sensor.165432605873987_full_dust and the entity state says 'problem' which I guess means dirty. This sensor flips to 'OK' state about every 2 mins then back to 'problem' state. Clearing the notification at the top of the smarthome app doesnt seem to get the binary sensor to change to OK in a stateful manor. Something is wrong.


ContentType checking

As expected out server returns the content type as application/json, this breaks the validation as you are looking for application/schema+json. I could update the server, but then all .json files will have the schema type.
Is there a way to override the default expected content type?
As I understand it there is no proposed extension for json schema files and a single extension can have two content types. This make this validation a little harsh.
Thank you
Guy

Perhaps a filename convention will help?
Something like "foo.schema.json" would make it clear for developers and server configurations to determine that file contains a schema and should be handled accordingly.
What is the exact issue you are having? Is there some code you are running that is having problems?

Yes I could name our schema something like foo.schema.json and update nginx to set the content type for this extension to "application/schema+json".
However not everyone will be able to change the contentType on the server. If the contentType is wrong when loading a schema by http:// or https:// the schema gets rejected with "Media type application/schema+json expected". This validation cant be ignored.
See file: /src/JsonSchema/Uri/UriRetriever.php
Line: 54
Exception thrown line 63 if line 54 fails.

@guyradford thoughts? https://github.com/justinrainbow/json-schema/pull/259

@bighappyface Yes that seems to make sense, I cant imagine the need for any other contentTypes, or making it user defineable. So would work perfectly.

@guyradford please update to 2.0.1 and let me know if your issues are resolved.

@bighappyface,  Yes that works perfectly, Thank you.


remove locktime

remove locktime for now
(will maybe be added back in some form: https://www.pivotaltracker.com/story/show/152484155)

"lock_time_block" at the moment this variable is located in "SpendTx," the role it occupies is to "lock" a transaction in order to avoid the forking. What other mechanism will we provide to deal with this problem ?

@rdimitrovbg I don't understand what you mean with avoiding forks? We remove it for now, but it will be added back later in one form or another, as described in the referenced ticket.
@DanielaIvanova yes

@thepiwo I'm sorry, my mistake. What I meant was to prevent from double spending not  ... avoid forks.

Still, I don't get it. Can you describe what double spend problems you see?

@rdimitrovbg ?

@DanielaIvanova @rdimitrovbg what is the state of this? - if finished PR it

@thepiwo
Apologies.
I was looking for opinions and suggestions.
I understand the idea of lock_time_block in the following way.
The Lock_time_block locks the transactions in a block for a certain time.
The time needed for the network to "refresh".
Time as a guarantee that transactions are legit.
^^^( there is a need for a "chain" longer at least  n blocks "where 'n' is lock_time_block = value" )
We know the longest "chain" wins.
By reducing this difficulty (lock_time_block) opens the possibility for more frequent meetings of "chains" at a lower priority.
And I thought.
Do we get a lot forks and pandora of transaction scenarios ? (And may be the double spend)
Or my understand of lock_time_block is not right.

it can be used like this, but we only used it to lock coinbase rewards for some blocks, to minimize malicious usage of small forks.
As suggested in the task at the top, we will add it back sometime, but potentially with other specs.
https://www.pivotaltracker.com/story/show/152484155


Import semantics

Was looking at the proposals for adding protected name spaces & using stuff like: std: to prefix the standard libraries. Can it be done like so:
Why not consider this as a simple cache rather than something special:

Libraries that are white listed gets cached.
When a new site requests it, it is served from the cache than downloading it.
If not available it will download from npm server or cdn or else from the website itself

With async modules, the preprocessors will start splitting bundles for this.
Advantages:

There is nothing special in importing it, if it isn't available in the cache it gets downloaded. Just ordinary memoization.
It will work in browsers that doesn't support it without any changes
Maintaining whitelist is much simpler, and browsers can differ in opinion what to contain in their list. This will reduce a lot of decision time.
Users can also have control over the whitelist, they can add or delete stuff from it
Browser can offer to add packages based on browsing patterns
This would be a simple "make available offline" if website bundles are added to the whitelist

Disadvantages

Dependency on npm/cdns in a standard solution

This seems related to #18.
I had a similar idea back in 2009.
I think there are concerns about hash collisions and other related security issues. See the above issue for more information.


High number of java.getPackageData calls when opening a java file

When opening the GreetingResource.java file of a quarkus project, I see java.getPackageData being called 8 times. That seems suboptimal:
[Info  - 10:24:43 AM] 4-Feb-2020 10:24:43 AM >> document/didOpen
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> document/codeAction
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand java.maven.initializeSearcher
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand java.resolvePath
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> document/documentSymbol
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> document/foldingRange
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand vscode.java.test.search.codelens
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand vscode.java.resolveMainMethod
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> document/codeAction
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand java.maven.initializeSearcher
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand microprofile/java/codeLens
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> document/foldingRange
[Info  - 10:24:44 AM] 4-Feb-2020 10:24:44 AM >> workspace/executeCommand java.project.list
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM Reconciled 0. Took 890 ms
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM Starting com.microsoft.java.debug.plugin
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:46 AM] 4-Feb-2020 10:24:46 AM >> workspace/executeCommand java.getPackageData
[Info  - 10:24:47 AM] 4-Feb-2020 10:24:47 AM begin problem for /GreetingResource.java
[Info  - 10:24:47 AM] 4-Feb-2020 10:24:47 AM 0 problems reported for /GreetingResource.java
[Info  - 10:24:47 AM] 4-Feb-2020 10:24:47 AM Validated 1. Took 472 ms

Seems like the dependencies view is making calls even though it's not open

Any plans for fixing this in the short term?

Hi @fbricon, I'll make sure this bug got fixed in the next sprint(start from next week).

Hi @fbricon,
TL;DR
After some investigation, the 8 times java.getPackageData invocations are caused by the feature: synchronize dependency viewer selection with folder explorer. It should not be a bug but by design.
Root Cause:

By default, the dependency explorer will automatically sync on event changeActiveEditor, which means, changing the active editor will cause the explorer expand some nodes and switch focus to the certain node.
To expand and focus to a certain nodes, the extension will call java.getPackageData several times to get data from different levels. Given a typical project like springboot-petclinic, the 8 times calls are:

1 call from the project level to get all containers
5 calls from different source container level to get the package roots.

src/main/java
src/main/resource
src/test/java
target/generated-sources/annotations
target/generated-test-sources/test-annotations

1 call from the package root level to get all packages
1 call from the package level to get all classes.

The results of the 8 calls will be cached unless the file opened by users belongs to an un-opened node in explorer.
Follow up
I think the problem here is that the method name java.getPackageData is misleading, since some of the invocations are not getting package data. A better name could be java.getNodeData

But again, one of my main gripes is it the dependencies view is making calls even though it's not open

@fbricon, hmm, yes that's a valid concern. We should add the check for this._dependencyViewer.visible here: https://github.com/microsoft/vscode-java-dependency/blob/master/src/views/dependencyExplorer.ts#L25


Add markdown extension

Fixes #91

Hi @ia3andy, this is the first draft, to see if I am on the right path

This looks good right @mkouba ?

Could you add this test:

some html

{#md}
# Hello markdown

Here is a list:
{#for item in items}
* an {item} as a list
{/for}

some {html} in the markdown
{/md}

Could you add this test:

some html

{#md}
# Hello markdown

Here is a list:
{#for item in items}
* an {item} as a list
{/for}

some {html} in the markdown
{/md}

Probably this one will fail 😆

Thank you for all your comments, I will take a look here

Hi @mkouba and @ia3andy, actually when we are using this one:

Quarkus and Qute

  {#md}
  # Qute and Roq
  Here is a list:
  {#for item in items}
  - an {item} as a list item
  {/for}
  {/md}

We are getting:

Quarkus and Qute

Qute and Roq

Here is a list:

an

apple

as a list item

an

banana

as a list item

an

cherry

as a list item

I think that the expected behavior is:

Resolver{#for}
Resolve {#md} with {#for}

In other words, resolve all sections inside markdown first. I am new with qute API, do you have in mindo how to solve this one?

In other words, resolve all sections inside the markdown first. I am new to qute API, do you know how to solve this one?

@mcruzdev  Your code looks good. I think there's some problem with line separators or something like that. What does the content passed to the MarkdownConverter look like?

Ah, I see where the problem is. You need to first collect all the results and then apply the converter.

By the way, you don't need a QuarkusUnitTest to test the functionality of the section itself. A simple unit test would be enough:
public class MdTest {
    @Test
    public void testMd() {
        Engine engine = Engine.builder().addDefaults()
                .addSectionHelper(new MarkdownSectionHelper.Factory(new CommonMarkConverter())).build();
        assertEquals("...", engine.parse("{#md}...{/md}").data("items", List.of("apple", "pie")).render());
    }
}

@mkouba good?

@mcruzdev Could you pls squash the commits? I'll merge the PR afterwards...


Elements are in wrong position on a 're-render' caused by unfiltering a filtered array

I am displaying my masonry tiles from a filtered array.
var myFilteredArray = myArray.filter( (tile) => this.props.filter.indexOf(tile.tag) > -1 )
var tiles = myFilteredArray.map( (tile) => <MyTile/>)

Where myArray is an array of json objects with a tag field. props.filter is an array of strings.
For exampleprops.filter =  ["a","b","c"]  and the json tags are "a", "b", "c"
When I update my props filter so that props.filter = ["b"]
I see that the A and C objects disappear and object B moves to the left most of the container.
However when I add back tags "a" and "c" into props.filter, the objects show up in the wrong position.
I would expect that the objects be in the order A,B,C, and filling up the container from the left most. What I see however is that object B goes back to where it was originally, and A, and C show up either on top of it or to the right of is. That means there is a big empty space to the left of Object B
My question is why is this happening? And how do I fix this?

Looks like this is related to https://github.com/eiriklv/react-masonry-component/issues/11.


Remove kv-namespace-worker

This commit removes the namespace kv worker and related code, now that
we talk over gRPC to the server, and not directly to the DB, we should
not need this anymore.
Basically, I think this should be safe now, but not sure, let's see what the tests say. What do you think @juanfont

[x] read the CONTRIBUTING guidelines
[x] added unit tests
[x] added integration tests
[x] updated documentation if needed
[x] updated CHANGELOG.md

Merging this as I believe it's safe, but we can keep in mind if weird things happen


[Feature] Aircraft wear & Maintenence

I came to an idea to add Aircraft Status when creating new aircraft (Status: 0-100%) which will show wear of an aircraft after every flight. After the flight is completed system would reduce status number by certain factor and once when it falls bellow 70% (or any percentage) the plane changes status from Active to Maintenence and is not available for flying.
This could also be connected to Landing Rate and if someone landed with landing rate greater then predefined value it should send aircraft to the hangar for maintenence.
If it is possible in Admin pannel there should be an option to predefine values for what is considered a crash landing and at what point aircraft should be sent to hangar for maintenence.

Dupe of #758, can you add this information into there, please?


Additional color information

For the parts lists it would be nice to have color information from all currently used technologies (LDD, Bricklink, Official LEGO, rebrickable)

BrickLink, official LEGO are currently available, while Rebrickable uses its own system and is not required in any existing use case.


fix(toggle-scrolling): fix conflicts between popper package and global toggle util and improvements

improve global util toggle functionality for scroll on body + fix conflicts with popper package + close main nav on orientation change + improve height calculations

Acceptance Criteria

[ ] Design Review by @Gagne87, @clastzoo
[ ] Technical Review by @hirsch88, @mladenplaninicic, @nobilo
Browser Testing by @hirsch88, @nobilo, @mladenplaninicic, @Gagne87, @clastzoo

Desktop

[ ] Chrome
[ ] Edge
[ ] Safari
[ ] Firefox

Mobile

[ ] Safari iOS
[ ] Chrome Preview


[Release-1.28] - Support containerd config_path for stargz snapshotter

Backport fix for Support containerd config_path for stargz snapshotter

#9976

Validated on release-1.28 branch with commit 9d5becb2
Testing
Followed the steps mentioned here: https://github.com/k3s-io/k3s/issues/9976#issuecomment-2150792687
Validation:
k3s -v
k3s version v1.28.10+k3s-9d5becb2 (9d5becb2)
go version go1.21.9

$ sudo cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml
# File generated by k3s. DO NOT EDIT. Use config.toml.tmpl instead.
version = 2

[plugins."io.containerd.internal.v1.opt"]
  path = "/var/lib/rancher/k3s/agent/containerd"
[plugins."io.containerd.grpc.v1.cri"]
  stream_server_address = "<IP_ADDRESS>"
  stream_server_port = "10010"
  enable_selinux = false
  enable_unprivileged_ports = true
  enable_unprivileged_icmp = true
  sandbox_image = "rancher/mirrored-pause:3.6"

[plugins."io.containerd.grpc.v1.cri".containerd]
  snapshotter = "stargz"
  disable_snapshot_annotations = false

[plugins."io.containerd.snapshotter.v1.stargz"]
cri_keychain_image_service_path = "/run/containerd-stargz-grpc/containerd-stargz-grpc.sock"
[plugins."io.containerd.snapshotter.v1.stargz".cri_keychain]
enable_keychain = true

[plugins."io.containerd.snapshotter.v1.stargz".registry]
  config_path = "/var/lib/rancher/k3s/agent/etc/containerd/certs.d"
...


Add Hd to README

Can you add a v1.2 line something like below in the Changelog to this PR, just for completeness (and credit to you!) - and I'll merge it. Thanks again for your commits!
* 1.2 - Support for converting from HTML entities to Unicode character (thanks to [Jay](https://github.com/jsit))

All set, I used slightly different text (and I don't like polluting READMEs with credits to myself 🙃)


BUG - You cant edit serialized fields in inspector when having one SerializedCallback

I have the following elements elements in my inspector but I cant edit them, I had to remove the serialized callback, assign the things and then add it because I cant edit them anymore.

I have the same one. I commented 27 line "property.serializedObject.Update();" in "SerializableCallbackDrawer", now it seems to work properly.

Are you getting any errors in console?

Are you getting any errors in console?

There are no errors after or before commenting 27 line.

I found the problem and fixed it.
All the serialized fields above of SerializedCallback will not be applied.
It caused by the Editor doesn't apply modified properties.
You can add the script "property.serializedObject.ApplyModifiedProperties();" on  the first line of  OnGUI in SerializableCallbackDrawer.


Add sell & buy functions to Exchange.sol, deprecate exchange function

Description

Adds function buy(uint256 buyAmount, uint256 maxSellAmount, bool buyGold)
Adds function sell(uint256 sellAmount, uint256 minBuyAmount, bool sellGold)
Deprecates function exchange(uint256 sellAmount, uint256 minBuyAmount, bool sellGold) which has the same functionality as sell
Runs same suite of tests for sell and exchange
Adds tests for buy

Other changes
n/a
Tested
Ran tests
Related issues
Related CIP: https://github.com/celo-org/celo-proposals/pull/26
Backwards compatibility
Fully compatible

Do we need to update the version of this contract?
https://github.com/celo-org/celo-monorepo/blob/d0d8e1d6849c8a620ea714ac634e97721cd800c9/packages/protocol/contracts/stability/Exchange.sol#L66-L68

In retrospect I don't think the version number needs bumping since it's already been bumped to <IP_ADDRESS> since the last release

Thanks @asaj and @m-chrzan! I'm holding off on the gold -> CELO rename for now, I just made a thread in #eng-contracts to discuss it a little bit


Edit function

Since I communicate regularly in three languages, I have auto-correct turned off on my phone. This results in  typos, which I have to fix through the web browser. It would be great if this was possible through the app.

Sounds good. As far as I know that would be a unique feature among Hacker News apps. :)
As with other interactive actions, such as upvoting and replying, the official API does not provide support for this. We'd have to send a POST request to the website at the /xedit endpoint with our credentials, an ID and the updated text. One complicating factor is that posts are only editable for an undocumented period of around two hours. The app has no way of knowing for certain whether something is still editable, and I'm not even sure the server will respond with a sane error code if we submit an edit after this moment has passed. I guess we'd have to show some kind of warning that edits may fail for this reason.
Open questions:

[ ] What's the server response on an invalid /xedit call?
[ ] Can we only edit comments, or submissions as well? How do we handle URL submissions, or, dare I say it, polls even?

This has been implemented as part of 00d9adb8d36b056a535c67ba32cdda48a6c4504c and should be available in the next release.


How to set default value when key is not present in translation file?

Hi,
I'm using Angular 2.0.0,
My problem is how to set default value when key is not present in translation file, it means the friendly value (eg. "No Key in DB") can be shown if the key not found.
Thanks.

Hi,
at the moment, if the value of the translation is not present, the same key is returned (#1).
I think we have to define a strategy. If you need to handle missing keys:

for development
for production

In development, we could set a property to display a friendly value, or logging in console missing keys.
For production? I think we need to show or the same key, or an empty field.
What do you think about it?

Agree with you. In my project, customer require display "No Key in DB" if no key found for production, because of they want to know which key don't config in resource file in the first time.

At this point, I plan to add a property to set or with the same key or with a message, and I will let to the developer the responsibility to change it depending on the environment.

Hi,
I added a commit that should solve your problem.
By default, if a key is not present in the json, the same key is returned.
When you initialize the LocalizationService, you can set a friendly value to use for these keys:
localization.translationProvider('./resources/locale-');
localization.setMissingValue("No key");

Alternatively, you can set a key to use for the missing keys, so that even this is translated:
localization.translationProvider('./resources/locale-');
localization.setMissingKey("MISSING");

and in the json:
{
    "MISSING": "No key",
    ...
}

If you want to test it, follow the instruction to build the library in the README.
This week I should release the new version of the library, along with the next version of Angular.
Let me know.
Greetings

Many thanks, it's big help for me.

Hi,
I released the new version that implements this feature.
Greetings

Sorry reply later, work fine for new version, thanks for your support.


test/rpcs

feat(rls relation): Add RLS to relation
test(rls relation): Add small test to prove it

:tada: This PR is included in version 1.3.0-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[$500] Android – Attachment – App flickering when uploading a long image to a conversation

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open New Expensify app
Log in with the account
Open any chat
On a conversation, click on the + button in the compose box
Upload long image to a conversation

Expected Result:
Preview of the image is displayed before uploading to the conversation
Actual Result:
App flickering when uploading a long image to a conversation in preview. Flashes on first boot
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/6b67556d-5092-4093-a749-5c3ec83a3dd2

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011d877180b69b96f5
Upwork Job ID:<PHONE_NUMBER>346445824
Last Price Increase: 2024-01-30

Reviewing tomorrow!

@ZhenjaHorbach Thanks for the proposal! The RCA feels a bit underdeveloped; I'm curious why onLoad is being called multiple times if it's only supposed to be called once. I also wonder if this is device specific?
@lanitochka17 Could you update/add which platforms this affects?

The issue is only reproducible on Android

Thanks for the extra detail! Happy to go with @ZhenjaHorbach's proposal here. The RCA seems correct that we're simply calling onLoad multiple times on Android (for some reason with different sizes), and the solution makes sense for that.
:ribbon::eyes::ribbon: C+ reviewed

@ZhenjaHorbach Thanks for flagging! Did you verify that the issue is fixed?


Review and feedback

hi, im testnet user you DEX almost perfect but there're some issue that i confused.
review: all is good on swap, earn and stake
issue: cannot remove LP
thanks
my wallet
0x7afc7a6CF727308CB211E2396088041F33C60e11

@kulicrypto
We have fixed the issues in regarding to removing the removing staked Liquidity. Thank you for your testing and we hope to deliver high quality improvements!


Fail jobs on OOM errors

Right now, creating a dummy job that just consumes memory, the job fails with an OOM error, but it stays on the queue forever. It's never marked as failed and never released.
This adds a shutdown handler that will mark the job as failed on OOM errors.
Without this, jobs that fail because of high memory usage all stay on the queue and accumulate there. If enough of them have accumulated, the workers keep spinning on jobs that can never go through preventing any other jobs from being worked on.
This now works similarly to what would happen on job timeouts.
This isn't the final PR, but I wanted to gauge interest in adding this before making a more complete PR.

We should add some comments around the new code, it is handling a special case.

I think we would need tests for this, and I don't think we should register a shutdown function from the Worker class - only from the queue:work Artisan command potentially.


Project Week 1 Review Ticket Hacks

[x] Link to group video

A main feature of site, IMO, would be to build the Calendar from backend data.  This is an important step even before you have many Editing features.  On planning, it seemed like Scrum board was mostly empty.   In discussion of Backend and Frontend, it seemed that think how one impact or works with the other has not be though out in depth.  I would suggest looking at https://calendly.com/ and thinking more about how you will get a couple of features to work. 4.4/5


calibration multicamera's

D415
Yesterday the webinar talked about calibration software for mulicamera setup.
But I could not find the software.
Where can I find this software?
Best Regards,
Martijn Kusters

The tool mentioned in the webinar is called Vicalib.
https://github.com/arpg/vicalib

Can Vicalib be used to calibrate multiple real sense camera pose relative to each other. Can someone please guide me in that direction on how to use Vicalib for the same. It would be very helpful.


Smooth loss input is not right

I read the rouce paper and found, the correct input should be deformation_matrix or not registered_image in Sommth_loss. Maybe i was wrong, can you tell me why input was registered_image in there.
thank you every much for your job, it's very useful for my regis work.

I have the same quession, the input of Smoothloss is flow field, not the registration image


[FINDINGS] Flashed the zip on MagiskOnWSA

Just out of curiosity I flashed the magisk module on my newly installed MagiskOnWSA from https://github.com/LSPosed/MagiskOnWSA
To my surprise, the Google photos app detected WSA as Pixel 5 with Unlimited Storage Saver Quality.
Sharing cause thought this was interesting.
Also off-topic but is there a way to set the device model as Pixel 2016 instead of Pixel 5?

Update: Uploads photos and videos just fine. Without any problems.


Add ParametricGeometry and fix the import in ParametricGeometries

Why
With three@144 the import for ParametricGeometry seems to break. This causes components like Drei's OrbitControls to break and other issues. See issue https://github.com/pmndrs/three-stdlib/issues/178 and https://github.com/pmndrs/drei/issues/1029.

What
Fix the import and add ParametricGeometry.

Checklist

[x] Ready to be merged

Sorry, didn't see this in time. Have a fix with #180.


LuckPerms Thread Dump

https://pastebin.com/cgt24r2f
I start getting this errors when I use LagAssist plugin. (Starts at 17:06).
2020-11-24-3.log

You're using an outdated version of the plugin, and have ignored the issue template.


Test cloud pkg

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
It test the cloud pkg and adds testing utils.

Should be merged into the refactoring branch


Change default parameters for back pressure and PG checkpoints

refer #1189

I am a bit worried that with these new limits backpressure won't be covered by our tests anymore.
So, maybe we can add some test that specifically covers backpressure?
I.e. set small values for lag parameters, perform writes and ensure that lag is within the limit using for example this query
select pid, pg_wal_lsn_diff(pg_current_wal_lsn(),sent_lsn) as pending_lag,
pg_wal_lsn_diff(pg_current_wal_lsn(),write_lsn) as write_lag,
pg_wal_lsn_diff(pg_current_wal_lsn(),flush_lsn) as flush_lag,
pg_wal_lsn_diff(pg_current_wal_lsn(),replay_lsn) as apply_lag
FROM pg_stat_get_wal_senders();

I don't feel comfortable changing wal_log_hints without some acknowledgment that the issues mentioned in https://github.com/zenithdb/zenith/issues/192 have been fixed. Meanwhile, the CI is currently failing because of the lack of backpressure, so it's pretty urgent to get the backpressure changes in quickly. So I opened https://github.com/zenithdb/zenith/pull/1239 with just the backpressure changes.

I don't feel comfortable changing wal_log_hints without some acknowledgment that the issues mentioned in #192 have been fixed. Meanwhile, the CI is currently failing because of the lack of backpressure, so it's pretty urgent to get the backpressure changes in quickly. So I opened #1239 with just the backpressure changes.

We are not force wal-logging of all evicted VM/FSM pages. So i theory #192 should not be a problem any more.
I repeated index-only-scan isolation test 100 times (with wal_log_hints=off) and there were no failures.

Addressed in https://github.com/zenithdb/zenith/issues/1189


Accessing external Python runtime

Hey! First off, thanks for developing this package :)
Without having looked in detail at the architecture and implementation, how flexible is the bridge to the external Python3.7 runtime via the Flask server?
To put it differently, is it possible to run any Python code snippet via that extension, in theory?
Also, have you tried accessing RevitAPI and/or RevitNodes via pythonnet (clr) in the external CPython?
I am asking, because I am interested in getting a smoother integration of modern python features into Dynamo, without rewriting the whole PythonScript Nodes that run on IronPython.
Thanks a lot! All the best,
Max

Hi @MaximilianFranz
Sorry for not responding sooner, didn't receive any notifications about you're message so just saw this now.
In theory you can run what ever python code you want using the extension, the only limitation right now is that you need to create a custom ZT node for every python snippet you want to run. Basically the ZT node sends a Json string to whatever falsk endpoint you specify and the Python code will execute using the Json as the functions argument.
I haven't done anything with the RevitAPI yet, if you have specific use cases i would be happy to look into it.


Added Two Player Chess Game with Features

@MrB141107
Hi,
Had a great time making my contribution to this repository.
Would love to contribute once again to this repository
So,
I am adding a Two Player Chess game with usual Chess features:

Checking each move to be Valid
Not allowing Invalid Moves
Castling
Pawn Promotion
En Passant Move
Nice UI

Feel Free to notify me of any issues.
Thanks and Regards,
Aditya Yedurkar

@MrB141107
In case you forgot to check this PR

@Aditya-y9, I heartily apologize for this delay


Feature/cplp 522/subscription status

@oyo can we do anything that this PRs are really just PRs for the respective topic...like in this case "Subscription Status".
I can see so many topics in this PR which are a complete different topic (like Feras his Stepper)

@oyo can we do anything that this PRs are really just PRs for the respective topic...like in this case "Subscription Status". I can see so many topics in this PR which are a complete different topic (like Feras his Stepper)

@jjeroch

@oyo can we do anything that this PRs are really just PRs for the respective topic...like in this case "Subscription Status". I can see so many topics in this PR which are a complete different topic (like Feras his Stepper)

@jjeroch - this was accidentially set to merge against main - what we intended to do only at the end of the sprint.  I changed that to dev now.


systray failed to start: Cannot read properties of undefined (reading 'items')

My project is just the example except that I had to make to constructor new SysTray.default
systray failed to start: Cannot read properties of undefined (reading 'items')
-snip-\node_modules\systray2\index.js:179
    if (item.items != null) {
             ^

TypeError: Cannot read properties of undefined (reading 'items')
    at addInternalId (C-snip-\node_modules\systray2\index.js:179:14)
    at -snip-\node_modules\systray2\index.js:301:87
    at Array.forEach (<anonymous>)
    at SysTray.<anonymous> (-snip-\node_modules\systray2\index.js:301:57)
    at step (-snip-\node_modules\systray2\index.js:52:23)
    at Object.next (-snip-\node_modules\systray2\index.js:33:53)
    at -snip-\node_modules\systray2\index.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (-snip-\node_modules\systray2\index.js:23:12)
    at C-snip-\node_modules\systray2\index.js:285:99

Process finished with exit code 1

{
  "name": "wallpapergarden-client",
  "main": "main.js",
  "type": "module",
  "scripts": {
    "start": "node ."
  },
  "dependencies": {
    "systray2": "^2.1.4"
  }
}

I cannot reproduce it. Can you share your project?

systray failed to start: input.on is not a function (node:29669) UnhandledPromiseRejectionWarning: TypeError: input.on is not a function     at new Interface (readline.js:189:11)     at Object.createInterface (readline.js:69:10)     at SysTray.<anonymous> (/Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:296:61)     at step (/Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:52:23)     at Object.next (/Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:33:53)     at /Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:27:71     at new Promise (<anonymous>)     at __awaiter (/Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:23:12)     at /Users/vimaldas/node-dev/aws-uploader/node_modules/systray2/index.js:285:99     at new Promise (<anonymous>) (node:29669) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3) (node:29669) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
I am on MacOS Catalina and just copied the code from the example

@vimal Are you running the program from a shell, which supports standard output stream?

I was running it through Webstorm on Windows, I deleted the project already. Could try to recreate it.


feature request: kill-paragraph

After using Emacs for 25 years, I'm switching to Atom. I've found your atomic-emacs to be indispensable, though one of the commands I find I'm missing is kill-paragraph. I noticed that I had it bound to a custom key in Emacs (so I don't know what the original key was, if any), but if you have a kill ring and forward-paragraph, it should be possible to combine them to emulate kill-paragraph, right?

Yes! It needs documenting (beyond the way-too-low-key changelog entry), but you can consume AtomicEmacs as a service and extend it. For example, you could add subword navigation like this:
init.coffee:
atom.workspace.packageManager.serviceHub.consume "atomic-emacs", "^0.13.0", (service) ->
  window.emacs = service

forwardSubword = (event) ->
  emacsEditor = emacs.getEditor(event)
  emacsEditor.moveEmacsCursors (emacsCursor) ->
    emacsCursor.skipNonWordCharactersForward()
    emacsCursor.cursor.moveToNextSubwordBoundary()

backwardSubword = (event) ->
  emacsEditor = emacs.getEditor(event)
  emacsEditor.moveEmacsCursors (emacsCursor) ->
    emacsCursor.skipNonWordCharactersBackward()
    emacsCursor.cursor.moveToPreviousSubwordBoundary()

atom.commands.add 'atom-text-editor', 'me:forward-subword', (event) -> forwardSubword(event)
atom.commands.add 'atom-text-editor', 'me:backward-subword', (event) -> backwardSubword(event)

keymap.cson:
'atom-text-editor':
  'ctrl-left': 'me:backward-subword'
  'ctrl-right': 'me:forward-subword'

You'll need to crawl the source for now to figure out what methods are available on an EmacsEditor and EmacsCursor, but hopefully it's pretty easy to follow.
As far as adding it to AtomicEmacs goes, I'd take a patch that added it if it supported multiple cursors like the other commands. Looks like GNU emacs doesn't ship with a key binding by default, so it'd be similarly unbound by default in AtomicEmacs.


Handle response codes as per the docs

Clients should handle response codes by distinguishing between client and server errors, and if there's a problem, informing their users about the kind of problem.

https://onionoo.torproject.org/protocol.html#general

Already handled by got


http_response_time_seconds metric not being exposed on v1.7.1

Describe the bug
Version 1.7.1 not exporting <namespace>_http_response_time_seconds_* metrics
To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Install nginx with below log format and below HCL configuration file, and check metrics exposed using http://localhost:4040/metrics
Expected behavior
A clear and concise description of what you expected to happen.
Curl request should expose required metrics.
Configuration file (remove section, if not applicable):
listen {
  port = 4040
  address = "<IP_ADDRESS>"
}

namespace "app1" {
  format = "$remote_addr - $remote_user [$time_local] \"$request\" $status $body_bytes_sent \"$http_referer\" \"$http_user_agent\" \"$http_x_forwarded_for\""
  source_files = ["/var/log/nginx/access.log"]
  labels {
    app = "app1"
    environment = "production"
  }
}

Example log file (remove section, if not applicable):
<IP_ADDRESS> - - [17/Nov/2021:07:50:54 +0000] "POST someuri/?EIO=3&transport=polling&t=<t>&sid=<session_id> HTTP/1.1" 500 483 "https://host/uri/" "Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [17/Nov/2021:07:50:57 +0000] "POST someuri/?EIO=3&transport=polling&t=<t>&sid=<session_id> HTTP/1.1" 200 28 "https://host/uri/" "Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [17/Nov/2021:07:50:57 +0000] "GET someuri/?EIO=3&transport=polling&t=<t>&sid=<session_id> HTTP/1.1" 500 1190 "https://host/uri/" "Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [17/Nov/2021:07:50:59 +0000] "GET someuri/?EIO=3&transport=polling&t=<t> HTTP/1.1" 200 137 "https://host/uri/" "Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [17/Nov/2021:07:51:00 +0000] "GET someuri/?EIO=3&transport=polling&t=<t>&sid=<session_id> HTTP/1.1" 200 64 "https://host/uri/" "Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36" "<IP_ADDRESS>"

Metrics output (remove section, if not applicable):
# HELP app1_http_response_count_total Amount of processed HTTP requests
# TYPE app1_http_response_count_total counter
app1_http_response_count_total{app="app1",environment="production",method="GET",status="101"} 7
app1_http_response_count_total{app="app1",environment="production",method="GET",status="200"} 59
app1_http_response_count_total{app="app1",environment="production",method="GET",status="429"} 1
app1_http_response_count_total{app="app1",environment="production",method="GET",status="499"} 4
app1_http_response_count_total{app="app1",environment="production",method="GET",status="500"} 27
app1_http_response_count_total{app="app1",environment="production",method="POST",status="200"} 25
app1_http_response_count_total{app="app1",environment="production",method="POST",status="500"} 30
# HELP app1_http_response_size_bytes Total amount of transferred bytes
# TYPE app1_http_response_size_bytes counter
app1_http_response_size_bytes{app="app1",environment="production",method="GET",status="101"} 114
app1_http_response_size_bytes{app="app1",environment="production",method="GET",status="200"} 6913
app1_http_response_size_bytes{app="app1",environment="production",method="GET",status="429"} 564
app1_http_response_size_bytes{app="app1",environment="production",method="GET",status="499"} 0
app1_http_response_size_bytes{app="app1",environment="production",method="GET",status="500"} 32130
app1_http_response_size_bytes{app="app1",environment="production",method="POST",status="200"} 700
app1_http_response_size_bytes{app="app1",environment="production",method="POST",status="500"} 14482
# HELP app1_parse_errors_total Total number of log file lines that could not be parsed
# TYPE app1_parse_errors_total counter
app1_parse_errors_total 0

Environment:

Exporter version: 1.7.1
OS (e.g. from /etc/os-release): Centos 7
Deployment method (e.g. Docker image, deb/rpm package, self-compiled, ...):  Binary based installation
Others: Tried with version 1.9.0 as well, but same metrics being exposed.

The http_response_time_seconds requires the $request_time variable to be present in your NGINX log format (which, at first glance, doesn't seem to be there). See the FAQ for more information.


python3Packages.hass-nabucasa: 0.45.1 -> 0.46.0

Motivation for this change
Update to latest upstream release 0.46.0
Change log: https://github.com/NabuCasa/hass-nabucasa/releases/tag/0.46.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@SuperSandro2000 Any particular reason you deleted that branch?

@SuperSandro2000 Any particular reason you deleted that branch?

Accident, I thought we left a branch behind that should be deleted.

That won't apply anymore as I picked it.


[Enhancement] add some trace log for dictionary manager (2/2)

What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/statistics/CacheDictManager.java
3
4
75.00%
[228]


Missing link from Asset to owner Item after signing STAC Item

Signed STAC Item returned from pc.sign is missing links from Assets back to Item.
assert signed_item.assets[name].owner is item

In the example below second assert fails.
from pystac import Item
import planetary_computer as pc

item = Item.from_file("S2B_MSIL2A_20190629T212529_R043_T06VVN_20201006T080531.json")
assert item.assets["B01"].owner is item
signed_item = pc.sign(item)
assert signed_item.assets["B01"].owner is signed_item

Adding an option to skip cloning / operate in place makes sense to me. API-wise, I think we call it either copy=True/False or clone=True/False (the default being to clone). I guess pystac uses preserve_dict=True, but that's in the context of dict -> pystac object.

@Kirill888 do you need a release with #25 in it, or do you have any additional testing / changes before you'd want a release?

Thanks @TomAugspurger, I'm not in a hurry for these fixes to be released as I ended up signing at url level as that fits for my use case better anyway, but then I'm also not planning any more additions to this, so if you want this fix released sooner that would be great too.

👍 0.4.1 is up on PyPI now https://pypi.org/project/planetary-computer/


[flash_ctrl] Size of the default region is set incorrectly

In flash_ctrl.sv, the size of the default region is set as follows:
  assign region_cfgs[MpRegions].size.q = {AllPagesW{1'b1}}; // 1ff or 511

This is one less than what it should be. This causes the last page (#511) to be completely inaccessible. This is due to the way region_end and region_match are calculated in flash_mp.sv.

In the snippet above, the page addr 1ff (= 512) does not match the default region, causing an error to be thrown.
The fix is to set the default region size to 512. This however raises another question - should mp_region_cfg[*].size field be 10 bits wide (to accommodate the value of 512)?

shall we close this issue if it's fixed?

Yes, this is fixed. Closing now.


Bar Chart change tooltip header

Hello,
Once I set .text() to display values inside the bars, the legend and tooltip title automatically take that .text() value. Which is not what I want. Am I overlooking something?
Fiddle: http://jsfiddle.net/Bq7Lc/12/
I was able to set the text for legend by using the text function but not sure how to access the tooltip title.
To be clear I would like the tooltip to display the name value as its title instead of the text value.
Thanks, Joe

Take a look at the "text" property of .labels( ). The .text( ) accessor will always be used for tooltip titles, but you can manually override where .labels( ) gets it's value (like how you were previously doing it for the legend): http://jsfiddle.net/Bq7Lc/13/


Move project to GitLab

I prefer GitLab over GitHub. We can maintain GitHub as a mirror, but use GitLab as the canonical repo. The main benefit of GitLab is the ability to mark issue dependencies.

Starting the import shortly.

So I tried something that didn't work, and now we have to wait a week for GitLab to delete the repo so we can re-import it.
Complaint filed here: https://gitlab.com/gitlab-org/gitlab/-/issues/191367#note_335383464


I tried to view my clipbord history and got the below error.

TypeError: Error processing argument at index 0, conversion failure from
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:280786
    at u (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:247022)
    at Generator._invoke (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:246775)
    at Generator.next (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:247385)
    at Os (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:252960)
    at a (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:253164)
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:253225
    at new Promise (<anonymous>)
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:253104
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:281132

Kit 1.32.4
Electron 19.0.16
darwin 22.1.0
Locale: en-US

@bigloudjeff Was that from using < from the main menu or trying the await getClipboardHistory() in a script?
Have you seen any other issues?

It was using the "<" keyboard shortcut. I had not given scriptkit accessibility permissions yet.


[stable/fluent-bit] Add serviceAccount annotations

What this PR does / why we need it:
Add annotations to serviceAccount ressource
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @edsiper

/ok-to-test
/assign
/lgtm


Is version 0.11.2 support gQUIC?

The version 0.11.2 can not serve chrome QUIC request, Is version 0.11.2 support gQUIC? Thank you

No. Please read readme. gquic branch supports gquic

@jinleileiking is right here.


Hooks intro and useState

Changes

Created Example code demonstrating useState and arrays
Updated Hooks introduction with a very brief description
Updated useState page

Do you want to merge this PR now, or do you want to add the other articles into this PR?
Merge this one! I was planning on doing the other pages in branches.. but I'm also flexible if you'd rather it all in one big PR 😃


cmd: Add release automation

Add release.sh( release.go wrapper)
Add release.go to use Github api and create new tags

Signed-off-by: Jose Carlos Venegas Munoz<EMAIL_ADDRESS>

@jodh-intel  thanks james, I added the feedback you provided. But I feel this PR should go in packaing repository I am closing this PR


Unnecessary edit parameter

Your code is passing this edit variable around but:
a) it's not used anywhere anyway
b) it wouldn't be correct anyway to use edit outside of the synchronous TextCommand run call. That would result in view not getting updated correctly.
https://github.com/yaroslavyaroslav/OpenAI-sublime-text/blob/63c909d289e4ad6b65d7894e6ef090c057ee57fe/openai.py#L11

Thanks for the suggestion, anyway, refactoring of the plug-in beyond of the bugfixing and minor UX improvements isn't in a near plans yet, at least until there's nothing major on the OpenAI side would have happened.
But if you're keen on it, you're more then welcome to provide a PR with the fix.

Fixed in #10


[WIP][SPARK-32227] Fix regression bug in load-spark-env.cmd with Spark 3.0.0

What changes were proposed in this pull request?
Fix regression bug in load-spark-env.cmd with Spark 3.0.0
Why are the changes needed?
cmd doesn't support set env twice. So set SPARK_ENV_CMD=%SPARK_CONF_DIR%\%SPARK_ENV_CMD% doesn't take effect, which caused regression.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested.

Create a spark-env.cmd under conf folder. Inside this, echo spark-env.cmd
Run old load-spark-env.cmd, nothing printed in the output
Run fixed load-spark-env.cmd, spark-env.cmd showed in the output.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @srowen

@warrenzhu25 . Could you elaborate about what is the regression you are mentioning here?

Fix regression bug in load-spark-env.cmd with Spark 3.0.0

ok to test

Test build #125441 has started for PR 29044 at commit bb018bb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30053/
Test PASSed.

@warrenzhu25 it should be best to the input like your command you tried and output from the command explicitly in PR description especially given that not so many dev people here arguably don't have Windows env.

Test build #125441 has finished for PR 29044 at commit bb018bb.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125441/
Test FAILed.

@warrenzhu25 As you see, we have a Windows OS test job in AppVeyor.
This patch consistently fails there. Could you take a look at that?

https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/33982534

@warrenzhu25 As you see, we have a Windows OS test job in AppVeyor.
This patch consistently fails there. Could you take a look at that?

https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/33982534

As I see, the failure seems unrelated with this change. It seems it couldn't find correct version of hadoop.dll.

It's directly relevant to this PR because your patch is changing environment variable.

Please see this for the detail (https://github.com/cdarlint/winutils)
You can run AppVeyor in your Spark fork, too.

Please remove [WIP] from the title when AppVeyor passes on Windows. Thanks.

It's directly relevant to this PR because your patch is changing environment variable.

Please see this for the detail (https://github.com/cdarlint/winutils)
You can run AppVeyor in your Spark fork, too.

winutils only impacted by PATH and HADOOP_HOME, and I don't touch both. Also, my change is just reverting into the version as 2.4.4. Could you help confirm this?

@dongjoon-hyun Could you help retest this as failing tests might be unrelated?

@warrenzhu25 you can push empty commit to retrigger the tests.

+1 for @HyukjinKwon 's comment.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31238/
Test PASSed.

Test build #126617 has started for PR 29044 at commit d6219d8.

Okay, I am debugging a related issue and happened to take a look again for this fix. this fix looks good. AppVeyor currently fails for another issue which I'll probably be able to fix soon.

Test build #126617 has finished for PR 29044 at commit d6219d8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126617/
Test FAILed.

Test build #126659 has started for PR 29044 at commit d169de3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31280/
Test PASSed.

Test build #126659 has finished for PR 29044 at commit d169de3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126659/
Test FAILed.

Test build #126670 has started for PR 29044 at commit 24af13c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31291/
Test PASSed.

Test build #126670 has finished for PR 29044 at commit 24af13c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126670/
Test PASSed.

Test build #126680 has started for PR 29044 at commit 4589e1b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31301/
Test PASSed.

Test build #126680 has finished for PR 29044 at commit 4589e1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126680/
Test PASSed.

@dongjoon-hyun Could you help merge this?

Merged to master and branch-3.0.

Thanks for working on this @warrenzhu25.

Thank you all. I see that this passed the GitHub Action at 4589e1b .


Visualiser has no output in webpack2

Adding the file like in the instructions has no effect; nothing is output.

/cc @chrisbateman

I'm unable to duplicate this, unfortunately. Any chance you could provide a link to your app code, or possibly make an example app with the issue?
Any error messages?
Are you just using new Visualizer() in your plugin setup?

@chrisbateman all good fine, i set wrong path :+1:

@chrisbateman Yes, with an output file name, too.

Same here: Added the plugin, but no output is generated.


Expand filter logic

This expands the builtin filter parser for LXD to facilitate integer operations, and allow configurable operators. Additionally moves the package over to shared so it can be imported by outside packages.
This is mainly to facilitate MicroCloud's preseed storage filter, but it's a nice to have for LXD, and it cleans up some panics as well.
filter.Parse now accepts an OperatorSet struct with definitions for each supported operator, as well as some additional symbols. The resulting ClauseSet can then be assigned custom parsers so we can transform fields to properly match the comparison object (like converting 10GiB to uint64)

@masnax seems like this is breaking things :)

Yep, static analysis and panic issues.


Visually separate bus and train services

Closes #24.

📝Changed routes:

/stations/[name]

(view full size)

Commit 66ef65affa3e7000ab7057dfb3290ba35643cda2 (https://ldb-git-services.kitibyte.vercel.app).


AWS Batch wrapper cannot execute function

Your documentation report this
https://docs.epsagon.com/docs/nodejs-aws-batch
I am using TypeScript and I have tried multiple things but I am getting always the same error.
try number 1:
`export const startExecution: any = epsagon.wrapBatchJob(doit);
function doit() {
console.log("sfsdffdsf")
}`
ERROR:
TypeError: handler_1.startExecution is not a function
try number 2:
export const startExecution: any = epsagon.wrapBatchJob((): any => {   console.log("sfsdffdsf") });
ERROR:
TypeError: handler_1.startExecution is not a function
try number 3:
`export const startExecution: any = epsagon.wrapBatchJob(async (): Promise => {
await runBatch();
});
export const runBatch = async (): Promise => {
// code here
};`
ERROR:
TypeError: handler_1.startExecution is not a function
It is interesting to note that the unit tests are all passing if you replace wrapBatchJob with lambdaWrapper and both of them have the same definition:
`
export function lambdaWrapper(f: T): T
export function wrapBatchJob(f: T): T
`
Thanks

Hi Ran,
I am playing around with the code and  with this little change I can run a function but not sure how to see if I broke the aws batch
module.exports.wrapBatchJob = function wrapBatchJob(functionToWrap) {
and unit tests are:
`it('wrapBatchJob: call sync function', () => {
function doit(arg) {
expect(arg).to.equal("params");
}
batchWrapper.wrapBatchJob(() => doit("params"));
});
it('wrapBatchJob: call async function', async () => {
    async function doit(arg) {
        expect(arg).to.equal("params");
    }
    batchWrapper.wrapBatchJob(async () => await doit("params"));
});

it('wrapBatchJob: sanity', () => {
    batchWrapper.wrapBatchJob(this.callbackStub);`

But again not really sure if this is enough or must be returned in the shimmer.wrap function

Hi @ymwjbxxq please look at the updated docs:
const epsagon = require('epsagon');
epsagon.init({
  token: 'epsagon-token',
  appName: 'app-name-stage',
  metadataOnly: false,
});

epsagon.wrapBatchJob();

function process(params) {
  // Your code is here
}

Thanks for pointing out the issue!

I do not understand how this fix the problem. I think now you need to change the TypeScript Definition

You're right, I've created a PR

you were faster than me...

:tada: This issue has been resolved in version 1.106.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bug: fix links in docs

some of the documentation links are broken. i am going to work on fixing these today.

Brandon,
As i mentioned in Slack, here are few other issues that i found.

In guide, we are suggesting to use latest Minikube version (in my case v0.17.1). With this version of Minikube, i was not able to use Kubernetes v1.5.1.
I ended up using v1.5.3

Also in guide, we have following instruction

Get a list of the current tags:
git tag -l
Checkout the tag you want to work with (use master for development):
For stability and testing, checkout the latest stable branch.
git checkout 0.2.0
I don't think we have tag 0.2.0 in github for our project.


New version of twilio-ruby coming soon

I just wanted to let you know that there is a new major version of the twilio-ruby gem on it's way soon. This new version is not backwards compatible with version 4 or below.
Since Textris, in production, doesn't depend on twilio-ruby it is worth testing this with versions 3 (which is the development dependency here), 4 and 5 (currently rc18).
I can take a look at this soon, but things are really busy for me right now, so I thought I'd call it out here in case anyone else can look.

Thanks a lot for a heads-up. I'll take a look at it next week and ping you if any doubts arise.


Add os module to backdoor_lnk.py

'import os' module missing. Using ExtFile throws error without it.

@katsu-sec Can you re-submit this to the (preferred) 2.0_beta branch or dev branch?


chef shell-init powershell fails due to double-quotes in a PATH segment

Description
On Windows, when I run the Chef Development Kit app from the Start Menu, I get the following exception:
iex : At line:1 char:2966
+ ... ox;C:\Users\lsilverman\AppData\Roaming\Boxstarter;"C:\Program Files\S ...
+                                                        ~~~~~~~~~~
Unexpected token 'C:\Program' in expression or statement.
At line:1 char:118
+ ... DK_ENV_FIX = 1; chef shell-init powershell | out-string | iex; Import ...
+                                                               ~~~
    + CategoryInfo          : ParserError: (:) [Invoke-Expression], ParseException
    + FullyQualifiedErrorId : UnexpectedToken,Microsoft.PowerShell.Commands.InvokeExpressionCommand

PowerShell 5.1.15063.138 (Microsoft Windows NT 10.0.15063.0)
Ohai, welcome to ChefDK!

The issue appears to be that Invoke-Expression doesn't like one of the paths being fed to it. Within the PATH environment, I have a double-quoted path that looks like ;"C:\Program Files\Sublime Text 3\";
I've been unable to figure out where shell-init is getting this path fragment to my Sublime installation folder. This path to Sublime does not exist in my system or user environment variables. It's also not embedded in my Powershell profiles. I'm sure it's set somewhere, but I cannot find it.
How does shell-init construct this string that it outputs? Where else can I look?
ChefDK Version
Chef Development Kit Version: 1.2.22
chef-client version: 12.18.31
Platform Version
Windows 10.0.15063.138
Replication Case
Possibly add double quotes to any part of the PATH.
Stacktrace
Included above.
NOTE: CHEFDK BUGS ONLY
This issue tracker is for the code contained within this repo -- chefdk.

Server issues
Chef-client issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

Nevermind, found the issue myself. Was using clink.exe, which has a custom startup file. I'd appended Sublime to my PATH there, with double quotes. Had never caused a problem until ChefDK. I've resolved this.


Invoking "cmake" failed with catkin_make -DCMAKE_BUILD_TYPE="Release"

How to solve the error above? Thanks~
zhangte@zhangte-Lenovo-V3000:~/catkin_ws$ catkin_make -DCMAKE_BUILD_TYPE="Release"
Base path: /home/zhangte/catkin_ws
Source space: /home/zhangte/catkin_ws/src
Build space: /home/zhangte/catkin_ws/build
Devel space: /home/zhangte/catkin_ws/devel
Install space: /home/zhangte/catkin_ws/install

Running command: "cmake /home/zhangte/catkin_ws/src -DCMAKE_BUILD_TYPE=Release -DCATKIN_DEVEL_PREFIX=/home/zhangte/catkin_ws/devel -DCMAKE_INSTALL_PREFIX=/home/zhangte/catkin_ws/install -G Unix Makefiles" in "/home/zhangte/catkin_ws/build"

-- Using CATKIN_DEVEL_PREFIX: /home/zhangte/catkin_ws/devel
-- Using CMAKE_PREFIX_PATH: /opt/ros/indigo
-- This workspace overlays: /opt/ros/indigo
-- Using PYTHON_EXECUTABLE: /usr/bin/python
-- Using Debian Python package layout
-- Using empy: /usr/bin/empy
-- Using CATKIN_ENABLE_TESTING: ON
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /home/zhangte/catkin_ws/build/test_results
-- Found gtest sources under '/usr/src/gtest': gtests will be built
-- Using Python nosetests: /usr/bin/nosetests-2.7
-- catkin 0.6.18
-- BUILD_SHARED_LIBS is on
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- ~~  traversing 5 packages in topological order:
-- ~~  - iai_kinect2 (metapackage)
-- ~~  - kinect2_registration
-- ~~  - kinect2_bridge
-- ~~  - kinect2_calibration
-- ~~  - kinect2_viewer
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- +++ processing catkin metapackage: 'iai_kinect2'
-- ==> add_subdirectory(iai_kinect2/iai_kinect2)
-- +++ processing catkin package: 'kinect2_registration'
-- ==> add_subdirectory(iai_kinect2/kinect2_registration)
-- OpenCV ARCH:
-- OpenCV RUNTIME:
-- OpenCV STATIC: OFF
CMake Warning at /usr/local/opencv-2.4.13/cmake/OpenCVConfig.cmake:163 (message):
Found OpenCV Windows Pack but it has not binaries compatible with your
configuration.
You should manually point CMake variable OpenCV_DIR to your build of OpenCV
library.
Call Stack (most recent call first):
iai_kinect2/kinect2_registration/CMakeLists.txt:29 (find_package)
CMake Error at iai_kinect2/kinect2_registration/CMakeLists.txt:29 (find_package):
Found package configuration file:
/usr/local/opencv-2.4.13/cmake/OpenCVConfig.cmake

but it set OpenCV_FOUND to FALSE so package "OpenCV" is considered to be
NOT FOUND.
-- Configuring incomplete, errors occurred!
See also "/home/zhangte/catkin_ws/build/CMakeFiles/CMakeOutput.log".
See also "/home/zhangte/catkin_ws/build/CMakeFiles/CMakeError.log".
Invoking "cmake" failed

Hi,
that's not related to this package but to your OpenCV installation. Something seems to be wrong there. It is recommended to use the version that comes with ROS.

Hello, can anybody help me to figure out the these compilation errors:
........partial...........
make[2]: *** [iai_kinect2/kinect2_registration/CMakeFiles/kinect2_registration.dir/src/depth_registration_cpu.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [iai_kinect2/kinect2_registration/CMakeFiles/kinect2_registration.dir/src/depth_registration_opencl.cpp.o] Error 1
make[2]: *** [iai_kinect2/kinect2_registration/CMakeFiles/kinect2_registration.dir/src/kinect2_registration.cpp.o] Error 1
make[1]: *** [iai_kinect2/kinect2_registration/CMakeFiles/kinect2_registration.dir/all] Error 2
make: *** [all] Error 2
Invoking "make -j4 -l4" failed

Well, please past the errors, and not the summary of the build.

Hi, How do you fix this issue?


chore: increase csi-node plugin memory limits

Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors merge


Variance in size of backup

We do periodic backups using something like
arangodump --server.database "wdt" --include-system-collections true --output-directory ....
Is there reason why the size of these backups would fluctuate ?  (increases in size the longer it's been since restart, goes back down to small size once the restart occurs)
these are small sizes 5mb to 20mb - and everytime we've restored them they have been sane - but what could contribute to this difference?

arangodump saves revisions to.
cat test_098f6bcd4621d373cade4e832627b4f6.data.json
{"type":2300,"key":"2260451821842","rev":"2260454115602","data":{"_key":"2260451821842","_rev":"2260454115602","a":"c"}}
{"type":2300,"key":"2260451821842","rev":"2260619462930","data":{"_key":"2260451821842","_rev":"2260619462930","a":"d"}}

arangodump will stream the contents of the collection datafiles to the client. The more datafiles, and the more data contained in the datafiles, the bigger a backup will be.
The are thus multiple reasons for increasing backup sizes:

the total number of documents in a collection grows, so the datafiles contain more documents, or there are more datafiles than in previous backups.
the number of deletions in a collection grows, so the datafiles contain more of them. deletions may be kept for a long time in the datafiles, but they are very small space-wise.
documents are updated often. In case of an update, a new document revision is written to the datafile, and old (outdated) and new (current) document revisions may coexist in parallel. If many outdated revisions are present in datafiles, the compaction should eventually clean the datafiles. So overall this shouldn't lead to a steady increase if the number of alive documents keeps about constant.
this may have been caused by issues #1596 and #1662, which have led to the compaction not cleaning the datafiles under some circumstances, leading to datafile growth, and thus a growth of backups.

If possible, can you re-try with 2.7.5 when it's available?

2.7.6 is now available for Download containing @jsteemann s fixes.


Feature/amounts

Codecov Report

Merging #108 into v0.6.2 will increase coverage by 0.14%.
The diff coverage is 94%.

@@            Coverage Diff             @@
##           v0.6.2     #108      +/-   ##
==========================================
+ Coverage   89.26%   89.41%   +0.14%
==========================================
  Files         102      107       +5
  Lines        7642     7892     +250
==========================================
+ Hits         6822     7057     +235
- Misses        820      835      +15

Impacted Files
Coverage Δ

model/src/lib.rs
0% <ø> (ø)
:arrow_up:

monero/src/amount.rs
100% <100%> (ø)

model/src/amount.rs
50% <50%> (ø)

zcash/src/amount.rs
91.66% <91.66%> (ø)

ethereum/src/amount.rs
94.79% <94.79%> (ø)

bitcoin/src/amount.rs
95.23% <95.23%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707a58d...8549699. Read the comment docs.


Just an idea: add subsection like cyber security?

Forrest I love your vids! Just a suggestion why not add sections like cyber security? Would love to see it!

Maybe that could be add on sections outside of the general premise.  I love the ideas.

I'm considering creating another repository for more specific sections, or dividing this repository into two sections. Section 1 is how it currently sits, and under that will be section 2 with the specific sections like AI dev, Cyber Security, Networking, etc.


chore: release main

:robot: I have created a release beep boop
protocol/core: 2.0.0
2.0.0 (2024-03-12)
⚠ BREAKING CHANGES

breaking fix

Bug Fixes

breaking fix (4aa7fa0)
fix some things (f426185)

runtime/tendermint-ssync: 1.1.1
1.1.1 (2024-03-12)
Bug Fixes

fix some things (f426185)

tools/kystrap: 1.4.1
1.4.1 (2024-03-12)
Bug Fixes

fix some things (f426185)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/shifty11/kyve-rdk-fork/releases/tag/protocol/core%402.0.0 :sunflower:

:robot: Release is at https://github.com/shifty11/kyve-rdk-fork/releases/tag/runtime/tendermint-ssync%401.1.1 :sunflower:

:robot: Release is at https://github.com/shifty11/kyve-rdk-fork/releases/tag/tools/kystrap%401.4.1 :sunflower:


Match Validation: 1/3

JIRA
First split of this PR
This create the match validation module, and support in the scanner
There is no real implementation yet will come in a follow up PR

Overall I think this is going in a good direction. I'm glad you were able to figure out some of the async Rust challenges. Two main things I'd like to see improved:

The custom PartialEq / Hash on MatchValidatorType seems suspicious and there's likely a better way to do this. I left some comments, but feel free to reach out and we can discuss this part more

There are 67 uses of #[cfg(feature = "match_validation")] in this PR. That seems a bit excessive and makes the code harder to work with. We should do one of the following:

Keep the feature. This will require adding better tests in CI to verify that all features actually compile correctly, since CI only currently tests the default features. You can use something like https://github.com/taiki-e/cargo-hack?tab=readme-ov-file#--each-feature to do this
Remove the feature, and make it a scanner level config. This seems like it wouldn't have much overhead, so it might be a reasonable choice to remove all the conditional compilation.
Maybe something in the middle, where all of the code is kept, but a single conditional compilation can enable / disable it (by choosing all of the validators, or an empty list?)

@fuchsnj I agree that the PartialEq seems suspicious, I think it makes the user interface neat though, so user can configure their custom validator directly in the rule in one place. Happy to chat about that so we can find a better solution.

Regarding the match_validation feature, I did it on a recommendation to not slow down the "standard" usage of sds, and so not adding extra suff on the RuleMatches returned. That beeing said it "only" adds 2 items, one is optional (8bytes) and the other one is MatchStatus (24 bytes), so 32 bytes per RuleMatch in total. @vinckama @fuchsnj this seems acceptable to me and I would prefer removing the match_validation feature

Regarding test on the CI @fuchsnj I added the feature in the dev-deps so tests are exectued with the match_validation (but not without it I confess)


add pod annotations for recording runtime version information

The only two (I think) we care about right now are executor version and kernel version. All the sidecars should be in the podspec.
Perhaps TSA version as well?

2 sounds fine. If we find that we are at 3, then I would propose we move to a single annotation + csv. I don't want the pod to explode with every version ever.
Plus, I don't really want systems built that actually read and take advantage of this data, should be debug and informational only (which is why I'm thinking a CSV would be just fine)


add RTP/MPEG-2 audio decoder and encoder

Codecov Report

Merging #257 (3595f5d) into main (2dc8838) will decrease coverage by 0.13%.
The diff coverage is 80.17%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   86.33%   86.20%   -0.13%
==========================================
  Files          86       88       +2
  Lines        8993     9107     +114
==========================================
+ Hits         7764     7851      +87
- Misses        953      976      +23
- Partials      276      280       +4

Impacted Files
Coverage Δ

pkg/formats/mjpeg.go
100.00% <ø> (ø)

pkg/formats/rtph264/decoder.go
81.60% <ø> (ø)

pkg/formats/rtph264/encoder.go
94.67% <ø> (ø)

pkg/formats/rtph265/decoder.go
72.22% <ø> (ø)

pkg/formats/rtph265/encoder.go
92.72% <ø> (ø)

pkg/formats/rtplpcm/decoder.go
100.00% <ø> (ø)

pkg/formats/rtplpcm/encoder.go
95.16% <ø> (ø)

pkg/formats/rtpmjpeg/decoder.go
87.28% <ø> (ø)

pkg/formats/rtpmjpeg/encoder.go
54.16% <ø> (ø)

pkg/formats/rtpmpeg4audio/encoder.go
96.64% <ø> (ø)

... and 8 more

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot mock DynamoDBv2 AsyncSearch for unit testing AWS calls

Would like to be able to properly unit test my code which uses the AWS SDK, and in particular the AsyncSearch class.
Possible Solution

Create an interface for this class
Create an empty public constructor may also work

I have  the same issue with AsyncSearch.

at the PR.

Do you have chance to look at it ?

Hello,
Any update regarding this?

This would be very nice please

1 vote for me. It's painful to test.

Frankly, The TDD approach of this lib is pretty shocking, why have you got interfaces that expose internally constructed objects such as AsyncSearch<T> and Table ? It makes for grim reading when trying to carry out the simplest of mocking in unit tests.
Just adding a public empty constructor would allow a safe non breaking fix for this - albeit not the best, but it should not have taken over a year to come to this conclusion.

When will we see movement on this issue. Not being able to write proper unit tests is very frustrating.
Just add the empty and public constructor so that we can mock the class.

When will we see movement on this issue. Not being able to write proper unit tests is very frustrating.
Just add the empty and public constructor so that we can mock the class.

@kwbauer  - I ended up caving in and wrapping this code in a new class with what should be the appropriate interface in this library. - I means that my unit tests are testing the wrapper, and not the actual call within the AWSSDK which means I'm not 100% happy about it, but it will do. Code snippets below.
    internal interface IAsyncSearch<T>
    {
        bool IsDone { get; }

        Task<IReadOnlyList<T>> GetNextSetAsync(CancellationToken cancellationToken);

        Task<IReadOnlyList<T>> GetRemainingAsync(CancellationToken cancellationToken);
    }

    internal sealed class AsyncSearchWrapper<T> : IAsyncSearch<T>
    {
        private readonly AsyncSearch<T> asyncSearch;

        public AsyncSearchWrapper(AsyncSearch<T> asyncSearch)
        {
            this.asyncSearch = asyncSearch;
        }

        public bool IsDone => this.asyncSearch.IsDone;

        public async Task<IReadOnlyList<T>> GetNextSetAsync(CancellationToken cancellationToken)
        {
            return await this.asyncSearch.GetNextSetAsync(cancellationToken);
        }

        public async Task<IReadOnlyList<T>> GetRemainingAsync(CancellationToken cancellationToken)
        {
            return await this.asyncSearch.GetRemainingAsync(cancellationToken);
        }
    }

    internal sealed class GeminiDbContext : IGeminiDbContext
    {
        private readonly Lazy<IDynamoDBContext> context;

        public GeminiDbContext(IDynamoDBContext context)
        {
            this.context = context;
        }

        public IAsyncSearch<T> Query<T>(object hashKeyValue, DynamoDBOperationConfig operationConfig = null)
        {
            var search = this.context.Value.QueryAsync<T>(hashKeyValue, operationConfig);
            return new AsyncSearchWrapper<T>(search);
        }
    }

I also renamed the wrapper method to Query istead of QueryAsync, as its not actually an Async method.
Hope this helps.

Hi Guys,
Any chance this issue can move into the main library it's a bit frustrating not being able to write unit tests as part of the main library?

There is a PR here https://github.com/aws/aws-sdk-net/pull/1187 , but was never merged.

Bump

Bump

Bump

Bump

Bump

Bump

BUMP!!!

Bump

bump

bump

It is ridiculous not to do anything about it for 5 years (sic!) 😡 😡 😡

bump
Just wondering if there has been any movement on this?

I put out this PR to provide a way to mock AsyncSearch. It is not perfect given the constraints we have to avoid making breaking changes but I would appreciate some thoughts on the PR.
https://github.com/aws/aws-sdk-net/pull/2089

If anyone wants workaround you can use approach propsed in this comment:
https://github.com/aws/aws-sdk-net/issues/772#issuecomment-578885398
Works fine 😃  But still it would be better to have that out of the box from library 👎

@jakubbujak Are you saying that my PR that would go in the box would not suffice?

I did not write anything like that, it may be, but I did not have time to review it :)

Version <IP_ADDRESS> of the AWSSDK.DynamoDBv2 package was recently released with https://github.com/aws/aws-sdk-net/pull/2089 that adds the ability to subclass AsyncSearch for mocking purposes.
        public class MockAsyncSearch<T> : AsyncSearch<T>
        {
            public override Task<List<T>> GetNextSetAsync(CancellationToken cancellationToken = default(CancellationToken))
            {
                return Task.FromResult(new List<T>());
            }
        }

        [TestMethod]
        [TestCategory("DynamoDBv2")]
        public async Task TestMockingAsyncSeach()
        {
            var mockDBContext = new Mock<IDynamoDBContext>();
            mockDBContext
                .Setup(x => x.ScanAsync<DataItem>(
                   It.IsAny<IEnumerable<ScanCondition>>(),
                   It.IsAny<DynamoDBOperationConfig>()))
                .Returns(
                   new MockAsyncSearch<DataItem>() // Return mock version of AsyncSearch
                );

            var search = mockDBContext.Object.ScanAsync<DataItem>(new List<ScanCondition>());
            Assert.IsInstanceOfType(search, typeof(MockAsyncSearch<DataItem>));

            var items = await search.GetNextSetAsync();
            Assert.AreEqual(0, items.Count());
        }


Doesn't work for black-and-white .jxl images

Hello,
I'm using the official binary that you provide in "JXLook-0.1.3.app.tbz", and it works for many .jxl images, but it doesn't for black-and-white ones.
I'm attaching to this ticket both an original .jpg file, and the .jxl image converted from the original. And JXLook is unable to show the converted image.
Here are screenshots proving this:

Attachments:
x1A27_L8xbE.jpg.zip
x1A27_L8xbE.jxl.zip

Thanks for reporting. Please check the latest version 0.1.4. It should support greyscale image.

Yes, the problem is now solved in 0.1.4. Thank you for your reactivity and for providing the app for free! Bye-bye


[dv, gls] Update ibex PMP signals for gate-level

Cherry-pick one commit from master to earlgrey_1.0.0

This would cherry-pick #24353 to earlgrey_1.0.0. I agree with that, but we need cherry-pick commits to adhere to a common format (see previous commits on that branch for reference). I'll shortly create a PR that includes this one.


H and B Image for delivery

Ability to attach an image when delivered

Can you create a new label and make this 'Nice To Have' please. That allows me to de-prioritise


P2P Linux platform fixes

[Issue #339]

connection now owns a fixed size send buffer, using only enough of it
to send each message.  Send buffer size matches input buffer size.
network_version is now initialized in net_plugin_impl.

Thanks! Let's use all caps for the constant name please.
On Fri, Sep 8, 2017 at 3:22 PM, jgiszczak<EMAIL_ADDRESS>wrote:

@jgiszczak commented on this pull request.
In plugins/net_plugin/net_plugin.cpp
https://github.com/EOSIO/eos/pull/388#discussion_r137881717:

     remote_node_id(),

     last_handshake(),
     out_queue(),
     connecting (false),

   syncing (false),

That looks like a merge problem. I managed to retain one of them but not
the other.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EOSIO/eos/pull/388#discussion_r137881717, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2wCVj0ovL6YuY4ahmOQnt5GIeJDAzdks5sgaH9gaJpZM4PRXab
.

--
Phil Mesnier
Principal Engineer & Partner
OCI | WE ARE SOFTWARE ENGINEERS.
tel<PHONE_NUMBER> x225 <(314)%20579-0066>
ObjectComputing.com
http://objectcomputing.com/

Yeah, that's because the launcher will set up A -> B + B -> A as 2 socket
connections, when it should just be one. But that's a topic for a different
issue.
On Fri, Sep 8, 2017 at 3:30 PM, jgiszczak<EMAIL_ADDRESS>wrote:

@jgiszczak commented on this pull request.
In plugins/net_plugin/net_plugin.cpp
https://github.com/EOSIO/eos/pull/388#discussion_r137883227:

     peer_addr ()

 {

 wlog( "created connection from client" );

 wlog( "created network connection" );

At the moment, that isn't always what it is. In my testing using launcher,
simply connecting two eosd peers consistently used the constructor that
output created connection from client. Unless you're choosing to use
language that makes no distinction between peer eosds and clients like
eosc in the description, considering them all clients, my change more
accurately describes the code's present lack of distinguishing between them.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EOSIO/eos/pull/388#discussion_r137883227, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2wCacvLYkUBAPuDss-lddfZmCcL1ySks5sgaPWgaJpZM4PRXab
.

--
Phil Mesnier
Principal Engineer & Partner
OCI | WE ARE SOFTWARE ENGINEERS.
tel<PHONE_NUMBER> x225 <(314)%20579-0066>
ObjectComputing.com
http://objectcomputing.com/

Fixed.  I've left the text as-is, pending refactoring to make the role distinction explicit.  I went with the only explicit constant naming convention anybody offered.  Per Dan, that's anything but all caps.


Slow Tele-Op

Our tele-op is very slow and all the movement is really rough and inconsistent.

The problem was that we were stacking conditionals on each other, which caused them all to run at the same time, which meant that the motors were doing different tasks at the same time. So, we decided to create a return function, which would only run the motors when the power wasn't 0, and wouldn't have them do simultaneous tasks.


How can I simply import s3 folder (no Spectrum )

Hello,
The official copy command would got error, so I look into this project .
I see usage is
Usage: spectrify create_table [OPTIONS] S3_PATH SOURCE_TABLE DEST_TABLE

Here, what is SOURCE_TABLE  ??  I already have a s3 folder contains some parquet files .
And , redshift spectrum is not launched on China AWS .
I just want to import data from s3 to redshift .

Hi @eromoe this article may help — https://aws.amazon.com/about-aws/whats-new/2018/06/amazon-redshift-can-now-copy-from-parquet-and-orc-file-formats/
I do not think you need Spectrify to accomplish your goals - if you have any other questions the aws forums are also super helpful.


Added description label side margins property.

I was using the descWidth property that you removed recently, so I decided to re-implement it in a close way (specifying the margins instead of the label width, that makes more sense IMO).
Feel free to reject if you think this feature is too specific.

Looks good, thanks! And sorry for delay, had to get rid of all bugs before moving to new features :)


Minor corrections for fan mode and parseCapabilityData

parseCapabilityData was always returning null, even when the capability was set to true. This was disallowing any mode changes.
Also fan action was incorrect, should have been fanOn

I cannot commit this change as it would break my implementation. It seems your ac is sufficiently different to others that use this code. Can you provide me with your capability json output from two so I can check the differences between your ad capability in fan and dry modes

I haven't changed any of the capabilities as far as I'm aware. There was a missmatch in the action names (you'd used both cmdFanSpeedMid and cmdFanSpeedMed, so it wasn't working. Also the action "fan" isn't a standard ST Thermostat action, it was changed to "fanOn". Neither of these would work no matter what capabilities were available, they were just code errors.
I did include some slight changes to stop it erroring when the thermostat set point wasn't set (moved the retrieval of getting the setpoint to inside the if statement after checking it was in HEAT or COOL mode).


Ignore missing declarations around DllMain

Please see the other way of addressing this: https://github.com/discordapp/discord-rpc/pull/130 and pick one to merge and one to drop or provide comments.

Naturally, I reviewed the wrong one.  I'm gonna merge #130.  ignore me~


matrix-hookshot: avoid runtime dependency on rustc

Description of changes
Nix previously would see a reference to rustc's store path in .rustc_info.json and proceed to register it as a runtime dependecy. Delete it so it doesn't.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Rebased on 1536926ef562 (3 weeks old) which is what my NixOS system I tested this is on.


⚠ Website has degraded performance

In d604ce0, Website (https://tandoor.dev/) experienced degraded performance:

HTTP code: 200
Response time: 8455 ms

Resolved: Website performance has improved in 9ccd6c8 after 15 minutes.


Serve chainlit app from a subdirectory

The docs says that

"Currently, you have to serve your Chainlit app from the root of your domain/subdomain. This means that you can’t serve it from a subdirectory like example.com/my-app."

So, I'd like to be able to serve the app from different base path, like setting a base tag or something.

Yes this is a current limitation. Setting a subdomain and serving the app from the subdomain root is not an option for you?

Yes, we can mitigate that way, but a best solution for us would be to serve the app from a subdir. I can work on that if you guys think it's a nice feature to be added and if there is no known limitations to develop that feature.

Would love contributions on that topic! I don't think we have any particular requirements except for the http endpoints to work correctly (maybe also oauth redirections). We do have the concept of CHAINLIT_URL already to help with tricky oauth redirections.

Encountered similar issue - tried run the app at root directory but still displayed empty screen.


⚠ Fortnite has degraded performance

In 25104a9, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1588 ms

Resolved: Fortnite performance has improved in a87d534.


Add Functional programming category

We are looking for links about Functional Programming.

can i add E-book haskell?

Hi @sayaPintar,
It will depend on what's inside your ebook and the following points :

The ebook should be for about "basics". It should not be a big ebook about mastering the techno that take 10h to be read. But in case of a big ebook we would accept if your link is followed by a short description that says "the chapter XX is a great introduction for learning functional programming"
It should be more about FP than just Haskell
The ebook should be free

Also regarding the second point, I'm wondering if this kind of link would have it's place in a "Language" section instead of in "FP". As you know what's inside the ebook, what's you opinion on this?

i agree but can we add more on, and summary about haskell?

I have done a pull request.

Finding-Dream-Business


[cef-build] Create a new port

Describe the pull request
CEF was requested 5 years ago but nobody has added it yet: #332
This is the next best thing: Pre-built CEF binaries.
What does your PR fix?
Fixes #332 (for win64 builds.)
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows, Yes
(There are binaries for other triplets on their website, but I didn't implement that.)
Does your PR follow the maintainer guide?

Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Update: I realize I'm not copying the dll, bin, pak and dat files correctly. It only ran for me because they were left over from an old build.
How do I get the pak and dat files to end up in the .exe directory?

Please take a look at https://github.com/microsoft/vcpkg/pull/10102

@Pospelove But doesn't the recent chartdir port use prebuilts?

@JackBoosY I changed it to use INSTALL() command for everything, but I still have the same issue, I don't know how to copy .bin files to output directory.
For example I added this to CMakeLists.txt:
file(GLOB bins_deb Debug/*.dll Debug/*.bin)
file(GLOB bins_rel Release/*.dll Release/*.bin)
INSTALL(
  FILES ${bins_deb}
  CONFIGURATIONS Debug
  TYPE BIN
)

And they appear in the bin folder:

But they don't get copied over to .exe directory. Am I doing something wrong?

@serg06  I will give you some help.

@serg06 ,Can you please resolve the conflicts against master?

I noticed that this port only generates the library libcef_dll_wrapper, and other libraries copy existing files. Right?
If it's true, we hope that the main library cef is generated by the build process and change the port name to cef.

Are you suggesting we generate the cef binaries ourselves instead of using prebuilts? How could that help with the current issue?

@serg06 According to our policy, we need to generate binaries as much as possible instead of directly installing pre-built binaries.

@JackBoosY That's fine, but it has been years and nobody has added cef yet. Wouldn't it better to have prebuilt binaries than to have nothing at all?

@serg06 Sorry but according to our policy, only SDK can use pre-built binaries.
We should use vcpkg_configure_gn to build it.
Example: chromium-base

@JackBoosY Ah okay. Thanks for the help. I hope someone will add it in the future.


There are some memory leak

I tried mnist_classifier.py, which is corresponding to mnist_classifier.py of Jax.
I increased num_epochs = 1000
mnist_classifier.py of jaxnet failed with out-of-memory although mnist_classifier.py of Jax finished without any errors.

Hi @neon5d, thank you for reporting this! Sorry for the delay.
I just ran the example for 1000 epochs on colab, which worked fine. Did you use the exact code from the examples folder? Also, what version of jax/jaxlib were you using?

Closing this since a similar issue (https://github.com/JuliusKunze/jaxnet/issues/11) is now fixed.
@neon5d Please don't hesitate to reopen in case if you still have this issue with the new version of JAXnet!


Typo in documentation for the Quick Shortcut

"... the Quick MonoBehavior wizard puts them right at your fingertips. Press CTRL+ALT+Q."  should be CRTL + SHIFT + Q

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f27057a9-85be-f96c-29aa-0fa60b488f35
Version Independent ID: cd80ccea-8ecd-d21f-08b8-af0a2ada7cf3
Content: Overview of Visual Studio Tools for Unity - Visual Studio
Content Source: docs/cross-platform/overview-of-visual-studio-tools-for-unity.md
Product: visual-studio-dev15
GitHub Login: @conceptdev
Microsoft Alias: crdun

Hey @zuluonezero. This feature has actually been removed in the latest version of Visual Studio Tools for Unity, now that we have IntelliSense support for the Unity API. We're working on updating the documentation to reflect this. Thanks for the feedback!

@zuluonezero We've just finished a fairly large overhaul of the VSTU docs, including addressing this issue. Take a look at your convenience! https://docs.microsoft.com/en-us/visualstudio/cross-platform/visual-studio-tools-for-unity