Explicitly call unbind() in Activity if ListenerClass has valid remover???

if ListenerClass implementation has a valid remover, e.g. OnPageChange and OnTextChanged, the remover method is added in the implementation of Unbinder.unbind() method, by BindingSet.removerOrSetter() method.
So, for Activities that reference ListenerClass implementations with a valid remover, I did not see a
explicit or implicit method to call the unbind() method of ButterKnife.bind()'s return value.
I wonder if the remover or unbind() method would be automatically called? How if yes? If no, there would be memory leak.
I believe we MUST EXPLICITLY call Unbinder.unbind(), where Unbinder instance is returned by ButterKnife.bind(), in Activities referencing any ListenerClass with a valid remover.
#906 #971

another path is ButterKnife.bind() calls parseOnTextChanged which returns a ListenerUnbinder. It's unbind() method calls:
private static final Setter<TextView, TextWatcher> REMOVE_TEXT_WATCHER =
      (view, value, index) -> view.removeTextChangedListener(value);

but also, the returned Unbinder of parseOnTextChanged() method is delegated to CompositeUnbinder, which is not called in Activities.

You only need to call unbind() in fragments in onDestroyView because it can cause a leak if the fragment is re-used. For activities you do not need to call the method because the references form a cycle which will be correctly GC'd.

@jakeWharton if we call addTextChangedListener() method which has a TextWatcher object referencing the activity. The listener is stored in TextView's  ArrayList<TextWatcher> mListeners. If we do not call removeTextChangedListener() method, there would be a memory leak.
with butterknife, the addTextChangedListener() method is replaced by perhaps a method annotated with a @onTextChanged. But the concrete implementation is also addTextChangedListener(). So we must call removeTextChangedListener() method in unbind().
I did not see any calls to removeTextChangedListener() in generated unbind() method.

They're there: https://github.com/JakeWharton/butterknife/blob/0ead8a7b21620effcf78c728089fc16ae9d664c0/butterknife-runtime/src/test/java/butterknife/OnTextChangedTest.java#L63
But like I said, this forms a cycle so it's not a problem for binding activities anyway.

hi @JakeWharton. DO APOLOGIZE IF I AM somewhat verbose... BUT I REALLY BELIEVE that the unbind() method is not called for _ViewBinding classes, when it's some SomeActivity_ViewBinding: because for activities, we don't call the unbind() method of the Unbinder returned by ButterKnife.bind() method.
would you please do me a favor to feature out how it's implicitly called? MANY THANKS!!!

It isn't. Either you call it or you don't.
On Sat, Apr 20, 2019, 4:47 AM macarthor<EMAIL_ADDRESS>wrote:

hi @JakeWharton https://github.com/JakeWharton. DO APOLOGIZE IF I AM
somewhat verbose... BUT I REALLY BELIEVE that the unbind() method is
not called for _ViewBinding classes, when it's some
SomeActivity_ViewBinding: because for activities, we don't call the
unbind() method of the Unbinder returned by ButterKnife.bind() method.
would you please do me a favor to feature out how it's implicitly called?
MANY THANKS!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1497#issuecomment-485071058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAQIEJ2WNS7WOXMCJJMJXDPRLKDJANCNFSM4HFMXT2Q
.

And what about the case when I use the bind() method in a ViewHolder of the RecyclerView adapter? Calling unbind() in onViewRecycled() might seem like a legit idea, but calling bind() each time an item appears (not in the constructor of a ViewHolder) seems kinda suspicious.

You shouldn't unbind in a view holder either. Bind in the constructor and
have the lifetime of the view holder match the lifetime of the view. When
new data comes in just update the local and view state. The views haven't
actually changed and so you don't need to re-bind them.
On Mon, Apr 22, 2019 at 4:23 PM MihailsKuzmins<EMAIL_ADDRESS>wrote:

And what about the case when I use the bind() method in a ViewHolder of
the RecyclerView adapter? Calling unbind() in onViewRecycled() might seem
like a legit idea, but calling bind() each time an item appears (not in the
constructor of a ViewHolder) seems kinda suspicious.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1497#issuecomment-485539509,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAQIEPR3AA4CUWFBYNYQGLPRYNCXANCNFSM4HFMXT2Q
.

@JakeWharton thanks


Maya: make render settings validator optional

Changelog Description
Make Render Settings validator otional
Testing notes:

set render settings validator in Maya optional
try to publish render

I also find out the enabled option for ValidatePluginPathAttributesModel might be wrong.(not related to this PR)
https://github.com/ynput/ayon-core/blob/9f4c7018a289a2bd060bd8ad1c25969952e93c28/server_addon/maya/server/settings/publishers.py#L239-L246

I also find out the enabled option for ValidatePluginPathAttributesModel might be wrong.(not related to this PR)

Unrelated, but fixed it here anyway, sorry about that.


Document lifetime of closures used to create Tasks

Description
Joe:

As a general rule, it is rarely necessary or helpful to use weak captures in a Task closure, since tasks already don't form permanent references to their context; like any other function, they will retain the values they use only for as long as the code executing needs them, and when the task ends, it will release any remaining local state.

https://forums.swift.org/t/unexpected-memory-leak-when-using-task-in-a-closure-causes/66272/6
Me:

To be fair, the documentation for the Task type does not mention this, nor does the documentation for any of the Task initialisers (where those closures are provided).
In other contexts, if you initialise a type by providing an @escaping closure, the assumption is that the closure's lifetime will match that of the initialised value (e.g. the value will save the closure as a stored property). If in this case the lifetime of the closure is truly independent of the lifetime of the created Task handle, then that fact should be a documented guarantee. Otherwise, developers should assume that it is an implementation detail and not rely on it, IMO.

We should add appropriate documentation to the Task type to inform users how long their @escaping closures will live for.
Current documentation: https://developer.apple.com/documentation/swift/task#creating-a-task

While wording of the rationale could be expressed nicer I agree it's worth documenting this explicitly :-)
PRs welcome, or we'll get to it sometime 👍

rdar://112653483

Yeah sorry it's a bit lazily written. It's hot and humid today 🥵
Hopefully it's still clear enough.


Windows behind taskbar

Microsoft PowerToys version
0.62.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
I have a grid with no space between the zones.
✔ Expected Behavior
The bottom of the windows at the bottom of the screen should still be visible.
❌ Actual Behavior
The base of the windows are behind the taskbar.
Other Software
Windows 11

Now I'm on 0.62.1 and it seems to be good now, however I didn't see it in the patch notes. Also, there was a Windows update since then too.

did have this issue too, only on not-main screens, now on 0.63.0 problem vanished, can probably close this issue....

I wasn't getting this on 0.62.1 and its back with 0.63.0. Seems to happen when powertoys starts with windows with administrator mode enabled. if it occurs, closing powertoys and restarting it fixes it

This is a /dup of https://github.com/microsoft/PowerToys/issues/10903.
Thanks!


feat: Add Happenstance Games sponsor card

Adding Happenstance sponsor.
@VaclavElias is this styling fine? Can you suggest a way to make those cards more even in height?

there seems to be a typo in the link...

Yes, there is a way to make it same, let me have a look.

Here, the inline styling is ok.

A visual live-programming environment that takes you from rapid prototyping to final production.

            Visit

                Sponsor
                Golden
                Technology
                Visualisation
                Partner

An indie game studio with a primary focus on virtual reality (VR) experiences.

            Visit

                Sponsor
                Platinum
                VR


12 task 2b primary locations work

When complete, this PR will allow us to assign people to actual primary locations. See #12 for details

A couple of errors thrown by ruff that I think we could relax:

G004 Logging statement uses f-string
EM101 Exception must not use a string literal, assign to variable first

What do you think @sgreenbury ?

@Hussein-Mahfouz: this looks great, I have updated the notebook and scripts the following changes:

Update region to Leeds only
Transform CRS from 27700 to 4326 for centroids no longer included with SPC
Update dep for uatk-spc
Remove recoding at start of notebook since already recoded (in second script?)
Fix remaining lints

It might be worth refactoring the scripts more extensively so their purpose is solely for processing the data (e.g. remove plots and other interactive aspects), but I think this would be better to look at in a new issue/PR.

Nice one! Happy to merge this :)

It might be worth refactoring the scripts more extensively so their purpose is solely for processing the data (e.g. remove plots and other interactive aspects), but I think this would be better to look at in a new issue/PR.

Yes agreed let's keep this one for a different PR. As discussed, the contents of the scripts might change so that we are dealing with all primary trips together


Release 1.0.0a2

MOTIVATION:

Share with the Mu development team.
Test with current master.
Get early feedback.

Released to PyPI at https://pypi.org/project/pup/1.0.0a2/. Closing.


Fix environment bgmode Canvas in GLES3

Viewport textures are now copied with transparency, if Environment has background mode "Canvas".
Fixes #36817

Looks like alpha was disabled intentionally in https://github.com/godotengine/godot/pull/15710
I have a feeling that this PR will re-introduce https://github.com/godotengine/godot/issues/11877 which #15710 solved.

Ok, is there another way to fix any of these two issues? I am not a professional in this

I'm not sure what a proper fix would be. And I'm not even sure the bug report is valid. Canvas Background doesn't create a viewport. It takes a snapshot of the current viewport which doesnt typically have alpha. If you try to read alpha from a viewport configured without alpha, you are going to end up breaking things.

OK, the canvas backgroundmode is pretty much useless in 3D with GLES3, without a fix ( this commit, or some other solution). A viewport with alpha configured shouldnt return black pixels instead of transparent. So it would be nice if someone could test if this actually breaks something or not

@lawnjelly What is the status of this?

No idea of the state of this particular bug (as it's 4.5 years old) or indeed whether it is a bug based on @clayjohn 's answer above.
As ever, feel free to review / investigate, I can't look at tonight.


[SPARK-39945][BUILD] Upgrade sbt-mima-plugin to 1.1.0

What changes were proposed in this pull request?
This PR aims to upgrade sbt-mima-plugin to 1.1.0.
Why are the changes needed?
This will bring the latest improvements and bug fixes.

https://github.com/lightbend/mima/releases/tag/1.1.0
https://github.com/lightbend/mima/releases/tag/1.0.1
https://github.com/lightbend/mima/releases/tag/1.0.0

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

The SparkR failure is irrelevant to this PR. Merged to master.
Thank you, @williamhyun , @HyukjinKwon , @LuciferYang .


Add support for installing msi packages that depend on oledlg.dll

After a long research and experimentation, while trying to install Crystal Reports Runtime for .NET, i have found out that the installation package depends on oledlg.dll.
As described here in more detail, this DLL file is not included on the Windows Server Core container :
[Windows 2016 container and Crystal Reports Runtime]
(https://social.msdn.microsoft.com/Forums/sqlserver/en-US/20588e86-c8fa-450a-8dad-77484eb9ef39/windows-2016-container-and-crystal-reports-runtime?forum=windowscontainers)
So in order to be able to install Crystal Reports, in any of the docker containers based on Windows Server Core, you need to manually extract oledlg.dll, from a full Windows Server machine, and copy it on your docker container.
After that, you should be able to install this specific package, and probably any other package that depends on that DLL.
Now, i would love to create a public repository, specific for users that need Crystal Reports support, but i i am not sure if i can upload a signed DLL from Microsoft in a public repository.
So, is there a way to overcome this issue, without the above 'hack', and without violating copyright?
My suggestion would be to include oledlg.dll in the Windows Server Core based containers, but i am sure that there is a reason for it not being already there.
Thanks in advance.

@shirhatti can you please route this to the right team?


Feature: Support Multiple Schemas

Feature: Support Multiple Schemas
This issue tracks work related to supporting multiple features in this Action. It has been brought to my attention (https://github.com/GrantBirki/json-yaml-validate/issues/6) that users are looking for a way to validate multiple files with multiple schemas.
Success Criteria:

Allow multiple schemas to be 'inputted' into this Action
Add a mapping of schema -> file so that the correct files are validated with the correct schemas
Update tests to support this use case

Cool. I think selecting json files explicity via input is the right way. I don't want all json files to be checked and I have different schemas for each file I want to be checked. Just sharing a real-life use case ;)

Has this been actioned upon yet? Currently hit a road block with this action because I'm specifying one single file and it's attempting to validate everything.

@andy-lawler-sbg It has not been completed yet. I have to prioritize other work at the moment and I'm not able to add this change. Pull requests are welcome though!
That being said, there are a couple of ways around this. You can tweak the inputs of this Action (either through the base_dir or one of the "exclude" options) to only validate or run against specific files. Then you could have a second (or more) workflows running with different schemas and pointing at different files that use said schemas. Its not pretty but it is a work around until this feature is added.

@GrantBirki Adding the options json_include_regex and yaml_include_regex as a first step would also really help, especially if your JSON files are all in the same directory and if you have multiple schemas (so your json_exclude_regex becomes (too) complex).
Then you could do the following:
jobs:
  validate-json:
    name: Validate JSONs
    steps:
      - uses: actions/checkout@v4

      - name: Validate index JSON files
        id: index-json-validate
        uses<EMAIL_ADDRESS>        with:
          json_schema: ./schemas/index-schema.json
          # Validate files with prefix index_ and suffix .json
          json_include_regex: 'index_.*\.json$'

      - name: Validate topic JSON files
        id: topic-json-validate
        uses<EMAIL_ADDRESS>        with:
          json_schema: ./schemas/topic-schema.json
          # Validate files with prefix topic_ and suffix .json
          json_include_regex: 'topic_.*\.json$'


Impl new fn MagickWand::get_image_pixels

Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

Can you help fix the clippy error in CI? The new version clippy add lint derive_partial_eq_without_eq.

Can you help fix the clippy error in CI? The new version clippy add lint derive_partial_eq_without_eq.

@jmjoy Done!

Can you help fix the clippy error in CI? The new version clippy add lint derive_partial_eq_without_eq.

@jmjoy Done!

Thx~

@jmjoy The CI should be fixed now.

LGTM


Cyberpunk 2077

Game saves for Cyberpunk 2077 don't show up after a scan. Adding it as a custom game does not work either.
The correct entries appear in the manifest:
https://raw.githubusercontent.com/mtkennerly/ludusavi-manifest/master/data/manifest.yaml
<home>/Saved Games/CD Projekt Red/Cyberpunk 2077:
The screenshots folder from steam does show up in the scan.

Restarting the app after adding a custom entry worked. I then removed the custom entry and restarted the app again and it continued to detect it. I'm not sure what happened there.

Did you play the game for the first time while Ludusavi was already open? When you open Ludusavi and do a backup/preview, it performs a full scan, but then if you do another backup/preview, it only re-scans the games it found before, unless certain settings change or you restart Ludusavi. It should always re-scan custom games, though.

I did not. I opened the app, clicked preview on backup mode, saw that only the screenshots were being detected, clicked on the edit icon and removed all but the relevant path, restarted, and it worked. I then removed the custom entry, restarted, and it continued to work.

Hmm, I don't have any idea what would cause that then, unfortunately :/

I'll close this out since it doesn't make any sense and it's currently working.

Re-opening. Looks like it's happening with Half-Life Alyx as well.

Except it's not detecting it at all currently, ever after restarting multiple times.


compute: add helper to return available AZs

Add a new function, named ListAvailableAvailabilityZones, that return
a slice of AZs that are actually available.
Note: it uses availabilityzones.List() which doesn't require admin
privileges (comparing to availabilityzones.ListDetail() which does).

WIP for now, I'm currently testing it.

@jtopjian hey, do you think this one would be fine?

@EmilienM Yeah, this gophercloud/utils repo is pretty flexible with what is accepted. Let me know if/when this is ready to be merged 🙂

@EmilienM Yeah, this gophercloud/utils repo is pretty flexible with what is accepted. Let me know if/when this is ready to be merged slightly_smiling_face

Thanks ! yes this is ready in my opinion, unless something thinks the function should work otherwise. I'll try to get someone else to review it before EOD but if you don't see any comment feel free to land it.

:+1:  LGTM!

Thanks for your quick review @jtopjian


Navigate incorrect screen in case switch account on token detail screen

Describe the bug
Version test: v1.0.6(180)
To reproduce the bug
Steps:

Go to the Token detail screen
Switch the account and observe the displayed screen

Actual: Don't navigate to the Homepage screen
Expect: Navigate to the Homepage screen

Version test: v1.0.6(182)
Devices test: IP 11
Validation passed.


Try to fix gitignore and name_list_data.js

Git keeps saying i've got an extra file hanging around, but it should be there and be ignored.

coverage: 94.59%. remained the same
when pulling 9101ea380ed13a26642c3db3e19b816024a1b3f9 on nimmo-fix-gitignore
into 95a62cc03d2b049d7ac511afa4b17a224c79d788 on main.


Fix Traits reference

It took me a while to figure out why this wasn't working in my server, but after some testing, it turns traits are in fact needed to be referenced with an unlockable prefix.

Hello!
I'm not sure what you are trying, but this works on my side:
var engineer = SkillCreator.createNewSkill("test:engineer", "test:textures/skills/engineer_back.png");
engineer.name = "Engineering";
engineer.setLevelCap(10);
engineer.setSkillPointInterval(500);
engineer.setBaseLevelCost(999);
engineer.setRankIcon(0, "immersiveengineering:textures/items/tool_manual.png");
engineer.setRankIcon(1, "immersiveengineering:textures/items/tool_wirecutter.png");
engineer.setRankIcon(2, "immersiveengineering:textures/items/toolbox.png");
engineer.setRankIcon(3, "immersiveengineering:textures/items/tool_hammer.png");

var elec1 = mods.compatskills.TraitCreator.createTrait("electricity", 3, 3, engineer, 50, ["test:engineer|2"]);
elec1.name = "Electricity I";
elec1.description = "Charge up, young one, for it's time to harness the wonderful power of electricity";
elec1.changeIcon("test:textures/unlockables/electricity.png");

var mec1 = mods.compatskills.TraitCreator.createTrait("mechanics", 2, 3, engineer, 50, ["test:engineer|2"]);
mec1.name = "Mechanics I";
mec1.description = "Force equals mass times acceleration! The gravity of this is impressive!";
mec1.changeIcon("test:textures/unlockables/mechanics1.png");

var mec2 = mods.compatskills.TraitCreator.createTrait("mechanics2", 2, 2, engineer, 50, ["test:engineer|4", "test:electricity"]);
mec2.name = "Mechanics II";
mec2.description = "Let's gear things up!";
mec2.changeIcon("test:textures/unlockables/mechanics2.png");

var car = mods.compatskills.TraitCreator.createTrait("cars", 0.5, 2.3, engineer, 50, ["test:engineer|6", "trait|compatskills:mechanics2"]);
car.name = "Cars";
car.description = "Carry on, do your thing.";
car.changeIcon("test:textures/unlockables/cars.png");

Please ping me on the CraftTweaker discord so as not to get an email on every conversation.


Add Canopy and Post-Halving test vectors

Motivation
We want to test Post-Canopy blocks on mainnet, and Post-Halving blocks on testnet.
Solution

Add post-canopy mainnet block test vectors
Add post-halving testnet block test vectors

The code in this pull request has:

[x] Documentation Comments
[x] Existing Unit Tests and Property Tests

Review
@oxarbitrage wants this change for #1903
Review Note
GitHub displays zebra-test/src/vectors/block-main-1-046-401.bin as an empty file in the unified diff view, but it actually contains 72 kB of binary data.
Related Issues
Closes #1099
Closes #1104
Follow Up Work
We'll need to do something similar for NU5.

@oxarbitrage just a note for your review:
GitHub displays zebra-test/src/vectors/block-main-1-046-401.bin as an empty file in the unified diff view, but it actually contains 72 kB of binary data.


allow custom wrangler config to wrangler dev

💡 Feature request
please allow giving wrangler dev a specific wrangler toml config file, same as with publish
Overview and problem statement
allow giving wrangler config path to wrangler dev command.
Basic example
wrangler dev -c some-folder/wranger.toml

Hey, thanks for submitting this request. Could you elaborate on why you have a seperate toml file just for dev?

Hey :) yea, so we just want to be able to arrange these files in a different folder structure instead of having them at the root,
to be more specific, we got a wrangler folder with
dev.toml
prod.toml
where prod.toml file is divided into 2 environment - staging/production
and dev.toml are settings to run locally

I believe this works with the --config <path> flag now, I tried it myself and it works. I'll close this issue for now, but let me know if it doesn't work as expected.


ADJUST1-557 DR View remand

On hold whilst we await new design requirements for multiple court names being shown


chore: fix confirmed modal

Description

Fix confirmed modal spacing, close button, and twitter -> x
This PR addresses two Mint Modal related P0 tickets:

https://www.notion.so/lazertechnologies/72fceb443e3842debb9139a62d4ec37a?v=8331767752974fcdae4d0866e80975d0&p=5b7dd786f622465483a3af442f84ce03&pm=s
https://www.notion.so/lazertechnologies/72fceb443e3842debb9139a62d4ec37a?v=8331767752974fcdae4d0866e80975d0&p=46474161aaf14ec1aa881aa2c910e666&pm=s

Ticket(s)

69

Deploy Notes
Notes regarding deployment of the contained body of work. These should note any
db migrations, nginx routes, infrastructure changes, and anything that must be done before deployment.

[ ] Need to add environment variables

ENV_VAR=

Screenshots (if appropriate)

Review Error for wilsoncusack @ 2023-08-10 17:46:16 UTC
User failed mfa authentication, see go/mfa-help

Review Error for aflock @ 2023-08-10 17:47:00 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

Review Error for wilsoncusack @ 2023-08-10 17:50:38 UTC
User failed mfa authentication, see go/mfa-help


Text changes in webshop view

Change the text in the screenshot to following:
Gebe hier die Adresse Deines Online-Shops ein:
Dein Online-Shop
speichern

The text ad the button are not as stated above in the requirement.

Needs to be changed to "Dein Online-Shop". Please change the  spelling of "Adresse" also

@Dipanjana1990 all buttons should start with a capital letter.
typo is corected

The spelling of "Online-shop" is now corrected.
Speichern should ideally start with small s but is not that big a issue


I ported this repo to the Kotlin language

Hey, thank you for this great work.
I took some time to port this code over to Kotlin and used the same license. It can be found at https://github.com/darvelo/fractional-indexing-kotlin with acknowledgements to this repo. Please let me know if it's okay to make this port public.
All the tests were ported as well and they all pass.

Of course, please do. Also if the port is meant to be bytewise compatible with the js impl you may want to note that in the readme.

Great, thanks. Not sure what you mean by bytewise compatible. I had to make a few minor changes to fit the Kotlin language and I'm not entirely sure the port is 100% the same, only that all the existing tests pass. 😄

I mean if it is the intent that this will generate same strings as js port
for any given input.
On Wed, Jul 5, 2023 at 7:24 AM David Arvelo @.***>
wrote:

Great, thanks. Not sure what you mean by bytewise compatible. I had to
make a few minor changes to fit the Kotlin language and I'm not entirely
sure the port is 100% the same, only that all the existing tests pass. 😄
—
Reply to this email directly, view it on GitHub
https://github.com/rocicorp/fractional-indexing/issues/17#issuecomment-1621868363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAATUBFSEYBSA7WBUHVX3I3XOV2IVANCNFSM6AAAAAAZ65LUKY
.
You are receiving this because you commented.Message ID:
@.***>

--
a (phone)

Cool, I added a link here: https://github.com/rocicorp/fractional-indexing#other-languages

Awesome, thanks 🎉


[BUG] ModuleNotFoundError when using cmdclass option in PEP517-style build

setuptools version
setuptools===60.2.0
Python version
Python 3.8
OS
Ubuntu 20.04
Additional environment information
build 0.7.0
Description
Having the cmdclass option defined in setup.cfg causes python -m build to fail with a ModuleNotFoundError.
Expected behavior
I expect to be able to customize/override setuptools commands in a project with a PEP 517-style build system with no setup.py.
The code for the overriden/customized commands resides in a python module at the root of the repo and is being pointed out with the cmdclass option in setup.cfg.
How to Reproduce

Download and unzip this minimal example: example.zip
Move to the top folder of the unzipped contents
Issue python -m build
Behold, no source or wheel distribution gets built. All we get is a ModuleNotFoundError

Output
zluudg@computer > python3 -m build
/home/zluudg/.local/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (setuptools==60.2.0, wheel)
* Getting dependencies for sdist...
Traceback (most recent call last):
  File "/home/zluudg/.local/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 363, in <module>
    main()
  File "/home/zluudg/.local/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 345, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/home/zluudg/.local/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 297, in get_requires_for_build_sdist
    return hook(config_settings)
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/build_meta.py", line 167, in get_requires_for_build_sdist
    return self._get_build_requires(config_settings, requirements=[])
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/build_meta.py", line 143, in _get_build_requires
    self.run_setup()
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/build_meta.py", line 158, in run_setup
    exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 1, in <module>
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/__init__.py", line 155, in setup
    return distutils.core.setup(**attrs)
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 122, in setup
    dist.parse_config_files()
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/_virtualenv.py", line 21, in parse_config_files
    result = old_parse_config_files(self, *args, **kwargs)
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/dist.py", line 804, in parse_config_files
    parse_configuration(
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 150, in parse_configuration
    options.parse()
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 498, in parse
    section_parser_method(section_options)
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 469, in parse_section
    self[name] = value
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 222, in __setitem__
    value = parser(value)
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 654, in _parse_cmdclass
    return {k: resolve_class(v) for k, v in self._parse_dict(value).items()}
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 654, in <dictcomp>
    return {k: resolve_class(v) for k, v in self._parse_dict(value).items()}
  File "/tmp/build-env-dwvi2g6f/lib/python3.8/site-packages/setuptools/config.py", line 650, in resolve_class
    module = __import__(pkg_name)
ModuleNotFoundError: No module named 'custom_build'

ERROR Backend subproccess exited when trying to invoke get_requires_for_build_sdist

Code of Conduct

[X] I agree to follow the PSF Code of Conduct

Hi @zluudg, thank you very much for reporting this!
Unfortunately, this feature is not yet fully supported by setuptools via setup.cfg only via setup.py. The reason is that build_meta does not guarantee the project directory is appended to sys.path (only build_meta:legacy guarantees that).
As a workaround, you could try:
PYTHONPATH=$PWD python -m build

But the good news is that this problem might be solved in the near future (via #2970)

Thanks for the tips and for the quick reply! I think I'll go with the setup.py-approach for now while keeping an eye on your PR. Good luck with that!

Another option could be to supply the cmdclass as a plugin. If you were to implement custom_build as a library like lzuudgs_custom_build, then declare that dependency in your build-system.requires (pyproject.toml), then it would be available to the setup.cfg for PEP 517 builds.

That seems like an interesting option as well, @jaraco. But would I have to upload my custom_build library to PyPI? Or is there some way to keep it in the same repo as my project and still specify it as a dependency in pyproject.toml?

It would have to be on PyPI or otherwise discoverable by pip, so not a good solution if the implementation is local to this one project.

Ah, I see. I think I'll stick with my setup.py-approach for now since I have no hard requirements to be "pure PEP 517". But it's very good for me to know what options I have.
Thanks a lot for taking the time, @abravalheri and @jaraco. It's ok for me if you want to close this issue.
Cheers!

Thanks @zluudg, I think it is ok to leave it open now as a reminder to add a test case if #2970 gets merged 😝

Sure, no probs!

Ok, I revisited this issue and considering the changes in the mentioned PR, I think this specific problem will not be solved, but a similar problem will: when the cmdclass reside within the package being published. So I think the best options here are keep using setup.py or use Jason's suggestion.


Full screen button not working on Safari 8.0.3

I also tested in Version 8.0.2 (10600.2.5) over Mac OSX 10.10.1.
Notify: SB/4576792

Does it throw a JavaScript error?

@javierarce No, it doesn't throw a Javascript error.
I've been researching, and it seems to be a Bug with Safari.
References:

Stackoverflow I : This is known Safari bug. Sol-> ...(/Safari/.test(navigator.userAgent) ? undefined : Element.ALLOW_KEYBOARD_INPUT)
Stackoverflow II : *Unfortunately, there isn't a good way to even do feature detection, since element.ALLOW_KEYBOARD_INPUT is defined in Safari, *
HTML5gamedevs : "For security reasons, most keyboard inputs have been blocked in the fullscreen mode. However, in Google Chrome you can request keyboard support by calling the method with a flag:
docElm.webkitRequestFullScreen(Element.ALLOW_KEYBOARD_INPUT);
This does not work in Safari, and the method won’t be called.
Hack.mozilla.org

I've done a patch and I'm "pull requesting" it.

:ok_hand:

merged.


Testing with request,

How make  testing with requests LIB
I'm Using pytest
My fixture
@pytest.fixture
async def server_cli(loop, app, sanic_client):
    app = create_app('test')
    server = await app.create_server(
        return_asyncio_server=True,
        asyncio_server_kwargs=dict(start_serving=True),
    )

i 'm testing
How get url by  name ?
def test_index(server_cli):
    print(server_cli)

    r = requests.get('MY URL name here')
    print(r.json())
    assert 2 ==1

Hi @johndiego
While it is possible to use the requests library like you have attempted here, it is a lot of work to set up boilerplate code to get it working.
Instead, it is recommended you use the pytest-sanic library, like is shown in the documentation here: https://github.com/huge-success/sanic/blob/master/docs/sanic/testing.rst#pytest-sanic

You also have the option of using the built in testing client as used by the Sanic internal unit tests:
request, response = app.test_client.get('/')

Or...
request, response = await app.asgi_client.get('/')


Purpose unclear from README: missed marketing opportunity

I have a feeling lorri might be exactly what I'm looking for in my development workflow, but it's extremely difficult to determine that from the immediately-visible project docs, which provide very little in the way of overview. The project README says that lorri combines nix-shell and direnv somehow, but doesn't explain the motivation, and what the end result or benefit of using lorri will be.
The example README has a quite compelling paragraph about editor integration, though it talks about Emacs specifically - this is relevant to me as an Emacs user, but it might not resonate with everyone, and doesn't give much of a clue about how lorri works.
I don't understand enough about lorri (yet), but I'd suggest adding just a little text to the main README to briefly outline:

The problem (e.g. it's hard to integrate editors with nix-shell because x & y?)
The solution (e.g. lorri combines nix-shell and direnv, so that direnv environments do something magical with nix when you're working in nix projects?)
Scope for use (e.g. editor integration, command line)

Hope that helps! Now I'm going to dig in a bit further.

I've come across this repo a few times, and as a beginner user of Nix who loves all things deterministic, I agree with this assessment. I've always had a feeling there's some reason why Lorri would be useful but couldn't see how it fit into my standard development workflow.
I did want to say, however, that I just found Tweag's blog post on Lorri which really helped me understand why it's more useful than direnv's use nix directive: https://www.tweag.io/posts/2019-03-28-introducing-lorri.html
Repurposing some of that content in this repo's README, or even just linking to it, would likely go a long way to helping people like me get why Lorri is really cool.

I did want to say, however, that I just found Tweag's blog post on Lorri which really helped me understand why it's more useful than direnv's use nix directive: https://www.tweag.io/posts/2019-03-28-introducing-lorri.html
Repurposing some of that content in this repo's README, or even just linking to it, would likely go a long way to helping people like me get why Lorri is really cool.

Thanks @jamesottaway! In the spirit of incremental improvement, I've done just what you suggested and added a link to the announcement blog post here: https://github.com/target/lorri/pull/234.
Ideally I think we should probably aim for the README to be mostly more self-contained, but adding that link now is a step towards making it clearer to anyone checking out lorri why they might want to use it.


SQL Lab doesn't seem to render Presto maps correctly

SQL Lab doesn't seem to render Presto maps correctly.

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Expected results
{a=1,b=4,c=2}
Actual results
[object Object]
Steps to reproduce
SELECT
    HISTOGRAM(som_column)
FROM
    some_table

Notice: this issue has been closed because it has been inactive for 499 days. Feel free to comment and request for this issue to be reopened.


Replaced State_a and so on into solid and so on

The tutorial contained a small bug in that the say_goodbye callback was (in the text) associated to State_a, but later executed when the sublimate trigger was called on the state `solid'. I replaced the names State_a and so on into the states solid and so on to line up this example of callback with the rest of the tutorial

Great, thanks!


Question 39

I have added question 39 based on Destructuring Object Literal

@kirandash I will create  a new pr for it , I somehow messed up this one, my question-39 is not visible in my repositery

@kirandash I will create a new pr for it , I somehow messed up this one, my question-39 is not visible in my repositery

ok. Go ahead. Or if you need help, feel free to let me know: I can do the changes on my side and push


The Crew gets stuck at loading with DXVK

Game stucks at the end of loading - just before showing the map, I guess: this is the static image I get, though I can hear the environment sounds.

I have not managed to collect an apitrace (I've got the latest mingw-compiled version from their website and launched it as in the issue submitting guidelines) of the game running with wined3d; every time, even with --output parameters defined no file would be produced, so only DXVK logs are included.
The game runs fine (well, there are some issues, but wine-d3d ones likelly) without DXVK.
Software information
The Crew (latest version from UPlay, launched using wine TheCrew.exe with UPlay running)
I have copied 32-bit DXVK libs to uplay.exe-containing directory and 64-bit libs to TheCrew.exe-containing directory.
Graphics are like this: everything at Medium, but:

Textures: High
Anti-Aliasing: Off
Ambient Occlusion: Off
Temporal AA: Off

System information

GPU: AMD Radeon R7 370 2GB (MSI Armor 2X)
Driver: AMDGPU @ linux-lqx 4.15.11; Mesa 17.3.7 (RADV) + LLVM 6.0.0
Wine version: 3.4-staging (Arch's wine-staging-nine built from source)
DXVK version: master (https://github.com/doitsujin/dxvk/commit/25669099173e1d82484a1538fb559a4b4577c74d)

Apitrace file(s)

Not available

Log files
TheCrew_d3d11.log
TheCrew_dxgi.log

Hm, should I upload more DXVK logs with some of its environment variables enabled for debugging purposes?

dont know wether this is working for this special case but may its worth a try:
run qps search for the stuck exe file right klick on it and chose continue if available this does it for me with "the witcher 3"

Please test with 44d8d6b8c3eaf48fc55de5321b56fce16fd0cbd1, it fixes a regression that was introduced with 0bdae4f9303626e90ca4d8e5d75b017604160835 that would cause lockups in a lot of games.
Also, if you encounter any other issues, please consider using mesa-git as 17.3 is quite broken for a lot of games.

@daschaffert what is "qps"?..

@daschaffert what is "qps"?..
@doitsujin alright, will try now and report here. About mesa - yep, I know that it's a crappy release, but I stick to stable releases and 18.0 is only supposedly going to be out tomorrow + the latest 17.3.7 contains fresh Vulkan driver fixes, so the graphics stack here is probably not the main thing to worry about :)

@doitsujin
I have disabled all the staging options I had (csmt, dxva accel & eax) enabled.
env DXVK_DEBUG_LAYERS=1 env DXVK_LOG_LEVEL=debug wine .wine/drive_c/Program\ Files\ \(x86\)/Ubisoft/Ubisoft\ Game\ Launcher/games/The\ Crew\ \(Worldwide\)/TheCrew.exe
TheCrew_d3d11.log
TheCrew_dxgi.log
env DXVK_DEBUG_LAYERS=1 env DXVK_LOG_LEVEL=trace wine .wine/drive_c/Program\ Files\ \(x86\)/Ubisoft/Ubisoft\ Game\ Launcher/games/The\ Crew\ \(Worldwide\)/TheCrew.exe
TheCrew_d3d11.log
TheCrew_dxgi.log

@mradermaxlol: qps is basicly "ps" with qt-gui you can watch all processes and even "reanimate" stuck processes

for me sometimes wine processess get stuck then i use qps leftclick on the process and select continue...

kind of linux taskmanager

@mradermaxlol While it's probably not responsible for the issue, 17.3.7 (and even 18.0) do not contain all the driver fixes for DXVK, and there were quite a few critical issues.
As for the game itself, I can't really debug it without an apitrace and the log files aren't really telling me anything.

@doitsujin okay, I got it. About the apitrace - could you please guide me through it, maybe I'm doing something wrong? I'll ask about the version I'm using straight away - is a 2017-something version from people.freedesktop.org compiled with MinGW the right one? If yes, how should I get the trace with it?
And nope, I'm not experiencing any GPU hangs, I can easily switch to another virtual desktop and use KSysGuard to terminate the game process.

I should be able to test with my GTX 1070, would that help at all?

Confirming that it works with my GTX 1070 (looks way better than stock wine too)

Looks like it may actually be the Vulkan driver issue... Damn :(
Anyway, will try to test with mesa master today, will see if stuff changes.

@doitsujin tested with mesa master as of 15 minutes ago with DXVK compiled right after mesa - same result, hangs on the loading screen with sound playing.

Tried to get the trace again with MSVC build of apitrace - still no luck. Is there something wrong with the way I'm running it?
wine apitrace-msvc/x64/bin/apitrace.exe trace -a dxgi .wine/drive_c/Program\ Files\ \(x86\)/Ubisoft/Ubisoft\ Game\ Launcher/games/The\ Crew\ \(Worldwide\)/TheCrew.exe

Nothing new with v0.40 :(
Riding mesa-git and llvm-svn btw.

@doitsujin still the same hang on https://github.com/doitsujin/dxvk/commit/320cebb8f975434d46ab91987108fe86742ee9a6 with {lib32-,}mesa-18.0.0-3 and llvm-6.0.0-4 + lib32-llvm-6.0.0-1.
I will try to test with mesa-git & llvm-svn ASAP and probably report at https://github.com/doitsujin/dxvk/issues/252

@doitsujin I hope I reverted it the right way :/

Hum ... Nope.
If you look at the bottom of the page, you'll see which file are modified by the patch.
If fact, you must to revert this patch :
https://reviews.llvm.org/file/data/e6m7q5pp2ypowi34qnw3/PHID-FILE-teyqmcsmmssxhbp7g2cn/D40556.diff

@berillions ooookay, so should I do svn merge -c -40556 {list of files affected in the patch mentioned} or what? I'm relatively dumb when it's about version control systems :/

Not an expert on SVN, I'm using the llvm-git mirror since it's more convenient for me.
git revert b0efc4fd6672f27ae2cbf28ef290d25a0da1dc08 in case anyone is using that.

Alright, is it possible, then, to initialize a git "repository" with already fetched svn sources pointing to their git mirror to revert the commit? I can't find any Arch packages with llvm using their git mirror, so I'm stuck with editing llvm-svn sources :(
@doitsujin or is it possible to create a patch based on the modifications made by git revert {that id} command and upload it here?

Why don't you just pull the sources from here?

@mradermaxlol : If you have the commit, you can create a patch by git format-patch -1 SHA and revert it by patch -R -p1 < Your_Patch
0001-AMDGPU-SiFixSGPRCopies-should-not-modify-non-diverge.patch.zip

@doitsujin reported in https://github.com/doitsujin/dxvk/issues/252

I can confirm the issue on Mesa 18 + wine 3.6-staging-pba + latest DXVK git from today. AMD RX 480 8GB - not a system hang, just the game hangs, I can alt+tab and get out of the process.
Is there any more debugging logs needed? If so, which ones?

Logs are pretty much useless. The main problem with this issue and all the other DXGI-related issues is that I cannot reproduce them locally, but even if I could they would be extremely hard to debug because it's not obvious for what reason a game hangs.
And reasons for that are:

Side effects caused by DXGI's window management functions are entirely undocumented.
Because of the convoluted message callback system in Win32, the order in which DXGI executes window-related functions and makes internal state changes visible to the application is actually crucial for some applications to work correctly, but very hard to figure out.
Some games rely on implementation details, e.g. Dark Souls 3 which falls back to 800x600 if the reported list of display resolutions is not ordered correctly.

This is the kind of stuff we're talking about here. I'm just not able to do anything about these issues unless I can actually reproduce them and at least try to figure out what's wrong.

Works fine for me. (using async build)

@sambow23 does it work when you enter a game too? Cause it does still freeze for me when loading the game.

So just tried with 0.72, and now the game freezes on the very first ("epilepsy" warning) screen of the game. When I click it then goes black, and nothing more happens.
Do you think this is now a new error? Should I gather some logs?
Using Mesa 18.3 + LLVM 8 compiled like ~2 weeks ago.

The game's been working for quite a while now, so it's probably a good idea to close this issue :)


Passing parameters during production build.

Is it possible to pass parameters during production build?
I have a use case to build with different themes for different clients. Can I pass a parameter like  'npm run build: prod  clientStyle.css ' such that the app uses the clientStyle.css as the theme for the build.
Any help would be gladly welcomed.
Thanks.

Thanks @andreyjkee . I just made separate config files for each client and performed the build in production mode with their respective style sheets. So,now I have the stylesheet bundled during build time itself.


Info for authorize callback info for pipeline should only be root

Rancher versions:  2.0 master 2/26
Steps to Reproduce:

Create a cluster
Go to Cluster/Tools/Pipeline

Results:  Information for the Authorize callback info for pipeline should only be root and not include /verify-auth

Version - 2.0 master 2/27
Verified fixed


Updated to latest rust

This adds the allow(unstable) attribute, which is not ideal, however I think it's needed for now, seeing as the rustc and syntax crates which are used here are both marked as unstable.

@gchp Ah sorry, I saw your PR to modifier (and saw it was failing here) so I came here and updated this myself already.

@reem no worries!


Add Homebrew install instructions

chars has been added to Homebrew 🎉

Great news, thanks so much!
bors r+

@antifuchs Sorry to bother you but I accidentally omitted the /formula/ URL path segment. The correct URL for the Homebrew formula is https://formulae.brew.sh/formula/chars#default Do you want me to do follow-up PR fixing it?

Oh, whoops - I should have checked that URL too. I'm happy to just commit a fix to that, thanks for letting me know (:

Oh, whoops - I should have checked that URL too. I'm happy to just commit a fix to that, thanks for letting me know (:

Thanks for cleaning up my mess. 👍 I should've checked it in the first place but in my defense couldn't do it at the PR creation time because there is a time delay between the formula being accepted and the formula's static info page being generated.

It's all good - thanks for your contribution, I wouldn't have noticed that the formula had gone in otherwise!


[SPARK-31038][SQL] Add checkValue for spark.sql.session.timeZone

What changes were proposed in this pull request?

The spark.sql.session.timeZone config can accept any string value including invalid time zone ids, then it will fail other queries that rely on the time zone. We should do the value checking in the set phase and fail fast if the zone value is invalid.
Why are the changes needed?

improve configuration
Does this PR introduce any user-facing change?

yes, will fail fast if the value is a wrong timezone id
How was this patch tested?

add ut

Merged build finished. Test PASSed.

Test build #119315 has started for PR 27792 at commit 72dce3c.

cc @cloud-fan @maropu, thanks for review.

Test build #119322 has started for PR 27792 at commit fa7a372.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24059/
Test PASSed.

Test build #119315 has finished for PR 27792 at commit 72dce3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #119322 has finished for PR 27792 at commit fa7a372.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119322/
Test PASSed.

Test build #119357 has started for PR 27792 at commit 641b74b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24095/
Test PASSed.

Test build #119357 has finished for PR 27792 at commit 641b74b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119357/
Test PASSed.

thanks, merging to master/3.0!


Creation and initialization of the relay SQLite3 database are not atomic

In database.py, get_db:
    must_create = (dbfile == ":memory:") or not os.path.exists(dbfile)
    try:
        db = sqlite3.connect(dbfile)
    except (EnvironmentError, sqlite3.OperationalError) as e:
        raise DBError("Unable to create/open db file %s: %s" % (dbfile, e))
    db.row_factory = dict_factory
    db.execute("PRAGMA foreign_keys = ON")
    problems = db.execute("PRAGMA foreign_key_check").fetchall()
    if problems:
        raise DBError("failed foreign key check: %s" % (problems,))

    if must_create:
        log.msg("populating new database with schema v%s" % target_version)
        schema = get_schema(target_version)
        db.executescript(schema)
        db.execute("INSERT INTO version (version) VALUES (?)",
                   (target_version,))
        db.commit()

If no database exists and the process crashes any time after sqlite3.connect but before db.commit then the system ends up in an inconsistent state from which it cannot recover without manual intervention - a database file exists but has no schema.  Subsequent attempts to open it will fail, most likely with an error about the version table not existing.
For example:
starting wormhole relay server
Traceback (most recent call last):
  File "/app/env/bin/wormhole-server", line 11, in <module>
    sys.exit(server())
  File "/app/env/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/app/env/local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/app/env/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/app/env/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/app/env/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/app/env/local/lib/python2.7/site-packages/click/decorators.py", line 27, in new_func
    return f(get_current_context().obj, *args, **kwargs)
  File "/app/env/local/lib/python2.7/site-packages/wormhole/server/cli.py", line 74, in start
    start_server(cfg)
  File "/app/env/local/lib/python2.7/site-packages/wormhole/server/cmd_server.py", line 42, in start_server
    twistd.runApp(c)
  File "/app/env/local/lib/python2.7/site-packages/twisted/scripts/twistd.py", line 25, in runApp
    _SomeApplicationRunner(config).run()
  File "/app/env/local/lib/python2.7/site-packages/twisted/application/app.py", line 380, in run
    self.application = self.createOrGetApplication()
  File "/app/env/local/lib/python2.7/site-packages/twisted/application/app.py", line 440, in createOrGetApplication
    ser = plg.makeService(self.config.subOptions)
  File "/app/env/local/lib/python2.7/site-packages/wormhole/server/cmd_server.py", line 24, in makeService
    allow_list=self.args.allow_list,
  File "/app/env/local/lib/python2.7/site-packages/wormhole/server/server.py", line 43, in __init__
    db = get_db(db_url)
  File "/app/env/local/lib/python2.7/site-packages/wormhole/server/database.py", line 57, in get_db
    raise DBError("db file is unusable: %s" % e)
wormhole.server.database.DBError: db file is unusable: no such table: version

(Yes, actually encountered this in real usage.)

Fixed in #189, I forgot to close this.


Untrack ipynb in linguist

Description

Motivation and Context
Github linguist autoselects the language for a repository. For coxeter, this results in the following:

Listing the package as primarily jupyter notebook could be confusing,and as far as I know there is no GLSL code. Updating the .gitattributes is a minor fix but a useful one nonetheless
Types of Changes

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Breaking change1

1The change breaks (or has the potential to break) existing functionality.
Checklist:

[x] I am familiar with the Contributing Guidelines.
[x] I agree with the terms of the Contributor Agreement.

It appears that https://github.com/glotzerlab/coxeter/blob/master/paper/figure1/shape_images/tri.txt.vert is the GLSL file:
https://github.com/github-linguist/linguist/blob/d190ad88af555bb2ee213aa64205f2b9a97a077d/lib/linguist/languages.yml#L2230-L2256

It should be possible to tell linguist to only run on the source directory - I'll try that

$ github-linguist
100.00% 360976     python

linguist-vendored untracks a folder in linguist, and subfolders must be added with parent/** instead of parent/*. This is all set now!

Merge appears to be locked to admins only - I could override, but is there a systematic setting to change to fix this?


Unable to compute Uniqueness/UniqueValueRatio

Describe the bug
Trying the lib on jupyter notebook, the example from quickstart. When trying to compute Uniqueness or UniqueValueRation facing java exception  'Method iterableAsScalaIterable([class java.lang.String]) does not exist'
To Reproduce
Steps to reproduce the behaviour:

start jupyter notebook in docker, one of the latest images from jupyter team:
$ docker run -p 8888:8888 jupyter/all-spark-notebook:a0a544e6dc6e
Install pydeequ from inside jupyter notebook
!pip install pydeequ
Follow the quickstart instructions to set up spark session and run deequ analysers. At this point everything works, however adding analyser .addAnalyzer(Uniqueness("b"))  Brings the error. (screenshots attached).

Screenshots

Additional context
I have tried few different combinations of spark/scala/amazon deequ libs versions but did not manage to make this work.

Hi! Apologies for the late reply amidst the holidays, but my guess is that your spark session is unable to access the  deequ-1.0.3.jar. We leverage ivy to download the jar from maven, so perhaps there is a disconnect of where those jars are stored between docker and your main machine. From the looks of the screenshot, you listed your jars in /usr/local/spark/jars/ whereas ivy downloaded deequ-1.0.3.jar into /home/jovyan/.ivy2/jars/.
Does your notebook work with just running the addAnalyzer(Size())? That would reinforce the fact that the sparksession is unable to access the deequ jar.
Also, we have only developed and supported up to deequ-1.0.3, so please stick to that version!

Hi! Apologies for the late reply amidst the holidays, but my guess is that your spark session is unable to access the  deequ-1.0.3.jar. We leverage ivy to download the jar from maven, so perhaps there is a disconnect of where those jars are stored between docker and your main machine. From the looks of the screenshot, you listed your jars in /usr/local/spark/jars/ whereas ivy downloaded deequ-1.0.3.jar into /home/jovyan/.ivy2/jars/.
Does your notebook work with just running the addAnalyzer(Size())? That would reinforce the fact that the sparksession is unable to access the deequ jar.
Also, we have only developed and supported up to deequ-1.0.3, so please stick to that version!

Hi, thx for coming back. That is I thinks the issue:

I think for me the fix will be to find the image with compatible spark/scala versions, and configure pyspark with extra ivy2 path.
thx vm.

Hi, thx for coming back. That is I thinks the issue:

I think for me the fix will be to find the image with compatible spark/scala versions, and configure pyspark with extra ivy2 path.
thx vm.


Remove need to equip boost items for wildy bosses

🚀 Feature Proposal
To get the boosts from boost items for Callisto, Venenatis, Vetion, Scorpia, Crazy arch., Chaos fanatic+elemental, they have to be equipped  in the wildy setup. It makes sense since you would be risking the item, however it was apparently said by Magna that Wildy bosses will not have any pking mechanics added to them, making this redundant. Therefore, boosts should work from bank for these bosses.

Outdated with wildy rework


added assistant chat

Added chat function, delete/update code ability has not been added yet.

Looks great. Thanks making the change.


issues on trigger definition condition

The following template:
tosca_definitions_version: tosca_simple_yaml_1_3
topology_template:
  node_templates:
    node:
      type: tosca.nodes.Root # or any node type
  policies:
    - policy:
        type: tosca.policies.Root # or any policy type
        targets: [ node ]
        triggers:
          t1:
            event: event.type1
            condition:
              and:
                - state:
                    - equal: started
            action: []
          t2:
            event: event.type2
            condition:
              or:
                - state:
                    - equal: started
            action: []
          t3:
            event: event.type3
            condition:
              not:
                - state:
                    - equal: started
            action: []
          t4:
            event: event.type4
            condition:
              state:
                - equal: started
            action: []

is not supported by puccini 0.18.0:
$ puccini-tosca compile triggers_condition.yaml
PROBLEMS (4)
  file:....../triggers_condition.yaml
    @14,15 topology_template.policies{0}.triggers["t1"].condition.and: unsupported field
    @21,15 topology_template.policies{0}.triggers["t2"].condition.or: unsupported field
    @28,15 topology_template.policies{0}.triggers["t3"].condition.not: unsupported field
    @35,15 topology_template.policies{0}.triggers["t4"].condition.state: unsupported field
$

These four condition clause definitions should be supported, shouldn't them?

 I will work on implementing them.

For now I have implemented proper parsing and validation, but normalization remains a TODO.
This is somewhat challenging because the attribute name ... well, there's no way of validating that the target nodes actually have that attribute until runtime.

Thank you Tal.

This is somewhat challenging because the attribute name ... well, there's no way of validating that the target nodes actually have that attribute until runtime.

I think you could validate at compile time as 'state' is a declared attribute of the 'tosca.nodes.Root' type and its type is string compatible with the 'started' constant string passed to 'equal'.

But what if you don't use a node that derives from root? And what if you include nodes as your policy targets that derive from various hierarchies? The validation check would have to be done for each node type independently.
But I'm not sure it needs be validated. You could consider any node that doesn't have the attribute to immediately fail the condition. That seems reasonable to me and more flexible because it exactly allows the trigger to be filtered in this way. Remember that we are dealing with attribute assertions here, so it's only at runtime that they can be asserted anyway.
The spec is unclear about this. It's up to us to interpret its spirit.


Resolved import error for ExceptionNotFound

Currently, the module will not function as the example shows because the following Error is raised:
ImportError: No module named 'ExceptionNotSeen'
To avoid this error we would need to import everything as a wild card with the following:
from naiveBayesClassifier import *
Or we can namespace the ExceptionNotSeen module as shown in the commit.
I followed a similar structure to how the trainer imports TrainedData
from naiveBayesClassifier.trainedData import TrainedData.

thank you :+1:


Adjust billing calculations in send and bridge

Work Completed
Used decimal package to make accurate calculations for floating numbers.


🐛 Setup load combination have bad default argument

The Im input is not working

it looks like that you Im has been modified from int to bool.
I'll fix it for this milestone

it looks like that you Im has been modified from int to bool. I'll fix it for this milestone

You're right, my bad!


ShardWriter for numpy arrays

Simple question: if I am using a custom Pytorch dataset that returns a few numpy arrays (read from HDF5 files), how should I setup ShardWriter? I get "no handler for data" when I pass in normally (encoder=True below), and "ValueError: data doesn't map to a bytes after encoding (<class 'numpy.ndarray'>)" when encoder=False. Looking through the code, it looks like tenbin should be used, I'm just not sure how to use it. Do the dictionary keys have to correspond to handler extensions? They aren't custom key names? What do I do for multiple numpy arrays?
with wds.ShardWriter('shards/shard-%06d.tar',maxcount=1000,encoder=False) as sink:
    for idx,(X,target,index,weight) in enumerate(dataset):
        sink.write({
            '__key__': "%06d"%index,
            'data': X,
            'target': target,
            'weight': weight
            })

I see now I have to add a ".ten" extension to the keys. Still, an error is thrown, and looking closer it appears due to the fact that tenbin.py returns a bytearray, but SharWriter expects a bytes type, and so throws an error. Should the check instead be isinstance(v,(bytes,bytearray))?

The most convenient and common way of writing tensors in this context is to use Python/Torch's pickle function. You get that by using the ".pyd" extension. Your ShardWriter should probably look like this:
with wds.ShardWriter('shards/shard-%06d.tar',maxcount=1000) as sink:
    for idx,(X,target,index,weight) in enumerate(dataset):
        sink.write({
            '__key__': "%06d"%index,
            'data.pyd': X,
            'target.pyd': dict(target=target, weight=weight)
            })

Do the dictionary keys have to correspond to handler extensions?

In principle, you can use whatever you like for decoding. The default decoder uses standard file name extensions; only the last extension counts for decoding, but all extensions together are used as a key, so you can have multiple objects encoded the same way. Common extensions are:

.jpg, png, ppm: images
.pyd: Python/PyTorch pickle
.json: JSON-encoded data
.ten: custom fast tensor encoding (usually, .pyd is better)

get "no handler for data" when I pass in normally (encoder=True below)

Yes, that's because your "extensions" ("data", "target", "width") don't correspond to known file name extensions.
TODO:

improve documentation
better error messages

I've added several small example to the ShardWriter portion of the documentation that hopefully illustrate the different use cases a bit better.

The .ten and .tb extensions now work. However, in most cases, you should probably use .pyd.


Generator setting mistake requiring cleanup

I screwed up and marked two combos as Generator when they should have been utility. (I want to automate the adding of a result to existing combos, but instead I generated hundreds of new variants as well.)
Here are the two combos:
https://backend.commanderspellbook.com/admin/spellbook/combo/26401/
https://backend.commanderspellbook.com/admin/spellbook/combo/26402/
I think this requires dev work to clean up and remove the unwanted variants from the database.

False alarm, didn't realize it would clean itself up once everything was marked correctly and the job was run again.


York Region, Ontario, Canada is missing city and district data

York Region is missing city and district data.
District names are important for certain cities in York Region, namely Vaughan and Markham.  The locals tend to use the district name to refer to their town.

@Valachio is this an official part of the address? I know sometimes we have city names in the data and sometimes they are emoty. I'm wondering if York formally has this; sometimes the municipalities don't specify, and sometimes they do. Just curious. Thanks!!

does this work for you @Valachio http://insights-york.opendata.arcgis.com/datasets/address-points

@justinelliotmeyers Yes that link is where I fetched my data from originally.  There should be both district and city names - those fields are in that file you linked.


[cdc_stream] [cdc_rsync] Remove port args if port is not set

Right now, we always pass -p to ssh and -P to scp for ports. Don't do this if the SSH port is unset, so that ssh and scp use the default port 22. That's also the default port we set, but it's confusing if the port is also set in CDC_SSH_COMMAND and CDC_SCP_COMMAND as then the port is set twice. Note that the FIRST argument wins!
Edit: For ssh the first argument wins. For scp the second argument wins :o:

Fixed by PR #41


Add Salt content to internal UITK website

Note: This issue mirrors the internal UITK-10075 one, so that we can track this work on our GitHub project more easily.

There is a bunch of Salt-related content we need to publish, that is only relevant to JPM-internal UITK users. Given that it is relevant to UITK users and internal-only, it makes sense to add this to the internal UITK site.
Most likely, this will necessitate the addition of a new, top-level "Salt" section on the UITK website. Likely content we will add in there will be:

Details and timelines about how Salt will eventually replace UITK
UITK to Salt migration guides

In the interest of releasing quickly and preserving our very limited design & dev resources, this work must:

Avoid the need for new page layouts or styles

Recommendation is to reuse existing layouts from other sections

Avoid duplicating information that exists (or should exist) on the public Salt site

Recommendation is to link to relevant pages on Salt site wherever needed. This content should focus exclusively on UITK- and/or JPM-internal info that cannot go on the public Salt site

Salt page live on UITK


Language Server: Reloading modules causes Open Editors and Folders to not align

Latest Insiders 1.27.
Python 2018.8.0-alpha0
It takes a while for the language server to start (minutes).
during this time if you have a file open in open editors, the folder is not synchronized for Python files.
Similarly when this happens "reloading modules", synchronization is lost.
this can take minutes . In some case the synchronization never works  again.
Have to close the files and re-open the files for the sync to work

Start-up time is being worked on. As for the loss of synchronization, we will have a look.

I can't reproduce anything that takes that long to get going, but if your system is taking minutes to start up the language server then I suspect any analysis to get going will take minutes as well. On my machine with the latest language server in the development build it only takes several seconds to start and then once completed almost immediately picks up file changes (and this is starting with an empty file and then immediately pasting in an entire file to pick up on to try and trigger synchronization issues).
Do you happen to have a specific file that regularly causes problems?

We don't control the Explorer in the side bar at all, so it might be some way VS Code is waiting on some response due to its new showing of e.g. problem counts in the Explorer view.


CIS Certification

We will need to create a unique set of benchmarks for K3s.

Related to CIS story: https://github.com/rancher/k3s/issues/826

Related: Docs for k3s cis 1.5: https://github.com/k3s-io/k3s/issues/2541

Related: Docs for k3s cis 1.5: https://github.com/k3s-io/k3s/issues/2541

Related (RKE2) https://github.com/rancher/rke2/issues/350

For k3s, we just need the automated testing for CIS 1.6 integrated rancher

Validated using k3s v1.20.6+k3s1 and Rancher v2.5.8-rc12
In Rancher, I deployed CIS Benchmark app v1.0.400 with default values.yaml, which at the time of this writing is:
affinity: {}
alerts:
  enabled: false
  metricsPort: 8080
  severity: warning
global:
  cattle:
    clusterName: ''
    systemDefaultRegistry: ''
  kubectl:
    repository: rancher/kubectl
    tag: v1.20.2
image:
  cisoperator:
    repository: rancher/cis-operator
    tag: v1.0.4-rc5
  securityScan:
    repository: rancher/security-scan
    tag: v0.2.3-rc5
  sonobuoy:
    repository: rancher/mirrored-sonobuoy-sonobuoy
    tag: v0.16.3
nodeSelector: {}
resources: {}
tolerations: []

1.20.4 and below gives expected error: Error validating ClusterScanProfile k3s-cis-1.6-profile-permissive, error: Kubernetes version mismatch, ClusterScanProfile k3s-cis-1.6-profile-permissive is not valid for this cluster's K8s version v1.20.4+k3s1
Running permissive scan on cluster that has not gone through the hardening guide is successful, and running hardened scan fails expectedly:

Note there are more passes in the hardened. The below three are those listed, and this is because some of those controls are "Manual" and therefore will show up as "Warn" in the 1.6 checks, and the one "Automated" one is marked "Not Applicable" because this check should not apply in a more permissive cluster.

- 4.2.7 | Ensure that the --make-iptables-util-chains argument is set to true (Automated)
- 5.3.2 | Ensure that all Namespaces have Network Policies defined (Manual)
- 5.7.4 | The default namespace should not be used (Manual)

Running both permissive and hardened scans on clusters that have gone through the hardening guide are successful:

k3s hardening guide remains the same and is still applicable for 1.6. The checks still pass/fail exactly as mentioned in our docs.

Validated on Ubuntu, SLES, and Centos8 with both permissive and hardened clusters.


Add a new rule that insures we consistently use camelCase with our variable names

Currently we have a mixture of snake_case and camelCase in our applications we need to standardise this and the chosen method of choice is camelCase.

Resolved as part of https://github.com/JumpTwentyFour/php-coding-standards/pull/27


Generate typescript natively

After having a chat with everyone the limitations of the thrift CLI were just too big:

the reserved words got in our way, keeping to maintain french-thrift might not be a good long term solution: it's written in C and not well documented
the way the official thrift command line manages dependencies between modules is not great and almost impossible to fix properly (I found the "episodic" compilation part pretty tough to understand and is undocumented)
the lack of good namespacing matching npm packages

So I bit the bullet and implemented a typescript generation extension to scrooge.
This PR isn't finished quite yet

[ ] Make the tsconfig.json more minimal
[ ] Update the readme
[ ] Actually use the native generation in the sbt plugin

I  don't expect this PR to be fully reviewed as it's ridiculously big, and it wouldn't matter as we have literally 0 system depending on it. So I'll merge on Monday, and if anyone spots anything funny I'll raise a new PR.
After merging this PR I'll rename the repo to scrooge-extras, who knows we might start adding our own swift support (cc @SLambrakis )
This was fun 😄

Great work!
The mustache templates are much more readable than the c++ version

Good lord! 👏


Save sorted list of experiments outside concat comprehension

Closes #276

Noticed this bug when I was refactoring. This whole code block is removed in the subsequent PR, but want to get this in now so the stable version of the conda environment doesn't contain a bug.

I am going to merge this and push a new version to fix this bug.


Rename package

This renames the package from lariat to @lariat/playwright as part of the effort in moving Lariat into the org.

@avo After this is published to npm, we can either deprecate the lariat package or alias it to this package.


Support key duplication in SeedFactory.Test.produce/1

It seems
produce user: :user1, user: :user2

doesn't work, while doing the same in multiple lines works just fine.
produce user: :user1
produce user: :user2

I'd expect both to work just fine.

I understand your expectation but I'm afraid it can't work due to more complex cases :slightly_smiling_face:
The order of entities specified to produce doesn't matter. You just declare what you need and SeedFactory automatically resolves which commands should be executed.
Let's take the schema from the README where we have company and user entities. If you type this
produce [:user, company: :company1, company: :company2]

then which company the user should belong to? :slightly_smiling_face:

then which company the user should belong to?

None of them would be my initial expectation. The company would be either taken from the :company (context) key, which none of the companies created in your produce call uses, or created implicitly.
However you could always go with Keyword semantics and choose the first :user key in the keyword list given to produce.
I can see not depending on the context map keys being useful to preventing a lot of „rekeying“ between entities.

None of them would be my initial expectation. The company would be either taken from the :company (context) key, which none of the companies created in your produce call uses, or created implicitly.

No, it doesn't work like this :slightly_smiling_face:
produce [:user, company: :company1]

is equivalent to
setup ctx do
  rebind(ctx, [company: :company1], fn ctx ->
    # everything that is executed here will refer to :company1 instead of :company
    # if we produce :company entity, it will be produced as :company1
    # if :create_user command needs :company, it will be taken from the context using :company1 key
    ctx
    |> exec(:create_company)
    |> exec(:create_user)
  end)
end


adding KSPI radiators (or, just resources) can break FuelVolumeChanged() method for wing.

Tried to use KSPI and this mod and "Mk2 extended KSPI integration" together and it seems it works incorrectly - "J" key does nothing. After some time spent in debugging I noticed Mk2 KSPI Integration adds radiators to wings (via MM patch). Simpliest way to fix is to change patch, of course, but I did more digging.
After little code changes to debug...
for (int i = 0; i < part.Resources.Count; ++i)
{
PartResource res = part.Resources[i];
Debug.Log ("PartResource = " + res.resourceName);
double fillPct = res.maxAmount > 0 ? res.amount / res.maxAmount : 1.0;
WingTankConfiguration tankSetup = StaticWingGlobals.wingTankConfigurations [fuelSelectedTankSetup];
Debug.Log ("Got tankSetup = " + tankSetup.GUIName);
WingTankResource resource = tankSetup.resources [res.resourceName];
Debug.Log ("Got Resource units/vol = " + resource.unitsPerVolume);
res.maxAmount = aeroStatVolume * resource.unitsPerVolume;
res.amount = res.maxAmount * fillPct;
}
I got this:
[LOG 09:41:58.386] PartResource = WasteHeat
[LOG 09:41:58.386] Got tankSetup = STR
[EXC 09:41:58.386] KeyNotFoundException: The given key was not present in the dictionary.
System.Collections.Generic.Dictionary`2[System.String,WingProcedural.WingTankResource].get_Item (System.String key)
WingProcedural.WingProcedural.FuelVolumeChanged ()
WingProcedural.WingProcedural.UpdateGeometry (Boolean updateAerodynamics)
WingProcedural.WingProcedural.RefreshGeometry ()
WingProcedural.WingProcedural.Setup ()
WingProcedural.WingProcedural.Start ()
Obviously WasteHeat can't be in STR TankSetup, so it throws exception. For sure, I reported this issue to (very old) Mk2 KSPI Integration thread, but, just in case, there can be a workaround against such case in B9 PWings too.

Latest commit should fix this issue


Make iconforge call create_dir_all, flush, and sync_all to deal with file system caches

In some rare cases, filesystem caches can cause the DM side of iconforge to experience the rust library returning, before the file is actually available for hashing and fcopy_rsc. This breaks a lot of assumptions that completely derails the code and breaks the asset registration completely.
To avoid this, we use our own bufwriter so we can call flush(), and sync_all().
Also calls create_dir_all as that was also an issue in testing.

@itsmeow please advise

Just need to run a tracy profile on this and compare the performance and it's good with me

Added another fix for another bug I found: for y in 0..std::cmp::min(image.width(), other_image.width()) only works for square icons. Using height works for both square and non-square icons.

So turns out this is way horrible for performance and is likely related to having massive spritesheet file sizes and no page cache on the Linux runners? I'm not sure if merging this is a good idea as they work fine for spritesheets that aren't massive and this adds seconds of overhead to small spritesheets that don't have issues. This needs to check for a certain size (what that size is, I have no idea)

For some use cases yes. It adds a little bit of overhead, but it's acceptable. The bug fix is necessary.


Code and state are not removed from the URL on auth completion

Library version: 0.8.0
After successfully logging in, the code and state parameters are not stripped from the URL. This is occurring when using history-based routing, and I'm not sure if it's occurring with hash-based routing. Example:
http://localhost:3000/?code=FgGYjo14HIgV4K8QszJN5HLdU3LbMy&state=vsORAETN0z

Closing, this is actually a downstream bug related to vue-router.


[BenchmarkService] some fields in videoRecords is zero

Related module
Benchmark
What happened
When testing my code, I found out that certain fields that were supposed to have values turned out to be null.Thus, I add a log in the benchmarkService, and someaFields in video records is null, I wonder if I made some mistake or there's actually a bug. Thanks

What you expected to happen
No response
How to reproduce
No response
Anything else
No response

We will release an update for benchmark service, which is still wip. You may check the branch https://github.com/hezean/sustc/tree/benchmark


Ubuntu: setting proxyman wrong proxy for https

Hi,
I observed strange behavior using the flag use_same=y for "Use same values for https and ftp"
This led to the creation of the two variables http_proxy/https_proxy pointing to the same http://[auth@]host:port of the proxy
From my experience I can tell that most of the time http_proxy variable shall point to http urls and https_proxy to https version.
Do you experience the same?

this was 5+ years back. I don't actually remember why, but there were some problems where using https for https_proxy lead to issues.
Hence, I chose this route.
Anyways, I later stopped caring much since OS level settings post 2018/19 became very reliable, unlike 2015 times.


安装出问题 Installation issues

Why is an error reported when using the following command?

Why do I get an error when using the following command?
pip install<EMAIL_ADDRESS>--no-deps

Why do I get an error when using the following command?
pip install<EMAIL_ADDRESS>--no-deps


Feature?: Contracts

Anyone interested in contracts?
http://disnetdev.com/contracts.coffee/
Seems like this would be a sweet layer on top of regular testing.
Thoughts?

:+1:


[Client] Remove unused tracker events

Another pretty terrible 'rewrite to async in one go' type commit.

merged


Improvement/release script

send PR to develop and master at the same time

I fixed some of the test failures that you are seeing in my PR: #365


Color theme panel fails to open from setting button if a new color theme is installed

VSCode Version: 1.41
OS Version: Windows 10 1909

Steps to Reproduce:

Install a new color theme form Marketplace and enable it
Try opening color theme panel from setting button and it fails
Try opening color theme panel from menu it works

Bug is also reproduced in the latest insider version.

Are you viewing the release notes when this happens? If so, probably a duplicate of #75209

@gjsjohnmurray I was not viewing release notes when I reproduced the issue. It seems the issue does not last for long. The panel can be opened after some time since I first tried.

Does this also happen when you have an extension preview open? If so then it is the same duplicate as John mentions.

@misolori You are right. I will close this issue.


2024-11-21 - LLM Exploration Weekly

Date
2024-11-14 - 12pm ET / 5pm GMT
Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Introductions
[ ] Upcoming Hackathon - DTCC & Use Cases
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Zoom info
Join Zoom Meeting
https://zoom.us/j/93805835465
Meeting ID: 938 0583 5465
Passcode: 724143
Find your local number: https://zoom.us/u/aHHeTieyi

Alvin Shih / Morgan Stanley

Peter Crosbie / Provectus

David Lee / ISDA

https://www.finos.org/blog/finos-llm-exploration-use-case-identification

Just a reminder, the lab is not focused exclusively on CDM. Use cases:
https://www.finos.org/blog/finos-llm-exploration-use-case-identification
https://www.finos.org/blog/ai-strategic-initiative-series-applying-llms-to-simplify-cdm

ai4finance.com

Ian Sloyan / FINOS


add Ctrl+Enter shortcut to the next button

fix https://github.com/martinroob/tiny-translator/issues/40


Eco MODE ON AIR & Output: Bad Request

See below:

Appears when triggering Eco MODE, ON AIR and OUTPUT

Companion is currently using an incorrect SmodeLive version (v1.0.1 instead of v1.0.2). ). To rectify this issue, navigate to the companion-module-smodetech-smodelive folder perform a git pull. Alternatively, you can clone the repository, and then attempt the operation again. Please remember to set the Developer modules path to the parent directory of companion-module-smodetech-smodelive folder.

fixed on companion v3.2.2
added as required in the smode documentation.
I Close


Added image download functionality

Getting these messages while running your branch.
Compiler message:
Error: Could not resolve the package 'image_downloader' in 'package:image_downloader/image_downloader.dart'.
Error: Could not resolve the package 'permission_handler' in 'package:permission_handler/permission_handler.dart'.
lib/screens/image_page.dart:7:8: Error: Not found: 'package:image_downloader/image_downloader.dart'
import 'package:image_downloader/image_downloader.dart';
       ^
lib/screens/image_page.dart:8:8: Error: Not found: 'package:permission_handler/permission_handler.dart'
import 'package:permission_handler/permission_handler.dart';
       ^
lib/screens/image_page.dart:267:7: Error: 'PermissionStatus' isn't a type.
      PermissionStatus status = await PermissionHandler()
      ^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:267:39: Error: The method 'PermissionHandler' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing method, or defining a method named 'PermissionHandler'.
      PermissionStatus status = await PermissionHandler()
                                      ^^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:268:34: Error: The getter 'PermissionGroup' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PermissionGroup'.
          .checkPermissionStatus(PermissionGroup.storage);
                                 ^^^^^^^^^^^^^^^
lib/screens/image_page.dart:270:21: Error: The getter 'PermissionStatus' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PermissionStatus'.
      if (status == PermissionStatus.granted) {
                    ^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:274:31: Error: The getter 'ImageDownloader' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'ImageDownloader'.
          var imageId = await ImageDownloader.downloadImage(
                              ^^^^^^^^^^^^^^^
lib/screens/image_page.dart:276:28: Error: The getter 'AndroidDestinationType' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'AndroidDestinationType'.
              destination: AndroidDestinationType.directoryDownloads);
                           ^^^^^^^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:293:5: Error: 'PermissionStatus' isn't a type.
    PermissionStatus status = await PermissionHandler()
    ^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:292:11: Error: The method 'PermissionHandler' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing method, or defining a method named 'PermissionHandler'.
    await PermissionHandler().requestPermissions([PermissionGroup.storage]);
          ^^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:292:51: Error: The getter 'PermissionGroup' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PermissionGroup'.
    await PermissionHandler().requestPermissions([PermissionGroup.storage]);
                                                  ^^^^^^^^^^^^^^^
lib/screens/image_page.dart:293:37: Error: The method 'PermissionHandler' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing method, or defining a method named 'PermissionHandler'.
    PermissionStatus status = await PermissionHandler()
                                    ^^^^^^^^^^^^^^^^^
lib/screens/image_page.dart:294:32: Error: The getter 'PermissionGroup' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PermissionGroup'.
        .checkPermissionStatus(PermissionGroup.storage);
                               ^^^^^^^^^^^^^^^
lib/screens/image_page.dart:295:19: Error: The getter 'PermissionStatus' isn't defined for the class '_ImagePageState'.
 - '_ImagePageState' is from 'package:chitr/screens/image_page.dart' ('lib/screens/image_page.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'PermissionStatus'.
    if (status == PermissionStatus.granted) {

Sorry, the issue was with my compiler. Ignore the above message.

When I click on download button it shows me Toast that "Check notification to see progress" but there is no notification.

Are you running on emulator or real device? It works fine on the devices I have tested. I have implemented the same download module here : https://github.com/bimsina/reWalls .

@bimsina I was running on the real device. Although after a couple of hours I got all those notifications. Let me check why That was happening.


PLAT-126935: Refined overscroll effect

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
For better UX, the default overscroll effect factor needs to be refined. From this PR, the default effect factor is 0.5 which is half of the maximum effect (1.0) and the maximum effect factor for flick input is still 1.0 as it shows bigger for the speed of flicking.
Resolution
Change the default effect factor from 1 to 0.5 except for flick input.
Additional Considerations
Links
PLAT-126935
Comments

Please resolve the merge conflict.


reorder parameters

In 1,0, primitives are created without memory.
auto conv1_prim_desc = convolution_forward::primitive_desc(conv1_desc, eng);
But Reorder still expects src and dst memories in reorder constructor and again pass them as arguments. Isn't it redundant?
    /* create reorders for data and weights if layout requested by
     * convolution is different from NCHW/OIHW */
    auto conv1_src_memory = user_src_memory;
    if (conv1_prim_desc.src_desc() != user_src_memory.get_desc()) {
        conv1_src_memory = memory(conv1_prim_desc.src_desc(), eng);
        net.push_back(reorder(user_src_memory, conv1_src_memory));
        net_args.push_back({ { MKLDNN_ARG_FROM, user_src_memory },
                { MKLDNN_ARG_TO, conv1_src_memory } });
    }

creating new issue

Quick answer on the original question. The reorder has few constructors.
The main reorder constuctor is this one:
reorder(const primitive_desc &pd): primitive(pd.get()) {}

You can find it here.
The proper way to create a reorder::primitive_desc is to call this constructor:
        primitive_desc(const engine &src_engine, const memory::desc &src_md,
                const engine &dst_engine, const memory::desc &dst_md,
                const primitive_attr &aattr = primitive_attr());

Link.
It requires memory descs, engines, and attributes. You don't need to have memory objects.
But if that happens that you already have memory objects it might be convenient to create reorders based on them directly. That's why we have these extra constructors.
So the long story short, the ctors you mentioned are indeed redundant. And should be considered as the ones for users convenience.
I will into the bug in the corresponding thread #473.


Clean up of txfunc.py

The following could help to make txfunc.py more clear and concise:

[x]  beg_yr and start_yr seem to refer to the same thing. If so, just use the same object name.
[ ] use or delete plot_txfunc_v_data()
[x] plot_full and plot_trunc are both used in plot_txfunc_v_data(), but just one of these booleans is enough
[ ] Are age_min and age_max same as s_min and s_max? If so, use consistent names for the objects
[x] tpers and BW appear to refer to the same thing.  Use just one of these names to refer to the number of periods in the budget window.
[x] In tax_func_loop we don't need to create such big arrays and then return slice so those arrays.  We can just start with smaller arrays and return the whole thing.

4 of these have been addressed in PR #470

It looks like s_min and s_max are the minimum and maximum ages to estimate tax functions for and min_age and max_age are the minimum and maximum ages observed in the data. I think this is useful for cases where there are gaps in the age data that are filled in using other data estimates.

@duncanhobbs  Thanks for confirming that those variables are not duplicates.  This issue has been fully addressed.


bad bundle image env var in Quickstart for Go-based Operators

make bundle IMG="example.com/memcached-operator:v0.0.1"
make bundle-build bundle-push

This should be BUNDLE_IMG

@thoraxe Thanks for bringing up this issue. Would you like to submit a PR? The commit you have mentioned would be helpful and can fix the issue.

@thoraxe created a PR for it last week.
It looks good, it's just missing commit sign-off before it can be merged.