Difference between angular-mydatepicker and mydatepicker?

Hello, thanks for the cool date picker! At the moment I use the ngx-mydatepicker library. But I wanted to switch to the newer one, to support the newer angular versions.
I noticed that in the angular-mydatepicker library, the todayNextBtn option is not available anymore. But in mydatepicker it is available.
Could you tell me the differences between angular-mydatepicker and mydatepicker or why you created both of these two libraries? Would be good to know, thank you! :-)

Hi @be-ndee
angular-mydatepicker

is more configurable
has more features
it based on newer Angular version
it is implemented as a directive
input box is your own code
it based on ngx-mydatepicker library

You can also read this: https://github.com/kekeh/angular-mydatepicker#main-features

Thank you for the fast reply! But the "today" button is not possible anymore, right?

Thank you for the fast reply! But the "today" button is not possible anymore, right?

@be-ndee I can confirm the 'today' button is not available anymore.

Thanks both of you! :-)


Auth status race condition

There is a race condition at https://github.com/Comcast/webpa-common/blob/master/device/manager.go#L336.
The initial auth status message should be sent via the outbound write message queue to avoid this.

This was solved in PR #325 by deprecating the auth status message.


Auto compaction based on parallel indexing

Description
This PR is to allow for auto compaction to use the parallel indexing task. This will be useful when there are too many or large segments in a single time chunk.
New/changed configurations

Parallel indexing task has a new configuration, splitHintSpec, in the tuningConfig to allow for operators to give a hint to control the amount of data that each first phase sub task reads. SegmentsSplitHintSpec is the only available option for now which is used only for IngestSegmentFirehose.
Compaction task now uses ParallelIndexTuningConfig.
Auto compaction tuning config now supports maxNumConcurrentSubTasks and splitHintSpec.

This PR has:

[x] been self-reviewed.
[x] added documentation for new or modified features or behaviors.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added unit tests or modified existing tests to cover new code paths.
[x] been tested in a test Druid cluster.

This change is

@ccaominh @clintropolis thank you for the review!

Does this still create a compact task that uses parallel indexing internally, or does it actually generate an index_parallel task?


Fix 723 Cleaned up TimePicker styling

This should fix https://github.com/primefaces-extensions/primefaces-extensions.github.com/issues/723
It's looking good on my MacBook with Chrome. We might want to test with some other browsers. I think we are alright though, since the majority of the styling is inherited from existing components (like spinner and input group)

I will check this out on Edge, IE and Firefox and let you know how it looks!

This looks good.  There are still a few issues though...

Look at the Spinners in Nova-Light and Nova-Dark.

The popup styling is off in the premium themes.
Omega:

Nova-Dark:

The customization input is an issue with the showcase (the with of that input is hardcoded there). We might want to add 10 to 15px there.
What browser gave you issues with the spinners?
What is wrong with the popup (other than the button style)?

I was testing in Chrome and Firefox.  Didn't try IE and Edge yet.  I am on Windows.
As for the popup doesn't it look really naked compared to Omega? No borders around dates etc?  Maybe its supposed to be that way it just looks awfully plain and the buttons are not styled.

vs Omega...

OK the good news is its working in Firefox, Chrome, IE and Edge.  But the the same spinner and popup rendering is consistent in all 4 browsers.

As for the popup doesn't it look really naked compared to Omega?

I tried to apply very mild styling and to keep it in line with, for example, p:calendar

But the the same spinner and popup rendering is consistent in all 4 browsers.

Okay, I'll look in to that.

@melloware can you please test again?

I will check it out!


Vue tab doesn't show in Chrome DevTools

Version
5.1.1
Browser and OS info
Chrome 77 / Windows 10 1903
Steps to reproduce
I'm not completely sure, but I had all Chrome DevTools settings set to default (fresh Chrome install)
What is expected?
I'm able to use Vue DevTools if it's detected by the plugin
What is actually happening?
I can't access Vue tab as it's not visible in DevTools

I've switched to Appearance > Theme setting from 'System preference' to 'Light theme' and it fixed itself. I've tried switching to 'System preference' and reopening browser and it's still working.

me too ,when i clicked the icon told me 'Vue.js is detected on this page. Open DevTools and look for the Vue panel.' but can't find the panel
点击地址栏旁的图标提醒我'Vue.js is detected on this page. Open DevTools and look for the Vue panel.' 但是并不能找到这个 vue 的panel

我也是，什么问题呢？安装好了有报错！

I have the same problem after update chrome

Same here. I got it to appear by tweaking the settings in the extensions management, but then it just loaded the Vue logo and nothing else. I got it back working by uninstalling and re-installing. HTH.

I had the issue and noticed that at the extension details/settling page, for google chrome, under "Inspect views" shown the hyperlink "background page (inactive)". Upon clicking it, it open console panel in a new window and the Vue devtools is showing afterward. The hyperlink changed to "background page"

@WeichenTeo, that worked for me. It wouldn't display and the extension showed "background page (inactive)".  I clicked it and afterwards the next time I opened the inspector the Vue tab appeared.

I've spent way too much time trying to diagnose this problem. None of the suggestions worked for me using the Brave or Chrome browsers. Finally uninstalled and re-installed the plugin, then turned on Dev Mode and then found the setting to "allow local file access" for the extension and suddenly, the Vue tab was showing once again. No idea what's going on but glad it's back.

https://devtools.vuejs.org/guide/installation.html#settings

https://devtools.vuejs.org/guide/installation.html#settings

Hey @Akryum,
You mocking me or us? Don't think we installed the plugin correctly before? Seriously, it really pisses me off when people point to the obvious step most every one of us already did. Every single one of us who had the plugin working before have for one reason or another lost the ability to use it, which is how we ended up here.
I wasted a day of work because I was trying to figure out what in my source code was killing the Vue tab in DevTools to vanish. As it turns out, the damned plugin failed in some way, or perhaps a recent update in the browser's code disabled the plugin's access to the local files. There was nothing wrong with my code. The plugin just stopped working.
(Also, why is local file access needed when the URL is http://localhost/. This makes no sense to me.)
Again, we've had it working before. We already INSTALLED IT CORRECTLY BEFORE.

You mocking me or us? Don't think we installed the plugin correctly before?

Your unrespectful and aggressive comments don't belong here. Don't expect me to help you further.

Seriously, it really pisses me off when people point to the obvious step most every one of us already did. Every single one of us who had the plugin working before have for one reason or another lost the ability to use it, which is how we ended up here.

Unfortunately not everybody read the docs before opening issues or commenting.

Also, why is local file access needed when the URL is http://localhost/. This makes no sense to me.

If that's really what fixed your issue, I guess you should open an issue in the Chrome tracker.

Wouldn't have thought this PR would still be active, and moreover, get this heated. 😅
I am using localhost, so I didn't think file access would be very relevant.
The bug still occasionally happens, but I just got so used to switching the theme to fix it, that I don't even think about it anymore, so it's a bit hard to estimate how often. Probably less since I started using v6.
I'll try to enable file access and see if there is any difference.

It didn't work for me before. It's a bit related to the Chrome version. I installed it in Firefox and it worked normally. Later, I upgraded the Chrome version, and then it also displayed normally

FYI, Chrome 99 devtools pane is buggy


Added RS5 EMI V2 support note

In Windows 10 RS5, devices can also support EMI_VERSION_V2.

Thanks Jake, we will publish this update within 24 hours.


Sanic instalation on Windows

Hi,
In order to install Sanic on Windows I went over the instructions to install it without uvloop and ujson, commands:
set SANIC_NO_UVLOOP=true
set SANIC_NO_UJSON=true
pip install sanic
I got the follow output, with the exception of {User} was my user:
Collecting sanic
Downloading sanic-0.5.4-py3-none-any.whl (43kB)
100% |████████████████████████████████| 51kB 290kB/s
Collecting websockets>=3.2 (from sanic)
Downloading websockets-3.3-py33.py34.py35.py36-none-any.whl
Collecting aiofiles>=0.3.0 (from sanic)
Downloading aiofiles-0.3.1-py3-none-any.whl
Collecting ujson>=1.35 (from sanic)
Downloading ujson-1.35.tar.gz (192kB)
100% |████████████████████████████████| 194kB 3.1MB/s
Collecting uvloop>=0.5.3 (from sanic)
Downloading uvloop-0.8.0.tar.gz (1.7MB)
100% |████████████████████████████████| 1.7MB 3.4MB/s
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users{User}\AppData\Local\Temp\pip-build-rnj1hcy_\uvloop\setup.py", line 11, in
raise RuntimeError('uvloop does not support Windows at the moment')
RuntimeError: uvloop does not support Windows at the moment
Although when I clone the project and do the following commands, it is successfully installed:
set SANIC_NO_UVLOOP=true
set SANIC_NO_UJSON=true
pip install .

It might make it a little more friendly to use sanic to tweak the setup.py to check the system it's installing on:
# setup.py
...
is_windows = sys.platform.startswith("win")
if strtobool(os.environ.get("SANIC_NO_UJSON", "no")) or is_windows:
    print("Installing without uJSON")
    requirements.remove(ujson)

# 'nt' means windows OS
if strtobool(os.environ.get("SANIC_NO_UVLOOP", "no")) or is_windows:
    print("Installing without uvLoop")
    requirements.remove(uvloop)
...

Or along the lines of #916 maybe make ujson and uvloop extras_require  so you opt-in on pip install with pipenv install sanic[ujson,uvloop].

With the 0.8.x release, this should be resolved.


Change SipHash2-4 -> SipHash1-3

Inspired by https://github.com/rust-lang/rust/pull/107925.
This seems to significantly improves performance.

Have you considered ahash, xxhash, fxhash, etc?

No, I haven't. I'm really just mimiciing rustc's decision on the matter.
I'm afraid I won't be able to test them out soon though (I'll be quite busy on the next days).

Have you considered ahash, xxhash, fxhash, etc?

At least fxhash doesn't have high-enough quality. We're relying on the fact that the collision probability for these 128-bit SipHashes is extremely low. If a collision happens, Typst might produce wrong results.


Update custom navbar styling to match modules

Nav items added directly to /includes/navigation need to be styled in same way as modules

The extra page links should use the same style classes as items for modules. iow "nav-item py-2". Seems like the class for modules links were changed from py-0 to py-2 but not the commented code: https://github.com/p2pu/course-in-a-box/commit/db90b099ea5f3af46f881729e7c92161e519d0a6#diff-685aab823f145ce7d8c69647c1bcef572d65655973a14032212c401924caf0cb


ARROW-6295:[Rust][DataFusion] ExecutionError Cannot compare Float32 w…

fixes
thread 'main' panicked at 'called Result::unwrap() on an Err value: ExecutionError("Cannot compare Float32 with Float64")', src/libcore/result.rs:1084:5
Change github address

This pull request is also related to ARROW-6290.

I have fixed the root cause in https://github.com/apache/arrow/pull/5136


Fullscreen visualization is partially covered by IDE buttons

Steps to reproduce

Open desktop IDE
Create a node with a simple visualization, like a number input.
Open a fullscreen vis for this node.
Observe that part of the visualization is covered by window buttons.

Affected version
Recent develop

The visualization is under canvas, so those icons and messages shall be hidden, as Graph Editor is.

No longer an issue, as the macOS windows are decorated.


Onboarding: Duplicate Student ID card image

Time Tracking: MA-34
This is done when:

[x] Onboarding screen 2 - duplicate Student ID image removed

Onboarding screen sizing requirements:

Onboarding screen
Dimensions

Large Phone
1242 x 2688

Standard Phone
1242 x 2208

Large Tablet
2048 x 2732

Standard Tablet
1536 x 2048

Resolved in #1186


Test Case keyword override keywords from resource currently executed

I have been created test suite file scope_test.robot like below:
*** Settings ***
Resource  scope_test_res.robot

*** Test Cases ***
Test
  key
  key_from_resource

*** Keywords ***
key
  Log  internal_test_case_keyword

And resource file scope_test_res.robot like below:
*** Keywords ***
key_from_resource
  key

key
  Log  call_keyword_from_resource

What I found is that when key_from_resource is executed the keyword from scope_test.robot is executed instead of local keyword key. When I change resource file (by adding file prefix to call the key keyword) to be like:
*** Keywords ***
key_from_resource
  scope_test_res.key

key
  Log  call_keyword_from_resource

everything works perfectly.
The question is, if this behaviour is something expected?

This is by design. The idea is that test case files can override parts of the functionality provided by resource files. I agree it can be surprising, though, and I'm not sure how useful this functionality really is. It's good that it is possible to prefix the keyword with the resource file name also in this case if you want to be sure exactly that keyword is called.

Thanks for update Pekka.


Migrate to Postcss 8 API

Looks like postcss 7 plugins are working again with 8, but its still recommended to port over to the new PCSS 8 api:
https://evilmartians.com/chronicles/postcss-8-plugin-migration

PR up https://github.com/jonathantneal/postcss-nesting/pull/72

It looks like the current main branch needs more updates to be fully PostCSS 8 compliant.
"Step 3: Take the most out of the new API" of the PostCSS plugin migration guide says:

PostCSS 8 does a single CSS tree scan. Multiple plugins can leverage the same scan for better performance.
To use the single scan you need to remove root.walk* calls and move the code to Declaration(), Rule(), AtRule() or Comment() methods in a plugin’s object:
module.exports = {
    postcssPlugin: 'postcss-dark-theme-class',
-   Once (root) {
-     root.walkAtRules(atRule => {
-       // Slow
-     })
-   }
+   AtRule (atRule) {
+     // Faster
+   }
  }
  module.exports.postcss = true

postcss-nesting still has:
const postcssNesting = () => {
	return {
		postcssPlugin: 'postcss-nesting',
		Once(root) {
			walk(root);
		}
	}
}

I'm experiencing a bug on the latest main branch where CSS added from a previous plugin in the postcss config isn't processed by the later-defined postcss-nesting and I suspect (but don't know) that this might be the reason.

Looks like jn got a start on it over here: https://github.com/csstools/postcss-nesting/pull/75
Go Jonathan Go!

Done in https://github.com/csstools/postcss-nesting/commit/64ba9ac4a56e353b1685adb91cf0a24b425183cc


emcee should be research software

http://depsy.org/package/python/emcee
should be research software
as per twitter

Fixed!  99the percentile :)
http://depsy.org/package/python/emcee


Peer-to-peer code review

👋 Hello Fortune

[ ] Instead of using fixed pixel values, consider using responsive units such as rem or em to ensure scalability and flexibility.
[ ] To position images, consider using background-position with the values of top right or bottom left.
[ ] Experiment with adjusting the width property and testing whether setting it to 100% of the container resolves any issues.

By Jorge Prada, Vishal Kumar, and Juan Velez👍

Thanks so much, guys. I implemented the changes you required


docs: AuthMechanism::Plain has wrong order of authzid/authcid

base64(b"<authenticate-id>\x00<authorize-id>\x00<password>")

->
base64(b"<authorization identity>\x00<authentication identity>\x00<password>")

message   = [authzid] UTF8NUL authcid UTF8NUL passwd
authcid   = 1*SAFE ; MUST accept up to 255 octets
authzid   = 1*SAFE ; MUST accept up to 255 octets
passwd    = 1*SAFE ; MUST accept up to 255 octets
UTF8NUL   = %x00 ; [UTF-8](https://datatracker.ietf.org/doc/html/rfc4616#ref-UTF-8) encoded NUL character

SAFE      = UTF1 / UTF2 / UTF3 / UTF4
               ;; any UTF-8 encoded [Unicode](https://datatracker.ietf.org/doc/html/rfc4616#ref-Unicode) character except NUL

UTF1      = %x01-7F ;; except NUL
UTF2      = %xC2-DF UTF0
UTF3      = %xE0 %xA0-BF UTF0 / %xE1-EC 2(UTF0) / %xED %x80-9F UTF0 / %xEE-EF 2(UTF0)
UTF4      = %xF0 %x90-BF 2(UTF0) / %xF1-F3 3(UTF0) / %xF4 %x80-8F 2(UTF0)
UTF0      = %x80-BF

The authorization identity (authzid), authentication identity
(authcid), password (passwd), and NUL character deliminators SHALL be
transferred as [UTF-8] encoded strings of [Unicode] characters.

Fixed on v2.


changing gossip broadcast method

As gossip registry always generate new Id via uuid, consider changing to  UniqueBroadcast
https://godoc.org/github.com/hashicorp/memberlist#UniqueBroadcast
this is faster then current approach, because avoid finding duplicates in queue.

Please consolidate into one issue.


Tracking: Repos targeting .NET 9 SDK

This is a tracking issue to identify which repos are currently onboarded to use .NET 9 SDK. This is necessary as a prerequisite to eventually have these repos produce packages that target net9.0.
Repos:

[ ] arcade: https://github.com/dotnet/arcade/issues/14261
[x] aspnetcore
[ ] cecil
[ ] command-line-api: https://github.com/dotnet/command-line-api/issues/2305
[ ] deployment-tools: https://github.com/dotnet/deployment-tools/issues/317
[ ] diagnostics: https://github.com/dotnet/diagnostics/issues/4421
[ ] emsdk
[x] format
[ ] fsharp: https://github.com/dotnet/fsharp/issues/16379
[x] installer
[x] msbuild: https://github.com/dotnet/msbuild/issues/9492 (staying on .NET 8 SDK/Arcade)
[x] nuget-client: https://github.com/NuGet/NuGet.Client/pull/5511
[ ] razor: https://github.com/dotnet/razor/issues/9659
[ ] roslyn: https://github.com/dotnet/roslyn/issues/71084
[ ] roslyn-analyzers: https://github.com/dotnet/roslyn-analyzers/issues/7066
[ ] runtime: https://github.com/dotnet/runtime/issues/95605
[x] sdk
[ ] source-build-externals
[ ] source-build-reference-packages
[ ] sourcelink: https://github.com/dotnet/sourcelink/issues/1152
[ ] symreader: https://github.com/dotnet/symreader/issues/299
[x] templating (doesn't consume NetCurrent)
[x] test-templates
[ ] vstest: https://github.com/microsoft/vstest/issues/4779
[ ] xdt: https://github.com/dotnet/xdt/issues/547

Related to:

https://github.com/dotnet/arcade/pull/14108
https://github.com/dotnet/source-build/issues/3663

We will hit this issue every year again and again. Maybe it would make sense for source-build to use a different SDK than what the non source build infrastructure uses? That would also help with issues like https://github.com/dotnet/runtime/issues/95022#issuecomment-1827826930

Source build is already using a .NET 9 SDK to build the VMR. The main driver of getting all these repos onto the new SDK is so we can roll out this change: https://github.com/dotnet/arcade/pull/14108.

Why not change these properties now when building from source and make repositories use a .NET 9 SDK in their source build legs? We will hit this problem with every release and it would be good to come up with a pattern that works long-term.

make repositories use a .NET 9 SDK in their source build legs

How would that work? I thought this was all controlled by global.json whether it's for source build or not.

How would that work? I thought this was all controlled by global.json whether it's for source build or not.

Isn't there an environment variable today that the host respects to specify a different global.json? If not, we should discuss if adding such a feature would be worthwhile.

Isn't there an environment variable today that the host respects to specify a different global.json? If not, we should discuss if adding such a feature would be worthwhile.

Not that I'm aware of. It's certainly not documented. That's related to https://github.com/dotnet/source-build/issues/3169.

One possible solution would be to allow major version SDK rollforwards in the individual repos (that's a global.json setting) and then just download a newer SDK. We should be able to change the version that is restored as that is handled via Arcade.

But regardless of what SDK is used for source build, the issue of rolling out https://github.com/dotnet/arcade/pull/14108 still exists. Not having that rolled out would mean we would need to have a bunch of source build conditions that explicitly set NetCurrent to net9.0. That's not a good solution either. Alternatively, you would iteratively rollout net9.0 in Arcade by first setting NetCurrent in Arcade to net9.0 only for source build. Then once repos have taken the new SDK, NetCurrent in Arcade can be upgraded with no conditions. Still seems like a lot of coordination.

templating (doesn't consume NetCurrent)

From the list in the top post. What does that mean? I see that they are using a 9.0 Arcade SDK and are currently targeting net8.0.

All the repos in the list above that don't intentionally stay on an older .NET SDK and Arcade SDK, now upgraded to .NET 9 and Arcade 9. I assume the remaining six repositories will update later around ~June/July when they stop dual-inserting. Except for command-line-api which doesn't dual-inserts but just doesn't want to use the .NET 9 SDK yet.

I am closing this as its usefulness is over.  There are two remaining repos (aspire and command-line-api) that don't utilize a net 9.0 SDK.  They both utilize NetCurrent so they are compatible with the product source-build.


✅ Cli Prepare Refactoring

✅ Task

Don't allow an env with no agents.
New cli command to create a storage.
Motivation

QOL.
Details

Effects:

scli
control plane

Related to #154 and #192.

closing because an env with no agents is acceptable for compute only envs


Typescript typings issue

Within the latest version, when I Start a new Expo project I'm getting the following ts error
I'm having issues understanding why
'MapView' cannot be used as a JSX component.
  Its instance type 'MapView' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'React.ReactNode' is not assignable to type 'import("/Users/screamz/js-dev/pro/stride/stride-new-mobile-app/node_modules/@types/react-native/node_modules/@types/react/index").ReactNode'.
        Type '{}' is not assignable to type 'ReactNode'.
          Type '{}' is missing the following properties from type 'ReactPortal': key, children, type, propsts(2786)

Reproduction
npm i -g expo-cli
expo init -> Typescript starter
expo install react-native-maps-> "react-native-maps": "0.29.4" given
Try to use <MapView /> within a component in a .tsx file

Looks related to https://github.com/facebook/react/issues/24304


fix 'drop schema' on DB2

The 'restrict' keyword is required on DB2.

https://hibernate.atlassian.net/browse/HHH-14203

@dreab8 this trivial change should be replicated in H6.

Merged and backported.


onboarding and minor layout fixes

the minor layout fixes regards:

month selector
budgets provider (create another method "insertOrUpdates" in the budgets provider is also possible)
add category page
routes

Nice work! Most of the things look good to me, I just noticed a couple of issue that need to be fixed before merging:

When I close and reopen the app I see the onboarding again. Once the user completes the Onboarding the first time they should skip to the dashboard.
When I add the main account I can only input a number without the decimal points (Ex. I can add 3000 but not 3000.01)

Here is a video:
https://drive.google.com/file/d/1kiv-2eVfrE10KS8I2Y6FAEKEElZP4ypB/view?usp=drive_link

Damn, I implement the one-time onboarding feature but for testing purpouse i commented it.
The idea was to uncomment it but i just forgot before committing >.<.
As you can see in main.dart at line 47/48 ther's the correct line and a TODO that explains everythings.
For the decimal point i'll take a look and see what i can do.
Thanks!


Unable to make selection or change WebEngine Mode setting

Dropdown menu for WebEngine Mode in settings does not have a selection option -Stef
Loom: https://www.loom.com/share/cbe1548fadfb440494406e7e83ab611b
I am able to save but it's not reflecting on instance - Gisele
Loom: https://www.loom.com/share/02a66b86b08849f4b2c3db04f5e97294

@smserpa can you try again in https://beta.zesty.io/ thanks


Make axes replacement public

✨ Feature Request
Could we make this function public?
https://github.com/SciTools/iris/blob/cbaa95524649378779f148cf5897611f208c76fb/lib/iris/plot.py#L827
Motivation

I want to write a function that makes a contour plot on the current axes, but I also want the plot projection to be different from the data projection.  So something like
def my_plotting_function(cube):
    iplt.replace_axes_with_cartopy_axes(plotting_crs)
    iplt.contourf(cube, ....)
    ... additional stuff like cartopy features, titles, etc....

Additional context

Even better would be if I could just pass plotting_crs as a keyword to contourf, but I think making the axes replacement function public would be the easier win.

I also raised this in Cartopy (https://github.com/SciTools/cartopy/issues/1756) as actually this sort of functionality would seem to fit better there.  @dopplershift was kind enough to point out that this would lead to a slew of bug reports from users who find the function doesn't reproduce everything from the existing axes.  So this appears to be a non-starter.


Hook refactor for ValidateLoginPage/index.js

Details
!!! This is applicable only for iOS and Android native.
Fixed Issues
$ https://github.com/Expensify/App/issues/16253
Tests
Note: I used this SO to test deep linking in dev

Sign in using the magic link with an account with 2fa enabled
Verify that the tab open by the magic link works as usual
Repeat the steps 1-2 with an account with 2fa disabled

[ ] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as Tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
N/A

Mobile Web - Chrome
N/A

Mobile Web - Safari
N/A

Desktop
N/A

iOS

Android

@cristipaval did @parasharrajat request to be unassigned from this one?

@cristipaval did @parasharrajat request to be unassigned from this one?

No, he didn't, I remembered that we ask for the C+ review only if we think it's necessary and I thought that this one is small 🤷
We can add him for more rigorous testing.

!!! This is applicable only for iOS and Android native.

This is for web & Desktop.

What do you mean? The implementation for the web is in ValidateLoginPage/index.website.js and for desktop this feature is disabled.

Ready for a new round of reviews @parasharrajat @marcaaron

Are we still holding? If so, can we put a HOLD in the title @cristipaval ?

Are we still holding? If so, can we put a HOLD in the title @cristipaval ?

Good point. Thanks!

Looks like we are still holding here?

On you @marcaaron

@marcaaron, displayName is now added

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add valid until function which returns a number that will guaranteed work until the expiration date

[https://github.com/pyotp/pyotp/pull/5]
Awesome idea to add

Hi tilkinsc,
Your function totp.valid_until() does not work for me, on both lua 5.1 and lua 5.3, it failes with the ((self.interval + 1) code.
Any ideas?
Thanks

Hi, as you can see I haven't updated LuaOTP in a long time. I need to catch it up to speed with the tilkinsc/COTP library.

If you can do that would be very welcome, but I also know it's you time.
But thank you for getting back to me.
Best regards
Tom
On Wed, 4 Sept 2024, 03:07 Cody Tilkins, @.***> wrote:

Hi, as you can see I haven't updated LuaOTP in a long time. I need to
catch it up to speed with the https://github.com/tilkinsc/COTP library.
—
Reply to this email directly, view it on GitHub
https://github.com/tilkinsc/LuaOTP/issues/1#issuecomment-2327766646, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQGDFPBEZENGHF5EWXAMMTZUZTMLAVCNFSM6AAAAABNSTF4ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXG43DMNRUGY
.
You are receiving this because you commented.Message ID:
@.***>

I pretty much scrapped all the code I had and writing anew. It seems like I can't find a sha1 library that isn't dogwater. If you can find one that I can just yeehaw and it outputs correct results compared to openssl in C with a permissive license, then I will be willing to finish it up.

Have you looked at http://25thandclement.com/~william/projects/luaossl.html it supports SHA1
The Git project
https://github.com/wahern/luaossl
The windows supported version of luaossl
https://github.com/daurnimator/luaossl


Updating notebook with pretrained=False

Saw the comment you were goin to re-run it.
But just in case - here's the notebook I ran. Feel free to close this.
Changes:
updated code to latest fastai2
Re-ran unet w/ pretrained=False
Re-ran classification w/ freeze=False

Thanks again for catching this! I've re-run my notebooks for 128x128 and 192x192.
For 128x128 I got:

5 epochs: 34.22%
20 epochs: 57.89%
80 epochs: 60.17%
200 epochs: 59.00%

Do these line up with what you got when you re-ran without pretraining?

I got slightly higher results:
5 epochs: 35.91%
20 epochs: 59.21%
80 epochs: 61.44%
200 epochs: 59.18%
Oh the one change I forgot to mention -
I normalized with imagenet stats on both. Could that be the difference?

I normalized with imagenet stats on both. Could that be the difference?

Yeah that's probably related. I haven't been normalizing at all.


Eloquent "filter" not working

I am trying to do a simple eloquent limit to a selection and it I am getting a 500 (Internal Server Error).
This is the controller code:
$plants = Plant::select(array('plants.id','plants.name','plants.created_at','plants.updated_at'));

    	return Datatables::of($plants)
      	->whereIn('id', [1,2,3,4])
        })->make(true);

The table:

        Plant ID
        Plant Name
        Created At
        Updated At

And javascript:
$(document).ready(function(){
            $('#dynamic-table').DataTable({
                "processing": true,
                "serverSide": true,
                "ajax": '{{ URL::Route('admin.servicetickets.custom_data') }}',
                "columns": [
                    {data: 'id', name: 'id', defaultContent:'n/a'},
                    {data: 'name', name: 'name', defaultContent:'n/a'},
                    {data: 'created_at', name: 'created_at', defaultContent:'n/a'},
                    {data: 'updated_at', name: 'updated_at', defaultContent:'n/a'}
                    ]
            });
          });

I am using Laravel 4.2.
Do you have any clue what might be wrong?

Can you open the 500 request in a new tab and view the error directly? Perhaps:

->whereIn(...) should be called on the $plants object, not the datatable. Also there's probably a syntax error with that extra } sitting around before the make function. Should look like:

 return Datatables::of($plants->whereIn('id', [1,2,3,4]))
     ->make(true);

Personally I would move the whereIn(...) up to the variable, and since you're selecting from the plant model itself table prefix isn't necessary (not sure if that would cause an error, though, just personal preference here)
$plants = Plant::select(['id','name','created_at','updated_at'])->whereIn('id', [1,2,3,4]);

return Datatables::of($plants)->make(true);

I think that should do it :)

Just a quick reply before I try your suggestions.
I specifically made the above example as a copy of Yajra's own Usage example taken from [https://github.com/yajra/laravel-datatables/wiki/Usage] (https://github.com/yajra/laravel-datatables/wiki/Usage)
Datatables now extends Query Builder's functionality which means that you can directy filter results using the Datatables class.
// Query Builder's extended function.
// See Laravel Query Builder docs for more details.
return Datatables::of($user)
    ->whereIn('id', [1,2,3])
    ->whereNull('id')
    ->make(true);

i have same problem with this.

@Razorsheep, @muhghazaliakbar sorry for misleading documentations. Most of the recent updates/features are only available on v5.x. Laravel 4.2 version has a very limited features which are derived from the original bllims version.
@johnhatch suggestion should fix your issue. thanks!

Added a note on read me for legacy code users. Sorry for the confusions.

Thanks for clarifying. Especially the custom filtering functions were quite
a source of frustration.
Well another excuse to update to laravel 5... 😉
Thanks for the good work!
Den 09/10/2015 06.56 skrev "Arjay Angeles"<EMAIL_ADDRESS>
Added a note
https://github.com/yajra/laravel-datatables#laravel-42--datatable-v19x-users
on read me for legacy code users. Sorry for the confusions.
—
Reply to this email directly or view it on GitHub
https://github.com/yajra/laravel-datatables/issues/207#issuecomment-146755313
.


Using Pip's '--no-cache-dir' within all Dockerfiles

Description
currently a lot of Dockerfile's or scripts that run within Docker leave pip downloaded artifacts in the final container and that leads to larger than desired containers.
Issues
https://github.com/opea-project/GenAIComps/issues/265
Type of change
List the type of change like below. Please delete options that are not relevant.

[Y] Bug fix (non-breaking change which fixes an issue)
[N] New feature (non-breaking change which adds new functionality)
N ] Breaking change (fix or feature that would break existing design and interface)
[Y] Others (enhancement, documentation, validation, etc.)

Dependencies
None
Tests
All the updated containers would undergo CI.

We can't merge the PR without CI pass.


Please make the debug toolbar moveable.

VSCode Version: 0.10.11
OS Version: mac

Steps to Reproduce:

Start debugging something
Try to read the filename that the debug toolbar is covering up
Try to move the toolbar
Hold your temper in when you accidentally stop your debugging process

Expected: some gripper that lets me move it to the side so i can see the filename
Resulted: can't move, even it were just positioned to the far right, then at least i could see the filename it's currently covering up.

As we discussed in the UX meeting, we should also consider a design where the toolbar slides in and out of view. Initially it would be in view but would then animate (slide upwards) until only the bottom edge of the toolbar was visible. When the mouse is moved to hover over the area it slides down.
If this doesn't work well we then suggested we should explore the ability to drag the toolbar horizontally.

@stevencl we got a very strong feedback in the standup today that the skype animation box is very painful to use. So we decided to first try with the horizontal move and if that does not work then try the animation.

+1 it's very annoying

i. am. SO EXCITED about this! @isidorn, you rock man

The problem exists now.
vs code version : 1.9.1
os version : win10

I can't move the debug bar. The problem annoys me seriously

@yunnysunny sorry about that, here's the issue with a workaround https://github.com/Microsoft/vscode/issues/20298
You can also switch to vscode insiders which has this fixed or wait a couple of days for a new stable version which contains a fix.


removed shading when less than 3 forecasts

fixes issue #214

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8fbdd95) 54.95% compared to head (d2f40af) 54.95%.

:exclamation: Current head d2f40af differs from pull request most recent head ee37e91. Consider uploading reports for the commit ee37e91 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   54.95%   54.95%
=======================================
  Files          23       23
  Lines        3963     3963
  Branches      578      578
=======================================
  Hits         2178     2178
  Misses       1648     1648
  Partials      137      137

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Setting formats (options) dynamically

Hey.
It would be great if it was possible to set formatting options after creating the IntlMessageFormat object. Something like this:
let msg = new IntlMessageFormat('The price is: {price, number, formatOptions}', 'en-US');
msg.setOptions({
    number: {
        formatOptions: {
            style   : 'currency',
            currency: 'USD'
        }
    }
});

const output = msg.format({price: 100});

In many cases where we format numbers we use the same message template, but with different formatting options e.g. with two decimals, without decimals, etc. Being able to set format options after creating the IntlMessageFormat object means that you dont have to create a new object instance, which we do now. This can affect performance of applications when objects are created and destroyed rappidly.

Creating Intl instances is way more expensive than creating JS objects. e.g.:
new Intl.NumberFormat(location, options);

Since it requires ICU/CLDR underlaying integration, which requires some bridge crossing from the engine to ICU, this operation is slow. Intl.MessageFormat is not part of the engine just yet, but it relies on the creation of a plural rule instance (https://github.com/tc39/proposal-intl-plural-rules/) and/or number format instance, which makes this expensive.
Moving all the logic to the .format is doable, but you will get penalize for extra operations during format, and introducing a setOptions() method diverge from other standard Intl mechanism, and IMO buy us little.


Doesn't work for nested elements.

If you have nested elements within the main div. This code doesn't work.

Yes same problem here. It remove other tags like  etc. in between the contents. Any fix for it please!

I had a problem with nested elements too. It would hide everything including sibling h1 and p tags (changed their CSS to display: none) of the container that is selected for shortening.


Update inactivity penalty deltas processing

Two main changes:

Inactivity scores are modified to decrease slowly for inactive validators when we are not in a leak, and quickly for active validators
The inactivity penalties are applied even not during a leak (note that inactivity scores decrease when outside of a leak)

This has the effect that the inactivity leak "overshoots" the target of finalizing again, and keeps leaking balances a bit more. For inactive validators, this PR sets post-leak recovery to happen 3x faster than the during-leak increase, so if a validator loses 3% during a leak, if they stay offline they should expect to lose another 1% until their score decreases back to zero.

I realized we were under testing this feature so I added a number of consensus tests for rewards with random inactivity leaks as well as some epoch processing process_inactivity_updates tests.
In addition, I realized that we should skip process_inactivity_updates at genesis because it relies upon the previous epoch participation.
Need some additional review on all of this. Thanks!

Merge #2408 first and backport helpers changes here


User is not able to launch any charts in Dashboard

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

On local cluster -->  Go to Charts --> Select Monitoring/Logging (any charts)
Request URL: https://<rancher-server>/v1/catalog.cattle.io.clusterrepos/rancher-charts?link=info&chartName=rancher-logging&version=3.4.000
Response: {"type":"error","links":{},"code":"ServerError","message":"EOF","status":500,"type":"error"}

Expected Result:
User should be able to launch without any errors
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head - commit id: 5e1b21b93
Installation option (single install/HA): HA on import k8s

Verified on master-head - commit id: 4149ea9e

On local cluster --> Go to Charts --> Select Monitoring/Logging (any charts)/backup-restore (from custom repo)
User is able to launch charts.


Extension content_scripts do not load if partition is set

Electron version: 4.3.1
Operating system: elementary OS 0.4.1 Loki

Extension content_scripts do not to load for BrowserWindows with partition set via webPreferences or for webviews with a partition attribute.
To reproduce:

Create an extension with content_scripts and load/enable it
Instantiate a new BrowserWindow and load 'https://google.com`
Observe that content_scripts are loaded
Pass webPreferences: {partition: 'test'} to new BrowserWindow
Observe that the content_scripts are not loaded

This needs some additional information. What is the extension manifest? Can you create a sample app?

Thankfully this was my mistake and not a bug. If you set a partition then it creates a new session. Extensions must be loaded and enabled independently for each session. For instance:
  process.on('extension-ready', (extension) => {
    console.log("EXTENSION-READY *************");
    sess.extensions.enable(extension.id);
  })

  process.on('extension-load-error', (error) => {
    console.log('ERROR***************')
    console.error(error)
  })

  sess.extensions.load(
    '/home/slord/Projects/muon-quick/extensions/shift',
    {},
    'component'
  );

you can use app.on('browser-context-created', (e, session) => { to get notifications when new sessions are are created


test/e2e: Do not wait for PVC to change its status from "Pending" to something else

Fixes #223
/assign @dmage

/lgtm


Payment method on permission

I had a thought about how to refine the payment process for needs that I faced with other shops and I believe it would be useful to filter payment possibilities based on user permissions.
For example:
If I have a shop that sends out goods I would rather not offer purchase on invoice to unregistered guests or unvalidated users. In that case, I would want to force "guests" to use paypal or any other payment processor that helps with security and validation of the payment. But if someone is a known customer and/or registered with a full data set, sending an invoice will be fine.
or:
If I have the case of rare cash payment ("pick up your order"), I would not want to offer "cash" as a payment method for anybody but I'd like to have it available for myself to keep up with the order numbers....
Whatdoyouthink?

Sorry, I think I originally missed this.
I think this would be handy for cases where customers have an 'account' with a shop, meaning that they are allowed to place an order using something like the Invoice method.
So I think this would be handy, but I think this would take quite a fair bit of work to code up.


Make the ays retries globally configurable from the orchestrator apis

Currently, the orchestrator API waits for all 6 retries before returning the result in case of a failing API.
AYS exposes the ability to configure the number of retries and configure the delay between the retries.
Make the retries configurable from the API, this will be a global configuration that will be applied to all runs.

software version
master 5c7668358


Move module_launcher from APIC to here, so that the Docker environment variables are transparent to the user

done, but in a different way - the module args are now a part of the core API


Handlers for listing and destroying tasks

Example usage (please see #714 for instructions on setting up the credentials header and task request):
Create a task:
➜  temp http POST localhost:8080/task/<EMAIL_ADDRESS>@task_req.yaml
HTTP/1.1 200 OK
Content-Length: 18
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:46:46 GMT

{
    "id": "WaWyjPKl"
}

List available tasks:
➜  temp http GET localhost:8080/task/<EMAIL_ADDRESS>
HTTP/1.1 200 OK
Content-Length: 57
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:47:07 GMT

{
    "tasks": [
        "tpi-yearly-light-anemone-1yrn2jft-51sxxrqg"
    ]
}

Destroy a specific task:
➜  temp http DELETE localhost:8080/task/tpi-yearly-light-anemone-1yrn2jft-51sxxrqg<EMAIL_ADDRESS>HTTP/1.1 200 OK
Content-Length: 18
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:47:27 GMT

{
    "id": "evwFZnRn"
}

Wait for the job to finish:
➜  temp http localhost:8080/job/evwFZnRn
HTTP/1.1 200 OK
Content-Length: 39
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:49:00 GMT

{
    "id": "evwFZnRn",
    "status": "executing"
}

➜  temp http localhost:8080/job/evwFZnRn
HTTP/1.1 200 OK
Content-Length: 34
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:49:03 GMT

{
    "id": "evwFZnRn",
    "status": "done"
}

List tasks again:
➜  temp http GET localhost:8080/task/<EMAIL_ADDRESS>HTTP/1.1 200 OK
Content-Length: 13
Content-Type: application/json
Date: Fri, 11 Nov 2022 15:49:14 GMT

{
    "tasks": []
}

Note: this is based on #714

Merging this into #714 to streamline reviews and development.


alpine cannot build rust agent

alpine doesn't support x86_64-unknown-linux-gnu
It only support x86_64-unknown-linux-musl. Even worse,
it doesn't support proc-macro, which is needed for serde_derive

https://github.com/rust-lang/rust/pull/69519

May be fixed by 1.44 https://github.com/rust-lang/rust/issues/40174#issuecomment-618999438

I have tried this and verified that 1.45 has resolved this issue.
$ docker run -it --rm -v `pwd`/kata-containers:/kc  rust:1.45.2-alpine3.12 sh
# cd /kc
# apk add --no-cache musl-dev
# cargo build


Improve the .children API

Hello Guys, this PR improves the .children API a little bit.
Now the children API accepts a number, and this number will filter the index of the children.
Example:
const wrapper = mount(<Component />);

expect(wrapper.children().at(0).type).toEqual('div');
expect(wrapper.children(0).type).toEqual('div');

The 2 above are equivalent.
The thing is, I noticed that I've been using the children().at(x) pattern too much, and this can be simplified by passing the number directly to the children method.
As the selector is a type of filter for the children method, I believe the number can be used as well.
One thing I'd like to ask is: In case  you accept this PR, take a look at the docs and check if the examples are clear enough (I'm not the best doc writter in the world hahahaha).
Cheers

Just an FYI, you can do this in userland. Just do something like this before your tests,
ShallowWrapper.prototype.childrenAt = function(filter, selector) {
  return this.children(selector).at(filter);
}

tests(wrapper.childrenAt(0)).toBeDefined();

@blainekasten totally... But I believe the idea is to provide as many useful methods as possible internally in the library...
I don't think extending the library on the fly would be the best approach.
But thanks for the snippet.
Cheers.

My only concern is that we are creating meaning for an integer in the same argument slot that a selector already is. This doesn't have any issues right now, but if we ever wanted to have a number mean something as a selector, we would not be able to do this.
Using a number as a selector may seem like a strange idea, but it's actually something I've considered for better utility with React Native. React Native produces numbers for the output of StyleSheet.create(), which more or less could act as identifiers in the same way that CSS class names are identifiers for react web.
I'm not in disagreement about the utility of this pattern, though.
An alternative might be to have a new method, called .childAt(number) that does this, without overloading the .children() method.
Thoughts?

childAt sounds good to me, and is a bit more obvious to me that it's doing "at", and returning one thing, then .children(n)

@mauriciosoares would you like to update your PR to use .childAt instead?

cool, I think that childAt(x) may be something less confusing than children(x).
I'll update this PR asap.

We could also work on implementing the :first selector and it's siblings.

hey @lelandrichardson and @ljharb I've updated my PR...
Would you mind to take a look? most importantly in the docs? :)

@blainekasten before we go implementing pseudo-selectors, I'd like to investigate how difficult it would be to bring in https://github.com/jquense/bill in a non-breaking fashion.
It would be nice to have the CSS selection bits of enzyme outside of the project. Additionally having a registerPseudo API would be pretty cool.

@mauriciosoares made a couple of comments. It also looks like you are missing the ShallowWrapper implementation and tests.

You're correct. missed that hahaha.
I'll update the code and docs and let you know.
tks

@lelandrichardson I have updated this PR, would you care to take a look? :)

@mauriciosoares looks great. Can you rebase and squash this into one commit for me?  That'd be perfect!

@lelandrichardson should I squash the "master merge commit" into mine as well?

@mauriciosoares we prefer the rebase workflow....  if you could do an interactive rebase and remove the merge commit, then rebase from upstream, we should end up with a single commit on top of current upstream/master.  Make sense?

sorry for the mess...
I believe that now this is what you expected. (I've never used interactive rebase before :smile:)

@mauriciosoares perfect! Thanks for doing that. This all looks good - merging.

@lelandrichardson :+1:

@lelandrichardson feel free to ping me on the https://github.com/jquense/bill repo with any question you might have. We built it for teaspoon, our enzyme-esque testing lib, so I think there's probably a lot of overlap of needs, and more then happy to collaborate to have it cover more use cases. I had also mentioned this briefly with @ljharb on IRC a while back.


integrate zonal with OnlineStats

https://github.com/joshday/OnlineStats.jl
deepcopy works on any online stat, so we can deepcopy the passed in stats and then fit! into them as part of the zonal.  This can be in a package extension.
Interest?

This would enable e.g zonal(Series(KahanSum(), Variance(), ExpandingHist(500)), raster; of = geoms).

But also the ability to do running means, etc.  Not sure if this is a great idea, but thought I'd put it up for discussion.

You might want to look at the integration of online stats into YAXArrays. There it is not used for zonal, but for table aggregation.

Would be cool to integrate diskarrays chunks, is that what you mean?

More that we could do zonal(OnlineStats.KahanSum(), ras; of = geoms) and have it return one of:

value(stat): a number
stat: an OnlineStats object

Not sure which is more valuable / sensible.  But it would potentially allow us to be completely lazy and avoid materializing anything.  Maybe that's the way to go...


Text/Header strings not prepared to be translated

While working on a translation to Norwegian Bokmål I noticed that there was certain parts that haven't yet been prepared to be translated.
Current findings
The current parts that I found that haven't been prepared yet.

Local/Remote package context menu
Disabled Header in the SettingsView_Source

Places referencing the wrong string

PackageView pin button is referencing the install button text.

I've fixed this in a local commit, so if interested I can open a PR for it.

I'd like to see a PR :+1:

@mwallner PR submitted: #406

Closed by #406

@AdmiringWorm thank you for submitting this, appreciate you taking the time to look at it!

@gep13 no problem, I probably missed some strings somewhere, as well as strings related to exceptions and logging was not added in #406. Mainly because, logging shouldn't be translated IMO, and didn't know which exceptions was displayed to the user so basically ignored those.


Clicking on categories causes a 404

To reproduce:

Go to http://openbuildservice.org/blog/
Click on one of the categories marked on each blog post
=> get a 404

http://openbuildservice.org/categories/documentation
http://openbuildservice.org/categories/releases

fixed by moving to netlify


EIC reference design or example?

I am attempting to use an external interrupt on PA14 on an atsamd51j.  This is an rtic project.
The eic is defined in the resources struct as :
gpioInput: eic::pin::ExtInt14<feather_m4::gpio::Pin<gpio::v2::PA14, hal::gpio::v2::Alternate<feather_m4::gpio::v2::A>>>,

and is initialized as:
let gpioInput = pins.d4.into_pull_down_input(&mut pins.port).into_ei(&mut pins.port);

The hardware task is
    fn gpio_interrupt(cx: gpio_interrupt::Context) {
		*cx.resources.gpioCount += 1;
	}

It compiles and runs, I can see valid pulses with a scope on d4 (PA14).  But, no interrupts are captured.
I am sure I am missing a step.  Is there a reference design or example code for setting up the samd51 for external interrupts?
EDIT:
It seems like I need a reference to hal::pac::eic, but it is not clear how to instantiate it.  Or, I could be chasing ghosts....

Hi @ewwaller , sorry I don't have a SAMD51 board to test with, nor experience with RTIC, but there's an EIC example here for SAMD21 which may help.  Additionally, I think you'll need to unmask the EIC interrupt:
unsafe {
    NVIC::unmask(interrupt::EIC);
}

And possibly add an ISR:
#[interrupt]
fn EIC() {
    defmt::info!("In EIC ISR");
}

That said, I came here after running in to trouble enabling a pullup and interrupt on the same GPIO pin.  It seems the issue is that into_ei() call, which in my case is calling .into_function() and disabling the pullup.

Thanks Ian,
That is pretty close to what I had.  I have it working now, but have a few unanswered question that I still need to resolve.
The atsamd51j hal does not implement eic::init  (at least not as a public function);  it does implement eic::init_with_ulp32k which yields a ConfigurableEIC rather than an EIC.  That ConfigurableEIC provides the expected methods of sense, enable_event, enable_interrupt, etc.   But, the Configurable EIC does nothing until it is ""Finalized" by a call to the finalize method, after which interrupts are processed. All good.   I assert the documentation on all of this is a bit thin.   I imagine the init_with_ulp32k configured the eic so it works when the processor is sleeping.
Problems remain, however.  For instance, how does one disable the interrupts?  The disable_interrupt method seems to only work on the ConfigurableEIC, but will not work with it after it has been finalized and converted to EIC.
Another problem is how this fits into the RTIC framework.   If one sets up the EIC in the init section, the pin (which has been converted into an eic) needs to be passed into the resources structure.   This is because the EIC_EXTINT_xx ISR needs reference to the eic to clear the interrupt.  Since it is necessary to enable the interrupt before it is finalized, and the eic is finalized before it gets passed into the resources structure as a LateRosources, is there not an instant between where the interrupt is enabled and the reference to the pin in the resource structure has not been initialized?  Would not an interrupt during this period be catastrophic?     I suppose it is possible that the init section of RTIC is protected as a critical section with interrupts disabled -- can someone verify whether this is the case?

@ewwaller, where did you land with this? It looks like #444 will land soon. I think you needed pull resistors as well. But it also sounds like there is other functionality missing. Feel free to make a pull request.

@ewwaller, now that #444 has landed, I'm going to close this. Feel free to reopen if needed.


alerts: threshold values for lowering alert levels

Currently
Alert is generated at every alert level change when going up info -> warn -> critical and when coming down critical -> warn -> info -> ok.
Problem
When monitoring for example free disk space level, the value often hovers both below and above the threshold values, causing e.g. a warn -> ok -> warn -> ok -> warn ... cycle. Flapping() percentages cause delays and are not optimal for every purpose.
Problem example:
stream
    |from()
        .measurement('disk')
    |alert()
        // values 20.0,19.99,20.0,19.99,... each cause an alert level change
        .warn(lambda: "free" < 20)

Proposed solution
provide optional, separate threshold functions for resetting a higher severity to a lower one.
Example:
stream
    |from()
        .measurement('disk')
    |alert()
        .warn(lambda: "free" < 20)
        .warn_reset(lambda: "free" > 25)
        .crit(lambda: "free" < 10)
        .crit_reset(lambda: "free" > 15)

In this example the value, once going below 20 and causing the initial "WARNING" alert, would be allowed to fluctuate between 10 and 25 without changing the alert level from warning.

I'm experiencing the same problem. This would be a very useful feature to be implemented to avoid continuous alerts on changes hover up and down the threshold values.

@rossmcdonald I would like to make a PR for this feature. Can you please tell me generally where should I begin? Which files should be involved?

Perhaps the syntax could simply be with an optional extra argument to the alert level functions, e.g. .warn(, [])
Example:
stream
    |from()
        .measurement('disk')
    |alert()
        .warn(lambda: "free" < 20, lambda: "free" > 25)
        .crit(lambda: "free" < 10, lambda: "free" > 15)

@melor  I think using warn_reset is more explicit and cleaner to implement internally.
@minhdanh Thanks for stepping up.
There is a function determineLevel that is responsible for determining the alert level of a data point. It probably needs another arg for the current level...
It can be found here:
https://github.com/influxdata/kapacitor/blob/master/alert.go#L554
Then in the pipeline/alert.go file you will need to field for the *Reset versions of the Alert node:
https://github.com/influxdata/kapacitor/blob/master/pipeline/alert.go#L204
Finally, you will need to parse the ast.LambdaNode expressions into stateful expressions. Which is done starting here for the normal expressions. https://github.com/influxdata/kapacitor/blob/master/alert.go#L313

@minhdanh Also I forgot to mention. You should probably base your changes off #732 since it makes a small change to that code, and is about to get merged.

Thank you for your detailed reply, @nathanielc
I actually already made some changes to the files you mentioned above. Now I'm thinking about writing some test for this feature. I'm going to submit a pull request and it would be great if you can give me some advise on it.

@minhdanh The tests can be found in the integrations/ package. Have a look first at TestStream_Alert. All tests basically replay data from a file found in integratoins/data and then run a TICKscript against that data. In the case of alert tests, a test http server is created and the alert is configured to post any events to it. You can then verify the alert triggered the correct events. A good place to start would to copy TestStream_Alert and create a test TestStream_Alert_WithReset and copy the TestStream_Alert.srpl file and modify it to test the reset conditions.


DCG push back not implemented, will assert rules for (',')//2

I made a little test with DCG rules that have push backs. It should either
translate them correctly or I guess otherwise it would be better to issue
an error not yet implemented.

Hi @jburse.
Thanks for your report. Solved in c985aa31e6f67388e5e265cf706b18af00186769!

(Still having issues with UTF-8 encoding).


Error when accessing port 8002 in feature/2.0

Hi, i read some of issues and found you have feature/2.0 that 5 ahead of main branches, but when i deploy using docker compose and accessing port it showing an error and the mailpit email me something about symphony, sorry i already undeploy, do you mind us step by step how to deploy feature/2,0 or is not stable yet.

Hello,
2.0 is not ready. I'll mergeit  to master and make a release once I'm done. For now You need to use 1.x.
It'll be couple of months before 2.0 is there.
The database structure won't change with 2.0 so updating will be pretty easy.
This will be front for 2.0 later then: https://github.com/Volmarg/personal-management-system-front
That should not really matter anyway, because I plan to make installation easy as well, with single docker-compose file.


Added DNF configuration and Multimedia Support for fedora and other Redhat Distros

Pull Request
DNF Configuration & Multimedia Codecs
Just some essential DNF changes to at least make it usable and faster by a margin.
Also added installation support for multimedia codecs
Type of Change

New feature

Testing
Checked on my System, it works
Issue related to PR

Resolves #289

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

Most distros enable that on the setup

We want this tool to work on any distro, not most.
Arch Linux (a very popular distro), for example, doesn't bundle ffmpeg in base.

Most distros enable that on the setup

We want this tool to work on any distro, not most. Arch Linux (a very popular distro), for example, doesn't bundle ffmpeg in base.

I agree with Adam.


[ci] : adding github actions

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bebaaad). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   95.48%
=========================================
  Files             ?        6
  Lines             ?      332
  Branches          ?        0
=========================================
  Hits              ?      317
  Misses            ?       15
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebaaad...2679432. Read the comment docs.


fix: display regtest instead of testnet

Try out this version of the Hiro Wallet - download extension builds.

Fixes #1251.
cc/  @kyranjamie @fbwoolf

Note that we'll need to replace regtest with devnet in general soon: https://github.com/blockstack/stacks-wallet-web/issues/1763
Should we make that change and display "DevNet" here instead as well?


init() function not called when the cursor is inside the component on mount.

We've experienced this issue, when clicking on a button renders a ReactCursorPosition component, but the cursor is already inside the new component.
In this case, the init() function will not be called until the mouse exits and entered the component again.
An easy fix for this is to call init() function in onComponentDidMount.
I will include a PR to fix this issue.

@aminy - I'm closing this for now due to lack of activity. Please let me know if you have any further thoughts. Thanks!


Add stdx.timeit utility

I've found this sort of utility invaluable for ad-hoc profiling of various things.
Pre-merge checklist
Performance:

[ ] Compare zig benchmark on linux before and after this pr.# benchmark results before
...

# benchmark results after
...

OR

[x] I am very sure this PR could not affect performance.

Do we have something like this somewhere already perhaps?

LGTM
bors r+

bors retry


EML 2.2.0 testing - Unforeseen error

When I try to save the project data of this dataset: https://eml-ipt.gbif-uat.org/manage/metadata-project.do?r=another-test-marie, I get this error:

Index 1 out of bounds for length 1

Thanks. This is a bug, fixing

related #2473


Also enable collapsing from the closing part of a section

Whenever I edit a .js file, I can only use the collapse buttons on the opening part of a section

... not its closing one :

Been able to do so would be a time saver, especially whenever I'm working on test files that embed big chunks of mocking objects.
By big chunks I mean several hundreds of lines 😋

Duplicate of https://github.com/microsoft/vscode/issues/60670


Error with settings  USE_TZ=True

and tox error:
======================================================================
ERROR: test_set (tests.test_cli.CliTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zodman/apps/django-constance/tests/test_cli.py", line 56, in test_set
    self.assertEqual(config.DATETIME_VALUE, datetime(2011, 9, 24, 12, 30, 25))
  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 503, in _baseAssertEqual
    if not first == second:
TypeError: can't compare offset-naive and offset-aware datetimes

WIP

DONE!
well on CONSTANCE_CONFIG for a datetime, i see the datetime must be naive because you dont pass the timezone to de conf. So  i extend the compress method to convert the datetime aware to naive ever .. and some tweaks on unittest @jezdez  i waiting for you VoBo (LGFM)

Seems like there is a bunch of commented code, can you please look into it @zodman ?


Cannot run when yarn uses global cache as repository and the project and cache are in different drives

Describe the bug
I use yarn in plug n play mode where the modules are stored in a global cache like C:...AppData...Local\Yarn.
I just create a project which uses yarn + vite + react. The project is located at D:\Projects.
When I run yarn run dev I got an error "Could not read from file .... react-dom/client.js"
I tried to move the cache to C:.yarn-cache without luck but it worked when I moved to D:.yarn-cache.
I had other react projects working fine using webpack and it's my first time using Vite.
Reproduction
Depends on the cache and project are stored
Steps to reproduce
No response
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 8.25 GB / 15.90 GB
  Binaries:
    Node: 20.9.0 - D:\Program Files\nodejs\node.EXE
    Yarn: 4.1.0 - D:\Program Files\nodejs\yarn.CMD
    npm: 8.18.0 - D:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (121.0.2277.98)
    Internet Explorer: 11.0.19041.3636

Used Package Manager
yarn
Logs
Could not read from file: D:/Desenvolvimento/Estudos/React/vite/.yarn/virtual/react-dom-virtual-91a0a8ad3c/6/C:/Users/andre/AppData/Local/Yarn/Berry/cache/react-dom-npm-18.2.0-dd675bca1c-10c0.zip/node_modules/react-dom/client.js
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi,
created reproduction here: mcenkar/vite-15801
Just simple starter project from https://vitejs.dev/guide/#scaffolding-your-first-vite-project
yarn config set enableGlobalCache false && yarn && yarn dev works just fine, but on default I get:
X [ERROR] Could not read from file: ...path.../.yarn/__virtual__/vue-virtual-42724c22b5/6/...path.../.yarn/Berry/cache/vue-npm-3.4.15-11fe9fcc84-10c0.zip/node_modules/vue/dist/vue.runtime.esm-bundler.js

Currently Vite doesn't support cross-drive links.
Duplicate of https://github.com/vitejs/vite/issues/8908 https://github.com/vitejs/vite/issues/10802 https://github.com/vitejs/vite/issues/15496

@mcenkar Sorry I totally overlooked your comment. I've tried on my Windows machine and I wasn't able to reproduce. Would you create a new issue with more details? (e.g. OS, where the global cache is located)

@mcenkar in my case indeed the error was caused by cross drive link. I can't recommend vite for the rest of the team by now. I hope vite can support this kind of environment soon. Thanks for the replies


Update Readme to describe case of Rails 7 and precision: 6

Describe issue https://github.com/ridgepole/ridgepole/issues/406 in Readme

Thank you!


Shape Mismatch Error in 4track Model (epoch=18-step=20000.ckpt)

I encountered a RuntimeError while using the 4-track model (orthrus_base_4_track) example. Specifically, when my input torch_one_hot has a shape of (1, 4, 495), I get the following error:
RuntimeError: mat1 and mat2 shapes cannot be multiplied (495x4 and 6x256)
Upon inspecting the model, I noticed that the embedding layer is defined as:
(embedding): Linear(in_features=6, out_features=256, bias=True)
Since in_features is set to 6, the error occurs when torch_one_hot has 4 features. However, when I modify the input to have a shape of (1, 6, 495), the code runs successfully and produces an output of torch.Size([1, 256]).
Question:
Is there a version of the model that works with a 4-track input, or is it necessary to use zero padding to convert the input to 6 features?
Thanks

Hi Yufan our cluster is down today but it looks like I might have uploaded either the wrong data config or the wrong config and ckpt file to huggingface (it looks like it's the 6 track version).
I should be able to verify and update huggingface tomorrow, sorry about that!

Hi Yufan it should be working now. Please let me know if it doesn't work for you!

Hi Phil,
Thank you so much for your prompt response and help in resolving the issue, and I’m grateful for the support you provided. The updated version is working smoothly now!


Query parameter is added to the URL within the address bar.

Everything has been working fine so far. Love your work. However I noticed a problem where the query parameter for dynamic pages is added to the URL within the address bar. I setup a simple example here to reproduce the problem:
codesandbox example
Even when I check some of my older branches of 4 weeks ago, where I used version 1.7.2, I get the same issue. So it is probably not related to next-translate-routes, but maybe something else changed. A dependency of a dependency or something. Using different versions of nextjs doesnt help either.
Anyway, not using pathname and query to define the url within the "href" property still works, but I am pretty sure the aforementioned behaviour is not intended.
So in short:
<Link href={{ pathname: "/blog/[slug]", query: { slug: "derp" } }}>
          Link to dynamic page
        </Link>

Results in this URL:
/blog/derp?slug=derp
Instead of:
/blog/derp

@gehaktmolen, thanks for reporting. I experienced the same problem. A complicated one: it took me a few days to rewrite a sensitive part. You can try the lastest prerelease: 1.9.0-2. I think it is nearly ready to be published as 1.9.0, but if you can try it and confirm that it works well, it would help.

@gehaktmolen, v1.9.0 is out, and I don't experience this issue any more. It you do, please reopen it.


What if predicted time more precise...

When the flight are long (eg.5~20km), I might go AFK, but I can't get useful predict time, it undulate a lot. sometimes it become super decrease or even increase. If this mod can estimate from a long time data, records from takeoff, not just several second, may offer more precise predicted time.
Its better if this mod can play a optional reminding sound when begin landing.

I'm aware of the imprecise ETA, I tried to fix it a while back but it is still not great. I'll look into it.
The sound reminder is pretty easy to do, so you can expect it in the next update


Add scripts for image build and e2e test jobs

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We have to ensure kubectl to not have a need to include it into the test
image. This will now be done by the test suite itself to make them more
independent from the environment.
Which issue(s) this PR fixes:
Ref https://github.com/kubernetes/test-infra/pull/18301
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/hold
for some fix

/hold cancel
Works, we just have to run as privileged and on host network to be able to access the kind cluster.

Please take a look again @hasheddan @pjbgf


Persistence volume claim with longhorn not working

I have tried to deploy the chart with a PVC on k3s with Rancher and Longhorn, but keep getting the error:
500 Internal Server Error
POST https://docker.host/v2/app/blobs/uploads/
{"errors":[{"code":"UNKNOWN","message":"unknown error","detail":{"DriverName":"filesystem","Enclosed":{"Op":"mkdir","Path":"/var/lib/registry/docker/registry/v2/repositories/app/_uploads/29ef60bf-e509-4832-a2eb-d60ec8d3e58e","Err":28}}}]}

confirmed with chart 1.11.0
persistentvolume/pvc-cc3a169d-bb5c-4d5a-87e2-6f59572bb2   30Gi       RWO            Retain           Bound    registry/registry-docker-registry                 longhorn                2m14s

accomplished with 1.1.0
persistence:
  enabled: true
  size: 30Gi
  storageClass: 'longhorn'


The latest version is detected in Windows Defender

The last version of the virus 'Trojan:Win32/Wacatac.B!ml' is detected in Windows Defender.
Does the added code cause this?


Update numi - version / url

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Simplify version and url.

Doesn't the versioned URL work anymore?

The versioned url still works, this is easier to update.

Nevertheless, versioned URLs are preferred since they don't break the sha256 when a new version is released.


fix: clientOptions to override Axios/Fetch options

Codecov Report

Merging #401 (f9799e7) into main (d2dc525) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   88.93%   88.93%
=======================================
  Files          71       71
  Lines        4553     4553
  Branches      589      589
=======================================
  Hits         4049     4049
  Misses        503      503
  Partials        1        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Typescript definitions?

Describe the solution you'd like
Are there any plans to bundle typescript definitions for this package?
Would you like to implement your proposal on your own using a pull request?
I can't see the source is committed to this repo, so I don't think a PR would be (easily) possible

@leereichardt, thanks for the issue!
Yes, I have plans to add typescript definitions. Moreover, there are plans to port the entire library to TypeScript.
About PR.
This repo does not have any other code sources.
I'm sorry, it looks like I misled the name of the lib folder. Looks like it should be renamed to src.
If you want to contribute - feel free to do PR.

Ah, thanks for that. I'll see if I can generate some basic and useful definition files until it's ported over to TS.

@leereichardt migration to TypeScript is done 🚀


router.push & router.replace to return promise if callbacks are not provided

What problem does this feature solve?
It would help preventing callback hell... Would be more consistent with vue js api...
What does the proposed API look like?
router.push('/new/url').then(() => doSomeCoolStuff())

This seems to work fine if for example your component is expecting an event.
methods: {
  asyncRouterPush (route) {
    return new Promise(resolve => {
      resolve(this.$router.push({ path: route }))
    })
  },
  doSomething (myVar) {
    this.asyncRouterPush(myVar)
      .then(() => {
        this.$root.$emit('someEvent')
      })
  }
}

Any progress on this? Seems a bit backwards in 2019 that we still have to use a callback API.

Here's a simple helper function in the mean time...
/**
 * Async push method
 */
router.pushAsync = function(route) {
  return new Promise((resolve, reject) => {
    router.push(route, resolve, reject);
  });
};

I will try implement this issue.

The problem is UnhandledPromiseRejectionWarning if we dont implement catch for previous implementations.
router.push should throw error on route abort? Or should resolve with undefined on route abort?

Yes, it's similar to nextTick. It must work when Promises are not supported. The behavior only changes when no callback is passed and there is support for Promises


Extending multiple interfaces where the interfaces expand on deeper inherited interfaces

TypeScript Version:
3.6.3-Nightly (this was working in 3.5.2 and prior)
Search Terms:
extends multiple compatible interfaces not identical
Code
interface Events<T> {
    emit<K extends keyof T>(name: K, obj: T[K]): void;
    on<K extends keyof T>(name: K, func: (obj: T[K]) => void): void;
}

interface WidgetEvents {
    onclick: MouseEvent;
}

interface Widget extends Events<WidgetEvents> {
    // ...
}

interface TextboxEvents extends WidgetEvents {
    textchanged: KeyboardEvent;
}

interface Textbox extends Events<TextboxEvents>, Widget {
    // ...
}

declare const w: Widget;
declare const t: Textbox;

w.on("onclick", e => { })
t.on("onclick", e => { })
t.on("textchanged", e => { });

Expected behavior:
Works, no errors
Actual behavior:
Error on the interface Textbox declaration
Interface 'Textbox' cannot simultaneously extend types 'Events<TextboxEvents>' and 'Widget'.
  Named property 'emit' of types 'Events<TextboxEvents>' and 'Widget' are not identical.

and similar for on.
Playground Link:
https://www.typescriptlang.org/play/?ts=3.8.0-dev.20191105&ssl=1&ssc=1&pln=31&pc=1#code/JYOwLgpgTgZghgYwgAgKIDcLgM4B4AqAfMgN4CwAUMtchALbBi4DStAHpCACbbIDWEAJ4B7GMiIAKEHDoQAXMmYAaZMIBGAKwX4A2swC6ASgXphwLgG5KNVSBbtOPfkNHjCUmfMUqYAVxAIChLqWuJ6RsgAvMSm5sbIsZaUAL6UaRSgkLCIKADq5gDmEGAYWGC85FQ0wgEANsAIfAoAssK+2BCl4FYUqRSUmdDwSMj5XEVgDlhOXeW4YxOz2MSVNgD0a8gAdDsp6QPgQzniEBxqwmxLU9y8C8VXqzSQHAgAFnAgRVwKzELncFAuLMen0Dllhih8KcwOc2NcZpgcARobCloQVHdJo9qBttrtevsKFwIAhagCUAgathJgB3BSYnrE0nk5CUkDU5BgbQoi49Sg0rY1CQAIhqpIafGFKhQ0VIyGShkoYEFIBFYvqjSltCiK3liooyqFwueYDeHy+WpluoVFiAA
Related Issues: #8606, #16936
Came across this while upgrading our project from 3.5.2 to 3.7.2, we rely pretty heavily in our typings for a JS library on the above pattern. I looked through the list of breaking changes for TS 3.6
but didn't see anything related to the issue. I note that it is quite similar to #16936 but opted to open a new issue since this was accepted by the compiler in prior versions where that ticket was never considered fixed.
Also, sorry about the title, hopefully the code makes it more obvious what I'm talking about!

This is the intended behavior; prior versions of TS had a bug where certain conflicts were not correctly detected. The types of these properties don't agree and you need to resolve the conflict.
Example:
Setup
interface Events<T> {
    emit<K extends keyof T>(name: K, obj: T[K]): void;
}

interface WidgetEvents {
    onclick: MouseEvent;
}

interface Widget extends Events<WidgetEvents> { }

interface TextboxEvents extends WidgetEvents {
    textchanged: KeyboardEvent;
}

interface Textbox extends Events<TextboxEvents>, Widget { }

The problem:
declare const w: Widget;
// OK
w.emit("onclick", null as any);
// Error
w.emit("textchanged", null as any)

declare const et: Events<TextboxEvents>;
// OK
et.emit("onclick", null as any);
// OK
et.emit("textchanged", null as any);

declare const t: Textbox;
// OK
t.emit("onclick", null as any);
// Is this supposed to be an error or not?
// The two base interfaces disagree
t.emit("textchanged", null as any)

Ahh, okay. So we were relying on a bug in older TS versions - that makes sense. We will deal with this internally then. Thanks for your time!


Update nf-d3d11-id3d11device-checkmultisamplequalitylevels.md

I hope this version is correct.
At least that’s the behavior I’m observing on my PC with Ryzen 7 5700G CPU, GeForce 1080Ti GPU, and Windows 10 20H2.

Since there's uncertainty, I'll get a technical review. Please stand by.
-Steve

Really good catch!
CheckMultisampleQualityLevels's returned HRESULT is based on the app passing in good parameters understood by the runtime(e.g., not a sample count of 0, or some garbage DXGI_FORMAT). The returned HRESULT is not really based on anything the driver says.
So yeah, it is possible to have CheckMultisampleQualityLevels return S_OK since your parameters were all good, while yielding a numQualityLevels of 0 since that's what the driver reported.
Good for docs to indicate this. Thank you!

@stevewhims OK, but I’m pretty sure their response is going to be “that’s up to GPU driver to decide”.
For instance, in this very article Microsoft says “FEATURE_LEVEL_11_0 devices are required to support 8x MSAA”, however in reality, Intel Haswell GPU, which on paper supports D3D 11.1, only supports 4x MSAA.


Treat *.logstash.conf files as language-logstash

Please have the language-logstash plugin trigger more intelligently. Right now, even naming my files blah.logstash.conf is not enough for language-logstash to activate. Instead, my logstash configuration files open in a generic Unix conf mode.

I am also affected by this. I dont have a file ending. would be nice if a user could define a pattern to match


Extracted SDS theme from app.tsx to theme.ts, updated global font to …

…Inter
Reviewers
Functional:
Readability:

Changes

add
remove
modify

Definition of Done (from ticket)
QA steps (optional)
Known Issues

Ah @hthomas-czi I forgot if this PR is still WIP 😆 If so maybe we can change it to a draft? Thank you!

Hi @tihuan. I think this can be reviewed and merged!
The only problem I noticed in Storybook is the correct font isn't always used (like in dropdown menus), but I'm not sure if that's a Storybook bug or an actual issue.

Hey Harley! I created an rdev with some fixes for the branch here:
https://thuang-sds-theme-frontend.rdev.single-cell.czi.technology/
Can you please take a look to see if it looks good?
If so I'll merge my PR into yours, and then we can merge this PR into main!
Thanks so much!

Also how did you test this in storybook again lol? I was testing it in Data Portal only 😆

Hey @tihuan! Sorry, I must have missed this in the bustle of team week.
Thank you for putting it on rdev. To test on Storybook, I just manually replaced the theme file and ran Storybook locally.
This looks good. There are just a few small changes I think we should make. What do you think is the best way to incorporate those?

Hey Harley!
No worries yeah I figured it was the home week 😆
Maybe just add your comments here and I can update the PR or something?

@hthomas-czi will automerge this after tests pass! Thanks so much for upgrading the look and feel of Data Portal 🎉 ✨ 👏


Update all alternative pages

Story: https://mojdigital.teamwork.com/#/tasks/20196427
Screenshots

🎉 Thanks. Good catch on the second broken link, didn't know there were 2 of them 👍


examples/models/state_dicts/squeesenet1_1_imagenet.pth not find

Hello author, as the title suggests, there seems to be a missing file in the example of imagenet，"examples/models/state_dicts/squeesenet1_1_imagenet.pth"

here is the screenshot

in squeezenet_imagenet.py


Apply API field renames

Packages impacted by this PR

@azure-tools/communication-short-codes

Issues associated with this PR
--
Describe the problem that is addressed by this PR
NOTE: THIS PACKAGE IS A PRIVATE PREVIEW RELEASE, NOT INTENDED FOR EXTERNAL USE
Some API contracts needed to be changed for internal reasons in the dependency chain, and those changes need to be reflected in the SDK. This will not be a problem for older SDK versions, since (for now) the REST API supports both versions.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
--
Are there test cases added in this PR? (If not, why?)
No tests added since they all rely on deep comparisons. Only a few fixed were needed (renaming fields).
Provide a list of related PRs (if any)

https://github.com/Azure/azure-sdk-for-js/pull/18429

This is the initial pull request that makes it clear that this package is for internal use only

Command used to generate this PR:**(Applicable only to SDK release request PRs)
--
Checklists

[x] Added impacted package name to the issue description
[x] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

Looks good overall, I just have a few comments/questions:

Shouldn't a new version of the API be used? Based on this comment it appears that there should be at least two different supported versions of the API:

This will not be a problem for older SDK versions, since (for now) the REST API supports both versions.

However, the API version in the swagger spec remains the same as the previous one: 2021-10-25-preview. I may be wrong in this though, since I don't have the context as to how these updates are implemented in the backend.

It appears that the change broke some tests, that will need to be fixed before marking this as ready for review.

@danielortega-msft

Shouldn't a new version of the API be used?
So, we discussed that internally and since our api is private now (and the sdk is only used internally), there's no need for us to introduce a new version :)

It appears that the change broke some tests, that will need to be fixed before marking this as ready for review
They're breaking because the new API changes aren't up yet, so there's a mismatch between the expected data and the actual data. This should be fixed as soon as the API gets updated (which I'll have to commit the new test records).


Convert to TypeScript

Add https://github.com/custom-cards/custom-card-helpers

Fixed in https://github.com/custom-cards/roku-card/releases/tag/1.0.0


Mention #93 fixed #89

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.557%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
334

Relevant Lines:
395

💛  - Coveralls


Update uncompleted tasks total time every update

The "total" time of a task was sent from the subscriber to the console each time there was any other change for the task. However, tasks that didn't have changes wouldn't send updates, and so their total time would lag behind. This fixes it so all tasks in the console have an up-to-date total time, by:

The total time is now only sent in a Task proto when the task is completed.
The subscriber's "current" time is sent in every TaskUpdate.
The console uses that time to calculate "total" time if the task isn't completed yet.

The total time is now only sent in a Task proto when the task is completed.

one thought: would it make more sense to just send a completion timestamp in StatsUpdate, and have the client always calculate total times? we can change that in an additional follow-up though.


[Code health] Catch only transient errors for retry in PhotoSyncWorker

From https://github.com/google/ground-android/pull/404#discussion_r396719499
@scolsen, "it might make sense to fail against certain exceptions—not sure precisely what exceptions that function can throw, but I imagine there may be some cases that are unrecoverable, in which case it doesn't make sense to continue retry work."

The number of retries is bounded, so even unrecoverable errors will cause photo upload to be aborted (eventually).

True, I don't think it's high priority for precisely that reason, but it feels wasteful for us to attempt any number of retries for cases which we know will never succeed, e.g. unsupported photo file type (which should happen rarely, if ever, in the first place) I think is one failure case in which it makes no sense for us to mark the work for retry as it will fail every time (the file extension for that particular unit of work will remain stable while we attempted to needlessly process it N times — that's N potential DB writes, etc. that would be happening for no good reason).

Removing "Done" status based on conversation above


Refactored edpm_download_cache role

splitted packages and container images downloads in two different files
added edpm_download_cache_packages and edpm_download_cache_container_images variables to enable/disable download of packages and container images
enabled the installation of podman via edpm_podman role since it's a requirement for podman_image module
added tags in the tasks

/test pre-commit-test

@slagle @fao89 @jpodivin i had to patch github action and pre-commit config because it started to raise weird errors (see the pre-commit prow jobs logs). I enforced the use of "our" version of python (3.9) and cleaned-up the pre-commit cache. I wanted to try a newer version of ansible-lint, but maybe it's material for a different PR.


Add option on layer called disableEdit

SDK-542

Coverage increased (+0.004%) to 74.126% when pulling e1c198549d89d2ce1593993ba270d2b223e80bf1 on disable-edit into 8b70aa7a571cdd412aab46dfb897d438626d3ba5 on master.

Coverage increased (+0.004%) to 74.126% when pulling bd3ee8e74c9555933cb983be7845a3dc317ab3f9 on disable-edit into 8b70aa7a571cdd412aab46dfb897d438626d3ba5 on master.