Base Java SE version to use in APIs

Do we have any expectation that our base Java SE API requirements will be higher than Java SE 11? Currently SE 11 is sufficient, but there has been discussion around having Java SE 21 be the base for EE 11, and SE 17 would be the minimum runtime required version. I guess any reliance on SE 17 or higher would require a major CDI release.

I'm not aware of anything we'd wanna do that would require bumping to 17.

Unless we want to explicitly specify CDI behavior with some newer Java constructs (such as records), I can't think of anything forcing us to use newer JDK versions.

Jakarta EE targets Java 21.

Official positioning here: https://jakarta.ee/about/meeting_minutes/marketing_committee/minutes-marketing-0112-2023.pdf

Jakarta 11?

yeah, Jakarta EE 11. https://github.com/jakartaee/jakartaee-platform/issues/553#issuecomment-1515845484

I think we agreed that the next version will be 4.1, which in my opinion prevents bumping the minimum Java version. We don't intend to do any significant API changes anyway, so I believe we can just stay on 11.
Records are a massive pain from CDI perspective, actually, because they are always final and therefore:

cannot be used to define normal scoped beans,
their methods cannot be intercepted or decorated,
there may be more.

I know there is certain school of thought out there that considers bumping the class file version not a breaking change, which is totally beyond me. If we bump the minimum Java version, we should make it a major release in my opinion.

Just to be clear, my previous comment isn't meant to indicate that we should bump the JDK version. I am just not aware of any jakarta-specific restrictions on that WRT minor versus major version of the given spec.
In fact, I am rather in favor of keeping the version lower unless we somehow directly benefit from the upgrade. That way, more people can use CDI (likely outside of Jakarta itself).
Note that we can still state the limitations people can encounter in the spec WRT newer JDKs - such as mentioning java records for which we needn't do anything but we can still warn users that they are by definition restricted as beans (final class, no no-args constructor by default)

Hm, the spec can handle the new features (SE 21) but the API can still be compiled with 11, or?

Yeah, agree. The API doesn't need to use any new features, but the spec can specify the behavior. We could for example add something like the following.
Chapter Managed beans:

If a managed bean class is a record, it may not declare a normal scope. The container automatically detects the problem and treats it as a definition error.

Chapter Producer methods:

If the producer method return type is a record, the producer method may not declare a normal scope. The container automatically detects the problem and treats it as a definition error.

Chapter Producer fields:

If the producer field type is a record, the producer field may not declare a normal scope. The container automatically detects the problem and treats it as a definition error.

Chapter Unproxyable bean types:

Certain legal bean types cannot be proxied by the container:

...
primitive types,
array types,
and records.

The modification to Unproxyable bean types covers interceptors and decorators. It would actually also cover normal scoped records, but that would mean normal scoped records are a deployment problem and I'm thinking definition error is perhaps better in this case.

If a managed bean class is a record, it may not declare a normal scope. The container automatically detects the problem and treats it as a definition error.

Note that statements like these will be untestable as TCK needs to have the same min. JDK (for instance 11) and as such won't know records.
We could OFC have a separate TCK module that holds newer ones but that would then require an adjustment to the definition of passing the TCKs which might be quite a hassle combined with the fact that we already have split TCKs in many ways.

Good point. We actually already have that problem in the Lang Model TCK, where we just don't test records at all :-)
But as far as I am concerned, we could bump the TCK to Java 17 (or 21) and leave the API on 11.

But as far as I am concerned, we could bump the TCK to Java 17 (or 21) and leave the API on 11.

Hmm, I am not sure you can do that.
If you want to claim min JDK version 11, you should allow any such (potential) impl to pass the TCK with that given JDK and that would no longer be possible. Or am I missing something?

Well, you couldn't run the TCK with Java 11, but you could run it with Java 17 even if the target runtime is built with Java 11, which would be kinda the point. You could claim compatibility with Java 17, but would still be able to run with Java 11.
It sounds weird, but also useful, to me at least.

If the producer field type is a record, the producer field may not declare a normal scope. The container automatically detects the problem and treats it as a definition error.

If possible to declare a record as Singleton, no proxy on the bean?

If possible to declare a record as Singleton, no proxy on the bean?

As far as I can tell, that would work -- if the bean is not intercepted or decorated.

If possible to declare a record as Singleton, no proxy on the bean?

As far as I can tell, that would work -- if the bean is not intercepted or decorated.

Maybe, but it still is not a very useful construct given that you have to deal with the zero arg constructor in the producer and how do you pass these arguments in? As seen by prototyping of what might be done in Validation, having generally useful records requires something like a proxy constructor via a qualifier at the injection site that has non-binding fields. A record is really more like an entity bean in terms of how it can be meaningfully produced.
It almost seems like a new @Constructor qualifier annotation would be needed, but is that a useful pattern?

Yeah I wouldn't use records to declare CDI beans myself. Their usefulness on that front is very limited -- they basically only make sense for pseudo-scoped beans that are not intercepted nor decorated.
I wouldn't try to shoehorn records into normal scopes, interception and decoration. It's a lot of pain for very small gain.

Actually, we just need the build SDK to be 17. Both artifacts can use a target version of 11 even though the depend on a SE 17 artifact. That seems a little strange, but I guess the linkage to the class does not entail any preclude differing SE versions.

Actually, we just need the build SDK to be 17. Both artifacts can use a target version of 11 even though the depend on a SE 17 artifact. That seems a little strange, but I guess the linkage to the class does not entail any preclude differing SE versions.

Yea, this is pretty much what I discovered during Beta release of CDI API - I used JDK 17 but the compiler version in pom.xml is still set to 11 and that works just fine.

Actually, we just need the build SDK to be 17. Both artifacts can use a target version of 11 even though the depend on a SE 17 artifact. That seems a little strange, but I guess the linkage to the class does not entail any preclude differing SE versions.

Yea, this is pretty much what I discovered during Beta release of CDI API - I used JDK 17 but the compiler version in pom.xml is still set to 11 and that works just fine.

Should CDI 4.1 be better off with Java 17? Is there any use case that CDI 4.1 are used outside of EE 11 using Java 11? If it does, the EL bit is not working.

Yes, the Java SE bootstrap mode as well as straight embedded Weld is
heavily used. The EL bit is only available in EE environments, so the fact
that it is still there in BeanManager is an artifact of the EE deprecation
process.
On Fri, Feb 23, 2024 at 4:34 AM Emily Jiang @.***>
wrote:

Actually, we just need the build SDK to be 17. Both artifacts can use a
target version of 11 even though the depend on a SE 17 artifact. That seems
a little strange, but I guess the linkage to the class does not entail any
preclude differing SE versions.
Yea, this is pretty much what I discovered during Beta release of CDI API

I used JDK 17 but the compiler version in pom.xml
https://github.com/jakartaee/cdi/blob/main/pom.xml#L122 is still set to
11 and that works just fine.

Should CDI 4.1 be better off with Java 17? Is there any use case that CDI
4.1 are used outside of EE 11 using Java 11? If it does, the EL bit is not
working.
—
Reply to this email directly, view it on GitHub
https://github.com/jakartaee/cdi/issues/650#issuecomment-1961086522, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACRDMWXGMJXJBJBNAOVNODYVBWDFAVCNFSM6AAAAAAU3XASKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGA4DMNJSGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

My question was about CDI 4.1 under Java 11 usage not about the standalone CDI 4.1 usage @starksm64 ?

There is no technical reason to preclude existing 4.0 users from upgrading
to 4.1 while using SE 11, and there is no benefit to producing SE 17
targeted binaries when there are no 17 language level features.
On Fri, Feb 23, 2024 at 9:25 AM Emily Jiang @.***>
wrote:

My question was about CDI 4.1 under Java 11 usage not about the standalone
CDI 4.1 usage @starksm64 https://github.com/starksm64 ?
—
Reply to this email directly, view it on GitHub
https://github.com/jakartaee/cdi/issues/650#issuecomment-1961529624, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACRDMTL2JTV2FLWBEJPVGLYVCYGVAVCNFSM6AAAAAAU3XASKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGUZDSNRSGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Current master does not work on 15.4

15.4.2 installed, no any 15.5 previews and have never been on this machine.
Load VFT solution, master branch
F5
Create a console project in the exp instance
Result

Even keyboard does not work properly - arrow keys, Del and Backspace do not work.

Ouch.  I was about to install master on my machine too.
@cartermp  @brettfo @KevinRansom  Any ideas on what we need to do to get master valid for 15.4 development?  I presume it's been the recent update to Roslyn dependencies? How can we address this in the future?

Probably when I updated dependencies yesterday.

Just online with dell, my laptop has a motherboard issue.  Then I will try to revert the change.

@dsyme I find 15.5 pre 3 is good and faster than 15.4, so maybe it's worth to just switch to it.

Lol ... and side by side.

@dsyme I find 15.5 pre 3 is good and faster than 15.4, so maybe it's worth to just switch to it.

AFAIU our policy is that master and vs2017-rtm require latest public non-prerelease Visual Studio 2017, and that currently we don't have a specific established technique to allow development with prereleases (though we obviously need one)
I'm fine with solving this via having multiple branches (master and vs-latest-prerelease or something, or just master and release) or whatever, but I'd just like that we have a policy and stick to it.

I experience this too. Had to uninstall the nightlies.


(Mainnet Verification) [Bug 🐞]: Can't change pages in dedicated nodes - https://next.dashboard.grid.tf/#/deploy/dedicated-nodes/

What happened?
https:// next.dashboard.grid.tf/#/deploy/dedicated-nodes/
can't move to next page, does not load, can't move to last page, nothing happens clicking the arrouw > >|
What did you expect?
to be able to change pages
What browsers are you seeing the problem on?
Chrome
ZOS info
No response
Dashboard info
No response
weblets info
No response
Relevant log output
No response

Verified, Mainnet 2.3.0.
The dedicated node table is now working fine with pagination and items per page.
screen-capture (21).webm
TC2219 - List Dedicated Nodes


Release 0.0.11

PR summary
Cutting a release. ref https://github.com/holochain/lib3h/issues/455
Review checklist

[ ] The story has unit or integration tests
[ ] No new bugs, and any tech-debt is identified and justified
[ ] There is enough API documentation (how to use)
[ ] There is enough code documentation (how the code works)

It effectively became release 0.0.13


python38Packages.ntc-templates: 2.2.2 -> 2.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.ntc-templates is: "TextFSM templates for parsing show commands of network devices"
meta.homepage for python38Packages.ntc-templates is: "https://github.com/networktocode/ntc-templates"
meta.changelog for python38Packages.ntc-templates is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.3.0 with grep in /nix/store/sl0l3pjryiv87p4nxh7vkcjpg38xf73a-python3.8-ntc-templates-2.3.0

found 2.3.0 in filename of file in /nix/store/sl0l3pjryiv87p4nxh7vkcjpg38xf73a-python3.8-ntc-templates-2.3.0

directory tree listing: https://gist.github.com/bcffebeee9517f97958c3c78efab1f3d

du listing: https://gist.github.com/0d64ebc2419898f6520dc6162f4c7564

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.junos-eznc
python38Packages.ntc-templates
python39Packages.junos-eznc
python39Packages.ntc-templates

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sl0l3pjryiv87p4nxh7vkcjpg38xf73a-python3.8-ntc-templates-2.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.ntc-templates https://github.com/r-ryantm/nixpkgs/archive/c7cccc55fe2fb39761ce6427294a102af865971a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sl0l3pjryiv87p4nxh7vkcjpg38xf73a-python3.8-ntc-templates-2.3.0
ls -la /nix/store/sl0l3pjryiv87p4nxh7vkcjpg38xf73a-python3.8-ntc-templates-2.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python38Packages.junos-eznc
python38Packages.ntc-templates
python39Packages.junos-eznc
python39Packages.ntc-templates

Maintainer pings
cc @mweinelt for testing.

Result of nixpkgs-review pr 136025 at c7cccc55 run on aarch64-linux 1

4 packages built successfully:

python38Packages.junos-eznc
python38Packages.ntc-templates
python39Packages.junos-eznc
python39Packages.ntc-templates


Allow resampling of timeseries data.

This PR introduces the ability to fetch time series data resampled according to a provided resampling_interval and ResamplingMethod. The ResamplingMethod is set per Variable.

Something else just crossed my mind. Didn't we specify that the SDK should allow specifying the resampling method per variable data type? We have consciously built the API such that the resampling method is defined per variable for maximum flexibility, knowing that we can handle the translation in the SDK.

Where did we specify that? That was not my understanding at all.

It's the latest documented state in https://github.com/enlyze/timeseries-service/issues/190, but that's already quite dated. Given that #3 doesn't specify the granularity on which the resampling method should be provided it's fine to stay as it is in this PR I guess.

@daniel-k docstrfmt conflicts with flake8 here https://github.com/enlyze/enlyze-python/pull/6/commits/78d3b64ce8efd6df7b28a46632c8243d13e1fbb5
What do you suggest we do?

@daniel-k docstrfmt conflicts with flake8 here https://github.com/enlyze/enlyze-python/commit/78d3b64ce8efd6df7b28a46632c8243d13e1fbb5
What do you suggest we do?

What about adding # noqa: E501 for that docstring?

@daniel-k Can you please re-review as I can't re-request review.


Documentation of the BuildReport.json file

Hi,
Is there documentation describing the structure and content of the BuildReport.json file, and other related files?
Thanks.

@FALLAI-Denis , please have a look to the IBM Docs centre for DBB:
https://www.ibm.com/docs/en/dbb/2.0.0?topic=apis-build-report
The JavaDoc for the reports:
https://www.ibm.com/docs/api/v1/content/SS6T76_2.0.0/javadoc/com/ibm/dbb/build/report/records/Record.html
Also the Self-paced training has a talks about the Buildreport
https://ibm.github.io/mainframe-downloads/Training/dbb-self-paced-learning.html


Fix compression algorithm parsing

Context: https://github.com/grpc/grpc/pull/19023#discussion_r284410354
There is definitely a bug because *has_compression_algorithm is always set to true.
I'm trying to understand the code and simplify it. But I'm not sure if this is the intended code logic. @muxi Please review the change carefully.

There is a real failure I think: https://source.cloud.google.com/results/invocations/9c83d72d-5805-4449-bcdd-a203a78264c2/log

@AspirinSJL - For the revisions as we discussed offline, are you going to make them in this PR or in a separate PR?

@muxi I will either change the code or add TODO items for all the things we discussed today.

OK I'll wait for your change

I'm still waiting for the test results.

The tests seem to fail. Would you be able to take another look please @AspirinSJL ?

Sorry for the delay! I'm looking at the failures.

No worries. thanks!

@muxi This PR is reviewable now. Thanks!

Interop Cloud-to-Cloud Tests (internal CI): https://github.com/grpc/grpc/issues/16580
Interop Cloud-to-Prod Tests (internal CI): https://github.com/grpc/grpc/issues/16580


project zomboid wont open

Project Zomboid does not have an achievement board ;)

Project Zomboid does not have Steam achievements.


In 1473

Rescission fields and other GPI content type issues. This may replace your open PR.

All my PR had was the template.


Pottential speedup: ujson or orjson

A potential speedup we could add to the mix is ujson, which after some quick testing, it seems to be a drop in replacement to the standard libraries implementation, but performs a lot better, which is already noticeable on startup, so could be even more significant for large bots, so might be worth looking into:
stdlib:

ujson:

Typehints are provided through typeshed, so shouldnt have an issue with typecheckers

If you want to provide feedback on this issue and test it yourself, you can easily do it by adding the following lines to your bot script (after installing ujson):
import ujson
from hikari.internal import data_binding

data_binding.dump_json = ujson.dumps
data_binding.load_json = ujson.loads

Have you looked into orjson? orjson is a larger library compared to ujson but its marginally faster in decoding benchmarks I think are more applicable to this project and its encoding speed is over 2x faster than ujson in all the benchmarks.
https://github.com/ultrajson/ultrajson#benchmarks

I did in fact look at it, but it seems to perform slower than ujson in our case. I re-ran the benchmarks provided by ujson here and did see orjson performing considerably better, but when it comes to a Discord workload, ujson shows better performance. I havent really looked into it (a bit why I opened this issue instead of a PR).
You can test it out yourself by replacing this specific line with send_bytes
https://github.com/hikari-py/hikari/blob/deb3ed15b7adfb2581f9869048c50586563c4d5c/hikari/impl/shard.py#L201
If anyone can run performance tests on their bots, please feel free to share, they are greatly welcome!

PS: While looking into this, I stumbled on this issue from Sanic regarding the same results I encountered: https://github.com/sanic-org/sanic/issues/1479#issuecomment-932960095

So I've experimented on Carberretta, and the differences are pretty minimal. I tried 3 times with each, and these were the average results:

Normal: 2.22s
ujson: 2.17s
orjson: 2.25s

I reckon some more data could be helpful, but there doesn't seem to be any major differences. The differences are smaller on a bot with more parts at the very least.

Since orjson was brought up, I experimented a bit with it and came up this branch.
I am still not fully happy with the outcome and have some plans to improve it even more, bringing in support to be able to pass json.loads and json.dumps singnature compliant functions.
Regardless, any testing on that branch (specially in large bots, if possible) would be welcome and appreciated!

I feel like this line should be changed or removed, as most bots will be running with optimisation flag 1 or 2, which remove assert statements.
https://github.com/hikari-py/hikari/compare/master...davfsa:hikari:task/orjson#diff-9aeb579dd7fd79080ace8defc3a3d27bf3855168dd1e4e7968727d5689d93fb3R431


[Improve][Flink][core]The outdated method of creating a table is deprecated

…ecated

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Do you have any ideas about how to declare a Schema for the createTemporaryView method in Flink1.15?

The latest dev branch has resolved some e2e test issues; it needs to be merged.

The latest dev branch has resolved some e2e test issues; it needs to be merged.

done, merge


Change harrow court items to class or spell DC

Paizo actually clarified this one.
https://paizo.com/community/blog/v5748dyo6sia5&page=2?Introducing-the-Stolen-Fate-Player-s-Guide#56

Conflicts!

Conflicts resolved peacefully


Use Jackson for JSON parsing

Handled in https://github.com/ThomasVitale/langchain4j-spring-boot/commit/b85aa738d75ec15327268223f32fe68425f690e2


rest assured generate url post test

Description
This PR includes rest-assured generate url post test, dependency changes to pom.xml. Made changes in log4j properties file output a log file.
-Partial completed jira ticket https://justice.gov.bc.ca/jira/browse/FLA-44
Type of change

[x] New test(non-breaking change which adds backend tests)

How Has This Been Tested?
Tested locally
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code

@sdevalapurkar-bcgov pull the trigger


WIP: lagged ILU preconditioned JFNK for ex10

I've finally worked out how to use scipy.optimize.root for pure (sparse!) Newton iteration (which fixes #119), pure JFNK (superseding #442), and many options for in between.
As Knoll & Keyes (2004, §3.5 ‘Matrix-free preconditioning approaches’) put it:

There is a continuum of choices ranging from forming no preconditioner to forming the complete Jacobian.

Basically scipy.optimize.root(method="krylov") runs the Newton iteration using finite difference approximations to the Jacobian.  Since it solves the Newton iteration equation with a Krylov method, it only needs the action of the Jacobian on a vector (basis vector of the Krylov space) and this is cheaply computed with the finite difference approximation to the Fréchet derivative in the required direction.
But root also accepts a preconditioner and if that preconditioner were the actual Jacobian, the Krylov iteration would converge in a single step.  In between those two extremes we can approximate the Jacobian in the preconditioner using ILU and we can lag it, only updating every p steps.  Here I take p = np.inf, so only the Jacobian of the initial guess is ever assembled and (incompletely) factorized.
This is still quite rough, but I think it works well and hopefully demonstrates some of the principles that I'd been talking about in connexion with hyperelasticity. #439

Thanks a lot @gdmcbain ,
Just finished taking a look at the paper and also this. Quickly adapting to the hyperelasticity example, there seems to be a trade-off when trying to improve the inner preconditioner. The overall convergence improves dramatically:
0:  |F(x)| = 0.0194247; step 1
1:  |F(x)| = 0.00301762; step 1
2:  |F(x)| = 0.000207081; step 1
3:  |F(x)| = 3.60293e-06; step 1
4:  |F(x)| = 2.80194e-08; step 1
5:  |F(x)| = 1.39458e-10; step 1
6:  |F(x)| = 3.44131e-13; step 1
7:  |F(x)| = 2.86443e-16; step 1

vs
0:  |F(x)| = 0.0382248; step 1
1:  |F(x)| = 0.0102671; step 1
2:  |F(x)| = 0.00692618; step 1
3:  |F(x)| = 0.0017736; step 1
4:  |F(x)| = 0.000146487; step 1
5:  |F(x)| = 5.72064e-06; step 1
6:  |F(x)| = 1.98364e-06; step 1
7:  |F(x)| = 4.99592e-07; step 1
8:  |F(x)| = 5.5456e-08; step 1
9:  |F(x)| = 6.83088e-09; step 1
10:  |F(x)| = 8.3604e-10; step 1
11:  |F(x)| = 3.82326e-10; step 1
12:  |F(x)| = 2.96208e-11; step 1
13:  |F(x)| = 2.95233e-12; step 1
14:  |F(x)| = 5.11091e-13; step 1
15:  |F(x)| = 4.30558e-14; step 1

but the only assembly of the jacobian done to precondition the inner Krylov inside the update function increases the solve time significantly. I will do some more checks tomorrow, and then hopefully run cProfile over the weekend to isolate the bottleneck (it most likely is the calculation of jacobian)
J = asm(jacNewton, iBasis, w=iBasis.interpolate(u_full))

I will start back on completing #439  tomorrow. Many thanks, again!!

One possibility for the hyperelastic problem is what Knoll & Keyes call 'physics-based preconditioning', i.e. approximating the Jacobian that is used in the preconditioner, noting that this does not weaken the finite-difference Jacobian defined in terms of the residual as used in the Newton–Krylov iteration proper.
In this example, the Jacobian is only ever actually assembled once at the beginning, and based on the initial guess, so it's really the linear Laplace operator rather than the Jacobian of the nonlinear Young–Laplace operator.  This wasn't exploited in the present implementation but would involve :

less derivation
less coding

actually the skfem.models.poisson.laplace is predefined

quicker assembly

Is there a 'physics-based preconditioner' for hyperelasticity, e.g. corresponding to linear elasticity?  If it omits some of the terms that proved tricky in #439, it might be quicker to assemble.


[Feature request] Chunked context support FP8.

Chunked context is a great feature for GPU memory capacity bound scenario, by enable this feature, I can increase batch_size without worrying about (batch * avg_prefill_seq) may cause oom.
However, chunked context required enabling 'paged_context_fmha', and currently FP8 is not compatible with paged_context_fmha.  https://github.com/NVIDIA/TensorRT-LLM/issues/1169#issuecomment-1970753421
### Tasks

Yes, we do not support fp8 currently, but we will support it in the future. Thanks!

@Shixiaowei02 Is this now supported? I'm reading the documentation here: https://github.com/NVIDIA/TensorRT-LLM/blob/a96cccafcf6365c128f004f779160951f8c0801c/docs/source/advanced/gpt-attention.md?plain=1#L67

Close it since this feature had been supported yet.


Remove redundant getTable call when fetching partitions

Back to the original idea of passing down Table

thanks @electrum


feat: add the https serving feature

missing the ws: and wss: changes in the client part

Closing this in favor of a more modular approach. Users will be able to provide a --server module that creates an http/https server according to their needs.


Need CONTRIBUTING.md

We don't have any contributor guidelines! For now, it should just have these things:

a friendly welcome message for contributors
a note saying we accept contributions in any programming language, but most things have been done in Python
a link to the README.md file

Possible future extensions:

a description of issue tags we use
a link to the Code of Conduct (we don't have one yet though)
a link to a place to ask general questions
guidelines and/or a link to a place to request features

Check out paperbadger's as an example - this one is pretty fleshed out, ours needn't be at this point.

http://mozillascience.github.io/working-open-workshop/contributing/

Here's a start, but it's very basic still: https://github.com/goyalsid/phageParser/blob/master/CONTRIBUTING.md


Add Scylla and Scylla Manager dashboards to Grafana

Motivation
ScyllaDB and Scylla Manager also expose some dashboards for us
Proposal
Add those dashboards to our dashboards
Test Plan

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #1567

PR #1568   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 26, 2:45 PM: @andresilva91 started a stack merge that includes this pull request via Graphite.


Discord?

What is your question?
Since discussions is gone, gimme the discord.

https://discord.gg/2ka77eMXDv

https://discord.gg/2ka77eMXDv


Abort entering a password into Git Bash terminal within Code, will hide text after

VSCode Version: 1.41.1
OS Version: Windows 10 x64

Steps to Reproduce:

Add, Commit and Push
Enter an incorrect password for your SSH key for Git
Press Ctrl + C to exit.
The terminal continues to hide text.  You can still type and enter commands but no text is shown.

Does this issue occur when all extensions are disabled?: Yes

Does it reproduce in Windows Terminal? https://www.microsoft.com/en-us/p/windows-terminal-preview/9n0dx20hk701?activetab=pivot:overviewtab
What version/build number of Windows are you on? (type ver in cmd)

It doesn't seem to reproduce in windows terminal no.
Microsoft Windows [Version 10.0.18362.592]

Unconfirmed, needs some investigation into what the terminal process is sending to us by enabling trace logging while reproducing this https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging
I suspect the program is telling us to hide the cursor but isn't telling us to show it when ctrl+c is hit.


Define cudaOutputMode_t to cupy_cuda.h

Lack of cudaOutputMode_t definition in cupy_cuda.h caused build failure of Read the Docs Detail.
I confirmed this PR makes the build successful Detail.

LGTM!


readme.md file  change developer console link now open

developer console link now open
https://console.developers.google.com/

@Bilal112 ❤


Fix broken pipelines

Fix dashboard path in infra-deployment-push
Upgrade rosa version in stonesoup-e2e-test

None of this changes impacts the CI run by PR, so force merging to see the impact.


Soafp

Source name
Soafp
Source link
https://soafp.com
Language
English
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

Is the site still not added?

@Evaider1 nope


Improve discoverability

Adding keywords will improve discoverability of this plugin. Ex: currently it's not listed in broccoliplugins.com.

Thanks! Merging.
(I think "es6" as a keyword is a bit of a stretch, but I don't have a super strong opinion so won't remove)


[WEB-1141-184] Fix: resolving missing fetch import

When writing tests for simulations, ReferenceError: fetch is not defined is thrown.  Just missing the import.

@pmdaly also I'm seeing an error on github about your commit not being signed, I can merge it with admin privileges but if you could setup commit signing with a GPG key that'd be great

I'll add the key.  I don't have much progress yet on the tests so I can split them up.


[upstream] added ability for compressed pointer to use full 32 bits for addressing in single tier mode and use 31 bits for addressing in multi-tier mode

This change is

cachelib/allocator/memory/CompressedPtr.h line 197 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
does it compile? on upstream, allocators_ is not a vector, but just a single pointer, right?
I think you could probably just hardcode isMultiTiered to false in this function for now.

It compiles now. I renamed SingleTierPtrCompressor to PtrCompressor. We can revert to SingleTierPtrCompressor name later with the other changes. This is the least intrusive option in my opinion for merging into meta/main. I took out the AllocatorContainer based PtrCompressor for now.

cachelib/allocator/memory/CompressedPtr.h line 197 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
Or if you don;t include that implementation, please add some comment or some info in the commit message that it needs to be implemented later.

done

cachelib/allocator/memory/CompressedPtr.h line 31 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
why do we need this forward declaration?

you're right. The forward declaration is needed because of the following in CompressedPtr class:
template <typename PtrType, typename AllocatorContainer>
friend class MultiTierPtrCompressor;
But for upstream PR, I took it out. I'm adding it back.

cachelib/allocator/memory/CompressedPtr.h line 190 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
where this class template is used?

It won't be used in the upstream PR. This is a foundational PR meant to add the framework. The MultiTierPtrCompressor will be used later. This is what Igor and I discussed.

cachelib/allocator/memory/tests/MemoryAllocatorTest.cpp line 410 at r4 (raw file):
Previously, byrnedj (Daniel Byrne) wrote…
I would recommend adding the following block after this line. This way we can at least say the code is tested. In fact, I tried adding this and it passed.

Added

cachelib/allocator/memory/CompressedPtr.h line 130 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
where we are storing tid? I believe we need a unit test to check compress function

The CompressedPtr is backward compatible. The tid part is set to default 0 in CompressedPtr constructor. Also the following use case
bool isMultiTiered = allocators_.size() > 1;
auto cptr = allocators_[tid]->compress(uncompressed, isMultiTiered);
if (isMultiTiered) { // config has multiple tiers
  cptr.setTierId(tid);
}

fix added. Thanks for posting the code stub Daniel.

cachelib/allocator/memory/CompressedPtr.h line 190 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
If a class template is not used anywhere the compiler does not even compile it. It means you might even have a compilation error inside such a class template and the compiler will not detect it. Maybe better to upstream this template later when it is actually used? Or (if we want to upstream it in this PR) introduce a unit test for it so that it is compiled by the compiler.

I added a baseline test.

cachelib/allocator/memory/CompressedPtr.h line 31 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
I still do not understand. If it is not needed right now by this PR let's remove it.

Done.

cachelib/allocator/memory/CompressedPtr.h line 130 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
Yeah, this is exactly my point, as Igor described.

I took out MultiTierPtrCompressor for this PR. The difference between MultiTierPtrCompressor and PtrCompressor is that the 32nd bit can be reserved for tier id. In case of PtrCompressor we don't allow this 32nd bit to be set whereas in case of MultiTierPtrCompressor this 32nd bit is reserved for tier id. That's why the allocators.size() check is made to ensure whether we're dealing with single or multi-tier. In case of single tier, even if you use MultiTierPtrCompressor, it won't allow you to reserve the 32nd bit for tier id. This was done to create a common structure that'll allow all 32 bits in MultiTierPtrCompressor to be used for addressing when config is single tiered.

cachelib/allocator/memory/tests/MemoryAllocatorTest.cpp line 418 at r5 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
Can we add some Unit tests for multitier?

Taking out MultiTierPtrCompressor and I added a tier test based on Daniel's suggestion above.

I took out MultiTierPtrCompressor for this PR.

cachelib/allocator/memory/CompressedPtr.h line 130 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
Why you added tid input parameter but it is not used anywhere in this function?

This was meant to introduce the API change with backward compatibility. The final definition would look like what's the complete change in develop branch:
// Compress the given slabIdx and allocIdx into a 64-bit compressed
// pointer.
static PtrType compress(uint32_t slabIdx, uint32_t allocIdx, bool isMultiTiered, TierId tid) noexcept {
XDCHECK_LE(allocIdx, kAllocIdxMask);
if (!isMultiTiered) {
XDCHECK_LT(slabIdx, (1u << (kNumSlabIdxBits+1)) - 1);
return (slabIdx << kNumAllocIdxBits) + allocIdx;
}
XDCHECK_LT(slabIdx, (1u << kNumSlabIdxBits) - 1);
return (static_cast<uint64_t>(tid) << kNumTierIdxOffset) + (slabIdx << kNumAllocIdxBits) + allocIdx;
}
Do you think this API change introduction is better with rest of tid details (rather than a placeholder in this PR) ?

cachelib/allocator/memory/CompressedPtr.h line 130 at r4 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…

Do you think this API change introduction is better with rest of tid details (rather than a placeholder in this PR) ?
Yes, I do think that full implementation like in develop branch is what we need in this PR. The current placeholder is not completed and I think it is error-prone because in the future we might forget to complete the implementation. And I see no barrier to putting complete implementation in this PR, am I wrong?

In https://github.com/intel/CacheLib/blob/develop/cachelib/allocator/memory/CompressedPtr.h
(develop branch Compressed Ptr) the PtrCompressor class requires an allocator container to be passed. In case of main branch, the PtrCompressor gets a single allocator. So raising a PR with complete set of changes from CompressedPtr would not work without rest of the multi-tier changes. The idea was to split the work into smaller chunks - that's why I broke up compressed pointer changes into 2 parts. One that can go independently; other with the multi-tier changes.
There are two options the way I see it -
Option 1. compressed pointer goes entirely with the multi-tier changes. That way the unit tests, that are in place in develop, can verify the compressed ptr part. The tid changes would be done everywhere; so compressed pointer code won't need any further change.
Option 2. The way we're doing it now. Create an initial PR that partially introduces API related changes in Compressed Pointer while keeping backward compatibility in main branch. Then the multi-tier PR can include the develop branch compressed ptr commit. Since the expectation is that API changes would already be part of main branch by that point, only the additional changes in Compressed Ptr would need review.

cachelib/allocator/memory/CompressedPtr.h line 133 at r8 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
now the logic looks good, but another question should it really be static_cast<uint64_t>? Should it be a 32-bit value?

changed to 32 bits.

cachelib/allocator/memory/CompressedPtr.h line 157 at r8 (raw file):
Previously, vinser52 (Sergei Vinogradov) wrote…
As we discussed, it also should be static_cast<32>

Done.


Update secrets for snow

Issue #, if available:
Description of changes:
Update secrets for snow
Testing (if applicable):

unit test
Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve
/woof


does it support multi_labels classfication?

No. Multi-label classification is not supported (i.e. training a model that predicts several independent labels).
The recommended solution is to train an individual TF-DF model for each label (possibly in parallel).
Remark that Decision Forests do not have the capability to extract hidden representations like Neural Networks do. In other words, "multi-head training" is equivalent to independent training.
Ps: Multi-class classification is supported (i.e. training a classification model on a label with more than two possible classes).

got it, thanks!@ach

No. Multi-label classification is not supported (i.e. training a model that predicts several independent labels).
The recommended solution is to train an individual TF-DF model for each label (possibly in parallel).
Remark that Decision Forests do not have the capability to extract hidden representations like Neural Networks do. In other words, "multi-head training" is equivalent to independent training.
Ps: Multi-class classification is supported (i.e. training a classification model on a label with more than two possible classes).

got it! thanks.


edited cell does not render anymore

Hi,
This is very great thank you!
I Noticed since yesterday update that the table does not render when the cell is edited (see screencast)
The value does seem to get transfered though but it does not appear in the table.
Could this be an issue with the formating function?
Thanks!
https://user-images.githubusercontent.com/52936717/103588570-7abb2980-4eb7-11eb-962c-b6defce484c8.MOV

fixed on v0.1.4!

fixed on v0.1.4!

Thanks!!

Thanks!!


Vertically mirrored render on Windows (virtualbox)

Godot version: v3.2.3.stable.official
OS/device including version: Windows 10 (VirtualBox 6.1); GLES2 mode via VBoxSVGA (3d accel enabled)
Issue description: see screenshot

It is render bug -- when I move mouse on the right side buttons hovers as if they placed correctly.
Steps to reproduce: launch in Windows 1809 on VBoX with SVGA video driver and guest additions installed.
Minimal reproduction project: N/A

Managed to open my project:

Duplicate of https://github.com/godotengine/godot/issues/40370.


Fix linting

I noticed that .golangci.yml had some commented out and disabled linters. This PR fixes that. It also uncomments "example" from the GitHub action.
Running go mod tidy -compat 1.17 fixed the "no go files to analyze" error linting "examples".
For the linting issues, I updated .golangci-lint and fixed the issues that it found.
I think most of the changes are obvious, but I want to mention a few things:

I created two test helpers "assertNilError" and "assertWrite" because that made the error checks issues easier to fix with find/replace. I see that assert functions are generally not used in this repo. I'm happy to inline these, but my preference is to keep them as-is.
I changed the signature of stringifyValue to accept a *bytes.Buffer instead of an io.Writer because the linter knows that Buffer.Write always returns nil errors.
I removed quite a bit of dead code from authorizations_test.go

Codecov didn't like that I modified an uncovered line, so I added a test for it.

I'm doing a crazy amount of driving today, so will be slow to respond. I try to "approve run" of the checks when I can, but today's going to be pretty challenging, sorry.

@gmlewis I appreciate how responsive you are on this repo. I have no expectation that you or anybody else be around on a weekend. I can see the lint results on my fork, so my feedback loop is just fine.

Thank you, @gabriel-samfira !
Merging.


[semantic-dom-diff] Should strip empty class attributes

semantic-dom-diff Should strip empty class attrs by default.
The only semantic meaning would be if someone puts a [class] { /* ... */ } rule in their css,
… but in my opinion, that person has it coming to them :wink:.
Empty class is a common symptom of classMap: You add some classMap to your code, but the case only obtains for one of your tests, everything still fails because of an empty class attribute which has otherwise no effect
Users can of course add <div class> to expected DOM, but this is

a hassle
not semantic

Users could also use { ignoreAttributes: ['class'] }, but this would strip all class attributes, where there might be meaningful static or dynamic class lists elsewhere in the tested HTML.
In short, class="" is not semantic, therefore semantic-dom-diff should strip it
@daKmoR suggested in slack a new { stripEmptyAttributes: ['class'] } option with class in the defaults. Theoretically, all global, non-boolean attrs can go in by default. But in practise that probably only includes class and id.

Tangential question, is this an issue with semantic-dom-diff or with classMap? Seems like classMap would benefit from working more like ifDefined. Have looked into the lit-html teams thoughts on this?

I chatted with Justin about it on Polymer Slack. He didn't seem to fussed about it. I still think it'd be worth our attention here, since the package is after-all called semantic-dom-diff

Cool. Thanks for the background info. If they’re not looking into it, we definitely should!


⚠ Anthelion has degraded performance

In f0749c2, Anthelion ($ATH) experienced degraded performance:

HTTP code: 200
Response time: 3413 ms

Resolved: Anthelion performance has improved in cd8d54c after 411 days, 23 hours, 23 minutes.


Update nox-automation to point to nox

Describe the bug
I used to have nox-automation installed, then the package changed at some point and I started getting confusing errors until I finally realized I needed to uninstall nox-automation and install nox. It would be nice to have the old package name somehow point to the new package, or have a deprecation warning when nox-automation is installed or updated.

Done https://pypi.org/project/nox-automation/

For posterity, the redirect package's code is located here: https://github.com/theacodes/nox/tree/nox-automation-redirect


Add Smart Gateway Debug Enablement

Provide ability to enable debugging with a simple flag on the ServiceTelemetry CR
for the various Smart Gateways we have.

@csibbitt first off, you're right.
My justification on this one right now is basically that we're going to have customers deploying the code like this, and having to get them to update the entire manifest just to enable the debugging is going to get really old really fast I think when we run this in production.
I don't like it either, and I already noted the containerImagePath as the next one on the list. I was going to do it at the same time, but thought this would be a good example of how one might accomplish this task (MVP).
I really want to do the proper fix, and based on how much of a pain in the ass the "update the entire manifest" approach is, I'm looking at doing the "do them all" sooner rather than later.
The two biggest pain points that I see right now are enabling debug, and enabling the custom SG image path override. That's what I wanted to start with.
Prefetch is really good point though too, so I can add that easily. I'm just trying to implement the 1 pt solution that will tide us over until I can work on the 3-5 pt solution next week.

I moved a card into the next sprint as part of the final GA delivery work to investigate the appropriate override methods that won't take us down the dark path. I'm going to close this out for now and will revisit it at that time.

Testing
Just for future reference, everything passed the scorecard tests.
operator-sdk scorecard --bundle ./deploy/olm-catalog/service-telemetry-operator/metadata/
INFO[0000] Using config file: /home/sysop/src/github.com/infrawatch/service-telemetry-operator/.osdk-scorecard.yaml
basic:
	Spec Block Exists                   : pass
	Labels:
		"necessity":"required"
		"suite":"basic"
		"test":"checkspectest"

	Status Block Exists                 : pass
	Labels:
		"necessity":"required"
		"suite":"basic"
		"test":"checkstatustest"

	Writing into CRs has an effect      : pass
	Labels:
		"test":"writingintocrshaseffecttest"
		"necessity":"required"
		"suite":"basic"

olm:
	Bundle Validation Test              : pass
	Labels:
		"necessity":"required"
		"suite":"olm"
		"test":"bundlevalidationtest"
	Log:
		time="2020-03-05T10:02:38-05:00" level=info msg="loading Bundles" dir=./deploy/olm-catalog/service-telemetry-operator/metadata/
time="2020-03-05T10:02:38-05:00" level=info msg=directory dir=./deploy/olm-catalog/service-telemetry-operator/metadata/ file=metadata load=bundles
time="2020-03-05T10:02:38-05:00" level=info msg="loading Packages and Entries" dir=./deploy/olm-catalog/service-telemetry-operator/metadata/
time="2020-03-05T10:02:38-05:00" level=info msg=directory dir=./deploy/olm-catalog/service-telemetry-operator/metadata/ file=metadata load=package

	Provided APIs have validation       : pass
	Labels:
		"test":"crdshavevalidationtest"
		"necessity":"required"
		"suite":"olm"

	Owned CRDs have resources listed    : pass
	Labels:
		"necessity":"required"
		"suite":"olm"
		"test":"crdshaveresourcestest"

	Spec fields with descriptors        : pass
	Labels:
		"test":"specdescriptorstest"
		"necessity":"required"
		"suite":"olm"

	Status fields with descriptors      : pass
	Labels:
		"necessity":"required"
		"suite":"olm"
		"test":"statusdescriptorstest"


Show date of gift card submission

[x] Show date of submission with other gift card information on person's page and /gift_cards pages
[x] Be able to see how many sign-up gift card submissions within a timeframe or per month

Added created_at start and end filters to gift card search.
https://github.com/smartchicago/kimball/commit/e90eca974033979477b00d268f60ca55808e5b69

The date created has been added, as well as some filtering functionality. However, there are gift cards on staging that are not showing up when searching for a date range. Here is an example:

While I searched for gift cards equal to 07/31/2016, and there are gift cards created on this date, it's not showing up in my search results.

This has been added and looks good. Closing this issue.


this.animation is undefined

When I used Modal containing Animation components
Crash info "this.animation is undefined "
import React from 'react';
import Animation from 'lottie-react-native';

export default class BasicExample extends React.Component {
  componentDidMount() {
    this.animation.play();
  }

  render() {
    return (
        <Modal animationType="slide" transparent={true} visible={false}>
            <Animation
                ref={animation => { this.animation = animation; }}
                style={{
                    width: 200,
                    height: 200,
                }}
                source={require('../path/to/animation.json')}
            />
        </Modal>
    );
  }
}

@Herb-Sun This isn't a lottie specific issue. This is just a react issue.

@Herb-Sun Try doing the this.animation.play(); at onShow of the Modal
i.e. <Modal onShow={()=>{ this.animation.play(); }}>

If this isn't a Lottie issue, why would the api docs show that this is the way to play your animation? Is there not a way for React-Native to play these animations as expected?

try:
setTimeout(() => {
this.animation.play();
}, 200);


Deleting Chats I No Longer Can See[Question]

I have my data package that was sent from discord, and I was wondering if there was a way to delete chats from past friends/servers that I can no longer see...?
All help is appreciated, thank you.

@SweatyMarty I don't think this is possible, since you don't have access to those chats. It's like trying to delete a message in a channel you don't have permission to send messages in.

Can confirm, when using the id's gathered from the data package I didn't have permission to delete said conversations. Thank you for the response!


change flavors display type

currently flavors are displayed as drop down. We must change it to make it as big buttons like how most of the services are displayed online.

we need something like this

I‘ll take this.


config option should be same across subcommands

for cluster operations the config is the first parameter (no switch).  for the tool operations the config has the switch '--config'.
I prefer the named parameter for all operations.

I believe that https://github.com/samsung-cnct/k2cli/pull/140 closes this ticket.


Truncate OAuth tables after staging DB restore

Fixes

Another step towards completing #1989
Description

This PR adds the truncation steps described in the IP for this work on step 12.3 here: https://docs.openverse.org/projects/proposals/search_relevancy_sandbox/20230406-implementation_plan_update_staging_database.html#dag
We also needed a connection to the staging database (we haven't had the need arise for one yet) so I added a new connection for that. The naming convention we have isn't great but I didn't particularly want to change that at this juncture.
The DAG definition specifies a handful of tables to truncate, but fortunately all of them reference api_throttledapplication either directly or indirectly, so a single TRUNCATE...CASCADE will truncate them all (and prevents deadlocks which might be incurred by truncating them all in parallel).

Testing Instructions

Testing this is a little troublesome - you'll need to perform all the setup instructions provided in #2099.
Additionally, we can't connect to the actual staging database because we need to connect to the jumphost first, and it's difficult (read: extremely tedious) to try and get the Airflow container to connect to the database which is bound to the host at 5432. The easiest way to test this is to have those commands run on the local API database instead. This can be done by setting AIRFLOW_CONN_POSTGRES_OPENLEDGER_API_STAGING=postgres://deploy:deploy@db:5432/openledger. Then run just api/init and just c to set up the API and start the catalog. You can then kick off the DAG, and the truncation steps should run against the local API database.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

we can't connect to the actual staging database because we need to connect to the jumphost first, and it's difficult (read: extremely tedious) to try and get the Airflow container to connect to the database which is bound to the host at 5432.

👍 This also seems a little scary, considering how simple it is to connect to the prod DB via the jumphost.

I tested this by setting SKIP_STAGING_DATBASE_RESTORE to false, but did not set up the AWS connection because I was hesitant to run the actual restore and delete operations. This meant that the tasks all failed, so I manually marked them as success and then cleared just the truncate_tables task to run it in isolation.

Ah nice, @krysal this should be a way to test this piece without the other variables/database restore steps!

I checked the tables listed in the IP to verify that they had been truncated, and saw that api_oauth2registration was not. It looks like this one does not reference api_throttledapplication and was not targeted by the CASCADE?

Shoot, I had thought that would be covered by the cascade. I'll double check and if not add that in!

Interesting, it seems we record api_oauth2registration and use the name in api_throttledapplication but not as a foreign key reference 😮 seems like that will also need to be truncated, I'll add that in!


add jsdoc to function randomDroneModel in random.js #17

add jsdoc to function randomDroneModel in random.js #17

Thank you @itsthecheat!
And congrats on taking the first few steps into the world of open-source! 🍾
I hope it is the first of many contributions.

Thank you for the opportunity! Great project btw


refactor(napi/parser): clean up code

#7596  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


I want to apply to join istio members.

I want to be istio members. And found basic requirements here: https://github.com/istio/community/blob/master/ROLES.md#member
But there is no way to do this. Can anyone approve my apply?
I am hzxuzhonghu, currently a kubernetes apiserver reviewer.  And focus on cloud native open source.
/cc @gyliu513 @ZackButcher @rshriram

+1 to this.
/cc @linsun

@hzxuzhonghu Could you expand on "no way to do this"?  I think the guidelines set forth are fairly straightforward, but if the community repository could use some fine tuning to clarify, we should take that action of clarifying membership.
Cheers
-steve

Please simply document your contribution so far, and we'll invite you as a member once the criteria is met:  https://github.com/istio/community/blob/master/ROLES.md#member

@linsun Thanks, following is my prs and issue

remove deprecated flags

/watch has been deprecated, use ?watch=true

use shared informer to watch kubernetes resources

update time.Duration print

fix some misc in pilot

fix potential timer leak

use read only stop channel

mixer: remove outdated comments

issue: https://github.com/istio/istio/issues/1367

cc @costinm @geeknoid @kyessenov it is related to contributor experience , is there a explicitly document about this?

@rshriram Could anyone invite me to join?


Support new questions type

These questions type should be supported by the plugin:

[x] Multiple choices question
[x] Short answer
[ ] Matched Pair
[x] Numerical Answer
[x] Essay Answer

For matched pair see https://developers.google.com/apps-script/reference/forms/checkbox-grid-item
Checkbox grid item.

Completely new version of add-on since February, so I'm closing.


devops_to_do_list add Dockerfile and Readme

What is "Fix EOF"? I don't understand what I should do.


added to examples docs

added to the docs in the parquet branch @mdigan

ok, docs have been updated to use riak-admin instead of curl to create demo tables @mdigan

@korry8911 these lines are no longer needed:
"Be sure to substitute the Riak node's IP address and HTTP port in for $RIAK_HTTP."

sorry, fixed @mdigan

@korry8911 Let's add steps about activating the table with riak-admin too, since that's still required (as in riak-admin bucket-type activate)

added activation step @mdigan

@korry8911 Sorry, one more thing... Please change the main header from "Examples and Interactive Scala Shell (REPL)" to just "Examples" and the text immediately afterwards from "Riak Spark connector comes with" to "The Spark-Riak connector comes with"

fixed, @mdigan

@korry8911 All looks good to me 👍
cc @srgg

@korry8911 please squash all the commits into the one comprehensive commit

@mdigan squashed

@korry8911 please provide reliable message for the commit that will reflect to the changes introduced to the codebase rather then to reflect the activities on this commit


readdir needs to call rewinddir

At least on BSD, and it looks like in some circumstances on Linux too. Quoting the NetBSD man page:
fdopendir(fd)
          The fdopendir() function associates a directory stream with the
          directory file descriptor fd.  The file offset associated with fd at
          the time of the call determines which entries are returned.

Are you suggesting that Dir::from_fd should always rewind the dir, or that it should have an optional method for that?  I don't think that always rewinding is necessarily the right option.

So the scenario is this:

open fd P, do something like openat() on P, which shifts the read pointer.
opendirat(P) - gets a DIR* but the read pointer for P is not at 0
readdir(P) - content is missed

Yeah, in that above case I'd say that moving the read pointer is deliberate.  We could have an optional method to rewinddir, but it shouldn't be mandatory.  Basically, if the user gives us a raw file descriptor, we have to assume that they know what they're doing with it.


Macintosh HD shown twice (macOS)

On macOS, the egui-file-dialog works well, but Macintosh HD is shown twice.

as / (read-only) gets pulled by fs::read_dir("/Volumes") as. /Volumes/Macintosh HD which I think is a symlink
as /System/Volumes/Data (user-data) gets pulled by Disk::from_sysinfo_disk(disk, canonicalize_paths)

This seems to be caused by the APFS file system and Apple's system integrity protection.
All the quick-action folders in the side bar point to /, everything is mapped there when using the command line etc on a Mac, so we should probably also use this.
I'll look into this and also verify that using / will not result in any write permission issues.

Fixed


configure staging

seems like it requires another repo to be able to deploy to multiple environments
i don't wanna create a repo just for dev/staging etc
might use some other deployment services for that purpose
also apparently GH pages team is working on this feature: https://github.com/github/pages-gem/issues/724


registry.module(name).size() fails

A 404 is returned from https://skimdb.npmjs.com/registry/_design/app/_view/howBigIsYourPackage
running:
registry.module('browserify').size({}, console.log.bind(console));

returns:
[SyntaxError: Unexpected end of input]

logging directly from the size method gives:
{ [Error: missing_named_view]
  name: 'Error',
  error: 'not_found',
  reason: 'missing_named_view',
  scope: 'couch',
  statusCode: 404,
  request:
   { method: 'GET',
     headers:
      { 'content-type': 'application/json',
        accept: 'application/json' },
     uri: 'https://skimdb.npmjs.com/registry/_design/app/_view/howBigIsYourPackage',
     qs: { key: '"browserify"' } },
  headers:
   { date: 'Fri, 18 Mar 2016 23:36:51 GMT',
     'content-type': 'application/json',
     'cache-control': 'must-revalidate',
     statusCode: 404,
     uri: 'https://skimdb.npmjs.com/registry/_design/app/_view/howBigIsYourPackage' },
  errid: 'non_200',
  description: 'couch returned 404' }

@jking90 there have been a lot of changes to how registry documents are served in the past year, I bet I stepped on the toes of this view on npm side.
Let's add a test for this failing behavior, and I can work on figuring out an alternative to fetching this information.

@bcoe I added the failing test in #14. Any updates on a new view for this info?

@bcoe this missing view is a blocker on a project of mine


V1.59 terminal bug

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:
1.when i update vscode to 1.59,and restart it,then i open the terminal viewport
2.the terminal view is messy, word spacing becomes particularly wide，until i delete this terminal viewport,and restart it ,it work normal
This problem did not occur in previous versions，until I updated it this morning

sounds like https://github.com/microsoft/vscode/issues/120004
I can't reproduce this.

likely a duplicate of #120004

Please include steps to reproduce the issue and a gif

duplicate of #130751


Add a fallback for the root level Suspense in AdminUI

The root level Suspense does not have a fallback render,  see null
https://github.com/keystonejs/keystone-5/blob/51e7330abe22d1f3cf2d5babedcb0ce37b54b564/packages/admin-ui/client/index.js#L132-L137
And in any case,  if that Suspense is actually triggered with the fallback,  watch your console become unresponsive as you hit 100% renderer usage + CPU,  and eventually a memory leak (Firefox seems to be worst at this).
Alternatively,  in Chromium,  I get React detecting a stack blowout.
I could only reproduce when I was experiencing the error from https://github.com/keystonejs/keystone-5/pull/1131.
 Did I get this right?
Is it a simple PR? Can I assign you? :P


Enhance registry controller to trigger request reconcile

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #321 #322 #314
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@DanielXLee
The logic for OperandBindInfo may need to be updated.
I think we don't need to add OperandBindInfo label into the OperandRequest.
In the OperandRegistry controller, we list the bindInfoList with the label, but we add the label on the OperandRequest.
	bindInfoList := &operatorv1alpha1.OperandBindInfoList{}

	opts := []client.ListOption{
		client.MatchingLabels(map[string]string{request.Namespace + "." + request.Name + "/bindinfo": "true"}),
	}
	if err := r.client.List(context.TODO(), bindInfoList, opts...); err != nil {
		return err
	}

I will merge this PR and make some changes in the following PR.

@horis233 nice catch, we should add label in operanBindinfo controller


fix for access array data with indices

[x ] Your pull request targets the staging branch of FreeCodeCamp.
[x ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ x] You have only one commit (if not, squash them into one commit).
[x ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x ] Tested changes locally.
[x ] Closes currently open issue (replace XXXX with an issue no): Closes #9068

Description
Added assertion to check code for \s*=\s*myArray[0]
Added corresponding message

The data in variable myArray should be accessed using bracket notation

sorry, forgot to rename the branch

There seems to be some merge conflicts.
git checkout staging
git pull --rebase upstream staging
git checkout fix__using-array-indices
git rebase staging

@robjloranger, you also need to squash your commits!
git rebase -i HEAD~3

Change the 2nd and 3rd commits from pick to squash.

git push -f origin fix__using-array-indices

@atjonathan i'm having quite the day lol
it wants to include someone else commit..
pick b730761 This is a buggy challange (#8843)
and is not including my latest commit

In the issue description you use [x ] while you should remove that space and make it [x]. It makes them checkboxes and you can see it in Preview tab before updating the comment.

LGTM

LGTM :+1:
Thanks for contributing :tada:


GKE: Enable Shielded GKE Nodes for Integration Tests and in Docs

This is a security feature which will be enabled by Default on GKE soon(ish) (once Kubernetes 1.18 is used).
We should also enable this in our integration tests, and document this in our GKE installation guide

in quickstart https://keptn.sh/docs/quickstart/
and in the 0.8.x docs https://keptn.sh/docs/0.8.x/operate/install/

Fixed in PR https://github.com/keptn/keptn/pull/2979 and in docs https://github.com/keptn/keptn.github.io/pull/712

Fixed in PR https://github.com/keptn/keptn/pull/2979 and in docs https://github.com/keptn/keptn.github.io/pull/712


line breaks within a cell

Thanks for your effort and support.
how can we add line breaks within cell itself.

I have same question.

Please reference: #70 Trailing new line is causing a new row in excel to be created.
Either:
 or <br> should do the trick.

Hi Travis Clarke,
The reference #70 is about new line creating new row,but i am trying the line break in a particular cell itself .
suggested method didn't helped me.
Thank for reply.

@rajeev13 / @smrrrazu
You are correct – my mistake. XLSX seems to be an exception to what is delineated in #70 .
There are some quirks with Excel related to consistency and which escape characters are interpreted as linefeed and carriage return across platform. I can likely patch this with a cell-style, but in the meantime, a workaround is to use standard linefeeds in the html (
 or literal return) and enable wrap text in Excel:


add DM Spectra plus minor fixes

I added two spectra classes to astromodels/functions/functions.py  DMFitFunction and DMSpectra.  DMFitFunction is based on a similar class in fermipy.  It creates DM spectra for a given mass/channel/sigmav/J-factor using the Pythia-generated table in the standard Fermi Science Tools.  DMFitFunctions is good for 2 GeV < mass < 10 TeV.
DMSpectra can be used for 2 GeV < mass < 1 PeV.  It supplements the Fermi table (used in DMFitFunction) with the Pythia-generated table used in the HAWC Collaboration for 10 TeV < mass < 1 PeV.  Note currently there is no working spectra of mass > 10 TeV for 'ee', 'gg', or 'WW' channel.
I also added examples/createDMSpectra.py to show how to initialize and use the new spectra classes.
Minor changes:  I updated astromodels/functions/functions_2D.py so variables the user won't use start with "_" (e.g. self.refX -> self._refX).  I also changed the function "set_file" -> "load_file" since I think that's more clear (I updated example/createExtendedSourceFromTemplate.py to use load_file).  I also updated astromodels/functions/functions_2D.py so the FITs file gets closed during the _set_up function.

I forgot to mention that I added the two Pythia-generated tables that DM spectra are interpolated from in astromodels/functions/  If there's another place you think those belong let me know and I can update the code to pull them from the appropriate location.
gammamc_dif.dat is for DMFitFunction and DMSpectra..its from the standard Fermi Science Tools
dmSpecTab.npy is for DMSpectra, its the models used in HAWC


Feature Request : display error messages only

Thank You for providing VSColorOutput May I please request a feature i.e. to wit the option to display error messages only . i would find it helpful as w/o such it is necessary to tediously scroll/search the output to find same . Thank You Kindly
PS Please give my regards to your pet dolphin or porpoise Nice picture

Would if I could. The output window has no mechanism in Visual Studio to modify or delete text. It only allows changing properties of line like classification.

Thank You for your kind reply . May i please inquire if it would be possible to send such filtered output to a self-created window .

That might work.


first letter of the day of the week

Is it possible to display only the first letter of the day of the week?

there is an option to specify "WeekdaysFormat". Unfortunately, when you look at the usage of it, you can see: start.ToString(WeekdaysFormat) where start is DateTime. As you may know, date formats don't support only first letter of a day.
If I were you, I would download the repo, add each project to your solution and update the method ChangeWeekdays() (line 170) to match your requirements.

I even did it, following your guidance. But now the background image on the special days does not appear as it appeared before, even when the image is set. :(

Not sure If I understood you correctly, but I've just checked on Android and it looks like this:

Unfortunatelly, I've made a mistake and there is another method which updates the "Calendar".
So what I did is: I changed ChangeWeekdays() method and ChangeCalendar(CalandarChanges changes).
You can find the sample code in forked repo.

I did it, thank you very much for your help. Now for some reason the image that I assign the special dates does not appear in the calendar. Do you have any idea what that might be?

Hmm. Is there a chance for a sample repo? It will be easier to find out why this is happening 🙂

Actually the problem is that when I remove the package and copy and paste the project into git, it unconfigures several things including the image of the special date that does not appear

Strange. What I did is: clone the source code of this package -> remove the samples & windows phone dirs -> move the package folders to my solution folder -> add needed references (in iOS to iOS calendar, in Android for Android calendar etc.). It worked in my case and I was also having special dates with images. Don't know how to help you 🤔

I got it: dancer:
Now the only problem is that the image of the special date is always visible, even when it is from the previous month. For example: 31/10 is a special date and appears on the November calendar, should be visible only in the month of the date. :(

Sorry. I've missed your answer 😔 Yes I can see it in my calendar too, unfortunately, this is how the library works. It sucks, but this is how it is implemented. You can take a look at the code yourself and check if it is possible to change it. I can't promise, I will have time in the next days to help you

I was able to resolve the code by refactoring! thank you!


Babel does not compile files in platformAssets/runtime

Files in platformAssets are not compiled by babel. This poses a problem on older platforms with fontManager.web.js that contains an arrow function (or any other runtime files).
This can locally be fixed by adding a virtual plugin
"babel_platformassets_fix": {
    "webpack": {
        "modulePaths": [
            "platformAssets/runtime"
        ]
    }
},

to plugins in renative.json. This adds the platformAssets/runtime folder to the include rules of babel.
But I believe this should be fixed in renative itself

Thanks @TheDuc fixed in this commit:
https://github.com/pavjacko/renative/commit/be795306fcb3fa66f73828ac197cc428fc15a802
will be shipped with 0.29.1

thanks for the quick fix as usual!


Bug in MaxDistanceSplitter

Hi, I just wanted to report a small issue that happens only in the rarest of cases.  In my case, I ran across a road that was exactly 5 km (the max edge length), and the splitter created 3 segments, with 1 segment of length zero .
In line 67:
if (data.Distance < _maxDistance)
should, I believe, be:
if (data.Distance <= _maxDistance)

Just noting that I was unable to make a contracted db after making this change (on a planet sized pbf filtered for rail data), the exception I received was

Edge detected that's too long in ...


pgsphere or pg_sphere?

The repository name is pgsphere. The extension name is pg_sphere. The document uses pgSphere. The names are not consistent. I propose to think about this problem.

Not the same question, but there's also a giant dichotomy between the naming of SQL functions and C functions, e.g. scircle_* vs spherecircle_*. And half of the C/SQL files are named pgs_* while the rest doesn't have a prefix. It's very confusing.

I would prefer pgsphere as well. I agree we shouldn't rename the extension.
Some more questions:

Should we use pgsphere when naming source files or doc files (like, pgsphere-1.3.1-A4.pdf)?
Should we use pgSphere or PgSphere in doc titles?

For certainty, I would propose to use pgsphere for the following cases:

Repository name
File and directory naming (?)
Documentation

Use pg_sphere:

Module name
Function names (like, pg_sphere_version)

Then, we may describe such naming chaos it in the doc.

I'd put a +1 on pgSphere, the spelling with PgS looks weird to me.


Android 8: Message received but not shown in notification shade, no sound either

Expected Behaviour
Show message in notification shade and play sound when app is in background.
Actual Behaviour
According to logcat message is received, according to app console log notification handler is invoked, however, no message in notification shade, no sound, no vibration.
Works with iOS.
Reproduce Scenario (including but not limited to)
Migrated from GCM to FCM and followed the installation requirements for plugin-push v2.x
Steps to Reproduce
Downloaded all require Android SDK's and tools via Android Studio SDKManager. Run android build from cordova-cli
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 8.0.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Google Pixel XL
Cordova CLI version and cordova platform version
cordova --version                                    7.0.1
cordova platform version android          6.2.3

Plugin version
cordova plugin version | grep phonegap-plugin-push   2.0.0

Sample Push Data Payload
var message = new gcm.Message({
                                "delayWhileIdle": true,
                                "timeToLive": 3,
                                "data": {
                                    "title": config.gcm.message_title,
                                    "body": data.new_val.desc,
                                    "sound": "default",
                                    "content-available": "1",
                                    "priority": 2,
                                    "badge": 1,
                                    "notId": androidNotId,
                                    "extra": {
                                        "url": "deals"
                                    }
                                }
                            }),
                sender  = new gcm.Sender(config.gcm.api_key);

                sender.send(message, {topic: '/topics/' + topic.topic.concat('-android')}, function(err, response) {
                    if (err) {
                        console.log('Error sending push notification to Android');
                        console.error(err);
                    }
                    else {
                        console.log('Push Android success: ' + JSON.stringify(response));
                    }
                });

Sample Code that illustrates the problem
 window.gcmPush = PushNotification.init({
            android: {
                sound: "true",
                vibration: "true",
                topics: map(androidTopics, 'topic')
            },
            ios: {
                fcmSandbox: "false",
                alert: "true",
                badge: "true",
                sound: "true",
                vibration: "true",
                clearBadge: "true",
                topics: map(iosTopics, 'topic')
            }
        });

Logs taken while reproducing problem
09-19 11:51:32.533 21905 23485 D Push_Plugin: key = content-available
09-19 11:51:32.533 21905 23485 D Push_Plugin: key = priority
09-19 11:51:32.533 21905 23485 D Push_Plugin: key = count
09-19 11:51:32.533 21905 23485 D Push_Plugin: key = extra
09-19 11:51:32.534 21905 23485 D Push_Plugin: key = notId
09-19 11:51:32.538 21905 23485 D Push_Plugin: key = sound
09-19 11:51:32.538 21905 23485 D Push_Plugin: key = title
09-19 11:51:32.539 21905 23485 D Push_Plugin: key = message
09-19 11:51:32.539 21905 23485 D Push_Plugin: key = coldstart
09-19 11:51:32.539 21905 23485 D Push_Plugin: key = foreground
09-19 11:51:32.548 21905 23485 V Push_Plugin: extrasToJSON: {"count":"1","sound":"default","title":"Local is Smart","message":"Damn android 8","additionalData":{"content-available":"1","priority":"2","extra":{"url":"deals"},"notId":"76240","coldstart":true,"foreground":false}}

@bardu what does your AndroidManifest.xml look like, specifically the min & target sdk values?

@macdonst:
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="26" />

@bardu this is a duplicate of #1949.
You can either set the target SDK to 25 or install the latest plugin from github. I'm going to do a new release of the plugin soon to support some Android 8 changes.

@macdonst   just today I installed the latest like
cordova plugin add phonegap-plugin-push@latest --save
But the issue still persists.
Any release date for v2.1.0?


Test normal distribution

I'm not actually sure how well the Ziggurat algorithm is expected to approximate the normal distribution, and the current tests are just sanity checks.


fs: clean up filesystem import state

Clean up two aspects of importing filesystems:
First: instead of trying to avoid crossing mountpoints (by checking .st_dev) in order to use .st_ino values as a "unique key" for tracking hardlinks, just take the (.st_dev, .st_ino) pair.  This resolves some issues with overlayfs where adjacent files can end up with different .st_dev.
Second: we were abusing the first setting of st_dev as a flag field to determine if we were stat()-ing the root inode or not, which was always a bit evil.  We did this to avoid collecting the mtime of the root directory for determining the newest file in the filesystem.  Let's change our approach here: we can collect the mtime when adding items to their parent directories (which is never done for the root directory). Use a impl on Inode to make it easier to collect that information.
These changes together turn .stat() into a pure operation (with respect to the state of the reader), so remove the &mut self reference.
Fixes #41

The CI failures look like the actions runners got the 2024-enabled 1.85 rust release and clippy isn't following our edition = "2021" line in Cargo.toml.  I tried eliding those lifetimes and it doesn't work in 2021.

Okay, so it's not an edition thing, it's just a version thing: this got added in 1.83.0.
I didn't know that changes like this could happen between releases...  The new version is in Fedora now, in any case, so let's just depend on it.


Improved Monorepo Profile Management for Enhanced CI/CD

Component
Forge, Cast, Anvil, Chisel
Describe the feature you would like
Improved Monorepo Profile Management for Enhanced CI/CD
Introduction
Our project is a monorepo where packages are organized into Foundry profiles, each with its own set of scripts and tests. In many cases, running tests across all profiles or recompiling the entire codebase is essential, especially within a CI/CD pipeline. However, achieving this currently poses challenges, which can only be overcome by duplicating profile definitions or manually parsing the Foundry configuration.
Proposed Features

Inclusive All Profiles Option

Option 1: Introduce a foundry.toml setting that allows including all profiles when executing commands if no FOUNDRY_PROFILE environment variable is set.

Option 2: Implement a --all-profiles command-line flag for executing operations across all profiles.

Enhanced Profile Tooling for CI/CD

Develop additional profile management tools to streamline CI/CD processes, including:

Profile Listing: Implement a command to list all available profiles within the monorepo.

Multi-Profile Support: Enable the use of multiple profiles through a new environment variable, such as FOUNDRY_PROFILES="a,b,c".

Conclusion
I believe that these proposed features would be beneficial for our monorepo, but I recognize that they may not represent the ultimate solutions to the challenges we face. This issue is intended to initiate a constructive discussion around improving Foundry profiles and profile management, so if I'm out of line or am totally missing something, please put me in my place, haha! Your feedback, insights, and alternative ideas are highly encouraged as we collectively work towards enhancing our development process.
Additional context
No response

Semi-related bug:
I'm encountering an issue when trying to use the Forge formatter in Visual Studio Code. It appears that the formatter doesn't work correctly unless the FOUNDRY_PROFILE environment variable is set. This requires running a manual command in the terminal: FOUNDRY_PROFILE="abcdef" forge fmt.
Expected Behavior:
The Forge formatter should be able to detect and use the FOUNDRY_PROFILE environment variable without the need for manual setup. Users should be able to format files in VSC seamlessly.

Hi @rmcmk, thanks for your report
I've added your requests here https://github.com/foundry-rs/foundry/issues/5479#issuecomment-2209265718
Closing this ticket in favor of that one

I'm encountering an issue when trying to use the Forge formatter in Visual Studio Code. It appears that the formatter doesn't work correctly unless the FOUNDRY_PROFILE environment variable is set. This requires running a manual command in the terminal: FOUNDRY_PROFILE="abcdef" forge fmt.

Please open a new issue for this if you are still encountering this behavior, it may have been fixed already


:bug: Fix static badge generation when license name contains special characters

I am duplicating the characters - and _ as suggested on https://shields.io/.

I am eager of some refactoring tips to avoid the duplication.

@all-contributors please add @Zenigata for code


spago: 0.17.0 -> 0.18.0

Motivation for this change
Update spago to 0.18.0: https://github.com/purescript/spago/releases/tag/0.18.0
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build spago


LSP configuration via didChangeConfiguration

Addressing #1443

Disclaimer: This is my first time writing vimscript. Feedback is extremely welcome. I'm sure I missed the boat on something here but I'm happy to help any way I can with some guidance.

Adding the ability to configure LSPs via the workspace/didChangeConfiguration method. I've added the lsp_config key to linter definition, added a new ale#lsp#message#DidChangeConfiguration, and added a call to ale#lsp#Send this message during ale#lsp#StartLSP if lsp_config is set.
This leaves it up to each LSP linter to define its own configuration variable and pass that to the linter definition. I've added an example implementation for pyls.

Are we sure these are the same thing? I'm most familiar with the implementation of RLS, so I'll use that as an example... Here's the initialization_options available to RLS and here are the configuration options available via workspace/didChangeConfiguration.

I guess they are different. For pyls, the options people will really care about can all be given in initialization_options, like disabling or enabling particular plugins.

Add support for didChangeConfiguration, but take away your changes for pyls for now.

I removed the pyls changes. I'll probably add the RLS changes in a separate pull request once this is merged.

would love to see this land.

Great to see progress here!

What is missing here, tests?

Some tests that make sure that bad input is thrown would be nice, I think. You should always test every possible branch, especially the ones you want to fail.

Yep, tests are still missing. Specifically the PreProcess tests still need to be written.

@w0rp added tests to check PreProcess (to check that lsp_config is accepted and processed appropriately, and that it throws if lsp_config is not a dictionary)

Cheers! :beers:

Would this also benefit from an lsp_config_callback variant so that lsp_config doesn't need to be a static dictionary and to support ale#VarFunc?


unhelpful error messages while using asynch in before()

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
Being a noob with ESM, I did not realize that I could not simply follow the documentation at the top of https://mochajs.org/.  After following the "prerequisites" steps for filing a ticket, I found my error and eventually found https://mochajs.org/#nodejs-native-esm-support.  However, I believe I had some unneeded frustration.  The error message I got was:
SyntaxError[ @/Users/jric/dev/socialvoter/src/server/js/test/test.js ]: Unexpected reserved word
    at Loader.moduleStrategy (node:internal/modules/esm/translators:146:18)
    at async link (node:internal/modules/esm/module_job:67:21)

for which I found very little actionable information, mostly in this ticket:  https://github.com/nodejs/modules/issues/471
Steps to Reproduce
create package.json with "type"="module"
create this test file, and run it with mocha
var assert = require('assert');
function myAsyncFunction() { return new Promise(() => {}, () => {}); }
describe('Server', function() {
    before(function() {
        await myAsyncFunction();
    });
});

Expected behavior:
I expect to see an error, such as I get when I remove the "await" from the test code above.
ReferenceError: require is not defined in ES module scope, you can use import instead

As another simple fix, I expect to see a qualification at the top of the documentation that specifies that the sample code is only for using the common module system, and it could link down to the alternate code for using ESM.
Actual behavior:
As mentioned above, I dutifully follow the sample code and get a very cryptic error.
Reproduces how often: 100%
Versions

The output of mocha --version and node_modules/.bin/mocha --version:

jric@Alexs-MacBook-Pro-3 js % mocha --version
zsh: command not found: mocha
jric@Alexs-MacBook-Pro-3 js % node_modules/.bin/mocha --version
9.2.1

The output of node --version:

jric@Alexs-MacBook-Pro-3 js % node --version
v16.6.1

Your operating system

name and version:
macOS Monterey 12.2.1
architecture (32 or 64-bit):
64 bit

Your shell (e.g., bash, zsh, PowerShell, cmd):
zsh
Your browser and version (if running browser tests):  N/A
Any third-party Mocha-related modules (and their versions): N/A
Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version):  N/A

Additional Information
N/A

@jric I understand Being a noob with ESM can be frustrating sometimes, but I don't think we are going to pursue this issue. We don't have the bandwith to cover basic javascript or Node features tutorial-like in our docs.
You have two mistakes in your test sample:

async/await: await can be used only within an async function, this is plain javascript (except top-level awaits in ESM). IMO removing await is not the correct solution, better to add async to the before callback. This issue probably triggers your SyntaxError.
esm: require instead of import, a basic Node feature.

SyntaxError[ @/Users/jric/dev/socialvoter/src/server/js/test/test.js ]: Unexpected reserved word

I agree this error message is suboptimal, it's a known Node issue. We already tried to improve the information, see #4557, it's a hack until Node has fixed the issue permanently.

I certainly am not suggesting an ESM tutorial in the mocha docs, but I appreciate that I may ask too much, @juergba.  At least the next unsuspecting soul may find this ticket in a keyword search and save themselves some time.
ESM is recommended by some popular projects and usage will increase over time.  I think this confusion is likely to happen with increasing frequency before it gets resolved by the Node community.
Thank you for considering my proposal and guiding me away from ESM for now.

[...] guiding me away from ESM for now.

Mocha has been supporting Node's native ESM since 2020-02-26, with very few issues reported.
But well, it's your decision. Closing.


Please add a feature to prevent exporting connections

Hello,
Especially for certificate-based VPN connections, I think it would be useful to add as functionality the possibility to choose when creating these connections whether it is exportable or not.
Or an option (checkbox) at the "Setting locker" that would prevent the export of all connections would be also welcome.
Or another way to protect the unauthorized export of connections from SoftEther Client.
Kind regards,
Bogdan

I see that "Export VPN Connection Setting" is greyed out by default.  How does one re-enabled it?


CSS linting

Implement http://stylelint.io/ as CSS linter.
Read about it https://css-tricks.com/stylelint/.
Integrate with https://www.npmjs.com/package/gulp-stylelint.
Use or inspire in prepared configs https://www.npmjs.com/browse/keyword/stylelint-config.
Try to find useful plugins (BEM, ...) https://www.npmjs.com/browse/keyword/stylelint-plugin.

Implemented stylelint with basic config.

I think we shouldn’t mix eslint with stylelint in one file (gulp/lint.js).
If you agree, I’ll separate them like gulp/eslint.js, gulp/stylelint.js.

Let’s do it.

It’s separated: https://github.com/actum/gulp-dev-stack/commit/cd124c843fda1e01830a1f3d54e48fa3069d011e


Keybase is not accessible to Snaps in Ubuntu

I'm running Ubuntu 18.04 (Bionic Beaver) and I've installed VSCode as my main editor because I loved the built-in SCM features and the ability to have terminal running just below my editor and a little icon tracking my changes. However, I switched my personal repo from GitHub to to Keybase.
Because VSCode runs as a Snap in Ubuntu, it doesn't seem to be able to access the system Keybase. I'm not sure if this more a bug with Keybase or VSCode/Snaps in general, but Keybase is the only thing I'm noticing it in.
Using VSCode's built in SCM module, trying to push gives me a "Keybase is not running, try run_keybase" error dialog. Using git push in the terminal built into VSCode (which should just be my system terminal as I can run other commands in it) also gives me the not running error. However, trying to run run_keybase in the VSCode terminal emulator gives me a "no such file or directory" error.

To Note: This is only an issue if you install VS Code with sudo snap install vscode. Otherwise, downloading the .deb file from Microsoft's website and installing with dpkg makes this work fine.

I am having a problem where the Firefox extension claims that Keybase is not installed. I am using Firefox from snap, so I think it's this same issue, but please do tell if I should open a new one for it.
name:      firefox
summary:   Mozilla Firefox web browser
publisher: mozilla
license:   unknown
description: |
<I have manually snipped Firefox advertising here as I am sure it has nothing to do with this issue.>
commands:
  - firefox
snap-id:      3wdHCAVyZEmYsCMFDE9qt92UV8rC8Wdk
tracking:     edge
refresh-date: yesterday at 13:00 EEST
channels:
  stable:        61.0.2-1    (118) 204MB -
  candidate:     61.0.2-1    (118) 204MB -
  beta:          62.0b18-1   (121) 204MB -
  edge:          ↑
  esr/stable:    60.1.0esr-2 (102) 205MB -
  esr/candidate: ↑
  esr/beta:      ↑
  esr/edge:      ↑
installed:       62.0b18-1   (121) 204MB -

I hope https://github.com/keybase/client/issues/9191 will fix these issues regardless of are they the same or not.

This is intended behavior for Snaps, and I was unaware of it at the time of creating this issue. Closing.