[QUESTION] Adding section item to section that is empty, ie, has an orphan header

Are the following limitations ?

We drag items out of a section so that we now have an orphan header. Can we drag items back into this section [that currently has no items] ?

Can we swap items of different types ? Both items extend AbstractSectionableItem.

@ahmedkhan23, yes, check the demo app, example Headers and Sections.
There are methods and callbacks that you need to override/implement to follow your use case of non swapping/dragging.
Pay attention that the support of Orphan headers, as I intended, is going to be deprecated soon with the next pre-release. Read issue #200 more more information.

Will v5.0.0 b8 always be available in the repo for future access ?
If you are able to tell me which methods to override that would be great.
Also, in general [and perhaps particular to your lib]: what determines the stable ID for any particular ViewHolder ? I ran into an IllegalStateException earlier when trying to swap/drag views with the message that 2 ViewHolders had the same stable ID.

Will v5.0.0 b8 always be available in the repo for future access ?

Yes, 5.0.0-b8, like older pre-releases as well, remains available at JCentral.

What determines the stable ID for any particular ViewHolder ?

As far as I know, stable ids should be used in conjunction only with notifyDataSetChanged() to animate differences, otherwise if items have no stable ids, that method won't run any animations by definition.
In this library, the only way to call that method is to pass animate=false as parameter to updateDataSet(), otherwise single notifications are the normality called everywhere.
Now, notifyDataSetChanged() is very fast when updating the data set but, as said, it comes with no animations, it also rebinds of all items on the screen again. With stable ids it should make the binding only for the real one that changed.
The items have stable ids if their id is unique, so you should implement hashCode() too and return the hash code of the id of your item in accordance with equals()!
Finally, depending on your business information, if you have thousands of items and you are going to use updateDataSet() with animate=false, is always a good choice to provide stableIds=true in the Adapter constructor, so items will animate however.
You can read more about it, googling it.

Ragarding the methods for dragging, there's a listener OnItemMoveListener with the methods shouldMoveItem() and onItemMove(), read the javaDoc. Exists OnItemSwipeListener for swiping too, but I still didn't use them in a real project, somebody did it, so I don't know exactly the needs for new methods if these are not enough.
There's also shouldMove() in the Adapter method that can be overridden but it simply wraps the call to the listener that is better to implement.
ItemTouchHelperCallback is the originator of the calls, that class can be completely customized by the user and set to Adapter. You can extends the existing one, because I wrote some basic code that works for everyone.
The demoApp has the left swiping unfinished, by the way, I need some help for background click and to restore back the swiping automatically if user undoes the action. That I don't know how to do.
Then the FlexibleViewHolder has specific settings for dragging and swiping you might want to enable.


Add Gwion to DSL section

Proposing to add Gwion to the DSL section. Gwion is a language designed specifically for working with sound and I think makes sense to add to your list of DSP tools.

Just added to HyMPS \ Programming ;)

Gwion looks great but the USP of my list is that I try and make it quite personal about things I work with or have some close connection to my area of work in audio/plugin development/spatial audio. If at some point I get inspired to try out Gwion, i'll reconsider this PR! Hope that's OK, all the best, Oli


flutter should expose a command to collect skqp information

Skia has a new tool for validating graphics hardware in the wild:
https://skia.org/dev/testing/skqp
We might want to consider exposing this in flutter as a way to collect info.  FYI @tvolkert

Maybe this is just the same as https://github.com/flutter/flutter/issues/11402 ?


d.ts. files for lib/umd/languageFacts aren't included in npm package

<EMAIL_ADDRESS>
vs

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Seeing this error as a client on 3.0.3 (latest prod):
> svelte-language-server
$ tsc

node_modules/vscode-html-languageservice/lib/umd/languageFacts/data/html5.d.ts:1:34 - error TS7016: Could not find a declaration file for module '../dataProvider'. '/Users/ortatherox/dev/svelte/language-tools/node_modules/vscode-html-languageservice/lib/umd/languageFacts/dataProvider.js' implicitly has an 'any' type.

1 import { HTMLDataProvider } from '../dataProvider';
                                   ~~~~~~~~~~~~~~~~~

Found 1 error.

But the same issue existing on 4.0.0 also<EMAIL_ADDRESS>

It looks like this is on purpose from the .npmignore  - I wonder if the bug then is that lib/umd/languageFacts/data/html5.d.ts even exists at all then

Looks like this section is removed in the 3.0.4-betas - will give those a run

Looking tricky, the codebase I'm looking at pulls a lot of the html data out of this package's privates, and there doesn't seem to be a correlation with the new webCustomData. Going to see if I can just pull some of this from the Vetur source code.
import { HTML5_GLOBAL_ATTRIBUTES, HTML5_VALUE_MAP } from 'vscode-html-languageservice/lib/umd/languageFacts/data/html5';
import { HTML5_EVENTS } from 'vscode-html-languageservice/lib/umd/languageFacts/data/html5Events';
import { HTML5_TAGS } from 'vscode-html-languageservice/lib/umd/languageFacts/data/html5Tags';

It seems like that the data is now available like this:
import { htmlData } from 'vscode-html-languageservice/lib/umd/languageFacts/data/webCustomData';
htmlData implements the public interface HTMLDataV1 so it contains events tags, global attributes, and a map.
Is there any possibility to make these default language facts public, so we can import them like import { htmlData } from 'vscode-html-languageservice';?

We actually publish them to https://www.npmjs.com/package/vscode-web-custom-data, but it doesn't include the types. However it includes the data according to the JSON spec. Would adding d.ts to the vscode-web-custom-data project work for your case?
If you are interested in raw data you should definitely import from vscode-web-custom-data, not the internals of html LS.

Thank you for the info! I did not know about that package. I tried importing it like import htmlData from 'vscode-web-custom-data/data/browsers.html-data.json'; and it seems to work, although infered types are off a little (string not assignable to MarkupKind), but that's okay for me. But of course it would be great if you could add the types. Just to be sure: After that I would import the json like import { htmlData } from 'vscode-web-custom-data?

I just published<EMAIL_ADDRESS>has

New API getDefaultHTMLDataProvider to get the default HTML data provider
New API newHTMLDataProvider to create a new provider from data.


Unhandled rejection when changing grid sort order

Bug appears on Locations and Locations Vehicles screens:
angular.js:14362 Possibly unhandled rejection: canceled

Looks like this is related to the Grid UI not supporting the current version of Angular we are using.  We can supress ALL  unhandled rejections , but that would potentially hide other errors
https://github.com/angular-ui/ui-grid/issues/5890

This was resolved in ui-grid version 4.0.3 and I've confirmed this fixes the issue and still passes all tests.  I don't want to branch and PR this fix till we dicuss what version we want to update though.  The current version is 4.0.6 so I'm not sure where we want to update to of those options

Hi @JVanderford - if the latest seems to have no adverse effects let's update to that one.


[FEATURE] Make log level in kvssink configurable.

Is your feature request related to a problem? Please describe.
Currently, kvssink GST component has hardcoded loglevel to DEBUG.
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blame/master/src/gstreamer/gstkvssink.cpp#L761
It is annoying to see multiple DEBUG messages in long-running GST pipeline.
Describe the solution you'd like
Kindly please make log4cpp logging appender push to gstreamer logging.
This way, kvssink would have gstreamer compatible logging.
Describe alternatives you've considered

Hardcode higher level of logging instead of DEBUG (INFO, WARN?) - quick fix, but hiding any potential issues permanently.
Set log level there, with if(GST_LOG_LEVEL==GST_DEBUG) { LOG_CONFIGURE_STDOUT("DEBUG");} else if(GST_LOG_LEVEL==GST_INFO) {LOG_CONFIGURE_STDOUT("INFO");}  statement during initialization - better one, but logging output is still fully controlled by log4cpp appender.
Rely on log4cpp config (for GST pipelines it would be yet another place to configure logging, which is inconvenient for gstreamer users)

Additional context
none

@mateuszboryn ,
The log level should be configurable. The SDK uses the kvs_log_configuration file to set the log level. (https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/v3.4.1/src/gstreamer/gstkvssink.cpp#L1583-L1590). This is where you set the log level if using the SDK provided log file: https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/v3.4.1/kvs_log_configuration#L1
You could also provide your own log config file by using the log-config property.
Am I missing something here or does this not work for you?


Created design brief method wiki

hey @pamela-drouin - can you take a look at it and merge?

Looks good, thanks @iamjessklein


Undo Prompt at File Save moments

Feature request or easy to add extension?
This a feature from some other editor I find useful. Basically I want undo to pause the last time the file was saved and ask "Continue to Undo Past Save Point?". I find that super valuable as I often just want to undo all edits since the last 1 or more saves. With that feature I just press and hold Undo until I get the prompt, no thought needed. Without that feature I have to carefully watch all the undos and pray I remember when I last saved. If there are hundreds of undos it's fairly hard.
Note: I get that I can just close the file and re-open but that only works for one last save. If I've saved 5 times then I press and hold undo until I get the prompt, click to continue, then press and hold again, repeat, until I get to the save point I wanted. I also get that if I was checking into some VCS on ever save that I could restore a version 5 versions ago but not all files are in a VCS or are new and have not been added yet.
So, Please consider this request for one of the follow.

a feature request for the feature described
a request some events/hooks to make it easy to add
pointers/tips on how to add it if it's already easy

@jennapv isn't what you want that the editor dirty indicator turns off once you reached the saved state again?

Checking the dirty indicator does not seem like enough.


Link to my profile is broken.

Hi,
The link to my profile is broken in all the Code Patterns and Blogs, I am listing below. Here's the link to my developer Advocate profile. Kindly Fix it, I would really appreciate it.
https://developer.ibm.com/profiles/neha1221/

https://developer.ibm.com/patterns/build-a-domain-specific-knowledge-graph-from-given-set-of-documents/
https://developer.ibm.com/patterns/store-graph-and-derive-insights-from-interconnected-data/
https://developer.ibm.com/patterns/image-classification-using-cnn-in-keras/
https://developer.ibm.com/tutorials/develop-a-multi-topic-aware-long-short-term-memory-mta-lstm-network/
https://developer.ibm.com/patterns/generate-insights-from-multiple-data-formats-using-watson-services/
https://developer.ibm.com/patterns/mine-insights-from-software-development-artifacts/
https://developer.ibm.com/patterns/tweeting-bot-that-summarizes-newsblogs-and-tweets-it-on-twitter/
https://developer.ibm.com/patterns/cloud-host-graph-database-using-kubernetes/
https://developer.ibm.com/announcements/image-classification-using-cnn-in-keras/
https://developer.ibm.com/patterns/algorithm-that-gives-you-answer-to-any-particular-question-based-on-mining-documents/
https://developer.ibm.com/announcements/build-a-domain-specific-knowledge-graph-from-given-set-of-documents/
https://developer.ibm.com/patterns/generate-insights-from-multiple-data-formats-using-watson-services/
https://developer.ibm.com/tutorials/develop-a-multi-topic-aware-long-short-term-memory-mta-lstm-network/

@Neha-Setia I can work with you to address this issue.  Please email me directly (corbinm@us.ibm.com), since this issue is not at all related to this particular repo where you posted the issue.  :)

@mcorbin-ibm Hey, sorry for posting it here. I didn't know whom to contact for this and I have mailed you :)


Release memory

Currently homepage always takes near 100MB of memory

For larger image (4096px), the memory taken even going up to 500MB.
How to release these ArrayBuffer after decoded all images?

@Ben-Mack — memory management is a very important topic for webp-hero
i haven't really looked into it, and i myself do not personally understand how to control memory management regarding the libwebp emscripten build — at some point, i naively increased a total memory allowance emscripten setting, when webp-hero was running out of memory at runtime (see a diff from CMakeLists.original.txt to CmakeLists.txt in webp-hero/libwebp/source for more info)
i believe we would need to do some research into memory management in emscripten, and how google's libwebp can be configured
i think an enhancement related to this issue would be implemented as changes to the webp-hero/libwebp dockerfile and associated configurations
if anybody has any ideas about this topic, we'd love to hear about it!
cheers,
:wave: Chase

@Ben-Mack what environment are you measuring usage in? Chrome has, pretty much forever and I think still even now, had a memory leak with Base64 images.

@chase-moskal what if we set this.cache[src] to null after polyfilling here? https://github.com/chase-moskal/webp-hero/blob/master/source/webp-machine.ts#L68 and here https://github.com/chase-moskal/webp-hero/blob/master/source/webp-machine.ts#L73
The only downside I see is if multiple copies of the same image are rendered multiple times on the page, we'll be clearing the cached value. We can probably work around this by created checking whether a src is used again on the page before dropping it from the cache.

@Slapbox — excellent observation, i think the cache is consuming a lot of memory, being that it's saving all of the decoded PNG data and hanging onto it
we should be mindful of a usecase where: a developer who adds new content to the page (via ajax, or component rendering) will want to be able to simply re-run webp-hero polyfillDocument method anytime content may have changed — so we want the cached images to remain available
i propose we could add a clearCache method which simply releases the cache, and the developer is responsible to decide when it's a good idea to do this — also it could be desirable to replace the current cache implementation with a Map object, or maybe we could figure something smart involving WeakMap to better manage this memory (perhaps we could hold references to existing img elements to avoid data duplication between image elements and the cache (however we'd need to ensure CSS images and picture elements and the rest could still work in such a system))
also, it may or may not be worth looking deeper into the way emscripten programs work, i believe it will allocate a bunch of memory space in array buffers, which the asm code will operate on during runtime, and there might be some special considerations to be taken to clear the memory space consumed by the emscripten program after work is completed (perhaps there could be a shutdown() method to dispose of the emscripten memory when work is completed)

@Slapbox It's just the memory tool in Firefox browser.
@chase-moskal Adding shutdown method to dispose all memory in cache and emscripten seems like a perfect fit for my use case

@Ben-Mack — here's some reading material i thought might be relevant on the subject

emscripten docs about avoiding memory spikes
here the creator of empscripten mentions a function called Module._free(ptr)
if we were to expose a function using Module._free(ptr), i believe it would be exposed in wrapping-end.js.txt and also its common-js counterpart

:wave:

I also have issues with memory. I am using this library with React like this:
  useEffect(() => {
    var webpMachine: any = new WebpMachine()
    webpMachine.polyfillDocument()

    return () => {
      webpMachine = undefined
    }
  }, [html])

On Safari iOS as well as macOS both the most recent versions the Site periodically crashes this is indicated by Safari saying "There has been a repeated problem on the website..". Now I am aware that what Im doing in my code is not the most efficient way however it still indicates some issue likely a memory issue in this library.

@OneAndOnlyOdin - Noooooooooooo!
Only run new WebpMachine() once, and in a higher scope! You can run webpMachine.polyfillDocument() as often as you like though.

Yes, this does the trick. Thank you for the Tip.

@Ben-Mack @Slapbox — clearCache has been added and published in the latest version of webp-hero


interaction issue with "python -m pdb" (click 6, windows, python 2.7)

The following module :
import click

#@click.command()
def foo():
    hi

foo()

will drop into the python debugger around 'hi' (the NameError) if invoked with
python -m pdb ./hi.py
but if we activate the click decorator, it will enter a loop like:
PS C:\src> python -m pdb  .\hi.py
> c:\src\hi.py(1)<module>()
-> import click
(Pdb) c
Usage: hi.py [OPTIONS]

Error: Got unexpected extra argument (.\hi.py)
The program exited via sys.exit(). Exit status:  2
> c:\src\hi.py(1)<module>()
-> import click
(Pdb) c
Usage: hi.py [OPTIONS]

Definitely not reproduced on a linux machine (python 2.7).
Is it a purely local issue ? Something windows related ?
Thanks in advance.

I can't reproduce it on my LInux either. Would be nice if somebody would spin up Windows and test this, but I suspect it's not an issue on your side.
At first sight this actually seems like a PDB issue (partially at least) since all the arguments are completely mixed up and Click is getting ./hi.py passed as arg.

I get the same issue on OSX Python 3.6.2

Might be a duplicate of https://github.com/pallets/click/issues/536. This one is older, but https://github.com/pallets/click/issues/536, has more activity.
Not sure what could possibly cause this on OS X... we simply use sys.argv there...

It does repro on Win32, and that is indeed because of #536. You can observe that it has the same workaround, i.e. instead of:
foo()

you must do
foo(sys.argv[1:])

So that Click doesn't try to circumvent sys.argv.

I'm not seeing this on Windows running Python 3. Closing since it seems to be a Python 2 only issue, and we are no longer supporting Python 2. If someone can replicate this on Python 3, please post the failing test case, and I'll reopen the issue.


[BUG] longhorn upgrade is not upgrading engineimage

Describe the bug (🐛 if you encounter this issue)
I am upgrading longhorn from 1.2.2 to 1.3.1.  I have set concurrent-automatic-engine-upgrade-per-node-limit to 1. After upgrading, there are few engineimages which still remains on 1.2.2. I have tried increasing concurrent upgrade limit to 5 also, but observing same behaviour, Although engineimages is getting deployed successfully on all nodes.
To Reproduce
Install 1.2.2. Create longhorn volumes more than 10. Upgrade longhorn to 1.3.1
Expected behavior
All engines should be upgraded.
Log or Support bundle
Environment

Longhorn version: 1.2.2
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE

Number of management node in the cluster: 3
Number of worker node in the cluster: 0

Node config

OS type and version: RHEL
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster: 13

Additional context
Add any other context about the problem here.

longhorn-support-bundle_5d68d7b0-aa45-4a06-b8d8-ae10c25e4c17_2023-04-12T06-16-03Z.zip
Support-bundle

It appears that the default-disk-fd0400000000 on agent3 scheduling is currently disabled. Could you please enable it, or remove any stopped replicas on agent3?
Note: the node IDs are empty on those replicas leading to upgrade failures: CheckEngineImageReadiness: nodes [] don't have the engine image.

Hi @c3y1huang
Thanks for reply.
I tried that and it is still giving the same error. I am seeing this error for other replicas also which are running on nodes having disk.
[root@server0 ~]# kubectl get replicas -n longhorn-system |grep pvc-ee8a7095-1e6d-4d8d-bac2-545a3f30d46c
pvc-ee8a7095-1e6d-4d8d-bac2-545a3f30d46c-r-6aba64bc   running   server0   ceb573c2-5cdf-414d-97a8-87cf7662bae9   instance-manager-r-43d27d07   sfbrdevhelmweacr.azurecr.io/longhornio/longhorn-engine:v1.2.2   13h
pvc-ee8a7095-1e6d-4d8d-bac2-545a3f30d46c-r-8b9ec4b9   running   server2   3d1c5500-2378-444e-9b39-6fc99168f2ab   instance-manager-r-23904f36   sfbrdevhelmweacr.azurecr.io/longhornio/longhorn-engine:v1.2.2   14h
[root@server0 ~]# kubectl get engines -n longhorn-system |grep pvc-ee8a7095-1e6d-4d8d-bac2-545a3f30d46c
pvc-ee8a7095-1e6d-4d8d-bac2-545a3f30d46c-e-9c8248d3   running   server2   instance-manager-e-45a58b0d   sfbrdevhelmweacr.azurecr.io/longhornio/longhorn-engine:v1.2.2   14h

@shuo-wu , any ideas?

Checked volume pvc-2b681d80-52bc-46e5-a87a-2001d877bd84
I don't know why this volume is healthy but contains an unscheduled replica. But I think this unscheduled replica (with empty node ID) is the culprit: When the function checks if the nodes of all replicas (nodes) have the corresponding engine image, the empty node ID of course does not in the engine image deploy list (nodesHaveEngineImage). Then Longhorn print out this kind of misleading log:
2023-04-12T05:53:19.791439128Z time="2023-04-12T05:53:19Z" level=warning msg="Engine live upgrade from sfbrdevhelmweacr.azurecr.io/longhornio/longhorn-engine:v1.2.2, but the image wasn't ready" accessMode=rwo controller=longhorn-volume engine=pvc-2b681d80-52bc-46e5-a87a-2001d877bd84-e-e7d696a7 error="<nil>" frontend=blockdev migratable=false node=agent3 owner=agent3 state=attached volume=pvc-2b681d80-52bc-46e5-a87a-2001d877bd84 volumeDesiredEngineImage="sfbrdevhelmweacr.azurecr.io/longhornio/longhorn-engine:v1.3.1"

@mynktl , in summary:

Try to solve the empty nodeID issue with this comment.
Make the volumes healthy as @shuo-wu mentioned.

Please provide a new support bundle if still doesn't work for you.

Hi @c3y1huang  @shuo-wu
I am attaching a new bundle from another environment where I am seeing this issue.
In this, I am seeing issue with 5 volumes out of which 1 is healthy and remaining 4 are degraded (Its been more than 12hr still not able to complete rebuilding). All these volumes have replica in running state also.
longhorn-support-bundle_80570984-c26d-474b-9ff3-51fc7f4fafa3_2023-04-18T06-39-42Z.zip
Is there any way to make this volume healthy?

Possibly because the disk scheduling is disabled on agent3?
    name: agent3
    disks:
      default-disk-fd0400000000:
        path: /datadisk
        allowscheduling: false
        evictionrequested: false
        storagereserved: 641099366
        tags: []

I am not sure about that. I think that should not cause any issue since disk scheduling is configurable and all replicas are in running state.

It seems it's unable to find the reproduce way, so see if live upgrade w/o any issues, is good enough, @shuo-wu ?

Sure. Will we close this issue then?

Let's close this after QA verify the related auto e2e test cases.
cc @longhorn/qa

Close this ticket, in recent build of longhorn master head test pipeline, engine upgrade test  did not encounter issue. Below is restult for reference:

Upgrade form v1.2.6 to v1.3.2 to master-head, did not see outstanding issue in test_engine_upgrade

Build 155
Build 156
Build 157

Upgrade from v1.2.6 to master-head, did not see outstanding issue in test_engine_upgrade

Build 443
Build 444
Build 445


Update beyond-compare to v4.1.0

Thank you for the contribution. It was merged directly as 2daaab489ecc9bab92551d6ec5e4e7f91b15b14d to keep commit history cleaner. Your contribution is still credited to you.

Thank you for the contribution. It was merged directly as 453a6c456a0659e046864de2258a3b9bd33d92d0 to keep commit history cleaner. Your contribution is still credited to you.


orphan cluster object opens thousands of agent proxy connections

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Run the rancher server standalone
Deploy a GKE cluster
destroy the GKE cluster directly from GKE
keep the GKE cluster object in Rancher
watch the proxy connections grow

Result:
Proxy connections to the Rancher Agent will grow to thousands within minutes.
Other details that may be helpful:
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:6443          <IP_ADDRESS>:*               LISTEN      29200/rancher
tcp        0      0 <IP_ADDRESS>:2379          <IP_ADDRESS>:*               LISTEN      29200/rancher
tcp        0      0 <IP_ADDRESS>:2380          <IP_ADDRESS>:*               LISTEN      29200/rancher
tcp        0      0 <IP_ADDRESS>:6060          <IP_ADDRESS>:*               LISTEN      29200/rancher
tcp        0      0 <IP_ADDRESS>:32781        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:51672        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:47780        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:59148        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:36438        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:39704        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:54283        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:52140        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:36183        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:51817        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:41687        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:47804        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:53398        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:33656        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:34809        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher
tcp        0      0 <IP_ADDRESS>:45031        <IP_ADDRESS>:443         ESTABLISHED 29200/rancher

{
...
    },
    "agentImage": "rancher/rancher-agent:v2.2.1",
...
    },
    "apiEndpoint": "https://<IP_ADDRESS>",
    "appliedEnableNetworkPolicy": false,
...

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):
V2.2.1

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Hosted
Machine type (cloud/VM/metal) and specifications (CPU/memory): Cloud
Kubernetes version (use kubectl version): 1.13.11-gke9

Here’s my best guess:

I had deployed the GKE test cluster many months ago
at some point the GKE test cluster was removed directly from the GKE interface
meanwhile Rancher server was attempting to reach out to the existing cluster at the https://<IP_ADDRESS>:443
at some point google reassigned the ip https://<IP_ADDRESS> to something and that caused Rancher server to make a connection there
whatever is on the other end of the ip https://<IP_ADDRESS> is certainly active but clearly not a Rancher agent hence the connections are invalid.
this is certainly a bug in the server code as it should not be designed to ddos an ip


tunnel: return tunnel token, fix uri

Description
Update TunnelToken to return the result as a string. Also fixes the uri to start with /
Downstream PR here: https://github.com/cloudflare/terraform-provider-cloudflare/pull/1590 (to be updated)
Has your change been tested?
Tested locally with changes to the terraform provider (see above PR) to verify token result was retrievable and properly set in state.
Types of changes
What sort of change does your code introduce/modify?

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.
[X] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

added a simple test to cover the change here


[py3-native] - minimal ubi 9.2

Status
Ready
Related Issues
Related: link to the issue
Description
change py3-native to be based on ubi 9.2 minimal

please note in changelog

pretty smooth change looks like

still didn't make it work, on it


Set name as well as id

Set name as well as id so Firefox PPAPI can find flash element when using ExternalApi from flash

Closing since this is old.


MAX_NUMBER_OF_MEMBERS

Hi,
Boost Hana's wonderfulness is unavailable for some autogen structs from table work I'm working with.
I have more than 62 columns - to be members -  of the table - to be struct.
Unfortunately, the ERB in hana/detail doesn't like the idea of more than 62 members in a struct.
MAX_NUMBER_OF_MEMBERS = (ENV["MAX_NUMBER_OF_MEMBERS"] || 40).to_i     raise "MAX_NUMBER_OF_MEMBERS must be <= 62" if MAX_NUMBER_OF_MEMBERS > 62
Pretty sensible for handcrafting but a bit limiting for my autogen work. Any thoughts on how best to raise the bar to 79 or 99 members?
Kind regards,
--Matt.

It looks like the ERB is just generating preprocessor macros which have a limit to the amount of arguments that a macro can receive.
The docs for Struct show that you can implement hana::accessors for your type directly instead of using the macro. It's not very pretty, but if you are generating code heterogeneously (outside of c++) that probably doesn't matter.
See the examples below "Minimal Complete Definition" here: Struct

Thanks for the link to Struct. That'll do the job I need.

I was away over the holidays. Reopening since I think we need a better solution. The ERB could generate the macros it needs for up to the right number of elements. In other words, we could lift the restriction that MAX_NUMBER_OF_MEMBERS <= 62.

This should now be addressed. You can now generate struct_macros.hpp without any restriction on the number of members. This will be in Boost 1.67.


AspNetUserLogins can have a null UserId

That doesn't make sense to me.  With the removal of the UserId from the composite primary key was the non-null metadata for this property missed ?

Fixed in c847f9c50df478ef826f6d4781ddcd760325da78

thanks


Simplify config classes using @Getter @Setter annotations

Describe your changes :

I worked on this to simplify config classes and make them compact

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Backend: @sureshms @harshach

Thought about using @Data - decided not to as it brings in a whole lot of other things besides getters and setters


File extension is changed from %22 to " when uploading file to blob through storage explorer

Storage Explorer Version:  1.17.0
Build Number: 20201211.10
Platform/OSWindows10
Architecture x64
Bug Description
If I just upload one .%22 file through Storage explorer, the extension doesn’t change, but if I upload a folder containing a .%22 file, the extension changes.
Steps to Reproduce

Upload a file with suffix %22 to container, no change for extension
Upload a folder containing a .%22 file, the extension changes. But for other .%23,.%25.%26 extensions, there is no change.

Expected Experience
What cause the difference? Is this by design or can be improved?

I am also encoutering the same issue which has blocked the project schedule. Could someone help to check and solve this issue? or some valuable advice? Thanks a lot!

This is expected by our current design but I do think it does have some ambiguity. The cause of the different behavior is that we only encode the url that we know for the upload. For example, if you upload a file "file.%22", the encoded destination url would be something like "https://acct.blob.core.windows.net/container/file.%2522". Thus the exact extension can be preserved. However, if you upload a folder containing such files, the only url we know is the url to the folder. Whether to encode the sub-filenames is up to the client tool we use.
Is there a reason why you choose % as a part of the extension name? % is preserved for url encoded characters so choosing another character would make things much easier.

@JasonYeMSFT. thanks for your reply. Because All the local files are suffixed with this %22. we need to upload a lot of the local file. If we have to make this adjustment, it will take a lot of time. Is it possible to fix the problem from the azcopy?  looking forward to your reply.

Is there a reason you have to name your file in %22 extension? If it is a dedicated file extension, we should consider supporting it.
AzCopy automatically encodes/decodes your file names so that even if they show up as *****." on Azure Storage, when you download them, they would be encoded again as *****.%22 in your local file system since " is an invalid character for Windows file name.
That is to say, a work around for you is that:

Group all your local files in a directory, instead of as single files, and upload the directory. All files will have extension " on Azure.
When you write code to interact with Azure Storage, take that into consideration and use " in your blob names.
When you download those files, their extension will be encoded as %22 which recovers their original file name.

@JasonYeMSFT. thanks for your response. Happy Chinese new year! The extension “.%22” is an output format of commercial software we are using, so we cannot change it. Please consider this issue in your backlog of the software update. Since we kind of found walk around, for now, the issue doesn’t need to be solved immediately.

@JasonYeMSFT,
Will there be some fix plan for this issue? and could we know the ETA?  Thank you in advance.

We talked to the AzCopy team and they are currently considering the ability to turn off the % decoding functionality. So we do not have any sort of ETA yet. As a workaround you can clone the file after it has been uploaded to have the correct name.


[KARAF-5805] Add feature required item field to JmxFeature CompositeData

https://issues.apache.org/jira/browse/KARAF-5805

Must we build with SNAPSHOTs? Sorta screws CI up when they're not available in any remote repo.


definitionModuleName is undefined for table type aliases

definitionModuleName is only defined in the case of an explicit table definition using AstExprTable. However, when a TableType is resolved from an AstStatTypeAlias with an AstTypeTable contained, no definitionModuleName is filled in initially. This is an issue for anything that resolves a table type without an AstExprTable really, but that's mostly limited to type aliases.
The constraint solver is supposed to fill this in later for specifically type aliases, but it's currently a TODO item since Luau 539, which for the informed reader was released in August of 2022. I think an issue is appropriate to track this rather than having to track down a TODO item for it.
https://github.com/luau-lang/luau/blob/master/Analysis/src/ConstraintSolver.cpp#L1104
This is problematic because existing (major) code depends on this, namely luau-lsp, and this behavior is not present in the old solver (the type alias has the correct definitionModuleName) and this causes luau-lsp tests to fail.
https://github.com/JohnnyMorganz/luau-lsp/blob/main/src/operations/Completion.cpp#L373

needs new solver label


[TRIFFLES] Duplicating items with the pouch

Vane versions: 1.12.2
Paper version: paper-1.20.1-18
Here is an explanation in GIF:

Thanks, I'll push a fix right now

I think the problem may also be present for the bag

Both should be fixed by this

Nice thx !


SQL Editor: remove the esoteric keywords from the autocomplete suggestions

Current keywords include: whenever, work, write. These aren't used in everyday SQL and distract from the more substantive suggestions.

qq on this: are there other SQL keywords that we don't allow because they are not applicable to modeler? @hamilton i think you mentioned that CREATE TABLE queries are not allowed, is that right? If so, should we remove those keywords as well? And would there be anything else in that category?


There is always a "Show" option in mac!

How to disable the default "Show" option?
My current options are:
open: undefined,
closeLabel: undefined,
dropdownLabel: undefined,
actions: ["A", "B", "C"],

Apparently, the "Show" option just focuses the terminal where I'm running the node process.

Also...how to change the title from "TERMINAL-NOTIFIER" ?!

Also...how to change the title from "TERMINAL-NOTIFIER" ?!

maybe help you
https://github.com/mikaelbr/node-notifier/issues/71


geph: init at 4.5.0-beta.1

Description of changes
geph: init at 4.5.0-beta.1
A modular Internet censorship circumvention system designed specifically to deal with national filtering.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@NickCao Could you please review this PR? (Sorry for pinging you, just thought that maybe a v2ray package maintainer is interested in this.)

A few nitpicking: the commit message should be in the format: <pname>: init at <version>, and cleaning up the history into three commits: add maintainer, add the node package, add the rust packages would make it look leaner.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/497

Can we merge it?


default constructor creation for derived class is not spec compliant

As per spec, if derived class doesn't have constructor, it should create a constructor something like this -
constructor(... args){ super (...args);}

Instead we do something like this -
constructor(... arguments){ super (...args);}

...arguments part loads argumentsObject on heap which is not performance efficient.

FYI - @akroshg , @suwc

Is the use of rest and spread optimized in this case or do they also add perf overhead that may be avoidable somehow?

Is the use of rest and spread optimized in this case

Probably. See #1230


[terraform_docs] Enable target different file instead of README.md

Hi,
I wanted to ask that if it is possible to have custom markdown file (e.g. docs.md or readme.md) for terraform_docs instead of using the default README.md?
Perhaps it is available to pass in the args in the .pre-commit-config.yaml?
Thanks.

Hi @nicholastcs, it is not yet possible
https://github.com/antonbabenko/pre-commit-terraform/blob/master/terraform_docs.sh#L113
It will be done in #7, close as duplicated


[gallery] call for community submissions

Making something cool with vx?
Submit a pull request or post here and we'll get it added to https://vx-demo.now.sh/gallery
Using vx in a project?
Post the project/company name + link and we'll add it to the Used By list in the Readme.

Where in the repo structure should gallery examples be placed?

@Fxlr8 - https://github.com/hshoff/vx/tree/master/packages/vx-demo

At the moment I've been featuring community projects in the Readme's In the wild  section https://github.com/hshoff/vx#in-the-wild.
Plan is to add a vx-demo.now.sh/gallery/community page once we have more examples to feature.

I've been building up a catalog under my codesandbox - https://codesandbox.io/u/techniq/sandboxes that might be worth linking in as well at some point.
I just created a new tag on codesandbox vx:example to make it easier to search for other examples (useful to say also show me examples using react-move)


fix and reenable testSkip_RequiredCharsets

The problem in this test was asserting something that simply wasn't true and wasn't expected to be true in many cases. Removing the offending assert allowed some redundant tests to be removed.
@garydgregory

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b54ac95) 86.13% compared to head (4844a07) 86.13%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #518   +/-   ##
=========================================
  Coverage     86.13%   86.13%
  Complexity     3427     3427
=========================================
  Files           229      229
  Lines          8140     8140
  Branches        959      959
=========================================
  Hits           7011     7011
  Misses          850      850
  Partials        279      279

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ATTENTION: Certbot 3.0 Python Update] Impacts to Third Party Plugins

Greetings from the Certbot Team,
With Python 3.8 reaching its end-of-life (see https://devguide.python.org/versions/#supported-versions), we have to update our Certbot snaps to a newer Python version. We will switch over early October and giving plugin developers until October 1st, 2024 to work on any updates to ensure their plugins don't break with Certbot 3.0.
If your plugin is released before Certbot 3.0.0, your users will continue to use your last version until Certbot 3.0.0 is released. Aim to release your plugin before Certbot 3.0.0 is released. If your plugin is released after Certbot 3.0.0, it will likely break.
We have outlined steps below, so you can take to smoothly update and test against the new changes:
Third Party Plugins Update Checklist:

[x] 1. Ensure snapcraft --version is at least 8.3

[x] 2. In your setup.py, change version to be 3.0.0 (though 2.12.0 and higher should work, assuming Certbot makes no interim releases).

[x] 3. Follow one of these instructions for updating snapcraft.yaml:

If you are using generate_dnsplugins_snapcraft.sh, grab the latest from github and run it again.
If you are manually editing your snapcraft.yaml  file, make the changes to tools/snap/generate_dnsplugins_snapcraft.sh shown in this commit, or similar. Migration guides can be found for core20 to core22, and core22 to core24.

[x] 4. Follow one of these instructions for building the snap:

If you are running snapcraft remote-build, note that the --build-id flag is not used, and that the command must be run from the main directory of a git repo.
If you are running certbot's build_remote.py script, you should be able to use it as before.
If you are manually building the snap, remove sudo /snap/bin/lxd.migrate -yes from your lxd setup instructions. You may need to be on ubuntu 24 to build it properly.

To test against Certbot with these changes implemented, use the edge channel: sudo snap install certbot --edge --classic. The version in that channel is 2.12.0.dev0, so setting your version to 2.12.0.dev0 temporarily (or lower) will allow it be installed for testing. After testing, be sure to bump your released version as mentioned in step 2.
Although no other changes should be necessary, see this PR for all changes made to migrate Certbot to core24/python3.12.
Do contact us on our Mattermost in our Certbot channel or<EMAIL_ADDRESS>if you have any questions.

Thanks! This is done now. These notifications are very helpful for maintainers!


fix: improve jinja err msg

Before:

After:

Note: currently I just pass the entire recipe source to the function. I am considering forwarding it to all the functions, as otherwise, the string that will be rendered won't make much sense.
Fixes #309

much better!

Should we delete the commented out error? Happy to merge.


Windows 10 Pro - No usable display

Hi,
Please see screencap.
My Windows 10 Pro is running as a VM in Virtualbox 6.1 if that matters.

Thanks @dlbradford for logging the issue! Currently, the editor relies on OpenGL 4+ on Windows - which doesn't seem to be well-supported in VirtualBox There might be a way to configure VirtualBox for it, though.
We're also looking at supporting DirectX render strategy (via ANGLE), which it does seem like virtualbox has better support for (and more broadly, better Windows support in general).

@bryphe, thank you for the reply and likely explanation. I will mess about with it to see if I can sort it out re OpenGL 4+ in VirtualBox.

Hi @dlbradford - this should be fixed now w/ latest builds, as we use ANGLE as the renderer strategy on Windows (which uses the better-supported D3D instead of OpenGL). I've tested on Hyper-V and Parallels which both had similar issues.
Will close as fixed with #2283 , but please let me know if you still have issues opening Onivim


redbean: init at 2.2

Description of changes

created redbean package
added myself as contributer

Things done

[v] Tested basic functionality of all binary files
[v] Fits CONTRIBUTING.md.

@coderofsalvation

file location is not correct, should be pkgs/by-name/re/redbean/package.nix
please keep original PR template
commit message doesn't follow  https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md maybe squash last commit

Don't know how I missed this, but upstream gives you instructions to build from source. You should do that instead. See https://redbean.dev/#source1

redbean is basically a binary build produced in this nixpkg: https://github.com/NixOS/nixpkgs/blob/nixos-23.11/pkgs/by-name/co/cosmopolitan/package.nix#L86
Btw. realize I'm a complete nixos noob, and I couldn't even use the cosmopolitan package (no idea where it installs what).
Instead I've always relied on podman to build stuff:
FROM alpine:latest

RUN apk add git bash make clang gcc g++ linux-headers

RUN git clone https://github.com/jart/cosmopolitan /cosmo --depth=1

# install and precompile simplest app (to speed up successive builds
RUN cd /cosmo && \
    mkdir -p o/third_party/gcc && \
    cd o/third_party/gcc && \
    wget https://cosmo.zip/pub/cosmocc/cosmocc.zip && \
    unzip cosmocc.zip && \
    cd - && \
    o//third_party/gcc/bin/make o//tool/net/redbean.com

I feel like this is going a bit beyond my current skillset, and I feel a bit worried I'm turning this PR into a nix course.
I guess the cosmpolitan nix-package should somehow be imported in this package, on the other hand the cosmopolitan-package might actually be the one shipping all the .COM binaries (like redbean).

That's all right, @coderofsalvation. Just add the changes I requested and you're good to go. This could be packaged from source in the future, by you, by us, or by someone who comes along here :)

@coderofsalvation thank you very much for your efforts
I just did some very simple hacks and was able to build redbean.com from source.
my recommendation would be to get @lourkeur ( github name changed ? ) @tomberek to have a look, since easiest way is to add redbean is to change/use cosmopolitan.
@coderofsalvation as for collaborative learning nix of, there is https://discourse.nixos.org/ feel free to ask questions there and tag me


Connect an existing container

Hello,
It's possible to connect directly to existing container by name ?
Thanx

Yes it is and it is actually one of the default behavior when running ssh2docker without any arguments.
However, I need to refactor all the arguments parsing to get something more natural, then I will update the documentation with different scenarios and examples

ok, Thanx


tabs - accessibility issue when using ul/li semantic

fix #30338 add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc

Why does this target v4-dev specifically? Isn't the issue present in master?

I'll take a look on v5

We generally target the master branch and then backport stuff in v4-dev. Not sure if the patch will apply clean going from master to v4-dev (probably not), so it should be OK for this specific case.
Generally we target master and cherry pick or apply manually what's needed for v4-dev.

thanks for this info for other PR I will target the master

FYI related #30382 (for v5) is approved by @patrickhlauke :)

@XhmikosR It's been merged in v5, I guess it can be merged in v4 too :)

Yeah, still waiting for @patrickhlauke approval, because this isn't a cherry pick.


pyimgui public interfaces (enables IDE autocomplete)

Hello!
I've created a simple script to automatically build public interfaces for our dear pyimgui in order to enable code autocomplete in your IDE of choice. 😃
You can find the repo here for details and if you are currently using the docking branch, feel free to use the  imgui.pyi  that is already provided.
If you haven't read the README, all you need to do is to copy the imgui.pyi file in the root folder of your virtual environment (be sure that your ide is using that too).
Test on VSCode:

Have a good day!

Thank's this sound awsome!

Hey, I am considering using this tool to automatically generate the .pyi file during the build and distribute it with the package via pip. In your readme there are several disclaimers:

The imgui.pyx in this repo contains imgui constants too, but this is not implemented in the code (yet) and has to be done manually.
Private member functions are included (change regex to exclude them)
This is an early alpha, code is not refactored and bugs might be hiding.

Do you have an estimate of the amount of work that those fixes would need? Do you plan to continue to work on this?

This is a very welcome addition, thanks!
I have some advices, since I saw that my IDE does a very good job at helping with pyimgui, and I wanted to see what could be done in your project to try to reproduce it (my IDE is Clion by JetBrains, but I suspect Pycharm does the same. May be this is only available in the paid versions).
When I select "go to definition" in my IDE:

This is what I see:

I would suggest to try to approximate the same function, by modifying the pyi file like this (i.e copy also the docs)
def begin( label: str,closable: Any = False, flags: Any = 0) -> Any: ...
    # begin(str label, closable=False, ImGuiWindowFlags flags=0)
    # Begin a window.
    #
    #     .. visual-example::
    #         :auto_layout:
    #
    #         with imgui.begin("Example: empty window"):
    #             pass
    #
    #     Example::
    #         imgui.begin("Example: empty window")
    #         imgui.end()
    #
    #     Args:
    #         label (str): label of the window.
    #         closable (bool): define if window is closable.
    #         flags: Window flags. See:
    #             :ref:`list of available flags <window-flag-options>`.
    #

More information:

A two minutes video where I show how it in action: https://traineq.org/pyimgui_stubs.mp4

The "kind of stubs" generated by Jetbrains: https://traineq.org/imgui_jetbrains_stubs.tgz

PS: at the moment, your repo does not produce an output which is similar to the imgui.pyi file you gave (the constants are missed).
Excellent job ad good idea anyhow!

This is a very welcome addition, thanks!
I have some advices, since I saw that my IDE does a very good job at helping with pyimgui, and I wanted to see what could be done in your project to try to reproduce it (my IDE is Clion by JetBrains, but I suspect Pycharm does the same. May be this is only available in the paid versions).
When I select "go to definition" in my IDE:
This is what I see:

I would suggest to try to approximate the same function, by modifying the pyi file like this (i.e copy also the docs)
def begin( label: str,closable: Any = False, flags: Any = 0) -> Any: ...
    # begin(str label, closable=False, ImGuiWindowFlags flags=0)
    # Begin a window.
    #
    #     .. visual-example::
    #         :auto_layout:
    #
    #         with imgui.begin("Example: empty window"):
    #             pass
    #
    #     Example::
    #         imgui.begin("Example: empty window")
    #         imgui.end()
    #
    #     Args:
    #         label (str): label of the window.
    #         closable (bool): define if window is closable.
    #         flags: Window flags. See:
    #             :ref:`list of available flags <window-flag-options>`.
    #

More information:

A two minutes video where I show how it in action: https://traineq.org/pyimgui_stubs.mp4
The "kind of stubs" generated by Jetbrains: https://traineq.org/imgui_jetbrains_stubs.tgz

PS: at the moment, your repo does not produce an output which is similar to the imgui.pyi file you gave (the constants are missed).
Excellent job ad good idea anyhow!

Hi, I have just updated the readme, since the imgui.pyi has to go into the "site-packages" folder, not into the venv root, sorry. i.e: on windows is located into "Lib/site-packages".
I see your point on preserving the docs comments, that'd be neat! I'll see what I can do about it and what @KinoxKlark suggested :)
Atm I'm quite busy though, keep in mind that I wrote that code in half a day so it needs a lot of work. Also I didn't know it could grab some attention lol
Anyways, thanks for the kind words!

Just one note: on my side, the pyi will work only if it is named site-packages/imgui/__init__.pyi(using Visual Studio Code)

Hi
Sorry but I cannot understand how this pyimgui library is useful.
I cannot get the autocomplete to work while writing code (windows vs code , pyimgui ver 2.0.0)
only while running then in debug console this works.
Does any user of this library found any success having auto complete.  the reposetory of @masc-it does not work.
and this is something that should work just with a pip install.
I am using ImGui in c++ and wanted to try a pyhthon version, but it seems there is no good version to work with.

seems like the issue is with language serever. by changing it to jedi auto complete seems to work!!
so go to setting in vscode search for server,  and python and choose jedi.  (instead of default that uses pylance)

it is still not full because if I want to get_window_draw_list() then I want to add circle / polygon there is no autocoplete  also in pycharm.

Hey, thanks for reaching out. I did not find the time to look into this yet, so I am afraid that there are no out of the box working solution. I myself do not use any autocompletion tool and I do not know how it works so I won't be able to help with this in a near futur. But as previously stated, I am willing to merge any working solution.
Since the scripts was developed here, we updated to 2.0 and we also did split the source code into several files in the 'fixes' branch https://github.com/pyimgui/pyimgui/pull/328. The 'fixes' and 'docking' branch are the most recent version, and any change should be proposed here. I can't guaranty that the developed script still works, and it probably has to be partly rewritten.
If someone here has any ressources that may be useful to learn how to configure this, it could be nice. I am guessing that such a config file has to be generated by parsing every function of our interface and listing them. One of the next projects that I have on the list for pyimgui is to write such a parser that is able to match every mapped function with the one from DearImGui in order to automate the upgrade process. I believe (thought I might be wrong) that this could be the a good place to append the generation of autocompletion config file (?).

I found this answer in pylance (vs code default python langage server) about producing some generate stub that can be used when a project is using Cython
https://github.com/microsoft/pylance-release/issues/674#issuecomment-1104716079
Maybe this approch will work. (I don't have experience with this )
when you say you don't use autocomplete/intelisense , so for each function you search the documentation, you don't have any IDE that helps completing function names, and describes the function input?

Thanks for the link. I'll try to schedule some time to look into this, it may indeed be a useful feature, especially for new users.

when you say you don't use autocomplete/intelisense , so for each function you search the documentation, you don't have any IDE that helps completing function names, and describes the function input?

Yep. I don't think this is relevant to this topic, but to satisfy your curiosity: I am used to coding only with syntax colouring in emacs or notepad++. Once you master the basic keyboard shortcuts, you can easily search code bases or local docs to find the function you want and its prototype. And I usually don't have to search for each function every time. I think one of the benefits of rewriting everything every time is that you end up learning the said functions pretty quickly :-)

For anyone looking for any help with this issue, I noticed that simply doing stubgen -p imgui doesn't work as it errors out on some syntax error with pyimgui 2.0.
But this generates some stubs that seem to work at least a little bit:
stubgen --ignore-errors --inspect-mode  -p imgui

The result of this is that at least some exports for the imgui top level import are found.  So it turns a lot of red underlines to "unknown" which is a bit better.  (before and after screenshots below)
I'm so used to VSCode and its real-time Python type checking and auto-complete, that it's a bit of a bummer that pyimgui doesn't work with it.

Did some extra digging and I was able to get stubgen to work without errors if I edited core.pyx as follows, did make build and ran stubgen -p imgui.
--- a/imgui/core.pyx
+++ b/imgui/core.pyx
@@ -2740,11 +2740,6 @@ cdef class _ImGuiTableSortSpecs(object):

 cdef class _ImGuiViewport(object):
     """Currently represents the Platform Window created by the application which is hosting our Dear ImGui windows.
-
-       About Main Area vs Work Area:
-       - Main Area = entire viewport.
-       - Work Area = entire viewport minus sections used by main menu bars (for platform windows), or by task bar (for platform monitor).
-       - Windows are generally trying to stay within the Work Area of their host viewport.
     """

     cdef cimgui.ImGuiViewport* _ptr
@@ -2774,25 +2769,25 @@ cdef class _ImGuiViewport(object):

     @property
     def pos(self):
-        """Main Area: Position of the viewport (Dear ImGui coordinates are the same as OS desktop/native coordinates)"""
+        """Position of the viewport (Dear ImGui coordinates are the same as OS desktop/native coordinates)"""
         self._require_pointer()
         return _cast_ImVec2_tuple(self._ptr.Pos)

     @property
     def size(self):
-        """Main Area: Size of the viewport."""
+        """Size of the viewport."""
         self._require_pointer()
         return _cast_ImVec2_tuple(self._ptr.Size)

     @property
     def work_pos(self):
-        """Work Area: Position of the viewport minus task bars, menus bars, status bars (>= Pos)"""
+        """Position of the viewport minus task bars, menus bars, status bars (>= Pos)"""
         self._require_pointer()
         return _cast_ImVec2_tuple(self._ptr.WorkPos)

     @property
     def work_size(self):
-        """Work Area: Size of the viewport minus task bars, menu bars, status bars (<= Size)"""
+        """Size of the viewport minus task bars, menu bars, status bars (<= Size)"""
         self._require_pointer()
         return _cast_ImVec2_tuple(self._ptr.WorkSize)

I guess the original imgui doc syntax throws off stubgen.
Generating stubs like this outputs something useful but alas, stubgen somehow ends up messing up keyword arguments:
def drag_float(strlabel, floatvalue, floatchange_speed=..., floatmin_value=..., floatmax_value=..., strformat=..., ImGuiSliderFlagsflags=..., floatpower=...) -> Any: ...
def drag_float2(strlabel, floatvalue0, floatvalue1, floatchange_speed=..., floatmin_value=..., floatmax_value=..., strformat=..., ImGuiSliderFlagsflags=..., floatpower=...) -> Any: ...
def drag_float3(strlabel, floatvalue0, floatvalue1, floatvalue2, floatchange_speed=..., floatmin_value=..., floatmax_value=..., strformat=..., ImGuiSliderFlagsflags=..., floatpower=...) -> Any: ...
def drag_float4(strlabel, floatvalue0, floatvalue1, floatvalue2, floatvalue3, floatchange_speed=..., floatmin_value=..., floatmax_value=..., strformat=..., ImGuiSliderFlagsflags=..., floatpower=...) -> Any: ...

Somehow it prefixes argument names with the type from core.pyx file :cry:

seems like the issue is with language serever. by changing it to jedi auto complete seems to work!!
so go to setting in vscode search for server, and python and choose jedi. (instead of default that uses pylance)
it is still not full because if I want to get_window_draw_list() then I want to add circle / polygon there is no autocoplete also in pycharm.

for vscode, this is working well for me. for the uninitiated, create .vscode/settings.json to your vscode project and add the following to it
{
    "python.languageServer": "Jedi"
}


data expired?

https://github.com/mkkellogg/GaussianSplats3D/blob/main/projects.markkellogg.org/downloads/gaussian_splat_data.zip

Thanks for the heads up, I swear that link was working properly :)

i have a couple of minor problems on windows, might do a pr

Maybe use google drive or drop box?

Maybe use google drive or drop box? Is the splat format explained somewhere by the ay? Is it just ply?

Sorry it took me so long to respond, the .splat format has been continually evolving until recently. Right now it is a bit more settled; It's way more trimmed down than a ply and supports compression using a chunking scheme. It still needs work, although with all the other splat viewers being developed it might make more sense to come to some agreement on a single format.


Refactor Navbar

@CimattiConsulting FYI, a tiny refactor for the use of new improved API

@artf
Thank you,


#67 text to speech

Requires some refactoring here and there, but works as intended.

wow! i want to test this as soon as possible :)


Offline Mode

FEATURE REQUEST / SUGGESTION
Offline mode
SUMMARY
Is there Someway that the component could implement to work with offline mode too?
It seems google maps sdk don't implement this yet:
https://issuetracker.google.com/issues/35827808
But i saw some custom solutions in that way:
https://code.google.com/archive/p/ogmaps/
Is that viable to Xamarin.Forms.GoogleMaps?
PLATFORMS
which platform do you want?

[x] Android
[x] iOS
[ ] UWP

VERSIONS

Xamarin.Forms.GoogleMaps - 1.8.1

No we can't.
Because Xamarin.Forms.GoogleMaps is depends on Google Maps SDK.
We can't inject some custom implementations.


[RFC] Conditional CRDT read requests

(I am currently designing an application that is kind of document store, where documents are stored in Riak KV as CRDTs, updated in Riak quite infrequently and cached in mobile devices for offline reading. I am currently evaluating cacheability of CRDTs in mobile devices - hence this ticket.)
Problem statement
From RFC 7232 section 1 i.e. HTTP/1.1 “Conditional Requests”:

Conditional GET requests are the most efficient mechanism for HTTP cache updates ...

Riak KV has conditional read requests for plain objects - both via the PB and HTTP APIs:

In PB API, see request parameters if_modified that is meant to be the Riak object vclock of a previous read response;
In HTTP API, see request parameter If-None-Match that is meant to be ETag header of a previous read response. Notice that the HTTP read response has both the Riak object vclock X-Riak-Vclock and the entity tag ETag, and notice also the usage of Riak object vclock and entity tag in the write request.

KV generates entity tag specifying webmachine callback function generate_etag implemented in KV and also called inside other callbacks by KV;
(Riak KV also has timestamp-based conditional requests but I am ignoring that on purpose as not relevant for this ticket.)

Riak KV has no conditional read requests for CRDTs:

PB read API has no conditional read - see KV doc and Erlang client code;
HTTP read API has no conditional read.

Proposal
I propose to enhance the Riak KV HTTP API wrt CRDT with conditional read requests.
I put together an initial untested rough patch and the code seems simple - the problem I have is getting the full understanding of the impact of the change. The impact I see is:

(A) Clients issuing GET or HEAD requests to a CRDT will get a new header ETag. This shall be acceptable;
(B) Unknown impact on HTTP/webmachine behaviour different from GET/HEAD requests;
(C) Unclear which tests would be needed for accepting this change.

For (B) it appears the change I made shall not impact anything else except GET/HEAD requests.

The patch if no Etag can be generated returns undefined that is the same as the default return value;
Webmachine appears not to make distinction on whether the callback generate_etag is unexported vs. is exported returning undefined - apart from log messages.
I based my investigation on Riak KV 2.2.0 that has webmachine 1.10.8-basho1 (checked via chain or rebar.config fails, terminating in https://github.com/basho/riak_api/blob/2.1.5/rebar.config#L6). In webmachine, the string generate_etag is only in webmachine_resource and webmachine_decision_core.

Not sure why DIalyzer fails but looks unrelated to this PR. Maybe you shall make PLT target as PHONY?


corrected Fusl server addresses

Current server adresses (2.opennic-fvz-rec-) are incorrect. dnscrypt-proxy does not accept them ("Unable to retrieve server certificates"). Correct addresses from http://meo.ws/dnsrec.php looks like 2.fvz-rec- without opennic- prefix

Merged, thanks!


nonce issues when using Ganache network

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Using lsp-factory with ganache test network causes nonce issues when deploying UniversalProfiles. Transaction nonces seem to be out by 2

Other information

the tx doesn't have the correct nonce. account has nonce of: 8 tx has nonce of: 10
Similar problems occur when using a local hardhart network, though turning automining off fixes it. Possibly related. Problem persists when using ganache whether automining is on or off

I'll close as this is 2y and we changed a lot of things in between. If you still have the issue please reopen.


Fix --dependency arg bug in create_adapter_plugin

Fix bug in create_adapter_plugin when a dependency is not passed in.
resolves #2507

Description

Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot check

Oh, I'm sorry - I just noticed that the changelog wasn't updated on this PR. Can you please add an entry to CHANGELOG.md under Contributors: with your github username that links to this PR? We want to make sure to credit you in the release notes!

@beckjake can do, within the CHANGELOG.md under which version number should I add that info?

@scarrucciu Please place it at the top, under dbt 0.18.0 (Release TBD). There should be an existing contributors list there, just follow that format. You can also feel free to add this to a new ### Fixes section for this release, following the existing pattern below.


[Bug]: Build error: Cannot find module './i18n/en.json'

Current Behavior
I got an error when I try to build my Angular app using @web3-onboard/core :
Error: node_modules/@web3-onboard/core/dist/types.d.ts:7:21 - error TS2307: Cannot find module './i18n/en.json' or its corresponding type declarations.
http://joxi.ru/V2VkjdGFBdeygA
As we can see we have no this file in node_module folder http://joxi.ru/KAxRabgHVZQ7Pm
At the same time we have it in repo:
http://joxi.ru/1A5eVXRI4DWVXA
Expected Behavior
Expect to have no errors with the build
Steps To Reproduce

Install core wallets versions of app
Start up a local server and you will see the error

Onboard Version
2.1.0
Node Version
16.13.2
What browsers are you seeing the problem on?
Chrome
Relevant log output
Error: node_modules/@web3-onboard/core/dist/types.d.ts:7:21 - error TS2307: Cannot find module './i18n/en.json' or its corresponding type declarations.

import type en from './i18n/en.json';
                      ~~~~~~~~~~~~~~~~
✖ Failed to compile.

Anything else?
No response

Hey @bisio2332 what bundler are you using? Could you try deleting your node_modules and re-running yarn / npm i? I have not seen this build error before and cannot replicate locally.

Hello @aaronbarnardsound , thank you for your answer.
Yea I deleted my node_modules and re-ran it but it did not help. I tried all versions of@web3-onboard/core library but I faced the same result.
I am using Angular CLI to build the app.
You can easily create a clear Angular project with the latest version.
Add @web3-onboard/core and after that try to do ng serve.
For a clear Angular project, it does not work for me as well.
Thank you

Hey @bisio2332 does adding the following to the compilerOptions parameter in your tsconfig.json file fix it?
{
  "compilerOptions": {
    "resolveJsonModule": true,
    "esModuleInterop": true
  }
}

Hi @aaronbarnardsound I tried your solution with my project and with the clear Angular Project, but unfortunately, it didn’t help me 😔. Should I give more information for you?
Thanks

Does it still needed to use the --resolveJsonModule? I'm running into the same problem than @aaronbarnardsound, with that resolveJsonModule set to true, it works. Is it necessary or I'm running into sth?


Fix Pyspark Wrapper Generation

-fix a problem where internal wrappers could not be serialized
-fix a problem where byte array params were not transferred to python properly

@mhamilton723,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Because we dont really have python tests that are full enough to catch these things. The fuzzing architecture and new pytest architecture will hopefully catch alot of these and give us a very robust python functionality check


pageserver: terminate on local I/O errors

Problem
In general, failures to read or write to local disk are fatal: only a few cases are retryable (notably ENOSPC), whereas EIO, EROFS, EACCESS etc indicate either a configuration issue of the node, or unhealthy hardware that we shouldn't continue to use.
Summary of changes

Add is_fatal_io_error and on_fatal_io_error functions, to decide if a particular std::io::Error should terminate the process, and to terminate the process respectively.
Add virtual_file::Error with a built-in behaviour to terminate the process on fatal errors.  By using this return type, functions can reliably ensure that they will encounter the check on all ? points, without having to carefully remember to call a function to maybe-terminate.  All users of VirtualFile inherit the terminate-on-fatal-errors behavior.
Add explicit calls into on_fatal_io_error in deletion queue locations that use tokio::fs I/O.

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Personally I also prefer an Error type over having nested Results. We can however avoid the "value creation is error handling" issue by:

changing the Error type from wrapping an std::io::Error to wrapping an anyhow::Error
in is_fatal_io_error or the code that calls it, trying to downcast the anyhow::Error to an std::io::Error, if it doesn't work it returns non-fatal, and if it works it does the current check.
changing all the places that ever do IO (or transitively call functions that do IO) to our Error type. We can actually change all places that return anyhow::Error right now to use Error
do the checking at the top level of the call hierarchy, where we right now just print the errors I suppose.

I think we should do the steps up to the last one one way or another, simply to ensure that no IO operation falls through the cracks. But the last step would allow us to move the checking at value creation to checking at the top of the call hierarchy.

Closing in favor of #5651


add a stop method to the consumer class; address #57

This can be used to signal the consumer to stop if it is running in a different thread

thank you both. I have made the changes, please have a look when you can.

I'll also mention that with this branch, I have now tested gwcelery termination on several occasions over the last 20 hours, and it has closed the connection and stopped the listener (https://git.ligo.org/emfollow/gwcelery/-/merge_requests/905/diffs#b03e78e6b901a90969bee266a4e115cf50cb5d89_119_92). Condor_rm removes all jobs successfully.


feat: allow JSON mode

Resolve google-gemini-php/client#8
Use v1beta as default base URL to support the feature

With models/gemini-pro, API returns Json mode is not enabled for models/gemini-pro
Working on models/gemini-1.5-pro

This PR will make the library completely dependent on the beta. A separate branch can be created for beta and proceed from there. I am therefore closing this PR.

Hi @jnlin @camilleislasse
This feature has been added to the beta version. You can use it by updating the version of the package in composer.json to the version I specified.
https://packagist.org/packages/google-gemini-php/client#1.0.0-beta


Basic usage of ObjectiveCBridgeable protocol on Linux

Add extensions to Bridgeable types to define
their conformance to the ObjectiveCBridgeable
protocol in terms of the existing bridging
support.  Since the compiler understands the
semantics of ObjectiveCBridgeable this allows
'as' conversions to be performed to/from various
NS types on platforms without ObjectiveC.

Relies on swift pull request https://github.com/apple/swift/pull/1994 which makes the protocol available.

Thanks Dave. Let's hold on to this and make sure the other PR goes through.

I guess the other followup part is to test via removing the calls to .bridge() and replace them with as conversions. If that works then we should see if the implicit conversions will work too (giving us source compatibility with struct <-> object conversion)

Agreed.  I can start going through the tests.  I can structure either as a separate pull request or as an addendum to this one.  Either is fine with me.

I think it may be best to have them separate just in case we get compiler crashes from the as conversion

Test suite update in #310

rebased to master as of 4/25; updated for Swift change for first argument labels; squashed to single commit.

I'm going to follow up on this with some swift compiler engineers and get back to you on it. The recent back and forth with implicit bridging going away has confused things...

ok, thanks Tony.   I'm happy with any outcome.  If we need this, I will rebase it.  If we don't need it after all, no problem...I learned a few things doing it.

not needed; closing.


SP5: String measurement ignores leading and trailing whitespace

Issue: (Text display is wrong when string to display contains spaces at start or at end.)
ScottPlot Version: (5.0.17)
Code Sample: Based on https://scottplot.net/cookbook/5.0/Text/Formatting/ sample code.
// Picture left side
var text = myPlot.Add.Text("Hello, World", 42, 69);

// Picture center
// 3 leading space characters
var text = myPlot.Add.Text("   Hello, World", 42, 69);

// Picture  right side
// 3 trailing space characters
var text = myPlot.Add.Text("Hello, World   ", 42, 69);

According to this :  https://learn.microsoft.com/en-us/dotnet/api/skiasharp.skpaint.measuretext?view=skiasharp-2.88#skiasharp-skpaint-measuretext(system-byte()-skiasharp-skrect@)
paint.MeasureText(...) function returns the width of the text, taking into account all characters including leading and trailing whitespace.
public class Label
{
...
    public PixelSize Measure(SKPaint paint)
    {
        ApplyTextPaint(paint);
        SKRect textBounds = new();
        float textWidth = paint.MeasureText(Text, ref textBounds);

        // textWidth is not always greater than textBounds.Width (depends of the font name).
        return new PixelSize(Math.Max(textBounds.Width, textWidth), textBounds.Height);
    }
...

It seems to work...

@devbotas @lindpatr you are close to the solution ;)
According to this post on StackOverflow, the SKPaint.MeasureText(string str, ref SKRect rect) works as follow:

the returned value is the length of the text with leading and trailing white space
rect.Left contains the width of leading white space
rect.width contains the length of the text without leading and trailing white space

So to resume, this should work:
public PixelSize Measure(SKPaint paint)
{
        ApplyTextPaint(paint);
        SKRect textBounds = new();
        float textWidth = paint.MeasureText(Text, ref textBounds);

        return new PixelSize(textWidth, textBounds.Height);
}

resolved in #3268


Update messaging-policies-in-teams.md

added a disclaimer that read receipts are not eDiscoverable

@LolaJacobsen please review. Thanks!


Pass PG into checkpoint load and load rng with state_dict

What does this PR do?

Pass process group into load call (which should be faster)
Load RNG in one call to avoid duplicate reads

Tests?

Tests?

I think existing sharded checkpoints cover this. We unfortunately cannot test HSDP with 2 GPUs, so I've queued manual tests I'll DM you.


resnet50 torch fails to vectorize and is 20x slower than TF versions

What happened?
wget https://storage.googleapis.com/shark_tank/latest/resnet50_torch/resnet50_torch.mlir
Steps to reproduce your issue
Will add the compile / benchmark commands shortly.
What component(s) does this issue relate to?
No response
Version information
No response
Additional context
No response

We have a temp workaround in SHARK-Runtime under --iree-flow-enable-conv-nchw-to-nhwc-transform

I think this can be considered done. And we can open new issues as required.


Feature request: Vue.js component

I could work on this issue if it's not taken yet.

Thanks @mat-sz , please do! 👍


Insert event into multiple calendars

Inserting an event, it’d be great if it could be added to several calendars, by for example passing a comma separated list of the calendar indexes.

The ReadMe or Wiki do not contain details on how to add an event to the calendar. Does it support it? Just curious, would love to know

@nicolassilvar Just press i.
@paulmenzel Thanks for feature request, but I'm not sure how many people want the feature...


Error message related to robertohuertasm.vscode-icons

Last version of vscode-icons 8.7.0 by VSCode Icons Team is installed but still get the following error message :
Cannot activate the 'GML Support' extension because it depends on an unknown 'robertohuertasm.vscode-icons' extension .

Because the extension has been changed to  vscode-icons-team.vscode-icons , I will fix it tomorrow.


wglMakeCurrent() fails randomly

wglMakeCurrent() fails randomly
This only happens on one of my team's machines, and is somewhat intermittent.
After running for a short time (a few seconds to a minute), we get this panic message:
class utils::PostconditionPanic in void __cdecl filament::PlatformWGL::makeCurrent(struct filament::backend::Platform::SwapChain *,struct filament::backend::Platform::SwapChain *) noexcept:205 in file D:\a\filament\filament\filament\backend\src\opengl\PlatformWGL.cpp
reason: wglMakeCurrent() failed. hdc = FFFFFFFF84010DCE

We can reliably reproduce this with nothing in the scene, which makes me wonder if there is a timing/race-condition issue.  Or, perhaps wglMakeCurrent is non-reentrant, but is somehow getting called on different threads.
The scene consists of: one directional light and an IBL light.
Here is the call stack:
     ucrtbased.dll!00007ffe1c497c75()
     ucrtbased.dll!00007ffe1c497e13()
     ucrtbased.dll!00007ffe1c4ae01d()
     Sketch.Render.Win10.dll!utils::TPanic<class utils::PostconditionPanic>::panic(char const *,char const *,int,char const *,...)
     Sketch.Render.Win10.dll!filament::PlatformWGL::makeCurrent(struct filament::backend::Platform::SwapChain *,struct filament::backend::Platform::SwapChain *)
     Sketch.Render.Win10.dll!filament::OpenGLDriver::makeCurrent(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>)
     Sketch.Render.Win10.dll!filament::backend::invoke<class filament::OpenGLDriver,void ,class filament::OpenGLDriver &,struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain> >(void ( filament::OpenGLDriver::*)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,struct filament::backend::Handle<struct filament::backend::HwSwapChain> &&,struct filament::backend::Handle<struct filament::backend::HwSwapChain> &&)
     Sketch.Render.Win10.dll!filament::backend::trampoline<void ( filament::OpenGLDriver::*)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,class std::tuple<struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain> >,0,1>(void ( filament::OpenGLDriver::*&&)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,class std::tuple<struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain> > &&,struct std::integer_sequence<unsigned __int64,0,1>)
     Sketch.Render.Win10.dll!filament::backend::apply<void ( filament::OpenGLDriver::*)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,class std::tuple<struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain> > >(void ( filament::OpenGLDriver::*&&)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,class std::tuple<struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain> > &&)
     Sketch.Render.Win10.dll!filament::backend::CommandType<void ( filament::backend::Driver::*)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>)>::Command<&filament::backend::Driver::makeCurrent(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>)>::execute<void ( filament::OpenGLDriver::*)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &>(void ( filament::OpenGLDriver::*&&)(struct filament::backend::Handle<struct filament::backend::HwSwapChain>,struct filament::backend::Handle<struct filament::backend::HwSwapChain>),class filament::OpenGLDriver &,class filament::backend::CommandBase *,__int64 *)
     Sketch.Render.Win10.dll!filament::backend::ConcreteDispatcher<class filament::OpenGLDriver>::makeCurrent(class filament::backend::Driver &,class filament::backend::CommandBase *,__int64 *)
     Sketch.Render.Win10.dll!filament::backend::CommandBase::execute(class filament::backend::Driver &)
     Sketch.Render.Win10.dll!filament::backend::CustomCommand::~CustomCommand(void)
     Sketch.Render.Win10.dll!filament::backend::CommandStream::queueCommand(class std::function<void >)
     Sketch.Render.Win10.dll!filament::backend::CommandStream::queueCommand(class std::function<void >)
     Sketch.Render.Win10.dll!filament::backend::CommandStream::queueCommand(class std::function<void >)
     Sketch.Render.Win10.dll!filament::backend::CustomCommand::`scalar deleting destructor'(unsigned int)
     Sketch.Render.Win10.dll!std::_Func_class<void>::operator()(void)
     Sketch.Render.Win10.dll!filament::backend::Driver::execute(class std::function<void >)
     Sketch.Render.Win10.dll!filament::backend::CommandStream::execute(void *)
     Sketch.Render.Win10.dll!filament::details::FEngine::execute(void)
     Sketch.Render.Win10.dll!filament::details::FEngine::loop(void)
     Sketch.Render.Win10.dll!std::_Invoker_pmf_pointer::_Call<int ( filament::details::FEngine::*)(void),class filament::details::FEngine *>(int ( filament::details::FEngine::*)(void),class filament::details::FEngine * &&)
     Sketch.Render.Win10.dll!std::invoke<int ( filament::details::FEngine::*)(void),class filament::details::FEngine *>(int ( filament::details::FEngine::*&&)(void),class filament::details::FEngine * &&)
     Sketch.Render.Win10.dll!std::thread::_Invoke<class std::tuple<int ( filament::details::FEngine::*)(void),class filament::details::FEngine *>,0,1>(void *)
     ucrtbased.dll!00007ffe1c4b542c()
     kernel32.dll!00007ffebe874034()
     ntdll.dll!00007ffec0b13691()

Desktop:

OS: Windows 10
GPU: NVIDIA GTX 1050
Backend: OpenGL

Which version of Filament are you building against? 1.4.3?

Yes.  I should have specified: 1.4.3

I'm not able to reproduce but I'll keep trying. Are you using any particular windowing library?

We are using Telerik for our windows controls.
We are going to test using material_sandbox by building and running that on the machine that is seeing the problem.  Maybe we can verify the behavior that way and eliminate our app from the process.

I have done quite a bit of testing recently and found that the current GL driver does not work for shared GL contexts. See #1921 for a bit more info on this.  I did create this test case that should compile directly by following the steps described in the readme: https://github.com/roxlu/windows-opengl-context  It might be worth to see if these tests work to find out if it might be related to threading.  My current finding is that you have to create the GL contexts on one thread and after that you can share them and use them in different threads.
I've created an experimental branch that allows you to create a GL context and pass that to Filament:
https://github.com/roxlu/filament/blob/rox/feature-win-shared-gl-context/filament/backend/src/opengl/PlatformWGL.cpp#L73-L108

@BStringhamVRSK let us know if you can reproduce with material_sandbox. Does your app use a shared GL context?

Our test with material_sandbox did not exhibit the problem.
As far as I know, we are not using a shared GL context, but I will have to do some research to determine if someone else might be creating one.  I will let you know what I discover.  It might be a couple of days before I can get to that.
@roxlu Thanks for the information.

obsolete/no more action needed


Adding '--webpack' option to use existing Webpack configuration

If you already have a Webpack configuration file you use with Storybook, you can use it in StoryShots as well. Simply run StoryShots like this:
storyshots --webpack

StoryShots will look for the webpack configuration file (webpack.config.js) in the config dir (provided by --config-dir), and run Webpack to load the stories.

Thanks. This is an approach we did consider to manage webpack. But we wanted avoid actually running webpack because running webpack took a long time for many projects. And we wanted storyshots to be fast so users can run it frequantly like other tests. (like for each file save).
See #33 for the way we handled require.context webpack option.
Now we are making storyshots to run directly inside jest. See #61. Since this saves the trouble of managing webpack and more people seem to use jest we would like to go forward with that approach.

Still, there are lot of Webpack functionality which are hardly solved when using Jest: aliases, loaders, plugins, etc. I believe Webpack should improve to decouple most of it's bundling logic so that other projects could rely on Webpack parts - resolving logic, for instance - and so allow other projects to make use of it in an execution flow, as well as in a bundling flow. Until then, I think it's prudent to allow usage of Webpack configs.
Ps.: this pull-request does not currently work for my webpack config... I'll try and figure it out why.

Thanks for the PR @benzaita
@lucasconstantino yep I can see the point of this PR for sure. It's has a pretty good value.
But for the maintenance purpose, we've moved to the direction on not to publish a CLI tool.
That's because we might have to implement a lot of features Jest already does.
So, with 3.0 we simply allow to use StoryShots inside Jest.
I think we might can have a separate tool for this PR in a different repo.


[terra-status-view] Remove opt object and add proptype check

Summary
Removes Opts object from status view component, and exports status view variants directly. See #2178. Jest tests updated to reflect variant access changes.
Closes #2178.

@emilyrohrbough good point. Maybe we should hold off on merging and bundle with other major changes, when they come up?


How to use one gpu on a pc training and prediction?

Thx!

set nproc_per_node=1 and local_world_size=1


Update MSTest.Test* packages from 3.6.4 to 3.7.0, follow best practices

Dependabot tried to update MSTest.TestFramework from 3.6.4 to 3.7.0 in #839, and MSTest.TestAdapter in #841. These PR's both failed, as the 2 pieces need to move together for the tests to work correctly. In addition, the newer version of MSTest.TestFramework adds several new warnings, and since our builds treat warnings as errors, the build breaks.
This PR touches a lot of files, but since these packages are all test-specific, so are the code changes. It was done as a series of commits, and reviewing each commit in sequence will probably simplify the review process. Commits are as follows:

Commit
Description/Coment

1
Unchanged from #839

2
Suppress new warnings

3
Unchanged from #841 -- this allowed the tests to run

4
Added a suppression that was flagged once both packages were updated

5
MSTEST0005 We were using TestContext improperly, fix it

6
MSTEST0006 ExpectedException is no longer considered a best practice, so I changed them to ThrowsException or ThrowsExceptionAsync. Most of these changes were tool-driven, but some were manual and exposed some dead code in the unit tests

7
MSTEST0017 Assert.AreEqual wants the expected parameter first--there were many places in the code where we had the test parameter first. These changes were largely tool-driven

8
MSTEST0024 was fixed by 5, so the suppression can go away

9
MSTEST0034 This just adds a parameter to an attribute decoration

10
MSTEST0037 Assert.AreEqual, Assert.IsNull, and Assert.IsNotNull are all preferred over Assert.IsTrue becuase they are more descriptive. These changes were largely tool-driven.

11
I noticed a few more places where the parameters of Assert.AreEqual were in the wrong order, but the analyzer failed to catch the error. These changes were manual.

12
MSTEST0026 Null propagation in asserts is discouraged

13
MSTEST0032 Non-nullable types don't need to be asserted as non-null. Note that this undoes some of the changes from 12

14
JSON002 is no longer showing up as an error, so I removed the suppression

15
Remove a couple of using blocks that were accidentally added along the way

16
Restore a check was dropped in 6

Note: When running from inside Visual Studio, the net472 projects get skipped. They run correctly from the command line, so any potential regressions should get caught in the pipelines. The net80 versions of the tests work as expected in both Visual Studio and from the command line. I'm working on opening an issue in the repo that produces the MSTest.* packages to track that.

Codecov Report
Attention: Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.

Project coverage is 44.49%. Comparing base (9ef64aa) to head (2d93c2d).

Files with missing lines
Patch %
Lines

...bom.Api.Tests/PackageDetails/RubyGemsUtilsTests.cs
0.00%
16 Missing :warning:

...s/Config/ConfigurationBuilderTestsForValidation.cs
0.00%
14 Missing :warning:

...s/Config/ConfigurationBuilderTestsForGeneration.cs
0.00%
13 Missing :warning:

...bom.Api.Tests/Executors/FileListEnumeratorTests.cs
0.00%
8 Missing :warning:

...bom.Api.Tests/Entities/FileValidationResultTest.cs
0.00%
5 Missing :warning:

...t.Sbom.Api.Tests/Executors/DirectoryWalkerTests.cs
0.00%
5 Missing :warning:

...ft.Sbom.Api.Tests/Executors/PackagesWalkerTests.cs
0.00%
5 Missing :warning:

.../Executors/ComponentToPackageInfoConverterTests.cs
0.00%
4 Missing :warning:

...Utils/ComponentDetectionCliArgumentBuilderTests.cs
0.00%
4 Missing :warning:

...Tests/Utils/ComponentDetectorCachedExecutorTest.cs
0.00%
4 Missing :warning:

... and 23 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   46.47%   44.49%   -1.99%
==========================================
  Files         355      355
  Lines       14151    14146       -5
  Branches     1163     1161       -2
==========================================
- Hits         6577     6294     -283
- Misses       7026     7312     +286
+ Partials      548      540       -8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How to show Status information in Nagdash?

Hi there,
If my brain isn't fooling me, nagdash showed the "Status Information" returned by the plugin in the overview in a prvious version
if [ "$rdp_run" -eq "0" ]; then
        echo "OK: NO Session running"
        exit $STATE_OK
fi
if [ "$rdp_run" -gt "0" ]; then
        echo "WARNING: RDP Session running"
        exit $STATE_WARNING
fi

So I could see "WARNING: RDP Session running" in the Servicetab (in yellow)  but at the momentI only see the Service name, which I defined in the host-config-file.
It's logical to the see the Servicename in the Service column ;), but I realy like to see the "Status Information" Data somehow
Hope you can give me a hint
-dbv-

You can hover over the rows to see the full status output :) Most people have too many services to show the full output all the time. Maybe this could be a configuration option.

(facepalm) :) Ok, since I don't have a Mouse on my Monitoring-PC is there any chance to make it visible permanently? I tried to crawl through the files to find a line where I can change that but no luck so far....but Web-Speech skills aren'T that great...as you can see ;)