[SPARK-30958][SQL] do not set default era for DateTimeFormatter

What changes were proposed in this pull request?

We should fill the default era manually.
Why are the changes needed?

By default we use "uuuu" as the year pattern, which indicates the era already. If we set a default era, it can get conflicted and fail the parsing.
Does this PR introduce any user-facing change?

yea, now spark can parse date/timestamp with negative year via the "yyyy" pattern, which will be converted to "uuuu" under the hood.
How was this patch tested?

new tests

cc @MaxGekk @HyukjinKwon

Test build #118968 has started for PR 27707 at commit 0d08ee9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23716/
Test PASSed.

Test build #118968 has finished for PR 27707 at commit 0d08ee9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118968/
Test FAILed.

Test build #118986 has started for PR 27707 at commit 866552c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23734/
Test PASSed.

Test build #118986 has finished for PR 27707 at commit 866552c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118986/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23755/
Test PASSed.

Test build #119008 has started for PR 27707 at commit e26ffc0.

Test build #119008 has finished for PR 27707 at commit e26ffc0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119008/
Test FAILed.

@cloud-fan, can you rebase? seems okay.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24483/
Test PASSed.

Test build #119754 has started for PR 27707 at commit 16ba424.

Test build #119755 has started for PR 27707 at commit 27e272c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24484/
Test PASSed.

Test build #119755 has finished for PR 27707 at commit 27e272c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119755/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24487/
Test PASSed.

Test build #119758 has started for PR 27707 at commit 27e272c.

Test build #119754 has finished for PR 27707 at commit 16ba424.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119754/
Test FAILed.

Test build #119760 has started for PR 27707 at commit 27345cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24489/
Test PASSed.

Test build #119758 has finished for PR 27707 at commit 27e272c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119758/
Test FAILed.

Test build #119760 has finished for PR 27707 at commit 27345cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119760/
Test PASSed.

Merged to master and branch-3.0.


Fixes/gh issue 499

Restructure HTML emails for more robust display

@cleargif Needs rebasing too

Closing. Feature will be added in a new PR.

...oops.
This needs to be rebased and reviewed.


fix: black placeholder image

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3910
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

@KngZhi not sure what happened here, but please, make sure our QA guild tests your PRs as well (don't remove them from reviewers)😆

pay 20 usd

😍 Perfect, I’ve sent the payout
💵 $20 @ 49.41 USD/KSM ~ 0.405 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x6186ba82350729e4bec5071ae88d6ddbc07435da75242c0e9c4dc1ddc792ab24
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@KngZhi not sure what happened here, but please, make sure our QA guild tests your PRs as well (don't remove them from reviewers)😆

don't know why that happen, just hit re-request review button, and it removes Lu 😂


Changes for Node.js UT automation

Description
I am making some changes to the Node.js UT scripts as well as the .sh script that runs them. These changes are necessary to integrate the Node.js UT scripts into the CI framework.
@rameshthoomu please take a look.
Motivation and Context
In order to integrated the existing Node.js UT into the CI framework I am making the following changes:
(1) Modifying the existing Node.js UT scrips to report the first failure and exit. We do not want to continue executing the test script, as typically, the operations that follow are dependent on the ones that come before them. For example, if deploy fails there is no point in waiting for invoke/query to finish. Or if enrollment of the test user with the membership service fails, there is no sense to continue the test as all subsequent requests will fail.
(2) Modifying the existing .sh script that is triggered with the make node-sdk-unit-tests so it returns a 1 whenever any of the Node scripts fail. This allows the CI scripts to use that output.
How Has This Been Tested?
I have tested this with the existing UTs. I am not introducing any new functionality.
Checklist:

[x] I have added a Signed-off-by.
[x] I have either added documentation to cover my changes or this change requires no new documentation.
[x] I have either added unit tests to cover my changes or this change requires no new tests.
[x] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Anna D Derbakova<EMAIL_ADDRESS>

@angrbrd : Observed above commit changes are working as expected. Commented below section to see a failure in chain-test unit test cases. After first failure triggered,  chain unit tests stopped and existed without executing other test cases in the chain test suite.
Tested this only in Travis.
sdk/node/test/unit/chain-tests.js
//  if (mode === 'dev') {
      // Name required for deploy in development mode
//      deployRequest.chaincodeName = testChaincodeName;
//  } else {
      // Path (under $GOPATH) required for deploy in network mode
//      deployRequest.chaincodePath = testChaincodePath;
//  }

Below is the Travis log:
not ok 11 Failed to deploy chaincode: request={"fcn":"init","args":["a","100","b","200"]}, error={"error":{},"msg":"Error: missing chaincodeName in DeployRequest"}
 ---
   operator: fail
   at: TransactionContext.<anonymous> (/home/travis/gopath/src/github.com/hyperledger/fabric/sdk/node/test/unit/chain-tests.js:365:7)
 ...
ERROR running chain-tests!
killing PID 18380 running chaincode_example02 ...
END running chain-tests
BEGIN running asset-mgmt tests ...

Travis Log file:
https://travis-ci.org/rameshthoomu/fabric/builds/145119846.

LGTM


Get TAMU UI working and dockerize

Run TAMU frontend locally

[x] Run the UI
[x] Add to docker compose

I'm closing this issue since we are rearranging projects. We'll work on creating docker files for those.


fix: add styles.css/package.json as an alias for Jest

Some older build/test tools have issues when importing RainbowKit styles due to lack of support for the exports field, which we previously used to publicly alias @rainbow-me/rainbowkit/dist/index.css as @rainbow-me/rainbowkit/styles.css.
To fix this, we now copy the CSS file into the root of the package as part of our build process so that it can be imported without an alias.
Note that I've left the original dist/index.css file there since some consumers were importing this file directly and I don't want to break them.
Related issue: https://github.com/rainbow-me/rainbowkit/issues/461
Fixes: PAR-18

I just pushed an update based on a genius idea by @jxom that simplifies things a lot.
We no longer need to copy files around—instead, there's a styles.css directory that contains a package.json file with a main field pointed at "../dist/index.css". This way Jest resolves the /styles.css import to this package.json file, and is then redirected to the generated CSS output. I've tested this in Jest and it works. Really clever.

daaamnnnn, i love that!


TypeError: Path must be a string. Received undefined

Running the latest phonegap CLI on latest node on OS X, I see this in my server logs:
TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.join (path.js:1213:7)
    at Object.handle (/usr/local/lib/node_modules/phonegap/node_modules/connect-phonegap/lib/middleware/cordova/cordova_plugins.js:18:33)
    at next (/usr/local/lib/node_modules/phonegap/node_modules/connect/lib/proto.js:193:15)
    at Object.handle (/usr/local/lib/node_modules/phonegap/node_modules/connect-phonegap/lib/middleware/cordova/cordova.js:33:13)
    at next (/usr/local/lib/node_modules/phonegap/node_modules/connect/lib/proto.js:193:15)
    at resume (/usr/local/lib/node_modules/phonegap/node_modules/connect/lib/middleware/static.js:65:7)
    at SendStream.error (/usr/local/lib/node_modules/phonegap/node_modules/connect/lib/middleware/static.js:80:37)
    at emitOne (events.js:96:13)
    at SendStream.emit (events.js:188:7)

$ phonegap -v
6.3.0

$ node -v
v6.4.0

Hi @zeke,
I have noticed this every once in awhile but haven't found the proper repro steps. Can you give a few details as to how you came about this error?

I'm on OS X, node 6.4.0, phonegap 6.3.0
I installed the PhoneGap desktop app, created a new project with it, ran the server from the desktop app, tried to connect with the iOS app, failed a few times, then decided to try running the server with the CLI instead. That didn't work either, but quitting the iOS app and restarting it seemed to do the trick.
I made no modifications to the generated project before running the server.
Hope that helps. Let me know if you need more info.

I can reproduce this every time with the latest phonegap-cli, as long as the project you are creating does not include plugins. Thus why the stack trace points to cordova-plugins.js middleware causing this error:
Object.handle (/usr/local/lib/node_modules/phonegap/node_modules/connect-phonegap/lib/middleware/cordova/cordova_plugins.js:18:33)

Repro steps - the key is to provide the blank template (so you get no cordova plugins):
$ phonegap create pathtest --template blank
$ cd pathtest
$ phonegap -d serve
$ # wait until the serve is listening, then load up the URL in your browser


upgrade commons-beanutils

Issue #, if available:
https://github.com/opendistro-for-elasticsearch/k-NN/issues/269
Description of changes:
commons-beanutils:commons-beanutils:1.9.3 is coming from com.puppycrawl.tools:checkstyle:8.20. Added  'com.puppycrawl.tools:checkstyle:8.24' dependency. Also, added checkstyle.xml
Post update
./gradlew dependencies | grep commons-beanutils
     +--- commons-beanutils:commons-beanutils:1.9.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Why do we need to add checkstyle.xml to upgrade commons-beanutils?

Was referring Performance Analyzer plugin https://github.com/opendistro-for-elasticsearch/performance-analyzer/pull/248. With out adding the xml file, checkstyle fails at compilation.

Why do we need to add checkstyle.xml to upgrade commons-beanutils?

Was referring Performance Analyzer plugin https://github.com/opendistro-for-elasticsearch/performance-analyzer/pull/248. With out adding the xml file, checkstyle fails at compilation.


SA generated by operator-sdk does not contain the automountServiceAccountToken required for CNF cert

Bug Report
Some RH Telco partners utilize operator-sdk to create operators for later CNF certification. CNF certification requires that operator service accounts explicitly disable API credential automounting as a recommended practice. The problem is that service accounts created by operator-sdk lack the automountServiceAccountToken: false setting, causing them to fail this requirement.
{"ObjectType":"Pod","ObjectFieldsKeys":
["Reason For Non Compliance","Namespace","Pod Name"],
"ObjectFieldsValues":
["serviceaccount XXX-YYY-agents:XXX-lYYY-agents-controller-manager is not configured
with automountServiceAccountToken set to false,
impacting pod XXX-YYY-agents-controller-manager-86d746fbdd-fkg7b",
"XXX-YYY-agents","XXX-YYY-agents-controller-manager-86d746fbdd-fkg7b"]}

In simple terms, operator-sdk doesn't generate CNF-compliant operators.
What did you do?
I initiated the helm-operator and verified that the Service Account does not contain automountServiceAccountToken: false as follows:
$ cd nginx-operator/
$ operator-sdk init --plugins helm --domain example.com --group demo --version v1alpha1 --kind Nginx

$ cat config/rbac/service_account.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  labels:
    app.kubernetes.io/name: serviceaccount
    app.kubernetes.io/instance: controller-manager-sa
    app.kubernetes.io/component: rbac
    app.kubernetes.io/created-by: nginx-operator
    app.kubernetes.io/part-of: nginx-operator
    app.kubernetes.io/managed-by: kustomize
  name: controller-manager
  namespace: system

What did you expect to see?
I expected the automountServiceAccountToken: false line to be automatically added during the generation of the operator's SA by operator-sdk, like this:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: build-robot
automountServiceAccountToken: false
...

What did you see instead? Under which circumstances?
Instead, we have an SA without the automountServiceAccountToken: false line, and our partners must manually add this line to all operators generated with operator-sdk, in order to pass the CNF certification.
Environment
Operator type:
/language go
/language ansible
/language helm
Kubernetes cluster type:
$ operator-sdk version
1.31.0
Possible Solution
Adding this line to the SA template should be a straightforward solution:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: build-robot
automountServiceAccountToken: false
...

/label good-first-issue

@tkrishtop If this is added to config/rbac/service_account.yaml does the bundled SA look correct and get applied correctly when the operator is installed in a cluster? I would think there is more work then just updating the SA.

To shed a little more light on this, the SA that is in the config/rbac directory is never created in the bundle folder, the below code excludes it:
https://github.com/operator-framework/operator-sdk/blob/master/internal/generate/collector/clusterserviceversion.go#L126
If the above code was changed to include all ServiceAccounts in the bundle and the operator developer added kustomize to update the service account properly, operator-framework-api would then throw an error saying this SA is not allowed in the bundle, see below:
https://github.com/operator-framework/api/blob/master/pkg/validation/internal/bundle.go#L63-L70
I'm not sure why this SA is not included in the bundle, probably because OLM is creating this SA based on the info in the CSV this is just speculation on my part. This means that operator developers can't customize the SA for their controller. Unless there is some other approach that they are supposed to follow, if so we should document the proper approach, as all we have now is --extra-service-account flag, but that is for another use case entirely.


Writing to the v-model for smart-select component does not effect the component

Framework7 version: 3.3.2
Vue.js version: 2.5.17
Platform and Target: Android

Describe the bug
When I set the v-model of the smart-select component, and I change that variable to an array within my javascript, the list item does not show these items as selected. However, I know it is working because when I then open the smart-select, I can see that those items that I put in the array for the v-model variable are checked, it's just that they are not showing as selected inside the corresponding list-item button that opens the smart select.
To Reproduce
Steps to reproduce the behavior:

Create smart-select component with a v-model, and the options '1', '2', '3'
In your javascript, set the value of the v-model variable to ['1']
The smart-select component does not show them as selected unless you open it

Expected behavior
I expect the smart-select component to display the items within it's v-model variable as selected, even if those items are set as selected within the javascript and not by the user.
Actual Behavior
They are being selected, but they are not being displayed in the list item for the smart-select as they would if the user had selected them manually.

I can't detect changed on <select> by Vue's v-model. So you need to trigger change event on select after you change it with v-model, like $$('select').trigger('change') or just manually write value text to f7-list-item's after property

Would be good to see JSFiddle with the issue

https://jsfiddle.net/7dk0t52a/

Nice job man. Thanks a million.


C struct member omnicomplete

Problems summary
I'm working with kernel source code. Tested and using deoplete and neoinclude which turned out to be simply amazing for my c code. Exactly what i was looking for - autocomplete across included headers, works just great! Only thing I'm trying to get now is omnicomplete for structure/union members. From what I've seen, people get amazing autocomplete suggestions using deoplete. Sadly I have faild to get it to work so far. While  gives accurate candidates(but takes a lot of time), combination of deoplete + neoinclude + deoplete-clang fails here.
Expected
struct/union members only candidate suggestion with deoplete
Environment Information

OS: Ubuntu 14.04
Neovim version: 0.1.3-dev

minimal init.vim
call plug#begin('~/.vim/plugged')

Plug 'Shougo/deoplete.nvim'

Plug 'Shougo/neoinclude.vim'

Plug 'zchee/deoplete-clang'

call plug#end()

let g:deoplete#enable_at_startup = 1

set path=~/dev/modules/linux/include/
set tags=./tags;/

let g:deoplete#sources#clang#libclang_path = '/usr/lib/llvm-3.4/lib/libclang.so'
let g:deoplete#sources#clang#clang_header = '/usr/lib/llvm-3.4/lib/clang'

let g:deoplete#omni_input_patterns = {}
let g:deoplete#omni_input_patterns.c = '[^.[:digit:] *\t]\%(\.\|->\)\w*'
let g:deoplete#omni_input_patterns.cpp = '[^.[:digit:] *\t]\%(\.\|->\)\w*\|\h\w*::\w*'

The reproduce ways from neovim starting (Required!)
So in this test i have kernel path set do kernel include dir ~/dev/modules/linux/include/ and test.c file in ~/dev/modules.  For test added /foobar/foobar.h to linux include dir. The results I get are shown in screenshot.

#ifndef FOOBAR_H
#define FOOBAR_H
typedef struct foobar_s
{
int foofoo;
foobar_s *next;
int barbar;
}foobar_t;
#endif

Screen shot

@cirnwlf Thanks.

I'm working with kernel source code.

I'm surprised. Thanks for using deoplete-clang :)
I will debug.
Please wait a little.

@cirnwlf This issue caused by deoplete-clang does not parse path dir.
I will fix the behavior.

@cirnwlf Sorry, I misunderstand.
If surrounded by a main(){}, It will works.

Maybe, libclang will return context aware completion words.
deoplete-clang does not touch this behavior.
also, YCM will same behavior :(
WDTY?

Ok, so I have been using my nvim setup for two days now on my computer at work and overall it was working perfectly. On different computer (the one I was initially testing deoplete-clang on) it doesn't work.
I will investigate and let You know.
Great job with your plugins, thanks :)

Please re-open the issue if you reproduce the issue.
I will test it.


Fix Axis linking

Description
Fixes #1718.
It wasn't checked correctly that if Axis A was linked to B, and then Axis B to C, that C should also be linked to A.
Type of change
Delete options that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] Added an entry in NEWS.md (for new features and breaking changes)
[ ] Added or changed relevant sections in the documentation
[x] Added unit tests for new algorithms, conversion methods, etc.
[ ] Added reference image tests for new plotting functions, recipes, visual options, etc.

Compile Times benchmark
Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:
using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

using
create
display
create
display

GLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–

CairoMakie
11.95s (11.82, 12.09) 0.09+-
24.08s (23.76, 24.51) 0.28+-
3.53s (3.46, 3.59) 0.05+-
20.29ms (20.06, 20.70) 0.23+-
24.23ms (23.94, 24.44) 0.20+-

master
11.83s (11.68, 12.03) 0.12+-
24.05s (23.57, 24.40) 0.34+-
3.54s (3.47, 3.60) 0.06+-
20.46ms (20.22, 20.77) 0.21+-
24.28ms (23.99, 24.67) 0.24+-

evaluation
+0.95%, 0.11s invariant (1.06d, 0.07p, 0.11std)
+0.13%, 0.03s invariant (0.10d, 0.85p, 0.31std)
-0.11%, -0.0s invariant (-0.07d, 0.89p, 0.05std)
-0.81%, -0.16ms invariant (-0.75d, 0.18p, 0.22std)
-0.19%, -0.05ms invariant (-0.21d, 0.70p, 0.22std)

WGLMakie
–
–
–
–
–

master
–
–
–
–
–

evaluation
–
–
–
–
–


RFR: Adding checkstyle,findbugs and PMD rules to Blueflood

Import the xml profile into Intellij and run it against your changeset to begin with.
This ruleset may seem intimidating, but at first it's only a way to get thinking about style issues in your code. Though we want our code to obey good style, we do not want to create too much noise.
Suggestions for use (to make it look less scary):

Run this profile using QAPlugs (or any other tool) and fix all issues against your changeset
Run it only against code classes (as opposed to Test)
Try to add only a single commit for style issues (to prevent noise).

Not getting used , closing it for now.


The app is perfect but is missing one big thing:!

Hello, can you add option for favourite stations, its perfect app but favourite stations is something primary. Please it will be great to have favourite option. Regards

As per the readme, we have added favorite stations for clients to this app many times. You can do it yourself, or hire us or someone else to quickly do it for you. The base code stays lean so it can be customized!

Hi, you said that you can do it. How much will cost and how long will take? Thanks
Sent from my iPhone

On Mar 20, 2017, at 02:18, Matthew Fecher<EMAIL_ADDRESS>wrote:
Closed #52.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

About 1 hour if you just wanted something simple. If you wanted with user logins to store the favoritees, it would be much more complex and require a backend system on the web. Our typical rate is $200/hr

Hi. I just need on the app to have option that users will add stations to favorites. Can you do just this I need and how much will cost.?
Sent from my iPhone

On Mar 20, 2017, at 15:32, Matthew Fecher<EMAIL_ADDRESS>wrote:
About 1 hour if you just wanted something simple. If you wanted with user logins to store the favoritees, it would be much more complex and require a backend system on the web. Our typical rate is $200/hr
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

We typically have a $500 minimum for any work. Though, this is very easy. It could be turned around in less than a day. If that is too much, you may just want to have someone on Upwork.com do it for $50-100.


Call configlet subcommand on CI

This changes configlet to pass a subcommand.
For now, we've released a version of configlet which handles both the old command:
configlet path/to/track

as well as the new command:
configlet lint path/to/track

This will let us update all the travis files to include the subcommand before we
release the version of configlet that requires the subcommand.
https://github.com/exercism/configlet/pull/23

Thanks, will merge


Update app/helpers/transloadit_helper.rb

As discussed here: https://github.com/transloadit/rails-sdk/issues/19
Sorry about the separate thread -- didn't know how to add code to an existing thread.

I much prefer the alternatively proposed solution discussed in the thread. Is there any reason you'd want this approach rather than the one we discussed?

Sorry about the two threads. My comments will be in https://github.com/transloadit/rails-sdk/issues/19
I'll leave this open since it has the actual pull request, which you can close once a resolution is reached. Thanks.

I'm with @stouset on this one. Way to obscure. Will close this for now, see discussion on https://github.com/transloadit/rails-sdk/issues/19 for a proposed solution.


[Consistency - Data Model / OLC] OLC identifier and data classes in data model update each other

As a user, I want that the OLC identifier and the respective class in the OLC update each other when one of them is changed. This includes that creating a new data class automatically creates a new empty OLC named after the data class and vice versa.

[x] Creating a new data class creates an empty OLC with the class name as identifier
[x] Creating a new OLC creates a new data class with the identifier of the OLC as name
[x] Updating the name of a data class updates the identifier of the respective OLC
[x] Updating the identifier of an OLC updates the class name in the data model
[x] pushed to develop

Done by closing #77


Add Bootstrap 4 renderer

Related: https://github.com/nette/forms/pull/209
Closes: #53

Fixed.

Ping.

Thank you! 🎉

May I know when you plan to release a new version with the BS4 renderer? Thanks.

Soon probably, but if you are looking for Bs3 for Nette 3.0, the repo was split into github.com/forms-rendering


Utils for getting driver metadata.

[x] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Going to rework this into a couple, more focused PRs.


Templates with dash in their names are not found

Template name: sample-test
 var t = TemplateFactory.TXT.get("sample-test");

Returns the following error:
Couldn't find template 'sample-test'.

Changed the template name to sample2
 var t = TemplateFactory.TXT.get("sample2");

The template is now found.
I tried multiple combinations, as soon as dash is the name the template cannot be found.

You'll get a stack trace that shows the actual name that was looked for, invalid Java identifier characters will be replaced by underscores. Sadly this is one of the limitations of compiling the templates to Java byte code and having a dedicated class for each template. The characters that can be used as the resulting class names can't support dashes and other characters.

Added these details to the javadoc:
https://rife2.github.io/rife2/rife/template/TemplateFactory.html#get(java.lang.String,java.lang.String)


Expand naming RFC to consider Vertex mode and undirected edge mode

Naming collision/ambiguity concerns, off the top of my head:

"topological" vertex vs geometric/boundary vertex

what naming convention would make this obvious to users?

directed edge vs (undirected) edge

can we use "edge" to mean undirected edge without confusion with directed edge?

@nrabinowitz, just to justify diving into naming, yet again ;)

2 cents here, since things are going to break in 4.0, anyway.
Call a DirectedEdge a Vector, and an undirected edge, just an Edge, or a segment.

We already have a Vector internally (used in the internals of h3ToGeo and geoToH3). I think Edge was where we ended up for undirected edges, and DirectedEdge has a nice symmetry there. 🤷


Update _settings.adoc

Sudo -> SUDO
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-doc-build


Enhance(+) readme and add .gitignore

Start splitting out useful and easily reviewable parts of the two long standing PRs on this repo.
.gitignore is from the native-load PR
and the README is mostly from the Rust Geomedian PR.

@omad Not sure this is the best place, but just a few stray thoughts on this repo:

Although this repo contains some fantastic tools, it is difficult to install, which has a big impact on all our downstream packages that use it (e.g. DEA Tools, DEA Intertidal etc). Making the requirements more minimal and/or moving dependencies to optional dependencies would make a big difference
Strongly agree that we should deprecate any functionality here that overlaps with odc-geo - I think that datacube, odc-geo and odc-stac should be the point of truth wherever possible
The image processing tools in this repo (dilation, erosion) etc are heavily used in downstream repos. Personally I think they would fit nicely in odc-geo as part of a new masking module there, but it would be great to preserve them here in the meantime (even though skimage is a bug dependancy, I've usually found it pretty easy to install)

@robbibt

Not sure this is the best place, but just a few stray thoughts on this repo:

Haha 😉 , probably not the best place, but, a place is important, and I'm always keen for your thoughts Robbi!

Although this repo contains some fantastic tools, it is difficult to install, which has a big impact on all our downstream packages that use it (e.g. DEA Tools, DEA Intertidal etc). Making the requirements more minimal and/or moving dependencies to optional dependencies would make a big difference

Okay, we can absolutely make some dependencies optional. It's easy and a step in the right direction.
It sounds like some deprecating/deleting and restructuring are also in order, which will take a bit more to achieve.

Strongly agree that we should deprecate any functionality here that overlaps with odc-geo - I think that datacube, odc-geo and odc-stac should be the point of truth wherever possible

Thanks!

The image processing tools in this repo (dilation, erosion) etc are heavily used in downstream repos. Personally I think they would fit nicely in odc-geo as part of a new masking module there, but it would be great to preserve them here in the meantime (even though skimage is a big dependancy, I've usually found it pretty easy to install)

That's good to know! I wasn't even aware there were masking tools in odc-geo. 💡
IIRC, we only use a tiny tiny part of skimage, so it might even be worth vendoring that bit, or getting it from elsewhere.

That's good to know! I wasn't even aware there were masking tools in odc-geo. 💡

There isn't "yet". But there are discussions around doing it here: https://github.com/opendatacube/odc-geo/issues/117
(would be particularly nice as masking funcs would then be something you could access via odc-geo's .odc. accessor, e.g. ds.odc.mask_invalid_data() etc instead of calling in external funcs from odc-algo or datacube-core)


Couldn't import my package with it's name

I used createSwiftPackage command to create swift package and it is successfully created. (Thank you for this great library)
   multiplatformSwiftPackage {         packageName("VLShared")         swiftToolsVersion("5.3")         targetPlatforms {             iOS { v("13") }         }         outputDirectory(File(rootDir, "/"))     }
But in my main swift project I need to import as "import common" to use package, I want to able to import package with my package name.
How can I solve this problem?

by adding this CocoaPods configuration extension problem is solved;
    cocoapods {         summary = "Some description for the Shared Module"         homepage = "Link to the Shared Module homepage"         ios.deploymentTarget = "12.4"         podfile = project.file("../iosApp/Podfile")         framework {             baseName = "VLShared"         }     }


[1.14.4] Refined Storage crash when re-entering world

Issue description:
A Refined Storage crash to the client when re-entering a world.
What happens:
The Gameclient crashes when trying to re-enter a existing world.
What you expected to happen:
Being able to enter the world without issues.
Steps to reproduce:

Enter the world
Wait
Crash
... Game closed.

Version (make sure you are on the latest version before reporting):

Minecraft: 1.14.4
Forge: 28.1.104
Refined Storage: 1.7.1

Does this issue occur on a server? [yes/no]
Not that i know of, no.
If a (crash)log is relevant for this issue, link it here:
https://pastebin.com/tA4VxS6V

I am getting the same error with the refined storage controller when restarting my dedicated server after setting up a refined storage system.
Using the All The Mods 4 Modpack.
https://pastebin.com/MwSKF24X

Thx for reporting. This issue will continue under #2381


awatch on windows can't be killed with Ctrl+C

The "KeyboardInterrupt" gets logged but the process doesn't terminate until the next file system event happens and RustNotify.watch() returns.
This is because windows doesn't have signals, so open_signal_receiver
https://github.com/samuelcolvin/watchfiles/blob/7a74df9d1a403fcf57e9b27ac65cfb30c2dbf8c9/watchfiles/main.py#L181
Doesn't work and there's no way to tell the rust code to terminate.
Potential solution is to return from RustNotify.watch() regularly, and thereby check if an error has been raised. Seems a bit ugly but I can't think of a better solution.
Let's see if people actually suffer from this?

I just came across this older bug, and I'm trying to wrap my head around it: SIGINT does work on Windows (but won't interrupt the thread's blocking API call, AFAIK), and AFAIK the call to PyErr_CheckSignals (py.check_signals() in this codebase) done each step should have triggered a KeyboardInterrupt in the main thread when it was called. The fact that a KeyboardInterrupt was seen says that SIGINT was called, as that is done by python's default SIGINT handler in Python code.
I do wonder if PyErr_CheckSignals called on a thread doesn't raise an error on Windows if the signal's already been handled on the main thread? But the stop_event should have been set and hence terminated the loop in the next step if that was the case. So I'm somewhat mystified here.

Does sound mystifying. I don't have windows and your logic makes sense, so I don't know what to suggest.

Fair 'nuff. I haven't tested my app directly on Windows, since we're running it inside a container. If I have some spare time, I'll have a play with it when I'm looking into the double-KeyboardInterrupt weirdness.

When I tested it on a VM on Ubuntu it seemed it to work. The stop_event didn't work, but the exception propagated on the next return from the rust code.
But I might have missed something.

Hmm. I noticed the comment added more-recently, and it does indeed appear that asyncio.add_signal_handler doesn't work on Windows, although there's no clear indication why, since the only Unix-only API it calls is already in that state on Windows, and e.g., signal.signal is supported on Windows.
So yeah, the original issue description was give-or-take correct, anyio.open_signal_receiver doesn't work because asyncio.add_signal_handler is not implemented on Windows, rather than lack of signals at all.

Also worth checking #136 to see if that makes it better or worse

Oh, interesting, the changes in #136 look like they are very similar to what I did to avoid the double-KeyboardInterrupt, by catching the cancelation of the awaited task, and setting my own stop_event if I saw it. Looking at https://github.com/samuelcolvin/watchfiles/issues/128#issuecomment-1109711265, that looks like roughly the same double-KeyboardInterrupt issue I saw.
So I'll follow up on that part of it in #128 if I come back to it, and for the actual topic of this bug, it looks like it's an asyncio deficiency that'll be hard to work around.

Using an Event seems like the way to do it. https://github.com/ThomasMonkman/filewatch/blob/a59891baf375b73ff28144973a6fafd3fe40aa21/FileWatch.hpp#L330
Windows has IOCP, which is IO completion ports which can do OVERLAPPED I/O.
I'm mystified python doesn't provide a signaling implementation using events.
And you can cancel I/O on Windows using that if you start them as Async.
One would presume "async" I/O uses actual asynchronous APIs from the operating system instead of a separate thread, I guess its some python limitation.


Introduce Build Operation Recorder

Introduce BuildOperationRecorder to record early fired build operations during build
Allows BuildOperationNotificationListener to handle operations fired before listeners are registered.
recording is stopped after root project is evaluated

@big-guy there's currently one performance regression seen at https://builds.gradle.org/viewLog.html?buildId=7675331&buildTypeId=Gradle_Check_PerformanceTestCoordinator&tab=report_project944_Performance_Failures for this build.


text missing - Australia

When searching for literature, the Author Country facet for Australia is missing some text:

cms search has been completely rewritten. let me know if you still see this issue.


Refactor upgrading to Blaze 2 #105

Since I found the issue and no one there from the 1th June, I just made a simple refactor to the standard c- prefix of Blaze 2.
I upgraded also all the tests to make them work with the new classes.
I think this upgrade won't break any implementations since no one should bind to the inner classes of the components except the components themselves (at least I hope...).
Tell me if something is wrong.
I hope it will be helpful!
NOTE: I forked the  master branch, but I'm seeing now that the dev  (which you mentioned within the CONTRIBUTING guide) is 3 commits behind. I hope it's correct.

I'm really new with the whole github thing.


Issue#26 added 'Modal' directory with .tsx and .module.css files

Awesome! Thank you so much!

Thank you!


Add a typesafe constructor for PermissionHelper

Yet another mini-PR :)
Before you had to use
permissionHelper.request(new String[]{Manifest.permission.GET_ACCOUNTS,Manifest.permission.ACCESS_FINE_LOCATION);

Now
permissionHelper.request(Manifest.permission.GET_ACCOUNTS,Manifest.permission.ACCESS_FINE_LOCATION);

I didn't remove the unsafe constructor because you can't use mine this way permissionHelper.request(isSingle ? SINGLE_PERMISSION : MULTI_PERMISSIONS);

have you run test base on this implementation? please confirm.

Testing code ? Life is too short for that :wink:
I tested manually using the sample app, I have no idea how to add unit test for these

i meant running test on the sample app base on your changes.

Yes I did, do you want me to add another activity with various permissions asked ?

its really up to you mate. i will be accepting your pull requests on weekend tho. so you have time to do whatever you like :)


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_ad530d65-6cab-4a05-8b3e-deaa6524590c/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_ad530d65-6cab-4a05-8b3e-deaa6524590c.git

Docs Build status updates of commit fc2cd60:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-04-07-03-26-36 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-04-07-03-26-36

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(SqlLab): Change Save Dataset Button to Split Save Query Button III

SUMMARY

This changes the current save query button into a split save button if the database has "Allow this database to be explored" enabled. When the user clicks the caret section of the button, they can now save the query as a dataset.
Bonus: In order to create this button, I conveniently needed to fix the styling on the "Run" query split button. The split line now goes all the way through the button and the caret is centered.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

From SqlLab, open a query for a database that has "Allow this database to be explored" enabled.

Observe the new split save button

Click the "Save" section of the button to see the save query modal
Click the caret v section of the button, then click "Save dataset" to see the save dataset modal
Both of these modals should be fully functional

From SqlLab, open a query for a database that does NOT have "Allow this database to be explored" enabled.

Observe that the save button is a normal button, not split

Clicking this button should show the save query modal

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Continued in this PR: https://github.com/apache/superset/pull/20852


st.read treats first row as data instead of header when you have just header in the sheet during excel import

When you have only one row in the Excel sheet which is the header and no data, st.read is treating it as data during import. In the attached image the first query shows correct behavior.  This is when you have at least one row (See 1 below the header in the first field)
The second  query in the screenshot show the issue, this is when the only row present is the header

Hi! Thanks for filing this issue!
Unfortunately since this is related to the underlying GDAL driver I'm probably not going to prioritize fixing this. Feel free to leave the issue open though and I might take a shot at it in the future.

Thank you Max.  Until then I will try to put in some workaround.  Hope this is fixed in the new year!

Hi guys,
@Maxxen please is there anything new regarding this?
@sjoe77 if you found some workaround, can you please share?
I searching for a way to load MS Excel data to DuckDB, always with headers. I have troubles with sheets that contain headers only.
Thanks a lot!

The workaround I used is to use SQL with explicit column names always(no select *).   Example select col1, col2 ...
So if you have no data just header this will throw an Exception that col1, col2 does not exist. I caught the exception and moved on assuming there were zero records in that file. But if the sql succeeded then it will give me records as expected when the data was present.

@sjoe77 cool, thanks! Unfortunately I cannot use that in my scenario (I don't have control over the SQL statement, it is issued by a user, as it is querying/testing tool). But anyway, thanks a lot for sharing your workaround.

duplicate to #8531, #113 (which were closed for whatever reason)
This error is still reproducible with duckdb==1.1.3 and a simple excel sheet with two sheets.
On the first sheet st_read correctly interprets the first row as column names, for the second one it ignores open_options=['HEADERS=FORCE'] and interprets all rows as data.

Hello! Im not really planning to fix this as anytime soon Im working on adding excel import/export to DuckDB's excel extension at which point I'll most likely remove it from spatial.


sshoogr init at 0.9.26

Motivation for this change
Add sshoogr groovy dsl to nixpkgs
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build sshoogr

@GrahamcOfBorg build sshoogr


New features: token calculation logic and account information query logic.

Tool for calculating token consumption quantity
API for querying account balance

@TheoKanning Request merge code

nice job

Thanks!

The API to request billing information doesn't seem to work. In Java it throws a 403 error and using the curl command, I get the following error message:
"Your request to GET /v1/dashboard/billing/usage must be made with a session key (that is, it can only be made from the browser). You made it with the following key type: secret."
See #349


Ensure query-planning is disabled in dask

Adds logic to raise an error if "query-planning" is enabled in dask when merlin.core is imported.
We will need to make sure merlin.core is imported (across all of Merlin) before dask.dataframe is ever imported.
This is most important for RAPIDS 24.06+, but may apply to edge cases in 24.04.

Notes on testing with RAPIDS 24.04
This PR disables both query-planning and automatic string conversion, which mitigate most test failures with 24.04. Remaining failures are described below (TODO: file issues where necessary)...

The dataset-validation machinery relies on deprecated "legacy" pyarrow features. My sense is that this validation machinery must be removed:

FAILED tests/unit/io/test_io.py::test_validate_dataset_bad_schema - ValueErro...
FAILED tests/unit/io/test_io.py::test_validate_dataset[parquet] - ValueError:...
FAILED tests/unit/io/test_io.py::test_validate_and_regenerate_dataset - Value...

It is no-longer possible to call the values attribute on an empty cudf.Series. This poses a problem for the SeriesLike protocol/test in merlin-core (not sure of the best solution yet):

FAILED tests/unit/core/test_protocols.py::test_series_are_serieslike[None] - ...

cudf does not support the np.float16 dtype (anymore?):

FAILED tests/unit/dag/ops/test_udf.py::test_udf_dtype_multi_op_propagation[False]

NOTE: Dataset cpu/gpu conversion must be updated to use the to_backend API before query-planning is enabled.

Possibly harmless int32 vs int64 dtype mismatch:

FAILED tests/unit/io/test_io.py::test_hive_partitioned_data[True] - Assertion...
FAILED tests/unit/io/test_io.py::test_hive_partitioned_data[False] - Assertio...


Email Authentication using Provider and Firebase

Description

Setup Email Signup using Firebase and Provider State management
#56 has already been created for removing the confirmation code page
Auth user flow is shown below

Screenshots

Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Make an auth provider dart file in lib\providers
All the auth screens are in lib\screens\auth
Firebase Auth has been set up in lib\services\auth.dart

Additional data
Auth User flow: https://www.figma.com/file/uhWQuE4EKDHR8AqH4p3eFK/Books-App?node-id=0%3A1
Maybe we can reset the password in a better way. Let's discuss it here

Can I work on this?

Cool @keyurgit45.
Also, follow the updated Guidelines in the README.

In widgets.dart there are custom textformfields for email and password. to get the text should I use textEditingController or onchanged ? @Mohitmadhav

In widgets.dart there are custom textformfields for email and password. to get the text should I use textEditingController or onchanged ? @Mohitmadhav

@keyurgit45 use textEditingController and make sure to check the validators.


Rows are out of sync

See this:

Career Status in text label.

probably related to scaling problems #207, #224

Yes, It seems to be scaling function of multiform which is not updated for the list. @katush Is it?

Works now.


Use requests

Switch to the requests module, instead of urllib

Coverage increased (+12.6%) to 97.245% when pulling a61e5775f86b2d76199f8e23e20eda9209832681 on use-requests into 189e5ab48e93868f721dca3965688433432b44bc on master.


Weird-ish: Not creating unique caches for different phases

Sample code:
import nlp
dataset = nlp.load_dataset('boolq')

def func1(x):
    return x

def func2(x):
    return None

train_output = dataset["train"].map(func1)
valid_output = dataset["validation"].map(func1)
print()
print(len(train_output), len(valid_output))
# Output: 9427 9427

The map method in both cases seem to be pointing to the same cache, so the latter call based on the validation data will return the processed train data cache.
What's weird is that the following doesn't seem to be an issue:
train_output = dataset["train"].map(func2)
valid_output = dataset["validation"].map(func2)
print()
print(len(train_output), len(valid_output))
# 9427 3270

Looks like a duplicate of #120.
This is already fixed on master. We'll do a new release on pypi soon

Good catch, it looks fixed.


feat: nullified note retrieval in get_notes and view_notes

This adds an include_nullified flag to the note getter/viewer options which results in the oracle combining both nullified and active notes in its response. We may eventually add a nullified_only option, though that would require performing an inclusion tesf on the nullifier tree, which will be made easier once https://github.com/AztecProtocol/aztec-packages/issues/4179 is addressed. At this point the flag would turn into an enum, but I decided to go with the simpler approach for now.
The get_note function was not given a way to query nullified notes, mostly to not break the current API as it does not have an options parameter. Ultimately though it is not hard to construct an equivalent call using get_notes by passing a limit value of 1 (which is what get_note does under the hood) and get a single potentially nullified note that way.
A potential issue that might arise with the current API is that the user does not know whether the notes they got are nullified or note, so they won't know if e.g. they need to nullify them after consuming them. However it is expected that use cases that require this option will not care about this distinction.
This PR has conflicts with https://github.com/AztecProtocol/aztec-packages/pull/3927, as that one performs some refactors on the KV PXE database which change or remove the underlying data structures used to store nullified notes. We're still coordinating with @alexghr on how to address these conflicts, so we shouldn't merge this immediately.
Fixes https://github.com/AztecProtocol/aztec-packages/issues/3755.

@nventuro realized that the extra test added is not added to run in ci. If you look at https://github.com/AztecProtocol/aztec-packages/pull/4236, @sklppy88 is adding his test. Consider doing the same or since the tests are somewhat related, might make sense to put them into the same environment to reduce number of sandboxes needed to be run.

Superceded by https://github.com/AztecProtocol/aztec-packages/pull/4238, since we cannot run CI here due to this being created from a fork.


[SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

What changes were proposed in this pull request?
When PythonUDF is used in group by, and it is also in aggregate expression, like
SELECT pyUDF(a + 1), COUNT(b) FROM testData GROUP BY pyUDF(a + 1)

It causes analysis exception in CheckAnalysis, like
org.apache.spark.sql.AnalysisException: expression 'testdata.`a`' is neither present in the group by, nor is it an aggregate function.

First, CheckAnalysis can't check semantic equality between PythonUDFs.
Second, even we make it possible, runtime exception will be thrown
org.apache.spark.sql.catalyst.errors.package$TreeNodeException: Binding attribute, tree: pythonUDF1#8615
...
Cause: java.lang.RuntimeException: Couldn't find pythonUDF1#8615 in [cast(pythonUDF0#8614 as int)#8617,count(b#8599)#8607L]

The cause is, ExtractPythonUDFs extracts both PythonUDFs in group by and aggregate expression. The PythonUDFs are two different aliases now in the logical aggregate. In runtime, we can't bind the resulting expression in aggregate to its grouping and aggregate attributes.
This patch proposes a rule ExtractGroupingPythonUDFFromAggregate to extract PythonUDFs in group by and evaluate them before aggregate. We replace the group by PythonUDF in aggregate expression with aliased result.
The query plan of query SELECT pyUDF(a + 1), pyUDF(COUNT(b)) FROM testData GROUP BY pyUDF(a + 1), like
== Optimized Logical Plan ==
Project [CAST(pyUDF(cast((a + 1) as string)) AS INT)#8608, cast(pythonUDF0#8616 as bigint) AS CAST(pyUDF(cast(count(b) as string)) AS BIGINT)#8610L]
+- BatchEvalPython [pyUDF(cast(agg#8613L as string))], [pythonUDF0#8616]
   +- Aggregate [cast(groupingPythonUDF#8614 as int)], [cast(groupingPythonUDF#8614 as int) AS CAST(pyUDF(cast((a + 1) as string)) AS INT)#8608, count(b#8599) AS agg#8613L]
      +- Project [pythonUDF0#8615 AS groupingPythonUDF#8614, b#8599]
         +- BatchEvalPython [pyUDF(cast((a#8598 + 1) as string))], [pythonUDF0#8615]
            +- LocalRelation [a#8598, b#8599]

== Physical Plan ==
*(3) Project [CAST(pyUDF(cast((a + 1) as string)) AS INT)#8608, cast(pythonUDF0#8616 as bigint) AS CAST(pyUDF(cast(count(b) as string)) AS BIGINT)#8610L]
+- BatchEvalPython [pyUDF(cast(agg#8613L as string))], [pythonUDF0#8616]
   +- *(2) HashAggregate(keys=[cast(groupingPythonUDF#8614 as int)#8617], functions=[count(b#8599)], output=[CAST(pyUDF(cast((a + 1) as string)) AS INT)#8608, agg#8613L])
      +- Exchange hashpartitioning(cast(groupingPythonUDF#8614 as int)#8617, 5), true
         +- *(1) HashAggregate(keys=[cast(groupingPythonUDF#8614 as int) AS cast(groupingPythonUDF#8614 as int)#8617], functions=[partial_count(b#8599)], output=[cast(groupingPythonUDF#8614 as int)#8617, count#8619L])
            +- *(1) Project [pythonUDF0#8615 AS groupingPythonUDF#8614, b#8599]
               +- BatchEvalPython [pyUDF(cast((a#8598 + 1) as string))], [pythonUDF0#8615]
                  +- LocalTableScan [a#8598, b#8599]

How was this patch tested?
Added tests.

Test build #107951 has started for PR 25215 at commit b3293fc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13061/
Test PASSed.

Test build #107951 has finished for PR 25215 at commit b3293fc.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107951/
Test FAILed.

* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) :
  dims [product 24] do not match the length of object [0]

SparkR CRAN feasibility check (SPARK-24152) fails again..Emailed to CRAN for help.

retest this please

Test build #107965 has started for PR 25215 at commit b3293fc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13074/
Test PASSed.

Test build #107965 has finished for PR 25215 at commit b3293fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107965/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13086/
Test PASSed.

Test build #107978 has started for PR 25215 at commit 34531b4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13088/
Test PASSed.

Test build #107980 has started for PR 25215 at commit 33a5e0d.

Test build #107978 has finished for PR 25215 at commit 34531b4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #107980 has finished for PR 25215 at commit 33a5e0d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PythonUDFSuite extends QueryTest with SharedSQLContext

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107980/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107978/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13109/
Test PASSed.

Test build #108001 has started for PR 25215 at commit 33a5e0d.

Test build #108001 has finished for PR 25215 at commit 33a5e0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class PythonUDFSuite extends QueryTest with SharedSQLContext

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108001/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13219/
Test PASSed.

Test build #108114 has started for PR 25215 at commit 3b3472e.

Test build #108114 has finished for PR 25215 at commit 3b3472e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108114/
Test PASSed.

cc @cloud-fan and @mgaido91 too

Test build #108546 has started for PR 25215 at commit c852142.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13640/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13644/
Test PASSed.

Test build #108551 has started for PR 25215 at commit 24c6744.

Test build #108546 has finished for PR 25215 at commit c852142.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #108551 has finished for PR 25215 at commit 24c6744.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108551/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108546/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13647/
Test PASSed.

Test build #108554 has started for PR 25215 at commit 24c6744.

Merged to master.

Test build #108554 has finished for PR 25215 at commit 24c6744.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108554/
Test PASSed.

cc @skonto, @Udbhav30, @shivusondur
When you guys are available, mind making each followup PR to add udf in group-by clause in each JIRA you guys took?
SPARK-28279 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/udf-group-analytics.sql @skonto
SPARK-28280 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/udf-group-by.sql @skonto
SPARK-28391 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_implicit.sql - @Udbhav30
SPARK-28390 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_having.sql @shivusondur
The PR title should usually be [SPARK-XXXXX][PYTHON][SQL][TESTS][FOLLOW-UP] Add UDF cases into group by clause in 'xxx.sql' and the procedure to describe PR description will be the same as you guys did before as described in SPARK-27921

cc @skonto, @Udbhav30, @shivusondur
When you guys are available, mind making each followup PR to add udf in group-by clause in each JIRA you guys took?
SPARK-28279 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/udf-group-analytics.sql @skonto
SPARK-28280 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/udf-group-by.sql @skonto
SPARK-28391 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_implicit.sql - @Udbhav30
SPARK-28390 https://github.com/apache/spark/blob/master/sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-select_having.sql @shivusondur
The PR title should usually be [SPARK-XXXXX][PYTHON][SQL][TESTS][FOLLOW-UP] Add UDF cases into group by clause in 'xxx.sql' and the procedure to describe PR description will be the same as you guys did before as described in SPARK-27921

@HyukjinKwon
I am still getting below error, after adding udf to groupby values, i tried for individual values also same issue
'''
-- !query 11
SELECT udf(b), udf(c) FROM test_having
GROUP BY udf(b), udf(c) HAVING udf(count(*)) = 1 ORDER BY udf(b), udf(c)
-- !query 11 schema
struct<>
-- !query 11 output
org.apache.spark.sql.AnalysisException
cannot resolve 'b' given input columns: [CAST(udf(cast(b as string)) AS INT), CAST(udf(cast(c as string)) AS STRING)]; line 2 pos 63
'''

@shivusondur @HyukjinKwon The analysis exception by adding udf to group by, is caused by SPARK-28386, SPARK-26741.
== Analyzed Logical Plan ==
org.apache.spark.sql.AnalysisException: cannot resolve '`b`' given input columns: [CAST(udf(cast(b as string)) AS INT), CAST(udf(cast(c as string)) AS STRING)]; line 2 pos 63;
'Sort ['udf('b) ASC NULLS FIRST, 'udf('c) ASC NULLS FIRST], true
+- Project [CAST(udf(cast(b as string)) AS INT)#x, CAST(udf(cast(c as string)) AS STRING)#x]
   +- Filter (cast(udf(cast(count(1)#xL as string)) as bigint) = cast(1 as bigint))
      +- Aggregate [cast(udf(cast(b#x as string)) as int), cast(udf(cast(c#x as string)) as string)], [cast(udf(cast(b#x as string)) as int) AS CAST(udf(cast(b as string)) AS INT)#x, cast(udf(cast(c#x as string)) as string) AS CAST(udf(cast(c as string)) AS STRING)#x, count(1) AS count(1)#xL]
         +- SubqueryAlias `default`.`test_having`
            +- Relation[a#x,b#x,c#x,d#x] parquet

Thanks, @viirya. @shivusondur Can you comment the test out with those JIRA numbers?


Update README.md

给usenix security'19-FIRM-AFL: High-Throughput Greybox Fuzzing of IoT Firmware via Augmented Proc添加了reading note [https://blog.csdn.net/weixin_39945679/article/details/111370554]

thanks


Stale data not being weeded from chart

Current Behavior
I have a chart being fed data every 5 seconds, and have set the chart config to append data points and x-axis limit to 1 hour.
When I first load the chart, or refresh the browser I get exactly that, 1 hour of data. But if I leave the browser connected, the stale data (more than 1 hour old) is not removed from the chart, as per the screenshot.
I'm concerned that if the browser was kept connected, that the amount of data (points) being stored would affect the stability of the system due to memory constraints.

Expected Behavior
I expected that chart data older than 1 hour would be removed from the chart after 1 hour, however that is not the case.
Steps To Reproduce
Create a chart configured as above, and leave the browser connected to the chart.
Forum link to discussion - https://discourse.nodered.org/t/stale-data-not-being-weeded-from-chart/87039
Environment

Dashboard version: 1.7.0
Node-RED version: 3.1.8
Node.js version: 20.12.0
npm version: 10.5.0
Platform/OS: Ubuntu on Oracle cloud server
Browser: Chrome Version 123.0.6312.106 (Official Build) (64-bit) (Although same result with Edge)

Have you provided an initial effort estimate for this issue?
I am not a FlowFuse team member

Further information...
Forum member Paul (zenofmud) commented;
Try this little flow I played with and you will see the data rolloff the chart as new data comes in once it hits the time limit.
It looks to me that if the count is greater than the number of points that would show in the time limit, only the number of points that fit in the time limit will show and new points will roll off the older points.
[{"id":"9ca6b2461422c2a6","type":"ui-chart","z":"2f464dcf4944f62e","group":"d2c4867136b89fdb","name":"","label":"chart","order":9007199254740991,"chartType":"line","category":"topic","categoryType":"msg","xAxisProperty":"","xAxisPropertyType":"msg","xAxisType":"time","yAxisProperty":"","ymin":"","ymax":"","action":"append","pointShape":"star","pointRadius":4,"showLegend":true,"removeOlder":"1","removeOlderUnit":"60","removeOlderPoints":"100","colors":["#1f77b4","#aec7e8","#ff7f0e","#2ca02c","#98df8a","#d62728","#ff9896","#9467bd","#c5b0d5"],"width":6,"height":8,"className":"","x":490,"y":560,"wires":[[]]},{"id":"18f731fd8d23c2eb","type":"random","z":"2f464dcf4944f62e","name":"","low":1,"high":"100","inte":"true","property":"payload","x":320,"y":560,"wires":[["9ca6b2461422c2a6"]]},{"id":"acd7ecd08794350b","type":"inject","z":"2f464dcf4944f62e","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"5","crontab":"","once":true,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":130,"y":560,"wires":[["18f731fd8d23c2eb"]]},{"id":"d2c4867136b89fdb","type":"ui-group","name":"Group Name","page":"fbb5c5f6fdf9ef6c","width":"6","height":"1","order":-1,"showTitle":true,"className":"","visible":"true","disabled":"false"},{"id":"fbb5c5f6fdf9ef6c","type":"ui-page","name":"Page Name","ui":"e662da78a987a98f","path":"/d2","icon":"home","layout":"grid","theme":"edb08c2cb16dcc54","order":-1,"className":"","visible":"true","disabled":"false"},{"id":"e662da78a987a98f","type":"ui-base","name":"Testd2","path":"/dashboard","includeClientData":true,"acceptsClientConfig":["ui-notification","ui-control"],"showPathInSidebar":false},{"id":"edb08c2cb16dcc54","type":"ui-theme","name":"Mytheme","colors":{"surface":"#ffffff","primary":"#0094ce","bgPage":"#eeeeee","groupBg":"#ffffff","groupOutline":"#cccccc"},"sizes":{"pagePadding":"12px","groupGap":"12px","groupBorderRadius":"4px","widgetGap":"12px"}}]

(see https://discourse.nodered.org/t/stale-data-not-being-weeded-from-chart/87039/7 )


Fix "find"-command in xspec.bat

XSpec failed with message:
find: ÔÇÿdÔÇÖ: No such file or directory
ERROR: XSPEC_HOME is not a directory

It seems the "find"-command is supposed to look for a letter "d" in file properties.
correct command for this task seems to be "findstr".
Line 281 changed this way things work

find on Windows is a standard command to look for strings. (The executable is C:\Windows\System32\find.exe.)
You probably have another find command in your PATH environment variable before C:\Windows\System32. Try where find to find out what.
(By the way, you perhaps meant to open this pull request at the upstream?)


python/tools: Update distrotest to retry apt failures

/retest infra fail

/lgtm deps

/retest flakes

seems this didnt work - im assuming due to no sudo - but i think the user is root anyway - ill update

argh - it landed anyway 8( - fix incoming ...


feat: add acc_dtype to einsum

Adds acc_dtype to einsum

can you add tests next to test_sum_acc_dtype?

can you add tests next to test_sum_acc_dtype?

@chenyuxyz
I put it into the existing test_arg_acc_dtype, as an explicit Tensor.einsum call, as it seems fit naturally with test_arg_acc_dtype structure, with other methods like .sum(), and .matmul.
Is that what you expected?

cool!


ARROW-12468: [Python][R] Expose ScannerBuilder::UseAsync to Python & R

This exposes (in python & R) the UseAsync method added to ScannerBuilder in ARROW-12289.

This PR could use some advice from the R community.  I'm adding the ability to request async (at the moment async is a performance degredation in some cases when I/O is really fast so until we've made more progress there it will need to be optional)  I've added UseAsync to the scanner in R which is used, for example, like this:
test_that("Scanner$ScanBatches", {
  ds <- open_dataset(ipc_dir, format = "feather")
  batches <- ds$NewScan()$Finish()$ScanBatches()
  table <- Table$create(!!!batches)
  expect_equivalent(as.data.frame(table), rbind(df1, df2))

  batches <- ds$NewScan()$UseAsync(TRUE)$Finish()$ScanBatches()
  table <- Table$create(!!!batches)
  expect_equivalent(as.data.frame(table), rbind(df1, df2))
})

However, most of the examples I see reading a dataset are doing something like...
ds %>%
      select(string = chr, integer = int) %>%
      filter(integer > 6 & integer < 11) %>%
      collect() %>%
      summarize(mean = mean(integer))

How should UseAsync be inserted into such a pattern (chain?) of calls.  Should it be it's own operator:
ds %>%
      select(string = chr, integer = int) %>%
      filter(integer > 6 & integer < 11) %>%
      use_async() %>%
      collect() %>%
      summarize(mean = mean(integer))

...or an argument to collect:
ds %>%
      select(string = chr, integer = int) %>%
      filter(integer > 6 & integer < 11) %>%
      collect(use_async=TRUE) %>%
      summarize(mean = mean(integer))

...or exposed some other different way?

Elsewhere, we use a global option for governing e.g. whether to use multithreading, would that be appropriate here?
Do you expect this to always be optional, or is it only optional for now while you sort out the performance optimization?

One concern I had when seeing the heavy parameterization (basically a lot of tests x4) is about the run test time, but checking the most expensive tests, it's basically all related to the S3 related tests:
$ pytest python/pyarrow/tests/test_dataset.py --durations=20
...
============================================================================================== slowest 20 durations ===============================================================================================
15.39s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_s3_with_filesystem_uri[threaded-sync]
15.36s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_s3_with_filesystem_uri[serial-sync]
15.36s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_s3_with_filesystem_uri[serial-async]
15.35s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_s3_with_filesystem_uri[threaded-async]
3.13s call     pyarrow/tests/test_dataset.py::test_write_dataset_s3
2.03s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[threaded-async]
2.02s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec[threaded-async]
2.02s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[serial-async]
2.02s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec[serial-async]
2.02s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[threaded-sync]
2.02s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[serial-sync]
2.02s setup    pyarrow/tests/test_dataset.py::test_write_dataset_s3
2.01s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec[serial-sync]
1.58s setup    pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec[threaded-sync]
1.07s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[threaded-async]
1.06s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[threaded-sync]
1.05s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[serial-sync]
1.05s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3[serial-async]
0.47s call     pyarrow/tests/test_dataset.py::test_open_dataset_from_uri_s3_fsspec[threaded-async]
0.30s setup    pyarrow/tests/test_dataset.py::test_make_fragment

So we now run those 4 times, but instead of objecting to the parameterization (since I suppose it's especially useful for S3 tests?), it's probably more useful to see why it actually takes such a long time

Locally it's far faster with AWS_EC2_METADATA_DISABLED=true and test_fs.py already has a workaround for this. (AWS SDK tries to contact an AWS metadata server by default with a long timeout.)
I filed ARROW-12810.

See #10348 - this should speed things up quite a bit (especially in test_fs.py it turns out).

Elsewhere, we use a global option for governing e.g. whether to use multithreading, would that be appropriate here?

A global option seems like it should be fine.

Do you expect this to always be optional, or is it only optional for now while you sort out the performance optimization?

I expect it should go away at some point.  Either we get to the point where the overhead is negligible or the filesystems themselves could determine what kind of mode to use (potentially via io context).

👍 then check out examples where GetBoolOption is called in r/src, that's probably what you want. The option is set in R like options(name=value)

+1 then check out examples where GetBoolOption is called in r/src, that's probably what you want. The option is set in R like options(name=value)
@nealrichardson

I've added a check to use the option if it isn't specified so that should catch dplyr now.  I'm a bit torn on testing.  There is no good way to tell if a scan happened synchronously or asynchronously by looking at the result (ideally they should be identical).  I could add an IsAsync method to the scanner but I don't know how I feel about adding that just for testing purposes, but I could probably be swayed.  The proof is really in the performance (and I hope to get an R version of the dataset benchmark up which should demonstrate this).

So we now run those 4 times, but instead of objecting to the parameterization (since I suppose it's especially useful for S3 tests?), it's probably more useful to see why it actually takes such a long time
@jorisvandenbossche

I don't know that the parameterization is particularly useful as the S3 tests are more focused on dataset factory.   I backed off a bit and only one S3 test is now run with async.  This, combined with David's changes, has all tests running in ~2.5s on my desktop.

Ok, I think I've addressed all review comments.  Any follow-up is welcome.
However, it might be convenient to hold off on merge for just a bit.  I've got a conbench benchmark that I've added (https://github.com/ursacomputing/benchmarks/pull/40) which should demonstrate that something is actually happening when we set use_async to true.  So I'd like to wait until that is merged and I run conbench on the PR.

@ursabot please benchmark lang=Python

@ursabot please benchmark lang=Python

The EC2 instances where we really want the benchmarks are running out of memory it seems.  I was able to get some times from ursa-i9-9960x.  Note, it does not line up the benchmarks because the tags are different but they are the same test.

@westonpace was there any more benchmarking you wanted to do here? Otherwise let's merge this.

@lidavidm Go for it :smile:


Create and publish nuget package

See Introductory Guide to Creating and Publishing a NuGet Package using Visual Studio.

https://www.nuget.org/packages/Enban


When I use security --list the following error occurred

Error: Atom's argument type is not a subtype of its declared type in file locked-ether.dl at line 15
contractCompliance(contract, matchComment) :-
-----------------------^---------------------------
The argument's declared type is Contract in file abstract-contract-pattern.dl at line 26
.decl contractCompliance(contract: Contract, comment: MatchComment)
------------------------------------^---------------------------------
Warning: Variable argInContext only occurs once in file pass.dl at line 27
ctxProvider.elementInContext(argInContext, argument, context),
-------------------------------------^----------------------------------
Error: Atom's argument type is not a subtype of its declared type in file timestamp.dl at line 53
existsBlockTimestamp(timestampSSA, blockTimestampLine):-
---------------------------------------^----------------------
The argument's declared type is Element in file timestamp.dl at line 52
.decl existsBlockTimestamp(blockTimestamp: Element, blockTimestampLine: Element)
----------------------------------------------------------------------------^---------
Error: Atom's argument type is not a subtype of its declared type in file tx-origin.dl at line 37
callInfo(call, matchInfo, matchComment) :-
-------------^----------------------------------
The argument's declared type is Transfer in file tx-origin.dl at line 36
.decl callInfo(call: Transfer, matchInfo: symbol, matchComment: symbol)
-------------------------^---------------------------------------------------
Warning: Variable valueCtx only occurs once in file unrestricted-ether-flow.dl at line 38
ctxProvider.elementInContext(valueCtx, value, context),
-------------------------------------^---------------------------
Warning: Variable thisBlock only occurs once in file unused-return.dl at line 11
externalJump(thisBlock, otherBlock, returnBlock),
---------------------^-------------------------------------
Warning: Deprecated type declaration used in file util-sets.dl at line 5
.symbol_type Set
-^-----------------
Warning: Variable _c marked as singleton but occurs more than once in file semantics.dl at line 23
criticalUsageAt(val, call) :- externalCall(c), callValue(c, v), SAME_CTX(val, call, v, c).
Warning: Variable _c marked as singleton but occurs more than once in file semantics.dl at line 24
criticalUsageAt(gas, call) :- externalCall(c), callGas(c, g), SAME_CTX(gas, call, g, c).
Warning: Variable _c marked as singleton but occurs more than once in file semantics.dl at line 27
SAME_CTX(arg, call, a, c).
Warning: Variable _c marked as singleton but occurs more than once in file semantics.dl at line 31
SAME_CTX(arg, ret, a, r).
Warning: Variable _c marked as singleton but occurs more than once in file semantics.dl at line 33
criticalUsageAt(value, store) :- storageMutation(s, v), SAME_CTX(value, store, v, s).
Error: Atom's argument type is not a subtype of its declared type in file trusted-variable.dl at line 29
trustedPredecessors(node, SET_ADD(set, [pred])) :-
-------------------------------^------------------------
The argument's declared type is Set in file trusted-variable.dl at line 12
.decl trustedPredecessors(node: data.Node, preds: Set)
------------------------------------------------------^-----
Error: Ambiguous record in file trusted-variable.dl at line 29
trustedPredecessors(node, SET_ADD(set, [pred])) :-
---------------------------------------------^----------
Warning: No rules/facts defined for relation warnings in file util-debug.dl at line 5
.decl warnings(error: symbol)
------^------------------------
5 errors generated, evaluation aborted

same issue


six.moves marked as missing module source

Environment data

Language Server version: 2021.5.3
OS and version: OSX 10.14.6
Python version (& distribution if applicable, e.g. Anaconda): 3.9.1

Expected behaviour
six.moves should be resolved in the activated interpreter as six is.
Actual behaviour
reportMissingModuleSource error

six.moves appears to be a module that gets dynamically generated in memory by six.py at runtime and doesn't appear on disk (but, has a stub via typeshed), hence the "missing source" error. That's really unfortunate.

Yeah; pylint can find it because it actually constructs the AST.  Tricky for static analysis that's for sure.

We can find it (as a stub in typeshed), it's just that we issue a warning when we can't find the source. I'm sure pylint has special cased this to not emit a message as it knows this popular module does something special.

Pylint constructs the AST for the source it's analysing. Doesn't need to special case anything to my knowledge.  It's a dynamic analysis tool whereas pylance appears to be a static analysis tool.  The tradeoff is performance versus correctness, as can be seen here.

I really think module six should be "mounted" somehow and the message not be displayed. It is a very used module. The funny thing is that the code complete finds the six.moves in the import.

Code-complete works because pylance bundles the stubs for six.moves from typeshed.
Perhaps pylance should just suppress reportMissingModuleSource for six.moves and sub-modules of it when six itself is found, as a known "implemented via sys.meta_path" case?

Import "six.moves" could not be resolved from sourcePylancereportMissingModuleSource
(module) moves

@mrkguruin I can confirm this error as well. But it is a different error from this issue. Can you please open a new issue?

I just disabled this check for all projects globally in user settings JSON:
{
	"settings": {
		"python.analysis.diagnosticSeverityOverrides": {
			"reportMissingModuleSource": false
		}
	}
}

It was only a warning, and seemingly not helpful?
I wonder if this could be extended to allow me to ignore this rule only for specific modules - or if six should be disabled by default - or possibly a guide on how to "install" the typeshed rules?  https://github.com/python/typeshed/blob/main/stubs/six/six/moves/init.pyi
i.e. pip install types-six in the venv terminal + Python: Restart Language Server didn't seem to cut it?


[Feature] update sharded loader

Description
Update SharededDataLoader according to https://github.com/apache/incubator-mxnet/pull/13447
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Job PR-468/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-468/6/index.html


Gradle 7

I had a go at switching to gradle 7.
One issue is Maven publishing. I switched to the maven-publish plugin, but not sure I can test it. I wasn't sure how to handle non-android libraries either so I excluded for now. Perhaps a starting point though.
Some unit tests fail. When running the tests in Android studio, I get a lot of java.lang.reflect.InvocationTargetException in ElectricSputnik, but this doesn't occur when running in the GitHub action. I'm not sure what the difference is, any ideas?
Otherwise, the sample App builds and runs fine.

After merging the unit tests without robolectric, all tests are passing now. The only remaining work to do is testing maven publish which I don't think I can do.

@dariuszseweryn Building javadocs currently doesn't work because of relocated javax.inject:
javadoc: error - In doclet class com.google.doclava.Doclava,  method start has thrown an exception java.lang.reflect.InvocationTargetException
com.sun.tools.javac.code.Symbol$CompletionFailure: class file for bleshadow.javax.inject.Inject not found

I upgraded the shadow plugin but still get the same error. Any ideas?

@dariuszseweryn I decided to fork this project so we can maintain it more actively and merge the PRs we had open. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. I've merged this PR there. If you continue maintaining this project, you may want to look at the following files for up to date publishing to Maven Central via GitHub Action:
https://github.com/NRB-Tech/RxAndroidBle/blob/main/gradle/gradle-mvn-push.gradle
https://github.com/NRB-Tech/RxAndroidBle/blob/main/gradle/gradle-mvn-config.gradle
https://github.com/NRB-Tech/RxAndroidBle/blob/main/.github/workflows/publish.yml


Use the JSON grammar file to generate various info tables.

This patch uses a Python script to parse the JSON grammar file to
generate the opcode table and operand kind tables.
Now we don't need to do the post-processing (from OperandClass
to spv_operand_type_t) and copying of the opcode info table is
not required anymore!

The Travis builds fail since simplejson is not available.  Why not just import it as "json"?

-1

+2


Multiple bootstrap modals scrolling issue.

The scenario is. I have my main page where i already have scrolling. Where i am opening one bootstrap dialogue which is also bigger and the scroll is showing and scrolling the dialogue. In this big dialogue i have opened one more dialogue which is smaller one which remove the scroll. after i close this small dialogue the scroll is coming back on the back but it is not scrolling the dialogue. The scroll is working for the main page.
So how to handle this situation?
Thank you in Advance.
Hrushikesh

Assuming you mean multiple modal dialogs, Bootstrap explicitly does not support having multiple modals open at once: http://getbootstrap.com/javascript/#callout-stacked-modals

As per that i have written custom code as below:
$("#btnAddPerson").click(function (e) {
e.preventDefault();
var href = '@Url.Action("AddPerson", "Common")';
$('#addPersonDialogWindow').html("");
$('#addPersonDialogWindow').load(href);
$('#addPersonDialogWindow').modal({ show: true });
});
$('#addOrgDialogWindow').on('hidden.bs.modal', function (e) {
e.stopPropagation();
});

We are unable to assist with the writing or debugging of such custom code on this issue tracker. Please direct your question to StackOverflow (or similar) instead. Thanks!

Something I am curious about, it seems like half the issues opened up are related to multiple modals on a page. With so many issues has there been any thought, perhaps in v4, to support multiple modals or is this not supported for a design reason?

It's my understanding that the main reason these aren't supported is that they can not be made accessible in a clear manner for screen readers and other assistive technologies.

Due to implementation difficulty (chiefly CSS and event handling), it's not currently under consideration for v4. mdo also cited bad UX in one of the issues where the feature was canonically rejected, although that was quite a while ago.

For those who are still facing this issue/limitation.
Workaround 1:
$('.modal').on('hidden.bs.modal', (e) => {
    $('body').addClass('modal-open');
});

If this not helping, here's workaround 2:
$('.modal').on("hidden.bs.modal", function (e) {
    if($('.modal:visible').length)
    {
        $('.modal-backdrop').first().css('z-index', parseInt($('.modal:visible').last().css('z-index')) - 10);
        $('body').addClass('modal-open');
    }
}).on("show.bs.modal", function (e) {
    if($('.modal:visible').length)
    {
        $('.modal-backdrop.in').first().css('z-index', parseInt($('.modal:visible').last().css('z-index')) + 10);
        $(this).css('z-index', parseInt($('.modal-backdrop.in').first().css('z-index')) + 10);
    }
});

Credits to this blog


Gdamore/automargin

@gdamore it looks like you've accidentally removed some Strikethrough fields here: I noticed that strikethrough styling no longer has any effect after bumping my tcell version.

Oof. My copy of the terminfo db probably lacks them.  I will have to check again. Sorry.
On Mar 2, 2024 at 7:48 PM -0800, Jesse Duffield @.***>, wrote:

@gdamore it looks like you've accidentally removed some Strikethrough fields here: I noticed that strikethrough styling no longer has any effect after bumping my tcell version.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Problem with small sprite in the latter half?

To reproduce, patch the repo with the following (using git-apply), or use the following repo. Then run riscv-example
Web: https://github.com/lxylxy123456/riscv-console/tree/bug16/riscv-example
Repo: git@github.com:lxylxy123456/riscv-console.git
Branch: bug16
Folder: riscv-example
diff --git a/riscv-example/src/main.c b/riscv-example/src/main.c
index 2d1a12c..bfcc7d7 100644
--- a/riscv-example/src/main.c
+++ b/riscv-example/src/main.c
@@ -24,6 +24,22 @@ int main() {
     VIDEO_MEMORY[11] = '!';
     VIDEO_MEMORY[12] = 'X';

+	// Mode
+	*(uint32_t*) 0x500FF414 = 0x1;
+
+	// Palette
+	* (volatile uint32_t *) 0x500fd000 = 0xffffffff;
+
+	// Control
+	int max = 128;
+	int i = 90;
+	while (1)
+		for (int i = 0; i < max; i++) {
+			int ii = (i + max - 1) % max;
+			* (volatile uint32_t *) (0x500ff214 + 4 * i) = 0x7fe42108;
+			* (volatile uint32_t *) (0x500ff214 + 4 * ii) = 0x7fe42109;
+			for (int i = 0; i < 0x10000; i++);
+		}

     while (1) {
         int c = a + b + global;

Each time the code makes a white square with small sprite i on the screen, and then remove the square of small sprite i - 1. So the small sprite should always appear on the screen. However, actually the square flashes periodically.
If we change int max = 128; to int max = 64;, the problem disappears. So I think there is some problem with around small sprite >= 70 (see image below, where I am trying to draw 3 lines of small sprites).

The code you posted has everything in the same location, but you are showing sprites spread out in the image. I assume there is different code for that? In terms of the flashing part of the issue might be that the updates aren't synchronized to the video interrupt. Have you tried using fewer, but further in the series? Is it a matter of the total sprites on screen?

The image I posted is from another code.
I think the flashing is not due to video synchronization. Because the flashing is slow and I have used for (int i = 0; i < 0x10000; i++); to "sleep" for some time.
I will try the things later. I guess it is likely to be related to the total sprites on the screen.

Think I found the bug. Try and pull the most current.

Looks good to me. Thanks for fixing the bug.


Feature/built in navigation reducer

Since we have the withNavigation High Order Component (HOC) available, make our own reducer doesn't add any advantage so this PR moves the reducer logic to the built-in reducer in the library and now we always navigate with the library props.
To handle the first state there is a new home component that checks if the setup was done or should redirect to the dashboard directly.
Also saves in the AsyncStorage the setup as complete here

I've included a link in the description to understand what an HOC is.


What license is it using?

@msshli the visualizer looks really great! I would like to fork it. What license is it using?

Apache 2. Forgetting to include it was an oversight.

Cool, thanks!
On Oct 21, 2016 8:26 PM, "Shenglong Li"<EMAIL_ADDRESS>wrote:

Closed #6 https://github.com/msshli/arm-visualizer/issues/6.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/msshli/arm-visualizer/issues/6#event-832311120, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAM0M0kSa8i3zHSAqsg4IpXjCAi4GXw8ks5q2PW3gaJpZM4KcGbo
.


Replace flake8 with ruff

Codecov Report

Merging #24 (5729993) into master (c0c0c67) will not change coverage.
The diff coverage is 84.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   90.78%   90.78%
=======================================
  Files          13       13
  Lines         727      727
  Branches      126      126
=======================================
  Hits          660      660
  Misses         56       56
  Partials       11       11

Impacted Files
Coverage Δ

src/tabeline/_expression/_functions.py
100.00% <ø> (ø)

src/tabeline/_data_frame.py
89.05% <54.54%> (ø)

src/tabeline/_validation.py
86.66% <75.00%> (ø)

src/tabeline/__init__.py
100.00% <100.00%> (ø)

src/tabeline/_concatenate.py
100.00% <100.00%> (ø)

src/tabeline/_expression/__init__.py
100.00% <100.00%> (ø)

src/tabeline/exceptions.py
80.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use pysqlite3 instead of stdlib sqlite3

This is so we can make use of the bundled version of SQLite in
pysqlite3-binary which (since this PR) has been compiled with a
much higher memory-map limit. Since, our 6G prescribing files were
exceeding the previous 2G limit its possible that this will have
significant performance benefits for us. The easiest way of finding out
is just to try it and see. We have nginx logging response times so a
before/after comparison should be fairly straightforward.

Add a calendar entry to check the times to find out?! Not super important, but interested!


Shadows api key from tavily logs

Fixes the #958 issue.
There are two design decisions taken here that we might discuss for sure.
The first one is that the class is local to be used by the Tavily module, but it could be located in a "common" module so that any other system can use this feature for passwords. Maybe for now, we can leave it as is,  but it is something we can have in mind.
The second was to figure out whether to use the VertX JSON feature to parse the body or start using some string manipulations. To keep things simple, I decided to use JSON instead of String manipulation utilities. I know this has an impact on performance, but it is INFO logs, so I am not sure if they would be enabled in production. Also, to avoid having potential IndexOutOfBound errors.

I don't know why there is a format error in the test, in theory it is autoformatted, but then the goal fails.

I force pushed to fix the formatting issue

I force pushed to fix the formatting issue

Gah, you were 10 seconds faster.

😆

The first one is that the class is local to be used by the Tavily module, but it could be located in a "common" module so that any other system can use this feature for passwords. Maybe for now, we can leave it as is, but it is something we can have in mind.

I don't think we can apply this easily to other modules, because Tavily has the oddity that the API key is a JSON field in the body of the request, all other services that we integrate expect it as an HTTP header.

CI now passes

Great, thank you very much. Would it be possible to have a release before Devoxx?. I need to show this in the demo, and I'd prefer to not have to worry about showing console by error :)

Yeah, I'll release today

No rush, if it is for Monday morning it is fine :)