Log in - "And" is missing in password requirements - Reported by: @parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to log in and enter a new user email
Click on the validation link
In the password setup screen check the requirements

Expected Result:
Message says 1 capital letter, 1 lowercase letter and 1 number
Actual Result:
And is missing in the last requirement before 1 number and says 1 capital letter, 1 lowercase letter, 1 number
Workaround:
None needed, visual issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.7-22
Reproducible in staging?: yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634061561200000
View all open jobs on GitHub

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@gabrielessner I just want to make sure we do want to make this copy update? And if yes, should we also make it on OldDot?

You are right @flodnv I just searched slack because I remembered a recent conversation about oxford comma's and found this.
So it should read as:
1 capital letter, 1 lowercase letter, and 1 number

@mallenexpensify Am I eligible for reporting bonus here? Thanks.


Pinpoint Collector fails

Prerequisites
Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

[ ] I have checked the FAQ, and issues and found no answer.

What version of pinpoint are you using?
v2.2.2
Describe your problem**
I installed pinpoint on RHEL-7
Java 7,8,9 are installed.
executed - ./mvnw install -DskipTests=true and  it was successful.
Then as per instructions, executed following to start the collector:
java -jar -Dpinpoint.zookeeper.address=localhost pinpoint-collector-boot-2.3.0-SNAPSHOT.jar
And I could see multiple errors on screen.
What have you done?
Steps you have taken to trigger the problem, for example:
I executed following to start the collector:
java -jar -Dpinpoint.zookeeper.address=localhost pinpoint-collector-boot-2.3.0-SNAPSHOT.jar
Logs
07-07 17:54:08.008 [localhost:2181)] WARN  o.a.h.h.s.o.a.z.ClientCnxn               : Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[?:?]
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[?:?]
at org.apache.hadoop.hbase.shaded.org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) ~[hbase-shaded-client-1.4.13.jar!/:1.4.13]
at org.apache.hadoop.hbase.shaded.org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1141) [hbase-shaded-client-1.4.13.jar!/:1.4.13]
07-07 17:54:08.008 [localhost:2181)] INFO  o.a.h.h.s.o.a.z.ClientCnxn               : Opening socket connection to server localhost/<IP_ADDRESS>:2181. Will not attempt to authenticate using SA
SL (unknown error)
07-07 17:54:08.008 [localhost:2181)] WARN  o.a.h.h.s.o.a.z.ClientCnxn               : Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[?:?]
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[?:?]
at org.apache.hadoop.hbase.shaded.org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) ~[hbase-shaded-client-1.4.13.jar!/:1.4.13]
at org.apache.hadoop.hbase.shaded.org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1141) [hbase-shaded-client-1.4.13.jar!/:1.4.13]
07-07 17:54:08.008 [localhost:2181)] INFO  o.a.z.ClientCnxn                         : Opening socket connection to server localhost/<IP_ADDRESS>:2181. Will not attempt to authenticate using SA
SL (unknown error)
07-07 17:54:08.008 [localhost:2181)] INFO  o.a.z.ClientCnxn                         : Socket error occurred: localhost/<IP_ADDRESS>:2181: Connection refused
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.r.ExecutorFactoryBean            : Shutting down ExecutorService 'grpcAgentServerExecutor'
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.r.g.s.c.GrpcCommandService       : close() started
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.z.ZookeeperClusterService      : ZookeeperClusterService destroying started.
07-07 17:54:08.008 [extShutdownHook] INFO  .p.c.c.z.ZookeeperProfilerClusterManager : stop() started.
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.z.ZookeeperJobWorker           : stop() started.
07-07 17:54:08.008 [rJobWorker(2-0)] INFO  c.n.p.c.c.z.ZookeeperJobWorker           : run() completed.
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.z.ZookeeperJobWorker           : stop() completed.
07-07 17:54:08.008 [extShutdownHook] INFO  .p.c.c.z.ZookeeperProfilerClusterManager : stop() completed.
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.z.ZookeeperClusterManager      : ZookeeperClusterManager destroying started.
07-07 17:54:08.008 [extShutdownHook] INFO  .c.c.c.CollectorClusterConnectionManager : CollectorClusterConnectionManager destroying started.
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.c.CollectorClusterConnector    : CollectorClusterConnector destroying started.
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.c.CollectorClusterConnector    : CollectorClusterConnector destroying completed.
07-07 17:54:08.008 [extShutdownHook] INFO  .c.c.c.CollectorClusterConnectionManager : CollectorClusterConnectionManager destroying completed.
07-07 17:54:08.008 [terManager(3-0)] INFO  c.n.p.c.c.z.ZookeeperClusterManager      : Worker stopped
07-07 17:54:08.008 [extShutdownHook] INFO  c.n.p.c.c.z.ZookeeperClusterManager      : ZookeeperClusterManager destroying completed.
07-07 17:54:08.008 [tor-Framework-0] INFO  o.a.c.f.i.CuratorFrameworkImpl           : backgroundOperationsLoop exiting
07-07 17:54:09.009 [localhost:2181)] INFO  o.a.h.h.s.o.a.z.ClientCnxn               : Opening socket connection to server localhost/0:0:0:0:0:0:0:1:2181. Will not attempt to authenticate using SASL (unknown error)
07-07 17:54:09.009 [localhost:2181)] WARN  o.a.h.h.s.o.a.z.ClientCnxn               : Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[?:?]
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[?:?]
at org.apache.hadoop.hbase.shaded.org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) ~[hbase-shaded-client-1.4.13.jar!/:1.4.13]

Hi @vikasthakur99
Error logs show it has problem with connecting Zookeeper.
Please check whether Zookeeper works well or not.
Thanks :)


New entity synthesis for tv screen devices

Relevant information
Added a new entity synthesis rule for TV screen devices

Checklist

[x] I've read the guidelines and understand the acceptance criteria.
[x] The value of the attribute marked as identifier will be unique and valid.
[x] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Frederico R Ferreira seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


The question about result

Hi, when I running main.py, I find that the result is unstable. After tried many times of main.py, I only got a few results consistent with the paper finally. I don't know this phenomenon is normal or not. Thanks a lot!

And this is the parameter I used in main.py

Hello, friend, excuse me, do you use the complete original data to get the result, or the partially processed data provided in the code

Hello, I use complete original data from the https://itrust.sutd.edu.sg/itrust-labs_datasets/ and process original data by the process_swat.py.

Hi @fuyuyuputao, thanks for your interest in our work.
I think the overall results you showed look fine to me. We have also found there exist some randomness even though the random seeds are set and fixed.

OK! Thanks a lot!

Hello, my friend, I got the original dataset from itrust and processed it, but the result doesn't seem to be as good as yours, can you please share the dataset, thanks a lot, my email is

OK! Thanks a lot!

Hello, my friend, I got the original dataset from itrust and processed it, but the result doesn't seem to be as good as yours, can you please share the dataset, thanks a lot, my email is<EMAIL_ADDRESS>

Hello, I got the original dataset from itrust and processed it, but the result doesn't seem to be as good as yours, could you please share the dataset, thanks a lot, my email is<EMAIL_ADDRESS>


[ST] Relayer fees bump not detected - Keep asking for more

Describe the bug
The user initiated a txn from Arbitrum to Linea with 0 relayer fees (this could be a calculation bug on our side)

https://connextscan.io/tx/0x5fbe311c626e640be067e7ae2908302a515bec2bed100e15f7f3bb59a1a47d2f
He bumped the first time here: https://arbiscan.io/tx/0xd475b7b07ca0b4a45e478e12c984282b94165319649dd5ae8831fe347f18c902
Then, the system requested him to bump it 2 more times:
https://arbiscan.io/tx/0x23f1969c364a45d204e90b21fe469546f5895fb7f9bb42a33b7f02f4f913b878
https://arbiscan.io/tx/0xaae0be675647c754d32fd813451ffeaa823dec4720a59fbc9d3512afa7e8deab
It seems that despite successive bumps the system is still showing the relayer fee at 0.
Link to ticket in discord
https://discord.com/channels/454734546869551114/1219801005328175124
@oncall

Closing unless we see more instances of this post-cutover.


Refiner injection into the Nuxt

Hi, thanks to owners for this package.
But i can't understand how correctly inject it into config file
I created file refiner.js into plugins folder, added this file into plugins block in nuxt config file.
It works, but I see it broke all my app.
Can you give me suggestion how correct inject it? Might be I'm doing incorrect?

nuxt config file:
plugins: [
    { src: '~/plugins/refiner.js', mode: 'client' },
  ],

refiner.js
import Vue from 'vue'
import Refiner from 'refiner-js'

Vue.use(
  Refiner(
    'setProject',
    process.env.REFINER_ID || '00000000-my-id-000000000'
  )
  //   Refiner('identifyUser', {
  //     id: 'USER-ID-ABC-123', // Each user needs an ID or email address
  //     email<EMAIL_ADDRESS>// Each user needs an ID or email address
  //     name: 'Jane Doe', // The full name of the user
  //   })
)

I also have another implementation based on this answer.. But I want to do the same way as all other plugins. Also I need get and update user info if user logged in.
upd:
import { _refiner as Refiner } from 'refiner-js'
works I suggest

created this solution:
`
import _refiner from 'refiner-js'
_refiner('setProject', '4e84dab0-e7d7-11ec-ae12-930deab8d014')
const random = Math.random()
let user = {
id: 'USER-ID-ABC-' + random,
email: 'anonymous-' + random +<EMAIL_ADDRESS>name: 'anonymous-' + random,
}
export default ({ store }) => {
if (store.state.auth.loggedIn) {
user = {
id: store.state.auth.user.user_id,
email: store.state.auth.user.email,
name:
store.state.auth.user.first_name +
' ' +
store.state.auth.user.last_name,
}
}
_refiner('identifyUser', user)
}
`

Thanks a lot for providing your solution Oscar. Closing this issue now.


Avoid the listening port conflict of etcd ; 2) kube-controller-manager.service should be started after kube-apiserver.service

Usually we use 2379 as the default port for communicating with other etcd instances, we should use 4001 port to let local etcdctl access etcd contents for preventing port conflicts.
kube-controller-manager.service should be started after kube-apiserver.service. Otherwize, we'll meet

Nov 04 01:31:12 centos7-node-221 kube-controller-manager[963]: F1104 01:31:12.757305     963 controllermanager.go:292] Failed to get api versions from server: Get https://centos7-node-221:443/api: dial tcp <IP_ADDRESS>:443: connection refused
Nov 04 01:31:12 centos7-node-221 kube-controller-manager[963]: E1104 01:31:12.759007     963 nodecontroller.go:154] Error monitoring node status: Get https://centos7-node-221:443/api/v1/nodes: dial tcp <IP_ADDRESS>:443: connection refused

after minions reboot.

@eparis because ansible

Usually we use 2379 as the default port for communicating with other etcd instances, we should use 4001 port to let local etcdctl access etcd contents for preventing port conflicts.

I think your hostname is resolved as <IP_ADDRESS>, so it reports port in use. For most cases, the hostname is resolved as the host's IP, I don't see port conflict in this case. And if you change port to 4001, you should advertise it as well.
@morganwu277 Could you check your host entry and try to remove "<IP_ADDRESS>  $your_hostname" in /etc/hosts, and then etcd again?

@gouyang Actually no, my hostname is resolved as the host's IP.
But because
etcd_listen_client_urls: "{{ etcd_url_scheme }}://<IP_ADDRESS>:{{ etcd_client_port }} configuration is set in kubernetes/contrib/ansible/roles/etcd/defaults/main.yaml
so <IP_ADDRESS>:2379 in the default case, this is why I said port conflict. We should use <IP_ADDRESS>:4001 as candidate local communication port.

personally I think etcd_listen_*_url should just be <IP_ADDRESS> and do away with all of this 127 non-sense. Any objections? Also, no to the controller-manager after api-server. These may not even be on the same computer (someday) and even if they start in the 'wrong' order the system must work. If it doesn't eventually work we need to fix kube, not work around it here.

@eparis YES, reasonable. Different  components should be designed as loose-coupling.

But because
etcd_listen_client_urls: "{{ etcd_url_scheme }}://<IP_ADDRESS>:{{ etcd_client_port }} configuration is set in kubernetes/contrib/ansible/roles/etcd/defaults/main.yaml
so <IP_ADDRESS>:2379 in the default case, this is why I said port conflict. We should use <IP_ADDRESS>:4001 as candidate local communication port.

it's not <IP_ADDRESS> so far, if it's <IP_ADDRESS>, then no need <IP_ADDRESS>:4001.
@eparis etcd_listen_*_url should just be <IP_ADDRESS> is acceptable to me.


test(QUnit 2.0.0)

upgrades the test harness and cases from QUnit 1.14.0 to QUnit 2.0.0, also upgrades asset jQuery to 3.0.0 .

@runspired review ?

@arjunkathuria looks good, rebase against the branch (previous PR has conflicts with this one)


set-realm-config instructions not decoded

See https://dao-beta.mango.markets/dao/SERUM/proposal/FFf16PUCKYZx6PVv6NEgijzQ3hXy1cUbaAzu39R1NvwY

Fixed by https://github.com/blockworks-foundation/governance-ui/pull/89. Without the governance clone registry we have to keep hardening the known clones. The same problem exists in other generic browsers like Explorer


Priority queue error

Your environment.

Version: v0.1.28

What did you do?
jitterBuffer := jitterbuffer.New(jitterbuffer.WithMinimumPacketCount(16))
jbEvent := make(chan struct{})
eventFunc := func(event jitterbuffer.Event, jb *jitterbuffer.JitterBuffer) {
	jbEvent <- struct{}{}
}
jitterBuffer.Listen(jitterbuffer.BeginPlayback, eventFunc)

go func() {
	for {
		select {
		case <-jbEvent:
			{
				packet, _ := jitterBuffer.Pop()
                                    ...
			}
                    ...
		}
	}
}()

go func() {
	for {
		packet, _, err := remoteTrack.ReadRTP()
                    ...
		jitterBuffer.Push(packet)
	}
}()

What did you expect?
It seemed to me that I would receive jitterbuffer.BeginPlayback event whenever the JitterBuffer packet count became 16.
What happened?
func (q *PriorityQueue) PopAt(sqNum uint16) and func (q *PriorityQueue) PopAtTimestamp(timestamp uint32) don't reduce the PriorityQueue length.
It would also be great to have an example of using JitterBuffer in practice.

Another question has appeared. Shouldn't the function func (jb *JitterBuffer) updateState() be implemented like this?
func (jb *JitterBuffer) updateState() {
	// For now, we only look at the number of packets captured in the play buffer
	if jb.packets.Length() >= jb.minStartCount && jb.state == Buffering {
		jb.state = Emitting
		jb.playoutReady = true
		jb.emit(BeginPlayback)
	} else if jb.packets.Length() < jb.minStartCount && jb.state == Emitting {
    		jb.state = Buffering
		jb.playoutReady = false
		jb.emit(StartBuffering)
       }
}

I received the BeginPlayback  event the first time the buffer filled and didn't receive it after the second time the buffer filled.
For example:

the buffer was filled to the minimum for the first time
the BeginPlayback  event was received
N elements were extracted from the buffer
N elements were added to the buffer
the BeginPlayback event wasn't received

Even if you assumed different logic, it seems to me that you need to add q.length-- code to the func (q *PriorityQueue) PopAt(sqNum uint16)  and func (q *PriorityQueue) PopAtTimestamp(timestamp uint32) methods:
For example:
func (q *PriorityQueue) PopAt(sqNum uint16) (*rtp.Packet, error) {
	if q.next == nil {
		return nil, ErrInvalidOperation
	}
	if q.next.priority == sqNum {
		val := q.next.val
		q.next = q.next.next
                q.length--                                   <------- here
		return val, nil
	}
	pos := q.next
	prev := q.next.prev
	for pos != nil {
		if pos.priority == sqNum {
			val := pos.val
			prev.next = pos.next
			if prev.next != nil {
				prev.next.prev = prev
			}
                        q.length--                             <------- here
			return val, nil
		}
		prev = pos
		pos = pos.next
	}
	return nil, ErrNotFound
}

Here's my current usage. And it performs really well on networks with packet loss. I emulate packet loss using a special utility. As you can see, I generally do not allow the buffer size to be less than the minimum. 16 in my case.
func (pi *PionRtcService) remoteTrackRead(ctx context.Context, done <-chan struct{},
remoteTrack *webrtc.TrackRemote) <-chan convert.AudioTrackData {
audioStream := make(chan convert.AudioTrackData)
jitterBuffer := jitterbuffer.New(jitterbuffer.WithMinimumPacketCount(16))

go func() {
	defer close(audioStream)

	for {
		packet, _, err := remoteTrack.ReadRTP()

		if err != nil {
			if err == io.EOF {
				audioStream <- convert.AudioTrackData{Final: true}
				return
			}
			audioStream <- convert.AudioTrackData{Error: err}
			return
		}

		if packet.Padding {
			continue
		}

		jitterBuffer.Push(packet)

	L:
		for {
			jbPacket, jbErr := jitterBuffer.Pop()
			if jbErr != nil {
				if errors.Is(jbErr, jitterbuffer.ErrNotFound) {
					jitterBuffer.SetPlayoutHead(jitterBuffer.PlayoutHead() + 1)
					continue
				} else {
					break
				}
			}

			select {
			case audioStream <- convert.AudioTrackData{Data: jbPacket.Payload}:
				{
					break L
				}
			case <-done:
				return
			}
		}
	}
}()

return audioStream


Question: How to start collecting whenever an ASP.NET request has been executing longer than (n) seconds?

If I understand correctly, StopOnRequestOverMSec will stop collecting whenever a request exceeds (n) milliseconds. Is it possible to somehow use StartOnPerfCounter to start collecting only when an executing requests exceeds a given time?
This information is definitely available. E.g.
%windir%\system32\inetsrv\appcmd list requests /elapsed:5000

For now this will suffice
@ECHO OFF
:START
%windir%\system32\inetsrv\appcmd list requests /elapsed:10000
IF "%ERRORLEVEL%" EQU "0"  (
  REM Run perfview -collect here
  GOTO EXIT
) ELSE (
  ECHO "Nothing to monitor"
  TIMEOUT 5
)
GOTO START
:EXIT


gallery-dl: 1.10.1 -> 1.10.2

Motivation for this change
Updated gallery-dl to 1.10.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Tested locally using nix-review and works fine

@GrahamcOfBorg build gallery-dl


fix: fixed links to specific category in tools section

Description

Added useEffect to scroll to the particular div, if provided.

https://github.com/asyncapi/website/assets/114330931/3e2236d2-e21f-4982-8c1b-d320a81e9485
Related issue(s)

Fixes #2181

@aryanas159 are you still working on it

@sambhavgupta0705 No I'm not, I put a reply above for the changes requested, but I don't think they were reviewed.


Document icon for .rs files doesn't work.

I don't know why. Fix it later. It's not very important.

It is not working. I don't know why and when.


release 2.12.32

Summary | Résumé
This will delete/recreate the system status static website in Terraform.
This will cause downtime and should not be merged until 8pm Wednesday June 19
Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/58

Test instructions | Instructions pour tester la modification
TF Apply works
Release Instructions | Instructions pour le déploiement
https://github.com/cds-snc/notification-attic/tree/main/scripts/sytem-status-static-module-recreation
Reviewer checklist | Liste de vérification du réviseur

[ ] This PR does not break existing functionality.
[x] This PR does not violate GCNotify's privacy policies.
[x] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
[x] This PR does not significantly alter performance.
[x] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

The PR will break existing functionality for ~15 minutes, as part of a planned downtime. Hence the item is not checked on the reviewer's checklist, but is cleared to go.


conversations.convertToPrivate Method

I'm looking into a way to programmatically convert a public channel to private (in order to make something self-service for end users) and it looks like the undocumented conversations.convertToPrivate API method is what the browser calls in order to make a channel private.
It looks like the browser client sends token and channel values through form data in a POST call.

Hey. since your issue has nothing to do with any of the documented API endpoints in this repo, I will need to close it.
To find and answer to your issue I would suggest to open a question on https://stackoverflow.com/questions/tagged/slack-api instead.

I'm not sure I understand; isn't this repository to document Slack's undocumented APIs?
I was asking if conversations.convertToPrivate could be added to the repository, as it is not documented by Slack.

I am sorry, did indeed misunderstand your issue.
however, after looking into this method it seams like it only works with runtime tokens. Those kind of endpoint are out-of-scope of this repo. Please see readme for details.
If you find a ways to work with this method using a user or legacy token feel free to open a new issue.


Warn if a Notifier has public fields

The state of a Notifier should be stored within the state property. It is fine to have an internal state, but no public one.

Some consideration:

visibleForX
protected


backlinks.py also checks stuff that it added

Suppose note A links to note B.

Fixed by putting the backlinks in the frontmatter.


php chat-server.php stuck

i have already do ALL the steps in ratchet tutorial
and when i run php chat-server.php
the cmd stuck and show nothing until the CMD close by it self

Well that's the nature of writing services, they keep running endlessly and wait for something to do. In this case for websocket connections.


Skip some questions

Is your feature request related to a problem? Please describe.
I don't write breaking changes and issues, so I want it not to ask me for them.
Describe the solution you'd like
Set on the config file like this.
breaking_change = false
issues = false

Describe alternatives you've considered
Pass these options to ignore them.
koji --no-breaking-change --no-issues

good idea, will try and get this in this week. want to redo how config works so will probably be part of that.

done. you can now add breaking_changes and issues keys to config as well as pass in --breaking-changes=false and issues=false. they both default to true.
one change that came with this is you can no longer pass --emoji but instead must do --emoji=true. this is because i couldn't find a good way for clap to allow:
koji --emoji       # true  - user passed in
koji               # false - user didn't pass in
koji --emoji=true  # true  - user passed in
koji --emoji=false # false - user passed in

because of how i'm doing config, i need to know whether the user passed anything in or not to know if i should default to the arg value or config value. hopefully not too big of a hassle, tho.


feat: Add an option to turn off the SPA behavior

Fixes #5720

Implemented in https://github.com/vitejs/vite/pull/8217


CDPS-789: Ignore migration records if they are a copy of previous values

Codecov Report
Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (af69b7e) to head (83b9af9).

Files
Patch %
Lines

...gital/hmpps/prisonperson/jpa/PhysicalAttributes.kt
77.77%
1 Missing and 1 partial :warning:

.../dto/request/PhysicalAttributesMigrationRequest.kt
88.88%
0 Missing and 1 partial :warning:

...ice/digital/hmpps/prisonperson/jpa/FieldHistory.kt
87.50%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #49      +/-   ##
============================================
+ Coverage     81.27%   81.47%   +0.19%
- Complexity      319      333      +14
============================================
  Files            55       55
  Lines          1047     1058      +11
  Branches        101      101
============================================
+ Hits            851      862      +11
- Misses          123      124       +1
+ Partials         73       72       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add step to account cancellation process

Added the step of clicking on Account Details. Plan & Billing is no longer is own tab directly under Settings.
Description of the change: Add Account Details to the cancellation workflow
Reason for the change: *Plan & Billing is no longer a tab within Settings in the UI. It follows clicking on Account Details.
Link to original source:

Closes #

Hello @kelseyenglish,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Noise appears when brushes are superimposed

Hello, when you use a marker brush to paint continuously on the canvas, there will be variegated colors. What is the problem?

Hi @Suyens
This is a result of how the color mixing process works, using webgl.
The process introduces make it look more natural, and it can go crazy if you paint many lines on top of each other.
Is it too bothersome for your project? I could see if an option can be added to avoid the noise, but might take a while!

I think it is good in moderation, but yeah, it might be nice to be able to tame it a bit when a lot of overlaps are desired of unavoidable.


chore: bronze sponsor link [skip ci]

GitHub treats non-https-prefixed links as relative paths, resulting in
https://github.com/vuejs/router/blob/main/www.vuejs.de

Thanks!
@antony-k1208 I think you should update the link in your profile to include the https 😛 . I automatically pick the link from there

Oh..my bad. Sorry I've just updated it 💪


Increase size of the star of Vietnam flag

I think the star of Vietnam flag is smaller than it should be.

This is fixed in 04377ea


[PROPOSAL] Add querying functionality

Quick sample about ideas on #24
Add queryable behaviour to translate Ecto.Query structures into Cypher's query.

[proposal]:

QueryBuilder to take place on translating Elixir structs into Cypher string
Neo4Ecto.Cypher to build a Cypher DSL

It seems like a good starting point.
Plus, I'm not sure why we need to call every single module from Ecto.Adapters prefix, I guess calling only the Neo4Ecto main module would be fine. (pros/cons?)


Marketplace extension installation with Azure DevOps Server (RC2)

Just a heads up while waiting for Azure DevOps Server documentation updates: "Install extensions for disconnected TFS" is not valid for Azure DevOps Server (RC2) anymore. Installing an extension downloaded from Marketplace now works like "Pre-installed extensions (first-party) for disconnected TFS"; select an uploaded extension and click "Get it Free" for installation dialogue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 46849bf5-07ed-62cd-66a5-2ebabe449855
Version Independent ID: d12ad05e-4348-f13a-ea35-7bb4761c3b0b
Content: Install extensions for Visual Studio Team Foundation Server (TFS)
Content Source: docs/marketplace/get-tfs-extensions.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

Thank you for the feedback @JukkaAtWork. We will update the page.


Enforce blank lines between class members

This change is effectively a separation of the behaviour for block-bodies vs block-expressions. In doing so, several simplifications were uncovered.

What's GJF's behavior for fields?

What's GJF's behavior for fields?

GJF preserves up to 1 blank line between field declarations.

I would support that behaviour for simple property declarations, but not when there are getter/setter definitions.

I agree.
For many fields (properties) one after the other, forcing newlines seems too much. WDYT?

I appreciate the consistency of "one blank line between each declaration". I also like that it means humans no longer have to chose (I remember spending time debating whether fields were "related enough" to be grouped, and then looking at the code a month later, being to totally indifferent to the choice I made).
However, if you feel like implementing it as part of this merge, that's also fine be me. The main thing is that methods definitely should be spaced.

I totally agree about methods and properties with getters/setters. I'm only concerned about the amount of vertical space it'll add to 'simple' properties.

Do you have an example of a class where spacing the properties makes things worse?

Do you have an example of a class where spacing the properties makes things worse?

I did some ripgrep'ing through Kotlin's own library to find this example: kotlin/IntrinsicType.kt
        // Coroutines
        const val GET_CONTINUATION              = "GET_CONTINUATION"
        const val RETURN_IF_SUSPENDED           = "RETURN_IF_SUSPENDED"

        // Interop
        const val INTEROP_READ_PRIMITIVE        = "INTEROP_READ_PRIMITIVE"
        const val INTEROP_WRITE_PRIMITIVE       = "INTEROP_WRITE_PRIMITIVE"
        const val INTEROP_GET_POINTER_SIZE      = "INTEROP_GET_POINTER_SIZE"
        const val INTEROP_NATIVE_PTR_TO_LONG    = "INTEROP_NATIVE_PTR_TO_LONG"
        const val INTEROP_NATIVE_PTR_PLUS_LONG  = "INTEROP_NATIVE_PTR_PLUS_LONG"
        const val INTEROP_GET_NATIVE_NULL_PTR   = "INTEROP_GET_NATIVE_NULL_PTR"
        const val INTEROP_CONVERT               = "INTEROP_CONVERT"
        const val INTEROP_BITS_TO_FLOAT         = "INTEROP_BITS_TO_FLOAT"
        const val INTEROP_BITS_TO_DOUBLE        = "INTEROP_BITS_TO_DOUBLE"
        const val INTEROP_SIGN_EXTEND           = "INTEROP_SIGN_EXTEND"
        const val INTEROP_NARROW                = "INTEROP_NARROW"
        const val INTEROP_STATIC_C_FUNCTION     = "INTEROP_STATIC_C_FUNCTION"
        const val INTEROP_FUNPTR_INVOKE         = "INTEROP_FUNPTR_INVOKE"

        // Worker
        const val WORKER_EXECUTE                = "WORKER_EXECUTE"

I'd argue this would look worse with uniform newlines everywhere, as opposed to these logical groupings.

I also like that it means humans no longer have to chose (I remember spending time debating whether fields were "related enough" to be grouped

I don't know if I agree this should be outsourced. I go through a similar thought process when it comes to property naming, method ordering, etc. Basically, just because it's fuzzy doesn't mean there isn't meaningful information in there.

I feel like that missed an operative part of the sentence:

and then looking at the code a month later, being to totally indifferent to the choice I made

Regarding kotlin/IntrinsicType.kt, ktfmt is already going to shatter that file. That beautiful handcrafted spacing won't survive 😂
Overall, I don't have a strong opinion on whether property declarations should have separating lines, but in the absence of a strong opinion from someone, I advocate against adding complexity.

I feel like that missed an operative part of the sentence:

Fair enough, but I think my point stands. Sometimes you'll end up indifferent, sometimes not. That's the fuzzy part.

Regarding kotlin/IntrinsicType.kt, ktfmt is already going to shatter that file. That beautiful handcrafted spacing won't survive 😂

I just ran it through the online formatter and got this:
    // Coroutines
    const val GET_CONTINUATION = "GET_CONTINUATION"
    const val RETURN_IF_SUSPENDED = "RETURN_IF_SUSPENDED"

    // Interop
    const val INTEROP_READ_PRIMITIVE = "INTEROP_READ_PRIMITIVE"
    const val INTEROP_WRITE_PRIMITIVE = "INTEROP_WRITE_PRIMITIVE"
    const val INTEROP_GET_POINTER_SIZE = "INTEROP_GET_POINTER_SIZE"
    const val INTEROP_NATIVE_PTR_TO_LONG = "INTEROP_NATIVE_PTR_TO_LONG"
    const val INTEROP_NATIVE_PTR_PLUS_LONG = "INTEROP_NATIVE_PTR_PLUS_LONG"
    const val INTEROP_GET_NATIVE_NULL_PTR = "INTEROP_GET_NATIVE_NULL_PTR"
    const val INTEROP_CONVERT = "INTEROP_CONVERT"
    const val INTEROP_BITS_TO_FLOAT = "INTEROP_BITS_TO_FLOAT"
    const val INTEROP_BITS_TO_DOUBLE = "INTEROP_BITS_TO_DOUBLE"
    const val INTEROP_SIGN_EXTEND = "INTEROP_SIGN_EXTEND"
    const val INTEROP_NARROW = "INTEROP_NARROW"
    const val INTEROP_STATIC_C_FUNCTION = "INTEROP_STATIC_C_FUNCTION"
    const val INTEROP_FUNPTR_INVOKE = "INTEROP_FUNPTR_INVOKE"

    // Worker
    const val WORKER_EXECUTE = "WORKER_EXECUTE"

I think "shattered" is a bit much, it's still perfectly readable. Maybe we should look into preserving space alignment though...

Overall, I don't have a strong opinion on whether property declarations should have separating lines, but in the absence of a strong opinion from someone, I advocate against adding complexity.

I can't tell if you're suggesting we continue with your suggestion of adding separating lines or not 😛

So, should I interpret this as a hard requirement that properties can be on adjacent lines? I don't really want to implement that, but I will if it means getting a fix for spacing between adjacent methods.
I note that there's a big-ish set of cases to consider: every pair of [prop, prop with comment, prop with gettter/setter, prop with annotation, other declaration]

The several folks I asked about this change favored GJF's behavior.
How do others at Google feel about this?

So, should I interpret this as a hard requirement that properties can be on adjacent lines?

Yeah what Carmi said, less of a hard requirement and more trying to understand what looks best. Especially since this would impact a lot of already formatted code, the bar is a bit higher.
For the previous example I gave, that was just in response to "what's a case where this looks worse?". It's still subjective but that's where we're coming from.

Preserved blank lines between properties.


trash dependency fails to build on FreeBSD

On FreeBSD 13 amd64, using the latest available cargo/rustc installed via the system package manager (1.55.0), cargo install dua-cli fails because of the dependency on trash, which has oddly-broken dependencies.
Installing via cargo install dua-cli --no-default-features --features tui-unix works as expected.
error[E0432]: unresolved import `chrono`
  --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:18:5
   |
18 | use chrono::{NaiveDateTime, TimeZone};
   |     ^^^^^^ use of undeclared crate or module `chrono`

error[E0432]: unresolved import `scopeguard`
  --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:20:5
   |
20 | use scopeguard::defer;
   |     ^^^^^^^^^^ use of undeclared crate or module `scopeguard`

error: cannot determine resolution for the macro `defer`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:645:5
    |
645 |     defer! { unsafe { libc::fclose(file); } }
    |     ^^^^^
    |
    = note: import resolution is stuck, try simplifying macro imports

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
  --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:37:28
   |
37 |         let uid = unsafe { libc::getuid() };
   |                            ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
  --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:80:24
   |
80 |     let uid = unsafe { libc::getuid() };
   |                        ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `chrono`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:193:32
    |
193 |                     let time = chrono::Local.from_local_datetime(&naive_local).earliest();
    |                                ^^^^^^ use of undeclared crate or module `chrono`

error[E0433]: failed to resolve: use of undeclared crate or module `chrono`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:420:27
    |
420 |                 let now = chrono::Local::now();
    |                           ^^^^^^ use of undeclared crate or module `chrono`

error[E0433]: failed to resolve: use of undeclared crate or module `url`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:535:12
    |
535 |     return url::Url::parse(&url).unwrap().to_file_path().unwrap().to_str().unwrap().into();
    |            ^^^ use of undeclared crate or module `url`

error[E0433]: failed to resolve: use of undeclared crate or module `url`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:539:15
    |
539 |     let url = url::Url::from_file_path(absolute_file_path.as_ref()).unwrap();
    |               ^^^ use of undeclared crate or module `url`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:635:18
    |
635 |         unsafe { libc::fopen(mounts_path.as_c_str().as_ptr(), read_arg.as_c_str().as_ptr()) };
    |                  ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:638:25
    |
638 |         file = unsafe { libc::fopen(mtab_path.as_c_str().as_ptr(), read_arg.as_c_str().as_ptr()) };
    |                         ^^^^ use of undeclared crate or module `libc`

error[E0433]: failed to resolve: use of undeclared crate or module `libc`
   --> /home/mqudsi/.cargo/registry/src/github.com-1ecc6299db9ec823/trash-2.0.2/src/freedesktop.rs:648:31
    |
648 |         let mntent = unsafe { libc::getmntent(file) };
    |                               ^^^^ use of undeclared crate or module `libc`

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `trash` due to 12 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `dua-cli v2.14.11`, intermediate artifacts can be found at `/tmp/cargo-installt6Zof6`

Caused by:
  build failed

trash appears to have a Linux-only dependency on chrono  but blindly uses it on all platforms that use the Freedesktop trash interface, causing the missing dependency.

Thanks so much for digging into this!

EDIT: I just realized your the author of both. That makes this a lot easier, lol.

Actually, @ArturKovacs is the author, but I stepped up as maintainer of the crate. In any case, it makes fixing this a lot easier :).
As a matter of fact, trash was just re-released with a fix.
I hope this works, please let me know.

I can confirm dua-cli builds fine on FreeBSD 13 with all features, and trash appears to work.

Thanks for letting us know. Closing.


Resolve circular reference: Equity.Test and Option.Test

Currently, Equity.Test depends on Option.Test (originateEuropeanPhysicalOption in the rights issue / subscription scenario)
Similarly, Option.Test should use code in Equity.Test (originateEquity for physically settled equity options).
For now, the more general originateInstrument is used instead.
Decide whether this is fine or if we want to model this differently.

The current solution has the advantage that the more general originateInstrument can represent various instrument types, not only equity.


Add processing of PUT request for Allergies Heading

Add processing of PUT request for Allergies Heading

thanks @anna-otrokhova
helpful to have that here,
suggest you also need to link this to the related issue on QEWD-Ripple, as there is a dependency there that Rob needs to address
please take a look here;
https://github.com/RippleOSI/Ripple-Qewd/issues
this may be the one you need to link to..
https://github.com/RippleOSI/Ripple-Qewd/issues/39
Always worth considering if existing/new issue needs to be linked elsewhere from issues raised here
thanks
Tony

@tony-shannon
This issue was fixed only on React version for now.
Tony, can I close this issue here?

yes
thanks


Remote-ssh : ssh remote host error with : Access Denied.

I have tested ssh connection on powershell and it showed success.

Then I add a config at .ssh folder

use remote ssh command with that config, and I set "remote.SSH.showLoginTerminal": true

After inputting the absolutely right password, i got

Does it work if you don't use a @ in your ssh config? That is the syntax for connecting to that IP with the user "Vultr"

Does it work if you don't use a @ in your ssh config? That is the syntax for connecting to that IP with the user "Vultr"

it seems like works. By the way, if i didn't make a misunderstanding, the string after HOST should be the name of the specified ssh config? So why the Vultr will be resoved as a username? In fact, the Vultr is the VPS supplier instead of my VPS username.
So, if that is the design of VSCode, i' ll close this issue. Please let me know if that's a bug.
Thanks for your reply.

it seems like works. By the way, if i didn't make a misunderstanding, the string after HOST should be the name of the specified ssh config? So why the Vultr will be resoved as a username? In fact, the Vultr is the VPS supplier instead of my VPS username.
So, if that is the design of VSCode, i' ll close this issue. Please let me know if that's a bug.
Thanks for your reply.

Yeah, I think this is the design of SSH, not just vscode. I can't figure out how to escape the @ so that ssh would treat it as part of a host name instead of a user/host separator

Yeah, I think this is the design of SSH, not just vscode. I can't figure out how to escape the @ so that ssh would treat it as part of a host name instead of a user/host separator


python3Packages.lmfit: init at 1.2.1

Description of changes
Adds a new python package. Yay, more packages!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable: Unit tests run, basic usage works.
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Upstream confirms that the skipped test cases are ok to skip: https://github.com/lmfit/lmfit-py/issues/878

Thanks for the review and suggestions!

Result of nixpkgs-review pr 230865 run on x86_64-linux 1

4 packages built:

python310Packages.lmfit
python310Packages.lmfit.dist
python311Packages.lmfit
python311Packages.lmfit.dist

Thank you!


Rebranding

This PR is applying Sauce Labs' new design system to Docs

@discombobulateme ~ In dark mode, the content in the box cards is not visible as the text is white on a white background.

Can we fix this?

@discombobulateme  ~ Are the colour contrasts for light and dark mode compliant with WCAG? Is that something that we check for?

@discombobulateme ~ We should also update the 404 error page.

Consider updating the  Collapsible text block . It is still style with blue:


Hero unit doesn’t load images if app was launched with connection error.

What does "launched with connection error" mean? That the original request resulted in an error, or that the user had no internet connection?

The latter. So:

Disable your wifi
Launch app
Enable wifi
App dismisses the ‘no connection’ screen or you do so yourself with the refresh button
No hero units on home screen

I see. Looks like it's related to keeping the view controllers in the hierarchy, even when they're not visible. This is an issue we've discussed before – since we keep them in the hierarchy, unlike a UITabViewController, their viewWillAppear: etc methods aren't called directly.
I know that removing them/readding them complicates the orientation changes on iPad, but I still can't help but feel like there's a better solution that we're not seeing.


[BEAM-115] Move expansion of Window.Bound into particular runners

As per the Runner API design this makes Window.into very explicitly a primitive, and moves the subsidiary primitives to top level classes in the util/ (aka miscellaneous) directory, eventually to move to some appropriate final location for "runner utilities" or to be removed entirely.

R: @tgroh for in-process runner
R: @bjchambers for Beam committer

LGTM -- suggestions for future improvements, but not necessary in this PR.

LGTM


Improving and extending HiCExplorer tutorial

Adding Pearson matrices and PCA tracks
Adding loop detection

ping @bgruening Needs to be merged for the Thursday Hi-C Galaxy course.

@bgruening Done.

Thanks.


Replace current linting packages with Ruff

Can I make this change?
Description
New package that has recently been implemented by other major packages such as FastAPI and Llama Index
Why is this needed
Performance increase is overwhelmingly better than the alternative.
https://docs.astral.sh/ruff/
Implementation details
Simple change to make file with respect to linting.
End result
CI

Does Ruff have a vscode plugin?

Yes

As long as it's low to no touch on the src code and can apply the same rules we currently have I'm cool with it.
@irgolic @zsimjee @ShreyaR Thoughts?

@CalebCourier little change from black outside of performance gain.
Info about the package: https://docs.astral.sh/ruff/
Here's a recent implementation I've done for Pydantic, we're waiting on the next version release to merge.
It should come out today. https://github.com/pydantic/pydantic/pull/7930

Thanks for flagging @Luca-Blight! No issues from my end cc @CalebCourier

@Luca-Blight sorry for the long cycle on this.  If you wanted to put in a PR for these changes feel free. Thanks for contributing!

gh actions and the precommit is using ruff now? Going to close this. Please feel free to reopen if I'm mistaken.


Update Sony - PlayStation (Redump).json

Sorry for the absence, I was kinda busy ^^;
GG again for Retool 2.0, I'm playing with it ATM.

Good to see you! Welcome back :)

Do I have to create a group for Kamen Rider V3 too?

Do I have to create a group for Kamen Rider V3 too?

Only if the title called "Kamen Rider" is different.
See the PlayStation 2 overrides section for how to achieve this.

Thank you UP for the explanations and your GREAT patience u_u

BTW, we have a strange case with Ghost in the Shell...
The game was dubbed in french and german for those countries but texts weren't translated. Redump don't add the countries flag when the text isn't translated so, even if I choose to have games in french and fall back to US when it's not translated, GitS (France) is skipped for GitS (USA). Do we have to edit the metadata?

Thank you UP for the explanations and your GREAT patience u_u

Thanks for your contributions! I'm really stoked each time I see one :)
This one is good too, because it highlights where I can make things easier for people to contribute. In this instance I've realized that I can probably get away with not changing the group names in clone lists -- which would make things much less confusing for everyone. I'll look into it.

BTW, we have a strange case with Ghost in the Shell...
The game was dubbed in french and german for those countries but texts weren't translated. Redump don't add the countries flag when the text isn't translated so, even if I choose to have games in french and fall back to US when it's not translated, GitS (France) is skipped for GitS (USA). Do we have to edit the metadata?

So, repeating what you're saying to make sure I understand correctly: Ghost in the Shell (France) is marked by Redump as being in English, but that's only because text in the game is in English, while the voicework is dubbed in French or German (or at least, those dubs are available).
The only scenario where you should still get the USA variation chosen over the French one (even if you prefer French over English as a language) is if USA is higher in your region order than France. If you've set up Retool differently and are still seeing the USA version selected, I'd be interested to know your settings.
Assuming you've configured Retool that way, this is a tough problem. We can't edit the metadata to change the languages, as it's overwritten each time I scrape Redump's site. I've also historically resisted turning Retool into a language database, preferring to fix the issue at the source, but the problem here is the language standard both Redump and No-Intro follow. Both fail to differentiate between text used in the game, subtitles, and voicework for languages. Both don't indicate what the default language of the title is, assuming there is one (and this can be tricky, as I believe some can switch the default language depending on the region the console is in).
Supporting this sort of functionality in Retool isn't a small thing, and requires a lot of verification work. I'll think about it, but at the minimum all the data would have to be community-supplied. For now, unfortunately we're stuck with this suboptimal situation.

Exactly! I've setted USA in a higher order than France but placed french language on top so I can get the best of the two worlds (NTSC games that have FR in their languages, NTSC games when games are in english only and PAL games when they're the only ones translated in FR).
For GitS, the way that game works is sick... GitS (France)/(Germany) has french/german voiceover without subtitles (and there's A LOT of cutscenes and briefings) but the texts are in EN.

Totally makes sense :)
I don't think I can work around it the way things are built currently, and there's a lot of complexity and work in supporting the different ways languages are presented. The only way forward at the moment is to add your own system override to remove the GiTS titles you don't want.
I'll mark it down as a problem title though, and should I get around to looking at a larger language project, I'll make sure it's considered.


Toggles are positioned wrong when 'slidingSubmenus' option is set to false.

If 'slidingSubmenus' option is set to false and toggles add-on is enabled, opening a child menu changes the position of the toggle button of the parent.

My workaroun/solution for this issue is
---
 src/scss/addons/jquery.mmenu.toggles.scss | 3 ++-
 src/scss/jquery.mmenu.oncanvas.scss       | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/scss/addons/jquery.mmenu.toggles.scss b/src/scss/addons/jquery.mmenu.toggles.scss
index 9bc6fc5..bb9cfa1 100644
--- a/src/scss/addons/jquery.mmenu.toggles.scss
+++ b/src/scss/addons/jquery.mmenu.toggles.scss
@@ -17,7 +17,6 @@ label.mm-check
 {
 	margin: 0;
 	position: absolute;
-	bottom: 50%;
 	z-index: 2;

 	&:before
@@ -34,6 +33,7 @@ label.mm-toggle
 	width: $mm_toggleWidth;
 	height: $mm_toggleHeight;
 	margin-bottom: -( $mm_toggleHeight / 2 );
+    margin-top: ($mm_btnSize - $mm_toggleHeight) / 2;

 	&:before
 	{
@@ -53,6 +53,7 @@ label.mm-check
 	width: $mm_checkWidth;
 	height: $mm_checkHeight;
 	margin-bottom: -( $mm_checkHeight / 2 );
+    margin-top: ($mm_btnSize - $mm_checkHeight) / 2;

 	&:before
 	{
diff --git a/src/scss/jquery.mmenu.oncanvas.scss b/src/scss/jquery.mmenu.oncanvas.scss
index 4267aad..6a8625a 100644
--- a/src/scss/jquery.mmenu.oncanvas.scss
+++ b/src/scss/jquery.mmenu.oncanvas.scss
@@ -103,7 +103,7 @@
 .mm-listview .mm-vertical .mm-panel
 {
 	display: none;
-	padding: $mm_padding 0 $mm_padding $mm_padding;
+	padding-left: $mm_padding;

 	.mm-listview > li:last-child:after
 	{
--

Thanks for pointing this out to me.
This same issue occurred with the ">" arrows, I fixed this by using a similar calculation for vertical submenus only.
Note that $mm_btnSize is the default height for list items with a single line of text, if a second line of text is added (with a <br /> or when the multiline extension is used), this calculation will not center the toggles.
Anyway, I'll implement the fix it in the next version.


Connecting to BOSH

When connecting to BOSH, I am getting:
x509: cannot validate certificate for X.X.X.X because it doesn't contain any IP SANs

I have executed bosh_exporter command like this:
/var/go/bin/bosh_exporter -bosh.url $BOSH_EXPORTER_BOSH_URL
-bosh.username $BOSH_EXPORTER_BOSH_USERNAME
-bosh.password $BOSH_EXPORTER_BOSH_PASSWORD
I have also added bosh.ca-cert-file flag at the end of command and placed a valid BOSH certificate, but I am getting the same error message. Any idea?

The certificates must be created setting a Subject Alternative Name (SAN) with the IP address of the BOSH director, otherwise, you will get the cannot validate certificate for X.X.X.X because it doesn't contain any IP SANs error message.
This exporter is using the golang bosh-cli director libraries, and unfortunately, there is no way to disable this validation (without creating my own bosh golang library). More details at https://github.com/cloudfoundry/bosh-cli/issues/19.
Here there is an example of how to create valid BOSH certificates: https://github.com/cloudfoundry/bosh-lite/blob/master/ca/generate.sh

@frodenas, thanks! :-) I will try that out and come back to you with the result.

We have created a certificate by setting a Subject Alternative Name (SAN) with the IP address of the BOSH director, following the script you have suggested: https://github.com/cloudfoundry/bosh-lite/blob/master/ca/generate.sh (of course we have modified the line with ip variable, where we have put our Bosh Directors IP address).
The certificates have been successfully created. In fact, when we execute the script, the following files are being generated:

ca.crt
ca.key
ca.srl
director.crt
director.key

We have then placed the certificates on the Docker instance, where the bosh-exporter is running, but we are still getting the same error message:
x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs

@frodenas, any idea what we could be doing wrong here?

@RobiD  Have you redeployed your BOSH director with the director.crt and director.key files?
I've added a section at the FAQ explaining how to generate/deploy the SSL Certificates: https://github.com/cloudfoundry-community/bosh_exporter/blob/master/FAQ.md#how-can-i-get-the-bosh-ca-certificate

@frodenas, thanks for your prompt answer and a link to FAQ! I guess, this is the step we have been missing. We will try to redeploy BOSH early next week using director.crt and director.key files. Will keep you updated.

ok, I'll keep this issue open until you test it.

I try it, and this fix the issue.
Just need to follow the bosh.io docs and add the cert into bosh exporter using the right properties.

Closing this. @RobiD please reopen if it doesn't work or you need some help with the ssl keys.


Add Deepa's file

This is a test pull request and am adding comments.
test.txt

Testtetstestesrwerwer

Reopened to commit.


JS PDF multiple url in default_url (viewer JS)

https://paste.ee/p/Ep7jF
Basically I just revised the default_url variable only, but how to create an array through that paste link I've made? To show multiple PDF files into the pre-made Viewer? (JS.PDF API)
This is one (https://stackoverflow.com/questions/9809001/is-there-a-way-to-combine-pdfs-in-pdf-js) is more on canvas and cannot solve on my current problem.
var DEFAULT_URL = 'https://cors-anywhere.herokuapp.com/http://<IP_ADDRESS>:8020/SuperContainer/RawData/Library/Catalog/Items/2744?a=0';
Is it possible to make it array? what are the changes I will do?
https://imgur.com/a/vF8MWKZ
Thank you

The viewer does not support loading multiple files at once, so I think the only way is to follow the advice on that Stack Overflow link to simulate that by rendering the files below each other.

Oh I see but is there any plans in the future for pdf.js?

Not for this particular feature, since its use case is limited, especially for usage in e.g., Firefox.


parameterization for createFromCategory

parameterization for createFromCategory

Thank @MrSilaz, after the changes I will add it to the next release

I corrected it myself for the parameter in the new release


Footer Prop

It would be great to have a Footer prop that allows for a parallax footer, revealed behind the scrollview or listview.

I agree! This would be nice to see. For example and what I find a common design practise is to have a location map at the end of a screen. It would be nice to allow this to grow as the header does when you scroll past the bottom!

+1


Need a Support quickly

How to use another events except InventoryClickEvent one's?

You can use a Listener as normal, the built-in SGMenuListener shows how this can be done.
Specifically, you can see on lines 87 - 95 how to test if an inventory is an SGMenu and how to get the SGMenu in question:
https://github.com/SamJakob/SpiGUI/blob/edde839de579038fd2f5c1135c2c9cb1fb2a7c46/src/main/java/com/samjakob/spigui/menu/SGMenuListener.java#L87-L95


ReprCString should have drop, like CVec

If ReprCString is analogous to Rust's String and owns its own memory, it needs a drop method just like CVec. As it is currently, passing ReprCString to the C side will leak because it has no way to free the string.

This is true, thanks for reporting! Generally it's a bit tricky, because it's meant to kind of mimic regular C char * strings, so I'm not set whether it's a good idea to add a drop with each string, or make sure each string is allocated with malloc.


Xcode 8 issue in RCTWebSocket

Two seemingly easy to fix bugs when updating to Xcode 8:
In RCTWebSocket > RCTSRWebSocket.m:
On two occasions the function is used: SecRandomCopyBytes
Xcode doesn't like that the return value is ignored:
/*!
@function SecRandomCopyBytes
@abstract Return count random bytes in *bytes, allocated by the caller.
It is critical to check the return value for error
@result Return 0 on success or -1 if something went wrong, check errno
to find out the real error.
*/

The actual error: /Libraries/WebSocket/RCTSRWebSocket.m:494:3: Ignoring return value of function declared with warn_unused_result attribute

What's the version of react-native-macos is this? Tthis error should be fixed in 0.10.0

Ahh snap, I rolled back after a previous bug and forgot to update after your fix.


Clarify sub-06 in fLoc

Currently, the fLoc README describes only sub-01, sub-02, and sub-03 participating in the fLoc tasks.
However, sub-06 is also in the accompanying roi folder. To a naive user (me) this is unexpected and surprising. It would be great to clarify this in the README !

Done!
https://github.com/courtois-neuromod/cneuromod-things/tree/main/fLoc
Since sub-06 could not do the task, I swapped the fLoc GLM contrast with the noise ceilings I estimated w GLMsingle to define subject-specific ROI boundaries around voxels sensititve to stimulus content, but constrained within group-derived parcels from the Kanwisher lab. I identified the noise ceiling masks a bit differently (I replaced stats-tscores with stats-noiseCeil) under cneuromod-things/fLoc/rois/sub-06/rois/task-derived.


[Question] What is the license for your code?

Thanks!

It is MIT after adding it this morning..... :) @Talderon

Awesome, thanks for getting back to me so quickly!


Update Composer dependencies (2024-04-17-00-10)

Visual regression test passed!
View the visual regression test report


When I update the vscode-icons from 1.9.0 to 1.19.1, this issue happens. The icons are all disappear

I'm using Visual Studio Code Version [1.4.0] [Stable/Insider]

I'm using the extension version [1.9.1]

My system is: [OS x]

How can this happen ?

When I update the vscode-icons from 1.9.0 to 1.19.1, this issue happens. The icons are all disappear.

Please read the README.
You need to enable the icons, so please execute Icons Enable

I have clicked "icon enabled" and "icon update". But it doesn't work

Do you have steps to reproduce?

NO, I never reproduce anything.

You misunderstood. What did you do? Is it a clean install?

I just click the update btn, it works well before.

I don't modify any config of this ext

Are you behind any proxy?

yes, I have proxy

ok, I'll try.

Can you check out this issue? https://github.com/robertohuertasm/vscode-icons/issues/21#issuecomment-232577432 Maybe you're done a mistake?

@fantasyKing I have the same issue. here is how I solved it:

Make sure you have permission to vscode install folder(/usr/share/code)
Icon Update
Restart
Icon Enable

@leido  I've met the same problem right now...
Windows 7 x64, tried vscode 1.4 & 1.5.1, not work.

@leido  I've met the same problem right now...
Windows 7 x64, tried vscode 1.4 & 1.5.1, not work.
All right, find out that sometimes the "icons.zip" could not be downloaded correctly, which causes the issue.

@nonoroazoro Are you behind any proxy? Is there any error in the Dev console?

@jens1o  I've tried both with and without proxy, the problem still occurs. After several attempts to update the icons, my vscode downloads the "icons.zip" correctly.
I didn't see any error in the Dev console, but at least it works now. Thanks!

How to open Dev console? @jens1o

I solve this problem: "vsicons.icons": "/Users/zhangguojin/programFile/icons.zip" in settings

@fantasyKing take into account that you won't be receiving new icons by using this method so you will have to manually update the icons.zip from time to time. The fact that you're not able to download the zip via extension may be due to proxy issues or permission issues. If you feel this issue is solved then please close it.

The last update made my icons desappear.
I tried this but doens't solved:
"vsicons.icons": "/Users/rmestre/vscode/icons.zip" (the icons.zip its there!)

Hey guys, I'm facing the same problem too.
The latest update (v1.5.1) from VSC made my vscode-icons icons dissapear, I'm guessing is related to the fact that on this version we can choose which icons to use from the menu bar as a theme:

The thing is that your vscode-icons sets is not listed on the menu options and I have already installed the extension

@lachama, we're preparing a new version with official support (so you will be able to see it also in the file icon theme menu soon). Despite this, we're still supporting the old functionality so you have to unselect whatever icon theme you have selected (select None) and then execute the icons enable command.
Let me know if it works for you.

@renatomestre have you solved you issue? Try with the latest extension update 2.0.1

@renatomestre, @lachama, @fantasyKing please let us know if you've solved the issue. I will close the issue in case on Monday I have no news from you. :wink:

@renatomestre ,yes, I'm already fixed it.

@robertohuertasm sorry I couldn't reply earlier. It's working nicely now ;)
Thanks!

@robertohuertasm its working! Thank u so!


Development: expand .editorconfig

Checklist
General

[x] This is a small issue that I tested locally in my IDE.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

We have multiple code scanning tools that complain about our usage of star imports or other formatting issues, making it hard to spot any real findings that should be taken care of.
Description
I exported the default editor configuration of Intellij and removed everything I could see that did not make sense for us. The only values that I changed is the usage of star imports to 1000 to prevent teamscale findings and coderabbit comments.
I do not intend to tell you how to format your code, I'd very much like this editor config to be a living document and be changeable by all. After all its just formatting and easily changeable.
Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Summary by CodeRabbit

Refactor

Updated the .editorconfig to improve code formatting standards, including line length and tab width adjustments.

Chores

Added specific .editorconfig settings for Liquibase changelog files to prevent reformatting issues.
Included a new .editorconfig in the test resources to address potential formatting-related test failures.

Hi @Hialus,
Thanks for the input.

I wasn't entirely aware that we are using Spotless for formatting; I knew that we use pre-commit hooks but didn't look into the tool behind it. I assumed the editorconfig was enforced - it turns out I was wrong.
I don't think this version of the editorconfig will collide with our JS Linters, as I only added stuff for Java and Python; the [*.java] or [*.py] headers inside the file indicate that.
IMHO We should not necessarily stick to custom linter rules; I see no benefit in that. We probably use Teamscale for a reason. If we don't want to ignore ca. 1700 bad practice findings, then either we need to revisit the custom rules or make every linting tool (spotless, coderabbit, teamscale, etc.) aware of those, right now actual findings go unnoticed because of the vast amount of false-positives.

What would you say if I revert all of the lines apart from the increased star import limit (as established in the last meeting, we want to eliminate the magic number of 4, my original intention with this PR) and thus hopefully make Teamscale helpful?
What do you think?

@Hialus, I removed everything except the changes to the usage of star imports. I also aligned the import order specified by Spotless. Now, if you optimize the imports using IntelliJ, it will expand them and remove the lines between the groups (didn't find anything for that). Spotless will validate the imports and readd the blank lines in between. I also couldn't find a setting for Spotless to replace star imports, but I guess with this setting, our code should produce fewer false positives.

I'm not sure if I understood the changes / goals right. My current understanding is the following:
The goal of this PR is to change our approach to star imports in order to get rid of teamscale and coderabbit warnings.
You accived this by changing the editorconfig threshold for start imports, but without touching the spotless configuration.
This means that if I change a file with star imports in one of my PRs, nothing will happen for now, and no tool will complain. The star imports will only get removed when using the "optimize imports" feature of IntelliJ.
At least in my workflow, the IntelliJ formatter does not play a role. If I want to reformat the code, I quickly execute spotless.
This means that in this form this change will create an inconsistent code style, depending on the current workflow of the developer. I'd like to avoid this.
Please check if you can enforce star import rules via spotless. Then violations will be automatically corrected in the pre-commit-hook and would lead to a failure in the server-style check. The editorconfig file in its current form is not meant to define its own rules, but instead to translate existing rules to the IDE which will then reduce the changes spotless needs to perform.
Regarding the PR size: If the configuration change is small (e.g. only one changed rule), I'm ok with bigger PRs (considering LOC) which enures a consistent code base. But I also agree with Timor, we should touch only 1-2 rules in such PRs to keep them reviewable.

Hi @Strohgelaender,
sorry I didn't reply earlier.
You're right. My goal/idea is to gradually phase out star imports as they keep causing false positives and leading to a complete neglect of real findings.
As I couldn't find a way to use Spotless only for changed files of a commit, I would rather merge these changes that prevent new ones and after some time, apply the config for all files that are left. This would decrease the potential merge conflicts and developer time for those changes.
I agree that this results in a temporarily inconsistent code styling, but after all, it's just imports


[CHAT-3081]: Veracode naming

Currently Veracode has issues and the scans are taking very long time to complete. The PR will be merged because the change is only in the github workflows and the Veracode scan is started with the correct parameters.


Update service-parent to version 4

The latest image does not work in devel instance when I test the build, but works locally. Upgrade the service-parent to 4 and let's see if there are some lib issues.

Close as above.


Running into link errors on Windows

After fixing a bunch of configuration-related compiler errors, I was presented with this:
note: C:\users\austin\Rust\gdk\target\debug\deps\libglib-fcaf29643d8f5d21.rlib(glib-fcaf29643d8f5d21.o): In function `glib::permission::Permission::get_allowed':
C:\msys64\home\Austin\.cargo\git\checkouts\glib-27833b4b6d67ca46\master\src/permission.rs:27: undefined reference to `g_permission_get_allowed'
C:\users\austin\Rust\gdk\target\debug\deps\libglib-fcaf29643d8f5d21.rlib(glib-fcaf29643d8f5d21.o): In function `glib::permission::Permission::get_can_acquire':
C:\msys64\home\Austin\.cargo\git\checkouts\glib-27833b4b6d67ca46\master\src/permission.rs:34: undefined reference to `g_permission_get_can_acquire'
C:\users\austin\Rust\gdk\target\debug\deps\libglib-fcaf29643d8f5d21.rlib(glib-fcaf29643d8f5d21.o): In function `glib::permission::Permission::get_can_release':
C:\msys64\home\Austin\.cargo\git\checkouts\glib-27833b4b6d67ca46\master\src/permission.rs:41: undefined reference to `g_permission_get_can_release'
C:\users\austin\Rust\gdk\target\debug\deps\libglib-fcaf29643d8f5d21.rlib(glib-fcaf29643d8f5d21.o): In function `glib::permission::Permission::impl_update':
C:\msys64\home\Austin\.cargo\git\checkouts\glib-27833b4b6d67ca46\master\src/permission.rs:48: undefined reference to `g_permission_impl_update'
C:\users\austin\Rust\gdk\target\debug\deps\libglib-fcaf29643d8f5d21.rlib(glib-fcaf29643d8f5d21.o): In function `glib::value::Value::new':
C:\msys64\home\Austin\.cargo\git\checkouts\glib-27833b4b6d67ca46\master\src/value.rs:36: undefined reference to `create_gvalue'

The g_permission functions are defined by the GIO library, a separate lib and link unit on Windows. And then create_gvalue() is an internal function not exported in the GLib headers, at least for me.
This is with the latest Windows x64 release of GTK from here.
Possible solutions:

Move the g_permission functions to a gio-sys crate that links to -lgio-2
Use g_value_init() instead of create_gvalue()

Erf... I don't develop under Windows so I can't help you on that... Just make a PR with your preferred solution (or maybe someone else has an idea on how to resolve this ?).

The gio problem we could plug by asking to link to gio in the gtk-sys build script.

I'm just thinking that we could split out gio from glib. It would seem more logical since we split out every library.

It seems there's very little substance to gio right now and it's unlikely to grow soon.

Yep but it'll certainly grow. By splitting it out of glib, we avoid any potential problem like that in the future.

I'm not sure I understand what kind of problem that would be. glib comes bundled with gio, gmodule, gobject and gthread on my system and there's little reason to pretend that they're usable separately.

Hum, I didn't saw that... Then yes, let's just ask to link to gio in the glib-sys build script like you proposed @gkoz.

https://github.com/rust-gnome/glib/pull/12 should fix the gio problem.

I merged it. Can you confirm it's fixed now @cybergeek94 ?

I'm working on fixing the GValue.

The g_permission functions are fixed for me now. Just create_gvalue() is left.

That would be https://github.com/rust-gnome/glib/pull/13 and https://github.com/rust-gnome/gtk/pull/35

And they're both merged.

Link errors are fixed on my end. Good job!


Support relative path for ES information

Kibana has a config.js file that let's you specify where  your ES instance is running.  In my case, I have nginx in front of ES and am trying to open up only certain paths to certain users.  My goal is to be able to host kopf at:
https://host/admin/
I succesfully have all the static assets being returned; I just do redirect so that /admin/ turns into /_plugin/kopf/ on the ES machine.  However, Kopf expects ES API to start at /, but I really want it to start at /es/.  Is this possible?
Better yet would be if I could run Kopf in my local browser and just point to a remote instance, but I feel like CORS stuff is going to prevent that.

so...how do I make use of this? Some documentation would be nice.

@MarkMurphy Something like this:
Edit kopf_external_settings.json:
{
    "elasticsearch_root_path": "/adminaccess/",
}

Then, in your web server proxy (nginx, apache) perform redirect.  This example is with Apache:
  <Location /adminaccess/>
      ProxyPass http://<IP_ADDRESS>:9200/
  </Location>

Your user can now go to http://elk_server/adminaccess/ and reach kopf.


Append data to next open column instead of row?

Is there a way to loop through data and append the results to the next column with a custom header, instead of the next open row?  Thanks!

Can you post an example of what you're looking to do? This is for an already existing Excel file?

Actually I figured it out!
I set
$column = 1
for the start of the script.
Then I start my loop and for the first time I use export-excel, I use
-startcolumn $column and then the next line of code is $column =
$column+1.  So the next time through the results go to the next column and
so on.
I did have another question though - what is the easiest way to center data
horizontally in a column?  I've looked at different examples and it seems
complex for what I'm trying to do. I just have certain columns where I'd
like the data centered in the cell.  Thanks.
On Thu, Mar 19, 2020 at 3:12 PM Doug Finke<EMAIL_ADDRESS>wrote:

Can you post an example of what you're looking to do? This is for an
already existing Excel file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/805#issuecomment-601393624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHOVBKZCUQNVOYCA5VUPVGDRIJ4BFANCNFSM4LPSDHNA
.

You can use -HorizontalAlignment Center on the Set-Format function.
https://github.com/dfinke/ImportExcel/blob/12fa49e3142af2178ae1c6b18d8c757af0d629ac/Examples/ExcelBuiltIns/DSUM.ps1#L20

I saw that option, but am not sure how to add it to my scripts.
I usually gather all kinds of data and then put it into a variable and so
at the end of my script it looks like this:
$Data | Export-Excel $results -worksheetname "something" -autosize
-autofilter -boldtoprow -append
How would I use the set-format function for this example?
On Thu, Mar 19, 2020 at 3:54 PM Doug Finke<EMAIL_ADDRESS>wrote:

You can use -HorizontalAlignment Center on the Set-Format function.
https://github.com/dfinke/ImportExcel/blob/12fa49e3142af2178ae1c6b18d8c757af0d629ac/Examples/ExcelBuiltIns/DSUM.ps1#L20
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/805#issuecomment-601411726,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHOVBK4NLIKLIM2HCMXGV3TRIKA63ANCNFSM4LPSDHNA
.

In that sample, it uses -PassThru. Then you have access to the Excel document and you can use set-format to change the columns.
There is no option on the Export-Excel function to set that.


Expose completion entry symbol for plugins API

Suggestion
🔍 Search Terms

languageService.getCompletionEntrySymbol
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Hi! I don't have very deep knowledge of TS internals, but it seems very obvious that completion entries are coming from symbols and getting that symbol information per entry is not possible in any way (calling getCompletionEntrySymbol for every entry seems to be inefficient inside of getCompletionsAtPosition as it calles it).
📃 Motivating Example and 💻 Use Cases
plugin
Probably absolutely any plugin that wants to improve or change existing completions lists, so I can imagine hundreds of hundreds use cases. But I have a few real world cases that I really need sometimes. For example removing marking (or even removing some) global symbol completions:
const isLibCompletion = (symbol: ts.Symbol) => {
    const fileName = symbol.declarations?.[0]?.getSourceFile().fileName
    if (!fileName) return
    if (!fileName.includes('node_modules/typescript/lib/')) return
    return basename(fileName).slice(0, -'.d.ts'.length)
}

let prior = languageService.getCompletionsAtPosition(fileName, position, options)
if (!prior.isGlobalCompletion) return
entries.map(entry => {
    if (entry.sourceDisplay) return entry
    const symbol = entry['symbol'] as ts.Symbol | undefined
    if (!symbol) return entry
    const libCompletionEnding = isLibCompletion(symbol)
    if (!libCompletionEnding) return entry
    return {
        ...entry,
        labelDetails: {
            ...entry.labelDetails,
            description: libCompletionEnding,
        },
    }
})

With this patch I can get it (in my case it just adds symbol in %LOCALAPPDATA%\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js at L135650):

before (lib.dom suggestions)
after

Another (but more advanced) cases would be:

Adding call signature (like objectLiteralMethodSnippets but for global / property access completions)
Filter only jsx components completions in <Foo[||]>
Change insertText of object literal property completion depending on JSDoc tags (for example @default)

... also changing sorting, insertText or even removing completions depending on contextual or declaration type or fileName (location) of where symbol is declared.
There are no workarounds known for me! (except of manually getting container and symbols of it), but it might become out of sync if manually maintained in plugin.

Hey, @andrewbranch, don't want to be annoying, but I wonder what kind of feedback is it awaiting? If there is anything else I should provide / do / discuss here, please let me know when you have time.
Others want features I can build using this information and I eagarly want to implement it, so again if there is any chance I can contribute to this let me also know about this. I'm also not sure of how it well it suits in the API, having it next to entry completion is just super handy (even ideal) for API usage (if we compare to getCompletionEntrySymbol arguments, which receives only name and source). Maybe it would be okay to have other getCompletionEntrySymbol method that would receive whole completionEntry as argument instead?

getCompletionEntrySymbol exists because it’s expected to get called against a different program than the one that gave the completion; e.g., the user started typing, got a list of completions, and then typed a few more characters before needing to get additional details about the symbol. When more characters are typed, the previous program gets thrown away, and much of the work done to find that original symbol has to be redone. If the symbol was merged or otherwise transient, it won’t exist anymore; a new one with a new identity will. That’s why it appears to be so inefficient. It’s not designed to do what you want at all. It’s reconstructing the world because it’s supposed to be called when the world has been thrown away.
Just returning the symbol on the completion entry as you did in your patch is a better solution. It would have to be enabled by a parameter passed to getCompletionsAtPosition to make sure that TS Server never sees it. I don’t think I have an issue with this but I’d want to run it by others on the team after the holidays. Normally I wouldn’t suggest making a PR before something is approved, but since it’s a small change, that’s probably the best way for us not to forget about it. (Most of the team is already on vacation, and I’ll be gone for a couple weeks starting tomorrow.)


moto[s3] cryptography dependency version

pip-audit labels versions of the cryptography package below version 41.0.0 as having a security vulnerability.  But the hook pip-compile reads the requirements of moto[s3]==4.1.3 and automatically installs a lower versioned cryptography package, 40.0.2, which is one version previous to cryptography 41.0.0.  When pip-compile sees the requirements for moto[s3]==4.1.3 it is specifies that it requires a version lower than cryptography 41.0.0 and causes pip-audit to fail due to the security vulnerability.
requirement=SpecifierRequirement('cryptography<41.0.0,>=3.1.0')
This is a request to bring moto[s3] up to compatibility with the cryptography package 41.0.0 that resolves the security vulnerability.

Hi @SiftRonnie, we only have the lower limit for cryptography. So I don't know why pip-compile installs 40.0.2, but that's not because of something that we have defined.
https://github.com/getmoto/moto/blob/3ddfc0db40a64621ae91de15c1f5f3841f57846b/setup.cfg#L31

My apologies. The requirement problem is with the other conflicting package. Closing issue.


PnP PowerShell Documentation Update March 2019

OPS Build status updates of commit d4374b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPAlert.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPApp.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePageSection.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideText.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideWebPart.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToList.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPCustomAction.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDataRowsToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPEventReceiver.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldFromXml.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldToContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFile.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFileToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFolder.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHtmlPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHubSiteAssociation.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPIndexedProperty.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptBlock.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptLink.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListFoldersToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListItem.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPMasterPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPNavigationNode.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPOffice365GroupToSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingImageRendition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPRoleDefinition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteClassification.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAdmin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAppCatalog.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesign.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesignTask.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteScript.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPStoredCredential.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTaxonomyField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantCdnOrigin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequence.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequenceSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequenceSubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantTheme.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPUserToGroup.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPView.md
:white_check_mark:Succeeded
View (sharepoint-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 9ad8498:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/docs-conceptual/sharepoint-pnp/sharepoint-pnp-cmdlets.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPAlert.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPApp.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSidePageSection.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideText.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPClientSideWebPart.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPContentTypeToList.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPCustomAction.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDataRowsToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPDocumentSet.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPEventReceiver.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldFromXml.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFieldToContentType.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFile.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFileToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPFolder.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHtmlPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPHubSiteAssociation.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPIndexedProperty.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptBlock.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPJavaScriptLink.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListFoldersToProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPListItem.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPMasterPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPNavigationNode.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPOffice365GroupToSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPProvisioningTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingImageRendition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPage.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPPublishingPageLayout.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPRoleDefinition.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteClassification.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAdmin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteCollectionAppCatalog.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesign.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteDesignTask.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPSiteScript.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPStoredCredential.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTaxonomyField.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantCdnOrigin.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequence.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequenceSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantSequenceSubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPTenantTheme.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPUserToGroup.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPView.md
:white_check_mark:Succeeded
View (sharepoint-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update Dockerfile and tools to add conda cleanup

Hi,
I started to update the image as in docker-galaxy-ngs-preprocessing
Bérénice

@bebatut have you cecked that all tools are available from conda already?

Any clue for why the tests are failing?

The startup.sh script copies everything into /export with many tools this can take minutes. Increasing the sleep time will help.


Use built-in upgrade command

Create a built-in upgrade command instead of upgrading via npm.

Already done, right?