Finetuning

Any resources / advises on how to finetune this model on a specific timeseries dataset?

Same question.

Would be interested too.

+1,same too,thanks

+1

Would be interested too.

Same question

https://github.com/google-research/timesfm/blob/master/notebooks/finetuning.ipynb - they recently added this

See an example here. It is meant to familiarize users mainly with paxml finetuning. You can of course bring your own data loader as well.


[bug] A view key of nil is not using the default

Is there an existing issue for this?

[X] I have searched the existing issues

Is this a regression?

[X] Yes, this used to work before

Current Behavior
Previously (in v1.1.0) the following worked...
MyBlueprint.render_as_json(my_object, view: nil)

Now (in v1.1.1) it raises with the exception...
#<Blueprinter::BlueprinterError: View '' is not defined>

I believe it was introduced when the following line was introduced:
https://github.com/procore-oss/blueprinter/blob/0e7f160d55e9f8cf53035f74af04bb33e6b739da/lib/blueprinter/helpers/base_helpers.rb#L18
Previously it was...
view_name = options.delete(:view) || :default

A possible solution is...
view_name = options[:view] || :default

Environment
- OS: Linux
- Browser Name and version: *
- Ruby Version: 3.3.4

Anything else?
No response

Thanks for opening the issue @nickjer! Was able to reproduce via test, and working on a quick fix!


Nothing built

@conda-forge/core it seems like nothing is built here. Is this a known bug in conda-smithy/conda-build-all?

This is hopefully fixed with PR #2. Nevertheless, there seems to have been a bug when creating the feedstock from staged-recipes.


Add float format = "%g" to several csv output functions

I don't know how powergenome works and so someone should really check
this. I didn't add float_format to places where it already existed.
I also didn't add it to the pudl extraction since that seemed to be an
intermediate operation.

Thanks @cfe316. There are two places where files are written to CSV:

Storing downloaded data so it doesn't need to be fetched again (EIA's open data and BLS consumer price index).
Writing input files for GenX

I think downloaded data should be saved as-is. GenX input files should be saved with reduced sig figs. This method might be best for files where formatting is consistent across columns. Generators_data.csv is much more varied, and it might be better to use the built-in GenX.round_col_values() function with this dictionary of column:sig fig inputs.

I'm not sure if this is needed anymore. In commit 0ddb5cd6584c2485bd30015568077c3aab3581dc I added column-specific formatting for the generators data file and a general output formatting for writing results to file. Is there anything else you think I missed?

I'll take your word for it! I'm actually not (yet) a primary user of PowerGenome, so I haven't tried it out.

Ok. I'll close this for now but we can revisit if necessary.


how to maintain lastupdated date of fhir resource while migrating Data

Question
we are moving from SQL to Cosmos, so we want to migrate data from  SQL to cosmos but we don't want to change the lastupdated date of FHIR Reasourse, how can we achieve this.

@shahedaAnsari right now we don't have any kind of migration tool to move data between FHIR servers except for exporting and reloading the data. We don't have a way to avoid updating the lastUpdated date when you load right now.


waffle.io Badge

Merge this to receive a badge indicating the number of issues in the ready column on your waffle.io board at https://waffle.io/pimutils/todoman
This was requested by a real person (user hobarrera) on waffle.io, we're not trying to spam you.

Bad placement, bot. :(


schema tests in dependent projects

@cmcarthur I've been using rewrite-materializations-1 and in general things have been working well. I was able to get my equality schema test up and running when I defined it in my local project. However, when I went to refactor it out into a shared utils project, it failed to run.
Console:
(venv) Tristans-MBP:analytics tristan$ dbt test --models table_a
Found 111 models, 122 tests, 0 archives, 0 analyses, 29 macros, 1 operations

16:05:01 | Concurrency: 4 threads (target='dev')
16:05:01 |
16:05:01 | 1 of 1 START test equality_table_a_ref_table_b_...................... [RUN]
16:05:01 | 1 of 1 ERROR equality_table_a_ref_table_b_........................... [ERROR in 0.01s]
! Compilation error while compiling test equality_table_a_ref_table_b_:
! 'test_equality' is undefined

Completed with 1 errors:
 - ERROR in test customerio.equality_table_a_ref_table_b_ (None)

Done. PASS=0 ERROR=1 SKIP=0 TOTAL=1

Link to my utility repo:
https://github.com/fishtown-analytics/dbt-utils
I can't link you to the actual place where it's failing because I have it implemented in a branch of a client project and have the tests build out using their data, but I can show you tomorrow.
The strangest thing about this is that it's clear from looking at the logs that dbt can see that file! Look at this:
...
2017-07-16 16:09:12,457: Parsing schema_tests/unique.sql
2017-07-16 16:09:12,460: Parsing equality.sql
2017-07-16 16:09:12,467: Parsing url_query.sql
2017-07-16 16:09:12,506: Found 111 models, 122 tests, 0 archives, 0 analyses, 29 macros, 1 operations
...

I'm not sure why it's able to parse it but then it's not able to find it later.
/cc @drewbanin

@jthandy unsure if this has changed in the new branch, but I believe you must scope the test name w/ the project name that it's defined in.
More info here: https://github.com/fishtown-analytics/dbt/pull/339
This makes sense given that dbt parses the file, but it's not present in the scope.

Quick update: this is still broken. Just tested, with the following result:
Tristans-MacBook-Pro:analytics tristan$ dbt test --models model_a

13:43:37 | Concurrency: 4 threads (target='dev')
13:43:37 |
13:43:37 | 1 of 1 START test equality_model_a_ref_model_b_...................... [RUN]
13:43:37 | 1 of 1 ERROR equality_model_a_ref_model_b_........................... [ERROR in 0.01s]

Completed with 1 errors:

Compilation Error in test equality_model_a_ref_model_b_ (models/test/schema.yml)
  'test_equality' is undefined

The schema file looks like this:
model_a:
    constraints:
        dbt_utils.equality:
            - ref('model_b')


Unrelated covid-19 topic used in project

I don't get what does has to do this project with Coronavirus

If is just to attract interest using a trendy tag... ok, you did it :clap:

This project contains new schema.org v7 types for the Corona virus.

Some more information on this:
https://blogs.bing.com/webmaster/march-2020/Bing-adopts-schema-org-mark-up-for-Special-Announcements-about-COVID-19

Thanks @tiggerito.


Performance: Cache regular expression instead of creating anew for every file in ScriptTransformer.

Summary
This PR improves performance by caching the regular expression string -> RegExp conversion.
Benchmarks on cached regular expression vs. creating new each time:
  new regex x   596 ops/sec ±0.95% (97 runs sampled)
  cached regex  x 1,668 ops/sec ±0.61% (97 runs sampled)

For large projects, Jest may process a LOT of files. The more workers in use, the higher chance that the same file is processed multiple times. Additionally, each time it's hit multiple regular expressions may be tested against.
The benchmark I used:
suite.add('new regex', function() {
  for (var i = 0; i < 10000; i++) {
    new RegExp('^.+\\.[jt]sx?$').test(
      'jest/packages/jest-haste-map/src/__tests__/haste_impl.js'
    );
  }
});

suite.add('cached regex', function() {
  const regex = new RegExp('^.+\\.[jt]sx?$');
  for (var i = 0; i < 10000; i++) {
    regex.test(
      'jest/packages/jest-haste-map/src/__tests__/haste_impl.js'
    );
  }
});

Test plan

All tests pass.
Performance benefit verified.

Codecov Report

Merging #8235 into master will increase coverage by 0.01%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #8235      +/-   ##
==========================================
+ Coverage   62.33%   62.34%   +0.01%
==========================================
  Files         265      265
  Lines       10553    10563      +10
  Branches     2565     2567       +2
==========================================
+ Hits         6578     6586       +8
- Misses       3387     3388       +1
- Partials      588      589       +1

Impacted Files
Coverage Δ

packages/jest-transform/src/ScriptTransformer.ts
80.76% <80.95%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08be02...3e9741e. Read the comment docs.


(FunctionClauseError) no function clause matching in Ecto.Adapters.Postgres.Connection.expr/3

Hi everyone,
I have an Elixir app that uses Ecto in order to execute queries in Postgres.
I have this Ecto schema:
defmodule Person do

  use Ecto.Schema

  schema "person" do
    field :name, :string
  end

end

I'm trying to make a simple select in Elixir:
query = from Person
result = Repo.all(query)

but after executing that code, I see this:
** (FunctionClauseError) no function clause matching in Ecto.Adapters.Postgres.Connection.expr/3

The following arguments were given to Ecto.Adapters.Postgres.Connection.expr/3:

    # 1
    {{:., [], [{:&, [], [0]}, "name"]}, [], []}

    # 2
    {{[34, "Person", 34], [84 | "0"],
      Person}, []}

    # 3
    #Ecto.Query<from c0 in Person,
     select: c0>

Attempted function clauses (showing 10 out of 33):

    defp expr(-{:^, [], [ix]}-, _sources, _query)
    defp expr(-{{:., _, [{:parent_as, _, [as]}, field]}, _, []}-, _sources, query) when -is_atom(field)-
    defp expr({{:., _, [{:&, _, [idx]}, field]}, _, []}, sources, _query) when -is_atom(field)-
    defp expr(-{:&, _, [idx]}-, sources, _query)
    defp expr(-{:in, _, [_left, []]}-, _sources, _query)
    defp expr(-{:in, _, [left, right]}-, sources, query) when -is_list(right)-
    defp expr(-{:in, _, [left, {:^, _, [ix, _]}]}-, sources, query)
    defp expr(-{:in, _, [left, %Ecto.SubQuery{} = subquery]}-, sources, query)
    defp expr(-{:in, _, [left, right]}-, sources, query)
    defp expr(-{:is_nil, _, [arg]}-, sources, query)
    ...
    (23 clauses not shown)

(ecto_sql 3.7.2) lib/ecto/adapters/postgres/connection.ex:590: Ecto.Adapters.Postgres.Connection.expr/3
(ecto_sql 3.7.2) lib/ecto/adapters/postgres/connection.ex:1284: Ecto.Adapters.Postgres.Connection.intersperse_map/4
(ecto_sql 3.7.2) lib/ecto/adapters/postgres/connection.ex:340: Ecto.Adapters.Postgres.Connection.select/3
(ecto_sql 3.7.2) lib/ecto/adapters/postgres/connection.ex:113: Ecto.Adapters.Postgres.Connection.all/2
(ecto_sql 3.7.2) lib/ecto/adapters/postgres.ex:102: Ecto.Adapters.Postgres.prepare/2
(ecto 3.7.2) lib/ecto/query/planner.ex:180: Ecto.Query.Planner.query_without_cache/4
(ecto 3.7.2) lib/ecto/query/planner.ex:150: Ecto.Query.Planner.query_prepare/6
(ecto 3.7.2) lib/ecto/query/planner.ex:125: Ecto.Query.Planner.query_with_cache/7

Also same result with Repo.all.
This are the versions that I'm using:
Elixir: 1.13
ecto_sql: 3.7.2
postgrex: 0.16.2
Does anyone has any idea what is making this error?
Thanks

Does it work if you do:
query = from p in Person
result = Repo.all(query)

Or just:
query = Person
result = Repo.all(query)

?

@josevalim I just tried with your 2 suggestions, but same result.
Looks like that for some reason, when trying to call Repo.all or Repo.one, those 2 functions are not being found

This is very weird. Can you provide a small app that reproduces this issue? :)

Make sure to provide an actual Ecto.Repo as Repo. I just used Repo as a shortcut.

Make sure to provide an actual Ecto.Repo as Repo. I just used Repo as a shortcut.

Yes exactly, I put an example but in my code, I´m referencing the full path of the module

This is very weird. Can you provide a small app that reproduces this issue? :)

Here is an example:
 defmodule Repo do

   use Ecto.Repo,
      otp_app: :my_app,
      adapter: Ecto.Adapters.Postgres

  import Ecto.Query

  alias Schema.Person

  def my_function() do
     query = from p in Person
     a = Repo.all(query) #in this lines the error appears
  end

end

Thanks!

I mean, a separate app that I can clone. :)

@josevalim Sorry for the delay, I figured out the problem:
I have a table in a Postgres database, that contains two fields:
person_age_123 and person_name_123
So on my schema on Elixir, I was trying to map those database column names to a more "friendly" field names, like age and name.
So my Elixir schema was the following:
defmodule EctoApp.Person do
use Ecto.Schema
schema "person" do
field :name, :string, [source: "person_name_123"]
field :age, :integer, [source: "person_age_123"]
end
end
and the error was because I was using " instead of :, so I think that the idea is to incluide atoms and not strings.
If you want, I can share a repo with the whole code, but with that, you can reproduce the issue.
Let me know if you want the app anyway :)

Thanks. This is great and enough! We should validate this somewhere and raise early instead of late.


Alternative to auto-instrumentations-node/register when needing to configure specific instrumentations

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

I'm currently using the auto-instrumentations-node/register module as it's quite convenient:
node -r @opentelemetry/auto-instrumentations-node/register dist/index

Now I'm in a situation where I need to customize the config for one of the instrumentations (in this case it's @opentelemetry/instrumentation-fs).
What's the best way to achieve this?
One solution that comes to mind is to take the source code of auto-instrumentations-node/register and customize the getNodeAutoInstrumentations call to my liking, like so:
import { DiagConsoleLogger, diag } from "@opentelemetry/api"
import { getNodeAutoInstrumentations } from "@opentelemetry/auto-instrumentations-node"
import { getResourceDetectorsFromEnv } from "@opentelemetry/auto-instrumentations-node/build/src/utils"
import * as opentelemetry from "@opentelemetry/sdk-node"

diag.setLogger(
  new DiagConsoleLogger(),
  opentelemetry.core.getEnv().OTEL_LOG_LEVEL
)

const sdk = new opentelemetry.NodeSDK({
  instrumentations: getNodeAutoInstrumentations({
    "@opentelemetry/instrumentation-fs": { enabled: false },
  }),
  resourceDetectors: getResourceDetectorsFromEnv(),
})

try {
  sdk.start()
  diag.info("OpenTelemetry automatic instrumentation started successfully")
} catch (error) {
  diag.error(
    "Error initializing OpenTelemetry SDK. Your application is not instrumented and will not produce telemetry",
    error
  )
}

process.on("SIGTERM", () => {
  sdk
    .shutdown()
    .then(() => diag.debug("OpenTelemetry SDK terminated"))
    .catch((error) => diag.error("Error terminating OpenTelemetry SDK", error))
})

Here's the significant diff:
<   instrumentations: getNodeAutoInstrumentations(),
---
>   instrumentations: getNodeAutoInstrumentations({
>     "@opentelemetry/instrumentation-fs": { enabled: false },
>   }),

Unfortunately, this code is using the getResourceDetectorsFromEnv function, which is internal and not exported. I get the following error when running the code above:
$ node -r ./dist/tracing dist/index

node:internal/modules/cjs/loader:535
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './build/src/utils' is not defined by "exports" in<EMAIL_ADDRESS>    at new NodeError (node:internal/errors:393:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:358:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:668:3)
    at resolveExports (node:internal/modules/cjs/loader:529:36)
    at Module._findPath (node:internal/modules/cjs/loader:569:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:981:27)
    at Module._load (node:internal/modules/cjs/loader:841:27)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/Users/user/project/dist/tracing.js:28:17) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v18.12.1

After having a glance at the implementation of getResourceDetectorsFromEnv, it seems quite useful, so I wouldn't want to skip it.
Does it make sense to export getResourceDetectorsFromEnv? If yes, I can probably submit a PR with this change.

Do we really need this part?
diag.setLogger(
  new DiagConsoleLogger(),
  opentelemetry.core.getEnv().OTEL_LOG_LEVEL
)

It seems to be the default behavior.

I'm not sure that you need resourceDetectors here. In the docs README it states "By default, all SDK resource detectors are used"... but that you can also set them via environment variable like export OTEL_NODE_RESOURCE_DETECTORS="env,host". Does that cover what you are trying to do?

Oh! I just realized you noted you are copying the code from the source here - maybe you would actually be interested in docs on using the SDK itself? Here is a link to sdk-node.
Set your environment variables and then you should just need this:
import { NodeSDK } from '@opentelemetry/sdk-node';
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node';

const sdk: NodeSDK = new NodeSDK({
  instrumentations: [
    getNodeAutoInstrumentations({
      '@opentelemetry/instrumentation-fs': {
        enabled: false,
      },
    }),
  ],
});

sdk.start();

@JamieDanielson The only occurrence of getResourceDetectorsFromEnv seems to be in metapackages/auto-instrumentations-node/src/register.ts. From my understanding, if I want to have the functionality of getResourceDetectorsFromEnv I have 2 options:

use @opentelemetry/auto-instrumentations-node/register
copy its source-code

Am I missing something?

I am also running into this issue, I am using the snippet from https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1531#issuecomment-1622681932 to be able to configure instrumentations (literally to disable fs instrumentation like the example :D), but would like to have ENV support for resource detectors, meaning for now I'm copying the function in. It would be great if getResourceDetectorsFromEnv were exported, it seems to have similar utility to the already exported getNodeAutoInstrumentations.

@JamieDanielson The only occurrence of getResourceDetectorsFromEnv seems to be in metapackages/auto-instrumentations-node/src/register.ts. From my understanding, if I want to have the functionality of getResourceDetectorsFromEnv I have 2 options:

use @opentelemetry/auto-instrumentations-node/register
copy its source-code

Am I missing something?

@opentelemetry/auto-instrumentations-node
I'm opening this issue again. I think I see what @eyalch @anuraaga are talking about.
The issue, as far as I understand, is that when you use the very convenient register module, there's no way to configure which instrumentations are enabled, or supply the configurations for the instrumentations being picked up by the register module.
I am running into this myself at the moment.
It would be really nice to be able to at least disable certain instrumentations via environment variables similar to how getResourceDetectorsFromEnv picks up which resource detectors to pick up.
So there a few possible solutions that I can think of

Have an environment variable to pick up which which instrumentations are enabled by the auto instrumentation register module
Have a way to simply supply the configuration json to the current auto instrumentation registration module. This potentially can be very simple to implement. getNodeAutoInstrumentations already takes an optional input config https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/src/utils.ts#L136 . So the call in the registration module could simply pick it up from environment variables if available over here https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/src/register.ts#L29C21-L29C48 .
Don't change anything and create your own tracer.js file and call auto getNodeAutoInstrumentations yourself and configure it with/without any of the instrumentations you need. This would bypass the use of the register module altogether

Of course option 3 works today without any changes to the library. However I'm finding the registration module really useful as it's requiring little changes to services that have more complicated setup with the added ability of being able to call auto instrumentation via NODE_OPTIONS. I really find this very useful.
I think it would be great to select which instrumentations the register module picks up via environment variables too. And added bonus would be to be able to supply further config options via the json that one can pass currently when they call getNodeAutoInstrumentations in code as mentioned in option 2 (and potentially very easy to implement with little library code change). But having at least option 1 would be great!

FWIW, while I started with the non-register approach to disable fs, to eventually have clean traces I needed to do a lot more programatic configuration including a custom span processor to move attributes like http.route, I don't know if just env configuration of instrumentation will cover it for my case. More env knobs is always nice either way though

a custom span processor to move attributes like http.route

A bit of topic here but is this an indication that the http.route handling done between express/hapi/fastify/... and the http instrumentation is not working as intended?
I doubt also that a pure env based variant will be enough to configure everything. Besides that I think that env configs like this should start at spec to have a consistent naming across techs/instrumentations/exporters/processors/propagators/....
a json/yaml file is likely more flexible (well, an env variable could point to this file). But if hook functions are needed event this might be limited.

Yes, I believe currently the nodejs instrumentation isn't very usable out of the box as server spans are purely generated by http instrumentation - while maybe I'm the only one that has trouble with a sea of spans named GET and POST, I somehow doubt it ;)
Java (/cc @mateuszrzeszutek @trask) has a similar issue where servlet instrumentation, e.g. tomcat, handles HTTP and routing instrumentation, e.g. spring, handles routes. It took a lot of effort but with the instrumentation API it's currently handled in a reasonably well-structured manner. There might be some tips to take from that, but looking through http and nestjs instrumentation here I got the impression it's pretty ad-hoc so unifying patterns for e.g. updating a server span looks like it could be a huge effort.
Back on topic, I wonder if this issue title misses the point, or perhaps I should file a new one. As in the original issue, the main problem with /register is inability to configure environment resource. There doesn't seem to be a way to tie environment resource to the register hook given that environment resource is defined in the spec of the SDK itself. I think this is similar to Java having done similar in https://github.com/open-telemetry/opentelemetry-java/pull/5554, so maybe we could get that exposed here to solve the current main issue with /register as I read this issue.


Infinite loading caused by session_start() and flock() [Session Drivers]

Hi,
My CI project doesn't work anymore, probably since a PHP update – but I'm not sure of that. I'm facing an infinite loading on every page.
I figure out the problem was related to session_start(); when initializating the Session library. Using Serverpilot to find slow PHP scripts, I got this exec stack:
script_filename = public/index.php
[0x00007fe121420d20] flock() public/system/libraries/Session/drivers/Session_files_driver.php:180
[0x00007fe121420c60] read() public/system/libraries/Session/Session.php:143
[0x00007fe121420c10] session_start() public/system/libraries/Session/Session.php:143
[0x00007fe121420b40] __construct() public/system/core/Loader.php:1285
[0x00007fe121420a20] _ci_init_library() public/system/core/Loader.php:1178
[0x00007fe121420900] _ci_load_stock_library() public/system/core/Loader.php:1043
[0x00007fe1214207f0] _ci_load_library() public/system/core/Loader.php:1089
[0x00007fe1214206e0] _ci_load_library() public/system/core/Loader.php:218
[0x00007fe121420620] library() public/system/core/Loader.php:202
[0x00007fe121420560] library() public/system/core/Loader.php:1359
[0x00007fe121420490] _ci_autoloader() public/system/core/Loader.php:157
[0x00007fe121420440] initialize() public/system/core/Controller.php:79
[0x00007fe1214203a0] __construct() public/application/controllers/Welcome.php:8
[0x00007fe121420340] __construct() public/system/core/CodeIgniter.php:518
[0x00007fe1214200f0] [INCLUDE_OR_EVAL]() public/index.php:315

The problem is located here : flock() public/system/libraries/Session/drivers/Session_files_driver.php:180
Do you know why this line is causing an infinite loading on both my MAMP local install (a AMP stack for OS/X) and my DigitalOcean droplet?
Thanks!
Stéphane
Server Config:

PHP 7.3.2 (cli) (built: May 20 2012 07:00:00) ( NTS )
Apache2
mysql  5.7.25
CI_VERSION = 3.1.10
Description: Ubuntu 18.04.2 LTS

Same issue with this config:

MAMP 5.3 on OS/X Mojave
Apache 2.2.34
PHP 7.3.1
CI_VERSION = 3.1.10

Something was bad with a custom Exception - it's now fixed. It was not related to CI core. Sorry for the inconvenience.
Have a nice day,
Stéphane


[#5033] improvement(docs): Add the documents about access control

What changes were proposed in this pull request?
Add the documents about access control.
Why are the changes needed?
Fix: #5033
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Just docs.

I have tested by hand using OpenAPI and curl command.

@jerryshao  I have checked this document of keyword grant and revoke.


How can set compression level (image quality) and extension like: png, etc?

It would be great if I could explain how to do this. if the library does not support it I think it would be a great addition.
Thanks for your great effort and sorry for the trouble.

Will take this as a feature request for a later version.

@Ceaggar
    try {
        FileOutputStream fos = new FileOutputStream (pictureFile); //takes a output file as input
        image.compress (Bitmap.CompressFormat.WEBP, 75, fos); //image is a bitmap type variable
        fos.close ();

    } catch (FileNotFoundException e) {
    } catch (IOException e) {
    }

Released with v1.5


docs: updated Collection.aggregate()

There are different ways of building aggregation pipelines, you can put the whole pipeline in the first parameter:
db.collection('Foo').aggregate([{ $match: { bar: 1 } }, { $limit: 10 }])

or add them via separate method calls later:
db.collection('Foo').aggregate([]).match({ bar: 1 }).limit(10)

In the second case, passing the empty array to aggregate() seems redundant and even though the pipelines parameter is currently documented as required, this also works:
db.collection('Foo').aggregate().match({ bar: 1 }).limit(10)

But I'm not fully sure if this is supposed to work or perhaps just an unintended side effect of a deprecated version of the function.
Either way, I find it clearer and would prefer it to be supported.

Thank you for your contribution @mjomble


Fix media library (manage own media) issue with german umlauts in usernames

Hi,
managing media libary has issues e. g. with german umlauts in file names.
Startet getting
A potentially dangerous Request.QueryString value was detected from the client...
errors. Wrong url encoding was also an issue.
With my suggested fix here meda library management work with german umlauts.

Hi @dpomt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

I understand the issue but this PR looks like a big hack. Let's see if it can't be fixed by simply url-encoding the folder path. The decoding should be done automatically when the query string is read from ASP.NET.

You  might be right concerning the "big hack". If somebody finds a better fix I would be happy with that. This was the only solution I found (for a site that was already in production with users facing the issue) and thought it would be good to share.

Please open a bug with some repro steps, this fix is incorrect, people will be able to comment and suggest a solution, or repro it.


Updated the API URL to add a solution package

Q
A

content fix?
yes

What's in this Pull Request?
The API URL to add a solution package seems to only be called with tenantappcatalog/Add instead of AvailableApps/GetById('xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx')/Add.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/apis/alm-api-for-spfx-add-ins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Elio


Failure: java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

Hi! I noticed error when I run atom on repos like react and three.js:
atom -o app.atom -l js .
Failure: java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

I can replicate this with the three.js repo locally. Investigating ...

Removing the JavaScript Type Recovery results in a successful atom creation.
new JavaScriptTypeRecoveryPass(ag).createAndApply()


month is not translated in resources

Describe the bug
screenshot speaks for itself;
anyway, whatever language is set, that month string remains in english, but it shouldnt.
Steps to reproduce
.
Screenshots or additional context

Culprit is line 92 in Resources.tsx
Should probably add month translations to the locale files, just like the days are.
https://github.com/usememos/memos/blob/a928c4f845891fbef9c3eeefb4860ff923bb3488/web/src/pages/Resources.tsx#L92C20-L92C124

damn. I really thougth months are covered. :|


Feature: unit conversion

This is a second attempt at implementing #530 and fixing #275. Based on the excellent work of @jvdoorn.
List of Changes

Add the manim/utils/unit.py module.
With respect to #530, I decided to simplify everything as much as possible and use functions instead of classes or decorators.

Motivation
The main motivation is that it doesn't make much sense that manim's frame has a width of 14.22 and a height of 8. That seems very arbitrary. It would be great to allow users to input units in other coordinate systems that make more sense. With the new additions, it doesn't really matter what coordinate system manim uses underneath at all, since users can now use the one they prefer.
Example
import manim as mn
from manim import ApplyMethod, unit
from manim import color as C

def make_dot(c):
    return mn.Dot(radius=0.2, color=c)

class UnitDot(mn.Scene):
    def construct(self):
        dot1 = make_dot(C.RED).shift(mn.UP)
        dot2 = make_dot(C.BLUE)
        dot3 = make_dot(C.GREEN).shift(mn.DOWN)
        self.add(dot1, dot2, dot3)

        self.play(
            ApplyMethod(dot1.shift, unit.m(3.55) * mn.RIGHT),
            ApplyMethod(dot2.shift, unit.px(213) * mn.RIGHT),
            ApplyMethod(dot3.shift, unit.pct(25, mn.X_AXIS) * mn.RIGHT),
        )

        self.wait()

Testing Status
I will add tests once we have reached consensus that this is the way to go.
Further Comments

Acknowledgement

[x] I have read the Contributing Guidelines

This is excellent; strong +1 for pursuing this further!

Looking very good so far!

Thanks for the replies. TBH I think this could be merged as is (after adding some tests). However, I want to discuss the interface a bit.
Right now, it looks like this:
dot.shift(unit.m(3.55) * mn.RIGHT)

If you read out loud the meaning of that line in English, you would say something like "shift 3.55 (m)units to the RIGHT". The thing is that the code has first the unit, then the number, then the direction: unit.m(3.55) * mn.RIGHT.
So one alternative would be to implement the following
dot.shift(3.55 * unit.m * mn.RIGHT)

which now exactly reads almost as in English "3.55 m units to the right". Similarly, I think the latter one of these next two is cleaner:
dot.shift(unit.px(213) * mn.RIGHT)
dot.shift(213 * unit.px * mn.RIGHT)

One could go as far as to have 213*px.
If anyone thinks this is cleaner and that it's worth it to implement it, this can easily be done by creating a custom Unit object and overriding the __mul__ method.

After reading that back to myself, I'm not sure if the added convenience is worth it :sweat_smile: what do others think?

As I said on the discord server, I feel like it might be more consistent to have MUNITS and PIXELS constants to use in the same way as the DEGREES constant, so like how you do 70 * DEGREES for 70 degrees, you'd use 3 * MUNITS for 3 munits and so on. And in places where you can't have just a straight constant, like with units.pct, you could instead make it a function but still named in all caps for consistency, so like 5 * PERCENT(X_AXIS)

I think that is the cleanest yet. However, now that I think of it, this would work for MUnits and Pixels, but not for PercentUnits, as they need an argument ("percentage of what?")

Is making it a function instead of a straight constant but still named in all caps like I mentioned not desirable?

Oh I just saw that, sorry :sweat_smile:
Uhm, I think it'd be fine though a little weird :thinking:  But we should reach some consensus so let's see what others think.

@friedkeenan after thinking about this some more, I don't think these should be implemented as upper-case-constants. The reason is that the conversion factor between logical manim units (Munits) and pixels is not always constant. See for example #749. They should be functions.

Perhaps then they could be special Unit classes that you multiply against, like how you were thinking before. I do still think though that keeping them in line with how DEGREES is used (including the uppercase naming) is desirable. I don't think it needs to be readily apparent to the user that they're not actually constants, as long as they work like DEGREES

How about this?
dot.shift(213 * unit.px * mn.RIGHT)
dot.shift(50 * unit.pct(X_AXIS) * mn.RIGHT)
dot.shift(3.55 * unit.m * mn.RIGHT)

These work like DEGREES. I am explicitly against using all upper case letters to name something that is not a global constant.

Maybe with some better naming then. Stuff like unit.m and unit.pct are really obscure, I'd really appreciate the full names of all these units instead of abbreviated ones. And then maybe DEGREES should be made in line with these not uppercase units instead of the other way around? I just really don't like the inconsistency it would bring if they were done differently

Oh! I agree with not having inconsistent things. If it's a matter of consistency, then I'm all for including DEGREES in this PR.
I'm beginning to think that it doesn't really matter that all of these are the same type of object, as long as they have a common interface like this. For example, there's no need to make DEGREES (or Degrees) into a function given that it is always a constant. On the other hand, Pixels (or PIXELS) cannot be a constant, as I said above.
So I propose something along the following lines:
class PixelUnits:
    def __mul__(self, val):
            return val * config.frame_width / config.pixel_width

class Percent:
    def __init__(self, axis):
        self.length = length_of_axis(axis)
    def __mul__(self, val):
        return val / 100 * self.length

Pixels = PixelUnits()
Degrees = 360 / PI
MUnits = 1

This would allow the following usage:
from manim.unit import *
dot.shift(213 * Pixels * mn.RIGHT)
dot.shift(50 * Percent(X_AXIS) * mn.RIGHT)
dot.shift(3.55 * MUnits * mn.RIGHT)
dot.rotate(PI * Degrees)

I'm still not sure about the naming convention. cc @behackl @cobordism @eulertour may have thoughts

from manim.unit import *
dot.shift(213 * Pixels * mn.RIGHT) #1
dot.shift(50 * Percent(X_AXIS) * mn.RIGHT) #2
dot.shift(3.55 * MUnits * mn.RIGHT) #3
dot.rotate(PI * Degrees) #4

Some comments on this regarding the naming:

This is nice!
Also nice, but I could also imagen "ratio" instead
Why do we want to have MUnits? As they are one, I guess that is not really necessary, and when someone would want something like this, one can just simply add this manually.
Also good!

@kolibril13 thank you, I was awaiting some thoughts on the naming.

We want MUnits in case the underlying default units (currently 8/14.22221) change at some point. See #749

Nice!
As this is a very nice and convenient feature, can we merge this maybe even before the next release?

I'll do my best to finish this before the next release
On Thu, Nov 26, 2020, 5:18 PM kolibril13<EMAIL_ADDRESS>wrote:

Nice!
As this is a very nice and convenient feature, can we merge this maybe
even before the next release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManimCommunity/manim/pull/742#issuecomment-734494970,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAILYAEGXMJPZ7LW7MDWEQ3SR3H3JANCNFSM4T4GGT4Q
.

I did not make it in time for the release :sweat_smile:
However, I just pushed a commit using this interface, including Degrees and changing MUnits to Munits (@friedkeenan ) I also added a test file.
If people are alright with this, then I will add the documentation.
One more thing: how do we want to import these units? Currently, there are two ways of importing them:
from manim import *              # this imports Munits, Degrees, Pixels, Percent, and 300 other names
from manim.utils.unit import *   # this only imports Munits, Degrees, Pixels, Percent

I would rather have something like from manim.unit import * rather than manim.utils.unit. But I don't feel too strongly about it. Anyone else?

I'm still not sure about the naming convention. cc @behackl @cobordism @eulertour may have thoughts

This is great ... except for seeing "PI * Degrees" ;)

Darn it.

Actually I just checked and I did it right in the test file.

Two more thoughts:
should Percent go from 0 to 100, or from 0.0 to 1.0 ? I would prefer the latter.
Percent is a bit long, what about Pct()?

Two more thoughts:
should Percent go from 0 to 100, or from 0.0 to 1.0 ? I would prefer the latter.

If it is called Percent, it has to go from 0 to 100.

Percent is a bit long, what about Pct()?

I wouldn't mind adding a shorter alias, but users should be able to find it using the full name.

I don't think Pct is very descriptive, and, for new users especially, it would be hard to ascertain what it is at first glance. I don't find Percent to be too long (especially in conjunction with autocomplete, but even without it) and the small increase in verbosity gives a big increase in readability. Rerhaps something like Pct = Percent could be done as a compromise?

I'm in favor of Percent and against Pct since the latter will normalize less readable code.

Just one more thought: users who want a shorter name can get it by doing from manim.utils.unit import Percent as Pct.

Just one more thought: users who want a shorter name can get it by doing from manim.utils.unit import Percent as Pct. I agree the actual class should just be Percent.

Brilliant!

One more review! One more review!

I just readded from .mobject.logo import * to manim/__init__ because otherwise the docs would fail

I just readded from .mobject.logo import * to manim/__init__ because otherwise the docs would fail

Thanks all, and sorry for abandoning this. After taking another look, I'm merging it.

Thanks all, and sorry for abandoning this. After taking another look, I'm merging it.


Azure RBAC fix refresh token logic

This PR aims to fix the refresh token logic for Azure RBAC.
The existing refresh token logic relies on the expires_in value from the token response -
{"access_token":"","expires_in":"86700","refresh_token":"","expires_on":"1732881796","not_before":"1732795096","resource":"https://management.azure.com","token_type":"Bearer"}
However in the case when the token is not fresh and returned from cache, the expires_in value misleads Guard to think the token doesn't need refreshing since it adds the current_time + expires_in to set the new expiry time.
In this PR we directly use the expires_on to set the expiry time accurately.
The PR also increases the tokenExpiryDelta to 5 minutes to ensure the token is refreshed 5 mins earlier than actual expiry. This is done on both AuthZ (rbac.go) and AuthN (graph.go) flow.
Using the current implementation guard now sets the expires property correctly, i.e. knows it expires at 2024-11-29 21:05:56 +0000 UTC in the below example rather than doing - current-time + 86700
Guard log -
│ I1202 20:38:40.019063       1 graph.go:331] Token received with expires_in 86700 and expires_at<PHONE_NUMBER>

││ I1202 20:38:40.019114       1 graph.go:337] Token refreshed successfully at 2024-12-02 20:38:40.019110448 +0000 UTC m=+444.823514368. Expire at set to: 2024-12-03 20:31:19 +0000 UTC

Tested KAP flow -

RBAC non proxy flow -

Also rename the PR with [BUG/FIX] in the title

LGTM!


Crop area width / height

Hi.
I want to know if it's possible to set the initial crop area width and height to a certain value. I tried that using crop-avatar example, but without success.
Thanks in advance.

I just achieved this. With Deferred objects.
I created a function:
function loadImage(src) {
    var deferred = $.Deferred();
    var img = new Image();
    img.onload = function() {
        deferred.resolve(img);
    };
    img.src = src;
    return deferred.promise();
}

And then used like this:
var loaders = [];
loaders.push(loadImage(this.url));
$.when.apply(null, loaders).done(function(img) {
    //Code goes here (using img)
});

You can close this topic.


Font size too small

when expanding the sections of the docs, the font size gets very small.

Please improve by providing a bigger font size.

Fixed in https://github.com/keptn/keptn.github.io/pull/235


Add support for Platform.sh

Resolves #2
Platform.sh allows a user to create their own environments with arbitrary names. It also allows a user to define the type of environment that it is (development, staging, production). The names and types are available in environment variables. I opted to have getEnvironment() always return the user-defined environment name and introduce a new getEnvironmentType() method to the PlatformSh class to be used by isProduction() and the like to get the type of environment.
Neither Lando nor DDEV supply the environment type variable, so I defaulted to "local" when it is not present.

@davereid The code climate action won't be able to complete successfully because CC_TEST_REPORTER_ID will be empty since secrets aren't available to PRs coming from a forked repo.


Consider removing the type byte

It is not really documented in the Sway Book and it's pretty similar to a u8. One added benefit to byte is that it doesn't cast to other integer types like u8.
Edit: actually we do mention byte in passing here: https://fuellabs.github.io/sway/latest/basics/built_in_types.html#numeric-types

All of the unsigned integer types are numeric types, and the byte type can also be viewed as an 8-bit unsigned integer.

Just do it.  :yoda: There is no consider.

https://www.youtube.com/watch?v=ZXsQAXx_ao0


Request: Removing APKs

View listed APKs on watch/phone and ability to remove them from device.

Would be cool. Should be possible via ADB's package manager interface

Update: The most recent version offers an "Uninstall" button right after installing an APK


A refresh on A profile page gives a 404 error

I have just  fixed it by adding a netlify.toml in the build file with this content
[[redirects]]   from = "/*"   to = "/index.html"   status = 200   force = false


Suggestion: SIGIR 2021 E-Commerce Workshop Data Challenge

Hi! I just discovered this project from links in a discussion area from another project. Having a look through here, I appreciate your features in the area of splitting, unique metrics, and stats tests!
I learned the other day that the SIGIR 2021 Conference has an e-commerce workshop data challenge, called In-session prediction for purchase intent and recommendations. They just opened it up for participation.
https://sigir-ecom.github.io/data-task.html
After looking at elliot's input structure, it seems like it wouldn't be too far off to connect elliot to the data challenge to get some elliot benchmarks out. Though, I didn't dig into the available models enough to know how they map to in-session datasets.
Unfortunately I am unable to give it a go due to other professional commitments. But I figured I'd share it here as well as an opportunity to grow awareness around elliot, in the event others are interested.

Hi @tszumowski,
thanks for the suggestion. During the last months, we are very busy due to some bugs still affected the code. Now with the latest version of Elliot, these are fully managed.
If in the next future you would like to collaborate in this direction we'd are very interesting to approach this direction in out framework.


fix: RPC Provider Node

Motivation and Resolution
RPC works on devnet as expected, this PR Fix it for Pathfinder
During this PR Pathfinder bugs were reported and fixed on their end, so this will work only with the latest fixed version >=0.4.3

By default, pathfinder doesn't have a pending block, so starknet.js RPC provider should have the same default behavior
Fixed null block identifier from contract call

RPC version (if applicable)
0.2.1
Pathfinder 0.4.3
Usage related changes
RPC will use the latest block by default
Checklist:

[x] Performed a self-review of the code
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Linked the issues which this PR resolves
[x] Documented the changes
[ ] Updated the docs (www)
[x] Updated the tests
[x] All tests are passing

By default, pathfinder doesn't have a pending block, so starknet.js RPC provider should have same default behaviour
by default? so it can have it?

By default, pathfinder doesn't have a pending block, so starknet.js RPC provider should have same default behaviour
by default? so it can have it?

Yea it can have it but the node needs to be run with poll-pending=true flag.
So I set defaults to 'latest' for RPC and it can be set to 'pending' on the method call or on the RPC provider create a config for all methods.


Update memory-integrity.md

Updating the summary of Memory integrity to more succinctly and simply describe what it protects against and why an end user might want to turn or keep it on.

@marcusrussell Would you be able to follow up with copy revision suggestions? We would like to proceed with the review. Thanks.

@marcusrussell Closing as there has been no follow-up with the reviewers' revision suggestions. Please re-open the PR to proceed with the review. Thank you for your patience with the process and your contributions.

if anyone else are interested in this topic, chances are good for opening a new Pull Request with this material and get it merged. Just make sure you will be able to follow up on your own work each weekday or working day (5 days a week).

This looks pretty easy, thank you @JohanFreelancer9 for your edits. @illfated and @e0i I'll just make the change, thanks for following up!


fake commit

this PR attempts to debug why hypothesis tests are flaking

hypothesis.errors.DeadlineExceeded: Test took 1004.39ms, which exceeds the deadline of 1000.00ms
need to bump deadline in CI profile?

I think it's always the exit_in_predict case, did something make that actually slower in a way we should fix directly?

I ran it locally and it failed the deadline in some other tests. Re-running them seems to have no issues, though. I vote to increase the deadline to 1.5s and think about it again if this re-surfaces.

LGTM. Can you cherry pick out the fake commit?


How to run in host mode?

Hi I use this command run :
docker run --cap-add=NET_ADMIN --device=/dev/net/tun --network host -ti evilfreelancer/docker-routeros

It start ok but cant connected with winbox and mikrotik self cant ping the gateway

answer please

Hi! This is not possible, because RouterOS is running inside QEMU virtual machine inside a container.
But you may use network_mode: host and your QEMU VM will have direct access to host network, this mean you will need to change settings in entrypoint.sh manually.


Added some HTML/CSS, Google login. Created fixtures folder and added it to gitignore.

The fixture folder is in the same directory as /templates /css and manage.py.

All tests are from this tutorial. I haven't figured out testing quite yet.


Added provisions for usgs gages if there are no lakes

For all gages: only create waterbody types dataframe if there are actually lakes

Specifically for usgs gages: reindex link to lake only makes sense if there are lakes

Additions

Removals

Changes

Testing

Screenshots
Notes

Todos

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Target Environment support

[ ] Windows
[ ] Linux
[ ] Browser

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

Please disregard this PR for the time being- it's a debug version that was meant to address the failing self tests.

OK - now it's good.

Obsolete - closed.


Tag/Versions newer than 3.1.0?

Hi!
I might be overlooking something, but I need help finding a branch or tag newer than 3.1.0, even though the README states that the current version is 3.4.0.
Am I missing something? How can I check out the v3.4.0 version?
Thanks!

+1
Also, it looks like 3.1.0 is a branch rather than a tag or version, which is a little unusual. I think that tags in the main branch would be less confusing.

OK, I created Release v3.4.0. I like to keep the older versions as branches so that I can continue development along one of those older branches if necessary. For example, v2.5.0 dropped support for SD Standard Capacity Memory Cards. If someone is still using those, they can run that branch. If there is some serious bug or something that needs to be rolled back, that branch can be continued.

Thanks!

Thank you! Awesome work!


Improvement for the security docs

Added the lines as suggested in the issue https://github.com/kubernetes/website/issues/39249

A relevant tip from our style guide: avoid using “we”
Can you reword, @Dhairya-Arora01 ? For example, “The Kubernetes project recommends…”

Yeah, that would be great

@NitishKumar06 @sftim hey guys sorry to disturb but please can you now review this

@NitishKumar06 @sftim hey guys sorry to disturb but please can you now review this

I know you're very eager to put your work upfront. We value your contribution to Kubernetes. However, Please keep in mind that Open Source is volunteer work, PRs can sometimes take months to get merged, and maintainers are equipped with different tasks at the same time. Have patience and keep contributing:)

Page preview:
https://deploy-preview-39961--kubernetes-io-main-staging.netlify.app/docs/tutorials/security/

/approve


LockToPreventUpdate_MultipleFiles test fails occasionally

This tests seems to be flaky since it will fail occasionally.
GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WindowsUpdatePlaceholderTests.LockToPreventUpdate_MultipleFiles
Failure was:
System.IO.IOException : The process cannot access the file 'C:\Repos\GVFSFunctionalTests\enlistment\16e733ff76ff49b5b457.gvfs\databases\ModifiedPaths.dat' because it is being used by another process.

@kewillford do you have more of the call stack or the logs from the test? Was this exception in the test code or in the product code?

In the test code
Full callstack:
2018-10-12T16:19:11.4331843Z System.IO.IOException : The process cannot access the file 'C:\Repos\GVFSFunctionalTests\enlistment\16e733ff76ff49b5b457\.gvfs\databases\ModifiedPaths.dat' because it is being used by another process.
2018-10-12T16:19:11.4332471Z    at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
2018-10-12T16:19:11.4333008Z    at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
2018-10-12T16:19:11.4333563Z    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
2018-10-12T16:19:11.4333945Z    at System.IO.File.Open(String path, FileMode mode, FileAccess access, FileShare share)
2018-10-12T16:19:11.4334369Z    at GVFS.FunctionalTests.Tools.GVFSHelpers.ReadAllTextFromWriteLockedFile(String filename) in C:\agent\_work\12\s\GVFS\GVFS.FunctionalTests\Tools\GVFSHelpers.cs:line 99
2018-10-12T16:19:11.4335238Z    at GVFS.FunctionalTests.Tools.GVFSHelpers.ModifiedPathsShouldContain(FileSystemRunner fileSystem, String dotGVFSRoot, String[] gitPaths) in C:\agent\_work\12\s\GVFS\GVFS.FunctionalTests\Tools\GVFSHelpers.cs:line 116
2018-10-12T16:19:11.4335872Z    at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WindowsUpdatePlaceholderTests.LockToPreventUpdate_MultipleFiles() in C:\agent\_work\12\s\GVFS\GVFS.FunctionalTests.Windows\Windows\Tests\WindowsUpdatePlaceholderTests.cs.cs:line 232

@kewillford @wilbaker Is it possible that the test is racing with the rename+overwrite in the product code? When the product code opens a handle to the file, it allows read sharing, but I don't know if the same applies when it does a rename over the top of an existing file.
If that is correct, then perhaps the test just needs to retry a couple of times?

@sanoursa that's a good theory.  @kewillford, I'm wondering if ModifiedPathsShouldContain should have this line in it:
this.Enlistment.WaitForBackgroundOperations().ShouldEqual(true, "Background operations failed to complete.");

That would ensure the BG tasks have finished updating ModifiedPaths, and it should eliminate the race mentioned by @sanoursa.
Thoughts?

@wilbaker Yes that sounds like the right fix to me.


Paving stones surfaces

Hi! I love this map style and has been using it on OSM as my default ever since I discovered it.
However, I think the style for areas paved with stones looks really out of style. It’s very dark and very visible. I also don’t remember it was like this a few weeks ago so it might be a recent change, though I might be wrong.
I’m talking of this styling:

For instances, a couple of screenshots of Copenhagen:

The dark gray areas are standing out a lot. It’s so dark that it seems like a zone that cannot be accessed, my first thought when I encountered it was that those were construction sites.
I believe it should be made lighter, closer to the colours of streets or sidewalks. The patterning is nice and can be kept.

Hi! Thanks for your feedback. Some other people share the same view. I can try to make pedestrian areas lighter and similar to pedestrian roads. Will do some exploration on that.

Updated opacity and it looks better!

Indeed thanks!
I wonder how it would look with a less contrasted outline stroke  (or none) as well? It kinda make it feel like a fence around it, while really you can walk easily though it. In reality most of the light gray between buildings and street lines (sidewalks, etc) is kinda the same as paved squares, places you can walk across. So having a dark gray line between the two is a little misleading?

Good idea! The gray border was from original carto style. Removed the border and it's clean and still recognizable. It's now updated and will be rerendered in a few days!

This is great! Thanks, looking forward to the update :)


Add nmbs_read_single_register

it should be nice to include a nmbs_read_single_register, exactly like nmbs_write_single_register.
thanks.

Hi, nmbs_read_single_register does not exist because the API is meant to reflect 1:1 the function codes found in the official modbus spec. The spec effectively presents a bit of asymmetry between the read/write FCs, but I prefer the API to be coherent, at least for the "core" ones.

OK, got it.
Thanks for the answer.
Thanks for this library.


Support for Cloudflare Workers

Hi!
I'm running my grammy telegram bot on CFW (Cloudflare Workers) and I would like to use the @grammyjs/conversations plugin. However this plugin has an indirect dependency to @deno/shim-deno though o-son.
This dependency leads to errors at build time.
// ...
const bot = new Bot(token)
bot.use(conversations()); // This line causes the error
// ...

When I try to deploy my bot with wrangler deploy (or to run it locally with wrangler dev), I have this error:
...
✘ [ERROR] Could not resolve "fs"

    node_modules/.pnpm/isexe@2.0.0/node_modules/isexe/windows.js:4:17:
      4 │ var fs = require('fs')
        ╵                  ~~~~

  The package "fs" wasn't found on the file system but is built into node.
  Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility.

✘ [ERROR] Could not resolve "util"

    node_modules/.pnpm/o-son@1.0.2/node_modules/o-son/script/_dnt.shims.js:7:23:
      7 │ const util_1 = require("util");
        ╵                        ~~~~~~

  The package "util" wasn't found on the file system but is built into node.
  Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility.

✘ [ERROR] Could not resolve "path"

    node_modules/.pnpm/which@2.0.2/node_modules/which/which.js:5:21:
      5 │ const path = require('path')
        ╵                      ~~~~~~

  The package "path" wasn't found on the file system but is built into node.
  Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility.

✘ [ERROR] Build failed with 108 errors:

  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/internal/Conn.js:17:22: ERROR: Could not resolve "net"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/internal/fs_flags.js:33:21: ERROR: Could not resolve "fs"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/internal/fs_flags.js:34:37: ERROR: Could not resolve "os"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/classes/FsFile.js:28:32: ERROR: Could not resolve "fs"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/classes/PermissionStatus.js:9:102: ERROR: Could not resolve "events"

I only tail 3 of the 108 errors, but they all refer to an "Could not resolve" error. The unresolved libs are the following:

"path"
"utils"
"util"
"fs"
"fs/promises"
"os"
"url"
"process"
"net"
"events"
"child_process"
"dns"
"tls"
"tty"

They are mostly in the @deno/shim-deno package (103 out of 108) but also 3 in isexe ("fs"), 1 in o-son ("util" without s) and 1 in which ("path")
Of course, I've tried to add node_compat = true in the wrangler.toml and the output is the following:
...
✘ [ERROR] Could not resolve "fs/promises"

    node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/watchFs.js:5:27:
      5 │ const promises_1 = require("fs/promises");
        ╵                            ~~~~~~~~~~~~~

  The package "fs/promises" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "fs/promises"

    node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/writeFile.js:31:32:
      31 │ const fs = __importStar(require("fs/promises"));
         ╵                                 ~~~~~~~~~~~~~

  The package "fs/promises" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Could not resolve "fs/promises"

    node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/writeTextFile.js:31:32:
      31 │ const fs = __importStar(require("fs/promises"));
         ╵                                 ~~~~~~~~~~~~~

  The package "fs/promises" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.

✘ [ERROR] Build failed with 20 errors:

  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/chmod.js:28:32:
  ERROR: Could not resolve "fs/promises"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/chown.js:28:32:
  ERROR: Could not resolve "fs/promises"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/copyFile.js:31:32:
  ERROR: Could not resolve "fs/promises"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/link.js:28:32:
  ERROR: Could not resolve "fs/promises"
  node_modules/.pnpm/@deno+shim-deno@0.16.1/node_modules/@deno/shim-deno/dist/deno/stable/functions/lstat.js:31:32:
  ERROR: Could not resolve "fs/promises"

Once again I only tail 3 of the 20 errors, but as you can see, only the : "fs/promises" package leads to an error now and all the other errors are gone. And all the 20 errors are in the @deno/shim-deno package.
Of course I don't need to use "fs" for my use case, because I use the @grammyjs/storage-supabase for the storage and we don't have access to the file system in the CFW environment anyway.
My question is: will you plan to support the CFW environment for this plugin? If not, is there some workaround we can implement to bypass this issue?
Thank you for your time!

We just need to provide a web build. This is being tracked at https://github.com/grammyjs/grammY/issues/372. Closing as duplicate.

Hey there
Does this have a resolution? Checked the threads and seems build needs to have web version?

Yes, i used @ponomarevlad/grammyjs-conversations as a temporary solution.


ci: update build-and-test workflows

Description
Update Build and Test workflows to sync with Autoware.Universe CI.
This PR adds:

daily tests for build-and-test
use aws code build
use cache to improve build time

Related links
https://github.com/autowarefoundation/autoware.core/issues/92
Tests performed
https://github.com/autowarefoundation/autoware.core/actions/runs/11815691460
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.
[x] The PR has been properly tested.
[x] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

They are now identical to https://github.com/autowarefoundation/autoware.universe/tree/main/.github/workflows
Only additional change to be made:
build-pre-command: taskset --cpu-list 0-6 to  --cpu-list 0-5 for the codebuild runner workflows. But can be made in another PR.


Cannot install plugin: Error

Error
$$$ leetcode plugin -i cookie.chrome
fs.js:145
    throw err;
    ^

Error: ENOENT: no such file or directory, unlink '/snapshot/leetcode-cli/lib/plugins/cookie.chrome.js'
    at Object.fs.unlinkSync (fs.js:1049:3)
    at Object.file.rm (/snapshot/leetcode-cli/lib/file.js:83:13)
    at WriteStream.<anonymous> (/snapshot/leetcode-cli/lib/plugin.js:170:21)
    at WriteStream.emit (events.js:182:13)
    at fs.close (fs.js:2181:14)
    at zalgoSafe (pkg/prelude/bootstrap.js:256:10)
    at FSReqWrap.oncomplete (fs.js:171:20)

@ketankr9 are you using all-in-one binary? then you don't need install plugin since it's all in one now. you should see all plugins via leetcode ext

It's all in one binary, but why is my plugin not active?
Active    Name                Version
✘        cookie.chrome      2018.11.18

I have configured my extension by:
$$$ leetcode config plugins:cookie.chrome
{
  "profile": "Default"
}

Thanks


[Shows] Crash when no meta_image is available

This show has none https://www.artsy.net/show/serpentine-galleries-alex-katz. Looking at the shows for Alex Katz on Force doesn’t seem to reveal this show at all: https://www.artsy.net/artist/alex-katz/shows.
So either Force is not showing shows where the meta_image is missing or they are filtering out this show based on another flag that I have not been able to figure out, based on the data in metaphysics at least.
We shouldn’t even crash, but I would like to know if this is simply a problem with the show metadata that needs to be fixed or that we need to be doing something differently.

It looks likely that if there isn't a cover image the show is not displayed. I think maybe @1aurabrown could tell you for certain.


[Snyk] Upgrade @graphprotocol/graph-ts from 0.31.0 to 0.32.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @graphprotocol/graph-ts from 0.31.0 to 0.32.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 11 versions ahead of your current version.
The recommended version was released a month ago, on 2023-12-08.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (29f665b) 77.83% compared to head (8dd67ff) 78.46%.
 Consider uploading reports for the commit 71acdec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
+ Coverage   77.83%   78.46%   +0.62%
==========================================
  Files          40       27      -13
  Lines        3086     2442     -644
  Branches      625      507     -118
==========================================
- Hits         2402     1916     -486
+ Misses        479      365     -114
+ Partials      205      161      -44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot #[near_bindgen] expose a function with a duplicate name

Steps to reproduce:

Implement a function on your contract's default state struct, that is not annotated with #[near_bindgen]. Wlog, this function is called foo. Whether this function is part of a trait or implemented directly in an impl Contract {} block is irrelevant.
Implement another function foo as part of a different trait or impl block, this time annotated with #[near_bindgen].

Expected result: The WASM is generated, exporting & calling the correct function (that which is annotated with #[near_bindgen]).
Actual result: Various compilation errors, including multiple applicable items in scope, this method takes 1 argument but 0 arguments were supplied, etc. depending on the nature of the functions involved.
Sample code:
use near_sdk::{
    borsh::{self, BorshDeserialize, BorshSerialize},
    log, near_bindgen, PanicOnDefault,
};

#[derive(BorshSerialize, BorshDeserialize, PanicOnDefault)]
#[near_bindgen]
pub struct Contract {}

trait T1 {
    fn foo(&self);
}

trait T2 {
    fn foo(&self);
}

impl T1 for Contract {
    fn foo(&self) {
        log!("foo from T1");
    }
}

#[near_bindgen]
impl T2 for Contract {
    fn foo(&self) {
        log!("foo from T2");
    }
}

Error output:
error[E0034]: multiple applicable items in scope
  --> workspaces-tests/src/bin/testy.rs:30:8
   |
30 |     fn foo(&self) {
   |        ^^^ multiple `foo` found
   |
note: candidate #1 is defined in an impl of the trait `T1` for the type `Contract`
  --> workspaces-tests/src/bin/testy.rs:23:5
   |
23 |     fn foo(&self) {
   |     ^^^^^^^^^^^^^
note: candidate #2 is defined in an impl of the trait `T2` for the type `Contract`
  --> workspaces-tests/src/bin/testy.rs:30:5
   |
30 |     fn foo(&self) {
   |     ^^^^^^^^^^^^^
help: disambiguate the method for candidate #1
   |
28 | T1::foo(&#[near_bindgen])
   |
help: disambiguate the method for candidate #2
   |
28 | T2::foo(&#[near_bindgen])
   |

For more information about this error, try `rustc --explain E0034`.

Another, slightly more insidious example (serialize is the name of a function provided by the BorshSerialize derive macro):
use near_sdk::{
    borsh::{self, BorshDeserialize, BorshSerialize},
    log, near_bindgen, PanicOnDefault,
};

#[derive(BorshSerialize, BorshDeserialize, PanicOnDefault)]
#[near_bindgen]
pub struct Contract {}

#[near_bindgen]
impl Contract {
    pub fn serialize(&mut self) {
        log!("serialize");
    }
}

Error output:
error[E0061]: this method takes 1 argument but 0 arguments were supplied
  --> workspaces-tests/src/bin/testy.rs:16:12
   |
14 | #[near_bindgen]
   | --------------- an argument of type `&mut _` is missing
15 | impl Contract {
16 |     pub fn serialize(&mut self) {
   |            ^^^^^^^^^
   |
note: method defined here
  --> /Users/jacob/.cargo/registry/src/github.com-1ecc6299db9ec823/borsh-0.9.3/src/ser/mod.rs:44:8
   |
44 |     fn serialize<W: Write>(&self, writer: &mut W) -> Result<()>;
   |        ^^^^^^^^^
help: provide the argument
   |
14 | serialize(/* writer */)
   |

For more information about this error, try `rustc --explain E0061`.

I suspect it is related to the unqualified way in which the method is invoked here. However, I also noticed that this code is nontrivially different from the released code (v4.1.1) that I am using. I therefore also tested these examples using the most recent commit of near-sdk from this git repo, and got similar results.

The solution will require to make sure that #[near_bindgen] uses a fully-qualified syntax to call the foo method, so instead of currently generated (pseudocode):
#[cfg(target_arch = "wasm32")]
#[no_mangle]
pub extern "C" fn foo() {
    // ... omitted
    let mut contract: MyContractStructure = near_sdk::env::state_read().unwrap_or_default();
    contract.foo(); // <--- See here
    near_sdk::env::state_write(&contract);
}

It would need to generate:
#[cfg(target_arch = "wasm32")]
#[no_mangle]
pub extern "C" fn some_method() {
    // ... omitted
    let mut contract: MyContractStructure = near_sdk::env::state_read().unwrap_or_default();
    T2::foo(&contract); // <--- See here
    near_sdk::env::state_write(&contract);
}

Generic arguments would also need to be figured out somehow (I am not sure it is possible to do in general case).
Ultimately, I am not sure if the effort is worth it as error message is quite clear, and the solution is to avoid the colliding method names. If anyone has the capacity to play with it, go ahead, but I don't feel it should be solved as a priority item before 5.0 release.

This could potentially be solved by allowing aliases, something like #[alias(foo_2)]. Then even if we have to implement the two traits that have colliding method names - it would be possible and pretty easy to implement.
#[near_bindgen]
impl T2 for Contract {
    #[alias(foo_two)]
    fn foo(&self) {
        log!("foo from T2");
    }
}

which would result in
pub extern "C" fn foo_two() {
...
}

This could potentially be solved by allowing aliases, something like #[alias(foo_2)]

@ruseinov  You can assign me this, I'd like to try it on for size.

I can't assign issues, but I assume you can just take this on. @frol is the boss :)

@muse254 Go for it! Please, make sure you document this feature (if you go with the #[alias] approach), so it is easy to discover it.
@ruseinov Rly? Am I?

@muse254 Go for it! Please, make sure you document this feature (if you go with the #[alias] approach), so it is easy to discover it.
@ruseinov Rly? Am I?

Well, you can assign issues! That makes you more of a boss than me!

@encody Could you test if the latest main branch resolves your issue? (#1186 should have addressed it) Feel free to re-open this issue if it is not resolved.


sharding_round_robin_dispatch() hangs with FileLister

🐛 Describe the bug
When create an IterableWrapper with FileLister, the sharding_round_robin_dispatch() function will hangs forever:
from torchdata.datapipes.iter import FileLister
from torch.utils.data.datapipes.iter.sharding import SHARDING_PRIORITIES
rs = MultiProcessingReadingService(num_workers=4)
dp = FileLister('/foo/bar', ['*.png']).open_files(mode='b')
dp = dp.shuffle().sharding_round_robin_dispatch(SHARDING_PRIORITIES.MULTIPROCESSING)
dl = DataLoader2(dp.batch(4, drop_last=True), reading_service=rs)
for i, x in enumerate(dl):
    print(x)
    dl.shutdown()

Remove sharding_round_robin_dispatch or change dp to dp = IterableWrapper(range(100)) eliminates the hang issue.
Versions
PyTorch version: 2.0.0+cu118
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.5 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Clang version: Could not collect
CMake version: version 3.25.0
Libc version: glibc-2.31
Python version: 3.8.0 (default, Nov  6 2019, 21:49:08)  [GCC 7.3.0] (64-bit runtime)
Python platform: Linux-5.4.0-89-generic-x86_64-with-glibc2.10
Is CUDA available: True
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce GTX TITAN X
GPU 1: NVIDIA GeForce GTX TITAN X
GPU 2: NVIDIA GeForce GTX TITAN X
GPU 3: NVIDIA GeForce GTX TITAN X
Nvidia driver version: 530.30.02
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.7.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.7.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          32
On-line CPU(s) list:             0-31
Thread(s) per core:              2
Core(s) per socket:              8
Socket(s):                       2
NUMA node(s):                    2
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU E5-2620 v4 @ 2.10GHz
Stepping:                        1
CPU MHz:                         1203.945
CPU max MHz:                     3000.0000
CPU min MHz:                     1200.0000
BogoMIPS:                        4199.99
Virtualization:                  VT-x
L1d cache:                       512 KiB
L1i cache:                       512 KiB
L2 cache:                        4 MiB
L3 cache:                        40 MiB
NUMA node0 CPU(s):               0-7,16-23
NUMA node1 CPU(s):               8-15,24-31
Vulnerability Itlb multihit:     KVM: Mitigation: Split huge pages
Vulnerability L1tf:              Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full generic retpoline, IBPB conditional, IBRS_FW, STIBP conditional, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT vulnerable
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a rdseed adx smap intel_pt xsaveopt cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts md_clear flush_l1d
Versions of relevant libraries:
[pip3] numpy==1.23.5
[pip3] torch==2.0.0+cu118
[pip3] torchaudio==2.0.1+cu118
[pip3] torchdata==0.6.0
[pip3] torchmetrics==0.11.4
[pip3] torchvision==0.15.1+cu118
[pip3] triton==2.0.0
[conda] numpy                     1.23.5                   pypi_0    pypi
[conda] torch                     2.0.0+cu118              pypi_0    pypi
[conda] torchaudio                2.0.1+cu118              pypi_0    pypi
[conda] torchdata                 0.6.0                    pypi_0    pypi
[conda] torchmetrics              0.11.4                   pypi_0    pypi
[conda] torchvision               0.15.1+cu118             pypi_0    pypi
[conda] triton                    2.0.0                    pypi_0    pypi

I cannot reproduce the hanging issue. I get TypeError: cannot pickle '_io.BufferedReader' object since python doesn't support passing opened file handles across processes via pickle.
I recommend you to update the pipeline to:
dp = FileLister('/foo/bar', ['*.png']).shuffle().sharding_round_robin_dispatch(SHARDING_PRIORITIES.MULTIPROCESSING)
dp = dp.open_files(mode='b').map(decode_fn)...
dp = dp.batch()

And, I think it's better to move dl.shutdown() out of the loop

Thanks @SvenDS9 and @ejguan for providing solutions!
Closing this issue.


bufio: ReadSlice with size argument

ReadSlice works wonderful with character termination. How to get the same performance and simplicity with size prefixes, i.e. how to read a string with 'n' bytes?
Unless there's a good solution, I'm happy to contribute an implementation of the following.
// ReadSliceSize reads n bytes of input, returning a slice pointing at the bytes
// in the buffer. The bytes stop being valid at the next read. An n value larger
// than the buffer causes an ErrBufferFull, without any I/O.
// When ReadSliceSize encounters an io.EOF after reading some data, but not all,
// then it returns all the data in the buffer with an io.ErrUnexpectedEOF.
// Because the data returned from ReadSliceSize will be overwritten by the next
// I/O operation, most clients should use Read or WriteTo instead. ReadSliceSize
// returns err != nil if, and only if, an error occurs before buffering n bytes.
func (r *Reader) ReadSliceSize(n int) ([]byte, error)

// ReadString demos ReadSliceSize.
func ReadString(r *bufio.Reader) (string, error) {
        sizePrefix, err := r.ReadByte()
        if err != nil {
                return "", err
        }
        slice, err := r.ReadSliceSize(int(sizePrefix))
        if err != nil {
                return "", err
        }
        return string(slice), nil
}

Usecase already covered with Peek and Discard. Thanks anonymous! 🙂


add top_k parameter to rerank endpoint (#396)

add top_k parameter to rerank endpoint

RerankInput: top_k as optional + add field validation

handle top_k parameter in AsyncEngine

add tests for top_k

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.63%. Comparing base (2ffb8a7) to head (7e0b5e5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (2ffb8a7) and HEAD (7e0b5e5). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (2ffb8a7)
HEAD (7e0b5e5)

4
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   78.62%   72.63%   -5.99%
==========================================
  Files          39       39
  Lines        3008     3011       +3
==========================================
- Hits         2365     2187     -178
- Misses        643      824     +181

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: pyarrow dataframe iter_rows

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[x] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #372

Checklist

[x] Code follows style guide (ruff)
[x] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

@MarcoGorelli I found some open issues on arrow's repo that seem to be related to this https://github.com/apache/arrow/issues/28694 https://github.com/apache/arrow/issues/28689. They mention currently there is no really efficient way to iterate over rows.
Although one of them has a snippet with suggestion on how to implement itertuples might be useful https://github.com/apache/arrow/issues/28689#issuecomment-1378027972

There may be a way using column buffers, I didn't have the time to investigate fully 🙈

thanks - i think the suggestion looks good

@MarcoGorelli I added some changes to use buffer_size and yield from slice of pyarrow table and limit memory usage.

How did this pass the check_backend_completeness.py check?! 👀


PHP8.1 compatibilty

With Magento 2.4.4 moving to PHP 8.1 wallee should be compatible. But it still has several errors as of yet.
E.g. during compilation:
PHP Fatal error:  During inheritance of ArrayAccess: Uncaught Exception: Deprecated Functionality: Return type of Wallee\Sdk\Model\PaymentMethodConfiguration::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/wallee/sdk/lib/Model/PaymentMethodConfiguration.php on line 754 in /vendor/magento/framework/App/ErrorHandler.php:61

It is also set to only allow php ~7.1.3||~7.2.0||~7.3.0||~7.4.0 in composer.json

When will the module be PHP 8 / Magento 2.4.5 compatible, is there a public roadmap for the module?

Dear s1mplex1337, matmarchant
Sorry for the late response.
In the meanwhile Magento 2.4.4 should be compatible with PHP 8.1.
Please install for this the newest plugin version: https://github.com/wallee-payment/magento-2/releases/tag/1.3.3
If you still have then problems there please contact our support<EMAIL_ADDRESS>


Extract task nugetSpec from nugetPack to generate nuspec

On top of previous pull request

support Map for defining nuspec in nugetSpec which could allow more flexible nuspec generation like doing modification before generation
attemp to change the way on getting output based on task dependency, to avoid depending the output in configuration phase but could be changed during execution

:shipit:


feat(platform): cleaned up summary stats view

Moved the biology section to the top, formats/tools/algorithms to the middle, and sources/licenses to the bottom
Used "&" and "and" consistently in the section headings
Added alternating background to sections
Corrected width of sections
Used consistent casing and pluralization in the section headings
Made the section subheadings have an equal number of lines so that the plots are positioned consistently
Cleaned up plot spacing when there are only 2 occupied columns
Removed the titles of the plots; they're redundant with the section headings
Moved the modeling formats plot to the second section with methods and tools
Used our color scheme
Corrected capitalization of options attribute

@bilalshaikh42 todo

[x] The versions of dependencies appears to be corrupted. I needed to install with the --force option. This needs to be fixed. Note, this PR adds a new requirement<EMAIL_ADDRESS>and removes google-palette
[ ] Put the pie chart item labels in the pie. If the labels are long, use a bar chart
[ ] Use bar charts rather than pie charts when there's >= 6 items

:tada: This PR is included in version 9.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

@bilalshaikh42 thanks for correcting the tests are merging this in.


At add lint badge

Se agrego la badge de Lint en el Readme

Pull Request Test Coverage Report for Build 180643217

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 180635839:
0.0%

Covered Lines:
37

Relevant Lines:
37

💛  - Coveralls

Pull Request Test Coverage Report for Build 180643217
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 180635839:
0.0%

Covered Lines:
37

Relevant Lines:
37

💛  - Coveralls


Merge physical and digitised works

I wrote these rules back in April but not sure if I shared them:
Rules for determining the print version of an E-book:
Use the contents of "Marctag":"776 w" from all "materialType" "e-book" bib records.
If the contents of subfield w contains the MARC organisation code (UkLW) in parentheses ignore this part of the code and use the remainder of the code, which starts with the letter b, to search for an exact match against "materialType" "Books" bibliographic record numbers. An exact match will identify the print counterpart to the E-book.
Example:
(UkLW)b21414440 ignore (UkLW) and use the remainder of the code: b21414440 to search for an exact match against other bibligraphic record numbers.
If the contents of subfield w contains the MARC organisation code (OCoLC) in parentheses use the entire code, including the code in parentheses and search for an exact match against the contents of "Marctag" : "035" in all "materialTye" "Books" bibliographic records.  An exact match will identify the print counterpart to the E-book.
Example:
(OCoLC)14322288 use the entire code: (OCoLC)14322288 to search for an exact match against "Marctag" : "035" in other bibliographic records.


Users should be able to delete their pin

Learn recyclerview, viewadapters, viewholders, android cards, and the ViewPin activity
You can add a dropdown menu to each "card" (the viewholder)
Add delete as one of the menu options
Delete only if the pin is owned by the user

Zane was working on this!

@Zanelib1 you can assign an issue to yourself on the right under "Assignees"


Path of Altruism:  Improved Aura of Courage: Passive abilities showing as needing icons

Looks like two improved aura's are showing up on the icon bar that should be "hidden":

Let me know if this is on my todo list or not.  I think the second icon there would have been Improved Aura of the Guardian, but i need confirmation.

no need. this will most likely be fixed on next DLC.


enable safari extension

To test the extension:

Run Shadowmap Location.xcodeproj

Make sure you select your target (Mac, iOS), it support all platforms

Click Run

You would say something like that

Click open Safari Extention and enable it by doing the checkmark.

Now for Debugging you can from the Developer Menu.

@simonmulser make sure to change the icons, cuz it looks not good atm since I take it from chrome extension.

@simonmulser make sure to change the icons, cuz it looks not good atm since I take it from chrome extension.

Did you found somewhere the resolution needed for the image?

What kind of monster is this PR? :D

@simonmulser, i didn't do anything just create new project lol, I even remove a lot of useless files which using popup but since you use the action so yeah, the only thing that need to be changes the icons and some of text if you want, for the icon size I already put the icon-{size} so you can replace it, or maybe if you want me to do it for you, just send me your logo with high quality 1024x1024 and I will change it for all icons :)

Yes, please exchange the pictures! Remember if there is a 2x or 3x you need to use the double or triple resolution. Eg. 20x20@2x you need to use an image which is 40x40 and save it under the filename<EMAIL_ADDRESS>

Steps:

Open Shadowmap Location/safari in XCode
Select Shadowmap Location (macOS) > My Mac (Rosetta)
Run
Opens

Click on Quit and Open Safari Extension Preferences...
Nothing happens

Log:
2022-03-02 11:33:22.553868+0100 Shadowmap Location[97188:12705287] Metal API Validation Enabled

Similar if I run it as Shadowmap Location (macOS) > My Mac (Rosetta). There the log looks as follows:
2022-03-02 11:35:23.083698+0100 Shadowmap Location[97300:12707703] Metal API Validation Enabled
2022-03-02 11:35:23.094649+0100 Shadowmap Location[97300:12707703] Errors found! Invalidating cache...

Please simply use the logo and don't use the grey rectangle in the background.

@ahmedsafadii I think it makes sense to rename it to "Shadowmap for Safari" (I see this naming a lot on the App Store) and target it only for MacOS. IMHO it doesn't make sense to have this plugin for iOS. What do you think?

@ahmedsafadii I think it makes sense target it only for MacOS. IMHO it doesn't make sense to have this plugin for iOS. What do you think?

You can simply ignore it and build it only for macOS, and you need to know that the power of Safari Web Extention, you code one and its release for all types, in case you want it for macOS we can just build for macOS.

Can you please send me the logo here?

Steps:

Open Shadowmap Location/safari in XCode
Select Shadowmap Location (macOS) > My Mac (Rosetta)
Run
Opens

Click on Quit and Open Safari Extension Preferences... - Nothing happens
Log:

2022-03-02 11:33:22.553868+0100 Shadowmap Location[97188:12705287] Metal API Validation Enabled

You need to go to safari browser and then from the preference select extension, you will find it there.
btw we can set a meeting now to run it for you if you want.

Steps:

Open Shadowmap Location/safari in XCode
Select Shadowmap Location (macOS) > My Mac (Rosetta)
Run
Opens

Click on Quit and Open Safari Extension Preferences... - Nothing happens
Log:

2022-03-02 11:33:22.553868+0100 Shadowmap Location[97188:12705287] Metal API Validation Enabled

You need to go to safari browser and then from the preference select extension, you will find it there.
btw we can set a meeting now to run it for you if you want.

I saw that. But the button Quit and Open Safari Extension Preferences... should work, right? It doesn't work for me. When I click on the button nothing happens.

Steps:

Open Shadowmap Location/safari in XCode
Select Shadowmap Location (macOS) > My Mac (Rosetta)
Run
Opens

Click on Quit and Open Safari Extension Preferences... - Nothing happens
Log:

2022-03-02 11:33:22.553868+0100 Shadowmap Location[97188:12705287] Metal API Validation Enabled

You need to go to safari browser and then from the preference select extension, you will find it there.
btw we can set a meeting now to run it for you if you want.

I saw that. But the button Quit and Open Safari Extension Preferences... should work, right? It doesn't work for me. When I click on the button nothing happens.

If the Extensions preferences window doesn't open automatically, go to the Safari menu and select Preferences. In the preferences window, click on Extensions. The Extensions preference tab opens.

Steps:

Open Shadowmap Location/safari in XCode
Select Shadowmap Location (macOS) > My Mac (Rosetta)
Run
Opens

Click on Quit and Open Safari Extension Preferences... - Nothing happens
Log:

2022-03-02 11:33:22.553868+0100 Shadowmap Location[97188:12705287] Metal API Validation Enabled

You need to go to safari browser and then from the preference select extension, you will find it there.
btw we can set a meeting now to run it for you if you want.

I saw that. But the button Quit and Open Safari Extension Preferences... should work, right? It doesn't work for me. When I click on the button nothing happens.

If the Extensions preferences window doesn't open automatically, go to the Safari menu and select Preferences. In the preferences window, click on Extensions. The Extensions preference tab opens.

Yes, I do understand that. Maybe let's discuss the details in a meeting.
Let me know here when you updated the logos!

Can you check if you can simplify the required rights? Currently it says that the plugin can read any information of the website including passwords, browser history. But maybe this is already the least permissive setting.

@simonmulser Done, i update all icons, i had to do it using sketch :D

Logos are great!

Minor and maybe hard to fix: Browser extension icon should be always yellow or yellow when the domain is Google Maps/Earth or Shadowmap. Currently it's only yellow on the tab where it was clicked which is a bit weird.

rights

Sad this alert for all types of plugins only on safari :D

Maybe we can restrict the extension only be active on certain domains (Google Maps/Earth and Shadowmap)? But yeah, if there isn't any other option, let's go for this!

rights

Sad this alert for all types of plugins only on safari :D

Maybe we can restrict the extension only be active on certain domains (Google Maps/Earth and Shadowmap)? But yeah, if there isn't any other option, let's go for this!

https://lapcatsoftware.com/articles/security-safari-extensions.html
"permissions": ["activeTab"],

This is what we only use we have full permit over correct active tab, but this is normal don't worry.

An option we could try would be using the permission tabs (https://developer.chrome.com/docs/extensions/reference/tabs/) instead of activeTab and then just read the URL from the tab (https://developer.chrome.com/docs/extensions/reference/tabs/#get-the-current-tab).

I even try that and guess what

same message.

An option we could try would be using the permission tabs (https://developer.chrome.com/docs/extensions/reference/tabs/) instead of activeTab and then just read the URL from the tab (https://developer.chrome.com/docs/extensions/reference/tabs/#get-the-current-tab).

I even try that and guess what

same message.

This is not the same message Ahmed. This message is way better! It doesn't say anything about sensitive information like passwords and credit cards.
So if we can work with this permissions would be better IMHO. Or am I missing something?

An option we could try would be using the permission tabs (https://developer.chrome.com/docs/extensions/reference/tabs/) instead of activeTab and then just read the URL from the tab (https://developer.chrome.com/docs/extensions/reference/tabs/#get-the-current-tab).

I even try that and guess what

same message.

This is not the same message Ahmed. This message is way better! It doesn't say anything about sensitive information like passwords and credit cards.
So if we can work with this permissions would be better IMHO. Or am I missing something?

OHHHH yes sorry mb, I had read the above extension message, wait then let me try to get the tab URL from tabs and see.

are you ok with this ?

are you ok with this ?

No, that isn't better. Why does it suddenly show "sensitive information, including ...". We just want to read the URL in the tab and we don't wan't to read the content of the website.
So then let's stick with the initial permission. I think this is even worse.