Add document about port which is expected to be opened

Related: https://github.com/nec-openstack/remora/pull/14

@oomichi ^^


[DataFactory] Updating the version of ADF for nuget publish

Description

Updating the version of ADF and fixing chenagelog.md as some changes were lost on merge
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please add REST spec PR link to the SDK PR
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@hvermis please pull from master and update the branch
Will merge after CIs pass


Hash characters

Websites like Twitter often use # for folksonomy tagging. But there are two different hash symbols! There’s the # we all know and love [U+0023], and there’s ＃.  Looks pretty similar, but in fact it’s the Unicode symbol [U+FF03] 'FULLWIDTH NUMBER SIGN'
My understanding is that Japanese keyboards tend to use the fullwidth version, so sites accept both for hashtags.
Would you be interested in a PR for it?

Yes, thank you! That sounds indeed like a good addition.


replace scala's parsing combinators with fast-parse / parbioled2

Motivation
http://www.lihaoyi.com/fastparse/#Comparisons
Current usage of parsing combinators:

[ ] https://github.com/thomsonreuters/CM-Well/blob/b6a203a7e2ae5d7fe33ed0b1aa173909219e1b9d/server/cmwell-ws/app/Parsers.scala
[ ] https://github.com/thomsonreuters/CM-Well/blob/b6a203a7e2ae5d7fe33ed0b1aa173909219e1b9d/server/cmwell-ws/app/controllers/SpHandler.scala#L174-L242

Would be nice to optimize.
Can be a good issue for external contributors as it is not involved in core logic.

Has there been any analysis (i.e., profiling) to determine whether the use of parser combinators is a significant expense worth optimizing? What about the relative cost of combinators vs. regular expressions?
It looks like FastParse might have a cleaner (functional, immutable) API that might give it an edge over the Scala combinators in terms to making the parsing code clearer.

@Andy-42

to determine whether the use of parser combinators is a significant expense worth optimizing?

Haven't seen tracing / profiling efforts yet, there's no way to determine that right now and prioritize accordingly.

cost of combinators vs. regular expressions?

Regex cost is massive, when we're talking about plain URI matching - there are not that many projects using Regex based path matching, and it's considered a bad practice in general.
It's a common problem for Golang, Rust, C# projects.
Regex cost is n^2 or n^3 in general, because of the internal FSM / stack-based context implementations. And custom combinator based implementations have  log(n) complexity at worst, because either have no backtracking or stripped prioritized matching with prefix trees.
https://github.com/buaazp/fasthttprouter
https://github.com/http-rs/route-recognizer/blob/master/src/lib.rs#L142
Using plain combinators for this will not give expected benefit because of the absence of the task specific optimizations.


New Library for Sourcecode-Editor and Code-View

The current Library (Code-Flask) is very basic and doesn't add a lot of features. All it offers is a very basic syntax highlighting.
It would be nice to replace Code-Flask with a library that additional offers at least:

Code-Completion (for basic language features and a robot specific API)
Language-Specific-Highlighting
Easy extendability and customizability

solved


SQLite updating create method adding new column to a table  - BUG

Resources:
Before submitting an issue, please consult our troubleshooting guide (http://ionicframework.com/docs/troubleshooting/) and developer resources (http://ionicframework.com/docs/developer-resources/)
Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[x] 2.x
[ ] 3.x
I'm submitting a ...  (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When SQLite updating create method adding new column to a table, some mobiles can not identify the change returning the error "table x has no column named y", being necessary change the widget id on config.xml to solve the problem.
Expected behavior:
Identify the change in all devices without need to change config.xml
Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

Hello! Thank you for opening an issue with us!
Since this is an issue with one of the Ionic Native Plugins and not with the Ionic Framework itself, I am moving this issue to ionic-team/ionic-native. Please follow the issue over there.
Thank you for using Ionic

This issue was moved to ionic-team/ionic-native#1951


MSID: 88916 Version: 1 DOI: 2<IP_ADDRESS>6009

"msas": "Chromosomes and Gene Expression", "Developmental Biology"
"msid": "88916"
"preprintDoi": "10.1101/2<IP_ADDRESS>6009"
"Reviewed Preprint posted": "2023-09-08"
"Sent for peer review": "2023-06-07"
"Posted to bioRxiv": "2023-05-02" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>6009v3/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=88916)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88916/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6009)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/88916/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88916)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88916

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88916

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88916/v1/88916-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88916)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

eLocations missing from reference list.


Add support for msgpack binary message format

Add few tests for protocol messages

Hi @kaashyapan ,
Thanks for the PR, I can see that after this PR the package in pub.dev is not showing WEB as supporte platform. Please check. thanks!

Hmm. I was under the impression that the following commit made it possible for the msgpack library to be transpiled to js.
https://github.com/knopp/msgpack_dart/pull/9
I will need to dig deeper...


[Refactor] Upgrade to react router 6

we currently use v5.2
https://reactrouter.com/docs/en/v6/upgrading/v5
Make sure to

replace history.push with navigate

For background - check out react-router tutorial


friendlychat use config only if it's defined

i need help to implement this friendly chat in my app.


Fix rst formatting for official releases page

Formatting for the releases page was done using markdown, but this
is actually an RST file. This switches the syntax over from md to
rst.

Coverage remained the same at 43.911% when pulling 375bbfd077b1b3cbc878ec20205dda803b0eabe0 on stmcginnis:aruba_doc into d9eca5ec3ff7ea8d49564864d517faefa6fdfb3a on opensds:development.


Adjust asset references in CSS/JS/JSON in Manganis

Related to #3325
Add functionality to update asset references in CSS, JS, and JSON files during the build process.

CSS Changes:

Add update_asset_references function to update asset references in CSS files.
Modify process_css to call the new function.

JSON Changes:

Add update_asset_references function to update asset references in JSON files.
Modify process_json to call the new function.

JS Changes:

Add update_asset_references function to update asset references in JS files.
Modify process_js to call the new function.

Hey, thanks for the PR! I don't see any actual functional changes here - is that intended?
I'm going to close this to clean up our tracker. If this PR is missing functionality changes then please ping me to re-open the PR or open a new one.
Thanks!


chore: move HttpSequenceHandler from id-broker to handlersjs-http

@arnevandoorslaer @BelgianNoise @AbelVandenBriel
does this fix https://github.com/digita-ai/handlersjs/issues/189 by any chance?


Initialize reconnectTimer in PhxSocket

Fixing autoReconnect feature. The reconnectTimer was always null so it basically didn't work at all.

👍 thanks again @AdamGrzybkowski


Type inference for exact strings

TypeScript Version:  2.2.2
Code
interface Css {
  position: 'absolute' | 'relative';
}
function style(rules: Css) { }

const rules = { position: 'absolute' };
style(rules);
style({ position: 'absolute' });

Expected behavior:
There should be no type issues.
Actual behavior:
style(rules) yields

Argument of type '{ position: string; }' is not assignable to parameter of type 'Css'
Types of property 'position' are incompatible

Using style({position: 'absolute'}) works fine.

#16360 just now seemed a bit similar (about tuples instead of objects).

duplicate of https://github.com/Microsoft/TypeScript/issues/16523 and https://github.com/Microsoft/TypeScript/issues/12955

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Implement Variable Width Font Rendering

Fixes #10

There are various things that I'd change/optimize/code differently.
I need to think more about this.
I may just merge it in a separate branch and slowly work on it before porting it to main.

Sounds like a good plan. It's your codebase so I was expecting you to rewrite some parts that you don't like anyways. At least the current state works well and I reasonably presentable.
However, there were some things that turned out slightly more complicated than I would've like, for example the font shadow logic which uses colors 15 and 7 specifically because 15 | 7 = 15 and 2 | 15 = 15 and 2 | 7 = 7 witch simplifies the rasteriser part. Also, the idea with the allocate tiles function was to allocate several tiles at once, by counting how many tiles were needed before rasterising characters, which in the end didn't happen.
For curiosity, what part do you think should/can be optimised? Too me, the slowest function seems to be convert_1bpp which will loop 64 times for each tile. Or maybe you mean optimise for ease of understanding/readability? Just curious :)

Haven't really looked at it, so I don't really know, besides the style.
In regards to your question, for 1bpp conversions you can prepare a 1bpp to 4bpp conversion table for the single rows, meaning you only need to iterate 8 times.

That sounds like a good idea. But you probably need 2 tables since there are two font colors (foreground +shadow). That should take and additional 2kB of ram which is not very much and provide a significant speedup. Good idea 👍

Hey, just an update, I should be able to look at this in the weekend.
I'll probably also need to rework a bit the text system.
To make it look nicer and all.
Again, thanks so much for the PR!

Yea, go ahead and rework it a bit to your liking. Glad I could help out. :)
Also, it should be possible to compress the font. I didn't have an lz-compressor available at the time, but that would be a nice way to save some well needed space since almost all 256kB EWRAM is used up.


add pillow==8.3.1

This should trigger a warning about pillow==8.3.1 being a vulnerable package, according to this Jira issue: https://statistics-norway.atlassian.net/jira/software/projects/DAPLA/boards/10?selectedIssue=DAPLA-486
This should not be merged, and is only a test to see if vulnerabilities in Docker images are picked up on by our build pipeline.

It seems like Google Vulnerability scan only checks the OS, not the python packages. We need to find another way of scanning the python packages.

In the final version of the pipeline, the Trivy vulnerability check failed because there was no space left on device. I think that might be due to the fact that several instances of the pipeline were running at once, and I can't cancel the other runs. We should try running the latest version of the pipeline again once all the runs have timed out of completed.

2.51 MiB / 6.88 MiB [---------------------->________________________________________] 36.48% ? p/s ?6.88 MiB / 6.88 MiB [-------------------------------------------------------------->] 99.98% ? p/s ?6.88 MiB / 6.88 MiB [-----------------------------------------------------] 100.00% 33.31 MiB p/s 1s2021-12-20T13:38:41.960Z	FATAL	scan error: image scan failed: failed analysis: analyze error: failed to analyze layer: sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0 : unable to get uncompressed layer sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0: failed to get the layer (sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0): unable to populate: unable to open: failed to copy the image: write /tmp/fanal-3773533808: no space left on device 2021-12-20T13:41:21.413Z	FATAL	scan error: image scan failed: failed analysis: analyze error: failed to analyze layer: sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0 : unable to get uncompressed layer sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0: failed to get the layer (sha256:3b12dc5ae360aa1ed5caae5f9afef3fa682f2f3be3c5acdd91de61f653ad72b0): unable to populate: unable to open: unable to export the image: Error response from daemon: write /var/lib/docker/tmp/docker-export-286548197/930c550180f2d893a15c262c0a05486d6ae8bf23c811616a16d36afdf2387d83/layer.tar: no space left on device ##[error]Bash exited with code '1'.
This is the "no space left on device" error from the Trivy image scan step of the Azure Pipeline.

I have now moved the Trivy vulnerability scan to happen inside the image, with Docker RUN command. The Conda Python3.9 folder is the one that is being scanned, specifically.

trivy does not scan the python distribution by specifying its path with the filesystem command. We can use Trivy to uncover other image vulnerabilities, and use Python safety check to uncover vulnerable python packages.

We agreed that trivy should not automatically fail the build because it might detect vulns in jupyterlab base that are not "real" and we might be willing to live with, but safety check should fail, because we don't want to introduce more vulns through python package installs.

Now that safety check is included in the image, and it fails the build when it finds pillow, and pillow has been removed again, we are ready to merge the branch into master, as soon as the build completes without errors!


Use link from/to type as a heuristic when evaluating triggers

This change allows us to more quickly discard triggers that won't match
when evaluating link contract insertions.
The types on the trigger filter are compared to the types declared on
the link contract, and if they don't match we can safely exit the
trigger evaluation logic instead of having to query the kernel.
Change-type: patch
Signed-off-by: Lucian Buzzo<EMAIL_ADDRESS>

@balena-ci rebase

@balena-ci I self-certify!


Document example of using a proxy

In my organization, services are deployed to private subnets with no internet access, requiring egress traffic towards the internet to go through a proxy where traffic filtering rules can be applied. One of the teams needed to connect to a third-party Kafka cluster over the internet, and had quite a challenging time getting it working, so I thought it'd be good to document an example of how to make it work.

How do you apply the socket factory?


Arnej/always append to logcontrol file

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@gjoranv please review
@bjorncs please review

The code looks fine, but I do not know how the loglevel control stuff works in order to say if this is correct or not from a higher level point of view.
Are there any unit tests related.


Bug: Voucher usage is not updated upon checkoutComplete

What are you trying to achieve?
I was trying to test checkout with voucher.
Steps to reproduce the problem

Run voucherCreate and voucherChannelListingUpdate
Create checkout with valid shipping and billing address, valid lines.
Add shipping method to the checkout.
Add created voucher to the checkout.
Create payment for the checkout's total.
Run checkoutComplete.
Check voucher's status by running voucher query.

What did you expect to happen?
Expected:
used:1
Actual:
used:0
Logs
Playground with all requests
Environment
Saleor version: core v3.18.0-a.0

If voucher is 'usageLimit': null then voucher.codes[x].used remains 0


remove repetitive words

Can one of the admins verify this patch?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @carrychair! If you sign the CLA, then we can merge this.

Thanks @carrychair! If you sign the CLA, then we can merge this.

Done. Please review again.

Thanks @carrychair!


model evaluation

I sincerely want to evaluate your model, how can I run it more simply

You can calculate the CLIP score using the evaluation method at https://github.com/rinongal/textual_inversion, hopefully this will help you!

You can calculate the CLIP score using the code in TI (https://github.com/rinongal/textual_inversion). Hopefully this will help you!

You can utilize the code in TI (https://github.com/rinongal/textual_inversion) to calculate the CLIP score. Hopefully this will help you!

You can utilize the code in TI (https://github.com/rinongal/textual_inversion) to calculate the CLIP score. Hopefully this will help you :)

You can reference the evaluation methods (or codes) in TI (https://github.com/rinongal/textual_inversion) or DreamBooth (https://github.com/google/dreambooth). Hopefully this will help you :)


Typo in documentation example for semver

In the example for semver in the documentation we have:
tags:
      - 'v*'

In "pure" simver "1.2.3" (vs basic example "v1.2.3") the action won't be triggered because of the leading v; it should be:
tags:
      - '*'

This is not a typo:

A leading "=" or "v" character is stripped off and ignored.

See https://www.npmjs.com/package/semver#versions

The v character wasn’t striped in my repo or somehow it failed and when
taken out it worked.
On Tue, Apr 5, 2022 at 11:02 PM CrazyMax @.***> wrote:

This is not a typo:
A leading "=" or "v" character is stripped off and ignored.
See https://www.npmjs.com/package/semver#versions
—
Reply to this email directly, view it on GitHub
https://github.com/docker/metadata-action/issues/178#issuecomment-1089417643,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFNVMM7KMYT5VK7QP5IEZDVDSZ5TANCNFSM5RYAFHRQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Draft] Config Dump for Secret Discovery Service

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Config Dump
Risk Level: Small?
Testing: Unit Test
Docs Changes: N/A(Is config_dump auto gen doc enough?)
Release Notes: config_dump handler prints out Secret Discovery Service information
[Optional Fixes #Issue] #7111

/cc @lizan @JimmyCYJ @PiotrSikora
Still some rough edges and some questions that I'm unsure, but it should be ready to take a look, thanks!

fix builds? I think this is on the right track.

@lizan all tests pass, PTAL, thanks!

Friendly ping :)

/retest

All right, all required tests now passed. PTAL, thanks!

@lizan @mattklein123 is there anything that I need to merge this PR? Thanks!


(PUP-6188) Add utf-8 encoding to various calls throughout puppet

This PR builds on / supersedes #4898 from @Iristyle
PUP-6188 tracks an effort to ensure Puppet's various file system interactions are specifying utf-8 encoding where possible/applicable, possibly in Puppet::FileSystem.open and Puppet::FileSystem.exclusive_open, but notes the problematic situation resulting from the reordering of method arguments from Puppet::FileSystem::FileImpl#open to ::File.open:

Rubys {{perm}} in our call is renamed as {{mode}}, and is moved from position 2 to position 1
Rubys {{mode}} in our call is renamed as {{options}}, and is moved from position 1 to position 2
We don't support the passing in of Rubys {{opt}} which is where one would set {{:encoding => 'utf-8'}}

This is further complicated by the fact that ruby allows specifying mode, encoding, and other options a number of different ways via these parameters. For example, encoding and mode, which can be specified

via opt (ruby optional param 3) in an options hash, ie :mode => 'r', :encoding => 'BOM|UTF-8'
via a mode string (ruby param 2), containing one of:

an IO Open Mode: "r", "r+", "w"
an IO Open Mode with encoding: "r:IBM437", "w:BOM|UTF-8"
a list of | separated File Constants: File::CREATE|File::APPEND

This means it's not simply a matter of extending the definition of Puppet::FileSystem::FileImpl#open and Puppet::FileSystem::FileImpl#exclusive_open to support an options hash (and thus specifying :encoding => 'UTF-8' because such options may collide with those already specified by a user via the mode string (ruby param 2). We could probably handle this somewhat gracefully (a rudimentary first pass at this is in https://github.com/MosesMendoza/puppet/commit/ccb65927b22544239adbc49a7b054cc91016bdde) but it seems like less risk of backwards-incompatibility and less complexity overall to simply update the callers of Puppet::FileSystem inside of puppet to leverage the ability to pass encoding in via the mode string.
This PR does so in several places, explicitly specifying UTF-8 as part of the mode string and updating associated tests. When updating the puppet config face, it was discovered that the :set action has no unit testing associated with it (at least not that I can find) - all testing is at the lower level of Puppet::Settings::Inifile, so this PR also includes a commit that adds initial basic spec coverage of puppet config set. Additionally, where encountered, File.read was replaced with Puppet::FileSystem.read - it seemed as if some of these places existed before Puppet::FileSystem was implemented.
After discussion with @Iristyle it was determined that much of the test coverage here likely deserves substantial improvement. Specifically, creating new tests that actually create files containing unicode-only characters, passing them through the code under test, and validating the fidelity of the data actually remains intact. I'm not sure if this PR should be gated on the addition of such tests, but I don't disagree that they're justified.

CLA signed by all contributors.

e6969f5 commit message talks about the BOM bit, but doesn't specify it in the code

Thanks - updated message to remove reference to 'BOM'

Some additional comments based on what I've looked at locally:

The INI file UTF-8 work is being merged in #5361 prior to this code
2636a60 (SSL changes) should really be to ASCII, not UTF-8.  While UTF-8 will work, it includes a broader range of characters than strictly necessary for the SSL files in question.
6a00f40 is a set of changes that I don't think we should make.  System files should generally be written in the systems encoding.  I don't think that there are any guarantees around crontab files on AIX or Solaris being UTF-8, so I suspect that we should leave the Ruby default behavior of Encoding.default_external here, which should match the systems expectations.


Add an endpoint to retrieve infos about the API

So it's easier to adapt stuff in the front-end

updated (and bugfixed lol) in a18220430c35389ec0914620a91f94447c38275f


Create Electronics_Shop.cpp

The solution to issue #143 in C++

Hey!
Could you make a different folder named "Electronics Shop" in Algorithms folder and then commit the soln with naming as "solution.cpp". Because thats the naming convention here, even according to readme.md file. And when youve done so, let me know, i'll update the readme file too

Ok @Aarushi11H

@Aarushi11H, I have made the changes, please check

Algorithms/Electronic Shops/solution.cpp -> its Algorithms/Electronics Shops/solution.cpp
change add an 's' in the Electronic

@Aarushi11H, please see

Hi, Electronics Shop not Shops

Done


Create a Google sheet script to export Worksheet2 as JSON

In Elliot's data entry repo, create a script that posts content as JSON to an endpoint in the API.
[Documented here b/c it is needed to support API development]

This replaces Issue #1.
I'm planning to do two things:
1. capture a static copy of the data and add it as a unit test for the API.
2. Work with Elliot to set it up so he can run a test push upon request.
Is there anything else you want it to do at this point?

Just to get this someplace other than Slack:
The very mediocre incomplete version of the Apps Script (slurp up data from Worksheet 2 and post to a url) is attached to my copy of the spreadsheet at https://docs.google.com/spreadsheets/d/178b3lMSgzCBtZCxIqBJ8OmnQ9Nm4rWFe3OubnmPsIYg/edit#gid=2335020
I left a copy of the script in a gist in case there are access issues: https://gist.github.com/zachlipton/ce55a1b865d969a4f37c7bd45338c5d9

This is done.  Code is in data_entry repo.


createMuiTheme() and responsive styling

Hi Greg
Nice work on this by the way.
General question here, I haven't really been able to figure out in combination with Material Docs and yours;
How to style the responsive parts of the table.  I am successfully targeting items as instructed via the crerateMuiTheme and using MUIDataTableBodyCell and MUIDataTableHeadCell for example.
Though how do I target the same items in their responsive modes?  For example with the cellStacked property applied?
Is there a better way to do it other than using the crerateMuiTheme?
Sorry for being so general though pulling my hair out as of late, and would love to keep using this.
Cheers

In looking deeper at the code I realised what I was doing wrong.
Didn't really understand the 'root' and other parts of the css keys that could be used.
Shoulda done dome more research, but sometimes all it takes is a different approach and maybe some coffee.
Thanks

What did you discover .. I am trying the same thing using theme.breakpoints.down("sm") but its not applying?

Got it while looking through the code.
theme.overrides["MUIDataTableBodyRow"] =  {
responsiveStacked: {
[theme.breakpoints.down("sm")]: {
'&:nth-child(odd)': {
backgroundColor: 'blue'
}
}
}
}


Add Navbar

Please, go through these steps before you submit a PR.

[ ] My Pod Leader knows I'm working on this Pull Request
[ ] I've explained what the Pull Request is adding.
[ ] I've explained why this is important.

@akshitadixit Completed the NavBar task. Kindly review it.
Thanks!

Please make the necessary changes.


AttributeError: 'NoneType' object has no attribute '_meta'

When I try add processing meta, I get error:

AttributeError: 'NoneType' object has no attribute '_meta'

and get 2 warnings:

WARNINGS:
river.ProceedingMeta.groups: (fields.W340) null has no effect on ManyToManyField.
river.ProceedingMeta.parents: (fields.W340) null has no effect on ManyToManyField.

Django version 1.11.1

I found that the error in the river/admin/proceeding_meta.py
def get_content_types():
    content_type_pks = []
    ctt = ContentType.objects.all()
    for ct in ContentType.objects.all():
        model = ct.model_class() # <- HERE
        for f in model._meta.fields:
            if type(f) is StateField:
                content_type_pks.append(ct.pk)
    return content_type_pks

When there is parsing the content_type, and it encounters an admin, he can not get his model_class ().
I have not figured out how to solve it correctly, but just adding :
        if not model:
            continue

Everything worked as expected

Also, in Django 1.11.1 there is a command remove_stale_contenttypes, the implementation of which solves this problem

Just you commented, it works fine.
`def get_content_types():
content_type_pks = []
for ct in ContentType.objects.all():
model = ct.model_class()
if not model:
continue
for f in model._meta.fields:
if type(f) is StateField:
content_type_pks.append(ct.pk)
return content_type_pks`


Please review this initial version of the mailstore connector

Don't use com.axonivy.market as namespace. Market is just the place where it will be promoted. A good groupId is next to the existing email encriyption utility:

e.g.
com.axonivy.utils.email.mailstore
or
com.axonivy.utils.email.store

if we promote this as connector, which we do, then it would make sense to put in the connector namespace, e.g:
com.axonivy.connector.mailstore

Just jumped over the files. I've seen some tests. So it's ok for me!


CATEGORY - Feature Added

I have added the feature of Icons category for both the modes.
I have made four categories :

Households
Actions
Socials
Others

If you prefer some changes kindly mention.
@AshutoshDash1999

please keep the theme gray/black for the light mode too

@fantasticbuddy please resolve merge conflicts. Take a pull first.


[quorum] integrate aws secrets manager

Commit to be reviewed

feat(quorum): integrate aws secrets manager
This PR will allow the use of the AWS service called Secrets Manager to store sensitive information, similar to how we use HashiCorp Vault for the same purpose.

A guide named integrate-aws-secrets-manager-with-eks.md has been introduced to help users securely connect their EKS cluster with Secrets Manager using OIDC.
The Quorum master README has been updated to guide users on how to deploy a network with AWS Secrets Manager.
A Python script has been added that contains the CRUD operation code for AWS Secrets Manager, injecting the script into the container via ConfigMap.
The Quorum Genesis and Node charts code have been updated to support Secrets Manager.

fixes #2200

The keys will conflict if same platforms are deployed using the same secret manager region. See if the keys can be made unique using the namespace


UI Update of PostView

[ ] Make App Bar transparent

[ ] Change back icon to something like ios_back

[ ] Add more UI adjustments that you prefer

How do you want the post view UI to be updated

@Promise4235 Check the description now, it is updated.

Can you assign this PR to me

@Wizpna I'll assign it to you, but don't create commits from a different account.

Ok, thanks

I have submitted a pull request regarding this issue, please review and merge

@Wizpna Check out the comment in the PR

ok

Please can you throw more light on what you mean

I have fixed the issue, check out my new pull request

Hello, can I work on this?

@yash2189 I am going to push some changes and update the description after that you can work on it


Usage of Rrunning clair via docker is wrongly written.

Command line needs --net=host when docker is used to run clair.

net=host is an optional flag if you want to run Clair using the hosts networking namespace. It is not required for executing Clair, although I could be convinced to document this if we find users are confused about this functionality.

@jzelinskie I mean that in sample configuration localhost is used to connect to postgres. But when container is running in bridge network, there is no way to access localhost. I think that the document about running clair via docker works wrong.

Ah! It turns out that you can elide net=host on macOS. I'm fine with adding this in to correct the instructions for Linux users.
Sorry about that.


Format and fix warnings

I ran cargo fmt on the code and fixed the build warnings (except for one that will disappear once we add more statements).

Closed due to supersedence.


There are no inpainted backgrounds and blurred details.

Hello, thanks for your great and exciting work!
But i got some strange results using pretrained ckpts:
https://github.com/JeffreyXiang/ivid/assets/50802787/2ae6d103-0f5a-4a3f-9753-2e8742f6f228
https://github.com/JeffreyXiang/ivid/assets/50802787/c846104f-231a-4ef7-90d1-c8e1a5490c3e
Any suggestions?

It seems that you executed inference/render.py with scenes comprising solely of the initial unconditional views.
To generate a complete scene with 27 views, try running inference/sample.py with the 3x9 viewset option.
Can you please provide the commands you used? In case this is a bug, I will address it as soon as possible.
Thank you.

Thank you for your reply! I ran the following command:
python inference/sample.py --num_samples 2 --classes random \
    --viewset uncond --steps_uncond 1000 --steps_cond 50 --guidance 0.5

python inference/render.py \
    --scene_dir samples/imagenet128/viewset_uncond_steps_u1000_c50_guidance0.5/ \
    --output_dir samples/imagenet128/viewset_uncond_steps_u1000_c50_guidance0.5/rendering \
    --frames 60 --traj swing

Oh i get it. I'll try 3x9 for multi-view generation. Thanks a lot!


Clusters: Unable to edit local cluster

Setup

Rancher version: v2.10-e59c50a79bff2b6cc023bdbdb4e825190b7833fb-head
Rancher UI: master f878279
Browser type & version: Chrome

Describe the bug
User is unable to edit local cluster.

To Reproduce

go to cluster management
click ellipsis for local cluster
click Edit Config
notice Create button (should be Save) is disabled
add description
notice Create button is still disabled

Result
User is unable to edit local cluster.
Expected Result
User is able to edit local cluster.

Screenshots
https://github.com/user-attachments/assets/092c7ed3-c583-4072-b371-7797922782ac

Additional context

Problem not happening on RKE2 & k3s. QA to confirm if this is happening elsewhere; if this is only local, then it's a release note for 2.10.0 until we figure out what to do since code change here will touch a lot of things.

Looks related to [this](https://github.com/rancher/dashboard/blob/master/shell/models/management.cattle.io.cluster.js#L117) getter. There is a possiblity for regression in the provider/distro column of cluster list views, as well as routing to/from the 'edit config' of clusters generally. We'll need to verify behavior for each of the following cluster types:
local clusters:
    rke1
    rke2
    k3s
    hosted

downstream clusters:
    rke1 provisioned
    rke2 provisioned
    k3s provisioned
    rke1 imported
    rke2 imported
    k3s imported
    hosted imported

/backport v2.10.0

Closing this out as I have already tested this in 2.10.


Fix signing with wildcards

The current iteration of the tool throws an exception if the file is e.g.:
NuGetKeyVaultSign sign **/MyCompany.*.nupkg
because the outfile path is not properly set (contains wildcards as well). Setting outputfilepath copies all signed packages in the same file.
The fix allows also for copying all signed packages to e.g.:
NuGetKeyVaultSign sign **/MyCompany.*.nupkg --output .\signed

Thanks!


Dockerfile changes

Adds initial optimized dockerfile configuration that takes advantage of docker layer caching, and tries to minimize final image size

On my test system a fresh image build without any cache takes 1:26, and an incremental rebuild with a change to index.js completes in two seconds.


config: Fetch config from server in frontend

Instead of having it built into the application at webpack time, it is fetched at load time from the server.
This adds an express route named /config that returns a Status with the project configuration.
The client's entry page now needs to asynchronously fetch it from server using this route and the page is only rendered when the response is back. If there is an error while getting the configuration, the MaintenancePage is displayed.

I'll work on #54 first

Let's start from scratch here with where the application is at the moment


feat: add autonomys testnet shortname

I would like to add short name for Autonomys Tesnet

Solved in #936
This PR was not adding the shortName as in ethereum chains list
https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-490000.json


Fetch ledger channels from nitro node

This PR enables us to try fetching ledger channels from a nitro node. This is currently not working. To test:

Spin up nitro nodes in go-nitro using go run ./scripts/start-rpc-servers.go
Create a ledger channel using npm exec -c 'nitro-rpc-client direct-fund 0xaaa6628ec44a8a742987ef3a114ddfe2d4f7adce'
Load the dashboard.
Observe error logs on the nitro node.

2. npm exec -c 'nitro-rpc-client direct-fund 0xaaa6628ec44a8a742987ef3a114ddfe2d4f7adce

Since you're not specifying a port this is command is going to communicate with Alice's RPC server. So running npm exec -c 'nitro-rpc-client direct-fund 0xaaa6628ec44a8a742987ef3a114ddfe2d4f7adce tells Alice to start a direct-fund objective with 0xaa... which is herself. This causes things to blow up when Alice tries to send a message; she doesn't find any peer information for herself.
We might want to catch this earlier and return a clearer error message.


Add snippets section

Closing with https://github.com/mersocarlin/mersocarlin.com/pull/196.
I'll make separate blog posts instead.

Closing with https://github.com/mersocarlin/mersocarlin.com/pull/196.
I'll make separate blog posts instead.


Support more features for Safari

Related: https://github.com/fzyzcjy/flutter_rust_bridge/discussions/1611

btw, @uditrugman given https://github.com/flutter/flutter/issues/55323, seems that it is minified, and we need --profile to get stack trace.
(cd frb_example/flutter_via_create && just codegen build-web && flutter build web --profile)
(cd frb_utils && dart run flutter_rust_bridge_utils serve-web --web-root ../frb_example/flutter_via_create/build/web)

@uditugman: I'd guess that Safari does not allow that. (https://github.com/fzyzcjy/flutter_rust_bridge/discussions/1611#discussioncomment-8022421)

I checked into details (as was promised in https://github.com/fzyzcjy/flutter_rust_bridge/discussions/1611#discussioncomment-8020010). Seems that Safari does allow it. It is the headers that we need to set correctly.

WOW! That would be amazing.
Do you know which header should be set in order for Safari to allow creating nested workers with shared buffers?

Just look at my PR (or wait a bit more, I am still checking and working on it)


Assign scroll up/down action when hover

Hi. Thank you for your work. The program is great. I have a problem that I am unable to solve. I'm trying to assign a menu trigger to a pen button. I have read your directions for assigning as a 4 or 5 button, but unfortunately I do not have such an option on the Huion tablet. Is there a workaround?
And one more suggestion. In the case of a mouse, it would be nice to use a roll. E.g . In the case of a graphics program, if you hover the cursor over a specific menu item (e.g. Stroke), moving the roll up and down will increase and decrease the stroke width. Ability to assign a shortcut for the up and down scroll.

Maybe it could be function instead, like a 'Scroll Wheel Control' function?  So you select the function and then scrolling would send whatever user-remapped keys until you do something to revert the scroll wheel function (like move the mouse a certain distance or click).  This avoids complicating the UI of the pie menu, and works within the current system.  The means of reverting the scroll functionality feels a little jank, not really sure what would be best here.


charts/csm-application-mobility: Update Velero install component to 1.11.1

Is this a new chart?
No
What this PR does / why we need it:
Which issue(s) is this PR associated with:
Adds Velero 1.11.1 support -> will be needed for AM install
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

closing this PR due to duplicate commits -> see https://github.com/dell/helm-charts/pull/276 for fixes


Agent can't transfer data to controller!!!

Describe the bug
jaeger agent report error:
{"level":"info","ts":1617467900.6410925,"caller":"grpc@v1.29.1/resolver_conn_wrapper.go:143","msg":"ccResolverWrapper: sending update to cc: {[] <nil> <nil>}","system":"grpc","grpc_log":true}
{"level":"error","ts":1617467917.929262,"caller":"grpc/reporter.go:74","msg":"Could not send spans over gRPC","error":"rpc error: code = Unavailable desc = last resolver error: produced zero addresses","stacktrace":"github.com/jaegertracing/jaeger/cmd/agent/app/reporter/grpc.(*Reporter).send\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/reporter/grpc/reporter.go:74\ngithub.com/jaegertracing/jaeger/cmd/agent/app/reporter/grpc.(*Reporter).EmitBatch\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/reporter/grpc/reporter.go:53\ngithub.com/jaegertracing/jaeger/cmd/agent/app/reporter.(*MetricsReporter).EmitBatch\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/reporter/metrics.go:85\ngithub.com/jaegertracing/jaeger/cmd/agent/app/reporter.(*ClientMetricsReporter).EmitBatch\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/reporter/client_metrics.go:121\ngithub.com/jaegertracing/jaeger/thrift-gen/agent.(*agentProcessorEmitBatch).Process\n\tgithub.com/jaegertracing/jaeger/thrift-gen/agent/agent.go:157\ngithub.com/jaegertracing/jaeger/thrift-gen/agent.(*AgentProcessor).Process\n\tgithub.com/jaegertracing/jaeger/thrift-gen/agent/agent.go:112\ngithub.com/jaegertracing/jaeger/cmd/agent/app/processors.(*ThriftProcessor).processBuffer\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/processors/thrift_processor.go:122\ngithub.com/jaegertracing/jaeger/cmd/agent/app/processors.NewThriftProcessor.func2\n\tgithub.com/jaegertracing/jaeger/cmd/agent/app/processors/thrift_processor.go:87"}

To Reproduce
Steps to reproduce the behavior:

Deploy Jaeger using the Jaeger Operator
Create a POD application and inject Jaeger
Report the data through a Python script

import logging
import time
from jaeger_client import Config

if __name__ == "__main__":
    log_level = logging.DEBUG
    logging.getLogger('').handlers = []
    logging.basicConfig(format='%(asctime)s %(message)s', level=log_level)

    config = Config(
        config={
            'sampler': {
                'type': 'const',
                'param': 1,
            },
            'logging': True,
        },
        service_name='myapp',
        validate=True,
    )
    tracer = config.initialize_tracer()

    with tracer.start_span('TestSpan') as span:
        span.log_kv({'event': 'test message', 'life': 42})

        with tracer.start_span('ChildSpan', child_of=span) as child_span:
            child_span.log_kv({'event': 'down below'})

    time.sleep(2)
    tracer.close()

Check the POD internal Jaeger-Agent container log

Expected behavior
After running the Python script, the client reports the data to the jaeger-agent, which then successfully reports the data to the controller
Screenshots

Version (please complete the following information):

OS: Centos7.4
Jaeger version: 1.22
Deployment: Kubernetes1.16

What troubleshooting steps did you try?
Try to follow https://www.jaegertracing.io/docs/latest/troubleshooting/ and describe how far you were able to progress and/or which steps did not work.
Additional context
Add any other context about the problem here.

The follow is jaeger-agent containers manifets yaml:
  - args:
    - --jaeger.tags=cluster=undefined,deployment.name=myapp,pod.namespace=observability,pod.name=${POD_NAME:},host.ip=${HOST_IP:},container.name=myapp
    - --reporter.grpc.host-port=dns:///jaeger-collector-headless.observability.svc:14250
    env:
    - name: POD_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: metadata.name
    - name: HOST_IP
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: status.hostIP
    image: jaegertracing/jaeger-agent:1.20.0
    imagePullPolicy: IfNotPresent
    name: jaeger-agent
    ports:
    - containerPort: 5775
      hostPort: 5775
      name: zk-compact-trft
      protocol: UDP
    - containerPort: 5778
      hostPort: 5778
      name: config-rest
      protocol: TCP
    - containerPort: 6831
      hostPort: 6831
      name: jg-compact-trft
      protocol: UDP
    - containerPort: 6832
      hostPort: 6832
      name: jg-binary-trft
      protocol: UDP
    - containerPort: 14271
      hostPort: 14271
      name: admin-http
      protocol: TCP
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: default-token-4rwmk
      readOnly: true


Allow PHPDBG and use it for code coverage

[13:07:14][4348][~/GitHub/amphp/amp] $ vendor/bin/humbug configure
You need to install and enable xdebug in order to allow for code coverage generation.
[13:07:29][4349][~/GitHub/amphp/amp] $ phpdbg -qrr vendor/bin/humbug configure
Warning: Humbug may only be invoked from a command line
You need to install and enable xdebug in order to allow for code coverage generation.

Please allow humbug to be run via phpdbg and use phpdbg for code coverage if xdebug is not available.

Duplicate of #178

Right, #184 solves this.


43296: Add 2.8.2 hotfix; Add patch to update minio

Description
Hotfix to use an updated minio image. In current minio image exists a defect that delete requests for objects are returned as successful but are not removed from the PersistentVolumeClaim. This has been fixed upstream in minio.
Offline installers will need to mirror the new image before applying the patch.
quay.io/minio/minio:RELEASE.2024-10-02T17-50-41Z
quay.io/minio/minio@sha256:ea15e53e66f96f63e12f45509d2d2d8fad774808debb490f48508b3130bd22d3

Testing
The patch was tested by running the if statement in its own bash script
#!/bin/bash
if [[ -z "$SKIP_MINIO" ]];
  then
    echo "Saving old guardian-minio image to old-minio-image.txt"
    oc get statefulset guardian-minio -n $BR_NS -o jsonpath="{.spec.template.spec.containers[0].image}" >> old-minio-image.txt
    echo "Updating statefulset/guardian-minio image to quay.io/minio/minio@sha256:ea15e53e66f96f63e12f45509d2d2d8fad774808debb490f48508b3130bd22d3"
    oc set image statefulset/guardian-minio -n $BR_NS minio=quay.io/minio/minio@sha256:ea15e53e66f96f63e12f45509d2d2d8fad774808debb490f48508b3130bd22d3
fi

Without skipping:
BR_NS="ibm-backup-restore" ./testminioupdate.sh
Saving old guardian-minio image to old-minio-image.txt
Updating statefulset/guardian-minio image...

With SKIP_MINIO variable:
SKIP_MINIO=true BR_NS="ibm-backup-restore" ./testminioupdate.sh

Image has been tested internally and is compatible with 2.8.0, 2.8.1, and 2.8.2.
Platforms
This image is supported on amd64, ppc64le, s390x, and arm64.

Closing this. https://github.com/IBM/storage-fusion/pull/133 is the replacement.


Design a mechanism to allow dynamic AppHandlers in the IBC component

Currently, penumbra-ibc depends on penumbra-shielded-pool, because the penumbra-ibc crate contains the implementation of the ICS20 token transfer handler, which edits the shielded pool state. This isn't the design we want, though, because we want the penumbra-ibc crate to be a "foundational" crate like penumbra-storage that's also usable by other projects. #3125 brings this problem from the backburner to the front burner.
Packet handling in penumbra-ibc is performed by the AppHandler trait, which exposes a generic interface for custom behavior. But currently, this is hardcoded to use an implementation that does Penumbra-specific ICS20 handling. Instead, we need a way to allow a dependency to implement the AppHandler, and then somehow cause that app handler to be used by the penumbra-ibc code.
This may also mean the AppHandler trait needs to be object-safe, and that may cause issues.
Two ideas on how we could do this:

We could pass some kind of configuration object with the AppHandler implementation in somewhere. This may be difficult, because the existing Component interface used by penumbra-ibc may not have a way to pass in extra parameters.
We could use global state, and have a registration mechanism.  Dependencies would register app handlers at startup, and those handlers would be used during execution.

The downside of (2) is that it wouldn't be possible to have two different applications both using penumbra-ibc to do different things inside of the same process. This is kind of aesthetically displeasing, but I'm not sure it's a real problem at the moment, since it seems unlikely someone would, e.g., import all of Penumbra and all of Astria into one program. Otherwise, it seems potentially simpler.
In a previous iteration of informal design discussions with @avahowell about this issue, I think we'd felt that (2) was probably the right option, but we should compare both approaches.
We'll also need to design/refine the external interface, now that the AppHandler will be public.

@noot To provide context for this design work, it would be helpful to know about how Astria works, in particular, how Astria represents accounts and balances, and what Astria's ICS20 handler would need to do in order to record the results of token transfers.

We could pass some kind of configuration object with the AppHandler implementation in somewhere. This may be difficult, because the existing Component interface used by penumbra-ibc may not have a way to pass in extra parameters.

Another thought on this (cf #3126): we could make the penumbra-ibc code not implement the Component trait directly, but instead implement its own trait, like ComponentWithHandlerConfig or something.  This new trait would have almost identical methods, but with the addition of an extra parameter that would provide the dyn AppHandlers.
Then the downstream code that defines the AppHandler could provide a Component impl that would forward to the methods on ComponentWithHandlerConfig but passing in the correct app handlers.

@hdevalence Astria represents accounts and balances as just a key-value pair in state, where the key is accounts/balance/<ADDRESS>. For example, the transfer cod e here (https://github.com/astriaorg/astria/blob/main/crates/astria-sequencer/src/accounts/action.rs#L49) shows balance being updated in accounts. See the state_ext trait here for how balances (and nonces) for accounts are stored in state: https://github.com/astriaorg/astria/blob/main/crates/astria-sequencer/src/accounts/state_ext.rs
We only have support for the native token right now - for extending this to tokens, I imagine we can do something like changing the storage key to accounts/<TOKEN_ID>/balance/<ADDRESS>.


Feature/zenodo workflow fixes

This PR is mostly tuning safedata_validator to work cleanly with the metadata webserver implementation. There are some documentation updates, some minor tweaks and a rewrite of the safedata_post_metadata entry point to add functionality to update the gazetteer data stored on the webserver.

Oh and also does this pull request fix #36? (and also #25?)

No - doesn't fix either #36  or #25.

No - doesn't fix either #36 or #25.

Ahh right (I must admit to not fully grasping #25). Does this not fix #36 because the update_gazetteer function defined in zenodo.py wouldn't get a proper response from the server even if it was run with valid data?

Does this not fix #36 because the update_gazetteer function defined in zenodo.py wouldn't get a proper response from the server even if it was run with valid data?

No - the issue is that sdv used to get this data from the server (when that was the source of truth) and used a simplified version of the full GeoJSON. But now the server is just a metadata server, admins should be maintaining that GeoJSON resource and using it directly with sdv and pushing updates to the server as required.


improve photo zoom

[x] when you release your finger the scale should be preserved
[x] you should also be able to scroll around the picture

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Remaining issues will be closed by https://github.com/functionland/fotos/issues/145


Cannot read property 'getState' of undefined in routes.js

I am trying to use onEnter, passing store as parameter in code/client/routes.js. However I see TypeError: Cannot read property 'getState' of undefined. Seems store is function getState() instead on initial loading.
Here is the code is code/client/routes.js:
export default function({store})
{
		console.log(store)
		const routes =
		(
			<Route
				component={RequireRole}
				onEnter={RequireRole.onEnter(store)}>
				<Route path="/" component={Layout} />
			</Route>
		)
	return routes
}

Thanks.

mm, that was a bug.
I fixed it, try the latest version.
And it will be like this now: (new, correct)
export default function(store)
``

As opposed to this: (old, incorrect)

export default function({ store })

Post back if it works now.
The `store` is not an actual store, but it has `dispatch` and `getState` if that's sufficient

Might as well write it as:
export default function({ dispatch, getState })

Thanks.
On my first time call to store.getState() in RequireRole.onEnter, it says
store.js?9b69:92 Uncaught TypeError: Cannot read property 'getState' of undefined
I see store is undefined in first call in the react-isomorphic-render/build/redux/store :
	// redux-routermiddleware 	// (redux-router keeps react-router state in Redux) 	reduxReactRouter({ 		getRoutes: function getRoutes() { 			return create_routes({ 				dispatch: function dispatch(action) { 					return store.dispatch(action); 				}, 				getState: function getState() { 					// Here store is undefined 					return store.getState(); 				} 			}); 		},
Have I done something wrong after onEnter? Thanks.

It is undefined the first time because the store is created after the routes are created:
store = createStore(..., routes({ dispatch: (a) => store.dispatch(a), getState: () => store.getState() }))

You shouldn't nedd the store right away if you're using store in onEnter.

I see you have new commits , is it related to the above? Thanks.

Yes, I added an error message so that a user won't be faced with store is undefined.
Does your code work?
Or are you still having issues?


fix(cdk/stepper/stepper.ts) : Pressing stepper header and setting selectedIndex programmatically does not work correct

fix(cdk/stepper/stepper.ts) : Pressing stepper header and setting selectedIndex programmatically does not work correct

Basically what happens here is that if we choose 3rd step from the tabs and again go and click on Button(selected index=0) it wont work because the value of selected index is already 0 hence it won't change the tabs too. So what I have done is simply reset the steps if we get same index after clicking the button. What this will do is it will allow us to re-select all the tabs again without any issue.
---------->Please check the solution here<------------
Fixes #15627

@mmalerba thoughts?

Closing due to inactivity after the last comment from mmalerba - feel free to reopen this PR if you'd like to try and land a fix for the issue


Changed images may not have a draft article to preview the image in article context

If an article referencing an image has been published, and in a subsequent publish the image changes but not the article, then that article will not appear in the bundle review page. This means that the user is unable to preview the changed image in the context of the referencing article. The changed image will still show up in the "Changed images" section of the bundle review page, so the changed image can be seen by itself that way. Also, the user may preview the changed image in the context of the article locally, outside of the sfdoc system.

The fix for this should find every article that references a changed image, and if it doesn't already have a draft for that bundle, then a draft should be created to preview the changed image. The article draft would be identical to the already published version. If and when the bundle is accepted/published, these article drafts could be published as normal, or instead (preferred) they would not be published so that there's not a new version with no differences. In that case the draft could be deleted or left alone.


Build: Plumber: Upgrade 0.4

Another attempt to upgrade Plumber now we've done some work on the test harness

:+1: if it all works


Log certificate domains before and after renewal

Right now only the id is logged as a prefix (e.g. crt-3), so it's not possible to easily determine which certificate was renewed, or failed to renew.
New loogs look like this:
[2020-05-28T23:23:28Z DEBUG acmed::certificate] crt-2: Checking for renewal (domains: acmed-test.dbrgn.ch,acmed-test2.dbrgn.ch)
[2020-05-28T23:23:28Z DEBUG acmed::certificate] crt-2: Certificate expires in 89 days
[2020-05-28T23:23:28Z DEBUG acmed::certificate] crt-2: The certificate will not be renewed now

...or
[2020-05-28T23:23:12Z INFO  acmed::certificate] crt-1: Certificate renewed (domains: acmed-test.dbrgn.ch,acmed-test2.dbrgn.ch)

That is a simple but very nice improvement, thank you ! :)


[REQ] Add check output as PR comment

Describe your feature request
Is your feature request related to other issues/PRs?
Check report introduced with PR #14
Describe the solution you'd like
The output should be added automatically as comment for new PRs.
This provides a nice overview of changed references.

created requirement ID check.ci for this request.

closed with commit https://github.com/mhatzl/mantra/commit/7e4a5a5fbb6564adbd1b0f711e067925ba45e3c7
To get the output of mantra check, some string replacements had to be made.
See mantra_pr.yml for the full workflow.


Readme in build references prepack which does not exist.

Describe the bug
I am following the directions in the readme file in the build folder, but there no prepack script.
Problem line:

Run prepack script with 3 additional arguments, this will generate env.7z under WebUI\package_res folder.
npm run prepack <python_embed_zip> <get_pip_py> <ref_conda_env>

Scripts in my environment:
AI-Playground\WebUI\build>npm run
Scripts available in<EMAIL_ADDRESS>via npm run-script:
dev
cross-env VITE_PLATFORM_TITLE="for Local® Dev™ Mode" vite
pack-python
node build\pack-python.js .\package_res
pack-offline
node .\build\pack-offline.js .\package_res
prebuild
node build\prebuild.js .\package_res ..\service .\external
build
npm run prebuild && npm run build:arc && npm run build:ultra && npm run build:ultra2
build:arc
cross-env-shell PLATFORM="arc" VITE_PLATFORM_TITLE="for Intel® Arc™" "vue-tsc && vite build && node .\build\render-template.js && electron-builder --config build\build-config.json"
build:ultra
cross-env-shell PLATFORM="ultra" VITE_PLATFORM_TITLE="for Intel® Core™ Ultra" "vue-tsc && vite build && node .\build\render-template.js && electron-builder --config build\build-config.json"
build:ultra2
cross-env-shell PLATFORM="ultra2" VITE_PLATFORM_TITLE="for Intel® Core™ Ultra Series 2" "vue-tsc && vite build && node .\build\render-template.js && electron-builder --config build\build-config.json"
build:ultra2-offline
cross-env-shell PLATFORM="ultra2" VITE_PLATFORM_TITLE="for Intel® Core™ Ultra Series 2" "npm run pack-offline ultra2 && npm run prebuild && vue-tsc && vite build && electron-builder --config build\build-config-offline.json"
preview
vite preview
To Reproduce
Steps to reproduce the behavior:
Just following the directions in the readme in the build folder
Expected behavior
Following directions should work without error.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS:  Windows11
GPU:  Intel Arc A770 16G

Sorry, it's a typo. Fixed in https://github.com/intel/AI-Playground/commit/9729cb7227ca63f32fbd0181db030089cb869cdc


Add formatting

This adds auto formatting on save.
I formatted every file once, so there should be no unnecessary changes in future commits
I added a Github action, that will check formatting, build and test for every push.

@TobiUUlm can you check again

Looks good


Fields need to be dropped from data

On the 04/15 meeting it was discussed that meeting id and topic need to be dropped from the Zoom (and probably Bluejeans) reports. Also anything containing the meeting id (like the URL) need to be dropped as well.
We need a way of doing this easily per data source.
This includes from Zoom
total_meetings -> id, topic
total_webinars -> id, topic
zoom_courses_meetings -> meeting_number, topic, join_url

The Bluejeans script should drop meetingTitle and meetingId.

The zoom_courses_meetings will still need to be dropped, this might be just incorporated into #137 directly.

Verified in the lti_zoom_meeting table, both meeting_id and host_id fields are with hashed values.


Running command with missing required option throws AppInsightsAsyncCorrelatedErrorWrapper error stack trace

Steps to reproduce:
Run
o365 spo app get or o365 spo customaction get
Expected behavior:
Required parameter id missing
Actual:
C:\Projects\office365-cli (customaction-list -> origin<EMAIL_ADDRESS>λ o365 spo app get
Required parameter id missing

C:\Projects\office365-cli\node_modules\applicationinsights\out\AutoCollection\Exceptions.js:33
                        throw error;
                        ^
Error: Required parameter id missing
    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (C:\Projects\office365-cli\node_modules\zone.js\dist\zone-node.js:811:33)
    at new AppInsightsAsyncCorrelatedErrorWrapper (C:\Projects\office365-cli\node_modules\applicationinsights\out\AutoCollection\CorrelationContextManager.js:172:18)
    at Vorpal.<anonymous> (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:168:17)
    at callback (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:830:22)
    at C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:961:7
    at Session._commandSetCallback (C:\Projects\office365-cli\node_modules\vorpal\dist\session.js:440:5)
    at Session.session.completeCommand (C:\Projects\office365-cli\node_modules\vorpal\dist\session.js:520:12)
    at onCompletion (C:\Projects\office365-cli\node_modules\vorpal\dist\session.js:450:10)
    at Session.session.execCommandSet (C:\Projects\office365-cli\node_modules\vorpal\dist\session.js:465:5)
    at Vorpal.vorpal._exec (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:960:18)
    at Vorpal.vorpal._execQueueItem (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:751:17)
    at Vorpal.vorpal._queueHandler (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:735:10)
    at Vorpal.vorpal.exec (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:682:10)
    at Vorpal.parse (C:\Projects\office365-cli\node_modules\vorpal\dist\vorpal.js:166:12)
    at C:\Projects\office365-cli\dist\index.js:42:20

I will investigate when some free time.

So that's by-design behavior of Vorpal (base upon which the CLI is built) and app insights we use for gathering telemetry.
First of all, although Vorpal describes the notion of required options, it doesn't enforce them the same way it does with arguments. So basically, if your command has a required option, you have to check for it yourself in the validate method. Nothing we can do about that.
Currently, app insights is setup to automatically collect exceptions. We could disable it, but it might be useful for debugging edge cases, so perhaps better to leave it as-is for the time being.

Thanks! Yes, better leave it as is, but good to know. I will close the issue.

I believe I misunderstood it initially. While it's by-design for app insights to collect exceptions, missing a required parameter is not really an exception and we should handle it more gracefully, the same way it's handled when you are in immersive mode. Ideally, the behavior should be the same no matter in which mode you'r using the CLI.


Failed to extracting archive when use parallel jobs with ramsey/composer-install@v1

name: Run tests and deploy

on:
  workflow_dispatch:
  push:
    paths:
      - '**.php'
      - '**.js'
      - '**.json'
      - '**.xml'
      - 'composer.*'
      - '.github/workflows/main.yml'

jobs:

  test_php:
    name: Run PHP tests
    runs-on: ubuntu-18.04

    steps:
      - uses: actions/checkout@v2
        with:
          ref: ${{ github.head_ref }}

      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.0
          extensions: bcmath, curl, dom, filter, gd, hash, intl, json, libxml, mbstring, openssl, pdo_mysql, pdo, redis, simpleXML
          coverage: none

      - name: Install composer dependencies
        uses: ramsey/composer-install@v1
        with:
          composer-options: "--prefer-dist --no-scripts"

  check_php_syntax:
    name: Check PHP syntax
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          ref: ${{ github.head_ref }}

      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.0
          extensions: bcmath, curl, dom, filter, gd, hash, intl, json, libxml, mbstring, openssl, pdo_mysql, pdo, redis, simpleXML
          tools: cs2pr
          coverage: none

      - name: Install composer dependencies
        uses: ramsey/composer-install@v1
        with:
          composer-options: "--prefer-dist --no-scripts"

Failed to extract square1/nova-metrics: (9) '/usr/bin/unzip' -qq '/home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61' -d '/home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/344f5f96'

[/home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61 or
        /home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61.zip, and cannot find /home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61.ZIP, period.

    The archive may contain identical file names with different capitalization (which fails on case insensitive filesystems)
    Unzip with unzip command failed, falling back to ZipArchive class
    Install of square1/nova-metrics failed
Error: '/home/runner/work/REPO-NAME/REPO-NAME/vendor/composer/tmp-887e5e92dba4429f8f1bb7ee187d3e61' is not a zip archive.

Happens here as well, over and over again.
I cannot give exact numbers, but I'd say at least one in 5 pushes lead to a failed job (I have multiple parallel actions running).
Each time a different composer package is presented as cause, it is completely random. When I hit "Re-run all jobs" it usually works, but sometimes it doesn't.
So yes, @lptn might be right with the assumption that it is somehow caused by parallel jobs.

Happening more and more every day. Have to manually re-run the workflow, sometimes multiple times for it to successfully install composer dependencies.

It happens so often that now I have to look for it every time a workflow run and wait to restart it when fails. It started with a fail every now & then, eventually now becoming a bottleneck in every workflow run 😞

maybe its the same issue then https://github.com/ramsey/composer-install/issues/152

This is fixed in v2, please upgrade using ramsey/composer-install@v2 or<EMAIL_ADDRESS>Details are available on the release announcement and the README.
Thanks!


Propagate the local vocabulary in all operations

Here is a text for the final ("squash and merge") commit message:
The local vocabulary is now properly propagated in all operations. In the GroupBy operation, a copy is made before adding words to the local vocabulary (otherwise the local vocabulary of other operations would be affected, and there would be unexpected results when reusing results from the cache). There are tests that the propogation indeed works as expected for each operation.


update FormData interface on lib.d.ts

complete FormData interface definition based on spec below.
https://xhr.spec.whatwg.org/#formdata
FYI, after tsc 1.4, it seems need to be update using USVString or FormDataEntryValue
instead of string or any.

Thanks for the PR, and sorry for the late reply. This file is a result of a build, so in general you do not want to change the files in bin without changing the sources that generated them, as the next update to bin from a build will overwrite the changes.
The source file contributing the FormData definition is src\lib\dom.generated.d.ts. This file is as well auto generated. We generated the dom from IE's dom specifications. this makes it really easy for us to generated updated dom definitions. but it also makes it hard for hand editing it. we are looking into changing the process and making this file generated from a webidl definitions. this is however not in the immediate plan.
Is there an issue for the original issue?


Branchefinale

@HelmiSahli Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Lib: Title and legend alignment

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
According to the DSM right now, the title and the legend should be left aligned with the left axis of the graph (it needs to be determined for graphs that don't have axis). It's not the case right now in the library.
The main goal of the study is to determine if this feature is too complex to be added:

If the answer is no, the issue can be transformed into a feature request and it can be implemented right away.
If the answer is yes, it needs to be reported to the design team so they will be able to modify the kit accordingly and propagate it to the DSM and think about the new good practices.

Motivation and context
Update either the DSM or the lib to have the same rendering and rules.

 I have a legend with only two items, and i want them to be align in horizontal center. Not possible just by changing the echarts config because it is hardcoded in css...

Hello @vogloblinsky,
FYI, it seems like the legend can be horizontally centered from a design point of view if the legend look more related to the chart this way.
Technically speaking, it means that you can achieve this by using themeManager.externalizeLegends() just like the second example that we provide and arrange it the way you want .
For instance it would look like:
themeManager.externalizeLegends(
  myChart,
  [{ legendHolderSelector: '#results_stack_legend', seriesRef: ['result'], orientation: 'horizontal' }]
);

Title

Sub-Title

Meanwhile, I'll try to work on a version that will work with your issue.


Add AES-CBC CTS to providers

Added Algorithm names AES-128-CBC-CTS, AES-192-CBC-CTS and AES-256-CBC-CTS.
CS1, CS2 and CS3 variants are supported.
Only single shot updates are supported.
The cipher returns the mode EVP_CIPH_CBC_MODE (Internally it shares the aes_cbc cipher code). This would allow existing code that uses AES_CBC to switch to the CTS variant without breaking code that tests for this mode. Because it shares the aes_cbc code the cts128.c functions could not be used directly.
The cipher returns the flag EVP_CIPH_FLAG_CTS.
EVP_CIPH_FLAG_FIPS & EVP_CIPH_FLAG_NON_FIPS_ALLOW have been deprecated.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

Rebased CHANGES.md

Ping for rebase and @openssl/committers review

rebased..
Note the most complex code in here is in the ts128_XXX_encrypt() & ts128_XXX_decrypt() methods.
These have been extracted from existing code in cts128.c

Conflicting in the CHANGES.md :(
Review also required.

I would prefer a reveiw before rebasing. (Otherwise I am just going to be rebasing many more times).

rebased just for fun.

rebased to bring it up to date. Should not need reapproval.

Merged
7cc355c2e4e081dca3c6c345a75a2ab16800c807 Add AES_CBC_CTS ciphers to providers


Create cluster with basic auth enabled by default

Seems like basic auth is needed for easier setting up cluster admin role in CI flow, add this by default.
Link for where it's used: https://github.com/knative/test-infra/blob/0c57f0098eec578373e53489d73124cb3400338a/scripts/library.sh#L269
/cc @adrcunha

/lgtm


Suggestion: change name to "Polyfire" - shorter and sweeter, imho :-)

Please see subject for the point of the suggestion. The term "polymerfire" is just too long and awkward, not euphonic at all to me. I like "Polyfire" myself :-)

I appreciate the suggestion, but I'm going to err on the side of consistency -- Firebase official bindings always use the full framework name (e.g. AngularFire, ReactFire, EmberFire) and I'd like to keep it consistent. 😁


⚠ File access (beta) has degraded performance

In 7eafa6b, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 4418 ms

Resolved: File access (beta) performance has improved in 9a669c9.


[BDW][Media][Decode]yamidecode blocks at XGetWindowAttributes() after libva dlopen

Test Env:
Libva:                          (master)e97ac9e78cd475a13e722c455e34d5d39d0f059d
Libva_intel_driver:       (master)43bd81abdde40b50ac71f6f44eb04e4eaf5af5f6
libyami:                        (master) 8cc7e42ca49ea407b7e49db0e200f794e20fc49c
2..Test command:
/home/wenxin1/libyami/omx/libyami/tests/yamidecode -i /media/ts/H264_176x144_frame320.mp4 -m 1
input file: /media/ts/H264_176x144_frame320.mp4, renderMode: 1
libva info: VA-API version 0.37.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /opt/X11R7/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_37
libva info: va_openDriver() returns 0
X Error of failed request:  BadWindow (invalid Window parameter)
Major opcode of failed request:  3 (X_GetWindowAttributes)
Resource id in failed request:  0x2a4f740
Serial number of failed request:  14
Current serial number in output stream:  15

Hi Jiankang:
seems hard to fix, look at it only if you have time.


Valid_Session

What does this particular line do in the context of the dataset?
clicks_df['valid_session'] = clicks_df.session_id.map(clicks_df.groupby('session_id')['item_id'].size() > 2)
As far as I am able to understand, it groups by 'session_id', returns True if the numbers of items in the particular session > 2, else returns false. How is this binary pd.Series mapped to df_session_id? As far as I understand from pandas documentation, map is used to replace values.

Solved.
This line


Make the parser work for empty lines

I've included an example file in the tests that shows the problem.  When downloading files from Netflix subtitles there were two issues:

Sometimes there were more than the number of blank lines you were expecting
Sometimes within a caption there were blank lines

I've fixed both issues and the whole file can be parsed now.

@glut23 I've made the changes

@glut23 fixed!

Are we good to merge this?

Apologies for the delay merging this @sontek.


Change language to not use master and slave

Hi,
We're looking at starting to trial and use roxy-wi in my company but some of the language used in the GUI does not rhyme with our values, something which can be an obstacle for us.
I realise that some people see it as an empty gesture, but even empty gestures are sometimes worth doing, especially if there are no drawbacks to doing them.
It'd therefore be great if the terms master and slave can be changed to what the rest of the industry is using nowadays, for example primary and secondary/replica/follower/etc.
We'd highly appreciate it and it'd make the road to purchasing licenses a lot easier for us, and most likely a lot of other companies.
Kind regards,
Joakim Kingström

Hello, of course this is not a problem.  Could you please notify me when you purchase licenses, I will correct the text by that date


Share code btw functions and webApp

defining a parent directory for shared types led tcs to create a wrong tree structure in lib
importing functions types from the front caused compilation errors (did not spend too much time on this) due to the fact that files in functions were trying to be compiled when building the front (not needed)

We need to choose the best approach to solve this and:

share types
fix TEST_ACCOUNTS duplication

pls make sure that hot-reloading for functions code when using the emulators locally still work after the refactor


added skill - markdown table creation

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

Added compositional skill: Creation of markdown-formatted tables from natural language
It provides the ability to create simple tables in markdown format.
The query must state the columns used in the table, and then the data for the rows.
It is advised to provide the data row by row, with data for each row in a line. Fields separated by comma.

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

[x] The contribution was tested with ilab generate
[x] No errors or warnings were produced by ilab generate
[x] All commits are signed off (DCO)
[x] The qna.yaml file contains at least 5 seed_examples
[x] The qna.yaml file was linted and prettified (yaml-validator can do both)
[x] An attribution.txt file in the same folder as the qna.yaml file
[x] Content does not include PII or otherwise sensitive or confidential information
[x] Content does not include anything documented in the project's Avoid these Topics guidelines

@instructlab-bot precheck


building: Update Go version

I'm likely not going to sign the CLA, so feel free to close this PR and have the changes made under an “authorised” user.

I'm likely not going to sign the CLA, so feel free to close this PR and have the changes made under an “authorised” user.

@aviau updated this in another pending PR anyway so I'll close this one.
I'll probably be removing the CLA requirement soon here too.

@aviau updated this in another pending PR anyway so I'll close this one.
I'll probably be removing the CLA requirement soon here too.


Pre/beta

Results of the tests, the ones who failed for the graphs are the Ernies one

The Ernie tests fail because we have no Ernie key. The other test failures seem to be caused by non-deterministic behavior. We either have to use mock models for everything, or not test at all


404 error on Source Connectors link

On the page
https://www.adobe.io/apis/experienceplatform/home/services.html
the link to 'Source Connectors' (under Data ingestions) sends users to the following page which throws a 404
https://docs.adobe.com/content/help/en/experience-platform/source-connectors/home.html

The goURL has been updated and will point to the correct link within 24 hrs. In the meantime, Sources documentation can be found here: https://docs.adobe.com/content/help/en/experience-platform/sources/home.html

Hi Wendy
Can you please re open the ticket until the issue has been confirmed to be
resolved after the release.
closing before the issue is actually fixed could leave gaps and remaining
issues if not confirmed before closing.
Thanks
Ian
On Wed, 30 Sep 2020 at 04:15, Wendy Braun<EMAIL_ADDRESS>wrote:

Closed #36 https://github.com/AdobeDocs/experience-platform.en/issues/36
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AdobeDocs/experience-platform.en/issues/36#event-3821034767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMIVVL4MEHVOMCVUHNKOBQDSIIP3DANCNFSM4R324WFQ
.

The link is confirmed to be working. This issue is resolved.


[Bug] Fix invalid challenge slugs

Is there an existing issue for this?

[X] I have searched the existing issues

What projects are you seeing the problem on?
OpenChallenges
Current behavior
Example: http://localhost:4200/challenge/oropharynx-cancer-%28opc%29-radiomics-challenge-::-human-papilloma-virus-%28hpv%29-status-prediction
The slug format is defined in the API description but is not enforced at the database level, which this ticket could address.
Expected behavior
The challenge slug example posted above should include only lowercase a-z, 0-9 and dash as a separator (see slug format defined in the API description).
Anything else?
This behavior is observed in the PR #1433.
Commit ID
e977cb95cbacb9d1e46cd34660fec99317ec5348
Are you developing inside the dev container?

[X] I am using the dev container

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Whoops, thank you for that catch!!
Kaggle has their own slugs, which I accidentally overwritten -- will revert that change now.


Download torrent team crashes

Example:
OS windows, centos
download torrent by infohash in command line:
webtorrent download 3d86eaaef6ce444da7761f39b16859c1f8b4f99b
the file is downloaded and a while crashes:
ERROR: If you think this is a bug in webtorrent, report it!
=====>                                               <=====
=====>  https://github.com/feross/webtorrent/issues  <=====
=====>                                               <=====

In previous versions 0.3- it was all good

@KrasCYBORG Can you share the full stack trace when you see the error? I can't debug with such limited information.

I'm going to close this since there's not enough info for me to understand the problem. @KrasCYBORG If you're reading this, feel free to comment with more info or open a new issue.


code quality

Codecov Report

Merging #273 (8d09d59) into master (57acb32) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage     47.02%   46.34%   -0.68%
+ Complexity      490      486       -4
============================================
  Files           117      117
  Lines          2624     2615       -9
  Branches        183      183
============================================
- Hits           1234     1212      -22
- Misses         1308     1325      +17
+ Partials         82       78       -4

Impacted Files
Coverage Δ
Complexity Δ

...eedu/address/logic/commands/AddExpenseCommand.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

.../seedu/address/logic/commands/ExchangeCommand.java
61.11% <ø> (ø)
5.00 <0.00> (ø)

.../seedu/address/logic/parser/EditCommandParser.java
59.09% <ø> (-0.17%)
4.00 <0.00> (+2.00)
:arrow_down:

...rc/main/java/seedu/address/model/expense/Date.java
62.50% <ø> (-13.11%)
10.00 <0.00> (-1.00)

.../seedu/address/model/expense/StatisticSummary.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...n/java/seedu/address/model/expense/Statistics.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../main/java/seedu/address/model/expense/Amount.java
50.00% <0.00%> (-25.00%)
7.00% <0.00%> (-1.00%)

...ain/java/seedu/address/model/expense/Category.java
50.00% <0.00%> (-18.75%)
7.00% <0.00%> (-1.00%)

...in/java/seedu/address/logic/parser/ParserUtil.java
58.18% <0.00%> (-10.91%)
12.00% <0.00%> (-3.00%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57acb32...8d09d59. Read the comment docs.


Release version 0.2

Once #1 is closed, release version 0.2 and build on conda-forge.

Move this repo to the climlab org prior to releasing version 0.2


[SUPPORT] OverwriteNonDefaultsWithLatestAvroPayload not work in mor table

Describe the problem you faced
Try to update some field with new value，OverwriteNonDefaultsWithLatestAvroPayload works in MOR table not work
I hope to update a dataframe that changes xx field to newValue , and xx2 field to previous value.
To Reproduce
Steps to reproduce the behavior:

create a mor table
read mor table  as DataFrame df
df.withColumn(xx, new Value).withColumn(xx2, lit(null).cast(StringType) )
df.write.format("hudi").option(DataSourceWriteOptions.PAYLOAD_CLASS_OPT_KEY, classOf[OverwriteNonDefaultsWithLatestAvroPayload].getCanonicalName)
read the mor table, I found the xx2 field is set as null but not the previous value.

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version :0.7.0,  0.8.0

Spark version :2.4.5

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

@shenbinglife I'm trying to understand the issue you are facing.
Are you expecting to just change xx field to newValue and let xx2 field continue to have it's previous value ? If yes, you can try the following:
df.withColumn(xx, new Value) and then perform the upsert. Once that is done, try to do the following :

Run a realtime query on the mor table with _rt
Compact the table
Run a read optimized query on the mor table

@n3nash I was trying this out, so if i understand this feature it is trying to update the value only for the keys whoo are not equivalent to theie default Value.

So, in this case if i construct defaultValue = null , I dont think it is working for Union type of Schema like

["null", "long"], default : null

@tandonraghav I'm not following. Can you describe it more concretely ?

@shenbinglife : Did you get a chance to try it out

we need to make a stab at reproducing this with MOR and the payload. There could be some impedance mismatch between merging logs by commit time vs the precombine field

@shenbinglife : I could not reproduce this. Here is what I tried.
Inserted a bunch of records to a new hudi MOR table.
Generated updates and marked one of the column as null (columns's default value is null). and upserted these to hudi.
On read, I can confirm that the column which I nullified, picked up the value from previous version of the record.
If your use-case is something different, let me know.
https://gist.github.com/nsivabalan/fa5d592d8ee08eb51c31835c7a51023c

@shenbinglife : let us know if you are looking for any more help. Or feel free to close the issue if you got it resolved.


Fix/true end step

What does this PR do?
partial of #3807
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @Borda! Thanks for opening this PR.

In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 189:13: W503 line break before binary operator
Line 191:13: W503 line break before binary operator

Do see the Hitchhiker's guide to code style


Client stub - Allow login

v2.experts.library.ucdavis has a complete set of fcrepo and ES data.  We can use some of the services, and the kibana interface to investigate thsi data.  However, we need  to have a simple client in place, just to have a login to have access to fcrepo

@UcDust I have started this at
git clone --branch=qh-experts https://github.com/ucd-library/aggie-experts-deployment.git

The client is at base-service/spa like dams/fin/ucd-lib-client where I got most of the data.  Let me know if you can make heads of tails of this, and we'll see if it's worth doing in this sprint

@qjhart @rakunkel-ucd
I've tried to strip out a lot of the extra packages and code, and created a basic landing page with a Sign In link in the header nav and a link to fcrepo. There's an open PR for this now.

To build the client code after the cluster is up, you just need to go in the terminal to /aggie-experts/services/base-service/spa/client and run npm run watch. This starts webpack and builds the client code for various page bundles.


Live reload in dev mode fails when multiple files are symlinks to the same path.

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When multiple files within the same project are symlinks to an identical path, dev live no longer works.
Steps to Reproduce

Create a new project.
Create a new file.
Create 2 symlinks to the original file.
Open Atom in developer mode.

Expected behavior: Live reload on edit of either the original file, or when opened via the symlink.
Actual behavior: No live reload.  Is there any other way around to get rid of this error?

In the I deleted .atom and .config/Atom Now the problem gone

I'm having exactly the same issue. I tried doing apm unlink --dev and apm unlink, but that doesn't work because I can't test my package otherwise. I also can't remove the first symlink because I'm using it as a mountpoint for my data drive.

I'm having trouble reproducing this.  Here's what I tried:

Clone the https://github.com/atom/timecop repository
Create two symlinks, styles\symlink.less and styles\symlink2.less that both point to styles\timecop.less

On Windows, I used the command mklink symlink.less timecop.less in the styles directory

atom --dev .

Expected and actual: Dev Live Reload watches files.

This issue was moved to atom/atom#18147


Query: Adds FIRST and LAST Scalar Expressions

Description
Adds FIRST and LAST to V3 DOM and Parser. Implements evaluation of FIRST and LAST.
Type of change

[] New feature (non-breaking change which adds functionality)

Closing issues
To automatically close an issue: closes #IssueNumber

/azp run

/azp run

/azp run


CocoaHTTPServer abandoned?

I'm just curious as to the status of this project. It hasn't been updated in 7+ months, there's tons of compiler warnings concerning depreciated functions, and a large queue of Github issues (most without any responses). I realize this is volunteer project, so I just want to know if it's advisable to find another solution for now. If the maintainer is busy with other projects, it might be a good idea to put a [Depreciated] tag next to the title in the README.

As a former contributor to CocoaHTTPServer myself, I have seen the project not being maintained for quite some time. Things happen, it was good while it lasted :)
That got me starting https://github.com/swisspol/GCDWebServer more than 2 years ago, which has a very modern codebase with lots of features and is quite popular now (and maintained!). You should have a look!

@swisspol I ended up using GCDWebServer instead of CocoaHTTPServer for IOCipher because it was a lot easier when working with virtual files.


Resolve DSP go.mod High Level Snyk CVEs

Description of your changes:
resolves: https://issues.redhat.com/browse/RHOAIENG-7308
Implemented fixes on my fork and tested out by importing the fork in my personal snyk account and making sure the CVEs were eliminated.
Checklist:

[ ] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

Commit Checker results:
**NOTE**: These are the results of the commit checker scans.
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between f3fbc2cfba32098ae1902ec8afa8d9661a2b30b0...4443eab6fa86d7274d75a3d5fb29b23b9b5a28f4

Closing this PR as it is duplicated by https://github.com/opendatahub-io/data-science-pipelines/pull/55

Commit Checker results:
**NOTE**: These are the results of the commit checker scans.
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 0 commits between 2aacfe2781c01939e087e188cdb04a0e117bfb2c...4443eab6fa86d7274d75a3d5fb29b23b9b5a28f4