Update teams-endpoint.md

@tomaschladek

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@bernice4winners - Can you respond to the requested changes or let us know if you would like us to commit them?
@tomaschladek - After the changes are made, please add a sign-off command to signal that the PR is ready to merge.

#sign-off


CNI Pod Subnet ignores Pod Subnet UDR

What happened:
When using CNI Pod Subnet with Dynamic Allocation, pod traffic is completely influenced by Node's NSG and Routes. I am not even sure that UDR are even applied in the pod subnets.
Also, this statement "the pod IP is always the source address for any traffic from the pod" from the docs appaers to be wrong.
From the docs:

Separate VNet policies for pods: Since pods have a separate subnet, you can configure separate VNet policies for them that are different from node policies. This enables many useful scenarios such as allowing internet connectivity only for pods and not for nodes, fixing the source IP for pod in a node pool using an Azure NAT Gateway, and using NSGs to filter traffic between node pools.

By examining vnet flow logs and evidence of impact of FW rules, everything points to packets being ultimately routed/SNATEd through and affected by the Node's subnet route table and NSG. Even if these are in different subnets with different policies (route tables and NSG).
The only official docs about CNI Pod Subnet seem to be:

https://learn.microsoft.com/en-us/azure/aks/concepts-network-azure-cni-pod-subnet
https://learn.microsoft.com/en-us/azure/aks/configure-azure-cni-dynamic-ip-allocation

Other links of interest:

https://learn.microsoft.com/en-us/azure/aks/concepts-network-legacy-cni

At the end of that post they mention this:

What source IP do external systems see for traffic that originates in an Azure CNI-enabled pod?

Systems in the same virtual network as the AKS cluster see the pod IP as the source address for any traffic from the pod. Systems outside the AKS cluster virtual network see the node IP as the source address for any traffic from the pod. But for Azure CNI dynamic IP allocation, no matter the connection is inside the same virtual network or cross virtual networks, the pod IP is always the source address for any traffic from the pod. This is because the Azure CNI for dynamic IP allocation implements Microsoft Azure Container Networking infrastructure, which gives end-to-end experience. Hence, it eliminates the use of ip-masq-agent, which is still used by traditional Azure CNI.

So this talks about "Dynamic IP allocation" VS Non dynamic IP allocation. Wether you are using one or the other seems to be related to a preview feature:
Register the subscription-level feature flag for your subscription: 'Microsoft.ContainerService/AzureVnetScalePreview'.

and to having the monitoring add-on enabled:
az aks enable-addons --addons monitoring --name <cluster-name> --resource-group <resource-group-name>

At this point I am not even sure what kind of CNI Networking modality is my AKS cluster using. To my understanding, Dynamic allocation is the default behaviour, and static allocation needs to be specified with (--pod-ip-allocation-mode StaticBlock) which is not yet available on terraform resource for AKS.
Example
Pod subnet has route to FW (<IP_ADDRESS>/0 -> VA) and Node subnet has same route.  FW is seeing traffic as coming from the node instead of the pod IP source address, so it is not possible to have specific FW rules for pod subnets.
Flow logs show that the packet is going through the nodepool's NSG with a source IP corresponding to the actual node:
<IP_ADDRESS> is the Node's IP
"1732605379536,<IP_ADDRESS>,<IP_ADDRESS>,48003,80,6,O,B,NX,0,0,0,0",
"1732605379568,<IP_ADDRESS>,<IP_ADDRESS>,48003,80,6,O,E,NX,3,383,2,220",
"1732605379568,<IP_ADDRESS>,<IP_ADDRESS>,48003,80,6,O,B,NX,0,0,0,0",

What you expected to happen:
Routing and NSG rules in a pod subnet when using CNI Pod Subnet should be applied independently of the node subnet's UDR and NSG.
How to reproduce it:

Create an AKS cluster on 4 subnets: node0, node1, pods0, pods1
Default node pool uses vnet node0 and pod subnet pods0
Windows node pool uses vnet node1 and pod subnet pods1
The pod has internet access
Add a route to pods1 subnet  [<IP_ADDRESS>/0 to None] expected result is that pod loses internet connectivity, but nothing happens
Add a route to nodes1 subnet  [<IP_ADDRESS>/0 to None] now the pod loses internet conectivity

Orchestrator and Version (e.g. Kubernetes, Docker):
Kubernetes: v1.30.5
Operating System (Linux/Windows):
Windows
Kernel (e.g. uanme -a for Linux or $(Get-ItemProperty -Path "C:\windows\system32\hal.dll").VersionInfo.FileVersion for Windows):
10.0.20348.2031 (WinBuild.160101.0800)
Anything else we need to know?:
I am not sure if this is a bug, a misconfiguration, or a misinterpretation of what the 'CNI Pod Subnet' feature is supposed to be.

hey @david-garcia-garcia I don't think this is the intended behavior with podsubnet, can you share azcli command or ARM template used to create your env for us to reproduce it?

@rbtr I'll be working on isolating our TF templates to build a minimal setup that reproduces the issue. This will take some time.
In the meanwhile I'll document here what we observe on the cluster the might be related to this issue.
Since setting up this cluster (the first one with pod subnet, we've always used mixed node+pod subnets without issues) we identified at least two additional networking components missbehaving.
azure-cns on windows nodes (mcr.microsoft.com/containernetworking/azure-cns:v1.6.13) will eventually loose it's authentication to the cluster's management API. Note that this is not happening to CNS on the Linux nodes.
│ W1201 06:13:15.922611    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1alpha.NodeNetworkConfig: Unauthorized                                        │
│ E1201 06:13:15.922611    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1alpha.NodeNetworkConfig: failed to list *v1alpha.NodeNetworkConfig: Unautho ││ W1201 06:13:43.201915    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1.Pod: Unauthorized                                                           │
│ E1201 06:13:43.201915    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1.Pod: failed to list *v1.Pod: Unauthorized                                  │
│ {"level":"info","ts":"2024-12-01T06:14:01.519Z","caller":"v2/monitor.go:124","msg":"calculated new request","component":"ipam-pool-monitor","demand":8,"batch":16,"max":50,"buffer":0.5,"target":16}          │
│ {"level":"info","ts":"2024-12-01T06:14:01.519Z","caller":"v2/monitor.go:127","msg":"NNC already at target IPs, no scaling required","component":"ipam-pool-monitor"}                                          │
│ W1201 06:14:04.724173    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1alpha.NodeNetworkConfig: Unauthorized                                        │
│ E1201 06:14:04.724173    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1alpha.NodeNetworkConfig: failed to list *v1alpha.NodeNetworkConfig: Unautho │
│ W1201 06:14:34.731016    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1.Pod: Unauthorized                                                           │
│ E1201 06:14:34.731016    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1.Pod: failed to list *v1.Pod: Unauthorized                                  │
│ W1201 06:14:35.139979    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1alpha.NodeNetworkConfig: Unauthorized                                        │
│ E1201 06:14:35.139979    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1alpha.NodeNetworkConfig: failed to list *v1alpha.NodeNetworkConfig: Unautho │
│ {"level":"info","ts":"2024-12-01T06:15:01.520Z","caller":"v2/monitor.go:124","msg":"calculated new request","component":"ipam-pool-monitor","demand":8,"batch":16,"max":50,"buffer":0.5,"target":16}          │
│ {"level":"info","ts":"2024-12-01T06:15:01.520Z","caller":"v2/monitor.go:127","msg":"NNC already at target IPs, no scaling required","component":"ipam-pool-monitor"}                                          │
│ W1201 06:15:09.553802    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1alpha.NodeNetworkConfig: Unauthorized                                        │
│ E1201 06:15:09.553802    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1alpha.NodeNetworkConfig: failed to list *v1alpha.NodeNetworkConfig: Unautho │
│ W1201 06:15:22.718539    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1.Pod: Unauthorized                                                           │
│ E1201 06:15:22.718539    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1.Pod: failed to list *v1.Pod: Unauthorized                                  │
│ W1201 06:15:55.630620    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1alpha.NodeNetworkConfig: Unauthorized                                        │
│ E1201 06:15:55.630620    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1alpha.NodeNetworkConfig: failed to list *v1alpha.NodeNetworkConfig: Unautho │
│ W1201 06:16:01.109326    6540 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: failed to list *v1.Pod: Unauthorized                                                           │
│ E1201 06:16:01.109326    6540 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.5/tools/cache/reflector.go:232: Failed to watch *v1.Pod: failed to list *v1.Pod: Unauthorized                                  │
│ {"level":"info","ts":"2024-12-01T06:16:01.520Z","caller":"v2/monitor.go:124","msg":"calculated new request","component":"ipam-pool-monitor","demand":8,"batch":16,"max":50,"buffer":0.5,"target":16}          │
│ {"level":"info","ts":"2024-12-01T06:16:01.520Z","caller":"v2/monitor.go:127","msg":"NNC already at target IPs, no scaling required","component":"ipam-pool-monitor"}

I've examined the historical logs for that pod and this starts happening out of nowhere. No specific error messages prior to the failure give any additional hint on what happened to authentication.
About the connectivity agent (mcr.microsoft.com/oss/kubernetes/apiserver-network-proxy/agent:v0.30.3-hotfix.20240819) something weird also happens, after working OK for some time, they start spamming messages such as:
I1201 06:22:08.160235       1 client.go:528] "remote connection EOF" connectionID=6981                                                                                │
│ I1201 06:22:25.587138       1 client.go:528] "remote connection EOF" connectionID=6982                                                                                │
│ I1201 06:22:28.154312       1 client.go:528] "remote connection EOF" connectionID=6983                                                                                │
│ I1201 06:22:34.797901       1 client.go:528] "remote connection EOF" connectionID=6886                                                                                │
│ I1201 06:22:45.592290       1 client.go:528] "remote connection EOF" connectionID=6887                                                                                │
│ I1201 06:22:48.198009       1 client.go:528] "remote connection EOF" connectionID=6984                                                                                │
│ I1201 06:22:54.892502       1 client.go:528] "remote connection EOF" connectionID=6985                                                                                │
│ I1201 06:23:11.087465       1 client.go:528] "remote connection EOF" connectionID=6889                                                                                │
│ I1201 06:23:14.787701       1 client.go:528] "remote connection EOF" connectionID=6890                                                                                │
│ I1201 06:23:25.578375       1 client.go:528] "remote connection EOF" connectionID=6892                                                                                │
│ I1201 06:23:28.184660       1 client.go:528] "remote connection EOF" connectionID=6893                                                                                │
│ I1201 06:23:34.801468       1 client.go:528] "remote connection EOF" connectionID=6986                                                                                │
│ I1201 06:23:48.151358       1 client.go:528] "remote connection EOF" connectionID=6987                                                                                │
│ I1201 06:23:54.211852       1 client.go:528] "remote connection EOF" connectionID=6895                                                                                │
│ I1201 06:24:11.084989       1 client.go:528] "remote connection EOF" connectionID=6989                                                                                │
│ I1201 06:24:45.577507       1 client.go:528] "remote connection EOF" connectionID=6990                                                                                │
│ I1201 06:24:48.151196       1 client.go:528] "remote connection EOF" connectionID=6991                                                                                │
│ I1201 06:24:51.096125       1 client.go:528] "remote connection EOF" connectionID=6896                                                                                │
│ I1201 06:24:54.802809       1 client.go:528] "remote connection EOF" connectionID=6992

We are investigating these internally and engaging with Azure support, I'll be posting here any progress made.

Both of the issues reported in my last comment seem to be unrelated to the original networking problem.

remote connection EOF spamming from connectivity agent

is expected as per
https://github.com/Azure/AKS/issues/4423

Failed to watch * in CNS pod in windows nodes

I am investigating separately, the kubelet is failing to renew tokens: https://github.com/Azure/AKS/issues/4679

@david-garcia-garcia I have identified the root cause of the Unauthorized errors with CNS - it's due to a change in token refresh with K8s 1.30 and the weird way CNS gets its Kubeconfig. I'm working with AKS on the fix. In the meantime, if you are able to disable OIDC on your cluster, it should resolve (the token refresh is a side effect of OIDC).


⚠ Bofrost.lu has degraded performance

In dc0da78, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1609 ms

Resolved: Bofrost.lu performance has improved in fa38594 after 9 minutes.


Add bbb_web_logouturl

Waiting for #128
Set adapted logoutURL
e.g. set logoutURL to ${bigbluebutton.web.serverURL}/logout.html

This pull request is mergeable too.


Help: Could you look into my cleaned data set

Check-list:
does it contain any null values?
Does it contain any value larger than normal values?
Does the naming convention is correct?

attendence_rate.csv


Add docs for releasing

Description

Creates a new file for releasing-specific docs in releasing.md, moving it out of the contributing.md. Releasing is only done by a small handful of total contributors so we can break it out into a separate file to cut down the clutter.
Adds "Common Problems" at the bottom and documents a recurring bug with changesets.
Other small tweaks.

Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@scottdixon I added a bit about the discord announcement, let me know if that makes sense in these docs.


Split Vocals & Pitch shift/song speed

What feature do you want to get added on the base engine?
I think it would be cool, if multiple vocals would be supported. But also for general FNF
Like, you can have either one for all, or use seperated (maybe via a toggle box in charting menu). That way it can also be that bf only can be silenced, and the opponent will be perfect to hear
Though that might be quite complicated to realize (regarding that there are at least two sides to sing)
But the seocnd thing would be, that you can play the song at different speeds and the pitch goes higher or lower with it
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Pitch shift: Sound useful, but it's unclear if they can make it.
Split Vocals: That an feature update for Week 8, but we can't added this yet hopefully. Otherwise...eventually, Tutorial, Monster, and Winter Horrorland do have spilt vocals which have not been used yet in the game, so I check on the FNF wiki...

Here the split vocals of Bopeebo which I made in FL Studio.
bopeebo.zip
For Tutorial, I have to use the music stem. Because it impossible to mute the vocals when miss.


Add Rumbleverse

Game Title
Rumbleverse
Game Website
https://www.rumbleverse.com
Anti-Cheat Software
Easy Anti-Cheat
Status of the Anti-Cheat
😥 Broken
Tinkering Steps
No response
Proof of Mention
none

It seems to work on Linux but i didn't find any statement that is supported on linux.
People playing it, but i also saw people saying that they got kicked out by eac.
https://www.reddit.com/r/SteamDeck/comments/vbhgqa/rumbleverse_beta_running_on_sd/https://www.reddit.com/r/SteamDeck/comments/vbhgqa/rumbleverse_beta_running_on_sd/
I checked the binary files and didn't find the eac linux binaries, like in FallGuys.


[core] Introduce projection fields to EqualiserCodeGenerator

Purpose

See #4126

Tests

API and Format

Documentation

LGTM +1


feat: update librime to 1.12.0+dfsg1

Rime Input Method Engine - utilities
Issue: https://github.com/deepin-community/sig-deepin-sysdev-team/issues/552
Log: update repo

需要回滚t64


parser: support the SELECT ... INTO OUTFILE syntax

What problem does this PR solve?
Fix #722.
Check List
Tests

Unit test

Thanks @kennytm , PTAL @winoros @XuHuaiyu .


Adding the FFmpegInteropX.FFmpegUWP NuGet package to UWP app,  cause release build failed

Step:

Add the FFmpegInteropX.FFmpegUWP NuGet package
Project - Publish- Create App Packages

Microsoft.NetNative.targets(809,5): error : Internal compiler error: MCG0023:UnresolvableAssemblyReference Unresolvable assembly reference 'Assembly(Name=Microsoft.Graphics.Canvas, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime)' found. Please check the references in your build system. A reference is either missing or an assembly is missing an expected type

Hi,
I tried and failed.
Can you provide a sample project?
Thanks.

Updating to latest preview version seems to fix the issue.

Thinking about this. We really do have a dependency on Win2d, because of the BasicVideoEffect. But it is not declared on the NuGet package. Even if the build succeeds with latest preview, at runtime it would sure fail, at least when using BasicVideoEffect. Not sure though why it builds with master branch releases, maybe there are some differences on how .NET Native handles C++/WinRT, compared to C++/CX.
I think most people use this lib with the project reference. But we need to make sure that NuGet works as well. And as long as we include BasicVideoEffect with the lib, we must declare it on the NuGet as well.

Closing this since it is fixed in latest prerelease packages.


Add ability to specify another repository

This pull request allows a repository input which will cause the release to be created in another repository.
We would like to use this to trigger matched releases across different tools using GitHub Actions.

It'd be great to get this merged, it's a super useful feature specially when you want to keep code private but releases public.

If i'm reading this correctly, is this a duplicate of #96? Looks like that PR has been merged


Raise IRQL to DISPATCH after test_helper is successfully initialized.

Description
Raise IRQL after test_helper initialization, so that its destructor is called at PASSIVE in we hit an error in test_helper::initialize().
(The test_helper::~test_helper() destructor calls ebpf_flush_epoch() that ends up blocking on a lock if called at DISPATCH.)
Testing
Do any existing tests cover this change? Are new tests needed?
Issued exposed by existing test.  No new test needed.
Fix Verification:
Successful local run of:
powershell.exe .\Test-FaultInjection.ps1 D:\wrk\ebpf-for-windows\x64\Debug 3600 .\unit_tests.exe 16
Documentation
Is there any documentation impact for this change?
No doc impact.
Installation
Is there any installer impact for this change?
No installer impact.
Fixes #2973

Since multiple failures can be placed under the same failing job while the issue is open, just making sure the PR addresses this specific callstack: https://github.com/microsoft/ebpf-for-windows/issues/2973#issuecomment-1759363487
If it's the same issue, could you quickly explain why this

(The test_helper::~test_helper() destructor calls ebpf_flush_epoch() that ends up blocking on a lock if called at DISPATCH.)

causes a crash with the stack from my comment? :)

Could you quickly explain why this

(The test_helper::~test_helper() destructor calls ebpf_flush_epoch() that ends up blocking on a lock if called at DISPATCH.)

causes a crash with this stack? #2973 (comment)
(I thought we'd see a driver verifier bugcheck detecting the IRQL deadlock, rather than an access violation exception code.)

I was puzzled by the stack dump in #2973 (comment) as well, as I did not see any other instances in the subsequent dumps.   Also, by the time I got to investigating this issue those artifacts had expired so couldn't investigate further.  All the more puzzling is the fact that this is a user mode test (we can't do fault injection in kernel mode, and driver verifier won't kick in either) so it's odd/interesting that it can trigger a kernel mode crash.
I have focused instead on the far more consistent 'hang' as seen all subsequent crash dump artifacts.   Nonetheless, I'm keeping an eye open for the originally reported crash and dig in if it does repro again.


After deploy fixes

some small urgent fixes that were discovered after deployment:

remove all disable functionalities from settings/spec
typo: exaple → example
erasing of solc version from additional files

=== BROKEN===
jobs that are in incomplete results status are being rendered together and it brake stuff!!! like when we want to create a new job list item

== DEPLOY ON SUNDAY ==

contact Oz when I merge


replace frob(6) by unitary_inverse in bls12 in r1cs-std

same as #231 but for r1cs-std crate

Hey @yelhousni, thanks for the PR!
We're transitioning the code in this repo over to https://github.com/arkworks-rs/curves/; could you make the PR there instead?

I believe this PR was merged in arkworks-rs/algebra, right?


Hangs when installing VS2017

C:\WINDOWS\system32>npm i -g --production --vs2017 install windows-build-tools

><EMAIL_ADDRESS>postinstall C:\Users\Jordan\scoop\persist\nodejs-lts\bin\node_modules\windows-build-tools
> node ./dist/index.js

Downloading vs_BuildTools.exe
Downloading python-2.7.14.amd64.msi
[============================================>] 100.0% of 20.17 MB (8.07 MB/s)
Downloaded python-2.7.14.amd64.msi. Saved to C:\Users\Jordan\.windows-build-tools\python-2.7.14.amd64.msi.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
2018-08-12T23:30:25 : Verbose : [SetupUpdaterImpl]: Rpc connection was closed.
2018-08-12T23:30:25 : Verbose : [SetupUpdaterImpl]: Stream was closed

------------------- Python --------------------
Successfully installed Python 2.7

The only info that gets output is:
2018-08-12T23:30:25 : Verbose : [SetupUpdaterImpl]: Rpc connection was closed.
2018-08-12T23:30:25 : Verbose : [SetupUpdaterImpl]: Stream was closed

No Build Tools components get installed, and it just hangs forever.

The RPC messages are red herrings. They're just left over messages from previous logs. If you delete the logs first, then it hangs with:
---------- Visual Studio Build Tools ----------
Still waiting for installer log file...

The actual failure is indicated in the dd_bootstrapper logs:
VisualStudio Bootstrapper:8/13/2018 2:37:30 AM: Starting vs setup process 'vs_installer.exe' with arguments '/finalizeInstall install --in "C:\ProgramData\Microsoft\VisualStudio\Packages\_bootstrapper\vs_setup_bootstrapper_201808130237109785.json" --norestart --quiet --add Microsoft.VisualStudio.Workload.VCTools --locale en-US --activityId "b3bbd12d-ae53-4412-b7f9-0a65e02a9ead"'.
VisualStudio Bootstrapper:8/13/2018 2:37:30 AM: Caught Exception: Type = ArgumentException, Message = Item has already been added. Key in dictionary: 'path'  Key being added: 'Path', StackTrace =    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
   at System.Diagnostics.ProcessStartInfo.get_EnvironmentVariables()
   at Microsoft.VisualStudio.Setup.Bootstrapper.Bootstrapper.StartProcess(String exeDir, String exeName, String args)
VisualStudio Bootstrapper:8/13/2018 2:37:30 AM: Couldn't launch setup process. Error: Item has already been added. Key in dictionary: 'path'  Key being added: 'Path'
VisualStudio Bootstrapper:8/13/2018 2:37:30 AM: Caught Exception: Type = BootstrapperException, Message = Unable to launch the installer. Error: Item has already been added. Key in dictionary: 'path'  Key being added: 'Path', StackTrace =    at Microsoft.VisualStudio.Setup.Bootstrapper.Bootstrapper.StartProcess(String exeDir, String exeName, String args)
   at Microsoft.VisualStudio.Setup.Bootstrapper.Bootstrapper.ExecuteCore()
   at Microsoft.VisualStudio.Setup.Bootstrapper.Bootstrapper.<>c__DisplayClass20_0.<Execute>b__0(Object s)
InnerException:Type = ArgumentException, Message = Item has already been added. Key in dictionary: 'path'  Key being added: 'Path', StackTrace =    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
   at System.Diagnostics.ProcessStartInfo.get_EnvironmentVariables()
   at Microsoft.VisualStudio.Setup.Bootstrapper.Bootstrapper.StartProcess(String exeDir, String exeName, String args)
VisualStudio Bootstrapper:8/13/2018 2:37:30 AM: Boostrapper failed. Exception: Unable to launch the installer. Error: Item has already been added. Key in dictionary: 'path'  Key being added: 'Path'

Apparently it doesn't like the fact that npm adds PATH and path aliases to the existing Path env var.
Patching launch.ts with:
delete process.env.PATH;
delete process.env.path;

right before it spawns powershell.exe seems to do the trick.

A fix has been merged into npm-lifecycle, so it should be fixed in the next version of npm. Until then, it may be good to patch this for npm >=6.1.0 and <6.4.0.

@jordanbtucker Thank you so much for your excellent research! I've fixed this in<PHONE_NUMBER>93ea7adec98241ec778b95e487a85c.


[suggestion] add support for Carpeted Quark Trapdoors

I have no plans to add this feature in the near future. Carpeted trapdoors already take up 16 block IDs for each variant, adding support for the Quark trapdoors is another 80 blocks that need to be registered (which would be an absolute pain). In the future I may change the texture of the base trapdoor to be more generic across the wood types instead.


Buttons should generate silent mentions for deactivated users

User profile cards have buttons for inserting/generating user mentions. For deactivated users, these buttons should insert/generate silent mentions, rather than regular mentions. This will hint that deactivated users cannot receive notifications.

Related issues:

#26857

CZO thread

@zulipbot claim

hi, @M2gue1  are you still working on this? or can i pick it up?

Hi! I am working!

okay. Thank you
On Thu, Oct 5, 2023 at 1:01 PM M1gue11 @.***> wrote:

Hi! I am working!
—
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/26858#issuecomment-1748745238, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATR5T4NHUKDIUJA6PCM7V2LX52OSTAVCNFSM6AAAAAA5GW4JVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYG42DKMRTHA
.
You are receiving this because you commented.Message ID:
@.***>

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim


Add configuration option for filename used by buildTar goal of maven plugin

The current (as of 1.0.2) maven plugin has the very useful goal of buildTar which creates a docker tar image named "jib-maven.tar".  It would be very convenient for their to be a configuration option to control the filename for situations when the version or other data needs to be placed into the filename.
Issue #1282 suggests using a separate plugin to accomplish this, but this is awkward at best.  So in this issue I'm requesting specifically that an option be added to allow setting the filename directly by the jib-maven-plugin.

I would like the same feature for the Gradle plugin!

@hoppermann @codeseedr FYI, we are actively working on this based on #2024.

@jrivard @tishun @oers @codeseedr @blagerweij We've released 1.7.0, which adds a jib.outputPaths (gradle) / <outputPaths> (maven) configuration block, which lets you specify the tar, digest, and imageId file paths.


Set up development environment using Visual Code Studio Remote Containers extension

As a developer
I need a development environment
So that everyone in the team has the same environment
Details and Assumptions

We are using Visual Code Studio Remote Containers extension

Acceptance Criteria
Given a provided git repo
When type code . in the folder terminal
Then the VScode will launch the Docker container and we can write code

Hey team! Please add your planning poker estimate with Zenhub @kovidiament @omb244 @SamSloboda

According to the professor, he has set up the environment for us. So this issue is not needed.


style: remove border from right tabbar button

Types

[x] 💄 Style Changes

Background or solution
fixed #358
Changelog
remove border from right tabbar button

Codecov Report

Merging #366 (9074485) into main (5b366e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   59.33%   59.32%   -0.01%
==========================================
  Files        1189     1189
  Lines       72850    72850
  Branches    15084    15084
==========================================
- Hits        43222    43219       -3
- Misses      27001    27003       +2
- Partials     2627     2628       +1

Impacted Files
Coverage Δ

packages/monaco/src/browser/schema-registry.ts
68.88% <0.00%> (-2.23%)
:arrow_down:

...kages/theme/src/browser/workbench.theme.service.ts
70.32% <0.00%> (-0.90%)
:arrow_down:

...erences/src/browser/preference-settings.service.ts
79.16% <0.00%> (-0.70%)
:arrow_down:

packages/core-common/src/node/port.ts
46.96% <0.00%> (+3.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b366e6...9074485. Read the comment docs.

LGTM


Address remaining clippy lints for services.

Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
Address clippy lint in Route53 helper.
This is the last part of https://github.com/rusoto/rusoto/issues/1402 . 🎉 Thanks to @sepiropht for the great work he's done for that issue. 👍
I think this can wait until after the 0.42.0 release tomorrow. 😄

I think this is ready for review 😄


Default Timeout is Surprising

Not sure if this is a bug, but rather it's an opinion.  The default response timeout for Aws::Client::ClientConfiguration took me by surprise.  It took me approximately 20 minutes to identify why all of my S3 downloads were failing.
It would be my expectation that the default timeout should be 0 (ie: No response timeout).  Certainly the value of 3000 ms seems arbitrary.
This error message did help when I looked up libcurl errors (http://curl.haxx.se/libcurl/c/libcurl-errors.html)
[TRACE] 2015-12-08 01:31:05 CurlHttpClient [139876696389568] 16384 bytes written to response.
[ERROR] 2015-12-08 01:31:05 CurlHttpClient [139876696389568] Curl returned error code 28.
[DEBUG] 2015-12-08 01:31:05 CurlHandleContainer [139876696389568] Releasing curl handle 0x24cee90.
[DEBUG] 2015-12-08 01:31:05 CurlHandleContainer [139876696389568] Notifying waiting threads.

One of the most common and frustrating networking bugs is people NOT setting timeouts on their IO. 3 seconds is fairly standard (especially when hitting tier one services). However, for S3, you may want to increase this limit.


E2E tests startup is flaky

During e2e tests webhooks are not ready which results in failing e2e tests
What happened:
E2E test failed on testing kueue readiness
What you expected to happen:
E2E test to succeed
How to reproduce it (as minimally and precisely as possible):
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1365/pull-kueue-test-e2e-main-1-28/1729486888244350976
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/kind flake

Looks like flaked again: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1378/pull-kueue-test-e2e-main-1-26/1730154566130864128
[BeforeSuite]
/home/prow/go/src/sigs.k8s.io/kueue/test/e2e/suite_test.go:94
  [FAILED] in [BeforeSuite] - /home/prow/go/src/sigs.k8s.io/kueue/test/e2e/suite_test.go:90 @ 11/28/23 13:12:39.891
[BeforeSuite] [FAILED] [60.003 seconds]
[BeforeSuite]
/home/prow/go/src/sigs.k8s.io/kueue/test/e2e/suite_test.go:94

  [FAILED] Timed out after 60.000s.
  Expected success, but got an error:
      <*errors.StatusError | 0xc00022e0a0>:
      Internal error occurred: failed calling webhook "mresourceflavor.kb.io": failed to call webhook: Post "https://kueue-webhook-service.kueue-system.svc:443/mutate-kueue-x-k8s-io-v1beta1-resourceflavor?timeout=10s": dial tcp <IP_ADDRESS>:9443: connect: connection refused
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Internal error occurred: failed calling webhook \"mresourceflavor.kb.io\": failed to call webhook: Post \"https://kueue-webhook-service.kueue-system.svc:443/mutate-kueue-x-k8s-io-v1beta1-resourceflavor?timeout=10s\": dial tcp <IP_ADDRESS>:9443: connect: connection refused",
              Reason: "InternalError",
              Details: {
                  Name: "",
                  Group: "",
                  Kind: "",
                  UID: "",
                  Causes: [
                      {
                          Type: "",
                          Message: "failed calling webhook \"mresourceflavor.kb.io\": failed to call webhook: Post \"https://kueue-webhook-service.kueue-system.svc:443/mutate-kueue-x-k8s-io-v1beta1-resourceflavor?timeout=10s\": dial tcp <IP_ADDRESS>:9443: connect: connection refused",
                          Field: "",
                      },
                  ],
                  RetryAfterSeconds: 0,
              },
              Code: 500,
          },
      }

Another recent occurrence: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1378/pull-kueue-test-e2e-main-1-28/1730521196279107584

Uhm.... I wonder if we need to increase the timeout or cpu/memory of the job.

According to the Grafana dashboard, resource requests seem to be sufficient. The max usage for CPU is 8.27 Core, and memory is 1.69 GiB.
https://monitoring-eks.prow.k8s.io/d/96Q8oOOZk/builds?orgId=1&from=now-7d&to=now&var-org=kubernetes-sigs&var-repo=kueue&var-job=pull-kueue-test-e2e-main-1-26&refresh=30s&var-build=All

I'm wondering if there are noisy navors 🤔

Another happening: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1412/pull-kueue-test-e2e-main-1-27/1732350401358860288

Should we just increase the timeout for waiting for the webhook?

Should we just increase the timeout for waiting for the webhook?

I think so since it seems that jobs have enough resource requests.

It looks like jobset is still having issues.
We should start by increasing the visibility into what is pending. Perhaps obtaining the status of the kueue-controller Pod is enough.

I'll take this for now
/assign

Comparing the kueue logs from a successful run with an unsuccessful run, something that catches my eye is the absence of the line CA certs are injected to webhooks in the failing one.

The first relevant log line to be absent is
https://github.com/open-policy-agent/cert-controller/blob/01a9f146b6f1c2f5ed6d496c4ca78a84bde4325b/pkg/rotator/rotator.go#L857C32-L857C32
@astefanutti does this give any clues? What should be generating this file? What does it depend on?

When the certs become ready, it doesn't take more than 5 seconds since the first kueue log line. So a greater timeout is unlikely to fix the issue.
I'm currently testing cert-controller 0.9 in an attempt to narrow down a culprit https://github.com/kubernetes-sigs/kueue/pull/1489

The E2E test is also failing with 0.9. I wanted to try 0.7, but there are some dependency issues that prevented me from trying.
I'm curious about whether the issue is related to https://github.com/open-policy-agent/cert-controller/pull/81

Uhm... I don't think so. I do see the message:
server certs refreshed

Meaning that an initial write was sent to the apiserver. It looks like what should happen next is that the kubelet watches the update of the Secret and updates the file.

The first relevant log line to be absent is https://github.com/open-policy-agent/cert-controller/blob/01a9f146b6f1c2f5ed6d496c4ca78a84bde4325b/pkg/rotator/rotator.go#L857C32-L857C32
@astefanutti does this give any clues? What should be generating this file? What does it depend on?

@alculquicondor That file has the following lifecycle (simplified with the relevant bits):

The webhook-server-cert Secret is mounted into the Kueue Deployment at tmp/k8s-webhook-server/serving-certs)
Concurrently:

cert-controller generates the certificates and updates the webhook-server-cert Secret

the kubelet propagates the update into the Secret volume mount from 1.
cert-controller checks the server certificate is mounted and closes the certsMounted channel

cert-controller injects the CA certificate into the admission webhooks and closes the IsReady channel (if certsMounted is also closes)

The Kueue webhooks are started along with the other controllers (gated by the IsReady channel)

In the failing runs, it's step 2.i.b. that fails to proceed. I initially though it could be the kubelet that takes to much time to propagate the Secret update to the volume mount (depending on the configMapAndSecretChangeDetectionStrategy kubelet configuration), but then the ensureCertsMounted method should print max retries for checking certs existence.
I still fail to understand what could cause to break what seems to be the ensureCertsMounted method two invariants, that are either log:

certs are ready in /tmp/k8s-webhook-server/serving-certs
Or max retries for checking certs existence

I'll keep digging, but it may be more productive to create a "DO NOT MERGE" PR with some added data points that could help nailing down why that ensureCertsMounted invariants are broken. How does that sound to you?

I realise with the exponential backoff configuration that's used in the ensureCertsMounted method:
wait.Backoff{ Duration: 1 * time.Second, Factor: 2, Jitter: 1, Steps: 10}

The tests time out before the backoff in the ensureCertsMounted method does.
So it's still a possibility the update made to the Secret by cert-controller isn't propagated as expected into the volume mount by the kubelet.

I've just found https://ahmet.im/blog/kubernetes-secret-volumes-delay/ that seems to corroborate the long Secret volume mount update propagation hypothesis.
@alculquicondor Based on that article, to validate the test timeout increase approach as in #1491, a value as long as two minutes might be needed.

That article is very useful, thanks!
Yes, it sounds like 2 minutes should be the target (how annoying).
Otherwise, I wonder if I can cause a Pod status update (to trigger kubelet sync) using the readiness probes more smartly. But I'll leave that as a follow up. It sounds like something like this might be happening most of the time, as we get the secrets updated within 5s when the test passes.


Build libredirect for x86_64, arm64, arm64e on darwin

libredirect currently fails to build on macOS machines. I've tried various combinations of BigSur and Monotery, it fails everywhere.
Our llvmPackages_13.clang doesn't seem to like being forced to create tiple arch files. So we'll resort to the system clang on darwin for now. This item is so fundamentally intwined with the impure state of the host system (dyld) over which we have no control, that I find this "hack" to be acceptable, while ugly.
/cc @thefloweringash @Ericson2314

libredirect currently fails to build on macOS machines

What do you mean by that? It builds on Hydra:
https://hydra.nixos.org/job/nixpkgs/staging-next/libredirect.x86_64-darwin

libredirect currently fails to build on macOS machines

What do you mean by that? It builds on Hydra: https://hydra.nixos.org/job/nixpkgs/staging-next/libredirect.x86_64-darwin

that is x86_64-darwin. And the aarch64-darwin probably just builds by coincidence that the hydra builder use rather old BigSur versions? It appears somewhere during the BigSur updates a new dyld was introduced that didn't like the aarch64 (arm64 in apple speak), anymore and as such libredirect started failing to build on those machines.

$ nix-shell -p neofetch --run neofetch --argstr system aarch64-darwin
                    'c.          angerman@aarch64-darwin-1
                 ,xNMM.          -------------------------
               .OMMMMo           OS: macOS 12.1 21C52 arm64
               OMMM0,            Host: Macmini9,1
     .;loddo:' loolloddol;.      Kernel: 21.2.0
   cKMMMMMMMMMMNWMMMMMMMMMM0:    Uptime: 16 hours, 19 mins
 .KMMMMMMMMMMMMMMMMMMMMMMMWd.    Packages: 176 (nix-system)
 XMMMMMMMMMMMMMMMMMMMMMMMX.      Shell: bash 5.1.8
;MMMMMMMMMMMMMMMMMMMMMMMM:       DE: Aqua
:MMMMMMMMMMMMMMMMMMMMMMMM:       WM: Quartz Compositor
.MMMMMMMMMMMMMMMMMMMMMMMMX.      WM Theme: Blue (Light)
 kMMMMMMMMMMMMMMMMMMMMMMMMWd.    Terminal: /dev/ttys001
 .XMMMMMMMMMMMMMMMMMMMMMMMMMMk   CPU: Apple M1
  .XMMMMMMMMMMMMMMMMMMMMMMMMK.   GPU: Apple G13G
    kMMMMMMMMMMMMMMMMMMMMMMd     Memory: 1434MiB / 16384MiB
     ;KMMMMMMMWXXWMMMMMMMk.
       .cooc,.    .,coo:.

Getting a cached build from hydra works (well, "works", it pulls the binary from cache...)
$ nix-build "<nixpkgs>" -A libredirect -I nixpkgs=https://github.com/nixos/nixpkgs/archive/nixpkgs-21.11-darwin.tar.gz
/nix/store/19j8my6waz6agi4247jx3q23lx3wqx69-libredirect-0

trying to force a build on the above machine:
$ nix-build "<nixpkgs>" -A libredirect -I nixpkgs=https://github.com/nixos/nixpkgs/archive/nixpkgs-21.11-darwin.tar.gz --check
checking outputs of '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv'...
unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
libredirect.c:102:11: warning: incompatible function pointer types initializing 'int (*)(const char *, int, mode_t)' (aka 'int (*)(const char *, int, unsigned short)') with an expression of type 'int (*)(const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*open_real) (const char *, int, mode_t) = LOOKUP_REAL(open);
          ^                                        ~~~~~~~~~~~~~~~~~
libredirect.c:107:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
libredirect.c:134:11: warning: incompatible function pointer types initializing 'int (*)(int, const char *, int, mode_t)' (aka 'int (*)(int, const char *, int, unsigned short)') with an expression of type 'int (*)(int, const char *, int, ...)' [-Wincompatible-function-pointer-types]
    int (*openat_real) (int, const char *, int, mode_t) = LOOKUP_REAL(openat);
          ^                                               ~~~~~~~~~~~~~~~~~~~
libredirect.c:139:27: warning: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' [-Wvarargs]
        mode = va_arg(ap, mode_t);
                          ^~~~~~
/nix/store/7sfdssd4p5c6gh5dr2j1fy06fxky195q-clang-wrapper-11.1.0/resource-root/include/stdarg.h:19:50: note: expanded from macro 'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^~~~
4 warnings generated.
installing
install: creating directory '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0'
install: creating directory '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib'
'libredirect.dylib' -> '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib'
post-installation fixup
patching script interpreter paths in /nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0
patching script interpreter paths in /nix/store/cbzgblyik90wag4arznwrw5sx62xfqsa-libredirect-0-hook
running install tests
dyld[53552]: terminating because inserted dylib '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' could not be loaded: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)
dyld[53552]: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)
Assertion failed: (system(TESTPATH) == 0), function test_system, file test.c, line 37.
/nix/store/i97a6fwzdp2n2mb9crzhnvdb7r15arqi-stdenv-darwin/setup: line 1355: 53550 Abort trap: 6           NIX_REDIRECTS="/foo/bar/test=/nix/store/dwhdayp98xmpp9vzzb1qp4va1pjy65gz-coreutils-9.0/bin/true" ./test
error: builder for '/nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv' failed with exit code 134;
       last 10 log lines:
       > install: creating directory '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib'
       > 'libredirect.dylib' -> '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib'
       > post-installation fixup
       > patching script interpreter paths in /nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0
       > patching script interpreter paths in /nix/store/cbzgblyik90wag4arznwrw5sx62xfqsa-libredirect-0-hook
       > running install tests
       > dyld[53552]: terminating because inserted dylib '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' could not be loaded: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)
       > dyld[53552]: tried: '/nix/store/27qmzv86dlmr9pibvmc6mb28n1f987qy-libredirect-0/lib/libredirect.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'arm64e')), '/usr/local/lib/libredirect.dylib' (no such file), '/usr/lib/libredirect.dylib' (no such file)
       > Assertion failed: (system(TESTPATH) == 0), function test_system, file test.c, line 37.
       > /nix/store/i97a6fwzdp2n2mb9crzhnvdb7r15arqi-stdenv-darwin/setup: line 1355: 53550 Abort trap: 6           NIX_REDIRECTS="/foo/bar/test=/nix/store/dwhdayp98xmpp9vzzb1qp4va1pjy65gz-coreutils-9.0/bin/true" ./test
       For full logs, run 'nix log /nix/store/n2jajggzh9rm02dkxdh2s65x5xsdycgn-libredirect-0.drv'.

# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target arm64e-apple-darwin test.c -c -o test_arm64e.o
# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target arm64-apple-darwin test.c -c -o test_arm64.o
# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target x86_64-apple-darwin test.c -c -o test_x86_64.o
# lipo -create test_arm64.o test_arm64e.o test_x86_64.o -output test.a
# file test.a
test.a: Mach-O universal binary with 3 architectures: [x86_64:\012- Mach-O 64-bit x86_64 object, flags:<|SUBSECTIONS_VIA_SYMBOLS>] [arm64:\012- Mach-O 64-bit arm64 object, flags:<|SUBSECTIONS_VIA_SYMBOLS>] [arm64e (caps: 0x2):\012- Mach-O 64-bit arm64e 00) object, flags:<|SUBSECTIONS_VIA_SYMBOLS>]

# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target arm64e-apple-darwin test.c -c -o test_arm64e.o
# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target arm64-apple-darwin test.c -c -o test_arm64.o
# $(nix-build . -A llvmPackages_13.clang.cc --no-out-link)/bin/clang -target x86_64-apple-darwin test.c -c -o test_x86_64.o
# lipo -create test_arm64.o test_arm64e.o test_x86_64.o -output test.a
# file test.a
test.a: Mach-O universal binary with 3 architectures: [x86_64:\012- Mach-O 64-bit x86_64 object, flags:<|SUBSECTIONS_VIA_SYMBOLS>] [arm64:\012- Mach-O 64-bit arm64 object, flags:<|SUBSECTIONS_VIA_SYMBOLS>] [arm64e (caps: 0x2):\012- Mach-O 64-bit arm64e 00) object, flags:<|SUBSECTIONS_VIA_SYMBOLS>]

That's much better! I got confused why it didn't like my -arch logic.

@veprbl thanks! I'll run some validation on a few aarch64-darwin machines.

@veprbl alright, I've finally managed to find the incantation to make this build with the nixpkgs provided tools. And I've also learned that we can use -arch with the llvmPackages clang.

@veprbl hope this is good to go now. I did rebase onto staging, and now it appears I have to rebuild the world again. Sigh.

This will need a backport to 21.11

@veprbl ping

@veprbl who can merge this? I don't seem to be able to.

@veprbl who can merge this? I don't seem to be able to.

Currently only members of the "Nixpkgs committers" group can merge PRs. I wanted to leave this open for a day to see if there will be any additional comments. Note that this will have to go through the staging process before it lands on master, which may take another 3 to 4 weeks.

Yes. I'm aware that this will take quite some time. I just don't want to have to maintain my custom nixpkgs-21.11-darwin branch any longer than absolutely necessary.

Out of curiousity, why does this library need to be fat?

@Ericson2314 so depending on the macOS version you end up on, and we don't really have control over the macOS version the end user ends up using, dyld will expect arm64, arm64e or x86_64 (though we could argue for x86_64, that this is unlikely with the guard; however better safe than sorry).
So we'd better build a fat library with all slices, to insulate us from the underlying system changing requirements in dyld.
This did build flawlessly on an old BigSur revision, that nixOS builders run. It failed on more recent BigSur builder and Monterey builders that my hydra runs, as they expect different architectures (most likely arm64e; however I also believe that BigSurs dyld has a bug in which non-far dylibs are erroneously rejected).

@angerman is that true for any library, or is this library somehow special?

@Ericson2314 so I haven't played much with libredirect and only ran into this as ti was a dependency. Again something just incidental to what I'm doing. I hope this is only with this one and due to the prelaod/insertion logic for dyld. The faketime package has similar issues, and it's the only other reference I could find online. (Though they didn't figure out how to solve it 🙄)

Oh I see, the issue is that is messing with dyld itself with how it works? and due to Rosetta and other things need to cope with dyld being different arches?

@Ericson2314 it's more like the dyld is dependent on the operating system. And an update to it can introduce slight changes to dyld, as in wanting arm64e isntead of arm64 now.
It appears as:

early versions of BigSur were ok with arm64 only
early version of Monterey were ok with arm64e only
late versions of BigSur, didn't like arm64 only anymore, but didn't like arm64e only either, they seem to be ok with a fat library containing arm64 and arm64e though (the codepaths for fat and non-fat libraries in dyld are different).

So I've opted to just go for all possible architectures to cover all our bases here.

OK. So perhaps x86_64 doesn't matter as rosetta stuff doesn't come into play but whatever, once were are doing fat-binary stuff might as well go all in. OK.


getProducts() Returns Incomplete List of Currency Pairs

At this time, https://api.pro.coinbase.com/products returns 58 currency pairs.  However, the following only returns 6:
const {CoinbasePro} = require('coinbase-pro-node');
const auth = {
    apiKey: '',
    apiSecret: '',
    passphrase: '',
    useSandbox: true,
};
const client = new CoinbasePro(auth);
const response = await client.rest.product.getProducts();

Is there a way to make it return all currency pairs?

It was because useSandbox was set to true instead of false.  It may be helpful to others to update your documentation to set the default value to false and/or indicate that setting it to true returns a subset of the products as indicated in the "Sandbox" section of the Coinbase Pro API Reference.

This is a good tip! I followed your advice and expanded the documentation: https://github.com/bennyn/coinbase-pro-node/commit/71d4bf9daf9aa361bf202a1e139060c5169a80b3


Fuzzy search for themes/shows

The current endpoints require the exact alias or theme ID to work which is good for retrieving data for a specific show/theme but not for searching purposes. Some POST end-points that take a search variable and perform fuzzy search on the database to return an array of matches would be nice.
A good Fuzzy Search solution I use in JavaScript is Fuse.js. It has a PHP equivalent here.

Housekeeping: As of now this is implemented on the release branch.
/api/search?q=XXXX...


was customActionHandler action changed?

We have 1.1.3 package installed.
It worked great until you changed push template form design.
We use custom Action. and if we type something in the field, for example myCustomAction
then we checked in the app as action.type === 'myCustomAction'.
It worked so for ages, but now we will have to check action.data === 'myCustomAction'
because type now is 'customAction'.
Is it an issue or was done intentionally? We can fix it easily but it excludes any backwards compatibility for our app.
Also it's related only to new onetime push campaigns. Our triggered campaigns continue working well with custom action, but i'm afraid of re-saving them. It could mean that the issue in the new template form.
For now, solution [action.type, action.data].includes('myCustomAction') looks better than others in case you fix the form and to support our triggered campaigns w/o re-saving them.
Could you please take a look at your new form?
Thanks!

Thanks for sharing this @nymphetamineinside. I'll have it looked by appropriate team.

Hi @nymphetamineinside, this should be resolved. Could you check if everything looks good from your end?

a

Hi @nymphetamineinside, this should be resolved. Could you check if everything looks good from your end?

Thanks a lot! Checking now

@ahendricks
Custom action works as expected now.
Thanks!


Don't merge! Regression pull request perf test for no metavalidation

Docs Build status updates of commit 992003f:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 992003f:
:warning: Validation status: warnings

File
Status
Preview URL
Details
Dependent Files

api/overview/azure/TestingPullRequest.md
:warning:Warning
View
Details

api/overview/azure/TestingPullRequest.md

[Warning] Metadata with following name(s) are not allowed to be set in Yaml header, or as file level metadata in docfx.json, or as global metadata in docfx.json: content_type. They are generated by Docs platform, so the values set in these 3 places will be ignored. Please remove them from all 3 places to resolve the warning.
[Warning] the value invalid_type is undefined for metadata content_type
Line 7: [Warning] Invalid file link:(~/api/overview/nonexisted1.md).
Line 8: [Warning] Invalid file link:(~/api/overview/nonexisted2.md).
Line 9: [Warning] Invalid file link:(~/api/overview/nonexisted3.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 992003f:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 992003f:
:warning: Validation status: warnings

File
Status
Preview URL
Details
Dependent Files

api/overview/azure/TestingPullRequest.md
:warning:Warning
View
Details

api/overview/azure/TestingPullRequest.md

[Warning] Metadata with following name(s) are not allowed to be set in Yaml header, or as file level metadata in docfx.json, or as global metadata in docfx.json: content_type. They are generated by Docs platform, so the values set in these 3 places will be ignored. Please remove them from all 3 places to resolve the warning.
[Warning] the value invalid_type is undefined for metadata content_type
Line 7: [Warning] Invalid file link:(~/api/overview/nonexisted1.md).
Line 8: [Warning] Invalid file link:(~/api/overview/nonexisted2.md).
Line 9: [Warning] Invalid file link:(~/api/overview/nonexisted3.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Still active?

Could you confirm if the repo is still active and needed? To do so, just close this issue by end of Feb 2024. If not, we'll archive the repo. The repo can still be unarchived, so it's not a destructive action.

Not active. Safe to archive, Paul 👍


Passing the first round when no one has scored causes the app to crash

This is an issue that I have noticed when no one score in round 1A. The app crashes because it attempts to make player_stats  as a roll-up of a non-existent scores table. I fixed this in the current master file (see commit d2db469) but could probably be done in a more elegant fashion than just passing invisible()

I believe this is fixed somewhere? @mdewey131

Oh yes, this is fixed actually


Manifest change required for android 11 support

I think this needs to be added your projects manifest to support android 11, might be worth adding to the readme
<queries>
    <package android:name="com.google.android.apps.fitness" />
</queries>

I think this needs to be added your projects manifest to support android 11, might be worth adding to the readme
<queries>
    <package android:name="com.google.android.apps.fitness" />
</queries>

Thanks for the info, May you share what happen if you don't include the tag?
Will it prevent you from open google fit, or completely block all google fit services.

I think this needs to be added your projects manifest to support android 11, might be worth adding to the readme
<queries>
    <package android:name="com.google.android.apps.fitness" />
</queries>

Thanks for the info, May you share what happen if you don't include the tag? Will it prevent you from open google fit, or completely block all google fit services.

It will prevent you from opening Google fit and the isAvailable will also not work

@moulie415 Thx! It's added into Doc!


issue with ax.fill in geographic plots

Description
ax.fill in geographic plots seem to have some issues.
Steps to reproduce
import proplot as plot

fig, ax = plot.subplots(proj='cyl', proj_kw={'lon_0': 180})
ax.format(coast=True, labels=True)
ax.fill([0, 100, 100, 0], [0, 0, 50, 50], fill=False)

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

It works fine when combined with cartopy
import cartopy.crs as ccrs
fig, ax = plot.subplots(proj='cyl', proj_kw={'lon_0': 180})
ax.format(coast=True, labels=True)
ax.fill([0, 100, 100, 0], [0, 0, 50, 50], fill=False, transform=ccrs.PlateCarree())

Proplot version
0.6.4

This is because GeoAxes.fill was not wrapped by proplot, so it required transform=ccrs.PlateCarree().   010773c makes transform=ccrs.PlateCarree() the default like in other proplot contexts.


Country flag images missing

Describe the bug
Country flag images are currently missing as the third-party webserver is currently down. Perhaps they could be hosted locally?
To Reproduce

Go to home page

Expected behavior
Flags should always show
Screenshots

Thanks. I'll try to find some new ones, or probably make my own.

It seems the host was just temporairily down, as it's working again.


Model-centric websockets to support concurrent requests

What?
Ensure that model-centric websockets API is capable to support multiple concurrent requests using a single connection so that the client can distinguish which response is related to which request.
How long?
Ideally we have unit test that checks that.
Is your research related to a problem?
See
https://github.com/OpenMined/KotlinSyft/issues/235
https://github.com/OpenMined/SwiftSyft/issues/170
Additional Context

So all we need to do is add the response handlers like job name and version whenever needed. I will update the responses here for evaluation

Upd: As discussed, we can add id or req_id (or similar param in every request) and copy its convents back into corresponding response . This will allow worker to correspond every res to req via this id.


Add a few new phrases

The quotes have been mostly taken from HAL 9000, there is one from "I,
Robot" as well.
In response to https://github.com/thomas-lebeau/zut/issues/1

:+1: Thank you!


fix: IE compatibility (#9)

This should resolve the overlapping ToC, but to make it work on all browsers I think we should better generate the ToC at build stage.

#9

Looks like CSS rules have problem with tests?

@ronaldtse thank you, I’ve no idea how I ended up with HTML-style comments in there

Thanks @strogonoff !


Not Found Error Is Back..

Hi there, I am using tensorflow 1.6 as 1.4 was not working so I just upgraded it.
Running demo gives me this following error... Appreciate for your help!
(ds3.6) ~/D/u/8/crf-rnn ❯❯❯ python run_demo.py                                 master ◼
/Users/lucius/miniconda3/envs/ds3.6/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Using TensorFlow backend.
Traceback (most recent call last):
  File "run_demo.py", line 27, in <module>
    from crfrnn_model import get_crfrnn_model_def
  File "./src/crfrnn_model.py", line 28, in <module>
    from crfrnn_layer import CrfRnnLayer
  File "./src/crfrnn_layer.py", line 28, in <module>
    import high_dim_filter_loader
  File "./src/high_dim_filter_loader.py", line 28, in <module>
    custom_module = tf.load_op_library(os.path.join(os.path.dirname(__file__), 'cpp', 'high_dim_filter.so'))
  File "/Users/lucius/miniconda3/envs/ds3.6/lib/python3.6/site-packages/tensorflow/python/framework/load_library.py", line 58, in load_op_library
    lib_handle = py_tf.TF_LoadLibrary(library_filename, status)
  File "/Users/lucius/miniconda3/envs/ds3.6/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 516, in __exit__
    c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: dlopen(./src/cpp/high_dim_filter.so, 6): Symbol not found: __ZN10tensorflow15OpKernelContext21CtxFailureWithWarningENS_6StatusE
  Referenced from: ./src/cpp/high_dim_filter.so
  Expected in: /Users/lucius/miniconda3/envs/ds3.6/lib/python3.6/site-packages/tensorflow/python/../libtensorflow_framework.so
 in ./src/cpp/high_dim_filter.so

I encountered similar problems when upgrading tensorflow. For me deleting and rebuilding high_dim_filter.so did the trick

Thanks @Toz3wm !


docs: sketch of post for metric styling

This PR contains a sketch of a possible blog post riffing on Emily Riederer's work on Column Names as Contracts (blog post, coalesce talk).
It is very rough, but I love the combo of column names, analytics engineering, and beautiful table displays, so wanted to put the idea out there!

Closing for now, but may reach back for some of this!


Subscribing to Frames in C++

I would like to subscribe to frames in an Electron app and send them through this particular API implemented in C++ (PDF warning). My original idea was to implement a native Node addon and have a C++ function handle the frame data. I got something working where a C++ function is called for every frame but it crashes when I iterate through the buffer data (see below).
So while it would be nice to get that working (see code below), I was thinking about my use-case and I was wondering if I could avoid the use of node buffers altogether since I don't have to use the data at all from JavaScript land. I was looking at the implementations of WebContents::BeginFrameSubscription and FrameSubscriber::OnFrameDelivered and had a few questions:

Let's say I pass a JavaScript instance of WebContents in to a native C++ function. How do I go about calling GetRenderWidgetHostView() so I can then call BeginFrameSubscription()?
Is there documentation anywhere on how to implement a FrameSubscriber in C++? Yes, I can read the code but it's been a while since I've really done serious C++.

As for what I had previously gotten working, I've never really done native node development before and I'm not too familiar with V8 internals. So this is an excerpt from my attempt at cobbling together various examples I've found across the internet:
#include <nan.h>

const int NUM_CHANNELS = 4;

void ProcessPixels(const Nan::FunctionCallbackInfo<v8::Value>& info) {
  unsigned long bufferLength = node::Buffer::Length(info[0]);
  unsigned char *bufferData = (unsigned char *)node::Buffer::Data(info[0]);
  unsigned long len = 0;
  for (unsigned long i = 0; i < bufferLength; i += NUM_CHANNELS) {
    for (int j = 0; j < NUM_CHANNELS; j++) {
      // Do something with the following
      // bufferData[i + j]; // Crashes when `i + j == 4435`
    }
  }
}

void Init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) {
  Nan::SetMethod(module, "exports", ProcessPixels);
}

NODE_MODULE(frames, Init)

The above crashes consistently when i + j is 4435 with SIGSEGV. So yeah, segfault. What I don't understand is why?... I also tried unit8_t * instead of unsigned char *, same result.

Okay, ignore the code "not working." I was using i in the inner loop when I meant to use j.
I'm still interested in my initial question though. Bypassing the usage of node Buffers and whatnot.

You can use v8::Object::GetAlignedPointerFromInternalField to get the native class pointer from the webContents object, but it would be very hard to call the right methods of it because Node doesn't know the headers of Electron, and the C++ interface is not exported.

So maybe a custom build of Electron with my own code added to WebContents? I could add a patch to the build process.

@knpwrs What did you end up doing here?

I wound up rendering what I wanted to render outside of Electron.


ARROW-1075: [GLib] Fix build error on macOS

int64_t is "long long" but gint64 is "long".

Can you rebase on master? Sorry, we force pushed to include the release tag and GitHub doesn't like it

Done!


preliminary teacher community

trim teach performance page and add modern algorithms workshop; add test join-us page with new form

Minor suggestion: Add Julia to the list of shared-memory parallel programming platforms.  (I know some people that would be happy with that addition.)


Cli tests

This is as far as I get with making Travis and CLI tests work.
We still fail on Shadow DOM API with jsdom.
@warpech please take a look

It does not run for me:
C:\www\PuppetJs>npm test

><EMAIL_ADDRESS>test C:\www\PuppetJs
> jasmine JASMINE_CONFIG_PATH=test/jasmine.json

Started
FFFFFFFFFC:\www\PuppetJs\test\spec\dom\LinksSpec.js:47
    div.createShadowRoot().appendChild(a);
        ^

TypeError: div.createShadowRoot is not a function
    at createLinkTestNestedShadowDOM (C:\www\PuppetJs\test\spec\dom\LinksSpec.js
:47:9)
    at null._onTimeout (C:\www\PuppetJs\test\spec\dom\LinksSpec.js:106:11)
    at Timer.listOnTimeout (timers.js:92:15)
 npm ERR! Test failed.  See above for more details.

Node v4.4.4
Can you update README.md with information how to run the CLI tests?

I have the same problem with v6.9.1

That's what I meant by "We still fail on Shadow DOM API with jsdom."
CLI test does not run, as there is no node environment that works with webcomponents.js (Shadow DOM)at least none I'm aware of.
So we will either

move to mocha+selenium (WCT),
remove Shadow DOM tests,
Move Shadow DOM tests and related functionality to puppet-client,

Is there a way to conditionally skip a test if document.createShadowRoot is undefined?

I bet there is, but I doubt if in long run somebody will care thet locally in browser test fails if npm test and travis are green.

I get it...
Can you then just pls add a warning that says that Shadow DOM tests fail because the test suite is not run in a web browser.

@tomalec your suggestion is to merge this as is, assuming that our tester in future will figure out how to make this pass in Travis and CLI? (phantomjs comes to mind).

Hm.. I thought I have commented it (maybe in some other repo ;) ), sorry
I managed to run it with phantomjs but is shown that we have tests failing in polyfilled browsers.
I'll merge it as it is. At least we could track the number of failing tests.

Merging


fix: don't error on empty comment line in matchExtension

Describe the PR
parseExtension will break on empty comment lines //
Relation issue
https://github.com/swaggo/swag/pull/1219
Additional context
My previous test cases weren't covering empty comment lines and in that case fields[0] breaks.
Added fix and tests.
More than open for further suggestions/improvements if there are any

@ubogdan Thanks for the merge #1219 earlier today.
Will need a bit more of your time. 👍

@igorkova Thanks for your contribution.


Idea: SWRL support

Here is a short description of a (probably bigger) feature that could be implemented:
The Semantic Web Rule Language combines OWL DL with a subset of RuleML. It allows to define rules that are beyond the expressiveness of OWL DL.
For example the following rule defines that someone who is your fathers brother is your uncle:
hasFather(x, y) ∧ hasBorther(y, z) ⇒ hasUncle(x, z)

This could be a nice feature to be integrated into Java file generation or even to have a possibility to annotated Anno4j interfaces with such rules.
Because of the complexity and the undecidability of SWRL the supported feature set would have to be constrained. In order to limit implementation effort an existing rule system could be used.

An inference engine has been implemented for a subset of SWRL. For details on the constraints and how to use  the engine see the Wiki.
Basic procedure of rule evaluation
For execution of a rule the engine first determines a SPARQL-serlizable part of the antecedent and translates it into a SPARQL-query. This way a candidate solution set can be retrieved. On basis of these candidates computation is done by the remaining built-ins. This process ends up with an enriched candidate set where all variables are bound to a value. For each candidate solution is checked if it fulfills every atom. In case this is true the candidate is taken as a solution.
After the engine has the solutions for the body it translates the head into a SPARQL INSERT query replacing the variables with their respective solution bindings and executes it.
This is done as long there are no more changes done to the triplestore by any rule.
** Reordering and optimization**
In order to evaluate rules correctly and efficiently with the above procedure a certain order must be imposed on the antecedent. First a dependency graph is constructed and brought into dependency order using Kahn's topological sort algorithm. Afterwards SPARQL-serializable atoms are pulled as far in front as possible in order to ensure that a maximal prefix can be translated into SPARQL.


Investigate Integration test degradation with<EMAIL_ADDRESS>

As discovered in PR #274, the latest version of rattler-build degrades our compatibility to the point where we no longer pass some integration tests.
It is good to see that this early alert system is working as intended! So we need to go in and figure out what happened and if we need to make any improvements to maintain our current level of compatibility.

Well there's your problem:

Passing
Failing

65 converted recipes no longer pass the dry-run stage.

I think I've found the culprit: https://github.com/prefix-dev/rattler-build/pull/1271

The conversion script should default to == when the version is ambigous, but it should also provide a warning.
Here's some example rattler-build output to use for inspiration:
Error:
  × Failed to parse recipe

Error:
  × Parsing: an unspecified error occurred.
    ╭─[34:7]
 33 │     - jpeg 9e
 34 │     - zlib 1.2.13
    ·       ─────┬─────
    ·            ╰── This match spec is ambiguous. Do you mean `zlib ==1.2.13` or `zlib 1.2.13.*`?
 35 │     # Optional dependencies
    ╰────


Genefunk 2090 Fix numerous bugs

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Bug Fixes

[x] NPC Attack rolls not showing by default
[x] Multiple/long word features are getting cut off by the hex display’s borders

Very very long entries will still cause an issue

[x] Hack DC showing up as “0” for hacks run.
[x] All Saving Throw and Ability checks for NPCs result in errors
[x] Proficiency Bonus Not Adding To Attack Rolls in Actions Section
[x] Crits Aren’t Giving Extra Damage
[x] Can Players Expand Crit-Range?
[x] Hit Points Don’t Display For New NPCs
[x] Request: Have Description Text Display When Clicked in Chat

This was actually a bug as the attribute to control whether descriptions were output or not was not in the sheet

[x]  Genetic Enhancement: Danger Sense bug

This was a minor data error where the mod was duplicated in the entry

Character Sheet Info Roll20 Internal Use only.


Smart Table not updating the data.

Hi,
I am trying to display a data using smart table. I am confused why it was not updating it's new data. I tried to add or update the column value but the table did not reflect the new data.
here is my ts code
this.orderService.ImportOrders(this.userId,xml).subscribe({
      next: (res:any)=>{
        //console.log(res)
         data = this.tableData.map((item,index) => {
          if (item['error']!== undefined) {
            item['error'] = res[index].error;
          }
          if (item['errorflag']!== undefined) {
            item['errorflag'] = res[index].errorFlag
          }

          return item;
        });

      },
      complete:() =>{
        this.tableData = data
        this.changeDetectorRef.detectChanges();
        console.log('new data',this.tableData)
      }
    })

and here is my smart table template

     <c-smart-table #smartTable="cSmartTable" activePage  clickableRows [columnSorter]="true"
            [columns]="columns" header
            [items]="tableData"
            pagination

            [tableProps]="{ hover: true, striped: true, responsive: true }">

            <ng-template cTemplateId="tableData" let-columnName="columnName" let-item="item"
                let-tdContent="tdContent">
                <td [cTableActive]="smartTable.tableDataCellProps(item, columnName)?.['active']"
                    [cTableColor]="smartTable.tableDataCellProps(item, columnName)?.color"
                    [cAlign]="smartTable.tableDataCellProps(item, columnName)?.align"
                    [ngClass]="smartTable.tableDataCellClasses(item, columnName)"
                    [ngStyle]="sortedColumnKey === columnName ? sortedColumnStyle: {}">

                    <ng-container [ngSwitch]="columnName">

                        <ng-container *ngSwitchCase="'StartDate'">
                            {{(item[columnName]) | date : dateFormat}}
                        </ng-container>

                        <ng-container *ngSwitchCase="'ExpirationDate'">
                            {{(item[columnName]) | date : dateFormat}}
                        </ng-container>

                        <ng-container *ngSwitchCase="'error'">
                            <span>{{item.error}}</span>
                          </ng-container>

                        <ng-container *ngSwitchDefault>
                            {{tdContent}}
                        </ng-container>
                    </ng-container>
                </td>
            </ng-template>
        </c-smart-table>

    I am using angular 14

    Thanks in advance

We do not know much about your orderService. It seems ImportOrders returns an Observable that you can subscribe to, providing partial Observer with next and complete notification callbacks. The complete will be called only once - when the producer is done and will send no more next values.
Questions:

When your observable completes? (Does it complete at all?) -> Do you see 'new data' in the console log (when)?
What happens if you move the assignment this.tableData = data from complete() to next()?

this.orderService.ImportOrders(this.userId, xml).subscribe({
  next: (res:any) => {
    this.tableData = this.tableData.map((item, index) => {
      // ...
    });
    console.log('new data', this.tableData)
  }
})

Also:

What's the initial value of tableData?
If there is no error or errorflag in the res array, there will be no change to the tableData. You'll get the exact copy of tableData array. Is this right?
If there is an error or errorflag in the tableData array row (aka item), item.error will be overwritten with res[index].error - it mutates item object. What about returning a shallow copy on item object?

return {...item};

Hi @xidedix ,
Yes, I saw the changes in the console. The initial tableData has error and errorflag.  I just overwrite the value when I call the api.

Hi @xidedix ,
I am opening this issue again. Actually I closed this issue before because I decided to use the generic table in bootstrap due to some issue with smart table not updating the value. And now, We want to use the smart table for this because we need some of the features of it but the problem is the smart table did not detect the changes from the array when the array is updated.
The array is TableData and it is perfectly binding when adding items to it and displays it into the smart table. The problem comes when I tried to update the the record of TableData that binds to smart table. Kindly check if I am doing this right.
EditPrice(item:any){
    const price = 200;

    let indextoUpdate = this.TableData.findIndex((x:any)=>x.idx == item.idx);
    alert(indextoUpdate)
    this.TableData[indextoUpdate].price = price;
    this.TableData[indextoUpdate].total = price * this.TableData[indextoUpdate].qty;
    this.TableData = [...this.TableData];

    console.log('edit price',this.TableData)
  }```
  The console log shows the recent changes or the new updated values but in the Smart Table, the records were still the same it seems it was not detected that there was a changed in the array.

  Please advise. Thank you

@32x0lf
What happens if you clone your array like this:
this.TableData = JSON.parse(JSON.stringify(this.TableData))

?

Hi @xidedix ,
It works. It changes the display. but why it needs to be parse?


The meaning of documents provided in drive.google

What are the model parameters provided in drive.google?
What I understand is that alpaca-lora-7B/adapter_model.bin is the parameter fine-tuned after the first stage instruction tuning, and alpaca-lora-7B/checkpot-800(600/1000) are the parameters after the second stage recommendation tuning, is that right?

尊敬的作者您好，请问这个意思是说second finetune stage最终的lora weight没有在google drive里面吗？

尊敬的作者您好，请问如果想用您训练好的结果直接在evaluate上面做，base_model 和 output_dir 里应该放哪个文件呢？


Update README.md

Enhancing Readability.

Why would you make such a pull request ? :-1:

Sorry but I don't accept PR for docs


Does it work with the updated Chrome Dev Tools?

I'm not able to have the Chrome Dev Tools work a Profile file generated by py2devtools.py.
I quickly compared the format generated by py2devtools and the one generated by Chrome and they seem quite different. The former starts with an object, the latter with an array. Since it looks like the Chrome Dev Tools have been updated recently, I wonder if the format expected has changed.
Are you still able to get Chrome to load your profile files?
Thanks,
J

As an alternative strategy, I was able to use v1.0.2 of the chrome2calltree tool to produce a Callgrind file from the py2devtools output, which worked with the QCacheGrind tool installed via Homebrew on a Mac (as noted in the npm package docs; there's also KCacheGrind for Linux, not sure about Windows). The UX is quite different from Chrome, but I was at least able to get some useful data out of my profiles this way.


license: update license to in sync with Perl/perl5

Looks like the license got updated into Artistic-2.0 per 298c06c692f6550db63b18336f4ad4c5eef95f61, which is not aligned with perl5, https://github.com/Perl/perl5/blob/blead/Copying. Thus, filing this PR to update license, @toddr let me know if it makes sense. Thanks!
relates to:

#97
https://github.com/Homebrew/homebrew-core/pull/158500

cc @toddr

@toddr gentle ping

Larry's license is the Artistic license, not GPL.


soroban-rpc: preflight: remove key sizes from read_bytes computation

Core stopped including including them
Followup from https://github.com/stellar/soroban-tools/pull/913#discussion_r1313608612

This has unveiled yet another ResourceLimitExceeded error when running the BumpFootprint operation. The test fails at https://github.com/2opremio/soroban-cli/blob/remove-keys-from-fee-estimation/cmd/soroban-rpc/internal/test/simulate_transaction_test.go#L748
envelope: AAAAAgAAAABzdv3ojkzWHMD7KUoXhrPx0GH18vHKV0ZfqpMiEblG1gAAZqAAAAAAAAAABAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAGQAAAAAAAAAUAAAAAQAAAAAAAAABAAAABgAAAAFnrAIfzK644FciM7c4L1q7oxCN5UdDC/Y0lL2onFdNaAAAAA8AAAAHQ09VTlRFUgAAAAABAAAAAAAAAAAAAAB0AAAAAAAAAAAAAE5FAAAAARG5RtYAAABAGAKEmnKibE8ikaCWwDf34EbFh3OeWSWc4gnsF0RY8B8+xLuOsB/EgHjf1Ns1/r0WssqDrf3P8zO2H3V9k/8pAA==
The soroban transaction data is the following. My guess is that we are not accounting for the written expiration entries. I will try to fix that.

Unfortunately, adding the write bytes didn't make the test pass. Here is the new soroban transaction data:

Now, thinking about it, the write_bytes couldn't be the problem since they were already 0 before this PR.

If you set read_bytes to 128 the test passes but it fails if set to 127 so we are missing 128 - 116 = 12 bytes which I am not sure how to account for.

The serialized length of an expiration ledger entry is 48, and not 36. This explains the missing 12 bytes :S
I noticed that fees.rs in rs-soroban-env also gets it wrong (@sisuresh I guess you copy-pased it from there) so it should be corrected.

To be more specific. This prints 48:
	entry2 := xdr.LedgerEntry{
		LastModifiedLedgerSeq: 4,
		Data: xdr.LedgerEntryData{
			Type: xdr.LedgerEntryTypeExpiration,
			Expiration: &xdr.ExpirationEntry{
				KeyHash:             xdr.Hash{},
				ExpirationLedgerSeq: 0,
			},
		},
		Ext: xdr.LedgerEntryExt{},
	}
	bin, err := entry.MarshalBinary()
	assert.NoError(t, err)
	fmt.Println(len(bin))

This is ready to merge, but let's not do it until @sisuresh / @dmkozh confirm  that the EXPIRATION_ENTRY_SIZE fix is correct.


Delete Labels Patch

I'm not sure how exactly that is going to work, given I accidentally made that change into main directly.

Thanks! So, I am closing this PR then.


Set up matterbridge (or some alternative) between slack and telegram

doesn't look very stable yet


🍒 Cherry pick PR #12072 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/12072 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.2.18-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @chiragsalian in version: 1.2.18-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Automation] Generate Fluent Lite from Swagger newrelic#package-2024-01-01

[Automation] Generate Fluent Lite from Swagger newrelic#package-2024-01-01

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-newrelicobservability


Installation issues

pip install giza-cli return
Ignored the following versions that require a different python version: 0.0.1 Requires-Python >=3.11,<4.0; 0.0.2 Requires-Python >=3.11,<4.0; 0.2.0 Requires-Python >=3.11,<4.0; 0.2.1 Requires-Python >=3.11,<4.0; 0.3.0 Requires-Python >=3.11,<4.0; 0.4.0 Requires-Python >=3.11,<4.0
ERROR: Could not find a version that satisfies the requirement giza-cli (from versions: none)
ERROR: No matching distribution found for giza-cli
expect：
The required python version is stated in the documentation.

Hello @traderalexfly
Thank you for opening this issue, as the error states we are using python 3.11 and onwards but we have not commented so in the docs.
We will add this to the docs and include a short tutorial on using pyenv for handling different python versions in the same system.
There will be a PR shortly.
Thank you!

At the Installation docs we have added a new entry showcasing that we recommend pyenv to handle python environments and stating that python 3.11 is needed! The changes have been added in #26


Support different types of ioctl request argument

ioctl request argument type can be different on different targets: https://github.com/rust-lang/libc/issues/1036

Faced with this problem on armv7-unknown-linux-musleabihf, but there a lot of other targets.

Thank you for your pull request. It indeed does not compile for musl since musl is POSIX compliant whereas glibc is not (http://pubs.opengroup.org/onlinepubs/9699919799/functions/ioctl.html). Your solution seems like a good way to get around this difference :+1:


[HELP!] Problem occurred when I used an array or object for ngModel

// js
var app = angular.module('app', []);
app.controller('ctrl', function($scope) {
  $scope.data = [1, 2, 3];
  $scope.push = function () {
    $scope.data.push(4);
  };
  $scope.cover = function () {
    $scope.data = [7, 8, 9];
  };
});

<input ng-model="data" type="text" /> {{data}}
<p>
  <button ng-click="push()">push</button>
  <button ng-click="cover()">cover</button>
</p>

I wonder why when I click the update button, data in the input does not change, but the cover function will work.
view in plunker

By default, test inputs are bound to string values. So, $scope.data will be set to a string (which doesn't have a push method). If you want to bind to an array, you can use ngList (updated plnkr), but it can only be an array of strings, of course.
--
That said, this is a general support question and is better suited for one of the general support channels.
GitHub issues are reserved for bug reports and feature requests.

@gkalpak Thanks.
Here is a link about ngModelWatch


[Docs] Add pydocstringformatter to precommits

Closes #165.

@dominikandreasseitz Not sure the gain is over the Moon but still.


[Job] Do not silent delete job when preserve is set to true

It can make must-gather blind to failed jobs

It can make must-gather blind to failed jobs

Could you be a bit more specific what leads to the missing jobs? If the job's input did not change then the job hash should not change either and therefore I don't expect that a new job is created leading to the old job's deletion.

It can make must-gather blind to failed jobs

Could you be a bit more specific what leads to the missing jobs? If the job's input did not change then the job hash should not change either and therefore I don't expect that a new job is created leading to the old job's deletion.

my motivation came from: https://github.com/openstack-k8s-operators/openstack-ansibleee-operator/pull/341
AEE was wrongly changing hashes when handling a map field, it was hiding the failures on CI which led to people bumping the timeout. It took a lot of time to find what was hiding the AEE failures.

actually, AEE is the right place to make changes


ImportError: cannot import name 'build_regex_from_object' from 'outlines.fsm.json_schema'

Description
Running python -m sglang.launch_server yields this error. I was running it in a container, which I'll describe below.
outlines-server-1  | Traceback (most recent call last):
outlines-server-1  |   File "<frozen runpy>", line 198, in _run_module_as_main
outlines-server-1  |   File "<frozen runpy>", line 88, in _run_code
outlines-server-1  |   File "/usr/local/lib/python3.11/site-packages/sglang/launch_server.py", line 3, in <module>
outlines-server-1  |     from sglang.srt.server import ServerArgs, launch_server
outlines-server-1  |   File "/usr/local/lib/python3.11/site-packages/sglang/srt/server.py", line 25, in <module>
outlines-server-1  |     from sglang.srt.constrained import disable_cache
outlines-server-1  |   File "/usr/local/lib/python3.11/site-packages/sglang/srt/constrained/__init__.py", line 4, in <module>
outlines-server-1  |     from outlines.fsm.json_schema import build_regex_from_object
outlines-server-1  | ImportError: cannot import name 'build_regex_from_object' from 'outlines.fsm.json_schema' (/usr/local/lib/python3.11/site-packages/outlines/fsm/json_schema.py)
outlines-server-1 exited with code 1

Reproducing
Here's the dockerfile, super simple:
FROM python:3.11
RUN pip install sglang[all]
ENTRYPOINT [ "python", "-m", "sglang.launch_server" ]

Running:
docker build  --rm -t sglang-server .
docker run sglang-server --model-path mistralai/Mistral-7B-Instruct-v0.2

Notes
I also tried this with the python 3.10 image, same issue. It also didn't work outside of docker.

Update: this seems to work again when installing from source, so the bug might be in the distribution.

i meet the same problem

+1 for this. I meet the same problem when I use llava-v1.6-mistral-7b

The error is caused by wrong outlines version in the latest release(0.1.12).
The workaround is to manually specify the version constraint of the outlines package by:
pip install "sglang[all]" "outlines<=0.0.30"

This is caused by the outlines API change, and we temporarily pin the outlines' version here https://github.com/sgl-project/sglang/pull/196.
Thanks @crissed53.

Pinning the outlines breaks up everything around it.

Downgrade outlines to the project specified version, e.g.
pip install outlines==0.0.27


Perlin Noise Field in Processing source file missing

I can't seem to find the PerlinNoiseFlowField Processing code, CC_24, the Processsing version is missing. Tough in the video there was this processing version show. I like to use Processing because of Java and would love to see how the same was done in Processing.

https://github.com/TheLastDestroyer/website/tree/CC_024_processing/CodingChallenges/CC_024_PerlinNoiseFlowField_Processing


Clarify semantics of custom_call::has_side_effect

fixes https://github.com/openxla/stablehlo/issues/1365.
Please refer to the issue for more information.
Evolution of this PR: Closed the initial  attempt, which has some feedback comments which are now incorporated in the current PR.

This pull request hasn't been active in a while. I'll be closing it for now, to be reopened when we have more cycles.


new brand colors

updated logo and colors

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a08320a13de853548cef15646a30127770e0744e/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b6a5d7bb9783a571b28b131f03a3b3acc1c11614/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e37d84d64073caf6a82b51efea275ec55728cdd2/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ad6be8c4bc779c38164e717cc875172c5c48eb0a/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/42a01d346501e3e073211e968ae513507e043ba1/

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4c8134a9f79201e07b5155f1c7004bbb2290cba8/


Security issue on join

Hi @perak ,
I used join many times and found this accidentally. I explain issue based on invoices example that available online and easier to refer and see problem.

Go to this page please.
If I set join for a field, kitchen generate code with publishJoinedCursors function but issue occurs on client when I run this two command in above page: (for example in firebug console)

JSON.stringify(Invoices.find().fetch());
JSON.stringify(Customers.find().fetch());

JSON.stringify(Invoices.find().fetch());
"[{"_id":"5RnWyzwrF8cyrCCaY","invoiceNumber":"1","date":"2015-09-30T20:30:00.000Z","customerId":"LPMcKGjNY6ChnJwWk","createdAt":"2015-10-01T16:03:28.252Z","createdBy":"GQfJEuBw75WM4poRc","ownerId":"GQfJEuBw75WM4poRc","totalAmount":0}]"
JSON.stringify(Customers.find().fetch());
"[{"_id":"LPMcKGjNY6ChnJwWk","name":"Chuck Norris","email":"internet@chucknorris.com","ownerId":"GQfJEuBw75WM4poRc","createdAt":"2015-10-01T16:02:53.532Z","createdBy":null,"totalAmount":0}

This is field definition in json file:

"name": "invoices",
				"fields": [
...

					{
						"name": "customerId",
						"title": "Customer",
						"required": true,
						"input": "select",
						"lookup_query_name": "customer_list",
						"lookup_field": "name",
						"lookup_key": "_id",
						"show_in_dataview": false,
						"show_in_read_only_form": false,
						"exportable": false,

						"join_collection": "customers",
						"join_fields": ["name"],
						"join_container": "customer"
					},...

As you see I set "join_fields": ["name"] in join but in client all Customer field available for example<EMAIL_ADDRESS>and if email is a secret data it is a security issue.
How to define join in a way that this issue does not happen and only fields pass to client that specified in "join_fields" section.

Are you sure you didn't subscribed to customers from another place?

Yes I sure @perak ,
You can check yourself invoices example to see the issue.

Do you see issue @perak . This is a bug or I missed something?

@cyclops24 I didn't have enough time to check this issue yet, I'll do it soon...

Hi @perak I think it's an important bug in join package. Do you have any idea to fix this?