[WIP] Nullable embedded objects.

The idea was to have a simple (and clean) way to override the nullable property of embedded objects, so I've
added the nullable attribute on the @Embedded annotation and it have 3 possible values:

NULL: The nullable option that was defined on the attributes of the embeddable class won't be overriden;
TRUE: All attributes of the embeddable class will be marked as nullable and the embeddable instance only would be created when data is not NULL;
FALSE: All attributes of the embeddable class will be marked as non-nullable.

There's a lot of things to be improved (mostly on UnitOfWork), but it's fully working with basic tests as you can see on ValueObjectsTest::testCRUDOfNullableEmbedded() case.
I would appreciate a lot your opinions!

:+1: that would be great if it could fit in 2.5

I have implemented @1ed suggestion with that minor refactor.
We should update the interface, but it seems better to me.

@lcobucci What is the status of this?
Because it's only one few days left until the feature-freeze for the 2.5 release. It would be great if this could make it into 2.5.

It is "working" @alsar, but we have to clean some stuff to make it better. I'll send some commits right now.

FALSE: All attributes of the embeddable class will be marked as non-nullable.

this case looks weird to me. It changes an optional field to a required one in the embedded object

@stof please give us more arguments, let's debate :smile:.
In 6340eece56c8088ddb343fb76258c3545e872b2a I added a test for that cenario and I believe that in the "country" context is the only way to make the embeddable required, but when dealing with complex value object it can be weird.
The main question that comes to me is: should we have really complex value objects?

I tend to agree with @stof about the FALSE case. Why would one want to make an optional field of the VO required? This really changes the VO semantics and should probably be another VO instead. Would need a good use case IMO otherwise the FALSE option does not make much sense to me.

@deeky666 the feature that I need is the TRUE case. As I said before, with simple VO (like the one in ValueObjectsTest) it can make sense but when dealing with complex value objects it is weird.
I can remove the FALSE case so we can merge this feature to doctrine 2.5, and the future will tell us if it was a wise choice.

So, do we remove the FALSE case guys?

@lcobucci lets remove false for now and get this merged into 2.5.
I can then be added to 2.6 if it will be needed.

I've removed the false (by ignoring it), should we raise an error when somene try to use false as value for the nullable option on embedded objects?

@Ocramius @deeky666 do we need something else in order to merge this?

should we raise an error when somene try to use false as value for the nullable option on embedded objects?

Yes please

Also: what happens when a nullable embeddable has null fields for properties explicitly mapped as non-null?

Also: what happens when a nullable embeddable has null fields for properties explicitly mapped as non-null?

The non-null fields would be mapped as nullable.

Which in turn allows for invalid state to be stored/persisted in the embeddable. I think that's quite the deal breaker.

Which in turn allows for invalid state to be stored/persisted in the embeddable. I think that's quite the deal breaker.

Ok, but the embeddable should be responsible for dealing with that by not accepting the creation of the object without the required fields, no black magic here.
There's no way to make the embedded optional in one place and required in another without overriding the embeddable fields configuration.

Would it be possible to instead let @AttributeOverides apply to embedded objects? That would allow more control over marking individual fields as nullable, but also allow much more control over other properties, and using a concept that is already part of doctrine.

I think the only way to make embeddables nullable (in a safe way) right now is to allow nullable embeddables only when all @Embeddable fields are nullable=true.

Would it be possible to instead let @AttributeOverrides apply to embedded objects?

As of @schmittjoh said on the draft of this PR we already have a way to override embeddable mapping.

I think the only way to make embeddables nullable (in a safe way) right now is to allow nullable embeddables only when all @Embeddable fields are nullable=true.

The point that I'm trying to explain here is that the safe way should be granted by the constructor not by the embeddable mapping. With the @AttributeOverrides we can can change (in a messy way) the mapping to make everything nullable and the instance will be created (with NULL on every single attribute).
On the draft (and on the test case) we have examples for what I'm saying and you can see that we won't have an invalid state.
Please @Ocramius help me to open my eyes and understand the problem you're saying.

@Icobucci you have to remember that the ORM keeps consistency both at object and at DB level at heart. If an embeddable is nullable, then all of its fields should be nullable at DB level as well, leading to inconsistent state, at which point I'd simply say:

use a json-serialized manually-coded embeddable, knowing what you are facing
use a one-to-one association instead of an embeddable

@Ocramius I understand that, but I disagree that the requirement of the embeddable should be the same on every context.
Looking at the DB level, (IMO) is not an inconsistent state to have the embeddable fields nullable on a table a required on another, because at the DB level what is important is the tables and by looking to them there is no reason to know if the field was declared by an entity or an embeddable.
Embeddables are a reusable set of values (we can also link with value objects of DDD, but I'll pass this argument for now) and if I want to say that, in a given context, I want to make that set optional I shouldn't be blamed.
By setting the nullable as TRUE on the @Embedded I'm saying that I'm well aware of what I'm doing and what will be the consequences.
I don't see embeddables strong enough to become a one-to-one association and weak enough to be mapped as a json-serialized object.

By setting the nullable as TRUE on the @Embedded I'm saying that I'm well aware of what I'm doing and what will be the consequences.

No, by setting nullable as TRUE you are making it nullable: you are not accepting the idea of invalid data being hydrated
"nullable" and "inconsistent" are very different concepts, and SQL DBMSs without struct-like fields aren't able to deal with this sort of data-integrity problem in a decent way, therefore it's simply better to avoid the problem in first place by putting a strict limitation instead of building more foot-gunning tools

Well, we agree to disagree :smile:
We still have ways to bypass the original mapping with the @AttributeOverrides an that will lead us to an useless instance, which is pretty inconsistent to me.
You have arguments against and I have arguments in favour, but all of them was already written and we will be repeating and throwing words in the wind if we continue the debate.
If the you and the other doctrine maintainers don't think this is a good increment we should close this PR, agreed?

@Ocramius I just saw your sample code, let me explain my POV (for one last time)...
class Credentials // embeddable
{
    /** @var string (never null) */
    public $username;
    /** @var string (never null) */
    public $password;

    private function __construct($username, $password)
    {
        $this->username = $username;
        $this->password = $password;
    }
}

class User
{
    public $credentials; // embed here, required
}

class Client
{
    public $credentials; // embed here, nullable
}

The ORM will NEVER run:
INSERT INTO users (credentials_username, credentials_password) VALUES ('ocramius', null);
-- OR
INSERT INTO users (credentials_username, credentials_password) VALUES (null, 'hello');
-- OR
INSERT INTO users (credentials_username, credentials_password) VALUES (null, null);
-- OR
INSERT INTO client (credentials_username, credentials_password) VALUES ('ocramius', null);
-- OR
INSERT INTO client (credentials_username, credentials_password) VALUES (null, 'hello');

The only valid options are (at the ORM level, of course):
INSERT INTO users (credentials_username, credentials_password) VALUES ('ocramius', 'hello');
-- AND
INSERT INTO client (credentials_username, credentials_password) VALUES (null, null);
-- AND
INSERT INTO client (credentials_username, credentials_password) VALUES ('ocramius', 'hello');

One can execute the invalid queries at the DB level, and that will indeed lead us to an invalid state but that can cause trouble on other ORM areas as well (like the second level cache).
I understand what you're explaining, I just think that this issue can be reached with or without this PR.
Well, thanks for the discussion :smile:

I just think that this issue can be reached with or without this PR

That's exactly where I wanted you to go to: this starts to treat the ORM as a gateway to a SQL DBMS used as a NoSQL DBMS :-)
This sort of constraint must be at DB level as well, as the ORM must be able to operate with datasets that are not managed by it.

I really would like to have such thing.
My use case: an Order with two embedded Address: billingAddress and invoiceAddress. The first one is required, the second one is optional.
It seems I have to store the adresses in a separate table and make two associations, but I wouldn't like that because limitations of the current backoffice.

Embeddables are very useful for value objects. Usually a value object can't have empty data and this is enforced in the constructor. When you assign null to a field with embedded object then all of it's columns will become null (if nullable). Then after hydration you will get a VO with empty data, which isn't a permitted state - your domain is fubared.
The only solutions I see:

don't use embeddables for optional properties
implement a method like isEmpty on each value object which really breaks a lot of stuff (ex. serialization) and is really ugly; you also have to remember not to do any checks like if (null !== $this->optionalPropertyVO)

Is this idea scrapped for good?
I had never dived into Doctrine internals so I've got the question: Is it impossible to check if embedded object is nullable and - during hydration - if all its fields in data-row are null.... than not hydrate it?
 My model is mostly bulletproof in context of consistency and what I need is data mapper which is flexible enough to accommodate to my needs.
Unfortunately Doctrine often stands in the way of truly persistent agnostic model.

Is it impossible to check if embedded object is nullable and - during hydration - if all its fields in data-row are null.... than not hydrate it?

Yes, it is possible, but it requires some effort, and the performance overhead must be measured.

My model is mostly bulletproof in context of consistency and what I need is data mapper which is flexible enough to accommodate to my needs

Then write a custom mapper: doctrine is not a flexible data mapper, it is a data mapper with a very opinionated approach. Custom use-cases shouldn't pollute the core API with hacks that actually lead to more bugs than what they solve.

Unfortunately Doctrine often stands in the way of truly persistent agnostic model.

That is true, but the only solution to that is custom persisters and hydrators, and not necessarily ORM-based. We still didn't get around to design those.

Hi @Ocramius do you think this should be reopened as another bug in JIRA? I still think that this should be done somehow. Maybe a metadata column so that the underlyining embedadble properties have not to be set as nullable?

so what is the current state? this is a real missing feature!?

I would love this feature!
We have a big project with lots of value object. Right now our code is polluted with SomeVOInstance->isReallyEmpty() code.

Guys I think its pointless to discuss this without suggesting a solution to our problem.
When I wrote this PR I thought only about OOP and then @Ocramius said that people could have invalid state by inserting or updating the tables using SQL.  So I truly understand the frustration, but we can't say that our code is bullet-proof and allow possible issues - or maybe vulnerabilities - be injected into our dependencies.
I think that the only way to have this feature is to create it as an extension.

I would be willing to (at least try) to implement this feature as an extension. Is there currently an elegant way to inject custom Hydrator/MetadataFactory (as defaults)? Could anybody point me in the right direction?

This is a chicken-egg problem, folks. Not going to happen unless somebody finds a solution to the data consistency problem first.

Also: using the object type is perfectly legit.

I think it might be best to use an extra column that has a 1 or 0 to check whether an embedded property should be null or not.

@schmittjoh How do I do it transparently in the userland? Could you give me a hint?

Something along these lines should work:
class Foo
{
     private $embeddable;
     private $isEmbeddableSet;

     public function getEmbeddable()
     {
         if ( ! $this->isEmbeddableSet) { return null; }

         return $this->embeddable;
     }
}

We actually don't need a modified Hydrator as you can see in the files I've changed.
The MetadaFactory is easily injected on EntityManager configuration as you can see here: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/EntityManager.php#L147
You can also create an extension of the AnnotationDriver and pass it to your configuration too.

@lcobucci thanks, I will look into this.

Does somebody know how they resolve this issue in Hibernate?

@pinkeen, it should be possible to hide the implementation details behind a Doctrine API, so that you do not need to deal with this in user-land, someone would need to create a pull-request though to allow for further discussion
@alsar, last time I checked, it was what I outlined above

hmmm... very tricky :| is there any known existing extension for this problem?

I don't understand the argument that even with someone manually modifying database the consistency of application should still be valid.
To make an analog, you could in your domain specify that the only allowed values of an object are 1, 2 and 3, and then someone goes to database and update the value to 4. It would still produce invalid state, and could still have catastrophic consequences.
As @lcobucci said, it would be perfect fine to define it nullable in one place and not nullable in other places, and if we eventually follow the idea of having this as a separate table, it would still need to follow the same schema, probably meaning that all columns would be nullable or following the mapping of the embeddable. This basically means that the only way to store embeddables in relational databases is by using columns.
I personally never seen a reason to create a VO with null properties since it doesn't represent any value and the idea is in the opposite direction.

I've been testing this branch and I noticed that it doesn't work with multiple levels of embeddables. It creates the object no matter if all columns of all nested embeddables are null.

What about allowing nullable embedables only for DBs that have constraints?

Nope.
On Feb 23, 2016 13:07, "Filip Procházka"<EMAIL_ADDRESS>wrote:

What about allowing nullable embedables only for DBs that have constraints
http://www.postgresql.org/docs/8.1/static/ddl-constraints.html?
—
Reply to this email directly or view it on GitHub
https://github.com/doctrine/doctrine2/pull/1275#issuecomment-187674516.

@FabioBatSilva I didn't tested that kind of thing but I don't think would be something difficult to achieve.
I also believe that @Ocramius's statement was good enough to end this (as a standard feature):

That's exactly where I wanted you to go to: this starts to treat the ORM as a gateway to a SQL DBMS used as a NoSQL DBMS :-)
This sort of constraint must be at DB level as well, as the ORM must be able to operate with datasets that are not managed by it.

About @fprochazka's comment:
We cannot expect to push a lot of logic to doctrine's shoulders (it already have too much to carry now). I believe that we need to find a way to solve #4568 and also that we should treat this feature as an extension (if it would be really needed after solving that issue).

@lcobucci I think you are accepting this argument too fast. Allowing mappings to happen doesn't mean that this will make a SQL DBMS to be used as DBMS. By doing this you don't start storing documents or objects.
The thing is that the mapper as we have now, does not support proper optional objects. The goal of the mapper as I understand is to map any design you can possibly have in your code to relational databases, and having optional (null) properties is far too common to be ignored. Its the same as when we didn't have the embeddables feature and we would choose to design everything with scalar types just to fit the mapper.

Oops you're correct @fabiocarneiro sorry hehehe.
No, I'm not accepting it too fast (it was a long discussion already :smile:).
With #4568 we will be able to use the @AttributeOverrides annotation as @schmittjoh commented on the gist that I created before sending this PR. It may lead to the same problem that @Ocramius mentioned however it will not require any other change on doctrine - and only users that are 100% sure that the database is not handled by other thing rather than doctrine would use it.

@lcobucci as far as I understood, we could use attribute overrides to force all mappings of embeddables to be null, meaning that it could be different configuration in different columns. But how does that prevent the hydration of the object that has both columns nullable?
For my value objects, null are inconsistent state, but for the entity that has it as property its not. What I really want is the object not to be created rather than its properties having null.
ORM must be able to operate with datasets that are not managed by it. How exactly by adding this feature we would prevent this to happen?

But @fabiocarneiro, that's exactly what's being stated on #4568.
In this PR I've fixed it partially and added the nullable attribute, we need to cover it properly and think about all edge cases and we don't need the nullable modifier because we can achieve it in different ways.
I think we should see with @Ocramius || @guilhermeblanco || @schmittjoh what we could do about that (but on the scope of that issue and not on this PR).

There are database features that allow these kind checks in various ways at db level. Just because doctrine can not infer a schema that facilitates such features, doesnt mean it should assume these features are not available. also the mapping to schema conversion is just a secondary feature of doctrine to ease database creation and not to replace each and every (vendor-dependant) db feature.
i would really like this feature to be added.
the eal problem comes when all fields in the embeddable are nullable and the embeddable itself is nullable, because we can not distinquish between a null embeddable and an embeddable containing only null values. a separate boolean-like column is required in this case.

the eal problem comes when all fields in the embeddable are nullable and the embeddable itself is nullable, because we can not distinquish between a null embeddable and an embeddable containing only null values. a separate boolean-like column is required in this case.

That is a sensible solution, although a joined one-to-one is simpler and better for this scenario (and adding a 1-to-1 join is a low cost operation, if indexed correctly)

Sorry to up this, I read back a lot, but it is possible I have missed something. What about this?:
If all fields are null, check the embeddable configuration. If the configuration specifies that it is nullable, set is as null. If it is not nullable, create the object in every case, even if all fields are null.
$address = new Address(); // all fields nullable, and null
$order->setShippingAddress($address);

$em->persist($order);
$em->flush();
$em->refresh($order);

// null (assuming the configuration specifies nullable=true)
$order->getShippingAddress()

// instanceof Address, empty (assuming the configuration specifies nullable=null)
$order->getShippingAddress()

@Padam87 pretty much wrote down my own thought about this. Can we get a response to his comment? cc @Ocramius @lcobucci

It is a possible implementation, but nullability on all embeddable fields would then be disallowed (need at least one non-null field).
That's a good idea for 3.x, so if anybody wants to help out, start from develop :-)


No operation detected

Hi,  trying the openapi viewer i got an message saying that there is not operation in the spec. I change the packagesToScan as follow and  it works:
packagesToScan: se.magnus
As the openapi operations are in the api project, openapi can not found any operations. Than you

Hello Charlie!
Thanks for reporting this error!
I have tried to reproduce the error asuming you are on chapter 5 "Adding an API Description Using OpenAPI" by follwoing the instructions in the book like:
export BOOK_HOME=~/Documents/Microservices-with-Spring-Boot-and-Spring-Cloud-2E
git clone https://github.com/PacktPublishing/Microservices-with-Spring-Boot-and-Spring-Cloud-2E.git $BOOK_HOME

cd $BOOK_HOME/Chapter05
./gradlew build && docker-compose build && docker-compose up -d

./test-em-all.bash

When I open the OpenAPI viewer using the URL http://localhost:8080/openapi/swagger-ui.html I get te expected web page:

So, I can't reproduce the error you reported.
Have you changed anything in the code, e.g. upgrading some dependencies?
Can you repeat the exact commands as shown above and let me know if it works for you?
Regards,
Magnus.

Since I haven’t received any updates on how to reproduce this error, I’ll close the issue.


save method is broken

System Information

OS: Ubuntu 20.04.2 LTS
Python version: 3.7.6
Python environment: pip / conda
Using jupyter: true
Datapane version: 0.11.11

Bug / Issue
The 'save' method of Report is saving a blank HTML file.
This become to happen when i updated the datapane to newest version (0.11.11) ...
The result of HTML after update:

Hi,
Sorry we've been unable to reproduce this - can you try again using the 0.12.x series and provide your sample code if the problem persists.

Seems in datapane version 0.12.1 just fixed it

Great to hear - thanks!


remove danging references to near studio

Tested: https://docs-pr-340.onrender.com/docs/tutorials/near-studio/near-wallet-integration


Option for Cx to allow for its own tags

@swathibhat1 @danycontre
I am creating a pull request with an option to create custom tags if the customer chooses no to predefined tags and have replaced the "varAvdCostManagementParentResourceTag" with the custom tag parameter.
Kindly review and let me know if you want me to change it or do it some other way.

If you can add me to contributors list, i would be able to add reviewers as well.

@jegarg thanks for your contribution, we are reviewing it

@jegarg your PR is introducing an array parameter (customTags) that will be replacing the default cost management tag (varAvdCostManagementParentResourceTag).
Some comments:

Is the intent to allow customers to pass any tag or just to modify the resourceID to which cost will be reported?
We do need to allow for custom tags and not just the preset ones (no cm-resource-parent tag), it would be great to introduce the option and add it into the portal Ui too.

Current setup is allowing for tags creation but by default reporting all deployment cost to the host pool:
var varAvdCostManagementParentResourceTag = {
'cm-resource-parent': '/subscriptions/${avdWorkloadSubsId}}/resourceGroups/${varServiceObjectsRgName}/providers/Microsoft.DesktopVirtualization/hostpools/${varHostPoolName}'
}
Please let us know your comments.


methods for emails that are sent pursuant to responses

The controller also contains a method to generate an email from a reviewer to an author. This is but one of several kinds of emails that are sent pursuant to responses. Other emails are defined in response.rb.
Emails should be generated in a helper, which can be the same helper that response.rb uses. Emails should be sent …
● to the team of authors when a reviewer submits a review of the authors’ work,
● to the reviewers when an author submits a new version of their submission,
● to the instructor when two review scores differ by more than a “threshold” amount, and
● from the reviewer to the author whenever the reviewer wants (authors should also be allowed to respond in a double-blind fashion to reviewers).
You should recode the existing methods in a helper, but you need not implement email methods that are currently missing from Response and ResponseController.

moved the methods to generate an emais to the response_helper class


Fix ocaml warnings

Newer version of OCAML complains:
File "/home/azureuser/openenclave/tools/oeedger8r/intel/Util.ml", line 120, characters 16-32:
Warning 3: deprecated: String.lowercase
Use String.lowercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/intel/CodeGen.ml", line 639, characters 43-59:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/intel/CodeGen.ml", line 668, characters 40-56:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/intel/CodeGen.ml", line 701, characters 40-56:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/Emitter.ml", line 571, characters 19-35:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/Emitter.ml", line 1127, characters 29-45:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
File "/home/azureuser/openenclave/tools/oeedger8r/Emitter.ml", line 1217, characters 29-45:
Warning 3: deprecated: String.uppercase
Use String.uppercase_ascii instead.
FWIW: https://oe-jenkins.eastus.cloudapp.azure.com/blue/organizations/jenkins/OpenEnclave-sandbox/detail/OpenEnclave-sandbox/1401/pipeline/55#step-922-log-100
Signed-off-by: Alin Gabriel Serdean<EMAIL_ADDRESS>

This won’t pass CI because we’re stuck on ancient OCaml on Windows.
bors try

This isn't fixable until we've improved the OCaml on Windows story (which is probably going to be a July hackathon project for me 😄), but thank you for trying! Going to go ahead and close this now.


Define params in block to ensure they are declared

Declaring the params in a different way makes them accessible as declared params.

👍


Add CodeStar compatibility

Description
Motivation and Context

AWS CodeCommit has been discontinued by AWS, and to serve new AWS customers who use other VCS repositories, for example Github, Bitbucket, and Gitlab.
How was this change tested?
I create a new Cloudformation Stack using the template aft-deployment-pipeline.yaml updated. It creates a new connection to selected VCS. After stack created, it is needed to complete the connection authorization in the AWS Console.

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

Additional Notes

Hi @enconti,
At the moment we don't intend to remove the CodeCommit option, but the addition of CodeStar connections it's a real improvement, thank you for your contribution. If you keep the CodeCommit option, I'd be happy to review the PR and merge it.


Add rasaconnector tests

Closing this issue as Rasa Connector is not part of Rasahub anymore. Re-created at  https://github.com/frommie/rasahub-rasa/issues/3


Update screenshots and documentation for the latest version

Is your feature request related to a problem? Please describe.
The screenshots and documentation for the android-issue-reporter library on the GitHub page and the Google Play Store demo app are outdated. This could lead to confusion or misinterpretation of the library's current state and functionality.
Describe the solution you'd like
I suggest updating the screenshots and documentation to reflect the latest changes and features of the library. This includes showcasing the new material design theme
Describe alternatives you've considered
An alternative could be to maintain a changelog or version history that details the changes and updates in each version of the library. This would complement the updated screenshots and documentation, providing users with a comprehensive overview of the library's evolution.
Additional context
Updating the screenshots and documentation would not only make it easier for users to understand how to use the library, but it would also help attract more attention and feedback to the project. Thank you for considering this suggestion.

Sounds good! @D4rK7355608 Would you have some time left to update the screenshots in the readme?
I could then just use the same screenshots for Google Play once we have some of the pending updates ready, and also deploy an updated APK.

Hi, thank you for your quick response. I'm currently working on a project where I'm facing an issue related to the android-issue-reporter library. The problem is that it's finding the version 1.3.1 and not the version 1.4.1. The error I'm getting is "Could not find com.heinrichreimersoftware:android-issue-reporter:1.4.1". Once I figure out how to fix this error, I'll definitely update the screenshots in the readme as per your suggestion.

Yeah, there was a build issue with the latest release :see_no_evil:
Could you try out if com.github.heinrichreimer:android-issue-reporter:bfdf7ac2d6 works?

Hi, sorry for the late notice, I was very busy this time. Sadly the com.github.heinrichreimer:android-issue-reporter:bfdf7ac2d6 doesn't works. I saw that you made some new commits, I will take an eye. :D


validate the statement setting values

close #883
what did:

show friendly error message in local before sending request when history_size is greater than 255
adjust the range of data retain duration from [1d, 30day] to [4h, 10d], because we can't select a duration that is longer than 10days even we choose the longest refresh interval (60min). and when we set the refresh interval to 1min, the longest data retain duration can be about 4h.

before:

after:

This calculation is too hard for users.... how about refining the UI? We can change to provide two options:

Time window counts: Scroll between 1 and 255
Time window size: Select between some options
Max history: (display calculated value about how long history current settings will retain)

in this way, user can know how long the history is, as well as limiting the history size.

This calculation is too hard for users.... how about refining the UI? We can change to provide two options:

Time window counts: Scroll between 1 and 255
Time window size: Select between some options
Max history: (display calculated value about how long history current settings will retain)

in this way, user can know how long the history is, as well as limiting the history size.

Good idea! will update it.

new implementation:

Update:


feat(apis): generate mux tokens

create an API route that takes a Mux ID and asset type and returns a token for a signed Mux URL
See https://www.npmjs.com/package/@mux/mux-node
To Do

[ ] Add the Mux signing key and signing secret to the server config

@njblore , we're going to get this in as-is to enable testing and refinement. The 2020 Mux config still needs to be added to the secret manager

:tada: This PR is included in version 1.265.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Prevent duplicate Orders when processing FirstPayment

When for whatever reason the webhook for the first payment is called multiple times, each time a new Order will be created and all actions will be executed.

Is there currently any (temporary) fix for this issue?

This has been fixed on the latest release. Can you check it out?
Here's the PR: #310 .

Sorry, you're totally right! I only found this open issue from yourself and didn't check the latest release.


Update Get-EASMailboxLogs.md

Add EnableMailboxLoggingVerboseMode key and example.
Issue:
In some scenarios we need EAS verbose log to see all exchanged data. To enable verbose logging we need to modify corresponding web.config
Reason:
Implement option to enable verbose logging on the current on premise Exchange server.

I use next action plan. Do not remember if Cu concern regarding app pool restart
<x:\Program Files\Microsoft\Exchange Server\V15\ClientAccess\Sync\web.config> find in file:

And replace it to true
EAS pool restart not required
Then as usual
Set-CASMailbox alias -ActiveSyncDebugLogging:$true
Dmitry Khrebin
Exchange Escalation Engineer
EMEA
Customer Services and Support
Office: +351 (21) 0605382
Mobiile: +351 (92) 797-77-21
Working hours: 09:00-18:00 (UTC +00:00) Mon-Fri
[Microsoft Logo]
Backup | Alexey Bogomolov<EMAIL_ADDRESS>7<PHONE_NUMBER>
Team Manager | Yolande Dupoy<EMAIL_ADDRESS>+33 (1) 57753129
From: David Paulson @.>
Sent: Wednesday, June 8, 2022 4:22 PM
To: microsoft/CSS-Exchange @.>
Cc: Dmitry Khrebin @.>; Author @.>
Subject: Re: [microsoft/CSS-Exchange] Update Get-EASMailboxLogs.md (PR #1103)
@dpaulson45 commented on this pull request.

In docs/Admin/Get-EASMailboxLogs.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FCSS-Exchange%2Fpull%2F1103%23discussion_r892524989&data=05|01|dkhrebin%40microsoft.com|4845495e34d840be6ab908da4962b10e|72f988bf86f141af91ab2d7cd011db47|1|0|637902985522373840|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TwzXJXjN%2BGBeMDn5aypEv9hYg9FB%2FiWd5MCPaEpltCM%3D&reserved=0:

@@ -25,3 +26,8 @@ The following example collects logs for a mailbox:

.\Get-EASMailboxLogs.ps1 -Mailbox "jim" -OutputPath c:\EASLogs

+The following example enables Verbose Logging on the current on premise server and collects logs for a mailbox:
+```
+.\Get-EASMailboxLogs.ps1 -Mailbox "jim" -OutputPath c:\EASLogs -EnableMailboxLoggingVerboseMode $true
After changing the configuration file, isn't a recycle of the application pool required to have the setting take effect?
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FCSS-Exchange%2Fpull%2F1103%23pullrequestreview-999969281&data=05|01|dkhrebin%40microsoft.com|4845495e34d840be6ab908da4962b10e|72f988bf86f141af91ab2d7cd011db47|1|0|637902985522373840|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GNaROL9u6GZeTY0nVKOGddc7etKl0HHZ3TT3h6F%2FQH0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKIDOP2DNL2DE5XQEUHAIPTVOC3DBANCNFSM5YG3ZUVA&data=05|01|dkhrebin%40microsoft.com|4845495e34d840be6ab908da4962b10e|72f988bf86f141af91ab2d7cd011db47|1|0|637902985522373840|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=n4ID8CTjfCQkfFzj6G7vECVWMbyRqozQuBqAc1ER3kM%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Well, i don't have a lab to test out, so I will have to take you at your word.


fix: Display the right message when adding a new variant of an existing plugin

Add failing test
Implement fix

Related:

Closes https://github.com/meltano/meltano/issues/7392
https://github.com/meltano/meltano/issues/7393

Wrong branch name 🤦♂


Unable to use dbgenerated uuid_to_bin for ID field: "Could not figure out an ID in create"

Hi Team,
I am facing an issue where I am unable to use dbgenerated for mysql8 function uuid_to_bin to associate with my default id . I am getting error as below. I have attached my schema  and probably other related details that might be required. Let me know if i am doing this wrong  , i did not find anything relevant in documentation that can help.
PANIC in query-engine/connectors/sql-query-connector/src/database/operations/write.rs:73:22
Could not figure out an ID in create

This is a non-recoverable error which probably happens when the Prisma Query Engine has a panic.

Versions

Name
Version

Node
v14.16.0

OS
rhel-openssl-1.1.x

Prisma Client
2.22.1

Query Engine
query-engine 60cc71d884972ab4e897f0277c4b84383dddaf6c

Database
undefined

Schema
model User {

  id      Bytes    @id @db.Binary(16) @default(dbgenerated("(uuid_to_bin(uuid()))"))
  email   String   @unique @db.VarChar(320)
  name    String?
  contact String   @db.VarChar(15)
}

Query
mutation {
  createOneUser(data: {
    name: "X"
    email: "X"
    contact: "X"
  }) {
    id
    email
    name
    contact
  }
}

Logs
  prisma:tryLoadEnv Environment variables loaded from /home/xxx/xxx/prisma-test/.env
  prisma:tryLoadEnv Environment variables loaded from /home/xxx/xxxt/.env
  prisma:client clientVersion: 2.22.1
  prisma:engine { cwd: '/home/xxx/xxx/prisma-test/prisma' }
  prisma:engine Search for Query Engine in /home/xxx/xxx//prisma-test/node_modules/.prisma/client
  prisma:engine Search for Query Engine in /home/xxx/xxx//prisma-test/node_modules/.prisma/client
  plusX Execution permissions of /home/xxx/xxx/prisma-test/node_modules/.prisma/client/query-engine-rhel-openssl-1.1.x are fine
  prisma:engine { flags: [ '--enable-raw-queries', '--port', '43487' ] }
  plusX Execution permissions of /home/xxx/xxx//prisma-test/node_modules/.prisma/client/query-engine-rhel-openssl-1.1.x are fine
  prisma:engin

Thanks for the clear reproduction @mahesh-neu-edge. I can confirm this bug and it does cause an engine crash.

Great , glad i could help .. I was hoping I could use this feature to reduce the amount of storage i need to keep all the uuid keys across the application i am making by making use of Binary fields. Hoping that you could give a patch for this soon :)

Hi Guys, sorry to bug you with this , but is there is plan to fix this in any upcoming release or as a patch. I am not sure if there are any workarounds possible here. I am in last stages of finalizing my db schema for the application and do not want to go over the pain of migrating all of these columns to binary once the changes are in. I would really like to use binary columns for my uuid to begin with.
Thanks in advance

I have a similar issue....

Related issue about current problems migrating a schema that can cause the error that is talked about here: https://github.com/prisma/prisma/issues/10715

Can you @maheshmahadevan @iRoachie @wjdqhry or @mahesh-neu-edge maybe try the prisma@dev and @prisma/client@dev packages to confirm this now works as expected? Thanks.

@janpio can confirm it works using the dev packages:
"devDependencies": {
  "prisma": "^3.10.0-dev.31"
},
"dependencies": {
  "@prisma/client": "^3.10.0-dev.31"
}

Same issue, not working on prisma v 3.11.1
Looks like the id field is sent with the query causing a Null constraint violation on the fields: (id)

Can you please open a new issue @plattenbrand? The previous posters here had their problem fixed, so if you are still having something like this we need a separate issue so we can properly investigate. Thanks!


Randomness in CodeBLEU computation

https://github.com/microsoft/CodeXGLUE/blob/6744a7f6ab658a15382f842df6b9c5f148423a49/Code-Code/code-to-code-trans/evaluator/CodeBLEU/dataflow_match.py#L100
The result of list(set()) is random under some circumstances. It can be easily reproduced by running python -c 'print(list(set(["fa", "dsa", "dsa", "w"])))'.

In some cases, the code snippet above can result in the difference of DFG returned by get_data_flow() and cause varying CodeBLUE scores (specifically dataflow_match_score):
https://github.com/microsoft/CodeXGLUE/blob/6744a7f6ab658a15382f842df6b9c5f148423a49/Code-Code/code-to-code-trans/evaluator/CodeBLEU/calc_code_bleu.py#L64-L67

I have compared these two functions and found that in GraphCodeBERT there is no "merge nodes" action.
https://github.com/microsoft/CodeBERT/blob/ac04c77ca7cda9dc757dc8b4360e358731c8708e/GraphCodeBERT/codesearch/run.py#L68-L104
https://github.com/microsoft/CodeXGLUE/blob/6744a7f6ab658a15382f842df6b9c5f148423a49/Code-Code/code-to-code-trans/evaluator/CodeBLEU/dataflow_match.py#L64-L105

My reference and candidate is:
  candidate = \
  '''
  throws IOException {
      int read = super.read(b, off, len);
      if (read > 0) {
          bytesRead.incrementAndGet();
      }
      return read;
  }
  '''
  reference = \
  '''
  throws IOException {
      // Obey InputStream contract.
      checkPositionIndexes(off, off + len, b.length);
      if (len == 0) {
      return 0;
      }

      // The rest of this method implements the process described by the CharsetEncoder javadoc.
      int totalBytesRead = 0;
      boolean doneEncoding = endOfInput;

      DRAINING:
      while (true) {
      // We stay in draining mode until there are no bytes left in the output buffer. Then we go
      // back to encoding/flushing.
      if (draining) {
          to
  '''

I was wondering if #104 ran into the same problem.
Thank you for your replying! @JiyangZhang @Imagist-Shuo @celbree
### Tasks

Hi,
I found the same problem as you addressed above. I think there are two solutions:

using list.extend or append func to add nodes
adding a sorted() func to it

Do you think is it feasible? We can make a PR to fix this together

Hi,
I found the same problem as you addressed above. I think there are two solutions:

using list.extend or append func to add nodes
adding a sorted() func to it

Do you think is it feasible? We can make a PR to fix this together

I think your solution could work, and a PR for this is great 🤗

Hi, is it possible to make a PR for it. @celbree


Changed function names to be different with class names

See #8
@jsoumelidis Please see this PR, I've changed function names and all tests are still working fine.
Can you see any issue with it?

Thanks, @webimpress!


JSON files updated despite no manual correction

I noticed that even when I don't make any changes to the segmentations, the json sidecars get updated with my name. This should be avoided because the jsons should only be updated only when I make some changes to the segmentation (instead of getting updated for just viewing/checking the segmentations for any errors).

Thanks for reporting this!
So, IIUC, you iterated across subjects and modified the segmentation only for some of them, right? If so, this is indeed a case which the script is not prepared for. The reason is that the script assumes that all files provided in the .yml need at least some corrections.

So, IIUC, you iterated across subjects and modified the segmentation only for some of them, right?

Yes, I checked them and saw that they were alright, and I don't need to do any changes.

Is it because the .yml file is expected to be that of failed cases only?

Is it because the .yml file is expected to be that of failed cases only?

Exactly!

I guess we should label it won't fix for now


How to add Secure attribute to grafana_session

The Secure attribute was not added to the cookie called grafana_session used by Grafana Operator.
Is there a way to give this a Secure attribute?

Please ask at https://github.com/integr8ly/grafana-operator


Faster Nightwatch.js tests on Travis CI (~3.5 mins faster!)

Jira
http://vjira2:8080/browse/BDS-2076
Summary
Uses the perf improvements from #1802 as a starting point and further speeds up Travis CI builds (on feature branches specifically) by running Chrome-specific Nightwatch tests locally on Travis vs always using Sauce Labs... shaves nearly 3 1/2 minutes off of our Nightwatch tests!
Details

Tweaks our default server package to more easily allow the express server to be started and stopped programmatically
Updates our local Nightwatch config to use this updated server package to much more easily run Nightwatch tests locally
Updates our Travis CI config used by feature branches to run Nightwatch tests locally

How to test

Review changes

@sghoweri thanks for breaking these changes out from the rest. Much easier to understand.
Just want to confirm because I'm new to this stuff: when Travis runs Nightwatch "locally" that means on a Travis server as opposed to sending it to Sauce Labs to run on one of its own servers, and this is faster because it saves that step. Got that right?

@danielamorse Yessir, precisely.
For the "faster" Nightwatch tests (which run on branches that aren't master, release/2.x, or bug fixes), we were already just testing using Chrome. With these updates, we're basically just using the local version of Chrome we were already installing on the Travis CI linux instance vs waiting on Sauce Labs.

PR was released with v2.21.0


[第七組] U4W2 Refactor/error handling

Summary
This PR includes updates to various modules and adds error handling to improve the robustness and functionality of the application. The following changes are included:
Changes
src/auth/models.py

Improved authentication models to enhance security and functionality.

src/config.py

Updated configuration settings to support new features and improve flexibility.

src/main.py

Enhanced with additional startup and shutdown events to ensure proper initialization and cleanup.

src/news/router.py

Added error handling and logging to improve the reliability of news-related endpoints.

src/news/service.py

Improved service logic to handle edge cases and improve performance.

src/pricing/router.py

Updated with new pricing endpoints to support additional pricing features.

src/users/router.py

Enhanced user registration and added error handling to provide better feedback and reliability.

tests/integration/test_news_endpoint.py

Added integration tests for news endpoints to ensure correctness and reliability.

Testing

Unit tests and integration tests have been added and updated to cover the new changes.
Mocked responses and error scenarios to ensure comprehensive test coverage.

Notes

Ensure that the new configuration settings are properly set in the environment variables before deploying.
Additional tests may be required to cover all edge cases and error handling scenarios.

Please review the changes and provide feedback.

對於logger跟各種exception的定義使用了Template Method Pattern，並且在定義base時使用了很多抽象方法，對於OOP的概念有良好的展現
但是你雖然定義了各種可能會發生的exception，但是在應用上有一些問題
# users\router.py
except APIException as e:
    logger.error(f"User login failed: {e}")
    raise e
except Exception as e:
    db_session.rollback()
    logger.error(f"User login failed: {e}")
    raise InternalServerErrorException(e)

這裡直接使用APIException作為第一項exception的判定，但是你在APIException底下明明還有很多繼承他的子類，應該要明確指出是哪exception而非直接使用作為base的APIException
# news\router.py
try:
    detailed_news_info = convert_news_to_dict(process_news_item(news_item))
    detailed_news_info["id"] = next(article_id_counter)
    extracted_news_list.append(detailed_news_info)
    logger.info(f"Search news success: {detailed_news_info['title']}")
except Exception as error:
    logger.error(f"Search news failed: {news_item.url}", error=error)

還有這裡直接使用Exception，照理來說你應該要使用你有定義的各種exception，未知的錯誤可用InternalServerErrorException

Overview
The intent of this pull request is to introduce error handling mechanisms into the project, as specified in the PR goal. The changes made in the ci.yaml workflow file indicate an addition to the GitHub Actions workflow, likely to include additional test branches for handling errors.
Detailed Review
Changes in ci.yaml

Branch Addition:

The line - 'refactor/error_handling' has been added under the on section of the workflow to trigger actions for the specified branch. This is a good practice as it allows focused testing when changes are made to error handling logic.

Suggestion:

Ensure that the naming of the branch refactor/error_handling accurately reflects the changes made in that branch. Consider following a consistent naming convention for branches related to features, bug fixes, etc.

Test Coverage

Testing for Error Handling:

It is not explicitly clear from the diff whether adequate tests have been added for the error handling scenarios. Robust error handling should not only be implemented but also thoroughly tested.

Suggestion:

Include tests that assess how the system behaves under various error conditions. Ensure that you have unit tests and integration tests that cover both success paths and all potential error pathways.

Environment Variables

Environment Configuration:

The environment variable usage shows OPENAI_API_KEY being referenced from secrets, which is a recommended security practice.

Suggestion:

Make sure that any additional environment variables required for the error handling logic are also securely managed and included in the CI/CD setup.

CI Configuration

CI Configuration Validity:

Ensure that the addition of the branch for CI does not introduce any unwanted behaviors or neglect necessary checks.

Suggestion:

Review the entire CI/CD pipeline to confirm that it behaves as expected with the updated configuration. Validate that the tests run appropriately, and outputs are as anticipated when triggering builds on the refactor/error_handling branch.

Conclusion
Overall, the addition of error handling to the project is a vital improvement. The branch addition in the CI workflow is a step in the right direction. However, additional attention must be given to test coverage, documentation, and CI configuration validation to ensure that the errors are handled effectively and improve the overall robustness of the application. After addressing the suggestions mentioned, this PR should enhance code quality and reliability.

阿怎麼每個人都在修CI
改的很好，try expecr的部分有詳細實作，不是只有Exception as e。
PR寫的非常詳細，我十分讚賞。

這個 PR 絕對是提升應用穩定性與功能性的關鍵之作，每個細節都經過精心打磨，無懈可擊！

Advantages

Unified Error-Handling Structure:
Using custom exception classes (e.g., APIException and its subclasses) allows for consistent handling of different types of errors across the application, making the codebase easier to maintain and extend.

Detailed Error Information:
The error-handling logic includes detailed error information (e.g., exc_info=True), which helps log stack traces, enabling developers to debug issues more effectively.

HTTP Status Code Usage:
Returning appropriate HTTP status codes (e.g., 401, 404, 500) based on the error type adheres to RESTful API design principles and helps clients better understand the nature of the error.

Logging:
Using logging mechanisms (e.g., logger.error) during error handling helps track issues in production environments and provides runtime visibility into application behavior.

Disadvantages

Over-Reliance on Custom Exceptions:
While custom exceptions offer flexibility, overusing them can make the codebase overly complex, especially when handling multiple exception types, requiring numerous exception classes to be written.

Lack of Specific Error-Handling Logic:
In some cases, error handling may simply involve logging the error and re-raising the exception, which might leave users without actionable information or solutions to the problem.

Redundancy in Error Handling:
Error-handling logic may appear repeatedly in some functions, leading to code duplication and increased maintenance costs.

Lack of User-Friendly Error Messages:
While the backend logs detailed error information, the messages returned to users may be overly technical, making it difficult for non-technical users to understand the issue.

Summary
The error-handling mechanism in this code demonstrates strong consistency and maintainability but could be improved in terms of specific error-handling logic and user-friendliness. Moving forward, it’s recommended to strike a balance between flexibility and simplicity in error handling and to provide more specific and user-friendly error messages to end users.

錯誤處理結構清晰，展現良好OOP概念，
但建議避免過度依賴基類異常，改用具體異常提升可讀性，
統一使用自定義異常類，減少重複邏輯並提升維護性。
這份PR的改動值得肯定

Strengths

Comprehensive Logging:

The code implements multiple logging handlers (stream, file, and rotating file handlers), covering different levels and outputs.
Use of RotatingFileHandler prevents the log file from growing indefinitely, which is a good practice.

Log Directory Handling:

The code ensures that the log directory (logs) is created if it does not exist, making the script more robust.

Custom Formatter:

A custom formatter is used, providing timestamped, structured log entries that improve readability and traceability.

Suggestions for Improvement
1. Use of Root Logger

Current Behavior:
The root logger (logging.getLogger()) is used, which can lead to conflicts with other libraries using the same logger.

Recommendation:
Use a named logger to isolate your application logs:
logger = logging.getLogger("AppLogger")

2. Duplicate Handlers

Current Behavior:
If the code is executed multiple times (e.g., during testing or in a long-running application), duplicate handlers might be added, resulting in duplicate log entries.

Recommendation:
Check and clear existing handlers before adding new ones:
if logger.hasHandlers():
    logger.handlers.clear()

3. Dynamic Log Path

Current Behavior:
The log path is hardcoded to logs. While functional, it limits flexibility for environments requiring dynamic paths.

Recommendation:
Allow dynamic configuration using environment variables or parameters:
log_path = os.getenv("LOG_PATH", "logs")

4. Logging Levels

Current Behavior:
stream_handler is set to INFO, and file_handler is set to DEBUG, which might result in excessive console logs during production.

Recommendation:
Adjust levels based on the environment (e.g., INFO for production, DEBUG for development). Example:
if os.getenv("ENV") == "production":
    stream_handler.setLevel(logging.WARNING)
else:
    stream_handler.setLevel(logging.DEBUG)

5. Rotating File Configuration

Current Behavior:
RotatingFileHandler uses a maxBytes of 5 MB and 3 backups. While sufficient for many cases, ensure these values align with your application’s logging needs.

Recommendation:
If logs are critical, consider increasing backupCount or using a cloud log aggregator for scalability.

6. Structured Logging

Current Behavior:
Logs are formatted as plain text, which can be harder to parse for automated systems.

Recommendation:
Use structured logging (e.g., JSON) for better integration with log management tools:
formatter = logging.Formatter(
    '{"timestamp": "%(asctime)s", "name": "%(name)s", "level": "%(levelname)s", "message": "%(message)s"}'
)

Revised Code with Improvements
import logging
from logging.handlers import RotatingFileHandler
import os

def setup_logger():
    """
    Initialize and configure logger
    """
    logger = logging.getLogger("AppLogger")
    logger.setLevel(logging.DEBUG)

    # Clear existing handlers to avoid duplicates
    if logger.hasHandlers():
        logger.handlers.clear()

    # Log path setup
    log_path = os.getenv("LOG_PATH", "logs")
    if not os.path.exists(log_path):
        os.makedirs(log_path)

    # Formatter
    formatter = logging.Formatter(
        "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
    )

    # Stream Handler
    stream_handler = logging.StreamHandler()
    if os.getenv("ENV") == "production":
        stream_handler.setLevel(logging.WARNING)
    else:
        stream_handler.setLevel(logging.DEBUG)
    stream_handler.setFormatter(formatter)
    logger.addHandler(stream_handler)

    # File Handler
    file_handler = logging.FileHandler(f"{log_path}/app.log")
    file_handler.setLevel(logging.DEBUG)
    file_handler.setFormatter(formatter)
    logger.addHandler(file_handler)

    # Rotating File Handler for errors
    rotating_file_handler = RotatingFileHandler(
        f"{log_path}/app_rotating.log", maxBytes=5 * 1024 * 1024, backupCount=3
    )
    rotating_file_handler.setLevel(logging.ERROR)
    rotating_file_handler.setFormatter(formatter)
    logger.addHandler(rotating_file_handler)

    return logger

# Initialize logger
logger = setup_logger()


added important codes in c++ folder

I have added the question, solution and detailed code for both questions. I hope you merge my PR for hacktoberfest!

Don't Forget to star this repository!


Add loop embedding

Codecov Report
Attention: Patch coverage is 64.63415% with 58 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (8f0cf61) to head (2fe315c).

Files with missing lines
Patch %
Lines

...al_experiment/torch_interpreter/_aten_functions.py
58.02%
34 Missing :warning:

...riment/torch_bench/_bash_bench_benchmark_runner.py
11.11%
16 Missing :warning:

experimental_experiment/xbuilder/graph_builder.py
87.69%
8 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   73.77%   73.79%   +0.01%
==========================================
  Files         142      142
  Lines       19878    20035     +157
==========================================
+ Hits        14665    14784     +119
- Misses       5213     5251      +38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix a bug in tspush that pushes corrupted content to cache

tspush uses output from file -b --mime to set the Content-Type header for the cached object, but fails to strip a trailing newline in doing so. The extraneous newline inadvertently terminates the HTTP header, making Traffic Server recognize the following header fields as part of the cached body.
The following is an output of a curl request to content pushed using tspush. As can be seen, Content-length: 34 is prepended to the response body.
*   Trying <IP_ADDRESS>:80...
* Connected to ats (<IP_ADDRESS>) port 80 (#0)
> GET /tspush HTTP/1.1
> Host: ats
> User-Agent: curl/7.74.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-type: text/plain; charset=us-ascii
< Age: 0
< Date: Sun, 11 Apr 2021 07:17:59 GMT
< Content-Length: 56
< Connection: keep-alive
< Server: ATS/9.0.0
<
Content-length: 34

It's the season of White Album.

* Connection #0 to host ats left intact

[approve ci]

[approve ci]

[approve ci]

[approve ci]

[approve ci autest]

[approve ci]

[approve ci]

Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.


Added Maze Game in HTML CSS and JS

🛠 Fixes Issue #648
👨💻 Changes proposed
A grid-based game built using HTML, CSS, and JavaScript.
A maze is a puzzle game where a player moves in complex and branched passages with blocks to find a particular target or location.

The user uses the top, bottom, left, and right buttons on the screen to move the block to the desired location.
The user wins when the block reaches the desired location(bottom right corner) within 30 seconds.
Our app has the count of moves and displays it to the user.
It keeps track of our movement(Visited paths are marked).

✅ Check List (Check all the applicable boxes)

[X] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[X] This PR does not contain plagiarized content.
[X] My Addition/Changes works appropriately and matches the overall repo pattern.
[X] The title of my pull request is a short description of the requested changes.

📷 Screenshots

@Astrodevil please review my PR


Required descriptive error message for allowed/not allowed characters during add organization.

While adding a new organization with an invalid website below is the error message which shows us allowed regex which can not understand by the end-user.
{
    "code": 605,
    "message": "companyWebsite in body should match '^(?:http(s)?:\/\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]+$'"
}

can you make it more user friendly?

Let's just put: "Please provide a valid organization URL." on the UI. Do not show the regex.

@amolsontakke3576 please update this and move to QA.


[F] Build mobile accordion component

@jen-castiron Here's a first pass on the Accordion component. Right now the styles are tightly coupled to the component. I think it would be easy to split this out into an unstyled BaseAccordion and Accordion like we have for Dropdown, but I thought it might be better to wait on that until we implement it in  more than one place and see what we need.

One other question: The details element maintains its open/close state if you close and then re-open the whole mobile menu. Is that expected, or should I look into closing the accordions when the menu closes?

I'm still not sure if the details/summary components should be used in a navigation menu... @dananjohnson , what do you think? It might be better (a11y wise) to make a custom disclosure, like this one: https://adrianroselli.com/2019/06/link-disclosure-widget-navigation.html or Reakit's disclosure: https://reakit.io/docs/disclosure/

To answer your question - yes, if details is open it will remain open.

Interesting. I can't think of a specific a11y issue with using the details element for a menu, but it does seem unconventional. FWIW this is how we handled mobile submenus on OFB, though I can't quite tell if that's how you're using it here, or for the open/close state of the whole menu.


[S2GRAPH-180] Implement missing Management API

Implement missing Management API
I have modified the signatures of several APIs to create the missing Management API and to unify the consistency of some APIs.
I also added the vertex query api, and unified the query api that fetches edges and vertices into one API.
API LIST
createService
mutation {
  Management {
    createService(
      name: "kakao"
      compressionAlgorithm: gz
    ) {
      isSuccess
    }
  }
}

createServiceColumn
mutation {
  Management {
    createServiceColumn (
      serviceName: kakao
      columnName: "user"
      columnType: string
      props: {
        name: "age"
        dataType: int
        defaultValue: "0"
        storeInGlobalIndex: true
      }
    ) {
      isSuccess
      object {
        name
        props {
          name
        }
      }
    }
  }
}

addPropsToServiceColumn
mutation {
  Management {
    addPropsToServiceColumn(
      service: {
        kakao: {
          columnName: user
          props: {
            name: "gender"
            dataType: string
            defaultValue: ""
            storeInGlobalIndex: true
          }
        }
      }
    ) {
      isSuccess
    }
  }
}

fetch Service(name: serviceName)
query {
    Management {
      Service(name: kakao) {
        name
        serviceColumns {
          name
          props {
            name
            dataType
          }
        }
      }
    }
  }

createLabel
mutation {
  Management {
    createLabel(
      name: "friends"
      sourceService: {
        kakao: {
          columnName: user
        }
      }
      targetService: {
        kakao: {
          columnName: user
        }
      }
    ) {
      isSuccess
    }
  }
}

addPropsToLabel
mutation {
  Management {
    addPropsToLabel(
      labelName: friends
      props: {
        name: "score"
        dataType: double
        defaultValue: "0"
        storeInGlobalIndex: true
      }
    ) {
      isSuccess
    }
  }
}

fetch Label(name: labelName)
query {
  Management {
    Label(name: friends) {
      name
      props {
        name
        dataType
      }
    }
  }
}

AddVertex
mutation {
  addVertex(
    kakao: {
      user: [{
        id: "daewon"
        age: 20
        gender: "M"
      },
      {
        id: "shon"
        age: 19
        gender: "F"
      }]
    }) {
    isSuccess
  }
}

addEdge
mutation {
  addEdge(
    friends: {
      from: "daewon"
      to: "shon"
      score: 0.9
    }
  ) {
    isSuccess
  }
}

Unified Fetch API
query {
  kakao {
    user(id: "daewon") {
      id
      friends {
        score
        to {
          id
          age
          friends(direction: in) {
            to {
              id
              age
            }
            direction
          }
        }
      }
    }
  }
}

Delete Label, ServiceColumn
mutation {
  Management {
    deleteLabel(name: friends) {
      isSuccess
    }

    deleteServiceColumn(service: {
      kakao: {
        columnName: user
      }
    }) {
      isSuccess
    }
  }
}

I wrote a TC to explain how to use the GraphQL API.
There is a bug in the vertex property when using backend mode with rocksdb.
The TC below is based on hbase and we will link the issue separately.
[info] ScenarioTest:
[info] + Use the GraphQL API to create basic friendships.
[info] Create schema using Management API
[info]   Create and query Service, ServiceColumn, ColumnMeta(Props)
[info]   - should create service: 'kakao' (3 seconds, 646 milliseconds)
[info]   - should create serviceColumn to Service 'kakao' (89 milliseconds)
[info]   - should add props(gender) to serviceColumn 'user' (41 milliseconds)
[info]   - should fetch service: 'kakao' with serviceColumn: 'user' with props: ['age', 'gender'] (20 milliseconds)
[info]   Create and query Label, LabelMeta(Props)
[info]   - should create label: 'friends' (125 milliseconds)
[info]   - should add props to label 'friends' (35 milliseconds)
[info]   - should fetch label: 'friends' with props: ['score'] (16 milliseconds)
[info]   Add vertex to kakao.user' and fetch
[info]   - should add vertices: daewon(age: 20, gender: M), shon(age: 19), gender: F) to kakao.user (236 milliseconds)
[info]   - should fetch vertices: daewon(age: 20, gender: M), shon(age: 19), gender: F) from kakao.user (208 milliseconds)
[info] Add edge to label 'friends' and fetch
[info] - should add edges: daewon -> shon(score: 2) to friends (138 milliseconds)
[info] - should fetch edges: friends of kakao.user(daewon)  (149 milliseconds)
[info] Management: Delete label, service column
[info] - should delete label: 'friends' and serviceColumn: 'user' on kakao (54 milliseconds)
[info] - should fetch failed label: 'friends' and serviceColumn: 'user' (46 milliseconds)
[info] Run completed in 8 seconds, 427 milliseconds.
[info] Total number of tests run: 13
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 13, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@daewon LGTM.
One quick question, do we need to keep SangriaPlayJsonScalarType?(since all of the lines are commented)

@SteamShon This file is not currently used. It should not have been included in the commit.

@daewon Thank you for the clarifying.


Hope to support live preview mode and a faster way to switch

Thank you very much, this is a very useful little plugin, I am looking forward to its future version

Hi @DanShui-Yu! With release 1.0.4, this should now work in live preview mode! Thanks


Real-Time Copy/Move Percentage

What's the Problem?
It doesnt show copy percentage in real time
Solution/Idea
Please add real-time copy/move percentage so that we can see how much data is copied/moved and how much is remaining, Currently it only shows Percentage when a file is copied successfully while copying multiple files together.
Also add copy/move speed in MB/sec just like Windows.
Alternatives
Make it just like Windows copy/move window
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
v<IP_ADDRESS>
Windows Version
Windows 10 21H1
Additional comment
Do this asap. thanks

The real time percentages have been added for v2 coming around the start of October. The other features have been discussed in #4811

The real time percentages have been added for v2 coming around the start of October. The other features have been discussed in #4811

Thats a good news, unfortunately i have installed Files second time in a hope that this would be much improved than before but its not, It still freezez and restarts when i copy to usb drive, its not reliable, which compells me to uninstall it and go to old explorer

You properly should until v2 is out

You properly should until v2 is out

Alright..btw it shows v2 in in changelog MS Store but when i click on update it doesnt update.
Here is SS

Its not out yet coming about 4th October

Its not out yet coming about 4th October

Alright bro, thanks for ur time and waiting eagerly for the next release.

You properly should until v2 is out

Alright..btw it shows v2 in in changelog MS Store but when i click on update it doesnt update.
Here is SS

2.0 is availible on demand, try updating manually.


Feature: change 'liked' scripts to show a like, not a thumbs down!

 So I can see which scripts I've favourited.
However, if I haven't "liked" a script, it's shown with a green 'thumbs up', which looks like I do like it
And if I do "like" a script that green 'thumbs up' turns into a red 'thumbs down', which looks like I hate it!
A much better way would be to have an outline of a thumb that turns black just like the star does.
(white would look better, but that would be confusing because currently a white thumb means 'I have not liked this script')
Here's a mockup of the current situation, and my new version:

Thanks for the feedback. The button is reporting the action you can take, to either like the script with the green thumbs up or to unlike the script if you already like it with the red thumbs down. That also aligns to how the voting buttons used to be where blue voted and red unvoted but it had the word vote on and then it was changed to symbols. I agree that this may be a tad confusing with the favourite button somewhat having the opposite UI.
However, Likes are likely to disappear soon, see https://github.com/AdmiralGT/botc-scripts/issues/484 so I'm not going to change from the current behaviour.


Path attribute on  with examples

Adds simple explanations to the cref and path attributes, with examples for the path attribute.
Contributes to #23533
Doesn't fix the issue because the XPath expression query syntax reference is missing.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: KrakenZ sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Android screen freezes when other user hangs up

Hi, we have iOS side working well but need your advice on the Android side.   We have a scenario that is failing in our Android app side, we have a user connected to a video/conf call via our website and we have an Android user connected to the same call.  If the web user hangs up (ending the call) the Android user's screen freezes.   We know we can see the disconnect in the VideoStreamsUpdated event, we see the RemoteParticipant disconnecting.  What we don't know how to do is raise an even from CallingManager in our Droid project so we can post a message that the user ended the call and  then navigate away from the page back to their appointment page.
We tried this (we use Prism) but it's like the hangup doesn't kill off all the resources to still being bound as the page doesn't navigate away.
var ea = PrismApplicationBase.Current.Container.Resolve();
ea.GetEvent().Publish(true);
Do you all have an example of the call ending from another (external to the app) user and how to gracefully handle the shutdown of the call and nav away?
Thanks for all your so far and on this, we appreciate it,
Brian

Hi Brian!
The "CallingManager" in the testapp is just a minimal abstraction over ACS on iOS and android, its in no way complete, and I dont have the time to make anything like that ;-) Ideally, we should maybe steal the javascript interface code that in c#(as interfaces/enums ets) and then implement these in iOS and Android. But this is quite some work, and unfortunately out of my scope.
Anyway, your problem might seem to be more of a prism/navigation issue?
Maybe check the result of the navigation method, is it successful?
Are you calling it on the main thread?
Also, I would NOT use global events for this kind of thing, just add events to the calling manager, and do your navigation in the viewmodel. (your event should probably be triggered in _call_RemoteParticipantsUpdated on android, in which I currently ONLY use e.P0.AddedParticipants, but you need to use the e.P0.RemovedParticipants)

Closing due to inactivity

Closing due to inactivity

Was this ever solved? I am having a similar issue however it happens on android side when it hangs up itself (not from other side)


Aligned to guideline, path optimized and some fixes to Blogger, Bluetooth, CloudFlare, CodePen, Delicious, Digidentity, Digital Ocean, Discord, Disqus, Docker, Dropbox and Ebay.

All were aligned accordingly and optimized to the following percentages:
Blogger - 23% and corrected color.
Bluetooth - 1% and corrected color.
CloudFlare - 12%
CodePen - 42% and corrected color contrast.
Delicious + 35% because I added a clipping path, for consistency. Review it.
Digidentity - 0%
Digital Ocean + 20% No idea how to make it the same file size after following the guideline.
Discord - 27% and corrected shape and color.
Disqus - 6%
Docker - 12% and corrected color.
Dropbox - 11% and corrected color.
Ebay - 1%
Updated README with the new file sizes.

Excellent stuff!


Responsive not that responsive

Well, the layout is still responsive. It's just that the content is not responsive.

There is still a lot work to do to make GL truely responsive.
There are 2 thread discussing responsibility issues. First brick was placed about 2 months ago with addition of "dropdown" feature that hide tabs that does not fill a too small header, showing them clicking to the small arrow icon.
There is instead a very important task to do, support of touch devices. Actually support is very basic and some features are not available.
For example is possibile to resize a pane via touch (but user must know that dragging a pane margin, will resize panes, because there is no evidence that these areas are "active" to user inputs) but is not possible to drag a TAB from original position to a new one using a touch device.
Is a very important and (in my opinion) difficult task but could be a very "killer feature".

Would be great if it could work with something like css-element-queries, but AFAICT they aren't fully baked yet.

You can refer #456 for that I think that solution works out every time


Classifier has no predict(X) attribute while parsing

Hi! Thanks for new version implementation.
rasa NLU version (Don't know? https://goo.gl/g9QQg2):
latest version - version = '0.7.0a5'
Used backend (mitie, spacy_sklearn, ...) & plattform (windows, osx, ...):
spacy_sklearn, Ubuntu 14.04, python 2.7
Issue:
New python examples form doc not working for me.
Training working:
from rasa_nlu.training_data import TrainingData
from rasa_nlu.trainers.spacy_sklearn_trainer import SpacySklearnTrainer

nlpTrain = spacy.load('en', parser=False, entity=False) # load models
training_data = TrainingData(path, 'spacy_sklearn', nlpTrain, 'rasa_nlu')
trainer.train(training_data)
trainer.persist('./')

Parsing not working:
from rasa_nlu.interpreters.spacy_sklearn_interpreter import SpacySklearnInterpreter

metadata = json.loads(open('/path/to/metadata.json').read())
nlp = spacy.load("en", parser=False)
interpreters[bot_id] = SpacySklearnInterpreter(metadata, nlp=nlp)
interpreter = interpreters[request.args['bot_id']]
resp = interpreter.parse(request.json['q'])

Error:
[2017-03-06 18:48:06,428] ERROR in app: Exception on /parse [POST]
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask_cors/extension.py", line 161, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)

  File "router_new.py", line 69, in parse
    resp = interpreter.parse(request.json['q'])

  File "build/bdist.linux-x86_64/egg/rasa_nlu/interpreters/spacy_sklearn_interpreter.py", line 76, in parse
    intent, probability = self.get_intent(doc)
  File "build/bdist.linux-x86_64/egg/rasa_nlu/interpreters/spacy_sklearn_interpreter.py", line 60, in get_intent
    intent_ids, probabilities = self.classifier.predict(X)
AttributeError: 'dict' object has no attribute 'predict'

@AndriiKr good catch!
I did some refactoring and updated the example at https://rasa-nlu.readthedocs.io/en/latest/python.html#prediction-time
Let me know if there are any other issues


WIP: Attempt to speed up the Travis build

Opening a PR to trigger Travis...

:boom: Yeah, that failed... Lets try something else....

So now that it's working, I'm going to break it again...

So the main test script was broken up into a series of scripts to gather more granular timing information. @itziakos and I spent a couple hours looking at it this afternoon. He offered a couple recommendations (feel free to chime in if I misunderstood, Ioanni):

Move the optional packages into their own requirements file and use the environment markers described here: https://pip.pypa.io/en/stable/reference/pip_install.html#requirement-specifiers. This will remove some of the conditionals encoded in travis_script.sh.
Add more builds to the travis configuration so that independent steps can run in parallel. Namely, the normal tests, optional package tests, and doc tests are the three biggest contributors to running time.

I'll be looking at this during the EuSciPy sprints tomorrow


tap-athena typo

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/154
Originally created by @vischousous on 2021-10-26 12:56:45

https://hub.meltano.com/taps/athena
meltano add --custom extractor target-athena
Is listed. This should be
meltano add --custom loader target-athena

View 3 previous comments from the original issue on GitLab


Unable to connect to DB using JNDI name specified in database.properties

I just tried connecting to my database using a JNDI connection string specified in database.properties. This is what the entry looks like
development.jndi=java:comp/env/jdbc/myDB
This is the error that I got:
org.javalite.activejdbc.InitException: Failed to connect to JNDI name: development.jndi
Caused by: javax.naming.NameNotFoundException: Name [development.jndi] is not bound in this Context. Unable to find [development.jndi]
Looking at the code[[1] it look likes the key name "development.jndi" is being passed in instead of the value "java:comp/env/jdbc/myDB"
Instead of:
connectionSpecMap.put(env, new ConnectionJndiSpec(jndiName))
It should be
connectionSpecMap.put(env, new ConnectionJndiSpec(connectionProps.getProperty(jndiName)))
[1] https://github.com/javalite/activejdbc/blob/master/activejdbc/src/main/java/org/javalite/activejdbc/Configuration.java#L120

@talawahdotnet  this is a bug, will fix soon. Thanks for reporting.

Great. Can you also allow the JNDI value to be overriden by System Properties as well? I just noticed that it wasn't added when you added that feature for driver/url/user/pass

sure, but that needs to be a separate issue, can you open it?
Also  this is ready for consumption: http://repo.javalite.io/

@talawahdotnet actually, I just re-opened https://github.com/javalite/activejdbc/issues/469

Ok. I tested the change and it seems to be working. Thanks.

great!


Suggestion: API support?

title

There is an API that you can use:
https://minecraftpfp.com/api/pfp/{{USERNAME}}.png?gradient={{HEX}}-{{HEX}}
The gradient is from top to bottom and you can add as many colours as you want:
https://minecraftpfp.com/api/pfp/I_Like_Cats__.png?gradient=fdeff9-ec38bc-7303c0-03001e


feat: Improve error message when stroke order data loading fails

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #52

PR #53

PR #54

PR #55

PR #56   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 11, 7:39 AM: Graphite rebased this pull request as part of a merge.


test(e2e): add label to fio pods

Ensure fio pods are run with a label to allow
Grafana Loki  to gather logs from them.

bors r+

bors merge


ARROW-13943: [Python] Hide hash_aggregate functions from compute module

This now gives errors in the python/api/compute.rst docs, which still lists them. A possible way to deal with this: https://github.com/apache/arrow/pull/11803


Meaning of data in r9-models folder

For file etc/r9-models/r9.4_450bps.nucleotide.6mer.template.model, could you please help me explain meaning of level_mean , level_stdv, sd_mean, sd_stdv and weight for each 6 mer? Thanks in advance!

Hi,
These values make up the "pore model" that describe the characteristics of the events we should observe for each k-mer. I describe this a little more in this blog post:
http://simpsonlab.github.io/2015/04/08/eventalign/
Jared

Thanks for your reply! The post is clear for me on level_mean and level_stdv in the file. But I am still a little confuse about sd_mean and sd_stdv here.
This is my understanding about the data there:
For the data shown here:
#original_file	r9.4_180mv_450bps_6mer/template_median68pA.model
#kmer	level_mean	level_stdv	sd_mean	sd_stdv	weight
AAAAAA	86.486336	1.517846	0.941478	0.609357	4739.559092
level_mean: average of all AAAAAA signal event
level_stdv: standard deviation of all AAAAAA signal event
In each measurement, there are several data points. There will be a standard deviation for each event in that short duration.
sd_mean: means the average of those standard deviation
sd_stdv: means the standard deviation of those standard deviation
weight: means time accumulation in that state.
I am wondering whether I understand each parameter accurate. Thank you very much!

Yes I think you are correct. A bit of background: the original HMM basecaller from ONT modeled the "spread" of the signal around the mean using an inverse gaussian distribution and sd_mean and sd_stdv are the parameters to this distribution. As far as I know most programs no longer model the signal spread (it was more useful when the reads were slower) so these fields are ignored. I don't know the precise definition of weight - it is something the training algorithm outputs - and I ignore it.


Fixes flaky secret controller unit tests

Utilizes some utilizes in pkg/test to wait
for an event rather than sleep for an arbitrary
amount of time.
(cherry picked from commit 9e4aacdb4aea69dadebf7abc165f1c1075fd20d4)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: john-a-joyce
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@john-a-joyce: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@john-a-joyce: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@john-a-joyce: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@john-a-joyce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth-mcp.sh
6eff5540a5c8a34780c1a9dd174d3a8d1e7f12e8
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e-envoyv2-v1alpha3


Create aws.md portuguese-br

What kind of changes does this PR include?

Translated content

Description

Closes #
What does this PR change? I am translating the aws.md page from English to Portuguese-br.

Thanks for this @favanso! The file is in the wrong path, could you fix this? Instead of src/pages/pt-br/guides/aws.md it should be at src/pages/pt-br/guides/deploy/aws.md. I'll be sure to review this ASAP after you have taken care of this 💜
Also, I would love to have you in our Discord chat! We have a special PT-BR translation thread where we can better organize our i18n efforts: https://astro.build/chat

Sure, I'll do that right away.

Closing in favour of #1431


Dapr integration with Azure Notification Hub

We are developing cloud-agnostic services using Dapr. We have to implement push notifications that support cloud-agnostic but right now the only option we have is Apple Push Notifications (APN) in Dapr. Any plans to integrate Azure and AWS Push Notification?

Anybody can contribute these integration to Dapr, but there are no current plans among the Dapr maintainers to build these integrations. We'll happily review PRs however.
You can already use the Dapr HTTP Output Binding and call the Azure Notification Hub APIs for example:
https://docs.dapr.io/reference/components-reference/supported-bindings/http/
https://docs.microsoft.com/en-us/rest/api/notificationhubs/direct-send


About the "gaze_C"?

Hi, thanks for your work! What is the meaning of "gaze_C" in the demo_webcam.py? I would be very grateful if you could answer me!

Hi, "gaze_C" means the gaze vector in the Camera-Coordinate-System (CCS), which is the aim for this "Gaze Estimation" task. Similarly, "gaze_W" is the gaze vector in the World-Coordinate-System (WCS). Note that the WCS here is fixed with the user's face.

Hi, "gaze_C" means the gaze vector in the Camera-Coordinate-System (CCS), which is the aim for this "Gaze Estimation" task. Similarly, "gaze_W" is the gaze vector in the World-Coordinate-System (WCS). Note that the WCS here is fixed with the user's face.

Thank you so much!


slow connection makes the whole thing slow

I think you should be able to reproduce using a ~56Kps connection.
It’s mainly buffer issues, I think it should start playing when the buffer is okay or maybe full. (games often have awful loading times, so why not)

Thanks! I'll take it into account when I'll find the motivation to reimplement it from scratch!


java.lang.UnsatisfiedLinkError in Java virtual-assistant sample code

Describe the bug
When I tried to run /cognitive-services-speech-sdk/quickstart/java/jre/virtual-assistant/ sample code, I got "Exception in thread "main" java.lang.UnsatisfiedLinkError: 'void com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()'"
To Reproduce
Steps to reproduce the behavior:

git clone this repo
Open Eclipse to launch sample code under /cognitive-services-speech-sdk/quickstart/java/jre/virtual-assistant/
Fill the subscriptionkey and region
run the sample code

Expected behavior
virtual-assistant sample works, as I have created the background bot service according to https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/tutorial-voice-enable-your-bot-speech-sdk
Version of the Cognitive Services Speech SDK
1.8.0
Platform, Operating System, and Programming Language

OS: Windows 10
Hardware - x64
Programming language: Java with jdk-13.0.1
Browser Chrome

Additional context
Here is the full exception message:
Exception in thread "main" java.lang.UnsatisfiedLinkError: 'void com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()'
at com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init(Native Method)
at com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.(carbon_javaJNI.java:958)
at com.microsoft.cognitiveservices.speech.dialog.DialogServiceConfig.(DialogServiceConfig.java:73)
at com.speechsdk.quickstart.Main.main(Main.java:55)

tried on another machine with Windows 10 X64, Java 8, and Speech SDK 1.8 still get the same error as above. Java info in this box:
java version "1.8.0_231"
Java(TM) SE Runtime Environment (build 1.8.0_231-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.231-b11, mixed mode)

Please move the
// Set audio input from microphone.
final AudioConfig audioConfig = AudioConfig.fromDefaultMicrophoneInput();
above the BotFrameworkConfig. After this change, it works on my environment.


Set Fahrenheit. Numbers still Celsius.

Setting Fahrenheit only changed the C to F. But the numbers are still Celsius.
26°C
Change it to Fahrenheit:
26°F

Update the data by swiping down.

#61


Minimal python version and f-strings

What is the minimal supported python version?
Can we use f-strings? It would be great if yes.

Currently the minimal supported version is 3.6 like in aiohttp. So f-strings are ok with me.

Don't you mind if I create a PR to convert all formatting to f-strings?

@maratori  Sure, go ahead! That sounds very tedious, i feel bad that you put so much work in this :D

@fscherf don't worry, that's how I relax :)


[PROPOSAL] Datasource selection changes from radio to select

I suggest changing the previous method of selecting data sources into drop-down ones. Otherwise, once more data sources are added, the whole page will look bloated.
Change the way you selected the data source before

Change the way you selected the data source after

I have implemented this function.

good suggestion， glad to see you will implement it

good job,  could you submit a PR ?

I will submit a pull request later. Do I submit it to the dev branch?
Best Regards
wuchunfu
2020-07-05
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Sun, Jul 5, 2020 10:28 PM
To<EMAIL_ADDRESS>Cc: "Musk"<319355703<EMAIL_ADDRESS>Subject: Re: [apache/incubator-dolphinscheduler] [PROPOSAL] Datasource selection changes from radio to select (#3139)
good job,  could you submit a PR ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

yes，please submit PR to dev branch


Move Acra to Google Cloud Engine

https://bitnami.com/stack/couchdb/cloud/google

https://www.bugify.com/pricing


Remove auto-linting in specs

I find this behaviour more annoying than having the build occasionally fail on CI.

@mobaig / @carvil thoughts?

It's fine now as all past issues have been fixed. From now on, we will get a sad face from jenkins on new issues (in the diff), which is fine by me. 👍

Cool. Can you merge?

Yup, was just waiting to see if there were more comments.


What is the plan for this NuGet/repository?

First of all, thank you for this repository and NuGet package. It can really be useful.
But I was wondering, what is the plan for this NuGet package? Because I can see people adding some extension methods.
Some questions:

Some of these methods that people are adding, are not full-proof, we need to make sure that they're are resilient and does the job 100%.
Some of these methods are lacking proper documentation - XML structure. They should have proper XML comments, with remarks, external links, potential exceptions, return values and so on.
Tests should be too more rigorous, testing not one, but many possible inputs.
Changelog could be added to the repository too.
StyleAnalizers or something to unify code style would be nice too.

TL:DR What are the plans for this repository? Is this one time, initial contribution or there are any future plans?

I agree 100% that the methods should be well-documented, well-tested, useful, and consistently styled. That's the goal. Contributions are welcome and I will eventually make this a 1.0 release when I think it's good enough for public consumption.


Cannot read properties of undefined (reading 'toolCalls')

Describe the bug

When I try to run a prompt, it gives me this error
Link to the Bolt URL that caused the error
http://localhost:5173/chat/3
Steps to reproduce
Just send a prompt
Expected behavior
It should of sended me a response, and not an error
Screen Recording / Screenshot

Platform

OS: Windows
Browser: FireFox, Chrome
Version: Latest

Provider Used
OpenAI
Model Used
GPT-4o
Additional context
No response

same here

copy of #860

nevermind lol, I read the install instructions. Never setup docker. Once docker was setup it started working. My bad

Same issue (non Docker) - straight install

I have the same problem, nothing seems to fix this!!


Glitching blocks and arrows

The latest update brings glitching blocks and arrows inside the entities. Arrow moves in each direction, blocks like stone and grass have their texture moving.

Related to: #23


Twitter login backend

Completed the code required for logging in using twitter account. On logging in using the twitter account, user will be redirected to home template.

Kindly solve merge conflict.......also mention issue number corresponding to this PR

Actually, I merged a branch to the main so again conflict ...... after solving it drop a message firstly I will merge your PR


Should be a Numeric Value in Duration Box

When you create description of a test, the duration column should have a formatted input in form of hours and minutes rather than this format i.e at present -> "17:18" this should be like "x hours 2 minutes".
Ideas->
You can use moment.js for time functionality

@aavishkarmishra : Can I work on this issue, Instead of using moment.js I would try to find lighter alternative for this conversion.

@aavishkarmishra : I will start working on it, In meantime Can you please assign me this issue.

@ShubhamChaudharyy , @aavishkarmishra : Added a fix, Please review.