Offer Created, Offer Updated, Offer Removed effects

Effects Offer Created, Offer Updated, Offer Removed are described in API docs, but they are not generated by the Horizon. Are there any specific reasons behind such behavior?
Those effects would be especially handy in case of historical asset price and orderbook recreation. I'm going to use historical data to implement coinmarketcap-like asset rating and trade volume history in my asset-centric block explorer. Besides, it's the only missing thing for the "time travel" feature, which will allow to view full asset/account stats for any point in timet.
Recreating active offers disposition at the particular point of time is really chalenging task without those effects implemented. Of course, I can parse raw XDR responses. However, I failed to found any solution for parsing XDR in SQL, so creating materialized view optimized for queries is not an option. On the other hand, parsing XDR outside the DB will result in additional tricky data sync with potentially stale data.
I understand that adding those effects may somewhat degrade the performance and increase Horizon DB size. So I would be very grateful if you could at least implement it as an optional feature that can be turned on by the env variable.
Thanks

Confirmed. Looks like a bug in https://github.com/stellar/go/blob/f08bdb8d5b13c92742b3d6d5d409b039adaff98e/services/horizon/internal/ingest/session.go#L479. It only processed trades.

This is important for professional trading desks that are looking for an audit trail

This is important for professional trading desks that are looking for an audit trail

I would not use the effects table for an audit trail!  Use the stellar-core history archives.

@bartekn @howardtw do you think we should make this an option since it may have performance impacts? Or avoid the complexity?


How to determine if project is up to date with theme

I can look at a project's go.mod file such as this one and I can figure out the updated date from that.  How can I then tell if this matches the most recent theme update?
Along those lines, I am guessing the version 0.0 is named such since we are in testing.  We should be sure to use a clear versioning system.

Version is 0.0.0 because we have no release on the theme for now. Once you create release on the theme's repo, hugo mod get will only update to latest release. See https://go.dev/doc/modules/version-numbers
I'd recommend remaining on a 0 version (0.1.0), because go has a strict policy on major version update: https://go.dev/doc/modules/major-version

Completely understand you won't be maintaining releases under the scope of this project.  I wanted to see if there is a way to look at the theme and look at a project and tell from there if the project up to date with the theme.

I think the hash in the version points to a commit, but you would have to confirm that. I'm not sure,

Thanks.


Comments: Update the App

Link to chapter - http://serverless-stack.com/chapters/update-the-app.html

This issue was moved to https://discourse.serverless-stack.com/t/comments-update-the-app/43


The npm version in the package.json dependency is too old.

Plese fill the template when you reporting a new issue, thanks!

Which platform are you running AnyProxy
Mac
The version of the AnyProxy

4.0
Your expected behavior of AnyProxy

Is it necessary to specify npm's version ("^2.7.0" in the anyproxy repo) in the package.json dependency? This would lock the npm version at 2.X in any project that require anyproxy! Then the old version npm could cause serious problem while almost every modern project may set their engines.npm to >=3.0 in their package.json.
The actual behavior of AnyProxy

AnyProxy dependency specify the npm version to 2.x, this is not a good idea.
The log of the error

remove the 'npm' from package.json


Show balloon messages when found/not found

Show a balloon message when the macro was found and copied, or it wasn't found.

Done. It already was working, it's just that if the silent mode is activated, they don't popup.


[DOC] Update every link in doc with {{ path_to_root }}

Insert the documentation link:
All documentation
Describe the issue or the suggestion:
Every link should be update with this very useful variable {{ path_to_root }}

Links are ok now so I close this issue


Compare results in Trixi2Img tests

Right now the test cases in Trixi2Img are really just smoke tests. We only test if the program runs, but we don't compare any generated images.
As comparing hashes doesn't really work on different systems, I suggest we actually compare the images and make sure they don't differ too much.
We could do this with Images.jl like in this example from here:
using Images, FileIO, Printf

absdiff(a::RGB{T}, b::RGB{T}) where T = sum(abs(col(a) - col(b)) for col in (red, green, blue))
function pctdiff(A::Matrix{Color{T}}, B::Matrix{Color{T}}) where T
    size(A) != size(B) && throw(ArgumentError("images must be same-size"))
    s = zero(T)
    for (a, b) in zip(A, B)
        s += absdiff(a, b)
    end
    return 100s / 3prod(size(A))
end

img50  = load("data/lenna50.jpg") |> Matrix{RGB{Float64}};
img100 = load("data/lenna100.jpg") |> Matrix{RGB{Float64}};

d = pctdiff(img50, img100)
@printf("Percentage difference: %.4f%%\n", d)

This code compares RGB values for each pixel and calculates a percentage difference.
One requirement would be that the generated images are all the same size. We could of course just let the test fail if the image sizes differ, but I am not sure if this could lead to problems. Is there any case where we could generate images with slightly different dimensions for the same input (perhaps on different machines)?

This is an excellent idea. I don't think that there is a reasonable situation where the image dimensions should differ between different machines/systems. Do you think that this would also work (maybe in a modified version) for PDF files?

I just tried reading a PDF with Images.jl and my REPL crashed. Also, I can't find anything about PDF in their docs, so I'm afraid that doesn't work.

OK, thanks for checking this out. Maybe someone will come with something else that we could do about PDFs...

If we just want to have this functionality on Travis, we could use ImageMagick to convert PDF files to JPG files and compare these in Julia (https://stackoverflow.com/questions/43085889/how-to-convert-a-pdf-into-jpg-with-command-line-in-linux).

Great idea :+1:! We can configure it such that it only checks this on Travis and does not fail when testing locally.

Closed since Trixi2Img is deprecated


"Edit on Only Office" not showing

Hello,
we recently tested a new confluence version and installed the add-on, we setup a document editor server and it worked.
Confluence Version 6.7.2
Now we deployed a new confluence appliance, installed the add-on and no attachment is showing the "Edit in Only Office" context.
Confluence is the same Version as in the lab scenario and the add-on is loaded and active. it's just showing it's outdated but that was also showing in the lab setup - but it worked.
Is there anything that we might have done to disable this add-on? Or is there a log to lookup a possible error?
Kind regards,
Max

Hello @Zasig, unfortunately, we did not develop and test ONLYOFFICE application for the version 6.7.2 of Confluence and we do not know how the application may behave.

i tried a few things and i noticed that the files i upload were not recognized as edit/viewable items for die document server. Because of that, it didn't show the string.


Av1f convertor?

Hello, I saw that AviF is presented as the new big thing, even if is webp here. It will be some support for AVIF?

I found something here,  but it will be nice to have it in img-optimize.

Hello @buzucan,
it will be available in the next release.


Logger shouldn't convert paths to absolute

The logger should be fixed so the logger doesn't convert file paths to absolute in the compilation commands. This extra logic is not necessary, since the "directory" attribute of the JSON object indicates the current working directory to which the relative paths are relative to.
This logic is duplicated in the Python code at processing response files #2092.

Fixed in #2160


Statter suggests it's not sampled

In my poking around for https://github.com/cactus/go-statsd-client/issues/27 I noticed that the Statter interface doesn't expose SetSamplerFunc -- is there any reason for this?
If there isn't it seems reasonable to reflect that the base Statter also has a sampler that can be configured.

It was intentional, yes. If an app exported a statsd client for plugins to use, for example, you wouldn't want to allow too much customization of the base client, as it would impact all instances of it. However, a substatter is more localized (a plugin can create a substatter and modify the inherited sampler).
It was added base don #24, if you want to read the background. I am not sure how widely utilized it is, so indeed the usage may be a bit awkward.
As far as a workaround, you could always type assert a Statter to a Client (if it happens to be one) or Substatter,  and then set the sampler that way. Not great used directly, but maybe palatable if you have a wrapper creating a Statter and returning it.

Yea, for general use it's not much of a problem / is easy to work around. It just made the static sampling wrapper a bit weirder to build but that's not really a common use case :)
Anyway, was just wondering if there was intent; thanks for humoring me.


Add SMURFF

FYI, @Kerbas-ad-astra
I assume SMURFF is compatible with KSP 1.1.2? In which case you'll probably want to update your .version file in the repository.

Suggestions

Other addons that bring "real-ish" capabilities and challenges to Kerbal Space Program include:

AntennaRange, to "enforce and encourage antenna diversity". Relaying is handled automatically, but only if you've used the right antennas for the job. (We'll see how the 1.1 antenna system is when that comes.)
I'll also advertise my AntennaRange Relays contract pack (for Contract Configurator), to give some guidance and financial support for deploying relays.
SCANSat, to make biome and elevation maps (handy for planning landings) and require just a bit more effort when scanning for resources.
USI Life Support, for a life support system which is simple and forgiving (unless you configure it to kill Kerbals).
USI Kolonization Systems, for ISRU that allows self-sustaining colonies (with some effort).
You should also consider picking up Extraplanetary Launchpads and OSE Workshop (and Kerbal Inventory System, OSE's dependency), as an extension of NASA's real-world interest in in-situ manufacturing and repair. (And to give your bases something new to do.)

@plague006 I've added basically every mod mentioned as a suggests including the "recommendations" which probably shouldn't be installed by default.

Looks good to me, merging with my thanks.

Looks good.

I haven't updated for 1.1.2 yet because I'm waiting on CryoEngines to officially update.


Samba error

See error #290, this problem is still current and needs to be done after every update!

#354 - fixed


Support for Determining a Gradient's Anchor Points

Is your feature request related to a problem? Please describe.
We currently don't support the ability to determine the anchor points of gradient tokens (probably also Figma API related).
One user's used case was that when he imported gradient styles into the plugin, the anchor points when applied through token were inaccurate compared to the way the style counterparts were setup and this caused for inconsistency across brands.
We will need more information on this as we also weren't able to find much information of this being supported in CSS. That being said, the aforementioned user did share the following links emphasising on the support of anchor-points:

https://developer.mozilla.org/en-US/docs/Web/CSS/gradient/linear-gradient
https://developer.mozilla.org/en-US/play

Screen-recording:

we are using this method since quite some time.
And it always worked, i don't know if Figma changed sth, or it is something else.

I think you described the issue precisely. The only thing I can add to this is the fact that the anchor points percentages are imported by Tokens Studio, but when applied back to a shape they are ignored. So, my guess is that this is indeed a bug in TS. Thanks for opening this ticket.

@keeganedwin so this is definitly a bug, because the sync/applying back works when the angle of the gradient is in 45° steps. it only brakes when other angles are used

@qimmiq @guedzzz, I came across an old ticket that was fixed a long time ago. It also seems to be related to importing gradient styles into TS which then changes the degree: #156

@keeganedwin @guedzzz  this ticket describes the way figma -> tokenstudio ...
what we are pointing out is the the other way. tokenstudio->figma. applying a color token to a figma shape breaks the appearance.

@keeganedwin i would also rather label it as a bug, because the position points of the gradient
Figma CSS:
background: linear-gradient(153.43deg, #AD00FF 0%, rgba(82, 255, 0, 0) 83.33%)
copied to Token applied back to shape, copied Figma CSS
background: linear-gradient(153.43deg, #AD00FF 8.33%, rgba(82, 255, 0, 0) 77.78%)
and also creating styles from tokens result in empty fills.
linear-gradient(136.98deg, #AD00FF -28.11%, rgba(82, 255, 0, 0) 123.5%)
-> empty figma style, no fill

This request has been moved to our new feedback tool. Go check out https://tokensstudio.featurebase.app/ to create a free account. You can upvote and comment on existing posts, make a new request, and subscribe to be notified when requests move into our roadmap.

Added to Featurebase Roadmap : 🎨 Expand gradient color support

Closing this issue as not planned as its been migrated to featurebase - 🎨 Expand gradient color support
Please click the link to create a free account and upvote the request so we can notify you when we start working on it. 🚀


On Parallel Adapters & Prefix Tuning

Environment info
NA

adapter-transformers version: 3.1.0
Platform: Linux GPU
Python version: 3.8
PyTorch version (GPU?): 1.13

Details

Is Parallel Adapters [1] supported for IA3 / Prefix Tuning[2] as well?
[1]: https://docs.adapterhub.ml/adapter_composition.html#parallel
[2]: https://docs.adapterhub.ml/classes/adapter_config.html?highlight=ia3#prefix-tuning

Many language models use generate API to generate text. When using ParallelAdapters, would use of generate still be possible?

When using Parallel Adapter, how does latency & GPU memory & GPU utilization look like?
Would having ParallelAdapter with N adapters be equivalent to having batch size N ?
Is there a benchmark study on latency comparison on using ParallelAdapter vs SingleAdapter?

Hi @hchoi-moveworks ,
with our new release of adapter-transformers v.3.2, we solved some of your issues

We support parallel composition for prefix tuning but not for IA3.
We added support for generation with parallel composition with the generate method.
Unfortunately, we don't have statistics on the latency, GPU memory or GPU utilization. If you get statistics, feel free to share them with us :) Using parallel composition is not equivalent to a batch size of N. The batch size is adapted at the first parallel block (see this illustration) until the first parallel block the batch size is the original one.

This issue has been automatically marked as stale because it has been without activity for 90 days. This issue will be closed in 14 days unless you comment or remove the stale label.

This issue was closed because it was stale for 14 days without any activity.


Update Kafka processor casting Object to String

Update casting of Gobblin metadata field from Object to Map<String, String>. Instead of force cast, now iterate through the Map<Object, Object> and cast each one to String. This correct many deserialization errors.
Improve debug information if client can't fetch schema from Registery (may due to lack of schemaId). Exception now contains topic name and first 40 bytes of message.

LGTM


Remove object from a list

Problem
Right now list removal happens at index: https://github.com/realm/realm-swift/blob/master/RealmSwift/List.swift#L152
It'd be nice to have something like: list.remove(element)
See: https://www.mongodb.com/community/forums/t/realm-swift-ui-pain-points/146772
Solution
Maybe something like this: https://github.com/realm/realm-swift/commit/cd83a7e24b5d84eff4b58c3fa43ad7780f8cbb82
There are a few cases to handle.
If the object doesn't exist in the list.
If the object exists multiple times.
Linking objects is another issue to think about. Elements are not really "appended" or "removed" because linking objects are based on the existence of a relationship.
How important is this improvement for you?
No response

+1 Yes, users of the SDK would love to see this

1

+1

Just as useful would be iterator removal similar to that found in the Java Collections API.


=product json override in order to enable copilot within oss

This should not go into product.json, rather you can store this in a file product.overrides.json which is in .gitignore and will be respected.


Add one new constructor with threadFactory only

Motivation:
In most cases, we want to use NioEventLoopGroup without setting thread numbers but thread name only. So we need to use followed code:
NioEventLoopGroup boss = new NioEventLoopGroup(0, new DefaultThreadFactory("boss"));
It looks a bit confuse or strange for the number 0 due to we only want to set thread name. So it will be better to add new constructor for this case.
Modifications:
Add one constructor: public NioEventLoopGroup(ThreadFactory threadFactory)
Result:
User can only set thread factory without setting the thread number to 0:
NioEventLoopGroup boss = new NioEventLoopGroup(new DefaultThreadFactory("boss"));

@jiafu1115 if you do this please also do this for the other EventLoopGroup implementations to keep it consistent.

@normanmaurer  Ok, will do. thanks

@normanmaurer done. Thanks for your review again.

@netty-bot test this please

@jiafu1115 thanks a lot... merged


Use S01E01 instead of S1E1

📝 Provide a description of the new feature
Having S01E01 instead of S1E1 looks nicer to the eye and looks simply better, would you mind implementing it in discrakt?
➕ Additional Information
No response

Valid point!


Modifications related to Thresholds

Various updates to add information to the SPHINX dataframe and some improvements related to the application of thresholds.

Also this PR is pending a unit test that exploits the bug that was fixed.

Note that these changes address and resolve Issue #4


Added logging to TestRunner

This change is

PR is added to the queue for testing as 1. task. (0901bf9)

Hi @baydet, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Test (Success) 86482582 build is completed (0901bf9)
See https://github.com/ThaliTester/TestResults/tree/864825820901bf9_Added_logging_to_TestRunner_baydet/ for the logs

Test<PHONE_NUMBER>01bf9(0901bf9) has successfully finished without an error
See https://github.com/ThaliTester/TestResults/tree/864825820901bf9_Added_logging_to_TestRunner_baydet/ for the logs

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 15 at r1 (raw file):

// MARK: - Current version of TestRunner doesn't display in logs assertion failures.
// This category `overrides` recordFailureWithDescription and adds logging for failures.
extension XCTestCase {

NB:
I don't like idea of using swizzling, especially in Swift. But I understand that we don't have much time now.
I suggest two different approaches how we can follow.

Take a loot at XCTestObservationCenter and XCTestObservation. If it doesn't take you a lot of time to implement your task with this classes, please do it. Because it's a correct way of implementing what you need.
Leave swizzling as it is now. Create a separate issue which tells that it should be rewritten later as of option 1 above. Put the link of this issue it in the code.

It's up to you to decide how to follow, but please take a look at 1 before leaving as it is now. I think it wold be easy since you just need very simple logs.

Comments from Reviewable

PR is added to the queue for testing as 3. task. (7cea8e2)

Test 864825827cea8e2(7cea8e2) has failed
See https://github.com/ThaliTester/TestResults/tree/864825827cea8e2_Added_logging_to_TestRunner_baydet/ for the fail logs

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 78 at r2 (raw file):

        // Test must only be run on the main thread.
        // Please note that it's important not using GCD, because XCTest.framework doesn't use GCD
        if !NSThread.currentThread().isMainThread {

NB: This's very tricky place. It may not work if someone calls runTest via GDC methods.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 15 at r1 (raw file):
Previously, larryonoff (larryonoff) wrote…
> NB:
>
> I don't like idea of using swizzling, especially in Swift. But I understand that we don't have much time now.
>
> I suggest two different approaches how we can follow.
> 1. Take a loot at `XCTestObservationCenter` and `XCTestObservation`. If it doesn't take you a lot of time to implement your task with this classes, please do it. Because it's a correct way of implementing what you need.
> 2. Leave swizzling as it is now. Create a separate issue which tells that it should be rewritten later as of option 1 above. Put the link of this issue it in the code.
>
> It's up to you to decide how to follow, but please take a look at 1 before leaving as it is now. I think it wold be easy since you just need very simple logs.

I've replaced swizzling with XCTestObservation. It really looks nicer and clearer.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

PR is added to the queue for testing as 7. task. (895a768)

Test (Success) 86482582 build is completed (895a768)
See https://github.com/ThaliTester/TestResults/tree/86482582895a768_Added_logging_to_TestRunner_baydet/ for the logs

Test<PHONE_NUMBER>5a768(895a768) has failed
See https://github.com/ThaliTester/TestResults/tree/86482582895a768_Added_logging_to_TestRunner_baydet/ for the fail logs

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 78 at r2 (raw file):
Previously, larryonoff (larryonoff) wrote…
> NB: This's very tricky place. It may not work if someone calls `runTest` via GDC methods.

Could you provide an example?

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 78 at r2 (raw file):
Previously, baydet (Alexander Evsyuchenya) wrote…
> Could you provide an example?

I'm lazy, so just posting article
http://blog.benjamin-encz.de/post/main-queue-vs-main-thread/

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

lib/ios/ThaliCore/ThaliCoreCITests/TestRunner/TestRunner.swift, line 78 at r2 (raw file):
Previously, larryonoff (larryonoff) wrote…
> I'm lazy, so just posting article
> http://blog.benjamin-encz.de/post/main-queue-vs-main-thread/

I'm not sure if it's a real problem in our case. Even if this mainThread check fails we're performing selector on main thread. I use this construction because I didn't use 3 calls of  performSelectorOnMainThread for these lines
        XCTestObservationCenter.sharedTestObservationCenter().addTestObserver(self)
        testSuite.runTest()
        XCTestObservationCenter.sharedTestObservationCenter().removeTestObserver(self)

PS
Since you marked this as NB could you just acknowledge this as viewed to make this annoying reviewable check passing :)

Comments from Reviewable

PR is added to the queue for testing as 4. task. (e70b00a)

Test (Success) 86482582 build is completed (e70b00a)
See https://github.com/ThaliTester/TestResults/tree/86482582e70b00a_Added_logging_to_TestRunner_baydet/ for the logs

Test 86482582e70b00a(e70b00a) has failed
See https://github.com/ThaliTester/TestResults/tree/86482582e70b00a_Added_logging_to_TestRunner_baydet/ for the fail logs

PR is added to the queue for testing as 5. task. (6cfc86f)

Test (Success) 86482582 build is completed (6cfc86f)
See https://github.com/ThaliTester/TestResults/tree/864825826cfc86f_Added_logging_to_TestRunner_baydet/ for the logs

Test 864825826cfc86f(6cfc86f) has failed
See https://github.com/ThaliTester/TestResults/tree/864825826cfc86f_Added_logging_to_TestRunner_baydet/ for the fail logs


[SPARK-13805][SQL] Generate code that get a value in each column from ColumnVector when ColumnarBatch is used

What changes were proposed in this pull request?
This PR generates code that get a value in each column from ColumnVector instead of creating InternalRow when ColumnarBatch is accessed. This PR improves benchmark program by up to 15%.
This PR consists of two parts:

Get an ColumnVector  by using ColumnarBatch.column() method
Get a value of each column by using rdd_col${COLIDX}.getInt(ROWIDX) instead of rdd_row.getInt(COLIDX)

This is a motivated example.
    sqlContext.conf.setConfString(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, "true")
    sqlContext.conf.setConfString(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key, "true")
    val values = 10
    withTempPath { dir =>
      withTempTable("t1", "tempTable") {
        sqlContext.range(values).registerTempTable("t1")
        sqlContext.sql("select id % 2 as p, cast(id as INT) as id from t1")
          .write.partitionBy("p").parquet(dir.getCanonicalPath)
        sqlContext.read.parquet(dir.getCanonicalPath).registerTempTable("tempTable")
        sqlContext.sql("select sum(p) from tempTable").collect
      }
    }

The original code
    ...
    /* 072 */       while (!shouldStop() && rdd_batchIdx < numRows) {
    /* 073 */         InternalRow rdd_row = rdd_batch.getRow(rdd_batchIdx++);
    /* 074 */         /*** CONSUME: TungstenAggregate(key=[], functions=[(sum(cast(p#4 as bigint)),mode=Partial,isDistinct=false)], output=[sum#10L]) */
    /* 075 */         /* input[0, int] */
    /* 076 */         boolean rdd_isNull = rdd_row.isNullAt(0);
    /* 077 */         int rdd_value = rdd_isNull ? -1 : (rdd_row.getInt(0));
    ...

The code generated by this PR
    /* 072 */       while (!shouldStop() && rdd_batchIdx < numRows) {
    /* 073 */         org.apache.spark.sql.execution.vectorized.ColumnVector rdd_col0 = rdd_batch.column(0);
    /* 074 */         /*** CONSUME: TungstenAggregate(key=[], functions=[(sum(cast(p#4 as bigint)),mode=Partial,isDistinct=false)], output=[sum#10L]) */
    /* 075 */         /* input[0, int] */
    /* 076 */         boolean rdd_isNull = rdd_col0.getIsNull(rdd_batchIdx);
    /* 077 */         int rdd_value = rdd_isNull ? -1 : (rdd_col0.getInt(rdd_batchIdx));
    ...
    /* 128 */         rdd_batchIdx++;
    /* 129 */       }
    /* 130 */       if (shouldStop()) return;

Performance
Without this PR
model name	: Intel(R) Xeon(R) CPU E5-2667 v2 @ 3.30GHz
Partitioned Table:                  Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
-------------------------------------------------------------------------------------------
Read data column                          434 /  488         36.3          27.6       1.0X
Read partition column                     302 /  346         52.1          19.2       1.4X
Read both columns                         588 /  643         26.8          37.4       0.7X

With this PR
model name	: Intel(R) Xeon(R) CPU E5-2667 v2 @ 3.30GHz
Partitioned Table:                  Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
-------------------------------------------------------------------------------------------
Read data column                          392 /  516         40.1          24.9       1.0X
Read partition column                     256 /  318         61.4          16.3       1.5X
Read both columns                         523 /  539         30.1          33.3       0.7X

How was this patch tested?
Tested by existing test suites and benchmark

Test build #52846 has started for PR 11636 at commit 0db679f.

@nongli , here is another example.
Spark code with two columns
    sqlContext.conf.setConfString(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key, "true")
    sqlContext.conf.setConfString(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key, "true")
    val values = 10
    withTempPath { dir =>
      withTempTable("t1", "tempTable") {
        sqlContext.range(values).registerTempTable("t1")
        sqlContext.sql("select id % 2 as p, cast(id as INT) as id from t1")
          .write.partitionBy("p").parquet(dir.getCanonicalPath)
        sqlContext.read.parquet(dir.getCanonicalPath).registerTempTable("tempTable")
        sqlContext.sql("select sum(p), sum(id) from tempTable").collect
      }
    }

Code snippet generated by this PR
...
    /* 073 */   private void rdd_processBatches() throws java.io.IOException {
    /* 074 */     while (true) {
    /* 075 */       int numRows = rdd_batch.numRows();
    /* 076 */       if (rdd_batchIdx == 0) rdd_metricValue.add(numRows);
    /* 077 */
    /* 078 */       while (!shouldStop() && rdd_batchIdx < numRows) {
    /* 079 */         org.apache.spark.sql.execution.vectorized.ColumnVector rdd_col0 = rdd_batch.column(0);org.apache.spark.sql.execution.vectorized.ColumnVector r
dd_col1 = rdd_batch.column(1);
    /* 080 */         /*** CONSUME: TungstenAggregate(key=[], functions=[(sum(cast(p#4 as bigint)),mode=Partial,isDistinct=false),(sum(cast(id#3 as bigint)),mode=Pa
rtial,isDistinct=false)], output=[sum#13L,sum#14L]) */
    /* 081 */         /* input[0, int] */
    /* 082 */         boolean rdd_isNull = rdd_col0.getIsNull(rdd_batchIdx);
    /* 083 */         int rdd_value = rdd_isNull ? -1 : (rdd_col0.getInt(rdd_batchIdx));
    /* 084 */         /* input[1, int] */
    /* 085 */         boolean rdd_isNull1 = rdd_col1.getIsNull(rdd_batchIdx);
    /* 086 */         int rdd_value1 = rdd_isNull1 ? -1 : (rdd_col1.getInt(rdd_batchIdx));
    /* 087 */
    /* 088 */         // do aggregate
...

Test build #52991 has started for PR 11636 at commit 141f2d6.

Test build #52991 has finished for PR 11636 at commit 141f2d6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52991/
Test FAILed.

Test build #52992 has started for PR 11636 at commit aa09964.

Test build #52992 has finished for PR 11636 at commit aa09964.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52992/
Test PASSed.

cc @davies

@nongli , is it possible to change the name of API from ColumnVector.getIsNull() to ColumnVector.isNullAt(). If it is possible, we can remove a change of this PR in at lines 74-84 in BoundsAttribute.scala.

@kiszk Feel free to change that API

Test build #53324 has started for PR 11636 at commit c522a68.

Test build #53324 has finished for PR 11636 at commit c522a68.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53324/
Test PASSed.

Test build #53466 has started for PR 11636 at commit 5544c96.

Test build #53466 has finished for PR 11636 at commit 5544c96.

This patch fails R style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class InputReference(ordinal: Int, dataType: DataType, nullable: Boolean, isColumn: Boolean)

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53466/
Test FAILed.

Test build #53468 has started for PR 11636 at commit 5efadf3.

Test build #53468 has finished for PR 11636 at commit 5efadf3.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class InputReference(ordinal: Int, dataType: DataType, nullable: Boolean, isColumn: Boolean)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53468/
Test FAILed.

Test build #53470 has started for PR 11636 at commit 8c9d054.

Test build #53470 has finished for PR 11636 at commit 8c9d054.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53470/
Test FAILed.

Test build #53500 has started for PR 11636 at commit e08472b.

Test build #53500 has finished for PR 11636 at commit e08472b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class InputReference(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53500/
Test PASSed.

Test build #53537 has started for PR 11636 at commit a7ac8fb.

Test build #53537 has finished for PR 11636 at commit a7ac8fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53537/
Test PASSed.

Merged build finished. Test PASSed.

Test build #53584 has started for PR 11636 at commit cdd3078.

Test build #53584 has finished for PR 11636 at commit cdd3078.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53584/
Test PASSed.

Merged build finished. Test PASSed.

@kiszk I think this is pretty close to what we want, thanks for working on it.

@davies I am glad to work on what the community wants.

Test build #53611 has started for PR 11636 at commit cdf4333.

Test build #53611 has finished for PR 11636 at commit cdf4333.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53611/
Test PASSed.

Test build #53674 has started for PR 11636 at commit fb693d2.

Test build #53674 has finished for PR 11636 at commit fb693d2.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53674/
Test FAILed.

Test build #53678 has started for PR 11636 at commit 9ec61ce.

Have you rerun the benchmark with these changes?

Test build #53678 has finished for PR 11636 at commit 9ec61ce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53678/
Test PASSed.

Here are benchmark results in the latest code.
Without this PR
model name	: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
Partitioned Table:                  Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
-------------------------------------------------------------------------------------------
Read data column                          484 /  529         32.5          30.7       1.0X
Read partition column                     323 /  368         48.7          20.5       1.5X
Read both columns                         617 /  654         25.5          39.2       0.8X

With this PR
model name	: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
Partitioned Table:                  Best/Avg Time(ms)    Rate(M/s)   Per Row(ns)   Relative
-------------------------------------------------------------------------------------------
Read data column                          412 /  444         38.2          26.2       1.0X
Read partition column                     290 /  327         54.2          18.4       1.4X
Read both columns                         516 /  613         30.5          32.8       0.8X

Test build #53706 has started for PR 11636 at commit 6b07e69.

LGTM

Test build #53706 has finished for PR 11636 at commit 6b07e69.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53706/
Test PASSed.

Merged build finished. Test PASSed.

Merged into master, thanks!


directx-shader-compiler: 1.7.2308 -> 1.8.2405

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/DirectXShaderCompiler/releases.
meta.description for directx-shader-compiler is: A compiler to compile HLSL programs into DXIL and SPIR-V
meta.homepage for directx-shader-compiler is: https://github.com/microsoft/DirectXShaderCompiler
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2403 in filename of file in /nix/store/v4cr7612y0a1b3j5s98z9w3zx6ffw79s-directx-shader-compiler-1.8.2403

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
amdvlk
directx-shader-compiler
driversi686Linux.amdvlk
rbdoom-3-bfg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v4cr7612y0a1b3j5s98z9w3zx6ffw79s-directx-shader-compiler-1.8.2403 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A directx-shader-compiler https://github.com/r-ryantm/nixpkgs/archive/a22a43597ff55e5024bdc6dc1dde295ad34bc6b4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a22a43597ff55e5024bdc6dc1dde295ad34bc6b4#directx-shader-compiler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v4cr7612y0a1b3j5s98z9w3zx6ffw79s-directx-shader-compiler-1.8.2403
ls -la /nix/store/v4cr7612y0a1b3j5s98z9w3zx6ffw79s-directx-shader-compiler-1.8.2403/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

amdvlk
driversi686Linux.amdvlk

3 packages built:

directx-shader-compiler
directx-shader-compiler.dev
rbdoom-3-bfg

Maintainer pings
cc @expipiplus1 @Flakebi for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/DirectXShaderCompiler/releases.
meta.description for directx-shader-compiler is: A compiler to compile HLSL programs into DXIL and SPIR-V
meta.homepage for directx-shader-compiler is: https://github.com/microsoft/DirectXShaderCompiler
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2403.1 in filename of file in /nix/store/0162dxwd7jmi2j430hxf6wmxk0xj5107-directx-shader-compiler-1.8.2403.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
amdvlk
directx-shader-compiler
driversi686Linux.amdvlk
rbdoom-3-bfg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0162dxwd7jmi2j430hxf6wmxk0xj5107-directx-shader-compiler-1.8.2403.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A directx-shader-compiler https://github.com/r-ryantm/nixpkgs/archive/4a51d4e38b7cd2942db11376d1f31dcc4702191e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4a51d4e38b7cd2942db11376d1f31dcc4702191e#directx-shader-compiler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0162dxwd7jmi2j430hxf6wmxk0xj5107-directx-shader-compiler-1.8.2403.1
ls -la /nix/store/0162dxwd7jmi2j430hxf6wmxk0xj5107-directx-shader-compiler-1.8.2403.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

amdvlk
driversi686Linux.amdvlk

3 packages built:

directx-shader-compiler
directx-shader-compiler.dev
rbdoom-3-bfg

Maintainer pings
cc @expipiplus1 @Flakebi for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/DirectXShaderCompiler/releases.
meta.description for directx-shader-compiler is: A compiler to compile HLSL programs into DXIL and SPIR-V
meta.homepage for directx-shader-compiler is: https://github.com/microsoft/DirectXShaderCompiler
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2403.2 in filename of file in /nix/store/5n9rv58zsmnk09xj55gasi9s46grrzr8-directx-shader-compiler-1.8.2403.2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
amdvlk
directx-shader-compiler
driversi686Linux.amdvlk
rbdoom-3-bfg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5n9rv58zsmnk09xj55gasi9s46grrzr8-directx-shader-compiler-1.8.2403.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A directx-shader-compiler https://github.com/r-ryantm/nixpkgs/archive/d92f0a4a3a0190f8cb235b3f087057d030773da5.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d92f0a4a3a0190f8cb235b3f087057d030773da5#directx-shader-compiler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5n9rv58zsmnk09xj55gasi9s46grrzr8-directx-shader-compiler-1.8.2403.2
ls -la /nix/store/5n9rv58zsmnk09xj55gasi9s46grrzr8-directx-shader-compiler-1.8.2403.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

amdvlk
driversi686Linux.amdvlk

3 packages built:

directx-shader-compiler
directx-shader-compiler.dev
rbdoom-3-bfg

Maintainer pings
cc @expipiplus1 @Flakebi for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/DirectXShaderCompiler/releases.
meta.description for directx-shader-compiler is: A compiler to compile HLSL programs into DXIL and SPIR-V
meta.homepage for directx-shader-compiler is: https://github.com/microsoft/DirectXShaderCompiler
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.2405 in filename of file in /nix/store/pv8wyvyval3maryq1h2qrf955pfzyqql-directx-shader-compiler-1.8.2405

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

amdvlk
directx-shader-compiler
driversi686Linux.amdvlk
rbdoom-3-bfg

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pv8wyvyval3maryq1h2qrf955pfzyqql-directx-shader-compiler-1.8.2405 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A directx-shader-compiler https://github.com/r-ryantm/nixpkgs/archive/01649bd81cfcd13d7ffc869de139802a8c84a2d4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/01649bd81cfcd13d7ffc869de139802a8c84a2d4#directx-shader-compiler

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pv8wyvyval3maryq1h2qrf955pfzyqql-directx-shader-compiler-1.8.2405
ls -la /nix/store/pv8wyvyval3maryq1h2qrf955pfzyqql-directx-shader-compiler-1.8.2405/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

amdvlk
driversi686Linux.amdvlk

3 packages built:

directx-shader-compiler
directx-shader-compiler.dev
rbdoom-3-bfg

Maintainer pings
cc @expipiplus1 @Flakebi for testing.

The amdvlk update that should fix the compatibility issue is here: #298096

Result of nixpkgs-review pr 295093 run on x86_64-linux 1

5 packages built:

amdvlk
directx-shader-compiler
directx-shader-compiler.dev
driversi686Linux.amdvlk
rbdoom-3-bfg

@NickCao could you mark it as ready again?


[Bugfix] Fix decode tokens w. CUDA graph

Fixes #6703.
This is not related to speculative decoding particularly but not sure why no unit test failed. Will try to add a unit test in this or a follow-up PR.
cc @cadedaniel @alexm-neuralmagic

How do we know this fixes the issue?

How do we know this fixes the issue?

I tested it locally and will add a unit test to catch this later. Just put the PR here to unblock benchmarking first.

Turns out that num_decode_tokens is probably the attribute missed in the unit test...
The new added assertion will fail without this PR.


Add solace exporter

Add exporter for Solace PubSub+

You're taking a password on the command line, which needs to be removed as that's insecure.
A few suggestions to improve things:
Why do you have a mutex in Collect? You're correctly using MustNewConstMetric, so you shouldn't need that.
Why are you resetting metrics on scrape? That'll break if there's more than one scraper.
You should probably drop all the _avg metrics, I'd guess that they're since process start and thus of little use. Similarly the _rate metrics can be calculated from the _total metrics in PromQL.

Hi Brian,
the password via command line is for docker the way to go i gues. Would you prever ENV?
The reset is for debug case and is not used in production.
_avg and _rate will be removed if there is a total.
Can you please explain the the mutex issue?

the password via command line is for docker the way to go i gues. Would you prever ENV?

I don't mind how you approach it, as long as there isn't a password being put on the command line by users.

The reset is for debug case and is not used in production.

I'd suggest a disclaimer for that option then, users have a tendency to set such things and not understand why everything then breaks.

Can you please explain the the mutex issue?

You've a mutex for no apparent reason.

@GreenRover Is the mutex perhaps only needed for the global reset, so you don't do it twice? The other read-only data gathering calls to Solace that happen in Collect() should be safe to do concurrently/in parallel, right?

@brian-brazil
For the password  i added a security hint that the command line option only should be use for hte config option of kingpin
All _avg _rate metrics was removed if a counter exists.
The reset option was refactored and documentation was improved. A warning was added to only usw with care.
@juliusv @brian-brazil
The mutex is to protect the solace broker to not bean overloaded. The target is not perform parallel scrapes.

@brian-brazil pleas not jet merge. @dabgmx needs a last confirmation that we are permitted to publish.

For the password i added a security hint that the command line option only should be use for hte config option of kingpin

The binary still takes a password on the command line, and in the docker example.

The mutex is to protect the solace broker to not bean overloaded. The target is not perform parallel scrapes.

That's not the duty of an exporter generally.

@brian-brazil This password options is still there. yes. This is beacuse kingpin use the same flags for commandline options and config file. What solution whould you advice? That support config file + ENV support.

If Kingpin forces you to take command line arguments for this, then I'd not use kingpin for this setting.


error occurred: Failed to find tool. Is gcc.exe installed? while cargo install diesel_cli --no-default-features --features "sqlite-bundled"

Setup
Versions

Rust:1.48.0
Database: Sqlite
Operating System: windows 10

Problem Description
I'm following the get started tutorial and when I try to install diesel cli i get this error message when using cargo install diesel_cli --no-default-features --features "sqlite-bundled":
error: failed to run custom build command for libsqlite3-sys v0.18.0`
Caused by:
process didn't exit successfully: *\AppData\Local\Temp\cargo-install7xv7rN\release\build\libsqlite3-sys-0e739e5ad9d937ff\build-script-build (exit code: 1)
--- stdout
cargo:rerun-if-env-changed=SQLITE_MAX_VARIABLE_NUMBER
cargo:rerun-if-env-changed=SQLITE_MAX_EXPR_DEPTH
TARGET = Some("x86_64-pc-windows-gnu")
OPT_LEVEL = Some("3")
HOST = Some("x86_64-pc-windows-gnu")
CC_x86_64-pc-windows-gnu = None
CC_x86_64_pc_windows_gnu = None
HOST_CC = None
CC = None
CFLAGS_x86_64-pc-windows-gnu = None
CFLAGS_x86_64_pc_windows_gnu = None
HOST_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
running: "gcc.exe" "-O3" "-ffunction-sections" "-fdata-sections" "-m64" "-DSQLITE_CORE" "-DSQLITE_DEFAULT_FOREIGN_KEYS=1" "-DSQLITE_ENABLE_API_ARMOR" "-DSQLITE_ENABLE_COLUMN_METADATA" "-DSQLITE_ENABLE_DBSTAT_VTAB" "-DSQLITE_ENABLE_FTS3" "-DSQLITE_ENABLE_FTS3_PARENTHESIS" "-DSQLITE_ENABLE_FTS5" "-DSQLITE_ENABLE_JSON1" "-DSQLITE_ENABLE_LOAD_EXTENSION=1" "-DSQLITE_ENABLE_MEMORY_MANAGEMENT" "-DSQLITE_ENABLE_RTREE" "-DSQLITE_ENABLE_STAT2" "-DSQLITE_ENABLE_STAT4" "-DSQLITE_SOUNDEX" "-DSQLITE_THREADSAFE=1" "-DSQLITE_USE_URI" "-DHAVE_USLEEP=1" "-DSQLITE_HAVE_ISNAN" "-o" "*\AppData\Local\Temp\cargo-install7xv7rN\release\build\libsqlite3-sys-a8e9f4042b6f0b14\out\sqlite3/sqlite3.o" "-c" "sqlite3/sqlite3.c"
--- stderr
error occurred: Failed to find tool. Is gcc.exe installed? (see https://github.com/alexcrichton/cc-rs#compile-time-requirements for help)
warning: build failed, waiting for other jobs to finish...
error: failed to compile diesel_cli v1.4.1, intermediate artifacts can be found at C:\Users\gabre\AppData\Local\Temp\cargo-install7xv7rN
Caused by:
build failed`

If you use the sqlite-bundled you need to provide a C compiler that is able to build sqlite.
Closed as this is not a diesel issue.


Updated RHODS alerts to point to documentation

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
[X] JIRA link(s): https://issues.redhat.com/browse/RHODS-1958
[x] The Jira story is acked
[x] An entry has been added to the latest build document in Build Announcements Folder.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Testing steps

Check that the links are poitint to the correct Runbook.

/lgtm, just ask alex once before merging

After upgrade, I can confirm that the yaml is correct.
I tested out the alerts too, the runbook links are good.

This is only to be merged and included in the 1.3.0 release

In the case of alerts "User notebook pvc usage at 90%" and "User notebook pvc usage at 100%" the triage url is
https://gitlab.cee.redhat.com/service/managed-tenants-sops/-/tree/main/RHODS
but there are no instructions there to increase the PVC
Note: those alerts are not sent to SRE, they are sent to the email address specified when installing RHODS. But it would be nice to have a triage document anyway in the managed-tenants repo. The instructions existed in the old document JupyterHub Notebook pod has run out of disk space and also in the users's docs 8.3. I see a database or disk is full error or a no space left on device error when I run my notebook cells

In the case of alerts "User notebook pvc usage at 90%" and "User notebook pvc usage at 100%" the triage url is https://gitlab.cee.redhat.com/service/managed-tenants-sops/-/tree/main/RHODS but there are no instructions there to increase the PVC
Note: those alerts are not sent to SRE, they are sent to the email address specified when installing RHODS. But it would be nice to have a triage document anyway in the managed-tenants repo. The instructions existed in the old document JupyterHub Notebook pod has run out of disk space and also in the users's docs 8.3. I see a database or disk is full error or a no space left on device error when I run my notebook cells

Hi @jgarciao I was about to reply you but you've commented it, this is specific to pagerduty alerts, PVC alerts are mail specific, we brought up that same thing last week.
We can consider opening a new ticket for that specific request (as it's related to email notifications and we should include new instructions) to implement that feature, what do you think @maulikjs @anishasthana ?


links on site don't resolve

instead of clickable link, this is what renders
Next up: [DNS Basics](basic.md.html).

For what it is worth, I do not see this issue currently.


How do you configure an InterceptStrategy in Quarkus?

In Spring Boot it was as simple as having a bean that implements InterceptStrategy, but this doesn't seem to work with Quarkus - the bean is not used and I get a warning:
================================================================================
CDI: programmatic lookup problem detected
-----------------------------------------
At least one bean matched the required type and qualifiers but was marked as unused and removed during build

Stack frame: org.apache.camel.quarkus.core.RuntimeBeanRepository.getReferencesByTypeWithName(RuntimeBeanRepository.java:66)
Required type: interface org.apache.camel.spi.InterceptStrategy
Required qualifiers: []
Removed beans:
	- CLASS bean  [types=[class com.example.ExampleInterceptStrategy, interface org.apache.camel.spi.InterceptStrategy], qualifiers=null]
Solutions:
	- Application developers can eliminate false positives via the @Unremovable annotation
	- Extensions can eliminate false positives via build items, e.g. using the UnremovableBeanBuildItem
	- See also https://quarkus.io/guides/cdi-reference#remove_unused_beans
	- Enable the DEBUG log level to see the full stack trace
================================================================================

You can annotate the bean producer with @Unremovable. Or assign a name to bean with @Named, which automatically makes it unremovable.

Thanks @jamesnetherton
To actually add the interceptor I had to do it manually with:
getCamelContext().adapt(ExtendedCamelContext.class).addInterceptStrategy(new ExampleInterceptStrategy());

It would be nice for this to be configured automatically if there is one or more beans of type InterceptStrategy like it does for Spring Boot - https://camel.apache.org/manual/advanced-configuration-of-camelcontext-using-spring.html#_auto_configuration_of_optional_services

It would be nice for this to be configured automatically

It should already work automatically. It's a feature of camel-main.
If you register a CDI bean of type InterceptStrategy it will be resolvable by lookups on the Camel registry.
E.g if I write a producer method like:
@Named("test")
@Singleton
public InterceptStrategy test() {
    return new InterceptStrategy() {
        @Override
        public Processor wrapProcessorInInterceptors(CamelContext context, NamedNode definition, Processor target, Processor nextTarget) throws Exception {
            // Something useful here
        }
    };
}

On startup Camel reports:
Adding custom InterceptStrategy with id: test

@jamesnetherton I had my class annotated with @ApplicationScoped like the following which did not work:
@ApplicationScoped
public class ExampleInterceptStrategy implements InterceptStrategy {
  // ...
}

Adding the @Named to my previous example with @ApplicationScoped makes it work - not sure why the @Named is required with Quarkus and not Spring Boot?

not sure why the @Named is required with Quarkus and not Spring Boot?

By default, Quarkus will remove what it considers to be 'unused' beans. E.g in this case, there's no injection point for your bean (since Camel does not need one), so it's removed.
I guess the enhancement here would be for Camel Quarkus to discover any beans of type InterceptStrategy and automatically make them 'unremovable'.

I'll raise that as a separate request, thanks for all of your help @jamesnetherton


[INFORM] Allstar joining the OpenSSF Scorecard project

As part of the official chartering of the OpenSSF Scorecard project, the @ossf/scorecard-maintainers made a few decisions:

(in discussions with @jeffmendoza) to include Allstar as a project within the OpenSSF Scorecard ecosystem
to include @jeffmendoza as a member of bootstrap Steering Committee for OpenSSF Scorecard

We've asked @SecurityCRob (in his capacity as a TAC member) if there are any process requirements in transitioning a project to another WG and it sounds like the only requirements are to:

reach an agreement between the maintainers of the relevant projects
inform the outgoing Working Group of this decision

This issue is intended to:

constitute formal notice that this WG transfer is occuring
capture any WG-level items that need to be completed as part of this transfer

cc: @ossf/wg-securing-critical-projects @afmarcum

Your two points look good.  Outside of the maintainers agreeing and then notifying the two involved working groups (I informed the BEST this week about the Allstar move potential) and updating documentation (WG readme's) you should be good to go!  SUPER happy to see the synergy between Allstar and Scorecard and am eager to see what awesome stuff  you all can achieve together now!

Your two points look good. Outside of the maintainers agreeing and then notifying the two involved working groups
(I informed the BEST this week about the Allstar move potential)

I've also cross-filed this tracker in BEST: https://github.com/ossf/wg-best-practices-os-developers/issues/502

and updating documentation (WG readme's)

Added this as an item for the umbrella issue: https://github.com/ossf/scorecard/issues/4073

SUPER happy to see the synergy between Allstar and Scorecard and am eager to see what awesome stuff you all can achieve together now!

@SecurityCRob — really appreciate your support throughout this process! 💕


Request mfa devices for specific user issues 19

Proposed mitigation for https://github.com/lonelyplanet/aws-mfa/issues/19

Apologies for not having time to get the build green yet.
I'm working around this by manually creating a ~/.aws/<users>_mfa_device file containing the device id, but it would be nice to see this work automatically for users subject to tighter IAM policies.


add possibility too give token type in code and not in header

In that way it's easier to pass the value in the header

the tests failed in local for me (event before my modifications), same for you?

@artentica pulling now to test. will keep you updated


Private registry cleanup job

Issues:
https://github.com/rancher/rancher/issues/36981
https://github.com/rancher/rancher/issues/37079
https://github.com/rancher/rancher/issues/37063
https://github.com/rancher/rancher/issues/35148
Problem
Add feature flag for custom RKE1 node cleanup
It is common for users to cleanup their own custom nodes when deleting
them from Rancher. This has caused issue with jobs and/or pods being
left around or nodes not being deleted properly.
Solution
This change adds a feature flag to turn the cleanup off globally if a
user doesn't need it.
Problem
Refactor node-cleanup job implementation
It was determined that some of the code around creating and deleting the
node-cleanup job was producing unexpected results like non-nil errors
with empty error messages. In addition, the cleanup job is being
leftover in some case.
Solution
This code makes the error messages more descriptive and adds retries to
try to ensure that the cleanup job gets deleted.
Problem
Add private registry information to node cleanup job
The node cleanup job ignored cluster private registry information. This caused
issues when trying to remove nodes from a custom RKE1 cluster when private
registries were enforced by something like OPA Gatekeeper.
Solution
Now, just as with cluster agent deployment, private registry information is
added whenever needed.
Problem
If a pod is stuck because it has been scheduled on a node that node
longer exists, then deleting the job may not be enough to delete this
pod. This would cause the job deletion to hang forever.
Solution
This change deletes the pod with gradePeriodSeconds of 0 to force its
deletion.

@thedadams I'm a technical writer on the Rancher team -- a user requested documentation for rke1-custom-node-cleanup as it was accidentally left out of https://ranchermanager.docs.rancher.com/getting-started/installation-and-upgrade/installation-references/feature-flags#docusaurus_skipToContent_fallback. Presumably the default value is true as it's active on a fresh Rancher install of v2.7.2. Is it considered general availability or experimental?

@martyav , you're correct that this flag defaults to true and it was added as part of the linked issue https://github.com/rancher/rancher/issues/37065 that has the rationale on why it got added. Right around the same time we've made multiple fixes to improve the stability of node cleanup jobs and this setting was viewed as "plan B" in case the fixes don't work on some configurations (so far the fixes has been good).
So, the setting does exist and I would not consider it "experimental" per se - just one that we should only recommend changing if the user understands the consequences of disabling it. The node cleanup job was introduced to prevent situations where removed nodes may attempt to rejoin the cluster after being booted up again.
Hope this helps.
cc: @thedadams

@snasovich Thank you, was able to update and do a general refresh on the page


Delay between Command and DMA transfer start in panel_io_i80_tx_color (IDFGH-9741)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am developing code for ssd1963 through 8 bit parallel bus using the i2s in parallel mode.
The lcd is 800 x 480 and at 3 bytes per pixel I can get a 2.4 FSP throughput.  If it was just a bit faster it would be great.
Looking at the timings there is a 172uS delay from the color data being placed on the que and the DMA transmissing starting.  Is there any way to reduce this time.

which ESP target? esp32  or esp32s2? The delay may come from i2s_lcd_prepare_cmd_buffer and i2s_lcd_prepare_color_buffer because we need to change the data format, by software.

Yes that is exactly where the delay is, if I shorten the conversion loop the delay time decreases.
I am using an ESP32, is the ESP32s2 better?
I was looking to see if I could prepare the data before sending it especially for clear screen etc.
Is the parallel SPI a better option for DMA / Speed?
Thanks

SOC_I2S_TRANS_SIZE_ALIGN_WORD is only defined on esp32, we use that to express the hardware limitation. ESP32S2 and ESP32 share the same source file "esp_lcd_panel_io_i2s.c", because SOC_I2S_TRANS_SIZE_ALIGN_WORD is not defined on esp32s2, so the "data prepare path" must be shorter than esp32.

Is the parallel SPI a better option for DMA / Speed?
Will the ESP32s3 be quicker?

Yes, because we don't see such a long prepare loop in the driver. But there still be some small buffer (for LCD command, parameters) prepare, usually several bytes.

That is ace, I have an ESP32s3 here I will rework the pre-production hardware for that and test it .  Thanks for your help.


[1pt] Implement mission leaving - Actions

Follow the same logic as with the "Join mission" - but you need to set the reserved key to false.
Dispatch these actions upon click on the corresponding buttons.

https://github.com/fbclh/space-travelers/pull/30


Feature

This project was built to create the Awesome books project that we built before using ES6 and modules. Dear reviewer I have created the project to the full of my knowledge. Please check it if you got time. Thanks for your time.

@OmarRamoun Thank you dear Sir for your nice and encouraging comment I will make the changes requested as optional by you thank you so much for your help


Is there a profile validator?

In profile.go I cannot find an equivalent of validateListing for profiles. I'm assuming this is planed but not yet written.

Unlike listings, the only opportunity to validate a profile would be when the user saves it. I suppose we could do that. We would need to come up with some sizes for the fields.

What happens when the frontend requests a random profile? Shouldn't it be validated by the server  before it is manipulated by frontend JavaScript?
A key reason I'm reviewing the server validators is because at Duo Search we need the scrapers to filter out nefarious stuff.

What happens when the frontend requests a random profile? Shouldn't it be validated by the server before it is manipulated by frontend JavaScript?

I believe that @cpacia is working on a refactoring of the API to address that. See for example here.


Necessary one-liner changes required to make project working.

@kevstigneev, @alekseysemenov please review and merge.

LGTM. @alekseysemenov please merge if you agree.


Community Administrator or Collection Administrator can't add logo to collection

Describe the bug
Community Administrator or Collection Administrator can't add logo to collection. This can only be done as Site Administrator. The problem was already present in version 7.4, but in 7.5 it's the same. In addition to our own DSpace installations, trials have been done at demo7.dspace.org. Same effect.
Same effect in different browsers.
To Reproduce
Steps to reproduce the behavior:

Login as Community  or Collection Administrator
Navigate to an collection page
Edit this collection
In section Edit Metadata -> Collection Logo ->  Drop a Collection Logo to upload, or browse -> add a graphic file with the collection logo
Save
At this point, a double message appears:
Upload Collection logo successful.
Uploading Collection logo failed. Please verify the content before retrying.

Expected behavior
The case is obvious. The Collection Administrator should be able to add a logo to the collection which he is the administrator of. Similarly, the Collection Administrator to whom this collection belongs should also be able to add a logo to it.

We've recently had this reported on 7.6.

Potential PR fix for this issue was just created in https://github.com/DSpace/DSpace/pull/9320  Removing the "help wanted" flag.
Anyone who is impacted by this issue should consider testing the PR, as that would allow us to accept it more quickly.


[dev.fuzz] internal/fuzz: mutator should generate valid UTF-8 for strings

Currently, we use the same mutation engine for string and []byte. This tends to generate a lot of invalid UTF-8 strings that aren't usable for many use cases. While invalid UTF-8 is likely to turn up many shallow parser bugs, it may make the mutator less effective at finding more subtle, deeper bugs.
We should have an option to make the mutator only generate UTF-8. Some ideas:

Create a UTF8String defined type. A fuzz function that accepts that as a parameter would only get valid UTF-8 strings.
Only provide valid UTF-8 strings for string parameters. A function could request []byte for random bytes, and that can still be converted to string.

cc @golang/fuzzing @findleyr

Some ideas ...

IIUC, one of the eventual goals is to be able to fuzz structs. If so, I'm not sure either idea works as well for higher-order types, where the field type is already a string and can't be easily changed.
Perhaps there can be a method hung off of testing.F that configures parameters about the mutator?

Create a UTF8String defined type. A fuzz function that accepts that as a parameter would only get valid UTF-8 strings.

I like this idea.  We could also have ASCIIString.  I think it would be convenient to have such a mechanism, for exactly the reasons you list, but I'm wary of making it the default. Despite my comment about the readability of non-utf8 string examples, consuming arbitrary bytes DID turn up a bug that wouldn't have been found with valid characters alone (#46855).

IIUC, one of the eventual goals is to be able to fuzz structs. If so, I'm not sure either idea works as well for higher-order types, where the field type is already a string and can't be easily changed.

I wonder if fields could be explicitly ignored by the mutator, perhaps with a struct tag, so that they may be substituted by other means. I.e.
type S struct {
  Count int
  Input string `fuzz:"ignore"`
}

func fuzz(t *testing.T, s S, input fuzz.UTF8String) {
  s.Input = string(input)
  ...
}

Perhaps there can be a method hung off of testing.F that configures parameters about the mutator?

Or, we could start with trying to have the mutator automatically balance exploration and exploitation based on which kind of string (e.g. all valid utf-8 runes, mix of valid and invalid utf-8 runes, binary data) yield the best results (in terms of defects discovered) on that specific target. So e.g. if for that target the fuzzer detects that all-valid utf-8 runes strings unearth more defects, it will progressively bias the mutator to generate more all-valid utf-8 runes strings, and less of the others types of strings.
Later on, if needed, we could easily add a way to disable this auto-tuning by passing an explicit configuration as suggested by @dsnet.

Or, we could start with trying to have the mutator automatically balance exploration and exploitation based on which kind of string (e.g. all valid utf-8 runes, mix of valid and invalid utf-8 runes, binary data) yield the best results, in terms of defects discovered, on that specific target.

Essentially this is the concept behind some of the advanced fuzzing strategies discussed in #46507. Implementing input prioritization methods which focus on inputs which produce more coverage (among other characteristics) naturally biases towards mutations that produce inputs that the program understands, without actually having to alter the mutator at all.
That said there have been some discussions previously about biasing certain mutators, i.e. in order to prioritize mutators which reduce the size of inputs over those that increase the size of inputs etc. In a similar vein we may want to bias the mutators for strings, to produce inputs with valid UTF-8, over invalid UTF-8. I'd like to do some evaluation with a string based target to see how much of an effect of coverage this produces.

Only provide valid UTF-8 strings for string parameters

I don't think we should do this. There is no property in the language which states that strings must be UTF-8, and we shouldn't special case this for fuzzing.
Rob made an important point:

Despite my comment about the readability of non-utf8 string examples, consuming arbitrary bytes DID turn up a bug that wouldn't have been found with valid characters alone (#46855).

This stuck out to me because it demonstrates one of the biggest benefits of fuzzing: the mutator is able to generate inputs to f.Fuzz that are vastly different from what you may have assumed is "valid input". Limiting to UTF-8 by default would take away from this.
A few general thoughts:

https://go.googlesource.com/proposal/+/master/design/draft-fuzzing.md#custom-generators talks a bit about what a custom generator might look like with the current design (once structs are supported). We could provide our own set of custom generators in the testing package in the future, including one for UTF-8-only strings
I also wonder if testing/quick would make more sense for inputs like this which have very specific generator needs.

Is there anything else to discuss on this issue, or are we okay with closing it?

Let's close. I think we're in agreement that UTF-8 by default is not a good idea. Custom mutators or defined types are appealing, but let's open an issue for those when we have a design.


Tutorial: generics, nullable constraints and nullable attributes

In this tutorial, explain how to annotate a generic class, and a set of generic methods using the notnull constraints, and related attributes:

AllowNull
DisallowNull
MaybeNull, MaybeNullWhen(bool)
NotNull, NotNullWhen(bool)
NotNullIfNotNull(string)

Fixed in #13659


Updating Card view styles

@haroon-sheikh PFA

@haroon-sheikh , Please review and provide feedback if any

@haroon-sheikh Updated screenshot attached

@sachinttn9663 You've added a cardview list to commit history.. But we need to also add that for the projectlist.

I think you should merge it, will create another PR fot that
On Mon, 5 Oct, 2020, 2:45 PM Haroon Sheikh<EMAIL_ADDRESS>wrote:

@sachinttn9663 https://github.com/sachinttn9663 You've added a cardview
list to commit history.. But we need to also add that for the projectlist.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sitture/commit-status/pull/64#issuecomment-703508413,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APGTLHPUQ7QDT24BUKQTILDSJGFCVANCNFSM4SDZA7PA
.

Your changes should now be live at https://commit-status.herokuapp.com/


Can't upload a folder to a hosted storage location

I'm using our laminlabs/lamin-dev instance.

Single objects upload fine, trying to upload any folder fails silently on the low level API.
Am debugging.

I suspect that it's yet another weird issue that results from how AWS permissions on a folder level are done and what fsspec expects in the async upload.

I need to ship a solution for the hackathon next week and I fear I'll for now build it around a single bucket storage location.


With in half an hour have three times with out work when edit html

VSCode Version: Code 1.5.3 (5be4091987a98e3870d89d630eb87be6d9bafd27, 2016-09-22T08:50:42.185Z)
OS Version: Windows_NT ia32 10.0.14393

Steps to Reproduce:

2.when have the BUG as the figure shows, the edit box will not work,but the menu bar will still work.
if close VS code ,the file not saved will lost.

@bpasero fyi it's the not responding dialog

@WinxEI any steps to reproduce?

@WinxEI can you try running VS Code via code --verbose and see if there is some exception printed to the console when it crashes?

A number of days has past without answer on the questions asked. I am thereby going to close this issue to clean up our backlog of issues. Once you can answer on the questions, the issue can be reopened again. Thanks for understanding this process!


Make noise generation resolution aware

Implements footprint based noise generation. I originally intended to also fix the Mandelbrot node in this pr but it turns out  that the node itself was never broken and it only stopped working due to an regression somewhere else which has since been fixed.
Changes:

Remove dimension parameter
The dimensions are new inferred from the footprint
Add clip parameter
The user can now choose if they want to constrain the noise

Alternatives considered

Make dimension optional
We could instead make the dimension parameter optional, which would eliminate the need for a transform node after the noise node. This might provide a nicer to use api and could be implemented in a follow-up pr.

We now only render what is visible on the screen and also support clipping to the viewport itself:

Nice! That's also great to see the Mandelbrot node has gotten fixed already too. My observation is that we'll want to remove the "Clip" parameter so it's always boundless, and always have it be infinite, then use clipping masks or other nodes to actually constrain the bounds as the user desires. We'll also want to inverse the Scale parameter, I think.

Nice! That's also great to see the Mandelbrot node has gotten fixed already too. My observation is that we'll want to remove the "Clip" parameter so it's always boundless, and always have it be infinite, then use clipping masks or other nodes to actually constrain the bounds as the user desires. We'll also want to inverse the Scale parameter, I think.

 This would even evaluate the texture if the artboard is not even in view.

We'll also want to inverse the Scale parameter, I think.
So using 1./scale ? We could instead rename scale to frequency, as we now just pass the value through instead of dividing it by some magic constant


Use apiKey for authentication over username/password

Thanks for publishing this library.
As I was not feeling very comfortable with using my credentials for authentication I've opted to refactor it to use the API Key that is available in Docker Cloud.

Please ignore this PR as I submitted it too soon, I've tested the wrong version.

Thanks for taking an interest. I am going to improve this library more to cover entire api, as well as provide a better documentation.


Fix. Ensure masked value fit to byte.

See #61

Tested on Travis

I dont think this is neccassary:

0>= mask[j] <= 255 is guarenteed (https://github.com/moteus/lua-websockets/blob/fix-lua52-compat/src/websocket/frame.lua#L85)
0 >= original[i] <= 255 since original is returned by string.byte

Maybe i dont fully understand this, but this a hotspot and every function call at this point has its cost.

I also thik the same but on travis I get lua: /usr/local/share/lua/5.1/websocket/frame.lua:45: bad argument #2 to 'schar' (invalid value) (https://travis-ci.org/moteus/lua-lluv-websocket/builds/53169714)
And with this patch all works (https://travis-ci.org/moteus/lua-lluv-websocket/builds/53181730)
I really did not know why. For now I have only Win XP/2k3

I think i found problem. You unpack mask as signed value and bxor(-XX, v) propogate signed bits.
Now all tests passed

:8ball: NICE!


Make AnimateViewHolder an interface instead of a subclass of ViewHolder

This will help ViewHolder just need to implement this class and can be a subclass of another ViewHolder in the app. What do you think?
Thanks for the library.
Thuy

👍


Question: using vncdotool under multiprocess

[x] VNC server and version: tightvncserver running in a ubuntu:18.04 docker container
[x] vncdotool version d7a98e2925ac2885ffdd6996cbd0491e3e2d6759
[ ] steps to reproduce

Is it possible that using vncdotool in a subprocess spawned by multiprocess module causes an issue?
It seems queue.get in api.py (in proxy_call) times out.
The issue does not occur when I limit the number of subprocesses to be 1.
architecture sketch below
+ main process
   + subprocess1
      -> api.connect(server1::port1, password=XXX, timeout=5)
      -> mouseMove, etc. -> times out
   + subprocess2
      -> api.connect(server1::port2, password=XXX, timeout=5)  # connected to a different VNC server inside a docker container
      -> mouseMove, etc. -> times out

Disconnecting & reconnecting to the same port sometimes works, but it is very unreliable, and it eventually stops working.

I'm not aware of any reason this wouldn't work. Some vncservers have a setting that only allow a single connection.

Each vncserver is a separate instance in a separate docker container, no one else is connecting to them, i.e. guaranteed to be a single connection.

In other words, I have multiple vncservers running at the same time, each running in completely separate docker containers, and trying to mass-control them in parallel (using multiprocess) from a single python program.

Running multiple processes in parallel results in each process getting less CPU time. Forking and exec()uting a new Python process is resource intensive, so timeout=5 might be too low for you case; try to increase that.
Also consider using os.fork() instead of subprocess or use threading as the Twisted reactor supports handling multiple connections to different VNC servers at the same time already.
Other than that no issue is known. I'm closing this issue therefore. If you still encounter that issue, please feel free to re-open this issue or to create a new issue.


Add include path to Rust build script

@jroesch
I'm not sure what we want to do here. I needed to add this path to make the build script work on my system -- perhaps there's something I should do on my side, though?

Could you post the error message you get when building?

error: failed to run custom build command for `tvm-sys v0.1.0 (https://github.com/apache/incubator-tvm?branch=main#4c4888bc)`

Caused by:
  process didn't exit successfully: `/home/gus/glenside-evaluation/target/debug/build/tvm-sys-6e86f41bfc277513/build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-env-changed=TVM_HOME
  cargo:rustc-link-lib=dylib=tvm
  cargo:rustc-link-search=/home/gus/tvm/build

  --- stderr
  /home/gus/tvm/3rdparty/dlpack/include/dlpack/dlpack.h:30:10: fatal error: 'stddef.h' file not found
  /home/gus/tvm/3rdparty/dlpack/include/dlpack/dlpack.h:30:10: fatal error: 'stddef.h' file not found, err: true
  Error: failed to generate bindings

Yeah, I agree that it doesn't seem to make sense. I'm having a hell of a time resolving this on one of our machines, and I have to assume it's because of how the machine is configured. We have stddef.h (multiple, in fact) but I have no idea which toolchain rust is trying to use here, so I don't know which one it's failing to find.
It seems to be happening in bindgen, and there's a running thread about issues like this: https://github.com/rust-lang/rust-bindgen/issues/1226. It seems like it's not actually an issue on their side, but it's common when using bindgen.

Have you tried specifying LLVM_CONFIG_PATH?

Yes, it's set! I think I was getting a different error before I realized I needed to set that.

Closing, glad that the problem is resolved

Oops, this problem isn't resolved! Sorry, didn't mean to imply that. I had already set LLVM_CONFIG_PATH before getting this error.

In this case it is indeed versy strange that stddef is not part of your include path, how about you add it to your CPLUS_INCLUDE_PATH and C_INCLUDE_PATH env variable in your system?

I have, to seemingly no effect. I'll bug our sysadmin about this. It must
be on my side.
On Wed, Oct 28, 2020 at 4:23 PM Tianqi Chen<EMAIL_ADDRESS>wrote:

In this case it is indeed versy strange that stddef is not part of your
include path, how about you add it to your CPLUS_INCLUDE_PATH and
C_INCLUDE_PATH env variable in your system?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-tvm/pull/6765#issuecomment-718264432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFZAKQIN4YXDUNFVHLUGTSNCRXNANCNFSM4S7ZXP4Q
.


feat: add AnySupport type tag

Motivation
The PR adds a type tag that can be used to tag the Node type parameter in the unmarshallers, as can be seen here. The tag is a safety mechanism ensuring that the correct unmarshaller is being used.
P. S. this PR is part of the solution to this issue.

me and @yanns found a way to make federation possible for Sangria without having to make this change, the implementation :) can be found here


Add an onTap Example

https://github.com/apptreesoftware/flutter_map/issues/101

Added an example page, see #103.


Fixes go vet errors

Addressing https://github.com/kubeflow/tf-operator/issues/395.
There are some errors in our code but it won't caught by the compilers
$ go vet $(go list ./... | grep -v /vendor/)

Output:
cmd/tf-operator/app/server.go:129: unreachable code
exit status 1
dashboard/backend/handler/api_handler.go:36: struct field tfJobs has json tag but is not exported
dashboard/backend/handler/api_handler.go:41: struct field namespaces has json tag but is not exported
exit status 1

This change is

/ok-to-test
This should be good to merge as soon as the tests pass.
@swiftdiaries Would be good if you could sync.

Pull Request Test Coverage Report for Build 868

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 31.856%

Totals

Change from base Build 861:
0.1%

Covered Lines:
582

Relevant Lines:
1827

💛  - Coveralls


fix(assert): Merge _eq and _matches via Data::raw

With the new eq_ variants (to not break compatibility), we switched
param order as part of the path to #226
Cherry pick of #291

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

54 of 78 (69.23%)  changed or added relevant lines in 8 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.9%) to 51.878%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/snapbox/src/harness.rs
0
1
0.0%

crates/snapbox/src/lib.rs
1
2
50.0%

crates/snapbox/src/assert/mod.rs
20
24
83.33%

crates/snapbox/src/data/source.rs
0
4
0.0%

crates/snapbox/src/cmd.rs
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

crates/snapbox/src/assert/mod.rs
3
28.57%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
1340

Relevant Lines:
2583

💛  - Coveralls


⚠ Mobitopup has degraded performance

In 1d98b7c, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 26534 ms

Resolved: Mobitopup performance has improved in af3fa47.


Handle non-success error codes in healthcheck

PR fixes #1593
What is being addressed
When the App Gateway returns a 502 Bad Gateway response, the body is HTML rather than JSON and we get an error: parse error: Invalid numeric literal at line 1, column 7
How is this addressed
This PR changes the healthcheck to only attempt to parse response as JSON for 200 success responses. This avoids attempting to parse HTML from 502 Bad Gateway responses as JSON.

/test

/test
Previous run got the 502 Bad Gateway which confirmed the PR fixes the error output!
Re-running in the hope that the Bad Gateway is resolved to test the success path

/test
Previous run got Gateway timeout on registering bundles

/test


Rename example files without spec version number

… to simplify comparison between version branches in the future (see https://github.com/AMWA-TV/nmos-discovery-registration/commit/8a00534a1fb8a5f89d6404f99aa4483209963e78 and https://github.com/AMWA-TV/nmos-device-connection-management/commit/1d21176ccbd165d2f6f28fc2db2b0c23c974bf06 for precedent), and delete 'eventsapi' from the filename of command and message examples.

Yes, that does appear to be the case. We could add the additional examples for the /type and /state endpoints in the RAML, but I didn't do that here. The example message and command files could be referenced from the docs, but there are embedded examples in most places already.

Looks good to me, do we have to be careful when to do the merge to avoid the conflicts? (given files were renamed)

ASAP? 😉
Since it's only the example files which only see infrequent editing and very few of which are referenced currently, it's not hugely urgent, but certainly better to do for a v1.0.1, so that a rebranched v1.1-dev (if we go that way) and future version bumps show simpler diffs.


Deployment with Azure docs not visible in RTD

What should we add?
In the Server Deployment section of the docs, the "Cloud Deployment" section only lists AWS. However, the docs folder also has instructions for deployment with Azure, which is otherwise not visible since it's not included in the index.rst. The deploy_with_azure.rst should be added to the index.rst as a card alongside AWS.
Also, I'm not sure if you wanted to include the Version Migration Guide in the "User Documentation" side-panel or not, but I don't think it's currently visible. I imagine this was also an accidental omission.
I'd open the PR myself but I'm not super experienced with rst and am running a bit short on time at the moment...

Hi @arosen93, great observation! Unfortunately, we're still testing the deployment with Azure at deployment with Azure and it's not available to the public yet. Our team is working hard to make sure everything is running smoothly and up to our standards. Once it's ready, we'll have everything you need at the click of a button, including the documentation, corresponding image, and plugin. If you're an Azure user and want more information, just let us know through Slack in Covalent. We'd be happy to give you access to the alpha version !

Oh, guess I was early! I'll close this then :) wanted to make sure that hard work wasn't hidden.
I assume the same goes for Google Batch?


Deploy to production documentation

Need to have complete documentation on what to do to setup your own booklogr service.
I'm thinking a good start would be a quite opinionated documentation that would be exactly how I deploy my own (nginx, docker etc) but later on can be updated with more options.

Install instructions are now available, https://github.com/Mozzo1000/booklogr/wiki/Install-with-Docker/35809312e13d7d0ae73c534158de88f33e266ac4


[Bug Report] Invalid Status Code

Describe the bug
Simply put, trying to play a song, the bot will just join and then leave.
To Reproduce
Steps to reproduce the behavior:

Play a song.
Bot will join and print the song with it's length.
Bot then leaves.

Expected behavior
The song is to play and function as normal.
Version Info (please complete the following information):

Operating System: Ubuntu 16.04.4 LTS
JMusicBot Version: 0.2.5

Additional context
Here's the error being reported below. The bot is only in 3 discord servers, none of which are utilizing the music element at the moment. The bot simply stopped working with no adaptations to the bot or server in any kind.
The logging used is from PM2, hence why it differs to what you're used to. Still logs in the same way.
9|NexusMusic  | [03:33:59] [ERROR] [LocalAudioTrackExecutor]: Error in playback of tbvwdv385Pg
9|NexusMusic  | com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Something broke when playing the track.
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.tools.ExceptionTools.wrapUnfriendlyExceptions(ExceptionTools.java:43)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:102)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$1(DefaultAudioPlayerManager.java:349)
9|NexusMusic  |         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
9|NexusMusic  |         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
9|NexusMusic  |         at java.lang.Thread.run(Thread.java:748)
9|NexusMusic  | Caused by: java.io.IOException: Invalid status code for video info response: 429
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.determineFailureReason(YoutubeAudioSourceManager.java:401)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioSourceManager.getTrackInfoFromMainPage(YoutubeAudioSourceManager.java:390)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.getTrackInfo(YoutubeAudioTrack.java:118)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.loadBestFormatWithUrl(YoutubeAudioTrack.java:96)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.process(YoutubeAudioTrack.java:63)
9|NexusMusic  |         at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:90)
9|NexusMusic  |         ... 4 common frames omitted

The issue is that Toutube is ratelimiting the bot, and there isn't anything that can be fixed on my end to prevent this. Is there anything else running on the VPS or same IP address as this bot? Where is it being hosted?

No sir, it was working perfectly fine for a solid few months. I can try closing down all additional bots and see if that causes an issue but as far as I'm aware, none use lavaplayer (RedBot does, but the audio module is disabled).
This is running off my dedicated machine which I've been using your bot on for a good year now. For some reason, it just clogged up and stopped working. I'll do some slight more debugging and get back to you but it's very odd how it just decided to stop working.

Yeah, I turned all other instances of a discord bot offline and it still has the issue. Is there such thing of a cooldown with YouTube where it's been rate limited so much that it just needs to sit idle/offline? I'm unsure as how this occurred as nothing has changed.

youtube is being more aggressive and are rate limiting music bots so its more likely that.

Yes. Large music bots such as Rythm can't play anything from YouTube anymore due to these rate limits YouTube recently put.

Closing as I'm centralizing all issues related to this in #305