Default Integrated Terminal Shell sometimes not used on launch for remote workspaces

Issue Type: Bug
Opening VS Code automatically creates an integrated shell window, which is what I want. However, despite setting the "cmd.exe" shell as the default and commenting out the other options that only the "Command Prompt" shell is listed to create another terminal windows, the automatically created integrated shell window opens with PowerShell. I don't want PowerShell. If I add another terminal window, then that new window uses the "Command Prompt" shell.
VS Code version: Code 1.58.1 (2aeda6b18e13c4f4f9edf6667158a6b8d408874b, 2021-07-13T06:58:28.115Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2904)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (4.44GB free)

Process Argv
--crash-reporter-id d17dcf09-a9c2-4505-9b94-904b43e5d3ee

Screen Reader
no

VM
0%

Not a duplicate of suggestion as I am not splitting the terminal window. My issue pertains to initially created terminal window upon VS Code launch.

I searched for and found this issue is the same, just with different default settings. You can see in the dropdown that Git is my default shell, but after updating VSCode today it reopened with Powershell terminal for some reason. This has happened for several updates now.

Have same problem. If VSC exits with at least one Integrated Terminal running, it will re-run a single Integrated Termianl on startup. However it will not re-run any of the profiles that were previously running, nor the current default profile - it will just re-run the out-of-the-box default (in my case, vanilla bash to WSL2). Would be good to at least re-run the current default profile (best), or else have an option to not remember that an Integrated Terminal was running previously (OK).

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

Hi Megan,
Yes, can reproduce, still happens on the Insiders build (1.59.0-insider).
David
On Wed, 28 Jul 2021, at 2:03 AM, Megan Rogge wrote:

I believe this is already fixed, can you see if you can reproduce in the Insiders build https://code.visualstudio.com/insiders?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/128763#issuecomment-887637981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJIVXYZHTKQQFFEF2BQLBLTZ3KGVANCNFSM5ANYZ7RQ.

Hi, I am experiencing the same problem as reported above with Visual - see attached reproduction of the issue in a little movie.
It would be great if there were a fix for that issue, which is a blocking one on my project. Thanks, Anais
https://user-images.githubusercontent.com/88326298/127863240-04b1ca9e-4333-49a0-9bf1-fcac12ea37d1.mp4

i can't repro tihis. pls provide me with your settings @amalaussena

https://github.com/microsoft/vscode/issues/129971
Anais Malaussena
Solution Architect Facilities Management CoE | 4614
European Patent Office
Bob-van-Benthem-Platz 1 | 80469 Munich | Germany
Tel. +49 (0)89 2399 5905
Mobile +49<PHONE_NUMBER>6
<EMAIL_ADDRESS>www.epo.orghttp://www.epo.org
Please consider the environment before printing this email.
From: Megan Rogge @.>
Sent: 02 August 2021 17:12
To: microsoft/vscode @.>
Cc: Anais Malaussena @.>; Mention @.>
Subject: Re: [microsoft/vscode] Default Integrated Terminal Shell (#128763)
i can't repro tihis. pls provide me with your settings @amalaussenahttps://github.com/amalaussena
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/128763#issuecomment-891107092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVB4BGWEAFY6ABHBETD525DT22YVZANCNFSM5ANYZ7RQ.

can anyone provide me with their user settings? to do this, ctrl + comma and click the document looking button. copy that file

I'm not sure how @amalaussena 's video shows the problem? The problem happens when VSC launches (as the OP said), and that is not in the video. Anyway, my settings are below. I've pasted both User and Workspace as I have settings across both. And the terminal settings are in Workspace at the bottom. Hope this helps!
User
{
"files.associations": {
".cform": "yaml",
".gql": "graphql"
},
"yaml.customTags": [
"!And",
"!And sequence",
"!If",
"!If sequence",
"!Not",
"!Not sequence",
"!Equals",
"!Equals sequence",
"!Or",
"!Or sequence",
"!FindInMap",
"!FindInMap sequence",
"!Base64",
"!Join",
"!Join sequence",
"!Cidr",
"!Ref",
"!Sub",
"!Sub sequence",
"!GetAtt",
"!GetAZs",
"!ImportValue",
"!ImportValue sequence",
"!Select",
"!Select sequence",
"!Split",
"!Split sequence"
],
"yaml.validate": false,
"timeline.excludeSources": [],
"aws.samcli.location": "/home/linuxbrew/.linuxbrew/bin/sam",
"git.enableSmartCommit": true,
"git.confirmSync": false,
"explorer.confirmDragAndDrop": false,
"aws.onDefaultRegionMissing": "ignore",
"aws.profile": "profile:default",
"eslint.validate": [
"javascript",
"javascriptreact",
"vue"
],
"terminal.integrated.copyOnSelection": true,
"python.terminal.activateEnvironment": false,
"remote.SSH.remotePlatform": {
"emma": "linux",
"emma_media": "linux"
},
"workbench.editorAssociations": {
"*.ipynb": "jupyter-notebook"
},
"javascript.updateImportsOnFileMove.enabled": "never",
"python.languageServer": "Pylance",
"redhat.telemetry.enabled": false,
"notebook.cellToolbarLocation": {
"default": "right",
"jupyter-notebook": "left"
}
}
Workspace
{
"folders": [
{
"path": ".."
}
],
"settings": {
"python.pythonPath": ".venv/bin/python",
"python.linting.pylintEnabled": true,
"python.linting.enabled": true,
"cfnLint.path": "./.venv/bin/cfn-lint",
"editor.rulers": [
100
],
"terminal.integrated.profiles.linux": {
"Project": {
"path": "bash",
"args": [
"--rcfile",
"${workspaceFolder}/.bashrc"
]
}
},
"terminal.integrated.defaultProfile.linux": "Project"
}
}

Hi @aupsloptp thanks for your help in this issue.  The issue is that even if bash is set as the default terminal, when opening a new terminal VSC always selects cmd and there is no way to change this.  This is the behaviour I tried to show in the video.
Based on your settings, are you able to switch from terminal shell eg. either cmd or powershell or bash?  It yes, I would be interested to know what is the difference between your settings and mine?  Thank you and Best Regards, Anais

I have the similar issue after last update: 1.60.0-insider.
Default profile option is still broken.

As mentioned above - issue can be reproduced in latest Insiders build
Setting "Command Prompt" or "Git Bash" to terminal.integrated.defaultProfile.windows still launches PowerShell
// "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
// "terminal.integrated.shellArgs.windows": ["--login", "-i"],
"terminal.integrated.profiles.windows": {
    "PowerShell": {
        "source": "PowerShell",
        "icon": "terminal-powershell"
    },
    "Command Prompt": {
        "path": [
            "${env:windir}\\Sysnative\\cmd.exe",
            "${env:windir}\\System32\\cmd.exe"
        ],
        "args": [],
        "icon": "terminal-cmd"
    },
    "Git Bash": {
        "source": "Git Bash"
    }
},
"terminal.integrated.defaultProfile.windows": "Git Bash",

terminal.integrated.profiles.windows is default configuration when you autocomplete this setting in settings.json file.
Old *shell* values are commented out.
Version: 1.60.0-insider (user setup)
Commit: 49af1cbe00271ac2ea36cfc5f7352fe31a7b0094
Date: 2021-08-06T06:41:50.275Z
OS: Windows_NT x64 10.0.19041

in insider's today, there's an issue with the default profile that will be fixed tomorrow - https://github.com/microsoft/vscode/issues/130268
I just re-read the OP description and think I now understand your problem. Commenting out the other shells won't work. You need to set them to null in order to remove them from appearing in the dropdown.
Please let me know if you are still seeing issues with this in tomorrow's insider's.

@meganrogge Can you please comment on the OP's post:

Not a duplicate of suggestion as I am not splitting the terminal window. My issue pertains to initially created terminal window upon VS Code launch.

The key words are "upon VS Code launch".
It does appear that somehow we are now looking at a different problem (the PowerShell one). Note that the OP also says "the automatically created integrated shell window". The problem as the OP described (and me) ONLY happens on VSC launch, not as @IllusionMH described.
See my original post, I am pretty sure that aligns with the OP. If the general consensus is not, then no problem, I will raise a new issue.

Can confim happening on launch as @aupsloptp
Can confim it still happens after setting the default, and opening a new terminal as @IllusionMH

Can confim happening on launch as @aupsloptp
Can confim it still happens after setting the default, and opening a new terminal as @IllusionMH

Can't repro, but seems like some people are seeing this still

@meganrogge there was no Insiders release with 690ff9e55e
I guess next will be Monday morning.

OK, I've had a bit of time to do some debugging here. It looks like the "launch" issue only happens when remote, e.g. WSL or SSH. Steps to reproduce:

Go to Remote Explorer
Connect to WSL or SSH
New window opens with "bash" as integrated terminal type
Select default profile of "tmux" (or anything else besides "bash")
Open new terminal, check that new profile is run instead of old default
Close all terminals
Open new terminal, again should be new profile as expected
Exit VSC (with that single integrated terminal running)
Run VSC
Should start up with integrated terminal, BUT it will be "bash" (not "tmux or whatever you chose as the default)
Confirm the actual default is still valid by firing up a new terminal

If you do the above steps for local (Windows) with say, Command Prompt and PowerShell, there is no bug (i.e. the default terminal is properly used when VSC starts up).
So maybe the issue is in the extensions? That's why it just occurs "sometimes", it depends on the last workspace you used?

It seems related with settings.json on remote machine.
I have one "special" linux box, there is no any shell in PATH, so I create a new profile and set absolute path, in remote machine setting, then set it default.
VSCode never run default shell at first, including auto-start when window open, and manually switch to terminal tab.
But it works without any issue from the second one.

I have been living with the default PowerShell since making this report, but decided to try again to correctly set Command Prompt as default shell on launch. The first image (entitled "Broke") was of my Integrated Profile definitions in settings.json, and the second (entitled "Fixed") is of those definitions now. It seems that the acceptable input for arguments had changed, because now VSC opens a Command Prompt terminal upon launch instead of PowerShell.

I am not using a remote workspace and still have this issue (I don't even know what a remote workspace is).

@vaindil What is your default terminal profile?

@meganrogge Here's a little clue too: If I change the default shell for the user outside of VSC (e.g. via chsh) on WSL (or SSH), then when VSC launches to WSL/SSH, it runs this new default shell. It really does look like that - on launch, to restore an integrated terminal - VSC just runs the default shell of WSL/SSH, be that bash/fish/whatever, and ignores the VSC default shell setting.

Even after 690ff9e, I was having an issue where it now recognized the default terminal profile after the terminal has been killed and reopened, but not when a project was first opened.
Turned out to be some kind of caching issue.  I was able to resolve by killing all terminals in the project (not just minimizing, but actually killing w/the trashcan icon), closing Insiders and then reopening it to that project.
Everything seems to be back to normal with the default profile for me now 👍

I have the same issue, when starting vs code, it does not open the terminal with the default shell but rather opens a different shell.
My settings json:
{
    "git.enableSmartCommit": true,
    "editor.fontFamily": "'Cascadia Code', Consolas, Monaco, 'Courier New', monospace",
    "editor.fontLigatures": true,
    "javascript.updateImportsOnFileMove.enabled": "always",
    "[html]": {
        "editor.defaultFormatter": "vscode.html-language-features"
    },
    "[javascript]": {
        "editor.defaultFormatter": "vscode.typescript-language-features"
    },
    "[jsonc]": {
        "editor.defaultFormatter": "vscode.json-language-features"
    },
    "css.lint.duplicateProperties": "warning",
    "css.lint.float": "warning",
    "editor.insertSpaces": false,
    "editor.tabSize": 4,
    "prettier.tabWidth": 4,
    "terminal.integrated.env.windows": {
    },
    "editor.accessibilitySupport": "off",
    "window.zoomLevel": 1,
    "[typescript]": {
        "editor.defaultFormatter": "vscode.typescript-language-features"
    },
    "editor.suggestSelection": "first",
    "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
    "git.autofetch": true,
    "typescript.updateImportsOnFileMove.enabled": "always",
    "[json]": {
        "editor.defaultFormatter": "vscode.json-language-features"
    },
    "git.confirmSync": false,
    "diffEditor.ignoreTrimWhitespace": false,
    "editor.inlineSuggest.enabled": true,
    "github.copilot.list.count": 10,
    "editor.autoClosingBrackets": "never",
    "github.copilot.enable": {
        "*": false,
        "yaml": false,
        "plaintext": false,
        "markdown": false
    },
    "files.exclude": {
        "**/.classpath": true,
        "**/.project": true,
        "**/.settings": true,
        "**/.factorypath": true
    },
    "terminal.integrated.defaultProfile.osx": "pwsh",
    "terminal.integrated.defaultProfile.windows": "pwsh",
}

Version: 1.60.0-insider (Universal)
Commit: 71b299184f7908491345aec5e231599c3ae8753b

After the newest upgrade, the vscode can startup with default terminal command prompt now. But when I debug the python code, it is still using the default powershell which cannot activate conda env. It can use the default terminal profile when debugging in 1.59.

rshell which cannot activate conda env. It can use the default terminal

I have the same problem, all my tasks in tasks.json don't work because they are being executed in Powershell, not Git Bash (and I have set Git Bash as the default).

@vaindil What is your default terminal profile?

These are my only settings.json lines that have terminal in them (other than a bunch of color stuff):
"terminal.integrated.profiles.windows": {
  "cmder": {
    "path": "C:\\WINDOWS\\System32\\cmd.exe",
    "args": [
      "/K",
      "C:\\path\\Cmder\\vendor\\bin\\vscode_init.cmd"
    ]
  }
},
"terminal.integrated.defaultProfile.windows": "cmder",

Looks like startup case (when Terminal view is visible when application starts) partially related to #130268
In #130268 new logic to get find default profile if one is not passed to createTerminal was added
https://github.com/microsoft/vscode/blob/0e4ddedb183449624754360c53320c6db96cde1f/src/vs/workbench/contrib/terminal/browser/terminalService.ts#L1111
However if terminal view is visible then createTerminal will immediately called when UI loads. And it will be before _detectProfiles finishes in first _refreshAvailableProfiles call and . Therefore this._availableProfiles will be undefined during initial call and PowerShell will be launched on Windows (with other default for different OS).
https://github.com/microsoft/vscode/blob/0e4ddedb183449624754360c53320c6db96cde1f/src/vs/workbench/contrib/terminal/browser/terminalService.ts#L490-L495

If I add console.log in few places (see details below) it's noticeable why this happens.
Results for case when Terminal view not visible at launch (e.g. Search panel active)
<start with Search tab active>

_refreshAvailableProfiles called
_detectProfiles finished Array(4)
_refreshAvailableProfiles called
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]

<clicked on Terminal tab>

_refreshAvailableProfiles called
createTerminal called {options: {…}, config: {…}, shellLaunchConfig: {…}}
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]
_refreshAvailableProfiles called
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]

In this case Git Bash (my default profile) launched as expected.

On the other hand if Terminal tab active when user launches VS Code app (close VS Code keeping Terminal tab active with Git Bash and launch again)
<start with Terminal tab active>

_refreshAvailableProfiles called
createTerminal called {options: {…}, config: undefined, shellLaunchConfig: {…}} <-- config: undefined instead of Git Bash profile object
_detectProfiles finished (4) [{…}, {…}, {…}, {…}] <-- finishes after createTerminal wasn't able to find default profile
_refreshAvailableProfiles called
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]

<click on + button to create new terminal>

createTerminal called {options: {…}, config: {…}, shellLaunchConfig: {…}} <-- config: {...} - correct Git Bash profile object
_refreshAvailableProfiles called
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]
_refreshAvailableProfiles called
_detectProfiles finished (4) [{…}, {…}, {…}, {…}]

As result first terminal that I see it PowerShell and then Git Bash is created by click on +

 console.log updates
private async _refreshAvailableProfiles(): Promise<void> {
	console.log('_refreshAvailableProfiles called');
	const result = await this._detectProfiles();
	console.log('_detectProfiles finished', result);
        ...

async createTerminal(options?: ICreateTerminalOptions): Promise<ITerminalInstance> {
	const config = options?.config || this._availableProfiles?.find(p => p.profileName === this._defaultProfileName);
	const shellLaunchConfig = config && 'extensionIdentifier' in config ? {} : this._convertProfileToShellLaunchConfig(config || {});
	console.log('createTerminal called', { options, config, shellLaunchConfig });
	...

@IllusionMH I like! Sounds like you've found it. That might also explain why only WSL/SSH sessions seemed to fail for me when I ran some tests, and not local. Local startups are faster & it may be that the profiles info is loaded in time for the correct terminal profile to be selected. With WSL/SSH there may be extra overhead that forces createTerminal to choose whatever it can.

The recent insider release still open powershell instead of using the default terminal from settings at startup and task running.

Also have Git Bash configured as the default profile, however powershell launches on VS Code start-up. Running the latest version of VS Code insiders:

For me  when (re)launching VSCode with terminal opened the powerShell shows, but if terminal is closed and then manually opened (ctrl + ç then my default profile (git bash) is shown

For me when (re)launching VSCode with terminal opened the powerShell shows, but if terminal is closed and then manually opened (ctrl + ç) then my default profile (git bash) is shown

This can be reproduced on my machine with the following settings:
    "terminal.integrated.profiles.windows": {         "PowerShell": {             "source": "PowerShell",             "icon": "terminal-powershell"         },         "Command Prompt": {             "path": [                 "${env:windir}\\Sysnative\\cmd.exe",                 "${env:windir}\\System32\\cmd.exe"             ],             "args": [],             "icon": "terminal-cmd"         },         "Git Bash": {             "source": "Git Bash",             "icon": "terminal-bash"         },     },     "terminal.integrated.defaultProfile.windows": "Git Bash",
Opening a Project directory from Explorer with VS Code launches Code with a PowerShell terminal window. After deleting the PowerShell window (with delete button), and relaunching terminal Ctrl-`   it reverts to Selected Git bash profile.
A temporary solution until this is fixed is to prevent the PowerShell profile from appearing in the menu by setting its source to "null"
        "PowerShell": {             "source": "null",             "icon": "terminal-powershell"         },
Thereby allowing Git Bash to open again by default.

"terminal.integrated.profiles.windows": {
    "PowerShell": {
        "source": "PowerShell",
        "icon": "terminal-powershell"
    },
    "Command Prompt": {
        "path": [
            "${env:windir}\\Sysnative\\cmd.exe",
            "${env:windir}\\System32\\cmd.exe"
        ],
        "args": [],
        "icon": "terminal-cmd"
    },
    "Git Bash": {
        "source": "Git Bash",
        "icon": "terminal-bash"
    },
},

It doesn't work setting "null" , it is even an invalid value

Opening a Project directory from Explorer with VS Code launches Code with a PowerShell terminal window. After deleting the PowerShell window (with delete button), and relaunching terminal Ctrl-` it reverts to Selected Git bash profile.
A temporary solution until this is fixed is to prevent the PowerShell profile from appearing in the menu by setting its source to "null"
"PowerShell": { "source": "null", "icon": "terminal-powershell" },
Thereby allowing Git Bash to open again by default.

It doesn't work setting "null" , it is even an invalid value

Only workaround i found (after hours of thread reading and trying to edit settings.json with no success in getting it to stick) was downgrading to 1.59 where it functions perfectly, i didn't even know auto upgrades were a thing for vscode, all i know is i was working on a project just fine then later in the afternoon reopened vscode and this extremely annoying thing was happening. I am scared to death of auto updates and to update vscode period because it does this on the stable build as well, directly from the site. I have since now disabled auto updates.  I am a coding student who is just now graduating school so my familiarity with vscode is very limited.

Having this issue after an auto update as well. Having issues with Windows 10 64 bit ignoring my default profile and opening up powershell.

Having this issue after an auto update as well. Having issues with Windows 10 64 bit ignoring my default profile and opening up powershell.

Reinstall version 1.59 over the top of 1.60 and disable auto updates, that is what i have resorted to as a work around, just go into your settings and type update and disable them, except the extensions. I didn't lose anything by downgrading this way thank god, it was absolutely driving me nuts though not being able to set it to default and having powershell open for everything regardless of which one i chose.

I can report that I'm having the same issue. Rolled back to 1.59 and default shell as Git Bash works again. I also added "update.mode": "none" to settings.json

I can confirm, using 1.60.0 still opens using powershell upon launch.
{
    "workbench.startupEditor": "newUntitledFile",
    "files.autoSave": "afterDelay",
    "git.autofetch": true,
    "workbench.editor.untitled.hint": "hidden",
    "python.formatting.blackPath": "/usr/local/bin/black",
    "python.formatting.provider": "black",
    "python.formatting.blackArgs": [
        "--line-length 100"
    ],
    "python.linting.flake8Args": [
        "--max-complexity 18",
        "--max-line-length 100"
    ],
    "python.linting.flake8Path": "/usr/local/bin/flake8",
    "workbench.editorAssociations": {
        "*.ipynb": "jupyter-notebook"
    },
    "workbench.iconTheme": "vscode-icons",
    "yaml.customTags": [
        "!And",
        "!And sequence",
        "!If",
        "!If sequence",
        "!Not",
        "!Not sequence",
        "!Equals",
        "!Equals sequence",
        "!Or",
        "!Or sequence",
        "!FindInMap",
        "!FindInMap sequence",
        "!Base64",
        "!Join",
        "!Join sequence",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!Sub sequence",
        "!GetAtt",
        "!GetAZs",
        "!ImportValue",
        "!ImportValue sequence",
        "!Select",
        "!Select sequence",
        "!Split",
        "!Split sequence"
    ],
    "yaml.validate": false,
    "python.venvFolders": [
        "venv"
    ],
    "python.venvPath": "~/venv",
    "window.zoomLevel": 1,
    "security.workspace.trust.untrustedFiles": "open",
    "extensions.supportVirtualWorkspaces": {

        "pub.name": false
    },
    "notebook.cellToolbarLocation": {
        "default": "right",
        "jupyter-notebook": "left"
    },
    "redhat.telemetry.enabled": false,
    "files.eol": "\n",
    "peacock.surpriseMeOnStartup": true,
    "peacock.affectStatusAndTitleBorders": true,
    "peacock.affectTabActiveBorder": true,
    "peacock.affectAccentBorders": true,
    "peacock.affectDebuggingStatusBar": true,
    "peacock.elementAdjustments": {
        "activityBar": "lighten",
        "statusBar": "darken",
        "titleBar": "none"
    },
    "peacock.favoriteColors": [
        {
            "name": "Angular Red",
            "value": "#dd0531"
        },
        {
            "name": "Azure Blue",
            "value": "#007fff"
        },
        {
            "name": "JavaScript Yellow",
            "value": "#f9e64f"
        },
        {
            "name": "Mandalorian Blue",
            "value": "#1857a4"
        },
        {
            "name": "Node Green",
            "value": "#215732"
        },
        {
            "name": "React Blue",
            "value": "#61dafb"
        },
        {
            "name": "Something Different",
            "value": "#832561"
        },
        {
            "name": "Svelte Orange",
            "value": "#ff3d00"
        },
        {
            "name": "Vue Green",
            "value": "#42b883"
        }
    ],
    "terraform.languageServer": {
        "external": true,
        "pathToBinary": "terraform-ls",
        "args": [
            "serve"
        ],
        "maxNumberOfProblems": 100,
        "trace.server": "off"
    },
    "git.enableSmartCommit": true,
    "terminal.integrated.defaultProfile.windows": "Git Bash"
}

Confirming the issue still happens when I tried to run django/python and npm debug sessions.
Version: 1.60.0 (user setup)
Commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
Date: 2021-09-01T10:41:52.311Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

even when I tried to do the following in settings.json per https://code.visualstudio.com/docs/editor/integrated-terminal#_removing-builtin-profiles
{
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
    "terminal.integrated.profiles.windows": {
        "PowerShell": null,
        "Command Prompt": null,
        "GitBash": {
            "source": "Git Bash"
        },
    },
    "terminal.integrated.automationShell.windows": "GitBash",
    "terminal.integrated.defaultProfile.windows": "GitBash",

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Django",
            "type": "python",
            "request": "launch",
            "console": "integratedTerminal",
            "args": [
                "runserver",
                "<IP_ADDRESS>:8000"
            ],
            "django": true
        },
        {
            "command": "npm run serve",
            "name": "Run npm serve",
            "request": "launch",
            "type": "node-terminal",
        },
        {
            "name": "vuejs: Chrome",
            "request": "launch",
            "type": "chrome",
            "url": "http://localhost:8080",
            "breakOnLoad": true,
            "sourceMapPathOverrides": {
                "webpack:///src/*": "${webRoot}/*",
                "webpack:///./src/*": "${webRoot}/*",

            },
            "preLaunchTask": "npm: serve"
        }
    ],
    "compounds": [
        {
            "name": "Run both-ends",
            "configurations": ["Python: Django","vuejs: Chrome", ]
        }
    ],
}

Per my issue concerning bash shells (#132312), I confirm this is still happening on the August stable release too.

How to downgrade when using scoop https://github.com/lukesampson/scoop/issues/4345#issuecomment-913495438

I'm experiencing this annoying issue after updating to 1.60.0 stable release. I mean when close VS Code and open it again, at startup it opens PowerShell every time even after choosing Git Bash as default terminal.
Version: 1.60.0 (system setup)
Commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
Date: 2021-09-01T10:41:52.311Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 6.1.7601

And my setting.json is as follows:
"terminal.integrated.profiles.windows": {
    "PowerShell": {
      "source": "PowerShell",
      "icon": "terminal-powershell"
    },
    "Command Prompt": {
      "path": [
        "${env:windir}\\Sysnative\\cmd.exe",
        "${env:windir}\\System32\\cmd.exe"
      ],
      "args": [],
      "icon": "terminal-cmd"
    },
    "Git Bash": {
      "source": "Git Bash",
      "icon": "terminal-bash"
    },
  },
  "terminal.integrated.defaultProfile.windows": "Git Bash",

can we get an easy update until this is fixed? update to not open an integrated terminal on start?

    "terminal.integrated.profiles.windows": {
        "PowerShell": {
            "source": "PowerShell",
            "icon": "terminal-powershell"
        },
        "Command Prompt": {
            "path": [
                "${env:windir}\\Sysnative\\cmd.exe",
                "${env:windir}\\System32\\cmd.exe"
            ],
            "args": [],
            "icon": "terminal-cmd"
        },
        "Git Bash": {
            "source": "Git Bash"
        },
        "Cmder": {
            "path": [
                "${env:windir}\\Sysnative\\cmd.exe",
                "${env:windir}\\System32\\cmd.exe"
            ],
            "env": {"CMDER_ROOT": "E:\\tools\\cmder"},
            "args": [
                "/K",
                "%CMDER_ROOT%\\vendor\\bin\\vscode_init.cmd"
            ],
            "icon": "cmder",
        }
    },
    "terminal.integrated.defaultProfile.windows": "Cmder",

Version: 1.60.0 (user setup)
Commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
Date: 2021-09-01T10:41:52.311Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

https://www.youtube.com/watch?v=_CL6n0FJZpk

Should be already fixed in latest Insiders build
Version: 1.61.0-insider (user setup)
Commit: bb9491d9f2c65510226dcc920a6efbf6501d5943
Date: 2021-09-07T05:17:08.586Z
@jmanthony3 could you check Insiders build to see if it still preproduces for you?

Should be already fixed in latest Insiders build
Version: 1.61.0-insider (user setup)
Commit: bb9491d
Date: 2021-09-07T05:17:08.586Z
@jmanthony3 could you check Insiders build to see if it still preproduces for you?

Fixed here

Should be already fixed in latest Insiders build
Version: 1.61.0-insider (user setup)
Commit: bb9491d
Date: 2021-09-07T05:17:08.586Z
@jmanthony3 could you check Insiders build to see if it still preproduces for you?

Yep, fixed here too

/duplicate https://github.com/microsoft/vscode/issues/132150


code

Hi,
Amazing work! When will the code be released?

We are currently tidying up our code. It is scheduled to be released in July.

We are currently tidying up our code. It is scheduled to be released in July.

Hey, where is the folder "libs"?


Add support for plugins to have background under user sidebar

from #71 (closed on force push)

This works for me


Regression issue: Auto-select new chat

When you create a new chat, the UI should "jump" to that chat.

fixed.


chore: rename c_peerdas_kzg to c_eth_kzg

Note: This crate is never published so if c_kzg_4844 is ever renamed, this won't cause any conflicts

Related to #54


fixed one char typo

changed "on" to "one"

@moagggi  Thanks for submitting this PR. Please star the project to continue supporting it


Remove unneccessary AppsandFeaturesEntries * manifests/a/AMD/AMDSoftwareCloudEdition/23.Q3/AMD.AMDSoftwareCloudEdition.installer.yaml

Microsoft Reviewers: Open in CodeFlow

URL:
Invalid URI: The hostname could not be parsed.
(Automated message - build 899)


RDKTV-12730: WPEFramework crash at signature std::terminate (RDKShell)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Skipping forward in video

Using the sample videos, the video player has the feature of allowing the annotator to skip forward to any time in the video (either using the bar or by typing in a time). This feature works for the videos hosted on S3, but for locally-stored videos (such as /video/0) it doesn't work when the video is first loaded - only after the page is refreshed.
Any suggestions as to how I can either fix this or work around it?

same issue here except that it does not work even after page reload. seek and keyframe click works for original videos. Any help is appreciated.

Does the video work by itself if you open the video file directly in the browser? That'd be a good place to start

yes. the video works in browser. to be clear, the video plays in beaverdam as well. it is the "seek" and "click on keyframes" that does not work.
Reproducing the bug:

Add a long video to database.
open webpage for annotating.
annotate on two keyframes.
click on frame circular markers below the seek bar.
takes you to begining of video instead of that keyframe
Alternatively:
Drag the seek controller. Hit Play. Takes you to first frame again.

@ankurgupta7 I have reproduced the problem. It seems to be a problem with Google Chrome (I am using Version 59.0.3071.115). Play back works correctly on Firefox though so I'd recommend you use Firefox for longer videos.

@mariellem @ankurgupta7 I looked into the problem further and it turns out that the reason why chrome cant play back bigger files is because chrome always enforces byte serving so that it only loads/buffer what is necessary to start video playback while firefox seems to just download the entire file if the server isn't responding to the range-request header. The reason why the seeded videos worked was because they were only ~1.5MB which, I assume, falls within the size limit of the request. More info can be found here
I have modified the code to force the browser to download the entire video first before initializing the video player which solves the problem but will mean that the worker has to wait for the entire file to download first before starting which may be problematic or undesired if the file size is very large.

Preloading fix can be found here #107

Great! That was a good catch! I'll get back to beaverdam next week and test if this works for me. Appreciate the effort.

So after looking into the numerous possible fixes that could be done we've decided to just document the issue here and leave it up to the user to choose the option that fits their video provider the best.
There are more or less 3 scenarios and for these 3 scenarios, local server refers to the server hosting the BeaverDam instance while remote server refers to an external server that hosts video content such as aws or youtube.
Scenario 1 - local server hosting big videos. Install Django Whitenoise to serve local content because it supports range requests/byte serving for static media hosted on local server according to here but keep in mind that theres a caveat for whitenoise, "For one thing, as described above, it only checks for static files at startup and so files added after the app starts won’t be seen."- Whitenoise Docs
Alternatively you can set up nginx/Apache on your local server to serve these files as they will support the range request headers and doesn't have the caveat that whitenoise does so you can create Video Objects from admin at anytime without having to stop and start your server. This is a good idea if you're planning to deploy the instance into production and hosting your own content.
Scenario 2 - local server hosting only small videos (<2MB depends) videos. Fine nothing needs to be changed from default Beaver Dam but you can also use all the fixes from Scenario 1
Scenario 3 - remote server hosting small or large videos. Fine nothing needs to be changed as video objects may be embedded cross origin as per Same origin policy specs
NOTE the branch/hotfix committed in this branch only works for large/small videos hosted on the local server and DOES NOT work for videos hosted on remote servers. If you run it you will see that the embedded videos hot linked from AWS created from the seed script do not work because the XMLHttpRequest used to download the file into the local filesystem is not allowed to download those files due to a CORS issue.


I want to continue the project as a new repo

It looks like, this project is inactive for more than 1 year. I really like this library, very straight forward, minimal features. Only missing part is the migration. I am not here to argue about anything.
What I want to do is, I want to continue the project as a new repo in github.
Is anybody here to help me to make decision.

Is version 1.2.0 (latest version) is stable enough to use in large scale application? I mean, can there be any known security issue?

Do I need to change directory structure? suppose, I convert to psr-4. Is current directory structure will reduce performance?

Please share what you think. Thanks.

If you like to create, say, a 2.0 version, then I think it would be beneficial to keep it in this repo.
That said, feel free to start a fork, and maybe eventually open a PR to get it merged to the main repo.
But beware, creating a library might not be that hard, but maintaining is no trivial task by any means. And you wouldn't be the first to attempt to give this library a new, without success.
I've done a lot of work on this project, but I didn't want to move solely on my own, which caused development to get stuck on waiting for reviews.
By now I'm not using the library anymore, so there's no value for me in continuing development, but I still think that the simplicity of this active record implementation was very easy to work with, and easy to integrate in existing projects. So for that reason I'd like to see this project get a new life.
Some useful pending changes you can find here; #424 #430

Hi @koenpun,
Thanks for sharing your opinion.
I did not fork this repo. I cloned and uploaded it in my github account. So, I got all commits, but here is no issues, no PR.
I am building an MVC framework (https://github.com/iceboxphp) and using ActiveRecord in my project.
Can you please tell me, how can I use those PR #424 and #430 in my project. If I fork from this repo, will I get those PR from this repo.
Have you any idea, where can I get official documentation for this project (what is hosted in http://www.phpactiverecord.org/ and in https://www.phpactiverecord.xyz/)?


improve typing of OrderedSet

[x] Passes isort . && black . && mypy . && flake8

Small patch to improve typing of OrderedSet: allowing more general input type in its constructor and .update method (Iterator instead of AbstractSet) helps to get rid of # type: ignore.
Side-effect: some performance gain in micro-benchmark (before and after):
%timeit xr.core.utils.OrderedSet(range(10))
3.46 µs ± 5.37 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

2.06 µs ± 6.39 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

Thanks @rhkleijn !


feat: Add sort by metric for heat map

Add control for sort by "asc" or "desc"
Associated with: https://github.com/apache-superset/superset-ui/pull/948
AFTER

TEST PLAN
Go to any Bar Chart
Select Sort By
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[x] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #13050 (da714b5) into master (2ce7982) will increase coverage by 13.94%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##           master   #13050       +/-   ##
===========================================
+ Coverage   53.06%   67.00%   +13.94%
===========================================
  Files         489      489
  Lines       17314    28782    +11468
  Branches     4482        0     -4482
===========================================
+ Hits         9187    19285    +10098
- Misses       8127     9497     +1370

Flag
Coverage Δ

cypress
?

python
67.00% <73.68%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/config.py
90.64% <ø> (ø)

...s/260bf0649a77_migrate_x_dateunit_in_time_range.py
0.00% <0.00%> (ø)

superset/viz.py
59.04% <50.00%> (ø)

superset/charts/commands/exceptions.py
92.85% <77.77%> (ø)

superset/db_engine_specs/elasticsearch.py
89.74% <93.75%> (ø)

superset/utils/date_parser.py
96.87% <100.00%> (ø)

...tend/src/explore/components/ExploreChartHeader.jsx

.../src/explore/components/controls/BoundsControl.jsx

...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx

...components/nativeFilters/FilterBar/FilterValue.tsx

... and 965 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0681b...da714b5. Read the comment docs.


Getting connected option from option

Hi,
Im probably understanding something poorly but Im trying to get option connected to my option and it acts like this:
opt.ConnectionCount returns 1 but opt.GetConnectedOption() returns list of 0 elements
Any idea why this could happen or what Im doing/understanding incorrectly?

Hi,
The Outpout side is referenced in m_hs_connected.Tolist(), so you can get it.
But, the Input side seems to be a problem.
if (v.Output == this) lst.Add(v.Input);
v.Output is deep copy object, so comparison between objects is not valid.
Object.ReferenceEquals cannot be used.
Is there another way around this?

I'm not very good at English and I use online translators a lot, so I'm sorry if my sentences sound weird.


functional-tester: use different ports in Procfile

@heyitsanthony @fanminshi
Current Procfile doesn't work because of port conflict.

Can we change procfile instead? or we have to change our prom deployment.

You are right. Just fixed. Thanks.

lgtm


[BUG] Issue after Chrome update - unknown error: cannot connect to Chrome at <IP_ADDRESS> from chrome not reachable

Bot crashes. Previously it happened only with mobile search, now with mobile and desktop
Description
The bot crashes when starting the mobiel browser. I think it is related with Chrome updates, as it has happened me twice, both after a Chrome update. The last time I solved it by removing the sessions folders, but after doing that I have to log in again manually (I have 2FA). Thus, I'm wondering whether it is possible to solve it without removing the full sessions folder (and thus losing my login cookies)
Expected Behavior
Doing the mobile search
Actual Behavior
2023-12-12 17:12:15,359 [ERROR] WebDriverException: Message: unknown error: cannot connect to chrome at <IP_ADDRESS>
from chrome not reachable
Stacktrace:
        GetHandleVerifier [0x00616E73+174291]
        (No symbol) [0x00540AC1]
        (No symbol) [0x00256E8A]
        (No symbol) [0x0024C8A3]
        (No symbol) [0x0027DE94]
        (No symbol) [0x00277B12]
        (No symbol) [0x00277927]
        (No symbol) [0x002AE259]
        (No symbol) [0x002ADBBA]
        (No symbol) [0x002A6DA6]
        (No symbol) [0x00281034]
        (No symbol) [0x00281F8D]
        GetHandleVerifier [0x006B49CC+820268]
        sqlite3_dbdata_init [0x00774EBE+652494]
        sqlite3_dbdata_init [0x007748D9+650985]
        sqlite3_dbdata_init [0x0076962C+605244]
        sqlite3_dbdata_init [0x0077586B+654971]
        (No symbol) [0x0054FEBC]
        (No symbol) [0x00548428]
        (No symbol) [0x0054854D]
        (No symbol) [0x00535858]
        BaseThreadInitThunk [0x770700F9+25]
        RtlGetAppContainerNamedObjectPath [0x772C7BBE+286]
        RtlGetAppContainerNamedObjectPath [0x772C7B8E+238]

Traceback (most recent call last):
  File "Path\Microsoft-Rewards-Farmer-master\main.py", line 24, in main
    executeBot(currentAccount, notifier, args)
  File "Path\Microsoft-Rewards-Farmer-master\main.py", line 147, in executeBot
    with Browser(
  File "Path\Microsoft-Rewards-Farmer-master\src\browser.py", line 41, in __init__
    self.webdriver = self.browserSetup()
  File "Path\Microsoft-Rewards-Farmer-master\src\browser.py", line 77, in browserSetup
    driver = webdriver.Chrome(
  File "Environments\RewardsFarmer\lib\site-packages\seleniumwire\undetected_chromedriver\webdriver.py", line 61, in __init__
    super().__init__(*args, **kwargs)
  File "Environments\RewardsFarmer\lib\site-packages\undetected_chromedriver\__init__.py", line 466, in __init__
    super(Chrome, self).__init__(
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\chrome\webdriver.py", line 45, in __init__
    super().__init__(
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\chromium\webdriver.py", line 56, in __init__
    super().__init__(
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 208, in __init__
    self.start_session(capabilities)
  File "Environments\RewardsFarmer\lib\site-packages\undetected_chromedriver\__init__.py", line 724, in start_session
    super(selenium.webdriver.chrome.webdriver.WebDriver, self).start_session(
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 292, in start_session
    response = self.execute(Command.NEW_SESSION, caps)["value"]
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\remote\webdriver.py", line 347, in execute
    self.error_handler.check_response(response)
  File "Environments\RewardsFarmer\lib\site-packages\selenium\webdriver\remote\errorhandler.py", line 229, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: cannot connect to chrome at <IP_ADDRESS>
from chrome not reachable
Stacktrace:
	GetHandleVerifier [0x00616E73+174291]
	(No symbol) [0x00540AC1]
	(No symbol) [0x00256E8A]
	(No symbol) [0x0024C8A3]
	(No symbol) [0x0027DE94]
	(No symbol) [0x00277B12]
	(No symbol) [0x00277927]
	(No symbol) [0x002AE259]
	(No symbol) [0x002ADBBA]
	(No symbol) [0x002A6DA6]
	(No symbol) [0x00281034]
	(No symbol) [0x00281F8D]
	GetHandleVerifier [0x006B49CC+820268]
	sqlite3_dbdata_init [0x00774EBE+652494]
	sqlite3_dbdata_init [0x007748D9+650985]
	sqlite3_dbdata_init [0x0076962C+605244]
	sqlite3_dbdata_init [0x0077586B+654971]
	(No symbol) [0x0054FEBC]
	(No symbol) [0x00548428]
	(No symbol) [0x0054854D]
	(No symbol) [0x00535858]
	BaseThreadInitThunk [0x770700F9+25]
	RtlGetAppContainerNamedObjectPath [0x772C7BBE+286]
	RtlGetAppContainerNamedObjectPath [0x772C7B8E+238]

Possible Fix
Removing the sessions folder
Steps to Reproduce
After a Chrome update
Your Environment

Chrome 120 (also happened with 119)
Windows 10
I'm using the bot with only one account

Same here, it was only doing desktop searches and since today it does not even start anymore.
selenium.common.exceptions.TimeoutException: Message: timeout: Timed out receiving message from renderer: -0.015
(Session info: chrome=120.0.6099.111)
Stacktrace:
GetHandleVerifier [0x005A6EE3+174339]
(No symbol) [0x004D0A51]
(No symbol) [0x001E6FF6]
(No symbol) [0x001D9B86]
(No symbol) [0x001D9ABF]
(No symbol) [0x001D89DC]
(No symbol) [0x001D8EFD]
(No symbol) [0x001E22F5]
(No symbol) [0x001EF4F4]
(No symbol) [0x001F2676]
(No symbol) [0x001D93BB]
(No symbol) [0x001EF41C]
(No symbol) [0x0024A05B]
(No symbol) [0x00236DA6]
(No symbol) [0x00211034]
(No symbol) [0x00211F8D]
GetHandleVerifier [0x00644B1C+820540]
sqlite3_dbdata_init [0x007053EE+653550]
sqlite3_dbdata_init [0x00704E09+652041]
sqlite3_dbdata_init [0x006F97CC+605388]
sqlite3_dbdata_init [0x00705D9B+656027]
(No symbol) [0x004DFE6C]
(No symbol) [0x004D83B8]
(No symbol) [0x004D84DD]
(No symbol) [0x004C5818]
BaseThreadInitThunk [0x769E7BA9+25]
RtlInitializeExceptionChain [0x77C4BD2B+107]
RtlClearBits [0x77C4BCAF+191]

Removed session folder and it worked

J'ai le même problème


[INLONG-7553][Sort] Mysql CDC support output DDL in all migrate mode

Prepare a Pull Request

Fixes #7553

Motivation
[INLONG-7555][Sort] Mysql CDC support output DDL model in all migrate
Modifications
[INLONG-7555][Sort] Mysql CDC support output DDL model in all migrate
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

check code style


Setting deepWatchData default to false breaks existing real time charts

Commit 115ae8170a49eb303dab04817bcf7726c5bfda96 sets deepWatchData to false by default. This breaks real-time charts like the real-time charting example. Setting deepWatchData back to true in the config solves this problem.
A minor version update shouldn't introduce a breaking change like this and it isn't really documented (pretty much all chart.data objects are "complex").
In my view there are three use cases: static charts, incremental updates and complete redraws. Static charts can be optimised like the Angular {{::var}} one-time binding to give the best performance possible. In the dynamic cases I think most would be of the incremental kind, and doing referential comparison would produce unexpected behaviour. Defaulting to referential equality would give sub-optimal result for static charts, completely break incremental updates and slightly benefit the complete redraws which I think are the minority in the use cases.

:+1: I experienced exactly this issue - I don't believe this change has been correctly communicated within documentation.

@gnail thanks for your review! We moved to default static charts due to some performance issues #75, #210, #225, stackoverflow. But it turned to be very painful for people, sorry for that.. In the new release [1.0.4] we found a way how to get around the issues, and backed to dynamic charts by default. Check the docs for more detail. Thanks.


Enable handle_internal_only_routers by default

The default value for handle_internal_only_routers changed from True to
False in OSA upstream, causing a unexpected behavior.
RPC-O enables handle_internal_only_routers in order allow Neutron
router without having to attach external networks. This is a valid
customer use case.
Closes-Bug: #1046

recheck

recheck_all

recheck_swift

recheck_upgrade

Hi @BjoernT - what is the upgrade impact here?
We need to understand what the impact is for upgrades to mitaka if we merge this in to master.
If there is some kind of impact, I'd be very wary about backporting to any of the liberty branches.

There is no impact to upgrades. It retains the default configuration in neutron. It was just plain wrong that OSA changed the value without knowing what it even does

Hi @BjoernT I mean upgrade impact to any deployments that may have already got the overridden 'False' setting.

OK, the impact is unknown since we do not always know how customer organize their router.
In worst case, they reboot a neutron agent container and the networks won't come up, at least if they use internal only neutron routers. Hence I would back port it where we can

@BjoernT if I'm understanding this issue correctly, if any customers are already deployed with the setting as False, then they wouldn't be able to create routers that are not attached to external networks. So is it fair to say that if we then set it to True, there should be no affect to those customers since they never could create those routers in the first place?
If you're agreed then I will +1 this patch.

Yes correct, this is a non risk change. On the flip side, not setting it to true will result in issue for customers who are using internal neutron router, which is a OK configuration in RPC. And most people would not even be able to debug this because the error message Neutron reports is absolutely wrong, which why we have a different neutron bug open to fix this so everyone will know what the problem is

👍

OK on your confirmation, this makes sense to me 👍
Note we still need another dev team +1

:+1:


feat(docs): commit for version release

:tada: This PR is included in version 1.118.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow passing additional data to getAccessToken()

This enables scenarios including the use of this library to authenticate with Azure Active Directory.

A proposed implementation of #13.

Your issues should be addressed, and I've updated the readme to reflect the new option :)

Just published as 2.4.0 😄


effect at start

hi! when i add the code to the header of my website, there is a starting zoom effect to make the particles appear that i don't want. is it possible to disable it?
regards!

That's a css transform scale effect. Refer to #229 to see lookup the css snippet


add session_ids arg for multithread use of pipeline.stream_infer

Motivation
When using pipeline.batch_infer / pipeline.stream_infer with multiple threads, the default session_ids are all start of zero which will makes batch inference impossible.
from threading import Thread
from lmdeploy import pipeline, GenerationConfig
pipe = pipeline('/mnt/140/InternLM/internlm2-chat-1_8b', log_level='INFO')

def work(ss):
  gen_config = GenerationConfig(ignore_eos=True, max_new_tokens=512)
  for i in range(10):
    for x in pipe.stream_infer('hello', session_ids=ss+i, gen_config=gen_config):
        pass

threads = []
for i in range(5):
  t = Thread(target=work, args=(i * 10, ))
  t.start()
  threads.append(t)

for t in threads:
  t.join()

@AllentDan Do you remember our motivation to support batch prompts inference in streaming mode?

@AllentDan Do you remember our motivation to support batch prompts inference in streaming mode?

Required by XTuner and community. https://github.com/InternLM/lmdeploy/issues/636

Users tend to input only one prompt in each thread in multithread situations. Shall we provide an infer function for it? The infer function is a synchronized function of async generate. It does not offer batch inference ability. Users can control the session id themself.

@AllentDan Do you remember our motivation to support batch prompts inference in streaming mode?

Required by XTuner and community. #636

It didn't make sense to me.
If users request streaming output for multiple prompts, can't we recommend they use async_stream_infer and pass the prompts one by one?

Maybe the user is not capable of using coroutine programming. I recommend they all use the generate function directly if possible.

That's not my point
My point is that outputting batch prompt response in streaming mode is probably inappropriate.
Is it supported by vLLM?

The root is we don't want users being bothered by session_ids in multithread scenarios.

May merge main so as to do the test


Patch gsa websites

Broke the PR into two commits. First was net new additions, second was deduplication and corrections for GSA websites.

closing and resubmitting after rebase if necessary


Need a way to modify decimal levels locally in spreadsheets.

There are times I need the default decimal precision and other time I'm doing currency.  A local per spreadsheet overide is needed to modify the decimal precision for at least each spreadsheet.  I looked in the Github Readme and in the page in Obsidian and unless I'm missing something, other than setting the precision globally there is no way to use high precision and currency precision decimal levels in the same vault.

Thanks

Hi! One solution is to use the format function of mathjs: https://mathjs.org/docs/reference/functions/format.html
To round π to 3 digits you could use:
=format(3.14159, 3)
To round π to 3 decimal places you could use:
=format(3.14159, {notation: 'fixed', precision: 3})


new attributes should overwrite the old ones if they exists

small bug.

The patch itself looks good but the unit test must be fixed. If you run the tests test_set_creator_attributes_update will fail since the behaviour changes. Can you update the test?


How can we get more pre-trained checkpoints?

Hi,
May I ask where can we get more pre-trained checkpoints, such as vit_base_patch16_384, which can be directly loaded based on current code?
Thanks.

Hi, do you need a pre-trained checkpoint for video or image?  They have minor differences such as the first patch embedding layer (3D conv for video while 2D conv for image).

Hi,
I just need pre-trained checkpoints for images with different ViT strutures. May I know do you download these checkpoints via links such as https://github.com/pengzhiliang/Conformer/blob/main/vision_transformer.py#L32-L80
Thanks.

I used timm provided checkpoints with small key-mappings as introduced in https://github.com/ShoufaChen/AdaptFormer/blob/main/PRETRAIN.md.
I intend to upload these processed checkpoints this weekend.

Sure, thanks. Hope to see the image code with pre-trained weights process as well soon. Thanks so much.

Hi, @rshaojimmy
Image code and pre-trained weights are released at https://github.com/ShoufaChen/AdaptFormer/pull/8.

Updated Table 1.

Thanks so much!


[Question] Can I listen fabric application start?

Hi , wondering if there have any event can be listened in c# code to monitor Fabric application start

What do you mean by start? The application either exists or does not exist.

I suppose he is asking for an BeginExistance event then


Specify HNSW Parameters

Hi, are you planning to allow passing HNSW parameters when creating a new collection? if not, would you accept a PR? thanks!

Hi @danielfleischer, We'll gladly accept a PR on that topic. Please let me know if you need any help!

Hi, I submitted #8; please have a look.

@danielfleischer Done. Thanks for the contribution! I had just a single minor comment.


Text claim changes

Reword it and added styles to make link easier to find. It was working in some places already

This seems confusing because when you click the link you're not actually going to 'report an issue' --> i don't disagree this spot can be improved, but I believe we should design something or at least have a plan to test the solutions implemented quickly.

I left that link because I thought it was important for us, but maybe we should redirect them to github.

okay I'm going to merge this one — but can we keep the GH issue open for collaboration/plannification?


docs: add link to template

created a cookiecutter template to create a basic structure which supports installing into my
https://github.com/seanbreckenridge/HPI-template
Has two basic example modules with/without the typical module boilerplate
https://github.com/seanbreckenridge/HPI-template/tree/master/HPI-{{ cookiecutter.username }}/my

oh nice, thanks! will keep in mind to update if we come up with some more specific guidelines/patters!


android LegacyDownloadDir

Hello,
Thank you for maintaining the package.
We were using ReactNativeBlobUtil.fs.dirs.DownloadDir but we figured out that it's no longer point to the Download directory in the external storage like /storage/emulated/0/Download or /storage/sdcard/Download.
But ReactNativeBlobUtil.fs.dirs.LegacyDownloadDir seems to work as intended. is LegacyDownloadDir supported in all android versions API > 21?
We just need to download files to /storage/emulated/0/Download/{APP_NAME}/ and make sure it that works flawlessly on all supported android versions > 21.
Thank you

Please update your docs, I spent a few hours on this problem, and this dir is not mentioned in your docs.  Also, the File System Access API docs point to an import that is invalid (RNFetchBlob).
Great work, I don't want to sound negative but updated docs would have saved me a lot of time.

@sentry0 you could open a PR. This is open source software after all, you're asking people to do work for free.

@sentry0 you could open a PR. This is open source software after all, you're asking people to do work for free.

Thank you!
A PR is always very much appreciated. At the end most of the repo maintainers, including me, are doing this in their spare time

Hello,
Thank you for maintaining the package.
We were using ReactNativeBlobUtil.fs.dirs.DownloadDir but we figured out that it's no longer point to the Download directory in the external storage like /storage/emulated/0/Download or /storage/sdcard/Download.
But ReactNativeBlobUtil.fs.dirs.LegacyDownloadDir seems to work as intended. is LegacyDownloadDir supported in all android versions API > 21?
We just need to download files to /storage/emulated/0/Download/{APP_NAME}/ and make sure it that works flawlessly on all supported android versions > 21.
Thank you

Yes ir should. But there are some deprecated APIs used under the hood to get the legacy folders. No way to say how long google will keep these available

i am facing this issue again in
"react-native-blob-util": "^0.19.9",
"react-native": "0.73.6",

export const exportClientData = async (type: 'all' | 'single', client_id?: string) => {
  let filepath = '';
  let url = '';

  if (type === 'all') {
      url = `https://...`;
  } else if (type === 'single') {
      url = `https:///.......`;
  }

  // Get the app's cache directory
  const { fs } = ReactNativeBlobUtil;
  const cacheDir = Platform.OS === 'ios' ? fs.dirs.DocumentDir : fs.dirs.LegacyDownloadDir;

  // Define the filename
  const filename = 'filename';

  // Construct the full filepath
  if (type === 'all') {
      filepath = `${cacheDir}/${filename}/ClientData.zip`;
  } else if (type === 'single') {
      filepath = `${cacheDir}/${filename}/${client_id}.zip`;
  }

  try {
      // // Ensure the directory exists
      // const dirPath = `${cacheDir}/${filename}`;
      // const isDir = await fs.isDir(dirPath); // Check if the directory exists

      // if (!isDir) {
      //     await fs.mkdir(dirPath); // Create the directory if it does not exist
      // }

      // Download the file and save it to the cache directory
      const configOptions:any = Platform.select({
          ios: {
              fileCache: true,
              path: filepath,
              appendExt: 'zip',
          },
          android: {
              fileCache: true,
              path: filepath,
              appendExt: 'zip',
          },
      });

      const response = await ReactNativeBlobUtil.config(configOptions).fetch('GET', url, {
          "Accept": "*/*",
          "Accept-Encoding": "*/*",
      });
      console.log('response==>>', JSON.stringify(response, undefined, 4));
      return response;
  } catch (error) {
      console.error('error in downloading==>', error);
      return error;
  }
};


Fix for missing HybridQuery results when concurrent segment search is enabled

Description
Fixed gap in implementation for case when shard has multiple (6+) segments. In such case some hits were missing in final hybrid query result.
Issue caused by wrong assumption that collector manager can have only one hybrid query result collector in reduce phase. It's true for number of segments < 6, otherwise core passes multiple collectors with a portion of result each. We have to merge those results at shard level to have correct collection of hits.
Lucene code where they define limit per slice (block that is processed by one collector). It's max of 250.000 docs or 5 segments.
Logic for merge is a bit tricky because we have to deal with TopDocs that has been formatted to special hybrid query format. Each next collector result should be merge into query result one by one. On each merge we need to find results of one sub-query and merge then separately, then wrap into hybrid query result format.
Example:
TopDocs in query result:
query1: {doc1: 10, doc3: 5, doc5: 3}
query2: {doc2: 3, doc3: 1}

result from next block of segments:
query1: {doc2: 11, doc6: 2}
query2: {doc5: 2, doc6: 1}

merged result:
query1: {doc2:11, doc1: 10, doc3: 5, doc5: 3, doc6: 2}
query2: {doc2: 3, doc5: 2, doc3:1, doc6: 1}

Added extensive list of unit tests and integ test that would fail with old logic (assertion of total hits, actual number would be lower).
Issues Resolved
https://github.com/opensearch-project/neural-search/issues/799
Check List

[ ] New functionality includes testing.

[] All tests pass

[X] New functionality has javadoc added
[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BWC for 2.15 will keep failing because main is still pointing to snapshot and as per our process we're changing that after the release.
Security check CI action will also fail for jdk 11 and 17, core has changed min requirement for security plugin to jdk 21. CI for jdk 21 is passing

Great Job @martin-gaievski for raising this PR.

Overall looks good to me. Just waiting for @navneet1v review.

Lucene code where they define limit per slice (block that is processed by one collector). It's max of 250.000 docs or 5 segments.

@martin-gaievski Opensearch defines more control on top of this, to how to slice the segments. Ref: https://opensearch.org/docs/latest/search-plugins/concurrent-segment-search/#slicing-mechanisms

Lucene code where they define limit per slice (block that is processed by one collector). It's max of 250.000 docs or 5 segments.

@martin-gaievski Opensearch defines more control on top of this, to how to slice the segments. Ref: https://opensearch.org/docs/latest/search-plugins/concurrent-segment-search/#slicing-mechanisms. are you taking any assumptions based on lucene slicing mechanism?

thanks for sharing that link, I was not aware of the OpenSearch specific approach. Anyhow, I'm not making any assumptions based on number of segments or any other condition of how the slices are constructed. Main principle will be same - it will be either one collector or many collectors with search results. Previously we were handling results from one collector, now we can handle scenario with multiple collectors.

Ran a benchmark of https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/noaa_semantic_search on main with and without this change, here are results for medium and large queries, where we have up to 8 segments and where the impact should be the visible the most:
With the change the performance is actually better. I'm taking one more round for baseline to make sure data isn't flaky, but these are preliminary results.
baseline:
   {
    "task": "hybrid-query-only-range-medium-subset",
    "operation": "hybrid-query-only-range-medium-subset",
    "throughput": {
     "min": 2.011052370071411,
     "mean": 2.021946349143982,
     "median": 2.018242835998535,
     "max": 2.0519936084747314,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0": 91.03496170043945,
     "90_0": 96.44083023071289,
     "99_0": 98.4694938659668,
     "100_0": 98.7366943359375,
     "mean": 91.10263374328613,
     "unit": "ms"
    },
    "error_rate": 0.0
   },
-----
  {
    "task": "hybrid-query-only-range-large-subset",
    "operation": "hybrid-query-only-range-large-subset",
    "throughput": {
     "min": 2.0065014362335205,
     "mean": 2.01287588596344,
     "median": 2.010721802711487,
     "max": 2.0304625034332275,
     "unit": "ops/s"
    }
    "service_time": {
     "50_0":<PHONE_NUMBER>586914,
     "90_0":<PHONE_NUMBER>336914,
     "99_0":<PHONE_NUMBER>9833984,
     "100_0":<PHONE_NUMBER>3671875,
     "mean":<PHONE_NUMBER>7045897,
     "unit": "ms"
    },
    "error_rate": 0.0
   },

with this change
   {
    "task": "hybrid-query-only-range",
    "operation": "hybrid-query-only-range",
    "throughput": {
     "min": 2.0113322734832764,
     "mean": 2.0225303030014037,
     "median": 2.0187013149261475,
     "max": 2.053476572036743,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0": 72.53012466430664,
     "90_0": 73.0995979309082,
     "99_0": 89.77497482299805,
     "100_0":<PHONE_NUMBER>7060547,
     "mean": 72.93198219299316,
     "unit": "ms"
    },
    "error_rate": 0.0
   },
---
  {
    "task": "hybrid-query-only-range-medium-subset",
    "operation": "hybrid-query-only-range-medium-subset",
    "throughput": {
     "min": 2.0104377269744873,
     "mean": 2.0207511043548583,
     "median": 2.0172306299209595,
     "max": 2.0493412017822266,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0":<PHONE_NUMBER>9116211,
     "90_0":<PHONE_NUMBER>3208008,
     "99_0":<PHONE_NUMBER>1196289,
     "100_0":<PHONE_NUMBER>8134766,
     "mean":<PHONE_NUMBER>7163086,
     "unit": "ms"
    },
    "error_rate": 0.0
   }

LGTM

I re-ran the benchmark, it shows no change for large sub-set and 5% delta for medium sub-set. that looks more realistic as we only add some computation.
baseline:
{
    "task": "hybrid-query-only-range-medium-subset",
    "operation": "hybrid-query-only-range-medium-subset",
    "throughput": {
     "min": 2.0109918117523193,
     "mean": 2.0218198919296264,
     "median": 2.0181103944778442,
     "max": 2.051851272583008,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0": 96.55980682373047,
     "90_0": 99.6461067199707,
     "99_0":<PHONE_NUMBER>3066406,
     "100_0":<PHONE_NUMBER>506836,
     "mean": 95.76778579711915,
     "unit": "ms"
    },
    "duration": 62003.01305705216
   }
---
   {
    "task": "hybrid-query-only-range-large-subset",
    "operation": "hybrid-query-only-range-large-subset",
    "throughput": {
     "min": 2.0072591304779053,
     "mean": 2.014420256614685,
     "median": 2.0119868516921997,
     "max": 2.0340819358825684,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0":<PHONE_NUMBER>03125,
     "90_0":<PHONE_NUMBER>0058594,
     "99_0":<PHONE_NUMBER>6416016,
     "100_0":<PHONE_NUMBER>328125,
     "mean":<PHONE_NUMBER>2749024,
     "unit": "ms"
    },
    "error_rate": 0.0
   }

after the change
{
    "task": "hybrid-query-only-range-medium-subset",
    "operation": "hybrid-query-only-range-medium-subset",
    "throughput": {
     "min": 2.0046942234039307,
     "mean": 2.0093229246139526,
     "median": 2.0077611207962036,
     "max": 2.0221428871154785,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0": 88.03913879394531,
     "90_0": 93.1028938293457,
     "99_0":<PHONE_NUMBER>5581055,
     "100_0":<PHONE_NUMBER>1972656,
     "mean": 88.63995048522949,
     "unit": "ms"
    },
    "error_rate": 0.0
   },
---
   {
    "task": "hybrid-query-only-range-large-subset",
    "operation": "hybrid-query-only-range-large-subset",
    "throughput": {
     "min": 2.0080811977386475,
     "mean": 2.0161024808883665,
     "median": 2.0133992433547974,
     "max": 2.0380523204803467,
     "unit": "ops/s"
    },
    "service_time": {
     "50_0":<PHONE_NUMBER>3642578,
     "90_0":<PHONE_NUMBER>4902344,
     "99_0":<PHONE_NUMBER>376953,
     "100_0":<PHONE_NUMBER>392578,
     "mean":<PHONE_NUMBER>224121,
     "unit": "ms"
    },
    "error_rate": 0.0
   }


Issue detected on fasterCallback being triggered after callback

It looks like the test is not done properly

There were several issues down the road:

The BDD mechanics make tests asynchronous: there is a significant delay between the two setTimeout and, at some point, the delay caused the issue (the slower was triggered before the faster). I rewrote the test to trigger the two setTimeout at the same time
I was relying on the internals of the timeout implementation (such as checking the queue and clearing it). It does not make sense when the BDD runner itself uses those APIs. It was removed.
The timer resolution in the script engine is not perfect. I included a tolerance for differences that are less than 10ms.


Scroll not working properly in Truth Table For Logical Operations page

Describe the bug
- description of what the bug is.
Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

Yes,Please assign this issue under hacktoberfest tag

Go ahead @zhcet19

Is this participating in Hacktoberfest this year or not ??


Ask about the result

Hello!
I read the paper you published and i also git clone the code .I run the code successfully.But the result I got is far from your result.
[wikidev.jsonl, epoch 4] overall:76.1, agg:89.1, sel:96.3, wn:97.1, wc:92.1, op:98.4, val:91.1.
I find that the where_col result and the where_val is worse than other.
What do you think about these issues?

Could you run experiment using docker with the DockerFile in repo? The trained model is uploaded in release section, and you can evaluate it to see if number matches.

have you solved your problem after set a bigger batch size？ I have the same problem now，my batch size is 24，but my result is lf（eg）=78，ex（eg）=82，Thank you！！

have you solved your problem after set a bigger batch size？ I have the same problem now，my batch size is 24，but my result is lf（eg）=78，ex（eg）=82，Thank you！！

Hi, could you refer to https://github.com/lyuqin/HydraNet-WikiSQL/issues/4 , where larger batch size should improve the accuracy. In addition, in the post, the subtask accuracy at epoch 0 was good with batch size 32 (except for val acc which had bug before). If your subtask accuracy was significant lower with similar batch size, please double check package version, especially pytorch and transformers.

Hi @Smile0524 @1456416403 , I re-run a few experiments with smaller batch size, results are listed below. It shows that larger batch size gives better result. I recommend to train with batch size > 64, which should give similar results as best model trained with batch size 256.
batch size 24
[wikidev.jsonl, epoch 0] overall:74.0, agg:89.1, sel:97.2, wn:98.1, wc:94.0, op:98.9, val:89.1
[wikitest.jsonl, epoch 0] overall:73.0, agg:89.5, sel:97.0, wn:97.4, wc:92.7, op:98.7, val:89.0
[wikidev.jsonl, epoch 1] overall:80.8, agg:90.1, sel:97.4, wn:98.1, wc:94.3, op:99.0, val:96.2
[wikitest.jsonl, epoch 1] overall:80.4, agg:90.3, sel:97.2, wn:97.7, wc:93.8, op:98.9, val:96.1
[wikidev.jsonl, epoch 2] overall:81.5, agg:90.0, sel:97.5, wn:98.4, wc:95.0, op:99.1, val:96.8
[wikitest.jsonl, epoch 2] overall:81.4, agg:90.6, sel:97.3, wn:97.9, wc:94.1, op:99.0, val:96.5
[wikidev.jsonl, epoch 3] overall:82.4, agg:90.6, sel:97.6, wn:98.5, wc:95.0, op:99.2, val:96.9
[wikitest.jsonl, epoch 3] overall:82.2, agg:91.0, sel:97.4, wn:97.9, wc:94.2, op:99.1, val:96.9
[wikidev.jsonl, epoch 4] overall:83.0, agg:91.1, sel:97.6, wn:98.5, wc:95.0, op:99.1, val:97.1
[wikitest.jsonl, epoch 4] overall:82.5, agg:91.2, sel:97.4, wn:97.9, wc:94.3, op:99.1, val:96.9
batch size 64
[wikidev.jsonl, epoch 0] overall:78.9, agg:88.0, sel:97.5, wn:98.3, wc:94.8, op:98.9, val:96.2
[wikitest.jsonl, epoch 0] overall:78.4, agg:88.5, sel:97.1, wn:97.8, wc:93.8, op:98.8, val:95.9
[wikidev.jsonl, epoch 1] overall:81.9, agg:90.6, sel:97.6, wn:98.5, wc:95.2, op:98.6, val:96.7
[wikitest.jsonl, epoch 1] overall:81.4, agg:90.6, sel:97.4, wn:98.0, wc:94.4, op:98.5, val:96.8
[wikidev.jsonl, epoch 2] overall:82.9, agg:91.0, sel:97.6, wn:98.5, wc:95.4, op:99.1, val:97.1
[wikitest.jsonl, epoch 2] overall:82.3, agg:90.8, sel:97.5, wn:98.2, wc:94.9, op:99.1, val:96.9
[wikidev.jsonl, epoch 3] overall:83.9, agg:91.3, sel:97.9, wn:98.6, wc:95.6, op:99.0, val:97.5
[wikitest.jsonl, epoch 3] overall:83.4, agg:91.4, sel:97.6, wn:98.2, wc:94.9, op:99.1, val:97.3
batch size 128
[wikidev.jsonl, epoch 0] overall:80.0, agg:89.4, sel:97.4, wn:98.1, wc:94.5, op:99.1, val:96.3
[wikitest.jsonl, epoch 0] overall:79.7, agg:89.7, sel:97.6, wn:97.7, wc:93.9, op:98.9, val:95.7
[wikidev.jsonl, epoch 1] overall:82.6, agg:90.6, sel:97.8, wn:98.4, wc:95.3, op:99.1, val:97.2
[wikitest.jsonl, epoch 1] overall:82.0, agg:90.6, sel:97.5, wn:98.0, wc:94.7, op:99.0, val:96.9
[wikidev.jsonl, epoch 2] overall:83.4, agg:91.1, sel:97.8, wn:98.4, wc:95.4, op:99.2, val:97.3
[wikitest.jsonl, epoch 2] overall:82.9, agg:91.2, sel:97.6, wn:98.0, wc:94.7, op:99.1, val:97.2
[wikidev.jsonl, epoch 3] overall:83.8, agg:91.2, sel:97.7, wn:98.7, wc:95.6, op:99.3, val:97.6
[wikitest.jsonl, epoch 3] overall:83.4, agg:91.3, sel:97.6, wn:98.2, wc:95.0, op:99.2, val:97.3
[wikidev.jsonl, epoch 4] overall:83.7, agg:91.1, sel:97.7, wn:98.6, wc:95.5, op:99.2, val:97.5
[wikitest.jsonl, epoch 4] overall:83.2, agg:91.2, sel:97.6, wn:98.1, wc:94.7, op:99.2, val:97.4

Thank you very much!


[Bug]: No setting to change how many icons get shown for a toughness of 1

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I wanted to make so that Minecraft Vanilla armors would show only up to 10 armor toughness points, whereas with default settings the full netherite set shows 13 points, making the second orange overlayed bar appear, which is what I want to avoid.
In the webpage is says "Note: How many icons get shown for a toughness of 1 can be set in the config." however I was not able to find such option anywhere in the settings.
This leaves me with the only option of disabling armor toughness, which is really a shame because it make diamond and netherite sets indistinguishable.
Version
BETA 3.0.0 for Minecraft Forge 1.18.1
Version
No response
To Reproduce
Just install the mod and search for the config.
Expexted Behavior
I expected to find a setting, like for absorption, resistance and protection, to change how many toughness icons are shown for a certain amount of toughness points.
Additional Context
No response
Screenshots

Relevant Log / Crash-Report Output
No response

In 3.0.0 alpha this setting was removed as i deemed it irrelevant, but i can add it back - thus marking this as a feature request.
Also, the website is not up to date for v3.0.0 beta, but still shows all features of v2.1.x

Yes, if you could add it back it would be awesome for me, for the reasons stated above.
Thank you

re-added in dae4142 (aka beta5)


Use cargo-zigbuild for reproducible build with glibc 2.31

Zig language has solved many issues regarding compilation linker.
It allows us to compile to a smaller version of glibc while using latest guix commit.
No need then to bootstrap multiple version of rust, the current supported version is 1.71.1
close #414

Checked on #d2379bd with @jp1ac4 that liana-gui checksum is same for both of us.
f9612bde713fbe5e3e3c965d5d81631ee98e9763375df2d0c9da9ea1260203cf  release_build/x86_64-unknown-linux-gnu/release/liana-gui


HTML breaks in /docs/concepts/cluster-administration/flow-control/

Problem
HTML breaks on this page:
https://kubernetes.io/docs/concepts/cluster-administration/flow-control/
Related to Hugo version upgrade in #19907
Page to update
https://git.k8s.io/website/content/en/docs/concepts/cluster-administration/flow-control.md

There's no HTML in the affected table, so it looks like there's a breaking shortcode:
{{< table caption="Example Shuffle Sharding Configurations" >}}

When I remove the table caption shortcode locally, it fixes the problem.


blender 2.8 physics build problem

When I build physics and play animation,the model is corrupted.

Cats is currently not designed to support animations and physics. But if you want to import animations, use scale 0.08 during the import.
A better way of adding animations to your model is here: https://i.imgur.com/sgymeps.png


Some settings are lists (rather than tuples) in Django now

According to the official Django docs INSTALLED_APPS and STATICFILES_DIRS are lists since a few versions.
I've also made a few styling adaptions to the text in the README, forgive me!

Maybe the If you have some behave related errors try to install ... paragraph is not totally relevant anymore since we had a 1.2.6 release of behave just recently, which should have done remediated some of the features lagging behind from 1.2.5.

Thanks Peter, I'm opening the issue to update behave version, check that there's no error anymore and update the documentation.


Finalize Homepage

Make sure the home page matches the one in the design
Things to keep an eye on:

[ ] Font type
[ ] Font weight
[ ] Margins, gaps
[ ] System color "using josa true blue"
[x]  The height of the main header will be decreased
[x] Reduce the size of the HeroBanner's heading to prevent it from overflowing the banner's container

@alsahawneh please check the design guidelines

closed due to being stale


Add swiping feature to slide the card.

By adding a prop swiping: (Boolean) allow a user to slide cards through the swipe.

Closing the issue because of inactivity


Unable to build simple rustls example (rayon-core can't find panic_unwind)

I am unable to build a simple rustls example using Xargo. Details below:
$ rustup show
...
active toolchain
----------------

nightly-x86_64-apple-darwin (default)
rustc 1.24.0-nightly (cfba0d446 2017-12-05)

$ xargo --version
xargo 0.3.8
cargo 0.24.0-nightly (5bb478a51 2017-11-29)

# Xargo.toml
[dependencies.std]
features = ["force_alloc_system"]

# Cargo.toml
[package]
name = "rustls-test"
version = "0.1.0"

[dependencies]
rustls = "0.11.0"

[profile.release]
panic = 'abort'

// main.rs
extern crate rustls;

fn main() {
    println!("Hello, World");
}

$ xargo build --release
...
error[E0463]: can't find crate for `panic_unwind`
error: aborting due to previous error
error: Could not compile `rayon-core`.

Is there a way to solve this issue?

$ xargo build --release

Try xargo build --release --target x86_64-apple-darwin. See gotchas (it applies to both plugins and build scripts)

Thanks! That allowed a completed build to complete.
I had read that section but hadn't realized it applied to this problem. Is there a way the README could be updated to help someone that hits it in the future?

The third bullet could probably be reworded to suggest always using --target. It then could mention that, without the flag, the build could fail due to compiler plugins and build scripts.

I'll see if I can work on a PR for you to review later today.


Reverse order events

We may want that events that are coming up show up first, and show past events after. This may be done adding reverse filter on index.md. The question is, would this make it harder to understand? IMO yes, but I'll allow for a free discussion around this.
Mentioned by @felixarpa

What about having two different subsections - Upcoming Events and Past Events? We can do a chronological sort (oldest to newest like the current version) on these sections.
What do you think about that?


Fully test health buttons

Test: true/false
damage health: true
current health !below 0: true
heal health: true
current health !above maxhealth: true
fully heal: false
button not present
instant death: false
button not present
notes

[ ] the current health icon is off centered and needs to be slightly raised up so that it can be more readable.

[x] I'd also like to make it so when you hit the button to either add or subtract to the current health, the number field goes back to being blank so you don't have to keep highlighting the number to change it.

I fixed the current health counter. I changed the size of it and the placement of the number. I'm pretty happy of how it turned out.  I also changed the placement of the health controls before I realized that I didn't want those centered on the current health because I still need to add the progress bar.

Here's the css that I ended with that left me with this setup:

now all that's left is to add those extra functions that I didn't have before. I'll make that into a separate issue section though for clarity.


Respect @psalm-internal

Relates to #904.
https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-internal allows to specify a different namespace for an @internal class. Currently cannot update to deptrac >=0.21.1 due to this issue.

And what is broken about this? What is the expected and actual behavior?

I started making a reproducer and realized that I didn't get this right:

If you do so, the marked class cannot be referenced by any class outside its layer

Thank you for this feature!

Glad to hear, it solved itself. I will check your other issue for making internal checks configurable when I have time


Tighten up wrapError semantics and implementation

Fixes #6746

Require it to return an IFluidErrorBase
Update any type using wrap to do implement IFEB.  For now they have error code "TBD", will open issues to follow up (see also: #6754)
Instead of copying telemetry props, add a variant that logs, tying the inner/outer errors together in telemetry via ErrorInstanceId\

still need to update tests

FYI @jvoels

This got too big when I started trying to make the impacted error classes here properly implement IFluidErrorBase.  Closing in favor of #7045


Installation problem

I am unable to install jsbin by using npm install -g jsbin and my npm-debug.log. I am using an OS X 10.11.6 with node v7.7.4 & npm v4.1.2.
I realize it is a recurring problem. I did find a solution, but I would like to verify if it is current, as jsbin is now at 3.41.9 while the solution was for 3.11.23. Also will this work on a mac as the original poster was using a windows.

Local installs don't work on anything above 0.10.


Angular CLI should warn when configurations are being overriden.

Command
build
Description
Thanks for all your work on this great framework!
We have a single application that can has multiple different configurations depending on both the application and deployment environment.
For example:
"configurations": {
            "fr": {
              "fileReplacements": [
                {
                  "replace": "projects/word-weaver/src/config/config.ts",
                  "with": "projects/word-weaver/src/config/config.fr.ts"
                }
              ]
            },
            "moh": {
              "fileReplacements": [
                {
                  "replace": "projects/word-weaver/src/config/config.ts",
                  "with": "projects/word-weaver/src/config/config.moh.ts"
                }
              ]
            },
          "ghpages": {
              "fileReplacements": [
                {
                  "replace": "projects/word-weaver/src/environments/environment.ts",
                  "with": "projects/word-weaver/src/environments/environment.ghpages.ts"
                }
              ]
            },
            "netlify": {
              "fileReplacements": [
                {
                  "replace": "projects/word-weaver/src/environments/environment.ts",
                  "with": "projects/word-weaver/src/environments/environment.netlify.ts"
                }
              ]
            }
}

Currently, running ng build --configuration=ghpages,moh just silently ignores the file replacements defined by the ghpages configuration.
Describe the solution you'd like
We would ideally like to build our application using the following commands:
ng build --configuration=ghpages,fr or ng build --configuration=ghpages,moh or ng build --configuration=ghpages,fr or ng build --configuration=netlify,moh depending on where we are deploying and how we want to configure our application.
However, as has been raised in multiple other issues (https://github.com/angular/angular-cli/issues/22424, https://github.com/angular/angular-cli/issues/11149, https://github.com/angular/angular-cli/issues/16688), merging fileReplacements across multiple configurations is not supported.
I would strongly prefer (and indeed our entire team expected) the functionality to be as described here. But, in the absence of that being supported - I think there should be a warning produced by Angular CLI since currently running ng build --configuration=ghpages,moh just silently ignores the file replacements defined by the ghpages configuration.
Describe alternatives you've considered
Currently we have to create different configurations for each combination which has quickly led to a dozen configurations in some projects which is frustrating to manage and not very DRY. I hope there is a better solution in the future, but a warning when certain configurations are being ignored would also be better than the current implementation.

The Angular CLI similar to TypeScript works by overridden the options and not merging. This is documented in https://angular.io/guide/workspace-config#alternate-build-configurations.
This does not apply soley to the fileReplacements but all the options. In this case, adding warning for each override would be too verbose.


Birth Spacing Preference - Subnational

Calculated subrationally to help model women's preference for spacing between births, to be used as needed in calibration.

Data file produced with results by region and residence.
birth_spacing_dhs_region.csv

Issue Closed: PR #319


Wrong location syntax for NGINX newer then 0.8.41

Information
https://whatismybrowser.com/w/MLNCGRF
Details
# reverse proxy
location / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Description
Wrong:
# reverse proxy
location / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Correct:
# reverse proxy
location ^~ / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Steps to reproduce
Open this link
Expected behavior
I expected to have ^~ after location directive.
# reverse proxy
location ^~ / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

See also: https://nginx.org/en/docs/http/ngx_http_core_module.html#location

In versions from 0.7.1 to 0.8.41, if a request matched the prefix location without the "=" and "^~" modifiers, the search also terminated and regular expressions were not checked.

Screenshots

When you say the syntax is "wrong", how does the routing behaviour break/change? Can you give an example of requests that are being routed incorrectly as a result of this?

Here is my use case:

I have a internal site: http://<IP_ADDRESS>:3000
I need a reverse proxy that route ALL traffic through NGINX

I tested. When using location /, only the / been routed in NGINX 1.23.2. The /style.css won't route, it will get 404 not found.

Ah I see, because nginxconfig.io/general.conf contains a regex location block for CSS files.

Hm, I'm not sure updating the proxy location to be ^~ / is the best idea here then, as it'd break the settings under nginxconfig.io/general.conf for asset expiration etc.
I wonder if there's a better way to apply those expirations while still allowing the proxy to work to catch all requests.

Oh, I just realized that I have a few location directives in the general.conf.
I see this in the doc:

Among them, the location with the longest matching prefix is selected and remembered.

That's why location / unable to proxy *.css files.
I can only find a way to proxy those asset files:
# reverse proxy
location / {
    resolver <IP_ADDRESS>;
    set $upstream_host my-app;
    proxy_pass            http://$upstream_host:50050;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

# assets, media
location ~* \.(?:css(\.map)?|js(\.map)?|jpe?g|png|gif|ico|cur|heic|webp|tiff?|mp3|m4a|aac|ogg|midi?|wav|mp4|mov|webm|mpe?g|avi|ogv|flv|wmv)$ {

    resolver <IP_ADDRESS>;
    set $upstream_host my-app;
    proxy_pass            http://$upstream_host:50050;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;

    expires 7d;
}

But I don't know what NGINXCONFIG can do in the existing preset. I think you might be able to add a new Reverse Proxy Presets for this.

I made a prototype for this context. (Route all requests)

hack way. not recommended.

@MattIPv4 Maybe turn off expires settings when enable Reverse proxy is a good choice?

I don't think disabling it would be the right move, as other domains in the tool might still be using it without a reverse proxy.
I think the best move would be to add a warning to the expires section in the tool when any domain is using the reverse proxy -- we show warnings in a few other places in the tool so I think it makes sense to lean into a standard UI/UX convention here.
With that warning in place, I'm fine with then switching the proxy block to using ^~, as I believe this was probably the intended behaviour all along. As that's then a regex operator, I believe it'll take precedence over the expiration blocks further down in the config, 'cause the logic for regex blocks is just the first matching block in the config?

Information
https://whatismybrowser.com/w/MLNCGRF
Details
# reverse proxy
location / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Description
Wrong:
# reverse proxy
location / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Correct:
# reverse proxy
location ^~ / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

Steps to reproduce
Open this link
Expected behavior
I expected to have ^~ after location directive.
# reverse proxy
location ^~ / {
    proxy_pass            http://<IP_ADDRESS>:3000;
    proxy_set_header Host $host;
    include               nginxconfig.io/proxy.conf;
}

See also: https://nginx.org/en/docs/http/ngx_http_core_module.html#location

In versions from 0.7.1 to 0.8.41, if a request matched the prefix location without the "=" and "^~" modifiers, the search also terminated and regular expressions were not checked.

Screenshots

same