What it donwloads before actual file

Please follow the guide below
MAIN ISSUE
I am downloading a playlist from youtube
One of the video as you can see in the screenshot that the actual size of video is about ~7MiBs  before downloading this video it downloads a file which is more than 50MB what us that thing??
**MAIN ISSUE **

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x
x` into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.05.07. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2017.05.07

Before submitting an issue make sure you have:

[ ] At least skimmed through README and most notably FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ x

] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
**MAIN ISSUE**
I am downloading a playlist from youtube
One of the video as you can see in the screenshot that the actual size of video is about ~7MiBs  before downloading this video it downloads a file which is more than 50MB what us that thing??

**MAIN ISSUE **

...

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
issue
MAIN ISSUE
I am downloading a playlist from youtube
One of the video as you can see in the screenshot that the actual size of video is about ~7MiBs  before downloading this video it downloads a file which is more than 50MB what us that thing??
**MAIN ISSUE **

It download two best video file (129MiB) and best audio file (17MiB) and then muxes them together.

Okay Thanka alot!!😃😃
On Mon, May 8, 2017 at 4:54 PM, Sergey M<EMAIL_ADDRESS>wrote:

Closed #13025 https://github.com/rg3/youtube-dl/issues/13025.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rg3/youtube-dl/issues/13025#event-1072657633, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AXtYYmMbkzbBJPYpjeTNWYYmyCEKnmMMks5r3wKKgaJpZM4NT1-G
.


Adding a 'frames' array in returned data for ffprobe() call with '-show_frames' option

Adding a 'frames' array in the returned data when calling ffprobe() with the '-show_frames' option, containing the entire set of information about video/audio frames. The current call of ffprobe() allows '-show_frames' option to be added, but the returned data does not contain this information, because of lack of this property (as array of 'frames') in the 'data' variable and not parsing the 'frame' blocks in the data returned in 'stdout' from the 'ffprobe' command.

+1 for adding this - we have a patch package doing this in our repo now!


⚠ ClamAV has degraded performance

In bfef677, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 216 ms

Resolved: ClamAV performance has improved in fbc04b7.


Issue building

Whenever I try to build and run I get this.

Any ideas?

Hmm, seems to work If I just build the jar then put it in my actual mods folder.

Different issue, how do I add another mod? If I add another jar to the loadedJars, it completely breaks the parenting in mod menu. Do I have to do something else?


Branch naming not working for types other than feature

Detailed description
When we try to create a PR or branch and the cli prompts us to select the type of branch, if we select the type other, instead of prompting to select among the other types (bugfix, dependency, deprecation, etc), it jumps straight to branch naming and ends up using "other" as a prefix.
Check this video:
https://github.com/InditexTech/gh-sherpa/assets/155542567/02ab12d5-1495-4e55-9eb6-a0c0921ccf36
Expected behaviour
When we select other in the type of branch prompt, it should offer other branch types allow the user to select among them. Like the following screenshot from a previous version of sherpa-cli:

Hi! Thanks for reporting this issue. We will review this behavior and address it.

@lluisoh , we're going to release a new version in a few days with this fix and some additional features.


Docker Deployment

When I try to build with Docker I get the following issue
ERROR: Could not build wheels for gevent which use PEP 517 and cannot be installed directly
ERROR: Service 'worker' failed to build: The command '/bin/sh -c pip install --no-cache-dir -r /requirements/production.txt     && rm -rf /requirements' returned a non-zero code: 1
I am on Ubuntu 18.04.

I was about to post exactly the same thing. I'd be very interested in the solution to this

Same issue here.

Hi Could you send me the Docker Image which you are using? I can fix this issue.


Refactor to use same symbol for type casting and conversion for unsafe numeric types

Purpose
This fix will provide to use same conversion symbol for type casting and conversion.
We need to remove error type from conversion symbol for type casting since type casting will be panic in unsafe conversion.
This pr will also make float to int and decimal to int conversions unsafe as per spec.
This will fix the tests accordingly.

Codecov Report

:exclamation: No coverage uploaded for pull request base (refactor_builtin_functions@e5bce8e). Click here to learn what that means.
The diff coverage is 100%.

@@                      Coverage Diff                      @@
##             refactor_builtin_functions   #13703   +/-   ##
=============================================================
  Coverage                              ?      65%
  Complexity                            ?      426
=============================================================
  Files                                 ?     2126
  Lines                                 ?    93575
  Branches                              ?    12352
=============================================================
  Hits                                  ?    60830
  Misses                                ?    27828
  Partials                              ?     4917

Impacted Files
Coverage Δ
Complexity Δ

...inalang/compiler/desugar/StreamingCodeDesugar.java
96.73% <ø> (ø)
0 <0> (?)

...alang/compiler/semantics/analyzer/TypeChecker.java
86.08% <100%> (ø)
0 <0> (?)

...rinalang/compiler/semantics/model/SymbolTable.java
96% <100%> (ø)
0 <0> (?)

...e/src/main/java/org/ballerinalang/bre/bvm/BVM.java
79.36% <100%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bce8e...ee16945. Read the comment docs.


span: Add Logs method to export logs

Logs are meant to be actionable data which requires to them to be
treated differently than traces, this commit allows accessing logs
from a Reporter to be sent to a logger.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-0.08%) to 85.055% when pulling 6b98be4f2af34635936a76d8ab65d1628707b544 on omeid:master into 54f0695650e74655284b474d26626363335c0736 on uber:master.

Can you rebase master? I just added a fix that's breaking the builds

Thanks a lot for the swift response and review everyone.
@black-adder's suggestion and the fx approach to logging seems to be a better option; it composes much better with jaeger/opentracing and is fairly more flexible, I managed to pull the initial implementation pretty quick for our project so I am going to close this pull request.
Perhaps the logging composition approach could be documented somewhere :)
Thanks again!


Remove references to popen2, replace with subprocess

This is another library that has been deprecated in modern pythons.

I have some changes for this in the runtime code which I should probably clean up and make a pull request for...

Cool. There were not many occurrences.
Sent from a mobile device. Please excuse my brevity or transcription errors.

On Apr 23, 2015, at 15:35, Dirk Hufnagel<EMAIL_ADDRESS>wrote:
I have some changes for this in the runtime code which I should probably clean up and make a pull request for...
—
Reply to this email directly or view it on GitHub.


Deployed helm releases disappear from 'Running Apps' list after deploy is complete

Today I was able to successfully deploy my 2-chart stack, which is great. However, I noticed that after the app deploy was complete both helm releases disappeared from the "Deployed Apps" page in the supergiant admin UI.

Details: I am deploying 2 charts, stable/postgresql and my rails app chart. Both charts appear on the list of Running Apps while they are in a state of deploying. Both charts then disappear from the list once their deployment is complete.
I wanted to try deploying a vanilla chart from the supergiant admin but I was unable to try that because the "Create Running App" page doesn't get any form field values filled in.

The root cause is that they disappear if they fail.
What should happen is that the user should get some sort of failed notification.

These failed notifications now exist on 1.0 and 2.0


fix: heap out of memory error when run yarn build

Description
fix the immer version in resolutions will cause heap out of memory during yarn build.
remove the resolution first, but this may cause the security analysis fail

Task Item
#minor

Screenshots

@srinaath @hatpick can you help verify if this fixes this issue, i can't repro the original issue

@srinaath @hatpick can you help verify if this fixes this issue, i can't repro the original issue

I dont think this fix is needed. I tried yarn build a couple of times on main. It seems to  work.

I dont think this fix is needed. I tried yarn build a couple of times on main. It seems to  work.

I got the same error on another branch, I bypassed it by increasing the max heap size.
https://github.com/microsoft/BotFramework-Composer/blob/3ac3ea526141bd702b889c94e6c64f88e6ef594c/Composer/packages/client/package.json#L11

I got the same error on another branch, I bypassed it by increasing the max heap size.
https://github.com/microsoft/BotFramework-Composer/blob/3ac3ea526141bd702b889c94e6c64f88e6ef594c/Composer/packages/client/package.json#L11

@lei9444  @boydc2014 temporarily closing it. @hatpick and me tried again this morning on main and yarn build works. @yeze322 can you make sure to try again on main.

@lei9444  @boydc2014 temporarily closing it. @hatpick and me tried again this morning on main and yarn build works. @yeze322 can you make sure to try again on main.

@srinaath I'm on the webchat branch, the error can appear. (encountered in two of my Windows PCs)

It's not a blocker to me, my workaround is increasing the heap size

@srinaath I'm on the webchat branch, the error can appear. (encountered in two of my Windows PCs)

It's not a blocker to me, my workaround is increasing the heap size


Allow relative images to display in README files

Relates to #314
So this does fix the issue in the GitHawk README, but we're still going to have issues with links going to relative destinations such as to a guide MD file or similar.
Thinking we need to check the file extension, see what the type is?
@rnystrom Advice?

Good point. Lets tackle that next.
Sent with GitHawk

Ah dang, this doesn't work now that I removed issue shorthand from readme's (b/c the owner and repo is nil in that case). Might need to change that into an options mask.

Ahh bummer! Revert the change and I'll try and approach the issue again!

@Sherlouk np! This was the right way to do it, just stepped on your toes lol. I'm fixing it up by adding the options mask to MD parsing, that way we can always deliver owner+repo but add options like issue shorthand, base url, etc and have different parsing behavior on different surfaces.

Hmm, even after fixing it, I can't get the relative image to show up in the GitHawk readme. I'll push my changes @Sherlouk mind taking a look?

Taken a quick look but may need to leave it until morning - The base URL is definitely getting through correctly when the request is being made so bit confused actually
Was definitely working with the original implementation on the GitHawk readme

Ya the base URL is being used for sure. Maybe it's a simulator issue, trying on device.
Sent with GitHawk

Admitting defeat for tonight because I need sleep, will take look tomorrow
Maybe a different approach would be to use a regex detecting relative URLs, iterate through them and prefix them manually before we even render the UIWebView? That way we can switch it out depending on the URL extension (MD different than PNG etc)


config/*.json file, class not found and activebus folder

1/  when running transformers/script/run_ft.sh, I wonder where I can find a example of json config file, the link in the description seem have been broken.
2/  In file transformers/plot/job.py I can't import 2 class LineAttnPlot, AspectLineAttnPlot, they seem not presented on the repo.
3/ the preprocessing code link in transformers/model_cards.md have been broken.
4/ there are a folder call activebus have been mentioned in the instructions, where can I download them from.
It would be nice if you can verify them and suggest some solutions to these issues.

I've solve the issues 1 and 4, but 2 and 3 didn't get any improvements. Also I run into a issues when running LatentOTJob, where can I download the file data/ft/ot/14/laptop/antt.txt?

@howardhsu can you check the class AspectLineAttnPlot and file data/ft/ot/14/laptop/antt.txt
thanks you


Support KV v2 backend in Vault provider

The current provider for secrets from HashiCorp Vault does not work for secrets stored in the KV version 2 backend. It leads to errors retrieving secrets. This is due to differences in the JSON structure of the response (wrapping in an additional "data" object). Note that KV v2 has the path to the secret include an additional "data" segment as well, e.g. "secret/data/path/to/it" for a secret "path/to/it". However this is compatible with current implementation of the secret provider in secretless-broker (ensuring the ID covers the proper path).
Proposal to support KV v2 backend: extend the current Vault provider in secretless-broker to parse an optional version indicator in the ID of the secret being retrieved. Currently it accepts: "path/to/secret" (with implied field "value") and "path/to/secret#somefield" with explicit field "somefield". This could be extended to support an optional version and delimiter prepended to the ID, e.g. "v2:path/to/secret" or "v2:path/to/secret#somefield". When omitted it should imply "v1", to not break current current behavior and expect the KV v1 backend.

@michael2m thanks for filing this request!
I'm not sure what our timeline for making this change would be, but if you're interested in contributing you can find more info in our Secretless Contributing Guide and in our general Conjur Contributing Guide. You can also contact us on Discourse - we have a channel specifically devoted to Secretless development, and we'd be happy to help you get up and running.

Per @michael2m's email request, I've marked this as implementing for him 🎉

Fixed via #1345 and queued for next release (>= 1.7.1). Thanks @michael2m - much appreciated!


CMake 3.0.2 fails when building for Android

Failure related to the fact that before a certain version (3.2?) CMake defined the SYSTEM_NAME on Android as Linux, not Android, so this file https://github.com/OSVR/OSVR-Core/blob/master/cmake/PlatformDefinitions.cmake fails to set up the header right.
h/t @janoc for finding this one.

I have "worked around" this at the OSVR-Android-Build level with documenting this: https://github.com/OSVR/OSVR-Android-Build/commit/10d37f52a58a261d8c7e39d947934e575fad4810#diff-04c6e90faac2675aa89e2176d2eec7d8R13
Not sure if that's sufficient, or if we should be enforcing the higher version

I would at least check the CMake version when building for Android and emit a warning/error there. There is no need to require higher version for other platforms. Otherwise the dev could miss that req ("hey, it compiled fine for Windows!") and waste a lot of time tracking this down - it is not really obvious from the error messages what is going on.
Alternatively, this could be perhaps fixed by changing those #ifdefs in the USBSerial library - nothing else seems to be using these macros.

Well, and that library is actually being skipped right now in the build for Android.

I have managed to build it without issues once the CMake problem was found. If you want to run servers on Android, that lib could be useful.

Yeah, the trouble is that the header/interface used by the Linux version of that code isn't included before Lollipop, so we'd need to write an android-specific version - see https://github.com/OSVR/OSVR-Core/issues/125


feat(item-layout): add component

Description

Extracted styles from dialtone-vue component
Added documentation

Note: Vue API section and preview are not working currently, this will be fixed after releasing and updating dialtone-vue.
Pull Request Checklist

[x] Ask the contributors if a similar effort is already in process or has been solved.
[x] Review the contribution guidelines.
[x] Use staging as your pull request's base branch. (All PRs using production as its base branch will be declined).
[x] Ensure all gulp scripts successfully compile.
[x] Update, remove, or extend all affected documentation.
[x] Ensure no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).

Obligatory GIF (super important!)

I had issues deploying dialtone-vue I'll update and merge this when I'm back. item-layout component has the styles embedded currently so there'll be no problem.


Add deploy previews and update master branch

Create connection with netlify or vercel (i.e. test-ictresearchmethods.vercel.app) and make sure that all the PRs have deploy previews. Will help to see the impact of changes.
Also: add the master branch als default branch and delete development. This also requires some configuration in the ftp actions.

This is fixed now, but keep it open for testing purposes. Will delete it after a few weeks. First making sure everything works as expected

https://test-ictresearchmethods.netlify.app/


Add support for CV

The initial code was taken from: https://github.com/eaplatanios/eaplatanios.github.io/blob/00409c61fd173d2cab1c2d25188122a443f9e4b4/_pages/cv.md
I made some changes, mostly to make it work with dark mode.
I also added demo data for the CV.
This may need more work for formatting, etc.

I just wonder - shouldn't the contents of cv.html and cv.md be exchanged? The *.md file now contains the layout which I think is not intended?

Yes, I agree. But in that case, the empty cv.md file must be there in _pages folder.

@rohandebsarkar, just wanted to say thank you for implementing support for CV, this is awesome! 🙌
I'll try to review this PR as soon as possible and will hopefully have it merged shortly after that.

@alshedivat thanks for your suggestions. I have resolved a couple of them, but I will be away for a week. Will try to take a look at them after I am back.


The column "Value" does not support array variables while deploying

We are using array variables in ADF pipelines which looks like this for ex [{"A":"B", "C","D"}]
While deploying the code we are getting "Unexpected token" . Will this feature be added in the future?

That is NOT valid array:


Limit zoom out/drag to min/max range

Hello,
Is there a way to limit zoom out to not go over the axis min and max value ?
Currently when i zoom out too "far" i see not drawn areas which could lead to the wrong feeling that no data exists but that could not be true, just because we did not receive the information.

Maybe it's possible to use/update the xExtent attribute of the zoom listener ? But i don't know how to update it when dataset is also updated

I think you'll have to wait for v2 for this kind of things. Fortunately, you probably won't have to wait much long (I'm hoping it to be released by the end of the year).

Thanks for the update. I will wait for v2


Fix simple typos in feature-gates.md (#18275)

I fixed few typos in feature-gates.md
Related issue is https://github.com/kubernetes/website/issues/18275

/assign @gochist

Re-assign to the next PR wrangler after winter holidays
/unassign
/assign @mistyhacks

/unassign

@sftim
Could you add approve label to this issue?

As of yesterday (#18398) yes I can.
/approve

As of yesterday (#18398) yes I can.
/approve

It's a great news!!


When I try to install Command Line Tools for Xcode 8, my Mac tells me it's incompatible with macOS Sonoma.

Is there some other way to install it that I'm not aware of? I hope this doesn't mean that skhd is no longer supported. It has an integration with an app I use, and I was really excited to get it up and running.

The newest version of command line tools (or even XCode) should work fine.


[NOJIRA] Add z-index 1000 to RichSelectList

Problem in the application:

Problem repro-d on the demo site:

After fix on demo site:

I don't think this is the right solution.


Sections

If I want to write a book or translate a book with notebooks in fastpages, how can I make sections. Titles of sections and subsections instead of titles of posts, is that possible?

Not at the moment, the best thing we have is tags.  Perhaps you can discuss on the forums to try to recruit someone to work on this


Windows compilation fails / bug

Hello,
First thanks for your work. We are using it for Steam integration with our project.
I just wanted to report back to you some issues we found in the Windows part of the code.
This line won't compile, val should be buf:
https://github.com/icculus/steamshim/blob/c49d0dfffc0381ed38e333f82fdac0e12840780a/steamshim_child.c#L72
This ternary seems to be backward:
https://github.com/icculus/steamshim/blob/c49d0dfffc0381ed38e333f82fdac0e12840780a/steamshim_child.c#L74
It should be:
return ((rc > 0) && (rc < buflen)) ? buf : NULL;
SIGPIPE does not seem to be supported on Windows, so those 2 lines don't compile:
https://github.com/icculus/steamshim/blob/c49d0dfffc0381ed38e333f82fdac0e12840780a/steamshim_child.c#L188
https://github.com/icculus/steamshim/blob/c49d0dfffc0381ed38e333f82fdac0e12840780a/steamshim_child.c#L208

also CreateProcessW fails with invalid parameter because no startup info is passed in. This works (though not sure if ideal).
STARTUPINFO sinfo = {};
sinfo.cb = sizeof(sinfo);
return (CreateProcessW(TEXT(".\\") TEXT(GAME_LAUNCH_NAME) TEXT(".exe"),
                           GetCommandLineW(), NULL, NULL, TRUE, 0, NULL,
                           NULL, &sinfo, pid) != 0);


Fix freshness when linking is interrupted.

Fixes a scenario where hitting Ctrl-C while linking would leave a corrupted executable, but Cargo would think it is "fresh" and fail to rebuild it.
This also includes a separate commit which adds more documentation on fingerprinting.
Fixes #7767

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Truncating the file seems a little hacky, but it seemed like a reasonable way to invalidate the fingerprint. I don't want to delete it because that would break the compare debug logging in some cases.

:umbrella: The latest upstream changes (presumably #8073) made this pull request unmergeable. Please resolve the merge conflicts.

@bors: r+
Ah ok that was a key part I was missing. This workaround isn't necessary for a one-unit compilation, but it's required for multi-unit compilations where you don't change the source of previous compilations. This happens because we don't hash the contents of each output, we just rely on mtimes. In any case looks good to me :)

:pushpin: Commit 14e86cc7037ba6a552c0a248e72747e1dec03702 has been approved by alexcrichton

:hourglass: Testing commit 14e86cc7037ba6a552c0a248e72747e1dec03702 with merge 53b1c48a51c2835dfa0151972339341725991d5a...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 53b1c48a51c2835dfa0151972339341725991d5a to master...


change text color on some dates in calendar

hello i read all the documentation but i am unable to do two things

hide and disable next button button on calendar toolbar (Next month arrow on top header)
make a custom selection of dates in month and also change their text color to red like [2,10,17,30]

i also posted this on stackoverflow here  but there is no response from anyone please help with these two things. Thanks

To disable the next arrow on top header you have to specify a maximum date value with the code below:
calendarView                 .state()                 .edit()                 .setMaximumDate(maxCalendarDay)                 .commit()
Have you tried the code below to change the text color? It works for me.
view.addSpan(ForegroundColorSpan(ContextCompat.getColor(context, R.color.cerulean)))


Removes reserved shortcut from 'aad approleassignment list' objectId option. Closes #1607

Coverage remained the same at 100.0% when pulling 94d47d1c2937402532916dfb35941fc7c1c6f7af on VelinGeorgiev:objectId-approleassigment-fix into f99b45527e9abc3f50198e7e0de336fc3cce5095 on pnp:dev.

Merged manually. Thanks! 👍


rename the rename_to_href function

Sorry, I don't see why you'd want to do this.

In commit b00d2db917cdbbe267cfcbdaa7064ef56d09c1db , one of the changes was:
- Changed "href" to "self" under "links".
So I thought it would be better to change the function name as well and I saw that the name change has no side effects.

OK, that makes sense.  I see that tests are failing, but that's due to early broken merges.  I think fixing tests is the priority over any code cleanup, however, so looking to other maintainers to judge if this is ready to merge.

I plan to use this in a project so I'm keen to collaborate however I'm no expert coder (especially when it comes to collaboration) so I might have some beginner's questions:
You said that fixing tests is the priority. However, what if the tests themselves are not testing the code to the current standard. For example, the current stable specifications for JSON API states that attributes should be stored in an attribute object. The current renderer doesn't do this. So what should the next step be? Fix the tests without modifying the code (i.e. keep the older specifications for now) or modify the code AND fix the tests. Sorry, I'm lost here!

This project is in a transition.  It was written against RC2, and significant changes were made to the JSON API spec in 1.0.  In the meantime, the initial contributors have moved on.  In my case, I expect it will be 6-12 months before I think of transitioning my own project to JSON API 1.0.
I believe the 1.0 effort is in PR #31 - you might want to take a look at that branch.

@jwhitlock
This is a small change and albeit we're with failing tests, they're not reflecting the current JSON API spec.
I'm trying to organize myself to go back and look to this project more often and really want to help.
I have the same doubt as @abdulhaq-e: should we start by making tests pass with the current implementation or send new pull requests with 1.0-compliant code ignoring unrelated tests until we reach a stable test suite?
I'm not a big fan of waiting for a big pull request like #31 - taking advantages of baby steps seems to be more effective in cases like this.
What do you think?

Oh! And I'm fine to merge this one as is.

should we start by making tests pass with the current implementation or send new pull requests with 1.0-compliant code ignoring unrelated tests until we reach a stable test suite?
I'm not a big fan of waiting for a big pull request like #31 - taking advantages of baby steps seems to be more effective in cases like this.

I modified the code to become compliant with 1.0 specifications and modified the tests along with it. Unfortunately, I couldn't do it through a step-by-step approach, i.e. a branch/commit for each "feature" because the change is large. I will have a pull request ready in a few days.

Baby steps is OK with me, especially since I don't have the bandwidth for the 1.0 conversion either.


Extend the integration test to test state sync on startup

We should have a better way to test state synchronization upon restart that happens in relatively rare cases of "restart during previous state synchronization". We do have unit tests for separate modules, but we don't have a good integration test (that would test these things including the chunks).

Dupe of #766 ?

Haha yup!


The conflicting result files of FVC

Hello, I ran FVC in a WGS file and got 5 files in the end: RP-347-8_test_out_indel.out, RP-347-8_test_out_snv.out, RP-347-8_filtered.vcf, FVC_predict_indel.txt, FVC_predict_snv.txt. I thought FVC_predict_* files are the lable and probability of each variant, but I found a variant is 0 and probability is 0.0012222216 in FVC_predict_snv.txt but in RP-347-8_filtered.vcf FVC=1 and FILTER=PASS. So which result should I use and why does FVC make this result?
FVC_predict_snv.txt
chr     loc0    loc1    ref     target  prediction      probability
11      7694640 7694640 A       *,T,<NON_REF>   0       0.0012222216
RP-347-8_filtered.vcf
11      7694640 .       A       *,T,<NON_REF>   0       PASS    DP=73;ExcessHet=0.0000;MLEAC=1,0,0;MLEAF=0.500,0.00,0.00;MQRankSum=0.000;RAW_MQandDP=262800,73;ReadPosRankSum=2.285;FVC=1     GT:AD:DP:GQ:PGT:PID:PL:PS:SB    1|0:33,30,0,0:63:99:0|1:7694612_GT_G:1409,0,1278,1245,1323,2563,1389,1365,2587,2730:7694612:21,12,21,9

Hi Liu,
Could you please provide the VCF with the target variant and the bam file including the region chr11:7693640-7695640?

Hi Ren
Here are the vcf file and bam file in attechment and the ref file I use is ensembl release-80 Homo_sapiens.GRCh38.dna.primary_assembly.fa. The vcf file is generated by GATK HaplotypeCaller. Here is the command when I ran the FVC:
bash ~/software/FVC/Features_construction.sh -i RP-347-8.g.vcf -b RP-347-8_markdup.bam -r Homo_sapiens.GRCh38.dna.primar -p RP-347-8_test_out_snv.out -q RP-347-8_test_out_indel.out
bash ~/software/FVC/Supervised_learning_filtering.sh -f filter -i RP-347-8.g.vcf -o RP-347-8_filtered.vcf -p RP-347-8_test_out_snv.out -q RP-347-8_test_out_indel.out -m /home/liuxubing/software/FVC/Pre-trained_Models/gatk_snv_xgbdef.model -n /home/liuxubing/software/FVC/Pre-trained_Models/gatk_indel_xgbdef.model
@.***
From: yyren
Date: 2022-11-02 12:49
To: yyren/FVC
CC: liu-xu-bing; Author
Subject: Re: [yyren/FVC] The conflicting result files of FVC (Issue #1)
Hi Liu,
Could you please provide the VCF with the target variant and the bam file including the region chr11:7693640-7695640?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Liu,
I am sorry I can not find the attached files both here and in my email. Could you please provide a website where I can download or send the files to my email<EMAIL_ADDRESS>

Hi Liu,
Thank you for pointing out this problem.
The predicted results of the SNVs (RP-347-8_test_out_snv.out) were not combined into the final results. We have updated the script 'merge_predict_results.pl'.
Please contact me if you have any other questions.

Hi Ren
I have tested the new FVC and got the right result.
Thank you.


[Program Card Images] [Admin] Implement program card preview UI

Sub-issue of main epic issue #5676

Implemented with https://github.com/civiform/civiform/pull/6227


feat: modal of drill to detail on the dashboard

SUMMARY
This PR is a preview version of Drill to detail modal on the dashboard. The backend was implemented at PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/2016594/178708825-d3be296e-2022-42f0-a921-76daa3a13c9c.mov
TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

pass this PR to cody, he work at: https://github.com/apache/superset/pull/20728


Typo on page

Issue in ./help/data-sheets/overview.md
You spelled Adobe Adobbe

Thanks for reporting. Fixed.


Multi inheritance tests

Tests for how multi inheritance works for packages.
😄 - DIR operation finds decorated endpoint routes from both parents.
😦 - Instance init only calls the first parent's implementation.
Workarounds demonstrated in the tests.

Dave these are some nice tests -- if you rebase on main I think they'll start passing; Maybe we keep this PR just to add extra robustness around PackageService rather than close it w/o merge.


Deployment contracts in grace period

Description
Prevent deployment on nodes with contracts in the grace period.
Changes
Screencast from 31-07-24 16:38:10.webm
Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/3025

Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

I would recommend excluding these nodes from the filters
also, if this is important info that the user should know, we can display a dialog with the nodes that are excluded.
But, I think it's not a good behavior to tell the user that this node isn't available after filtering, he user needs to deploy with only a single click.

@Mahmoud-Emad I think we had an issue for displaying them before, @AhmedHanafy725 what do you think?

IMO, we should show the node to him and notify him that the contract is in a grace period instead of hiding it and he will keep looking for why it's not on the list


Unable to start on raspberry pi

I am trying to use this on my raspberry pi, however, I am running into an issue. It would see that it has python 2.7 and python 3 installed, and it is defaulting to v2.7. Is there any way I can run the command "catt" and tell it to point to python 3?

Install with: pip3 install catt

Alright I'm going to make a patch release.

@skorokithakis Please wait a couple of hours. There's no need to rush out a release, because of something that is not an actual bug.

@theychx I did try using pip3 install catt , but it still produces what I have in the screenshot. I tried to remove python 2.7 and ended up screwing up my pi install.

@theychx There isn't really anything in this potential release, just the error message when trying to install on 2.

@skorokithakis https://github.com/skorokithakis/catt/compare/v0.9.2...master

@skorokithakis will this fix anything regarding my issue or is there something else I should do to make this work given my situation?

@theychx Hmm, we may need to be more diligent about our commit messages so they get included in the changelog...
@talormanda It makes catt installable only on 3, so it would refuse to install on an older Python. Can you try to install from HEAD?

@skorokithakis - sorry, I am unsure what HEAD is. But I can research and try if it is hard to explain

I just meant clone or download the repo and install that.

I just meant clone or download the repo and install that.

excuse my dumbness, I don't know how to install from the repo after downloading the files.


Resizing window results in content moved away

✍ Bug Description
I'm trying to use saucer on my WebView based C++ app. It seems working fine, but if I resize window on macOS the WebView content is moved. In my app (not public), the Y coordinate goes negative and cannot go back to the top of the content. It is also (likely) reproducible in the official example examples/embedded; it simply cleans up the content (looking like blank page) there.
It is probably specific to wk.webview.mm but I haven't confirmed on other platforms.
🔁 Steps to reproduce
on macOS, launch examples/embedded and resize the window.
❔ Expected behavior
Resizes normally.
👀 Screenshots

🛸 Saucer Version
7e9c730
🖥 Operating System
MacOS
🧰 Compiler
AppleClang <IP_ADDRESS>00026
📦 Environment
macOS Sonoma 14.7
🖥 Distribution
No response
✅ I confirm that...

[X] I have collected all the required information and read all the comments in this document
[X] I searched for an existing bug report for this issue
[X] the problem does occur with the reproduction steps I provided
[X] what I described is indeed a problem

I cannot reproduce this, which WKWebView version are you running?

Not sure what is the expected answer as I don't really indicate the version of WebKit in particular, but I guess this gives the info:
$ head /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/WebKit.framework/Versions/Current/WebKit.tbd
--- !tapi-tbd
tbd-version:     4
targets:         [ x86_64-macos, arm64-macos, arm64e-macos ]
install-name:    '/System/Library/Frameworks/WebKit.framework/Versions/A/WebKit'
current-version: 619.1.26
reexported-libraries:
  - targets:         [ x86_64-macos, arm64-macos, arm64e-macos ]
    libraries:       [ '/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy',
                       '/usr/lib/libobjc.A.dylib' ]

And this happens on the embedded example without any changes? If so, could you check if the bug also reproduces on the very-experimental branch?

Okay, apparently this is related to having the dev tools open, it seems that I'll have to set autoresizingMask on the webview to prevent the devtools from pushing the content oob. I'll push a fix soon.

The answers are yes, yes, yes (the same), yes (doesn't matter), and yes (doesn't matter).

I couldn't reproduce the issue in a new VM either, but have pushed some changes to very-experimental. Please let me know if that works for you :)

Yes, it works perfectly. Thanks!

Perfect, thanks for confirming so quickly!

I will release a stable version containing the fix soon!


Add a warning when no repository was found

This PR adds a check and throws an error when not repository was found for the given options.
Before, the code was assuming that response.data.data.repository is always available which is not the case if you have a typo in your github options (which I had).
It was throwing a "cannot read from undefined" error instead which isn't very helpful for users.

Thank you!


Feature: Recursive brute force for a set of HTTP response codes

Can we have a feature where a normal brute force is running based on HTTP response like 403/401 do a recursive brute force on that endpoint?

Hi @g33kyshivam, could you provide a example please?

let's say that an endpoint /api returns a 401 response. So for my brute-force list if the response code is 401 then I want to launch a recursive brute force after /api/
so a command line switch would be great so specify these response codes which fuff would launch a recursive brute force say like
fuff -responsecode 401,403
the above should do a recursive search for that response status code

If i'm not wrong, you want an additional config to preset to tell FFUF when should do some recursive work.
Today we have
  -recursion       Scan recursively. Only FUZZ keyword is supported, and URL (-u) has to end in it. (default: false)
  -recursion-depth Maximum recursion depth. (default: 0)

You wanna add something like
-recursion-if-code 401-403

Which would prevent FFUF of do recursion in 200 for example.
That is?
Today we have a simple check:
https://github.com/ffuf/ffuf/blob/7ffd74d87e15bf7673e323a02da5c4f7582580db/pkg/ffuf/job.go#L308-L310
-mc/-fc config is not what you want, but could help by now.

That's a good idea. The current recursion detection implementation is based on the ways the current httpd's handle directories. This proposal does make sense for API recursion though.
I have previously thought that it's not that important, but I'm slowly changing my mind.


Rich text editor component breaks when switching to JavaScript placeholder

Description
Upon attempting to switch the placeholder of the Rich Text Editor component to JavaScript, the entire functionality of the component breaks down.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://function-adminportal-test.shesha.dev/dynamic/Boxfusion.SheshaFunctionalTests.Common/twenty-three-details?id=9e58861b-2b22-48e9-a5ab-05fddd8cfe13'
Navigate to form designer
Click the Rich Text Editor component
Click the placeholders's JS button

Actual Behaviour:
The component breaks and displays the error "An error has occured
i18n: Need string in first argument"
Expected behavior
Switching the placeholder property to JavaScript should not break the functionality of the Rich Text Editor component. Users should be able to utilize JavaScript for dynamic placeholder content while retaining the core functionality of the editor.
Screenshots

Added as part of release 0.34


Fix Kafka parser regex

Coverage increased (+0.5%) to 67.53% when pulling d8fe451d5fde832ef24013b7c1bff48705ef3874 on kafka-parse into ac29268d6f28c4fa28bb47c1d01fb73c3b934eb7 on master.


Document disk space unit.

LGTM =)

retest this please

I renegerated docs/docs/generated/api.hml.

lgtm


update index cards for ACC overview page

https://docs.microsoft.com/en-us/azure/confidential-computing/ - changed cards

do not merge

@angarg05 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@angarg05 - I'm putting the PR into draft mode to prevent accidental merge.  You can take it out of draft mode if you'd like to proceed with a review / merge. However, for changes to landing pages, you will need to open the PR in the private repo (and make sure you have content owner approval). Thanks.

Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @Jak-MS! How can I check if I content owner approval in my private repo? How can I see a preview of this PR/draft (it is a /yml file I have modified)?

@angarg05 - The current version of this file has changed substantially since you created this PR. If you'd like to see changes to the current file version, please open a new PR.


Automatically update NPM package new tagged releases are built.

When we create a release I would like that an automated process publishes the package to npm.

@tegud is this possible ... i was hoping we could create a tag and when a tag is created it publishes the npm package

There's complexity in requiring a commit to bump the version number in the package.json
Could look at other projects approaches.


Http2: Hyper client stuck requests

We are encountering stuck requests in hyper client even with hyper 0.14.25 which should include the fix for #2419 . I managed to reproduce our issue with a fork of the repro in #2419. My repro is here https://github.com/ylow/h2-repro
The main modification is that we issue a much larger number of requests (8K), but buffered with a futures stream so that a limited number of requests are pushed concurrently (100). It generally hangs hard after 4K+ requests.
Am I missing something or doing something wrong? Anything I can help to debug?
Thanks!

No there is a bug in my repro. Not the right repro. We are encountering a hang still with 0.14.25, but struggling to effectively repro it. Closing this for now.


TextViewWithHint fails with v-model

TextViewWithHint doesn't appear to work with v-model in Vue.
Typing into a TextViewWithHint does not update the v-model that is bound to the TextViewWithHint.
<TextViewWithHint hint="Additional Information" v-model="additional_information"  />
Thanks,
Rob

So, I've been able to access the value through a ref
this.$refs.additional_information.nativeView.text
But its a bit clunky in that the field is erased when it loses focus

Just checking: does the v-model work when using a plain old TextView?

Yep - works with plain old TextView

Thanks for confirming that. I forgot to wire something up. Fixed in 1.5.1 (available now!).

Hi @EddyVerbruggen - sorry to bug you again... Upgraded to 1.5.1, and problem persists. Thanks


jwt: add functions to parse a token

Add a new function jwt_parse_payload to parse token payload
Add a new function jwt_verify to verify token header and signature

jwt_verify now works with RSA but not with ECDSA (signature changes at each call).
I'll try to do it another way.

jwt_verify now works with RSA but not with ECDSA (as signature changes at each call).
I'll try to do it another way.

Done

The "490 ms" looks strange here?

For Mbed TLS ECDSA it might not surprise me. It depends on what code ends up getting used inside of Mbed TLS. There is an accelerated version of p256 in the tree, but I'm not sure when it might decide to use it. I'll glance at the code and see if there is anything obvious, otherwise, we might have to figure out if our mbedtls config.h we end up using in the test enabled p256m.

Is there any way to compare signatures between the implementations? A simple case might just to be a test signature. For example, if one version was misconfigured and doing a different kind of signature, just doing a round-trip test would still pass.


FLUID-6264: Deploying generated output to a deploy branch.

The Infusion-Docs repo no longer uses GitHub pages to host the site.
Changing the branch name and removing the CNAME file will reduce
confusion and keep GitHub from trying to publish to GitHub pages.
https://issues.fluidproject.org/browse/FLUID-6264
After this PR is merged, we'll need to remove the gh-pages branch from the repo and set the GitHub pages source to "none" in the repo's settings.

This looks good to me. I don't have access to the repo settings to remove the GitHub pages source, but that can be done by someone else after merge.

Can you also remove the mention of GitHub pages in the README as part of this PR?
https://github.com/fluid-project/infusion-docs#deploy-to-github-pages

@waharnum I've updated the README. Ready for more review.

LGTM, merging.
Longer term we should consider changing the "build and commit to deploy branch" step somehow (a simple Grunt task, perhaps) to remove any mention of ghpages, to absolutely minimize confusion.

@waharnum, I believe the long term solution will remove the generated site from the repo completely.

Yes, that sounds correct to me.


A server can't get itself event with pm2 cluster

i start server by pm2 start -i 2,
Server A emit event and Server B receive, but Server A not, how can Server A receive event too ?

Hi! Please check the documentation here: https://socket.io/docs/v4/pm2/

i have solved it ,thanks


Remove JSON versions of runner pages functionality

What is the context of this PR?
The jsonify call in the _render_page method is broken. When called, an exception can be thrown when it tries to serialise WTForms objects. This method should be removed from the code as it's not used and is broken.
How to review
Run make test-unit to check if no test is broken, missing and there is 100% coverage.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Remove JSON versions of runner pages functionality


Enable ethereum in xstate wallet

Seems pretty nice:

Can you add this screen to storybook relatively easily?
The use must now click twice to get ethereum enabled (once in the app, once in the wallet). I guess this is a better reflection of the current architecture, and more secure (the wallet should not expose sensitive data such as myStateChannelsSigningKey without user approval)   Perhaps we should change the button in RPS to be "Connect with StateChannels"?

Would now be the right time to fold getAddress(), getEthereumSelectedAddress() into a single channelClient.enable() API call which triggers your new workflow, including the window.ethereum.enable() step?
That way, the UI you have added is protecting the user against inadvertently exposing sensitive data such as myStateChannelsSigningKey to an app, at least without user approval.
To me, that is the real value of having the new user approval screen -- as is, it is merely forcing the user to reassert the intention that they have just expressed. (Why would they click "Connect with Metamask" in the app, and then click "No" in the wallet? You could ask the same question about a non state channel Dapp: why click "Connect With Metamask" in the Dapp and not in Metamask... but there is a good answer for that. Metamask owns the sensitive data being requested and should have the final say about releasing it).

Would now be the right time to fold getAddress(), getEthereumSelectedAddress() into a single channelClient.enable() API call which triggers your new workflow, including the window.ethereum.enable() step?

Sounds like a good idea to me, but I'd rather get this merged in first.


Deriver macro is not able to support sealed abstract classes

I noticed that recently a Schema was implemented for the zio-json Json AST, which is defined as a sealed abstract class. The relevant code can be found here: zio-schema package.scala L13.
I am wondering if it would be feasible to introduce functionality for generating derivers for sealed abstract classes. This feature would be very beneficial for some of the work in zio-jdbc towards supporting JSON column types. While a general implementation would be ideal, even a special-case solution for Json AST's would be greatly appreciated.
Looking forward to your thoughts on this.

/bounty $100

/attempt #621


[Research] Generate Oculus Store compatible APKs

Initial request
https://twitter.com/ThePra9/status/1455899334365618181
Current plan

Check if APK generated by Oculus CLI uses TWA (Trusted Web Activity):
1.1. Generate APK using Oculus CLI:

./ovr-platform-util create-pwa
  -o output.apk
  --android-sdk /opt/android_sdk
  https://example.com/manifest.webmanifest

Or to use local manifest file:
--manifest-content-file manifest.webmanifest
  https://example.com/

Check if Oculus supports TWA (Trusted Web Activity):
2.1. Generate APK using Bubblewrap (PWABuilder), try to publish it to Oculus Store via Oculus CLI or web interface (see https://developer.oculus.com/resources/publish-reference-platform-command-line-utility/#upload-quest) and make some changes to APK source code to fix errors/warnings (see https://developer.oculus.com/resources/publish-mobile-manifest/#specs).
2.2. Compare APK generated by Oculus CLI with APK generated by Bubblewrap (AndroidManifest.xml, etc.).
2.3. Check APK with fixes published to Oculus Store on real Oculus device.

Create a pull request for Bubblewrap.

Create a pull request for PWABuilder.

Write docs. E.g. document new vendor-specific proprietary web app manifest members such as:

"ovr_scope_extensions": [
  {"pattern": "*.example.com"}
]

and
"ovr_multi_tab_enabled" : true

Notes
This should be an option to not affect APKs for other app stores.

On 1, if someone can share an APK generated by the Oculus CLI I'm happy to check it out.

Hmm, for some reason I have no create-pwa command in ovr-platform-util: https://twitter.com/alexey_rodionov/status/1456689833380827137. 🤔
@jacobrossi PTAL.

the cli is https://developer.oculus.com/documentation/web/pwa-packaging/#download-the-cli
mac and widows version the zip has a pwa-template.apk included

@andreban
Here's APK: https://drive.google.com/file/d/1IAw8M0kc695GiawnBAvijfqzohrWHPbJ
I'm almost 100% sure it's not a TWA. :)

Interesting - despite being ~1mb in side, the Android Manifest doesn't have any Activity and neither does the code in classes.dex. They could make it much smaller by dropping the androidx dependencies.
Overall, their approach seems to be similar to how Trusted Web Activity works on Chrome OS on some scenarios - when the application is installed, Chrome OS reads the APK and extracts the information shipped within the app to generate an installed PWA - Bubblewrap ships a copy of the Web Manifest inside the APK.

Interesting - despite being ~1mb in side, the Android Manifest doesn't have any Activity and neither does the code in classes.dex. They could make it much smaller by dropping the androidx dependencies.

@jacobrossi @cabanier FYI. :wink:
BTW, @jacobrossi @cabanier Does Oculus Browser supports TWA (Trusted Web Activity)?

Anyone made any progress - any examples walkthroughs?

I'm still working on it. The problem is I don't have my own Oculus device. So I ask my friend who has the device to check some things for me.
Along the way, I check what PWA features on Oculus works and what doesn't. See https://github.com/immersive-web/webxr-samples/pull/135. :wink:
That's why it's so slow. :)

If you need another device I have Quest2 I can test with for you.

Good news! I finally own Quest 2. 😊
ICYMI, preview version of PWABuilder (https://preview.pwabuilder.com) offers packaging PWA for Oculus Store. 😉
@tomayac cc.
It uses ovr-platform-util under the hood. Here's the repo: https://github.com/pwa-builder/pwabuilder-oculus.

I've also checked TWA on Quest 2. I've sideloaded APK via ADB and opened it via "Unknown Sources" section. And it just opened in Oculus Browser just like regular website (not in standalone mode).
I've also sideloaded Google Chrome APK to Quest 2. :) If Chrome is installed, then TWA open in it in standalone mode (instead of Oculus Browser).

Oh, thanks for sharing, @FluorescentHallucinogen. That's really a nice feature addition to PWABuilder!

For anyone who's interested:

Packaging PWAs for Quest with PWABuilder is officially released in stable channel: https://twitter.com/pwabuilder/status/1529191206919491586.
It's the recommended way to package PWAs for Quest: https://developer.oculus.com/documentation/web/pwa-building-with-pwabuilder/.
So I've updated @tomayac's “PWAs on Oculus Quest 2” blog post: https://web.dev/pwas-on-oculus-2/.

I've reduced the size of pwa-template.apk by 1000x, from 1.2 MB to 1.2 kB! See my PWABuilder pull request for details: https://github.com/pwa-builder/pwabuilder-oculus/pull/7.
The pwa-template.apk is used in ovr-platform-util CLI that is used in PWABuilder under the hood for Packaging PWAs for Quest.

I've finally got my hands on working on pull request that adds to Bubblewrap a flag for generating universal APKs compatible with Quest that open Trusted Web Activity (TWA) on regular Android devices and open Meta Quest Browser on Quest devices. This will allow to abandon ovr-platform-util in favor of Bubblewrap.

See #704. :wink:


v10-rc3: Multiple permissions for adding blacklist records

Hey everyone,
after upgrading to v10-rc3, there exists two permissions: "Can add players to blacklists" and "Can add players to the blacklist". The later one seems to be obsolete, or is only needed for normal bans (which could be removed anyway).

Maybe one of these can be removed. Or, if both are needed, the description could be changed to something more clear.
Thank you!

Fixed!

Thank you!


Go-to-definition and find-all-references don't work on TypedDict properties

I'm on the pre-release of Pylance v2023.11.13.
class Blah(TypedDict):
    attr_a: int
    ^ (1)

x: Blah = {"attr_a": 1}
            ^ (2)

x["attr_a"]
   ^ (3)

x.get("attr_a")
       ^ (4)

Perform go-to-definition on (2), (3), and (4). Notice that only (2) works.
Perform find-all-references on any of (1), (2), (3), and (4). Notice that none of them work.
I would expect all of these to provide an answer.

Thanks for the suggestion. I agree this would be nice

It would be very nice if go to definition worked for TypedDict constructors.


A widget for all options and a widget for custom options

It seems that currently there are 3 widgets, one for all brand icons, one for all regular icons, and one for all solid icons.
I think it would be useful to allow for a single widget to include all of the icons.
I also think it would be useful to allow for a completely custom set of options in case it makes sense to present only a limited set of options that would make sense for a particular piece of content.
I imagine this change could be made without changing the API for the existing widgets, for example:
CMS.registerWidget(
  "fontawesome-solid",
  FontawesomeWidget.Solid,
  FontawesomeWidget.Preview
);

CMS.registerWidget(
  "fontawesome-all",
  FontawesomeWidget.All,
  FontawesomeWidget.Preview
);

CMS.registerWidget(
  "fontawesome-directions",
  FontawesomeWidget.Custom([
    'far fa-caret-square-left',
    'fas fa-caret-square-left'
  ]),
  FontawesomeWidget.Preview
);

It seems that currently there are 3 widgets

yes, we open for other widget request, if you need another widget one.
for the all in one icons, I think it better to create separate bundle as those will be big bundle.
about the custom set, I love it.


New tool: Dexie.waitFor() keeps transaction alive.

Inspired by @wwoods solution described  in #374 and the new indexeddb-promises proposal, I've added the method Dexie.waitFor() that may wait on a non-indexedDB Promise or Promise-returning function to complete and keep transaction alive during the whole lifetime of that task.
Implementation was also inspired by the elegant code in polyfill.js by @inexorabletash.

Typescript type definition update is missing.

@dfahlander Looks good to me, and should allow cleaner code than the writer / reader "threads" I was using.  Perhaps a smidge less performant, but more than made up for by ease of use.  Nice work :+1:


Regarding BEST PRACTICES for VIDEO on mobile browser

Question
Hi Team,
I came across your link which talks about "Best Practices for Twilio Video on Mobile Browsers". It mentioned few ideas like "Perform pre-call microphone and camera tests" etc....
My Question is - Are you guys taking care of it in this App?
Additional context
https://www.twilio.com/blog/best-practices-video-mobile-browsers

Thanks for the question @helloneeraj!
Yes - this is taken care of in this app. On the following screen, users are given a chance to verify that their video is correct (in the preview), that their audio is working (the little microphone icon indicates audio volume), and that their network connection is good. Any device errors are shown to the user in a message up in the corner:

However, I did just find a bug that prevents this error message from being displayed to the user. I have a PR here (#363) that will fix it.
Thanks again for the question. Please let me know if you have any more. I'm happy to help!


python311Packages.openai: 1.7.1 -> 1.9.0

Description of changes
Updated to latest version, and did a little bit of cleanup.
Diff: https://github.com/openai/openai-python/compare/refs/tags/v1.7.1...v1.9.0
Changelog: https://github.com/openai/openai-python/releases/tag/v1.9.0
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281620 run on aarch64-darwin 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

8 packages failed to build:

checkov
checkov.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
open-interpreter
open-interpreter.dist
shell-genie
shell-genie.dist

11 packages built:

chatblade
chatblade.dist
imaginer
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist

Result of nixpkgs-review pr 281620 run on x86_64-darwin 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

8 packages failed to build:

checkov
checkov.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
open-interpreter
open-interpreter.dist
shell-genie
shell-genie.dist

11 packages built:

chatblade
chatblade.dist
imaginer
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist

Result of nixpkgs-review pr 281620 run on aarch64-linux 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

6 packages failed to build:

khoj
khoj.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
shell-genie
shell-genie.dist

13 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
imaginer
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist

I think this should be good to merge. Notes on dependency build failures:

checkov fails due to unrelated build failure from igraph.
open-interpreter fails for unrelated reasons, fixed and updated here #281627.
llm and shell-genie both fail because they don't support openai >= 1.0.0.

Result of nixpkgs-review pr 281620 run on aarch64-darwin 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

6 packages failed to build:

checkov
checkov.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
shell-genie
shell-genie.dist

13 packages built:

chatblade
chatblade.dist
imaginer
open-interpreter (python311Packages.open-interpreter)
open-interpreter.dist (python311Packages.open-interpreter.dist)
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist

Result of nixpkgs-review pr 281620 run on aarch64-linux 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

6 packages failed to build:

khoj
khoj.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
shell-genie
shell-genie.dist

15 packages built:

chatblade
chatblade.dist
checkov
checkov.dist
imaginer
open-interpreter (python311Packages.open-interpreter)
open-interpreter.dist (python311Packages.open-interpreter.dist)
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist

Result of nixpkgs-review pr 281620 run on x86_64-darwin 1

2 packages marked as broken and skipped:

chatgpt-retrieval-plugin
chatgpt-retrieval-plugin.dist

6 packages failed to build:

checkov
checkov.dist
llm (python311Packages.llm)
llm.dist (python311Packages.llm.dist)
shell-genie
shell-genie.dist

13 packages built:

chatblade
chatblade.dist
imaginer
open-interpreter (python311Packages.open-interpreter)
open-interpreter.dist (python311Packages.open-interpreter.dist)
openai (python311Packages.openai)
openai.dist (python311Packages.openai.dist)
pentestgpt
pentestgpt.dist
python311Packages.guidance
python311Packages.guidance.dist
python311Packages.litellm
python311Packages.litellm.dist


Windows Fix

I replaced all of the instances of process.env.PWD, which doesn’t exist on Windows, with process.cwd() which, according to the Node.js docs (https://nodejs.org/dist/latest-v7.x/docs/api/process.html#process_process_cwd), is the correct cross-platform way to get the current working directory.

@churchs19 Thank you very much.  I did not know isAbsolute . I learned a lot :D

Sure thing. I'm glad I could help. This is a great extension. It just needs a little polish to make it really good.


Created Base Framework

Created application base framework with Template Studio for WinUI (C#)
Added Back button for Navigation.

Good to Go


Fix hyperpython install

hyperpython has an open issue about failure to install transitive dependencies. This PR fixes the
RTD config file to work around it and makes a note in the README.

LGTM 👍


finish can be problematic

Hello,
I ran into a problem while using Encoder in a context where it has to be switchable for other Write implémentation : the finish method has to be called to send the last bytes to the inner writer. Other Write implementation for similar purpose (like flate2 or snappy framed) will just flush the last page on drop().
Working around it is tricky: as finish() consumes self, you can not make a trivial wrapper implementing Drop around the Encoder because drop only has a &mut self...
And, you can not just add drop() to the implementation alongside finish(), because finish() returns the inner Write. I just think we can't have both, unless we have two variants of Encoder.
I see the point of being able to get the inner Write back, but I'm wondering if this feature is preferable to compatibility with other encoder (and safety, as calling drop() can not be forgotten).
What do you think ?

I ran into a problem while using Encoder in a context where it has to be switchable for other Write implémentation : the finish method has to be called to send the last bytes to the inner writer. Other Write implementation for similar purpose (like flate2 or snappy framed) will just flush the last page on drop().

Writer finish() method add end-of-compressed-stream mark and flush last page.
I think make this logic on drop() is not good idea, because in interrupted sender method we can get a correctlly closed stream (because drop() will called anyway). So I need some mark of successfully completed work.
Also drop() method can't return error.

Working around it is tricky: as finish() consumes self, you can not make a trivial wrapper implementing Drop around the Encoder because drop only has a &mut self...

You can workaround this by code like:
struct Wrapper<W: Write> {
	s: Option<Encoder<W>>,
}

impl<W: Write> Write for Wrapper<W> {
	fn write(&mut self, buffer: &[u8]) -> Result<usize> {
		self.s.as_mut().unwrap().write(buffer)
	}

	fn flush(&mut self) -> Result<()> {
		self.s.as_mut().unwrap().flush()
	}
}

impl<W: Write> Drop for Wrapper<W> {
	fn drop(&mut self) {
		match self.s.take() {
			Some(s) => {s.finish();}
			None => {}
		}
	}
}

I see the point of being able to get the inner Write back, but I'm wondering if this feature is preferable to compatibility with other encoder (and safety, as calling drop() can not be forgotten).

I make this feature because I can. I don't know how this problem solved in another encoders.

Thanks. This Wrapper would work, indeed. I have had a look at other implementations (std::io::BufWriter, flate2, snappy_framed, which are the ones I need to switch). The four of them are handling thing differently:

snappy http://docs.randomhacks.net/snappy_framed-rs/snappy_framed/write/struct.SnappyFramedEncoder.html expects the user to call flush(), and do not allow inner writer retrieval
flate2 offers finish(), but manage the inner ownership internally with an option
stdlib BufWriter goes even a bit further by handling a possible panic during the finish()

Do we need a WriterWrapper trait in stdlib ? cc @alexcrichton

I create https://github.com/rust-lang/rust/pull/32625

I try with RFC: rust-lang/rfcs#1568

Just hit this issue. Problem for me happens when I try to use this with other libraries, like slog, which  take input writers as self and simply drop to close.
Seems a bit strange that the finish method is a self, but it only calls write_end which is &mut self. Maybe you could make the write_end public instead?

Running this workaround on Rust version 0.40. throws an error (possibly due to updated error checking).
warning: unused `std::result::Result` in tuple element 1 that must be used
   --> chunk_reads/src/main.rs:255:27
    |
255 |               Some(s) => {s.finish();}
    |                           ^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: this `Result` may be an `Err` variant, which should be handled

Packages calling this will not compile unless this is added above the "struct". As a workaround, this will allow it to compile with a warning, although error handling would be ideal.
#[allow(unused_must_use)]


store data in dropdown filters

Stored data from QList<QList<QString>> list in dropdown filters for further improvement.


Renters ignore HostExternalSettings.SectorSize

This field of host settings is assigned to modules.SectorSize. I guess there is a plan to let hosts to modify this value in future (currently there is no such a way so host uses modules.SectorSize). But renters also use modules.SectorSize instead of the value from HostExternalSettings:
$ git grep -w SectorSize modules/renter | grep -v modules.SectorSize
$

This means old renters will be incompatible with new hosts when hosts implement changing this value. Old renters will continue to use modules.SectorSize instead of the value provided by the host.

At this time we don't plan to support sector sizes other than 4MB, at least in the near future.


fix dayjs i18n

resolve #754
This bug should be brought by PR #677 which changed all 'zh-CN' to 'zh' limit the available languages to 'zh' and 'en', but dayjs doesn't have a 'zh' locale name, it should be 'zh-cn'.
Effect:

Hi @breeswish , the root cause of this bug is that the PR #677 limit the available languages to 'zh' and 'en' by whitelist: ['zh', 'en'] option, but for dayjs, we only import the 'en' and 'zh-cn' locales for it, but we don't import 'zh' locale for it.
So I just found a new and simpler solution, and it works fine after trying. Just need to change one line code, to import 'zh' locale instead of 'zh-cn' locale for dayjs. (I checked 'zh' locale and 'zh-cn' locale are exactly same except the name).
- import 'dayjs/locale/zh-cn'
+ import 'dayjs/locale/zh'

How about this?
I don't think currently we need to support 'zh-TW' etc languages for dayjs. Because if we want to support this, we need to import an extra 'dayjs/locale/zh-tw' for it, but we don't prepare any other zh-TW.yml, it makes no much sense.


ccls.xref fails

What did you expect to happen?
In C mode the code lens that shows the refs should list all the references when clicked on.
What actually happened?
Instead, it throws an error:
LSP :: workspace/executeCommand' with ccls.xref' failed.
(wrong-type-argument json-value-p ccls.xref)
Describe your attempts to resolve the issue
I have removed the line from modules/lang/cc/config.el as advised
;; :hook (lsp-lens-mode . ccls-code-lens-mode)
and i correctly get one lens but it crashes as mensioned.
Steps to reproduce
I have enabled lsp
I have enabled cc +lsp
I have removed the problematic line from modules/lang/cc/config.el
System Information
https://pastebin.com/2a9ZBPrw

The bug seems to be in emacs-ccls:
https://github.com/emacs-lsp/emacs-ccls/pull/108
This pull-request fixed it for me


SIGSEGV while debugging program

While i debugging i get message about reconnect and after that i get SIGSEGV
The problem is that connection.socket is set to nil during write. From my pointview - closing socket cannot set connection.socket to nil.
LOG:
2018/09/13 11:30:11 [info] connection (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) reconnected 2018/09/13 11:30:14 [info] closing the connection (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) to event store... ' 2018/09/13 11:30:14 [error] connection (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) closed 2018/09/13 11:30:14 [info] connecting (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) to event store... 2018/09/13 11:30:16 [info] successfully connected to event store on <IP_ADDRESS>:1113 (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) 2018/09/13 11:30:16 [info] connection (id: b775ac4d-13da-470e-9e86-c3a46cd07a7f) reconnected panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x863ac6] goroutine 57 [running]: github.com/pgermishuys/goes/eventstore.(*TCPPackage).write(0xc4201e7768, 0xc4200c6500, 0x0, 0x0) 	/home/krz/gocode/src/github.com/pgermishuys/goes/eventstore/tcppackage.go:86 +0x466 github.com/pgermishuys/goes/eventstore.sendPackage(0x200000000, 0xc420204290, 0x10, 0x10, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...) 	/home/krz/gocode/src/github.com/pgermishuys/goes/eventstore/connection.go:232 +0xf3 created by github.com/pgermishuys/goes/eventstore.readFromSocket 	/home/krz/gocode/src/github.com/pgermishuys/goes/eventstore/connection.go:201 +0xb6b

@jkralik are you still using this client? if so, in what capacity?

Hi. No we are not using it. We implemeted our cqrs library https://github.com/go-ocf/cqrs


Key Error in get_membership (v0.7.0)

I got this error (some infos redacted):
INFO: Found 64291 users
WARNING: Could not resolve SID: S-1-5-21-XXXXXXXXXXXXXXXXX-44658
...
Traceback (most recent call last):
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 57, in get_membership
    resolved_entry = self.addomain.users[member]
KeyError: 'CN=RTCComponentUniversalServices,CN=Users,DC=root,DC=XXXXXX,DC=de'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 61, in get_membership
    resolved_entry = self.addomain.groups[member]
KeyError: 'CN=RTCComponentUniversalServices,CN=Users,DC=root,DC=XXXXX,DC=de'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 65, in get_membership
    entry = self.addomain.computers[member]
KeyError: 'CN=RTCComponentUniversalServices,CN=Users,DC=root,DC=XXXXX,DC=de'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/ldap3/strategy/base.py", line 823, in sending
    self.connection.socket.sendall(encoded_message)
ConnectionResetError: [Errno 104] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/avollmer/.local/bin/bloodhound-python", line 10, in <module>
    sys.exit(main())
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/__init__.py", line 265, in main
    disable_pooling=args.disable_pooling)
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/__init__.py", line 71, in run
    membership_enum.enumerate_memberships()
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 294, in enumerate_memberships
    self.enumerate_groups()
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 255, in enumerate_groups
    resolved_member = self.get_membership(member)
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py", line 70, in get_membership
    qobject = self.addomain.objectresolver.resolve_distinguishedname(member, use_gc=use_gc)
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/objectresolver.py", line 58, in resolve_distinguishedname
    distinguishedname = self.addc.ldap_get_single(distinguishedname, use_gc=use_gc, use_resolver=True)
  File "/home/avollmer/.local/lib/python3.7/site-packages/bloodhound/ad/domain.py", line 163, in ldap_get_single
    generator=False)
  File "/usr/lib/python3/dist-packages/ldap3/extend/__init__.py", line 125, in paged_search
    paged_criticality)
  File "/usr/lib/python3/dist-packages/ldap3/extend/standard/PagedSearch.py", line 121, in paged_search_accumulator
    paged_criticality):
  File "/usr/lib/python3/dist-packages/ldap3/extend/standard/PagedSearch.py", line 64, in paged_search_generator
    None if cookie is True else cookie)
  File "/usr/lib/python3/dist-packages/ldap3/core/connection.py", line 782, in search
    response = self.post_send_search(self.send('searchRequest', request, controls))
  File "/usr/lib/python3/dist-packages/ldap3/strategy/base.py", line 299, in send
    self.sending(ldap_message)
  File "/usr/lib/python3/dist-packages/ldap3/strategy/base.py", line 834, in sending
    raise communication_exception_factory(LDAPSocketSendError, type(e)(str(e)))(self.connection.last_error)
ldap3.core.exceptions.LDAPSocketSendError: socket sending error[Errno 104] Connection reset by peer

This appears to have fixed it, but I'm not sure if this is a proper solution:
--- /home/avollmer/.local/lib/python3.7/site-packages/bloodhound/enumeration/memberships.py	2020-04-06 16:36:59.196000000 +0200
+++ memberships.py	2020-04-06 17:25:08.540000000 +0200
@@ -252,10 +252,7 @@
                 group['Properties']['description'] = ADUtils.get_entry_property(entry, 'description')

             for member in entry['attributes']['member']:
-                try:
-                    resolved_member = self.get_membership(member)
-                except KeyError:
-                    resolved_member = None
+                resolved_member = self.get_membership(member)
                 if resolved_member:
                     group['Members'].append(resolved_member)

The KeyError is intentional, however the underlying problem is that the connection with the LDAP server was reset during operation. This is not intentional and some better error handling is needed here. The positive thing is that there's a good chance collection will run fine if you try it again.

Ah, so the patch didn't really do anything and I just got lucky when I ran it a second time.

I'll put this on the backlog but close this one as it's not really descriptive of the actual problem.


Remove filter direction attributes

by definition multiply in freq domain by complex response to go from units_in to units_out
remove channel response filter by dividing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d5d6891) 83.66% compared to head (d6e917e) 83.72%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                Coverage Diff                @@
##           fix_issue_173     #181      +/-   ##
=================================================
+ Coverage          83.66%   83.72%   +0.05%
=================================================
  Files                270      270
  Lines              20072    20019      -53
=================================================
- Hits               16793    16760      -33
+ Misses              3279     3259      -20

Flag
Coverage Δ

tests
83.72% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add community deploy

Signed-off-by: Hanqiu Zhang<EMAIL_ADDRESS>

Makefile target should need update for this


Python Substring: infine loop using ruff v0.1.2

Using ruff v0.1.2 and ruff-pre-commit v0.1.2, pre-commit fails with:
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

error: Failed to converge after 100 iterations.

This indicates a bug in Ruff. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BInfinite%20loop%5D

...quoting the contents of `my/service/folder/api_v0/router.py`, the rule codes E231, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

my/service/folder/api_v0/router.py:215:106: E231 Missing whitespace after ':'
Found 101 errors (100 fixed, 1 remaining).

The code is pretty straightforward:
from sqlalchemy.orm import DeclarativeBase

class Base(DeclarativeBase):
    pass

class MyClass(Base):
    file_uri: Mapped[str] = mapped_column(
        String(1024),
        nullable=False,
    )

...

def my_function(snapshot: MyClass):
    assert snapshot.file_uri is not None, f'Run "{req.run_id}" does not have a snapshot file.'
    snapshot_path = snapshot.file_uri[len(f's3://{self.s3_bucket_name}/'):]

Here my pyproject.toml settings:

[tool.mypy]
warn_return_any = true
warn_unused_configs = true

plugins = ["pydantic.mypy"]

# follow_imports = "silent"
warn_redundant_casts = true
warn_unused_ignores = true
disallow_any_generics = true
check_untyped_defs = true
no_implicit_reexport = true

# for strict mypy: (this is the tricky one :-))
disallow_untyped_defs = true

[tool.pydantic-mypy]
init_forbid_extra = true
init_typed = true

[tool.coverage.run]
branch = true
omit = [".devenv/*", "stages/*", "tests/*", ".venv/*"]

[tool.coverage.report]

[tool.coverage.xml]
output = "cov.xml"

[tool.ruff]
# Enable Pyflakes and pycodestyle rules.
select = ["E", "F"]
# select = ["ALL"]
preview = true

# Never enforce `E501` (line length violations).
ignore = ["E501"]

# Always autofix, but never try to fix `F401` (unused imports).
fix = true
unfixable = ["F401"]

[tool.ruff.per-file-ignores]
# "__init__.py" = ["E402"]

It works when I set:
    snapshot_path = snapshot.file_uri[len(f's3://{self.s3_bucket_name}/'): len(snapshot.file_uri)]

but still, it wants a space between the first and the second length :/

Thank you for filing!

This is my simplified pyproject.toml, I don't know if it works for everywhere. Interestingly, I need to run Ruff in the directory where the Python file is located to trigger the issue.
E231 and E202 need to be selected at the same time, otherwise the problem does not seem to occur.
[tool.ruff]
select = ["E231","E202"]
preview = true
fix = true

(I think flagging those errors in the first place is incorrect -- pycodestyle doesn't.)


turn TODOs and FIXMEs into issues

Since this is a potentially never ending issue and more like a development guideline, I would suggest to close this issue. It is partially addressed by specific issues referencing some of these todos (for access control for example)


Don't rely on hardcoded library names

Attempts to solve #10 by using the Plex search instead of hardcoded library names.
Can test with
docker run --rm ghcr.io/pjnes/cmcucp:library-fix PLEX_USER PLEX_PASS PLEX_SERVER [PLEX_PLAYLIST]

Thank you, works great! And a brilliant solution as it supports multiple library’s as well!
However, now that the library’s are found and things are actually being added I spotted another peculiar issue concerning the tv shows matching. I don’t know if this is a localization problem in Plex metadata or if it’s something else but the titles of newer shows like Falcon and WandaVision are not prepended with “Marvel’s” in my library and therefore they are not matched by the script. Shows like The Defenders and Agents of SHIELD are however prepended with Marvel’s and are added as expected. I tried a lazy fix and commented out the renaming on line 40 (show = "Marvel's %(show)s" % {'show': show}) and that actually worked, all four shows being matched and added. Now, I don’t know if there’s a specific reason to prepend Marvel’s to all the titles, maybe some shows get mixed up in the matching with other, non marvel series or something. If that’s the case maybe an acceptable solution could be to try match “Marvel’s %(show)s” first and if that fails attempt to match only “show” before throwing the no match error.
Cheers!

This works great!