Deprecate Pulse package and dependencies

Summary
This PR deprecates the Pulse package and any non-pulse package code within Qiskit that uses it.
Closes #13063
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

160 of 166 (96.39%)  changed or added relevant lines in 51 files are covered.
825 unchanged lines in 28 files lost coverage.
Overall coverage decreased (-0.1%) to 88.788%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/providers/fake_provider/utils/backend_converter.py
0
2
0.0%

qiskit/visualization/pulse_v2/plotters/base_plotter.py
0
2
0.0%

qiskit/visualization/pulse_v2/plotters/matplotlib.py
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

qiskit/providers/fake_provider/utils/backend_converter.py
1
0.0%

qiskit/pulse/instructions/directives.py
1
97.44%

qiskit/pulse/transforms/alignments.py
1
96.6%

qiskit/qasm3/init.py
1
95.0%

qiskit/visualization/pulse_v2/plotters/matplotlib.py
1
0.0%

qiskit/visualization/pulse_v2/plotters/base_plotter.py
1
0.0%

qiskit/circuit/library/pauli_evolution.py
2
96.15%

qiskit/scheduler/sequence.py
2
95.74%

qiskit/transpiler/passes/synthesis/unitary_synthesis.py
2
88.26%

qiskit/primitives/containers/data_bin.py
2
96.36%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.1%

Covered Lines:
73637

Relevant Lines:
82936

💛  - Coveralls

I think this PR is ready for review now as it contains all the deprecations, unit-test assertions, warning filtering and release notes I thought we should have for deprecating the pulse package. A couple notes worth highlighting and getting feedback on:

I've introduced a few deprecation decorators, specifically for pulse, located in qiskit.utils.deprecate_pulse.py. The aim of these decorators is to reuse deprecations messages and overall reduce code clutter due to the deprecation code in many places.
For unit test classes which interact heavily with pulse (e.g. all test cases in test/python/pulse) I used a new class level decorator which is used to suppress all deprecation warnings issued by pulse classes and methods. Same goes for calibration builder passes.
warnings.catch_warnings is used in several places which are called in common workflows such as transpile and working with Target. The motivation being is to prevent pulse-related deprecation from being emitted in cases where the user code does not call deprecated pulse APIs directly.

Here is the result of a performance comparison of Qiskit benchmarks, showing only the change w.r.t the default ASV factor.  There isn't a clear trend and I'm curious about what these changes mean really. Anyway for now I think we should wait a bit until the PR is stable and then rerun this and decide whether or not it's worthwhile to dive into this in more detail.

Change
Before [54fe09b2]
After [f78a9574]
Ratio
Benchmark (Parameter)

-
138±0.7μs
106±0.5μs
0.77
circuit_construction.CircuitConstructionBench.time_circuit_copy(14, 8192)

-
1.68±0.07ms
1.05±0.04ms
0.63
circuit_construction.CliffordSynthesis.time_clifford_synthesis(10)

+
1.02±0.02ms
1.69±0.2ms
1.65
mapping_passes.PassBenchmarks.time_dense_layout(14, 1024)

+
3.62±0ms
3.99±0.03ms
1.1
mapping_passes.PassBenchmarks.time_layout_2q_distance(14, 1024)

+
1.15±0.01ms
1.27±0ms
1.1
mapping_passes.PassBenchmarks.time_layout_2q_distance(5, 1024)

+
471±1ms
525±0.5ms
1.12
passes.MultipleBasisPassBenchmarks.time_basis_translator(14, 1024, ['rx', 'ry', 'rz', 'r', 'rxx', 'id'])

+
667±3ms
748±2ms
1.12
passes.MultipleBasisPassBenchmarks.time_basis_translator(20, 1024, ['rx', 'ry', 'rz', 'r', 'rxx', 'id'])

+
158±0.4ms
174±0.1ms
1.1
passes.MultipleBasisPassBenchmarks.time_basis_translator(5, 1024, ['rx', 'ry', 'rz', 'r', 'rxx', 'id'])

+
312±2ms
344±6ms
1.1
quantum_info.RandomCliffordBench.time_random_clifford('5,1000')

-
16.3±0.4ms
5.60±0.4ms
0.34
quantum_volume.QuantumVolumeBenchmark.time_ibmq_backend_transpile(1, 'translator')

-
18.1±1ms
6.35±0.05ms
0.35
transpiler_benchmarks.TranspilerBenchSuite.time_single_gate_compile

+
54.9±0.9ms
77.6±6ms
1.41
transpiler_qualitative.TranspilerQualitativeBench.time_transpile_time_cnt3_5_180(0, 'sabre', 'sabre')

And regarding the benchmarks, I see what you mean, and in my experience the variability of the asv results is quite high, which makes certain improvements difficult to track (I have seen this with Unitary Synthesis, where the tests that didn't run it would also change quite a lot when benchmarking the PR).

The only missing point I think could be improved is my previous comment on adding a link to Qiskit Dynamics for the deprecated pulse dependencies.

Thanks @ElePT . I have implemented your suggestion already but haven't pushed it yet since I'm waiting for input from @nkanazawa1989 and @DanPuzzuoli regarding the exact dependencies which should be moved to Dynamics. Putting the list here so we can discuss in a wider forum if needed:
qiskit.compiler.schedule()
qiskit.compiler.sequence()
qiskit.scheduler.schedule_circuit()
qiskit.scheduler.sequence()
qiskit.scheduler.ScheduleConfig
qiskit.scheduler.methods.as_soon_as_possible()
qiskit.scheduler.methods.as_late_as_possible()
qiskit.visualization.pulse_v2.draw()


Redefinition of _CRT_SECURE_NO_WARNINGS macro

Hi!
There are several sources with #define _CRT_SECURE_NO_WARNINGS. I believe there should be #ifdef first for projects which have already defined the macro. In my case I get a lot of warnings because I defined the macro in my project settings to suppres GLFW warnings. I could workaround it, but I think that #ifdef would be better in any case.

Fixed in #804


New skins got added?

i dont have time to play csgo rn so I just wanted to know if the new skins got added to osiris till now or not?

Skins are pulled from game, so yes.


Release 1.3.0.Beta10

Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Dependency update
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Let's summarize PRs contained in this release @fedinskiy :-)

@michalvavrik we have release drafts to do that for us, no?

Okay, let see if it works. I always did it manually, thanks.

run tests

CI failure on the latest is due to https://github.com/quarkusio/quarkus/issues/32219


Add smooth scrolling

Add tailwind utility class scroll-smooth to <html> of index.html and and docs.html to enable smooth scrolling behaviour whenever an anchor is clicked.

WOW! that great. Thanks for your contribution.

There are some other known issues I found like anchored section hiding under header etc. I will raise a PR when I find time to fix them.

WOW! that great. Thanks for your contribution.

There are some other known issues I found like anchored section hiding under header etc. I will raise a PR when I find time to fix them.


Unable to download artifact(s): Artifact not found for name: .net-app

Tool version
Latest Main Branch Deployment
Describe the bug
When trying to deploy to app services we are see the below error
Run<EMAIL_ADDRESS>with:
name: .net-app
merge-multiple: false
repository: ######/AzureNamingTool
run-id:<PHONE_NUMBER>5
env:
AZURE_WEBAPP_PACKAGE_PATH: .
DOTNET_VERSION: 8.0.x
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: .net-app
Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md
Unable to download artifact(s): Artifact not found for name: .net-app
To Reproduce
Steps to reproduce the behavior:

Go to actions
Click on "Azure Naming Tool - Build and deploy to an Azure Web App"
Run workflow

Expected behavior
AzureNamingTool Deployed to app services
Screenshots

I'm having this same issue.

@MattDyson85  this is a duplicate of https://github.com/mspnp/AzureNamingTool/issues/115. If you update your deploy yml
actions/upload-artifact@v3
to
actions/upload-artifact@v4
it should work for you.

This change has been merged to the main branch, Please pull the latest version and it should build/deploy properly.

Bryan


xc7: cmake: add calculate_average_switch func to warning ignore list

This is to avoid VPR printing out tons of warnings related to "Inconsistent buffering of rr nodes .."
Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>Output example:
Warning 65: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1316 type: CHANX location: (7,2) <-> (9,2) track: 165 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 66: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1317 type: CHANX location: (7,2) <-> (9,2) track: 164 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 67: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1318 type: CHANX location: (7,2) <-> (9,2) track: 163 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 68: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1319 type: CHANX location: (7,2) <-> (9,2) track: 162 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 69: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1320 type: CHANX location: (7,2) <-> (9,2) track: 161 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 70: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1321 type: CHANX location: (7,2) <-> (9,2) track: 160 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 71: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1322 type: CHANX location: (7,2) <-> (9,2) track: 159 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 72: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1323 type: CHANX location: (7,2) <-> (9,2) track: 158 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 73: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1324 type: CHANX location: (7,2) <-> (9,2) track: 157 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 74: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1325 type: CHANX location: (7,2) <-> (9,2) track: 156 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)
Warning 75: Inconsitent buffering of children of rr node OUTPINFEED (RR node: 1326 type: CHANX location: (7,2) <-> (9,2) track: 155 len: 2 longline: 0 seg_type: OUTPINFEED dir: BI_DIR capacity: 1)

This goes for ~1000 lines more

In the long run, we need to actually need to fix this warning, because it's an error in upstream VTR.  See here: https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/d521ee3e24da7e30c8d45f4cef1fbc3de545e167/vpr/src/route/rr_graph_indexed_data.cpp#L390-L391

because it's an error in upstream VTR

Is this captured in some issue? Otherwise, we might lose track of this one.


[MenuList] Divider inside MenuList is keyboard-focusable

When keyboard navigation using ArrowUp and ArrowDown keys is used in MenuList (or Menu), Divider elements get focused (with an outline indication) as if they were list items.

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Dividers are ignored during keyboard navigation of MenuLists
Current Behavior 😯

Dividers receive focus and are highlighted during keyboard navigation of MenuLists.
Steps to Reproduce 🕹

Link: https://jsfiddle.net/2c60vpoy/

Click on Item1 so that it has the keyboard focus
Press the ArrowDown key twice on the keyboard
Observe the Divider being focused

Context 🔦

Trying to use Divider to separate groups of menu items in a Menu.
Your Environment 🌎

Tech
Version

Material-UI
v3.9.2

React
16.8.4

Browser
any

@ignitenet-martynas Correct, I'm closing for #13708.

Apologies, no idea how I missed the existing issue.


⚠ Bofrost.lu has degraded performance

In b87c555, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1183 ms

Resolved: Bofrost.lu performance has improved in 883c2a9 after 14 minutes.


Cannot set fields to null with GraphQL

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
7.6.26
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
api
Amplify Commands
codegen
Describe the bug
Easy to spot with very bad consequences:
The VTL resolvers generated for updating a model do not contain nullable fields for an auth rule unless the delete operation is present. This means that these fields will throw an unauthorized error when trying to set them to null.
For example:
{
allow: owner
ownerField: "assigner"
operations: [create, read, update]
}
{ allow: owner, ownerField: "assignee", operations: [update] }
{ allow: groups, groups: ["Admin"], operations: [update, delete] }
{ allow: groups, groups: ["Management"], operations: [update] }
{ allow: private, operations: [read] }
These rules allow update (setting optional fields to null) only for the Admin role.
Expected behavior
It should be possible to set optional fields to null when update operation is specified.
Reproduction steps

Create a model with an auth rule, that has update but not delete
Since the resolvers are wrongly generated, it isn't possible to set the optional fields of the model to null

GraphQL schema(s)

# Put schemas below this line

type Task implements Deletable
  @model
  @auth(
    rules: [
      {
        allow: owner
        ownerField: "assigner"
        operations: [create, read, update]
      }
      { allow: owner, ownerField: "assignee", operations: [update] }
      { allow: groups, groups: ["Admin"], operations: [update, delete] }
      { allow: groups, groups: ["Management"], operations: [update] }
      { allow: private, operations: [read, delete] } #! SHOULD REMOVE DELETE, IS USED ONLY FOR AN AMPLIFY CLI BUG
    ]
  ) {
  id: ID!
  deletedAt: AWSDateTime @index(name: "byDeleted")
  assigner: String
  assignee: String! @index(name: "byAssignee")
  startDateTime: AWSDateTime!
  endDateTime: AWSDateTime!
  travelDuration: String
  returnDuration: String
  modality: ModalityName!
  location: LocationName
  moved: Int @default(value: "0")
  placeInfo: Place
  review: Review
  outcome: OutcomeName @index(name: "byOutcome")
  outcomeMotivation: String @index(name: "byOutcomeMotivation")
  suggestedOutcomeMotivation: String
  activityTasksId: ID!
  identityTasksId: ID!
  children: [Task!] @hasMany
}

Log output

# Put your logs below this line

Additional information
No response

I believe the VTL template should be written so nullification and Delete Operation are not the same. Delete should be able to delete an item from a table, and nullification should be part of an update, not the same thing.
This might sound drastic, but I would remove nullAllowedFields from VTL auth templates.

@IsaacTrevino agreed 100%. This is so bizarre. Having to re-write all my auth rules to include "delete", ie:
{ allow: groups, groups: ["Admins"], operations: [read, update, create, delete] }
Even though we explicitly remove the delete mutation via:
@model(mutations: { update: "updateEvent", create: "createEvent" })


Add notifications for new messages and load command to fetch 10 latest messages in a group/user thread and update README.md

In this merge a native notification can be shown to the user whenever a new message arrives.
This is achieved using the node-notifier package Node Notifier.
The user can also load his latest 10 messages from a group/user thread and simply continue sending messages using the command.
load: groupname/username

The README.md file is also updated to reflect the above mentioned changes

I'll take a closer look at this in a bit, but this looks like a cool addition.
I have a couple questions though, if you wouldn't mind answering them.
What exactly is the cross-platform behavior of this package? Do different options have to be specified per-platform, or is it handled automatically? What is the fallback if there is no supported notification system? Will it crash?
Thanks for the contribution!

I'll take a closer look at this in a bit, but it looks like a cool addition.
I have a couple questions though, if you wouldn't mind answering them.
What exactly is the cross-platform behavior of this package? Do different options have to be specified per-platform, or is it handled automatically? What is the fallback if there is no supported notification system? Will it crash?
Thanks for the contribution!

tq for ur reply, the node-notifier will change its behavior according to
the platforms automatically. ie in windows 10 it will use notification
center and in windows 8.1 and lower it will use the notification balloon
and in ubuntu it will use the default notification bar. Thus u can see it
covers most of the platforms and if none is supported then it wont show
anything.
On Mon, Oct 2, 2017 at 6:52 PM, Cameron Bernhardt<EMAIL_ADDRESS>wrote:

I'll take a closer look at this in a bit, but it looks like a cool
addition.
I have a couple questions though, if you wouldn't mind answering them.
What exactly is the cross-platform behavior of this package? Do different
options have to be specified per-platform, or is it handled automatically?
What is the fallback if there is no supported notification system? Will it
crash?
Thanks for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AstroCB/Messenger-CLI/pull/1#issuecomment-333532607,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOu4gOV-vZoJOKti1JG3OLXR_XTdjknyks5soOOagaJpZM4PqO94
.

--
Thumbs up,
Ameer Jhan
"Lets wave our flag..."

Hey there did you had a look at my contribution?

These changes look good; I'll probably make some revisions later, but thanks for the pull request!

Thank You, yup you can improve it the way you want!! :)


Insecure default for private setting with github_repository resource

The github_repository resource currently makes new repositories public by default, and requires you to specify that you want it private. This is a poor choice from a security perspective, especially considering this resource only works with organizations.
I posit that most users of this Terraform provider are private companies with private codebases, with a majority of their repositories being private ones with sensitive IP that would be damaging if exposed to the web. In consideration of this, this resource has an insecure default that should be deprecated and inverted. The private setting should default to true instead of false, or maybe we should deprecate the usage of private altogether in favor of public = true so that it's even more obvious that you're exposing the repo to the world. I am happy to contribute either of these changes if Hashicorp agrees.
Terraform Version
N/A
Affected Resource(s)
Please list the resources as a list, for example:

github_repository

Terraform Configuration Files
resource "github_repository" "super_secret_stuff" {
  name        = "example"
  description = "My org's crown jewels"

  template {
    owner = "github"
    repository = "terraform-module-template"
  }
}

Expected Behavior
Repository should be created as private by default
Actual Behavior
Repository is created as public by default

While I am a fan of "secure by default" this also means deviating from the upstream default: https://developer.github.com/v3/repos/#parameters-5.
If you work for an organization I recommend that you never use github_repository anywhere outside your companies module where you can specify your own sane/safe/secure defaults. The reality is that Github is used more for open than closed source and I think that is something we should weigh here.

A compromise here may be to remove the public /private configuration options in favour of a required visibility option that has no default.
I like the idea above about wrapping this provider with modules to smooth out the interface. We could make modules geared towards the different use cases of this provider and publish them to the Terraform Registry.


[Bug]: When executing a DLM task periodically, the status changes to Completed, resulting in no disable button.

ODC version
ODC422
OB version
independent
What happened?
When executing a DLM task periodically, the status changes to Completed, resulting in no disable button.

What did you expect to happen?
normally
How can we reproduce it (as minimally and precisely as possible)?
Create periodic execution tasks
Anything else we need to know?
No response
Cloud
No response

pass


unused global constants in convert.go

In convert.go we have some consts that are not used anywhere, for e.g. ConvertSource and ConvertBuildConfig. This needs a cleanup.

I would like pick it up


Double and single quotes consistency

Hi,
It seems to be single quotes for all snippets except for the bdd-snippets (https://github.com/extrabacon/atom-turbo-javascript/blob/master/snippets/bdd.cson#L5). I believe that the snippets for bdd should be updated to use single quotes.
This will affect #26.

Seconded, and even better it would be great to have a setting to chose between single and double quotes.

Published in version 1.2.0.


fix(eslint-plugin): handle first argument reference edge case

fixes #4450

@TkDodo I think it's another flaky test

Codecov Report
Base: 96.36% // Head: 92.46% // Decreases project coverage by -3.90% :warning:

Coverage data is based on head (18c4955) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4451      +/-   ##
==========================================
- Coverage   96.36%   92.46%   -3.91%
==========================================
  Files          45       88      +43
  Lines        2281     3568    +1287
  Branches      640      922     +282
==========================================
+ Hits         2198     3299    +1101
- Misses         80      253     +173
- Partials        3       16      +13

Impacted Files
Coverage Δ

src/core/mutation.ts

src/devtools/devtools.tsx

src/react/useQuery.ts

src/core/query.ts

src/core/onlineManager.ts

src/react/setBatchUpdatesFn.ts

src/devtools/styledComponents.ts

src/react/QueryErrorResetBoundary.tsx

src/core/queryClient.ts

src/core/utils.ts

... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


v5.14.15

[x] I have followed (at least) the PR section of the contributing guide.

PR for v5.14.15 release

Make sure to update to latest master and check the versions, there are already some conflicts.


编译出错

Configuring ppp-mod-pppoe.

check_conflicts_for: The following packages conflict with sagernet-core:
check_conflicts_for: 	v2ray-core * check_conflicts_for: 	xray-core *
opkg_install_cmd: Cannot install package luci-app-ssr-plus.
check_conflicts_for: The following packages conflict with sagernet-core:
check_conflicts_for: 	v2ray-core * check_conflicts_for: 	xray-core *
opkg_install_cmd: Cannot install package sagernet-core.
make[2]: *** [package/Makefile:70: package/install] Error 255
make[1]: *** [package/Makefile:111: /workdir/openwrt/staging_dir/target-x86_64_musl/stamp/.package_install] Error 2
make[2]: Leaving directory '/workdir/openwrt'
make[1]: Leaving directory '/workdir/openwrt'
make: *** [/workdir/openwrt/include/toplevel.mk:230: world] Error 2
Error: Process completed with exit code 2.

编译出错，源码没改动

已经修复


save password

Add dotenv-rails gem this gem is particularly useful when deploying applications to different environments, ensuring that sensitive information remains secure and that configurations can be easily managed across various deployment scenarios.
I used .env to add DEVISE_JWT_SECRET_KEY in.
update database delete column password from user table

Please try to clone it again


Feature/issue 322/add r lang support

I think I've done everything necessary to add support - let me know if I've missed anything. It successfully passes the new test 😁

Thank you 🏆


Livestreaming and stream viewing in the desktop app

Is your feature request related to a problem? Please describe.
Cannot create, view or engage in livestreams in the desktop application.

This is an odysee only feature.


Set XML report name to be the module name

What is your use-case and why do you need this feature?
Currently, the XML coverage report generated by Kover, when using the default engine, has its name set to Intellij Coverage Report, ie:
<report name="Intellij Coverage Report">

When using JaCoCo, the name is set to the module's name (for example :app).
Would it be possible to have the same behaviour for both engines? The report name may be used by other tools, for example https://github.com/marketplace/actions/jacoco-report. Having a unique/identifiable name for each report may then be useful.
Describe the solution you'd like
It would be great if Kover's default engine could use the module's name for the report name, instead of Intellij Coverage Report.

Thanks for the idea!

@shanshin I'll need to extend com.intellij.rt.coverage.report.api.ReportApi#xmlReport with title parameter

I see that you already included the new title parameter @zuevmaxim, thank you 🙂
@shanshin once the changes mentioned above in intellij-coverage are released, are you open for external contributor to add the title parameter in Kover?

Implemented in 0.7.6

Thanks for the quick release @shanshin!
I just updated to Kover 0.7.6, and it appears to be working fine 👍🏻


Add options for other open-ai models

I tried testing out agency-swarm via the collab notebook but I ran into an error. This might be as a result of not having access to gpt-4-1106-preview models

BadRequestError                           Traceback (most recent call last)
 in <cell line: 3>()
1 from agency_swarm import Agency
2
----> 3 agency = Agency([
4     ceo,
5     [ceo, dev],
6 frames
/usr/local/lib/python3.10/dist-packages/openai/_base_client.py in _request(self, cast_to, options, remaining_retries, stream, stream_cls)
875             # to completion before attempting to access the response text.
876             err.response.read()
--> 877             raise self._make_status_error_from_response(err.response) from None
878         except httpx.TimeoutException as err:
879             if retries > 0:
BadRequestError: Error code: 400 - {'error': {'message': "The requested model 'gpt-4-1106-preview' does not exist.", 'type': 'invalid_request_error', 'param': 'model', 'code': 'model_not_found'}}

I checked the code. It is possible to pass the model to the agent constructor like this:
ceo = Agent(name="CEO",
description="Responsible for client communication, task planning and management.",
instructions=ceo_instructions, # can be a file like ./instructions.md
files_folder=None,
model="gpt-3.5-turbo-1106",
tools=[])

Yes, you can pass a model in the model parameter, if it is supported by assistants api. I will add docstrings soon


Fixed bug where changing image size in config wouldnt change anything…

…. Also Unet sometimes not loading
Tried to use in my project, but my images were 224x224. Even though config changed, the call to LEDPipeline did not include the updated image size, so default size of 512x512 was used instead, causing crash.
Also ensured self.unet was loaded with parameter for when it is called with one already built (needed to do to fix crash on windows 10 device)

Thanks for your kind contribution ~


Issue 800 added padding in bottom

Issue #800

Added padding in bottom so it's less covered by the overlay.

Good catch @smcmurtry 👍

@smcmurtry in IOS normally the bullet and the text are read together but looks like android doesn't follow that rule. I feel its redundant to swipe twice to get the content of each bullet. But I guess its a personal preference. I'll revert it back.

@smcmurtry when I was looking at your comment earlier, I could only see the still image. Now I can see the animation. That does seems weird. Locally it just reads the bullet and the text together. I will remove that

I don't think we actually want the accessible accessibilityRole="button" props on the Box component. The ButtonSingleLine component already has the accessibilityRole= "button" prop (ref). And touchable elements like the button have the accessible prop set to true by default.
Sorry I didn't catch this on my 1st review!

@smcmurtry the tag was added to the box so the focus would go to both the button and the padding below the button so talk back and Voiceover to scroll the button higher up so its not covered by the overly. Otherwise it will not scroll enough for the button to not be under the overlay.

Can the bottom of these pages have some additional padding added to help with the issue?

My original comment was to see if we could add to the bottom of the pages.
I haven't checked out this PR but looks like padding was added to the button .
@amazingphilippe should comment before anything gets merged here.

Can the bottom of these pages have some additional padding added to help with the issue?

My original comment was to see if we could add to the bottom of the pages.
I haven't checked out this PR but looks like padding was added to the button .
@amazingphilippe should comment before anything gets merged here.

@timarney  The problem isn't with there not being enough padding in the bottom. The problem is that the screen reader doesn't see the overlay at the bottom. So as soon as the button is at the bottom of the page it stops scrolling which puts the button behind the overlay.

I don't know if button padding solves the issue in the most graceful way. Is there a way to make voiceover aware of the bottom fade? My worry is about the voiceover outline being larger than what it needs. Furthermore, voice over reads out the item, so I wouldn't worry about readability. @JuliannaR would there be a scenario where a user uses voice over, without listening to the voice? just for navigation?


Branch 1.0: Unhandled Exception: Parameter is not valid error on export

Settings installation path:
# EverQuest Installation Path
EverQuestDirectory = C:\Program Files (x86)\Steam\steamapps\common\Everquest F2P

Command Prompt output:
C:\LanternExtractor>lanternextractor neriaka

Unhandled Exception: System.ArgumentException: Parameter is not valid.
   at System.Drawing.Bitmap..ctor(Stream stream)
   at LanternExtractor.Infrastructure.ImageWriter.WriteImage(Stream bytes, String filePath, String fileName, ShaderType type)
   at LanternExtractor.EQ.Pfs.PfsArchive.WriteImage(Int32 index, ShaderType type, String folderName)
   at LanternExtractor.EQ.Pfs.PfsArchive.WriteAllFiles(Dictionary`2 textureTypes, String folderName, Boolean onlyTextures)
   at LanternExtractor.LanternExtractor.ExtractZoneFile(String shortName)
   at LanternExtractor.LanternExtractor.ExtractZone(String shortName)
   at LanternExtractor.LanternExtractor.Main(String[] args)

C:\LanternExtractor>

Output files:

This is caused by trying to extract newer zones. Some of the files are named as bitmaps but are actually .dds files. Will look into this in the future.


Module Warning (from ./node_modules/source-map-loader/dist/cjs.js): Failed to parse source map

Have used 'React Awesome Reveal' with React 17... no problems... works extremely well!
However, I have installed and tried to implement in current React 18 project and now receiving 100 errors in terminal... basically all reveal error types ...the following is an example:

WARNING in ./node_modules/react-awesome-reveal/dist/module.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '.../node_modules/react-awesome-reveal/dist/fadeIn.ts' file: Error: ENOENT: no such file or directory, open '.../node_modules/react-awesome-reveal/dist/fadeIn.ts'

Is 'React Awesome Reveal' not compatible with react 18 yet OR is there some other possible explanation that I am overlooking?
Thanks in advance for your prompt reply!
Andrew

React Awesome Reveal is fully compatible with React 18 starting from v4, this is not an issue related to React 18 support.
It seems your setup tries to read the source maps from an invalid path (source maps are shipped with the package), may you give me additional details?

OK ... my only main difference between my last project and this one is Material UI installed.
Dependancies include:
"@mui/icons-material": "^5.8.4",
"@mui/material": "^5.9.0",
"@mui/styled-engine-sc": "^5.8.0",
"react-awesome-reveal": "^4.0.1"

I installed 'react-awesome-reveal' via NPM ...npm install react-awesome-reveal
No errors on install shown!
In my component:

import { Fade } from 'react-awesome-reveal;

Wrapped 2 divs as shown(these are styled divs) :

  <Fade>
    <HeaderTitleText>Hello</HeaderTitleText>
    <HeaderTitleText1>World</HeaderTitleText1>
  </Fade>

The problem seems to be in the import phase... so if I comment out the import there are no errors
Any suggestions?

This issue persists on my end too, I've got 100 compile warnings from one import 😢

Same issue here.

I got the same issue andisaba presents.

same for you and I also use Material UI...

To anyone stopping by, I did this with react-app-rewired to neutralize the warning messages:
module.exports = {
  webpack: function (config, env) {
    return {
      ...config,
      stats: 'none',
      ignoreWarnings: [/Failed to parse source map/],
    };
  },
};

So I guess you are using create-react-app, it was not specified when the issue was opened. If I have time I will look into this, but it is not an issue with the lib itself.

Yes confirmed ...used create-react-app ...would be great if you could look into this and indicate a fix!
Ignoring warnings as indicated by 'fidaay' isn't addressing the underlying issue

I shared what I did, didn't indicate anything. In that way I can develop without seeing 100 warning messages.

Fixed in v4.1.0

Thanks for the fix... that's fantastic!
I'm keen to give it another go... fingers crossed!
Cheers!


Mixins: props are not correctly mixed in when registered globally

Vue.js version
2.0.2
Reproduction Link

https://github.com/thenickname/vue-global-mixin-bug
Steps to reproduce
Register a mixin with props globally:
Vue.mixin( {
  props : [ "myProp" ]
} );

Pass a prop value into any component:
<hello my-prop="foo"></hello>
What is Expected?
myProp becomes a prop of Hello.vue and the value of my-prop is "foo".
What is actually happening?
The value of my-prop is undefined
Notes

props are correctly mixed in if registered directly in the component using
mixins : [ { props : [ 'myProp' ] } ]
default values are passed correctly but will never change
clone the provided git repository and run npm run dev to see the bug

repo contains two components "Hello.vue" and "HelloWithLocalMixin.vue" that demonstrate the apparently buggy behavior
also see App.vue and main.js

The bug is back in v2.1.8

Then please open a new issue with a reproduction. Thanks! :)


Split_layer requires specialized batch handling

Current implementation of split layer is assuming fixed set of batch size, this needs to be handled in a flexible manner.

:octocat: cibot: Thank you for posting issue #1238. The person in charge will reply soon.

Yes, handling updating the batch size for the split layer after its init is NYI.

I'll make a simple patch plz review


AWS quickstart doesn't work without a Default VPC

The AWS quickstart example doesn't work for AWS accounts that do not have a default VPC (as t2 instances require a VPC). The example should be updated to include an awsx VPC.
https://pulumi.io/quickstart/aws/modify-program/

If we do this https://github.com/pulumi/docs/issues/1177, we won't need to modify the quickstart, fwiw, since it will no longer encounter this problem. We may want to fix up some of our examples, however (e.g. https://github.com/pulumi/examples/tree/master/aws-js-webserver).

I'm updating the AWS Get Started guide to use the approach suggested in #1177.
Keeping this open to track updating:

https://pulumi.io/reference/tutorials/aws/tutorial-ec2-webserver/
https://github.com/pulumi/examples/tree/master/aws-js-webserver
etc.

https://pulumi.io/reference/tutorials/aws/tutorial-ec2-webserver/

This now has a mention of the VPC requirement and a suggestion to use t1 is needed.


[Feature Request]: Allow ChatEngine to use async memory buffer?

Feature Description
The memory in ChatEngine can only be synchronous even in the async methods like (achat, achat_stream), for example this line in CondensePlusContextChatEngine.
Reason
I think it's common to have a chat memory backed by async DB calls, the current code stops people using async chat memory with chat engine without heavily customizing the chat engine.
Value of Feature
No response

Thanks! Appreciate the quick support on the request 🙏


Behaviour on non-leaf PTE's D/A/U bits

Hi,
In the section "Addressing and Memory Protection" of Privileged Architecture spec, I found this sentence below requiring the D/A/U bits to be cleared on non-leaf PTEs.

For non-leaf PTEs, the D, A, and U bits are reserved for future standard use and must be cleared by software for forward compatibility.

However in the follow section "Virtual Address Translation Process", the algorithm description ignored these bits. This leaves an apparent gap in how the implementation should do with regard to these non-leaf PTE bits. I notice the above sentence specifically mentioned software. Is this supposed to be a constraint to software only therefore not a hardware requirement? Am I right to assume that this is intended to be an implementation defined point?
Regards,
Freddie

"Reserved" is the key word here.  In general, using such an encoding results in UNSPECIFIED behavior.  The implementation might trap, or ignore the bits, or do any other thing that doesn't violate protection boundaries.
cc @gfavor @daniellustig: although the intent here is clear, I can't recall whether we've furnished the necessary priv-spec machinery to make my claim true.  Essentially, PTEs should behave like instruction opcodes w.r.t. reserved encodings, but we need to actually write that if we haven't.

I don't know if there's wording specifically defining "reserved" for priv.  The unpriv spec is clear that decoding a reserved instruction is UNSPECIFIED behavior, but I don't see similar language in the priv spec for cases like this.  (Entirely possible I'm just missing it.)  We should make sure this is clear both now and as RISC-V goes through its documentation overhaul.
FWIW the virtual-memory branch currently has this proposed change:

If $pte.v=0$, or if $pte.r=0$ and $pte.w=1$, or if any bits or encodings
that are reserved for future standard use are set within $pte$, stop and
raise a page-fault exception corresponding to the original access type.

https://github.com/riscv/riscv-isa-manual/pull/611/files#diff-1673d75098c5b339d06598ff6bb126f7a429d6bed61593e9b41092ee0587c9b9R1541
That's actually stricter than just calling it UNSPECIFIED.  We wrote that text with setting of the PTE reserved bits in mind.  Is it indeed true that seeing a PTE with reserved bits set should specifically trigger a page fault while setting D/A/U on a non-leaf PTE is UNSPECIFIED?

I don't see anything in the Priv spec defining what "reserved" means.
The DAU bits are described as "reserved for future standard use and must be cleared by software for forward compatibility".  The high Reserved bits probably would have said the same thing if the 1.11 spec had said anything, which it doesn't.
Since nothing was said for the Reserved bits, we added the explicit "trap on non-zero" statement to v1.12 to fill in that hole in the spec.  But it seems like that statement would be equally suitable for the DAU bits in v1.12.
One could say that v1.11 left all these bits to trap, be ignored, or ....  And v1.12 tightens this up to better ensure that v1.12 implementations will be forward compatible with future standard uses of these bits.  That seems like a desirable and worthwhile motivation for doing this tightening in v1.12.
So I propose also requiring a page fault on non-zero DAU bits in no-leaf PTEs.  Thoughts for or against?

Makes sense to me—but this should be listed as a technically incompatible change in the preface, since I agree with your interpretation that “reserved” by itself is a much weaker statement.

Dan, if you agree, can you add verbiage to the v1.12 tablewalk pseudocode for non-zero non-leaf DAU bits?  And add the "technically incompatible change" comment in the preface.

Works for me too.  I think the added (bolded) text in my previous comment covers this already then, but I'll add the note about this being a technically incompatible change to the preface.

#759 will address this.

Resolved via #759


Failing to compile on Go 1.9.2

i see following problem when i run on go 1.9.2. Looks like godog is somehow assuming 1.9.1
My go version
go version
go version go1.9.2 darwin/amd64

failed to compile testmain package:
/var/folders/0d/lbw05by930b_0mmdc780z28h0000gn/T/godog-1511694296932703000/_testmain.go:4:2: import /SomeLocation/go/pkg/darwin_amd64/someproject/vendor/github.com/DATA-DOG/godog.a: object is [darwin amd64 go1.9.2 X:framepointer] expected [darwin amd64 go1.9.1 X:framepointer]

Plz ignore somehow didnt realize that the godog command line is actually a different go get github.com/DATA-DOG/godog/cmd/godog and that was older version

close


Add SUPERSET_NO_DB_INIT

Setting this envvar to true disables the docker-init script.
This is required to set up a proper deploy inside Kubernetes.
Signed-off-by: Maartje Eyskens<EMAIL_ADDRESS>

Should we add this env var to the docs?
Maybe a new section inside Description:
## Description

blah blah

### Environment Variables

You can configure the docker image reads the following environment variables:

- blah blah

@smacker re-worked those changes a bit so I can just use the docker-init.sh in the Helm hooks

@carlosms sure! How about a table somehere like we did in https://github.com/src-d/terraform-provider-online#developing-the-provider?

A table would be perfect

@carlosms added a table with all envvars I knew about


TypeError: 'NoneType' object is not callable

I'm running the latest version of the code. During the training of s3dis data set, the following problems occurred at the end of the first epoch. I hope to seek help. Thank you.
2022-04-18 22:25:18,343 - INFO - Epoch [1/20][1020/1020]  lr: 0.004, eta: 7:57:16, mem: 3470, data_time: 0.65, iter_time: 0.94, semantic_loss: 0.4898, offset_loss: 0.7772, loss: 1.2671
2022-04-18 22:25:24,027 - INFO - Epoch [1/20][1020/1020]  lr: 0.004, eta: 7:56:36, mem: 3470, data_time: 0.00, iter_time: 0.19, semantic_loss: 0.3694, offset_loss: 0.6032, loss: 0.9726
2022-04-18 22:25:25,085 - INFO - Validation
0%|          | 0/68 [00:00<?, ?it/s]Traceback (most recent call last):
File "/home/zgj/SoftGroup-main/tools/train.py", line 94, in validate
result = model(batch)
TypeError: 'NoneType' object is not callable
0%|          | 0/68 [00:01<?, ?it/s]

Please change model = model.eval() to model.eval() and check if problem happens again?

Please change model = model.eval() to model.eval() and check if problem happens again?

This Works. You can close this  thread.


Newspaper pip install running each time i run the script

I just started to use your library but i have a problem with full article
from gnews import GNews
google_news = GNews(language='fr', country='FR', period='1d',max_results=2)
pakistan_news = google_news.get_news_by_topic('TECHNOLOGY')

for x in pakistan_news:
    article = google_news.get_full_article(pakistan_news[0]['url'])
    print(x)
    print(article.text )

by just adding the line 'article = google_news.get_full_article(pakistan_news[0]['url'])' the console is showing a pip install output. and this, each time the 'for loop' is running.
what can i do ?
thanks
eg of output :

python news.py
WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip.
Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue.
To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.
Requirement already satisfied: newspaper3k in c:\python311\lib\site-packages (0.2.8)
Requirement already satisfied: beautifulsoup4>=4.4.1 in c:\python311\lib\site-packages (from newspaper3k) (4.9.3)
Requirement already satisfied: Pillow>=3.3.0 in c:\python311\lib\site-packages (from newspaper3k) (9.4.0)
Requirement already satisfied: PyYAML>=3.11 in c:\python311\lib\site-packages (from newspaper3k) (6.0)
Requirement already satisfied: cssselect>=0.9.2 in c:\python311\lib\site-packages (from newspaper3k) (1.2.0)
Requirement already satisfied: lxml>=3.6.0 in c:\python311\lib\site-packages (from newspaper3k) (4.9.2)
Requirement already satisfied: nltk>=3.2.1 in c:\python311\lib\site-packages (from newspaper3k) (3.8.1)
Requirement already satisfied: requests>=2.10.0 in c:\python311\lib\site-packages (from newspaper3k) (2.26.0)
Requirement already satisfied: feedparser>=5.2.1 in c:\python311\lib\site-packages (from newspaper3k) (6.0.10)
Requirement already satisfied: tldextract>=2.0.1 in c:\python311\lib\site-packages (from newspaper3k) (3.4.0)
Requirement already satisfied: feedfinder2>=0.0.4 in c:\python311\lib\site-packages (from newspaper3k) (0.0.4)
Requirement already satisfied: jieba3k>=0.35.1 in c:\python311\lib\site-packages (from newspaper3k) (0.35.1)
Requirement already satisfied: python-dateutil>=2.5.3 in c:\python311\lib\site-packages (from newspaper3k) (2.8.2)
Requirement already satisfied: tinysegmenter==0.3 in c:\python311\lib\site-packages (from newspaper3k) (0.3)
Requirement already satisfied: soupsieve>1.2 in c:\python311\lib\site-packages (from beautifulsoup4>=4.4.1->newspaper3k) (2.4)
Requirement already satisfied: six in c:\python311\lib\site-packages (from feedfinder2>=0.0.4->newspaper3k) (1.12.0)
Requirement already satisfied: sgmllib3k in c:\python311\lib\site-packages (from feedparser>=5.2.1->newspaper3k) (1.0.0)
Requirement already satisfied: click in c:\python311\lib\site-packages (from nltk>=3.2.1->newspaper3k) (8.1.3)
Requirement already satisfied: joblib in c:\python311\lib\site-packages (from nltk>=3.2.1->newspaper3k) (1.2.0)
Requirement already satisfied: regex>=2021.8.3 in c:\python311\lib\site-packages (from nltk>=3.2.1->newspaper3k) (2023.3.23)
Requirement already satisfied: tqdm in c:\python311\lib\site-packages (from nltk>=3.2.1->newspaper3k) (4.64.1)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in c:\python311\lib\site-packages (from requests>=2.10.0->newspaper3k) (1.26.14)
Requirement already satisfied: certifi>=2017.4.17 in c:\python311\lib\site-packages (from requests>=2.10.0->newspaper3k) (2022.12.7)
Requirement already satisfied: charset-normalizer~=2.0.0 in c:\python311\lib\site-packages (from requests>=2.10.0->newspaper3k) (2.0.12)
Requirement already satisfied: idna<4,>=2.5 in c:\python311\lib\site-packages (from requests>=2.10.0->newspaper3k) (3.4)
Requirement already satisfied: requests-file>=1.4 in c:\python311\lib\site-packages (from tldextract>=2.0.1->newspaper3k) (1.5.1)
Requirement already satisfied: filelock>=3.0.8 in c:\python311\lib\site-packages (from tldextract>=2.0.1->newspaper3k) (3.11.0)
Requirement already satisfied: colorama in c:\python311\lib\site-packages (from click->nltk>=3.2.1->newspaper3k) (0.4.6)
{'title': "L'Allemagne dit adieu à ses dernières centrales nucléaires - Le Monde", 'description': "L'Allemagne dit adieu à ses dernières

in line 185 of gnews.py, in the get_full_article defenition, there is a check to see if you have newspaper3k installed, however, newspaper3k is misspelled as newspaper.


Pipe helper errors into normal text and json output

Helper errors (-k or -kk) are currently only visible on stderr.
Change that behavior to emit them to text output (-o) and in JSON
format.
This allows tools that process the JSON output to account for the
errors, similarly to lost perf events.
Checklist

[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

Fixed clang format and added a changelog entry.


Dependency Issues with Google Cloud Storage V1 on Visual Studio 2015

Hi,
We got through building our library which uses Google Cloud Storage V1 (pre release version) to connect to our Google Cloud Storage.
While going through the development, we realized that Google.Api.Gax.dll (<IP_ADDRESS>) is still looking for Google.Apis.Auth.PlatformServices.dll (<IP_ADDRESS>), even though the NuGet package manager downloads the <IP_ADDRESS> version of Google.Apis.Auth.PlatformServices.dll
This is forcing us to use binding redirects on our API's as a workaround since we don't have access to Google.Apis.Auth.PlatformServices.dll.
While this works ok for us in the short run, we would like to stay away from Binding Redirects on our API's.
Can you please suggest us a solution to this, or, provide us with an ETA of when the reference issue would be fixed on Google.Cloud.Storage.V1
Thank you in advance.

Fundamentally I suspect you need to make sure that binding redirects aren't a problem for you - because I expect they will be needed in the future.
For example, suppose we release Google.Cloud.Storage.V1 v1.0.0 with a dependency on Google.Apis.Storage.v1 v1.22, and Google.Api.Gax also uses Google.Apis.* v1.22. That's great temporarily - but at some point we may well need to use some feature in a later version of Google.Apis.Storage.v1 that will depend on Google.Apis.* v1.23. With everything following SemVer, that should be fine - all the Gax could should work perfectly well with Google.Apis.* v1.23, but obviously assembly binding redirects are required to satisfy the runtime.
We would not want to have to re-release Google.Api.Gax every time a library needed some new feature from another library which Google.Api.Gax depends on... this is precisely what assembly binding redirects are there for.
I'd expect this to all be transparent, with Visual Studio or the dotnet SDK simply doing the right thing for you - but expecting not to need binding redirects at all is unrealistic, IMO.

Closing for now, as I don't think there's any way to avoid this. Please feel free to add more comments of course.

Thanks for providing valuable input, we will continue using the binding redirects.


Question: High Availablity / Multiple Instances

Does BGPalerter support running multiple replicas with the same config and volume to more easily facilitate things like no-downtime rolling restarts and config changes, or does it only support one replica?

Hi @benyanke,
You can share the same config but not the same volume if you have persistStatus on (in that case the volume can be re-used but not written at the same time by multiple instances).
Changes to prefixes.yml are auto reloaded without restarts.


Add empty plugin version validation to PluginGroup Publishing Step

What this PR does / why we need it

Automatically trim any extra leading or trailing space from the plugin-group name and description if specified
Add validation to make sure plugins with empty plugin versions are not specified in the plugin group.

Which issue(s) this PR fixes

Fixes #
Describe testing done for PR

Note that the builder plugin will automatically trim any extra space in the plugin group name and description if specified.

$ tz plugin search
  NAME     DESCRIPTION             TARGET  LATEST
  builder  Build Tanzu components  global  v1.3.0-dev
  test     Test the CLI            global  v1.3.0-dev

When an empty version is specified for the builder plugin.

$ make inventory-plugin-group-add PLUGIN_GROUP_NAME_VERSION="  default:v0.0.4  " PLUGIN_GROUP_DESCRIPTION="   THIS IS A Test desc"
/Users/anujc/Documents/code/tanzu-cli/bin/builder inventory plugin-group add \
                --repository localhost:5001/test/v1/tanzu-cli/plugins \
                --plugin-inventory-image-tag latest \
                --publisher tanzucli \
                --vendor vmware \
                --manifest /Users/anujc/Documents/code/tanzu-cli/artifacts/plugins/plugin_group_manifest.yaml \
                --name default \
                --version v0.0.4 \
                --plugin-inventory-db-file "" \
                --description "THIS IS A Test desc" \

2024-02-29T12:28:15-08:00 [i] pulling plugin inventory database from: "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest"
Error: error while reading plugin group: invalid plugin version "" for plugin "builder", target "global". plugin version cannot be empty for plugin group.
2024-02-29T12:28:20-08:00 [x] : error while reading plugin group: invalid plugin version "" for plugin "builder", target "global". plugin version cannot be empty for plugin group.
make: *** [inventory-plugin-group-add] Error

When an invalid plugin version is specified which is not in the plugin-inventory database (existing)

$ make inventory-plugin-group-add PLUGIN_GROUP_NAME_VERSION="  default:v0.0.4  " PLUGIN_GROUP_DESCRIPTION="   THIS IS A Test desc"
/Users/anujc/Documents/code/tanzu-cli/bin/builder inventory plugin-group add \
                --repository localhost:5001/test/v1/tanzu-cli/plugins \
                --plugin-inventory-image-tag latest \
                --publisher tanzucli \
                --vendor vmware \
                --manifest /Users/anujc/Documents/code/tanzu-cli/artifacts/plugins/plugin_group_manifest.yaml \
                --name default \
                --version v0.0.4 \
                --plugin-inventory-db-file "" \
                --description "THIS IS A Test desc" \

2024-02-29T12:28:43-08:00 [i] pulling plugin inventory database from: "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest"
2024-02-29T12:28:43-08:00 [i] updating plugin inventory database with plugin group entry
Error: error while inserting plugin group 'default': specified plugin 'name:test', 'target:global', 'version:v2.3' is not present in the database
2024-02-29T12:28:43-08:00 [x] : error while inserting plugin group 'default': specified plugin 'name:test', 'target:global', 'version:v2.3' is not present in the database
make: *** [inventory-plugin-group-add] Error 1

When correct plugin version are specified in plugin-group.

$ make inventory-plugin-group-add PLUGIN_GROUP_NAME_VERSION="  default:v0.0.4  " PLUGIN_GROUP_DESCRIPTION="   THIS IS A Test desc"
/Users/anujc/Documents/code/tanzu-cli/bin/builder inventory plugin-group add \
                --repository localhost:5001/test/v1/tanzu-cli/plugins \
                --plugin-inventory-image-tag latest \
                --publisher tanzucli \
                --vendor vmware \
                --manifest /Users/anujc/Documents/code/tanzu-cli/artifacts/plugins/plugin_group_manifest.yaml \
                --name default \
                --version v0.0.4 \
                --plugin-inventory-db-file "" \
                --description "THIS IS A Test desc" \

2024-02-29T12:29:09-08:00 [i] pulling plugin inventory database from: "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest"
2024-02-29T12:29:09-08:00 [i] updating plugin inventory database with plugin group entry
2024-02-29T12:29:09-08:00 [i] publishing plugin inventory database
2024-02-29T12:29:09-08:00 [i] successfully published plugin inventory database at: "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest"

$ tz plugin group search
  GROUP                    DESCRIPTION          LATEST
  vmware-tanzucli/default  THIS IS A Test desc  v0.0.4

$ tz plugin group get vmware-tanzucli/default
Plugins in Group:  vmware-tanzucli/default:v0.0.4
  NAME     TARGET  VERSION
  builder  global  v1
  test     global  v1.3

Release note

Additional information
Special notes for your reviewer

LGTM with one nit
For completeness, I'll mention the manual tests. For the manual testing sections, notice from the printout that when you run make inventory-plugin-group-add PLUGIN_GROUP_NAME_VERSION=" default:v0.0.4 " PLUGIN_GROUP_DESCRIPTION=" THIS IS A Test desc" which adds extra spaces in the name, version and description, those spaces are not passed to the builder plugin by the Makefile, so this is not really a valid test. To test with spaces, you can put the variables before the make command: PLUGIN_GROUP_NAME_VERSION=" default:v0.0.4 " PLUGIN_GROUP_DESCRIPTION=" THIS IS A Test desc" make inventory-plugin-group-add
Also, in our publication pipelines we don't use PLUGIN_GROUP_NAME_VERSION but we use PLUGIN_GROUP_NAME and PLUGIN_GROUP_VERSION, so using those in the manual tests is better: PLUGIN_GROUP_NAME=" default " PLUGIN_GROUP_VERSION=" v0.0.4 " PLUGIN_GROUP_DESCRIPTION=" THIS IS A Test desc" make inventory-plugin-group-activate. I checked, it works 😄
And technically, to test appropriately, we need to use the Makefile that our publishing pipelines use, but I looked and they look the same, so we're good.

Thanks @marckhouzam for mentioning and even running the correct tests as part of the review. 😄


Fix contributing documentation link

Coverage remained the same at 12.09% when pulling 368f1da2785f2412422c8896903f56f75f950d18 on uranusjr:fix-readme-link into 349803db19c2d80f30c706cacd0faf17484195a5 on SublimeLinter:master.

Sorry, this slipped by while on holiday.
Thanks


A process that is consuming a significant amount of memory is running.

Hello, developers at InMobi,
While using your SDK, I've observed that even when there are no ad plays or calls, a thread named "ConfigBootstrapHandle" continues to occupy a considerable portion of memory. When advertising is invoked, the combined memory usage of the "TIM-ma" thread and the aforementioned thread becomes quite substantial. Given that our project is a game and we prioritize memory sensitivity, we've also noticed noticeable memory fluctuations. While these may not necessarily be caused by your SDK, we kindly request your assistance in investigating and optimizing this situation. We will also reach out to developers from other advertising platforms for further examination. Could you please take a look and provide optimization suggestions, or guide us on how to avoid this issue? Your support is much appreciated.
Thank you.
Here are some screenshots of my memory monitoring.

The SDK version I am using is 10.5.9


Add validate-format verb with placeholder for future validation

Wire up a validate-format verb that runs the format validation logic for a specified file. This is a hidden verb that I imagine being used during development, and in future by DRI to explore an SBOM or troubleshoot a validation failure. This change is just the boilerplate required to add and call the new verb; actual validation logic will be in the next PR.

Codecov Report
Attention: Patch coverage is 71.42857% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 58.72%. Comparing base (29bc8fb) to head (1f19b28).

Files
Patch %
Lines

src/Microsoft.Sbom.Api/Config/ConfigSanitizer.cs
56.25%
7 Missing :warning:

.../Microsoft.Sbom.Api/Config/ConfigurationBuilder.cs
0.00%
3 Missing :warning:

src/Microsoft.Sbom.Api/Config/SbomToolCmdRunner.cs
0.00%
3 Missing :warning:

...osoft.Sbom.Api/Config/Args/FormatValidationArgs.cs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   58.67%   58.72%   +0.05%
==========================================
  Files         253      254       +1
  Lines        7852     7901      +49
  Branches      920      924       +4
==========================================
+ Hits         4607     4640      +33
- Misses       2828     2844      +16
  Partials      417      417

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


--lock with no input requirements should resolve the whole lock

With this lockfile created via pex3 lock create ansicolors -o colors.lock --indent=2:
{
  "allow_builds": true,
  "allow_prereleases": false,
  "allow_wheels": true,
  "build_isolation": true,
  "constraints": [],
  "locked_resolves": [
    {
      "locked_requirements": [
        {
          "artifacts": [
            {
              "algorithm": "sha256",
              "hash": "00d2dde5a675579325902536738dd27e4fac1fd68f773fe36c21044eb559e187",
              "url": "https://files.pythonhosted.org/packages/53/18/a56e2fe47b259bb52201093a3a9d4a32014f9d85071ad07e9d60600890ca/ansicolors-1.1.8-py2.py3-none-any.whl"
            }
          ],
          "project_name": "ansicolors",
          "requires_dists": [],
          "requires_python": null,
          "version": "1.1.8"
        }
      ],
      "platform_tag": [
        "cp39",
        "cp39",
        "macosx_11_0_arm64"
      ]
    }
  ],
  "pex_version": "2.1.70",
  "prefer_older_binary": false,
  "requirements": [
    "ansicolors"
  ],
  "requires_python": [],
  "resolver_version": "pip-legacy-resolver",
  "style": "strict",
  "transitive": true,
  "use_pep517": null
}

I get this error:
❯ ../pex/dist/pex --lock colors.lock
Traceback (most recent call last):
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 503, in execute
    exit_value = self._wrap_coverage(self._wrap_profiling, self._execute)
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 408, in _wrap_coverage
    return runner(*args)
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 439, in _wrap_profiling
    return runner(*args)
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 559, in _execute
    return self.execute_entry(self._pex_info.entry_point)
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 695, in execute_entry
    return self.execute_pkg_resources(entry_point)
  File "/Users/ericarellano/.pex/unzipped_pexes/4bbee6e719f7c34181394d0293cbdafc19203558/.bootstrap/pex/pex.py", line 727, in execute_pkg_resources
    return runner()
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/bin/pex.py", line 724, in main
    do_main(
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/bin/pex.py", line 745, in do_main
    pex_builder = build_pex(
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/bin/pex.py", line 594, in build_pex
    resolve_from_lock(
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/resolve/lock_resolver.py", line 137, in resolve_from_lock
    resolve_result = locked_resolve.resolve(
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/resolve/locked_resolve.py", line 661, in resolve
    return Resolved.create(
  File "/Users/ericarellano/.pex/installed_wheels/b343f539fabf56dc5011ddc42b3cbcfc20790515/pex-2.1.70-py2.py3-none-any.whl/pex/resolve/locked_resolve.py", line 339, in create
    target_specificity=sum(target_specificities) / len(target_specificities),
ZeroDivisionError: division by zero

I believe this implies that downloadable_requirements is empty, so this for loop isn't executing, because the append is unconditional in the loop body:
https://github.com/pantsbuild/pex/blob/2f2c77227bbda4401054b6ca1b7677ef6a419ed2/pex/resolve/locked_resolve.py#L317-L342

This was due to me not understanding the right invocation. pex --lock colors.lock fails, but pex --lock colors.lock ansicolors works spendidly.
@jsirois would you consider a mode where you attempt to install the entire lock contents? That would help Pants out, we have the [python].run_against_entire_lockfile option, where Pants is not aware of what all the possible python_requirements are that were used to generate and it would be a slow calculation to do so.

Yes. That was actually intended / worked on. I think --pex-repository works this way now?.

I think --pex-repository works this way now?.

It looks like it.

$ pex --pex-repository=colors.pex -o colors.2.pex

--

That was actually intended / worked on

Would it help for me to pick that up?
(It might be a good exercise for me to better understand this code.)

I think "picking that up" == solving this issue!


BOP was just updated, and broke the BOP add-on for Dynamic Trees.

Install the latest version of BOP: "BiomesOPlenty-1.12.2-<IP_ADDRESS>2-universal.jar", install "DynamicTreesBOP-1.12.2-1.4.1e.jar", which is the latest.  Wait for the crash, specifically complaining that BOP 2422+ is supported, and misreports the version of BOP.

The 2443 update to BOP fixes the issue.


[Bug] Trying to enter my SP World with Mythic Metals installed causes a server disconnect error

Minecraft 1.21
Fabric Loader 0.16.0
Fabric API 0.100.7
Mythic Metals 0.20.0-alpha4
Ok, suuuuuper confused about this one. Now that the Alloy Forgery issue is fixed, I tried adding Mythic Metals to my modpack, and for some reason when I try to enter my Singleplayer World, I get a Network Protocol Error and get dumped back to the Multiplayer Server Selection Screen.
Crash Report (?):
https://mclo.gs/iIuagb8

Duplicate of #252. Update to 0.20.0-alpha5


Apply style programmatically

Hello,
I am trying to use ChatKit in one of my application that is server-based themable (colors come from the server). Thus I need to be able to change bubble colors (most notably) programmatically and not only through XML.
From what I see all "style" attributes and methods in MessagesList and MessagesListAdapter are private so I cannot manage my path through that even by extending those classes.
What is the proper way to do this?
Thanks,
Nicolas

In the end I needed much more so ended up doing custom holders and layouts :)


Local Pregenerated File Archive support

Probably low priority as a free account is perfectly serviceable, but still very future-proof.
Random Org provides daily pregenerated random data at https://archive.random.org/
Possibly, this data can be used to generate months if not years of RP random rolls with a single download, rather than rely on the API and risk the service not responding for some reason (site down, etc.) It would be great if we could use local random data instead of the Random.org service.

This can be added sometime in the future. Probably will pull in the historic data with the initial load of random numbers.

After lookin into it more, it appears that the Pregenerated File Archive format is intended for random integers not random floating point numbers. The data I'd receive could be any floating point number including invalid numbers. Scaling the integers down from int.MinValue -> int.MaxValue to 0.0 -> 1.0 could potentially cause some issues.
Due to that issue this feature won't be added.


Define KEDA readiness and liveness probes

KEDA should report it state/availability to the kubernetes cluster.

Duplicate of https://github.com/kedacore/keda/issues/237?

@tomkerkhove no, these are probes for the KEDA Operator deployment, to expose KEDA state to the cluster. #237 is talking about probes on the target deployment and scaling based on the probes there.

Oh I've missed that, fully agree on this one then!

Fixed in #792

Can we get some docs on this on https://keda.sh/docs/2.0/operate/?

I am not sure this is something worth documenting. Those probes exposes state of the Operator and Metrics Server Deployment toward kubernetes, eg. kubernetes scheduler knows when the Deployment is not available and should try to spin another pod.

Let's close since it's part of our YAML & chart?

@zroubalik @tomkerkhove Where can I see the Yamls and Chart? I want to see examples of liveness/readiness configuration.

@zroubalik @tomkerkhove Where can I see the Yamls and Chart? I want to see examples of liveness/readiness configuration.

Chart can be found here: https://github.com/kedacore/charts/tree/master/keda

Chart can be found here: https://github.com/kedacore/charts/tree/master/keda

@tomkerkhove I don't see there an example for scaledobject.yaml.
This is what I have from version 1.5.0. Should it tweaked to be compatible with v2.0.0?
`apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
name: lf-scaledobject-{{ .Values.tenantId }}
namespace: {{ .Values.lf_namespace }}
labels:
deploymentName: log-forwarding-{{ .Values.tenantId }}
spec:
scaleTargetRef:
deploymentName: log-forwarding-{{ .Values.tenantId }}
pollingInterval: 180
cooldownPeriod:  43200
minReplicaCount: 0
maxReplicaCount: 5
triggers:

type: gcp-pubsub
metadata:
subscriptionSize: "50"
subscriptionName: "lf-data-{{ .Values.tenantId }}-sub"
credentials: GENERIC_GOOGLE_CREDENTIALS`

@tomkerkhove I don't see there an example for scaledobject.yaml.
This is what I have from version 1.5.0. Should it tweaked to be compatible with v2.0.0?
`apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
name: lf-scaledobject-{{ .Values.tenantId }}
namespace: {{ .Values.lf_namespace }}
labels:
deploymentName: log-forwarding-{{ .Values.tenantId }}
spec:
scaleTargetRef:
deploymentName: log-forwarding-{{ .Values.tenantId }}
pollingInterval: 180
cooldownPeriod:  43200
minReplicaCount: 0
maxReplicaCount: 5
triggers:

type: gcp-pubsub
metadata:
subscriptionSize: "50"
subscriptionName: "lf-data-{{ .Values.tenantId }}-sub"
credentials: GENERIC_GOOGLE_CREDENTIALS`

The probes are for KEDA runtime, ScaledObject scales your workload, so you are in control of those probes.

The probes are for KEDA runtime, ScaledObject scales your workload, so you are in control of those probes.

Or maybe I'm not fully getting your question.

Or maybe I'm not fully getting your question.

You can refer Migration Guide https://keda.sh/docs/2.0/migration/

You can refer Migration Guide https://keda.sh/docs/2.0/migration/

Exactly what I needed :) Thanks!

Exactly what I needed :) Thanks!


cronjob trigger

What would you like to be added:
Is it possible to manual trigger job in cronjob view. Normally, I have to open a terminal to execute kubectl create job.
Why is this needed:
If we can trigger job more easy. I think that is good for testing.
Environment you are Lens application on:
Dev, QA, beta, Stage, Production

Kubernetes distribution: [EKS, AKS, GKE, Rancher, ...]
K8S, EKS
Desktop OS:
Mac Catalina

Every Kubernetes manangment tool as Dashboard, Octant, K9s have a trigger button to trigger a cronjob. This feature I think we will be interesting

That would be incredibly useful !

missing this feature a lot :-(

Just did a PR for this


Fix hardcoded amd64 arch for git-shim

Adds TARGETARCH argument similar to updater images to prevent having amd64 binary of git-shim when building arm image

Huh, that's interesting as building a local ARM image has been working for me. I wonder how!

Huh, that's interesting as building a local ARM image has been working for me. I wonder how!

It might be something to do with docker-desktop on macos and it's virtualisation + rosetta. The issue that caused me to see this happened during runtime when executing on linux arm environment.


Bug when updating amount in receive bitcoin screen

When you try to update the invoice amount, and switch between USD and BTC, the amount doesn;t update properly at first but picks up later.
See video attached for how to reproduce the behaviour.
Expected behavior
Amount should be updated concurrently when switching between USD and BTC

Device: iOS and Android
Version 2.1.27

https://user-images.githubusercontent.com/60826700/219028821-37bcd263-8d44-4561-820c-593ccd95895a.MP4

closing this issue (duplicate) since we have it here https://github.com/GaloyMoney/galoy-mobile/issues/1145


Modifications for Carbon Templates

Improvements on the code highlights needed.
Suggest better code highlights
Link to Carbon Now

@ameerhamza619 will you take this up?


Improvement of Build Script with Better Error Handling and Python Best Practices

Here are the changes made in this new version of the build script as well as the bug fixes that has been made to make it better. First, there are improvements in error handling and logging that are incorporated into the script to ensure that there is proper handling of errors that may occur while build and installing the program. This includes the use of subprocess. run to execute shell commands to improve control and feedback compared to the previous use of os. system.
Furthermore, there are changes made in the code to make it conform with current Python standards. Changes made in this release include the updating of the export_version_string function to work more efficiently for both nightly and release candidate versions where the changes have been made to the setup. py file and the correct format of the version string has been written to the version. py file. The refactored move_tf_keras_directory function also has a better and safer way of updating the module references, where it can solve the problem of incorrect module path and guarantees that all the references are updated correctly.
In addition, some changes were done to the build_and_save_output function so as to make it more efficient. The script has been modified to check if the ‘dist’ directory is there and create it if it is not and also show clear messages whether the build was successful or not. SOME CHANGES: The code responsible for wheel installation has been rewritten in the install_whl function to be more reliable; the script now accepts command line arguments that allow users to indicate whether they want to work with nightly builds or release candidates.

This pull request contains important changes and enhancements to the build script we use when building the Keras package. The main changes are:

Enhanced Error Handling and Logging: Moved to use of sub process. use runfor more efficient command execution and improved error messages instead of usingos. system`. The build and installation phases have now been made to throw more informative errors and log them more comprehensively.

Refactored Functions: Enhanced the export_version_string function to better identify Nightly and Release Candidate versions and tweaked the move_tf_keras_directory to safely update module references and paths.

Improved Build and Output Handling: The variable function now checks if the directory ‘dist’ exists and if not, it creates it and also gives better messaging when the process is successful or not. Improved the install_whl function to make the wheel installation more efficient.

**Modern Python Practices:Modified the script in order to fit the standards used in modern Python code, including better command-line parameters handling and enhanced compatibility with Python’s features available in the current version of the language.

These changes intend to improve the stability, and manageability of the build process and make it easier to use, in line with the latest development standards in Python.


Fix full screen in iOS and Mac safari

Currently it doesn't work properly. It doesn't really enter fullscreen and we fake it with CSS, and then the fake breaks when we leave fullscreen.

mac safari fullscreen should work correctly now. ios is trickier
https://github.com/joshmarinacci/voxeljs-next/commit/f242bd167256c0c8117edca38f9fb87c8896c929

ios fixed now. turns out it does support the same api as mac. just needed some webkit prefixes

fixed!


LG Editor: Update Break and Prosody SSML snippets to contain default values

Update the inserted SSML for Break and Prosody snippets to contain default values. I have agreed this approach with @Quirinevwm
Break tag:
Prosody tag:
Rationale for change: Break tag in many cases will be left at medium, this reduces effort for the user. The time attribute currently added is optional, so let's remove it. For prosody, the above will leave the pitch at the default level, but adding a default value improves discoverability of the type of value required and also means we insert valid SSML from the get go.

Currently, here's what is inserted for each SSML tag from menu:
Break:
Prosody:
Audio:
I dont understand the issue, can you elaborate?

@hatpick I must have been using an older build when I made a note of this issue. Closing out.


[wait for #1386] [applications] Enable working applications with v2

Enable working applications with v2. This is done by also enabling split, concat and embedding layer for the V2 design.
Adding some minor updates to the applications to match with the v2 implementation.
An extra property from embedding layer was also removed to work with the new LayerV2 semantics.
resolves #1229
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1387. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @kparichay, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1387-202107161020110.5862181186676-df758ee9a13428bf6379d9008cf7de8250a54789/.


Suggestion: Add 8Ball Image, Add To Github Pages

I think it would be great if you added an image of an 8ball and added this static site to google pages for easy access. I will submit a PR to add the image.
PolishPenguinDev

Hello polish-penguin-dev,
Thanks for giving me a suggestion and I will promise to add it soon
From the creator:
PolishGitHubDev21 :)

8ball Image PR: https://github.com/PolishGitHubUser21/8ball/pull/2

Thanks for merging! Can you add gh pages?


Improved Logging/ Tests for MC

Prior to the changes Mc printed every step to output.log, and logged the tests which were intended to throw errors under error.log.
Mc output.log will now provide colorized print of all tests which are executed, all progress bars and extraneous prints have been removed to make output.log more readable. Mc error.log will only hold errors if an unintentional error is thrown, the convention followed for logging is that the test which failed will be printed to both output and error.log, inside of error.log a line number which the test failed on will also be provided. Because these tests are being done on MC error logging can be improved with the --debug flag. For mc share upload, and mc share download (the more complicated commands), --debug stack traces are logged under error.log if an error is found.
Fixes #86 (only part of it)

@CarterMcClellan looks like shellcheck is failing, please check

Also, here a document of all tests which I am working towards implementing in mint.
Mint MC Tests.docx

@CarterMcClellan I think it will be better to add the doc as .md in the /run/core/mc directory

@CarterMcClellan I tried running these changes locally
$ cd mc
$ cat error.log
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
curl: (6) Could not resolve host: null
Presigned Upload Test 1 Failure
Error on line 164
jq: error: Could not open file myVar: No such file or directory
Watch Objects Test 1 Error
rm: cannot remove 'myVar': No such file or directory

$ cat output.log

  Make Bucket Tests

	Entering Make Bucket Test 1
	Test Success

  Put Object Tests

	Entering Put Object Test 1
	Entering Put Object Test 2
	Test Success

  Put Object Multipart Tests

	Entering Put Object Multipart Test 1
	Entering Put Object Multipart Test 2
	Test Success

  Mirror Object Tests

	Entering Mirror Object Test 1
	Test Success

  Presigned Upload Object Tests

	Entering Share Upload Test 1
	Share Upload Test 1 Failure

  Presigned Download Object Tests

	Entering Presigned Download Object Test 1
	Test Success

  List Object Tests

	Test Success

  Cat Object Tests

	Test Success

  Watch  Object Tests

0a1
> ObjectCreated ObjectRemoved
\ No newline at end of file
	Watch Objects Test 1 Error
	Test Success

  Put Object Error Tests

	Entering Put Object Error Test 1
	Test Success

  Make Bucket Object Error Tests

	Entering Make Bucket Error Test 1
	Test Success

  End of tests

 1 End of tests

Looks like the failure is not properly reported, could you please check

@CarterMcClellan i added a comment please take a look.


FF stop Working. "Downloading Bypass Definitions" loop

Body
Like the title, Fast forward stops working completely on fresh installs, you can access the extension settings, however it does not perform any function both on edge and Chrome. stays in a "Downloading definitions" loop
despite numerical version differences between platform; both are First Time installs were run at the same time and day, with the available versions of .zip for chrome and MS Store for edge.
Issue could also be present in Firefox https://github.com/FastForwardTeam/FastForward/issues/998
Additional Info:
Chrome Version 113.0.5672.127 (Official Build) (64-bit)
[Running AdBlock in parallel   but it doesn't seem to be a problem of additional extensions]
Microsoft Edge Version 113.0.1774.50 (Official build) (64-bit)
OS: Windows 11 Pro 22H2 Build 22621.1702
Version
0.2251 , 0.2256
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
What OS are you seeing the problem on?
Windows
Anything else?

seems failes to load resources from background.js (net::ERR_FILE_NOT_FOUND).

.../src/js/injection_script.js
.../src/js/rules.json
.../src/linkvertise.js

xhr.open("GET", "https://cdn.jsdelivr.net/gh/FastForwardTeam/FastForward@" + upstreamCommit + "/src/js/injection_script.js", true)

This is a known issue that occurs when you already have the latest version. We have fixed this in our prerelease MV3 version.

I have the latest version and it's still happening. It worked a few days ago but not anymore after I accidentally reinstalled the extension. This is on Chrome browser.


Substr "---" in yaml string cause builder crash

If you edit any post content and add string like this to meta fileds:
foo: 'bar---baz'

site:build creashes with error like this:
  [Symfony\Component\Yaml\Exception\ParseException]
  Malformed inline YAML string ('bar) at line 6 (near "foo: 'bar").

Seems that AttributeParser needs a review. I'm working on that

Fixed. Thank you


[QNN] Fix multi batch matmuls

The previous version incorrectly broadcasted across the batch dimensions which led to type errors.
I have updated tests to handle multi batch examples and updated the documentation to note the transposed nature of the operator.

cc @mbrookhart

@tvm-bot rerun

Thanks @AndrewZhaoLuo @anwang2009


Fixed typo in JavaDoc

In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md
Changes

fixed typo in Javadoc of JobFactory.java to correctly spell "opportunity"

Checklist

[x] tested locally
[x] updated the docs
[ ] added appropriate test
[x] signed-off on the above mentioned SoftwareAG contributor agreement via git commit -s on my commits.

Unfortunately, due to the change of ownership of this project, the terms of contribution have been updated, and this PR will need to be re-created, agreeing to the new terms.


adding Colorado medicare exclusion list crawler

I'm getting an error while trying to create the link between the company and the entity saying it's a self referencing link. I left that part of the code commented out.


Trace a message when the blockchainTime starts in the future

When the start time of the blockchain time is in the future, we block until
that time has come. We now trace a message when this happens so that the user
knows what is going on.
A new 'blockchainTimeTracer' was added to accomplish this.

bors r+


Incorrect limit info

East US / East West regions appear to allow for successful creation of Linux containers / container groups with 4 vCPU and 16 GB RAM in both standard (Public) deployments and preview VNet deployments. I have not tested other regions.
(Edit: Specified "Linux" as the OS.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4153e809-a854-ff58-3d1e-31770c36a1f9
Version Independent ID: e37b5834-9174-5ea2-567c-7b2628ed9eeb
Content: Azure Container Instances resource availability
Content Source: articles/container-instances/container-instances-region-availability.md
Service: container-instances
GitHub Login: @dlepow
Microsoft Alias: danlep

Thanks for the feedback! We are currently investigating and will update you shortly.

This is definitely not a bad observation - it's just not a match to the documentation.
Example bash CLI creating a single East US public ACI with 4 vCPU / 16 GBI:
az container create --resource-group [insert-your-RG-name] --name nginx-pub --image nginx --location eastus --cpu 4 --memory 16 --ip-address Public --os-type Linux --no-wait
Example bash CLI creating a single East US private ACI with 4 vCPU / 16 GB:
az container create --resource-group [insert-your-RG-name] --name nginx-priv --image nginx --location eastus --cpu 4 --memory 16 --os-type Linux --vnet [insert-your-VNet-name] --subnet [insert-your-ACI-Subnet-name] --no-wait
Get similar results deploying a multi container group via json template.

@toddjeaton just to confirm, you are referring to this section

and this section

correct?

Yes, correct.

Thanks for confirming!
@iainfoulds if these two sections are out of date, it is quite possible the other numbers need updating as well. Can you take a look? Or if you know who I can get this checked with I can make any edits as needed.

@toddjeaton - Thanks for the heads up. I confirmed your observation with the List Capabilities REST API, which is a good source for up to date info on region capabilities and limitations. I'll submit an update soon to the ACI limits article and confirm data also with our engineering team.
#in-progress

@dlepow Thanks for the update, Dan. That's good info! There's also some of the same data shown at https://docs.microsoft.com/en-us/azure/container-instances/container-instances-vnet under the
Regions and resource availability section.

Documentation updated with current regional availability/limits. @toddjeaton - thanks again for letting us know.
#please-close


Remove broken factory for orchestration stack

Remove orchestration_stack_amazon_with_non_orderable_template that requires no longer existing factory orchestration_stack_cfn. It was only used by classic-ui spec. The non orderable template can be generated in the spec test.

@miq-bot add_label bug
@miq-bot assign @gmcculloug

The UI test no longer needs the deleted factory https://github.com/ManageIQ/manageiq-ui-classic/pull/2295

@chrisarcand Please take another look.


Adding the Social Media in all the footer Section.

I have added the Social media handel's (like LinkedIn, GitHub, Twitter, Instagram) in all the footer sections.
please merge my pull request @Tejashri-Taral .

@Tejashri-Taral  please merge the pull request


user can create  additional addresses but once they log out they cannot recover those addresses

User can create accounts which are additional addresses but once they log out they cannot recover those addresses
After login the second time the extension only shows the first wallet the other "add an account" wallets are lost.
Video of issue
http://somup.com/crVlYVolo4
Image of the switch address option with 3 addresses

user logs out and logs back in switch accounts is not available

Just to be clear, because I had to double check this stuff, the addresses are the exact same when you create the second, third, etc, account. The problem (which is legit) is that they don't show up right away.

Just to be clear, because I had to double check this stuff, the addresses are the exact same when you create the second, third, etc, account. The problem (which is legit) is that they don't show up right away.

Just to be clear, because I had to double check this stuff, the addresses are the exact same when you create the second, third, etc, account. The problem (which is legit) is that they don't show up right away.

Could you elaborate, the address in the picture look to be 3 different addresses.

Just to be clear, because I had to double check this stuff, the addresses are the exact same when you create the second, third, etc, account. The problem (which is legit) is that they don't show up right away.

Could you elaborate, the address in the picture look to be 3 different addresses.

Oh! I see. That is perfectly expected. A wallet is "hierarchical", so there is sort of a "master wallet", and then from there unlimited accounts can be generated from it. This is different than how our other Stacks Wallets have been built, but they can technically also derive multiple accounts. And, with the same secret key, you will always get the same exact address for account 1, account 2, etc, but they will be different. And no one can "link" the accounts together except for you (they're private in that way).

So the issue is its just supposed to make the same address over again right?

Yep!

Oh! I see. That is perfectly expected. A wallet is "hierarchical", so there is sort of a "master wallet", and then from there unlimited accounts can be generated from it. This is different than how our other Stacks Wallets have been built, but they can technically also derive multiple accounts. And, with the same secret key, you will always get the same exact address for account 1, account 2, etc, but they will be different. And no one can "link" the accounts together except for you (they're private in that way).

So the issue is its just supposed to make the same address over again right?

Yep!

Basically, when you use the desktop wallet, you're only seeing "Account 1".

Basically, when you use the desktop wallet, you're only seeing "Account 1".

Got it, so the only issue is that we want it to persist after logout and relogin

Got it, so the only issue is that we want it to persist after logout and relogin

Ready for QA - it will even restore usernames from the old authenticator.

Ready for QA - it will even restore usernames from the old authenticator.


parse_git_branch is not defined

Hello,
When using scm_breeze's index functionality I'm getting the below error and this is due to undefined function being used in repo_index.sh
s watch_tower/                                                                                wael@Phoenix-X
_git_index_pull_or_status:11: command not found: parse_git_branch

Thank you, this project is really helpful and can speed up workflow
Regards,
Wael Nasreddine

Oops, sorry about that. I forgot to pull that function from my .bashrc. This has been fixed (at 4d5126731aa1cb429a78f9d37ad3c8096fcfe25a)

Thanks, it works as expected now :)


GeoJSON output keys in lowercase

Is there a specific reason upper case keys are used in the properties, i.e. ID?  Could these be made lowercase.  It isn't a huge deal, but a consistent key case makes parsing easier.

I typically use upper case for identifiers and lowercase for attributes to set things apart. I can drop that convention if it is helpful elsewhere.


Pacbot keeps on inreasing AutoScaling

Heyyyyy I notice that Pacbot keeps on increasing the AutoScaling group and in less than a week I have about 12 m4.xlarge instances running. Is that normal ? Any way to reduce that ?

@luizfelipepg , Those instances are launched by AWS batch service to process your data. If the data volume is huge AWS instances will be launched accordingly.
Please note that these instances will be terminated automatically once they finish batch-job execution.

@johnakash , thanks, I was suspecting that this was the case but I notice that the instances are not terminating or at least looks like it is not. I have a few instances that were created days ago and never terminated. I have setup only 1 account for now and I am afraid to add the other 18 I have, this might create hundreds of servers ? :P

@luizfelipepg , Could you please let us know which are the jobs running in batchjobs continuously?
How to get job details - Login to AWS console >> Navigate to Batch service >>  Select Jobs >> select queue pacbot-data

Yeap, here is what looks like:

Here is both queues:

And here is showing we have already 27 instances running:

@luizfelipepg , Could you please navigate to Jobs  (make sure you are using pacbot-data as job queue)in AWS batch and grab a screenshot?

I am sending the RUNNING list only, let me know if you need any other
You can see a lot of the Data Colletcor:

There is a lot more of the Data Collecor, I just sent the start and the end

I am already up to 40 instances :/

Ny the way, I noticed that for the ones that are running, the logs keep showing:
2019-10-16 20:22:54 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0

Ok, I decided to terminate all batch process running (for a long time)and that dropped all the instances. Let's see how it goes from here. Any information on what could have happened and how to prevent that ?

Ok, another one started and seem to have a similar problem. I can see this error on logs:
[main] ERROR c.t.c.p.i.InventoryFetchOrchestrator - Delete Failed com.amazonaws.services.s3.model.AmazonS3Exception: The XML you provided was not well-formed or did not validate against our published schema (Service: Amazon S3; Status Code: 400; Error Code: MalformedXML; Request ID: 6F0E1817BD592070; S3 Extended Request ID: vMzvm3LpBFUxMe1t4QdxZckvBdrIf2F2uKd15TuQcqQEH37w0fsTfrXYU8DUs2aMrESVZbiUaUA=)
Just after this I can see this lines I can see
2019-10-16 22:03:03 [main] INFO c.t.c.p.i.InventoryFetchOrchestrator - End : Backup Current Files
2019-10-16 22:03:03 [main] INFO c.t.c.p.i.InventoryFetchOrchestrator - Start : Upload Files to S3
2019-10-16 22:03:04 [main] INFO c.t.c.p.i.InventoryFetchOrchestrator - Uploading files to bucket: xxxxxx  folder: inventory
2019-10-16 22:03:07 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0
2019-10-16 22:03:10 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0
2019-10-16 22:03:13 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0
2019-10-16 22:03:16 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0
2019-10-16 22:03:19 [main] DEBUG c.t.c.p.i.InventoryFetchOrchestrator - Transfer % Completed :0.0
.
.
.
.
.
.

I changed the bucket name to xxxxxx
Transfer line keeps repeating forever....

@johnakash

Had similar issue.. just deployed pacbot in a test AWS account where i dont have nothing other than the VPC created for Pocbot.
Surprisingly i started seeing m4.xlarge instances creating after successful deployment.
The count goes to 40+ and keeps increasing where i dont have anything in this aws account where pacbot is deployed. It is a kind of hack, the code using my aws resources for other purposes?
End up terminating the pacbot deployment.
Any suggestions?


Remote microphone

Just as tittle says, normal remote mic

https://github.com/quasar/Quasar/issues/718


Workbench spams getAccountInfo in higher environments

Workbench gets blocked from mainnet (I think?) pretty doggone quick, probably because we're slamming getAccountInfo so frequently across thousands of accounts https://github.com/workbenchapp/solana-workbench/blob/867b9e0041f9907dffb1b78ca671ad59c4b60fca/src/renderer/components/ProgramChange.tsx#L55-L57

We could bundle these calls up into one getMultipleAccounts that we call every so often, or probably just remove this part (after all, we're subscribing to changes in lamports, so if a change happens, we already get a notification pushed, why not use that?)

I'd like to push this to "next release" - its not a regression, but something we're actively working towards improving.
yes, imo we need to do both - I added code to getAccounts to use the pushed info when its up to date enough (and I'm guessing its not got enough slack), and at the same time, started accounts should be rolled up into a getMultipleAccount

the worst offenders are the not-on-chain accounts - I wasn't caching those. playing with it in rebasing #86