Creating a cluster with a private registry mirror is not documented for vsphere provider

What happened:
After importing packages to a private registry there were no instructions on how to create a cluster using that registry.
What you expected to happen:
I expect to be able to follow the instructions, step by step, to create a cluster using the registry mirror configuration.
How to reproduce it (as minimally and precisely as possible):
Follow the create cluster instructions for GSP here.
https://anywhere.eks.amazonaws.com/docs/getting-started/production-environment/vsphere-getstarted/
Anything else we need to know?:
Environment:

EKS Anywhere Release: 0.14
EKS Distro Release:

I don't think we should document that there.

There is a link from the getting started to the optional configurations which includes registry mirror.
Snow documents registry mirror, but snow needs it by its nature.
It is linked from https://anywhere.eks.amazonaws.com/docs/reference/clusterspec/vsphere/

Creating a cluster is not documented for anything other than Snow, correct. Users are left to infer how that's supposed to work. The current documentation only shows how to add the config. It doesn't include anything about downloading artifacts and bundle overrides.


Rviz crashes trying to load mesh in plugin after reset

http://docs.ros.org/indigo/api/rviz_plugin_tutorials/html/tool_plugin_tutorial.html
plant flag twice, reset and try planting flag twice more, it crashes showing it cannot find the resouece
package://rviz_plugin_tutorials/media/flag.dae

[1439668555.838213851]: OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource package://rviz_plugin_tutorials/media/flag.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/buildd/ogre-1.8-1.8.1+dfsg/OgreMain/src/OgreResourceGroupManager.cpp (line 756)
Qt has caught an exception thrown from an event handler. Throwing
exceptions from an event handler is not supported in Qt. You must
reimplement QApplication::notify() and catch all exceptions there.
terminate called after throwing an instance of 'Ogre::FileNotFoundException'
what():  OGRE EXCEPTION(6:FileNotFoundException): Cannot locate resource package://rviz_plugin_tutorials/media/flag.dae in resource group Autodetect or any other group. in ResourceGroupManager::openResource at /build/buildd/ogre-1.8-1.8.1+dfsg/OgreMain/src/OgreResourceGroupManager.cpp (line 756)
Aborted (core dumped)

Hmm, seems like the plugin is not handling reset correctly. Though I'm not sure how that would affect the resource management. Thanks for the report, but I don't have time to look into it at the moment. If you figure out anything else please let us know. Perhaps someone will have time to look into it.
I'll mark it as untargeted for now.

I have the same issue. Does anybody know how to fix it?

Unfortunately I also did not get the time to fix it. But as a workaround
disabled using a dae file as a resource to show the flagged position.
On Oct 1, 2015 3:44 PM, "zfxw0206"<EMAIL_ADDRESS>wrote:

I have the same issue. Does anybody know how to fix it?
—
Reply to this email directly or view it on GitHub
https://github.com/ros-visualization/rviz/issues/908#issuecomment-144868752
.

I am currently experiencing the exact same problem (using Xenial) using not a dae file but a Ogre::SceneManager::PT_SPHERE. Did anyone have new insights about this issue? Meanwhile, can someone tell me, what exactly happens to a rviz::Display on a reset? Something seems to be not cleaned up correctly here..

I have been troubling with this problem. Turns out, you have to "pre-load" the mesh file using rviz::loadMeshFromResource(filename)
See https://github.com/ros-visualization/visualization_tutorials/blob/0ba771c1ad56ff78afab17d243ac6e628db6b706/rviz_plugin_tutorials/src/plant_flag_tool.cpp#L90
Hope this helps.


xADGroup: Implemented multidomain group members (fixes #152, close #174)

Pull Request (PR) description
This PR builds on the work done in #174 by @robbiddle and implements multi-domain group members.
This PR closes #174, which has been marked as abandoned.
This Pull Request (PR) fixes the following issues

Fixes #152

Task list

[x] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #240 into dev will decrease coverage by <1%.
The diff coverage is 78%.

@@         Coverage Diff         @@
##            dev   #240   +/-   ##
===================================
- Coverage    84%    84%   -1%
===================================
  Files        16     16
  Lines      1437   1470   +33
  Branches     10     10
===================================
+ Hits       1210   1235   +25
- Misses      217    225    +8
  Partials     10     10


Add upcoming events?

Some groups will have events (like local State of the Map conference, meetups, etc).
Should we add an upcoming events data to this index so that tools like iD can show the user when the group's next event will be?

There's already https://wiki.openstreetmap.org/wiki/Current_events out there, and WeeklyOSM team already parses this list automatically. Would be good to leverage this one.
Again, duplication of maintenance is only adding more fragmentation. If for whatever reason you don't find this list useable, could you please make a proposal on how to improve it?

@bhousel Are you planning to collect events in a Git repository at GithHub? If so, please keep in mind that the wiki is much easier to use for people who are not developers and don't know who to use Git. In addition, GitHub is not translated into any language which is a huge barrier for participation. Not to mention the privacy problems due to the collection of personal information by GitHub which is not necessary from my point of view to provide such a service.
I don't want to say that we have to stay with the wiki (a very active wiki editor made me thinking about replacing the wiki by something different) but any service which replaces the wiki or parts of it has to be as accessible as the wiki.

from @mmd-osm:

However, we also have to keep in mind that the Wiki basically allows everyone to add events, no matter or large or small they are, and publishing is immediate without any Pull Request fiddling, etc.. I guess you don't want to grant everyone write & commit access to this repo, which essentially means that we'd be losing a fair amount of flexibility here.

Actually I probably would accept almost any PR to this repo without really looking at it.  If somebody asks "Add our state of the map conference to our group", I'd just do it.  I'd also happily grant write and commit access to this repo to anybody who cares to help maintain it.
The success of editor-layer-index proves that this model of contribution works pretty well.
from @Nakaner:

Are you planning to collect events in a Git repository at GithHub?

I was just thinking something simple like this:
{
  "id": "Mapping-DC-meetup",
  "featureId": "dc_metro",
  "type": "meetup",
  "name": "Mapping DC",
  "description": "Improve OpenStreetMap in the DC area",
  "url": "https://mappingdc.org/",
  "contacts": [
    {"name": "Brian DeRocher", "email"<EMAIL_ADDRESS>  ],
  "events": [
    {"name": "April Meetup", "when": "2018-04-10 18:00", "url": "..."},
    {"name": "June Meetup", "when": "2018-06-12 18:00", "url": "..."},
    {"name": "August Meetup", "when": "2018-08-14 18:00", "url": "..."},
    {"name": "October Meetup", "when": "2018-10-09 18:00", "url": "..."}
  ]
}

iD could add a line for the next event, or nothing if there are no next events.  It's also a nice signal that a group is actually active.
This question is more for people who run the community resources - do you want your event to appear alongside to your group in a listing like this?  For example, I'm more interested to know if @openbrian finds this useful.  I don't have a strong opinion.

If somebody wants to write a thing to scrape the wiki page and move the events into a more structured format, that would be great, but it's not something I know how to do.
For now I'm just going to add a very simple event array to the resources schema like described above.. We might end up using it, or not.

If somebody wants to write a thing to scrape the wiki page and move the events into a more structured format, that would be great, but it's not something I know how to do.

Fortunately, WeeklyOSM already have a working solution for this issue:
Wiki page: https://wiki.openstreetmap.org/wiki/Template:Calendar
Parsed result: https://osmbc.openstreetmap.de/calendar/preview
@Nakaner should have a link to the current repo, I don't have it at hand atm.

@mmd-osm wrote:

@Nakaner should have a link to the current repo, I don't have it at hand atm.

https://github.com/ThomasBarris/osmcalendar

@bhousel trying to create a calender using GitHub is a nightmare - for all those user, which never ever used github and are not able to.
Editing a wiki page (osm wiki or wikepedia) is well known to many users - github is not.
GitHub is for software development, not for replacing an application.

trying to create a calender using GitHub is a nightmare - for all those user, which never ever used github and are not able to.

Agreed - we're not trying to create a calendar!

Agreed - we're not trying to create a calendar!

what else?

@wambacher : I think "We might end up using it, or not." is pretty clear. Let's see what the future brings, if there's lots of momentum in this repo, some sort of import of the existing wiki calendar is likely to happen.  I'm still not sure on how to link geoJSON information in the json with what we have in the Wiki. But that's not a priority for today or tomorrow.


How to create animated model SkeletonNode with controls as TransformableNode?

I create SkeletonNode with animated fbx model. Animation is playing but I can't moving model by finger like TransformableNode with Andy model. I tried set parent TransformableNode to SkeletonNode and vice versa, in not works. How to integrate this classes?

You can create the transformable andy and add it to the anchor. The code example is as follows:
// Create the transformable andy and add it to the anchor.
TransformableNode transformableNode = new
TransformableNode(arFragment.getTransformationSystem());
transformableNode.addChild(andy);
transformableNode.setParent(anchorNode);
transformableNode.select();

Were you able to get this working?

yes it works.
   `AnchorNode anchorNode = new AnchorNode(anchor);
    anchorNode.setParent(arFragment.getArSceneView().getScene());

    SkeletonNode dragon = new SkeletonNode();
    dragon.setRenderable(dragonRenderable);

    TransformableNode transformableNode = new
            TransformableNode(arFragment.getTransformationSystem());
    transformableNode.addChild(dragon);
    transformableNode.setParent(anchorNode);
    transformableNode.select();

`


testcne: add functional tests for cne lib to testcne

Add functional tests relevant to lib/core/cne/cne.[ch]
to testcne. Functions which are covered by other testcne
tests are not covered.
Signed-off-by: Sushma Sitaram<EMAIL_ADDRESS>

Looks pretty good, I think the test name needs to change.

Any suggestions for the test name? Going with the pattern of other tests under testcne, cne_test.[ch] were giving build errors due to the reference to an existing cne_test.h under lib/include

reverify

@sushmasi can you also run "clang-format" before re-submitting this patch? When you added a new include to cli_cmds.h1, clang-format wants to adjust the spaces before the comments.
Obviously this is not very important, but I'd prefer to have clang-format run to be clean.
1 https://github.com/CloudNativeDataPlane/cndp/runs/6558534623?check_suite_focus=true


[Folly, fizz, wangle, proxygen, fbthrift, mvfst] Update to latest version

Describe the pull request
I updated these ports in a single PR because wangle depends on fizz and fizz depends on folly.
I needed to fix rsocket as well because of an error (see bellow).

What does your PR fix?
Makes these ports compatible with OpenSSL 3 (see https://github.com/microsoft/vcpkg/pull/22878#issuecomment-1028779172)
Fixes #20558
Fixes #20586
Adds quotes
Remove deprecated cmake

Which triplets are supported/not supported? Have you updated the CI baseline?
Didn't change

Does your PR follow the maintainer guide?
yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

rsocket fails with error:
D:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\rsocket\transports\tcp\TcpConnectionAcceptor.cpp(32): error C3668: 'rsocket::TcpConnectionAcceptor::SocketCallback::connectionAccepted': method with override specifier 'override' did not override any base class methods [56/59] C:\PROGRA~2\MICROS~3\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe   /TP -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DDEBUG -DFMT_LOCALE -DFMT_SHARED -DGFLAGS_IS_A_DLL=1 -DGLOG_NO_ABBREVIATED_SEVERITIES -DGOOGLE_GLOG_DLL_DECL=__declspec(dllimport) -DGOOGLE_GLOG_DLL_DECL_FOR_UNITTESTS=__declspec(dllimport) -DNOMINMAX -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -ID:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean -ID:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\yarpl\.. -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 -std:c++17 /showIncludes /FoCMakeFiles\ReactiveSocket.dir\rsocket\transports\tcp\TcpConnectionFactory.cpp.obj /FdCMakeFiles\ReactiveSocket.dir\ReactiveSocket.pdb /FS -c D:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\rsocket\transports\tcp\TcpConnectionFactory.cpp

@Thomas1664 ,Thanks for your pr, Have you tested the features locally?

I have tested all features on my local machine

This LGTM, thanks for the major updates!


Fix iterator context

What changed?
Fix iterator context

Why?
ctx field was not init before

How did you test it?

Potential risks
N/A

Coverage decreased (-0.03%) to 59.756% when pulling 3be45024d3564aacc299ab36a773e30bbd069f68 on yycptt:fix-iterator-ctx into 2ea3ca81fc5da5ea0dd09a8d841f8890feec636a on uber:master.


Cryptocoin has no indication of life left

It is just rotating when hit with no indication if the Shift- or the Sub-Towers did anything until it finally reaches the end and draws a life. Really frustrating experience to not know how much life that thing had left.

These coins are meant to be a little challenge, so that the game won't be too easy. It is true that it is not possible to see their current value. But you know that

the coins are about as strong as the strongest numbers in that wave
they spin when hit
and they are not affected by MEM and ACC.

So if a coin makes it through, give the level another try, with one more upgrade to your SUB and SHR.  Or play other levels first, and come back when you have some more heroes at your sides.


I can't find the login name and password, I can't log in. Help me, thanks!

I can't find the login name and password, I can't log in. Help me, thanks!

The 3rd hit.
Help is on the way


[FEAT]: Add Symbols of Other Currencies

Add Symbol of Other Currencies which are not in the WebApp

I am working on the issue and I have a question. When adding the currency symbols if a country has the same currency symbol as another country in the list should I skip it?

No, add it again to that specific country again.

I just submitted a pull request. Please let me know if you like the changes. I have a link below to the website I used for the list of country currency codes.
https://www.worlddata.info/currencies/

Closed by #2


Link to the correct Firefox LiveReload plugin

The README currently links to a rule-based autoreload Firefox plugin. This PR replaces it with the appropriate plugin for the LiveReload protocol that markserv uses.

Pull Request Test Coverage Report for Build 291

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.984%

Totals

Change from base Build 278:
0.0%

Covered Lines:
319

Relevant Lines:
437

💛  - Coveralls


Add plots from Piff running on DC2 1.2i

I'm submitting some plots made by Piff running on DC2 1.2i field 00261962-i.  These include:

Rho statistics (rho.png).  The most notable is rho_1, which is the auto-correlation of the residual shapes between the model and the data.  This is one of the key metrics of PSF fidelity for weak lensing studies.  The results look quite good, as do the other 4 rhos stats, which involve different auto- and cross-correlations that are relevant to shear measurement errors.
Spatial distribution of size and shape errors (twod.png).  These used to show significant outliers that were too numerous for Piff to do a good job of removing them.  But switching to the DM PSF stars for the input list works well, and there don't seem to be any big outliers present.
Histogram of the size and shape measurements and residuals (shape.png).  These probably aren't so informative, but it is the other statistic we have currently built into Piff.  They seem to match up fairly well, and the residuals are pretty well centered at zero, so that's good.

The Piff configuration file I used is also submitted in the same directory (contributed/plots/piff_dc2).  This was run at nersc using the command piffify piff_single_1.2i.yaml.
It turned out that there were a number of changes required to Piff to get it to properly read in the LSST DM data products.  These are in Piff PR #79.
The main change that we may want to push back on DM about is that their variance plane images include the signal as part of the variance.  This is almost never the right thing to use for model fitting.
Piff expects the variance to just include noise from the sky, read noise, dark current, etc.  But specifically, not the signal.  So I had to add code that subtracts off the signal from the variance to get it in the format that Piff is expecting.
@esheldon ran into the same issue, and it will probably keep cropping up.  The easiest long term solution, I think, would be for DM to add another hdu to the calexp files with a normal weight image = 1/variance, where the variance does not include the poisson shot noise from the signal.

@rmjarvis - we are looking to merge the HackurDC2-related PRs in the coming days. Might you be available to address the review comments by ~early next week? Hopefully they can be done with quite minor modifications.
Thanks!

Yao said:

For someone like me who has little idea about Piff, I think it would be very useful to...

Done.

Also, I noticed that piff is not installed in the shared DESC environment. Is this a package that we should install so that members can use it easily without the need to install their own?

Certainly eventually.  And maybe already.  It's a package that is still in fairly active development, so I don't know how averse you are to including unstable packages in that environment.  I don't really use the DESC environment much myself, but then I'm more comfortable installing things myself than most people are.  (And I don't use the DM stack, so that's not something I need to keep up to date for my purposes.)
Perhaps the most appropriate action is to wait until someone requests it?

Robert said

I'm not sure how Mike wants DM to remove the object photon noise; I'd have thought that what he really wanted is to know would be the noise model and the sky level in each pixel. I'd have to check, but I think that this is all available. So I think this comes down to an interface to get that noise, rather than adding it to the calexps.

Well, it's now a solved problem in Piff, so for that purpose, I don't need anything from DM particularly.  The calexps include both the full variance including the signal as well as the signal itself (i.e. the image), so it's relatively straightforward to do that calculation and subtract it off.
However, I expect that this will be something that keeps coming up as other projects desire to do any kind of model measurement on the images.  Indeed it surprised me that DM didn't already have such a thing calculated for your own model fitting algorithms.  Using the full variance including the variance from the shot noise of the signal leads to biased sizes and shapes.  (Probably not so important for flux I guess.)  The right procedure is to let the model tell you the Poisson variance from the expected signal at each point rather than use the realized number of photons.
So either the solution I implemented in Piff needs to become lore that gets passed around among people who want to use the images directly, or DM can add the more usual kind of weight map (inverse variance without signal) as another hdu.  I think in the long run, the latter option makes more sense, but it is kind of up to you.

Jim said

A link to the ADS entry for your 2016 paper (http://adsabs.harvard.edu/abs/2016MNRAS.460.2245J) would also helpful.  Regarding your plot comments, could you be more quantitative on what would be good numbers for the various rho stats for data like this? As a non-expert, I'm not sure how to interpret, say, the rho_1 points given plots like Figure 10 in the 2016 paper.

Done.  (Mostly at this point, the takeaway is that it is broadly consistent with no signal.  Once we run this on more images and beat down the noise, we'll have a better handle on whether there is any problematic correlations here that we need to work on.)

Finally (and I realize this is well outside the scope of this PR), would it make sense to compute these statistics and make these plots for the PSF model used by the DM code?
I expect there would need to be some development in the PIFF package or elsewhere get that to work, but seeing comparisons between the performance of the current PSF model in the DM code vs what Piff obtains might be interesting.

It is definitely outside the scope of what I did here, but I'll see about running that measurement when I expand this up to running on all of DC2.

By all means feel free to keep discussing these other issues (e.g. Piff installation at NERSC), but I am going to go ahead and merge the plots in to master now.


Put the commit message into the clipboard

When a commit fails to put the previous message into the clipboard.

Fixed by #348


Add filtering capability

Problem being solved
Specially when you are starting to use Monolint, sometimes hundreds of issues might arise and you might take months to fix all of them gradually. Filtering of the results would be good for developers that wants to focus only on certains portions of the repo. One could, for example, focus on fixing issues only on "package.json" files, while others could focus on fixing "serverless.yml" issues.
Proposal
Add to the command line the option "--filter=[regex to resource]" so that the results would show only resource names/paths that maches a specific regex.
Examples:
--filter=".ts$" - only return results to files with ".ts" extension
--filter="/extlibs/" - only return results for files under "/extlibs" dir
--filter=".test.ts$" - only return results for files with ".test.ts" in their name

done

done


parameter type formData is not supported yet

We need to handle this parameter type special in two places:

The controller base. Here the parameter should be unmarshalled from the request body as described in https://www.playframework.com/documentation/2.0/ScalaForms
Tests. Here parameters of this type should be marshalled and attached to the request as a body

Hello,
I really need this feature for my project, so I may help you for the implementation. Is it possible to give me some clue? What are the interesting trait or class to modify?
Rémy

@remy-phelipot Cool, thanks for reaching out!
We plan to make plugin feature complete as a next step. This will include support for files as well. I'll start to work on this feature next week.
Probably a couple of places will change, including the controller template. I'm not really sure for now, as I don't have a clear idea how to implement this feature in most non-invasive way.

Ok, glad to hear that! Feel free to ask if you need help.

resolved in master


TLS Termination Policy

Right now APIcast can serve just one TLS certificate for all services (configured by ENV variable). We need a way to have the ability to do this by a policy per service (using ssl_certificate phase).
This policy should be able to offer TLS certificate from various sources:

stored in the policy configuration
stored on the filesystem

But it also could be able to request a certificate from different services like:

SPIRE/SPIFFE
ACME (LetsEncrypt) (https://github.com/GUI/lua-resty-auto-ssl)

closed by https://github.com/3scale/APIcast/tree/master/gateway/src/apicast/policy/tls


Can't reconnect agents to host since this morning

Rancher Version: 1.3.0
Docker Version: 1.12.3
OS and where are the hosts located? (cloud, bare metal, etc): cloud
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) single node rancher, internal DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
I've been running Rancher with 4 hosts for like two months without problems.
Today 3 of them show DISCONNECTED in the server UI without me doing anything. One is still connected.
When stopping and re-creating an agent on one of the hosts I get this log output:
What can I do about this?
INFO: Running Agent Registration Process, CATTLE_URL=http://rancher.storyx.company:8080/v1
INFO: Attempting to connect to: http://rancher.storyx.company:8080/v1
INFO: http://rancher.storyx.company:8080/v1 is accessible
Traceback (most recent call last):
  File "./resolve_url.py", line 21, in <module>
    client = from_env(url=url)
  File "/usr/local/lib/python2.7/dist-packages/cattle.py", line 45, in from_env
    return gdapi.from_env(prefix=prefix, factory=Client, **kw)
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 613, in from_env
    return _from_env(prefix=prefix, factory=factory, **args)
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 632, in _from_env
    return factory(**result)
  File "/usr/local/lib/python2.7/dist-packages/cattle.py", line 12, in __init__
    super(Client, self).__init__(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 197, in __init__
    self._load_schemas()
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 315, in _load_schemas
    response = self._get_response(self._url)
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 266, in _get_response
    self._error(r.text)
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 255, in _error
    raise ApiError(self._unmarshall(text))
  File "/usr/local/lib/python2.7/dist-packages/gdapi.py", line 300, in _unmarshall
    object_pairs_hook=self.object_pairs_hook)
  File "/usr/lib/python2.7/json/__init__.py", line 352, in loads
    return cls(encoding=encoding, **kw).decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
curl: no URL specified!
curl: try 'curl --help' or 'curl --manual' for more information
ERROR: returned
ERROR: --- START ---
ERROR: --- END ---

ERROR: Failed to load registration env from CATTLE_URL=http://rancher.storyx.company:8080/v1 ENV_URL=
ERROR: Please ensure the proper value for the Host Registration URL is set

What output do you get when you run a curl inside the container to the URL you specify?

Closed due to inactivity, please comment if you still need help so we can track this down.


Improved Icons for settings ? elements

PR for "Improve help icons in settings" #20484
Testing plan:
Manual Checks and changed accordingly
GIFs or screenshots:
In Light mode :

In Dark mode :

New code playground :

The screenshots look reasonable. I'm not sure why this issue is double-assigned... @YuhuiJiang99 , @shirleyzhang2 could you review this PR?
Also, while we're at it, @Rishabh-792 could you make the horizontal spacing before the code playgrounds question mark match the spacing before the Message retention question mark?

Added the spacing. Will this work @alya ?

@alya Thank you for bringing this to our attention and apologies for the confusion. I believe @YuhuiJiang99 was the first to claim the issue in the original thread, and we are not sure why it was claimed a second time. I guess all of us are just very excited to contribute to zulip :sweat_smile: @YuhuiJiang99 and I are first-time contributors and tried our best to follow the contribution guide, but if there is anything we could have done in the beginning to avoid this duplicate assignment please let us know!

I don't know why the bot let this issue get double-assigned, so hopefully it won't happen to you again. :)

@sahil839 Please review my PR. Waiting for your review and changes..

LGTM and it's almost same as #20487 except that this PR has some more filled icons changed to empty ones.

Thanks for the review @sahil839 .
Due to some reason, the issue got double assigned and me and @shirleyzhang2 and @YuhuiJiang99 both created a PR each addressing the issue. I am sorry for this confusion.

Hey @alya and @timabbott , requesting you to give this PR a final look and merge it if it looks good to you.
I can also encorporate changes from @shirleyzhang2 's PR (#20487 ) if needed and I think that this will also increase the quality of final commits/PR which can include all of our contributions towards the issue :)

@Rishabh-792 Thank you for the encorporation! Seems like the BOT got both of us unassigned without merging our PR.

@alya @sahil839 can you please check this PR a final time and please let me know about any modifications to be made to resolve the issue in a better way.

You need to squash the commits into a single commit. Check out https://zulip.readthedocs.io/en/latest/contributing/version-control.html for guidelines.

You need to squash the commits into a single commit and also fix the commit message. Check out https://zulip.readthedocs.io/en/latest/contributing/version-control.html for guidelines.

I squashed the commits into a single commit and also updated the commit message. 👍
Any other suggestions ?

LGTM apart from the point that I mentioned in other PR as well that whether we want all icons to be filled or we want to differentiate between the ones used for tooltip and those which are used as links.

LGTM apart from the point that I mentioned in other PR as well that whether we want all icons to be filled or we want to differentiate between the ones used for tooltip and those which are used as links.

About this, Alya commented in the issue that we want the question marks to look the same preferably with empty background.
I did this for the organization settings, and should I also change the filled icons to empty ones in other settings (user profile, stream,) too ?? @alya @sahil839

@Rishabh-792 I think at this point we're uncertain whether we want to do the ? -> i conversion. Could you please split off your fixes for the other two points into a separate commit, so that we can get those merged? Thanks!

@Rishabh-792 I think at this point we're uncertain whether we want to do the ? -> i conversion. Could you please split off your fixes for the other two points into a separate commit, so that we can get those merged? Thanks!

I created a new PR (#21353 ) for fixing the other two tasks.
I am converting this PR into a draft until we figure out the appropriate changes for the icons.
Thanks !

That works!

Closing as https://github.com/zulip/zulip/pull/21353 was integrated and the rest of the issue was closed and replaced with a new plan.


Moving .gleam doesn't remove old .erl files

$ ls build/dev/erlang/hello/build/
hello.erl  hello.gleam_module
$ mkdir src/hey && mv src/hello.gleam src/hey
$ mix compile
Compiling 1 file (.gleam)
Compiling 1 file (.erl)
Generated hello app
$ ls build/dev/erlang/hello/build/
hello.erl  hello.gleam_module<EMAIL_ADDRESS><EMAIL_ADDRESS>
The hello.erl  and hello.gleam_module files should no longer be there

We might need to clear the project subdir in build/dev/erlang on every compile to cover this.
Otherwise, we could potentially leave it to users to run gleam clean in these situations, but that's likely not ideal.
@lpil does this seem like something gleam compile-package should handle? I'm thinking maybe not.

It should not, no. That'd the role of a build tool.

Closed by https://github.com/gleam-lang/mix_gleam/commit/04d0d7a1dbd23cb20fd040e6f4c4e2de7a1216e8


Z-Index of loading animation is above the header

@photoshopped Thank you for reporting this. I'll take a look.


swallow_regex with emacsclient

Hyprland Version
Hyprland, built from branch  at commit 49597688e975c23b4f3bb53e77617ed3cd1e4937  ().
Bug or Regression?
Bug
Description
swallow works with emacs but not with emacsclient
How to reproduce
enable_swallow=true
swallow_regex=^(kitty)$

run emacsclient -c ...

Still experiencing the same


Deleting a Version - the deleted version name is reported as still existing

Replication:

Create a version
Save
Delete the Version
Create a new Version with the same name - get the Error that a version with that name already exists.

duplicate check needs to ignore (soft)deleted stuff, we need to check what will happen in an admin reverts the deletion

Ok, so solution as talked about is probably removing the unique check on version name allowing a user to upload multiple versions with the same name to one project.
The url format would need to be changed as well to <version>.<id> (e.g. 3.0-SNAPSHOT.221)


Bug in Non-Max Suppression

Hi I would like to report there is some bug in NMS parts.
if we wee 267 lines in UltraFace.cs
input.Sort((f1, f2) => f1.Score.CompareTo(f2.Score));
This code is making opposite site sorting for face score.
(lower face score is going first for NMS, higher score should go first)
so, we need to exchange like below:
input.Sort((f1, f2) => f2.Score.CompareTo(f1.Score));
if you have a time, please review it and update it.

@ynchae
You are correct!!!
Just in case, I checked the source code.
https://github.com/Linzaer/Ultra-Light-Fast-Generic-Face-Detector-1MB/blob/3cb8d7f9a9e418ab594b5b0bb349756a49699517/ncnn/src/UltraFace.cpp#L113
input should be sorted as descending.

Fix and published nuget package
https://www.nuget.org/packages/UltraFaceDotNet/<IP_ADDRESS>


[tantivy] Fix for schema deserialization error

There is a feature in serde_yaml that it cannot deal with borrowed strings. It makes impossible to deserialize yaml to Schema due to error invalid type: string \"field_name\", expected a borrowed string
This extra allocation is a tol-tol solution, but it's a far more easier way then rewriting whole serde_yaml and I hope deserializing schema is not a hot path.

I don't understand anything about this bug.
Tantivy does not use Yaml. If you really need yaml serialization that's a feature request you want and you will need to explain why this is useful to you.

There was a one line test in PR that does not working right now:
serde_yaml::from_str::<FieldEntry>(field_content).unwrap();
or similar
serde_yaml::from_str::<Schema>(schema_content).unwrap();

If you really need yaml serialization that's a feature request

You already have yaml serialization due to using serde crate :) There is just a small trouble with deserialization.

About the reasons - we are storing schemas in files, not in the code. Yaml is much easier for human to read and edit:
[{
  "name": "title",
  "type": "text",
  "options": {
    "indexing": {
      "record": "position",
      "tokenizer": "default"
    },
    "stored": false
  }
}, {
  "name": "body",
  "type": "text",
  "options": {
    "indexing": {
      "record": "position",
      "tokenizer": "default"
    },
    "stored": false
}]

vs
- name: text
  type: text
  options:
    indexing:
      record: position
      tokenizer: default
    stored: true
- name: body
  type: text
  options:
    indexing:
      record: position
      tokenizer: default
    stored: true

You can easily be mistaken with this curvy brackets while editing file manually

I see... And I had missed the fact that the dependency was just a dev-dependency for the unit test! I think that is ok then.

I may or may not ditch the unit test in the future when I get annoyed by the extra compilation time.

Sure, the test is mostly for illustrating the issue.

Yes it is great!


Signatures for attr_accessor won't add runtime checks to the writer method

Input
Given the following strictly-typed class:
→ View on sorbet.run
# typed: strict
class Foo
  extend T::Sig

  sig { params(bar: String).void }
  def initialize(bar)
    @bar = bar
  end

  sig { returns(String) }
  attr_accessor :bar
end

And using the Foo class from another piece of code (outside of the purview of Sorbet's static checks) or iRB/Pry:
  foo = Foo.new("Hello, world")
  foo.bar = 42 # <- Strangely, no TypeError is raised! (e.g. when `Foo#bar=` is called)
  puts foo.bar # <- Instead, a TypeError is raised whenever `Foo#bar` is called afterwards

Observed output
The foo.bar = 42-line runs without an exception.
However, when foo.bar is subsequent read, a TypeError of the following kind is raised
TypeError: Return value: Expected type String, got type Integer with value 42

Expected behavior
The runtime error should be raised for Foo#bar=(42), rather than allowing the invariants of instances of Foo to be silently broken.
It should be noted that Sorbet's static checks pick up on this problem. Obviously this only happens if the file/location/environment where this happens is part of the code which Sorbet is checking statically.
I'm pretty sure that the runtime system ought to catch this problem for the places where the static checks cannot.

After encountering this error in my own codebase, I looked through Sorbet's code, and found this test containing a 'TODO' hinting at this problem as well. However, it does not seem like an issue was ever made from that TODO.

One way to fix this, is to override attr_accessor in classes that contain extend T::Sig with the following:
def self.attr_accessor(*getter_names)
  super(*getter_names)

  getter_names.each do |getter_name|
    getter_sig = T::Utils.signature_for_method(self.instance_method(getter_name))
    type = getter_sig.return_type
    setter_name = :"#{getter_name}="

    sig { params(getter_name => type).returns(type)}
    define_method(setter_name, self.instance_method(setter_name))
  end
end

This is still an open issue since the fix was reverted in https://github.com/sorbet/sorbet/pull/6505


[New feature] Bring GO-lang's goroutine support to dart, as Web is not a problem now

hi,
Go-routine

A goroutine is a lightweight thread managed by the Go runtime.

A Goroutine is a function which executes independently and simultaneously in connection with any other Goroutines present in the program.

The cost of creating Goroutines is very small as compared to the thread.

Dart's Isolates are even heavier than threads, so goroutine would be like a 3-yo brother to Isolate.
Why?

Goroutine is the prime highlight feature of GO language.
This feature, along with memory efficiency, can even make the most GO-phers, and NodeJS-ers, jump to Dart.

Why now?
As I could understand from Google Groups: Why not the goroutine way? [Oct 2016], dart team did not implement goroutines before, because:

Dart has Isolates that work in the VM and Browser (implemented as web workers).

Dart was trying to match the JavaScript features

this need to match the present and future JS features

But dart-web is going the wasm route, which will have threading support,
So cannot this be implemented now, because

Make the most GO, and NodeJS users, jump to Dart
Because Memory is not a very big factor now-a-days, which GO users would care about

I also read (in the above google-groups chat), that

Dartino was experimenting with lighter weight concurrency controls, like coroutines

May be because Dartino, did not have the "Web worker" constraints
thanks

Related: Dart Issue: Isolates are way too complex for a standard user

I'll admit I have a hard time placing this issue into an existing bucket. I'm going with library-isolate, but only because that's the existing feature it wants to replace.

But dart-web is going the wasm route,

I wouldn't assume compiling to JavaScript will just go away.

Am I missing something? I thought this had already been a thing for some time now https://youtu.be/SXT7nir1B48

you don't need to wait for javascript to go away, isolates is already native exclusive, they could just build an easier to use isolate (similar to goroutine or kotlin coroutine) without looking into javascript.

I do not support this feature, anymore, after reading:

Isolate groups (having shared heap) can overcome some of the negative scenarios such as parsing a JSON in a spawned isolate and sending the result back to the main thread without a noticeable freeze there.

This fundamental change can ruin Dart, as it seems to violate, some key concepts of the language.

Originally posted by @maxim-saplin in https://github.com/dart-lang/language/issues/333#issuecomment-1130036521
Also,

Visual Studio Code is implemented in single thread JS and packaged as standalone app via Electron

Originally posted by @maxim-saplin in https://github.com/dart-lang/language/issues/333#issuecomment-1129918815
repo admins, please close this issue if needed
thanks

Consider it closed :)


Fix 'acc and gyro output ' bug in imu_sensor.c

1.Fix 'acc and gyro output' bug in imu_sensor.c

OK


Generalize functionality of controller's handling of WebSupervisor sim

At the moment, the controller continuously reports self.position.{xyz} via the WebotsSupervisor sim device. This allows robot testing code to confirm the robot is where it is expected to be. I propose that this should be generalized as follows:
If a sim value with a name of the form {pose,velocity}[defPathOrId][index] is created on the WebotsSupervisor sim device, then after each subsequent sim timestep, but before the new simTime is reported, the controller will set the corresponding value via something like:
webotsSupervisorSim.set("{pose,velocity}[defPathOrId][index]", Objects.requireNonNullElse(robot.getFromDef(defPathOrId), robot.getFromId(Integer.parseInt(defPathOrId))).get{Pose,Velocity}()[index]);

If the above format is too inefficient, see wpilibsuite/allwpilib#6677.

@CoolSpy3, based on the reply to that issue, I'm going to bite the bullet and see how painful it would be to use NetworkTables for this. Let me know if you object.

I'm not totally opposed to that. I'd be somewhat annoyed that sim communication can't be done fully through a single connection, so I might also suggest considering creating a subclass of SimDevice/SimDeviceSim that does basic array parsing (maybe just for ints, doubles, and/or booleans) using strings. If you do want to go with the NT route, DeepBlueSim/CommandVisualizerClient might have some useful example code.

I'm not totally opposed to that. I'd be somewhat annoyed that sim communication can't be done fully through a single connection, so I might also suggest considering creating a subclass of SimDevice/SimDeviceSim that does basic array parsing (maybe just for ints, doubles, and/or booleans) using strings.

Unfortunately there is no support for string values.

Ah, yes. my bad. I'm too used to seeing the API as JSON.

It's looking like I'll be able to make it work. Fwiw, the size of DeepBlueSim.jar went from 1.6 MB to 21.4 MB.

Scratch that. 9.9 MB after removing camera server and opencv.

Fixed by PR #67.


Add task level locks

Closing as the YAML playbooks wont continue and the Plan ones basically have this now


Complete community profile checklist

See here: https://github.com/qMRLab/qMRLab/community
Missing items

[x] Code of conduct
[x] Contributing
[x] Issue templates
[x] Pull request template

Agah suggested @emdupre's tedana's repo for templates ideas: https://github.com/ME-ICA/tedana

@mathieuboudreau 0967127e5ce2a13f60af8703108aa9c368c7a94a should work (based on your idea_pitches repo, this) I guess?

Closed #321.

Amazing !! :tada::sparkles::tada:

@agahkarakuzu any clue why in the settings page, the Contributing and PR template haven't registered?

@mathieuboudreau interesting, it can hyperlink to the COC, but does not give us a green check for that. As for PR template, I will fix it in my next PR.

All set (COC is set as well, but it likes it orange).

Yeah, now that you mentioned it I checked tedana's and we're orange too. I'll see if I can find an example of all greens...


Create Init Command

This command should completely remove the need to clone a the toolkit repo

https://github.com/GoogleCloudPlatform/gke-poc-toolkit/pull/113


Update VariableName docs url

What are you adding in this PR?
The previous link to the VariableName docs in Shopify theme check is going to a 404 page in /docs/themes/. I've updated it to the correct link in /docs/storefronts/.
What's next? Any followup issues?
There are many other /docs/themes/ urls that should be updated to their new location on the /docs/storefronts/.

I have signed the CLA!


Documentation about convolution padding computation is missing

URL(s) with the issue:
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/api_docs/python/tf/nn/convolution?version=nightly
Description of issue (what needs changing):
The documentation refers to an invalid link, https://tensorflow.org/api_guides/python/nn#Convolution, and the reference to that link is recently deleted in this commit:  https://github.com/tensorflow/tensorflow/commit/271df9ce498f630b6c417087f18b32f2f7446a83 (cc @MarkDaoust ).
However, I think the correct action to take is to make an alternative to the invalid link (rather than deleting it).
When the link existed in the past, it contains the formula of how padding is computed for convolution, which is obviously a necessary piece of information for users to know and must be in the documentation.
As a reference, I found some incomplete third-party website that contain the old version of this now-missing page:

Hey @jvishnuvardhan , is anyone working on this?? Can you assign this to me??

Done. Give it a shot.
Those docs are coming from:

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/nn_ops.py#L1138-L1161
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/nn_ops.py#L998-L1135

Hey @MarkDaoust , thanks for replying. Soo do I only need to attach the link of the third-party website in the links to the docs provided by you?? Like just edit the docs with the given link?? Where should I provide the link to the website?? Any specified location?? Please reply thanks.

The api-reference pages on tensorflow.org are built from the source.
Those two links I posted take you to the source for the source for tf.nn.convolution:
If you edit this, and your PR gets merged:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/nn_ops.py#L998-L1135
It will show up on tensorflow.org is a few days.

The link is 404'ing again


CPR hospital admissions for counties only

We will soon have county-level hospital admissions signals in the API from CPR = community profile report.
While this is technically supposed to be coming from the same data source as that underlying the HHS hospital admissions signals (I've checked this with CDC), for unknown reasons, there are disagreements at this point between the data published by these two sources.  This discrepancy, I'm told by CDC, should be resolvable though, and they're working on that.
Also, it should be noted that by my calculations the CPR signals will be 1 day more latent compared to the HHS signals (available at a 3-day lag, rather than a 2-day lag).
I would like the COVIDcast dashboard to show the CPR signal values for county-level hospital admissions, but still HHS for state-level and national hospital admissions.  This should be seamless and not require the user to change indicators, it would be under the "COVID Hospital Admissions" indicator.  But the data description should indicate clearly that it's actually coming from two different sources, and should warn that---at the moment---there is a discrepancy (sum of county counts do not add up to state counts) for unknown reasons, and we're working with the data stakeholders to fix that.
I believe this should affect the following:

When in "indicator mode" with indicator = hospitalizations, region = national, the choropleth map (as a toggle option way from beehive grid) should show CPR county-level signal
When in "indicator mode" with indicator = hospitalizations, region = any given state or county, the choropleth map should show CPR county-level signal
When in "indicator mode" with indicator = hospitalizations, region = any given state or county, the data table at the bottom should show CPR county-level signals
When in "indicator mode" with indicator = hospitalizations, region = any given county, the time series graph should show CPR county-level signals

@sgratzl @RoniRos @krivard Any concerns with this plan?

What is your plan if/when we find out the source of the discrepancy, but it is not going to be corrected?

No plan, really. We keep the dashboard as-is, and just remove the line in the data descriptions us working on it with data stakeholders.
Very few graphics that I referred to above would be possibly problematic: only the county-level time series plot (which overlay county curves with warent state and national level curves in faint lines) and the table (which would compare indicator values, relative change, and spark lines across national, parent state, and counties).
But mostly all the graphics would be coherent, since they would be comparing a signal from a signal data source to itself, either over time or over space.

this is probably going to need to be hard-coded, which is awkward and will reduce our ability to make quick or consistent changes in the future, but it seems worth it.
@sgratzl any ideas for how to specify this? do you want to try to extend the signals doc syntax for it, or handle everything within svelte, or some other options?

question regarding consistency:

When in "indicator mode" with indicator = hospitalizations, region = national, the choropleth map (as a toggle option way from beehive grid) should show CPR county-level signal

so the map will show a different signal than the summary numbers and time series on top? The map itself doesn't have a separate description that would highlight that

Very few graphics that I referred to above would be possibly problematic: only the county-level time series plot (which overlay county curves with warent state and national level curves in faint lines) and the table (which would compare indicator values, relative change, and spark lines across national, parent state, and counties).

yes the geo table for e.g. a county will have following entries:

national value
state value
county value
neighboring county value
so national and state rows will have a different signal right?

for geo table of states it will have:

national value
state value
all contained counties value
with a similar inconsistencies.

for line chart as you mentioned in case of a county the lines will contain a similar mix:

national line
state line
county line
average neighboring county line

How do you wanna handle these inconsistencies? I assume both signals have at least the same unit?

Re the map and all inconsistencies that you point out: yes that's correct in all instances. These are only technically different signals between county and state/national, they're not fundamentally different signals. Meaning, they are really supposed to be measuring the same thing (so yes, in the same units) from the same data source.
If we can put an emphasized line (bold or italics) in the data descriptor paragraph with an explanation, as I said, I think that will be sufficient for now.

blocked till API signal is available.

@sgratzl @krivard Hi guys! Long time no speak about this issue.
I don't think this is blocked anymore, right Katie?
Sam, can we start this then? Thanks.

Yep:
$ curl -sL "https://api.covidcast.cmu.edu/epidata/covidcast_meta" |jq -c '.epidata | map(select(.data_source=="dsew-cpr" and .geo_type=="county"))[]' |head
{"data_source":"dsew-cpr","signal":"confirmed_admissions_covid_1d_7dav","time_type":"day","geo_type":"county","min_time":20210107,"max_time":20220220,"num_locations":3272,"min_value":0,"max_value":825.5714285714286,"mean_value":3.3437084,"stdev_value":12.5475417,"last_update":1645635075,"max_issue":20220223,"min_lag":3,"max_lag":391}
{"data_source":"dsew-cpr","signal":"confirmed_admissions_covid_1d_prop_7dav","time_type":"day","geo_type":"county","min_time":20210107,"max_time":20220220,"num_locations":3219,"min_value":0,"max_value":569.2346462295616,"mean_value":2.6698172,"stdev_value":5.5533145,"last_update":1645635079,"max_issue":20220223,"min_lag":3,"max_lag":391}


For performance issue

Hey am using more the 50000 row of data. But that setCellValue() function will take so much time.
for me this could done by 1m28s.

And also streamWriter.Flush() will take 2s to finishe.

And consider merge cell will take lot of time. Is there any alternative for merge with stream

50000 rows merge cell only 1m28s？i try 1900 rows by 1m19.62s.

Thanks for your feedback, in order to ensure that any operation (range overlap, adjust existing value or object on the range and etc.,) of the spreadsheet with high compatibility, Excelize has done a lot of checks internal, which will slow down, I'll consider optimizing performance for it.

any progress here? A 4200 x 20 cell table takes way to long to write.

@rbucker @xuri I am using the exact flow like yours and facing the performance issue. Writing 1.5 million records into the sheets taking more than 12 hrs to process. @rbucker do you found any workaround?

@rakesh-wrx streaming is the only way but it creates some other challenges when trying to set the column width... I have not figured that part out yet.... the streaming took some trial and error. I would share it except it's part of a larger application and out of context would not be helpful.

Please reference this document and examples about the streaming writer.

Hey @xuri thanks to you and other developers who worked on developing this library. I am finally able to get the desired outcome in a very less time. For your information, I just upgraded the Excelize library from 1.4 to 2.5, and it got a massive improvement in terms of performance. Please refer to the attached image for more info. I have a question for you and am curious to know. Can you please tell me what were the major changes from the 1.4 to 2.5 version that resulted in huge performance improvement?

There is a lot of optimization across multiple versions, please reference the release note of each version and also reference the performance benchmark report.


Check if a Tag already exists on save

Good solution, but it should query the source to see if it exists rather than just looking at the dataclass.
See https://github.com/silverstripe-labs/silverstripe-tagfield/pull/57

@Zauberfisch this needs rebasing
@tractorcow was this fixed by another PR?

Sorry, this has been fixed with https://github.com/silverstripe-labs/silverstripe-tagfield/pull/58. I should have closed this ticket.


Migrate Terraform Data on EKS templates to V5 EKS blueprints.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?
EKS BLUEPRINTS repo is soon deprecating sub-modules to create EKS node groups, fargate,kms, irsa, and emr on eks modules with an intention of leveraging open source aws modules.
As a part of this move all the doeks terraform blueprints will be migrated to use the latest v5 approach.
You will notice the major change is only for creating eks clusters, node groups and emroneks module. Kubernetes add-ons will still use the eks blueprints sub module.

Describe the solution you would like

Describe alternatives you have considered

Additional context

The following blueprints have been updated
1/ https://github.com/awslabs/data-on-eks/tree/main/analytics/terraform/emr-eks-fargate
2/ https://github.com/awslabs/data-on-eks/tree/main/analytics/terraform/emr-eks-karpenter
3/ https://github.com/awslabs/data-on-eks/tree/main/streaming/nifi
This issue will be closed once all the templates are updated with V5 EKS Blueprints

Closing this issue. We will create a new tag and announce once all the blueprints are migrated with V5 approach. We will create issues with individual blueprints


Glue Jobs fail with ERROR when AvailabilityZone is specified

CloudFormation Lint Version
1.12.3
What operating system are you using?
Mac and Linux
Describe the bug
GlueConnections fail linting when az is specified:
INFO     cfnlint.runner:runner.py:125 Run scan of template tests/data/integration/based-on-poc-serverless-service.yml
ERROR    lint_cfn:lint_cfn.py:17 W3010: Availability zone properties should not be hardcoded: Avoid hardcoding availability zones 'us-west-2c'
 at:Resources/AlsoPoliticianProcessingDefaultGlueConnection/Properties/ConnectionInput/PhysicalConnectionRequirements/AvailabilityZone

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-connection-physicalconnectionrequirements.html#cfn-glue-connection-physicalconnectionrequirements-availabilityzone
What's not documented is that AvailabilityZone is required if SecurityGroupIdList[] is provided or the Glue Connection silently fails.
Expected behavior
Should not lint as error.
Reproduction template
Resources:
  AlsoPoliticianProcessingDefaultGlueConnection:
    Properties:
      CatalogId:
        Ref: AWS::AccountId
      ConnectionInput:
        ConnectionType: NETWORK
        Description: Default VPC Connection for job also-politician-processing
        Name: tools-dev-poc-serverless-service-also-politician-processing-network
        PhysicalConnectionRequirements:
          AvailabilityZone: us-west-2c
          SecurityGroupIdList:
          - Fn::ImportValue: DefaultGlueSecurityGroupId
          SubnetId:
            Fn::ImportValue: DefaultGlueSubnetId

This is a warning level rule pointing toward template re-usability.
You can solve these type of things by doing:
Parameters:
  AvailabilityZone:
    Type: String
    Default: us-west-2c

Resources:
  AlsoPoliticianProcessingDefaultGlueConnection:
    Type: AWS::Glue::Connection
    Properties:
      CatalogId:
        Ref: AWS::AccountId
      ConnectionInput:
        ConnectionType: NETWORK
        Description: Default VPC Connection for job also-politician-processing
        Name: tools-dev-poc-serverless-service-also-politician-processing-network
        PhysicalConnectionRequirements:
          AvailabilityZone: !Ref AvailabilityZone
          SecurityGroupIdList:
          - Fn::ImportValue: DefaultGlueSecurityGroupId
          SubnetId:
            Fn::ImportValue: DefaultGlueSubnetId

or
Resources:
  AlsoPoliticianProcessingDefaultGlueConnection:
    Type: AWS::Glue::Connection
    Properties:
      CatalogId:
        Ref: AWS::AccountId
      ConnectionInput:
        ConnectionType: NETWORK
        Description: Default VPC Connection for job also-politician-processing
        Name: tools-dev-poc-serverless-service-also-politician-processing-network
        PhysicalConnectionRequirements:
          AvailabilityZone: !Select [3, !GetAZs ""]
          SecurityGroupIdList:
          - Fn::ImportValue: DefaultGlueSecurityGroupId
          SubnetId:
            Fn::ImportValue: DefaultGlueSubnetId

You can also disable the rule doing:

Metadata:
  cfn-lint:
    config:
      ignore_checks:
      - W3010
Resources:
  AlsoPoliticianProcessingDefaultGlueConnection:
    Type: AWS::Glue::Connection
    Properties:
      CatalogId:
        Ref: AWS::AccountId
      ConnectionInput:
        ConnectionType: NETWORK
        Description: Default VPC Connection for job also-politician-processing
        Name: tools-dev-poc-serverless-service-also-politician-processing-network
        PhysicalConnectionRequirements:
          AvailabilityZone: us-west-2c
          SecurityGroupIdList:
          - Fn::ImportValue: DefaultGlueSecurityGroupId
          SubnetId:
            Fn::ImportValue: DefaultGlueSubnetId


Feature: improve ROS parameter handling

Description

Abstract
This change improves the ROS parameter obtaining in traffic simulator. It adds a ParameterManager class that aims to replace the getParameter function.

Background
The need for this feature originated from implementing Traffic Source feature where it has been noticed that Entity takes over 100ms to spawn, which was conflicting with high spawn rates of Traffic Source.

Details
The ParameterManager class is a simple wrapper over the ROS Node parameter interface which can be passed around to different modules. The aim of this change was to eliminate the usage of getParameter from traffic simulator. The class is initialized with ROS Node type, and it is intended to be initialized in API and then passed to other classes as needed.
This is much faster as the Node object does not have to be created, only the Node object is used to extract the node parameters interface which is later only reused.
Additionally, the forwarding getParameter function has been added to the API.
The performance has been measured and after the change, spawning an Entity takes a little over 1ms.

References
INTERNAL LINK

Destructive Changes
None

Known Limitations
None

Please complete the regression test before releasing the draft pull request.


Migrate JIra afeect version to found in BUild field in Azure devops

I need to migrate Afeect version of JIRA field which is text box to Found in Build in Azure devops which is dropdown where we can enter text as well .. what chnages i need to do in config file

What chnages in config i need to make for the same including the mapper type.
this is config file
config.json

The field mapping would look something like this, I think:
      {
        "source": "versions",
        "target": "Custom.MyAdoFieldReference"
      },

Maybe consider using the Array mapper:
      {
        "source": "versions",
        "target": "Custom.MyAdoFieldReference",
        "mapper": "MapArray"
      },

Where Custom.MyAdoFieldReference is the Work Item Field References in your Azure DevOps instance.


Integer must be between....

Greetings again,
After re-writing my methods due to the breaking changes of V3.0  , i encountered an issue (That may be already been before an issue , just without this message)
  -Integer must be between 0 and 9999.- at WatsonTcp.Message.WatsonMessage.IntegerToBytes(Int32 i)
I dug around a bit , and think its related to the site of the data i want to send?
Is the Metadata limited in some way , eather in size or format ?
The situation:
When my clients connecting to the server,  the server is sending a dictionary with
FileLocations as Keys ( string )  and FileHashes ad Values (string) ( String KeyValuePairs casted to object for sending ofc) .
I thought it would make more sense to send them via the metadata as it already defines a dictionary.   /  Before the breaking changes i did send all that info as normal message as 1 big string and used JsonDeserialize at the endpoint myself . Worked all fine.
Some help here would be nice :p  Thanks

Hi @Crushedice yes, this is due to a size limitation hard-coded into the framing layer.  It can be extended to a larger size by modifying WatsonMessage.cs.  How much data are you sending?

Juust did a test with debug output,
He stops at the metadata with said exception and tells me :
"Metadata: [present,98289 bytes]"
The file where he's reading the dictionary of is 103kb ,
In the notepad there are 1350 Lines , each one - Key + Value  as Json converted.

Creating a branch for v3.0.3 and uploading, would you be able to give it a whirl and make sure it works for your use case?  Expanding metadata out to 99,999,999 bytes.

Branch v3.0.3-beta: https://github.com/jchristn/WatsonTcp/tree/v3.0.3-beta
NuGet package attached here for the same (Debug version)

Branch 3.0.3 Beta :" This branch is even with master. "
I cant see any difference.  Expected outcome - like before

I'm dumb, I did it on master instead of first doing a git checkout v3.0.3.  Please try with master.  Or the ZIP containing the NuGet package.  Let me know, thanks!

Did this work for you @Crushedice ?

Hi @Crushedice I just tested this on my side and it appears to work, definitely sending more than 10KB through metadata.  I added a hidden test command to Test.Client and Test.Server to send metadata comprised of a Dictionary where the key was integers 0...99999 and values that were identical to the key.  Thus it was sending likely 10s of megabytes of data.
I'll go ahead and close this and package up v3.0.3 in NuGet.  Please re-open if you encounter any problems.

Sorry,  Was unavalible today,  but just tested it out, and this reolved my issue. Thanks for this!
A small question i now have with the breaking changes made,
as i dont see any message system here ill ask this here.
Whats the point of the "Data" arg ?
so like  - StreamReceivedFromClientEventArgs args.Data ,  Its saying , i can just get the whole stream from this.
So i could work with Data ,  and dont have to fetch all the stuff myself with the "while" and  Buffer.BlockCopy method?

Awesome, I'm glad it worked for you.
Re: Data - that's right.  If you access Data, then DataStream will be fully read for you, so you can access the data directly.  Cheers!


[Bug]: Preview external pages inside hover editor renders surfing preview behind hover editor window

Bug Description
When hover the mouse cursor on an external link inside a hover editor window, the preview opens behind the hover editor window, as the screenshot sent — where the expected behavior would be the twitter preview appears on front of hover editor window.
Relevant Screenshot

To Reproduce
No response
Obsidian Version
Version 1.5.12 (Installer 1.5.12)
web-browser-only

[X] Did you install only one web browser plugin?

Checklist

[X] I updated to the latest version of the plugin.

It's weird. Will be fixed

Fixed already.

The problem still remains here:

Tested on the Obsidian Sandbox vault, based on the following version:
SYSTEM INFO:
	Obsidian version: v1.5.12
	Installer version: v1.5.12
	Operating system: Darwin Kernel Version 23.4.0: Fri Mar 15 00:11:05 PDT 2024; root:xnu-10063.101.17~1/RELEASE_X86_64 23.4.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 2
	Plugins enabled: 2
		1: Hover Editor v0.11.19
		2: Surfing v0.9.11

Will look into this issue soon


Resolves issue #54

This resolves issue #54

When bludgeoning, piercing, and slashing from nonmagical attacks is selected, it always appears at the end of the list
This damage type is always preceded by a semi-colon
Does not display a semi-colon if it is the only resistance type selected

I broke something trying to resolve conflicts with my local working copy, and it added all of the commits to this PR. I need to fix this.

Do you mind including a basic description of what a PR does in each title? And then link the associated issue with the "linked issues" box? I keep losing track of what's what.

Sure, however, I have a mess with this PR. I'm going to close it, create a new branch and submit a new PR for this. I can't just rollback my commits with what I did.


Use TestDatabases to exercise the experimental code in the catalog backend

No changeset, since it only affects tests and devDependencies. The reviewer may want to uncheck show whitespace changes.
No real functional changes to the tests, basically just the .each dance and longer timeouts, and maybe putting the SUT creation code in a function instead of a beforeEach.

Hm, we could filter on CI=1 or so as an allowlist type of thing, but that's a bit unfortunate perhaps.
You can always supply the BACKSTAGE_TEST_DISABLE_DOCKER=1 env var when running locally to speed it up, but that's cumbersome.
Suggestions?

I'm probably in the CI=1 camp where you flag that you want to run the CI tests, if the flag ain't there run it against sqlite in memory.
And don't get me wrong, it's great to get this in to catch the differences in databases/versions.

Aight, yeah that might make sense, although it does form a kind of coupling between the code and the build env. Either way that's a change in backend-test-utils that we might want to do separately then


Creates the backend.

This is more than the title. It creates the backend for the system. It adds the models, routes, and controller.
I followed the tutorial that North gave us and then made it work for us.
Currently, we can do all of the regular CRUD operations on our database. We can make it do more as we find that we need more.
It works as long as you have the local database on your machine.

Er, update the .gitignore

Made requested changes.


[resolves #701] Ensure converters can be loaded from package names sp…

…cified in TypeConverter manifest file

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/516/
Test PASSed.


User Online Status

How can i display user is online or offline in this MVC structure.

Hi, this MVC framework doesn't include anything to do that by default, although it could be used for such a task. There's a discussion here that might help.


theme and template specification

@justinwalsh I am designing a custom template and theme.
Since the website is down at the moment, how do I specify in the config.json the template and the theme I want to use?
Thanks!

The site has been reuploaded, please look at this page : https://dauxio.github.io/For_Developers/Creating_a_Theme.html

@VincEmond the documentation is incorrect. You'll notice that I have a pending pull request with the corrections.


using crypto with koa 2

When I am trying to use node crypto example with koa2 context behave like it would be lost
router.get('/password', (ctx, next) => {

  const crypto = require('crypto');
  crypto.pbkdf2('secret', 'salt', 100000, 512, 'sha512', (err, key) => {
    if (err) throw err

    const hex = key.toString('hex')

    ctx.status = 200
    ctx.body = hex

    console.log(hex)  // '3745e48...aa39b34'
  })
})

I have got error:
assert.js:81
 throw new assert.AssertionError({
 ^
 AssertionError: headers have already been sent
 at Object.set status [as status] (/code/node_modules/koa/lib/response.js:82:5)
 at Object.status (/code/node_modules/delegates/index.js:92:31)
 at InternalFieldObject.crypto.pbkdf2 [as ondone] (/code/code/routes.js:13:24)

If I wont set ctx.status = 200 inside pbkdf2 then I got 404 Not Found default response
Any idea of this behavior?

I think u have to use the synchronous version of pbkdf2. I've not really tested it.
router.get('/password', (ctx, next) => {
  const crypto = require('crypto');
  const key = crypto.pbkdf2('secret', 'salt', 100000, 512, 'sha512');
  ctx.status = 200;
  ctx.body = key.toString('hex');
})

Or you should wrap the async method in a promise, then you can await it.
Maybe something like this:
const crypto = require('crypto');

function generatePassword(secret, salt) {
  return new Promise((resolve, reject) => {
    crypto.pbkdf2(secret, salt, 100000, 512, 'sha512', (err, key) => {
      if (err) {
        reject(err)
      } else {
        resolve(key.toString('hex'))
      }
    })
  })
}

router.get('/password', async (ctx, next) => {
  const hex = await generatePassword('secret', 'salt')
  ctx.status = 200
  ctx.body = hex
  console.log(hex)  // '3745e48...aa39b34'
})

like that manually or use https://github.com/normalize/mz to get promise version of pbkdf2

@dicearr sync version works but it freezies node thread while calculating
@slaskis wrapping code into promise gives same results


Preconfirmation API Spec Draft

This PR contains the initial draft of the API specification.

Merging this PR to open the repo to issues/comments


Add optimizer rule randomization support for integration tests

Summary of the changes / Why this improves CrateDB
This adds support for the randomization of optimizer rules in the integration test. Rules will be randomly disabled. This can be specified using an Annotation:
 @UseRandomizedOptimizerRules()
 public void test_my_optimizer_rule() {
     ...
 }

It's possible to specify the value for randomization (0 never, 0.5 sometimes, 1 always):
 @UseRandomizedOptimizerRules(1)
 public void test_my_optimizer_rule() {
     ...
 }

There is also the possibility to keep rules out of the randomization to make sure they always run:
 @UseRandomizedOptimizerRules(alwaysKeep = MyOptimizerRule.class)
 public void test_my_optimizer_rule() {
     ...
 }

and also do it for multiple rules:
 @UseRandomizedOptimizerRules(alwaysKeep = {MyOptimizerRule.class, AnotherRule.class} )
 public void test_my_optimizer_rule() {
     ...
 }

Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Will look into it in more detail tomorrow.

I would rename it to alwaysKeep to be clear that any randomization wouldn't remove the rules.
Would it make sense to also add an alwaysRemove?

Will look into it in more detail tomorrow.
* I would rename it to `alwaysKeep` to be clear that any randomization wouldn't remove the rules.

This is a good idea. I will do it.

* Would it make sense to also add an `alwaysRemove`?

I thought about that as well but wanted the scope limited for now and could not come up with a use case where I would need that.

Would it make sense to also add an alwaysRemove?

I thought about that as well but wanted to keep the scope limited for now and could not come up with a use case where I would need that.

Sure, we can always add it later, when we have a use case for it.


Add platform support to bash script

Signed-off-by: navendu-pottekkat<EMAIL_ADDRESS>Description
This PR fixes #2309
Add a -p flag to the bash script which takes in a PLATFORM(defaults to "docker" if no platform is specified) and uses this flag to start Meshery with mesheryctl system start -y -p $PLATFORM.
A new global --platform -p flag has been added which will take in a platform and initialises the config.yaml file with it when it is first being created.
Notes for Reviewers
I have tested the changes in mesheryctl and it works fine.
I tested the bash script by copying the changes to a test.sh file and executing bash test.sh -p <platform name> pointing to the locally created mesheryctl binary.
Is there any other way to test this? I don't why it should not work when we deploy this to the stable release.

[x] Yes, I signed my commits.

@leecalcote I have tested the changes script with a local mesheryctl binary(not sure how to test e2e) but I do not see why it would behave differently when deployed.
If this is okay, I will also add the update to the documentation adding new commands.

Our goal here being to eventually move to Kubernetes as the default platform or even better prompting the user if -p isn’t specified.

@leecalcote Yes, changing the default platform here and on mesheryctl is straightforward. Once we have Kubernetes ready, we can make that change.
Should I add the prompt user in the bash script?

Thank you. Yes, both in the bash script and in mesheryctl when a new meshconfig is being created, if the platform isn't set, please do prompt the user.

Sounds good. Will add the change

This should work for the bash script right?
The first one is the input and I echo the platform at the end of the script

@leecalcote Made the changes as you mentioned. (Check the above comment for bash script changes)

start without specifying platform and then specifying a valid platform
start without specifying platform and then specifying an invalid platform
start specifying a platform

Please ignore the errors as they are unrelated.

This is great, @navendu-pottekkat. The only tweak I can suggest is that echoing the name of the platform when -p is present with docker or kubernetes isn't necessary. It's just debug.
If echo'ed, a message like Deploying Meshery to <platform>... is more useful to the user.

I do not think I echo, I used that for a demo script to demonstrate the change I made rather than testing with the whole bash script.


Vite injects css assets in wrong order with dynamic import and css modules.

Describe the bug
Vite injects css assets in wrong order with dynamic import and css modules.
Reproduction
Repo to reproduce
For example:

You have component Button with default styles (text color: red)

/* button.tsx */
import React from "react"
import classnames from 'classnames'

import styles from './button.module.css'

type ButtonProps = {
	children: string
	className?: string
	onClick?: () => void
}

function Button({ children, className, onClick }: ButtonProps) {
	return <button className={classnames(styles.button, className)} onClick={onClick}>{children}</button>
}

export default Button

/* button.module.css */
.button {
	color: red
}

You have Page component. This page use Button component and overrides it styles by passing custom class name as a prop (text color: green)

/* home.tsx /*
import React from "react"

import Button from "../../components/button/button"

import styles from './home.module.css'

function HomePage() {
	return

Home page

		<Button className={styles.greenTextButton}>should be green</Button>

}

export default HomePage

/* home.module.css */
.greenTextButton {
	color: green;
}

You import Page component with dynamic import.

import React, { lazy, Suspense, useState } from 'react'

const HomePage = lazy(() => import('./pages/home/home'))
const AboutPage = lazy(() => import('./pages/about/about'))

function App() {
  const [page, setPage] = useState('home')
  return (

       setPage('home')} style={{ marginRight: '5px' }}>home page
       setPage('about')}>about page

      <Suspense fallback={
loading
}>
        {page === 'home' && (
          <HomePage />
        )}
        {page === 'about' && (
          <AboutPage />
        )}
      </Suspense>

  )
}

export default App

You exepect page styles will override button styles, but they are not (as vite injects styles in wrong order)

P.S. You can reproduce this but with cssCodeSplit: true or false.

System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 94.85 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.volta/tools/image/node/14.16.1/bin/node
    npm: 6.14.12 - ~/.volta/tools/image/node/14.16.1/bin/npm
  Browsers:
    Chrome: 91.0.4472.114
    Firefox: 89.0
    Safari: 14.1.1
  npmPackages:
    vite: ^2.3.8 => 2.3.8

Used package manager:
Logs

 vite:config bundled config file loaded in 42ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'alias',
  vite:config     'react-refresh',
  vite:config     'vite:dynamic-import-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'rollup-plugin-dynamic-import-variables',
  vite:config     'vite:import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     polyfillDynamicImport: false,
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     minify: 'terser',
  vite:config     terserOptions: {},
  vite:config     cleanCssOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     brotliSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null
  vite:config   },
  vite:config   configFile: '/Users/anatoliidomaratskyi/Work/Mimy/css-code-split-order/vite.config.ts',
  vite:config   configFileDependencies: [ 'vite.config.ts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/Users/anatoliidomaratskyi/Work/Mimy/css-code-split-order',
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object] ] },
  vite:config   publicDir: '/Users/anatoliidomaratskyi/Work/Mimy/css-code-split-order/public',
  vite:config   cacheDir: '/Users/anatoliidomaratskyi/Work/Mimy/css-code-split-order/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   isProduction: true,
  vite:config   server: {
  vite:config     fsServe: {
  vite:config       root: '/Users/anatoliidomaratskyi/Work/Mimy/css-code-split-order',
  vite:config       strict: false
  vite:config     }
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   optimizeDeps: { esbuildOptions: { keepNames: undefined } }
  vite:config } +6ms
vite v2.3.8 building for production...
✓ 33 modules transformed.
dist/assets/favicon.17e50649.svg   1.49kb
dist/index.html                    0.45kb
dist/assets/home.5d3a6e0a.js       0.26kb / brotli: 0.15kb
dist/assets/button.14aa6fb9.js     0.80kb / brotli: 0.41kb
dist/assets/home.deac2baa.css      0.04kb / brotli: 0.04kb
dist/assets/about.563410d2.js      0.60kb / brotli: 0.28kb
dist/assets/button.a44dba50.css    0.03kb / brotli: 0.03kb
dist/assets/index.3938cd91.js      1.55kb / brotli: 0.60kb
dist/assets/about.d57e38e3.css     0.06kb / brotli: 0.05kb
dist/assets/vendor.cc984a25.js     127.61kb / brotli: 36.05kb

Before submitting the issue, please make sure you do the following

[ +] Read the Contributing Guidelines.
[ +] Read the docs.
[ +] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[ +] Provide a description in this issue that describes the bug.
[+] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[ +] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

the same issue for vue vite

vite: 2.2.0
the same issue

i also meet the same problem

I also have the same problem with React

I also have the same problem with React

+1

I also have the same problem with React

How did you solve it

Same problem.

Same problem.

Same problem.

Same problem.

Same problem.

Any updates?(
Maybe @sodatea will provide some thoughts where to find problem in project and i will try to make pull request to vite?

I'm seeing this issue as well, now that I've started to use storybook's new dynamic loading feature, my styles are broken in production stories.  I've found that the css files are directly after the component in the network tab.  So, in one example, I have a RadioButton component that imports Label (which has its own styles that I want to override), and then it imports some css module with the overrides.  However, when building now, I see this:

Which puts the RadioButton styles higher in the cascade, and they are overwritten by the Label styles, which is backwards from what I want.

Here is a minimal stackblitz reproduction: https://stackblitz.com/edit/vite-gu874q?file=main.jsx

Great work @IanVS! Really hope this helps resolving the issue. I would help, but have no idea on where to start unfortunately.

I finally found the culprit, and FOR a while I thought vite-plugin-pages and unplugin-vue-components were causing the problem, my bad. Glad to use them again.
My temporary solution is to load influenced page synchronously in router configuration.

any idea when will #6301 be merged?

As far as I know it's not ready, @mgiraldo.  This is a sticky problem to solve.  If you have any ideas or can help out, please do!

i understand. thanks for all this work!

I wonder whether Vite could maybe look for a __vite__injectStyle global hook to allow overriding the head.appendChild behavior.
With Webpack's style-loader one can specify a function/hook that will be called to place the style tag into the DOM (by default it will just append it to the head like Vite does).

Webpack Configuration
// webpack.config.js
      {
        test: /\.css$/,
        use: [
          {
            loader: "style-loader",
            options: {
              injectType: "singletonStyleTag",
              // this hook will be
              insert: require.resolve("./tools/insertStyleTag.ts"),
            },
          },
          { loader: "css-loader" },
        ],
      },

// insertStyleTag.ts
function insertStyleTag(element) {
  element.dataset.styleLoader = "";

  // Custom logic, could be more complicated. Here I added a marker
  // to ensure `import ...` styles are added before `styled-component`
  // styles.
  document.head.insertBefore(
    element,
    document.head.querySelector("[data-styled]")
  );
}

module.exports = insertStyleTag;

For those who (like me) had to ship and need a temporary workaround: Depending on your project, you may be able to use build.cssCodeSplit to extract a single css file which has the classes in the correct order.

sadly this didnt work out for me @laurentvd 😔 i might need to refactor my components 🤔

hay!
It's almost finished now, but it's stuck at one point. Now the loading order should be as expected, but there is still a problem with the execution order
Why pre-load blue.module.css but execute first__vite__updateStyle is post-load red.module.css 🥲
However change the import order I do, it always load order by red -> green -> blue in dev mod.

This is a pretty big issue. The production build styling order also differs in order compared with the dev build making working with Vite a nightmare for me. Is there no workaround I can use in the meanwhile, it seems we are a long way from having this fixed?

@poyoho Any progress?

I tried out the latest vite 2.9.14 version, and the situation seems to be improved (not as many style errors as before), but not quite yet resolved.  I rebased https://github.com/vitejs/vite/pull/6301 onto the latest 2.9 branch as well, but its test is still failing.

I have this problem i add antd css in main file and other css in component but in dev ant last style and component css before antd.
Any have solution until fix it?

I import css end of all import in component before and now most first import all css and then import other component and solved this issue.
Component A
import "compnentA css"
import ComponentB from "."

ComponentB
import "compnentB css"
import other component

But with CRA haven't this problem

This is a really big issue which is now open for over one and a half year and more. Is there any progress? anything on the horizon?
We are using BEM. But with this problem parent component is not able to overwrite child css with a class which forces us to do parent > child selectors to get higher specifity which is against what we want to do with BEM. So we are a bit in trouble.
Any workaround on this, or idea when this will get solved?

which forces us to do parent > child selectors

@awacode21
not really a solution, but yet another workaround when you can't use (or it would be tricky) a parent selector -> .something:not(#\#) (or actually any other bogus value for :not(...)) to make a selector more specific easily.
(still struggling with this issue here since forever (already had it in webpack too))

@poyoho Can we please get an update on the progress of this and https://github.com/vitejs/vite/pull/9278?

has this issue perfectly resolved? Or still working on it?

As far as I know, it is not fixed and I don't think anyone is actively working on it.  @poyoho made some heroic efforts on it, but was never able to handle all the edge cases.  I wonder if code splitting is just fundamentally incompatible with css modules.

is the goal with #9278 to make CSS insertion (in dev) follow what's already happening in production builds?

just to be certain, is the goal with https://github.com/vitejs/vite/pull/9278 is to make CSS insertion (in dev) follow what's already happening in production builds?

I don't think so.  If anything, it is to make production builds behave similarly to dev.

The only way to preserve CSS ordering when bundling is to bundle all CSS into 1 CSS file per-page. Once you chunk common dependencies you are creating scenarios where ordering will be different on some pages. In Astro we are reconsidering whether to use the :where selector due to this. We might also come up with some other solutions. Just chiming in that the underlying problem is probably unsolvable.

I suppose it's also not possible to just bundle all CSS into a single bundle at build, because the order of the dynamic imports can't be known until runtime, right?

@IanVS For the entire site or a single page? For an entire site that's typically unwanted because the CSS file is going to be quite large and it will cause unwanted styles on some pages. If you mean on a single page you can do that, but it just means that shared CSS gets loaded once for each page, and people often don't like that.

I'm curious if it's possible to deploy a true unbundled build that just loads the CSS the same as in dev..

akin to the "granular chunking" in project aurora: https://developer.chrome.com/blog/introducing-aurora/

@IanVS For the entire site or a single page?

In my case, I have a single-page-app (so I guess, both?).  Right now, I'm not able to use dynamic imports / lazy loading because of the style problems.  Even if I had to load the entire site's CSS up front, that would be a bit of an improvement if I could start to code-split the JS.  But, I doubt that it's possible to bundle all the CSS in the correct order in that situation.
This issue is specifically about css modules.  I suppose other styling approaches do not suffer this same problem, and perhaps I need to investigate other approaches if I want to use dynamic imports.  Has anyone else here had any luck working around this problem by changing your approach to styling?

i mentioned above that i worked around it using cascade layers. it was a long time ago so i don't remember the exact details (i think it was with css modules).
when you define your layers upfront, the order of imports doesn't matter anymore so it will behave predictably even if vite messes it up.

I'm very excited about cascade layers.  I even created https://github.com/DefinedNet/postcss-assign-layer to make it possible to automatically assign component css to a particular layer based on a glob.  Unfortunately browser support is not yet good enough for me, and the postcss polyfill requires that all styles are known up-front: https://github.com/csstools/postcss-plugins/issues/376#issuecomment-1126511448.

I have the same issue. Vite --host works fine, but code after Vite build mixes order css files. My workaround is !important property but it is crap

Have you tried something like this in vite.config:
export default defineConfig({
    css: './path/to/main.css'
})

I've no tried before, but I think it could be priority.

This reference could help with this issue?
[https://vitejs.dev/config/shared-options.html#css-modules](Vite css.modules)

Any progress on this issue please? I'm having the same problem when packaging my application using the Federation module.

For those who (like me) had to ship and need a temporary workaround: Depending on your project, you may be able to use build.cssCodeSplit to extract a single css file which has the classes in the correct order.

I see the wisdom in Remix of having "per-page" css loaders in this case - JS imports and CSS cascade generally follow an inverse relationship, right? So the most correct CSS cascade will need about one CSS chunk per page..

I'm having related a related issue but perhaps also different? Every time I run vite build it slices all of the css code above the media queries in one of my components off. I checked the compiled css and half of that module is no where to be found. Any update on this? I tried disabling code splitting but it didn't seem to work, or perhaps my config file was wrong..

In my case css injection  seem to be  sorted by name.

replace app with zpp in manualChunks

This seems to still be an issue. Really killing me. Any updates?

is there any update on this?

Applying styles in the wrong order is a deal breaker for using vite.
I don't understand - why is this issue still open and more importantly, how are people actually developing with vite when you cannot trust the css order?

I don't understand - why is this issue still open

Because it isn't fixed yet. Have you considered that this may be a difficult problem?

more importantly, how are people actually developing with vite when you cannot trust the css order?

There are solutions to manage cascade order that do not depend on CSS order. Have you considered reading the thread that you're commenting on?

Speaking of cascade layers, if you're using css modules (which is likely if you're hitting this issue), you could try out https://github.com/DefinedNet/postcss-assign-layer to assign all of your components to a separate layer from your global / utility layers.  This doesn't work with the cascade layers polyfill, but I think browser support is good enough you shouldn't need the polyfill anymore.

I don't understand - why is this issue still open and more importantly, how are people actually developing with vite when you cannot trust the css order?
@adamxi I also encountered a similar problem in project. In our project we use Vue3, and to make global styles more basic, we imported them into main.js before importing App.vue, so on the final page in the chunk tree, global styles are imported first, and more specific ones in tags

I'm having related a related issue but perhaps also different? Every time I run vite build it slices all of the css code above the media queries in one of my components off. I checked the compiled css and half of that module is no where to be found. Any update on this? I tried disabling code splitting but it didn't seem to work, or perhaps my config file was wrong..

UPDATE: I just want to retract my addition to this issue. Mine was an embarrassingly newbie mistake of leaving a comment open >.<

I've got a really hacky solution in case it helps anyone, but it is very possible that it only works for my particular project: it consists of moving the styles from the  to the bottom of the :

However, keep in mind that in my project:

In development the styles are added with multiple


Remove extraneous semicolon in pronghorn test

Resolves current pronghorn failure in https://civet.inl.gov/job/2615353/

Job VTB Documentation, step Sync Docs on e80c6d4 wanted to post the following:
View the site here
This comment will be updated on new commits.