[SPARK-14143] Options for parsing NaNs, Infinity and nulls for numeric types

What changes were proposed in this pull request?
Adds following options for parsing type-specfic nulls to CSV data source:

byteNullValue
integerNullValue
shortNullValue
longNullValue
floatNullValue
doubleNullValue
decimalNullValue

Adds following options for parsing NaNs:

floatNaNValue
doubleNaNValue

And following options for parsing infinity:

floatNegativeInf
floatPositiveInf
doubleNegativeInf
doublePositiveInf

How was this patch tested?
TypeCast.castTo is unit tested and an end-to-end test is added to CSVSuite

Test build #54113 has started for PR 11947 at commit 93ac6bb.

Test build #54113 has finished for PR 11947 at commit 93ac6bb.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54113/
Test FAILed.

Merged build finished. Test FAILed.

ping @HyukjinKwon and @rxin

@cloud-fan would you take a look at this if you have time?

For codes, overall, it looks good to me. However, I am not used to and have a lot of experience of dealing with NaN, Inf  or -Inf. If the values can be different in many cases, I think it is reasonable.
Nevertheless, I feel a bit questionable for the options for null for each type.

I found both NaN and Infinity are handled in JSON data source and it was fixed in this PR, https://github.com/apache/spark/commit/7a9dcbc91d55dbc0cbf4812319bde65f4509b467.
cc @yhuai for reviewing.

I'm not sure how complicated the use case will be, but it really scares me with so many options...
If we decide to do it, I think we should also add these options to JSON, to make them consistent.

Test build #55010 has started for PR 11947 at commit 180a900.

Test build #55010 has finished for PR 11947 at commit 180a900.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55010/
Test FAILed.

Merged build finished. Test FAILed.

Test build #55033 has started for PR 11947 at commit 124873b.

Test build #55033 has finished for PR 11947 at commit 124873b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55033/
Test FAILed.

Merged build finished. Test FAILed.

Test build #55559 has started for PR 11947 at commit 161a3eb.

Test build #55559 has finished for PR 11947 at commit 161a3eb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55559/
Test PASSed.

Merged build finished. Test PASSed.

hello!
why is there no stringNullValue?
basically i want for a column with type string to read in all empty strings as nulls. this is what the old option "treatEmptyStringsAsNulls" used to do. its the natural complement for writing out nulls as empty strings (without this data does not roundtrip).
thanks

do these settings roundtrip correctly? say i set doubleNaNValue to "XY", and i create a dataframe with a Double.NaN in it, does it get written out correctly as XY, and then XY gets read back in correctly as Double.NaN?

i personally would have been happy with a simple single values for nulls for all datatypes.
and the usage of that single value should be consistent across reading and writing. so when that value is encountered during reading it becomes null (except for double/float columns it becomes NaN perhaps), and when writing a null values gets written out as this value.
for example when dealing with text files dumped from hive this value is typically "\N" across all columns and datatypes. when i read this sort of data i simply want every "\N" to become null, and when writing out data that needs to be compatible with hive i would like to write out nulls across all columns as "\N".
for cascading/scalding this value is typically "" (the empty value). so again i would want all empty values to be converted to nulls when reading, and when writing i would want every null to be written out as the empty value.
thanks

As discussed offline, we should just have a single option for setting null, another for nan, another for inf and negative inf. Basically just 4.

Test build #57394 has started for PR 11947 at commit 698b4b4.

Test build #57394 has finished for PR 11947 at commit 698b4b4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57394/
Test PASSed.

@falaki sorry this no longer merges cleanly. Do you mind bringing it up to date?

@rxin done.

Test build #57423 has started for PR 11947 at commit 6facd26.

LGTM pending tests.

Test build #57423 has finished for PR 11947 at commit 6facd26.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57423/
Test PASSed.

please also provide a way for strings to be converted to null upon reading

@falaki can you update the pr description?

@HyukjinKwon would be great if you can review this. Thanks.

LGTM. (Maybe we should not forget, for documentation,  nullValue has the highest priority than other options such as nanValue if the same value is given as option)

OK I'm going to merge this in master and manually update the commit message.


New mutation needed for convert button functionality

Two new mutations are needed to support the convert button functionality in @lnflash/flash-mobile

Sending money from BTC -> USD:
Sending Money from USD -> BTC

Should send money from USD wallet to BTC wallet, and it should be a split payment so that Flash is getting a fee for the conversion.

Closing as not planned


gsimplecal: 2.1 -> 2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gsimplecal/versions.
meta.description for gsimplecal is: "Lightweight calendar application written in C++ using GTK"
meta.homepage for gsimplecal is: "http://dmedvinsky.github.io/gsimplecal/"
meta.changelog for gsimplecal is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.2 with grep in /nix/store/83z8ql7313f37xgf03l16syaijrfinwb-gsimplecal-2.2

directory tree listing: https://gist.github.com/1d72de8bb9aa471ddcb26bdf8348cd6a

du listing: https://gist.github.com/ce051cb82cdbf259f05a6e2f33c206ff

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gsimplecal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/83z8ql7313f37xgf03l16syaijrfinwb-gsimplecal-2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gsimplecal https://github.com/r-ryantm/nixpkgs/archive/538e089e28958bb0ced4376961cff6c0e13f6e46.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/83z8ql7313f37xgf03l16syaijrfinwb-gsimplecal-2.2
ls -la /nix/store/83z8ql7313f37xgf03l16syaijrfinwb-gsimplecal-2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gsimplecal

Maintainer pings
cc @romildo for testing.

Result of nixpkgs-review pr 113677 run on x86_64-linux 1

1 package built:

gsimplecal


The App wont open

I don't the debug log to provide in addition.
The snap distribution install cannot launch application from both terminal and app launcher.
snap --version states
snap    2.37.4+18.04.1
snapd   2.37.4+18.04.1
series  16
ubuntu  18.04
kernel  4.18.0-17-generic

Can you describe the behaviour when it starts up? Does it open and disappear? Not appear? Etc

I would recommend that you uninstall and reinstall the snap and see if that fixes the problem. I just released an update that fixes all of the final known bugs in the app, otherwise, I need more details to try and fix the problem.

I am closing this due to inactivity. Please feel free to reopen if you have any more details to add.

Same for me, the app just does not appear either if I try to snap run or I try to launch it normally.

What operating system? Is it Ubuntu 19.04?

snapd   2.38-2.fc29
series  16
fedora  29
kernel  5.0.7-200.fc29.x86_64

I have no clue what is causing it. Could you clone the repo and start it by following the 'Developing' guide in the README and see if it gives you errors in the console when starting.

Also, I get no errors if I run the snap from a standard user but I get this if I try to run it as an admin user: snap run electronplayer
2019/04/28 12:59:47.994380 cmd_run.go:885: WARNING: cannot start document portal: dial unix /run/user/1001/bus: connect: permission denied
mkdir: cannot create directory '/run/user/1000': Permission denied
No protocol specified
I don't know if this can help you.

Does this same error happen for other snaps?

That looks like a snap/Linux issue and not this project (but I could be wrong).

No I this error only happens for this snap.
With the dev guide the application works, it's very inconvenient to use though but I will try to find a workaround.

Can you try the AppImage? It can be downloaded from the Github releases.

the AppImage works too

I don't really know how to proceed as this seems to be a Linux or snap related issue, not this project. I checked the issues for the build system used by this project (electron-builder) and saw nothing that matched this issue.

Kept you waiting. Should have checked at the repo sooner.A Ubuntu distro-upgrade resolved the issue.


v1/balance is retired, please use GET /fapi/v2/balance

Describe the bug
Hello, while getting futures account balance, get this error: APIError(code=-5000): GET /fapi/v1/balance is retired, please use GET /fapi/v2/balance

i also start facing the same error since a day ago

This PR is solving this problem.

got the same error


Verilator simulation utility: Make it easier to use generated toplevel class

Currently, we generate a toplevel class (I'll call it topname here), inheriting from the Verilator-generated toplevel class (V*), and from the VerilatedToplevel abstract class. This allows us to pass around pointers to VerilatedToplevel whenever we need any toplevel, e.g. to call eval() on.
                      topname
                   /          \
         VerilatedTopevel      Vtopname
           public eval()   public: clk_i, rst_ni, etc.
                           public eval(), etc.

We now want to access the members of Vtopname from a pointer to VerilatedToplevel. That's achievable by casting VerilatedToplevel* to topname*, and then simply accessing the inherited members:
void dosomething(VerilatedToplevel* dut) {
  dynamic_cast<topname*>(dut)->clk_i = 1;
}

Doing this cast requires type information for topname to be available, i.e. it requires including the corresponding header file in the compilation unit.
Previously, including verilated_toplevel.h wasn't sufficient: the class topname was only available when the VERILATED_TOPLEVEL() macro was called.
With this PR, #include verilated_toplevel.h and adding -DTOPLEVEL_NAME=topname is all that is needed.
Thanks @lenary for help trying out various options to achieve this, and thanks to the C preprocessor for its unlimited supply of magic.
Side notes:

VM_TRACE is always defined as 1 or 0 by Verilator, so we can use it directly in the assert.
The alternative approach we tried out earlier is available at https://github.com/imphil/ibex/commit/51e59dfe0ef1752b0bc56eecf7b5617264e3f2d6. It essentially does the same thing, but additionally changes the class hierarchy to have VerilatedToplevel at the top. I didn't follow through with that once since it's more intrusive, and I don't like the idea of a class of a given name (VerilatedToplevel) having different members available depending on how it's compiled.

Thanks for your comments @lenary! I've updated the code as discussed, including a change to dut() to return a reference instead of a pointer.

Updated after discussion, also changed TOPLEVEL_NAME::name() to use STR_AND_EXPAND instead of STR, otherwise expansion wasn't done and name() was always TOPLEVEL_NAME.


Proposal feed not displaying for "Approvals" and "Discarded"

This is a Bug Report
:tophat: Description
For bug reports:

What went wrong?
On the side menu in the proposals section one can access to "Votable" proposals, "Approvals" proposals and "Discarded" proposals. For now only "Votable" display proposals in the feed.
What did you expect should have happened?
I'd expect for proposals which voting dates have passed to show in "Approvals" if they received more "Yes" votes and to show in "Discarded" if they've received more "No" votes.

Related issue :
#61
:clipboard: Additional Data

Sovereign deployment where you found the issue: http://alpha.democracy.earth/

Browser & version: Chrome Version 60.0.3112.90

Not longer relevant since always on refactoring.


Usage Documentation / Unit Test  / Working example for Widgets?

Is there any usage documentation or working examples for the widgets?  Specifically, I'm looking for information pertaining to the multi field panel.
Thanks!

@bgronek Have you checked the feature documentation page [1]? It provides a complete cq:Widget XML structure you can copy/paste into your Project. Are you looking for something else?
[1] http://adobe-consulting-services.github.io/acs-aem-commons/features/widgets.html

Thanks for the quick response!
I found my issue.  I was actually working with this example and had it mis-configured.  Thanks so much!


With regard to the betti_2 number calculation

Hi, Thanks for the great work!
Do you mind do us a favor to tell us how to use this Betti-Matching-3D to calculate the betti_2 number ?
Best regards,

Hi,
in the introduction.ipynb notebook you can find an example of how to compute the Betti numbers.
Best regards,
Nico


How to resume the computation in the colab?

I ran the computation to the 4th stage of "run BindCraft" . However, it was stopped because my computer went to sleep.
As such, I could not run the next step "consolidate and rank designs".
Is that anyway to resume the computation from where I left? Or I have to start over.
Thanks!
I am using colab pro+.

Since the data is saved on your google drive, you can just start it again and as long as it points to the same output folder it will continue doing the designs. Note, the cosolidate and rank designs part will only start automatically once sufficient number of designs have passed the filters (100 by defualt). This can take a long time depending on your target size, generally you need to generate like 500-3000 trajectories to get 100 that pass the filters. However, if less is okay for you, then you can stop the design loop cell and just run consolidate and rank designs. You can also continue any time and consolidate again, the pipeline is designed in a way that you can always generate more designs and it does not "break" anything.

Thanks for the clarification. It is very clear now that the newly found hits were stored under the project folder. We can always run the software to search the sequence universe to find potentially better hits. I know this could be a random process. But when I start a new round of run, how can the software know which space it has already searched?

Based on the filename, that's why we include the binder length and seed number which is what "roughly" determines the search space.


Results Pane should collapse to bottom of the screen

SQL Operations Studio Version: 0.23.6

Please change the behavior of the Results pane to collapse to the bottom of the screen in the same way the Messages pane collapses to the bottom of the screen when you click it.  This behavior, as opposed to the current behavior, would maximize the viewable area of the Editor (and your code).  It would also be more in-line with the behavior of SSMS where Ctrl-R will hide the query results.

@kburtram @yualan is this still a valid issue?

@sebcruz the Shift-Windows-R shortcut will toggle the results tab visibility similar to SSMS Ctrl-R.  Please let me know if that doesn't address this suggestions.

Thank you @kburtram


Check that full screen toggles are consistent with button visibility / UI togglability / visibility.

Created by mistake.


Update readme issue 141

Type of PR

[x ] Documentation changes
[ ] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

Purpose of PR
Test run of Java README and change it to be formatted consistently with the Node.js README.
Review notes
Issues Closed or Referenced
Closes #141
Closes #73
Closes #190

We should remove the app insights key from the instructions for security best practices. Just run without App Insights integration.


Use static_cast rather than reinterpret_cast whenever possible

In particular, you should use static_cast for going up or down a class hierarchy or for converting between T* and void* .
Many of the remaining uses of reinterpret_cast are for things that are "morally" part of a class hierarchy (e.g., grpc_endpoint vs mock_endpoint) but currently aren't because they are expressed in C-style. This will allow further reduction of reinterpret_cast in the future.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

Thanks for doing this Vijay! From the errors, it looks like some of the conversions weren't part of a hierarchy or void * to and fro conversions.
LGTM once it builds :)

I wasn't building Cronet until now. Hopefully this goes through now.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]      +8  +0.0%

  [ = ]       0 TOTAL       +8  +0.0%

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]      +8  +0.0%

  [ = ]       0 TOTAL       +8  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

Rebased, diff unchanged

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]      +8  +0.0%

  [ = ]       0 TOTAL       +8  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Update Startup.cs

Changed Namespace in Startup.
This is to fix an issue where the UseDotNurseInjector extension method was not showing up.
When I copied this class to a file in my project, and changed the namespace as above, then it successfully showed up as an extension method.
See this about not using framework class namespaces.
Also note that I am using this in a aspnetcore 5 project.

Firstly thank you for your contribution 👍
I'll update namespaces & add .Net 5.0 support as pre-release.
@gregoryagu
Let me descripbe why did I pick that Microsfot.Extensions.DependencyInjection before,
As I see App.Metrics uses same namespace and that makes able to use extension methods without adding any more namespace into Startup class. But I've never tried before on .Net 5.0. So I accept your PR and update version.

You can use v2.0.0-pre.1 pre-release version for .Net 5.0 until .Net 5.0 is fully supported. @gregoryagu


Add a section with notes on PRE multicast replication behavior

Also restrictions on what kinds of items can be added to multicast
groups.

@samar-abdi I don't see how in Github to add you as a reviewer, but please take a look at this and add any comments you have.


Ability to control with AppleScript or other software

Although set global shortcut key is used well, but sometimes it will be conflict or forget. I think if provide a way to controlled by other way like Raycast should be nice. I checked Raycast's API documentation, there is a way that use AppleScript control other application, maybe other similar application could access through AppleScript too.

Mis-attributed in a different commit, but I don't think we'll be addressing this so leaving it closed.


allow py 3.9 and 3.10 in setup.py

The remaining failures are due to:

No ghostscript installed -- we don't need/want it
No pdftopng installed -- we don't need it
poppler not installed -- It's installed in the argus environment so there shouldn't be any issues there.

2023-06-05T17:45:24.2280720Z FAILED tests/test_cli.py::test_cli_lattice - AssertionError: assert 1 == 0
2023-06-05T17:45:24.2281084Z  +  where 1 = <Result PDFInfoNotInstalledError('Unable to get page count. Is poppler installed and in PATH?')>.exit_code
2023-06-05T17:45:24.2281374Z FAILED tests/test_cli.py::test_cli_output_format - AssertionError: Output: Found 1 tables
2023-06-05T17:45:24.2281450Z
2023-06-05T17:45:24.2281534Z assert 1 == 0
2023-06-05T17:45:24.2281855Z  +  where 1 = <Result TypeError("NDFrame.to_excel() got an unexpected keyword argument 'encoding'")>.exit_code
2023-06-05T17:45:24.2282334Z FAILED tests/test_common.py::test_parsing_report - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2282740Z FAILED tests/test_common.py::test_repr_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2283059Z FAILED tests/test_common.py::test_repr_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2283518Z FAILED tests/test_common.py::test_url_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2283845Z FAILED tests/test_common.py::test_url_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2284249Z FAILED tests/test_common.py::test_pages_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2284576Z FAILED tests/test_common.py::test_pages_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2285083Z FAILED tests/test_errors.py::test_no_tables_found_logs_suppressed - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2285612Z FAILED tests/test_errors.py::test_lattice_ghostscript_deprecation_warning - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2286134Z FAILED tests/test_lattice.py::test_lattice - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2286625Z FAILED tests/test_lattice.py::test_lattice_table_rotated - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2287458Z FAILED tests/test_lattice.py::test_lattice_two_tables - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2287954Z FAILED tests/test_lattice.py::test_lattice_table_regions - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2288418Z FAILED tests/test_lattice.py::test_lattice_table_areas - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2288913Z FAILED tests/test_lattice.py::test_lattice_process_background - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2289535Z FAILED tests/test_lattice.py::test_lattice_copy_text - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2290020Z FAILED tests/test_lattice.py::test_lattice_shift_text - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2290489Z FAILED tests/test_lattice.py::test_lattice_arabic - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2290951Z FAILED tests/test_plotting.py::test_text_plot - pdf2image.exceptions.PDFInfoNotInstalledError: Unable to get page count. Is poppler installed and in PATH?
2023-06-05T17:45:24.2291396Z FAILED tests/test_plotting.py::test_lattice_contour_plot_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2291767Z FAILED tests/test_plotting.py::test_lattice_contour_plot_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2292185Z FAILED tests/test_plotting.py::test_line_plot_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2292530Z FAILED tests/test_plotting.py::test_line_plot_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2292944Z FAILED tests/test_plotting.py::test_joint_plot_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2293288Z FAILED tests/test_plotting.py::test_joint_plot_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2293686Z FAILED tests/test_plotting.py::test_grid_plot_poppler - OSError: pdftopng is not installed. You can install it using the 'pip install pdftopng' command.
2023-06-05T17:45:24.2294093Z FAILED tests/test_plotting.py::test_grid_plot_ghostscript - ModuleNotFoundError: No module named 'ghostscript'
2023-06-05T17:45:24.2294250Z ============ 29 failed, 39 passed, 8 warnings in 444.07s (0:07:24) =============


Make sure the focal location is plotted

Seems like it's excluded from the plot if outcome percentiles exclude it

resolved


fix #3929 support range sharding to broadcast sql to all actual tables

Fixes #3929
Changes proposed in this pull request:

support range sharding(SQL with ‘>’, '<' and between...and...)

We need to discuss this change:

For standard sharding strategy, user need config precise algorithm (for =, IN) and range algorithm (for BETWEEN AND, <, >,  >=, <=). If user do not config range algorithm, the BETWEEN should query all data nodes, that correct;
For inline sharding strategy, user only can config precise algorithm via inline expression, and cannot config range algorithm. So throw exception when SQL contains BETWEEN may better than query all data nodes.

I found this error is puzzle for me in this case in past 3 weeks.
There is a sharding table named 'test' with 4 actual tables with sharding key is 'id' column, then we will try proxy with:

1.select * from test
2.select * from test where id=102
3.select * from test where id>102
4.select * from test where id>102 and id<104
5.select * from test where id<>102
6.select * from test where id!=102
7.select * from test where id between 102 and 104
8.select * from test where id in (102, 104)
9.select * from test where id not in (102, 104)
10.select * from test where id>102 or id<102

Executing these No. 3\4\7\10 SQL will occur the same exception：
[2020-01-12 14:01:13] [C1000][10002] 2Unknown exception: [Inline strategy cannot support range sharding.]

When I read incubator-shardingsphere/sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/inline/InlineShardingStrategy.java, we can learn InlineShardingStrategy isn't support Range query:
Preconditions.checkState(shardingValue instanceof ListRouteValue, "Inline strategy cannot support range sharding.");

But the puzzle is: the No.10 SQL(can't executed) is equals with the No.5(executed correctly), the I wanna ask why and how to support range query in sharding strategy？
Aside from performance considerations, we can find the most effective way to directly support this feature by broadcasting the whole Range query to all sharding db/tables，just like  ‘<>’ operator.
Then we can let it work well and optimized later，we can insert here one line to broadcasting sql：
if (shardingValue instanceof RangeRouteValue) {
            return availableTargetNames;
        }

Then the No.3\4\7\10 SQL will be executed correctly.
Related PR： https://github.com/apache/incubator-shardingsphere/pull/3945
------------above from issue 3929 ----------
PS:  this two sql is supported now:

"select * from test where id<>102"
"select * from test where id not in (102, 104)"

I guess they're also range query and have a lower performance than the condition "id>102".

We can consider about add a new prop key to let user define whether full query for range query or throw exception.


Decide on involvement from One Login (contribution?)

What
One Login have a Header component with Navigation that is already organised with all domain-level items contained within the black bar and all service-level items will be contained within the grey bar.
Why
It reduces duplication of effort if we can upstream their component into our codebase.
Done when

[ ] met with one login to determine what stage they are at with their header, capacity etc.
[ ] get a sense of how this works normally from other folks on the team.
[ ] delegate roles and responsibilities with the contributor, for example, who organises testing etc.

Meeting being set up for 14 May

Notes from the conversation in Google Docs


Preview on Hover: Not showing the correct size of a FrankerFaceZ custom mod badge + preview of vip, regular moderator, and broadcaster badge not appearing

Describe the bug
The Preview on Hover feature is not displaying the correct size preview for custom FrankerFaceZ moderator badges. also after initially opening this issue i have noticed that the preview for the Broadcaster badge and the VIP badge aren't showing up
To Reproduce
Go to settings turn on Preview on Hover and then go to a channel that has a custom FrankerFaceZ moderator badge larger than 18x18 for example Trihex
Expected behavior
The Preview on Hover would show the correct size preview of the custom FrankerFaceZ moderator badge
Screenshots
image of preview viewed on twitch website:
image of preview on the latest nightly:
image of preview of VIP badge on the latest nightly:
image of preview of Broadcaster badge on the latest nightly:
image of preview of regular Moderator badge on the latest nightly:
Chatterino version
2.1.4-beta-1 (03.09.2019 9ee286f)

Currently looking into fetching the FFZ mod badge more intelligently

#1293 should solve the issue of the FFZ mod badges not scaling properly.
For the other badges (VIP, Broadcaster, Moderator) we just need to make them into BadgeElements instead of ImageElements for them to be "hoverable".

Can confirm, broken on 2.1.4 ce56653e. This happens also with the Twitch Prime Subscriber badge.

can;t reproduce


Racon cannot work with duplucates in paf file

I have aligned contigs to longreads using Minimap2 and generated the paf file. I am trying to use racon to get a consensus of these.
The command I am using:
./racon PA_hifi.fa minimapConToHiFimapped_PA.paf minia_contigs_Pseudomonas.contigs.fa
and the error I am getting is:
[racon::Polisher::initialize] loaded target sequences 0.059568 s
[racon::Polisher::initialize] error: duplicate sequence 0 with unequal data
I know that minimap2 gives more than one position for a particular contig. Is that the reason I am getting this error?
But I am also having the same error with mashmap alignment where it is giving me one hit. I have checked by grep if my files have any duplicate sequences or not which it does not.

Hello,
do files PA_hifi.fa and minia_contigs_Pseudomonas.contigs.fa have a sequence with the same name but different data? Racon has error correction mode for which we included a check that if a sequence name appears in both files it should have the same length (which should imply the same contents).
Best regards,
Robert


WMAgent docker image running with old VOMS servers

Impact of the new feature
WMAgent (and potentially every single WM image deployed to kubernetes)
Is your feature request related to a problem? Please describe.
While deploying/running WMAgent 2.3.4rc12 container, the startup failed because it could not communicate with any of the VOMS servers. Despite running these containers in Alma9, which has the correct VOMS configuration, it turns out our Debian-based image for WMAgent is outdated (no surprise):
(WMAgent-2.3.4rc12) [xxx@vocms***:current]$ ls /etc/vomses/
cms-lcg-voms2.cern.ch  cms-voms2.cern.ch

This ticket is similar to https://github.com/dmwm/WMCore/issues/11997, but hopefully this one can be less invasive and we only update the VOMS package.
NOTE that those old VOMS servers have been disabled today, which means our WMAgent containers are all going to fail to renew the user proxy, so we better fix this before the weekend.
Describe the solution you'd like
We need to update the voms package in the WMAgent docker image such that it points to one of the new server endpoints (perhaps the same as the Alma9 host?).
My recommendation is to update the minimum amount of system packages with this update, such that we have high confidence in pushing the upcoming new release to production without any major validation.
Describe alternatives you've considered
We probably need to fetch the very latest stable image for python3.8, which will likely come with many package updates and potentially voms too. That should be left for the next WMAgent cycle though, if possible. This ticket is meant to track that: https://github.com/dmwm/WMCore/issues/11997
Or yet another alternative would be to mount /etc/vomses/ from the host to the container. That is likely the simplest solution.
Additional context
None

This issue has been fixed by https://github.com/dmwm/CMSKubernetes/pull/1518
Next, I am going to cut the final release under 2.3.4 and push it in in production. Thanks for following this up, Andrea!


Integration with NestJS

How can we integrate the UI to nestjs project where queues are alreay created and maanged by @nest/bull package?

Hi @piby180
This is how you integrate with nestjs:

https://github.com/iam4x/bobarr/blob/master/packages/api/src/main.ts#L11
https://github.com/iam4x/bobarr/blob/master/packages/api/src/modules/jobs/jobs.service.ts#L32-L39

You add bull-board directly to the express app returned from nestjs and register your queues in one service where you inject all the queues you want to visualize.

Thanks a lot :)


Requested changes after NECC meeting

[x] Ignore the CO FE values in the results tab if they are >100. Another possibility would be to ignore them if CO is used as feed gas.
[x] Read the excel successfully if thermocouple data is missing. If the Thermocouple is not measured then we should still read the results data and not stop with an error.
[x] Check name of NECC Electrode (always ends with .archive.json?)
[ ] Most important things to filter for explore view: Current, Voltage, FE (for experimental properties the user defined quantities are ok)
[ ] Wait for Sid to check/adjust names of potentiostat and thermocouple data; possibly adjust some column names
[x] Discuss possibility of group account. The group would like to have something like a superuser view where everyone can compare with everyone else's data. Should they share with everyone every time? What happens when new person joins team? Latest idea: Create an account with group's email and always share upload with this account. If you want to compare with others you log in with groups email. You can still see what you uploaded because you only upload data from personal account.

I moved the bigger open todos to https://github.com/nomad-hzb/nomad-chemical-energy/issues/14 to close this issue


New styles for RSGButton, Label and Box.

List of what this pull request aims to cover.

[x] Add new styles and features to existing components.
[ ] Add new examples for the changed components.

New styles applied to:

[x] RSGButton
[x] RSGLabel
[x] RSGBox

Changes require major versioning bump to rsg-components due to:

Change of styling in certain components.
Change to their respective APIs.

This commit is actually copy of #4 It's because I merged #4 unintentionally... After that fixed the mess in the branches, but there isn't way to reopen or delete #4 and now we're here.
For earlier reviews, comments & others please read #4, too.

Don't bump version numbers in PRs!

I see you fixed some of my inefficiencies in RSGLabel, yes, I did make some mistakes but.. why did you replace it with something more inefficient? Instead of an arrow function, you could simply assign it to a string. I've done so in my new commit.
The wiki will need a rewrite of certain parts after this indeed.

Oh wow, and your implementation didn't work either.

@retrixe OH, Yeah, sorry.

Are you done with RSGLabel and Box?
There's a bug with RSGBox I'm filing so if this could be sorted out in this PR, would be great.

DUDE!
THEY'RE GONE!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@retrixe What????

The standard code style and everything is gone from master and is now here..
On Aug 20, 2017 4:04 PM, "Radi Cho"<EMAIL_ADDRESS>wrote:

@retrixe https://github.com/retrixe What????
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RSG-Group/rsg-components/pull/5#issuecomment-323576784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGkN3Gep4Cs5eP8c3UhFoJBjkykWqFFKks5saAvGgaJpZM4O7Qc3
.

Any issues have been resolved via talks, progress continues.

@retrixe Please review the PR now

View this video: https://youtu.be/x2ziU3-cL44


Add API parity stubs for UDP sockets/TCP streams

These are no-ops in turmoil (AFAICT, based on patterns in our tests), but having these available minimizes the amount of caller code that needs to change

https://docs.rs/tokio/latest/tokio/net/struct.TcpStream.html#method.set_nodelay
https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.join_multicast_v6
https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#method.set_multicast_loop_v6

Done


services/rootfs: return grpc code on existence

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM


Small fix for faster TryIndirectTypeLookup

The function was doing really silly things if you had more than one
assembly in the project. This removed over 10MB of allocations on our
game.

Thanks!


Fix/v10.x

In Laravel 10.x, the flow of dispatch helper function changed a bit and lucid wont be working on it anymore. To solve it, let me create this PR.

run method of Lucid\Bus\UnitDispatcher.php &
serve method of Lucid\Bus\ServesFeature.php

will now be using dispatchSync() not the dispatch() that lucid used previously.

And I have noticed that we cannot run the queued job of lucid as follow.
$this->runInQueue(new SomeClass($arguments)) due to the following implementation
public function runInQueue($unit, array $arguments = [], $queue = 'default')
{
$reflection = new ReflectionClass($unit);
$instance = $reflection->newInstanceArgs($arguments);
$instance->onQueue((string) $queue);
  return $this->dispatch($instance);

}
The parameter from the passed object is not passed again and being ignored here.  I will soon create another PR to solve that problem as well.

https://github.com/lucidarch/lucid/pull/51


Rest Features

This pull request adds some functionality concerning rests:

Added Rest attribute is hidden for rests that should not be visible, i.e. not compiled in export.
Created make_rest_features equivalent to make_note_features
Included staff flag in note_array_from_part, rest_array_from_part, ensure_notearray, ensure_rest_array, note_array_from_part_list, note_array_from_note_list, rest_array_from_part_list, rest_array_from_rest_list. None staff value is initialized to 0.

Codecov Report

Merging #113 (3910602) into develop (0395ca5) will decrease coverage by 0.36%.
The diff coverage is 32.30%.

@@             Coverage Diff             @@
##           develop     #113      +/-   ##
===========================================
- Coverage    77.80%   77.44%   -0.37%
===========================================
  Files           53       53
  Lines         8855     8907      +52
===========================================
+ Hits          6890     6898       +8
- Misses        1965     2009      +44

Impacted Files
Coverage Δ

partitura/musicanalysis/note_features.py
69.45% <17.64%> (-8.49%)
:arrow_down:

partitura/utils/music.py
58.55% <75.00%> (+0.17%)
:arrow_up:

partitura/io/exportmusicxml.py
70.74% <100.00%> (+0.05%)
:arrow_up:

partitura/musicanalysis/__init__.py
100.00% <100.00%> (ø)

partitura/score.py
78.59% <100.00%> (+0.01%)
:arrow_up:

tests/test_rest_array.py
96.66% <100.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0395ca5...3910602. Read the comment docs.

This PR adds hidden attribute for rests and rest_features equivalent to note_features.


"/$value" for submodel URL is missing for 24.03 version of IRS

Description
Fetching of submodels is not working because the URL is built wrongly.
We need to backport/cherry pick a bugfix for 24.03 (4.5.2) https://github.com/eclipse-tractusx/item-relationship-service/commit/cfc065c408534ef7eefd3652f82fd1a10b0ae867

Current behaviour
The issue is that the IRS does not append the “/$value” suffix to the URL like it is described in the standard
Expected behavior

Append the “/$value” suffix to the URL like in the Bugfix cfc065c408534ef7eefd3652f82fd1a10b0ae867

Steps to reproduce the Bug

Let IRS fetch any submodel and you will see that it tries to reach the URL without the suffix.

@mkanal
Please prioritize this bug.
@poojapatel23 will work on the fix during my absence in the next days
@ds-jhartmann

Against which branch should we create the PR?
Is there a specific process to create the tag after the merge? Are we allowed/permitted to do that?

@rogocof the branch should be created off of this tag https://github.com/eclipse-tractusx/item-relationship-service/tree/4.5.2
The release process is described here, but you require eclipse-committer status to create tags and merge PRs.
I can do that once the changes are prepared

Thanks @ds-jhartmann
@poojapatel23 do you need more information to prepare the fix?

IRS is released with the back-ported fix
https://github.com/eclipse-tractusx/item-relationship-service/releases/tag/irs-helm-6.14.3
https://github.com/eclipse-tractusx/item-relationship-service/releases/tag/4.5.3


minor suggestions

@jmhauck  can you tell me more about these suggestions? Looks like the loop through the sources is removed?

@kellyhutchins it was a redundant set of loops though the sources. Still have one pass through the sources but it checks both source types. Won't have all that many sources so two passes vs one won't change much.

@jmhauck  ah got it - makes much more sense this morning instead of late last night :) I'm going to approve this one but let's hold off on merging until post-release/patch. We'll want to test it in all the apps just to verify that everything is ok

@jmhauck @kellyhutchins - just saw this in the PR queue. Do you guys think this is good to merge now?

Looks like this one was resolved


changeowner and withdraw need to pass parameters

Passing parameters for serialization throws an exception

golang withdraw

golang changeowner

Could you please explain what is the issue?

How do I pass params parameters


[Unity][Dlight] GeMV rule skip cases of "outer dim being grouped"

Prior to this PR, the GeMV contains an assumption that "the grouped dimension of the largest tensor in GeMV must has the same iter type as the innermost dimension", which is enforced by an assertion.
Since AutoGPTQ quantization only supports KN GeMV layout, the decode-GeMV generated under the AutoGPTQ quantization has the pattern where the reduction dimension is not the innermost and is grouped. This pattern does not follow the assersion above and thus an assertion error will be thrown.
This PR updates the logic to skip transforming such cases, instead of asserting the assumption. One real AutoGPTQ decode-GeMV workload is added as a test case for future awareness.

if we don't know how the memory access can be friendly if we use block reduction, maybe we can manually do transpose when loading the params from gptq, then we can enhance the performance of dlight default schedule ?

if we don't know how the memory access can be friendly if we use block reduction on kxn layout, maybe we can manually do transpose when loading the params from gptq, then we can enhance the performance of dlight default schedule ?

Good point. I’m not sure how the autogptq decode-GeMV can benefit from the GeMV dlight rule. Perhaps we can try out as as follow up. In the meantime, we need to remove the assertion here in the PR to ensure robustness.


polkadot and kusama adapte

adapte polkadot and kusama network
clean API code in the util directory

waiting for darwinia.js update


date format "DD, MM d, yy"    Thursday, January 7, 2021   is not working

date format "DD, MM d, yy"    Thursday, January 7, 2021   is not working
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This plugin only supports some limit format tokens, check out the format option for details: https://github.com/fengyuanchen/datepicker#format

This plugin only supports some limit format tokens, check out the format option for details: https://github.com/fengyuanchen/datepicker#format


Feat: implement DeleteGroupDialog

Overview

Implement DeleteGroupConfirmDialog component.
Changes

Wrap GroupCardDropdownMenu with DialogRoot, and put DeleteGroupConfirmDialog outside of drop down menu because if DialogRoot goes inside of GroupCardDropdownMenuContent, closing the dropdown will also close the dialog.
Add DeleteGroupConfirmDialog component.
Add trigger to open the dialog in GroupCardDropdownMenuContent.

Review points

The trigger is in GroupCardDropdownMenuContent, content is in GroupCardDropdownMenu. Is this component structure complexity okay? If not, not using DialogTrigger to open the dialog can be an another solution.

Screen Captures

https://github.com/nishiki-tech/nishiki-frontend/assets/99339182/bf0f42f3-8db6-4ebe-b508-0294f2940d79
Assignee Checklist:

[x] The naming convention of the PR title is correct (See the comment at the top of this template)
[x] The base branch is correct (See: Types of Branches)
[x] The branch name follows the Branch Naming Conventions
[x] The correct assignees and reviewers have been designated for this PR
[x] The coding style follows the Coding Style Guide
[x] All the related issues are associated with this PR
[x] All criteria in the associated issues are met (please tick the checkboxes)
[x] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[ ] Double-check the "Assignee Checklist"
[x] The code follows the generic best practices and our Coding Style Guide
[ ] The code is well-commented and easy to understand
[x] The UI changes accurately reflect the provided design

@nick-y-ito
Thank you for your review!
I basically followed the way it's implemented in DeleteFoodDialog, and this PR stays focusing on only UI.
Please take a look at the change when you have time 🙏

@nick-y-ito
Thank you for your review!

the dropdown menu should be closed together when closing the dialog

I just forgot to implement the functionality in this PR, so I included it in commit #9c5e7d2.

I am sorry, I found an error in the console after I approved. That says:
app-index.js:35 Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
Could you inspect it, please?

Sorry that I didn't notice the warning in the first place. I should've checked that.
I fixed the issue in the commit #00e3444.
It was because of unnecessary asChild in DropdownMenuItem.
Please kindly take a look at them again on your convenience 🙏

@kanta1207 Thank you for updating!
I think the dropdown menu should also be closed when after the [ Delete ] button is clicked.
There is another problem with this behavior, though... #269

Thank you for your review!
I fixed to close dropdown on closing dialog with delete button clicked! Please take a look again 🙏


Client certificate authentication

This PR aims to add client certificate authentication, in relation to this issue: https://github.com/IBM-Swift/SwiftyRequest/issues/33#event-1731532028

[ :tada:]


SASS paths and output style

Although I've only been trying out Bourbon for a few days, I like what I've seen so far. However, when it comes to SASS and building the site (I'm using Jekyll, btw) I think I'm missing something...
In Compass, resource paths and style formatting gets declared in a config.rb file. Set it once, and you really don't need to look at it again. Really simple.
How does Bourbon deal with these options? Having to run sass --watch inside of each directory seems clunky. I'd much rather make a small bash script that chains the commands together. With the path specified, it should just be able to run from the project root, no?
Ideally, I would like to have 1 .scss file which imports all partials and outputs a compressed format with all line breaks and extra spaces removed.
I know there are several projects which implement Bourbon and Neat as Compass extensions, but that looks kind of weird and I'm not sold on it working long-term...

Bourbon is just a library of Sass partials. Just import it in your main Sass manifest and you can start using it.
Jekyll comes with built-in support for Sass, so when you run jekyll serve it should be continually compiling Sass for you. It has some options for output style, too.

@tysongach,
Thanks for the quick reply, it figures that Jekyll has configuration options for this (and I've never seen them :smile:. Although I've contributed to Jekyll (and its docs) in the past, this is one area I didn't bother with. Now that I'm using SASS in more projects, it's definitely worth a read.
I first started trying to get Bourbon up and running yesterday and kept running into conflicts between the file structure that Bourbon expects and what you get out of jekyll new, hence the confusion.


Server-side apis get all stylesheet at once (maybe it should only get the "current")

This isn't a big issue and more like an optimisation, where we could only append to the stylesheet the current classNames being used.
We could introduce Stylesheet.collect to analyse the html as a string, and compare the classnames.
Making sure the "critical" is the required to be appended to the resultant HTML.
let stylesheet = Stylesheet.get_all();
let html = ReactDOMServer.renderToString(<App />);
let (critical, other) = Stylesheet.collect(html, css);

Taken from: https://github.com/callstack/linaria/blob/master/docs/API.md#collecthtml-string-css-string--string
The API might change, but the solution should look quite similar

Emotion have an implementation as well (https://emotion.sh/docs/ssr#on-server) maybe we can port this?

I didn't want to jump into this issue since I wanted to do first https://github.com/davesnx/styled-ppx/issues/433 and then see if this is actually a problem? Since If we just generate a static file, we could append prefix per module or other techniques where this problems goes away. WDYT?


Add CloseClaimCommand and CloseClaimCommandParser

Adding the CloseClaimCommand and CloseClaimCommandParser to support the close claim feature as listed in #85 and #88.
Currently the test coverage is 0%, but this will be fixed by the tests that will be opened in a separate PR.

Will merge as tests will be written later.


cwl_engine management of arrays of inputs

There is an issue with workflow https://raw.githubusercontent.com/kids-first/kf-alignment-workflow/v2.7.3/workflows/kfdrc_alignment_wf.cwl , leading to error message
inputdeclarations.yaml:2:1:  * the `input_bam_list` field is not valid because value is a CommentedMap, expected null or array of <File>

due input_bam_list not being properly represented.
cwl_engine.CWLWorkflowEngine generates file inputdeclarations.yaml before calling cwltool, in order to tell it the input parameters and where to find the files.
That yaml is created by createYAMLFile https://github.com/inab/WfExS-backend/blob/3da5db236f87fbb0d1daea4f084539f3cac8d355/wfexs_backend/cwl_engine.py#L492-L510
which depends on the output from executionInputs https://github.com/inab/WfExS-backend/blob/3da5db236f87fbb0d1daea4f084539f3cac8d355/wfexs_backend/cwl_engine.py#L512-L550

added cases to manage arrays of files and strings in executionInputs:
https://github.com/inab/WfExS-backend/blob/92d8dd11f030f4436d609eccb2c13934c450d8da/wfexs_backend/cwl_engine.py#L516-L566

Fixed along several commits. The issue arose when some input or output has more than one possible type. These cases are quite common in CWL, so it needed several refinements. Commits d3363a12df1fafc77ac3441daeb446a103c8ea16 , 2062e81a17dafa78eefc13fae24dbf8095d39b6f , bc0da5f47d094c90775486e90ea9223303bb23fc , 3a75c970a091b1010912ac35b204f04f802b894b , 0f4c029d62bfdf0126a8171efd81861feaf1199a led to the proper handling of this use case


style(frontend): remove unnecessary margin bottom in info

Motivation
See screenshots
Changes

span instead of p

Screenshots
Before

After

Duplicated by #2668.


hack/update-codegen.sh uses deprecated scripts

What would you like to be cleaned:
When running make generate, this message shows up:
WARNING: generate-groups.sh is deprecated.
WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead.

WARNING: generate-internal-groups.sh is deprecated.
WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead.

Why is this needed:
Keep kueue building

I think https://github.com/kubernetes-sigs/kueue/pull/1151/files should resolve this

Maybe this ticket is a duplicate of https://github.com/kubernetes-sigs/kueue/issues/1134

Maybe this ticket is a duplicate of https://github.com/kubernetes-sigs/kueue/issues/1134

Yes, that's right.
/close


bbox-services: init at 0.6.0

Description of changes
Add bbox services package.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Build is currently failing on
   Compiling mbtiles v0.9.1
error: set `DATABASE_URL` to use query macros online, or run `cargo sqlx prepare` to update the query cache
   --> /build/bbox-services-0.6.0-vendor.tar.gz/mbtiles/src/mbtiles.rs:135:21
    |
135 |         let query = query! {"SELECT tile_data from tiles where zoom_level = ? AND tile_column = ? AND tile_row = ?", z, x, y};
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `$crate::sqlx_macros::expand_query` which comes from the expansion of the macro `query` (in Nightly builds, run with -Z macro-backtrace for more info)

I don't see, why the of the mbtiles package is failing. Which build command is executed? There are mutliple binaries in the bbox package. If you build in the bbox-server subdirectory, all standard services are included.

Which build command is executed?

cargo build -j 32 --target x86_64-unknown-linux-gnu --offline --profile release

is used .

The build is successful on my machine and also on Github CI and in a Docker env. I'll open an issue in the mbtiles repo, maybe they have an idea.

Just in case, here is my attempt to package https://github.com/sikmir/nur-packages/blob/master/pkgs/geospatial/bbox/default.nix

@sikmir , thanks.
I tried to pick some ideas from your package (setting PROTOC var or setting cargoBuildFlags), but none of them helped. The error message is the same.

Can you try setting SQLX_OFFLINE=true according to https://github.com/launchbadge/sqlx/blob/main/sqlx-cli/README.md#force-building-in-offline-mode ? (Current bbox version is 0.6.1, btw)

Another thought. Maybe the .sqlx directory required for offline build got lost?

(Current bbox version is 0.6.1, btw)

Updated to 0.6.1. Thanks.

Can you try setting SQLX_OFFLINE=true according to https://github.com/launchbadge/sqlx/blob/main/sqlx-
cli/README.md#force-building-in-offline-mode ?

Setting this variable resulted in little change of error message:
error: `SQLX_OFFLINE=true` but there is no cached data for this query, run `cargo sqlx prepare` to update the query cache or unset `SQLX_OFFLINE`
   --> /build/bbox-services-0.6.1-vendor.tar.gz/mbtiles/src/mbtiles.rs:135:21

looks like we might be missing .sqlx directory.

Looks like the source directory /build/bbox-services-0.6.1-vendor.tar.gz/mbtiles/.sqlx/ is missing. Does the nixpkg toolchain somehow remove dot-files/directories from the tar.gz?

FYI: Dotfiles should be allowed as of

https://github.com/NixOS/nix/pull/9867


Bump antlr4 from 4.8 to 4.9.3

Why are the changes needed?

This PR aims to bump antlr4 from 4.8 to 4.9.3.
Version 4.8 was released on Jan 21, 2020, It's been nearly three years, and there have been a lot of bug fixes during that time, see more at change list.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Thanks, merging to master


CI: Install Rust manually

Install Rust manually in the CI, instead of relying on actions-rs/toolchain.
See https://github.com/knurling-rs/probe-run/issues/338.

bors r+


Issue with collectLocations

So we've hit a bug in some part of the language-server. I found what's triggering it and I have a small reproduction. When the bug happens, the project is not loaded and the rest of the IDE experience is poorly degraded.
The cause is the following NPE:
[11:47:51] java.lang.NullPointerException: Cannot invoke "org.eclipse.lsp4j.Location.getRange()" because "<local6>" is null
	at software.amazon.smithy.lsp.ext.SmithyProject.collectMemberLocations(SmithyProject.java:274)
	at software.amazon.smithy.lsp.ext.SmithyProject.collectLocations(SmithyProject.java:239)
	at software.amazon.smithy.lsp.ext.SmithyProject.lambda$new$0(SmithyProject.java:70)
	at java.base/java.util.Optional.ifPresent(Optional.java:178)
	at software.amazon.smithy.lsp.ext.SmithyProject.<init>(SmithyProject.java:70)
	at software.amazon.smithy.lsp.ext.SmithyProject.load(SmithyProject.java:174)
	at software.amazon.smithy.lsp.ext.SmithyProject.load(SmithyProject.java:145)

This is rather explicit: we pull something out of a map, it can be null if the thing is not in the map, but we don't check for that, so it blows up.
The quick fix is to do a null check. The right fix is to find why this happens. So I went on a hunt.
Given the following:
.
├── core
│   └── common.smithy
└── test
    └── test.smithy

With the following content:
> cat core/common.smithy
$version: "2"

namespace core

boolean IsTestInput

@mixin
structure HasIsTestParam {
  isTest: IsTestInput = false
}

> cat test/test.smithy
$version: "2"

namespace test

use core#HasIsTestParam

service AService {
  version: "1",
  operations: [SomeOp]
}
operation SomeOp {
  input: SomeOpInput
}

structure SomeOpInput with [HasIsTestParam] {
  @required
  body: String
}

apply SomeOpInput$isTest @documentation("Some documentation")

This specific workspace will blow up the LSP w/ the error above.
Everything is fine if I comment the following line: apply SomeOpInput$isTest @documentation("Some doc")
Also, everything is fine if I pull the shapes from core into test (placing the shapes in the same file / same namespace).

While debugging, I tweaked the implementation of LspLog a little bit with two improvements:

when we fill the buffer to eventually write to the file, we duplicate the timestamp
when doing println(exception)

it would be great if the whole stack trace was flushed in the file, it's much easier to find the cause of an issue.
Do you want a PR for that?

That PR would be welcome.


Add Contributing link to readme

Provide access to the CONTRIBUTING.md file from the README.

Thanks for that - will merge shortly!

Merged.  Thank you very much.

Welcome sir.


[button]: Primary button shows loading spinner twice when changing other attributes

Detailed description
The loading spinner (baloise logo) is shown twice, at least for the primary button.

I think this is caused by the following modification:
element.addEventListener("click", function () {
          element.loading = "true";
          setTimeout(function () {
            element.disabled = "true";
          }, 100);
        });

It seams that if element.disabled = "true"; is executed, that an additional spinner is added.
If I toggle disabled on the button it will even add more spinners.

I think it has something to do with the color as primary, danger, success, warning have the issue but the other button colors not.

will be done with #998


Incorrect code generation when assigning a generated function to a function

The first param gets the contents of the whole function:
var x = {
  /**
   * [* description]
   * @param {[type]} aWindow)      {    if (!aWindow) {      throw new TypeError('Invalid input. Expected xul browser.');    }    if (this.isXULWindow(aWindow)) {      return yield this._awaitFetchManifest(aWindow);    }    return this._fetchManifest(aWindow);      } [description]
   * @yield {[type]} [description]
   */
  obtainManifest: async(function* (aWindow) {
    if (!aWindow) {
      throw new TypeError('Invalid input. Expected xul browser.');
    }
    if (this.isXULWindow(aWindow)) {
      return yield this._awaitFetchManifest(aWindow);
    }
    return this._fetchManifest(aWindow);
    //'DOM:ManifestObtainer:Obtain'
  })
}

Documenting generated functions is a difficult one, since it's very difficult to statically tell what the result will be (especially without using a proper parser). If we searched the arguments list for functions and assumed that a function with the same signature was returned, then there'd be other edge cases where it's equally broken in the other direction, eg:
// (what should the docs be here?)
var x = doAsyncThing(function callback(err, res) {
});

Of course, the current behaviour is pretty terrible, I'm not denying that...

This is an edge case issue with other languages too.  See https://github.com/spadgos/sublime-jsdocs/issues/377

Yes, I completely understand. Also, my use is somewhat strange, in that I'm calling a function to get a function that will serve as a pollyfill for async function(){} - and expecting @params, etc. to be generated from that is a bit of a stretch.
I'm ok if you WONTFIX this - but just wanted to bring it to your attention. Thanks for this awesome tool - can't live without it :)
On June 15, 2015 at 5:07:58 AM, Nick Fisher<EMAIL_ADDRESS>wrote:

Documenting generated functions is a difficult one, since it's very difficult to statically
tell what the result will be (especially without using a proper parser). If we searched
the arguments list for functions and assumed that a function with the same signature
was returned, then there'd be other edge cases where it's equally broken in the other
direction, eg:
// (what should the docs be here?)
var x = doAsyncThing(function callback(err, res) {
});

Of course, the current behaviour is pretty terrible, I'm not denying that...

Reply to this email directly or view it on GitHub:
https://github.com/spadgos/sublime-jsdocs/issues/375#issuecomment-111986989


Adding additional settings

I would very much like to see an option where I can change the default for new tasks from having both date and time to defaulting to just date. This could be an additional option in the setting menu and then be changed on an as-needed basis when creating new tasks.

Here is my counter proposal:
Instead of adding a setting, let's get rid of the all-day checkbox altogether. My idea is to disconnect the date and time fields. At present the app automatically picks the current time (the next full hour to be precise) when you click the date field. Instead, it could only set the date, leaving the time blank until you also set a time. A new button could allow you to clear the time without clearing the date. Optionally we could utilize the clear button we already have and let it clear the time on the first tap (if there is any time value) and the date on the second tap.
In future, I'd like to take it a step further and switch to the instantpicker I've been working on for a while now. It allows you to pick all-day and date-time values conveniently in a unified picker.

On 09/16/2019 05:14 PM, Marten Gajda wrote:

Here is my counter proposal:
Instead of adding a setting, let's get rid of the all-day checkbox altogether. My idea is to disconnect the date and time fields. At present the app automatically picks the current time (the next full hour to be precise) when you click the date field. Instead, it could only set the date, leaving the time blank until you also set a time. A new button could allow you to clear the time without clearing the date. Optionally we could utilize the clear button we already have and let it clear the time on the first tap (if there is any time value) and the date on the second tap.
In future, I'd like to take it a step further and switch to the instantpicker https://github.com/dmfs/instantpicker I've been working on for a while now. It allows you to pick all-day and date-time values conveniently in a unified picker.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dmfs/opentasks/issues/845?email_source=notifications&email_token=ACODNXOJXOUMXTONR4SMCETQJ7ZNFA5CNFSM4IXEWZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62RKRQ#issuecomment-531961158, or mute the thread https://github.com/notifications/unsubscribe-auth/ACODNXNB4IQPEWOOZUOSWS3QJ7ZNFANCNFSM4IXEWZYQ.

I would like it to be as simple as possible. In 99% of tasks I create I only need/want a date field, I want the task to be full-day task with no time, nor should it default to 00:00 or something like that. This means that when the task eventually show up on some other platform (after synchronizing via my owncloud backend), such as Thunderbird, it should still be a full-day task.
I do not want to have to click more than necessary to accomplish the above...
How does this sound? Doable?


Fix for using the charset UTF-8 when reading the resources file

I'm creating this PR to solve the issue reported in #3. I was facing the same issue here but with the locale pt_BR.
[Before]

Fantastic, thanks! Will push a new version soon!


Parameter for ready() to indicate if it's called for the first time

Currently _ready() is called every time the node enters scene tree.
People tend to use _ready as a constructor, but in some situations it can be harmful since sometimes there is need to reparent node or disable it (by removing it from the scene tree for some time).
My proposition is to add additional boolean parameter to _on_ready that will indicate if this is a first ready call for given node.
Potentially related issue: https://github.com/godotengine/godot/issues/1905

It would be better actually to add something different that can achieve this easily.
I would recommend adding a 'static' keyword that works the same as C++.
This way you can  setup a flag that turns to true and skip portion of code accordingly.
This would be useful too, to count the number of scenes currently instanced by
making a static counter in the _ready().
AFAIK gdscript doesnt support globals scope in scripts (autoload is an exception).
But static variables have different scope than globals.
But if this is not gonna happen, I wonder if implementing something a kin to std::once_flag
Is feasible in GDscript. Or even something like call_once()

i think for the rare cases when you remove nodes from the scene you can add
a boolean, it's not that common to remove and readd nodes
On Sat, Jan 9, 2016 at 2:45 PM, RebelliousX<EMAIL_ADDRESS>wrote:

It would be better actually to add something different that can achieve
this easily.
I would recommend adding a 'static' keyword that works the same as C++.
This way you can setup a flag that turns to true and skip portion of code
accordingly.
This would be useful too, to count the number of scenes currently
instanced by
making a static counter in the _ready().
AFAIK gdscript doesnt support globals scope in scripts (autoload is an
exception).
But static variables have different scope than globals.
But if this is not gonna happen, I wonder if implementing something a kin
to std::once_flag
Is feasible in GDscript. Or even something like call_once()
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3290#issuecomment-170264349.

I agree, a simple boolean would suffice for this.

Well it looks my project is quite specific since it's quite common situation for me in many places. I use it to disable some functions of a scene (remove some logic-component for some time), or change behaviour (like on FSM state change), by replacing some nodes with other ones. Also other unrelated to FSM situations like ability to define what a wooden chest should drop when it's opened (my wife is adding items/weapons in a child node of chests, they are cached by chest in ready, then thrown on the floor, hero can pick them up, sometimes put in the backpack, from backpack to the hand etc). Some of the scenes in my project even serve as 'repository/prorotype factory' that stores/defines items and so we can calibrate parameters in the editor and duplicate them during runtime... (something similar to prototype factory pattern if I remember corretly).
As it seems to be to much specific for how I'm using the editor I will close the issue in a couple days if there will be no more interest in it.

I'm not sure that it is not common. It certainly depends on the workflow, since this question was raised a few times by different people. @kubecz3k's example makes the use clearer, and adding a boolean flag manually in all of the scripts seems wrong to me. You can't even use inheritance since there's no guarantee that all nodes will be of the same type.
As an alternative to the boolean parameter, there could be a _first_ready() virtual function that runs only on the first _ready().
The possible overhead of this is that the boolean flag will still have to exist and it'll be in every node, even of those that aren't making use of it.
I think the point is valid: a kind of constructor that runs when the tree below is already there. Just don't know the proper way to implement it.

maybe we could add a counter for how many times the node was added into a
scene?
On Sat, Jan 9, 2016 at 4:32 PM, George Marques<EMAIL_ADDRESS>wrote:

I'm not sure that it is not common. It certainly depends on the workflow,
since this question was raised a few times by different people. @kubecz3k
https://github.com/kubecz3k's example makes the use clearer, and adding
a boolean flag manually in all of the scripts seems wrong to me. You can't
even use inheritance since there's no guarantee that all nodes will be of
the same type.
As an alternative to the boolean parameter, there could be a
_first_ready() virtual function that runs only on the first _ready().
The possible overhead of this is that the boolean flag will still have to
exist and it'll be in every node, even of those that aren't making use of
it.
I think the point is valid: a kind of constructor that runs when the tree
below is already there. Just don't know the proper way to implement it.
—
Reply to this email directly or view it on GitHub
https://github.com/godotengine/godot/issues/3290#issuecomment-170273401.

While I do agree that a simple boolean can solve the issue, but I don't like the idea of
polluting the namespace, defining variables outside functions is really bad when projects get
bigger.
But I believe it all stands on the designing phase of the mechanics of the game you are implementing.
Each instance has its own state machine controled by a bigger state machine, how objects
interact with each other, modifying their state each frame. It gets hairy and scary with potential some hundred boolean variables and big if-else statements for the flags of the bigger state machine, saving and loading those flags when user want to resume the game at later time.

@reduz function that returns a counter would do the trick but I think it would be a good idea to give a strong hint to new users that _ready should not always be seen as an constructor. I remember my confusion many months ago when I discovered that I had bugs because _ready is called every time when node enters tree (I thought _enter_tree call was for that, and while currently I know the difference I think it might be confusing for new users).  But just like @vnen I'm not sure what is the best way to solve this issue. The idea with new _first_ready() good and bad at the same time, since for new users it might be confusing on it's own that there are two ready functions... but maybe it could be minimized by changing _first_ready to '_init_in_tree()' (since ordinary constructor is called _init()). I'm not sure maybe I'm over-thinking this, and simple counter is the best after all?

See also the related discussion in #1949.

maybe related to #2657

Isn't there an _enter_tree() function for all Nodes? So if _ready() is called every time then what's the difference from _enter_tree() function ?

I support  @kubecz3k seems like not only you have 2 redundant functions but also a really useful function like on ready is called every time you enter and re-enter the node resetting those variable.
_ready() should be called only once and should only be called if a node entered the tree which makes it different than _init() which is called at instance time and different than _enter_tree()  which is called every time you enter/re-enter the tree.
In this sense _ready() would become a "in-game constructor" function rather than a regular constructor.

At this point I personally don't use _ready function at all. I'm also not using _init() either - because inside init it's impossible to use get_node to fetch internal nodes.
Instead  I'm using following template in my scripts:
func _notification(what):
	if (what == NOTIFICATION_INSTANCED):
		#all internal initialization, you can use get_node here to get internal nodes and object will be to some degree usable even if not added yet to scene tree
		pass
	elif(what == NOTIFICATION_READY):
		#only parts that are dependent on outside world (on theparents etc/also called when reparented)
		pass

It's the only way for me to have more or less error prone code with my habit of re-parenting nodes when I need :) The only problem with this approach is lack of auto-completion for internal nodes that were fetched during INSTANCED notification.

@trollworkout: [...]but there's deff no point in instantiating variables over and over every time you add and remove the node. I can just make brand new objects for that purpose if I wanna start fresh.

While you may want something to initialize only once, sometimes you need to reinitialize stuff when entering the tree again. E.g. if you have a Bullet node and your game have a lot of bullets flying all the time, it's better performance-wise to make an object pool rather than destroying/recreating everything.
_enter_tree() does not cut it as there's no guarantee that the children are initialized. Actually, I see no real use for _enter_tree(). If it performed like _ready(), then I'd agree with the change.

@kubecz3k maybe if we add a _instanced() virtual function that runs when NOTIFICATION_INSTANCED notification arrives it would solve all problems. Also an oninstanced keyword akin to onready. Though it might be still a problem if you need info from parent nodes.

@vnen oninstanced and instanced() would be fine with me

@vnen well it's not the most straightforward solution for new people (not sure when they should learn about the difference between ready and instanced). For me personally it would be nice, since this is what I'm doing currently and I would have auto-completion thanks to this. But in the end it's not about me, and I'm not sure if there is sense to add that kind of api when no-one else is doing stuff this way :) (not sure how many people would really benefit)

This issue is addressed in #7138, but I don't think it's the right way
Not calling _ready when reinserting is confusing. In my opinion the Node class by itself has no need to expose the first insertion as a special case.
If one desires to remove and reinsert Nodes, some understanding of out-of-tree operations is required. Adjusting _ready to encourage ignoring this fundamental system will just lead to worse code.
Well written Node classes don't care how often they've been inserted or removed. They use callbacks to adjust their state, usually using _enter_tree, _ready and _exit_tree for in-tree operations and NOTIFICATION_PARENTED, _UNPARENTED and _INSTANCED to handle out-of-tree operations.
If this confuses new users, we should improve the documentation to explain that custom node state has to be cleaned up (prepared for reinsertion) in _exit_tree or NOTIFICATION_UNPARENTED if later reinsertion is desired. Also improve documentation for NOTIFICATION_INSTANCED, _PARENTED, _UNPARENTED and out-of-tree operations in general. Maybe even make some of the notifications available as callbacks
I don't think the system is so complex that we can't document and teach it but build crutches

I agree, I had just misunderstood @bojidar-bg's change in b6eab00 and thought it only addressed the double _ready() call when first initializing a node. This change should likely not have been made in the same PR as a bugfix - unless there's a strong argument for keeping it, I'd propose to revert it until it can be properly discussed.

@eska014 @akien-mga I agreed. _ready() should be called when it's enter tree again. but prevent to call _ready twice when enter tree.

Reverted b6eab00.

Closed by f3f4a11cfb9767e1d691aec431dd2f1a87a31977, since ready is called only once now (but you can use request_ready to get another one :smiley: )

For tool scripts, ready() seems to be called twice: once when adding the node in editor and once when the game runs.

@Zireael07 this is kind of inevitable, because it's added in the tree of the editor and later it is added in the tree of the game. If you want to run some code only in editor, you need to surround with an if get_tree().is_editor_hint().


[AutoPR machinelearningservices/resource-manager] chore: jsonfmt machinelearningservices

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6477

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6125


${Identifier.number}  in Fn::ForEach to get processing number

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
To summarize, I would like to get what processing number is currently on.
As an example, I want to create subnets and other resources for each AZ to support a redundant environment.
But I cannot create OutputKey with an AWS-specific parameter type,like this.
sample template 1
AWSTemplateFormatVersion: 2010-09-09
Transform: 'AWS::LanguageExtensions'
Parameters:
  paramAZs:
    Type: List<AWS::EC2::AvailabilityZone::Name>
  paramVpc:
    Type: AWS::EC2::VPC::Id
Mappings:
  mapSubnetIP:
    ap-northeast-1a:
      Subnet: <IP_ADDRESS>/24
    ap-northeast-1c:
      Subnet: <IP_ADDRESS>/24
    ap-northeast-1d:
      Subnet: <IP_ADDRESS>/24
Resources:
  'Fn::ForEach::AZs':
  - myAZ
  - !Ref paramAZs
  - 'PrivateSubnet${myAZ}':
      Type: 'AWS::EC2::Subnet'
      Properties:
        VpcId: !Ref paramVpc
        CidrBlock: !FindInMap
          - mapSubnetIP
          - !Ref myAZ
          - Subnet

This sample template will fail with this error message.
Transform AWS::LanguageExtensions failed with: OutputKey 'PrivateSubnetap-northeast-1a' should be alphanumeric.
${Identifier.number} can solve this issue, and it will be simple.
sample template 2.
AWSTemplateFormatVersion: 2010-09-09
Transform: 'AWS::LanguageExtensions'
Parameters:
  paramAZs:
    Type: List<AWS::EC2::AvailabilityZone::Name>
  paramVpc:
    Type: AWS::EC2::VPC::Id
Resources:
  Fn::ForEach::AZs:
  - myAZ
  - !Ref paramAZs
  - 'PrivateSubnet${myAZ.number}':
      Type: 'AWS::EC2::Subnet'
      Properties:
        VpcId: !Ref paramVpc
        CidrBlock: !Select
          - !Sub ${myAZ.number}
          - ["<IP_ADDRESS>/24", "<IP_ADDRESS>/24","<IP_ADDRESS>/24"]

Are you currently working around this issue?
Defining each resource separately without using ForEach.
What is the expected behavior with this new feature
In sample template 2 ,${myAZ.number} will be replaced 0,1,2 .. depend on ForEach's list.
It is simple, so no work for replacing - , _ or others for KeyName.
And, also I use ${myAZ.number} for selecting subnet from list.
I don't need to know what is ${myAZ} value (ex. ap-northeast-1a), and I can reduce Mappings section.
Additional context

Almost all the resource IDs use "-", and We cannot use "-" in Keyname. We can't use resource IDs in Fn::ForEach's list now.
All the AWS-specific parameter types use "-". so now We can't use them in Fn::ForEach ,too.
I think this can be done without much regard to the order of text transformation, so this New feature will suit  for Cfn's transform,
and it might not need so hardwork.
Minitour has also reported almost the same issue in  #140  .

Attachments
no attachment

Another workaround would be to only ask for the (last) letter of the AZ as input:
AWSTemplateFormatVersion: 2010-09-09
Transform: 'AWS::LanguageExtensions'
Parameters:
  paramAZs:
    Type: CommaDelimitedList
    Default: a,c,d
  paramVpc:
    Type: AWS::EC2::VPC::Id
Mappings:
  mapSubnetIP:
    ap-northeast-1a:
      Subnet: <IP_ADDRESS>/24
    ap-northeast-1c:
      Subnet: <IP_ADDRESS>/24
    ap-northeast-1d:
      Subnet: <IP_ADDRESS>/24
Resources:
  'Fn::ForEach::AZs':
  - myAZ
  - !Ref paramAZs
  - 'PrivateSubnet${myAZ}':
      Type: 'AWS::EC2::Subnet'
      Properties:
        VpcId: !Ref paramVpc
        CidrBlock: !FindInMap
          - mapSubnetIP
          - !Sub "${AWS::Region}${myAZ}"
          - Subnet

Thank you for your comment, benbridts.
It is a nice idea for replacing sample 1.
However, I would like the template to work dynamically and not just in some regions.
For example, sample 1 will not work for a StackSet with multiple regions, but sample 2 will work.

For example, sample 1 will not work for a StackSet with multiple regions, but sample 2 will work

You can leave out the region-specific mapping, if that is what you'd need. That way you also don't have to worry as much about how you're going to override the paramAZs parameter for each region (because in sample 2 they will have to be different for every region).
AWSTemplateFormatVersion: 2010-09-09
Transform: 'AWS::LanguageExtensions'
Parameters:
  paramAZs:
    Type: CommaDelimitedList
    Default: a,c,d
  paramVpc:
    Type: AWS::EC2::VPC::Id
Mappings:
  mapSubnetIP:
    a:
      Subnet: <IP_ADDRESS>/24
    c:
      Subnet: <IP_ADDRESS>/24
    d:
      Subnet: <IP_ADDRESS>/24
Resources:
  'Fn::ForEach::AZs':
  - myAZ
  - !Ref paramAZs
  - 'PrivateSubnet${myAZ}':
      Type: 'AWS::EC2::Subnet'
      Properties:
        VpcId: !Ref paramVpc
        CidrBlock: !FindInMap
          - mapSubnetIP
          - !Ref myAZ
          - Subnet

Thank you for your response. Got it, making index with mappings will solve such issues. Thank you for your help.
I still think that will reduce mappings and helps to keep templates simple,
but I can work around writing all-repeat-lines.


UI Improvements

Summary:

brand colors
custom chart colors
card style updates
leaflet tile z-index and grid fix

This is really goid


Minor patch

Hide bug: https://github.com/buttercomponents/butter-component-settings/issues/33 (Not a fix)
~Integrate default theme as fallback for css vars~ (Auto fallback by Inheritance)
Fix global css bug.
Fix navbar padding.

Fixes https://github.com/buttercomponents/butter-component-settings/issues/22

i don't think this is the right fix
we need to pre-load the defaultt theme.

https://github.com/butterthemes/butter-base-theme

Also not sure if this apply in chrome, but:

This method also have been seen to cause performance issue. It makes browser render page slowly than normal as it takes time to parse through it.

@xaiki I going to merge this, any regrets?

It's just css so it's safe to merge 😄 !

i feel this should be reverted =/

Yep I'll fix it!

Done ^^


  A pr contains all changes in a folder.

This change is

/approve

/lgtm


Frame didn't arrived within 5000 with RS-D435 on Ubuntu14.04

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu14.04

Kernel Version (Linux Only)
4.4.0-101-generic

SDK Version
rs2

Hi everyone, I developed a project with RealSense D435 under Qt5.9. I read the color frame and depth frame data by rs2 api default function.
The core code segment is as followed:
while(1)
{
    rs2::frameset frameset = pipeline.wait_for_frames();
    rs2::frame depth_frame = frameset.get_depth_frame();

    matDepth = cv::Mat(cv::Size(640,480), CV_16UC1, (void*)depth_frame.get_data());

    cv::imshow("depth img", matDepth);
    cv::waitKey(10);
}

The program could run correctly for several minutes, but each time it will terminate unexpectly with error message :
terminate called after throwing an instance of 'rs2::error'
what(): Frame didn't arrived within 5000

Hello @ytzhao, do you see the same behavior with RealSense samples/tools such as realsense-viewer or rs-depth-quality?
If so, could you please provide RealSense log by adding "log_to_file(RS2_LOG_SEVERITY_DEBUG);" to your app?
There is also a possibility that your camera hangs up while streaming. In order to ensure it doesn't happen please try to monitoring the USB connect/disconnect events by doing the following:

Open Terminal.
Type udevadm monitor
Try to reproduce the issue

If the camera hangs up you will see output from udevadm.

Hello @icarpis , firstly, thanks for your reply.

I tried with RealSense samples/tools/realsense-viewer, there are about 2 out of 10 times output:

- librealsense version: 2.8.2
- Intel RealSense 435 was selected as a default device
- Incomplete frame detected!
Size 328712 out of 614655 bytes (53%)

I added "log_to_file(RS2_LOG_SEVERITY_DEBUG);" to my app, the app ran for about 15 minutes and then crashed. The log file shows that:

 26/12 15:35:01,000 DEBUG [139909046900480] (archive.cpp:157) CallbackFinished,Color,0,DispatchedAt,1514273701000.158447
 26/12 15:35:01,000 DEBUG [139909046900480] (archive.cpp:164) Frame Callback [Color#0] overdue. (Duration:<PHONE_NUMBER>000.158447ms, FPS: 30, Max Duration: 32ms)
 26/12 15:35:01,000 DEBUG [139909046900480] (sync.cpp:26) SYNCED: Color 21169,<PHONE_NUMBER>00
Infrared 21343,<PHONE_NUMBER>00
Infrared 21343,<PHONE_NUMBER>00
Depth 21343,<PHONE_NUMBER>00

 26/12 15:35:01,000 DEBUG [139909046900480] (archive.cpp:361) CallbackStarted,Color,21169,DispatchedAt,1514273701000.286865
 26/12 15:35:01,000 DEBUG [139909046900480] (archive.cpp:157) CallbackFinished,Infrared,21341,DispatchedAt,1514273701000.330566
 26/12 15:35:01,000 DEBUG [139909046900480] (archive.cpp:164) Frame Callback [Infrared#21341] overdue. (Duration: 68.186035ms, FPS: 30, Max Duration: 32ms)
 26/12 15:35:01,000 DEBUG [139909055293184] (archive.cpp:157) CallbackFinished,Infrared,21341,DispatchedAt,1514273700999.356201
 26/12 15:35:01,000 DEBUG [139909055293184] (archive.cpp:164) Frame Callback [Infrared#21341] overdue. (Duration: 66.955811ms, FPS: 30, Max Duration: 32ms)
 26/12 15:35:01,000 DEBUG [139909055293184] (archive.cpp:157) CallbackFinished,Color,21168,DispatchedAt,1514273701000.613525
 26/12 15:35:01,000 DEBUG [139909055293184] (archive.cpp:157) CallbackFinished,Color,0,DispatchedAt,1514273701000.657227
 26/12 15:35:01,001 DEBUG [139909046900480] (archive.cpp:157) CallbackFinished,Depth,21341,DispatchedAt,1514273701000.951904

I watched the device monitor, when my application runs, the camera does not hang up.

Thank you for the detailed outputs.
The prints of Incomplete frame detected means that either the machine or the USB controller are weak.
Regarding the realsense-viewer crash, please provide core dump file by the following steps:

Open a Terminal
Type ulimit -c unlimited
Reproduce the crash of realsense-viewer
A core file should be appears at the working directory
Revert back the core dump settings to default by typing ulimit -c 0

Hi, I had this issue now and then.
@icarpis What do you mean with:

The prints of Incomplete frame detected means that either the machine or the USB controller are weak.

Do you mean, it has power issues (not enough power for the device)? do you mean the controller has not enough bandwidth to transfer the full frames ?

Sorry for delay, the partial frames issue usually indicate that the uvcvideo driver does not get enough USB buffers from the USB subsystem. This can be either because the system is overloaded (possibly thermal-throttled), CPU utilisation is near 100%, or the USB controller is not handling the requests in time.

[Realsense Customer Engineering Team Comment]
hi @mjscosta , @ytzhao
do you still need support on this topic?
thanks.

[Realsense Customer Engineering Team Comment]
let me close this ticket here, please feel free to open new ticket if any question.

Fell free to close it on my side. I've got this under a VM, either using vmware or virtualbox.
So dorodnic's reply, just explains it. Thanks for the info.
Best.


Failing to return search results

sh = SciHub()
sh.search('bacteria',5)
This fails to return any results due to a captcha. Any way to work around this?
{'papers': [], 'err': 'Failed to complete search with query food (captcha)'}

Why is this issue being closed?


Mistake in DocumentEngine tests

@michael,  here we call getDocument with string argument, while it should be args object

True! Can you fix and open PR (based on devel branch). I'm currently in overlay business.

yes, but let's collect more issues

@Integral can you take care of the Collab tests and smooth things so we are good for beta 4 here.

??!

almost done

https://github.com/substance/substance/pull/677

This is done


Maintainer Story: @mumoshu

Title
Maintainer Month 2023: Behind the scenes with Yusuke Kuoka
Author or authors
Yusuke Kuoka
Description
Hi 👋
In honor of Maintainer's Month, my blog post focuses on encouraging everyone to get involved in open-source, by introducing how open-source helped motivate me and progress my career as a software developer.
Resource link
https://surrealdb.com/blog/maintainer-month-2023-behind-the-scenes-with-yusuke-kuoka
Conent type
Blog Post
Related topics
Open Source

Thanks for another story @mumoshu! Should be live shortly on the website


MWPW-136159 Update eslintrc.js as per Milo

Update eslintrc to prevent VSCode lint-ing noise

Codecov Report

Merging #369 (0ff6852) into stage (893fcd4) will not change coverage.
Report is 4 commits behind head on stage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage     #369   +/-   ##
=======================================
  Coverage   92.79%   92.79%
=======================================
  Files          24       24
  Lines        2680     2680
=======================================
  Hits         2487     2487
  Misses        193      193

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Lack of integrity verification of downloaded external dependencies

Hey,
My name is Maciej Mensfeld and I run a research security project called WhiteSource Diffend.io.
I've noticed, that this library downloads some external resources and uses them. While it's a totally common pattern, what is lacking here is integrity verification.
You could verify the integrity of the downloaded files before using them by comparing the files hashes to a hardcoded, expected files hashes.
This is essentially what package managers do to verify the integrity of downloaded packages.
Doing this would prevent attack scenarios in which sass-embedded is manipulated.
Have a great day :)
ref: https://my.diffend.io/gems/sass-embedded/0.1.0/page/1#d2h-090432-2851

The dart-sass-embedded is not stable yet, so currently it always downloads the latest release binary from https://github.com/sass/dart-sass-embedded/releases. Because the latest release is changing I cannot hard code a checksum.
This will be reconsidered once the dependency has entered a stable state, closing for now.