Issue 1699 extend destination field

What does this PR do?
closes #1699
Checklist

[x] This is an enhancement of existing features, or a new feature in existing plugins

[ ] I have updated CHANGELOG.asciidoc
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Added an API method or config option? Document in which version this will be introduced
[ ] I have made corresponding changes to the documentation

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #1788 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-04-26T12:04:01.588+0000

Duration: 3 min 59 sec

Commit: a4a563e6e5caf324182350640fde2a57f1cbb9e1

Trends :test_tube:

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here
Description: approval-list/elastic/apm-agent-java.yml

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output
Expand to view the last 100 lines of log output

[2021-04-26T12:06:31.593Z] Merging remotes/origin/master commit 0e93d3e0666ecd714877ae71cf09571b4820d6e8 into PR head commit a4a563e6e5caf324182350640fde2a57f1cbb9e1
[2021-04-26T12:06:31.083Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-04-26T12:06:31.090Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-26T12:06:31.101Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-04-26T12:06:31.115Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-04-26T12:06:31.115Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-04-26T12:06:31.116Z]  > git fetch --no-tags --progress --prune -- https://github.com/elastic/apm-agent-java.git +refs/pull/1788/head:refs/remotes/origin/PR-1788 +refs/heads/master:refs/remotes/origin/master # timeout=100
[2021-04-26T12:06:31.601Z]  > git config core.sparsecheckout # timeout=10
[2021-04-26T12:06:31.606Z]  > git checkout -f a4a563e6e5caf324182350640fde2a57f1cbb9e1 # timeout=100
[2021-04-26T12:06:31.824Z]  > git remote # timeout=10
[2021-04-26T12:06:31.831Z]  > git config --get remote.origin.url # timeout=10
[2021-04-26T12:06:31.838Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-04-26T12:06:31.839Z]  > git merge 0e93d3e0666ecd714877ae71cf09571b4820d6e8 # timeout=10
[2021-04-26T12:06:32.191Z] Merge succeeded, producing d5f375ccdfab6f1aaa21d440fb3cd6547c787592
[2021-04-26T12:06:32.191Z] Checking out Revision d5f375ccdfab6f1aaa21d440fb3cd6547c787592 (PR-1788)
[2021-04-26T12:06:32.183Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-04-26T12:06:32.194Z]  > git config core.sparsecheckout # timeout=10
[2021-04-26T12:06:32.201Z]  > git checkout -f d5f375ccdfab6f1aaa21d440fb3cd6547c787592 # timeout=100
[2021-04-26T12:06:35.940Z] Commit message: "Merge commit '0e93d3e0666ecd714877ae71cf09571b4820d6e8' into HEAD"
[2021-04-26T12:06:35.940Z] First time build. Skipping changelog.
[2021-04-26T12:06:35.968Z]  > git --version # timeout=10
[2021-04-26T12:06:35.982Z]  > git --version # 'git version 2.17.1'
[2021-04-26T12:06:35.995Z] fatal: bad object b4aa23e52e63d1c9b07c2ac41042ac29824d10a5
[2021-04-26T12:06:37.059Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-04-26T12:06:37.164Z] Timeout set to expire in 1 hr 0 min
[2021-04-26T12:06:37.201Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-04-26T12:06:37.684Z] [INFO] Number of builds to be searched 10
[2021-04-26T12:06:37.996Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-04-26T12:06:38.033Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1788/src/github.com/elastic/apm-agent-java
[2021-04-26T12:06:38.089Z] [INFO] gitCheckout: Checkout SCM PR-1788 with some customisation.
[2021-04-26T12:06:38.131Z] [INFO] Override default checkout
[2021-04-26T12:06:38.219Z] Sleeping for 10 sec
[2021-04-26T12:06:48.250Z] The recommended git tool is: git
[2021-04-26T12:06:48.395Z] using credential 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
[2021-04-26T12:06:48.405Z] Cloning the remote Git repository
[2021-04-26T12:06:48.424Z] Cloning repository https://github.com/elastic/apm-agent-java.git
[2021-04-26T12:06:48.455Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1788/src/github.com/elastic/apm-agent-java # timeout=10
[2021-04-26T12:06:48.468Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2021-04-26T12:06:48.469Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-04-26T12:06:48.469Z]  > git --version # timeout=10
[2021-04-26T12:06:48.476Z]  > git --version # 'git version 2.17.1'
[2021-04-26T12:06:48.476Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-04-26T12:06:48.477Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-26T12:06:49.041Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-04-26T12:06:49.045Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-04-26T12:06:49.052Z]  > git config remote.origin.url https://github.com/elastic/apm-agent-java.git # timeout=10
[2021-04-26T12:06:49.062Z] Fetching upstream changes from https://github.com/elastic/apm-agent-java.git
[2021-04-26T12:06:49.062Z] using GIT_ASKPASS to set credentials GitHub user @apmmachine User + Personal Access Token
[2021-04-26T12:06:49.063Z]  > git fetch --tags --progress -- https://github.com/elastic/apm-agent-java.git +refs/pull/1788/head:refs/remotes/origin/PR-1788 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2021-04-26T12:06:49.540Z] Checking out Revision a4a563e6e5caf324182350640fde2a57f1cbb9e1 (origin/PR-1788)
[2021-04-26T12:06:49.734Z] Commit message: "added instrumentation for setDestinationAddress, setDestinationService"
[2021-04-26T12:06:49.734Z] First time build. Skipping changelog.
[2021-04-26T12:06:49.751Z]  > git --version # timeout=10
[2021-04-26T12:06:49.756Z]  > git --version # 'git version 2.17.1'
[2021-04-26T12:06:49.759Z] fatal: bad object b4aa23e52e63d1c9b07c2ac41042ac29824d10a5
[2021-04-26T12:06:49.526Z]  > git rev-parse origin/PR-1788^{commit} # timeout=10
[2021-04-26T12:06:49.542Z]  > git config core.sparsecheckout # timeout=10
[2021-04-26T12:06:49.547Z]  > git checkout -f a4a563e6e5caf324182350640fde2a57f1cbb9e1 # timeout=10
[2021-04-26T12:06:50.903Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-04-26T12:06:51.635Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-04-26T12:06:52.684Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1788/src/github.com/elastic/apm-agent-java/.git
[2021-04-26T12:06:52.841Z] Archiving artifacts
[2021-04-26T12:06:53.670Z] + git rev-parse HEAD
[2021-04-26T12:06:54.022Z] + git rev-parse HEAD
[2021-04-26T12:06:54.353Z] + git rev-parse origin/pr/1788
[2021-04-26T12:06:54.420Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-04-26T12:06:54.653Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-04-26T12:06:55.647Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1788/reviews return 0 elements
[2021-04-26T12:06:55.742Z] [INFO] githubPrCheckApproved: Title: Issue 1699 extend destination field - User: kananindzya - Author Association: CONTRIBUTOR
[2021-04-26T12:06:56.152Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-04-26T12:06:56.152Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-04-26T12:06:56.263Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-04-26T12:06:56.297Z] Sleeping for 5 sec
[2021-04-26T12:06:57.639Z] Stage "Build" skipped due to earlier failure(s)
[2021-04-26T12:06:57.898Z] Stage "Tests" skipped due to earlier failure(s)
[2021-04-26T12:06:58.166Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2021-04-26T12:06:58.185Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2021-04-26T12:06:58.202Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2021-04-26T12:06:58.220Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-04-26T12:06:58.239Z] Stage "Javadoc" skipped due to earlier failure(s)
[2021-04-26T12:06:58.472Z] Failed in branch Unit Tests
[2021-04-26T12:06:58.487Z] Failed in branch Smoke Tests 01
[2021-04-26T12:06:58.502Z] Failed in branch Smoke Tests 02
[2021-04-26T12:06:58.518Z] Failed in branch Benchmarks
[2021-04-26T12:06:58.535Z] Failed in branch Javadoc
[2021-04-26T12:06:58.861Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-04-26T12:06:58.976Z] Stage "Stable" skipped due to earlier failure(s)
[2021-04-26T12:06:59.098Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-04-26T12:06:59.152Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-04-26T12:06:59.632Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1788
[2021-04-26T12:06:59.889Z] [INFO] getVaultSecret: Getting secrets
[2021-04-26T12:06:59.945Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-26T12:07:01.097Z] + chmod 755 generate-build-data.sh
[2021-04-26T12:07:01.097Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1788/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1788/runs/1 ABORTED 179231
[2021-04-26T12:07:01.097Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1788/runs/1/steps/?limit=10000 -o steps-info.json
[2021-04-26T12:07:01.097Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1788/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-04-26T12:07:01.097Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-04-26T12:07:02.441Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-04-26T12:07:04.303Z] Retry 3/3 exited 22, no more retries left.
[2021-04-26T12:07:04.303Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1788/runs/1/log/ -o pipeline-log.txt

Hey @kananindzya 👋
Thanks for the PR. However, we're currently re-thinking how the API should look like given that the destination.service.name and destination.service.type are not actually used. More info here: https://github.com/elastic/apm/issues/424#issuecomment-826820094

Blocked until https://github.com/elastic/apm/pull/436 is finalized

@kananindzya would you like me to take over and apply these minor fixes?

@kananindzya would you like me to take over and apply these minor fixes?
I can make a PR on this PR if you want

Hi @eyalkoren, after 30 min I will send changes.

Instead of duplicating the properties for user-supplied values, would it be possible to either

Only override existing values if they are user-supplied (no additional properties needed)
Mark properties that have been user-supplied with a boolean flag (similar to the span name priority)

@elasticmachine run elasticsearch-ci/docs


Publish output from forc doc for sway-lib-std on ghpages

As we refactor CI to publish both "The Sway Book" and "The Sway Reference" under ghpages (rather than just the former), we should also add a std reference generated by forc doc.
In the long-run, we can take some inspiration from docs.rs and automate the generation of all pkg documentation from the hypothetical future package registry. #865

#3930 is a critical fix for #3923
There is also another critical bug at #3929


Works for cert install, but then cameras can't connect

Hi thanks for the script,
However, I think some things might have changed since it was written.
The script works and the SSL becomes valid, but then when adopting a camera, it gets stuck during the adoption process.
I believe this is related to some changes in how camera streams are encrypted.
I am trying this guide now:
https://www.john.geek.nz/2018/05/using-letsencrypt-with-ubiquiti-unifi-video-server/
More info:
https://community.ubnt.com/t5/UniFi-Video/Custom-SSL-Certificates-in-3-8-1-and-beyond/m-p/2089043

I see that your last commit was in June 2017, the blog post with changes to SSL was made in October 2017, so more than likely that is the problem

Hey @travisaustin I got it working and we can close this issue. Couple of things I discovered:

In order to connect a camera to a remotely located NVR, you have to use the adoption token method:
https://help.ubnt.com/hc/en-us/articles/204975924-UniFi-Video-How-to-Adopt-a-Remote-Camera-that-is-not-Displaying-in-the-NVR
My camera had version 3.2 firmware which did not have the option for inputting the token. It would connect but then go to "Upgrading" and become stuck.
In order to fix the problem I downloaded NVR version 3.8.3 locally and was able to use that to adopt the camera normally and then upgrade the firmware.
Now with the upgraded firmware I was able to input the adoption token into the camera and connect it to the remotely located NVR

Now it works fine, so none of this was actually related to the script, which still works.

Awesome, @reillychase. Thanks for following up.


bbc_microbit_v2 build error for lis2dh

lis2dh_output.txt
Describe the bug
Error while building the example lis2dh, it works for bbc_microbit but not for bbc_microbit_v2.
I have tried to find the issue, but I have no luck, one thing which might cause some problems is that the sm303agr-magn@1e and lsm303agr-accel@19 from the bbc_microbit_v2.dts file are on the same GPIO pin.

To Reproduce
Steps to reproduce the behavior:

zephyr 2.4
cd zephyr/samples
west build -b bbc_microbit_v2 samples/sensor/lis2dh
See the error

Expected behavior
Bbc_microbit (v1.5 and v2) share the same accelerometer lsm303agr it is expected for the same code to work, or a solution to access the accelerometer for v2.
Impact
Not able to progress on my FYP (Final year project) because I can not access the accelerometer information.
Logs and console output
In file included from ../include/sys/util.h:27,
                from ../include/sched_priq.h:9,
                from ../include/kernel_includes.h:23,
                from ../include/kernel.h:17,
                from ../include/init.h:11,
                from /home/liviu/Part2/zephyrproject/zephyr/drivers/sensor/lis2dh/lis2dh.c:10:

zephyr/include/generated/devicetree_unfixed.h:2926:40: error: 'DT_N_S_soc_S_i2c_40003000_S_lsm303agr_accel_19_BUS_P_label' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_i2c_40003000_S_lsm303agr_accel_19_P_label'?
2926 | #define DT_N_INST_0_st_lis2dh          DT_N_S_soc_S_i2c_40003000_S_lsm303agr_accel_19
     |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/sys/util_internal.h:65:26: note: in definition of macro '__DEBRACKET'
  65 | #define __DEBRACKET(...) __VA_ARGS__
     |                          ^~~~~~~~~~~
../include/sys/util_internal.h:57:2: note: in expansion of macro '__GET_ARG2_DEBRACKET'
  57 |  __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
     |  ^~~~~~~~~~~~~~~~~~~~
../include/sys/util_internal.h:52:2: note: in expansion of macro '__COND_CODE'
  52 |  __COND_CODE(_XXXX##_flag, _if_1_code, _else_code)
     |  ^~~~~~~~~~~
../include/sys/util.h:414:2: note: in expansion of macro 'Z_COND_CODE_1'
 414 |  Z_COND_CODE_1(_flag, _if_1_code, _else_code)
     |  ^~~~~~~~~~~~~

There are 300 lines, I have attached the file lis2dh_output.txt for the full output.
Environment (please complete the following information):

OS: Linux 20.04
Toolchain: Zephyr version: 2.4.0, west 0.9

Additional context
The bbc_microbit (v1.5) has the Cortex-M0 processor while v2 has the Cortex-M4 processor, I am not sure if that should make any difference in the ability to use the example lis2dh.

Assigning to @mbolivar-nordic since this seems to be a Devicetree issue.

zephyr 2.4

Do you mean 2.5? Zephyr 2.4 did not have support for the bbc_microbit_v2 board

zephyr 2.4

Do you mean 2.5? Zephyr 2.4 did not have support for the bbc_microbit_v2 board

I have brought the bbc_microbit_v2 Zephyr 2.4, I think it still should work, the Bluetooth works with bbc_microbit_v2 in the 2.4. I basically added the board from 2.5 to 2.4.
The reason is what I thought 2.4 is more stable because 2.5 is a draft yet.
I am sorry I should have specified that.

The reason is what I thought 2.4 is more stable because 2.5 is a draft yet.

No, 2.5 was released a few days ago, please do test 2.5.0.

No, 2.5 was released a few days ago, please do test 2.5.0.

I have tried Zephyr 2.5 now, the exact same error appeared. I have attached the new file which contains the output.
lis2dh_output_ZephyrV2.5.txt

Hi, thanks for the detailed report. I've posted a fix in #32597. I can only build test this, since I don't have hardware. @Liviu112 can you please confirm this fixes your issue?

Hi, thanks for the detailed report. I've posted a fix in #32597. I can only build test this, since I don't have hardware. @Liviu112 can you please confirm this fixes your issue?

Hi, thank you, yes it works as expected on bbc_microbit_v2, thank you :)

yes it works as expected on bbc_microbit_v2

Great :). Thanks for confirming.


Sema: Move preCheckExpression() out of solveForExpression()

There are two "RAII cleaners" here:

CleanupIllFormedExpressionRAII cleans up the Expr in its final state
ExprCleanser walks the Expr before it is mutated and collects
sub-expressions, then cleans those up after

The subtle difference comes into play if we started to apply the
solution (which can fail, leaving the AST in an inconsistent state)
or if preCheckExpression() modified the AST.
The latter case was causing an ASan failure because we were not
cleaning up type variables in new nodes introduced by
preCheckExpression().
Fix this by moving the preCheckExpression() call out of
solveForExpression(), so that if solveForExpression() is called
with TypeCheckExprFlags::SkipApplyingSolution, we don't mutate the
AST at all.
Sigh...
Fixes rdar://problem/33277279.

@swift-ci Please smoke test

Excellent, thanks!

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test Linux

@swift-ci Please smoke test Linux


Trivy upload not working

Bug description
Trivy k8s scan results would not upload to deject dojo
Steps to reproduce
Steps to reproduce the behavior:

Go to findings
Click on import scan results
Select trivy scan as scan type
See error

Expected behavior
Upload Trivy k8s results scan into dojo
Deployment method (select with an X)

[ ] Docker Compose
[ X] Kubernetes
[ ] GoDojo

Environment information
Self hosted (AWS) v. 2.9.0 ( release mode )
Logs
Use docker-compose logs (or similar, depending on your deployment method) to get the logs and add the relevant sections here showing the error occurring (if applicable).
Sample scan files
If applicable, add sample scan files to help reproduce your problem.
Screenshots

Additional context (optional)
Add any other context about the problem here.

Hi @Vanye-getcerebral, please provide the logs and/or a sample report to reproduce the problem

json sample report
trivy_result.txt

@StefanFl @Vanye-getcerebral it's a new beta feature of Trivy. the parser doesn't support these data and need work.

True, so it's not a bug. The parser reports correctly that it doesn't support this schema. I will have a look at it in the next days.

@StefanFl more a missing feature but yeah :) . this thing is new so...

Merged, will be part of the next release.


Runtime endpoint route uris resolving

I was digging into the VRaptor code and I was unable to figure out a way to define the controller's endpoints paths (URI's from the @Path/@Get/@Post annotations) at runtime.
In some situations this can be very useful.
I was trying to isolate some common controllers as libraries, but the URI's of those controllers methods must be defined as static strings that must be compilation time resolvable.
Am I missing something here? It is already possible to do that?
I can think of some other situations that this can be useful, like dynamic generation of URI's in multi instance system, some API publication patterns and others.
Do you think this is an interesting feature for VRaptor? If so, I can propose an implementation of this.

@renatorroliveira thank you for bringing this up
However, I cant think in a situation where I'd use this in my projects.
could you provide an use case?

Well, it is very specific indeed.
But let me explain my actual use case.
I have several projects that share the same logic of user control and multi tenant implementation. However they are distinct projects and a I can't use these logics as a auth/authz microservice, I must embed them into the project and deploy them on different servers. So, I came with the proposal to isolate that logic into a library/plugin. At this point no problem.
The thing is that I want to include the API controllers within the library too. When I was doing that I noticed that there are many approaches for this, none of them is intuitive. The lack of an easy way to register/resolve routes at runtime makes this implementation ugly. I want to include the controllers and dynamically decides if a given route will be included or not in the current application instance based on runtime data. For example, I can have a configuration bean that defines which routes will be included in the internal router:

public interface MyRuntimeRoutesConfiguration {
	public String getRoutesPrefix();
	public boolean isUserControlEnabled();
	public boolean isMultiTenantEnabled();
}

Then I inject this bean into an override of the path resolver:
public interface RuntimeRouteResolver {
	String[] getURIsFor(Path pathAnn);
}

@Target({ElementType.METHOD, ElementType.TYPE})
@Documented
@Retention(RetentionPolicy.RUNTIME)
public @interface RuntimePath {
	Class<? extends RuntimeRouteResolver> value();
}

public class PrefixedRouteResolver implements RuntimeRouteResolver {

	private MyRuntimeRoutesConfiguration config;

	public PrefixedRouteResolver() {
		this.config = CDI.current().select(MyRuntimeRoutesConfiguration.class).get();
	}

	@Override
	public String[] getURIsFor(Path pathAnn) {
		String[] uris = pathAnn.value();

		for (int i = 0; i < uris.length; i++) {
			if (!GeneralUtils.isEmpty(uris[i])) {
				uris[i] = this.config.getRoutesPrefix() + uris[i];
			}
		}

		return uris;
	}

}

@ApplicationScoped
@Specializes
public class RuntimeRouteParser extends PathAnnotationRoutesParser {

	private static final Logger LOG = Logger.getLogger(RuntimeRouteParser.class);

	/**
	 * @deprecated CDI eyes only
	 */
	protected RuntimeRouteParser() {
		this(null, null);
	}

	@Inject
	public RuntimeRouteParser(Router router, ReflectionProvider reflectionProvider) {
		super(router, reflectionProvider);
	}

	@Override
	protected String[] getURIsFor(Method javaMethod, Class<?> type) {
		if (javaMethod.isAnnotationPresent(RuntimePath.class) && javaMethod.isAnnotationPresent(Path.class)) {
			Path pathAnn = javaMethod.getAnnotation(Path.class);
			RuntimePath runtimePathAnn = javaMethod.getAnnotation(RuntimePath.class);

			RuntimeRouteResolver resolve;
			String[] uris = new String[] {};
			try {
				resolve = runtimePathAnn.value().newInstance();
				uris = resolve.getURIsFor(pathAnn);
			} catch (InstantiationException | IllegalAccessException e) {
				LOG.errorf(e, "Error instantiating runtime path resolver.");
				checkArgument(false, "Error instantiating runtime path resolver.");
			}

			checkArgument(uris.length > 0, "You must specify at least one path on @Path at %s", javaMethod);
			checkArgument(getUris(javaMethod).length == 0,
					"You should specify paths either in @Path(\"/path\") or @Get(\"/path\") (or @Post, @Put, @Delete), not both at %s", javaMethod);

			fixURIs(type, uris);
			return uris;
		}
		return super.getURIsFor(javaMethod, type);
	}
}

This is an initial solution I came up with, but I really believe that this logic could be added to the framework (or something similar) because it enables more flexible approaches for some architectural problems we can face.
Of course it is a little specific, but I think flexibility isn't a problem. What do you think?

This is just an example that adds runtime resolved prefix to the endpoint's URI. Some project that uses the library can specializes the configuration bean and change prefix and/or disable/enable the multi tenant related endpoints for example.
I hope this example shows the flexibility this idea brings.


feature/jobOpenings -> dev

This change is

Reviewed 26 of 26 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

byuSuite/Apps/JobOpenings/controller/JobOpeningsCategoriesViewController.swift, line 40 at r1 (raw file):

	//MARK: Custom Methods
	private func loadCategories() {
		JobOpeningsClient2.getJobCategories { (categories, error) in

Rename client without the 2. Also, look for any other leftover 2s in JobOpenings

byuSuite/Apps/JobOpenings/controller/JobOpeningsPostingsViewController.swift, line 28 at r1 (raw file):

    }

	override func viewWillAppear(_ animated: Bool) {

I'm seriously considering putting this in the TableDataVC... Can you see if any feature using TableDataVC DON'T do this exact thing in their viewWillAppear?
If we were to do this, we would also be moving the tableView into the ViewController (which I've been wanting to do for a while). This would obviously be on a separate branch, but look into it for me

byuSuite/Apps/JobOpenings/model/JobOpeningsCategory.swift, line 15 at r1 (raw file):

	var siteId: String
	var siteDescription: String?

Remove excess space

byuSuite/Apps/JobOpenings/model/JobOpeningsClient.swift, line 14 at r1 (raw file):

	static func getJobCategories(callback: @escaping ([JobOpeningsCategory]?, ByuError?) -> Void) {
		let request = ByuRequest2(url: super.url(base: BASE_URL))
		ByuRequestManager.instance.makeRequest(request) { (response) in

inline request when it's this short :)

byuSuite/Apps/JobOpenings/model/JobOpeningsClient.swift, line 32 at r1 (raw file):

	static func getJobPostings(categoryId: String, callback: @escaping ([JobOpeningsFamily]?, ByuError?) -> Void) {
		let request = ByuRequest2(url: super.url(base: BASE_URL, queryParams: ["id": categoryId]))

You can inline this if you want. If you like it better outside, this one can stay outside. Whatever you'd prefer

byuSuite/Apps/JobOpenings/model/JobOpeningsFamily.swift, line 20 at r1 (raw file):

		//Check that listings is an array. Where there is only one listing, the service simply returns the one dictionary
		if let jobListings = dict["job_listing"] as? [[String: Any]] {

Let's save dict["job_listing"] before the if let so we don't duplicate the key

byuSuite/Apps/JobOpenings/model/JobOpeningsPosting.swift, line 22 at r1 (raw file):

		departmentDescription = dict["department_description"] as? String
		openDate = dict["posting_open_date"] as? String
		jobDescription = dict["job_description"] as? String

The obj-c code defaulted this variable. Match what's its doing. That might also make jobDescription non-optional

Comments from Reviewable

Reviewed 1 of 26 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

byuSuite/Apps/JobOpenings/controller/JobOpeningsDetailViewController.swift, line 34 at r1 (raw file):

			descriptionView.loadHTMLString(htmlString, baseURL: nil)
		} else {
			descriptionView.isHidden = true

Why do we set this to hidden? Would this just show an empty page? Shouldn't we show some default text label saying that the posting was invalid or something?

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions.

byuSuite/Apps/JobOpenings/controller/JobOpeningsCategoriesViewController.swift, line 40 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Rename client without the 2. Also, look for any other leftover 2s in JobOpenings

Done.

byuSuite/Apps/JobOpenings/controller/JobOpeningsDetailViewController.swift, line 34 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Why do we set this to hidden? Would this just show an empty page? Shouldn't we show some default text label saying that the posting was invalid or something?

I hide it so that for a posting that does not have an html string, there will not be an empty box that you can scroll up and down. A posting can have all other data except the html string and still be valid.

byuSuite/Apps/JobOpenings/controller/JobOpeningsPostingsViewController.swift, line 28 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I'm seriously considering putting this in the TableDataVC... Can you see if any feature using TableDataVC DON'T do this exact thing in their viewWillAppear?
If we were to do this, we would also be moving the tableView into the ViewController (which I've been wanting to do for a while). This would obviously be on a separate branch, but look into it for me

It looks possible, I dont think we have moved a lot of the features to use ByuTableDataViewController so I dont think it should take that long.

byuSuite/Apps/JobOpenings/model/JobOpeningsCategory.swift, line 15 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Remove excess space

Done.

byuSuite/Apps/JobOpenings/model/JobOpeningsClient.swift, line 14 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
inline request when it's this short :)

Done.

byuSuite/Apps/JobOpenings/model/JobOpeningsClient.swift, line 32 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
You can inline this if you want. If you like it better outside, this one can stay outside. Whatever you'd prefer

Done.

byuSuite/Apps/JobOpenings/model/JobOpeningsFamily.swift, line 20 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Let's save dict["job_listing"] before the if let so we don't duplicate the key

Done.

byuSuite/Apps/JobOpenings/model/JobOpeningsPosting.swift, line 22 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
The obj-c code defaulted this variable. Match what's its doing. That might also make jobDescription non-optional

this goes along with the comment about descriptionView.isHidden = true. If I leave this optional, then I can check in the JobOpeningsDetailViewController if it is nil or not, and if it is then I hide the descriptionView so we dont have an empty box that scrolls when no description was given.

Comments from Reviewable

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/JobOpenings/controller/JobOpeningsDetailViewController.swift, line 34 at r1 (raw file):
Previously, alexanderboswell (Alexander Boswell) wrote…
I hide it so that for a posting that does not have an html string, there will not be an empty box that you can scroll up and down. A posting can have all other data except the html string and still be valid.

Yup. Sounds good. But what will the screen look like? Just empty?

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

byuSuite/Apps/JobOpenings/controller/JobOpeningsDetailViewController.swift, line 34 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Yup. Sounds good. But what will the screen look like? Just empty?

it will still have the job title, id , and when it opens.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Krakend does not work with Django for POST requests

Environment info:

KrakenD version: 2.0.4
System info: Darwin 21.6.0 arm64
Backend technology: Django Web Framework

Describe what are you trying to do:
I want to run simple Django app that accept POST requests and return POST data as response.
def home(request):
    if request.method == 'POST':
        if 'name' in request.POST:
            name = request.POST['name']
            return HttpResponse(f'Welcome Home {name}!', status=201)
        return HttpResponse('You must send name as form-data', status=400)
    return HttpResponse('Welcome Home!')

# Run Django server
./manage.py runserver

# Send a request to Django
curl -X POST -F 'name=John' http://<IP_ADDRESS>:8000/home

#Response
Welcome Home John!

This works flawlessly without Krakend and returns response correctly. But when I use Krakend as API gateway no form-data sending back to my Django backend.
# Run Django server
./manage.py runserver

# Run Krakend
krakend -c krakend.json run

# Send a request to Krakend
curl -X POST -F 'name=John' http://<IP_ADDRESS>:8080/home

#Response
You must send name as form-data

Download project repo
Your configuration file:
{
  "$schema": "https://www.krakend.io/schema/v3.json",
  "version": 3,
  "endpoints": [
    {
      "endpoint": "/home",
      "output_encoding": "no-op",
      "method": "POST",
      "backend": [
        {
          "url_pattern": "/home",
          "encoding": "no-op",
          "host": [
            "http://<IP_ADDRESS>:8000"
          ]
        }
      ]
    }
  ],
  "extra_config": {
    "telemetry/logging": {
      "level": "DEBUG",
      "syslog": false,
      "stdout": true
    }
  }
}

Configuration check output:
Result of krakend check -dtc krakend.json --lint command
Global settings
        Name:
        Port: 8080
1 global component configuration(s):
- telemetry/logging
1 API endpoint(s):
        - POST /home
        Timeout: 2s
        Connecting to 1 backend(s):
                [+] POST /home
                Timeout: 2s
                Hosts: [http://<IP_ADDRESS>:8000]

0 async agent(s):
Syntax OK!

Commands used:
How did you start the software?
krakend -c krakend.json run

Logs:
2022/08/20 - 11:38:38.041 ▶ INFO Starting the KrakenD instance
2022/08/20 - 11:38:38.041 ▶ DEBUG [ENDPOINT: /home] Building the proxy pipe
2022/08/20 - 11:38:38.041 ▶ DEBUG [BACKEND: /home] Building the backend pipe
2022/08/20 - 11:38:38.041 ▶ DEBUG [ENDPOINT: /home] Building the http handler
2022/08/20 - 11:38:38.041 ▶ DEBUG [ENDPOINT: /home][JWTSigner] Signer disabled
2022/08/20 - 11:38:38.041 ▶ INFO [ENDPOINT: /home][JWTValidator] Validator disabled for this endpoint
2022/08/20 - 11:38:38.041 ▶ INFO [SERVICE: Gin] Listening on port: 8080
[GIN] 2022/08/20 - 11:38:42 | 400 |    2.566333ms |       <IP_ADDRESS> | POST     "/home"
2022/08/20 - 11:38:43.042 ▶ DEBUG [SERVICE: Telemetry] Registering usage stats for Cluster ID uAIFJEAwGqv5c97v+T1icKxY2iZIUcC0Nud0+wT+kEs=
#Additional comments:

change your krakend config so that it makes a POST request to your backend. Currently it makes a GET request since you did not specify method explicitly:
"backend": [
    {
        "url_pattern": "/home",
        "encoding": "no-op",
        "method": "POST",
        "host": [
        "http://<IP_ADDRESS>:8000"
        ]
    }
]

Hi @shervintech
This may come late, but I would say that your backend is not receiving the required headers since your input_headers configuration is empty.
Try setting input_headers (I think adding the Content-Length should be enough to start) and try again.

Hi @taik0
Yes it works.


max_native_ad_view.dart:224:44: Error: Member not found: 'MediaQuery.devicePixelRatioOf'.

Feature Description
Hi,
I'm having a problem, I'm trying set a banner but I can't run the app through the following error:
Member not found: 'MediaQuery.devicePixelRatioOf'.
The code I have for the banner is:
Future initializePlugin() async {
// logStatus("Initializing SDK...");
Map? configuration = await AppLovinMAX.initialize("SDK_KEY");
if (configuration != null) {
  _isInitialized = true;

  // logStatus("SDK Initialized: $configuration");

  attachAdListeners();
}

}
void attachAdListeners() {
/// Banner Ad Listeners
AppLovinMAX.setBannerListener(AdViewAdListener(onAdLoadedCallback: (ad) {
  // logStatus('Banner ad loaded from ${ad.networkName}');
}, onAdLoadFailedCallback: (adUnitId, error) {
  // logStatus('Banner ad failed to load with error code ${error.code} and message: ${error.message}');
}, onAdClickedCallback: (ad) {
  // logStatus('Banner ad clicked');
}, onAdExpandedCallback: (ad) {
  // logStatus('Banner ad expanded');
}, onAdCollapsedCallback: (ad) {
  // logStatus('Banner ad collapsed');
}, onAdRevenuePaidCallback: (ad) {
  // logStatus('Banner ad revenue paid: ${ad.revenue}');
}));

}
And:
bottomNavigationBar:
    MaxAdView(
        adUnitId: "Banner_ID",
        adFormat: AdFormat.banner,
    ),

Sorry for my english

also i same issue

@CoolSoftMatias  simply upgrade your flutter version to [3.13.3] your issue got resolved

@CoolSoftMatias, thanks for reporting this issue.
According to the Flutter doc, using specific methods such as MediaQuery.devicePixelRatioOf is preferred rather than MediaQuery.of(context).devicePixelRatio.   But, it is essential to support our library regardless of the Flutter version.   Let us update.

Updating my flutter version I could run the app, and test ads appear. But the app downloaded from the play store is not showing ads, I live in Argentina works fine here?

@CoolSoftMatias - Live ads are not guarnateed to fill - that's where we suggest integrating more mediated networks to fill in the demand.


Events no longer bubble

Thanks for the awesome plugin, first of all. :)
In 8934ee1 events were made to never bubble, but I don't quite understand the reason. I noticed this because it breaks all of my widgets that rely on event bubbling.
Here's a very stripped-down example...

      <input data-keydown="keydownEvent">

The dialog has certain default keydown shortcuts. Pressing enter submits it and pressing escape cancels it. There's an autocomplete search inside the dialog that handles the same events. If the search menu is open, escape closes the menu (rather than the dialog), and pressing enter selects a menu item (rather than accepting the dialog).
Even if the menu is closed, autocomplete.keydownEvent is still executed, so post-8934ee1 the event no longer bubbles up to dialog.keydownEvent.
There's also some outside jQuery code that manually registers events on the document/body and handles various actions, and these don't see the event either.
Depending on why the change was made, maybe reverting to the previous behavior but having something similar knockout's fooBubble bindings would be a sufficient solution. http://knockoutjs.com/documentation/event-binding.html e.g. data-keydownBubble="false".

There is a new option in 0.5.0 to allow bubbling to continue by adding an additional binding like:

Then, on a case-by-case basis, the handler could even access the event arg and decide to prevent bubbling, if necessary.


Feat: Expose defineNitroPlugin from #imports.

Describe the feature
Currently, when creating a new Nuxt module using npx nuxi init -t module my-module, the developer may choose to create a nitro plugin as part of the module runtime.
However defineNitroPlugin is not exposed by the #imports, albeit defined in the docs. As a workaround, in order to define a server-side nitro plugin, one needs to manually stub the function's type from "nitropack". For example:
In server runtime: <root>/src/runtime/my-nitro-plugin.server.ts
import type { NitroApp } from "nitropack"

// type stub
type NitroAppPlugin = (nitro: NitroApp) => void

function defineNitroPlugin(def: NitroAppPlugin): NitroAppPlugin {
  return def
}

// Export runtime plugin
export default defineNitroPlugin((nitroApp) => {
  console.log("my module nitro logic runs here")
})

In nuxt module: <root>/src/module.ts
import { defineNuxtModule, createResolver, addServerPlugin } from "@nuxt/kit"

export default defineNuxtModule({
  meta: {
    name: "my-module",
    configKey: "myModule",
    compatibilty: ">=3.0.0",
  },
  setup(_, nuxt) {
    const { resolve } = createResolver(import.meta.url)
    const runtimeDir = resolve("./runtime")
    nuxt.options.build.transpile.push(runtimeDir)

   // Adds server-side plugin to module.
    addServerPlugin(resolve(runtimeDir, "my-module.server"))
  },
})

A live example can be found here and here
The desired solution would be to simply import defineNitroPlugin without stubbing the module.
Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

You need to import it from #internal/nitro, ideally it would be more intuitive though

This seems like an unintended bug if global types of nitro are not already exposed with internal typedef helper.

The global types of nitro are exposed but what would be helpful is for nitro to expose an alias of #imports in its generated tsconfig.json paths, so we can directly import from there.


limit minimum python version #1038

We decided on supporting the same minimum version as numpy. Thus, we move to minimum python3.9

Hi @lawrennd
sorry for the high traffic (there might be more coming up).
There is not too much in this MR. Simply a limitation to the minimum supported python version to prevent further compatibility issues with modern numpy versions.
This may drop support for some users but python 3.8 is end of life, so I guess moving to a minimum python 3.9 is "fair".


In the login popup, explain the permissions that should be added

at least public_repo (top) and delete_repo (bottom)

dupe of #74


Not a valid ERC-20 token

Hi there,
I just created a new erc20 token (ropsten network).
On
https://ropsten.etherscan.io/token/0x00d53126139c547c7bd4f4285fc3756c2f081ab1?a=0xc0ed690dbd9cdf76f17de0eca687299cec57e331
I see is a valid erc20 token, on myetherwallet I see and can send that, but on my friend's myetherwallet (ubuntu) I see Not a valid ERC-20 token error when I try to add that. Any help?
Thanks

Sorry is fixed, ignore this.


Give root route same access at index.yaml (fixes #66)

@liamawhite will this break your implementation?
cc @christopherhein

great, thanks!


feat(MGDCTRS-639): makes operators cluster-wide

Changes the behavior of debezium and camel operators so they will watch
the entire cluster for changes on ManagedConnector and other resources.
The property cos.connectors.namespace is not used anymore. Resources are
now created in the same namespace where the ManagedConnector resource
already is.
Roles and RoleBindings were changed to cluster.

@rinaldodev I guess this requies a larger change to the managed-tenants addon as well. Do you plan to provide it too?


feat: addPreloadScripts respects contexts param for old contexts

This only makes the already created Contexts respect the PreloadScript, the newly create one will still run the script atm.

@Lightning00Blade please don't wait on my review


(Fix) - #1605 QR Input address fix

Closes #1605
Closes #1196 by:

Adding types
Fixing how the. useEffect hook was being used for opening/closing the modal

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

#1196 's point 2. is not fixed. I still have the image selector popping up again, and the image is not being processed.

Maybe it would be better to let that fix for another PR and focus on the #1605 here.

I tested it and seems that the problem is that the qr scanner cannot read the qr but instead of throwing an error it just open the modal again, I added an error text for those cases and remove the auto poping:

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Tested here:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/balances
The recipient field not being filled with the contract's address was fixed
The file selector window opening over and over doesn't happen anymore
If a wrong QR image is being uploaded a message indicating such error is displayed
Checked that the address validation still works (loading a MM account as a Safe won't work for example)
It looks good to me

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1612--safereact.review.gnosisdev.com/volta/app


⚠ Bofrost.at has degraded performance

In 378ecfe, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1952 ms

Resolved: Bofrost.at performance has improved in a30f124.


Changes manifest setting from singleInstance => singleTask

fixes https://github.com/textileio/photos/issues/1041
Not going to lie, I don't fully understand this one.
Recreating the bug
I used the final clue in the ticket above and installed another gallery app that would take over the intent (Simple Gallery). Then when selecting an image, I'm offered selecting from Photos or Simple Gallery. If I select one and then select an image to share, ImagePicker.launchImageLibrary callback will return with a user cancelled value.
Solution
After looking for other people with similar issues, I found an issue I was reading through (not really related https://github.com/react-native-community/react-native-image-picker/issues/164) and noticed that there are problems if you use android:launchMode="singleInstance" in your manifest. I changed it and voila, it works.
My guess is this is also the cause of the store reviewer they likely just got through onboarding fine because they took a new avatar from their camera (no intent mess up) and then just couldn't post an image because of this bug.
Anyway, fixed.

yep, did pretty thorough QA this afternoon and found some things.

deep linking is working as expected now.
photo adds are working as expected now
photo re-shares were broken, there was a bug in uiredux now fixed. working as expected
fixes navigation to threads after joins now.

only odd thing left i found, is that the react-navigation params set during componentDidMount sometimes lag behind the screen. meaning if a user clicked them immediately it would error. i fixed this by disabling them until they are !undefined. this was actually the case before too, but I believe our app was recycling existing views so often the old values were still available, possibly causing edge-case bugs, not sure.


[FEATURE] Export-PnPTermGroupToXml and Import-PnPTermGroupFromXml do not respect order of Terms.

Is your feature request related to a problem? Please describe.
We want the Terms to appear in a specific order within their TermSets.
We manually created a TermSet with Terms in a specific order (see Source Hour TermSet.png).

The Export-PnPTermGroupToXml and Import-PnPTermGroupFromXml commands resulted in the Terms being ordered alphanumerically (see Target Hour TermSet.png).

Export-PnPTermGroupToXml creates an output file that disregards the source Term order an reorders the Terms alphanumerically within the .xml file (see UtilitiesTermGroup.xml.png).

If the xml file is manually edited to put all the pnp:Term elements in the desired order, the Import-PnPTermGroupFromXml command still disregards the ordering and results in an alphanumeric order in the target tenant (see Target Hour TermSet.png above).
Describe the solution you'd like
We would like the source TermGroup to be faithfully replicated on the target tenant including the order of Terms within each TermSet.
Describe alternatives you've considered
We tried manually setting the order in the Export-PnPTermGroupToXml output file as described above.
Additional context
Add any other context or screenshots about the feature request here.

The ordering can be manually updated through the browser using /sites/< shorturl >/_layouts/15/termstoremanager.aspx?RedirectToModernExperience=false. However, it would be nice to see the ordering preserved in the commands.

I have just tried to reproduce the problem and I was unable to do so.
I have created a term group and a term set with similar terms as you have in your screenshots. I have set custom sort on a term set level.
When I execute Export-PnPTermGroupToXml, custom sort is getting preserved (please note CustomSortOrder property on terms below). Same thing with Import-PnPTermGroupToXml - terms are getting correctly imported, taking custom sort into account.


Set-FTPTracing throws an error

Attempting to enable tracing throws an error:
PS C:\Windows\system32> set-ftptracing -enable
Unable to find type [FluentFTP.FtpTrace].
At C:\Program Files\WindowsPowerShell\Modules\Transferetto\0.0.11\Transferetto.psm1:963 char:20
+     if ($Enable) { [FluentFTP.FtpTrace]::EnableTracing = $true }
+                    ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (FluentFTP.FtpTrace:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

Unable to find type [FluentFTP.FtpTrace].
At C:\Program Files\WindowsPowerShell\Modules\Transferetto\0.0.11\Transferetto.psm1:966 char:32
+     if (-not $HideFunctions) { [FluentFTP.FtpTrace]::LogFunctions = $ ...
+                                ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (FluentFTP.FtpTrace:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

Unable to find type [FluentFTP.FtpTrace].
At C:\Program Files\WindowsPowerShell\Modules\Transferetto\0.0.11\Transferetto.psm1:970 char:25
+     if (-not $HideIP) { [FluentFTP.FtpTrace]::LogIP = $true }
+                         ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (FluentFTP.FtpTrace:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

It looks as if the namespace used to reference the FtpTrace class is wrong. According to the FluentFTP source code, the fully qualified name for the class should be FluentFTP.Helpers.FtpTrace:
https://github.com/robinrodricks/FluentFTP/blob/01131bbd99a3c4dbb0f4dbf0281c4784c9eb3406/FluentFTP/Helpers/FtpTrace.cs

I actually fixed it, but forgot to push to github. Now it should be fixed. Lemme publish new version

Done.

Thanks. We'll get the latest version once it's available.


[beta] Allow cargo package --list even for things that don't package.

Beta backport of #8175.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

:warning: Warning :warning:

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.44.0. Please double check that you specified the right target!

@bors: r+

:pushpin: Commit f42ed7a86339f662ba385d82b65422e52fdb947b has been approved by alexcrichton

:hourglass: Testing commit f42ed7a86339f662ba385d82b65422e52fdb947b with merge ff919113bf183bf3ead638a1dee1605e9dcf7bc0...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing ff919113bf183bf3ead638a1dee1605e9dcf7bc0 to rust-1.44.0...


[Python] lambda is a reserved keyword

You can not access data.lambda in Python, because the interpreter throws a SyntaxError: invalid syntax

Coverage increased (+1.2%) to 73.814% when pulling 514ac28b3ce71c565fcec30e9ee233ec40e25c6c on nim65s:devel into 8e4ff8729fd0d957a4f1c2835aca8c2b14da4519 on stack-of-tasks:devel.


go/types: uses $GOROOT/pkg/$GOOS_$GOARCH/unsafe.a incorrectly

The Go compiler treats import "unsafe" as special - even if there is a vendor/unsafe directory, or a compiled unsafe.a package file, it doesn't use any of those - import "unsafe" always means the real unsafe, no matter what.
go/types appears not to follow this rule. I accidentally created a $GOROOT/pkg/darwin_amd64/unsafe.a, and that causes go/types to fail to typecheck just about any code using unsafe, because it no longer uses the real unsafe.
Obviously I will fix my problem and stop generating unsafe.a, but go/types should still refuse to treat import "unsafe" as anything other than the real unsafe.
/cc @adonovan @griesemer

@rsc which package did you use to import the data into go/types?
I believe that's who's responsible for ensuring that unsafe is always the same.
(Not 100% sure about that but I've been poking around in various importers the last few days and noticed code like "if importing unsafe then return types.Unsafe")

Reproduction:
touch $(go env GOROOT)/pkg/$(go env GOOS)_$(go env GOARCH)/unsafe.a
go test -short go/types

It fails quite loudly. The first few lines of output are:
--- FAIL: TestBuiltinSignatures (0.00s)
	builtins_test.go:141: var s []int; _ = append(s): 1:19: could not import unsafe (/Users/rsc/go/pkg/darwin_amd64/unsafe.a: can't find export data (EOF))
	builtins_test.go:141: var s []int; _ = append(s, 0): 1:19: could not import unsafe (/Users/rsc/go/pkg/darwin_amd64/unsafe.a: can't find export data (EOF))

and so on.

go/types just uses whatever importer is provided. In this case, it's going to be the default importer which is the gc importer. Since the unsafe.a file exists, it tries to import that.
It's certainly easy to not call any importer at all for "unsafe".

The Go vendor spec explicitly says that
https://golang.org/s/go15vendor:

These rules...apply to standard library packages. If someone wants to vendor (and therefore hide the standard library version of) “math” or even “unsafe”, they can.

It sounds like a bug in gc or 'go build' to me, not go/types.

ping @rsc

Sigh. Obviously my memory is going. OK. Well, the importer is going to get rewritten as part of package management and workspace abstraction issues, so that will probably fix this anyway. So I guess nothing to do now.

FWIW, it doesn't make a lot of sense to me to vendor package unsafe - I'd be fine to disallow this and perhaps even state it in the spec that importing unsafe means only one thing and cannot be changed.


[Snyk] Security upgrade org.springdoc:springdoc-openapi-starter-webmvc-ui from 2.1.0 to 2.3.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

store-base/store-build-chassis/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

551/1000  Why? Recently disclosed, Has a fix available, CVSS 5.3
Denial of Service (DoS) SNYK-JAVA-ORGSPRINGFRAMEWORK-6091650
org.springdoc:springdoc-openapi-starter-webmvc-ui:  2.1.0 -> 2.3.0
No
No Known Exploit

651/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 6.6
Arbitrary Code Execution SNYK-JAVA-ORGYAML-3152153
org.springdoc:springdoc-openapi-starter-webmvc-ui:  2.1.0 -> 2.3.0
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)
🦉 Arbitrary Code Execution

closing in favor of #79


Switch from deprecated proxy to httpClient

See linked issue https://github.com/mia-care/node.js-mia-care-template/issues/22

@nicola88 The PR looks good to me. However, I have an observation on this: the HttpClient.js file aims to wrap the HttpClient that is a utility for, potentially, every call to external or internal service. So, my question is: are we adding further logic just to overcome a lack from CRUD Service? In this case, I think this operation should not be carried out, since we're specializing the HttpClient utility for the CRUD. If we need it, I think we need to change the name to CRUDClient, to let SWEng aware that this utility is just for CRUD.
Moreover, has this issue regarding CRUD ever been notified?

If I recall correctly when we discussed this behavior, the ending slash has a semantic which the CRUD applies correctly, so as you suggest I will change its name to make it clear it works for the CRUD.


Background color support for Steam browser

background-color is removed as a property if I understand correctly. @ironyx has some details I think

Photos attached of what the blog looks like in steam browser.

It appears to be that the body tag needs background-color CSS applied. When I test my website in Steam (http://www.dache.io) it works properly, and this is the only difference I can see.

Should be fixed with https://github.com/StackExchange/blog/commit/a2dd8b912f7bc05ec7eb39f6e8a0f93deca50055

Confirmed fixed. Thanks!


State & license of this project

HI,
Thanks for the good work. I am planning on integrating this library with electron-packager https://github.com/maxogden/electron-packager/issues/30. But based on the resource hacker licencing terms, its clearly stated that
This software is not to be distributed via  any website domain or any other media without    the prior written approval of the copyright owner.
based on this comment https://github.com/mllrsohn/node-webkit-builder/issues/44#issuecomment-51233048 , you already sent a mail to the author of the resource hacker. I am wondering is this taken care of?
If not, instead of packaging the resourcehacker.exe with this library, we can do a npm post hook to download and install the resourcehacker.exe. This will avoid the licencing issues i suppose.
Please let me know if you need any help, i am already working on the npm post hook stuff.
Cheers

Hi Rameshv. I sent an email to the author but I never got any answer.
Your solution seems fine to me, I'll review the pull request and publish a new version in the next hours

Merged and published to npm

I just hope it wont overload its server :S

Cheers @felicienfrancois. lets hope not :)


Is there is any way to hide filter icon? I need filter functionalities only  using api.

For past 1  month i'm using ag-grid. i'm facing a pbm that i have to hide the filter icon while mouse over to column header but i need the filter functionalities through filter api.

Try using "suppressMenu: true" in column definition.

Thanks fkoulba this is solved my pbm.
ag-grid has more functionalities but is not properly documented.

This isn't working for me. Even with  suppressMenu: true, I can still see the filter icon.

suppressMenu - stops the menu from appearing.
this does not stop the filter icons from appearing.
if you want no filter icon, then don't filter by that column!!!
or - change the header template, and provide a template that is missing the filter icon.

Ceolter. What about when a user resets the filter so that all filtering is removed? The filter icon should go away then.

user resets the filter so that all filtering => it is removed when no filter active.

floatingFilterComponentParams: {
  suppressFilterButton: true,
},


Presentation website shows the homepage text twice at first load

Step to reproduce :
1/ Open https://material.preactjs.com/ in a private navigation window
Expected behavior : show the homepage content once
See behavior : the content is shown twice
I suspect there's some service worker misconfiguration here
Attached video : https://www.youtube.com/watch?v=iopYx8VFxIg

This was fixed in a recent deployment. But shouldn't be happening in a private window.
Your you tube vid is not available

@prateekbh sorry for the video, i just switched it to unlisted.

it isnt really happening for me. can you close all incognitos and try again?

hmm i know where its coming from, will fix it tomorrow

should be fixed now. please check

Yes, issue fixed, nice :)


v0.14.0

What's New in cartopy 0.14
==========================

:Release: 0.14.0
:Date: 24th March 2016

Features
--------

* Zachary Tessler and Raj Kesavan added the :class:`cartopy.crs.Sinusoidal` projection,
  allowing MODIS data to be visualised in its native projection. Additionally, a
  prepared :data:`cartopy.crs.Sinusoidal.MODIS` projection has been made available for
  convenience.

* Joseph Hogg and Daniel Atton Beckmann added the :class:`cartopy.geodesic.Geodesic`
  class which wraps the proj.4 geodesic library. This allows users to solve the direct and
  inverse geodesic problems (calculating distances between points etc). It also contains a
  convenience function that returns geodetic circles. This is used by
  :meth:`cartopy.mpl.geoaxes.GeoAxes.tissot` which draws Tissot's indicatrices on the axes.

   |tissot|_

     .. |tissot| image:: examples/tissot_00_00.png

     .. _tissot: examples/tissot.html

* The SRTM3 data source has been changed to the `LP DAAC Data Pool
  <https://lpdaac.usgs.gov/data_access/data_pool>`_. The Data Pool is more
  consistent, fixing several missing tiles, and the data is void-filled.
  Consequently, the :func:`cartopy.srtm.fill_gaps` function has been deprecated
  as it has no purpose within the STRM context. The
  :ref:`SRTM example<examples-srtm_shading>` has also
  been updated to skip the void-filling step. Additionally, this data source
  provides SRTM at a higher resolution of 1 arc-second, which may be accessed
  via :class:`cartopy.io.srtm.SRTM1Source`.

* All downloaders will use secure connections where available. Not
  every service supports this method, and so those will use non-secured HTTP connections
  instead. (See :pull:`736` for full details.)

* Cartopy now supports, and is tested against, matplotlib 1.3 and 1.5 as well as
  numpy 1.7, 1.8 and 1.10.

* Daniel Eriksson added a new example to the gallery:

  |image_aurora|_

    .. |image_aurora| image:: examples/aurora_forecast_00_00.png

    .. _image_aurora: examples/aurora_forecast.html

Incompatible changes
--------------------
* :meth:`cartopy.crs.CRS.transform_point` now issues NaNs when invalid transforms are identified.

Deprecations
------------
* :data:`cartopy.crs.GOOGLE_MERCATOR` has been moved to :data:`cartopy.crs.Mercator.GOOGLE`.

Too fast for me :smile:


JFXDatePicker works on PC but doesen't work on Raspberry Pi

Hi guys, I'm recently making a JavaFX project on Raspberry Pi 2B with Netbeans and SceneBuilder. I work with jfoenix library because I think jfoenix library provides a beautiful interface allows me to interact with users.
The library perfectly work on my PC and  Raspberry Pi 2B except one thing ：I can't create a project with JFXDatePicker on Raspberry Pi. When I run the project on Raspberry Pi, it came out with a run time exception and said：
"java.lang.NoSuchMethodError:com.jfoenix.skins.JFXDatePickerSkin.getEditableInputNode()Ljavafx/scene/control/TextField;"
I can deploy any Jfoenix library on the project which I run on my PC, and I can also deploy any Jfoenix library(JFXButton, JFXColorpicker, ...etc) on the project which I run on my Raspberry Pi except the JFXDatePicker.
I appreciate in advance if anyone can tell me the reason and how to fix it.

Hello,
you need to update the java version on Raspberry Pi to Java 8 u66 or above, updating to the latest java version is recommended.
Regards,

Thanks for replaying.
I check my current  version and it says it's java 1.8.0_65.
But I try to update the java version by using the command "sudo apt-get install oracle-java8-jdk".
And it says that my java version is the latest version. I'm a little confused that  java 1.8.0_65 is not the latest version, but how come the result is that?
I try the method here(http://raspberrypi.stackexchange.com/questions/45976/how-do-i-update-java-8-in-raspbian) but it still doesn't work.
Is there any another way to update the java version on my Raspberry Pi?

Sorry, not sure how to update java version on raspberry pi.
this issue will be closed as its not related to JFoenix development.
Good luck with your project,


Remote Controller empty / blank page

Hi,
i set up a recent Koel 4.2.2 and everything works fine (last.fm, youtube integration, inotify watcher, ..) except the remote controller. Its page is just blank: https://music.leyghis.de/remote
i tested this from android and from different browsers. I also CURLed from localhost. The output page is the same blank page on all devices :-(
in 3.7.2 this worked well. I don't know what happened here since last upgrades. I cannot find any error in

browser inspector
apache log
Koels artisan log

does anybody has some idea where i could look for some errors and/or to fix this?
regards, Mario

Yikes! This is what you got for bad test coverage!

hi. this commit fixed the visibilty of the service but it throws an error in browser console now. It has to do with MIME type and CORS headers. I am not able to find the issue because it points to the option "nosniff" which i did not set at all.

curl -i https://music.leyghis.de/remote
HTTP/1.1 200 OK
Date: Fri, 27 Dec 2019 12:53:08 GMT
Server: Apache/2.4.29 (Ubuntu)
Strict-Transport-Security: max-age=63072000; includeSubDomains; preload
X-Frame-Options: DENY
Host: <IP_ADDRESS>:8000
Cache-Control: no-cache, private
Content-Type: text/html; charset=UTF-8
Vary: Accept-Encoding
Access-Control-Allow-Origin: *
Referrer-Policy: origin-when-cross-origin
Transfer-Encoding: chunked

I already played a lot the header vaules (removed all of them) but no difference

It works for me. Maybe check your adblocker?
Am Fr., 27. Dez. 2019 um 19:56 Uhr schrieb Mario Voigt <
<EMAIL_ADDRESS>
hi. this commit fixed the visibilty of the service but it throws an error
in browser console now. It has to do with MIME type and CORS headers. I am
not able to find the issue because it points to the option "nosniff" which
i did not set at all.
[image: grafik]
https://user-images.githubusercontent.com/5631071/71517938-a07b1f00-28b0-11ea-80ec-59d57c74be68.png
curl -i https://music.leyghis.de/remote
HTTP/1.1 https://music.leyghis.de/remoteHTTP/1.1 200 OK
Date: Fri, 27 Dec 2019 12:53:08 GMT
Server: Apache/2.4.29 (Ubuntu)
Strict-Transport-Security: max-age=63072000; includeSubDomains; preload
X-Frame-Options: DENY
Host: <IP_ADDRESS>:8000
Cache-Control: no-cache, private
Content-Type: text/html; charset=UTF-8
Vary: Accept-Encoding
Access-Control-Allow-Origin: *
Referrer-Policy: origin-when-cross-origin
Transfer-Encoding: chunked
I already played a lot the header vaules (removed all of them) but no
difference
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/1151?email_source=notifications&email_token=AB5O3UVKYG3DWXFJRABB7MDQ2X3PRA5CNFSM4J7PQT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXESBQ#issuecomment-569264390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5O3UX22D55X5B6FDZHZPDQ2X3PRANCNFSM4J7PQT2A
.

hi, i checked this from smartphone, a notebook and some regular tower pc. same behaviour with/without Antivirus browser integrations or Adblock Plus etc.

I've no idea really, as this doesn't have anything to do with cross-origin.
Am Fr., 27. Dez. 2019 um 20:26 Uhr schrieb Mario Voigt <
<EMAIL_ADDRESS>
hi, i checked this from smartphone, a notebook and some regular tower pc.
same behaviour with/without Antivirus browser integrations or Adblock Plus
etc.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/1151?email_source=notifications&email_token=AB5O3UXEFKIEHUWTX4WRTI3Q2X7BBA5CNFSM4J7PQT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXFY3I#issuecomment-569269357,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5O3US3265MO67TFVM62DDQ2X7BBANCNFSM4J7PQT2A
.


Not fully compatible with Windows 11 Pro 22H2. Throbber missing on boot screen.

OS: Windows 11 Pro
Version: 10.0.22621 (22H2)
Build: 22621.1992
Motherboard: B550M PRO-VDH WIFI (MS-7C95)
Installing a custom boot logo causes the throbber on the boot screen to disappear. Uninstalling HackBGRT doesn't fix the issue. HackBGRT used to work perfectly fine until I installed a Windows update about two weeks ago. I don't recall what version of Windows worked fine with HackBGRT.

Nevermind. I restarted my PC, & the throbber returned. Note, this was an issue for me on Windows 11 Pro N, but I did tinker with the registry & other settings. So that was probably my fault. After clean installing the normal Windows 11 Pro, I thought HackBGRT was giving me the same issue, but that is not the case so far.

The issue has returned. I don't know why. Today, the throbber is just gone.

HackBGRT doesn't do anything for the Windows boot loader or the throbber. If the problem occurs even after uninstalling HackBGRT, then it is not caused by HackBGRT.


Download Videos and Images feature request

I use the PurgeSpace_ModeEx with Min Space % set at 15%, I’d like to be able to select certain files within ‘Download Vidros and Images’ with a ‘keep’ feature so that as files are getting deleted as more files are added it doesn’t delete the files I’ve selected to be kept.

Interesting idea. I'll look into it.
It may be possible to do this by having a keep button which sets the files to read only.

Selected files can now be locked or unlocked. Locked files are read only and can't be deleted or purged. Locked files do not have the little delete icon on their thumbnail.

Thanks Robert


sinkcores/outputcore: extract default core into a Sink

Current dependencies on/for this PR:

main

PR #18   👈

PR #19

This comment was auto-generated by Graphite.

Codecov Report

Merging #18 (4573a15) into main (ecda81b) will decrease coverage by 0.18%.
The diff coverage is 14.70%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   57.32%   57.14%   -0.19%
==========================================
  Files          14       15       +1
  Lines         539      546       +7
==========================================
+ Hits          309      312       +3
- Misses        223      226       +3
- Partials        7        8       +1

Impacted Files
Coverage Δ

init.go
0.00% <0.00%> (ø)

internal/globallogger/globallogger.go
19.04% <0.00%> (+3.95%)
:arrow_up:

sinks_output.go
0.00% <0.00%> (ø)

logtest/logtest.go
77.14% <71.42%> (-1.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecda81b...4573a15. Read the comment docs.


Changed FlowableFluid getVelocity method name to getFlowDirectionVect…

Changed FlowableFluid getVelocity method name to getFlowDirectionVector. Changed the argument in the same method with name state to mainFluidState. Also added a documentation for the method. This method tells the game the direction a fluid should flow by evaluating the level of other fluid blocks around it. It returns a 3D vector with numbers -1 OR 0 OR 1 for each component of the 3D vector to indicate what direction the fluid should flow towards.
I thought about using just getFlowDirection, but given that Direction is already a class that indicates something else, I went with getFlowDirectionVector to indicate in the name it returns a vector and not a Direction object. It is still a vector that is used to know the direction of flow from a fluid, but it's not a Direction object.
state I changed to mainFluidState to make it more clear in the code from the method that the variable holds the FluidState whose direction is desired since the method creates 2 other FluidState objects inside of it to make the calculations of flow direction.

I just committed the suggestions.

It returns a 3D vector with numbers -1 OR 0 OR 1 for each component of the 3D vector to indicate what direction the fluid should flow towards.

This might be good to include in the javadoc


Add multiple radio buttons warning to docs

Add a warning to the docs discossed in related issue: https://github.com/wearebraid/vue-formulate/issues/434#issuecomment-890815492

@justin-schroeder I've added a warning. Please take a look. I hope, I got the formatting right.


Create abc base class

[ ] Decide what will be passed into every class
[ ] Transform inside or outside?
[ ] Maybe ModelResults should be completely separate

X_test and X_train should have the same columns and feature names?
So I need to input X_test and y_test, y_pred, y_probs, model, and transformer...
In the base class???


Ability to add pre-planned routined schedule delivery in Task Scheduler

Feature request
Status
Blocked by open-rmf/rmf_ros2#103.
Description
Adding this feature request here based on Morgan's advice.
Have additional options for task creation to specify tasks that need to be repeated, or start on a condition other than time. The task overview should also be able to reflect these details as well as allow for editing.
Implementation considerations
'Task->Task Scheduler' additional options should include:

At a specific time
At a specific time on a daily schedule
At a specific time on a weekly schedule
At a specific time on a monthly schedule
At a specific time on a monthly day-of-week schedule
OPTIONAL When a specific event occurs (i.e. start, end of another task)

Scheduled task overview list 'Task->Overview' should include:

The schedule of the task should also be indicated
Allow for edits to change the schedule
Allow for enabling/disabling
Deleting tasks

Additional information
Could emulate existing task scheduling interfaces or alternatively look at clock (alarm) apps on the phone for the execution of the implementation flow.

@codebot this is just a mock, but I think we cover all the cases with the following UI (except When a specific event occurs (i.e. start, end of another task)) .

Any feedback is welcome =)

This can be achieved using the task scheduler now


fix: upgrade to version 3.0.444

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
76931a252dd002b5263048e26f06ba5a4877cb65
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
76931a252dd002b5263048e26f06ba5a4877cb65
link
/test gsm

vault
76931a252dd002b5263048e26f06ba5a4877cb65
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Installing the fsharp power tools before installing adding VS2015 update 1 breaks Roslyn

Hi guys,
You are probably aware of this:  https://sergeytihon.wordpress.com/2015/12/01/how-to-restore-viual-studio-2015-after-update-1-dependency-dance/
It turns out that, when the Visual F# Power Tools are installed they write to the real devenv.exe.config
It turns out ... and it would be fair to say I didn't know this either ... writing to the devenve.exe.config file interferes with the visual studio teams ability to service that file in updates.
Here is a thread discussing the navigation bar:  https://github.com/fsprojects/VisualFSharpPowerTools/issues/37
Here is the PR that causes the problem: https://github.com/fsprojects/VisualFSharpPowerTools/pull/210
There is a devenv.exe.config that is generated when VSIXs are installed.  The contents of this app config file are merged with the devenv.exe.config file when devenv is started.  So that is the right place to make the changes.
However ... that file is regenerated whenever a VSIXis installed and so just adding the line, will not be a permanent solution.  I am trying to find out from the VSIX engineering team, what the correct solution is for you.
Thank you for your patience.
Kevin

I think the correct solution is to make it a proper Visual F# Tools setting and remove the devenv config messing out from VFPT.

I think that would be a good choice.

We're more than happy to remove Navigation Bar when Visual F# Tools accommodate it. Changing devenv.exe.config is error-prone and more trouble than it's worth.

Okay I have opened an issue on visual# tools:  https://github.com/Microsoft/visualfsharp/issues/786
It says this:
We need an alternate mechanism to enable these features:
// App.config keys for determining whether not-shipping features are turned on or off
// Edit devenv.exe.config and place these at the end.
//
//
//
//
//
Because of this design the powertools who used this feature correctly, happened to cause VS update 1 to do bad things to people who use Dev 15 and the PowerTools.

:+1:


Remove max_depth constraint from plugin listing/caching

update @plugin_cache so that it always changes whenever any addition/edit/removal of plugins occurs (including touch PLUGINS_DIR)
remove max_depth flag from download_plugin(), for consistency with how list_plugins() searches infinitely deep, if necessary, to find plugins

Closing in favor of https://github.com/voxel51/fiftyone/pull/3732


Running demo notebook on MyBinder

I had a quick go at trying to run this repo, and in particular the ffmpeg-numpy.ipynb notebook, using MyBinder, and it seemed to work with the following setup:

rename requirements.txt to eg requirements-dev.py
create requirements.txt containing:

matplotlib
pillow
graphviz

create apt.txt containing:

ffmpeg
graphviz

It would probably be cleaner to put these files into a binder/ directory (as per Mybinder docs) but then I don't think the ffmpeg setup.py would run unless you called it with a correct path from a binder/postBuild file?

Neat idea. I've been meaning to try Mybinder out. Will try to run through the above steps soon and see how it goes.


ec2metadata and build.properties are missing in the project source

Please find the classes where we are using these references.
1)BrokerStatsRetriever -> Process process = Runtime.getRuntime().exec("ec2metadata");
2)OstrichAdminService -> properties.load(this.getClass().getResource("build.properties").openStream());
Also want to know if anyone able resolve the following issue related to OpenTSDB.
com.pinterest.doctorkafka.util.MetricsPusher - Failed to send stats to OpenTSDB,

@BrianGallew Are you able to see Kafka cluster metrics on DoctorKafka UI. It would be a great help if you can provide your help on the following.

copy of doctorkafka.properties file. Attached doctorkafka properties file for your review.
confirm your kafka version and doctorkafka versions which are working for you.
where are the topics (metrics- brokerstats, action - operator_report) are configured  same kafka cluster or different kafka cluster.

Thanks in advance.
doctorkafka.properties.txt

@venkatwilliams  could you tell if the issue is resolved, or you are still blocked?


Added config option to toggle showing the slot destroy button

It is way too easy to accidentally click this button while trying to change the transform of a slot. Even worse is that the destroy button is not undoable, so if you click it you cannot get the slot back unless you saved it. Currently the way to avoid this button is to disable all direct action buttons, but you probably lose access to other useful buttons by doing that. Therefore an ideal solution is the introduction of a config option which can toggle showing the destroy button.

Not sure why the code formatting got messed up :(
Looks like somehow tabs and spaces got mixed.

i understand the usecase but would rather implement a generic solution. maybe we could have a string config option where the user create a regex to select what delegates to hide. each delegate's string that's evaluated with the regex should in include the type of any argument if there is one, the fully qualified name of the delegate's type and the method name.

Yes this would be more powerful although would be difficult for some people to use who don't know regex. Do you have any idea what an example regex string would look like for this?

Would it not be sufficient to provide a string like "Slot.ResetPosition`2[IButton, ButtonEventData]" to filter buttons?
I think something like this would be a lot easier and more accessible than regex.

Slot\.ResetPosition2[IButton, ButtonEventData]would be a valid regex string, the power of regex is it allows for more general selectors likeSlot.*and handles situations where people have a list with something like(Slot.ResetPosition2\[IButton, ButtonEventData]|Slot\.ResetRotation2[IButton, ButtonEventData])` there are many regex building tools online such as retool's regex generator


Can one system log in and other systems log in automatically

For example, there are three systems A, B and C，After the user successfully logs in to system A，system B and system C also log in automatically

@hanpenggit i can't fully understand what you mean, could you please elaborate

for two systems: A and B, when the user log in A by sso, change the website to system B, the user can auto log in B without redirecting to sso

@hanpenggit  See: https://casdoor.org/docs/how-to-connect/single-sign-on


Installation instructions

Hello,
Is there a step by step manual to install traccar on Ubuntu Server 16.04 LTS please ? From the official website, I understand it doesn't take more than the following 2 lines:

Run traccar.run (sudo ./traccar.run)
Start daemon (sudo /opt/traccar/bin/traccar start)
However, I would like to know which environment is required (apache2 ?) ? Should I also install mysql-server ? Any version of JDK will go ? V8 is okay ?
Or does it only needs to run traccar.ru + start daemon ?
Thank you for your feed-back
Poobaisle

Java version 7 or higher is required. If you don't have it, installer will tell you. No other dependencies, so you don't need Apache or anything else.
By default Traccar uses embedded database. If you want to use it with MySQL, you need to read following instruction (after installing Traccar):
https://www.traccar.org/mysql/

Thank you ! What are the advantages of using it with MySQL ? Does it give more flexibility ? Afterward, I want to add the web interface from Traccar Web UI because I need to generate the kind of reports I could find on his demo server. I guess, it means I need to shift to MySQL isn't it ?

MySQL is recommended for any production server. Default embedded database is not designed to handle large amounts of data. If by Traccar Web UI you mean the project from Vitaly Litvak, it can work on any database as far as I know.

Yes, I meant the project from Vitaly Litvak. Then, I will try first with the embeded database. What is considered to be large amounts of data please ? A fleet of 50 vehicle would fit into the embedded database ? thank you

For anything more than a couple of devices, I would not recommend to use embedded database.

Thx. I'll follow your recommendation then.


Add code support for cheaper IMU solutions

We are currently using BNO boards that cost around 15€ each and needing 6 per glove.
There is an existing board we can use to develop the code for the project:
https://oshwlab.com/neosquared2002/MultIMU-Module-for-SlimeVR
I didn't find an off the shelf board that includes a BMI270 and magnetometer, but please share if you know where to get them so development is faster.

https://oshwlab.com/neosquared2002/MultIMU-Module-for-SlimeVR was deleted in the meantime.
SlimeVR already has some code for the next IMU I want to use, the ICM-20948, will focus on porting that next.


Install python3-dev when not using python2

By default, ubuntu-based distros would install python2-dev if you install python-dev.
The package python3-dev should be installed explicitly if we're not using python2.
I've encountered this problem in two cases:

When spinning up a new distro and starting a cookiecutter-django project with python2="no"
When cookiecutter-django in a distro where python2-dev is already installed, but I've selected the option python2=no

Many thanks @bloodpet!


Use uv sync & uv run in docs build

Description
The offical RTD guide was written a few months ago and I realised after merging https://github.com/cookiecutter/cookiecutter-django/pull/5438 that we can in fact simplify a bit more.
Also upstreamed these changes to RTD: https://github.com/readthedocs/readthedocs.org/pull/11655
Checklist:

[ ] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
[ ] I've updated the documentation or confirm that my change doesn't require any updates

Rationale
Simpler build steps

I would expect the --no-dev and --frozen parameters here

Good point! Fixed

Forgot that we don't have dev dependencies xD
Will add some soon ;)


When resized to small mobile device the top right side logo cannot be clicked

Why is that? This is for Chrome, I am not sure about the other browsers...

Thank you for reporting this. I'm going to look into it.


[User Interface: Redesign]: Display of Resource Catalogs

Issue Name
Display of Resource Catalogs
Issue Description
Five Resource Catalogs have now been ingested from the DDE. Based on previous work involving the ComputationalTools and discussions with the NIAID team, we expect the Resource Catalogs to roughly be displayed as follows:

The terminology to be used for the subterm is expected to be the value of the collectionType field
To be determined:

The best term for the Term in this image (Other? Resource Catalog? Resource? Source?)
The color of the bar (same as Datasets? different color than Dataset? Was this previously discussed for ComputationalTools?)
UI changes to enable filtering for just ResourceCatalogs? Note: split this out to a separate issue if this is expected to involve more extensive work (eg back-end changes other than simple API queries, UI testing). If this was previously enabled for ComputationalTools (and the implementation had previously been user tested, feel free to proceed based on the previous implementation
Display of additional ResourceCatalog-specific fields in the record view (eg - collectionSize). Note, collectionSize is a recommended (rather than required) field so it's possible this field will have no values for a record.

Next steps:

[x] Generate Lyssna tests as needed to address above uncertainties (No need to do a G-doc write up for the test, just create a GH issue for it using this template. Assigned to @EmilyHaag as some of the aboved TBD content may already have been tested or just accepted by the NIAID team for ComputationalTools. If so, no need to retest.
[x] @EmilyHaag @leandrocollares Conduct Lyssna test and analyze results
[x] @candicecz Create mock ups based on results of Lyssna tests
[x] @candicecz For easily reverted changes, move to staging. If changes are not easily reverted, @gtsueng to seek NIAID approval first before moving to staging
[ ] @gtsueng Seek NIAID approval to move to production

Issue Discussion
This issue was discussed at the bi-weekly meeting dated 2024.01.30
Mockup URL
No response
WCAG Compliance Check

[ ] The ui changes are not expected to significantly affect WCAG compliance (ex- wording changes)
[ ] The ui changes have visual elements which have yet to be tested for WCAG compliance
[ ] The ui changes have visual elements which have been tested for WCAG compliance
[ ] The ui changes have passed all checks for WCAG compliance

Related WBS task

https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/53
https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/11
https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/12

For internal use only. Assignee, please select the status of this issue

[ ] Not yet started
[ ] In progress
[ ] Blocked
[ ] Will not address

Status Description
No response
UI change status check list

[ ] This ui change has yet to be discussed between NIAID, Scripps, Leidos
[X] This ui change has been discussed/reported between NIAID, Scripps, Leidos
[x] This ui change has been mocked up
[ ] This ui change has been implemented on Dev
[x] This ui change has been approved for Staging
[ ] This ui change has been implemented on Staging
[ ] This ui change has been approved for Production
[ ] This ui change has been implemented on Production

The following feedback was provided on the Resource Catalog search results view in staging on 2024.03.05 during the ODSET in person meeting:

It's still unclear what the difference is between Resource Catalog and Dataset. Please provide a simple alt text definition to make it more clear.

Adding alt text to the 'Type' term on the filter can help the user to know to look there to filter for types.

In terms of a definition...

Schema.org uses the following definition: "The schemas are a set of 'types', each associated with a set of properties. The types are arranged in a hierarchy." Which is rather uninformative for anyone unfamiliar with schemas.
Bioschemas provides the following defintion: "Schema.org provides a way to add semantic markup to web pages. It describes ‘types’ of information, which then have ‘properties’. The types are things that we can talk about and the properties are the things that we can say about the type." Which is more informative, but too verbose

For the NIAID Data ecosystem, something short but succinct would be best. Maybe something like:
"The type of metadata record available in the NIAID Data Ecosystem"

Here's the definition of Type from Dublin Core: "Type is used to categorize the nature or genre of the content of the resource"... it's probably the briefest available definition available that makes sense.

This type definition has been added to the staging  and production  instance.

I am marking this issue as Pending close out. If there are no further comments on this issue within the week, it will be closed.


[html] auto remove closing-tag

When editing markup language files like HTML, XML, JSX, if I type / before opening tag's > of an empty element (clearly I want to make it self-closing), then I want VSCode auto-removing the closing tag.
For example, If I type / on <Foo |></Foo> (assuming | is the cursor), then I want <Foo /> rather than <Foo /></Foo>
There are already 'expanding' content assistant features like Emmet, why not a 'collapsing' content assistant features like this, if neccessary.

That's an interesting idea. I would be great if an extension author can implement it so we can get some experience with it.


update CI matrix for supported Python versions

xref: https://github.com/pysal/esda/issues/310
Drop 3.9 -- Add 3.12

Python 3.12 added


solc.compile_source() Failed

py-solc Version: 2.1.0
solc Version: 0.4.21 (here is solcjs)
Python Version: 3.5.4
OS: linux(ubuntu)

What was wrong?

My commands:

Install solc:  npm install -g solc
Install py-solc: pip3 install py-solc
Use solc in python3:
from solc import compile_source
compile_source('pragma solidity ^0.4.0; contract A{ funcion A() public{}}')

Details:

Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.5/dist-packages/solc/main.py", line 106, in compile_source
stdoutdata, stderrdata, command, proc = solc_wrapper(**compiler_kwargs)
File "/usr/local/lib/python3.5/dist-packages/solc/utils/string.py", line 85, in inner
return force_obj_to_text(fn(*args, **kwargs))
File "/usr/local/lib/python3.5/dist-packages/solc/wrapper.py", line 165, in solc_wrapper
stderr_data=stderrdata,
solc.exceptions.SolcError: An error occurred during execution
command: solc --combined-json abi,asm,ast,bin,bin-runtime,clone-bin,devdoc,interface,opcodes,userdoc
return code: 1
stderr:

stdout:
Must provide a file

Cute Animal Picture

put a cute animal picture here.

There is a typo in your solidity snippet.  Missing the T in function.  Should be:
compile_source('pragma solidity ^0.4.0; contract A{ function A() public{}}')

Although "Must provide a file" is a confusing error message for a failed computation.

Its possible that @ajax-2 hit another issue before hitting the syntax error.  When I ran the example snippet I got:
        <stdin>:1:46: Error: Expected token Semicolon got 'LParen'
pragma solidity ^0.4.0; contract A{ funcion A() public{}}

I am using the apt packaged solc. Im wondering if the version of solc installed by the npm package is different than the regular solc binary. I also thought that the npm solc command was "solcjs", which definitely does behave differently.

@dylanjw  I'm sorry that My contract's code is error. I know what does my problem cause. My solc is not complete, Because solcjs cannot adapt to py-solc. I uninstall my solcjs and install it with "apt-get install solc", now, I can use py-solc normally. thanks!! your reply is very useful!

Glad I could help!


refactor and fix test cases for mrw

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

It makes me very nervous to change tests to GA Core components. The reason for this is that the tests are validating behaviors we have a contract with customers that we will not make breaking changes to, and it's not clear to me how we can be certain that we won't accidentally change the tests in a way that allows us to introduce regressions for things that were previously validated. I'd like to work with the Core v-team to establish best practices on this topic before moving forward with changes to tests in either Azure.Core or System.ClientModel test projects. My proposal is that we adopt a policy where we don't make changes to tests unless one of two cases holds: 1) We find a bug in the test or 2) we decide to change the functionality the test is validating.
If we think we have a set of tests that needs to change with some degree of regularity, I'd love it if we could take a step back to ask why. Specifically:

What unit test coverage do we have of the Core component?  Is it complete?
If the tests that need to change are scenario tests, should they live in Core at all?

There is a philosophy of tests that says every test should validate one specific behavior of a component. If we could clarify the type and behaviors of the Core components that these tests are testing, I think it might make it easier to understand the risks/tradeoff around changing tests of ModelReaderWriter.

I cannot answer your question here in general. But this PR contains two parts: refactor the test case code and fix some test cases.
I was introducing some of the test cases here to the generator part to make sure the generator is generating those models that could meet the requirement of MRW, during which I noticed some of the test cases are not quite simple to maintain.

We are building up strings to get the expected result. I changed them to use JsonSerializer along with anonymous objects (see this comment).
since the purpose of the "roundtrip" test cases, are validating if the serialization and deserialization could be roundtrip, where roundtrip means if the JSON is the same, and the JSON string, I believe does not have to be identical. Therefore I changed the way of validating the result (see this comment). The test cases here might be OK unchanged (because they previously could pass), but since the generator side, we generate those models and the sequence of writing properties is slightly different, I have to change the sequence of the "expected result" a lot, which is too cumbersome to maintain therefore I change the way of validating results.

Above are the "refactors" introduced by this PR.
The fixes I want to introduce in this PR is for this case:

The AvailabilitySetData model is not fully implemented therefore we are not fully validating the roundtrip case for it: https://github.com/Azure/azure-sdk-for-net/pull/41055/files#r1446813585
This might be depending on how the interfaces are implemented but we should align with other test cases and the implementation here: https://github.com/Azure/azure-sdk-for-net/pull/41055/files#r1444159093

I also think, all those test cases I am changing, the serialization and deserialization tests and the roundtrip validations, they depend on how the model implements the interfaces we introduced in this library. Would it be a test issue if the model for test is not properly implemented as the purpose indicates? For instance, the implementation of AvailabilitySetData model is not implemented with the serializedAddtionalRawData therefore it could never be roundtrip in a row of deserializing and then serialize.