Can't change remoteHost once set

It would seem that once the IP of the Roku device to which you want to send remote keypresses to is set, it is then impossible to update it.
This is due to the value being stored as a memento (remoteHost) in the workspace database (stored in state.vscdb), and once set the function
getRemoteHost will always use that value regardless of the settings parameter (e.g. "brightscript.remoteControl.host":"<IP_ADDRESS>")
Using SQLite browser it is possible to update the value, and this new  value is then used by the extension.
e.g.
{"rokuAutomationAutorunOnDeploy":true,"rokuAutomationConfigs":"{\"configs\":[{\"name\":\"DEFAULT\",\"s0teps\":[]}]}","remoteHost":"<IP_ADDRESS>","rokuAppOverlays":[]}
Perhaps a solution would be to always use the value from the VSCode settings, and if the value is ${promptForHost} show the input and then overwrite the setting with whatever the user entered?

We definitely need some improvements in this area. Our ultimate goal is to implement a proper "Default/Active Device" feature (outlined in https://github.com/rokucommunity/vscode-brightscript-language/issues/506).
But to your specific point right now, I believe that value will change if you sideload to a different device. If I remember correctly, it will always overwrite the value with whatever device was most recently sideloaded to.

That feature sounds great.
In my use case I'm not sideloading so the value is never overwritten, but I see your point :)

Until we get the time to properly implement #506, would you be interested in submitting a PR that adds a menu option to the device list that would switch that internal value. Something like this, with maybe a title like "Set as active device":

I think you'd need to add a new entry in that devices list here:
https://github.com/rokucommunity/vscode-brightscript-language/blob/dd4bc9c22bb3f3788a1130cbde4779c86c2e746d/src/viewProviders/OnlineDevicesViewProvider.ts#L126
And then add the command in https://github.com/rokucommunity/vscode-brightscript-language/blob/master/src/BrightScriptCommands.ts that would set the value like we do here

I'll take a look and see what I can do.

Trying to setup a build environment using
mkdir RokuCommunity && cd RokuCommunity && git clone https://github.com/rokucommunity/vscode-brightscript-language && cd vscode-brightscript-language && npm run install-local
And getting a 404 :(
npm error code E404
npm error 404 Not Found - GET https://artifactory.tools.roku.com/artifactory/api/npm/roku/roku-test-automation/-/roku-test-automation-2.0.10.tgz
npm error 404
npm error 404  'roku-test-automation@https://artifactory.tools.roku.com/artifactory/api/npm/roku/roku-test-automation/-/roku-test-automation-2.0.10.tgz' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.

Next:

open the vscode-brightscript-language folder in vscode
in the debug panel, choose the "Extension" debug configuration from the drop-down
press F5 to start debugging
vscode will open a NEW vscode window with the [extension host] name in the title. This vscode window has a live version of the current local complied copy of the vscode extension.

Okay, getting further :)
In the second VSCode running the BRS extension is showing but after a while it gives the following error:
Activating extension 'RokuCommunity.brightscript' failed: vscode.workspace.workspaceFolders is not iterable.
Any ideas?

Does it give you a stack trace? You can find that in the debug panel of the non [extension host] window. Does it happen with the code directly from master or was this an issue introduced by your new code?

I thought much the same so I did revert the code, but behaves the same
Debug Console
vscode-custom-css is active!
Application directory c:\Users\spoyser\AppData\Local\Programs\Microsoft VS Code\resources\app\out
Main HTML file c:\Users\spoyser\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\code\electron-sandbox\workbench\workbench.html
Git installation not found.

Call Stack

Behaved exactly the same.
Thought maybe it was a windows thing so tried again in Linux and got this error again when I tried the npm install
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package<EMAIL_ADDRESS>npm warn EBADENGINE   required: { vscode: '^1.57.0', node: '^12.12.0' },
npm warn EBADENGINE   current: { node: 'v20.17.0', npm: '10.8.2' }
npm warn EBADENGINE }
npm warn deprecated<EMAIL_ADDRESS>This is a stub types definition for chalk (https://github.com/chalk/chalk). chalk provides its own type definitions, so you don't need @types/chalk installed!
npm warn deprecated<EMAIL_ADDRESS>this library is no longer supported
npm warn deprecated<EMAIL_ADDRESS>This package has been renamed to @vscode/debugprotocol, please update to the new name
npm warn deprecated<EMAIL_ADDRESS>Please upgrade to 2.3.7 which fixes GHSA-4q6p-r6v2-jvc5
npm warn deprecated<EMAIL_ADDRESS>This package has been renamed to @vscode/debugadapter, please update to the new name
npm warn deprecated<EMAIL_ADDRESS>16.1.1
npm error code E404
npm error 404 Not Found - GET https://artifactory.tools.roku.com/artifactory/api/npm/roku/roku-test-automation/-/roku-test-automation-2.0.10.tgz
npm error 404
npm error 404  'roku-test-automation@https://artifactory.tools.roku.com/artifactory/api/npm/roku/roku-test-automation/-/roku-test-automation-2.0.10.tgz' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
npm error A complete log of this run can be found in: /home/spoyser/.npm/_logs/2024-09-22T13_04_13_288Z-debug-0.log

Not sure if this is relevant?

@triwav this looks like it might be an issue with rta. Any thoughts on why it's failing to install?

@spoyser it appears that you're using artifactory as some type of middleware package management suite. Can you check with that team to see if they're blocking packages with the word "roku" in it somewhere? Or can you try bypassing using artifactory instead to see if it will work with that removed from the equation?

npm error 404  'roku-test-automation@https://artifactory.tools.roku.com/artifactory/api/npm/roku/roku-test-automation/-/roku-test-automation-2.0.10.tgz' is not in this registry

Ah yes I see that, although that is only on the Linux environment.
Still doesn't explain the issue I'm seeing on Windows (I assume it should work on Windows?):
Activating extension 'RokuCommunity.brightscript' failed: vscode.workspace.workspaceFolders is not iterable.

Hmm, I'm not sure why it would be failing with that message. I work on this project almost exclusively on windows and haven't seen this issue before. Would you be open to chatting more about this on our RokuCommunity slack? (I'm @Bronley Plumb )

I'd love to help you get this issue unblocked,

Hey @spoyser I think I found the issue and resolved it. I have no idea why this issue was happening only sometimes, but it started happening randomly to me today so I was able to fix it and then ensure it was resolved.
Can you pull latest from the repo and try again? Also, thank you so much for your patience.

@TwitchBronBron
That's great news, I'll give it a whirl and let you know how I get on (I was gonna contact you via Slack but been snowed under for that last week)

All done, I added a clear active device for a particular use case of mine too.

I’ve been thinking about this a bit more and IMO the remoteHost setting in the settings file should be removed.
There is no benefit to setting it except for the very first use, where it would save you have to enter it in the input box. But once the value is in the VSCode database this setting has zero effect and in fact is just confusing because it has no effect.
I think it should be removed and the code always prompt fir the value if it is currently not set in the database, this works well in conjunction with the clearActiveHost command I added (which can easily be bound to a key-press)

I think it should be removed and the code always prompt for the value if it is currently not set in the database

I mostly agree with you. However, I'm hesitant to remove it, just for legacy purposes at the moment. I think once we get into actually implementing #506 , we can eliminate the setting then.


AOP requires registration in two places

This may be "working as advertised", but it seems a bit weird.
Resource classes need to be registered with Jersey (through the ResourceConfig, either individually or via packages()). If they are registered with Guice only, they don't show up as endpoints (ie, they are 404). However, they don't need to be registered/bound separately with Guice to receive Guice injection.
However, in order to receive AOP, resource classes must also be registered/bound with Guice.
Is there a way to make registration necessary only in one place, either with Guice or with Jersey? It's almost there, it just doesn't seem to work with AOP. FWIW I don't care if it's Guice-side or Jersey-side that requires registration/binding.

I guess i am get 404 as I have not registered explicitly registered services with Jersey through ResourceConfig
I get 404 for all REST endpoints
I think With Jersey 1.x "com.sun.jersey.guice.spi.container.servlet.GuiceContainer" did the registering part. Do we have anything equivalent of this?

Is this still an issue?

Any solutions to this? I'm having the same issue.

Ahh, this fixed it for me:
https://github.com/Squarespace/jersey2-guice/wiki#aop-with-guice
Force HK2 to use Guice by using explicit bindings for those classes, and also remember to change the @Inject annotation on the constructors in those classes to use com.google.inject.Inject.


Refactor Writer and Publisher, and add a Util class for publishing Kafka audit counts

Break BaseDataPublisher.publishData() and AvroHdfsTimePartitionedWriter.write() into smaller methods, so that they can be reused by subclasses.
Added a class SerializationUtils which serializes and deserializes an object to/from Strings using charset ISO_8859_1. This is used to transfer Kafka audit count objects from Writers to Publishers as a config property.
Added a method in AvroUtils for converting GenericRecord into byte array.
Some other small changes.

@liyinan926 can you take a look?

@liyinan926 updated.

LGTM.


Remove unnecessary setting in tsconfig.json

strict includes noImplicitAny,  noImplicitThis, and strictNullChecks.
https://www.typescriptlang.org/docs/handbook/compiler-options.html

Coverage remained the same at 100.0% when pulling 5dcb2dc210085607ee64904282d6666a9bfb9dea on 38elements:tsconfig into 40a696f4c565d5dbcfb4e1c90fffe91d1e125486 on developit:master.


Dropdown click not working

I wanted to share one small issue in our main page(www-site) navigation bar.
So in the navbar's dropdown my profile link click is only working when clicking on the text. In hovered area click is not working (image for reference).

PS - For sign out it is working.

I would love to work on this issue, can you please assign me?

Can you assign this issue to me

can you assign this to me ?

I would like to work on this issue.

I would like to work on this issue.

Sorry @prerana1821 it's first come first serve basis so assigned to @crater90 .


feat(on-slide-moved): add on-slide-moved expression to slideBox

Hello,
kuwabarahiroshi already tried to add an on-slide-moved callback here: https://github.com/driftyco/ionic/pull/2766
There was no new comment since 2 months, so i decided to make a similiar pull request. I'm passing the currentSlide, the targetSlide and a paramenter for the relative Position between the currentSlide and the targetSlide. This parameter is a float value between 0 and 1. I would love to see it in the Ionic core, because it allows, for example, to easily add slidingTabs to the slideBox, like i'm doing it in this example: http://knorr.ruhr/ionic/
In a future pull request i would add an directive that brings the native Android sliding Tabs(from Material Design Sepcs) to ionic.
That these sliding Tabs are wished you can see here:
http://forum.ionicframework.com/t/ionic-sliding-tabs/18917
I'm sure you want me to add some unit test, but i couldn't find a similiar unit test for the on-slide-changed expression (for example). So i just added an example to the HTML tests, where you can see the behaviour of the feature in the console.

Slidebox is such a mess right now, I'm hesitant to add much to this implementation.
That said, I don't know when I'll be able to get around to fixing it and this is a potentially useful addition.
A few things, though. First, this would fire a lot. I'd like to take extra steps to limit how much of an impact it'd have on people who don't use the feature. I think the logic in sliderView.js could be made to be one line, no conditional, and have it all wrapped in a condition that checks to see if onSlideMoved is set, which could further simplify the new unified expression.
Secondly, could you shorten up the description?
Lastly, thanks for the HTML test. We'll need unit tests though. I can help if there appears to be demand for this and no one's able to add them though.

What are the plans around slidebox if it's currently a mess?

Hello! Thanks for opening this PR! We really appreciate it! As slidebox has been deprecated since this pr was opened i will be closing this PR. Feel free to contribute more in the future!


[Question] Project roadmap and timeline

First of all, I would like to say how great this framework is. It's one of the most beautiful, functional, yet simplistic frameworks I have used. I'd just like to know, and I'm sure, many of the users would too, what is the planned release time for v1.2 and beyond? I do understand you are working on this alone, and I appreciate all your effort!

I'm always a bit hesitant to give out exact dates, because everything takes a bit longer than what I expect, especially when polish is involved. The progress has been quite steady so far in the last 20 days or so, so I have high hopes that the new update will come soon hopefully. Thanks, and yeah, I am working on this alone.

Any updates on this? Or is this now a dead project?


Admin client config working for kafka cli tools doesn't work for julie

Describe the bug
I've created a kafka admin client properties file. This file works perfectly with kafka-topics and the other kafka cli tools. If I pass julie the very same properties file the SSL handshake fails.
To Reproduce
Steps to reproduce the behavior:

Setup a kafka cluster with self-signed TLS certificates.
create an admin client config file:

$ cat /etc/kafka/secrets/topology-builder.properties
security.protocol=SSL
ssl.keystore.location=/etc/kafka/secrets/kafka.keystore.jks
ssl.keystore.password=<my_secret_password>
ssl.truststore.location=/etc/kafka/secrets/kafka.truststore.jks
ssl.truststore.password=<my_secret_password>
ssl.endpoint.identification.algorithm=

test the admin client config with kafka-topics:

$ kafka-topics --bootstrap-server <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093 --command-config /etc/kafka/secrets/topology-builder.properties --list
[2021-03-25 14:31:02,673] WARN The configuration 'schema.registry.url' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
[2021-03-25 14:31:02,674] WARN The configuration 'ssl.truststore.location' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
[2021-03-25 14:31:02,674] WARN The configuration 'ssl.keystore.password' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
[2021-03-25 14:31:02,674] WARN The configuration 'ssl.keystore.location' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
[2021-03-25 14:31:02,674] WARN The configuration 'ssl.truststore.password' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
[2021-03-25 14:31:02,674] WARN The configuration 'ssl.endpoint.identification.algorithm' was supplied but isn't a known config. (org.apache.kafka.clients.admin.AdminClientConfig)
__consumer_offsets
_confluent-command

create a dummy topology file:

$ cat /tmp/ansible.u353lgc6/app.yaml
---
context: "playground"
projects:
  - name: "my-project"
    topics:
      -
        name: demo
        config:
         replication.factor: 3
         num.partitions: 10
...

run julie using the admin config file and the topology file:

bash-5.1$ julie-ops-cli.sh --clientConfig /etc/kafka/secrets/topology-builder.properties --brokers <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093 --topology /tmp/ansible.u353lgc6 --dryRun
[INFO ] 2021-03-25 14:29:42.896 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093
[INFO ] 2021-03-25 14:29:42.896 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093
log4j:WARN No appenders could be found for logger (org.apache.kafka.clients.admin.AdminClientConfig).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
[ERROR] 2021-03-25 14:29:46.362 [main] TopologyBuilderAdminClient - java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
[ERROR] 2021-03-25 14:29:46.362 [main] TopologyBuilderAdminClient - java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
Exception in thread "main" java.io.IOException: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClient.listTopics(TopologyBuilderAdminClient.java:52)
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClient.listApplicationTopics(TopologyBuilderAdminClient.java:73)
	at com.purbon.kafka.topology.TopicManager.loadActualClusterStateIfAvailable(TopicManager.java:89)
	at com.purbon.kafka.topology.TopicManager.apply(TopicManager.java:48)
	at com.purbon.kafka.topology.JulieOps.run(JulieOps.java:181)
	at com.purbon.kafka.topology.JulieOps.run(JulieOps.java:201)
	at com.purbon.kafka.topology.CommandLineInterface.processTopology(CommandLineInterface.java:196)
	at com.purbon.kafka.topology.CommandLineInterface.run(CommandLineInterface.java:144)
	at com.purbon.kafka.topology.CommandLineInterface.main(CommandLineInterface.java:134)
Caused by: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
	at org.apache.kafka.common.internals.KafkaFutureImpl.wrapAndThrow(KafkaFutureImpl.java:45)
	at org.apache.kafka.common.internals.KafkaFutureImpl.access$000(KafkaFutureImpl.java:32)
	at org.apache.kafka.common.internals.KafkaFutureImpl$SingleWaiter.await(KafkaFutureImpl.java:89)
	at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:260)
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClient.listTopics(TopologyBuilderAdminClient.java:49)
	... 8 more
Caused by: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
Caused by: javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection?
	at java.base/sun.security.ssl.SSLEngineInputRecord.bytesInCompletePacket(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineInputRecord.bytesInCompletePacket(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.readRecord(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.unwrap(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.unwrap(Unknown Source)
	at java.base/javax.net.ssl.SSLEngine.unwrap(Unknown Source)
	at org.apache.kafka.common.network.SslTransportLayer.handshakeUnwrap(SslTransportLayer.java:509)
	at org.apache.kafka.common.network.SslTransportLayer.doHandshake(SslTransportLayer.java:368)
	at org.apache.kafka.common.network.SslTransportLayer.handshake(SslTransportLayer.java:291)
	at org.apache.kafka.common.network.KafkaChannel.prepare(KafkaChannel.java:173)
	at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:543)
	at org.apache.kafka.common.network.Selector.poll(Selector.java:481)
	at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:561)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.processRequests(KafkaAdminClient.java:1329)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1260)
	at java.base/java.lang.Thread.run(Unknown Source)

Expected behavior
julie successfully connects to the kafka cluster.
Runtime (please complete the following information):

OS: latest julie docker tag
Kafka: Confluent Platform version 5.5.3

Additional context
Connecting to the brokers with openssl s_client works. The handshake fails as the operating system doesn't trust the self signed CA. This shouldn't be an issue for julie as julie should use the truststore specified in the admin config file containing the CA.
bash-5.1$ openssl s_client <IP_ADDRESS>:9093
CONNECTED(00000003)
Can't use SSL_get_servername
depth=1 C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
verify error:num=19:self signed certificate in certificate chain
verify return:1
depth=1 C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
verify return:1
depth=0 C = US, ST = Ca, L = PaloAlto, O = CONFLUENT, OU = TEST, CN = <IP_ADDRESS>
verify return:1
139653260368712:error:141A10F4:SSL routines:ossl_statem_client_read_transition:unexpected message:ssl/statem/statem_clnt.c:393:
---
Certificate chain
 0 s:C = US, ST = Ca, L = PaloAlto, O = CONFLUENT, OU = TEST, CN = <IP_ADDRESS>
   i:C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
 1 s:C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
   i:C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIDjzCCAnegAwIBAgIUEc58/VfYLmsTqh0RJglumxvvaVQwDQYJKoZIhvcNAQEL
BQAwZTELMAkGA1UEBhMCREUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoM
GEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDEeMBwGA1UEAwwVY2xvdWQgbmF0aXZl
IHNlcnZpY2VzMB4XDTIxMDMyNDA5MDcxOVoXDTIyMDMyNDA5MDcxOVowajELMAkG
A1UEBhMCVVMxCzAJBgNVBAgTAkNhMREwDwYDVQQHEwhQYWxvQWx0bzESMBAGA1UE
ChMJQ09ORkxVRU5UMQ0wCwYDVQQLEwRURVNUMRgwFgYDVQQDEw8xMDAuMTI3LjEy
OS4xNTgwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC0iMasIu6sEUcx
W/R499GOAnmQCnpyCKGmb/gdTFvIs9k3HIWCpbD6iv3dYJ6MfrDc4puVUSnbdYjK
q2uFxalEKLeKzX/5w23d6NJW7ZUteH/woHXWFkX8S6wZEl7NgpYqNqXvAF8edeGz
X0jBD8GkfXt2So3LjvPOTwVZDZE9CcrcF23DQEoWedYlLefGsi5ApMUApEDg7AkV
l1I/9P9HncdZfS4/sKtHrthLHQupNYI1Vax1z+IcXkclR5UE1p1vFBJKxiW2wvZE
NX+5RGjTIZZRmRkFiBnXL1PrTb/xC7SgjbK69i4UAUbHV4HIe0qJc4XLb2yu9baw
QQXPY9HzAgMBAAGjMjAwMB0GA1UdJQQWMBQGCCsGAQUFBwMBBggrBgEFBQcDAjAP
BgNVHREECDAGhwRkf4GeMA0GCSqGSIb3DQEBCwUAA4IBAQCY5D/w9qD6xZ4k5r9f
lOhipu59tP3rzNFnSD0DXByvF6hrl2BUmKh+Bygx7v13efrZZ5WoTTP2DqOum2TT
9/qfOFXbhRUu+byrPum0nMR/BXppqkJOKlcat+Hj21MLE99HI76zYQyVBin/GjvF
NnC7mqJgMNwZyF9fyptHnaXDxXD+zvLWzZICEvUSBSnKu150z5tbw/dck4Xv6Gti
X/vqYw+ldugNW3TGQ+fdWANVq3C0LiEFeVEL+/UpflcdgxmqKSMT0hY8YeifqUdO
s/fmrk7Eun1bMrX4VW+PbLkcESa78olDcCv40pK6w+QOYrncufqvcQf5OQzZDc1S
wD+w
-----END CERTIFICATE-----
subject=C = US, ST = Ca, L = PaloAlto, O = CONFLUENT, OU = TEST, CN = <IP_ADDRESS>

issuer=C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services

---
Acceptable client certificate CA names
C = DE, ST = Some-State, O = Internet Widgits Pty Ltd, CN = cloud native services
Client Certificate Types: RSA sign, DSA sign, ECDSA sign
Requested Signature Algorithms: ECDSA+SHA512:RSA+SHA512:ECDSA+SHA384:RSA+SHA384:ECDSA+SHA256:RSA+SHA256:DSA+SHA256:ECDSA+SHA224:RSA+SHA224:DSA+SHA224:ECDSA+SHA1:RSA+SHA1:DSA+SHA1
Shared Requested Signature Algorithms: ECDSA+SHA512:RSA+SHA512:ECDSA+SHA384:RSA+SHA384:ECDSA+SHA256:RSA+SHA256:DSA+SHA256:ECDSA+SHA224:RSA+SHA224:DSA+SHA224:ECDSA+SHA1:RSA+SHA1:DSA+SHA1
Peer signing digest: SHA256
Peer signature type: RSA
Server Temp Key: ECDH, P-256, 256 bits
---
SSL handshake has read 4882 bytes and written 462 bytes
Verification error: self signed certificate in certificate chain
---
New, TLSv1.2, Cipher is ECDHE-RSA-AES256-GCM-SHA384
Server public key is 2048 bit
Secure Renegotiation IS supported
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-AES256-GCM-SHA384
    Session-ID: 605C9F0F2C60D55B223DF065B9DA94131AB671B8658542BC6CAB469D8A7C68D5
    Session-ID-ctx:
    Master-Key: 979F46FFE49176BAF6CE3F72F347DE09F9BEC2328619A4AFBF8FDC681545C55E7F289D60CC4E14F220622AA1CA68477E
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time:<PHONE_NUMBER>
    Timeout   : 7200 (sec)
    Verify return code: 19 (self signed certificate in certificate chain)
    Extended master secret: yes
---

Thanks for bringing this up, I am sorry your are having this problems.
With latest I changed a bit the way the JVM is done in the docker image, to basically make it smaller I might be some missing stuff if required in java.
I tested right now master code with the docker image locally under docker/tls and I have notice no errors, but I will keep testing tomorrow.
Looking forward to sort this out.
Context, Admin client usage is really simple here, all configs goes there, so there should be no difference.
Keep you posted

Hi @manuelbonk.
I finally took sometime to run a couple of test in this report. What i did is this.

Start the docker tls sample as located inside the docker/tls directory in this project.
Run the JulieOps CLI from a second containers as a single command.

This is what I get:
docker run -t -i \
       -v /Users/pere/work/gitops/kafka-topology-builder/example:/example \
       -v /Users/pere/work/gitops/kafka-topology-builder/docker:/docker \
       --network tls_default \
       purbon/kafka-topology-builder:latest \
       julie-ops-cli.sh  \
       --brokers kafka.confluent.local:9093 \
       --clientConfig /example/topology-builder-tls.properties --topology /example/descriptor.yaml

[INFO ] 2021-03-27 17:32:28.401 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to kafka.confluent.local:9093
[INFO ] 2021-03-27 17:32:28.401 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to kafka.confluent.local:9093
log4j:WARN No appenders could be found for logger (org.apache.kafka.clients.admin.AdminClientConfig).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
List of Topics:
context.company.env.source.projectC.topicE
context.company.env.source.projectC.topicF
context.company.env.source.projectA.bar.avro
.... redacted....
_confluent-monitoring
'TOPIC', '_confluent-monitoring', '*', 'CREATE', 'User:ControlCenter', 'LITERAL'
'TOPIC', '_confluent-monitoring', '*', 'WRITE', 'User:ControlCenter', 'LITERAL'
'TOPIC', '_confluent-monitoring', '*', 'DESCRIBE', 'User:ControlCenter', 'LITERAL'
'TOPIC', '_confluent-monitoring', '*', 'READ', 'User:ControlCenter', 'LITERAL'
status
'TOPIC', 'status', '*', 'WRITE', 'User:Connect1', 'LITERAL'
'TOPIC', 'status', '*', 'READ', 'User:Connect1', 'LITERAL'
List of Principles:
Kafka Topology updated

you can see i used latest as in your report.
This is the property file I used:
/example/topology-builder-tls.properties
security.protocol=SSL
ssl.truststore.location=/docker/tls/certs/truststore.jks
ssl.truststore.type=PKCS12
ssl.truststore.password=test1234
ssl.keystore.location=/docker/tls/certs/server.keystore.jks
ssl.keystore.password=test1234
ssl.keystore.type=PKCS12
ssl.key.password=test1234
ssl.endpoint.identification.algorithm=

this file is available in the running container and used to access and run the commands.
As you can see from https://github.com/kafka-ops/julie/blob/master/src/main/java/com/purbon/kafka/topology/api/adminclient/TopologyBuilderAdminClientBuilder.java#L22-L34
and https://github.com/kafka-ops/julie/blob/c46058f17ea82703586c1ecbc914fe4f244865c5/src/main/java/com/purbon/kafka/topology/Configuration.java#L137
nearly every config given in then passed to the adminClient.
I wonder,

You run the julie-ops cli alone, not as I did with my test. Which is the parameters you are passing there?
Are you accessing the tls ports?  see

Caused by: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
Caused by: javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection?

this reference something arrived unrecognized during the SSL handshake trial.
Do you mind replicating and validating my tests here? I would love to help findings the small needle in your situation.

Either in JulieOps as in Kafka, I would suggest turning on the LOG debug mode. This would help debugging the problem.

Hi Pere, thanks for your reply. I've set the properties file just like your's:
security.protocol=SSL
ssl.keystore.location=/etc/kafka/secrets/kafka.keystore.jks
ssl.keystore.password=XXX
ssl.truststore.location=/etc/kafka/secrets/kafka.truststore.jks
ssl.truststore.password=XXX
ssl.endpoint.identification.algorithm=
bootstrap.servers=<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093
ssl.keystore.type=PKCS12
ssl.truststore.type=PKCS12

How can I enable the debug log for Julie? I couldn't find any info on that in the docu.
I'm only passing the client config and the topology dir, still the same result:
bash-5.1$ julie-ops-cli.sh --clientConfig /tmp/ktb.properties --topology /tmp/ansible.u353lgc6
[INFO ] 2021-03-29 17:02:03.832 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093
[INFO ] 2021-03-29 17:02:03.832 [main] TopologyBuilderAdminClientBuilder - Connecting AdminClient to <IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093,<IP_ADDRESS>:9093
log4j:WARN No appenders could be found for logger (org.apache.kafka.clients.admin.AdminClientConfig).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Exception in thread "main" java.io.IOException: Problem during the health-check operation
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClient.healthCheck(TopologyBuilderAdminClient.java:62)
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClientBuilder.build(TopologyBuilderAdminClientBuilder.java:30)
	at com.purbon.kafka.topology.JulieOps.build(JulieOps.java:70)
	at com.purbon.kafka.topology.CommandLineInterface.processTopology(CommandLineInterface.java:195)
	at com.purbon.kafka.topology.CommandLineInterface.run(CommandLineInterface.java:144)
	at com.purbon.kafka.topology.CommandLineInterface.main(CommandLineInterface.java:134)
Caused by: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
	at org.apache.kafka.common.internals.KafkaFutureImpl.wrapAndThrow(KafkaFutureImpl.java:45)
	at org.apache.kafka.common.internals.KafkaFutureImpl.access$000(KafkaFutureImpl.java:32)
	at org.apache.kafka.common.internals.KafkaFutureImpl$SingleWaiter.await(KafkaFutureImpl.java:89)
	at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:260)
	at com.purbon.kafka.topology.api.adminclient.TopologyBuilderAdminClient.healthCheck(TopologyBuilderAdminClient.java:60)
	... 5 more
Caused by: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
Caused by: javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection?
	at java.base/sun.security.ssl.SSLEngineInputRecord.bytesInCompletePacket(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineInputRecord.bytesInCompletePacket(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.readRecord(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.unwrap(Unknown Source)
	at java.base/sun.security.ssl.SSLEngineImpl.unwrap(Unknown Source)
	at java.base/javax.net.ssl.SSLEngine.unwrap(Unknown Source)
	at org.apache.kafka.common.network.SslTransportLayer.handshakeUnwrap(SslTransportLayer.java:509)
	at org.apache.kafka.common.network.SslTransportLayer.doHandshake(SslTransportLayer.java:368)
	at org.apache.kafka.common.network.SslTransportLayer.handshake(SslTransportLayer.java:291)
	at org.apache.kafka.common.network.KafkaChannel.prepare(KafkaChannel.java:173)
	at org.apache.kafka.common.network.Selector.pollSelectionKeys(Selector.java:543)
	at org.apache.kafka.common.network.Selector.poll(Selector.java:481)
	at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:561)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.processRequests(KafkaAdminClient.java:1329)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1260)
	at java.base/java.lang.Thread.run(Unknown Source)

Yes, I'm accessing the TLS port, see Additional context in my initial post where I get a response with openssl s_client.

I've tried it without the bootstrap.servers in the file and by passing only one broker, still the same issue.
I've used the latest version of the julie docker image and also tried an old version of kafka-topology-builder. Both were running on the same K8s cluster, against the same Kafka cluster with the exact same topology files, properties files and credentials. The former failed, the latter succeeded...
I've also tried it on different kafka clusters, still the same error.

I seem to only be able to replicate this on the Alpine Linux version of purbon/kafka-topology-builder created from the nightly build. This may have something to do with your comment:

With latest I changed a bit the way the JVM is done in the docker image, to basically make it smaller I might be some missing stuff if required in java.

The strangest part is that I can rerun the same command multiple times in a row without changing anything and around ~60% of the time it will throw the following error, and the rest of the time it works as expected. Maybe it's some kind of race condition?
Exception in thread "main" java.io.IOException: Problem during the health-check operation
...
Caused by: java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
...
Caused by: org.apache.kafka.common.errors.SslAuthenticationException: SSL handshake failed
Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
...
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1289)
at java.base/java.lang.Thread.run(Unknown Source)

Usage Details
I'm using Confluent Cloud, and my config is like so:
test-environment.properties:
bootstrap.servers=***
schema.registry.url=***

test-environment-override.properties:
ssl.endpoint.identification.algorithm=https
security.protocol=SASL_SSL
sasl.mechanism=PLAIN
sasl.jaas.config=org.apache.kafka.common.security.plain.PlainLoginModule required username="***" password="***";
basic.auth.credentials.source=USER_INFO
schema.registry.basic.auth.user.info=***:***
allow.delete.topics=true
topology.features.experimental=true
allow.delete.principals=false
allow.delete.bindings=true
topology.service.accounts.managed.prefixes.0=Service
topology.translation.principal.enabled=true
ccloud.environment=***
topology.state.cluster.enabled=true

output.yml:
---
# Source: kafka-topology/templates/topology.yaml
context: env
instance: test-environment
projects:
  - name: ***
    topics:
      - name: "***"
        producers:
          - principal: "Service:***"
        consumers:
          - principal: "Service:***"
            group: "****"
        schemas:
          value.schema.file: schemas/***.avsc
          value.format: "AVRO"
          value.compatibility: "FULL_TRANSITIVE"
        config:
          replication.factor: "3"
          num.partitions: "1"
          confluent.key.schema.validation: true
          confluent.value.schema.validation: true

command:
julie-ops-cli.sh --clientConfig ./JulieOps/test-environment.properties --overridingClientConfig ./JulieOps/test-environment-override.properties --topology ./JulieOps/output.yml


Dereference Public Symlinks

Our next.js site has some symlinks in the public/ directory to files outside the public directory.  (These files come from a git submodule which is why they aren't in the public directory directly.)  The file layout looks like
next-config.js
package.json
pages/...

thesubrepo/screenshots/aaa.png
thesubrepo/screenshots/bbb.png

public/somedirectfile
public/screenshots    (screenshots is a symlink to "../thesubrepo/screenshots")

The pages then reference /screenshots/aaa.png which works great during development.  The issue is during deployment the copyPublicFiles function https://github.com/netlify/netlify-plugin-nextjs/blob/main/src/lib/steps/copyPublicFiles.js  does not dereference the symlink so what happens is that in the netlify publish path there is a symlink screenshots to a directory that does not exist.
The copySync  function https://github.com/jprichardson/node-fs-extra/blob/HEAD/docs/copy-sync.md has an option dereference but it defaults false.
Maybe it would be a backwards compatibility problem to just always set dereference to true, but could there be an option or config setting somewhere to enable dereferencing public files when copying them to the publish directory?  Maybe an environment variable?  Just need to pass dereference: true to copySync.
For now, I have worked around this by manually copying the files as an additional build step.

@wuzzeb whoa very interesting! thanks for opening this with us :) glad you have a temporary workaround. i think it's likely we can safely default dereference to true instead, and if not, it's definitely reasonable to make this configurable. we'll keep you updated!!

Hello! We don't suggest symlinking files outside of the site itself. Your workaround for copying the files in the build command is the right way to achieve what you're looking for. 😄
If you run into any bugs during the build step, let us know!


1.20.1 beta-6 crash

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

[X] I have tested this issue and it occurs when no other mods are installed

Minecraft Version
1.20
Eureka version
1.5.1-beta.3
VS2 version
2.3.0-beta.6
Mod Loader
Forge
Issue description
if load valkyrian skies 2.3.0 beta.6 then cause eureka load error.
Issue reproduction
if load valkyrian skies 2.3.0 beta.6 then cause eureka load error.
Logs
latest.log

Ah! My mistake. sorry. I close issue and re open issue of compatibility.


T450s OS Sonoma 14.0

T450s OS Sonoma (EFI 0.95) - Final : https://drive.google.com/file/d/1nGacsXMY5Y-5pO0aV2RrU1L9mg4d2TKD/view?usp=sharing

VDA Decoder : Fully Support
Smooth run
Update Serial, MLB,etc

the gpu isnt working

the gpu isnt working

Better now

How I couldn't do it in ventrua and I went back to Monterey

Can you send the temps and can you use a external monitor

the gpu isnt working

Better now

How

T450s OS Sonoma (EFI 0.95) - Final : https://drive.google.com/file/d/1nGacsXMY5Y-5pO0aV2RrU1L9mg4d2TKD/view?usp=sharing

VDA Decoder : Fully Support
Smooth run
Update Serial, MLB,etc

can you please make a youtube tut about it and say what works and what doesnt

the gpu isnt working

Better now

How

Try it

GPU working

Steps for fix:

download opencore legacy patcher
select post install root patch
select intel graphics patch
reboot

GPU working

Steps for fix:

download opencore legacy patcher
select post install root patch
select intel graphics patch
reboot

Works perfectly. Better than Ventura. Let's start to try to make bluetooth work

With only 1024mb

I patched with framebuffer-unifiedmem：00000080 but it still flashes with strikes

T450s OS Sonoma (EFI 0.95) - Final : https://drive.google.com/file/d/1nGacsXMY5Y-5pO0aV2RrU1L9mg4d2TKD/view?usp=sharing

VDA Decoder : Fully Support
Smooth run
Update Serial, MLB,etc

can you please make a youtube tut about it and say what works and what doesnt

Uh i cant download the efi

GPU working

Steps for fix:

download opencore legacy patcher
select post install root patch
select intel graphics patch
reboot

Works perfectly. Better than Ventura. Let's start to try to make bluetooth work

Hello. Bluetooth working with original bluetooth intel card.
I used this file: https://github.com/OpenIntelWireless/IntelBluetoothFirmware/issues/460#issuecomment-1790533302
Problem: The mouse click only works at the trackpad. The 3 buttons doesn't but the red button ok.
Can anyone help?
EFI 0.95: https://drive.google.com/file/d/1xDXvB8cuT5EtM33POEra3NL7kVObhzhT/view?usp=sharing

Is there any possibility of driving dw1820a in Sonoma?

Uh i cant download the efi....

Would this work on the X1C3 (X1 Carbon 3rd gen)? Asking since the repo supports that model as well.

T450s OS Sonoma (EFI 0.95) - Final : https://drive.google.com/file/d/1nGacsXMY5Y-5pO0aV2RrU1L9mg4d2TKD/view?usp=drivesdk

VDA Decoder : Fully Support
Smooth run
Update Serial, MLB,etc

Would this work on the X1C3 (X1 Carbon 3rd gen)? Asking since the repo supports that model as well.

How should I install it? How can I download the image file? I installed macOS Sonoma 14.1.2 using the recovery version and used your EFI, but the graphics memory is only 5MB and the usage is very slow.

The computer restarts as soon as the installer UI is displayed, sometimes it starts but it is unlikely and when it does the wifi does not work, that is, when I turn on the wifi and you click on the icon the computer turns off, I have a t450s with an i5 5300u the same as yours I think I don't know what the problem is

The computer restarts as soon as the installer UI is displayed, sometimes it starts but it is unlikely and when it does the wifi does not work, that is, when I turn on the wifi and you click on the icon the computer turns off, I have a t450s with an i5 5300u the same as yours I think I don't know what the problem is

use opencore patcher in macos,i fixed it

The computer restarts as soon as the installer UI is displayed, sometimes it starts but it is unlikely and when it does the wifi does not work, that is, when I turn on the wifi and you click on the icon the computer turns off, I have a t450s with an i5 5300u the same as yours I think I don't know what the problem is

use opencore patcher in macos,i fixed it

I don't know how to do it, can you share the EFI?

The computer restarts as soon as the installer UI is displayed, sometimes it starts but it is unlikely and when it does the wifi does not work, that is, when I turn on the wifi and you click on the icon the computer turns off, I have a t450s with an i5 5300u the same as yours I think I don't know what the problem is

use opencore patcher in macos,i fixed it

I don't know how to do it, can you share the EFI?

efi is same ,read this(https://imacos.top/2023/12/21/2653/) passage sir

La computadora se reinicia tan pronto como se muestra la UI del instalador, a veces se inicia pero es poco probable y cuando lo hace el wifi no funciona, es decir, cuando enciendo el wifi y haces clic en el icono la computadora se apaga, yo tengo un t450s con un i5 5300u igual que el tuyo creo que no se cual es el problema

uso el parche opencore en macos, lo arreglé

No sé cómo hacerlo, ¿puedes compartir el EFI?

efi es el mismo, lea este pasaje ( https://imacos.top/2023/12/21/2653/ ), señor

I cannot apply Post-Install Root Patch, I have a 5th i5 and macOS Ventura, is it because this operating system supports 5th processors?

La computadora se reinicia tan pronto como se muestra la UI del instalador, a veces se inicia pero es poco probable y cuando lo hace el wifi no funciona, es decir, cuando enciendo el wifi y haces clic en el icono la computadora se apaga, yo tengo un t450s con un i5 5300u igual que el tuyo creo que no se cual es el problema

uso el parche opencore en macos, lo arreglé

No sé cómo hacerlo, ¿puedes compartir el EFI?

efi es el mismo, lea este pasaje ( https://imacos.top/2023/12/21/2653/ ), señor

I cannot apply Post-Install Root Patch, I have a 5th i5 and macOS Ventura, is it because this operating system supports 5th processors?

Hello. This EFI is to Sonoma. Try it.

but my processor is fifth generation

La computadora se reinicia tan pronto como se muestra la UI del instalador, a veces se inicia pero es poco probable y cuando lo hace el wifi no funciona, es decir, cuando enciendo el wifi y haces clic en el icono la computadora se apaga, yo tengo un t450s con un i5 5300u igual que el tuyo creo que no se cual es el problema

uso el parche opencore en macos, lo arreglé

No sé cómo hacerlo, ¿puedes compartir el EFI?

efi es el mismo, lea este pasaje ( https://imacos.top/2023/12/21/2653/ ), señor

I cannot apply Post-Install Root Patch, I have a 5th i5 and macOS Ventura, is it because this operating system supports 5th processors?

Hello. This EFI is to Sonoma. Try it.

but my processor is fifth generation

but my processor is fifth generation

La computadora se reinicia tan pronto como se muestra la UI del instalador, a veces se inicia pero es poco probable y cuando lo hace el wifi no funciona, es decir, cuando enciendo el wifi y haces clic en el icono la computadora se apaga, yo tengo un t450s con un i5 5300u igual que el tuyo creo que no se cual es el problema

uso el parche opencore en macos, lo arreglé

No sé cómo hacerlo, ¿puedes compartir el EFI?

efi es el mismo, lea este pasaje ( https://imacos.top/2023/12/21/2653/ ), señor

I cannot apply Post-Install Root Patch, I have a 5th i5 and macOS Ventura, is it because this operating system supports 5th processors?

Hello. This EFI is to Sonoma. Try it.

but my processor is fifth generation

No problem. Just do it.

New EFI Version: Opencore 0.9.9.
https://drive.google.com/file/d/1JVN7ME7EshXhKRWQi-hRBn-UHTREjHKY/view?usp=share_link
2 problems, so, i need help:
1- HDMI don't work. Even if OCLP. https://github.com/acidanthera/WhateverGreen/blob/master/Manual/FAQ.IntelHD.en.md
2- When sleep, the sound stop to work. Need reboot.
After install, use OCLP: https://github.com/dortania/OpenCore-Legacy-Patcher/

On Sonoma everything works except brightness control. I am unable to adjust brightness and there isn't the brightness slider under System Settings > Displays.

On Sonoma everything works except brightness control. I am unable to adjust brightness and there isn't the brightness slider under System Settings > Displays.

even the webcam? 👀👀

If your laptop x250 configure EFI based on x250 hardware or find older version of X250 that works well. You can update Opencore to 0.99 with change Boot file, Opencore.efi, drivers and config.pliz update to follow 0.99 version. Use plist sanity check ( https://sanitychecker.ocutils.me/ ) and adjust version open core, you will see which lines should be added or adjusted.

Friend, I have tried this EFI and all the previous ones, but every time the operating system starts, it restarts after a while. Can you help me? I already patched the GPU but the EFI I used for that doesn't work for my laptop since it is for a thinkpad x250

Sorry, I didn't make myself understood, I have a thinkpad t450s, I used the EFI of an x250 to be able to boot since, as I said before, the EFI published here does not work for me, but said EFI is not 100% compatible with my computer, there are many errors

Everything appear to work on my Thinkpad T450s, WIFI, bluetooth, brightness, sound and function keys, etc but HD 5500.
I've tried different versions of the OCLP but not luck. Can somebody tell me some suggestions ?
I'm using T450s OS Sonoma (EFI 0.95) - Final and when try to use OCLP to execute the Post-Install Root Patch ... I've no option to patch ... only the option that are not grayed out is "Revert Root Patches" .... Any clue about to how to solve that ?

On Sonoma everything works except brightness control. I am unable to adjust brightness and there isn't the brightness slider under System Settings > Displays.

even the webcam? 👀👀

Sorry for late replay. But yes.
No brighntess slider.
Does eneybody now how to fix it?

On Sonoma everything works except brightness control. I am unable to adjust brightness and there isn't the brightness slider under System Settings > Displays.

even the webcam? 👀👀

Sorry for late reply. But yes. No brightness slider. Does eneybody know how to fix it?

Brightness is a know bug from Opencore Legacy Patcher. They said it on the official docs. Take a look here :
https://dortania.github.io/OpenCore-Legacy-Patcher/TROUBLESHOOTING.html#no-brightness-control

On Sonoma everything works except brightness control. I am unable to adjust brightness and there isn't the brightness slider under System Settings > Displays.

even the webcam? 👀👀

Sorry for late reply. But yes. No brightness slider. Does eneybody know how to fix it?

Brightness is a know bug from Opencore Legacy Patcher. They said it on the official docs. Take a look here :
https://dortania.github.io/OpenCore-Legacy-Patcher/TROUBLESHOOTING.html#no-brightness-control

OK. Thank you. Now the brightness control works with the app recommended on the OpenCore website.  I am just wondering why the brightness control does not work on Sonoma.out of box" like it did on Monetary.

Hello.
2 questions:
Anybody use  14.5 sonoma? Because OCLP 1.5.0 don't work for me.
How U upgrade version? Because of the partition, only using a new install.

Hello. 2 questions:
Anybody use 14.5 sonoma? Because OCLP 1.5.0 don't work for me. How U upgrade version? Because of the partition, only using a new install.

Smooth update to 14.5 without any issues ... After the update you need to apply OCLP 1.5.0 again to patch the Intel 5500 graphics

Hello.
2 questions:
Anybody use  14.5 sonoma? Because OCLP 1.5.0 don't work for me.
How U upgrade version? Because of the partition, only using a new install.
I did a clean installation (After erasing the disk)
I have updated to Sonoma 14.5 and OCLP doesn't work for me too(it says no patches required though there is only 7 MB graphics memory), maybe due to it only supporting up to 14.4? Need help, please.

Hello.
2 questions:
Anybody use  14.5 sonoma? Because OCLP 1.5.0 don't work for me.
How U upgrade version? Because of the partition, only using a new install.

I did a clean installation (After erasing the disk)
I have updated to Sonoma 14.5 and OCLP doesn't work for me too(it says no patches required though there is only 7 MB graphics memory), maybe due to it only supporting up to 14.4? Need help, please.

Hello.
2 questions:
Anybody use  14.5 sonoma? Because OCLP 1.5.0 don't work for me.
How U upgrade version? Because of the partition, only using a new install.

I did a clean installation (After erasing the disk) I have updated to Sonoma 14.5 and OCLP doesn't work for me too(it says no patches required though there is only 7 MB graphics memory), maybe due to it only supporting up to 14.4? Need help, please.

As bad as...
Same problem.
At the wekkend I'll try clone the partition and repair the firmware problem to update by Software Update

just like that

just like that

That means that your Intel HD 5500 graphics configuration at your config.plist are wrong. Because OCLP only patch the graphics card on the Thinkpad T450s. Verify your config.plist

just like that

That means that your Intel HD 5500 graphics configuration at your config.plist are wrong. Because OCLP only patch the graphics card on the Thinkpad T450s. Verify your config.plist

And there is another problem. This version don't recognize external USB disk, Pendrive, etc.

just like that

That means that your Intel HD 5500 graphics configuration at your config.plist are wrong. Because OCLP only patch the graphics card on the Thinkpad T450s. Verify your config.plist

Yes.. You're right.
EFI 14.5: https://drive.google.com/file/d/1MruDa1JeH56Tv196LUI-djMlsn8x9MND/view?usp=sharing
I need a help to enable SIP. There is a problem with vmware fusion

I bought an original Apple BCM94360CS2 wireless card for my T450, could you provide an OpenCore version that includes drivers for this original Apple card, thank you very much!!!! @gonav8

I bought an original Apple BCM94360CS2 wireless card for my T450, could you provide an OpenCore version that includes drivers for this original Apple card, thank you very much!!!! @gonav8

try this: https://github.com/acidanthera/BrcmPatchRAM

Hi i have a question
What doesnt work?
And how Is the performance?
Does GPU accelleration work?

Why can't you adjust the brightness?

Will this work on my t450 or Is It only for the t450s
Sry for dumb question

Hey, can someone please help me? When i boot into the recovery on my t450 using this EFI a get a lor of these errors:
shared_region: 0x627d9e050db45f8b [146 (newfs_hfs)] check_np (0x7ff7bbee00c8) vm_shared region_start_adress() failed

Updated:
Sonoma 14.6.1, EFI 1.0.1 with sidecar: https://drive.google.com/file/d/1H8YuTds1HSpNI1S6ZeB6jwr4t_BrPT1U/view?usp=sharing
The problem with brightness is OCLP and I don't know how repair.

Thank you in gonna update my efi.
i fixed everything using brightness slider.
Hope someone can get Sequoia to work
Il lun 9 set 2024, 15:23 hlbomfim @.***> ha scritto:

Updated:
Sonoma 14.6.1, EFI 1.0.1 with sidecar:
https://drive.google.com/file/d/1H8YuTds1HSpNI1S6ZeB6jwr4t_BrPT1U/view?usp=sharing
The problem with brightness is OCLP and I don't know how repair.
image.png (view on web)
https://github.com/user-attachments/assets/c6d6f513-e6ea-449d-82a3-c5deef86e44e
—
Reply to this email directly, view it on GitHub
https://github.com/CLAY-BIOS/Lenovo-ThinkPad-T450s-Hackintosh-OpenCore/issues/133#issuecomment-2338115775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A52IF77SCYCIL2W3WLPPB43ZVWOLXAVCNFSM6AAAAAA5R6NHEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZYGEYTKNZXGU
.
You are receiving this because you commented.Message ID:
<CLAY-BIOS/Lenovo-ThinkPad-T450s-Hackintosh-OpenCore/issues/133/2338115775
@github.com>

My hero. Brightness slide works fine!👍
You shoud try Sequoia with a new partition usint this EFI.

Thank you in gonna update my efi. i fixed everything using brightness slider. Hope someone can get Sequoia to work

Yea Im gonna try changing the smbios and booking.
But of course we arent gonna get GPU acceleration until oclp fully supports sonoma

Sorry for late reply, sequoia boots fine with the same efi as sonoma, but oclp doesn't yet support Sequoia

Sorry for late reply, sequoia boots fine with the same efi as sonoma, but oclp doesn't yet support Sequoia
EDIT: Tried using oclp 2.0 nightly but It caused my system to kernel panic

GREAT.... When officially launch we can create a new thread to Sequoia

Oclp 2.0 stable Is relased!
I Need to reinstall Sequoia (oclp 2.0 nightly broke It) and see of It works
It seems like HD 5500 Is supported: https://github.com/dortania/OpenCore-Legacy-Patcher/issues/1008

Oclp 2.0 stable Is relased!
I Need to reinstall Sequoia (oclp 2.0 nightly broke It) and see of It works
It seems like HD 5500 Is supported: dortania/OpenCore-Legacy-Patcher#1008

@matte-oss , launched!
https://www.apple.com/br/macos/macos-sequoia/
You can create a new thread 😂😂

I created a issue for sequoia #137

Welcome Brightness not working what is the solution

Brightness slide works fine

Install Brightness slide. Works fine

Hi
I need install ventura please send me folder efi

Has anyone here had any problems with kernel panics after patching the integrated graphics? I installed macOS Sequoia on my ThinkPad T450 without any issues, but after patching, the system doesn't want to boot.


OSError: [Errno 22] Invalid argument

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

MY command Line:
$@"-v --format m4a --hls-prefer-ffmpeg -o ""C:/DIRECTORY/%(title)s.%(ext)s"" {path}"

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--format', 'm4a', '--hls-prefer-ffmpeg', '-o', 'C:/Users/johni/Desktop/MusicDiscord/MusicBotV2/MusicBot/src/MusicBotV2/Music/%(title)s.%(ext)s', 'https://www.youtube.com/watch?v=NVb_3xpa55c']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg 3.2.4
[debug] Proxy map: {}
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\__init__.py", line 465, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\__init__.py", line 455, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\YoutubeDL.py", line 1896, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\YoutubeDL.py", line 760, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 433, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\youtube.py", line 1397, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 634, in _download_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 531, in _download_webpage_handle
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 487, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 699, in report_download_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\extractor\common.py", line 691, in to_screen
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\YoutubeDL.py", line 472, in to_screen
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\YoutubeDL.py", line 486, in to_stdout
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\YoutubeDL.py", line 475, in _write_string
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpwgfs80it\build\youtube_dl\utils.py", line 1405, in write_string
OSError: [Errno 22] Invalid argument
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w' encoding='cp1252'>
OSError: [Errno 22] Invalid argument
...
<end of log>

Description of your issue, suggested solution and other information
I just get this error sometimes not all the time and have no idea why. As the path is not invalid. I am running on Windows 10

I got the same error, as it looks like BossDarkReaper is running youtube-dl from a c# application as myself as well.
I could avoid that error, if i changed the Attributes for the Process Method, as follows:
Code produces the error:
 Process p = new Process                     {                         StartInfo =                         {                             RedirectStandardInput = true,                             RedirectStandardOutput = true,                             FileName = @"D:\Tools\youtube-dl\youtube-dl.exe",                             WorkingDirectory = @"D:\MyYouTube",                             Arguments = arguments                         }                     };                     p.Start();
Code doesn't produce the error:
 Process p = new Process                     {                         StartInfo =                         {                             RedirectStandardInput = false,                             RedirectStandardOutput = false,                             FileName = @"D:\Tools\youtube-dl\youtube-dl.exe",                             WorkingDirectory = @"D:\MyYouTube",                             Arguments = arguments                         }                     };                     p.Start();
Hope this might help.

On msft windows, using double quotes for the output parameter (-o) solved the issue with video titles including the ' character.


[stable/jenkins] Unable to mount volumes for pod after using fsgroup

Describe the bug
Timeout when mounting volumes due to fsgroup
Version of Helm and Kubernetes:
EKS 1.15
Which chart: stable/jenkins
What happened:
After migrating to version >= 2 when starting to use fsgroup, pods gets timeout when trying to mount my pvc possibly due to the volume size (~70GB)
Unable to mount volumes for pod "jenkins-8558c9669-nbmkr_jenkins(55aa3121-efff-444d-9db2-95483c4a2569)": timeout expired waiting for volumes to attach or mount for pod "jenkins"/"jenkins-8558c9669-nbmkr". list of unmounted volumes=[jenkins-home]. list of unattached volumes=[plugins tmp jenkins-config plugin-dir jenkins-home sc-config-volume jenkins-token-4zsr9]; skipping pod
What you expected to happen:
Pods launching correctly like before bumping version
How to reproduce it (as minimally and precisely as possible):
Have a PVC to store jenkins data with a considerable size and  try to use fsgroup
Anything else we need to know:
as a Workaround I had to unset fsgroup
https://support.cloudbees.com/hc/en-us/articles/360035837431-Timeout-when-attaching-volumes-in-Kubernetes

I had the same issue. My workaround was using an older version by tacking on --version "1.27.0" during the helm install.

@delphe you still can use the latest helm version, just make sure to set fsgroup=0 and runAsUser=0 on your values

There is a related Kubernetes issue here. The TL;DR is that it's running a chown on all the files when fsGroup is set to something other than 0 which is a very lengthy process when you have millions(?) of files.
Running containers as root is not advisable. We've run into this same issue (not intrinsic to Jenkins) and just waited it out. For us it takes ~1.5hrs and eventually the Pod comes up.
As a mitigation strategy, we plan to do aggressive job clean up and cache deletion.

Just had the same issue when upgrading chart to 2.x, using the new fsGroup=1000 config.
I followed the upgrade instructions from the README, the chown command took a huge amount of time compared to what I'm used to for a similar amount of files.
Then I applied the helm upgrade, and the Jenkins pod failed due to the mount timeout. I initially thought something was broken but then I saw this Github issue and waited, it took half an hour but finally worked without further intervention.
I'm running Jenkins on a GKE cluster, with standard persistent disk storage. I guess the relatively low disk I/O performance is the direct cause of the slowness

/nostale

📢 stable/jenkins has moved to https://github.com/jenkinsci/helm-charts. If still applicable, please reopen the issue there. Thanks!


The location to extract the CodeQL bundle to appears to be wrong

The page says to extract the bundle as follows:
"Download and unzip the bundle to the following directory inside the agent tool directory, typically located under _work/_tool: ./CodeQL/0.0.0-[codeql-release-bundle-tag (i.e. codeql-bundle-v2.14.2)]/x64/"
The path I ended up needing to extract to was:
_work_tool\codeql\0.0.0-codeql-bundle-v2.15.1\x64\codeql
...please note the additional \codeql folder at the end of the path.
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8c21f56a-170e-d33f-e568-7fc93e8e7d3c
Version Independent ID: 8c21f56a-170e-d33f-e568-7fc93e8e7d3c
Content: Configure GitHub Advanced Security for Azure DevOps features - Azure Repos
Content Source: docs/repos/security/configure-github-advanced-security-features.md
Service: azure-devops
Sub-service: azure-devops-integration
GitHub Login: @laurajjiang
Microsoft Alias: laurajiang

Hi @dstretch - thanks for the issue! You are correct that the contents of the bundle will need to land in _work/_tool/codeql/0.0.0-codeql-bundle-v2.15.1/x64/codeql.
You should be able to unzip the contents into the parent directory of _work/_tool: ./CodeQL/0.0.0-[codeql-release-bundle-tag (i.e. codeql-bundle-v2.14.2)]/x64/, unpacking into its own codeql directory.


Character builder/roller

Bcholmes character sheets import into the system nicely. Could we provide a link to their website, or, would they like to collaborate on building one into the system?


Configuraton: Allow providing wallet configuration/credentials

my bad, strange why the pre-push hook didn't catch it. Anyway, I've updated the commit now


Fixed broken example link

Just a heads up in lieu of a PR, since I accidentally committed directly instead: I fixed a broken link in https://github.com/reasonml-community/bs-react-native/commit/c81a05fe074e3b5f88c360e15b04a09508f99fe0.

Thanks :)


remove unused dead code

MarkIssueClosedJob is unused and doesn't have any implemented. This PR 🔥's dead code.

✂ ✂ ✂ ✂ ✂ ✂ ✂ ✂

Thanks!


Do not call to_representation when value is None.

This works against the current drf-3.0.5. I thought this was the best way to handle it, if not let me know. This is my first attempt at pull requests so I'm more than a little confused. Thank you for your patience!

Coverage decreased (-0.25%) to 94.11% when pulling 2a006dce90ae0fbe722d75e9173f9b3d0c9c3943 on mattxbart:master into 15be798372a6f472b00f66a139b38a0a83dfeb97 on djangonauts:master.

Coverage decreased (-0.25%) to 94.11% when pulling 2a006dce90ae0fbe722d75e9173f9b3d0c9c3943 on mattxbart:master into 15be798372a6f472b00f66a139b38a0a83dfeb97 on djangonauts:master.

Looks like it failed because of a network connection issue on Travis CI:
error: [Errno 104] Connection reset by peer

restarting the build right now

Good work Matt!
I need to ask you one favour in order to keep the history of this project clean.
There are two commits for one action, the second commit overwrites the changes of the first one, so it would be better to have 1 commit only.
To achieve this you should do something like:
git rebase -i HEAD^^

set the last commit to squash, edit the commit message by putting something explicit about the change you did, then save, then check you have one commit only with:
git log -3

If the result is bad, start over by doing:
git reset --hard ORIG_HEAD

If the result is good, push the result onto your fork:
git push -f origin master

And the pull request will update automatically.
Thank you
Federico

Coverage increased (+0.02%) to 94.38% when pulling 5d94db7641f4e4118a91fd292b5d407d896947c1 on mattxbart:master into 13b951c29e555e58987fd0a2c09c5e8d305c57bb on djangonauts:master.

Coverage increased (+0.02%) to 94.38% when pulling 5d94db7641f4e4118a91fd292b5d407d896947c1 on mattxbart:master into 13b951c29e555e58987fd0a2c09c5e8d305c57bb on djangonauts:master.

thanks

No problem, thank you for the guidance as well. I really appreciate it.


[HOLD for payment 2023-07-14] [$1000] Original message is displayed for few seconds after adding emoji reaction on edited message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app and login with user A
Open the app in another device and login with user B
From user B, send message to user A
From user A, open user B report, hover on latest sent message and click on Add reaction
From user B, edit the message
Observe in user A, the user B message is displayed edited, from the current open emoji picker for reaction, click on any emoji to add reaction
Observe that after adding the reaction, app displays older (message before edit) for few seconds

Expected Result:
App should not display older message i.e. message before edit on adding reaction to edited message
Actual Result:
App displays older message i.e. message before edit on adding reaction to edited message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.33-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/9db1ed99-c6e8-445e-bfc8-93ad2fcde9c8
https://github.com/Expensify/App/assets/93399543/bc2d776e-8a2a-4066-9852-c7e949267100
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687870862782029
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015a60dfce3c07cce2
Upwork Job ID:<PHONE_NUMBER>000873472
Last Price Increase: 2023-06-29

Proposal
Please re-state the problem that we are trying to solve in this issue.

Problem is user is seeing old message for few seconds when someone edits the message, before the user add's emoji to the message.

What is the root cause of that problem?

The reportAction given to Report.toggleEmojiReaction function is not updated with the latest message.

What changes do you think we should make in order to solve the problem?

We can access the latest message using reportID and reportActionID and pass it to a function ReportActionsUtils.getReportAction(reportID, reportActionID) (which i had to create) and now use this reportAction for further code.

 Code for `toggleEmojiReaction`
function toggleEmojiReaction(reportID, reportAction, emoji, paramSkinTone = preferredSkinTone) {
    const latestReportAction = ReportActionsUtils.getReportAction(reportID, reportAction);
    const message = latestReportAction.message[0];
    const reactionObject = message.reactions && _.find(message.reactions, (reaction) => reaction.emoji === emoji.name);
    const skinTone = emoji.types === undefined ? null : paramSkinTone; // only use skin tone if emoji supports it
    if (reactionObject) {
        if (hasAccountIDReacted(currentUserAccountID, reactionObject.users, skinTone)) {
            return removeEmojiReaction(reportID, latestReportAction, emoji, skinTone);
        }
    }
    return addEmojiReaction(reportID, latestReportAction, emoji, skinTone);
}

What alternative solutions did you explore? (Optional)

N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
When user opens the emoji picker from the reaction bar, openEmojiPicker is called
https://github.com/Expensify/App/blob/d1a743c3d6ed9ff3767e6da93daf9a604c45a781/src/components/Reactions/MiniQuickEmojiReactions.js#L59-L71
The value of props.onEmojiSelected is defined when openEmojiPicker is called. So reportAction value of the onEmojiSelected function when emoji is selected would have the value of when user opens the emoji picker.
https://github.com/Expensify/App/blob/53e4154143052649ed7b2b8df302cd1744f31f67/src/pages/home/report/ContextMenu/ContextMenuActions.js#L60-L63
This is the root cause
What changes do you think we should make in order to solve the problem?
We can get latest reportAction in toggleEmojiReaction function
https://github.com/Expensify/App/blob/53e4154143052649ed7b2b8df302cd1744f31f67/src/libs/actions/Report.js#L1641
    const action = _.get(allReportActions, [reportID, reportAction.reportActionID], reportAction);

The final function would look like
function toggleEmojiReaction(reportID, reportAction, emoji, paramSkinTone = preferredSkinTone) {
    const action = _.get(allReportActions, [reportID, reportAction.reportActionID], reportAction);
    const message = action.message[0];
    const reactionObject = message.reactions && _.find(message.reactions, (reaction) => reaction.emoji === emoji.name);
    const skinTone = emoji.types === undefined ? null : paramSkinTone; // only use skin tone if emoji supports it
    if (reactionObject) {
        if (hasAccountIDReacted(currentUserAccountID, reactionObject.users, skinTone)) {
            return removeEmojiReaction(reportID, action, emoji, skinTone);
        }
    }
    return addEmojiReaction(reportID, action, emoji, skinTone);
}

This works as expected.

Result
https://github.com/Expensify/App/assets/126839717/2701b880-71c2-4c7a-a93e-2709e39a5dbf

What alternative solutions did you explore? (Optional)

Comment : https://github.com/Expensify/App/issues/21826#issuecomment-1612093829
Check below video for fix if necessary.

 Fixed Video
https://github.com/Expensify/App/assets/78416198/1b524557-d81a-4d08-923f-35e1db961db8

Did some Android issues for Sophie, so doing an issue swap as I'm a bit swamped today and working 50%.

Able to reproduce!

@jeet-dhandha i agree with the root cause and the solution.

Sounds good to me too thanks!

@neil-marcellini @rushatgabhane - Will create a PR and send here.

@dhanashree - do you mind doing this please?

The BZ member will need to manually hire dhanashree for this role Reporter. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

Hi @sophiepintoraetz, sorry I didn't get it, should I apply to the job?

Melvin bot has marked wrong profile, my tag is @dhanashree-sawant

PR: https://github.com/Expensify/App/pull/21933.
Thanks 🙏 .

Regression: https://github.com/Expensify/App/issues/22235

@rushatgabhane Any updates on this one ?

I think @aimane-chnaif is working on the review for regression https://github.com/Expensify/App/pull/22270

Okay so @jeet-dhandha - can you confirm whether your PR introduced a regression? If so, it is correct that is a 50% deduction for you, @rushatgabhane? (So 1500/2 = $750)
Lastly, what is needed to close out this issue?

@sophiepintoraetz There’s a pr which needs to be merged before mine so waiting for that.

Okay but to be clear, your PR did not introduce a regression?

It introduced on DEV env, basically someone was testing on main branch and had a issue in reacting with emoji in a thread chat’s first message. So i fixed it before it can go to Stagging. But my PR was not merged due to this https://github.com/Expensify/App/pull/17996 PR.

So you can somewhat count it as a regression on DEV end.

Any idea on when can we merge that PR ?

Okay so we actually can't release payment until the 7 day window has passed. I think if a regression is introduced in production, that would have the penalty applied...so you're lucky! And Rushat will be best placed to say when we can merge.

Hi @sophiepintoraetz, I have accepted the offer, you have also sent invite for that job so not accepting that as offer already accepted.

Waiting for @stitesExpensify to complete the requested changes on this PR : https://github.com/Expensify/App/pull/17996 and then i will have to make changes accordingly for my PR and then we will be able to complete this. @stitesExpensify if you need any help completing it quicker do tell me.

Hi @sophiepintoraetz, I just got another offer for this issue from @trjExpensify and I understood that it was already paid after accepting it. Not sure what to do about it, kindly suggest.

Most probably offer was for #20423 as @trjExpensify sent me offer with this issue title and had mentioned that offer was sent on that issue.

Yeah, I just fudged the contract title on #20243. My bad! Paid that one out anyhow!

Not overdue

@aimane-chnaif should i take a pull frommain branch on. My current branch or should i create a new branch and make changes there?

Thanks will do that.

@jeet-dhandha @aimane-chnaif @rushatgabhane - can we confirm the PR for this issue has merged with no regressions in the last 7 days? I'm not sure why we're talking about creating/editing branches if the PR has merged?

@sophiepintoraetz i think they're talking about a different issue.
But the bottom line is this -
@jeet-dhandha's PR caused a regression.
So no timeline bonus is applicable
@jeet-dhandha - $1000 (or $500 not sure)
@rushatgabhane - $500

Got it - thanks. @anmurali or @JmillsExpensify will pay you $500 in NewDot once you've completed the checklist here!

Payment issue to Jeet and contract ended - closing.

@sophiepintoraetz wondering does the payment gets 1/3rd when received ?

@jeet-dhandha - see the comment from the c+ here

Reviewed details for @rushatgabhane. This is accurate and approved for payment in NewDot.


Meetups and Startups

Proposed via @AaronSchneider1
How does meetup activity and startup activity relate? Do meetups tell us anything about startup activity in a region?

lead/sales potential
AI innovation hotspots (what new startups in AI are "hot" per accelerator funding? what areas are getting the most attention? does new startup funding for these areas of AI correlate with actual innovation or is it just "hype"?)

This will be updated once the branch is cleaned up and merged: https://github.com/BonnyCI/meatmap/tree/meetup_dataz/analysis/01_meetup_api_discovery/new_contributor_onboarding/incubators


Fix misbehavior related to copying of RootModel

Closes https://github.com/pydantic/pydantic/issues/6911
Technically we could include a check in the __copy__ directly in BaseModel, but I think this is just a bit more performant since it removes the if not self.__pydantic_root_model__: branch in the method for both classes.
Can refactor to modify the BaseModel methods if preferred.

please review


getting "google is not defined"

I'm using React/Webpack, and trying to get videojs-ima to work properly with videojs v7 (using newest release).  following the guidelines, i'm trying this
import 'video.js/dist/video-js.css';
import videojs from 'video.js';
import 'videojs-contrib-ads';
import 'videojs-ima';
...
  componentDidMount() {
    // instantiate Video.js
    logger.log('mounting video wrapper and player', this.wrapperNode, this.videoNode);
    this.player = videojs(this.videoNode, this.props, function onPlayerReady() {
      logger.log('onPlayerReady', this, this.ima);
      this.ima(options);
    });
  }

my logger output looks like this

So it does look like the plugin is recognized, but somehow google is not defined, which implies that perhaps it didn't initialize properly.  Unless there is a required dependency that hasn't been imported.
Thoughts?

Hi,
It looks like the IMA SDK loader is missing in your project, it is required by the Videojs-IMA plugin for ads requests. Try to manually add the IMA SDK loader script to your index.html file. <script type="text/javascript" src="//imasdk.googleapis.com/js/sdkloader/ima3.js"></script>

ok that worked, thanks.

ok that worked, thanks.  seems like this page is pretty misleading
https://developers.google.com/interactive-media-ads/docs/sdks/html5/

Not clear we have to load the SDK ourselves from this language, and if so..what exactly is the core value that this npm plugin is providing, vs. importing all the dependent files ourselves?

Hi,
The page you're pointing at is about the IMA SDK for HTML5 implementation guide (it doesn't use NPM or dependencies) and is not about videojs. On the videojs-ima plugin page it is stated that you have to reference the IMA SDK library in your index.html page.


Why not add steps for monocular 3D detection in readme?

Hi, I notice that the code can be transformed to monocular easily as the paper said.Why not adding the approach for mono in readme?

Can you tell me how to make pseudo lidar work for mono images?


Update stable version in repo from 0.6.2 to 0.6.4

Think about update stable version to 0.6.4
Version: stable=0.6.2 (46 days old) => latest=0.6.4 (30 days old)
Installs: stable=838 (47.45%), latest=197 (11.16%), total=1766
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 0.6.4 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

I pushed the stable via the developer portal.

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.6.4 but the current stable version is already 0.6.4.
So this issue should be closed.
@mcm1957 for evidence


Accessible Slide Presentations

integration to allow the tool to make accessible slide presentations easier to create

Hi @rgraha6!  Thank you for opening an issue for Theme Builder to consider.  Could you provide more detail on what you are thinking?  For example, how do you envision this integration happening?  Would the exported Figma Tokens or CSS be consumable by slide presentation software?  Or is there another format (preferably standardized) that can be used to configure styling in slide presentations?
I look forward to hearing how you envision that this might work!

@lwnoble mentioned that there is a new product from Figma called Figma Slides.  We need to do some research on whether Figma Slides is mature enough to handle design tokens to affect presentation.


Use Box instead of Form

It seems layout relevant currently, surely Form isn't responsible for this
Let's remove layout stuff from Form

todo: https://github.com/Pure-UI/pure/issues/6


Running a game on an extended desktop

Is it possible to (automatically) launch a LibGdx app that spans an extended monitor with 2 (or more) monitors?
I have a workaround that creates 2 separate windows using the new LWJGL3 backend but this presents some challenges of its own.

The game logic is now split across two different applications.
Additional "wiring" is required for communicating between both windows.

No, fullscreen APIs only work on one  (logical) monitor. Your OS must support joining extended monitors to one (logical) monitor.


Add HuggingFace predictor type support

KServe added new HuggingFace ClusterRuntime in the latest update.
Related-to: https://github.com/kserve/kserve/pull/3395

Can you rebase to master and fix the tests?


feat: add hcl resource plugin

Adds support for hcl updating uses minamijoyo/hcledit.
Test
To test this pull request, you can run the following commands:
cd ./pkg/plugins/resources/hcl
go test

go build -o bin/updatecli && ./bin/updatecli diff --config e2e/updatecli.d/success.d/hcl/noscm.yaml

@olblak wanted to get this up early to discuss before putting some more time into it and finishing off condition.go and test coverage etc.
Let me know your thoughts and if you happy to take that package as dependency.

Thanks folks!
If it helps, I'm interested in testing for these 2 cases we have on the Jenkins project:

Docker Bake file (which is HCL in our case) variables updates - https://github.com/updatecli/updatecli/issues/1378
Terraform updates - https://github.com/updatecli/updatecli/issues/534

providers: https://github.com/jenkins-infra/aws/blob/main/updatecli/updatecli.d/terraform-providers.yaml
modules: https://github.com/jenkins-infra/aws/blob/main/updatecli/updatecli.d/terraform-modules/eks.yml

@dduportal
Docker Bake
Using this as file: https://github.com/jenkinsci/docker/blob/master/docker-bake.hcl
With this config:
targets:
  update-file:
    name: Update files content
    kind: hcl
    spec:
      file: ./local-e2e/docker-bake.hcl
      key: variable.ALPINE_FULL_TAG.default
      value: 3.19.0

Results in:
update-file
-----------

**Dry Run enabled**

INFO: Using spec.Value instead of source input value.
⚠ - path "variable.ALPINE_FULL_TAG.default" updated from "3.18.0" to "3.19.0" in file "./local-e2e/docker-bake.hcl"

Terraform Modules
Source: https://github.com/jenkins-infra/aws/blob/main/cik8s-cluster.tf
With this config:
targets:
  update-file:
    name: Update files content
    kind: hcl
    spec:
      file: ./local-e2e/cik8s-cluster.tf
      key: module.cik8s.version
      value: 19.16.0

Result:
update-file
-----------

**Dry Run enabled**

INFO: Using spec.Value instead of source input value.
⚠ - path "module.cik8s.version" updated from "19.15.3" to "19.16.0" in file "./local-e2e/cik8s-cluster.tf"

Terraform Providers
There's a bit more to that than the HCL update, the lockfile could be updated with hcl plugin. But there would need to be a source that provided the versions and hashes..
As a side note, I have had some good mileage with using depedanabot. It provides provider specific updates, rather than rewriting the entire lock file. But I can see you don't use that in the linked project so could understand why you wouldn't want to go down that route.

Thanks @mcwarman for the tests! I got pretty much the same behavior, it's really nice!
About the terraform providers case, I was a bit quick to explain as I already knew about the dependabot case. I believe your PR here in updatecli with HCL covers the .tf part and that the terraform package ecosystem should be something else. THanks for sharing

Waow, It's great that you found a library. Last time I had a look, I couldn't find one. I wanted to start one and then I moved to projects which don't use HCL files but there is strong interest for this plugin.

There's a bit more to that than the HCL update, the lockfile could be updated with hcl plugin. But there would need to be a source that provided the versions and hashes.

Well it's a topic where I have mixed feelings, in theory I want Updatecli to be able to run from OSx/Windows/Linux  without any other dependencies, that being said as you mention, it's a bit a waste of time to re-implement de wheel,etc
I went with a middle ground where I combine a plugin like json or xml with a shell plugin or just the shell plugin like:
targets:
    package-lock.json:
        name: Bump "@vue/cli-plugin-router" package version to {{ source "npm" }}
        kind: shell
        spec:
            changedif:
                kind: file/checksum
                spec:
                    files:
                        - package-lock.json
                        - package.json
            command: npm install --package-lock-only --dry-run=$DRY_RUN @vue/cli-plugin-router@{{ source "npm" }}
            environments:
                - name: PATH
            workdir: .
        disablesourceinput: true

combining the changedif with DRY_RUN is useful, but definitely more complicated to write and test than a specific plugin.

Waow, It's great that you found a library. Last time I had a look, I couldn't find one. I wanted to start one and then I moved to projects which don't use HCL files but there is strong interest for this plugin.

I'll continue to work on it then and get something ready for review.
I came across hcledit when @quotidian-ennui and myself where discussing alternative options to the regex approach I'd taken for hcl updates.
It was a classic open source discovery journey; finding a dead project (hclq), then finding an issue that linked to alternative that fit the bit.

It would also be great if you could add a doc page similar to
https://github.com/updatecli/website/blob/master/content/en/docs/plugins/resource/npm.adoc

go build -o bin/updatecli && ./bin/updatecli apply --config e2e/updatecli.d/success.d/hcl/noscm.yaml

diff --git a/pkg/plugins/resources/hcl/testdata/data.hcl b/pkg/plugins/resources/hcl/testdata/data.hcl
index 6ba0f24..df865c5 100644
--- a/pkg/plugins/resources/hcl/testdata/data.hcl
+++ b/pkg/plugins/resources/hcl/testdata/data.hcl
@@ -1,5 +1,5 @@
 resource "person" "john" {
-  first_name  = "John"
+  first_name  = Johny
   middle_name = ""
   surname     = "Doe"
   age         = 30

@olblak Thanks, enjoyed working on this!

Thanks for the pullrequest, I'll trigger a new release by the end of the weekened


Git info variable

Hugo has a Git info variable that fetches the last commit associated with a contents page. Is it possible to do the same in Asciidocsy?

There isn't a way to do this with Jekyll to my knowledge, but this would make a great plugin, so I might add it. I have definitely used this before, but I always ingest it before the build.
I think for now I would add a step to the build with a Bash command like:
git log -n 1 --pretty=format:'{%n  "commit": "%H",%n  "abbreviated_commit": "%h",%n  "tree": "%T",%n  "abbreviated_tree": "%t",%n  "parent": "%P",%n  "abbreviated_parent": "%p",%n  "refs": "%D",%n  "encoding": "%e",%n  "subject": "%s",%n  "sanitized_subject_line": "%f",%n  "body": "%b",%n  "commit_notes": "%N",%n  "verification_flag": "%G?",%n  "signer": "%GS",%n  "signer_key": "%GK",%n  "author": {%n    "name": "%aN",%n    "email": "%aE",%n    "date": "%aD"%n  },%n  "commiter": {%n    "name": "%cN",%n    "email": "%cE",%n    "date": "%cD"%n  }%n},' > _docs/_data/gitinfo.json

Then the object will be available as site.data.gitinfo.commit etc.

I got most of that command from here: https://gist.github.com/varemenos/e95c2e098e657c7688fd

Oh I would also add _docs/_data/gitinfo.json to .gitignore -- we never want to commit built files, obviously.

I just found the jekyll-github-metadata plugin, which gives you site.github.build_revision variable, which renders the latest commit.
One thing that's awkward about attributes/variables with jekyll-asciidoc is that they don't cross those two scopes very well. If you set attributes in your AsciiDoc files, they won't be available as Jekyll/Liquid variables even on the same page template. Meanwhile, anything in the 'site' scope (other than site.asciidoctor.attributes` is not available inside AsciiDoc files, unless you enable Liquid parsing in AsciiDoc, which I don't recommend, especially if you have Liquid code listings in your content, as we do.
I might try to modify jekyll-asciidoc in order to make the site scope available as AsciiDoc attribute substitutions.


KIE forms jBPM integration

Fixing build order
Adding new modules

Merge together with:
https://github.com/droolsjbpm/kie-wb-common/pull/551/files
https://github.com/droolsjbpm/jbpm-designer/pull/495/files
https://github.com/droolsjbpm/jbpm-form-modeler/pull/76/files
https://github.com/droolsjbpm/kie-wb-distributions/pull/399/files

+1
don't merge, only @psiroky can merge as build order has to change on jenkins.


Google cloud sdk update changes

What are your changes?
Google cloud sdk now updates via yum.
What type of changes does your doc introduce?

[x] Bug fix
[ ] New feature

What is the urgency level of this change?

[ ] Blocker
[ ] High
[x] Medium

I have completed these items:

[x] I have tested all commands and code snippets.
[x] I have built locally and tested for broken links and formatting.
[x] I have made this change for all affected versions (e.g. 1.7, 1.8, and 1.9).
[x] My doc follows the style guide: https://github.com/dcos/dcos-docs#contributing.

Ping @emanic, @sascala, or @joel-hamill for reviewing pull request changes.
If you included a comment with your commit, it appears here:

Can one of the admins verify this patch?

Thanks a lot for this @ajazam!


EA SPORTS FIFA Football Demo [PCSB00082]

App summary

App name: EA SPORTS FIFA Football Demo
App serial: PCSB00082
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 2957-4343481c
Commit hash: https://github.com/Vita3K/Vita3K/commit/4343481
CPU backend: Dynamic
GPU backend: both

Test environment summary

Tested by: User01
OS: Windows 10
CPU: AMD Ryzen 5 2600 Six-Core Processor
GPU: NVIDIA GeForce RTX 3060 Ti/PCIe/SSE2
RAM: 16 GB

Issues

Screenshots

Log
vita3k.log
Recommended labels

Nothing

Por favor has que sea compatible con el emulador Vita 3k

Vita3K summary

Version: v0.1.6
Build number: 3069
Commit hash: https://github.com/vita3k/vita3k/commit/73fc1be1
CPU backend: Dynarmic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:
Game plays with audio and graphical issues
Screenshots:

Log
vita3k.txt
Recommended labels

Ingame+
Audio quality
Graphics bugs

hat


PT-162156314 Remove ulimit check

PT-162156314

The default on my Mac seems to be 256 and that is too low at times, I've had crashes...

The default on my Mac seems to be 256 and that is too low at times, I've had crashes...

@thepiwo also reported crashes without ulimit on OSX

Marked as WIP as pending comments.

Closing as we prefer warning rather than node crashing.


Update quickstart-groundedness.md

@PatrickFarley
Can you review the proposed changes? Note that the validation warnings must be resolved before merging.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @PatrickFarley,
I made your suggested commits.
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#sign-off


3.4.0 Regression - molecule miss podman binary even with docker or containers driver

Issue Type

Bug report

Molecule and Ansible details
Tox install output
ansible==4.5.0,ansible-compat==0.5.0,ansible-core==2.11.4,ansible-lint==5.1.3,arrow==1.1.1,attrs==21.2.0,bcrypt==3.2.0,binaryornot==0.4.4,bracex==2.1.1,cached-property==1.5.2,Cerberus==1.3.2,certifi==2021.5.30,cffi==1.14.6,chardet==4.0.0,charset-normalizer==2.0.4,click==8.0.1,click-help-colors==0.9.1,colorama==0.4.4,commonmark==0.9.1,cookiecutter==1.7.3,cryptography==3.4.8,distro==1.6.0,docker==5.0.2,enrich==1.2.6,flake8==3.9.2,idna==3.2,importlib-metadata==4.8.1,iniconfig==1.1.1,Jinja2==3.0.1,jinja2-time==0.2.0,MarkupSafe==2.0.1,mccabe==0.6.1,molecule==3.4.0,molecule-containers==1.0.0,molecule-docker==1.0.2,molecule-podman==1.0.1,molecule-vagrant==0.6.3,netaddr==0.8.0,packaging==21.0,paramiko==2.7.2,pathspec==0.9.0,pluggy==0.13.1,poyo==0.5.0,py==1.10.0,pycodestyle==2.7.0,pycparser==2.20,pyflakes==2.3.1,Pygments==2.10.0,PyNaCl==1.4.0,pyparsing==2.4.7,pytest==6.2.5,pytest-testinfra==6.4.0,python-dateutil==2.8.2,python-slugify==5.0.2,PyYAML==5.4.1,requests==2.26.0,resolvelib==0.5.4,rich==10.9.0,ruamel.yaml==0.17.16,ruamel.yaml.clib==0.2.6,selinux==0.2.1,six==1.16.0,subprocess-tee==0.3.2,tenacity==8.0.1,text-unidecode==1.3,toml==0.10.2,typing-extensions==<IP_ADDRESS>,urllib3==1.26.6,wcmatch==8.2,websocket-client==1.2.1,yamllint==1.26.3,zipp==3.5.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
For it to works
Actual Behaviour
On a jenkins debian10 worker installed with docker and no podman

command not found in PATH podman

With either driver: docker or driver: containers
It works on my workstation, with both podman & docker

Duplicate of https://github.com/ansible-community/molecule/issues/3226

My bad, the title mislead me a bit and then I also misread the report. Sorry for the churn.

We're experiencing this issue too. I implemented a bandaid fix by symlinking docker to podman. Seems to be working so far.
ln -s /usr/bin/docker /usr/bin/podman
As a test, I installed molecule 3.4.0, ansible 3.4.0 (2.10.13) and the latest molecule-containers plugin in a fresh environment - this allowed me to reproduce the problem. I'm still trying to pinpoint exactly what the cause is.
Installed pip packages:
ansible             3.4.0 ansible-base        2.10.13 ansible-compat      0.5.0 ansible-lint        5.1.3 arrow               1.1.1 bcrypt              3.2.0 binaryornot         0.4.4 bracex              2.1.1 cached-property     1.5.2 Cerberus            1.3.2 certifi             2021.5.30 cffi                1.14.6 chardet             4.0.0 charset-normalizer  2.0.4 click               8.0.1 click-help-colors   0.9.1 colorama            0.4.4 commonmark          0.9.1 cookiecutter        1.7.3 cryptography        3.4.8 distro              1.6.0 docker              5.0.2 enrich              1.2.6 idna                3.2 importlib-metadata  4.8.1 Jinja2              3.0.1 jinja2-time         0.2.0 MarkupSafe          2.0.1 molecule            3.4.0 molecule-containers 1.0.0 molecule-docker     1.0.2 molecule-podman     1.0.1 packaging           21.0 paramiko            2.7.2 pip                 21.0.1 pluggy              0.13.1 poyo                0.5.0 pycparser           2.20 Pygments            2.10.0 PyNaCl              1.4.0 pyparsing           2.4.7 python-dateutil     2.8.2 python-slugify      5.0.2 PyYAML              5.4.1 requests            2.26.0 rich                10.9.0 ruamel.yaml         0.17.16 ruamel.yaml.clib    0.2.6 selinux             0.2.1 setuptools          57.4.0 six                 1.16.0 subprocess-tee      0.3.2 tenacity            8.0.1 text-unidecode      1.3 typing-extensions   <IP_ADDRESS> urllib3             1.26.6 wcmatch             8.2 websocket-client    1.2.1 zipp                3.5.0
All Molecule commands produce the same error, seemingly.
# mol --version command not found in PATH podman

I did some testing I found out that the real cause behind this issue is https://github.com/ansible-community/molecule-podman/pull/53. Before that PR was merged, the podman executable was loaded lazily (when actually needed), but that PR changed the behavior and started loading the podman executable at drive initialization time (https://github.com/ansible-community/molecule-podman/pull/53/files#diff-7df8585419271bfb1adee6f8eabda2ee840744ac690655432417f05481fadf05R156-R163).
I am moving the issue to molecule-podman directory since the issue stems from there.


Switch from Travis to Gitlab

cc @ddorgan
TODO still:

[ ] Add windows build
[ ] Remove travis.yml

I think yarn test should stay though ^^

Which mac os x artifact do you want?
• building        target=macOS zip arch=x64 file=dist/Parity Fether-0.1.0-mac.zip
• building        target=DMG arch=x64 file=dist/Parity Fether-0.1.0.dmg
• building block map blockMapFile=dist/Parity Fether-0.1.0.dmg.blockmap

For mac: the .zip and .dmg
For windows: the .exe
For linux: AppImage, snap, deb and tar.xz


Enable disconnect or network change when connected to wrong network

Clicking on the "Wrong Network" button should open the network change dialog. Like it does on create.zora.co.
See openChainModal in the custom button example here: https://www.rainbowkit.com/docs/custom-connect-button

completed via 9fd7d0d.