Can ChangeStar be used for general CD?

hi,
Thanks for the great work.
I wonder, can this work be used for general change detection? i.e., multi-class not just single class.
If yes, do you have done the experiments? Thanks!

hi,
Thanks for the great work. I wonder, can this work be used for general change detection? i.e., multi-class not just single class.
If yes, do you have done the experiments? Thanks!

Of course, ChangeStar is a unified architecture for change detection, e.g., binary, semantic change detection.
Under bitemporal and semantic supervision, it works well.

BTW, how do you prepare the "targets" for tier3 of xview2? Thanks!

We have released these files here https://github.com/Z-Zheng/ChangeStar/releases/download/v0.1.0/xView2-tier3-targets.zip
Hope this helps.


When Updating Module from PSGallery configuration file gets removed.

This happens because of the module versions number folders. Will need to copy the last file from the previous version.

This has been tested.

Fixed in #107


when a sip request emits 'cancel' it should have as property the CANCEL message

Currently when an application handles the cancel event it has no access to the actual CANCEL message, i.e.
req.on('cancel', () => ..)

It would be useful if the event included the actual CANCEL request, so that the application could get any headers, if needed, i.e.
req.on('cancel', (msg) => ..)

fixed in 4.4.43


Can't Equip Rough Sense Stone (The Mighty Sand Yak)

No equip button, and double clicking isn't working. Have closed game and tried again several times.
On inspecting element I saw it had class "locked", which, once removed, allowed me to equip the item and proceed.

You are supposed to buy it with the unlock button after selecting it:


Improper positioning

Is your feature request related to a problem? Please describe.
On the main page, the tiles are in quite an improper position.
Describe the solution you'd like
Aligning all tiles to the same baseline.
Are you willing to contribute to this issue? [Yes/No]
Yes
Additional context

@Praful932 is this problem going to be solved by #48

@Praful932 is this problem going to be solved by #48

Nope we can take this here

Can I work on this issue?

Yea go ahead


Table process_int_source_sink is invoked twice

process_int_source_sink is invoked twice because, at the end of ingress, we do not have the egress port (added right before egress started), the portion that looks at it will work to see if we is sink, change to a different operation to save performance
because of the above, there will be 2 different references to the same action, which may cause problems in the future:
EgressPipeImpl.process_int_source_sink.tb_set_sink
and
IngressPipeImpl.process_int_source_sink.tb_set_sink

I moved cloning back to ingress, now there is again just one table invocation.


Changed test on topp.

We already checked that it's between 0.0 and 1.0 when it has been set, there's no need to do it again (every time).

Does it actually make logical sense? if topp == 0, logically it's the same as greedy.

Yes, currently the test is:
        // we sample from this distribution to get the next token
        if (topp <= 0 || topp >= 1) {
            // simply sample from the predicted probability distribution
            next = sample_mult(logits, sampler->vocab_size);
        } else {
            // top-p (nucleus) sampling, clamping the least likely tokens to zero
            next = sample_topp(logits, sampler->vocab_size, topp, sampler->probindex);
        }

but topp is within 0.0 and 1.0, meaning that the sample_mult() will only be called when topp == 0.
Is to avoid having an additional test.

Wait, the test leaves open the possibility that topp == 1.0.  Does it make sense to have topp at 1.0?
Previously topp= 1.0 meant the same as 0.0 ....

topp==1.0 totally makes sense and logically means exactly what follows in the current code:
// simply sample from the predicted probability distribution
next = sample_mult(logits, sampler->vocab_size);

which is exactly what is documented here ("1.0 = off") :
https://github.com/karpathy/llama2.c/blob/ee95b1bf2943f87bc3e2c845bf07a733aca3806b/run.c#L713
The only reason not to use "topp=1.0" to indicate "off" in the actual code is to prevent using topp in combination with topk, which was always the tradition in LLMs.

@ozabluda is correct, closing


[GOBBLIN-1914] Configurable Gobblin Application Master class for Yarn

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1914] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1914

Description

[X] Here are some details about my PR, including screenshots (if applicable):
The current design of the GobblinApplicationMaster has a heavy dependency on Helix task framework. Going forward, we'd like to explore Gobblin on Temporal as an alternative to Helix TF. I am requesting the ability to add specify a custom Application Master class from the Azkaban yarn app launcher to allow experimentation with different GobblinAM implementations that do not rely on Helix.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Existing unit tests / internal testing

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3781 (471a96e) into master (a289613) will decrease coverage by 1.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3781      +/-   ##
============================================
- Coverage     47.30%   46.11%   -1.20%
+ Complexity    10953     2183    -8770
============================================
  Files          2152      416    -1736
  Lines         85114    17987   -67127
  Branches       9452     2191    -7261
============================================
- Hits          40263     8294   -31969
+ Misses        41197     8812   -32385
+ Partials       3654      881    -2773

see 1743 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


use cuda for prediction

May you guide me to use predict in cuda for better performance? Thanks a lot
(https://github.com/unilight/sheet?tab=readme-ov-file#i-just-want-to-use-your-trained-mos-predictor)

    ssl_mos_predictor = torch.hub.load("unilight/sheet:v0.1.0", "default", trust_repo=True, force_reload=True)
    ssl_mos_predictor.model.cuda()

    result= ssl_mos_predictor.predict(wav=torch.rand(16000).cuda())

I modified the code for CUDA. Try to use this :)

Thank a lot @sh-lee-prml sh

@sh-lee-prml Thanks a lot! I will modify the readme with your suggestion :)


overline/underline issue not resolved

https://github.com/mathjax/MathJax/issues/2701 is closed but not resolved in 3.2.0.
\overline and \underline are not visible ...
... on Firefox in Windows 10 v20H2 and v21H1, underline and overline not visible at 90% or 120%;
... on Firefox on Ubuntu 21.10, underline and overline not visible at 80%, 100% (but visible at 110+%)

Just a bystander here. You might want to post a minimal example exhibiting the problem (including screen information as this depends on pixel density). But the problem is ultimately a browser bug that MathJax can, at best, try to work around.

Thank you. \overline{A} will demonstrate the issue. We've tested this on Windows 10, desktops and laptops at various screen resolutions, and it is consistent. We tried changing the underlying CSS to correct it, without success, but we're not experts in that regard.
(Chrome displays the overline or underline at all the magnifications that we tried, on several devices including iPads. So, yes, a browser bug.)

It seems you've confirmed that this is not a bug with MathJax. Consider filing an issue with Firefox.

Bug report filed with Mozilla:   https://bugzilla.mozilla.org/show_bug.cgi?id=1741887

I added my use case to the mozilla bug report, but there seems to be limited interest in fixing it. What a pity!


StorageAccess for adapters is undefined when standard: true

According to the docs, standard: true in bidderSettings allows storage access to all adapters. In the config panel, under Bidder Settings, storage access lists all adapters with their own setting (the explicit assignment to each one or undefined otherwise). This is misleading because access is granted globally.
Maybe we can show that access is allowed if standard: true exists, or at least put a side note for this?

Thanks for the reply!
Here is an example of a bidderSettings config

You can see here that standard: true, nonetheless storage access is evaluated to undefined for all the adapters.
It is true that they were not explicitly configured with storageAllowed: true, but they can access local storage.
You can watch it here.

Hi @erezbens ,
i just pushed version 0.2.55 to chromes webstore that should fix your issue. please let me know if that works for you.

hi @florianerl thanks for the quick action, that’s great!


Typo fix in riemann/README.md

Line 4: "The heart of Riemann is in it's clojure based stream configurations. "
it's->its

/assign @foxish

cncf check failed, close it and re-create.


feat: add aago helper function

The aago() function returns an array of [ year, month, day, hours, minutes, seconds, milliseconds ] representing a Date instance.
I think this can be a yorlang's date representation, pending when objects are added to the language.

Thank you very much @mykeels . I'm glad you thought of this

Please can you add test cases for the feature?
They should include returning the current date when no parameter is passed

Test cases have been added


Task/close revamp

Checklist

[x] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

All fixed :+1: Ready for another review :)

what's the behaviour for double keyboard interrupts on linux during startup for this? On windows it seems to just treat each interrupt as a single keyboard interrupt on startup even if you spam it and will wait until all the shards have started up to start shutting down

@FasterSpeeding
On Windows, CTRL-BREAK, and on Linux, CTRL \ are used to murder a process immediately.
Keyboard interrupts are a polite request to close soon if possible. Processes are not required to do them as is equal with C on signal term


remove the "Description:" line when displaying the "long" usage.

Each command has a "short" and a "long" usage component.  When displaying usage for the command, the short usage is displayed first.  If there is a "long" usage, then it is displayed after a "Description:" line.  I find that it would better to not print the "Description:" line at all, so that the long usage simply continues documenting the command.

removed the "Description:" line when printing the long usage.
Tagged with v1.0.1


[Question] lowering the COMPATIBLE version to 21.0.0

We have legacy integration tests (and probably code) failing on the new BOOLEAN type so for the time being I would like to revert to setting COMPATIBLE to 21.0.0 instead of 23.0.0.
I've naively tried forcing by running ALTER SYSTEM SET COMPATIBLE='21.0.0' SCOPE = SPFILE; and restarting the database, which fails of-course.
I've looked at the createDatabase script but that doesn't seem to have an option to do this eg. setting as an env variable or similar; I've found the GH-action as well, but that has no obvious option to set the compatible level either.

Hi @mprins,
There might be a misunderstanding of what the COMPATIBLE parameter does, it can only be increased but never decreased. For more information, see the Oracle Database documentation: https://docs.oracle.com/en/database/oracle/oracle-database/23/upgrd/what-is-oracle-database-compatibility.html#GUID-4711E0D1-9FCF-4F35-85B5-52EBB437C00E
If you were to run an Oracle Database Free with COMPATIBLE set to 21.0.0, it would not allow the use of the BOOLEAN data type altogether.
It would not auto-convert these columns into VARCHAR2 or NUMBER, in case you were thinking that.

If you were to run an Oracle Database Free with COMPATIBLE set to 21.0.0, it would not allow the use of the BOOLEAN data type altogether.

This is what I would expect; we have legacy ddl that uses 1/0 and TRUE/FALSE values that are now returning boolean in the Java code thereby auto-converting the string values to boolean values, breaking the application

The database would still return a number for a NUMBER column and a string for a VARCHAR2 column (note the Typ number for the respective columns):
SQL> create table bool_test (col1 number, col2 varchar2(5), col3 bool);

Table BOOL_TEST created.

SQL> insert into bool_test values (1, 'TRUE', true), (0, 'FALSE', false), (1, 'true', true), (0, 'false', false);

4 rows inserted.

SQL> commit;

Commit complete.

SQL> select col1, dump(col1), col2, dump(col2), col3, dump(col3) from bool_test;

   COL1 DUMP(COL1)            COL2     DUMP(COL2)                            COL3 DUMP(COL3)
_______ _____________________ ________ __________________________________ _______ ___________________
      1 Typ=2 Len=2: 193,2    TRUE     Typ=1 Len=4: 84,82,85,69                 1 Typ=252 Len=1: 1
      0 Typ=2 Len=1: 128      FALSE    Typ=1 Len=5: 70,65,76,83,69              0 Typ=252 Len=1: 0
      1 Typ=2 Len=2: 193,2    true     Typ=1 Len=4: 116,114,117,101             1 Typ=252 Len=1: 1
      0 Typ=2 Len=1: 128      false    Typ=1 Len=5: 102,97,108,115,101          0 Typ=252 Len=1: 0

Would you, by chance, have the SQL statements that return BOOLEAN now instead of NUMBER/VARCHAR2?

Awesome, glad to hear it!
Hm, we do implicit data type conversions for case-insensitive 'FALSE', 'TRUE', 'YES', 'NO', 't', 'f'. I know because I put the sheet together what to convert :D
You can find the whole list here: https://docs.oracle.com/en/database/oracle/oracle-database/23/sqlrf/Data-Types.html#GUID-285FFCA8-390D-4FA9-9A51-47B84EF5F83A
Even an INSERT with a boolean value into a VARCHAR2(5) or vice versa (varchar2 value into boolean col) should work.
SQL> create table foo (b bool, v varchar2(5));

Table FOO created.

SQL> insert into foo (b, v) values ('false', false);

1 row inserted.

SQL> insert into foo (b, v) values ('FALSE', FALSE);

1 row inserted.

SQL> select * from foo;

   B V
____ ________
   0 FALSE
   0 FALSE

But in any case, I'm happy that you solved the issue!
And thanks again for using these images!


chore: bdd-gh-1587690490 to 0.0.1

chore: Promote bdd-gh-1587690490 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Merge unitest branch into dev

Merging unittest branch into dev.
After this we will remove unittest branch.

I'll be back in the office on 8/29/2016. If this isn't merged by then I'm going to merge it automagically.

There are too many changes to review from the PR page (I guess GitHub has a file/line limit).
But I was going to try to run the unittests, but am getting a few (repeated) errors:
So I may need some help figuring out my configuration issues - if you want me to test run:
Zip Name: MaritimeDecisionAidToolsTestData.zip
Extracting zip...
Deleting zip...
Downloaded MaritimeDecisionAidToolsTestData to C:\MyFiles\Work\Github\pr-test\solutions-geoprocessing-toolbox-unittest\utils\test\suitability_tests\data
Testing Visibility Range At Sea (Pro).
PYTHON ERRORS:
Traceback info:
  File "C:\MyFiles\Work\Github\pr-test\solutions-geoprocessing-toolbox-unittest\utils\test\suitability_tests\VisibilityRangeAtSeaTestCase.py", line 80, in test_visibility_range_at_sea
    arcpy.ImportToolbox(toolboxPath, "mdat")

test_GetProjectedPoint004 (capability_tests.ERGScriptTestCase.ERGTest)Traceback (most recent call last):
  File "C:\MyFiles\Work\Github\pr-test\solutions-geoprocessing-toolbox-unittest\utils\test\capability_tests\ERGScriptTestCase.py", line 185, in test_GetProjectedPoint004
    inputPoint = ERGTestUtils.getInputPointFCFromXY(-98.233824, 26.654716)
  File "C:\MyFiles\Work\Github\pr-test\solutions-geoprocessing-toolbox-unittest\utils\test\capability_tests\ERGTestUtils.py", line 53, in getInputPointFCFromXY
    sr)[0]
  File "C:\Users\Chris\AppData\Local\Programs\ArcGIS\Pro\Resources\ArcPy\arcpy\management.py", line 1361, in CreateFeatureclass
    raise e
  File "C:\Users\Chris\AppData\Local\Programs\ArcGIS\Pro\Resources\ArcPy\arcpy\management.py", line 1358, in CreateFeatureclass
    retval = convertArcObjectToPythonObject(gp.CreateFeatureclass_management(*gp_fixargs((out_path, out_name, geometry_type, template, has_m, has_z, spatial_reference, config_keyword, spatial_grid_1, spatial_grid_2, spatial_grid_3), True)))
  File "C:\Users\Chris\AppData\Local\Programs\ArcGIS\Pro\Resources\ArcPy\arcpy\geoprocessing\_base.py", line 500, in <lambda>
    return lambda *args: val(*gp_fixargs(args, True))
arcgisscripting.ExecuteError: ERROR 000258: Output in_memory\tempfc already exists
Failed to execute (CreateFeatureclass).

Note: I did try to go over the readme install steps, but a few of these steps don't seem to apply anymore (like getting submodules): https://github.com/Esri/solutions-geoprocessing-toolbox#fork-and-clone-the-repo

The first one is Issue #403.
The second is #389.
So I guess at this point we will keep the branch open and continue to fix the test issues.

... and the updated instructions should be in the README.md included in the PR, not the DEV branch, which is wrong.

Updated instructions are there in unittest branch/fork now? Or will be there when the readme is updated?
The configuration steps look the same to me: https://github.com/mfunk/solutions-geoprocessing-toolbox/blob/unittest/README.md#fork-and-clone-the-repo
The step I didn't quite understand was the step/instructions to get submodules when they aren't any submodules.

Removed the lines mentioning submodules from the README.md


improvements: welcome view

[ ] decide on a good way to sort the buildings, matching the behavior for issue descriptions suggestions if possible (#23)

Moved to Trello.


Unable the start program

System Information (please complete the following information):
Hello,
It's  my first time to use ML.NET.
I ran into debugging issues while trying run my sample sentiment classification model.
I was the final stage where I have to consume myMLApp.
Please, see the screenshot.

@Idaogah Sorry you ran into this problem. What was the build error?

When you build the project in VS does it show anything in the "Erro List"?

No. Everything works perfectly including testing.
On Thu, Jun 16, 2022 at 11:22 PM Becca McHenry @.***>
wrote:

When you build the project in VS does it show anything in the "Erro List"?
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/machinelearning-modelbuilder/issues/2149#issuecomment-1158141338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASPEBALPVTVVZRTNDXJOEV3VPOLHPANCNFSM5YRNK7OQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Apologies for the delay here. Is this error still happening?

Any update here on getting the details of the build error?

I don't have enough information to investigate this issue. if you're still seeing a problem please comment with more info.


convert svg has wrong aspect ratio

What did you expect to happen?
Expected the aspect ratio of a 10w x 4h icon to be measured as 0.4.
What happened?
Aspect ratio was instead calculated as the inverse (2.5)
Steps to reproduce

Import any non-square svg
The width prop passed to the <Svg> element will be correct
The height prop passed to the <Svg> element will be incorrect

Quick fix for now:

do a find-and-replace across the entire code base:

replace const ASPECT_RATIO = WIDTH / HEIGHT;
with: const ASPECT_RATIO = HEIGHT / WIDTH;

make sure only desired files were affected

Fixed in #27


Update tag.js

Just change delete to null, like at end of function

Coverage remained the same at 91.53% when pulling de5cca95c8af3870ae78a647733efd7fe3c0739e on marciojcoelho:patch-2 into 46b5a0f5fc03b23f6fbbf9e0fe02d56f94ca7258 on muut:dev.

What's the problem with the delete method?

Line 127 was change from
delete root._tag

to
// somehow ie8 does not like `delete root._tag`
    root._tag = null

but line 118 was not modify.

Ok thanks I got it


Refactor/32 var

Closes #32

This looks good!
But as a reviewer it would more involved, before it helps sometimes to know the type while doing review.


Variadic Pred

Why Pred have only one argument?
type Pred<T> = (v: T) => boolean;

What if I wanted to do something like this?
const h = groupWith(both(f, g))

You're right, both was typed unnecessarily strict. Changed that now. :)


Add support for passing values files

Hi!
Please add support for adding values files (-f flag in helm)
https://helm.sh/docs/chart_template_guide/values_files/

A values file is passed into helm install or helm upgrade with the -f flag (helm install -f myvals.yaml ./mychart)

Currently only default values.yaml is supported by the library

I've just published v0.0.13 which includes the feature requested in this issue:

https://repo1.maven.org/maven2/com/marcnuri/helm-java/helm-java/0.0.13/
https://github.com/manusa/helm-java/releases/tag/v0.0.13

Please, share any feedback you may have, it is much appreciated :pray:


OCSP Must-Staple support

Since Let's Encrypt allows to generate certificates with this feature, accessing to the ZNC web interface will fail in compliant browsers (e.g. Firefox with a MOZILLA_PKIX_ERROR_REQUIRED_TLS_FEATURE_MISSING error).
This might also affect IRC clients in the future if they start going compliant with this feature which makes OCSP useful.
OS/distribution version: Fedora 27
/znc version: 1.6.6, IPv6: yes, SSL: yes, DNS: threads, charset: yes

https://gist.github.com/sleevi/5efe9ef98961ecfb4da8 has more details how to
do this.
There are 2 parts - obtaining the staple, and sending it to client. ZNC
could read the staple from a file, and rely on some other software to
update it regularly.
2018-04-16 3:06 GMT+01:00 Francisco de la Peña<EMAIL_ADDRESS>
Since Let's Encrypt allows to generate certificates with this feature,
accessing to the ZNC web interface will fail in compliant browsers (e.g.
Firefox with a MOZILLA_PKIX_ERROR_REQUIRED_TLS_FEATURE_MISSING error).
This might also affect IRC clients in the future if they start going
compliant with this feature which makes OCSP useful.
OS/distribution version: Fedora 27
/znc version: 1.6.6, IPv6: yes, SSL: yes, DNS: threads, charset: yes
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/znc/znc/issues/1516, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT15KLNxezzMNhxKA4K7O2kneTjI4ipks5to_ywgaJpZM4TVw6G
.

I now we're not fond of "me too" comments, but I've just now been bitten by this.
ZNC is now the only software on my server that doesn't support OCSP.
Emacs ERC and Circe are both complaining that they can't properly verify the security.


Split big cmd/pg2sink/main.go into separate command files

Command implementation should be placed in cmd/pg2sink/cmd/{stream,add,remove,resync}.go files, and the main.go file contain only glue code.

#36 separates commandline code into cmd/pg2sink/cmd package, and cleans things up. It also removes all commands other than the stream function, so it hasn't exactly 'fixed' this issue

I'm going to close this issue as at present, we have no sub-commands. I'd rather re-open if those get reintroduced.

I'm going to close this issue as at present, we have no sub-commands. I'd rather re-open if those get reintroduced.


Properties of type "number" of "integer" without format lose their "enum" and "defaultValue" at import

Affect
swagger-core 1.5.13
How to reproduce
Example of swagger definition that loses enum and defaultValue at import:
---
swagger: "2.0"
info:
  version: 1.0.0
  title: Examples
paths: {}
definitions:
  AnObject:
    type: object
    properties:
      numberProperty:
        type: number
        default: 2
        enum: [ 2, 42, 666 ]
        minimum: 2
        maximum: 666
      integerProperty:
        type: integer
        default: 2
        enum: [ 2, 42, 666 ]
        minimum: 2
        maximum: 666
        example: 2
        multipleOf: 2 # Not supported by RWADef 3.0

Cause:
Swagger parser (inPropertyBuilder class):

parses numberProperty into DecimalProperty that doesn't have those two fields contrary to DoubleProperty.
parses integerProperty into BaseIntegerProperty that doesn't have those two fields contrary to LongProperty.

Resolution proposition
Either add the missing attributes in DecimalProperty and BaseIntegerProperty
or deserialize in the largest implementation:DoubleProperty and LongProperty

Please supply a test case showing the issue

I added this PR with a failing unit test: #2180

Hello, any news about this issue?

Same issue here. I agree with @boillodmanuel 's resolution proposal: add the missing attributes in DecimalProperty and BaseIntegerProperty.


Add Pad{Left,Right} extensions for LocalisableString and ILocalisableStringData

For use in https://github.com/ppy/osu/pull/22208#discussion_r1070462373. Mirrors string.Pad{Left,Right} methods.

Not sure whether these methods should still exist, given that the only use case for them was deemed bad in the first place. I understand that LocalisableString should have similar methods to string, but probably not worth adding it if it won't be used anyway? @ppy/area-client thoughts?

Tend to agree that this should not be a thing.

Closing as it's not needed. Can be revisited if it ever comes up as a valid use case,


Allow option to disable zipkin calls when tracing is enabled

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Zipkin was removed from our k8s clusters, but there is currently no way for us to remove reference to it from our Istio ConfigMaps without disabling tracing altogether. The failed calls to zipkin result in an excessive amount of error logs (I'm assuming the calls are retried in the event of failure). We would like an additional option added to the Istio configuration to enable tracing headers, but disable sending traces to zipkin.
Describe alternatives you've considered
We have explored sending the traces to Datadog, but 1) this would add to our networking costs, and 2) many of our applications send these headers through to Datadog already in their own logs, so the calls would be redundant.
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[x] Networking
[x] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

That's correct. I considered opening this as a bug as we do not have zipkin in our istio install, but it attempts to send the trace regardless.

https://github.com/istio/istio/pull/34217 allows this

@howardjohn I think https://github.com/istio/istio/pull/34217 did not fix this, GetEffectiveTemplatePath will return default tracing with zipkin configuration.

It did at one point... maybe it regressed

Will need to check this with my team (am currently on parental leave), but I'm gathering it's possible the linked issue does not resolve my report?

Any instrustuctions didn't works for me, but after all I disabled zipkin by explicity add podAnnotation to every pod with sidecar and istio gateways:
        podAnnotations:
          proxy.istio.io/config: |
            tracing: {}

That will overwrite any upstream settings.


fix(gateways): ensure gateway linking uses ids rather than names

Similar to https://github.com/kumahq/kuma-gui/pull/2380

Can you please add some tests for this so we can’t mess this up anymore?

Yeah sure I can do that in a follow up?

Sure

Tests added here https://github.com/kumahq/kuma-gui/pull/2386


Board Review: Small, Targeted Change for Azure.DigitalTwins.Core

We intend to release a new data plane API version - 2021-06-30-preview - that is identical to the current API version 2020-10-31 (for which a GA SDK exists). The only differences are:

API version 2021-06-30-preview added
src/Models/DigitalTwinPropertyMetadata.cs contains a new optional, writeable property sourceTime

Link to changes: https://github.com/Azure/azure-sdk-for-net/pull/26495/files . All other changes are a result of auto-generation, adding new API version, recording a set of new service traces for playback when running tests.
We were asked by the architecture review board to introduce a new API version, since PUT / PATCH of a sourceTime attribute results in a different response in currently supported API versions.
Please let us know if a full review is required, or if this can count as a small, targeted change. We are trying to add this feature in as soon as possible, ideally before February 15th.
Contacts and Timeline

Responsible service team: Azure Digital Twins
Main contacts: @sjiherzig
Expected code complete date: 2/7/2022
Expected release date: 2/15/2022

About the Service

Link to documentation introducing/describing the service: https://docs.microsoft.com/en-us/azure/digital-twins/overview
Link to the service REST APIs: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/digitaltwins/data-plane/Microsoft.DigitalTwins/preview/2021-06-30-preview/digitaltwins.json
Link to GitHub issue for previous review sessions, if applicable:  N/A

About the client library

Name of the client library: Azure.DigitalTwins.Core
Languages for this review: .NET

Required artifacts
.NET

APIView Link: https://apiview.dev/Assemblies/Review/a33bab59b8bc43cdb83cf35b366016fa
Link to Champion Scenarios/Quickstart samples: (unchanged)

@sjiherzig - does this need a full Board review or are you already working with the respective architects? Thanks


NPM Update (devDependencies)

Codecov Report

Merging #6 (73ef11b) into main (ee9c528) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files           4        4
  Lines         178      178
  Branches       24       24
=======================================
  Hits          170      170
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9c528...73ef11b. Read the comment docs.

Codecov Report

Merging #6 (73ef11b) into main (ee9c528) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files           4        4
  Lines         178      178
  Branches       24       24
=======================================
  Hits          170      170
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9c528...73ef11b. Read the comment docs.


Fix and test type mismatch for memview of extension types indexing

Following test code produces C code that fails to compile:
> cdef class ExtensionType(object):
>     cdef public int dummy
>     def __init__(self, n):
>         self.dummy = n
>     cdef cfoo(self):
>         print self.dummy
>
> items = [ExtensionType(1), ExtensionType(2)]
> cdef ExtensionType[:] view = np.array(items, dtype=ExtensionType)
> view[0].cfoo()

with gcc error and relevant C file lines:
extension_type_memoryview.c:2604:94: error: ‘PyObject’ has no member named ‘__pyx_vtab’
2570:  PyObject *__pyx_t_1 = NULL;
(...)
2601:  __pyx_t_1 = (PyObject *) *((struct
    :__pyx_obj_25extension_type_memoryview_ExtensionType * *) ( /* dim=0 */
    : (__pyx_v_25extension_type_memoryview_view.data + __pyx_t_2 *
    : __pyx_v_25extension_type_memoryview_view.strides[0]) ));
2602:  __Pyx_INCREF((PyObject*)__pyx_t_1);
2603:  /* __pyx_t_4 allocated */
2604:  __pyx_t_4 = ((struct
    : __pyx_vtabstruct_25extension_type_memoryview_ExtensionType *)__pyx_t_1
    :->__pyx_vtab)->cfoo(__pyx_t_1); if (unlikely(!__pyx_t_4)) {__pyx_filename
    : = __pyx_f[0]; __pyx_lineno = 69;

It seems that generic PyObject* temporary for __pyx_t_1 is used here while
typed ExtensionType* temporary should have been used instead (as suggested by
excess casting on line 2601).
I've found this is caused by following check in ExprNode.allocate_temp_result():
> if type.is_pyobject:
>     type = PyrexTypes.py_object_type

Removing the check breaks everything, so I suppose it is intentional (what's
its purpose?) and I've resorted to overriding allocate_temp_result() in
IndexNode and skipping the check in the very special case of memoryview direct
indexing.
This fixes the test-case and doesn't break other tests, but sounds a bit hacky
and may be actually completely incorrect.

Status: issue is a bug, test code is good, patch is not good.


Damage tint issue for 1.17 and 1.18, and mod incompatibility

The red damage tint isn't applied to the skin additions after taking damage in 1.17.1 and 1.18 (Only tested with fabric).

Skin additions get displaced along with the Wildfire's Female Gender Mod breast size slider (might be a issue for the creator of that mod).

I am aware of this issue being present for 1.16.5 and 1.17.1 instances (Only tested with fabric).

Cannot reproduce.

Happens to me on forge, without any other mods.
Minecraft: 1.18.2
Forge: 40.1.80
Ears: 1.4.5
Graphics (reported by F3 screen): GeForce GTX 1660 SUPER/PCIe/SSE2; 3.2.0 NVIDIA 461.09


Create the Home / Landing Page of the site

Create the Home page of programming community site using basic HTML, CSS and JavaScript which contains a basic introduction about programming community and cards containing informations about other pages with visit link.
You can use any dummy image in the image tag or places where image is required for now.
The files for the Home pages are index.html for CSS use index.css and for JavaScript use index.js.
Request to assign the issue to avoid any conflict.

@Aryan-Kumar-Thakur please could you assign this task to me

@Aryan-Kumar-Thakur please could you assign this task to me

sure, @Prithwi32 . I assign this to you. Feel free to make a PR when you are done with your work. All the best 👍

@Aryan-Kumar-Thakur please could you assign this task to me

sure, @Prithwi32 . I assign this to you. Feel free to make a PR when you are done with your work. All the best 👍

Hey could could you review my PR and suggest me

@Aryan-Kumar-Thakur Hey please could you review my PR and suggest me

Hey, sorry for the delay. we would like to inform you that we merge your PR. Thank you for your contribution. we are looking forward for more contribution from your side. Have a nice day !!.

@Aryan-Kumar-Thakur Hey please could you review my PR and suggest me

Hey, sorry for the delay. we would like to inform you that we merge your PR. Thank you for your contribution. we are looking forward for more contribution from your side. Have a nice day !!.

@Aryan-Kumar-Thakur
Sure :)
Thank you.. you made my day!


Bug 1706103 : Dockerfile: set coreos org as canonical for release-3.3

This was an oversight by me but it must be fixed before GA.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1706103
Requires: https://github.com/openshift/release/pull/3693

/cc @smarterclayton PTAL I am not sure exactly on the ordering here if this should merge then release?

/hold cancel

If you have release ready we should merge this, then release.

@smarterclayton can you bless this, please I am coordinating with release.

/cc @wking @deads2k

/lgtm


Make instructions.json format localizable

For the instructions strings file, we should use a format that standard localization tools can work with. What we have now is more or less the JSON key-value format supported by Transifex, but with an informal mini-language around placeholders and optional clauses. This format has some downsides for localization:

No way to provide comments to localizers

Switching to Chrome JSON format would address this issue.

No way to vary capitalization or word order when a clause is omitted

We should get rid of all [optional] clauses and enumerate all the possibilities. String concatenation always works against localizability.

No way to vary surrounding words based on a placeholder’s number or grammatical gender

We could build this ourselves by allowing any string to be replaced by an object mapping number patterns (ONE, TWO, MANY) to message variants, but localizers would be unable to add their own variants using a tool like Transifex.

Primarily for (3) and so that other clients don’t have to build their own custom parsers, we should consider switching to one of the other Transifex formats that happens to support these features. As an iOS developer, I’m most familiar with .strings and .stringsdict, but gettext and XLIFF are solid formats that support all the features we need for localization while being compatible with Node, Android, and iOS development.
Depends on #6 and #5.
/cc @bsudekum @MoKob @freenerd @zugaldia

After #27 this is were we are at:

No way to provide comments to localizers

This is not there yet, using chrome json as suggested feels like a good idea. Need to do a sample implementation of that.

No way to vary capitalization or word order when a clause is omitted
We should get rid of all [optional] clauses and enumerate all the possibilities. String concatenation always works against localizability.

We have no optional clauses anymore, everything is spelled out completely in whole strings. We still have string interpolation via {token}.

No way to vary surrounding words based on a placeholder’s number

I don't think we actually have a counting problem in instructions right now. We have ordinalization, which is included.

No way to vary surrounding words based on [..] grammatical gender

We do not have grammatical gender support. Translating to german (which is gender-aware) might be a good test
Next:

[ ] Test Chrome JSON
[ ] Get trans

We have a couple of languages in now and that seemed fine. Closing until we run into problems again (comments, counting, gender)


How to use with node-webkit-builder in Linux?

How should you use this with node-webkit-builder, when it produces zip format and you require tar.gz?

I haven't used the two together on Linux yet. Suggestions / pull-requests welcome


Polish the names for ResourceMover

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.ResourceMover


Update Dockerfile to 1.14.2 version of aws-cli

https://pypi.python.org/pypi/awscli/1.14.2
User that previously worked with Basic projects had expected behavior/functionality of most recent aws cli (ticket).

@mlocher is there a way to simultaneously run the test build and view the provisioned application/environment in an AWS dashboard, perhaps note the (non-"Ready") state?

@whiteotter Yeah, you'd need to be logged in to our AWS sandbox account. Jim can provide you with access if you don't have it already.
However, since the environment is in a healthy state according to the lines 57 to 61, and is again in a healthy state when the cleanup function is run, which (according to the times on the last run I did) is roughly 1.5 seconds apart, I wouldn't expect to get a lot of information from watching the dashboard. (That said, I could absolutely be wrong with that assumption.)

@mlocher Stack Overflow post is suggestive of issue being IAM policy related. This would also explain why previously passing builds are now failing.

@mlocher looks like the final blocking item was updating the index.html file pathing on nginx to properly send out the commit id ¯_(ツ)_/¯

@whiteotter Nice catch, and awesome this is finally working again.
:shipit:


Require explicit rmin for LAMMPS tabulated pair potential

This PR explicitly requires the user to set a nonzero rmin when using LAMMPS.
Fixes #107

This is a small change, merging without review.


avgForEach is not specialised

The method avgForEach returns Array(Float64) when used on Array(Float32) column.
This is forcing to use arrayMap with toFloat32 to have the Array(Float32) back.
I think this could be more effective to have a specialized version which is not keeping Float64 in memory in forcing another loop to convert it in the initial type.

avg always return Float64 (the only exception is Decimal):
select toTypeName( arrayReduce('avg',[0]) );
It's here:
https://github.com/yandex/ClickHouse/blob/47dd1730072d98ff2d598edbbabb3d108a37373d/dbms/src/AggregateFunctions/AggregateFunctionAvg.h#L47

Could I implement the new function which should return Float32?

Sure - it would be appreciated.


auto mirroring

Hi,
when working on object detection with real world data, a feature witch mirrors images and annotations automatically would be real useful as it doubles the amount of input information without a lot of effort for the user and you know that data preparation is the most effort.
Please think about it.
kind regards
Roman

Hi @romanoss ,
Just to make sure we understand your use case, do you mean something that visualizes the annotations on the images?
Thanks,
Shantanu

Sorry for being not exact.
No, I mean an automatism which eg duplicates the training images and annotations automatically before training. Imaging when u train the detection of animals (cats). A mirrored image has for sure the same classification and is a very likely version of reality. Annotating large image training sets is painfully.
A simple flag like mirror='true' which adds a mirrored duplicate (with the mirrored annotation info) to the training data in object_detector.create() would be really helpful and should be easy to implement and goes well with the principles of turicreate (being comfortable) as I understand.
Thanks
Roman

The object detection toolkit performs data augmentation automatically, and one of the augmentations is that with probability 0.5, each image is flipped horizontally. (There’s currently no way to disable this augmentation in the Python API, but we may expose augmentation options in general at a later date.)


chown 1000 --> chown 100

Apparently the git uid is 100 not 1000

Thanks for your pull request!
It made me realize that the permissions should be fixed automatically at container startup instead (see f809502)
If you pull the latest image, you won't need to do the chown anymore.


Light: new module

This allows the control of the Pebble's backlight.
Simple app to test it:
var UI = require('ui');
var Light = require('ui/light');

var main = new UI.Card({
  title: 'Light test',
  body: 'UP -> Light.on()\nSELECT -> Light.auto()\nDOWN -> Light.trigger()'
});

main.show();

main.on('click', 'up', function(e) {
  Light.on();
});

main.on('click', 'select', function(e) {
  Light.auto();
});

main.on('click', 'down', function(e) {
  Light.trigger();
})

Really cool! Thanks a lot!
Looks good to me but I will let @Meiguro review and confirm he is ok with it!

Nice work, it looks good! I just merged in it. Now you've seen the huge mess that is simply-pebble.js. I want to split that up some time.

Yep 😄 Now I'm considering to implement the "Wake Up" functionality.

Haha, I feel extremely bad about how much I've delayed that feature #7. I want to try to have the feature ready for a hackathon next week however, so I've finally been making progress in that area. simply_msg.c was getting huge so I decided to move the differing sections of simply_msg.c into their respective module files in order to make writing new C-dependent features more simple. It reduced code size by a few bytes as a bonus.
With that, I was able to use the wakeup API, but I think it needs some sugar similar to the settings module to feel at home with the pebble.js API's. If you've made some work I can merge with yours before I've finalized anything! I've still not a solution in place for how to calculate a timestamp for a certain time on a particular weekday for example. I may see if there is an MIT/BSD micro library, or write a small utility function.

I've just written a little function Wakeup.schedule(timestamp, notify_missed) that does what you expect, but nothing more :).
In the matter of the timestamp, I used the moment.js library that is already present under vendor:
Wakeup.schedule = function(timestamp, notify_missed) {
  time_f = moment(timestamp * 1000);
  // HACK: because of no timezone support on the Pebble, we need to remove
  // the timezone from the timestamp
  var no_tz_time = moment(time_f.format('YYYY-MM-DDTHH:mm:ss') + "+00:00").unix();
  simply.impl.scheduleWakeup(no_tz_time, notify_missed);
};

The problem is that as soon as the Pebble OS will support the timezone, this will break badly.

Ah, for some reason I had thought I removed moment! I might make use of that for the weekday calculations.
We have nearly the same API then! I've decided to add a callback in case of scheduling errors, and will pack the event with information on what kind of failure. It is actually similar to the Settings module.
Yes, the timezone stuff is definitely nasty. There's also issues with app messages coming in before the app message listener is ready, making a wakeup event possibly missed. To work around these issues, I added Ready and LaunchReason. The watch sends the LaunchReason after receiving Ready which also contains the watch's current timestamp. I calculate a timeOffset within 30 minute resolution and use that to offset subsequent timestamps. timeOffset should be 0 when timezone support is added. The only issue is that timeOffset is initialized with the current timezoneOffset, so there is a small window of an incorrect timeOffset being used after such a new firmware.
Thinking about it again, I should test if no app messages are ever missed if app message is registered outside of the PebbleKit ready event.

On Pebble you can detect whether the timezone is set.

Right, we could ask the pebble if the timezone is set, otherwise use the "hack".

On 22/feb/2015, at 20:49, Thomas Sarlandie<EMAIL_ADDRESS>wrote:
On Pebble you can detect whether the timezone is set.
—
Reply to this email directly or view it on GitHub.


Fix typo kakfa to kafka

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I just deployed replicator with rbac and i saw some typo kakfa is wrong on some params so i changes it.
Test Configuration:
Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Any variable changes have been validated to be backwards compatible

Thanks @thititongumpun for the pointing out the mistake and fixing it :-) Since, its not breaking the functionality, I would request you to raise the PR against 7.2.x branch Thanks.

@nsharma-git Isn't renaming a variable breaking from a user point-of-view? I think so. Maybe "alias" the var-names, as I think we have done previously.

Thanks @thititongumpun for the pointing out the mistake and fixing it :-) Since, its not breaking the functionality, I would request you to raise the PR against 7.2.x branch Thanks.

@nsharma-git Isn't renaming a variable breaking from a user point-of-view? I think so. Maybe "alias" the var-names, as I think we have done previously?

@erikgb Yes, it would be a breaking change from user's perspective. In my earlier comment, I meant to say that the current variables are not breaking the functionality so I don't want to push these changes in -post branch. For 7.2.x we should make aliases and deprecate the older one.


Delete account

Subject: Delete account
Description:
I would like to delete my account.
Results:
It is not clear how to delete my account and all of my data.
Backend version: develop-0a2f2ed7
Frontend version: develop-0a2f2ed7
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36
Page: https://app.couchers.org/
User: gabriele (5056)

Forwarded to support


testinfra/modules/blockdevice: Don't fail on stderr

The blockdevice module raises a RuntimeError if blockdev returns with a non-zero exit code, or if stderr is not empty.
But the latter can happen even when there's no failure at all, for instance if sshd has a banner message configured (which gets output to stderr whenever someone connects to the host).

Merged, thanks!


QueueTrigger function from Quickstart shows Indexing method error

From @SimonGuo009 on April 25, 2017 9:47
Environment URL: functions.azure.com
Corresbonding Ibiza URL: ms.portal.azure.com
App runtime version: ~1
Proxy runtime version: ~0.2
Private Site Extension: 1.0.10913
Repro steps:

Create a new function app.
Click on "+" button to open Quickstart page.
Choose "Data Processing" then click create. (Language does not matter)
Verify its Develop was opened automatically, along with the error messages.

Please refer to snapshot:

Copied from original issue: projectkudu/AzureFunctionsPortal#1244

We saw an issue with a very similar error yesterday in triage, but I can't seem to find it. @christopheranderson , @fabiocav?
I tried with the new build and did not see this when creating a new queue triggered function. So I'm thinking it's caused by something else and may not be a regression in the new build (though still it's bad, obviously).

@MikeStall, @mathewc thinks this is a regression from the BYOB changes. What do you make of it?

From @fabiocav on April 25, 2017 16:24
This was the issue we looked at yesterday: https://github.com/Azure/azure-webjobs-sdk-script/issues/1446

We've now confirmed that it's a regression. It happens when connection is set to empty, which is what the quickstart does (as opposed to the normal templates):
{
  "disabled": false,
  "bindings": [
    {
      "name": "myQueueItem",
      "type": "queueTrigger",
      "direction": "in",
      "queueName": "myqueue-items",
      "connection": ""
    }
  ]
}

If you do this with new build, it fails with:
Error:

Function ($QueueTriggerCSharp2) Error: Microsoft.Azure.WebJobs.Host: Error indexing method 'Functions.QueueTriggerCSharp2'. Microsoft.Azure.WebJobs.Host: Microsoft Azure WebJobs SDK '' connection string is missing or empty. The Microsoft Azure Storage account connection string can be set in the following ways:
 1. Set the connection string named 'AzureWebJobs' in the connectionStrings section of the .config file in the following format <add name="AzureWebJobs" connectionString="DefaultEndpointsProtocol=http|https;AccountName=NAME;AccountKey=KEY" />, or
 2. Set the environment variable named 'AzureWebJobs', or
 3. Set corresponding property of JobHostConfiguration.
Session Id: 9e440394ce974b90a2a2972c6655f11e

Timestamp: 2017-04-25T17:25:59.120Z

Ok, so same error, but in that case, I think she really had a missing connection string, while here it should have been clean.

https://github.com/Azure/azure-webjobs-sdk/blob/e2fafe557738c09fdd1130517531e57570ebd3ba/src/Microsoft.Azure.WebJobs.Host/Executors/StorageAccountProviderExtensions.cs#L44
This needs to be string.IsNullOrWhitespace
It's related the the IConnectionProvider changes - before we must have kept Connection null in this case?

It looks like it was regressed in this change: https://github.com/Azure/azure-webjobs-sdk/commit/e2fafe557738c09fdd1130517531e57570ebd3ba
if (string.IsNullOrEmpty(connectionStringName))
{
    connectionStringName = ConnectionStringNames.Storage;
}

got changed to:
connectionStringName = connectionStringName ?? ConnectionStringNames.Storage;

So good news is this was a simple well-understood tweak.
I have a local fix and unit test; I'm scanning through for other cases.

Closing as fixed


enhance: Add optional timestamp to dovecot

Currently the dovecot parser will work with dovecot configured to log to a file (with labels.type set to dovecot), however, it does not expect a timestamp within the parser we should add an optional prefix to parse a timestamp if present.
ref: #1159

also link: #1160


Revert "Workaround rootfsPropagation: shared brokenness."

This reverts commit 7efaec5886f1fe09a8ac216b9961b75af53bcc8d.
This is not needed since the update to Kubernetes 1.10.3 in #83.
Signed-off-by: Ian Campbell<EMAIL_ADDRESS>

LABELS: Debian, testing, amd64, linux
ID: 51c4e8de-3f1b-4d75-994c-51c49eca6438
[PASS    ] kubernetes.smoke.cri-bridge 189.29s
[PASS    ] kubernetes.smoke.cri-weave 232.14s
[PASS    ] kubernetes.smoke.docker-bridge 247.30s
[PASS    ] kubernetes.smoke.docker-weave 266.12s
[SUMMARY ] LogDir: 51c4e8de-3f1b-4d75-994c-51c49eca6438
[SUMMARY ] Version: testing
[SUMMARY ] Passed: 4
[SUMMARY ] Failed: 0
[SUMMARY ] Cancelled: 0
[SUMMARY ] Skipped: 0
[SUMMARY ] Duration: 935.20s

pr84.zip


Specify CMAKE_RUNTIME_OUTPUT_DIRECTORY from outside of the project

Description
Hardcoding this into the library itself means that outside consumers cannot choose a different value. This in particular breaks the CMake template project of ours which also tries to set this value. It resulted in the DLLs not being placed in build/bin as expected but rather build/_deps/sfml-build/bin.
As conventional wisdom dictates, it's best to not touch CMAKE_ variables unless necessary. Luckily our use of presents means we can easy move this into the development preset so there are no ergonomics disadvantages to this.
This problem is not present in SFML 2 because that version does not manipulate CMAKE_RUNTIME_OUTPUT_DIRECTORY. Luckily now that the template project defaults to static libs these DLL issues are harder to run into.
Thanks to @Bambo-Borris for reporting this.

Found this whilst using the template project, altered to target master. I regularly use the current state of master. I noticed that the DLLs weren't being output to the expected directory build_directory/bin when using master but were when using 2.6.0. Thanks to @ChrisThrasher for the quick spot and potential resolution for this

What do you want to do about buildbot?

The Mesa3D stuff hardcode a reference to ${PROJECT_BINARY_DIR}/bin. To make this PR work I think I need to figure out a more generic solution that doesn't depend on using that particular directory.


Support Multiple Same Kind Remediation

Why we need this PR

This PR will enable the user to select several SNR Templates (of the same kind) when using NHC escalating remediation.
In a nutshell SNR can be used several times as a remediator each time with a different fence agent.
This feature is dependent on the changes in NHC as well (which is available starting from NHC 0.8.0).
Changes made

Automatically add the MultipleTemplatesSupportedAnnotation that enables this feature via "Defaulting" (Mutating) webhook.
Support that Node's name might come from NodeNameAnnotation instead than from remediation's name (when the feature is enabled).
Updated Common package to the version shipping the new annotations needed by this feature.
Test coverage for both configurations (supported and unsupported multiple same kind remediation).

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1930
Test plan

/test 4.15-openshift-e2e

/test 4.15-openshift-e2e

/retest

/retest

/retest

/retest

/test 4.15-openshift-e2e

/retest

/test 4.13-openshift-e2e

the problem on 4.16 does not depend on us
/override "ci/prow/4.16-openshift-e2e"


pinthreads(:affinitymask) fails with hyperthreads

pinthreads(:affinitymask) fails with error message "More Julia threads than CPU-threads specified by affinity mask" when I have enough threads+hyperthreads but not enough physical cores.

I thought about this once more and it isn't clear to me why it's failing. Could you tell me what ThreadPinning.initial_affinity_mask() and threadinfo() gives on your system / in your SLURM allocation?

Closing for now. (Feel free to provide more information.)


Scripts can't reach out to other servers

We have some scripts that reach out to organization's websites and find their Twitter handle. For some reason they aren't working on api.wevoteusa.org. Can you look into why these calls aren't working from behind the load balancer?
See:
WeVoteServer/import_export_twitter/views_admin.py
def scrape_website_for_social_media_view
...and where the heavy lifting is happening:
WeVoteServer/import_export_twitter/controllers.py
def scrape_social_media_from_on_site
(code pasted below)
Please note that many other sites refuse connections that don't have a User-Agent that a normal user's browser might show.
==========
urllib._urlopener = FakeFirefoxURLopener()
headers = {
'User-Agent':
'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.64 Safari/537.11',
}
# 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8',
# 'Accept-Encoding': 'none',
# 'Accept-Language': 'en-US,en;q=0.8',
# 'Connection': 'keep-alive'
# 'Accept-Charset': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
try:
request = urllib.request.Request(site_url, None, headers)
page = urllib.request.urlopen(request, timeout=5)
for line in page.readlines():
try:
if not twitter_handle_found:
for m in re.finditer(RE_TWITTER, line.decode()):
if m:
name = m.group(1)
if name not in TWITTER_BLACKLIST:
twitter_handle = name
twitter_handle_found = True
raise GetOutOfLoopLocal
except GetOutOfLoopLocal:
pass

Joe added python3-openssl to Django server, and this allows outbound connections now.


Updated protobuf version for s390x

Signed-off-by: Mujahid-Dandoti<EMAIL_ADDRESS>
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
Updated protobuf version from 3.5.0 to 3.17.3 in protobuf.cmake for s390x.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@dandotimujahid: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dandotimujahid
To complete the pull request process, please assign ldegio after the PR has been reviewed.
You can assign the PR to them by writing /assign @ldegio in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @dandotimujahid. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@gnosek could you please have a look on my PR.

LGTM label has been added.  Git tree hash: d203fa58b14ebb1f099286425a1a8cf4b05c1bed

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dandotimujahid, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


provide insights related to new ways of optimising fuzzers

such as

insights into code that need not be compiled with sanitizers, e.g. https://blog.envoyproxy.io/a-stroll-down-fuzzer-optimisation-lane-and-why-instrumentation-policies-matter-f0012ec260b3
excessive logging areas
areas that may be overanalysed, e.g. the fuzzers are spending a lot of time in without being seemingly interesting

One other extension point we'd like to see is for infrastructure to be able to inject additional info into these reports.
e.g. on infra we have information about e.g:

Where crashes are happening. e.g. if a fuzzer keeps hitting a particular crash that's blocking it from finding more interesting bugs.
Other runtime blockers such as if something is allocating too much memory.


Upgrade float to double in cirq protos

Hi, I am suffering from the precision issue due to google protobuf.
In fact, google protobuf float is float32, and double is float64. However, python uses float only for float64, and this makes discrepancy when I saved into protobuf and reload the circuit from the proto. As it happens to others (https://github.com/quantumlib/Cirq/issues/2728, for example) I suggest that upgrading the float to double in cirq protos.
For example,
https://github.com/quantumlib/Cirq/blob/master/cirq/google/api/v2/program.proto#L146
float float_value = 1; # -> double float_value = 1;

OR at least, I hope to have double_value as one of the variables,
https://github.com/quantumlib/Cirq/blob/master/cirq/google/api/v2/program.proto#L145-L149
oneof arg_value {
    float float_value = 1;
    RepeatedBoolean bool_values = 2;
    string string_value = 3;
    double double_value = 4; # <- like this.
  }

Is this coming from Tensorflow quantum integration?  Changing double to float isn't really an option without breaking the api, but we could add a double value.

I think we need to

add double value to proto
make _arg_from_proto support double value
get _arg_from_proto version of cirq out to dependencies
make _proto_from_arg support double value (should ints be made to doubles?)

@maffoo

@dstrain115 for comment as well.

Note that we also use floats in the sweep protos for Points and Linspace: https://github.com/quantumlib/Cirq/blob/master/cirq/google/api/v2/run_context.proto#L104.
We might want to modify those as well to allow specifying doubles for people who want the higher precision.
I don't feel particularly strongly either way; it seems like the few tests that fail that can be handled with approximate equality (or might be fixed with proto 3.12 which truncates floats differently) and 32-bit floats are plenty of precision for the hardware control. On the other hand, using 64-bit doubles might reduce some surprises at the cost of a little more complexity in handling protos.

Can we clarify the problem here a little bit?
@jaeyoo so you are serializing and deserializing a Circuit and that doesn't end being equal to the original Circuit? Can you provide example code?
Can you provide some clarity around what use case does this influence in TFQ?

I got a repro as I'm wrapping my head around it:
import cirq
import numpy as np
import cirq.google as cg

X_SERIALIZER = cg.GateOpSerializer(
    gate_type=cirq.XPowGate,
    serialized_gate_id='x_pow',
    args=[
        cg.SerializingArg(
            serialized_name='half_turns',
            serialized_type=float,
            op_getter='exponent',
        )
    ],
)

X_DESERIALIZER = cg.GateOpDeserializer(
    serialized_gate_id='x_pow',
    gate_constructor=cirq.XPowGate,
    args=[
        cg.DeserializingArg(
            serialized_name='half_turns',
            constructor_arg_name='exponent',
        )
    ],
)

MY_GATE_SET = cg.SerializableGateSet(
    gate_set_name='my_gate_set',
    serializers=[X_SERIALIZER],
    deserializers=[X_DESERIALIZER],
)

q = cirq.NamedQubit("a")
circuit = cirq.Circuit(cirq.XPowGate(exponent=np.pi)(q))
circ2 = MY_GATE_SET.deserialize(MY_GATE_SET.serialize(circuit))
print(circuit[0][q])
print(circ2[0][q])
assert circuit == circ2

Prints:
X**3.141592653589793(a)
X**3.1415927410125732(a)

I've run into this before when serializing into FSIM_GATESET and then deserializing on the other side, since it wants to check if exponent is close to, say pi/6, and it is only within 1e-6 instead 1e-8 due to the down-scaling to 32 bit precision.

Thank you all for giving your attention. @dabacon @dstrain115 @balopat @maffoo . Yes, if it is the well-known practice about the proto serializer, I also want to follow up the course - rounding up :) I've struggled fixing our serializer & deserializer, and now I can see no errors without changing the proto from float to double.
Now that we decided not to work on modify proto, please let me close this issue!

Did we actually decide not to work on this?  I think we may want to consider changing from float to double.

Ahhh @dstrain115 , I misunderstood. Sorry. I decided, but not we. Thank you for the correction :) So I want to say it is not urgent to me anymore.

I went ahead and fixed items 1 and 2 from @dabacon comment in PR #3140 .  We will need to wait for a version push in order to do 3 and 4.
@maffoo In order to change Points and Linspace to double, we will need to make a new field.  So, there will be points and points_double for a while, then we will have to deprecate points in favor of points_double.  I am a bit reluctant to do that, as it introduces a new argument with worse naming.  Do you think it is worth doing that?

Is this still open?  I think double support was added, and is being used?

Not urgent, but while you are in the protos, can you check this issue, @verult ?  I believe that this has been done and that the resulting (deprecated) fields can be removed, but this could use a bit of verification, since I haven't touched this in a while.

From @MichaelBroughton: resolved by removal of TFQ proto-coupling.


v3.0.0 prerelease stratum connection issues

Mining against a p2pool node with this version is producing a stratum connection interrupted between each found share.

I think you meant to create this on the p2pool repo. https://github.com/vertcoin/p2pool-vtc

Closing this, wrong repo... meant for p2pool


Adding additional 3D sensors

The MiR100 only appears to directly support the use of 2 3D cameras, which provides a limited field of view around the robot. I was wondering if it would be possible to add additional 3D cameras to a host PC running this library and publishing this data to a topic on the MiR PC such that it can use it for obstacle avoidance.
We are currently evaluating the MiR100 for our project so I unfortunately can't test this myself. Thank you.

I have made an attempt to do just this two years ago. I added two upward-pointing Pico Flexx cameras to the front and back of the robot in order to prevent collisions with the top part of our robot. The images below show one of the cameras.
Then, I made the following changes:

run a PCL VoxelGrid filter with voxel size = 10 cm to reduce the amount of data coming from the cameras
publish the point cloud topics and the tf transforms of the camera frames to the MiR over the mir_bridge
modify the move_base configuration on the MiR internal PC to add the point cloud topics as observation_sources.

This kinda worked, but unfortunately not as well as I had hoped. There were two problems with this approach:

The processing of the additional point cloud topics really slowed down the internal MiR PC.
You often get into a situation where you have entered a dynamic obstacle (such as a person) into the costmap, then the robot moves away, and the obstacle moves away as well. However, since the cameras are pointing upwards (and not horizontally), you can never remove the obstacle again unless you drive back to the position where you first observed it. So very quickly, the map gets swamped with spurious obstacles. This makes finding a path almost impossible, and probably also contributed to the computational load on the internal MiR PC.

On the other hand, the MiR supports a very similar use case with its additional "top camera", so it must be possible somehow. But since this was not a top priority for me, I did not investigate further and just gave up after some time. I'm not saying that it is impossible.
If you want to "try before you buy", you could try including additional 3D cameras into the Gazebo simulation and move_base config in this repo. This would at least enable you to figure out solutions to problem 2. Note that I wrote the move_base config in this repo just to be able to run it in Gazebo. It's not identical to the move_base config on the actual robot. Navigation on the actual robot works even better than my config.
If you want, I can provide you the code that I wrote back then.

Thank you very much @mintar for the detailed explanation. It really helps.
I'll have a more thorough look at the simulation once I have a chance. We are mostly concerned with detecting dynamic obstacles at the payload level (somewhat similar to your use-case) so there may be a way to have some of these detected points decay over time though this is hard when you don't have direct access to the mapping and move_base nodes on the MiR.
If you would be able to share your code of your previous experiment that would be much appreciated.

If you would be able to share your code of your previous experiment that would be much appreciated.

I'm sorry I didn't reply to this earlier. If you still need the code, let me know and I'll prepare something for you. It's a bit of work for me to dig through it all and put it into a presentable format, so only tell me if you really need it, not as a "nice to have".

Thanks @mintar. I'm starting to put together the equipment to do testing. Let me look into this in more detail and see if I can figure it out myself. If I can't, I'll be sure to reach out. Thanks again.

Hi @mintar. I have a MiR250 that I am trying to control through ROS (noetic). You mentioned to have accessed the move_base inside the mir computer? How is that done? Also, is there any way of setting the robot to ignore the SICK configurations and drive close to walls?

Hi @ravescovi, since your questions are a bit different from this issue, I've created a new issue for that and will reply there: #94


Add logging

Introduce logging in the app.
Recommended libs: Slf4j, log4j

Hey! I can give assistance in Introducing logging in the app. I will be happy to help

@yashvk10 thanks for your interest in contributing. This is a student project for the students enrolled in Java course at Hillel IT School. However contributions are generally welcome.
Please drop a mail at<EMAIL_ADDRESS>with a brief description of your intention and few words about your skill set.


Feature request: Implement LMS adaptive filtering + other adaptive filters

Adaptive filtering is often used for signal noise reduction and some other cool DSP applications. The most often used one is the Least Mean Square (LMS) adaptive filter.
A very good adaptive filtering library in Python is padasip. It also has some code documentation on how the algorithm should work, both in code and on a documentation page.
Other potential good source: explanation of MATLAB LMS adaptive filtering implementation

I have been looking at introducing adaptive filters to JDSP. Might be worthwhile implementing most used adaptive filters that the given library (padasip) has.
Probably will be incorporated in a future release.

@psambit9791 am working on an LMS and NLMS adaptive filter for my application and both seem to be working. Still have to write some test and am also trying to do other adaptive filters from padasip. So you can assign this issue to me if you want

[ ] LMS
[ ] NLMS
[ ] LMF
[ ] NLMF
[ ] SSLMS
[ ] NSSLMS
[ ] RLS
[ ] GNGD
[ ] AP

@psambit9791 am working on an LMS and NLMS adaptive filter for my application and both seem to be working.

@SiboVG I have created a checklist for the filters. You can tick the ones you have worked on.
Also, in terms of the class location, it will make sense to keep them inside the filter package under a subpackage classed adaptive. The new package name being com.github.psambit9791.jdsp.filter.adaptive.

@psambit9791 am working on an LMS and NLMS adaptive filter for my application and both seem to be working.

@SiboVG I have created a checklist for the filters. You can tick the ones you have completed / are working on. Also, in terms of the class location, it will make sense to keep them inside the filter package under a subpackage classed adaptive. The new package name being com.github.psambit9791.jdsp.filter.adaptive.

That's exactly how I've done it right now, with the adaptive-filter package ;) good that we're on the same wavelength

@psambit9791 I would suggest leaving out the LMF and NLMF filter. I've tried implementing it, but it gave very unreliable results (results diverged very often, both in my own implementation as in the padasip implementation), and is also a little used adaptive filter.

@SiboVG What about RLS and GNGD? I am not sure how often adaptive filters are used in practice, especially the types.

RLS is more often used, especially for noise reduction. GNGD a bit less, but still way more than LMF (also find little documentation about LMF)

From: Sambit Paul @.>
Sent: Monday, November 15, 2021 1:51:46 PM
To: psambit9791/jDSP @.>
Cc: SiboVG @.>; Mention @.>
Subject: Re: [psambit9791/jDSP] Feature request: Implement LMS adaptive filtering + other adaptive filters (Issue #26)
@SiboVGhttps://github.com/SiboVG What about RLS and GNGD? I am not sure how often adaptive filters are used in practice, especially the types.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/psambit9791/jDSP/issues/26#issuecomment-968879878, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACUFHX6XTM54PYJDZIWP5ALUMD66FANCNFSM5HKHUCNA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'll pick up RLS and GNGD.

I can work on SSLMS and NSSLMS, since they are similar to LMS and NLMS

@SiboVG Do you think it makes sense to create an abstract class called _Adaptive which implements common functionalities the way it works in padasip?

@SiboVG Do you think it makes sense to create an abstract class called _Adaptive which implements common functionalities the way it works in padasip?

Was also thinking about it; I think all of them will use the same methods, but that's maybe something we can do after every filter is implemented, because it might be that some filters need different parameters etc.


List of user's project lost on page refresh

Reproduction
Steps to reproduce:

Create two projects
Select "Mes Projets": you see your two projects
Select the first one
Refresh the page
Select "Mes Projets": you can only see your current project

Expected Behavior
You should be able to see the list of all your current projects.
Actual Behavior
You can only see your current project if you refresh the page. The call to the '/projects' route is not done if you refresh the page
Environment

Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOs

Thanks for reporting!
That’s indeed a bug. Would you like (and have the time) to try and fix it? I can show you around the codebase if you need.

Yes, I'll try to have a look ;)

It's weird, it seems that the deploy with Heroku button didn't deploy the latest version of Falco, or am I missing something ?
=> I don't have the "Gérer les paramètres du projet" link here

And when I launch it locally, I got this:

Hello @clementdessoude I'm closing this since it seems the problem has been fixed. Feel free to reopen it if you notice it again :wink:


[PcGamerBridge] fix pc gamer, revert to meta tags, get image from meta tag as enclosure, get category tags

I expect using meta tags and a.article-link should be less likely to break in the future.
If a.article-link should break, then finding each a for the same domain and checking for the meta tags where og:type is article ought to be even more durable.

Hi, @mdemoss !

Are type_news and channel_gaming_software supposed to be in feed item categories? IMHO they duplicate Category: News and Category: gaming software

Are type_news and channel_gaming_software supposed to be in feed item categories? IMHO they duplicate Category: News and Category: gaming software

I'm not sure why they have some of those tags, maybe it's for their internal use. I filtered out a couple already at https://github.com/RSS-Bridge/rss-bridge/blob/a60c6efc2de2694a07ede06205348fdaccf62c20/bridges/PcGamerBridge.php#L28
Maybe a better approach could be to remove every tag that contains an underscore, at the risk of losing some meaningful tags.


fix(marathon): Fixing more issues

About the PR

Replaced O2 and N2 gas miners with large station gas miners.
Connected the disposal unit inside chemistry to the disposal network.
Why / Balance

I misunderstood what was required to solve #28326 in my last PR. I thought "large" gas miners were actually large (2x2) and didn't attempt to map them in before.
Fixes #28326
The disposal unit in chemistry was not connected to the disposal network.
Fixes the "issue" that was reported in the comments of my last PR.
I did not fix the last issue, #29361 because I have no idea how APCs work.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Before is located at #28326
After:

Before is located at https://github.com/space-wizards/space-station-14/pull/29256#issuecomment-2184949351
After:

Breaking changes

Changelog

I have no idea how APCs work.

Draw a line with MV cable to the nearest substation to opwer the APC


MongoDB storage driver

This supersedes #94 (cc: @iampersistent).

This is awesome.

This is awesome.

Ill try and get time for a new release soon, there are some changes and unfortunately there will be some more.


Incorrect order for Deps.sort

The following piece of code
pub trait Foo {
    const c : u32;
}

pub struct foo {}
impl Foo for foo {
    const c : u32 = 17;
}

type F = foo;

pub fn bar(random: u32) -> u32 {
    random % F::c
}

gets sorted incorrectly, as the bar function is moved before the impl block. If possible we should probably keep the order of the original program instead of moving functions earlier, if there are no conflicts in the dependency graph.

This issue is related to #375 as the graph is not getting an edge, since the concrete idents are not equal.

Hi Lasse, thanks for the bug report!
That's indeed related to #375, and also to #372, which I have to debug.
Gonna try to look at that soon.

Hey, this should be fixed now, impl expressions are taken into account for the dependency analysis.
Can you check if that works for you on main and close if it's the case? Thanks!


[APL-336] - Minor textual changes for APL feature

Description 📝
Minor textual changes for APL feature
Changes  🔄
List any change relevant to the reviewer.

Doc links have been changed from old/placeholders to new documentation pages .
APL Acronym removed from public facing text.
Node pool threshold for APL now checks for vcpu as well.

Target release date 🗓
11/12

Thanks! I'll merge once CI finishes. 🚀


WIP: Adding real metrics to mvp demo

Signed-off-by: bharathappali<EMAIL_ADDRESS>

Closing as this is stale. Re-open if needed.


bosh-deployment-resource doesn't upload stemcells where the director has 2 different types of cpis

Here is another multi-cpi stemcell issue we ran into.  Attempting to do a deploy that spans 2 CPIs (requiring 2 different stemcells) bosh-deployment-resource fails with a message like Stemcell bosh-aws-xen-hvm-ubuntu-trusty-go_agent not defined in deployment manifest.
Steps to reproduce:

Setup a director that uses 2 cpis of different types (e.g. AWS and vsphere)
This will require uploading 2 stemcells to the director.
However, the deployment manifest will only have one stemcell definitions (something like):

stemcells:
- alias: ubuntu
  os: ubuntu-trusty
  version: latest

When executing the deploy bosh-deployment-resource attempts to ensure that all the stemcells and versions uploaded are being used in the manifest but it fails to take into account this multi-CPI scenarios.

Somewhat related to: https://github.com/cloudfoundry/bosh-deployment-resource/issues/47

Hi @youngm,
I've been looking into this and I'm having a hard time writing a failing test for this scenario (maybe I'm not understanding it correctly). Given your description above I would expect any attempt to upload 2 stemcells of the same os or name to fail. I say this because the section of the code that handles this is agnostic of which CPI(s) are in play.
Could you tell me which stemcells and versions were failing? The information fed into this function is determined by the stemcell.MF file packaged in a stemcell and the most recent versions of stemcells seem like they would pass through this code ok. I'll continue to look at this, but I wanted to give you an update in case my understanding was incorrect.

Hi @drich10 ,
It doesn't fail with the stemcell upload. It fails when attempting to set the versions of the stemcell in the deployment manifest prior to deploy.  And it actually only fails when the stemcells are of the same version because there will only be one stemcell referenced in the deployment manifest in that case.  I believe it fails with this error https://github.com/cloudfoundry/bosh-deployment-resource/blob/master/bosh/deployment_manifest.go#L57 .
Does that help at all?

@drich10 Well, I just tested the very configuration that I thought failed before and it seems to be working now.
How embarrassing.  I don't know what was wrong with me when I submitted these last 2 issues.  Sorry for taking up your time looking into it.  Next issue I'll be sure to be super thorough with complete test cases and everything.
Thanks for your help!

No problem! I'm just glad everything ended up working for ya. Thanks for double checking and getting back to me 👍 .


Update v3/index.json to mention the new SemVer 2.0.0 registration hive

The new hives are deployed to PROD and are referenced in search service and v3/index.json. I will close this issue once we have enabled and validated SemVer 2.0.0 package upload. Thanks for the help @shishirx34.


Allow scala_benchmark_jmh to specify a runtime_jdk version

Description

Include runtime_jdk as an an attr on jmh_support:benchmark_generator.
scala_benchmark_jmh can now specify a Java runtime to build its scala_binary with.

To test whether our changes work for different specified JDKs, we include<EMAIL_ADDRESS>as an http_archive.
We don't override our Bazel's (@.bazelversion) rules_java and instead pull in the newer rules_java as @rules_java_extra.
This allows us to use remote_jdk8 runtimes specified here.
Motivation

We want to be able to use JMH benchmarking on different Java runtimes.
Co-authored-by: Shane Delmore<EMAIL_ADDRESS>

@simuons


Add Caregiver Baby Book Main Pages & Update Admin Baby Book Page

What does this Pull Request change?
Adds the caregiver baby book pages. Updates the admin baby book page
Important Changes

Adds /caregiver/book and /caregiver/book/[babyId] for viewing and editing baby books
Updates /admin/book/[babyId] to reflect new design and add ability to select images

Path to DO NOT DELETE's caregiver album: /caregiver/book/bd89888ca382e490a04183167a810518f2aa9f39?iv=af3abe9304c706f681857b64fc4e6127


TypeScript is not listed as a requirement

I have a react-native project that cannot use this module because it is distributed as .ts files. Nowhere in this repo or even in the react-native-vision-camera repo does it say TypeScript is required to run it.

I'm Seeing this error: ReferenceError: Property '__scanFaces' doesn't exist, js engine: hermes


Require authenticated user on grid list command

With this PR a proper error message is shown if user is not logged in and he/she is trying to list grids.
Before:
$ kontena grid list
 [error] Expected([200, 201]) <=> Actual(400 Bad Request)
         Rerun the command with environment DEBUG=true set to get the full exception

After:
$ kontena grid list
 [error] You are not logged into a Kontena Master. Use: kontena master login
         Rerun the command with environment DEBUG=true set to get the full exception

LGTM


How to be with hash_equals() on PHP 5.5.9 or lower

We have implemented your library to our server... and it seems our version of PHP differs from required version in your library...
I have found some of the Backward Compatibility Workarounds in User Contribution Notes ... But I have doubts about safety concerns.
For now we are using following workaround
Please could you suggest your optimal and safe way to do this...
Thanks in advance...

RNCryptor-php already supports PHP 5.5.  We have passing unit tests for it as well.
Are you using the latest version of our library?  It also includes a dependency on sarciszewski/php-future which is a polyfill that supplies for the lack of hash_equals() in earlier versions of PHP.  Are you using Composer to manage dependencies and autoloading?  Otherwise you will need to read composer.json and install the dependencies yourself.


API request with non ascii characters brokes the server response

Describe the bug
We are having a big problem with this encoding here:

This is a request made from our application to the backend: getting a bug.

Every time we sent text with Turkish character from the application we get this bug; looking on how fixing this we meet this pull request which seems to solve the bug, but this pull request is not yet in the last plugin's version.
To Reproduce
Steps to reproduce the behavior:

Create an object with some non ascii character to be the request body.
Send the request to the backend through the api.
Get the response from the server on the console log.

Expected behavior
A true response from the backend.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device:  Lenovo Tab M10 (FHD)
OS: Android 9
Browser [e.g. stock browser, safari]
Version 0.2.1

Additional context
There is a possible solution already in this plugin's base code, but it is not in the last version.

This is already fixed on master in #41 so I'm closing this. A new npm version will be out later this week if everything goes well!

This is already fixed on master in #41 so I'm closing this. A new npm version will be out later this week if everything goes well!


Update pronounciation

This is how I say it in my head, with a Chi followed by a long O: ταχωμητερ. Thoughts?

Haha, well actually I pronounce it like the rev-counter in cars (https://www.youtube.com/watch?v=-oS2dWv0Tug), but I'm happy for you to pronounce it however you like ...

I'm just thinking this is a great branding opportunity 💰🌮🌮👌


Lambda Workflows [Adds integration to UI] [5/5]

Describe your changes and why you are making these changes
Base branch for adding the lambda integration
Related issue number (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

I'll run the Golang Linter before I merge to main, I don't want to add a bunch of golang files to this PR.


Remove Guava dependency from certain core API classes

I plan to copy these classes into the jib-build-plan project, where we won't depend on Guava.

Thanks @loosebazooka!


[Create New Issue]: HTML colors

Description
Description About colors in HTML
Domain
Frontend Dev HTML/CSS/JS
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

I would like to go with ./video as adding more proficient look to the topic .Please assign me

/assign


Consolepasswordendpoint

Codecov Report

Merging #62 (c9fe935) into master (30ca56a) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #62      +/-   ##
=========================================
- Coverage    4.48%   4.45%   -0.04%
=========================================
  Files          13      13
  Lines        1025    1032       +7
=========================================
  Hits           46      46
- Misses        973     980       +7
  Partials        6       6

Impacted Files
Coverage Δ

machine.go
8.68% <0.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ca56a...c9fe935. Read the comment docs.


Wrong documentation for iOS installation

How can I make this library work on iOS using Cocoapods?
In your documentation I've found the following:
You can use the included podspec in your podfile to take care of all dependencies
instead of manually adding files to the project (instead of steps 2 through 5,
but you might still have to do step 6 above).

but above is only 4 steps...
My actions to reproduce the issue:

yarn add react-native-webrtc
add podspec to Podfile in ios folder
cd ios && pod install
cd .. && react-native link
try to build project in Xcode -> the error appears: clang: error: linker command failed with exit code 1 (use -v to see invocation)

Can you paste the full error?

@saghul sure:
Apple Mach-O Linker Error Group:
    Linker command failed with exit code 1 (use -v to see invocation)

That's not the full error. It should give the reason under. You may need to right click and pick "reveal in log file".

@saghul here is the screenshot:

The error is "Duplicate symbols for architecture x86_64". Check if you are linking with WebRTC.framework twice.

@saghul yeah, you're right - it happens because of react-native link command. So, with Cocoapods we don't need to use it after pods have installed.
Thank a lot for your help!


Use font_size setting to control napari-console font-size

References and relevant issues
See napari/napari-console#32 and napari/napari-console#33
Description
Enable napari-console to react to the changes over the font size setting from napari. This needs some changes over napari-console too. See napari/napari-console#33
A preview:

@dalthviz what's the proper/preferred order of merging this and the console PR?

Hi there, I think the napari-console PR should be merged first. In fact I think a release with the change will be needed so this PR can update the napari-console dependency constraint (something like napari-console >=0.0.10).
However, thinking about this and checking the current constraint for napari-console, I think the work done over the console side could break things if used with napari 0.4.x . I think part of the code I removed there needs to still be there to keep napari-console compatibility with napari 0.4.x 🤔 (enable the console to update its style sheet). For the moment, I will mark both PRs as WIP, do some tests, and come back to you after I have ensured changes keep compatibility between the console and previous napari versions :+1:

I added some changes to the console PR and checked locally with napari 0.4.19 so things seem ready for review now :+1:

@dalthviz tests are failing here because of the napari-console requirement. Are we waiting on console to release before this PR can be updated?

Are we waiting on console to release before this PR can be updated?

Correct, in fact https://github.com/napari/napari-console/pull/33 needs to be merged first and then a release with that change be done. However, I'm not totally sure if this is the right approach to follow/if there are alternatives to achieve the behavior this work is doing. Maybe these PRs (this one and https://github.com/napari/napari-console/pull/33) just should be closed

I think it's this -- linking napari font size with the console -- or making people more aware that the console has qtconsole keybinds, so you can use the zoom in/out keybinds to change the font in the console:
https://github.com/napari/napari-console/issues/32#issuecomment-1997831720

@psobolewskiPhD I would expect you to have a preference for either option?
I think using the preference is good because it'll remember it between sessions, whereas I expect using the shortcut doesn't?

Once #7287 is merged, we could iterate this PR again.

Amazing! 🚀


[CI] Cross-compile Intel Mac release binary

Follow-up to #2958, where we added and tested cross-compilation support. This allows us to use Xcode 16 to compile the Intel Mac binary (macos-15 is Apple Silicon-based, macos-13 only has Xcode 15 available) and take advantage of the faster M1-based runners.
==============
Should save some precious macOS runner time. In a follow-up, we will also compile the macOS arm64 binary here, and eventually the Linux arm64 binary. Then all release binaries will be compiled here and we'll be able to automate the NPM publish and NPM types jobs so that releases are fully automated.

[ ] After merging, manually confirm that the generated release artifact is actually an x86 binary (this worked in local testing for #2958, and when testing cross-compilation in that PR CI tests were slightly slower which is likely being caused by the Rosetta overhead).

As with all release-only changes, there is a small risk that this breaks the build, in which case I will promptly fix or revert.


pritunl-client: 1.3.3785.81 -> 1.3.4026.10

Description of changes
~https://github.com/pritunl/pritunl-client-electron/releases/tag/1.3.4024.40~
https://github.com/pritunl/pritunl-client-electron/releases/tag/1.3.4026.10
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343015 --checkout commit run on x86_64-linux 1

1 package built:

pritunl-client

Please follow the commit message guidelines, that would be pritunl-client: 1.3.3785.81 -> 1.3.4024.40
Side note: this is more than aesthetic, it allows ofborg the bot to automatically build the changed package (well not this particular one since it's unfree, but you get the idea).

Ah please squash the commit and we are good to go.

@NickCao sorry, I thought the squash could/would happen when squash-merging the PR;
Squashed and rebased manually. Thank you