[cakephp] Merge minor releases to single row

@ravage84 ping ? could you also give a review for this ??

@captn3m0 : @ravage84 ( Marc ) is one of core devs of cakephp

As explained in https://github.com/endoflife-date/endoflife.date/pull/1707#issuecomment-1282136426 I'd prefer the other PR.


move ubuntu and ng-dashbaord-aggregator to pl bundle

move ubuntu and ng-dashbaord-aggregator to pl bundle

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Show proper background for CR featured projects

Summary of changes
Asana Ticket: Missing background on Featured CR Project
This adds a special case to the route parser for the featured projects banner to return the correct CSS class for commuter rail lines.

Before getting review, please check the following:

[ ] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

@ingridpierre this is the branch that I haven't been able to test with IE yet

@beeuhtricks All good on IE11, thanks for helping me get that on dev!


Added fast json formatter

Description

Motivation and Context

Alternative to #541
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

:+1:


BUG : Token check issue

Hello Team,
I dont have any read only tokens in the workflow but i get this as the result

{
"Details": null,
"Score": 10,
"Reason": "tokens are read-only in GitHub workflows",
"Name": "Token-Permissions"
}

Repository for reference : https://github.com/bhuvi11/ecom-service
Please help

My guess is that there are no tokens found and hence the score of 10 which is the expected behavior. If you have any tokens with write permissions and the check did not catch it, feel free to re-open this bug.
Closing this for now.

Hello @azeemshaikh38,
But shouldnt it tell there is no read token? instead the reason says tokens are read-only in GitHub workflows which means i have tokens that are read only but i dont have any token at all


Storage: Rationalize File quotas

https://apiview.azurewebsites.net/Assemblies/Review/47c9ebbff8c0458fa2e7904eae34656f
Check the REST API to make sure we're clear if each value is in GB or Bytes and use QuotaInBytes and QuotaInGB as names.

Also make sure anything in InBytes is of type long.


Problems installing MoqComplete in Rider 2021.2

Thank you a lot for your great plugin! It really helps typing!
After upgrade to 2021.2 i am unable to install MoqComplete. Rider finds it in marketplace (version 1.4.9) and i am able to install it, but after restart it is dropped and i do not see MoqComplete in installed plugins.
Rider build is 212.4746.113
Any ideas how to investigate?

It seems to be an issue with Jetbrains Rider, I've contacted them here:
https://rider-support.jetbrains.com/hc/en-us/community/posts/4405250236050-Unable-to-install-MoqComplete-plugin-with-Rider
They have created an issue on their end. I suggest upvoting it so that it gets prioritized

Upvoted&commented!

It seems to be an issue with Jetbrains Rider, I've contacted them here:
https://rider-support.jetbrains.com/hc/en-us/community/posts/4405250236050-Unable-to-install-MoqComplete-plugin-with-Rider
They have created an issue on their end. I suggest upvoting it so that it gets prioritized

Hi, I think more important is the link to the tracker, vote for the task here: https://youtrack.jetbrains.com/issue/RIDER-66631

Is there any workaround? I've tried to install the plugin from disk, didn't help ((

Is there any workaround? I've tried to install the plugin from disk, didn't help ((

I haven't found any; downloading an older version of Rider may help: https://www.jetbrains.com/rider/download/other.html

I'm going to trigger a new public release; in the meantime the plugin can be manually installed from the zip file here
Thanks @ForNeVeR  for the fix


Application Layer Or Application Service

Hi, I read some articles about clean architecture and some of them said that there is a layer called application layer that handle the business logic and types.
"The Domain layer contains the enterprise logic and types, and the Application layer contains the business logic and types"
Is there any Application Layer or Application Service inside Ardalis/CleanArchitecture project?
Or interfaces inside core layer act as Application?
what about events folder, they handle domain business or application business or service
Is there any plan to decouple "CORE" layer to two separate parts like Domain and Application?

Many applications don't really need a separate layer or project just for "application services" sometimes also called "use cases". My preference is to have such services, when needed, simple live in the UI project (in this case the Web project). They often benefit from returning DTOs defined in the Web project, just as ViewModels or API models, so it makes sense to put them in the same project as these DTOs. If you find the additional layer/project helpful, it should be trivial for you to add it, and no judgment from me on it. :)


Investigate adding support for BucketAccessControls: insert

This is for discussion.
Do we need to provide support for BucketAccessControls: insert or rather expect users to rely on bucket update/patch?
I think update/patch method should be enough. We can always add BucketAccessControls: insert later if someone requests it.

I agree and I think we should either close it (and re-open per request) or label it as "enhancement" which
is not likely to be implemented.

I'm closing this. We can reopen in the future if users request this feature or we feel like it should be added.


.UseMauiCommunityToolkit() extension method is not chained in the MauiProgram.cs for the project with CommunityToolkit.Maui package

[] Include the log file upgrade-assistant.clef that is produced in the working directory (not necessary as it is not pertaining to upgrade exe)

Describe the bug
.UseMauiCommunityToolkit() extension method is not chained in the generated MauiProgram.cs file for the project that references the CommunityToolkit.Maui NuGet package (this got referenced as part of the Xamarin.CommunityTookit NuGet package upgrade).
To Reproduce

Create a Xamarin.Forms App/Library project with Xamarin.CommunityToolkit package reference added to it and then try to upgrade it to .NET MAUI.
Exceptions (if any)

The upgrade is successful. Post that build error.
Further technical details

Windows version and bitness info (32-bit or 64-bit)
Include the output of dotnet --list-sdks
Include the output of upgrade-assistant --version

Windows version - Microsoft Windows [Version 10.0.22621.1778] - x64
The output of upgrade-assistant --version
0.4.421302+be0ea11e8234f2a0bde2d170b0fdd455fa4f9a45


GraphCMS datamodel missing

Can you export the full datamodel schema from the GraphCMS server and upload it here? It's necessary for easier replication of the full stack example.
Great job so far. Thanks for your effort

@motleydev We should create a Template for the example if it is not existing yet.


perf(minifier): avoid repeated Atom creation in InjectGlobalVariables

Re-use Atoms in InjectGlobalVariables minifier plugin.
Instead of allocating a new Atom on every replacement, create Atom lazily when making first replacement, and cache it.
As discussed in: https://github.com/oxc-project/oxc/pull/4759#discussion_r1711669464

#4802  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite

Thanks for reviewing Dunqing. But please can you let Boshen have a chance review too before merging? I'd like him to see what I was talking about on #4759.


Add fail cases to user controller

Thank you for your contribution. But the test failed :(. Could check it out if possible :).

Thanks @andregomesb


Hi, can I pause the VAD test, please?

Hi, first of all, thank you very much for your efforts to provide us with such a great library. One of my needs during the use is whether the detection can be paused? Based on this scenario, I change the microphone recording from active to inactive and send the audio to http server to wait for its processing and then return the recognition result, before returning I want to pause the VAD detection (destroying and then rebuild may be overloaded), can I pause the detection now?

I'm working on a similar use case. have u come up with a solution ?


Can't delete azure cloud shell

Windows Terminal version (or Windows build number)
10.0.20303.1 1.7.210226002
Other Software
No response
Steps to reproduce
Try to delete the azure cloud shell
Expected Behavior
The Azure cloud shell configuration gets deleted
Actual Behavior
It cant be deleted since it's built in
For Customers that are legally prevented from using cloud services it's rather bad to have a mandatory config to a MS cloud service. Therefore it should be possible to delete it.
IT's also rather unpractical for AWS or Google users.

The Azure Cloud Shell is a "dynamic" profile, which can be hidden with
"hidden": true

@zadjii-msft
Hiding it doesn't prevent it from being in the config and so on so that didn't meet the need but you did solve it anyway by mentioning and linking dynamic profiles.
By using "disabledProfileSources": ["Windows.Terminal.Azure"] in the config file we can prevent it from being created so that will solve the issue :)

On the newest version of Windows Terminal, it looks like your global settings are initialized with the defaults, and you can just completely delete the azure shell section and it disappears forever.


Jmeter Integration with Custom Plugin

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Adding @ntrogh for review

#assign-reviewer: @ntrogh

@ntrogh please review


Testing docker

Hey mate thanks for this easy docker setup. Had a hard time to get the official one running. Could you help me, i need to verify if the docker build works.
Connected 2 devices and hit sync on 1 and after a minute or so on the other, but nothing sync's.
I have the docker running locally on my server and i want to port forward my router :5000 to :5000 so I can sync on the go. Perhaps with an extra nginx SSL layer on top. How is your SSL been taken care of?
Thanks and kind regards
Ezra
Edit: would it also need to be https://IPADDRESS:5000/token/1.0/sync/1.5 instead of https://IPADDRESS/token/1.0/sync/1.5:5000 since we need to connect to the docker :5000 instead of the webserver running on the host.

Yeah right then i get why its not working. Could you share your docker run/create command?
Thanks

The build command:
docker build -t sync .

The run command:
docker run --init -d --name sync -e URL=sync.example.com sync

Closing. Feel free to re-open the issue if you still have problems.


Add release drafter.

This PR adds release drafter config and a GitHub action to update the current release draft every time a PR gets merged to master.
I've set up the categories based on existing labels, but I also added

Maintenance (I'd recommend adding a new label chore for any maintenance related work), and
Dependency updates - for when scapegoat gets added to Scala Steward.

Closes #273.

Did you get the release drafted correctly? I can't see the draft because I don't have the permissions, but I was wondering whether it worked. Might be also worth labelling all the PRs to get them categorised correctly.

Hey @mccartney could you check if you can see the current release draft? I just want to check if it's working and it included all the PRs since the last release.
It would be a good idea to label all of those PRs before a new release so that they get categorised correctly in the release note.

I can see the draft the laundry list of fixes at https://github.com/sksamuel/scapegoat/releases/tag/untagged-d79439205a58a609cd68
I am surprised the list is so long. It's definitely too many items there. The oldest number included there is #48

That doesn't sound right, it should only include the changes since v1.4.1. Maybe the ci job in travis doesn't fetch the tags on checkout, that's the first thing that comes to my mind.

I'd try this and see if that makes any difference:
before_install:
  - git fetch --tags


Bugfix: Add scopes to subscription conversion

Description
This PR adds converting subscription scopes between v1alpha1 and v2alpha1.
Issue reference
Closes #3914
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test


Notify user on invite filter

Currently, when the bot detects an invite link it's just deleted without notifying the user, often leading to them trying multiple times until they either realize it's being deleted intentionally or a staff member steps in.
How about adjusting the cog so it notifies the user, either in-channel or via a DM, that the invite is being removed per Rule 10?
For invites DMed to the bot, we could either use this same notification, or just defer it to staff action.

love this idea. let's do it!


Very bad search results

For example, arr matches ARABIC RAY before ARROW. The same thing used to happen with Atom's Command+P command prompt. This needs to use the new search method that prioritizes whole matches.

In addition, searching 'alpha greek' gives nothing, while 'greek alpha' gives the character you'd expect.
Order SHOULD be taken into account in assigning result priority, however, the order of search terms should not exclude results.

Command+P has better search order now, you should use the same alg they use.

The fix is really simple: Swapping the fuzzaldrin library with fuzzaldrin-plus.
Should the old scoring algorithm be kept as an option?

Probably not.

It would really be nice to have that, since I would like to use it for greek letters and always typing greek alpha is not so nice...


first captcha code always wrong

I have this snippet in a form

                  <input type="text" id="captcha_code" class="form-control required" size="10" maxlength="6">

Once the user enteres the characters there is an ajax triggered to a file containing
`<?php
require_once($_SERVER['DOCUMENT_ROOT'] . "/assets/securimage/securimage.php");
if(isset($_POST["captcha_code"])){
$securimage = new Securimage();
$result = array();
if($securimage->check($_POST["captcha_code"]) == false){
  // the code was incorrect
	$result["succcess"] = false;
	$result["error"] = $_POST["captcha_code"];
	echo json_encode($result);
}else{
	$result["succcess"] = true;
	$result['data'] = '<input type="hidden" name="cap" value="approved">';
	echo json_encode($result);
}
unset($_POST);

}
exit;
?>`
yet every initial time this event is triggered, even if the code is correct I get a return as false.
If I refresh the captcha, then enter the code it works just fine
If I do a js to trigger a click() on the a tag holding the captcha, again it works fine
But that first time on page load, never, even works the first time.
What could I be doing wrong?  I have tried putting session_start() at begining on file and this does nothing.

$(document).ready(function() {
                    $('#your_html_a_tag_id').trigger('click');
}

With ajax forms you need to be careful not to validate the captcha if any other form validation fails. When check() is called with the correct code, it cannot be used again. Sometimes this happens with ajax forms and causes problems. Otherwise, this might be caused by session/database config issues.
For future integrations/updates and to get around this issue, check out the nextgen/4.0 branch.


User with AMDVLK organization

An unknown user by the name of procedural created the AMDVLK organization. It contains some of AMD's technologies, I think, and I'm not exactly sure what the user is trying to do with this organization.
I don't know if this is a trademark/copyright issue, but if a member wants to report to GitHub, then here's a link to help you: https://support.github.com/contact/trademark-policy

@TheEvilSkeleton Thanks for the information.

No problem. If possible, keep me updated please.


Updating the "Basic FHIR search tutorial" with SDK examples

Coverage remained the same at 94.124% when pulling 47dc939370187a8749fe60713bbeb1a10b63cab3 on rahul-update-basic-search into 31cb80749035d325780d4880d2551eb87da341f2 on main.


Add do not show again option to the native notebook insiders survey banner.

For #4658

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #4729 (1194d18) into main (bd71f96) will increase coverage by 0%.
The diff coverage is 33%.

@@          Coverage Diff          @@
##            main   #4729   +/-   ##
=====================================
  Coverage     76%     76%
=====================================
  Files        400     400
  Lines      26254   26259    +5
  Branches    3768    3769    +1
=====================================
+ Hits       20124   20145   +21
+ Misses      4579    4561   -18
- Partials    1551    1553    +2

Impacted Files
Coverage Δ

.../datascience/insidersNativeNotebookSurveyBanner.ts
74% <33%> (-23%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
83% <0%> (-2%)
:arrow_down:

...lient/datascience/kernel-launcher/kernelProcess.ts
82% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
76% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/kernelVariables.ts
72% <0%> (-1%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (-1%)
:arrow_down:

...datascience/notebookStorage/nativeEditorStorage.ts
80% <0%> (+<1%)
:arrow_up:

...ient/datascience/editor-integration/codewatcher.ts
69% <0%> (+<1%)
:arrow_up:

.../datascience/editor-integration/codeLensFactory.ts
86% <0%> (+1%)
:arrow_up:

... and 12 more


Add CODEOWNERS linter baseline error file

CODEOWNERS is now going to be linted. This PR contains the existing linter errors, deduped, which are used to filter results, otherwise this pipeline couldn't be run on PRs that contain CODEOWNERS changes without the several hundred issues being fixed, which is not ideal. The linter will run daily and on every change to CODEOWNERS or the baseline file. Specific details of the linting can be found here but here is what's being verified in a nutshell.

Metadata tags - PRLabels, ServiceLabels, ServiceOwners (previously /<NotInRepo>/, both are still valid for the moment) and AzureSdkOwners (new, used for issue triage).
Source paths - Does the path exist? If the path is a glob, is it valid and does it have matches in the repository?
Owners - There are several verifications for owners:

Does the owner, individual or team, have write access (every team/individual in a CODEOWNERS file needs to have write access, this is a GitHub thing).
Is the owner public? Individuals need to set their Azure membership to public. This is explicitly mentioned in the onboarding documents for azure-sdk repositories.

I'm going to override check enforecer. The cpp - codeowners-linter pipeline ran and passes, the cpp - core pipeline had a failure but nothing in this PR affects anything outside of the linter pipeline


[#1876] ✨ Instance-level CI/CD variables API: add description

Added Description Field for Instance Variables

@svanharmelen Can you approve this as well?
Thanks for the fast Merge.


use digest for cross build ppc64le,s390x

@gyliu513 amd64, power, Z operator images are cross build on x86 machine.
On x86 machine, amd64 uses registry.access.redhat.com/ubi8/ubi-minimal:8.1-398 and can get a x86 arch base image.
This PR just ensure power, Z can get the correct base image.

@haoqing0110 seems all images in ODLM are using digest, please refer to https://github.com/IBM/operand-deployment-lifecycle-manager/pull/178/files for detail. FYI @horis233 @DanielXLee @chenzhiwei

@gyliu513 ok, will append a new PR to make dockerfile same as OLDM.


More complete version management

While there's a lot of things, I don't like about Alembic I do think they have a pretty solid data model for versions: https://alembic.sqlalchemy.org/en/latest/branches.html. It'd be really interesting to see what concepts we can pick up from them, maybe while still keeping migrations as edges not vertices.

topological sort ?

Well a topological sort is probably needed somewhere. But really I think the interesting bits are around creating branches, the concept of HEAD revision, branch merging, having multiple "down" revisions, etc.


Unable to access objects on 3rd party S3 endpoints that only support path-style URL's

This is more of a feature request, but I would like see the use of path-style object URL's as an option for a given client configuration.
In testing the latest s3motion release with an EMC Elastic Cloud Storage endpoint that is not configured for virtual-host style URL's, I was unable to address objects.  The use of the virtual-host style URL's requires some DNS configuration that isn't always practical or approved for use with on-premise object storage deployments.  Having the ability to use the "legacy" path-style URL's would provide a suitable workaround.
Here is an example of the error:
Confirm bucket existence:
curl -i -XGET http://localhost:8080/api/buckets/ecs-joe
HTTP/1.1 200 OK
X-Powered-By: Express
Content-Type: application/json; charset=utf-8
Content-Length: 155
ETag: W/"9b-e8fcc88c"
Date: Wed, 31 Aug 2016 20:06:08 GMT
Connection: keep-alive

{"Buckets":[{"Name":"joe","CreationDate":"2016-08-17T19:48:23.501Z"}],"Owner":{"DisplayName":"<redacted>","ID":"<redacted>"}}

Attempt object listing:
$ curl -i -XGET http://localhost:8080/api/objects/ecs-joe/joe
HTTP/1.1 200 OK
X-Powered-By: Express
Content-Type: application/json; charset=utf-8
Content-Length: 1102
ETag: W/"c004Wda6KT/KI8i9JytTRg=="
Date: Wed, 31 Aug 2016 20:12:16 GMT
Connection: keep-alive

"unable to list joe : UnknownEndpoint: Inaccessible host: `joe.<redacted>.<redacted>.com'. This service may not be available in the `us-east-1' region.
    at Request.ENOTFOUND_ERROR (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/event_listeners.js:355:46)
    at Request.callListeners (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/sequential_executor.js:100:18)
    at Request.emit (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/request.js:604:14)
    at ClientRequest.error (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/event_listeners.js:204:22)
    at ClientRequest.<anonymous> (/usr/local/lib/node_modules/s3motion/node_modules/s3/node_modules/aws-sdk/lib/http/node.js:61:19)
    at ClientRequest.emit (events.js:95:17)
    at Socket.socketErrorListener (http.js:1552:9)
    at Socket.emit (events.js:95:17)
    at net.js:834:16"

@joeharlan i'll have to add this to my backlog of things to do. I haven't updated this in a while and didn't know if people were getting use out of it.


Chopped down the overly long PPP

Pull Request Test Coverage Report for Build 352

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.5%

Totals

Change from base Build 350:
0.0%

Covered Lines:
2765

Relevant Lines:
3160

💛  - Coveralls


Add more player methods

Add more player methods

Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9069579) 100.00% compared to head (5a27478) 94.70%.

:exclamation: Current head 5a27478 differs from pull request most recent head 833548e. Consider uploading reports for the commit 833548e to get more accurate results

Files
Patch %
Lines

src/spotifyaio/spotify.py
54.54%
5 Missing and 5 partials :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #29      +/-   ##
===========================================
- Coverage   100.00%   94.70%   -5.30%
===========================================
  Files            4        4
  Lines          168      189      +21
  Branches        16       23       +7
===========================================
+ Hits           168      179      +11
- Misses           0        5       +5
- Partials         0        5       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ci: Use correct sources for 'Publish gadget img manifest'

Use correct sources for publishing gadget image manifest to registry. Currently if fails with:
Publish the manifest list
> ERROR: no sources specified

Fixes: 77582cbbf31d ("treewide: Remove bcc flavor and rename default.")
Testing done

https://github.com/mqasimsarfraz/inspektor-gadget/actions/runs/6408490245/job/17397845995

I am nonetheless wondering why the CI did not catch these mistakes 🤔.

I found it via CI run but only after it was merged since 'Publish gadget img manifest' is only done for main. Maybe we pass such changes through citest, just to be sure.


Add kpod import command

Imports a tarball and saves it as filesystem image.
One error message change to kpod history
Vendor in latest containers/image
Signed-off-by: Urvashi Mohnani<EMAIL_ADDRESS>

@rhatdan PTAL

I think you need to redo vendoring the update c/image. A lot more than just containers/image was updated.

@mheon I just did containers/image because I needed the new tarball transport that was added. What else should I update in the vendor?

@umohnani8 The problem is that you picked up too much, not too little - the kubernetes and CNI vendors also updated. I think you need to specifically update only the containers/image vendor with vndr (specify the repo and updated commit directly to vndr). Alternatively, you could directly revert the changes to all the vendors except containers/image by directly manipulating the vendor folder.

@mheon thant is what I did. I changed the commit id of containers/image to match the tarball commit and just vendored that it. I can try it again.

@umohnani8 A few of the other vendors (kubernetes, CNI to name a few) don't have specific commits IDs attached, so they have a tendency to update whenever we vendor something new in. I think @runcom and @mrunalp are familiar with how to work around this - might want to ask them for help?

So when I do vndr github.com/containers/image with the tarball commit id, it shows me a bunch of files have been deleted, which include the Kubernetes and CNI files.
I just selected the containers/image files and committed those.

Vendoring looks fine now, thanks @umohnani8
I'll do a more thorough review after lunch

thanks for pointing that out @mheon :)

Bunch of pull-related tests seem broken. Unclear if this is the new CI acting up or an actual regression.

@mheon the tests should pass now. Something with the new containers/image was causing them to break.
I am not sure what exactly is happening with containers/image right now, but I just vendored in the changes for the tarball transport to support kpod import. @mrunalp @runcom is that acceptable?

Well I like the fact that you got rid of Nalins pool

@umohnani8 Containers/image broke a lot of kpod image-related functions, so you dropped the parts that broke us? I'm a bit concerned that we're broken on the upstream code - we should try and figure out how to fix either c/image or how we use c/image so we can use all the updated code.

@mheon I don't believe I dropped anything that we already had. I just added the tarball folder and changes to the transports folder. There were other changes to containers/image, which was breaking our tests so I didn't commit those after vendoring in containers/image.

@umohnani8 I'm just a little iffy on cherry picking a partial new commit from c/image. I think we should bother someone on the image side to ask why the new commit broke kpod.

@mheon the main thing that was breaking was pulling a docker-archive file - it kept throwing the error "blob size mismatch". There was a PR in containers/image that got merged when it shouldn't have and I spoke to @nalind, but he said most of the changes to that was for containers-storage, so weird that docker-archive is messing up.
I can pull in the changes and try to get to the bottom of why its causing pulling from docker-archive to fail.

@umohnani8 If it's not too much trouble, sure - I'd just like to make sure we aren't going to hit this again next time we have to update c/image.

I agree with Matt, I would rather get this cleaned up in containers/image then get kpod import in.

All tests should pass now. I was vendoring in from containers/image master and not @nalind's fork, which was causing compression issues with docker-archive therefore breaking the tests.
Vendored in latest from Nalin's fork and all tests should pass now.
@mheon @rhatdan PTAL.

One last nit, LGTM
@mheon @mitrmac PTAL

@umohnani8 The code from Nalin's c/image fork is going to land upstream at some point, right? I don't want to be permanently tied to his fork instead of upstream

@mheon I believe so. Also Nalin's fork is what has been vendored in for cri-o.

@rhatdan tests passed.

@mheon PTAL
LGTM other then the comment above.

LGTM. @umohnani8 Can you add an issue after this merges to switch back to containers/image master once Nalin's changes merge?

@rh-atomic-bot r+


Disappearing selection

I can't work with the text, it's normal?

Hmm - what platform? That works for me although you had me worried since I don't recall ever trying that.

OS - Linux
Yes, when i remove plagin, error disappear)

OK - sadly this will take a while to fix since I don't have linux installed at the moment. The right-menu is over-rated though. Can you do without for now? ;-) See if the plugin works for you in general?
Anyway - yeah - sorry about this.

Pfff...of cource i can)
Thank YOU for the excellent work.
I'll try to find solution

By the way, error precisely in plugin, because I install it on pure program
P.S. I apologize for mistakes, I am from Ukraine and speak a language poorly

I have this issue too, and have confirmed that it disappears when you uninstall the plugin.I would love to help debug this issue in any way I can. I can possibly help patch as well, I am a professional python developer, I am just not familiar with ST3 plugins.

I've forgotten the exact details and the movie is not working anymore.

If you right click on a selection, say to copy text, the selection is cleared. Regardless If you mark a selection, or select a section using the mouse.

No log messages appear in the console. I wasn't sure if there is a debug logging mode, or something like that I could enable to get more verbose logs.

I am downloading ubuntu now. Wish me luck!

Let me know if there is anything I can do to help.

OK - I have reproduced it on Ubuntu. I will see if I can sort it out. But ... not today unfortunately.
Thanks for reminding me about this.

OK I have fixed this. Turns out that on linux the "context_menu" command was invoking the on_post_text_command hook, whereas on Macs it does not do that. I will construct a release.

Much appreciated! This was an annoying bug I've had for a long time.


Shrine: opening and closing an item spikes dart, gpu

On Android, with --release.
Open gallery, shrine, tap an item's image. Then tap the back icon in the upper right. Repeat.
Notice the spikes that occur:

This is likely the same as https://github.com/flutter/flutter/issues/4501?

After https://github.com/flutter/flutter/pull/5015, the transition is smooth except for a hitch at the end.

(sorry, at the beginning)


[GL] Explicitly set OpenGL 3.3 profile to Core (X11, Windows) and enable GLES2 on Windows.

Explicitly set OpenGL profile to Core (X11, Windows, on macOS it's already Core).
For some unknown reasons RenderDoc was reporting Godot to use Compatibility profile (RenderDoc bug?), while there was no profile flag set and default value should be Core: GLX_ARB_create_context, WGL_ARB_create_context.

Enable GLES2 on Windows.

Thanks!

Should probably pull the core profile bits into 3.0.z

@bruvzg BTW, shouldn't we bump this to 3_3? https://github.com/godotengine/godot/blob/master/platform/osx/os_osx.mm#L1144

BTW, shouldn't we bump this to 3_3? https://github.com/godotengine/godot/blob/master/platform/osx/os_osx.mm#L1144

Yeah, checked the git blame and it has been like that since the opensourcing. It likely dates back to older proprietary Godot versions which used to support OpenGL 3.
https://github.com/godotengine/godot/blame/55d425807f6f1784d6ffd84586ae7efd77c1b352/platform/osx/os_osx.mm#L1028

@akien-mga there is no such thing, macOS only support NSOpenGLProfileVersionLegacy (2.1) , NSOpenGLProfileVersion3_2Core (3.2 core forward compat.) and NSOpenGLProfileVersion4_1Core (4.1 core forward compat.) and nothing in between.
https://developer.apple.com/documentation/appkit/enumerations/1436146-opengl_profiles

Thanks for checking. It would be good to update the comment at some point, but it's not urgent :)

Core profile bits have been cherry picked into 3.0.3


Add options to find query

I'm cool with this. We should adds some docs around this as well. @feathersjs/core-team where do you want to put them? In the docs or leave something specific like this in the README? I'm inclined to put it in the docs so that it all stays together.
Refs #12.

Definitely in the docs repo.

Ok then I'll create a corresponding issue in the feathers-docs repo.

Thanks guys. Let me know if I can be of any help.

Thank you for contributing! I just published a patch release with your fix.

You're far too kind. Thanks for your help.


New cop:  Layout/OrderedMethods

New cop to enforce that methods are ordered alphabetically per visibility block.
5587453 was accomplished using a corrector that's still a work-in-progress.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I think that it is good to have some kind of some consistency style like that. Unfortunately, this change to force uniformly alphabetically makes it harder to see git blame and history. In the many changes to RuboCop repository, the benefit which exceeds the loss of making git history difficult to read cannot be considered from this diff.  Also it will be hard to maintain even if default is set to disable, so I'm sorry to close this PR. It might be PoC to try making it as 3rd party gem.

https://github.com/shanecav84/rubocop-ordered_methods


the data used to plot orientation preference map and pinwheels ?

Dear Bednar,
I am trying to collect data to analyze orientation maps and pinwheels and I use including:
topo.sim.run(1000)
p=topo.sim.V1.views.maps.OrientationPreference.last.data
s=topo.sim.V1.views.maps.OrientationSelectivity.last.data
for every time recording, which means collecting data for every 1000 iteration map matrix.
Then I compare the ploted maps with GCAL_Tutorial in .doc with running notebook.  In this
tutorial, I also run the same script. As shwon there, data=topo.sim.views,  pref=data.OrientationPreference.V1, sel=data.OrientationSelectivity.V1. Also I  run data.Pinwheels.V1. But for every 1000 iteration snapshot, the map shown in the tutorial and the one
from using the collected data are not the same.  I am puzzled by this and maybe the data I collected is not the same ?

Sorry -- for some reason I didn't see this issue come in!  The detailed shape of the map is affected by lots of things, and I'm not sure which particular simulation you were running.  Any change in the random streams of inputs will give a different random shape to the map.  If you wanted to post more detail, we could figure out what the differences are, but it's probably not worth it -- the details of the maps are not important, just their overall properties...


fix: Remove extraneous "Foo" type from Py codegen

This type appears to be an artifact from testing/development and has no references in the source.

/azp run

Codecov Report

Merging #1867 (21a2497) into master (dedcbda) will decrease coverage by 7.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   86.86%   79.37%   -7.49%
==========================================
  Files         299      299
  Lines       15521    15521
  Branches      793      793
==========================================
- Hits        13482    12320    -1162
- Misses       2039     3201    +1162

Impacted Files
Coverage Δ

...microsoft/azure/synapse/ml/codegen/PyCodegen.scala
80.85% <ø> (-10.64%)
:arrow_down:

... and 52 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


help: Emoji in props

📚 What are you trying to do?
Use emoji in props (i.e. title)
🔍 What have you tried?
I try title like "lorem ❤ ipsum", but the results is:
"lorem
❤
ipsum"
Using emoji always breaks the lines, why?
ℹ Additional context
My first experience with og-image.
Added to existing Nuxt UI project.

Hi, this is an issue with the Satori renderer, see https://github.com/vercel/satori/issues/484
Unfortunately there isn't a fix for this besides hacking away at the HTML / CSS until it looks how you want OR just using the chromium renderer.


Bug: Setting Up a Chromium User Profile Docker Desktop Windows Perms Errors

Provide a screenshot and describe the bug
archivebox.io has a Working Around Sites that Block Archiving section to archive sites that actively work against snapshots such as websites behind Cloudflare. This includes a few different methods but for this bug report, the CHROME_USER_DIR  link that demonstrates how to setup a Chromium profile.
My instance is running via docker compose on Docker Desktop Windows and this works fine until Step 3 of the provided Docker VNC guide but then hits a dead-end. This is the docker compose run archivebox /usr/bin/chromium-browser --user-data-dir=/data/personas/Default/chrome_profile --profile-directory=Default --disable-gpu --disable-features=dbus --disable-dev-shm-usage --start-maximized --no-sandbox --disable-setuid-sandbox --no-zygote --disable-sync --no-first-run command which I attempted to run via the docker desktop's terminal.
I have tried to troubleshoot already using:

uncommenting and setting PUID and PGID as default, then 1000 and 100 and then from Windows SID (this might be irrelevant apparently according to something from Devilbox documentation that Docker Windows uses SMB to mount volumes?)
searching extensively for the Chromium SingletonLock file within the externally-linked dir and docker container files (both in the data and home directory configs for container)
double checking the compose has the matching lines from Step 2 uncommented and copied exactly and repeating from Step 1 with a fresh container install
setting image to 0.8.5rc51 version and retrying instructions

Steps to reproduce

Open docker-compose.yml, uncomment personas directory and link to match archivebox directory on host, add CHROME_USER_DATA_DIR and DISPLAY variables to the env. Check and ensure the novnc is matching besides the host port which was changed but confirmed to be accessible.
In the docker desktop containers terminal use docker compose up -d novnc
Use docker compose run archivebox /usr/bin/chromium-browser --user-data-dir=/data/personas/Default/chrome_profile --profile-directory=Default --disable-gpu --disable-features=dbus --disable-dev-shm-usage --start-maximized --no-sandbox --disable-setuid-sandbox --no-zygote --disable-sync --no-first-run
errors

Logs or errors
[7:7:1104/042514.718415:ERROR:process_singleton_posix.cc(335)] Failed to create /data/personas/Default/chrome_profile/SingletonLock: Permission denied (13)
[7:7:1104/042514.719296:ERROR:chrome_main_delegate.cc(597)] Failed to create a ProcessSingleton for your profile directory. This means that running multiple instances would start multiple browser processes rather than opening a new window in the existing process. Aborting now to avoid profile corruption.

Docker (or other container system like podman/LXC/Kubernetes or TrueNAS/Cloudron/YunoHost/etc.)
What operating system are you running on?
Windows (including WSL, WSL2, Docker Desktop on Windows)
What type of drive are you using to store your ArchiveBox data?

[x] data/ is on a local SSD or NVMe drive
[ ] data/ is on a spinning hard drive or external USB drive
[ ] data/ is on a network mount (e.g. NFS/SMB/CIFS/etc.)
[ ] data/ is on a FUSE mount (e.g. SSHFS/RClone/S3/B2/OneDrive, etc.)

Docker Compose Configuration
services:
    archivebox:
        image: archivebox/archivebox:latest
        ports:
            - 8100:8000
        volumes:
            - ./data:/data
            - ./data/personas/Default/chrome_profile/Default:/data/personas/Default/chrome_profile/Default
        environment:
            # - ADMIN_USERNAME=admin            # create an admin user on first run with the given user/pass combo
            # - ADMIN_PASSWORD=SomeSecretPassword
            - CSRF_TRUSTED_ORIGINS=https://archivebox.example.com  # REQUIRED for auth, REST API, etc. to work
            - ALLOWED_HOSTS=*                   # set this to the hostname(s) from your CSRF_TRUSTED_ORIGINS
            - PUBLIC_INDEX=True                 # set to False to prevent anonymous users from viewing snapshot list
            - PUBLIC_SNAPSHOTS=True             # set to False to prevent anonymous users from viewing snapshot content
            - PUBLIC_ADD_VIEW=False             # set to True to allow anonymous users to submit new URLs to archive
            - SEARCH_BACKEND_ENGINE=sonic       # tells ArchiveBox to use sonic container below for fast full-text search
            - SEARCH_BACKEND_HOST_NAME=sonic
            - SEARCH_BACKEND_PASSWORD=SomeSecretPassword
            # - PUID=911                        # set to your host user's UID & GID if you encounter permissions issues
            # - PGID=911                        # UID/GIDs <500 may clash with existing users and are not recommended
            # - MEDIA_MAX_SIZE=750m             # increase this filesize limit to allow archiving larger audio/video files
            # - TIMEOUT=60                      # increase this number to 120+ seconds if you see many slow downloads timing out
            # - CHECK_SSL_VALIDITY=True         # set to False to disable strict SSL checking (allows saving URLs w/ broken certs)
            # - SAVE_ARCHIVE_DOT_ORG=True       # set to False to disable submitting all URLs to Archive.org when archiving
            # - USER_AGENT="..."                # set a custom USER_AGENT to avoid being blocked as a bot
            - CHROME_USER_DATA_DIR=/data/personas/Default/chrome_profile
            - DISPLAY=novnc:0.0
            # ...
            # add further configuration options from archivebox/config.py as needed (to apply them only to this container)
            # or set using `docker compose run archivebox config --set SOME_KEY=someval` (to persist config across all containers)
        # For ad-blocking during archiving, uncomment this section and pihole service section below
        # networks:
        #   - dns
        # dns:
        #   - <IP_ADDRESS>

    archivebox_scheduler:

        image: archivebox/archivebox:latest
        command: schedule --foreground --update --every=day
        environment:
            - TIMEOUT=120                       # use a higher timeout than the main container to give slow tasks more time when retrying
            # - PUID=502                        # set to your host user's UID & GID if you encounter permissions issues
            # - PGID=20
        volumes:
            - ./data:/data
        # cpus: 2                               # uncomment / edit these values to limit scheduler container resource consumption
        # mem_limit: 2048m
        # restart: always

    sonic:
        image: valeriansaliou/sonic:latest
        expose:
            - 1491
        environment:
            - SEARCH_BACKEND_PASSWORD=SomeSecretPassword
        volumes:
            - ./sonic.cfg:/etc/sonic.cfg:ro    # use this if you prefer to download the config on the host and mount it manually
            - data-sonic:/var/lib/sonic/store

    novnc:
        image: theasp/novnc:latest
        environment:
            - DISPLAY_WIDTH=1920
            - DISPLAY_HEIGHT=1080
            - RUN_XTERM=no
        ports:
            # to view/control ArchiveBox's browser, visit: http://<IP_ADDRESS>:8080/vnc.html
            # restricted to access from localhost by default because it has no authentication
            - <IP_ADDRESS>:8180:8080

networks:
    # network just used for pihole container to offer :53 dns resolving on fixed ip for archivebox container
    dns:
        ipam:
            driver: default
            config:
                - subnet: <IP_ADDRESS>/24

volumes:
  data-sonic:

ArchiveBox Configuration
SECRET_KEY = ***

You've already tried everything I would try, I don't have many ideas unfortunately.
Maybe some other SMB / users can chip in and offer advice? Does SMB implement locking like Unix filesystems do, perhaps chrome on Linux is expecting Unix file locking to work and is failing when the underlying drive doesn't support it?

Just curious, does this error occur when you run against a new clean /data/ folder?
Also, try running docker compose run -it --remove-orphans archivebox /bin/ls -liah /data/personas/Default/chrome_profile/.  I suspect either the directory permissions are wrong (like wrong owner or user) or a lock already exists.
For me, I saw the following files which prevented me from launching:
1535 lrwxr-xr-x  1 archivebox root   19 Nov 18 22:15  SingletonCookie -><PHONE_NUMBER>842911122
1533 lrwxr-xr-x  1 archivebox root   17 Nov 18 22:15  SingletonLock -> 62ac359410cc-1480
1534 lrwxr-xr-x  1 archivebox root   50 Nov 18 22:15  SingletonSocket -> /tmp/.org.chromium.Chromium.11FDDc/SingletonSocket

To remove those three lines:
docker compose down
docker compose run -it archivebox /bin/bash -c "rm /data/personas/Default/chrome_profile/Singleton*"
docker compose up -d --remove-orphans


After 2.1.0 update - ERROR: Unable to exclude default styles

I was getting the same default style bug on clean build as described here #1115
I updated to 2.1.0 because it is suppose to have a fix for this issue, however once I update to 2.1.0 I receive the following error when I run gulp -
ERROR: Unable to exclude default styles
I thought it might be related to the includeDefaultStyles but I am not using this and adding it to my gulp file doesn't seem to effect the outcome. Any help would be greatly appreciated because I am having to revert back to version 1.7.0 to not have the default style bug issue.
Also, I found that if you run gulp twice after a clean build the style bug seems to fix itself. Not sure why?

I had the same issue with a fresh build and adding includeDefaultStyles: true to our config fixed it. This happens because this conditional:
https://github.com/SC5/sc5-styleguide/blob/b9787e3501ef1d712d43b98620ed4fdec0a7298d/lib/modules/common.js#L35
sets it to false if you don't specify it.
So the readme is actually wrong because the default is not true:
https://github.com/SC5/sc5-styleguide/blob/580b6d0868d29ad4511602b4eedbe1a9a7c67959/README.md#L229

Fix available in #1130.


Use proper operation name in default client error

Fixes #2945

Thanks for the merge @casualjim. When is the next release planned?


fix react build

i am embarrassed that this is the solution. its due to webpack being hidden and the js ecosystem (mainly webpack) being in a very ugly transition to web standard modules.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

verified that npm run build now works
npm run build

><EMAIL_ADDRESS>build
> react-app-rewired build

Creating an optimized production build...
Compiled with warnings.

File sizes after gzip:

  118.46 kB  build/static/js/main.8feb2e91.js
  1.78 kB    build/static/js/787.545aecf5.chunk.js
  541 B      build/static/css/main.073c9b0a.css

The project was built assuming it is hosted at /dash/.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.

Find out more about deployment here:

  https://cra.link/deployment

but still have some nonsense sourcemap spam

I am not going to pretend I understand this. Just sign the CLA and I'll merge :)


No Sign up button?

Hi, when I log in I can't see a Sign up button, only Log in: is it normal?

yeah its normal 😀. the idea is to prepare a prototype for login functionality that you can implement next


Update DPDK version to 18.05

DPDK 18.05 has been released, we may want to switch to new version.

Done in 0.4


为什么我npm install dva-cli -g 安装不了，一直报错？

What happens?
A clear and concise description of what the bug is.
Mini Showcase Repository(REQUIRED)

Provide a mini GitHub repository which can reproduce the issue.
Use yarn create umi, select app, choose dva, then upload to your GitHub

How To Reproduce
Steps to reproduce the behavior:
1.
2.
Expected behavior
1.
2.
Context

Dva Version:
Node Version:
Platform:

maybe you meet permission error. you can try  sudo npm install dva-cli -g


[epic] OLMv1 Should be suitable for real Clusters

User story
As a cluster administrator, I want to ensure that OLMv1 works seamlessly with existing cluster configurations, especially when cert-manager is installed. This includes ensuring that cert-manager dependencies are handled properly, without impacting the overall functionality or stability of the cluster.
As a Cluster Administrator:

I want to install solutions using OLMv1 in clusters where cert-manager is already present.
I do not want OLMv1 to override, replace, or disrupt the existing configuration of cert-manager.
I need OLMv1 to respect and integrate with the cluster's existing components without causing conflicts or compatibility issues.

Maintainer Perspective

I want cert-manager to be treated as a project dependency and not embedded directly within it.
I still want an installer that can install the project and its dependencies so that I can quickly test and develop against it.
I need to ensure that users can independently manage cert-manager without interference from the project.

List if issues

[ ] Create a RFC so that a design solution can be discussed

New content or update?
Net-new content
Types of documentation
Concept
References
No response

This one might be blocked by: https://github.com/operator-framework/operator-controller/issues/982#issuecomment-2548966863


Pigsteel armor trim icons displaying diamond trim

Yeah that's cuz the trim system mojang setup is horrible sadly. Will probably use Trimmed library in the future to fix this


OC-648 Peakshaving: adapt the chain so the output given by a MQTT device is handled correctly

SonarQube analysis reported 6 issues

 4 critical
 2 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L41: Override the "equals" method in this class.

SonarQube analysis reported 6 issues

 4 critical
 2 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L41: Override the "equals" method in this class.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L41: Override the "equals" method in this class.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L44: Override the "equals" method in this class.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L44: Override the "equals" method in this class.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L45: Override the "equals" method in this class.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 GridMeasurementPublishedEventConverter.java#L45: Override the "equals" method in this class.


Support bare relative links

Fixes #95
Markdown (or at least GitHub's markdown w/ extensions) supports bare relative links like
[link](some_file.md)

But this would fail when trying to strip the current directory prefix because there isn't one
Manually tested that this still works with anchors, paths prefixed with ./, etc. This whole section could use a refactor and some automated testing

Yeah definitely can't believe this wasn't picked up earlier, I just expected it would work. But this change looks good for now we can deal with the rest later.


onnxruntime_gpu installed on amd64

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines
[X] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

onnxruntime-gpu doesn't install

What is the new behavior (if this is a feature change)?

onnxruntime-gpu installs on amd64 machines

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

Fantastic Pandu!


BUG: Export wallet - Key string has too many characters (Mobile + Desktop)

There should be only 13 characters from each side of the "..."

@yaroslav-fedyshyn-nordwhale wasnt this fixed already?

@sirpy yes it was fixed already.
@LiavGut How and where did you get such long string? I cannot reproduce it on goodev and locally too.

maybe it just wasnt fixed on production?

On production, desktop + mobile

On goodqa it looks as expected

@sirpy @LiavGut
I checked the code and found that the src/lib/utils/string.js file on the production instance contains an old implementation. That's why the key displaying wrong.

The latest changes for the src/lib/utils/string.js file is already on production (I checked).
Also, I tested how it displays - works fine.
So moving it to the QA

@sirpy The "My wallet private key" string is displayed well
Checked on qa V1.4.1-0  // Prod V1.4.0
Desktop: Windows 10 // Google Chrome  85.0.4183.121
iPhone 8 //13.3.1


Content no longer loads on 1.0.0-beta.6

Did setRows or addRows go away or something? I'm not getting any errors that they are undefined, but none of my rows load anymore.

Nope they didnt go away. This is a rendering issue with ember-scrollable.
This is a known issue in the latest beta that we are currently working on. Please revert back to beta.4.

Closing since this is a duplicate of #74


Enable Upload of EPW files

If a user has a valid EPW file that it wants to upload and analyse it shoud be possible to do so
this needs to be solved together with #52

issue related to #52

done with b0661781553d67580e79b60aafa2a0c175bf7386


Plans for the next major version (v2.0)

Replace inquirer.js with enquirer, more lightweight and testable.
Bundle the module with webpack, so the install size will be < 1MB.
A new convention for writing saofile.js for flexibility 🤔https://gist.github.com/egoist/473170713977f6817e39a87db15701a8#file-saofile-js
Written in TypeScript
Upgradable template

hi, thanks for sao whats about parsing args? directly witout using third party lib :D

Just chiming in to say that I think the current saofile.js format is more intuitive than the proposed format.
Personally I love Hygen's approach to prompts and copying files. Have a basic mode for just parsing all the files in template with EJS, and then a more advanced mode for fine-tuning the actions.
But that said I think the current format is great 👍

And the scaffolded project upgrade tool would be amazing

@seaneking loading generator based on folder structures and using inline front matter instead of config file look pretty interesting 👀 maybe we should consider that too.

I don't think the inline frontmatter would be a good approach for sao, since it really breaks down once you have more than a couple of files. It's great for mini generators for new components/etc like Hygen was designed for, but not for whole projects like sao is designed for. They're complimentary tools/approaches and I use both.
For example I use sao to scaffold out client Gatsby projects, and having to write frontmatter for the 93 files in that template would be really painful.

Just rewriting the aforementioned Gatsby generator (coming from Yeoman) and one change I think sao should make for v2 is taking a function for the filter argument to add, passing the answers hash and expecting to return an array of files to exclude. Right now the key:value object is pretty limiting.

@seaneking: passing the answers hash and expecting to return an array of files to exclude.

You can use files to achieve this:
actions() {
  return [
  	{
  		type: 'add',
  		files: ['*', !this.answers.ts && '!tsconfig.json'].filter(Boolean)
	}
  ]
}

Oh nice. I didn't realise you could pass a function with the generator instance to actions. In that case I think that should be better documented, and maybe the filter and similar methods deprecated, because you can acheive all that more succinctly by returning a function like this.
FWIW sao errored when I tried to access this.answers in actions, I had to pass access it from the generator instance passed in, ie:
actions({ answers }) => [ ... ]

Started the work #145


HTTP::Request, added remote ip and peer_addr

I'm not so sure about this. I think we're adding too much intelligence to the Request already. Maybe we need to put this logic in a handler that we insert as a middleware.
Also, note that the same class is used for client requests so I wonder if we shouldn't have a context object instead that we pass around between server handlers.

@waj that was my first suggestion. I only added the peeraddr to the REMOTE_ADDR header to be used in middleware. I like the peer_addr on request better. But perhaps we can move the remote ip logic to a handler that sets the REMOTE_ADDR header? Or is there another way of passing that info down the middleware stack without using the headers?

I would really dislike adding custom headers. And a middleware approach would do the detection on every single request, keep in mind it's about 10 header checks per request.

But if you use it for logging purposes you're gonna be doing the lookups on every request either via the middleware or via the request object.
If you only need the remote ip let's say every ten requests then it's 10 headers checks you're not gonna need
But there's always the option of creating an extra class where the logic can be placed. We could also create an HTTP util class.
But in all cases do we agree to the peer_addr being set on the request? Cause I would happily split the pull request into peer_addr and remote_ip

How about having a middleware that calls underlying handlers with request decorator, that has all the additional logic added on top of raw request? i.e.:
class SmartHTTPHandler < HTTP::Handler
  def call(request)
    smart_request = SmartRequest.new(request)
    call_next(smart_request)
  end
end

class SmartRequest
  private getter original_request
  def initialize(@original_request)
  end

  delegate_when_missing_to original_request

  # lazily fetches peer address of request
  def peer_addr
    # ...
  end

  # set peer address of request
  def peer_addr=(value)
    # ...
  end

  # .. and more stuff, like #url_params, #body_params, etc. ..
end

Other point, is that middleware is not required in this case, one can use these decorators directly on demand.

We plan to make a review of http request/response and client with @waj for this, and we'll hopefully come with a good solution.

@asterite now that https://github.com/crystal-lang/crystal/pull/3406 is merged WDYT about this?

@sdogruyol It's on our TODO list, just that we won't implement it this way (it doesn't have to be attached to the request, it will probably be in the HTTP::Server::Context).

I originally came here to make sure this doesn't consider the HTTP headers as the authoritative source for IP address since HTTP headers can be spoofed. Glad to see there is an option to rely on the socket information (coming from the TCP connection data itself) or the HTTP header.
As far as code quality is concerned, LGTM. Perhaps some cleanup of the specs according to the comments already left by others.
LGTM :+1:

FWIW it would be "convenient" to have this in there I think people would use it.  Here's how rails 2.3 does it: https://gist.github.com/rdp/ec8d8d7152988f496f951a2f0d65a320

Still not merged!! I really need that right now 😅   @benoist

Well i think this code is pretty outdated. Happy to make the required changes to get this merged though.

@benoist Yeah I'd say do it, if not I will in a couple weeks I think...

Wow, i still remember the day this issue opened. Time really flies 😄

@rdp Do we know what the required changes are, as I believe @asterite was going to discuss the implementation details with @waj

I assume just the review comments but everybody feel free to chime in :)
On Mon, Apr 10, 2017 at 11:36 AM, Benoist<EMAIL_ADDRESS>wrote:

@rdp https://github.com/rdp Do we know what the required changes are,
as I believe @asterite https://github.com/asterite was going to discuss
the implementation details with @waj https://github.com/waj
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/crystal-lang/crystal/pull/1722#issuecomment-293022735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAw0CrOCBc78bFWJvIHNB-B95GVrWV6ks5rumimgaJpZM4GMm_q
.

@sdogruyol It's on our TODO list, just that we won't implement it this way (it doesn't have to be attached to the request, it will probably be in the HTTP::Server::Context).

That was after the review comments from jhass

This is too old so I'm closing it.
We still need this functionality, though, but it will probably come from the core team. Maybe we can copy what Go does, but I don't know (I don't know much about HTTP and proxies).


Fixed Layout Files

Some games may be functional, but the MAME default.lay files in the artwork.zip is not fully supported, and thus some titles will show graphical issues. This will typically present as the background covering up the LCD, so that you can't see anything (see #1), but there are other possible errors as well (hbw_squeeze uses special MAME constants that are not supported).
This issue is intended to be a catchall for fixed layout files. If you create a new layout file for a game to fix some issue, please create a comment and attach it here. Layouts should be trivial supporting files, so licensing shouldn't be a problem in my understanding

hbw_squeeze
hbw_squeeze_layout.zip
This title creates its SVG in a different manner from all other ROMs I've seen, so unfortunately the generator still cannot parse it (the format is weird, and the paths don't have unique IDs, so they are unable to be distinguished). However, when considered without the LCD SVG, the ROM builds and displays correctly.

gnw_cgrab.zip
seems to fix crab grab

gnw_ssparky.zip
zip contains only the layout file
seems to fix spitball sparky

ktopgun.zip
tgaiden.zip
tgaunt.zip
tinday.zip
tmegaman3.zip
Top Gun , Ninja Gaiden , Gauntlet , Independance Day , Megaman 3
you may need to to rename bg.png to background.png

The new .lay file for tgaiden works insomuch as the game now loads and plays.
When compared to the actual hardware, the lcd looks as though it's shifted a bit lower than the real deal.
Crab Grab's LCD also seems to be offset from the original hardware. These issues could be a result of scaling discrepancies between the background and the LCD.
For reference:
Ninja Gaiden
Crab Grab
Thanks for getting these titles up and running. Some just need a lil tweaking to get them just right.

When compared to the actual hardware, the lcd looks as though it's shifted a bit lower than the real deal.
Can you please open the game in MAME and compare? I doubt there is a scaling bug on my side.

I was referencing the zips that @terminator2k2 added to this thread
Perhaps I'm not understanding what these modified .lay files are doing. I thought they were responsible for placement of the LCD assets.
I'll have another look and get back here asap.

Perhaps I'm not understanding what these modified .lay files are doing. I thought they were responsible for placement of the LCD assets.

They do. I haven't checked, but I assume Terminator didn't change any of the asset positions, so they should be identical to the normal MAME ROMs (you can even compare the original artwork with the modified one, if you'd like).

retry this one for
tgaiden.zip
tgaiden

retry this one for
tgaiden.zip
tgaiden

Bingo! Looks great.
Crab Grab's issue is not nearly as distracting, but it is slightly off center. If I had the expertise, I'd take a stab at modifying the .lay myself.
I'll leave it to the pros

for crab grab i didnt mess with the original values, but i just had a play and came up with :
before:

after:

so give this a try:
gnw_cgrab.zip

for crab grab i didnt mess with the original values, but i just had a play and came up with :
before:

after:

so give this a try:
gnw_cgrab.zip

Looks much better. Thanks!
One last thing for these SuperColor titles: there should be one graphic layer in the foreground over the LCD to give the black LCD assets a unique hue for each column.
As seen here
Perhaps I should open a new issue for this

One last thing for these SuperColor titles: there should be one graphic layer in the foreground over the LCD to give the black LCD assets a unique hue for each column.
Perhaps I should open a new issue for this

That is covered by #1. There are blending effects used that I do not support, so the color doesn't get applied.

One last thing for these SuperColor titles: there should be one graphic layer in the foreground over the LCD to give the black LCD assets a unique hue for each column.

Perhaps I should open a new issue for this

That is covered by #1. There are blending effects used that I do not support, so the color doesn't get applied.

Roger. I think I can live with that

I cannot get Trspider to generate a rom. I get the error "Could not find suitable view." Do you know why this might be?

I cannot get Trspider to generate a rom. I get the error "Could not find suitable view." Do you know why this might be?

I would have to see the default.lay file contained within the trspider.zip artwork zip. Most likely your version of the art doesn't have a nicely named MAME view (one of the selectable display options), and thus the tool reports that it doesn't know what to do. You could modify the default.lay to have one of the names listed here

trspider_layout.zip

trspider_layout.zip
This should fix that problem at least. I renamed the second to last view to be "background only (no shadow)". I imagine others here have already fixed this layout and others like it.

That worked! Thank you so much!

hbw_squeeze
hbw_squeeze_layout.zip
This title creates its SVG in a different manner from all other ROMs I've seen, so unfortunately the generator still cannot parse it (the format is weird, and the paths don't have unique IDs, so they are unable to be distinguished). However, when considered without the LCD SVG, the ROM builds and displays correctly.

Hi,
I'm trying to generate .gnw file with this layout and I get the following error:
"Top and bottom screen sizes don't match"
Not sure if I'm running the command properly. I copied this default.lay on artwork zip file replacing the original one and changing top.png and botton.png file names.
fpga-gnw-romgenerator.exe --mame-path D:\fpga-gnw\ --output-path D:\fpga-gnw\ --homebrew specific hbw_squeeze
Thanks,
Shark

Your command is correct. You should not have to change the names of the artwork file; they're already named top.png and bottom.png.
I'm not really sure what is causing your issue, as the top and bottom images are the same sizes. Did you swap them out or something?
In any case, Squeeze requires a rebuilt SVG, which cannot be posted here. Without that rebuilt SVG, my tool cannot build the ROM.

Where could I find/download the correct SVG (rebuilt)?
Thanks,
Shark

which cannot be posted here
It would be violating the copyright of the original game to post a modified SVG. Thus I cannot endorse any method other than doing it yourself (or applying a IPS patch, which doesn't exist to my knowledge).

We've discussed distributing IPS patches in the future to make this process easier.

We have obtained permission from the Squeeze creator to distribute the modified ROM. It can be found in this comment

I cannot get these two games to display properly. The games won't start. They are Shuttle Voyage and Thief in Garden. I'm attaching the layout files for them.
Shuttle_Voyage_default.zip
Thief_in_Garden_default.zip

This is not the correct issue to discuss your problem. Please create a new issue describing what is wrong.

I’m not sure if I should rename hbw_squeeze_layout.zip or hbw_squeeze_rom.zip, and I also do not know were to put them in my windows folder?

Can someone please explain what I need to do?

I have updated the instructions in the original post.

Can someone please explain what I need to do?

I have updated the instructions in the original post.

I understand that you have updated the instructions in the original post, but the way you worded it made it sound very unclear to me. Can you please explain it to me in more detail?

I'm still having trouble hbw_squeeze, even using the two files posted earlier to this ticket:

hbw_squeeze
hbw_squeeze_layout.zip
hbw_squeeze_rom.zip
(place the layout in the layout folder, and the rom in the ROMs folder, after renaming each of them to hbw_squeeze.zip)
The author of Squeeze was gracious enough to allow us to modify and redistribute the ROM, so here is the fixed SVG ready to reuse (just rename it to hbw_squeeze.zip)

I'm using version 0.2.0. The command and output are:
.\fpga-gnw-romgenerator.exe -m .\mame\ -o .\out\ --homebrew specific hbw_squeeze
-------------------------
Processing device hbw_squeeze

SVG contains invalid nested paths at None
Failing device hbw_squeeze

-------------------------
Total: 1, Success: 0, Fail: 1, Skip: 0

For completeness, my directory looks like:
│   fpga-gnw-romgenerator.exe
│   manifest.json
│
├───mame
│   ├───artwork
│   │       hbw_bride.zip
│   │       hbw_squeeze.zip
│   │
│   └───roms
│           gnw_dkjr.zip
│           gnw_mickdon.zip
│           hbw_bride.zip
│           hbw_squeeze.zip
│
└───out
        Bride.gnw

Am I doing something obviously incorrect?

That seems like you're not using the correct ROM zip.

I'm using the ROM linked above. Here's my md5 hash if you'd like to compare.
mame/roms$ md5sum gnw_mickdon.zip hbw_squeeze.zip
10b363cff6524b94b3e1f5359eaf13fa  gnw_mickdon.zip
1ef0043f9ba02c842d424d88210aab75  hbw_squeeze.zip


Deploy master branch to staging environment in CircleCI

Resolves #190
Impact: minor
Type: feature
Issue
We would like to automatically deploy the code from the master branch to a staging environment.
Solution
Added a step to the CircleCI pipeline which deploys the Docker image built previously by CircleCI to an AWS ECS cluster, to a service already created within that cluster.
Testing

Push a change to the master branch, wait for the CircleCI to finish, then visit https://starterkit-staging.devops.reactioncommerce.com/ to make sure your change was deployed.

@griggheo one more thing, pleas load our sample data found here: https://github.com/reactioncommerce/reaction-catalog-sample-data

@griggheo I have fixed the Snyk issues, now just the lint errors need to be fixed. I ran lint locally in my container and don't see any errors. So the problem is with the cicle CI config.


"Up" and "Down" traversals

Getting to the predicates from a node, or the nodes from a predicate, or some odd combinations thereof. Ditto for label.

Moving discussion to feature requests: https://discourse.cayley.io/t/up-and-down-traversals/241


documentation improvement: metals memory settings

Describe the feature
Hi,
Would it be possible to document how to configure the JVM memory settings for metals? (gc, Xmx etc)
I've tried to look at https://github.com/scalameta/nvim-metals/blob/main/doc/metals.txt but cannot seem to find it there (nor on the website https://scalameta.org/metals/docs/editors/vim)
Thanks
Potential ways to implement
No response

Hey @svalaskevicius thanks for the request! For sure, I can try to make this clearer. There is actually a fair amount of stuff that goes into this. It looks at the .jvmopts file and also grabs a few other things. You can see some of the logic here: https://github.com/scalameta/nvim-metals/blob/main/lua/metals/jvmopts.lua. Let me try to come up with some illustrations and figure out the best place to put some more info.

Hey @svalaskevicius getting back to this, actually looking further into this, did you read the docs for serverProperties. This is actually what you'll want to use for this:
serverProperties                                              *serverProperties*

Type: table ~
Default: {} ~

Table of properties to pass along to the Metals server. By default, the
environment variable `JAVA_OPTS` and the `.jvmopts` file are respected.
However, we care most about the proxy settings from those places, not
necessarily the memory options since Metals has different requirements for
example than sbt. So if you have proxy settings defined in `JAVA_OPTS`, then
no need to define them here again. However, if you want to set some spefic
memory settings for Metals, then this is the place.

So thinking about documenting this more, do you have any recommendations on how to make this easier for people to find or to use?

Hi, I've completely missed it! Thanks!
My search in the docs was based on various forms of java, opts, Xmx and similar keywords, and I'd stumbled at least twice on java home and ammonite jvm opts.
Maybe just some similar search keywords for other users would be beneficial, or crosslinking java home option to this?
Thanks again :)


Enable segment pixel with new parameter

Task/Issue URL: https://app.asana.com/0/488551667048375/1204954184560576/f
Description
Add new parameter to m_daily_user_event_segment pixel
Steps to test this PR
Existing user won't be sending the pixel with new parameter

You need an older version app without this implementation
Install from this branch
[ ] Check pixel is not sent when opening the app (filter by Pixel sent: m_daily_user_event_segment in Logcat)

New parameter is sent with pixel

Comment Line 41 after val shouldFireSegmentPixel = and Line 42. In this way, the pixel is sent every time the app is opened.
Fresh install
Set DDG as default in onboarding (optional)
Use fire button (optional)
Close app
Open app
[ ] Check pixel is sent with new parameter days_since_app_install and (optional) parameters set_as_default and fire_button_used set to true (filter by Pixel sent: m_daily_user_event_segment in Logcat)

Current dependencies on/for this PR:

develop

PR #3311   👈

This comment was auto-generated by Graphite.

Not needed anymore


docs: fix wording for proper written notation

Describe this PR
Fixed the following non-compliant written form of terms in docs:

Npm is incorrect
Javascript is incorrect

Changes
Wording changes.

Appreciate the quick response 🚀


DPG form visual cues added for required questions

Required questions did not have the star (*) visual cue.
They were missing the isRequired: true, property in JSX.
They have been added now.

@lacabra I had to slightly change the UI of the thank you page.
I'll attach a screenshot of how it looks like below


Fix compact proof decoding unaccessed last child trie.  (#9715)

This PR backports #9715 into the polkadot-v0.9.10 branch.

fix no child proof attached but root included.
small stress test for proof of child tries.
rust fmt

@bkchr is it ok merging this one ?


Chapter 8 Issues [version 2022-05-02].

Section 8.2

p. 323 (latex) line 32: z subscript should be uppercase - "z_t" --> "z_T".

p. 314 (latex) Eq. 8.43: missing "= j" - " p(z_{t+1}|y_{1:T})" --> "p(z_{t+1} = j | y_{1:T})".

p. 315 (latex) line 26: "If we define \xi..." this line already appears at the top of the page (line 2).

p. 315 (latex) line 38: A is defined as the transition matrix between z_{t-1} and z_t, while they are equivalent, for consistency with the figure that this sentence is referring to (Figure 8.3) it might be helpful to write it as "A = p(z_t | z_{t+1})".

Section 8.3

p. 320 (latex) Eqs. 8.73, 8.74: This LG-SSM models are defined to include inputs (u_t) and with an autoregressive term (E_t). In the next sentence these terms are all stated to equal to 0 and I don't think they are used at any point in the rest of the section. Given that the full equations are given in Chapter 28, it might be more clear to just drop these terms entirely.

If this were done it would be necessary to make the following additional changes for consistency:

p. 320 line 45: drop the conditioning on u in the joint p(y,z|u) --> p(y,z).
p. 320 Figure 8.6 would have to change, the new form would be identical to Figure 8.1(a).

p. 321 (latex) line 26,27: The sampling frequency is referred to in the text as \Delta but in Eq 8.75 I think the equivalent term is written as "\Delta t".

p. 322 (latex) line 3: Typo - "thay" --> "that".

p. 324 (latex) Eq 8.91: The term h_t has previously been referred to as C_t (e.g. in Eq 8.81).

p. 324 (latex) line 11: The noise term \epsilon_t was previously labelled r_t (Eq 8.76).

p. 327 line 46: "using the same island algorithm as in Section <IP_ADDRESS>". I think the corresponding algorithm is called the "divide and conquer algorithm" in Section <IP_ADDRESS>.

Section 8.4

p. 331 (latex) Eq 8.145: P(X=x | u), in the rest of this section the notation "Pr(.)" is used for probabilities.

fixed, thanks


Handle errors gracefully on routes

Description
This fixes an unhandled error on the GetEnvironmentEnvironments route, as well as standardizes error value treatment using an error to http status converter. All status codes now use the standard net/http consts (enum).
How Has This Been Tested?
Tested with make test.
Merge criteria:

[x] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Do we want to do anything with left over "todo" comments? if no further steps we are going to like 401 ones which get intercepted at filter level, can we remove them?

Do we want to do anything with left over "todo" comments? if no further steps we are going to like 401 ones which get intercepted at filter level, can we remove them?

I'd advise to manage the TODOs as follow-up PR, so to keep the scope of this PR to start consolidating repeated code, while "debt" to be managed separately


Refactor subscription logic

Signed-off-by: MUzairS15<EMAIL_ADDRESS>Description
This PR fixes potential race condition.
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #5964 (cc90a75) into master (2ab8585) will increase coverage by 0.60%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #5964      +/-   ##
=========================================
+ Coverage    5.79%   6.39%   +0.60%
=========================================
  Files         107     110       +3
  Lines       10248   10394     +146
=========================================
+ Hits          594     665      +71
- Misses       9497    9560      +63
- Partials      157     169      +12

Flag
Coverage Δ

gointegrationtests
6.39% <0.00%> (+0.60%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

UI integration test fails with: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

Re ran workflow

UI integration test fails with: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.

Integration test failing, not related to this PR.
Pushing changes, hopefully, passes.🤞🏻


multi: convert the existing channeldb.ChannelType uint8 into a bit field

In this commit, we convert the existing channeldb.ChannelType type
into a bit field. This doesn't require us to change the current
serialization or interpretation or the type as it is, since all the
current defined values us a distinct bit. This PR lays the ground work
for any future changes that may introduce new channel types (like anchor
outputs), and also any changes that may modify the existing invariants
around channels (if we're the initiator, we always have the funding
transaction).

Travis fails for the dual funder flow:
--- FAIL: TestLightningWallet (356.83s)
    --- PASS: TestLightningWallet/btcwallet/bitcoind:change_output_spend_confirmation (6.29s)
    --- PASS: TestLightningWallet/btcwallet/bitcoind:insane_fee_reject (0.01s)
    --- PASS: TestLightningWallet/btcwallet/bitcoind:single_funding_workflow (0.72s)
    --- PASS: TestLightningWallet/btcwallet/bitcoind:single_funding_workflow_tweakless (2.46s)
    --- FAIL: TestLightningWallet/btcwallet/bitcoind:dual_funder_workflow (0.33s)
        interface_test.go:489: unable to consume alice's sigs: counterparty's commitment signature is invalid

Fixed the test failure. An earlier version was incorrect in that it re-defined the base channel type (single funder) to one instead of zero. I fixed that, but then introduced another bug that would cause it to not recognize dual funder channels properly. This has been fixed now, by defining IsSingleFunder using the dual funder bit.


kubelet-ds: mount iscsiadm and /lib/modules into self-hosted kubelet

As this is done by the bootstrap kubelet as well and is required for
running OpenEBS.
Signed-off-by: Mateusz Gozdek<EMAIL_ADDRESS>

Just a note, some OpenEBS issue involving CoreOS also suggests mouting /etc/iscsi into kubelet, so I guess if user has some custom iSCSI settings, kubelet will use them. I'm not sure if we need it for now though. Refs: https://github.com/openebs/openebs/issues/160#issuecomment-315104565

Closing in favor of #168.


[242] Fixed a data racing bug

Changelog category (leave one):

Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Can one of the admins verify this patch?

test this please


bug(CdkDragDrop): Nested cdkDropLists don't work correctly

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
It is necessary to use nested cdkDropLists with the ability to drag and drop elements between them: elements must be dragged between all cdkDropLists, as well as within the cdkDropLists themselves. When dragging an element from a nested group, there is no possibility to drag and drop within the same group from which the element is dragged.
Reproduction
StackBlitz link: https://stackblitz.com/edit/components-issue-eksnha?file=src%2Fapp%2Fexample-component.ts
Steps to reproduce:

Try re-sorting the items within group 1 or within group 2.

Expected Behavior
Elements within groups are sorted
Actual Behavior
Sorting doesn't work because the items are dropped at the root level and can either be dropped into another group or at the root level, but it's impossible to return them to the group they were pulled from.
Environment

Angular: 16,2,12
CDK/Material: 16,2,13
Browser(s): Version 130.0.6723.58 (Official Build) (64-bit)
Operating System (e.g. Windows 11, macOS, Ubuntu):

Duplicate of #16671.


⚠ ClamAV has degraded performance

In 7b1a102, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 439 ms

Resolved: ClamAV performance has improved in 540c685.


Build 1.22.1 breaking Platform IO build tasks

VSCode Version: 1.22.1
OS Version: Windows 10

Steps to Reproduce:

Upgrading the VScode to this version
Build any existing platform IO project
The build task gets stuck and no progress is displayed nor the task finish.

This build tasks were working fine just before the update. (minutes before)

Dups https://github.com/Microsoft/vscode/issues/47350


Epic - Create a smarter installer for the container wrapper scripts

The primary blocker for switching to a feature-branch strategy is the image and branch definition in the wrapper scripts.
The proposed solution is to abstract the version definition out of the wrapper scripts in some way and and develop a uniform way of installing the scripts locally.
An initial experiment and subsequent updates have proven to be worth exploring further.
The current install script is still dependent on the version branches. Refactor as necessary to abstract away that dependency.

A new project has been created to address this.


Restart commands to be reset to Start

Hello, all Restart-AzVm commands need to be reset to Start-AzVm as VMs won't restart after stopping them in a previous command. Hence, scripts fail once done with updating using Update-AzVm

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a34525b2-3bf1-d23a-2712-3e8a124a32e0
Version Independent ID: 632314eb-3599-03ca-6ed2-3b1838d68158
Content: PowerShell: Use proximity placement groups - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/proximity-placement-groups.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

#assign @cynthn

@RaviMSHybd Thanks for the feedback! I have filed a pull request to make the changes. Thanks again :)
#please-close


"ESCU - Baseline Of Cloud Instances Destroyed" failed with "Error in 'fit' command: Error while fitting "DensityFunction" model: Unable to fit an Exponential distribution due to numerical errors. All values in the dataset are the same."

the search is failing since there is a expon (exponential distribution)explicitly set in the fit command. Updating the search to remove that parameter

this issue is fixed in the following commit
https://github.com/splunk/security-content/pull/640/commits/d95a7452f5353fa0785d365f467ba56f51284621
Thank you for reporting this bug @kkolli4

As discussed, reverted this commit as this parameter dist=expon is intentional


call prototype overrides with original context

The overridden prototype calls are executed with the wrong context, causing errors if any of the wrapped lifecycle methods are trying to call a local class function, i.e.
class Foo extends Component {
    componentDidUpdate() {
      this.bar() //error: bar is not defined
    }
    componentDidMount() {
      this.bar() //error: bar is not defined
    }
    bar() {}
}

Awesome, thanks!
Releasing as v0.3.0


Remove dependency on seq and allow for custom geoip server

This looks great, I will test and merge soon.

I'm wondering if it wouldn't be better to use jot as a replacement for seq, in order to avoid using eval. Maybe testing if jot exists and default on using it if so, if not try seq instead.
For info, jot is present on FreeBSD / NetBSD / OpenBSD and also on OS X.
Any thoughts on that?

I had thought about using jot, but eval seemed cleaner.
I wrote a quick test to see what happens if you do something like: "forcast:; ls;". I couldn't get it to spit out anything but a syntax error (because it's still evaluating the sequence "0.." and expecting a number after.).
#!/usr/bin/env bash

a="4"
b="9;ls "

for i in $(seq 0 $(($a-1))); do
        echo "seq:a:$i"
done

for i in $(seq 0 $(($b-1))); do
        echo "seq:b:$i"
done

for i in $(eval echo "{0..$(($a-1))}"); do
        echo "eval:a:$i"
done

for i in $(eval echo "{0..$(($b-1))}"); do
        echo "eval:b:$i"
done

The eval lines give an error similar to this:
-bash: 9;ls -1: syntax error: invalid arithmetic operator (error token is ";ls -1")

Still, probably safer to use jot.

I merged the commit which allow for custom geoip server. For the first one, while I agree using eval in this context is unlikely to cause issues, I'm still paranoid by nature :-)
I've been sleeping on it and in the end, I think the best thing to do is probably to ditch seq / jot / eval altogether and use a while loop instead.
Something like while [ $i -lt $forecast ] would do the trick I guess, and work everywhere.

I pushed a commit in the noseq branch which implement the while loop solution. Let me know if it works for you.
Does that look like an acceptable solution?

Looks good to me!

Great! I will merge this when I come back home.
Would it make sense to attempt getting AnsiWeather in the OpenBSD ports collection? If so, I could start making tarball releases, that was the original plan anyway.

Sure! You wouldn't even really need to make tarballs for it. We recently added GH_* options for pulling tags / commits from github repos!

Merged. Thanks for the pointer on the GH_* options, I'll have a look. OpenBSD Porter's Handbook is in my reading list, I'll get to it soon hopefully. I have a few OpenBSD machines so I'm definitely interested in porting some stuff.
Thanks for your contributions on AnsiWeather.

NP! Let me know if you have any questions!


"Contribute changes to this page" link does not work

i.e. from release blobstore it goes to https://github.com/cloudfoundry/docs-bosh/blob/master/release-blobstore.html.md.erb
Correct url is https://github.com/cloudfoundry/docs-bosh/blob/master/release-blobstore.md

Fixed via recent switch to mkdocs.


[BUG] Action workflow need for updated realtime notebook

Hey @heerden, please check the notebook for a regression that causes the workflow to fail for realtime rt.

Hi @vukosim, it was the low variability in the NW district data which caused the error. I have removed those districts for now. Here is the pull request #294
I will work on some additional error handling to avoid future bugs like this.

Thanks @heerden