Error "new URL(url, import.meta.url) is not supported in SSR." with ssr: false & adapter-static

Describe the bug
I'm trying to get sveltekit to work with wasm.
(Built with wasm-pack).
It works fine in the development environment, but I get an error only when building.
vite v2.4.1 building SSR bundle for production...
...
Error: `new URL(url, import.meta.url)` is not supported in SSR.

Looking at the error log, it appears that the js-script generated by wasm-pack is SSR-bundled, even though it is run only on the client side.
What I've tried:

set ssr: false in svelte.config.js
use @sveltejs/adapter-static and spa-mode
dynamic import wasm(wasm-pack generated) in onMount

Reproduction
/svelte.config.js
import preprocess from 'svelte-preprocess';
import { ViteRsw } from 'vite-plugin-rsw';
import adapter from '@sveltejs/adapter-static';

/** @type {import('@sveltejs/kit').Config} */
const config = {
	preprocess: preprocess(),

	kit: {
		adapter: adapter({
                         // spa-mode
                         // https://github.com/sveltejs/kit/tree/master/packages/adapter-static#spa-mode
			fallback: '200.html'
		}),
		ssr: false,
		prerender: {
			enabled: false
		},
		target: '#svelte',
		vite: {
			input: {
				markdown_wasm: './markdown_wasm/Cargo.toml'
			},
			plugins: [
				ViteRsw({
					crates: [
						{ name: 'markdown_wasm', outDir: './pkg' }
					]
				})
			]
		}
	}
};

export default config;

where wasm is called
<script lang="typescript">
	import { onMount } from 'svelte';
	let text = '';
	let html = '';
	let init
	let pulldown_cmark

	onMount(async () => {
		const i = await import('../../markdown_wasm/pkg/markdown_wasm')
		init = i.default
		pulldown_cmark = i.pulldown_cmark
	})

	const handleTextChange = async () => {
		if (!init) return
		await init();
		html = pulldown_cmark(text);
	};
</script>

init() (js-script which wasm-pack generated)
async function init(input) {
    if (typeof input === 'undefined') {
        input = new URL('index_bg.wasm', import.meta.url);
    }
    const imports = {};
    imports.wbg = {};
    imports.wbg.__wbindgen_throw = function(arg0, arg1) {
        throw new Error(getStringFromWasm0(arg0, arg1));
    };

    if (typeof input === 'string' || (typeof Request === 'function' && input instanceof Request) || (typeof URL === 'function' && input instanceof URL)) {
        input = fetch(input);
    }

    // WebAssembly.instantiate(module, imports) or WebAssembly.instantiateStreaming(module, imports) are called in load(module, imports)
    const { instance, module } = await load(await input, imports);

    wasm = instance.exports;
    init.__wbindgen_wasm_module = module;

    return wasm;
}

Logs
Tomohiko@hiraki sveltekit-wasm % npm run build

><EMAIL_ADDRESS>build
> svelte-kit build

🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
⚡⚡         Hello RSW!           ⚡⚡
⚡⚡  Vite + Rust 💖 WebAssembly  ⚡⚡
🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
vite-plugin-rsw (1.8.0)
[rsw::deploy] https://github.com/lencx/rsw-node

🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
⚡⚡         Hello RSW!           ⚡⚡
⚡⚡  Vite + Rust 💖 WebAssembly  ⚡⚡
🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
vite-plugin-rsw (1.8.0)
[rsw::deploy] https://github.com/lencx/rsw-node

vite v2.4.1 building for production...
transforming (7) src/routes/todos/index.svelte
[rsw::build] markdown_wasm_bg.wasm ~> /_app/assets/markdown_wasm_bg.34797c41.wasm
✓ 39 modules transformed.
.svelte-kit/output/client/_app/assets/svelte-logo.87df40b8.svg                           1.85kb
.svelte-kit/output/client/_app/assets/markdown_wasm_bg.a665361f.wasm                     8034.25kb
.svelte-kit/output/client/_app/assets/fira-mono-cyrillic-ext-400-normal.b3140dd3.woff2   16.11kb
.svelte-kit/output/client/_app/assets/fira-mono-greek-ext-400-normal.8659ae46.woff2      7.85kb
.svelte-kit/output/client/_app/assets/fira-mono-cyrillic-400-normal.046b609f.woff2       9.08kb
.svelte-kit/output/client/_app/assets/fira-mono-greek-400-normal.1f8b3a07.woff2          10.48kb
.svelte-kit/output/client/_app/assets/fira-mono-latin-ext-400-normal.b6331a25.woff2      11.84kb
.svelte-kit/output/client/_app/assets/fira-mono-latin-400-normal.a2f9dbe8.woff2          16.44kb
.svelte-kit/output/client/_app/assets/fira-mono-all-400-normal.0d19eb5d.woff             75.54kb
.svelte-kit/output/client/_app/assets/markdown_wasm_bg.34797c41.wasm                     8034.25kb
.svelte-kit/output/client/_app/manifest.json                                             3.68kb
.svelte-kit/output/client/_app/error.svelte-2e34e082.js                                  1.55kb / brotli: 0.64kb
.svelte-kit/output/client/_app/pages/index.svelte-53d803f5.js                            4.06kb / brotli: 1.45kb
.svelte-kit/output/client/_app/pages/__layout.svelte-c0f95ef0.js                         4.62kb / brotli: 1.51kb
.svelte-kit/output/client/_app/pages/embossToImage.svelte-a91b4e29.js                    2.65kb / brotli: 1.16kb
.svelte-kit/output/client/_app/pages/markdown.svelte-64e4311e.js                         1.50kb / brotli: 0.75kb
.svelte-kit/output/client/_app/pages/about.svelte-6e209491.js                            2.39kb / brotli: 0.90kb
.svelte-kit/output/client/_app/chunks/preload-helper-9f12a5fd.js                         0.61kb / brotli: 0.31kb
.svelte-kit/output/client/_app/pages/todos/index.svelte-0c565c3b.js                      6.11kb / brotli: 2.12kb
.svelte-kit/output/client/_app/assets/start-a8cd1609.css                                 0.16kb / brotli: 0.10kb
.svelte-kit/output/client/_app/assets/pages/__layout.svelte-ded7473c.css                 5.06kb / brotli: 1.36kb
.svelte-kit/output/client/_app/start-77c5bb20.js                                         17.84kb / brotli: 5.55kb
.svelte-kit/output/client/_app/assets/pages/embossToImage.svelte-8d18bb30.css            0.14kb / brotli: 0.08kb
.svelte-kit/output/client/_app/assets/pages/index.svelte-078f1a0b.css                    1.35kb / brotli: 0.36kb
.svelte-kit/output/client/_app/assets/pages/markdown.svelte-361b27bc.css                 0.16kb / brotli: 0.10kb
.svelte-kit/output/client/_app/assets/pages/about.svelte-4db5be0d.css                    0.11kb / brotli: 0.07kb
.svelte-kit/output/client/_app/chunks/vendor-ab59cbb9.js                                 13.88kb / brotli: 5.39kb
.svelte-kit/output/client/_app/assets/pages/todos/index.svelte-05e41044.css              3.72kb / brotli: 0.86kb
.svelte-kit/output/client/_app/chunks/markdown_wasm-1d577caa.js                          29.73kb / brotli: 5.20kb

🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
⚡⚡         Hello RSW!           ⚡⚡
⚡⚡  Vite + Rust 💖 WebAssembly  ⚡⚡
🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀🦀
vite-plugin-rsw (1.8.0)
[rsw::deploy] https://github.com/lencx/rsw-node

vite v2.4.1 building SSR bundle for production...
✓ 28 modules transformed.
[asset-import-meta-url] `new URL(url, import.meta.url)` is not supported in SSR.
file: /Users/Tomohiko/workspace/sveltekit-wasm/markdown_wasm/pkg/markdown_wasm.js:4066:16
4064: async function init(input) {
4065:     if (typeof input === 'undefined') {
4066:         input = new URL('markdown_wasm_bg.wasm', import.meta.url);
                      ^
4067:     }
4068:     const imports = {};
> `new URL(url, import.meta.url)` is not supported in SSR.
Error: `new URL(url, import.meta.url)` is not supported in SSR.
    at error (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/rollup/dist/shared/rollup.js:151:30)
    at throwPluginError (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/rollup/dist/shared/rollup.js:19296:12)
    at Object.error (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/rollup/dist/shared/rollup.js:19948:20)
    at Object.error (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/rollup/dist/shared/rollup.js:19472:38)
    at Object.transform (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/vite/dist/node/chunks/dep-cc49d7be.js:50723:30)
    at Object.<anonymous> (/Users/Tomohiko/workspace/sveltekit-wasm/node_modules/vite/dist/node/chunks/dep-cc49d7be.js:51204:19)
    at /Users/Tomohiko/workspace/sveltekit-wasm/node_modules/rollup/dist/shared/rollup.js:20153:25

System Info
System:
    OS: macOS 11.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 7.12 GB / 64.00 GB
    Shell: 3.2.57 - /bin/sh
  Binaries:
    Node: 16.3.0 - ~/.nvm/versions/node/v16.3.0/bin/node
    npm: 7.15.1 - ~/.nvm/versions/node/v16.3.0/bin/npm
  Browsers:
    Chrome: 91.0.4472.114
    Safari: 14.1.1
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.13 => 1.0.0-next.13
    @sveltejs/kit: next => 1.0.0-next.124
    svelte: ^3.38.3 => 3.38.3

Severity
annoyance
Additional Information
No response

@tontoko  I am just commenting on this issue because I wrestled with it for a few hours myself and came up with a work around. I don't believe this is an actual svelte-kit issue, I believe it can be traced all the way back to wasm-pack. The challenge is the way svelte-kit can compile a component for both SSR and CSR.
In your /Users/Tomohiko/workspace/sveltekit-wasm/markdown_wasm/pkg/markdown_wasm.js file this line
4066:         input = new URL('markdown_wasm_bg.wasm', import.meta.url);
can't be transformed by the SSR compiler because it contains the URL javascript keyword as you can see above the client compiler completes just fine. I myself tried ever permutation to get the SSR compiler to ignore that line but then you can't use wasm in SSR :( so that isn't a solution. Anyway all that to say you have to remove line# 4066 or any line that contains new URL and then pass in the string url to the init function. The regex is used to parse the url during build and will return a string in dev.
Hope this helps.
export const wasm_boot = async () => {
  const res = (await import('$rsw/bin_comm/pkg/wasm_library_bg.wasm'))
    .default
    .toString()
    .match(/\(t\,\"(.*)\"\)/)

  const url = res ? res[1]<EMAIL_ADDRESS>  const init = (await import('$rsw/bin_comm/pkg')).default;
  const { add } = (await import('$rsw/bin_comm/pkg'));
  const initialized: WebAssembly.Module = await init(url);

  return {initialized, add}
}

@NiQ-B Thanks for your comments!
I tried your workaround and found another workaround by accident.
// for my wasm file: const {pulldown_cmark} = await wasm_boot('../../markdown_wasm/pkg/markdown_wasm')
export const wasm_boot = async (wasmPath: string) => {
	const init = (await import(wasmPath + '.js')).default;
	const fn = await import(wasmPath + '.js');
	const initialized: WebAssembly.Module = await init(wasmPath + '_bg.wasm');

	return { initialized, ...fn };
};

When I ran npm run dev, I got the following warning.
/Users/Tomohiko/workspace/sveltekit-wasm/src/lib/wasm_boot.ts
1  |  export const wasm_boot = async (wasmPath) => {
2  |    const init = (await import(wasmPath + ".js")).default;
3  |    const fn = await import(wasmPath + ".js");
   |                            ^
4  |    const initialized = await init(wasmPath + "_bg.wasm");
5  |    return { initialized, ...fn };
The above dynamic import cannot be analyzed by vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

  Plugin: vite:import-analysis
  File: /Users/Tomohiko/workspace/sveltekit-wasm/src/lib/wasm_boot.ts

As vite:import-analysis says, I don't think this is a good way to do it.
But at least in my environment, it can be builded and worked for both SSR and SPA with following configs.
(I checked with cd build && python -m SimpleHTTPServer 8000)
svelte.config.js
import staticAdapter from '@sveltejs/adapter-static';
const config = {
	kit: {
		adapter: staticAdapter({
			fallback: '200.html'
		}),
                ssr: false,
                ...
	}
}

or
import nodeAdapter from '@sveltejs/adapter-node';
const config = {
	kit: {
		adapter: nodeAdapter(),
                ...
	}
}

Made a proof of concept with ssr, but the new Url line has to be deleted manually currently to get ssr sveltekit-rust-ssr-template

Same error using"@wasm-tool/rollup-plugin-rust"
87: async function init(input) {
88:     if (typeof input === 'undefined') {
89:         input = new URL('index_bg.wasm', import.meta.url);
                    ^
90:     }
91:     const imports = {};
> `new URL(url, import.meta.url)` is not supported in SSR.
Error: `new URL(url, import.meta.url)` is not supported in SSR.
    at error (/prj/node_modules/rollup/dist/shared/rollup.js:158:30)
    at throwPluginError (/prj/node_modules/rollup/dist/shared/rollup.js:21741:12)
    at Object.error (/prj/node_modules/rollup/dist/shared/rollup.js:22415:20)
    at Object.error (/prj/node_modules/rollup/dist/shared/rollup.js:21917:38)
    at Object.transform (/prj/node_modules/vite/dist/node/chunks/dep-55830a1a.js:42795:30)
    at Object.<anonymous> (/prj/node_modules/vite/dist/node/chunks/dep-55830a1a.js:43303:19)
    at /prj/node_modules/rollup/dist/shared/rollup.js:22620:25

I would expect this is fixed now by passing ssr: false as a resolve option in handle. Previously SvelteKit would need to load a page on the server even when not rendering it, but that is no longer true. Please try again and let me know whether it works or not now. If I don't hear anything I will close this issue

Same error with ssr disabled.
[vite:asset-import-meta-url] `new URL(url, import.meta.url)` is not supported in SSR.
file: /home/falsetru/h/falsetru.bitbucket.io/page-src/read-slang/pkg/read_slang.js:153:16
151: async function init(input) {
152:     if (typeof input === 'undefined') {
153:         input = new URL('read_slang_bg.wasm', import.meta.url);
                     ^
154:     }
155:     const imports = {};
> `new URL(url, import.meta.url)` is not supported in SSR.
    at error (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/rollup/dist/shared/rollup.js:199:30)
    at throwPluginError (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/rollup/dist/shared/rollup.js:21848:12)
    at Object.error (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/rollup/dist/shared/rollup.js:22571:20)
    at Object.error (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/rollup/dist/shared/rollup.js:22025:42)
    at Object.transform (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/vite/dist/node/chunks/dep-9c153816.js:38785:30)
    at Object.<anonymous> (/home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/vite/dist/node/chunks/dep-9c153816.js:39320:19)
    at /home/falsetru/h/falsetru.bitbucket.io/page-src/node_modules/rollup/dist/shared/rollup.js:22817:37

src/hooks.js

export async function handle({ event, resolve }) {
    const ssr = false;
    const response = await resolve(event, { ssr });
    return response;
}

Thanks. Can you please provide a repository that reproduces this issue? I don't have a .wasm file to reproduce this with

@benmccann https://github.com/falsetru/svelte-kit-1896

Thanks!
Hmm. Even putting the code behind a browser and onMount check doesn't help. The onMount code is a no-op
that is never called (https://github.com/sveltejs/svelte/pull/6416), but is still left in place. The code wrapped in a browser check should end up getting removed and code shaken out, but I think that doesn't happen until later in the build process
Maybe the Vite check could be moved to the very end of the build process into a closeBundle hook or removed?

Maybe the Svelte compiler could remove the code in onMount?

Rich said we it can't do this in the svelte compiler, because it would need to apply to custom lifecycle functions in .js modules

A fix for this has been merged and will be included in Vite 2.9

fwiw here's my cursed workaround for the time being for emscripten:

Turn .wasm file into base64

// encode.js
import fs from 'fs';
const f = fs.readFileSync('mt63Wasm.wasm');
fs.writeFileSync('mt63Wasm.txt', f.toString('base64'));

node encode.js

Copy result and paste it into a file in your lib:

// wasmBuf.ts
const wasmBuf = Buffer.from(...base64 contents here..., 'base64');
export wasmBuf;

Wedge generated module code to just use the buffer directly

// generatedWasm.js
...
  return (
      function(Module, binary) { // pass binary with Module
          Module = Module || {};
...

          function getBinaryPromise() {
              return Promise.resolve().then(function() {
                  return binary;
              })
          }

Pass the buffer from the imported file to the initializer:

// some-endpoint.ts
import { wasmBuf } from '$lib/wasm/wasmBuf.js';
import { Module } from '$lib/wasm/generatedWasm.js';

/** @type {import('@sveltejs/kit').RequestHandler} */
export async function get({ params }) {

  const mod = await Module({}, wasmBuf);
  // Tada


InfiniteData wrapper for is removed after upgrade from 2.28.0

What version of kubb is running?
2.28.3
What platform is your computer?
MacOS
What version of external packages are you using(@tanstack-query, MSW, React, Vue, ...)
@tanstack-query v5
What steps can reproduce the bug?
After upgrading version from 2.28.0 it is removing the InfiniteData wrapper from generated hooks:

How often does this bug happen?
Every time
What is the expected behavior?
It should keep InfiniteData wrapper as we are already using for pagination.
Swagger/OpenAPI file?
No response
Additional information
No response

+1
https://github.com/kubb-labs/kubb/commit/1fa6320cef37147f92ff58ba97804c61a257cb8c#diff-f4307d209ff5a47b6e21c8318113edfeef3bd47edaa3a138c11730066c9a3361R370
After removing this, useInfiniteQuery now gets the response type from useQuery, I mean the same one, I think it should have InfiniteData wrapper.

@amorinabelt @gentrith44belt This has been resolved with v2.28.4

Hey @stijnvanhulle, thanks.
Make sure to update it also for v3 if you can, it is the same.


Lime Test Windows Error (Song.hx:65: characters 27-41 : Array access is not allowed)

Describe your bug here.
When I attempt to run Psych Engine it gives me an error of:
"source/Song.hx:65: characters 27-41 : Array access is not allowed on {+ length : Int }"
Command Prompt/Terminal logs (if existing)
PS E:\Documents\FNF-PsychEngine-main> lime test windows
source/Song.hx:65: characters 27-41 : Array access is not allowed on {+ length : Int }

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
added a new character to character list

I had the same problem

Update your haxe.


Add support for dynamically mounting volumes

Is your feature request related to a problem? Please describe.
Caikit currently assumes any necessary volumes where data is read from/written to is already pre-mounted. This leaves the various backends (e.g. TGIS, ray) left to fend for themselves for coming up with a way to mount volumes and/or read from/write to s3fs buckets in their own way.
Describe the solution you'd like
Create a standardized way to access these remote volumes, so that it can be shared by any module wishing to use remote storage.

Will close because this is being covered by other integrations.


cannot find select all dropdown

I've been through all the dropdowns but cannot find dropdowns capable to select all items at once like one of those bootstraps ui are capable of. it would be great have.

hey @y0hami , can i pick this task?
please let me know.

@Nagendra88688 Hi, feel free however this project is now dead.  Take a look at Fomantic-UI


Update prompt_step.py

Error Handling: Wrapped the API calls in a try-except block to catch and handle exceptions gracefully.

Type Hints: Ensured that the function signature includes type hints for better readability and understanding of expected input/output types.

[!IMPORTANT]
Added error handling and type hints to prompt_step() in prompt_step.py.

Error Handling:

Added try-except block in prompt_step() to handle exceptions and return error messages.

Type Hints:

Added type hints to prompt_step() function signature for better readability.

This description was created by  for 11f7c4bcb0ad51749f64569161e3e24d9c8e829f. It will automatically update as commits are pushed.

not idiomatic python and also not needed here. closing


Modified ReactNative.md file to provide introduction on Expo

I'v modified the existing ReactNative.md page to include more details on React Native and Expo, and formatted the page into a more readable style.

Added introduction to React Native and Expo so new starters can understand what these tech stacks mean
Added various links at suitable positions within the description so readers can easily access the official documentations if they require additional information
Modified the existing style of page and included some more accurate details
Incorporated my experiences from managing our project so future students can maintain a clean project and avoid conflicts or redundancies.
Added various hyperlinks to other pages within the wiki at appropriate texts. Reduces overlap with existing info on the wiki while allowing readers to find more details on various concepts, this adds cohesiveness to the entire learning centre.

Add some notes to explain what the different are between the original command and yours.


Add lint: System ordering ambiguity

It may be worth moving this to the "Suspicious" category instead of "Restriction", since ordering ambiguities are basically data races. (They're more challenging to fix, which is why I don't think they should be a hard error under the "Correctness" category.)


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/106384

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/108018

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110323

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110800

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113632

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114526

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117152

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119934


Revert "Updated sponsor's sort"

Reverts fossasia/open-event-android#1694

@niranjan94 Please merge


fix(webhook): more robust cidr check for ippool

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

We relied on a node annotation called rke2.io/node-args to extract the cluster-wide service CIDR string --service-cidr. It's an RKE2-specific annotation. Currently, there's no other good way to get such information via Kubernetes API calls. Plus, the implementation has a flaw iterating through all the nodes: worker nodes do not have such a flag so the validation procedure will fail if the cluster has any pure worker nodes.
On the other hand, we need a way for admin to specify the cluster-wide service CIDR if the cluster is not RKE2.
Solution:

Load the cluster-wide service CIDR from the following sources:

rke2.io/node-args annotation in management Node objects
Webhook command argument --service-cidr
Default value <IP_ADDRESS>/16

Comparing the CIDR of the user-input IPPool object with the cluster-wide one. If overlap happens, reject the create/update requests.
Related Issue:
harvester/harvester#5153
Test plan:

Install and enable the harvester-vm-dhcp-controller add-onapiVersion: harvesterhci.io/v1beta1
kind: Addon
metadata:
  labels:
    addon.harvesterhci.io/experimental: "true"
  namespace: harvester-system
  name: harvester-vm-dhcp-controller
spec:
  chart: harvester-vm-dhcp-controller
  enabled: true
  repo: https://charts.harvesterhci.io
  valuesContent: |
    image:
      repository: starbops/harvester-vm-dhcp-controller
      tag: fix-5153-head
    agent:
      image:
        repository: starbops/harvester-vm-dhcp-agent
        tag: fix-5153-head
    webhook:
      image:
        repository: starbops/harvester-vm-dhcp-webhook
        tag: fix-5153-head
  version: 0.3.0

Prepare a VM Network (NAD) named test-net
Create an IPPool object associated to the VM Network and overlapped with the cluster service CIDR using kubectlapiVersion: network.harvesterhci.io/v1alpha1
kind: IPPool
metadata:
  namespace: default
  name: test-net
spec:
  ipv4Config:
    serverIP: <IP_ADDRESS>
    cidr: <IP_ADDRESS>/16
    pool:
      start: <IP_ADDRESS>
      end: <IP_ADDRESS>
  networkName: default/test-net

The creation request should be rejected by the validating admission webhook:Error from server (InternalError): error when creating "STDIN": admission webhook "validator.harvester-system.harvester-vm-dhcp-controller-webhook" denied the request: Internal error occurred: could not create IPPool default/test-net because cidr <IP_ADDRESS>/16 overlaps cluster service cidr <IP_ADDRESS>/16

After discussion, I'll drop the runtime decision of service CIDR from the node's annotation because the footprint is too heavy, querying for every Node object whenever a new IPPool is created/updated. Instead, I will leave <IP_ADDRESS>/16 the default value for service CIDR and allow users to configure it via the webhook binary's argument (also configurable from chart value).
cc @w13915984028


Editable admin url

1. Why is this change necessary?
It isn't, but would be nice.
2. What does this change do, exactly?
Change static urls into generated routes.
3. Describe each step to reproduce the issue or behaviour.
Test with this plugin:
https://gist.github.com/hlohaus/986dd0618707d5a736568c5fd09002e6
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

Hi @hlohaus,
This behavior is not desired.
For security reasons it should not be possible to change the URL.
Sunny Regards
Pantrtxp


D435 Aligning Depth Frame to RGB Frame

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04.4

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
2.32.1

Language
C++

Segment
others

I want to align a depth frame (stream profile 76, Z16 1280x720@ 30Hz), to a rgb8 frame (RGB8 1280x720@ 30Hz).
I've seen on https://dev.intelrealsense.com/docs/projection-in-intel-realsense-sdk-20
that I will need to make calls to rs2_project_point_to_pixel(...), etc to achieve this.
However, the depth stream profile has Brown Conrady as its distortion model.
In the source code for rs2_deproject_pixel_to_point, I've noticed that RS2_DISTORTION_BROWN_CONRADY is not a handled case. Does rs2_deproject_pixel_to_point support that distortion model?
I am also interested in running frame alignment using processing blocks, as described in the Frame Alignment section here: https://dev.intelrealsense.com/docs/projection-in-intel-realsense-sdk-20
However, the frames I would like to align are not in rs2::frame format. Instead, I have access to the frame's raw data buffer, width, height, and bytes_per_pixel. How might I directly construct a rs2::frameset from this data to then use in the processing block?

If you are aligning depth to color with 2D frames (not a point cloud) then the process may be relatively straightforward.  The SDK's Align sample program offers a pre-made example of how to do so.
https://github.com/IntelRealSense/librealsense/tree/master/examples/align
In the code of that example, to define the stream configurations that you want, you would change these lines:
cfg.enable_stream(RS2_STREAM_DEPTH);
cfg.enable_stream(RS2_STREAM_COLOR);
To these lines:
cfg.enable_stream(RS2_STREAM_DEPTH, 1280, 720, RS2_FORMAT_Z16, 30);
cfg.enable_stream(RS2_STREAM_COLOR, 1280, 720, RS2_FORMAT_BGR8, 30);
The first two numbers in the bracket define the resolution (e.g '1280, 720' = 1280x720) and the final number at the end of the bracket sets the FPS (e.g '30' = 30 FPS).
For the D435 model though, bear in mind that the optimal depth resolution is 840x480, whilst for the D415 model the optimal depth resolution is 1280x720.

If however you want to map color texture onto a 3D point cloud, the SDK also has an example program called rs-pointcloud:
https://dev.intelrealsense.com/docs/rs-pointcloud
You can also map color texture to a 3D point cloud in the RealSense Viewer.  To do so:

Switch to '3D' mode to view camera information as a point cloud.

Activate both the Depth and RGB streams.  This makes drop-down menus appear at the top of the Viewer window.

Left-click on the drop-down menu called Texture Source and select the Color option to map the RGB onto the point cloud.

It sounds as though you require a custom solution using coding though, as you wish to use raw data that has not been adjusted ('rectified').  This could be difficult though.  The Y16 IR format provides unrectified data (the other stream formats are rectified by the Vision Processor D4 hardware inside the camera after the data is captured).
The IR sensor can also provide a color image, though on the D435 models it is monochrome, whilst the D415 model can provide a color image from the left IR sensor.  So I wonder if you could align an unrectified Y16 color image from the left IR sensor of a D415 with the depth image.  Even that would be complicated though, as described in the comment in a discussion linked to below (please read the comment beneath it too).
https://github.com/IntelRealSense/librealsense/issues/5062#issuecomment-542616997
This may not be a helpful method though if you need to use a D435 or the program needs to work with any model of 400 Series depth camera.
If you need to create your own frameset, the discussion in the link below may be useful guidance.
https://github.com/IntelRealSense/librealsense/issues/5847

Hi @MartyG-RealSense, thank you for the links and information.
However, I do not have access to the rs2::frames produced by the D435. I am not running the depth alignment on the same device that is connected to the realsense cameras.
My intended pipeline involves a jetson receiving frames from the D435, then streaming those frames to a processing server. The processing server has access to the raw data buffer (just a void *), and the width and height and bytes per pixel of the depth and color frames.
Is there a way I could also manually create rs2::Frames from that data?

The hardware setup that you are describing sounds similar to a RealSense paper that Intel recently published about creating an open-source ethernet network.  In that paper, they used Raspberry Pi boards to demonstrate the concept.  The camera was connected to the Pi and the Pi was connected by ethernet to a central computer.
https://dev.intelrealsense.com/docs/open-source-ethernet-networking-for-intel-realsense-depth-cameras

Hi @matthewha123    Do you still require assistance with this case please, or can it be closed?   Thanks!

Thanks very much for providing an update!


Adapt ingen-sdk for multiple dir mapping

Update proto to support multiple directory mapping and permission control.
Modify the directory variables to vector.

lgtm! we can merge it now.


usingdocker.md does not work on Windows

URL: https://docs.docker.com/engine/tutorials/usingdocker/
Problem description
When following the instructions in usingdocker.md, I get a Connection refused error.
To reproduce:

Start with a Windows 10 host, having VirtualBox 5.0.24 installed
Install Docker Tools (does not mention that it requires a reboot)
Follow the instructions in usingdocker.md
At you can now browse, get a connection refused error

I tried to connect to these ports:

localhost:5000
localhost:32768
<IP_ADDRESS>:32768

None of them worked. Also, docker-machine ip always returned Host does not exist, no matter what I passed as arguments. After rebooting Windows, connecting to <IP_ADDRESS>:32768 worked.
Since docker-machine ip still did not work, the only hint for the IP address came from the welcome screen.
Suggestions for a fix

Mention that a reboot may be necessary
Make docker-machine ip work

@londoncalling Is this something you can take a look at with your Windows machine? :)

@rillig did localhost:32768 work for you also? I can add a mention of a reboot required in the docs, for now.
@johndmulhausen I can't test this on my Windows box with Toolbox and Oracle VB, only with Docker for Windows (which works as documented). Re-installing Toolbox at this point would be a little disruptive and maybe not worth it.
@nathanleclaire, @ManoMarks, @friism Any thoughts on this? Do you have a Windows box set up w/Toolbox and VB to test?

I don't have a windows box set-up to test with only Toolbox on it.

@rillig for Windows 10, you can use Docker for Windows, which will solve these issues easily.
With regard to using Windows 10 with Toolbox, I could not reproduce the issue.
Closing this, please re-open if you continue to have problems with Docker for Windows.


Create endpoint size

It's only the start, but interested in your opinion on https://github.com/huggingface/datasets-server/pull/670/files#diff-0f066cc0774e19de939dd3c15c9b224c193fe83b71468cdb33315fce49a45ddfR27-R34, @huggingface/datasets

Codecov Report
Base: 87.92% // Head: 88.09% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (b7faf3e) compared to base (e31129e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   87.92%   88.09%   +0.17%
==========================================
  Files          48       19      -29
  Lines        1623     1302     -321
==========================================
- Hits         1427     1147     -280
+ Misses        196      155      -41

Flag
Coverage Δ

jobs_mongodb_migration
?

libs_libcommon
88.09% <100.00%> (?)

services_admin
?

services_api
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/libcommon/src/libcommon/config.py
81.31% <ø> (ø)

libs/libcommon/tests/test_processing_steps.py
100.00% <100.00%> (ø)

services/api/tests/conftest.py

services/admin/tests/fixtures/hub.py

services/admin/tests/conftest.py

services/api/src/api/routes/healthcheck.py

services/admin/tests/test_prometheus.py

services/admin/src/admin/routes/healthcheck.py

services/admin/src/admin/routes/pending_jobs.py

services/api/tests/routes/test_webhook.py

... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

See internal discussion at https://huggingface.slack.com/archives/C0311GZ7R6K/p1672052009820369

Blocked until https://github.com/huggingface/hffs/ is released publicly.

Should we use Dask (https://docs.dask.org/en/stable/generated/dask.dataframe.read_parquet.html) to read the parquet file, or is it better to directly use pyarrow?


Properly compute start location after leading trivia

The logic here was flipped, causing nodes at the beginning of a line to
display their start location at the end of the previous line.
Also adds tests to make sure we don't regress here.

cc: @ahoppen

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 9d53567903ba5f4d53978e798b7d785191720c84


Add directed graph for URIs

Add directed graph for URIs to track dependencies between resources identified with a URI.

What took you so long? 😉


"Features" section

Features define the basic functionality of the font.

This is a strange way to introduce the topic. What do you mean by "basic functionality" here? Better to describe what a feature is: a collection of lookups which specify information to the shaper about what substitutions and positioning adjustments need to be applied in particular circumstances.

The OpenType Layout feature model provides great flexibility to font developers because features do not have to be predefined by Microsoft Corporation. Instead, font developers can work with application developers to determine useful features for fonts, add such features to OpenType Layout fonts, and enable client applications to support such features.

This paragraph is somewhat misleading; was it written before the explosion of features in the features registry? While it is technically true that font developers could create arbitrary features outside the spec and then somehow convince layout engines to turn on processing for them, it's hardly common or best practice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b15ab9e-86c5-f6e0-0145-f9de77c60141
Version Independent ID: 0ebe3dec-cc24-b6a4-01b8-73bfdb79a71a
Content: Advanced typographic tables - OpenType Layout - Typography
Content Source: typographydocs/opentype/spec/ttochap1.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: PeterCon

Two separate issues here: (i) describing "features" in general, and (ii) the registry part.

The first issue, describing features, has been address in the changes made for #506.
Wrt the second issue, the quoted paragraph is a bit misleading, but not entirely so: even after the initial explosion of features in the late 1990s, there have been new features defined over time since then, driven by font vendors, layout format specs (e.g., CSS WG) or app vendors.
Changes for next version:

The OpenType Layout feature model provides great flexibility to font developers because features do not have to be predefined by Microsoft Corporation. Instead, font developers can work with application developers to determine useful features for fonts, add such features to OpenType Layout fonts, and enable client applications to support such features.flexibility for font developers, allowing them to choose capabilities to support in a font as appropriate for a given design or the requirements of their customers. The model also provides extensibility for future enhancements: on-going innovation can lead to features for new capabilities being defined over time.


Create custom logo

Every tool needs a cool logo

This should include a social media thumbnail for the project.


Add NatFlags flag to OutboundNatPolicySetting

This is to allow setting the ipv6 flag when creating outbound nat policy.

@vikas-bh Thanks Vikas.  Change LGTM though

@vikas-bh I can probably push a change right after to fix the things that should be constants, unless you want to. Do we want a new release of the shim with these changes? Is this for k8s?

@vikas-bh I can probably push a change right after to fix the things that should be constants, unless you want to. Do we want a new release of the shim with these changes? Is this for k8s?

This is for ipv6 support being added to the Windows CNI (it is under development). I say we hold on for a bit before creating a new release in case there are more things we find which need to be fixed in hcsshim.

@vikas-bh Sounds good!


build: just to definition

I broke jump to definition when adding undefinedToOptional

Codecov Report
Base: 99.34% // Head: 99.35% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (21084ed) compared to base (09e9a4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   99.34%   99.35%
=======================================
  Files          57       57
  Lines        3382     3397   +15
  Branches      811      811
=======================================
+ Hits         3360     3375   +15
  Misses         13       13
  Partials        9        9

Impacted Files
Coverage Δ

src/lib/util-types.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added note on I specifier of mrb_get_args()

I thought it was redundant, so I stopped writing the same content in src/class.c.

Thank you for the detailed note. But issues like #5703 were caused by the mistake of API design introduced by #3251. I should have noticed the issue beforehand. So I decided to remove I specifier altogether from mrb_get_args to reduce the risk. The I specifier behavior has been changed by #5530, so the compatibility was lost anyway.

I understand and agree with your decision.
I will also close this PR as it is no longer needed.


Modernize code examples in the direct manipulation section

The examples in the Direct Manipulation section look to have fallen victim to a rogue codemod; they are currently a mix of functional and class syntax that doesn't actually work.
In this PR I do too many things (sorry):

fix indentation (2 spaces everywhere)
remove styles that don't aid in the understanding of the concept of direct manipulation
convert everything from class to functional/hooks syntax
repair the opacity example by dimming the button onPressIn instead of onPress
use conventional ref forwarding to achieve the desired effect in the example where we show how to forward the effect of setNativeProps from a wrapper component to a child component

T74535407

Thanks for the catch and the cleanup! 🎉


can't change contract description

Description won't change for contracts via admin::Scout::Contracts
I'm trying to change the description for every single<PHONE_NUMBER> state contract.  I change it and hit submit and it won't change.  i've also tried hitting save and continue and it doesn't save.

What are you trying to change it to, and from what?

I tried based based on a pattern that you provided and had no trouble.
There are 393 of these; do you want me to bulk-update them in one go?

it's still not working for me.
i am trying to change them to MASTER IT SERVICES ITQ- CONTACT PROCUREMENT
BEFORE USING https://www.buildpgh.com/admin/contract/?search=4400004480#
I just tried with Collective Intelligence and it doesn't change
On Thu, Nov 19, 2015 at 12:25 PM, Ben Smithgall<EMAIL_ADDRESS>wrote:

I tried based based on a pattern that you provided and had no trouble.
There are 393 of these; do you want me to bulk-update them in one go?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/pittsburgh-purchasing-suite/issues/609#issuecomment-158127209
.

It updated for me just fine: https://www.buildpgh.com/admin/contract/?search=collective+intelligence
Are you using the individual page edit or editing by clicking on the description and changing it that way?

i'm on Admin::Scout::Contracts and searched the contract number.  I got all
of page one done but it won't update/save any on page 2.
On Thu, Nov 19, 2015 at 1:21 PM, Ben Smithgall<EMAIL_ADDRESS>wrote:

It updated for me just fine:
https://www.buildpgh.com/admin/contract/?search=collective+intelligence
Are you using the individual page edit or editing by clicking on the
description and changing it that way?
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/pittsburgh-purchasing-suite/issues/609#issuecomment-158145784
.

I can't reproduce this issue locally or in production, so I am not really sure what to do here. Riley if you want to just add that contact procurement before using, I can do that in bulk at the database level so you don't have to do 330 times.

ya I'd like that for this case. i found out that state contract is more
just like a PQ so i want to make sure we tell ppl to contact us so we can
explain before they buy with the vendor
On Thu, Nov 19, 2015 at 2:36 PM, Ben Smithgall<EMAIL_ADDRESS>wrote:

I can't reproduce this issue locally or in production, so I am not really
sure what to do here. Riley if you want to just add that contact
procurement before using, I can do that in bulk at the database level so
you don't have to do 330 times.
—
Reply to this email directly or view it on GitHub
https://github.com/codeforamerica/pittsburgh-purchasing-suite/issues/609#issuecomment-158170924
.

Ok, I will do that and then close this issue


duplicate header "Content-Length" in HTTP responses

In the Content Routes, When a folder route is specified and the file address is accessed, the HTTP header will return a duplicate "Content-Length" in HTTP responses.
When Test in the postman, it will cause errors: Parse Error: "The response has a duplicate "Content-Length" header"
If the author confirms that this is a bug, please fix it. Thank you very much.

Hi @sqlnew could you help me reproduce?  I just tried this using the Test project and only see a single instance of Content-Length when using content routes.

cURL:
C:\Users\joelc>curl -v http://localhost:8080/html/index.html
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 8080 (#0)
> GET /html/index.html HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/7.55.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: text/html
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Methods: OPTIONS, HEAD, GET, PUT, POST, DELETE
< Access-Control-Allow-Headers: *
< Accept: */*
< Accept-Language: en-US, en
< Accept-Charset: ISO-8859-1, utf-8
< Connection: close
< Host: http://localhost:8080
< Content-Length: 226
<

        <title>Hello from HttpServerLite!</title>

Hello!

Hello from HttpServerLite!

* Closing connection 0

Code:
Console.WriteLine("Initializing server");
_Server = new Webserver(_Hostname, _Port, false, null, null, DefaultRoute);
_Server.Settings.Headers.Host = "http://" + _Hostname + ":" + _Port;
_Server.Events.ServerStarted += ServerStarted;
_Server.Events.ServerStopped += ServerStopped;
_Server.Events.ServerDisposing += ServerDisposing;
_Server.Events.Logger = Console.WriteLine;
_Server.Routes.Content.Add("./html/", true);
_Server.Routes.Content.Add("./img/", true);
_Server.Settings.Debug.Responses = true;
_Server.Settings.Debug.Routing = true;
_Server.Start();

Hi, I have written a simple test program to indicate that there is a bug. Please download this test program. I have uploaded it to the file saving website.
https://fs.163.com/fs/display/?p=X-NETEASE-HUGE-ATTACHMENT&file=8T9cP5naUq1qY_8Yx_bxT7M9IqVIL2v5O_pRbTlG9q8aO14059R_cKssacjGkEmSx0ZuE9W-IyhuoqrHkjHb-Q&p=X-NETEASE-HUGE-ATTACHMENT&language=en

I don't see the same behavior as you.  When I build the HttpServerApp and run it, and then use cURL to GET the /getjson URL, I see:
C:\Users\joelc\Downloads\HttpServerApp\bin>curl -v http://localhost:7000/getjson
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 7000 (#0)
> GET /getjson HTTP/1.1
> Host: localhost:7000
> User-Agent: curl/7.55.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: text/plain;charset=utf-8
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Methods: OPTIONS, HEAD, GET, PUT, POST, DELETE
< Access-Control-Allow-Headers: *
< Accept: */*
< Accept-Language: en-US, en
< Accept-Charset: ISO-8859-1, utf-8
< Connection: close
< Host: http://localhost:7000
< Content-Length: 65
<
{
  "biaoshi": "01010101345",
  "username": "123testtestabc"
}* Closing connection 0

Notice there is only one Content-Length header.
I also do not see the behavior you are experiencing when I use the Test project.

It's not the "/getjson" path that has a problem, but this one http://localhost:7000/html/hello.html There is a problem with the path. When reading and accessing local files, two content - length.

After tracking the source code, it is found that the content length tag is added in two places:

This "content length" flag has been repeatedly set in the function sendinternalasync

Got it, thank you, was able to reproduce!  Fixing now.
C:\Users\joelc>curl -v http://localhost:7000/html/hello.html
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 7000 (#0)
> GET /html/hello.html HTTP/1.1
> Host: localhost:7000
> User-Agent: curl/7.55.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Type: text/html
< Content-Length: 262
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Methods: OPTIONS, HEAD, GET, PUT, POST, DELETE
< Access-Control-Allow-Headers: *
< Accept: */*
< Accept-Language: en-US, en
< Accept-Charset: ISO-8859-1, utf-8
< Connection: close
< Host: http://localhost:7000
< Content-Length: 262
<
<!DOCTYPE html>

    <meta charset="utf-8" />
    <title></title>

        Hello 你好！

* Closing connection 0

Please confirm this is fixed in v<IP_ADDRESS>: https://www.nuget.org/packages/HttpServerLite/<IP_ADDRESS>


Backdrop enabled Moment banners

What does this change?

Image background colours removed
Backdrop tiled image added to banner (image can be breakpoint dependent)
Story 'MomentTemplate/With Backdrop' to demonstrate

Why are we doing this change?
Moment template banner cleanup

[Trello] https://trello.com/c/i5kQWfNy/1564-momenttemplate-banner-sub-components-background-change-backcolour-to-transparent

Looks good! The images default to transparent once we remove the explicitly specified background, is that right? (Or probably rather: the images themselves are transparent, but we were putting an extra background behind them with the CSS, which you’ve now removed.)

Yes the images default to use their own transparency when we take away background colour. a background image can then be used to show through (at varying breakpoints should we choose to use it)


Add customizable callback option to TikiSdk.present() method

As a developer, I would like to have the option to create personalized flows for each TikiSdk.present() method call. This would allow me to react differently to user choices and provide a better user experience.
The TikiSdk.present() method does not provide any customizable options for the user experience flow. The only available options are the onAccept/onDecline callbacks, which are applied to all calls of the method and are best suitable for license and offer management.
To achieve this, I suggest adding an optional callback or return method to the TikiSdk.present() method. This would allow the developer to decide what to do next in each call of the method, making it especially useful when working with multiple offer prompts in different areas of the app.

Decided to not over complicate the SDK, given the developer has a variety of options to implement multi-state endings already.
Such as:

use a state variable (e.g. sharedPreferences or similar) set prior to calling present() and then retrieving this var in the onAccept/onDecline handlers.

wrap the present() function in an async method/thread and then inline await for it's completion.


[Question] Regarding batch size and fine-tuning methods

Question
Great work !

According to the paper, the batch size is set to 1152. How many graphics cards will be used during the training phase?
Is training full fine-tuning or efficient parameter fine-tuning?

Hi, thanks for your interest.

I double check the training script, and find that the batch size is not 1152. We use 192 V100 for training, and the batch size for each GPU is 2, so the total batch size is 384.
We do full fine-tuning.

Thanks for your reply.
I would like to ask two more questions:

Is CLIP fully fine-tuned or frozen?
What are the ${N}{SA}$ and ${N}{FA}$ in the paper?

Hi, thanks for your interest.

I double check the training script, and find that the batch size is not 1152. We use 192 V100 for training, and the batch size for each GPU is 2, so the total batch size is 384.
We do full fine-tuning.

Thanks for your reply.
I would like to ask two more questions:

Is CLIP fully fine-tuned or frozen?
What are the ${N}_{SA}$ and ${N}_{FA}$ in the paper?

CLIP is frozen.
$N_SA$ is set to 8 empirically as the preliminary experiment shows that the first 8 layers does not have a good attention map. All remaining layers use FlexAttention.


Add butter to Activating-the-DJI-FPV-Combo.md

The current version of the "Activating..." wiki page was created before butter and does not mention it at all. This is somewhat misleading for a new WTF.OS user, who just clicked wiki. As well as the warnings that look like user should avoid updating the firmware at all costs.
Also, personally, I had v01.02.0000, but the option to switch to "DJI Digital FPV System" only appeared after I upgraded the firmware to v01.03.0000. So, maybe "If you still don't have the option your Goggles have a very old factory firmware" is not entirely true, maybe this applies, say, to all versions that were originally sold together with the drone or something.
I'd like to suggest the following new version:
This guide will walk you through getting your brand new DJI Goggles (or the whole FPV Drone kit) activated. Before the [butter](https://github.com/fpv-wtf/butter) was introduced, it was important to do this without having to flash the dreaded 0015 firmware.
I highly recommend reading through the whole thing before jumping in so you don't rush ahead at any point and miss critical nuances.

Please bear in mind that since this uses official methods to activate your devices, it may stop working at any time. If this is the case, please contact us on [Discord](https://discord.gg/7w4KTyGpqF) or open an [Issue](https://github.com/fpv-wtf/butter/issues/new) so we can update the guide to reflect this.

Finally, keep in mind this will very likely void your warranty.

### Activating the Goggles

Start up your Goggles and navigate to Settings, About, switch to "DJI Digital FPV System" mode (aka DIY mode). This should be the last entry in menu, just below "Reset All". If you don't see this option, try the following:

   1. Pair your Goggles to your FPV Drone (without activating or going online, if you'd like to avoid downgrading with Butter later!), restart the Goggles.
   2. Take your PC offline and connect your Goggles to DJI FPV Assistant 2 on your PC and then check again if the option to switch modes showed up.
   3. Update the firmware to a new version using [DJI FPV Assistant 2](https://www.dji.com/ee/downloads/softwares/dji-assistant-2-dji-fpv-series) (you would be able to easily downgrade the firmware version with butter after the activation).
   4. If you're not based in the US you may need to also use a VPN to log into the FPV Assistant 2 while connected to a US server and then go offline completely before connecting the Goggles to Assistant.
   5. Download and flash [V01.02.0001](http://dankdronedownloader.com/DDD2/app/index.php?model=gl170&ver=01.02.0001&type=Other&Brand=DJI) to the Goggles with Dronehacks in FPV Drone mode. Then try all the above steps again.

After switching to the "DJI Digital FPV System" restart your Goggles.

Now that you're in the HD FPV System mode (a.k.a. DIY mode used with custom built quadcopters) connect your Goggles to your PC, activate them with DJI FPV Assistant 2 and upgrade/downgrade the firmware to V01.00.0606. Ignore the current version as shown in the header of the assistant window, re-flash the firmware in any case.

### Rooting the Goggles option 1, via butter (simple)
Download the pre-built package from https://github.com/fpv-wtf/butter#usage and follow the README.txt inside.

### Rooting the Goggles option 2, via margerine (more involved, obsolete)

**What you'll need**:
 - [nodejs](https://nodejs.org/) installed - for running margerine
 - [margerine](https://github.com/fpv-wtf/margerine/releases) the Goggles root exploit - for defeating forced upgrade mode on the Goggles
 - [adb](https://dl.google.com/android/repository/platform-tools-latest-windows.zip) Android Debug Bridge - for talking to the rooted Googles
 - [Dronehacks](https://drone-hacks.com/download) desktop client - for free drone firmware flashing
 - [V01.02.0020 FPV Drone firmware](http://dankdronedownloader.com/DDD2/app/index.php?model=wm170&ver=01.02.0020&type=Aircraft&Brand=DJI) from Dank Drone Downloader - for tricking Fly App activation logic
 - (optionally) [V01.02.0000 FPV Drone firmware](http://dankdronedownloader.com/DDD2/app/index.php?model=wm170&ver=01.02.0000&Brand=DJI) from Dank Drone Downloader - for downgrading to an exploitable firmware on the drone after all is said and done
 - Minimal ability with the command line (navigating to downloaded folders and running commands as instructed)
 - Patience!

In order to be able to get rid of the forced upgrade state in your Goggles later, we'll need to root the Goggles with margerine while in DIY mode. Open up the Command Prompt (or Powershell) and navigate to wherever you downloaded and extracted margerine. To get everything ready run:

    npm install
Now power up your Goggles, connect them via USB and run:

    node margerine.js unlock
If you get the error **waving wand, result e0** restart your Goggles and try again. If that doesn't help check out the Troubleshooting tips in the margerine [README](https://github.com/fpv-wtf/margerine).

Now you should see the following in the command output:

    device should be unlocked, try 'adb devices'
Navigate to the folder where you downloaded and extracted adb and run:

    adb shell
You should see the following output:

    [sec_debug_state:202] secure debug value 0x1
    root@pigeon_wm170_gls:/ #
Type `exit` to close the debug connection for now.
### Activating the Drone
Use the Dronehacks client you downloaded to flash the V01.02.0020 firmware you downloaded onto the drone. No license or login required. Don't worry, 0020 is actually older than the notorious 0015 and while it does prevent you from hacking the drone, it can later be downgraded to vulnerable versions.

**Make sure to read the whole proceeding paragraph before proceeding or you'll get your Goggles in a bad state.**

Now, connect your Goggles (with the Drone and RC powered up and bound) to the [DJI Fly](https://www.dji.com/downloads/djiapp/dji-fly) app on your phone and activate the drone. **This is very important** - disconnect your Goggles from your phone **as soon as the drone is done activating** and the Goggles 0015 firmware starts downloading (don't worry, it's safe even if it's managed to already start uploading the firmware to the Goggles). Your Goggles will now be in a forced upgrade state, but don't worry, we can fix this, since we rooted with margerine earlier.
### Fixing the Goggles forced upgrade state
Connect your Goggles back up to your PC and go back to the folder where you ran adb previously. Now run:

    adb shell
    rm /cache/force_upgrade
    setprop dji.prop.enforce_upgrade 0
    reboot
Congrats! The forced upgrade state should be gone, all your devices activated and everything in a hackable state. You'll get a warning of firmware version mismatch on the Goggles and Drone, but this can be dismissed. Such is the price of freedom. As far as we know, this shouldn't cause any actual problems with flight.

If you want to purchase a Dronehacks license to remove some limits on your Drone, then now is a good time to use the free version to downgrade your Drone back down to V01.02.0000. Dronehacks Pro license will also allow you to root your drone for low level access if you so wish.
### Have fun and fly responsibly
With great power comes great responsibility.

Please consider [donating](https://www.buymeacoffee.com/fpv.wtf) if you found this guide useful. BTC and ETC addresses also available in the margerine [README](https://github.com/fpv-wtf/margerine#support-the-effort).

Terribly sorry for neglecting this for so long. I appreciate the effort you put into this.
In fact I nuked that wiki page altogether since all of that is completely unnecessary with butter. The wtfos README has also been updated accordingly and I added a section on activating to the The-V2-Goggles-Firmware-Situation wiki page in case someone is in doubt.
I don't see any reason anymore to make users go through all that.
When it pertains to upgrading to newer version after the downgrade, I'm on the final stretch of releasing butter packages that will downgrade, root and upgrade all in one shot, so that will also be significantly simplified.


Not Working in IE 11

I have implemented in my react project, and it is working fine in all browsers except IE. Can u help me out to make it work in react project.

The breakdown is we are using a packer tool (http://dean.edwards.name/packer/) to encode our JavaScript to make it much smaller. IE 11 has some issue with that which makes it VERY hard to debug since this is only an encoded syntax error. Since all the code is a string this makes debugging even harder.
The short term solution. We are debating shipping the unpacked version for es6 library output. This would alleviate the issue but also add 120 kb in size.
The long term solution would be to fix the error and determine and stable solution for all browsers. We are also discussing internally the benefits of compression vs packing with/without gzip. Since we encode the library, natural web gzip compression is less efficient since the algorithm looks for similar patterns. With the packed version already being encoded there aren't many similar patterns so gzip compression doesn't work as well. If we gzip the unpacked version of the library we are very similar in size to the gzip version of the packed library.

I may probably be mistaken by your issue, but I have this working on my IE11-specific project. I used Polyfills configuration to compile the create-react-app (TypeScript) to be IE11-compatible from these instructions:

https://create-react-app.dev/docs/supported-browsers-features/
https://github.com/facebook/create-react-app/blob/main/packages/react-app-polyfill/README.md

Unfortunately, there are no longer any plans to support IE11.
If you are currently a paying customer, we would be open for discussion about this matter.
However, check out the ZingChart library, which should support IE11.


In application sign in methods Request path authentication options comes as enabled eventhough select start with default configs

How to reproduce:

Access console and register a traditional web application
Go to sign in methods
Select add totp as a second factor
Enable Request path authentication basic oauth and oauth bearer
Update
Click revert to default
Then click on start with default configurations
Check the request path authentication section

Even though I started with default configs the 2 options of request path authentication comes as enabled.
https://user-images.githubusercontent.com/31848014/162885401-df1a8e11-bc4d-4dc8-b580-001f139a5081.mp4

Env
IS 5.12.0 alpha 19

IMO, Start with Default is intended to be for the Authentication Sequence, we should move Request Path Authenticators to somewhere else.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Failed to copy RAT smali files

Hi,
Script fails because payload/smali/com/metasploit/stage/MainBroadcastReceiver.smali file is not present.
payload/smali/com/metasploit/stage directory has only 1 file - MainActivity.smali
[*] Running backdoor-apk.sh v0.1.4 on Mon Oct 17 14:47:18 IST 2016
[+] Android payload options:
1) meterpreter/reverse_http   4) shell/reverse_http
2) meterpreter/reverse_https  5) shell/reverse_https
3) meterpreter/reverse_tcp    6) shell/reverse_tcp
[?] Please select an Android payload option: 2
[?] Please enter an LHOST value: <IP_ADDRESS>
[?] Please enter an LPORT value: 443
[*] Generating RAT APK file...done.
[+] Using payload: android/meterpreter/reverse_https
[+] Handle the reverse connection at: <IP_ADDRESS>:443
[*] Decompiling RAT APK file...done.
[*] Decompiling original APK file...done.
[*] Merging permissions of original and payload projects...done.
[*] Running proguard on RAT APK file...done.
[*] Decompiling obfuscated RAT APK file...done.
[*] Creating new directories in original project for RAT smali files...done.
[*] Copying RAT smali files to new directories in original project...done.
[!] Failed to copy RAT smali files

@gaurav9991 Thanks for reporting the issue. Is this Metasploit on Kali Linux? If not, can you describe your environment and how you are obtaining Metasploit?

Hi @dana-at-cp,
I fixed the issue by updating Metasploit by msfupdate command. Yes, I was using Kali Linux.

@gaurav9991 Great! Glad you got it sorted.


Test Failure: DataScience - VSCode Notebook - (Trust): Test notebook with output

Prompted to trust an untrusted notebook and trusted:
Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/vscode-jupyter/vscode-jupyter/out/test/datascience/notebook/notebookTrust.vscode.test.js)

Dup of https://github.com/microsoft/vscode-jupyter/issues/393


Removes unused parameter

Changes

Removes unused parameter from get_secondary_nav_items function.

Review

@richaagarwal
@kave
@kurtw

Seems fine to remove, but I would defer to @kave since he introduced it in
this commit:
https://github.com/cfpb/cfgov-refresh/commit/bcff9984e2547dfad2012269a0f40802163770b2
On Tue, May 3, 2016 at 11:58 AM, Ans<EMAIL_ADDRESS>wrote:

Changes

Removes unused parameter from get_secondary_nav_items function.

Review

@richaagarwal https://github.com/richaagarwal
@kave https://github.com/kave
@kurtw https://github.com/kurtw

You can view, comment on, or merge this pull request online at:
https://github.com/cfpb/cfgov-refresh/pull/2030
Commit Summary

Removes unused parameter

File Changes

M cfgov/v1/util/util.py
https://github.com/cfpb/cfgov-refresh/pull/2030/files#diff-0 (2)

Patch Links:

https://github.com/cfpb/cfgov-refresh/pull/2030.patch
https://github.com/cfpb/cfgov-refresh/pull/2030.diff

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cfpb/cfgov-refresh/pull/2030

This can be removed. This line does the job of the parameter in question.


Fix: lint

Simplifies lint task using glob package, fixes #30. Also fixes existing lint errors.

:+1:

Coverage remained the same at 93.617% when pulling b6e4c6120657ba4c845b3e4c11e9ca5304422b83 on feature/fix-lint into e105e1f1f8bb10fb0c4026f0aad45a5eb5272ae9 on master.


Docs: Adapt end user manual and Interface Documentation

As puris administrator ,
I want to have a documentation of the application ,
so that i know how train employees and how to operate the application.
Hints / Details

Got feedback from system architect to adapt the following:

visual support for end user manual
in interface docu link to syntax of API in arc42

Outcome / Acceptance Criteria

Outcome

...

Acceptance Criteria

end user manual feedback incorporated (add images, provide further information)
interface docu links to ar42 runtime view for item stock api

Out of Scope

...

Handled in #241


#2316 can set default CookieJar for Client

Hey.
Thank you for this PR.
Could you elaborate why you would like to do this?

Closing due inactivity. Feel free to comment on this PR if you change your mind.


Bug: The number of stars on Git is not updated on the website

What happened?
I want to solve this issue
Add screenshots

What browsers are you seeing the problem on?
Brave
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Hey, @partha120804
How are you planning to solve this issue?

@Sanchitbajaj02
I will use github api to fetch the current number of stars, everytime the page loads

@Sanchitbajaj02
I will use github api to fetch the current number of stars, everytime the page loads

If you have noticed, I have currently implemented that

Ok


Cache Favicon.ico [200 USDC Reward!]

🐛 Bug Bounty: Tree Shaking Optimization Needed! 🛠
Reward: 🏆 200 USDC 🏆
We are thrilled to announce a special bug bounty for proficient third-party developers! This is an opportunity to showcase your expertise, make a significant impact, and earn a substantial reward.
Issue Description 📄
Cache Favicon.ico
Current Behavior ❌
Favicon.ico is not cached locally, and it sometimes takes a long time to retrieve
Expected Behavior 💡
This should just be on a local cache with long expiry time.
Requirements for the Bounty 🏁
Submit a pull request with a verified solution to optimize tree shaking.
Demonstrate a measurable decrease in the bundle size as a result of your optimization.
Ensure the fix does not introduce any new bugs or vulnerabilities.
Adhere to our project's coding style and contribution guidelines.
Your solution will undergo a thorough review by our team, and the bounty will be awarded upon approval.
How to Claim Your Bounty 💰
Fork our repository.
Create a new branch dedicated to your optimization fix.
Submit a pull request to our main branch with comprehensive details of your optimization strategy and evidence of the reduced bundle size.
Upon review and approval, the 200 USDC will be transferred to your wallet.
Please Note: All bounty claimants must undergo a KYC (Know Your Customer) process with our finance team to receive the reward. This is a mandatory step to ensure compliance with financial regulations.
We eagerly await your innovative solutions and thank you for contributing to the efficiency and performance of our project!

I want to start working on this issue please assign it to me.
Thank You

@ramishj No need to assign. We pay the bounty to the first person who merges a PR to fix the problem. Thanks!

@MaxMillington why im getting this error while building locally

someone tell me how to fix this while build

@CryptoAssassin1 @kamal-sutra

 someone tell me how to fix this while build

@ramishj trying yarn clean and then yarn && yarn build

@ramishj trying yarn clean and then yarn && yarn build

nothing happens

Thank you @Myestery


Throttler API and Implementation

Issue #327

Coverage decreased (-0.4%) to 66.85% when pulling 43e6f19f4ed4b90d876cb44bdad27f47e63af9a6 on tamer-eldeeb:throttler into 37a6a24f98b4dfd02353adee8ff17d54cf416864 on uber:master.

Changes Unknown when pulling 3b258b35ac9b1f5b9d74acae981598057c145cde on tamer-eldeeb:throttler into ** on uber:master**.

Closing down this old PR since we're unlikely to merge it as-is but may still look at it for reference later.


"Switch Application By Name" is very slow if exact_match=false is used

Zoomba Version 2.8.0
If keyword "Switch Application By Name" is used in combination with exact_match=false it is much slower than using it with exact_match=true (by factor 2-4 if no other application is running but by factor 10-15 if some other applications are running).
You can test it by the follwing suite:
*** Settings ***
Library   Zoomba.DesktopLibrary

Suite Setup      Suite Initialization
Suite Teardown   Suite Finalization

*** Variables ***
${REMOTE_URL}   http://localhost:4723
${APP}          Microsoft.WindowsCalculator_8wekyb3d8bbwe!App

*** Test Cases ***
AppChange
    # ${calculator_handle}=  Open Application    ${REMOTE_URL}     platformName=Windows    deviceName=Windows   app=${APP}
    ${calculator_handle}=  Switch Application By Name  ${REMOTE_URL}  window_name=Rechner  exact_match=true  platformName=Windows    deviceName=Windows   app=${APP}
    Wait For And Click Element  accessibility_id=clearEntryButton
    Wait For And Click Element  accessibility_id=num1Button
    Wait Until Element Contains  accessibility_id=CalculatorResults      1

    # Switching to Word but don't know the name of the currently open word document (means I have to use exact_match=false)
    Switch Application By Name  ${REMOTE_URL}  window_name=Word  exact_match=false  platformName=Windows    deviceName=Windows
    Send Keys  Hello World 1  \ue007

    Switch Application  ${calculator_handle}
    Wait For And Click Element  accessibility_id=num2Button
    Wait Until Element Contains  accessibility_id=CalculatorResults      2

    # Switching to Word but using the exact document name
    Switch Application By Name  ${REMOTE_URL}  window_name=Dokument1 - Word  exact_match=true  platformName=Windows    deviceName=Windows
    Send Keys  Hello World 2  \ue007

    Switch Application By Name  ${REMOTE_URL}  window_name=Rech  exact_match=false
    Wait For And Click Element  accessibility_id=num3Button
    Wait Until Element Contains  accessibility_id=CalculatorResults      3

    # Switching to Word againg using exact_match=false to see whether there is some caching
    Switch Application By Name  ${REMOTE_URL}  window_name=Word  exact_match=false
    Send Keys  Hello World 3  \ue007

*** Keywords ***
Suite Initialization
    Driver Setup

Suite Finalization
    Driver Teardown

This results in the follwing log

What can be done to improve the performance?

I am facing similar issues (tested also with the newest version)...

When we know the exact name of the window we are able to do a find like so:
window = desktop_session.find_element_by_name(window_name)`

Which is pretty quick but when we attempt a  search for an approximate name we have to use xpath:
window_xpath = '//Window[contains(@Name, "' + window_name + '")]'
window = desktop_session.find_element_by_xpath(window_xpath)

Xpath in WinAppDriver is slow and in this case effected by how many other programs your desktop has running. I attempted to test a few more xpath possibilities to see if what I was doing was ill-performant but I couldn't get a noticeable difference in execution speed.
This all ends up on the WInAppDriver side which is closed source. They promise that its not dead but we have yet to hear too much from them on it.
Open to any suggestions you may have on how to improve this though!

@frankstriegel @simonmeggle
See https://github.com/Accruent/robotframework-zoomba/pull/201 for a new keyword to try. This won't make the partial name search or xpath any faster but perhaps there is an id or class you could use that would be much faster.
Switch Application By Locator

Thanks Brandon! 👍


fixed state root loaded to be 0 when running fresh node

Motivation
State root needs to be initialized when running fresh node
Changes
stateRoot is not inited using IntermediateRoot when loading
Test Plan
added UT to test processor loading with root hash != 0
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge


auto loot problem

i using this mod a week ago, don't have trouble in first 24 hours,
after that, this mod make fallout 4 crashing when loot something
( i don't know what kind item who make it crash ),
so i update this mod about yesterday, it still crash if auto loot to player inventory,
after i move auto loot to settlement, the crash is gone, but it bring new problem
some time, after load area(after loading) the "auto steal"(auto pick owned item) is active
(but in the auto loot config / option writes auto steal do not active)
and yes, every body attack my player because he steal something
please fix this , sorry for my bad English

after that, this mod make fallout 4 crashing when loot something

If you have Automatron installed, you will experience more crashes with or without mods.
Some crashes are due to the use of UI mods that have not been updated to support Automatron. You should completely uninstall any UI mods, including deleting the interface folder in your Fallout 4\Data directory.
All crashes are unrelated to Auto Loot.

some time, after load area(after loading) the "auto steal"(auto pick owned item) is active

There are two ways to activate Auto Steal:

Use the toggle in the Advanced Setup.
Type the following command in the in-game console: set dubhAutoLootStolenFilter to 0

Those are the only two ways to activate Auto Steal. There is no other way to activate Auto Steal.
If there is a bug in the game that is causing global variables to reset to zero, I can do nothing about that.
However, if you believe that Auto Steal has been activated in error:

Using the in-game console, type sglv to show all global variables.
If the value of dubhAutoLootStolenFilter is 0, then Auto Steal was activated.
To disable Auto Steal, type set dubhAutoLootStolenFilter to 1 or toggle the setting in the Advanced Setup menu.

thanks for quick respond.
yes i am using automatron dlc
maybe i just need to deactivate automatron until next patch is come,
anyway, what software do you use for make this mod, it seem more advance than fo4edit
i like to try make player control by companion ai(travel and combat),
and using VANS as travel destination.
once again, thanks for your reply,
and sorry for unrelated question

I am having a crashing issue, as well, and it began prior to installing Automatron.  I have set the range of auto looting very low to avoid overloading my system.  Still, the game locks up from time to time while auto loot is active.  I have a theory....
I THINK this may be happening when I approach a body that contains a legendary item.  With auto loot off, we get the screen that pops up when looting, showing the legendary item (ta-da!) and asking you to accept it.  I believe this is somehow crashing auto loot.  Perhaps auto loot is trying to accept it too quickly for my system?

set inventory to settlement is slove crash problem as well
but i think if we can filter what item that should send to settlement like junk or misc item will be really good
love this mod so far

i don't know its bug or not,

in dead body all of item is taken by auto loot, but equipped weapon not
sometime the auto loot, loot very fast, especially after entering a room , but some time i don't know auto loot work or not, because raider still wearing his armor after 2 minutes he/she died

@Tellerd:

I am having a crashing issue, as well, and it began prior to installing Automatron.

There is no way for Auto Loot to cause crashes. It just isn't possible. I'm sorry that you're experiencing crashes, but Auto Loot doesn't do anything hacky or exotic to work. Auto Loot uses bog standard functions used elsewhere by Bethesda. It's more likely that you installed another mod without all of its assets. Missing meshes or textures, and outdated UI mods, will crash the game, for example.
@prayoga-masagi:

what software do you use for make this mod, it seem more advance than fo4edit

FO4Edit for the plugin, and Orvid's Caprica for compiling the scripts.

i think if we can filter what item that should send to settlement like junk or misc item will be really good

I thought about it, but unfortunately, this is too much work.
Creating terminal menus is a pain. To show feedback when you select a menu item, you have to create two terminal menu items for every item. I had to create 60 menu items to show 30 settlements, and I had to break those 60 menu items across 4 pages because the terminal menu lags when there are too many items per page. To allow you to direct specific item categories to specific settlements, I'd have to create 540 more menu items to cover the 9 modules, or 544 menu items total, including the player as a destination. No thanks.
If we had a better menu system like SkyUI for configuring mods while in the game, I'd do it, but the terminal design is just terrible.

in dead body all of item is taken by auto loot, but equipped weapon not

If Filter Mode is enabled, only items that have a module will be auto looted. There are no modules for armor and weapons.
If Filter Mode is disabled and the Bodies module is active, all items should be auto looted from bodies.

some time i don't know auto loot work or not, because raider still wearing his armor after 2 minutes he/she died

If there are a lot of bodies and/or you have a lot of modules active, it will take time to iterate through the loot array.

I have seen the same crashing with AutoLoot running.  However, I do not believe it is directly related to the mod itself.  With FO4 up and running will all of my mods (with and without Autoloot) I have noticed a steady climb in memory usage.  This tells me there is a memory leak that isn't being recovered.  After a couple of hours (with the help of Autoloot) I will routinely experience a CTD.
This did not happen before, I just got freezes.  Now however, i can still enjoy my game with Autoloot quietly sending my gains to Sanctuary.  I have also not had the Auto Steal mysteriously turn on since my first encounter with it.
Now the only suggestion I have is that there are many quest items that are set to auto trigger when you touch an item that end up getting broken because the mod works so well.  I am trying to get one of my quests with a holotape re-kickstarted.  Shouldn't be to hard.
I did encounter one NPC body type that Autoloot doesn't work on.  Triggerman from Good neighbor.  When you have to clear out the warehouses, you have a good number of bodies.  Not a big deal, just an observation for the sake of completion.

Now the only suggestion I have is that there are many quest items that are set to auto trigger when you touch an item that end up getting broken because the mod works so well.

You can drop items that have a script attached to them, turn off Auto Loot, and then pick them up manually.
Or you can just remove those items from the formlists in the plugin. There aren't too many.
Valuables:

BottleCapMinePlacedCaps "Caps" [ACTI:002472ED]
loot_capsStash_tin "Caps Stash" [ACTI:0003000C]
MoneyShotPlacedCaps "Caps" [ACTI:0020ABE3]
MS11GuidanceChip "NX-42 Guidance Chip" [MISC:0004E3A2]

Junk 1:

BobbyPinBox "Bobby Pin Box" [MISC:0008FCA8]

Junk 2:

PlayerHouse_Lamp01Off "Pre-War Lamp" [MISC:00078309]
PowerRelayCoil "Power Relay Coil" [MISC:00091FDE]
VaultSuitPackage01 "Vault 111 Jumpsuit" [MISC:0008C1AE]
VaultSuitPackage114 "Vault 114 Jumpsuit" [MISC:00195385]

I am trying to get one of my quests with a holotape re-kickstarted.

There are no holotapes in the formlists, so if you auto looted any holotapes, they were on a body or in a container.
Filter Mode exists so that you can control which items are auto looted from bodies and containers.

I did encounter one NPC body type that Autoloot doesn't work on. Triggerman from Good neighbor. When you have to clear out the warehouses, you have a good number of bodies.

I wouldn't know why. Triggermen use the Human race which has the ActorTypeHuman keyword, so Auto Loot should loot those bodies. There are no fixes to be made that I can make. Fallout 4 has bugs. That's all I can say.

fireundubh thanks again for reply,
i have a question, i know making terminal menu is annoying,
but, can you type the console command (with explain)
i like to loot ammo to player and anything else to sanctuary

fireundubh i am thank you very much for reply and everything

i have a question, i know making terminal menu is annoying,
but, can you type the console command (with explain)
i like to loot ammo to player and anything else to sanctuary

I realized that I didn't need to add hundreds of menu items, so I implemented a solution in the latest update.
You can now:

Choose a settlement as the default container in Container Setup.
Then, override the default container with the player for any module in Container Setup>Preferences.

Please redownload and reinstall the mod, overwriting all files.
dubhAutoLootEffectScript.pex is no longer needed as well because none of the modules share a script anymore.
I'm closing this thread. Please create a new issue if you have any other feedback.


snapshot revisited

Hi,
as of the release of nw 0.12.0, the snapshot functionality is stable, supports closure and runs like a charm. No comparison to the old 0.11.x and below.
As stated in https://github.com/mllrsohn/node-webkit-builder/issues/162, the thought was put away. But given the new development, it would be great to implement that as I use it for every build and I know a lot of others who make great use of it, given that it's dead stable and allows for secure deployment of the source code

+1

+1

is this supported now? @adam-lynch this is a pretty standard feature by now

I know little about this. I can't seem to find new docs on it (it doesn't exist in the nwjs.io docs?). Is there any?

@chino23 let me know of you want to get this discussion going again. I don't know much about snapshots but open to learn more.


flutter web support?

Does anyone have any suggestions for web support?

same feature request needed here!


[Feature Request] Option to display more precise temperatures

Currently the once an hour notification displays the temperature to a single decimal precision, this is great. But I'd like the current temperature view to display the same if possible, as it currently rounds off all decimals. I'd like to see if it's -0.3 or +0.1.

It currently displays fractional values on the main temperature view, rounded values in the per-hour bar and fractionals in the notifications. The latter two are unchanged and the first is precisely what I wanted.
Fractionals in the per-hour bar would probably be quite cluttered, and tapping them brings that timeslot into the main view for more precise info, so this seems perfect to me


Scheduling decisions ignore worker network exhaustion

Short
Scheduler chooses worker with best available performance metrics, while ignoring network metrics. Further service deployment blocks and ignores other available workers, if worker is out of addresses for service to deploy.
Proposal
When deploying multiple instances of a service (70 upwards) to a cluster with multiple workers with different ressources, the scheduler will always select the most ressource available worker at time of deployment, no matter how many services are already planned to be deployed on that worker.
Currently workers only support a limited amount of IP addresses. Once the limit is reached, the cluster-scheduler will keep assigning services to that worker, despite the worker not having any more available addresses - making deployment impossible.
Solution
Make cluster-scheduler respect the available namespace addresses of worker node in scheduling.
Status
Looking for feedback
Checklist

[ ] Discussed
[ ] Solved
[ ] Tested

@smnzlnsk If we implement https://github.com/oakestra/oakestra-net/issues/155, there is no need for this any longer, right? Ideally, we should not be limited by the network but by the resources.


Allow selecting images to send for processing by OAM Server

If displaying original OIN images and no tile service is available, the authenticated user should be able to select those images of interest and submit for processing by the OAM Server. The produced TMS will then be added to the OAM catalog for display and use through the OAM browser.
This workflow should be defined by specific API functions and coordinated with OAM Server developers.

All uploaded imagery through OAM gets a TMS now through the dynamic tiler. Need to reopen a new ticket with new framing if we want to consider ways to create custom mosaics in the future.


UPower always montiors the battery if the native-path doesn't exist

I have enabled the module and specifically enabled hide-if-empty = true; on NixOS. I specified a directory that wasn't always on-- only when connected to the device via  bluetooth, but it seems for UPower if it detects that it's empty, it switches to my laptop's battery no matter what.

The same happen to me. If you enable the tooltip, you can probably see that even though you defined a specific device via native-path the upower module shows all connected devices anyway.
My configuration (for my Bose QC35 headset)
	"upower#boseqc35": {
		"native-path": "/org/bluez/hci0/dev_04_52_C7_7E_67_82",
		"show-icon": false,
		"icon-size": 20,
		"hide-if-empty": true,
		"format": " {percentage}",
		"format-alt": " {percentage}",
		"tooltip": true,
		"tooltip-spacing": 5,
		"on-click": false
	},

The way it is shown in waybar (with the correct battery level value of the correct tracked device)

The tooltip I see when I mouse-over it.

Since I configured the module to only track the headset, I would not expect to see my mouse battery level listed too. Am I wrong?
I think having multiple device listed there, may trick the module to consider the device still connected even when I turn off my headset. Does something similar happen to you as well?

By giving a closer look at the documentation hide-if-empty is described as

Defines visibility of the module if no devices can be found.

Hence, if at least one valid device is connected, the module is shown in waybar, even when the tracked devices is disconnected but another valid device is still connected.
https://github.com/Alexays/Waybar/blob/2c927de4c624d0c560f73ad78b4abc85fb703562/src/modules/upower/upower.cpp#L341-L342
devices.size() == 0 sounds to me like if there's at least one valid-connected device.
Here the definition of valid device:
https://github.com/Alexays/Waybar/blob/2c927de4c624d0c560f73ad78b4abc85fb703562/src/modules/upower/upower.cpp#L322-L326

Closing in favor of your issue since I don't use Waybar right now.


Fix a wrong fix to ord

Due to python3's incompatible change, data buffer is represented as a byte rather than str .
The RFB code depends on the assumption that they are str, which no longer works.
The code uses ord to convert a single-char string into an int.
There are two typical usages of ord in the code:

buffer string of length > 1 --(index access)--> string of length 1 --(ord)--> int
string of length 1 --(ord)--> int

However in python3, this usage morphs into

byte of length > 1, --(index access)--> int --(ord)--> Error
byte of length 1 --(ord)--> int

The previous wrong fix #164 only considers the first case, and replace ord with an identity that returns an int.
However this fix causes an error (#170 #172).
I reimplemented ord simply as a cast : When the input is an int, returns it, otherwise apply the normal ord.

@guicho271828 thanks for debugging and putting a fix together


jwplayer integration

Hi,
is there any chance of integrating wavesurfer (along with videojs-wavesurfer plugin) with jwplayer?
Thanks,
Laura

Hi,
I'm interested in JwPlayer integration too.
I'd like to use wavesurfer to show the waveform referred to the audio track of a video played in JWPlayer.
Is there a way to synchronize audio track and video?
Thanks a lot,
Asile

@Asile984 you can use a video element instead of audio to achieve that.


Illustrator Test Scripts added

Hi @sigadamvenkata, I have added Illustrator Test Scripts.
Local Test Run Results:

I will be raising the new PR with changes as discussed. Hence closing this.


Gas overlay urgently needs optimization

Due to the lack of overlay bubbling and poorly performant gas netcode, the current gas overlay absolutely kills the client when there's a big fire or a lot of gas atmos changes.

Notice the 5000+ Kb download and the big lag spikes.

@Zumorica I'll take this if you want, I assume we're just going to chunk the data and send the relevant chunks as they update.

@Zumorica I'll take this if you want, I assume we're just going to chunk the data and send the relevant chunks as they update.

Indeed, this is pretty much what needs to be done

Fixed by #1678


Don't rename device, just update description

Why
This change restructures how devices are renamed and updated. This is done to help be able to easily identify which devices were created by Pulsemeeter and which ones may be user created.
I actually discovered this limitation when trying to make my own sink that uses a null module, but I was unable to load the null module as a sink in Pulsemeeter. This doesn't fixing not being able to load external null modules, but it's a step that helps make it easier to maintain and I think allows for easier managing of devices.
How it works
Previously, the config file had one name field that was used for the name and the description of the device. Now, each device has both a name and a desc field. When a user does any type of renaming, the device is referenced by the name (which now never changes) and the description property is updated.
For backwards compatibility, if a user is using an old config that doesn't have a desc field for the device, it will default to the name field, and then also create the the desc field as necessary.
I didn't see a contributing guideline, so please let me know if there's anything else I should include.

Identified a bug actally, closing this temporarily until I resolve

Resolved the bug, which was related not updating all the references to name. Specifically, in the application output section

Thanks for the PR, I was planning on doing this at some point but I've been busy for the last couple of days, I'll need to run some tests but I think its good to go