wildcards in test -n doesnt work with ZSH

Problem
Running a command like this mbed test -n tests-api-* should run all tests in the TESTS/API/* folder, but under ZSH this doesnt work. Instead ZSH barfs like this zsh: no matches found: tests-api-*.
Solution
unknown, look into using wild cards in zsh
importance
low, just logging bug for future reference

@BlackstoneEngineering how would you like to proceed then?

The documentation now contains information about shells that are exploding * into file names. https://github.com/ARMmbed/mbed-cli#limiting-the-test-scope


Determine if the task is running in Build or Release definition

What is the suggested way to determine in the task if it is running in a Build definition or Release definition?

You could look for the presence of this environment variable that only has a value in Release: Release.ReleaseId
var releaseId = tl.getVariable('Release.ReleaseId');
if (!releaseId) {
}

The build and release variables are documented here:
Build Variables
Release Variables

create an issue on vsts-task-lib repo and we will add a function

There is a variable system.hostType


mpg123 missing - add to requirements or setup

Mpg123 subprocess call failed for me since I didn't have the binary for it. Automatic download of it should be added to setup.

It's been listed as the requirement here: https://github.com/Melissa-AI/Melissa-Core/wiki/Installation.


Add Karl to the service manual team page

What
Add Karl to service manual team page.
Why
So our users know they have joined.
Done when

[x] Update page via PR
[x] Ask for review
[ ] Publish

@karlgoldstraw When you do this, would you mind making sure that the dashes are all en-dashes, please? We've got a mix of dashes.

Work done, ready for release.


Not loading paths

I don't know if it has something to do with my device specifically (it might) but whenever I load a path, it will not show up, I tried uninstalling and reinstalling and it just won't work. I am very stressed about it; can somebody help me to try and find what I'm doing wrong?

https://streamable.com/jwri1b

Thanks for reporting. For convenient I will discuss the issue with you on discord!

Np mate.


[prim_util] Make prim_util a package

prim_util was a include file before, and the vbits() function in it
was effectively a global function. This patch modifies the code to put
the utility function into its own package, prim_util.
The old implementation was problematic for a number of reasons:

Xcelium doesn't like $clog2() inside a "constant function". Even
though we couldn't find evidence that this isn't allowed by the LRM,
we have to live with the implemented reality. A potential workaround
would be implementing clog2() as it was done in pre-SystemVerilog
days.
Functions in included files are visible for all code in the same
compilation unit, with no way to undefine them. This spill-over can
lead to surprising bugs and is best avoided.

Fixes #2579

@cindychip @tunghoang290780 Can you test this patch with Xcelium to see if it resolves #2579?

@cindychip @tunghoang290780 Can you test this patch with Xcelium to see if it resolves #2579?

It likely wouldn't fix #2579. We will have to talk to Cadence AE and get their opinion on this. In the meantime, a quicker fix would be to convert vbits into a macro instead.

@cindychip @tunghoang290780 Can you test this patch with Xcelium to see if it resolves #2579?

It likely wouldn't fix #2579. We will have to talk to Cadence AE and get their opinion on this. In the meantime, a quicker fix would be to convert vbits into a macro instead.

@sriyerg I could not run simulation completely due to issue #2586 but it seems that I was able to compile prim_fifo_sync.sv from @imphil  PR

Btw, I am using Xcelium version 19.09-s008

I rebased and dropped this committed PR: https://github.com/lowRISC/opentitan/pull/2479, and the compilation passed!

Thanks @cindychip! Now I only need to figure out what Vivado is having problems with in CI.

@imphil There are dependencies between PR/Issues so it'd better complete review, check, then merge asap to avoid blocking

Yes, we're almost there. The Vivado issue should be fixed with this PR, but I'd like a sign-off by @sriyerg on this PR and on #2590 by @sriyerg before merging.

@cindychip @tunghoang290780 Can you test this patch with Xcelium to see if it resolves #2579?

It likely wouldn't fix #2579. We will have to talk to Cadence AE and get their opinion on this. In the meantime, a quicker fix would be to convert vbits into a macro instead.

@sriyerg I could not run simulation completely due to issue #2586 but it seems that I was able to compile prim_fifo_sync.sv from @imphil PR

Btw, I am using Xcelium version 19.09-s008

Good to know, thanks! It is strange that the Xcelium compile error goes away with this change.

@sriyerg sure, I renamed to prim_util_pkg.
#2586 is now fixed and this PR is rebased on top of it, so if you want to re-run the regression @tunghoang290780 with this PR that would be appreciated. It should all work again.

@imphil ran regression on AES with this PR. Issue is resolved

Great, thanks!

Even though CI is stuck at the moment, I did run a local Vivado run and it seemed OK, let's get this merged to unblock everyone, and back out tomorrow if I did break something.

@imphil this issue has not been resolved, i2c is still failed due to #2579
@rasmus-madsen correct me if I am wrong but AES does not use prim_fifo_sync so it naturally passed

@tunghoang290780 so you earlier tests of this PR were somehow giving you a wrong result?
Can you please file a new issue with the error message you're now getting, plus steps to reproduce them? And please ensure you're using the latest master version of OpenTitan.

I reran with I2C yeah, it failed... I think in original code, this function is in the compilation unit, so no matter the DUT uses prim_fifo_sync or not, the Xcelium compile will fail. I guess when we move it to the package, only included ones will fail. My previous test was on alert_handler and it does not use prim_fifo_sync, that is probably why Xcelium passed?


Neo4j 2.2 token for cypher queries

Hi !
first of all thanks a lot for this library.
I has some troubles in migrating to neo4j 2.2 since it implements tokens.
Could be possible to implement it into seraph?
Thanks
Daniele

Hi! This is now supported as of seraph 0.11.0. Please see the new server options docs to see how to specify your username/password when initialising seraph.

Also I'm assuming you're talking about auth tokens here. Please correct me if I'm wrong :)

Yep, exactly, thanks!


#113 - Completed.

@rultor merge.

@rultor merge.

@driver733 OK, I'll try to merge now. You can check the progress of the merge here

Coverage increased (+4.1%) to 78.137% when pulling 558f458f76a6d164b5f6629abf3a82e17a4c56b3 on #52 into 5702cbd951aa5b984384de3180bfedede8440909 on master.

@rultor merge.

@driver733 Done! FYI, the full log is here (took me 6min)


Use newer versions of rustc in CI

Updates the rustc versions used in CI.
If you want to keep 1.19 (for example) to ensure compatibility, I'll re-add it!

I'd like to keep all previously existing rust versions as well. I'm not committing to supporting them indefinitely but I'd like to drop support to them at least consciously, not accidentally.

That said I don't think it makes sense to keep both 1.22.0 and 1.22.1

The CI error seems not to be our fold, could you please re-trigger this?

It is the fault of this PR, there is no such download for whatever reason. Will fix on master directly


Only update experiments for firebase namespace

Currently updateExperimentsWithResponse is being called on fetches for all namespaces, causing issues with experiment exposures as fireperf fetch requests are incorrectly updating experiment data
Tracked internally in b/179461119

not sure why spm tests are failing..

Try build the unit test using swift package manager by opening the package.swift.


Make way for host-containers: Task-iterations and command-template functionality

PR to put out some feelers about handling deployments for projects running in containers on the remote host. This is by no means meant to be "the final solution" (although it can be), but simply an initial attempt to get some discussion going. It does work and does exactly what I wrote it for, for your information :)

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

I did not want to make too big of a change to the base functionality. I also wanted to avoid adding container specific functionality in this project, as that should probably be a recipe.
Managed to come up with the following 2-fold approach to allow the functionality I wanted:

A Task now has iterate-functionality. This allows you to specify a set of configuration "delta" items and the task will be ran on the host for each of those deltas. In between runs (and after) the replaced values will be restored (or set to null if they were added because deleting is not supported). Idea here is that we want to be able to run a task on one or more containers on the host. It's also the most compact way to add the needed functionality to a Task
The run()-function can now wrap the command to execute in a so called command_template. As long as this configuration value is not empty (and apply_command_template is not set to false), the template will be used as the command instead. The command to execute is stored in the command-configuration value.

Using this we can achieve running commands within docker on the host fairly easy  (assuming the docker/similar recipe included at the bottom is there):
Wrap existing task (move into container)
runTaskInDocker('deploy:vendors', 'my_container_name', ['release_path' => '{{container_source_path}}']);

Everything the "deploy:vendors" task does will now be ran in the my_container_name-container on the host. The release_path variable will - for the duration of the task - be replace with whatever container_source_path is set to, so that we don't have to rewrite any of the original task but it will run fine within the docker container.
Within a container task: run statement on the host
runOnHost('{{bin/docker-compose}} up -d');

Using the runWithoutTemplate functionality, this disables using the command_template for a single callback and thus runs the regular way.
Some explanation up front
Why iterations?
I get that, most of the time, it will probably be a single container, but adding it within a possible iteration just seemed cleaner to me. Like that it also works for both a single and multiple runs of that task.  The functionality is also not container specific, so who knows what else can be done.
{{?command}}?
The command template has support for tokens that should only be parsed when we're actually about to run the task. This is needed because we want to get the value of the template and "install" it before any parsing is done on the original command.
For example imagine you want to run "{{bin/php}} -i" in a container: If the command_template would simply contain "{{command}}", attempting to get the template value would result in a call to locateBinaryPath('php') since everything is parsed recursively (assuming that set('command', ...) was called already).
locateBinaryPatth would start running commands to try to locate the php executable. Unfortunately these will run on the host instead of in the container.
By delaying substitution for some tokens (like the command), we can fetch the template value, change "{{?command}}" into "{{command}}" and then run the template with normal parsing.
Instead of command -v 'php' this will now result in /usr/bin/docker exec -i my_container_name bash -c 'command -v '\''php'\'''
docker_command_template?
I have been in some situations where I want to be able to specify a different user to run a command, so this allows you to override the template with one of your own, for example:
set('docker_command_template', '{{bin/docker}} exec -i --user not_root {{container}} bash -c {{?command}}');
Curious about your thoughts.
Docker recipe
namespace Deployer;

function runTaskInDocker($task, $containers, $additionalConfiguration = [])
{
    $task = Deployer::get()->tasks->get($task);

    if (!$task) {
        throw new \InvalidArgumentException('Invalid task specified');
    }

    $containers = (array) $containers;
    $iterations = [];
    foreach ($containers as $name) {
        $iteration = [
            'command_template' => has('docker_command_template') ?
                get('docker_command_template') : '{{bin/docker}} exec -i {{container}} bash -c {{?command}}',
            'container' => $name
        ];

        foreach ($additionalConfiguration as $key => $value) {
            $iteration[$key] = $value;
        }

        $iterations[] = $iteration;
    }

    $task->iterate($iterations);
}

function runOnHost($command, $options = []) {
    return runWithoutTemplate(function() use ($command, $options) {
        return run($command, $options);
    });
}

set('bin/docker', function () {
    return runWithoutTemplate(function() {
        return locateBinaryPath('docker');
    });
});

set('bin/docker-compose', function () {
    return runWithoutTemplate(function() {
        return locateBinaryPath('docker-compose');
    });
});

Hi,
Thanks for your contribution, very interesting approach to manipulate containers.
But I think it's too early to merge functionality like this into main deployer. What about creating separate repo under deployer/*** and name it experimental? It should be extension for deployer which add this PR functionality. In this repo we can play and look for better API without worrying of breaking something (as it called experimental).
Also this allows of less major version releases of deployer. After API stabilization we can merge such functionality into deployer.
What do you think?

Like I said, it's just something to get the discussion going, which it did :)
Impact on the main repository is that

Please tell me more about how you use containers and deploy them? Why don't oyu use something like kubernetes?

Currently the system in place is using docker-compose to setup one or more container networks on a server. For example having a php container for the fpm part of a deploy means having to run all artisan commands in that container as the host system doesn't have PHP installed

Has there been any decisions? Will this be merged?

Nope, sorry. Still didn't found time to review all of this.
If someone can provide example project which is using this functionality it will be much better.

thank you for all the information you've shared @jasperf, it's very handy for someone that is just taking his first steps at implementing CI and using Docker. As someone that's used Deployer for over 2 years, I really hope (and figure it would make a lot of sense) that a future update makes it compatible.. so we don't have to learn yet another tool and keep using Deployer for many more years =D


Added New X Profile

What does this PR do?
This PR adds new X Profile

Awesome 👍 about to merge it.. Make sure to drop a ⭐ Star to the repository @ArnabBCA

Thanks a lot, I am new to open source and am looking forward to contribute more to this repo.😊

That's great. We are running through another issue. Maybe you can help us with that


Bugs🐞 on Sales invoice and Payment entry doctype

Objection:

Investigate what cased this bug🔍🔍.

Where?

Sales invoice doctype.
Payment Entry doctype.

It seems that server is not handling and rendering the fields properly. If you go to other tabs or save something then it works.


Bug - Manager - Manager unable to save answers to questions to Assessment Plan

A manager who is trying to build his assessment plan in the online builder says he's been having issues - he says when he tries to add questions he gets a network error so his "passing answer" text won't save.

We think this is an intermittent issue.

We think this is an intermittent issue.


Pod documentation that use :allow< > does not highlight as Raku code but as Pod

Pod documentation that is: =begin code :allow<B L> highlights as Pod not Perl 6 code. It is the :allow which causes this.
htmlify.p6 passes these as Pod to the highlighter, and so it gets highlighted as such (this is to allow us to make things bold/other styles).
Proposed solution from the docs side: we need to parse this Pod and strip it of Pod tags, and insert special Unicode control codes which nobody will have in normal text. These control codes can then be removed in the htmlify.p6 side once the highlighter highlights them.
From the highlighter https://github.com/perl6/atom-language-perl6 side, we will tag these differently than normal code, so we can add that effect in the CSS.

Possibly part of #1823.

I'll see what goes on with this one. I'm not sure I understand it completely, but first I'll see how many pieces of code are affected. If there are not too many, I'll try the solution proposed.

What I was meaning about adding special Unicode codepoints was so we know where to add bold html tags, but I don't know if that approach would be best.
Essentially what the code currently does afaik for =begin code :allow is to not put it through the highlighter but instead renders it to html with pod, so we get links and bold but not syntax highlighting. We need some way to take out the POD tags, highlight it, and then add the bold and links in afterword.

@coke this is definitely a website issue. Moreover, I think this has been at least approached by @finanalyst and it sparked a lot of discussion at other places.


Turning in place

How would I go about making the robot turn in place with pathplanner?

Turning in place is not really something that should be done with a GUI tool. I usually recommend avoiding turning in place entirely since it is usually pretty slow and can be a source of inaccuracy. If you have to turn in place though, it is best to do it on-robot. Using a position PID controller with an IMU usually works pretty well.


Auto-Scroll for Logs

Why do we need this ?
Auto-scrolling in logs will enhance convenience for users.

Acceptance Criteria

[ ]  Implement logic to automatically scroll to the bottom of the logs file.

@VipinDevelops I would like to work on this enhancement as it's pretty straight forward. Could you please assign it to me?

Go Ahead @xyfer17

@VipinDevelops just take a look on PR and let me know will i have to change anything else.


How to determine which variables should share memory in an "shared_optimizer"

Hi, can you give me some advice that How to determine which variables should share memory in an "shared_optimizer";

I find that you share memory of some variable
state['exp_avg'].share_memory_() state['exp_avg_sq'].share_memory_()
in your shared_adam.py; but others also shared step;
state['step'].share_memory_()
also in shared_RMSprop , here is share different with here;

Thank you advance!

Finally, I got it! Hi, MorVan, your code have not share state['step'], which caused a wrong bias_correction. Refer to  here, it should be fixed to like this .

Finally, I got it! Hi, MorVan, your code have not shared state['step'], which will cause a wrong bias_correction. Refer to here, it should be fixed to like this .

Finally, I got it! Hi, @MorvanZhou , your code have not shared state['step'], which will cause a wrong bias_correction. Refer to here, it should be fixed to like this .

Thanks, that is indeed a problem for adam but not for rmsprop. The reason I choose rmsprop is that I don't need to add 'step()'


Upgrade resin-device-logs to v2.0.0

This new version contains necessary functionality to get logs from
recently provisioned devices.

As I've commented there I think you don't properly build the channel name

@emirotin Yeah, caught it the hard way. It's being fixed here: https://github.com/resin-io/resin-device-logs/pull/9.


Depreciation warning on latest Atom

When using Elmjutsu on the newest atom I get this warning
Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Seems like I have found the same issue.


feat: Add NavigationRailLabelType and example for go_router

Issue
Closes: #2
Approach
Add NavigationRailLabelType in AdaptiveNavigation and _defaultRailBuilder.
Add an example for the go_router package, based on the go_router stateful_shell_route example.

@c0pp1ce
Please check this PR.

WIll do tomorrow 👍🏻

Sorry for being very late.
More customization for default builders
I have decided to not include NavigationRailLabelType or other properties like it (e.g. NavigationDestinationLabelBehavior).
The reason for this is that they can be changed via themes which will also affect the default builders.
go_router example
Can you open a different PR for the go_router example?


Templating logging feature values in values.yaml

Purpose
fixes: https://github.com/wso2/apk/issues/1209

Codecov Report
Patch coverage has no change and project coverage change: +27.55 :tada:

Comparison is base (7c17831) 32.41% compared to head (d3c1b44) 59.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1218       +/-   ##
===========================================
+ Coverage   32.41%   59.97%   +27.55%
===========================================
  Files         376       25      -351
  Lines       43800     2006    -41794
  Branches    14200     1093    -13107
===========================================
- Hits        14198     1203    -12995
+ Misses      29352      803    -28549
+ Partials      250        0      -250

Flag
Coverage Δ

adapter
?

admin-domain-service
52.40% <ø> (ø)

backoffice-domain-service
?

devportal-domain-service
?

idp-domain-service
80.10% <ø> (ø)

runtime-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 351 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add commit status for E2E Test workflow

Now that the E2E Test workflow is a workflow_run target workflow, it is disconnected from the pull_request target workflow and it does not appear in the PR's checks list.
We update the workflow to add its own commit status to the PR via the commit SHA. The context parameter to the create commit status API connects the two APIs calls so that the later call updates the status of the initial call.
We also include a target url in the commit status to link to the E2E Test action run for the PR.
Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Functional tests have been added, if necessary.
[ ] E2E Workflow tests have been added, if necessary.

This PR may be closed in favor of #2342.


Windows: don't fail the connection for recoverable errors on network changes

Prevents the connection for failing during network changes when:

A new network interface comes up, but the current (gateway) interface is still connected.
We fail to add the route to tun2socks (router), since the route already exists.

Thanks for the review, @trevj. Since I only updated comments, should I recompile and sign OutlineService.exe?

No, no need to recompile since you just changed comments. Thanks!


Added Logo, Button, FAQs, Features, Footer and Hero components. Updated Home Page.

Added Logo, Button, FAQs, Features, Footer and Hero components. Updated Home Page.

replace the logo with correct logo without background.
remove Home from this pull request.


Support 'onAfterLeave' callback.

Closes #166

This change is

Reviewed 5 of 5 files at r1.
Review status: all files reviewed, 4 unresolved discussions (waiting on @SomeoneToIgnore)

demo/vaadin-router-lifecycle-callbacks-demos.html, line 250 at r1 (raw file):

          router.setRoutes([
            {path: '/', component: 'x-main-page'},
            {path: '/editText', component: 'x-autosave-view'},

let's use lowercase in path values

demo/vaadin-router-lifecycle-callbacks-demos.html, line 259 at r1 (raw file):

            is: 'x-autosave-view',
            onBeforeEnter: function() {
              this.text = savedText;

let's change this to avoid using Polymer data bindings at least here, e. g.
this.shadowRoot.querySelector('textarea').value = savedText;

and for saving, respectively:
savedText = this.shadowRoot.querySelector('textarea').value;

demo/vaadin-router-lifecycle-callbacks-demos.html, line 274 at r1 (raw file):

        <dom-module id="x-autosave-view">
          <template>

<textarea rows=5 cols=30>{{text}}</textarea>

please use double quotes for HTML attributes.

src/documentation/web-component-interface.js, line 51 at r1 (raw file):

 * Any of the `onBefore...` callbacks have a possibility to cancel the navigation and fall back
 * to the previous navigation result (if there is no result and this is the first resolution, an exception is thrown).
 * Any of the `onAfter...` value is ignored.

consider making this a bit longer, e. g. " Any of the onAfter... callbacks are considered and non-cancellable, and their return value is ignored. "

Comments from Reviewable

Review status: 2 of 5 files reviewed, 4 unresolved discussions (waiting on @web-padawan and @SomeoneToIgnore)

demo/vaadin-router-lifecycle-callbacks-demos.html, line 250 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
let's use lowercase in path values

Ok.

demo/vaadin-router-lifecycle-callbacks-demos.html, line 259 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
let's change this to avoid using Polymer data bindings at least here, e. g.
this.shadowRoot.querySelector('textarea').value = savedText;

and for saving, respectively:
savedText = this.shadowRoot.querySelector('textarea').value;

Right, more standardized, thanks.

demo/vaadin-router-lifecycle-callbacks-demos.html, line 274 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
please use double quotes for HTML attributes.

Done.

src/documentation/web-component-interface.js, line 51 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
consider making this a bit longer, e. g. " Any of the onAfter... callbacks are considered and non-cancellable, and their return value is ignored. "

Ok.

Comments from Reviewable

Review status: :shipit: complete! all files reviewed, all discussions resolved

demo/vaadin-router-lifecycle-callbacks-demos.html, line 250 at r1 (raw file):
Previously, web-padawan (Sergey Kulikov) wrote…
maybe just "edit"?

Yeah, looks better, thanks.

Comments from Reviewable

Reviewed 2 of 5 files at r1, 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4.
Review status: all files reviewed, 1 unresolved discussion (waiting on @SomeoneToIgnore)

test/router/lifecycle-events.spec.html, line 51 at r4 (raw file):

    describe('Vaadin.Router lifecycle events', function() {
      const {verifyActiveRoutes, onAfterEnterAction, onAfterLeaveAction, onBeforeEnterAction, onBeforeLeaveAction} = VaadinTestNamespace;

nit: the line seems to be too long
Please consider wrapping it. An idiomatic way would be
const {
  verifyActiveRoutes,
  onAfterEnterAction,
  onAfterLeaveAction,
  onBeforeEnterAction,
  onBeforeLeaveAction
} = VaadinTestNamespace;

Comments from Reviewable

Review status: all files reviewed, 1 unresolved discussion (waiting on @SomeoneToIgnore)

test/router/lifecycle-events.spec.html, line 51 at r4 (raw file):
Previously, vlukashov (Viktor Lukashov) wrote…
nit: the line seems to be too long
Please consider wrapping it. An idiomatic way would be
const {
  verifyActiveRoutes,
  onAfterEnterAction,
  onAfterLeaveAction,
  onBeforeEnterAction,
  onBeforeLeaveAction
} = VaadinTestNamespace;

Linter was not complaining, but sure, done :)

Comments from Reviewable

Reviewed 2 of 2 files at r5.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


pdf.js and pdfworker.js are not working after build my whole project (all the js concatenated in one file)

i removed the pdf.js and pdfworker.js from concatenation and added them separately and it worked. how can i make them work while concatenated ?

Did you use node make singlefile?

yes i use node i use angular cg-generator and its grunt file for building

It seems like there may be a problem with that particular generator then. Can you also reproduce it with the regular Makefile commands from this repository (as we do not use Grunt)?

This appears to work just fine for me using the regular Makefile. It is recommended to use that with node make generic. There is also node make singlefile to produce one file is that is really needed. Angular CG generator and its Grunt Makefile are out of scope for this project: if there are any problems with that, please report them at their repository.
Closing as invalid. If there is really an issue in PDF.js (i.e., with our Makefile), then please provide more details to reopen.


chore: import repository https://github.com/saikumarram123/jx3-minikube.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

First Commit


Add support for Spark ML SQLTransformer

Explore the possibility of adding support for Spark ML SQLTransfomer (https://spark.apache.org/docs/latest/ml-features.html#sqltransformer) in HB.

We don't need this anymore because of TQP.


Doc request: document empty conditionals

Name
0 Filter
1 Filter
2 Filter

OR
return empty list
validate single filter
validate all filters

AND
return all items
validate single filter
validate all filters

NOT
return all items
validate single filter
validate all filters

Context: https://github.com/prisma/prisma/issues/4784#issuecomment-779845616
Perhaps on this page: https://www.prisma.io/docs/concepts/components/prisma-client/null-and-undefined
Details: https://www.notion.so/prismaio/Filter-condition-reduction-behavior-450c7baa5c5d4835a2c5dcc49c3eb494

Suggest adding a section to prisma.io/docs/concepts/components/prisma-client/null-and-undefined about the effects of null on conditionals
Suggest adding one example to each reference section (OR, AND, NOT) with a link to the general explanation: https://www.prisma.io/docs/reference/api-reference/prisma-client-reference#and


Not working in swade

I'm not sure if I'm just missing something but the module doesn't seem to do anything for me. I'm using swade. I've tried and PCs and NPCs. I've tried setting the wounds manually on the sheet and tried applying wounds through both the default system interface and the Better Rolls 2 for SWADE module. Nothing seems to work. I also tried the reapply wounds macro and that does nothing either.
Manually apply the wound effect using the macro from Token FX works fine, so it's not an issue of something there not working.
I'm on Foundry 11.315, swade version 3.2.5, Token FX version <IP_ADDRESS>, and your module version 1.1.7.

It's the same for me.
Foundry v11.315
Savage Worlds Adventure Edition (SWADE) v3.3.11
Token Magic FX v<IP_ADDRESS>
Automatic Wounds v1.1.7

Fixed in v1.1.8 probably (haven't tested it, but I saw a clear bug in the code).  Let me know if it does or doesn't work!

It does seem to be fixed, thanks. FYI, because you've the new version as 12+ in the package interface (but not in the module.json) it doesn't automatically update for v11 even though it is compatible. I'd recommend updating the release info to have the min version be v11.

Ah, that's because I wasn't sure if foundry.utils.getProperty exists in v11, and didn't want to risk it for such a small fix.  Are you sure it worked fine in v11?  if so I'll change it

Yeah, it definitely works. I'm a mod dev too. All they did was remove support for directly calling getProperty and now require it be called through foundry.utils but it was possible to call it through foundry.utils in v11.

they didn't remove support for it though - it only gives a deprecation warning!
but thanks, I'll update this now :)


Access-Control-Allow-Headers determined by first request (and clean up)

If options.headers is not set, it is permanently set to the value of this.header['access-control-request-headers'] of the first request processed by this middleware. I can't see why this is the desired behavior in any case.

:+1:
This was causing major ghost bugs on my production environment.

:+1:

Just got bit by this again, because I forgot to use my fork. This really needs to be merged.

Yeah, I really wish the author would merge this :<
Let's make our own library with less bugs and blackjack! And allow pull requests!

:+1:

Sorry guys so long, I'm taking a look.

It's now merged, Thanks for the good work.


Website link broken

Context
This is an awesome protocol and it'd be awesome to dig into this. But, there are 2 minor issues:

Website link broken from the docs page: https://modelcontextprotocol.io/
Are there examples on how the protocol works in various contexts?

I checked. For me https://modelcontextprotocol.io resolves. Maybe it was a temporary blip or there are potentially connection issues on your side (e.g. proxys, firewalls, etc).

What specific examples are you looking for? I am sure we can improve on given examples. Understanding what would be most useful to you and others would help a lot.


Research existing open source TTS models

https://github.com/balisujohn/tortoise.cpp is what we're about to use.
Is there anything better? Report as comment in this issue.

I've searched for most used TTS models and they are:

Ultravox

Pros:

it's suitable for real-time - "time-to-first-token (TTFT) of approximately 150ms, and a tokens-per-second rate of ~60, all using a Llama 3.1 8B backbone"
Actively developing

Cons:

Doesn't have .cpp version
Doesn't support voice cloning

Tortoise / tortoise.cpp

Pros:

Has some of the most natural-sounding speech
Excels at generating multiple distinct voices
Can clone voices
Has .cpp version

Cons:

Occasionally deviates from the exact input text
The developer behind it was hired from OpenAI, so it might be not so actively developing

Bark

Pros:

Highly realistic, multilingual speech
Generates music, background noise, simple sound effects

Cons:

Doesn't have .cpp version
Not actively developing

MeloTTS

Pros:

It says it's fast enough for real-time CPU and supports multiple languages

Cons:

No support for voice cloning
Doesn't have .cpp version

StyleTTS2

Pros:

Realistic and natural speech

Cons

Not actively developing
Doesn't have .cpp version

ChatTTS

AGPLv3+ license

Ok. Let's evaluate tortoise deeper since it's the only one with a .cpp version.
Try running it locally. How does it sound? How fast is it?

I forked tortoise.cpp in our org and in the beginning I was able to run it only on CPU because some operations were not ported for Metal (they were implemented only for CUDA). So, after a couple of days I was finally ready with implementation and bug-fixing(there were bugs in metal part in ggml since the guy was not using vanilla ggml).
The sound is good, the same as the one on the CPU. For small sentence I tested with ("dr freeman, does the metal work?") the results are:

CPU - 133.31 sec
Metal - 23.21 sec (almost 6x faster)

We'll finish the research for now. tortoise.cpp is good enough for the current goal. So we'll continue with plugin implementation in different repo.


Update subscriptions FE staging urls

Task/Issue URL: https://app.asana.com/0/488551667048375/1206807350622744/f
No UI changes

#4283  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on  Graphite


Enabling admin notifications causes program to crash

On Release 65, If admin notifications are enabled, the software crashes. If admin is disabled there are no errors. Changing notifyBlockFound to false does not change the behavior, neither does using/adding notifyPaymentSuccess.
"notifications": {
"enabled": true,
"email": {
"host": "smtp.gmail.com",
"port": 587,
"user"<EMAIL_ADDRESS>"password": "password",
"fromAddress"<EMAIL_ADDRESS>"fromName"<EMAIL_ADDRESS>},
"admin": {
"enabled": true,
"emailAddress"<EMAIL_ADDRESS>"notifyBlockFound": true
}
},
Error:
[2022-01-02 23:34:35.2453] [I] [XmlKeyManager] User profile is available. Using '/home/ubuntu/.aspnet/DataProtection-Keys' as key repository; keys will not be encrypted at rest.
[2022-01-02 23:34:35.3877] [E] [Host] BackgroundService failed System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at Miningcore.Notifications.NotificationService.ExecuteAsync(CancellationToken ct) in /home/ubuntu/temp/miningcore/src/Miningcore/Notifications/NotificationService.cs:line 156
   at Microsoft.Extensions.Hosting.Internal.Host.TryExecuteBackgroundServiceAsync(BackgroundService backgroundService)    at Miningcore.Notifications.NotificationService.ExecuteAsync(CancellationToken ct) in /home/ubuntu/temp/miningcore/s                                                                                rc/Miningcore/Notifications/NotificationService.cs:line 156
   at Microsoft.Extensions.Hosting.Internal.Host.TryExecuteBackgroundServiceAsync(BackgroundService backgroundService)
[2022-01-02 23:34:35.4012] [F] [Host] The HostOptions.BackgroundServiceExceptionBehavior is configured to StopHost. A BackgroundService has thrown an unhandled exception, and the IHost instance is stopping. To avoid this behavior, config                                                                                ure this to Ignore; however the BackgroundService will not be restarted. System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at Miningcore.Notifications.NotificationService.ExecuteAsync(CancellationToken ct) in /home/ubuntu/temp/miningcore/src/Miningcore/Notifications/NotificationService.cs:line 156
   at Microsoft.Extensions.Hosting.Internal.Host.TryExecuteBackgroundServiceAsync(BackgroundService backgroundService)    at Miningcore.Notifications.NotificationService.ExecuteAsync(CancellationToken ct) in /home/ubuntu/temp/miningcore/s                                                                                rc/Miningcore/Notifications/NotificationService.cs:line 156
   at Microsoft.Extensions.Hosting.Internal.Host.TryExecuteBackgroundServiceAsync(BackgroundService backgroundService)
[2022-01-02 23:34:35.4012] [I] [Lifetime] Application is shutting down...

Need more information on this.

What info do you need? More than happy to provide.

Your redacted config file (minus passwords etc).

{
"logging":{
"level": "info",
"enableConsoleLog": true,
"enableConsoleColors": true,
"logFile": "debug.log",
"apiLogFile": "api.log",
"logBaseDirectory": "/home/ubuntu/temp/miningcore/testlogs",
"perPoolLogFile": true
},
"api": {
"enabled": true,
"listenAddress": "<IP_ADDRESS>",
"sslConfig": {
"enabled": false,
"sslPath": "/home/ubuntu/ssl/arctic.pfx",
"sslPassword": ""
},
"port": 4001,
"rateLimiting": {
"disabled": true,
"rules": [
{
"Endpoint": "*",
"Period": "1s",
"Limit": 20
}
],
"ipWhitelist": [
""
]
}
},
"banning":{
"banOnJunkReceive": false,
"banOnInvalidShares": false
},
"notifications":{
"enabled": true,
"email":{
"host": "smtp.gmail.com",
"port": 587,
"user": "user",
"password": "password",
"fromAddress"<EMAIL_ADDRESS>"fromName": "pool"
},
"admin":{
"enabled": true,
"emailAddress"<EMAIL_ADDRESS>"notifyBlockFound": true
}
},
"persistence": {
"postgres": {
"host": "<IP_ADDRESS>",
"port": 5432,
"user": "postgres",
"password": "password",
"database": "miningcore"
}
},
"paymentProcessing":{
"enabled": false,
"interval": 600,
"shareRecoveryFile": "recovered-shares.txt"
},
"pools": [
{
"id": "picacoin",
"enabled": true,
"coin": "picacoin",
"addressType": "BechSegwit",
"bechPrefix": "bc",
"address": "bc1uhr4zfvycqcxzk287gtz6cmq3vyht27kv0234f",
"rewardRecipients": [{
"address": "bc1uhr4zfvycqcxzk287gtz6cmq3vyht27kv0234f",
"percentage": 0.01
}],
"gbtArgs": [ {"rules": ["segwit"] } ],
"blockRefreshInterval": 500,
"jobRebroadcastTimeout": 10,
"clientConnectionTimeout": 600,
"banning": {
"enabled": true,
"time": 600,
"invalidPercent": 50,
"checkThreshold": 50
},
"ports": {
"3923": {
"listenAddress": "<IP_ADDRESS>",
"difficulty": 8192,
"name": "ASIC Mining",
"varDiff": {
"minDiff": 1024,
"targetTime": 15,
"retargetTime": 90,
"variancePercent": 30
}
},
"13923": {
"listenAddress": "<IP_ADDRESS>",
"difficulty": 500000,
"name": "Nicehash/High Diff Mining",
"varDiff": {
"minDiff": 500000,
"targetTime": 15,
"retargetTime": 90,
"variancePercent": 30
}
}
},
"daemons": [{
"host": "<IP_ADDRESS>",
"port": 8772,
"user": "user1",
"password": "password"
}],
"paymentProcessing": {
"enabled": true,
"minimumPayment": 0.0001,
"payoutScheme": "SOLO", // PROP PPLNS SOLO supported
"payoutSchemeConfig": { "factor": 2.0 }
},
}
]
}

config.json-error.txt

Hmm, I cannot reproduce the crash.

https://github.com/lurchinms/kriptokyng_miningcore/commit/74d3409dd2bc69ea5ca786630f60dfbb4e63bd53


Fix warning and code clean

Pull Request Test Coverage Report for Build 134

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 132:
0.0%

Covered Lines:
88

Relevant Lines:
88

💛  - Coveralls


append to setting does not work in 0.13.16 in an AutoPlugin's projectSettings

steps
project/MyPlugin.scala
import sbt._
import sbt.Keys._

object MyPlugin extends AutoPlugin {
  override def projectSettings = Seq(
    sourceDirectories in Compile += baseDirectory.value / "blah"
  )
}

build.sbt
lazy val root = (project in file("."))
  .enablePlugins(MyPlugin)

do show compile:sourceDirectories
problem
In 1.0.x the value is added to the list, in 0.13.16 it is not.
Also, in 0.13.16 this line mysteriously fixes the problem:
  override def requires = plugins.JvmPlugin

Found here: https://stackoverflow.com/a/29848730/1531945
expectation
Should work in 0.13.x as well.
notes
I've tried sourceGenerators += ... as well.
I could not find similar issue here.

https://github.com/sbt/sbt/issues/2082

@xuwei-k Thank you very much!
Is this documented?
This comment describes the behavior, but this requirement seems still not mentioned in docs.
How can one find which setting comes from which plugin? inspect does not provide such hints, it only points to the place where setting macro is applied.

I can rewrite the issue to documentation issue.


Fix request send status #1073

Resolves #1073

please resolve the conflicts in message-actions.js

the conflict should be resolved now.


Broken helper function generating extended_vars.yaml

- rawname: CS3_GATEWAY
  path: services/idp/pkg/backends/cs3/bootstrap/cs3.go:76
  - foundincode: true
  + foundincode: false
  name: CS3_GATEWAY
  type: ""
  default_value: ""
  description: ""
  do_ignore: true
- rawname: CS3_GATEWAY
  path: ./services/idp/pkg/backends/cs3/bootstrap/cs3.go:76
  foundincode: true
  name: CS3_GATEWAY
  type: ""
  default_value: ""
  description: ""
  do_ignore: false

and other exended envvars...
Issue: there should not be the same identical block.
@dragonchaser @micbar fyi

Easy bug, result from #7422. Change in the Makefile resulted in changing the path to a relative one, just do a string operation and remove the ./


Implement greedy scheduler

Implements https://github.com/JuliaFolds2/OhMyThreads.jl/issues/11
Like split=:scatter, this option is a bit scary to expose for tmapreduce because it also requires that the reducing op be commutative.
I almost wonder if we should do some sort of argument validation to detect if the user gave us a non-commutative reducing operator...
e.g.
julia> treduce(vcat, [:a, :b, :c, :d, :e, :f, :g])
7-element Vector{Symbol}:
 :a
 :b
 :c
 :d
 :e
 :f
 :g

julia> treduce(vcat, [:a, :b, :c, :d, :e, :f, :g], schedule=:greedy, init=Symbol[])
7-element Vector{Symbol}:
 :b
 :f
 :a
 :g
 :d
 :e
 :c

This is not a problem for tforeach, tmap(f, OutputElementType, A), or tmap!, but it is a concern for regular tmap, as well as tmapreduce, treducemap, and treduce.
One other potential problem is that this algorithm is prone to giving errors if you run it on a small array and don't provide an init argument:
julia> treduce(vcat, [:a, :b, :c, :d, :e, :f, :g], schedule=:greedy)
ERROR: TaskFailedException
Stacktrace:
[...]
    nested task error: MethodError: reducing over an empty collection is not allowed; consider supplying `init` to the reducer
    Stacktrace:
[...]

this is because we're doing
    ch = Channel{Tuple{eltype.(Arrs)...}}(0; spawn=true) do ch
        for args ∈ zip(Arrs...)
            put!(ch, args)
        end
    end
    tasks = map(1:ntasks) do _
        @spawn mapreduce(op, ch; mapreduce_kwargs...) do args
            f(args...)
        end
    end

so if one task gets spawned after the channel gets emptied, then we're in trouble.

Like split=:scatter, this option is a bit scary to expose for tmapreduce because it also requires that the reducing op be commutative.
I almost wonder if we should do some sort of argument validation to detect if the user gave us a non-commutative reducing operator...

I think documenting this requirement clearly for these options should be fine. After all, you have to actively opt for them. As for testing the commutative property, I would think that that's hard (perhaps even impossible) to do in general and also can be costly.

I think so, yes. But I'll revisit them when I set up Documenter (today).


Grammar fix for note 1

Note 1 should be:
1 Provided that the user has been added as a guest and is signed in with the guest account.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f080a5c-4268-1db4-566f-f1edc27920b5
Version Independent ID: ac556a92-58af-3e05-f53b-0fc00afc96c0
Content: Use guest access and external access to collaborate with people outside your organization - Microsoft Teams
Content Source: Teams/communicate-with-users-from-other-organizations.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


uninstallMobile fails when no app is installed on the device, and compileFlex + packageMobile are UP-TO-DATE

hi, just trying out gradle+gradlefx for the first time today, and i run into a problem with installMobile.
c:\xxx> gradlew installMobile
:aaa:copyresources
:aaa:compileFlex
:aaa:packageMobile
:aaa:uninstallMobile
[ant:java] Java Result: 14
:aaa:installMobile
BUILD SUCCESSFUL
then manually delete the app from the device, and run the build again
c:\xxx> gradlew installMobile
:aaa:copyresources
:aaa:compileFlex UP-TO-DATE
:aaa:packageMobile UP-TO-DATE
:aaa:uninstallMobile
[ant:java] Java Result: 14
Failed to find package xxx.yyy.zzz
:aaa:uninstallMobile FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':aaa:uninstallMobile'.

java.lang.Exception: uninstall app to target device failed: Failed to find package xxx.yyy.zzz

BUILD FAILED
So, is there any way to skip the failed uninstallMobile in this case as well?
(Doing a :aaa:clean and a rebuild is a workaround for now, but pretty inconvenient and time consuming)

Gradle 2.3
Build time:   2015-02-16 05:09:33 UTC
Build number: none
Revision:     586be72bf6e3df1ee7676d1f2a3afd9157341274
Groovy:       2.3.9
Ant:          Apache Ant(TM) version 1.9.3 compiled on December 23 2013
JVM:          1.8.0_60 (Oracle Corporation 25.60-b23)
OS:           Windows 7 6.1 amd64
and GradleFx version 1.3.1

I have encountered the same issue, will submit a PR later today

https://github.com/GradleFx/GradleFx/pull/207 should fix it

Sweet, it does install the app now. (It says failed after installation b/c i guess uninstall failed, but thats just a minor issue for me)

merged PR #207


Is content unloaded to readonly property

Replace isContentUnloaded with a readonly property contentUnloaded and added documentation.

Good to me.

For #3241.


Allow export for clang make

I will really appreciate if there will be a possibility to export or even print the whole command called when clang and clang-tidy is called.
I know the command line could be really long, especially when there's a long -I list, but it really will help me (and I think many others) executing the clang-tools by hand or even build a simple cmake for it.

You can see all the details behind the scenes, including the command line passed to clang++ or clang-tidy by activating the verbose mode.
Clang Power Tools > Settings > General > Verbose Mode => True
Eg.  [Output tab]
clang++
VERBOSE: Clang job args[0]: -include-pch "win\GuiProj.clang.pch" -x c++ "editor\ImageButtonControl.cpp" -Werror -std=c++14 -Wall  -fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas -Wno-unused-variable -Wno-unused-value -fsyntax-only -DWIN32 -D_WINDOWS -D_DEBUG -DUNICODE -D_UNICODE
clang-tidy
VERBOSE: Clang job args[0]: "editor\ImageButtonControl.cpp" -checks=-*,modernize-use-equals-default,modernize-use-equals-delete  -header-filter="comps\\win" -quiet -- -Werror -std=c++14 -Wall -fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas  -Wno-unused-variable -Wno-unused-value -DWIN32 -D_WINDOWS -D_DEBUG -DUNICODE -D_UNICODE


Event Detail Close action enhancements

Currently the event detail window close button is only on the inside of the detail and is hidden upon scroll. This makes it hard to browse through events. The user experience would be improved if:

the close button and download buttons were sticky on the top of the event window
the event window would close when the mouse is clicked outside the window
the last event selected that was shown in the event window is highlighted
the event window internal scroll state did not persist between events

I will try to work on the issue.

How should we display the last selected event? I tried to style it with an outline, how does this look?

That's a good start! I feel a lighter colored background would pop a little more than the outline, perhaps grab lighter color from the 'today' button on the top left?

Sure. That sounds good. I'll try this out.


BUG: pass through dynamic metrics

Codecov Report

Merging #113 into master will decrease coverage by 1.44%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   99.46%   98.02%   -1.45%
==========================================
  Files           5        4       -1
  Lines         566      557       -9
==========================================
- Hits          563      546      -17
- Misses          3       11       +8

Impacted Files
Coverage Δ

scikeras/_utils.py
94.91% <50.00%> (-5.09%)
:arrow_down:

scikeras/wrappers.py
98.38% <0.00%> (-0.67%)
:arrow_down:

scikeras/utils/transformers.py
100.00% <0.00%> (ø)

scikeras/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0efdf...99f201f. Read the comment docs.


allowDismissByPanningPresentedView does not work with left/right panning

If my view slides in from the left and I have allowDismissByPanningPresentedView set to true, I would expect a pan gesture on the view to the left to dismiss the view. However, I can only pan the view up and down. Furthermore, when I pan up the view moves down and vice versa. The up/down pan gestures do not dismiss the view, but I would not expect them to do so.

Feel free to make PR with functionality

I took a look at the relevant code but found it difficult to follow. Can you tell me the general intent of the pan gestures?

By using pan gestures you can dismiss using some of edges of presented controller or by holding finger on presented view controller and slide it

Can you tell me exactly what those intended gestures are?


PERF: Fast assign point data, weights BSplineScatteredData filter

BSplineScatteredDataPointSetToImageFilter::GenerateData() now does fast
assignments to the internal STL containers of m_PointWeights,
m_InputPointData, and m_OutputPointData, instead of calling the expensive
itk::VectorContainer::InsertElement member function.
Using VS2015 (Release), ~8% run-time duration reduction was observed on an
Update() of BSplineScatteredDataPointSetToImageFilter. For an Update()
of N4BiasFieldCorrectionImageFilter (which heavily uses
BSplineScatteredDataPointSetToImageFilter), ~7% run-time duration reduction
was observed (from 56 sec to 52 sec, on a 3-D MRI volume + mask (453x340x20),
provided by Denis (@dpshamonin), at LKEB, Leiden University Medical Center).

@dzenanz Thanks for your approval!
@ntustison FYI, this PERF pull request also increases the speed  of your bias correction filter! Compared to ITK4, I observed a total performance improvement of more than 40% on an Update() of your filter, from all the merged ITK5 PERF improvements + this PR!

@N-Dekker That's great.  I was also going to ask about this and another filter which is an integral part of the image registration framework.

FYI The issue addressed by this PR is that itk::VectorContainer::InsertElement is particularly inefficient when it is used to append a large number of elements to a container. Internally it then resizes its std::vector with each InsertElement, which is time consuming. It appears much more efficient to just assign the entire vector at once, if that is possible.

Can a deque be used instead of vector for the point sets? Also, vectors' capacity grows by more than one element at a time, so this might not be much of an issue.

@dzenanz

Can a deque be used instead of vector for the point sets?

Technically, I think that's possible, indeed. Doing so is likely to improve the performance on appending an arbitrary number of elements. However, I don't think std::deque is always preferable to std::vector, for point sets. It depends on the use case. std::deque has some more overhead that std::vector (for its internal data management), and std::vector has the advantage that it is a contiguous container.

Also, vectors' capacity grows by more than one element at a time, so this might not be much of an issue.

For large number of elements, I still think memory reallocation is causing the performance issue addressed with this PR. Even though std::vector may have a clever reallocation strategy, which reduces the number of reallocations, it cannot avoid all of them, with each itk::VectorContainer::InsertElement call. Unless the total number of elements is known beforehand, and reserved (using std::vector::reserve). Do you think there's another reason for this performance issue?

@N-Dekker --- yes, that information should be known.  So is this is something you want to tackle or should I put it on my to-do list?

@N-Dekker Happy New Year.  Thank you for a year of great contributions.

@dzenanz

vectors' capacity grows by more than one element at a time, so this might not be much of an issue.

For the record, I observed on VS2015 that when calling std::vector::push_back 1,574,804 times (which happens with the tested 3-D MRI 453x340x20 MRI data set from LKEB, LUMC), it takes 37 reallocations, if this is done without a call to std::vector::reserve. In that case, the capacity grows as follows: 1 2 3 4 6 9 13 ... 1049869 1574803 2362204.

If number of elements is known in advance, reserving that number is the right thing to do. I was just noting that vector isn't too bad either.

Happy New Year to you as well  :-)
@blowekamp

The performance improvement from this patch may also be the "VectorContainer::Modified" no longer being called when each element is added.

Indeed, that could certainly have contributed to the performance gain.
The three members involved with this commit are all private: m_PointWeights, m_InputPointData, and m_OutputPointData. Could a Modified() call on these data members have any useful effect at all?

If they are used internally as input to a filter run as a mini-pipeline the MTime could be important to ensure execution of the filters ( in some cases ). Also if the DataObjects are exposed to the user via Get methods or as output data objects of the filter the MTimes can be very important.

If they are used internally as input to a filter run as a mini-pipeline the MTime could be important to ensure execution of the filters ( in some cases ). Also if the DataObjects are exposed to the user via Get methods or as output data objects of the filter the MTimes can be very important.

Thanks, @blowekamp  I inspected the code (both itkBSplineScatteredDataPointSetToImageFilter.h and itkBSplineScatteredDataPointSetToImageFilter.hxx). Fortunately it appears to me that none of these good reasons that you mentioned for doing Modified() are there, for those three private data members of BSplineScatteredDataPointSetToImageFilter.


[WIP] Replace AppVeyor with GitHub Actions

This is based on @qarmin's work in #38433
It only builds windows at the moment and provides:

windows editor binaries which you can download.
pull request building
cache handling (to be fixed but this should work...)
explicit python versioning
faster builds

It's really meant to just replace AppVeyor right now in a smaller step so Godot can evaluate it internally.
Example/overview of the actions

https://github.com/RevoluPowered/godot/actions

Windows binaries example

https://github.com/RevoluPowered/godot/actions/runs/161976551

Some build logs to show you how the builds replicate the existing appveyor behavior

https://github.com/RevoluPowered/godot/runs/849869572?check_suite_focus=true

I see you test build from scratch took 40 min. Did you check how long it then takes with cache:

For a no-op build
For a change to a leaf class (e.g. something in editor)?

I see your test build from scratch took 40 min. Did you check how long it then takes with cache:
* For a no-op build

* For a change to a leaf class (e.g. something in `editor`)?

I can run tests of this and post the results with the cache, I had some troubles with the caching on windows, basically it has a cache directory but it wasn't being used. :/ I tried scons updates and no luck, so will boot windows and look into it there.
IRC for me is down right now IRCCloud is having ISP issues.
I could use some help debugging why the cache there is not working, I think possibly it's looking in the wrong directory for the cached files.

IRC for me is down right now IRCCloud is having ISP issues.

Use http://webchat.freenode.net/?channels=#godotengine-devel for now :slightly_smiling_face:

Superseded by #40282.


I cannot download redis system from docker.

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

doeck pull redis
the system return the message "no matching manifest for windows/amd64 in the manifest list entries"

Redis is a linux docker image only - Please see the documentation for this image and the requirements.
To learn more about Windows Containers, please see this post:
https://blog.docker.com/2016/09/build-your-first-docker-windows-server-container/
Additionally, if you're running Docker for Windows, you can switch to using windows containers:
https://docs.docker.com/docker-for-windows/#switch-between-windows-and-linux-containers


Add LeetCode problem #1160

https://leetcode.com/problems/find-words-that-can-be-formed-by-characters/

ping


Tavic update

Codecov Report

Merging #22 into JDBC4.3 will increase coverage by 0.1%.
The diff coverage is 31.03%.

@@             Coverage Diff              @@
##             JDBC4.3      #22     +/-   ##
============================================
+ Coverage      46.45%   46.56%   +0.1%
- Complexity      2211     2218      +7
============================================
  Files            108      108
  Lines          25363    25373     +10
  Branches        4177     4177
============================================
+ Hits           11783    11814     +31
+ Misses         11545    11531     -14
+ Partials        2035     2028      -7

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.48% <31.03%> (+0.1%)
2215 <0> (+5)
:arrow_up:

#JDBC42
46.48% <31.03%> (+0.1%)
2212 <0> (+7)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java
88.33% <0%> (ø)
13 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.2% <0%> (+0.3%)
0 <0> (ø)
:arrow_down:

...ava/com/microsoft/sqlserver/jdbc/FailOverInfo.java
52.63% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java
12.8% <0%> (-0.11%)
9 <0> (ø)

...lserver/jdbc/SQLServerDataSourceObjectFactory.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerDataSource.java
46.56% <100%> (ø)
68 <0> (ø)
:arrow_down:

.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java
77.22% <100%> (ø)
25 <0> (ø)
:arrow_down:

...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java
45.92% <100%> (ø)
30 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
44.92% <50%> (+2.03%)
105 <0> (+2)
:arrow_up:

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
45.47% <71.42%> (ø)
277 <0> (ø)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1dbacc...bc0f270. Read the comment docs.

Codecov Report

Merging #22 into JDBC4.3 will increase coverage by 0.1%.
The diff coverage is 31.03%.

@@             Coverage Diff              @@
##             JDBC4.3      #22     +/-   ##
============================================
+ Coverage      46.45%   46.56%   +0.1%
- Complexity      2211     2218      +7
============================================
  Files            108      108
  Lines          25363    25373     +10
  Branches        4177     4177
============================================
+ Hits           11783    11814     +31
+ Misses         11545    11531     -14
+ Partials        2035     2028      -7

Flag
Coverage Δ
Complexity Δ

#JDBC41
46.48% <31.03%> (+0.1%)
2215 <0> (+5)
:arrow_up:

#JDBC42
46.48% <31.03%> (+0.1%)
2212 <0> (+7)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java
12.8% <0%> (-0.11%)
9 <0> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.2% <0%> (+0.3%)
0 <0> (ø)
:arrow_down:

...ava/com/microsoft/sqlserver/jdbc/FailOverInfo.java
52.63% <0%> (ø)
0 <0> (ø)
:arrow_down:

...lserver/jdbc/SQLServerDataSourceObjectFactory.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java
88.33% <0%> (ø)
13 <0> (ø)
:arrow_down:

.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java
77.22% <100%> (ø)
25 <0> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerDataSource.java
46.56% <100%> (ø)
68 <0> (ø)
:arrow_down:

...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java
45.92% <100%> (ø)
30 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
44.92% <50%> (+2.03%)
105 <0> (+2)
:arrow_up:

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
45.47% <71.42%> (ø)
277 <0> (ø)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1dbacc...bc0f270. Read the comment docs.


RGB camera images from Carla client in Linux are not anti-aliased

RGB camera images from Carla client are not anti-aliased even when the main window renders with anti-aliasing.
This issue is similar to https://github.com/carla-simulator/carla/issues/1133 . But I am creating a new ticket to know the current status and plans for the future.
CARLA version: 0.9.14
Platform/OS: Ubuntu 22.04
Camera attributes:

Resolution: 1242 x 376
fov: 120
enable_postprocess_effects: True

Any Updates to this?


k2-e2e-aws-k8s-conformance doesn't work with k8s 1.6.x

Trying to be a good open source citizen and try alpha/beta testing the releases as they're getting cut.
https://pipelet.kubeme.io/job/k2-e2e-aws-k8s-conformance/187
20:13:24 + go run hack/e2e.go --v --test '--test_args=--ginkgo.v=true --ginkgo.noColor=true --ginkgo.focus=\[Conformance\] --ginkgo.skip=\[Serial\] --e2e-output-dir=/var/jenkins_home/jobs/k2-e2e-aws-k8s-conformance/workspace/output/artifacts --report-dir=/var/jenkins_home/jobs/k2-e2e-aws-k8s-conformance/workspace/output/artifacts' --check_version_skew=false
20:13:25 flag provided but not defined: -v
20:13:25 Usage of /tmp/go-build815977757/command-line-arguments/_obj/exe/e2e:
20:13:25   -get
20:13:25     	go get -u kubetest if old or not installed (default true)
20:13:25   -old duration
20:13:25     	Consider kubetest old if it exceeds this (default 24h0m0s)
20:13:25 2017/02/23 20:13:25 e2e.go:54: NOTICE: go run hack/e2e.go is now a shim for test-infra/kubetest
20:13:25 2017/02/23 20:13:25 e2e.go:55:   Usage: go run hack/e2e.go [--get=true] [--old=24h0m0s] -- [KUBETEST_ARGS]
20:13:25 2017/02/23 20:13:25 e2e.go:56:   The separator is required to use --get or --old flags
20:13:25 2017/02/23 20:13:25 e2e.go:57:   The -- flag separator also suppresses this message
20:13:25 2017/02/23 20:13:25 e2e.go:74: err: Cannot install kubetest until $GOPATH is set

Possible solutions:

set GOPATH
use kubetest directly (I have manually verified this works with older versions of k8s on my laptop)

Not urgent until we decide k2 needs to move to k8s v1.6.x

add labels of:
kraken-ci-jobs
priority-p1

This can be closed unless you have Reasons for it to remain open. The linked PR fixes this issue

oh, if its fixed then I don't care.  CLOSED.


Update case-app to 2.1.0-M11

Updates com.github.alexarchambault:case-app from 2.1.0-M10 to 2.1.0-M11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.alexarchambault", artifactId = "case-app" } ]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #2297.


[svg]: create LaunchIcon and CopyIcon

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guide

🎨 Wireframes and designs for Layer5 site in Figma (open invite)

Hello @nebula-aac , kindly assign this to me


Can't deploy hybridRunbookWorkerGroups without error

Bicep version
run bicep --version via the Bicep CLI, az bicep version via the AZ CLI or via VS code by navigating to the extensions tab and searching for Bicep
Bicep CLI version 0.4.1008 (223b8d227a)
Describe the bug
I am trying to deploy a hybrid worker group, hybrid worker, and then deploy the hybrid extension to a basic windows VM. When I go to run this code, The group successfully creates but throws an error.
resource hybrid_worker_group 'Microsoft.Automation/automationAccounts/hybridRunbookWorkerGroups@2021-06-22' = {
  name: 'HybridGroup1'
  parent: automation_test_acct
  dependsOn:[automation_credential
  ]
}

Error message
{"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"InternalServerError","message":"{\r\n  \"error\": {\r\n    \"code\": \"ResourceDeploymentFailure\",\r\n    \"message\": \"The response for resource had empty or invalid content.\"\r\n  }\r\n}"}]}}

Raw error
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
  "details": [
    {
      "code": "ResourceDeploymentFailure",
      "message": "The response for resource had empty or invalid content."
    }
  ]
}

So looking at the provider documentation here - https://docs.microsoft.com/en-us/azure/templates/microsoft.automation/2021-06-22/automationaccounts/hybridrunbookworkergroups?tabs=bicep#runascredentialassociationproperty
I need to reference a credential block. I do not need to do this in the portal though and it can be blank. I have tried just including a blank credential block, omitting the block and for the heck of it, deploying a credential and then referencing the credential in multiple ways (static name, referencing credential_test.name, credential_test.property.description) and then I get this error
resource automation_credential 'Microsoft.Automation/automationAccounts/credentials@2020-01-13-preview' = {
  name: 'unused'
  parent: automation_test_acct
  properties: {
    description: 'unused'
    password: 'username'
    userName: 'password123'
  }
}

output output2 string = automation_credential.name

resource hybrid_worker_group 'Microsoft.Automation/automationAccounts/hybridRunbookWorkerGroups@2021-06-22' = {
  name: 'HybridGroup1'
  parent: automation_test_acct
  credential: {
    name: automation_credential.properties.description
  }
  dependsOn:[automation_credential
  ]
}

{"status":"Failed","error":{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"InternalServerError","message":"{\r\n  \"error\": {\r\n    \"code\": \"ResourceDeploymentFailure\",\r\n    \"message\": \"The response for resource had empty or invalid content.\"\r\n  }\r\n}"}]}}

Additional context
I know this feature is in preview but trying to see if this is a problem with my bicep code or from what I can tell appears to be potentially a bug. any help is appreciated!

I also want to mention this code actually deploys the worker group but just throws the error mentioned above. It should succeed and move on :)
resource hybrid_worker_group 'Microsoft.Automation/automationAccounts/hybridRunbookWorkerGroups@2021-06-22' = {   name: 'HybridGroup1'   parent: automation_test_acct   dependsOn:[automation_credential   ] }

Some more info I've found.
The example ARM template found here. https://docs.microsoft.com/en-us/azure/automation/extension-based-hybrid-runbook-worker-install
if you load the code into VS code, the ARM template helper is complaining that the type field is wrong
`
      "name": "[concat(parameters('workerGroupName'),'/',guid('AzureAutomationJobName', variables('UniqueStringBasedOnTimeStamp')))]",
      "type": "hybridRunbookWorkerGroups/hybridRunbookWorkers",   //This line here!!!
      "apiVersion": "2021-06-22",
      "dependsOn": [
        "[resourceId('Microsoft.Automation/automationAccounts', parameters('automationAccount'))]",
        "[resourceId('Microsoft.Compute/virtualMachines', variables('vmName'))]"
      ],
      "properties": {
        "vmResourceId": "[resourceId('Microsoft.Compute/virtualMachines', parameters('virtualMachineName'))]"
      }
    }
  ]
},

`
Value must be one of the following values: "hybridRunbookWorkers"arm-template (schema)
type Resource type
Type: string
If I try to update this and run it as an arm template it fails.

An InternalServerError is a service-side bug and either means the resource provider service is down or in some bad state or there is a bug in the error handling logic. Are you able to open a support case to involve the AutomationAccount team?
The error you are getting on the ARM template you found is a result of a missing schema for that type and is not likely the cause of your issue.

Thank you. I have a support ticket open with Microsoft, I've sent a bunch of this detail to support but don't think the support engineer understands it as a provider issue as he doesn't know ARM templates/Bicep and is just pointing me at the FAQ and troubleshooting section on the automation account. I will escalate up when I get a response from my latest email. Thank you.

Awesome - please keep us updated on the resolution.

I have the exact same issue.
The group is successfully created but throws the same error.
note: this happens on most, but not every deployment.

The ms support engineer hasn't been very helpful with this. I basically have been waiting for almost 2 weeks for him to run the same steps in the ms documentation and confirm I'm not doing something wrong and alert the team responsible for the azure automation account API or confirm the issue is with bicep vs just ARM templates.

I have a similar issue with this extension in Terraform where the terraform provider for the automation account outputs the url for the autoMation account but this extension when you try to install it says that the url sent was not formatted correctly.
I was able to work around this by the way by running a custom script extension to run the powershell commands to register the server to the automation account.

I was found on official site following:
Create hybrid worker group
You can create a Hybrid Worker Group via the Azure portal. Currently, creating through the Azure Resource Manager (ARM) template is not supported.
So in reality creating Hybrid Worker Group by arm template works not as expected - group was created but with message:
Status Message: The response for resource had empty or invalid content.

I was going to add that I too an having the same issue, but if it's not supported then I guess we can't complain :-)
Kind of funny to think you can't fully automate and automation account ;-)


[DM-43950] First draft

Thak you so much Adam for the suggestions!

Thanks Eric! I've applied the suggestions and improved the text for clarity.


[BUG] ISO installation console can't correctly reflect the Harvester provisioning status

Describe the bug

Use ISO installation to provision Harvester, the console page always keep in Setting up Harvester and Setting up node

Actually we can access Harvester dashboard

The node status is Ready
harv14-241001:~ # kubectl get nodes
NAME            STATUS   ROLES                       AGE     VERSION
harv14-241001   Ready    control-plane,etcd,master   3h29m   v1.29.9+rke2r1

Pods are running well too

To Reproduce
Steps to reproduce the behavior:

Use ISO install to provision Harvester
Check the console page
Access Harvester dashboard
Access Harvester node

Expected behavior

The ISO install console should display the correct Harvester cluster and node status
Should not always keep in Setting up Harvester and Setting up node
Support bundle

supportbundle_da5ad14e-01a6-4d88-b96f-bd3a56a486b0_2024-10-01T14-58-34Z.zip
Environment

Harvester ISO version: v1.4-047b0468
Underlying Infrastructure: Single node kvm machine

That status is from these two conditions https://github.com/harvester/harvester-installer/blob/f6d189bfc828879096e28786cfd175ec5a439bab/pkg/console/dashboard_panels.go#L519-L524, which is from these two commands:

kubectl get no -o jsonpath='{.items[*].metadata.name}'
kubectl -n fleet-local get ManagedChart harvester -o jsonpath='{.status.conditions}' | jq 'map(select(.type == "Processed" and .status == "True")) | length'

BTW, it also shows Setting up xxx  in my local. It's okay with first command, but it showed 0 with second command.
kubectl -n fleet-local get ManagedChart harvester -o jsonpath='{.status.conditions}
=> [{"lastUpdateTime":"2024-10-01T04:21:09Z","status":"True","type":"Ready"},{"lastUpdateTime":"2024-10-02T08:13:47Z","status":"True","type":"Defined"}]

kubectl -n fleet-local get ManagedChart harvester -o jsonpath='{.status.conditions}' | jq 'map(select(.type == "Processed" and .status == "True")) | length'
=> 0

That value should be greater or equal to 1 in https://github.com/harvester/harvester-installer/blob/f6d189bfc828879096e28786cfd175ec5a439bab/pkg/console/dashboard_panels.go#L467-L473.
That means we lack one status called Processed. However, I'm not sure why it's missing.

Maybe it's related to we bump rancher to 2.9, @FrankYang0529 please take a look

This is also present in v1.4.0-rc1

Continue to provide more context.
In rancher/rancher v2.9.2 (In Harvester v1.4) and rancher/rancher v2.8.5 (In Harvester 1.3.2), both synced the bundle status to managedchart staus.
I found that rancher/rancher v2.8.5 uses rancher/fleet v0.9.5, and rancher/rancher v2.9.2 uses rancher/fleet v0.10.2.
The rancher/fleet v.0.9.5 sets the Processed status in https://github.com/rancher/fleet/blob/e06bc0170211485edded240c6260f339073d8018/internal/cmd/controller/controllers/bundle/controller.go#L66-L75.
It seems we should check other status fileds instead of Processed.
The rancher/fleet v0.10.2 doesn't use this RegisterBundleGeneratingHandler function anyone. It only used SetReadyConditions in https://github.com/rancher/fleet/blob/decbf9ae72eff096b2bee5efe05a92fdcbd5627d/internal/cmd/controller/reconciler/bundle_controller.go#L250

I added an refactor enhancement https://github.com/harvester/harvester/issues/6719, which was also requested before about an API endpoint to get the Harvester cluster information and status.

@w13915984028,
Just want to confirm should we need to wait for the enhancement https://github.com/harvester/harvester/issues/6719 to be merged to verify this issue. Many thanks.

@TachunLin No, the #6719 is not planned yet, PR https://github.com/harvester/harvester-installer/pull/858 has fixed this issue and it can be verified on v1.4.0, thanks.

Verified fixed on v1.4-a14e133-head (24/10/07). Close this issue.
Result
$\color{green}{\textsf{PASS}}$ Create mode installation $~~$

The ISO install console can display the correct Harvester cluster and node status, and can access Harvester dashboard well

$\color{green}{\textsf{PASS}}$ Join mode installation $~~$

The ISO install console can display the correct Harvester cluster and node status, and can access Harvester dashboard well

$\color{green}{\textsf{PASS}}$ Binary mode installation $~~$

The ISO install console can display the correct Harvester cluster and node status, and can access Harvester dashboard well

$\color{green}{\textsf{PASS}}$ Join mode in witness role installation $~~$

The ISO install console can display the correct Harvester cluster and node status, and can access Harvester dashboard well

Test Information

Test Environment: Single and two nodes harvester on kvm machines
Harvester version: v1.4-a14e133-head (24/10/07)

Verify Steps
Create mode installation

Trigger ISO installation
Select create mode
Complete the installation process
Check the console installation status
Check can access the Harvester dashboard

Join mode installation

Already have a management role cluster
Trigger ISO installation
Select join mode
Complete the installation process
Check the console installation status
Check can access the Harvester dashboard

Binary mode installation

Already have a management role cluster
Trigger ISO installation
Select binary mode
Complete the installation process
Check the console installation status
Check can access the Harvester dashboard

Join mode in witness role installation

Already have a management role cluster
Trigger ISO installation
Select join mode
Select the witness role
Complete the installation process
Check the console installation status
Check can access the Harvester dashboard


cmd/cue: vet with non-CUE files doesn't mention which non-CUE file is missing required fields

What version of CUE are you using (cue version)?

$ cue version
cue version v0.6.0-rc.1

go version go1.20.6
      -buildmode exe
       -compiler gc
       -trimpath true
     CGO_ENABLED 0
          GOARCH amd64
            GOOS linux
         GOAMD64 v1

Does this issue reproduce with the latest stable release?
n/a (required fields not available <0.6)
What did you do?
! exec cue vet schema.cue 1.yml
stderr 1\.yml
-- schema.cue --
required!:  string
optional?: bool
-- 1.yml --
optional: true

(Whilst working in the same sphere that led to my opening #2511):
I noticed that when cue vet is vetting non-CUE files, and one of those non-CUE files is missing a required field, cue vet produces an error that only mentions the CUE file(s) that are in scope. It doesn't mention the non-CUE file that's at fault.
What did you expect to see?
I expected to see some mention of the non-CUE file that failed to satisfy vet when unified with the CUE that's in scope. I expected this because when I'm vetting multiple non-CUE files I need to see which of them are missing required fields, notwithstanding #2511's limit.
What did you see instead?
$ testscript no-filename-mentioned.txtar
> ! exec cue vet schema.cue 1.yml
[stderr]
required: field is required but not present:
    ./schema.cue:1:1
[exit status 1]
> stderr 1\.yml
FAIL: /tmp/testscript1585510356/no-filename-mentioned.txtar/script.txtar:2: no match for `1\.yml` found in stderr
error running no-filename-mentioned.txtar in /tmp/testscript1585510356/no-filename-mentioned.txtar

Replicated with v0.8.0

Can we in general know that a specific file is "at fault" where a field is missing? Perhaps in some situations, but it's not clear to me that we can know this in all situations.
For example:
! exec cue vet schema.cue 1.yml 2.yml

-- schema.cue --
required!:  string
optional?: bool
-- 1.yml --
optional: true
-- 2.yml --
other: true

Can we in general know that a specific file is "at fault" where a field is missing?

Given that each data file is vetted in isolation, I believe we can - at least with regards to required fields.

Perhaps in some situations, but it's not clear to me that we can know this in all situations.
For example:
! exec cue vet schema.cue 1.yml 2.yml
-- schema.cue --
required!:  string
optional?: bool
-- 1.yml --
optional: true
-- 2.yml --
other: true

I'd expect both files to be flagged up as missing the required field.

Given that each data file is vetted in isolation

Ah yes, that's the "edge" I keep forgetting about. We should link this issue to the issue where we discuss whether/how that should remain inconsistent with the behaviour of cue export etc with respect to non-CUE files.

This also strikes in the following cue cmd context, under CUE v0.9.0-alpha.5:
! exec cue cmd exampleCommand
cmp stderr out
-- a_tool.cue --
package example

import (
	"time"
	"encoding/json"
	"tool/http"
	"tool/cli"
)

command: exampleCommand: {
	fetch: http.Get & {
		url<EMAIL_ADDRESS>	}
	validate: json.Unmarshal(fetch.response.body) & #Schema
	display: cli.Print & {
		text: json.Marshal(validate)
	}
}

#Schema: {
	Version!:   string
	Time?:      time.Time
	aBogusField!: string // this field isn't present in the JSON fetched over HTTP
	...
}
-- out --
command.exampleCommand.display.text: invalid string argument: field is required but not present:
    ./a_tool.cue:15:2
    ./a_tool.cue:14:50
    ./a_tool.cue:16:3
    ./a_tool.cue:23:2
    tool/cli:4:3

There's nothing specific about the use of the HTTP source, but this is the context in which I've experienced the issue striking.
This issue renders the simple implementation of a "fetch some remote data and validate it" workflow command ineffective. Whilst it might be worked around using more complicated CUE, I feel this implementation should be achievable.

This also strikes in the following cue cmd context, under CUE v0.9.0-alpha.5:

Please create a separate issue for this. It's not immediately obvious that it's the same issue.

Please create a separate issue for this. It's not immediately obvious that it's the same issue.

https://github.com/cue-lang/cue/issues/3186 opened.


About specificity_at_sensitivity metric

🚀 Feature
The metric SpecificityatSensitivity returns Tuple.
Is it aligned with the general structure of Torchmetrics? Generally, single metric is returned.

I think returning tuple breaks lightning integration, since it expects a single metric value to be returned.
Can we introduce a return_thresholds parameter to the constructor of the metric to control this behavior?

@awaelchli We need your experience here :) Do you have an idea or do you know somebody who can have an idea on the general structure of torch metrics.
@ozen Seems like a good idea.

@oguz-hanoglu @ozen I assume you are talking about the self.log feature in Lightning, that can accept a metric object as input, and will evaluate it automatically?
I think there will always be some "metrics" that produce a non-scalar. For example, the confusion matrix is a very useful "metric" in torchmetrics and it outputs a NxN tensor. So in regards to torchmetrics yes, I think it is generally acceptable to have them return non-scalars.
For Lightning, we don't have a good way to handle this right now and it is not in scope at the moment. We would need to brainstorm this on a feature request and see if there is enough demand for this.
The user today shouldn't be blocked by this though. It's always possible to evaluate the metric separately and either unpack the tuple and then log whatever you want with self.log(), or further process the non-scalar output and visualize it in a different way.
These are my quick thoughts :)

Whether it makes sense to add an argument to BinarySpecificityAtSensitivity like @ozen, I have no objections but leave it up to torchmetrics team to decide :))

@awaelchli thanks for the clarification.
Computing SpecificityAtSensitivity at batch level doesn't make sense, and unnecessarily adds the cost of computing the ROC curve.
Also, it doesn't perform a reduction like mean or sum.
So a possible workaround, I think, is to use metric.update() and not to use self.log() in the step method, and to use metric.compute() and metric.reset() in the epoch end hook.
So, basically, we cannot use the torchmetrics feature of self.log().


Scoped storage for CameraX

Hello,
I am using this library for picking images and it works great.. I also need to use the Camera (CameraX) feature,but it is using the old storage model (legacy storage & needs write permission too),it would be great if you consider upgrading it anytime soon,so the image file can be saved in public image directory (DCIM,PICTURES) by not using legacy storage, MediaStore can allow it.
Thank you.

Ok I will keep it in my mind

Ok I will keep it in my mind

Hi,
I made changes and updates to the project and tested in Oreo and Q (should work in R too)

CameraX saves image via MediaStore
Crop Image saves Cropped image via MediaStore
Compress Image saves image via MediaStore
No need of read/write storage permission.
ExifInterface (unchanged)
Using ViewBinding

Hi,
I made changes and updates to the project and tested in Oreo and Q (should work in R too)

CameraX saves image via MediaStore
Crop Image saves Cropped image via MediaStore
Compress Image saves image via MediaStore
No need of read/write storage permission.
ExifInterface (unchanged)
Using ViewBinding

That's great
ok that's great. create a pull request. I will merge it.

That's great
ok that's great. create a pull request. I will merge it.

That's great
ok that's great. create a pull request. I will merge it.
Plz, remove view binding. It is good but it creates extra classes that will increase the size of the library

Okay sure, but kotlin-android-extensions & parcelable is deperecated

That's great
ok that's great. create a pull request. I will merge it.
Plz, remove view binding. It is good but it creates extra classes that will increase the size of the library

Okay sure, but kotlin-android-extensions & parcelable is deperecated

Please make a pull request to dev branch

Please make a pull request to dev branch

Did you test carefully. Android Lollipop to Android 10??

Did you test carefully. Android Lollipop to Android 10??

Tested in

Lenovo Vibe K5 Plus,K8 Note (API 21 Lollipop,Api 26 Oreo)
MicroMax (API 24 Nougat)
Realme Narzo 20 (API 29,Q)

But I haven't changed code for devices lower than Q :-)
Things that need to be worked more in this lib -

ExifInterface (with the updated lib), there were some debug message like W/ExifInterface: Invalid image: ExifInterface got an unsupported image format file(ExifInterface supports JPEG and some RAW image formats only) or a corrupted JPEG file to ExifInterface., new androidx lib supports png now..Sometimes it was maybe this issue https://github.com/bumptech/glide/issues/3851

Update Readme for read/write permission below Q,because exif data needs permission..In Android Q this may become an issue because of Scoped Storage it may be helpful - https://developer.android.com/training/data-storage/shared/media#location-info-photos

Tested in

Lenovo Vibe K5 Plus,K8 Note (API 21 Lollipop,Api 26 Oreo)
MicroMax (API 24 Nougat)
Realme Narzo 20 (API 29,Q)

But I haven't changed code for devices lower than Q :-)
Things that need to be worked more in this lib -

ExifInterface (with the updated lib), there were some debug message like W/ExifInterface: Invalid image: ExifInterface got an unsupported image format file(ExifInterface supports JPEG and some RAW image formats only) or a corrupted JPEG file to ExifInterface., new androidx lib supports png now..Sometimes it was maybe this issue https://github.com/bumptech/glide/issues/3851

Update Readme for read/write permission below Q,because exif data needs permission..In Android Q this may become an issue because of Scoped Storage it may be helpful - https://developer.android.com/training/data-storage/shared/media#location-info-photos

There is a duplication while capturing an image and compressing it.  Why didn't you solved it?. Why did you copy the image to internal storage.

There is a duplication while capturing an image and compressing it.  Why didn't you solved it?. Why did you copy the image to internal storage.

There is a duplication while capturing an image and compressing it. Why didn't you solved it?. Why did you copy the image to internal storage.

When I used the lib in my app,there existed that issue..If you try to delete the original image file you won't get the imageview but you get the uri of latest compressed image..So,if its seems okay to not have the imageview set,we can just revert and call the delete(savedUri) to delete the original image and get only one image (compressed one)
Lets continue the conversation somewhere else instagram or fb or anywhere you want.. Insta - idevelop.around & Fb - Jayant Navrange

There is a duplication while capturing an image and compressing it. Why didn't you solved it?. Why did you copy the image to internal storage.

When I used the lib in my app,there existed that issue..If you try to delete the original image file you won't get the imageview but you get the uri of latest compressed image..So,if its seems okay to not have the imageview set,we can just revert and call the delete(savedUri) to delete the original image and get only one image (compressed one)
Lets continue the conversation somewhere else instagram or fb or anywhere you want.. Insta - idevelop.around & Fb - Jayant Navrange


Font Ligatures Stopped Working

When I opened my VS Code this morning, my font ligatures stopped working, my font in my files is not right and the font in my integrated terminal had dramatically changed. I was able to get the integrated terminal back to some sense of normalcy, but I've attempted to find the solutions posted for the font ligatures and font with no luck. My relevant config info is below:
{
    "workbench.colorTheme": "Night Owl Light",
    "editor.fontFamily": "Fira Code",
    "editor.fontLigatures":true,
    "editor.fontSize": 15,
    "files.autoSave": "afterDelay",

}

In the "Fira Code" Wiki they suggest to wrap the font name with additional apostrophes, if something doesn't work out. Maybe it'll fix the problem.
"editor.fontFamily": "'Fira Code'",

Link to the wiki:
https://github.com/tonsky/FiraCode/wiki/VS-Code-Instructions#manually-editing-settingsjson

I'm experiencing the same issue as of today using the Fira Code font. It seems like the font has stopped working completely (not only the ligatures).
Other font settings still work in VS Code:

'Times new roman', Consolas
Times new roman, Consolas

And the Fira Code font is correctly installed on my system, I can use it without problems (and with ligatures) in other apps.
VSCode setup:
Version: 1.43.2 (user setup)
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.17763

I just tested it on another system with the following two setups:
Version: 1.43.1 (system setup)
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:20.184Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

Version: 1.43.2 (system setup)
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

Both times it worked fine. The only difference I see is that on the system from my first comment, I was using WSL and on this system I'm not.
For the WSL setup I had the font installed in both the host and the Linux subsystem.

@sw8wm2013 What OS and version of VS Code are you using?
@eddex When using  WSL + remote WSL, the window rendering VS Code executes on the Windows side, so the font needs to be installed on the Windows side. Using remote WSL would not influence this in any way, so I believe there might be something else to it.

@eddex When using WSL + remote WSL, the window rendering VS Code executes on the Windows side, so the font needs to be installed on the Windows side. Using remote WSL would not influence this in any way, so I believe there might be something else to it.
If I start VS Code without WSL the problem still exists, so you're right, it has nothing to do with WSL.

@eddex AFAIK the user/system VS Code installation does not influence font lookup done by Chromium. May I kindly suggest that you uninstall the font, and then follow the installation directions on the official font page and install again?

@alexdima thanks for the tip!
When I searched the installed fonts, I noticed, that the font was not showing up anymore. I re-installed the font and at this point a popup notified me that the font is already installed (even tho it was not listed as installed).
After installing the font again, it works as expected in VS Code.
I now installed the font for all users (right click -> Install for all users) becuase I expect it may have been removed by some company policy.

@sw8wm2013 Do you still have the issue? Can you please try to reinstall the font?


Fix testing docs indentation

Description
A tab is converted to 8 spaces. So it is better to use only spaces for indentation.

Checklist:

[x] Securely signed commits
[n/a] Component(s) with PHPdocs
[n/a] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

@paulbalandan Yes.


Remove repeated hardware during cluster upgrade

Issue #3447
Description of changes:
Adding logic to remove list of provisioned hardware objects obtained from the management cluster during cluster upgrade. This prevents prevents the scenario where user had provisioned hardware in their hardware.csv input from getting applied and messing up the cluster.
Testing:
Tested different use cases where user provides varied inputs.
./eksctl-anywhere upgrade cluster -f ./tink/tink-eks-a-cluster.yaml

./eksctl-anywhere upgrade cluster -f ./tink/tink-eks-a-cluster.yaml -z hardware.csv

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/lgtm


[FEAT]: Real Time OCR via webcam connected to a Nvidia Jetson board.

What would you like to see?
I have a Nvidia Jetson AGX Orin with AnythingLLM on docker. It will nice to have a Real Time OCR feature where using a webcam connected:

AnythingLLM can recognize objects, text, etc, using a webcam
AnythingLLM can show/import actual text from an image in real time.

PS...you all have a Happy New year 2025.!!

While i can appreciate the desire to have something like that as a tool, it is certainly out of scope of AnythingLLM in terms of its vision. For something like this you would be better suited running a standalone tool for this kind of feature!
There are tons of YOLOv8 or opencv python scripts that can stand this up for you in only a few minutes. Happy new years as well!


update to fix plotting in matplotplib + pandas plotting.

As described in the issues #888  and #837 , upon the release of 3.1.0, a side effect of importing pandas_profiling was that it overrode the existing backend of matplotlib on import, and prevented plots from being rendered in Jupyter environments.
Since it seems the backend does not needed to be set per matplots documentation,

By default, Matplotlib should automatically select a default backend which allows both interactive work and plotting from scripts, with output to the screen and/or to a file, so at least initially you will not need to worry about the backend.

Using matplot.libuse() will require changes in your code if users want to use a different backend. Therefore, you should avoid explicitly calling use unless absolutely necessary.

and it is generally a best practice to not have side effects upon importing a package, I have elected to remove that line.
A new test is in place in notebooks/notebook_plotting.ipynb to prevent this in the future.

@jodom961 this looks great thank. Would be nice to get a review from a maintainer here.

Hi @jodom961, thanks for your analysis and fix of the issue! The fix is already included in the v3.2.0 release (shoutout to you in the changelog), however the test would still add value.
If you're interested, then please rebase on develop and squash the commits with a message accepted by convential commit (e.g. test: matplotlib backend side-effects).

@sbrugman sure! will rebase + update with the tests..


Remove HTML font size setting

The font size currently set on the html element will be removed so that the browsers setting will be used.

Completed.