Investigate GH rate limiting

Look into the GH rate limiting and what we can do about it, ie new bot account, reduce number of calls, reduce number of CI runs, etc

You can use the built-in GITHUB_TOKEN to authenticate requests in GitHub Actions workflows. For more information, see "Automatic token authentication."
When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

The GraphQL API also has a custom rate limit that is separate from and calculated differently than rate limits in the REST API.
Query how many calls remaining per user:
curl
-H "Authorization: bearer GH_TOKEN"
-H "Accept: application/vnd.github.v3+json"
https://api.github.com/rate_limit

The GraphQL API v4 limit is different from the REST API v3's rate limits. The GraphQL API v4 rate limit is 5,000 points per hour. Note that 5,000 points per hour is not the same as 5,000 calls per hour: the GraphQL API v4 and REST API v3 use different rate limits.

limit:
curl -H "Authorization: bearer GH_TOKEN" -X POST -d " { "query": "query { rateLimit { limit }}" } " https://api.github.com/graphql
remaining:
curl -H "Authorization: bearer GH_TOKEN" -X POST -d " { "query": "query { rateLimit { remaining }}" } " https://api.github.com/graphql
used
curl -H "Authorization: bearer GH_TOKEN" -X POST -d " { "query": "query { rateLimit { used }}" } " https://api.github.com/graphql
query {
viewer {
login
}
rateLimit {
limit
cost
remaining
resetAt
}
}

You can use the GITHUB_TOKEN by using the standard syntax for referencing secrets: ${{ secrets.GITHUB_TOKEN }}

The GITHUB_TOKEN secret is basically a GitHub App installation access token.

The GITHUB_TOKEN instead expires just right after the job is over. So even if someone is able to steal it (which is almost impossible), they basically can't do anything wrong.

Applied the ${{ secrets.GITHUB_TOKEN }} to these repo and files:
Operations Engineering
archive-repos.yml
remove-duplicated-repository-access.yml
github-collaborators
approved-email-check.yml
deleted-repos.yml
post-data.yaml
remove_large_number_collaborators.yaml
report-terraform-difference.yml
repository-check.yaml
github-repository-standards
post-report-data.yml

attempted the token ${{ secrets.GITHUB_TOKEN }}  on ours repo's but it doesnt have org settings which is required by most of the scripts. This is still a good token to use where the above permissions types are used.

The alternative solution is to use the above curl commands to find out the remaining API rate and wait till the refresh time if the limit is near being reached

Ben suggested and implemented reducing the number of times a CI action is run to reduce the token usage

Checked the last 3 months of CI runs and there not that many rate limit failures, it is more likely to happen locally when doing prototyping and debugging.
With the new slack alerts for CI failures we can keep an eye if rate limit failures occur often enough in the future to warrant adding preventative code into the existing python and ruby scripts


Implement a Query Builder similar to SQL Developer

This feature would expand Omni's user-base to non-technical users or users with no SQL experience.
[https://docs.oracle.com/cd/B25329_01/doc/appdev.102/b25309/qry_bldr.htm](Oracle Docs - Building Queries with Query Builder).

Yes, it would be very useful, thank you for your suggestion! :+1:


Socat uses 100% when odoo is stopped

When using this in doodba-scaffolding and stopping socat sometimes uses 100% of the CPU:
top - 10:06:13 up  1:59,  4 users,  load average: 3,31, 4,00, 4,01
Tasks: 530 total,   5 running, 393 sleeping,   0 stopped,   0 zombie
%Cpu(s):  4,8 us,  7,3 sy,  0,0 ni, 87,9 id,  0,0 wa,  0,0 hi,  0,0 si,  0,0 st
KiB Mem : 32937164 total,  9793444 free, 10869704 used, 12274016 buff/cache
KiB Swap: 33484796 total, 33483260 free,     1536 used. 20933540 avail Mem

  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
26513 root      20   0   14584    360      0 R 100,0  0,0  10:40.81 socat tcp-listen:8069,fork,reuseaddr tcp-connect:odoo:8069

Currently the image is using socat version <IP_ADDRESS> (from 2016):
bigbear3001@wt-io-it-bigbear3001:~$ docker run tecnativa/whitelist socat -V
socat by Gerhard Rieger - see www.dest-unreach.org
socat version <IP_ADDRESS> on Apr 29 2016 22:10:44
   running on Linux version #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019, release 4.15.0-54-generic, machine x86_64
features:
...

It seems that <IP_ADDRESS> (from 2017) whould fix this issue: http://www.dest-unreach.org/socat/.
Would it be ok to have a patch where socat is installed from tar.gz instead of from the alpine repos? or upgrade to alpine 3.6 which would have this version i guess:
https://pkgs.alpinelinux.org/package/v3.6/main/ppc64le/socat

@Yajo is on holidays. He will answer when he comes back.

@pedrobaeza thanks for the info
just rebuilding the image should be enough to solve this (i get socat version <IP_ADDRESS> when i build the image on my local system)

I triggered a rebuild in the Docker Hub, thanks for the report.


Support for CodeCov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e64b14d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage          ?   67.09%
=========================================
  Files             ?       20
  Lines             ?     1252
  Branches          ?        0
=========================================
  Hits              ?      840
  Misses            ?      412
  Partials          ?        0

Flag
Coverage Δ

#KituraNet
67.09% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e64b14d...cbeb4e5. Read the comment docs.


Fixed version of 842a475: Remove a wrong test for copyAnnotations return...

Concerning 842a475: You've misunderstood me. My point was that copyAnnotations itself can return null and then you'll get an NPE in testing for zero length. But you were right with reverting it, as I made a mistake: copyAnnotations could return both null and a zero-length array! So a null-safe emptiness test would be needed. That's plain wrong.
So I sort of un-reverted it and made copyAnnotations never return a zero-length array, so we don't need the test.
IMHO every method should do exactly what's needed and Eclipse being insane should not make us insane.
OK, FORGET IT. I'm pretty sure, I'm right, but it's not that important.

Right, well, the problem is, this behaviour, while its a thing I can imagine one would like to do, isn't actually what Tolerate is documented as doing.
Also, this closes another exotic use-case which is:  You wrote an equals() method that is not the 'real' equals (parameter type isn't j.l.Object) and you'd like lombok to ignore it.
We'd have to document this. While the behaviour of this pull request is sensible enough, trying to document it is mostly going to read as confusing gobbledygook which is unfortunate.
If you're still interested in this feature, what's the use case? When would you like a lombok-generated equals while writing your own hashCode, and when would you like a lombok-generated hashCode while writing your own equals? What about canEqual?

Concerning documentation, for me adding "as much as it can makes sense" to the existing documentation would do.
Fineprint: 1. If generating a method would lead to an error and Lombok knows it, it never generates it. 2. Otherwise, it ignores existing method annotated with @Tolerate. 3. Otherwise, an existing equally-named method with the same number of arguments stops Lombok from generating a method. 4. Moreover, if there is any method named either hashCode or equals, regardless of return type, no methods will be generated, and a warning is emitted instead.
Note that I tried to summarize all suppressions due to existing methods. Rule 2 is the explanation of what @Tolerate is good for, rule 1 is just a sanity rule making it more usable. For me, both feel natural and are trivial to remember. Not knowing them can never lead to unexpected errors.
Actually, I'd probably extend the Tolerate documentation and replace all mentioning of suppressions due to an existing thing by a link.
Concerning use cases, I'd actually prefer my hashCode to be always deterministic. This may be a non-common need, but then it gets hard, as two important cases stay in the way, namely enums and Classes. So while the requirement might be a bit exotic, the obstacles are rather abundant. I could imagine @EQHC(moreDeterministic=true) handling these two obstacles, but I'm afraid the demand is not high enough.
Also some manual caching of hashCode makes sense. A corresponding Lombok feature would be even better, but there are many options (precomputation or caching, support for other methods, possibly methods with arguments, etc.) and it doesn't exist yet. I'd personally be happy with a hash code precomputation (faster than caching and good enough for immutables), additionally used in equals as the very first thing to compare.
Someone could want to exclude some fields from hashCode for performance reasons, but not from equals (for correctness). This may be the case for large arrays or lists or dependent fields.
I can't imagine someone letting hashCode to be generated and writing equals manually (doing just the more tedious part) and canEqual is probably too rare to care about.


refactoring of internal/table.Client.CreateSession retryer usage

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 40.74%. Comparing base (b84477e) to head (03f4605).

Files with missing lines
Patch %
Lines

internal/table/client.go
0.00%
20 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (b84477e) and HEAD (03f4605). Click for more details.
HEAD has 122 uploads less than BASE

Flag
BASE (b84477e)
HEAD (03f4605)

go-1.22.x
12
2

unit
18
4

ubuntu
26
2

macOS
6
2

go-1.21.x
12
2

go-1.23.x
14
0

integration
18
0

ydb-23.3
6
0

windows
6
0

ydb-24.1
6
0

ydb-24.2
6
0

ydb-nightly
2
0

experiment
2
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1494       +/-   ##
===========================================
- Coverage   66.86%   40.74%   -26.12%
===========================================
  Files         353      350        -3
  Lines       36676    30790     -5886
===========================================
- Hits        24523    12546    -11977
- Misses      11071    17739     +6668
+ Partials     1082      505      -577

Flag
Coverage Δ

experiment
?

go-1.21.x
42.05% <0.00%> (-25.05%)
:arrow_down:

go-1.22.x
40.74% <0.00%> (-24.10%)
:arrow_down:

go-1.23.x
?

integration
?

macOS
40.71% <0.00%> (-0.05%)
:arrow_down:

ubuntu
40.73% <0.00%> (-30.42%)
:arrow_down:

unit
40.74% <0.00%> (-0.45%)
:arrow_down:

windows
?

ydb-23.3
?

ydb-24.1
?

ydb-24.2
?

ydb-nightly
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unhandled exception if graylog goes down

If the graylog server goes down then
Unhandled exception. System.Net.Internals.SocketExceptionFactory+ExtendedSocketException (00000005, 0xFFFDFFFF): Name or service not known
at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, ValueStopwatch stopwatch)
at System.Net.Dns.<>c.b__33_0(Object s, ValueStopwatch stopwatch)
at System.Net.Dns.<>c__DisplayClass39_01.<RunAsync>b__0(Task <p0>, Object <p1>)    at System.Threading.Tasks.ContinuationResultTaskFromTask1.InnerInvoke()
at System.Threading.Tasks.Task.<>c.<.cctor>b__272_0(Object obj)
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
at Serilog.Sinks.Graylog.Core.SinkComponentsBuilder.GetIpAddress(String hostnameOrAddress)
at Serilog.Sinks.Graylog.Core.SinkComponentsBuilder.MakeTransport()
at Serilog.Sinks.Graylog.GraylogSink.<>c__DisplayClass3_0.<.ctor>b__0()
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode) --- End of stack trace from previous location ---    at System.Lazy1.CreateValue()
at Serilog.Sinks.Graylog.GraylogSink.Dispose()
at Serilog.Core.Sinks.RestrictedSink.Dispose()
at Serilog.LoggerConfiguration.<>c__DisplayClass32_0.g__Dispose|0()
at Serilog.Core.Logger.Dispose()
at Program.$(String[] args) in /home/daniel/Work/DataApiTools/dataapi-soak/Program.cs:line 71
at Program.(String[] args)

Okay and what?

Well I would rather not have to put try catches around every single logging statement in my code in order to handle a connection loss to my logging server.


Fix broken links in the documentation folder

Please see #670, #660, #638, #679, #671, #662, and #691. See also #773. This works as expected. No PR necessary. :smile:


Hi Team, Recently I started with the SPFx with angular and I am facing issues while integrating angular UI framework "PrimeNG". Could you please any one help me to use PrimeNG library in SPFx angular web part.

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
(DELETE THIS PARAGRAPH AFTER READING)

Category

[x] Question
[ ] Typo
[x] Bug
[x] Additional article idea
[ ] Example checked item (delete this line)

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
If you are planning to share a new feature request (enhancement / suggestion), please use SP Dev UserVoice at https://aka.ms/sp-dev-uservoice. (DELETE THIS PARAGRAPH AFTER READING)
(DELETE THIS PARAGRAPH AFTER READING)

Expected or Desired Behavior

If you are reporting a bug, please describe the expected behavior. If you are suggesting an enhancement please describe thoroughly the enhancement, how it can be achieved, and expected benefit.
(DELETE THIS PARAGRAPH AFTER READING)

Observed Behavior

If you are reporting a bug, please describe the behavior you expected to occur when performing the action. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Steps to Reproduce

If you are reporting a bug please describe the steps to reproduce the bug in sufficient detail to allow testing. Only way to fix things properly, is to have sufficient details to reproduce it. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Submission Guidelines

All suggestions or bugs are welcome, please let us know what's on your mind.
If you are reporting an issue around any of the documents or articles, please ensure that you have clear > reference on the specific file or URL, which should be fixed.
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and > #spfx-tooling on (SharePoint StackExchange)[http://sharepoint.stackexchange.com/]. You can also > alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.

(DELETE THIS PARAGRAPH AFTER READING)

Thanks for your contribution! Sharing is caring.

Closing this due to non-actionable...

please use the issue sections provided to submit an issue
this isn't a forum for "help me with my problem" open-ended questions like this... if you have a specific issue, please provide details... IOW: help us help you
this isn't a bug... you can use SPFx does nothing to block use of 3rd party components


Fixed bug in NT macro

I came across this bug. I don't understand it deeply, but it is there.
For the test code I provided lookup.keySet and tpes are different. The types differ in their ? part. I solved it by a fallback that uses proper equality.
Please let me know if I can improve something in this PR.

Looks good to me. Just one question about the specific implementation choice.

I added a commit that simplifies the lookup. I am not sure how to run benchmarks to check the performance, but it doesn't seem like it should change noticably.

Compile time performance should be negligible in this situation. I'd prefer to have the cleanest code possible, since Iota is already a difficult enough due to the extensive macro use!

Thank you again for all of your contributions!


Voice entry demo

Basic demo starting point. Doesn't do anything useful yet
Demo running on Comma 3 device:
https://github.com/commaai/openpilot/assets/83676301/5a5f5349-60bc-4f1d-a199-1f1276422997

Offline wake words and speech to text/text to speech are pretty nice right now due to Home Assistant's year of voice:
https://www.home-assistant.io/blog/2022/12/20/year-of-voice/
I found one model that'll run via ONNX, which should be accelerated by the comma 3/x
Would be interested to see how reliable it is over LTE!

@jnewb1 can you try this out in a car?

tried it in a car, looks pretty good! openpilot seems to run fine with it running, I will check some cpu stats soon. couple things

noticed the last word takes a bit longer in the live view, is that just a display issue or something with the API?
have you experimented with making a custom wake word (like "hey comma"?)

https://www.youtube.com/watch?v=TGMpwqr3r08
either way, this certainly fulfills the bounty qualifications!

Thank you for testing it. I am glad you liked it!

have you experimented with making a custom wake word (like "hey comma" or just "comma"?)

That requires training a new model which I am not familiar with doing but it is well documented here.

noticed the last word always takes a bit longer in the live view, is that just a bug in the display or something with the API?
final parsing to get the full phrase seems to take 5 seconds, can we reduce that?

Yes, there are ways to decrease latency but there are some tradeoffs. you can read the docs here but here are the important parts. https://docs.rev.ai/api/streaming/requests/#raw-file-content-type
max_segment_duration_seconds: This parameter potentially changes the amount of context our engine has when creating final hypotheses and therefore has a minor effect on word error rate. Higher values correlate with fewer errors in transcription.
skip_postprocessing=true: Only available for English and Spanish languages You can choose to skip post-processing operations, such as inverse text normalization (ITN), casing and punctuation, by adding skip_postprocessing=true to your request. Doing so will result in a small decrease in latency; however, your final hypotheses will no longer contain capitalization, punctuation, or inverse text normalization (for example, five hundred will not be normalized to 500).
And lastly, I am sending 80ms binary chunks instead of 250ms chunks. This should be fairly easy to change by concatenating chunks from the audio_queue.
I originally used Google's api and it was faster! you can see my google API implementation here There may be optimizations if you select a different model from rev.ai but I am not sure. You could change the api provider fairly easily as long as it supports streaming.

@jnewb1 Can you send interac e transfers?

@jnewb1 Can you send interac e transfers?

What?

@jnewb1 Can you send interac e transfers?

What?

Like for the bounty payout. Do you guys do PayPal or e-transfer or something else?

@jnewb1 Can you send interac e transfers?

What?

Like for the bounty payout. Do you guys do PayPal or e-transfer or something else?

https://github.com/commaai/openpilot/blob/master/docs/BOUNTIES.md#rules

@jnewb1 Can you send interac e transfers?

What?

Like for the bounty payout. Do you guys do PayPal or e-transfer or something else?

https://github.com/commaai/openpilot/blob/master/docs/BOUNTIES.md#rules

Ok if thats the case id like to do a few more and save up for a comma body!

Thank you sounds good!

tried it in a car, looks pretty good! openpilot seems to run fine with it running, I will check some cpu stats soon. couple things

noticed the last word always takes a bit longer in the live view, is that just a bug in the display or something with the API?
have you experimented with making a custom wake word (like "hey comma" or just "comma"?)
final parsing to get the full phrase seems to take 5 seconds, can we reduce that?

https://www.youtube.com/watch?v=TGMpwqr3r08
either way, this certainly fulfills the bounty qualifications!

I emailed rev AI about the latency. They said they will fix the issue.
Here is the email exchange:
I am developing speech to text for Openpilot, a self driving add-on system. I have chosen to use rev AI because of its ease of authentication and simple API. On issue I am facing is the delay between the interim and final results. For example if the user says "Navigate to home", the interim result will return "navigate to" immediately and it will take about 8 seconds for it to return the full final result "Navigate to home".
Using your streaming demo on your website it's very fast and I would like the same performance.I am using the python API SDK. I am recording 80ms chunks of audio. I tried sending 250ms chunks but it doesn't make a difference.
Reply from support:
The team does have an idea of how they can improve your experience. The issue is it is going to be weeks before they can implement it. At minimum, 2 weeks. Possibly longer if something more urgent comes up. As I understand it, they need to code the ability to disable overlaps and apply it to your account specifically. Given your responses will all likely be short, the overlap is what is holding things up. This is not something we have built yet, but they think it can be done. I am keeping your ticket open so I can circle back to you once I have confirmation this has happened.


[.NET] String only Inlines are round-tripped as full TextRuns

Platform

.NET

Author or host
Are you an author (like sending something to Outlook), or a host that is rendering your own cards? Author
If you're an author, who are you sending cards to?
A console app
Version of SDK
NuGet 1.2.4
Details
A rich text block can have strings instead of text runs in its inlines property. However, the strings get deserialized into text runs because the .NET library treats the inlines property as a List<IAdaptiveInline> (which can't contain strings of course). The only type that implements IAdaptiveInline is TextRun so strings have to be deserialized as text runs, but then they can't be reserialized as strings.
var json = "{'type':'AdaptiveCard','version':'1.0','body':[{'type':'RichTextBlock','inlines':['Inline string']}]}";
var card = AdaptiveCard.FromJson(json).Card;

Console.WriteLine(card.ToJson());
// {
//   "type": "AdaptiveCard",
//   "version": "1.0",
//   "body": [
//     {
//       "type": "RichTextBlock",
//       "inlines": [
//         {
//           "type": "TextRun",
//           "text": "Inline string"
//         }
//       ]
//     }
//   ]
// }

I can see two ways to fix this:

Automatically serialize text runs as strings if the only populated property is text.
Create a new type that implements IAdaptiveInline to represent strings.

@RebeccaAnne can you take a look at this one to investigate ?

@v-kydela, can you tell me more about the scenario where the current behavior causes problems for you? The string version of the inline is meant as a convenience for card authors, but the meaning is the same as a TextRun with no additional properties, so the card information is maintained even if the form has changed.
Serializing text runs with only text as strings would be a reasonable behavior, just trying to understand the scenario better. Thanks!

@RebeccaAnne - Those are good points. It's been a while since I've thought about this, but I think I remember a customer just being confused about how to represent string inlines as C# objects.

Actually on further consideration, automatically serializing text runs as strings wouldn't fix the problem if the problem is making sure the JSON can be round-tripped consistently. Maybe a better solution is to put something in the documentation to keep people from getting confused.

@v-kydela That seems reasonable, we can look at a documentation update on this topic to make sure it's clear that the string form is just a short-hand for a TextRun with no additional properties. I don't think it's necessarily a goal for the round tripped json to be identical to the json coming in, only that the card it represents is the same. For always outputting the string form I was thinking that might help if there was a verbosity concern, which is why I asked about the scenario, but it doesn't seem like that's the issue. I'll mark this for a doc update. Thanks!

@RebeccaAnne is this still on track to getting in for 20.10?


Linear types to track use count?

#201 doesn't allow inlining the term, since we don't know how many times it will be used. With linear types, we can precisely track how many times something will be used. Not sure how feasible this is. Do note that this wouldn't be "real" linearity, e.g. even though the HOF passed to pmap is only used "once", it should probably not be linear, since morally it is used many times.

It would, that's part of why we can't do it right now.

I've thought more and more about this, and this would be extremely useful, and would truly take the eDSL to the next level. Perhaps this should be Plutarch 2.0.

Perhaps we also want dependent types for Plutarch 2.0, let's hope they land in GHC this year!

I'm less convinced we need linear types.

We don't need this.


Delete package-lock.json

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[x] Test B

Test Configuration:

Operating system:
Gdd.Js version:
Node version:
NPM version:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Sorry but this PR is incomplete


Snap crashes on startup

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.19.1
Platform
Linux
OS Version
Linux Mint 20.1
Architecture
x64
Build Number
No response
Regression From
previous snap release
Bug Description
on startup snap dependency errors prevent the application from launching
upon investigating it looks very similar to this issue:
https://github.com/microsoft/vscode/issues/100940
Steps to Reproduce

launch snap version of Storage explorer

Actual Experience
application fails to launch
Expected Experience
No response
Additional Context
env BAMF_DESKTOP_FILE_HINT=/var/lib/snapd/desktop/applications/storage-explorer_storage-explorer.desktop /snap/bin/storage-explorer
[2021-05-04T15:21:19.369Z] ( main) <NONE> Log file: /home/rijnhard/snap/storage-explorer/23/.config/StorageExplorer/StorageExplorer/logs/2021-05-04_172119/2021-05-04_172119_main.log
[2021-05-04T15:21:19.377Z] ( main) <NONE> Log level: info
Gtk-Message: 17:21:21.491: Failed to load module "xapp-gtk3-module"
93710 (Provider) >>> Loading '/snap/storage-explorer/23/resources/app/out/app/main/Resources/ResourceProvider'
93710 (Provider) >>> Loading '/snap/storage-explorer/23/resources/app/out/app/main/Configuration/ConfigurationProvider'
Resolved resource module './resources/Shell': '/snap/storage-explorer/23/resources/app/resources/Shell.json'
Resolved resource module './resources/Azure': '/snap/storage-explorer/23/resources/app/resources/Azure.json'
Resolved resource module './resources/Host': '/snap/storage-explorer/23/resources/app/resources/Host.json'
Resolved resource module './resources/Activities': '/snap/storage-explorer/23/resources/app/resources/Activities.json'
Resolved resource module './resources/Dialogs': '/snap/storage-explorer/23/resources/app/resources/Dialogs.json'
Resolved resource module './resources/ExtensionManager': '/snap/storage-explorer/23/resources/app/resources/ExtensionManager.json'
93710 (Provider) >>> Loading '/snap/storage-explorer/23/resources/app/out/app/main/UserAccountManagement/ServiceHubProvider'
(node:93710) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
** Message: 17:21:21.937: Remote error from secret service: org.freedesktop.DBus.Error.AccessDenied: An AppArmor policy prevents this sender from sending this message to this recipient; type="method_call", sender=":1.239" (uid=1000 pid=93710 comm="/snap/storage-explorer/23/StorageExplorerExe --no-" label="snap.storage-explorer.storage-explorer (enforce)") interface="org.freedesktop.Secret.Service" member="OpenSession" error name="(unset)" requested_reply="0" destination=":1.9" (uid=1000 pid=3801 comm="/usr/bin/gnome-keyring-daemon --daemonize --login " label="unconfined")

(StorageExplorerExe:93710): Gtk-WARNING **: 17:21:22.652: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.
**
Gtk:ERROR:/build/gtk+3.0-24RAPQ/gtk+3.0-3.22.24/./gtk/gtkiconhelper.c:493:ensure_surface_for_gicon: assertion failed: (destination)
Aborted (core dumped)

Assuming you have the latest snap installed, you should find the logs under ~/snap/storage-explorer/current/.config/StorageExplorer/StorageExplorer/logs.

Closing due lack of response. If you continue to have problems, please open a new issue.

@craxal apologies but its no longer an issue, randomly. so it can stay closed.

@rijnhard Glad you resolved it. If there was anything you think would be helpful for other Linux users, feel free to share.


Fix aria-label

Add aria label for next button, previous button and sidebar toggle

Fixes https://github.com/vaadin-component-factory/vcf-pdf-viewer/issues/14


Add dependabot / depfu

@pavanjoshi914 can you help us here?

i think we have to login into getalby github account. else i have to authorize it from my own account signup there. it also has pricings

Added by @reneaaron :raised_hands:


pdfcpu - panic: runtime error: invalid memory address or nil pointer dereference

I am facing the same issue happening in this one: https://github.com/gotenberg/gotenberg/issues/673
I have gone through testing various old releases,  and I found that the merge was working up to version 7.9.0. Starting from version 7.9.1, it started crashing (panic).
I hope that could narrow down the problematic release.
=== Error Log from container =====
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xc066a3]
goroutine 343 [running]:
github.com/pdfcpu/pdfcpu/pkg/pdfcpu.EnsureOutlines(0xc0001117d0, {0xc0004d258f, 0x5}, 0x0)
/go/pkg/mod/github.com/pdfcpu/pdfcpu@v0.6.0/pkg/pdfcpu/merge.go:78 +0x5e3
github.com/pdfcpu/pdfcpu/pkg/api.prepDestContext({0xc0004d2540, 0x54}, {0x10ae758, 0xc0001340a0}, 0xc00048b520)
/go/pkg/mod/github.com/pdfcpu/pdfcpu@v0.6.0/pkg/api/merge.go:91 +0x99
github.com/pdfcpu/pdfcpu/pkg/api.Merge({0x0?, 0x77?}, {0xc00003e600?, 0x1?, 0x1?}, {0x10a5440, 0xc000134088}, 0x7d2c65?, 0xb0?)
/go/pkg/mod/github.com/pdfcpu/pdfcpu@v0.6.0/pkg/api/merge.go:134 +0x265
github.com/pdfcpu/pdfcpu/pkg/api.MergeCreateFile({0xc00003e600, 0x3, 0x4}, {0xc0002e2000, 0x77}, 0x1?, 0x1?)
/go/pkg/mod/github.com/pdfcpu/pdfcpu@v0.6.0/pkg/api/merge.go:191 +0x145
github.com/gotenberg/gotenberg/v8/pkg/modules/pdfcpu.(*PdfCpu).Merge(0x0?, {0xc000440500?, 0xc00003e600?}, 0x3?, {0xc00003e600?, 0xc00002b7d0?, 0x8c2c85?}, {0xc0002e2000?, 0xc000140000?})
/home/pkg/modules/pdfcpu/pdfcpu.go:44 +0x38
github.com/gotenberg/gotenberg/v8/pkg/modules/pdfengines.(*multiPdfEngines).Merge.func1({0x7fbb52e85308?, 0xc00049c0f0?})
/home/pkg/modules/pdfengines/multi.go:31 +0x4d
created by github.com/gotenberg/gotenberg/v8/pkg/modules/pdfengines.(*multiPdfEngines).Merge in goroutine 341
/home/pkg/modules/pdfengines/multi.go:30 +0x265

@gulien Thanks for you prompt response.
Yes, I tested on latest version 8.1.0, and it have the same issue.

Looks like an issue with pdfcpu v0.0.6 🤔
Using --pdfengines-engines=qpdf,uno-pdfengine,pdftk is still a valid workaround.
Could you share the faulting PDFs?

Unfortunately, it does contain some sensitive information!. Any suggestions with that?

Could you remove somehow these sensitive data? 😅

Hey, I had the same issue. Putting pdfcpu at the end of the pdf engine order solved the issue for me. Hope it can be resolved because it's kind of scary having a broken engine to fallback on! Cheers

👍 I'll soon release a new Gotenberg version that contains the latest pdfcpu version. Hopefully it will resolve this issue.

👍 I'll soon release a new Gotenberg version that contains the latest pdfcpu version. Hopefully it will resolve this issue.

Cool! I'll test it when you do and let you know

@stefannovak Could you test your scenario with Gotenberg 8.2.2? Thanks 😊

@stefannovak Could you test your scenario with Gotenberg 8.2.2? Thanks 😊

It's fixed! Nice one!

Thanks for your quick response!


can't install it from npm

npm install -g elm-graphql
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/5.6.0/bin/node" "/usr/local/bin/npm" "install" "-g" "elm-graphql"
npm ERR! node v5.6.0
npm ERR! npm  v3.6.0
npm ERR! code E404

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/elm-graphql
npm ERR! 404
npm ERR! 404  'elm-graphql' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jackalcooper/Documents/Work/quail/elm/npm-debug.log

After I clone the project and build it. There is no tool directory

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Sorry, I was making some changes. The npm package is now published, please install it and make sure that you're using v1.0.4.


Complete C# bindings

The C# bindings have not been fully ported from MediapipeUnityPlugin yet.
This pull request aims at completing them in order to finally have a complete Mediapipe wrapper library.

At this stage, Akihabara builds successfully.

However, we will need unit tests (in a separate pull request) to make sure that all bindings work correctly.

Also, it seems that the MediapipeUnityPlugin is porting additional classes from Mediapipe that are needed for the specific graphs to be used, namely instant_motion_tracking and object_detection_3d, 2 graphs that we absolutely don't need for Vignette.
Instead, we would need at least face_mesh, and in the future holistic_tracking and hand_tracking.
Meaning, we will have to figure out how to make our own Bazel targets for these graphs, and put the resulting .proto files in the right place.

We would love them intact for other consumers too so keep them as-is. Don't just build for our case, since we want this to be used by the greater community.

True ─ we'll get face_mesh to work first; when it does, all the others will very likely work with the same process.


Command to navigate between panes of a diff view

There's no command to switch between two panes of a diff view. #22412 asks for this but it was locked with no resolution. It was marked as a duplicate of #16707 which does not seem to offer a solution for this.

/duplicate https://github.com/microsoft/vscode/issues/95068


Vitest browser mode userEvent type not recognizing special chars

Describe the bug
When using vitest browser mode, the following test fails:
import { expect, test } from 'vitest'
import { render } from 'vitest-browser-vue'
import HelloWorld from './HelloWorld.vue'
import { userEvent } from '@vitest/browser/context'

test('renders name', async () => {
  const { getByText, getByRole } = render(HelloWorld, {
    props: { name: 'Vitest' },
  })
  await userEvent.type(getByRole('textbox'), "éèù")
})

Fails with Error: keyboard.down: Unknown key: "é"
é is a valid key in AZERTY french keyboards. I cannot use userEvent.fill because I want to test the specific press of special char keys.
With playwright I can type the é key with their equivalent method.
Reproduction
clone https://github.com/Seboran/special-chars-vitest
pnpm i
pnpm test:browser

get error message Error: keyboard.down: Unknown key: "é"
System Info
System:
    OS: macOS 15.1
    CPU: (10) arm64 Apple M2 Pro
    Memory: 796.86 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.0 - ~/.nvm/versions/node/v20.5.0/bin/node
    Yarn: 1.22.22 - ~/.nvm/versions/node/v20.5.0/bin/yarn
    npm: 10.1.0 - ~/.nvm/versions/node/v20.5.0/bin/npm
    pnpm: 9.12.1 - ~/Library/pnpm/pnpm
    bun: 1.1.29 - ~/.bun/bin/bun
  Browsers:
    Safari: 18.1
  npmPackages:
    @vitejs/plugin-vue: ^5.1.4 => 5.1.4
    @vitest/browser: ^2.1.4 => 2.1.4
    @vitest/eslint-plugin: 1.1.7 => 1.1.7
    vite: ^5.4.10 => 5.4.10
    vitest: ^2.1.4 => 2.1.4

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

it looks like it's a duplicate of https://github.com/microsoft/playwright/issues/7396
but it puzzles me a bit why it does work with page.keyboard.type from playwright experimental ct, and not userEvent.type from playwright...
This works for example:
import { test, expect } from '@playwright/experimental-ct-react'

test('test', async ({ mount, page }) => {
/** ... **/
const text = 'éè'
  for (const c of text) {
    await page.keyboard.type(c)
  }
/** ... **/

Vitest's userEvent.type is implemented based on Playwright's page.keyboard.down, but probably they have a different implementation for page.keyboard.type, which works somehow. It looks like they have test cases like this https://github.com/microsoft/playwright/blob/50775698ae13642742f2a1e8983d1d686d7f192d/tests/page/page-keyboard.spec.ts#L291-L306

@Seboran Can you try https://github.com/vitest-dev/vitest/pull/6873#issuecomment-2461305369? I'm not exactly sure what Playwright's insertText does in terms of keydown/keyup event etc... It would be useful to know if this works for your use case.


Fail fast for unsupported Node versions

Description
Bolt has a fairly high Node version requirement (v10 LTS). We think this is okay for this project's first release, and will align to the Node Slack SDK Support Schedule in the future.
Since the version requirement is relatively high, and Bolt is meant to be approachable for relatively new programmers, any guidance regarding not meeting requirements would be beneficial. While version detection is normally considered a bad practice, and feature detection is usually preferred, we feel that in this case its a reasonable solution.
The requirement is to throw an Error when initializing App and the process.versions.node is less than major version 10. The Error should have a very clear and helpful message about not meeting the requirement and how the developer can update their current version.
Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

I ran into this today, it looks like when the app initializes (i.e., when the constructor is called) would be too late. Here is the error I saw when trying to start my app using Node v8.11.0:
/Users/cfurfarostrode/src/projects/tldr-bot/node_modules/@slack/bolt/dist/middleware/builtin.js:207
const slackLink = /<(?<type>[@#!])?(?<link>[^>|]+)(?:\|(?<label>[^>]+))?>/;

SyntaxError: Invalid regular expression: /<(?<type>[@#!])?(?<link>[^>|]+)(?:\|(?<label>[^>]+))?>/: Invalid group
    at Object.<anonymous> (/Users/cfurfarostrode/src/projects/tldr-bot/node_modules/@slack/bolt/dist/middleware/builtin.js:207:19)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/cfurfarostrode/src/projects/tldr-bot/node_modules/@slack/bolt/dist/App.js:12:19)
    at Module._compile (module.js:652:30)

That error happens when importing from the ./middleware/builtin module. During import/require the module gets evaluated and older Node versions have a hard time with the regex on this line: https://github.com/slackapi/bolt/blob/master/src/middleware/builtin.ts#L248
If you want to fail fast, you'll need to test the node version in App.ts before the import statements. It's probably worth adding something to the README too about supported Node versions.
FWIW I think supporting Node 10+ is fine, Node 8 leaves TLS at the end of this year, so it doesn't seem worth adding backwards compatibility especially once this issue is fixed.

I think if the entire package is scoped to Node 10+ (and in light of the above finding), it might make the most sense to put this warning at the top of index.ts, similar to how create-react-app does for the same constraint on Node 8+.


Geohub tags

When new tags are generated, it is appended to instead of overwritten. Hence, the search tags includes tags that are no longer associated with data.

I close this issue since we will have new search api


Error in cadvisor when pod not returned from Kubelet

Output of the info page
Here's the top section of the output; I'm not comfortable giving the full output in a public github issue:
Executing command on datadog-22sn7
Getting the status from the agent.

============================
Agent (v6.10.3-logs-api-key)
============================

  Status date: 2019-04-23 21:37:09.208728 UTC
  Pid: 387
  Python Version: 2.7.15
  Logs:
  Check Runners: 16
  Log Level: info

  Paths
  =====
    Config File: /etc/datadog-agent/datadog.yaml
    conf.d: /etc/datadog-agent/conf.d
    checks.d: /etc/datadog-agent/checks.d

  Clocks
  ======
    NTP offset: -999µs
    System UTC time: 2019-04-23 21:37:09.208728 UTC

  Host Info
  =========
    bootTime: 2019-04-15 22:59:20.000000 UTC
    kernelVersion: 4.4.0-1079-aws
    os: linux
    platform: debian
    platformFamily: debian
    platformVersion: buster/sid
    procs: 463
    uptime: 187h11m27s
    virtualizationRole: guest
    virtualizationSystem: xen

Additional environment details (Operating System, Cloud provider, etc):
Running Kubernetes v1.11.9 in AWS.
** Info about the issue**
In our logs, I see a lot of errors like:
[ AGENT ] 2019-04-23 17:03:59 UTC | ERROR | (pkg/collector/py/datadog_agent.go:146 in LogMessage) | (cadvisor.py:108) | Unable to collect metrics for container: 27f509fdbca861480227545dddd5c14e35b402470437fc335ce4d6af7dedc31e ('NoneType' object has no attribute 'get')

I'm pretty sure that maps to this line of cadvisor.py: https://github.com/DataDog/integrations-core/blob/1288ba846c6b3c77c94d72e9ce7e6eb223828c9a/kubelet/datadog_checks/kubelet/cadvisor.py#L108
Looking through this block of code, I see these lines:
        pod = get_pod_by_uid(pod_uid, pod_list)
        if pod is not None and is_static_pending_pod(pod):
            in_static_pod = True

which implies to me that pod can be None.  But then about 12 lines later in the else clause of your switch statement, you're calling:
        else:  # Standard container
            cid = pod_list_utils.get_cid_by_name_tuple(
                (pod.get('metadata', {}).get('namespace', ""),
                 pod.get('metadata', {}).get('name', ""), k_container_name))

Which means you might be calling get on an instance of NoneType.
I believe this occurs when cadvisor reports metrics on a container that is not returned by kubelet. I think this could happen if you're running a static pod on the host.
Let me know if you need any additional information.
cc @dndungu, who has opened a ticket with Datadog support about this issue

Hi @jonmoter, thanks for using Datadog.
If support has been contacted about this, there is no need to also open a github issue. Did you get the required assistance from support?


update constraints: add Equal statement

LGTM

Codecov Report

Merging #375 into master will decrease coverage by -0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   42.95%   42.69%   -0.27%
==========================================
  Files          21       21
  Lines       10764    10764
==========================================
- Hits         4624     4596      -28
- Misses       4936     4981      +45
+ Partials     1204     1187      -17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4104fd...6a656bf. Read the comment docs.


Fix deprecation warnings due to not using collections.abc

This were suddenly very visible, due to the --actually-quiet argument on the pytest checks.

/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/google/protobuf/descriptor.py:47: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from google.protobuf.pyext import _message
/home/travis/build/quantumlib/Cirq/cirq/ops/op_tree.py:111: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  if isinstance(root, collections.Iterable):
/home/travis/build/quantumlib/Cirq/dev_tools/shell_tools.py:72: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  async def _async_forward(async_chunks: collections.AsyncIterable,
/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/jsonschema/compat.py:6: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import MutableMapping, Sequence  # noqa
/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/jsonschema/compat.py:6: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import MutableMapping, Sequence  # noqa

I can't do much about the dependencies, but I cleaned up the remaining ones within cirq.

Still missed one:
/home/travis/build/quantumlib/Cirq/cirq/ops/qubit_order.py:127: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  if isinstance(val, collections.Iterable):

Are there newer version of protobuf and jsonschema that we can pin?

Oh it's only warning on the first use; there was actually a ton more.

I don't want to change the protobuf version without checking with Mike first.

Changing package versions doesn't need to be in this PR.  Open an issue.

https://github.com/quantumlib/Cirq/issues/1831

Also tenserflow_core on Windows.


fix fix parse_url is not working in some case to extract the HOST

Proposed changes
Issue Number: close #24452

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Static directory with source directory override.

I have overwritten next to use src for the content of my application and am using express to serve my application.
.
├── node_modules
├── package.json
├── server.js
├── src
│   ├── components
│   ├── next.config.js
│   ├── pages
│   ├── static (dynamic from webpack)
│   └── styles
└── yarn.lock

// next.config.js
const path = require('path');

const autoprefixer = require('autoprefixer');
const ExtractTextPlugin = require('extract-text-webpack-plugin');

module.exports = {
	webpack: (config) => {
		config.plugins.push(new ExtractTextPlugin({ // bundle all CSS for static export
			filename  : 'static/styles/bundle.css', //<--- PROBLEM LINE
			allChunks : true,
		}));

		config.module.rules.push(
			{
				test    : /(\.scss|\.css)$/,
				loader  : 'emit-file-loader',
				options : {
					name: './dist/[path][name].[ext]',
				},
			},
			{
				test   : /(\.scss|\.css)$/,
				loader : ExtractTextPlugin.extract({
					fallback : 'style-loader',
					use      : [
						{
							loader  : 'css-loader',
							options : {
								modules        : true,
								sourceMap      : true,
								importLoaders  : 1,
								localIdentName : '[name]__[local]___[hash:base64:5]',
							},
						},
						{
							loader  : 'postcss-loader',
							options : {
								plugins: [autoprefixer],
							},
						},
						{
							loader  : 'sass-loader',
							options : {
								includePaths: [path.resolve(__dirname, './')], //eslint-disable-line
							},
						},
					],
				}),
			});

		return config;
	},
};

// server.js
const next = require('next');
const dev = process.env.NODE_ENV !== 'production';
const dir = './src';

const app = next({ dev, dir });

What happens:
Running yarn dev === NODE_ENV=dev node server.js

./src/static/styles/bundle.css is created and refreshed on file changes
next properly references the /static directory in the head so my styles appear

Runing yarn build === next build src && yarn start === NODE_ENV=production node server.js

pages / components / JS is bundled into ./src/.next
server.js correctly loads JS resources from .next directory.
./src/.next/static is created with the bundle.css
**head is trying to resolve /static to ./src/static instead of ./next/static

What I've tried
I've tried everything under the sun for filename in next.config.js and I cannot seem to get it to drop the static directory into ./src when running yarn build.  It either is nowhere (presumably in relative path in the build process, deep in my file system) or is in .next which is not referenced in <head>
Expected Behavior
I think that static should get compiled to .next and used there.  It would be a much cleaner solution.  However, I get that sometimes static will be very large, (due to images and the like) so that might not be the best solution.  Therefore, any help getting static to populate when using a src override  with build would be amazing.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Steps to Reproduce (for bugs)

See Above

Outcome
If I'm able to get this fixed, I can update the external-css example (or make a new css-module example that will help the community have a non-js-in-css option that is modern and scalable.
Your Environment

Tech
Version

next
4.14

node
8

OS
osx

browser
chrome

etc

The core of this is we don't yet support most of the webpack loaders and ExtractTextPlugin. We know about this issue and working on a solution right now.

@arunoda
Is there an issue I can follow?
Also, could this perhaps be helped by having next surface an ENV variable like build_directory so we could use that to construct the path in our next config file?
For now it seems like I'll have to run dev and cancel the process to get static populated

We'll update the PR when it's ready for early beta.
There are many related issues like this. Better to stay with the canary branch for more.

Posted https://github.com/zeit/next.js/issues/8451


Add axum to home page

The point isn't to list all framework on the home page, axum is still very new, and actix-web, rocket, tide, and warp are by far the most popular/mature.

I think I'll leave this out for now.

Oops, didn't mean to merge :see_no_evil:

Axum has now almost caught up to Actix, has beaten Tide, and has blown away Warp and Rocket
.

@randomairborne I agree, I'd accept a pull request now.


JDBC 0.4.0

Summary

Update the underlying JDBC driver to v0.4.0.
In the plugin configuration wizard, the suggested username is pre-filled with default now

Status: blocked by https://github.com/ClickHouse/clickhouse-java/issues/1221
Checklist

[x] A human-readable description of the changes was provided to include in CHANGELOG

Blocked by https://github.com/ClickHouse/clickhouse-java/issues/1221

unblocked by https://github.com/ClickHouse/clickhouse-java/releases/tag/v0.4.1

Closed in favour of https://github.com/ClickHouse/metabase-clickhouse-driver/pull/145


Merge openmp_handler into interpolate

Need to merge openmp_handler extension module into interpolate.  When testing static building to sp and ip, but dynamically linking to the OpenMP library, increasing the thread count does not reduce runtime.  But when testing with only 1 extension module (interpolate), it worked properly.  So we want to

merge openmp_handler into interpolate.
allow for static linking to OpenMP library.

Closing this issue.  The problem all along was a bug in grib2io 🙄


Fixes after JPA 2.0 to 2.1 upgrade

Please don't merge yet. All the IP BOM 7.0.0.CR5 PRs need to be merged together.

jenins retest this

jenins retest this

jenkins retest this

@nmirasch @cristianonicolai could you please review this?


Mermaid Support

Does this tool support converting diagrams to Mermaid style?

I don't think so, would be good if it's supported in future!

Not yet. Let me research this more.

Not sure what that is, can you provide more context.

Not sure what that is, can you provide more context.

You can find it here

What exact feature would you like this library to support? Can you provide a minimal example?


'JavaScript basics' issue

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[X] Correction or update

Details

This module originally instructs users to type these two lines at the top of our 'main.js' document:
const myHeading = document.querySelector('h1');
myHeading.textContent = 'Hello, world!';
When we get further into the tutorial ['Adding a personalized welcome message'] we are told to write the following two lines:
let myButton = document.querySelector('button');
let myHeading = document.querySelector('h1');
However, this seems to conflict with the 'const' from before. I asked a friend (experienced JS user) who told me to change the 'const' to a 'let' at the top of the document and only add the - let myButton = document.querySelector('button'); - at the bottom.
This fixed the issue. Before I asked him, the button would not do anything when I clicked it.

https://developer.mozilla.org/en-US/docs/Learn/Getting_started_with_the_web/JavaScript_basics

Hi @chimpchimpo21 !
The two parts you are citing are in conflict, agreed.
However, before the second one, you are asked to "Also delete your Hello world! JavaScript from the earlier exercise." — see bullet number 4 under the "Adding an image changer" heading.
However, I don't think this instruction is very obviously placed, so I'm going to move it and change it to make it clearer.

Hi @chimpchimpo21 !
The two parts you are citing are in conflict, agreed.
However, before the second one, you are asked to "Also delete your Hello world! JavaScript from the earlier exercise." — see bullet number 4 under the "Adding an image changer" heading.
However, I don't think this instruction is very obviously placed, so I'm going to move it and change it to make it clearer.

Ok! Oh, good point. Just seeing that. Thanks for the quick response. Sent from Mail for Windows 10 From: Chris MillsSent: Friday, January 8, 2021 10:57 AMTo: mdn/sprintsCc: chimpchimpo21; MentionSubject: Re: [mdn/sprints] 'JavaScript basics' issue (#3981) Hi @chimpchimpo21 !The two parts you are citing are in conflict, agreed.However, before the second one, you are asked to "Also delete your Hello world! JavaScript from the earlier exercise." — see bullet number 4 under the "Adding an image changer" heading.However, I don't think this instruction is very obviously placed, so I'm going to move it and change it to make it clearer.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Ok! Oh, good point. Just seeing that. Thanks for the quick response. Sent from Mail for Windows 10 From: Chris MillsSent: Friday, January 8, 2021 10:57 AMTo: mdn/sprintsCc: chimpchimpo21; MentionSubject: Re: [mdn/sprints] 'JavaScript basics' issue (#3981) Hi @chimpchimpo21 !The two parts you are citing are in conflict, agreed.However, before the second one, you are asked to "Also delete your Hello world! JavaScript from the earlier exercise." — see bullet number 4 under the "Adding an image changer" heading.However, I don't think this instruction is very obviously placed, so I'm going to move it and change it to make it clearer.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

OK, I've updated the document — see https://github.com/mdn/content/commit/122aa5af46dd681dd2e8bb0175d8603d4f173a5f for the change diff.
I think this is better now, so I'm closing this issue, but feel free to chime in if you have more queries.

OK, I've updated the document — see https://github.com/mdn/content/commit/122aa5af46dd681dd2e8bb0175d8603d4f173a5f for the change diff.
I think this is better now, so I'm closing this issue, but feel free to chime in if you have more queries.


Fix korean typo

This pr fixes typo in korean document. The 도입부 is appropriate meaning for introduction.

Thank you, @pushrsp !


[Languages] Building a Video cataloging app with React, firebase and React-styled-components

Topic Suggestion
Building a Video cataloging app with React, firebase and React-styled-components
Writing sample(s):
https://www.section.io/engineering-education/building-animated-signin-routes-with-react-and-bootstrap/
https://www.section.io/engineering-education/building-faq-page-using-react-styled-components-and-react/
Proposal Submission
Proposed title of article
Building a Video cataloging app with React, firebase and React-styled-components
Proposed article introduction
Video based social media websites and applications has experienced wide spread adoption over the decade from YouTube, Instagram and most recently TikTok.  With average monthly user exceeding a billion.
Building a video cataloging app capable of displaying and playing videos in categories ranging from sports, entertainments, educational, etc. can be done with React.js and React-styled-components used in creating and styling the user interface and firebase used in uploading and managing the video.
Key takeaways
At the competition of this tutorial, the reader will have the understanding and knowledge to implement the following:

Getting started with React.js
Building a video cataloging app with React.js
Creating and managing firebase entries
Error handling in React.js and firebase
Customizing video components with react-styled-components

Article quality
This tutorial is a project-based application of React.js, firebase and react-styled-components in creating, managing, uploading, customizing and cataloging video entries. This article will walk the reader through the processes, dependences and steps required in building a video cataloging app with React.js and other modern web development packages.
References
N/A
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.

Great topic 🚀 , make sure it matches the following:

Adds value beyond what is in the official docs and what is covered in other blog sites.
To avoid potential article closure, it should not overlap with existing EngEd articles or incoming topic suggestions.

Please reference any relevant EngEd articles in yours and build a unique project - Approved.


Avoid using Pkg internals

functions like https://github.com/SamuraiAku/PkgToSoftwareBOM.jl/blob/938168a775658ebcd173e1e1cb45471e05c48105/src/packageInfo.jl#L3 are using Pkg internals, which have changed in the past.
One tool that can help is https://github.com/GunnarFarneback/RegistryInstances.jl which provides a public API for the RegistryInstances portion of what Pkg does. (See the Background section of the README there).

This package has no releases yet, but this is the functionality I am looking for. I’ll keep an eye on this. Thanks for the tip.

RegistryInstances actually does have a registered release in General: https://github.com/JuliaRegistries/General/blob/master/R/RegistryInstances/Package.toml. It doesn't have TagBot setup (fyi @GunnarFarneback), which is why nothing shows up as a github release. (I know since I'm using it in PackageAnalyzer.jl).


[abc:iview] Extract chapters and audio description tracks

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

This PR adds the ability to extract chapters and AD tracks when they are available.
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Some previous review comments are still unaddressed

@bashonly Sorry for the delay. I didn't realize you have to click "Submit review" in order to make your comments visible to others. Having to submit a review on my own PR was extremely counter-intuitive.

All good. Sorry it's taken me a while to get back to this; I am a bit puzzled by the m3u8 problem


Getting errors even on first request, even with large timeout

I tried running this, and I am getting the same kind of error. I didn't make a lot of requests, and this error persists whether I vary the following factors:

session: Tried with and without
timeout: Tried with and without

Here's what the errors are:
Session and timeout: Response Error: b')]}\'\n\n38\n[["wrb.fr",null,null,null,null,[9]]]\n57\n[["di",207],["af.httprm",206,"-5973836830292919317",0]]\n25\n[["e",4,null,null,132]]\n'.

Session: Response Error: b')]}\'\n\n38\n[["wrb.fr",null,null,null,null,[9]]]\n57\n[["di",158],["af.httprm",157,"-7097826725018575708",1]]\n25\n[["e",4,null,null,132]]\n'.

Timeout: Response Error: b')]}\'\n\n38\n[["wrb.fr",null,null,null,null,[9]]]\n57\n[["di",188],["af.httprm",187,"-7191527685766192777",2]]\n25\n[["e",4,null,null,132]]\n'.

No Sesh No Timeout: Response Error: b')]}\'\n\n38\n[["wrb.fr",null,null,null,null,[9]]]\n56\n[["di",170],["af.httprm",170,"3959452704966963607",1]]\n25\n[["e",4,null,null,131]]\n'.

!pip install bardapi

from bardapi import Bard
import os
import requests

# Get this from going to
# Bard web UI -->
# Developer tools -->
# Applications -->
# Storage tab -->
# cookies -->
# Secure-1PSID
token='MYCOOKIE.'
session = requests.Session()
session.headers = {
            "Host": "bard.google.com",
            "X-Same-Domain": "1",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36",
            "Content-Type": "application/x-www-form-urlencoded;charset=UTF-8",
            "Origin": "https://bard.google.com",
            "Referer": "https://bard.google.com/",
        }
session.cookies.set("__Secure-1PSID", token)

# TRY DIFFERENT COMBOS OF SESSION AND TIMEOUT

# Session and timeout
bard = Bard(token=token, session=session, timeout=500)
ans = bard.get_answer("What's a creative use for a hat?")['content']
print("Session and timeout:", ans)

# Session
bard = Bard(token=token, session=session)
ans = bard.get_answer("What's a creative use for a hat?")['content']
print("Session:", ans)

# Timeout
bard = Bard(token=token, timeout=500)
ans = bard.get_answer("What's a creative use for a hat?")['content']
print("Timeout:", ans)

# No Session, No Timeout
bard = Bard(token=token)
ans = bard.get_answer("What's a creative use for a hat?")['content']
print("No Sesh No Timeout:", ans)

It does not seem to be the issue of this library as bard itself throws error if it notices some pattern. In my case i am asking same question by changing some parameters. if I break the pattern by asking different question then it starts to work fine but only for couple of instances.
As of now, I dont have any solid implementation that works but will try some logic to break such pattern.

Did you ask questions again and again with same frequency as your code? I tried to replicate the same from the UI and I was greeted with the same error. Notice the popup on the bottom left side of the window. It clearly rejected my request from UI. And the error in the response of network seems similar to what we are getting from the API.

But you are asking a different question, which did throw an error on the UI. I am saying that my prompt did _not _ throw an error on the UI. Try asking: "What's a creative use for a hat?" several times. It does not throw an error on the UI.


React App on mac external drive keeps refreshing page

Posted this question on StackOverflow (https://stackoverflow.com/questions/61178447/create-react-app-on-mac-external-drive-keeps-refreshing-page) initially but I believe it's likely it is an fsevents issue:
I am running a react app created with create-react-app ("react": "^16.13.1", nodejs: 13.12.0) on an external drive connected through USB-C to a MacBook Pro (macOS Catalina).
After npm start the app keeps refreshing every ≈ 10 seconds (it's not constant interval) without any change to the files. The page also gets reloaded in the browser.
I prevented Spotlight from indexing this drive (by adding to Privacy) but still the issue persists. Also tried on another MacBook Pro (macOS Catalina). On one of the notebooks there is no antivirus installed.
The same application runs without any reloads from each of the MBPs own internal drives.
I'm not sure what else can trigger the reload on the external drive.
After I start the npm app (disk access led blinks with each app/page reload):
USB-C: sudo lsof +D "/Volumes/USB-C"
COMMAND   PID          USER   FD   TYPE DEVICE SIZE/OFF   NODE NAME
mds       136          root   21r   DIR   1,11    32768      2 /Volumes/USB-C
zsh     81813 username  cwd    DIR   1,11    32768    250 /Volumes/USB-C/myproject/frontend
zsh     82998 username  cwd    DIR   1,11    32768      2 /Volumes/USB-C
node    86986 username  cwd    DIR   1,11    32768    250 /Volumes/USB-C/myproject/frontend
node    86987 username  cwd    DIR   1,11    32768    250 /Volumes/USB-C/myproject/frontend
node    86988 username  cwd    DIR   1,11    32768    250 /Volumes/USB-C/myproject/frontend
node    86988 username  txt    REG   1,11    36204 649396 /Volumes/USB-C/myproject/frontend/node_modules/fsevents/fsevents.node
sudo    87013          root  cwd    DIR   1,11    32768      2 /Volumes/USB-C
lsof    87014          root  cwd    DIR   1,11    32768      2 /Volumes/USB-C
lsof    87015          root  cwd    DIR   1,11    32768      2 /Volumes/USB-C

In normal use (app not running, disk led not blinking, no access)
USB-C: sudo lsof +D "/Volumes/USB-C"
COMMAND   PID          USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
mds       136          root   21r   DIR   1,11    32768    2 /Volumes/USB-C
zsh     81813 username  cwd    DIR   1,11    32768  250 /Volumes/USB-C/myproject/frontend
zsh     82998 username  cwd    DIR   1,11    32768    2 /Volumes/USB-C
sudo    87126          root  cwd    DIR   1,11    32768    2 /Volumes/USB-C
lsof    87127          root  cwd    DIR   1,11    32768    2 /Volumes/USB-C
lsof    87128          root  cwd    DIR   1,11    32768    2 /Volumes/USB-C

I used an USB stick also, I get same behaviour just time between refreshes seems to be a bit longer (probably due to slower speed of the drive)

Update: I formatted the drive to Mac OS Extended (Journaled) and the issue does not appear anymore.


Refactor how we show Sync/Settings

Description
The current Sync experience is poor as it grew drastically over the last couple of months with new providers that were added.
Requirements
We should refactor this:

Don't group sync settings by provider
Instead, show all stored providers in a vertical list
Add a Add new button that lets the user choose from Providers
After choosing one, do the same thing as we did today.
Change each Sync Item so we have a ... menu that shows more options
Show Connection errors inside the active sync item if there is one

include validation > @rbosker check the issue for the error handling.

All the sync providers are showing the same icon.

In light mode, the dropdown menu on 'Add new' is still in dark mode.

Shipped in 129


Authorize requests during integration tests

Hi there!
I would like to set up a simple integration tests on an authenticated route. This route hits a remote API that uses oAuth to authorize the request. Currently, I am using the authenticateSession() method to authenticate properly, but I notice that when the integration tests run there is no Authorization: Bearer <token> present in the request, and causes the test to fail.
Is there a way to include a token in an integration test? What is best practice here, is it in fact better to stub out the API call and not actually hit the endpoint used in the ember application? Would greatly appreciate your advice on this. Love the library and thanks!

authenticateSession uses a fake authenticator that always resolves restoration, authentication and invalidation. It doesn't add a token or anything to the session. The whole purpose of the helper is to make the session authenticated in the context of the Ember app - it couldn't really add any token or so anyway as it doesn't know what authentication/authorization mechanism you're using outside of the test environment anyway and how that mechanism works/what it requires in terms of tokens etc. (for example OAuth 2.0 works with access_token whereas devise works with token and user_email and these names are also configurable).
I would always stub all API requests in tests anyway. If you have to (or really want to) use actual authenticators/authorizers in tests you should define your own helper.


[Nightly] Messages received out of order when sent in quick succession

Much like this bug here I've only had it happen once, but I received these three messages probably within one second of each other and they displayed out of order. Quitting the app from the app switcher and going back in didn't fix it.

@CSab6482 should i close this?


More fixes for data management and data client

Various adjustments to Dataset, including fixes for serialization and deserialization
Adjustments to DatasetManager
Adjustments to object store stack/services
Work to get object store based datasets accessible within workflows
Adjustments to dataservice functionality to support various operations (query, check if data available, delete, etc.)
Adjustments to hydrofabric class after format updates
Adjustments to things using hydrofabric datasets to ensure proper identification of desired hydrofabric

This PR should remain in draft status until #179 is complete.

As stated in #179, I anticipate the checks for this PR will fail.  This should be the last PR in the sequence we are working through with these particular expected failures.


update polkadot-launch

Running this with a different config.json locally, so pls try with the one in this PR.

we'll want to investigate just pulling it in as a dependency or submodule IMO


physics - suggested changes to Pong Game section

Suggested text after "Add an event handler to run when the scene fires the loaded event.":
We need the help of JavaScript again. Near the bottom of the file you should see this code within a couple of <script> </script> tags:
on($('a-scene'),'loaded',()=>{

})

Add these lines between the curly braces:
const pos = ball.getComputedAttribute('position')

    //start the ball moving
    ball.body.applyImpulse(
      new CANNON.Vec3(0, 0, -50),
      new CANNON.Vec3().copy(pos)
      )

That script code should now look something like this:
<script>
      const $ = (sel) => document.querySelector(sel)
      const on = (el,type,cb) => el.addEventListener(type,cb)
on($('a-scene'),'loaded',()=>{
  const pos = ball.getComputedAttribute('position')

    //start the ball moving
    ball.body.applyImpulse(
      new CANNON.Vec3(0, 0, -50),
      new CANNON.Vec3().copy(pos)
      )
  })
</script>

Note: Josh, I'm loving this! Learning about physics and A-Frame here.
I appreciate your style. Glitch is great for this!
Thank you

good point. updated.


Documentation improvements

"Index" section. The README is too long, we need links to the subsections near the top
The epinio push of the sample app doesn't explain how to get the sample-app (git clone the repo? include release assets? new repo?)
What drives Epinio's new features? What comes next? Why is there no far future Vision? (clearly state what Epinio is)

Working branch: https://github.com/epinio/epinio/tree/306-documentation-improvements


Automated cherry pick of #3824: fix resize disk

Cherry pick of #3824 on release/2.12.
#3824: fix resize disk

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@3bd0e05). Click here to learn what that means.
The diff coverage is 52.63%.

@@              Coverage Diff               @@
##             release/2.12   #3826   +/-   ##
==============================================
  Coverage                ?   6.93%
==============================================
  Files                   ?     500
  Lines                   ?   84367
  Branches                ?       0
==============================================
  Hits                    ?    5850
  Misses                  ?   78023
  Partials                ?     494

Flag
Coverage Δ

#aFlag
6.93% <52.63%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/kvm.go
3.37% <0%> (ø)

pkg/compute/models/guests.go
0.59% <0%> (ø)

pkg/hostman/diskutils/nbd/nbdman.go
57.5% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd0e05...46d01a6. Read the comment docs.


Encode Value in Compact form in UTxO

It is counterproductive to uncompact the value in order to store it on disk in the ledger state. There is not really requirement for TxOut to be serialized in the same format in the ledger as it is in the transaction. It is convenent, since we can reuse the same (de)serializers, but conceptually it doesn't have to be that way.
This came up in the context of snapshotting in consensus, where extra containers allocation overhead is present during serialization of ledger state. See https://github.com/IntersectMBO/ouroboros-consensus/issues/868#issuecomment-1938477531
First part of this ticket would be to implement a quick solution for Babbage, just so we can confirm that doing this change will actually be benefitial

There is a mostly complete implementation of this ticket in this branch: https://github.com/IntersectMBO/cardano-ledger/tree/lehins/use-mempack
@nfrisby have successfully confirmed that this results in a significant improvement to performance of snapshot creation: https://github.com/IntersectMBO/ouroboros-consensus/issues/868#issuecomment-2358522722
We are now waiting for https://github.com/IntersectMBO/cardano-base/pull/506 to be merged and new version of cardano-crypto-class to be released to CHaP. This is currently blocked by #4699


Add menuconfig option to invert colors on ILI9341

This fixes issue #119

@C47D

Thanks for the PR, I can't test it right now, so will test it later today.


Questions: Which branch do I download? Why can't I find commits fcfbcf9 and 920b367 from asset-library pages? (They're horribly out-of-date BTW.)

Oh wait, this isn't GDScript anymore? But the releases don't have any builds?

A bit confusing, the current version of the store is 1.20, you need an old version, I'm currently working on a version practically redoing the entire lib with gdextension.
Can you show me exactly which version you need, I'll check if there's a git problem and if so make it available in a branch for you.

I've been away from Godot for a while but I'm coming back now by re-downloading all my bookmarked Godot-related-stuff,
(now that most of said stuff is much more mature now and ready to actually use)
including your character-controller (addon & demo) and inventory-system (addon & demo) which I had saved to a backup
archive on an old USB-HDD.
The files I had saved;
"inventory-system-e83a4b5-main.zip" dated 11/03/2024
"inventory-system-d68bcb7-addon.zip" dated 15/03/2024
So yea, old. So old the commit hash's don't work in search.
I just wanted what are the now current updated equivalents would be.
I really liked your work because as a learner it was one of the first & few "working & complete" examples/templates for
its time (around godot 4.1) but we've gotten more now like;
Cogito
Garage42
Godot-Easy-Vehicle-Physics
godot-simplified-flightsim
tinybox
desert-light
Bistro-Demo-Tweaked
All really good stuff and it was your addons/demos that were the first ones on that list. :)

Well, these commits still exist, but I admit that there is no longer support and work on the gdscript of these versions. A version 2.0 of this plugin will be released in some time, and it intends to keep everything practically in C++. The idea is to keep very well separated what is part of the module and what is part of the demo. The choice of C++ is very much in view of the fact that inventory optimization should be a priority for a game that has scalability. In any case, I am helpful for any specific questions and I also propose a fork of the gdscript version if it is still necessary to work on it.


[discussion] desktop architecture

dat desktop architecture
I ran into some issues with dat-desktop's technical design today. I'm writing
this document because I feel it's important to communicate the issues and
proposed solution. This way it's clear for everyone if we decide to take a
certain direction, and makes sure we're all on the same page. Here goes:
current
Currently dat-desktop is a mix of server and client code, living in the
client:
    ┌──────Electron window─────┐
 ┌ ─│        client code       |<┐
 |  │        server code       | |
 |  └──────────────────────────┘ |
ipc                            ipc
 |                              |
 |  ┌──────Electron server─────┐ |
 └ >│        boot process      |─┘
    └──────────────────────────┘

While this is very efficient to bootstrap, it mixes code in a way that's
entirely unique to electron and cannot be done in any other environment. It's a
bit of a special snowflake so to speak. Tools such as browserify and related
transforms cannot be applied to this particular architecture, and abstractions
cannot always easily be ported to other projects. One of the most pressing
issues is that the current design of dat-elements relies on browserify
transforms, and can thus not be consumed by the current architecture.
proposed
Instead I want to propose we switch to a somewhat more traditional
architecture, providing a clearer devision between "client" and "server":
    ┌──────Electron window─────┐
 ┌ ─│        client code       |<┐
 |  └──────────────────────────┘ |
ipc                            ipc
 |                              |
 |  ┌──────Electron server─────┐ |
 └ >│        server code       |─┘
    │        boot process      |
    └──────────────────────────┘

This has the advantage that the desktop app will have more overlap with our
other projects; and allow us to re-use elements without problem.
This would also allow us to start iterating on abstractions that can later be
moved out to separate packages. One particular example that comes to mind is an
API for dat-cloud.
If we were to separate the server from client, we'd have to call an API on the
server, from the client. I can imagine this would be similar to how dat-land
(or any other client) would call dat-cloud using an API library:
    ┌──────Electron window─────┐
 ┌ ─│        client code       |<┐
 |  │        client API lib    | |
 |  └──────────────────────────┘ |
ipc                            ipc
 |                              |
 |  ┌──────Electron server─────┐ |
 |  │        server API lib    | |
 └ >│        server code       |─┘
    │        boot process      |
    └──────────────────────────┘

As the packages stabilize we could start moving them out, lowering the cost of
maintaining dat-desktop and creating more consumers of our APIs and related
libraries, improving their quality and thus also providing a better environment
for third party developers and future contributors.
caveats
Moving to separate client from server is not without caveats. One particular
cost is that initial boot times would be increased. However, we can overcome
this by creating a static bundle for production and pointing to the bundle, and
additionally remove all asset rendering bits. This would also allow us to
optimize the bundle, improving performance.
A caveat for using dat-desktop as prototyping ground for other APIs is that
it would become a gravity well for other projects, potentially becoming
blocking for members involved. I think using a clear architecture (hi choo)
could to a certain extent help mitigate this, as code becomes less coupled and
individual people can take ownership of certain parts of the app - but we'd
have to figure out as a team how to do this. Given that this will not be
happening in the immediate future, we'll have enough time to think about the
approach and merits.
wrapping up
I think it'd be greatly beneficial to move to a browserify based architecture
in the short term, and in the mid to long term use dat-desktop as prototyping
ground to start working on packages such as API libraries that will be used in
other environments.

Thinking out loud, but it seems like the 'code smell' here is that while you don't need browserify to bundle your code for electron (since you can just require directly), you still need browserify to run browserify transforms. Maybe there's some unconsidered solution that involves either avoiding a dependency on browserify transforms or maybe calling transforms in special cases without needing to switch totally over to a bundled (client) workflow.
All in all though I think your proposal is very practical + agree keeping dev tools portable across environments is a high value feature.

From IRC:
19:07:09 <@karissa> yoshuawuyts: yeah seems reasonable

@yoshuawuyts I can't seem to find the dat-elements repo anywhere, also curious why it needs browserify transforms. Maybe we can just do those transforms as part of the npm publish step so you can require them from anywhere?

@juliangruber https://github.com/datproject/dat-elements maybe?

@mafintosh ah, they aren't on npm yet, didn't see that repo. looking at https://github.com/datproject/dat-elements/blob/master/package.json#L6, even If we use browserify it's not going to run any transforms for this module, right?

@juliangruber it will for https://github.com/yoshuawuyts/base-elements

@yoshuawuyts i guess moving this step into prepublish wouldn't work?

browserify is now in the tree - we can improve on how we're compiling right now but this issue can be closed now - we're treating electron as a first-class third target in addition to node and browser, but also running browserify to enable optimizations and transforms. Yay! :sparkles:


[Docs] Broken link in Need More Help Section

I would like to raise an issue regarding the Need More Help section. The link provided, Learn from GitHub from Scratch ,appears to be non-functional or broken.
I would like to fix this issue by adding an alternative resource to learn GitHub or if you have recommendation resource that you can provide for me so that I can start working this, thank you!
under gssoc23
issue:

can you check? @AtriSukul1508 thank you!

pls check @AtriSukul1508

pls check @AtriSukul1508. assig it to me! thank you!


Rename AssignedWorkloads to AdmittedWorkloads

Signed-off-by: Carlos Eduardo Arango Gutierrez<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:

Part of #7
Special notes for your reviewer:
Part 1 of https://github.com/kubernetes-sigs/kueue/issues/7#issuecomment-1062817277

/assign @ahg-g

/lgtm
/approve


⚠ Account Settings API has degraded performance

In 7d0575a, Account Settings API (https://accountsettings.roblox.com) experienced degraded performance:

HTTP code: 503
Response time: 4421 ms

Resolved: Account Settings API performance has improved in ee1dde9.


Overlapping fields in Faculty page

Student email and department overlaps if the email field is a bit long.

Added word-break:break-all; to break long emails/names into multiple lines.


Can't log in

I'm trying to log in with my google account, but it won't work. It gives me the ID of 7e487h47m. What is going on?

I'm getting this error too

Me too

Still getting this

I just recently got this error. But I see that some people are able to publish puzzles, one was published just a few days ago. Is there a way to publish without being signed in? Or is there some kind of workaround?

I have a feeling it was for people signed in before it broke, who still have existing auth cookies.
Two years later and I still can't sign in, very much feels abandoned unfortumately.

Yes. It's not even doing PRs, one of us would have to fork and host an updated version. Problem is all those wonderful puzzles already registered in production.


update scale_bar example to include new attributes

References and relevant issues
Closes #7007
Description
Adds various attributes to scale_bar example to show some options, including the typical settings of setting the unit, desired length, and increasing the font size.
Known visual issues with this scale bar example include enlarged text clipping outside scale_bar.box (issue #5914) and moving the scale_bar.position to anywhere on the top clips outside the viewer (PR #7018). These visual bugs are left in to show the user some of the limitations.
Trying to work on some of these issues to learn the napari library better, seems to be the point of the 'good first issue' tag, but please feel free to give extra guidance.

So, I updated the file to include the commenting spaces and changing the box color. I'm a bit confused how the 'reviewed' code works. It looks like it's not actually added to the file until a new commit is made? But it also looks like you can directly accept reviewed codes as commits? If so, I'm wondering why @jni 'approved the changes' if we still had a few things to tease out.

Hi @TimMonko thanks for the PR, and welcome to the repo!

It looks like it's not actually added to the file until a new commit is made? But it also looks like you can directly accept reviewed codes as commits?

That's right, review comments with suggestions in them can be accepted directly by clicking the Commit suggestion. This generates a new commit with the changes, authored by the author of the comment. You can also add many suggestions to a batch and commit at once.

If so, I'm wondering why @jni 'approved the changes' if we still had a few things to tease out.

Good question! I think because the suggestions were mostly nitpicks, Juan was happy to approve the PR knowing that you'd address the few tiny details without him needing to re-review. He also probably assumed that other folks (like me!) would come along and have a look.
Note that a PR in our repo isn't merged until it gets the "ready to merge" label, so an approval with some minor suggestions is quite common.


Issue #167: User choose language from welcome page

Fixes #167
Changes proposed in this pull request:

Redirects to settings in the welcome page
Changed the setNoFirstTimeFlag to setting on save button
Deleted isSaveDisabled on save button

The reason i did it that way was because of simplicity and comfort since the settings page only manage the language preferences. If more settings will be added you could store the settings in different components and keep the button on the welcome page calling settings >> language.

@Xhoria-RB Thanks for your work :-)
But, we expected to add select box (with all supported languages) like settings page, and add text
select your language beside welcome (in multiple languages).
You can ping us on Gitter, if this is not clear.

ok @abahmed thanks for the review, i'll work on the select box right on.

I'm working on integration

Hello @abahmed i did as you told me and deleted the snapshots then i run npm test but i still getting this error and i've tried to solve it but i can't, if you can tell me how to solve it i can try.
This is the error in the test:

The app works fine everytime i open and it changes the language without errors.

Hi @Xhoria-RB @abahmed The issue here is that the test and the welcome screen are calling this function and it needs the electronStore object. While on the welcome screen you have initialized the store, but it is not on the test.
@abahmed Do you know how can this be fixed or at least where to start?

Hey @jesusbibieca @Xhoria-RB
Please mock api.electron in app.test.js by adding this line
jest.mock('../../utils/api.electron')
It should work properly.

@abahmed Yes, adding that mocked function does the trick! @Xhoria-RB if you need help with anything here let us know. With the line that was suggested before the tests will pass and everything else should be ok

Thanks @abahmed @jesusbibieca  for the reviews i'll work in them

I finished the changes suggested, please review @abahmed @jesusbibieca @mjimenez07 and let me know if anything needs to be changed.

Thanks @abahmed for telling me about that. The selectLang is fixed, but the setNotFirstTimeFlag is already there after the saving, just in case i checked again and did some test and it worked fine after the user selects the language it won't show the welcome page again and keeps the selected language as default.


escape Go version string

Fixes https://github.com/googleapis/toolkit/issues/817

Current coverage is 83.31% (diff: 100%)

Merging #819 into master will increase coverage by <.01%

@@             master       #819   diff @@
==========================================
  Files           315        315
  Lines         12023      12024     +1
  Methods           0          0
  Messages          0          0
  Branches       1581       1581
==========================================
+ Hits          10017      10018     +1
  Misses         1577       1577
  Partials        429        429

Powered by Codecov. Last update e1bbe86...007bf27


Implement GetValidators interop

Neo.Blockchain.GetValidators and its alias, AntShares.Blockchain.GetValidators.

This will require adding a list of validators to the blockchain that initially is populated from the config (StandByValidators).

And it's related to the consensus functionality, BTW.

Add transaction.EnrollmentTX here.


Rdb2RdfTest dg0016 Failure: SQL Query Syntax - Illegal Mix of Collation for UNION - TIMESTAMP

Description
Running Ontop against Rdb2Rdf Test dg0016 (direct mapping) on MySQL with 'utf8_unicode_ci' collation results in SQLException: Illegal mix of collations for operation 'UNION'.

Test Case: https://github.com/ontop/ontop/tree/version4/test/rdb2rdf-compliance/src/test/resources/D016
JUnit Tests: https://github.com/ontop/ontop/blob/version4/test/rdb2rdf-compliance/src/test/java/RDB2RDFTest.java
Database: Docker mysql:5
JDBC Driver: mysql-connector-java:8.0.30
While the JUnit test is coded against a H2 memory database, I have modified it to run with different databases.

The problem appears comes down to how TIMESTAMP is handled in the SQL Query. It looks like INTEGER, FLOAT, and DATE are cast to CHAR CHARACTER SET UTF8 while TIMESTAMP is not.
It also appears that using the general collation works, but unicode collation does not. Likely because the default collation is general... If I remove all CHARACTER SET UTF8 statements from the query, it also works. So, either all results must be cast to utf8 character set or no results should be cast to utf8, but casting only some results to utf8 cause the problem.
Workarounds:

Change COLLATE 'utf8_unicode_ci' to COLLATE 'utf8_general_ci'

Problem Query Fragment - CAST(v7.EntranceDate AS CHAR(30))
SELECT v7.`ID` AS `ID1m20`, 'http://example.com/base/Patient#EntranceDate' AS `v30`, CONCAT(REPLACE(CAST(v7.`EntranceDate` AS CHAR(30)),' ', 'T'),REPLACE(TIME_FORMAT(TIMEDIFF(NOW(),CONVERT_TZ(NOW(),@@session.time_zone,'+00:00')),'+%H:%i'),'+-','-')) AS `v49`, 3 AS `v9`
FROM `Patient` v7

Fixed Query Fragment -- CAST(v7.EntranceDate AS CHAR(30) CHARACTER SET utf8)
SELECT v7.`ID` AS `ID1m20`, 'http://example.com/base/Patient#EntranceDate' AS `v30`, CONCAT(REPLACE(CAST(v7.`EntranceDate` AS CHAR(30) CHARACTER SET utf8),' ', 'T'),REPLACE(TIME_FORMAT(TIMEDIFF(NOW(),CONVERT_TZ(NOW(),@@session.time_zone,'+00:00')),'+%H:%i'),'+-','-')) AS `v49`, 3 AS `v9`
FROM `Patient` v7

Complete Example
Source Table - MySQL (sessionVariables=sql_mode=ANSI)
Use sql_mode=ANSI to support the ANSI-formatted scripts provided by rdb2rdf.
 However, if the first CAST doesn't include CHARACTER SET utf8 it doesn't matter if any of the remaining CASTs include the character set.
# including CHARACTER SET in the first CAST statement requires all remaining CASTs to include charset
SELECT v5.`ID` AS `ID1m20`, 'http://example.com/base/Patient#Height' AS `v30`, CAST(v5.`Height` AS CHAR  CHARACTER SET utf8) AS `v49`, 2 AS `v9`

# excluding CHARACTER SET from the first CAST statement allows other CASTs to include or omit the charset
SELECT v5.`ID` AS `ID1m20`, 'http://example.com/base/Patient#Height' AS `v30`, CAST(v5.`Height` AS CHAR) AS `v49`, 2 AS `v9`

Hi @thomasjtaylor,
Many thanks for extensively testing MySQL. That's an interesting issue, we need to dive into it.
Thanks for the suggestion.
Some of these tests (the ones about R2RML) were run once over 4.1.0 for MySQL and PostgreSQL:
https://github.com/ontop/r2rml-implementation-report
We haven't run them recently, but normally, we should now get a better score for the development version. If you are interested, feel free to have a look.
Best,
Benjamin

This may have been resolved in #779