More gossip broken promises due to network thread

Describe the bug
This is from a test mainnet node 12h after we merge network thread work, there are lower peers with mesh threshold

this is mostly due to p7

this is broken promise ratio

Expected behavior
Same broken promise ratio like with single thread mode

looks like this correlates to number of Nimbus peers

also we start publishing to lightclient topics since we move network to worker thread

there is also more late message delivery (this is monitored on beta mainnet node, v1.9.0-rc.0)

Moving this one forward for milestones as we continue to debug gossip issues when enabling the network thread.

this is a test mainnet node with useWorker=true, 2d chart

vs unstable

it shows network thread has been improved and comparable or better than default mode (useWorker=false)


Use bare minimum chrono features

Hey, we are using quick-junit in Deno. I'm trying to get rid of dynamic library that cost startup time. It turns out chrono's "clock" features pulls in iana-time-zone which pulls in the core-foundation on macOS.
This PR just disables the default features (including "clock") in chrono, no functional changes.

Thank you!

Released in quick-junit 0.3.5.


Add MaaS compatibility with Keystone v2.0

Currently the OpenStack MaaS plugins only support v3. The OSP project
requires that the plugins support Keystone v2.0.
This commit updates maas_common.py and the plugins so that both Keystone
v2.0 and v3 are supported.
Closes-Issue: https://github.com/rcbops/rpc-openstack/issues/668

I can't comment on those lines directly because GitHub doesn't allow it, but this does not address the problem in #668 of expires_at not being the correct attribute on the token. This also does not address the disparities between Keystone v2.0's serviceCatalog and v3's catalog structures.
See #683 for a far smaller fix that addresses those problems directly while avoiding adding more global state and refactoring things in a fix that might need to be backported.


Removed jcenter repository

jcenter is being turned off, so every project should migrate to an alternative, like mavenCentral

do open this pr to https://github.com/CodetrixStudio/CapacitorGoogleAuth


Properly use Python3's buffer interface.

Description
When using luigi with Python 3 there is issue running PigTask. Because output in track_and_progress is both read to unicode string and copied to temporary file, it failed as conversion to string happens before writing to file. I simply moved decoding after writing to temporary file.
Motivation and Context
Without this change, running PigTask ended with following error:

File "/projects/big-data/luigi-tasks/libs/pig_task.py", line 57, in on_execute
PigTask.run(self)
File "/home/etl/.projects/big-data/lib/python3.4/site-packages/luigi/contrib/pig.py", line 127, in run
self.track_and_progress(cmd)
File "/home/etl/.projects/big-data/lib/python3.4/site-packages/luigi/contrib/pig.py", line 149, in >track_and_progress
temp_stdout.write(line)
TypeError: 'str' does not support the buffer interface

And while Pig script finished successfully, luigi marked it as failed.
Have you tested this? If so, how?
After making this change locally our Pig scripts run without issues using Python3.4

Can you add a test case?

I'll give it a shot afternoon.

@Tarrasch Instead of adding new test case I changed fake Popen stuff to let PigTask read input (by returning None from poll at least once). It was enough to make all tests fail. And applying fix fixed that.

LGTM. But someone knowing pig should review.

Actually this issue has nothing to do with Pig itself, but if you know such a person it would be great to let her/him know.

Okay. If nobody comments for a while I suppose this can be merged.

LGTM, I would just change line 130 to temp_stdout = tempfile.TemporaryFile('wb') to make it explicit that the temporary file is expecting binary and not string.

@gpoulin Good point, thank you for that, I've just pushed this change.

lgtm


Improve Performance on Letterpress and Other Augmentations Relying on Noise Generation

Augmentations that rely on perlin noise generation are particularly slow, including Letterpress and others.
It would be great if the augmentations taking more time can be made more efficient/leverage GPU as it is too slow to practically use the bottom ones in the list for training.
I tried to train a model using letterpress and found that its one epoch was taking 12x more time than without applying the augmentation. I timed most augmentations on augmenting 7 images and here are the results:

Here is the code for timing:
aug_list = [
        DirtyDrum(line_concentration=0.5, noise_intensity=1.0, direction=2),
        BleedThrough(intensity_range=(0.6, 1.0), offsets=(7, 7), alpha=0.5),
        DirtyRollers(),
        Dithering(),
        Faxify(),
        InkBleed(severity=(0.5, 0.8)),
        Letterpress(),
        LowInkRandomLines(count_range=(10,15)),
        Markup(),
        PencilScribbles(size_range=(250, 400), count_range=(1, 10), stroke_count_range=(1, 6)),
        BrightnessTexturize(),
        ColorPaper(),
        Gamma(),
        Geometric(rotate_range=(-3,3)),
        LightingGradient(),
        PageBorder(width_range=(5,10)),
        SubtleNoise(subtle_range=25),
        BadPhotoCopy(),
        BindingsAndFasteners(ntimes=(2, 4)),
        Folding(fold_count=4),
        Jpeg(),
        NoiseTexturize()
        ]

    times = []

    for aug in aug_list:
        start_time = time.time()
        aug_imgs = []
        for img in imgs:
            aug_imgs.append(aug(img))
        end_time = time.time()
        times.append(end_time - start_time)

Thanks for the feedback. Right now the performance improvement is in our improvement roadmap and it should be included in the next major update.

The key issue with these slower augmentations is the noise generation process.  So, we will use this issue to focus on approaches to speed noise generation while retaining an essential level of random variation in the distortions.
These augmentations should all be improved once we can improve the noise generation process:

Letterpress
BleedThrough
BadPhotoCopy
LightingGradient
PageBorder
NoiseTexturize
DirtyDrum
InkBleed
Faxify

We've recently released a performance improvement via #270 which included use of Numba to optimize loops.  However, we found there remain a lot of opportunity to improve the noise generation processes which most heavily impact augmentation performance.


why can't gripper  pick the cube

I replay this trajectory but the grip cannot pick up the cube,I have changed the stiffness,damping,effort and friction,but make no sense
https://github.com/user-attachments/assets/010e911e-b904-4106-becd-ae25df1fd6e9

Is this your custom robot or one of the prebuilt ones?

这是您定制的机器人还是预制的机器人之一？

custom robot,more specifically,it's realman arm and inspire gripper(EG2)

Another question I can't understand : I set the friction (of the gripper of panda) to 0 , the gripper  pick up the cube still , which is abnormal
        _materials=dict(             gripper=dict(static_friction=0, dynamic_friction=0, restitution=0.0)         ),

can you share the URDF and the agent class you created? Could be something not defined well.

can you share the URDF and the agent class you created? Could be something not defined well.

of course,here is my robot urdf
`

`
(Actually I've solved this issue by setting the parameters(stiffness,damping,friction) to a very very large value,which I think is not reasonable.Really hope you can propose other better solution,thank u very much

can you share the URDF and the agent class you created? Could be something not defined well.
here is my robot urdf:

can you share the URDF and the agent class you created? Could be something not defined well.

can you share the URDF and the agent class you created? Could be something not defined well.
rm75.zip
it seem failing to show the urdf,I compress it to .zip

Do you have the reset of the assets for the URDF? Moreover do you have an example base agent class implementation

Do you have the reset of the assets for the URDF? Moreover do you have an example base agent class implementation

Thx for ur reply.I've figured out the problem.Actually ,it's all because of the structure of my gripper.The opposite direction of rotation in the 4 'revolute' joints results in the failure when picking up.


i have write a scaffold for vue-cli,can you add it to this readme?

i have write a full stack of loopback+vue scaffold,can you add it to this readme?
for help user use loopback+vue much easy. one more choose ,is better for CLI maybe
https://github.com/qxl1231/loopback-vue/tree/master
any issue, please feel free to contract me  ~

and my question is: how to add my scaffold to your cli tool? the yeoman is use NPM ,for example i only need to publish ,and add key words yeoman , but how to add my custom scaffold to your CLI tool?

vue init github-username/repo-name

The readme is only for official templates, I guess you can add yours to https://github.com/vuejs/awesome-vue#boilerplates


chore: migrate DragHandle component from jsx to tsx

SUMMARY

PR for migrating HiddenControl functional react component from JSX to TSX
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[x] Has associated issue: #10004
[x] Enhancement (new features, refinement)
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@etr2460 Ptal, thx!

lgtm! if you wanted to make this as functional component too, i wouldn't complain. but that doesn't need to be addressed

Sure, will give it a shot. :)

Thanks for this improvement @Damans227 !


Use global separate openstack helm toolkit definitions for openstack servuces

Replace local chart definition for separate osh toolkit in favor of
upstream global chart definitions that is now availble.

Upstream patch has been merged. This is ready for review and merge.

Could you please recreate this as a PR from you own fork of the socoks repo. IIRC we agreed some weeks ago to not create devel branches on the main repo. Thanks.

Talked with James. He will use fork next time so I will merge this time as its blocking local.


Unicode characters in project names

A few errors in production.... looks like someone was trying to create a project with a name made up of Unicode characters
2018-07-16T09:47:30.69+0100 [APP/PROC/WEB/2] ERR {"name":"ml-for-kids","hostname":"032dfbf0-71c7-4343-46d6-8b3a","pid":51,"level":50,"err":{"message":"Incorrect string value: '\\xEF\\xBC\\x9F' for column 'name' at row 1","name":"Error","stack":"Error: Incorrect string value: '\\xEF\\xBC\\x9F' for column 'name' at row 1\n    at PromisePoolConnection.PromiseConnection.execute (/home/vcap/app/node_modules/mysql2/promise.js:102:20)\n    at Object.storeProject (/home/vcap/app/dist/lib/db/store.js:100:47)\n    at <anonymous>\n    at process._tickDomainCallback (internal/process/next_tick.js:228:7)","code":"ER_TRUNCATED_WRONG_VALUE_FOR_FIELD"},"msg":"DB error","time":"2018-07-16T08:47:30.698Z","v":0}

Presumably they were trying to call their project:  ï¼Ÿ

I quickly tried creating a project with that name and it seemed to handle it fine. That's odd.

There we go.... an emoji will do it

2018-07-16T10:50:25.95+0100 [APP/PROC/WEB/0] ERR {"name":"ml-for-kids","hostname":"e8961500-1d42-43d7-423e-2dfc","pid":57,"level":50,"err":{"message":"Incorrect string value: '\\xE2\\x9A\\xBD' for column 'name' at row 1","name":"Error","stack":"Error: Incorrect string value: '\\xE2\\x9A\\xBD' for column 'name' at row 1\n    at PromisePoolConnection.PromiseConnection.execute (/home/vcap/app/node_modules/mysql2/promise.js:102:20)\n    at Object.storeProject (/home/vcap/app/dist/lib/db/store.js:100:47)\n    at <anonymous>\n    at process._tickDomainCallback (internal/process/next_tick.js:228:7)","code":"ER_TRUNCATED_WRONG_VALUE_FOR_FIELD"},"msg":"Server error","time":"2018-07-16T09:50:25.953Z","v":0}


how to edit node or child name?

how to edit node or child name?
or use context menu on node?

Hi @manvfx @rubparsa, have you got anything to add, edit and delete a node?

Hi @anoop-chauhan, check my repository:  https://github.com/rubparsa/editor-curso/
Finally I used FancyTree, in this Typescript file you can check it:
https://github.com/rubparsa/editor-curso/blob/master/client/src/app/components/capitulo-add.component.ts
Hope it helps you.


Many internal void functions unintuitively contain the word "get"

Many of Godot's void functions start with "get", and this seems unintuitive to me. I would expect a function starting with the word "get" to return a value. If the function's purpose is to obtain data from somewhere but not return something, perhaps it would be better to use the word "load" instead of "get".
For a full list (there are quite a few), here's a grep one-liner to search for them (excludes pointer-containing functions and code in thirdparty, since there's lots of Bullet code that does this too):
grep -Ri "void get_" | grep -v thirdparty | grep -v "*" | grep -i "void get_"

Just to pick one out at random as an example, void EditorData::get_plugin_window_layout only operates with the passed-in variable and its own internal field editor_plugins. If I understand how this function works correctly, it would make more sense to call this function load_plugin_window_layout instead. CC @reduz

Hi,
IMHO when you know the "trick" it's not really a problem. For your example and from my POV, "load_plugin_window_layout" would mean that I want to load a layout for a window, when I actually want to get the layout infos of the window (don't know if I'm clear here...)
If it should be modified, I'd like to suggest "fetch_" instead of "load_", as it as the same meaning as "get_" (we still want datas from the function) but will allow to have different meanings for the function's type.

Using an argument (pointer/reference) for result instead of function return value is normal. I don't think there should be a different name for this approach.

@starry-abyss Which I why I excluded lines containing *, or do you mean something else?

In the example void EditorData::get_plugin_window_layout you mentioned, the argument is a smart pointer (Ref<>). Apparently, the function writes the result to pointed-by memory, so it doesn't also need a second (traditional) return value.


The last version seems don't work

hi:
The last version svg.js and svg.draggable.js seems don't work.
Browser:Firefox
code:

Sorry. That is my fault.


Added a stack trace to the http/grpc recovery log

Coverage increased (+0.04%) to 97.332% when pulling 76134f605cfdef2316d5c42ccd84a12dcc64dd68 on recovery into 525e6d8c7d0175ae4e0db43dd3b91f812bc9ef42 on master.


Cleans up Cassandra Session logic in preparation of Driver v4

The more notable change in Datastax Driver v4 is consolidation of
Cluster and Session types. This centralizes logic to create a session
regardless of test or mainline. It also ensures the cluster object is
closed during main and test code when storage is.

thanks for having a look @anuraaga!


support windows

Ensure flv-future-aio compiles and run in non unix platform.  Features like Zero copy should be only be enabled in the unix platforms.

fixed.  Windows is supported by CI


Feature Request: Add gif functionality to images view

Maybe the image view could be expanded to a general-purpose view to support both images and gifs via the usage of gif-pros?

Sounds great, will add that to my todo to investigate for a future minor update!

Having done some basic testing, I found that https://github.com/theol0403/gif-pros is fully compatible with Robodash's view system. I could help write a PR to add a new GIF view to the template, but I'd like to hear your opinion on embedding gif-pros.


x Fixed compilation issues with some #defines

Compilation currently fail when MEDIAINFO_XML_YES and/or MEDIAINFO_ADVANCED is not defined.

thanks!


use target: webworker

We should force the target: webworker configuration in webpack, it will avoid webpack's runtime to use window or document.

@xtuc is there any way we can get a minor version push to npm to include this update? :cry:

You can set target: "webworker" in your webpack configuration, if you have one as a workaround.

You can also clone this repository and run cargo install --force --debug --path . to get the latest version. This does not come with many QA guarantees though, we try to only merge things into master that we are confident with, but we do more rigorous testing on releases.


fix: #231 Print target requests value

The m.Spec.TargetRequests in this case will never be nil, because it can be set by default value as 100. So I just fix it by de-referencing.

Thanks @benz9527 for taking this in on yourself! Greatly appreciated.


fpb-lint action comment on PR

What does this PR do?
Improve repo
For resources
Description
This PR attempts to relieve some of the work needed by reviewers. It should do a couple of tasks on PR's

If lint task fails, it will comment on the PR letting the dev know what failed
If lint task fails, it will add "lint error" label to PR
When lint task passes, comments and labels are removed

It may still need a bit of work, but posting to get some feedback.
Why is this valuable (or not)?
This makes it so reviewers do not need to go through dozens of PR's pointing out the lint has failed, it will be done automatically.
How do we know it's really free?
N/A
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines.
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[ ] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

I fixed the build

this will be great.

When lint task passes, comments and labels are removed
only the lint label should be removed. no comments should be removed.


1.3.1 не позволяет запустить майнкрафт

Describe the bug
При попытки запуска игры лаунчер выдает exception
To Reproduce
Установить fsit 1.3.1
Запустить майнкрафт через prism launcher
Expected behavior
Запускаться
Screenshots

Logs
https://mclo.gs/3hEBVa4
Info (please complete the following information):

OS: Win 11
Minecraft Version: 1.20.1
Mod Version: 1.3.1

Yep, that's the release problem. I'm re-uploaded mod to Modrinth and wait for approving from CurseForge. Sorry for the inconvenience.

still have same issue

Are you re-downloaded FSit? If there is fsit-1.3.1-shadow.jar you need to remove it and replace with fsit-1.3.1.jar.

I've republished a release, because Modrinth didn't actually replace a jar file on servers. Now it's launching without problems (want to believe).


New animal, Pig

About the PR
Simple mob with no special mechanics.
I decided to add it for practice purposes and because this sprite is really cute.
Screenshots

Changelog

:cl:

add: Added new animal, pig, and new chef's pig-companion.

Please consider adding breath mask and tanks for it.
https://github.com/space-wizards/space-station-14/pull/12376
For reference.

Please consider adding breath mask and tanks for it.
#12376
For reference.

Done.
Masks are a bit ugly, but pigs have a specific face shape, and I'm a mediocre artist.


method k:v if condition

method obj if condition is compiled into
if (condition) method(obj);

However, method k:v if condition is compiled into
method({
  k: condition ? v : void 0
});

I guess method(k:v) if condition is far more frequently intended than method k: (v if condition). Is it reasonable that we change this precedence?

Yes, I think it is. This is an example of the rewriter going too far, and wrapping the object around the postfix if statement ... when the postfix if statement should really be closing the implicit object.

I bumped into this recently myself, in fact: I thought I'd be able to create an array of objects with
key: val for x in y

I feel like there's already an open issue on this... maybe @michaelficarra knows?

+1, I've got this bug today.

Yeah, I could swear this used to work properly. Perhaps a side-effect of satyr's big rewriter fixup?

Nope, definitely not a recent change. I do believe there's an open issue for this. I'll try to find it.

Implicit object is a more diff{erent,icult} beast than implicit call in that it naturally spans multiple lines:
a: b
c: d if e

What should it mean?

{a: b, c: (d if e)}
{a: b, c: d} if e
{a: b}; {c: d} if e

As always, @satyr makes an excellent point. Naively, I would want:
a: b if c
# into:
{a: b} if c

a: b
c: d if e
# into:
{a: b, c: e ? d : void 0}

... but that's fairly horribly inconsistent. Perhaps our current behavior is the best option?

Perhaps our current behavior is the best option?

I don't think so.
coffee -bep 'a = b: c if d'
var a;
a = {
  b: d ? c : void 0
};

postfix if should encompass the whole line in instances like those (and the OP's)

+1 for #3

:+1: for #3

#3 is good. But I'd like to add that there is another way to interprete the object:
a: b
c: d if e

The object is {a: b} if e is false, and is {a: b, c: d} is e is true. I know this seems to introduce a new syntax (and might not be feasible), but I simply want to point out that there is another way to interprete it. :)

I guess "{a: b, f: g}" if e is false, and "{a: b, c: d, f:g}" if e is true. Basically a rough rule is, the express (spans as long as reasonable) before if is effective  if the condition is true.

Huh. @gravof's suggestion is actually something I've often wished for when conditionally passing (as opposed to not passing) a particular keyword argument to a function. +0.7, but let's save it until after the issue at hand is resolved?

Apparently I'm in a special cases mood today, because I've opted for door number 2 -- special casing it so we get the intuitive behavior in both cases.
The rule is this: IMPLICIT_ENDs (postfix for, if, unless, etc.) will close implicit objects if they occur on the same line that the object was started on. If the implicit object continues onto multiple lines, only an explicit terminator or outdent will close it.
So:
call a: b if c

call
  a: b
  c: x for x in list

Means:
call(a: b) if c

call
  a: b
  c: (x for x in list)

Shouldn't this compile too?
$ bin/coffee -bce '{a: b if x, d: e if y}'
({
  a: x ? b : void 0,
  d: y ? e : void 0
});

$ bin/coffee -bce 'a: b if x, d: e if y'
Error: Parse error on line 1: Unexpected ','
...

http://stackoverflow.com/questions/8629339/how-to-properly-use-for-in-list-iteration-inside-coffeescript-object-indentat


Corrected comment to keep the docs readable

High-level description
This PR removes an extra comment for AR cache lua code to keep the docs readable.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
https://jira.mesosphere.com/browse/DCOS-39104
Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ x ] Read the DC/OS contributing guidelines
[ x ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@orsenthil also here the mergebot/enterprise/build-status/aggregate is read (the corresponding EE PR has one non-required check failed) Could you have a look please? Thank you!

@mesosphere-mergebot label ship-it


Adding the LATCH binary descriptor

Based on the following paper:
Gil Levi and Tal Hassner, "LATCH: Learned Arrangements of Three Patch Codes", arXiv preprint arXiv:1501.03719, 15 Jan. 2015
http://arxiv.org/abs/1501.03719

Seems as though there are merge conflicts in xfeatures2d.hpp.
Can someone please provide some guidelines on how I can resolve it?
Thanks!
Gil

My first guess due to the kind of bogus error message is that your branch isnt submitted on top of the latest contrib repo. Is that possible?

your xfeatures2d.hpp is lacking LUCID so it is probably too old.
there will  probably be more elegant ways of resolving this, but:

save a copy of latch.cpp and your changes to xfeatures2d.hpp elsewhere
git checkout master
git pull upstream master //(get latest contrib)
git branch -D AddingLATCH // yep, delete it ;)
git checkout -b AddingLATCH   // start from scratch
add your latch.cpp, and append to xfeatures2d.hpp, commit
git push -f origin AddingLATCH  // -f for force overwrite


Incorrect value of trimmedByteRange in certain case.

Description
There is a strange incorrect value of trimmedByteRange, when using ❤ . I tried with another emoji , and there is no problem.
Steps to Reproduce
//Bug
let str1 = """
❤

func foo(str: String) {

}
"""

//Bug
let str2 = """
❤❤❤❤❤

func foo(str: String) {

}
"""

//Normal
let str3 = """
a❤❤❤❤❤

func foo(str: String) {

}
"""

//Normal
let str4 = """

func foo(str: String) {

}
"""

public override func visit(_ node: FunctionDeclSyntax) -> SyntaxVisitorContinueKind {

	**let offset = node.trimmedByteRange.offset // -> 0 for str1 and str2 (Bug)**

	return .visitChildren
}

Tracked in Apple’s issue tracker as rdar://114755239

The following response is under the assumption that you are expecting trimmedByteRange to strip away the hearts. If you’re expecting something else, please re-open the issue and let me know.
This behaves correctly. From the doc comment of trimmedByteRange:

The byte source range of this node excluding leading and trailing trivia.

But if you print the tree, you’ll see that the hearts aren’t trivia but unexpected nodes within the tree. Since trimmedByteRange doesn’t remove unexpected tokens, this behavior is expected.
FunctionDeclSyntax
├─attributes: AttributeListSyntax
├─modifiers: DeclModifierListSyntax
├─unexpectedBetweenModifiersAndFuncKeyword: UnexpectedNodesSyntax
│ ╰─[0]: binaryOperator("❤")
├─funcKeyword: keyword(SwiftSyntax.Keyword.func) leadingTrivia=newlines(3) trailingTrivia=spaces(1)
├─name: identifier("foo")
├─signature: FunctionSignatureSyntax
│ ╰─parameterClause: FunctionParameterClauseSyntax
│   ├─leftParen: leftParen
│   ├─parameters: FunctionParameterListSyntax
│   │ ╰─[0]: FunctionParameterSyntax
│   │   ├─attributes: AttributeListSyntax
│   │   ├─modifiers: DeclModifierListSyntax
│   │   ├─firstName: identifier("str")
│   │   ├─colon: colon trailingTrivia=spaces(1)
│   │   ╰─type: IdentifierTypeSyntax
│   │     ╰─name: identifier("String")
│   ╰─rightParen: rightParen trailingTrivia=spaces(1)
╰─body: CodeBlockSyntax
  ╰─leftBrace: leftBrace

What you might try instead, is to get the first token in the fixed tree using tree.firstToken(viewMode: .fixedUp), which will skip over unexpected tokens. You can then get that token’s position/location/offset/...

I don't understand why if there are unexpected nodes outside the range of the function, FuncDecl will include them?

I believe it's because instead of a heart symbol, you could have attributes there. If I'm not mistaken, the following Swift code is valid:
@available(*, deprecated, message: "❤")

func foo() { print("don't use me :'(") }

I believe it's because instead of a heart symbol, you could have attributes there. If I'm not mistaken, the following Swift code is valid:
@available(*, deprecated, message: "❤")

func foo() { print("don't use me :'(") }

There is no problem to take the attributes as a part of the FuncDecl, my question is why FuncDecl must include the unexpected node that is outside the range of the function?
❤

@available(*, deprecated, message: "❤")

func foo() {
	print("don't use me :'(")
}

Another thing I didn't understand, why only the Unexpected Nodes that are above a FuncDecl are included while in VariableDecl the Unexpected Nodes that are above and below are both included?

We need to include the unexpected tokens somewhere and including them as part of the FunctionDeclSyntax is as good a place as any other. I.e. would it really make any more sense to include them in the CodeBlockItem or at the start of the SourceFile? I don’t think so.
From an implementation perspective: The way the parser works is that it skips unexpected tokens during the parser and then attaches these unexpected tokens in front of the token that it was expecting – in your case, this is the func token.


Defect and Feature Request: Renaming a feature branch dissociates it from its changelist

Issue
If you rename a feature branch --- either at the command line or with the VCS -> Git -> Branches -> Rename menu option in the IDE --- it becomes disassociated with its changelist.
For example, I can rename a feature branch from "feature/my-feature-1" to "feature/my-feature-1-with-different-name" (CLI or in IDE), and all is well. Let's call the changelist associated with this feature branch "my-feature-1". Of course, however, from time to time I need to make a different changelist active, and gitflow4idea conveniently also automatically switches to (or creates) the target branch associated with that changelist. For this example, let's say this other changelist is called "my-feature-2" and its associated feature branch is "feature/my-feature-2".
Switching from changelist "my-feature-1" to "my-feature-2" works fine, thus still no problems so far. However, as soon as I switch back from changelist "my-feature-2" to "my-feature-1", gitflow4idea tries to checkout "feature/my-feature-1" (instead of "feature/my-feature-1-with-different-name"), does not find it, and so creates a new, empty branch called "feature/my-feature-1", which is obviously not the desired behavior.
Request (Summary)

Provide an option to enable preventing the problem in the first place.
Provide an option to allow the user to be warned before the plugin creates an unwanted, empty branch.
Provide an option to help correct the problem if it has occurred.
Routinely check if the presently-active branch matches that associated with the presently-active changelist and, if not, warn the user, with an option to then correct the problem (item 3).

Request (Details)

Add an option in the gitflow4idea UI to rename a branch that prevents this problem (related: see Technical Details, next section).
Add a (boolean) setting that allows users to specify if they want to be warned before creating a new branch under the following conditions:

The user is making a different changelist active (i.e., is switching changelists)
The target changelist has a feature branch associated with it
This associated feature branch does not exist

As a part of the interaction for warning users (item 2), provide a list of branches and allow the users to pick the correct branch with which to re-associated the changelist with a branch.

It's probably wise to limit the list of branches to those following under the feature-branch-prefix (e.g., feature/, topic/, etc.) specified in .git/config.
It's probably wise regarding the list of branches to list all those branches already associated with a changelist last, and emphasize this fact (e.g., perhaps using an italic font, using a different font color, such as grey, and even under a separate a dialog-box section, named, for example, "Already in use").
If there are any issues with having a feature branch associated with more than one changelist (e.g., the user selects an "Already in use" branch), either warn the user of the possible consequences of doing so, or, if such issues are serious enough, disallow using already-in-use changelists altogether.
It's probably also helpful to further divide the list of available feature branches such that matches "similar" to the existing association are shown first, then all others (e.g., in the example in the previous section, very simple pattern matching, e.g., start of strings match, would detect that "feature/my-feature-1-with-different-name" is a good candidate for what was "feature/my-feature-1").
An even more helpful implementation of the previous would be to have some sort of criteria and algorithm that determines if there is a clear best candidate, and as a first step prompts the user to use it, before presenting the list of (feature) branches (e.g., "Branch 'feature/my-feature-1' no longer exists. A different branch, 'feature/my-feature-1-with-different-name', is not associated with any changelist and is named similarly. Would you like to associated this branch with this changelist?: Yes, No, Select Different Branch, Cancel).

Whenever possible and as often as needed, warn the user if the active feature branch does not match what gitflow4idea thinks it should be, as well as provide an option to correct this (i.e., an option that redirects him or her to the functionality in the previous item 3). If gitflow4idea can be notified when the IDE refreshes / resyncs with native git, that likely would be an ideal time to check if the branch name is different than expected, and such an implementation would require very little additional processing overhead. (This of course might not be possible or there may be other, preferable solutions.)

Technical Details
This issue is rooted in the fact that, when a git branch is renamed (CLI or in IDE), the appropriate <branch> entry (within the appropriate <task> entry) in the file .idea/workspace.xml is not updated.
For the example in the first section, then, the following entry:
<branch name="feature/my-feature-1" repository="$PROJECT_DIR$" />
should have been updated to the following when the branch was renamed:
<branch name="feature/my-feature-1-with-different-name" repository="$PROJECT_DIR$" />
(Indeed, making such a correction manually is trivial and is how I fixed things when I first encountered this problem.)
For CLI, updating this <branch> entry likely would be accomplished using git hooks, and, as such, is probably out of scope of what gitflow4idea cares to handle.
For the Jetbrains' IDEs, updating the branch entry ought be trivial, at least in the case of Request item 1 (above). For the "native" IDE option to rename a branch (i.e., menu option VCS -> Git -> Branches -> Rename), the ease of implementing a solution of course will depended whether Jetbrains plugin authors can either create hooks to that menu option (or perhaps register callbacks with it).
Context

Gitflow4idea version: 0.6.6
Gitflow version: 1.9.1 (AVH Edition)
PyCharm version:

PyCharm 2018.2.4 (Professional Edition)
Build #PY-182.4505.26, built on September 19, 2018
JRE: 1.8.0_152-release-1248-b8 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.13.0-38-generic

Thanks for the very detailed report @morsedl
I'll have a look at this when I get the chance

@morsedl I assume you're talking about changelists created with the new task dialog?

@OpherV Yes, that is correct. SVN supports changelists, but Git does not. So far as I am aware, changelists for Git Repos in Jetbrains IDEs is a function provided soley by the IDE and not really accessible outside of the IDE.

@morsedl So to summarize as I understand the issue is

Git branches and changelists are created for new task. The branches are are properly associated with the changelist
When a branch is renamed, it loses association with the original changelist

Yes?

@OpherV : Correct. This can of course happen outside of the IDE, with say CLI git or git-kraken or whatever. The plugin won't know of this of course until after the fact, hence the need for some sort of detection and correction within the plugin. But even down within the IDE, as I described, the disassociations still happens. Probably because the steps to renaming a branch aren't hooked up with the plugin. So if those menu actions have hooks or one can insert an inverse dependency, your plugin could know about the branch renaming as it's happening and ensue the associations is properly maintained. More likely I imagine, however, is no such hooks / possibility for reverse injection exists. So, that's where the same detection and correction mechanisms you might write for handling the renaming of the branch outside of the IDE might also become the only way of dealing with a branch renaming even if the use is doing so right within the IDE. Hope this helps.

Note that in my summarized description I haven't mentioned git flow at all.
While I completely agree that it would be nice to have a feature that keeps branches aligned even after rename, it sounds out of scope for this plugin and more like something IntelliJ could implement generally in their git plugin.
My suggestion would be essentially cutting and pasting the important bits of this discussion to the proper IntelliJ bug reporting channels
Closing for now


Use namespace from Rollouts resource to avoid unauthorized access to other HTTPProxies

Closes #17

@izturn could you please help to review, thanks.

thx @mvgmb   LGTM


fix(social-icons): "rel" attribute with multiple values in links

The <a> tag of social icons had two rel attributes, which didn't work — only the first one was kept. Instead of using the rel attribute twice with different values, we want to use it once with two values.

Looks good to me! Thanks @gprst

@all-contributors please add @gprst for code


npm run build后出现这个⚠ ⚠ ⚠  It's not recommended to use webpack.config.js, since roadhog's major or minor version upgrades may result in incompatibility. If you insist on doing so, pl ease be careful of the compatibility after upgrading roadhog.

npm run build后出现这个⚠ ⚠ ⚠  It\'s not recommended to use webpack.config.js, since roadhog\'s major or minor version upgrades may result in incompatibility. If you insist on doing so, pl ease be careful of the compatibility after upgrading roadhog. 这个问题大不大啊？请问有没有什么解决办法？

我也遇到这个问题，是不是出现这个问题后热处理不行的啊，我改了代码一定要重启才能生效

roadhog报的警告，没问题


How to get Kubernetes log messages from inside Prometheus?

prometheus/discovery/kubernetes calls Kubernetes code; Kubernetes code logs via glog; there doesn't seem to be a way to set the glog level inside Prometheus.
glog does set up command-line options like -v via flag.Var(), but because nobody is calling flag.Parse()  they don't help.

In the 2.0 branch we are overwriting the error handler and handle the logging of errors from the k8s code base ourselves: https://github.com/prometheus/prometheus/blob/dev-2.0/cmd/prometheus/main.go#L205-L212

That appears to be yet another thing.
I'm talking about for instance https://github.com/prometheus/prometheus/blob/dev-2.0/vendor/k8s.io/client-go/tools/cache/reflector.go#L236

I see, ultimately, this is a severe mis-design of Kubernetes libraries in general and we currently don't and cannot provide flags for a basically arbitrarily chosen and unswappable logging library somewhere in our dependencies.
Why are you interested in seeing those debug logs?

Got an error from discovery; didn't understand it; wanted more context what the k8s library was doing.
More specifically it was a customer running the program so I preferred to say "run with -v=8 and send me the full log" - even though most of the information is useless it is good to get it all in one hit rather than go back 20 times "ok, now try this...".

Yes, that's right. It would be great to just show those messages when debug logging is enabled but with k8s' current approach I don't see a sane way for us to do it =/

Request to fix Kubernetes http://github.com/kubernetes/kubernetes/issues/61006

--log.level=debug displays the Kubernetes logs since #4931.


add 2D cross product

Add 2D cross product and test.

Thanks for the PR! The 2D cross product addition looks great


doesn't work with multiple apps

This appears to make the assumption that the page only has a single angular app running. Batarang makes the same assumption but is changing that in the next version, so that these tools will work with things like overmind.

Do you have an example page that shows this issue? The maintainer of the project posted a screenshot in issue #19 when a user reported the same problem (showing that it works with 2 apps), but the reporter never provided a sample to test with. I'd be happy to take a look if you have some live code to share.

@geddski the problem you were having may be related to some other issue, ng-inspector does indeed account for and handle multiple apps in the page. I'm closing the issue for now, feel free to open a new one if you still encounter issues.


logger fix

Fix for #6909
Not sure if this can lead to infinite loops.
        except Exception as e:
            Logger.exception("Unexpected exception in logging", e)

to be sure, could you write a simple test showing the issue on your machine, and check that the fixed code works with it? bonus points if that's a unittest we can run in CI, that would be most comforting :).

To me, the whole thing should actually be unit tested to show the point.
It shouldn't be that hard to add a test calling the _write_message() method showing that Logger.exception() is then getting called


[YBUG.IO] I have USDT in my liquality...

I have USDT in my liquality wallet and I am trying to lend.  my deposit is rejected... thoughts
Source url: https://live.sovryn.app/lend
Reported by<EMAIL_ADDRESS>Reported at: 26 Apr at 17:16 UTC
Location: US, California, Costa Mesa
Browser: Chrome 87.0.4280.88
OS: macOS 10.10.4
Screen: 1440x900
Viewport: 1440x820
Screenshot:

For more details please visit report page on Ybug:
https://ybug.io/dashboard/reports/detail/angv163fxnw290m31r0r

Sent user follow-up email with instructions to use RSK tokenbridge


The difference between components/Elements and components/*.

Hi, thanks for the nice architecture design!
I would like to ask you a question regarding the title🤔
I would like to know the difference between
a component placed in components/* and
a component placed in components/Elements/*.
Specifically
Head and Layout are global, so I understand that they are placed outside of Elements, but I feel uncomfortable that Form and Notifications are also placed there.
I would like to know what criteria are used to place them there.

Hey,
In Elements we have components that would belong to a design system such as Buttons, Links, etc. Maybe Elements should be changed to something like ui, but that is a matter of preference.
Form contains the behavior of a form thus should not belong to Elements. It is shared but not as simple as the UI components.

Thank you for your reply.
I believe Form and Notifications are part of the design system.
Why don't UI components with behaviors belong to Elements?
Notifications has behaviors, but the processing is in the useNotificationStore, so I don't think that complex processing is written in Notifications itself.
Since Notifications also has behaviors, does that mean it is not included in Elements?


Why is _version__ missing in the pip package?

This works, was due to a cached old version of openghg on user's computer.


Added package parameter for JUnit-Reporter

This PR creates a new optional parameter for the JUnit-Report called package which holds the base package of the test suites that are handled by this reporter. The parameter defaults to ''.
The purpose of this change is to be able to specify a general classification for tests that are handled by this reporter. Otherwise all these tests have the root package in Jenkins test result aggregation.

Seems pretty innocent and straight forward, and thanks for adding both documentation and tests for the new feature. However, since this is random user-defined input the value should be passed through escapeInvalidXmlChars before insertion into the XML to make sure it doesn't become malformed if someone uses a creative package name.

Added a couple commits to expand test coverage, escape invalid XML characters, and only modify XML output if a package is provided.
Thanks, this will land in 2.0.6.


UI freezes

I have a project that contains data driven tests that generate a total of 117 350 test cases (theories). The runner does not seem to be able to handle this many tests. Visual Studio grinds to a halt when I run my tests. It's hard to determine if this is a UI issue or if my tests are running slower because of this. I don't think the runner itself is slowing down though.

Sounds like it's probably a UI issue - that's a lot of tests :)
What version of ReSharper are you using?

9.2 running in VS2015.
Could it be that test progress reporting is slow with that many tests?

Repro:
public class DataDrivenTests
{
    public static IEnumerable<object[]> GetNumbers()
    {
        const int Size = 10000;
        var numbers = new List<object[]>(Size);
        numbers.AddRange(Enumerable.Range(1, Size).Select(i => new object[] { i }));
        return numbers;
    }

    [Theory]
    [MemberData("GetNumbers")]
    public void Test(int x)
    {
        Assert.True(x > 0);
    }
}

Try increasing or decreasing the value of Size to see what I mean. A value of 10000 is enough to absolutely slaughter my mid-range laptop.


Learning this as I go, can't sort out this error (init.lua, unable to find HDF5 lib)

Hi there, apologies in advance as this is all entirely brand new to me, and I feel like what I'm doing is incredibly rudimentary but I've hit an error I can't sort out. I've been searching for similar cases but nothing seems to have worked and I'm not versed at all in working in Terminal or Linux or any of these programs, unfortunately, so I may need a hand-hold, explain-like-I'm-5 sort of set of steps.
I'm running Ubuntu 18.04 in a VM on my PC so that I can run Torch and do a basic sort of plug-and-play "we input a list of [THING] and had a bot try to create its own list of [THING]". Here's my VM settings:

For the most part, I'm using this blog to coach myself along: http://www.jeffreythompson.org/blog/2016/03/25/torch-rnn-mac-install/
Any hiccups I've been able to address, be it installing things not explicitly stated, etc. But here's the command I'm caught up on:
th train.lua -input_h5 data/All5Leagues.h5 -input_json data/All5Leagues.json -gpu -1
And here's the Terminal copy-paste with the error:

bryan@bryan-VirtualBox:~$ cd torch
bryan@bryan-VirtualBox:~/torch$ cd torch-rnn
bryan@bryan-VirtualBox:~/torch/torch-rnn$ th train.lua -input_h5 data/All5Leagues.h5 -input_json data/All5Leagues.json
/home/bryan/torch/install/share/lua/5.1/hdf5/init.lua:15 Unable to find the HDF5 lib we were built against - trying to find it elsewhere
/home/bryan/torch/install/bin/luajit: /home/bryan/torch/install/share/lua/5.1/trepl/init.lua:389: /home/bryan/torch/install/share/lua/5.1/trepl/init.lua:389: /home/bryan/torch/install/share/lua/5.1/hdf5/ffi.lua:29: libhdf5.so: cannot open shared object file: No such file or directory
stack traceback:
[C]: in function 'error'
/home/bryan/torch/install/share/lua/5.1/trepl/init.lua:389: in function 'require'
train.lua:6: in main chunk
[C]: in function 'dofile'
...ryan/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
[C]: at 0x56163dbb1570
bryan@bryan-VirtualBox:~/torch/torch-rnn$

I understand this means Torch isn't finding some sort of library, which I'm pretty certain I have. But anything I've tried doesn't seem to work and hopefully I could get some assistance. Thanks!

Check the library path in install/share/lua/5.1/hdf5/config.lua, sometimes it doesn't get detected correctly. Also you might hit library version issues, the last time I used torch it didn't support current hdf5 library version and I had to install a patched version.
Unfortunately torch is pretty dead these days, and you'll probably hit more issues sooner or later. I switched my code to pytorch last year.

Thank you! I appreciate the tips. I've actually started over on a new VM because I think I messed with too many things... plus this would cut down on the commands looking for paths all over the place. Here's the current error I'm up to right now:

The suggestion I've received on this is to uninstall my system libhdf5 and tell lua to use a different version of it. Again, this is all brand new to me so I don't know if this will work or not but I trust the person suggesting this.
How similar is Pytorch? Is it simple and/or similar to use? Ultimately, I'm just trying to do a silly "feed the machine a list of names of a thing, have it learn and try to create its own, laugh at the results" sort of thing, so hardly anything scientific or seemingly complicated. I know Torch does character-based learning, does Pytorch as well?

It's trying to use CUDA, but cutorch and cunn modules aren't installed. Either install them using luarocks (but you might have to tell nvcc to use a host compiler it's compatible with) or switch to CPU mode using -gpu -1.
PyTorch API is quite similar to Torch, and I tried to keep pytorch-rnn close to torch-rnn, but some parts are still missing.


Upgrading from v4-beta to V4-release

Hi,
What's the upgrade path from v4-beta to V4-release?
Is it enough to follow Bootstrap's migration path (e.g. https://getbootstrap.com/docs/4.0/migration/#beta-3-changes ) or have there been material-specific changes as well that we need to account for?

Please follow Bootstrap's migration path. The majority of the recent changes in this project is to get the code in line with Bootstrap's changes.
Feel free to reopen this issue if you have any other questions or if I have missed anything.

A migration doc is on  the way: #167


testing vault on workflow - non final

What Vault does is it stores "secrets" (API Keys, admin password etc...).
It operates on the port 8200 and uses HTTPS with a self signed ssl certificate
Other microservices can store a request in vault with a request such as :
curl -k \
     --header "X-Vault-Token: $(cat ../volumes/shared_data/root_token.txt)" \
     --request POST \
     --data '{"Data_title": {"name_key": "name_value", "password_key": "password_value"}}' \
     https://<IP_ADDRESS>:8200/v1/secret/data/logins

or they can ask to get a previously posted secret with a request such as :
curl -k --header "X-Vault-Token: $(cat ../volumes/shared_data/root_token.txt)" \
     https://<IP_ADDRESS>:8200/v1/secret/data/logins

Notes :

Every "post a secret" request replaces the data located at the given URI
Since we don't want to store any sensitive data on the github, and we want vault to work for anyone who just has cloned the repo, the data is not persistent. Every build removes the existent data in /vault/file to set it up again.
as the commands above show, the root vault token generated after the build can be accesses in the security/vault_debian/volumes/shared_data directory


options

Curious how one gets the options input to work for ncks.
My verified command-line code:
ncwa -C -a lat,lon,time -d lon,-105,-100 -d lat,30,35 -l /tmp -p http://some.thredds.server/thredds/in.nc ~/out.nc
My pynco command (run from python 3.7)
nco.ncks( input = URLnc, output = Otmp, options = [ c.Limit("lat", minLt, maxLt),                                                         c.Limit("lon", minLn, maxLn) ])
The error:

NameError: name 'c' is not defined

This is a rather obvious error, but the examples that I'm following on your page do not elaborate on the functionality here. I'm sure this is trivial.
Ultimately, what I want to do is extract netcdf information from a given lat,lon using NCO limits feature. Ideally I want to put this into pandas dataframe for quantitative analysis and time-series display.
Any help is appreciated.

I think you need the following line at the top of your code page.
import custom as c
...Henry

Having the same problem with  name 'c' is not defined, and import custom as c didn't work either. conda install custom reports that this isn't available from current channels, and googling for python + custom returns 100s of useless sides. Which package is this? Thanks.

@mifads
The file custom.py is  located in the nco directory.
In the latest code in the pynco repo  nco.py is now NOT dependant  on this file.
I shall try and get this code into the next conda build

Thanks. Look forward to the next version.


documentation is not available

I can't open documentation. Can you please fix the link?

@changmingw96 can you please check this issue? https://github.com/FabrizioBrancati/Queuer/issues/26
You can find the new Xcode 13.0 beta generated documentation here.

This is now fixed on Queuer 3.0.0 🎉
The DocC plugin has been added, so you can generate it by running swift package --disable-sandbox preview-documentation.
It will also be available from tomorrow on Swift Package Index


CTRL-C should exit

at least when on an empty line

Also CTRL-D should too, according to Julian

I think I'm going to mirror the Python REPL for CTRL+D and CTRL+C. CTRL+D exits the CLI if the current line is empty and CTRL+C clears your input but does not exit the CLI.


BAU Payouts page add specific content for release date

As the payouts tracking feature was released after services started
taking payments with Stripe, there are a number of services (who
potentially took payments before and are coming back to self service)
who would see no payouts listed.
This adds more specific content that will only be shown if the
environment specifies what the date the payouts processing began.
Current copy - this will be shown by default if there are no payouts and we have no release date in the environment.

Draft copy - this will only be shown if there are no payouts AND we've specified a release date in the environment, this can be turned off if we think it's no longer relevant to communicate when to expect to see data from.

Looks good @sfount 🙂 only a couple of very minor stylistic things I'd recommend:

removing 0 from the front of single digit numbers, makes them more natural to read and consistent with the content style guide
putting the line about contacting support in a new paragraph – is distinct enough from the previous sentence to be worth calling out on its own IMO

Thanks @christopherthomasdesign! Addressed both of your comments in https://github.com/alphagov/pay-selfservice/pull/2032/commits/1b73908a8464a7c312f1d3308d75eba76e7a6ace


App supportability (streamlit)

Can we use this package to develop saml for streamlit application.

Use better python3-saml


Fix both demo links linking to same url

Both links go to webp-hero/?force.

marvelous, thanks for the fix @FINDarkside :+1: :+1:


Implement IpAddressType

Description
IpAddressType is implemented as a type in Presto. It will be great to have this in Velox to support queries using this type.
CC: @pedroerp @aditi-pandit @kagamiori @mbasmanova @majetideepak @laithsakka

@amitkdutta  : IPAddressType should be a customType in Prestissimo (instead of a first class Velox type) imo

There isn't any similar type in Spark/DuckDB/Parquet.
https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/type/IpAddressType.java implements IPAddress using a byte array. This can be easily done with a Custom Type
Presto IPAddress has only few scalar functions https://prestodb.io/docs/0.284/functions/ip.html and CAST logic to/from varchar/varbinary. There isn't really much interaction with other types.

It feels more natural to implement this in presto-native-execution submodule to me.
@mbasmanova, @pedroerp : wdyt ?

I would suggest to put it under velox/types/presto.  The underlying physical type is int128, and there will be quite a few places in the core library need to be fixed when we hard code int128 to be long decimal, so it will be much easier if we can put all the changes in one repo.  Also this way the functions can be put in velox/functions/prestosql with better fuzzer support etc.


Enable completely offline Duelyst development via Firebase Emulator instrumentation

I was able to get the firebase emulator (realtime db and auth) up and running and discovered they can be made to cycle while persisting data. Was able to instrument the server/lib/duelyst_firebase_module.coffee file to use the emulators for auth and database read/write. Got as far as able to create a new user and it's details updated within the emulated db, but couldn't progress farther due to how old the firebase-web module is
Unsure if there is a way to instrument it to use a local emulator (seems not as it'll error if not provided a firebaseio.com url). I tried beautifying and disabling as much of the obfuscated code as I could to bypass the checks, but alas still nothing. I checked with firebase-web v8 and was able to connect to the emulator and read/write.
To get the final piece working and potentially have 100% offline duelyst development would either require

someone much more skillful at javascript to modify the firebase v2 module to prime and communicate with the emulator, I believe it'll accept any unsigned token
hope someone knows or has the documentation on how to hook up the  emulator to firebase-web v2 (I've tried wayback machine to no success either, only goes back to 2016 for the emulator instrumentation logic)
implement issue #192 to update the frontend logic to firebase v8 or v9

Documentation on starting up the emulators and various flags
https://firebase.google.com/docs/emulator-suite/install_and_configure#startup
Command I used to start up the emulator with persistency
note: emulator has a logic that if project key starts with demo- prefix will ensure no calls accidentally reach to production instances, all calls will be only local
firebase emulators:start --export-on-exit=./fire_emu_data --project demo-foobaryst --import=./fire_emu_data
Modifications done to instrument firebase-admin for emulator usage
https://firebase.google.com/docs/emulator-suite/connect_auth#admin_sdks
for instrumenting the firebase-admin backend portion that Duelyst uses, all that is needed is to add the emulators url to a local environment variable and it'll do the rest. I hard coded it just for testing purposes, probably best practice would be to update the dotenv declaration.
Duelyst_firebase_module.coffee modifications for instrumentation
https://github.com/open-duelyst/duelyst/blob/main/server/lib/duelyst_firebase_module.coffee
note: I just added the env variable at the top of the file (before firebase module was loaded) and mocked in a dummy token for ease of testing
line 1:
process.env.FIREBASE_AUTH_EMULATOR_HOST="<IP_ADDRESS>:9099"

any line with a firebaseServiceAccount reference
firebaseServiceAccount = {
  project_id: "demo-foobaryst",
  client_email<EMAIL_ADDRESS>  private_key: "cHJpdmF0ZWtleQo=",
}

line 82:
//with firebaseDBEmuUrl just the ip:port to the database, the first line/env set was ip:port for the auth
app = firebaseAdmin.initializeApp({databaseURL: firebaseDbEmuUrl}, firebaseDbEmuUrl)

Create user invocation success, but just hangs infinitely due to old firebase-web version

Snippet of Firebase Emulator UI showing Duelyst backend creating the user and initial boss rotation data

How neat!!!!


Resized About window

Resized About window because the OK button did not fit, and changed the StartPosition to be CenterParent.
Before:

After:

Thanks, my Visual Studio always does this when I work with windows that have non-resizable borders for some reason.


Create a Next.js App Setup lesson lists incorrect minimum supported Node.js version

The https://nextjs.org/learn/basics/create-nextjs-app/setup page says:

If you don’t have Node.js installed, install it from here. You’ll need Node.js version 10.13 or later.

But the docs https://nextjs.org/docs/upgrading#v13-summary say:

The minimum Node.js version has been bumped from 12.22.0 to 14.6.0, since 12.x has reached end-of-life.

Updated in #133 and within the course.


Update the method parameter from String to CharSequence.

Update the method parameter of InetAddressUtils from String to CharSequence.
Sometimes I need to pass parts of a String(create a String slice) to this method instead of splitting the String into multiple pieces.

Hi, @ok2c  CI indicates that version compatibility check failed, but in fact the API is compatible, what do I do in this case?

@wangkaish You do something like that https://github.com/ok2c/httpcomponents-core/commit/96ca1afe17af5e7e4973b21579adf9ebd5a10a69

but in fact the API is compatible
@wangkaish No, it is not. It is compile compatible but binary incompatible.

@ok2c There is a method named isIPv4MappedIPv64Address in InetAddressUtils, is that mean isIPv4MappedIPv6Address?

@wangkaish There are style-check violations. Please address them. Please also add @since 5.3 to a;; new methods. Otherwise looks good.


Controller 'ngModel', required by directive 'input', can't be found!

I keep getting this error "Controller 'ngModel', required by directive 'input', can't be found!"
(https://docs.angularjs.org/error/$compile/ctreq?p0=ngModel&p1=input)
because the inputs[checkbox] are missing ng-model directive.
What am I doing wrong?

Hi,
Can help to replicate your code in Plunker or JsFiddler?

Fixed it thanks

@FirstImpression do you remember what this issue was? Running into the same issue.

got it, I had forgotten I was overriding the checkbox directive.


python310Packages.psycopg: disable timing sensitive information

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 213786 run on x86_64-linux 1

6 packages built:

pgcli (python310Packages.pgcli)
python310Packages.pgspecial
python310Packages.psycopg
python311Packages.pgcli
python311Packages.pgspecial
python311Packages.psycopg

Can you show me a trace that I can submit upstream?


[Forwardport] [Catalog v2] can not change the url or branch of the builtin catalog Rancher

forwardport: rancher/rancher#30594
prs: https://github.com/rancher/rancher/pull/31075

Will be validated with a 2.6.0-rc, when made available

on master-head (3e89bb8):

changed URL and branch of rancher builtin catalog

based on comments from https://github.com/rancher/rancher/issues/30594#issuecomment-771165152, waiting for an RC to test airgap

Available to test in v2.6.0-rc1

No need to validate airgap as you won't be able to change what charts are pulled in as we package them directly.


[ADDED] Github workflow for Android action

Based on guideline in https://github.com/amardeshbd/hello-github-actions

See https://github.com/amardeshbd/hello-github-actions/pull/2


Timekeeping

The initialise_model function should probably provide by default a t parameter, keeping track of current simulation time.
It will be useful to implement analytical time-dependent fields.
If implemented this would require to change affect! functons and expect all concentration field related functions to accept t as parameter

If implemented this would require to change affect! functons and expect all concentration field related functions to accept t as parameter

Not true, the current interface for affect (microbe, model) and field functions (pos model) can easily deal with this by internally referring to model.t.
So it's an easy implementation worth doing.


fix login button and make local debugging easier

for local debugging just uncomment the localhost tags and comment the normal ones


fix: make TransportChannel autocloseable

Codecov Report

Merging #4 into master will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
- Coverage     75.17%   74.73%   -0.44%
  Complexity      593      593
============================================
  Files            42       42
  Lines          3646     3642       -4
  Branches        251      222      -29
============================================
- Hits           2741     2722      -19
+ Misses          757      756       -1
- Partials        148      164      +16

Impacted Files
Coverage Δ
Complexity Δ

...om/google/cloud/logging/spi/v2/GrpcLoggingRpc.java
42.72% <100.00%> (ø)
1.00 <0.00> (ø)

...ava/com/google/cloud/logging/v2/MetricsClient.java
55.31% <0.00%> (-5.32%)
23.00% <0.00%> (ø%)

...java/com/google/cloud/logging/v2/ConfigClient.java
44.21% <0.00%> (-3.16%)
57.00% <0.00%> (ø%)

...ava/com/google/cloud/logging/v2/LoggingClient.java
63.43% <0.00%> (-1.50%)
21.00% <0.00%> (ø%)

...ain/java/com/google/cloud/logging/LoggingImpl.java
88.25% <0.00%> (+0.18%)
73.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f19e8...31f6093. Read the comment docs.


Experiment with inline background svg

Instead of putting the svg for the icons straight into the templates, I could use webpack to inline them in the css as background images. This would keep templates cleaner and separated from assets like icons.

I don't see much of a point doing this now.


[occm] Add quotes to values in cloud.conf file in helm chart

What this PR does / why we need it:
When a value in cloud.conf  (e.g. password) starts with # character, it becomes a comment since # starts comment section in .conf files. We need to add quotes around values to have valid conf files.
Release note:
Add quotes to values in cloudConfig

/ok-to-test

/lgtm
/approve


Display Year info

It displays only month information. Display year info as well on the calendar

@vinsbhat See https://github.com/savvisingh/DateRangePicker/issues/9, https://github.com/savvisingh/DateRangePicker/issues/32. Also there is an error, not SimpleDateFormat("MMMM, YYYY"), but SimpleDateFormat("MMMM yyyy").


Vaadin 24 - Component breaks because of Popup component dependency

Enhanced Grid depends on Popup component version 3.0.0 to create the filter popup and this component is not compatible yet with Vaadin 24.
Error when trying to use Enhanced Grid on Vaadin 24: class file for com.vaadin.flow.component.polymertemplate.PolymerTemplate not found
PolymerTemplate was removed in Vaadin 24 and Popup component relies on that. See issue.

Fixed by https://github.com/vaadin-component-factory/enhanced-grid-flow/pull/34


Tracker task 4: Create a bug fix to make sure that the tracker get deleted once its cctx status changes to Reverted/OutboundMinded/Aborted.

I think we can close this as garbage trackers (associated with finalized cctxs) don't accumulate any more since v11.


v1.3.1 Performance Testing

Run the performance tests using the perf-cli, similar to https://github.com/hyperledger/firefly/issues/1470#issuecomment-2077567912

Run against 1.3.1
stackJSONPath: /home/ubuntu/.firefly/stacks/newstack/stack.json

wsConfig:
  wsPath: /ws
  readBufferSize: 16000
  writeBufferSize: 16000
  initialDelay: 250ms
  maximumDelay: 30s
  initialConnectAttempts: 5
  heartbeatInterval: 5s

instances:
  - name: long-run
    tests: [{"name": "msg_broadcast", "workers":50},{"name": "msg_private", "workers":50},{"name": "blob_broadcast", "workers":30},{"name": "blob_private", "workers":30},{"name": "custom_ethereum_contract", "workers":20},{"name": "token_mint", "workers":10}]
    length: 500h
    sender: 0
    recipient: 1
    messageOptions:
      longMessage: false
    tokenOptions:
      tokenType: fungible
    contractOptions: {"address": "0x2715cc29d158e2d5261cb33a2eec0c6789e7eb6d"}

FireFly git commit:
3a2d40cca759c761ff0bba839ac582da163453d2

Happy with the above results and performance tests, no degradation compared to v1.3.0 - closing!


pass in the whole data object for afterInsertRow and afterDeleteRow

Hello,
In the docs, it reads

I wonder, if we can pass an extra argument of the complete data object, so that it is easy to use redux/setState to manage the data. I will be able to use something like onUpdate={data => this.setState(data)}.
I just went through the docs briefly. If I miss the function please let me know. :)

@wuyuanyi135, i thinks it will be feasible. Actually, I manage the selection state by rowKey only. I need find a solution for this requirement.

I wonder if the component internally maintains the data state. If yes it can be passed every time.

@wuyuanyi135, sorry I cant got you. did you want the whole row data in afterInsertRow?

This component handle the internally state surely.

did you want the whole row data in afterInsertRow?
Yes exactly.

I wonder if the component internally maintains the data state. If yes it can be passed every time

well, so what's means, or any plan for this requirement?

Never mind if it's misleading.. I read that you are having problem of the selection state by rowKey only. But In my thought I just want there is one extra argument for afterInsertRow and afterDeleteRow that passes in the whole row data. Does the selection state matter the data?

oh, sorry a misunderstand for you the selection state by rowKey only > just never mind.
I just explain why i return a rowkey instead a whole row, because I save the selection rowKey in internal state. I'll support this feature for you in near future.
Anyway, why you need the whole row, you should have the all data in the data in your component.

:+1: Great, Thanks
That is because I am using your built-in insertRow and deleteRow button. If the whole data are passed in I can simply use setState to sync the state, rather than manipulating the array using _.concat(this.props.sci, row) and _.reject(this.props.sci, { year: row[0]}.
It is an enhancement for convenience :P


Error while Installing go modules

Hello there :)
when I am installing the go modules with go get -u I get the error:
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>malformed module path "model": missing dot in first path element

As I am not developing with go (atm) I don't know what to do with this error. I looked for a missing dot in the files but found none. As debugging the error I found out that the error msg changed when removing the replaces from the ./src/server/go.mod file...maybe this has smthn to do with the error?
Thanks for helping/fixing the error

Hi, what's your Go version? You can check it with go version.

go version go1.15.5 darwin/amd64

Actually, I've never encountered this problem before, and both of my computers are working fine with Go 1.17.5.
I think that's probably because of some incompatibility with Go 1.15.5, maybe try:

Upgrade Go version to 1.17.x
go mod tidy -compat="1.17"
go get -u

Go module is always changing, and I think it's really confusing between different versions. 😢

@raphaelbernhart Hello there, any updates on this issue?
I've tested the above solution and it should work. :D


Implement missing cases for Float

Implement

NaN
-Inf
+Inf

The current state of library handles these special floats.
Test in binary writer    -     test in binary writer
Test in text reader     -    test in text writer
Also the test on ion-test repository which tests [+inf -inf NaN]: floatSpecials.ion


Implement uncomprehended IE handling

Fix for https://github.com/free5gc/free5gc/issues/443.
Require https://github.com/free5gc/aper/pull/6 and https://github.com/free5gc/ngap/pull/8.

@ShouheiNishi
https://github.com/free5gc/aper/pull/6 and https://github.com/free5gc/ngap/pull/8 are merged. Please help update the hashes. Thanks.


Update README.md simple example

I have presented the issue #34
After that, I checked the examples dir and got success running them.
PS: Maybe, could make a new release? The last release got deprecation problems on package syscall.
Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #35 (8c58d50) into master (830a617) will decrease coverage by 6.01%.
The diff coverage is 55.39%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   56.75%   50.74%   -6.02%
==========================================
  Files          16       22       +6
  Lines        3011     4010     +999
==========================================
+ Hits         1709     2035     +326
- Misses       1195     1828     +633
- Partials      107      147      +40

Impacted Files
Coverage Δ

dist/epmd.go
0.00% <0.00%> (ø)

linux.go
0.00% <0.00%> (ø)

net_kernel.go
26.24% <0.00%> (+1.40%)
:arrow_up:

lib/tools.go
12.12% <11.11%> (ø)

dist/dist.go
20.26% <20.34%> (ø)

etf/etf.go
46.78% <46.00%> (+10.09%)
:arrow_up:

node.go
64.26% <57.48%> (-7.01%)
:arrow_down:

etf/decode.go
58.04% <58.04%> (ø)

monitor.go
71.69% <70.38%> (-1.36%)
:arrow_down:

registrar.go
77.68% <76.05%> (-8.34%)
:arrow_down:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49379a1...8c58d50. Read the comment docs.

just made a new release with these fixes


⚠ Bofrost.at has degraded performance

In aca61fc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 987 ms

Resolved: Bofrost.at performance has improved in 2f59686.


Try setting up CI for Python bindings tests

Fortunately, Maturin can generate YAML for GitHub Actions. Let's see how this goes…

It took a little tweaking, but it works!


Moon browsers are blocking gke cluster scale down

Hi there,
recently we are getting warnings from GKE about moon browser pods blocking cluster scale down:
"Pod is blocking scale down because it’s not backed by a controller"
{
  "insertId": "96beaab8-e3c3-4773-a733-f9559c041b0f@a1",
  "jsonPayload": {
    "noDecisionStatus": {
      "measureTime": "1643992124",
      "noScaleDown": {
        "nodes": [
          {
            "node": {
              "mig": {
                "zone": "europe-west4-b",
                "name": "gke-hybris-cluster-n-hybris-node-pool-702525f4-grp",
                "nodepool": "hybris-node-pool-nonprod"
              },
              "cpuRatio": 43,
              "name": "gke-hybris-cluster-n-hybris-node-pool-702525f4-cqjm",
              "memRatio": 43
            },
            "reason": {
              "parameters": [
                "chrome-95-0-7d3784d7-9ccd-4510-8006-a37f60eb7c22"
              ],
              "messageId": "no.scale.down.node.pod.not.backed.by.controller"
            }
          }
        ],
        "nodesTotalCount": 1
      }
    }
  },
  "resource": {
    "type": "k8s_cluster",
    "labels": {
      "cluster_name": "hybris-cluster-nonprod",
      "location": "europe-west4",
      "project_id": "hybris-prod-0815"
    }
  },
  "timestamp": "2022-02-04T16:28:44.919959722Z",
  "logName": "projects/hybris-prod-0815/logs/container.googleapis.com%2Fcluster-autoscaler-visibility",
  "receiveTimestamp": "2022-02-04T16:28:45.608040844Z"
}

We can try fixing this with an annotation like cluster-autoscaler.kubernetes.io/safe-to-evict: "true" but maybe there is a better solution?

Hmm ok I see: The real problem seems to be some stuck browser pods ... the logs of this pods are containing an endless list of Waiting X server... entries.

@mhubig you have to check defender container logs of such pods. Usually this could be because of DNS issue or Kubernetes API overload.


Update to ava 1.2.0

This PR updates to the latest version of ava (from 1.0.0-beta-8 to latest stable version). npm test is passing locally for me after the update.

Awesome, thanks!


Adding ESLint to the build pipeline

ESLint config was added to the Scripts folder.
AppVeyor config was changed to run linter before the unit tests.
Parse errors produced by ESLint were fixed.

/cc @AlekseyMartynov


WIP: Add GitHub Pages Action

This will deploy gds-way to GitHub Page, as https://alphagov.github.io/gds-way/

Closing this PR, moving the branch over to this repository. Work to carry on within alphagov.


python integration crashes when load of qsharp.client is too big.

Trying to call the qsharp.client.execute method with a big payload causes the iq# kernel to crash with an invalid message signature.

This should have been resolved with #70, such that I think this can be closed when we push the next version up to PyPI. Is this correct, @anpaz-msft?


[Ninja] update to 1.10.1

Describe the pull request
This updates the Ninja build system from 1.10.0 to 1.10.1 (for Windows, Linux and MacOS).
release notes Ninja v1.10.1

What does your PR fix? Fixes #10890

Which triplets are supported/not supported? Have you updated the CI baseline?
OSX v10.12 is again the minimum required for Ninja (was accidentally v10.14 with the 1.10 release).

https://github.com/microsoft/vcpkg/blob/bc21841c614f3460413530110ba2c1919de7a706/scripts/cmake/vcpkg_find_acquire_program.cmake#L212

Oh my! Putting the same thing in two locations ...

I'm not sure why the CI on x86 failed. Downloading Ninja worked and it should have extracted, but CMake can't seem to find the executable.
All other CI-jobs got past this point without issues and various other jobs on Windows have already finished successfully.

That's really weird and I can't repro it. @BillyONeal can you please take a look?
Thanks.

Looks like it was using an old azure-pipelines.yml; I pushed a merged with master and it seems happy now.

One other thing I'll note: asking GitHub to "rerun" doesn't trigger a "remerge" so it will only fix download failures. Pushing a merge with master is usually a better way to request a reattempt (unless your branch is already up to date of course)

LGTM.

Thanks for the fixes everyone!


Release notes contain "111" and nothing else

Describe the bug
No release notes for Hoxton
Sample
https://github.com/spring-cloud/spring-cloud-release/wiki/Spring-Cloud-Hoxton-Release-Notes

Thanks - someone has deleted our wiki page. I've reverted it

And I've restricted access

thanks for a quick response


Fix 2.7 multi registry

see https://github.com/apache/dubbo/pull/9786

Codecov Report

Merging #9787 (a3ac990) into master (6fe17e7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9787      +/-   ##
============================================
- Coverage     60.88%   60.87%   -0.01%
- Complexity      447      449       +2
============================================
  Files          1100     1100
  Lines         44546    44560      +14
  Branches       6481     6487       +6
============================================
+ Hits          27120    27128       +8
- Misses        14455    14464       +9
+ Partials       2971     2968       -3

Impacted Files
Coverage Δ

...o/rpc/cluster/loadbalance/AbstractLoadBalance.java
70.83% <100.00%> (+2.65%)
:arrow_up:

...ache/dubbo/qos/command/util/ServiceCheckUtils.java
6.89% <0.00%> (-4.87%)
:arrow_down:

...etadata/report/support/AbstractMetadataReport.java
56.31% <0.00%> (-3.40%)
:arrow_down:

...ubbo/registry/support/AbstractRegistryFactory.java
80.28% <0.00%> (-2.82%)
:arrow_down:

...che/dubbo/remoting/transport/mina/MinaChannel.java
46.05% <0.00%> (-1.32%)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
67.79% <0.00%> (-1.13%)
:arrow_down:

...bbo/rpc/cluster/support/ForkingClusterInvoker.java
85.71% <0.00%> (-0.40%)
:arrow_down:

.../apache/dubbo/config/bootstrap/DubboBootstrap.java
55.09% <0.00%> (+0.06%)
:arrow_up:

.../org/apache/dubbo/config/MetadataReportConfig.java
81.92% <0.00%> (+2.40%)
:arrow_up:

...he/dubbo/remoting/transport/netty/NettyServer.java
73.68% <0.00%> (+3.50%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe17e7...a3ac990. Read the comment docs.


OSX 10.12 + UE 4.18 - "SpawnActor failed because no class was specified"

We have a setup with a pawn in the default scene. This pawn is of type "UnrealEnginePython.PyPawn". This actor / pawn has a python module in the Scripts directory inside a file called foo.py with class name MyPawn.
However, when playing the scene - I get the error "SpawnActor failed because no class was specified" which is an error thrown by UnrealEngine proper (LevelActor.cpp : AActor* UWorld::SpawnActor(...)). The only place where the UEPy plugin invokes the level actor spawn is in UEPyActor.cpp which seems to call world->SpawnActor(...) where it passes the (UClass *) of the py_obj->ue_object which apparently is NULL.
What would cause this to happen? The strangest thing is that this does not occur with the exact same build on my linux ubuntu dev box also running 4.18 and the same version of the UnrealEnginePython plugin. Any ideas?

This only seems to happen on my OSX 10.12 laptop, on my home machine running OSX 10.12, things are fine! The rather strange thing, is that I have a custom HUD which MyPawn spawns using:
hud = self.uobject.actor_spawn(PyHUD, PythonModule="components.my_hud", PythonClass="MyHUD")

Any my HUD spawns correctly, but the Pawn's tick / interface functions are never called.

This might or might be a benign side effect of something else. I will later instrument the plugin and figure out a call-stack of why this is going on. For the time being, I am noticing that calls to "print" do not flush to the ue python console, but calls to ue.log show up as expected.


allMatch action

In writing rule exclusions and virtual patches, it is often required to validate a certain parameter, such as ARGS:foo "@streq good".
However, a user can submit multiple parameters with the same name, e.g. foo=bad&foo=good.
There is currently no easy way to require all of these parameters to match. If you write SecRule ARGS:foo "@streq good" "id:1,allow", then the rule would match as soon as one foo=good parameter is present, even if there's another one, which may be interpreted in various ways by the web application.
If the rule writer knows that the variable only should occur once, then they can add a chain to ensure &ARGS:foo "@eq 1".
But, for some APIs, the parameter really can occur multiple times in a benign request. There is currently not a good way to facilitate validating all selected variables without doing a difficult dance with creating tx variables.
It would be useful to have something like an allMatch modifier that would require a match to ALL mentioned variables, as a condition for the rule to match.
Context: https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/599#issuecomment-252291013

As of now I think you might be able to accomplish what you're looking for with these rules:
SecRule ARGS "@rx (bad)|(good)" "id:1,pass,capture"
SecRule TX.0 "@streq good" "id:2,pass"
SecRule TX.1 "@streq bad" "id:3,block"

Or maybe trying to match it with QUERY_STRING, REQUEST_URI or REQUEST_LINE
We could get a new allMatch action for 3.0.4 release, but thinking again, it seems like de-facto webservers such as Apache and Nginx does not take two parameters with the same name into consideration internally.
For instance, if I submit parameters with the same name like foo=bad&foo=good this is what I get with on Apache access_log:
::1 - - [28/Sep/2018:23:52:36 -0400] "GET /?foo=bad HTTP/1.1" 200 10933 "-" "curl/7.38.0"

And Nginx:
<IP_ADDRESS> - - [28/Sep/2018:23:57:33 -0400] "GET /?foo=bad HTTP/1.1" 200 8 "-" "Wget/1.16 (linux-gnu)"

I could only reproduce a valid scenario to test this by using a custom ModSec's v3 test case like this: https://gist.github.com/victorhora/4140a8f42e935d5ce157bb78ae2b9927
We might not rely on the webservers normalization routines to parse data, but in this case I'm not sure what's the value of developing such a feature.
Thoughts?

I'm going to go ahead and close this because:

it's been open way too long overall
it's been open way too long 'pending feedback' without response
there are multiple ways to accomplish what is needed, including the suggestion by @victorhora
it is too much of a niche scenario (in my opinion) to warrant adding a new action when there are multiple ways to accomplish the underlying need

An additional way to register a match when any value of a particular name fails to have a certain value (e.g. 'good'):
SecRule ARGS:foo "@rx ^((?!(good$)).*)" ...        <== use negative lookahead to match anything other than 'good'


Added support for async methods, .NET core

This still needs to support net45

Also you should just use GetAwaiter().GetResult() instead of .Result as it avoids wrapping any exceptions in an AggregateException.

_kinesisFirehoseClient.PutRecordBatchAsync(request)).GetAwaiter().GetResult()

instead of

var putRecordBatchTask  =  Task.Run(async () => await _kinesisFirehoseClient.PutRecordBatchAsync(request));

var result = putRecordBatchTask.Result;

You can read more about this here:

http://blog.stephencleary.com/2014/12/a-tour-of-task-part-6-results.html
https://blogs.msdn.microsoft.com/pfxteam/2011/09/28/task-exception-handling-in-net-4-5/
https://github.com/aspnet/Security/issues/59

Wouldn't you just target netstandard2.0 only? That is compatible with .NET core & full framework.

@jakejscott @Ry-K Can you take rev

@thirkcircus Plz have look and merge this. If something else needs to be done let me/us know.

@wcrooy Thanks for your fixes!

@wcrooy it's merged


cornerstone: display NIfTI and dicom image previews

Fixes #23

The hard part was sorting out that I have to use the "legacy" Cornerstone and then just writing this demo, but with that knowledge in hand I got this working immediately.
First draft screenshots
annexed

unannexed

Relationship to #1
Note that this feature doesn't need git-annex. Due to #22 (+ #20), if used on an annexed file, $.RawFileLink will be filled with a working link when the template renders, but works independently.
So as much of a pain as it is, I think we should maintain this as a separate branch from #1.

Second draft
annexed (and in `LANG=ml-IN`)

unannexed

TODO:

[ ] integrate cornerstone-wado-image-loader for completeness (is that the right package? I need to dig up some examples of this in actual use) for DICOM support
[ ] Split this to cornerstone so that we have git-annex, cornerstone, and git-annex-cornerstone branches.
[ ] Consider adding a basic toolbar with zoom/etc

As a reminder to the future: I was very confused] by the rewrite of Cornerstone, going from cornerstone-core ^2.6.1 to @cornerstonejs/core ^0.22.0. The docs assume the rewrite, but don't actually explain how to use anything. It turns out the new version is at best unfinished and at worst vaporware, since not even the flagship app currently uses the rewrite, it's still on 2.6.1 and neither has the author of the NIfTI plugin ported to the new API ((even though that plugin has started being published under the new namespace at @cornerstonejs/nifti-image-loader ^1.0.8 with cornerstone-nifti-image-loader being abandoned and only running up to 1.0.0).
The upshot is that the dependencies look inconsistent:
https://github.com/neuropoly/gitea/blob/c528c18ae17a52c6a9dc9f71722309270a3bf9ea/package.json#L10-L13
it's because they are.
For future reference: the way I actually figured out how to use this plugin was with the help of GitHub's downstream tab; it helped me find ChRIS_UI whose package.json clearly shows a working configuration and code shows how to actually use all the different filetypes together.

DICOMs :tada:
I've read enough examples to figure out how to patch in the DICOM loader.
I grabbed some of the dicoms off the wado-image-loader demo, out of https://github.com/cornerstonejs/cornerstoneWADOImageLoader/tree/master/testImages, and demoed them:
annexed

unannexed

Testing :christmas_tree:
I don't know how to write tests for this since it's mostly frontend code so I'm just not going to do it. I don't think upstream even bothers to test the frontend automatically that much, there only really seems to be these two files:
https://github.com/neuropoly/gitea/blob/fa43bce541507c8a702723f84764a48db9278506/web_src/js/features/repo-code.test.js#L1-L18
https://github.com/neuropoly/gitea/blob/fa43bce541507c8a702723f84764a48db9278506/web_src/js/features/repo-findfile.test.js#L1-L35
which don't actually test loading any pages or images, they are just unit tests on some utils that happen to be in javascript instead of go.


Tasks 1666-1670

Reviews: https://github.com/swarooprm/CSE576HW/pull/51/files

Dropped 1668 as there were too much noise in annotation.


Column Formatting causes Lookup Values to Disappear in Grid View (SharePoint Online)

If I apply any type of formatting to a lookup column, and Edit in Grid View, both the current value and the list of lookup values become invisible when I attempt to select or change a value in that column.  This behavior is the same whether I select out-of-the-box formatting or custom JSON.

I am also having this issue. Hopefully my report will give additional useful information.
Our formatting has five separate icons and values, with one of two colours for each of those options.
Edit in Grid View compresses this list, removing the icons and values, and reduces the number of colours to one.


Plain, Star, Roles, Patterns and Generics

This PR addresses several shortcomings of the current typings, introduces a set of narrower 'Plain' types for developers dealing with pre-RDF-star formats such as Turtle 1.1, and includes several fixes for generics, defaults, arguments, and return types. Closes #5
1. Introduction of 'Plain' and 'Star' namespaces
Not all libraries are ready to adopt the RDF-star specification draft and some will be interested in exclusively dealing with RDF 1.1 data. To accommodate the narrower scope of those 'Plain' Term types, this introduces the following namespaces:
1a. PlainRole and StarRole
Unions of Term types for the various roles they play in 'plain' RDF 1.1 Data, and RDF-star data, respectively. Each namespace exports the following named types: Subject, Predicate, Object, Graph, Datatype, and Quad
Note that PlainRole is an export-only type and not used by @rdfs/types internally. It is meant to provide developers with a type for working with serialization formats and datasets that do not (yet) support RDF-star, such as Turtle 1.1 .

1a.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L137-L147
1a.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L162-L172

1b. PlainPattern and StarPattern
For each type in PlainRole and StarRole, these pattern interfaces add a union with Variable | null for the various RDFJS methods that accept term patterns as input.

1b.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L149-L159
1b.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L174-L184

2. Addition of PlainQuad and StarQuad
Without removing BaseQuad, these two new interfaces extend BaseQuad by specifying a stricter term type for each quad component than the former Quad_{Subject|Predicate|Object|Graph} interfaces. Most notably, PlainQuad and StarQuad components do not have unions with Variable (those cases are covered separately by PlainPattern and StarPattern).
Note: Each of the Quad_{Subject|Predicate|Object|Graph} interfaces are still made available in the exports and carry the same exact types as before. A deprecation annotation has been added to notify the user to consider using one of the more fitting types.

2.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L300-L324
2.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L274-L298

3. OutQuad now defaults to StarQuad instead of BaseQuad
The specification says that each component of the 'Quad' interface be a Term, hence why BaseQuad exists in the typings. In this PR, OutQuad still extends BaseQuad, meaning that developers may still use quad implementations that have unorthodox term types such as Literal in the subject position. However, this PR makes it so that if the generics arguments are omitted, then OutQuad will default to a quad with the traditional term types (including the RDF-star subject and object types) for each component. This change provides developers with stronger type information by default without removing features nor deviating from the spec.

3.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/data-model.d.ts#L330
3.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L8
3.3 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L51
3.4 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L58
3.5 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L199

4. InQuad now defaults to StarQuad instead of OutQuad
InQuad should not default to OutQuad if the 2nd generic argument is omitted. For example:
export class MyDataset extends RDFJS.DatasetCore<MySpecialQuad> {
    // ...
}

Would imply now that the quad parameter is typed to MySpecialQuad for add(quad), delete(quad), has(quad), etc. -- but the library should accept all RDFJS terms as arguments in order to implement the spec, not just MySpecialQuad.
By defaulting to InQuad to StarQuad, if this argument is omitted, then the types for quad arguments are assumed to be traditional, RDF-star compatible quads.
See 3.1, 3.2, 3.3, 3.4, and 3.5 above for code references.
5. subject, predicate, object and graph arguments are now typed to InQuad['{subject|predicate|object|graph}']
Before this change, each argument in match methods (e.g., DatasetCore#match(), Dataset#deleteMatches(), and so on...) were typed to Term. Now these methods are typed by component types within the given generic InQuad argument, and each one is union'ed with | Variable | null.

5.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L46
5.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L86
5.3 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/dataset.d.ts#L196
5.4 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L48
5.5 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L104

6. Distinguish between OutQuad vs. InQuad generic arguments for Source and Store
Prior to this PR, the argument types and return type of Source#match() (and, by inheritance, Store#match) were the same; however the implementors should be allowed to accept RDFJS term types as arguments and return a stream of their own implementation of Quad. This change allows implementors to specify those two types (OutQuad and InQuad) much the same way it is done in dataset.d.ts.
Additionally, Store#removeMatches() and Store#deleteGraph() now specify InQuad rather than the ambiguous Q.

6.1 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L38
6.2 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L80
6.3 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L90
6.4 https://github.com/rdfjs/types/blob/0824ab67915659674c0eb730ee7c771f83ea70b9/stream.d.ts#L116

7. Remove toArray()
Per https://github.com/rdfjs/dataset-spec/pull/64 .

Would you revert the rdfjs-tests.d.ts. rename? It did not get picked up by GitHub's diff

Yes, I'm happy to break these out into smaller, more manageable PRs. It's just that several of these changes are intra-dependent so it made it hard to split some of them up.
I understand the veto to 4. InQuad now defaults to StarQuad instead of OutQuad .

Yes, I'm happy to break these out into smaller, more manageable PRs. It's just that several of these changes are intra-dependent so it made it hard to split some of them up.

I would totally separate "toArray change".
We may work out the rest. If you look at my branch I linked to, it appears that some of those changes could be avoided?


ReferenceError: 'html' is not defined

Describe the bug
When trying to launch the plugin from within Figma i get ReferenceError: '__html__' is not defined
To Reproduce
Steps to reproduce the behavior:

Go to 'Plugins > Development'
Click on 'AEUX'
See error

Expected behavior
The UI for the plugin should load.
Screenshots

Desktop (please complete the following information):

OS: macOS 13 Ventura
Figma 116.2.4, AEUX 0.8.2

The issue seems to have resolved itself... 🤔🤷🏼♂


Increased the height of prompt textarea.

Issue Addressed: #51
What:
The height of the prompt TextArea was too small.
How:
Added a tailwind height class.
Screenshot for reference:

@skks1212, the merge conflict was resolved from my side, and the code works. Would be great if you test it out as well...