Artifactory Generic Download failing after extension was  update to  1.11.1

Describe the bug
Got below errors in Artifactory Generic Download
2020-12-21T10:59:59.6108197Z   "status": "failure",
2020-12-21T10:59:59.6109847Z [Error] rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-979236064\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.6114442Z   "totals": {
2020-12-21T10:59:59.6116218Z [Error] Download finished with errors, please review the logs.
2020-12-21T10:59:59.6121498Z     "success": 0,
2020-12-21T10:59:59.6148744Z     "failure": 1
2020-12-21T10:59:59.6149610Z   }
2020-12-21T10:59:59.6162384Z }
2020-12-21T10:59:59.6218839Z ##[error]Error: Command failed: C:\hostedtoolcache\windows\jfrog\1.42.2\x64\jfrog.exe rt dl --url="https://" --user=* --password=*** --fail-no-op=true --dry-run=false --insecure-tls=false --threads=3 --retries=3 --validate-symlinks=false --split-count=3 --min-split=5120
2020-12-21T10:59:59.6411285Z ##[section]Finishing: Download Artifacts - Arm
To Reproduce
Use Artifactory Generic Download task with below spec:

task: ArtifactoryGenericDownload@3
displayName: ${{ parameters.jobName }}
inputs:
connection: ${{ parameters.ArtifactoryServiceName }}
fileSpec: |
{
"files": [
{
"pattern": "${{ parameters.patternPath }}/*.zip",
"target": "${{ parameters.target }}",
"build": "${{ parameters.buildName }}/${{ parameters.buildID }}",
"flat":"true",
"explode":"true"
}
]
}

Expected behavior
Finish task without errors
Screenshots
If applicable, add screenshots to help explain your problem.
Versions

Artifactory Azure DevOps extension version: 1.11.1
Agent operating system: Hosted agent, Image: windows-2019
JFrog Artifactory version: SaaS Artifactory

Additional context
Full log of the  task:
2020-12-21T10:59:55.8429101Z ##[section]Starting: Download Artifacts - Arm
2020-12-21T10:59:55.8591115Z ==============================================================================
2020-12-21T10:59:55.8591676Z Task         : Artifactory Generic Download
2020-12-21T10:59:55.8592231Z Description  : Download artifacts from Artifactory using FileSpecs, while allowing to collect build-info. The collected build-info can be later published to Artifactory by the "Artifactory Publish Build Info" task.
2020-12-21T10:59:55.8593687Z Version      : 3.11.1
2020-12-21T10:59:55.8594098Z Author       : JFrog
2020-12-21T10:59:55.8594345Z Help         :
2020-12-21T10:59:55.8594763Z ==============================================================================
2020-12-21T10:59:56.2408362Z Downloading: https://api.bintray.com/content/jfrog/jfrog-cli-go/1.42.2/jfrog-cli-windows-amd64/jfrog.exe?bt_package=jfrog-cli-windows-amd64
2020-12-21T10:59:57.9753947Z Caching tool: jfrog 1.42.2 x64
2020-12-21T10:59:57.9996132Z Running jfrog-cli from C:\hostedtoolcache\windows\jfrog\1.42.2\x64\jfrog.exe.
2020-12-21T10:59:58.3255150Z JFrog CLI version: 1.42.2
2020-12-21T10:59:58.3266261Z Generic download...
2020-12-21T10:59:58.3283467Z Using file spec:
2020-12-21T10:59:58.3283921Z {
2020-12-21T10:59:58.3284226Z     "files": [
2020-12-21T10:59:58.3284577Z      {
2020-12-21T10:59:58.3284971Z         "pattern": "aqua-saas/SeaMonkey/.zip",
2020-12-21T10:59:58.3285410Z         "target": "D:\a\1\s/arm\",
2020-12-21T10:59:58.3285844Z         "build": "farmerui-arm/LATEST",
2020-12-21T10:59:58.3286237Z         "flat":"true",
2020-12-21T10:59:58.3286602Z         "explode":"true"
2020-12-21T10:59:58.3286918Z      }
2020-12-21T10:59:58.3287209Z     ]
2020-12-21T10:59:58.3287490Z }
2020-12-21T10:59:58.4152684Z [Info] Searching items to download...
2020-12-21T10:59:58.9468453Z [Info] [Thread 2] Downloading aqua-local-saas/SeaMonkey/SeaMonkey.Automation-<IP_ADDRESS>.zip
2020-12-21T10:59:59.0803729Z [Info] [Thread 2] Extracting archive: D:\a\1\s\arm\SeaMonkey.Automation-<IP_ADDRESS>.zip to D:\a\1\s\arm
2020-12-21T10:59:59.1040997Z [Warn] [Thread 2] Attempt 0 - Failure occurred while downloading https://*****/aqua-local-saas/SeaMonkey/SeaMonkey.Automation-<IP_ADDRESS>.zip - rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-812474715\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.2362089Z [Info] [Thread 2] Extracting archive: D:\a\1\s\arm\SeaMonkey.Automation-<IP_ADDRESS>.zip to D:\a\1\s\arm
2020-12-21T10:59:59.2589301Z [Warn] [Thread 2] Attempt 1 - Failure occurred while downloading https:///aqua-local-saas/SeaMonkey/SeaMonkey.Automation-<IP_ADDRESS>.zip - rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-740628222\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.4142969Z [Info] [Thread 2] Extracting archive: D:\a\1\s\arm\SeaMonkey.Automation-<IP_ADDRESS>.zip to D:\a\1\s\arm
2020-12-21T10:59:59.4377504Z [Warn] [Thread 2] Attempt 2 - Failure occurred while downloading https:///aqua-local-saas/SeaMonkey/SeaMonkey.Automation-<IP_ADDRESS>.zip - rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-526257221\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.5821694Z [Info] [Thread 2] Extracting archive: D:\a\1\s\arm\SeaMonkey.Automation-<IP_ADDRESS>.zip to D:\a\1\s\arm
2020-12-21T10:59:59.6073593Z [Warn] [Thread 2] Attempt 3 - Failure occurred while downloading https://aqua-local-saas/SeaMonkey/SeaMonkey.Automation-<IP_ADDRESS>.zip - rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-979236064\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.6080425Z {
2020-12-21T10:59:59.6082757Z [Error] [Thread 2]  Received an error: rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-979236064\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.6108197Z   "status": "failure",
2020-12-21T10:59:59.6109847Z [Error] rename C:\Users\VSSADM~1\AppData\Local\Temp\jfrog.cli.temp.-1608548399-979236064\Install-SeaMonkey.ps1 D:\a\1\s\arm\Install-SeaMonkey.ps1: The system cannot move the file to a different disk drive.
2020-12-21T10:59:59.6114442Z   "totals": {
2020-12-21T10:59:59.6116218Z [Error] Download finished with errors, please review the logs.
2020-12-21T10:59:59.6121498Z     "success": 0,
2020-12-21T10:59:59.6148744Z     "failure": 1
2020-12-21T10:59:59.6149610Z   }
2020-12-21T10:59:59.6162384Z }
2020-12-21T10:59:59.6218839Z ##[error]Error: Command failed: C:\hostedtoolcache\windows\jfrog\1.42.2\x64\jfrog.exe rt dl --url="https://" --user= --password=*** --fail-no-op=true --dry-run=false --insecure-tls=false --threads=3 --retries=3 --validate-symlinks=false --split-count=3 --min-split=5120

@boris-ait - thanks for reporting this!
We've just released version 1.11.2 - I belive this should resolve the issue.
Please let su know.

Hi @eyalbe4,
It seems the issue occurs when we use the jfrog-cli 1.42.3
Anyway, it works with jfrog-cli 1.41.x and I found that @talarian1 did the cli change 5 days ago:
https://github.com/jfrog/artifactory-azure-devops-extension/commit/0ce4a38cf199bebc6bed00f337e871817a71cb49
Also, we face the same issue when the target in the task is "." (dot).
It is a severe issue that blocks us to execute our builds!!
Please assist ASAP!!

@boris-ait - thanks for reporting this!
We've just released version 1.11.2 - I belive this should resolve the issue.
Please let us know.

We have the same issue using this version.
Please see the comment above. We did some debugging and found the issue in the jfrog-cli version.

@DO-User,
Can you please share the AzureDevOps build log? I'd like to see if indeed the pipeline downloads version 1.42.3.
The original build log you shared still downloads version 1.42.2.

I'm sharing with you the second scenario on Linux machine:
`Starting: ArtifactoryGenericDownload
Task         : Artifactory Generic Download
Description  : Download artifacts from Artifactory using FileSpecs, while allowing to collect build-info. The collected build-info can be later published to Artifactory by the "Artifactory Publish Build Info" task.
Version      : 3.11.2
Author       : JFrog
Help         :
Downloading: https://api.bintray.com/content/jfrog/jfrog-cli-go/1.42.3/jfrog-cli-linux-amd64/jfrog?bt_package=jfrog-cli-linux-amd64
Caching tool: jfrog 1.42.3 x64
Running jfrog-cli from /home/buser/ag04/_work/_tool/jfrog/1.42.3/x64/jfrog.
JFrog CLI version: 1.42.3
Generic download...
Using file spec:
{ "files": [ { "pattern": "generic-p/p-modules/modules-1.0.0.tar.gz", "target": ".", "explode": "true" } ] }
[Info] Searching items to download...
[Info] [Thread 2] Downloading generic-p/p-modules/modules-1.0.0.tar.gz
[Info] [Thread 2] [2]: 206 Partial Content...
[Info] [Thread 2] [0]: 206 Partial Content...
[Info] [Thread 2] [1]: 206 Partial Content...
[Error] [Thread 2]  Received an error: open p-modules/modules-1.0.0.tar.gz: not a directory
{
"status": "failure",
"totals": {
"success": 0,
"failure": 1
[Error] open p-modules/modules-1.0.0.tar.gz: not a directory
[Error] Download finished with errors, please review the logs.
}
}
##[error]Error: Command failed: /home/buser/ag04/_work/_tool/jfrog/1.42.3/x64/jfrog rt dl --url="https://artifactory.blablabla.com/artifactory" --user=*** --password=*** --fail-no-op=true --dry-run=false --insecure-tls=false --threads=3 --retries=3 --validate-symlinks=false --split-count=3 --min-split=5120
Finishing: ArtifactoryGenericDownload
`

@DO-User , Please run the job with env var JFROG_CLI_ERROR_HANDLING=panic to get the full stack trace.

For me, the new version of the extension worked well.
If we will face another issue on Linux platform, a new issue will be opened.

@DO-User , Please run the job with env var JFROG_CLI_ERROR_HANDLING=panic to get the full stack trace.

Here is the output :
Task         : Artifactory Generic Download
Description  : Download artifacts from Artifactory using FileSpecs, while allowing to collect build-info. The collected build-info can be later published to Artifactory by the "Artifactory Publish Build Info" task.
Version      : 3.11.2
Author       : JFrog
Help         :
Found tool in cache: jfrog 1.42.3 x64
Running jfrog-cli from /home/build_user/ag01/_work/_tool/jfrog/1.42.3/x64/jfrog.
JFrog CLI version: 1.42.3
Generic download...
Using file spec:
{ "files": [ { "pattern": "generic/modules/modules-1.0.0.tar.gz", "target": ".", "explode": "true" } ] }
[Info] Searching items to download...
[Info] [Thread 2] Downloading generic/modules/modules-1.0.0.tar.gz
[Info] [Thread 2] [2]: 206 Partial Content...
[Info] [Thread 2] [1]: 206 Partial Content...
[Info] [Thread 2] [0]: 206 Partial Content...
{
"status": "failure",
"totals": {
"success": 0,
"failure": 1
}
}
panic: open modules/modules-1.0.0.tar.gz: not a directory
goroutine 11 [running]:
github.com/jfrog/jfrog-cli-core/utils/coreutils.PanicOnError(0x104fd40, 0xc000186480, 0x242, 0x1b6)
/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core@v1.2.4/utils/coreutils/utils.go:68 +0x59
github.com/jfrog/jfrog-client-go/utils/io/fileutils.MoveFile(0xc00045a090, 0xd, 0xc0004d2360, 0x22, 0x104fd40, 0xc000186480)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/utils/io/fileutils/files.go:593 +0x40c
github.com/jfrog/jfrog-client-go/utils.ExtractArchive(0xc000446610, 0xd, 0xc00045a090, 0xd, 0xc000434620, 0x14, 0xc000436130, 0xb, 0x30, 0xc00045a090)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/utils/archiveutils.go:34 +0x477
github.com/jfrog/jfrog-client-go/httpclient.(*HttpClient).DownloadFileConcurrently(0xc000450680, 0xc000434620, 0x14, 0xc0004d03c0, 0x5d, 0xc000468570, 0x30, 0xc00045a090, 0xd, 0xc000446610, ...)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/httpclient/client.go:428 +0x48a
github.com/jfrog/jfrog-client-go/artifactory/httpclient.(*ArtifactoryHttpClient).DownloadFileConcurrently(0xc00021bc10, 0xc000434620, 0x14, 0xc0004d03c0, 0x5d, 0xc000468570, 0x30, 0x16b9fce, 0x1, 0xc000446610, ...)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/artifactory/httpclient/httpclient.go:125 +0x158
github.com/jfrog/jfrog-client-go/artifactory/services.(*DownloadService).downloadFile(0xc0002d67c0, 0xc000180460, 0xc000436130, 0xb, 0xc00019e500, 0x1000001, 0x1400, 0x3, 0x3, 0xd, ...)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/artifactory/services/download.go:265 +0x472
github.com/jfrog/jfrog-client-go/artifactory/services.(*DownloadService).downloadFileIfNeeded(0xc0002d67c0, 0xc0004d03c0, 0x5d, 0xc000446610, 0xd, 0x16b9fce, 0x1, 0xc000436130, 0xb, 0xc000446620, ...)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/artifactory/services/download.go:413 +0x382
github.com/jfrog/jfrog-client-go/artifactory/services.(*DownloadService).createFileHandlerFunc.func1.1(0x2, 0xc00004ef80, 0x1)
/root/go/pkg/mod/github.com/jfrog/jfrog-client-go@v0.17.4/artifactory/services/download.go:386 +0x808
github.com/jfrog/gofrog/parallel.(*runner).Run.func1(0xc00046a1c0, 0xc0005d6c60, 0xc00046a1d0, 0xc00046a1e0, 0x2)
/root/go/pkg/mod/github.com/jfrog/gofrog@v1.0.6/parallel/runner.go:111 +0xb1
created by github.com/jfrog/gofrog/parallel.(*runner).Run
/root/go/pkg/mod/github.com/jfrog/gofrog@v1.0.6/parallel/runner.go:108 +0xd9

@DO-User - thanks for providing the stacktrace.
We're unable to replicate this issue. We tried creating the exact same spec from your logs:
{ "files": [ { "pattern": "generic/modules/modules-1.0.0.tar.gz", "target": ".", "explode": "true" } ] }

and we get no errors.
Maybe there's something in the structure of your modules-1.0.0.tar.gz that causes this. Will you be able to share this file with us, so we can reproduce this behaviour?
Let me create a command that you can use to send us this file...

@@DO-User,
If you are allowed to share with us the modules-1.0.0.tar.gz file, then you run the following JFrog CLI command while inside a directory containing the modules-1.0.0.tar.gz file. It will upload this file to a repository where we can fetch it from.
jfrog rt u modules-1.0.0.tar.gz t1 --url https://ecosysjfrog.jfrog.io/artifactory --access-token eyJ2ZXIiOiIyIiwidHlwIjoiSldUIiwiYWxnIjoiUlMyNTYiLCJraWQiOiJ2MUFpWkIySDFMakllYXY2aHRoRXZST1NHYktpM2N3b3IwbEgtX0h4ZnBnIn0.eyJzdWIiOiJqZi1hcnRpZmFjdG9yeUAzMDNmMThjNC0yYzc4LTRiOGEtYWNjMi03M2FkMjhmMTE1MjBcL3VzZXJzXC9odHRwczpcL1wvZWNvc3lzamZyb2cuamZyb2cuaW9cL2FydGlmYWN0b3J5XC8iLCJzY3AiOiJtZW1iZXItb2YtZ3JvdXBzOnQxIGFwaToqIiwiYXVkIjoiamYtYXJ0aWZhY3RvcnlAMzAzZjE4YzQtMmM3OC00YjhhLWFjYzItNzNhZDI4ZjExNTIwIiwiaXNzIjoiamYtYXJ0aWZhY3RvcnlAMzAzZjE4YzQtMmM3OC00YjhhLWFjYzItNzNhZDI4ZjExNTIwXC91c2Vyc1wvZXlhbGIiLCJleHAiOjE2MDg2MTUyNjYsImlhdCI6MTYwODU3OTI2NiwianRpIjoiZmE1NmJkNjEtMzgzNy00YjgzLTlhZGMtZjU3NGYxZDNiZTdhIn0.N_1xYFF4uIax83wBEDrVC0_MOl2vbb2drrrPeRm9bidxMbDF9KsMA-sUKTq2qh5Bg03Eko4KntNjLZVD9_WucsSvXaEMdJu4nr4N953vxuaK3MSUkFK5PSZlH4WQsFgLxjyQSDnnFGXiMIsN41X3S9TGfsWqWRDmwRVRE6-npCRcEtHFABYG5mcuvcUDqsIIxl6KCzNHuHyx9lHbK-h0cqE8QSezE6G45zL9JH5jQ9NWjF8NSizV0Vbreus7KC9kmKnJQ7pGDTDkA6fEpMsHDE8kQLILfv2xbcZBbIGo9hHi12m8d00jXpnuQlBIKGfdL1nlnNMV222DfMWvYUl_4g

@eyalbe4 , thx for the reply .
this task was working ok till yesterday .
from what we found :
it stopped working with the new jfrog-cli
jfrog-cli version 1.42.x has stopped working with "." as target  and "explode=true"
if you change the target with "./" its working.
jfrog-cli version 1.41.2 this behavior is disappearing and the task is working correctly.
the content of modules-1.0.0.tar.gz is folders with number of folders.(nothing special).
for example :
com/
system/
redis/
that should be extracted to modules/[com,system,redis] (also it created the folder modules).

I'm happy to hear this is working for you now @AlexeiBarabash!
Appologies for the inconinicence caused by this issue.
@Or-Geva shared with me that he managed to repruce the issue. We decided to enhance the testing scneios as part of the JFrog CLI's testing code around the explode functionality. We want to make sure this farly complex functionality is fully covered.
We're also working on making some design chamges to the code, which should simplify it and make it safer to maintain.

Hi @eyalbe4,
Maybe we didn't explain it clearly, but the usage of "." as a target path is still not manageable.
We had to modify our pipelines in order to fix this syntax issue.
Anyway, we've already made the adjustments on our side, and I glad to hear that you thick your tests for the Jfrog CLI.
Thanks.


chore(package): update cypress to version 4.0.2

Closes #145

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support --aws-instance-profile option through environment variable?

Would you consider a patch adding support for an AWS_INSTANCE_PROFILE=1 (or similar) environment variable? It's currently the only option we can't pass as an environment variable.

Yeah, I'd accept that.


[Terraform] Add option for platform providers locking

It would be valuable to have to option to extend the platform providers locking.
https://github.com/dependabot/dependabot-core/blob/f6acb90326f54ad7b19d6045ad9d8f9960248855/terraform/lib/dependabot/terraform/file_updater.rb#L115
Or we simply add all needed platforms in the hcl.lock through the flags -platform=linux_amd64 -platform=linux_arm64 -platform=darwin_amd64 -platform=windows_amd64.
Parsing the hcl.lock and deciding which to take might be to much.

duplicate of #4042


add google analytics to flutter_tools

This adds support for sending anonymous usage data for flutter_tools to google analytics. It:

prints a message on first run, telling the user how to disable the analytics, and displaying the privacy policy
adds a new flutter config command, where analytics can be enabled and disabled
sends command usage, command timing, and crash data

We'll want to iterate on it to properly track the host OS and command parameters.
fix #1065

and command parameters

Do you mean "multi-arg commands" like flutter build apk ?

I think it is critical that we add a test that verifies that if you turn off analytics, we don't send any analytics.

LGTM if, and only if, we have a test that verifies that once you opt-out, we don't send analytics. Ideally this would test the following scenarios:

flutter create in two different directories, opt-out while in one, are you opted out of the other?
opt out then flutter upgrade (not sure how you simulate this usefully), are you still opted out?
opt out then change channel (alpha -> master, say), are you still opted out?

Also, please update our docs so that when they introduce the flutter tool, they mention how to opt-out.

Do you mean "multi-arg commands" like flutter build apk?

No, I meant things like --foo - flags and options to commands. flutter build apk would come in as apk. For the nested commands, we could manually override to something like build_apk.

I'll add some tests and update the PR. We store the opt-out data in ~/.flutter, so it would work independent of the current project, or something like running flutter upgrade.

(I'm going to rev. the usage package to make this easier to test.)

@Hixie, this PR has been updated quite a bit since the first review. It doesn't send any analytics on first; it doesn't send any analytics for the config command (in case the user is in the process of disabling analytics); we print the analytics state in the help for config now; we rev'd to 2.2.0 of usage to capture some changes that make testing easier; and there are two tests to verify that we don't send data when we shouldn't.


Inlcude missing packages and files into pkg setup script.

Coverage remained the same at 90.143% when pulling f8d33b815e8e858cd1c4cf40899f794565bd0487 on alexprey:master into 220d74d089e8d519e6f1985a93c704c9150646da on JamesPHoughton:master.

Coverage remained the same at 90.143% when pulling 37427239f5ed5d6ea67e28aa26ffa74495e9b613 on alexprey:master into 220d74d089e8d519e6f1985a93c704c9150646da on JamesPHoughton:master.

Moved to https://github.com/JamesPHoughton/pysd/pull/164


Set-BcContainerServerConfiguration and Restart-BcContainerServiceTier added

I added the Set-BcContainerServerConfiguration and Restart-BcContainerServiceTier cmdlets to make it easier to change the Service Tier configuration.
Second try of #2488. I messed up the rebase.

will be in a preview later tonight

I renamed the Set-NavConfainer.... to Set-BcContainer (which you had in the .psm1 file)


VoiceConnection stuck in autopaused or signalling after 50 seconds

Describe the bug
The voice connection may disconnect after 50 seconds or less.
It causes the music to be paused. /pause and /play do not work after that anymore.
The bot must be restarted.
To Reproduce
Steps to reproduce the behavior:

Choose a voice channel region, which server id is below 10,000
Summon the bot and play any content
Wait 50 seconds

Expected behavior
The bot continues to play
Additional context
Temporary fix implemented in 723ee14bb5e2fe344b143f785208cb33847bf68a .
The fix creates a bad stream pause of about 200 milliseconds though.
Issue is already known: https://github.com/discordjs/discord.js/issues/9185

Fix has been implemented on the dev image, but this only seems to be a temporary solution.
Waiting that more information comes up on the issue...


Add "failSafe" init-param configuring FilterUtils.throwOnErrors

Enable configuring FilterUtils.throwOnErrors via web.xml configuration of the Filter.

The travis-ci/pr check error looks like a false failure, with a subsequent try succeeding.

Thanks Andrew!


Add z-depth-0 to remove shadow from elements

Some elements come with default shadow, like the navbar or the buttons. I would like to have a z-depth-0 so we can remove the shadow on those elements and make them flat if desired.

Codepen with the code:
http://codepen.io/anon/pen/KwLoXr

Added in c7305d328b73f361f5ed9d2c2e0f86d

Thanks!! :+1:

Awesome.
It would be great to update the Rails gem with these updates.
Also the rgba is missing a zero at the end, it has to be 4 zeros

I am just repeating what @0bserver07 said.

It would be great to update the Rails gem with these updates.
Also the rgba is missing a zero at the end, it has to be 4 zeros

I have mentioned you @Dogfalo  just to make sure you've already read his comment :)

Thanks a lott..It worked ..!!!!!!

Wow... @vivekgautamj That was, well. Fast ;)


Unable to create personal git repository

Windows 10
GUI gives ERROR CODE 218 - Can't get TLF private key for key generation 5 in method keybase.1.git.createPersonalRepo
Command line gives - ERROR Can't get TLF private key for key generation 5

Can you keybase log send ?
CC: @strib

OR cc: @mmaxim

my log id: 0b2c25ff0d82a4e279d8571c

@brkattk looks like that folder is keyed for the device you're using (xuul-9370).  Can you log into Keybase from one of your existing devices with access, either mbp-zuul, zuul18, or pixel-two?  If those are already online or you've already tried that, it would be useful to get a keybase log send or feedback sent from one of those devices, to figure out why it hasn't been rekeyed.
Seems like you added this device just today, from pixel-two -- maybe you closed the app right away after provisioning it, and it didn't have time to rekey?  Or maybe something else is wrong...

(Edit above -- not keyed.)

I may have tried creating the git repo too soon? I did do it almost immediately after adding the new device, from the new device.
I got that error above and tried also adding the git repo from the pixel-two device, but I don't know how to send logs from the phone.
Here's some logs from zuul18: ffaa5d3a9bdf9dd5572b061c fc5817c94dda39dac061a91c
I tried creating the repo on that machine and it did eventually work

Thanks.  Yeah things look fine now for all your devices on our side.  I think you hit a known performance bug where everything gets slow when you revoke a device that had written to that folder in the past.  We have a fix but it's not out in a release yet.  So probably it just took a while to do make the folder available to your new device.  Sorry about that!
P.S.: On the phone, you can "Send feedback" from one of the menus, to send us logs.  But don't worry about that now, all looks fine.

No worries. Thanks!


yas3fs deletes the /tmp directory

Hi,
I've discovered a specific set of conditions under which the entire /tmp directory is deleted when yas3fs cleans its cache.
This causes all sorts of problems in Linux since /tmp is a system directory that should always exist.
How to recreate

Start with an empty /tmp directory.
Run yas3fs and add a new file to the mounted directory.

The local filesystem cache is created at /tmp/yas3fs/...

Delete the file you just added to the mounted directory.

yas3fs removes that file from its cache
empty cache directories are recursively deleted using python's os.removedirs method
because that was the only file in the cache, the entire /tmp/yas3fs directory is deleted
/tmp is now empty so it gets deleted

Why it happens
This happens because FSCache.delete() calls FSData.delete(), which calls remove_empty_dirs_for_file(), which calls remove_empty_dirs(), which uses os.removedirs().
The docs for os.removedirs() say that:

removedirs() tries to successively remove every parent directory mentioned in path until an error is raised (which is ignored, because it generally means that a parent directory is not empty).

Therefore if /tmp is empty after deleting /tmp/yas3fs, then it will be deleted too.
What should happen
yas3fs shouldn't recursively delete beyond its own cache path (i.e. the --cache-path option, in this case /tmp/yas3fs)
It might be necessary to implement a custom recursive delete function rather than use os.removedirs(), since it doesn't look like it's possible to limit that to a specific root directory.

 This isn't the first time I've seen os.removedirs() misused. It's an unintuitive API.

Would shutil.rmtree be the correct choice here?

it's fixed


nimble-menu-button doesn't close when scrolled out of view

🐛 Bug Report
The nimble-menu-button stays open when it is scrolled under another part of the page. This means the button itself is no longer visible, but the menu itself renders on top of the other content.
As an example, you can see that the menu is showing on top of the gray properties panel even though the menu is not visible.

We should consider fixing this in a holistic manner that would also address other potentially problematic components, such as the nimble-select and nimble-combobox.
💻 Repro or Code Sample

🤔 Expected Behavior
The menu associated with the menu-button should close when the menu-button is no longer visible.
😯 Current Behavior
The menu-button gets hidden behind other page content when the page scrolls, but the menu is shown on top of the other content. This leads to an odd "floating" menu that doesn't seem associated with anything on the page.
💁 Possible Solution
Use an intersection observer to close an anchored region whenever the anchor element goes out of view.
🔦 Context
This was originally filed as a bug within SLE: https://dev.azure.com/ni/DevCentral/_workitems/edit/2492542/
We should remove the workaround added to fix the bug once a fix is available within nimble.
🌍 Your Environment

OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
Version [e.g. 1.8.0]

The same issue we encountered while developing the mention-list dropdown in this PR
Currently, we have handled it by creating an intersection observer for the @ element in the editor. (Similar to the handling we did for this bug in sl-comments-library)
When the @ character is intersected, the mention-list popup will be closed.
But during our discussion, @rajsite suggested not to implement the intersection observer as a fix. Instead, all the popups must be closed whenever there is a scroll event that happens within the page. This behavior must be consistent across all the nimble components.

Instead, all the popups must be closed whenever there is a scroll event that happens within the page. This behavior must be consistent across all the nimble components.

The popup behavior should be consistent. mention listbox uses an intersection observer, table dismisses action menu on scroll of the table, combobx and select attempt to scroll with the page and do not dismiss. One possible choice was to behavior like native menu popups (i.e. right click popups), which seem to dismiss on scroll (at least on windows). A specific direction has not been determined yet.

Most dropdown controls (e.g. Shoelace, Carbon, Polaris) scroll with the page while open, and maintain a sane z height.
Fluent was the only example I found where the dropdown scrolls with the page, but appears above other content (like our menu button, select, and combobox).
Native select drop-downs behave in a few browser/OS specific ways (e.g. Safari prevents scroll while open).
Can we keep the dropdown open on scroll, and have it scroll under any frames?

Notes from team discussion:

table closes menus when it scrolls
SLE comment component closes at-mention popup on scroll (but that logic is there, not in Nimble rich text)
there are lots of native browser features recently landed or upcoming that might impact what we want to do

Fred will consider these inputs to determine priority and recommended direction.


tests, integ, dhcp: add tests exposing that dhcp on a bridge whose port is a vlan is buggy

On more complex scenarios, involving VLANs, NetworkManager hangs while assigning an IP address via DHCP to the linux bridge.
This is examplified when creating a VLAN on top of a bond, on top of an ethernet interface. That VLAN is in turn set as a port to a linux bridge.
The 2 added tests show that NM hangs when the linux bridge has a dynamic IP configuration on top of a VLAN - in the first test, this happens within a single transaction, while on the last, it manifests
when multiple transactions are used.
The NM main loop aborts since the interfaces are not assigned a dynamic IP address - since the DHCP server configured in the dynamic IP module is not being ran behind a VLAN interface, and as
such, the L2 traffic (untagged) is discarded before reaching the bridge.
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1755542

Coverage remained the same at ?% when pulling b7e4d889c2b9ed5c846a21d2413701e82b59c04c on maiqueb:bridge_port_vlan_over_bond into 34ee4efc751816a8a6ec1f806f802c61ff1c5199 on nmstate:master.

The test does not setup a DHCP server on VLAN interface, so we cannot tell it's a nmstate bug or DHCP failure on this issue.

To cover this case, please consider to create a test case where DHCP server is actually running:
#!/bin/bash

VLAN_ID=100
SRV_NIC="dhcpsrv"
CLI_NIC="dhcpcli"
SRV_VLAN_NIC="$SRV_NIC.$VLAN_ID"
NS_NAME="ns_dhcp_vlan"

ip link del $CLI_NIC
ip netns del $NS_NAME

ip link add $CLI_NIC type veth peer name $SRV_NIC
ip link set up $CLI_NIC
ip netns add $NS_NAME
ip link set $SRV_NIC netns $NS_NAME
ip netns exec $NS_NAME \
    ip link set up $SRV_NIC
ip netns exec $NS_NAME \
    ip link add link $SRV_NIC name $SRV_VLAN_NIC type vlan id $VLAN_ID
ip netns exec $NS_NAME \
    ip link set up $SRV_VLAN_NIC
ip netns exec $NS_NAME ip addr add <IP_ADDRESS>/24 dev $SRV_VLAN_NIC
ip netns exec $NS_NAME \
    dnsmasq --dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> \
    --interface=$SRV_VLAN_NIC

nmcli device set $CLI_NIC managed yes

The test does not setup a DHCP server on VLAN interface, so we cannot tell it's a nmstate bug or DHCP failure on this issue.

This could be useful though to keep an xfailed test to show that hanging DHCP responses block us.
Just an opinion though.

To cover this case, please consider to create a test case where DHCP server is actually running:
#!/bin/bash

VLAN_ID=100
SRV_NIC="dhcpsrv"
CLI_NIC="dhcpcli"
SRV_VLAN_NIC="$SRV_NIC.$VLAN_ID"
NS_NAME="ns_dhcp_vlan"

ip link del $CLI_NIC
ip netns del $NS_NAME

ip link add $CLI_NIC type veth peer name $SRV_NIC
ip link set up $CLI_NIC
ip netns add $NS_NAME
ip link set $SRV_NIC netns $NS_NAME
ip netns exec $NS_NAME \
    ip link set up $SRV_NIC
ip netns exec $NS_NAME \
    ip link add link $SRV_NIC name $SRV_VLAN_NIC type vlan id $VLAN_ID
ip netns exec $NS_NAME \
    ip link set up $SRV_VLAN_NIC
ip netns exec $NS_NAME ip addr add <IP_ADDRESS>/24 dev $SRV_VLAN_NIC
ip netns exec $NS_NAME \
    dnsmasq --dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> \
    --interface=$SRV_VLAN_NIC

nmcli device set $CLI_NIC managed yes

Sure, thanks for this :)
I'll adapt the existing code to optionally run dnsmasq behind a VLAN.

Please place the server veth and dnsmasq into a namespace. In my test, only with that the DHCP server can work on a VLAN interface.

Why does that happen ? I'll try to get traffic captures of this, to ensure there are dhcp responses from the server on the dhcp_cli interface.

@maiqueb , could you please revisit this PR?

Temporarily closing the PR, to reduce the PR queue, since I won't be able to work on this at the moment.


Added in the suppression of error using silent flag

Changed to now have all errors suppressed when using the -silent flag. This makes scripting much easier!

Thanks for this. Good work :+1:


[formrecognizer] Include typing improvements in changelog

API change check
API changes are not detected in this pull request.


About Helm controller and crd

Hello, This is a proposal about Helm Controller and the CRDs.
We have implement an example Controller based on the Helm3 code (with a little modification) and define the HelmRequest and Release crd. Here is an example HelmRequest crd
apiVersion: app.<group>/v1alpha1
kind: HelmRequest
metadata:
  name: jenkins
  namespace: default
spec:
  chart: in/jenkins
  clusterName: ""
  namespace: h8
  dependencies:
  - nginx
  values:
  - global.namespace=h8
  - aaa=aaa
  version: v2.0-b.3

A few notes:

most of the spec field is similar to helm cli, for example namespace/chart/values...
repo info is stored in a configmap, same format as helm
support ClusterRegisty. If clusterName == "", install to the current cluster
support a loosely dependencies,  the HelmRequest in  the dependency list will be checked first before install this HelmRequest

Also there is a Release CRD, here is an example:
apiVersion: app.<group>/v1alpha1
kind: Release
metadata:
  creationTimestamp: "2019-07-09T07:37:25Z"
  generation: 2
  labels:
    modifiedAt: "1562657845"
    name: dex
    owner: helm
    status: deployed
    version: "1"
  name: dex.v1
  namespace: f10
  resourceVersion: "5519337"
  selfLink: /apis/app.alauda.io/v1alpha1/namespaces/f10/releases/dex.v1
  uid: 6579313f-a21c-11e9-8b67-525400488bfd
spec:
  chartData: <data>
  configData: <data>
  hooksData: <data>
  manifestData: <data>
  name: dex
  version: 1
status:
  Description: Install complete
  deleted: null
  first_deployed: "2019-07-09T07:37:25Z"
  last_deployed: "2019-07-09T07:37:25Z"
  notes: |
    1. Get the application URL by running these commands:
  status: deployed

It contains all the information in the old ConfigMap or Secret format , but use separate fields and move some field to status.
The controller we created use helm3 code as a library, besides it, it's a standard controller-manager with webhooks.  i think it's the right direction.
We are considering to open source all the implements and want hear suggestions from the maintainer team and all the developers. Hope our work will help the community

@hangyan Thanks for reaching out. Would you be interested in demoing this at a Helm Developer Call.
If you do make something readily available we have a related projects page this could be listed on at https://helm.sh/docs/related/
I know weaveworks has done some work in this space. I'm not sure. Are you aware of their work? It might be a good place for inspiration, collaboration, or just a way to know what else is out there.

@mattfarina Thanks for you response.  Love to demo it at the developer call. I have checked the schedule and it seems like it's only a few hours left, i will do some preparing before the demo.
We will discuss about open source as soon as possible,  it also require a lot of documenting work.
I haven't heard about from weaveworks's work. But i will check out, surely  we can learn from each other and get some great inspiration.

@mattfarina Sorry to bother you, i have check the meeting time, it's 12:30 wed in Beijing Time, But nobody is online, is the meeting delayed or something?

@hangyan checkout https://github.com/fluxcd
You don't need to feel pressure to demo this week. This is a regular meeting. You can demo in the future.

@mattfarina  It's ok, i cal the local time wrong..  I will check out the fluxcd project.

I'm on the meeting. Still no one?

The meeting was at 9:30AM Pacific Standard.

@bacongobbler I have check to local time is Friday 12:30AM in Beijing, am i cal wrong  again ?

@hangyan I think the time would be 01:30 am Friday (Beijing)

Yes ,that make more senses. But i didn't know why google give me that answer.

Possibly didn't take daylight savings into account?

Thanks for pointing it out. Didn't familiar with that before... Guess it will be next week.

Guess i have missed the meeting again, it should be 0:30 am Friday in my local time (Beijing)...Sorry guys, next week...

https://github.com/alauda/captain
I have upload the codes and add some intro docs,  it's welcome you guys can give some thoughts about it
@mattfarina how can add this project to this page https://helm.sh/docs/related/ ?

Make a PR against https://github.com/helm/helm/blob/master/docs/related.md

@bacongobbler Ok, thanks very much

@hangyan just noticed this was a helm 3 related project. Please check my edit above^

@bacongobbler OK, thanks


Added chalk to dependencies

Without this, git clone, npm install, npm test fails

Coverage remained the same at 6.41% when pulling 53707d49311526a8588f56c272182d5cf809170b on shawninder:master into 521242b58d9294b2c374059d453e072edd1cff31 on tunnckoCore:master.

Coverage remained the same at 6.41% when pulling 53707d49311526a8588f56c272182d5cf809170b on shawninder:master into 521242b58d9294b2c374059d453e072edd1cff31 on tunnckoCore:master.

Haha, very thanks! But it is pretty outdated and i'm thinking for updating it soon, or release one pluggable prompter, which is already working btw... code is at https://github.com/tunnckoCore/ideas/issues/56. It was factor from this module's code :)


Go module build fails with upper/lower case problem

Are you building on Win?
go: downloading github.com/Threagile/threagile v0.0.0-20201115181100-9a846523ea83
go: github.com/Threagile/threagile upgrade => v0.0.0-20201115181100-9a846523ea83
go get<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: github.com/threagile/threagile
	        but was required as: github.com/Threagile/threagile

Sorry, only the project URL


"failed to load RocksDB jni library"

When i start up bookie I meet this problem. Does anyone know how to solve this problem？help me please!

hello @Gray-Fullbuster I have the same problem,  I see you close this problem please share. i'm stuck this issue thanks

@Gray-Fullbuster hey gays, I have just sloved it by unstalling the old version java and installing the java8.


Update model files

Update model files to ss v3.30.20.

Thanks for getting this done @e-gugliotti-NOAA.
For the next release we should think about doing this earlier in the process because the changes to the model input files are a useful way to see the changes to the ss_new files for a variety of models (as in the example screenshot below).

Also @iantaylor-NOAA , thanks for the suggestion of doing this earlier for the next release! I think I would typically do this shortly after the release comes out, and it is on the checklist- the script I passed on had some outdated comments and confusing steps (completely my bad), so now that it is sorted out, it shouldn't be a problem to do this sooner. :)


ci: add pypi provider

PR summary

Added missing PyPI provider in .travis.yml
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.3.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(Code Sample/PHP): update response type to be php

Not for this PR, but this really should be php

Originally posted by @razor-x in https://github.com/seamapi/blueprint/pull/58#discussion_r1714659877

@andrii-balitskyi Was the json response type for PHP intentional? Isn't there a PHP class for each resource?

@razor-x Yes, you're right, there's a class for each resource. I was referencing our current docs where we put JSON in the PHP response example. My bad.
I'm not sure how a PHP-style response should look.
Something like this:
?

@andrii-balitskyi For rendering the response for each language, let's use the primitive literal syntax. I realize the actual return value is a wrapper data class, but it's not possible to format that via a formatter, and it can't be copy-pasted into an interpreter.
So for PHP, this would be
[
    "connected_account_id" => "...",
    "is_managed" => True,
]


Unable to do anything after update.

Running Actual-Server in docker.
After updating nothing is working. Server showing offline. File won't load.
Getting this error in the logs:
Rejection: TypeError: res.status is not a function     at middleware (/app/util/error-middleware.js:3:7)     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)     at trim_prefix (/app/node_modules/express/lib/router/index.js:317:13)     at /app/node_modules/express/lib/router/index.js:284:7     at Function.process_params (/app/node_modules/express/lib/router/index.js:335:12)     at next (/app/node_modules/express/lib/router/index.js:275:10)     at expressInit (/app/node_modules/express/lib/middleware/init.js:40:5)     at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)     at trim_prefix (/app/node_modules/express/lib/router/index.js:317:13)     at /app/node_modules/express/lib/router/index.js:284:7

Running from InPrivate getting this:

See #40. Fix in the PR #46 seems to be working for me now.

That did the trick.
I'll close this one seeing as it's a duplicate.


Webpack 5 loadModule throws unhandled error if a loader returns error

Bug Report

What is the current behavior?
When calling loadModule in the context of a custom loader, if any loader for that given module type returns an error, Webpack crashes without reporting what the original error is. The resulting error and stack trace is as following:
Error: The module created for a LoaderDependency must have an original source
    at compilation.handleModuleCreation.err (/sandbox/node_modules/webpack/lib/dependencies/LoaderPlugin.js:79:16)
    at buildModule.err (/sandbox/node_modules/webpack/lib/Compilation.js:1556:8)
    at hooks.result.callAsync.hookError (/sandbox/node_modules/webpack/lib/util/AsyncQueue.js:281:5)
    at Hook.eval [as callAsync] (eval at create (/sandbox/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/sandbox/node_modules/tapable/lib/Hook.js:18:14)
    at AsyncQueue._handleResult (/sandbox/node_modules/webpack/lib/util/AsyncQueue.js:254:21)
    at _processor (/sandbox/node_modules/webpack/lib/util/AsyncQueue.js:237:11)
    at _modulesCache.store.err (/sandbox/node_modules/webpack/lib/Compilation.js:1263:15)
    at /sandbox/node_modules/webpack/lib/HookWebpackError.js:69:3
    at Hook.eval [as callAsync] (eval at create (/sandbox/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/sandbox/node_modules/tapable/lib/Hook.js:18:14)
    at Cache.store (/sandbox/node_modules/webpack/lib/Cache.js:107:20)
    at CacheFacade.store (/sandbox/node_modules/webpack/lib/CacheFacade.js:282:15)
    at module.build.err (/sandbox/node_modules/webpack/lib/Compilation.js:1254:26)
    at doBuild.err (/sandbox/node_modules/webpack/lib/NormalModule.js:795:12)
    at processResult (/sandbox/node_modules/webpack/lib/NormalModule.js:604:12)
    at runLoaders (/sandbox/node_modules/webpack/lib/NormalModule.js:691:5)
    at /sandbox/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /sandbox/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/sandbox/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at Object.module.exports (/sandbox/loader2.js:3:3)
    at LOADER_EXECUTION (/sandbox/node_modules/loader-runner/lib/LoaderRunner.js:132:14)
    at runSyncOrAsync (/sandbox/node_modules/loader-runner/lib/LoaderRunner.js:133:4)
    at iterateNormalLoaders (/sandbox/node_modules/loader-runner/lib/LoaderRunner.js:250:2)
    at Array.<anonymous> (/sandbox/node_modules/loader-runner/lib/LoaderRunner.js:223:4)
    at runCallbacks (/sandbox/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:27:15)
    at _provider.call (/sandbox/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:200:4)
    at /sandbox/node_modules/graceful-fs/graceful-fs.js:123:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)

Reproduction steps:
The reproduction requires two different file types to be included on the webpack configuration:

A file type configured with a loader that will return an error (through emitError or calling callback(error)).
A second file type configured with a loader that will call this.loadModule, passing as argument the path to a file matching the first file type.
Minimal reproduction steps available on the following code sandbox: https://codesandbox.io/s/wpk-loadmodule-err-j7uom?file=/loader.js

A real-life scenario example would be the following:
index.js ->
@import "index.html";
index.html ->

    <link href="index.css" type="text/css" rel="stylesheet">

index.css ->
Anything that causes a syntax error.
Loaders for HTML files: ["file-loader", "extract-loader", 'html-loader"]
Loaders for CSS files: ["file-loader', "extract-loader", "css-loader"]

What is the expected behavior?
Webpack should not crash, and instead correctly report the error thrown by the loader.
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Reproduced on webpack 5.4, 5.11 and 5.14. I can confirm that this issue does not reproduce on webpack 4.
From a brief analysis of the thrown error, I've noticed that the done callback from handleModuleCreation on the file LoaderPlugin.js expects the module to have an originalSource set. However, on NormalModule.js when doBuild has an error, it is simply marking the module as failed and returning, and at that point this._source has never been set.
As I don't know the full context of why the error is not immediately returned from doBuild's callback, my suggestion would be to either:

Initialize a module's _source using the module's raw content.
On LoaderPlugin besides checking err, also check the module.errors before proceeding.
Return the error on doBuild's callback.

I am willing to contribute with the fix as this is something that will impact my team's development with webpack.

I'm having the same issue, when i try to use html-loader with some custom tags (ex: ng-include)

I'm having the same issue, when i try to use html-loader with some custom tags (ex: ng-include)

I've submitted #12632 to address this issue. It would be really nice to have a maintainer provide feedback on this. Thanks!


Remove IDEA related files on repository and add those to .gitignore

Yes I will try

It was completed. close issue.

Still there are IDEA related files on repository.

@getogrand There seems no IDEA files. Can I close this?

@mingrammer Sure! Thanks!!


TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

How to fix the TypeError in "gpt-neox/megatron/fused_kernels/setup.py", line 11, in _get_cuda_bare_metal_version
[cuda_dir + "/bin/nvcc", "-V"], universal_newlines=True
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' when running "python ./megatron/fused_kernels/setup.py install" in README? Thanks.

Try running
git checkout make_fused_kernels_optional
pip install -r requirements/requirements.txt

and then running the code you're interested in.

@StellaAthena    As I have tried your code, it shows the error below
"File "/usr/local/lib/python3.7/dist-packages/deepspeed/launcher/launch.py", line 147, in sigkill_handler
    raise subprocess.CalledProcessError(returncode=last_return_code, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-u', 'generate.py',"

So how to fix it? Thanks!

@StellaAthena
As I have tried your code, it shows the error below
"File "/usr/local/lib/python3.7/dist-packages/deepspeed/launcher/launch.py", line 147, in sigkill_handler
    raise subprocess.CalledProcessError(returncode=last_return_code, cmd=cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python3', '-u', 'generate.py',..."

So how to fix it? Thanks!

I have absolutely no idea. This doesn’t really provide a whole lot of information, and could easily be an issue with your local set-up rather than an issue with the code. It does look like my suggestion solved your original issue though?

I'm also getting the original error :( And checking out the branch, installing requirements, and running it didn't work.

It seems to be b/c nvcc is not installed, so running sudo apt install nvidia-cuda-toolkit will work, and then fused kernels can be installed (assuming compatible cuda versions)


feat: Examples from docstrings are also taken over to stub docstrings

Closes #115
Summary of Changes
Examples from docstrings are also taken over to stub docstrings.

:tada: This PR is included in version 0.3.0 :tada:
The release is available on:

v0.3.0
GitHub release

Your semantic-release bot :package::rocket:


Support for GCS Cloud Pub/Sub Notifications

GCS has a new feature (currently in private alpha) wherein buckets can be configured to send object change notifications to Cloud Pub/Sub topics, rather than as push notifications to HTTPS endpoints.

Implemented in 60c15f4557d9bdc47c48f16133f238cf1f273357.


docker search filter official images

Can we add a simple switch to output only official images for docker search, as there is for --automated=true|false ?

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I thought it is a good idea, and it is easy to implement.
From the (client code)[https://github.com/docker/docker/blob/master/api/client/search.go#L72], we can find that the response of search command from registry include the IsOfficial attribute.

I think it makes sense, so I'm +1 for a feature that support this.
For consistency with other commands (e.g. docker ps, docker images), I would be in favor of implementing a --filter option for search in stead of adding more flags, and mark the --automated and -s, --stars flags as deprecated.
e.g. docker search --filter is-official=true --filter is-automated=true foobar

https://github.com/docker/docker/issues/22369 was merged, so this will be in docker 1.12
thanks @fsoppelsa!


Seperate fov option for ashley?

hello i was wondering if maybe u could add a seperate fov setting for ashley, the one i use pulls itself too far back when ashley is in the party so i have to lower it when she joins

Tried adding a basic override for this, but it looks very strange whenever you tell Ashley to stop/start following and the FOV changes at the same time as the camera moves in/out.
Better solution might be to adjust the position of the actual camera instead. Looks like the Ashley Follow camera is defined in stru_BFB360, and the corresponding camera for aiming is defined in stru_BFA4F0. Not sure if we need to edit this or if we can just apply a vector somewhere to zoom in/out.


Is it possible to run cfbot with api access token

Hello
This is not really an issue but just want to know if it's possible to do. I am already having the oauth token from bluemix so it is possible to avoid getting cf_username and cf_password in cups.

The application doesn't support this authentication scheme at the moment I'm afraid. We use the https://www.npmjs.com/package/cf-nodejs-client client library for Cloud Foundry and it doesn't seem to support this either.
If you want to attempt to get this working, please send a pull request 😀


attempt to fix msvc compilation

Scope & Purpose
Try to fix a compile error on Windows

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.11: -
[ ] Backport for 3.10: -

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Obsolete


Feature/model student and class

required changes are added

reduce no of commits from 2 to 1

reduced


Removing comments on runbook, tip passthru

The machinery for passing through these fields no longer exists, as we can't
depend on having the individual check to pull this information from. Removing
these comments, and making runbook mandatory, for clarity.

ship


Logging to a file?

Would it make sense to add a Target variant for logging to a file? It doesn't make sense to print to stdout or stderr in TUI applications as that breaks the TUI, and having to ask users to redirect stderr to a file is inconvenient.
Context: https://github.com/osa1/tiny/issues/238

Sure, sounds like a simple enough addition. @SirWindfield wdyt?
One thing to note is that this can't be done in a backwards-compatible manner, because Target currently implements Copy.

If we decide to do this, we might want to copy what simplelog does and accept anything that is writable.

One thing to note is that this can't be done in a backwards-compatible manner, because Target currently implements Copy.

Send and Sync will also be lost if we simply put a file handle in a Target variant, but they can be maintained by wrapping the File with Arc<Mutex<..>>.
Also, Target is currently exposed to users so adding a new variant to it is a breaking change that requires major version bump. So regardless of the traits I think this will require a version bump.

Also, Target is currently exposed to users so adding a new variant to it is a breaking change that requires major version bump. So regardless of the traits I think this will require a version bump.

Right. Could potentially be made non-exhaustive with the next version.

I’ve previously punted on supporting file logging, because it’s a bit of a can of worms. You can’t really just pipe records into a file, you end up needing to have custom file patterns, rolling files with configurable sizes, deal with transient IO errors and slow writes. It’s definitely possible, and has been done plenty before, but it always ends up being a whole stack of its own to maintain 🙂

@KodrAus What about adding a note that we don't do any of this? I think just piping records into a file would work well for short-lived programs, even if it quickly breaks down for daemons or server applications.

Maybe we could design it to indirectly support files, instead of baking it in? So it might look something like:
enum Target {
    Pipe(Box<dyn Write>),
    ..
}

which we then wrap in a Mutex in the logger and stream records to. You could use a File or rolling file wrapper and env_logger wouldn’t have to build its own rolling file API?

Yeah, I wouldn't want to bake in file either, that's why I mentioned how simplelog does it. Box<dyn Write> should be good.

Ye, I wouldn't want to just support a File object alone. We should definitely abstract it somehow away. Box<dyn Write> definitely goes into the right direction. I'd probably use that one if nothing better comes up.
Just to be sure here, non_exhaustive forces users to basically add a catch all into their matches, doesn't it? At least that would allow us to extend functionality later on if needed without introducing another breaking change.

Just to be sure here, non_exhaustive forces users to [basically] add a catch all into their matches, doesn't it?

That's exactly what it does.

Hi!
I tried to work out logging to a file based on custom_target example, but I could not.
Here is my attempt. I was expecting to have the logging written in the file and not in the command line. I simply get an empty file (from when it is created): there are no records in it.
Do you mind telling me my mistakes, or adding an example on how to do this?
Thanks in advance!

Have a look at #208, the Pipe Target sadly is broken, because we forgot to actually test it, ups. ^^
#211 already fixes this, but it's not merged jet.

Thank you very much!
I will test it when it is merged then :)


removing p5.signal from codebase (inital)

This is the inital Pr for removing p5.signal from codebase.
Any help on tesing or debugging would really be appreciated.

I think we are good to go now !
merging this :)


Script tags are not colorized properly when nested in C#

commenting to follow the result

commenting to follow the result

up


Improve docs for webpack and jsx

I made the JSX consistent with the Webpack examples.
Also brought more "ghost"/"undefined" variables into the snippets. I am not sure if this is more confusing but it still follows the consistency of using create-react-app varialbes (i.e. the paths.indexJs).

I'm SO sorry this took so long to merge! Thanks for making our docs better 🙂


New Installation not working

Laravel new project
install package
modify .env - (add api configs, secrets, etc)
php artisan envy:install
php artisan envy:sync
"There are no variables to sync!"

Hi, I might be misunderstanding you are doing, but here is my assumption.
You are adding env variables to your .env file and running the sync command, expecting it to notify you about env variables missing in your .env.example file which are present in your .env file.
However this is not what this library does. This library makes sure all your env variables used in your config files are present in your .env.example file.
I'll close this issue, however if my assumption is wrong, then please correct me and I'll reopen the issue, so we can investigate further what happens for you.


Extending JSONFormatter data JSON serialization (Patch advice)

I want to write a patch to solve the below problem: Would this be accepted?
I have a structure with a function pointer field.  Whenever I run
logrus.WithField("item", item)....

It fails using JSONFormatter with
Failed to obtain reader, Failed to marshal fields to JSON, json: unsupported type: datum.LifetimeFunc

This is because it cannot be serialized into JSON.  This is a common object that I would like to log in multiple places.  It would be great if JSONFormatter supported something like the following
type LogFormattable interface {
LogFormat() interface{}
}
Then, inside Format() for JSONFormatter, it could check if the object implements LogFormattable and if so, use LogFormat() rather than the object itself in the JSON log.
Does this sound reasonable?  If so, I could get a pull request up shortly.

As an extra issue, it would be great if I could trigger some kind of callback on log formatting issues inside Entry.log() rather than them going to stderr.  This has caused issues in production code where untracked error logs were getting dropped.

What about if you pass a function as a value to a field, it gets executed? That makes sense in general, because expensive values (e.g. for debugging or lower debugging levels) would then only be computed when needed.

I really like that.  It requires reflection packages though, right?  Would reflection on every field slow down logrus too much, or would that be acceptable?

We're already checking types, which in my experience is fairly cheap. I've wanted this in Logrus for some time, because it seems expected and would solve a number of people's performance problems (and being able to do crazy, fancy things). It shouldn't be hard to do, but it would have to come with a benchmark to proof it doesn't slow down Logrus extensively. I don't think it would, because it wouldn't do extra allocations. Let me know if you want to work on this.

I'll work on that patch.  It requires changing both the json and stdout formatter.  You feel trying to cast into a func() string is better than implementing a type?

Hi,
Before I work on this I wanted to clarify the use of func() rather than interface?  One option is something like this:
type Loggable interface {
    Logged() interface {}
}

type F func() interface{}

func (f F) Logged() interface {} {
  return f()
}

...

Then code can look like this:
log.WithField("complex", complexItem).Info("Hi")

And I don't need to remember to cast out complex item.  People can add inline functions with:
log.WithField("complex", logrus.F( func() interface{} {return ....}).Info("HI")

We can also go with your recommendation of func(), but then I need to remember to write this when I log something:
log.WithField("complex", complexItem.Logged),Info("Hi")

Let's merge this with https://github.com/Sirupsen/logrus/issues/207


Adding CDN usage + appropriate warnings.

Ariya,
As per our conversation in the google code issue, here's the PR for your review.
Google Code issue: https://code.google.com/p/esprima/issues/detail?id=627

Please squash into one commit. Don't forget to link to the issue in the commit message.
See any existing commits for an example.

Will do.

Sigh.  I will create new PR with one commit. :disappointed:


multi: modify key derivation to be fully deterministic, remove p2pkh, wallet now witness only

In this PR, we modify the wallet's key derivation for channels and the like to be fully deterministic. We do so by adding a new package: keychain.  Additionally, after this PR, the p2pkh addr type is no longer supported.  We do this as the mix of segwit and non-segwit addresses has caused widespread confusion with new users in the last. A related change is  that we no longer have a --witness_only option for the walletbalance RPC. Since the wallet will only produce segwit addresses.
NOTE: This PR contains breaking changes. Within channeldb,  we'll no longer store plain raw public keys. Instead, we'll store a  keychain.KeyDescriptor. This allows a stateless wallet to re-derive  the keys required to sign for a channel. This paves the way for our  static wallet backups, as these will serialize  keychain.KeyDescriptors rather than raw public keys.
Aside from the new package, another major change is that the  SignDescriptor struct now accepts a keychain.KeyDescriptor  rather than a raw public keys for similar reasons to the change  within channeldb.
new keychain package
The role of this package is to house all the interfaces that lnd will use to generate the various keys it needs to create contracts and operate within the network. Additionally, we also use this package to define a deterministic key derivation scheme, that can be implemented by any software/hardware that partially understands BIP43-like derivation.
The first version (v0) of the keychain schema is very simple. We re-use BIP43, with a slight twist. Re-using BIP43 lets us leverage all the existing libraries out there as far as compatibility. The purpose used is 1017, and the coin type, the particular coin type of the chain where the keys are meant to be used. Within our schema, we define multiple “key families”. Each key family is actually just manifested as a new “account” within the BIP44/43 family. With this schema, if we have static description of the keys used within a channel, given the seed, and the “KeyLocator”, we can re derive all keys necessary be able to re-sign for the channel.
NOTE: The integration tests are currently failing due to an issue with  node startup related to this change.
Related to https://github.com/Roasbeef/btcwallet/pull/15 and #719.

An intermittent deadlock was introduced in the linked btcwallet PR. Working on a fix right now, will update the PR's glide file with the latest version once I have a fix.

Pushed an updated rebase version. The bug was fixed in my btcwallet PR, as a result this should be able to build now.

After the latest changes, the build now passes!

Pushed out an updated version with two new commits:

https://github.com/lightningnetwork/lnd/pull/769/commits/6dc42693c2e832256671fce3076aa5c0f8c27372 (future proofing for future seed/derivation versions)
https://github.com/lightningnetwork/lnd/pull/769/commits/01a09d6185abe7f432a78698806d834a13c007e2 (fixes an integration test flakes)


Fix SamplerAddressMode.Clamp mapping in OpenGL

The previous mapping to Clamp caused a glError of INVALID_ENUM on OSX, but ClampToEdge is supported.

Thanks, according to info around the web, it seems like GL_CLAMP is definitely the wrong thing to be using here, although Nvidia doesn't seem to mind. Thanks for the fix!


[ListItemText] Add comonent prop to primaryTypographyProps and second…

…aryTypographyProps

[ v ] I have followed (at least) the PR section of the contributing guide.

fix #19036

@fyodore82 Could you have a look at the test fails? @eps1lon Is the pull request taking the right direction?

@oliviertassinari , I'll surely take a look and make correction next week, so tests will pass. I had no time yesterday so I left it as is.

Several comments for changes made.
I have removed Partial from primaryTypographyProps and secondaryTypographyProps for the following reasons:

All props of Typography are already optional
component prop is optional.
And the main reason, if component is used, OverrideProps will add component own props. Some components, especially custom, may have required props. With Partial all props, even required by custom component, will become optional which may introduce bugs. See line 23 of ListItemText.spec.tsx as example

Thank you for starting this effort. There are a lot of moving parts so reviewing this might take some time. First look is promising though

Any news on this?

Note this PR now addresses the underlying issue for all components at once (e.g. CardHeader is breaking too).
@eps1lon @fyodore82

Whats the plan for CardHeader? It’s pretty much same issue. Is anyone working on that already? Happy to transfer this work to CardHeader if it helps. If there’s any special considerations let me know too. @eps1lon @fyodore82

@rart , yes, for CardHeader solution will be the similar.
I think you can transfer it. At least I am not working on CardHeader.

@rart 👍


COSBETA-57: Validate phone registration

Fixes a bug where users could provide invalid phone number.
Changes a returned value of isPhoneNumberValid to false when it cannot be interpreted as an international or possible UK phone number. It used to be true, which allowed pretty much any badly invalid number to go through.
Checklist:

[x] Automated checks are passing locally.

Actually, looking at the comments on the ticket, I wonder if we should also be using the getNumberType() method of libphonenumber to check if it's a number that can receive SMS messages.
Perhaps we want to check if the parsed number is valid and its type is either MOBILE or FIXED_LINE_OR_MOBILE? More details here.


Use https for hibernate.org URLs

It'll get redirected to https anyway, so why not give an https URL to start with ...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

failed test is unrelated to the changes (https://hibernate.atlassian.net/browse/HSEARCH-5194)


webView doesn't render local HTML files

See the simple example at https://github.com/mvolkmann/svelte-native-webview.
app/App.svelte tries to use a webView to render app/demo.html, but nothing is rendered.

How are you ensuring the file is copied as part of the bundle? You might
need to update the webpack config
https://stackoverflow.com/questions/56167984/how-to-set-right-path-to-assets-in-nativescript
On Sun, 22 Mar 2020, 11:35 pm Mark Volkmann<EMAIL_ADDRESS>wrote:

See the simple example at
https://github.com/mvolkmann/svelte-native-webview.
app/App.svelte tries to use a webView to render app/demo.html, but
nothing is rendered.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/halfnelson/svelte-native/issues/138, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGS5HMEGGCEESSACGRMJLRIYHYJANCNFSM4LRJNVCQ
.


Add released Django 1.10 to travis

Django 1.10 is released, so add to travis.

The travis error is not my fault.


taken account of X-Forwarded-For header

everywhere we are using request.RemoteAddr[1]; we should first check if X-Forwarded-For[2] exists and use that instead. Then fall back to request.RemoteAddr.
See[3] for how golang/pkgsite does it. Also how they do ratelimiting is interesting[4]

https://github.com/komuw/ong/search?l=Go&q=RemoteAddr&type=
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For
https://github.com/golang/pkgsite/blob/8b9886cdffa22a4f43206ac784fa1646fd0b6da6/internal/middleware/quota.go#L89-L94
https://github.com/golang/pkgsite/blob/8b9886cdffa22a4f43206ac784fa1646fd0b6da6/internal/middleware/quota.go#L50-L70

There's also the Forwarded header which is standardized and is supposed to be a replacement of X-Forwarded-For
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded

We are not going to take X-Forwarded-For or Forwarded into account for now. This is because those headers can easily be spoofed among other problems. See[1] which deals with this comprehensively.

https://adam-p.ca/blog/2022/03/x-forwarded-for/

https://github.com/gin-gonic/gin/issues/2473
https://nginx.org/en/docs/http/ngx_http_realip_module.html

Another algo for selecting IP: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#selecting_an_ip_address

https://github.com/realclientip/realclientip-go written by the person who wrote https://adam-p.ca/blog/2022/03/x-forwarded-for/


SCRUM-1329 model paper handle for experimental conditions

A PR for discussions.

@cmpich @sierra-moxon
I agree with @markquintontulloch
The 'paper_handle' slot definition seems like it needs to be changed to 'handle' (build currently fails otherwise).
With the proposal to just attach a handle to the ConditionRelation object, now it means that we could have the same set of conditions in the same paper with different paper handles because they are used with different condition relations. So, we could have two conditions 'high salt' and 'high temperature' that are used with the 'has_condition' relation in some paper, with a paper handle 'high salt, temperature (has_condition)'; If another experiment used the same two conditions but with a different relation, e.g. "induced_by", it would then need a new and different paper handle like 'high salt, temperature (induced_by)' or something. Is this what we want?
I had thought ConditionRelation objects would get reused across different papers, but it sounds like that isn't necessary, in which case it is OK to reference a single reference/publication. I see that neither 'handle' nor 'single_reference' are required individually, but it seems that if one is provided, the other should be provided as well. Is there a way we can specify that?

Hi @markquintontulloch, @chris-grove - I think the handle does have to take condition_relation_type into account, yes, if it is intended to function the way it does at ZFIN (as a shorthand name for a set of conditions).  But, I was under the impression that the handle would only be used for ZFIN?  Is that still true?  If so, a ZFIN curator does not currently make condition_relation_types other than 'has_condition.'  (the highsalt hightemp use case does not currently exist at ZFIN).
I think we could have a conversation about what makes a ConditionRelation unique and whether or not the harmonized model leads to two different ways of curating?  If I understand correctly, for ZFIN, a DiseaseAnnotation will only every have 1 ConditionRelation, whereas other groups may have many ConditionRelations per DiseaseAnnotation.  This could lead to questions about what the "handle" means if used for other groups.  Do we have to address this use case now?
I'm curious why single_reference isn't required?  I think it probably should be.  It might not be very frequent that two papers use the exact same set of experimental conditions?

Those are valid comments, Chris, however, I would go for the simplest solution at this moment which serves the needs of ZFIN. As we develop the UI for the DA and the experimental conditions we will see if other MODs would be amenable to re-use the handle concept as well. We then can make the necessary modifications according to the new requirements. They probably will only be stated with a functioning UI to start with.
Sierra, thanks for fixing the paper_handle -> handle issue.

@sierra-moxon @cmpich
OK, yes, the most important thing now is handling the ZFIN use case, so if the model does that as proposed then I think we should move forward with it. I'm OK with making single_reference required, as long as we don't end up in a situation where we need to update the same reference information in multiple places. In other words, the DiseaseAnnotation class already has a single_reference slot, and so it should go without saying that a ConditionRelation object connected to a DiseaseAnnotation object has that same DiseaseAnnotation single_reference. If we can ensure that (in the software logic) the single_reference in the DiseaseAnnotation and the single_reference in the associated ConditionRelation objects are never decoupled such that the reference information has to be managed in multiple locations, then I'm OK with it.
I will go ahead and merge as is. Thanks!


[SCSS] Ctrl+Click is not working when file name has a suffix with a dot

VS Code Version: 1.55.2
OS Version: Windows 10 x64 10.0.19042

Steps to Reproduce:

Create 3 empty files: index.scss, theme.scss and component.theme.scss
Paste next snippet to index.scss@use './theme' as *;
@import './theme';

@use './component.theme' as *;
@import './component.theme';

Try open ./component.theme via Ctrl+Click
Note, Ctrl+Click on ./theme is working

yeah I also got a error of a non existing file;
The problem is in the naming of the file
use the below given code it's working :
@use './theme' as *;
@import './theme';
@use './component.theme.scss' as *;
@import './component.theme';

@tymsai Thanks, yes, I saw that it works with .scss, but it should also work without it, like other examples

@tymsai Thanks, yes, I saw that it works with .scss, but it should also work without it, like other examples

as I said there should be only one dot " . " in the file name.

If someone is interested in looking into i:. The logic to resolve the file name is in https://github.com/microsoft/vscode-css-languageservice/blob/3ab3d91a81bcebd9e8566e2cf7cad454188e8324/src/services/scssNavigation.ts#L27

Created a PR https://github.com/microsoft/vscode-css-languageservice/pull/241 fixing this


Audio device picker

Adds the ability to select which audio device to use for individual audio visualizer layers and globally for the local pc information game state.

Fixes #1784 and #1975


Fix the problem of building on Linux by merging files

After a failed attempt to fix the problem of building Kitura-Request on Linux by renaming files, to get the compile order correct, I am merging the problematic files together.
Fixes issue IBM-Swift/Kitura#955.
Tested on Linux and macOS by running Kitura-Request unit tests.

Current coverage is 83.58% (diff: 100%)

Merging #25 into master will not change coverage

@@             master        #25   diff @@
==========================================
  Files            10         10
  Lines           262        262
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            219        219
  Misses           43         43
  Partials          0          0

Powered by Codecov. Last update 2a496f6...a606d72


Method naming convention - please use this in figure labels etc.

•	WAM2layers
•	2LDRM
•	UTrack
•	BTrIMS
•	TRACMASS
•	HAMSTER-FLEXPART
•	WaterSip-FLEXPART (UiB)
•	WaterSip-FLEXPART (UniVie)
•	WaterSip-LAGRANTO
•	WaterSip-FLEXPART (HKUST)
•	WaterSip-FLEXPART (IBCAS)
•	WaterSip-FLEXPART (LATTIN, Uvigo)
•	Stohl&James-FLEXPART
•	WRF-WVT

I need some insights into the new naming convention.
Is WaterSip-FLEXPART (HKUST)  refering to FLEXPART-WaterSip (Xu) or FLEXPART-WaterSip (TFC)? The same question is about WaterSip-FLEXPART (IBCAS).
In addition, "WaterSip-FLEXPART (LATTIN, Uvigo)" is too large for labelling at the top of the subpanel.  It also does not follow the naming convention for FLEXPART-based models. I suggest renaming it as LATTIN-FLEXPART. We can highlight that LATTIN is a WaterSip-based tool, e.g., in the Figure caption.

Hi Albenis, good points. The FLEXPART-Watersip (HKUST) is the one from TFC. The one wit IBCAS is the one from Xu.


Hide email addresses everywhere

At the moment registered users can see the email address of other users. Could you please add an option, either globally in app.ini or as a user setting, to hide the email address completely from everybody (included both registered users and visitors)? Thanks

+1
notabug also wants this feature and currently implements it as a routine upgrade chore

Is this even viable? Since one can still pull a users repo (given it's public of course) and git log will print the commiters email :confused:
Only reason to hide emails from the UI is related to spiders, and in that case a global setting is enough IMO

Non-login user is already not possible to see the emails.

ok i am very unfamiliar with this codebase ATM but let me try to clarify the issue as i see it
yes the email address that you git commit is not the concern here - my assumption is that the email address on the User model as shown on the user profile page is not necessarily the same as the git commit address - on other hosts such as github my primary email address is NOT the one that i commit with for the very reason that i dont want too much spam - this is the primary email that is used for notifications and admin communications in addition to alternate email addresses can be defined for matching git commits
correct me if im wrong? is it the case that the email address shown on the user profile page MUST be the same as your git commit address? id so then this is not an issue i would pursue - but instead i would raise the issue that whichever email address that MAY or MAY NOT be shown on the user profile page should NOT necessarily be the same as your public git commit address so that admin communications and/or activity notifications can be sent to a private email address

@Unknwon the problem is not about non-login users, this already works very well. The problem is that we would like to hide email addresses to logged in users as well.
@bkcsoft your point is totally correct. However I don't think it's a problem if a user git-pushes his commits using some email. That's public and anybody can expect it to be public. Plus they can be using 2 different emails, one for registering to Gogs, and another one in their local git configuration. The way to fix this issue would be:
1 - hide users emails in every Gogs HTML template (for example in the user homepage). Currently this works only partially, because registered users can still see other users' emails
2 - when I commit from Gogs, for example when I create a new repo and select "Initiate with Readme file", Gogs uses the user email to push the new commit. This shouldn't happen. Gogs should just push using the username *and no email address
As I said, if a users commits something using his email, then pushes to Gogs, well here nobody can do anything, Gogs is not responsible for this.

@ftrtyyuukjnbvd
as i said i am just getting familiar with this project now but i am working on this feature regardless of whether or not upstream wants it - perhaps you could give me a head start?
do you know exactly which pages show the email? or else i will need to rely on find and grep to find them
is it true that the registered email is the only one you can also commit with? e.g. if you push commits under a different email are the not associated with your user?

@bill-auger the only page that I know is displaying the user email, is their own homepage. To be clearer, this page here. I'm not aware of any other place.
As far as I know, git always remembers the email you committed with. So for example, if I commit with email A, then again with email B, and then push to Gogs. A and B is what you'll see. What I was talking about is that if I create a new repo from Gogs (ie you select "Create new repo"), and also select "Initialize repo with Readme" (always from Gogs), Gogs creates the new repo, and then does the first commit (with the Readme file and possibly the .gitignore if you've selected that as well). This commit done from Gogs, withing Gogs, is registered with "Gogs username ", which I think you can read if you download the repo and reads the commit history.

@bill-auger to explain with an example, I've just created a throwaway account at try.gogs.io. Then, from Gogs, I've create a new repo using these settings

as you can see I didn't push anything myself, just created a new account and a new repo. Now, I invite you to clone my repo and look at the commit history. You'll see my email address that I used to register to Gogs with.

thanks - yes i understand you last point - that is probably a separate issue than this one
i was aware of the user profile page - that is actually the one place that some may want it to be visible - but the issue title says "everywhere" so i figured there were more
a quick grep has found 102 instances of the token 'Email' in the templates/ dir - surely not all of these are in visible portions but this may take some time to be sure


Fix Comments E2E tests

This fixes the currently skipped E2E tests for comments and introduce new tests.

Amazing that you got them to work! Did you figure out what was the issue before?

I'm not entirely certain if the tests will pass in the CI environment yet, as I'm encountering persistent failures with other tests like offline.test.ts (I've been retrying for a while now, not sure if the new tests have an impact on those). However, I did identify a problem in the previous comments code. Specifically, when a revalidation request was triggered by a comment webhook message, it was incorrectly deduplicated if there were other concurrent requests. We needed to adjust our approach to ensure that these revalidation requests are handled independently, as each one potentially carries unique and important updates that should not be ignored or merged with other requests.
Also, with the new cache manager, we do not need to worry about request deduplication anymore (thankfully), and I've also made the tests slightly simpler and plan to add more as we see fit.


Imprv: Enable to download an attached file with original name(添付ファイルを元の名前でダウンロードできるようにしてほしい)

Environment
Host

item
version

OS
windows 2016

crowi-plus
2.4.0-RC

node.js
6.11.5

npm
3.10.10

Using Docker
no

Using [crowi-plus-docker-compose][crowi-plus-docker-compose]
no

Client

item
version

OS
windows 7

browser
chrome

How to reproduce? (再現手順)

download an attached file by clicking link
(添付ファイルのリンクをクリックしてダウンロードする)

What happens? (症状)

the file is downloaded with a name which is "ObjectID" + "original file Extension"
(ファイル名がオブジェクトID＋元の拡張子でダウンロードされる)

What is the expected result? (期待される動作)

the file is downloaded with an original name
(アップロード時の元のファイル名でダウンロードできるようにしてほしい)

I misstake posted the same issue on crowi's github.
https://github.com/crowi/crowi/issues/262
Modified sources are also merged with crowi-plus, but since crowi and crowi-plus have different upload paths, the problem is not solved.

@tshimokawa
I was able to reproduce the problem. I investigate the cause of the problem from now on.
@dev-hayash
Thank you for reporting! I make use of it for a solution to the problem.

@tshimokawa @dev-hayash
I am sorry to have kept you waiting.
Next v3.0.7 release solve this problem.


Update to .NET 8 SDK

.NET 6 end of life is coming up in a couple months, and .NET 3.1 has been unsupported for years. So we should stop using those .NET versions. Library projects continue to target netstandard2.1 and net48, so this change does not impact applications that consume the libraries.

Update from .NET 6 to .NET 8 SDK in global.json.
Update from .NET Core 3.1 + .NET 6 to .NET 8 for test and benchmark projects.
Update PR and CI build steps accordingly.
Remove the build step to link libssl.1.1 on Mac OS, as it was failing on the current Mac OS build agents, and (I think) isn't needed anymore with .NET 8.
Fix GitHub action permissions for the test-reporter.

I'm still trying to get the crypto tests working on Mac OS again, that might take several more iterations.

I'm still trying to get the crypto tests working on Mac OS again, that might take several more iterations.

Fixed.


add HelloWorld ASP

Description

i add hello world use ASP and add describe about ASP.NET
Types of changes

[ ] Bug fix or improving code quality
[x] New language
[ ] New feature

Checklist:

[ ] My code follows the code style of this project.
[x ] I have updated the documentation accordingly.

add HelloWorld ASP and TypeScript


Unable to upload images and files

Below is what I see when I tried uploading an image.
![0_1468979555815_1464346253798-laksa_slide1.png](Uploading 0%)

What are your settings?
Are any files being put into s3?

Hi Lewis, thank you for replying.
I am hosting with nodeBB and I didn't user environment variable nor instance meta-data for S3 upload plugin. The last successful upload to S3 was 15th July.
The upload to S3 was working all the time and files are being placed in S3 until Julian helped us to migrate our stuff to a server in Singapore. Somehow it stopped working, I'm not sure if this is a coincident.
I filled up the following confirgation:
Database Stored configuration:

Bucket
Path
Region

Credentials

Access Key ID
Secret Access Key

Saw this in my log
22/7 01:59 [21308] - warn: [plugins/nodebb-plugin-s3-uploads-updated] Mapped path 's3 => /home/saas/nodebb/node_modules/nodebb-plugin-s3-uploads-updated/public' not found.

If its not been working since a migration please talk to the people that did your migration first.

I'm seeing this issue too. Do we need to set a CORs configuration or a bucket policy for the S3 bucket?

could you make a new issue with your issue and some more info of your own please ill close this one as the op never came back


Could you please share 170 annotated publications?

Hi,
Could you please share 170 annotated publications? https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6852618/
Best regards,
Elena

Hi @tutubalinaev, thank you for your interests in this project. Since this is in one part of our ongoing project, we haven't released the dataset to the public yet. We plan to share the datasets including both this and ongoing ones later. Sorry for the inconvenience.


Kubernetes Improvements

This quickstart is lacking in dashboards and alerts and due to the interest in it from our customers we should add a dashboard an alert to make this quickstart higher quality.
Justification
We have an upcoming event (Kubecon) where this will be showcased
Acceptance Criteria

[ ] add at least one new dashboard
[ ] add at least one alert

What is the exact type of data that is missing in this quickstart? I can take this one but need to get more context on the customer requests! @jpvajda


add issue/PR templates

repository can reuse the templates from Salt or others

When the time comes for this need, we'll add it.
So far the project is small and mostly gets bug reports from the salt team.


Unexpected registration behaviour

Describe the bug
The AddSingleton behaves in an unexpected way when instance is supplied.
To Reproduce
Steps to reproduce the behavior:

Using version '2.1.1' of package 'DependencyInjection'
Run this code

            var configurationBuilder = new ConfigurationBuilder();
            configurationBuilder.AddJsonFile("LocalSettings.json");
            var configuration = configurationBuilder.Build();
            serviceCollection..AddSingleton<IConfigurationProvider>(r => new ConfigurationProvider(configuration));
//few lines later...
public class SomeService
{
public SomeService(IConfigurationProvider configurationProvider)
{
}
}

See error

Expected behavior
Expected: SomeService is resolved correctly
Actual: Dependency resolution exception is thrown

Do you get an error for SomeService or for IConfigurationProvider? If it's the former, then it's because you didn't register the service. You need to register SomeService as well if you want to resolve it.

What's the exception?

Hi. We're closing this issue as no response or updates have been provided in a timely manner and we have been unable to reproduce it. If you have more details and are encountering this issue please add a new reply and re-open the issue.


Appstudio update test-component-pac-jyqh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-jyqh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
25 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
26 seconds
inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
24 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
24 seconds
sbom-json-check

✅ Succeeded
12 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-jyqh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
25 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
26 seconds
inspect-image

✅ Succeeded
24 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
24 seconds
sbom-json-check

✅ Succeeded
12 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-jyqh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
22 seconds
build-container

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
52 seconds
clamav-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
19 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-jyqh-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
22 seconds
build-container

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
52 seconds
clamav-scan

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
19 seconds
label-check

✅ Succeeded
8 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom