The link to the csv file is missing

The link which has csv file is not available, due to this I'm not able to load data into synapse:
https://feastonazuredatasamples.blob.core.windows.net/feastdatasamples/customer_profile.csv,
https://feastonazuredatasamples.blob.core.windows.net/feastdatasamples/driver_hourly.csv
https://feastonazuredatasamples.blob.core.windows.net/feastdatasamples/orders.csv

Any update on the issue ?


[TB-3062] Add reader mode settings error handling styles and colors

What 🕵 🔍

Add reader mode settings error-handling styles and colors

References 📝 🔗

TB-3062

Codecov Report

Merging #69 (51ef03c) into main (1bab75c) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   47.22%   47.10%   -0.12%
==========================================
  Files          56       56
  Lines        2069     2074       +5
==========================================
  Hits          977      977
- Misses       1092     1097       +5

Impacted Files
Coverage Δ

lib/src/linden/xcolors.dart
33.77% <0.00%> (-0.46%)
:arrow_down:

lib/src/linden/xstyles.dart
27.58% <0.00%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bab75c...51ef03c. Read the comment docs.


Download function is not working properly while ...

Download function not working properly using Right Mouse Button, while trying downloading folders with emails. Probably because emails have different ownership, with normal files eg. public_html all is working fine...
Let's try explain step by step, where is a problem.
Make a main virtual server: aaa.com
and a new domain as sub-server: bbb.com
Let's make some mails accounts eg<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>and these mails contain some emails inside folders.
Eg. a folder /home/aaa/domains have around 150MB, but after clicking Download under RMB the folder have less than 2MB and the archive don't contain emails. I thought, because a different ownership. However when I move a folder from /home/aaa/domains to eg. /root/domains then downloading is working fine...

If you disable automatic switching to user mode in File Manager configuration, and keep user as root, will download work?

I suspect that it would work.
Report back, please.
Now, I don't think that we even need to jail downloads in any additional way than it's already done by the File Manager core.

It is working as a charm now.
Thanks

It's fixed on the latest commit. Thanks for reporting.


Add examples for tabular data with FT_Transformer in AutoMM

Issue #, if available:
Description of changes:
Motivations: Examples of using FT_Transformer in AutoMM on 11 tabular datasets. Details of the datasets are described in Table 1 in [1], which covers (i) classification (both binary and multi-class) and (ii) regression tasks.
Availability to the datasets: The official implementation provides the datasets in numpy.darray format: https://www.dropbox.com/s/o53umyg6mn3zhxy/data.tar.gz?dl=1. Data in numpy.darray formatting was first pre-processedin into .csv format, which can thus be loaded with pandas.Dataframe as the input to AutoMMPredictor.  All Data in .csv format can be downloaded from s3.
Availability to the results The trained models, configs can be downloaded from https://autogluon.s3.us-west-2.amazonaws.com/results/tabular/results.zip.
ToDo:

Refine the dataset loading (from numpy.darray to pandas.Dataframe).
Add hyperparameters.
Add README file.

Results

Datasets
ca
ad
he
ja
hi
al
ep
ye
co
ya
ml

metrics
rmse
acc
acc
acc
acc
acc
acc
rmse
acc
rmse
rmse

problem_type
regression
binary
multiclass
multiclass
binary
multiclass
binary
regression
multiclass
regression
regression

#objects
20640
48842
65196
83733
98050
108000
500000
515345
581012
709877
1200192

#num.
8
6
27
54
28
128
2000
90
54
699
136

#cat.
0
8
0
0
0
0
0
0
0
0
0

#classes
-
2
100
4
2
1000
2
-
7
-
-

Best in [1]
0.459
0.859
0.396
0.732
0.729
0.963
0.8982
8.794
0.970
0.753
0.745

FT-Transformer in [1]
0.459
0.859
0.391
0.732
0.729
0.960
0.8982
8.855
0.970
0.756
0.746

AutoMM FT-Transformer + Const Lr=1e-4
0.404
0.863
0.388
0.727
0.729
0.954
OverflowError
0.781
0.964
AttributeError
0.904

AutoMM FT-Transformer + Cosine Lr=1e-4
0.401
0.864
0.388
0.728
0.729
0.952
OverflowError
0.780
0.964
0.765
0.924

Reference:
[1] Revisiting Deep Learning Models for Tabular Data (NeurIPS 2021)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1752-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1752/1/index.html

Need to add a README.md.

@zhiqiangdon We need to take a look at the overflow error.

Job PR-1752-4 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1752/4/index.html

Job PR-1752-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1752/5/index.html

Job PR-1752-6 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1752/6/index.html

Job PR-1752-10 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1752/10/index.html


Change Client's Meeting to a list

Codecov Report
Base: 69.20% // Head: 69.33% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (0fd2971) compared to base (409e727).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     69.20%   69.33%   +0.12%
  Complexity      421      421
============================================
  Files            77       77
  Lines          1338     1337       -1
  Branches        139      139
============================================
+ Hits            926      927       +1
+ Misses          374      372       -2
  Partials         38       38

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/client/Client.java
95.45% <50.00%> (+4.34%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to uninstall tensorflow?

Help I want to reinstall tensorflow, from GPU to CPU, because, just installed tensorflow not work correctly.
I test my installation, from documentation of tensorflow.org,
then it gives back that error:
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
hello = tf.constant('Hello, TensorFlow!')
Traceback (most recent call last):
File "", line 1, in
AttributeError: module 'tensorflow' has no attribute 'constant'

SO SHOULD I REINSTALL TENSORFLOW?
before I installed by pip, but it did not work then I use virtualen, also did not work, then by using anaconda. something worked, but I stack in testing installation. Help me!

@gunan Heads up: this is the second recent bug I've seen where someone somehow got an empty installation of TensorFlow (no tf.constant here, no tf.Variable for https://github.com/tensorflow/tensorflow/issues/7285).  This one is anaconda; not sure about the other one yet.
@danchokobo We don't support Anaconda, so if you installed it through that you should look at Anaconda docs to know how to uninstall.

Ah, didn't notice you were the same person from https://github.com/tensorflow/tensorflow/issues/7285.  I believe you installed through Anaconda, so you should look at the Anaconda docs for how to uninstall.

I installed tensorflow through pip for python on windows 10
cmd-> pip3 install --upgrade tensorflow
It said "successfully installed tensorflow" but when I typed " import tensorflow as tf", it gave me a huge error saying "DLL load failed" and "no module named _pywrap_tensorflow_internal" and "failed to load the native tensorflow runtime", in the end.
I uninstalled through pip -> pip uninstall tensorflow in command prompt and reinstalled but I'm getting the same error.

Do the following:
conda update libgcc
but this will require downgrading "due to dependency conflicts" next time you update anaconda.
OR
you can mask the anaconda libstdc++ so that your system's libstdc++ is used
cd ~/TO-YOUR-ANACONDA-FOLDER/lib
mv libstdc++.so libstdc++.so.bkp
mv libstdc++.so.6 libstdc++.so.6.bkp

Further optionally create a softlink inside the anaconda lib directly
ln -s /usr/lib/x86_64-linux-gnu/libstdc++.so.6 libstdc++.so.6


Unable to start CodeNarc Server

Looking for help with an error running analyze.  I originally saw this error running VSCode in remote mode via SSH, but I confirmed that I get the same error directly on the remote machine.
I have NPM 12 installed ( on both local and remote machines).  (I have removed any identifying info such as IPs)
GroovyLint: Unable to start CodeNarc Server. Use --noserver if you do not even want to try
CodeNarcServer http call unexpected error:
{
"name": "RequestError",
"message": "Error: connect ECONNREFUSED 172.x.y.z:7484",
"cause": {
"errno": "ECONNREFUSED",
"code": "ECONNREFUSED",
"syscall": "connect",
"address": "172.x.y.z",
"port": 7484
},
"error": {
"errno": "ECONNREFUSED",
"code": "ECONNREFUSED",
"syscall": "connect",
"address": "172.x.y.z",
"port": 7484
},
"options": {
"method": "POST",
"uri": "http://172.x.y.z:7484/request",
"body": {
"codeNarcArgs": "-basedir=/tmp/npm-groovy-lint/codeNarcTmpDir_0.7705393990443135 -rulesetfiles=file:/tmp/npm-groovy-lint/codeNarcTmpRs_0.8503429860780096.groovy -includes=**/regression.groovy -report=xml:/tmp/npm-groovy-lint/codeNarcReportXml_0.4252318666148276.xml",
"parse": true,
"file": "/tmp/npm-groovy-lint/codeNarcTmpDir_0.7705393990443135/regression.groovy",
"requestKey": "/home/user/src/pipeline/pipelines/regression.groovy-none"
},
"timeout": 360000,
"json": true,
"simple": true,
"resolveWithFullResponse": false,
"transform2xxOnly": false
}
}
GroovyLint: Error running CodeNarc:
/bin/sh: 1: node: not found

This node not found is strange... what OS/version are you using ?
Are you on a docker image ?

I think there is an issue with node-jre package, which is supposed to install java automatically when it is not here: it is deprecated
Can you stry again after installing Java ? ( 8 or 11 are tested via CI, but any version > 8 should work )

I updated the extension so that node is not called anymore, but a fork is instead
@jmcfallargo please can you confirm it is ok now ?

Confirmed - it now works!  Thanks for the help on this!
I did have Java installed locally, before I encountered this issue.

Great, thanks for your feedback and have fun grooving :)


[RFC] Gluon Based C++ Frontend

Problem statement
Currently, migration of cpp-package to MXNet2.0 is in progress. The changes in MXNet2.0 cpp-package include some tasks like renaming some CAPIs with Ex suffix, adopting CachedOp interface in executor forward computing and autograd interface in executor backward propogation. Which means, the v1.x cpp-package users can migrate to v2.0 to still utilize executor to do training or inferencing on their models.
However, there are two limitations:

The cross-compilation problem is not resolved at all. In issue https://github.com/apache/incubator-mxnet/issues/13303 and issue https://github.com/apache/incubator-mxnet/issues/20222, users are still facing the issue from using OpWrapperGenerator.py to open a target binary on the host machine.
The users for cpp-package are still interacting with symbols, which lacks certain flexibility in model construction.

Proposed New C++ Frontend
Based on the above limitations, I propose to adopt the design of gluon api to build a new version of cpp-package with both flexibility and performance benefits. The design logic is highly similar to current gluon2.0 with tracing and deferred compute. I have been building a simple gluon based cpp-package and a simple demo to create an end-to-end training process. The following is the high level overview of some APIs.
Operator
New operator is relying on packed function's runtime api(this is a runtime api, probably will solve the limitation1). Firstly, an operator map will be created by mapping from the operator's string name to its function handle. Then user only need to use this macro to create the operator wrapper in the mxnet::cpp::op namespace. Inside the operator, the type conversion and translation happens. It's similar to the function.py, which erase the type information for each argument and wrapped into MXNetValue, passed to C++ backend.
Block
MXNet C++ block will be the base class of all the basic layers, which is the same as python. It will use register_block to store the pointer to its children in a vector. Tracing and deferred compute is used to create the graph.
basic_layers
Currently, I have only Dense, Activation and Dropout layer for demo purpose. Parameters for dense layer will be registered with register_parameter method.
autograd
Since there is a lack of context manager mechanism in C++, we have to use start_recording() and finish_recording() to define the autograd recording scope. Also, the backward method is a simple wrapper around the CAPI.
Others
There are some other simple modules, like Trainer and loss
Example
A simple example
#include <chrono>
#include <string>
#include "utils.h"
#include "mxnet-cpp/MxNetCpp.h"

using namespace mxnet::cpp;

// Define a new Model derived from Block
class Model : public gluon::Block {
 public:
  Model() {
    // Register three dense blocks and one dropout block(need user to provide shape)
    dense0 = register_block("dense0", gluon::nn::Dense(64, 784, "relu"));
    dropout0 = register_block("dropout0", gluon::nn::Dropout(0.5));
    dense1 = register_block("dense1", gluon::nn::Dense(32, 64, "sigmoid"));
    dense2 = register_block("dense2", gluon::nn::Dense(10, 32));
  }

  // Model's forward algorithm
  NDArray forward(NDArray x) {
    x = dense0(x);
    x = dropout0(x);
    x = dense1(x);
    x = dense2(x);
    return x;
  }

  gluon::nn::Dense dense0, dense1, dense2;
  gluon::nn::Dropout dropout0;
};

int main(int argc, char** argv) {
  // Create a new model
  Model model;
  // Use Uniform Initializer to initialize the model's parameters with scale of 0.07
  model.initialize<Uniform>(Uniform(0.07));
  // Use legacy cpp-package's dataloader
  int batch_size = 32;
  std::vector<std::string> data_files = { "./data/mnist_data/train-images-idx3-ubyte",
                                          "./data/mnist_data/train-labels-idx1-ubyte",
                                          "./data/mnist_data/t10k-images-idx3-ubyte",
                                          "./data/mnist_data/t10k-labels-idx1-ubyte"
                                        };
  auto train_iter = MXDataIter("MNISTIter");
  if (!setDataIter(&train_iter, "Train", data_files, batch_size)) {
    return 1;
  }
  // Define autograd
  AutoGrad ag(true, true);
  // Define trainer with sgd optimizer and 0.5 learning_rate
  std::unordered_map<std::string, double> opt_params;
  opt_params["lr"] = 0.5;
  Trainer trainer(model.collect_parameters(), "sgd", opt_params);
  // Define loss function
  gluon::SoftmaxCrossEntropyLoss loss_fn;

  for (size_t epoch = 1; epoch <= 100; ++epoch) {
    size_t batch_index = 0;
    // Reset train iter
    train_iter.Reset();
    // Iterate the dataloader
    while (train_iter.Next()) {
      // Get data batch
      auto batch = train_iter.GetDataBatch();
      // Start Autograd recording
      ag.start_recording();
      // Apply model on the input data
      NDArray pred = model(batch.data);
      // Compute loss value
      NDArray loss = loss_fn(pred, batch.label);
      // Backward propagation on the loss
      ag.backward(loss);
      // Finish Autograd recording
      ag.finish_recording();
      // Update parameters with trainer
      trainer.step();
      NDArray::WaitAll();
      if (++batch_index % 100 == 0) {
        std::cout << "Epoch: " << epoch << " | Batch: " << batch_index
                  << " | Loss: " << loss.item<float>() << std::endl;
      }
    }
  }
}

References
[1] https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/block.py

Implemented in #20131


Report coverage correctly

Coverage reports need to contain output from both shards, but due to a change in circle the other shard was getting stopped before we attempted to collect the reports.

LGTM


Update bx-python to 0.8.1

These are copied to wheels.galaxyproject.org. I tested the cp27mu wheel for Linux x86_64, presumably we'll hear if the macOS wheel has any issues.


Embedding receptive field

@dan and I had some confusion (#22) of what exactly this embedding learnt and the effect of averaging all 64 embeddings into one. So here I'm trying to reason it. Please @weiji14 and @srmsoumya, check me.
TL;DR It's mostly probably safe to use average.

My understanding is that:

The 256x256 image "chip" is split into a 8 x 8 grid of "windows".
While doing the "vanilla MAE" training, randomly, up to 75% of the windows are blacked out, and the loss function aims to recover its content.
This translates that the embedding of the available windows will try to enconde the semantics of the blacked out ones, so the decoder can recreate its content.
When we tweak the vanilla MAE into Clay v0 we are adding the absolute location and time, so this will also add the capacity of the windows to learn about the content based not only on other local windows, but also the actual absolute location.

If the above is correct, it means that the embeddings of each window have learned to predict the content of the surrounding windows, which makes most window embeddings similar.  This reduces the effect when we average all 64 window embeddings into a single chip embedding.
The similarity can be checked on the embeddings example @weiji14 shared. Min cosine similarity is .999

For example:

a chip with a red small house in the middle, a road leading to it, and rest grass.
When MAE removes the red house, windows with the road  (vanilla enconder) and also all available windows (using absolute location from the clay v0 modification) will converge to learn that there is a house in the blanked-out part.
When we average al 64 window embeddings, the semantics of the house will be retained since it's present in several if not all windows.

@brunosan your understanding of how the encoder side of MAE works is spot on.
In our modified architecture, we are making two changes for now:

We are splitting the image spatially and channel-wise.
We are adding time and lat/lon information as learnable embeddings. These embeddings provide additional information to the model about when and where a certain feature appears.

Transformers have a concept called the cls token, which is used to capture a generic vector representation of the input space (EO imagery in our case). This idea is borrowed from the BERT paper and is commonly used in Vision Transformers. We can choose to use the embeddings from the cls token, which represents what the image as a whole looks like. Alternatively, we can take the mean of the remaining vectors, which should capture the same information but be more robust to certain outliers.
For the example you shared, let's say we completely remove the small red building from the image and ask the MAE to recreate the original image. In this case, there is less chance of the MAE adding a building back to the image. Although we have absolute lat/lon and time information available as embeddings, we can expect the network to learn a general understanding of the information rather than very specific features. However, I might be totally wrong here. Training a large model might actually encode such granular features and be able to recreate them. We have to test and try that out to see.


added API for Tip of the day

here i have used websracpping in place of creating a new Database as the data was static.
after that i have used flask.blueprint to map the data.
this is for issue #45

Very nice.
It would be better if you store your scrapping tips permanently as a JSON and then fetch them from that file.
Create another issue and start working on it.


v4 doc not clearly describe the "optional" js files usage

OS:Ubuntu 17.10
Browser:Chrome 60.0
Description:
V4 documention seems has a lot thing to upgrade.When i use the dropdown example code block in the doc.
WhenI copy it to my html file.And click on the dropdown-navbar.It always go to example.com.But didn't show the dropdown menu
code:
`

Navbar

Home (current)

Features

Pricing

          Dropdown link

Action
Another action
Something else here

`

Did you include jQuery, Popper.js, and our Bootstrap JS?

@mdo oops,now i have debug that I didn't include Popper.js.But in the document,It is said "optional".No clearly marked its usage and function.I think the document should rewrite this part of content.

It's written in the overview here : https://getbootstrap.com/docs/4.0/components/dropdowns/#overview

@mdo @Johann-S Maybe that should be a callout?

I’m struggling to get dropdowns to work on my web pages. I’m using npm with Laravel and have this in my resources/assets/js/bootstrap.js file:
window.$ = window.jQuery = require('jquery');

require('popper.js');
require('bootstrap');

But drop-downs still aren’t working—clicks aren’t intercepted and the address bar is updated with the link’s href attribute value (just an ID selector).

To allow Bootstrap to use Popper.js you should have a window.Popper present

@Johann-S So if I add window.Popper = require('popper.js') to my bootstrap.app file, I get the following error in the console when clicking a drop-down link:

Uncaught TypeError: Popper is not a constructor

Because you do not use the last release of Popper.js 1.12.3

@Johann-S I have "popper.js": "^1.12.3" in my package.json file.

that's strange maybe @FezVrasta have an idea why you still have this issue ?

Fixed. Had to do the following in my resources/assets/js/bootstrap.js file:
import Popper from 'popper.js';

window.$ = window.jQuery = require('jquery');
window.Popper = Popper;

require('bootstrap'); // Bootstrap, as in this library

@Johann-S: what should we do with this issue? Close?

yep I'll close that issue


fix(model): Use the correct PURL type for CocoaPods

According to the purl-spec and ossindex, the name of CocoaPods is "CocoaPods" not "Pod".
[1] https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#cocoapods
[2] https://ossindex.sonatype.org/ecosystem/cocoapods

Thanks for your contribution! Please use fix as the Conventional Commit type, like fix(model): Use the correct PURL type for CocoaPods.

Also footers that refer to URLs should be referred to from the body text, and the foot notes should have a colon after the square brackets. See e.g. 4f9609e979ddfe1422e6241a1a1b201f510eb781.

According to the [1] and [2], the name of CocoaPods is "CocoaPods" not "Pod".

Also, please amend your commit and hard-wrap this line after 75 chars.

Good point about the test fixes. Please also fix the occurrences in plugins/package-managers/cocoapods/src/funTest/assets/projects/synthetic/dep-tree-expected-output.yml and simply amend your first commit with all the changes to tests.

Please don't put merge commits into PRs, but rebase instead.

Please don't put merge commits into PRs, but rebase instead.

I've rebased the commit to avoid merge commits.
I apologize for any inconvenience this may cause.

I apologize for any inconvenience this may cause.

No need to apologize. Thanks for addressing all review comments so quickly!

Merging despite the unrelated OsvFunTest failure.


Omiting Scope will return both web and site scope

Added ability to return both web and site scoped ScriptLinks by omiting the Scope parameter. Is this something you would like to include? Small risk here is that before by default it would return Site scoped results only, so it's not fully backwards compatible, but does make more sense this way in my opinion.

Hi @KoenZomers, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@KoenZomers, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


cmd/cgo: using cgo when passing unsafe.Pointer of a slice to C function causes memory leak

What version of Go are you using (go version)?

$ go version
go version go1.14.6 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/workspace/go/src"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/root/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/root/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build148444834=/tmp/go-build -gno-record-gcc-switches"

What did you do?
We found a memory leak when go pass a unsafe.pointer to a C function.
Code:
package main

/*
#include <stdlib.h>

int cli_upload(char *file_data, unsigned char *file_data_buf, void *etag_out)
{
	return 0;
}

*/
import "C"
import (
	"bufio"
	"fmt"
	"net/http"
	_ "net/http/pprof"
	"os"
	"runtime"
	"sync"
	"unsafe"
)

func uploadMemLeak(wg *sync.WaitGroup)  {
	buf := make([]byte, 6)
	etag_out := make([]byte, 256)

	ptr := C.CString("1006")
	defer C.free(unsafe.Pointer(ptr))

	c_err := C.cli_upload(ptr, (*C.uchar)(unsafe.Pointer(&buf)), (unsafe.Pointer(&etag_out[0])))

	fmt.Printf("upload done, err = %d\n", int(c_err))
	wg.Done()
}

func main() {
	fmt.Println(runtime.Version())
	go http.ListenAndServe("<IP_ADDRESS>:6060", nil)

	c := make(chan int)
	reader := bufio.NewReader(os.Stdin)
	_, _ = reader.ReadString('\n')

	waitGourp := sync.WaitGroup{}
	waitGourp.Add(10000)
	for i:=0; i<10000; i++ {
		go uploadMemLeak(&waitGourp)
	}
	waitGourp.Wait()
	fmt.Printf("before gc\n")
	runtime.GC()
	fmt.Printf("end gc\n")
	<-c
}

After running the code, we use pprof tool to checkout the heap memory.
we found memory leak at line 26 and 27.
What did you expect to see?
Memory recycled after C func
What did you see instead?
pprof result:
heap profile: 6: 2304 [7: 2336] @ heap/1048576
6: 2304 [6: 2304] @ 0x440ce1 0x441260 0x465b1f 0x466726 0x43b6f1
#	0x440ce0	runtime.malg+0x30		/root/sdk/go1.14.6/src/runtime/proc.go:3360
#	0x44125f	runtime.newproc1+0x44f		/root/sdk/go1.14.6/src/runtime/proc.go:3416
#	0x465b1e	runtime.newproc.func1+0x4e	/root/sdk/go1.14.6/src/runtime/proc.go:3387
#	0x466725	runtime.systemstack+0x65	/root/sdk/go1.14.6/src/runtime/asm_amd64.s:370
#	0x43b6f0	runtime.mstart+0x0		/root/sdk/go1.14.6/src/runtime/proc.go:1041

0: 0 [1: 32] @ 0x74d573 0x4687c1
#	0x74d572	main.uploadMemLeak+0x52	/root/go/src/test_mem_leak/mem_leak.go:26

# runtime.MemStats
# Alloc = 4539288
# TotalAlloc = 8506472
# Sys = 74006784
# Lookups = 0
# Mallocs = 64304
# Frees = 45619
# HeapAlloc = 4539288
# HeapSys = 63209472
# HeapIdle = 57294848
# HeapInuse = 5914624
# HeapReleased = 55083008
# HeapObjects = 18685
# Stack = 3899392 / 3899392
# MSpan = 207536 / 262144
# MCache = 13888 / 16384
# BuckHashSys = 1444202
# GCSys = 3582216
# OtherSys = 1592974
# NextGC = 9010064
# LastGC =<PHONE_NUMBER>154702867
# PauseNs = [5824027 168789 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
# PauseEnd = [1596792042118860538<PHONE_NUMBER>154702867 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
# NumGC = 2
# NumForcedGC = 1
# GCCPUFraction = 0.00010325341112560225
# DebugGC = false

Can you show us exactly the commands you used to get that pprof result, so that we can reproduce it ourselves?
Maybe unrelated to this issue, but this is almost certainly not what you want:
(*C.uchar)(unsafe.Pointer(&buf))

That's a pointer to the slice header. You want
(*C.uchar)(unsafe.Pointer(&buf[0]))

That's a pointer to the first element of the slice.

Your wg.Done call will run before your deferred call to C.free, so it's not implausible that one buffer was left behind.  See what happens if you change your code to call C.free before wg.Done.

Can you show us exactly the commands you used to get that pprof result, so that we can reproduce it ourselves?
Maybe unrelated to this issue, but this is almost certainly not what you want:
(*C.uchar)(unsafe.Pointer(&buf))

That's a pointer to the slice header. You want
(*C.uchar)(unsafe.Pointer(&buf[0]))

That's a pointer to the first element of the slice.

console input:
go tool pprof http://<IP_ADDRESS>:6060/debug/pprof/heap

open browser. url is http://<IP_ADDRESS>:6060/debug/pprof/heap?debug=1

any sugguestion?

Did you see this comment?  I don't see a reply.

Your wg.Done call will run before your deferred call to C.free, so it's not implausible that one buffer was left behind. See what happens if you change your code to call C.free before wg.Done.

Did you see this comment? I don't see a reply.

Your wg.Done call will run before your deferred call to C.free, so it's not implausible that one buffer was left behind. See what happens if you change your code to call C.free before wg.Done.

sorry
i delete the wg. result also remain the same....

Sorry, I wan't asking you to remove the WaitGroup.  I was saying that your function uploadMemLeak does the wrong thing, because it marks the WaitGroup as done before it frees the C memory.  You need to write your function like this:
func uploadMemLeak(wg *sync.WaitGroup)  {
	buf := make([]byte, 6)
	etag_out := make([]byte, 256)

	ptr := C.CString("1006")

	c_err := C.cli_upload(ptr, (*C.uchar)(unsafe.Pointer(&buf)), (unsafe.Pointer(&etag_out[0])))

	fmt.Printf("upload done, err = %d\n", int(c_err))
	C.free(unsafe.Pointer(ptr))
	wg.Done()
}

What happens if you make that change?

Sorry, I wan't asking you to remove the WaitGroup. I was saying that your function uploadMemLeak does the wrong thing, because it marks the WaitGroup as done before it frees the C memory. You need to write your function like this:
func uploadMemLeak(wg *sync.WaitGroup)  {
	buf := make([]byte, 6)
	etag_out := make([]byte, 256)

	ptr := C.CString("1006")

	c_err := C.cli_upload(ptr, (*C.uchar)(unsafe.Pointer(&buf)), (unsafe.Pointer(&etag_out[0])))

	fmt.Printf("upload done, err = %d\n", int(c_err))
	C.free(unsafe.Pointer(ptr))
	wg.Done()
}

What happens if you make that change?

Thx
I try your code in my env. Sadlly, there is still mem leak happened.
i also tried deleting the waitGourp:
package main

/*
#include <stdlib.h>

int cli_upload(char *file_data, unsigned char *file_data_buf, void *etag_out)
{
	return 0;
}

*/
import "C"
import (
	"bufio"
	"fmt"
	"net/http"
	_ "net/http/pprof"
	"os"
	"runtime"
	"unsafe"
)

func uploadMemLeak()  {
	buf := make([]byte, 6)
	etag_out := make([]byte, 256)

	ptr := C.CString("1006")

	c_err := C.cli_upload(ptr, (*C.uchar)(unsafe.Pointer(&buf)), (unsafe.Pointer(&etag_out[0])))

	fmt.Printf("upload done, err = %d\n", int(c_err))
	C.free(unsafe.Pointer(ptr))
}

func main() {
	fmt.Println(runtime.Version())
	go http.ListenAndServe("<IP_ADDRESS>:6060", nil)

	c := make(chan int)
	reader := bufio.NewReader(os.Stdin)
	_, _ = reader.ReadString('\n')

	for i:=0; i<10000; i++ {
		go uploadMemLeak()
	}

	fmt.Printf("before gc\n")
	runtime.GC()
	fmt.Printf("end gc\n")
	<-c
}

there is still mem leak when i check the pprof heap monitor.
heap profile: 9: 2352 [13: 6992] @ heap/1048576
5: 1920 [5: 1920] @ 0x4469d1 0x446f1d 0x46f3bf 0x46ffe6 0x441771
#	0x4469d0	runtime.malg+0x30		/root/sdk/go1.14.6/src/runtime/proc.go:3360
#	0x446f1c	runtime.newproc1+0x40c		/root/sdk/go1.14.6/src/runtime/proc.go:3416
#	0x46f3be	runtime.newproc.func1+0x4e	/root/sdk/go1.14.6/src/runtime/proc.go:3387
#	0x46ffe5	runtime.systemstack+0x65	/root/sdk/go1.14.6/src/runtime/asm_amd64.s:370
#	0x441770	runtime.mstart+0x0		/root/sdk/go1.14.6/src/runtime/proc.go:1041

1: 208 [1: 208] @ 0x52e455 0x47a895 0x51eaea 0x51f03d 0x51f1fb 0x894bd8 0x472081
#	0x52e454	fmt.glob..func1+0x34		/root/sdk/go1.14.6/src/fmt/print.go:132
#	0x47a894	sync.(*Pool).Get+0xf4		/root/sdk/go1.14.6/src/sync/pool.go:148
#	0x51eae9	fmt.newPrinter+0x39		/root/sdk/go1.14.6/src/fmt/print.go:137
#	0x51f03c	fmt.Fprintf+0x3c		/root/sdk/go1.14.6/src/fmt/print.go:203
#	0x51f1fa	fmt.Printf+0xaa			/root/sdk/go1.14.6/src/fmt/print.go:213
#	0x894bd7	main.uploadMemLeak+0x1f7	/root/go/src/test_mem_leak/mem_leak.go:32

2: 192 [2: 192] @ 0x43f992 0x450d59 0x450b32 0x508e75 0x5093d3 0x50bcca 0x516b71 0x513d99 0x51f0e4 0x51f1fb 0x894bd8 0x472081
#	0x450b31	internal/poll.runtime_Semacquire+0x41	/root/sdk/go1.14.6/src/runtime/sema.go:61
#	0x508e74	internal/poll.(*fdMutex).rwlock+0x144	/root/sdk/go1.14.6/src/internal/poll/fd_mutex.go:154
#	0x5093d2	internal/poll.(*FD).writeLock+0x42	/root/sdk/go1.14.6/src/internal/poll/fd_mutex.go:239
#	0x50bcc9	internal/poll.(*FD).Write+0x59		/root/sdk/go1.14.6/src/internal/poll/fd_unix.go:255
#	0x516b70	os.(*File).write+0x80			/root/sdk/go1.14.6/src/os/file_unix.go:280
#	0x513d98	os.(*File).Write+0xe8			/root/sdk/go1.14.6/src/os/file.go:153
#	0x51f0e3	fmt.Fprintf+0xe3			/root/sdk/go1.14.6/src/fmt/print.go:205
#	0x51f1fa	fmt.Printf+0xaa				/root/sdk/go1.14.6/src/fmt/print.go:213
#	0x894bd7	main.uploadMemLeak+0x1f7		/root/go/src/test_mem_leak/mem_leak.go:32

1: 32 [1: 32] @ 0x51e649 0x525f6b 0x51f090 0x51f1fb 0x894bd8 0x472081
#	0x51e648	fmt.(*buffer).writeString+0xb8	/root/sdk/go1.14.6/src/fmt/print.go:82
#	0x525f6a	fmt.(*pp).doPrintf+0x19a	/root/sdk/go1.14.6/src/fmt/print.go:991
#	0x51f08f	fmt.Fprintf+0x8f		/root/sdk/go1.14.6/src/fmt/print.go:204
#	0x51f1fa	fmt.Printf+0xaa			/root/sdk/go1.14.6/src/fmt/print.go:213
#	0x894bd7	main.uploadMemLeak+0x1f7	/root/go/src/test_mem_leak/mem_leak.go:32

0: 0 [2: 512] @ 0x894a9a 0x472081
#	0x894a99	main.uploadMemLeak+0xb9	/root/go/src/test_mem_leak/mem_leak.go:26

0: 0 [1: 32] @ 0x894a1f 0x472081
#	0x894a1e	main.uploadMemLeak+0x3e	/root/go/src/test_mem_leak/mem_leak.go:25

0: 0 [1: 4096] @ 0x411b7c 0x413bfd 0x418a85 0x496fd1 0x44c0f9 0x44c0b4 0x44c0b4 0x44c0b4 0x43f1e4 0x472081
#	0x496fd0	unicode.init+0x1fe0	/root/sdk/go1.14.6/src/unicode/tables.go:3586
#	0x44c0f8	runtime.doInit+0xb8	/root/sdk/go1.14.6/src/runtime/proc.go:5420
#	0x44c0b3	runtime.doInit+0x73	/root/sdk/go1.14.6/src/runtime/proc.go:5415
#	0x44c0b3	runtime.doInit+0x73	/root/sdk/go1.14.6/src/runtime/proc.go:5415
#	0x44c0b3	runtime.doInit+0x73	/root/sdk/go1.14.6/src/runtime/proc.go:5415
#	0x43f1e3	runtime.main+0x183	/root/sdk/go1.14.6/src/runtime/proc.go:190

# runtime.MemStats
# Alloc = 5083328
# TotalAlloc = 8303912
# Sys = 74465536
# Lookups = 0
# Mallocs = 54574
# Frees = 29704
# HeapAlloc = 5083328
# HeapSys = 66256896
# HeapIdle = 58540032
# HeapInuse = 7716864
# HeapReleased = 49569792
# HeapObjects = 24870
# Stack = 851968 / 851968
# MSpan = 218144 / 294912
# MCache = 13888 / 16384
# BuckHashSys = 1445378
# GCSys = 3520776
# OtherSys = 2079222
# NextGC = 9836096
# LastGC =<PHONE_NUMBER>118630653
# PauseNs = [167826 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
# PauseEnd = [1597903797118630653 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
# NumGC = 1
# NumForcedGC = 0
# GCCPUFraction = 0.002968485099643129
# DebugGC = false

In my code, mem leak happened at line 25 and 26.
I don't know how to fix it.

If you remove the WaitGroup, it is not surprising that you see what appears to be a memory leak.  You are not waiting for all the C memory to be freed before the program exits.
Can you show us the code with the corrected use of WaitGroup, and show us what you see?  Thanks.


Reply button is not removed when deleting a code review comment

Fixes #13764
This adds a conversation-wrapper div around a code review comment thread. When the last comment in the conversation gets deleted, the conversation-wrapper now also gets deleted, removing the reply / (un)resolve buttons and resolved conversation wrapper.
I also extracted the conversation, which was duplicated in box.tmpl (left+right) and section_unified.tmpl, into a separate template.

Codecov Report

Merging #13774 (d98771c) into master (b1cf7f4) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13774      +/-   ##
==========================================
- Coverage   42.23%   42.15%   -0.08%
==========================================
  Files         699      699
  Lines       76959    76959
==========================================
- Hits        32501    32440      -61
- Misses      39091    39179      +88
+ Partials     5367     5340      -27

Impacted Files
Coverage Δ

modules/indexer/stats/db.go
43.47% <0.00%> (-8.70%)
:arrow_down:

modules/notification/ui/ui.go
84.72% <0.00%> (-8.34%)
:arrow_down:

modules/secret/secret.go
66.66% <0.00%> (-7.41%)
:arrow_down:

models/issue_comment.go
45.46% <0.00%> (-7.26%)
:arrow_down:

modules/notification/mail/mail.go
33.33% <0.00%> (-5.75%)
:arrow_down:

modules/charset/charset.go
68.53% <0.00%> (-4.50%)
:arrow_down:

modules/git/commit.go
49.67% <0.00%> (-3.95%)
:arrow_down:

modules/notification/base/null.go
74.28% <0.00%> (-2.86%)
:arrow_down:

modules/notification/notification.go
83.92% <0.00%> (-2.68%)
:arrow_down:

modules/queue/workerpool.go
58.77% <0.00%> (-1.23%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cf7f4...d98771c. Read the comment docs.

@jpraet by the way: if you allow maintainers to edit pulls - we could update pull's too :)

please merge latest changes

@jpraet by the way: if you allow maintainers to edit pulls - we could update pull's too :)

For some reason the "Allow edits from maintainers" checkbox is not showing up for me.

yeah, I think it is available only when creating PR :(

Very nice work, always great to see template deduplications which we are very guilty of 😉

we should backport the fix - but I'm not sure if we should also backport template dedub?

This also has a dependency on the new mergeinto helper which I think is not in 1.13.

@jpraet can you create a backport to 1.13 without the dedublication refactor ?

@6543 ok


fix(plugin-chart-table): Revert "fix(chart table in dashboard): improve screen reading of table (#26453)"

SUMMARY
PR #26453 introduced important accessibility upgrades, but broke displaying table totals in sticky mode. Since the totals being always visible (sticky) is a key feature of the table chart, I think we should revert the accessibility PR and reopen it once the bug is fixed.
CC @ncar285 @eschutho
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before the revert:
https://github.com/apache/superset/assets/15073128/20cf0f7a-0601-4ff5-b172-4cf24ea04e51
After:
https://github.com/apache/superset/assets/15073128/e79efd86-7825-4e33-8239-a81e2bc0a723
TESTING INSTRUCTIONS

Create a table chart with enough rows to enable scrolling
Check "Show totals"
Verify that totals row is sticky

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

🏷 preset:2024.5


wwwroot directroy size is increasing massively

In Azure web app, wwwroot directroy size is increasing massively. As I mentioned in \site\wwwroot\Install\Temp folder which stores the extension backup is carrying very large size. Is it safe to delete the files in temp folder, will it affect in anyway to my live website?
Please respond as soon as possible.
Thank you.

In theory that folder is only used while a module is in the process of installing and it should be fine to delete.
However, I would recommend taking a backup first just in case.

We delete the Temp folder regularly as part of our standard maintenance.
https://github.com/UpendoVentures/Upendo-Dnn-Prompt/wiki/delete-tempfolder


Implement DIDComm support for multiple recipients

In DIDComm, the to property is defined as an array. The property is OPTIONAL and if omitted, the recipient should assume that it is the intended recipient. If multiple recipients are provided, the recipient should assume that it is similar to a CC message.

relevant code: https://github.com/uport-project/veramo/blob/78836a46d3ce71b568acaa98558b64f9c2b98167/packages/did-comm/src/didcomm.ts#L271


sabau/1681-Modal proposal feedback

PageProposal:

Fix votingStartedAgo attribute from voting_start_block to voting_start_time

ModalPropose:

error messages for title and description maxLength
error class enabled in form group if the data is not validated
short form methods for validators

Closes #1681
Contribute to #1690

❤ Thank you!

[ ] Added entries in CHANGELOG.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer

amazing, already the 2nd PR!


WIP: Postgresql driver

There's still a bug in the scan function.

I've checked the update statement in the scan function and it seems to be working fine. The select is returning one row less than the MySQL equivalent. I'll fix this over the next few days.

Also we need to update travis to build all database drivers. Which means we will then need to install and setup MySQL & Postgresql on the travis machine first.


Generation broken when using reference clips longer than 15 sec

Not sure when this started happening, but if you use a reference clip of--for example 30 seconds--the generated result is 10 second gibberish.
For comparison I trimmed the exact same reference clip to 12 second and generated with the exact same text, and it works perfectly.

Hi @cocktailpeanut ~
Thanks for reporting this, mainly because some edge cases not properly considered when clipping long ref_audio input.
Fix in 456456971b1e7a227764aff16c46ab4c1cc97c39
Thanks!


add support for /network/peers

As far as i can see this does not expose the peers of the connected node.

@tulpenhaendler thanks for the feature request, I will add this.


Excel Importer - Save models

Thanks Tolis !
Is there any way to save my import models ? I have 20 defined and do want to recreate (2hours) every time that i create a new database ?
My initial idea was to create a model that import my 20 models. I could do a simple action to achieve this.  This was alsmost working but the file (filedata) is mandatory and we cannot set the file in the mapping.
Any idea how to achieve this ?
BR
ISA

what do you mean save the models? export them? You can use the IO module for this as it can export/import configurable domain trees.

You can export any object domain using the UI and the popup action IO/Export and then in a ModuleUpdater you can import on a new db. Similar to what FeatureCenter does to import the NorthWind db for WorldCreator.
https://github.com/eXpandFramework/eXpand/blob/18.1/Demos/FeatureCenter/FeatureCenter.Module/WorldCreator/NorthWind/WorldCreatorUpdater.cs#L26-L27

Hello,
I will try IO/Export and import. Sorry, I'm a new user and do not know all module yet.
BR
ISA


restarted tests, now work from the command line

closes #152

[ ] Graphics

[x] Image

[x] 2D 512x512 rand image which is pre-saved with cmaps

[x] changing cmap

[x] 2D RGB array, imageio example images
[x] changing vmin vmax

[x] Line

[x] sine, cosine, sinc from examples

[x] slicing colors, data
[x] present followed by auto_scale()

[ ] Scatter
- [ ] present
- [ ] dataslice
- [ ] colorslice
- [ ] cmap
[ ] GridPlot
- [ ] simple example constructing gridplot
[ ] upload screenshot test images and diffs if tests failed: see https://github.com/pygfx/pygfx/blob/main/.github/workflows/ci.yml#L132 and https://github.com/actions/upload-artifact
[ ] make sure nbmake runs notebooks in CI pipeline

added the fancy indexing as mentioned in comments, but I left it commented out for now bc my branch is so far behind master...sent you slack ab it

We kinda don't need the "just build" test.
Can you make a matrix for the test examples for python versions: https://github.com/pygfx/pygfx/blob/main/.github/workflows/ci.yml#L67-L76
and update the checklist

Can you:

[ ] rename all test examples so that they are prepended by the dirname, for example "image_cmap" not just "cmap"
[ ] put an __init__.py for each test module, else it complains
[ ] look again at how pygfx makes image (png) screenshots and try to get those, they are easier to visually inspect that npy files
[ ] use git lfs to store the files, I'll tell you about this later

tests, are mostly done...the examples just need to be updated with the latest changes of fpl/pygfx since we currently are running the tests with a pinned version of pygfx but you have since refactored fpl to match
only thing that I do not understand is why when I push to this feature branch that the CI is not running even though it is a PR to master which should make it run based on CI yml file

yay! CI pipeline...I think

amazing job :D @clewis7


Typing two identical characters causes the first one to display blank

Environment
Win32NT             10.0.19546.0 Microsoft Windows NT 10.0.19546.0
WSL2 / Ubuntu / bash
Windows Terminal Preview version 0.10.761.0
Steps to reproduce
Open a new windows terminal preview tab or window or pane, type .. or // or --
Expected behavior
.. or // or --  are displayed in the terminal
Actual behavior
The first character displays blank  . or  / or  -

@fabienheureux Could you share your profiles.json with us?
My hunch is that you're using a ligature font, and there's a bit of a regression in those recently: #4974

Ho yeah...I am using a ligature font 🤦♂
I am going to use another font for now.
Closing as duplicate.
Thanks !


[$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js

This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestTagPage
New Component IOURequestStepTags
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0c8228cceba8683
Upwork Job ID:<PHONE_NUMBER>276064256
Last Price Increase: 2024-01-17
Automatic offers:

fedirjh | Reviewer | 28119689
dukenv0307 | Contributor | 28119690

Would love to work on this

Hey @fedirjh looks like we have a few proposals here, could you please review?

Bump @fedirjh  -- are you able to review these proposals for us?

PR was CP'd to staging a few hours ago

Summarizing payment on this issue:

Contributor: @dukenv0307 $250, paid via Upwokr
Contributor+: @fedirjh $250, paid via Upwokr

Upwork job is here: https://www.upwork.com/jobs/~01f0c8228cceba8683


ImportError: LoadLibraryEx fails for win32ui.pyd on 64 bit Windows Python

My application compiled without any problems on Nuitka until I imported win32ui as an additional runtime library. The compilation process goes fine, but at runtime, the app errors out and closes immediately, being unable to load the win32ui.pyd file. Below is the stack trace:
C:\Users\vikram\Desktop\ms\nuitka\app.dist\app.exe
Traceback (most recent call last):
  File "C:\Users\vikram\Desktop\ms\nuitka\app.dist\app.py", line 75, in <module>
ImportError: LoadLibraryEx 'C:\Users\vikram\Desktop\ms\nuitka\app.dist\win32ui.pyd' failed

It's kind of strange and unexplained to me, as the win32ui pyd file is definitely in the dist directory, and it is found, but still throws an import error at runtime. I am also using win32gui module, from the same pywin32 package. I have been able to compile + run the app with no problems just using win32gui at runtime, but somehow importing win32ui ends up causing the error. So I am not pulling in any extra dependency packages, just an extra module from the pywin32 package I have already been using to compile + run successfully.
To make things all the stranger, the same compiled app exe + dlls that throws the runtime error on one machine, works just fine on another.. I have tried to compile with a cleared cache, but no luck. If anyone has an idea of what's going on I'd be curious to know.
There was a similar issue here, but for a different library (QtWidgets.pyd), linked:
https://github.com/Nuitka/Nuitka/issues/73
I installed Nuitka using pip, and here is the Nuitka version info:
<IP_ADDRESS>
Python: 2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:30:26) [MSC v.1500 64 bit (AMD64)]
Executable: C:\Python27\python.exe
OS: Windows
Arch: x86_64

So in hunting this down further:
a) PyWin32 requires two DLLs in its SxS configuration. One is the C library, the other is the MFC library of MSVC.
b) Nuitka picks up the one from "pythonwin" which PyWin32 installed.
c) This is the wrong one, it should be the SxS one, although copying it there didn't make it stop complaining, there are likely more DLLs needed.

Interestingly dependencywalker also does report the same error as LoadLibraryEx does, the fact that SxS could not be satisfied, then shows mfc90.dll from pythonwin as used.  That is after moving the SxS up in priority as it probably ought to be. Currently it is last.
I really wonder if this means that Dependency Walker is doing more than it is supposed to do, i.e. actually loads the library for a run time analysis, where I am expecting an offline analysis, that would also make thing slow. But that is a separate issue clearly.
I tried to write code that removes SxS config from DLLs, but that didn't immediately succeed. I will now first check if removing the SxS config with Visual Studio works, as it seems a bit tricky.
Also, there seems to be error dialog suppression code in CPython, and better output in the Windows code that loads pyd files. I am going to integrate those. Who knows, if the SxS error goes away then.
Also I need to check if python.exe actually does load the one SxS variant of the MFC dll that is in question, or if it also fails, but somehow more silent. Maybe the .pyd file has more of an expectation of a relative path to find things. But my understanding is that SxS error is before any code is to be executed, so that should not be possible.

So removing the SxS config of win32ui.pyd with Visual Studio, and it just works. I checked with Anaconda, and there it has SxS config too.
I really wonder why they include a SxS config that is invalid, seems like an upstream problem right there.
Seems CPython ignored the SxS config somehow and gets away with it, loading the .pyd with no issues. I need to check if error suppression is the issue here.

Ok, this won't be easy, it may be a lot easier to remove all SxS configuration from everything, just automatically. I think the MSCRT90.DLL refuses to load without a manifest in the exe file, but apparently not the case for MFC90.DLL, so manifests in the standalone distribution ought to not contribute anything.
It just seemed non trivial to delete resources, there is no tool that does it, it would only replace things, but with a ctypes usage, it should be possible to list all manifest resources, and then to open and modify them, where setting it NULL is going to delete it.
Code for this should be created by imitating this https://github.com/ronreiter/PyRes/blob/master/pyres.py
Not sure how slow the search for SxS config is going to be. And not sure how slow the removal is going to be. It sure wouldn't have to be slow.
Obviously this is only for Python2, for Python3 the MSVC compilers used no longer do this crap.
I am unsure why with 32 bits I am not seeing the issue. Maybe I just happen to have to SxS for it installed and not for 64. It very probably can be ignored that this only happens with certain bits.
Yours,
Kay

I failed to reproduce the issue I had observed with sys.path not containing the .pth files added, so this was probably a mistake of mine.

Hey Kay,
Happy holidays! Thanks for your research, the issue seems like a strange one indeed.. I think it may just be time to upgrade my project to python 3... I also had some other nasty issues on python2 with default ascii encoding instead of utf8 for ex (which would sometimes throw utf8 decode errors if some of the machine specific resources loaded included non ascii chars), and also tkinter thread safety bugs which are resolved in python3, and now this also seems to be a python2 issue.
I hadn't anticipated all these bugs in python2 when I decided to roll with it for this project.. but now I know, haha. Will definitely be using python3 going forward.
Do you know if using python3 with MinGW compiler for nuitka would be ok, or should I be using the msvc compiler with nuitka? Does it make a difference?

Hi Kay,
Ok, I understand that the SxS issue is not really related to python2 vs 3 ; rather its the invalid SxS config used during runtime to load the .pyd's by the older MSVC 9.0, if I understand correctly.
I did just try to run the factory branch compiler on my project, and unfortunately I got the same error ImportError: LoadLibraryEx , I figure there may be additional complications in my environment that are not immediately obvious. I'm not sure how I would report them though since the error message is the same one that I got before.

Hello there,
if you put --python-flag=-v and search for the ImportError in the output, there will be an indication of which module it is that is failing to load. Just scroll up the "cleanup" mess.
Yours,
Kay

Alright, was just able to run it with the extra cl arg, and have pasted the output below:
# installing zipimport hook
import zipimport # builtin
# installed zipimport hook
Setup nuitka compiled module/bytecode/shlib importer.
import os # considering responsibility
import os # claimed responsibility (compiled)
Loading os
import errno # considering responsibility
import errno # denied responsibility
import errno # builtin
import nt # considering responsibility
import nt # denied responsibility
import nt # builtin
import ntpath # considering responsibility
import ntpath # claimed responsibility (compiled)
Loading ntpath
import stat # considering responsibility
import stat # claimed responsibility (compiled)
Loading stat
import genericpath # considering responsibility
import genericpath # claimed responsibility (compiled)
Loading genericpath
import warnings # considering responsibility
import warnings # claimed responsibility (compiled)
Loading warnings
import linecache # considering responsibility
import linecache # claimed responsibility (compiled)
Loading linecache
import types # considering responsibility
import types # claimed responsibility (frozen)
Loading types
import types # frozen
import UserDict # considering responsibility
import UserDict # claimed responsibility (compiled)
Loading UserDict
import _abcoll # considering responsibility
import _abcoll # claimed responsibility (compiled)
Loading _abcoll
import abc # considering responsibility
import abc # claimed responsibility (compiled)
Loading abc
import _weakrefset # considering responsibility
import _weakrefset # claimed responsibility (compiled)
Loading _weakrefset
import _weakref # considering responsibility
import _weakref # denied responsibility
import _weakref # builtin
import copy_reg # considering responsibility
import copy_reg # claimed responsibility (frozen)
Loading copy_reg
import copy_reg # frozen
import site # considering responsibility
import site # claimed responsibility (compiled)
Loading site
import traceback # considering responsibility
import traceback # claimed responsibility (compiled)
Loading traceback
import sys # considering responsibility
import sys # denied responsibility
import sys # previously loaded (sys)
import encodings # considering responsibility
import encodings # claimed responsibility (frozen)
Loading encodings
import encodings # frozen package
import encodings.codecs # considering responsibility
import encodings.codecs # denied responsibility
import codecs # considering responsibility
import codecs # claimed responsibility (frozen)
Loading codecs
import codecs # frozen
import _codecs # considering responsibility
import _codecs # denied responsibility
import _codecs # builtin
import encodings.encodings # considering responsibility
import encodings.encodings # denied responsibility
import encodings.aliases # considering responsibility
import encodings.aliases # claimed responsibility (frozen)
Loading encodings.aliases
import encodings.aliases # frozen
import encodings.__builtin__ # considering responsibility
import encodings.__builtin__ # denied responsibility
import encodings.utf_8 # considering responsibility
import encodings.utf_8 # claimed responsibility (frozen)
Loading encodings.utf_8
import encodings.utf_8 # frozen
import pywintypes # considering responsibility
import pywintypes # claimed responsibility (compiled)
Loading pywintypes
import imp # considering responsibility
import imp # denied responsibility
import imp # builtin
import _win32sysloader # considering responsibility
import _win32sysloader # claimed responsibility (compiled)
Loading _win32sysloader
import _win32sysloader # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\_win32sysloader.pyd");
Loaded _win32sysloader
import pywintypes # dynamically loaded from C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\pywintypes27.dll
Loaded pywintypes
import win32gui # considering responsibility
import win32gui # claimed responsibility (compiled)
Loading win32gui
import win32gui # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32gui.pyd");
Loaded win32gui
import win32ui # considering responsibility
import win32ui # claimed responsibility (compiled)
Loading win32ui
import win32ui # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32ui.pyd");
Traceback (most recent call last):
  File "C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\automsm.py", line 74, in <module>
ImportError: LoadLibraryEx 'C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32ui.pyd' failed

I think the output shows that you are not using the factory version. I added the tracing of the DLL load error message, which is missing to this mode.
What I have done for this issue, is to create a tool that scans for all SxS packages, and make it run on my CPython 2.7 and Anaconda2 installation, which found 2 more modules with the issue, one of which is in the win32 domain.
I am closing the issue assuming a mistake of yours in trying it out as I could well reproduce it and see it fixed, although now that I think of it, "os.path.normcase()" should be applied to be absolutely sure, I will add that too.
Yours,
Kay

I believe I was using the factory branch, as I cloned a fresh copy from the factory link. I pulled the latest changes from the remote factory branch, and now had my local factory branch at commit: e0b807cae6eb48f53cf782f71f325d9fefad76d7 from 12/28
Still somehow got a similar output as before, pasted the relevant portion:
import encodings.utf_8 # frozen
import pywintypes # considering responsibility
import pywintypes # claimed responsibility (compiled)
Loading pywintypes
import imp # considering responsibility
import imp # denied responsibility
import imp # builtin
import _win32sysloader # considering responsibility
import _win32sysloader # claimed responsibility (compiled)
Loading _win32sysloader
import _win32sysloader # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\_win32sysloader.pyd");
Loaded _win32sysloader
import pywintypes # dynamically loaded from C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\pywintypes27.dll
Loaded pywintypes
import win32gui # considering responsibility
import win32gui # claimed responsibility (compiled)
Loading win32gui
import win32gui # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32gui.pyd");
Loaded win32gui
import win32ui # considering responsibility
import win32ui # claimed responsibility (compiled)
Loading win32ui
import win32ui # LoadLibraryEx("C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32ui.pyd");
Traceback (most recent call last):
  File "C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\automsm.py", line 74, in <module>
ImportError: LoadLibraryEx 'C:\Users\vikram\Desktop\ms\nuitka\automsm.dist\win32ui.pyd' failed

Not sure why that is.. I might be missing something else.


UITest fails due to slow network

https://github.com/sparta-science/connect/actions/runs/172560174
Network took longer then 5 seconds in testFailedInstallation:

LoginTest.swift#L73
XCTAssertEqual failed: ("XCTWaiterResult") is not equal to ("XCTWaiterResult") - vernal_falls.tar.gz should be installed

fixed by: https://github.com/sparta-science/connect/commit/b5e18667b17a92e0509aa88700967eca2297ebac


Add support for shortening GitHub issues links

Relates to #411

btw sorry @rnystrom, couple prs to review now 😅
Probably want to do a big merge before v1.11

@Sherlouk wanna add any unit tests for this?

Sure, on it now!

Should be all good!


Update README.md

Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[ ] If you have multiple commits please combine them into one commit by squashing them.

Hi James - did you just add a trailing space or am I missing something?
John
On Thu, Dec 26, 2019 at 6:09 PM James Hill<EMAIL_ADDRESS>wrote:

Please make sure these boxes are checked before submitting your pull
request - thanks!

Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to
make sure you didn't break anything (with an emulator running or phone
connected)
If you have multiple commits please combine them into one commit by
squashing them.

You can view, comment on, or merge this pull request online at:
https://github.com/sky-map-team/stardroid/pull/319
Commit Summary

Update README.md

File Changes

M README.md
https://github.com/sky-map-team/stardroid/pull/319/files#diff-0 (2)

Patch Links:

https://github.com/sky-map-team/stardroid/pull/319.patch
https://github.com/sky-map-team/stardroid/pull/319.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sky-map-team/stardroid/pull/319?email_source=notifications&email_token=AD5LWC4VO4QNR3DXCOP6FYTQ2U2SVA5CNFSM4J7RSYQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICYZX3Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5LWCZNVJN6BL5W7TDPNFLQ2U2SVANCNFSM4J7RSYQQ
.

--
Google Pittsburgh is hiring again!


DropdownMenu can not be center aligned when using expandedInsets

Steps to reproduce

Put a dropdown in a Center widget and put that inside an Expanded widget
Use expandedInsets

Expected results
The dropdown should be centered
Actual results
The dropdown sticks to the top
Code sample
Code sample
Row(
  mainAxisAlignment: MainAxisAlignment.center,
  children: <Widget>[
    Expanded(
      child: Center(
        child: DropdownMenu<int>(
          inputDecorationTheme: const InputDecorationTheme(
            helperMaxLines: 5,
            border: OutlineInputBorder()
          ),
          expandedInsets: const EdgeInsets.symmetric(horizontal: 40),
          helperText: "Some long helper text.",
          initialSelection: 1,
          label: const Text("A number"),
          onSelected: (final int? num) {
          },
          dropdownMenuEntries:
            [1, 2, 3].map<DropdownMenuEntry<int>>(
              (final int num) {
                return DropdownMenuEntry<int>(
                  value: num,
                  label: "$num"
                );
              }
            ).toList(),
        ),
      ),
    ),
    Expanded(
      child: Center(
        child: DropdownMenu<double>(
          inputDecorationTheme: const InputDecorationTheme(
            helperMaxLines: 5,
            border: OutlineInputBorder()
          ),
          expandedInsets: const EdgeInsets.symmetric(horizontal: 40),
          helperText: "Long text.",
          initialSelection: 1.0,
          label: const Text("Another"),
          onSelected: (final double? num) {
          },
          dropdownMenuEntries:
            [1.0, 2.0, 3.0].map<DropdownMenuEntry<double>>(
              (final double num) {
                return DropdownMenuEntry<double>(
                  value: num,
                  label: "$num"
                );
              }
            ).toList(),
        ),
      ),
    ),
  ]
),

https://github.com/flutter/flutter/blob/aef2758716b806ec2d567b519dba0bf0643d9031/packages/flutter/lib/src/material/dropdown_menu.dart#L951-L970

The second code block above seems to be the issue.
Screenshots or Video

Dropdowns stuck to the top

Remove `expandedInsets` and it comes down to the center but we lose the full width

Logs
NA
Flutter Doctor output
Doctor output
% flutter doctor -v
[✓] Flutter (Channel stable, 3.24.1, on macOS 12.7.6 21H1320 darwin-x64, locale en-GB)
    • Flutter version 3.24.1 on channel stable at /Users/<user>/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5874a72aa4 (5 weeks ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/<user>/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/to/macos-android-setup for more details.

[!] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    ! Flutter recommends a minimum Xcode version of 15.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.15.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
    Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2023.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (2 available)
    • iPhone 14 Pro Max (mobile) • 1C6417FB-1C3E-4088-B3BD-8BD3E816ADD5 • ios        •
      com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64 • macOS 12.7.6 21H1320 darwin-x64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 3 categories.

Reproducible using the code sample provided above.

complete code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(

        child: Row(mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[
          Expanded(
            child: Center(
              child: DropdownMenu<int>(
                inputDecorationTheme: const InputDecorationTheme(helperMaxLines: 5, border: OutlineInputBorder()),
                expandedInsets: const EdgeInsets.symmetric(horizontal: 40),
                helperText: "Some long helper text.",
                initialSelection: 1,
                label: const Text("A number"),
                onSelected: (final int? num) {},
                dropdownMenuEntries: [1, 2, 3].map<DropdownMenuEntry<int>>((final int num) {
                  return DropdownMenuEntry<int>(value: num, label: "$num");
                }).toList(),
              ),
            ),
          ),
          Expanded(
            child: Center(
              child: DropdownMenu<double>(
                inputDecorationTheme: const InputDecorationTheme(helperMaxLines: 5, border: OutlineInputBorder()),
                // expandedInsets: const EdgeInsets.symmetric(horizontal: 40),
                helperText: "Long text.",
                initialSelection: 1.0,
                label: const Text("Another"),
                onSelected: (final double? num) {},
                dropdownMenuEntries: [1.0, 2.0, 3.0].map<DropdownMenuEntry<double>>((final double num) {
                  return DropdownMenuEntry<double>(value: num, label: "$num");
                }).toList(),
              ),
            ),
          ),
        ]),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.0 24A335 darwin-arm64, locale en-US)
    • Flutter version 3.24.3 on channel stable at /Users/deanli/dev/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (12 days ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[!] Flutter (Channel master, 3.26.0-1.0.pre.183, on macOS 15.0 24A335 darwin-arm64, locale en-US)
    • Flutter version 3.26.0-1.0.pre.183 on channel master at /Users/deanli/dev/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c8ca4cbd6 (5 hours ago), 2024-09-23 22:57:25 -0400
    • Engine revision 4013dc28a4
    • Dart version 3.6.0 (build 3.6.0-270.0.dev)
    • DevTools version 2.40.0-dev.1


Make sure array_map does not create warnings

Re: #2828
This has already been fixed in 3.0.x.

I'll use 4d722a0 which fixes the issue a 2 places. But thanks @michael-e


Strange behavior when linking scatter.selected with traitlets.

This is perhaps a special and unconcerning case, but inside a class that inherits from ipywidgets.HBox I tried linking the selected points on Scatter mark to a list of selected points (in a separate, model class) using traitlets, and encountered strange behavior. I essentially wrote:
traitlets.dlink(
    source=(self.model, 'selected_list'),
    target=(self.scatter, 'selected')
)

When the model gets a new list of selected points, the selected points on the scatter do indeed update accordingly. However, it turns out that the scatter.selected property does not update, which caused bugs for me down the line.
I see that the selected property is not listed under scatter.trait_names, so perhaps this is not a bug at all and I just need to find a different way. But it seemed strange that figure did appear to behave the way I wanted it to-- highlighting the appropriate points-- without actually updating the property, so I thought I'd make a note here.

Hmm, even when I abandon the traitlets link and set the scatter.selected property programmatically from a callback function, I'm still having trouble getting the property to stick.
Now I'm doing something like:
self.model.observe(self._callback, names='selected_list')

def _callback(self, change):
    new_idx_list = change.new
    self.scatter.selected = new_idx_list

Once again, the scatter plot updates to reflect the desired list, but the property does not stick-- when I call self.scatter.selected later, I get a different value than what is shown in the plot.
Is the behavior you would expect? Perhaps I need to use hold_sync() or hold_trait_notifications() somewhere?

Ah, it looks like simply not setting interactions = {'click': 'select'} as a property of the scatter mark fixes my issues-- I can still attach on_element_click() to a callback function, and set the selected points the way I want to.
I'll leave this issue open in case any of the behavior I mentioned sounds strange. Thanks!!

@dustinmichels This is very strange behavior. Thanks for reporting this.
When you say self.scatter.selected does not stick, what is it set to? If you can share a small snippet which reproduces this behavior, that will be very useful. Unless you explicitly click on the chart or on the figure, having {'click': 'select'} should not affect the selected attribute.

I'm not sure there's actually I problem. I was trying to override the default behavior of {'click': 'select'}, and I could only get the right behavior when I disabled that interaction.
Anyway, here's a sample notebook:
http://nbviewer.jupyter.org/github/dustinmichels/bqplot/blob/master/examples/Scatter Issue.ipynb
(Sorry I couldn't get the plots embedded in nbviewer!)

@dustinmichels So after discussion with @jasongrout we agreed that this is a limitation of the current syncing protocol. The behavior is hard to predict if the same property is being set both from the python side and Javascript side and it is resulting in a race condition. By removing {"click": "select"} from the interactions attribute, we are forcing the selected property to be set only from the Python side. Hope this answers your question.

Yes, it makes sense! Thanks for taking a look!!


Small docs fix

Current coverage is 73.11% (diff: 100%)

Merging #42 into master will not change coverage

@@             master        #42   diff @@
==========================================
  Files            25         25
  Lines          2604       2604
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1904       1904
  Misses          700        700
  Partials          0          0

Powered by Codecov. Last update c66e06f...9f1da12

Ah, thx!


Unexpected scroll behaviour when opening steps

There seems to be some unpredictable scrolling behaviour when opening steps. On this question, for example,. https://numbas.mathcentre.ac.uk/question/153089/vector-mcq/preview/ it seems that:

if you're above the steps in part a), with the question prompt and header fully in view, the step opens as expected, with no change in your position on the screen
if you've already scrolled past the heading for a),  then the window jumps down to the start of b)

Is it possible that the window is set to move to the next visible heading, or something like that, when the steps open, so goes to b) because the heading for a) has left the window?
Let me know if you want a video, it's easier to see than write about!

Which browser did you see this in? It doesn't seem to happen in Firefox. A video would be helpful.


Add an option to create/edit applications, also on SKRs

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

Resolves https://github.com/kyma-project/busola/issues/712

/retest


Some flags don't have equivalent function

Some ffmpeg command-line flags, like -xerror, and -abort_on empty_output and -y (to overwrite files without asking), don't seem to have any equivalent function in node-fluent-ffmpeg. Is it still possible to use these flags from node?

Use outputOptions(). And read the documentation, please :)


Missing hover tooltip on the "Image Diffs"

Describe the bug
When hovering over the diff image, the x-y coordinates and the rgb values of the pixel in the  images being compared are not updated.
To Reproduce
Steps to reproduce the behavior:

Click on the Visualizations tab
Click on the Image Diff button
Hover over a diff image
See error - x-y and rgb values are "stuck"

Expected behavior
x-y coordinates and rgb values of the images being compared should change and consist of correct values
Desktop

OS: Windows 10
Browser: chrome

Hi Ela,
Thanks for noticing it!
I fixed the issue and will soon push/merge the patch.


Extract service from CompletedFileReviewJob

To follow the pattern of a job class having a corresponding service
object.

Thanks for reviewing @gylaz


About Course Collapse

ISSUE #298

Describe the changes you've made
Add expanded and collapse list and show a summary of about course.
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review
Preview: https://deploy-preview-309--edu-client.netlify.app/mycourses/:coursename
<!-- Please add deployed link to here text >

Please review, @Abhishek-kumar09 @vasudevsinghal


SoC is at 0% in ABRP

Since upgrade to 2.0 via docker my SoC on ABRP website and app is always at 0%.
Log output shows no obvious problem:
2023-12-13 12:55:05: [INFO] Data object successfully sent: {'utc':<PHONE_NUMBER>, 'soc': 0, 'power': 0, 'speed': 0, 'lat': XXX, 'lon': XXX, 'elevation': 0, 'is_charging': False, 'is_dcfc': False, 'is_parked': True, 'est_battery_range': 130.55, 'ideal_battery_range': 136.73, 'ext_temp': 6.0, 'model': '', 'trim_badging': '', 'car_model': 'tesla:my:22:mylr_22:perf:heatpump', 'tlm_type': 'api', 'voltage': 0, 'current': 0, 'heading': 330}

Hello @Str1atum,
First of, kinda unrelated to your issue, did you remove the "odometer" key of the object above?
Second of all, there's indeed something wrong but that's not nearly enough information to help me debug this.

Could you please check that TeslaMate's MQTT is working properly and sending the "right" value for the SoC? (see an example of it here; teslamate/cars/1/usable_battery_level is the topic you are looking for; it should not be 0.
Can you revert to the previous release (using "fetzu/teslamate-abrp:1.4.0" as a Docker image) and tell me if the SoC is being reported properly?

I just tried a reboot of my server and now it's working again - sorry for the bothering

No worries, I’m glad it works ;).


java backend requires jdk/tools.jar

a plain beaker fails with
ERROR: java.lang.IllegalStateException: Failed to find the system Java compiler. Check that your class path includes tools.jar

the proper solution is to distribute beaker with jdk instead of jre.
in the meantime the workaround is for users to install the jdk and then set JAVA_HOME pointing to it in their ~/.bash_profile

the JDK can't be downloaded as tar.gz like the JRE.  Instead I just did this:
cp /Library/Java/JavaVirtualMachines/jdk1.7.0_55.jdk/Contents/Home/lib/tools.jar ./launcher/mac/jre1.7.0_60.jre/Contents/Home/lib


Use new Function-less access to this for debugObjectHost

Fixes a comment on the original PR #9580.
Originally it was just debugObjectHost = this as any, but this breaks --noImplicitThis. So #9580 changed it to (new Function("return this"))(). Now it's (function () { return this })().

@vladima can you take a look?


➕➕ Adding EmojiOne emojis.

Hey @mrowa44 @GrenderG :wave:
This PR adds the aliases for the EmojiOne (JoyPixels) emojis. I verified that the JSON file containing the aliases is MIT licensed as mentioned here.
I also noticed some duplicate aliases. I removed those and preserved only the shortest associated emoji code.
Thanks for reviewing :smile:

Seems like some of them are not being shown, for example :couple_mm:, man_genie and others. But it adds a lot of new ones that are indeed working, I'd merge @mrowa44.


Hardware wallet support for Ledger

This PR implements issue #41
Using a hardware wallet
Currently only Ledger devices are supported when creating a hardware wallet. Use a Ledger Nano S/S+ to sideload the Zenon Ledger Embedded App. See How to sideload the Zenon Ledger Embedded App for Ledger Nano S/S+.
The onboarding experience has been made in such a way other devices can be easily added in the future.
A hardware device with Zenon app is necessary when creating and initializing a hardware wallet. The hardware device is not necessary to unlock the wallet once it is initialized. Only when the wallet cache is reset, will the hardware device be necessary again to unlock and initialize the wallet. An error message will be presented to the user when this is the case.
In the special case of using a different hardware device than the one the wallet was initially initialized on, signing will eventually fail. The address of the hardware device is not asserted with the cached address when unlocking the wallet, because this would require access to the wallet. Resetting the cache and reinitializing the wallet should be enough to start using the new hardware device.
The hardware wallet uses Syrius's notification mechanism to notify the user when confirmation is required.
Generating new addresses on a hardware wallet requires confirmation. When multiple addresses are generated at once, multiple confirmations are required. The process of generating new addresses stops whenever a new address is rejected and a widget error is dislayed.
Signing an arbitrary message or file on a hardware wallet is enabled but fails if the underlying wallet does not implement it. An unsupported error message will then be displayed.
Changes

Hardware wallet onboarding is enabled for creating and initializing a hardware wallet.
The global kWallet variable has been replaced with the kWalletFile variable.
A reference to the wallet is now obtained by opening and closing it with the WalletFile class. Access to the wallet is locked until the wallet is closed to ensure mutual exclusion. This means not only sending and receiving is protected with a lock, but all access to the wallet.
All occurrences of blockSigningKey, keyPair or keyFile variables are renamed to the more generic wallet, walletAccount or walletFile terms.
The Zenon.defaultKeyPair property is not used anymore, instead the address is specified as an argument to the send method. Allowing the Wallet to be opened only when it is necessary.
Decrypting or opening a wallet are now separate actions. This allows to change the wallet password without necessarily opening it.
Signing an arbitrary message or file only uses the public key when it is needed and not every time the Settings widget is build.
The HtlcSwapsService now uses the wallet password as cipher instead of the wallet private key. Migration code ensures the migration of wallets created by Syrius v0.1.0.
Dump mnemonic and backup buttons are disabled when using a hardware wallet.
Added new notification type confirm for displaying confirmation notifications.
Added wallet type to the about card.
Syrius version has been increased to v0.2.0; otherwise p2p migration code does not work.
The walletType is stored as metadata in the encrypted file and used when loading in order to differentiate between different wallet types.

@vilkris4 I've tested the ledger device on macOS with @KingGorrin.  We've tested transfers and P2P swaps.  We did the P2P swap on mainnet without issue.  I'm going to review the PR and approve it today unless you or anyone else disagrees.


Dead link for vnet validation

The url https://raw.githubusercontent.com/Microsoft/sql-server-samples/master/samples/manage/azure-sql-db-managed-instance/delegate-subnet on this par of the documentation is returning 404.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6b036445-58f3-bd8e-103e-17c60041a545
Version Independent ID: fa53a263-a15a-2449-207a-51b59afbec4c
Content: Configure an existing virtual network - Azure SQL Managed Instance
Content Source: articles/azure-sql/managed-instance/vnet-existing-add-subnet.md
Service: sql-managed-instance
Sub-service: operations
GitHub Login: @srdan-bozovic-msft
Microsoft Alias: srbozovi

@Diastro We are checking this and will get back to you.

@Diastro  We have checked and link is not working. We will work with our author to get correct link.
@srdan-bozovic-msft Please check the link and correct with the correct one.


Complete location_items.csv using smaller official guide data

The current version of location_items.csv is from Kiranico, which I believe used the (smaller) official guide. However, they didn't list the node type and node drop table (common/rare aka shiny). If anyone has that guide and is willing to add the information here, I'd certainly love the help.
The idea would be to add a node_type and node_rarity column. node_type would be ore, bones, redore, etc. node_rarity would be common or shiny.
Also, apparently some maps have "merged areas" for the spawning of certain nodes. If that's true, updating the specific entries to refer to the merged sum would be helpful. I hear this happens in Elder's Recess 5 and 6, so an area 5 or 6 would be the area of that node.

Hello @gatheringhallstudios ,
I am a Graphic Designer looking to collaborate in projects like this!
I'd like to provide a logo that suits this project!
let me know if you are interested! Thanks!!!

Thank you for the offer, but unfortunately this is a data collection project, and we're mostly solid on images (outside of images that need to be manually collected...not designed...).
Good luck though.


Update site-wide settings

Fixes #11

Codecov Report

Merging #30 (3ecc5d6) into master (76a79a4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a79a4...3ecc5d6. Read the comment docs.


Correctly reset peer state on host/unhost

When a dat toggles the hosting state, we need to reset the replication feeds. Currently that's behind done with a 3 second timer, because some kind of state needs to get reset, and we don't know what event to watch for yet.
Obviously that hack cant stay.

Done


Enable native spellcheck

Spellcheck in editor is disabled:
https://github.com/P2Pvalue/swellrt/blame/master/src/org/waveprotocol/wave/client/editor/EditorImpl.java#L1748
May we try to turn it on? This feature was requested by one user of Pear2Pear https://github.com/P2Pvalue/pear2pear/issues/109

Is this still an active need/request?

As for Teem (former Pear2Pear) is a non prioritized feature (maybe we will not even need it).
I do not know how important is this feature for other SwellRT projects.

@atfornes I don't understand your answer. Of course we can live without this, but the spellcheck working in Teem pads would be a nice thing to have IMO. I don't think the user that requested that feature has changed her mind
I am still wondering the rationale behind SwellRT disabling the spellchecker

@atd, as far as I know, we have not prioritized this feature in our Sprint meetings neither we have detected this as an important need of our users.
To the question, is this an active need? I reply that form teem is not currently active or a need.
However I let the open question on how is this important to other SwellRT projects. Personally I believe it is important to be activated in that broader context, and even that it will be good for Teem.
Please let me know if you think otherwise.

@atfornes we did receive comments from our users missing the spellchecker. Still wondering why we have to remove it

@atd, I was not aware of this comments despite the original one. I did not say we have to remove it, just that is not currently prioritized, and that maybe we will not need it (in the sense of user needs of Lean approach we are following).
With the information you are sharing, it is clear that the priority of this issue is not as low a I commented, thanks for bringing it here.
The resolution of this issue will benefit Teem and other SwellRT project. I believe that it is an important feature of SwellRT.


Fix docs generation util

Includes utils into the package back

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.961%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
73

Relevant Lines:
124

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.961%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
73

Relevant Lines:
124

💛  - Coveralls


Azure Load testing Pipeline error (standalone mode)

When I try to run the azure load testing pipeline, it succeeds provisioning the azure load test service but fails with the following error int create test step.

Hi @rishabhsaha, thanks for reporting this issue. I'll take a look.


Update copyright year to 2024

I just pushed the same commit across the board, without realizing your PR, my bad. Thanks for the update.


fix #1481, fix storm performance regression

+1

The changes include

replaces storm's DefaultKryoFactory with gearpump's StormKryoFactory such that we have a chance to register GearpumpTuple in Kryo. Note that we only register GearpumpTuple when the storm configuration topology.fall.back.on.java.serialization is false, when we are sure values in GearpumpTuple could be serialized with Kryo. Otherwise, GearpumpTuple will be serialized with Java serialization which has bad performance.
initializes grouper beforehand rather than on each emit
removes componentId from GearpumpTuple since it can be retrieved from TopologyContext
adds application.conf so storm applications use StormKryoPool by default.

The performance is on par with our previous tests where Storm over Gearpump has a throughput of 4,500,000 messages/s on a three-node cluster running SOL benchmark (36 producers, 36 processors).

+1


Add support for Adafruit Feather LoRa 32u4

Add support for the Adafruit Feather LoRa 32u4 board.

What is the latest status of this?

@lnlp I would be happy to contribute to this enhancement.
Contact Me<EMAIL_ADDRESS>


Export only modules names

Currently we have something like this:
// app/components/something/something.js
let someModule = angular.module('something.module', [depA, depB]);

export default someModule;

// app/app.js
import someModule from './something/something';

angular.module('app', [someModule.name]);

I have two questions:

why we are using let keyword? Module instance should be immutable (const keyword), isn't it?
why we are exporting module but not only it's name?

// app/components/something/something.js
export default angular
    .module('app.something', [depA, depB])
    .name;

// app/app.js
import something from './something/something';

angular.module('app', [something]);

@gdi2290 what do you think?

SGTM
Scott has been meaning to update the repo. What do you think @Hendrixer

1


use-marketplace-content-in-studio-pro

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: use-marketplace-content-in-studio-pro
Document link: app-store-content.md
My Issue/Suggestion
Please add paragraph on how updated Marketplace content is presented. Pushed, pulled or else?

Hi @RobinH81 thanks for your feedback. I don't quite understand what you'd like to know here, though. Are you asking about how content appears in Marketplace in Studio Pro?

Wow! New SLA? My comment back from Sept '22 answered two weeks ago and now closed as completed? I am into different kind of work at the moment (at the same company). Mendix isn't part of my work now unfortunately, so a two weeks term seems te me as a little inappropriate, but hey, SLA's stil have a higher priority than customer satisfaction right? Not personal! Here at our company exactly the same bllsht prio unfortunately.

Hi @RobinH81 thank you for your comments. I can reopen this feedback item if you can address my request for more info above:

I don't quite understand what you'd like to know here, though. Are you asking about how content appears in Marketplace in Studio Pro?


Check in with @alecps re updating config and redeploying ODIS combiner (see two steps below)

Reminder to sync on next steps in ODIS signer rotation and combiner deployment.
Ref:

https://github.com/celo-org/celo-monorepo/issues/9314

Closing this ticket because @alecps responded to the ODIS signers on Discord.