New terminal lines rendering cuts off bottom of long characters

The new terminal rendering cuts off the bottom part of "long" characters, such as g, j and y.
1.17.0:

1.17.1:

VSCode Version: 1.17.0

Version 1.17.0
Commit be377c0faf7574a59f84940f593a6849f12e4de7
Date 2017-10-04T23:33:45.303Z
Shell 1.7.7
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

OS Version: Ubuntu Trusty 14.04

Steps to Reproduce:

Open the Terminal
Start typing git checkout -b feature/object

Reproduces without extensions: Yes

Same problem here.

similar to #35794 but on fedora it cuts off the top part

Chops the top off on Fedora 26.

Same problem here.

I just changed the "terminal.integrated.fontFamily" value. My issue was that underscores were not displayed using DejaVu Sans Mono. With other fonts they are displaying, not sure if it would help to fix your problem guys, but sure is worth to give it a try.

The variable width font that I'm partial to now looks like this.

@imgss see https://github.com/Microsoft/vscode/issues/35660
@jashworth see https://github.com/Microsoft/vscode/issues/35681

@viktorku what's in your settings.json file?

In 1.17.1 the rendering changed (it's somewhat blurrier and smaller fontsize) but the bug prevails:

@Tyriar This also happens for a fresh code instance (without settings.json in the project's root .vscode). My User Settings are like this:
{
    "workbench.sideBar.location": "left",
    "files.exclude": {
        "**/.git*": false,
        "**/.svn": true,
        "**/.hg": true,
        "**/.DS_Store": true,
        "**/.tags*": true,
	"**/.pyc": true,
        ".catkin_tools/**/packages": true,
        "build": true,
        "devel": true,
        "logs": true,
        "src/external": true,
        "**/CMakeLists.txt.user": true,
        "**/__pycache__": true
    },

    "editor.fontSize": 12,
    "editor.tabSize": 2,
    "editor.wordWrap": "on",
    "editor.rulers": [
        100
    ],

    "[python]": {
        "editor.tabSize": 4
    },

    "files.trimTrailingWhitespace": true,
    "diffEditor.ignoreTrimWhitespace": false,

    "workbench.editor.enablePreviewFromQuickOpen": false,

    "window.zoomLevel": 0,

    "clang-format.executable": "/usr/bin/clang-format-3.8",
    "clang-format.style": "Google",
    "clang-format.language.javascript.enable": false,

    "prettier.printWidth": 100,
    "prettier.singleQuote": true,
    "prettier.bracketSpacing": true,
    "workbench.colorTheme": "One Dark Pro",

    "editor.multiCursorModifier": "alt",
    "git.ignoreLegacyWarning": true,
    "workbench.startupEditor": "newUntitledFile",

    "eslint.nodePath": "/home/viktor/.nvm/versions/node/v7.4.0/bin/node",

    "python.linting.pylintArgs": [
        "--load-plugins pylint-django"
    ]
}

Similar issue. Image here: https://github.com/Microsoft/vscode/issues/36322#issuecomment-337618385

Using the insiders build I believe you can workaround this currently by setting:
"terminal.integrated.lineHeight": 1.1

@Tyriar
This workaround doesn't work for me in latest insiders.
Running Ubuntu in virtualbox

VSCode Version: Code - Insiders 1.18.0-insider (81cca6cc606eeca3443998025bff3893fcfe3ad5, 2017-10-31T06:24:27.011Z)
OS Version: Linux x64 4.10.0-37-generic

yeah, fixed on fedora26 with the terminal.integrated.fontSize option

Ubuntu 17.10 here and terminal.integrated.fontSize  solved it. Thanks, everyone.

Added "window.zoomLevel": -0.001 for workaround on fedora26 VSCode 18.1

Thanks @suonto , it worked on my Ubuntu 16.04 VSCode 1.18.1 as well.

Confirmed @suonto's fix works on Debian Stretch VSCode 18.1. Also, it looks much better with "terminal.integrated.lineHeight": 1.2

Oops , This issue also came into stable build
Version 1.18.1
Commit 929bacba01ef658b873545e26034d1a8067445e9

Yup. This is broken for me:
[mattvh@hitomi] ~ % cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=17.04
DISTRIB_CODENAME=zesty
DISTRIB_DESCRIPTION="Ubuntu 17.04"
[mattvh@hitomi] ~ % code --version
1.18.1
929bacba01ef658b873545e26034d1a8067445e9

Can confirm that adjusting terminal font size works as a workaround.

I came from #38133. Underscores are missing in my terminal too.
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=17.10
DISTRIB_CODENAME=artful
DISTRIB_DESCRIPTION="Ubuntu 17.10"
$ code --version
1.18.1
929bacba01ef658b873545e26034d1a8067445e9

Setting "terminal.integrated.fontSize" to 13 or 15 (default for me was 14) resolved the problem.

Upstream issue: https://github.com/xtermjs/xterm.js/issues/1138

In the Visual Code Settings is:
"terminal.integrated.fontFamily" : ""
"terminal.integrated.fontSize" : "14"
// Controls the font family.
"editor.fontFamily": "'Droid Sans Mono', 'monospace', monospace, 'Droid Sans Fallback'",
// Controls the font size in pixels.
"editor.fontSize": 14,
If I use the default settings, the character _ is not displayed.
But, If I change the value of "terminal.integrated.fontSize" for a value diferent of 14, the character is displayed.
And, I noticed, other detail, if I not change "terminal.integrated.fontSize" but
"terminal.integrated.fontFamily" for other font, independently of value in "terminal.integrated.fontSize", is charactere _ is displayed.

In Ubuntu 16.04, changing the terminal font family to a different Ubuntu font fixed the problem.
"terminal.integrated.fontFamily": "Ubuntu mono".

using "terminal.integrated.fontSize": 13 or "terminal.integrated.fontSize": 15 did the trick for me. only fontSize: 14 shows the problem. quite curious.

Can confirm what @sombriks says.

also "terminal.integrated.fontFamily": "Courier" instead of font size solved the problem here.

If I use the default settings, the character _ is not displayed.
But, If I change the value of "terminal.integrated.fontSize" for a value diferent of 14, the character is displayed.
And, I noticed, other detail, if I not change "terminal.integrated.fontSize" but
"terminal.integrated.fontFamily" for other font, independently of value in "terminal.integrated.fontSize", is charactere _ is displayed.

There are two ways to fix this in Ubuntu (I tested this on 16.04 and 17.10):

Put this into your settings:
 "window.zoomLevel": -0.001,

That seems to fix the problem with the original vscode font.

Put this into your settings:
 "terminal.integrated.fontSize": 16,
 "terminal.integrated.fontFamily": "Ubuntu mono",

This will use the same font as in the gnome-terminal in Ubuntu, and the size will be the same as in the original vscode font, so if you are already used to the font size in the vscode terminal, it doesn't change. If you want the same size as in the Ubuntu gnome-terminal window, use size 18.

P.S. I posted this in https://github.com/Microsoft/vscode/issues/46900#issuecomment-377741221, but that issue is closed, and whenever I get on a new computer, I have to google how to fix this issue, so by posting here, it's easy to find the workaround for Ubuntu, until this gets fixed.

with
"terminal.integrated.fontSize": 16,
"terminal.integrated.fontFamily": "Ubuntu mono",

Thanks @leejroberts
"terminal.integrated.fontFamily": "Ubuntu mono",
"terminal.integrated.fontSize": 16,

This is also present in version 1.25.0 (Ubuntu 18.04).

This issue is affecting me on 1.25.0 on Antergos.
All of the fixes mentioned here, including setting window.zoomLevel to -0.001 and increasing line height were unable to fix it for me with my default fault. Only using other zoom levels with ctrl+ and ctrl- or changing fonts worked for me. My workaround was to change fonts to Courier family.

Is there going to be any fix for this ?
I think characters in the integrated terminal (eg. underscores) should be displayed without the user having to tweak the settings. A freshly installed VS Code should not suffer from this bug.

+1 vote for fix this problem once and for all.
I googled this thread for fix with every fresh install of VS Code.

The fix that worked best for me is "window.zoomLevel": 0.001
(+ or - non-zero value close to zero seems to work fine)

For those who can't get these font size/type solutions to work - make sure you check in a new terminal window. The changes won't be reflected in any currently open terminals.

@suonto zoom level fix works! I'm using Fedora 28 and VSCode 1.27.1

A temporary workaround was merged for Ubuntu that tweaks the font family/size if it's not set https://github.com/Microsoft/vscode/pull/56429

Another possible workaround (Mint 19 MATE) is changing the terminal rendered like this
"terminal.integrated.rendererType": "dom"

@matcha works for ArchLinux with GNOME3 too.

Ununtu 18.04 with zsh, having the same problem.

Linux Mint 19. What an upsetting bug. That undescore invisibility just renders the terminal un-usable

in my case, you just have to zoom in your screen with [Shift] + [Cmd] + [;]

I fixed the issue by removing 'monospace' from editor.fontFamily in settings.json (or Settings > Text Editor > Font > Font Family):
# Broken: "Hello_World!" -> "Hello World!"
"editor.fontFamily": "'Droid Sans Mono', 'monospace', monospace, 'Droid Sans Fallback'"

# Works: "Hello_World!" -> "Hello_World!"
"editor.fontFamily": "'Droid Sans Mono', monospace, 'Droid Sans Fallback'"

I fixed the issue by removing 'monospace' from editor.fontFamily in settings.json (or Settings > Text Editor > Font > Font Family)

I think this is a bad choise of possible workaround, because by disabling monospace fonts you will have broken pseudo-graphic user interface in various console utilities.
You should really try to calculate working value of terminal.integrated.fontSize for your case.

@fessmage He only removed the 's

@fessmage The broken config contains two monospace entries. One with quotation marks ('monospace') and one without (monospace). I just removed the entry with quotation marks.

@mmhelm  Right, i see it now, sorry.
Also i discovered that in my case, on Ubuntu, i needed no more to declare this settings for correct terminal font:
"terminal.integrated.fontSize": 16,
"terminal.integrated.fontFamily": "Ubuntu mono",

because after merging this PR, vscode sets this automatically.

Using this setting solved the issue for me (fedora 29), whatever the integrated terminal font size:
"terminal.integrated.fontFamily": "monospace"

Can confirm this as well. Removing 'monospace' (=with quotation marks) resolves the issue.

Change the fontWeight works for me.
"terminal.integrated.fontWeight":"600"

Using this setting solved the issue for me (fedora 29), whatever the integrated terminal font size:
"terminal.integrated.fontFamily": "monospace"

This did not solve the issue for me. I'm also using Fedora 29.
I used to use the zoomlevel = 0.001 workaround, but that does not work either anymore...

@mikkancso
What did the trick for me on Fedora 29 was to set the font family to :
"terminal.integrated.fontFamily": "Liberation Mono"

@mikkancso
Try with the font weight:
 "terminal.integrated.fontWeight": "600",
 "terminal.integrated.fontWeightBold": "600"

"terminal.integrated.fontFamily": "Liberation Mono"

Also works on Ubunty 18.04.

Only add "window.zoomLevel": 0.001

@Tyriar
La solución de la altura de la línea no funciona para mí en los últimos conocedores
Ejecutando Ubuntu en virtualbox

Versión VSCode: Código - Insiders 1.18.0-insider ( 81cca6c , 2017-10-31T06: 24: 27.011Z)
Versión del SO: Linux x64 4.10.0-37-genérico

En mi captura de pantalla escribí algunos guiones bajos _________

También probé alturas locas como, 2pero nada parece ayudar.
Esta es una regresión de 1.17 donde se muestra bien:

El ajuste terminal.integrated.fontSize": 13es una solución para mí

Font weight fixed it for me on Ubuntu 18.04

What's the status here? Kind of annoying that the terminal is unusable with the default font-size/height

I've gotten used to this in the terminal since this issue was originally reported, but today I just noticed that it is affecting other aspects of VS Code as well like the renaming symbol interface. Demonstration:

@welkie I think that's this one https://github.com/microsoft/vscode/issues/46879, I suspect it's the same underlying cause that _ in Linux fonts sometimes go out of their expected bounds at least when drawn in Chromium, the fix would look different though.

@welkie please comment on https://github.com/microsoft/vscode/issues/46879 what OS/distro you're on and also whether or not the problem shows up in the intellisense completions as well like in the original post of that issue.

@Tyriar Looks like I can't comment on #46879 because it's locked. If it's unlocked, I'll leave a detailed comment with all the relevant info.

Unlocked, meant to when I reopened

@Tyriar Left a detailed comment.

setting "terminal.integrated.fontSize" to 15 shows the underscore character for me.

setting "terminal.integrated.fontSize" to 15 shows the underscore character for me.

It does not make sense to show only in higher font size, we need to fix it. But good to know the value, it could help debug.

Any progress on this issue?

Any progress on this issue?

A none, continue the problem. :/

On Linux (Mint 19.2) installing the Inconsolata font and making it the first in the font list (and restarting VS Code) fixed the terminal window issue for me. I know that's not a "fix" but for those reading this thread who want a font "That Just Works" maybe that will help until it is fixed. FWIW, Linux Mint's editor, Xed, has had a similar issue - https://github.com/linuxmint/xed/issues/39.

I have the same problem
Reproduce: echo "___" into terminal
Version: 1.37.1
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Datum: 2019-08-15T16:17:25.463Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
Betriebssystem: Linux x64 4.15.0-60-generic

Same issue here on Ubuntu 18.04 and latest (1.38.0) Visual Studio code. "terminal.integrated.fontFamily": "monospace" provides a good workaround, but a fix would be very appreciated :/
Version: 1.38.0
Commit: 3db7e09f3b61f915d03bbfa58e258d6eee843f35
Date: 2019-09-03T21:51:09.716Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-60-generic

Simply setting terminal font to Hack on Kubuntu 18.04 fixed it for me.
"terminal.integrated.fontFamily": "Hack"

When gets this fixed? It's a issue from 2 years ago already!
I don't understand why it's not a priority.
Setting: terminal.integrated.fontSize to 15 fixed the issue.
Maybe, make this font size the default? This could be an option.

I work a lot in a linux environment compared to windows environment so when changing over from windows, I always get irritated that I cant see the underscores and I see that this has been going on for two years already. Commenting so I can follow this issue to see it fixed.

I'm not using vscode, but I'm seeing this issue on ArchLinux in both Chromium and Hexchat with certain font-sizes only, but not only with DejaVu Sans Mono (Book) but also with Noto Sans Mono  but way less visible. Tested for chars: qpjy_. With Nono the underscore is always visible, but other chars can be seen cut off a bit.
Inconsolata font however seems to exhibit no such issues. Hence why I'm switching my Monospace font to it.
$ fc-match monospace
Inconsolata-Regular.ttf: "Inconsolata" "Regular"

This here is an interesting read as to why this descenders cut off might be happening.

Setting font size to 13.9 (from the default of 14) fixed underscores for me.

The current thing blocking this is stabilizing the WebGL renderer, see upstream query: https://github.com/xtermjs/xterm.js/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Faddon%2Fwebgl

@Tyriar
The line height workaround doesn't work for me in latest insiders
Running Ubuntu in virtualbox

VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________

I also tried crazy heights like 2 but nothing seems to help
This is a regression from 1.17 where it displays fine:

Setting terminal.integrated.fontSize": 13 is a workaround for me

fontSize: 13 and fontSize: 15 all can solve this problem. just advise that the default Size not be 14, it will be solved.

ok so wow, what happened
On Oct 22, 2019, at 2:47 AM, suntao<EMAIL_ADDRESS>wrote:

@Tyriarhttps://github.com/Tyriar
The line height workaround doesn't work for me in latest insiders
Running Ubuntu in virtualbox

VSCode Version: Code - Insiders 1.18.0-insider (81cca6chttps://github.com/microsoft/vscode/commit/81cca6cc606eeca3443998025bff3893fcfe3ad5, 2017-10-31T06:24:27.011Z)
OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________
[image]https://user-images.githubusercontent.com/5593825/32218526-661786ba-be2b-11e7-837d-74ce740f92a8.png
I also tried crazy heights like 2 but nothing seems to help
This is a regression from 1.17 where it displays fine:
[image]https://user-images.githubusercontent.com/5593825/32218743-39ad2a70-be2c-11e7-8d87-1312afdd09d5.png
Setting terminal.integrated.fontSize": 13 is a workaround for me
fontSize: 13 and fontSize: 15 all can solve this problem. just advise that the default Size not be 14, it will be solved.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/35901?email_source=notifications&email_token=AMVNWDQL4LCDA4BOLJEBOATQP2V2VA5CNFSM4D6JW65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB42M3I#issuecomment-544843373, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDVTP2RHPM7EKYSE3EDQP2V2VANCNFSM4D6JW65A.

want me to pwr up?  seemed everyone had a little fun with me so i just shut down for the night. But maybe it wasn’t ? i really would like to know, when i booted to another drive had multiple logins were erasing every drive so i shut back down
On Oct 22, 2019, at 2:53 AM, Rocket<EMAIL_ADDRESS>wrote:
ok so wow, what happened
On Oct 22, 2019, at 2:47 AM, suntao<EMAIL_ADDRESS>wrote:

@Tyriarhttps://github.com/Tyriar
The line height workaround doesn't work for me in latest insiders
Running Ubuntu in virtualbox

VSCode Version: Code - Insiders 1.18.0-insider (81cca6chttps://github.com/microsoft/vscode/commit/81cca6cc606eeca3443998025bff3893fcfe3ad5, 2017-10-31T06:24:27.011Z)
OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________
[image]https://user-images.githubusercontent.com/5593825/32218526-661786ba-be2b-11e7-837d-74ce740f92a8.png
I also tried crazy heights like 2 but nothing seems to help
This is a regression from 1.17 where it displays fine:
[image]https://user-images.githubusercontent.com/5593825/32218743-39ad2a70-be2c-11e7-8d87-1312afdd09d5.png
Setting terminal.integrated.fontSize": 13 is a workaround for me
fontSize: 13 and fontSize: 15 all can solve this problem. just advise that the default Size not be 14, it will be solved.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/35901?email_source=notifications&email_token=AMVNWDQL4LCDA4BOLJEBOATQP2V2VA5CNFSM4D6JW65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB42M3I#issuecomment-544843373, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDVTP2RHPM7EKYSE3EDQP2V2VANCNFSM4D6JW65A.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/35901?email_source=notifications&email_token=AMVNWDX2Q564KGAQ77LHHCTQP2WOLA5CNFSM4D6JW65KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB422PA#issuecomment-544845116, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDX2NCUJER3TC5TG5OTQP2WOLANCNFSM4D6JW65A.

Underscores are finally visible with fontSize: 14 and the latest 1.40 version :tada:

@SurgeS
Underscores are finally visible with fontSize: 14 and the latest 1.40 version

Still not working for me on: Ubuntu 18.04.3 LTS x64, VS Code 1.40
I have to use the workaround "terminal.integrated.fontSize": 15" in order to see the underscore.

@viniciussp4 I use my docker image with ubuntu 18.04 for development and I see the underscores:
https://github.com/Bessonov/dev-image
Can you check your installation and vscode settings or the image?
https://github.com/Bessonov/dev-image/blob/master/Dockerfile#L28
I mean, if it's working in a reproducible way with docker, then it could be a local problem.

@Tyriar
The line height workaround doesn't work for me in latest insiders
Running Ubuntu in virtualbox

VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T06:24:27.011Z)
OS Version: Linux x64 4.10.0-37-generic

In my screenshot I typed some underscores _________

I also tried crazy heights like 2 but nothing seems to help
This is a regression from 1.17 where it displays fine:

Setting terminal.integrated.fontSize": 13 is a workaround for me

I don't get it but only the with font-size of 14 there comes the problem, but with other font sizes it not the case. Any reason ??

It's an off by one error in measuring the "height" of the font that doesn't happen in all font sizes in the canvas renderer of xterm.js. If there is someway to fix up this computation then that would fix this for the canvas renderer. I think there was an issue in xterm.js where I explained my investigation of this.

The issue is that rows are clipped so that we can render rows independently, otherwise the whole terminal would need an update. https://github.com/microsoft/vscode/pull/84440 fixes this and makes the terminal way faster so stay tuned 😃

I'm running OSX and I used to have "ProggyCleanTTSZ"  ( from the amazing https://proggyfonts.net/ ) and it worked like a charm.
One day i decided to accept the "Update" on VS Code and that terrible update started cropping my text on the terminal.
I played with all settings possible here in this thread and nothing worked other than changing my font to "monospace", which is less than ideal as i'm used to use ProggyClean for over 15 years now 😢
I hope this get fixed before i move back to vim, which perhaps i should never have left, lol

@hems that's a bug in Chromium that shows up on some fonts https://github.com/microsoft/vscode/issues/84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

@hems that's a bug in Chromium that shows up on some fonts #84432, https://bugs.chromium.org/p/chromium/issues/detail?id=1026254

hopefully fixed soon

You can try out the new WebGL-based renderer where this issue is fixed by using this:
"terminal.integrated.rendererType": "experimentalWebgl"

It's available in Insiders and in the upcoming version.
The canvas renderer will eventually be removed as the webgl one is basically a highly optimized/low-level version of it.

"terminal.integrated.rendererType": "experimentalWebgl"

that just gave me new problems, like my text is rendered out of the Terminal box sometimes and i can't see it. but if i type for instance ls -la then i can se the result because it spans many lines.

@hems I haven't heard of a problem like that before, please report in a new issues with repro steps.

If you're still on the canvas renderer, @hems calls out a workaround in https://github.com/microsoft/vscode/issues/107942#issue-713299633 to regenerate the font file:

After months and months having the issue with my font being cropped on the bottom of the terminal i managed to solve the issue by importing the font into https://www.glyphrstudio.com/online/ then export it as OTF.


Add transient Props to @xstyled/emotion

Summary
Emotion allows its consumer apps to change styles based on props. See here. By default, emotion would prevent invalid props from being rendered to the DOM element but since xstyled is overriding the "shouldForwardProp" this functionally is being removed.
Styled-components handle this by prefixing the prop name with a dollar sign $.  Transient Props
Do you see any downside or conflict by doing something this? @agriffis @gregberge
Test plan

My previous PR was causing some issues with the "as" so this is why I just remove the ones with the $.

Thanks Max!
For reference, styled-components checks for transient props before calling shouldForwardProp:
https://github.com/styled-components/styled-components/blob/23ec638a5e0802b9b17b0ffde025e6ba1ea650c9/packages/styled-components/src/models/StyledComponent.ts#L135-L150
I think we should move the check before checking generator.meta.props (fast check before slow check)
I'm also suspicious that we should check for prop === 'theme' since I think I've seen that sneak through sometimes.

Thank you for your quick response. @agriffis
Base on your last comment:

I'm also suspicious that we should check for prop === 'theme' since I think I've seen that sneak through sometimes.

I don't see the the theme being forwarded to the DOM from the theme provider. But if I explicitly add a "theme" prop to the component it would be render in the DOM. In that case, I don't understand why it should have a special treatment.
I reordered the check.
  it("doesn't forward theme", () => {
    const Dummy = styled.box``
    const { container } = render(
      <SpaceTheme>
        <Dummy />
      </SpaceTheme>,
    )
    expect(container.firstChild).not.toHaveAttribute('theme')
  })

I appreciate your willingness to add an extra test, but I think we should leave that one out for now, since it's otherwise unrelated to this PR.
Otherwise this looks good to me. Do you have any concerns or thoughts, @gregberge ?

I appreciate your willingness to add an extra test, but I think we should leave that one out for now, since it's otherwise unrelated to this PR.
Otherwise this looks good to me. Do you have any concerns or thoughts, @gregberge ?

@agriffis I removed the test. Thank you for the support.

Hello @maxmedina05, thanks, it looks good to me.

@agriffis @gregberge How does the pipeline works?
Would this be automatically published? like 2.4.2? or do I need to trigger something?

For now, Greg is the pipeline :stuck_out_tongue_winking_eye:

Ey @gregberge
Thank you for letting merge this.  With this I can finally finish upgrading an internal lib to v2.
could this be release as version 2.4.2?

@maxmedina05 done


allow other output-styles (related #105)

This will default to current output style, but allow other styles, for example on gitlab-pages:
react-snapshot --output-style "{name}/index.html"

This is awesome! Can we get this merged?
@geelen


Ss18/pr0 enhancement

Fixed typos:
additonal -> additional
alligned -> aligned
boundry -> boundary
seperated -> separated
Found with: https://github.com/ss18/grep-typos

Thank you!


LiveShare: Cannot  perform "Go to definition" via Ctrl+click on client

VS Version: 16.1.0 Preview 4.0 [28904.22.d16.1stg]
Python Tool Version: 16.1.19121.1
Repro step:

Type below code
import decimal
decimal.Decimal()
Ctrl+click on ‘Decimal' on client

Actual Result:
It doesn't go to the definition on client. On host, it can go to the definition.
Expect Result:
It should jump to the definition of the method on client.

This is a feature not supported by LiveShare.
I filed internal issue 888095
Closing since that's out of our control and not a bug.


doc: Add docstrings to dbg_trace and assert! in do blocks

they had doc strings in their term forms, but the doElem variant did
not, as noted on zulip

Note: unlike in mathlib, changing the title does not change the eventual commit message :)

I guess I should have triggered https://squasher.nomeata.de/ before.
Can we haz Borg or mergify soon, to reduce this friction? :-)


Error if missing values in last column

I get an error if there are missing values in the last column of input. Adding any value rescues the file. Is this expected? I get quite a files with missing data.
tmp.bed
bedtools merge -i tmp.bed
Error: unable to open file or unable to determine types for file tmp.bed

Bedtools expects that every record has the same number of columns. The best thing to do would be to preprocess every file to standardize the records.

Bedtools expects that every record has the same number of columns. The best thing to do would be to preprocess every file to standardize the records.

Hmm, the files have the same number of columns. The issue comes up if there are empty i.e. \t\t values in the last column. Other columns with empty values don't cause an issue.

Good point - will try to patch this up.

Were you able to reproduce this? It came up again. The solution was to add dummy values to the last column if it was empty. It felt wrong.

Not sure why this was closed, it is still open.

Bump -- I am having this issue as well. Any word on when it might be fixed?

This is now fixed in master - thanks for reporting and for the patience.

Thanks!

I am having this occur using bedtools intersect. Was the bug fixed only for bedtools merge?


NodeJS 10.x for runtime version 2.0

Upgrade NodeJS runtime Docker image to NodeJS 10.x.
The description on Docker Hub for image azure-functions/node:2.0 is as follows:

the latest stable 2.0 function runtime for Linux with node 10 worker runtime. The Dockerfile can be found here

The image actually contains NodeJS 8.x. See the file host/2.0/stretch/amd64/node.Dockerfile: version 8 is clearly installed.

included in #140


Optimizing node_modules in production

Problem
I am running a Next.js application (on an Express custom server) using Prisma.
I've been working on minimizing my production Docker image size, and I've noticed that even when only @prisma/client is included in production deps, Prisma happens to downloads all its engine binaries, costing a whopping 82MB:

Suggested solution
I was wondering if Prisma could provide some way to trim down the bundled binaries if, say, I don't need the introspection/migration engines on my production server image. Of course, it's possible to run a script to delete them. But maybe there should be an option (env var?) to install Prisma with only some of the dependencies.
Alternatives
Write a script to delete unwanted binaries from node_modules.

Just to add context - this was with Prism 2.15.
Looks like a bug in 2.15, where @prisma/cli was included in prod dependencies (I ran yarn install --production), creating the bloated engines dir.
Running this with Prisma 2.16 doesn't reproduce, so I'm closing this issue for now.


Edit Social Media links

Facebook: https://www.facebook.com/blockchainedu/
Twitter: https://twitter.com/blockchainedu
Medium: https://medium.com/blockchain-education-network
Discord: https://bit.ly/BENdiscord

@otech47 - I completed this one locally and will send a merge request :) Also updated the FA version so we could include our new Discord!


Add toggle all details button

Additions

Adds a toggle details button that toggles the show/hide button for details.

Changes

Makes the edit page button (and the toggle all button) always show text.

Testing

Visit the PR preview branch and find a page that has details, such as buttons, and click the toggle details button in the lower-right.

Screenshots

Todos

Is the state of the toggled details retained across pages? If so we need to save a cookie or similar.
If some details are showing and some others aren't, how should the toggle button work?

As a frequent small screen user I prefer the buttons to show text only on hover.

Let's discuss in team time!

I'd also vote to have the button functionality alternate between Show all details and Hide all details instead of a static Toggle details.

Yes, we discussed this in chat on Friday and I'll update to be Show all details/Hide all details

My bad, turns out the browser dimensions had to be enlarged in the webdriver config.


[BULK] Validation: Description, tables fixes

Category

[x] Content fix
[] New article

Related issues
No issue part of validation
What's in this Pull Request?
This PR fixes X issues for Y files.

Docs Build status updates of commit 96e3edc:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/schema/appprincipal-element-appdefinition-complextypesharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/appprincipaldefinition-complextype-sharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/appprincipaltypedefinition-simpletype-sharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/arrayofcrawledpropertyinfo-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofcrawledpropertyinfo-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofmanagedpropertyinfo-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofmanagedpropertyinfo-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofproperty-element-list.md
:warning:Warning
View
Details

docs/schema/arrayofpropertyrule-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofpropertyrule-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofreorderingrule-complextype-sps15xsdsearchset5.md
:warning:Warning
View
Details

docs/schema/appprincipal-element-appdefinition-complextypesharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/appprincipaldefinition-complextype-sharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/appprincipaltypedefinition-simpletype-sharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofcrawledpropertyinfo-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofcrawledpropertyinfo-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofmanagedpropertyinfo-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 11, Column 1: [Warning: yaml-duplicate-key] Key 'ms.date' is already defined, remove the duplicate key.

docs/schema/arrayofmanagedpropertyinfo-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofproperty-element-list.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofpropertyrule-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofpropertyrule-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofreorderingrule-complextype-sps15xsdsearchset5.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 58fd413:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/schema/appprincipal-element-appdefinition-complextypesharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/appprincipaldefinition-complextype-sharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/appprincipaltypedefinition-simpletype-sharepoint-add-in-manifest.md
:warning:Warning
View
Details

docs/schema/arrayofcrawledpropertyinfo-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofcrawledpropertyinfo-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofmanagedpropertyinfo-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofmanagedpropertyinfo-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofproperty-element-list.md
:warning:Warning
View
Details

docs/schema/arrayofpropertyrule-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofpropertyrule-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofreorderingrule-complextype-sps15xsdsearchset5.md
:warning:Warning
View
Details

docs/schema/arrayofreorderingrule-element-sps15xsdsearchset5.md
:warning:Warning
View
Details

docs/schema/arrayofresultitemtype-complextype-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofresultitemtype-element-sps15xsdsearchset2.md
:warning:Warning
View
Details

docs/schema/arrayofsearchqueryconfigurationsettings-complextype-sps15xsdsearchset3.md
:warning:Warning
View
Details

docs/schema/arrayofsearchqueryconfigurationsettings-element-sps15xsdsearchset3.md
:warning:Warning
View
Details

docs/schema/arrayofsource-complextype-sps15xsdsearchset1.md
:warning:Warning
View
Details

docs/schema/arrayofsource-element-sps15xsdsearchset1.md
:warning:Warning
View
Details

docs/schema/assembly-element-event.md
:warning:Warning
View
Details

docs/schema/assemblyredirect-element-assemblyredirects-elementworkflowinfo-elementaction4.md
:warning:Warning
View
Details

docs/schema/appprincipal-element-appdefinition-complextypesharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/appprincipaldefinition-complextype-sharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/appprincipaltypedefinition-simpletype-sharepoint-add-in-manifest.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofcrawledpropertyinfo-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofcrawledpropertyinfo-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofmanagedpropertyinfo-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofmanagedpropertyinfo-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofproperty-element-list.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofpropertyrule-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofpropertyrule-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofreorderingrule-complextype-sps15xsdsearchset5.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofreorderingrule-element-sps15xsdsearchset5.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofresultitemtype-complextype-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofresultitemtype-element-sps15xsdsearchset2.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofsearchqueryconfigurationsettings-complextype-sps15xsdsearchset3.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofsearchqueryconfigurationsettings-element-sps15xsdsearchset3.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofsource-complextype-sps15xsdsearchset1.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/arrayofsource-element-sps15xsdsearchset1.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/assembly-element-event.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/schema/assemblyredirect-element-assemblyredirects-elementworkflowinfo-elementaction4.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!


Khasan

create a new branch properly according to your  current tasks
each task = the separate branch
resolve comments


Bug: Dimensions do not work for SpongeForge.

When generating or loading a world while using SpongeForge, OTG v21 DEV1, Biome Bundle, and OTG Skylands, the game will crash with a null pointer exception, World Properties has a null UUID.
If only using Biome Bundle, everything works as expected, however when the dimensions feature is utilized by adding another pack, the game will crash.

Also getting this bug

Needs to be tested with v8.3_r4 or higher. There may still be issues, need updated info.

Closing due to inactivity.


Receiving messages does not work when buffered=true.

Hi,
I've got the same issue as #22 - receiving messages does not work when buffered=true. buffered=false remedies the problem, however it's a bad solution because it disables buffering of the deletion requests.
Any ideas what causes the problem? To improve the usability of the library I suggest setting the default to false and adjust the Readme while this option does not work.
Best,
Mark

I've got the same issue.
Best,
Alexandre

As best I can tell, this is a problem with the underlying Java library from Amazon. I was hoping it would fix itself as they release a new version, but that hasn't happened. It's time to at least change the default. Update coming shortly.


Strange thing

Describe the bug
What When there is a power failure again, everything starts up properly on the internet TV box, but the WG starts up but does not connect to the server. As soon as I open the WG app, it is automatically turned on again.Connect without me turning it on  It would be great if it turned on again by itself
** Nvidia Shield pro
Wat Als er weer een stroomstoring is, start alles goed op de internet tv box, maar de WG start wel op maar maakt geen verbinding met de server. Zodra ik de WG app open, is het automatisch

Device: Android tv  box
Android Version: [e.g. Android 11
App Version [e.g. 3.5.3

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots (Only if necessary)
Additional context
Add any other context about the problem here.

Working now i let you know how it goes ,


Clicking on the screen with another finger while dragging an element interrupts the dragging behavior

Describe the bug
Clicking on the screen with another finger while dragging an element interrupts the dragging behavior, unless you remove the dragging finger and start dragging again
Sandbox or Video
codesandbox link: https://codesandbox.io/s/confident-beaver-556uec
https://user-images.githubusercontent.com/40483898/164155641-e7c6963d-fd89-4eaf-9659-4892b5ef0c91.MP4
I looked at the source code and found that these two lines of code were the problem.
https://github.com/pmndrs/use-gesture/blob/main/packages/core/src/engines/DragEngine.ts#L296-L297
The other finger clicked and set _pointerActive to false, which broke the drag behavior. If these two lines of code were removed, they would behave normally, as follows:
https://user-images.githubusercontent.com/40483898/164156275-9191767f-bf21-4f67-9ed4-60cd87289336.MP4
I didn't submit the PR because I wasn't sure what problem these two lines of code were solving
Information:

Use Gesture version: 10.2.11
Device: iPhone 11 & Xiaomi 11
OS: iOS 15.4 & Android 11
Browser: Chrome

Checklist:

[x] I've read the documentation.
[x] If this is an issue with drag, I've tried setting touch-action: none to the draggable element.

Fair enough, that could / should be fixed, thanks for reporting this. This bug should only occur with preventScroll option set.
I'd need to run some tests to make sure we could safely remove those lines (the gesture cleaning might be done elsewhere).

Sorry for the long wait, should now be fixed!


Kafka 12766 - Disabling WAL-related Options in RocksDB

description
Streams disables the write-ahead log (WAL) provided by RocksDB since it replicates the data in changelog topics. Hence, it does not make much sense to set WAL-related configs for RocksDB.
Proposed solution
Ignore any WAL-related configuration and state in the log that we are ignoring them.
Implementation details
See below
In addition - I made very small refactoring - class RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter is now package private, as this class is internal to Streams
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Build failures are unrelated.


certain (gtk?) clients do not make menu paste available on initial clipboard data offer

I'm not sure whether this is an issue with the proxy, or the ocaml-wayland library.  An example client is l3afpad, a very basic GTK3 app.  After a copy is performed in a different client (doesn't matter which), if l3afpad is the target of the initial paste, its menu paste operation will remain grayed out.  However, Ctrl-V performs the paste.  Also, primary and dnd are not affected (of course - they're not menu based).  Subsequent clipboard usage is not impacted - only the initial one.
Note that l3afpad when not run as a client of wayland-proxy-virtwl does not have this issue.
Maybe something has to be done along with a data offer to get GTK apps to update their menus the first time?
This problem occurs on both the master and Eio branches.

The easy way to find out what's going on is to run it with WAYLAND_DEBUG=1 and compare the output with and without the proxy.


Release Google.Cloud.Dialogflow.V2Beta1 version 1.0.0-beta17

Changes in this release:
New features

Add properties for nested resource name references (commit 15eec4d)

Created release for Google.Cloud.Dialogflow.V2Beta1-1.0.0-beta17


Simplify reportportal plugin test using yq

PR for #2183 [WIP]

There is a struggle with yq working on key starting with a symbol, particularly the / in this case.
I found out it has different behaviour in testing environment (mkvirtualenv tmt) and outside of it, see the example below.

The question is what behaviour will be applied once the PR is merged. As it currently fails in testing environment.
And how to make it work?

The question is what behaviour will be applied once the PR is merged. As it currently fails in testing environment.
And how to make it work?

Hi @4N0body5, how about removing char / when using yq? For example,
(tmt) huanli@KVM:reportportal$ cat data/test.fmf | head -4
/bad:
    summary: Failing test
    contact<EMAIL_ADDRESS>    test: echo "Something bad happened!"; false
(tmt) huanli@KVM:reportportal$ cat data/test.fmf | sed 's%^/%%g' | head -4
bad:
    summary: Failing test
    contact<EMAIL_ADDRESS>    test: echo "Something bad happened!"; false
(tmt) huanli@KVM:reportportal$
(tmt) huanli@KVM:reportportal$ cat data/test.fmf | sed 's%^/%%g' | yq -r '.bad'
{
  "summary": "Failing test",
  "contact"<EMAIL_ADDRESS>  "test": "echo \"Something bad happened!\"; false"
}
(tmt) huanli@KVM:reportportal$
(tmt) huanli@KVM:reportportal$ cat data/test.fmf | sed 's%^/%%g' | yq -r '.bad.summary'
Failing test

Can you try wrapping key in your filter with double quotes, https://github.com/jqlang/jq/issues/38#issuecomment-9770240 ? jq/yq should be fully capable with keys with spaces, dashes and other symbols too.

Can you try wrapping key in your filter with double quotes, jqlang/jq#38 (comment) ? jq/yq should be fully capable with keys with spaces, dashes and other symbols too.

@happz I tried all the ways to wrap the key with symbol (single, quotes, double quotes, escaping, etc.). They all work unless I try it in the testing environment. And I don't really know what it means.

@psss @happz Thank you very much for your answers..

Can you try wrapping key in your filter with double quotes, jqlang/jq#38 (comment) ? jq/yq should be fully capable with keys with spaces, dashes and other symbols too.

Sorry for ignorance, I overseen the need of double quotes inside of the quotes.

Do you see the problem even if the test name is inside double quotes like in the example above?

You're right, it does work now in both environments! This must be truly the only combination I haven't tried and does work. Unfortunately for me, because this way I cannot use variables there because of the single quotes.
Now I'm simplifying the test, I wanted to omit the analogous sections and awful functions per each test and replace it with neat function. But it requires the use of variables as a key for yq.
The question is if it's worth it rewrite it completely, or all what is wanted is to replace greps for yq..?
Example:

Try something like this:
rlRun "yq -r '.\"/test/$variable\"'"

This should expand the variable just fine.

Please review...
There are two commits, the first one simplifying only (extracting fmf data with yq), the other one with complete redesign (for generalization and easier maintenance), but it seems to be just more complicated now.
Please let me know your opinions.


Example syntax is missing a comma

There's a missing comma between the component name and the local params. I think this may have happened when we added Rouge.
Shows:
<%= render "govuk_component/alpha_label" {
  message: "This is an optional different message to explain what Alpha means in this context which can take HTML"
} %>

Should be:
<%= render "govuk_component/alpha_label", {
  message: "This is an optional different message to explain what Alpha means in this context which can take HTML"
} %>

This is my bad, I'm going to put together some more robust tests and fix this, thanks Paul.


Multiple build

I want to generate a few separated documentations from one project but I don't know what should I build my config file. It should be array of biulds? Something like that?
typedoc: {
    build: [{
            build 1
    },
    {
            build 2
    }]
}

Ok, I solved my problem. There I should to build config file like that:
typedoc: {
    build1: {
            build 1
    },
    build2: {
            build 2
    }
}

and call as typedoc:build1 or typedoc:build2

Thanks for posting your fix for others! I :+1:'d your SO question.
FYI, this may be more specific to gulp-typedoc than the typedoc proper.


Make a promo video for launch

We need a promo video on youtube for web store and product hunt launch. it should highlight quick menu and sidebar primarily.

Done ! : https://www.youtube.com/watch?v=sHnGUdMJJD8


🚀 [FEATURE]: API Collection - Generate collection for Insomnia

👀 Background
RestQA aim to provide an up to date API collection for the backend engineer to stop accumulating meaningless collection.
✌ What is the actual behavior?
Currently the only API collection supported is API collection
🕵♀ How to reproduce the current behavior?

Clone the project
run the command npm run contribute
Check the API collection on the RestQA Report result

🤞 What is the expected behavior?
It would be great to have other tool supported such as Insomnia
😎 Proposed solution.

[ ] Update CLI
[ ] Update documentation
[ ] Report UI update

🙏 Would you be willing to submit a PR?
Yes
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Codebase to modify:

https://github.com/restqa/restqa/blob/master/packages/core-collection/src/vendors/index.js
https://github.com/restqa/restqa/blob/master/packages/core-collection/src/vendors/insomnia.js

And the tests 😁 : https://github.com/restqa/restqa/tree/master/packages/core-collection/tests

Hello I'm Hermann, a junior Node developer. Could you assign me this issue please ?

Hello I'm Hermann, a junior Node developer. Could you assign me this issue please ? @olivierodo

Let me close the issue for the moment.
As of today the main tool in the market to focus on is .... POSTMAN!


Week 6 David Review Ticket

Peer Grade from : /5
PBL Coders review ticket

[x] GH Team/Indi Page as applicable, Review Ticket, SCRUM Team graded

My Review Ticket that someone else graded
Review Ticket that I graded

[x] PBL project "tangibles" for two weeks.

Commits
Replit
Code also on IntelliJ

[x] Quiz3 MCQ results

37/50
Corrections

Total Points: 4.5/5 (without .5 from Mr.M)

Had a lot of contribution on team website in the commits
Shows MCQ results and corrections (extra work)
Code runs on Replit


The alluxio-fuse container/pod exited without releasing a newly created file

Alluxio Version:
2.9.0
Describe the bug
Below is a case of the issue

alluxio-fuse is running in a container
There is a client program which reads/writes file through alluxio-fuse. The client program creates a file and calls "close" for the file.
Just after the create/close operation, the container exited
Start a new container with alluxio-fuse to read the file and it encountered the following exception

...
2023-04-18 11:33:11,176 WARN  BaseFileSystem - File /.../src/zip.sh is not yet completed. getStatus will see incomplete metadata.
2023-04-18 11:33:11,200 WARN  BaseFileSystem - File /.../src/zip.sh is not yet completed. getStatus will see incomplete metadata.
2023-04-18 11:33:11,249 WARN  BaseFileSystem - File /.../src/zip.sh is not yet completed. getStatus will see incomplete metadata.
2023-04-18 10:21:39,002 ERROR AlluxioJniFuseFileSystem - File /src/zip.sh is not completed

The doc of CS135 FUSE Documentation says

release(const char* path, struct fuse_file_info *fi)
This is the only FUSE function that doesn't have a directly corresponding system call, although close(2) is related. Release is called when FUSE is completely done with a file; at that point, you can free up any temporarily allocated data structures.

Which means that "release" may be not called before the returning of "close". So if the container exited just after "close", the file in alluxio may be incomplete.
To Reproduce
Cannot reproduce the issue stably.
Expected behavior
"release" is called before the returning of "close".
Urgency
Normal
Are you planning to fix it
NO

This issue may also cause alluxio-fuse created a file but did not trigger completeFile

thanks for the information, @LuQQiu @ssz1997  FYI

I'm wondering what triggered the exit of the fuse container?

This is triggered by the client program itself and is expected. The client program has finished its logic after the returning of "close".

Theoretically release shall be called for every open according to libfuse doc

Yeah, but it does not guarantee that it's called before the returning of "close".

If it could wait until everything's done before exit, it should be fine.

Yes. We tried sleeping a short period(100ms) between "close" and "exit the container", but the issue still occurs sometimes.

is it possible to get a debug-level fuse log in this case?

This issue is very hard to reproduce, and it's not good to turn on debug-level log for all users for a long time.


[Bug] Millennium keeps resetting to default steam every boot

Before Reporting

[X] I found no existing issues matching my bug
[X] My issue is not caused by a theme

Describe the Bug
Everytime I reboot my PC, the steam will reset to default.
There is no options from millennium can be seen.
I have to do the powershell script every time to bring back millennium and the theme.
What I have tried:

Fresh reinstall steam
Uninstall millennium and install again

My settings:

Steam located in D:\Steam
Using fluenty theme
Millennium version 2.11.1

Is it steam forcing something? Or I should install specific version of steam.
But I don't think that's a problem.
I had 3 PC installed millenium with the same theme.
Only one pc has this problem... kinda frustrating
Expected Behavior
As mentioned above
Steps To Reproduce
Reboot > open steam > steam reset to default
**update: switching account make this happens too
A .crash file appears in steam folder
GameOverlayRenderer.log
When I run the powershell script again, I see more lines shown in the picture

Operating System
Windows
Anything else?
No response

When you notice it not working anymore do the following:

Check you antivirus hasn't deleted Millennium.
Check user32.dll exists in the Steam folder.

You can also start steam with -dev and leaving it running like that until either you see an error, or the dev console no longer shows.

Hi,
I took some more time to troubleshoot, the problem still exists

tried changing other theme
tried moving the steam folder from another pc to my laptop
user32.dll exists
antivirus is disable
I really love millennium. It works fine on my other pc.
But no idea why not working well on my new laptop...

You are confident that when this issue happens, user32.dll is still in the Steam folder?

i think i have experienced it before. when i booted my pc up, it had a powershell warning.

Try checking this issue out: https://github.com/SteamClientHomebrew/Millennium/issues/149

Fixed in the latest release!


Can't click login button after being logged out.

Describe the bug

After being logged out of the CMS, there seems to be a lot of z-index issues with the login flow. I can't click the Login with Netlify Identity button at all.
To Reproduce

Log out of your admin, or clear your application cache so you are forced to login with Netlify Identity again.
Navigate to your admin dashboard to get to the login flow.
Try clicking the Login with Netlify Identity button

Expected behavior

Clicking the Login with Netlify Identity button should prompt an email and password modal to pop up over the button
Screenshots

Applicable Versions:

Netlify CMS version: 2.11.11
Git provider: GitHub
OS: MacOS 10.14.6
Browser version Chrome 79

CMS configuration

CMS.init({
  config: {
    backend: {
      name: 'git-gateway',
      repo: 'https://github.com/mixmaxhq/mixmax-website',
      branch: process.env.NETLIFY_BRANCH || 'master',
      use_large_media_transforms_in_media_library: true,
    },
    load_config_file: false,
    display_url: 'https://mixmax.com',
    media_folder: 'static/assets',
    public_folder: '/assets',
    publish_mode: 'editorial_workflow',
    show_preview_links: true,
    collections: [
      primary,
      feature,
      integrations,
      useCases,
      blog,
      hub,
      legal,
      landingPages,
    ],
  },
});

Additional context

Hi @bobbymart1n, I'm getting all 404 except the main index.html when trying to access the CMS:

Hi @bobbymart1n, I'm getting all 404 except the main index.html when trying to access the CMS:

This is actually a separate issue I've been having. If you use /admin/ it should direct properly.

This is aside from the issue, but this isn't a valid CSS property

Its on the class .visuallyHidden

Is there any way to prompt the login flow via a URL? Other teams that I work with are blocked from entering the CMS currently

It seems like the identity widget is initiated twice, I see two instances loaded in the DOM.

This is actually a separate issue I've been having. If you use /admin/ it should direct properly

You can read up on that discussion here: #332

Closing this issue. Adding enableIdentityWidget: false, to gatsby-plugin-netlify-cms options in gatsby-config.js solved the problem. I'm now running into another issue where adding that property breaks page previews in the CMS


Add option to limit number of plays of the same song in a specified time period

Some users play the same song excessively. Configuration options to limit the number of times a song can be played in a given time period would be useful in limiting this.

Currently Permissions.ini has MaxSongs    which will limit how many they can add to the current queue which may be a start.

I'd definitely love to +1 this


The url http://<IP_ADDRESS>:8080/login/auth takes you to a Grails/Spring Security default login page

Remove it as login is only from the Angular front end

This will be dealt with as part of the Spring Boot migration.


🐛 [BUG] - MinimalFooter alignment for Links and Buttons

Describe the bug
When using MinimalFooter.Link as a and button together, the links aren't aligned correctly. In the example below the last link is rendered as button.
Reproduction steps
Use `MinimalFooter.Link` as `a` and `button` together.

Expected behavior
All links in the footer should be aligned properly.

Screenshots

Browsers
No response
OS
No response

Can confirm this is fixed.


How to access channel data sent to Healthcare Bot.

I'm sending channel data from StartBotConversationAsync() in directlineClient to the healthcare Bot.
var userMessage = new Activity
            {
                From = new ChannelAccount(_userService...),
                Text = ActivityTextHelper.StartHealthcareBot,
                Type = ActivityTypes.Message,
                ChannelData = questionnaireViewModels
            };

The problem I'm having is accessing the channel data from the healthcare bot service. Is there a way that I can access ChannelData from the healthcare bot service? Thanks in advance.

Hi, Channel data is not accessible in the scenario authoring tools in Healthcare Bot. To transfer data to Healthcare bot you can pass custom variables in the Invoke event. This is then accessible in the scenarioArgs in Healthcare Bot.
https://docs.microsoft.com/en-us/HealthBot/integrations/programmatic_invocation
Adam


Routing: URI vars dont pass if the controller has the same name like the public function

Hey,
probably no1 except me usng this constallation.
Today i wrote a controller which got the name _save _and a public function save.
i tried to pass 2 variables to the controller with a request.
class Save extends CI_Controller {

	public function save($name, $data) {

	}
}

The vars were undefined when i called it.

<IP_ADDRESS>/project/index.php/save/save/123.log/abc

I tried to fix it with routing but it doesnt work aswell.
Just renaming the function or controller solved the issue.
Greetings
Chris

Duplicate of #3451.


java: fix java_home on macOS

https://github.com/Homebrew/brew/pull/10397 incorrectly changed what java_home pointed to on macOS. The path is correct on Linux, but on macOS, the Java home is actually in /usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home to ensure compatibility with being linked to /Library/Java/JavaVirtualMachines per the openjdk formula caveat.
If a formula used e.g. bin.write_jar_script in its install block, this is what it looks like on macOS before and after this pull request.
#!/bin/bash
export JAVA_HOME="${JAVA_HOME:-/usr/local/opt/openjdk/libexec}"
exec "${JAVA_HOME}/bin/java"  -jar "/usr/local/Cellar/foo/1.0/libexec/foo.jar" "$@"

#!/bin/bash
export JAVA_HOME="${JAVA_HOME:-/usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home}"
exec "${JAVA_HOME}/bin/java"  -jar "/usr/local/Cellar/foo/1.0/libexec/foo.jar" "$@"

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

Review period will end on 2021-02-03 at 07:44:03 UTC.

Review period skipped due to critical label.

Finished in 8 minutes 6 seconds (files took 5.65 seconds to load)
1022 examples, 6 failures

Failed examples:

rspec ./test/language/java_spec.rb:21 # Language::Java::java_home returns valid JAVA_HOME if version is specified
rspec ./test/language/java_spec.rb:26 # Language::Java::java_home returns valid JAVA_HOME if version is not specified
rspec ./test/language/java_spec.rb:45 # Language::Java::overridable_java_home_env returns java_home path if version specified
rspec ./test/language/java_spec.rb:50 # Language::Java::overridable_java_home_env returns java_home path if version is not specified
rspec ./test/language/java_spec.rb:38 # Language::Java::java_home_env returns java_home path if version is not specified
rspec ./test/language/java_spec.rb:33 # Language::Java::java_home_env returns java_home path if version specified

Thanks for shepherding in this bug fix! I wasn't able to fix the tests last night so thanks for helping get this merged!


mkdtemp not getting cleaned up

I just ran out of space on /tmp/ after training about 200 decision forests.  I think the temporary directory created at https://github.com/tensorflow/decision-forests/blob/58a5eb0187e8b4c391eca1ba02c2406b5adabfc5/tensorflow_decision_forests/keras/core.py#L378 is never cleaned up, even after the python process ends.  Each model that I was training required about 20 megs.  So after 200 models I had 4 gigs in /tmp/ and my operating system said "what is all that doing there??" and got mad at me.
I have two ideas about this.

It seems like it should be possible to insist that the learner doesn't use disk unless explicitly permitted by the user.   But perhaps that is wildly naive.
It looks like the temporary directory is only actually used in _train_model.  So we should be able to use a  https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory context manager, just for that call (unless the user explicitly provdes a temporary directory).

Thoughts?

Hi jacksonloper,
Thanks for the alert and suggestions :).
Background
The training method takes a temp_directory argument. If not provided, the argument defaults to tempfile.mkdtemp(). As you noticed, unlike something like TemporaryDirectory, mkdtemp does not remove the files.
This directory is in fact not used for training (ydf does not require a temp directory for training). Instead, the directory is used to store the TF SavedModel assets after training. In other words, if the temps directory is removed after training, the model will work fine (e.g. you can can predict), but it won't be possible to export it (e.g. model.save).
The temp_directory also serves another purpose. The model kept in RAM is a compiled version optimized for the specific hardware. The compiled version is generally significantly smaller than the original model. However, the compilation is a non-reversible operation. Therefore, the temp_directory is the only full copy of the model.
Your proposed solutions

It seems like it should be possible to insist that the learner doesn't use disk unless explicitly permitted by the user. But perhaps that is wildly naive.

This might be possible. See new proposed solutions 4 and 5.

It looks like the temporary directory is only actually used in _train_model. So we should be able to use a https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory context manager, just for that call (unless the user explicitly provides a temporary directory).

There need to be a logic to keep the model temp directory (if the user wants to).
New proposed solutions

[easy] Document the logic described above to the user (pydoc and mddoc). Create an example (e.g. doc or colab) where the temp_directory is created and removed by the user. Pro: Existing solution.

[easy] Add an argument to remove the use of the temp_directory and make the model non-serializable (great if you don't expect to export the model after training). Pro: The most efficient solution (memory and disk IO) if the user does not care about the model. Con: separate path for the creation of the TF Model object.

[some work] Add an argument to remove the use of the temp_directory while keeping the model serializable. The non-compiled model will be kept in memory (alongside the compiled model). Pro: No need for a tmp directory. Con: higher memory usage.

wdyt?

Some thoughts:

It gets my vote for a good default, but like happened with @jacksonloper, one may run out of disk-space during, let's say when doing hyperparameter tuning -- a common use case ...

3.b. Would it be possible/safe to improve solution 3 by adding a .__del__() method, or a weakref.finalize() to remove the files, if the model gets garbage collected ? As described in:
https://docs.python.org/3.6/library/weakref.html#comparing-finalizers-with-del-methods
This way the disk-space and memory-space will be kind of bound together.

Handy option, +1 to having this (as a non-default option).

+1 to having this option as well, but non-default because of the larger memory footprint. But with 3b they will become somewhat similar (since both are garbage collected).

The solution 3.b was implemented in TF-DF 0.1.8.
By default, the temp directory is linked to the model object.


plot problem

when I ran python main.py -na
then i encountered this
Traceback (most recent call last):
File "main.py", line 737, in
true_p_bar
File "main.py", line 183, in draw_plot_func
sorted_keys, sorted_values = zip(*sorted_dic_by_value)
ValueError: not enough values to unpack (expected 2, got 0)
please help
thank you

i got the same problem

I got the same problem,I found a reason. You should run evaluate.py before run main.py .If you run A, check if the output is predicted

请问解决了吗

when I ran python main.py -na
then i encountered this
Traceback (most recent call last):
File "main.py", line 737, in
true_p_bar
File "main.py", line 183, in draw_plot_func
sorted_keys, sorted_values = zip(*sorted_dic_by_value)
ValueError: not enough values to unpack (expected 2, got 0)
please help
thank you
请问您解决了吗


Local pull request success status testing

Docs Build status updates of commit f189292:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[MB-4745] Add payment requests needing approval count to Payment requests tab

Description
Draft PR for now to make sure this all seems good. I would like to add tests, but otherwise am looking to see if this approach is correct.
My own Todo:

[ ] Add tests

Reviewer Notes
Just ensure I'm not missing any edgecases and that the logic of displaying the indicator makes sense.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Login as<EMAIL_ADDRESS>role
Code Review Verification Steps
MBRYPJ move code has no indicator as payment request has been reviewed already
TXKRK9 has one indicator, reviewing it removes indicator

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-4745

  Generated by :no_entry_sign: dangerJS against 564c4e72ae7ea2c012fec6b69118452d17533035

Your approach looks great!

Ready for review again (I also moved it out of Draft status.) I updated this to use the constants not from /shared. I also added some tests, and rewrote the existing Enzyme tests for the MovePaymentRequests in react-testing-library.


build(openshift): rename configmap property osio.sentry.dsn to launcher.backend.sentry.dsn

Ike Plugins (test-keeper)
Thank you @ia3andy for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation.


Linux Bit is null - fails to download geckodriver

We are using selenium-grid-extras version 1.12.17
gecko-driver 0.19.0 is failing to download.  For some reason the linux "bit" (64/32) is not getting set so it can't find the file to download.
I see this in the logs:
2017-10-13 21:27:19 INFO  ExecuteOSTask:177 - Downloading Gecko Driver 0.19.0
2017-10-13 21:27:19 INFO  GeckoDriverDownloader:91 - Downloading from https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linuxnull.tar.gz
2017-10-13 21:27:19 INFO  Downloader:94 - Starting to download from https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linuxnull.tar.gz
2017-10-13 21:27:20 ERROR Downloader:102 - java.io.FileNotFoundException: https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linuxnull.tar.gz
2017-10-13 21:27:20 ERROR Downloader:105 - Download failed
2017-10-13 21:27:20 INFO  DownloadGeckoDriver:162 - {"exit_code":1,"out":[],"error":["java.io.FileNotFoundException: https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linuxnull.tar.gz"],"root_dir":["/tmp/webdriver/geckodriver"],"file":["geckodriver_0.19.0.tar.gz"],"file_full_path":["/tmp/webdriver/geckodriver/geckodriver_0.19.0.tar.gz"],"source_url":["https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linuxnull.tar.gz"]}

I ensured that the selenium_grid_extras_config.json file explicitly specifies the bit
"geckodriver": {
"bit": "64",
"version": "0.19.0"
}
this did not help though

I just tried with SGE 1.12.17 and changing the selenium_grid_extras.json file to
   "geckodriver": {
      "bit": "64",
      "version": "0.19.0"
    },

made it download the geckodriver without problems. However, it still doesn't work


DOC: add code review doc

This is awesome, thanks for putting this together!

Thanks for reviewing @RNAer @wasade! I addressed your comments, this is ready for another review.

👍  i am ok with it and can merge it. let me know if you want another 👍 before merge

Thanks @RNAer! Let's have @wasade take a final pass and merge since he had some comments I addressed or responded to.

I'm :+1:

Great! Can one of you merge?

Thanks!


Update zio-interop-cats to <IP_ADDRESS>

Addresses this as well: https://github.com/zio/interop-cats/issues/658 where interop-cats <IP_ADDRESS> was published as 2.0.03. As a result, tooling like Scala Steward will also not bring in <IP_ADDRESS>, since 23.0.03 > <IP_ADDRESS>.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sebastiaan Heunis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


External table overwrite becomes append, ADLS

Describe the bug
When writing to a delta table (on ADLSgen2) with mode 'overwrite', 'appends' happen instead.
To Reproduce
Steps to reproduce the behavior:

Configure spark with unity catalog (and unity with ADLS container)
write delta table with overwrite
write delta table again with overwrite
read table with spark

from pyspark.sql import SparkSession

STORAGE_PATH = "<your path here>"
UNITY_HOST = ""
UNITY_TOKEN = ""
UNITY_DEFAULT_CATALOG = ""
spark = (
    SparkSession.builder.appName("local-uc-test2")
    .master("local[*]")
    .config(
        "spark.jars.packages",
        "org.apache.hadoop:hadoop-azure:3.4.1,io.delta:delta-spark_2.12:3.2.1,io.unitycatalog:unitycatalog-spark_2.12:0.2.0"
    )
    .config("spark.sql.extensions", "io.delta.sql.DeltaSparkSessionExtension")
    .config("spark.sql.catalog.spark_catalog", "io.unitycatalog.spark.UCSingleCatalog")
    .config("spark.sql.catalog.unity", "io.unitycatalog.spark.UCSingleCatalog")
    .config("spark.sql.catalog.unity.uri", UNITY_HOST)
    .config("spark.sql.catalog.unity.token", UNITY_TOKEN)
    .config("spark.sql.defaultCatalog", UNITY_DEFAULT_CATALOG)
    .getOrCreate()
)

data = [("Alice", 34), ("Bob", 45), ("Cathy", 29)]
columns = ["Name", "Age"]
df = spark.createDataFrame(data, columns)
df.show()

df.write.format("delta").option("path", STORAGE_PATH).mode('overwrite').saveAsTable('unity.default.table1')
df.write.format("delta").option("path", STORAGE_PATH).mode('overwrite').saveAsTable('unity.default.table1')

spark.read.format("delta").table('unity.default.table1').show()

results into:
+-----+---+
| Name|Age|
+-----+---+
|Alice| 34|
|Alice| 34|
|Cathy| 29|
|Cathy| 29|
|  Bob| 45|
|  Bob| 45|
+-----+---+

Expected behavior

commit 2 should definitely be a 'overwrite' operation.
Show should result in latest write, 3 records.

+-----+---+
| Name|Age|
+-----+---+
|Alice| 34|
|Cathy| 29|
|  Bob| 45|
+-----+---+

System [please complete the following information]:

OS: devcontainer based on mcr.microsoft.com/devcontainers/python:1-3.11-bookworm

@fseyn Hi! Would you mind if I want to ask you in detail that how to link the uc oss to adls? Now, my uc can see files on s3 bucket, although I done it with someway I think it shouldn't work like that. However, I stuck with adls for a long which might because I don't know how to get all config addressed in server.properties. Please suggest me

configuration parameters:
adls.storageAccountName.0=
adls.tenantId.0=
adls.clientId.0=
adls.clientSecret.0=```

You just have to create a service principal and give him blob contributor rights.
Afterwards you supply spark with the packages mentioned in my post and use abfss paths.

I already config and implement like you do, but it still doesn't work. There are the detail if I do sth wrong plz tell me

I have storage account both blob and data lake storage, and I already assign
Storage Blob Data Contributor role on both storage accounts with service principals
I config server.properties file in unity catalog oss with the following

adls.storageAccountName.0=https://<blob_storage_account_name>.blob.core.windows.net
adls.tenantId.0=<my_tenant_id>
adls.clientId.0=<service_principal_client_id_1>
adls.clientSecret.0=<service_principal_secret_1>

adls.storageAccountName.1=abfss://<data_lake_storage_account_name>
adls.tenantId.1=<my_tenant_id>
adls.clientId.1=<service_principal_client_id_2>
adls.clientSecret.1=<service_principal_secret_2>

Then, I implement the following according to documentation

cd ~/unitycatalog/
bin/start-uc-server

cd ~/spark-3.5.3-bin-hadoop3
bin/pyspark --name "azure-uc-test" \
    --master "local[*]" \
    --packages "org.apache.hadoop:hadoop-azure:3.3.6,io.delta:delta-spark_2.12:3.2.1,io.unitycatalog:unitycatalog-spark_2.12:0.2.0" \
    --conf "spark.sql.extensions=io.delta.sql.DeltaSparkSessionExtension" \
    --conf "spark.sql.catalog.spark_catalog=io.unitycatalog.spark.UCSingleCatalog" \
    --conf "spark.sql.catalog.unity=io.unitycatalog.spark.UCSingleCatalog" \
    --conf "spark.sql.catalog.unity.uri=http://localhost:8080" \
    --conf "spark.sql.catalog.unity.token=" \
    --conf "spark.sql.defaultCatalog=unity"

Finally, I done follow what you do

data = [("Alice", 34), ("Bob", 45), ("Cathy", 29)]
columns = ["Name", "Age"]
df = spark.createDataFrame(data, columns)
df.show()

STORAGE_PATH_1 = "https://<blob_storage_account_name>.blob.core.windows.new/<container_name>/<directory_name>"
df.write.format("delta").option("path", STORAGE_PATH_1).mode('overwrite').saveAsTable('unity.default.table1')

STORAGE_PATH_2 = "abfss://<data_lake_storage_account_name>/<container_name>/<directory_name>"
df.write.format("delta").option("path", STORAGE_PATH_2).mode('overwrite').saveAsTable('unity.default.table1')

have you tried with just using the storage account name instead like:
adls.storageAccountName.0=<blob_storage_account_name>
Also check that your installed package org.apache.hadoop:hadoop-azure:3.3.6 is based on the correct hadoop version.
I used org.apache.hadoop:hadoop-azure:3.4.1


Add CONTRIBUTING.md

Adding CONTRIBUTING.md for easier contribution support since the contributing section of readme.md was repititive.

Thanks for contributing @Sam6900


Note that make.biom creates v1.0 biom files

I created a biom file with make.biom, then attempted to import it into QIIME2.
It worked when I specfied Biom format v1.0, but not v2.1.

@mothur-westcott could you double check this? I thought that the added library got us to v2

The biom.info command can read version 2.0 and convert it to mothur formatted files. Mothur does not currently create 2.0 files. The make.biom command creates a version 1.0 biom file. Do you want me to add an issue to change this?

Yeah, that would probably be good to have.

On Oct 19, 2020, at 9:24 AM, Sarah Westcott<EMAIL_ADDRESS>wrote:
The biom.info command can read version 2.0 and convert it to mothur formatted files. Mothur does not currently create 2.0 files. The make.biom command creates a version 1.0 biom file. Do you want me to add an issue to change this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mothur/mothur.github.io/pull/47#issuecomment-712153880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJUUBDIB56TTG3Z4JSWUBTSLQ4YTANCNFSM4SVM6DOA.


SLVUU-50: Add E2E tests for Layout Management

Description
Adds end-to-end Cypress tests covering the saving and re-loading of user-defined layouts.
Change List

Add end-to-end tests
Update page object model to facilitate testing
Give toast notifications "status" role

Notes
These tests will run on the pipeline using the local implementation of layout management. An extra step should be added to the GitHub action to adjust the environment variable and re-run the tests using the remote implementation.

PR raised to Finos


Added Mogee

Added the game I have created for the https://itch.io/jam/lowrezjam2016, check the submission here: https://unsoundscapes.itch.io/mogee

Thanks Andrey, this is awesome!


Add docker in script

[ ] script in package.json
[ ] bin file

https://github.com/HsuTing/generator-cat/commit/314d4caa9b8e6d708cd0cff80639ac60d3d52b00


Add Connector for Azure OpenAI Text

Description
Fixes https://github.com/wso2-enterprise/choreo/issues/19293
Related Pull Requests

Pull request 1

One line release note:

Adds connector for Azure OpenAI Text

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Ballerina Version: 2201.4.1
Operating System: Ubuntu 22.04.1 LTS
Java SDK: openjdk version "1.8.0_362"

Checklist:
Changes to OpenAPI definition

[x] Modified info section of the OpenAPI definition file - Example

description - what the connector is about
x-ballerina-init-description OpenAPI extension - connector initialization details
x-ballerina-display OpenAPI extension - connector name and path to the connector icon

[x] Added proper description each API Key, if API Key authentication is defined in OpenAPI definition file

Changes to connector module

[x] Added license header at the top of each .bal file.
[x] Added Package.md as per the guide here
[x] Added Module.md for the module of the  connector as per the guide here
[x] Added connector icon to the root of the connector. Icon needs to be a png of 200x200 px size with name icon.png
[x] Added Ballerina.toml file with following information. For keywords refer to guide

Verifying connector module

[x] Compiled the connector successfully with the targeted ballerina version.
[ ] Conducted smoke tests on the connector (Recommended when OpenAPI definition is obtain from an unofficial source)

Security checks

[x] Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines?
[x] Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dulaj Prabasha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Express server not receiving whole files (sometimes)

The issue:
I have an app in production where the front end is React, and the api is express.  One of the app pages is a video upload page, that sends the file to the api (both are served through nginx).  The video file (as written to the /tmp dir) is then loaded into fluent ffmpeg and converted, uploaded to storage server, etc.
I began getting reports that the upload function was not working.  Digging into this, I took note of the file size transmitted from the react app, and the size of the file received in express.  The react app always shows that sent bytes === total bytes.
The express api shows (sometimes -- specifically in instances where the function later fails in the conversion step), that not all bytes are always received.  It happens about half the time.  Sometimes the entire file is received.
Initially I was using multiparty, but in my troubleshooting I've replaced that with busboy, then formidable, and the same thing is happening with all of those.  I'm not sure if it is, but it seems like an issue with express.  Currenty using express 4.16.4
I'm experiencing the issue on multiple servers.  The production server, AND a beta server, AND my local development pc.
OS: Ubuntu 20.04 (both servers) Windows 10 (development pc) macOS 12 (other developmetn pc)
Running express with: pm2 (servers), npm start (pc)
web server: nginx (servers), none (pc)
The specific issue that occurs is during the ffmpeg conversion, it errors out with "invalid data found while processing this file" because some important flags are usually stored at the end of video files, and that part of the file isn't available.  Videos range in size from 15mb to 300mb and doesn't seem to have impact on the failure rate of this specific route.
I know there's a lot of variables here, but I'm hoping someone can help me with this.  I have tried EVERYTHING (I can think of), and nothing is fixing it.
Here is my package.json file if that is helpful..  Idunno.
{   "name": "f21-api",   "version": "0.0.0",   "private": true,   "scripts": {     "start": "node ./bin/www"   },   "dependencies": {     "@ffmpeg-installer/ffmpeg": "^1.1.0"<EMAIL_ADDRESS>"^1.0.1",     "aws-cloudfront-sign": "^2.2.0",     "aws-sdk": "^2.951.0",     "bcrypt": "^5.0.1",     "busboy": "^0.3.1",     "cluster": "^0.7.7",     "cookie-parser": "~1.4.4",     "cors": "^2.8.5",     "dayjs": "^1.10.6",     "debug": "~2.6.9",     "express": "~4.16.1",     "express-busboy": "^8.0.0",     "express-fileupload": "^1.2.1",     "express-formidable": "^1.2.0",     "express-ws-routes": "^1.1.0",     "farmhash": "^3.2.1",     "ffmpeg-extract-frames": "^2.0.2",     "ffprobe": "^1.1.2",     "ffprobe-static": "^3.0.0",     "fluent-ffmpeg": "^2.1.2",     "formidable": "git+https://github.com/node-formidable/formidable.git",     "get-video-dimensions": "^1.0.0",     "hls-ffmpeg": "0.0.9",     "http-errors": "~1.6.3",     "jsonwebtoken": "^8.5.1",     "lodash": "^4.17.21",     "mandrill-api": "^1.0.45",     "mongoose": "^5.13.3",     "morgan": "~1.9.1",     "multiparty": "^4.2.2",     "nodemailer": "^6.6.3",     "pdfkit": "^0.11.0",     "redis": "^3.1.2",     "sharp": "^0.25.4",     "shelljs": "^0.8.4",     "socket.io": "^3.1.2",     "socket.io-redis": "^6.1.1",     "stripe": "^8.164.0",     "ws": "^7.5.3",     "xlsx-to-json": "^0.3.0",     "xml2js": "^0.4.23"   } }

Unfortunately express itself is not involved in the transfer of bytes; express is a routing layer on top of the Node.js http server. The various modules you are using read the bytes directly from the Node.js http server; express is not actually involved, unfortunately. If you are not getting the entire file, it is either something wrong in Node.js http server or in one of the intermediate proxies.
If you can provide an example app and the exact steps to reproduce the issue with the app, I can help track down what is happening, though, even if that is ultimately to report a bug to Node.js. Without a reproduction case provided, the best I can say is that I run a site that does something very similar to what you described (uses multiparty for the parsing) and have never had such an issue.

  Turns out nginx was the problem.  Once I traced it to that, I replaced nginx with apache and everything works fine now.

It's no problem, glad you got is solved! And don't think you are an idiot; we all start somewhere and no one knows everything.


Double Strike - Value Error

new double strike values have not yet been updated

Seems like new gems are not in PoB yet.

Seems like new gems are not in PoB yet.

ahh ok "/