EBCDIC to ASCII conversion on column level redefine fails on json conversion

When there is a column level redefine in the copybook the ascii conversion is not able to parse the file properly.
DIFSDB.zip

Hi. It seems there is a gap in the copybook parser.
I've created this rule:
"transf-rule": [
    {
        "offset": 29,
        "size": 2,
        "hex": "f2f0",
        "transf": "transf1"
    }

And changed the following "transf1" node:
        {
            "type": "zd+",
            "bytes": 7,
            "offset": 133,
            "dplaces": 2,
            "name": "DB-CK-AMT",
            "part-key": false,
            "sort-key": false
        },

Attached is the changed meta data file:
/Users/luisdant/Downloads/DIFSDB (1)/mainframe-data-utilities/DIFSDB-list.json
PS, I still need to check the DB-CK-SEVERITY-CODE.

Thank you so much Luis.We will try to parse the file after changing the json file.
From: Luís Gustavo Dantas @.>
Sent: Tuesday, April 19, 2022 7:17 PM
To: aws-samples/mainframe-data-utilities @.>
Cc: anilcert @.>; Author @.>
Subject: Re: [aws-samples/mainframe-data-utilities] EBCDIC to ASCII conversion on column level redefine fails on json conversion (Issue #3)
Caution: This email originated from outside Capco. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hi. It seems there is a gap in the copybook parser.
I've created this rule:
"transf-rule": [
{

    "offset": 29,

    "size": 2,

    "hex": "f2f0",

    "transf": "transf1"

}

And changed the following "transf1" node:
    {

        "type": "zd+",

        "bytes": 7,

        "offset": 133,

        "dplaces": 2,

        "name": "DB-CK-AMT",

        "part-key": false,

        "sort-key": false

    },

PS, I still need to check the DB-CK-SEVERITY-CODE.
—
Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/mainframe-data-utilities/issues/3#issuecomment-1103285036, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYXZKFR35VZK7E5PHD5PJTLVF5EI5ANCNFSM5TZ4DZKA.
You are receiving this because you authored the thread.Message ID: @.***>

It seems that there are actually 2 decimal fields within DB-CK-SEVERITY-CODE.

I've split into 2 fields and the result file looks good.

This weekend I'll make a quick change in the code to consider the "upper case" and "lower case" hexadecimal values in the transformation rule (e.g. F2F0 and f2f0), and I'll document the REDEFINES gap on readme file.
Please, let me know if the workaround is ok for now and I'll close the issue.

Updated the copybook to split the DB-CHK-SEVERITY-CODE into 2 fields.
Edited the json file with transformation rule added and 'transf1' for DB-CHK-AMT.
But the output is not matching with the one you got.I am attaching files for your reference.

Masked.zip

Hi Anil,
I'm sorry. I forgot to mention. I've found the same problem, and it worked well when I changed the DB-CHECK-RMKS1 from PIC X(30) to PIC X(29). Would it be bad data?
Attached are the changed copybook and the corresponding json.
difsdb3.zip
Best Regards
Luis

We analysed the output ASCII and have questions to the client as the copy book has a mismatch with the data in  "DB-CHK-SEVERITY-CODE" and waiting for the response.

Anil,
As suspected I found an issue in the data item length calculation, which was happening with packed-decimals having 3 figures or less.
The version available now has processed the DFISMAST file. I just had to manually change that unsupported redefines data item.
Attached are the copybook, json list and result ASCII file. Can you please review?
DIFSMAST.zip

We are able to  convert the packed decimal values properly now after the fix.
Thank you


Review checklist

Adds a review checklist to CONTRIBUTING.md. Impetus: we would have missed some stuff on #738 if not for Carl's sharp eyes: https://github.com/riptano/cassandra-dtest/pull/738#issuecomment-170140677
Should be uncontroversial -- I've tried to just document our existing review process here. @ptnapoleon, and any other interested parties, to review.

I think it looks fine? If only we had some sort of meta-review checklist.

If only we had some sort of meta-review checklist.

Huh?

Huh?
http://lmgtfy.com/?q=humor

I'm +1

Huh?

http://lmgtfy.com/?q=humor

Some helpful stuff at this link, thanks!

Thanks for the review, merging.


feat(camera_view_plugin): add camera view plugin package

Description
In testing the system, sometimes frequently switching from a third-person view following the vehicle and a bird-eye view focusing on the vehicle is needed.
This PR adds two buttons RViz plugin for convenient switching between the two views.
Related links
https://github.com/autowarefoundation/autoware.universe/pull/5469

Tests performed
PSim

Notes for reviewers

Interface changes
Because operation view only makes sense when it is looking at the vehicle. So in code we force the target frame of operation view  being base_link .

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Owen-Liuyuxuan
Could you change the file name and plugin name to more generic name?
ex.
operation_view -> third_person_view
route_set_view -> bird_eye_view

@tkimura4 Sorry I may have interrupted the auto-merge with a commit to fixing the license problem.

@Owen-Liuyuxuan
Could you check https://github.com/autowarefoundation/autoware.universe/actions/runs/6741712068/job/18326863638?pr=5472 ?

@Owen-Liuyuxuan Could you check https://github.com/autowarefoundation/autoware.universe/actions/runs/6741712068/job/18326863638?pr=5472 ?

I know that normalise should considered as a common spelling error that needs to be fixed. But it seems to be a library function https://www.ogre3d.org/docs/api/1.7/class_ogre_1_1_vector3.html#a9e572a5cc4e1ed826839e5281d8f1d3b

The spell-check-partial action succeeded.
https://github.com/autowarefoundation/autoware.universe/actions/runs/6742722495/job/18387566275?pr=5472


setEquality on List field

im trying to set equality filter on a grid but i can only get it to work on a simple int field like ID. But how do i do it when i want to check if a List field contains a value?
Again the feeling of missing something simple :/
this.setEquality(Hub.ListingRow.Fields.UserID, 1); // this works on a simple id field
this.setEquality(Hub.ListingRow.Fields.UserList, [1,2]); // but when its a list it doesnt

#1513
i feel thats in the direction but i coldnt get it to work...

maybe an easier way to explain my issue:
i have this field
[DisplayName("Users")]         [LookupEditor(typeof(UserRow), Multiple = true), NotMapped, LinkingSetRelation(typeof(UserListingsRow), "NumListingId", "UserId")]         public List<Int32> UserList         {             get { return Fields.UserList[this]; }             set { Fields.UserList[this] = value; }         }
this is the field i need to setequality on. so if this relation field contains the currently logged in user then show the record, if not filter it out.

pass an array as value. it will search with IN filter not equals


Add service account token authentication from k8s config

This show an example of how authenticate using kubernetes configuration file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Coap-proxy-websocket: use localhost as default address of endpoint server

I suggest to use localhost:8000 as default address of endpoint ws server instead of wot.city in /lib/coapServer/server.js. It is easier for newer to test code straightforwardly without adding any code. Also, add a doc of usage.

Use localhost:8000 is the best implementation.


Invalid "requirements_file": path docs/requirements.txt does not exist error

Details

Read the Docs project URL: squiggle.readthedocs.io
Build URL (if applicable):
Read the Docs username (if applicable):

Expected Result
Build to succeed
Actual Result
Problem parsing YAML configuration. Invalid "requirements_file": path docs/requirements.txt does not exist error
This is particularly strange because the repo clearly has a docs/requirements.txt file. What could be causing this?

Update: I just triggered a new build on a repo (i.e. no changes) that had worked as of three hours ago and now it is failing with the same error:
http://readthedocs.org/projects/freqgen/builds/7495641/
Could this be related to either #4377 or the GitHub outages today?

As a data point same thing is happening to me. Only change in my code is a version number and a new tag. https://readthedocs.org/projects/flask-jwt-extended/builds/
Glad it's not just me, I thought I was going crazy for a second :+1:

Sorry people, I'm trying to replicate this locally right now. But I think I know where is the bug.

I can't replicate this locally (I think this is something to do with the builds being executed in another server). This was introduced in https://github.com/rtfd/readthedocs.org/pull/4298.
But, I think I know where the bug is, I'll send a PR soon. If you need your docs now, a workaround is using a configuration file https://docs.readthedocs.io/en/latest/yaml-config.html.

The fix is ready https://github.com/rtfd/readthedocs.org/pull/4379, let's hope the rtd team can review/deploy that soon.

The fix to the similar issue #3140 included: (1) a change in the RTD "search for configuration file logic" to use one in the repository root folder if found; and (2) explicitly including a configuration file in the root folder to preclude use of other yaml files found deeper within the repo and/or git submodule repositories collected during the build process.  For example, a root folder configuration file https://gerrit.onap.org/r/gitweb?p=doc.git;a=blob;f=readthedocs.yml;h=6e6b9af07e6d523a60342e76bf181288bf826c63;hb=HEAD

#4379 is now out. Raise a new issue if you are noticing any similar issues.


Kwxm/flat/canonincal data encoding (PLT-9705)

As described in https://github.com/IntersectMBO/plutus/issues/5852, the flat encoding of Data objects did not always have the canonical format described in the Plutus Core specification, which is arguably a bug. This should fix the problem.  See the code comments for details.  The actual fix only requires one extra word, but I've added some tests too.

Do we need to check that we still deserialize non-canonical things correctly? I think surely we must, otherwise everything would be broken.

Do we need to check that we still deserialize non-canonical things correctly? I think surely we must, otherwise everything would be broken.

Good point.  We certainly do deserialise non-canonical things correctly, but we don't have a test for that.    They definitely do get serialised non-canonically because if you take out  the toStrict added in this PR then the new canonicity test fails occasionally (I had to set the limit to 10000 to get that to happen consistently though).


Slack-like mention plugin

User Behavior
User should be able to use whitespace to search another user to mention. See example below on Slack:
search_with_whitespace.webm
Feature Value
In apps like Slack, whitespace can be utilized to search for users by both first name and last name. This feature is particularly helpful in workspaces with many users, especially when several users have the same first name.
Additional context
Super Editor offers StableTagPlugin but I don't think it can support the use case above. I naively tried to implement it by tweaking the user TagRule, using double whitespace as escape character instead of single whitespace.
TagRule(trigger: '@', excludedCharacters: {"  ", "."})
It looked initially promising. However, it has created an issue where it's now unclear whether the user intends to mention someone or is just typing in the middle of a sentence.
See below, using UserTagsFeatureDemo with modified TagRule:
super_editor_user_tag_with_whitespace.webm
More specs we can observe from Slack
It seems in Slack the composing tag area is always between the trigger user entered and text user tapped after the trigger.
It keeps track of what text user typed after tapping the trigger.
On the other hand, current implementation of tags in SuperEditor uses TagFinder.findTagAroundPosition which looks for a tag around the cursor, starting with the tagrule trigger and ending with tagrule excluded characters. No matter if the text was typed by user or not.
Furthermore, on slack, you can see that if the composing tag value doesn't match any user, the app decides to commit it in an "unknown state" (with dots and question mark around). This way when the cursor goes back in this tag, the search can continue.
https://github.com/superlistapp/super_editor/assets/6229343/3aa53d38-4882-45c1-95c4-95f6ec06ea71
I'll be happy to continue discussing the feasibility of this feature. I'm wondering if in order to accomplish it we need to mimic all specs from slack search.

@BazinC - I broke this ticket down into the following:
#1986
#1987
#1988


[BUG] Feedback Page

Description
The Feedback Page of the Website is very basic and has very less user interactivity.
Screenshots

Any additional information?
I will make a very good feedback form
What browser are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

I have made a PR with respect to this Issue. Kindly, check.
PR: #475


Multiple gaps in data for MID/stream

Describe the issue
Multiple gaps in data for MID/stream.
Steps to Reproduce
Steps to reproduce the behavior:

Open the MID_Gaps.csv file attached
Column A is "Last startTime before the gap"
Column B is "Following startTime after the gap"
Column C is gap duration in minutes
Column E is "Start of the Gap startTime"
Column F is "End of the Gap startTime"
Column G is number of expected missing entries ei. settlementPeriods. Keep in mind there are two dataProviders and I expect each will have a value for specific settlementPeriod
Click on column H's link, that will show link where the gap is found

Expected behaviour
Expected is to see data for two dataProvider for every settlement period (startTime every 30 minutes) for links listed in column H.
Observed behaviour
Data is missing for specified time intervals for both dataProviders.
HTTP requests/responses
If applicable, add HTTP requests and/or responses to help explain your problem.
Additional context
All of the API requests are listed in MID_Gaps.csv H column. You can use any of them to see the gap.
Checks
Please answer the following questions for yourself before submitting an issue.

[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I'm reporting the issue to the correct repository
[x] I'm reporting a problem and not a feature request
[x] I have added the correct labels
[x] I have added screenshots or other relevant evidence (if applicable)

MID_Gaps.csv

Thank you for your enquiry,  this is being investigated.
Please do contact<EMAIL_ADDRESS>further further support


chore(litmus-portal): Subscription fixes, added functionality to workflow table and created the schedules table.

Proposed changes
This PR add:

Subscription fixes in the Workflow Table.
Added search, filter and sort functionality in Workflow Table.
Created the Schedules Table and a separate route to edit the scheduling of a workflow.
Added Types for WorkflowRuns
Changes in GraphQL schema in frontend.

Issues solved with this PR #1925 #1926
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

/run-unit

/run-unit


Facing "panic: assignment to entry in nil map" when trying to export otlp logs to google cloud

i have the following configuration for my otel collector
extensions:
  health_check:
  pprof:
    endpoint: <IP_ADDRESS>:1777
  zpages:
    endpoint: <IP_ADDRESS>:55679

receivers:
  otlp:
    protocols:
      grpc:
      http:
        endpoint: <IP_ADDRESS>:4318
        cors:
          allowed_origins:
            - "*"

processors:
  batch:

exporters:
  logging:
    loglevel: debug
  googlecloud:
    retry_on_failure:
      enabled: false
    project: project-name
    log:
      default_log_name: opentelemetry.io/collector-exported-log

service:
  telemetry:
    logs:
      level: debug
  pipelines:
    logs:
      receivers: [otlp]
      processors: [batch]
      exporters: [logging, googlecloud]

  extensions: [health_check, pprof, zpages]

When I run the collector with just the loggin exporter in my logs pipeline, things work fine and i can see the logs in the otel stdout, but when i run it with googlecloud exporter, i get the following error
panic: assignment to entry in nil map

goroutine 145 [running]:
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector.logMapper.logToSplitEntries({{0xc000682420}, {{{0xc00029a2a0, 0x27}, {0x0, {...}, 0x0}}, {0xc0009c9818, 0x11}, {0x4c4bb10, 0x2b}, ...}, ...}, ...)
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector@v0.30.2-0.20220512190557-875976f87023/logs.go:288 +0xd7
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector.logMapper.createEntries({{0xc000682420}, {{{0xc00029a2a0, 0x27}, {0x0, {...}, 0x0}}, {0xc0009c9818, 0x11}, {0x4c4bb10, 0x2b}, ...}, ...}, ...)
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector@v0.30.2-0.20220512190557-875976f87023/logs.go:201 +0x431
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector.(*LogsExporter).PushLogs(0xc000878900, {0x5492a30, 0xc000c42210}, {0x0?})
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector@v0.30.2-0.20220512190557-875976f87023/logs.go:133 +0xbb
go.opentelemetry.io/collector/exporter/exporterhelper.(*logsRequest).export(0x7fe726bbb8e0?, {0x5492a30?, 0xc000c42210?})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/logs.go:65 +0x34
go.opentelemetry.io/collector/exporter/exporterhelper.(*timeoutSender).send(0xc000c84a50, {0x54a5d40, 0xc000c421b0})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/common.go:225 +0x96
go.opentelemetry.io/collector/exporter/exporterhelper.(*retrySender).send(0xc0003f3200, {0x54a5d40?, 0xc000c421b0?})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/queued_retry.go:147 +0x156
go.opentelemetry.io/collector/exporter/exporterhelper.(*logsExporterWithObservability).send(0xc000910498, {0x54a5d40, 0xc000c421b0})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/logs.go:131 +0x88
go.opentelemetry.io/collector/exporter/exporterhelper.(*queuedRetrySender).start.func1({0x472ba20?, 0xc000c421b0})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/queued_retry_inmemory.go:119 +0x5c
go.opentelemetry.io/collector/exporter/exporterhelper/internal.consumerFunc.consume(0x0?, {0x472ba20?, 0xc000c421b0?})
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/internal/bounded_memory_queue.go:82 +0x2c
go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers.func2()
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/internal/bounded_memory_queue.go:69 +0xcd
created by go.opentelemetry.io/collector/exporter/exporterhelper/internal.(*boundedMemoryQueue).StartConsumers
	go.opentelemetry.io/collector@v0.53.0/exporter/exporterhelper/internal/bounded_memory_queue.go:63 +0x98

I'm facing this same error in local as well as production environments.
as far as i can tell this error only occurs when using the google cloud exporter for exporting logs. Exporting traces seems to be working fine.

What version of the collector are you using?
cc @damemi

What version of the collector are you using?

stack trace looks like its 0.53.0, which I think is pinned to v0.31.0 (v0.30.2-0.20220512190557-875976f87023)? That would point to this line that gets the log attribute: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/v0.30.1/exporter/collector/logs.go#L228
Maybe we should check for log.Attributes() to be nil before calling Get() on it

Sorry I misread the log line, it's probably actually referring to this line where we assign a label in a map. Working on a test and fix

@kushal-ti have you tried the attributes processor?

@damemi i'm really sorry to keep bothering you regarding this, but based on this

Maybe we should check for log.Attributes() to be nil before calling Get() on it

I assumed that if i added an attribute to my logs manually, using the attribute processor, before passing it to the googlecloud exporter it would have worked, but it still fails with the same error
This is my modified config
extensions:
  health_check:
  pprof:
    endpoint: <IP_ADDRESS>:1777
  zpages:
    endpoint: <IP_ADDRESS>:55679

receivers:
  otlp:
    protocols:
      grpc:
      http:
        endpoint: <IP_ADDRESS>:4318
        cors:
          allowed_origins:
            - "*"

  # Collect own metrics
processors:
  batch:
  attributes:
    # Override the default log name.  `gcp.log_name` takes precedence
    # over the `default_log_name` specified in the exporter.
    actions:
      - key: gcp.log_name
        action: insert
        value: otel-collector-pipeline

exporters:
  logging:
    loglevel: debug
  googlecloud:
    retry_on_failure:
      enabled: true
    project: codenation-186008
    log:
      default_log_name: app

service:
  telemetry:
    logs:
      level: debug
  pipelines:
    # traces:
    #   receivers: [otlp]
    #   processors: [batch]
    #   exporters: [logging]

    # metrics:
    #   receivers: [otlp]
    #   processors: [batch]
    #   exporters: [file]

    logs:
      receivers: [otlp]
      processors: [batch, transform, attributes]
      exporters: [logging, googlecloud]

  extensions: [health_check, pprof, zpages]

And I can confirm that the attributes are being added to my logs, but it still doesn't seem to work. For the moment i'm hacking my way around it by sending logs to fluent bit which then sends it to otel collector (these logs have attributes added to them automaitcally by the fluent bit receiver) and these can then successfully be exported to gcp, however, going forwards it will be difficult for me to use this hack everywhere and i would really appreciate if there was any way to export logs directly from my application to otel and then to GCP
I understand that there was some kind of bug in the current release, but is there anyway i can modify the structure of my logs to sidestep that bug ?

oh wait, so it's not the attributes but the labels that is messing things up ? Is there any way i can set instrumentationSource and instrumentationVersion to be empty strings so that the if conditions causing the errors never get triggered ? @damemi

oh wait, so it's not the attributes but the labels that is messing things up

Yeah I misread the stack trace at first and was looking at the wrong line. But the instrumentation source and version come directly from the log scope. I don't know if there's a way to directly modify those (since it's not just a label or attribute), maybe with the transform processor.


Download metrics scores in csv

Today, I (well, @mjpost) wanted to download all WMT15 BLEU scores from wmt.ufal.cz. It would be nice to have a button for downloading a csv file where
lines = all systems (tasks) from all experiments
columns = experiment_name, task_name, task_description, all metrics scores
The header line should include the metrics names.
One could imagine a configuration dialog where the users select which metrics and which experiments/tasks they are interested in, but I think that's not worth the work. The users can filter the csv themselves (e.g. by importing it to Excel).

Done in c41599066b7c947ff5fa90ef88c29f539acc1917.


The sky loves a good joke

This PR is a significant step towards fast autocorrection. The big optimization here is running all auto-correcting cops separately from non-autocorrecting cops.
When there are a number of offenses, the whole inspection process can be repeated many times, with just the autocorrections from a single cop applied on each round. This means that the non-autocorrecting cops (redundantly) perform inspection many times, when all we care about is what they find on the last round.
In a couple of performance tests, I observed this optimization to knock about 1/3 off of total runtime when autocorrecting.
When working on this optimization, I made a discovery. We are mangling our ASTs, so they can only be traversed a single time.
This is not the way it should be. The ASTs are supposed to be mutable. BUT, there are these fateful lines in ast_node.rb (which we inherited from Astrolabe):
      each_child_node do |child_node|
        child_node.parent = self
      end

Because of these lines, just instantiating a temporary AST node mutates any existing nodes which you give it as children, causing those children to "lose" their original parent and point to a new parent. The old parent still points to its original child, but the child doesn't point back. Our AST has become an "ASG" (for "graph").
VariableForce caused this to happen by instantiating temporary nodes. But what really ravaged the ASTs was Commissioner, and its use of AST::Processor to traverse an AST. Processor is designed, not for traversing an AST, but for transforming one. After each hook returns, it optionally initializes a new node.
I have fixed things up so that ASTs are not mutated after being completely initialized. This makes it possible to split up the inspection process into stages.

In a couple of performance tests, I observed this optimization to knock about 1/3 off of total runtime when autocorrecting.

Awesome performance boost. I am all for anything performance related.

Added a few performance tweaks. Each of them gains a small amount, nothing huge.

@lumeet Updated to catch config for obsolete SpaceAfterControlKeyword and SpaceBeforeModifierKeyword cops.

One thing here about VariableForce. I found that it was mutating the AST by wrapping it in a begin node. So I modified it so that it doesn't require the AST to be rooted in a begin node, but can work with any type of node as the root.
Another option would be to modify ProcessedSource so it guarantees that ASTs are always rooted in a begin node.

Apart from my tiny remarks and the stalled build - the changes look good.

stalled build

It's passing.

Renamed nodoc? to has_nodoc_comment?. Added comment in Team as requested by @bbatsov.

Let's just confirm that the build passes.

:-(

Renamed nodoc? to has_nodoc_comment?. Added comment in Team as requested by @bbatsov.

Btw, I was thinking of just nodoc_comment?.

It didn't like has_nodoc_comment?, using nodoc_comment? instead.

Should pass this time.

:+1:


Usage failure

drf-rw-serializers version: 0.1.0
Django version: 2.0.3
Python version: 3.6.4
Operating System: macOS High Sierra 10.13.3

Description
Read/write serializers not being called. I've traced it into generics.py, but don't see it going through the mixins ever...
What I Did
I implemented drf-rw-serializers, put them in installed apps, imported them and went through your usage documentation.
Quit the server with CONTROL-C.
Internal Server Error: /
Traceback (most recent call last):
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/django/core/handlers/exception.py", line 35, in inner
    response = get_response(request)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/django/core/handlers/base.py", line 128, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/django/core/handlers/base.py", line 126, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/views.py", line 494, in dispatch
    response = self.handle_exception(exc)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/views.py", line 454, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/views.py", line 491, in dispatch
    response = handler(request, *args, **kwargs)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/schemas/views.py", line 31, in get
    schema = self.schema_generator.get_schema(request, self.public)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/schemas/generators.py", line 286, in get_schema
    links = self.get_links(None if public else request)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/schemas/generators.py", line 324, in get_links
    link = view.schema.get_link(path, method, base_url=self.url)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/schemas/inspectors.py", line 182, in get_link
    fields += self.get_serializer_fields(path, method)
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/schemas/inspectors.py", line 302, in get_serializer_fields
    serializer = view.get_serializer()
  File "/Users/user/workspace/django-dapi/lib/python3.6/site-packages/rest_framework/generics.py", line 112, in get_serializer
    return serializer_class(*args, **kwargs)
TypeError: 'NoneType' object is not callable

@hugobessa Would we need to subclass a BrowsableApiRenderer?
Have you started working on this yet?

exactly @meiralins, subclass a BrowsableApiRenderer... and no, I couldn't start working on that yet :frowning_face:

@hugobessa I noticed that if get_serializer_class returns the proper serializer based on the HTTP Method, everything seems too work fine. Turns out the BrowsableApiRenderer does some hacky stuff for it to work like that.
Also, if you adopt this behavior you could delete a lot of code from this repository.
I wonder if I am missing some edge case. =)


Update rooms-prep.md

Replace the note about HDCP for HDMI ingest (not the right place in the documentation set) with a note about supportability statement around proxy authentication.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


(maint) Two minor pcore resource type related things

Details in the commits.

Good to merge - not sure if we have master branch lookdown or not (marked Blocked). I am +1 on merging if there is no Block, or when block lifts.

CLA signed by all contributors.


"Ink" Items in ListView are not cropped properly

Observed behavior:
The decoration of "Ink" widgets that are positioned outside of a ListView is being painted.
Expected behaviour:
The decoration is cropped in the same way all the other contents are.
Minimal example:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Column(
          children: <Widget>[
            SizedBox(height: 500, child: Container(color:Colors.black45)),
            Expanded(
              child: ListView(
                children: <Widget>[
                  InkItem(),
                  InkItem(),
                  InkItem(),
                  InkItem(),
                  InkItem(),
                  InkItem(),
                  InkItem(),
                  InkItem(),
                ],
              ),
            )
          ],
        ),
      ),
    );
  }
}

class InkItem extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Ink(
      decoration: BoxDecoration(
        borderRadius: BorderRadius.circular(5),
        color: Colors.black12,
      ),
      child: SizedBox(height: 100, child: Center(child: Text("Item"))),
    );
  }
}

Just revisited this, and noticed that the mandatory Material parent widget was missing for the Inks.
Maybe there will be a feature for the linter or IDE to give hints for this in the future? Although I get that reading through the documentation of a widget before using it would be desirable, in practice it is unlikely and might be a common source for user errors that might be prevented by automated checks (just like Expanded complains when not a direct child of columns/rows, although I get that by using a Scaffold there technically IS a suitable parent Material).


NOTICKET Remove dist folder from repo and folders from npm

Love it @kamilio and @stefanbuck 😸 have switched over Audiences to this. Just some alterations here to what gets sent to npm and the repo. Feel free to contest!

Removes the /dist folder from the repo.
Added an .npmignore to not publish the src and test folders.

I'm undecided if I prefer white or blacklisting to specifiy the included project files see package.json docs.

That's awesome. I've committed the build file before we published it, for development. It is not needed anymore. Thanks buddy!

@stefanbuck I think it does not make any difference in projects of this size...


Mob accidentally attacked Mob

For example, when a Zombified Piglin attacks a player and tries to attack them, it may harm its own kind and lead to mutual attacks. I am not sure if this was intentional or accidental, but I will treat it as erroneous feedback. If my feedback is intentional design, please let me know

This is technically intended design, since the only thing that the custom attacks check are whether or not any hit mobs are allied to the attacker. For example, Illagers will not accidentally hit each other with the custom attacks, since they are considered part of the same team.
I can introduce a config option similar to the one Better Combat provides for players to fine-tune relations on a per-mob basis.

Fixed by 6b5b9e5. Be on the lookout for Better Mob Combat 1.1.2 which comes with brand new config options, and preset values for zombified piglins to not attack each other accidentally.


Writing a NaN to an integer variable gives inconsistent results upon subsequent read

Hi netCDF friends!  Question regarding netCDF-C behavior when writing NaNs to a integer variable.  I tested this with netCDF 4.8.1 on my Linux machine.  I see similar results on Windows.
In MATLAB and in my netCDF-C repro program (attached), if I create a netCDF integer variable and write a NaN to it, I see inconsistent results when reading the value back which I suspect is caused by undefined behavior in C library when converting a floating point type to integer type.  This stackoverflow post is similar to what I’m seeing:  https://stackoverflow.com/questions/3986795/what-is-the-result-of-casting-float-inf-inf-and-nan-to-integer-in-c.
Note MATLAB NaN is the IEEE arithmetic representation for NaN as a double scalar value.  Also, MATLAB stores all numeric values as double-precision floating point values.
So for example, if I create an int16 variable, write a NaN, then read it back, I get zero.  Because we're passing in NaN (a double) to ncwrite, we end up calling nc_put_var_double() and passing it the C value -nan as a double.  So when it gets into the netCDF library, and netCDF is trying to assign the NaN to an int16, I think the zero is the result of undefined behavior:
% write NaN to int16 variable
nccreate('ocean1.nc','temperature','Datatype','int16','Format','netcdf4');
ncwrite('ocean1.nc','temperature',NaN);
data = ncread('ocean1.nc','temperature')
data =
     int16

     0

Note that writing an int32 to a NaN gives a different, non-zero result:
% write NaN to int32 variable
nccreate('ocean2.nc','temperature','Datatype','int32','Format','netcdf4');
ncwrite('ocean2.nc','temperature',NaN);
data = ncread('ocean2.nc','temperature')
data =
     int32

     -2147483648

However, if I first cast the NaN to an int16, the internal are a little different - we end up calling nc_put_var_short (because we cast NaN to int16), and we pass in a value of zero (since in MATLAB, casting a NaN to an integer type always results in zero).  Thus in this case, we're basically writing a zero and reading a zero, which makes sense.
% write NaN to int16 variable but cast the NaN to int16
nccreate('ocean3.nc','temperature','Datatype','int16','Format','netcdf4');
ncwrite('ocean3.nc','temperature',int16(NaN));
data = ncread('ocean3.nc','temperature')
data =
     int16

     0

Here’s a summary of the behavior when writing NaN for all the integer types in MATLAB:
For uint8, uint16, uint32, int8, and int16, writing NaN writes zero.
For int32, writing NaN writes -2147483648.
For uint64 and int64, writing NaN writes -9223372036854775808.
My “nanTest.c” program (attached as text file) tests this with int16, int32, and int64 and shows the same behavior.
Question:   Is this expected behavior in the netCDF-C library?  Can you consider making the behavior consistent, such as returning zeros for all cases of writing a NaN to a variable defined as an integer, or giving a warning?
nanTest.txt

I looked at that stack overflow url. The claim is that all conversions of Nan
(and Inf) to integer are undefined. I do not think that netcdf-c does anything
so I assume this is done by the hardware or the C runtime library.

Thanks Dennis, that's what I thought - netCDF isn't doing anything special, it's just relying on the C behavior when converting NaNs to integer types.
My question at this point is whether you and your netCDF colleagues are going to leave the netCDF code as-is and close this out saying it's expected behavior, or if you consider it a bug and will modify the code to guard against cases where there is a NaN-to-integer conversion (and handle it in some way like always returning zero, or giving a warning, etc.).
Note this wasn't reported to us by a MATLAB customer - we found it during internal testing.

Hi @ellenjohnson.  This is a good question; we've certainly encountered other issues where undefined behavior was encountered.  It seems like we may need to raise an 'undefined behavior' warning.  Our general guide here is that it's better to raise a warning/error and let the user change the data, rather than quietly changing the data being written.
We'll need to figure out exactly how we want to address this, but 'the data being written/read is an unexpected value' is exactly the situation we want to avoid.

Thanks @DennisHeimbigner and @WardF for the quick replies!  I really appreciate it.  I'll add a comment to the bug we're tracking on our side that we're waiting for a fix from the netCDF developers.

Fixing this in the netcdf-c library may be costly. In effect,
we have to examine each value during conversion from float/double
to int to see if it is a NaN value.

My opinion is that the netcdf library should prioritize speed over numerical consistency. I think this is what most users want and expect, most of the time. The library uses the most efficient available hardware and software instructions for type conversion.
Therefore, result values can not be guaranteed for numerical exceptions such as NaN conversions, unless they are somehow guaranteed by hardware, C runtime, and IEEE numerical standards.
Applications that need full consistency should simply read or write only the original data type, and perform their own controlled type conversion.


fix: X dry run

Relates to:
Twitter dry run not working
Risks
Affects anyone working to improve their agents and trying to test their changes
Background
What does this PR do?
This PR reenables the TWITTER_DRY_RUN flag
What kind of change is this?
Bug fix
Documentation changes needed?
None
Testing

Where should a reviewer start?
It's straightforward enough to just look at the 4 lines :)
Screenshots
Before

After

Deploy Notes
N/A
Database changes
N/A
Deployment instructions
N/A

LGTM!


Contributor information for Eliot Lash/Pear Therapeutics

Here is the PR you requested.
I omitted my bitrise username. I don't feel comfortable with publishing this to the whole internet unless it's really necessary, as it seems like it would just open up a potential attack vector and not provide any useful information to the community. Also I was not sure how to specify that our organization should be credited with the contributor discount. I already sent you an email with the web link to our org in bitrise.
Thanks,
Eliot

Sure, no problem at all, this is perfect ;)
Thanks for your contrib! 🚀

Just one thing though, it was quite some time ago, could you please ping me again through email/onsite chat on Bitrise.io ?

Nevermind, found our previous conversation ;)

(just sent you the instructions there)


[BUG 🐞] only_today = true send all today update for

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Install telegram-rss
Set feeds setting only_today = true

Expected behavior
No duplicate post.
Desktop (please complete the following information):

Python Version 3.8
Version lates 0.8.0

Fixed on v0.8.1 release.
Please reopen this issue if still occured, thank you!


How to skip the semantic and corssfy api Request

hi there . i have question for you . due my country restriction i can't get semantic or crossfy api . is there way that in that i cant deactivated that and make request timeout longer?

Waiting for the solution, I encountered the same issue and couldn't access these two APIs. How should I modify the code to skip them?

set use_doc_details=False
settings = Settings(
  verbosity=3,
  parsing=ParsingSettings(use_doc_details=False)
)

This is not exposed! this is not in __init.py!


Token Helight Color Not Working Fine!

Type: Bug
I use the same settings in my windows laptop and mac. But vsccode in mac always show me the different syntax helight from windows. Windows version is exactily what I need and is correct helight. Bty, I find that inspect Editor tokens and scopes is different in macos vscode from windows.
language: C++ 17
Theme: GitHub Dark
settings json:
       "editor.tokenColorCustomizations": {
        "enabled": true, // enable for all themes
        "textMateRules": [
            {
                "scope": "comment.block",
                "settings": {
                    "foreground": "#62c27a"
                }
            },
            {
                "scope": "entity.name.function.preprocessor",
                "settings": {
                    "foreground": "#b74fe0"
                }
            },
            {
                "scope": "entity.name.function.macros",
                "settings": {
                    "foreground": "#b74fe0"
                }
            },
            {
                "scope": "keyword.control.directive",
                "settings": {
                    "foreground": "#687f8d"
                }
            },
            {
                "scope": "entity.name.function",
                "settings": {
                    "foreground": "#dbd40c"
                }
            },
            {
                "scope": "string.quoted",
                "settings": {
                    "foreground": "#c8e4d8"
                }
            },
            {
                "scope": "variable.other.local",
                "settings": {
                    "foreground": "#fba741"
                }
            },
            {
                "scope": "constant.numeric",
                "settings": {
                    "foreground": "#788ee0"
                }
            },
            {
                "scope": "comment.line",
                "settings": {
                    "foreground": "#41de7d"
                }
            },
            {
                "scope": "punctuation.separator.namespace.access.cpp.cpp",
                "settings": {
                    "foreground": "#8993d3"
                }
            },
            {
                "scope": "entity.name.class",
                "settings": {
                    "foreground": "#1d1d1d"
                }
            }
        ]
    },

I try all :
 {
                "scope": "entity.name.function.preprocessor",
                "settings": {
                    "foreground": "#b74fe0"
                }
            },
            {
                "scope": "entity.name.function.macros",
                "settings": {
                    "foreground": "#b74fe0"
                }
            },
{
                "scope": "entity.name.function",
                "settings": {
                    "foreground": "#dbd40c"
                }
            },

Macros and functions show the same color and Scape in mac. And variables never be helighted.
VS Code version: Code 1.87.2 (Universal) (863d2581ecda6849923a2118d93a088b0745d9d6, 2024-03-08T15:21:31.043Z)
OS version: Darwin arm64 23.3.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (0.50GB free)

Process Argv
--crash-reporter-id 1f5fcdd0-1d46-4d2c-8b1f-817b7e88448f

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

asciidoctor-vscode
asc
3.2.3

solidity
Jua
0.0.174

vscode-clang
mit
0.2.4

debugpy
ms-
2024.2.0

python
ms-
2024.2.1

vscode-pylance
ms-
2024.3.2

remote-ssh
ms-
0.109.0

remote-ssh-edit
ms-
0.86.0

cmake-tools
ms-
1.17.17

cpptools
ms-
1.20.0

cpptools-extension-pack
ms-
1.3.0

hexeditor
ms-
1.9.14

makefile-tools
ms-
0.9.10

remote-explorer
ms-
0.4.3

sqltools
mtx
0.28.1

sqltools-driver-mssql
mtx
0.4.2

shader
sle
1.1.5

cmake
twx
0.0.17

vim
vsc
1.27.2

json
Zai
2.0.2

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
ccp1r3:30993539
dsvsc020:30976470
pythonaic:30996667
dsvsc021:30996838
gd77d436:30999572

Can you also add a small code sample, and screenshots?
You say  Editor tokens and scopes is different. How so? Can you take screenshots of the two?

It seems that some settings might be causing this outcome, and I've ruled out plugins. I've encountered similar results using the same project on Windows as well. This project can compile successfully.

Need more information?

So what is wrong? All three screenshots show a function call and all of them are rendered with the same color as I would expect.

Syntax highlighting is only based on the structure of the program. It can't look up symbols and doesn't know that VK_MAKE_VERSION is macro.
To resolve symbols (possibly across files) a language server is needed. It will add 'semantic highlighting' on top of the syntax highlighting.
Looking at your screenshots, there's no semantic highlighting active here.

make sure you have a C++ language extension installed
make sure it is properly configured, e.g. knows the project setup
make sure semantic highlighting is not disabled. Note: Not all themes support that. Best to use the default themes for testing.

If that's all properly configured, you will see a semantic token section showing up in the Inspect editor scopes.. hover


[master branches] TextField brings up the keyboard and then closes the keyboard, the return key will be invalid.

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...

class MyHomePage extends StatefulWidget {
 MyHomePage({Key key, this.title}) : super(key: key);

 final String title;

 @override
 _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

 @override
 Widget build(BuildContext context) {
   return Scaffold(
     appBar: AppBar(
       title: Text(widget.title),
     ),
     body: Center(
       child: TextField(

       )
     ),
   );
 }
}

Expected results:
The return key should correspond normally.
Actual results:
The return key will be invalid.

Logs

[√] Flutter (Channel master, 1.22.0-2.0.pre.130, on Microsoft Windows [Version 10.0.19041.450], locale zh-CN)
    • Flutter version 1.22.0-2.0.pre.130 at C:\Users\me\AppData\Local\Android\flutter
    • Framework revision 12b7355da1 (82 minutes ago), 2020-08-29 07:28:03 -0400
    • Engine revision 3029dcd93e
    • Dart version 2.10.0 (build 2.10.0-76.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\me\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[!] VS Code (version 1.48.2)
    • VS Code at C:\Users\me\AppData\Local\Programs\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[√] Connected device (2 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows       • windows-x64 • Microsoft Windows [Version 10.0.19041.450]

Hi @xkeyC
I was unable to reproduce this issue on latest master channel.

Can you upgrade to master and try again
flutter channel master
flutter upgrade --force
flutter doctor -v

[✓] Flutter (Channel master, 1.22.0-2.0.pre.139, on Mac OS X 10.15.6 19G2021,
    locale en)
    • Flutter version 1.22.0-2.0.pre.139 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision c0ea00ed3f (82 minutes ago), 2020-08-30 22:20:16 -0700
    • Engine revision bada9fc5f3
    • Dart version 2.10.0 (build 2.10.0-76.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.6 19G2021
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      84.0.4147.135

! Doctor found issues in 3 categories.

Hi @xkeyC
I was unable to reproduce this issue on latest master channel.

Can you upgrade to master and try again
flutter channel master
flutter upgrade --force
flutter doctor -v

The return key can close the keyboard, but cannot return to the previous page or close the program.

[√] Flutter (Channel master, 1.22.0-2.0.pre.140, on Microsoft Windows [Version 10.0.19041.450], locale zh-CN)
    • Flutter version 1.22.0-2.0.pre.140 at C:\Users\me\AppData\Local\Android\flutter
    • Framework revision 6d1242dd4b (2 hours ago), 2020-08-31 03:53:04 -0400
    • Engine revision 784e6d746e
    • Dart version 2.10.0 (build 2.10.0-76.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\me\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[!] VS Code (version 1.48.2)
    • VS Code at C:\Users\me\AppData\Local\Programs\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[√] Connected device (2 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows       • windows-x64 • Microsoft Windows [Version 10.0.19041.450]

as the picture shows

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text(widget.title),
        ),
        body: Column(
          children: [
            TextField(),
            FlatButton(
                onPressed: () {
                  Navigator.push(context,
                      MaterialPageRoute(builder: (BuildContext context) {
                    return MyPage();
                  }));
                },
                child: Text("p2"))
          ],
        ));
  }
}

class MyPage extends StatefulWidget {
  MyPage({Key key}) : super(key: key);

  @override
  _MyPageState createState() => _MyPageState();
}

class _MyPageState extends State<MyPage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("p2"),
      ),
      body: Text("p2"),
    );
  }
}

I was able to reproduce this on latest master but not in current beta or stable channel. The issue is that the back button is completely broken on Android devices.
You can't even navigate to a second page and then navigate back to the first page.
Testing with Master channel

Testing with Stable/Beta channel

 Sample code
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Scaffold(
        body: Center(
          child: Builder(
            builder: (context) {
              return GestureDetector(
                  child: Text('Click here to navigate to a second page'),
                onTap: () {
                    Navigator.push(context,
                    MaterialPageRoute(builder: (_) => SecondPage())
                    );
                },
              );
            }
          ),
        ),
      ),
    );
  }
}

class SecondPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Second Page'),),
      body: Center(
        child: Text('You can\'t close this app\nby pressing back button.'),
      ),
    );
  }
}

 flutter doctor -v (master)
[✓] Flutter (Channel master, 1.22.0-2.0.pre.139, on Mac OS X 10.15.6 19G2021,
    locale en)
    • Flutter version 1.22.0-2.0.pre.139 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision c0ea00ed3f (82 minutes ago), 2020-08-30 22:20:16 -0700
    • Engine revision bada9fc5f3
    • Dart version 2.10.0 (build 2.10.0-76.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.6 19G2021
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      84.0.4147.135

! Doctor found issues in 3 categories.

 flutter doctor -v (beta)
[✓] Flutter (Channel beta, 1.21.0-9.2.pre, on Mac OS X 10.15.6 19G2021, locale
    en)
    • Flutter version 1.21.0-9.2.pre at
      /Users/pedromassango/dev/SDKs/flutter_beta
    • Framework revision 81a45ec2e5 (4 days ago), 2020-08-27 14:14:33 -0700
    • Engine revision 20a9531835
    • Dart version 2.10.0 (build 2.10.0-7.3.beta)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • Web Server (web)            • web-server    • web-javascript • Flutter
      Tools
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 84.0.4147.135

! Doctor found issues in 3 categories.

 flutter doctor -v (stable)
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.6 19G2021, locale en)
    • Flutter version 1.20.2 at /Users/pedromassango/dev/SDKs/flutter_stable
    • Framework revision bbfbf1770c (3 weeks ago), 2020-08-13 08:33:09 -0700
    • Engine revision 9d5b21729f
    • Dart version 2.9.1

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11
      (API 30) (emulator)

! Doctor found issues in 3 categories.

This same issue didin't reproduces on physical devices.

在物理设备上不会重现此相同问题。

No, I also have this problem on my Xiaomi device, it happened after waking up the keyboard.

This same issue didin't reproduces on physical devices.

No, I also have this problem on my Xiaomi device, it happened after waking up the keyboard.

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Builder(builder: (BuildContext context) {
        return Scaffold(
          body: ListView(
            children: [
              TextField(),
              FlatButton(
                  onPressed: () {
                    Navigator.push(
                        context, MaterialPageRoute(builder: (_) => SecondPage()));
                  },
                  child: Text("Click here to navigate to a second page"))
            ],
          ),
        );
      },

      ),
    );
  }
}

class SecondPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Second Page'),
      ),
      body: Center(
        child: Text('You can\'t close this app\nby pressing back button.'),
      ),
    );
  }
}

This screen recording may be more illustrative

@chinmaygarde @jason-simmons
Does this fix is on current master now? I'm still able to reproduce this on master (1.22.0-2.0.pre.161).

 sample code
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Scaffold(
        body: Center(
          child: Builder(
              builder: (context) {
                return GestureDetector(
                  child: Text('Click here to navigate to a second page'),
                  onTap: () {
                    Navigator.push(context,
                        MaterialPageRoute(builder: (_) => SecondPage())
                    );
                  },
                );
              }
          ),
        ),
      ),
    );
  }
}

class SecondPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Second Page'),),
      body: Center(
        child: TextFormField(initialValue: 'You can\'t close this page\nby pressing back button once this field is focused'),
      ),
    );
  }
}

 flutter doctor -v
[✓] Flutter (Channel master, 1.22.0-2.0.pre.161, on Mac OS X 10.15.6 19G2021,
    locale en)
    • Flutter version 1.22.0-2.0.pre.161 at
      /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision ba78539bdb (4 hours ago), 2020-08-31 19:13:04 -0700
    • Engine revision 165abef0a2
    • Dart version 2.10.0 (build 2.10.0-77.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 48.1.4
    • Dart plugin version 202.7206

[!] VS Code (version 1.48.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11
      (API 30) (emulator)
    • macOS (desktop)             • macos         • darwin-x64     • Mac OS X
      10.15.6 19G2021
    • Web Server (web)            • web-server    • web-javascript • Flutter
      Tools
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 84.0.4147.135

! Doctor found issues in 3 categories.

Yes, I just updated the latest master channel  and this problem still exists.

The fix has landed in the Flutter engine tree, so you will see it if you are building the engine locally.
It has not yet rolled into the prebuilt engine binaries.  See https://autoroll.skia.org/r/flutter-engine-flutter-autoroll for the current status of the engine->framework roller.


Does webview_flutter support post method?

I am not able to find any api to post data with url.
I have a situation where I need to post data to load a url
Does this library support post data?

Hi @eco4ndly
I see there's an open issue addressing the case you described.
Please follow up on that issue,
I'm closing the current one as duplicate.
If you disagree please write in the comments
and I will reopen it.
Thank you

Thanks @iapicca


clicking the notification on android with resume: true opens the app in a new session

when clicking the notification on android with the "resume" option on true, the app is opened in a new session (even if the previous activity is still running)

Me too. what is happening?, only on android.

This is not the case for me. I'm using Cordova v5.0.0 (w/ CordovaLib v4.0.0) on Android 5.1.

SOLUTION:
put in your androidmanifest.xml:


updated metabase (0.15.0)

Thank you for the contribution. It was merged directly as 5f68ed9485f041953000aa6de11ead4c4b722c80 to keep commit history cleaner. Your contribution is still credited to you.


Unable to install from CNApy installer

Hello, thank you for developing this!
I'm struggling to get the cnapy installer to work, I would prefer it as a standalone, and have tried the 1.0.9 version installer and it didn't work at all going into program files. I tried another time with an earlier version 1.0.8 (I think) into a hard drive file (just incase admin rights were the issue) - there it managed to download minianaconda, but not cna itself, before the installer window came up that it had successful installed, which seems to be timed. Is there a way of installing from the master file downloaded as a zip file? It maybe I have slow internet, and the connection isn't open long enough for it to be fully installed from the installer.
I have tried installing/ through anaconda from zipfile, but I'm not that confident coding; and I would prefer a standalone programme if possible.
Best wishes

Thanks @CrimsonCurlew  for reporting this issue.
@Paulocracy maybe you could have a look at this issue? :pray:
Looks like the latest version of CNApy switched to a new windows installer :+1:
I guess there are two things:

1st The installer should not report a successful install if it could not install properly.

2nd can we provide a stand alone installer for offline installation?
The aim of constructor is to build such stand alone installers.
Of course our old constructor based installer also needed an internet connection to pull the dependencies, which was also because some dependencies where not available on conda. But there has been some updates on the repositories since then ... so maybe it would worth checking again if it is possible to create a standalone installer?
Of such an installer would be huge :fearful:

Hello!
First of all sorry for my late reply, I've been sick for quite a long time :-|
It's right that the installer was changed starting with 1.0.8 because the old constructor-based installer just stopped working. The new installer itself is also open source and its source code can be found here.
@CrimsonCurlew The CNApy installer version for CNApy 1.0.8 is not up-to-date and might have more quirks than the new installer which is attached to CNApy 1.0.9. Therefore, I would suggest to retry the installer for CNApy 1.0.9. Alternatively, if this installer still doesn't want to work on your device and without having to set-up Python and git, you can try to install CNApy directly with Miniconda as described here.
For the installer of 1.0.9, I'd like to know if you get a specific error message in the installation process? It's true that the installer doesn't work if you select a folder which needs admin rights, therefore it is recommended to select a folder which doesn't need these rights. Additionally, the speed of your internet connection should not play any role in the success of the installation.
I'm also, as suggested by @sthiele, looking after whether an offline installer for CNApy is feasible.

Hello!
No worries, thank you for getting back. It might have been partially where I was installing it: in the programme files (where I should have admin rights)- 'An error occurred in a download process of the installation. Please make sure your internet connection works and retry the installation', I tried again downloading onto a external disk hard drive (as I am working on a laptop) and got 'Error whilst running installation process unknown error during the execution of the installation process. Please make sure you have access permissions on the selected installation folder' (it only downloaded the miniconda installer), so I decieded to try again in the documents folder ...as admin rights shouldn't be an issue - there it seemed to work, a black box with text came up, and it installed a desktop icon. However now when I click onto the desktop item, it doesn't work.
All three times it came up with a successful install message.
I shall have a look at the instructions for installing with Miniconda.... The final time; there were some warning messages about dependances for miniconda that came up very quickly, (too quickly to note down) I feel like it is almost there...

Hello again!
Thank you for sharing your further experiences :-) Thanks to that, I found a bug in the CNApy installer which caused it to show a "successful installation" message even if it wasn't successful :3 This should be fixed now. Furthermore, regarding your issue with the program files folder, I added a user-privilege-granting procedure to the installer right at the start of it.
You may download and try this new installer, just the old version, from the latest CNApy release 1.0.9.
I hope that it doesn't include the bug where CNApy is installed and shown at the desktop with a dysfunctional link, but fortunately a colleague of mine has the same problem and I'm trying to reproduce it with his help.
Regarding the Miniconda installation, dependency warnings are normal as long as they do not cause the installation process to stop. Did you follow the instructions of CNApy's README and if so, at which point does the Miniconda installation seem to fail?

Hello, I go it working following Miniconda instructions! So all good - it just didn't seem to work from miniconda when it was through the windows exe opening it up. I think the difference was when minconda opened after the windows exe, it downloaded less of the required dependancies, and following the miniconda instructions it downloaded more... unfortunately, I couldn't tell you the exact difference. Thank you for the help!

Hello! It's great to hear that you could successfully install CNApy :D I'll try to find out more about the remaining .exe installer problem with my colleague. In the meantime, I wish you much success with using CNApy and if you encounter any problem, feel free to open new issues here :-)


Support BYSETPOS for MONTHLY AND YEARLY freq

Self-explanatory ;)

Interesting! This option doesn't seem to be clearly documented in the icalendar RFC but it looks like it's widely supported by different tools. I believe it would be worth finishing this up and adding it.
http://www.kanzaki.com/docs/ical/recur.html


Update sbt-scalafix to 0.9.12

Updates ch.epfl.scala:sbt-scalafix from 0.9.11 to 0.9.12.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #182


feat: Vec data structure

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: Closes #55
What is the new behavior?

Mutable vec data structure

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Fix la ci stp

Fix la ci stp
He's on a more recent version of Cairo.
We'll need release 8 to be able to merge this

Fix la ci stp

He's on a more recent version of Cairo. We'll need release 8 to be able to merge this

Haven't you seen? They released 1.0.0-rc0 a few days ago. Once quaireaux is updated to this version, I'll make the required changes :)

Is it considered as an "official release" I heard there should be a more official release next week maybe best to wait for that one?

Is it considered as an "official release"? I heard there should be a more official release next week maybe best to wait for that one?

release candidate are even more "official" than alpha versions, no?

I'll work on updating quaireaux to that one right away ser 🙏
Let me quickly check with other PR if it won't create issues

@gaetbout ready to merge :)


Provoke AWS into sending Content-Length header

head used to get content lengths, but does not any more, unless Accept-Encoding is unset, presumably because compressed files might have different lengths (unsure if a requests or AWS change)

LGTM from Nick


CB-6730. List instance groups even if all metadata are terminated.

Problem

on resize, if you have downscaled all the nodes for an instance groups you cannot get back the instance group itself with 0 instance metadata (if ALL terminated)

Changes

removed left join fetch query
get instance groups by stack and filter in java on the non-terminated instance metadata

Why like this?

condition (not terminated) should go into the right side of the join -> BUT you cannot include any with/on-clause if you are using fetch
without using fetch, we end up to using many queries (around 8)
with the actual (removed) query, we still load stack anyway in the objects, so it contains all instance groups/instance metadata -> in terms of space/load query only the instance group with all metadata should not cause larger heap space

@Query("SELECT i FROM InstanceGroup i JOIN FETCH i.instanceMetaData im "
        + "WHERE i.stack.id = :stackId AND ((im IS NULL OR im.instanceStatus <> 'TERMINATED') OR i IS NOT NULL)")

is works as well, could you please try it?


Too many tooltips

I have a line chart of about 400px width containing like 40 data points. So each the horizontal distance between two points is about 4px. When I mouseover one point, instead of seeing the tooltip of just that point I see the tooltip for that point AND the tooltip for neighbour points, seeing a total of ~4 tooltips overlapped.
Is there an option to show at max one tooltip at a time?

Thanks for the tip! I just had the same issue and your explanation helped me fix it.

It's all relative. I have to support up to 120 data points in a chart that can be as small as 284px (iphone5 w/ some padding, etc). Even w/ pointHitDetectionRadius all the way down to 0, I get many tooltips showing at the same time:

So whether or not Chart.js will work for you depends on your data and chart size requirements.

Does your chart require that level of granularity? Or could you get away with a smaller scale eg. Less points. I'm curios of the point detection radius myself. Gonna take a look....

@tannerlinsley The base Point class in Chart.core.js takes into account both the x and the y coordinate in it's inRange method. However, the line chart overrides inRange and only uses the x coordinate. Any idea why that may be the case? It sounds like we could filter all of the matching points and do something smarter.
@tomwayson can you try removing these lines from your Chart.js source file and see if that helps your example.
https://github.com/nnnick/Chart.js/blob/master/Chart.js#L2578-L2580

@etimberg - commenting out those lines definitely helped - there are still multiple tool tips when the points are close together (sort of like @Cristy94 says above), but it's not nearly as noticeable.
@tannerlinsley - I agree that reducing the point density by filtering some of the data points for smaller size charts would be a good solution , but this application is replacing a Flex app which has charts that are able to draw that many points and show fluid tooltips, so the client's expectation is that this app will be able to meet those same requirements.
Thanks for your suggestions. I have been looking at c3, but this workaround may be a viable solution!

Yeah. Completely understandable. Well hopefully we can come up with a good way to increase the accuracy

Quick fix in https://github.com/alanszp/Chart.js
@etimberg @tannerlinsley Want a PR?

@alanszp
I would strongly encourage you to make the PR. I tried this with my test data, and it worked much better than @etimberg's suggestion to comment out the lines that override the inRange method.
Don't get me wrong, I appreciated that suggestion, but I would say that it's fairly common for line charts (at least timeline charts) to only listen for changes in x on mouseover. So it felt a little awkward to have to mouse exactly over the line to see the tooltip, Even then, the bigger issue is that you would still see multiple tooltips some times. Your solution was the first that I've seen that completely eliminated the multiple tooltips. So I think you're on the right track to be filtering the points instead of only registering the hover event if the user is exactly over the line.
Did you try this on a chart that has multiple datasets? I did not, but I wonder if your code will cause it to only the tooltip for one dataset? I'm guessing why the library allows multiple tooltips in the first place?
Anyway, I hope you PR this, b/c I think we're going to try using a custom Chart.js based on this along with the ability to turn of x axis labels in #865 instead of using c3, which out of the box was able meet all our requirements except one: export to PNG. I've got a prototype for that, but it has a lot of dependencies and doesn't work in IE.
Thanks for all the help everyone!

Just had the same issue, thanks for answering after you figured it out!

Had same issue, got inspiration from @alanszp, although it didn't handle multiple datasets as I'd like to,
I just hacked it to return single point that is closest to the mouse cursor (pythagoreas), and return that one:
`        getPointsAtEvent: function (e) {
        var shortestDistance = null;
        var shortestPoint = null;

        var eventPosition = helpers.getRelativePosition(e);

        helpers.each(this.datasets, function (dataset) {
            helpers.each(dataset.points, function (point) {

                var x1 = point.x;
                var y1 = point.y;
                var x2 = eventPosition.x;
                var y2 = eventPosition.y;

                if (point.inRange(eventPosition.x, eventPosition.y)) {
                    var distance = Math.sqrt((x1 - x2) * (x1 - x2) + (y1 - y2) * (y1 - y2));
                    if (!shortestDistance || distance < shortestDistance) {
                        shortestDistance = distance;
                        shortestPoint = point;
                    }
                }
            });
        }, this);

        return [shortestPoint];
    },

`


Upload dockerd configuration over HTTP

Let admin upload daemon.json over HTTP, enabling control over those part of the dockerd configuration that are not exposed through parameters today.
Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have verified that the code builds perfectly fine on my local system
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have verified that my code follows the style already available in the repository
[x] I have made corresponding changes to the documentation

This is a nice feature but it is not needed to get rootless Docker delivered. In addition it adds a new dependency on the fastcgi setup meaning that that would be harder to remove if we find a better solution for the TLS upload It is also not clear how we explain to the user (or handle) if the file contains settings that we already use as inputs to dockerd.
I would prefer that you do not merge this.

The main use case for this is to allow ourselves to upload proxy settings without SSH. If we would switch to a different solution for TLS upload, I assume that solution would also work for daemon.json.
If a configuration is specified both in daemon.json and on the command line, dockerd will not start. Perhaps we need consider this even for the current way we expose daemon.json. We could add a note in the documentation about which entries in this file that are not configurable.
I find it odd that we provide a mechanism for per-device configuration of dockerd but we don't want to make it as convenient as possible to use, even for ourselves.
An alternative could be to provide the proxy settings as AXParameters, or if there are already other proxy settings in the device that we can use.


changes in user privileges

💡 Summary
As a system architect, I need to ensure support for updated integration requirements. Instructions are contained within the ATO document folder with Control ID AC-02 Account Management.
Motivation and context
Establishes conditions for group and role membership.
Acceptance criteria
Group and Role Conditions:
Admin Role

[ ] Cleared DHS EOD
[ ] Designated by Federal Lead
DHS CSA
[ ] Member of the Regions
[ ] Mange several organizations
Organizational Roles
[ ] Must be a member of the organization or
[ ] Operate as a DHS Representative for organization or sector (e.g. CSA)


Refactor: remove redundant function name from app.disable

The function name disable was unnecessary since it's already clear from the app.disable property assignment.
Removing it simplifies the code, improves readability, and follows best practices for concise function expressions.

@Ayoub-Mabrouk Thanks, but this is a style change that doesn't bring any improvement.


WebGL node-webkit example doesn't work out of the box

Uncaught node.js Error

TypeError: Cannot read property 'getExtension' of null
    at initGL (file:///C:/Users/USER~1/AppData/Local/Temp/nw4612_9195/js/three.min.js:21422:33)
    at new THREE.WebGLRenderer (file:///C:/Users/USER~1/AppData/Local/Temp/nw4612_9195/js/three.min.js:14887:2)
    at init (file:///C:/Users/USER~1/AppData/Local/Temp/nw4612_9195/js/showlogo3d.js:61:23)
    at HTMLDocument.<anonymous> (file:///C:/Users/USER~1/AppData/Local/Temp/nw4612_9195/js/showlogo3d.js:29:5)

Generator doesn't pack required files?

With what node-webkit version you are trying the webgl example?

0.8.6

Then it seem that three.js from the example is not compatible with node-webkit 0.8.6. And we can't do much about this because we don't maintain the examples nor three.js.
Could you please test if 0.10 or newer version of node-webkit works with the example?

Thanks for your help in improving generator-node-webkit, we close this because it uses an old version of node-webkit which we don't support anymore. Please reopen if the bug still persists in v0.10 or later.


[Bug]: Default PubsubMessage coder will drop message id and orderingKey

What happened?
We register multiple coders for PubsubMessage:
https://github.com/apache/beam/blob/9b2f87d0201e8923a021c6bedbe0f64e37704014/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubCoderProviderRegistrar.java#L32-L40
But in practice everything but the first one is a no-op. We will never use them (see https://github.com/apache/beam/pull/22216#discussion_r951821329 for a detailed explanation). This means that in cases where the coder for a PCollection<PubsubMessage> is inferred, we will use PubsubMessageWithAttributesCoder, which does not handle messageID or orderingKey.
Issue Priority
Priority: 2
Issue Component
Component: io-java-gcp

Marking this P1 since it could lead to data loss (in rare cases). We might mitigate by making PubsubMessageWithAttributesCoder (and other PubsubMessage coders) raise an error if the unsupported fields are non-null.
A better long-term fix would be to default to a coder that handles all fields, but this could break update compatibility so we'd need to be careful.

@egalpin @TheNeuralBit Is this fixed by #22216?

@apilloud It's introduced by https://github.com/apache/beam/pull/22216 rather than fixed.  Part of the complexity, at least for me, is the multiple coders registered against the same class in PubsubCoderProviderRegistrar.  Since all pubsub messages of type org.apache.beam.sdk.io.gcp.pubsub.PubsubMessage appear to use the first coder in the registrar by default, any messages with a superset of properties compared to PubsubMessageWithAttributesCoder will have those properties nullified silently.
Assuming that the "superset" coder which supports all the fields were the default, what would the drawback be in the case where, say, the messageId would never be used?  It would mean more bytes to represent the PubsubMessage, but are there other drawbacks?  Otherwise it seems like it might be easiest to make the "superset" coder the default, and view other coders as data-size optimizations that users could opt in to.
I do like the idea of raising an error in the coders in the case where unsupported fields are non-null, I think this could be an effective way to defend against data loss that could be implemented relatively quickly.

 As long as there is some path (it could require a code change by the user, such as explicitly declaring the old coder) to produce the previous behavior that should be sufficient.

Good idea, I'll start a thread on dev list

Any update on this one?

Ah this one fell off the radar for me unfortunately.  I've started a dev@ thread just now.  Thanks for the reminder!

Is there any workaround for this? any alternative to PubsubIO? Would com.google.cloud.pubsub.v1.Publisher work with apache beam api?

Noting that there is an open PR and I pinged it.

PR closed to lack of activity. I presume you ran out of time? Maybe someone else can pick this up.

thanks @kennknowles 👍  I just have not been able to squeeze in the time for testing. Agreed, happy to collaborate or hand off if someone else has capacity!

I've stumbled upon this bug once again. To assist anyone, I'm sharing the stack trace of the error that occurs in the dataflow console when using PubsubIO.readMessagesWithAttributesAndMessageIdAndOrderingKey().
Beam version: 2.51.0
org.apache.beam.sdk.coders.CoderException: NullableCoder expects either a byte valued 0 (null) or 1 (present), got 50
        org.apache.beam.sdk.coders.NullableCoder.decode(NullableCoder.java:90)
        org.apache.beam.sdk.coders.NullableCoder.decode(NullableCoder.java:79)
        org.apache.beam.sdk.io.gcp.pubsub.PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.decode(PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.java:73)
        org.apache.beam.sdk.io.gcp.pubsub.PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.decode(PubsubMessageWithAttributesAndMessageIdAndOrderingKeyCoder.java:35)
        org.apache.beam.sdk.coders.Coder.decode(Coder.java:154)
        org.apache.beam.runners.dataflow.worker.PubsubReader$PubsubReaderIterator.decodeMessage(PubsubReader.java:129)
        org.apache.beam.runners.dataflow.worker.WindmillReaderIteratorBase.advance(WindmillReaderIteratorBase.java:60)
        org.apache.beam.runners.dataflow.worker.WindmillReaderIteratorBase.start(WindmillReaderIteratorBase.java:46)
        org.apache.beam.runners.dataflow.worker.util.common.worker.ReadOperation$SynchronizedReaderIterator.start(ReadOperation.java:381)
        org.apache.beam.runners.dataflow.worker.util.common.worker.ReadOperation.runReadLoop(ReadOperation.java:211)
        org.apache.beam.runners.dataflow.worker.util.common.worker.ReadOperation.start(ReadOperation.java:169)
        org.apache.beam.runners.dataflow.worker.util.common.worker.MapTaskExecutor.execute(MapTaskExecutor.java:83)
        org.apache.beam.runners.dataflow.worker.StreamingDataflowWorker.process(StreamingDataflowWorker.java:1433)
        org.apache.beam.runners.dataflow.worker.StreamingDataflowWorker.access$800(StreamingDataflowWorker.java:155)
        org.apache.beam.runners.dataflow.worker.StreamingDataflowWorker$4.run(StreamingDataflowWorker.java:1056)
        org.apache.beam.runners.dataflow.worker.util.BoundedQueueExecutor.lambda$executeLockHeld$0(BoundedQueueExecutor.java:163)
        java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        java.base/java.lang.Thread.run(Thread.java:834)
        ```


which question user has

there is test failing

there is test failing

I really don't know what is the reason. I search it but don't know. the same error also in other pull-request

please run prettier on all your files