more tests for confusion matrix

more tests for confusion_matrix

Codecov Report

Merging #119 into dev will increase coverage by 3.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #119      +/-   ##
==========================================
+ Coverage   69.85%   73.38%   +3.52%
==========================================
  Files          21       21
  Lines        1088     1082       -6
==========================================
+ Hits          760      794      +34
+ Misses        328      288      -40

Impacted Files
Coverage Δ

src/data.jl
86.31% <0%> (+0.89%)
:arrow_up:

src/measures/confusion_matrix.jl
98.5% <0%> (+54.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b141f...c65b873. Read the comment docs.


Allow replacing of stories (again)

Issue: #4056
What I did
Replaced the error thrown when adding an already existing story with a console.warn. Created a test that covers this case. Note: console.warn is mocked as the jest config throws an error when this is called.

I originally made the changes on a release branch so I'm just running through the tests on master to make sure nothing has broken.

I can fix the tests for master, but that will break the tests for 3.4 when and if the commit is cherry picked.

@storybooks/team, does anyone want to give a feedback?

Thanks for the approval. If there's anything I can do to get this into the v3 stream please let me know.

I think we need to merge in master, I can do it today.

@michaelduminy I will cherry-pick it to release/3.4 branch right before the next patch release, you don't need to do anything


Scale calculation for after centering poses without colmap pts3d

Hi! Thanks for the work:
I am trying to use poses_bounds.npy for the dataset without colmap data.  Everything works  fine except one thing:
in the center_poses function pts3d argument is optional, we can calculate average pose without it.  But when using it without pts3d leads to not-converging training.
I found that Z coordinate of translation vector after centering with and without pts3d is very different.
In the case of  centering without pts3d its mean is close to zero:
np.mean(centered_poses_without_pts3d [:, -1, 3]) = -1.1102230246251566e-17
and with pts3d its far from 0:
np.mean(centered_poses_without_pts3d [:, -1, 3]) = -29.84
So scale = np.linalg.norm(self.poses[..., 3], axis=-1).min()  is 0.64 vs 29.41. If I manually hardcode scale to 29.41 it converges in  both cases.
Can you suggest how to deal with scale correctly in this case?

Looks like solution from original NERF is working:
        bd_factor = 0.75
        sc = 1. if bd_factor is None else 1. / (bds.min() * bd_factor)
        self.poses[:, :3, 3] *= sc


Build DevAnalyzers as a very first project to avoid race condition problems with MSBuild

We have randomly failed build because of DevAnalyzers.pdb being used by another process. Locally I was able to easily reproduce this issue. But not after these changes.
Let's see if it will actually help with the CI...

With default SDK support for in-solution analyzers being broken we can do something like this:

In DevAnalyzers.props (and generators):

build analyzers and generators manually with Nuke
Set AnalyzerCIHack environment variable with Nuke

That will prevent the SDK from rebuilding those projects since it won't even see ProjectReference

Alternatively we can change OutputItemType to something else and do a copy to an per-project intermediate dir via a target before CoreCompile

Welp, this PR's CI build failed with the old error. Didn't help.


build: enable CIFuzz

Add CIFuzz workflow action to have fuzzers build and run on each PR.
This is a service offered by OSS-Fuzz, on which coveragepy already runs.
CIFuzz can help detect catch regressions and fuzzing build issues early, and has a variety of features (see the URL above). In the current PR the fuzzer is built on a pull request and will run for 300 seconds.
Signed-off-by: David Korczynski<EMAIL_ADDRESS>

Thanks! There was also some mention some place of moving the fuzzing code itself into this repo so that we could extend it.  How do we make that happen?

There was also some mention some place of moving the fuzzing code itself into this repo so that we could extend it. How do we make that happen?

Move this code https://github.com/google/oss-fuzz/blob/master/projects/coveragepy/fuzz_parse.py into this library. We can move this anytime now -- feel free to make a PR on OSS-Fuzz that remove it and moves it up here. We should adjust https://github.com/google/oss-fuzz/blob/master/projects/coveragepy/build.sh and https://github.com/google/oss-fuzz/blob/master/projects/coveragepy/Dockerfile accordingly, but this is likely just switching a link.
In order to build fuzz_parse.py in the OSS-Fuzz environment, we use https://github.com/google/oss-fuzz/blob/master/projects/coveragepy/build.sh It would be great to continue using compile_python_fuzzer for the OSS-Fuzz environment since it makes it possible to get the coverage reports (thanks to this repo :) !) as well as introspector reports (still early stage for Python: https://github.com/ossf/fuzz-introspector).
If we place the fuzzer in test/fuzzers/ of this repo, then we can adjust the build script on OSS-Fuzz to use:
for fuzzer in $(find ./test/fuzzers/ -name 'fuzz_*.py'); do
  compile_python_fuzzer $fuzzer
done

The source folder in the find command is the only thing changed. That will make it possible to simply put new fuzzers in test/fuzzers/* and OSS-Fuzz will start running them continuously automatically.

Is this still valid @nedbat ?


yaml highlighting/textmate recognises some integers as strings (or vice versa?)

Does this issue occur when all extensions are disabled?: Yes

Version: 1.64.2
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:29.527Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-28-generic snap

OS is Ubuntu 20.04
Description:
Some integers (or strings?) are treated differently even though they look the same to me.
In each comment I've specified what the scope inspector reports the scope as.
This is what it ends up looking like for me:

I'd expect them all to be the same; so either they should all be integers or they should all be unquoted strings.
Test case:
test:
  - test: 01 # constant.numeric.integer.yaml
  - test: 02 # constant.numeric.integer.yaml
  - test: 03 # constant.numeric.integer.yaml
  - test: 04 # constant.numeric.integer.yaml
  - test: 05 # constant.numeric.integer.yaml
  - test: 06 # constant.numeric.integer.yaml
  - test: 07 # constant.numeric.integer.yaml
  - test: 08 # string.unquoted.plain.out.yaml
  - test: 09 # string.unquoted.plain.out.yaml
  - test: 10 # constant.numeric.integer.yaml

Steps to Reproduce:

Create a test file, test.yml with the contents from the test case

Thank you for the detailed issue! I have moved it to the upstream repo that we get our yaml syntax highlighting grammar from: https://github.com/textmate/yaml.tmbundle/issues/39


Parameter to give Installer URLs in Quick Update Mode

Description of the new feature/enhancement
After #64 is merged, we can use:
.\YamlCreate.ps1 -PackageIdentifier <PackageIdentifier> -PackageVersion <PackageVersion> -Mode <1..5>

Can we also add a -Urls Parameter so that we can run YamlCreate.ps1 in unattended mode.
Proposed technical implementation details (optional)
.\YamlCreate.ps1 --Urls <installer-url-1> <installer-url-2> <installer-url-3>

OR (if an array is passed)
.\YamlCreate.ps1 --Urls $installer_urls_array

Also, I think that it can be confusing for I'll suggest enabling it only when EnableDeveloperOptions is set to true.

@Trenly Is the array thing possible?

This isn’t possible in powershell, since we can’t guarantee that the installers will always be read in the same order. Wingetcreate avoids this issue by checking every URL and doing its best to match it with the installer, but it isn’t perfect and does sometimes fail.

This isn’t possible in powershell, since we can’t guarantee that the installers will always be read in the same order.

Well, I can guarantee. I have upgraded a couple of packages and observed that myself. When there are large installers and they take time to download, I schedule keypresses and the manifests is submitted automatically.
With the limitations of powershell, this would be too much to implemet at this time
Hmm. Then, I will have to look for any workaround so I will have to build a function that does the sorting of URLs in the array automatically.

Well, I can guarantee. I have upgraded a couple of packages and observed that myself.

I would disagree, as I have seen where it isn't in the same order as the manifest. The way that powershell-yaml interprets the installers is as an array of dictionary objects. Think @( @{}; @{}; @{} ). Based on what I have seen, it reads the dictionaries into memory and then stores them in the array. So, if you have 3 installers in a manifest, and one of the installers takes longer to read for whatever reason (maybe an extra key, maybe a slightly longer URL, maybe just randomly gets processed by a slower core on your CPU, etc.) then it can be placed later in the array of installers. Granted this isn't a common occurrence, but I've seen it happen.

Also what is the best thing about this when there are large installers and they take time to download, I schedule keypresses and the manifests is submitted automatically.

Automation can be very useful, but it can also be dangerous. Look at how often wingetbot tries to delete manifests that are working just fine because it either times out when downloading the installer or the website blocks bots. Not to say that automation shouldn't be done, but just that you have to be aware of edge cases any time you automate anything.

Hmm. Then, I will have to look for any workaround so I will have to build a function that does the sorting of URLs in the array automatically.

My best suggestion for a workaround would be to create a worker script that calls YamlCreate. The flow would look something like this -

Call the worker script with the Package.Identifier Package.Version and URL's that you want
The worker script will find the Last version of Package.Identifier and modify the URL's only, then save the files
The worker script can then call YamlCreate.ps1 Package.Identifier Package.Version -AutoUpgrade
Don't use the autosubmit in YamlCreate
Have your worker script restore the deleted manifest files
Have your worker script commit the remaining changes and submit the PR

I would disagree, as I have seen where it isn't in the same order as the manifest. The way that powershell-yaml interprets the installers is as an array of dictionary objects. Think @( @{}; @{}; @{} ). Based on what I have seen, it reads the dictionaries into memory and then stores them in the array. So, if you have 3 installers in a manifest, and one of the installers takes longer to read for whatever reason (maybe an extra key, maybe a slightly longer URL, maybe just randomly gets processed by a slower core on your CPU, etc.) then it can be placed later in the array of installers. Granted this isn't a common occurrence, but I've seen it happen.

Oh, because I work on a fast machine, I did not experience it.

Automation can be very useful, but it can also be dangerous. Look at how often wingetbot tries to delete manifests that are working just fine because it either times out when downloading the installer or the website blocks bots. Not to say that automation shouldn't be done, but just that you have to be aware of edge cases any time you automate anything.

I am working on automatically updating packages that are shipped through GitHub Releases. I will be happy if you would like to contribute to that once I complete it (https://github.com/vedantmgoyal2009/winget-pkgs-automation).

My best suggestion for a workaround would be to create a worker script that calls YamlCreate. [...]

I will see if it would work in my case. Not much difficult to implement it.

I would disagree, as I have seen where it isn't in the same order as the manifest. The way that powershell-yaml interprets the installers is as an array of dictionary objects. Think @( @{}; @{}; @{} ). Based on what I have seen, it reads the dictionaries into memory and then stores them in the array. So, if you have 3 installers in a manifest, and one of the installers takes longer to read for whatever reason (maybe an extra key, maybe a slightly longer URL, maybe just randomly gets processed by a slower core on your CPU, etc.) then it can be placed later in the array of installers. Granted this isn't a common occurrence, but I've seen it happen.

Oh, because I work on a fast machine, I did not experience it.

Automation can be very useful, but it can also be dangerous. Look at how often wingetbot tries to delete manifests that are working just fine because it either times out when downloading the installer or the website blocks bots. Not to say that automation shouldn't be done, but just that you have to be aware of edge cases any time you automate anything.

I am working on automatically updating packages that are shipped through GitHub Releases. I will be happy if you would like to contribute to that once I complete it (https://github.com/vedantmgoyal2009/winget-pkgs-automation).

My best suggestion for a workaround would be to create a worker script that calls YamlCreate. [...]

I will see if it would work in my case. Not much difficult to implement it.

Another idea I had; Because of how the autoupdate works by not deleting if the version is equal to the last version, the logic could be simplified even more

Copy previous version forward to new version folder
Update URL's in the file
Run YamlCreate with the autoupdate option
Submit PR using YamlCreate


joblib.memory.cache fails to save index

Hi, it seems like joblib.memory.cache cannot save an index.
I know this is not necessarily a bug, but it should at least be specified!

Hi,
It seems that the problem is that pybind11 methods __getstate__ and __setstate__ are not implemented (https://pybind11-rtdtest.readthedocs.io/en/stable/advanced.html). So you cannot make a copy of an index.
Probably it is a good thing to do.


Remove old Windows 7 support code

This update finally drops Windows 7 support from the windows-core crate as I did for C++/WinRT some months ago. Much like the Rust compiler, this "support" was never actually tested as we don't have test infrastructure for Windows 7. As a consequence, some Windows 8 only dependencies had crept in a long time ago.

Errf, I still use windows-rs on Windows 7, this move is going to cause me issues.
Starting with Rust 1.76, there is now a dedicated for windows7, called x86_64-win7-windows-msvc. Would you accept a PR that #[cfg]-outs the call to RoOriginateError?

Just turn it into a nop?


How to use with Laravel?

How do I use the library in a Laravel Controller? I am not sure how to Inject the Class. Can you post an example?
Thanks,
Fabian

Hi there.
Simply required with composer
composer require andreyco/instagram
and follow instructions
https://github.com/Andreyco/Instagram-for-PHP#laravel

@fabnoe did you find it any helpful?

For me the laravel setup doesn't work. I did get it to work by setting it up explicitly (eg the 'normal PHP') example. When setting up the Laravel version none of the settings (eg API key and secret) are applied. Might have to do that this project is still on Laravel 5.2

I will try to update to 5.3+ as soon as possible. Open to PR as well

@fabnoe, @PanMan, the instructions given by @Andreyco work for me with Laravel 5.4. Here they are in a bit more detail:

Install the package by running the command composer require andreyco/instagram

Open config/app.php and register the service by adding the following entry below the "providers" array key: 'Andreyco\Instagram\Support\Laravel\ServiceProvider\Instagram',

Also in config/app.php, add 'Instagram' => 'Andreyco\Instagram\Support\Laravel\Facade\Instagram', below the "aliases" array key.

The Instagram login URL should now be functional—add it to of your views: @php echo "Login with Instagram"; @endphp.

@fabnoe please, find updated docs. As pointed by @PanMan, package was on older Laravel 5.2. Now, Larave 5.3+ is supported.


Fix UnboundLocalError when clicking twice in tabs bar

Clicking twice in a blank space in tabs bar raises an exception trying to show the "Changing Tab label" dialog:
Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\runtimes\Anaconda3_64\Lib\tkinter\__init__.py", line 1705, in __call__
    return self.func(*args)
  File "p:/repos/sqlitebro/sqlitebro.py", line 473, in btn_presstwice
    actions = [widget, index]
UnboundLocalError: local variable 'index' referenced before assignment

Fixed as was only to be expected: with one tab :D

thanks , but now I notice we can't rename a "blank" tab

so, apparently, just that test can be removed, and we can move or rename "blank" tabs
if  "label" in elem:"


POC: Rust Wrapper for 1DS C++ SDK

What is this?
Adds a Rust "wrapper" to the 1DS C++ SDK, which will allow the SDK to be imported into Rust projects as a crate. The crate interacts with the C API of the SDK (instead of C++) as this will ensure a stable binary interface between the Rust layer and C++ layer of the project.
Project Structure
Crates:

cpp-client-telemetry-sys: crate directly exposing the C API of the 1DS SDK to Rust.
oneds-telemetry: contains some abstractions over the 1DS SDK and allows messages to be sent to the SDK from the log crate.
telemetry-sample: example executable using the oneds-telemetry crate.

Limitations

Currently only i64 and string telemetry fields are supported.
Currently we're only linking with the Windows-x64 static library - additional work on the build script will be required to add support for dynamic linking and other architectures/operating systems.

@microsoft-github-policy-service agree company="Microsoft"

@CDFriend This looks to be a good addition. when you have time, can you please make it ready for review :)

@CDFriend This looks to be a good addition. when you have time, can you please make it ready for review :)

@latlib - I can work on resolving the feedback.


[BACKPORT-v1.2.x][IMPROVEMENT] Improve snapshot purge

backport #3613

verified passed on v1.2.x-head
by manual test: snapshot purge retry


Fix can not connect to some websocket server

Ref to https://tools.ietf.org/html/rfc6455 section 1.2 and 1.3, should use lowercase only for upgrade protocol

Section 4.1 of said RFC6455 on page 18 mentions:

If the response lacks an |Upgrade| header field or the |Upgrade|
header field contains a value that is not an ASCII case-
insensitive match for the value "websocket", the client MUST
Fail the WebSocket Connection.

Strangely enough the request is not specified whether it should be case-insensitive or not, just that upgrade should contain the word "websocket" in 2 fields (Connection and Upgrade). So it would be better to create a ticket with the WebSocket server, IMHO.

Header values are case insensitive. Bug the server implementation


AI Face beta2

Description

Added support for the Large Face List and Large Person Group
Added support for latest Detect Liveness Session API
Change the default service API version to v1.2-preview.1.

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-ai-vision-face

We likely need more tests on administration clients, after API review pass (they could be in follow-up PRs).

Thanks for the suggestion, manually tested with sample. Will add test in the future.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/952 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 3a2a41f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-07-12-06-52-55 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Heart: the City Beneath] adding character sheet

Added html, css, json, and png files
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Does the pull request title have the sheet name(s)? Include each sheet name. The sheet names are heart.html and heart.css.  The game is called "Heart: the City Beneath"
https://www.kickstarter.com/projects/gshowitt/heart-the-city-beneath
If this is a new sheet, did you follow Building Character Sheets standards ? Yes, as best as I could. I wasn't sure what the rules on camelcasing were, so I have some camelcased identifiers, but most are just all lower case.


Unexpected property visibleAzLogin

We set this in our pipelines:
visibleAzLogin: false

It is a supported property of the AzureCLI@2 task, and we set that to avoid printing the list of subscriptions in the logs. It makes the logs cleaner.
But, the VSCode extension then complains that the property does not exist, flooding our list of problems with the warning Unexpected property visibleAzLogin.
Can this property be marked as supported?
No other property for the AzureCLI@2 task are reported as unexpected.

Is it possible to 'simply' push a new version of the extension with the updated schemas of the tasks? I could not find a script that generates that schema file, otherwise o would maybe try and patch my own environment. Seems like a separate release trigger should be in place for only schema changes, just a suggestion.

(Actually, I'll keep this open until we do regenerate the schema)


Publish builds on main branch are failing with a config cache error.

The publish snapshot job on main is failing with a config cache error.
(looks like it is still publishing correctly)
https://oss.sonatype.org/content/repositories/snapshots/com/slack/lint/compose/compose-lint-checks/1.4.0-SNAPSHOT/
Maybe just use --no-configuration-cache for the snapshot publishing?
It makes it harder to tell at a glance if there is a "real" failure or not.
https://github.com/slackhq/compose-lints/actions/runs/10647621460/job/29515766042#step:7:35
FAILURE: Build failed with an exception.

* What went wrong:
Configuration cache problems found in this build.

3 problems were found storing the configuration cache, 2 of which seem unique.
- Task `:compose-lint-checks:dokkaHtml` of type `org.jetbrains.dokka.gradle.DokkaTask`: cannot serialize object of type 'org.gradle.api.internal.artifacts.configurations.DefaultUnlockedConfiguration', a subtype of 'org.gradle.api.artifacts.Configuration', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.10/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:compose-lint-checks:mavenDokkaJavadocJar` of type `com.vanniktech.maven.publish.tasks.JavadocJar`: cannot serialize object of type 'org.jetbrains.dokka.gradle.DokkaTask', a subtype of 'org.gradle.api.Task', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.10/userguide/configuration_cache.html#config_cache:requirements:task_access

See the complete report at file:///home/runner/work/compose-lints/compose-lints/build/reports/configuration-cache/6ypudivk1lunb9zflx95ggxnr/9ohkz4ychv2thj2q4bdej83ie/configuration-cache-report.html

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org./

BUILD FAILED in 5s

yeah publishing to central should have CC disabled, can fix


Billboard mirrored when loading ImageBitmap

When adding a billboard image from an ImageBitmap it appears mirrored (upside down) in Cesium. This does not happen when loading from a Canvas or URL.
See this Sandcastle example:
var viewer = new Cesium.Viewer("cesiumContainer");

//Create sample canvas
var canvas = new OffscreenCanvas(160, 30);
var ctx = canvas.getContext("2d");
ctx.font = "30px Arial";
ctx.fillStyle = "red";
ctx.fillText("Hello World", 0, 30);

//Create bitmap from canvas
createImageBitmap(canvas).then(function (bitmap) {

    //Add upper billboard
    viewer.entities.add({
        billboard: {
            image: bitmap, //FROM BITMAP
        },
        position: Cesium.Cartesian3.fromDegrees(-80, 30)
    });

    //Add lower billboard
    viewer.entities.add({
        billboard: {
            image: canvas, //FROM CANVAS
        },
        position: Cesium.Cartesian3.fromDegrees(-80, 20)
    });

    //Create and add a new canvas from bitmap
    //just to make sure that it's not an issue with the bitmap
    var newCanvas = document.createElement("canvas");
    newCanvas.style.position = "absolute";
    newCanvas.width = bitmap.width;
    newCanvas.height = bitmap.height;
    var newCtx = newCanvas.getContext("2d");
    newCtx.drawImage(bitmap, 0, 0);
    document.body.appendChild(newCanvas);
});

Using rotation: Math.PI rotates it 180°, but it's still going to be mirrored.
This is how it looks in Chrome, haven't tried with different browsers yet:

In my application I'm getting a lot of ImageBitmaps from a worker that I'd like to add to the viewer without performing any further, potentially costly operations.

@bjoeni textures in CesiumJS require being flipped. Normally they are flipped on upload to the GPU, see: https://github.com/CesiumGS/cesium/blob/ec320dd43f56219036625c8d7a4d7fded9b1dc5a/Source/Renderer/Texture.js#L178.
However, an ImageBitmap cannot be flipped during GPU upload, because it's already been decoded. You must instead flip it during decode. This is why the canvas one appears correctly, it's flipped during GPU upload. So in your example you'd need to replace the following:
createImageBitmap(canvas)

With:
createImageBitmap(canvas, { imageOrientation: "flipY" })

You can read more about the history of how this works and how these decisions were made here: https://github.com/CesiumGS/cesium/pull/7579 and here: https://github.com/CesiumGS/cesium/pull/7701. If you have ideas on improving this API/implementation we're happy to consider it! I'm closing this issue for now since it's working as designed.

Oh I see. Thanks for your response!
I don't exactly understand why the everything needs to be flipped in the first place (and not just the imagery on upload), that seems a little counterintuitive but I assume that's just how the project grew. Or is that more performant because there are usually more tiles than other textures?
It's a bit unfortunate since I'm not only displaying the bitmaps within Cesium. So I guess I'm gonna flip it when creating the bitmap and the whole project has to work with flipped bitmaps now if I don't want it to be converted back and forth for/within Cesium.
Maybe it's worth noting that in the documentation? I know that it doesn't claim to be supporting ImageBitmap at all but I guess there are quite a few use cases where it's much more performant to keep existing ImageBitmaps.

I don't exactly understand why the everything needs to be flipped in the first place (and not just the imagery on upload), that seems a little counterintuitive but I assume that's just how the project grew. Or is that more performant because there are usually more tiles than other textures?

@bjoeni this is actually a WebGL convention, not specific to CesiumJS. See: https://webglfundamentals.org/webgl/lessons/webgl-image-processing-continued.html

Finally in the original example we flipped the Y coordinate when rendering because WebGL displays the canvas with 0,0 being the bottom left corner instead of the more traditional for 2D top left.

I think it may make sense to explicitly document it since the engine does support ImageBitmap (internally most things are created as an imagebitmap to move decoding off the main thread) and you can explicitly creating one by passing in preferImageBitmap here: https://cesium.com/docs/cesiumjs-ref-doc/Resource.html?classFilter=Res#.fetchImage.
I'm not sure if there are code paths that won't accept ImageBitmap anywhere that HTMLImageElement is currently accepted. Feel free to move the discussion to the community forum (https://community.cesium.com/) or open a PR if you find it works in cases and is missing doc for it!


refactor(errors): support encoding of AMQPErrors

Not too much craziness going on here, but definitely enough to
warrant comment:

error conditions have all been moved to the ErrorCondition enum
module. They are enumerated both by legacy enum format
(e.g. InternalError, or LinkRedirect), but also now by names
used in the spec ('internal-error', 'link:redirect'). This
opens us up to the possibility of users simply needing to use
a string in order to send the required error.

errors can be specified by full use of the AMQPError type
internally (it is not exported), as well as by a plain object
(e.g. { condition: 'internal-error', description: 'test' }), or
just a string (for the mandatory condition field).

any unknown errors will throw an EncodingError

tests for all of this are baked in

forgot to mention:
closes #216

I should also mention that this includes a nice little example of using requires in the composite definition. This same tactic could be used everywhere else we have a "choice" field (e.g. TransferFrame.rcvSettleMode) for two main benefits:

ensure we aren't screwing up any types that are being sent
ensure incoming data is in a format we expect it to be
allow users to use a more idiomatic node style values (auto/settle, instead of our exported constants)

"allow users to use a more idiomatic node style values (auto/settle, instead of our exported constants)"
This is awesome


AFA data structures, Closed set data structures, functions for inspecting an AFA, two AFA emptiness tests

I've changed the former data structure for alternating automata, I've added structures for transition and inverse transition and several functions which enable us to inspect an alternating automaton using antichains (pre, post). I've also implemented two antichain-based AFA emptiness tests (which work in a forward and backward fashion).
I've also added a file closed_set.hh which makes the work with antichains easier.
I've also added several test cases.

So are all comments addressed? Could you mark conversations as resolved? Once everything is done, we can merge this PR.

It looks that the most comments by reviewers were addressed. @Adda0 are all requested changes done?
The last thing left for discussion is number of Post functions. However, I don't think it is possible to easily rewrite code without them. So I am for merging this PR and maybe creating issue about possible improvements of AFA code.


Cache complex union and intersection relations

We've discussed caching union and intersection relations before, but had concerns about the increased memory usage. This PR introduces caching for complex union and intersection relations, specifically those than have a combined number of constituents of at least 4. This ideally strikes a balance between time and memory.
This PR improves check time for our "compiler with unions" code base by about 12%.

@typescript-bot perf test this

Not much effect on our perf test suites, so not clear how valuable this is. But it definitely has a pretty positive effect on the compiler with unions code base.

@weswigham @RyanCavanaugh FYI

I'm surprised there's not a more pronounced effect on Material UI but I guess it makes sense

@rbuckton know if we can go about enabling that perf test at some point (and get some historical data for it)?
@ahejlsberg we going to merge this at some point? Should it have a milestone? It looks like it needs a merge for a baseline update.


Client-side sorting directive

Having trouble following the client-side sorting example (using md-order) outlined in the README.
Here's a plunker demonstrating that clicking a <th> apparently has no effect on the sort order (although watching the ctrl.order variable in the md-data-table directive proves that it is being updated on click).
Am I missing a step? If so, I'd be happy to submit a PR for the README with additional detail.

Might have uncovered another issue with this plunker: the <tbody> has the md-auto-select directive. As intended, clicking anywhere in the row adds the element to the selected array; however, the corresponding md-checkbox appears to not have the md-checked class applied.

@twrk I've updated the version of Angular in your provided plunker to version 1.4.x and everything seems to be working as expected. I'm not sure what incompatibility is being experienced with Angular 1.3.15. Do you need to use Angular 1.3.15 in your app or are you able to update?

Ahh yeah, that'll do it, thanks! And 1.4 works just swimmingly for me :)

:+1:

I'm facing the same issue with Angular 1.3.15.
Is there any workaround for this version of angular? I cannot update to 1.4.x without getting multiple approvals.


Update to latest git (CVE mitigation)

Hi,
just wondering what's the process for updating packages? There are some major CVE reports on git version 2.14.1 that is used and should be updated in this repo.. (CVE-2018-11233, CVE-2018-11235)
And/or how can I check if it is already uploaded to the s3 bucket? So I could do a pull request for this..
@jhunt @starkandwayne-bot
Thanks

Some blobs we track.  Others we don't.  git falls into the latter.  Opening an issue like this asking for an update is probably the easiest way, for now.

Thanks. Is there any chance that you upload an updated version of git to your blobstore so I could build the release on my own for the meantime?

You shouldn't need it in the blobstore; you can test locally.  Then you can take your changes to the packaging script (if any) and submit them as a PR.


Unable to update

git pull and npm install says it updated packages but when I check the version in the package.json it shows 2.0.0?  What am I doing wrong?   Thanks
pi@raspberrypi:~ $ cd MagicMirror pi@raspberrypi:~/MagicMirror $ cd modules pi@raspberrypi:~/MagicMirror/modules $ cd MMM-News pi@raspberrypi:~/MagicMirror/modules/MMM-News $ git pull Updating 081fcb2..bff080d pi@raspberrypi:~/MagicMirror/modules/MMM-News $ npm install audited 95 packages in 3.8s found 0 vulnerabilities

maybe retry installing ?
delete MMM-News
and reinstall it
it's weird...

@bugsounet that worked thank you!


Dialog v1 POC

Components

Dialog handles all of the floating ui business, sets up the context provider, and applies padding top and bottom
DialogContext passes the status prop for DialogTitle to render the status icon, and dialogId so that the title and dialog can be associated with aria attributes.
DialogActions wraps the buttons, applies padding, and applies flex layout defaults. These can be easily bypassed with minimal css, and extended with our layout components.
DialogContent wraps the text/interactive contents and applies scrolling
DialogCloseButton positions the close button to top right.

 Status is passed directly to DialogTitle component instead of the Dialog.
<DesktopWindow>
    <DialogTitle status="warning">Title</DialogTitle>
    <DialogContent>Content...</DialogContent>
    <DialogActions><Button>Ok</Button></DialogActions>
</DesktopWindow>

/snapshot-pr

/snapshot-release

looking v good!! 🌟

probably good to move out of draft to get more 👀 on this
and add a changeset

thanks @libertymayc 👍


Create additional info blocks

You can make your resume less official by adding more entertaining info, like your hobbies and interest, or what do you like, some interactive content or joke, easter egg, etc.

Add my hobbies.


docs' SCSS code does not pass the linter

docs/assets/scss/_ads.scss:11 [W] PropertySortOrder: Properties should be ordered width, height, padding, margin, overflow, font-family, font-size, line-height, color, text-align, background, border
docs/assets/scss/_ads.scss:52 [W] IdSelector: Avoid using id selectors
docs/assets/scss/_anchor.scss:13 [W] PropertySortOrder: Properties should be ordered opacity, -o-transition, -webkit-transition, transition
docs/assets/scss/_anchor.scss:13 [W] VendorPrefix: Avoid vendor prefixes.
docs/assets/scss/_anchor.scss:14 [W] Indentation: Line should be indented 2 spaces, but was indented 7 spaces
docs/assets/scss/_anchor.scss:14 [W] VendorPrefix: Avoid vendor prefixes.
docs/assets/scss/_anchor.scss:15 [W] Indentation: Line should be indented 2 spaces, but was indented 10 spaces
docs/assets/scss/_buttons.scss:14 [W] SpaceAfterPropertyColon: Colon after property should be followed by at least one space
docs/assets/scss/_component-examples.scss:26 [W] PropertySortOrder: Properties should be ordered min-width, max-width, margin-right, margin-left
docs/assets/scss/_component-examples.scss:70 [W] PropertySortOrder: Properties should be ordered padding, margin-right, margin-bottom, margin-left, border-width
and so on

Fixed by #18752.


add transformers.py

@twolffpiggott should we add this here or to an other project we open source?
https://github.com/PhilipMay/mltb/blob/master/mltb/integration/transformers.py

Please also add yourself (@twolffpiggott ) to the code owners section like I did: https://github.com/telekom/HPOflow/blob/main/CONTRIBUTING.md#code-owners

Will be doing opening the PR today :)


Adding MP3 Support

Added basic support for (and default to) MP3 format.

Thanks for putting this together! Worked perfectly for me.


Eliminate Warnings on Puppet 4+, allow registry module <4

Pull Request (PR) description
Eliminate Warnings on Puppet 4+, allow registry module <4
This Pull Request (PR) fixes the following issues
Fixes #60
Fixes stdlib deprecation messages.

Sigh, the tests have to be updates as well to match the new text. validate_legacy adds a new layer of logic to this

Thank you for the contribution. Closing as this functionality has been added.


not in subquery OOM or takes too much time.

Steps to reproduce the behavior (Required)
TPC-H SF100
Expected behavior (Required)
Real behavior (Required)
mysql> set enable_pipeline_engine=false;
Query OK, 0 rows affected (0.06 sec)

mysql> SELECT count(*) FROM orders WHERE o_orderkey NOT in(SELECT l_orderkey FROM lineitem);
ERROR 1064 (HY000): Memory of query_pool exceed limit.  Used:<PHONE_NUMBER>52, Limit:<PHONE_NUMBER>65. Mem usage has exceed the limit of query pool
mysql> set enable_pipeline_engine=true;
Query OK, 0 rows affected (0.04 sec)

mysql> SELECT count(*) FROM orders WHERE o_orderkey NOT in(SELECT l_orderkey FROM lineitem);
ERROR 1064 (HY000): Memory of query_pool exceed limit.  Used:<PHONE_NUMBER>52, Limit:<PHONE_NUMBER>65. Mem usage has exceed the limit of query pool
mysql> SELECT count(*) FROM orders WHERE o_orderkey NOT in(SELECT l_partkey FROM lineitem);
+-----------+
| count(*)  |
+-----------+
| 145000000 |
+-----------+
1 row in set (29.19 sec)

StarRocks version (Required)
2.2.0

This SQL use a HashJoin operator, which needs to load the whole right table in memory, may cause the oom issue in your environment.
We would optimize the memory consumption in the future.


Ionic IOS NOT id

ios version is not bringing the id
{"isWritable":1,"ndefMessage":[{"tnf":1,"id":[],"payload":[4,118,105,110,104,111,115,100,101,108,117,120,111,46,99,111,109],"type":[85]}]}

same problem here


Bottom Drawer fails to show by default on a phone screen

Need to scroll the window up to see the buttons

Looks like this is a problem of mobile navigators, since the height of the viewport is not considering the search bar and additional bars created by the navigator in top of the content.
For example, in brave you have search bar at top, and options bar at bottom of I scroll down and then I scroll up, those bars disappear and everything is visible.


docs: add a architecutres field

What this PR does / why we need it:
Which issue(s) this PR fixes:
Sorry, I forgot this field when I support it. So I added it.
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Nice, could you update docs under /docs-v0.44.x as well. Since this feature had released.

@khanhtc1202
I fixed.


Subscription to location updates can lead to excessive battery usage

If i make a subscription to get regular position updates, the requests are never emptied thus the location manager is always running. And it is always running in the mode desiredAccuracy kCLLocationAccuracyBest. But i don't need this accuracy which needs so much battery power. I have no option to change to desiredAccuracy.

Hi @oonoo,
You are correct, INTULocationManager runs with kCLLocationAccuracyBest. For the regular one-time requests, this is actually not a problem, because as soon as the requested accuracy has been achieved, the request is completed, and once all requests have been completed location services are powered down.
For the newer subscription API, there is currently no way to specify the desired accuracy, which would be required to let INTULocationManager know what kind of -[CLLocationManager desiredAccuracy] to use.
I definitely think that this would make a good enhancement: to add another API for starting a subscription, which includes a desired accuracy parameter. (The existing subscription API will continue to default to "best".) This will require a little bit of work, because internally, INTULocationManager will need to dynamically adjust the desiredAccuracy setting on CLLocationManager based on the highest accuracy requirement of all current location requests.
Does that make sense? If you'd like to submit a pull request with this enhancement, that would be great! Otherwise it may be something that can be included with the next release (alongside #45).

Please take a look at the changes in be2dcee, I've implemented a new public API and some internal enhancements to support this!


bug: Documentation - members section

Describe the bug
Text is not visible on members section of the docs.
To Reproduce
No response
Expected behavior
No response

We should add new profile pics, social links, and design for member cards to this issue as well.

Add @patrikrek
Images.


[RESOLVED] High ICMP ping response time

Problem started at 08:27:29 on 2023.07.26
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Operational data: Value: 715ms
Original problem ID: 33098
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23268&eventid=33098

Problem has been resolved in 7m 0s at 08:34:29 on 2023.07.26
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Original problem ID: 33098


WebClient documentation update to the latest API version

WebClient documentation needs to be updated to reflect newest API changes.

Done already


enter causes form to submit

When using react-autosuggest in a <form> and the user presses the enter key to select a suggestion, the form is submitted. This seems undesirable from a usability perspective (particularly if you're using more than one instance of react-autosuggest on the same form).  (Supporting implicit submit -- form submittal via a button/input with type="submit" -- is important for accessibility reasons.) It seems like the enter key event should be contained to the react-autosuggest component and/or the event should be canceled. This would change would allow react-autosuggest to live nicely within a <form>.
Here's a codepen based on 6.0.2 that demonstrates the issue: http://codepen.io/anon/pen/XjAZxN?editors=0010
It's straight forward to solve this on the consuming application side:  add an onSelect callback that does the following:
onSuggestionSelected(event, { suggestion }) {
  if (event && event.key === 'Enter') {
    const { getSuggestionValue, cInputText } = this.props;

    if (getSuggestionValue(suggestion) === this.state.value) {
      // If old and new values are the same, bail early and don't perform any
      // selection logic. This prevents double selections from the react-autosuggest
      // component when the user hits enter in the input field.
      return;
    }

    // If old and new values differ, proceed as normal -- except we might be
    // in a form, so prevent this enter keystroke from submitting the form.
    event.preventDefault();
  }

  // ... perform the rest of my selection logic
}

However, it seems like things would be better if every consuming application did not have to write this code.

Is it basically comes down to calling event.preventDefault() from onSuggestionSelected?
onSuggestionSelected = event => {
  event.preventDefault();
};

Is there any harm to always call event.preventDefault() from onSuggestionSelected?

With the example shown, no, there would not be any harm. It would be inconvenient for consumers, but that's all.
In my more complex application, however, this does cause problems. So perhaps it's not actually a good idea. (Imagine synthesizing a "no match found" suggestion on the fly when the list of suggestions is empty. Combine that with focusFirstSuggestion and you need some selection logic to skip the synthetic element, but allow the key press event to go through. In a word: complicated.)
Closing this one.


Persist workspace assignments without modifying the config

Hi, thank you for this amazing tool! I love how lightweight and unobtrusive it is.
Question:
Is there a way to persist assignments to workspaces other than adding each individual app to the config? I have a lot of apps that I do not use often and that are specific to only one machine. Consequently, I'd rather avoid cluttering my config with these apps. However, I still want them to remain in the workspaces where I put them after reboots or application restarts.

Reference: https://i3wm.org/docs/layout-saving.html

Of course, having a layout file as in i3 would be the dream. Until it’s implemented, I’ve found a handy workaround. I use a bash script, triggered via Alfred, to set up the simple layouts that I frequently use. For instance, I have setups for different scenarios like tutorials, thesis writing, or work workspaces. Just thought I’d share this tip while we wait for the layout file feature. Hope this helps!
#!/bin/bash
view=$1
if [ "$view" == "tutorial" ]; then
	ws=1
	open -a Firefox
	aerospace move-node-to-workspace $ws

	open -a IINA
	sleep 1
	aerospace layout tiling
	aerospace move-node-to-workspace $ws

	open -a WezTerm
	aerospace move-node-to-workspace $ws

	aerospace workspace $ws
	aerospace layout tiling
	for i in {1..3}; do
		aerospace move left
	done
fi

if [ "$view" == "thesis" ]; then
	ws=2
	open -a sioyek
	sleep 1
	aerospace move-node-to-workspace $ws

	open -a WezTerm
	aerospace move-node-to-workspace $ws

	open -a Firefox
	aerospace move-node-to-workspace $ws

	aerospace workspace $ws
	aerospace layout tiling
	for i in {1..3}; do
		aerospace move left
	done
fi

function open_move_fullscreen {
	open -a $1
	aerospace move-node-to-workspace $2
	aerospace fullscreen
}

if [ "$view" == "default" ]; then
	aerospace close-all-windows-but-current
	open_move_fullscreen "ChatAll" A
	open_move_fullscreen Firefox B
	open_move_fullscreen WezTerm T
	aerospace workspace B
fi

if [ "$view" == "work" ]; then
	ws=C
	open -a "Microsoft Teams"
	sleep 1
	aerospace move-node-to-workspace $ws

	open -a "Microsoft Outlook"
	sleep 1
	aerospace move-node-to-workspace $ws

	aerospace workspace $ws
	aerospace layout tiling
fi

Layout files would be fantastic! This is the feature I'm waiting most eagerly for (and others in this and also this issue).
@nikitabobko Do you still have this feature on the roadmap? Thanks!

I've created this small script to save and restore window -> workspace config; I run aerospace-save_restore.sh save before a aerospace "cold restart" (e.g. aerospace version update) and aerospace-save_restore.sh restore after. It's only useful when window IDs persist, so won't be useful to recover from OS updates/reboots.
https://gist.github.com/bdlow/59a35c8adeed8294929f1f6f8b0e1de7


Added Porto, Portugal

A couple of spots I've found in the few weeks I've been in Porto.

+1!

thank you @samhogg :D

@diasdavid you're welcome!


Authentication Policy missing request.auth.claims attribute

The new Authentication Policy should expose a request.auth.claims attribute. See: https://preliminary.istio.io/docs/concepts/security/authn-policy.html.
However, this attribute hasn't been defined for Mixer. I get an error attempting to use it (in 0.7.1, 0.8, and HEAD):
2018-04-18T00:20:16.772654Z	error	Unable to initialize adapter: snapshot='6', handler='apigee-handler.apigee.istio-system', adapter='apigee', err='cannot infer type information from params in instanceConfig 'apigee.authorization.istio-system': failed to evaluate expression for field 'Subject'; failed to evaluate expression for field 'Subject.Properties[encoded_claims]'; unknown attribute request.auth.claims’.
This attribute is a must-have for me to use the policy. Thanks!

Note: There is a similar, older issue having to do with the old EUA policy that could probably be closed as irrelevant: https://github.com/istio/istio/issues/3194.

Are you using authn config?  Is it Envoy config generated by Pilot?  The code is in
https://github.com/istio/proxy/blob/master/src/istio/control/http/attributes_builder.cc#L89
If not working, we need to debug it.  Please provide your config detail

Yes, that code is in Proxy... and is probably fine there, but Mixer doesn't understand that request.auth.claims is a valid attribute. I don't know where all it needs to be declared in Mixer, but you can see that the generated vocabulary is missing this attribute: https://preliminary.istio.io/docs/reference/config/mixer/attribute-vocabulary.html.

In the PR https://github.com/istio/istio/pull/5136, the tests istio/mixer/test/client/istio_authn_origin_jwt_bound_origin/authn_report_test.go and istio/mixer/test/client/istio_authn_peer_jwt_bound_peer/authn_report_test.go show that the request.auth.claims is in Mixer. These two tests in the PR 5136 configure the Istio authn policy, send a HTTP request, and verify that the attributes at Mixer are as expected.

The SHA of the api repo used in the release-0.8 branch is 9d978d76653da8b7b4bd6421b7e8f9925d8c79ea, which was committed in two months ago. Thus the recent changes on the api repo are not included in the release-0.8 branch yet. According to the following comments in the istio/istio.deps in the release-0.8 branch, the dependency of api repo is auto updated by a robot:
{
"_comment": "This file is auto updated by a robot executing https://github.com/istio/test-infra/blob/master/prow/test-infra-update-deps.sh.",
"name": "istio.io/api",
"repoName": "api",
"prodBranch": "master",
"file": "Gopkg.toml",
"lastStableSHA": "9d978d76653da8b7b4bd6421b7e8f9925d8c79ea"
},

What needs to happen to get the api changes merged into release-0.8? @douglas-reid ?

@mandarjog can you help?

Just linking to a file with the missing attribute for quick reference: https://github.com/istio/istio/blob/release-0.8/mixer/pkg/attribute/list.gen.go

This was brought to my attention today and there is some confusion about whether this is release blocking for 0.8.0.
Could someone provide some detail if this is indeed blocking 0.8? If so, it needs to be tracked in https://docs.google.com/spreadsheets/d/1KquD8HJLlg-IwGYuF6O8AqJMpJPWLHjA-VEY24Eu8b8/edit#gid=0.

The following code in istio/Gopkg.lock shows that the SHA for "istio.io/api" repo used by release-0.8 has been updated to 170445541e5b5a1515b52c9c9596570220679a27, which is committed on May 3, 2018. So the request.auth.claims should have been in the release-0.8 branch. In the commit https://github.com/istio/istio/commit/23a8d3ec89c79f891d1d14fb1133f4596d5f32b7 in the release-0.8 branch, the tests istio/mixer/test/client/istio_authn_origin_jwt_bound_origin/authn_report_test.go and istio/mixer/test/client/istio_authn_peer_jwt_bound_peer/authn_report_test.go show that the request.auth.claims is in Mixer. These two tests configure the Istio authn policy, send a HTTP request, and verify that the attributes at Mixer are as expected.
[[projects]]
branch = "master"
name = "istio.io/api"
packages = [
"authentication/v1alpha1",
"broker/dev",
"envoy/config/filter/http/authn/v2alpha1",
"mesh/v1alpha1",
"mixer/adapter/model/v1beta1",
"mixer/v1",
"mixer/v1/config/client",
"networking/v1alpha3",
"policy/v1beta1",
"rbac/v1alpha1",
"routing/v1alpha1"
]
revision = "170445541e5b5a1515b52c9c9596570220679a27"

Thanks @lei-tang. If the fix is already in release-0.8, I suppose no additional work is needed and hence this is not blocking anymore.
For reference, please make sure to add the kind/blocking release label to the blocking issues in future to make sure issues won't fall through the crack.

@hklai @theganyo @mandarjog we need to run go generate ./mixer/pkg/attribute/... on the branch.
I rebased to the release-0.8 branch, and was able to generate the following diff:
index 06311870e..1bf9545d1 100644
--- a/mixer/pkg/attribute/list.gen.go
+++ b/mixer/pkg/attribute/list.gen.go
@@ -185,5 +185,7 @@ var (
               "connection.event",
               "check.cache_hit",
               "quota.cache_hit",
+               "source.principal",
+               "request.auth.claims",
    }

@theganyo we also need to update the attribute manifest. Example: https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/mixer/templates/config.yaml#L85

Status update: I've added the necessary request.auth.claims attributes in mixer, but there's a bigger problem that will need to be solved: Proxy is processing and delivering request.auth.claims as a string map and will need to be rewritten to deliver a string.

Alternatively, the string map of request.auth.claims produced by the proxy can be converted into a string by a consumer of the request.auth.claims. Different consumers of request.auth.claims may want to convert the string map of the claims into different formats of  strings based on their own requirements, e.g, a string of claims delimited by comma, or by semicolon, and so on.

That wouldn't be sufficient. JWT claim values can be complex and the existing implementation on Proxy drops all JWT claims that don't have simple string values.

After discussing with @mandarjog, we've decided to move forward with the string map and file a separate issue against the proxy for it to include raw string values for all claims. Meanwhile, I'll submit a PR for this shortly.

request.auth.claims_raw contains the original claims from the header.
We need to add this as a string attribute to the attribute vocabulary.
We should revisit this solution, if we want map<string, string> to contain all claims or just simple claims.

is request.auth.claims_raw a final naming decision?  should this be request.auth.raw_claims to better match style guidelines?  or maybe request.auth.claims.raw and request.auth.claims.map ?

It's actually raw_claims: https://github.com/istio/proxy/pull/1744. But as Mandar mentioned, it's not yet in the mixer attributes.

The name is indeed request.auth.raw_claims.
I didn't add the attribute to global_dictionary, as per my understanding, it is for optimization mainly. However, feel free to add it, or let me know if you want me to do. Other than that, I don't know any other place we need to change to hook up with mixer. As long as (mixer) client send the attribute, mixer should see it, right?

verified as fixed in nightly build. thanks!


Update for A2 New mesh + delete old files

Careful, you deleted the glb and replaced it with a new one, but you forgot to update your code:

Also, I tried to fix it for you and the model has also been compressed it.
Make sure you don't compress it before uploading it, otherwise it won't work


add clip_grad_norm_ parameter.grad test

Add clip_grad_norm_ parameter.grad test.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.pc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


One shot DevP2P transaction broadcasting

What was wrong?
We need "one shot DevP2P transaction broadcasting" in order for Alexandria to support the eth_sendRawTransaction JSON-RPC API.
How can it be fixed.
A Trio compatible async python function that takes a transaction and broadcasts it into the DevP2P eth protocol.
async def broadcast(
        *transactions: Transaction,
        confirmations: int = 3,
        ...) -> None:
    ...

Implementation requirements.

Discovery

v5.1 protocol only

Bootstrapping:

May use a persistent database of nodes for faster bootstrapping.
Should use discovery protocol for sourcing candidate nodes.

Broadcasting

Must broadcast transaction over the DevP2P eth/65 protocol.
A "confirmation" is defined as being able to retrieve the transaction from a peer using the GetPooledTransactions message.

@gsalgado this would be a bigger task but still valuable.  It would leverage your existing knowledge of the DevP2P protocol.


.NET 6 (and later) does not support LongEnumEqualityComparer

Inside StaticCache in HEAl.Attic there exists dynamic type lookups for different system types. One of these types is the LongEnumEqualityComparer, which is not supported in .NET 6 and 7 (maybe even earlier versions). A possible solution to this problem may be to ignore unloadable types (instead of throwing an exception). Nevertheless, the miss of LongEnumEqualityComparer could lead to break backwards compatibility.

Fixed with PR #46


No sensor appear to Energy -> Add consumption

Impossible to add a any EM sensors on HA Energy Module -> Electricity Grid -> Add Consumption.
I see only 1p7k Lifetime energy

Hello,
This will be added in EM's firmware in a future release.

Hello,
Thanks for the feedback.
Any idea of release date of the corresponding firmware ?
In my case I have the TRI model (3P22k).
Thanks


Fix UIScrollView indicator display in dark mode

Use .white indicator style in UIScrollView when in dark mode
According to https://developer.apple.com/documentation/uikit/uiscrollview/indicatorstyle, UIScrollViewIndicatorStyleWhite is a style of indicator is white and smaller than the default style. This style is good against a black content background, thus should be used in dark mode.

In addition, you may need to bump the version number.

In addition, you may need to bump the version number.

OK i should bump it to 0.6.0? should i make the change directly in master branch or should i make another PR?

@eyvallah Maybe a minor version since it is a bug fix. What do you think, @kylinroc?
We prefer a PR.

@eyvallah Maybe a minor version since it is a bug fix. What do you think, @kylinroc?
We prefer a PR.

I'm fine with both way since we are in 0.x.x version
https://semver.org/#how-should-i-deal-with-revisions-in-the-0yz-initial-development-phase


Fixing the documentation links

Documentation links in the readme file are broken links after the folder was moved

Thank you!


False positive of no-callback-in-promise in 7.2.0

In many different cases. Example:
'use strict';
var call = require('../internals/function-call');

module.exports = function (record, fn, ITERATOR_INSTEAD_OF_RECORD) {
  var iterator = ITERATOR_INSTEAD_OF_RECORD ? record : record.iterator;
  var next = record.next;
  var step, result;
  while (!(step = call(next, iterator)).done) { // 8:24  error  Avoid calling back inside of a promise  promise/no-callback-in-promise
    result = fn(step.value);
    if (result !== undefined) return result;
  }
};

Reproduction:
https://eslint-online-playground.netlify.app/#eNp9UsFu2zAM/RVVF9uAI99TBFuxZEAvy5DlVhWBYNOZOpnyJDnLUOTfR9pOsRZoT6b13uN7pPQsY6grOJuud6CeolzKbIggYgq2TtmtxpMJojbOiZUI8HuwAfJMqcpigoDGxaodsE7W44JZWUESjZ1vBuoH596HFEl6JYk8QO1DU4oWS3G/3+zu9tvd4f7bj/3mbn3Yfj3sNl+2u3UhnjUKweaWjEzygbq8zxefKB03Fsu5UFcdBZoaIZzTOMUI898LFBP0JSFxcNPhn5/WgchvckZIxLPlLClf8hSFajzCnFTMap4VR5U6GTcA74NR2/LoI+NmtRIDNtBahKYgXRoC/m9+0Xi5laWE6GjNqvbY2qPqxtuxHa9U9G44WvwefGfptlr6imyiLyZo0U9Ypin1KCFDw/YPbFFVQinF1atOs1d8yFpnUsWr6jqgrE32WGp8pFC9qX+ZI78Vj5RnHF7L9LcHLZdUscKjlkRnoIHTGnpugbWFyJx5X1p+nhJXT+OxlmQJMc1SJkz4h+CbcV9zr8uUl3/xm/vD

Looks like I'm experiencing the same issue. I noticed that many parts of my code fail linting when they include arguments named next, even though they're unrelated to promise usage.

@dependabot ignore this version

A reproduction is any CallExpression where the callee is not named like a callback and an argument is named like a callback.  A minimal repro:
function hasCallbackArg(callback) {
  console.log(callback);
}

This was regressed by 907753f4b6108ba78b93571a40b6f1384b3c6899
It appears that without the call to hasPromiseCallback, there is nothing to constrain the rule to code inside a promise.
CC: @brettz9


Have option to surpress generation of figure files

When I'm generating an html output file right now by essentially specifying only the input file, I get one html file plus a bunch of png files in the folder png. But those png files seem unnecessary, given that the graphics are already embedded in the html file.  Would be nice if there was an option so that the only file generated is the html file (or maybe even make that the default?).

I will fix this, the figures are just an artifact left from running the code and I think they should always be removed.

Great! And the folder as well? Maybe just use this to create the folder?

And I just realized that when I weave a jmd file, it generates an html and a md file in the directory. Is there some way to suppress the generation of the md file as well?

Not currently, but I will fix it as well.

Same with pdf files, and I assume some other formats as well. It would just generally be nice if the only file generated is the one requested, and nothing else.

It only happens for html and pdf (as other formats need to call pandoc, latex etc. and need the figures) I'm already working on a fix that will work pdf's as well.

Note that figures can't be removed when caching is used (well they could be for md2html but that needs more changes that I don't have time to do right now, but not for other formats).

Ok, so adding the temporary directory breaks figure pdf generation windows...

And fixed with  458ef30. I also implemented caching of embedded figures for html anyway so no extra files are left in the directory after a succesful call to weave.

Excellent!


Fix gcc9 build error test/src/unit-allocator.cpp (Issue #1472)

Hello,
This fix the compilation of  test/src/unit-allocator.cpp as described in issue #1472.
I validated the compilation + tests on:

gcc (GCC) 9.0.1 20190205 (experimental)
gcc (GCC) 8.2.1 20190205
gcc (GCC) 6.5.0

Congrats to @theodelrieu for this nice catch.

Coverage remained the same at 100.0% when pulling ddc9f201f45c58ff8d94e9fec5ad22873b965adc on stac47:fix_gcc9_allocator into 21516f2bae552a49cc1ba1c11746be3730361d8d on nlohmann:develop.

Merging even though Travis failed. The failing CI step is deprecated and removed in develop branch.

Thanks!


I cant find option to change theme

In linux version ther is no option to change theme to dark

Options menu appears when you right click the messenger icon in your taskbar.

The menu didn't appear for me when I right clicked the icon in the task bar (only the DE's standard context menu appeared), but it did work when I right clicked inside the program.

This is fixed in the next release

and when is the next release?

As soon as I can get the mac build from Aluxian

Please try the release:
https://github.com/Aluxian/Facebook-Messenger-Desktop/releases/tag/v1.4.8


Fix binary detection in Makefile

https://github.com/prometheus/alertmanager/issues/3624

@dgl  Please check if it is ok

Thanks for fixing the yaml lint issues. However, this is now conflating an actual change in the Makefile and lint fixes in one and the same commit.
@simonpasquier any reason why https://github.com/prometheus/prometheus/pull/13377 is still a draft?
In any case, @simonpasquier and @SuperQ should review the actual Makefile changes.
Lint cleanups are great, but they should happen in a separate commit (or even PR, if you don't want to wait for the actual changes to get reviewed).
And generally, our apologies for taking so long to review PRs.


lower account creation initial balance from 100 to 10

Fixes #990

It will be a breaking change for a lot of scripts that are relying on this amount. I would rather not merge it.
Isn't it better to increase the number of tokens in the original acc from 200 to ~1000?

I still don't understand why this couldn't be a major bump then.  I assume those are test scripts that could be updated to use the newer version.  From a devx perspective it's a weird default.

I still don't understand why this couldn't be a major bump then. I assume those are test scripts that could be updated to use the newer version. From a devx perspective it's a weird default.

Yeah, I do agree that 100 seems to be a weird default and yeah... most likely these scripts are tests that will need to be updated for users. Thoughts @volovyk-s ?

Isn't it better to increase the number of tokens in the original acc from 200 to ~1000?
I think if we did this the faucets would get depleted very quickly as some write scripts to create a dev-account then delete it and grab the 200 $NEAR. We did have the default set to 500 $NEAR and then lowered it... I think it was because someone was draining testnet faucets but not sure how lowering it by 300 resolved the issue. Let me see if I can dig up the reasoning of lowering initial balance of dev-accounts / testnet accounts.

FYI, testnet account creation that doesn't use a masterAccount to fund the account (e.g. the dev-deploy command, which only works on testnet) would not be impacted by this change, because testnet account creation is provided by a REST API call to the near-contract-helper, which ignores any value you provide and always gives every account the same 200N on creation.
FYI, the NEAR that are given to new dev-deploy created accounts are provided from the balance held by the testnet top-level account, which has a balance currently of over 55 million NEAR (https://explorer.testnet.near.org/accounts/testnet).
It is not clear to me whether, how, and/or how often the testnet account gets additional balance added to it, but if it is never increased, then using 200N per account, we could create around ~275,000 dev-deploy accounts before exhausting the current balance of the testnet account.  Is that something you are investigating already @thisisjoshford ?


isomorphic support

when requiring this module on an isomorphic app, it throws:
/whatever/node_modules/crossvent/node_modules/custom-event/index.js:24
'function' === typeof document.createEvent ? function CustomEvent (type, params) {
                      ^

ReferenceError: document is not defined

so this is an attemp to solve that

it seems that tests with zuul are not working anymore 😞

To be clear, this just makes the module requirable in Node.js. It doesn't actually make the CustomEvent() constructor work. It would throw the same document is not defined error if you tried to create an instance in Node.js

yep, the idea is to avoid doing:
let customEvent;
if (typeof document !== 'undefined') {
  customEvent = require('custom-event');
}

in an isomorphic code

Is that so terrible though? The flip side is that now you're loading code on the server-side that never gets used (small amount of memory, but still).
I'm not opposed to this patch, just wanted to understand your use-case a bit more clearly.

thanks!
any chance to bump a version with this change?

See v1.0.1


Dropdown menu broken

For the demo on http://language-translation-demo.mybluemix.net/
The dropdown menu for Choose Language in the "Output" section is broken.

you need to type a message to enable the dropdown in the output section

I see.  I'm not sure if this is intuitive since people decide the input and output language before inputting text but my issue has been resolved.  Thanks!

I think that this is a legitimate usability bug. I ran into this also and it took me a minute to figure it out.


[feature suggestion] elm-make auto insert type annotation

When using elm-make --warn, it warn and provide a guess of the function annotation.
It will be great if the tool can auto insert the type annotation if it can be surely guessed.
I am working it on, will make a pull request soon.
If there is an existing tool doing that, please kindly point me to that. Thank you.

I'm using this simple external tool for now:
build and tools/insert-type.js in https://github.com/beenotung/five-element/commit/451bb559327df4304ed00aadda99deebc42fb5b3
Will invest on the compiler source code later on.

i wonder if there is typescript definition for the output json

I think this should live in developer tooling. It makes sense for the compiler to provide the infrastructure to figure things out, but not to actually change the code. I think it is important to separate these concerns clearly.

maybe can be a package of the elm-x family?
Like golang do for go fix


UPEA boundary merge

Benefit
Update the UPEA Membership Districts data, map, and pdf with the merged boundaries.
Acceptance Criteria

[x] Merge 7-Uintah Basin District and 8-Southeastern District into a single boundary, 8 - Eastern.
[x] Eastern District boundary color should be the orange color of the current Southeastern boundary
[x] Remove District 7 from the legend

Notes
No response
Risks
Possible additional requests
Issue Reference
refs #

March 29, 2024
Audry Wood requested one more change to the map legend to remove the word "Officer's" from district 11, which Jake completed and sent back. I requested confirmation from Audry on April 3rd that the changes and project are complete.


Release 2.0.1

Questions
Answers

Description?
Release 2.0.1

Type?

BC breaks?

Deprecations?

Fixed ticket?

How to test?

@Hlavtox there's a conflict, you can sync your fork dev <-> dev, create a new branch on your fork, pull from master with rebase, and create a PR to fix the conflicts :)

@Hlavtox there's a conflict, you can sync your fork dev <-> dev, create a new branch on your fork, pull from master with rebase, and create a PR to fix the conflicts :)

@Hlavtox could you please check and fix the conflits before merge the PR !
Thank you ^^

@Hlavtox could you fix the conflict please?

@nicosomb Krystian was trying, but nothing is working. I think we will need to force push the master branch.

Hello , @kpodemski @Hlavtox
In a fresh shop , when I install the PR I see that there is some conflicts are not resolved yet ! You can see the attached screen shot !

Could you please check and feedback!
Thank you !

This PR needs a rebase, could you do that please ?

@hibatallahAouadni CTRL+F5


horiztonal logo n other stuff

I have updated the existing logo for landscape/horizontal display. Files have been added to the documentation _static directory as svg for better resolution. Compare my PR of the logo repo: https://github.com/brightway-lca/logo/pull/1

I adopted most of your edits last night - some I will need to open as separate tasks to make sure they are documented. Many thanks for your work during the hackathon!


koordlet: support cpu evict feature

Signed-off-by: Jason Liu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #147
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

Codecov Report

Merging #169 (274e958) into main (cb90038) will increase coverage by 0.47%.
The diff coverage is 70.11%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   57.82%   58.30%   +0.47%
==========================================
  Files          91       92       +1
  Lines        8159     8420     +261
==========================================
+ Hits         4718     4909     +191
- Misses       3029     3095      +66
- Partials      412      416       +4

Flag
Coverage Δ

unittests
58.30% <70.11%> (+0.47%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/koordlet/resmanager/resmanager.go
56.66% <0.00%> (-1.46%)
:arrow_down:

pkg/koordlet/resmanager/config.go
56.25% <50.00%> (-2.09%)
:arrow_down:

pkg/koordlet/resmanager/cpu_evict.go
70.91% <70.91%> (ø)

pkg/koordlet/resmanager/metrics_query.go
66.32% <100.00%> (+9.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb90038...274e958. Read the comment docs.

/cc @stormgbs

/lgtm

/approve


Authenticate with github account

acceptance criteria

[ ] all Jenkins users are authenticated with their github accounts
[ ] build results are still public accessible

rationale

LLVM contributors need a github account anyway.
keeping the credentials in files is annoying
we might want to give more people access eventually
2-factor-authentication is cool

won't fix because of #154


Plugin API raises DeprecationWarning in python3.x

When you want to use context parameter of the apply method, python3  interpreter compains about this: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec().

Fixing it is rather trivial, I have dealt with the same issue on a bottle Plugin I've written myself. I could create a pull request if you think that is worth resolving this.

Sure, as long as the change is backwards compatible with all supported python versions (>=2.7.3, >=3.3)

Dropping Python 3.3 support would be okay, though, if that helps.

raise ValueError if we added annotations on callback:
.venv\lib\site-packages\bottle.py:557: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()
  return getargspec(self.get_undecorated_callback())[0]
*** ValueError: Function has keyword-only parameters or annotations, use inspect.signature() API which can support them

I made a trivial pull request to fix this. https://github.com/bottlepy/bottle/pull/1381

Fixed in 0.12.23 and master (for some time now). Thanks :)


Need Active Slide Index on Init

I have this situation where i should add and delete slides dynamically.
Iam getting active index on change where i cannot get active index after deleting.
https://codesandbox.io/s/react-slick-playground-gd6lr

You can use initialSlide settings to set the value. The solution looks simple to your problem, but I hope this solves your problem.

but if infinite=true, the initialSlide does not work


[feature request] use IPython zmq-interface

First super awesome project.
Looking at ipython integration I suppose it would be possible to use the two-process console that uses zmq in contrib/ipython.py It would have the nice addition of beeing able to use this with all the kernels supported by IPython, bipython is using a similar approach.
I might take a shot at that later.

(I guess this is not relevant anymore.)


Indent correction to fix None handling for g.Conditional()

Fixes #870

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Joe 47878 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Enhancement] subRoute.exec()

The problem with route.exec() is how it executes every defined router so it's pretty inefficient when I just want to execute my custom tag's subrouter upon mounting for the first time. Although I can use route.query() to check unfortunately i need to parse my path as well.
Here's my pattern
<app>

</app>

app.tag:
route('search..', ()=> {
this.component = 'search';
this.update()
})

search.tag:
this.on("mount", ()=>{
  subRoute('search/*', (term)=>{ doSearch(term); });
  route.exec(); // this executes all other routers as well
});

Closing this issue because it's related to an old router version. Please update to the latest @riotjs/route version if you can.


how can i set the size of emoji

They replace the character with a span like this
.
Just style the span using the .em class in CSS.

can style using background-size,but it cannot support some older browsers,thx anyway

Sorry for the delay, I have tons of work.
I got the Apple emojis from the original Apple Font on OS X (macOS), I use a Ruby script to extract the PNG images from the font, then I join all the images creating a SVG file and converting the file to a PNG with all the images as one... that is the first part, second part is creating the CSS styles, the ones that define the width and height of the emoji, using the same logic I created a node.js script for creating that CSS style sheet, it has some vars that can be changed in order to display other size than 20x20px
Here is the last version I created:
https://github.com/rodrigopolo/minEmoji/tree/master/sprite_gen3


Tenant user rights

Platform: Chirpstack 4 on Docker, OpenSUSE 15.4.
When an unprivileged user logs in, Add gateway, Delete gateway, Delete device buttons are enabled. After clicking on any of these buttons, the user is logged out.

I'm not sure if I can reproduce all cases:
Steps I tried:

I created an active / non-admin user
I added this user to the default tenant, without any admin rights

I do not see add gateway or delete gateway buttons. I do see the delete device button, which on click redirects to login (because of auth error of the API). The issue was a missing  block around this component, checking if the user was authorized to perform this action and if not, hide the button.


Small typo I think

On the left it says I should use /\d+/gi
However if I do that throws an error...
and the correct expression should be:
var expression = /\d+/gi;
notice that theres an extra \ in the suggested code. Once I took that out, the code worked. Maybe its a typo?
Thanks!
Waypoint: Find Numbers with Regular Expressions
We can use special selectors in Regular Expressions to select a particular type of value.
One such selector is the digit selector \d which is used to grab the numbers in a string.
It is used like this: /\d/g.
For numbers this is often written as /\d+/g, where the + following the digit selector allows this regular expression to match multi-digit numbers.
Use the \d selector to select the number of numbers in the string, allowing for the possibility of multi-digit numbers.

If you look at test case and find there an extra \ in suggested code, then there is not a typo. There is an special escape character in string (which assert() will should show you). This special character need to show simple \. It is looks like \n for new line or \t for tabulation.
!msdn example
assert(editor.getValue().match(/\/\\d\+\//gi),
           'message: You should be using the following expression /\\d+/gi to find the numbers in the testString.');
message: You should be using the following expression /\d+/gi to find the numbers in the testString.

Closing this issue. I think @tva10 answered fully, thanks.


server to test with

does this include server too ? possibly even an existing server.
if the only thing holding you back is testing with real dodge we should find a way to get you some then.  ebay is an easy source for them without signing up to anything.

@netpipe Have you tried with ElectrumX ? It suppose to have Dogecoin support

I have not tested it yet, when it goes public likely dogecoin will goto 50 cents or higher. it makes coins easier to sort and manage.

https://github.com/c4pt000/electrum-doge-server seems to have been updated last year


fixed username -> email; updated readme for github/google login

Addresses #41 and #42.
How does versioning work here? Should we wait until we address #40 and then bump to 1.0.1?

Looks good so far, I will let you know when I have the api endpoint to do here too, I hope today.
Maybe we do 1.1.0 as it's not a minor change?


Update dependabot config to cover GHA

Problem
We have inconsistent and under-configured dependabot config files.
Solution
Consistify them.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Two failed tests are known flaky tests that produced the expected error logs (cannot open relation with OID ).


FtpClient does not honor CanSeek property of the Stream class

FTP OS: Not relevant
FTP Server: Not relevant
Computer OS: Any
UploadFileInternal method of FtpClient class relies on Stream Length property and does not honor related CanSeek property like it does for rewinding the stream. If the stream does not support seeking, the Length property of the Stream class will throw NotSupportedException. One should not rely on Stream length to determine when writing is finished but rather when no more data can be read from the stream.
Logs :
Not needed.

Thanks for this. However, unless this code crashes with an exception we prefer not to change underlying details. The code is time tested and battle hardened, and any messing around with it usually results in more side effects.


[Symfony 3.0] Remove FormTypeWithDependencyToOptionsRector, as it always require manual check of code

Ref issue caused by this rule https://github.com/rectorphp/rector-symfony/pull/467#issuecomment-1619457378
Instead, it should be handled manually on per-case basis :+1:

I think this is a great move. 👍🏻 This rector isn't even relevant anymore for newer Symfony versions, as the form type must be passed as class-string, and never as instance.

@bobvandevijver Perfect, thanks for constructive feedback on this one :+1:


Panic in v2.8.0 that is not occurring in 2.7.18

It's occurring on this ln485 in client.go
if c.client.androidVersion > 0 {
			return format.URL, nil
		}

It would appear the the issue is coming from:
client *clientInfo
as my current value while debugging is: client:
*github.com/kkdai/youtube/v2.clientInfo nil
This is occurring on all links/urls, not anything in particular.

Exception has occurred: panic
"runtime error: invalid memory address or nil pointer dereference"
Stack:
4  0x0000000000ce1cf3 in github.com/kkdai/youtube/v2.(*Client).GetStreamURLContext
at /home/light/go/pkg/mod/github.com/kkdai/youtube/v2@v2.8.0/client.go:485
5  0x0000000000ce1b8c in github.com/kkdai/youtube/v2.(*Client).GetStreamURL
at /home/light/go/pkg/mod/github.com/kkdai/youtube/v2@v2.8.0/client.go:475
6  0x0000000000ce011b in github.com/kkdai/youtube/v2.(*Client).GetStreamContext
at /home/light/go/pkg/mod/github.com/kkdai/youtube/v2@v2.8.0/client.go:320
7  0x0000000000cdff7b in github.com/kkdai/youtube/v2.(*Client).GetStream
at /home/light/go/pkg/mod/github.com/kkdai/youtube/v2@v2.8.0/client.go:315
8  0x0000000000cf5ac5 in main.DownloadVideo
at /home/light/goget/yt.go:63
9  0x0000000000cf5734 in main.GetMedia
at /home/light/goget/yt.go:42
10  0x0000000000cf47e5 in main.DownloadHandler.func1
at /home/light/goget/web.go:62

I think you are right about the origin of this panic, I was able to get it working in https://github.com/norwnd/youtube/releases/tag/v2.8.1,
leaving it here in case somebody needs resolution fast. I hope repo maintainers could get to this sooner or later and maybe prepare a proper fix (or borrow mine), I'd try to avoid the lazy initialization here which seems to be the culprit (the issue might show up in other places in the code we haven't hit so far).


Support full filenames in logs.

@spinorx thanks for the pull request.
Please provide the following

Addition to the Options cmake file. Please make the default for this define as false.
A description for the pull request. For historical reasons a one or two liners - however obvious makes it easier for people when browsing changes.

Cheers
Kjell

Updated.  Let me know.  Also fixed 2 macros which didn't have parentheses around them.

:+1:

Thanks for the contribution


Variant to Reference vs ReferenceSet links

From my understanding, a reference in the v2 model is a sequence (equivalent to a linkage-group if we refer to v1). A referenceSet is a set of references, and thus potentially represents the entire genome sequence.
I find the current situation confusing because:

The SVG data model https://brapi.org/docs/brapi_test_server_data_model_v2.0.svg shows a reference_set_id field in the Variant object, which would suggest that a Variant is directly linked to a ReferenceSet.

Apiary does not show this field (so I guess the SVG is probably obsolete). It says however that Variant objects should have a referenceName (which looks good to me), but does not mention a referenceDbId. I think it should, because a Variant is meant to be positioned on a reference.

Am I missing something? Please guys tell me your opinion.

... this is all the more confusing as /search/variants allows filtering by referenceDbId


An explicit way to choose between behaviors that want to act at the same time.

Decided is to use: behavior calling order.


Update legacy v2.2 branch

I was using the v2.2 branch via :git reference, and seems it has fallen behind v2.1 branch. This PR adds in the fixes from v2.1 to v2.2. Please consider releasing v2.2 if possible in order to tie up the loose ends.

I don't think we are going to release 2.2. I started this branch as experiment to see if we could backport some of the 3.0 features to 2.x release but it was not worth.

OK, will close PR then.


checkbox icon in "checkbox plugin"

Hi,
Is there an easy way to change the icons of both selected & unselected checkboxes?
For example, Putting a star icon and an empty-star icon instead.
Thx

The easiest way would be to modify the sprite in the default theme directory. Or you can create a copy of the default theme, change the name and modify the sprite.
Best regards,
Ivan


better handling when you send a message

In whatsapp when you send a message it show almost inmediatelly the message, but use visual feedbak to show if the message was sent, received, etc. In sphynx you sent a message and it dissapear for a few seconds, and then suddenly appears, its weird and make you think that something went wrong.

there is a 1-2 second delay between pressing send on the msg and when the msg shows up in the chat view

I think this is fixed.


[cherry-pick] add release note (#5438)

Add release note
Co-authored-by: Mingliang Tao<EMAIL_ADDRESS>

Coverage remained the same at 33.818% when pulling 8a8b7201acee9c08da661fa7370f15870d3cac29 on binyli/release-note-master into f54dff4050d8d6266103b6ebb65497b0777d236d on master.


same bug as solid-file-client

for name appearing more than once in fullname
see pull request #7  last commit https://github.com/jeff-zucker/solid-ide/pull/7/commits/e5a874bbe9f2f9870ed7c3e5e94323afad180dbe
I have difficulty to make a new pull not including the previous one. May be I should have deleted my fork before making a new commit ?

Oh, yeah, I had that problem with a PR I submitted to someone else.  I ended up deleting my fork, re-forking, then submitting the PR.  There may be an easier way, but I don't know about it.  If it's easier, I can just cut and paste this time.

Ok I deleted and recreated the fork and made a new pull and issue.
Le jeu. 28 mars 2019 à 19:59, Jeff Zucker<EMAIL_ADDRESS>a
écrit :

Oh, yeah, I had that problem with a PR I submitted to someone else. I
ended up deleting my fork, re-forking, then submitting the PR. There may be
an easier way, but I don't know about it. If it's easier, I can just cut
and paste this time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jeff-zucker/solid-ide/issues/13#issuecomment-477728941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHZ5jwhj88posOPtV01DC3diEBbLx9eks5vbREEgaJpZM4cQ3xT
.

see PR #14


Aggregation API update

The CS API will follow this principle:
a) we don't bundle during sync
b) when you get a bundled event then those counts are accurate as of that API call, so don't update the counts
This has been discussed at https://matrix.to/#/!fuiphBbxmgKxJjXYFn:matrix.org/$155844046336cSPsh:jki.re?via=matrix.org&via=jki.re&via=lant.uk

[x] This means that the implementation just needs to update the reaction summary only on live reaction events. It does not need to update it on reaction events received while paginating.
[x] Optionally, for HS not supporting the aggregation API yet, we can support building reaction summary from reactions received while paginating.

Kamino cloned this issue to vector-im/riotX-android

Moved to phase:2 as synapse is not yet ready.


SubscriberHistory improvements [6343]

This PR:

should fix #708
improves performance on SubscribeHistory by doing unchangeable QoS comparisons only on creation
removes two unused and incorrectly implemented methods

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows


Feat: enable NOSONAR comment to ignore warning

Signed-off-by: henry-lp<EMAIL_ADDRESS>

@fermadeiral ready for review

Nice, @henry-lp! Thank you!

@fermadeiral thanks for merging . Can you Aldo deploy Sorald since I need the newest changes for Repairnator :) ?


Allow volunteering start date to be up until the next cycle starts

Need to wait for sign off from ProVendor before merging
Context
Based on some feedback Gaby gave from a TTA, it seems like candidates would like like the ability to add volunteering experiences they've signed up for, but have not yet completed.
This will save them some word count in the personal statement.
Changes proposed in this pull request
-Allow candidates to add volunteering experiences that start before the beginning of the next cycle
Guidance to review
While looking at this it seemed to make sense to me that they would have to start their voluntary work before the launch of the next cycle.
The only edge case i can think of is people who are applying with the intention of deferring. Seems like a fairly niche edge case though. Interested to hear what people think.
Link to Trello card
https://trello.com/c/y6fUTOSX/4011-allow-candidates-to-enter-volunteering-experiences-before-the-start-of-the-next-cycle
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

closing for now


fixed horizontal scrolling

Fixing the issue that the column in the ColumnLayout was horizontally scrollable on some browsers.
Checklist:

[ ] Test added / Snapshots updated
[ ] Documentation added / updated

didnt we remove this because of the chrome bug lately?


Parse the line table of GSYM files.

The line table of GSYM file provide a way to translate an address to the file name and the line number of its source code if there is.
Signed-off-by: Kui-Feng Lee<EMAIL_ADDRESS>

We spoke. I will finish up the pull request, because it is blocking upcoming work that relies on this functionality. I will close this one and create a new one once I have something.


fix #121: update all objects, even when port is missing

Fix issue https://github.com/skippbox/kompose/issues/121

I saw this issue and the created a code change locally, but then saw this PR!


Improve loading error messages

Increase developer feedback on experiment loading errors.
Context
The method loadFail captures the majority of the loading errors and shows a generic error message on the screen.  Developers are having hard times figuring out what is the issue. As a consequence some times they create duplicated GitHub Discussions or Issues.
By improving the error messages we:

Reduce the time to solve the problem by the developer.
Reduce the number of Issues/Discussions in the repo.

Test
Before the change:

After the change, some examples:

Next steps:

Group messages on the same place.
Allow third parties (developer, browser or other SDK) to catch the error.

Looking forward to hear your feedback :D

@javidalpe thanks very much for this suggestion! I completely agree about the benefits of improving the loading error messages.
One thing I'm wondering is if the main message on the page should be aimed at the participant rather than the researcher, with instructions to contact the researcher and pass on the detailed error message.
Another thing that occurs to me is that this should probably be parameterized to provide better support for different spoken languages. (But this is also true with the existing default "The experiment failed to load" error message). If we went with your suggestion here, maybe the first part of the message could be parameterized so that it can be written in different languages, include instructions for contacting the researcher etc., and the second part (error details and how to fix) can remain hard-coded in jsPsych in English.
@jodeleeuw do you have thoughts on a milestone for this?

Thank you for the feedback @becky-gilbert . I had the same concerns during development, and I'm still not sure how the UI should be. Some of the errors can appear during development, some will appear mostly on production.

I agree with @becky-gilbert that the error displayed to the user should probably not be aimed at the developer. We could add a fancier UI that displays the complete error message after a button click.
I'm also wondering if part of the solution here is to convert the preloading features into a plugin and move them out of jspsych.js. This might make it easier to parameterize, and also allows for easier customization by researchers. It would also provide a built-in solution to perform partial caching of materials throughout the experiment. We've seen that feature needed in many cases, e.g. #724.
The downside is that automatic preloading wouldn't be as easy to support. But we could still populate a list of media to preload at the start of the experiment and allow the plugin to access that list. So the experience might be:
var preload = {
	type: 'preload',
	auto_preload: true,
	images: [...],
	audio: [...],
	video: [.,.],
	show_progress_bar: true,
	loading_message: '
whatever html here.
',
	show_detailed_errors: true,
	max_load_time: 60000
}

@javidalpe do you have suggestions about how to make it possible for 3rd parties to catch errors? What's the smoothest way we can provide that experience?

The preloading plugin is a great idea! The researcher could add a preloading trial to the timeline at any moment:
    var preloading  = {
    type: 'preload',
	auto_preload: true,
	images: [...],
	audio: [...],
	video: [...],
	show_progress_bar: true,
	loading_message: '
whatever html here.
',
	show_detailed_errors: true,
	max_load_time: 60000
   }
    var hello_trial = {
        type: 'html-keyboard-response',
        stimulus: 'Hello world!'
    }

    jsPsych.init({
        timeline: [preloading, hello_trial]
    })

Regarding catching error messages by third parties, you could simply add a "on_error" callback to the init parameters. Then, if there is no observer listening for 'on_error' events, you could display the technical error on the screen. If there is an observer, hide the technical error from the participant.
Happy new year!

Closing this as these changes have been made in the context of the new preload plugin (issue #1351 and PR #1496).
Thanks again for your suggestions @javidalpe! Although we weren't able to merge this because of changes to how preloading works, we incorporated your suggestions by including a show_detailed_errors option in the preload plugin that can be set to true or false. If you have further suggestions for improving the loading error messages, then please feel free to submit another PR against the updated master branch.