Autoform + i18n?

It would be very nice to have a built-in integration with a package such as @theosp's tap:i1n8.
For example, maybe if an i18n option is set, Autoform could get the label via tap:i18n using the field name as key, instead of via the label option?

Hello !
My option, for the moment, is :
Books.attachSchema(new SimpleSchema({
  title: {
    type: String,
    label: function() {
      if(Meteor.isClient) {
        return(TAPi18n.__('labels.title'));
      }else{
        return('title');
      }
    },
    max: 200
}));

The label part can't be placed inline... And the i18n can work on the server. ;)

I found a cleaner way to do i18n. Just before attaching the schema, I do this:
_.each(postSchemaObject, function (property, key) {
  if (!property.label) {
    postSchemaObject[key].label = function () {
      return i18n.t(key)
    };
  }
});

I go over each schema property. If it doesn't already have a label, I set the label to a function that returns an i18n string based on the property name (key).
Oh, and I use a function instead of setting the label directly to make sure it's evaluated later on once the i18n stuff is already defined.
I can then go on and define and attach the schema as usual:
Posts = new Meteor.Collection("posts");

postSchema = new SimpleSchema(postSchemaObject);

Posts.attachSchema(postSchema);

@SachaG any ideas how we could make it more "built in" without committing to any one i18n library/solution?
I'm thinking maybe:
SimpleSchema.defaultLabel = function (key) {
  return i18n.t(key);
};

SS would simply check whether SimpleSchema.defaultLabel is set to a function and use that as fallback before resorting to humanizing the key string.

That sounds perfect :)

Just to give more info about my use case: I want each field to have an i18n string based on its name. But if no string is defined, the label should fall back to humanizing the key.
Additionally, if a label is explicitly defined (for example someone is customizing Telescope and just wants to overwrite a single label, not i18n'ize the whole thing), then it should just use that.
So I think your solution covers it pretty well. In order of priority, it would use:

The label property.
The result of defaultlabel(key).
The result of humanize(key).

This sounds like a suitable solution for me as well.

Started writing i18n error messages, feel free to contribute! https://github.com/gwendall/meteor-autoform-i18n

Moved this issue to simple schema repo: https://github.com/aldeed/meteor-simple-schema/issues/343

FYI, I also published a package for this purpose. https://github.com/gwendall/meteor-autoform-i18n

Yeah @gwendall, thanks. I looked briefly at it the other day and it seemed like a good solution. My goal is just to make any core changes to better enable packages like yours, so if you have any suggestions let me know.

I'm using @gadicc meter messageformat which is working great and very simple to implement IE|:
title: {
type: String,
label: mf('title', 'Title'),
max: 200
},
but it's not reactive I wounding if there is a way to rerun the Schema so it reloads if a language is changed?

I am still not competent enough for understanding all what was said in the thread,
but here is my POV: 1) a web app needs to language scalability from day 1 (this means everithing displayed).

Not sure how similar it is with i18n method, but my idea was to assign, athe the router, a different language specific collection to the same "label" collection variable name. It would be reactive with its subscription. Then some reactive code would load reactive objects with its content. So, the name=attribute, should be able to trigger the lookup in the object.

A final (dream come true) would be the possibility to "fit-in" the label content to the surrounding container, so if the translated text is longer, it woud either wrap lines or further reduce font size.
Bottom of the line: having only one template for all languages.

Thanks for your hidden work!
Marc

after updating to 5.7.1, the previous trick to implement language switch is no longer working, any idea of what happened? (Reverting to 5.4.0 makes it work again)
getLabelsFor = (schema, name, sessionLanguage) ->
  labels = {}
  for fieldName in schema._schemaKeys
    i18n_key = name.charAt(0).toLowerCase() + name.slice(1) + "." + fieldName.split(".$").join("")
    # console.log "schema:  " + name + "  fieldName:  " + fieldName + " i18nkey: " + i18n_key
    translation = i18n.t(i18n_key)
    if new RegExp('string').test(translation) isnt true and translation isnt i18n_key
      # schema._schema[fieldName].label =  i18n.t(i18n_key)
      labels[fieldName] = translation
  return labels


Battle music sometimes won't stop

the battle music sometimes doesn't stop even on qtd and qtm the save itself is stuck with it until i do something that causes it to not do that. is that a you issue or Skyrim issue?

Lol this is a classic Skyrim Civil War bug. This must mean that the Civil War siege is still running for some reason. You usually can teleport somewhere else to get it to stop. I also put something in the 'Get CWO Unstuck' MCM option to stop the music. Let me know if either of those work.

teleporting never works and mcm menu i think but i'll have to confirm it tomorrow

Can send me a screen of the CWO Debug MCM?

i am not at my computer at the moment so i am unable to but when i will when i do

My music is still stuck from taking Morthal for the Stormcloaks. The debug MCM says it thinks I'm in Haafingar even though I'm in Eastmarch. I don't see an option in the menu to stop the music.
Fast traveling many places does not resolve. Talked to Ulfric, successfully got next quest, but music still going. Fast traveling many other places still does not end music.

Did you do fix quest?

Also if you don’t mind me asking what country are you from, I can’t tell if you are from around Australia/Britain or if you’re just an American with a very scuffed sleep schedule

The "help quests get unstuck" option does end the music. It also seemed to skip forward a bit, though. Not sure if I was supposed to do more than take one fort before Solitude.
I'm in the USA.

Okay, I reloaded and see that it only skipped over Galmar giving me money and telling me about the next quest. So I did that and THEN did the unstuck option and all seems good now.

The "help quests get unstuck" option does end the music. It also seemed to skip forward a bit, though. Not sure if I was supposed to do more than take one fort before Solitude.

you are, please lose the battle of solitude for me :)

I'm in the USA.

wow, what time is it for you, it is 8am here

Okay, I reloaded and see that it only skipped over Galmar giving me money and telling me about the next quest. So I did that and THEN did the unstuck option and all seems good now.

I thought ulfric was the guy who reluctantly pays you

It's 6 PM. Galmar does most of the paying. No apparent reluctance.

It's 6 PM. Galmar does most of the paying. No apparent reluctance.

I don’t think that is meant to happen unless it is the one time payment from winning sieges, as ulfric usually pays you when you ask for pay and try’s to swindle you out of it by “donating” it to the “cause”

Ah I see 6pm not too late then, is that east coast or west?

I've never heard any dialogue along those lines. East.

Okay, I reloaded and see that it only skipped over Galmar giving me money and telling me about the next quest. So I did that and THEN did the unstuck option and all seems good now.

Okay cool that’s what is meant to happen minus the lack of money.

I've never heard any dialogue along those lines. East.

Have you spoken to Ulfric? I usually do a stormcloak traitor route and every time I report back to him when you ask for your pay he says “are you sure?” Whereas Tullius is like I got you fam

Yes, I've spoken to Ulfric. There's never an option to ask for pay. It's simply given.

okay that’s not normal, Ulfric specifically is supposed to give you an option radiantly when you come back to ask for pay (post siege captures don’t count as pay is always given for that)

Okay, I reloaded and see that it only skipped over Galmar giving me money and telling me about the next quest. So I did that and THEN did the unstuck option and all seems good now.

Quote replying to this to “pin this” so that it can be found easier

Music also stuck after winning Solitude. Trying the unstuck option there gave a message about trying to set up the final siege (which was already completed), ended the music, but then started it again.

I also notice my follower was missing, probably because she's the Solitude housecarl. Unstuck made her reappear where I had fast traveled to but still doesn't seem a suitable workaround in this case.

The console command to manually stop the music (both ran directly and via the unstuck MCM) just result in the music instantly restarting for me. Also no resolution from traveling, additional combat, console command to kill player, or relaunching game.

The console command to manually stop the music (both ran directly and via the unstuck MCM) just result in the music instantly restarting for me. Also no resolution from traveling, additional combat, console command to kill player, or relaunching game.

The issue is save based, if it happens and you save it there, that save will have the issue, other saves do not

The console command to manually stop the music (both ran directly and via the unstuck MCM) just result in the music instantly restarting for me. Also no resolution from traveling, additional combat, console command to kill player, or relaunching game.

Unstuck quest both works and doesn’t work at the same time, it is finicky

I did have a save from before the entire battle. Repeated it and found that upper door. Worked normally there except music still stuck.

update: button worked the first time in solitude but failed in my older stormcloak save

update update: it works too well it disables it and it doesn't reactivate on new siege

update update update: button works

button is very finnicky sometime it works straight away sometimes the music loops for a bit then stops

button is very finnicky sometime it works straight away sometimes the music loops for a bit then stops

This is unfortunately an engine thing. I cannot do anything about this unfortunately


Update landing page

Describe your changes
update 3 landing pages based on Figma design
Fixes #14 (issue)
@yellowHatpro please have a look on the design :)
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code
[x] My changes generate no new warnings
[x] Have you successfully run tests with your changes locally?

Have edited the black circle in different page

Hi @HYnam , Thanks for the work. It looks really good 💯 . I've left a small comment to replace the scale units.

LGTM! Thanks for the work 💯


Fix keyboard shortcuts typos

The backslash was causing strange formatting, as it was interpreted as an escape for the <kbd> HTML tag
Why:
Fix keyboard shortcuts typos/formatting

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

15 noy 2023, Ç. 12:59 tarixində github-actions[bot] <
@.***> yazdı:

Thanks very much for contributing! Your pull request has been merged 🎉
You should see your changes appear on the site in approximately 24 hours.
If you're looking for your next contribution, check out our help wanted
issues
https://github.com/github/docs/issues?q=is%3Aopen+is%3Aissue+label%3A"help+wanted"
⚡
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/29963#issuecomment-1812045144, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BDWRSMPCZTD2K2FKZUAZELTYER76JAVCNFSM6AAAAAA7LOGRCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGA2DKMJUGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Ensure no user account is associated on login attempt

Ensure no user account is associated on login attempt
:recycle: Current situation & Problem
This PR contains some minor changes that make sure that no user account is associated when we try to login or signup for a new user account.
:gear: Release Notes

Perform automatic signOut on a new login attempt.
Added additional logging output.

:books: Documentation
--
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Thank you for adding this @Supereg!


Fix texture naming on GLTF load

The GLTF loader renames loaded textures to "materialName ({TextureType})" on load, breaking our .babylon serializer, as the original name is lost.
This PR proposes that we change the GLTF loader to name textures with the name provided by the GLTF texture, and remove the default naming schema.

This was done on purpose as the texture names in the file are not guaranteed to be unique. Maybe we should have a flag that does one or the other.

Furthermore, there is not a one-to-one mapping between glTF textures and Babylon textures. Babylon textures are more like a glTF textureInfo object which does not have a name.

@Drigax, I think we should revert and find another way, cause this will create texture clash in the sandbox for instance, as Gary said this was the main reason of introducing the naming. Can you take care of it ?

That's a pretty good reason to change the names, we can add a flag to the loader, but I'm not sure how useful that would be.
We can always try to rename at export using the babylonTexture url as the name instead.

Giving this more thought @sebavan why is having multiple textures in the sandbox that share names even an issue? The textures are given unique Identifiers. I noticed that #6521 causes this to happen without issue, as far as I can tell.

Babylon is having a cache system for textures and basically the new one will be taken from the cache instead of the given uri

https://github.com/BabylonJS/Babylon.js/blob/master/src/Materials/Textures/baseTexture.ts#L530

Right, but we use the image uri to check the cache, not the texture name. I'm currently unsure how we can use multiple images that share name (say we have two models that both have their own unique "texture.png" in their own local directory) but, so far my limited testing isn't showing much issue

So currently https://github.com/BabylonJS/Babylon.js/blob/master/src/Materials/Textures/texture.ts#L274 name and url are often the same. Maybe we can add a originURL smwhere to keep track of it.
But why do we need it in the first place ?
The main issue is to prevent broken import, why not reading the current texture pixels values with to recreate a new texture if the path is not valid ?

Well url should be the originUrl :)


items left-margins not equals

in demo the same problem in VWY letters

sorry :) i have found option "layout_pin_width" in src :) all OK

Good :) Then I'm gonna close the issue.


Make the GitHub buttons more accessible

The link to a crate's repository is the feature I use the most; we still have space in top bar, so why not moving the button there?

This is a duplicate of https://github.com/rust-lang/docs.rs/issues/61.


HDDS-11054. native check fails with Java11+

What changes were proposed in this pull request?
native check fails when run with Java 11 or later.
$ export JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
$ mvn -Drocks_tools_native -Pnative clean test
...
Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:copy-dependencies (copy-jars) on project hdds-rocks-native: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187

This was reported earlier in HDDS-10118, but mistakenly thought to be fixed, because we were trying to reproduce with mvn clean install.  The problem only happens if Maven goal preceding package is executed.
The workaround is to run tests by using verify goal, which is after package in the lifecycle.
Also, remove hard-coded compile source/target of Java 8 in the native module.
https://issues.apache.org/jira/browse/HDDS-11054
How was this patch tested?
Native check with Java 11:
https://github.com/adoroszlai/ozone/actions/runs/9625813024/job/26551221261#step:6:14
https://github.com/adoroszlai/ozone/actions/runs/9625813024/job/26551221261#step:6:1383
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/9625801311

@hemantk-12 @smengcl @swamirishi can you please review?


Stacking and masking scripts not fully work via GUI anymore

Stacking and masking scripts not fully work via GUI anymore.
I have done several test scanning (using latest software versions) and every time i get all raw images, but after 5 - 40 stacking and masking images rest of these images remain uncreated. Is this results in some kind of memory leak??
Now when scanning is done and axis go back to homes, these scripts also stop. In an earlier scAnt version these scripts stopped after the images were completed.
This is not big deal for me, i can also run these scripts separately as instructed. This may make the process a little faster...
Software
scAnt 1.2
Anaconda Navigator 2.1.2
SpinnakerSDK_FULL_<IP_ADDRESS>_x64
spinnaker_python-<IP_ADDRESS>-cp37-cp37m-win_amd64.whl
My computer
Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz x64
RAM 16,0 GB
GeForce RTX 3070
Free disk space over 600 GB

Thanks for letting us know!
Will look into this issue asap and come back with a solution

The issue should now be fixed! After scanning is completed, stacking and masking scripts should continue to work through all queued images. Let me know if the problem persists on your side!

Awesome! Thanks a lot for letting me know!


fix(sequencer): respect max_tx_bytes when preparing proposals

Summary
Ensures that cometBFT blocks will not become too large during prepare_proposal() from the addition of commitments to the front of the block.
Background
cometBFT sends in a max_tx_bytes parameter to the ABCI prepare_proposal() that should be respected when modifying the block. We currently add commitments to the front of the block for the included rollup ids and included rollup transactions. It is possible that adding these bytes will cause the cometBFT block to be larger than the max_tx_bytes parameter.
Changes

Prevents cometBFT blocks from becoming too large from adding the commitments to the front of the block.

Testing

Added new unit test ensuring that overflow is okay.
Ran local setup to ensure that transactions still flow through the system in general.

Issues
closes https://github.com/astriaorg/astria/issues/850

addressed all the comments!

I'm not 100% on what I did regarding returning/managing errors. I don't have a good sense yet of the idiomatic way to do error handling is for the codebase 🫣


New version: Jackett.Jackett version 0.20.1129

Pull request has been automatically created using 🛫 WinGet Releaser.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Fix terminology: injecting transactions into blocks-> batches

Signed-off-by: Hans Jin<EMAIL_ADDRESS>

@LiyanJin fyi we were able to sort out the formatting error causing the DCO problem for your commits. All good now. Thanks.

@dcmiddle @ryjones Thank you so much for helping me out of this formatting error and Signed-off problem.


[Global] Update types to adhere to React 18

Description
There are new React 18 type definitions. One of the breaking changes is that children are no longer implicitly allowed in FunctionComponent definitions.
This will break the build when people upgrade to React 18 and the new official type definitions.
To solve this, this PR ran the recommended codemod for v18 against all code in ./packages.
I only had to update one test where we test not passing children to a component that requires it, so I omitted children there.

Hey @janhoogeveen , thanks for this! we’ll soon be raising some changes specific to React 18 which should address these type issues (and potentially supersede this PR), but wanted to chime in to say we have looked at your PR and appreciate the contribution so far.

Hey @janhoogeveen, thanks for your initial work on this!
We've got a PR (#1329) with more React 18 updates that supersedes this one, so I'll close it now.
Thanks 🙏

Sweet. Ty!


Copy error during deployment from Linux

I had following errors during the deployment through terraform apply:

That's simple🙂: you enabled a windows_overwrite_local_kube_config variable, which copies a kube config into user folder (to enable kubectl commands without any params). Unfortunately, this command targets Windows OS. I think you'll need to disable this variable (in your variables.auto.tfvars file).
The file is also copied from the control plane, so we can use kubectl like the following: kubectl  --kubeconfig .terraform/.kube/config-external (when called from the root of the cloned repo after provisioning is complete)

Thank you. Now all right.

Great!


[runtime/ipex]update libIPEX download url

Recently libIPEX download URLs are upgraded to https, so update is needed in cmake file.

@xingchensong @robin1001  Please help review and merge, thanks!

will merge this a bit later


fix(protocol-designer): disable load liquid save if no liquid selected

Closes RQA-2728
Overview
When loading a liquid into labware wells in LiquidPlacementForm, we need to disable 'Save' if the volume is 0, null, or '', OR the selected liquid is null or ''.
Test Plan

Create OT-2 or Flex PD protocol
Create a liquid
Load a labware
Select the labware's 'Name and Liquids' to add a liquid
Select any wells of the labware
Enter a non-zero volume, but leave the 'Liquid' dropdown empty
Verify that the 'Save' button is disabled

Changelog

check for null or empty string value for selectedLiquidId in LiquidPlacementForm save button disabled prop

Risk assessment
low

thanks! lgtm!
random thing but the arrow in for the liquid dropdown is large - i think you aren't up to date with latest edge? 🤔

yeah my bad, this branch was accidentally based off chore_release-7.3.0 and I screenshotted before rebasing off edge. I updated the screenshot in the PR body!


Rename to parity-rocksdb and publish to crates

If we're not going to try to upstream the changes in this fork I think we should rename it so we can publish it to crates.

And also update the README while we're at it.

This is needed to publish kvdb-rocksdb which is blocking https://github.com/paritytech/parity-ethereum/pull/9410

Fixed in #18.


[JAX] Add checkpoint_name for the recompute granularity control

Add checkpoint_name for TE's tensors. That enables the support for different checkpoint_policy in PAXML.

/te-ci jax

/te-ci jax


Deleting reports and changing subfolders in the test tab

The following actions in the test tab cause a surprise:

In the root folder, select multiple reports from different folders.
Change to a subfolder from which some records were selected.
You only see the reports that are in the subfolder, works as expected.
Press the delete button.
See the error: the confirmation dialog shows all reports initially selected, also the ones that were not visible anymore when delete was pressed.

Expected behavior: reports that get out of scope should not be deleted, as confirmed by @jacodg. Question: does this also mean that reports should be deselected when they get out of sight?

When not visible I don't see where they can be (de)selected. In memory waiting to be displayed in the future?

Suppose you have reports in different folder. When you are in the root you can see them all. Suppose you select reports from different folder. When you select a subfolder, you do not see all selected reports. Should the frontend automatically de-select the reports that no longer shown?
This would have two implications. First if you would select the root folder again, less reports would be selected than you originally selected. Only the reports you selected earlier that were also in the subfolder would be selected at this point. Second, this approach guarantees that the reports being deleted are always the selected reports.
Or do we do it the other way. We can also remember what reports were selected when we change subfolder. Then you have the same reports selected again when you select a subfolder and then the root folder again. But if you press delete, you are not deleting all selected reports, only the subset of selected reports that is in the currently selected subfolder.

I don't thinks we should remember selected folders after a different folder has been clicked. When a folder is clicked I think is is nice when all the reports which are direct children of this folder are selected by default and all report that are shown because they are in a subfolder of the selected folder are unselected by default. This is also how the old GUI is doing it.

A fix for the test tab folders in is review right now, please check if this issue still persists after merging with master or check this issue on branch: fix/test-tab-folders

[ ] #650

When I change folders, all reports are selected by default. OK.
When I select all reports of the root folder, select a subfolder and press delete, only one report is eligible for deletion.
But when I confirm the delete, all my reports are gone! Not OK. Refreshing the reports and refreshing the browser does not help.

This should be fixed now, please check.

Works now.


XHR requests error not handled properly for hosted fields

The two XHR requests made in the hosted fields JS logic in pay with paypal page does not handle errors properly. This leads to a stuck page with an infinite spinner.
This can be easily tested by replicating this issue: https://github.com/Sylius/PayPalPlugin/issues/165
I can provide a PR for this

Hello Luca! Thank you, for this report - PR would be welcomed :) 🖖

Hello Luca! Thank you, for this report - PR would be welcomed :) 🖖

Hey @LucaGallinari any progress with pr ? :P

I am really sorry but i hadn't found time yet, I actually don't know when i will, hope soon ='(


Button click unreliable

I'm finding the single click function doesn't always register (works 80% or less of the time). I'm using a nodemcu V2 and clickable encoder.  I have tried replacing the encoder.  I can see the blue led light up on the nodemcu everytime I click it even when it doesn't register. Perhaps a timing issue?  The sketch is basically built off the demo.  I'm using visual studio code with platformio.  Using the latest encoder library I pulled from github and the button2 library is from platformio.  I tried using your latest one from github and the buttons wouldn't register at all.
#define ROTARY_PIN1	D2
#define ROTARY_PIN2	D3
#define BUTTON_PIN	D4
/////////////////////////////////////////////////////////////////
ESPRotary r = ESPRotary(ROTARY_PIN1, ROTARY_PIN2, 2 );
Button2 b = Button2(BUTTON_PIN);
void setup() {
Serial.begin(9600);
delay(1000);
Serial.println("\n\nFocusrite Knob");
setupWifi();
delay(3000);
broadcast();
getPort();
setupClient();
delay(50);
Serial.println("\n\nInitialized");
r.setChangedHandler(rotate);
r.setLeftRotationHandler(showDirection);
r.setRightRotationHandler(showDirection);
b.setClickHandler(muteVol);
b.setLongClickHandler(resetPosition);
}
void loop() {
r.loop();
b.loop();
}

Hm, please try playing around with the denounce time. During this time clicks will be ignored. There is a function to change it. See what happens if you shorten it.

Thanks.  I just tried that and it didn't help (1,5,10ms) .  Sometimes it doesn't respond at all.  The rotary encoder is rock solid.  I can see the led on the nodemcu light when I press it but I don't get teh "Button Press" in the serial console.
b.setClickHandler(muteVol);
void muteVol(Button2& btn) {
Serial.println("Button Press");
}

Could you try setting the  pressed and the released handlers and see if they also skip?


Add protocol ListOffsets v1

ListOffsets Request (Version: 1) => replica_id [topics]
  replica_id => INT32
  topics => topic [partitions]
    topic => STRING
    partitions => partition timestamp
      partition => INT32
      timestamp => INT64

ListOffsets Response (Version: 1) => [responses]
  responses => topic [partition_responses]
    topic => STRING
    partition_responses => partition error_code timestamp offset
      partition => INT32
      error_code => INT16
      timestamp => INT64
      offset => INT64

#209


Sesssion

In the Credentials class there is a struct called Sesssion
I assume this is a typo and should be Session, or would that conflict with the Vapor Session class?

Yes, that's a typo in Turnstile, unfortunately. We'll get that fixed =]
https://github.com/stormpath/Turnstile/issues/25

Fixed


bottles: 2<IP_ADDRESS> -> 50.2

Description of changes
https://github.com/bottlesdevs/Bottles/releases/tag/50
https://github.com/bottlesdevs/Bottles/releases/tag/50.1
https://github.com/bottlesdevs/Bottles/releases/tag/50.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1738


native log likelihood changes at each execution

Bug description
I am running the very useful esm/examples/inverse_folding/score_log_likelihoods.py script to calculate the likelihood of a chain with a pdb structure where one of the two chains is identical and the query chain has 1 aminoacid difference to the chain in the pdb. The reported "native likelihood" is different every time I run it against the same pdb, which makes me wonder if I am misinterpreting what "native likelihood" means in this context, or if this is a bug.
Reproduction steps
Input a fasta sequence of one of the two chains present in the pdb (obtained via Alphafold2), where the input chain is identical to one of the two chains except for 1 aminoacid. Take note of the "native likelihood". Try again with a different query chain, this time a different aminoacid change to the previous one. The "native likelihood" is different than the one reported the first time.
Expected behavior
If I am interpreting "native likelihood" correctly, I was expecting this value to be the same every time I run the script with the same pdb structure.
Logs
Please paste the command line output:
I did this in a sweep of a chain, where I change the original aminoacid for something different, and then compared "native_llh" values to the log_likelihood of the execution of the variant, and coloured here by the llh_delta between the two. I just see a cloud of values, so these two seem relatively uncorrelated to each other. This is an observation, I am not sure what I was expecting.

![image](https://user-images.githubusercontent.com/158007/176405532-640b86db-a87a-49f7-9c21-26a0cd100dd8.png)

Additional context
Add any other context about the problem here. (like proxy settings, network setup, overall goals, etc.)

Why would you expect the log likelihood to be the same each time? You're scoring different sequences against the same backbone each time right?

Ok, I checked out the HEAD version as of a few minutes ago, and it's now
working as I was expecting, i.e. if you run the score_log_likelihood.py
script with a pdb and a chain with the exact same sequence as in the pdb,
the native llh value, with 2 decimal numbers is the same as the
log_likelihood value returned by the script.
Thanks!
On Wed, Jul 20, 2022 at 10:50 PM naailkhan28 @.***>
wrote:

Why would you expect the log likelihood to be the same each time? You're
scoring different sequences against the same backbone each time right?
—
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/esm/issues/226#issuecomment-1190796976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGSN64F5NEFMFJNN3P663VVBYCJANCNFSM52FCMKKA
.
You are receiving this because you authored the thread.Message ID:
@.***>


feat(@libp2p): Add protocol-perf to release workflow.

Once the perf workflow is integrated in test-plans we should run the benchmarks on our release workflow
Can be added once https://github.com/libp2p/test-plans/pull/280 is merged

Closing as running a full performance test in CI will not give us much confidence without dedicated testing infrastructure.
A lighter touch such as proposed in #2118 will likely be more useful.


shuf: Do not read input when -n0 is given

This is explicitly tested by some suites, including the GNU test suite.
Together with #5980 and #5989, this should make uutils pass the GNU test suite for shuf. Yay! :D

please run rustfmt :)

Changes since last push:

Added "unwritable" to the cspell-ignore header.
test_cp::test_cp_arg_interactive_update flaked. No action taken.

Changes since last push:

Rebased on current main
Simplified a few tests by calling .no_output(). Thanks @cakebaker!
Split test_zero_head_count_file_touch_output into three tests: Negative (tries to write to unwritable path), positive (new file created), another positive (touches existing file). Thanks @cakebaker!

Good job, thanks!


A-Z English Learning Extensions for Kids

Is your feature request related to a problem? Please describe.
Why make a toddler carry books when he can just click on the letter and hear the word aloud
Describe the solution you'd like
An extension for every toddler that reads aloud  english alphabet as well the word that starts by it. It is going to be like that keyboard that kids backs in the day had that would read aloud the alphabet and words as they were pressed.
Describe alternatives you've considered
None
Additional context
GSSoC'24
What problem is this feature trying to solve?
How do we know when the feature is complete?

Please assign this to me @Sulagna-Dutta-Roy

Kindly don't raise a PR without assigned the Issue @samarsajad

Kindly don't raise a PR without assigned the Issue @samarsajad

I want to solve this issue kindly assign me this issue. @Sulagna-Dutta-Roy


feat(shared-data): update module offsets for DVT cradles

Closes RSS-204
Overview
DVT cradles have slightly different measurements than EVT ones. We'll be replacing all existing ones in the office with DVT cradles so need to update the present offsets.
Test Plan
Make sure to test on an OT3 with DVT cradles and aligned gantry system. Make sure to also complete pipette calibration before starting this test.

Upload a protocol with labware loaded on temp module, heater-shaker and thermocycler. Include pipetting steps to/from these modules in the protocol.
Run LPC without applying any existing offsets, the pipette should go to the right location on module labware.
Ideally there should be no additional LPC offsets required but practically there might be some. Note down these LPC offsets

Changelog

updated affine transforms in shared data

Review requests

Ideally a code review should be sufficient but from past testing we have found important distinctions between theoretical offset vs actual observed offset so we should probably test this (w/ testing plan above) and note down those differences, if any.
Make sure I've used the correct offsets mentioned in the excel sheet for DVT cradles. There's tests that verify the resulting offsets, so as long as the final offsets are correct, we should be good.

Risk assessment
Low.

We've agreed to merge this without completing physical testing. Details in RLAB-335.


Write to file the configuration file

Codecov Report

Merging #23 (f090d22) into master (cca8b56) will decrease coverage by 10.24%.
The diff coverage is 65.75%.

@@              Coverage Diff              @@
##             master      #23       +/-   ##
=============================================
- Coverage     76.31%   66.07%   -10.25%
- Complexity        9       10        +1
=============================================
  Files             8       10        +2
  Lines            76      112       +36
  Branches          0        1        +1
=============================================
+ Hits             58       74       +16
- Misses           18       38       +20

Impacted Files
Coverage Δ

src/main/kotlin/gghactions/GithubActionsTask.kt
28.00% <0.00%> (-5.34%)
:arrow_down:

src/main/kotlin/gghactions/configuration/Steps.kt
0.00% <0.00%> (ø)

...c/main/kotlin/gghactions/GithubActionsExtension.kt
14.28% <14.28%> (-85.72%)
:arrow_down:

src/main/kotlin/gghactions/model/JobId.kt
92.85% <90.00%> (+2.85%)
:arrow_up:

src/main/kotlin/gghactions/GithubActionsPlugin.kt
100.00% <100.00%> (ø)

...n/kotlin/gghactions/configuration/DefaultValues.kt
100.00% <100.00%> (ø)

src/main/kotlin/gghactions/model/Job.kt
100.00% <100.00%> (ø)

src/main/kotlin/gghactions/model/Matrix.kt
100.00% <100.00%> (+100.00%)
:arrow_up:

src/main/kotlin/gghactions/model/Step.kt
100.00% <100.00%> (+6.25%)
:arrow_up:

src/main/kotlin/gghactions/model/Workflow.kt
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca8b56...f090d22. Read the comment docs.


HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

Description of PR
When running integration tests against an S3-compatible endpoint without SSE support, tests would fail despite marking test.fs.s3a.encryption.enabled as false.
How was this patch tested?
Against eu-west-1, no special configuration. Encryption enabled.
I see these failures - looks unrelated. Tests for encryption are passing. Third time they went away and everything is passing.
[ERROR] Failures:
[ERROR]   ITestS3AIOStatisticsContext.testThreadSharingIOStatistics:294->assertThreadStatisticsForThread:377 [Bytes read are not as expected for thread : 70] expected:<[150]L> but was:<[85]L>
[ERROR]   ITestS3APrefetchingInputStream.testRandomReadLargeFile:158 [Gauge named stream_read_blocks_in_cache with expected value 2] expected:<[2]L> but was:<[1]L>
[INFO]
[ERROR] Tests run: 1143, Failures: 2, Errors: 0, Skipped: 186

[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.451 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSDefaultKey

Against an S3-compatible endpoint without SSE support, running only ITestS3AEncryptionSSEKMSDefaultKey.
Works for me :) Only tried ITestS3AEncryptionSSEKMSDefaultKey - there's a lot breaking both before and after this change, still need to figure that bit out later.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 15s

trunk passed

+1 :green_heart:
compile
0m 51s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 41s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
26m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 43s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 33s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 23s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 16s

the patch passed

+1 :green_heart:
shadedclient
24m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 41s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

108m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8504ec32468f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 94a2b0ab17c26f24ce95d3abb7849078916f5074

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/testReport/

Max. process+thread count
562 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 25s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 39s

trunk passed

+1 :green_heart:
mvnsite
0m 49s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
23m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 12s

the patch passed

+1 :green_heart:
shadedclient
23m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 36s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

105m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 09eefe33415c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1673c7438122233b7ff5c6802196674633af15dc

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/testReport/

Max. process+thread count
534 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ok, merged to trunk. this can go into -3.3 as well, can't it?

ok, merged to trunk. this can go into -3.3 as well, can't it?

Yeah, I don't see why not. I've opened #4977. Integ tests are running ATM.


Potential SQL bug

I guess this method is unused but it looks wrong to me

It's being used in get_dependents, but it's probably better to remove one_column entirely and just use many_many.


Reverse

A highly convinient conversion would be, to also convert back - to convert pdb to dwarf.
Is this a possibility for this project?

Sorry, that's way out of scope. The project is more or less in maintenance only, as it is not needed a lot for D anymore.


feat: Table widget - new column type select

Description

Enabled a new Column type select where the user can setup a select widget in a column.

Fixes #6766
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: FEATURE/6766-new-column-type-select

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.01 (-0.04)
36.56 (0)
34.49 (0)
55.53 (-0.03)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

:red_circle:
app/client/src/widgets/TableWidget/component/TableStyledWrappers.tsx
87.06 (0.16)
53.87 (-1.02)
80 (0.37)
87.06 (0.16)

:green_circle:
app/client/src/widgets/TableWidget/component/TableUtilities.tsx
38.07 (-0.03)
25.22 (1.33)
15 (-1.22)
36.42 (0.06)

:red_circle:
app/client/src/widgets/TableWidget/widget/derived.js
64.81 (-0.28)
60.92 (-0.62)
51.16 (0)
62.81 (-0.27)

:green_circle:
app/client/src/widgets/TableWidget/widget/getTableColumns.tsx
56 (25.57)
23.08 (23.08)
33.33 (33.33)
50 (30)

:red_circle:
app/client/src/widgets/TableWidget/widget/index.tsx
28.54 (-1.1)
9.42 (-0.06)
29.09 (-0.32)
28.11 (-1.18)

:red_circle:
app/client/src/widgets/TableWidget/widget/propertyConfig.ts
87.27 (-8.65)
100 (0)
81.08 (-12.47)
87.27 (-8.65)

:green_circle:
app/client/src/widgets/TableWidget/widget/propertyUtils.ts
28.99 (0.52)
10.78 (0)
26.67 (0)
27.91 (0.57)

@vibhandikyash semantics are not right!

UX Issues

When selecting an option from the select cell, the row gets selected, and triggers the onRowSelected. Let's not propagate these events.
currentRow is not accessible in the property controls of the select type columns
Server side filtering doesn't need to be in the list of property controls for now. Please remove all references to this control and any functionality which has been added related to this.
Even if currentRow is available to bind, it is not defined when evaluating triggers.
In all select components, the first option is always shown as highlighted in the list, while there is no selection @Tooluloope

UX Issues

In all select components, the first option is always shown as highlighted in the list, while there is no selection @Tooluloope

@riodeuno The reason for that is for keyboard accessibility. So when the dropdown is active, the first item is auto focused. There is a difference between the focused state and the select state of the options.

@vibhandikyash Tested this PR and Please find the status below,
1.The order in the Select Column Property pane should match the Select widget order

Options
Default Options
Placeholder
Required Toggle
Visible Toggle
Disabled Toggle
Filterable Toggle
OnOption Change Action

Required Toggle is not available

Filterable Toggle is not available

Once when the disabled toggle is enabled and disabled - Then the select column is in disabled mode

https://loom.com/share/3d22bc4621064815a20da68fed699d8d
5.By Default - Options, Default Options and PlaceHolder are empty - Due to which empty checkbox is displayed on the select column - Default values can be displayed
https://www.loom.com/share/c581beefec334a05954e9393bf7e1fae

Feedback @vibhandikyash:

Default value needs to change to computed value and should be re-ordered below column type
Just like in the button column type we have the button properties separated, we will do the same for this column type
Point 4 from @YogeshJayaseelan feedback is true
Point 5 from @YogeshJayaseelan feedback should be looked into, Set the defaults as per other column types
Re-order the disable property to the top of Select properties
Documentation changes required here
Do we have the basic cypress and jest tests for this?

Revert on the above feedback:

@YogeshJayaseelan since this is in a table and the value is bound the query I dont see the case of using required (please explain if required), However in extension to the inline edit in table widget we could introduce some validation here.
@YogeshJayaseelan lets raise filterable as a separate requirement later, I would like to see some request around this before taking it up

Triggered row didn't work for me
The select option was very slow to update
There were options missing like server side filtering

@vibhandikyash Let's implement the triggeredRow feature here. We populate the triggeredRow when we a button cell is clicked. The same should happen for the onOptionChange of the select column type.
We should also include the description of triggeredRow in the documentation

Here are two issues I found. I'm not sure if this is related to the changes in this PR. Please verify.

[ ] Math.random(), triggers updates repeatedly
[ ] currentRow works in an unexpected manner in the onOptionChange binding.
https://user-images.githubusercontent.com/103687/140047799-9913a714-c024-496e-b738-b6605eb4ba1d.mov

https://user-images.githubusercontent.com/103687/140047816-2c7b9d67-70ed-4c67-b30f-36756e7f3902.mov

/ok-to-test sha=0ab5a42

@vibhandikyash  Nice work! This is close to completion. Quite a few problems have been resolved, however, one issue remains. Please see attached screen recording.
I'll get back to you on the debugger issue.
https://user-images.githubusercontent.com/103687/143436046-c2249924-f4b9-4ee1-a6c6-51f39a6d2a71.mov

/ok-to-test sha=647ed3a

@vibhandikyash I'm not able to check the deploy preview as there is a typescript error while led to a failed build. Please fix this and pull the latest release to see if there are any updates to the binding issue.

/ok-to-test sha=3cfd653

@vibhandikyash Tested this feature and please find the status below,
Issue 1 - Property fields order will be based on table widget
Issue 2 - Not in scope
Issue 3 - Not in scope
Issue 4 - Fixed,
Issue 5 - Not Fixed - Default value is not displayed - The select column is empty by default
Issue 6 - Math.random(), triggers updates repeatedly - This is still happening and what is expected behaviour here @riodeuno - https://loom.com/share/8a9c157790714f1a879c9edc1163bb7b
New issue :
Issue 7 - Text alignment and vertical alignment is not working for select column type - Should alignment work for select column too? @somangshu @vibhandikyash
https://www.loom.com/share/b1acdfd665e3442db8a9a62cf977fe45

Issue 7 - Text alignment and vertical alignment is not working for select column type - Should alignment work for select column too? @somangshu @vibhandikyash

@YogeshJayaseelan yes that should be the case

ok-to-test sha=2e5f161

/ok-to-test sha=2e5f161

Closing this PR. Feature will be reopened with TableV2.


Cannot find Annotation file and "~/script/maxime.utils.r"

Hi Maxime,
When I try to reproduce the results in your paper,  cannot find the file you used in line 21 in 02_TLS_imprint_signature.R.
  annot <- list.files(paste0("/data/visium_ccRCC/annotations/",slide),full.names = T)

So, I am considering that could you share your annotation file for slices you included in your paper.  I really appreciate if you can share the file with me<EMAIL_ADDRESS>Thank you.

Hello,
I will make the annotations available through the GEO submission.
Best,
Maxime

Wow, that is great, thanks a lot.

Annotations are now included as .csv files in each sample directory of submission GSE175540

Thank you very much. I checked the accession number GSE175540, and I found that you maybe missed the annotation for the sample ffpe_c_10.

This samples have low tumor content and no TLS, therefore a TLS annotation is not necessary.


[pulsar-bookkeeper] Failed to open rocksdb

We got this exception in our production logs:
ERROR org.apache.bookkeeper.statelib.impl.kv.RocksdbKVStore - Failed to open rocksdb at dir /pulsar/data/bookkeeper/ranges/ranges/000000000000000002/000000000000000001/000000000000000000
This incident was associated with an occurrence of this issue: https://github.com/apache/pulsar/issues/6054
but we haven't been able to track down a distinct cause yet. The error above is the only error that we couldn't pin to some other possible cause, such as a network issue or broker restart, so we're not sure if it's related.

Closed as stale. Feel free to reopen it if it's still relevant for maintained versions.
Besides, thanks for reporting issues :) I believe the integration with RocksDB has been improved over the years.


Issues with Java 1.6*

This doesn't not work with java 1.6.* versions, make sure you have java 1.7 installed.
Also keep the JAVA_HOME updated with the java version.

closed by #624


Support clustered endpoints

Statcord supports clustered bots, where each cluster posts with its own unique id and then the stats are merged together. It would be nice if this lib supported that (the official lib doesn't).
Note that clustered endpoints are restricted, so you may have to get whitelisted first. API info here: https://docs.statcord.com/#/api?id=post-clustered-stats

This library is only for use with Discord.py. Unless you have a complex sharding solution there should be no need for this as Discord.py's AutoShardedBot basically runs all the shards in one big cluster anyways.

discord.py allows for manual sharding, allowing me to launch multiple clusters. Like this:
bot_instance_1 = commands.AutoShardedBot(shards=8, shard_ids=[0, 1, 2, 3])
bot_instance_2 = commands.AutoShardedBot(shards=8, shard_ids=[4, 5, 6, 7])

Then each instance can be launched in its own process.

I know you can do that.

Unless you have a complex sharding solution

I guess this is more common than I thought. It would be too complex to add this functionality into this library, so perhaps I'll make a seperate library specifically for bots which use clustering.

All you would need is to use a different endpoint and then have the StatcordClient accept a cluster_id parameter, which you then post. Everything else would be the same, each StatcordClient with the stats for its cluster.

Oh, I didn't read the first comment in full. Yeah I can do that I'll do it Tuesday or Wednesday

Sorry this took so long, 2.0.3 is out which contains the StatcordClusterClient class which supports this feature.

Thanks a lot


[FEATURE]:

Which tool
tidal gui
Describe the feature
can you add the ability too download the new lossless hires flac  from tidal? (no MQA)
Max sound quality
Up to 24-bit, 192 kHz
Formats available include HiRes FLAC
Add screenshots
No response

I doubt we ever gonna see it, app seems dead.. the dev has not updated the code in a while and there still old bugs reported some time ago still not cleared up. By the grace just lucky can even download anything with it and that Tidal has not nuked the methods this app uses to rip the tracks. Tho I wish this was still updated.. i accepted that this may be abandoned :(. I hope i can be proven wrong but it is what it is. It a free app with great features and thankful for what i got from it thus far.


Added recipe unifying script

Usage:
python merge_recipe --config_name=cifar10_resnet -> saves cifar10_resnet_complete.yaml in path/to/super_gradients/recipes

python merge_recipe --config_dir=/path/to/recipes/ config_name=my_recipe.yaml -> saves config_name_complete.yaml in /path/to/recipes/

python merge_recipe --config_dir=/path/to/recipes/ config_name=my_recipe.yaml save_path=/other/recipes/dir/my_complete_recipe.yaml
 -> saves the complete receip in /other/recipes/dir/my_complete_recipe.yaml

Maybe add a unit test to export some recipes to ensure everything is working as it should?

Maybe add a unit test to export some recipes to ensure everything is working as it should?

Moved the logic to a helper method, which is whats tested in the added tests.


Add password to the User model

Add password to later authenticate the User in JWT auth /login

added password to the user model


Generate current working file?

Is there a way to bypass grunt assemble to generate every single page but instead just generate the file that I currently working on?
Thanks

Version of assemble is 0.2.1
https://gist.github.com/kkashou/b4fd4c7a591124860f32
The command line just list out the generated pages.
I was hoping that it only generates the page I am working on not the entire site.

grunt-assemble isn't setup to handle incremental builds. The main reason is that there are features that rely on having all of the pages in memory during rendering.
You can try grunt-newer to see if that works for your build.

That worked thank you!


UnsatisfiedLinkError: No implementation found for void org.maplibre.android.net.NativeConnectivityListener.initialize()

Firebase crash log
 Fatal Exception: java.lang.UnsatisfiedLinkError: No implementation found for void org.maplibre.android.net.NativeConnectivityListener.initialize() (tried Java_org_maplibre_android_net_NativeConnectivityListener_initialize and Java_org_maplibre_android_net_NativeConnectivityListener_initialize__) - is the library loaded, e.g. System.loadLibrary?
       at org.maplibre.android.net.NativeConnectivityListener.initialize(NativeConnectivityListener.java)
       at org.maplibre.android.net.NativeConnectivityListener.<init>(NativeConnectivityListener.java:27)
       at org.maplibre.android.net.ConnectivityReceiver.instance(ConnectivityReceiver.java:45)
       at org.maplibre.android.MapLibre.getInstance(MapLibre.java:62)

libs.version.toml
maplibre-android-sdk = "11.4.0"
maplibre-android-plugin-annotation-v9 = "3.0.1"

maplibre-android-sdk = { group = "org.maplibre.gl", name = "android-sdk", version.ref = "maplibre-android-sdk" }
maplibre-android-plugin-annotation-v9 = { group = "org.maplibre.gl", name = "android-plugin-annotation-v9", version.ref = "maplibre-android-plugin-annotation-v9" }

To Reproduce
Steps to reproduce the behavior:

Open a simple fullscreen map on an Android device

Platform information
The crash was only seen on this user's devices:
Device
Brand: Vivo
Model: Y27s
Orientation: Portrait
RAM free: 3.87 GB
Disk free: 189.88 GB
Device
Brand: Vivo
Model: Y18
Orientation:Portrait
RAM free: 2.34 GB
Disk free: 81.6 GB
Operating System
Version: Android 14
Orientation: Portrait
Rooted: No

build.gradle
included
ndk {
			abiFilters += listOf("armeabi-v7a", "arm64-v8a", "x86", "x86_64")
	}

Some discussion on an old Mapbox issue: https://github.com/mapbox/mapbox-gl-native/issues/15331

Additional information
compileSdk = "34"
targetSdk = "34"
minSdk = "26"
androidBuildTools = "34.0.0"

Ruben from Flitsmeister shared on Slack:

According to our crashlytics this happened to 47 users in the last month, which is like ~0.005% of our monthly android userbase so it doesn't happen often. 1

We're seeing this issue too. It occurs very rarely, but for the users it affects the issue is permanent. AFAICT the affected devices are either very cheap Android phones or automated testing devices through in Google Play pre-launch reports. So far we ignored the issue because it is so exceedingly rare among our users.
Our assumption so far was that the database behind Google Play's app bundle (.aab) to APK conversion has incorrect information about the supported ABIs of the devices, i.e. the .so variant the device actually tries to load is not included in the APK produced by Google Play. Most likely the device supports multiple ABIs (e.g. armeabi-v7a and arm64-v8a) but the prioritization is different between the on-device logic and Google Play. Only one .so variant will be included in the APK (that's kind of the point of the app bundle system) and the device tries to load the other one.
If this assumption is correct, the remaining question is: Why does the device not fall back to loading the other supported ABI? Is this something maplibre can solve or is it a bug in the Android implementation of the device?

It occurs specifically on api 35 16kb page size devices.
Starting 11.5.2, libmaplibre.so is not 16 KB ELF aligned anymore (done in #2429) which leads to load failure
Maybe a branch or build process issue ?

@bruno-obv Thanks that was it! Fix will be released today.


A way to add parameters in the .exe

Hello, since I have so many sttutering problems with the game, I use a shortcut with parameters that avoid having them. It would be nice if your app allowed to use shortcuts instead of the original .exe, or a way to add the parameters like Steam.

I agree, having the ability to add launch options would be great. I use "-popupwindow" to get fullscreen borderless windowed mode, but I can't get it to work with this awesome tool.

launch parameters is already supported, just pass it to the unlocker via command line or shortcut

launch parameters are already supported, just pass it to the unlocker via command line or shortcut

Oh thanks. I didn't realize that I could do that. Then I will close the "Issue".


proc entries randomly become invalid pointers

platform: windows
byond ver: 515.1633
hello, I am experiencing periodic crashes while debugging (both breakpoints/runtime errors)
i decided to spend some time debugging; the crash is apparently caused by get_line_number.
more specifically, the get_misc_by_id call caused by proc.bytecode(). get_misc_by_id is called with an ID of 0x007F7A5C by auxtools; after checking, this byondcore function checks it against what seems to be a maximum, which at that time was 0x0001665F; an infinitely more reasonable value.
i can't consistently repro, but I was just debugging runtime errors on that specific byond version for https://github.com/Foundation-19/Foundation-19 when I experienced this issue
crash point; https://github.com/willox/auxtools/blob/master/debug_server/src/server.rs#L210
caused by; https://github.com/willox/auxtools/blob/master/auxtools/src/raw_types/misc.rs#L152

Seems to be a wider issue with random invalid proc references, only on some procs.

poking @Absolucy for this since primary maintainer of 515 support

Ah. After many.. many a time spent debugging, I have finally found what's happening.
When populate_procs is called, the proc has a valid entry. Perfectly valid!
At some point, by the time the breakpoint is hit, the entry pointer is now completely invalid. Incredibly exciting.
After adding some absolutely cursed debug code (photos attached), it turns out that the pointer to proc entry is magically changed by the game some time after the initial proc population. This debug code was able to fix the crash.

Breakpointed this to confirm; proc entry did indeed change.

It's being realloc'd by the function at byondcore.dll+0x207E50 on 515.1633 byondcore.dll, hope that helps a bit

Got a working (albeit poorly made) patch to proc.rs that fixes the issue. Other possible solution is hooking the proc that BYOND reallocates the proc entry array on and only checking for reallocation then, but that requires maintaining another signature.

Patch
```
diff --git a/auxtools/src/proc.rs b/auxtools/src/proc.rs
index 29864d4..15dc47a 100644
--- a/auxtools/src/proc.rs
+++ b/auxtools/src/proc.rs
@@ -4,6 +4,8 @@ use std::{
 	fmt
 };
+use lazy_static::lazy_static;
+
use ahash::RandomState;
use fxhash::FxHashMap;
@@ -166,14 +168,25 @@ impl fmt::Debug for Proc {
}
}
+struct ArrayStartWrapper {

pub ptr: *mut raw_types::procs::ProcEntry
+}

thread_local!(static PROCS_BY_NAME: RefCell<HashMap<String, Vec, RandomState>> = RefCell::new(HashMap::with_hasher(RandomState::default())));
thread_local!(static PROC_OVERRIDE_IDS: RefCell<FxHashMap<raw_types::procs::ProcId, u32>> = RefCell::new(FxHashMap::default()));
+thread_local!(static PROC_ENTRY_ARRAY_START: RefCell = RefCell::new(ArrayStartWrapper {ptr: std::ptr::null_mut()}));
fn strip_path(p: String) -> String {
p.replace("/proc/", "/").replace("/verb/", "/")
}
pub fn populate_procs() {

unsafe {

  PROC_ENTRY_ARRAY_START.with_borrow_mut(|a| {

  	assert_eq!(raw_types::funcs::get_proc_array_entry(&mut a.ptr, raw_types::procs::ProcId(0)), 1);

  })

};
let mut i: u32 = 0;
loop {
let proc = Proc::from_id(raw_types::procs::ProcId(i));
@@ -210,6 +223,17 @@ pub fn clear_procs() {
}

pub fn get_proc_override<S: Into>(path: S, override_id: u32) -> Option {

PROC_ENTRY_ARRAY_START.with_borrow(|a| {

  let mut new_start: *mut raw_types::procs::ProcEntry = std::ptr::null_mut();

  let current_start = a.ptr;

  unsafe {

  	assert_eq!(raw_types::funcs::get_proc_array_entry(&mut new_start, raw_types::procs::ProcId(0)), 1);

  	if new_start != current_start {

  		clear_procs();

  		populate_procs();

  	}

  }

});
let s = strip_path(path.into());
PROCS_BY_NAME.with(|h| match h.borrow().get(&s)?.get(override_id as usize) {
Some(p) => Some(p.clone()),

</details>

it seems that the best solution would be to store the index in to the array inside our Proc type instead of the pointer instead of caching it

it seems that the best solution would be to store the index in to the array inside our Proc type instead of the pointer

good solution, except you have the overhead of grabbing with get_proc_array_entry every time. it might be faster to actually store the proc array and do pointer arithmetic to get the proc entry instead of calling into it in that case

do we know why a reallocation is happening?

no idea, random byond code that I didn't look into a whole lott

okay I figured it out
the proc I was crashing on was a breakpoint in /Initialize() for some wall subtype. right around initialization of SSatoms was when the reallocations were happening.
when I looked at the call stack after applying the patch, I was able to see the Holy Grail of light power_change.

after looking at the code, the reasoning was very evident (this is called on every light in every area on /area/initialize)

changing the light code to not use a spawn() and changing back to the original spacemandmm instead of my custom compiled one (so it actually grabs the bundle) proves this theory, as the crash no longer happens. i guess its something to do with too many suspended procs forcing a reallocation; this is a problem primarily on older codebases tbh

goon probably has this issue due to the massive amount of spawns we use


Cache pip dependencies to speed up CI

This PR attempts to speed up both unit-tests and integration-tests CI jobs. Every CI job spends about 2 minutes on installing pip packages. The step dominates about 90% of the total time of unit-tests and about 30% of the total time of integration-tests. The step to install pip packages can be skipped by creating virtual environments and caching the installed packages onto the environments using actions/cache. Note that actions/setup-python@v4 doesn't support caching installed packages. It only allow to avoid re-downloading by caching downloaded packages from PyPI under ~/.cache/pip.
Dependencies listed in setup.py are moved to requirements.txt. This is to generate lock files for every Python version from requirements.txt. The generated lock files are used as keys to caches to properly invalidate when dependencies are updated. Unless dependencies are changed, every CI job should be reproducible (with respect to installing pip dependencies). Making the CI jobs reproducible and faster achieves at the expense of periodical updates of these lock files. Maintaining lock files for dependencies is pretty common in other programming languages such as JS and Rust. This update can be done by running cicd/gen_requirements_lock.sh.

This looks pretty helpful!

This looks very useful! Thanks for implementing it!
Out of curiosity, do you think it would make sense to use poetry or pipenv (or some other options) to implement this? Or do you think it's overkill? Now that we have a lock file, it might also be helpful to use it for local development and for distribution. I think something like poetry can cover both of those scenarios.

@tetsuok Could you add a specific reviewer if you make a readied pull request?
Personally I vote +1 to use poetry over manually implementing the lockfile functionality. Applying poetry we can organize everything in pyproject.toml and remove setup.py.

@odashi I can't because I don't have a write access to the repository, as per documentation.

@lyuyangh @odashi I agree with using a dedicated tool such as poetry to manage lock files by design. I think that topic needs to be discussed in a separate issue first, because the impact of the change is bigger than caching dependencies in CI. How about the following process?

Create a new issue, and discuss migrating to poetry with other members there.
Create a PR to switch to poetry and update CI/CD pipelines If we get an agreement. This PR needs to focus on switching to poetry.
Update this PR to cache dependencies managed by poetry in GitHub Actions. (This PR must be blocked by until Steps 1 and 2 are finished. I believe the current CI jobs are not intolerably slow to merge this PR as soon as possible)

Hi @tetsuok ! That sounds good! I think we can put off this PR for now if you are ok with it.

Created issue: #414
@tetsuok I think you basically don't need to make any consensus to make issues because it does never affect the code itself. Feel free to make issues if you realized something.

@odashi Sure.

@lyuyangh I'm totally fine.

hi @tetsuok, thanks for the nice contributions.
Regarding "I can't because I don't have a write access to the repository"
I think you can now. Let me know if you still cannot.

Closing as we can resolve this issue by a different approach and because this PR is behind main.


Scribble may purge or ignore spaces when a string is wrapped across multiple pages

Observed:
If text is wrapped and creates multiple pages, scribble may purge spaces in the middle of lines of text, even if the text is not near the end of a line or page.
Expected:
The wrapped text would not purge spaces that should still be present.
ErrorInvestigation.zip

Workaround is to set SCRIBBLE_FLEXIBLE_WHITESPACE_WIDTH to false

https://github.com/JujuAdams/Scribble/commit/c78f29f2bc9f0eada1c8163d5e7cb19058a0ada5


Conform to README.lint

Proposing changes per readme-dot-lint.

Maybe in a separate PR, but we should absolutly get a link to local-interchain on the home readme.

I will do a local-interchain write up in another PR. Should keep this one to basic linting and general info


Fix SARIMAXModel saving init params

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (checklist)

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contribution guide?
[x] Did you check the code style? make lint (poetry install -E style).
[x] Did you make sure to update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you check that your code passes the unit tests pytest tests/ ?
[ ] Did you add your new functionality to the docs?
[x] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Codecov Report

Merging #81 (872ea12) into master (d152d9a) will decrease coverage by 4.29%.
The diff coverage is 100.00%.

:exclamation: Current head 872ea12 differs from pull request most recent head 487f3a7. Consider uploading reports for the commit 487f3a7 to get more accurate results

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   90.14%   85.85%   -4.30%
==========================================
  Files          48       48
  Lines        2152     2170      +18
==========================================
- Hits         1940     1863      -77
- Misses        212      307      +95

Impacted Files
Coverage Δ

etna/models/sarimax.py
93.87% <100.00%> (+1.37%)
:arrow_up:

etna/transforms/pytorch_forecasting.py
26.38% <0.00%> (-73.62%)
:arrow_down:

etna/models/nn/tft.py
43.58% <0.00%> (-56.42%)
:arrow_down:

etna/models/nn/deepar.py
45.94% <0.00%> (-54.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d152d9a...487f3a7. Read the comment docs.


v0.13.0, code is breaking in iOS

I am using v0.13.0 in my project, but the code is breaking. When I tried to run the application in iOS, I am getting the following error message, and build is getting failed.
CompileC /Users/username/Desktop/projectname/ios/build/Build/Intermediates/AirMaps.build/Debug-iphonesimulator/AirMaps.build/Objects-normal/x86_64/AIRMapCallout.o AirMaps/AIRMapCallout.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
But it is working properly in v0.12.2.

I am having this issue too. I am using React Native 0.40.0

The following build commands failed:
CompileC /Users/username/project/FoodProject/ios/build/Build/Intermediates/AirMaps.build/Debug-iphonesimulator/AirMaps.build/Objects-normal/x86_64/AIRMapCallout.o AirMaps/AIRMapCallout.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
Same here. Using 0.40.0 and I having the exact same issue.

you can try to change port "react-native start --port=8088"

I recently made a fresh example build with pods and GoogleMaps with no issues.
https://github.com/alvelig/react-native-maps-pods-example.
Try to check it out or build through the README.MD. If it does not help, let me know.


amp file appears to have unnecessary jars in it

The 1.2-4.2 amp file includes the following jars. I assume none are required for a release build and hence this bloats the repository and also could cause jar versioning issues.
jetty-continuation-7.4.0.v20110414.jar
jetty-security-7.4.0.v20110414.jar
jetty-util-7.4.0.v20110414.jar
spring-core-3.2.17.RELEASE.jar
args4j-2.0.16.jar
jetty-http-7.4.0.v20110414.jar
jetty-server-7.4.0.v20110414.jar
junit-remote-3.jar
spring-test-3.2.17.RELEASE.jar
commons-logging-1.2.jar
jetty-io-7.4.0.v20110414.jar
jetty-servlet-7.4.0.v20110414.jar
slf4j-api-1.7.7.jar

I will check that. So this is only included in the 1.2-4.2.amp, right?

Ok, all versions are involved. I will play with the pom.xml a little bit and see how I can avoid that.
Thanks...

I have fixed it


docs(readme): Add feature roadmap and support to readme

CC @nastra @Fokko @rdblue @coded9 @bitsondatadev @wolfeidau


Ensure status is set to valid if no payload needed to be executed

PR Description
Fix fork choice so that when blocks post-merge but before TTD are imported they are marked as valid.  Previously they stayed optimistic because there was no request to executePayload and so no valid response was received.
Also updates ChainUpdater to mark the blocks as valid when it's inserting them into storage manually.
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

merged in #4687


Crashes when scroll to top after sending multiple messages

New issue checklist

[x] I have read the README, documentation, and FAQ.
[x] Contributing guidelines confirmation: 💪😎👊
[x] I have searched existing issues and this is not a duplicate.

General information

JSQMessagesViewController version: 7.3.2
iOS version: each one
Devices/Simulators: iPhone 5,6,7
Reproducible in the demo project? (Yes/No): Yes
Any related issues:

What happened?
If your screen is moved by showing messages scrolling back to the top causes the crash. It always happens when I scroll to specific position.

Same thing with version 7.3.4

@martynpekala, thanks for submitting an issue. Can you provide all steps to replicate it in the demo project? That would help us address the issue accurately. 😃

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Integrating Intel GPU Decoder and Encoder Support into Torio/Torchaudio

🚀 The feature
@mthrok, I'd like to propose the integration of Intel GPU decoder and encoder support into Torio/Torchaudio's ffmpeg. This would provide native Intel GPU support for users running PyTorch on Intel GPU systems. Additionally, this could set the groundwork for a more plugin-based system or an extension mechanism that accommodates future vendor GPU implementations.
Motivation, pitch
Recently, my team and I enabled Intel GPU support in Torchvision's VideoReader. We observed a performance boost of approximately 1.8x ~ 2x for inferencing on ResNet50 using Intel GPU. Given the recent discussions about consolidating functionality in Torio, we're keen on contributing this enhancement to Torio instead.
Alternatives
No response
Additional context
Would the Torio/Torchaudio maintainers be open to this contribution? We're eager to collaborate and support the project's goals.

Hi @leopck
Thanks for the suggestion. We are open to take the contribution, but need to understand a bit more of the approach. How are you enabling the Intel GPU decoder? Does it involves bundling a library?
Currently, CUDA decoder/encoder is integrated through the abstraction provided by FFmpeg, so that we can build it with bare minimum FFmpeg and distribute it without re-distributing hardware library. Users who want to use CUDA decoder need to build/install FFmpeg with cuvid integration by themselves.
If your approach is similar, I think we are good to go.

How are you enabling the Intel GPU decoder? Does it involves bundling a library?

We are using ffmpeg + VAAPI so there is no bundling of library required. As long as the system installs VAAPI, then it would be sufficient.

Currently, CUDA decoder/encoder is integrated through the abstraction provided by FFmpeg, so that we can build it with bare minimum FFmpeg and distribute it without re-distributing hardware library. Users who want to use CUDA decoder need to build/install FFmpeg with cuvid integration by themselves.

Right now, we are using the defauly ffmpeg that we pull from Ubuntu APT repo, which ffmpeg version and ffmpeg package that you are using right now?

How are you enabling the Intel GPU decoder? Does it involves bundling a library?

We are using ffmpeg + VAAPI so there is no bundling of library required. As long as the system installs VAAPI, then it would be sufficient.

Sounds good.

Currently, CUDA decoder/encoder is integrated through the abstraction provided by FFmpeg, so that we can build it with bare minimum FFmpeg and distribute it without re-distributing hardware library. Users who want to use CUDA decoder need to build/install FFmpeg with cuvid integration by themselves.

Right now, we are using the default ffmpeg that we pull from Ubuntu APT repo, which ffmpeg version and ffmpeg package that you are using right now?

Right now, torchaudio is compiled against custom FFmpeg binaries to ensure that we only use FFmpeg's public API (those start with av_), which is licensed LGPL. We compile the same source code against v4.4, 5, and 6. So that it will work with different versions of FFmpeg found in the user environment. FFmpeg installed with apt should work just fine.
Can you try if the current code work with VAAPI already? IIUC, using VAAPI decoder is just about selecting the decoder. For example, Passing h264_vaapi to add_video_stream could just work. I looked at FFmpeg C VAAPI examples and these examples required to do a bit more because it does hardware encoding. I got the impression that you do not need to do anything special to just use hardware decoder.

Right now, torchaudio is compiled against custom FFmpeg binaries to ensure that we only use FFmpeg's public API (those start with av_), which is licensed LGPL. We compile the same source code against v4.4, 5, and 6. So that it will work with different versions of FFmpeg found in the user environment. FFmpeg installed with apt should work just fine.

Yes, agreed this would work for us as well.

Can you try if the current code work with VAAPI already? IIUC, using VAAPI decoder is just about selecting the decoder. For example, Passing h264_vaapi to add_video_stream could just work. I looked at FFmpeg C VAAPI examples and these examples required to do a bit more because it does hardware encoding. I got the impression that you do not need to do anything special to just use hardware decoder.

Actually, there are some special optimizations that we are doing on our side that we would like to help to add into this project such as zero copy mechanisms and using some media acceleration capabilities from Intel GPU. You are right that if the intention here is just solely for decoding and encoding using vaapi on ffmpeg, then h264_vaapi is sufficient. But for our case, we would like to add in these optimization for decoding as well as we would like to get higher performance for capabilities like inferencing. We saw around ~80% performance gain from these optimizations.


Add create cluster and generate  manifest cmd using cnpg plugin.

I will add the spec.

@danishedb Closing as stale. Feel free to reopen adding the Spec if you think to continue working on this.


NTR: cyclin L -CDK11 complex

Please provide as much information as you can:

Suggested term label:

NTR: cyclin L -CDK11 complex

Definition (free text)

A protein complex consisting of cyclin L and cyclin-dependent kinase 11 (CD1). Cyclins are characterized by periodicity in protein abundance throughout the cell cycle. Cyclin-dependent kinases represent a family of serine/threonine protein kinases that become active upon binding to a cyclin regulatory partner.

Reference, in format PMID:#######

PMID: 32446654 review
PMID:23122962 the paper I am curating

Gene product name and ID to be annotated to this term

Parent term(s)

GO:0000307   cyclin-dependent protein kinase holoenzyme complex

Children terms (if applicable) Should any existing terms that should be moved underneath this new proposed term?

Synonyms (please specify, EXACT, BROAD, NARROW or RELATED)
Cdk11-Cyclin L Complex

Any other information

This complex is important (mediator associated) and conserved:
The cyclin, hereafter named L-type cyclin pombe (Lcp1), showed similarity to the L-type cyclin family previously shown to associate with metazoan Cdk11 (Dickinson et al., 2002; Loyer et al., 2008),

+[Term]
+id: GO:0180038
+name: cyclin L-CDK11 complex
+namespace: cellular_component
ng to a cyclin regulatory partner." [PMID:23122962, PMID:32446654]
+synonym: "Cdk11-Cyclin L complex" EXACT []
+is_a: GO:0000307 ! cyclin-dependent protein kinase holoenzyme complex
+property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/27122" xsd:anyURI
+created_by: vw
+creation_date: 2024-02-26T13:53:41Z


fix: support IDs in faction/chain and faction/territory

4065e66587ad30fbf9ffdc6bcfbcdb061d33162b:  running npm run format would change all line endings (on my machine) to LF, now it will force prettier to use CLRF (else the diff ends up being every single file)
7e227e773b0589832ea1a810d75ac06f63411373: This presumably wasn't noticed as for some sections no error will be thrown (https://api.torn.com/user/undefined?key=xxx&selections=basic will default to the current user's id, https://api.torn.com/faction/undefined?key=xxx&selections=territory will not).
c42278f6d8f247fdfe4483cd31518ff9892a46a7: self explanatory

Alright can do in the future. Thanks!


When reopening a saved file the data panel is empty

I have prepared a connection to an API, created all my data field-values, and saved.
When I reopen, the "Query data" field contains all the data, the Address also, but the Data panel does not.
Visual Json 1.4 from the App Store.

I would like to add, that this also goes for the header section (as seen above too).
I experience it too.


Added support for custom timeouts when creating a command

If you are not blocking, and using pexpect, you can now add a timeout parameter when creating a command.  If the command takes longer than this to complete, it will fail and throw the appropriate error code.  The default is 30 seconds.

✨🍰✨

I think this is ready for a merge now that the chain methods supports timeouts.

Again, instead of hardcoding 30 in, let's make that a constant at the top of the file.
TIMEOUT = 30

Then later
... timeout=TIMEOUT)


Application freezes after I open messages for a subscription (probably proxy-related)

I can start the application and connect to a certain service bus instance and see all the topics and subscriptions. However, when I want to send a new message or open the messages for a certain topic subscription, the application freezes and does never recover (mouse cursor shows loading icon). This only seems to happen in my corporate network, when I use an open hotspot, the problem does not occur.
I assume there is a problem with making a connection, but an error message would be more helpful.

I had similar issue as @javafrog. Using a corporate network, it didn't have any issue fetching the service meta data, however, when I tries to fetch the messages  first time, it freezes.
After 5-10 min, I kill it, try again for a few times, same issue. In one case, I let it run for a little longer, then it fetches the messages. And subsequent fetches are fast. First time freezing is true every time after restarting ServiceBusExplorer.
It appears there is something going on during the first fetch; I wish I could provide logs but can't find it.

Hi @raymaung when did you start to experience this problem? I mean, did you observe the same issue with previous versions of the tool or only with a recent version? Thanks!

Thanks for your comments! I did configure the proxy in the config file, with the same results, before I created this issue.
Today, however, it worked just as @raymaung described: The first connection took a while, appearing like a freeze. Then after like 30 seconds, the messages appeared. Subsequent accesses were quick. I did try it from our (most restrictive) LAN.
I also don't know if there are any logs written somewhere that I could provide you.

@paolosalvatori I should clarify 4.0.108 - just frozen. 4.0.109 eventually fetches the first message after many minutes.

@paolosalvatori I tested different versions against the same corporate network and here are the results

4.0.105

won't even load the meta data

4.0.106 to 4.0.108

load the meta data
freeze on first time fetching messages

4.0.109

take awhile to complete the first messages fetch
fast on subsequent messages fetch

When using SBE to connect to SB through a proxy the following four requirements must be met:

The SBE config file must be properly configured for the proxy used. This is described at https://docs.microsoft.com/en-us/dotnet/framework/network-programming/proxy-configuration. SBE needs to be restarted after a config file change.

Connectivity Mode must be AutoDetect, Http or Https. This is set when connecting to a namespace. Test all three modes.

SBE must be using a version of the SB Client that does not have the Http/Https bug. So either use a really old version of SBE or the latest, 4.0.109.

The proxy must allow traffic to SB and properly handle it.

As I understand it @raymaung this has never worked for you. I therefore believe that the issue is inside the proxy. When loading meta data the SB Client uses normal REST calls but when sending or receiving messages in Connectivity Mode in Http or Https (or AutoDetect has choosen one of the latter modes) the SB Client tunnels the traffic in HTTP or HTTPS to be able to get through the proxy and this could be tricky. I know that in one case a change had to be made on the proxy to allow this tunneled traffic. I recommend opening a case with Microsoft to solve this. If you are lucky they have information about how to configure your proxy. If not then they will probably need network traces to find out what is wrong.

Closing this as there has not been any comments in the last six months.


Json report not generated while testing from Cypress UI runner

Current behavior
cucumber Json report not generated while testing from Cypress UI runner
Desired behavior
Json report get generated while testing from Cypress UI runner as earlier versions
Test code to reproduce

Add<EMAIL_ADDRESS>Cypress 10.3.0
Cypress open
Run any feature spec

Versions

Cypress version: 10.3.0
Preprocessor version: 12.0.0
Node version: 14.17.5

Checklist

[X ] I've read the FAQ.
[X] I've read Instructions for logging issues.
[X] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

https://github.com/badeball/cypress-cucumber-preprocessor/issues/776#issuecomment-1194662310


Quick Open Case Sensitivity

As far as I can tell, the quick open window is Case sensitive?
If that is the case, I suggest instead that Oni copy Vims config options for ignorecase and smartcase.

Ignore case is fairly self explanatory, we just always ignore the case, IE a returns A or a.

Smart case is slightly different, you ignore case when a lower case string is given, but if you include upper case letters then it swaps to case-sensitive search.

IE apple returns Apple, apple, APPLE or any other combo, but searching for aPPle will only return aPPle.

I'm quite used to using just lower case search terms as I have this set in Vim, so having the quick open window work similarly would be nice.
After having a quick look, it looks like we explicitly pass over a "--case-sensitive" flag to ripgrep, so it would look like I can add a config option or two to pass over "--ignore-case" or "--smart-case" instead?
Assuming that sounds okay, what config options would we want?

@CrossR I think this is related to the reason I filed https://github.com/bryphe/oni/issues/747.
Ripgrep is the default fuzzy finder used for quick open and it's hardcoded as case-sensitive, a solution to this issue would be to enable configuration of the default arguments to ripgrep.

Ah it's actually a bit confusing (and good for us to clarify). Thanks for calling this out.
We actually only every call ripgrep once (it's really fast!), so I don't have it set up to utilize the ${searchString}, which would call it as the text is changed. So the case sensitive option we passed to ripgrep is effectively a no-op, since it isn't even using search parameters.
The logic that is impacting this is our filtering of results here:
https://github.com/bryphe/oni/blob/ba6c932c15204e4cac3302b25b7d205976b062fa/browser/src/Services/Menu/MenuReducer.ts#L114
And there are two phases of filtering there (after we get the results from the finder process, which defaults to ripgrep):

A 'pre-filter' pass where we check that all letters in the search string are present in the items
A 'fuzzy-find' pass where we use the fuse library to find and rank results.

The pre-filter pass is used for performance reasons, because running fuse can get slow with a large amount of results, so we try and rule some out ahead of time.
So there's really three phases:
(1) get results from the running process (Line 158 in QuickOpen.ts) -> (2) do the pre-filter pass (Line 114 in MenuReducer.ts) -> (3) run the fuse ranking and get the highlighted letters (Line 132 in MenuReducer.ts)
(2) and (3) are always run after the finder process returns results, so that we can rank + do the highlighting in the menu.
I was looking through this and it seems like the pre-filter pass (2) is case-sensitive, whereas the (3) fuse actually isn't, which is a problem since the behavior is confusing today and hard to explain. (And as mentioned above, the ripgrep process just dumps all the results, so it actually doesn't care about the casing at the moment).
I'm thinking we could do the following:

Add an option editor.quickOpen.caseSensitive - it can be either false, true, or "smart", to control the case-sensitivity of steps (2) and (3) in the pipeline, and the "smart" setting would behave as described above - all lowercase would be case-insensitive, but if there are upper-case letters, it would be case-sensitive.
Change the pre-filter pass to always be case-insensitive
Pick the right casing strategy for fuse based on the quickOpen.caseSensitive setting and the search input.

If we had that setting, it would at least help clarify the behavior. The only downside is that, if a custom editor.quickOpen.execCommand is specified, it could have its own casing strategy, separate from the editor.quickOpen.caseSensitive setting, which applies to the post-result filtering logic in (2) and (3). But I think that is reasonable.
Thanks for logging the issue @CrossR  and the ideas @badosu ! I'll give it a shot tomorrow morning - let me know if you have any feedback on the proposal.

@bryphe Defaulting case sensitivity to 'smart' would be a good idea I think.
Also, if someone is configuring execCommand it should be pretty clear for the person that it is not following the 'standard' configuration for the quickOpen functionality. Thanks for the clarification @bryphe, really good job!
To be frank I am not sure why we have this complicated setup, shouldn't ripgrep be fast enough to be called each time? At least that's how most of the Vim world uses a fuzzy-finder.


Devtools Issue webmanifest

Web app manifest should have the filename extension 'webmanifest'.
This issue will at least touch:

server/manifest.js
server/server.js
server/template.js
worker/staticInstall.js
worker/dynamicInstall.js

The documentation about how to generate manifest.json should be updated to manifest.webmanifest

i ended up doing this to remove conflicts to extensions manifest.json