Add filter rule association into the NAT Port Forward Create.

Hi Jared,
Thank you for a brilliant piece of work.
I would like to suggest the addition of a missing field in the Port Forward Creation page.
Is your feature request related to existing pfSense functionality that is missing from the API? Please describe.
In the pfSense UI a selection can be made to Add associated filter rule. This is the last field in the UI under port forward create, Filter rule assosiation. This seems to be missing from the REST API.
When this is used with add-associated, then pfSense will create a basic firewall rule and associate it with the nat port forward rule.
The json below shows the current request body that could be send to create a nat port forward rule.
{
  "apply": false,
  "descr": "",
  "disabled": false,
  "dst": "string",
  "dstport": "string",
  "interface": "string",
  "local-port": "string",
  "natreflection": "enable",
  "nordr": false,
  "nosync": false,
  "protocol": "tcp",
  "src": "string",
  "srcport": "string",
  "target": "string",
  "top": false
}

Describe the solution you'd like
This can be achieved by adding the filter-rule-association field to the Port Forward Create model.
It seems that there are 4 possible values that can be used here:

None
add-associated
add-unassociated
pass

Suggested json to be send in request body.
{
  "apply": false,
  "descr": "",
  "disabled": false,
  "dst": "string",
  "dstport": "string",
  "interface": "string",
  "local-port": "string",
  "natreflection": "enable",
  "nordr": false,
  "nosync": false,
  "protocol": "tcp",
  "src": "string",
  "srcport": "string",
  "target": "string",
  "top": false,
  "filter-rule-association": "string"
}

Additional context
I tried to add the field myself but since I have no knowledge on PHP I seem to keep on missing something. My solution doesn't seem to affect any change.
Kind Regards,
Gert.

I would really like to see this integration too!
It's an bit of a time saver, and this makes it more like how the GUI is supposed to work/respond

Hi @jaredhendrickson13
I had forked the repo and add additional choices to field associated_rule_id in PortFoward model to support created rule when created port forward
is there a way you can add the option for that Model
if not then can you show me the way how to setup a vps for the runner to build pkg
i had setup a pfsense with freebsd but can not run the github runner
Thanks

@lechuhuuha The reason this has not yet been implemented is it heavily relies on managing the state of a related model object, which up until v2 was difficult and required a lot of redundant logic. I think this should be much more feasible now. I'll see if I can fit it into v2.1.0.
You can refer to the link in the comment I added on #516 for help building the package from source on your fork if you want to go that route.
Thanks!


NSFS | NC | NC Coretests changes - PR 2/3

WIP - This PR is dependent on merging https://github.com/noobaa/noobaa-core/pull/7719
Explain the changes

Makefile - added run-nc-tests makefile rule for running nc_index.js tests file.
test_utils.js - added a helper function for get_coretest_path() that chooses coretest/nc_coretest path by process.env.NC_CORETEST.
nc_coretest.js - config_dir, storage, and other setups and starting nsfs.js process, added mapping between rpc_client calls and manage_nsfs commands or other mocks.
nc_index.js - added NSFS relevant test files.
test_bucketspace.js - added skips by process.env.NC_CORETEST of non-relevant tests, and different error_codes.

Issues: Fixed #xxx / Gap #xxx

Gap - nc_index.js contains commented test files that needs to be added as well.
github action for running nc_index.js

Testing Instructions:

[ ] Doc added/updated
[ ] Tests added

@naveenpaul1 The regular Coretest runs noobaa endpoint (and other components of noobaa core) and then a test can run full s3 flow.
NC Coretest runs nsfs.js instead of running the endpoint and by that, we run the NC code. Then a test can run full s3 flow on NC environment. I hope it makes it clearer, let me know if there are more questions.


Implement onboarding journey

When vendors start the app for the first time, they are required to enter several details as well as learn how to use the app.
UX has already been defined here - https://github.com/HeathWallace/coinface/issues/113
There are several tools that we could use for this, so some research should be done to figure out the best tool for the job, maybe one of the following?:

http://bootstraptour.com/
https://www.npmjs.com/package/react-joyride

After encountering an issue with the React Joyride module (whereby it calculates the co-ordinates incorrectly in the Settings drawer in the closed state) - we may find it easier to build a simpler bespoke version just for the app?

I've managed to get it working, turns out it wasn't too happy with using Chrome devtools.
@m-potts here's what I've done so far, is this workable in terms of coming up with a design?
@ArghZombies how is this looking so far?

Looks awesome! Can we style it to closer match the existing app, such as the body text? And the letter spacing looks suuper narrow for some reason


Add log and error to CompressionHandler

Related: https://github.com/ItzNotABug/appexpress-essentials/pull/1


HtmlElementView is drawn below parent widget

Expected results:
All HtmlElementView's should be drawn above.
Actual results:
As you can see initially 7x widgets are drawn above but remaining in first column aren't visible, in second column we can see that it's actually drawn below the color.

Code sample
import 'dart:html';
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

void main() {
  runApp(const TestApp());
}

class TestApp extends StatelessWidget {
  const TestApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Row(
        children: [
          Expanded(
            child: TestColumn(
              color: Colors.black,
            ),
          ),
          Expanded(
            child: TestColumn(
              color: Colors.black.withOpacity(0.9),
            ),
          ),
          Expanded(
            child: TestColumn(),
          ),
        ],
      ),
    );
  }
}

class TestColumn extends StatelessWidget {
  final Color? color;

  const TestColumn({
    Key? key,
    this.color,
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
        TestWidget(color: color),
      ],
    );
  }
}

class TestWidget extends StatelessWidget {
  final Color? color;

  const TestWidget({
    Key? key,
    this.color,
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    const viewType = 'html-test-widget';
    // ignore: undefined_prefixed_name
    ui.platformViewRegistry.registerViewFactory(
      viewType,
      (_) => ParagraphElement()
        ..text = 'TestWidget'
        ..style.color = '#ff0000',
    );

    return Container(
      height: 32.0,
      color: color,
      child: const HtmlElementView(viewType: viewType),
    );
  }
}

Logs
[✓] Flutter (Channel stable, 2.10.0, on macOS 11.6.1 20G224 darwin-x64, locale en-LV)
    • Flutter version 2.10.0 at /Users/martinsandersons/fvm/versions/2.10.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5f105a6ca7 (9 days ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.64.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

@krokyze
The expected behavior occurs when we run using html renderer:
flutter run -d chrome --web-renderer html:

Probably you are running with canvaskit rendering with which the current behavior occurs. Does using html rendering solve the issue at your end ?

@darshankawar yes it's canvaskit only, when using html I do get the expected behavior.

Thanks for the update. This seems specific to canvaskit as verified above.

 stable, master flutter doctor -v

[✓] Flutter (Channel stable, 2.10.1, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.10.1 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db747aa133 (12 hours ago), 2022-02-09 13:57:35 -0600
    • Engine revision ab46186b24
    • Dart version 2.16.1
    • DevTools version 2.9.2

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

[✓] Flutter (Channel master, 2.11.0-0.0.pre.514, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.11.0-0.0.pre.514 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 76855aa893 (4 hours ago), 2022-02-11 00:35:16 -0800
    • Engine revision bed591d394
    • Dart version 2.17.0 (build 2.17.0-87.0.dev)
    • DevTools version 2.10.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Add --roles flag to verify, lookup CLI commands

From discussion in https://github.com/docker/notary/issues/852#issuecomment-233820701

I can handle this but before that I also want to make sure this is the right way to do it. How about still discuss in #852

Sounds good, more than happy to discuss here as well if that thread gets hard to follow :)

@riyazdf  I'll pick this .


⚠ Bofrost.be has degraded performance

In 7e0e709, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2872 ms

Resolved: Bofrost.be performance has improved in ec1bc07.


Complete overhaul of plotting scripts and structure

Functionised and parameterised plotting
Restructured plotting scripts
Standardised plot style across various plot types (mostly byproduct of first point)
Deleted/removed anything unnecessary/redundant from scripts/repo
Some changes as per latest requirements/decisions

Refer 00_scripts/plot_pipeline.R now for all plotting requirements


Bump up user docker 19.03.12

Bump up user docker to 19.03.12.
Relates https://github.com/rancher/os-services/pull/229.

See https://github.com/rancher/os/issues/3000.


Is it possible to add scorers information?

Is it possible to add scorers/goals information. I am not asking you to add this info, I just want to know if it is possible like in the cl database.

Please send questions to the forum / mailing list https://groups.google.com/group/opensport. Cheers. Prost.

Thanks for adding the score. Yes, it's possible.


Getting " msauser not authorized to perform operation VersionShowCommand" when opening database in AzureDataExplorer

Module: 00
Lab/Demo: dp900-05b-stream-synapse-data-explore
Task: Create a database and ingest data
Step: 06
https://microsoftlearning.github.io/DP-900T00A-Azure-Data-Fundamentals/Instructions/Labs/dp900-05b-stream-synapse-data-explorer.html
Description of issue
When I try to open the iot-data database I am getting "Principal 'msauser=' is not authorized to perform operation 'VersionShowCommand' on 'https://depool****.wg-.kusto.azuresynapse.net:443/'. https://depool****.wg-.kusto.azuresynapse.net/;fed=true
Repro steps:

Hello @ramakoni1
I went through all the steps and could not reproduce the error.
Can you confirm you have waited for both the dxpool to be deployed (having the Running status) and the iot-database sucessfully created.
Have you tried re-creating the resources for the exercise again?
Best regards,
Mihai

Yep, I can confirm that I waited for the dxpool status to be running and db successfully created - will retry later today or tomorrow and probably trying to do a recording of the same and will share. Thank you for looking into this.
Regards.
Ramu.

@ramakoni1  We've reached out to the product group for support, but as a "Preview product" it has no SLA. I will remove from the material for the time being.
FYI @Mihai-Ac

Oh ok - was going to test it out again in the afternoon, but thanks for the update.

[like]  Rosemary Caperton reacted to your message:

From: Ramu Konidena @.>
Sent: Friday, April 28, 2023 6:46:12 PM
To: MicrosoftLearning/DP-900T00A-Azure-Data-Fundamentals @.>
Cc: Rosemary Caperton @.>; Comment @.>
Subject: Re: [MicrosoftLearning/DP-900T00A-Azure-Data-Fundamentals] Getting " msauser not authorized to perform operation VersionShowCommand" when opening database in AzureDataExplorer (Issue #26)
Oh ok - was going to test it out again in the afternoon, but thanks for the update.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/DP-900T00A-Azure-Data-Fundamentals/issues/26#issuecomment-1527955605, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALTP4RT3GB3RH26LXD3LZSTXDQF7JANCNFSM6AAAAAAXLUKSIY.
You are receiving this because you commented.Message ID: @.***>


Please correct license file

It says
Copyright 2017 Steven Diamond

@phschiele fyi

Done in 5bd24a4, thanks @tschm!


After training, there are only 2G Pt files left. What's wrong with missing files?

After I tried to train with my own data set, the PT file I got was not 7g in size. Use it to execute. / scripts / text2image.sh -- debug error "runtimeerror: error (s) in loading state_dict for gpt2model:".
Who can help me?Thank you.

Is the model size identical to the size in the paper? You should match the hyperparameters.


Unable to login with new account.

I tried with two emails and It always fails on login to get the API key. AM I mad, or is something wrong

Nope, not crazy, and an ongoing issue that will hopefully be fixed soon! For some small number of people. there's a weird DNS glitch that creates this problem, and Apiable is working on a fix (aka a whole new portal).
In the meantime, if you send me an e-mail to<EMAIL_ADDRESS>I'd be happy to generate you a key by hand.
Sorry about this,
Alexander

Thanks for the reply the account finally worked, it all worked perfect on HA for 1 day and now I get the following issue.
https://github.com/alexander0042/pirate-weather-ha/issues/134

Apologies for missing this one, and happy this particular issue was fixed! I'm going to close for now so we can focus on the HA side of things


Minor fixes in mutable dispatch tests.

Fix size of newWrapper in MutableDispatchSVMArguments.
Fix errnoneus clCommandNDRangeKernelKHR call.

@EwanC I added another small fix in this one

Merging as discussed in the January 30th teleconference.


[Ready to Review] Feature/500 error when accessing log detail

Purpose
Issue https://openscience.atlassian.net/browse/OSF-5777
Accessing log detail /v2/logs/{log_id}/ for a project's logs gives a 500.
This issue blocks https://openscience.atlassian.net/browse/OSF-5471
Changes
Instead of using ContributorOrPublic method on log views (which was built for nodes), created a ContributorOrPublicForLogs method which then calls ContributorOrPublic for each of the nodes on the log's backref to see if the user has permission to access the log.
(Will be modified slightly when backrefs are eliminated between nodes and nodelogs).
Tests were already written for these endpoints and were now failing locally before this change.  Are these running on Travis?

Change looks good. @pattisdr Can you please add a regression test?

@sloria, where do regression tests go?  There are already unittests for this.  (When I originally wrote unittests, they were passing. When I pulled from develop, they were failing. This change makes the unittests pass again.)

Oh, ok. So there are tests for the log detail endpoint that fail without this change? I didn't see those. There are other tests that were failing on develop, but those were unrelated.

Yes, these tests were failing before this change:
https://github.com/CenterForOpenScience/osf.io/blob/develop/api_tests/logs/views/test_log_detail.py
I am still confused about it, because I wrote these tests when I did log permissions, and they were originally passing.  When I pulled from develop, they were failing and this change made them pass again.

Okay, so now I can't duplicate this ^.  I will try to write another test that fails before this change.

Thanks for helping me figure out a way to test this @sloria.
Added test that tacks ?format=api onto the end of the log detail request.   The test will fail prior to this fix.  Test needed because the standard api tests were not duplicating the issue getting seeing in the browser.


Fix Docs: Manifest incorrect in chapter Deploying using a Manifest

resolves https://github.com/spring-cloud/spring-cloud-dataflow-server-cloudfoundry/issues/425

rebased, merged as a1b30eb7009fedfbc78065f3649c58e55919d1e4


Add smart retry flow

Create a flow that is capable of performing smart retries with dbt. @sungchun12 has an example of how to achieve this functionality here: https://github.com/sungchun12/prefect-dbt-cloud/blob/main/dbt_cloud_smart_rerun.py

Related: https://github.com/PrefectHQ/prefect-recipes/tree/main/prefect/flows/dbt/rerun-models-from-failure#handle-dbt-model-failures

Closed by #81


HDDS-2536. Add ozone.om.internal.service.id to OM HA configuration.

What changes were proposed in this pull request?
This Jira is to add ozone.om.internal.serviceid to let OM knows it belongs to a particular service.
As now we have ozone.om.service.ids -≥ where we can define all service id's in a cluster.(This can happen if the same config is shared across the cluster)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2536
How was this patch tested?
Modified MiniOzoneHAclusterImpl to set serviceID value for ozone.om.internal.service.id. And ran TestOzoneFSHAUrls.java, and test passed. And also verified that the new code path is being run.

Thank You @anuengineer and @dineshchitlangia for the review.
To make it to new style java Config opened a new Jira(https://issues.apache.org/jira/browse/HDDS-2581)


Fix issues when passing a vararg for non-rest params

Purpose
$title.
Fixes #24348 - Invalid type set for the rest arg when the vararg provides for required/defualtable params too
Fixes #24281 - Taint analyzer crashes when passing a rest arg to a function with no rest param
Remarks
https://github.com/ballerina-platform/ballerina-lang/issues/24415
https://github.com/ballerina-platform/ballerina-lang/issues/23307#issuecomment-647352681
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

The following crashes:
public function main() {
    [int, (string|int)...] x = [1, 10, "foo"];
    foo(true, ...x);
}

function foo(boolean b, int i, string... s) {
}

This should've been caught at compile time right?

The following crashes:
public function main() {
    [int, (string|int)...] x = [1, 10, "foo"];
    foo(true, ...x);
}

function foo(boolean b, int i, string... s) {
}

This should've been caught at compile time right?

This is due to a bug in tuple type-checking.
How we type-check this is by first creating an expected tuple type based on the remaining non-rest param types and the rest param (if available), which in this case will be [int, string...]. We then use this new type as the expected type for the rest-arg expression. But tuple type-checking seems to be broken when the source tuple has a rest descriptor.
Neither of the following y and z assignments fail.
public function main() {
    [int, (string|int)...] x = [1, 10, "foo"];

    [int, string...] y = x; // no error!
    [int] z = x; // no error!
}

Created https://github.com/ballerina-platform/ballerina-lang/issues/24764 to track this.


question, map() vs through()

Sorry.  This is probably a very noob question but I don't see why there is a .map() function when .through() seems to do the same exact thing or more. Is there some underlying behavioral difference?  When would you choose one over the other?

I don't think they do the same thing, they have different type signatures:
through :: (Stream a -> Stream b) -> Stream a -> Stream b

map :: (a -> b) -> Stream a -> Stream b

I'm not sure why you'd favour the first over the second if all you want to do was a simple map.
hl([1,2,3]).through(xs => xs.map(x => x +1)).each(console.log); // 2, 3, 4
hl([1,2,3]).map(x => x +1).each(console.log); // 2, 3, 4


The shadow under the header does not reach the timeline

Hi, we really like your calendar!
There is one problem related to UI
If the calendar header(CalendarHeaderBackground) has an elevation (by default it is 2), then its shadow does not reach the left edge of the screen (above timeline bloc)

We tried to fix this through the timeline builder.
But without changes in the library, it was not possible. Maybe you will succeed.
Or as a workaround, you can add Divider (with color and height parameters) or some builder here \kalender\lib\src\views\multi_day_view\multi_day_view.dart:108

Hi, thanks for bringing it to my attention will have a look at it.

Hi I fixed the issue, the latest version 0.2.0 contains it.

Thank you. But there is still a small problem:

Yes, i run \kalender\example\lib\main.dart on android

Hi, should be fixed now let me know if it works for you as well.

Everything looks great!


DVA memory warning

DVA3219 VM spam:
"Detected non-Synology recommended memory module configurations."
No matter what is set:
sed -i "s/support_memory_compatibility="no"/support_memory_compatibility="yes"/"  /etc.defaults/synoinfo.conf
sed -i "s/support_memory_compatibility="yes"/support_memory_compatibility="no"/"  /etc.defaults/synoinfo.conf
sed -i "s/support_memory_compatibility="no"/support_memory_compatibility="yes"/"  /etc/synoinfo.conf
sed -i "s/support_memory_compatibility="yes"/support_memory_compatibility="no"/"  /etc/synoinfo.conf
Here people believe opposite settings is good for DVA:
https://github.com/fbelavenuto/arpl/issues/307
Another annoyance is nonstop nvidia warning: "NVRM: No NVIDIA graphics adapter found!" in dmesg
Hope someone knows what's special about DVA.

Your sed commands need to escape the " around the yes and no, otherwise sed fails to edit support_memory_compatibilty.
sed -i "s/support_memory_compatibility="\no\"/support_memory_compatibility="\yes\"/" /etc/synoinfo.conf
But there is an easier way to disable support_memory_compatibility:
synosetkeyvalue /etc/synoinfo.conf support_memory_compatibility no
synosetkeyvalue /etc.defaults/synoinfo.conf support_memory_compatibility no

Or to enable support_memory_compatibility:
synosetkeyvalue /etc/synoinfo.conf support_memory_compatibility yes
synosetkeyvalue /etc.defaults/synoinfo.conf support_memory_compatibility yes

And to check the values:
synogetkeyvalue /etc/synoinfo.conf support_memory_compatibility
synogetkeyvalue /etc.defaults/synoinfo.conf support_memory_compatibility

Sorry, the backslash was removed as I pasted it without code.
Still, in both ways the message stays there. By doing manually, by using -r switch, by using loader settings. No matter how it's set after boot.

Conclusion: -r sets 'no'. Reportedly, DVAs requires 'yes'. In my report, both don't work. Proposal that works:
/usr/lib/systemd/system/SynoMemCheck.service
ExecStart=/bin/true

So you edited /usr/lib/systemd/system/SynoMemCheck.service to replace ExecStart=/usr/syno/bin/syno_mem_check with ExecStart=/bin/true ?
There's also a copy of SynoMemCheck.service in:
/usr/lib/systemd/system/basic.target.wants/SynoMemCheck.service
/usr/lib/systemd/system/syno-bootup-done.target.wants/SynoMemCheck.service

Correct, because i could not disable the service, it would come up like many other things in DSM. Looks like /bin/true is used in 10 other services already, quite popular.

Fixed in Release v3.1.63


From cv2.Mat to image

Hello dear developers!
I ran into a problem when converting cv2.Mat in the picture
As I understand from your example,
"x": [ [ 1 ], [ 2 ], [ 3 ] ],
"y": [ [ 2 ], [ 3 ], [ 4 ] ],
"z": [ [ 3 ], [ 4 ], [ 5 ] ]

what (x y z) these are (R G B) colors. I'm converting an image like in example, but I get an error:
Response Status: 400 Bad Requests
Response body: {"error": "input images are not an array","error_type":"bad_request_error"}

Do you have any Python code that would be an example of checking from Mat images to json? Thank you in advance

session content:
HTTP/1.1 200 OK
Content-Type: application/json
Content-Length: 209

{
  "created_at":<PHONE_NUMBER>,
  "execution_count": 0,
  "inputs": {
    "images": "float32[1,3,1024,1024]"
  },
  "last_executed_at": 0,
  "model": "mod_A",
  "option": {
    "cuda": false
  },
  "outputs": {
    "output0": "float32[1,7,21504]"
  },
  "version": "v1"
}

Hi, @kilievich-dmitriy-andreevich
When attempting to run the ONNX session, you should send the following JSON as the post data:
{
  "images": [
    // shape 1
    [
      // shape 3
      [
        // shape 1024
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        ... // 1024 arrays
      ],
      [
        // shape 1024
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        ... // 1024 arrays
      ],
      [
        // shape 1024
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        [
          //shape 1024
          0,0,0,0,0,0, ... // 1024 float numbers
        ],
        ... // 1024 arrays
      ]
    ]
  ]
}

There is a (1024, 1024) shape in the data, which I assume refers to the width or height of the image.


added 1st gen surface laptop

#6279

Dear @JohanFreelancer9, could you please have a look?
Thank you

@Dansimp - PR has been copy edited and has been approved by @CoveMiner. Can you please assist to merge this PR? This is based on issue #6279
Thank you.
cc: @kenwith


feat: Update sdk schema

Description

Tom has a commit in the sdk side to go through and update the schema. I am bring that update in composer. (the package update is included in #2679 )
Here are two issues I found for the schema update, others looks good to me.

Enum is updated to one of enum, which caused all the enum type failed to render in composer.
EditArray->changeType, HttpRequest->responseType. Here is one example:

For value with different types, we should show string editor as a default instead of empty.
Now:

Suggested Fix:

@cwhitten @a-b-r-o-w-n
Task Item
fixes #2541

Screenshots

I'll make some PR's today to address those issues.

@luhan2017 update: I have been talking with @tomlm about make some more adjustments to the schema based on the usage by the property editor. He is in the process of applying those updates and I will push some commits into this branch. I have marked the PR as draft in the meantime.

@a-b-r-o-w-n,

Begindialog.dialog is missing "type" field, so we got such error in composer, I've created this PR is SDK side https://github.com/microsoft/botbuilder-dotnet/pull/3801

Not sure which version of the schema you are using. I see Tom make more changes on the schema and the nightly build didn't come out yet. we might need to update the schema to the latest version after it is ready.

The schema was based off of microsoft/botbuilder-dotnet#3794. That has been merged to we should take the nightly build to generate the schema.

@luhan2017 I have fixed 1 failing e2e test. The other is due to the issue you mentioned above. Ping me when you update the schema to the nightly build and I will do another look and then we can merge.

@a-b-r-o-w-n , I've updated to the very latest schema and packages, and I did some sanity test, the samples looks good now.

I've found another issue about the validation, I've talke with @lei9444 on this, he will submit a PR to fix the validation logic.

@luhan2017 can you address the conflicts as well as investigate the e2e test failure?
Once those are addressed, go ahead and merge.


[grocy] Upgrade to version 3.1.3 and fix upgrade bug

Description of the change

Added emptyDir volume for the viewcache in order to prevent problems when upgrading the image that would require manual intervention.
Changed image tag to version-v3.1.3.

Benefits
No manual interaction required when upgrading the the image if persistence is enabled.
grocy's upgrade instructions mention clearing data/viewcache. Failing to do so will result in an blank pages after upgrading the image. Mounting the directory as emptyDir removes the need to open a shell into the container and manually performing the operation after upgrading the image (which doesn't fit well in a k8s workflow).
Possible drawbacks
After restarting the pod, the first time visiting the page might be a bit slower as the cache needs to be refilled.

Checklist

[X] Chart version bumped in Chart.yaml according to semver.
[X] Title of the PR starts with chart name (e.g. [home-assistant])
[X] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

I have taken the liberty to update this PR so that it passes CI.


Migrate countdown to lit

[x] Convert JS to Lit
[x] Convert CSS to be extendable
[x] Create description page

Fixed in https://github.com/YuraVolk/Js-Library/commit/928f75cc6e8963bd48e7df22d7bcca642b8e9700.


[BUG] i Don't get the sublist at configs tab

Describe the bug
When i click on the config tab in the menu, A submenu is supposed to open but it doesn't, this way i can't ave the config or edit the settings.
Click on config tab.
It's supossed to open a submenu, i got it before but now it doesn't work for some reason
https://i.imgur.com/R6gGDwy.png
Desktop (please complete the following information):

OS: Microsoft Windows NT 10.0.18363.0
Browser Chrome Versie 88.0.4324.190 (Officiële build) (64-bits)

You have to open a config for the submenu to appear. Have you tried double clicking a config or selecting it and then clicking on the edit button?

You have to open a config for the submenu to appear. Have you tried double clicking a config or selecting it and then clicking on the edit button?

Yes i tried that, i think it totally disappeared when i made a new config

Had the same issue, not sure why this happened, but full page refresh (Ctrl+F5) helped


Improve HTML attribute wrap

This ensures that wrap-line-length is respected where possible.

Possibly related bug was addressed here: line_char_count did not reset properly which caused wrap_line_length to not be respected in some cases

Thanks for submitting!


Chocko installation is not working

I install https://www.microsoft.com/en-us/download/confirmation.aspx?id=53175
Then:
PS C:\Windows\system32> choco install microsoft-windows-terminal
Chocolatey v0.10.15
Installing the following packages:
microsoft-windows-terminal
By installing you accept licenses for the packages.
Progress: Downloading microsoft-windows-terminal 0.11.1191.0... 100%

microsoft-windows-terminal v0.11.1191.0 [Approved]
microsoft-windows-terminal package files install completed. Performing other installation steps.
The package microsoft-windows-terminal wants to run 'chocolateyInstall.ps1'.
Note: If you don't run this script, the installation will fail.
Note: To confirm automatically next time, use '-y' or consider:
choco feature enable -n allowGlobalConfirmation
Do you want to run the script?([Y]es/[A]ll - yes to all/[N]o/[P]rint): A

Progress: 0% - Processing                                                                                ERROR: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Deployment failed with HRESULT: 0x80073CF3, Package failed updates, dependency or conflict validation.

Windows cannot install package Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe because this package depends on a framework that could not be found. Provide the framework "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 14.0.27810.0, along with this package to install. The frameworks with name "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are:
Windows cannot install package Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe because this package depends on a framework that could not be found. Provide the framework "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 14.0.27810.0, along with this package to install. The frameworks with name "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are: {Microsoft.VCLibs.140.00.UWPDesktop_14.0.26905.0_x64__8wekyb3d8bbwe}

NOTE: For additional information, look for [ActivityId] 4858422f-2018-0002-da45-58481820d601 in the Event Log or use the command line Get-AppPackageLog -ActivityID 4858422f-2018-0002-da45-58481820d601

The install of microsoft-windows-terminal was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\microsoft-windows-terminal\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - microsoft-windows-terminal (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\microsoft-windows-terminal\tools\chocolateyInstall.ps1'.
 See log for details.
PS C:\Windows\system32>

PS C:\Windows\system32> Get-AppPackageLog -ActivityID 4858422f-2018-0002-da45-58481820d601

Time                      ID           Message
----                      --           -------
5/1/2020 5:26:59 PM       164          The app bundle signature was validated for core content of the app bundle
                                       published by CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond,
                                       S=Washington, C=US. App packages won't be validated until they are read.
5/1/2020 5:26:59 PM       216          App manifest validation warning: Declared namespace
                                       http://schemas.microsoft.com/appx/2019/bundle is inapplicable, it will be
                                       ignored during manifest processing.
5/1/2020 5:26:59 PM       391          The bundle streaming reader was created successfully for bundle
                                       Microsoft.WindowsTerminal_2020.428.1934.0_neutral_~_8wekyb3d8bbwe.
5/1/2020 5:26:59 PM       157          The app package signature was validated for core content of the app package
                                       published by CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond,
                                       S=Washington, C=US. Payload won't be validated until the files are read.
5/1/2020 5:26:59 PM       216          App manifest validation warning: Declared namespace
                                       http://schemas.microsoft.com/developer/appx/2015/build is inapplicable, it will
                                       be ignored during manifest processing.
5/1/2020 5:26:59 PM       170          The streaming reader was created successfully for app package
                                       Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe.
5/1/2020 5:26:59 PM       603          Started deployment Add operation on a package with main parameter
                                       Microsoft.WindowsTerminal_0.11.1191.0_8wekyb3d8bbwe.msixbundle and Options 0
                                       and 0. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing
                                       app deployment issues.
5/1/2020 5:26:59 PM       10002        Creating Resiliency File C:\ProgramData\Microsoft\Windows\AppRepository\8f6c6be8
                                       -d660-4483-aff2-585bc21063d6_S-1-5-21-3089440382-2224085253-3903626013-1001_1.rs
                                       lc for Add Operation on Package
                                       Microsoft.WindowsTerminal_2020.428.1934.0_neutral_~_8wekyb3d8bbwe.
5/1/2020 5:26:59 PM       607          Deployment Add operation on package
                                       Microsoft.WindowsTerminal_2020.428.1934.0_neutral_~_8wekyb3d8bbwe has been
                                       de-queued and is running for user SID
                                       S-1-5-21-3089440382-2224085253-3903626013-1001.
5/1/2020 5:26:59 PM       614          Bundle Uri file:///C:/ProgramData/chocolatey/lib/microsoft-windows-terminal/tool
                                       s/Microsoft.WindowsTerminal_0.11.1191.0_8wekyb3d8bbwe.msixbundle contains
                                       packages: "CascadiaPackage_0.11.1191.0_x86.msix":
                                       Microsoft.WindowsTerminal_0.11.1191.0_x86__8wekyb3d8bbwe
                                       "CascadiaPackage_0.11.1191.0_x64.msix":
                                       Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe
                                       "CascadiaPackage_0.11.1191.0_ARM64.msix":
                                       Microsoft.WindowsTerminal_0.11.1191.0_arm64__8wekyb3d8bbwe.
5/1/2020 5:26:59 PM       854          Successfully added the following uri(s) to be processed:  file:///C:/ProgramData
                                       /chocolatey/lib/microsoft-windows-terminal/tools/Microsoft.WindowsTerminal_0.11.
                                       1191.0_8wekyb3d8bbwe.msixbundle file:///C:/ProgramData/chocolatey/lib/microsoft-
                                       windows-terminal/tools/Microsoft.WindowsTerminal_0.11.1191.0_8wekyb3d8bbwe.msixb
                                       undle\CascadiaPackage_0.11.1191.0_x64.msix.
5/1/2020 5:26:59 PM       628          Windows cannot install package
                                       Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe because this package
                                       depends on a framework that could not be found. Provide the framework
                                       "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation,
                                       O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64
                                       processor architecture and minimum version 14.0.27810.0, along with this
                                       package to install. The frameworks with name
                                       "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are:
                                       {Microsoft.VCLibs.140.00.UWPDesktop_14.0.26905.0_x64__8wekyb3d8bbwe}
5/1/2020 5:26:59 PM       605          The last successful state reached was Indexed. Failure occurred before reaching
                                       the next state Resolved. hr: 0x80073CF3
5/1/2020 5:26:59 PM       401          Deployment Add operation with target volume C: on Package
                                       Microsoft.WindowsTerminal_2020.428.1934.0_neutral_~_8wekyb3d8bbwe from:
                                       (Microsoft.WindowsTerminal_0.11.1191.0_8wekyb3d8bbwe.msixbundle)  failed with
                                       error 0x80073CF3. See http://go.microsoft.com/fwlink/?LinkId=235160 for help
                                       diagnosing app deployment issues.
5/1/2020 5:26:59 PM       404          AppX Deployment operation failed for package
                                       Microsoft.WindowsTerminal_2020.428.1934.0_neutral_~_8wekyb3d8bbwe with error
                                       0x80073CF3. The specific error text for this failure is: Windows cannot install
                                       package Microsoft.WindowsTerminal_0.11.1191.0_x64__8wekyb3d8bbwe because this
                                       package depends on a framework that could not be found. Provide the framework
                                       "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation,
                                       O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64
                                       processor architecture and minimum version 14.0.27810.0, along with this
                                       package to install. The frameworks with name
                                       "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are:
                                       {Microsoft.VCLibs.140.00.UWPDesktop_14.0.26905.0_x64__8wekyb3d8bbwe}

chocolatey.log

Thanks for the report! This is actually already being tracked by another issue on our repo - please refer to #3097 for more discussion.
/dup #3097
This is actually also already fixed in #5661, and should be a part of the next release ☺


/scripts/build.sh fails two unit tests

[ERROR] Failures:
[ERROR]   SpelTaskEvaluatorTests.test32:289 expected: </> but was:
[ERROR]   MkdirTests.test2:27 Expected java.nio.file.FileSystemException to be thrown, but nothing was thrown.
[INFO]
[ERROR] Tests run: 98, Failures: 2, Errors: 0, Skipped: 0
Assertions.assertEquals(FilenameUtils.getFullPathNoEndSeparator(System.getProperty("java.io.tmpdir")),evaluated.get("tempDir"));
java.io.tmpdir is /tmp on my machine, and getFullPathNoEndSeparator gives "/", which is not equal to "/tmp"
task.set("path", "/no/such/thing");
Files.createDirectories() will not throw expected exception.
Am I missing anything here?
Thanks

Interesting. I just ran it locally on my machine and it worked. What OS are you on?

hi I am runing on CentOS 7

@okayrunner Hi just a little confused, what's the point of MkdirTests.test2 and why it's expected to throw an exception? It creates /no/such/thing directory anyways

and now I tried running it on a clean Ubuntu18.04.3 LTS, I got the same error again.
I guess you set the variable java.io.tmpdir on your machine?

Appreciate if you can look at this and help


Typos fix

Several typos have been fixed (e.g. "We create two fake `div` element" into "We create two fake `div` elements")

Thanks @Konrud 👍


Longer load time

Game stops loading around 60% when playing 1.2.0 version of game with 1.2.0 version of DarkCodex. Game loads ok when DarkCodex is uninstalled.

I have a couple features that read through all blueprints. Way back that wasn't an issue as all blueprints are loaded into the game anyway. This was optimized some time ago, which shortens load time noticeable. Unfortunately my mod now takes more time to load (exactly the time which was gained by the optimization). On the plus side, the blueprints stay in cache, so this time loss is only once, even if other mods do the same (Toybox for example).
TL;DR it takes about 30 to 60 seconds longer to load, depending on your specs. Sorry.
I can probably predefine which blueprints needs to be edited and reduce load time that way.

Made huge improvement in loading time.


Fatal error: Cannot read property 'distribute' of undefined

We're running into a new error after updating recently to the newest version of svg-sprite. For us, the task is fired off during a grunt build, using grunt-svg-sprite module.
The options grunt-svg-sprite use look like this (I added the log verbose to get the dump, normally we don't have a log statement)
'use strict';

module.exports = function (grunt) {
  // Create SVG sprite
  // see: https://github.com/jkphl/grunt-svg-sprite
  grunt.config.set('svg_sprite', {
    app: {
      cwd: '<%= paths.src.app.media %>/',
      src: ['**/*.svg'],
      dest: '<%= paths.dist.media %>/app/',
      options: {
        log: 'verbose',
        mode: {
          inline: true,
          symbol: {
            dest: './sprites',
            sprite: 'icons.svg'
          }
        }
      }
    }
  });
};

The error message I'm getting is:
Running "svg_sprite:app" (svg_sprite) task
2015-05-11 14:26:31 - verbose: Initialized spriter configuration
2015-05-11 14:26:31 - info: Created spriter instance
2015-05-11 14:26:31 - verbose: Added shape "icons:regular"
2015-05-11 14:26:31 - verbose: Added shape "scott:regular"
2015-05-11 14:26:31 - error: Optimizing "scott.svg" with SVGO failed with error "%s" ArgumentError: Invalid SVG file
    at Object.SVGShape._initSVG (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/lib/svg-sprite/shape.js:317:14)
    at Object.SVGShape.setSVG (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/lib/svg-sprite/shape.js:304:14)
    at /Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/lib/svg-sprite/transform/svgo.js:68:10
    at optimizeOnceCallback (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/lib/svgo.js:43:17)
    at /Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/lib/svgo.js:65:9
    at Object.sax.onend (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/lib/svgo/svg2js.js:140:26)
    at emit (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/node_modules/sax/lib/sax.js:625:33)
    at end (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/node_modules/sax/lib/sax.js:667:3)
    at Object.write (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/node_modules/sax/lib/sax.js:929:30)
    at Object.SAXParser.close (/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/node_modules/sax/lib/sax.js:153:38)
2015-05-11 14:26:31 - verbose: Added shape "slider-nav:regular"
Fatal error: Cannot read property 'distribute' of undefined

I tracked it down to the regex in shape.js line 317 in v 1.2.3 - looks like the validation was added 4/18 (changeset: https://github.com/jkphl/svg-sprite/commit/0a921c6ea26aeda2355381f349b79b5c9f2db3de)
Here's an SVG file that repros the issue:

if you comment out the first line (as it is below) - (the rect declaration) the grunt build fails with the above noted error.
If you uncomment the first line (the rect declaration) the grunt build succeeds.

<svg xmlns="http://www.w3.org/2000/svg" version="1.1">
  <!-- <rect x="25" y="25" width="200" height="200" fill="lime" stroke-width="4" stroke="pink" /> -->

  <symbol id="calendar" viewBox="0 0 60 60">
    <path d="M47.19 12.54h-0.4V8.72c0-2.05-1.67-3.72-3.72-3.72 -2.05 0-3.72 1.67-3.72 3.72v3.82h-5.61V8.72C33.74 6.67 32.07 5 30.02 5c-2.05 0-3.72 1.67-3.72 3.72v3.82h-5.61V8.72c0-2.05-1.67-3.72-3.72-3.72 -2.05 0-3.72 1.67-3.72 3.72v3.82h-0.43c-3.84 0-6.97 3.13-6.97 6.97v28.54c0 3.84 3.13 6.96 6.97 6.96h34.37c3.84 0 6.96-3.12 6.96-6.96V19.5C54.15 15.66 51.03 12.54 47.19 12.54zM41.44 8.72c0-0.9 0.73-1.63 1.63-1.63 0.9 0 1.63 0.73 1.63 1.63v3.82 1.04 3.9c0 0.9-0.73 1.63-1.63 1.63 -0.9 0-1.63-0.73-1.63-1.63v-3.89 -1.04V8.72zM28.39 8.72c0-0.9 0.73-1.63 1.63-1.63s1.63 0.73 1.63 1.63v3.82 1.04 3.9c0 0.9-0.73 1.63-1.63 1.63s-1.63-0.73-1.63-1.63v-3.89 -1.04V8.72zM15.34 8.72c0-0.9 0.73-1.63 1.63-1.63 0.9 0 1.63 0.73 1.63 1.63v3.82 1.04 3.9c0 0.9-0.73 1.63-1.63 1.63 -0.9 0-1.63-0.73-1.63-1.63v-3.89 -1.04V8.72zM12.82 14.63h0.43v2.85c0 2.05 1.67 3.72 3.72 3.72 2.05 0 3.72-1.67 3.72-3.72v-2.85h5.61v2.85c0 2.05 1.67 3.72 3.72 3.72 2.05 0 3.72-1.67 3.72-3.72v-2.85h5.61v2.85c0 2.05 1.67 3.72 3.72 3.72 2.05 0 3.72-1.67 3.72-3.72v-2.85h0.4c2.69 0 4.87 2.19 4.87 4.87v6.1H7.94v-6.09C7.94 16.81 10.13 14.63 12.82 14.63zM47.19 52.91H12.82c-2.69 0-4.88-2.19-4.88-4.88V27.69h44.12v20.35C52.06 50.73 49.87 52.91 47.19 52.91zM13.28 48.21h33.8V31.32H13.28V48.21zM15.37 40.97h4.43v5.15h-4.43V40.97zM34.42 40.97h4.18v5.15h-4.18V40.97zM32.33 46.13h-4.18v-5.15h4.18V46.13zM34.42 38.88v-5.47h4.18v5.48H34.42zM32.33 38.88h-4.18v-5.47h4.18V38.88zM26.06 38.88h-4.17v-5.47h4.18V38.88zM26.06 40.97v5.15h-4.17v-5.15H26.06zM40.68 46.13v-5.15h4.3v5.15H40.68L40.68 46.13zM44.98 38.88h-4.3v-5.47h4.3V38.88zM19.8 33.41v5.48h-4.43v-5.47H19.8z" />
  </symbol>
</svg>

Could you please check which version of SVGO you are running? There has been a similar issue before, which was caused by an SVGO bug. I'd like to ensure that this is not the problem before we dig deeper.

/Users/sburkh4/Projects/SHS/shs-web/node_modules/grunt-svg-sprite/node_modules/svg-sprite/node_modules/svgo/bin/svgo -v
0.5.2

Hmm, ok, so it's the most recent one. I'll try to reproduce the case tomorrow and get back to you.

I was able to bypass the bug by modifying shape.js line 317 to change the regex to /.*/ ;) - not the fix you're looking for though I'd guess. Seems like it's related to the regex though.

That's a valuable hint, thanks a lot. I made a little change to the regex a couple of days ago, maybe that introduced a regression of some kind. I'll look into it. Thanks again!

One more hint then, I tried the regex you originally committed on 4/18 but that didn't fix this issue. Thanks for being so responsive!

You're welcome. Thanks again!

That was a weird one indeed, and I didn't really understand it (although it should be fixed now). It seems that SVGO under certain circumstances calls its result handler twice: Once with the regular optimized SVG, and once with an empty <svg/> element, which doesn't match the regex, hence the error. I'll further investigate why this double call is happening. In the meantime, I modified the regex to suit all situations.

I am currently experiencing this error using it with a normal npm script.
Node version 0.12.7

Could you please post more details, like your complete config and the SVG files used?

Thanks for the speedy reply! Code is exactly from the example:
var spriter = new SVGSpriter({
      dest: global.DIST + '/images/svgs',
      mode: {
          css: {
              render: {
                  css:true
              }
          }
      }
  }),
  cwd = path.resolve(global.SRC + '/images/svgs');

  glob.glob('**/*.svg', {cwd: cwd}, function(err, files) {
      files.forEach(function(file){

          spriter.add(new File({
              path: path.join(cwd, file),
              base: cwd,
              contents: fs.readFileSync(path.join(cwd, file))
          }));
      })

      spriter.compile(function(error, result, data){
          for (var type in result.css) {
              mkdirp.sync(path.dirname(result.css[type].path));
              fs.writeFileSync(result.css[type].path, result.css[type].contents);
          }
      });
  });

The version of svg-sprite is: 1.2.12.
Is there anything specific you need to know?

Could you please try activating the debug logs and see if there's an explanation?
{
	dest: global.DIST + '/images/svgs',
	log: 'debug',
	// ...
}

Hi - I tried it again this morning and it appears to be working, oddly! I'm wondering if the error was caused by a corrupt SVG or something like that? Thanks for the assistance anyway!

Oh great! Sorry for me not being more responsive, I'm at a conference right now. But checking your SVGs would've probably been the next thing I had suggested. q:)

You've extremely responsive and helpful :). Thank you

Just encountered this issue, however I did not update my version of svg-sprite.  However I did upgrade to node 5.X, so that could be related.

@jarcoal We are using svg-sprite with Node 5 in production without any issues, so this shouldn't be the problem. Again, could you please post your complete configuration (and double-check that all of your SVG files are valid; you might also try it with SVGO optimization disabled)? Thanks!

Thanks for the quick reply!  I'm using svg-sprite through grunt-svg-sprite, and only noticed this issue on our CI server at first.  I tried to duplicate it locally but could not.  Then I cleared out my node_nodules and re-installed them, that's when I started getting the error locally as well.
Here is my grunt config:
    svg_sprite: {
      sm: {
        expand: true,
        cwd: 'src/svg',
        src: ['*.svg'],
        dest: 'dist',
        options: {
          shape: {
            dimension: {
              maxWidth: 16,
              maxHeight: 16
            },
          },
          mode: {
            css: {
              dimensions: "",
              sprite: 'sm.svg',
              prefix: ".svg-%s-sm",
              bust: false,
              render: {
                css: {
                  dest: 'svg-sm.css'
                }
              }
            },
          }
        }
      },
      md: {
        expand: true,
        cwd: 'src/svg',
        src: ['*.svg'],
        dest: 'dist',
        options: {
          shape: {
            dimension: {
              maxWidth: 24,
              maxHeight: 24
            },
          },
          mode: {
            css: {
              dimensions: "",
              sprite: 'md.svg',
              prefix: ".svg-%s-md",
              bust: false,
              render: {
                css: {
                  dest: 'svg-md.css'
                }
              }
            },
          }
        }
      },
      lg: {
        expand: true,
        cwd: 'src/svg',
        src: ['*.svg'],
        dest: 'dist',
        options: {
          shape: {
            dimension: {
              maxWidth: 32,
              maxHeight: 32
            },
          },
          mode: {
            css: {
              dimensions: "",
              sprite: 'lg.svg',
              prefix: ".svg-%s-lg",
              bust: false,
              render: {
                css: {
                  dest: 'svg-lg.css'
                }
              }
            },
          }
        }
      }
    },

And here is the line I have in my package.json:
  "devDependencies": {
    "grunt-svg-sprite": "^1.0.18",
    // ...
  }

@jarcoal I see. Is there anything holding you back from updating grunt-svg-sprite to the most recent version (1.2.14)?

Nope, but I tried that and it didn't make a difference.

@jarcoal There has been a regex issue that should've been fixed with version 1.2.4 (see above), so I'd definitely recommend updating to the most recent version anyway. Also, did you try to disable SVGO for a moment?

Ok I upgraded to 1.2.14, cleared out node_modules and re-installed.  Still getting the same error, however I did bump up the log level and now see an SVGO error:
2015-10-23 13:57:40 - verbose: Added shape "ios-calendar-outline:regular"
2015-10-23 13:57:40 - error: Optimizing "ios-calendar-outline.svg" with SVGO failed with error "TypeError: Cannot read property 'length' of undefined"
Fatal error: Cannot read property 'distribute' of undefined

I'm not sure how to disable SVGO.

@jarcoal Ah, that's what I thought. Disabling SVGO is simple:
var config = {
	shape: {
		transform: []
	}
}

This will skip SVGO, but leave your SVG files unoptimized, which isn't ideal of course. You could further dig into it and disable single SVGO plugins instead of the whole optimization, but I'd recommend using the online configurator then. In any case, if SVGO is the problem, then there's nothing I could do from the perspective of svg-sprite.

That looks to be the case.  I wonder if 0.6.1 release of svgo that they cut two days ago fixes this.

Well, bumping the SVGO dependency in svg-sprite's package.json and updating your modules will tell you. If so, I'd happily push out an updated release for you.

Disabling SVGO fixed the issue, so that's settled.  0.6.1 yielded the same error, so looks like we're stuck waiting on a fix on their end.
Thanks for your help @jkphl .  Much appreciated.  I will let you know if I make any further progress on resolving this.

You're very welcome. Maybe you could take the time and file an issue at SVGO's end, providing your offending SVG as an example‽ Also, please consider digging into SVGO's plugin configuration as disabling a single one of them could well solve your problem. There are some rather aggressive plugins that tend to make trouble with particular SVGs. Good luck (and happy spriting)!


Margin on top (89.1)

Describe the bug:

Hello
First, thanks for the great work !
I just upgrade to 89.1, and I get this margin on top (look at screenshot)
Config YAML:

    - type: 'custom:compact-custom-header'
       main_config: true
       # disable: true
       menu: overflow
       notifications: overflow
       voice: hide
       options: overflow
       clock_format: 24
       exceptions:
         - conditions:
             user_agent: Windows
           config:
             disable: true
         - conditions:
             user: Marion
           config:
             hide_tabs: 5

HA and/or Browser Error:

no error
HA, Card, and Browser Versions:

HA : 89.1

Does this happen on every view or just one?

on every view

Does this happen on default, windows exception, and Marion exception as well?

It happen on default and Marion.  Windows is ok.
Thanks.

I try to remove Windows exception and on PC it's ok. the css issues is on my phones (2 android)

Please try the latest version of the card as it might fix your issue, report back here and let me know. Thanks!

I install the last version, clear the cache, but get the same issue :(

Can you disable CCH by commenting it out in your resources section and see if the problem persists? That way we can be sure CCH is causing it.

yes :

the margin is exactly the same size of the original header.

1.0.1b6 is ok ! I was on 1.0.1b5 , after update it's ok !
Thank you


RDM6300 configuration bug

Version
???
Branch
future/main
OS
Raspberry pi os 32 lite bookworm
Pi model
Raspberry pi 4
Hardware
RDM6300
What happened?
when I try to install using the following command cd; bash <(wget -qO- https://raw.githubusercontent.com/MiczFlor/RPi-Jukebox-RFID/future3/main/installation/install-jukebox.sh) when i get to the option to Executing shell support commands by executing setup.inc.sh (i.e. configure system settings)... Auto-configure system settings? [Y/n]  and I click Yes it just get stuck ive done this like a thounsand times now :(

any help would be greatly apreciated.
Logs
I had to ctrl c the app because it just get stuck on the blue Would you like a login shell to be accessible over serial? screen
INSTALL-1729544895.log
Configuration
No response
More info
No response

Looks like there's again a behavior change with bookworm.
We need to change the disabling of the serial access, see https://github.com/raspberrypi/bookworm-feedback/issues/114#issuecomment-1776113246
Needs to be changed here https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/f2a1730a8df693350aef14aa6df6f563ffe6f786/src/jukebox/components/rfid/hardware/rdm6300_serial/setup.inc.sh#L6
We probably need to check, if we need to keep the current command for older OS versions or if this is backwards compatible.

Thank you for looking into this issue :)

Has been fixed in #2450


correct thread-safety in several classes

Work in progress 👀 and I will rebase later
Fixes #520

Ready for review.  All the work on this PR is in the first commit "fix isClosed...".
The other two allow for successful test runs. I opened separate PRs for these. So depending on the order in which you review or merge...I can rebase again or the merge with automatically drop duplicate commits.

Please wait before merge. I've rebased to remove the two commits that are already separate PRs. And I see the STYLE ci didn't pass. I'd like to run that step locally and see if I can fix them (or if it is something beyond my changes).
I'll force push soon.

force-pushed. I only removed the two commits in other PRs. No other changes.
Ready for your review and hopefully merge.
The style CI fail is happening on code that I didn't write.
I ran clang-format on just the lines in this PR and I didn't get any reports of formatting issues.

Style issue comes from shared code - updating now with also other branches in & style fix
LGTM - if ready, will merge

I have no more code or known changes to add to this PR.


Feature Interaction (Select, Hover) Not Working in Chrome 89

Describe the bug
This problem seems to have come up in a recent Chrome update. Hovering or selecting a feature on my map does not work well in Chrome. Either the mouse location is wrong or the hover is very slow. I tried this in both Windows 10 and Mac OS X Big Sur and the problem is worse in Windows 10. I thought maybe it was my code, but I checked the OpenLayers examples and these also do not work for me:
https://openlayers.org/en/latest/examples/select-hover-features.html
https://openlayers.org/en/latest/examples/select-features.html
https://openlayers.org/en/latest/examples/select-multiple-features.html
On Mac OS X Big Sur Chrome 89 the rendering is slow once I have hundreds of features but at least I am still able to select features correctly. On Windows 10 Chrome 89, I click on a feature but it doesn't work, sometimes I click someplace that isn't a feature and a feature some place else becomes selected. The above examples and my own code work perfectly fine without slow rendering of features in Firefox on both operating systems. I tried shutting down Chrome and restarting it but this did not fix the issue.
My code is using openlayers 5.1.2 and based on the package info on the examples above, those examples are using 6.5.0.
To Reproduce
Steps to reproduce the behavior:

Go to any of the above links using a Windows 10 desktop/laptop computer and Chrome 89.
Try to hover or select a feature on the examples
For multiple features select, it selects many features at once instead of just one at a time; For single feature select it selects the wrong ones; For hover it does not hover over the correct features

Expected behavior
I expect to be able to select or hover over the feature that my mouse is hovering above.

I rebooted Windows and it's working now. Really weird. Sorry everyone!


Ceramic content updates are failing

Describe the bug
Name and Content Link updates are failing to process during claims and edits. This is happening on both the staging env and prod.
Dev Console Errors:
POST https://g12-a-ceramic.3boxlabs.com/api/v0/streams 500
95-31d57f0cb938be90.js:1 Uncaught (in promise) Error: HTTP request to 'https://g12-a-ceramic.3boxlabs.com/api/v0/streams' failed with status '': {"error":"Can not verify signature for commit bagcqceramrtsnh6i4dcht72x6xmqvod267p5h5vwagwanpzqkqp57jy5fg2a: Signature does not belong to issuer"}
at Ae (95-31d57f0cb938be90.js:1:1684229)
at async Ie.createFromGenesis (95-31d57f0cb938be90.js:1:1685504)
at async ht.createStreamFromGenesis (95-31d57f0cb938be90.js:1:1696713)

We are going to be switching to our own mainnet node soon. Let's see if that fixes it before trying anything else.

We are going to be switching to our own mainnet node soon. Let's see if that fixes it before trying anything else.

That's good by me. I'll stand-by for testing.

This has been fixed by subsequent changes.


EnableFastFirstSignIn - Pre-configured candidate local accounts

Pre-configured candidate local accounts are any local accounts (pre-configured or added) in your device.
Hi there, I think this needs additional clarification.
What if the machine has multiple user profiles? How do we pre-configured a profile for this purpose?

@Siva-Github you don't need to pre-configure profiles. That's being done in the background when enabling this feature.
More details here
"When the FastSignIn feature is enabled, Windows creates a “candidate profile” in advance. Once the user has successfully authenticated during the sign-in process, the account is connected to the pre-created candidate profile, which results in a time savings."

Hi VLG17, I don't think it answers the question.
no details on what a candidate profile is and how to customize it ahead of time.


📱🔧 Jasonette

Current Status

Codebase in progress: anishkny/realworld-jasonette

Interested in helping out? Say hello! 🎉 gitter.im/realworld-jasonette/Lobby

Todo:

[x] 🏁 Fork the starter repo & post the link in this issue
[ ] 🎨 Create logo for repo & update issue status (@ericsimons)
[ ] 🔨 Implement all of Conduit's functionality per the spec & API
[ ] 👀 Move repo to main org & Peer review final codebase by admins/community (RFC)
[ ] 🎉 Tag v1 release and officially list it on the README!

Background:
Jasonette is a radical new way to develop native Android/iOS apps using just JSON... yes you heard me right!
The entire app is specified by a single JSON object, served over HTTP, which is then hydrated on the fly for a native mobile experience.
It would be cool to see RealWorld implemented using Jasonette!
Perhaps @gliechtenstein would be up for the task?

Hello we are currently moving all work in progress to Github Discussions.
I'll close this issue by now, you can find instruction to open a discussion there : https://github.com/gothinkster/realworld/discussions/633
Thanks for your contribution !


Store expanded sequences

Tickets addressed: Closes #829.
Review: By commit
Merge strategy: Merge (no squash)

Description
This PR adds a new table that we use to store expanded sequences per expansion run. In order to generate the sequence we need an activity linked to a sequence ID, so there are some prior steps required before we generate and save the sequence.

Create a plan
Add activities
Simulate the plan
Add an expansion set
Define a sequence
Link an activity to that sequence
Run the expansion (this is when we save the expanded sequences)

Verification
Ran existing tests and added a new one to check if the expanded sequence was stored.
Documentation
NA
Future work
Future UI work to show the stored expanded sequences and let the user select which one they'd like to view.

@goetzrrGit We have a new requirement to save all sequences with each expansion run. This is so users can browse past runs and the sequences that were generated.

Looks great Cody, I have a question about the workflow. I am not sure If we had a meeting that I missed or was out on leave.
The proposed coded change will make every expansion run generate a sequence. From my mission planning experience on MSL, if the planning team needs to iterate over the plan multiple times, it might not be necessary to save sequences that are not going to be used. This approach could help conserve computational and database resources.
Therefore, I think we shouldn't make this a 2 operation process. Keep the /expand-all-activity-instances endpoint the same, and use the /bulk-get-seqjson-for-seqid-and-simulation-dataset to generate the sequence and save it. This way, if the planning team needs to make changes to a subset of activities, fix errors in expansion, or modify how an activity is expanded, they can do so without generating unnecessary sequences that will not be used. Once the team is satisfied with the changes made to the plan, the sequences can be generated as needed.

I think this is more a process / design question for Chris? The original ticket was specifically to save the expanded sequences for every expansion run. It takes a series of actions that won't always be fulfilled when the user clicks the expand button, so there are cases where the user can still expand and not generate + save the expanded sequences.


On HOrizon; can't get my log to show anything

Hello. On HOrizonXI and I can't get my log to show any damage or reports. it will show me some of the debuffs but not damage.

nevermind I am an issue!


OAuth for QuickBooks Online

Is it possible to get a token from QBO, since they require to pass in a callback URL?
[https://developer.intuit.com/docs/0100_accounting/0060_authentication_and_authorization/connect_from_within_your_app]

Hi @favishG some of the authenticators use callback urls, but determining how to use them has been on a case-by-case basis.
For example, for TodoistAuthenticator, the following was determined:

For the redirect url, any valid url seems to work (as only the querystring is used in authentication)
e.g. www.example.com, www.yourcompany.com, etc.
The redirect url must match the value set in the "App Management Console"

This was possible since the redirect is detected before it actually occurs so it's ok if it goes to a 404.
I would look into the TodoistAuthenticator approach since it should be applicable here. Please reopen this issue if you into any issues.


max number of records returnable from prometheus

What did you do?
Team, I have major issue on grafana dashboard which is increasing step size by itself resulting in substantial loss of data.
https://github.com/grafana/grafana/issues/34775
As per https://github.com/grafana/grafana/issues/34775 this is defect due to limitation of Prometheus where prometheus is making limit of 11K records.
Whereas I see no limitation of records in Prometheus documentation.
What did you expect to see?
No limitation of records. It should be limit of infrastructure or a configuration parameter configurable by adminsitartors.
What did you see instead? Under which circumstances?
https://github.com/grafana/grafana/issues/34775
Environment

System information:
insert output of uname -srm here

Prometheus version:
insert output of prometheus --version here

Alertmanager version:
insert output of alertmanager --version here (if relevant to the issue)

Prometheus configuration file:

insert configuration here

Alertmanager configuration file:

insert configuration here (if relevant to the issue)

Logs:

insert Prometheus and Alertmanager logs relevant to the issue here

Thanks for your interest in Prometheus and Grafana. This was extensively discussed in the linked grafana issue. I am going to close this on the Prometheus side.


Error when writing destination doesn't have extension

First of all, thank you very much for creating maintaining VIPS ❤
I noticed that if I try to write a Vips::Image to a path which doesn't have an extension, ruby-vips throws an error
require "vips"
require "tempfile"

vips_image = Vips::Image.new_from_file("test/fixtures/portrait.jpg")
vips_image.write_to_file(Tempfile.new.path)

No known saver for '/var/folders/k7/6zx6dx6x7ys3rv3srh0nyfj00000gn/T/20180311-51784-139sd50'. (Vips::Error)

I presume this is because ruby-vips doesn't know in which format should the file be saved. Could ruby-vips in this case perhaps save the result in the same format as the input file?

That's right, write_to_file picks the saver from the file extension.
You can pick a particular saver yourself, for example:
vips_image.jpegsave Tempfile.new.path

Would that solve your problem?

@jcupitt Well, the thing is that I don't know which type the input file is (JPEG, PNG etc), I'm writing generic logic for all common image types.
I was wondering if ruby-vips possibly already knows which type of file it is (I'm assuming it has to, in order to be able to know on new_from_file whether to call jpegload, pngload etc.), then perhaps ruby-vips could automatically choose the correct saver in case the destination path doesn't have an extension.
Or is there some VIPS function to tell which type the file is?

Hello again @janko-m,
It records the thing that originally loaded the file, so you could pick a saver from that:
john@kiwi:~$ cd pics
john@kiwi:~/pics$ irb
irb(main):001:0> require 'vips'
=> true
irb(main):002:0> a = Vips::Image.new_from_file "k2.jpg"
=> #<Image 1450x2048 uchar, 3 bands, srgb>
irb(main):003:0> a.get "vips-loader"
=> "jpegload"

But that won't always help. GIFs, for example, can be loaded by gifload or magickload, depending on how your libvips has been configured, and an SVG file doesn't really have a saver once it has been rasterized. A Q90 JPG won't look the same as a Q50 JPG. What if someone uploads an interlaced PNG? You wouldn't want to save that as an interlaced PNG, it would cause severe performance problems.
I think if you want to copy a file, you should probably use the system copy function. If you want to resize (for example), then I'd just always use JPG.

But that won't always help. GIFs, for example, can be loaded by gifload or magickload, depending on how your libvips has been configured, and an SVG file doesn't really have a saver once it has been rasterized. A Q90 JPG won't look the same as a Q50 JPG. What if someone uploads an interlaced PNG? You wouldn't want to save that as an interlaced PNG, it would cause severe performance problems.

Thanks for the explanation, that makes sense 👍

If you want to resize (for example), then I'd just always use JPG.

Ok, choosing JPEG as the default format when the file type is not known is a good option 👍. Thanks for your input!


Update releasing guide

This is WIP as I am going through release steps. Submitting few ideas.
List:

NDK is actually needed in the first step for the e2e scripts to run.

Thanks @grabbou!
@facebook-github-bot shipit

Not sure if fb bot will handle re-opened case, but just leaving it here as I added few other changes to be reviewed :)

Better create a new pr
On Monday, 18 April 2016, Mike Grabowski<EMAIL_ADDRESS>wrote:

Reopened #7038 https://github.com/facebook/react-native/pull/7038.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/pull/7038#event-631794441

@grabbou The PR has been merged, can you create a new PR with the remaining changes please?

Yep :)


Errors running sgt_constructor.py, Error in rule raxml

Using a fresh install of conda and the provided database I am encountering an error when running sgt_constructor.
The error log file of the run is attached. However the logs in raxml folder which link to these errors are blank
2022-10-09T151112.057541.snakemake.log
For some other genes, there are warnings for identical sequences.
The script then terminates without any tree, BMGE, RAxML folders.
I've tried to re-run the script but it gives the same results.

@pyongheng can you please provide details on the machine you are running this on?

The log file is attached, it is empty.
DRG2.log
log files with text are mostly like this
H2A.log
Yes, I am using version 1.2.0. I had to find it in the mamba installer logs.
Is there a quicker way to find it?
Machine specs are
macOS Monterey
version 12.2.1
MacBook Pro M1 2020
Chip Apple M1
Conda installed is the normal version not M1, following previous instruction

There are no folders with BMGE logs or outputs.


Reduce Route memory utilization by avoiding absl::optional overhead.

Reduce Route memory utilization by avoiding absl::optional overhead.
std::duration values wrapped in an absl::optional take twice as much memory as the durations themseves -- 16 bytes for each optional milliseconds value. This PR removes the optional overhead by using a sentinel -1 value to represent lack of the duration.
There are 6 optional durations on each Route, and 2 more in RetryPolicy, so this is saving 64 bytes per route.
This is a step towards more memory efficient config data structures. Issue #24154.
Signed-off-by: Yury Kats<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/wait

heh, it didn't like the comment! ERROR: ./source/common/router/config_impl.h:347: Don't use std::optional; use absl::optional instead

/retest

Great idea Greg. I think (Yury is going to kill me for scope creep) this might be a very good pattern to generalize like OptInt<IntegerType, SentinelValue>. I almost might expect abs::optional or std::optional to provide this as a specialization except the API doesn't provide an (obvious) way to specify what the sentinel is.

/wait-any

This has been done before, there are libraries out there that do just that, eg https://github.com/Sedeniono/tiny-optional. What's the Envoy's policy of using something like that?

Oh that's nice. Can we take the integer version of that and not bring in the part that relies on undefined behavior? That might be a problem for flows where use UBSAN. It might be annoying to disallow the case without a sentinel.
There is a process for adding new deps but I don't recall the details. @yanavlasov any thoughts?

I would not go the route of platform specific tricks. We have to consider ARM platforms and UBSAN builds. This may be more trouble than it is worth. I would just make dedicated optional_duration which encapsulates the sentinel value and use that.

/wait

I agree, that a more generic sentinel-based optional, a-la tiny_optional, would be helpful in general. I may get back to that, but for these optional timeouts I went a slightly different route -- https://github.com/envoyproxy/envoy/pull/24659 -- which allows to avoid even more overhead if none of them are present.


Make it possible to specify unwanted dependencies (/loosen the version)

These may be linters, coverage or dependencies that are not yet packaged in Fedora.
There may be versions we don't want to have strictly pinned.
There should be a way to remove them from the source code.

FWIW the fact that %pyproject_buildrequires does not have this ability is (a controversial) worldview of the authors. The idea is that the tool exists solely to transform metadata from upstream to a form that RPM understands. If the metadata is not applicable, it needs to be patched (or sedded), as we do with code. This is basically a "metadata as code" approach. We don't do %autosetup -p1 -X replace_something_in_the_code and we don't do %pyproject_buildrequires -X remove_unwanted_dependnecy_foo.

In that case, I don't see any way to solve this (i.e. generate sed invocations or patches to edit the metadata) in a clean, buildsystem agnostic way. I guess this just isn't something pyp2spec should get into, unless there's some other solution that I'm missing.

I guess this just isn't something pyp2spec should get into...

:+1:


Enable net size check when running with run-cu

Is your feature request related to a problem? Please describe.
We disabled the check_net_size compilation pass so that it wouldn't trigger when running things with the C runtime. But now, if a net ends up being too large for hvm-cu, it'll fail at runtime.
Describe the solution you'd like
We should enable check_net_size when the CLI command is run-cu.
We should also enable it when the command is run-c but with a different max net size (atm: 64 for hvm-cu, 4095 for hvm-c).
This max net size should probably be a cli option as well, but that's not necessary for now.

"We disabled the check_net_size

What i am assuming that you made check_net_size default to false. ? it that correct. And for enabling it should be true?

Yes, that's correct.
The actual maximum value depends on the runtime you're targetting, so we disabled it to avoid false positives.

@developedby
When enabling it and setting 4095 for run-c 2 tests are failing, one of which is net_size_too_large.bend - with the diagnostics message, I think the failing is the green condition here, since it should fail on large net size case.
?

@developedby When enabling it and setting 4095 for run-c 2 tests are failing, one of which is net_size_too_large.bend - with the diagnostics message, I think the failing is the green condition here, since it should fail on large net size case.
?

Yeah, this test checks that the error is properly thrown by the compiler. Probably the function it creates is not large enough to cause an error in the C runtime, so we'd need to change it to something larger.
A way to create a very large function that can't be broken up is
def too_large(x):
  return x(
    x, x, x, x, x, x, x, x, x, x,
    x, x, x, x, x, x, x, x, x, x,
    x, x, x, x, x, x, x, x, x, x,
    x, x, x, x, x, x, x, x, x, x,
    ... as large as you want it to be
    x, x, x, x, x, x, x, x, x, x)

@developedby can you check.


[wip] add authentication header

[wip] add authentication header

@exabrial Could you clarify the reasoning behind this feature, plus documentation on how to use it? Thank you.

@jgallimore @exabrial I've enhanced the PR with:

Separate properties to send in the Basic Auth credentials. This will allow to use a different set for credentials for the Basic Auth and Principal.
Friendly error message with Exception if the Basic Auth fails.
Additional test cases.

@jgallimore @exabrial I do have a question:
When using the Basic Auth without the Security Principal, what should be the value of SessionContext.getCallerPrincipal()? At the moment, it returns the Basic Auth login value. It seems the EJB context gets a Principal from this authentication, when want we were trying to achieve was only the Basic Auth. I'm not sure if this Principal should propagate to the EJB context.

Proposed documentation:
https://gist.github.com/radcortez/fb040e83761638ab40d8a19d06b8bfc3

I've pushed the documentation into my own git repo. Here is a PR:
https://github.com/radcortez/tomee-site/pull/1
Probably easier to review this way. Also easy to generate a patch.


Missing mangle option in documentation

For both the compressor and mangler there are separate keep_fnames options.
https://github.com/mishoo/UglifyJS2/issues/552#issuecomment-68931039
In README for Uglifier there is keep_fnames in compress section, but there is no in mangle section.

Thanks! Added that to documentation and also the global keep_fnames that implies both compress and mangle option.


monero-cli: update submodule version; disable aarch64-darwin

This is a backport of c2ec2109937999bdcefd7d68c27974a731144f74 from master to release-24.05

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am closing this request in favor of the backport release-24.05 label on the original PR (https://github.com/NixOS/nixpkgs/pull/341980). If that doesn't work like I expect, then I'll reopen this.


Spartan AntiCheat

In regards to:
https://wiki.geysermc.org/geyser/anticheat-compatibility/
Bedrock support is provided in the original purchase of Spartan since 4th of January 2023.  Would appreciate if you could correct its description and move it to the "Full Compatibility" list.

https://github.com/GeyserMC/GeyserWiki/blob/master/_docs/geyser/anticheat-compatibility.md
Feel free to submit a PR with the changes you'd want to make, I've linked the page above

Thanks. There you go:
https://github.com/GeyserMC/GeyserWiki/compare/master...Vagdedes:GeyserWiki:patch-1

That's a commit to your own fork, could you open a PR from your fork to the Geyser-Wiki repo now? That would allow us to actually merge it after review :-)


Stackdriver Logging

Note the diff is larger than the actual change - that's because I moved the existing stackdriver.go from //adapter/stackdriver/stackdriver.go to //adapter/stackdriver/metric/metric.go, and repurposed //adapter/stackdriver/stackdriver.go into a facade over the various mesh function implementations.
A bit more testing needs to happen in this PR, but the main logic is fine to start reviewing. Note that part of the changes here are actually due to https://github.com/istio/mixer/pull/1146 which this PR is branched off of.
Release note:

NONE

This change is

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
dcad7b06710ba54cad2ce06c7d1424e8bd1c6fc0
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
826dfbb3b71ababab5d993963af5154671fccce7
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
b9484c704607040ce98d3ba1acd711c7a867dedc
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
d9f2414a26d0933d04cdb233c8182db2b984aa0f
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
e2ecf19a3a0762048c14f7b5b7107472ba3dbaed
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
33d5e8a29e15e81d8e490f22317431d51efb1a56
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-e2e-smoketest.sh
0d11ff7b0eab4f92a13ab6fdeacc7b0c24710f69
link
/test mixer-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Tests pass on Doug's cluster and mine:
$ ./tests/e2e.sh --mixer_hub=gcr.io/google.com/zbutcher-test --mixer_tag=pr-1161
<snip>
Tests Summary
PASSED: //tests/e2e/tests/mixer:go_default_test
PASSED: //tests/e2e/tests/bookinfo:go_default_test


Writing to protected branches produces a lakefs.ForbiddenException instead of a PermissionError

What happened?
We have an exception translator that translates lakefs API exceptions to builtin Python exceptions to ensure conformity of our fsspec implementation.
I just tried streaming JSON data directly into lakeFS for our nnbench project with a command like this:
nnbench .sandbox/example.py -o "lakefs://quickstart/test/res.json"

Details are not as important, it just calls fs.open() under the hood and passes the resulting file descriptor off to json.dump(). When attempting to write that file in a fresh lakeFS quickstart repo like above, I get the following exception:

Traceback (most recent call last):
  File "/Users/nicholasjunge/Workspaces/python/nnbench/.venv/bin/nnbench", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/nicholasjunge/Workspaces/python/nnbench/src/nnbench/cli.py", line 64, in main
    f.write(record, outfile)
  File "/Users/nicholasjunge/Workspaces/python/nnbench/src/nnbench/reporter/file.py", line 288, in write
    with fd as fp:
  File "/Users/nicholasjunge/Workspaces/python/nnbench/.venv/lib/python3.11/site-packages/lakefs/object.py", line 162, in __exit__
    self.close()
  File "/Users/nicholasjunge/Workspaces/python/nnbench/.venv/lib/python3.11/site-packages/lakefs/object.py", line 487, in close
    stats = self._upload_presign() if self.pre_sign else self._upload_raw()
                                                         ^^^^^^^^^^^^^^^^^^
  File "/Users/nicholasjunge/Workspaces/python/nnbench/.venv/lib/python3.11/site-packages/lakefs/object.py", line 540, in _upload_raw
    handle_http_error(resp)
  File "/Users/nicholasjunge/Workspaces/python/nnbench/.venv/lib/python3.11/site-packages/lakefs/exceptions.py", line 159, in handle_http_error
    raise lakefs_ex
lakefs.exceptions.ForbiddenException: code: 403, reason: Forbidden, body: {'message': 'cannot write to protected branch'}

So it seems that we're missing a raise translate_lakefs_error() somewhere in LakeFSFileSystem.open().
What did you expect to happen?
I expected something like PermissionError: cannot write to protected branch 'main', but the branch name would probably be sugar on top in our exception facility. There have been a few instances where I wanted more detail from lakeFS exceptions, but some (or all) of it is just the scarcity of info you get from the server.
lakeFS-spec version
0.11.0
lakeFS version
1.42.0

This might be a little harder than I thought - we're just handing off the lakefs.ObjectReader (or Writer) to the user, and that is what produces the error in its .close() method when trying to send the buffer to the server.
Since the user voluntarily takes ownership of these object readers and writers when using them outside of a context manager (or even within? I don't see error translating anywhere here tbh), there might not be a lot we can do here, since we're not "within" our file system anymore.


feat(typography): refactor text styles

Refactor text styles
:hammer_and_wrench: Type Of Change

[ ] Fix
[x] Feature
[ ] Performance Improvement
[ ] Refactor

:book: Jira Ticket

DLT-1610: Refactor Design Tokens
DLT-1611: Implement refactored Design Tokens in Dialtone CSS

:book: Description

Updating naming convention of text style classes, while still supporting previous ones (temporarily at least until they've been replaced in product).

Added a few new variants

In dialtone-tokens via Tokens Studio. Previewable in this Figma branch text-styles-refactor.
In dialtone-css
In dialtone-documentation/docs/_data/type.json
Applied updates in dialtone-vue2 and dialtone-vue3.
Generated Type Styles in Figma Library branch (above Figma link, not part of this PR).

Added a bit more doc'ing on Design Language > Typography

:pencil: Checklist
For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[ ] I have reviewed my changes.
[x] I have added all relevant documentation.
[x] I have considered the performance impact of my change.

For all Vue changes:

[ ] I have added / updated unit tests.
[x] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script.
[ ] I have validated components with a screen reader.
[ ] I have validated components keyboard navigation.

For all CSS changes:

[x] I have used design tokens whenever possible.
[x] I have considered how this change will behave on different screen sizes.
[x] I have visually validated my change in light and dark mode.
[x] I have used gap or flexbox properties for layout instead of margin whenever possible.

:crystal_ball: Next Steps
DLT-1613: Implement refactored text styles in product codebase

This may seem like a large PR, but that's only because of a flurry of search-and-replace. The main updated updates will be called out below...

Alright we should be good then

@braddialpad,

...when updated in product...

My understanding is that a Dialtone engineer will directly update the dialtone dependency, right? So when this specific version number is applied, it would be prudent to ensure that they validate.

Please validate it looks okay if it starts working again.

Awesome! Thanks for reconciling. I'll give it a look and ensure all is good.

...We'll have to put out a communication about this and publish the mapping table on there.

I've logged DLT-1624 which I'll have Yorbi do. Feel free to give that a look and add any detail you feel the description is missing.

Looks like github is back to normal and the latest preview has the changes