NET_ADMIN capabilities

Hello,
I am just thinking of a need to have "cap_add: - NET_ADMIN" capabilities for this container. I am not a docker or linux developer, so maybe this is a must :) If this can somehow be removed, your container can be used in future for services that does not require higher privileges.  Then together with the GPU passthrough (I know, hard to achieve :)) it should be great for GPU rental services such as vast.ai or runpod.io.
I know that this might be a difficult path to achieve but a huge milestone in providing unprivileged container that can be used across many cloud services too :)
Thanks

@kroese doens't seems harmless. Second this stack exchange thread: https://unix.stackexchange.com/questions/508809/docker-running-an-app-with-net-admin-capability-involved-risks, the container could escalate access and gain root access on the host.


Build failure: snapper-0.11.1

Steps To Reproduce
Steps to reproduce the behavior:

build snapper-0.11.1

Build log
> checking for chsnap... /sbin/chsnap
> checking for cp... /nix/store/cnknp3yxfibxjhila0sjd1v3yglqssng-coreutils-9.5/bin/cp
> checking for touch... /nix/store/cnknp3yxfibxjhila0sjd1v3yglqssng-coreutils-9.5/bin/touch
> checking for rm... /nix/store/cnknp3yxfibxjhila0sjd1v3yglqssng-coreutils-9.5/bin/rm
> checking for diff... /nix/store/fy6s9lk05yjl1cz2dl8gs0sjrd6h9w5f-diffutils-3.10/bin/diff
> checking for chattr... /usr/bin/chattr
> checking for lvcreate... /sbin/lvcreate
> checking for lvremove... /sbin/lvremove
> checking for lvs... /sbin/lvs
> checking for lvchange... /sbin/lvchange
> checking for lvm... /sbin/lvm
> checking for lvrename... /sbin/lvrename
> checking for btrfs_read_and_process_send_stream in -lbtrfs... yes
> checking for btrfs/version.h... yes
> checking for libmount/libmount.h... yes
> checking pkg-config is at least version 0.9.0... yes
> checking for dbus-1... yes
> checking for libxml-2.0... yes
> checking for json-c... yes
> checking for zlib... no
> configure: error: Package requirements (zlib) were not met:
>
> No package 'zlib' found
>
> Consider adjusting the PKG_CONFIG_PATH environment variable if you
> installed software in a non-standard prefix.
>
> Alternatively, you may set the environment variables ZLIB_CFLAGS
> and ZLIB_LIBS to avoid the need to call pkg-config.

Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
- host os: `Linux 6.9.8-zen1, NixOS, 24.11 (Vicuna), 24.11.20240727.b73c222`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.23.3`
- nixpkgs: `/nix/store/qxf6anli54ij0q1sdlnlgx9hyl658a4v-source`

Add a :+1: reaction to issues you find important.

#331120


support destination

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yibo.fyb seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Class level decoding

Hello,
is it possible to have an option to decode the USB stream to Class level like Total Phase Beagle 480?
It is nice to see the datastream, but most time I need to look on class level. So I can directly see what is going on.

In the long run, decoding class-specific requests and data structures is possible and I'd consider it in scope for the project.
There are some small things already done, e.g. if you look at the request for a HID report descriptor, the detail pane will show the structure of the report.
But to do this sort of work across all classes is a huge job, because of how many classes there are and how many different data formats are used in each of them. I've not personally used Total Phase's products, but I'm sure that they must have put a great deal of work into that feature of their software.
I think that the best solution is probably not for us to write Rust code for all classes directly, but to use some kind of definition language in which the data formats used by each class can be expressed more succinctly, and which Packetry can load, interpret and use at runtime. That would make it a lot faster to translate each class specification into a form that Packetry can work with, and would enable more people to contribute to that effort.
If we can find a sufficiently intuitive way to do this, then users would also be able to use that same approach to describe the data formats used by vendor-specific devices, which would be a great feature to have too.


An .electronignore file ?

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Writing too much in --ignore option is annoying, how about taking an .electronignore file?
Just like .gitignore, .npmignore, .eslintignore, etc.
electron-packager app --ignore \"(yarn\\.lock|package-lock\\.json|__test__|\\.map|src\\/web)$\"

Ref: https://github.com/electron-userland/electron-packager/blob/master/docs/faq.md#why-isnt-my-ignore-option-working
Btw, I can't make ignoring package-lock.json work.

There was an attempt at an electronignore file in https://github.com/electron-userland/electron-packager/pull/376 but I was not a fan of it. I said that I would rather see a way to specify all config options in the package.json. Now I'm hesitant to do that because it adds a lot of complexity for a small percentage of users. I would instead suggest that people either use Electron Forge (which has that feature, and why I know how much work it is to do that correctly), or that someone write a thin wrapper around Electron Packager's API. If someone does end up doing that, they should take inspiration from how Electron Forge does it, because you'd also have to remove the config from the copied package.json for security purposes.
Regarding your problem, instead of a bunch of |s, I would either just have multiple --ignore params, or run a script that uses the Packager API instead of invoking the Packager CLI.

@malept thanks for your time, great answer!


screen reader support

none of the buttons get read out
you have to refresh the screen reader (stop & play again) to hear the current prompt

i don't actually know how to fix this yet but i didn't know javascript when i started this project so. I think i can figure it out.

"lineart" gets read out by my screen reader as "linn ee art"

buttons can probably be fixed by switching them from "button" type to "a" type, but we will have to see if that breaks the whole app

turns out i think that my screen reader extension i was using just kinda sucks it doesn't even read labels which are explicitly meant to be read out by screen readers hglskdfjs. so this might not be as much of an issue as i initially thought? i kind of. don't know. but i'll try switching the buttons to a elements anyway

Switching the buttons to "a" elements makes the page not button-navigatable, so it appears that's just. a bad move. given that the issue screen-reader wise is almost certainly my browser extension screen reader just not working well, i'll close this issue


Call .toJSON() of populated objects.

When calling toJSON() on mongoose objects, toObject() is called on populated objects. This pull request fixes this and correctly call toJSON() instead.

i have the fix for #412 local. just need to push with some other fixes.
what is this fixing? is there a bug here somewhere? can you include a test?

Please look at this example: https://gist.github.com/1589265
Without the fix, it outputs:
{ title: 'Test',
  _creator:
   { name: 'Jerem',
     age: 42,
     _id: 4f0c46607d68db4d67000001 },
  _id: 4f0c46617d68db4d67000002,
  was_in_to_json: true }

As you can see, toJSON is only called for the root object which is wrong, it should also be called for the nested object.
But with the fix, toJSON is also called for populated objects - which is the correct behavior. Bellow is the output with the fix applied:
{ title: 'Test',
  _creator:
   { name: 'Jerem',
     age: 42,
     _id: 4f0c46373095bc4a67000001,
     was_in_to_json: true },
  _id: 4f0c46383095bc4a67000002,
  was_in_to_json: true }

gotcha. we'll need to be careful here. isMongooseObject() returns true for Documents, Arrays, and MongooseBuffers; not all of which have a toJSON method. please update this pull to include tests so we know we're ok.

Done!

Any chance to have this merged before the next release? Thanks!

yeah i think this is ok. can you update to latest HEAD so it merges ok?

Here it is!

merged. thanks!

Is this supposed to work for embedded documents as well as DBRef-style linked documents? (It doesn't seem to.)


Feature/inspector

This features is partial, see task tracking in Trello 11-atellier-create-proptypes-fields
Implemented and missing types:

[x] string
[x] number
[x] bool
[ ] oneOf
[ ] array
[ ] component

And should be merged in development to maintain the compatibilitie


FE-200: add support for enterprise & smart graphs in new graphs UI

Scope & Purpose
Adds back support for enterprise & smart graphs

[x] :hankey: Bugfix

Checklist

[x] Tests

[x] Manually tested

[x] :book: CHANGELOG entry made

Related Information
This is related to FE-200, which had disabled smart graph support in the new graph viewer.

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/FE-200

[ ] https://jenkins01.arangodb.biz/job/arangodb-ANY-jslint/28094/


Update deck.gl version in readme

Maybe include update-release-branch script?

Coverage increased (+2.7%) to 82.62% when pulling 374bc5120012b8fe25141a7378a562216c1e2942 on xx/7.3 into 92d875b2197b36f1f86f1024e7598cc8d18c920b on 7.3-release.


Add travis CI for buttshock

Need to make sure things always work against python 2/3

All done. https://travis-ci.org/metafetish/buttshock-py


Add Google Analytics

I have a UA code generated for the domain; we need to put some basic tracking.

This appears to be done. @justinribeiro

@Reshurum


How to use flask debug mode?

When use flask-sockets, start with the sample code
if __name__ == "__main__":
    from gevent import pywsgi
    from geventwebsocket.handler import WebSocketHandler
    server = pywsgi.WSGIServer(('', 5000), app, handler_class=WebSocketHandler)
    server.serve_forever()

The flask debug mode is invalid, can't reload after code change, help me.

I've used something like the following.  It's been awhile since I worked on this, but I believe it allowed me to both auto-reload and get the usual Flask debug trace in a browser.
from gevent import pywsgi
from geventwebsocket.handler import WebSocketHandler

# https://coderwall.com/p/q2mrbw/gevent-with-debug-support-for-flask
from werkzeug.serving import run_with_reloader
from werkzeug.debug import DebuggedApplication

# If using PyCharm enable Gevent debugging support under:
#   Settings->Build, Execution, Deployment->Python Debugger
from gevent import monkey
monkey.patch_all()

def run_server():
    if app.debug:
        application = DebuggedApplication(app)
    else:
        application = app

    server = pywsgi.WSGIServer(('<IP_ADDRESS>', 5000), application,
                               handler_class=WebSocketHandler)
    server.serve_forever()

if __name__ == "__main__":
    run_with_reloader(run_server)

@gmyers18  Thanks, is perfect.


Add unique ID to each observation

Needed if we want everything to be uniquely and easily traceable back to raw data.
Right now using only 16/32 hash characters; haven't seen any collisions yet, but they are possible.
For this to work, data need to be pivoted to long form in L0, not L1_normalize.

Everyone seems to like the idea of using a hash for observation ID, so merging


Optionally run as daemon and log to file

Allow a command that will let the client run in the background and log output to a file.

Using

nohup dataserv-client farm >> logfile &

while its in beta


Non-Active/Non-Selected Query Params not greyed out

Expected Behavior
Prior to the 9.3.0 release the query params that were not active or selected in the list were greyed out. This made for a simple UX in knowing exactly which ones were selected and which were not.
Actual Behavior
Now since 9.3.0 all query params just show the same whether they are selected or not. The only indication is a tiny checkmark. This makes it extremely cumbersome for anyone who might have repeated query params saved that they can turn off and on instead of typing out new values all the time.

Reproduction Steps
Install version 9.3.x and this feature will no longer be available
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
9.3.1
What operating system are you using?
macOS
Operating System Version
Sonoma 14.4.1
Installation method
Homebrew
Last Known Working Insomnia version
9.2.0

I believe this has already been fixed in main by @gatzjames and will be released in 9.3.2 this week.

Insomnia v9.3.2 has been released fixing this issue.


Refactor arm_mpu to use CMSIS directly

Initial PR towards implementing #8018.
This PR refactors the ARM MPU implementation to use the CMSIS macro definitions directly.

Codecov Report

Merging #8457 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8457   +/-   ##
=======================================
  Coverage   64.61%   64.61%
=======================================
  Files         421      421
  Lines       40296    40296
  Branches     6803     6803
=======================================
  Hits        26037    26037
  Misses      11126    11126
  Partials     3133     3133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6245d6c...6902599. Read the comment docs.

CI is failing because the beetle doesn't have CMSIS headers. You might be able to fix by defining __MPU_PRESENT for that SoC, but I vaguely remember Vincenzo having some issues with that macro when he originally introduced MPU support into Zephyr.

@MaureenHelm I added a commit to explicitly define the ARM MPU related macros for Beetle. It looks it is the only arm SOC that does not include CMSIS headers, so this is a straightforward workaround, IMO.


Advanced settings not persisting

Go to settings > advanced, turn on hide balance header, click done...it shows back up.

Same root-cause as #5974?

Don't think so, they don't even seem to trigger a settings set if we're saving them to the wallet.

This is because arriving on settings page triggers sync pull....

Duplicate
Closing in favor of #6363 split settings into separate subareas with navigation.  "Advanced Settings" will go away, and there will be no double pull.


Added timeframe property to allow finer-grained search. Modified URL and newURL accordingly

Been playing with google search url and thought this could be super useful.
Source: http://www.webdistortion.com/2012/02/19/need-a-more-realtime-google-search-try-this-hack/
Gist:
add 'tbs=qdr:value' to instruct google search to return results in timeframe corresponding to 'value'.
Also did quick update of README since it was right there.

Got it, handsome. Woot.


Story: Large Data Support / Incremental Summaries / Automatic Chunk Reuse (WIP)

M2.1 : Large Data Support / Incremental Summaries / Automatic Chunk Reuse
This story provides execution details on Epic: Large Data Support / M2 / Automatic chunk reuse strategy
Introduction
The goal of current work item is to reduce the size of periodic summary uploads by reusing portions of previous summaries for unchanged data. The proposed strategy is to identify and de-duplicate data redundancies on the client-side using DDS agnostic techniques such content-based slicing using a rolling hash.
This area is actively researched in the academia and in the industry, traditionally relevant for differential backup, data reduction and redundancy de-duplication software. More recently similar techniques are used for modeling the persistence of distributed database systems.
Scoping Down
Multiple algorithm choices satisfy the incremental summary use-case. However, based on the industry adoption, recent academic research and available libraries for reuse, narrowing down the scope of investigation to Gear fingerprint, ie. FastCDC and Cyclic polynomial, ie. Buzhash

Buzhash - has widest adoption for backup software, eg. Borg, Asuran,  Casync, Probabilistic B-Trees, etc.

FastCDC - fastest to date, Asuran, Rdedup, etc.

Wasm
Content defined chunking, just by the nature of computing and evaluating hashes byte-by-byte are CPU and data intensive. To address this concern most of the reviewed solutions are implemented in natively compiled languages (eg. C, Go, Rust). This aspect challenges Fluid's web / javascript -centric philosophy. The current thoughts are to isolate the chunking process in a web assembly reusable module. The module would ideally be created as a wrapper on existing open-source cdc libraries. During the investigation phase it is favorable to combine together multiple algorithms in a single module, however not ideal for production software which should minimize the loaded code size to the opted-in features.
Evaluation Library
This repository is used to generate the CDC wasm library.
Wasm library for content-based slicing. Convenience wrapper on existing rolling hash implementations in rust, such as provided by fastcdc, asuran chunker, etc.
Usage NodeJS
npm install @dstanesc/wasm-chunking-node-eval

import {compute_chunks_buzhash, compute_chunks_fastcdc} from "@dstanesc/wasm-chunking-node-eval";

Usage Webpack
npm install @dstanesc/wasm-chunking-webpack-eval

import {compute_chunks_buzhash, compute_chunks_fastcdc} from "@dstanesc/wasm-chunking-webpack-eval";

API
const buf = ...
// mask 0b11111111111111
const offsets_buz = compute_chunks_buzhash(buf, 15).values();
// chunk sizes: min 16 KiB, avg 32 KiB, max 64 KiB
const offsets_fast = compute_chunks_fastcdc(buf, 16384, 32768, 65536).values();

Benchmarks
Performance Results

FastCDC constantly stands out for relative performance, roughly 10x faster than Buzhash.
Also good absolute performance, chunking roughly  0.5 MiB / ms in my local Firefox env.

More details at chunking speed benchmark page.
Stability Results
The good

Both FastCDC and Buzhash display a remarkable reuse behavior on json and serialized (msgpack encoded) data.
One surprising insight is that LZ4 compression is also preserving a very good reusability rate, almost equivalent with the json and serialized data.
Sparse modifications (see bottom charts) applied to json, msgpack and LZ4 data formats also manifest very good reusability

The bad

CDC on the LZ77+Huffman compression format (ie. Pako) shows NO ability to reuse blocks
Base64 encoding also collapses the reusability rate

More details at the chunking stability benchmark page
Elected Chunking Algorithm
After the evaluation phase, FastCDC stability and speed appears to be the closest match for content-defined chunking needs for summarization. Created a dedicated library for rust based wasm generation. Relies on the leading Rust implementation for the FastCDC
Purpose built library for Fluid usage is wasm-chunking-fastcdc
Modularization Strategy
Introduce a standalone @fluid-experimental/content-chunking Fluid component.

The module will be evaluated first in the context of PropertyDDS. This activity should require minimal changes.
Same module can be used to experiment w/ content-defined chunking in larger context
The module can be used to experiment w/ content-defined chunking combined w/ LZ4 compression (appealing, considering on the above stability benchmarking results)

Usage:
const buffer=...
const chunkingConfig: ChunkingConfig = { avgChunkSize: 64 * 1024, chunkingStrategy: ChunkingStrategy.ContentDefined };
const contentChunker: IContentChunker = createChunkingMethod(chunkingConfig);
const chunks: Uint8Array[] = contentChunker.computeChunks(buffer);

Note: there are two chunking strategies proposed at this stage, the new ChunkingStrategy.ContentDefined and ChunkingStrategy.FixedSize for backward compatibility

POC
A PropertyDDS based application and a convenience library is used to analyze the functional feasibility and the API evolution needs
The SharedPropertyTree changes are minimal but configuration needs (eg for chunk size and chunking strategy) stand out.
Chunk Deduplication
Two IDocumentStorageService implementations relevant in the blob/chunk deduplication discussion:

ShreddedSummaryDocumentStorageService using the SummaryTreeUploadManager to upload the blobs. ShreddedSummaryDocumentStorageService is used in the context of Tinylicious relay. Notably, it looks to already provide chunk deduplication ie. only uploads the necessary blobs - which is - not referenced by the prior summary snapshot
WholeSummaryDocumentStorageService using the  WholeSummaryUploadManager to upload the blobs. WholeSummaryDocumentStorageService is used in context of Routerlicious and inherently FRS but lacks the ability to deduplicate chunks

@DLehenbauer @noencke  @milanro @vladsud, initial thoughts on using CDC to achieve incremental summaries. To evolve.

This a great summary.  Thank you for opening this issue!

FYI. Created and published first draft of the cdc wasm module. See above details.

@DLehenbauer @vladsud, @justus-camp, @milanro FYI. Updated the Benchmarks section w/ the finding summary and links to the speed and stability benchmark repos, incl results

@DLehenbauer @vladsud @milanro Updated the initial comment above with notes about current status, concrete library for chunking and POC bits for review. See Elected Chunking Algorithm, Modularization Strategy,  POC and Chunk Deduplication paragraphs.  At this stage few feedback and help topics stand out:

Feature Configuration.
A. The app and/or feature rollout ability to switch between the content-defined and fixed-size chunking.  fixed-size chunking is current behavior and needs preserved as default.
B. Chunk (average) size is important for chunking stability tuning. Domain specific most of the time.
The solution strategy we adopted for configuring compressed trees (aka derived property tree classes) seems not the most appropriate vehicle for configuring chunking.

WholeSummary -- Blob Deduplication Instrumentation Priority. My review indicates that the ShreddedSummary and its helping stack already have the ability to deduplicate summary blobs. Technically IMHO ShreddedSummary represents the superior way forward. The question remains whether borrowing the dedup pattern for the WholeSummary stack is still a desirable investment.

Building Service & Client Side. The relevant upload managers shredded summary and whole summary are colocated in the 2nd build. Would be extremely useful in case we (as open source developers) could access more information on:
A. What are the prerequisites to build the server. In my case manual build fails, err log attached. Docker build succeeds but won't deliver libraries
B. How to build together client and server/routerlicious/packages/services-client so that build results are usable for development (testing, debugging)

Note: In my current context the classes get pulled indirectly (ie webpack://@fluid-experimental/shared-property-map-hello/../../../../node_modules/@fluidframework/routerlicious-driver/node_modules/@fluidframework/server-services-client/lib/summaryTreeUploadManager.js), even if directly referenced in client's package.json. I believe another variable is  the hoisting outcome which favors older versions because version inconsistencies in main (eg. 0.1038.1000 vs 0.1038.2000)

Is the team supporting the proposed modularization strategy?  See @fluid-experimental/content-chunking](https://github.com/dstanesc/FluidFramework/tree/pdds-summary-chunking-poc/experimental/framework/content-chunking)

Actual chunking is performed in wasm. We created an external library to be used by @fluid-experimental/content-chunking. Unlike the evaluation libs which are chunkier -- pun intended -- and also suffer from particular licensing drawbacks, the new library targets solely the winning algorithm (see chunking speed and stability benchmarks). It is written in rust. It is part of my open source contribution.

Blob deduplication evidence. I was working around the inability to regenerate shredded summary uploader by directly modifying the .js files nested under root node_modules (ie. webpack://@fluid-experimental/shared-property-map-hello/../../../../node_modules/<EMAIL_ADDRESS>) to analyze the current behavior.
A.  Below the results when adding 0.05 MB of data to a preexistent summary of 1.2 MB, classic SharePropertyTree (no compression) configured w/ the avgChunkSize: 48KB. The hello app is using synthetic material data for triggering the incremental summary behavior
B. Deserves mentioned that after some inactivity all blobs need published (no reuse)  which likely relate to the history pruning in PropertyDDS but other factors may play a role as well. Still open investigation.

 Still open investigation.

Appears to me that the actual reason resides in the blobsShaCache lifecycle and looks more like a bug. The cache becomes empty after a period of idleness. While called a cache, actually represents in my view a convenient projection/transformation/index on the previous summary snapshot helping with blob existence query cases. I think a construct associating the ISnapshotTree tree with the set of hashes for the blob leaves, evtl. encapsulated by the already existing ISnapshotTreeEx would allow better lifecycle correlation between the summary snapshot and its corresponding blobs hash set. Any other thoughts?

Wow.  This is really amazing work!

For configuration, I think you'll want to add to IContainerRuntimeOptions similar to what @justus-camp did for op compression.

For a POC, I think it's up to you if it's easier to start with the shredded or whole document summarizer and add CDC.  Longer-term, I think your work might converge the two?  (i.e., you could perhaps configure the you're summarizer to produce as many or few chunks as desired, including a whole document summary?)

I wasn't unable to resolve this, but I'll have another look tomorrow when I'm at my desktop.  As a starting point, did you install the node-gpy dependencies listed in the Dockerfile?

Could you explain a bit more?  Are you asking about separating the CDC implementation into its own small module?

Nice!

I have a hypothesis.  I'll ask some questions and get back to you soon.

@DLehenbauer @milanro
Thank you Daniel!
Few quick thoughts:

For configuration, I think you'll want to add to IContainerRuntimeOptions similar to what @justus-camp did for op compression.

My assessment finds 2 missing links for the goal at hand:
A. The place we want to instrument now is in propertyTree#summarizeCore which seems unreachable by the current propagation of IContainerRuntimeOptions or derived. The closest layer to receive ISummarizeOptions (relevant fragment of the IContainerRuntimeOptions) stays the runtime and is the SummaryGenerator#summarizeCore component which won't propagate it further to the DDS itself
B. Could not find a way to provide IContainerRuntimeOptions when instantiating a container via the AzureClient (this is how HxGN Nexus uses fluid today). If I understand correctly the limit seems to be in the AzureClient and its provider for the runtime factory which creates its own runtime options
This state of affairs looks rather blocking for the feature unless some work is done for both A. and B. Is this a package we should consider taking in our group?

... As a starting point, did you install the node-gpy dependencies listed in the Dockerfile?

Thanks for the hint. Yes, dependencies seemed to be alright but will revisit

Could you explain a bit more? Are you asking about separating the CDC implementation into its own small module?

Indeed. This separation seems appropriate to me especially by flagging it experimental but wanted to know your opinion about it.

I'm sorry, I misunderstood your question about 1.  Was the problem with the derived classes that the matrix of options is getting too big (i.e., too many subclasses required?)
FYI - I did successfully build '/server/routerlicious' on Ubuntu (WSL) by:
sudo apt update
sudo apt install -y python3 make git curl g++ openssl libssl-dev ca-certificates
cd server/routerlicious
npm i
npm run build

Were you doing the same?
Regarding 4, we mostly use 'experimental' for things that have a risk of customer confusion and/or temporarily need special exemptions from our linting/testing policies (e.g., bulk code imports).  I don't think your work necessarily needs to be in experimental, but it's fine to put it there if it's convenient.
Regarding 6, we should loop in @znewton when he is back in office next week.

FYI - I did successfully build '/server/routerlicious' on Ubuntu

Yes I did the same and now fails during the npm i phase w/ the attached err. Interesting enough I recall also having it working in the more remote past. I can only blame the kernel upgrades (also ubuntu version -- now 22.04 for this machine) I did since then. The strech-slim used by Docker seems antique (ie. kernel 4.9 compared to mine 5.15.0 ). This alone can justify header files to diverge. The other option I am trying without much success for now is to build selectively as I really need only the routerlicious/packages/services-client in this exercise. Otherwise the solution would be to downgrade somehow my environment or virtualize it.

I'm sorry, I misunderstood your question about 1. Was the problem with the derived classes that the matrix of options is getting too big (i.e., too many subclasses required?)

Yes this is the case, and the options I see listed above

One Fluid build problem seems to be the strict dependency to openssl 1.1.1. The openssl version in Ubuntu 22.04 is 3.0. Documenting the fix if needed by anyone else:
Check your current version
dpkg -l | grep libssl-dev

Update to opento 1.1.1 if different
wget http://security.ubuntu.com/ubuntu/pool/main/o/openssl/openssl_1.1.1f-1ubuntu2.16_amd64.deb
wget http://security.ubuntu.com/ubuntu/pool/main/o/openssl/libssl-dev_1.1.1f-1ubuntu2.16_amd64.deb
sudo dpkg -i libssl-dev_1.1.1f-1ubuntu2.16_amd64.deb
sudo dpkg -i openssl_1.1.1f-1ubuntu2.16_amd64.deb

Next section works:
npm run clean
git clean -xfd
npm install
npm run build:fast -- --nolint --install
cd server/routerlicious
npm i
npm run build

Incremental fluid-build, symlink within monorepo works.
alias fb='clear && node "$(git rev-parse --show-toplevel)/node_modules/.bin/fluid-build"'
fb --install --symlink
fb @fluid-experimental/property-inspector

Incremental fluid-build, symlink across monorepos fails. This is relevant as I need to change the @fluidframework/server-services-client ( pulled via @fluidframework/azure-client and the @fluidframework/routerlicious-driver in my poc)
Unclear whether I am doing smth wrong or needs reported as a bug.
alias fb='clear && node "$(git rev-parse --show-toplevel)/node_modules/.bin/fluid-build"'
fb --install --symlink:full
fb --all @fluid-experimental/property-inspector

Symlink in full mode
ERROR: Unexpected error. @fluidframework/build-tools: tsc not found for project reference
Error: @fluidframework/build-tools: tsc not found for project reference
    at TscTask.addDependentTasks (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/leaf/tscTask.js:88:23)
    at TscTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/leaf/leafTask.js:76:14)
    at NPMTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/npmTask.js:20:18)
    at NPMTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/npmTask.js:20:18)
    at NPMTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/npmTask.js:20:18)
    at ConcurrentNPMTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/npmTask.js:20:18)
    at NPMTask.initializeDependentTask (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/tasks/npmTask.js:20:18)
    at /home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/buildGraph.js:271:27
    at Map.forEach (<anonymous>)
    at BuildGraph.filterPackagesAndInitializeTasks (/home/dstanesc/code/FluidFramework.Debug/build-tools/packages/build-tools/dist/fluidBuild/buildGraph.js:263:28)

@dstanesc, @milanro - I made some progress on the build failures reported above (see #12400).
They turned out to be unrelated to synchronizing the client/server monorepos (i.e., they repro without 'symlink:full'.)

@dstanesc, @milanro - I was able to build --symlink:full w/the above fix yesterday, with the caveat that it fails our type validation tests.  The type validation tests are generated *.ts files that mix the use of Fluid types from the current source and the previously published packages in order to catch unintentional build breaks.
You can identify the type validation test failures by the path of the compilation error, but it's annoying.  Using fb --all --script tsc will build only the commonjs module (no tests), which might be an acceptable workaround.
Although I wasn't sure if your plans were to continue building deduping at the driver level, or if you were going to try implementing deduping as a layer above the driver, in which case I think you'd avoid the hassles of --symlink:full?

Although I wasn't sure if your plans were to continue building deduping at the driver level, or if you were going to try implementing deduping as a layer above the driver, in which case I think you'd avoid the hassles of --symlink:full?

Thank you! Still investigating the possibilities for the WholeSummary. However, strongly inclined to follow your suggestion and lift the implementation above the driver. That should reduce the hassle as you mentioned.
FYI. Not sure you have seen it, meanwhile I sent a pull request for the experimental chunking module  alone.

@DLehenbauer @vladsud @milanro
Just created a draft pull request for the deduplication, localized above the driver, in the runtime.
Please take a look at your convenience. Looking for your feedback before polishing the implementation and sending an official pull request.

@DLehenbauer  @vladsud  Created a merge-able PR - 12699 isolating only the relevant changes for the deduplication feature for review convenience. Looks like the repo-policy-check still needs attention from a Fluid maintainer to run the workflow, apparently still first time contributor status.

This PR looks interesting, I wonder why it wasn't merged into the master branch.


Release/0.0.1 rc3

Codecov Report

Merging #41 (726cd38) into master (9e0965c) will decrease coverage by 0.20%.
The diff coverage is 95.21%.

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
- Coverage     96.70%   96.49%   -0.21%
- Complexity      372      437      +65
============================================
  Files            12       18       +6
  Lines           910     1085     +175
============================================
+ Hits            880     1047     +167
- Misses           30       38       +8

Impacted Files
Coverage Δ

src/QueryBuilder/Raw.php
81.81% <0.00%> (-18.19%)
:arrow_down:

src/JSON/JsonExpressionFactory.php
64.28% <64.28%> (ø)

src/QueryBuilder/WPDBAdapter.php
94.85% <75.00%> (+0.07%)
:arrow_up:

src/JSON/JsonSelectorHandler.php
95.00% <95.00%> (ø)

src/QueryBuilder/QueryBuilderHandler.php
96.51% <97.36%> (+0.15%)
:arrow_up:

src/QueryBuilder/JsonQueryBuilder.php
98.38% <98.38%> (ø)

src/JSON/JsonHandler.php
100.00% <100.00%> (ø)

src/JSON/JsonSelector.php
100.00% <100.00%> (ø)

src/QueryBuilder/TablePrefixer.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0965c...726cd38. Read the comment docs.


Num/Caps lock backspace issue

I have noticed that while in the *lock modes you cannot send the backspace through.

Odd. That is not the case for me.
If I press caps lock (f xxxx) or number lock (n xxxx) then type some
letters or numbers, I can press backspace (f -x--) and it works as expected
deleting the char. and staying in the locked mode.
What behavior are you experiencing?
-Greg
On Mar 30, 2016 10:58 AM, "HyrulianHero"<EMAIL_ADDRESS>wrote:

I have noticed that while in the *lock modes you cannot send the backspace
through.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/clc/chorder/issues/2

Oh! I apologize, it was the Enter/Return key!
Sorry my mind thought one thing and my fingers typed another.

Again, I am not seeing that issue.  Pressing far thumb and pinky together
gives [ENTER] key in both caps lock and num lock mode.  I don't know why
that would not work for you.
So, if I understand you, [ENTER] works as expected when typing text, but if
you have entered cap-lock (far thumb and all 4 fingers) or num-lock (near
thumb and all four fingers) it does not work.  When you leave caps-lock or
num-lock it returns to working?  Is that correct? If not please tell me how
I have miss-understood.
Please connect your chorder over the usb cable to the host with arduino ide
on it.  Open the serial monitor so you can see the serial output from the
FeatherChorder as it runs.  Connect the FeatherChorder over BLE to your
device.  Now when you type you should see what the FeatherChorder is trying
to send.  When you press the "F-- ---P" you should see in the serial
monitor window:
AT+BLEKEYBOARDCODE=0-00-28
AT+BLEKEYBOARDCODE=00-00
If you do, then your chorder is trying to do the right thing and the issue
may be on the receiving end.  If you see something else, let me know what
it is. If you do see the above lines in the monitor window,  please try
pariing with a different BT host.  It may be some configuration on the
device you are connecting with.
Other thoughts:
Have you made any modifications to the default ChordMappings.h?  If you
have, please try flashing your feather with the default files and see if it
does work.  In fact, it might be a good thing to just reflash anyway, and
see if that changes anything.
Any chance there is a wiring issue?  (the Monitor window may also give you
help figuring that out as well.
Does [ENTER] work if directly preceded by shift (Far thumb alone) or
num-shift (near thumb alone)?
For me, I get the desired result (an [ENTER] keypress) in plain text, if
preceded by num-shift or shift or both, when in caps-lock, num-lock or
both.
The only place "F-- ---P" is not mapped to "ENUMKEY_enter" is in the
function key mapping.
Please let me know what you figure out.
Greg
On Apr 12, 2016 12:06 AM, "HyrulianHero"<EMAIL_ADDRESS>wrote:

Oh! I apologize, it was the Enter/Return key!
Sorry my mind thought one thing and my fingers typed another.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/clc/chorder/issues/2#issuecomment-208741681

3rd time is the charm, okay so it wasn't [ENTER] or [BACKSPACE],
It was the [DELETE] "F-- -MR-" all along! It only occurs when the caps lock is active.
I feel a little silly for not tracking this down more efficiently. Sorry about all of that unnecessary work you did, but I do very much appreciate the troubleshooting tips that you graciously replied with.

I am sorry you are having problems, but
I am not able to reproduce your issue(s).
Were you able to connect your featherchorder to a different device to see
if it was device specific?
Were you able to look at the serial monitor?
If your problems persist, please include serial monitor output (as
suggested in my last message) and annotate it with some comments about what
you were pressing when.  Also, how about a closeup  picture of your
feather?  Given your ongoing issues, I would like to visually confirm your
wiring.
But before that, just to be sure, please grab a copy of the latest version
of the FeatherChorder and reflash your feather.
Again, if you can give me more to work with I will revisit your issue,
-Greg
On Apr 12, 2016 9:37 PM, "HyrulianHero"<EMAIL_ADDRESS>wrote:

3rd time is the charm, okay so it wasn't [ENTER] or [BACKSPACE],
It was the [DELETE] "F-- -MR-" all along! It only occurs when the caps
lock is active.
I feel a little silly for not tracking this down more efficiently. Sorry
about all of that unnecessary work you did, but I do very much appreciate
the troubleshooting tips that you graciously replied with.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/clc/chorder/issues/2#issuecomment-209224237

This turned out to be the incompetent ramblings of a novice. It sends the delete through text just needs to be selected first. I'll close this issue and learn how to use the serial monitor.
Thanks again for all your time and energy! keep up the good work!


Handle cosmosdb table API requests

This change allows azure-sdk-for-go to send the requests to
cosmosdb table API. It exposes a new method as AddAdditionalHeaders
which allows users to specify cosmosdb specific headers.
This change allows users to use azure-sdk-for-go to connect to and use
cosmosdb table storage.

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Can one of the admins verify this patch?

@ArcturusZhang can you please release this package in the next minor update?


Investigate why Codacy and CodeCoverage ratings are so low

We know both tools test code's performance, style and correctness, but we need to know why are they so low. CodeCoverage is all about checking how many lines of code are being used during tests, so when we get to test the web services, we can improve that.
Database testing can be done properly without the web service, so get on that.
Some of the problems Codacy has are either:

Unused imports I can't find on code that I don't think is different from master
Some JavaScript stuff Bootstrap seems to be doing wrong and I'm not sure how to fix that
In any case, most are easy to solve

So Codacy is still reporting complaints about GetParticipantInfoImpl, a class we mixed with UpdateParticipantInfoImpl (I think that was the name) to provide a single façade.
CodeCoverage is also wondering why the line coverage in the package "hello" is so low (I can assure you, that package is long gone)
So I suggest using the HTML provided by mvn site to get readings on code coverage and proficiency till we figure out why the repository under analysis according to those two sites is in another time-line

Codacy is now keeping up with the repo more or less, and we now know how to use both tools.
CodeCoverage is still on no man's land, though it's now using a commit from 2 days ago, it still has the wrong package structure and code.
Let's keep using Maven and we'll sort them out later on


search filter and sort not working on nested objects?

Hi,
I have a datagrid with some nested objects to populate the textfields (e.g. client.name), but it seems the search filter isn't working on these. User error, design, or bug? Same goes for sorting btw.
Thanks

Hi,
If I try adding a filter on a nested field in the blog example:
const CommentFilter = ({ ...props }) => (
    <Filter {...props}>
        <TextInput source="author.name" />
    </Filter>
);

Then typing the string "foobar" in the author search box issues the following REST request:

GET_LIST comments {"filter":{"author":{"name":"logan"}},"pagination":{"page":"1","perPage":"6"},"sort":{"field":"id","order":"DESC"}}

This seems perfectly fine to me. Now it's up to your REST client to transform that into something your API can understand.
As for the sorting, if I add a nested field in my datagrid:
export const CommentList = ({ ...props }) => (
    <List {...props}>
        <Datagrid>
            <TextField source="author.name" />
        </Datagrid>
    </List>
);

Then clicking on the author name column header does issue a proper REST query for the nested field:

GET_LIST comments {"sort":{"field":"author.name","order":"ASC"},"pagination":{"page":"1","perPage":"6"},"filter":{}}

Once again, it's up to your restClient to turn that into something your API can understand.


False positive on library affinity-3.1.1.jar - reported as cpe:/a:thread_project:thread:3.1.1

False positive on library affinity-3.1.1.jar - reported as cpe:/a:thread_project:thread:3.1.1
<dependency>
   <groupId>net.openhft</groupId>
   <artifactId>affinity</artifactId>
   <version>3.1.1</version>
</dependency>

I'm wondering how ODC comes up with this CPE, as I don't find any evidence for vendor "thread_project" or product "thread" in the evicence list (except for the fact that "thread" is part of some product evidence, like the description "Java Thread Affinity library" in the pom.) I'd appreciate any insight into this to better understand how ODC works.
Thanks a lot!

ODC has a Lucene index of all CPEs of the NIST NVD that is consulted for all the found product- and vendor evidences. The result(s) that Lucene returns are validated to ensure that they 'sufficiently' match a dependency (all words of the Lucene result are contained in at least one of the corresponding evidence values). Some stop-words are ignored in this evaluation, such as project.
So yes, the 'Thread' part in the pom name is in the end what triggers this false (LOW confidence) association with the CPE of   thread_project:thread.
See also its implementation at
https://github.com/jeremylong/DependencyCheck/blob/main/core/src/main/java/org/owasp/dependencycheck/dependency/naming/CpeIdentifier.java


Feature request: separate backups for dual SIM phones

Highly useful to have a possibility of setting up different IMAP folders (or even accounts) for backup calls and sms came from different SIM cards or SIP accounts.

This appears to be a duplicate of #598 which is requesting substantially the same features.


Amendment-detail fix change recommendation

Current behaviour:
In Amendment-detail view (you need an amendment which changes more than one line)

[ ] A. If a change recommendation is added then the original version of the motion is displayed, not the Diff Version anymore.
[ ] B. If the change recommendation is deleted then you need to reload the page to see the change recommendation anymore
[ ] B.1. If a change recommendation is added, the whole motion text can't be activated with the checkbox "Show entire motion text". By clicking it an error appears in the console. Error message "Cannot read properties of null (reading 'offsetTop')"
[x] C. If an amendment changes several lines and has one change request then the line numbers are not correctly displayed
[x] D. If an amendment has a change recommendation then the option "show entire motion text" vanishes

Descriptions changed because Case C and D are resolved and A/B needed a rework.
Reproduction:
In a meeting:

create a motion with several lines/paragraphs (I recommend 7 lines)
create an amendment which changes several (but not all) lines in the motion
add a change recommendation to the amendment
3.1. hover around the beginning of the sentence (a bit more to the left) until you find a blue cross-icon
3.2. press the icon
3.3. change something in the sentence and save (hint: doesn't matter, if it is a part of the change recommendation or the regular text.)
( Case A) ) now the original version of the amendment is active, not the Diff Version (compare: in a motion the Diff Version is active after adding a change recommendation.)
(Case B) Original version must be active.-  Open the console. Now activate the checkbox "Show entire motion text". An Error message appears in the console. The entire motion is not displayed. -> Reload the page to switch back to a working version.
(Case B.1) Delete the change recommendation. -> CR stays active and visible. By deleting it twice, a correct error message appears.
reload the page -> the change recommedantion is gone

Wanted behaviour:

[ ] A. - After adding a change recommendation to an amendment, the Diff Version should be visible. It should follow the same logic like adding an amendment to a motion. Please check, if this is connected to the function "Default text version for change recommendations and projections of motions".
[ ] B.1 - the change recommendation should vanish after deletion without reload
[ ] B. - activated checkbox "Show entire motion text" should show whole motion text
[x] the displayed lines should be correct even if there is a change request
[x] the optiojjn to display the whole text should always be available

Case D) only happens if the Diff Version is selected. @emanuelschuetze @MSoeb is this a feature?
If it is, ignore D)

Case C is solved #2970

Case D) is wanted behaviour

Re-Tested and rewrited the issue:

Case A: Edit to reflect the occuring problem
Case B: Still occurs. Also found another problem which is strongly connected to it. Integrated it in the issue in B.1

I looked into Case A: I can reproduce a failure there. In the os-motion-highlight-form the function determineCrMode
doesn't work in this case. It sets the cr mode to original in a if clause, which shouldn't happen. The hasChangeRecommendation property returns a false, but it should return a true.  I need more time to debug this.

Add some fixes. I debugged here a lot, but there are still some issues here. I stop working on this.
Case A and part of B1 should be fixed.

Re-Test:
Case A) still occurs
Case B) CR deletion -> still occurs
Case B.1) can't reproduce it. seems to work correctly

Very likely to be resolved after #4023 is finished.


Add some YUV image tooling

Cropping
Format conversion
Scaling

images in general
colour plane to different subsampling ratios

Refactored the yuv player.
Added format conversion and basic cropping.
Added comparison utilities.

No scaling (except chroma) just yet - we don't really need it.
The tools will evolve and we'll add new issues as they come up.


Architecture

Currently, we have something of an architectural mess.  We need to rebuild this with emphasis on the core traits and concepts.  A simple summary of the library might be:

An incremental parser-combinator library

I think it is more than that, however, as we want to use it for all things incremental --- not just parsers.  However, parsers afford a useful and concrete starting point.  I can also immediately use them in other systems.  Key things we need:

Traits for incremental computation (currently Transformable, PartiallyTransformable, etc)
Traits for describing lexers / parsers.  For example, nom has the top-level trait Parser<I,O,E>
A small library of useful incremental combinators (e.g. which could be used in external tools)

I think the naming of the incremental traits is not that consistent with Rust's naming.

Top level traits:

(functional) Transformer and PartialTransformer.
(imperative) Transformable and PartialTransformable.
Incremental .  Described as similar to the Into trait?

Maybe should have IncrementalInto then?

Strategy:

[ ] Strip back to minimum (remove Incremental and various unused implementations)
[ ] Rename existing traits.
[ ] Add traits for parsing.
[ ] Add minimal implementations (e.g. Diff for Vec, etc).


Access All Listeners within a Plugin

Summary
Being able to see all of the listeners within a plugin would be nice, so when wanting to get the function names or event types that the listeners subscribed to, you can do so for whatever reason necessary.
Why is this needed?
Just like above, developers can access which event listeners are loaded into a plugin. and what their hooked functions are.
Ideal implementation
def load(client:lightbulb.BotApp) -> None:
    client.add_plugin(plugin)

    for event in plugin.all_listeners:
        ... # Do something with the event

Checklist

[X] I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.

Why specifically do you need the listeners registered to the specific plugin? You can already get all the listeners registered with the bot for a specific event by using GatewayBot.get_listeners(event_type)

I would like to implement my own custom even subscribed log.
When I load all of a plugin's listeners, I would like to have all of the function names, etc. be available for developers to see so they can track when events are listened to and what functions are linked to them without hard-coding it.

subclass the bot and override the subscribe method which is used to register listeners

Sounds good


If only one annotation server is chosen, background sends undefined storage selected

When configuring products, if only browserstorage is selected , background.js does not respond with selected annotation server, what makes contentscript error and not starting.

This is solved but not automatically closed after commit...


Grpc service

depends on #43

Codecov Report

Merging #46 (2d93a07) into master (0fa5c1b) will increase coverage by 0.20%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   76.56%   76.76%   +0.20%
==========================================
  Files           7        7
  Lines         542      551       +9
==========================================
+ Hits          415      423       +8
- Misses         68       69       +1
  Partials       59       59

Impacted Files
Coverage Δ

ipam.go
75.00% <0.00%> (-25.00%)
:arrow_down:

postgres.go
70.00% <ø> (ø)

storage.go
50.00% <ø> (ø)

memory.go
94.59% <100.00%> (+0.30%)
:arrow_up:

prefix.go
78.01% <100.00%> (+0.31%)
:arrow_up:

sql.go
70.00% <100.00%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa5c1b...2d93a07. Read the comment docs.

@majst01 any idea to get this merged?

Needs some love, we are currently using it as library, probably will have time to polish in the next time

closing in favour of #82

@ekarlso grpc is now merged and available since v1.10.0


Key not found: Type - File processing is skipped

Sample to reproduce the issue
package main

type Phone struct {
	 phone string
  phonetype string
}
type Person struct {
  phone []Phone
  name string
}

func main() {
 var fphone = []Phone{{phone: "1234567890", phonetype: "Home"},{phone: "1234567890", phonetype: "Home"}}
	var person = Person{fphone, "Person name"}
}

Pull Request: https://github.com/joernio/joern/pull/3658


PDF size issue

I am also facing the same size issue with different cases.
1st generated PDF without adding any image -  PDF size 355 Kb.
Then again generate pdf by adding one image (122 kb - compressed image) -  PDF size 1.5 Mb
Then again generate pdf by adding same size 5 images (122 kb - compressed image) -  PDF size 8 Mb.
Please reduce the pdf size issue. When pdf contains 12-15 images that size reach at 30 Mb it's so big size for document.
Thanks

#35 is a different issue, it generates different sizes for same data in different devices.
I am closing this issue, will investigate this issue with issue #35.


Debug option?

I just tried it and it seems to be great but I clicked the buttons on my localhost and I guess it saved the cookies and I can't get the banner back to debug / design it (without wiping out the cookies every time).
It's great that it's so small but I still wish for a debug feature. Maybe something like this?
<div id="cookies-eu-banner" style="display: none;" data-debug="true">

With the debug, the bar always comes back after refresh.
It's not been updated in a while. Do you still consider it an active repo?

Do you still consider it an active repo?

Agree! Simplicity wins! ☺

Just wanted to let you know. One of the biggest advantages with your solution is the size. I also wrote about it here (before I switched to yours):
https://github.com/insites/cookieconsent/issues/154

3.5kb is almost nothing but having a js of more than 17kb just to display a cookie message is quite much, I think.

Cookies-EU-banner is a 2.35kb plugin of vanilla JS :)
https://github.com/Alex-D/Cookies-EU-banner/blob/c1832d1b19d8cd7de2d47dd75993f8c505bee7b0/dist/cookies-eu-banner.min.js


update the CLA to include GitHub licenses and suggested changes by lawyers

This PR includes an explicit mention of the license under which GitHub granted the right to use and modify their CLA for this repository (CC-BY-4.0).
The text of the CLA is adapted in line with the suggestions by the lawyers, strengthening the section on the source of a contribution.

The suggested changes look good to me.


My jobs are setted to BLOCKED state after executing

Ok, let me explain the situation:

My Scheduler:

Properties prop = new Properties();
prop.setProperty ( "org.quartz.threadPool.class", "org.quartz.simpl.SimpleThreadPool" );
prop.setProperty ( "org.quartz.threadPool.threadCount",    "5" );
prop.setProperty ( "org.quartz.threadPool.threadPriority", "9" );
scheduler = new StdSchedulerFactory ( prop ).getScheduler ( );

I've a job named MyJob. This job is marked with DisallowConcurrentExecution. I'm creating some objects using this class, but different identity each instance.

JobBuilder.newJob(MyJob.class) .withIdentity(id + "&inicio",G_CHANGECONTENT)
Each instance is added to the scheduler with different trigger.
TriggerBuilder.newTrigger( ).withIdentity( "trigger" + id + "&inicio", G_CHANGECONTENT )
id=string variable, different value for first instance and second instance.
For example, object A -> 9AM all days; object B -> 10 AM all days.

My job A is executed at 9 o'clock, perfect.

My job B is executed at 10 o'clock, perfect.

BUT: After this momento,  I add a breakpoint at some point of the code, I inspect the state of each trigger and all two are BLOCKED.

I've a listener class, the method 'jobWasExecuted' is launched for each instance correctly (9:00-10:00).
I don't understand why my triggers are marked as BLOCKED after first execution.

Yeah, it is relevant. I don't understand why the jobs are setted to BLOCKED after first execution, if the job was marked with DisallowConcurrentExecution.


Network issues and Timed out waiting for group information to appear

Hi there.
I've created a simple example to play with cluster mode. I run two nodes in the cluster with manual deployment of verticles. After a successful start I turn off the network from one node for five minues and turn it on after that. The cluster seems to be created again, but LoggingVerticle at the node that was suffered from the network problems doesn't consumes messages anymore. These messages are created with HttpControllerVerticle.
Also, I see a warning in the log file:
io.vertx.core.impl.HAManager WARNING: Timed out waiting for group information to appear
I've attached the log file from the node that was disconnected.
vertx-test-log-39.log
What does the warning mean? I want to get the cluster worked again, but the problem is that I don't know where to start fixing the problem.

Seems related to https://github.com/vert-x3/vertx-hazelcast/issues/90. Upgrade to 3.5.4 and it should fix your issue.

Thank you for advice, I confirm that the problem is fixed.


added x86_64 version of SPSC ring buffer

Initial commit of One-To-One ringbuffer for resume cache and for new type of DuplexConnection for testing.

haven't really looked deeply yet, but one thing we should do is to run devtools/format_all.sh on the change.

@lehecka done

As a rewrite of existing code, with unit tests and not currently actively used.  I'm going to take the finer details on faith.


[Feature] The "context" object should not be part of this package

Describe the solution you'd like
The context object came from the NHS.UK tests which use Behave, but UiTestCore could be used by any other test pack so it doesn't make sense to use this object which is too closely coupled to a particular test pack. This change would require the config_handler to be moved back into the test packs, and any code using "context" would need to be refactored.

Closing this because it is a duplicate of #10


Too many connections!

Hello Bhavik,
Shark is just awesome..  Also shark after the update is just killing it but there one one problem if the victim reloads the page then it shows ‘too many connections’ which is the only issue.. Hope you fix this out soon! And ya we do want a new update next month and I am creating multiple accounts on GitHub for giving stars to shark 🦈..😉

this error is because of the free version of ngrok you can use the VIP version to minimize this error

Bruh just change ngrok that u own  private ngrok.

Bruh just replace ngrok use ur own, paste ur Ngrok to /bin directory.


ci: GitHub Actions JDK 8, 11, 17

Unfortunately, rest assured doesn't compile with Java 17. I think it's an issue with gmaven.


Be explicit about using UTC

Draft PR, because the more I think about this the less confident I am that it's the right thing to do.
This PR makes publishing API be explicit about using UTC when its turning dates into strings.
This is to allow us to be consistent in the timezone in GOV.UK apps - they should all use London, and publishing-api should be consistent with that.
However, now that I've implemented this, I'm not sure it really does make sense for publishing-api to have a London timezone. Because it's not user facing, it's never got a reason to turn a time into a string in the user's timezone. And because it's an API, it usually wants to render times in UTC. If there's never a case where we want to render things in the London timezone, maybe it would be better for us to say "publishing apps and frontends (which have human users) should use London as the timezone, but API-only apps should use UTC". Otherwise there's a bit of a risk of getting it wrong (e.g. doing datetime.iso8601 instead of datetime.utc.iso8601). 🤔  🤔  🤔
If we do want to have some UTC apps and some London apps, it might be that https://github.com/alphagov/govuk_app_config/pull/381 is not such a good idea after all. We could introduce something like config.govuk_time_zone = "UTC" to allow apps to be explicit, but maybe we'd be better off without the weirdness in the gem and just setting London explicitly instead...
Discussion very welcome 😅

On quick glance, it makes sense for the API's to store dates and present dates in a single Timezone, as it simplifies logic around them (and I dunno if we have a use case for needing to preserve Timezone information).
Does the fact that we have users outside the London Timezone make more sense to use UTC for our APIs? For example, if we introduced localised content, then things aren't going to be consistent anyway.

We definitely only want to store things as UTC (but that's already the case everywhere, because active record has its own, separate time zone, which is UTC by default).
When we show users times in publishing apps, they should be in the London timezone (or if we ever get around to handling users in other time zones, like embassy workers in travel advice publisher, in that user's timezone).
When we communicate dates between publishing apps and apis / apis and frontends, it doesn't feel like it's useful to have them in any format other than UTC. It's not really meaningful to say "this was last updated at 2024-06-25T17:40 Cairo time" in an API payload. Much more convenient to have everything in UTC.
So I'm thinking the APIs should all be in UTC, and the apps with UIs should all be in London (and they've got the option to override things to their users' timezones if that's considered worthwhile).

Another alternative which Kevin and I worked out would be to explicitly set the time_zone back to UTC in publishing-api. This is a bit inconvenient, because of the approach I've taken in the govuk_app_config gem, but it's still possible - https://github.com/alphagov/publishing-api/pull/2786

Closing in favour of #2786


Wrong quotes in install instructions

Wrong quotes at the top of README.md:
To enable Flurry Analytics:

  pod ‘Flurry-iOS-SDK/FlurrySDK’

@virl fixed.  Thanks for the head's up.


Integration branch for next lwaftr release with Snabb 2019.06 “Deltadromeus”

This branch so far includes:

Merge of snabbco/snabb:v2019.01 (Snabb 2019.06 “Deltadromeus”)
#1222 (Memory monitor)
#1224 (Support draft-ietf-softwire-yang-16)
#1225 (snabb rrdcat)
https://github.com/snabbco/snabb/pull/1443 (rxdrop counter fixes for 82599)
#1228 (Resource leak fixes for #1221)
#1229 (ingress_drop_monitor: monitor per-queue stats)
#1230 (ptree: do not aggregate symlink counters)
https://github.com/eugeneia/snabb/pull/15 (lwaftr: avoid some unsunk allocations of cdata pointers)

Notably, this switches the lwaftr over to use RaptorJIT, adding extended auditing functionality to the SHM directory:

audit.log is a complete flight recorder for JIT compiler events
vmprofile/ tracks trace execution profiles for performance debugging

@dpino @wingo Ready for review when you are. :-)

Tested locally and appears to work.  Excellent!!


Add neureka support

Ciao Luka,
Great work, the PR is in very good shape, I would not label any of my comments as blocking.
I think it's a good idea to resolve the TODO in neureka/hal/neureka_task.c, but, feel free to resolve my other comments.
It would be good to add a version branch / commit hash for the PULP-SDK / GVSoC versions this was tested with, if possible, maybe in the README? On that note, we know about a bug in the pointwise mode in Siracusa, where only unsigned weights compute correctly. Is this captured in the GVSoC version you are using?


Update Color Scheme on Report Page

Overview
Addresses #123
Updated report page to use colors with higher contrast in light mode and dark mode.
Screenshots

@doomspork I am going to spot check a few report pages with Rocket Validator this evening to ensure that most of the bases are covered and then I'll merge it! 🌔 🌞


implement new parsing into put command

Issue #, if available:
Solve #162
Description of changes:
Introduce pest parsing into put command. This commit adds new features and breaking changes but not limited to,

Support binary types.
Support single quotes for a string type.
Support explicit set types.

However, it no longer supports the inference of set type when using [elem] because we can now specify set type explicitly using <<elem>> literal.
BREKING CHANGE: put command no longer infers a set type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmyoda Thank you for your review. I made fixes based on your comments. Could you check these modifications?


[Event Request] in procedure CheckWarehouse table 39 "Purchase Line"

Could we please have a publisher OnCheckWarehouseOnBeforeShowDialog  in the procedure CheckWarehouse in table 39 "Purchase Line"
table 39 "Purchase Line"
{
...
    local procedure CheckWarehouse()
    var
        Location2: Record Location;
        WhseSetup: Record "Warehouse Setup";
        ShowDialog: Option " ",Message,Error;
        DialogText: Text[50];
        IsHandled: Boolean;
...

        // >>>>>>>>>>>>>>>>>
        OnCheckWarehouseOnBeforeShowDialog(Rec, ShowDialog);
        // <<<<<<<<<<<<<<<<<
        case ShowDialog of
            ShowDialog::Message:
                Message(WhseRequirementMsg, DialogText);
            ShowDialog::Error:
                Error(Text016, DialogText, FieldCaption("Line No."), "Line No.")
        end;

        HandleDedicatedBin(true);
    end;

[IntegrationEvent(false, false)]
local procedure OnCheckWarehouseOnBeforeShowDialog(var PurchaseLine: Record "Purchase Line"; var ShowDialog: Option " ",Message,Error)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add unimplemented methods, doc, fix POST data in some calls

Add a couple unimplemented methods:

list services
get a service
info
grant admin access to user server

Add docstrings everywhere, matching the Hub REST API documentation, and in some cases document types of arguments.
Try to make create_user and create_users work nicely together, which were causing errors in my application. Previously, create_users takes a list of some users object. Seems like this object, from the create_user signature, has keys name and value, and these objects were appended together in a new list. However, current REST API signature for create multiple users takes data:
{
  "usernames": [
    "string"
  ],
  "admin": true
}

So it seems to me that it is more appropriate to pass a list of names, along with the admin flag. This works nicely in tests, but would cause breaking changes for anyone using the existing create_users signature.

Woo, thanks!


Getting the same error can any one help here whats the issue?

Same error. Any solution for this?

Have you found any solution ? please.

I too have this problem.


feature: blacklist/whitelist

Did you check the docs?

[X] I have read all the todo-comments.nvim docs

Is your feature request related to a problem? Please describe.
It would be important to have an option to specify:

A whitelist for cases where we only want to highlight certain filetypes.
A blacklist for cases where we want to ignore a certain filetype.

To make it simple, we could just say that if you specify a blacklist, then the whitelist option is ignored.
Describe the solution you'd like
x
Describe alternatives you've considered
x
Additional context
No response

This can be done already with
highlight = {
  exclude = {}, -- list of file types to exclude highlighting
},


How to document methods inside objects

I have a service that contains a method that returns an object that contains methods:
/**
* @memberof module
* @name myService
* @ngdoc service
*/
function myService(){

 return {
  test: test
}

/**
* @memberof myService
*/
function test(){

/**
* @memberof myService
* @desc This is an obj
* @type {Object}
*/
 var obj = {
  prop1: '',
  testfunc: function (){
    //some stuff
   }
  }
 }
}

How do define a description for testfunc?

You can’t. Actually there’s already a mistake in documenting obj as a member of myService–it’s not.
There’s a way to do something like that, though.
You can document obj explicitly using @ngdoc type:
/**
 * @ngdoc type
 * @name YourObjectName
 * @memberof app
 *
 * @property {string} prop1 You could also document this string property
 * @property {function} testfunc Here you can document the function. :)
 */

Depending on what you want to do with obj, you could use app.YourObjectName as the return type (like @returns {app.YourObjectName} description blah blah) of a function or even declare obj with @type {app.YourObjectName} as opposed to @type {Object} in your example.
I hope this helps. :)

According to JSDOC3 @memberof this should definitely be possible.
Quoting their @memberof basic example:
/** @namespace */
var Tools = {};

/** @memberof Tools */
var hammer = function() {
};

Tools.hammer = hammer;

Also you should be able to achieve this with the use of the @alias and @memberof!  (notice the exclamation point at the end of memberof).
http://usejsdoc.org/tags-memberof.html

Okay, I assumed it was of importance to keep it in the object definition and not use dot notation.


Revert "Delete extra files from the Universe templates"

Reverts dcos/dcos-ui#3650

:tada: This PR is included in version 2.79.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


DiskCache is null within the ImageService object.

Description
DiskCache is null within the ImageService object.
Steps to Reproduce
Attempt to access DiskCache property from ImageService
Expected Behavior
DiskCache is a valid object. Also that await ImageService.InvalidateCacheAsync(FFImageLoading.Cache.CacheType.All); could be called to invalidate both memory and disk cache.
Actual Behavior
DiskCache object is null
Basic Information

Version with issue: 1.10
Last known good version: unknown
Platform: iOS simulator

Reproduction Link / Code
`
private IImageService imageService = Application.Current.MainPage.Handler.MauiContext.Services.GetService<IImageService>();
//...
imageService.InvalidateMemoryCache();   // This works fine
await imageService.DiskCache..ClearAsync();  // This crashes because DiskCache is null
`

DiskCache has not been set yet, I will update the code this week. Thanks for reporting.

Fixed in latest version 1.1.1 https://www.nuget.org/packages/FFImageLoading.Maui/1.1.1


How to integrate angular 2?

Great - now I'd like to use angular 2.0 and asp.net core (vnext). What are the steps?

I had in mind to create a sample with Angular 2.0 and now that is in RC maybe it's a good time. I will try to add one in the coming days


AND/OR option for metadata search

The clonable metadata search fields are internally handled as "AND" search query.
For most setups the majority of metdata items is single valued but the mask accepts to add the same keyword multiple times - some users misinterprete this as "OR"ed search and are disappointed about the empty result.
A pure "OR"ed search might also be insufficient as using different patterns or having multivalued items is possible.

Maybe it should be mentioned in the release notes that there is a backwards incompatible change in the search syntax.


SSD-ResNet34 label mapping is done is finalize()

Unlike SSD-MobileNet, SSD-ResNet34 predicts the index of the label instead of the label itself, so an additional label mapping is needed (called use_inv_map in coco.py). However, currently this additional mapping is done in the finalize() and is not part of the performance timing.
Depending on whether this mapping should be timed, we should either:

Move use_inv_map to __call__()
OR
Add an option to accuracy script accuracy-coco.py to do the mapping in the accuracy script instead.

Added an option to accuracy script accuracy-coco.py to do the mapping in the accuracy script in #395. Closing.


fixed plugins loading

Current coverage is 21.07% (diff: 0.00%)

Merging #357 into master will not change coverage

@@             master       #357   diff @@
==========================================
  Files            20         20
  Lines          1604       1604
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            338        338
  Misses         1266       1266
  Partials          0          0

Powered by Codecov. Last update ebdc882...6207740


Allow passing arguments to render_submit in submit_form

Hello again, I have a component like LiveSelect that uses JavaScript to tickle a hidden input, which provides the Magic™.
I see there was a discussion about the issue in #37 but this seems like a nice thing to have in PhoenixTest itself.
Perhaps we could add an optional fourth argument to submit_form? My workaround thus far has been:
test "creates new work order with valid params", %{session: session} do
  truck = insert(:truck)
  params = params_for(:work_order, truck: truck)

  session =
    session
    |> visit(~p"/service_work_order")
    |> click_link("span.visible a", "New")

  {:ok, view, _} =
    session.view
    |> form("#work-order-form")
    |> render_submit(work_order: params)
    |> follow_redirect(session.conn)

  %PhoenixTest.Live{view: view, conn: session.conn}
  |> assert_has("span", "Truck #{truck.unit_no}")
  |> click_link("a[data-title='Audit']", "Audit")
  |> assert_has("td", "create")
  |> assert_has("td", params.complaint)
end

but breaking in and out of PhoenixTest like this feels naughty.
Here is a POC: https://github.com/dabaer/phoenix_test/commit/f745cfe7a9060575efa2f92ba316910e0949534f
And the much cleaner test 🎊
test "creates new work order with valid params", %{session: session} do
  truck = insert(:truck)
  params = params_for(:work_order, truck: truck)

  session =
    session
    |> visit(~p"/service_work_order")
    |> click_link("span.visible a", "New")
    |> submit_form("#work-order-form", %{}, work_order: params)
    |> assert_has("span", "Truck #{truck.unit_no}")

  session
  |> click_link("a[data-title='Audit']", "Audit")
  |> assert_has("td", "create")
  |> assert_has("td", params.complaint)
end

What do you think? Also, I wasn't quite sure how to go about presenting this to the DeadView side of things (or if it's even needed there), so the option is black-holed for now.

Hi @dabaer thanks for opening this issue.
I'm currently making changes to PhoenixTest so it automatically includes all hidden fields and other defaults (e.g. a default checked radio button).
Would that ☝ solve your issue without you having to break out of PhoenixTest?
If it doesn't, I have been considering how to best offer an escape hatch so you can drop in to LiveView when you want.
My guess for now would be to do something like this:
session
|> visit("/")
|> # ... do other phoenix test things
|> in_live_view(fn view ->
  view
  |> element("#some-hook")
  |> render_hook(%{params_from_js: "hello world"})
end)
|> assert_has(text: "hello world")

I like that since it is a full escape hatch (instead of patching submit_form to take in more params and then having to come up with another solution for things like testing hooks.
What do you think?
In the meantime, the escape hatch you're using is okay. It's technically private API, but I don't know how much it'll change (just be warned in case it breaks at some point in a weird way).
If you keep using that escape hatch, I might do it like this so that you keep more of whatever is in the Session struct:
test "creates new work order with valid params", %{session: session} do
  truck = insert(:truck)
  params = params_for(:work_order, truck: truck)

  session
  |> visit(~p"/service_work_order")
  |> click_link("span.visible a", "New")
  |> then(fn session ->
  {:ok, view, _} =
    session.view
    |> form("#work-order-form")
    |> render_submit(work_order: params)
    |> follow_redirect(session.conn)

    %{ session | view: view}
  end)
  |> assert_has("span", "Truck #{truck.unit_no}")
  |> click_link("a[data-title='Audit']", "Audit")
  |> assert_has("td", "create")
  |> assert_has("td", params.complaint)
end

A hands-off option for working with hidden fields would be a fantastic option, though I'm not familiar enough with how LiveView.Test handles hidden inputs under the hood to say immediately if it will work in this case so I will need to try it out.
For other cases an official escape hatch is also a great idea!
I don't actually use the escape hatch I outlined anymore, as I use the commit I linked as the dep in my project and specify the hidden fields as the third argument (though it's not as nice as the first idea you mentioned).
Using then to break out definitely looks a lot cleaner as well, I wish I had thought of that initially 🤦
I look forward to the changes you are implementing and will try them out!
As far as this issue is concerned, I believe either of the options you mentioned would negate an actual change to submit_form so I will close it down.


Catalog react owner text overflow

PR for the issue :26990
With this fix the text will not overflow as we can see in the below screenshot .

@freben @vinzscam comment were addressed last week only , please re-review it .


telemetry: use UDS for mixer sidecar communication

UDS eliminates some of the overhead of TCP protocol.
/assign @douglas-reid @mandarjog
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
Assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [mandarjog]
pilot/OWNERS [kyessenov,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Please update the title if this changes both policy and telemetry.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, kyessenov, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [douglas-reid,mandarjog]
pilot/OWNERS [douglas-reid,kyessenov,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

UDS latency is around 2us average.


maxZ is nil on qb-target.lua

in line 139 value returned nil with console error.
exportHandler('AddBoxZone', function(name, center, length, width, options, targetoptions)
    local z = center.z

    if not options.useZ then
        z = z + math.abs(options.maxZ - options.minZ) / 2 -- < options.maxZ is nil (tested in qb-core framework after delete qb-target)
        center = vec3(center.x, center.y, z)
    end

    return api.addBoxZone({
        name = name,
        coords = center,
        size = vec3(width, length,
            (options.useZ or not options.maxZ) and center.z or math.abs(options.maxZ - options.minZ)),
        debug = options.debugPoly,
        rotation = options.heading,
        options = convert(targetoptions),
    })
end)

was fixed in #33
any solution for this?

any solution for this?

Make it NOT NIL?

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

Not my fault that QB can't even manage to use "their" resource correctly. It also isn't my responsibility to provide 100% compatibility for anything, let alone for a framework that steals code and removes copyright notices.
qb-target compatibility is only there because somebody PR'd it. If something doesn't work, then PR a fix, because I frankly could not give any less shits about it.

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

are you like brain dead or something bruhhhhhhh? wew there goes the qb-target support CONGRATS buddy


Fix ocis runtime

fixes #115 however magical. Currently looking into why adding a logging line fixes the execution...

Currently looking into why adding a logging line fixes the execution...

Probably you know, but anyways: The logline probably acts as a synchronization point  because logging always blocks. Or are we alredy doing this? https://github.com/rs/zerolog#thread-safe-lock-free-non-blocking-writer

Just fixed that, it was a goroutine issue


Require MYSCOPE to be your npm username.

Problem
In 8.2.4, it currently says

...
In your project directory run the following command:
$ wasm-pack init --scope MYSCOPE
where MYSCOPE is your name or something.
...

To me, or something implies that MYSCOPE can be anything.
This is what I thought when I was following the tutorial, so I chose hello-world as my scope, and got an error message.
It turns out, according to the npm scope documentation:

Each npm user/organization has their own scope, and only you can add packages in your scope.

Solution
To solve this, I simply replaced the misleading your name or something with your npm username.

@kylejlin thanks for the clarification and thank you for fixing this! :D


Error when gutter-position set to “split” and gutter to “0”

My settings:
$susy: (
	math: fluid,
	gutter-position: split,
	container: 1100px,
	columns: 12,
	gutters: 0,
	global-box-sizing: border-box
);

I was getting this error:
message: 'invalid null operation: ""16.66667%" plus null".'

… when using a margin mixin:
@include push(2 of 12);

The fix was to change gutter-position to “after”:
$susy: (
	math: fluid,
	gutter-position: after,
	container: 1100px,
	columns: 12,
	gutters: 0,
	global-box-sizing: border-box
);

:+1:


Add option to set name field for input.

This PR adds an option to set a name field for the input field.

Thanks


Allow specifying query params in get request without using params

From<EMAIL_ADDRESS>on January 27, 2011 14:02:08
Allow this: get("/redirect?url="+url). Right now the "?" is url encoded.
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=23

From<EMAIL_ADDRESS>on February 11, 2011 08:20:53
Status: Fixed


Fix FixtureSupport#run_in_transaction?

ActiveRecord::TestFixture's uses_transaction is designed to be used like this:
uses_transaction :the_test_method_name

And in RSpec, the method name would be the example's name.
uses_transaction "does someting"

it "does someting" {}

But in the current implementation, it's passing the example object instead of its name, which would always fail the name comparison in https://github.com/rails/rails/blob/main/activerecord/lib/active_record/test_fixtures.rb#L94-L97
So this PR fixes the issue by passing the example's name instead of the example object.

Ruby: 2.5.8, Rails: ~> 5.2.0
GitHub Actions has encountered an internal error when running your job.

:man_shrugging:
Re-running.

@pirj I'll leave any decisions on this up to you, my feedback is non blocking

Thank you for the contribution and for revealing the mystery behind uses_transaction, @st0012 !

@pirj I've been using rspec-rails for years and it's finally my turn to make a small contribution 🙂


Hide amendment buttons for versioning fix release

@calebissharp I haven't looked at git so I don't know how hard it would be to throw all amendment stuff in a branch and pop off from dev, but I'm assuming it would be a PIA as its been a WIP for awhile.  I'm cool with just commenting them out for this week if that works for you.

@micheal-w-wells I don't think it makes sense to remove all the amendment implementation right now (it's also been partially implemented since the previous contractors anyways), so just hiding the button seems like the best solution.

@LisaMoore1 @ZoeSimon I'm going to move all the amendment stuff in QA over to ice box while we work on this versioning & client linking + misc fixes release.


Determine when sub-contexts created for coordination can be removed

Currently, sub-contexts created for coordination purposes are never removed.
For a phased coordinator, we know when the final response is about to be returned, so we can probably remove the sub-context in process_response.
For sequential coordinators, currently, the last agent in the sequence sends the response back to the agent that called the sequential coordinator. Perhaps we can update things so that an ACK message is also sent to the sequential coordinator so that in its process_response method, it could take care of removing the sub-context when this ACK completion message is received.

this relates also to #382


[WIP] :book: Add docs for writing provider integrations

What this PR does / why we need it:
Adding docs for writing provider integrations
Which issue(s) this PR fixes:
Fixes #29
TODOs:

[ ] squash commits
[x] include documentation
[ ] add unit tests

@michal-gubricky @NotTheEvilOne @jschoone I have added the documentation that we talked about in yesterday's meeting. I updated the previous section about best practices to make it clearer. @michal-gubricky if there are some open questions to you that I haven't answered yet, please tell me!


Mixin target "IntegratedServer" was not found

Hey, I'm not sure if this is important at all. I'm going through my server's latest.log to check for errors and found the following warning:
[mixin]: @Mixin target net.minecraft.server.integrated.IntegratedServer was not found mixins.vanillafix.crashes.json:MixinIntegratedServer
Is this something I should look into fixing? I couldn't find any information about it via googling, just people's logs.

I couldn't make a guess to why there is an issue without a log from your end.

My apologies. I was half expecting this to be a non-issue so I didn't try to upload the latest.log, my bad.
Here it is: https://paste.ee/p/ioo3J
And also here is my environmental information:

Minecraft version: 1.12.2
Forge version: forge-1.12.2-<IP_ADDRESS>38-universal
Modpack version (links to current modlist): 1.7.2
Mod versions: VanillaFix-1.0.10-99


Initial commit for User Security Metadata notebook

This notebook will provide a step-by-step instructions on how to consume and understand the analytics data in Sentinel.
@juliango2100 , @ianhelle , @yroymsft

If you look at other existing notebooks, i.e., Guided Hunting - Windows-Host-Explorer, you will notice that we have common sections:
Title + Packages and Platform requirements + Description.
Table of Contents.
And then sections.
I cannot easily view your layout, can you please provide a notebook screen snapshot?

BTW, we have sample code to read user config info: look at: Get Started.ipynb.

So, last thing, have you tested it on Az Notebook Free Compute?

@zhzhao8888 yes I  have tested this notebook  on Free Compute.


Why store Github uid rather than username?

I'm up and running and users can sign in with github and all, but looking through the users only the name and uid is stored from github. Would it be more useful to identify the user by their username (which is also unique) rather than the uid? Is there a good reason for storing the uid that I am just missing? Thanks for the clarification

The way I fixed this was as follows (I kept the uid just in case there is a good reason for having it):

Add username field to database

rails g migration AddUsernameToUsers username:string
(optional) I went into the migration and made the username unique

Go into user model and save the username (referred to, for some reason, as the nickname)

user.username = auth['info']['nickname'] || ""
(This is within the if statement for auth['info'])

Now you can access the username as you usually would (@user.username)


Type-Aware Builder Return Values?

The builder methods on AbstractCameraActivity.IntentBuilder return an instance of AbstractCameraActivity.IntentBuilder, not the subtype. As a result, you have to call subtype methods like skipConfirm() before anything else. See if there's a better way (generics?) of implementing such builders, to still use inheritance but return instances typed for the concrete type.

Addressed in v0.4.0.


no-mergable-namespace -> no-mergeable-namespace

This is already fixed in the source via https://github.com/palantir/tslint/pull/1361, but this is a good quick fix until the docs site is regenerated completely.