Add support to plugins

Hello dear sir.
it would be nice to add custom plugins to local_requirements.txt and install them automatically.
a task in the file configure.yml similar to this one can do the job:
- name: configure | add the custom plugins local_requirements.txt
  ansible.builtin.lineinfile:
    path: "{{ netbox_current_path }}/local_requirements.txt"
    line: "{{ item.name }}"
    regexp: "^{{ item.name }}"
    owner: "{{ netbox_user }}"
    mode: '0644'
    create: yes
  with_items: "{{ netbox_plugins }}"

I'm using the already present variable netbox_plugins to generate the list of names to be added to the local_requirements.txt
I might open a PR but I suspect you are already working on something like this.
let me know.
Best

Some plugins have a pip package name that differs from the PLUGIN_CONFIG name.
Probably would be better to use a separate variable netbox_local_requirements_plugin for the local_requirement.txt population.

Hi! I was working on plugins at one point and got side tracked. I would certainly welcome a PR to add this functionality to the role.
You bring up a good point on the package name differing from the plugin name. Additionally, we would also have to ensure any required plugin steps are followed per the docs, ie. database migration, etc.
Also need to ensure this does not conflict with itself during installation, upgrades, config changes, etc.

Found some time to work on plugins again. The linked PR uses a similar method to what you were proposing. I cross-referenced the upgrade.sh script with how NetBox recommends installing packages. Fortunately the script completes all the same tasks for us, so I used changes here to trigger that script to run again.
The PR should successfully install and configure as well as allow removal of plugins as required. Let me know if you experience any issues with this.


Improve radio checkboxes in the default editor theme

The change was done for checkboxes already, but I forgot to do it for radio checkboxes in that PR.
Preview

Before
After

Before
After

Thanks!

Since https://github.com/godotengine/godot/pull/48954 was cherry-picked for 3.4, this PR should also be cherry-picked for consistency :slightly_smiling_face:

Cherry-picked for 3.4.


Add a CONTRIBUTING.md file

To help developers understand, contribute, and test, it would be helpful to have a development.md file.

We need to add a Contributor Guide to the project. We could start outlining it in this issue or check in something simple.

I would like to help with this issue.

Cool, go ahead and submit something!  I PROMISE it will be easier to get pushed through than those usaf RMF and ATO documents lol ;)


upload unsigned build artifacts

Note that artifacts are all uploaded to the workflow summary page when the entire workflow has completed. For example: https://github.com/Jigsaw-Code/outline-client/actions/runs/1496543793

I'll split up the workflows in the next PR.


Allow running containers without overriding command line

Currently Dockerfiles are using a mix of ENTRYPOINT and CMD. If we change the ENTRYPOINT to always point to the executable, and CMD to point to the default arguments (like all for hotrod image), then the containers can be run as executables with additional parameters overriding the CMD, but not overriding ENTRYPOINT.
E.g. hotrod's Dockerfile should have
ENTRYPOINT ["/go/bin/hotrod-linux"]
CMD ["all"]

while all other binaries should have just the ENTRYPOINT pointing to the binary.
The main benefit is that when users run the image and pass additional arguments, they don't need to know the name of the binary inside the image.

I've been meaning to revamp our Docker images, applying some of the good practices shown during a presentation I watched a couple of months ago: https://de.slideshare.net/QAware/docker-und-kubernetes-patters-antipatterns (slide 15, it's in German but shouldn't be difficult to deduce what the good practices are).


Handling of language codes

Hi,
I have a recurring problem with subtitles embedded in mkv files. Quite often, they are coded using alpha3b codes, e.g. using 'fre' when the alpha3 code is 'fra' for French.
The problem is:

If I don't include 'fre' in the swl list, the subtitles do not get picked up
If I include 'fre' in the swl list, then the subtitles get picked up, but the mkvtomp4 script errors on line 555, because babelfish expects alpha3 codes, not alpha3b codes. (NB: this does not happen with audio, where I can include both codes).

I did some research, and the spec for mp4 is that yet another ISO standard should be used, namely alpha3t (ISO-639-2/T) (you can see it here, in section 8.8)
I thought it was a good idea to set things up so that:
swl, awl, sdl, and adl  all use alpha3t code and then convert the subtitle.metadata['language'] and audio.metadata['language'], to alpha3t codes too, to make sure that equivalent things are compared. Otherwise, users would need to put all codes in autoProcess.ini to make sure that they include their language in the processed file, which also leads to unnecessary iterations in the various loops (checking once for 'fre', and once for 'fra' is inefficient).
French is not the only language with this problem, Chinese, Dutch, German and other languages have different alpha3b and alpha3 codes too.
Please, do tell me if you want me to amend the code. I am not a professional developer, so things may be inelegant, or there just might be a better way that I just don't know about. I'm happy to improve.
Thanks you and kind regards,
Jon

Minor thing that you may want to fix, this  breaks python3 compatibility when using manual.py.
In the languagecode.py file, you'll need to add a check for python 2, as basestring is dropped in python3.
Something like this:

import sys
IS_PY2 = sys.version_info[0] == 2

def validateLangCode(code):
    """
    :param code: alpha2, alpha3 or alpha3b code or list of codes
    :type code: list or string
    :return:  list or string containing valid alpha3 codes
    """
    lang = 'und'
    if code:
        if isinstance(code, list):
            lang = filter(lambda x: x != 'und', list(set(map(getAlpha3TCode, code))))
            lang = 'und' if lang == [] else lang
        elif IS_PY2:
            if isinstance(code, basestring):
                lang = getAlpha3TCode(code)
        else:
            if isinstance(code, bytes):
                lang = getAlpha3TCode(code)

    return lang

Ok, thanks. I’ll fix this tonight.

Le 21 mars 2018 à 00:46, Alex<EMAIL_ADDRESS>a écrit :
Minor thing that you may want to fix, this breaks python3 compatibility when using manual.py.
In the languagecode.py file, you'll need to add a check for python 2, as basestring is dropped in python3.
Something like this:
import sys
IS_PY2 = sys.version_info[0] == 2
def validateLangCode(code):
"""
:param code: alpha2, alpha3 or alpha3b code or list of codes
:type code: list or string
:return:  list or string containing valid alpha3 codes
"""
lang = 'und'
if code:
if isinstance(code, list):
lang = filter(lambda x: x != 'und', list(set(map(getAlpha3TCode, code))))
lang = 'und' if lang == [] else lang
elif IS_PY2:
if isinstance(code, basestring):
lang = getAlpha3TCode(code)
else:
if isinstance(code, bytes):
lang = getAlpha3TCode(code)
return lang

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

While this exact pull is dated this feature was implemented recently


Update tutorial-discover-hyper-v.md

Fixed a small typo, where the sentence was referring to 'VMware environment'.

#sign-off


E2 print(int, str, ...) fails silently

print(int, str, ...) fails to print anything (unexpected)
print(str, int, ...) works
Example:
print(5)
print("test", 5)
print(5, "test")

Output:
5
test    5

Expected output:
5
test    5
5    test

Ah it's intended, the first int is changing where the print is going to. Should've dug a bit more into the docs

Ah it's intended, the first int is changing where the print is going to. Should've dug a bit more into the docs

yeah this is a relic of the past. Previously, E2 did not support varargs, and print had only print(N,S). Then, print(...) was added later, but an exception was made to it, in order to preserve backwards compatibility with the old N,S arguments.

yeah this is a relic of the past. Previously, E2 did not support varargs, and print had only print(N,S). Then, print(...) was added later, but an exception was made to it, in order to preserve backwards compatibility with the old N,S arguments.


Wrap FieldErrors in errs.Error inside Query handlers

This addresses the issue raised in #443 .

Check out this commit with the fix you identified. This handled things with a minimal change.
https://github.com/ardanlabs/service/commit/982523cce0afaa9e56f5796eb9ae40887acd46fc

It looks great!
So, I'm closing this PR.

Thanks again for identifying this problem!!


[EOC-145] Edit list limited shared

I edited list schema and changed "isPrivate" field to "type". In all places where this prop was used to check list's privacy there is comparison now e.g. type === ListType.LIMITED both on front-end and back-end.

I edited list schema and changed "isPrivate" field to "type". In all places where this prop was used to check list's privacy there is comparison now e.g. type === ListType.LIMITED both on front-end and back-end.


add online monitor

Preamble: https://github.com/AxFoundation/strax/pull/315 should be merged first before this PR makes sense.
What is the problem / what does the code in this PR do
Add a new frontend to the main context.
Can you briefly describe how it works?
It allows certain specified plugins to be writing data to the online_monitor collection of the database. This data can then be loaded elsewhere and displayed on the website
Can you give a minimal working example (or illustrate with a figure)?
The output will look like:
https://gist.github.com/jorana/d3176c4e561ccca4e8ca2fc2420acf7c
For code see:
XENONnT/analysiscode#27

Since https://github.com/XENONnT/straxen/pull/207 it is also possible to output the deadtime to the website. This will be added soon to this PR after https://github.com/AxFoundation/strax/pull/315 has been merged.

@darrylmasson, based on your request I've changed the init of the online monitor backend. This is now only available if one is the DAQ or adds the storage by hand.
Also, what plugins would you say we would want to display on the website? I would argue the AQMon-plugin written by @AlexElykov and also the pulse-counts as you can really see the rates changing while also allowing e.g. a PMT expert to load the associated data.

Also, what plugins would you say we would want to display on the website? I would argue the AQMon-plugin written by @AlexElykov and also the pulse-counts as you can really see the rates changing while also allowing e.g. a PMT expert to load the associated data.

I think it is a good idea, especially if we will able to deploy this before the upcoming light yield tests, this will give us a better handle on the DAQ/veto performance.
What is the envisioned implementation of this on the user side (@darrylmasson), is it gonna be another page on the DAQ website (NODIAQ..jade, javascript based) like I've made for the deadtime chart? or you has something else in mind?

I don't have anything specific envisioned for the visualization, but we already have the page that interfaces with microstrax, and that seems like a pretty good place to put things.

After https://github.com/AxFoundation/strax/pull/323, there is an entry in each document: write_time.
To this end, I've created a new collection online_monitor in the xenonnt database which is TTL and expires after 7 days.

After implementing https://github.com/AxFoundation/strax/pull/327 we successfully ran this PR on the event builder. The entries for run 9158 are now in the rundoc. Please notice that in the case of crashes (like the first document in the 'online_monitor' collection) are not automatically removed but can be recognized by the omission of 'writing ended'.

Hi all,
Thanks, I don't think exporting get_mongo_url is a good idea as people might for some reason start printing it in a notebook and upload our cridentials for the mongo-database somewhere. There is limited reason why people should want to get the mongo-url outside the instances provided in this PR (RunDB and OnlineMonitor).
I will add a docstring, thanks for the good suggestion Daniel!


The blacklist page itself has also a lot of visual issues.


UIPER-104: leverage cookie based authentication in all api requests

https://issues.folio.org/browse/UIPER-104

getLegacyTokenHeader should be provided by stripes-core.
Then using it as in the original version of this PR becomes a recognizable idiom.

getLegacyTokenHeader should be provided by stripes-core.
Then using it as in the original version of this PR becomes a recognizable idiom.

I guess using okapiKy or stripes-connect would be.


port to node

This is not done, but I'm opening this to get feedback.
What needs to be done before merging:

[ ] merge latest changes in master
[ ] assure all blocks render correctly: npm test
[ ] package translations.js and all-translations.js
[x] discuss API change, major version bump
[x] document API change

Quite a few changes here, just leave a line comment if something is unclear or you disagree in the change.

Hi! There's lots of great stuff here :D
Here are some thoughts:

Rewriting build_translations in JS is excellent, I've been meaning to do that for a while.
Porting extra_aliases to JSON is also rather sensible, thanks for that.
Regarding the API change: I like the old API, and I'd rather not change it at this point (it's already deployed eg. on the forums, and the forums are very fragile.) Maybe add a convenience function (like scratchblocks.renderToSVG(text) if that's what you want? :)
I'm uncertain about the build system changes. It's particularly important to me that I can hack on scratchblocks without having to manually rebuild after each change; my workflow is that I just refresh the browser window. Can you confirm that's still possible?
I liked that scratchblocks was entirely self-contained in one static JS file, but I guess I'll give that up if I have to. (Hence the Makefile for updating its contents; I guess you've removed that now?)
I'm not sure why you moved utils.js to a separate file. I'd rather keep everything together if possible
:)
The text measuring stuff is clever, but I'm not sure how well it will work for eg. unicode/emoji. I need to have a closer read through your code (the diff is pretty large because of all the file moves around, it'll take me a while to sort through).

If you can support headless rendering with fewer changes to the build system, that'd be great :) Otherwise this looks like a good piece of work!

Regarding the API change: I like the old API, and I'd rather not change it at this point (it's already deployed eg. on the forums, and the forums are very fragile.) Maybe add a convenience function (like scratchblocks.renderToSVG(text) if that's what you want? :)

I understand that.

I'm uncertain about the build system changes. It's particularly important to me that I can hack on scratchblocks without having to manually rebuild after each change; my workflow is that I just refresh the browser window. Can you confirm that's still possible?

Yes, it is. See CONTRIBUTING.md for work flow. Essentially this should set you up:
npm install
npm start

It does not livereload, but it does build when file changes.

I liked that scratchblocks was entirely self-contained in one static JS file, but I guess I'll give that up if I have to.

Heh, I though of separating it even more. Had some hard time navigating through the flow of the code.

Hence the Makefile for updating its contents; I guess you've removed that now?

Yes, all of that is contained in package.json, see scripts. It's basically equivalent as the makefile, but idiomatic node.

I'm not sure why you moved utils.js to a separate file. I'd rather keep everything together if possible :)

I moved out code which would not run / give sense on node. I can put it back if you prefer, or maybe add it through the browser build step? Is it that it remains in a separate file that the problem, or that it's not available directly?

The text measuring stuff is clever, but I'm not sure how well it will work for eg. unicode/emoji. I need to have a closer read through your code (the diff is pretty large because of all the file moves around, it'll take me a while to sort through).

Canvas should be equivalent to rendering in DOM. Here is the essential part:
function measureText(text, font) {
     // re-use canvas object for better performance
     var canvas = measureText.canvas || (measureText.canvas = newCanvas());
     var context = canvas.getContext("2d");
     context.font = font;
     return context.measureText(text);
 }

Canvas should be equivalent to rendering in DOM. Here is the essential part:

Oh, great. I was thinking of your proof of concept but presumably that's removed now. :)

I can put it back if you prefer, or maybe add it through the browser build step? Is it that the code remains in a separate file that's the problem, or that the API is not available directly?

I'd prefer if it went back, I think. I'd like the old API put back and to be available; having it in one preference is a style thing.

npm start

Should've said; I did try this, and it seemed to work the way I wanted -- I just wanted you to reassure me that's the intention! :)
I'm sorry to hear you had trouble understanding the code! Sounds like something a long comment / dev doc / philosophy page might help fix? I should probably try writing one!
Thanks again for working on this!

Oh, great. I was thinking of your proof of concept but presumably that's removed now. :)

Hehe, yes, that was a naive dead end. What really amazed me was that there is so little concrete information about fonts. Like, what available font sizes are available, which fonts looks alike, etc. Did find this great resource though: fontfamily.io

I'm sorry to hear you had trouble understanding the code! Sounds like something a long comment / dev doc / philosophy page might help fix? I should probably try writing one!

To put it in context, first, I tried reading through. As it's a couple of thousand lines, keeping things in memory / context did not work out.
Then I used the debugger, and drew a flow map. This way I was able to sort out essential parts. Still, I do not have complete overview of the code yet.
A philosophy / writeup would probably help here. Here are a couple of questions I still haven't answered:

Is the code structured with a tokenizer, lexer and parser?
What does the tokenized stream look like?

Is the code structured with a tokenizer, lexer and parser?
What does the tokenized stream look like?

Ahaha, no! Parsing scratchblocks is really hard: it doesn't really fit the traditional lexer/parser model.
What we have is two separate parsers: parseLines and parseScripts. parseLines() is a recursive descent parser that operates over a stream of characters (the original source). It parses a whole line to get a Block --  or the string 'NL' for blank lines. It takes care of things like auto-closing brackets at the end of a line, and it calls into paintBlock to do the block recognition.
parseScripts() streams in the lines and "parses" them to build up the nested structure -- C blocks, scripts, etc. It takes care of things like: a hat block always forces a new script.
recogniseStuff walks over the AST looking for things like list names and custom blocks, and recolours them appropriately.
Where this gets confusing is that in order to implement the { } notation for rings / custom C blocks / embedded stack blocks, parseScripts also calls into parseLines! So the flow is somewhat inherently confusing :P

I'll add a philosophy writeup to my todo list; that'll go on my blog in a month or two. But if you have any more questions at any point, feel free to ask!
Are you happy to clean this up a bit, and restore the previous API? Then I can try and get this merged. :)

Regarding the src/browser scratchblocks.js distinction -- would it make sense to use AMD/UMD here, and have a single file shared between both?

It should already be UMD:
  --standalone -s  Generate a UMD bundle for the supplied export name.
                   This bundle works with other module systems and sets the name
                   given as a window global if no module system is found.

Are you happy to clean this up a bit, and restore the previous API?

I'll take a look at restoring the API now.

PS: You need to get the package name back on npmjs: https://www.npmjs.com/package/scratchblocks

PS: You need to get the package name transferred on npmjs: https://www.npmjs.com/package/scratchblocks

Yeah, I don't know how to go about that. Do you want to try taking it over? :)

Ok, this is good to go. Please take a look in the tests folder after a npm test to confirm that blocks renders correctly.
Also, I'm not including the latest changes in master, as more commits have been pushed just after I pull and merged the latest changes. I'm sure you can figure this out, I did git checkout master; git diff v3.1 to find latest changes.

I'm not including the latest changes in master, as more commits have been pushed just after I pulled and merged the latest changes

Huh? I haven't pushed to master for at least a week (the last commit was eight days ago).
I don't like the style changes; for example, the 'inconsistent quotes' are actually a personal style thing (double-quotes for user-facing strings, generally). I'd also much rather the indentation in src/scratchblocks.js wasn't changed; this is making the diffs overly complicated.

Huh? I haven't pushed to master for at least a week (the last commit was eight days ago).

See my edit above. Git did not figure out the manual merge, I misunderstood that.

I don't like the style changes; for example, the 'inconsistent quotes' are actually a personal style thing (double-quotes for user-facing strings, generally).

I get that.

I'd also much rather the indentation in src/scratchblocks.js wasn't changed; this is making the diffs overly complicated.

Sorry about that.
I've already used quite some time here, and I'm leaving it with this. You can probably figure out how to keep the style of the project as you like.

Ok, will do. :)

For people interested in node/UMD/browserify/webpack compatibility, I've forked to arve0/scratchblocks.

Sorry—I keep meaning to get to this, but I'm just too busy!
I've merged your branch—from the small amount I've played with it, it looks very good :-)
I've also granted you push access, so you can merge your own pull requests in future.


[Service Bus] Improve delays in test

Also includes fix for few test failures due to race condition in multiple receive
batch tests
Addresses issue #1015

Closing in favor of https://github.com/Azure/azure-sdk-for-js/pull/1068


[0.10.1] panic: runtime error: slice bounds out of range

Instances are clustered and restart of any of the nodes causes this panic:
panic: runtime error: slice bounds out of range

goroutine 71 [running]:
github.com/influxdb/influxdb/tsdb/engine/tsm1.(*indirectIndex).UnmarshalBinary(0xc222850f00, 0x7f715
abea3c9, 0x7efa2a, 0x7efa32, 0x0, 0x0)
        /tmp/tmp.n7AHL1nb9U/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/reader.go:639 +0x45f

Nodes cannot be restarted currently. The logs from the nodes are attached
Gist with logs
Tagging @joelegasse per his request

Would it be possible to get a copy of the database that is causing the issue?
Is this limited to 0.10.1? Or is this also seen in 0.10.3?

This appears to be a corrupt/truncated index from where the code is panicking. We can (and should) add some checks to make sure everything doesn't crash, but that wouldn't fix the ability to load the data, or even prevent the corruption if we happen to be creating these corrupt indexes ourselves.

Should be fixed via #6082

related to #5889


Use kvstore with grid

Verified from https://github.com/threefoldtech/www-mastodon/pull/122/files
The BackendStorageType is now set to tfkvstore in the client config.


Create Radarr API Calls

TMDB

[x] Search Person: https://api.themoviedb.org/3/search/person

Radarr

[ ] POST Import List: /api/v3/importlist
[ ] GET Import List: /api/v3/importlist
[ ] GET Quality Profiles: /api/v3/qualityprofile
[ ] GET Root Folder Path: /api/v3/rootfolder

Related to #7
Use GET Import List


Namespaces for enveloped entity instances

Generally it's best practice to put all elements from a vocabulary in their own namespace to avoid conflicts and to allow easy and unambiguous discrimination from elements in other vocabularies (e.g. for schema validation). On the other hand, namespaces add complexity for just about everything downstream. What’s the cost-benefit? Should this be optional? If so, how do we determine the namespace URI and prefix?

"If so, how do we determine the namespace URI and prefix?"
We have included baseUri in the model for this purpose (for the URI anyhow).  There are potentially two uses for this Uri in instance data: both in the XML persistence layer and in a TDE template to extract triples.

I too would like to see support for namespaces in instances.

temporarily switched to 'task' to prod the bugtrack integration into setting to 9.0-2.
still considered enhancement until we decide to put it into a scope of work tho.

Set milestone and labels for BT update

Considering design for namespaces in canonical documents.
We already have a "baseURI" property, which is used to form the left-hand side of triples.  It would be a natural fit for also being the namespace of canonical instances, but there are other options that would provide more flexibility.
Say each entity type could take a "namespace" property.  Then the canonical XML namespace would be controlled at the type level, not the model/vocabulary level.  Would that be preferable?
Curious about opinions from @paxtonhare , @jmakeig
``
{"info":
{"title":"Socks", "version":"3.0.0", "baseUri": "http://example.ontology/clothing/"}
"definitions":
{
"sock" : {
"namespace":"http://example.org/clothing/sock"
}
}

This approach would ensure granularity for validation purposes, but make a lot more namespaces, which might not be good XSD convention.

implemented changes to database properties creation and search options.  schema looks perhaps more complex than I thought, test instances are done.

Added tests that will be in PR later today.

Task completed. Added tests are running fine. Shipping the task


Existed Cache bucket usage policy attachment to docker machine is missing

I am following this sample,
https://github.com/npalm/terraform-aws-gitlab-runner/blob/develop/examples/runner-public/main.tf
when you create cache bucket outside of the module, even if you pass the related policy arn into  cache_bucket variable, it is not attached because create is false..
  cache_bucket = {
    create = false
    policy = "${module.cache.policy_arn}"
    bucket = "${module.cache.bucket}"
  }

So you have to attach it, outside of the module. If this is the case you need to update example. If not why we are passing the policy into variable.

@realsby good catch, thanks for creating the issue


fix picking a wrong trending factor bug

Currently the picked trending factor is not the max factor based rules, but the last rule's factor of rules.
This PR is to pick the correct factor from rules

@hitzzc  Thank you


Allow receiving an external tree

A small performance improvement: allow receiving an external tree into extruct.
Also bump the default Python version to 3.9, hope that's OK.

@croqaz thanks for the PR! Do you mind updating supported versions in https://github.com/scrapinghub/extruct/blob/9453e4348e06509e7716ada3de585cddfe2ad0d4/setup.py#L67 -- and also having a look at the CI, it seems we also run 3.7 and 3.11 on this branch (and then we don't need to drop 3.7 I guess, although I would not mind at all).

According to https://devguide.python.org/versions/ at this point in time, 3.7 is dead, and 3.8 has a bit over a year. Looks safe to remove 3.7.

Sounds great! Do you mind also mentioning this feature in the README? We don't build docs here so it would be useful to mention it there.


Fix #392 - restore limited support for 'execute line in interactive'

Fixes #392 - adds back the keyboard shortcut and command handling for 'Execute line in interactive'.
This maintains the decision to remove "execute line" from the UI context menu. It just restores the keyboard shortcut and backend handling so that we don't break anyone's muscle memory.

The scenario meets the bar however it should be code reviewed.

@dungpa @enricosada @KevinRansom etc, can you take a look at this guy? Shiproom would like to see some code review before approving.

Is that the wrong linked issue? This is not a fix for 'Compiler sometimes suggests constraints that are impossible to write' ? :)

@rojepp thanks, fixed

Overall, LGTM. Just have a few minor comments above.

@dungpa great feedback, thanks.  I've applied your suggestions.

LGTM.
:shipit:

Approved 5/27 by ML Shiproom.


Export Cradle utilizes

Followup to  #178.
This is needed for Avi-D-coder/implicit-hie-cradle.
I copied anything I did not see beaning used by other cradles besides the implicit one.

... and it would close #165 😄

@mpickering @fendor Could you take a look at this


Re-enable ToolBuilder tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+13.1%) to 78.797%

Totals

Change from base Build<PHONE_NUMBER>:
13.1%

Covered Lines:
2988

Relevant Lines:
3792

💛  - Coveralls


Set SSH root password (fixes #58)

Purpose:

This sets the SSH root password for better security.
It is also used for PureFTPD FTP access with the root / {password} credentials.

Testing:

Verified working on my Yi Home 1080p v3 camera.

Very good work! Unfortunately for my case it does not really work as I'd like to set the root password independent from the other (HTTP/FTP) as I want to include the Snapshots in my SmartHome dashboard without using the root password for authentication.
Proposed change:

Configurable SSH root password independent from HTTPD/FTP

I have a spare 9FUS here and will add the feature on a fork and create a pull request after testing on my local devices.

root password (/etc/passwd authentication) works only with telnet, ssh and ftp.
Custom authentication (available in the web interface) works with onvif, rtsp and http.
If you want to use snapshot feature through the web interface you have to use the second one.

@roleoroleo Thanks for the information. I have found the corresponding configs and scripts. What I see from the current system.sh script it uses the same password from the configuration. I have added a SSH_PASSWORD that can be configured in a separate field in the authentication section.

Implementation and test done, pull request #90


Graphic mode display problem

Describe the bug

Open the Claculater in standard mode, switch to graphic mode.
Then boom!

Steps To Reproduce

Open the Claculater in standard mode, switch to graphic mode.
Then boom!

Expected behavior

Display normally.
Screenshots

Device and Application Information

OS Build: 10.0.19041.0
Architecture:X64
Application Version:10.2005.23.0
Region:zh-CN
Dev Version Installed: False

Additional context

Requested Assignment

I'm just reporting this problem.  I don't want to fix it.

I just click the menu button, then it appeared again.

More screenshot.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

Hi @youlingwangzi--it looks like this issue might be related to your graphics card or driver.
Can submit a problem report using the Feedback Hub app in Windows, which will gather some diagnostic information about the graphics driver in your PC? If you click the "Share" button in Feedback Hub, it will create a link which you can post here.

Here is the Feedback Hub link:
https://aka.ms/AA8y629

Thanks for the feedback hub report. I'll route this to someone internally who can try to diagnose the issue.
In the meantime, you might consider checking whether there is a newer HD Graphics 530 driver available from Intel.

Closing this as external, since it seems like we are routing this to the right place internally.


Batch 2 of tpch queries for polars and pandas

Added code for q2 polars & pandas
Added code for q3 pandas
Added code for q4 polars & pandas
Added code for q5 polars & pandas

Thanks, I think it looks good. Can I merge it?

let me do q6 as well,

let me do q6 as well,

Can we do that in a separate PR?

let me do q6 as well,

Can we do that in a separate PR?

done already
:D

Added code for q2 and q6 as well.

Thanks a lot for the effort @chitralverma!


Recipe for Go Modules.

How to build using Go Modules.

Coverage remained the same at 54.054% when pulling b4e76d4521b1ef7af6d9da311f4c088c8a7603bf on udhos:master into 81d2751f928ac621783bff4b831ec62dacc0259b on Netflix:master.

Hey @udhos , thanks for submitting this PR. Sorry it was left hanging for all this time. Someone should have reviewed it and worked to get it merged, as it was a good change to make.
It's been superseded by https://github.com/Netflix/chaosmonkey/pull/78, so we're going to close this PR.


Update sbt to 1.3.11

Updates org.scala-sbt:sbt from 1.3.10 to 1.3.11.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Coverage remained the same at 0.0% when pulling 14b14a0b904175398e77a8860c6263c2a0d31605 on scala-steward:update/sbt-1.3.11 into 7566a3d8bdb59e715d6662750e351eaf8006da9a on andyglow:develop.


add events

I'm working with my team using this package but we didn't find event handling yet (v-on or @)

I'm working with my team using this package but we didn't find event handling yet (v-on or @)

Hi @mouhsineelachbi
Here has event description, maybe can helpful you.
https://linmasahiro.github.io/vue3-table-lite/dist/api.html#events
And we has example on here.
https://github.com/linmasahiro/vue3-table-lite/blob/master/src/examples/CustomizeStyle.vue
Btw, If you means add new event handling to the component, it is not support now.


Is there a way I can create Rectangle just like i do with javascript api?

I can not create rectangles. Is there a way to do that?

map.addPolygon({
    points: [
        latlngBounds.southwest,
        {"lat": latlngBounds.southwest.lat, "lng": latlngBounds.northeast.lng},
        latlngBounds.northeast,
        {"lat": latlngBounds.northeast.lat, "lng": latlngBounds.southwest.lng}
    ]
});


Hello, if the song is 1 million (the duration of the song is about 3 minutes), the matching time is very slow, how to optimize it?

Hello, if the song is 1 million (the duration of the song is about 3 minutes), the matching time is very slow, how to optimize it?

Don't use python for this case, see this project: https://github.com/AddictedCS/soundfingerprinting


Fix handling of variables inside comprehensions

Currently, the comprehension assumes it is the only thing on the stack, which may not be correct:
const x = [ 1, 2, 3, 4, 45, [60] ]

echo [ .a, .b, .c ] + [ x for x <- x ]
# incorrectly prints [60, 1, 2, 3, 4, 45, [60]]

Will be fixed in v0.12.3


What if you don't have your tenant linked to a Subscription?

Please clarify what will happen if you don't or forget to link your tenant to a subscription if you have less (or more) than 50,000 MAU. Most customers I work with have never specified this and asking what will occur if they don't select it, especially those who use Azure AD and Microsoft 365 but yet don't have any Azure Subscriptions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d48108c5-3850-af59-ed14-84238bca37f7
Version Independent ID: cca4148e-8754-87a7-42a3-ea368fcb0285
Content: MAU billing model for Azure AD External Identities
Content Source: articles/active-directory/external-identities/external-identities-pricing.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

Thanks for the question! We are taking a look into this and will get back to you soon.

@JonesMikael MAU billing model is enabled when subscription is linked to external identities. If subscription is not linked, 1:5 ratio billing model is applied, which allows up to 5 guest users for 1 Azure AD Premium license in a tenant.
When your tenant is linked to a subscription and you use External Identities features to collaborate with guest users, you'll be automatically billed using the MAU-based billing model.
This is mentioned under About monthly active users (MAU) billing section of the document.


Panic with subinvoke error fails because of parse error

Currently, in most cases, it is not possible to panic inside of a wasm wrapper with the error you get from a subinvocation.
This is most likely due to the way WrapError is de/serialized and lack of support for error aggregation.
Example wasm wrapper code:
let result = TestModule.doWithError();
if let Err(err) = result {
    panic!("{}", err);
}

Expected result:
Should throw with the error from subinvoke.
Actual result:
The following error is received: Error: Failed to parse WrapError.

I'm unable to replicate the issue with this:
let result = ImportedInvokeModule::invoke_throw_error(
    &imported::imported_invoke_module::ArgsInvokeThrowError { a: args.a },
);
if let Err(err) = result {
    panic!("{}", err);
}

Do your remember any more details about when the failure occurred?


WCAG 4.1.2: (devenv/button 'Refresh') Focusable sibling elements must not have the same Name and LocalizedControlType.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:
#A11yMAS; #A11yTCS; #Win32; #DesktopApp; #Feature-ML.NETModelBuilder-Win32-Nov2020; #A11ySev2; #Benchmark; #Visual Studio; #A11yAuto; WCAG4.1.2;
Environment Details:
Microsoft Visual Studio 2019 Preview Version 16.8.0 Preview 6.0
Repro Steps:
1.Open Visual Studio Enterprise 2019 Preview
2. Create a new .Net Core Console App (C#)
3. Tab to "Solution Explorer" and right click on the project (Shift + F10) and then from the expanded list Select "Add" and then from the list items select "Machine learning"
4. Tab till "Object Detection" scenario and select the scenario
5. Tab till "Set up work Space" button and press enter
6. Run Accessibility Insights for Windows
The following accessibility issue needs investigation.
App:
devenv
Element path:
button 'Refresh'
Issue Details:
Focusable sibling elements must not have the same Name and LocalizedControlType. WCAG 4.1.2
How To Fix:
Provide unique names for sibling controls that have the same ControlType property.
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.

Verified the bug in the latest build and the issue is fixed.
Hence closing the bug
Please find the attachment for reference
Microsoft Visual Studio Enterprise 2019 Preview
Version 16.9.0 Preview 4.0 [30917.4.main]

Github tag: #Closed;


When I install inter Atom's autocomplete stops working

When I install inter Atom's autocomplete stops working.
This problem came about when I've decided to update Atom and all my packages!
Not Atom says that "atom-typescript" is depricated!!????

Same here, after updating to Atom 1.19.0

Related to
#https://github.com/TypeStrong/atom-typescript/issues/1294

Doesn't seem to work for me 😞

I'll just leave these here: #1310, #1317.

Pretty sure this can be closed.


Add "join table" for visits

Description

Create a table named vets
Create a "join table" called specializations
Create a "join table" called visits
Insert data for vets
Insert data for specialties
Insert data for visits
Write queries

Screenshots

Who was the last animal seen by William Tatcher?

How many different animals did Stephanie Mendez see?

List all vets and their specialties, including vets with no specialties.

List all animals that visited Stephanie Mendez between April 1st and August 30th, 2020.

What animal has the most visits to vets?

Who was Maisy Smith's first visit?

Details for most recent visit: animal information, vet information, and date of visit.

How many visits were with a vet that did not specialize in that animal's species?

What specialty should Maisy Smith consider getting? Look for the species she gets the most.

@Lucas-Masaba this header was missing in the previous 3 pull requests. How come other reviewers did not notice that?

@Lucas-Masaba can you please refer me to any documentation which states having all the headers in readme are mandatory for code reviews.

Hello @utsargo ,
As code reviewers, we are instructed to ensure that your README.md has all the necessary headers the template provides to make it look professional. Here is a screenshot as proof that we are looking for this requirement. Let me know if this answer is satisfying enough. Sorry, for any inconvenience.

@Lucas-Masaba Thank you very, I understand. :)

Awesome @utsargo , happy coding 👨💻


Do we need to docker login in our test workflows?

Our test-create-stack workflow fails when a user opens a PR on this repository from a fork. This is because GHA runner doesn't populate our tokens when a user opens a PR from a fork for security reasons.
The token is used for a docker login step for the publish acceptance test. We should determine if this test is necessary, and if so, if there's another way to test this functionality without reaching out to the docker registry itself.
Acceptance
The outcome of this issue should be some solution that A. fully tests create-stack functionality without and loss in coverage and B. doesn't fail when run from a workflow on a PR from a fork.

Update:
We saw this again today on https://github.com/paketo-buildpacks/stacks/pull/130, @robdimsdale had to PR into a new branch, and then create another PR from branch to main to get around this.

In the long term, I hope that the Stacks Descriptor RFC and attendant changes to the toolchain will render this moot. With my refactoring of the create-stack codebase, I'm targeting creation of the stack as an OCI archive file output. So, publishing would then require using something like skopeo to push to a registry, similar to what we do with buildpackages in our other workflows.


Migrated LoadingRepositoryList to styled-components

Question
Response

Version?
v1.4.1

Devices tested?
iPhone 6 (iOS 10.3)

Bug fix?
no

New feature?
no

Includes tests?
no

All Tests pass?
yes

Related ticket?
#532

Screenshots

Before
After

Description

Migrated LoadingRepositoryList to styled-components

Coverage increased (+0.08%) to 51.07% when pulling bce15dc3286f92f084d72e264638c783db7b5fe6 on Chandrasekar-G:refactor/LoadingRepositoryList into 6e0f6b224e65c7bdee9b37af9d40b8d1d9c897b2 on gitpoint:master.


input field should only accept valid number format

please restrict the input fields to accept valid number format.

@ashachaf this should work now. This is just a workaround for now until John and I have reworked the calculations to match all the same type. It is working now I think but needs some further polishing.


Is it possible to do single channel single master with multiple outstations

I tried to run the master as the TCP server and then connect multiple outstations to it, and it can only get the data from that single outstation with the specified remote address. If I want to have only one master, how should it be able to connect to multiple outstations? Thank you in advance!

TCPServer channels only support a single outstation.
Have a look at the master "gprs" example:
https://github.com/dnp3/opendnp3/tree/release/cpp/examples/master-gprs
It allows you to accept multiple connections as a master and handle them based on their link-layer address.


ARROW-17697: [Python] Fix Cython warning in types.pxi

Will fix ARROW-17697

Turn warnings into errors
Change signature of DataType.field as others like StructType.field allowed taking int or str.

I think the changes are clear:

flag in cmake for Cython compilation that turns warnings to errors,
changing signatures to fix for reported warnings in pyarrow/types.pxi when compiling PyArrow.

And just to check my understanding: you used cpdef here because you changed def and we want it to be callable from Python? And the error was happening due to the field method being a cdef function in the DataType superclass?

Yepsi pepsi, that's right. I have nothing to add to your understanding. :)


dynamic field

Add dynamic fields documentation to explain their functionality and usage in Sui. Includes details on adding, borrowing, and removing dynamic fields, along with code examples for practical implementation.

This pull request has been deployed to Vercel.

Latest commit:
3dbc5f8

✅ Preview:
https://sui-bootcamp-2024-84z5o8ruc-vbi-academy.vercel.app

🔍 Inspect:
https://vercel.com/vbi-academy/sui-bootcamp-2024/EuTzLwYWv81Uides5FikzPcNzW8f

View Workflow Logs


Fix error when creating a new file

I didn't see this PR when I submitted https://github.com/jupyter/jupyterlab/pull/1065
When this PR is merged, please close 1065 as well.

Superseded by #1065.


clicking away from a GUI element causes history "back" function

I just did a pip install --upgrade homeassistant today and now when I click an element of the GUI (e.g. to bring up the history plot of it), the history comes up but when I click in the gray background, the browser goes back a few pages to some non-home-assistant page and I have to click Forward to go back to my dashboard.
Any ideas how to fix?

Clicking away from a more info dialog causes a history back event so that people can use the back button in their browser but most importantly on Android phones.
Which browser are you using?

Interesting. I'm using Firefox 43 on Ubuntu 15.10. Back button does work but it is so much farther away than the background! ;-)
Maybe if there was a dismiss button on the more-info dialog then, or something? This has kicked me out of home-assistant about 10 times (due to habit, I guess) and it feels a little shocking/unexpected.

Well clicking the background is supposed to also work.
I just confirmed the bug on FIrefox on my Mac. Chrome and Safari work fine.

Also experiencing the same issue on Firefox. Fine on Chrome.

Where's the code that deals with this kind of thing anyway? I haven't worked on the frontend before.

url-sync.js

This problem still exists after upgrading to 0.12.0 in Firefox 44.0. No change in the behavior.

And it does still happen on the main screen, just more randomly. If you click off a few More Info tabs it eventually shoots you back in history a few pages (out of hass).

:disappointed:

This should have been fixed with the 0.13 release


flow performance

I try use flow write a simple demo,then test it's performance.it too many time cost in runtime.pthread_cond_signal.i try to use flow.RunProc() or set DefaultComponentMode,but can not find this function and field

Closing this because in 1.0 branch a different approach to channel and process management is used to improve performance


Implement maxOccurs limits (remove unbounded)

Many hard limits like 16 are in the spec.
Ideally nothing should be 'unbounded'.

PR: https://github.com/DFDLSchemas/mil-std-2045/pull/48

Fixed in 377839f82419226fc3b3462a3b64347211d62676


[A6T1][T15-B2]He Xing Darius DIP

@hesingon Some comments added. Please close the PR after reading comments.


Improve styling

Makes the UX a little easier to follow

Ok the first issue with state management is fixed, but I can't push to this PR branch atm. Working on the rest of the minor problems.


Docs metadata release should update preview package overviews to describe released packages

In cases where preview and GA versions for a package both exist the package overview for the preview version should state that there is a GA release and link to the moniker/page of the latest released version.

What should the copy be?
Will need to update preview pages on GA release via some kind of parsing (preview package overviews aren't published when GA releases for a given package today; those pages are only updated upon release of preview packages)

My stab at what a callout should say:
"The Azure <insert library/package name> for  is now generally available (GA) and fully supported for production use. More details on the GA release can be found here .

After chatting with @mario-guerra, it is probably better for the customer experience (and certainly more straightforward to automate) linking to the GA package overview. Possible text:

The Azure Tables client library for .NET is now generally available (GA) and fully supported for production use. More details on the GA release can be found in the [GA documentation](link-to-documentation)

Updated copy:
> [!IMPORTANT]
> The Azure Tables client library for .NET is now generally available (GA) and fully supported for production use. **The GA library should be used instead of this preview version to ensure you are using the most secure and performant version of the library.** More details on the GA release can be found in the [GA documentation](data.tables-readme.md)

Updated onboarding will eliminate these files which will result in automatic redirects to the latest or legacy moniker as needed. We won't need to edit markdown files in place.


Does not respond when clicked

When I click on the article circled in red, it does not respond.
I can't open the link.
http://momoclozamurai.xxxblog.jp/archives/56053029.html

Device: [Google Pixel 5]
Android Version : [Android 11]
Kiwi Browser Version [1181850297]

Other browsers can be opened without any problems.
Definitely a bug in the Kiwi Browser.
Please fix the bug immediately.


Connecting to CosmosDB emulator gives 'Unauthorized' error

Hi,
I'm trying to call a executeStoredProcedure on CosmosDb emulator, but get the following error back:
"{"code":"Unauthorized","message":"The input authorization token can't serve the request. Please check that the expected payload is built as per the protocol, and check the key being used. Server used the following payload to sign: 'post\nsprocs\ndbs/(dbname)/colls/(collectionname)/sprocs/(sprocname)\nsun, 14 may 2017 11:33:26 gmt\n\n'\r\nActivityId: 3127c606-1a19-4f39-ad5d-38d744c8490f"}"
Above, the values in parenthesis are of my database, collection and stored procedure
I'm using the MasterKey provided for the emulator: C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==
Some debugging in the SDK code shows the Authorization header value in the request as: "type%3Dmaster%26ver%3D1.0%26sig%3DgqPgawlh%2BnVD%2BKyzyxMmkl7Tb0s75erI09cRJgjzgao%3D" and it changes with every request since it likely takes a hash of text containing timestamp.
Can you please guide through this?
I'm using CosmosDb emulator version <IP_ADDRESS>.

After going through some other issues in this repository, I found a comment that the id provided shouldn't contain a trailing '/'. Maybe we need to handle it in the code and remove it if one exists?

Hi, I appreciate if you send a sample code so we can reproduce this problem.

Hi, I have same problem...
I'm using emulator version: <IP_ADDRESS> / azure-documentdb-node : 1.12.0
{ Error: self signed certificate
at Error (native)
at TLSSocket. (_tls_wrap.js:1092:38)
at emitNone (events.js:86:13)
at TLSSocket.emit (events.js:185:7)
at TLSSocket._finishInit (_tls_wrap.js:610:8)
at TLSWrap.ssl.onhandshakedone (_tls_wrap.js:440:38) code: 'DEPTH_ZERO_SELF_SIGNED_CERT' } }

@TE-yujianishiyama this is related to SSL certificate validation and is different from the authorization issue reported.
Since emulator SSL certificate is self signed, the SDK fails to validate the emulator's self signed certificate. When working with emulator you should disable SSL verification at the node SDK side to avoid this.
There is an option for this:
connectionPolicy.DisableSSLVerification
Please see this example:
https://github.com/Azure/azure-documentdb-node/blob/c4292a1170b785c2e5b525f87e19083285f6d0ed/source/test/sslVerificationTests.js#L52-L64

@moderakh  Thanks 👍 　, ｍy test code was able to run in the local environment.

@TE-yujianishiyama I am happy to hear that :-)

@moderakh
Yeah, with your link I was able to get a workaround going. Thanks.
Something like:
var documentClient = require("documentdb").DocumentClient;
var lib = require("./node_modules/documentdb/lib/");
var documentBase = lib.DocumentBase;

But honestly, I think the recommendation in #187 is better for all.

@jderus  That didn't work for me. But I found this in the sample nodejs application they provide. And it worked for me. Just setting NODE_TLS_REJECT_UNAUTHORIZED to 0. we can set this in a npm start script. That's what exactly in the sample nodejs application which comes with cosmosDB local emulator.  "scripts": {     "start": "set NODE_TLS_REJECT_UNAUTHORIZED=0&& node app.js"   },


Issue with k8s.io/docs/getting-started-guides/ubuntu/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
I've just installed a fresh system with Ubuntu 17.10. I followed the instruction in the documentation page, saying that I have to do:
sudo snap install conjure-up --classic
# re-login may be required at that point if you just installed snap utility
conjure-up kubernetes

Then I tried to start kubernetes but I received the following Python traceback:
drpaneas@ubuntu1710:~$ conjure-up kubernetes
Traceback (most recent call last):
  File "/snap/conjure-up/441/bin/conjure-up", line 11, in <module>
    load_entry_point('conjure-up==2.2.0', 'console_scripts', 'conjure-up')()
  File "/snap/conjure-up/441/lib/python3.6/site-packages/conjureup/app.py", line 238, in main
    utils.lxd_version(),
  File "/snap/conjure-up/441/lib/python3.6/site-packages/conjureup/utils.py", line 199, in lxd_version
    raise Exception("Could not determine LXD version.")
Exception: Could not determine LXD version.

The problem is that conjure-up kubernetes needs to talk to lxd but this is not installed in my system:
$ dpkg-query -l lxd
dpkg-query: no packages found matching lxd

Proposed Solution:
To have lxd as a dependency of during the installation of  snap install conjure-up --classic. Also, it should be able to start/stop the lxd by itself, add the user to the lxd group, set the correct permissions to read the unix.socket, etc ...
Page to Update:
http://kubernetes.io/...
Please update the page with working instructions. Having kubernetes in the front-page of ubuntu.com many people are going to end-up with that broken behavior.

This happens also on Ubuntu 17.04.
I've installed lxd snap, @drpaneas  any tip on how to start it as a workaround for this bug?
Thanks.


Change @w to {?} in UriMapping handlers

Since Starcounter 2.2, {?} should be used instead of @w in OntologyMap according to the release notes.

Done on develop branch


Feature: intrinsics to access allocation info for self-test

Miri already tracks allocations and deallocations. It would be convenient if, from a test, I could make assertions about those allocations.
For example, I might want to assert that a particular block of code performs no allocations. Or that it performs one allocation of a specific size and alignment.

Given that Miri now supports concurrency, this is actually non-trivial -- I think we would have to remember which thread allocates which memory, and then also take some form of snapshot at the beginning of the relevant block of code to see what changed at the end of it. Or what kind of implementation strategy did you have in mind?
Also this seems like something you could test without Miri without too much hassle, by using a custom allocator?

@RalfJung this is exactly what I did: https://docs.rs/mockalloc/0.1.0/mockalloc/
The problem is that I have to disable these checks when the tests are run under miri because they can't be used in conjunction. It would be simpler if I could just directly access this information from within the test and then always use miri.
The simplest way would be to offer something similar to the record_allocs function from that crate, which just works on the current thread.

The reason you need to disable those tests is because https://github.com/rust-lang/miri/issues/1207 is not implemented yet, so mockalloc won't work with miri?

Yeah, but I figure if miri is tracking this information anyway, it's redundant to track it twice.

I don't think Miri is tracking the right information for you though. Sure, it has a list of all allocations globally, but it has no way to tell where they have been created, and no way to check if a piece of code added more of them. Also notice that "allocation" in Miri includes "stack variable", so just counting how many allocations there are will not be useful.
The bugs listed in mockalloc, however, should all be detected by Miri already.
Basically, there is an interesting jump here:

It would be convenient if, from a test, I could make assertions about those allocations.

So this would be things like "total number of allocations", "total size", right?

For example, I might want to assert that a particular block of code performs no allocations.

This is not an assertion about the allocations, it is an assertion about the code! Could you describe what exactly you'd like to query from Miri to enable such a check?

This is not an assertion about the allocations, it is an assertion about the code!

It's an assertion about what allocations the code performs, but I think you get the idea 😛

Also notice that "allocation" in Miri includes "stack variable"

Ah OK.

Could you describe what exactly you'd like to query from Miri to enable such a check?

Some tests I'd like to write (I'll use Vec as an example since it's similar to my type):

That Vec::with_capacity(0) does not perform any allocations.
That calling Vec::push N times performs log(N) allocations.
That calling Vec::<T>::with_capacity(N) for various combinations of T and N allocates with the expected size and alignment (this Vec type stores its length and capacity inside the allocation, so that layout calculation is non-trivial).
That collect()ing from an iterator that supports size_hint() performs the expected number of allocations.
That IntoIter frees the Vec's memory once the last item has been returned from next() even if the IntoIter iterator itself has not been dropped.

This is amusing timing, but I think the following documentation-PR is also relevant here: https://github.com/rust-lang/rust/pull/79045
Anyway, tracking heap allocations is a bit harder than tracking regular allocations, since we actually have to implement some logic that runs through the list of allocations and checks their allocation-kind. This could be quite expensive if there are a lot of live allocations in general, but for testing that's ok.
I personally would like to see some miri specific introspection functions for querying various aspects of the interpreter state for testing.

It's an assertion about what allocations the code performs, but I think you get the idea stuck_out_tongue

Well, I get the idea of what you want at the top-level, but I am not actually sure which APIs you think Miri should expose for this. It would really help if you could draft a concrete example, or (even better) a concrete API that Miri should expose, with a precise spec. Right now I'd have to guess what it is you need/want.

This is amusing timing, but I think the following documentation-PR is also relevant here: rust-lang/rust#79045

All the more reason to run these kinds of tests under miri, where we can be sure these optimizations are not happening.

Since you probably already thought about this, it seems silly that I should re-do that design work.^^

I linked you to the API for mockalloc: the record_allocs function is the kind of high level API I'd want to work with.
However, I would not expect that high level API to necessarily be directly exposed by miri. It might make more sense for miri to provide lower level building blocks such that people can build these higher level APIs on top. As for what those lower level APIs look like: I don't have a design ready to give you, and I would expect that design to be more heavily influenced by the way miri works internally, than my specific requirements.
I have a few ideas:

The basic building block could be a "snapshot". A single intrinsic would be provided to generate such a snapshot. It would then be up to library code to take two snapshots and compare them to determine what a particular section of code does. Under this model it would be necessary to tag allocations with the ID of the thread that allocated them.

The basic building block could be an "event stream". You might have start/stop recording intrinsics, or it could be always recording and the intrinsic would ask for all events within a time interval. Events would need to be tagged with a thread ID.

The intrinsics could allow directly querying the miri data-structures (ie. no snapshot capability). It would be up to the library code to avoid doing things (like allocating) that would disrupt its own data collection.

I linked you to the API for mockalloc: the record_allocs function is the kind of high level API I'd want to work with.

Oh, I thought you wanted more than what mockalloc provides.
I think it'd make more sense (and be easier!) to fix https://github.com/rust-lang/miri/issues/1207 than to re-implement mockalloc.


Fresh build breaks due to outdated dependencies

Dependencies (both organizational and public) are way out of date. Default build fails as a result.
(Issue originally reported by @nicolemors)

@calebeby First priority should be diagnosis: Is this a simple dependency issue, does this require a big overhaul of the build process, etc.?
Possibly (probably?) related issue: cloudfour/core-gulp-tasks#63

@tylersticka the build seems to be working. Does it work for you?

Hmm...I also just tried this and it builds fine for me as well. 🤔
Steps I followed:

Jump into master branch and pulled the latest

Ran npm start

Is that what wasn't working for you @tylersticka?

[x] Clone fresh copy
[x] Run npm start… works! 👍
[x] Kill node_modules
[x] rm .nvmrc
[x] nvm use node (switches to v10.3.0)
[x] Run npm start again… also works! 👍

Did you change anything? 🤔
@nicolemors Can you check to see if the problem is resolved for you, too?

🤷♂ It seems to work even if I check out 5fdd23051392a9061c1a374915599f7f5493460c, which was before I made any changes.
@tylersticka @gerardo-rodriguez can we close this then?

@calebeby I think so.
@nicolemors If you encounter this again, please re-open and let us know what version of Node you're using.


Question: Factor 0.45 in focal calculation

Hello, I noticed there's a factor 0.45 on calculating focal length
// Viewer.js
updateSplatMesh = function() {

    const renderDimensions = new THREE.Vector2();

    return function() {
        if (!this.splatMesh) return;
        const splatCount = this.splatMesh.getSplatCount();
        if (splatCount > 0) {
            this.splatMesh.updateTransforms();
            this.getRenderDimensions(renderDimensions);
            this.cameraFocalLengthX = this.camera.projectionMatrix.elements[0] *
                                      this.devicePixelRatio * renderDimensions.x * 0.45; // ------ here 0.45
                                      this.cameraFocalLengthY = this.camera.projectionMatrix.elements[5] *
                                      this.devicePixelRatio * renderDimensions.y * 0.45;
            this.splatMesh.updateUniforms(renderDimensions, this.cameraFocalLengthX, this.cameraFocalLengthY);
        }
    };

}();

I am wondering what does this factor stands for?
And why not using something like 0.5 * height / tan(0.5 * fov) to calculate focalLength?
Many thanks!

Really the 0.45 should be 0.5 here, I just adjusted it to 0.45 at some point during debugging & experimenting and never changed it back because I thought it looked it good :)
Your formula 0.5 * width / tan(0.5 * fov) (altered to use width instead of height) is actually equivalent to my formula if I change 0.45 to 0.5
this.camera.projectionMatrix.elements[0] is equivalent to (2 * n) / (r - l) where n is the focal length (distance to the near plane). When that is multiplied by 0.5 and then by renderDimensions.x (which is the viewport width) you get (n * width) / (r - l). Since r - l equals width, you're left with n, which is the focal length.
The calculation for cameraFocalLengthY should yield the same result, so really I should just be passing a single value for focal length to the updateUniforms() function.

got it! thanks


addOpenGLRunpath: deprecate

Description of changes
Now that https://github.com/NixOS/nixpkgs/pull/269475 is merged, let's go ahead and

deprecate addOpenGLRunpath
update all packages (and modules) in the tree to use addDriverRunPath

It looks like the last PR didn't introduce an autoAddDriverRunpathHook helper for cuda packages. If desired, I can move it into a separate PR. See #301176
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks like by-name packages can not be used in aliases.nix? Not sure how to fix this

As #301176 already dealt with the CUDA part, I rebased and reduced the scope of this PR to addOpenGLRunpath

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4089

Thank you @Scrumplex


Bump version for release

LoadError: Package PackageAnalyzer errored during testing (exit code:<PHONE_NUMBER>)

https://github.com/JuliaEcosystem/PackageAnalyzer.jl/actions/runs/7122204188/job/19392836924?pr=95
Never seen that! Will re-run it


Logging is not saved during federated learning experiments

Bug Report
Current Behavior
The default logging directory used by the Federator in experiments is written to a directory that is not mounted by a PVC during remote training. As a result experiment data will be lost after training.
Expected behavior/code
Logging data is always written to to a non-conflicting directory or file after/during training when running in a cluster.
Environment

Python version: 3.9
PyTorch version: 1.9.1
OS: *
Kubernetes version: All
Platform: Minikube, GKE cluster

Possible Solution
Add logging directory path to the Federator.
Additional context/Screenshots

Resolved in #25


Allow remote content to have different ID

This lets you specify the id of the foreign turbo_frame tag. By default this will match the id of this turbo_frame.
This is useful if you are loading multiple turbo_frames from the same endpoint on a single page, maybe with different parameters without having duplicate IDs on the page
This would resolve #151 .
<turbo-frame id="pinned_items" foreign-id="items" src="/items?pinned=1"></turbo-frame>
<turbo-frame id="items" foreign-id="items" src="/items"></turbo-frame>
<turbo-frame id="items" src="/items"></turbo-frame> <!-- equivalent to previous turbo-frame -->

Hi @jbennett, thanks for your contribution! We don't plan to expand the Turbo frames API to accept more than one frame. If you need more complex operations, I suggest you explore Turbo streams to achieve similar things


Write unit tests

I want to reach at least 80% test coverage before releasing the bot. However we also need to cover more side effects.

Consider it done :) Test coverage is now at 84%. Since we can't possibly test everything I think this is okay.


fix: some view controllers have not been removed successfully

I was using EMPageViewController directly. When I try to reuse the view controller which has no parent view controller, I found this issue.

sorry, it is not a bug.


Glossary of terms in the spec

I was thinking that it will be amazing to define upfront some of the most important elements in the spec itself (as opposed to the docs).

See rapid-dictionary.md

Abbreviated Term
Description

RAPID
Rest API Design Profile

Term
Description

action
service-defined operation that MAY define parameters used during its execution and MAY have observable side effects and MAY return a single or collection of any type

annotation
instance of a term

atomic change set
set of update or action operations that may be are guaranteed to be isolated from other operations that may be happening at the same time

atomic operation
operation that is guaranteed to be isolated from other operations that may be happening at the same time

atomicity group
set of operations that must either all succeed or all fail

batch request
set of operations made as a single request

batch response
response containing one body part for each processed or accepted request

bound operation
operation with scope identified by its first parameter

collection
set if values having a common type

complex type
keyless nominal structured type

control information
metadata about the metamodel that defines RSDL

create operation
operation that instantiates a new entity

deep insert
create operation that includes related entities, represented using the appropriate inline representation

delete operation
operation that removes an entity

dynamic property
property that is not declared as part of a structured type's definition

entity
instance of an entity type

entity container
Type exposed by an OData service with structural properties defined by entity sets, singletons and behaviors defined by function and action imports

entity set
Structural property of an entity container specifying an entity type and with zero or more entities of that type

entity type
nominal structured types with a key that consists of one or more references to structural properties.

enumeration type
nominal type that represents a non-empty series of related values

error response
returned information from a failed operation

expand
query option indicates that related entities and stream values must be represented by value

filter
query option restricts the set of items returned

function
service-defined operation that may define parameters used during its execution, must not have observable side effects, and must return a single or collection of values defined by the same primitive, enumeration, entity, or complex type

instance
allowed value of a type

key
unique identifier of an instance in the context of an entity set

metadata
data about data

metamodel
structural, behavioral, and relational semantics of the elements used to define a model

model
informative representation of an object, person or system, including the structural, behavioral, and relational semantics

namespace
a dot-separated sequence of simple identifiers with a maximum length of 511 Unicode characters

navigation property
property of a structured type that represents an association to values of a common entity type and which may be serialized by reference or by value

nominal type
type that is referenced using its qualified name

operation
verbs (or methods) that correspond to create, read, update, and delete.

parameter
argument used to pass information into or out of an invocation of an action or function.

primitive type
predefined type, without any substructure

property
navigation or structural property

qualified name
schema unique namespace followed by a dot and a simple identifier for a model element

RAPID service
OData service that supports RAPID protocol and payloads

Rest API Design Profile
RESTful API for defining and sharing common patterns, tools, and libraries based on a simplified profile of the OData specification.

retrieval operation
read operation

schema
structural description of a model defined in a formal language

service root
URL of a service

singleton
Structural property of an entity container specifying an entity type and with zero or one entity of that type

structural property
property of a structured type that holds a single or collection of values with a common primitive, complex, or enumeration type

structured type
type are composed of zero or more structural properties and navigation properties

term
specification of an annotation that applies to one or more schema elements

type
specification of a set of allowed values of an instance of the type

unbound operation
operation with RSDL service global scope

update operation
request to update an identified resource

upsert operation
create request in the context of an update operation


Cover the function inside yield call with test

I have this saga:
export const handleGet: Saga = function*(): IterableIterator<any> {
  const merchantId: string = yield select(getMerchantId);
  const env: EnvInterface = yield getContext(SagaContextEnum.env);
  const placePickerFacade: PlacePickerFacade = yield getContext(SagaContextEnum.placePickerFacade);

  try {
    const response: StoreLocationServerResponse = yield call(() => placePickerFacade.getStoreLocations(merchantId, env.PLACE_PICKER_SESSION));
    const storeLocations: LegacyStoreLocationInterface[] = response.value;
    yield put(locationsActions.successGet(storeLocations));
  } catch (err) {
    yield put(locationsActions.errorGet(err));
  }
};

and corresponding tests for it:
it('handleGet success', () => {
    const iterable: IterableIterator<any> = handleGet(locationsActions.requestGet());
    iterable.next(fakeMerchantId);
    iterable.next(fakeEnv);
    iterable.next(placePickerFacade);
    const facadeCall: IteratorResult<any> = iterable.next();
    expect(JSON.stringify(facadeCall.value)).toEqual(JSON.stringify(call(() => placePickerFacade.getStoreLocations(fakeMerchantId, fakeEnv.STORE_ID))));
    const success: IteratorResult<any> = iterable.next({
      value: [fakeLegacyStoreLocation],
    });
    expect(JSON.stringify(success.value)).toEqual(JSON.stringify(put(locationsActions.successGet([fakeLegacyStoreLocation]))));
  });

  it('handleGet error', () => {
    const iterable: IterableIterator<any> = handleGet(locationsActions.requestGet());
    iterable.next(fakeMerchantId);
    iterable.next(fakeEnv);
    iterable.next(placePickerFacade);
    const facadeCall: IteratorResult<any> = iterable.next();
    expect(JSON.stringify(facadeCall.value)).toEqual(JSON.stringify(call(() => placePickerFacade.getStoreLocations(fakeMerchantId, fakeEnv.STORE_ID))));
    // @ts-ignore
    const fail: IteratorResult<any> = iterable.throw(new Error('Failed to fetch'));
    expect(JSON.stringify(fail.value)).toEqual(JSON.stringify(put(locationsActions.errorGet(new Error('Failed to fetch')))));
  });

The Jest coverage is telling that I did not cover the function in yield call.

Am I doing it right?

Why you use arrow function inside call effect ? You can just use:
yield call(placePickerFacade.getStoreLocations, merchantId, env.PLACE_PICKER_SESSION)

Your arrow function inside call effect is not called in test context

I don't need it to be called in the test context. I just need to pass a value to the generator using iterable.next(value), or do I?!
Also to pass the value to the result of yield call I need to call iterable.next() 2 times and 2nd time with value! Don't know why exactly!! :confused:

Closing due to inactivity.  If this is still an issue then please reply and I will reopen and try to help debug.  Thanks!


[BUG] SKBitmap.ColorSpace is always null. Unable to check for CMYK, RGB, etc.

Description
Our code needs to check whether an image is CMYK or RGB (and reject any image that is CMYK).
However, @mattleibow "explicitly set the color space to null for backwards compatibility". That is breaking things, since it now seems to be impossible (without jumping through major hoops) to check whether an image is CMYK or not.
Solution: Allow ColorSpace to return the correct value. Or provide another method for checking the color space.
Code
SKBitmap.ColorSpace

Expected Behavior
SKBitmap.ColorSpace should return correct value, instead of null.
Actual Behavior
SKBitmap.ColorSpace always returns null.
Version of SkiaSharp
2.88.3 (Current)
Last Known Good Version of SkiaSharp
Other (Please indicate in the description)
IDE / Editor
Visual Studio (Windows)
Platform / Operating System
All
Platform / Operating System Version
All
Devices
All
Relevant Screenshots
No response
Relevant Log Output
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct

We could remove that for 3.0.
You could use SKImage as well - or use SKCodec directly and SKBitmap.Decode. That will not remove the colorspace.

I just checked 3.0 and that already has the comapt line removed. Have you tried 3.x at all?

I just checked 3.0 and that already has the comapt line removed. Have you tried 3.x at all?

I haven't because 3.0 is still in a preview release. We can try it once 3.0 becomes a stable version.
Any ETA for a 3.0 stable?


design/software-architecture/solution-strategy: Text suggestions

The list "In relation to our Quality goals":

https://github.com/seedcase-project/seedcase-project/blob/d6086fe2ca077597dc7cf00db9d863055f04139e/design/software-architecture/solution-strategy.qmd#L42-L43

Do we know which established protocols that will be used yet? If yes, the could be added here. Potentially with links.

https://github.com/seedcase-project/seedcase-project/blob/d6086fe2ca077597dc7cf00db9d863055f04139e/design/software-architecture/solution-strategy.qmd#L47-L48

Second mention of Test-Driven Dev (with link to wikipedia). Should we add a post on this instead describing how we practice this? - Or add Test-Driven Dev to the post on Documentation Driven Development?

Will wait with this until #92 and #100 has been merged.

Many of these things have been fixed, are no longer relevant, or are addressed in other issues. Closing


fix(var): patch set_uri_args

set_uri_args modifies the $args variable without accessing our patched metatable. For it to work we need to invalidate our index whenever the function is called.
fix for https://github.com/Kong/kong/issues/10080

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to reproduce filtered search benchmark

Hi,
I didn't understand exactly what were the metrics in the filtered search benchmark. How did you measure precision in these benchmarks? what are the differences between the "regular" and "filtered" search?
Also, is there a way of reproducing these benchmarks, as there is for the "pure" search benchmarks? Couldn't find the configuration files for the filtered benchmark.
I would appreciate any help, thanks!

We used https://github.com/qdrant/ann-filtering-benchmark-datasets

Closing this since I believe the question has been answered. Feel free to ask any other questions related to Qdrant :)


Add PowerUnifSampler

This PR adds a utility distribution for use with hyperband.

Do you think tests are necessary here, @stephen-hoover? I'm not sure what would be a useful test for a simple sampler like this.

Yeah, it was such a small class that I hesitated to make a new module for it, but I agree that it's not really part of hyperband.
As for subclassing from rv_continuous, that would involve doing some math to figure out the pdf, cdf, etc. It's something I can do, but I'm not sure it's worth the additional time and effort, since we're not getting any additional value out of it (at least right now). I'm going to spend a little time looking for an alternate distribution that does something similar, maybe the truncated exponential: https://docs.scipy.org/doc/scipy-0.19.1/reference/generated/scipy.stats.truncexpon.html

Okay, I can agree that it's not worth the effort to make this a full scipy distribution at this time. You should put a note in the class docstring about it being similar to an rv_continuous in some ways, but not a full subclass.

I lean toward switching to the truncated exponential, and not including this in civisml-extensions at all. It will take a little more time to figure out what distributions to use in CivisML, but the scipy distribution is more fully supported and fleshed out, and it'll be easier for users to understand.

I think that sounds fine, if you think it's best. But I also think it's reasonable to add a cut-down distribution with appropriate documentation here. The truncated exponential is a different distribution from what this does.

I wouldn't mind including a cut-down distribution here if we had a strong justification for using it. But the distribution was a kind of arbitrary choice anyway, so I lean toward using an existing distribution that does something similar. I think as a CivisML user who encountered this distribution in my estimator, I might be a little confused.

Closing this and switching to a truncated exponential in CivisML.


Proposal to Simplify Code Structure in SDK for call Routines

Proposal to Simplify Code Structure in SDK for .call() Routine
Description
The existing code structure appears as follows:
let ixResponse = await logicDriver.routines.GetPosts()
let { allPosts } = (await ixResponse.result()).output;

This proposal suggests simplifying it to the following form:
let { allPosts } = await logicDriver.routines.GetPosts().unwrap();

With this proposed change, devs can use .unwrap() to directly retrieve the returned object if they are not concerned about the ixResponse data.
Comparison
This proposal draws inspiration from the approach taken by ethers.js in simplifying their call methods:
await erc20.decimals();
// you get 18

The intention is to streamline the code structure and enhance the developer experience with a more readable syntax.

resolved in https://github.com/sarvalabs/js-moi-sdk/pull/36


[wolfssl] add patch to increase default max alt name limit

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Rather than check in a large patch, can we fetch the patch directly, see how vcpkg_download_distfile is used in other ports for an example.

Thanks for the feedback, the important part of the patch involves the change to wolfssl/wolfcrypt/asn.h. I can try to adjust the patch to only change that one line.

All features passed with following triplets:
x64-windows
x64-windows-static


feat: fix some field types

Category

[ ] New feature
[x] Bug fix
[ ] Improvement
[ ] Refactor
[ ] etc

Description

To more strictly validate gRPC messages, those messages must be declared separately.

In this PR, sync_options and capability has been declared separately.

Unused import sentence has been removed

Known issue

Cool, LGTM! :)


Added ros2 service info to documentation

closes #3263
Updated the existing documentation of ROS2 services by adding ros2 service info description and example usage case.

Ah too late 😅 , but lgtm.


Fix flag processing for x/html output

name: Pull request
about: Propose changes to fix an issue or implement a new feature

Description
Fixes several problems with DITAVAL based flag processing in HTML / XHTML output:

Flag images are currently broken when a DITAVAL file is located outside of the map directory. The generated references in HTML use a relative path back to the literal source flag image (outside the scope of the output directory); the flag images are not copied.
Today, the flag copy process results in build failures under some circumstances (if the image already exists at the target location, which is often the case when a DITAVAL is in the map directory) -- reported in #3184
Flag image references are not treated consistently; how we handle relative paths (and where the images are copied) varies based on whether the DITAVAL is outside the map directory, in the map directory, or in a subdirectory of the map, resulting in unstable output

This update makes several changes to fix the issues:

Relative URIs (based on the input directory) are now created in .job.xml for flag images based on DITAVAL outside of the map directory. Previously these were missing; with only the full URI to the source image, it was impossible for processing to know where to put the image in the output.
The old flag copy routine is almost as old as DITA-OT, and relied on file lists that are mostly obsolete. With multiple DITAVAL input files, those lists also made it impossible to know how to resolve relative paths. The new routine is much simpler and should be more stable; it relies on info in the Job file to copy files.
The older copy flag is still there because it cannot be removed in a hotfix, but I've marked it deprecated.

Motivation and Context
Customers with a large number of plugins build them with a DITAVAL located in a common peer directory. When upgrading from 2.5 to 3.x, the flag images all disappeared due to a change in how file paths are calculated. This update resolves those issues.
How Has This Been Tested?
The existing filter list test in integrationTest was a very useful test; also tested with:

Content in a map directory / sub-directory, all using flags;
With those flags defined in the map directory, and with those flags defined in the map directory;
Where flags in the ditaval are in the same directory as the ditaval, and in a subdirectory of the ditaval

Type of Changes

Bug fix (non-breaking change which fixes an issue)

This could break functionality if we removed the obsolete code, but for now it is left in because custom build scripts could be calling it.
Checklist
Still want to add the complex test cases described above into integrationTest, but the code should otherwise be ready for review.

Also need to test this against #3257 (flag with absolute path) - I don't think we have a test case today for that so I'm not sure of the result.

After a lot of running in circles on the uplevels test -- I've just checked in what the result should be, but it's only working right now if the input map and input filter file do not share any common directories. Still need to work out what's going wrong with the relative path / base dir / input map variables.


Test for expected exception

Make use of pytest.raises instead of using pytest.mark.xfail
https://github.com/pymc-labs/pymc-marketing/blob/8a284dc65515e2900d7b63d0d94be8f4a02611b2/tests/test_model_builder.py#L260-L265

can you assign me?

can you assign me?

Thanks! Go ahead. Just write the "Closes #"


feat: add WASM transformer

Possibly we can move to https://github.com/tetratelabs/wazero which is pure Go with no dependency.

With WASI preview 2 being officially released https://github.com/WebAssembly/WASI/tree/main/preview2 it brings the WASM component model.
Possibly we can move to the WASM component model for marshalling and unmarshalling https://component-model.bytecodealliance.org/design/why-component-model.html

Related https://github.com/konveyor/move2kube/pull/1144

Implemented in https://github.com/konveyor/move2kube/pull/1172


How to create Machine Learning App using the FastAPI and deploying it to kubernates cluster

Proposed title of the article
How to create Machine Learning App using FastAPI and deploying it to Kubernetes cluster
Introduction paragraph (2-3 paragraphs):
FastAPI is a modern, fast (high-performance), web framework for building APIs with Python 3.6+.
Here we will build our machine learning model, after creating the model we will create an application using the FastApi which has different routes that can be used to make predictions.
After serving our machine learning model as an API, we will create a docker container for the application.
Finally, we will be able to deploy the FastAPI docker container to the Kubernetes cluster.
Key takeaways:

How to create a simple machine learning model.
How to install the FastAPI.
Serving the ML model as an API using the FastAPI.
How to create Docker Container.
Deploying the FastAPI docker container to Kubernetes cluster.

References:
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Can you give more details about the machine learning model that you will be building?

Hello @lalith1403 the model I will be building is a simple machine learning model that can predict the churn rate within a bank.
Predict if a person will leave a bank or not depending on certain inputs.

@lalith1403  this model will then be used to show how we can serve a machine learning model as an API using the FastAPI.
Thereafter we will deploy the FastAPI docker container to the Kubernetes cluster.

Yes. This is a good project. Explain each step in detail. You are covering the entire machine learning life cycle, beginning with Data preprocessing to model deployment and inference. Make sure to explain the various alternatives that one can take during each phase and your thought process.
Cc: @hectorkambow

Hello @lalith1403 should I now continue writing the article?
@hectorkambow

@Bravinsimiyu
sounds like a very helpful topic - approved 🚀


Remove ForceDryRunSigning=true

I added ForceDryRunSigning to arcade to enable use of dry run signing even when the repo thinks that its in official build modes. In those cases, it would normally only allow real signing. This needs to be removed, but requires the following:

Non-official builds should not use the repo official build IDs (should be -ci or dev or whatever)
Real signing needs to be functional across all OSes.

We could also take a piecemeal approach and remove use of the switch over time, starting with official builds where real signing is functional. Once all those are done,. then we still need to avoid setting the official build id in non-official builds to complete the removal

T-Shirt Size: XS/S
Depends on how we decide to handle non-official builds using repo official build IDs.
Will also involve part of https://github.com/dotnet/source-build/issues/4062 which requires ensuring that MicroBuild plugin is installed and functional.


Update Opportunities.md

Added bullet point for Chinese scholarship council under PhD Studentships (i think)

Thanks Joe!


Feature/conditional components

What I did in the PR:
1- I make conditional component for the reserved rockets

Congratulations :confetti_ball:
There is nothing more to add than to say it is time to merge the project


not working for me

Hello
Hope you got a minute to help - I've no idea what I'm doing wrong - in one of my sass files, I've the following code:
.test{  	@include rem(width, 40px); 	height: rem(80px);  }
what I get in the css file is:
.test{  	width: 4rem; 	height: 5rem;  }
base is set to 10 px so the width is correct - the height is calculated based on 16px - do you have any idea why this is happening?
Thanks

Hi!
Could you give me more info on how you compile your .scss? Do you use LibSass or Ruby Sass and which version? Any other post-processing stuff, like minifying?

Hello Pierre
I think I figured out what the issue is - if I import your rem mixin before
Bourbon it creates those issues - if I change the import order, it seems to
work fine - Bourbon has also a function called rem.
On Tue, Sep 15, 2015 at 5:45 AM, Pierre Burel<EMAIL_ADDRESS>wrote:

Hi!
Could you give me more info on how you compile your .scss? Do you use
LibSass or Ruby Sass and which version? Any other post-processing stuff,
like minifying?
—
Reply to this email directly or view it on GitHub
https://github.com/pierreburel/sass-rem/issues/4#issuecomment-140375970.

--
Marco M. Jaeger
http://net4visions.com

Still kind of struggling with the following code - hope you can provide
some insight:
`
$grid-gutter-width: rem(40px);
@mixin make-container($gutter: $grid-gutter-width) {
margin-right: auto;
margin-left: auto;
padding-left:  ($gutter / 2);
padding-right: ($gutter / 2);
@if $enable-flex {
} @else {
@include clearfix();
}
}`
if I set the grid-gutter like: $grid-gutter-width: rem(40px); the css
shows 4rem/2 instead of the expected 2rem - if I set the grid-gutter to
4rem everything works fine?
any idea what I'm doing wrong?
thank you again for your input.
On Tue, Sep 15, 2015 at 7:11 AM, Marco M. Jaeger<EMAIL_ADDRESS>wrote:

Hello Pierre
I think I figured out what the issue is - if I import your rem mixin
before Bourbon it creates those issues - if I change the import order, it
seems to work fine - Bourbon has also a function called rem.
On Tue, Sep 15, 2015 at 5:45 AM, Pierre Burel<EMAIL_ADDRESS>wrote:

Hi!
Could you give me more info on how you compile your .scss? Do you use
LibSass or Ruby Sass and which version? Any other post-processing stuff,
like minifying?
—
Reply to this email directly or view it on GitHub
https://github.com/pierreburel/sass-rem/issues/4#issuecomment-140375970
.

--
Marco M. Jaeger
http://net4visions.com

--
Marco M. Jaeger
http://net4visions.com

Interesting find. I would advise you to make your operations before converting (padding-left: rem($gutter / 2);), however i made a small change: now the rem function return a number instead of a list if possible.

I'll give it a try, thank you
On Wed, Sep 16, 2015 at 11:34 AM, Pierre Burel<EMAIL_ADDRESS>wrote:

Interesting find. I would advise you to make your operations before
converting (padding-left: rem($gutter / 2);), however i made a small
change: now the rem function return a number instead of a list if
possible.
—
Reply to this email directly or view it on GitHub
https://github.com/pierreburel/sass-rem/issues/4#issuecomment-140835853.

--
Marco M. Jaeger
http://net4visions.com

That did the trick - thanks again
On Wed, Sep 16, 2015 at 12:10 PM, Marco M. Jaeger<EMAIL_ADDRESS>wrote:

I'll give it a try, thank you
On Wed, Sep 16, 2015 at 11:34 AM, Pierre Burel<EMAIL_ADDRESS>wrote:

Interesting find. I would advise you to make your operations before
converting (padding-left: rem($gutter / 2);), however i made a small
change: now the rem function return a number instead of a list if
possible.
—
Reply to this email directly or view it on GitHub
https://github.com/pierreburel/sass-rem/issues/4#issuecomment-140835853
.

--
Marco M. Jaeger
http://net4visions.com

--
Marco M. Jaeger
http://net4visions.com


Fix typos

This looks good. Thank you for the PR. The typos tool looks interesting. Automating it makes sense too, but I wonder if adding it as a pre-commit hook would work better.


Update google-cloud-trace to 2.38.0

About this PR
📦 Updates com.google.cloud:google-cloud-trace from 2.3.7 to 2.38.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-trace" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.cloud", artifactId = "google-cloud-trace" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #354.


Report jetstream not enabled instead of no response from server

When calling nats account info for example we currently throw a no response from server error in the case JetStream is not enabled. In nats.go we do this check to transform this error into a not enabled error for now: https://github.com/nats-io/nats.go/blob/7623eaad8b7d2fc29e5b21fb6577dba9690e0e1f/jsm.go#L198-L200
Something similar could be done for:
https://github.com/nats-io/jsm.go/blob/83c9d5c82c54be1b378fd83d1e9ea134942caa3d/manager.go#L79
https://github.com/nats-io/jsm.go/blob/83c9d5c82c54be1b378fd83d1e9ea134942caa3d/manager.go#L274-L280

It's a lot more involved than fixing it in the above locations - since in some cases you would get no responder when for example some resource does not exist even when JS is enabled.
So I'd rather handle that error in account info only

Also fwiw, account info api does not do no responders anymore - it used to.  Now it returns error 10039 because $JS.API.> always listen.
The mix of interactions between accounts, imports, exports, domains, selective permissions etc means you just cant know if jetstream is enabled and you also cant know if a no responders mean jetstream is disabled.
For this reason in some places like account info the server now has a not enabled error (10039) and responds with that.  It's just not safe to assume no responders mean jetstream is not enabled.
So I'll close this one.

sounds good to close, in the nats.go client we do ErrJetStreamNotEnabled when no responders and then ErrNoStreamResponse when it is the result of a js.publish etc...