Snippets Not Working

Describe the bug
I have been trying to test out code snippets, and I cannot seem to get them to work.  I type in %scan and I do not see anything like the documentation suggest.
To Reproduce
This is tricky, but here is what I can tell you:

The function I am testing with is %scan because it is the one you use in your examples
I am on a Mac, but I tried this on a Windows VM and had the same issue
I have the latest version of VS Code and the latest version of the extension
I disabled ALL my extensions and ONLY enabled the Code for IBM i and I still experienced the issue
I downloaded an RPGLE file to my local drive and, when I opened it, I experienced the same issue

Expected behavior

Snippets should appear when typing a known built in RPGLE functions

Screenshots
I am getting console errors, but I am not entirely sure they are relevant:
console.ts:137 [Extension Host] DMIMATT/QRPGSRC/TESTPGM2.RPGLE
console.ts:137 [Extension Host] DMIMATT/QRPGSRC/TESTPGM2.RPGLE
log.ts:313   ERR this._getFsProvider(...).watch is not a function: TypeError: this._getFsProvider(...).watch is not a function
	at l.$watch (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:80601)
	at i._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:97:13801)
	at i._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:97:13485)
	at i._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:97:12147)
	at i._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:97:10825)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:97:8934
	at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:64:1712)
	at s.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:19002)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:112:34390
	at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:64:1712)
	at s.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:19002)
	at a._receiveMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:23583)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:21117
	at l.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:64:1712)
	at _.acceptChunk (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:15833)
	at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:72:14963
	at Socket.A (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:112:13838)
	at Socket.emit (events.js:315:20)
	at addChunk (internal/streams/readable.js:309:12)
	at readableAddChunk (internal/streams/readable.js:284:9)
	at Socket.Readable.push (internal/streams/readable.js:223:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
console.ts:137 [Extension Host] Error: Could NOT open editor for "member:/DMIMATT/QRPGSRC/TESTPGM2.RPGLE".	at D.showTextDocument (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:65822)	at processTicksAndRejections (internal/process/task_queues.js:93:5)	at async /Users/mlavinder/.vscode/extensions/halcyontechltd.code-for-ibmi-0.8.31/dist/extension.js:2:597133	at async u._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:30224)	at async u._executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:30224)

Environment (please complete the following information):

Extension version v0.8.31
IBM i OS version 7.4
VS Code Version  1.64.0
Mac Version 12.2
Windows 10 (on VM I tested with)

Additional Information
Apologies if this doesn't wind up being a bug. I have done a lot a reading up on snippets and have been experimenting because I really did not want to create this issue. I feel like I am probably missing something, but I am not sure what else I could try at this point.

Do you mean the RPGLE snippets? Because those come from a different extension: RPGLE language tools (vscode-rpgle)


Could not install this package on laravel in a MAC environment

When I require this package via composer it gives me dependency error for openssl. Now I have updated version of openssl on my mac but it is still giving this error;
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for duccio/apns-php ^1.0 -> satisfiable by duccio/apns-php[v1.0.1].
    - duccio/apns-php v1.0.1 requires lib-openssl * -> the requested linked library openssl has the wrong version installed or is missing from your system, make sure to have the extension providing it.

I is not clear from the message that which openssl version is required. Here my current version of openssl;
OpenSSL 1.0.2h  3 May 2016
Please let me know if can change any version to make it work?

i have same problem here, how to make it work?

I've been having the same problem, and I upgraded to PHP 5.6, and the error went away. Not sure if that's an option for you, but that's the only thing that fixed this for me. I used this tutorial to update php version 5.5 to 5.6


update airgap_patch image tag in doc

Signed-off-by: hang.jiang<EMAIL_ADDRESS>
What type of PR is this?

/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


docs: Fixed a couple of typos in the docs iam-eks-role module

Description
Just fix a couple small errors in the doc
Motivation and Context
💅

This PR is included in version 4.10.0 :tada:


bugfix/keyerror-at-fields-to-jsonapi-schema-rendering

The implementations out for review are used to fix KeyError happening at fields to JSON:API schema rendering due to failing logic applied due iteration. See related issue @ https://github.com/vladmunteanu/starlette-jsonapi/issues/45.

@alidaw Thanks for submitting the issue and the PR! I will take a closer look in the next couple of days.
In the meantime, any chance you could add a test that fails when this change is not applied?

The openapi support is really experimental, and I would've preferred the implementation to be done with apispec.
Sadly, that library doesn't play well with the serialization hooks implemented in marshmallow-jsonapi which is why I started playing around with a new implementation of marshmallow-jsonapi here: https://github.com/vladmunteanu/marshmallow-jsonapi-exp
Didn't have time to finish it, but I may get a chance to do that soon. If you're passionate about this subject, feel free to have a look at the marshmallow-jsonapi-exp idea. I think a much cleaner solution would be achievable by using apispec instead of the custom logic added in starlette-jsonapi.

Thx in advance! I needed to overwrite the commit I applied to fix the issue via interactive rebase. Checking if key called attributes exists in dictionary before accessing it to set requirement state of field addressed in iteration wouldn't solve the issue as the issue was caused by not ignoring the field called id there.
As the field called id according to rules guided by  JSON:API is required, it's processing must be be excluded somewhere on top of your iteration's control structure used to apply requirment state to fields being either child of property called attributes or relationships.
Otherwise, if field called id won't be excluded there and would be the first field processed in iteration where key called attributes haven't been set yet, we would run into KeyError. KeyError at key called relationships anyway won't be an issue there as you already take care to apply it only for fields of kind equaling relationship, which according to JSON:API shouldn't be the case for field called id.

In addition to the commit bearing the bug fix I've added a commit used to expand the unit tests of openapi module with three commits:

test_fields2jsonschema_conversion_if_id_first_item_iterated
test_fields2jsonschema_conversion_if_id_last_item_iterated
test_fields2jsonschema_conversion_if_id_in_between_item_iterated

The three tests run green. If I comment out the bug fix I've applied, then the tests fail with the same reason (KeyError('attributes')) as the fetching of API docs generated via starlette-jsonapi fails where call of starlette-jsonapi.openapi.JSONAPISchemaConverter.fields2jsonschema() method is involved. So the tests I've implemented prove that the bug fix I've provided would fix the issue.
Just a side note: the import from apispec.utils import validate_spec as it is part of tests.test_openapi module would make your CI test suite fail as it is not valid with the latest apispec version released and as you don't ping specific version in your requirements file the latest gets installed. So you would need to do hand on before applying the unit tests again via CI I think.


data.sha can be undefined at View diff button

Description
https://github.com/typesense/showcase-linux-commits-search/blob/c781341b83b4459c150674e03568e654e5883c2d/src/app.js#L212
https://linux-commits-search.typesense.org/?commits[query]=minecraft
click View Diff on commit 628e04dfeb4f66635c0d22cf1ad0cf427406e129
Expected Behavior
Should be gone to https://github.com/torvalds/linux/commit/628e04dfeb4f66635c0d22cf1ad0cf427406e129

Actual Behavior
Actually it goes to https://github.com/torvalds/linux/commit/undefined

Resolved by #2


Switch build-ami action to OIDC

With iterative/itops#890 we switched terraform project name from cml to packer-infra to be used also for Studio-Selfhosted packer builds. Additionaly I made a role to cooperate with OIDC.

@0x2b3bfa0 Did you wish to trigger this pipeline in PR? If yes, we need to to add this
      - .github/workflows/build-ami.yml
    pr:
      paths:
        - environment/**
        - .github/workflows/build-ami.yml

@mjasion, I only wanted to trigger it after it's merged, but also when the workflow file itself changes.


Licensing FAQ: update language around free tier for educational orgs

Link: https://www.cockroachlabs.com/docs/stable/licensing-faqs.html#i-work-for-a-non-profit-as-a-student-or-in-academia-and-i-would-like-to-use-cockroachdb-do-i-need-a-license-to-access-enterprise-features
In the above question, we point out that CockroachDB can be provided for free to select institutions. We should clarify this language to point out that the free offering is only for our on-prem deployed version of CockroachDB. We can offer discounted pricing on CockroachCloud, but it will not be free. In both cases, contacting us is the correct next step.
cc @kannanlakshmi who is figuring out next steps for CockroachCloud after a request from a prospective customer

@piyush-singh, @kannanlakshmi, how important is this update? Needed in the 19.2 timeframe?

Its nice to have but by no means blocking for 19.2 It would also be simply updating this sentence "Cockroach Labs is willing to offer CockroachDB enterprise features free of charge to select non-profit organizations and non-commercial academic projects. To learn more, please contact us."
to read "Cockroach Labs is willing to offer CockroachDB enterprise features free of charge for select non-profit organizations and non-commercial academic projects that are hosting the database themselves. To learn more, please contact us."
I think adding the phrase "hosting the database themselves" is the only change necessary and clarifies that this doesn't include cloud.


Why are embeddings of feature length 1024?

(More of a question than an issue)
The embeddings are of shape (None, 3, None, 1024). Is there any specific reason why embeddings have a size of 1024? Which hyper parameter should I change if I want to reduce the embedding size?

This is 2X the output dimension from the forward and backward LMs.  This is projection_dim  in the hyperparameters.


Onefile mode cause crash on Win7

Nuitka is very nice package tool!!!
Yeah, this is a duplicate issue referenced in https://github.com/Nuitka/Nuitka/issues/904, while the solution won't work, and I found a bug in your source code trigger the crash.
environment: Win7_x64 + python3.7 + nuitka_1.2
Just a simple helloword.py
print("helloworld")

Package it with following command:
python -m nuitka --mingw64 --onefile helloworld.py

Run helloworld.exe and then got a crash just like issues904

I tried to debug it with windbg/ida, then find out a bug in nuitka\build\static_src\HelpersFilesystemPaths.c
bool writeFileChunk(FILE_HANDLE target_file, void *chunk, size_t chunk_size) {
#if defined(_WIN32)
    return WriteFile(target_file, chunk, (DWORD)chunk_size, NULL, NULL);
#else
    size_t written = fwrite(chunk, 1, chunk_size, target_file);
    return written == chunk_size;
#endif
}

[https://learn.microsoft.com/zh-cn/windows/win32/api/fileapi/nf-fileapi-writefile](url)
In msdn it says the the lpNumberOfBytesWritten parameter cannot be NULL just on Win7!!!, so I change the sourcecode to
bool writeFileChunk(FILE_HANDLE target_file, void *chunk, size_t chunk_size) {
#if defined(_WIN32)
    DWORD writesize = 0;
    return WriteFile(target_file, chunk, (DWORD)chunk_size, &writesize, NULL);
#else
    size_t written = fwrite(chunk, 1, chunk_size, target_file);
    return written == chunk_size;
#endif
}

package helloworld.py againt and the exe print "helloworld" with no crash
This bug only affacts win7, no matter the toolchain is mingw64 or visualstudio

Thanks, that seems to be extremely helpful stuff.

This will make it into the next hotfix, 1.2.5 likely.

This was release in the mean time.

I met the same error.
I built my project on win10 to find that some win 7 could run successfully, some not.
then, I tried to build my project on win 7 which cannot run. Yes, the output .exe run successfully on the system. But when I run it on other win 7 systems, the same error happened.
my python environment is 32bit 3.8.10 with pyside2, but the win 7 system who build it is 64 bit.


NASNet-Mobile is ported

Hi!
NASNet-A-Mobile has been successfully ported to PyTorch!
https://github.com/veronikayurchuk/pretrained-models.pytorch
The results are:
Acc@1 74.080, acc@5 91.740
Hope, it would be useful!

Nice! Great work!
At some point it might be good to have those in torchvision, if we manage to retrain them from scratch (in order to keep the normalizations and preprocessing consistent with the other models in torchvision), but that might require quite some work to get those working as the official ones.


discrimination of offline and online chromatographic separation. Online does not have a output

Potenital solution - Add gradient to ChromatographicSeparationProcess class

Refactored so we don't need this. Handling fluid was made to handle both offline and online.


Convert crash quickstart to crashlytics

Fixes #486

Note that this will break one snippet include in the docs, I think we can hardcode that one back into those docs.

LGTM, merge once the docs are updated.

cl/196893034


create environment configuration

@ca7alindev Please resolve confilicts

@ca7alindev Please resolve confilicts

@evghen1 this PR should be closed in favor of #192


Update meta information in core node content pages

Description
Add specific meta descriptions, and revise titles and tags for better SEO to the following:

[ ] https://flowfuse.com/node-red/core-nodes/
[ ] https://flowfuse.com/node-red/core-nodes/batch/
[ ] https://flowfuse.com/node-red/core-nodes/catch/
[ ] https://flowfuse.com/node-red/core-nodes/change/
[ ] https://flowfuse.com/node-red/core-nodes/comment/
[ ] https://flowfuse.com/node-red/core-nodes/complete/
[ ] https://flowfuse.com/node-red/core-nodes/csv/
[ ] https://flowfuse.com/node-red/core-nodes/debug/
[ ] https://flowfuse.com/node-red/core-nodes/delay/
[ ] https://flowfuse.com/node-red/core-nodes/exec/
[ ] https://flowfuse.com/node-red/core-nodes/file/
[ ] https://flowfuse.com/node-red/core-nodes/function/
[ ] https://flowfuse.com/node-red/core-nodes/html/
[ ] https://flowfuse.com/node-red/core-nodes/httpin/
[ ] https://flowfuse.com/node-red/core-nodes/httpproxy/
[ ] https://flowfuse.com/node-red/core-nodes/httprequest/
[ ] https://flowfuse.com/node-red/core-nodes/inject/
[ ] https://flowfuse.com/node-red/core-nodes/json/
[ ] https://flowfuse.com/node-red/core-nodes/link/
[ ] https://flowfuse.com/node-red/core-nodes/mqtt/
[ ] https://flowfuse.com/node-red/core-nodes/range/
[ ] https://flowfuse.com/node-red/core-nodes/rbe/
[ ] https://flowfuse.com/node-red/core-nodes/sort/
[ ] https://flowfuse.com/node-red/core-nodes/split/
[ ] https://flowfuse.com/node-red/core-nodes/status/
[ ] https://flowfuse.com/node-red/core-nodes/switch/
[ ] https://flowfuse.com/node-red/core-nodes/tcpin/
[ ] https://flowfuse.com/node-red/core-nodes/template/
[ ] https://flowfuse.com/node-red/core-nodes/tls/
[ ] https://flowfuse.com/node-red/core-nodes/trigger/
[ ] https://flowfuse.com/node-red/core-nodes/udp/
[ ] https://flowfuse.com/node-red/core-nodes/unknown/
[ ] https://flowfuse.com/node-red/core-nodes/watch/
[ ] https://flowfuse.com/node-red/core-nodes/websocket/
[ ] https://flowfuse.com/node-red/core-nodes/xml/
[ ] https://flowfuse.com/node-red/core-nodes/yaml/

Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Hi @Hasmin-AC I'm currently working on a way to do this, it isn't possible at the moment because the files are generated automatically. I'll share the link to the PR here when I have it, so @sumitshinde-84 can update what's requested here.

I did see your comment on the write node PR, I just wanted to solve it before replying 😉

Sure @Yndira-E lets wait till its technically possible. I'm just capturing the task here so we make sure it gets done :)

@Yndira-E, it's only for the docs that will go under /node-red, right? we can add meta elements using front matter for these docs  https://flowfuse.com/docs/, correct?

@sumitshinde-84 It's only for the /core-nodes, the docs you've been writing for each node don't have a front matter, and can't have one, because all of that content is being injected to the body of those pages.
You should be able to add info to the front matter of the /docs.

This is the PR: https://github.com/FlowFuse/website/pull/2130
It's already been merged.  @sumitshinde-84, please check the description for where you need to add the information.

Oh, and the titles are created automatically based on the name of the nodes, so no need to add that.
For instance, for the inject node the generated title is: Node-RED - Inject Node


Exception after update to 1.4.0

Since updating from 1.3.0 to 1.4.0, I'm getting the following stack trace when I run eslint:
> eslint '**/*.js' --ignore-path .eslintignore

Cannot read property 'name' of undefined
TypeError: Cannot read property 'name' of undefined
    at /Users/sdavenpo/code/my-proj/node_modules/eslint-plugin-jsx-a11y/lib/rules/role-supports-aria-props.js:59:54
    at Array.forEach (native)
    at EventEmitter.JSXOpeningElement (/Users/sdavenpo/code/my-proj/node_modules/eslint-plugin-jsx-a11y/lib/rules/role-supports-aria-props.js:58:23)
    at emitOne (events.js:101:20)
    at EventEmitter.emit (events.js:188:7)
    at NodeEventGenerator.enterNode (/Users/sdavenpo/code/my-proj/node_modules/eslint/lib/util/node-event-generator.js:40:22)
    at CodePathAnalyzer.enterNode (/Users/sdavenpo/code/my-proj/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:607:23)
    at CommentEventGenerator.enterNode (/Users/sdavenpo/code/my-proj/node_modules/eslint/lib/util/comment-event-generator.js:97:23)
    at Controller.traverser.traverse.enter (/Users/sdavenpo/code/my-proj/node_modules/eslint/lib/eslint.js:886:36)
    at Controller.__execute (/Users/sdavenpo/code/my-proj/node_modules/eslint/node_modules/estraverse/estraverse.js:397:31)

Any ideas? FWIW I'm running nodejs 6.2.1.

Think I may have a fix for this given limited info. There are multiple different types of attributes, but this is assuming that the name property is only one of them. Your code may be using a component with a different naming convention, so I am going to fix in next couple mins and then we can re-test. Thanks for reporting!

My hypothesis was wrong, hmm. Is there any other info you can dig up about the context of the error?

Ah it could be failing on a spread props. Are you using that in the code?
<div {...props} />

v1.4.1 published, can you try running again and see if it's fixed? Thanks!

@SethDavenport can we close?


[CI/CD] Pushed Image to AWS ECR

Hi @kunalrawat425
Thank you for your contribution
I'm checking your work 😁

I edited some code from your original and created a new PR (because I cannot direct edit from your repo).
Please refer to #512.


Extension members are returned as members of current modules

Close #234.

This only deals with intrinsic type extensions right?

I guess not. I think Intrinsic type extensions are exposed as normal members.

Yeah they are, just checking :-)
Annoyingly types and methods with [<Extension>] are not considered to be type extensions :-(


add help text for range officers about usage

simple help text renders based on plan end date vs agreement date, explains usage to range officers.

@calebissharp can you check out this commit and see if prettier on your machine sees what the gh action prettier does here?  i'm gonna run home and swap machines

@micheal-w-wells Nope, works fine for me locally. In the github actions config, you should run npm ci first so that prettier is installed. That should fix it.

Also, I think npm run prettier is the wrong script, since it will actually write to the files, instead of throwing an error. npm run pretest seems to do the job though.


Changed note about AllUsers

https://github.com/MicrosoftDocs/windows-powershell-docs/issues/344

@dariomws306 @tseward
Peer review needed for this PR. Thanks.

I don't have a 1709 machine or below to try it with, but if @get-itips has tested this to be accurate, I'm good with the change.

Super agree with Trevor.

@AndreaBarr This PR that has passed peer review can be merged. Thanks.


Stop making microbatch batches with filters that will never have any rows

Resolves #10824
Our logic previously created batches for each batch period where batch_start <= event_end_time.  The two statements in that filter would logicially exclude each other meaning that 0 rows would be selected always. Thus we've changed the batch creation logic to be batch_start < event_end_time (as opposed to <=), which stops the bad batch filter from being a possibility.
Checklist

[X] I have read the contributing guide and understand what's expected of me.
[X] I have run this code in development, and it appears to resolve the stated issue.
[X] This PR includes tests, or tests are not required or relevant for this PR.
[X] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[X] This PR includes type annotations for new and modified functions.

One outstanding question is...
what should happen if you have a lookback=2, batch_size=day, an --event-time-end "2024-05-26", and don't specify an --event-time-start?  If we want (1) to happen we'll need to make a change to the start time calculation here. Basically we'd do something like
if MicrobatchBuilder.truncate_timestamp(checkpoint, batch_size) == checkpoint:
  lookback += 1

start = MicrobatchBuilder.offset_timestamp(checkpoint, batch_size, -1 * lookback)

One outstanding question is...
what should happen if you have a lookback=2, batch_size=day, an --event-time-end "2024-05-26", and don't specify an --event-time-start?

Thinking about it more, I think we should go with option (1) that I laid out. That being three batches:

2024-05-23 00:00:00 <= event_time < 2024-05-24 00:00:00
2024-05-24 00:00:00 <= event_time < 2024-05-25 00:00:00
2024-05-25 00:00:00 <= event_time < 2024-05-26 00:00:00

The reason I think we should go that direction is because I asked myself what I would expect to happen if an automated job kicked off that model 2024-05-26 00:00:00. In that scenario I would expect it to run the previous day 2024-05-25 00:00:00 <= event_time < 2024-05-26 00:00:00 and then. the prior two days as well. If that is what we'd expect to happen in that scenario, then it is reasonable to extend that expectation if one specifies that timestamp via --event-time-end.


[Pipelines] Greatly simplified the "Create Reusable Components" tutorial

The recently added artifact passing feature makes data passing and component development much simpler.
Updating the tutorials.

This change is

/cc @amygdala

/cc @sarahmaddox

/assign

Preview:

https://deploy-preview-1277--competent-brattain-de2d6d.netlify.com/docs/pipelines/reference/component-spec/
https://deploy-preview-1277--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/best-practices/
https://deploy-preview-1277--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/component-development/

Thanks @Ark-kun This LGTM. I'll approve and apply a hold in case @amygdala has any further comments.
/lgtm
/approve
/hold

/hold cancel
(Not sure that will work, Sarah might have to do..)
LGTM, though I think there is still one place where inputValue should be inputPath ? -- see my comment above.

LGTM, though I think there is still one place where inputValue should be inputPath ? -- see my comment above.

Sorry, I missed that one. It's now merged in https://github.com/kubeflow/website/pull/1286


Getting Error 21205

Hi, I cloned this project and I am getting this error:
localhost:3000 says
{"readyState":4,"responseText":"{"status":400,"code":21205,"moreInfo":"https://www.twilio.com/docs/errors/21205\"}","responseJSON":{"status":400,"code":21205,"moreInfo":"https://www.twilio.com/docs/errors/21205"},"status":500,"statusText":"Internal Server Error"}
I double checked ngrok and it is fwding on port 3000:
Session Status                online
Account                       Twilio (Plan: Twilio)
Version                       2.3.35
Region                        United States (us)
Web Interface                 http://<IP_ADDRESS>:4040
Forwarding                    http://1668b3b4.ngrok.io -> http://localhost:3000
Forwarding                    https://1668b3b4.ngrok.io -> http://localhost:3000
Connections                   ttl     opn     rt1     rt5     p50     p90
0       0       0.00    0.00    0.00    0.00
How can I troubleshoot further this issue?
Thanks!
Al

I have the same issue!


Github action // Error: error running container

Bug report
Describe the bug
Hi @sweatybridge,
I'm trying to create an action to generate automatically db types and based my dev on this project
I can't get more than Error: error running container
Here's what I'm using :
    - name: "Generate database typescript types"
      shell: bash
      env:
        SUPABASE_REF_ID: ${{ inputs.SUPABASE_REF_ID }}
        SUPABASE_ACCESS_TOKEN: ${{ inputs.SUPABASE_ACCESS_TOKEN }}
        DB_PASSWORD: ${{ inputs.DB_PASSWORD }}
        OUTPUT_PATH: ${{ inputs.OUTPUT_PATH }}
      run: |
        supabase link --project-ref ${SUPABASE_REF_ID} --password ${DB_PASSWORD}
        supabase gen types typescript --db-url 'postgresql://postgres:${DB_PASSWORD}@db.${SUPABASE_REF_ID}.supabase.co:5432/postgres' > ${OUTPUT_PATH}

Can you help about it ?
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Use it as an action :
    steps:
      - uses: alex-galey/generate-supabase-db-types-github-action@supabase-cli
        with:
            SUPABASE_REF_ID: ${{ secrets.SUPABASE_REF_ID }}
            SUPABASE_ACCESS_TOKEN: ${{ secrets.SUPABASE_ACCESS_TOKEN }}
            DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
            OUTPUT_PATH: db.types.ts

Expected behavior
The Github action generates db.types.ts
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: ubuntu-latest from Github action
Version of supabase-js: 1.4.6

Hi @alex-galey , I think the problem is with this line
supabase gen types typescript --db-url 'postgresql://postgres:${DB_PASSWORD}@db.${SUPABASE_REF_ID}.supabase.co:5432/postgres' > ${OUTPUT_PATH}

You need to use double quote instead for environment variable to be substituted in bash scripts.
Another tip is to use the pgbouncer port 6543 for better connection pooling. Users might be denied access when opening too many connections with the default postgres port.

Thanks @sweatybridge, this made it work ! I also followed your recommendation to use pg_bouncer


direct registry stops working as it doesn't support env tag

We have an issue fixed in the service discovery that the tag is not part of the cache. https://github.com/networknt/light-4j/issues/482
After the fix, it seems that the direct registry stops working as the tag is not supported in it. I have fixed the test case for the light-router in the following issue to disable the tag in the header.
https://github.com/networknt/light-router/issues/49
Also, I have received a report that the user application fails with a direct registry in the dev environment.
We need to figure out why the direct registry fails and see if we can enhance it to mimic the feature of Consul Registry.

 direct registry stops working as it doesn't support env tag


Best way to make edges of world to act like walls?

I have a matter world that takes up the size of the page. As the size of the page can change, I reposition the four walls at the edges of the page. There's not a true way to set the size of a body, so I do some math to scale the four walls to the size of the page.
This seems pretty convoluted for something that probably could be calculated while updating other bodies.
I tried clamping the other bodies positions to the edges of the page, this works, except bodies seem to continue gaining velocity / inertia as they are technically free-falling. I am not familiar with physics to know what to do with the bodies velocity and inertia to mimic hitting a figurative wall.

Could you share your code? I don't really follow the problem here.

It sounds like the way you're doing it is what I'd suggest, but you can make it a bit easier by making the rectangles extremely large (so effectively a pseudo-plane) then you don't need to resize them, just move them offset by half their bounding box.

It sounds like the way you're doing it is what I'd suggest, but you can make it a bit easier by making the rectangles extremely large (so effectively a pseudo-plane) then you don't need to resize them, just move them offset by half their bounding box.

I don't know why I didn't think about that, its much simpler now, requires no scaling.
Setup:
const thickness = Number.MAX_SAFE_INTEGER
const floor = Matter.Bodies.rectangle(0, 0, thickness, thickness, { isStatic: true })
const left = Matter.Bodies.rectangle(0, 0, thickness, thickness, { isStatic: true })
const right = Matter.Bodies.rectangle(0, 0, thickness, thickness, { isStatic: true })
const ceil = Matter.Bodies.rectangle(0, 0, thickness, thickness, { isStatic: true })

Position: (I do this before updating the engine, you could use the window resize event, but I've found it does not always update the values before calling the event.)
const width = window.innerWidth
const height = window.innerHeight
Matter.Body.setPosition(floor, { x: width / 2, y: height + thickness / 2 })
Matter.Body.setPosition(left, { x: -thickness / 2, y: height / 2 })
Matter.Body.setPosition(right, { x: width + thickness / 2, y: height / 2 })
Matter.Body.setPosition(ceil, { x: width / 2, y: -thickness / 2 })

I still think there should be a setting for this effect though.

I think as a physics engine that feature would be a little too specific to a certain use case which I'd rather avoid, but it might make for a good example in future so will keep in mind!


Finalize repo QA compliance

As part of the TM issue https://github.com/api3dao/tasks/issues/849 for QA, some requirements need to be addressed:
Repo setup requirements as per new_repo_creation_checklist.md:

[x] Add repo link to some relevant page if applicable (e.g. api3 docs, npm package link, ...)
[ ] Add the relevant license file (LICENSE) consistent with the organizational standards or project requirements.

Docs being updated here


Name item bug 1.13

What is the output link of /viaversion dump?
https://dump.viaversion.com/0be744b0757cc4bc85101aeadf8c0f1f1bce467a052b87fa1fa430d25d436cc4
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
ViaVersion works under Spigot, but server works using BungeeCord
How does this error happen? login? Using an item?
All the item names have &o by default. Please fix it or add this feature like they have it on Hypixel.
Is there an error in the console? Use pastebin.com. Is there a kick message?
Nope

This was fixed #888


Skipping upload of existing files

App Id:d3q0md74ypfwe9
Region:eu-west-2
Step:Deploy
Status:Succeded
Issue/question
During deployment of my react application I faced with next situation. Some static files haven't uploaded. I can't get some images from /static/media/... So, how to fix it?

Here my redirects

and my amplify.yml
version: 0.1
frontend:
  phases:
    preBuild:
      commands:
        - yarn install
        - yarn lint
    build:
      commands:
        - yarn run build
  artifacts:
    baseDirectory: build
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

@AntonBurduzha those files should already exist as they got deployed the first time.

@swaminator it seems everything is working now, i don't know what was the problem, but during for a few hours i can't get some images. Thanks for your time, though


Don't use whilecard (*) for Access-Control-Allow-Origin

I've noticed CORS messages when using jskos-server on some browsers (especially Safari). Not sure if there's anything to it, but it might be good to investigate a little.

Will be reopened if there's an actual example.

Seems like the * wildcard for Access-Control-Allow-Origin is only meant for development purposes and should not be used in production. Safari (and maybe Firefox) actually blocks certain requests if the wildcard is used. So instead of using the wildcard (here), we should just return the origin of the request in that header (basically a whitelist for all origins), similar to what we're doing in login-server. This should fix the error.

See also:

https://stackoverflow.com/a/49346957
https://github.com/monsur/CORSinAction/blob/master/ch07/listing-7.1/app.js#L46-L57

Fix is in dev, will be included in the next release (no need to release a new version specifically for this issue).


Use smt instead of iavl

Currently we're using a version cosmos-sdk that only supports an iavl, in the future we will want to use a sparse merkle tree instead, as it is more conducive to state fraud proofs. Ideally we could do this before mainnet, so that syncing from scratch is significantly easier since the we wouldn't have to migrate the entire state db at the upgrade height.

This depends on the work being done on https://github.com/celestiaorg/iavl/issues/1
we might only need to switch to a modified version of the iavl.

closing for now, as we should be able to use the standard version of the iavl


Error toast notification shows only 'X' icon with no message.

Describe the bug
When I was creating a new story, I have filled all the fields except the description field. It gives an error by showing a toast notification having only the 'X' icon with no error message. Just like the below image:
Actual Behavior

Expected behavior

In the above image, The Toast has the error message along with the icon. It enhances the understandability of the user.
To Reproduce
Steps to reproduce the behavior:

Sign in to your account.
click on the 'new story' button which is at the top-right corner.
Try to fill out the form except for the description field. Then click on the submit button.

Environment (please complete the following information):

OS: Windows 10
Browser: Chrome

Hi, Can I take upon this issue? @dikshashukla455 @cyntss


Update flakey test for no-selected-start-before-selected-end

What's this fix?
Fixes the breaking test in master from merged in PR #1608
What happened?
The broken test was validating that a change in end date would call deleteModifier for no-selected-start-before-selected-end on all visible days. Turns out the test was flakey because the visible days object calculated by DayPickerRangeController is determined by the initialVisibleMonthThunk.
const initialVisibleMonthThunk = initialVisibleMonth || (
   startDate ? () => startDate : () => this.today
);

DayPickerRangeController.jsx Line 1065.
The default initialVisibleMonthThunk does not take into account a passed in end date and by defaulting to today, the test cannot rely on a hardcoded number of times that deleteModifier will run. This isn't a major issue since DayPickerRangeController is most likely consumed by using the DateRangePicker kitchen sink that determines initialVisibleMonthThunk like so
const initialVisibleMonthThunk = initialVisibleMonth || (
    () => (startDate || endDate || moment())
);

DayPickerRangeController.jsx Line 460.
Happy to update the default of DayPickerRangeController to match the default on the DateRangePicker for both consistency and expected behavior, but wanted to prioritize fixing the flakey test for now.
Let me know if this works @majapw @ljharb! 😁

@ljharb Would we be able to merge and publish a new minor? I feel some slight nervousness for being the pull request that is breaking master right now 😅

No need to publish anything just for tests; I’m going to defer to @majapw to merge this tho.


[FIM] Does not delete spaces on the left of the cursor

Example to reproduce:
def random_points_in_square(N: int = 100, square_size: float = 1):
    """
    Square is center [-square_size/2, square_size/2]
    """
    points = []
    for a in range(N):
        x = random.random() * square_size - square_size / 2
        y = random.random() * square_size - square_size / 2
        points.append(Point2d(x, y))
・・|

2-3 spaces at the end. After hitting Space:

Tab does not delete spaces to the left.

Prompt looks like this:

Means JB plugin did not delete spaces to the left before sending the request.

...but in other cases, it tries to do the right thing:

But that behavior is hard to reproduce, one out of 20 attempts?


wt.exe --window argument now available

Just updated the store version of Windows Terminal and the --window argument now works for naming windows, and targeting them.

Docs Build status updates of commit 695b2ae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Good catch, thanks!


Supports Fastify versions 5.x

npm warn While resolving<EMAIL_ADDRESS>npm warn Found<EMAIL_ADDRESS>npm warn node_modules/fastify
npm warn<EMAIL_ADDRESS>from the root project
npm warn
npm warn Could not resolve dependency:
npm warn peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm warn node_modules/fastify-socket.io
npm warn<EMAIL_ADDRESS>from the root project
npm warn
npm warn Conflicting peer dependency<EMAIL_ADDRESS>npm warn node_modules/fastify
npm warn   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm warn   node_modules/fastify-socket.io
npm warn<EMAIL_ADDRESS>from the root project

https://github.com/ducktors/fastify-socket.io/issues/177


Rating Widget: Add Read-Only

Added the Read-Only property with a description to the Properties table for the Rating widget. Resolves #496

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Throw error when account password is empty

Accounts with empty passwords lock MuleQueue indefinitely. An account load error should be displayed instead.

This has been released in v0.7.5.


Update extend-zowe-overview.md

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)
Please describe your pull request.
:heart:Thank you!

Thanks Ashley. We're creating a story to do this review.
Andrew
On Mon, Nov 9, 2020 at 10:02 AM nannanli<EMAIL_ADDRESS>wrote:

@nannanli https://github.com/nannanli requested your review on: #1464
https://github.com/zowe/docs-site/pull/1464 Update
extend-zowe-overview.md.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/zowe/docs-site/pull/1464#event-3972605542, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJESEG4R2H2SHCQ7MMTJQ43SO6VYRANCNFSM4TJAWNDA
.

--
Andrew Jandacek
Technical Writer | Mainframe Software Division
Easytrieve, Pan/SQL, Telon, CA Brightside, Zowe API Mediation Layer
Broadcom
V Parku 2308/8 | Prague, 148 00 | Czech Republic
(+420) 226 207 674 | broadcom.com

@janan07 I had time to make some edits, just for some grammar and minor details re the CLI. Didn't quite make it to the bottom of the doc, and in some cases left things like passive voice bc I wasn't sure how to accurately rewrite.

The PR updates the information Re: API ML in this overview article and removes inaccuracies.


Bad error message when GUNW file missing in S3 bucket

When running RAiDER in HyP3 independently against a previous INSAR_ISCE job, RAiDER looks for a GUNW product in the provided S3 bucket and job_id prefix. However, there are cases where there won't be a GUNW product in the bucket, such as:

the INSAR_ISCE job failed on the DockerizedTopsApp step and so no GUNW was produced
the ARIA_RAIDER job was provided a job_id for a different job type which does not produce a GUNW

When this happens, aws.get_s3_file returns None here:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L523
and then either:

for the HRRR model, the None gets converted to the string 'None'  which becomes the GUNW ID:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L525-L527
and this line
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L528
raises an exception like:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/opt/conda/envs/RAiDER/lib/python3.12/site-packages/RAiDER/cli/__main__.py", line 44, in <module>
  main()
File "/opt/conda/envs/RAiDER/lib/python3.12/site-packages/RAiDER/cli/__main__.py", line 40, in main
  process_entry_point.load()()
File "/opt/conda/envs/RAiDER/lib/python3.12/site-packages/RAiDER/cli/raider.py", line 539, in calcDelaysGUNW
  if not RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation(gunw_id):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/RAiDER/lib/python3.12/site-packages/RAiDER/aria/prepFromGUNW.py", line 61, in check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation
  ref_acq_time = _get_acq_time_from_gunw_id(gunw_id, 'reference')
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/conda/envs/RAiDER/lib/python3.12/site-packages/RAiDER/aria/prepFromGUNW.py", line 36, in _get_acq_time_from_gunw_id
  date_tokens = tokens[6].split('_')
                ~~~~~~^^^
IndexError: list index out of range

for other weather models, it likely fails similarly opaquely in these lines:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L533-L542
either when checking the weather model availability or trying to load the GUNW ingest JSON file. If somehow it manages to get through all that, then it will raise this exception, which still doesn't explain the problem adequately:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L544-L545

Ideally, an exception would be thrown like:
if iargs.file is None:
    raise ValueError(f'GUNW product file could not be found in  s3://{iargs.bucket}/{iargs.bucket_prefix}')

here:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L523
And an:
if json_file_path is None:
    raise ValueError(f'GUNW metadata file could not be found in  s3://{iargs.bucket}/{iargs.bucket_prefix}')

here:
https://github.com/jhkennedy/RAiDER/blob/dev/tools/RAiDER/cli/raider.py#L539

Hi, I'm working on a PR to add your improve error messages and right now I'm writing tests to make sure they are triggered instead of the old error from now on. Can you please send steps to reproduce the error so I can put it into the tests?

@bbuzz31 do you have an example yaml that calls a GUNW product that would work for testing this? I think the only thing we really need is a yaml that references a GUNW product directly.

@cmarshak can you chime in?

This is reproduced on the cloud and can't be reproduced exactly locally  - tests for this would be mocked (see the GUNW tests for examples).
I wouldn't recommend doing this right now; Joe did an excellent job documenting the roadmap to fix this.

@garlic-os to see the happy path, you can use this ARIA GUNW job for the next 5 days (expires 2024-07-07T00:00:00+00:00)
You can list the files for this job like:
aws s3 ls --no-sign-request s3://hyp3-tibet-jpl-contentbucket-81rn23hp7ppf/53ad52c3-51fa-43a9-af9c-5cd3d1481437/

(After it expires, you can have @cmarshak show you how to run/find new ones)
Likewise, for the failure case, you can use this ARIA GUNW job since it's expired and the GUNW .nc and .json files have been deleted, but the browse image remains.
aws s3 ls --no-sign-request s3://hyp3-tibet-jpl-contentbucket-81rn23hp7ppf/668d2ef5-b2a5-4fa7-9d86-9b88a864d824/

But yes, for adding an integration test, @cmarshak is right; you'll want to mock similar to the GUNW tests or stage test cases in a testing bucket somewhere.

Thanks for the info, folks. I'm getting a 401 Not Authorized on both those job links. Is there something I need to do to authenticate?

Yes, you need an ASF cookie which you can get by signing into Vertex with an Earthdata Login. You can also use the job UUID (bucket prefix) and the HyP3 SDK
I think you only really need the info in the S3 path: --bucket and UUID for --input-bucket-prefix.
Note: RAiDER will bonk when trying to upload the final product to --bucket and --prefix as you won't have permission for that unless you set up an S3 bucket specific for testing.

Thanks again for your advice everyone. I have code + tests ready in #658 now, and I went ahead and marked that PR ready for review.


Self-signed SSL certificate failures

HTTPS connections that use self-signed SSL certificates return CERTIFICATE_VERIFY_FAILED.
It would be beneficial to have an override option for request HTTP headers verify=False or to provide verify='/path/to/certfile'.

Dup of #21


Add tests

Add some missing unit tests to the function :

EscapeCharactersTextTransformer

InversionTextTransformer

Add moke tests  to the function:

CreateTextTransformer

Added 10 mock tests.

Reviewed changes, added unit tests to the TextTransformerCreator and merged changes.


Add fusion as possible extension

The neos-project(http://neos.io/) has it's own intermediate language called fusion which will be more and more dominant in NeosCMS projects (and maybe also Flow-Framework(the underlying framework)).
So it would be very nice if ag would be able to find contents in this files, I think it would be helpful for many people as the amount of developers for NeosCMS is growing more and more.
Thx!

Any chance to get t his merged @ggreer ?


Excerpt for Article Pages

Implement an Excerpt function to provide an excerpt for Article previews in Article Lists (and a target for the Continue Reading link).

Completed.


Smart Apply: Enable in other clients based on client capabilities

Description
The Smart Apply functionality should be OK to enable in other clients as:

We have a generic UI that should work in any webview client. PR: https://github.com/sourcegraph/cody/pull/5188
It proxies from chat to inline edit, so any client that has the edit capability should be able to use this

Test plan
Test in other clients that have the Edit capability

https://github.com/user-attachments/assets/20927704-b3d2-4b3a-931a-a09c38768af4
Seems to be working in JetBrains. (I see to have no styles though)
Tagging @sourcegraph/jetbrains-plugin for a review and help testing

@mkondratek Thanks for taking a look!

the action texts should not be visible

The UI changes are intentional here, we do actually want to make "Copy" and "Apply" more visible. These are likely to be more higher frequency actions that the other ones (Copy is used way more from looking at usage data, Apply is looking that way too)
I'll tag @danielmarquespt on this too for 👀 when he's back from PTO, the UI change is also behind a feature flag so I don't think we should block this though (we can quickly revert if necessary).
It does seem that we are missing some code block styles though, the action buttons look way different to VS Code:

I wonder if we're missing some styles somewhere? 🤔


Fix a number of issues with emitted code

I apologize for the girth of this.  It can be reviewed commit-by-commit, and we can break it up for merging.  In the middle is a "DNM" commit with gengo changes.  If you are good with those I will PR gengo.
Notable changes:

Don't validate private fields
Don't emit code for types with no validations
Emit fatal validation code first
Use anonymous functions with early returns to implement fatal in the face of nil-checks for pointer fields
Don't emit nil-checks over and over

This removes some arguments used internally in favor of hard-coding value and field path variable names.  IMO, it is simpler - can debate! :)

Re-pushed with comments addressed and update-codegen run.


[YUNIKORN-1851] Don't allow similar app ids by different users

What is this PR for?
Detect same app ids being used by different users for app submission and don't allow when app is already running. By default, this check has been disabled (configurable).
What type of PR is it?

[ ] - Bug Fix

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1851
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

I think this might be a case of the cure being worse than the disease. Shared environments like this are somewhat cooperative by nature, and reusing app ids can happen either accidentally or even automatically (especially for the autogenerated app id). Rejecting a pod in this case is very heavy-handed and will result in unexpected failures. Tracking users by app instead of pod leads to this (IMO small) issue, but I don't think we should disallow behavior that Kubernetes allows -- we should strive to be more compatible, not less.
I don't see this issue being much worse than the ambiguity we have in the case of group quotas and multiple possible matches. It's not perfect, but probably good enough.
I'm -1 on this approach due to the pain it will likely cause.

reusing app ids can happen either accidentally or even automatically (especially for the autogenerated app id)

This does not affect re-using application IDs. You can still do that without a problem. If the application is not currently known in the shim the user info will be set without question. For the auto generated app ID: I do think that is a case we need to handle and not reject.

Tracking users by app instead of pod leads to this (IMO small) issue, but I don't think we should disallow behavior that Kubernetes allows -- we should strive to be more compatible, not less.

K8s does not have the concept of applications and or users on a workload so we have no compatibility look at. Looking at a simple case: I could set a Spark application ID on a pod as a completely different user, in a different namespace with a different service account etc. That pod will then be run as part of the already running Spark job in a queue which I might not have access to under a different quota. That is a huge gap which will show up as a problem. I am surprised that it has not as yet.

I don't see this issue being much worse than the ambiguity we have in the case of group quotas and multiple possible matches. It's not perfect, but probably good enough.

The group resolution is defined and far less of a problem than this is.
The reason for adding this is that we have seen abuse similar to this on YARN years ago. We have to put mitigations in place. Even if they are off by default but we need to have them.

We need to be careful about this one. https://issues.apache.org/jira/browse/YUNIKORN-1961 was filed a few days ago that indicates that Spark uses different auth info when submitting executor pods, so somehow we need to take that into acccount here.

Closing this for now. We can't make this change, as it will break a lot of things (including Spark) as executors are launched using different security credentials (the spark service account) than the original driver.


incorrect css/css-module-imports do not cause type-errors

Describe the bug
Vite declares modules with wildcards in client.d.ts.
declare module '*.module.css' {
  const classes: CSSModuleClasses
  export default classes
}

and
declare module '*.css' {
  /**
   * @deprecated Use `import style from './style.css?inline'` instead.
   */
  const css: string
  export default css
}

These cause typescript to not be able to catch an incorrect css-module import, which is very bug-prone.

It's highly likely this is a duplicate issue, but I was not able to find it.
Reproduction
https://github.com/bigmistqke/vite-css-module-incorrect-path-bug
Steps to reproduce

yarn create vite
choose vanilla vite
choose typescript
cd into the repo
yarn install
go to src/main.ts
add an incorrect css or css-module import at the top of the file
notice how it does not produce a type-error.

System Info
System:
    OS: macOS 13.3.1
    CPU: (8) arm64 Apple M2
    Memory: 108.94 MB / 24.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 18.12.1 - ~/.volta/tools/image/node/18.12.1/bin/node
    Yarn: 3.4.1 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 8.19.2 - ~/.volta/tools/image/node/18.12.1/bin/npm
  Browsers:
    Chrome: 112.0.5615.121
    Safari: 16.4

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

TypeScript can't detect specific css files to provide path check as a normal .ts file but only with a https://www.typescriptlang.org/docs/handbook/modules.html#wildcard-module-declarations. However, you can leverage https://www.npmjs.com/package/typescript-plugin-css-modules as a typescript plugin to check CSS modules paths. While you need to copy the original vite-env.d.ts and remove *.module.css definition by yourself.

Yes, I'd prefer going with the typescript plugin approach for now. I don't think there's a middle ground where Vite can provide this ootb without extra dependencies.


Update Boost to 1.83

I got rid of the submodule.

Boost locale has different platform implementations, including a WinAPI provider for Windows. It looks like these platform implementations are recent-ish (Our submodule version was 4 years out of date). These platform implementations aren't header-only, you need the src implementations to go with them.
I'd investigate using something like boost-cmake which lets you cherry-pick the various boost modules we require. It has an automated downloader for boost. We can also use rules_boost for bazel.

@mwilsnd I used the scripts/update-boost.sh script here.
Will updating to a slightly less recent Boost resolve the issue you think?

        using Md = describe::describe_members<T, describe::mod_any_access>;

        mp11::mp_for_each<Md>([&](auto D){

            boost::hash_combine( r, v.*D.pointer );

        });

Results in:
/Users/ec2-user/actions-runner/_work/maplibre-native/maplibre-native/vendor/boost/include/boost/container_hash/hash.hpp:431:27: error: Use of undeclared identifier 'Md'
        mp11::mp_for_each<Md>([&](auto D){

Just saw this on the phone. ICU update may be tricky as Qt uses an older one by default.
Does the code still compile without any API changes? Then I guess we're fine (as we use system ICU).

@ntadej I think ICU is stable as a rock. We'll see :)


refactor(env): simplify ternary statement for dsync feature flag

This PR addresses a code style issues in the env.ts configuration file. Previously, you were using an unneeded ternary statement to set the flag. However, this can be simplified to a single logical NOT operation.
To improve readability, we've updated the code to avoid the unneeded ternary statement.
Changes include:

Updating the feature flag in env.ts to use a logical NOT operation instead of a ternary statement.

This change should make the code in env.ts easier to read and maintain.

I am in a place with slow internet i will fix the errors tomorrow.

I have made the changes as suggested by @ukrocks007. Please check.


Caravan does not recognize Ledger policyHmacs from imported Unchained wallet config files

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request

Expected Behavior
When I load up my wallet configuration file, I expect any ledgerPolicyHmacs in my wallet config file to be brought over and fully imported into Caravan as well.,
Current Behavior
Currently, in order to successfully sign with my Ledger in Caravan, I must re-register the device as the ledgerPolicyHmac for my multisig wallet does not carry over. If I don't re-register, I receive Ledger device: UNKNOWN_ERROR (0xb008)
Possible Solution
I am unsure about the solution, but I feel it's worth calling out.
Steps to Reproduce (for bugs)

Register a Ledger with an Unchained vault
Download the config file, and examine it to ensure the policyHac is in the file
Import the file into Caravan and proceed without registering Ledger again
Attempt to sign and receive Ledger device: UNKNOWN_ERROR (0xb008)

Environment

Where are you running caravan:  unchained-capital.github.io
Operating system: Mac
Browser and version: Chrome

Ordering and naming were previously an issue but should be resolved now.


SBOM maven pom.xml reading logic replaced with maven-plugin tool

Reverts siemens/continuous-clearing#53

redundant


[FEATURE] Adoption of React Query

Why do we need this improvement?
Background
Fetching data is one of the very complex problems in the react ecosystem, we have so many tools and frameworks trying and competing to tackle this problem.
How does NextJS handle this problem? They did this by aggressively caching everything & overwriting the fetch specification and introducing cache as the default behavior, that's why fetch in the server is not the same as fetch in browser API, but cache does not come for free cache has some nuance, and sometimes neglected performance, time walk past and NextJS regret this decision by introduce NextJS 15 which are cache has no longer default behavior
How will this change help?
Problems
So many things can be broken when fetching with useEffect + useState from managing fetch lifecycle loading, error, etc., and dealing with cleanup function as a consequence of using useEffect .
By adding react-query it will also be managing the default behavior including some of what we mentioned above, what makes it more interesting is that it will also give configuration to change the default behavior and give the developer the power to manage our data.
What are the main benefits in the Modelina Codebase
It will reduce the complexity of data fetching in the Modelina playground and improve the speed of adding features in the Playground code generator from exponential(adding context and so on) to linear and also can potentially reduce the number of API calls in NextJS Api which also reduces cost.
Screenshots
No response
How could it be implemented/designed?
How it will be implemented
It will be implemented in the playground, and extracting fetch to separate files. We also need mutation to perform CRUD
We also need to discuss whether we want the first initial code in Playground to be fetched ahead of time/during built time to reduce cost by using prefetching
Reference
https://ui.dev/why-react-query
https://tanstack.com/query/v5/docs/framework/react/guides/request-waterfalls
🚧 Breaking changes
No
👀 Have you checked for similar open issues?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue?
None

I would love to work on this.
I looked into the code and I can only find react query being usefull here as mutation
Is there a particular part of the codebase where you see React Query being useful for data fetching (not just mutations) ?


Update track configuration

Write docs, including the about, installation, resources, and tests
pages  (#35).
Configure the online editor (#8).
Add language blurb (#24).
Add tags (#10).

I've also written a hello world exercise, but I think that should probably be a separate PR. I'm interested in working more on this track. What are the current plans for Nix on Exercism?

Thank you for picking this up. I’ve been meaning to do it myself, but life has been hectic. If we have decided on a way, I can help write exercises as well.
I was also going to suggest lib.debug.runTests. I was also wondering if flakes should be used to manage the nixpkgs input, but since it is still a experimental and there is no native integration for nix flakes and lib.debug.runTests I guess it might be worth holding off on that.

I agree with you. Flakes aren't ready. They also don't fit our usecase well because we don't depend on external inputs besides nixpkgs and they add a lot of boilerplate code.
For testing, runTests does most of the work, but it's lacking a good UX. In the future, I think it would be great if we could automatically generate test cases from the problem specification, but let's not get ahead of ourselves. Here's what I've hacked together for the hello world exercise:
hello-world-test.nix
with builtins; let
  lib = import <nixpkgs/lib>;
  helloWorld = import ./hello-world.nix;
  results = lib.debug.runTests {
    testHello = {
      expr = helloWorld.hello {};
      expected = "Hello, World!";
    };
  };
in
  if results == []
  then "All tests passed!\n"
  else
    deepSeq
    (map
      (t:
        trace ''
          ${t.name}:
            expected: ${t.expected}
            result: ${t.result}''
        t)
      results)
    (throw "${toString (length results)} tests failed!\n")

hello-world.nix
{
  hello = {}: "Goodbye, Mars!";
}

Anyway, the testing details can be worked out later. It's not critical for this PR.

I made a few small changes in the Github web editor. I’ll squash the commits when I’m at my computer later.

Thanks for the feedback. Please take another look at the changes before merging.


Fix TimePicker input mode width for 12-hour format

fixes https://github.com/flutter/flutter/issues/122471

code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Builder(builder: (BuildContext context) {
          return FilledButton(
            onPressed: () async {
              await showTimePicker(
                initialTime: TimeOfDay.now(),
                initialEntryMode: TimePickerEntryMode.input,
                context: context,
              );
            },
            child: const Text('Open Time Picker'),
          );
        }),
      ),
    );
  }
}

Before

Preview

After

Preview

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Not sure why, but the cocoon golden test is failing with this change.  I didn't think it had a time picker, but maybe?

Not sure why, but the cocoon golden test is failing with this change. I didn't think it had a time picker, but maybe?

Just rebased. All green.


Messages: json: Unmarshal(non-pointer client.EthTxPayload)

Some client.EthTxPayload messages are failing to be read.
I updated the following example to skip these messages for now https://github.com/bonedaddy/go-blocknative/pull/15
Ideally we can read all messages, but I am not sure why we cannot unmarshal some of the EthTxPayload messages.

Work around for now:
You can remove "continue" to stay in the loop for the hash detected, and import another client instance like:
geth  "github.com/ethereum/go-ethereum/ethclient"

to handle that transaction hash to extract more data.

Closing since you can create a Blocknative webhook locally to read from the mempool as well.
Example I used to get this working: https://groob.io/tutorial/go-github-webhook/


EKF: Fix bug causing simultaneous range and baro height fusion

This fixes a bug that causes simultaneous fusion of range finder and baro measurements when EKF2_RNG_AID is enabled.
The symptons of this bug are a drift in the the height estimate when range finder is being used as an alternate height reference.

@dagar Can we get a submodule update on Firmware for this?

https://github.com/PX4/Firmware/pull/9400

Is there a solution to this problem? Or unrelated
EKF baro hgt timeout - reset to baro #9060


Send fcm synchronous call  available ?

Hi,
I'm facing following issue,
 var isSent =false

for(let token of tokens){
 isSent = await fcm.send(message, async (err, response)=> {
          if (err) {
                        console.log("Something has gone wrong!");
                        return false;
                    } else {
                        console.log("Successfully sent with response: ", response);
                        return true;
                    }
                });
}

Here isSent is always undefined , Is there is any synchronous call to send FCM messages ?

try like this
let isSent =false

for(let token of tokens){
  isSent = await new Promise((resolve, _) => {
    fcm.send(message, (err, response)=> {
        if (err) {
          console.log("Something has gone wrong!");
          resolve(false);
        } else {
          console.log("Successfully sent with response: ", response);
          resolve(true);
        }
    });
 });
}


Dev refactor

Refactor code to be

more integrated with PyTorch lightning
up to date with 1.6.3
better API

Running example with MNIST. The API looks like the following
from mnist_example import MNISTModel, MNISTDataModule
from pytorch_lightning import LightningModule

from energizer.learners.base import Deterministic
from energizer.learners.acquisition_functions import entropy
from energizer.trainer import Trainer

# the user defines a learner and how it scores the instances on the pool
class Learner(Deterministic):
    def __init__(self, learner: LightningModule, query_size: int):
        super().__init__(learner, query_size)

    def pool_step(self, batch, *args, **kwargs):
        x, _ = batch
        logits = self(x)
        scores = entropy(logits)
        return scores

if __name__ == "__main__":

    # define datamodule
    datamodule = MNISTDataModule(batch_size=32)
    datamodule.setup()

    # user-defined LightningModule
    model = MNISTModel()

    # create a learner
    active_learner = Learner(model, query_size=1)

    # use the custom trainer
    trainer = Trainer(max_epochs=1)
    trainer.active_fit(active_learner, datamodule=datamodule)

Issues with method forwarding
This library implements a subclass of LightningModule, the Learner, that add pool_-related methods to be used during active_fit. The Learner encapsulates the user-defined LightningModule and forwards method calls to the encapsulated module.
However, the current forwarding is creating a bit of problems because lightning sees as overridden some methods that are not overridden in the underlying LightningModule just because they are forwarded in the Learner.
Basically, if I test whether the learner behaves as a normal LightningModule (from the example above)
from pytorch_lightning import Trainer as Trainer_pl

pl_trainer = Trainer_pl(max_epochs=1)
pl_trainer.fit(active_learner, datamodule)

I get the following warning
packages/pytorch_lightning/trainer/connectors/data_connector.py:589: UserWarning: You have overridden `transfer_batch_to_device` in `LightningModule` but have passed in a `LightningDataModule`. It will use the implementation from `LightningModule` instance.
  f"You have overridden `{hook_name}` in `LightningModule` but have passed in a"

Instead, I would forward a method only when it is overridden in the underlying module

Continuing on the method forwarding issue, it appears that the logs are not properly forwarded. In fact if I run
pl_trainer.test(model, datamodule)  # prints logs
pl_trainer.test(active_learner, datamodule)  # does not print logs


[Question] About Future and Further Developments

Hi,
First of all, i would like to thank you guys for such an awesome piece of art. Fantastic work on the icons. Love them. I was looking around when i saw that the last release was in 2021, which seems pretty old. Are there any further developments planned for the icon library or has the development been stalled ?

We have a major release planned for some time in the next few weeks, which will have some minor changes specifically to this package...including splitting the icon fonts up by weight, and shipping them in woff2 along with the existing formats. So you should see some size and perf improvements for minimal upgrade effort.
What specifically are you looking for in terms of improvements?

Thanks so much for the feedback!
We have zero runtime dependencies and a very simple design, so we have zero vulnerabilities to patch. Other than that, it's just bugs and improvements. Don't be surprised if our updates are few and far-between, but rest assured the project is alive and well.
As a totally free (always and forever) side project, we haven't felt the need for a roadmap in the past -- we don't like to promise icons or features, and generally are not beholden to honor requests in any order, or at all. That being said, we plan on including support for React Server Components in the next release, along with some QoL changes in the Vue library. These things seem important to the community to know about, so we'll consider posting it up somewhere for all to see.

Thank you and God bless.
Looking forward to many more years of Journey with Phosphor Icons.


Implement CRF decode (Viterbi decode) for tensor

Currently, Tensorflow doesn't support CRF decoding (Viterbi decoding) for tensor. Although tf.contrib.crf.viterbi_decode function can do CRF decoding, it can only be used at test time, since it accepts Numpy arrays as inputs.
Implementing CRF decoding for tensor benefits us a lot, as this makes our model more portable (e.g. we can freeze model, save it to a .pb file and then load it in Golang at test time).
This PR implements CRF decoding for tensor and adds test code for it.
This PR's change is compatible with current API.

Can one of the admins verify this patch?

I signed it!

@drpngx do you feel like reviewing this?

Let me know when it's ready for review again. Thanks!

@drpngx I had made some new changes according to your review comment. You may start review again whenever you're free. Thanks!

@drpngx
I have removed the non-deterministic example and added a deterministic one. In my test, crf_decode has passed this test.
By the way, crf_decode also has passed the previous non-deterministic example.

Jenkins, test this please.

Cool! Thanks for getting this reviewed so quickly @drpngx !


on /ui/infrastructures from the cards either provide a link to the infra service resource or allow to get resource level info

Because infra service names are not unique for referencing them when working via API one needs their respective resource IDs. It's not possible to get the resource ID from the cards on /ui/infrastructures page. It is required to go to /ui/api and search for the needed infra service there. It's rather user unfriendly.

The ID is now provided on the detailed IS page. Closing.


translation(ru): Updated Russian translation for NSIS

translation(ru): Updated Russian translation for NSIS

thanks!


ocaml-jupyter-kernel failing after installation of dev version

Hi again,
I tried installing the dev version from GitHub, with $ opam pin add jupyter https://github.com/akabe/ocaml-jupyter.git.
It seems to work, then I can install the kernel with sudo jupyter kernelspec install --name ocaml-jupyter /home/lilian/.opam/4.04.2/share/ocaml-jupyter but the binary ocaml-jupyter-kernel now fails with this (very explicit) error message:
Fatal error: exception Failure("No such file or director: ")
Raised at file "pervasives.ml", line 32, characters 22-33
Called from file "lib/kernel/JupyterKernelConnectionInfo.ml", line 44, characters 7-54
Called from file "src/JupyterMain.ml", line 57, characters 18-71

As the message does not say anything useful, I have no idea what the issue could be.
Thanks in advance, I really want to try your project and use it over iocaml, but keep failing to install it...

OK, sorry about the stupid issue, the binary ocaml-jupyter-kernel is not supposed to be ran from the command line.
The new kernel works perfectly well, as expected.


Remove the pre-install R packages

Fixes for https://issues.redhat.com/browse/RHOAIENG-2646
Description

Installation of  R-Studio required OS packages
Removal of RUN R -e 'install.packages(c("tidyverse", "tidymodels", "plumber", "vetiver", "devtools"))'
How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Thanks for the removal.
:100:

/cherrypick 2023b


issues 14, 13, galaxystop

issue 14 should be fixed with this

issue 13 partially fixed with this, didn't really spend too much time on it

added galaxy stop to notable abilites

Could've sworn I put Galaxy Stop on there! x_x


How to use Slash Commands

Hello everyone!
I wonder if this amazing library supports Discord Slash Commands.
Thanks in advance 👍🏻

Still in progress

@fjodor-rybakov any ETA on when support slash commands will be available?

I think there will be a release this month


Discuss modifying board requirements for Phase 5

To discuss in a future TA meeting:
The phase 5 specs currently say that the board should be printed from both perspectives every time. We may want to change this to print only the color the player is trying to join as, or potentially we could make it a separate runnable as the code for it in Phase 5 is temporary anyway.

#161 loosens the requirement to allow both options, at least for this semester. Later on we can require something more specific if we want.

Discussed and I believe a resolution was reached:

require only one board - from the perspective of the individual player when joining or the team playing white pieces perspective when observing
not required (but recommended) to loop through and look at pieces on an actual board rather than hardcoding the starting board (what phase 6 actually needs)
no separate runnable


How to plot the selection gene in PCA?

In [792] of this velocyto-notebooks, https://github.com/velocyto-team/velocyto-notebooks/blob/master/python/DentateGyrus.ipynb, here plot the selection gene in tSNE plot, how to plot the similar selection gene in PCA? Thanks!
plt.figure(None, (17,2.8), dpi=80)
gs = plt.GridSpec(1,6)
for i, gn in enumerate(["Pdgfra","Igfbpl1"]):
ax = plt.subplot(gs[i*3])
try:
ix=np.where(vlm.ra["Gene"] == gn)[0][0]
except:
continue
vcy.scatter_viz(vlm.Sx_sz[ix,:], vlm.Ux_sz[ix,:], c=vlm.colorandum, s=5, alpha=0.4, rasterized=True)
plt.title(gn)
xnew = np.linspace(0,vlm.Sx[ix,:].max())
plt.plot(xnew, vlm.gammas[ix] * xnew + vlm.q[ix], c="k")
plt.ylim(0, np.max(vlm.Ux_sz[ix,:])*1.02)
plt.xlim(0, np.max(vlm.Sx_sz[ix,:])*1.02)
minimal_yticks(0, np.max(vlm.Ux_sz[ix,:])*1.02)
minimal_xticks(0, np.max(vlm.Sx_sz[ix,:])*1.02)
despline()
vlm.plot_velocity_as_color(gene_name=gn, gs=gs[i*3+1], s=3, rasterized=True)

vlm.plot_expression_as_color(gene_name=gn, gs=gs[i*3+2], s=3, rasterized=True)

plt.tight_layout()
plt.savefig("../figures/Fig3_selection.pdf")

Any guy has the same situation?

Hi
This is not the best forum for general programming questions. To learn how to compute a PCA and plot it, please look at the docs for scikit-learn and matplotlib.
This forum is for reporting bugs and feature requests for velocyto.
If you think you have found a bug, please describe in detail (1) the steps to reproduce the bug (2) what the result was and (3) what you had expected to happen. Please also describe your installation (OS, how you installed velocyto, python version).

Hi slinnarsson,
Thanks for the reminder, I just wonder that  vlm.plot_velocity_as_color and vlm.plot_expression_as_color
can do plot using tSNE, why not work using PCA? So I thought there should be a similar tool for PCA, Thanks.

Velocyto calculates velocities. You can trivially plot them in a PCA or any other linear transformation of the coordinates. For tSNE, being nonlinear, it’s a bit more difficult and that’s why we provide special methods.


Logo is added to the nav bar and Animation is added to the menu symbol

#23 logo is added to the nav bar
and adding values to the alt attributes in image tags
making more responsive by making max-width:650px
Animation is added to Menu symbol
Git page : https://manoj-14.github.io/Student-portal/

Add the name 'Student Portal' after the Logo

Ok

@Manoj-14 please resolve the conflicts

@Manoj-14 ???


[BUG] rancher basic function broke, seems cannot listen crd changes

Rancher Server Setup

Rancher version: 2.7.0
Installation option (Docker install/Helm Chart): start up the rancher in dev mode using source code

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details: self certificate according to official guide

Information about the Cluster

Kubernetes version: 1.22
Cluster Type (Local/Downstream): 1 local + 1 downstream (origin K8S)

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions:
admin

Describe the bug

I was trying to add a user into an new created project, but it reports error like below

I know creating 1 project will also create 1 namespace named by projectID. But in this situation, it seems something wrong with the listener? I m not sure if this issue is K8S issue or rancher issue.
And I checked the backend log, found some logs below

closing watcher for xxxxx
unable to decode an event from the watch stream: http2: response body closed

I m not sure if these logs are related to this issue.
I did not notice this issue in v2.6, just found this issue in v2.7 recently.
I also test user creation.
In normal rancher, when creating a user, rancher will listen this new user, and create default cluster role for this user.  But in this bug situation, it seems rancher cannot listen this new user creation. Therefore, no default cluster role will be created for this user.
I have 2 environments on 2 PC.  Both using the same source code to start the rancher.
One environment does not have this issue.
The other one has this issue.
I don't know how to reproduce the issue. It seems this issue happens all of a sudden.
And if this issue happens, it cannot be repaired by restart rancher.
I tried to reset the K8S and then start the rancher (like reinstall the rancher), then the issue is gone. But after using a while, this issue happens again.
I also searched known issues in rancher github, there is one issue very similar to this issue.
[BUG] Creating/deleting management resources cause resources to be unsubscribed #40558
the error log is same.
But still not sure if it is the same issue.
I think this a critical issue. Many basic function cannot use after issue happens, and restart operation cannot recover the rancher.
Can some experts help check if this issue like issue 40558 or this is a new issue.
To Reproduce

Result
Expected Result

Screenshots

Additional context

Some of those error messages are spurious and should hopefully be removed soon (see https://github.com/rancher/rancher/issues/40627).
https://github.com/rancher/rancher/issues/40558 is an expected result of a change of permissions (where resource watches are closed).
I've just tried creating a Project that contains an additional user as a member and this worked fine (Rancher ~2.7.5).
@boltdog2022 Can you provide some step by step instructions on how to recreate the bug?
Unfortunately I work UI side, so that's the only part I can assist with

Thanks anyway. I think this is a backend issue too.


Improve compatibility with other frameworks and future OMF.

Move all autoloaded functions to functions/.

LGTM :+1:


Default MAX value?

As per the docs about the option -m MAX,
-m  MAX          Only run the specified script MAX times

What is the default value of -m if I don't specify it in the command?

It's not explicit anywhere in the README or wiki, but it's kind of implicit in the package's name, runs forever (no max times).
Keep in mind, the script will not restart automatically if the script up time is less than the config of --minUptime which default to 1 second.


Move Public OpenSearch Domain to VPC (public to private)

Summary
The MCP Cloud Management Team (Shawn, Caden, Chris) has identified the need to move our current public OpenSearch domain into an existing VPC, creating a private OpenSearch domain and endpoint. This will enhance the security and privacy of our data. Though we are behind on the remediation date, it is recommended to make this change as soon as possible.
Steps to Move OpenSearch Domain into VPC and Retain Indexed Data

Create a snapshot of the existing public OpenSearch domain data.

Creating manual snapshots

Configure security groups within the existing VPC to control access to the new private OpenSearch domain.

Creating security groups

Create a new private OpenSearch domain within the VPC.

Creating VPC-based domains

When creating a VPC-based domain, you need to specify the VPC ID, and one or more subnet IDs. You also need to configure security groups to control traffic to your domain.

Restore the snapshot taken in step 1 to the new private OpenSearch domain.

Restoring snapshots

Update any applications or services to use the new private OpenSearch endpoint.

This is APT Lambda, SQS Lambda, and Frontend application

Verify data consistency and connectivity to the new private OpenSearch domain.
Once the new private OpenSearch domain is operational, decommission the old public OpenSearch domain.

Deleting OpenSearch domains

Here is the full ticket from MCP internal system:
Details13/Mar/23 1:22 PM
Priority
Medium
Description
MCP is performing Yearly reviews of Security Hub and ATO Continuous Monitoring things and require your support in remediating a finding in one or more of your accounts.
Elasticsearch domains should be in a VPC
[ES.2] This control checks whether Elasticsearch domains are in a VPC. It does not evaluate the VPC subnet routing configuration to determine public reachability. This AWS control also does not check whether the Amazon OpenSearch Service resource-based policy permits public access by other accounts or external entities. You should ensure that Elasticsearch domains are not attached to public subnets. See Resource-based policies (https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-ac.html#es-ac-types-resource) in the Amazon OpenSearch Service (successor to Amazon Elasticsearch Service) Developer Guide. You should also ensure that your VPC is configured according to the recommended best practices. See Security best practices for your VPC (https://docs.aws.amazon.com/vpc/latest/userguide/vpc-security-best-practices.html) in the Amazon VPC User Guide. Remediation instructions
OpenSearch domains should be in a VPC
[Opensearch.2] This control checks Amazon OpenSearch Service domains are in an Amazon Virtual Private Cloud (VPC). Remediation instructions
ServiceCompliance StatusSeverityWorkflowAccountResourceRegionUpdatedESFAILEDCRITICALNEW237694371684arn:aws:es:us-west-2:237694371684:domain/apt-api-lambda-prod-elasticus-west-22023-03-13T17:01:07.201ZOSFAILEDCRITICALNEW237694371684arn:aws:es:us-west-2:237694371684:domain/pi-lambda-prod-v2-opensearchus-west-22023-03-13T06:34:01.470Z
Critical Findings have a 15 day turn-around if at all possible.
The current tentative remediation date is 4/3/2023. Remediation instructions are linked above. LMK if you have any questions.
Remediation Type
Security Hub
Due Date
02/Apr/23
Account Number
237694371684
AWS Region
us-west-2 (Oregon)

@naomatheus If I'm not mistaken, step 2, 3 and 5 could be done through our cdk config in https://github.com/NASA-IMPACT/nasa-apt/blob/bbca71b50a8937b8d6713c307c0159a05b266161/stack/app.py#L173 by adding the right security group and vpc config to the domain creation function, right?

Yes I would agree @sunu . We can complete a lot of this with small changes to the infrastructure code. And actually we should implement all of this in CDK.

I removed myself from this issue for now since @sunu  will be first on this task.
I'm happy to support where necessary and for deployment to production.
cc: @wrynearson

@sunu any updates here? Is any more work needed?

@wrynearson Sorry, I somehow missed this. Looking at the linked PR (https://github.com/NASA-IMPACT/nasa-apt/pull/703), it needs some more tweaks. After that we can test on staging and then production.

No problem, thanks @sunu

@wrynearson Should we move this into a sprint since MCP is requesting this get completed?

@bwbaker1 this is complete. I forgot to close the ticket.


Wrong DLL name in target_compile_definitions of demo hardware?

I guess that in line 47 of the hardware CMakeLists.txt (https://github.com/ros-controls/ros2_control_demos/blob/master/ros2_control_demo_hardware/CMakeLists.txt) is a copy and paste error?
# Causes the visibility macros to use dllexport rather than dllimport,
# which is appropriate when building the dll but not consuming it.
target_compile_definitions(${PROJECT_NAME} PRIVATE "JOINT_STATE_BROADCASTER_BUILDING_DLL")

Shouldn't it be:
# Causes the visibility macros to use dllexport rather than dllimport,
# which is appropriate when building the dll but not consuming it.
target_compile_definitions(${PROJECT_NAME} PRIVATE "ROS2_CONTROL_DEMO_HARDWARE_BUILDING_DLL")

this is correct. can you submit a PR for that?


chore: forward-port leanprover-community/mathlib#19134

The mathlib3 change was fixing a synchronization comment, so there is nothing to port.

Thanks!
bors merge


FEATURE: Chat channel creation modal

This is fantastic, but I feel we reached the last straw security wise :)
Can you create a ChatGuardian class and then only allow "staff" for now to create channels (and move topics as well while in there)
Also, do we support rename?

We don't support rename - I planned to do that in the next chunk of work with archiving channels. It's basically a big change to the chat-channel-settings-row component to allow renaming and archive. Is that OK for now @SamSaffron ?

yeah we can hold off on rename, just can not hold off on the security audit, I want this as part of this PR.

What exactly do you mean? There are specs for the endpoint that ensure non-staff can't create a channel for example

NOTE FOR ME TOMORROW: Remove message select UI for non-staff.

(clarified on chat ... add can_move_chat_to_topic and can_create_channel to existing guardian)

Going to add channel description


Send requestheader-client-ca-file from API

Bug
Environment

Platform: DigitalOcean
OS: container-linux
Ref: Server Version: v1.11.2
Terraform: -
Plugins: -

Problem
I want to deploy the Prometheus Adapter and in its logs I can see the following error after which the pod terminates.
F1105 17:13:12.140688       1 adapter.go:206] unable to install resource metrics API: cluster doesn't provide requestheader-client-ca-file

Desired Behavior
API Server (I guess) should send this requestheader-client-ca-file and the Prometheus Adapter should be able to start.
Steps to Reproduce
Start Typhoon cluster and then deploy kube-prometheus from my fork which already includes the Prometheus Adapter manifests.

Typhoon enables kube-apiserver TLS client authentication and service account tokens. Other optional apiserver authentication mechanisms like bearer tokens, bootstrap tokens, oidc tokens, username/password, authenticating proxy (i.e. what you're asking for with --requestheader-*), and anonymous auth are disabled.
I'd prefer to keep a minimal kube-apiserver authentication surface area and allowing authenticating proxy would be a non-goal.


Feature request: support for loadBalancerClass

Would it be possible to have the provider check the "loadBalancerClass", so that it only assigns IP addresses to matching services? For example by setting an environment variable "KUBEVIP_LB_CLASS" (or so).

Yeah that sounds reasonable
Right now kube-vip supports this field
Kubernetes LoadBalancer Class (Kubernetes v1.24+) (kube-vip v0.5.0+)
The watcher will always examine the [load balancer class ](https://kubernetes.io/docs/concepts/services-networking/service/#load-balancer-class), and if it isn't set then will assume that classes aren't being set and act upon the service. If the spec.loadBalancerClass has been set in the service spec then kube-vip will only act IF the spec has been set to:

spec.loadBalancerClass=kube-vip.io/kube-vip-class.

And kube-vip loadbalancer should also honer it if they are used together

Summarizing the functionality here

If service has loadbalancerClass, kube-vip-cloud-provider is not configured with loadbalancerClass, kube-vip-cloud-provider will ignore the service
If service doesn't have loadbalancerClass, kube-vip-cloud-provider is configured with loadbalancerClass, kube-vip-
cloud-provider will ignore the service
If service has loadbalancerClass, kube-vip-cloud-provider is configured with loadbalancerClass, kube-vip-
cloud-provider will allocate ip for the service
If service doesn't have loadbalancerClass, kube-vip-cloud-provider is not configured with loadbalancerClass, kube-vip-
cloud-provider will allocate ip for the service

Found problem with the implementation, since default cluod-provider won't reconcile service if it has loadbalancerClass set
https://github.com/kubernetes/cloud-provider/blob/982d74ad51fe6a37157eb20dd1386be1a2a0f106/controllers/service/controller.go#L824-L827
Need to come up with other way

@lubronzhan does this still have your attention, or can we better look for an alternative way to achieve this?

Now it's supported


loggerのパッケージ構成をいい感じにする

Codecov Report

Merging #53 (f80eed5) into master (9667064) will decrease coverage by 6.37%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   79.59%   73.21%   -6.38%
==========================================
  Files           3        3
  Lines          49       56       +7
==========================================
+ Hits           39       41       +2
- Misses          7       12       +5
  Partials        3        3

Flag
Coverage Δ

unittests
73.21% <65.38%> (-6.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/invitation/usecase.go
68.42% <62.50%> (-4.92%)
:arrow_down:

pkg/infra/dao/error.go
58.33% <63.63%> (-1.67%)
:arrow_down:

pkg/infra/dao/invitation.go
84.00% <71.42%> (-2.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9667064...f80eed5. Read the comment docs.

Codecov Report

Merging #53 (f80eed5) into master (9667064) will decrease coverage by 6.37%.
The diff coverage is 65.38%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   79.59%   73.21%   -6.38%
==========================================
  Files           3        3
  Lines          49       56       +7
==========================================
+ Hits           39       41       +2
- Misses          7       12       +5
  Partials        3        3

Flag
Coverage Δ

unittests
73.21% <65.38%> (-6.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/invitation/usecase.go
68.42% <62.50%> (-4.92%)
:arrow_down:

pkg/infra/dao/error.go
58.33% <63.63%> (-1.67%)
:arrow_down:

pkg/infra/dao/invitation.go
84.00% <71.42%> (-2.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9667064...f80eed5. Read the comment docs.


Need to fix Helidon MP/SE doc - OCI Vault (image src is invalid)

Environment Details

Helidon Version: 2.3.1
Helidon MP and SE

ref: https://helidon.io/docs/v2/#/mp/oci/03_vault
The image src does not seem to be set up properly.

Currently, the documentation says image::oci/ocivault.png[OCI Vault, align="center"], but I think it should be image::oci/vaultkey.png[OCI Vault, align="center"]. Isn't it?

See PR #3224