Adding a link to github

Draft PR for https://github.com/relaycc/receiver/issues/70

This is what the footer looks like now per #70

Closes #70

My only thought would be that this maybe looks too much like an advertisement that companies wont wont on their page. Maybe not though... Maybe just a github logo?

 Relay is open-source on

does this look right for the footer? Does anything need to be spaced / sized differently?

Maybe our logo and the GH logo should be center aligned with the text 1 sec

text is a little higher

Full context

if the relay logo opens a new tab to try.relay.cc and the gh one opens new tab to to github.com/relaycc/receiver then lgtm

yes, they do. I'll push the code and make any adjustments needed

If there is any specific reason as to why this hasn't been merged yet that I can help out with, let me know. In my opinion the current footer is in serious need of something to be merged in it's place

@vdp @killthebuddh4

@BrianS111 These aren't blocking comments, but a couple notes

Let's not inline svgs anymore, svgs can go at the bottom of the file or extracted into their own component. I'd probably default to the bottom of the file for now
Let's not use inline styles


Weird repositories on my try.gitea.io organization

Gitea version (or commit ref): try.gitea.io
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
Hello, I created a organization long time ago in try.gitea.io
Today I see many repositories in my organization dash board that doesn't actually exist. Please see https://try.gitea.io/org/di/dashboard
Another wierd thing is I can see many issues in https://try.gitea.io/org/di/issues .
But when I click the link it send me another repositories, those are not relavant with di organization. The PR section acts exactly same.
Please take a look.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

#933 only reosolved dashboard problem. Not resolved  https://try.gitea.io/org/di/issues

Please check https://try.gitea.io/pulls page too.

It's still not resolved completely.

I'm working on this.

@kybin Please confirm #943 has resolved this.

It isn't resolved yet.
I think it is safe to say my id and password, so you could see my pages when you debug it.
id: kybin
password: gitea

No. try.gitea.io is not updated to 847527f yet. current is 140967f0. Maybe you can confirm it after a while.

Ah, ok. I didn't catch that.
I deleted the previous post.

Now it's the newest version and I think it should be fixed.

Seems try.gitea.io is down. So I can't test it.

Seems try.gitea.io is down. So I can't test it.

This have been a different issue, everything is up and running.

Yes, it's fixed now. Thank you for the effort!


Issue/fix for compiler import loop (#2761)

Pull request opened by the merge tool on behalf of #2761

Merged into branches iso4 in 4b379008dcafba1e50d427bd5a85b9207387309c


patch: 555 dummy number improvements

:tada: This PR is included in version 10.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Task]: Update on #8604

Task description
I have the new software but it does not like my password. How do I access wallet with my 24 word secret seed.

If you dont remember your password your can re-import your 24 words as a new profile


remove superfluous browser-shim lines from package.json

[x] https://github.com/nlesc-sherlock/spiraljs/blob/49b660dd0f0179b20ba85a47e9647c30af77c833/package.json#L91
[x] https://github.com/nlesc-sherlock/spiraljs/blob/49b660dd0f0179b20ba85a47e9647c30af77c833/package.json#L93
[x] https://github.com/nlesc-sherlock/spiraljs/blob/49b660dd0f0179b20ba85a47e9647c30af77c833/package.json#L96
[x] https://github.com/nlesc-sherlock/spiraljs/blob/49b660dd0f0179b20ba85a47e9647c30af77c833/package.json#L98

should be solved by PR #62


DL by Group new illust

Hi,
Sry for my english, can you add features:
"Download new illust from boukmarked memmbers by Group ID "
Exemple by Personal link for group: "AD"
https://www.pixiv.net/bookmark_new_illust.php?tag=AD
Cordialement,
Eiv

You are asking for new feature, right? Can you do it at https://github.com/Nandaka/PixivUtil2/issues


Prevent http response from code being overwritten by stash(status => 'text...')

Summary
Any user using stash('status') unaware that it's a restricted variable can potentially allow unsanitized data to replace the http response code.
PoC
use Mojolicious::Lite;
get '/hello/#status' =>  'groovy';
app->start;

__DATA__
@@ groovy.html.ep
Your name is <%= $status %>.

# Exploit:
# http://<IP_ADDRESS>:3000/hello/200%20OK%0d%0aContent-Length:%20150%0d%0aX-XSS-Protection:%200%0d%0a%0d%0a<html><body onload="eval(window.location.replace(String.fromCharCode(104,116,116,112,58,47,47,119,119,119,46,115,97,110,103,101,114,46,100,107,47)))">

Motivation
I recently had a complaint from a client that certain pages of their application was displaying unrendered html when opened in safari. It appeared that the issue was limited to pages with the route '/list/:status' and some manual requests returned the following:
* Connected to localhost (<IP_ADDRESS>) port 3000 (#0)
> GET /list/SALE HTTP/1.1
> User-Agent: curl/7.38.0
> Host: localhost:3000
> Accept: */*
>
* HTTP 1.0, assume close after body
< HTTP/1.1 SALE
< Content-Type: text/html;charset=UTF-8
< Date: Mon, 24 Oct 2016 07:31:26 GMT
< Server: Mojolicious (Perl)
< Content-Length: 4

Rereading the documentation can i see that 'status' is a reserved word but the lack of runtime warnings is somewhat problematic...
References
From: Sebastian Riedel<EMAIL_ADDRESS>Date: Mon, 24 Oct 2016 14:47:44 +0200
Subject: Re: Mojolicious Vulnerability (stash status)

> This may affect some people so thought I would send via email as a
> precaution.

Thank you, this is very hard to exploit, so you're welcome to discuss
the problem and your patch in public.

In order to be considered (by project policy) this feature must come with tests and documentation.

Aside from the lack of tests, the patch also seems to address the same problem in 3 different ways. That can't be right.

Sorry, looks like i didn't check the branch pushed to github before opining the request..... I will update with the correct version when i get home.


Laravel 11.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:

Checkout the l11-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

:warning: Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

:information_source: Shift detected you do not have a CI workflow using GitHub Actions. If you would like, Shift can help you get started with the CI Generator. Although the Shift is paid, GitHub Actions is free and having a CI workflow will improve the stability and review process for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/bruno.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "optimus/bruno": "dev-l11-compatibility",
    }
}

Finally, run: composer update


Change "help" button to "call" button for Workspace guide calls

Details

We are updating the Help button to say Call so we are consistent across OldDot and NewDot. See linked issue for more details.
Fixed Issues

$ https://github.com/Expensify/App/issues/5385
Tests

Go to your workspace and make sure the button at the top right corner says Call like on this screenshot.

QA Steps

See tests section.
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Self-merging merging now due to deadline urgency!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.1.0-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Bounding box drawing and value representation

@tianweiy, when i run the model on the nusc/ custom data  the predictions consists of  "box3d_lidar", the values obtained from them, are the centerxyz , wlh which when i use to draw on the point cloud is not exactly on the object is there any conversion we should be doing for drawing the prediction bounding box to visualization

@abhigoku10
can you please explain how you solved the problem


Cleanup various flags in CMakeLists.txt

HandleLLVMOptions allows us to cleanup several of the flags that are being set explicitly in onnx-mlir. In addition, this change sets the policy for CMP0116 to match llvm-project.
This change depends on #718

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

@jenkins-droid test this please

@caoimhinuibrian : I expect the builds for this change and the runtime change to fail until the HandleLLVMOptions PR is merged.

@jenkins-droid test this please

@caoimhinuibrian : I expect the builds for this change and the runtime change to fail until the HandleLLVMOptions PR is merged.

@sstamenova ok, cool

Can one of the admins verify this patch?

@jenkins-droid test this please

Jenkins Linux ppc64le Build #331 [push] Cleanup various flags in... started at 15:26

Jenkins Linux amd64 Build #1185 [push] Cleanup various flags in... started at 14:24

Jenkins Linux s390x Build #1183 [push] Cleanup various flags in... started at 15:24

Jenkins Linux s390x Build #1183 [push] Cleanup various flags in... passed after 42 min

Jenkins Linux amd64 Build #1185 [push] Cleanup various flags in... passed after 47 min

Jenkins Linux ppc64le Build #331 [push] Cleanup various flags in... passed after 54 min


Feat/remove tuples

Description
There is no reason for Tuples to continue to exist, because the project limits the version of Dart to at least 3.2, which already includes support for Records.
Therefore, this PR removes Tuple2 and changes its uses to Records.
Related Issue

Closes #59

@ricardodalarme Pronto, publicado. Obrigado!

Congrats on this 10 release and thank you very much everyone!


Fix cases where frags did not exist in clean_geometry

Hi @dblodgett-usgs,
This should solve the issue of the missing fragments, and duplicate areasqkm issue.
library(hyRefactor)
#> Registered S3 method overwritten by 'geojsonlint':
#>   method         from
#>   print.location dplyr
#> USGS Support Package: https://owi.usgs.gov/R/packages.html#support
catchments = readRDS("/Users/mjohnson/Downloads/agg_fail.rds")
ttt = clean_geometry(catchments)
plot(ttt$geometry)

Created on 2021-12-06 by the reprex package (v2.0.1)

Thanks Mike!!


Resumable hashing

Have any of you considered resumable hashing for rhash?
When hashing extremely large files, 20GB and up, being able to resume hashing from a previous position would help a ton.
Is this something you've considered?

It's an interesting feature request. It can be implemented by serializing internal librhash state into a "partly hashed" file.
But for now it's a low priority FR, so not sure when I get my hands to it.

You have knowledge of the library.
Can you put 15 min and give a rundown of where that code is and what essentially should happen?
I might look into implementing it, would rather know where to look without learning the entire code base
Its very useful for download automation where you need hashing, can be split into a piped stream into rhash. Partial hashing is necessary for crashes(long downloads tend to have issues)
I.e. a way to send in the "partially hashed" file or load it after a crash.
The same code can be reused to increase stability during crashes.
When you hash a 50g file and it breaks in the middle that's a little nightmare scenario

see also https://stackoverflow.com/questions/2130892/persisting-hashlib-state
you really just have to save and load

the file size
the internal state of the hasher functions

Since bbbe1beae95217b458ba43d4a90b7858325cca45 librhash supports add rhash_import() and rhash_export() functions to save and load internal state. Now it's not hard to support resumable hashing of single file.
It some things are not clear:

What RHash should do in a case, when many files or a directory tree are passed to hash them? How and where to store info, what files were already hashed? Note that RHash usually outputs hashing result to STDOUT, not to a file.
What to do if RHash is recursively hashing a directory tree, but after resuming the filesystem returns files in a different order?


Allows the use of VERTICAL_SCROLLABLE constant in DateRangePicker com…

I'm unsure if this is actually wanted or not but there seems to be a few others wanting to use DateRangePicker component with vertical scrolling.
Currently it works fine but results in an ugly proptype warning. This PR attempts to address that by importing ScrollableOrientationShape rather than OrientationShape within DateRangePickerShape

Coverage remained the same at 84.875% when pulling 8e640c267abbdbf3eb77cd7423e9dd90bd47198a on theolampert:master into 0e019f55757a2a6fe5bb8466c64a85bde04a8a61 on airbnb:master.

Sorry for the delay. This is a great bug fix, but it needs a regression test, can you add one?

@ljharb sorry closed this thinking it was no longer needed. Yeah I can add a test.

@ljharb Could you take another look?

@ljharb done 🙂

@theolampert I've rebased this; could we add some storybook stories that cover this new orientation?

@ljharb I wasn't able to get storybook to build on an M1 mac, complains about node-sass missing so I assume it's some native module thing I didn't really want to debug. I'll try and take a look from an intel machine either tonight or tomorrow.

@theolampert node-sass requires very specific node versions - in this case, i think node 14? and on an M1 mac, node < 16 requires installing it via rosetta.


URL in repository's description points to 404

URL points to https://contributte.org/packages/contributte/datagrid.html, but this page does not exists. The URL should be "https://contributte.org/packages/contributte/datagrid/" instead.

Solved. Thanks.


Development

What type of PR is this?
cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Issue fix for AppImage on Linux not connecting to Ledger
Special notes for your reviewer:
Please add this to a new branch, or test some other way, as this introduces a breaking change - the linux build is for Linux only.
Does this PR introduce a user-facing change?:

Fix for Linux build to get ioPay desktop app to work with Ledger

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

fixed at #1982


Litmus Junit report

Hi
Is there a way to produce a JUnit report based on Litmus experiment reports?

Hi @strus38 ! Thanks for bringing this up - this is a feature we will be integrating soon. Would you like to share any pointers/preferences?

Hi @ksatchit,
Is there a basic test report generation that can be done in JSON or CSV format right now from the ChaosResult (yaml) objects or from the experiment logs ?
What system of reporting is already in place in LitmusChaos?
I am thinking of extracting test results from ChaosResult object in json format using JSONPATH and then running a JSON parser to get the required key-value pairs from it.
Any suggestions would be welcome.
-Srikanth

Hey @strus38 @jnsrikanth what do you think of the following ways of getting result info? Would be interested in hearing your thoughts!
LitmusChaos xUnit result XML format
Note:

A native xUnit result schema for LitmusChaos (just like there is jUnit schema for jenkins et al)
LitmusChaos can provide a parser for rendering this in a standardized/beautified html format

<?xml version="1.0" encoding="UTF-8"?>
<testcase probes="2" probefailures="1" name="catalogue-latency-10s">
   <properties>
      <property name="experiment.version" value="2.1.0" />
   </properties>
   <probes>
      <probe type="http-probe" name="frontend-availability-check" result="pass" />
      <probe type="cmd-probe" name="sock-shop-user-crud-check" result="pass" />
      <probe type="prom-probe" name="service-qps-check" result="fail">
         <probefailure status="Failed" message="actual value {180.99} less than {200}" />
      </probe>
   </probes>
   <fault name="pod-network-latency" targetkind="deployment" targetname="catalogue">
      <testfailure verdict="Failed" message="steady-state validation failed" />
   </fault>
</testcase>

LitmusChaos jUnit result XML generated via litmus-sdk from chaosresult YAML input
Note:

Output format based on jenkins/ant references
Offline rendering of an existing junit template based on fields parsed from input chaosresult using litmus-sdk
Here the chaosengine corresponds to the testsuite that runs a specific fault
Probes map to individual tests or constraints

<?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="1" failures="1" name="{{ .Metadata.Name }}"> <!-- catalogue-latency-10s -->
  <properties>
    <property name="fault.name" value="{{ .Spec.Experiment }}"></property> <!-- pod-network-latency -->
    <property name="target.kind" value="{{ .Status.Targets[0].Kind }}"></property> <!-- deployment -->
    <property name="target.name" value="{{ .Status.Targets[0].Name }}"></property> <!-- catalogue -->
  </properties>
  <testcase classname="http-probe" name="frontend-availability-check">
    <failure message="Failed" type="Actual output does not meet criteria - 200 OK"></failure>
  </testcase>
  <testcase classname="cmd-probe" name="service-self-heal-under-mttr"></testcase>
</testsuite>

LitmusChaos jUnit result XML format based on jenkins/ant - generated via experiment as an artifact
Note:

Very similar to previous schema
Runtime generation of an existing junit template based on chaosdetails captured
Since it is runtime generated, we will also have extra info - such as run_duration, app reschedule/startup/recovery time etc., (which is not available with offline render)
This may be placed/written into a configmap at the end of the experiment for further format/extraction by users.

<?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="1" failures="1" time="03.20" name="catalogue-latency-10s">
  <properties>
    <property name="fault.name" value="pod-network-latency"></property>
    <property name="target.kind" value="deployment"></property>
    <property name="target.name" value="catalogue"></property>
    <property name="app.recovery.time" value="00.30"></property>
  </properties>
  <testcase classname="http-probe" name="frontend-availability-check">
    <failure message="Failed" type="Actual output does not meet criteria - 200 OK"></failure>
  </testcase>
  <testcase classname="cmd-probe" name="service-self-heal-under-mttr"></testcase>
</testsuite>

LitmusChaos ChaosResult converted to XML format
Note:

Doesn't conform to regular xUnit/jUnit result format, but can be rendered if users employ generic xml- parsers.

<?xml version="1.0" encoding="UTF-8" ?>
<root>
  <apiVersion>litmuschaos.io/v1alpha1</apiVersion>
  <kind>ChaosResult</kind>
  <metadata>
    <name>helloservice-pod-delete-pod-delete</name>
    <namespace>litmus</namespace>
    <resourceVersion>8315917</resourceVersion>
  </metadata>
  <spec>
    <engine>helloservice-pod-delete</engine>
    <experiment>pod-delete</experiment>
  </spec>
  <status>
    <experimentStatus>
      <failStep>N/A</failStep>
      <phase>Completed</phase>
      <probeSuccessPercentage>100</probeSuccessPercentage>
      <verdict>Pass</verdict>
    </experimentStatus>
    <history>
      <failedRuns>0</failedRuns>
      <passedRuns>1</passedRuns>
      <stoppedRuns>0</stoppedRuns>
      <targets>
        <chaosStatus>targeted</chaosStatus>
        <kind>deployment</kind>
        <name>hello</name>
      </targets>
    </history>
  </status>
</root>

Since it is runtime generated, we will also have extra info - such as run_duration, app reschedule/startup/recovery time etc., (which is not available with offline render)

<testsuite tests="1" failures="1" time="03.20" name="catalogue-latency-10s">

@ksatchit Can this information be included in the chaos result CR, so that offline generation can also display it?


Crate 0.55.2, Cannot allocate memory

I try to deploy a Crate cluster with 3 nodes upon Crate 0.55.2, yet when I load data using COPY FROM, error come out as follows:

Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000000dd990000,<PHONE_NUMBER>4, 0) failed; error='Cannot allocate memory' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map<PHONE_NUMBER>4 bytes for committing reserved memory.
# An error report file with more information is saved as:
# /data1/upload/hadoop/hs_err_pid15016.log

I describe some details of softeware and configuration:

Crate version: 0.55.2
JDK version: "1.8.0_92"
OS version: CentOS release 6.5 (Final)
Machine memory: 64314M
Crate config: CRATE_HEAP_SIZE=30G

See attachment for details of error log, thanks.
hs_err_pid15016.txt
Sincerely,
Robin

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35946849-crate-0-55-2-cannot-allocate-memory?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505659&utm_medium=issues&utm_source=github).

Hi! Since if you want, you can also post the answers to my questions here instead of the email.
Cheers, Claus

Hi Claus,
1.This is table structure.
CREATE TABLE dm_list_play_d(
etldate string,
plat string,
sty string,
source string,
singername string INDEX USING plain,
songname string INDEX USING plain,
singername_org string INDEX OFF,
songname_org string INDEX OFF,
filename string INDEX USING plain,
filename_org string INDEX OFF,
song_type string,
play_cnt integer,
complete_play_cnt integer
) PARTITIONED BY(etldate);

2.Crate is the only major program to use memory on my machine, the usage of memory is %4 on each machine, and the Crate 0.55.2 installed freshly.
3.Disk info
df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/sda2        20G  3.6G   16G  20% /
tmpfs            32G     0   32G   0% /dev/shm
/dev/sda1      1008M   60M  897M   7% /boot
/dev/sda4       1.1T  461G  555G  46% /data1

cat /proc/scsi/scsi
Attached devices:
Host: scsi0 Channel: 02 Id: 00 Lun: 00
  Vendor: DELL     Model: PERC H730P Mini  Rev: 4.25
  Type:   Direct-Access                    ANSI  SCSI revision: 05

dmesg | grep sda
sd 0:2:0:0: [sda]<PHONE_NUMBER> 512-byte logical blocks: (1.19 TB/1.08 TiB)
sd 0:2:0:0: [sda] Write Protect is off
sd 0:2:0:0: [sda] Mode Sense: 1f 00 00 08
sd 0:2:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
 sda: sda1 sda2 sda3 sda4
sd 0:2:0:0: [sda] Attached SCSI disk
EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts:
dracut: Mounted root filesystem /dev/sda2
EXT4-fs (sda1): mounted filesystem with ordered data mode. Opts:
EXT4-fs (sda4): mounted filesystem with ordered data mode. Opts:
Adding 8388600k swap on /dev/sda3.  Priority:-1 extents:1 across:8388600k

4.I import data via COPY FROM, each JSON file is about 5G, and 61 files total.
5.When I import data, this error occured immediately, there is no enough time to observe the status of memory, CPU and disk.
Thanks.
Sincerely,
Robin

Does Crate come up at all, i.e. is there any log output?

Hi Claus,
There is no error log, but there is some WARN log as follows:

[2016-07-12 16:58:00,400][WARN ][bootstrap] unable to install syscall filter: seccomp unavailable: requires kernel 3.5+ with CONFIG_SECCOMP and CONFIG_SECCOMP_FILTER compiled in

Thanks.
Sincerely,
Robin

what's the STDOUT output? journalctl etc?

STDOUT:

Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000000dd990000,<PHONE_NUMBER>4, 0) failed; error='Cannot allocate memory' (errno=12)
#
# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (mmap) failed to map<PHONE_NUMBER>4 bytes for committing reserved > memory.
# An error report file with more information is saved as:
# /data1/upload/hadoop/hs_err_pid15016.log

See attachment for details of error log, thanks.
hs_err_pid15016.txt

Hmm this seems to be a JVM issue, which seems to be unable to start with the assigned heap size. can you try lower heap sizes (1g is default)

But I set CRATE_HEAP_SIZE=32G in Crate 0.54.11, there is no problem.

I try to set CRATE_HEAP_SIZE=24G and restart Crate 0.55.2, but there still have this problem.

Sorry, typo.  Thanks Claus.

Hmm did earlier Crate versions also have this problem? Also, are you running in a virtualized environment like OpenVZ?


Unable to configure tenant-wise EmailOTP notifications

Describe the issue:
As per [1], it is possible to have tenant-based event adapter configurations and as per [2], is it possible to have tenant-based authenticator configurations. With those both features enabled you could have one tenant sending emails with Gmail API, another with SendGrid and another one with a SMTP server.
This works as expected for event based notifications such as account confirmation, account (un)locked, password reset, etc. but it does not work for EmailOTP notifications even when the EmailOTP Authenticator has been configured to use event based notifications, i.e:
<AuthenticatorConfig name="EmailOTP" enabled="true">
    ...
    <Parameter name="useEventHandlerBasedEmailSender">true</Parameter>
    ...
</AuthenticatorConfig>

On this case IS return an authentication error, and on the wso2carbon.log we can see an exception like the next one:
ERROR {org.wso2.carbon.identity.application.authentication.framework.handler.step.impl.DefaultStepHandler} -  Authentication failed exception!
org.wso2.carbon.identity.application.authentication.framework.exception.AuthenticationFailedException: Authentication Failed: Authenticator Properties may be null
...
Caused by: org.wso2.carbon.identity.application.authentication.framework.exception.AuthenticationFailedException: Error while getting the SMTP configuration
	at org.wso2.carbon.identity.authenticator.emailotp.EmailOTPAuthenticator.sendOTP(EmailOTPAuthenticator.java:1909)
	at org.wso2.carbon.identity.authenticator.emailotp.EmailOTPAuthenticator.checkEmailOTPBehaviour(EmailOTPAuthenticator.java:511)
	at org.wso2.carbon.identity.authenticator.emailotp.EmailOTPAuthenticator.processEmailOTPFlow(EmailOTPAuthenticator.java:909)
	... 67 more

It seem to be that during the authentication flow, IS is reading the authenticator configuration from the application-authentication.xml file on the filesystem and not from the application-authentication.xml uploaded to tenant's registry [3].
How to reproduce:

Configure EmailOTP email template type and email template following the steps on [2] (Configure WSO2 IS as the email OTP provider - step # 4).
Restart WSO2 IS to apply changes.
Create a tenant and log in to management console using tenant's admin credentials.
Create an Email OTP federated Identity Provider.
Create a service provider and configure local and outbound authentication to use "EmailOTP" as a second step.
Create a user.
Configure <IS_HOME>/repository/tenants//eventpublishers/EmailPublisher.xml file following the steps on [1].
Create a copy of the <IS_HOME>/repository/conf/identity/application-authentication.xml and configure EmailOTP authenticator following the steps on [2] (Configure WSO2 IS as the email OTP provider - step # 6).
Upload this new application-authentication.xml file into the registry at /_system/governance/EmailOTP (you'll have to create the EmailOTP collection beforehand) [2] (Configure WSO2 IS as the email OTP provider - step # 6).
Log in to the service provider using the credentials of the user you've created on the above steps.

Expected behavior:

The user should receive an email with the OTP code instead of an authentication error, and
The user should receive an email with the OTP code from the adapter configured on tenant's EmailPublisher.xml file instead of the SMTP server configured on the axis2.xml file or the adapter configured on the output-event-adapter.xml file.

Environment information:

Product Version: IS 5.8.0

[1] https://docs.wso2.com/display/IS580/Sending+Tenant-Wise+Emails
[2] https://docs.wso2.com/display/IS580/Configuring+Email+OTP
[3] https://github.com/wso2-extensions/identity-outbound-auth-email-otp/blob/256002fb4b86890ab0a559bb5fe6816f1be0b709/component/authenticator/src/main/java/org/wso2/carbon/identity/authenticator/emailotp/EmailOTPAuthenticator.java#L894

Could not reproduce this issue locally in the latest IS-5.12.0-alpha19 snapshot pack. Tested with the default pack (H2 DB) using the doc provided here .
Also in IS 5.12.0, we have introduced this REST API to configure notification senders tenant-wise](https://is.docs.wso2.com/en/5.12.0/develop/notification-sender-rest-api)I[1]. This makes the life easy
[1]https://anuradha-15.medium.com/tenant-wise-email-and-sms-notification-senders-in-wso2-identity-server-43554e1a5afe
Closing this issue since this is not reproducible in the latest  IS-5.12.0-alpha19 snapshot
Related issue:
https://github.com/wso2/product-is/issues/8544


allow adding additional files to tsconfig

Maybe we should add a feature request to jsii to support adding files to the includes clause... We already support injecting exclude clauses......
Originally posted by @RomainMuller in https://github.com/aws/aws-cdk/pull/4946

I think I would rather handle it in allowing users to basically won and control the tsconfig.json file and simply ensure they're compatible with jsii requirements...

This issue has been inactive for a while, any plan to implement it. #1644 #2071 also requires this feature.
It’s a blocking issue for below scenario,
The library has some static assets not ending with .ts extension, the hardcode include in tsconfig can not package them to output folder.

See my updated issue on this, any progress / options for this?


Slow nccopy in 4.6.3+ compared to <IP_ADDRESS>

As reported by Martin Schmidt, using a 1.7GB netCDF classic file:
nccopy -k3 -d2 [infile] [outfile] takes approximately 30 seconds using netCDF-C <IP_ADDRESS>, whereas it takes nearly 100 minutes in 4.6.3, 4.7.0 and the current master.  Debugging is under way.

If the -d2 option is removed, then the speed seems ok. So I think the problem is
somehow related to zip compression usage.

A possibly related fact - my recent performance testing of PIO shows that it's an order of magnitude slower when using compression. This does not agree with what I expect from compression, which is a pretty small slowdown.

I assume that deflation was specified to force the output to be in netcdf-4 format,
correct?

Ed, is your slowdown related to the use of nccopy, or is it more general?

PIO uses deflate level of 1 by default for netCDF-4 access.
PIO does not use nccopy, it uses the C library directly for data access. So I would look for something that happened to the compression in the C library. I suspect nccopy is just seeing what is happening in the C layer, not adding any slowdown in this case.

I had the def_var_chunking code print out the chunksizes being used.
For: 	float WIND_SPEED(TIME, DEPTH, LATITUDE81_400, LONGITUDE481_840) ;
it appears to use: chunksizes var=WIND_SPEED sizes=356,1,320,360
which either is the default or is actually being specified.
In any case, this appears to be using a single chunk, which might explain the speed
issue.
[Ward can you do ncdump -hs on the file copy to verify the chunk sizes being used?]
I am going to try an experiment in specifying the chunksizes explicitly to see if that makes
a difference.

The fact that the <IP_ADDRESS> version has no such slowdown would suggest that something changed, when using compression, between <IP_ADDRESS> and the current versions.  I'll be doing some profiling as soon as I'm done here at the RMHPC symposium.

@DennisHeimbigner I'm happy to test that, but regardless of chunk sizes, changing the version of netcdf (and nothing else) sees a time increase from seconds to over an hour.  The geometry of the file will no doubt play a part overall, but holding it constant between the netCDF versions makes me think that it is not the primary issue.

@DennisHeimbigner the results of the ncdump -hs are attached below.

ncdump_wind_file.txt

So, I am not entirely certain that the <IP_ADDRESS> version is actually compressing the data.  Let me continue to investigate.

At the moment, I am pretty sure the problem is with the default chunking sizes.
If I force the use of same default chunksizes, then the time to copy
is very close to the same as seen by <IP_ADDRESS>.

More specifically, this command simulates the default chunking of <IP_ADDRESS>

./nccopy -k3 -d2 -c LONGITUDE481_840/360,LATITUDE81_400/320,DEPTH/1,TIME/1 wind_2008.nc ./junkd2.nc

I stand corrected, we did change the default chunk sizes at some point.  So, that's a great lesson learned.  I'll follow up with Martin.  So, nccopy doesn't inherit the chunk sizes when copying? I can't recall if I knew this, or if I'm surprised by it.

Thanks for your help with this Dennis; closing out this issue now as I'm confident you have solved it.
-Ward

OK, but is it really solved? Because apparently whatever changes were made to the default chunksizes resulted in a significant slowdown.
Or did I misunderstand what happened with this ticket?

I did not mean to imply we solved it. The error is that the default chunking
is being set/computed incorrectly. The question is: what changed and where?
My speculation is that there is some kind of error where specifying deflation
requires chunking on the output and that is being set incorrectly somehow.

Ok, I see that there is an error in nccopy to fix.
But AFIAK this is nccopy specific, so I do not know what the PIO issue is.
Ed - can you see if the chunking on those slow files looks reasonable?

Yes, examining the chunking is on the (long) list of things to investigate from the PIO performance effort. I will have many more details and some graphs at the June 3 NOAA meeting, which we are now calling a HPC I/O Workshop.


In nvim normal mode， the virtual  hint always twinkle

my environment:

nvim
coc-rust-analyzer

question:

I am in normal mode.When I move the cursor, then the places  I marked twinkle. Move once, twinkle once.
This problem makes me mad.How to solve it?
Run debug, how I use this button? I can't click and move on it. Or how I conceal it?

The flickering might be a bug in Coc or the editor integration, for what it's worth, although I think I've also seen it in VSCode to some extent. Have you seen it show up on other languages?
To use these code lenses, you have to define a mapping for <Plug>(coc-codelens-action) in your init.vim (see :h n_coc-codelens-action)
Re: how to disable these, they're code lenses: the config key rust-analyzer.lens.enable should do it. This is also enabled globally with the coc config item codeLens.enable (see :h coc-config-codelens).

coc-rust-analyzer is independent from the Code extension in this repo: https://github.com/fannheyward/coc-rust-analyzer/.

The flickering might be a bug in Coc or the editor integration, for what it's worth, although I think I've also seen it in VSCode to some extent. Have you seen it show up on other languages?
@lf- I have never seen this on other languages.Because I also have never seen the virtual hint text on other languages.
I learned a lot from your words. Now I have changed codelens.enable's  status to false.And my problem is solved.  :smile:
Thank you very much. :+1:


inject middleware instead of using router

after talking to derrick this is my PR for chancing from router usage to injection usage.
Possible Breaking Change: ONLY strapi.api routes can be seen.

Btw I fixed a bug you had with the contentType name as that doesn't exist.

Tested moving my code in strapi-plugin-redis over to register instead of bootstrap and it works, if we can move the provider registration to bootstrap that would be best instead of me doing this in register as it might fuck up other plugins.

After doing some basic testing it works really well and custom additional route middlewares work perfectly :+1:

Will make the provider change this evening

Can't promise I'll have time to test this before I go on vacation but I'll try

@derrickmehaffy @Boegie19 is there anything we can do to push this along?

@derrickmehaffy @Boegie19 is there anything we can do to push this along?

We will most likely wait for Strapi v5 to be released as it's gonna require an entire new rewrite most likely


[SPARK-23365][CORE] Do not adjust num executors when killing idle executors.

The ExecutorAllocationManager should not adjust the target number of
executors when killing idle executors, as it has already adjusted the
target number down based on the task backlog.
The name replace was misleading with DynamicAllocation on, as the target number
of executors is changed outside of the call to killExecutors, so I adjusted that name.  Also separated out the logic of countFailures as you don't always want that tied to replace.
While I was there I made two changes that weren't directly related to this:

Fixed countFailures in a couple cases where it was getting an incorrect value since it used to be tied to replace, eg. when killing executors on a blacklisted node.
hard error if you call sc.killExecutors with dynamic allocation on, since that's another way the ExecutorAllocationManager and the CoarseGrainedSchedulerBackend would get out of sync.

Added a unit test case which verifies that the calls to ExecutorAllocationClient do not adjust the number of executors.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/878/
Test PASSed.

Test build #87429 has started for PR 20604 at commit b5a39da.

Test build #87429 has finished for PR 20604 at commit b5a39da.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87429/
Test PASSed.

Merged build finished. Test PASSed.

Test build #87496 has started for PR 20604 at commit 4d0b52e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/926/
Test PASSed.

Test build #87496 has finished for PR 20604 at commit 4d0b52e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87496/
Test PASSed.

@tgravescs @vanzin @zsxwing could you take a look? thanks

Test build #87567 has started for PR 20604 at commit e69851b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/974/
Test PASSed.

Test build #87567 has finished for PR 20604 at commit e69851b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87567/
Test FAILed.

Jenkins, retest this please

known flaky test: https://issues.apache.org/jira/browse/SPARK-23458

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/990/
Test PASSed.

Test build #87589 has started for PR 20604 at commit e69851b.

Test build #87589 has finished for PR 20604 at commit e69851b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87589/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1022/
Test PASSed.

Test build #87635 has started for PR 20604 at commit 35314cb.

Test build #87635 has finished for PR 20604 at commit 35314cb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87635/
Test FAILed.

retest this please

Test build #87639 has started for PR 20604 at commit 35314cb.

Test build #87639 has finished for PR 20604 at commit 35314cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87639/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1107/
Test FAILed.

Test build #87722 has started for PR 20604 at commit cf7ac86.

Test build #87722 has finished for PR 20604 at commit cf7ac86.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87722/
Test PASSed.

Merged build finished. Test PASSed.

Merging to master / 2.3.

@vanzin @sitalkedia @jiangxb1987 I was looking at this code again, and I'd appreciate your thoughts on how this relates to SPARK-21834 https://github.com/apache/spark/pull/19081
I actually think that SPARK-21834 probably solves the bug I was describing initially.  I hit the bug on 2.2.0, and didn't properly understand the change of SPARK-21834 when proposing this change.  Nonetheless, I still think this fix is a good one -- it improves code clarity in general and fixes a couple other minor cases.  I'd also link the issues in jira etc. so the relationship is more clear.
I'd go even further and suggest that with this fix in, we can actually remove SPARK-21834, as its no longer necessary.  its not harmful, but its just confusing.
thoughts?

ping @squito


[bug] fix reading with to_arrow_batch_reader and limit

Fixes #1040

LGTM. Thank you for fixing this bug @kevinjqliu !


Commands: Discover contexts registered in the service provider

Fixes #2293
With this, it's now possible to have your Startup, DbContext, and Migration classes in three separate projects. But not on DNX yet because it's blocked by #2679.
Also stops throwing on DNX if Startup isn't found (fixes #2867)
Verification: Manual bashing :hammer:

:shipit:

Hi Brice,
What is (or will be) the DNX command to add a migration if Startup and DbContext are in separate projects?
Thanks!

As stated above, we need to do #2679 first, but the command will be:
cd src\MyMigrationsProject
dnx ef migrations add MyMigration --startupProject MyStartupProject

Note, the DbContext could be in a separate, third project so long as it's referenced by MyStartupProject and MyMigrationsProject.


Grpc is incompatible with tf2 if tf2 was built from source

Hello, I have tried to use seed_rl framework on local machine:
Ubuntu 18.04.5 LTS
AMD Ryzen 9 3900x 12-core
GeForce RTX 3080/PCIe/SSE2 (Gigabyte)
I installed nvidia driver 455, cuda 11.1 and Cudnn 8.0.4 according to instructions from  nvidia official website.
As far as I can tell, there aren’t tensorflow 2 builds compatible with Cuda 11.1 for now. So I build tf2 version from source using one of the latest tf-nightly commits (tf-nightly==2.5.0.dev20201025, tf.git_version == v1.12.1-44562-g33335ad96). After building tf2 tf.test.is_gpu_available() returns True and simple convnet tf2 examples also work as well as tests from cudnn samples.
I cannot start training in docker using my tf2 built from source, because I cannot use my wheel while building docker image – it raise the following error:  “wheel is not supported on this platform”. So I start training locally (local training without docker works perfectly fine with CPU only and tf==2.2), however when using seed_rl with GPU and tf2 built from sources it raises an error:
tensorflow.python.framework.errors_impl.NotFoundError: /home/nono/PycharmProjects/seed_rl/grpc/python/../grpc_cc.so: undefined symbol: _ZNK10tensorflow8OpKernel11TraceStringERKNS_15OpKernelContextEb
So I built  grpc using  builder from seed_rl repository (using tf-nightly==2.5.0.dev20201025 as tensoflow version), just adapted script a little according to https://github.com/google-research/seed_rl/issues/14 and it was built successfully and passed tests. However I experienced the same error with  this  grpc build and my tf2 version built from source (from the same commit as tf-nightly==2.5.0.dev20201025).
I want to mention that if I’m using  tf-nightly==2.5.0.dev20201025 as my local tf2 (instead of built from source)  grpc works fine (however it is not compatible with 11.1 cuda and so my GPU).
In conclusion: my problem is that RTX 3080 is compatible only with CUDA 11.1, tf2 compatible with CUDA 11.1 can only be build from source, however built from source tf2 doesn’t work with  any grpc I built (even one that was built in container with tf-nightly built from the same commit as my tf2 built).

I also tried CUDA 10.1 and CUDA 11.0.
With CUDA 10.1 seed_rl starts very slow (however this can be partially fixed with CUDA_CACHE_MAXSIZE=2147483648) and gives very strange results: looks like something wrong with computations: trained on GPU models  achieve different (usually very bad) results from trained on CPU ones and sometimes GPU’s results looks wrong.
With CUDA 11.0 tensorflow gives a lot of warnings and then crushing with “out of memory” message.
grpc_dockerfile.txt

" just adapted script a little according to #14 and it was built successfully and passed tests. " <- it passed the grpc tests? based on building with tf-nightly==2.5.0.dev20201025?

How did you make it build on tf-nightly?
Try and change the base image of Docker.grpc to
nightly-custom-op-gpu-ubuntu16

Hello. I have already used "nightly-custom-op-gpu-ubuntu16" as you can see in attached to my issue file "grpc_dockerfile.txt".

" just adapted script a little according to #14 and it was built successfully and passed tests. " <- it passed the grpc tests? based on building with tf-nightly==2.5.0.dev20201025?

Yes, it passed grpc tests while image based on nightly-custom-op-ubuntu16 as grpc_compile and i installed tf-nightly==2.5.0.dev20201025 by "RUN pip3 install tf-nightly==2.5.0.dev20201025".
I think you can reproduce it using my grpc_dockerfile which i attached to the issue.

@treeeeke
I was facing the same problem with incompatible Tensorflow.
How I managed to get it to work is by extracting the TF library from nVidia NGC container.
docker pull nvcr.io/nvidia/tensorflow:20.10-tf2-py3
/usr/local/lib/python3.6/dist-packages/tensorflow*
It is compiled with Ampere in mind.
Ugly solution though. Hope this helps.

It seems to work for me:
Use your docker file for Dockerfile.grpc
./grpc/build.sh (to update grpc_cc.so and service_pb2.py)
Add RUN pip3 install tf-nightly==2.5.0.dev20201025 in e.g. Dockerfile.atari
./run_local.sh atari r2d2 4

@treeeeke
"With CUDA 11.0 tensorflow gives a lot of warnings and then crushing with “out of memory” message."
I'm having the same problem, did u find a solution?

@mooihi @treeeeke  Is it possible that nightly-custom-op-gpu-ubuntu16 is not compatible with ubuntu18?


uboot: add hydra-build-products

Motivation for this change
This will allow users to easily download the bootloader for their device without having Nix installed.
This is what it looks like on my Hydra instance (for ubootRockPro64):

Right now, this PR applies to ubootTools as well, but I could make a flag to disable it there if you think that would be better.
cc @samueldr
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

My browser tries to load u-boot.itb as a text file, but not idbloader.img.

I don't know if the nixos.org hydra instance would act differently with regards to downloads.
Isn't that also driven by the HTTPD?

We got a request for this feature on IRC today: https://logs.nix.samueldr.com/nixos/2020-11-17#4247715;

I still think this is a good idea to have.


Pruthvi/lstm fusion

RNN fusion with LSTM cells
fusion pattern for LSTM
mkldnn RNN fprop kernel in  cpu_emitter

lstm_fprop_rnn_fusion.pdf

mkl-dnn has a new release that include the RNN preview the SHA is 0e7ca73. I think it would be better to use that one instead of the SHA in the PR

sure thanks @silee2 , i will make make that changes

@jbobba @Krovatkin please review it, when u get time

################################# with RNN fusion #################################

[pthoreho@nervana-skx21 build]$ OMP_NUM_THREADS=56 KMP_AFFINITY=granularity=fine,compact ./src/tools/nbench/nbench -f 8_layer_60_step_LSTM.json -b CPU -i 700  --timing_detail
Benchmarking 8_layer_60_step_LSTM.json, CPU backend, 700 iterations.
compile time: 2,135ms
36.7929ms per iteration

---- Aggregate times per op type ----
Rnn           36,166us
Concat           193us
Reshape          125us
Slice            121us
Add               40us
Broadcast          0us
Result             0us

---- Aggregate times per op type/shape ----
Rnn{1920, 100}           36,166us
Concat{1920, 200}           193us
Reshape{32, 200}            121us
Slice{32, 1, 200}           121us
Add{400}                     40us
Reshape{32, 60, 100}          4us
Concat{64, 100}               0us
Broadcast{32, 100}            0us
Result{32, 60, 100}           0us

################################# master without RNN fusion ####################

[pthoreho@nervana-skx21 build]$ OMP_NUM_THREADS=56 KMP_AFFINITY=granularity=fine,compact ./src/tools/nbench/nbench -f 8_layer_60_step_LSTM.json -b CPU -i 700  --timing_detail
Benchmarking 8_layer_60_step_LSTM.json, CPU backend, 700 iterations.
compile time: 51,837ms
48.13ms per iteration

---- Aggregate times per op type ----
MatMulBias     13,271us
Sigmoid         9,268us
Tanh            6,076us
Add             6,002us
Slice           4,588us
Multiply        2,924us
Reshape           183us
Concat            177us
Broadcast           0us
Result              0us

---- Aggregate times per op type/shape ----
MatMulBias{32, 400}     13,271us
Sigmoid{32, 100}         9,268us
Tanh{32, 100}            6,076us
Add{32, 400}             5,036us
Slice{32, 100}           4,383us
Multiply{32, 100}        2,924us
Add{32, 100}               966us
Slice{32, 1, 200}          205us
Reshape{32, 1, 100}        183us
Concat{32, 60, 100}        177us
Result{32, 60, 100}          0us
Broadcast{32, 100}           0us

I'm currently in the exploratory phase of RNN and LSTM fusion in the GPU transformer and am thinking it makes good sense to leverage @pruthviIntel's work here. To do so, my thought was to export the RNN and LSTM ops to ngraph core. Ideally the rnn fusion pass should be exported as well, but it looks like there are some cpu-specific implementation considerations there. I will take a look at what is needed to generalize it for core so that more backends are able to harnass it, but wanted to get @pruthviIntel and invested parties input on this before I start touching things. The rnn and lstm ops look backend agnostic, is that correct?

hi @csullivan , currently the CPU Lstm and RInn op definition are made In consistent with MKLDNN kernel.  But the API also can also be used with  directly with to the Mxnet Gluon LSTM API. In Mxnet Lstm , the parameters specified are for the fused kernel later it will get unrolled in the computational graph. we do the opposite @ ngrah level.
Mxnet LSTM API
class mxnet.gluon.rnn.LSTM(hidden_size, num_layers=1, layout='TNC', dropout=0, bidirectional=False, input_size=0, i2h_weight_initializer=None, h2h_weight_initializer=None, i2h_bias_initializer='zeros', h2h_bias_initializer='zeros', **kwargs)
layer = mx.gluon.rnn.LSTM(100, 3)
layer(input, [h0, c0])

graph CPU RNN op
            Rnn(std::shared_ptr<Node> src_layer,
                std::shared_ptr<Node> src_iter,
                std::shared_ptr<Node> weights_layer,
                std::shared_ptr<Node> weights_iter,
                std::shared_ptr<Node> bias,
                const int num_timesteps,
                const int num_gates_per_cell,
                const int src_sequence_length,
                const int src_layer_feature_size,
                const int src_iter_feature_size,
                const int num_cell_states,
                const int direction,
                const int num_fused_layers);

this is how the RNN CPU Op maps Mxnet LSTM API
direction = bidirectional
src_layer_feature_size = hidden_size
num_fused_layers = num_layers
src_layer = input
src_iter = concat(h0 , c0)
weights_layer = i2h_weight_initializer
weights_iter = h2h_weight_initializer
bias = i2h_bias_initializer + h2h_bias_initializer

I have documented other arguments in the Rnn Op definition, you can take a look. let me know if you have any more questions. :)


Update HBase-two version in phoenix connectors according to PHOENIX-6028

@stoty Could you review this change please?


feat: path operations

Just wanted to move the PR forward. Added @TeoDev1611 as a coauthor. Thanks for the initial work!
I don't think a dedicated example to deleting files is necessary. At most, I would maybe modify another example to add deleting files.
Supersedes #17

@kt3k please take a look when you have time!


Resuming from checkpoint, mid epoch gives a very distorted time estimate

Bug description
This might be related to : https://github.com/Lightning-AI/lightning/issues/13124
Currently when resuming from a deepspeed checkpoint, it seems like the time estimate, uses the "current running time" against the "total dataset steps". This gives incredibly warped numbers, when resuming mid epoch for long 1 day+ runs.
Where you can see estimates for runs which would have taken hours, being in minutes.

This can be observed even in small dataset / models, where you can see crazy it/s rates - and remaining time estimate - at the start, which improves over time, but never fall back inline with a more realistic estimate (especially if it resumed > 50% mark)
I do not have full repro steps here, but i am filing it so that others might be able to confirm / follow up on it.
What version are you seeing the problem on?
v2.0
How to reproduce the bug
No response
Error messages and logs
No response
Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @tchaton @awaelchli

To resolve this, we probably need to tweak a setting on the tqdm progress bar when resuming. Need to investigate, thanks for reporting!


bumping dev to 0b35cb28e437183d5b54e5d15053fb9f9b130239

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

It has been a few weeks since the last release, wanted to get a new dev build out


Update larastan.yml to use Larastan Org

Starting with Larastan 2.7.0, the Larastan repository will now be managed under the Larastan organization.

[x] I have not changed the README.md directly.

Awesome, thanks!


Add support for integer types for OVL input and output tensors

Currently only float and double types are supported in input and output OVL tensors. Add support for the integer types supported in tensorflow: int8, int16, int32, int64, uint8, uint16

This is currently blocked by
https://github.com/tensorflow/tensorflow/issues/1450

building tensorflow 0.11.0rc0 from source seems to have fixed the issue with int32. int64 still won't build because it seems that TF or Eigen is defining int64 to a long long int, but int64_t on 64-bit ubuntu, used in OVL cuda and c++ kernels is defined as a long int in stdint.h.

created branch integerTypes with int32 and int64 type implementation. Requires TF 0.11.0 and also defining an int64_tf type to be long long int which is not ideal...

upgrade to tensorflow 0.11.0rc1 and merged integerTypes branch


Use BeeGFS instead of NFS for multi-node jobs

Use BeeGFS to aggregrate the performance and capacity of all the nodes used by the job, rather than having an NFS server running on one of them.
https://www.beegfs.io/wiki/BeeOND
Checked for:

[x] udocker
[ ] Singularity

Checked for:

[x] Open MPI
[ ] MPICH

Also:

[ ] Find a BeeGFS health check to be used by HTCondor startd cron

Singuarlity gives "too many symbolic links" errors, needs further investigation. Try latest Singularity (not yet in EPEL)?

Singularity issue fixed in https://github.com/prominence-eosc/prominence/commit/b47e6542124cbefc4501f187c4a5aefd703bf611 and https://github.com/prominence-eosc/prominence/commit/40a8c55bc9357e3783d4fa225c21d169ad422574 (/mnt/beeond was not mounted in container, need this in addition to /home).

Closing this for the moment as we have no health checks at all yet.


Update comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.292%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
847

Relevant Lines:
988

💛  - Coveralls


Slide effect of SlideNavigationTransitionInfo goes over another control

Describe the bug
I added it in the xaml but the sliding effect seems broken, it goes over the navigation bar.
It looks less bad, if I add the effect in code and not as xaml TransitionCollection.
Look here:
https://github.com/yki5000/WinUI3_Unpackaged_CPP/issues/3
I'm on 1.3. (only use stable versions but I don't know, if this version is officially supportet because it works in the WinUI 3 gallery)
Steps to reproduce the bug

Create an unpackaged app.
Create a page with some test content.
Add a frame to the main window.
Add a NavigationView to the main window (left compact design).
Add the TransitionCollection to the frame.

<Frame.ContentTransitions>
	<TransitionCollection>
		<EdgeUIThemeTransition Edge="Left">
		</EdgeUIThemeTransition>
	</TransitionCollection>
</Frame.ContentTransitions>

Test the navigation by the navigate method, you should see the error.
For the second test just remove the  TransitionCollection from the frame and add the following code and adjust it. The error is still there but it looks less bad.

// Create the slide transition and set the transition effect to FromRight.
SlideNavigationTransitionInfo slideEffect = SlideNavigationTransitionInfo();
slideEffect.Effect(SlideNavigationTransitionEffect(SlideNavigationTransitionEffect::FromRight));
Frame().Navigate(winrt::xaml_typenameBasicNavigation::Page2(),winrt::box_value(name().Text()),slideEffect);

Expected behavior
Slide effect of SlideNavigationTransitionInfo should not go over an other control.
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.3.3: 1.3.230724000
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

If you look on my page, I tested it in c#, same result.

Have you tried putting the frame into the NavigationView.Content section?

@Ihak, thank you.
The NavigationView was not implemented correctly by me.

@ihak, thank you.
The NavigationView was not implemented correctly by me.


addTextFieldWithCustomTextField causing crash

When adding a custom textfield with only one property secureTextEntry, causing crash.
"*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UIInputWindowController selectedViewController]: unrecognized selector sent to instance 0x10a8e3200'"

My orientation management code was conflicting. so can be treated as invalid defect.


Replace specs2 with hedgehog

Replace specs2 with hedgehog

Added Gens to replace Arbitraries
Test code has been rewritten using Hedgehog
Specs2 and ScalaCheck were removed from libraryDependencies

👍
You mind rebasing?

Let me know when you're ready to merge

@charleso OK, thanks!

@charleso Ready to merge.

Nice one Kev!


1.19.2 mob bugs

sunken skeletons missing coral sticking out head.

wildfire and redstone golem colors are too dark when glowing using oculus/shaders. for reference img 1-2 w out oculus. img 3-4 using oculus. colors seem off using oculus as well.

Geckolib and shaders aren't exactly compatible. We'll see what we can do in regards to it, though.


K9 Notification Sound

I changed the notification sound on my phone, K9 stuck with the previous sound while all other apps adopted the new one. My expectations are that the app respects the system-wide settings to do with notifications.
Unfortunately I cannot supply a log because I don't own a usb-c usb-a cable.
K9 version 5.600
Stock Android 10
Pixel 2 XL
The issue is app-wide
The notification setup initially was sound and vibration.
I changed the notification sound and K9 retained the previous sound along with vibration.
I tried these things and none fixed the issue:
Restarting the phone
Cleared cache
Removed accounts and cleared app data
Uninstalled, restarted the phone and re-installed app - The app persisted with the original sound + vibration once installed
Deleting the cache(?) of the previous notification sound

This stopped K9 using the previous notification sound, instead silence and vibration remained
Switching off all notification sounds bar the ring-tone, switching off vibration too then switching them all back on again
I checked the app was setup to notify me using sound
Currently, the app notifies using vibration only.
Just as an aside, the link to documentation provided in .github/CONTRIBUTING.md, * User Manual, 404's, it leads to https://k9mail.app/documentation.html, perhaps it should be https://k9mail.app/contribute#documentation?
Thank you

K-9 Mail 5.600 doesn't support the new notification channel system introduced with Android 8. Try using the latest beta version of K-9 Mail.

Oh I see! I hadn't realised the app hadn't been updated since 2018, shows how observant I am! Made more sense when I read this: https://k9mail.app/2020/06/01/Whats-Up-With-K-9-Mail.html
I'm using the beta, seems great, familiar but different. Notifications working as I would expect so closing this.
Thank you


Fix site deployment

Fix site deployment by doing:

Commit some resources
Add the build.sh script back as it was when we recently removed it [0]
Remove the gh-pages CI job

Please see last patch for explanation and reasoning.
[0] I ran the build script, site is live now with the new cookbook!

cc @realeinherjar
Happy to take your input on the repository separation but as I see it I still think the separation is valid. Also this PR requires the least work by Andrew since everything is already set up like this. (He has admin perms to the org.)

I think that we should think what is best in the long-term.
First, repository separation:
I think we should delete/archive rust-bitcoin/www.rust-bitcoin.org
and move all publishing activities to rust-bitcoin/rust-bitcoin.github.io.
The problem is that GitHub Pages hardcodes the main landing page for any hosted GitHub Pages to the orgname.github.io repo.
I searched this extensively and I cannot find a workaround to circumvent this.
Any other organization repo, e.g. orgname/repo, that publishes a GitHub Pages would be accessible in www.orgname.com/repo.
Hence, that's why the GitHub Pages deployment in rust-bitcoin/www.rust-bitcoin.org redirects to http://rust-bitcoin.org/www.rust-bitcoin.org/.
Thus, if we keep committing on rust-bitcoin/www.rust-bitcoin.org, we will have to do the duplicate work to update the same changes to rust-bitcoin/rust-bitcoin.github.io.
It doesn't make sense...
Second, the bash script:
I don't think a bash script is the least work.
Someone needs to run it.
Additionally, it depends on Hugo and mdbook, so who is in charge of running it also needs to keep Hugo and mdbook installed, updated and maintained.
We already saw a problem with an older version of mdbook not rendering code locally correct, as in https://github.com/rust-bitcoin/www.rust-bitcoin.org/pull/9#discussion_r1336371630.
The GH Action is the least effort it runs every time there's a new change on master rebuilds the website and publishes it.
No need to run any bash script.
No need for you or andrew to do anything.
Conclusion: if we archive/delete rust-bitcoin/www.rust-bitcoin.org and move all activities (including the GH Pages CI action) to rust-bitcoin/rust-bitcoin.github.io will be most logical and easy to maintain course of action. No need for duplicate work or bash scripts that depend on someone's local dependencies.

I had a bit more of a read of the github docs, it seems we have two options

deploy from branch
deploy with github actions

I believe you are suggesting we use (2). A few problems I see

Its in beta
It supports Jekyll sites or static HTML

So it looks like to get our build to work we have to do custom stuff, am I missing something?
Said another way, where do you propose the static site files go once built? In the gh-pages job that is removed in this PR I don't understand where they will live after the build VM goes away?

Humour me with one more question, have you got a live site already that uses your proposed set up or are we learning as we go?

So it looks like to get our build to work we have to do custom stuff, am I missing something?

We need to do what we are doing here (including the GH Actions CI) in rust-bitcoin/rust-bitcoin.github.io.

Said another way, where do you propose the static site files go once built? In the gh-pages job that is removed in this PR I don't understand where they will live after the build VM goes away?

It is a static site, or client-side rendered. GH Pages do not support server-side rendering.
The GH Pages CI renders everything (hugo and mdbook) and then commits the server HTML, CSS and JS code into the gh-pages in the / root folder.
GH Pages then monitors that gh-pages branch and redeploy on changes.
Everything that you do with your build.sh is automated and done by the GH Pages CI.

oooo, the gh-pages branch was the piece I was missing. I'm going to push the current state of master on this repo to the https://github.com/rust-bitcoin/rust-bitcoin.github.io/settings/pages repo and configure that repo to use the gh-pages branch. I'm don't know what the current behaviour of that repo is in regards to running the actions though. I'll manually create the gh-pages branch with the current site on it so that we don't get down time. Then next time we push to master we will see if it re-builds.

I'm going to push the current state of master on this repo to the https://github.com/rust-bitcoin/rust-bitcoin.github.io/settings/pages repo and configure that repo to use the gh-pages branch.

I don't follow. You mean rust-bitcoin/www.rust-bitcoin.org/master to rust-bitcoin/rust-bitcoin.github.io/master?
If yes,
I am confident that the it will work.
I did all this here thinking that this was the repo behind <www.rust-bitcoin.org>.
So what if we archive this repo and migrate all issues and PRs to rust-bitcoin/rust-bitcoin.github.io?

I've got a bad feeling its not going to handle the submodule (site/themes/nightfall). I'm going to push it anyway, lets see.

I'm going to push the current state of master on this repo to the https://github.com/rust-bitcoin/rust-bitcoin.github.io/settings/pages repo and configure that repo to use the gh-pages branch.

I don't follow. You mean rust-bitcoin/www.rust-bitcoin.org/master to rust-bitcoin/rust-bitcoin.github.io/master?

My bad, cut'n'pasta fail.

If yes, I am confident that the it will work. I did all this here thinking that this was the repo behind <www.rust-bitcoin.org>.
So what if we archive this repo and migrate all issues and PRs to rust-bitcoin/rust-bitcoin.github.io?

@apoelstra, I've been intentionally not mentioning you to shield you from all this but now we need you to please update some settings. To save you reading everything this is whats happened:

I migrated all the source code from github.com/rust-bitcoin/www.rust-bitcoin.org to https://github.com/rust-bitcoin/rust-bitcoin.github.io (I created a couple of patches on master in my tree then pushed to upstream).
First I branched off gh-pages on that repo and pushed that branch, and configured the repo to serve from that branch
Now, in order for the github actions to run (build and deploy on push to master) we need your perms to set the github actions settings please

# This needs the following setting:
# Setttings > Actions > General > Workflow permissions
# change to "Read and write permissions"

Once that is all done we can:

Migrate issues/PRs from www.rust-bitcoin.org to this repo
Archive www.rust-bitcoin.org
Stop pushing to master and go back to only PRing things in - bad Tobin, no biscuit.

Any updates on this?

Just looking at this now, sorry, sometimes I forget to look at the github notification "reason" column and miss mentions.

@tcharding I think the "read and write permissions" setting is already set.

We don't want to go this direction.


feat(Form): improve form control and input validation trigger

This PR aims to give more control over the form component and improve input validation. It features:

triggering validation on input events.
a new prop validate-on to specify when validation should happen
a function to clear form validation errors.
a function to manually set errors.
an example with back-end validation errors.

Should solve #475 #474 #480

@benjamincanac I merged this branch with https://github.com/nuxtlabs/ui/pull/491 to fix conflicts and make it easier to test.

@romhml Do you need me to wait on merging #496 and #497 as you're in the middle of a large refactor?

No you can go ahead, it should be easy to merge

@benjamincanac I'm almost done with the changes, I just need to improve the documentation. Do you know if it's possible to replicate the ComponentProps layout for exposed attributes?

What do you mean by exposed attributes?

The Form's public functions here:
https://github.com/nuxtlabs/ui/pull/487/files#diff-c923347138b9a573e905bb6bdffe4e52ba34f7f220fdadf5b5c4011cf73298a9R100-R125

Have you tried setting componentMeta.metaFields.exposed to true in docs/nuxt.config.ts?

Just tried it, it breaks everything:
[nuxt-component-meta 2:29:20 PM] ✔ Components metas parsed in 3444.11ms

[2:29:40 PM]  ERROR  Cannot start nuxt:  Invalid string length

  at JSON.stringify (<anonymous>)
  at getStringifiedComponents (node_modules/.pnpm/nuxt-component-meta@0.5.3_rollup@3.26.2/node_modules/nuxt-component-meta/dist/parser.mjs:62:47)
  at getVirtualModuleContent (node_modules/.pnpm/nuxt-component-meta@0.5.3_rollup@3.26.2/node_modules/nuxt-component-meta/dist/parser.mjs:63:59)
  at Object.updateOutput (node_modules/.pnpm/nuxt-component-meta@0.5.3_rollup@3.26.2/node_modules/nuxt-component-meta/dist/parser.mjs:89:18)
  at async Context.buildStart (node_modules/.pnpm/nuxt-component-meta@0.5.3_rollup@3.26.2/node_modules/nuxt-component-meta/dist/module.mjs:24:9)
  at async Promise.all (index 8)
  at async hookParallel (node_modules/.pnpm/vite@4.3.9_@types+node@20.4.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:42512:9)
  at async Object.buildStart (node_modules/.pnpm/vite@4.3.9_@types+node@20.4.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:42824:13)
  at async node_modules/.pnpm/vite@4.3.9_@types+node@20.4.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:63536:13
  at async _createServer (node_modules/.pnpm/vite@4.3.9_@types+node@20.4.5/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:63566:9)

Mmmh, it might be easier to document this manually then.

@romhml I've updated the resolves in the pr description, can you confirm?

Thanks! I'll have a look in the afternoon and wrap things up. Sorry for the delay I did not have a lot on of time this week.

@benjamincanac I applied your suggestions, and I can confirm that all the issues you mentioned will be solved by this PR.

Thanks! I'll have a look in the afternoon to wrap everything up. Sorry for the delay I did not have a lot on of time this week.

No worries at all! Thanks a lot for the changes 😊
I've updated the API section if you want to take a look!

Looks good! Thanks!

@romhml Not sure about my last commit: caebf48 (#487), there was an error when clicking any checkbox in the documentation (to toggle the props). Do we need to make the name prop required?

It might be better to emit the event only if the path is provided in emitFormEvent

Can I let you improve it? 😊

@benjamincanac Never mind what I had in mind did not work. Your changes are good to go as is, no need for requiring the name attribute since it's only needed if used with the form component.


Console output disappears on PowerShell + ConEmu

- Do you want to request a feature or report a bug?
Bug.
- What is the current behavior?
I'm on Windows and I use ConEmu as my console emulator. Whenever I run netlify through ConEmu on PowerShell, the colours break to the point where no text is visible on the console unless I select a block of text. It also persists after the command is finished, even after running cls.

- If the current behavior is a bug, please provide the steps to reproduce.

Install ConEmu.
Run a PowerShell console through ConEmu.
Run netlify.
Text disappears.

- What is the expected behavior?
Normal behaviour when running through a regular cmd/powershell window:

- Please mention your node.js, and operating system version.

Node 8.9.0
Windows 10 (x64) Build 16299

Looks OK in my ConEmu/PowerShell:

so we must be using different color schemes.  Here's what I have in Settings > Features > Colors:

Also, one of the cool things about ConEmu is that it live updates the console window when you change the colors, so you can have the window open with the netlify-cli text, then scroll through the different color schemes (or change colors individually) until you see the text.

@verythorough Hmm, this is weird, tried cycling through the color schemes, nothing else worked except PowerShell (but only briefly):

But when I switch to it, it broke again.

I was using the Ubuntu color scheme, with no additional configuration.

Hm, that is so strange!
I'm curious—have you tried the Go-based cli tool, netlifyctl? I wonder if it has the same issue. We'll be focusing future development efforts on that client, so I recommend giving it a try. (It just recently reached feature equivalence with netlify-cli, so we're in the process of updating the docs to match, but all commands described in the docs are available in netlifyctl in the same way they're available in netlify-cli.)

@verythorough Hey, sorry for taking too long to get back to you!
And yeah, using netlifyctl fixed the colours. Thanks!


only one svgspace possible

heyho @williamngan! 🌳 🌾
you can make a microwaved quick meal, or you can take the full on adventure time travel to dinosaur land. and this for me is pts. wow. what an amazing library! and i am just scratching the surface.. 🤯
because of performance issues with the canvas element and locomotive-scroll in safari, i had to switch to the svg renderer which works beautifully fine, even though its still marked as experimental.
there's just one major problem i am facing. i can only get one svg space working at the same time. as soon as i create more than one, it only renders the last one.
i created a pretty basic pen just to demonstrate. actually we should be able to see two lines here. but we only see one. is it me who's not understanding how to setup the library correctly, or is there something wrong on the other side?
https://codepen.io/jaro_io/pen/MWjpZxL
thank you so much for taking a quick look!
jaro
🐤

Heyho @jaro-io 😃 Thanks for trying out Pts and sending the detailed bug report.
Looks like there's a bug here where the svg id won't get updated unless you passed an svg element.
I'll patch this soon in the next release. But a quick fix now would be to add an empty  element inside the div. Eg:

<svg id="one" />

<svg id="two" />

Just curious what kind of performance issue did you encounter with Safari -- can you create a new issue when you get a chance?
Thanks again. Cheers!

wow, thank you for the super fast heads-up. 🤞🏻 i already had the same idea, but in my specific case, it didn't fix the problem. in fact, in the pen it does. so i'll investigate! trying to find out how i can reproduce my problem here. i will let you know soon!

hello again @williamngan!
i changed my pen to illustrate what i meant yesterday. even though now i have two empty svg elements with unique ids, the library is still only rendering one of the two lines. it does add all the setup attributes to the second svg element, but the svg itself stays empty.
https://codepen.io/jaro_io/pen/NWRjPpg
when this is still nothing on my end (please check my code, i only just started), it might be another bug or related to the one we found yesterday.
thank you so much for looking into this!
jaro
🍯

Thanks @jaro-io -- I should have a patch coming later today or tomorrow. Hang on :)

@williamngan thank you so much for the immediate support! 🍡

v0.9.6 should fix this issue hopefully. Give it a try.

thank you so much @williamngan. that was super fast. 😮 it did in fact fix something but not everything.
when using empty svg elements with unique ids it works fine, as long as i use an id string (like '#custom-id') to create the new svg space.

if i pass the svg element via javascript directly when creating the space, it still only renders the first of all animations.
if i add an empty div to my site and pass its unqiue id string to create the space, it does the same thing. so only rendering one animation.

we're getting there.
but please don't stress yourself. with the empty svg elements i now have a working solution!
again, thank you!
🌾

The empty div with id approach should work. I tested with your CodePen example and it seems to work. Can you check if you're using v0.9.6?
Here's an example:

There might be another issue with "svg element" approach -- I'll take a look.
Thanks!

you're right. sorry, this has been a mistake on my end. so, passing ids as a string when creating a new SVGSpace works fine when targeting both svgs and divs.
only passing javascript elements, like you can do with CanvasSpaces, is not working yet.
🦾

Hi, closing this now. Please reopen if it continues to be an issue.


Adjust permissions so that Cassandra can run without root access

Allows both non root access as well as running with --user=<random id>
This makes the Cassandra example run on OpenShift.

LGTM


[CT-642] Schema change detected for bigint columns (expected long)

Describe the bug
Incremental model doesn't run with bigint column.
Steps To Reproduce
Create an incremental model on a table with a bigint column, run it.
Expected behavior
It should fail with a schema change error.
Screenshots and log output
        Source columns: [<SparkColumn device_id (string)>, <SparkColumn app (string)>, <SparkColumn event_date (string)>, <SparkColumn event_timestamp (bigint)>, <SparkColumn session_id (string)>, <SparkColumn merge_key (string)>]
        Target columns: [<SparkColumn device_id (string)>, <SparkColumn app (string)>, <SparkColumn event_date (string)>, <SparkColumn event_timestamp (long)>, <SparkColumn session_id (string)>, <SparkColumn merge_key (string)>]

System information
dbt-core 1.1.0
dbt-databricks 1.1.0
The operating system you're using:
The output of python --version:
Additional context
It looks like the relations cache is using show table extended while for the temp view dbt uses describe table they return different data types for the Biging columns.

@francescomucio Thanks for opening! Context from Slack thread here.
It looks like bigint and long are aliases for one another in Databricks SQL: https://docs.databricks.com/sql/language-manual/data-types/bigint-type.html
There's a specific fix we can make here: Add a mapping between those types within SparkColumn, for use in the translate_type method here:
https://github.com/dbt-labs/dbt-spark/blob/f03d217ebb004bb889eff80d61da14bc72983370/dbt/adapters/spark/column.py#L21-L23
On other databases, we use that translate_type method to handle type aliasing. Check out the default implementation in dbt-core here.
the fix
I think this might be as simple as:

removing the translate_type override in dbt-spark
using the default version instead, while also overriding the standard mapping to support just long → bigint:

class Column:
    TYPE_LABELS: ClassVar[Dict[str, str]] = {
        "LONG": "BIGINT",
    }

Plus a test case, for exactly the experience you're having. We have existing integration tests for on_schema_change functionality in tests/integration/incremental_on_schema_change.
Is that a fix you'd be interested in contributing?
larger context
In v1.2, we are looking to move away from using show table extended for top-of-run caching, and use show tables + show views instead (much much faster: #342). That would then mean we always use describe table to power adapter.get_columns_in_relation, with consistent results.

I can contribute with a quick fix, let me try :)


Fix spelling on SuggestionCompoonent

While I was hacking away on adding clickable suggestions, I noticed the misspelling in SuggestionCompoonent.
Is there any reason why it was named that way ?
Anyway, this PR renames the React component SuggestionCompoonent to SuggestionComponent
I've run ag on the codebase to make sure I caught all occurences. Looks like the component is not used outside of this single file.

@j-allard, thank you. I try to have as few rules about PRs as possible because people hate rules. So, in case you plan to contribute further, you don't have to create a separate PR for this, just fix what you think is wrong along with some feature. But separate PRs are good too. :)


Serialized directive definitions do not follow the GraphQL Specification

As part of #716 directive definitions are not included in the serialized schema. It looks like the format does not follow the specification.
For example in a stitched schema the @source directive is used. It's current serialization looks like the following:
"Annotates the original name of a type."
directive @source("The original name of the annotated type." name: Name! "The name of the schema to which this type belongs to." schema: Name!) repeatable on Enum | Object | Interface | Union | InputObject | FieldDefinition | InputFieldDefinition | ArgumentDefinition | EnumValue

I would expect something like
"Annotates the original name of a type."
directive @source("The original name of the annotated type." name: Name! "The name of the schema to which this type belongs to." schema: Name!) on ENUM | OBJECT | INTERFACE | UNION | INPUT_OBJECT | FIELD_DEFINITION | INPUT_FIELD_DEFINITION | ARGUMENT_DEFINITION | ENUM_VALUE

The important differences besides the casing on the locations are:

The repeatable concept for directives is not part of the specification.
FieldDefinition vs FIELD_DEFINITION.

The repeatable concept for directives is not part of the specification.

Repeatable is becoming part of the draft specification. We are implementing features once they become draft status.
https://github.com/graphql/graphql-spec/pull/472/files

Thought it may be something like that and checked the draft specifications. what's the official status if it hasn't actually been merged yet?
This leaves us in a bit of a tough place as a lot of other tools such as GraphQL Code Generator don't support that unpublished draft spec.

But are you using isrepeatable?


Revert disconnect changes

I have no idea how I missed it during code review.

This change is

PR is added to the queue for testing as 2. task. (ad55a3e)

PR is added to the queue for testing as 3. task. (cda3355)

Test 112066071 (ad55a3e) build started.

Test (Fail) 112066071 build is completed (ad55a3e)
See https://github.com/ThaliTester/TestResults/tree/112066071ad55a3e_Revert_disconnect_changes_chapko/ for the logs

Test 112066071 (cda3355) build started.

Test (Fail) 112066071 build is completed (cda3355)
See https://github.com/ThaliTester/TestResults/tree/112066071cda3355_Revert_disconnect_changes_chapko/ for the logs

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable