Cant Destroy Entity In Multi Pools with Multi Systems

i have controller create systems (warp logic systems)
public class BattleController : MonoBehaviour {

    Systems _systems;

	// Use this for initialization
	void Start () {
        InitSystems(Pools.game);

    }

	// Update is called once per frame
	void Update () {
        _systems.Execute();
	}

    void InitSystems(Pool pool)
    {
        _systems = new Feature("BattleSystems")

            // init sys
            .Add(pool.CreateSystem<CreateBattleSystem>())

            // add tick logic systems.
            .Add(new BattleLogicSystems("LogicSystems", pool)

                    .Add(pool.CreateSystem<TickSystem>())

                    .Add(pool.CreateSystem<InputSystem>())

                    // reactive
                    .Add(pool.CreateSystem<DestroySystem>())
                    .Add(pool.CreateSystem<MoveSystem>())

                    )

            ;

        _systems.Initialize();
    }

}

i have two Pool named "Game" and "Core"
i have create test player entity like this
public class CreateBattleSystem : IInitializeSystem, ISetPool {

    Pool _pool;

    public void SetPool(Pool pool)
    {
        this._pool = pool;
    }

    public void Initialize()
    {
        // 1、创建玩家角色
        _pool.CreateEntity()
            .IsPlayer(true)
            .AddPosition(0, 0, 0)
            .AddMove(1.0f, 5.0f, 1.0f)
            .AddName("chiuan",1)
            ;

    }

}

and test destroy entity like this
Pools.game.playerEntity.IsDestroy(true);

but!
i found the entity cant destroy and DestroySystem wont hit the IReactiveSystem
public class DestroySystem : IReactiveSystem, ISetPool, IEnsureComponents
{
    Pool _pool;

    public IMatcher ensureComponents
    {
        get
        {
            return GameMatcher.Destroy;
        }
    }

    public TriggerOnEvent trigger
    {
        get
        {
            return GameMatcher.Destroy.OnEntityAdded();
        }
    }

    public void Execute(List<Entity> entities)
    {
        foreach(Entity e in entities)
        {
            TTDebuger.Log("entity destroy > " + e.name.ToString());

            _pool.DestroyEntity(e);
        }
    }

    public void SetPool(Pool pool)
    {
        this._pool = pool;
    }
}

but , when i modify the DestroyComponent attr from
[Game]
public class DestroyComponent : IComponent {
}

to
[Game,Core]
public class DestroyComponent : IComponent {
}

and Destroy works well!
i am confused.
because create the 2 systems using the game pool of cause.
by the way,only TickComponent here contains all Pools attributes.
[Core,Game,SingleEntity]
public class TickComponent : IComponent {
    public long currentTick;
}

by the way,i have checkout the usage of multi pools in Example demo project > https://github.com/JuDelCo/Shmup-AAA-plus
but if i use multisystems ,wont worked in some system.

solve this error in #120


How to configure pdf_generator to use local installation of chrome-headless-render-pdf and puppeteer?

Hello all!
I've already posted this issue in this Elixir Forum post, where I was advised to open an issue on Github: https://elixirforum.com/t/how-to-configure-pdf-generator-to-use-local-installation-of-chrome-headless-render-pdf-and-puppeteer/28714
Maybe I'll some guidance here too. But here is a copy just in case:
I managed to use pdf_generator with chrome-headless-render-pdf and puppeteer installed globally. Now I'd rather have both packages installed locally, however I couldn't find a way to make it work.
I tried to install both packages within the /assets folder by running the npm install chrome-headless-render-pdf puppeteer command.
This did not work as pdf_generator expect chrome-headless-render-pdf to be in _build/dev/lib/pdf_generator/priv/node_modules/chrome-headless-render-pdf/dist/cli/chrome-headless-render-pdf.js
After reading the README.md, and implementing the instructions for a local chrome install, I still get the same error.
Basically what I did is:

added {:pdf_generator, ">=0.6.0", compile: "make chrome"} to mix.exs
run make priv/node_modules which returns me this error make: *** No rule to make target 'priv/node_modules'.  Stop.
run cd priv && npm install and rerun the above mentioned command, which still gets me the same make error.
run mix deps.get and mix phx.server which return me this error make: *** No rule to make target 'chrome'.  Stop. ** (Mix) Could not compile dependency :pdf_generator, "make chrome" command failed. You can recompile this dependency with "mix deps.compile pdf_generator", update it with "mix deps.update pdf_generator" or clean it with "mix deps.clean pdf_generator" with none of the mentioned command working.

Any tipps?
I have GNU Make 4.1, nodejs v12.14.1, npm 6.13.4 and Elixir 1.10.0.

Installing via Hex the priv directory is missing, in the same way like different files... I solved this using:
{:pdf_generator, "~> 0.6.0", github: "gutschilla/elixir-pdf-generator", compile: "make chrome"},

@manuel-rubio thanks for pointing this out! :+1:

Adressed in https://github.com/gutschilla/elixir-pdf-generator/releases/tag/v0.6.2
Using hex shpould be fine now. The mix file was missing the priv dir. Again, thanks a lot for reporting the issue!


Add functionality to detect a site's .well-known.gpc.json response

As @dknopf mentioned in our discussion today, we may want to display a site's response to receiving a Do Not Sell signal as the site expresses it in its .well-known.gpc.json file. Essentially, this means to check for every site visit whether there is something available at www.example.com/.well-known.gpc.json. If so, retrieve that content and display it in OptMeowt. There are various points this functionality may touch upon, among others, OptMeowt's performance and where and how in OptMeowt this content should be displayed. For the time being this is not urgent and we can make this issue more concrete later on.

As @kalicki1 suggested, we may want to have the icon fully green for half a second or something like that. In addition, maybe some explanation or visual or UI design element in the popup to explain what the fully green icon means.

I implemented the .well-known green icon functionality in the last commit I pushed to this issue. Once we merge our open pull request regarding the Firefox fixes, we can merge this issue into the main branch as well.

Excellent!

Feel free to close, @kalicki1, if you feel this is done.


Warn about encrypted rooms

Fixes #129

It doesn't look like this handles rooms the bridge is already in that are encrypted. Is that intentional?

@turt2live Kinda sorta, I don't know if we are allowed to post unencrypted messages to encrypted rooms which the bridge would have to do. I guess you can do it, but I thought it wasn't recommended.
OH, also we can't decrypt bot commands anyway.


Fixed hyperlink formatting

Presumably an omission when this document was converted to markdown.

@chrisbrownie,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Add Dolphin Sockets Tests to the regression tests

There's not much there, but sure, why not run it. Had to remove a couple assertions about host names--it's hard to come up with a host name that has a stable IP address and reverse-DNS record...

Huh, I see that InternetAddressTest>>testLocalHost failed in the CI build. It works on my machine, which I'm guessing comes down to a difference in configuration. The test should obviously not be that brittle, but I don't even know how exactly it's failing in CI. Any thoughts?

How about google-public-dns-a.google.com?
Regarding the failing test, I would start by adding some descriptions to the assertions in the test, and also replacing any generic assert: expressions with assert:equals:, etc, where appropriate. You might also want to consider setting up an appveyor build on your fork to make it easier to run a bunch of test commits through builds. This is relatively straightforward as the build is described in a checked in yaml file.

Good ideas, thanks—trying them out, we'll see how it goes with testLocalHost. Is there a problem with just using the automatic AppVeyor build here? If it costs you money or bothers you with emails or something I can set up my own, but otherwise that seems like what it's for...

No problem at all. The only reason I suggested it was because finding there are errors after raising a PR is a little late. By the time I raise a PR I prefer to know that I'm done apart from responding to code review comments, but please work in whatever way you prefer.
BTW: I don't think it would be unreasonable to add a 'self skipIfCiBuild' to the failing test and raise an issue to track it. It still represents a useful improvement.

As this has been waiting here for a month and a half, I'm going to merge it even though that will break the build. I'll then add a skip for the test that doesn't run on the CI machine.

Sorry for letting this slip through the cracks—I more or less meant to do that (add a skip) myself, and just kept not getting around to it. Thanks for taking care of it.


PR: develop, Remove bound check during auto scrolling

Change log

Remove bound check during auto scrolling

Dsecription
AS-IS
private func checkPointToScroll() {
    ...
    if scrollWeight > 0 {
        if scrollDirection == .horizontal {
            if contentOffset.x >= startBound && contentOffset.x <= endBound {
                addScrollDisplayLink()
            }
        }
        ...
    }
    ...
}

TO-BE
private func checkPointToScroll() {
    ...
    if scrollWeight > 0 {
        addScrollDisplayLink()
    }
    ...
}

This condition is meaningless in auto scroll process. because content offset be in bound range. So this condition will be true always. (but modify reason isn't this 😅)
When touch collection view's edges to scroll, It call display link -> handler -> invalidate display link every time.
contentOffset.x >= startBound && contentOffset.x <= endBound

Discussion
I set content offset using min, max to adjust value during auto scrolling. but offset value is out of my expect sometimes...
I think that remove bound check condition is way to solve this problem. So modified it.

LGTM


.NET Standard

Can this library support .NET standard and not .NET Core 3

It's possible now to target .netstandard 2.0. However, on Windows some of the UWP Notifications API is not available under this TFM.


Use JSON instead of "PHP-style nested object syntax" to send actual data types in the metadata

Currently, because bugsnag-js serializes metadata as "PHP-style nested objects" into the query string, the actual data types get lost.
https://github.com/bugsnag/bugsnag-js/blob/9fc759f7c5ecdab9d13a23ac321a106d9f1dc913/src/bugsnag.js#L753-L756
Preserving the data types in the reports is important to debug certain type-related issues which are not uncommon in weakly typed JavaScript.
The data types could be preserved by using JSON.
The public Bugsnag API is advertised to take JSON payload: https://docs.bugsnag.com/api/error-reporting/#json-payload

I would be interested to see the size difference of using JSON instead, as I know the keys kinda add some redundancy to the payload right now.
The main issue I see here is the fact that IE6 & 7 (and in some cases IE8) (caniuse.com) don't support JSON.stringify. But the notifier needs to support them.
I don't see an issue with conditionally stringifying the payload based on what's available in the browser - using the current method as a fallback if JSON.stringify isn't supported. It probably wouldn't be the best idea to include a JSON shim just for some of the legacy browsers.

On a quite nested payload (redux state of a large app), JSON is twice shorter:
serialize(params).length
22650

JSON.stringify(params).length
12378

Note that JSON.stringify throws on circular references in data structures, so you'd like to apply something like this: https://github.com/sindresorhus/serialize-error/blob/9ea5d5332d2cf6516de05166f31c883dd42bbc54/index.js before applying JSON.stringify (there isn't much additional code, especially if compressed).
Moreover, serialize-error is smarter in handing circular data structures than the current version of bugsnag-js because it does not limit the depth globally, rather it only prevents actual circular references.

I was wrong to include the raw, non-URL-encoded JSON size, but the URL-encoded size it still less:
serialize(params).length
22672

JSON.stringify(params).length
12398

encodeURIComponent(JSON.stringify(params)).length
17252

Btw, can the current Bugsnag API accept JSON payload in the query string, in a GET request?

I was wrong to include the raw, non-URL-encoded JSON size, but the URL-encoded size it still less:
serialize(params).length
22672

JSON.stringify(params).length
12398

encodeURIComponent(JSON.stringify(params)).length
17252

That's not a terrible saving. Every little counts.

Btw, can the current Bugsnag API accept JSON payload in the query string, in a GET request?

It doesn't seem to be possible with the current "general" notifier endpoint, because GET requests can't have a body.
Though seeing as the payload is structured differently for the JS notifier anyway, if the current JS endpoint accepted both the JSON & "PHP-style" format, it would make it even easier - as far as the changes required in the notifier.

Though seeing as the payload is structured differently for the JS notifier anyway, if the current JS endpoint accepted both the JSON & "PHP-style" format, it would make it even easier - as far as the changes required in the notifier.

Are you in the Bugsnag team? There isn't any public documentation of that special "js" endpoint...

Oops looks like my example payload, being sent as query string (either serialize or JSON), may hit the URL length limit in some browsers: http://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string (fortunately, it hasn't hit it with the Bugsnag API server yet).

Are you in the Bugsnag team? There isn't any public documentation of that special "js" endpoint...

No, I'm not. And I'm not sure there is any documentation for it - but you can open up the network tab (in Chrome) and take a look at what gets sent. Or you could do a bit of code diving 😛

Oops looks like my example payload, being sent as query string (either serialize or JSON), may hit the URL length limit in some browsers: http://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string (fortunately, it hasn't hit it with the Bugsnag API server yet).

Yeah that's the main issue, and why every little really does help.

I took a look at an example event (from the app I work on), and these are my results.
encodeURIComponent(JSON.stringify(params)).length
6915

serialize(params).length
7488

And I'm not sure there is any documentation for it - but you can open up the network tab (in Chrome) and take a look at what gets sent. Or you could do a bit of code diving 😛

Yes, I did that. I mean, to learn if there are other types of requests it can possibly accept.

I am thinking that an option to specify a custom transport to send requests would be useful here. This way an app could implement both sendBeacon (which is URL-limited as well) and POST JSON.
And I'm thinking unfortunately I'll have to abandon bugsnag-js for now and implement requests to the "general" Bugsnag API with JSON Payload. :(
I'd like to reuse what it adds on top, but these URL and serialization limitations are quite critical to me, as I'd like to be able to analyze the full app state in the error condition.

@sompylasar I think the easiest way to accomplish what you are trying to do is with a beforeNotify callback.  This is called immediately before the request is made. In it you could use your own serialization and request logic and still benefit from all the features of the library. Just be sure to return false from the callback or it will perform duplicate requests.
Bugsnag.beforeNotify = function(payload) {
  // custom serialization and request logic

 return false;
}

The only other thing you would be missing is this one check that we do to filter out indecipherable cross-domain and eval script errors, but you could also paste that into your beforeNotify callback.
We recommend however that you continue using the JS endpoint with the payload in the url query string (as this endpoint doesn't support posting JSON). The JS endpoint pulls out some metadata (ip address, user agent, referer) from the request itself because it is assumed to come from the user directly. If you wanted to use the main notifier endpoint you would have to collect this information manually and include it in the payload metadata in order to take advantage of it.

@wordofchristian Looks good, thank you! I missed this part If you want to halt the notification completely, return false from this function. in the docs.
I'm sure this
if (payload.lineNumber === 0 && (/Script error\.?/).test(payload.message)) {

is not the only error that needs to be filtered. I previously made a custom error reporter, similar to bugsnag but proprietary, for a world-wide product, and we filtered lots of false reports including this one (there was a hundred lines of code just for filtering false positives observed in different browsers and conditions).

We recommend however that you continue using the JS endpoint with the payload in the url query string (as this endpoint doesn't support posting JSON). The JS endpoint pulls out some metadata (ip address, user agent, referer) from the request itself because it is assumed to come from the user directly. If you wanted to use the main notifier endpoint you would have to collect this information manually and include it in the payload metadata in order to take advantage of it.

If this endpoint could support consuming JSON payload, this could help partially, but this cannot help overcome the URL length limits that may apply. I need to post a large chunk of data and I'd like it to be structured to be able to use Bugsnag custom filters. What I dream of is to be able to apply filtering in the reporting service itself, not in the app.

There's a lot of good points and interesting discussion in here. It makes sense that we give more thought to supporting a more modern delivery mechanism in addition to the existing options, though the library's API for handling this would need to be refined somewhat. I posted some related ideas on @jacobmarshall's related issue here. The next steps are to explore and define this idea more concretely, hopefully to have an expressive yet performant (and backwards compatible) library.

@kattrali Thanks! By the way, if you're going to redefine the library's API, please consider unifying bugsnag-js and bugsnag-node APIs for the common functions.

@sompylasar That’s a great point too. Thanks!

Hey everybody on this thread, you can now try out the v4 beta version of this notifier which uses JSON as the serialized data format (at last 🎉)!
Intro/instructions are here: https://docs.google.com/document/d/1HBBLyVv9FHsNmbkRLx58WbtisMRVHwDoR3pnxac9JQQ/
If you try the beta, please let us know how you get on. Otherwise we anticipate doing a full major release at the start of December.

🚢 v4 is now published. Please upgrade!
See UPGRADING.md and full docs for more info 😄


Using 'windows' within 'handleMess' has strange behaviour some conditions

Problem Description
If:

we define a custom layout and give it a handleMess method
the handleMess implementation calls windows (W.greedyView someWorkspaceId)
handleMess then returns a non-Nothing value

then:

the workspace we swap to will wrongly inherit the selected layout of the workspace we are swapping from

Steps to Reproduce

Start XMonad with the supplied configuration file
Open two terminals on workspace 1, and two terminals on workspace 2 (M-<Return> M-<Return> M-2 M-<Return> M-<Return>)
Return to workspace 1 and swap layout to Full (M-1 M-<Space>)
Swap to workspace 2 (M-2). Note that workspace 2 is unchanged
Return to workspace 1 (M-1)
Swap to workspace two with the alternative keybinding (M-S-2). Note that workspace 2 has had its layout changed to Full as well!

Configuration File
Please include the smallest full configuration file that reproduces
the problem you are experiencing:
{-# LANGUAGE FlexibleInstances          #-}
{-# LANGUAGE MultiParamTypeClasses      #-}

import           Control.Monad.Writer               (Writer, execWriter, tell)
import           Data.Foldable                      (for_)
import           Data.Map                           (Map)
import qualified Data.Map                           as Map
import           XMonad
import qualified XMonad.Layout.BinarySpacePartition as LBSP
import           XMonad.Layout.LayoutModifier       (LayoutModifier (handleMess),
                                                     ModifiedLayout (..))
import qualified XMonad.StackSet                    as W

main :: IO ()
main = xmonad myConfig
  where
  myConfig = def
    { modMask = mod4Mask  -- super
    , terminal = "alacritty"
    , keys = myKeys
    , workspaces = show <$> [1..9]
    , layoutHook = myLayout (LBSP.emptyBSP ||| Full)
    }

myKeys :: XConfig Layout -> Map (KeyMask, KeySym) (X ())
myKeys conf@(XConfig { XMonad.modMask = mod }) =
  execWriter $ do
    -- launch terminal
    bind mod xK_Return $ spawn (XMonad.terminal conf)
    -- rotate layout
    bind mod xK_space $ sendMessage NextLayout
    -- move up/down window stack (n for next)
    bind mod                   xK_n   $ windows W.focusDown
    bind (mod .|. controlMask) xK_n $ windows W.focusUp
    -- workspaces
    for_ (zip (XMonad.workspaces conf) [xK_1 .. xK_9]) $ \(workspace, key) -> do
      bind mod                 key (sendMessage $ MoveTo_Working workspace)
      bind (mod .|. shiftMask) key (sendMessage $ MoveTo_Broken workspace)

  where
  bind :: KeyMask -> KeySym -> X () -> Writer (Map (KeyMask, KeySym) (X ())) ()
  bind mask key act = tell $ Map.singleton (mask, key) act

data MyMessage
  = MoveTo_Working WorkspaceId
  | MoveTo_Broken WorkspaceId

instance Message MyMessage

data MyState a = MyState
  deriving (Show, Read)

myLayout :: l a -> ModifiedLayout MyState l a
myLayout = ModifiedLayout MyState

instance LayoutModifier MyState a where
  handleMess _ msg =
    case fromMessage msg of

      Nothing -> pure Nothing

      Just (MoveTo_Working ws) -> do
        windows (W.greedyView ws)
        pure Nothing

      Just (MoveTo_Broken ws) -> do
        windows (W.greedyView ws)
        pure (Just MyState)

Checklist

[x] I've read CONTRIBUTING.md

I tested my configuration

[x] With xmonad version 0.17.0
[x] With xmonad-contrib version 0.17.0

Thanks for the nice report and example! It's a cool find. Didn't see the keys defined as a Writer Monad before, cool trick.
As for the weird behavior, in my opinion, this is a bit of an abuse of the X monad. This is my understanding of what's happening here: the handleMessage implementation for the LayoutClass instance of layout modifiers, found here, returns the layout that was active when the message was received, modified depending to the result of handleMessOrMaybeModifyIt (which just calls handleMess in the default implementation). As specified in LayoutClass, the layout that is returned by handleMessage is applied to the active workspace. In your case, since the original layout is taken from workspace 1 and by the end of handleMessage workspace 2 is active, then the modified layout from workspace 1 is used for workspace 2 (and the layout of workspace 1 won't change). I think one should be able to create the same behavior with normal layouts, using a layout modifier isn't necessary.
Changing this behavior is almost certainly a breaking change: I think this is a core change: remember the workspace that was active before the message is handled and apply the new layout to that workspace (disclaimer: I haven't looked at that part of the code yet). I'm not sure whether it's really an issue or just a quirky feature.
Anyways, this was just a fun and shallow 15 minutes dive into the code, let's see what others think.

I personally consider any use of windows in a handleMessage to be risky business, to be honest. If it breaks, you get to keep the pieces. 😄 (It's admittedly not as risky as doing so in a layout method proper; that absolutely would break things, since those are called from inside windows.)

Thank you both for the responses! It's sounding like this is an XY problem and I shouldn't be using layouts to do this in the first place :sweat_smile:! I was able to re-implement my feature using ExtensibleConfig and ExtensibleState instead of layouts. I'll leave the issue open since it sounds like it still might be valuable?

On Tue, Aug 09 2022 14:20, maynard wrote:

I was able to re-implement my feature using ExtensibleConfig and
ExtensibleState instead of layouts.

That's great to hear!

I'll leave the issue open since it sounds like it still might be
valuable?

Tbh, I think that the fundamental way we handle layouts is unlikely to
change at this point in time.  I think this can be closed, personally,
though other opinions are welcome.
--
Tony Zorman | https://tony-zorman.com/

Anyone can reopen if they think this needs further discussion. Thank you all!


HttpRequestData probably should not validate headers

I have a HTTP trigger which reads request headers and sometimes it throws an exception like this one:
 System.FormatException: The format of value 'AliApp(DingTalk/4.5.11) com.alibaba.android.rimet/10487439 Channel/227200 language/zh-CN' is invalid.
   at object System.Net.Http.Headers.HttpHeaderParser.ParseValue(string value, object storeValue, ref int index)
   at void System.Net.Http.Headers.HttpHeaders.ParseAndAddValue(HeaderDescriptor descriptor, HeaderStoreItemInfo info, string value)
   at new Microsoft.Azure.Functions.Worker.Http.HttpHeadersCollection(IEnumerable<KeyValuePair<string, string>> headers) in D:/a/1/s/src/DotNetWorker.Core/Http/HttpHeadersCollection.cs:line 41
   at HttpHeadersCollection Microsoft.Azure.Functions.Worker.GrpcHttpRequestData.get_Headers() in D:/a/1/s/src/DotNetWorker.Grpc/Http/GrpcHttpRequestData.cs:line 67

In this case a bot is sending a user agent which the header validation does not like and thus I am completely prevented from reading the headers because merely accessing the Headers property causes this exception to be thrown.
The problem seems to be that you call Add on HttpHeaders here:
https://github.com/Azure/azure-functions-dotnet-worker/blob/72b9d17a485eda1e6e3626a9472948be1152ab7d/src/DotNetWorker.Core/Http/HttpHeadersCollection.cs#L39-L45
Maybe you should be calling TryAddWithoutValidation instead when dealing with request headers?
I have tried making similar requests to a ASP.NET Core site and can read headers just fine even with the user agent above.

Sounds reasonable. Tracking that as part of the work for the current sprint.

I think this may apply to the "From" header, Google and Bing for instance like to send "googlebot(at)googlebot.com" and "bingbot(at)microsoft.com" in the the "From" header which as soon as you try to access the Headers collection fails.
I thought I might be able to strip out the "From" header with middleware but you can't override details of the BindingContext.BindingData as it's a IReadOnlyDictionary.

We also are seeing this issue when duplicate headers are sent through. With something like duplicate Content-Type headers getting set to "application/json, application/json" we would normally handle this and return a HttpResponseData object with a duplicate header error message but cannot generate a HttpResponseData object due to the parent HttpRequestData object being invalid.

+1. Calling from a browser such as Edge or Chrome on localhost causes this exception too.

@fabiocav Any update on this?

@DavidZidar validating some of this work, PR should be in soon, aiming  to have it done as part of the current sprint for a release in approximately 2 weeks

Updated the sprint to reflect that

@fabiocav Excellent, thanks for the update!

Argh! I've just hit this after updating a Function App to .NET 5 in dotnet-isolated mode, with a Docker Registry instance calling my function app:
 ---> System.FormatException: The format of value 'UpstreamClient(Docker-Client/20.10.6 \(linux\))' is invalid.
   at System.Net.Http.Headers.HttpHeaderParser.ParseValue(String value, Object storeValue, Int32& index)
   at System.Net.Http.Headers.HttpHeaders.ParseAndAddValue(HeaderDescriptor descriptor, HeaderStoreItemInfo info, String value)
   at Microsoft.Azure.Functions.Worker.Http.HttpHeadersCollection..ctor(IEnumerable`1 headers) in D:\a\1\s\src\DotNetWorker.Core\Http\HttpHeadersCollection.cs:line 41
   at Microsoft.Azure.Functions.Worker.GrpcHttpRequestData.get_Headers() in D:\a\1\s\src\DotNetWorker.Grpc\Http\GrpcHttpRequestData.cs:line 67

All I want to do it read the Authorization header, but TryGetValues or even just enumerating the header values, results in that exception above. I obviously cannot control the User-Agent header that the official Docker Registry image sends - is there some workaround that would allow me to simply read the header values without HttpHeadersCollection.cs throwing?! 😠

I

Argh! I've just hit this after updating a Function App to .NET 5 in dotnet-isolated mode, with a Docker Registry instance calling my function app:
 ---> System.FormatException: The format of value 'UpstreamClient(Docker-Client/20.10.6 \(linux\))' is invalid.
   at System.Net.Http.Headers.HttpHeaderParser.ParseValue(String value, Object storeValue, Int32& index)
   at System.Net.Http.Headers.HttpHeaders.ParseAndAddValue(HeaderDescriptor descriptor, HeaderStoreItemInfo info, String value)
   at Microsoft.Azure.Functions.Worker.Http.HttpHeadersCollection..ctor(IEnumerable`1 headers) in D:\a\1\s\src\DotNetWorker.Core\Http\HttpHeadersCollection.cs:line 41
   at Microsoft.Azure.Functions.Worker.GrpcHttpRequestData.get_Headers() in D:\a\1\s\src\DotNetWorker.Grpc\Http\GrpcHttpRequestData.cs:line 67

All I want to do it read the Authorization header, but TryGetValues or even just enumerating the header values, results in that exception above. I obviously cannot control the User-Agent header that the official Docker Registry image sends - is there some workaround that would allow me to simply read the header values without HttpHeadersCollection.cs throwing?! 😠

In the short term I got around the issue by using middleware and deserializing the headers from the binding context binding data and passing  what I need back via the function context items.

@chtay1 thank you, that worked! 👏

@fabiocav Any update on when a new version will be released with this bug fix?


Slides display and position suggestion

Hello. I rly appreciate the work you are doing for developing good-quality vanilla extensions.
I like lory features. But the only thing that makes me step back to using on my projects is related about how the slides are positioned and the default css styles.
It's well known that inline-block is suposed to not be used for grid-like design (Google it).
But this brings a little problem with relative font-sizes in responsive design. I mean when using font sizes according to parent font size: using the em unit. If I use em units to set the content of slides: the content dissappear. Of course... because set a font size according to 0 will gives 0.
Yeah... I know... I can set the font-size using px manually, but in that way I must set the correct font-size for each item inside slides in each media query... using em units will become pointless, and for a lot of people em unit are very very useful. Of course... this will make the css bigger also...
In other hand... setting font-size:0 and line-height:0 seems like some kind of content hiding that may cause SEO penalties. I´m not shure about this... but I would't risk myself to let some bots think that I wanna hide valuable content. And the way bots analize sites changes constantly.
Anyway... Regardless of the points mentioned above... it simply feels like a poor and ugly hack to makes it work.
I suggest using display:block and floating instead. Or maybe, the new display:flexbox and display:grid and makes a fallback.
I hope you have understood me. Sorry for the criticism and also for my bad english. Keep the good work.

Hey @GiuTaeKim,
I really do not give you any specifications on how to structure your css to get it up and running. Yeah I could imagine that lory has more examples with different layout variants, so feel free to either contribute.
If u can use other css models that work better for you, just use it. My CSS is actually just for demo purposes.
In my daily business I rarely use floats (just for text floating) because I destroy the box model and the content flow if I use float for layout purposes.
As far as I know, If I use floats for layout then the element is always repainted when rearranging elements instead of a reflow which is from a browsers perspective way cheaper.
But actually feel free to use what ever works best for u.
Thanks for your feedback, I appreciate it a lot.
Max


Install error prevents from using device

When I install the Windows alpha downloaded on Win 10 (10.0.14393) today I get the following error message during install (after adding my work PC as a device):
.
Seems error handling when accessing local appdata folder could be more graceful.
Then when I trying to login / connect to the same device I get the "Type in text code" dialog. As this is my first device I then choose "go back" and get the error message "kex canceled by caller".
(This may not be an issue if/when installing as administrator). I downloaded using Chrome and started install from the reader..

Thanks for the report.
Cc: @zanderz
On Thu, May 4, 2017 at 11:11 AM finneivind<EMAIL_ADDRESS>wrote:

When I install the Windows alpha downloaded on Win 10 (10.0.14393) today I
get the following error message during install (after adding my work PC as
a device):
[image: image]
https://cloud.githubusercontent.com/assets/28396965/25709790/937e59d6-30ea-11e7-97ce-e63141e4c8a8.png
.
Seems error handling when accessing local appdata folder could be more
graceful.
Then when I trying to login / connect to the same device I get the "Type
in text code" dialog. As this is my first device I then choose "go back"
and get the error message "kex canceled by caller".
(This may not be an issue if/when installing as administrator). I
downloaded using Chrome and started install from the reader..
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/6871, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_zcRjIC057XKmsioSOZIhIXAG2lHks5r2eqygaJpZM4NQ0CO
.

Are you able to do keybase log send at the Keybase Shell?
Are you running any antivirus software?

Hi Steve,
Thanks!
Just did a keybase log send.
And yes, I am running on a managed corporate PC, we have for reasons that do not make sense to me installed McAfee.
Eivind
Fra: Steve Sanders<EMAIL_ADDRESS>Sendt: torsdag 4. mai 2017 18.59
Til: keybase/client<EMAIL_ADDRESS>Kopi: Throndsen, Eivind<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [keybase/client] Install error prevents from using device (#6871)
Are you able to do keybase log send at the Keybase Shell?
Are you running any antivirus software?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkeybase%2Fclient%2Fissues%2F6871%23issuecomment-299246199&data=01|01|eivind.throndsen%40finn.no|c7b5bbcaec594f2541b308d4930ecd90|8e414aeed6e14d1398c8d3876cd2b059|0&sdata=%2Bj97rB7uDJyudfZJVNZ2EGpIAPuF7csOz%2F2NZbzS3gA%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAbFNpXqOsz2vG48yxBLfpNElOyIn9Ijqks5r2gO5gaJpZM4NQ0CO&data=01|01|eivind.throndsen%40finn.no|c7b5bbcaec594f2541b308d4930ecd90|8e414aeed6e14d1398c8d3876cd2b059|0&sdata=hBnEwlq0T2RHskmTKTQ8Rg0vihKhCLXSQzQFauzLZFk%3D&reserved=0.

This is almost certainly due to the AV opening files while we're trying to access them, in order to make sure no malware is writing to them. We have solved similar cases in the past by adding some retries; we'll add one here too.

https://keybase.atlassian.net/browse/CORE-5100


Expose CSS color and sizing choices as Style Properties

To improve upgrading compatibility, converting CSS to use Style Properties for a bunch of the colors would be ideal.

Implemented in v1.2.0


console is not defined

Using worker-pouch I'm getting random pouch calls failing with "console is not defined".

This happens on Chrome v30 which is what the webview for android 4.4.2 is locked to. I can't reproduce on Firefox or Chrome latest. I think this is due to the console not being defined in web workers in this version of Chrome.
I assume this is due to something in PouchDB logging but it's very difficult to test and debug, so I can't tell for sure.
Maybe the fix is some sort of console polyfill (eg: https://github.com/padolsey/operative/blob/master/src/contexts/BrowserWorker.js#L189) or maybe just a console stub so log messages are ignored.

released in 1.0.3, fixed (hopefully) in #17

I can still reproduce this with 1.0.3 :(

Seems it's an issue in core Pouch, then. :/

Could be. It could be in core or a plugin, right? That's why I leaned towards using the no-op polyfill.

It could be in a lot of places. I admit such a bug may be lurking in PouchDB's code base, because we can't test Android <4.4 in SauceLabs and also don't test <4.4 in a worker.
The no-op polyfill sounds like a good solution for your codebase if you're not sure where the console is coming from though.

The no-op polyfill sounds like a good solution...

Does that mean you'll consider reopening https://github.com/nolanlawson/worker-pouch/pull/18 ?

I'd prefer not to have a global polyfill in a library. It's the same policy we normally take with Promises, etc. IMO it's best to handle console on a case-by-case basis rather than pollute the global namespace, since it's less surprising for users.
OTOH PouchDB claims to run in Android 4+, so it's reasonable to put console guards in there. I think we just need to comb the codebase and wrap all the console usages.

I did mean it might be a good solution for your own project though.

I don't think I can add it in my project though because I don't have access to the worker. It's only the worker "global" I'm polluting, not the actual "global". I'm happy to comb through PouchDB and fix any I find. I worry that a later version of PouchDB or a plugin might add unguarded console logs, as you say it can't be CI tested.
How do you feel about passing a flag to opt in to legacy support?
The only other way I can see to do it is to fork worker-pouch and that doesn't help anyone else.

worker-pouch now has a "custom mode" that allows you to use its code inside your own worker, so you could use that to inject a global console.

I got the "custom mode" solution working today. Thanks @nolanlawson !


Return arrays from transformers for use with mergeMap

What does this change?
All transformers now always return an array, so that we can us Rx.js mergeMap (replaces map) consistently (ht @kenoir).
How to test
cd pipeline && yarn test
How can we measure success?
I think this is the last piece required for the addressable transformers, so 'All' search will soon be possible.
Have we considered potential risks?
A future reindex will include this.

I've merged the season and project transformers into main, so will need to amend them to return arrays. Do you mind doing that in this PR?


a tera variable or filter for previous_version

For context:
I'm using in my changelog usually links that point to GitHubs version compare pages like this:
## [Unreleased]
[Unreleased]: https://github.com/steganogram/stegano-rs/compare/v0.5.0...HEAD

## [0.4.10] - 2021-11-15
[0.4.10]: https://github.com/steganogram/stegano-rs/compare/v0.4.10...v0.4.9

so there are links that points to the GitHub code compare, for the actual version (v0.4.10) with the "previous" (v0.4.9) semver version that was released, and the last released version (v0.5.0) with the HEAD
In order to make this same changelog available by cliff I've tried the cliff.toml as below:
# template for the changelog body
# https://tera.netlify.app/docs/#introduction
body = """
{% if version %}\
    ## [{{ version | trim_start_matches(pat="v") }}] {{ timestamp | date(format="%Y-%m-%d") }}
    [{{ version | trim_start_matches(pat="v") }}]: https://github.com/sassman/putzen-rs/compare/{{ version }}...{{ previous_version }}
{% else %}\
    ## [unreleased]
    [Unreleased]: https://github.com/sassman/putzen-rs/compare/{{ latest_version }}...HEAD
{% endif %}\

I guess this variables could be very tricky to provide, but maybe when assuming semver version tags it might be possible to have them all parsed and prepared for the tera rendering.
Alternatively it might be a filter available that goes to the previous version of a given version number like this:
    [{{ version | trim_start_matches(pat="v") }}]: https://github.com/sassman/putzen-rs/compare/{{ version }}...{{ version | previous_release }}

Hey Sven!
Have you tried using the previous field which is mentioned in the template context?
So you can use it like this to get the same result:
{% if version %}\
    ## [{{ version | trim_start_matches(pat="v") }}] {{ timestamp | date(format="%Y-%m-%d") }}
    [{{ version | trim_start_matches(pat="v") }}]: https://github.com/sassman/putzen-rs/compare/{{ version }}...{{ previous.version }}
{% else %}\
    ## [unreleased]
    [Unreleased]: https://github.com/sassman/putzen-rs/compare/{{ previous.version }}...HEAD
{% endif %}\

But be aware, this will only work if you run git-cliff with --unreleased or --latest flags. Otherwise you might get template errors due to previous.version not being present. In that case you can add another conditional check to avoid this error.
Hope this helps 🙂


Simplify report closure changes for QuickBooks desktop

Codecov Report

Merging #48 (fb7fb78) into master (470dc7d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   99.55%   99.55%
=======================================
  Files          37       37
  Lines        1801     1802    +1
=======================================
+ Hits         1793     1794    +1
  Misses          8        8

Impacted Files
Coverage Δ

apps/fyle/tasks.py
100.00% <ø> (ø)

apps/workspaces/models.py
100.00% <100.00%> (ø)


Benefits of SHRM Certification

The SHRM-CP and SHRM-SCP certifications provide a reliable indicator to the global business community that the credential-holder is a recognized expert and leader in the HR field with the necessary capabilities in both aspects of HR practice—competencies and knowledge—that are required for effective job performance.
This can lead to increased job opportunities, higher salaries, and greater professional recognition.

The Society for Human Resource Management (SHRM) offers two professional certifications: the SHRM Certified Professional (SHRM-CP) and the SHRM Senior Certified Professional (SHRM-SCP). These certifications are designed to demonstrate a level of expertise and knowledge in the HR field and provide a range of benefits to those who hold them. Here are some of the benefits of SHRM certification:

Increased credibility: SHRM certification is a widely recognized and respected credential in the HR field. Holding this certification can increase your credibility and demonstrate your commitment to the profession. It can also help you stand out from other job candidates and make you a more attractive candidate for HR positions.
Enhanced knowledge and skills: The SHRM certification exam is designed to test your knowledge and skills across a wide range of HR topics. Preparing for the exam can enhance your knowledge and skills, and passing the exam can validate your expertise in these areas.
Professional development: SHRM certification requires ongoing professional development, which means that you must stay up-to-date with the latest trends and best practices in the HR field. This can help you continue to grow and develop in your career.
Career advancement: Holding an SHRM certification can lead to increased job opportunities and higher salaries. According to SHRM, those who hold an SHRM-CP earn an average of 15% more than their non-certified peers, while those who hold an SHRM-SCP earn an average of 31% more.
Global recognition: SHRM certification is recognized globally, which means that it can open up job opportunities and professional recognition around the world. This can be especially valuable for those who work for multinational companies or who are interested in working abroad.

Overall, obtaining an SHRM certification can have a range of benefits for those in the HR field, from increased credibility and professional development to career advancement and global recognition.


SO_BINDTODEVICE failing with virtual interface

I tried to run NSD 4.3.1 on a machine (Debian 10.4), which uses bonding for LACP. Starting NSD fails with this error message:
setsockopt(..., SO_BINDTODEVICE, ..., ...) failed: No such device

Running it on a pretty much identical setup with plain interfaces works.
Best guess so far is, that SO_BINDTODEVICE introduced with NSD 4.3.0 seems to not play well with virtual devices.
Is it possible to detect such virtual interfaces automatically and subsequently not apply this socket option to avoid startup failures?
Furthermore, the option to disable this functionality for config files (bindtodevice: <yes or no>) seems broken. It is considered invalid by nsd-checkconf. Setting it prevents NSD from being started as well.

Hi @and0x000! bindtodevice is an option attribute and should be specified per ip-address, so an = (equal sign) rather than : (colon). Judging by the message though it must indeed have something to do with that option, but bindtodevice should be disabled by default, so I'm really curious what's going on there. Do you have reuseport enabled? Maybe you can paste an anonymized version of the config (server: block is enough)?

Looking through the code, there may be an issue when combined with reuseport if bindtodevice is enabled (I'll have a better look tomorrow). Still, if it's not enabled, it shouldn't try to enable it, so still interested in that config :slightly_smiling_face:

hi @k0ekk0ek
this is my configuration:
server:
    ip-address: <IP_ADDRESS>
    ip-address: ::1
    ip-transparent: yes
    ip-freebind: yes
    reuseport: yes
    debug-mode: no
    database: ""
    identity: ""
    nsid: ""
    server-count: 8
    tcp-count: 250
    tcp-query-count: 0
    tcp-timeout: 5
    ipv4-edns-size: 4096
    ipv6-edns-size: 4096
    port: 53
    username: nsd
    xfrd-reload-timeout: 1
    verbosity: 2
    hide-version: yes
    rrl-size: 1000000
    rrl-ratelimit: 200
    rrl-slip: 2
    rrl-ipv4-prefix-length: 24
    rrl-ipv6-prefix-length: 64
    rrl-whitelist-ratelimit: 4000

ip-freebind and ip-transparent are both required, as it is a HA setup with a hot standby.
I tried specifying the bindtodevice per ip-address but to no avail (iirc). Will test it again tomorrow to be on the safe site though.
Regarding where to specify it, the documentation seems a bit contradictory to me.
From the man pate I thought it would have to be specified as a regular server option. Only from the sample config I got the hint about the attribute.

Follow-up:
it does not work either with
    ip-address: <IP_ADDRESS> bindtodevice=no
    ip-address: ::1 bindtodevice=no

I think #100 will fix the problem for you. You're probably using a package, but can you try to compile with that fix?

@k0ekk0ek I got a version with the fix compiled by @asciiprod (kudos). The fix works for my case.


⚠ HDBits has degraded performance

In 4f59cf5, HDBits ($HDB) experienced degraded performance:

HTTP code: 200
Response time: 9154 ms

Resolved: HDBits performance has improved in 1895ad1 after 18 minutes.


CS:GO crashes when injecting an AVX-512 or AVX2 compiled build.

My CPU is a Ryzen 5 2600 and ,according to several websites, supports AVX2 and AVX-512. I know this isn't an issue with the source itself, but I am still curious as to why that happens. As for now, I'm going to fall back to compiling with SSE2.

AVX-512 is not supported by Ryzen 5 2600, that's why your game crashes with your own Osiris build.

AVX-512 is not supported by Ryzen 5 2600, that's why your game crashes with your own Osiris build.


User' set evil-collection-key-blacklist isn't respected

What did you expect to happen?
Set evil-collection-key-blacklist in init.el (to be sure, because Doom initialize evil before loading config.el).
It is respected.
What actually happened?
Keys in set evil-collection-key-blacklist is bound by evil-collection anyway.
Describe your attempts to resolve the issue
Advise evil-collection-init and set the variable before as a workaround.
Steps to reproduce

In init.el: (setq evil-collection-key-blacklist '("n"))
magit-status
Press n, expected magit-section-forward but got evil-ex-search-next instead.

System Information
https://pastebin.com/Sdp4P1h9

Did you wrap your custom (setq evil-collection-key-blacklist ...) in (after! evil-collection ...)?

Yes, I have tried
(after! evil-collection
  (setq evil-collection-key-blacklist (append (bound-and-true-p evil-collection-key-blacklist)
                                              '("n" "p"))))

Checking evil-collection-key-blacklist later gives ("SPC" "," "M-SPC" "gd" "gf" "K" "gr" "gR" "[" "]" "gz" "<escape>").


const getter

Most, if not all getters (generic function parameters are currently unstable) can be const functions
https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn

Great idea. :)

Just checked in, this is still unstable. :(

const fn get_value(&self) -> &String {
    &self.value
}

Correct, but the generic case is not. :(

Any updates to this? It doesn't seem reasonable to put this on hold just because of a special case.
What about adding a feature gate or an attribute to enable const getters?

I was working on a rewrite of this lib to better support features like this, but it's not done yet. You're welcome to contribute a patch to add this feature, or as always, write the getters and setters yourself (as is probably best!).


Fix a bug: docker-compose >= 1.28: "host" network_mode is incompatible with port_bindings

Description
Fixed a bug: "host" network_mode is incompatible with port_bindings
This minor bug seems to occur when docker-compose >= 1.28.
I tested on ArchLinux with docker-compose = 1.29.2.
note: https://forums.docker.com/t/docker-errors-invalidargument-host-network-mode-is-incompatible-with-port-bindings/103492/3
Why is this needed
Fix a bug: docker-compose >= 1.28: "host" network_mode is incompatible with port_bindings

Fixes: #

Hey @kerryeon this looks fine and I'm ready to merge, but we need you to verify that you've read & understand the DCO.


WIP: Fix textarea in/valid icon getting left behind when a user resizes the field

cases:
normal-top label:
nothing: resize height/width, container width fit-content
quiet: no resize
custom width: only resize height
custom height: only resize width
custom both: no resize
normal-side label:
nothing: resize height/width, container fit-content
quiet: no resize
custom width: only resize height
custom height: only resize width
custom both: no resize
in form-top label:
nothing: resize height, follow form width
quiet: no resize
in form-side label:
nothing: resize height, follow form width
quiet: no resize
Closes https://jira.corp.adobe.com/browse/RSP-1792
✅ Pull Request Checklist:

[ ] Included link to corresponding Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

Another case noted, label end-aligned needs to line up with textarea's edge, at least to start

should be fine to use https://caniuse.com/#feat=mutationobserver

Hooray, this is no longer an issue https://github.com/adobe/react-spectrum/pull/1543


APEXMALHAR-1977: Add matrics to jdbc input operator

@bhupesh can you please review?

Change looks okay to me. Will merge this tomorrow if there are no other comments.

Remember to correct the spelling error (i.e. matrics) of the JIRA and the commit message before merging.


Windows installer unable to use terraform /dev/null issue

Issue Report Template
Tectonic Version
1.6.4
Environment
What hardware/cloud provider/hypervisor is being used with Tectonic?
AWS, installing with terraform on a windows OS
Expected Behavior
Same terraform install process that is actual behavior on a linux machine should also work with a windows install
Actual Behavior
When running a known working version of the terraform process, the following is seen:
tectonic.module.bootkube.template_dir.bootkube: file: open /dev/null: The system cannot find the path specified. in:
${base64encode(file(data.null_data_source.etcd.outputs.key_path))}
Reproduction Steps

Download new Tectonic 1.6.4
Extract files
In Tectonic dir, attempt to run terraform as explained in install process
Recieve /dev/null error at same point as expressed above.

Other Information
Have also tried with different shells, such as bash, bash developer (windows port), zsh. All encounter the same final error after getting to the 'terraform plan'
Feature Request
Environment
Running Terraform v0.9.11 for windows x64
Desired Feature
Full support for a windows environment install not just through a linux base. Primary need is for a windows/linux install that would work on both environments without issue.
Other Information

related to; https://github.com/coreos/tectonic-installer/issues/1051


SEPG Automated Release - v4.0.0

SEPG Details
Release Build Link: https://sou-jenkins2.swinfra.net/job/Auto-Release/816/
Build Token: github.com/CAFapi/util-flyway-installer/main/c91af9bd35378f6f5b013785863972876b29b1a1
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Maven

com.github.cafapi.util.flywayinstaller:util-flywayinstaller-cli:4.0.0-241(pom,sources.jar,javadoc.jar.asc,javadoc.jar,pom.asc,sources.jar.asc,jar,jar.asc)
com.github.cafapi.util.flywayinstaller:util-flywayinstaller-aggregator:4.0.0-241(pom.asc,pom)
com.github.cafapi.util.flywayinstaller:util-flywayinstaller:4.0.0-241(jar,sources.jar,sources.jar.asc,javadoc.jar,jar.asc,pom,pom.asc,javadoc.jar.asc)

Dependent Downstream Repositories
The following jobs contain have a dependency on the repository being release:

JobService/job-service:develop

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


fix: added digest check on resolve ref

This PR adds check on user input digest and resolved digest.

Codecov Report

Merging #689 (b3099f0) into main (d35d85c) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   63.94%   63.81%   -0.14%
==========================================
  Files          40       40
  Lines        2219     2222       +3
==========================================
- Hits         1419     1418       -1
- Misses        679      682       +3
- Partials      121      122       +1

Impacted Files
Coverage Δ

cmd/notation/manifest.go
56.66% <0.00%> (-3.11%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


kilogram unit missing

https://github.com/anitaapplegarth/oxrse_unit_conv/blob/40b94152d6d9a8784055cc3c04843b7a2d4dbf91/src/oxrse_unit_conv/units.py#L21
The kilogram unit comment is there but the calculation needs adding

@isabellauhw another one for you to do, I've been told to assign it to you!


Unable to create EC2 Instances with CoreCLR/dotnetcore

(this is a cross-post from Stack Overflow, I wasn't sure I could open issues here: https://stackoverflow.com/questions/37678520/creating-instances-using-awssdk-core-for-net-core-apps)
I'm trying to programmatically create AWS EC2 instances using AWSSDK Core for .NET Core. I'm mostly following this guide:https://docs.aws.amazon.com/AWSSdkDocsNET/V3/DeveloperGuide/run-instance.html
However I get a lot of AmazonEC2Exceptions and I can't seem to catch them.
First, I've created a credentials file under C:\users\myUserName\.aws\credentials
[myKeyName]
aws_access_key_id = [something]
aws_secret_access_key = [something longer]

I also created an AmazonCloudProvider class to handle all the basic AWS requests. My constructor looks like this:
AmazonEC2Client ec2Client;
string amiId = "ami-d3c022bc";
string keyPairName = "myKeyName";
public List<Instance> instances;
public List<string> instanceIds;
public AmazonCloudProvider()
{
    try
    {
        var credentials = new StoredProfileAWSCredentials(myKeyName, "C:/users/myUserName/.aws/credentials");
        ec2Client = new AmazonEC2Client(credentials, RegionEndpoint.EUCentral1);
    }
    catch(AmazonEC2Exception ex)
    {
        throw new Exception("Error!", ex.InnerException);
    }
}

I then have a method to instantiate an instance:
public async void CreateInstance(int minCount, int maxCount)
{
    var launchRequest = new RunInstancesRequest()
    {
        ImageId = amiId,
        InstanceType = InstanceType.T1Micro,
        MinCount = minCount,
        MaxCount = maxCount,
        KeyName = keyPairName
    };
    RunInstancesResponse launchResponse = null;
    try
    {
        launchResponse = await ec2Client.RunInstancesAsync(launchRequest);
    }
    catch(AmazonEC2Exception ex)
    {
        throw new Exception("Error launching EC2 instance: ", ex.InnerException);
    }

    instances = launchResponse.Reservation.Instances;
    foreach(Instance instance in instances)
    {
        instanceIds.Add(instance.InstanceId);
    }

However as soon as the ec2Client.RunInstancesAsync(launchRequest) method is called, the code just hangs and closes. I get no error caught in the console or debug window. All I get is a bunch of errors like this:
Exception thrown: 'Amazon.EC2.AmazonEC2Exception' in AWSSDK.Core.dll
Exception thrown: 'Amazon.EC2.AmazonEC2Exception' in mscorlib.ni.dll
Exception thrown: 'Amazon.EC2.AmazonEC2Exception' in mscorlib.ni.dll
The program '[10564] dotnet.exe' has exited with code -1073741819 (0xc0000005) 'Access violation'.

I'm not exactly looking for a turn key solution to my problem, what would really help me is to find a way to debug this code and catch the errors to try and solve them. I'm using Visual Studio 2015 Community Edition, .NET Core RC2 and the AWSSDK.Core and AWSSDK.EC2 version <IP_ADDRESS>-beta

Turns out it was an error with the credentials (and therefore me). Sorry for the inconvenience (also, sorry for all those VMs I spawned as I was debugging ;) )


Fix bug in prevWindow/nextWindow

This fixes the issue where prevWindow(0) called on the first element in a ChainLink would return the first element, and where prevWindow(i>0)/nextWindow(i>0) would return the first/last element when called on the first/last element respectively.

thanks!


Unexpected label during prediction

Hi! So I'm running the grounded_sam2_hf_model_demo.py on one of my images with labels woman. swab. balcony. room. bucket. sky.  However, the results that the processor looks like this: 'labels': ['bucket', 'room', 'woman', 'womanab']. I am not too sure where the womanab label comes from?
Here is the image that I used

Here is the image post processing

Does anyone have any insights on why this might be happening? Thanks!

Hello @yuerout , we have similar discussions here: https://github.com/IDEA-Research/Grounded-SAM-2/issues/50. You can refer to this issue for more details.

Hi @rentainhe , thanks for the reply! I looked at the file, but it seems like the input to that is a text prompt ("There is a cat and a dog in the image ."). My input is already parsed into individual labels. I was wondering if you know how I can adapt the code there for my use? Thank you!

Hi @yuerout
About how the womanab come: Grounding DINO will first compute the box region similarity with each text, if the max score is higher than the pre-defined box_threshold, we will keep the box to the final output list, and the box's label will be all the combination of the texts which has the similarity scores with this box higher than the text_threshold. So in this case, both woman and ab has high score with this box, so the label will be womanab. This may introduce some confusing results to the users.

Hi @rentainhe, thanks for the response! I'm still a bit confused -- Why would a score be computed for ab in the first place? This is not in the list of labels. It looks like a fusion of woman and swab.


Infobox not working on iOS safari

added custom infobox to my app with your 0.8.7 gem.  all is working well in chrome, ff, and safari, but not on ipad/iphone.   the markers seem not to be clickable.  any ideas.
this gem is awesome.  thanks for your hardwork!
miguel

Hi ,
I am using Google maps in my rails application, And i am printing the map by using window.print. In Firefox the map is printing fine. But in mac safari, safari and Google chrome the map printing badly. Shade coming over the map in the printed page. My safari version is 3.1.2.
How can i slove it. Is there is any problem with my code.
Please help.
Thanks,
Anu Krishna.


libpqxx: 6.2.5 -> 6.3.0

Motivation for this change
https://github.com/jtv/libpqxx/releases/tag/6.3.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build hydra

@edolstra would you like this to wait for your review? Happy to do so, no hurry for the upgrade AFAIK.


Uncaught Error: ENOENT: no such file or directory, lstat 'G:/'

Steps to reproduce

Open Atom, either directly or from GitHub Desktop through "Open in Atom".
See red error popup as soon as Atom loads!

Atom: 1.29.0 x64
Electron: 2.0.5
OS: Microsoft Windows 10 Enterprise
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat 'G:'
At fs.js:1700

Error: ENOENT: no such file or directory, lstat 'G:\'
    at Proxy.realpathSync (fs.js:1700:15)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:320:29)
    at atom.project.getPaths.map (~/AppData/Local/atom/app-1.29.0/resources/app/node_modules/fuzzy-finder/lib/path-loader.js:16:73)
    at Array.map (<anonymous>)
    at Object.startTask (~/AppData/Local/atom/app-1.29.0/resources/app/node_modules/fuzzy-finder/lib/path-loader.js:16:56)
    at Object.startLoadPathsTask (~/AppData/Local/atom/app-1.29.0/resources/app/node_modules/fuzzy-finder/lib/main.js:129:43)
    at get_process.nextTick (~/AppData/Local/atom/app-1.29.0/resources/app/node_modules/fuzzy-finder/lib/main.js:31:45)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Thanks for contributing!
We noticed that this looks like a duplicate of #10774 so you can subscribe there for updates if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

Are you sure? I didn't move the app while it was open. The error gets thrown as soon as I open Atom, and Atom hasn't been moved.

Ahhh yeah :+1:  Based on the stack trace, I think it might be https://github.com/atom/fuzzy-finder/issues/255.

Sorry about that @EmiLithium!


After a while, processing gets very slow.

I have both 2d and 3d cartographer working great for localization in small and medium size environments.  However, when I try to explore a large environment, the processing eventually (after 30 minutes or so) slows down and grinds to a halt.
I am wondering if I need to close submaps or something like that as I go along.  If so, how do I do that and also, how do I save the overall localization?

Thanks, I'll try that.  What I meant was, if I get rid of old submaps, will I still have global localization?

(I assume you have a "frozen" background map in which you want to localize)

I am trying to create a 3d map while exploring a very large area (2 x 2 km) and remain localized with respect to the original origin throughout the process.  In previous projects, I have done that over smaller areas (.1 km x .1 km) and then saved the map at the end and also created a 2d ROS map from that.  In this case, I don't need the ROS map (although it would be nice to have), but I do need to stay localized  while exploring.

Ah, I see. So you do live mapping, I thought you meant pure localization.
Changing some parameters can already have a positive effect on runtime efficiency. For example disabling global constraint search by setting POSE_GRAPH.global_constraint_search_after_n_seconds to very high value, lowering the POSE_GRAPH.constraint_builder.sampling_ratio, making the min_scores higher to let the branch-and-bound search exit earlier, ...

Thanks for the suggestions.  I was not able to find guidelines for values of those parameters, so I just tried plugging in POSE_GRAPH.global_constraint_search_after_n_seconds = 100 and POSE_GRAPH.constraint_builder.sampling_ratio = 0.05 and the efficiency did improve.  It's hard to figure out the impact of those changes though.

Sounds like an example for these parameters would be a useful addition to the tuning guide.

Actually, it's already there: https://google-cartographer-ros.readthedocs.io/en/latest/tuning.html#low-latency

Yes, that is a very helpful list.  Is there someplace where the default values for all parameters are listed?  I found some values by using grep, but there must be a better way.

I actually have a pull request in cartographer for an utility that tries to help with exactly this :smile:
https://github.com/googlecartographer/cartographer/pull/1508
It's not merged yet, but maybe you can upvote it

upvoted!


finatra-httpclient: Pass expected POST body to InMemoryHttpService map

Problem
Explain the context and why you're making that change.  What is the
problem you're trying to solve? In some cases there is not a problem
and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes
this section is unnecessary because it is self-explanatory based on
the solution.
Problem
The InMemoryHttpService allows tests to specify an expected body when mocking a
POST request.  This body is not being passed through to the map of responses, so
tests which should fail are passing.  Additionally, the test for this
functionality is faulty, because a generic "Exception" is expected to be thrown
when a non-expected body is received.  The assertFailedFuture test helper method
does not work for generic Exceptions, because the ScalaTest fail() method throws
an exception which is also caught.
Solution
Pass the "withBody" parameter from "mockPost" through to the responseMap.
Introduce PostRequestWithIncorrectBodyException so that the  "post mocked with
different body" test reports correctly.

Travis has the same problem as me getting the SNAPSHOT dependencies, but running with v2.1.5 it does work (see #317)

Merged in 994c9dc2be81bfd60d19e60792538c91e20a98c7


Bump all JS dev dependencies to latest

Builds on #1519 (so merge that first) - including those commits to avoid conflicts in the lock file.

eslint has significant breaking changes, so I'll do this seperately

Closing this for now - will follow up with more limited set of dev dependencies


CommentThread range not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.75.0
OS Version: Darwin x64 21.6.0

I have a extension that tries to get the code for a comment thread using the range property of the comment thread. It was working fine before however, with the most recent update 1.75.0 it's not working anymore and returning a empty string instead.
Steps to Reproduce:

Execute below function when creating a comment thread using the created comment thread as input.

function getCommentThreadCode(thread: vscode.CommentThread) {
		const editor = vscode.window.activeTextEditor;
		if (!editor) {
			return; // No open text editor
		}
		const document = editor.document;
		console.log("REACHED HERE");
		console.log(thread.range);
		// Get selected code for the comment thread
		return document.getText(thread.range);
	}

You will see that you get empty string.

Are there any updates to this issue?

I suggest you fork https://github.com/microsoft/vscode-extension-samples, create a branch, then edit the comment-sample to demonstrate your issue. Doing this should make it easier to investigate.

I tried console logging the thread.range and upon closer inspection, the range is correct. However, for some reason document.getText(thread.range) returns an empty string. So I guess the problem is with document.getText()?

Your code fragment assumes activeTextEditor uses the document the thread relates to. I think instead you should use thread.uri to access the document.

so maybe something like vscode.workspace.openTextDocument(thread.uri)? Are there better ways to do it?

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


4108a8cc-4c10-4d94-ae4d-9ca92c304d7b

this is for automated testing

97f900c1-6dc6-44da-ae67-46421c0a7978


Ensuring HexAddress is Wrapped in String format and as HexAddress

This is pr fixes for #230
@nguyer @awrichar @peterbroadhurst
I have been able to implement the fix for issue #230 ensure the HexAddress are  wrapped properly please, I would like reviews

Hey @Philip-21. Sorry I probably should have steered you in the direction of the existing code in the firefly-signer library that we already have that does these sorts of things. Two places you might want to look are:

https://github.com/hyperledger/firefly-signer/blob/main/pkg/ethtypes/address.go
https://github.com/hyperledger/firefly-signer/blob/main/pkg/ethtypes/hexbytes.go

I'd rather that we use the existing library to handle parsing, validation, or conversion of these types, rather than creating another implementation in an additional repo. If there's functionality missing in firefly-signer that we need here, it would be great to add it to the shared library.

@nguyer I have been able to use the firefly-signer library to handle validation and parsing.
what  do you think of the changes I made ?

@Philip-21 Looks like there are compilation errors now:
Error: ../internal/tokens/erc1155/erc1155_provider.go:93:41: cannot convert loc["address"] (map index expression of type string) to type types.HexAddress
# github.com/hyperledger/firefly-cli/internal/tokens/erc20erc721
Error: ../internal/tokens/erc20erc721/erc20_erc721_provider.go:92:40: cannot convert loc["address"] (map index expression of type string) to type types.HexAddress
Error: ../internal/tokens/erc20erc721/erc20_erc721_provider.go:103:58: invalid operation: factoryAddress != "" (mismatched types types.HexAddress and untyped string)
make: *** [Makefile:25: build] Error 2
Error: Process completed with exit code 2.

@nguyer please  i would like you to review my code , i am still trying to figure out why the checks are failing i was able to tackle the compilation error , but i still have failing e2e tests

@nguyer, these are error messages i got from the e2e tests
DEBUG evmconnect: FF21040: Invalid listener options: FF23036: Invalid event filter: {"address":"783688521890864681654499112172336319967459785509","event":{"anonymous":false,"inputs":[{"indexed":true,"internalType":"address","name":"operator","type":"address"},{"indexed":true,"internalType":"uint256","name":"type_id","type":"uint256"},{"indexed":false,"internalType":"bytes","name":"data","type":"bytes"}],"name":"TokenPoolCreation","type":"event"}}:
It seems the error is related to an invalid event filter in Ethereum. Specifically, it seems to be related to the event filter for "TokenPoolCreation" on a contract with address "783688521890864681654499112172336319967459785509".
Maybe, the address isn't defined well.

783688521890864681654499112172336319967459785509 looks like something that was an address which may have been converted to a number. Based on what I see in the E2E test log:
initializing token providers
initializing tokens on member 0
Error: http://localhost:5110/api/v1/init [500] {"statusCode":500,"message":"Internal server error"}

I am guessing that the token connector config or environment variables aren't getting written correctly with these changes

Contributor

Yes these values don't have the proper Hexaddress format which are meant to be in 20 byte [] type, based on the firefly-signer library the address must be of 20 byte[] type.
the unit tests i wrote, gives different examples of how i defined the hexvalues in 20 byte []type


Feat/forms button improvements

Disable forms button until all the necessary parameters are provided.
Description
This pull request introduces a modification to the forms functionality, specifically targeting the submit button. The primary change ensures that the submit button remains disabled until all the necessary parameters are provided by the user. This enhancement is essential for improving the user experience and preventing incomplete form submissions.
Changes Made

Added logic to disable the submit button by default.
Implemented parameter validation to enable the submit button only when all required parameters are provided.

Screenshots
Actual Behaviour:

New Behaviour:

NOTICE
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish<EMAIL_ADDRESS>on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md
Sample JSON:
movieDisableFormButton.json
Signed off: Monish<EMAIL_ADDRESS>

Can you please check the code duplication and if you can add testing for this new behaviour in Cypress? Thank you so much for contributing to the project!

@alfredorubin96 Done


E2E tests for configuration screen for different roles

What
E2E tests for configuration screen for different roles
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2919227
How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

This looks great. Let's have those snapshots so we can review the golden files as well.

is this update intentional?

is this update intentional?

No, got updated automatically


Old build in npm-package (0.7.2 instead of 0.7.3)?

I installed leaflet from npm doing npm install leaflet.
The version in node_modules/leaflet/package.json is 0.7.3, but L.Version in source (node_packages/leaflet/dist/leaflet.js) is 0.7.2.
So how to get the latest stable release (build) of leaflet using npm?

It's 0.7.3, just with a wrong L.version constant. See #2735


River is deprecated in ES 1.5

Since River is deprecated in ES 1.5
http://www.elastic.co/guide/en/elasticsearch/rivers/current/index.html
and seems will never be added back
So, that means elasticsearch-river-web cannot be used after ES 1.5, right?

Yes, River Web will not work on ES 1.6 or the above.
Therefore, River Web will be changed to Java application.
We started to work on it.

River Web 1.5 runs as Java application.

So this can be used for 1.6 now?

I think that it works on elasticsearch 1.x.


Various small bug fixes in ffigen

Fixing some bugs I ran into while working on protocol implementation:

NSObject is not actually the root of the ObjC class hierarchy. Instead there's an internal object type that's the true root. This is what id is actually supposed to map to. In the Dart wrapper objects, our root is ObjCObjectBase, so I've mapped id to this instead.
Fixed most of the "Duplicate methods with different signatures" log spam.

Add method deps before checking for duplicates, to ensure that msgSend is non-null. Part of the signature check is checking whether the msgSends are identical between the methods, and if one is null then that's treated as a mismatch.
Some Apple APIs have methods that are supposed to be declared as returning instancetype, but instead return id, eg NSInflectionRule.init. In these cases we keep the instancetype version.
Found two other causes of this spam, but I'll leave those for later: #1136 and #1137

Remove some nonexistent includes from pkgs/objective_c/src/foundation.h.

coverage: 90.956% (+0.1%) from 90.815%
when pulling 7caea8df4ba4b21ceb552188c2dd3500b3dd32e7 on objcbase
into 1807deec2d958266181ba80b9f59832d9b118a60 on main.

Please add a test for this, so that we don't regress this.

Done


Windows editor like notepad fails to open desired file in WSL shell

In bash, I try to open an existing file which belongs to WSL by some editor installed in Windows, but it will try to create new file in c:\windows\system32

DO NOT create / modify Linux files from Windows apps, tools, scripts or consoles
https://blogs.msdn.microsoft.com/commandline/2016/11/17/do-not-change-linux-files-using-windows-apps-and-tools/


Attach preview window to DOM element, instead of placed by pixels

This plugin is awesome, many thanks. I am trying to attach the preview to a dom element which is dynamically placed, and then have it move with the element as scrolling occurs or the element's position changes.
The only way I can see straight away to do this is keep an eye on the element's location and as it changes kill the preview window and add a new one at the new location; obviously this is horribad especially for scrolling.
Is there any way I can attach it to an html element so it's always stuck with it?

Doubt you can do this as the camera element is actually not in the webview DOM

Hey thanks for the reply @DaCardinal ... do you have any suggestions on how I can solve the issue of the preview window working on various form factors?

Easy answer probably pretty hefty coding solution. You'll need to embed the camera in a cordova webview to be able to  have that sort of interaction.Take a look at this http://docs.phonegap.com/en/2.3.0/guide_cordova-webview_android.md.html#Embedding Cordova WebView on Android

Hrmm my entire app is Cordova, and the app itself will need to communicate with the preview window of course, so I'm not sure well that approach will work. I'll investigate though thanks a bunch!

You can take a look at this https://github.com/alexwasner/Cordova-Camera-Webview haven't tried that yet.Though

Maybe you could try this https://github.com/webrtc/samples


Update README.rst

Fix cylce -> cycle
:) Great project BTW, really excited to try and apply the learnings to a pi-zero w project I'm working on.

Thanks, I'm glad you found it useful. Good luck with your project =)


Developing a process for issue review and contributions

To ensure good work practices, we need to decide upon a process for contributing to the repo.
Following up to our Dec. 13th call, I have reviewed the issues/PR processes followed in other GA4GH projects and prepared a PR for review. Some thoughts to consider:

Do we want to include some kind of formal voting/review as part of PR approval? Right now, community review is implied in

Open issues and PRs are reviewed and triaged in our QC of WGS calls.

Would it be useful to include definitions of product maintainer, contributor, subgroup lead, etc.?
Do we want to create PR/Issue templates for contributors?
Do we want instructions on how we'd prefer use of Github labels, milestones, and the project board?
Not yet described are Github features like code review limits. Do we want to enable any of these features?

Examples: VRS Development Process, VRS CONTRIBUTING.md, TRS CONTRIBUTING.md, Phenopackets CONTRIBUTING.md

@lindsmith Thanks for starting the discussion! Do we general templates for GA4GH repos for some of these? I suspect PR/issue templates could be relatively generic, as could be an agreed-upon set of labels as starting points and what the expectations for maintainer and contributors are. Happy to go with ad hoc definitions for now and use them to start a broader discussion.

@ohofmann Unfortunately no general use templates yet, but this has been submitted as a best practice need (see the Airtable board) for further development & discussion.
I think we will need to go with our own ad hoc definitions for now. I agree - let's share our decisions to generate some broader discussion. I'm assuming the Best Practices team will be reaching out to groups in the future to collect this information anyway.

Okay! @skanwal - can you work with Alexis and the team to port over some of our ICA (and UMCCR) templates for reports/issues or PRs?

Hi @lindsmith - Re adding templates for issues and PRs, I am not able to access "Settings" for this repository. I think because I am not part of GA4GH github org.
Is it possible for you to add me?

Hi @skanwal - I updated the permission, can you access the settings now? Please let me know if not and I have one other fix to try.

That worked, Lindsay, Thanks.

Spoke too soon. I am only able to view limited options in "Settings".
Ability to setup templates is still not accessible.

@skanwal - ok, you are now an admin to the repo! Working now?

Yes, I can see complete options now. Thanks. I plan to set-up templates next week.


Out of memory on large schemas

Error:
 abort("Cannot enlarge memory arrays. Either (1) compile with -s TOTAL_MEMORY=X with X higher than the current value 33554432, (2) compile with -s ALLOW_MEMORY_GROWTH=1 which adjusts the size at runtime but prevents some optimizations, (3) set Module.TOTAL_MEMORY to a higher value before the program runs, or if you want malloc to return NULL (0) instead of this abort, compile with -s ABORTING_MALLOC=0 ") at Error at p (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:13446) at m (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:13597) at Ve (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:23682) at E (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:13675) at _ (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:14095) at w8 (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:2343558) at X5 (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:2319786) at MA (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:1290600) at TA (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:1290532) at OJ (blob:https://apis.guru/9de57295-33a6-4398-8229-46c5dadfee67:1:2084422) If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.DISMISS

Caused by a very large schema (which i cannot provide unfotunately, but its about 1026396 lines), any work around?

@jonmillar Thanks for reporting.
Memory limit is hardcoded here:
https://github.com/APIs-guru/graphql-voyager/blob/24c895560d3e43aed8e7936c069c47e3583402ea/src/graph/viz-worker.worker.js#L6
If you have Node.js enviroment it would very helpfull if you find minimal limit that will work with your GraphQL schema.
npm start supports hot-reloading so it should be pretty fast process.

Hi Can i know if changing the limit  invoyager js from 2 * 16777216  to a higher value helped?


Fix GuzzleHttpAdapter

GuzzleHttpAdapter was not following the AdapterInterface contract, returning instances of Stream instead of string.

Thanks. :)


Propagate custom styles in drawer section

I cant apply my own custom styles in Drawer.Section. Probably the styles as prop should be passed on here?
The need of this is because several times the section headers are overalapped and even the items are not visible at times. Here is a screenshot of what happens when i place two sections one after the other :

Also, if there is two sections one after the other, and the second one contains say 3 or more elements, some of them are not even rendered in view :
<Drawer.Section
             items={[{
                 icon: 'home',
                 value: 'Profile Page'
             }
           ]}
         />
       <Drawer.Section
           title="Actions"
           items={[
             {
               icon: 'settings',
               value: 'Settings'
             },
             {
               icon: 'label',
               value: 'Settings-2',
               label: '12'
             },
             {
               icon: 'exit-to-app',
               value: 'Exit'
             }
           ]}
           style={styles.section}
           />

     </Drawer>

Thus i feel maybe propagating the user css might resolve this issue. What do you think?

also have this problem

also have this problem

Want to submit a pull request?

remove the flex attribute in the session's style can resolve the issue.
const styles = {
    section: {
        //flex: 1,
        marginTop: 8
    }
    ...


Job icons

is there a way to have Job icons added, like from these two older ones pluggins below. would be nice to be able to add icons with job names like GNB but also have choice of icon instead or both
Both of these have icons, but limited configurations compared to Playertags much more detailed configs.  It would also be nice to be able to change size of tags.
https://github.com/xPumaa/JobIcons
and also
https://github.com/shdwp/xivPartyIcons
--Issue with Jobicons is it is not kept up and has limited options - I got jobicons to work but since it is out of date, only by using install from dalamudRepobrowser and that link above.
--Issue with  PartyIcons  is it has  limited configuration options and no ability to have job names like GMB or MNK.
but both have library of icons if they could be included into the  Playertags.

I will have a look on it. Thanks for the references. ^^ Let's see, what's possible. :D
Btw, don't afraid of creating future issues here: https://github.com/Pilzinsel64/PlayerTags/issues/ ;)


GM1 Editor new Prerelease

Hello Guys,
i realeased the first Version from my GM1 Editor: https://github.com/Gaaammmler/Gm1KonverterCrossPlatform/releases
Maybe @Sh0wdown can you link the Editor in your Readme, so more People can see it?

  You could?)) Praise you. The old program was very buggy .... it's beautiful !!! Tell us about the functions of the program!
Друг! Ты что,  правда улучшил эту отвратительную программу?? Ты смог?)) Хвала тебе. Старая программа очень глючная была....это же прекрасно!!! РАсскажи об функциях программы!

Nice! I assume you are also going to add a feature to export and import bmp files so we can change the data in external programs correct? After all its a bit inefficient to change each color individually.
@Russianstory from what i can tell atm the main feature of the program is to change the colors used in each of the animation files that make use of a color set, so you could essentially make player one colors pink for example

Thats correct Monsterfisch,
but this function will take a little bit longer, so i made a first Prerelease to change some Colors in the Colortable for new Player Colors etc.
Later i will export all Color Tables + the Images for editing in the upcomming versions

In this case, I would really like the program developer to listen to me.
There is a big problem: extracting and adding graphics files from the game - from hm1 to bmp and back. There is also a problem in extracting and adding animation. There is also a problem in that it is impossible to extract many files at once and immediately and hold. If you succeed in solving this, it will simplify work with graphics. That is why I have difficulty with the graphic part of my mod))).
В таком случае я бы очень хотел, чтоб разработчик программы прислушался ко мне.
Есть большая проблема: извлечение и добавление файлов графики из игры - из гм1 в бмп и обратно. Также есть проблема  в извлечении и добавлении анимации. Ещё есть проблема в том, что невозможно извлечь сразу много файлов и сразу и зажать. сли получится это решить то это упростит работу с графикой. Именно поэтому у меня сложности с графической частью моего мода ))).

sweet definitely looking forward to that day i am dying to finally effectively work on the image files as extracting them 1by1 with the current program is a pain in order to test them in game. in case you are looking for feedback to make the program more userefficient, i am more than open to give my input

Hello Monsterfisch,
that will be nice if u can help me, i added today a new Version for more Userfriendly Support.(I added the export Images options for you so you can try it, the files will be in next realeases got import function.)
https://github.com/Gaaammmler/Gm1KonverterCrossPlatform/releases/tag/0.1a
What do you want me to do next? If u want we can Speak about it, i'm also a German Dude. I only write all in english to help other People understand all of it what i am doing. :)

yeah i know you are german i write in english for the same reason.
You can add me on discord Monsterfish_ #7254 if you want which should make communication there a little easier ;)
As for what to do next I mean being able to extract and import the animated building tiles like gatehouses and towers etc would be pretty nice as it in the current program causes glitchy textures to appear on other textures from the same gm file.
Another thing that would be fantastic would be if you could add a feature where you can adjust the size of the images for example in my version of the game the roofs for the big square towers are not as wide as the tower itself which limits the range of possibilities of what can be done with it but I can elaborate on that more in private if needed.

To all Guys following the Thread, new Release will comming soon!
I need to do some small bugfixing and allmost all can be done in the Exporter/Importer, i have some Images that show what can be done by the next realease:

You're doing allright! Hope that your work will help all modding community and especially Stronghold Europe team to bring some long-awaited features!

Hello Guys,
i just created a new Prerelease https://github.com/Gaaammmler/Gm1KonverterCrossPlatform/releases/tag/Pre-release
have fun to test it.

I started to develope a game called Wild Wild West (not that movie with foreigns). I think it will be a browsergame cause there is no Stronghold-1 SDK (i don't like STRG+2 STRG+3 :-b)
Is there a way to export all images? Currently i need to take a screenshot and edit it in gimp.

@sdiebel yes you can do it by click the export button? Or how do you use my converter?

Thanks man that's what i have needed, i used Stronghold Image Toolbox before and screenshot... but your Converter is perfect for that job. Nice and thank you, maybe i could donate when i reach my goals.
I'll use the images for a game which i'll make private not public and commercial. When the game runs then sure i have to make own graphics as long no license is available. But that's task after finishing the game.


Page feedback - feature flags

Suggested improvements for page: https://opentelemetry.io/docs/demo/feature-flags/
This looks very straightforward, except the repo I'm using doesn't seem to have a src/flagd/demo.flagd.json file.
All I see in the src folder is the services, there is no flagd folder.

Thanks for reporting your issue, @szeitlin.
@open-telemetry/demo-approvers, PTAL!

@szeitlin which repo are you using?
This doc page is responsible for instructions on the upstream OpenTelemetry Demo: https://github.com/open-telemetry/opentelemetry-demo
If you are using a vendor fork or some outdated version of the demo you indeed may not have that file.
In that case you can navigate to the path /feature of your your frontend page.
Depending on how you are running the demo, that would be:
http://localhost:8080/feature
The Feature Flags can be enabled/disabled in there.
I don't think we should have that explained in the upstream docs though, as we try to keep docs and demo up-to-date and in sync.

interesting, I'll try that. Yeah this is a vendor fork (and their fork isn't completely up to date with yours, it turns out). Thanks!

Thanks, all!
@szeitlin I'm going to close this issue, but please feel free to come back with any other docs issues you encounter.


Master 3.1 uplift vis

Added minor funtions and fixed issues.

@leefrank9527 happy to merge.
A reminder to try and make variable names as descriptive as possible/necessary

@obrienben Thank you for the reminding, have renamed some variables and a method to make the code more readable. The branch was updated.