Add new BufferSystem to Renderer

Hey peeps,
So was thinking about how we push pixi forwards using the new Uniform buffer objects stuff. This could be quite useful in reducing gpu calls further down the line!
UniformBuffers are basically handled exactly like the buffers we currently have, but are obviously not related to geometry!
To that end I have separated the buffer logic from GeometrySystem and created a new BufferSystem. Aside from the fact it paves the way for UBO usage, feels like this is actually a nice separation of concerns!
Fortunately only GeometrySystem uses is for now, so a low risk refactor!
One question for perhaps you @ivanpopelyshev , the ref counting - this only makes sense in the geometry right? Or should that be moved to the buffer system too?

Codecov Report

Merging #7096 (deb400b) into dev (ae43a8f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #7096   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           17        17
  Lines          699       699
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae43a8f...3fbc8be. Read the comment docs.

With refcounting, buffer is disposed at the same time as the last geometry that has reference on it.

When you add UBO's - you'll have to refcount buffers in them too.

With refcounting, buffer is disposed at the same time as the last geometry that has reference on it.

cool, so this works as is?

I found a bug in it yesterday, #7093, and added test for it. Your code looks straightforward.
There's a reason we didnt implement RenderBufferSystem for example: it completely covered in FrameBufferSystem.
If you really have time to experiment right now then we have to merge this thing so you can start next PR

I think #7107 should be merged into this branch before approving this.

I think #7107 should be merged into this branch before approving this.

@GoodBoyDigital can you resolve conflicts with your other shader optimization PR?

@GoodBoyDigital can you resolve conflicts with your other shader optimization PR?

sure thing! Done and done!

@GoodBoyDigital build is now passing on actions!

This is intense; I can't wait to test it out & write about it.
I went through all the code and read the docs to understand what's going on. I think we can make sure our docs maintain a standard of quality; we're PixiJS :) Otherwise, the code itself is very robust. Nice work!

cheers man! Totally agree, dos should be top draw! The written word tends to be my enemy :P so feedback on docs like this is always appreciated! 👍

Still seems to be intermittently failing, can you look and see if this actually a bug?
Uncaught TypeError: Cannot read property 'refCount' of undefined
      at GeometrySystem.disposeGeometry (/home/runner/work/***/***/packages/core/dist/cjs/core.js:2737:256)
      at GeometrySystem.disposeAll (/home/runner/work/***/***/packages/core/dist/cjs/core.js:2741:298)
      at GeometrySystem.contextChange (/home/runner/work/***/***/packages/core/dist/cjs/core.js:2682:137)
      at Runner.emit (/home/runner/work/***/***/packages/runner/dist/cjs/runner.js:57:578)
      at ContextSystem.handleContextRestored (/home/runner/work/***/***/packages/core/dist/cjs/core.js:2504:175)

Yo! yeah, seeing some weirdness on my end now too! got this error for interaction tests:

@SukantPal any idea what could be going on there?

That seems weird to me that Interaction would originate this TypeError. Here's the code in  disposeGeometry where this is coming from. So buf here is undefined. I guess that's because _glBuffers[this.CONTEXT_UID] is undefined or else we'd get undefined on _glBuffers.
        const buffers = geometry.buffers;
        // ...
        for (let i = 0; i < buffers.length; i++)
        {
            const buf = buffers[i]._glBuffers[this.CONTEXT_UID];

            buf.refCount--;
            if (buf.refCount === 0 && !contextLost)
            {
                this.disposeBuffer(buffers[i], contextLost);
            }
        }

That seems weird to me that Interaction would originate this TypeError. Here's the code in disposeGeometry where this is coming from. So buf here is undefined. I guess that's because _glBuffers[this.CONTEXT_UID] is undefined or else we'd get undefined on _glBuffers.
        const buffers = geometry.buffers;
        // ...
        for (let i = 0; i < buffers.length; i++)
        {
            const buf = buffers[i]._glBuffers[this.CONTEXT_UID];

            buf.refCount--;
            if (buf.refCount === 0 && !contextLost)
            {
                this.disposeBuffer(buffers[i], contextLost);
            }
        }

hmmm, perhaps the geometry is being destroyed before its buffer has been created?

Also, seems like this is triggered by a context restore. Might that have anything to do with it?

Also, seems like this is triggered by a context restore. Might that have anything to do with it?

looks like the context was getting lost right before the destroy is called in the tests!
Added a catch to check gl buffers exist before we destroy em. (if they don't, they were already destroyed so should be all good!)

Great work @GoodBoyDigital!


Error setting up integration

Hi, after installing with HACS and adding the integration with address, zip, etc., i get the following error:

This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/renoweb/init.py:84
Integration: RenoWeb Garbage Collection (documentation, issues)
First occurred: 11:13:24 AM (3 occurrences)
Last logged: 11:17:53 AM
Error setting up entry None for renoweb
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 335, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/renoweb/init.py", line 84, in async_setup_entry
await renoweb.get_pickup_data()
File "/usr/local/lib/python3.9/site-packages/pyrenoweb/client.py", line 258, in get_pickup_data
for row in json_data["list"]:
KeyError: 'list'

Any idea what could be wrong?
Best regards
Mathias

I just tried with the neighbour address and worked perfectly.
My address is "3B". Entering the address without the "B" works as well.


Logging to Debug Console via 'debug' package broken after a call to console.log

Version: 1.29.1 (user setup)
Commit: bc24f98b5f70467bc689abf41cc5550ca637088e
Date: 2018-11-15T19:13:36.375Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
When running my node app in the vscode debugger, log statements made via the debug npm package successfully print to the Debug Console, up until the moment my app makes a call to console.log(). After this call, no further log statements made via debug will show up in the Debug Console. They will successfully print when I run my app from the command line, indicating this is an issue with vscode.
Steps to Reproduce:
const debug = require('debug')('app');
debug.enabled = true;

debug('debug message 1'); // <-- Displays in Debug Console
console.log('console message'); // <-- Displays in Debug Console
debug('debug message 2'); // <-- Does not display in Debug Console. Does show up in shell.

Repro project here: https://github.com/eanders-MS/vscode-console-bug

The debug module writes directly to stderr, so it is invisible to the debugger. But the node debug extension shows all stderr output until the first normal log message it receives (in this case, from console.log), because that early stderr output may be startup errors. But that's why the first one shows up.

Also you can set "outputCapture": "std" in your launch config to get all output from stdout/stderr.

Or configure debug to log with console APIs instead: https://www.npmjs.com/package/debug#output-streams

Oh interesting. Thank you for the clarification and the workaround suggestions.


Math based algorithms

DESCRIPTION
WIll we implementing a few math based algorithms like:
(1) Factorial
(2) Fibonacci Series
(3) Project Euler problem-1
(4) An algorithm for a Random Number Generator
STEPS TO REPRODUCE
Will be coding the following algorithms in C,C++ or Python.
Proposed Solution [optional]
I'd like this issue to be assigned to me so that I can implement the following.

@prateekiiest can you assign this to me? :)

This are really novice problems
It could be better if you can work after problem 20

Okie I'll have a look at it and get back to you!


Sluggable: "unique_base" option with indirect associations

I have an entity Role associated manyToOne with an entity UserType, which is in turn is associated manyToOne with an entity Account.
Role ==manyToOne==> UserType ==manyToOne==> Account
I would like to generate slugs for my Role entity that are unique within an Account (not within a UserType).
I'd like something like the following. Would that be possible at all?
My\App\Role:
[...]
slug:
    type: string
    gedmo:
        slug:
            fields: [label]
            unique: true
            unique_base: userType.account
            updatable: false
[...]

I could add another direct association directly between Role and Account, but I think that'd be redundant data...

Hi, sorry, the issue slipped away somehow. It is not possible at the moment. Timestampable has this kind of feature for on changed events, marking it as feature request


VASARA Collection [PCSE01314]

App summary

App name: VASARA Collection
App serial: PCSE01314
App version: 1.01

Vita3K summary

Version: v0.1
Build number: 1827
Commit hash: https://github.com/Vita3K/Vita3K/commit/0f2aabb900ddd27078df540bfe8f1d177ff0445d

Test environment summary

Tested by: Arnold Secret
OS: Windows 10
CPU: Intel Core i7-4500U
GPU: NVIDIA Geforce GT 740M
RAM: 8 GB

Issues
Unicorn error on loading.
Screenshots
None.
Log
vita3k.log

Vita3K v0.1.5 2724-4cc25397
still nothing
vita3k.log

Vita3K summary

Version: v0.1.6
Build number: 2840
Commit hash: https://github.com/vita3k/vita3k/commit/4a2c6582
CPU backend: Dynarmic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:
Game has occasional flickering
Screenshots:

Log
vita3k.log
Recommended labels

Playable
Graphics bug


Merge 'release/3.0' into 'release/3.0-preview9'

Is there an issue tracking a similar update to all repos? Also, we need to update the branding in the 3.0 branches to RC2? And also, I think we're gonna run into some issues with Blazor packages which will be building with preview9 packages in both branches?

Is there an issue tracking a similar update to all repos?

This is a mad dash that's being discussed in email and on Teams.

Also, we need to update the branding in the 3.0 branches to RC2?

Yes.

And also, I think we're gonna run into some issues with Blazor packages which will be building with preview9 packages in both branches?

Talked to @danroth27. We're going to leave branding in aspnet/Blazor and the client-side Blazor corner of aspnet/AspNetCore alone.

Bump approvers…
And @JunTaoLuo I'll update this branch to pick up whatever NuGet workarounds we need, once you get them into 'release/3.0-preview9'.


u-boot: Add mechanism to programmatically set fuses for HAB/AHAB (i.M…

…X only)
This mechanism allows the programming of HAB/AHAB fuses via u-boot variables. The following u-boot variables can be set for this mechanism to work:

fuse_prog_list: An ordered, space separated list of hex values to be programmed into the fuses.

fuse_prog_close: A boolean 1 or 0 for whether the device should be closed for HAB/AHAB. This variable is optional and if it does not exist it's the same as if it was 0.

fuse_dry_run: Boolean 1 or 0. Causes the logic to do a dry run of the actions without actually programming any fuses.

As feedback this mechanism will set the following environment variables.

fuse_val_N: This contains the hex value currently programmed in the Nth HAB/AHAB fuse on this device.

fuse_fail: This will be set to 1 if any errors are detected in the process of programming the fuses on this device.

Related-to: TOR-3634

Alright, this was a fun one. I tested this on:

Colibri imx7-emmc
Colibri imx8x
Verdin imx8mp
Apalis imx6
Apalis imx8

I also tested this on a device with actual HAB/AHAB events, as well as on a device where the fuses were actually set prior to this.
Finally, I tested this on a device where U-Boot did not have HAB/AHAB capabilities enabled. The device still boots fine. However, there are some minor consequences. We want to run read_fuses every boot to see if any fuse values changed and need to be recorded. However on a U-Boot where HAB/AHAB is not enabled, the command that was added here, tdx_is_closed, will not be available. Meaning during boot there will be a small complaint from U-Boot that this command doesn't exist. This doesn't actually affect anything as read_fuses will treat the exit code from attempting to run this non-existing command as if the device is open, which I guess is a safe assumption. Same thing with hab/ahab_status in prog_fuses, though this would only be executed if for some reason fuse_prog_list was set on a non-HAB/AHAB enabled U-Boot.
I'm not sure if there is a more elegant way to handle this, I couldn't find a way in U-Boot to "test" if a command exists or not.

V2 submitted.

V3 submitted.
This also includes a solution for that issue we discussed where the device should reboot after programming the fuses, but before running hab/ahab_status. I may need to do some further testing on this, but my initial testing looked good.

V4 submitted.


HLSL Support

This adds basic HLSL support (vert, frag and early compute support). It's in active use for a while now in Kha/Kore via krafix and the code which actually runs it is in HlslTranslator2.cpp - there's also code for compiling the HLSL code in D3D9Compiler.cpp and D3D11Compiler.cpp - not sure about putting that into SPIRV-Cross.
I only just started testing and fixing the SPIRV-Cross shaders (basic.vert and basic.frag at least are working), so it's kinda early, but I'd still like to get the process started. The sooner I can get more people to see it and help out with it the better I think.

Cool! Before reviewing in detail I'd like to see some basic regression testing set up.
I just added basic setup to regression test Metal output: https://github.com/KhronosGroup/SPIRV-Cross/pull/100. You could base it on that. I assume that we can use glslangValidator in HLSL mode to compile to SPIR-V and also to validate the HLSL output from SPIRV-Cross.

Will do. Can also implement an optional test mode using Microsoft's compiler (run only on Windows, load dll dynamically).

Wouldn't it also work to just optionally call "fxc" from Python instead? I'd like to avoid Windows-specific test code if possible.

Sure, can as well call fxc.

All done.
There's a problem with line endings because spirv-cross on Windows outputs \r\n and regression_check just compares a file hash. We should probably change that and also add an appveyor script so the fxc test can actually run.

I assume more tests will be added soon? I assume compute/tess/geom isn't working at all?

Some compute works, tess/geom not yet. We'll have to talk about tess before I add it because the structure is somewhat different (separate function for controlling tess factors). Yes, will add more tests.

All done.

All done once again.

Thanks for the contribution.


Can´t download chapters.

When i try to download chapters i get this error.
 Traceback (most recent call last):
   File "code.py", line 26, in <module>
synopsis = soup.select('div[class="fr-view"]')[1]
IndexError: list index out of range
From this line of code:
synopsis = soup.select('div[class="fr-view"]')[1]
And if i change the index number to 0 the scripts works fine and lets me chose the range of chapters to download but when its all finished and all the only thing thats saved its the image of the novel.
The novel that i tried to download was Overgeared, i am using Windows 10 and everything is updated according to the guide.

It works now. Please check the latest version.


On repo don't have any file as on pub.dev

player_widget.dart
global.dart
not found

Sorry, please follow the issue template as this issue as-is is incomprehensible.


Travis/update build matrix

Similar to pull request #206 but without the build stages.

Now fixed. See my note in #206


Add support for angular in null-safety migration tool.

Null-safety migration tool could be improved to better support code depending on Angular.
Example / first step:
In angular, injectable constructor parameters can be annotate with "@Optional()" to indicate nullable parameter.
This could hint the migration tool to make the corresponding type/field nullable.

Some more easy fixes:
@ViewChild() and @ContentChild() also require nullable types.

Ok, with 4d0dc2ea8a5da68d65252c68df1bd81a15ca2a5d, @Optional() implies nullability, and with f66037acce9222718a0158e3f61590f5608a39a2, @ViewChild() and @ContentChild() imply nullability.  I'm going to close this issue since everything that has been requested so far is complete.  @grouma please feel free to reopen (or open a separate issue) if something else comes up that is needed.


Admin

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@raulalvarado1 I'm sorry, but I don't understand what you're asking for here. You have not provided any information about the feature you're requesting.


Added ability to transfer props to children

I needed this feature, but last version broke it.

Would be good if you could add some example usage, or documentation on this to README.

Maybe just to copy an existing example and adjust it to show this feature.


fix(output): do not print syscall_buffer_size when gvisor is enabled

Signed-off-by: Aldo Lacuku<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Avoid printing the syscall_buffer_size when gvisor is enabled.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval by writing /assign @mstemm in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: af5d5a2bcbe1c2d0c101b9440f5792acafaa84fc

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[TASK]: Making the dashboard include real data

Task Summary
Make the dashboard have real data pulled from the database
Acceptance criteria

Gets user data
Shows user data correctly

Any Additional Context
No response

Assigning myself to this

deplicate


Grid view

Hi, is there any possibility that we can browse the feed in grid view, not linear

It's possible. I might add this in the future 👍

A grid view would be wonderful!

Not sure why this issue was closed before the request was implemented, as it sounds like it is something that could be viable. Reopening.


Fix issue with "=\n" in end of QP string

Reported at zbateson/mail-mime-parser#132
If a string ends in an '=\n', the '=' character is printed.

Released in 1.0.4


Proofread German locale file

Went through the German locale and fixed some stuff.

@rbq thank you very much for your contribution!
We chose capitalization for words in titles and on buttons. That why it is Wieder Starten instead of Wieder starten. Otherwise your changes look good!
Thank you again!

Oh, okay. But why not put the correct spelling into the locales files and use CSS for presentational purposes? Should be less confusing for translators and improve reusability of strings.
h1, h2, h3, h4, h5, h6, input[type="button"], input[type="submit"] {
  text-transform: capitalize;
}

@rbq text-transform can be hurt certain locales. It's not localization friendly.

@rbq thank you again!

I reverted everything that looked like it's meant to be capitalized.
@joaocunha Not sure I understand. Capitalizing words against the rules of grammar obviously changes their meaning in any language, doesn't it? E.g. „Willkommen zuhause“ welcomes someone returning home, whereas „Willkommen Zuhause“ is a strange but friendly greeting from someone to their home. „Ich folge“ means “I follow”, but „Ich Folge“ means something like “Me, the sequence, …”. That's why I suggested using correct translations in the first place. ;)

You're welcome. :)

@rbq not sure I understand you too :)

Oh, okay. But why not put the correct spelling into the locales files and use CSS for presentational purposes?

We are capitalizing the strings by hand so it's predictable. If we leave that job to CSS, it can capitalize the string incorrectly - for example, a Turkish ì would become I in certain browsers, hence changing the meaning of the word.
You can see a test table here: https://www.w3.org/International/tests/repo/results/text-transform

So it changes it into a different letter? Not cool. 😆
What I mean is that in German all nouns are capitalized and lots of words are turned into nouns when you capitalize them, e.g.:

folgen – to follow / Folgen – the sequences
zuhause – at home / Zuhause – the home

Capitalisation for decorative purposes might work in English and other languages because the casing barely carries any meaning. In German that's just not the case.

@rbq ah, I get you. Makes sense, but I'm afraid I'll have to leave Diese Diskussion for you German speakers :P
Thanks a lot for your input and fixes!


Question: uint64 or int64?

From the README, sonyflake uses 63 bits. This aligns with the design of  Snowflake ID, which is specifically designed to fit in a signed integer:

Snowflakes are 64 bits. (Only 63 are used to fit in a signed integer.)

I notice that sonyflake returns uint64 rather than int64:
https://github.com/sony/sonyflake/blob/848d664ceea4c980874f2135c85c42409c530b1f/sonyflake.go#L86
Should it return int64, instead?
I assume not since it has been around for a while. If that's correct, perhaps some documentation could be added to describe how to safely convert the value into an int64 so that it might more easily be used in databases that don't support uint?

The NextID return should return int64，because the result max is int64 length

Thank you for your feedback!
I think it is better to keep the interface for the compatibility. I have added a note instead:
https://github.com/sony/sonyflake/commit/3719d006ac3b5aa6d2beb9739a1d1e637ec3d53f


Updating .jshintrc per Issue #331

Updating with additional checks to make our code cleaner

Skipping PR - No APP related changes

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

.jshintrc, line 4 [r1] (raw file):
Shouldn't we set esversion to 5?
Freeze also seems like a good idea.
latedef also makes a lot of sense
maxdepth set to 2 or 3 also seems wise

.jshintrc, line 5 [r1] (raw file):
immed is going bye bye. Shouldn't we bring in jscs? This would give us much better control over our style

.jshintrc, line 6 [r1] (raw file):
Same as immed

.jshintrc, line 7 [r1] (raw file):
I'm sure it will make somebody unhappy but I'd love to add nocomma
I don't think it's a big deal but it seems pretty harmless to throw in nonbsp
nonew seems good as well
singleGroups seems good

.jshintrc, line 12 [r1] (raw file):
Do we actually want browser set to true? The code in the Thali_CordovaPlugin project doesn't run in the browser.

.jshintrc, line 14 [r1] (raw file):
Do we want strict set to global? This would also let us get rid of the deprecated globalstrict

.jshintrc, line 15 [r1] (raw file):
I can't find trailing as a listed option in http://jshint.com/docs/options

.jshintrc, line 16 [r1] (raw file):
globalstrict is being deprecated so we should probably remove it.

.jshintrc, line 17 [r1] (raw file):
I can't find white listed in http://jshint.com/docs/options

.jshintrc, line 18 [r1] (raw file):
This is being deprecated. Again, shouldn't we use JSCS?

.jshintrc, line 21 [r1] (raw file):
Which warning is W030?

.jshintrc, line 22 [r1] (raw file):
Since JXCore is Node 0.10 and as Node 0.10 doesn't support EcmaScript 6 is defining this as a predef a bad idea? For now we have to explicit require a library like lie or we won't have promises and this could hide that until runtime. Once we use EcmaScript 6 runtimes on all our platforms we can revisit.

Comments from the review on Reviewable.io

Skipping PR - No APP related changes

Skipping PR - No APP related changes

Skipping PR - No APP related changes

.jshintrc, line 18 [r1] (raw file):
Will look into jscs after this...

Comments from the review on Reviewable.io

.jshintrc, line 21 [r1] (raw file):
Got rid of it instead, put in expr: true

Comments from the review on Reviewable.io

Skipping PR - No APP related changes

Reviewed 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

.jscsrc, line 2 [r5] (raw file):
I'm not sure I agree on this one. The reason is that I sometimes have unused params to remind me of the fact that the argument is being passed to me but I'm not currently using it. This is really common with callbacks. I'm torn on this one.

.jscsrc, line 9 [r5] (raw file):
Shouldn't we have checkRedundantReturns: true?
Also we should have checkTypes: strictNativeCase, this one has been driving me crazy and my own docs are a mess because of it. Would love to have this checked.
I'm also shocked you didn't jump on checkRedundantAccess with "enforceLeadingUnderscore"
I'm also surprised you didn't jump on leadingUnderscoreAccess
I suspect requireDescriptionCompleteSentence is probably a good idea

.jscsrc, line 70 [r5] (raw file):
I'm really drawn ot maximumNumberOfLines. There is a limit there somewhere, say 1000 lines after which it's time to split.
We should set requireCamelCaseOrUpperCaseIdentifier to true
The temptation to set requireVarDeclFirst is really high. :)
We absolutely must set safeContextKeyword, I prefer self to that but whatever. We need this to be consistent!

Comments from the review on Reviewable.io

.jscsrc, line 2 [r5] (raw file):
I'm not because it forces you to use what you declare.  Remember that if you have multiple parameters and only using the last one, then it won't count against you.

Comments from the review on Reviewable.io

.jscsrc, line 70 [r5] (raw file):
Set the this = self for safeContextKeyword.
Let's hold off on the requireVarDeclFirst at the moment.
Agreed on the line limit which would keep us from big balls of mud, although if our documentation is that long, is that worth it?

Comments from the review on Reviewable.io

Skipping PR - No APP related changes

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

.jscsrc, line 70 [r5] (raw file):
My goal is that as the docs get implemented we delete the procedural parts of the doc and just use the code. I expect to review code by seeing what was deleted in the doc and confirming the code matches.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

:shipit:


Python code generation

There is currently a python_generation example that illustrates how to customize code generation to produce python code. This example could be promoted into a library feature. This would unlock quicker experimentation - for example when iterating on a function in a python notebook.
Broadly:

The generator in the python_generation example could be moved into C++, like the other generators.
The resulting code would use numpy for mathematical operations.
Optionally, the generated methods could use @numba.jit to allow quick JIT compilation of generated code.

#288 has been merged. Examples + documentation are to come.

Added an example of generating methods with JAX in #294.


Add backpressure support which retains last Query value.

Might fix #34, but can't repro it.

LGTM

I'd like to play with changing this to do compare-and-swaps instead of locks, but for now the behavior is all I want.


Create function for setting SimAuto flags/constants

There are some SimAuto constants/flags such as "CreateIfNotFound" that users may want to set. We should create a single entry point for setting these.

Fixed in b89ac5a5f0bbe5bc866542e48ce761d06cbc7a67.

Other properties like CurrentDir, ProcessID, RequestBuildDate and ExcelApp might be implemented based on requests. Close the issue now and feel free to re-open it if it does not solve your problem.

@mzy2240 - I think we should create a function so that you can change these on the fly, rather than once upon initialization.


chore: add withWhereHas method to supported Eloquent Builder methods

…(#1523)

[x] Added or updated tests
[x] Documented user facing changes

Changes
add withWhereHas method to supported Eloquent Builder methods.

Breaking changes

Workflow seems to have failed by accident.

Thank you!


#10211: Fix iterating cores in core range

Ticket
Link to Github Issue
Problem description
Iterating over the cores in a core range sometimes iterates over cores outside the boundaries of the core range. This commit fixes that by only iterating over the cores within the boundaries of the given core range.
What's changed
Inside the CoreRange class, a nested class called CoreIterator is responsible for handling the iteration over cores in a core range. The iterator lazily generates the successive core to be traversed after the current core. CoresInCoreRangeGenerator is no longer used anywhere and so it has been removed. In order to be able to use CoreIterator, the CoreRange class has two new methods - begin() and end() - which are used when the iterator is called. Since end was already being used as a member variable, I renamed it to end_. I also renamed start to start_ to be consistent. Most of the files that have been modified are because of these member variable names being changed.
Checklist

[x] Post commit CI passes
[ ] Model regression CI testing passes (if applicable)
[x] New/Existing tests provide coverage for changes

You should implement both row-wise and col-wise iteration.

You should implement both row-wise and col-wise iteration.

I can modify the implementation to support col-wise iteration as well. However, if I implement support for col-wise iteration, I was thinking of leaving row-wise iteration as the default usage for begin() and end() so that users can cleanly iterate row by row when calling CoreRange in a for loop. Col-wise iteration could be implemented as a separate method that users would have to explicitly call and wouldn't be called implicitly in a for loop over CoreRange.

start and end is used really commonly for CoreRange. Should we rename it to something like start_coord and end_coord?

I'm fine with leaving it as start_ and end_ as CoreRange doesn't have a lot of member variables currently, and I don't think it's ambiguous what a member variable named start_/end_ for a class called CoreRange refers to.

CoreRange::start_/end_ names are not good. They are used actively all over the place. Please follow the recommendation from @TT-BrianLiu . I hope search-replace will be trivial

I agree. If something is named arg_ or _arg, it should only be used internally, but it's used everywhere.

I have renamed start_/end_ to start_coord/end_coord


Add MySQL-python to requirements.txt so Cabot can use mysql

@mahendra We need this to use MySQL databases with cabot.
I ran the tests using a mysql test db and everything worked fine except an issue mysql has with unicode, which shouldn't be relevant for us

trigger build


CI: ClusterMesh: timeouts in client-egress-l7

I've seen a few variations of this, all with L7 on egress and clustermesh:
  ❌ client-egress-l7-named-port/pod-to-pod/curl-1: cilium-test/client2-bc59f56d5-w5w9c (<IP_ADDRESS>) -> cilium-test/echo-other-node-5c58b8cf8b-g4lwr (<IP_ADDRESS>:8080)
  ❌ client-egress-l7/pod-to-world/http-to-google.com-0: cilium-test/client2-bc59f56d5-bzr5n (<IP_ADDRESS>) -> google.com-http (google.com:80)
  ❌ client-egress-l7/pod-to-world/http-to-google.com-0: cilium-test/client2-bc59f56d5-qkj62 (<IP_ADDRESS>) -> google.com-http (google.com:80)

Link: https://github.com/cilium/cilium/actions/runs/4722694005/jobs/8377638774
Sysdump:
cilium-sysdumps-5.zip
Link: https://github.com/cilium/cilium/actions/runs/4719364276/jobs/8370097019
Sysdump:
cilium-sysdumps-1.zip
Link: https://github.com/cilium/cilium/actions/runs/4713940509/jobs/8359970494
Sysdump:
cilium-sysdumps-2.zip

https://github.com/cilium/cilium/actions/runs/4827305584/jobs/8599940047
this one is with client-egress-l7-named-port but i'm guessing it's the same issue:
❌ 1/32 tests failed (1/224 actions), 1 tests skipped, 1 scenarios skipped:
Test [client-egress-l7-named-port]:
  ❌ client-egress-l7-named-port/pod-to-world/http-to-google.com-0: cilium-test/client2-76f4d7c5bc-k75nf (<IP_ADDRESS>) -> google.com-http (google.com:80)

cilium-sysdumps-7.zip

Hit on https://github.com/cilium/cilium/pull/26205
 ❌ 1/43 tests failed (1/472 actions), 13 tests skipped, 1 scenarios skipped:
Test [client-egress-l7-named-port]:
  ❌ client-egress-l7-named-port/pod-to-pod/curl-ipv4-2: cilium-test/client2-76f4d7c5bc-qbt49 (<IP_ADDRESS>) -> cilium-test/echo-other-node-545c9b778b-6nld8 (<IP_ADDRESS>:8080)

cilium-sysdumps.zip

I've seen
  ❌ client-egress-l7/pod-to-pod/curl-ipv6-3: cilium-test/client2-59b578d4bb-z72ww (fd00:10:242:1::bb2f) -> cilium-test/echo-other-node-596fc9c48f-6vqvd (fd00:10:244:1::e07a:8080)

in https://github.com/cilium/cilium/pull/27838.
Run: https://github.com/cilium/cilium/actions/runs/6042609538/job/16398064551

Hit a similar issue with pod-to-pod on https://github.com/cilium/cilium/pull/28589 (1/10 failures)
[=] Test [client-egress-l7]
142
.......
143
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-only-dns' to namespace 'cilium-test'..
144
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-only-dns' to namespace 'cilium-test'..
145
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-l7-http' to namespace 'cilium-test'..
146
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-l7-http' to namespace 'cilium-test'..
147
  [-] Scenario [client-egress-l7/pod-to-pod]
148
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv4-0: cilium-test/client-78f9dffc84-qwhrf (<IP_ADDRESS>) -> cilium-test/echo-same-node-79d996cb79-8qx7h (<IP_ADDRESS>:8080)]
149
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv6-0: cilium-test/client-78f9dffc84-qwhrf (fd00:10:242:1::a4bb) -> cilium-test/echo-same-node-79d996cb79-8qx7h (fd00:10:242:1::551f:8080)]
150
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv4-1: cilium-test/client-78f9dffc84-qwhrf (<IP_ADDRESS>) -> cilium-test/echo-other-node-9746df45c-cmttz (<IP_ADDRESS>:8080)]
151
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv6-1: cilium-test/client-78f9dffc84-qwhrf (fd00:10:242:1::a4bb) -> cilium-test/echo-other-node-9746df45c-cmttz (fd00:10:244:1::45d4:8080)]
152
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv4-2: cilium-test/client2-59b578d4bb-pgbtx (<IP_ADDRESS>) -> cilium-test/echo-same-node-79d996cb79-8qx7h (<IP_ADDRESS>:8080)]
153
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv6-2: cilium-test/client2-59b578d4bb-pgbtx (fd00:10:242:1::b9de) -> cilium-test/echo-same-node-79d996cb79-8qx7h (fd00:10:242:1::551f:8080)]
154
  [.] Action [client-egress-l7/pod-to-pod/curl-ipv4-3: cilium-test/client2-59b578d4bb-pgbtx (<IP_ADDRESS>) -> cilium-test/echo-other-node-9746df45c-cmttz (<IP_ADDRESS>:8080)]
155
  ❌ command "curl -w %{local_ip}:%{local_port} -> %{remote_ip}:%{remote_port} = %{response_code} --silent --fail --show-error --output /dev/null --connect-timeout 2 --max-time 10 http://<IP_ADDRESS>:8080" failed: command terminated with exit code 28
156
  ℹ  curl output:

Another hit in #29643
..............
[=] Test [client-egress-l7-named-port] [47/59]
........
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-only-dns' to namespace 'cilium-test'..
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-only-dns' to namespace 'cilium-test'..
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-l7-http-named-port' to namespace 'cilium-test'..
  ℹ  📜 Applying CiliumNetworkPolicy 'client-egress-l7-http-named-port' to namespace 'cilium-test'..
  [-] Scenario [client-egress-l7-named-port/pod-to-pod]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv4-0: cilium-test/client-59bddc8c5-2kd52 (<IP_ADDRESS>) -> cilium-test/echo-same-node-5cd8c46654-48js6 (<IP_ADDRESS>:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv6-0: cilium-test/client-59bddc8c5-2kd52 (fd00:10:242:1::d1ac) -> cilium-test/echo-same-node-5cd8c46654-48js6 (fd00:10:242:1::aa3a:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv4-1: cilium-test/client-59bddc8c5-2kd52 (<IP_ADDRESS>) -> cilium-test/echo-other-node-54c86bc6b8-drgzc (<IP_ADDRESS>:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv6-1: cilium-test/client-59bddc8c5-2kd52 (fd00:10:242:1::d1ac) -> cilium-test/echo-other-node-54c86bc6b8-drgzc (fd00:10:244:1::1f19:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv4-2: cilium-test/client2-694d49cf6d-rv5j9 (<IP_ADDRESS>) -> cilium-test/echo-same-node-5cd8c46654-48js6 (<IP_ADDRESS>:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv6-2: cilium-test/client2-694d49cf6d-rv5j9 (fd00:10:242:1::e78d) -> cilium-test/echo-same-node-5cd8c46654-48js6 (fd00:10:242:1::aa3a:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv4-3: cilium-test/client2-694d49cf6d-rv5j9 (<IP_ADDRESS>) -> cilium-test/echo-other-node-54c86bc6b8-drgzc (<IP_ADDRESS>:8080)]
  [.] Action [client-egress-l7-named-port/pod-to-pod/curl-ipv6-3: cilium-test/client2-694d49cf6d-rv5j9 (fd00:10:242:1::e78d) -> cilium-test/echo-other-node-54c86bc6b8-drgzc (fd00:10:244:1::1f19:8080)]
  ❌ command "curl -w %{local_ip}:%{local_port} -> %{remote_ip}:%{remote_port} = %{response_code} --silent --fail --show-error --output /dev/null --connect-timeout 2 --max-time 10 http://[fd00:10:244:1::1f19]:8080" failed: error with exec request (pod=cilium-test/client2-694d49cf6d-rv5j9, container=client2): command terminated with exit code 28

Sysdump:
cilium-sysdumps.zip


SCEP: provide request DN and SAN filter regex

An optional request DN and SAN filter should be available in the SCEP server policy.
Possible purposes:

only accept certain CNs, e. g. if certificates for a certain server group should be issued, but not for other hosts
reject wildcards in requests
To make this easier to configure, it might be useful to provide an "include" and an "exclude" filter.

Example:
...
dn_include_regex: CN=[a-z]+[0-9]+.example.com,.*
dn_exclude_regex: *
san_include_regex: ^[a-z]+[0-9]+.example.com$
san_exclude_regex: *

Solved by the ApprovalRules Plugin in EE


Readjust the nformatter function

This readjusts the way numbers are formatted in CommunityDetails.js and CommunityCompareDetails.js

Nice work, the formatting is looking great now!


Update androidx.core to 1.8.0-beta01

Codecov Report

Merging #320 (e743b04) into main (76b43a4) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e743b04 differs from pull request most recent head bdb564a. Consider uploading reports for the commit bdb564a to get more accurate results

@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   63.56%   63.56%
=======================================
  Files          78       78
  Lines        3886     3886
  Branches      666      666
=======================================
  Hits         2470     2470
  Misses       1089     1089
  Partials      327      327

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Use correct syntax for brew installation

As per https://github.com/ericchiang/pup/issues/161#issuecomment-944005044

Duplicate of https://github.com/ericchiang/pup/pull/94


init-copy-website-2018-08-06

@chenopis  This PR is a translation initialization document request, thanks.

@markthink 👋 Can you please verify which branch in k/website you're copying from? Thanks in advance.

@zacharysarah  I think, in principle, it is copied directly from the master branch of the website, which requires a certain time interval, such as one month synchronization.

This is from k/website master to k-docs-zh master, so I think it's good.
/lgtm
/approve


[test-triage] chip_sw_entropy_src_csrng timed out

Hierarchy of regression failure
Chip Level
Failure Description
UVM_ERROR @ * us: (chip_sw_base_vseq.sv:223) virtual_sequencer [chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = * ns has 2 failures:

Test chip_sw_alert_handler_ping_timeout has 1 failures.

2.chip_sw_alert_handler_ping_timeout.3237703319
Line 484, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/2.chip_sw_alert_handler_ping_timeout/latest/run.log

  UVM_ERROR @ 12016.433331 us: (chip_sw_base_vseq.sv:223) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = 12000000 ns

  UVM_INFO @ 12016.433331 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---
Test chip_sw_entropy_src_csrng has 1 failures.

2.chip_sw_entropy_src_csrng.273037401
Line 479, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/2.chip_sw_entropy_src_csrng/latest/run.log

  UVM_ERROR @ 18022.531147 us: (chip_sw_base_vseq.sv:223) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = 18000000 ns

  UVM_INFO @ 18022.531147 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

Steps to Reproduce

Commit hash where failure was observed: c2a8c64cc
dvsim invocation command to reproduce the failure, inclusive of build and run seeds:
./util/dvsim/dvsim.py hw/top_earlgrey/dv/chip_sim_cfg.hjson -i chip_sw_base_vseq --fixed-seed 273037401 --build-seed<PHONE_NUMBER> --waves -v h
If dvsim invocation doesn't work - test name is chip_sw_entropy_src_csrng

Tests with similar or related failures

[ ] chip_sw_entropy_src_csrng
[ ] chip_sw_alert_handler_ping_timeout

Still seen this failure in chip_sw_alert_handler_ping_timeout with seed 713603959, build-seed<PHONE_NUMBER>, github revision https://github.com/lowrisc/opentitan/tree/84fdd3bf374f168367ba7ffcb07cfa4d79c54875

Unassigning as I'm not look at it.

this test appears to have been fixed by #15314 (also passing for past 3 nightlies)
Close down for now and see if nightly shows up again.


Pave the way for converting nRF devicetrees to use phandles for pinmuxing

RFC for now because of these questions:

what "flags" value should we use for I2C sda-gpios and scl-gpios? The driver ignores them, so I guess maybe documenting that and saying "just put 0" is right, even if it's a bit inconsistent with Linux's use of those properties for bit-banged I2C.
once we settle that, I need to convert all in-tree devicetrees to stop using the deprecated properties

Nordic SoC devices do their pinmuxing in devicetree using properties that look like foo-pin = <PSEL value>;, where a "PSEL value" is an integer that represents a GPIO (like P0.1, P1.2) to a bitmask with the lower 5 bits representing the pin (0-31), and the 6th bit representing the port (0 or 1).
This requires users to manually encode and decode pins to ints and vice versa.
This has two problems:

it confuses people who aren't familiar with the underlying register maps (which usually have registers that take the PSEL values directly)
it "hides" device dependencies on GPIO controllers, which may break automated tooling related to the devicetree, such as dependency tracking done for things like power management (#29644) or generating pin maps without special cases (https://github.com/zephyrproject-rtos/zephyr/pull/24132)

The same solution applies to both problems: use standard devicetree GPIO phandle and specifier, so you could say:
foo-gpios = <&gpio0 1 FLAGS>;   // P0.1

or
foo-gpios = <&gpio1 2 FLAGS>; // P1.2

This pull request makes that possible with backwards compatibility and sensible error messages from drivers that convert to the new style:

both foo-pin and foo-gpios are supported, but foo-pin can be deprecated
if both foo-pin and foo-gpios are given in a devicetree, the user gets a readable error message identifying the node and properties that need to be fixed
the same is true if neither foo-pin nor foo-gpios is given

This is shown using the I2C drivers. I tested this using a sensor driver with the new sda-gpios and scl-gpios properties on nRF52840-DK.

Once we get this out of RFC, I'll tack on more patches converting the other drivers and updating in-tree DTS files. My guess is this won't make 2.5 but I would like to get it into 2.6.

@anangl @galak do you have an opinion on this part?

what "flags" value should we use for I2C sda-gpios and scl-gpios? The driver ignores them, so I guess maybe documenting that and saying "just put 0" is right

If we agree on 0, I can keep going on this.

@anangl @galak do you have an opinion on this part?

what "flags" value should we use for I2C sda-gpios and scl-gpios? The driver ignores them, so I guess maybe documenting that and saying "just put 0" is right

If we agree on 0, I can keep going on this.

I think this field could be used for specifying if the driver should enable pull-ups for those pins or not (if external pull-ups are present). If I understood correctly, @pabigot mentioned such functionality in the Dev Meeting. The nrfx drivers for TWI and TWIM do not currently provide such option (to specify if pull-ups are to be enabled), but this could be added quite easily, without breaking those driver APIs. Before this option is added, it could be e.g. checked in the shims with a build assertion if GPIO_PULL_UP flags were specified (as currently those pull-ups are always enabled by the nrfx drivers).

If we agree on 0, I can keep going on this.

So from the generic I2C perspective my position is:

It's reasonable to allow 0 rather than suggest people should use GPIO_ACTIVE_whatever (which is not relevant in this use; the driver/peripheral will always control direction configuration, even when the pin is configured as a GPIO).  IMO it's wrong to suggest GPIO_PULL_UP (because in almost all cases the pull-up will be external and the GPIO peripheral pulls would not be configured).  0 should also be what gets synthesized if a -pin property is used.
But I think it's reasonable to allow GPIO_PULL_UP if the intent is to rely on SOC internal pull-ups to eliminate the need for external ones.  Electrically I think this is not always reliable good idea, but in some cases it can work.

IMO it's not the place of this devicetree change to specify how the Nordic driver will interpret flags that aren't zero: whether GPIO-configured pull ups even affect I2C signals might be SOC-specific.  If/when we decided to do examine those flags we could document the behavior, but that should be done in the context of examining all I2C drivers to see if Nordic is the only one where this is even relevant.
If we need to document something I'd say "The flags cell may be 0.  The behavior if the flags cell that is not 0 is not yet defined."

If we need to document something I'd say "The flags cell may be 0. The behavior if the flags cell that is not 0 is not yet defined."

I'm fine with making nonzero values undefined behavior. @galak / @anangl -- agreed?

Feels like some of the commits in here can be pulled out and merged.

OK, I've taken out the parts that aren't mergeable yet that demo this in the I2C drivers and just pushed the infrastructure.
Removed RFC and added 2.5 milestone. We do have a use case for this for Zephyr 2.5 (#30262) that will rebase on top once this is merged.
Please give it a real review if you can.

Feels like some of the commits in here can be pulled out and merged.

OK, I've taken out the parts that aren't mergeable yet that demo this in the I2C drivers and just pushed the infrastructure.
Removed RFC and added 2.5 milestone. We do have a use case for this for Zephyr 2.5 (#30262) that will rebase on top once this is merged.
Please give it a real review if you can.

I'd still rather see a bank property in the devicetree node to
provide the multiplier of 32 added to calculate the PSEL value, but
that's just personal preference.

OK, I'll leave this as-is to save us some extra properties in each SoC
.dtsi for now, unless someone else speaks up and I become outnumbered on
this.

If you make this actual values rather than symbols, e.g. <&gpio0 23 GPIO_ACTIVE_LOW> that may be more helpful. Otherwise or in addition I
think it's worth a comment saying that the flags value should almost
certainly be GPIO_ACTIVE_LOW unless intervening hardware inverts the
signal from what the peripheral expects.

Good ideas; both done.

I'd still rather see a bank property in the devicetree node to
provide the multiplier of 32 added to calculate the PSEL value, but
that's just personal preference.

OK, I'll leave this as-is to save us some extra properties in each SoC
.dtsi for now, unless someone else speaks up and I become outnumbered on
this.

If you make this actual values rather than symbols, e.g. <&gpio0 23 GPIO_ACTIVE_LOW> that may be more helpful. Otherwise or in addition I
think it's worth a comment saying that the flags value should almost
certainly be GPIO_ACTIVE_LOW unless intervening hardware inverts the
signal from what the peripheral expects.

Good ideas; both done.

@jfischer-no @anangl thanks for review. Comments addressed. The main changes are:

dropped DT_SAME_NODE
changed NRF_DT_CHECK_GPIO_CTLR_IS_SOC to use the compatible and removed obsolete private macros that used DT_SAME_NODE
made NRF_PSEL_OFFSET_HELPER a requirement for soc.h that is used by soc_nrf_common.h; hopefully this helps future-proof the implementation
each NRF_PSEL_OFFSET_HELPER now uses DT_REG_ADDR to distinguish nodes representing P0 from nodes representing P1
re-worked spi-controller.yaml comments

@jfischer-no @anangl thanks for review. Comments addressed. The main changes are:

dropped DT_SAME_NODE
changed NRF_DT_CHECK_GPIO_CTLR_IS_SOC to use the compatible and removed obsolete private macros that used DT_SAME_NODE
made NRF_PSEL_OFFSET_HELPER a requirement for soc.h that is used by soc_nrf_common.h; hopefully this helps future-proof the implementation
each NRF_PSEL_OFFSET_HELPER now uses DT_REG_ADDR to distinguish nodes representing P0 from nodes representing P1
re-worked spi-controller.yaml comments

@galak :

Feels like some of the commits in here can be pulled out and merged. Trying to look through and understand the need for the new DT APIs (DT_SAME_NODE) and (DT_NODE_PATH).

I dropped DT_SAME_NODE. The DT_NODE_PATH macro is just for making the error messages easier to read by including the 'real' paths to bad nodes.

Need to look at the binding stuff and use of FOO-gpios v pinctrl-N.

I'm using FOO-gpios in anticipation of supporting upstream bindings like sda-gpios and scl-gpios: https://github.com/torvalds/linux/blob/c912fd05fab97934e4cf579654d0dc4835b4758c/Documentation/devicetree/bindings/i2c/i2c.txt#L79

@galak :

Feels like some of the commits in here can be pulled out and merged. Trying to look through and understand the need for the new DT APIs (DT_SAME_NODE) and (DT_NODE_PATH).

I dropped DT_SAME_NODE. The DT_NODE_PATH macro is just for making the error messages easier to read by including the 'real' paths to bad nodes.

Need to look at the binding stuff and use of FOO-gpios v pinctrl-N.

I'm using FOO-gpios in anticipation of supporting upstream bindings like sda-gpios and scl-gpios: https://github.com/torvalds/linux/blob/c912fd05fab97934e4cf579654d0dc4835b4758c/Documentation/devicetree/bindings/i2c/i2c.txt#L79

@galak @jfischer-no gentlemen have you got something against merge of this PR?
I'm waiting with my PR: https://github.com/zephyrproject-rtos/zephyr/pull/30262 util this one is merged.

@galak @jfischer-no gentlemen have you got something against merge of this PR?
I'm waiting with my PR: https://github.com/zephyrproject-rtos/zephyr/pull/30262 util this one is merged.

Rebased to get through some unrelated compliance issues and cleaned up the commit logs.

Rebased to get through some unrelated compliance issues and cleaned up the commit logs.


Fix http & ws healthcheck

Flow Readiness & Healthchecks are performed by sending a request to the flow's /dry_run endpoint. Currently for http & ws this is send to protocol://host:port

Fixed in https://github.com/jina-ai/client-go/pull/10


Bugfix: github.com archive css issue

Describe the bug
Github archive issue
Steps to reproducem

Ran ArchiveBox on github.com page
CSS on wget clone doesn't seem to be working
Screenshot and pdf look fine

Screenshots or log output

Software versions

OS:                        Debian 10
ArchiveBox version:        7ec1e35
Python version:            Python 3.7.3
Chrome version:            Chromium 83.0.4103.116 built on Debian 10.4, running on Debian 10.4

Yeah this is just the result wget produces, it's a known thing and not a bug with ArchiveBox.
I recommend using the HTML dump, PDF, screenshot, or other methods for Github.


[vcpkg] 2024.07.12 Release Notes are referring to the wrong vcpkg-tool version

Describe the bug
The Release Notes for 2024.07.12 says that vcpkg-tool 2024-06-10 has been released since the last vcpkg release, but that's the same version the Release Notes for vcpkg 2024.06.15 mentioned. Also, the last commit in 2024.07.12 is https://github.com/microsoft/vcpkg/pull/39836, which pulls in vcpkg-tool 2024-07-10.
TLDR: vcpkg 2024.07.12 release notes has a typo in the vcpkg-tool version number, referring to 2024-06-10 instead of 2024-07-10.

Hello, I did not see the 2024-06-10 note in the release interface for 2024.07.12, as shown in the following image:

Seems like someone has already fixed it. Feel free to close this issue.


Allow file extension to be part of the unique snapshot check

Describe the bug
Verify acts in a strange way when there are two Verify calls with the same snapshot prefix but a different file extension. I was expecting file extension to be part of the "identity" of the snapshot file (as the file system would allow) but this appears to not be the case. The snapshot gets renamed based on whichever Verify(..., extension: "csv or json") goes last.
Apologies if this should be a feature request instead of a bug report. It feels buggy to me but that's perhaps just due to a bad expectation on my part.
I ran into this because I have a JSON file called ..._PackageReadmes.verified.json and a CSV called ..._PackageReadmes.verified.csv in the same test file. It ran into this problem.
Minimal Repro
namespace VerifyExt;

[UsesVerify]
public class Tests
{
    [Fact]
    public async Task MyTest()
    {
        VerifierSettings.AutoVerify();
        VerifierSettings.DisableRequireUniquePrefix();

        await Verify("foo", extension: "csv").UseTextForParameters("MyFoo");

        // 'Tests.MyTest_MyFoo.verified.csv' is on disk right now

        await Verify("bar", extension: "txt").UseTextForParameters("MyFoo");

        // Now it is 'Tests.MyTest_MyFoo.verified.txt'. The CSV is gone!
    }
}

Submit a PR that fixes the bug
TODO. I will work on this now. I think I will try adding an option IncludeExtensionInUniquePrefix to take the stance that this is by design instead of a bug. Let me know if that's the wrong direction.

can you instead use this approach>
[Fact]
public async Task MyTest()
{
    await Verify(new List<Target>
    {
        new("csv", "foo"),
        new("txt", "bar")
    });
}

I tried this in my test suite and face the same problem. It appears to be a race condition based on what happens before each Verify call. I had some async work reading from Azure Storage inside async helper methods that at the end call Verify.
There appears to be some sync setup in the Verify task. If any of this is interleaved then the behavior is inconsistent. I'll confirm this theory by switching the order of the Verify calls and the subsequent awaits.

Oh, I misread your suggestion (I saw that as the Task.WhenAll combination). This is not as easy to generalize with simple test helpers that collect some test output via async calls then at the end of the helper method call Verify. I guess this means I need to collect a bunch of Target instances in my tests and pass them all to a single Verify call at once. I'll go try.

Yes that works. This test I added in my PR then modified passes:
    [Fact]
    public async Task MultipleExtensions()
    {
        #region UniqueForFileExtension
        await Verify(new[]
        {
            new Target("txt", "the text"),
            new Target("xml", "b"),
        }).AutoVerify();
        #endregion
        Assert.True(File.Exists(CurrentFile.Relative($"Tests.{nameof(MultipleExtensions)}.verified.xml")), "The xml snapshot should exist.");
        Assert.True(File.Exists(CurrentFile.Relative($"Tests.{nameof(MultipleExtensions)}.verified.txt")), "The txt snapshot should exist.");
    }

I'll go give it a try in NuGet Insights and see how it shakes out with helper methods.

i usually push back on people using multiple Verify calls in the same test. since it means u often need to run the test multiple times to get all the snapshots to be created

I think it's a bit of a challenge for migration since you want to treat a verify call like an assert. And having multiple asserts per test is very common.

yeah usually that is mitigated by the fact that Verify supports anon objects. https://github.com/VerifyTests/Verify/blob/main/docs/anonymous-types.md

I tried out a flow where I have an AddTargetsAsync helper method that is called through an extended test. This collects Target instances in a List<Target> field. Then call Verify at the end on that list. This is to align with your recommendation of only having a single Verify call per test. This seems perhaps workable but had two problems:

We lose fail fast on the tests. If there is a <Step 1> then <Step 2> arrangement in the test, there are now no assertions at the end of <Step 1> and the <Step 1> failures now happen at the end of <Step 2> along with <Step 2> failures if any. We could perhaps break up <Step 1> and <Step 2> into multiple tests but this feels painful since we're basically duplicating the <Step 1> setup into another test just to run <Step 2> and losing the "narrative" of a longer, multi-step integration test.
It's not clear how to have an assertion at the end of <Step 2> that asserts that some data hasn't changed from a value produced by <Step 1>. It's like I want to say simultaneously want to say "Verify step 1 output hasn't changed and verify 2 output is the same as step 1" without storing two snapshots (since they are just duplicated in this case).

I felt like the approach I had before where I had multiple Verify calls spread throughout the test and/or test helpers was actually working more to my liking, I just had the file extension conflict issue. I think I might go back to that and just work around it by not using file extension to disambiguate a snapshot and add something to UseTextForParameters to make it work, if there's not a desire to let file extension be part of the uniqueness of a snapshot.

@SimonCropp

can you instead use this approach>
[Fact]
public async Task MyTest()
{
    await Verify(new List<Target>
    {
        new("csv", "foo"),
        new("txt", "bar")
    });
}

How could you use that approach when one of the snapshots is JSON (for which you'd normally use VerifyJson) and the other is not?

This should very much be allowed. Surprised to find out it isn't.

@aradalvand please share a minimal repo of what you want to achieve in a GH repository

closing this one. I suggest instead you submit a PR that meets your requirements with a single Verify call


New Game! -The Challenge Stage!-Chinese Version [PCSH10101]

App summary

App name: New Game! -The Challenge Stage!-中文版
App serial: PCSH10101
App version: 1.00

Vita3K summary

Version: v0.1.3
Build number: 2256
Commit hash: https://github.com/vita3k/vita3k/commit/3b7410b
CPU backend: Dynarmic.

Test environment summary

Tested by: qc
OS: Windows 11
CPU: INTEL i5 4460
GPU:  NVIDIA GeForce GT 610
RAM: 12 GB

Issues
The game enters normally but there is no text，The screen flickers after switching scenes，The game has no audio output，Crash after running for a while。
Screenshots

Log
vita3k.log
Recommended labels

screen flashing
graphics bug
crash

The label is wrong.
I can save, load and play the game, but I cant see text in this game.
so It should be labelled in "ingame+"
@sunho

you have missing installed firmware font package

you have missing installed firmware font package

The Japanese version of the font display is normal, the Chinese version does not work

you have missing installed firmware font package

The Japanese version of the font display is normal, the Chinese version does not work

Oh yes no view is asia version, strange

hi i have the same problem there is no text in this game how to fix this? the prev comment say it should install something but where to install that? can someone help me.


Fix video sharing

Details

This PR reenables video sharing feature. With these changes videos from inside the chat will be sharing their state with the player that is inside the attachment carousel.
Fixed Issues

$ https://github.com/Expensify/App/issues/36873
PROPOSAL: https://github.com/Expensify/App/issues/36873#issuecomment-1963964585
Tests

Button linking:

Go to prerequisite chat
Play&Pause the video
Tap on the expand button on the video preview
Verify if video player showed there have the same state as the on from chat
Play&Pause the video
Exit from the attachment view via clicking X button top right
Try to Play&Pause the video in preview mode

Window dimension changing:
Web & desktop:

Open video in attachment carousel
Make your app widow smaller
Enter full screen
Exit fullscreen
Verify if video continue playing

Native devices:

Open video in attachment carousel
Enter full screen
Change device orientation
Exit fullscreen
Verify if video continue playing and if app changed layout

[X] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@ishpaul777 resolved!

Bug: there's a loading indicator and video restarts when changing windowsize after a breakpoint in attachment carousel

I don't think it is a bug. Video reloads when changing window size and hitting breakpoint because on small screens in-chat video player ins't available and we can't share video element that don't exit. So it like natural behaviour because we have to stop sharing video element and render separate player directly inside attachment carousel

Bug?: it takes few second to play video when video timing is backed (it seems it redownloads the video everytime)

Hmm, I think is not related to this PR. The same thing appears on main and probably that how native android player works. It can be connected how our backend returns video to our app. It accepts video ranges and probably Android native video player doesn't load entire file, only parts of it. After some time cached parts of the video are removed.
I will investigate this issue more, however it should block this PR, since it is not connected to it

@ishpaul777 I've added review changes and answered to you comments, let me know what do you think :D

@ishpaul777 I resolved conflicts

Okay, no problem. Thanks

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Not an emergency, reviewer has completed all the checklist boxes. Removing label.

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


ARROW-7570: [Java] Fix high severity issues

Fixes two high severity issues reported by LGTM: https://lgtm.com/projects/g/apache/arrow/?mode=list&lang=java&severity=error

Yes, there is a LGTM plugin available for Github. Apache Druid is using this.


refactor: separate DeclareV2::new_with_sierra_class_hash

Create a new method for passing the Sierra class hash to the DeclareV2 constructor.
This is done for two reasons:

It avoids unnecessary breakage
Makes the error prone usage explicit and opt-in, as passing the wrong hash would result in incorrect behavior

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #807 (d39749e) into main (dce8b59) will decrease coverage by 0.08%.
The diff coverage is 31.74%.

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   91.77%   91.70%   -0.08%
==========================================
  Files          52       52
  Lines       12297    12346      +49
==========================================
+ Hits        11286    11322      +36
- Misses       1011     1024      +13

Impacted Files
Coverage Δ

src/transaction/declare_v2.rs
74.05% <31.74%> (-1.44%)
:arrow_down:

... and 8 files with indirect coverage changes


fix: Use logging facilities to report summary

Dumping summaries to stderr may disturb users of the lib. There's no sensible way to turn off such messages. The patch redirects summaries to the existing logging functions which can be controlled by users.

Thanks!
I had to change your modifications so the # of errors/warnings were reported at the INFO level. Otherwise, they would increment the number of reported errors/warnings.
I also moved the PR to the development branch.


Dataset Viewer issue for phamson02/vietnamese-poetry-corpus

Link
https://huggingface.co/datasets/phamson02/vietnamese-poetry-corpus
Description
The dataset viewer is not working for dataset phamson02/vietnamese-poetry-corpus.
Error details:
Error code:   ConfigNamesError
Exception:    OSError
Message:      [Errno 116] Stale file handle
Traceback:    Traceback (most recent call last):
                File "/src/services/worker/src/worker/job_runners/dataset/config_names.py", line 61, in compute_config_names_response
                  for config in sorted(get_dataset_config_names(path=dataset, use_auth_token=use_auth_token))
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/inspect.py", line 323, in get_dataset_config_names
                  dataset_module = dataset_module_factory(
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 1219, in dataset_module_factory
                  raise e1 from None
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 1196, in dataset_module_factory
                  return HubDatasetModuleFactoryWithoutScript(
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/load.py", line 829, in get_module
                  dataset_readme_path = cached_path(
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/utils/file_utils.py", line 183, in cached_path
                  output_path = get_from_cache(
                File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/utils/file_utils.py", line 611, in get_from_cache
                  http_get(
                File "/usr/local/lib/python3.9/tempfile.py", line 496, in __exit__
                  result = self.file.__exit__(exc, value, tb)
              OSError: [Errno 116] Stale file handle

Thanks for reporting, @phamson02.
I have forced the refresh of the viewer and it is fixed now:


const / variable often named "appd" or "appdynamics". Should named "otel" or "opentelemetry" or "otel_web_sdk"

Describe your environment
Many of the variables in this project are named like "appd_you_name_it" or "appdynamics_you_name_it".
Steps to reproduce
Describe exactly how to reproduce the error. Include a code sample if applicable.
What is the expected behavior?
Should named "otel" or "opentelemetry" or "otel_web_sdk"
What is the actual behavior?
What did you see instead?
Additional context
Add any other context about the problem here.

Thanks for raising this, we will take this up.


Terraform module versions with 'v' prefix

Package ecosystem
terraform
Language version
Terraform v1.0.5
dependabot.yml content
version: 2
registries:
  terraform-cloud:
    type: terraform-registry
    url: https://app.terraform.io
    token: ${{secrets.TERRAFORM_API_TOKEN}}

updates:
  - package-ecosystem: "terraform"
    registries:
      - terraform-cloud
    directory: "/"
    target-branch: "release"
    labels:
      - "terraform"
    schedule:
      interval: "daily"

Description
Terraform registry allows for semantic version, which can optionally be prefixed with a v.
Dependabot throws a BadRequirementError when module versions are prefixed with a v. The full error:
Steps to reproduce

set requirement_string to v1.0.0 in terraform/spec/dependabot/terraform/requirement_spec.rb
run bundle exec rspec spec
output looks like:

Randomized with seed 59800
....................................................F........................................................................................................................

Failures:

  1) Dependabot::Terraform::Requirement.new
     Failure/Error: raise BadRequirementError, msg

     Gem::Requirement::BadRequirementError:
       Illformed requirement ["v1.0.0"]
     # ./lib/dependabot/terraform/requirement.rb:15:in `parse'
     # ./lib/dependabot/terraform/requirement.rb:37:in `initialize'
     # ./spec/dependabot/terraform/requirement_spec.rb:7:in `new'
     # ./spec/dependabot/terraform/requirement_spec.rb:7:in `block (2 levels) in <top (required)>'
     # ./spec/dependabot/terraform/requirement_spec.rb:11:in `block (3 levels) in <top (required)>'
     # /home/declan/Documents/repo/projects/dependabot-core/common/spec/spec_helper.rb:49:in `block (2 levels) in <top (required)>'
     # /var/lib/gems/2.7.0/gems/webmock-3.14.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

Finished in 32.72 seconds (files took 0.56344 seconds to load)
173 examples, 1 failure

Failed examples:

rspec ./spec/dependabot/terraform/requirement_spec.rb:11 # Dependabot::Terraform::Requirement.new

Randomized with seed 59800

Should be addressed by https://github.com/dependabot/dependabot-core/pull/4191


Subdomains with capybara-webkit?

With this in my /etc/hosts file:
<IP_ADDRESS> localhost local.host www.local.host blog.local.host wiki.local.host mobile.local.host

... I can use the app locally by going to urls like http://wiki.local.host:3000/overview.
Is there any way I can do this with capybara + capybara-webkit with rspec 2 in rails (without cucumber)?  I am using capybara 1.0.
I have tried the suggestions here but none of them work:

http://jamesalmond.posterous.com/testing-subdomains-using-capybara
http://rorn00b.blogspot.com/2010/06/cucumber-and-subdomains-revisited.html
http://www.jeffroush.com/technotes/2011/03/19/navigating-subdomains-with-capybara/
http://forrst.com/posts/Testing_Subdomains_in_Capybara-g4M
http://groups.google.com/group/ruby-capybara/browse_thread/thread/50552c9d3e6ece61/ca98c140ee019037?#ca98c140ee019037

If I am using the default rack-test driver, everything works fine:
# spec/spec_helper.rb
Capybara.app_host = "http://wiki.local.host:3000"

# spec/wiki_spec.rb
require 'spec_helper.rb'

feature "Wiki" do
  context "GET" do
    scenario "home page" do
      visit "/"
      page.should have_title "Overview"
    end
  end
end

But if I add :js => true, it doesn't work:
# spec/spec_helper.rb
Capybara.app_host  = "http://wiki.local.host:3000"
Capybara.javascript_driver = :webkit

# spec/wiki_spec.rb
require 'spec_helper.rb'

feature "Wiki" do
  context "GET" do
    scenario "home page", :js => true do
      visit "/"

      # Capybara::Driver::Webkit::WebkitError:
      #  Unable to load URL: http://wiki.local.host:3000/

      page.should have_title "Overview"
    end
  end
end

Any ideas?

echoing @bradrobertson, I had the same error and also found the problem was a page with an exception. It took me hours of picking away at the page view to track down the problem. it would be great if capybara-webkit could give more info than just the cryptic "unable to load URL" error.
The clue for me to figuring this out was realizing that only one page wasn't loading, while the others were.


Conflict with latest Comfy GUI update

Hello!
I accidentally updated to the latest ComfyUI GUI https://blog.comfy.org/comfyui-v0-3-0-release/ and noticed suddenly my workflows wouldn't display correctly—they were being loaded and my menu/settings worked, but the actual nodes/nodes wouldn't display correctly.
I was able to confirm this node was the culprit after disabling all of my nodes and slowly reenabling them and testing my ComfyUI.
I'm not complaining, love the node, but wanted to share this info. I'd rather rollback my ComfyUI update (running on the cloud via Paperspace) but I don't exactly know how... so for now I'll just disable the node.

FYI, you can rollback in the setting in your Comfy frontend.
Also I was able to reproduce this issue and the trace came out to be related to Comfy Easy Use's extension javascript
Can you also check if the you have Comfy Easy Use installed.

Have you got the latest version of UE?

Have you got the latest version of UE? This looks very like an issue that was fairly recently fixed...
I'll look into it when I have a moment!

I believe so! I just did a git pull and it says it's the latest. No rush at all, and it might be something I'm doing wrong too. Thanks!

OK - I've got the latest version up now and can't reproduce the problem. So may be a conflict with another custom node (maybe to one @yoland68 mentioned)

OK - I've got the latest version up now and can't reproduce the problem. So may be a conflict with another custom node (maybe to one @yoland68 mentioned)

Thank you for taking a look and sorry for taking up your time! As he noted, it was indeed a conflict with that other node; Use Everywhere works normally after I disabled it. All good now, I think!


[RESTEASY-2685] Merge client headers with MP REST Client

Sorry, was on PTO for a bit, I've now added a test

@ronsigal @asoldano Is this good now?


[Bug] The new color schemes are too dark

Is your feature request related to a problem? Please describe.
After the 3.0 update dark color schemes the background is darker than it was earlier and the interface text lacks the needed contrast.
Describe the solution you'd like
Old colorschemes were really good, would be nice to bring them back.
Describe alternatives you've considered
I considered editing the background colors myself, but the css is too big, and I can't figure it out. Also all the colors seem to be the same?
Additional context
Here are the screenshots of Prism 2.x and 3.x. I think it's not just the layout, the background colors are definitely different.

Hi @lsvy97,
The layout changes are how they should be since Prism 3.0.0 was rewritten from scratch to accommodate the changes made to the default theme when Obsidian 1.0.0 released. This brought along a change in style to the current more simplistic one.
As for the colours and contrast, I do agree that the current dark themes are a little too dark and I do intend on working on it in the new year. Probably will be the next major update. Thanks for reporting!

Good to know! Keep up the great work! 👍

Hi @lsvy97,
I've completely reworked the colour schemes in the new Prism 3.3.0 update. Should be a lot better for Dark Colour Schemes. Not exactly as grey as before though. If you want you can make your own Colour Scheme by following this guide: https://github.com/damiankorcz/Prism-Theme/wiki/Creating-a-Custom-Colour-Scheme-CSS-Snippet

Thank you. For curiosity, I checked it with a colorpicker and the color is literally the same now.


Mismatch in weights and features?

I'm getting the following error running the suggested moses command:
FATAL ERROR: Mismatch in number of features and number of weights for Feature Function OpSequenceModel0 (features: 5 vs. weights: 1)
The full log is below. Is there anything I need to do other than fix the paths in the ini files?
Defined parameters (per moses.ini or switch):
	config: moses.sparse.mert.avg.ini`
	distortion-limit: 1
	feature: CorrectionPattern factor=0 context=1 context-factor=1 CorrectionPattern factor=1 OpSequenceModel path=/home/baselines-emnlp2016/models/data/osm.kenlm input-factor=0 output-factor=0 support-features=no EditOps scores=dis Generation name=Generation0 num-features=0 input-factor=0 output-factor=1 path=/home/baselines-emnlp2016/wikilm/wiki.classes.gz UnknownWordPenalty WordPenalty PhrasePenalty PhraseDictionaryMemory name=TranslationModel0 num-features=4 path=/home/baselines-emnlp2016/models/sparse/phrase-table.0-0.gz input-factor=0 output-factor=0 KENLM lazyken=0 name=LM0 factor=0 path=/home/baselines-emnlp2016/models/data/lm.cor.kenlm order=5 KENLM lazyken=0 name=LM1 factor=0 path=/home/baselines-emnlp2016/wikilm/wiki.blm order=5 KENLM lazyken=0 name=LM2 factor=1 path=/home/baselines-emnlp2016/wikilm/wiki.wclm.kenlm order=9
	input-factors: 0 1
	mapping: 0 T 0 0 G 0
	search-algorithm: 1
	weight: OpSequenceModel0= 0.056400116 EditOps0= 0.089810909 0.055824475 0.251698374 UnknownWordPenalty0= 0.000000000 WordPenalty0= 0.033986809 PhrasePenalty0= 0.213073353 TranslationModel0= 0.053263575 0.079491017 0.050398784 -0.002760660 LM0= 0.030412285 LM1= 0.059879919 LM2= 0.022263916
	weight-file: /home/baselines-emnlp2016/models/sparse/moses.wiki.sparse
line=CorrectionPattern factor=0 context=1 context-factor=1
Initializing correction pattern feature..
FeatureFunction: CorrectionPattern0 start: 0 end:<PHONE_NUMBER>3709551615
line=CorrectionPattern factor=1
Initializing correction pattern feature..
FeatureFunction: CorrectionPattern1 start: 0 end:<PHONE_NUMBER>3709551615
line=OpSequenceModel path=/home/baselines-emnlp2016/models/data/osm.kenlm input-factor=0 output-factor=0 support-features=no
FeatureFunction: OpSequenceModel0 start: 0 end: 4
Exception: moses/FF/Factory.cpp:191 in static void Moses::FeatureFactory::DefaultSetup(F*) [with F = Moses::OpSequenceModel] threw util::Exception because `weights.size() != feature->GetNumScoreComponents()'.
FATAL ERROR: Mismatch in number of features and number of weights for Feature Function OpSequenceModel0 (features: 5 vs. weights: 1)

Could you add the feature-value pair num-features=1 to the line of the OSM model in the ini and report back if that helps? If yes we will update the ini-files accordingly.

Yes, that seems to have fixed it! Thanks!

Great, thanks for reporting back.
@snukky , can you update the ini-files as discussed above?

Fixed.


Translation 🇧🇬 🇩🇪 🇺🇸 🇫🇷 🌎 😀

Allow for translation. The primary goal of this issue to have the Android app translated but better have the ability to translate everything.
My humble suggestion for translating platform would be Hosted Weblate to match the Open Source nature of the project. Weblate is a home for many well known open source projects like F-Droid, OsmAnd~, KOreader, DAVx5, Tasks.org, AndrOBD, Minetest, Orbot, and many, many others.
Aside from Weblate there are several other closed source platforms that sponsor open source projects. To name a few that I know of: Crowdin and Transifex.

Thanks for the ticket. I like the idea. The Android app should be easily translatable, since it's all in a strings.xml file. The web app would be a little harder, since I have to pull out the strings, and the CLI I don't think I'd want to translate. That's typically not done anyway, right?

Great to hear that!

That's typically not done anyway, right?

I'd say it's totally up to you. Whole Linux distros are translated, CLI included, but let's focus on the low-hanging fruit for now. Like you said the Android app seems like a good start.
Did you decided on a translation service?

I registered at https://hosted.weblate.org/ but couldn't add a project. Says I don't have permission. Are you sure I can just add my project there, and that I don't have to self-host this tool?

I'm sure you can add project at hosted.wablate.org. You may see the docs. Although I'm not aware of the new profile limitations. I'll ask the support and get back to you.

I think I found it. Sorry. It requested a "libre" project now. It'll be reviewed I think. Now I have to figure out how it works.

Ah, good to know. The process it's little cryptic I must admit.

Still working through it. I set up a project https://hosted.weblate.org/projects/ntfy/, added the Android app as a component and started translating a few strings to test. I have no idea how they are going to get back into the app or the repo. Still looking :eyes:

Okay. That was exceptionally easy. I suppose now I have to grant users access to translate stuff? And write some docs on how to get started?
I also have questions around what happens when I fundamentally change a string or the meaning of it. Is it best to make a new string and remove the old? I guess I'll find that out as I go along.

I didn't set up auto-push because that scares me a little. I'd love to just have regular pull requests (maybe every 3 days or so) automatically by weblate, but I'm not sure if that's possible.

I added it to the README.md which I think should be enough for now. And it looks like it's pretty easy to add languages.
If the English phrases are weird or there is obviously not enough space for phrases in your language, please let me know I can obviously change the app to make more room.
I'll close this ticket for now and create one for the React app, which I have to put much more work in first.
Thank you for your contribution!!!

I almost forgot, we can also directly chat in Discord if you like: https://discord.com/invite/cT7ECsZj9w


Update log message to public level

The current log will be <private> to end user unless the user is debugging on it.
And it makes the log message of SourceKit a bit of useless.

Inspired by digging the original issue https://github.com/apple/swift/issues/62274#issuecomment-1337940045

I think we could improve the logger method to add public modifier
os_log("%{public}@", log: xx, type: .info, xx) // If we use old API
Logger().info("\(xx, privacy: .public)") // If we can drop macOS 10.15- Support to use new API

rdar://102990224

I agree that the current situation is not ideal.
But I think the tricky bit is that the log message might contain potentially privacy-sensitive information that we don’t want to log, so marking the entire opaque string is not an option IMO. So each log call would need to decide which information it wants to mark as public and private.

I redesigned the logging infrastructure in https://github.com/apple/sourcekit-lsp/pull/859 and now log calls can specify which parts should be public and which ones should be private. All log calls should now log some public information.

I redesigned the logging infrastructure in #859 and now log calls can specify which parts should be public and which ones should be private. All log calls should now log some public information.

I see it was merged into main. Is there a plan to cherry-pick it to release/5.10?

That refactoring is quite an invasive change to the entire codebase and I don’t plan to cherry-pick it to release/5.10 which doesn’t contain any of the commits that the PR relies on.


Defer hashing in staged ledger diff application

Problem: when performing transaction application, all merkle ledger hashes are recomputed for every account update. This is wasteful for a number of reasons:

Transactions normally contain more than one account update and a hash computed for an account update is sometimes overwritten by a subsequent account update
Ledger's depth is 35, whereas only around 2^18 records are actually populated. This means that each account update induces an overhead of at least 17 hashes (most of these wasteful)
When an account is touched in a few transactions of the same block, it's gets hashed a few times, whereas in fact only the final hash is truly needed

Solution: defer computation of hashes in mask. When an account is added, it's stacked in a list unhashed_accounts of masks which is processed at the time of next access to hashes.
This fix improved performance of handling 9-account-update transactions by ~60% (measured by #14582 on top of #15979 and #15978).
Explain how you tested your changes:

[x] Measured performance with #14582

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

!ci-build-me

!ci-build-me


Use mattermost-server/v6

Summary
This PR updates the dependency on github.com/mattermost/mattermost-server from v5 to v6. This ensures the v6 breaking changes propagate quickly to developers using this plugin.
Please note that the plugin still works against v5 servers.
Ticket Link
None

Codecov Report

Merging #32 (d4ec616) into master (b8a08fc) will decrease coverage by 0.02%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   21.49%   21.46%   -0.03%
==========================================
  Files          10       10
  Lines         777      778       +1
==========================================
  Hits          167      167
- Misses        603      604       +1
  Partials        7        7

Impacted Files
Coverage Δ

server/command.go
20.77% <0.00%> (ø)

server/handlers.go
5.09% <ø> (ø)

server/main.go
0.00% <ø> (ø)

server/plugin.go
0.00% <0.00%> (ø)

server/report.go
0.00% <ø> (ø)

server/watcher.go
20.93% <0.00%> (ø)

server/manifest.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a08fc...d4ec616. Read the comment docs.

Let's test this PR as part of release testing.


clstm.pb.h

is being requested by the compiler but isn't in the source tree ?

I encountered the same problem, and I compiled the clstm.proto manually with the following command.
protoc clstm.proto --cpp_out=.

The problem was that the build rule only had one target, but protoc generates two. I think I have fixed that now.


cmd/cue: eval -i -c does not include error reported by eval -c

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20230412103328-9db1b95606c3

go version go1.20
      -buildmode exe
       -compiler gc
     CGO_ENABLED 1
          GOARCH arm64
            GOOS linux
             vcs git
    vcs.revision 9db1b95606c3d393aafebe3eb159855e3790011c
        vcs.time 2023-04-12T10:33:28Z
    vcs.modified false

Does this issue reproduce with the latest release?
Yes
What did you do?
exec cue eval -i -c x.cue
cmp stdout stdout.golden

-- x.cue --
x: 200
x: y + 100
y: x - 100

// If a cycle is not broken, CUE will just report it.
a: b + 100
b: a - 100
-- stdout.golden --
x: 200
y: 100
a: _|_ // a: cycle error
b: _|_ // b: cycle error

What did you expect to see?
Passing test, modulo some variation in the error-comments against fields a and b in stdout.golden.
What did you see instead?
> exec cue eval -i -c x.cue
[stdout]
x: 200
y: 100
a: b + 100
b: a - 100
> cmp stdout stdout.golden
--- stdout
+++ stdout.golden
@@ -1,4 +1,4 @@
 x: 200
 y: 100
-a: b + 100
-b: a - 100
+a: _|_ // a: cycle detected
+b: _|_ // b: cycle detected

FAIL: /tmp/testscript2588338441/repro.txtar/script.txtar:2: stdout and stdout.golden differ

i.e. the use of -i with -c causes a and b to not be shown in error.
Just to confirm, however, that the use of -c should report an error here. Indeed dropping -i confirms as much:
> exec cue eval -c x.cue
[stderr]
cycle error:
    ./x.cue:6:4

The impact here is that https://cuelang.org/docs/tutorials/tour/references/cycle/ is wrong, following the merge of https://review.gerrithub.io/c/cue-lang/cue/+/552601

Marking as triage to bisect.


Adds command spo file sharinglink clear

Closes #4028
I noticed that we reused so much code over multiple files that I couldn't resist myself and create a class for this... If I need to seperate this from this issue and include it in a different PR, feel free to ask.

Great work @MathijsVerbeeck, I'll try to review it ASAP!

@MathijsVerbeeck looks like there are some conflicts. Could you take a look at them 😄

@MathijsVerbeeck looks like there are some conflicts. Could you take a look at them 😄

That has been resolved!

BTW: I also added the short option for --scope as suggested by Martin

Manually merged, thank you a lot for adding this to the CLI! 👏