HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)…

… with builder pattern

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  3s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 134 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 21s
master passed

+1 :green_heart:
compile
4m 41s
master passed

+1 :green_heart:
checkstyle
4m 24s
master passed

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 13s
master passed

+0 :ok:
spotbugs
2m 26s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
12m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 44s
the patch passed

+1 :green_heart:
compile
6m 50s
the patch passed

+1 :green_heart:
javac
6m 50s
the patch passed

+1 :green_heart:
checkstyle
0m 45s
hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98)

-1 :x:
checkstyle
2m 18s
hbase-server: The patch generated 28 new + 947 unchanged - 26 fixed = 975 total (was 973)

+1 :green_heart:
checkstyle
0m 28s
hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)

-1 :x:
checkstyle
0m 56s
hbase-thrift: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
checkstyle
0m 19s
The patch passed checkstyle in hbase-endpoint

-1 :x:
checkstyle
0m 24s
hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
checkstyle
0m 26s
hbase-it: The patch generated 1 new + 128 unchanged - 1 fixed = 129 total (was 129)

-1 :x:
checkstyle
0m 25s
hbase-rest: The patch generated 3 new + 108 unchanged - 0 fixed = 111 total (was 108)

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-shaded-client-project

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
24m 56s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
javadoc
0m 37s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
findbugs
11m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s
hbase-client in the patch passed.

+1 :green_heart:
unit
62m  7s
hbase-server in the patch passed.

-1 :x:
unit
6m 32s
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
2m 26s
hbase-thrift in the patch passed.

-1 :x:
unit
3m 29s
hbase-endpoint in the patch failed.

+1 :green_heart:
unit
7m 29s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 47s
hbase-rest in the patch passed.

+1 :green_heart:
unit
1m  6s
hbase-shaded-client-project in the patch passed.

+1 :green_heart:
asflicense
5m  0s
The patch does not generate ASF License warnings.

209m  9s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestSyncTable

hadoop.hbase.coprocessor.TestCoprocessorEndpoint

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1222

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b4f22f2eacc2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh

git revision
master / 3c3aae9a2f

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-thrift.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-backup.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-it.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-checkstyle-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/artifact/out/patch-unit-hbase-endpoint.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/testReport/

Max. process+thread count
9653 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 134 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 38s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 34s
master passed

+1 :green_heart:
compile
4m 43s
master passed

+1 :green_heart:
checkstyle
4m 35s
master passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 18s
master passed

+0 :ok:
spotbugs
1m 31s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  1s
the patch passed

+1 :green_heart:
compile
4m 45s
the patch passed

+1 :green_heart:
javac
4m 45s
the patch passed

+1 :green_heart:
checkstyle
0m 33s
hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98)

+1 :green_heart:
checkstyle
1m 31s
hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973)

+1 :green_heart:
checkstyle
0m 22s
hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)

+1 :green_heart:
checkstyle
0m 38s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-endpoint

+1 :green_heart:
checkstyle
0m 16s
The patch passed checkstyle in hbase-backup

+1 :green_heart:
checkstyle
0m 21s
hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129)

+1 :green_heart:
checkstyle
0m 21s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
checkstyle
0m 13s
The patch passed checkstyle in hbase-shaded-client-project

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
16m 13s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
3m 12s
the patch passed

+1 :green_heart:
findbugs
11m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 54s
hbase-client in the patch passed.

+1 :green_heart:
unit
62m 34s
hbase-server in the patch passed.

+1 :green_heart:
unit
6m 51s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 27s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 27s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
7m 29s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m 16s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 47s
hbase-rest in the patch passed.

+1 :green_heart:
unit
1m  6s
hbase-shaded-client-project in the patch passed.

+1 :green_heart:
asflicense
4m 58s
The patch does not generate ASF License warnings.

188m 18s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1222

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 16301fb45f9b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh

git revision
master / b24ea32b3b

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/testReport/

Max. process+thread count
9592 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  3s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 134 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 22s
master passed

+1 :green_heart:
compile
4m 44s
master passed

+1 :green_heart:
checkstyle
4m 34s
master passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 20s
master passed

+0 :ok:
spotbugs
1m 30s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m 37s
master passed

-0 :warning:
patch
2m 42s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  8s
the patch passed

+1 :green_heart:
compile
4m 53s
the patch passed

+1 :green_heart:
javac
4m 53s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98)

+1 :green_heart:
checkstyle
1m 33s
hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973)

+1 :green_heart:
checkstyle
0m 22s
hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)

+1 :green_heart:
checkstyle
0m 44s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-endpoint

+1 :green_heart:
checkstyle
0m 16s
The patch passed checkstyle in hbase-backup

+1 :green_heart:
checkstyle
0m 22s
hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129)

+1 :green_heart:
checkstyle
0m 20s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
checkstyle
0m 13s
The patch passed checkstyle in hbase-shaded-client-project

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 57s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
3m 18s
the patch passed

+1 :green_heart:
findbugs
11m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s
hbase-client in the patch passed.

-1 :x:
unit
62m 12s
hbase-server in the patch failed.

-1 :x:
unit
6m 50s
hbase-mapreduce in the patch failed.

-1 :x:
unit
14m  1s
hbase-thrift in the patch failed.

+1 :green_heart:
unit
3m 26s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
7m 34s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m 12s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 46s
hbase-rest in the patch passed.

+1 :green_heart:
unit
1m  6s
hbase-shaded-client-project in the patch passed.

+1 :green_heart:
asflicense
5m  3s
The patch does not generate ASF License warnings.

199m 48s

Reason
Tests

Failed junit tests
hadoop.hbase.wal.TestWALSplit

hadoop.hbase.mapreduce.TestTableInputFormatScanEmptyToEmpty

hadoop.hbase.thrift2.TestThriftHBaseServiceHandler

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1222

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d30e4b5d05cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh

git revision
master / a420f0482e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-mapreduce.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/artifact/out/patch-unit-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/testReport/

Max. process+thread count
9555 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Test failures in the latest QA results are not relevant

@HorizonNet I have addressed comments. Could you please take a look?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 134 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 48s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 21s
master passed

+1 :green_heart:
compile
4m 42s
master passed

+1 :green_heart:
checkstyle
4m 39s
master passed

+1 :green_heart:
shadedjars
4m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 25s
master passed

+0 :ok:
spotbugs
1m 44s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
11m 33s
master passed

-0 :warning:
patch
2m 55s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 32s
the patch passed

+1 :green_heart:
compile
4m 59s
the patch passed

+1 :green_heart:
javac
4m 59s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
hbase-client: The patch generated 0 new + 94 unchanged - 4 fixed = 94 total (was 98)

+1 :green_heart:
checkstyle
1m 34s
hbase-server: The patch generated 0 new + 929 unchanged - 44 fixed = 929 total (was 973)

+1 :green_heart:
checkstyle
0m 22s
hbase-mapreduce: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)

+1 :green_heart:
checkstyle
0m 37s
The patch passed checkstyle in hbase-thrift

+1 :green_heart:
checkstyle
0m 15s
The patch passed checkstyle in hbase-endpoint

+1 :green_heart:
checkstyle
0m 16s
The patch passed checkstyle in hbase-backup

+1 :green_heart:
checkstyle
0m 21s
hbase-it: The patch generated 0 new + 128 unchanged - 1 fixed = 128 total (was 129)

+1 :green_heart:
checkstyle
0m 21s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
checkstyle
0m 13s
The patch passed checkstyle in hbase-shaded-client-project

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 53s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
3m 17s
the patch passed

+1 :green_heart:
findbugs
11m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s
hbase-client in the patch passed.

+1 :green_heart:
unit
61m  3s
hbase-server in the patch passed.

+1 :green_heart:
unit
6m 50s
hbase-mapreduce in the patch passed.

+1 :green_heart:
unit
2m 25s
hbase-thrift in the patch passed.

+1 :green_heart:
unit
3m 25s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
7m 30s
hbase-backup in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-it in the patch passed.

+1 :green_heart:
unit
2m 46s
hbase-rest in the patch passed.

+1 :green_heart:
unit
1m  7s
hbase-shaded-client-project in the patch passed.

+1 :green_heart:
asflicense
5m  0s
The patch does not generate ASF License warnings.

188m 33s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1222

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 1bc591059806 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1222/out/precommit/personality/provided.sh

git revision
master / 48a3ccf523

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/testReport/

Max. process+thread count
9727 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup hbase-it hbase-rest hbase-archetypes/hbase-shaded-client-project U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1222/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@HorizonNet Does it look good to you with latest QA results?

Thanks for the review @HorizonNet


added timer

added time left/time elapsed display in static position on screen under refcount

implemented, thanks


Support $raw in sendToClient, sendToCurrentClient, sendToUid

Fix typo
Support $raw in sendToClient, sendToCurrentClient, sendToUid

Thanks.


Add EntityWriter

I'm thinking about adding the EntityWriter class.
Do you think this will be useful?
Should there be a separate interface for this? (EntityWriterInterface implements DataWriterinterface)

Should make syntax a bit better. I'm fine with having it.


continuous become discrete when using umap_reduce

https://github.com/GenoML/genoml2/blob/8040f2b1b460cc6085527e5fd65963518459cd11/genoml/__main__.py#L92
When running continuous supervised munge, there is a bug that claims it is discrete, and maybe it is. But clearly, this handler initiates the issue.
Also, there is never a prompt asking whether I have cofounders, like it looks like there should be elsewhere in the code. It continues without an error anyway. Are they necessary?

Hi @njohnso6 - all code under "continuous" is currently under active development, only the discrete supervised modules have been extensively built out at this time (as indicated in the README).
Thank you for flagging this and the other issues!


Enhancement: Plot Multiple Columns/Sensors

It would be nice to be able to specify multiple columns in the value_index option of a sensor; this would produce multiple lines on the single subplot. Also, if an "aggregate" sensor (e.g., sum or difference of real sensor values) could be plotted in a subplot, that would also be nice. E.g.,
[sensor.total]
port=aggregated
label=Total Weight
sensors=sensor.foot,sensor.seat
function=numpy.sum

Available in Revision 0.1.3.


testin

The added code is not functional, please add only functional code to the project. If needed also add additional tests!


Selectors containing keyword 'white' change to '#fff'

I am using grunt-contrib-cssmin and I have the following CSS:
[class*="button-"][class*=“-white”]{
    background: white;
    color:#6f777b;
}

After minifying the above CSS I get the following output:
[class*="button-"][class*="-#fff"]{background:#fff;color:#6f777b}

This should actually be:
[class*="button-"][class*="-white"]{background:#fff;color:#6f777b}

Is there an option I need to pass to prevent this?

Actually nevermind I think the issue is due to Sass compression...


Should quit_excess_workers_for() respect TERM_CHILD setting?

Is it necessary to send a different signal in quit_excess_workers_for when TERM_CHILD=1 is set to ensure clean shutdown of workers under Heroku signal handling conditions? Currently it always sends QUIT
    def quit_excess_workers_for(queues)
      delta = -worker_delta_for(queues)
      pids_for(queues)[0...delta].each do |pid|
        Process.kill("QUIT", pid)
      end
    end

That sounds very reasonable to me.
It's certainly the approach used by graceful_worker_shutdown_and_wait! and graceful_worker_shutdown!, although shutdown_everything_now! is reversed (which is confusing, but based on the default CLI options which will use graceful_worker_shutdown_and_wait when TERM_CHILD is enabled).
Send a small PR, and I'll quickly merge it. :)


Support governance proposals/hotfixes in contractkit

Description
Adds interfaces to src/wrappers/Governance for interacting with proposals/hotfixes
Adds src/governance/proposals for constructing proposal/hotfix inputs
Tested
Added src/wrappers/Governance.test to test e2e proposal functionality
Hotfix tests disabled until #1737 is fixed
Other changes

Touches #501
Fixes #672

Adds timeTravel to test-utils/test-ganache
Updates, simplifies, and dedupes type converters in src/wrappers/BaseWrapper
Migrates util functionality to /packages/utils/src/address
Adds positional args to src/explorer/block-explorer/CallDetails interface

Closing for merge of #2139


Improve usability of select2 in node environment with browserify

There are a couple issues that result from select2 being require()d in a node environment and then browserified for use client-side, as set out in #3282 and #3287. This PR solves both of these issues.

Will this PR be merged or has it already been dealt with in the main branch?

This has not yet been merged as we still need to look into it.

@kevin-brown - thanks for the prompt response! And @leftmostcat for the fork to potentially use in the meantime.

any chance this gets merged?

This should have been fixed by https://github.com/select2/select2/commit/8edf3c64082be59b9506f3ad6dd84073b6eb5841.


contrib: support installation on Arch Linux

This PR enables CacheLib to be installed on Arch Linux.
I am an Arch Linux user, and I have tested it on my own machine.

(CC @assafgelber)

(CC @agordon)


Packaging features and popularity

Hi,
I found this project shared today in my Fediverse feed and wanted to know what the intention for the Project is. Your readme mentions that you don't want to replace the existing solutions which is ok, but depending on popularity of your project and your future self making new plans this might or may not change. As the Readme does not mention any goal I was wondering what is the goal? Are there any features planned or is this just an experiment?
Some clarification would be nice, so people looking into this space know what to expect from your project.
As a Packager for example I am already missing a equivalent to auconfs DESTDIR feature to put the final installation tree under a area for later packaging. It's ok if it's just an experiment. Just though I'd let you know so you can think where you want to go.
Also on a sharing note similar work is also done on the illumos site as an experiment. https://github.com/oxidecomputer/eos
It's only an experiment but frustration with current systems is high so you might find yourself popular soon.
Enjoy the Coding and all the best

Hi,
Thank you for checking this out and asking.
Originally this started as a way for me to learn Rust and more about meta build systems that existed and why they have done their decisions. At the same time, I was frustrated with using systems like cmake as I feel it can be incredibly complex at times. I wanted to see if it was possible to create a system that was declarative and easy to use.
Additionally, if it is possible, I wanted to force a specific work flow on the developer. A project that uses yambs can only be built in one way, and not in the tens of thousands of ways you can customize, configure and build a project in cmake.

Your readme mentions that you don't want to replace the existing solutions which is ok, but depending on popularity of your project and your future self making new plans this might or may not change. As the Readme does not mention any goal I was wondering what is the goal? Are there any features planned or is this just an experiment?

I've tried to be careful on my wording. Before I made the project open I was unsure about how people would view this concept: Have I taken a wrong approach on things, have I misunderstood concepts, and so on. I would base myself on the feedback. Not adding goals was a blunder of mine.
A key thing to making this public was also that after working on this for a while, I noticed that I got more and more locked into my own perspective. I wanted to get other people's perspective on what's missing and what should be thought of.
I definitely do want this project to keep going. The goals I (so far) have for long term are:

Support other platforms (Linux, MacOS, Windows)
Different generators (Make and perhaps different flavors, Ninja, MSVC)
Customizable toolchain without sacrificing the declarative syntax
Support other package managers (conan, vcpkg, ...)

I must admit I am somewhat unsure on the packaging part. It has been in the back of my mind but I have not found a great way to attack this yet. One idea I had was to let that be up to the user's responsibility. Perhaps this is the wrong way to go?
Adding support for equivalent of autoconf's DESTDIR can definitely be done; I've just not gotten that far yet. If you do have more cents to share on this, I am happy to listen to it.

Well my tool work might give you an overview.
In general I would like to make my definitions as minimal as https://github.com/Solarm-Project/solarm-gate/blob/main/packages/gnu-binutils/package.kdl
And leave out the Summary and stuff so I only have to manage which version with which options I want. And which compiler options I want. Like force enable frame-pointers and PIC on all packages. So nobody has to remember to do that and all the compiler details can be nicely defined into a datafile and thus applied, analysed and used.


Add ResourceFlavor section to Job troubleshooting guide

What type of PR is this?
/kind documentation

What this PR does / why we need it:
I extended the Job troubleshooting guide by adding a short section about identifying ResourceFlavor of a Job
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/cherry-pick website


Add warning on while let syntax

A brief warning in bold about the following misuse of the while let syntax suggested in the docs:
let array = [0, 1, 2, 3];
while let Some(item) = convert(array.iter()).next() {
  // This is an infinite loop!
}

I got bitten by it while replacing regular iterators with streaming iterators and it took me quite a while to notice my mistake, so I think it's worth mentioning.

Ah yeah, good call. This is one way where while let is significantly different from for loop behavior.

Thanks!


[QUESTION].  how can we send an exported file to email after export?

Prerequisites
Versions

PHP version: 7.1.26
Laravel version: 5.7
Package version: 3.1

Description
I didn't find in documentation how to send the exported file to email as the attachement. What event can we use or some other way ?

Please refer to https://github.com/Maatwebsite/Laravel-Excel/issues/2045

Just store the file to a disk and then send attachments the Laravel-way as I explained in the comment @GlennM shared.
Depending if you are queuing or not, you can chain an extra job at the end of the export job chain https://laravel-excel.maatwebsite.nl/3.1/exports/queued.html#appending-jobs
If you are not using queueing, you can just put the attachment logic underneath the Excel::store() code.


Update zio, zio-macros, zio-streams, zio-test, ... to 2.0.10

Updates

dev.zio:zio
dev.zio:zio-macros
dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.2 to 2.0.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.0.2).
You might want to review and update them manually.
project/versions.scala

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #176.


Allow fileInstance & fileBundle for relRecording & relStimulation

based on #107

@apdavison & @UlrikeS91 thanks for the issue and taking care of it :slightly_smiling_face:


Bug with Germany(DE)  stnr validation

Hi!
Found a bug when validating Steuernummer, German tax number stnr most examples from the wiki  fail validation and return an error

Although the library that you inspired python-stdnum validates these numbers correctly
i.e.
stnr.validate('18181508155')
or
stnr.validate('181/815/0815 5')
result will be

Thanks for the report!   I'll hopefully get to this in the next day or two.

Digging into this, I think the wikipedia page does not have valid Stnr values.  There are two validation criteria for Steuernummers.

In the first 10 digits exactly one digit must be repeated two or three times and other digits can appear only once.
The check digits are failing as well

When I look at these numbers carefully I note that they all consist of similar repeating patterns that probably are not valid. Can you please confirm that these should be valid numbers and not just examples.

For reference, the python stdnum package only does syntactical validation no checksum validation.

Thanks for the quick response  🚀
I'm trying to find confirmation on real Steuernummer, this takes time. I will try until the end of the week. The confusing thing is that all validators give the same result, but stdnum-js is different. Give me some time to check the data please. This issue is useful in any case 🙂

Hi guys!
I tried using and validating an existing number 121/5752/5373 and it also failed checksum validation.
Any chance I can have a check this, please?


Why rewrite from Go to Rust?

What was the reasoning for rewriting the application in rust? Did you encounter any limitations in Go?

The short answer is that I want more experience with Rust.
I'm using my spare time to work on this and what I get back is experience.
There is no limitations in Go that prevents me from using it for this project, but Rust have some language features that I enjoy using (that are missing from most mainstream languages):

Tagged unions
Null safety
Immutable data (by default)
More type safe in general


Navigation rework

I know it's a draft, but here are a couple of thoughts I had, while looking at it:
I like the new list component on the explorer page. It also makes sense that data visualization is on that page.
As a user, I would probably expect public photos on the sharing page.
Face recognition could be on the person page. But maybe it needs a new tab on the side menu, because right now it's pretty much needed in order to label persons and therefore needs to be discoverable. Once we have an automated clustering system for faces in place, we can then move it.
Also, the auto generated albums are missing :sweat_smile:  We should maybe also rename that to "Events" or "Moments" or something like this.

There are a few things that need to be looked at:

Mobile menu still hasn't been done. I don't think that it will be a huge issue though. I am thinking of 5 items at the bottom (same as on the side) and the rest is the same—no pop-up menus.
The explorer links organisation need some thought. I agree that some links should be moved to other sections.
I was thinking to have auto-albums as a "tab" or something similar in the albums menu.

I am still exploring options on how to organise links.

I will reopen PR for navigation rework when other related bits will be done


lost-move: a full width block isnt working

tried to move 2 full width block like this and its not working
div:first-child {
lost-move: 1;
}
div:last-child {
lost-move: -1;
}

Doesn't work with 1/1 does it?

All lost-move is doing is visually moving over an item to the right and left so on larger displays you are simply visually laying it out differently. No matter what, when you're dealing with a full width element (normally dealing with that on mobile) then it will always revert to the actual structure that the HTML is laid out.
e.g.

First

Second

In that above scenario, First is ALWAYS going to be first and second is ALWAYS going to be second when you have each div full-width. lost-move ONLY works when you say have both of those divs next to eachother and you want the second div and the first div to visually swap with eachother. Once you revert them back to be full-width then it's always going to go back to the first and second top to bottom because that's the physical structure layout.
What you're looking for is to change the ordering. Something that you have to use flexbox for (there's NO graceful way to reorder the physical structure of html elements without getting EXTREMELY messy with position absolute top/bottom numbers and stuff). Look up flexbox ordering and you can mix flexbox with lost-grid to accomplish what you are trying to accomplish.


disable gravatar by default (privacy)

If I want to get tracked, I could use a hosted solution. And if I might cite the cockpit startpage  ;-)

Self-hosted - Keep complete control. Your data is and will be always yours.

I still have a solution, but I never worked with APIs or riot or npm before. So I wait with my pull request until someone else will review the code or give some hints for a cleaner logic. But I learned a lot the last days - searching for docs, reading the code, using Guzzle, Postman, riot etc. and I can't wait to restructure all my data.
My commit in my repo adds a config variable gravatar with default to false to bootstrap.php and it adds some logic to a few views and .tag-files to take care of the configuration.
It also contains a few console.logs for debugging.
Two commits later I removed a lock file and added it to .gitignore.
And thank you for this software.

You're totally right, I already planed to remove gravatar for the next release

Thank you very much. That was fast and removing sounds even better than disabling. Next time I'll ask you before I write a workaround. But otherwise - now I have a basic understanding of the templating system.


Sampling

Sample user input (mouse, touch, ...) with respect to the speed of the motion (sample less often when the movement is slower). The sampled points should be connected and the final curve should be smoothened using Bézier curves (interctive example).

This SO answer suggested to use methods described in this article.
The plan now is to sample stroke points, at least MIN_DISTANCE apart, and implement the algorithm described in the article using the la4j library.

Need to set-up the project (at least core) for unit testing.

JUnit testing set up in #4.

Android doesn't support Point2D (part of the java.awt package, which isn't supported on Android).


feat: add support to auth module 0.3.0

Dex branding changes LGTM, but there are some other changes for gangplank included in this PR, is that ok? Also, this PR is for changes top the auth module that are still in draft or am I wrong?

feat: prepare v0.3.0 fury-kubernetes-auth#27

change the PR's title to "feat: add support to auth module 0.3.0", same goes for the PR you linked that is not in draft state anymore, thanks for pointing it out


Color cursor doesn't show correctly on Ubuntu 22.04

Details on:
https://github.com/pharo-graphics/Bloc/issues/211

Steps on a terminal:

curl https://get.pharo.org/110+vmLatest | bash
./pharo Pharo.image and load project as in README (reference commit: https://github.com/tinchodias/pharo-sdl-experiments/commit/83199c1bc98229390731b0abbcb924811c56322e)
./pharo Pharo.image eval --no-quit "SceneDragAndDropDemo new open"


Add automated release system

There are a couple of changes here:
In order to release more frequently it is necesary to automate some tasks. Linting and Test running are already. However deployment is not.
In order for contributors to have a common workflow/ci-cd platform, and provided that this is hosted in github, as well as 99% of FOSS projects. I propose migrating the ci to github workflows.
I moved both pre-exising workflows from circle-ci to github so we have them all in the same place
The purpose for this is to stablish a good basis to close several features contributed in #48  and also frequent user requests like #65

Here the build results https://github.com/teamdatatonic/airflow-dbt/actions/runs/2993755238 for a pick

@RafalSiwek , a couple of actions have to be taken from Gocardless side:

Add Pypi token to the repo so the job can authenticate
Switch from circle-ci to github workflows
Switch to the prod pypi: You can see that it is uploading the package to the TEST pypi repo for now. Once it's working do a small commit to switch it

Do we have any ETA on when the next release will be ready?


Status Code: 404

I've been trying place a order on kucoin futures, with ta API v2 using the following url: 'https://api-futures.kucoin.com/api/v2/order'
but I just got the error 404 that means it's not found, so anyone knows witch url shoul I use to place a order ?
thanks in advance

I solved the problem using the url of version 1
'https://api-futures.kucoin.com/api/v1/orders'
and keeping "KC-API-KEY-VERSION": "2", on the header


feat: Price estimate flow first QA pass

https://artsyproduct.atlassian.net/browse/GRO-46
This PR follows up on a long list of items from our first QA pass of the price estimate flow. A large part of the work was getting our layout to be correct on mobile and responsive. Please check out the ticket to see the full list.
My screen capturer seems to have a color issue so unfortunately the light gray background in the price estimate section isn't showing up but it's still there.
Screen captures

(Nice git disclipline @williardx)


Add Reward Call Via Supermax Endpoint

What's the problem? (required)
When a token holder is making the delegation decision, # of missed reward calls is not exposed.  As a result, people just look at "Total Stake".  We don't want this to happen.
What's the current behavior? (required)
No information about reward calls is in the "transcoders" tab of the explorer.
Do you have any personal experiences dealing with this problem? (optional)
The best way currently is to use Supermax, which is a very high-barrier action.
Describe a possible solution you've considered (optional)
We can use the Supermax API endpoint to load the reward information.  Try it with:
curl -X POST \
  https://supermax.cool/supermax/api/v1/activity/livepeer/aggregateCallCountByAccountOverRounds \
  -H 'Authorization: hello@world.com:eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJlbWFpbCI6ImhlbGxvQHdvcmxkLmNvbSIsIl9pZCI6IjVhMTBjMzllNTQ2ZWZiMDc1MWEwYWUzYyIsImlhdCI6MTUxMTA1MDE4NH0.oIe738oMRmez_NI5U4-w9L0LiCjkssJ6f9KtbX9_N_k' \
  -H 'Cache-Control: no-cache' \
  -H 'Content-Type: application/json' \
  -d '{
  "network":"mainnet",
  "startRound":1000,
  "endRound":1101,
  "ethcallName":"reward",
  "accountAddresses":["0xbd91c9df3c30f0e43b19b1dd05888cf9b647b781", "0x4f4758F7167B18e1F5B3c1a7575E3eb584894dbc"]
}'

I propose we start with a simple metrics of "# of missed reward calls in last 30 rounds".  This can be queried with a single query to the Supermax API.

This has been worked on and pushed to production. Closing this, @ericxtang you can reopen if this has not been implemented.


chore: update codecov action to v5

Tokenless uploads are supported again.
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token

Coverage dropped because last time it was uploaded was 6 months ago.


Issue Error Messages for Unsupported Operators

@gatorsmile A PR for your PR. I think this should be what we are aiming for. I changed the code for visitChildren, and I had to change the predicate/predicated rules. Feel free to integrate this in your PR.

Thank you! @hvanhovell I will do it. You are so nice!


Code improvement

Update flask-restplus to latest version flask-restx.
flask-restplus does not receive updates since Jan 2020. Besides, flask-restx updated last month (August 2020).

Update from flask to fast API
https://github.com/tiangolo/uvicorn-gunicorn-fastapi-docker
Performance issues
<EMAIL_ADDRESS>

https://fastapi.tiangolo.com/deployment/

https://fastapi.tiangolo.com/tutorial/bigger-applications/


WIP: DEVHAS-627: Check if application is under deletion before component deletion

What does this PR do?:
This PR adds an extra condition upon component deletion. More detailed in https://github.com/redhat-appstudio/application-service/blob/main/controllers/component_controller.go#L191 we now check if the component's application has a deletion timestamp set. If yes we don't delete the component to avoid race conditions between the component & the application deletion.
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/browse/DEVHAS-627
PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

WIP until is tested on a local cluster

no tests needed?

Yeap is WIP as I'm still working on the test cases.
cc @maysunfaisal @johnmcollier

@johnmcollier @maysunfaisal I've removed the WIP label and added a test case for component deletion for applications that have been marked as deleted

/retest

/test application-service-e2e

/test application-service-enterprise-contract

/test application-service-e2e

/retest

/retest

/retest

/retest

/retest


Combine arrayDepth and objectDepth

we'd call it execution Depth

Fixed in https://github.com/algomaster99/collector-sahab/commit/9d292a2ab119cdbd0038d3b8e29e01f88cf6a32b.


Maximum sync item limit reached

Hi, I've been using this extension for years and I guess I finally selectively turned off dark mode for enough websites that I went over the 512 sync item limit and now always get this prompt whenever I try to selectively enable/disable dark mode from a new website:

I know it suggests using local storage, but I'd like to have everything synced across Chrome browsers—is there any way around this to getting a larger number of site settings syncable? Could one item be changed to fit more data to bypass this?

Then you would probably be limited by size - they have a lot of different limits...
I would recommend to change the way how you use settings. For example if you are disabling it for most of the websites then just disable it by default and only enable for those you need it.


build istio/istio from master - curl: (60) SSL certificate problem

I try to build istio/istio from master use make build, according to https://github.com/istio/istio/wiki/Using-the-Code-Base . When build-script try to download istio-proxy, curl exit with error code:
...
Downloading Envoy: curl -fLSs https://github.com/istio/proxy/releases/download/1.0.2/istio-proxy-1.0.2-macos.tar.gz to /work/out/darwin_amd64/release/envoy-1.0.2
curl: (60) SSL certificate problem: self signed certificate in certificate chain
More details here: https://curl.haxx.se/docs/sslcerts.html
...

I visited https://curl.haxx.se/docs/sslcerts.html , download last version cacert.pem and put to /etc/ssl/certs/cacert.pem.
After all I could download istio-proxy-1.0.2-macos.tar.gz manually (use curl)
curl -L https://github.com/istio/proxy/releases/download/1.0.2/istio-proxy-1.0.2-macos.tar.gz --output some-output-file
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   620  100   620    0     0   1383      0 --:--:-- --:--:-- --:--:--  1383
100 7947k  100 7947k    0     0   631k      0  0:00:12  0:00:12 --:--:-- 1359k

,but error still occur during execution make build.
When use curl with -k(Allow insecure server connections when using SSL), get You are being redirected.:
You are being <a href="https://github-production-release-asset-2e65be.s3.amazonaws.com/75322405/f13ffa80-b53b-11e8-9527-2a586cbda4ad?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200304%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200304T111428Z&X-Amz-Expires=300&X-Amz-Signature=73a2788ecc120b520a6ddeb237b8bbd74a035f71e3aed8f5ee2de6f463abf3fc&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Distio-proxy-1.0.2-macos.tar.gz&response-content-type=application%2Foctet-stream">redirected.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ x ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Steps to reproduce the bug

make build

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
clone from master branch
Environment where bug was observed (cloud vendor, OS, etc)
macOS Catalina 10.15.1

@ericvn any ideas? only mentioning you since you have worked on the osx build stuff a bit

tmp solution -> add -k option  to
if command -v curl > /dev/null; then
    if curl --version | grep Protocols  | grep https > /dev/null; then
      DOWNLOAD_COMMAND='curl -kfLSs'
      return

in bin/init.sh

I can look into this more, but I recall I might have had to just go with the -k option at one point as well.


RC test: ph-scale-basics 1.3.0-rc.3

@KatieWoe, @ariel-phet, @arouinfar, ph-scale-basics/1.3.0-rc.3 is ready for RC testing. This is for brand=phet only. PhET-iO and a11y are not included.
Document issues in https://github.com/phetsims/ph-scale/issues (not in ph-scale-basics) and link to this issue.
Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Check this LoL spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
If there is a console available, check for errors and include them in the Problem Description.

Focus and Special Instructions
This is a spot check. A full test matrix is not necessary.  Verify the issues in "Issues to Verify" on one or two platforms.
Issues to Verify

[ ] update credits for 1.3.0 release

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is "status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Simulation
iFrame
XHTML
Test Matrix
Legends of Learning Harness

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

[ ] Win 10 chrome
[ ] Win 10 firefox
[ ] Win 10 edge

[ ] Mac 10.14 chrome
[ ] Mac 10.14 safari

[ ] Win 7 IE
[ ] Mac 10.11 safari

[ ] ChromeOS
[ ] iOS 12

@pixelzoom to approve test devices

Definitely overkill for https://github.com/phetsims/QA/issues/383 (credits), which is the only issue relevant to ph-scale-basics.  One platform is sufficient.

QA is done

Thank you QA. This concludes the RC process. Production version 1.0.0 has been deployed. Closing.


Dynamically creating rules and compile directives

I would like to generate Rules DSL from the helper module. I have custom blog helper and i would like it to generate RSS feeds automatically so I don't have to specify any compile and routing rules in the Rules file as long as specific metadata is present.
For more details, please see my question on stackoverflow:
http://stackoverflow.com/questions/32645687/dynamically-creating-rules-and-compile-directives

I’m inclined to say that this is not the purpose of the Rules file, and I believe a better approach would be to add attributes to the site configuration, items and layouts, and parameterise rules that way, so that there’s no need to generate rules programmatically.
An additional challenge with generating rules is that it gets rid of a central place where all rules are stored. This can make it difficult and confusing to find out which rules actually exist, and which rules are used for a given item/layout.
Having said that, there is #include_rules, which, given a file name, will include the rules in the file with that name.

I believe a better approach would be to add attributes to the site configuration, items and layouts, and parameterise rules that way, so that there’s no need to generate rules programmatically.

This is precisely what I try to avoid. I would like to have zero configuration for some modules. I just want to plug it in (enable it in preprocessing section) and it should setup details itself. Typical case is tags module - I want to have 1 page that shows all tags and one blog for each individual tag and 1 feed for each tag blog. If I include such module it should create all those items and configure them for the articles that have tags metadata, no questions asked. With module arguments or site config I could customize the module if I need to. Without it, I need to setup all that manually (which means stuff in content, stuff in nanoc.yaml and stuff in Rules on multiple places, stuff in default.rb) which makes removal of tags non-trivial especially after some time has passed. Furthermore, multiply this with the number of nanoc sites where you need this functionality. If I need to maintain this module over multiple sites its even more problematic.

An additional challenge with generating rules is that it gets rid of a central place where all rules are stored.

We have  nanoc show-rules for that ? Also, it seems easy to change #include_rules to remember all included files and list their content with new command (or just those generated by modules).
I think that existence of mechanisms such as this would make nanoc far more usable as without understanding the internals much you would be able to follow plugin/module convention to get the desired effect and only tweak internal details if those conventions are not good in your scenario. Black box functionalities would also make easier for everybody to experiment.

Moved to nanoc/features#2.


wild card support

wild card support would be nice, so that 'prayer potion*' would cover all doses of potion
'prayer potion*' = 'prayer potion(4), prayer potion(3),prayer potion(2),prayer potion(1)'
even potion would cover almost every potion type and all of their doses

Added in v1.1, waiting for approval now: https://github.com/runelite/plugin-hub/pull/3826

Re-opening until update is merged.


SNR value

In the paper in equation (4) you give a formulation of the SNR, but then in the code  you use another formulation for this value.
Which is the correct one?

Sorry for the confusion. Actually, equation 4 and the code are equivalent: 1.0 / (1 - alpha) - 1 = alpha / (1 - alpha).

Thanks you for the quick answer! You are right, totally an oversight from my side 😅.


BugRep: failed installing steamtinkerlaunch-git

Tried steamtinkerlaunch-git on a freshly installed Ubuntu 22.04 VM (installed using Boxes express installer, already updated). Got an error with the following message:
First Try Log
$ pacstall -I -K steamtinkerlaunch-git
[+] INFO: Keeping build files
Do you want to view/edit the pacscript [y/N]
[+] INFO: Sourcing pacscript
[+] INFO: Installing yad
[*] WARNING: Prompts are disabled
[+] INFO: Keeping build files
Do you want to view/edit the pacscript [y/N] N
[+] INFO: Sourcing pacscript
[+] INFO: yad requires autotools-dev intltool libgtk-3-dev automake to install
Do you want to remove them after installing yad [y/N] N
Extracting templates from packages: 100% // truncated package installation
[+] INFO: Creating dummy package
[+] INFO: yad has optional dependencies that can enhance its functionalities
Optional dependencies:
    libwebkit2gtk-4.0-dev: for supporting HTML dialog
    libgtksourceview-3.0-dev: for enabling syntax highlighting in text-info dialog
    libgspell-1-dev: for support spell checking in text fields
Do you want to install them [Y/n] Y
[+] INFO: Installing dependencies
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'yad' instead of '/tmp/pacstall/yad-pacstall.deb' // truncated package installation
[+] INFO: Retrieving packages
Initializing download: https://github.com/v1cont/yad/releases/download/v12.0/yad-12.0.tar.xz
File size: 282.508 Kilobyte(s) (289288 bytes)
Opening output file yad-12.0.tar.xz
Starting download

Connection 1 finished
[100%] [..................................................................................................................] [ 151.2KB/s] [00:00]

Downloaded 282.508 Kilobyte(s) in 1 second(s). (151.19 KB/s)
[+] INFO: Preparing // omitted yad install log as there was no issue
[+] INFO: Symlinking files
[+] INFO: Storing pacscript
[+] INFO: Cleaning up
[+] INFO: Creating dummy package
[+] INFO: steamtinkerlaunch-git has optional dependencies that can enhance its functionalities
Optional dependencies:
    mangohud: vulkan/opengl monitoring hud
    winetricks: wine settings tweaker
    vkbasalt: vulkan graphics enhancer
    goverlay: vulkan overlay configurator
    scummvm: VM for point-and-click games
    gameconqueror: memory editing for cheating
Do you want to install them [Y/n] Y
[+] INFO: Installing dependencies
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'steamtinkerlaunch-git' instead of '/tmp/pacstall/steamtinkerlaunch-git-pacstall.deb'
Setting up steamtinkerlaunch-git (2c28fc5b-1) ... // truncated package installation
[+] INFO: Retrieving packages
Checking object directories: 100% (256/256), done.
Checking objects: 100% (192/192), done.
[+] INFO: Preparing
[+] INFO: Building
[+] INFO: Installing
cp: cannot stat 'categories': No such file or directory
[!] ERROR: Could not install steamtinkerlaunch-git properly
[+] INFO: Cleaning up

Full log here: https://pastebin.com/ykAX3Ave

Second Try Log
$ pacstall -I steamtinkerlaunch-git
Do you want to view/edit the pacscript [y/N]
[+] INFO: Sourcing pacscript
[+] INFO: The pacstall dependency yad is already installed
[*] WARNING: It's recommended to upgrade, as yad may have a newer version
[+] INFO: Creating dummy package
[+] INFO: Installing dependencies
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'steamtinkerlaunch-git' instead of '/tmp/pacstall/steamtinkerlaunch-git-pacstall.deb'
The following NEW packages will be installed:
  steamtinkerlaunch-git
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/1394 B of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 /tmp/pacstall/steamtinkerlaunch-git-pacstall.deb steamtinkerlaunch-git all 2c28fc5b-1 [1394 B]
Selecting previously unselected package steamtinkerlaunch-git.
(Reading database ... 235368 files and directories currently installed.)
Preparing to unpack .../steamtinkerlaunch-git-pacstall.deb ...
Unpacking steamtinkerlaunch-git (2c28fc5b-1) ...
Setting up steamtinkerlaunch-git (2c28fc5b-1) ...
[+] INFO: Retrieving packages
Checking object directories: 100% (256/256), done.
Checking objects: 100% (192/192), done.
[+] INFO: Preparing
[+] INFO: Building
[+] INFO: Installing
cp: cannot stat 'categories': No such file or directory
[!] ERROR: Could not install steamtinkerlaunch-git properly
[+] INFO: Cleaning up

It does manage to install all the other required dependencies, so I managed to just manually git clone https://github.com/frostworx/steamtinkerlaunch and sudo make install. Here is the log for that:
Manual Install Log
$ git clone https://github.com/frostworx/steamtinkerlaunch
Cloning into 'steamtinkerlaunch'...
remote: Enumerating objects: 5818, done.
remote: Counting objects: 100% (1324/1324), done.
remote: Compressing objects: 100% (402/402), done.
remote: Total 5818 (delta 957), reused 1244 (delta 905), pack-reused 4494
Receiving objects: 100% (5818/5818), 2.81 MiB | 2.37 MiB/s, done.
Resolving deltas: 100% (3930/3930), done.

$ cd ./steamtinkerlaunch/

$ sudo make install
sed "s:^PREFIX=\"/usr\":PREFIX=\"/usr\":" -i steamtinkerlaunch
install -Dm755 steamtinkerlaunch -t "/usr/bin"
install -d "/usr/share/steamtinkerlaunch"
cp -r collections eval guicfgs lang misc "/usr/share/steamtinkerlaunch"
install -Dm644 README.md -t "/usr/share/doc/steamtinkerlaunch"
install -Dm644 "misc/steamtinkerlaunch.desktop" -t "/usr/share/applications"
install -Dm644 "misc/steamtinkerlaunch.svg" -t "/usr/share/icons/hicolor/scalable/apps"

Something wrong with the ./categories folder it seems?

Thanks for the report!
Once I get back from vacation (7-8 hours), I will fix this bug.


cleanup machine variables

There are quite a bit of unused or obsolete variables in our machine files, let's drop them.
Signed-off-by: Jonas Gorski<EMAIL_ADDRESS>

Built and runtested on as4610 and as4630-54pe by logging in via serial console.


Schedule Refresh not working for my custom connector

Hi,
I have designed a custom connector to connect with power bi. Everything works fine in desktop, API is hit, data is load and every other thing works fine in power bi desktop. The problem starts when I want to sync it with power bi service. I publish it to power bi service and have a configured schedule refresh. Schedule refresh doesn't take place and fails due to anonymous reasons. I have tried both with on-premise enterprise and personal gateway, only to fail in both. I have implemented test connections and searched a numerous sites. Help to resolve this issue will be highly appreciated. A sample of my response (This is the whole response I get.)
Cluster URI: | WABI-SOUTH-EAST-ASIA-redirect.analysis.windows.net
Activity ID: | 9fbe0877-dbac-42aa-8114-349cf9e16454
Request ID: | 3c056601-436c-431f-8ed4-67455638f2c5
Time: | 2019-12-12 07:14:47Z
Thanks in advance!

for more details about the error you need to export the logs from your gateway and try to search for the activity ID "9fbe0877-dbac-42aa-8114-349cf9e16454" to trace it.

Thanks for instant response. I tracked my logs and found the following logs :

DM.EnterpriseGateway Error: 0 : 2019-12-12T07:13:29.7153762Z DM.EnterpriseGateway	141587ea-dee2-4e67-8361-d8427e0a4c2c	f95c547d-f7e6-47c7-ae72-a5b1db0d3fef	MGPP	9fbe0877-dbac-42aa-8114-349cf9e16454	31aed1df-aed1-423f-83d8-a01fbcdf7074	31aed1df-aed1-423f-83d8-a01fbcdf7074	0BD00B27 [DM.GatewayCore] Failed to Renew OAuth token. Exception: System.NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.Mashup.Engine1.Runtime.Extensibility.ExtensionOAuthFactory.Provider.Microsoft.Mashup.OAuth.IOAuthProvider.Refresh(TokenCredential credential)
at Microsoft.PowerBI.DataMovement.Pipeline.GatewayCore.GatewayOAuthUtils.RenewOAuthToken(IOAuthProvider oauthProvider, CredentialDetails credentialDetails)
at Microsoft.PowerBI.DataMovement.Pipeline.GatewayCore.GatewayOAuthUtils.d__7.MoveNext()

Basically, its failure to renew oauth token. I have implemented the oauth mechanism like below :
StartLogin = (resourceUrl, state, display) =>
    let
        AuthorizeUrl = authorize_uri & "?" & Uri.BuildQueryString([
        client_id = client_id,
        redirect_uri = redirect_uri,
        state = state,
        scope = GetScopeString(scopes, scope_prefix),
        response_type = "code"
    ])
    in
        [
            LoginUri = AuthorizeUrl,
            CallbackUri = redirect_uri,
            WindowHeight = 720,
            WindowWidth = 1024,
            Context = null
        ];

FinishLogin = (context, callbackUri, state) =>
    let
        parts = Uri.Parts(callbackUri)[Query],
        result = if (Record.HasFields(parts, {"error", "error_description"})) then
                    error Error.Record(parts[error], parts[error_description], parts)
                 else
                   TokenMethod("authorization_code", parts[code])
    in
        result;

Refresh = (resourceUrl, refresh_token) => TokenMethod("refresh_token", refresh_token);

TokenMethod = (grantType, code) =>
    let
        query = [
            grant_type = grantType,
            client_id = client_id,
            client_secret = client_secret,
            redirect_uri = redirect_uri
        ],

        queryWithCode = if (grantType = "refresh_token") then [ refresh_token = code ] else [code = code],

        response = Web.Contents(token_uri, [
            Content = Text.ToBinary(Uri.BuildQueryString(query & queryWithCode)),
            Headers=[#"Content-type" = "application/x-www-form-urlencoded",#"Accept" = "application/json"]]),
        body = Json.Document(response),
        result = if  (Record.HasFields(body, {"error", "error_description"})) then
                    error Error.Record(body[error], body[error_description], body)
                 else
                    body
    in
        result;

Logout = (token) => logout_uri;

Value.IfNull = (a, b) => if a <> null then a else b;

GetScopeString = (scopes as list, optional scopePrefix as text) as text =>
    let
        prefix = Value.IfNull(scopePrefix, ""),
        addPrefix = List.Transform(scopes, each prefix & _),
        asText = Text.Combine(addPrefix, " ")
    in
        asText;

I don't find anything abnormal that could possibly be the reason for the failure for the refresh. Can you please help on debugging this and find if anything is wrong in the implementation of oauth.

A previous user got the NullReferenceException because their Refresh function was calling a TokenMethod function with three arguments while the definition of TokenMethod only has one argument.
https://github.com/microsoft/DataConnectors/issues/237

I used Extension.CurrentCredentials() to view the credentials and found that refresh_token is not being stored. Resulting in null reference exception. I tried with another api and the result was same, refresh_token is not being stored. Do you know why or is there any other method to manually add refresh_token to the credentials. I feel if refresh_token is stored, my issue would be solved. Even a little help is appreciated.

You have a syntax error in the token method:
queryWithCode = [code = code],

Nope, it isn't a syntax error. If it's syntax error, I wouldn't have got the above respone. I generate refresh token and access token while calling tokenmethod() manually. The same is not reflected when calling Extension.CurrentCredentials() where i get null for refresh token.

Have you looked at e.g. Fiddler to see what the token endpoint is returning?

Where is the refresh token being stored ? In other words, how do we store the refresh token ? And, where will it be persistent ? In a file ? In memory ?
By fiddler, do you mean to debug the code and understand it ?

@CurtHagenlocher What if the token method does not provide a refresh token? Is it still possible to do scheduled refreshes?

If the service doesn't support returning a refresh token, then it really depends on the lifetime of the access token. If it expires in an hour (or even a day) then scheduling refresh isn't practical because you'd need to log in very frequently. Ideally, the lifetime of the access token would be at least one month.

The access token has a long lifetime (150 days), but still the scheduled refreshes will not work...

@nagabalajitg , where the refresh token is stored depends on the host. For the SDK and Power BI Desktop, we store it encrypted in a local file alongside the rest of the credential. By "Fiddler", I mean having Fiddler running to inspect your network traffic while getting the credential in order to validate that the endpoint is actually returning the refresh token.
@maikenflowers, "the scheduled refreshes will not work" is too ambiguous a problem description for me to address. Is there a specific failure message?


Upgrade to protobufjs 6

I spent quite a while tracing through an issue with protobufjs that stems from the fact that I had manually installed it, meaning it was at the latest version, 6, and tsc_wrapped apparently fails if it's on 6 instead of 5, in a way that seems...incredibly opaque to me. tsc_wrapped isn't even in the stack trace below(!!), but I did eventually track it down to that, and downgrading to 5 fixed the issue.
I unfortunately can't think of a way that would make this easier for past-Caleb to debug, but upgrading to protobufjs 6 would solve the specific problem regardless.
(As an aside, I find this all pretty weird that NPM/Yarn wouldn't yell at me about having incompatible versions being depended on, or just install both versions for the appropriate project. Otherwise, what's the point of semver and including versions at all? Maybe this is some basic thing that I just haven't experienced, but it seems crazy to me.)
$ bazel build src
INFO: Found 1 target...
ERROR: /Users/calebegg/Code/mta/src/BUILD.bazel:4:1: Compiling TypeScript (devmode) //src:src failed (Exit 1).
failed to load main  TypeError: Cannot read property 'resolve' of undefined
    at Object.<anonymous> (/Users/calebegg/Code/mta/node_modules/protobufjs/src/root.js:62:39)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/calebegg/Code/mta/node_modules/protobufjs/src/index-light.js:83:29)
    at Module._compile (module.js:570:32)
Target //src:src failed to build

NPM/Yarn probably installed both protobufjs versions in node_modules.
The challenge is, which version does a given require load? The semantics depend on the calling script. If the calling script in node_modules/@bazel/typescript has its own node_modules/@bazel/typescript/node_modules/protobufjs then it should use that one.
I suspect your issue is due to our own Bazel-ified module loading patch, see https://github.com/bazelbuild/rules_nodejs/commit/ebbad65504cd0a0007987b6adce3b77a8a898ee8
this is needed because we support require('some-name') where some-name is the module_name of a build rule in the dependencies, not installed by npm/yarn. (effectively we have our own private npm repository inside bazel). That commit actually broke module loading in a different case.
I need to understand these scenarios better and include coverage for them in the rules_nodejs repo so that module loading always follows the npm semantics, yet also supports our internal loading. (Of course we don't have an example to follow in google3 because we don't use npm semantics)

Aha, interesting. I'm not sure I've ever encountered node_modules/foo/node_modules structures. There's a lot I still don't know about npm....

@alexeagle I've run into a similar issue where rules_typescript uses pbjs5 but our own code uses pbjs6 and both where in the same resolution path. I'm not grasping the entire setup yet, but doesn't this look like an isolation issue? I reordered the resolveLocations in rules_nodejs/internal/node_loader.js and suddenly tsc_wrapped_bin used the correct version. please check this out, looks like a bug.

I'm also running into this problem. It looks like the wrapped tsc should only be using the _tsc_wrapped_deps node_modules, but it's using both those and the project's node_modules.
Note that I'm not using the @bazel/typescript package, but am referencing this github from my WORKSPACE. I have the following protobufjs packages:
$ find  -L . -name protobufjs
./node_modules/protobufjs
./bazel-myproject/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-myproject/node_modules/protobufjs
./bazel-myproject/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc_wrapped_bin.runfiles/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-myproject/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc_wrapped_bin.runfiles/myproject/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-myproject/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc.runfiles/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-myproject/bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc.runfiles/myproject/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc_wrapped_bin.runfiles/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc_wrapped_bin.runfiles/myproject/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc.runfiles/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs
./bazel-out/host/bin/external/build_bazel_rules_typescript/internal/tsc.runfiles/myproject/external/build_bazel_rules_typescript_tsc_wrapped_deps/node_modules/protobufjs

FYI I've looked into this a bit for unrelated reasons, and I believe #188 is not sufficient to make rules_typescript compatible with protobufjs 6.
It turns out v6 is a complete rewrite of protobufjs (see https://github.com/dcodeIO/protobuf.js/issues/485) (yay!). Notable changes for us are that there are no more getter & setter functions, messages are no longer constructor, and ByteBuffer is no longer used. This means all code in worker.ts that accesses protos needs to change, but also the message reading loop logic.
I'm still puzzling a bit on how to pull this off. The change to worker.ts while non-trivial is not that complex. The bigger problem is that v6 is incompatible and has lots of very non-obvious semantic changes (plus very little checking on top of it). This means to land it, we'd need to update a lot of Google-internal code.

I think the root cause here was that we mixed the dependencies of tsc_wrapped with those the user installed.
Ever since switching to an npm-delivered package @bazel/typescript, we can have whatever version of protobuf.js in our dependencies without regard for a different version used by the users code.
So this is obsolete.


Extend testing on set_approval_for_all

Set_approval_for_all updates permissions of the "assignee" to include 'approval' permission.  We need to test that once the permission is updated, it will also allow the "assignee" to assign 'approval' permissions to node operators.  Similarly, it should allow revocation of approval.

@gRoussac @darthsiroftardis please provide an estimate by Tuesday 2.28

This ticket has potentially confusing wording. To have parity with ERC-721, approved operators should have possibility to approve an address, but not other operators.
ERC-721 provide confusing terminology with terms sounds similar from the natural language perspective, but having different domain meanings. The standard separates “approval for all”, which can be applied to multiple operators from single “approve”, which can be applied only to a single address.
| Permission type  | Object name      | Supports multiple Object |
|------------------|------------------|--------------------------|
| Approve          | Approved address | No                       |
| Approval for all | Operator         | Yes                      |

which have the following permissions
| Caller           | Can call "approve" | Can call "set_approval_for_all" |
|------------------|--------------------|---------------------------------|
| Owner            | Yes                | Yes                             |
| Operator         | Yes                | No                              |
| Approved address | No                 | No                              |

The above was derived from ERC-721 and ERC-1155 implementations.
Additionally please look at the screenshot from the ERC-721 standard description.


Finishing site setup was taking too long

Expected behavior:
If installation was finished should be shown admin panel or store panel.
Actual behavior:
I'm using setup wizard tastyigniter v.3 and stack in 'finishing site setup'.
Reproduce steps:
Setup wizard was installed in localhost. I'm already write column installation properly, but in step 'finishing site setup' doesn't finish yet about one hour.
Version:
v.3
https://prnt.sc/p77gvj

I tried to reproduce this -
I get "stuck" on \System\Classes\UpdateManager::instance()->update();
This is where it installs the database tables though is does eventually complete successfully.
(May also be worth checking your max execution time in your php.ini file - If it's timing out will require installation restart to retry. )


Column header with blue outline after clicking for sorting

What version of React-Table are you using?
Your bug may already be fixed in the latest release. Run yarn upgrade react-table!
6.7.5
What bug are you experiencing, or what feature are you proposing?
As described in Title.
Refer to description by @gary-menzel in https://github.com/react-tools/react-table/issues/682
Use https://codesandbox.io/s/X6npLXPRW (by clicking the "Fork" button) to reproduce the issue.
https://codesandbox.io/s/5knzrn8qmk
What are the steps to reproduce the issue?

npm install -g create-react-app
Add<EMAIL_ADDRESS>to package.json.
replace src/App.js with following code

import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';
import ReactTable from 'react-table';
import 'react-table/react-table.css';

class App extends Component {
  constructor() {
    super();
  }
  render() {
    const data = [
            {
                "location":"01-01",
                "amount":150
            },
            {
                "location":"01-02",
                "amount":3000
            },
            {
                "location":"01-03",
                "amount":1201
            }
    ];

    const columns = [
      {
        Header: "Location",
        accessor: "location"
      },
      {
        Header: "Amount",
        accessor: "amount",
        Cell: props => {props.value}
      }
    ];

    return (

Welcome to React

          To get started, edit src/App.js and save to reload.

        <ReactTable
          data={data}
          columns={columns}
          classsName='-striped -highlight'
        />

    );
  }
}

export default App;

npm start.
Click any title of headers, and it shows

Thanks for that - checking in some changes against this issue now.  Not sure how quickly it will make it into a release (but I have notified the owner).

Yes noticed it too, the outline also wraps the column-resizer so it looks weird

The focus issue is a bug that has a PR in waiting to get released.

I've recently started using React Table and noticed that this bug is still occurring.  Using the Code Sandbox link referenced above (https://codesandbox.io/s/5knzrn8qmk) I updated the react-table dependency to 6.8.0 and the blue outline is still there.
I've create a PR with a fix (see #881)

Please see my comment on the PR.

One thing that works for me is using the onSortedChange property, overriding it to blur the document's active element.
<ReactTable
    ...
    onSortedChange={(c, s) => { document.activeElement.blur() }}
    ...
    />

Hope this helps others!

Any news on that PR? I still have the Issue in 6.8.2

Add this to your CSS:
.ReactTable .rt-thead [role="columnheader"] {
outline: 0;
}

I updated react-table which didn't work and I couldn't figure out how to add Mikkel-Vagn's css in without hardcoding it into the module files. This works for me though.
getTheadThProps={() => {                  return {                    style: {                      outline: 0,                    }                  };                }}

Following on from @cedricholz comment, incase this is of any use to anyone - I had grouped table headers, so used the getTheadGroupThProps function also:
getTheadThProps={() => { return { style: { outline: 0, } }; }}
getTheadGroupThProps = { () => { return { style: { outline: 0, } }; }}

.ReactTable .rt-resizer{   display:inline-block;   position:absolute;   width:3px;   top:0;   bottom:0;   right:-1px;   cursor:col-resize;   z-index:10 }
did the trick. it reduces the size of the table column resizer.


Add drivers for SSD1327 and the SSD1351.

Add color display driver and OLED color display driver / template. These are closely related to the display and OLED display driver. Updated daisy.h to include the color driver and the OLED color driver. The hardware interface is identical to the black / white driver.
The SSD1327 driver is configured for 128x128. It supports 16 gray scale level. Each pixel is 4-bits.
The SSD1351 driver is configured for 128x128. It supports 64k color. Each pixel is 16-bits (565 color).
The main addition to the black / white driver is the concept of a foreground / background color. All other calls remain the same.
These device drivers are a v1 status. I want to add image processing and change the SPI transaction to DMA.
These drivers were tested with these two OLED displays:
SSD1327: WaveShare OLED
SSD1351: WaveShare OLED

Awesome! Thanks for the contribution!


Feat: add tests for ProductController

Ok, but you need to thing abaut use many calls controller into one test


Incomplete self-relation leads to prisma format causing confusing error message

This is a writeup of what happened in https://github.com/prisma/prisma/discussions/11140

Create this schema:
datasource db {
  provider             = "mongodb"
  url                  = env("DATABASE_URL")
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["mongoDb"]
}

model Comment {
  id       String @id @default(dbgenerated()) @map("_id") @db.ObjectId
  children Comment[] @relation(name: "children")
}

Running npx prisma validate shows this error message:
C:\Users\Jan\Documents\throwaway\11088>npx prisma validate
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Error: Schema parsing
error: Error validating field `children` in model `Comment`: The relation field `children` on Model `Comment` is missing an opposite relation field on the model `Comment`. Either run `prisma format` or add it manually.
  -->  schema.prisma:13
   |
12 |   id       String @id @default(dbgenerated()) @map("_id") @db.ObjectId
13 |   children Comment[] @relation(name: "children")
14 | }
   |

Validation Error Count: 1

Running npx prisma format then returns this error message:
C:\Users\Jan\Documents\throwaway\11088>npx prisma format
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Error: Schema parsing
error: Error validating: A self-relation must have `onDelete` and `onUpdate` referential actions set to `NoAction` in one of the @relation attributes. (Implicit default `onDelete`: `SetNull`, and `onUpdate`: `Cascade`) Read more at https://pris.ly/d/cyclic-referential-actions
  -->  schema.prisma:14
   |
13 |   children  Comment[] @relation(name: "children")
14 |   Comment   Comment?  @relation("children", fields: [commentId], references: [id])
15 |   commentId String?   @db.ObjectId
   |

Validation Error Count: 1

As visible in the error message, the schema was updated to have this full relation definition:
children  Comment[] @relation(name: "children")
Comment   Comment?  @relation("children", fields: [commentId], references: [id])
commentId String?   @db.ObjectId

Which then indeed triggers the cyclical relation error message: https://www.prisma.io/docs/concepts/components/prisma-schema/relations/referential-actions/special-rules-for-referential-actions#self-relation-sql-server-and-mongodb
As the user does not actually have that relation in their schema file, it is hard for them to fix it via adding onDelete: NoAction or similar.

If you create the following model from the beginning, the error message makes sense is actionable:
model Comment {
  id       String @id @default(dbgenerated()) @map("_id") @db.ObjectId
  parentId String
  parent   Comment?  @relation(name: "children", fields: [parentId], references: [id])
  children Comment[] @relation(name: "children")
}

turns into
model Comment {
  id       String @id @default(dbgenerated()) @map("_id") @db.ObjectId
  parentId String
  parent   Comment?  @relation(name: "children", fields: [parentId], references: [id], onUpdate: NoAction)
  children Comment[] @relation(name: "children")
}

Tested with 3.8.0

Updated base schema for current versions:
datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
}

model Comment {
  id        String    @id @default(auto()) @map("_id") @db.ObjectId
  children  Comment[] @relation(name: "children")
}

prisma validate:
PS C:\Users\Jan\Documents\throwaway\1483> npx prisma validate --schema prisma/11176.prisma
Environment variables loaded from .env
Prisma schema loaded from prisma\11176.prisma

Error: Prisma schema validation - (validate wasm)
Error code: P1012
error: Error validating field `children` in model `Comment`: The relation field `children` on model `Comment` is missing an opposite relation field on the model `Comment`. Either run `prisma format` or add it manually.
  -->  prisma\11176.prisma:12
   |
11 |   id        String    @id @default(auto()) @map("_id") @db.ObjectId
12 |   children  Comment[] @relation(name: "children")
13 | }
   |

Validation Error Count: 1
[Context: validate]

Prisma CLI Version : 5.14.0

Using the VS Code extension's "Format Document", we get to the following formatting result:
model Comment {
  id        String    @id @default(auto()) @map("_id") @db.ObjectId
  children  Comment[] @relation(name: "children")
  Comment   Comment?  @relation(fields: [commentId], references: [id])
  commentId String?   @db.ObjectId
}

This is another instance of https://github.com/prisma/prisma/issues/18599, as the available name: "children" from the children backrelation is not used in the generated Comment relation. If it was, the schema would be more valid and could trigger the correct cyclical relation error message:
model Comment {
  id        String    @id @default(auto()) @map("_id") @db.ObjectId
  children  Comment[] @relation(name: "children")
  Comment   Comment?  @relation(name: "children", fields: [commentId], references: [id])
  commentId String?   @db.ObjectId
}


chore: adding ggshield-admins team as codeowner

Adding team as codeowners of the repo, to then add a branch protection rule on main requesting a review from codeowners.

I'm not sure we should add ggshield-admin to the codeowners. This group is about 10 people, who from what I understand would be notified for every PR on this repo. WDYT ?

I'm not sure we should add ggshield-admin to the codeowners. This group is about 10 people, who from what I understand would be notified for every PR on this repo. WDYT ?

I think that maybe there are too many people in the group and we should keep only the team. @agateau-gg , what do you think?

@gg-jonathangriffe I just updated team members, let me know what you think

It seems reasonable now. It's good for me, I'd like to get @salome-voltz 's opinion though.


Fixing the body content

There is white space on the left side of the page body and therefore website scrolls horizontally

please assign this issue to me

@ayushseth07 this is happening because the website is not responsive and you are watching it in tab view I guess.

@ayushseth07 but there is no problem on my system I mean  no space.


fix: Update sqlite dialect to allow RETURNING clauses

Closes: https://github.com/doug-martin/goqu/issues/358

Returning clauses supported since SQLite 3.35.0 (2021-03-12).


add grpc broker.

This PR introduces a gRPC message broker, enabling the Maestro agent to subscribe to resource specifications and publish resource statuses, similar to how an MQTT broker operates.
depends on: https://github.com/open-cluster-management-io/sdk-go/pull/68

/assign @qiujian16 @clyang82 @skeeey

/ok-to-test

removed the multiple maestro server (grpc broker) instances for now in https://github.com/openshift-online/maestro/pull/157/commits/1083ec5ae48335075b8ea1868dd384722bc98ebb and added a TODO item for that, because it's not the required function for now and the implementation may impact other components.
/cc @qiujian16

LGTM


implementation of net$Socket class in lib/node.js file

net$Socket is now implemented accordingly to nodejs documentation, tests are passing locally

@facebook-github-bot shipit


Expire locks

The JdbcPartitionManager does not expire locks. In case of an application shutdown, they need to be removed manually.

@alnkpa Is this still an issue for you or did you migrate to the subscription api? I just heard that the nakadi team would actually like to deprecate the low-level api.

Closing, the suggestion is to move to the subscription api


Function triggered by a file arriving on SFTP

This particular example is triggered by a HTTP call - where could I see an example involving SFTP and function triggered by a file arriving SFTP
thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e656bde5-b5d8-8d80-b7b3-ab430e57613e
Version Independent ID: 329eb12f-7302-4ecf-c1bf-a50ba3f34bdf
Content: Create your first function in Azure with Java and Maven
Content Source: articles/azure-functions/functions-create-first-java-maven.md
Service: azure-functions
GitHub Login: @rloutlaw
Microsoft Alias: routlaw, glenga

@jnsunkersett
See the documentation which states:

The External File bindings are experimental and might never reach Generally Available (GA) status. They are included only in Azure Functions 1.x, and there are no plans to add them to Azure Functions 2.x. For scenarios that require access to data in SaaS providers, consider using logic apps that call into functions. See the Logic Apps File System connector.

Java functions are not supported in runtime 1.x. Please check language and run time support here.
To automate tasks that monitor, create, send, and receive files on a Secure File Transfer Protocol (SFTP) server, you can build and automate integration workflows by using Azure Logic Apps and the SFTP connector.

@jnsunkersett Checking in to see if the above post helped answering your question.

@jnsunkersett Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


InModule.Help.Exceptions.ps1 efficiency

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[x] feature
[ ] bug:

Details
InModule.Help.Exceptions.ps1 is by far the longest running test in our collection. Can someone take a look and make it faster?

Perhaps @FriedrichWeinmann or @niphlod

that was always a sore point, by far it's the one that shows best "piping" limitations of powershell (just because pester leverages it a lot). We can surely do best, I'll make a note to inspect it properly.


added osgi bundle metadata generation for blueprints-core

Thanks for the PR, but will not merge for the reasons described in:
https://github.com/tinkerpop/blueprints/issues/524


G cloud 8 supplier declaration - Cath training with Tom

Initial changes for the G-Cloud 8 supplier declaration made during training with Tom

Looks good :+1:


Trying to fix a platform issue with windows line ending

Uniformazing the line ending in the project to avoid issue
with windows.
Fix #45 and Fix #39

IMHO we should always outputting with \PHP_EOL.

The problem is that you can only reliably split on "\n" and if you sometimes output code using PHP_EOL then you will leave some "\r" randomly in the output on windows. I don't know if it could cause issue though.

Ping @weierophinney

IMHO we should always outputting with \PHP_EOL.

The fact that this generates different code on windows and on proper operating systems (:trollface:) is already a show-stopper for using \PHP_EOL.
I think the fix is legit, but we need to check if the tests need some changes too. @mikeSimonson did you check if these modified paths are covered by tests that expect "\n" or \PHP_EOL?

The fact that this generates different code on windows and on proper operating systems (:trollface:) is already a show-stopper for using \PHP_EOL.

This is the general idea. For example: Outputting to the files according to operation system sound reasonable. When collaborating with files we have 'converters' etc.  or maybe the better is using one proper operating system :)
In this case using PHP_EOL prevent us from bug observed on Windows machines during composer install
    $lines = explode(PHP_EOL, $body);

Nothing more is need it to fix this bug.

Outputting to the files according to operation system sound reasonable.

No, ZF in general has a "no dependency on configuration/environment", nor "modification of environment" policy.
The components should behave in the same way regardless of the OS. Generated code is considered an output.

@Ocramius Do I need to change anything ?

@mikeSimonson I'd need you to just check whether any tests are still relying on PHP_EOL. They should all verify only \n line-endings.

@Ocramius I think its fixed. There is only one reference left to PHP_EOL in this file. The test pass if it's uncommented and converted to \n. Should I add that too ?
The failure is only related to an update of phpcs. I am looking into the rule that need to be set to remove the failures.

@mikeSimonson thanks

@weierophinney Thanks


Add Dokka documentation to artifacts

This PR adds Dokka-generated documentation as a publish artifact.
It is done by using functionality introduced in this PR in config.
Also, while updating the config, the outdated groovy directory was removed.
Important details
In the 2.11.0 version of error_prone_core, they broke their contract which lead to a compilation error. To resolve this issue the previous version was forced.

Vulnerabilities regarding Dokka dependencies can be fixed only by adding dependency constraints in the config repository because it is a transitive dependency of the precompiled script dokka-for-java.
The vulnerability of error_prone_core is not relevant as this dependency is forced to 2.10.0 which uses 30.1-jre with no mentioned vulnerabilities.


[Backport 2.10] Improved validation for tolerations / affinity agent customization

Backport for https://github.com/rancher/rancher/issues/47703

Closing the backport as the main issue got deprioritized; will open backports as needed if it gets prioritized again.


Issue running define-env with a value that has a space on CI

On CI (docker unix image but I'm able to reproduce on windows Powershell), I'm using this tool like that:
flutter build web $(flutter pub run define_env -f "env/.staging.env")
Everything is working fine if .staging.env file doesn't contains space but it's failing each time there is one (KEY="VALUE WITH SPACE" for example)
It's exactly the same than that issue: https://github.com/flutter/flutter-intellij/issues/4588. After some investigation, I think I understand why, but can't figure out how to fix it. The output of the command in interpreted as a string, and the flutter build/run command is not working fine in these cases.
Relevant working samples:
flutter build web --dart-define=KEY1=VALUE1 --dart-define=KEY2="VALUE2 WITH SPACE"
flutter build web '--dart-define=KEY2="VALUE2 WITH SPACE"'
flutter build web '--dart-define=KEY1=VALUE1' '--dart-define=KEY2="VALUE2 WITH SPACE"'
Relevant NOT working samples:
flutter build web '--dart-define=KEY1=VALUE1 --dart-define=KEY2="VALUE2 WITH SPACE"'
=> output "Target file "WITH" not found."
The thing is I'm not sure I can raise an issue to flutter team as the command line argument is not designed to be inserted between quotes. I think the real issue is on the way "define_env" is outputing the result.

It seems there is now a native way to "define-env" from file (https://github.com/flutter/flutter/issues/107810).
I will have a look at this feature and may switch to it!

So it looks like the variables not being expanded properly
Can you try the following
flutter pub run define_env -f "env/.staging.env" | xargs flutter build web

Also thanks for pointing out the native way for doing this.
I will reevaluate how define_env can be used once lands in stable, which might take another month or so.

I'm now using "--dart-define-from-file" with JSON file (available since Flutter 3.7.0) and I'm no longer using define-env.
Thanks anyway, it was very helpful!


NVSHAS-9440: support separate network mode and Process and File mode …

…in CRD (cli)

I had review discussion with william, approve this PR


chore(nvim-treesitter): update get_parser_configs with ssh preference

I do some simple tests, I think it won't cause issues. But still, please examine it.
refer to #313

Sorry for adding a non-related commit in this issue, forgot to open a branch for it. 😂