[wip] Version secret upload

What this PR solves / how to test
Fixes #[insert GH or internal issue number(s)].
Author has addressed the following

Tests

[ ] TODO (before merge)
[ ] Included
[ ] Not necessary because:

E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)

[ ] I don't know
[ ] Required / Maybe required
[ ] Not required because:

Changeset (Changeset guidelines)

[ ] TODO (before merge)
[ ] Included
[ ] Not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s):
[ ] Not necessary because:

Screenshots
Version in dash

Not deployed latest version

Partially rolled out latest version

Fully rolled out latest version

Know you're still polishing up so ignore if these are on your to-do:

Only thing that should be updated / evaluated with the wrangler versions secret put command is secrets. Wrangler.toml warnings should not be shown

Copy when creating a new secret:

npx wrangler versions secret put <KEY> ? Enter a secret value: › *** 🌀 Creating the secret for Worker worker-name ✨ Success! Created version XXX with secret FOO. ➡ To deploy this version with secret FOO to production traffic use the command wrangler versions deploy.
Deleting a secret should reflect similar copy.
Nice one with the automated versions message! Can we add one on delete of a secret too?

Looking great. Some more feedback:

Nit: Can we add a space between ➡ and "To"

Forgot the flag in the copy
➡ To deploy this version with secret new-secret to production traffic use the command wrangler versions deploy --x-versions.

Not seeing the version message populated anymore (I did wrangler secret put)

wrangler secret list is showing warnings (similar to #1 in my message above)

Not seeing updated output for wrangler versions view. Also shows the warning.

Know this has already been merged but I have feedback:
1. Rollback guardrail: If we detect that a user is rolling back to a version that has a different value for a secret, we should warn the user but give them the option to proceed anyway:
I set up a case to hit the guardrail and wrangler is getting stuck here:

It isn't until I cancel the operation that I see the warning

Also, this is what I'm seeing in dash:

We need a popup window rather than a banner.
2. I want to make the next step after wrangler versions secret put/delete clear to users and the best way to do that is to have “To deploy..” on the next line
Instead of:

This:

Can we add back the automatic version message when a secret has been updated? Currently the version message is blank

Reminder to implement wrangler versions view updates


Update links to blog posts in service standard and What's new

Georgina has carried out a review of links: Review Links in the Service Standard Pages #1144
Task:

[ ] Update links and publish in service standard and What's new
[ ] Bring all links in service standard into line with link style, i.e. include website name in link for external sites

I've done links for service standard point 1. I'll come back to the others. Here's the list of links in Confluence: https://nhsd-confluence.digital.nhs.uk/display/SMDS/Service+Standard+Guidance+Links+Review.

I'm going to put this back to the backlog for a few weeks while I finish off actions for April Style Council.


Any additional suggestion about performance ?

Do you have any additional suggestions on how to optimize performance apart from what you wrote in the article?

What performance issues are you having?

I have a Azure DTU based database with 200DTUs. This is my typical scenario. The query takes: CPU time = 2235 ms,  elapsed time = 1133 ms.
I tried:

convert the float to real. The size of the storage is less, but the performance is unchanged.
I 'quantized' the float to an int16. Same results of #1
I tried to calculate the vectors out of the json using only the table 'wikipedia_articles_embeddings', but the performance are horrible.
I tried to calculate the vector stored as a concatenated string, splitting it with STRING_SPLIT. Same as #3
I tried to increase the compression of the column store with: DATA_COMPRESSION = COLUMNSTORE_ARCHIVE. No changes in the performance

I would like to have at least the double of the performance. My concern is related to the storage and the number of the users connected to the db. 25000 articles are a good amount of data for my use case, but I can't exclude that they become more, and I'm assuming that the performance is inversely proportional to the number of articles.

I am considering expanding the use of SQL Server for my production application, which is an RAG platform with about 80,000 pages of data. Our application's data needs are growing, and we're exploring options to increase our storage capacity significantly.
Given that SQL Server is our favorite DB, I'm interested in exploring it as the layer that stores the vector embedding from our data.
Did you have success in optimizing performance?
Any insights or lessons learned from your experience would be greatly appreciated, especially if you've navigated similar challenges.
If you decided not to use SQL Server for storing vectors, I would love to learn why.
Thank you.

Yes, I'm still using the SQL and I did a lot of tests and improvements.
First as I mentioned above converting from float to real, gave me a 3.2X performance.
Then I notice that the kernel memory is adding to many layers and abstractions, so I extracted the code for my use case. I can't tell you exactly, but this was the biggest improvement in performance and code maintenance.
Another rule: do not mix 'row query' with 'column query': when you query a table with the column store, it must be a pure table scan.
Then optimise the embedding. I strongly suggest to take a look to the new text-embedding-3-large/text-embedding-3-small. They supports 'shortening' meaning that you can reduce the size of the vector finding the best balance performance/accuracy.
Feel free to contact me also privately if you need more info


index.js not loading in website

The index.js is not loading in the page (https://stylis.js.org/) and the output is not being generated.

fixed


Segfault when replacing net destination in python API

Describe the bug
When running a script in the python console that replaces (remove and add) the connection to nets on one pin, HAL crashes with a segfault.
To Reproduce
Steps to reproduce the behavior:

Open any netlist with at least one gate
Get the ID of any net with at least one destination
Run the following script:

net = netlist.get_net_by_id(ID_FROM_EARLIER)
g = net.get_destinations()[0]
net.remove_destination(g)
net.add_destination(g.get_gate(), g.get_pin())

Expected behavior
HAL should not crash. Visually/technically, nothing should happen, as we're replacing the net with the same net in this example. This is used in practice for replacing the input of one gate with a different net.
On that note, it might be helpful if some additional info for the requirements of add_destination would be listed in the documentation. For example, that the destination endpoint should not have an existing connection, which would need to be removed before like this.
Desktop (please complete the following information):

OS: Windows 10 => WSL with Ubuntu 22.04
Version: 4.2.0-269-g8e8d384d1

Additional context
Might be required in the Project 4 of the Hardware-Reverse-Engineering course held at RUB.

In your script g is the endpoint of the net you are about to remove. Please keep in mind that you cannot extract any information from that endpoint after removal.
After the following modification your script works for me (ep = EndPoint, g = Gate, pn = Pin)
net = netlist.get_net_by_id(34)
ep = net.get_destinations()[0]
g = ep.get_gate() # get gate before removing endpoint
pn = ep.get_pin() # get pin before removing endpoint
net.remove_destination(ep)
net.add_destination(g,pn)


Bugfix, renaming arguments

Hi Marios,
I implemented the changes we discussed and added a handful of basic tests. I searched the other files for usages of dim, but please have a look on your own to see if I missed anything.
Let me know if there is anything you are missing.
Best,
Lukas

Hi @code-lukas. Thanks a lot for preparing the MR, I added some comments :-) The overall code looks good.
I would also suggest to run all tests as some are failing e.g. with pytest .. They should be fixed though if you make some of the suggested changes (on the default value of n_components).

I made some adjustments to accommodate your changes @koulakis. All tests ran green in my pre-commit, same with the latest commit. I added some tests for the default functionality if no arguments are specified. The only 'shortcut' I had to take was to set n_components = 2 in the constructor and not immediately in the method signature as I would otherwise be unable to differentiate between a user-specified n_components = 2` and the default.

That was fast! I like the solution of defaulting to 2 only if both values are none.
One last nitpick, could you please change in line 99 of the projector code the type of n_components from Union[int, None] to Optional[int]? Then we can also completely remove the import of the Union type as it is not used anywhere else.

Slipped right by me, thanks for the heads-up! Should be fixed now


Change default events for Batch to 25 from 250

Closes #???
Description
Changes number of blocks a worker will fetch.
The maximum block range was recently changed from 250 to 25 because too many requests were causing the ENs to crash on testnet. This fix addresses that by changing the default value for the number of blocks each worker will fetch from 250 to 25.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report

Merging #397 (76e889f) into master (ff1f8b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   55.33%   55.33%
=======================================
  Files          36       36
  Lines        1874     1874
=======================================
  Hits         1037     1037
  Misses        707      707
  Partials      130      130

Flag
Coverage Δ

unittests
55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1f8b1...76e889f. Read the comment docs.


chore(deps): improve monerod docker builds

Description
Bump monerod release, split AMD64/ARM64 envs, healthcheck and move binary
Motivation and Context
Remove double version envs - Part of the fix for docker tag version label
How Has This Been Tested?


eip7594: Remove proof parameter from recover_cells_and_kzg_proofs

This removes the proof parameter from recover_cells_and_kzg_proofs since computing individual proofs is only favourable when there are one to five cells missing. Since most clients will start recovery when half of the cells are missing, this functionality would not be useful in practice for our usecases.
We could leave it there, ignore it and have implementations decide, but note that we do need to validate the proofs are valid according to the current API, so its not free.
This means we are essentially validating the proofs twice, since a user should only pass in proofs + cells that they have passed to verify_cell_kzg_proof beforehand. It is not a security concern if these proofs are not validated since the receiver will validate them, but given that fk20 takes about 200ms to compute all of the proofs on a single thread, I don't think it makes sense to try and optimize for the seemingly rare case of one to five missing cells/proofs

One possible blocker for this PR, is the time it takes to now compute all of the proofs. Before it was only computing the missing proofs.
This is a possible blocker because it increases the CI time.
cc @hwwhww


reference persistence forecast implementation

Hard to believe that persistence forecasts could be this complicated, but here we are.
The only testing I've done is to verify that index_persistence runs and produces the right output for a handful of inputs.
It would be worthwhile to get some feedback on the design before putting too much effort into testing. You'll find a handful of comments and questions in the diff.
Eventually closes #53.

@alorenzo175 can you give this a high level review?

I cleaned up the code and checked that persistence and index_persistence do the right thing. See this gist with examples: https://gist.github.com/wholmgren/3e983c8e465e17e316038ac5a9574c52
My implementation is frustratingly non-trivial because:

Observations can represent beginning labeled intervals, ending labeled intervals, instantaneous measurements.
The index persistence should account for changing solar position during interval averages.
The persistence quantity can be either a scalar or an array depending on what you want.

The functions in persistence.py are fairly general, while the run function in main.py makes choices based on the observations and forecast.
Still needs real tests.
@cwhanse it would be helpful for you to review this in detail.

The documentation helps greatly @wholmgren I understand what window does.  I'll complete the review

Great. I can set up the readthedocs build for the branch in an hour or two.

Here's a link to the rendered docs: https://wholmgren-solarforecastarbiter-core.readthedocs.io/en/benchper/reference_forecasts.html

Code and example notebook updated to reflect the discussions above. persistence.py now has 3 persistence functions: persistence_scalar, persistence_interval, and persistence_scalar_index. I've not implemented the 4th, persistence_interval_index because I don't think it's very useful.
The API and the code in these more specific functions are more clear than they were in the previous general functions. And I am more confident that they are correct. The downside is that it takes a little more work to glue them together in run_persistence, but I think the trade off is net positive.

Updated the example notebook to use run_time. Appears to work as expected but we'll need real tests to be sure.

I added a lot of tests. They are not pretty but they get the job done.
I think the codecov/patch only fails because I renamed variables in the unrelated run function and this function isn't actually tested yet.

probably good to go once rebased on master

@alorenzo175 can you check the new changes related to load_data and session? Was surprised when the requests_mock worked the first time I tried it.


Adds Support for Apex Wallet as a Rainbow Wallet

This PR

Adds Apex Wallet as a custom Rainbow wallet so users can connect to PoolTogether using their Apex wallet.

Context

Hey! This doesn't build. It looks like this is a CommonJS package but our app only supports ESM at the moment. If you guys redeploy a new build and get test this out we can get it merged in.


[1812] Stop okcomputer logging

Context
Reduce the quantity of generated logs
Changes proposed in this pull request
Stop logging forom the okcomputer healthcheck
Guidance to review
Check logs for this review app in Logit
Link to Trello card
https://trello.com/c/bjfo0jo9
Checklist

[x] Attach to Trello card
[ ] Rebased main
[x] Cleaned commit history
[ ] Tested by running locally

 Onboard services to Logit.io


Look at data right where the spike happens

It is suspicious that we had two slightly different models (one with biases, one without), that both spiked at exactly the same moment. This suggests there might be a data issue.

Marking the items prior to Feb 29th as "closed".


Does not understand .mjs extension / script type

My index.html file has a script like <script type="module" src="./main.mjs"></script>
Bundler crashes because it can't find a createAsset plugin despite (1) mjs being a fairly common extension for JavaScript module files (2) the type="module" tag, which should identify this as Javascript.
deno run -A --unstable https://deno.land/x/bundler/cli.ts bundle index.html
Entry index.html
Error: No createAsset plugin found: 'main.mjs'
    at Bundler.createAsset (https://deno.land/x/bundler@0.8.1/bundler.ts:175:11)
    at async Bundler.createGraph (https://deno.land/x/bundler@0.8.1/bundler.ts:251:17)
    at async Bundler.bundle (https://deno.land/x/bundler@0.8.1/bundler.ts:621:19)
    at async bundleFunction (https://deno.land/x/bundler@0.8.1/cli.ts:38:41)
    at async Command.bundleCommand [as fn] (https://deno.land/x/bundler@0.8.1/cli.ts:88:3)

multiple extensions are now supported and should be processed correctly with the next release.


What's the license?

We want to use this project, but we have not found any license information.
Could you offer the license please?
Thx.

Thank you for your attention. I have commit a Apache-2.0 license to use.


Update README.md and documentation

[ ] Change the example how to extend inside README.md
[x] Update the API with addClass(), removeClass() and toggleClass()
[ ] Improve the visual format of the wiki pages, see how jQuery's does it
[ ] Each method should have it's own wiki page
[x] Create a custom sidebar menu

The browser support is outdated related to IE9+ ... jBone actually needs 11+
Since IE10: https://developer.mozilla.org/de/docs/Web/API/Element/classList
Since IE11: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset
I suggest that we add a Polyfill section to README.md to make jBone work with IE9!
https://github.com/remy/polyfills/blob/master/classList.js
https://github.com/remy/polyfills/blob/master/dataset.js
Maby I'm missing a couple more unsupported features, you know jBone better.


Create landing page for "History"

Created the issue to backup the current text about the history for a future implementation into a dedicated landing page.

Xenko was originally started by Silicon Studio, a technology and services company of 300+ employees founded in 2000, dedicated to driving entertainment forward. Silicon Studio develops world-class products to help developers maximize the potential of leading-edge digital media technology.
In 2018, Xenko was transformed by Silicon Studio into an independent project, driven by an open-source community.
In 2020, the project formerly known as Xenko took on a new identity as Stride.
Then, in May of 2021, Stride proudly became a member of the .NET Foundation.

We can also link it just from the footer and interlink from other places if needed . No need to promote it in the top navigation.


New issues encountered in version 2.0.1

1.标题栏，左侧录屏按钮和中间空白处透明度不一致，希望可以调整成一致的透明度。此外，应用放大后录屏按钮会在最左边，中间会留下较大的空白，希望可以修复一下这个界面设计bug
The transparency of the title bar, the left screen recording button and the middle space is inconsistent. Please adjust it to the same transparency. In addition, after the application is enlarged, the screen recording button will be at the far left, leaving a large blank in the middle. I hope to fix this interface design bug

2.标题栏在非活动窗口下显示（控制窗口的按钮）希望可以调整为winWindows 11的设计风格，目前仍然使用的是Windows 10的风格（非活动窗口下带有颜色）。
2. The title bar is displayed under the inactive window (the button that controls the window). I hope it can be adjusted to the design style of winWindows 11, and currently I still use the style of Windows 10 (with color under the inactive window).

3.真诚的希望添加多语言支持
3.Sincerely hope to add multilingual support.
4.当捕获全屏时，显示屏幕没有任何东西。
When capturing full screen, the display screen is empty.

Hi @Gaoyifei1011 thanks for creating this ticket.

The idea is to have two different acrylic surfaces to differentiate them. I actually don't understand why you see nothing in between, the ideas would be to show recorded videos there. I attach a screenshot

Thanks, I'll try to fix this

Multilingual support is already present, feel free to translate the app here https://github.com/MarcAnt01/Fluent-Screen-Recorder/blob/master/translations.md

This is a Windows 11 bug, I'll try to reach out the team working on this feature

好吧。关于问题一，我可能错误的理解了您设计的意图。但是就我个人而言，我希望您能够微调一下。如果本地已经有录好的视频，希望可以显示一下本地录好的视频文件。如果没有的话，希望增加一个“您没有录取的视频”这类的提示语言。
All right. As for question 1, I may have misunderstood your design intention. But personally, I'd like you to tweak it. If a local video has been recorded, you want to display the local video file. If not, I hope to add a prompt language like "videos you did not record".

@Gaoyifei1011 in theory the section in the middle shouldn't be visible at all if no videos have been saved, not sure why this isn't happening

我个人估计应该是这个程序设计的时候，没有考虑到没有视频的情况下中间部分的显示问题，希望未来能够优化一下代码，中间页面做一个判断。在没有视频的情况下中间页面是不显示的。


Remove empty subproject build configuration

Context
There're two subprojects not configured properly, which results in pointless build configurations.

Thanks @wolfs !


Group By when joining HasMany

Hello,
shouldn't the groupBy be added when the relation is HasMany?
From:
if ( ! $this->selected && count( $relations ) > 1 ) {

To:
if ( ! $this->selected && ( count( $relations ) > 1 || $relatedRelation instanceof HasMany ) ) {

Edit:
Or maybe just add a distinct?

groupBy  is always added when at least one relation is joined
count( $relations ) > 1
so groupBy  is already applied for HasMany

if you want remove additional grouping:
$query->getQuery()->groups = array_filter($query->getQuery()->groups, function ($e) {
    return $e !== 'table.id'; // table.id is the group you want to remove
});


Avoiding LSP formatting conflicts

Hello,
How can I force a lsp server on file save ? For example, formating by default with null-ls on my go files.
I tried to add this lines but without success :
https://github.com/jose-elias-alvarez/null-ls.nvim/wiki/Avoiding-LSP-formatting-conflicts

Thanks for help !
Regards

gopls format capacity should be disabled.
e.g in go.nvim, you can set  lsp_document_formatting = false
In navigator, you can also disable with
      disable_format_cap = { "gopls"  }

Thanks.
It's not already there ?
https://github.com/ray-x/nvim/blob/69b2d2d6649806e2af0048e376aed6239f7a800f/lua/modules/lang/config.lua#L307
https://github.com/ray-x/nvim/blob/69b2d2d6649806e2af0048e376aed6239f7a800f/lua/modules/lang/config.lua#L393

It's ok now ! Thanks a lot.


Skip pinot.admin.system.exit check for quickstart

Description
QuickStart commands starting using bin/pinot-admin.sh QuickStart -type XXX will exit once the table is bootstrapped.
This is extremely annoying when running pinot from docker.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

cc @kkrugler


Bendford py last 2 digits

I have performed every other bendford test but this one requires decimal values:
Last Two Digits Test
L2d = bf.last_two_digits(orders["Order_amount"].astype(int), decimals=1, confidence=99)
Warning
C:\Users\cgarciadiaz\AppData\Local\Continuum\anaconda3\envs\Supplier_DTEC\lib\site-packages\benford\benford.py:471: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame.
Try using .loc[row_indexer,col_indexer] = value instead
See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
temp['L2D'] = temp.ZN % 100

Thanks Conny,
This is a Warning pandas sometimes throws, despite the code is not doing what it is complaining about.
I will create an issue to disregard it in production versions of the library.
Anyway, I have not seen this influence the test performance. Did it prevent you from getting the results or showing the plot?
The decimals parameter is a way to make the function aware of the data decimal places, like 2 in case of money, or 0 if integers.


ERC6551 implementation

This PR revamps HatsWallet to use (un-finalized) ERC6551 standard

FYI the gas report diff check is expected to fail since the main branch doesn't yet have a gasreport.ansi file against which to compare


Update test framework

Related issue(s):
No related issue.
Description:
This PR adds various updates to the testing framework.
Problem(s) & goal(s):

There's now a testing package which holds the logic related to the relay mocking and helper methods which are used in the tests.
The relay mock is now more generic : each relay holds its own key-pair and each of the response is signed properly by the associated key at compile-time.
Helper methods have been tested.
The relay entry method have been tested.
There's a new backend package, leaving the responsibility of implementing the backend's interface to the server package. Regardless of the REST framework used to implement the server, backend holds a "common" interface for the backend. Some of the server values such as the endpoint paths are used by the testing framework.

Additional comment:
It is also possible to remove the testing package and keep the updates made to the test framework in the server package.
If the project is not aimed to be very large, this could be an option to consider as it is always possible to refactor this later on.

I have run these commands:

[ ] make lint
[ ] make test
[ ] make run-mergemock-integration
[ ] go mod tidy

Codecov Report

Merging #135 (7e9b367) into main (bd6b2c1) will decrease coverage by 10.90%.
The diff coverage is 44.25%.

@@             Coverage Diff             @@
##             main     #135       +/-   ##
===========================================
- Coverage   67.76%   56.86%   -10.91%
===========================================
  Files           5        6        +1
  Lines         515      517        +2
===========================================
- Hits          349      294       -55
- Misses        133      198       +65
+ Partials       33       25        -8

Flag
Coverage Δ

unittests
56.86% <44.25%> (-10.91%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/testing/relay.go
27.61% <27.61%> (ø)

internal/testing/types.go
100.00% <100.00%> (ø)

server/relay_entry.go
84.21% <100.00%> (ø)

server/service.go
74.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6b2c1...7e9b367. Read the comment docs.

First off, thanks and great work!
I'm not against separating the testing but if there's no simple cli flag then perhaps better put it all together into the main package and keep the coverage high 🙂

I like it a lot 👍


Bug Report: Stage crashes the game

If you replace the dad with anyone else via the debug menu, the game crashes.

same on every other song

no?
On the latest version its fine.
https://user-images.githubusercontent.com/26305836/116465876-a9705d80-a822-11eb-9545-1a353061891d.mp4

This issue only happens to me on web, desktop is fine.

p sure this is an issue with the base game html5 as well. since this would be a preloading issue.


Updating Jamie's info.

This is an update of my info.

Hey Jamie! Could you submit this PR to the Directory repo instead? I will then use a subtree to pull it into this repository. This enables everyone to sidestep having to clone the entire Jekyll repo and running Jekyll locally. You can also add an image to the Directory Images repo as well if you'd like.

Will do.
On Sun, Jul 1, 2018, 9:12 PM Alex Pawlowski<EMAIL_ADDRESS>wrote:

@alexpawlowski requested changes on this pull request.
If you could send this PR instead to the Directory repo that would be
awesome! (Hopefully it will also make it easier to contribute to in the
future)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/KnoxDevs/knoxdevs.github.io/pull/22#pullrequestreview-133473431,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfthaMBbZfuDDEe9WOU1QYzVdrDbcJAks5uCXOSgaJpZM4U-gxh
.


feat: Use a map and reduce approach to personality routing.

Is your feature request related to a problem? Please describe.
As a user, I have to pick the personality to respond.
Describe the solution you'd like
I'd like all the personalities to fire concurrently, and then have an agent pick from the best responses.
A simple version inspired by Tree of Thought
Describe alternatives you've considered
The current "routing" layer uses regex. This is certainly an unnecessary optimization.
However, one advantage is that certain models have differing average latencies for response.
In this case, perhaps it would be ideal to start all the personalities, and then as responses come in, decide whether it's worth waiting for the others.

This was delivered in #42


fix: throttle fractional indices validation

throttle the validation on scene updates and during reconciliation, to be performed at most once every minute (so that we could sleep a bit more calmly)
ignore error logs when it's expected to fail (~ in tests and syncMovedIndices)

see: Duplicate bound arrow with only one end bound throws error originating from Throttle Fractional indices #8315

sorry... false alarm, the issue is unrelated to this PR, also unrelated to elbow connectors. Looking for the last good build without this error. #8315


[Bug] Inverted definition in PlutoGridSelectingMode

I think that you inverted the definition in PlutoGridSelectingMode, you changed the PlutoGridSelectingMode.row with PlutoGridSelectingMode.cell
The image of demo code:

A sample image of "row" mode selection(but is working as cell) in the first grid:

A sample image of "cell" mode selection(but is working as row) in the second grid:

The demo code if you want to dowload:
pluto grid example.zip

@Lorenzobettega
selectionMode is the mode for selecting cells or rows.
Tap and hold to move the mouse or select a cell or row with Shift + Arrow keys.

@bosskmk the problem is that PlutoGridSelectingMode.row selects cells and not rows

And PlutoGridSelectingMode.cell selects rows and not cells. Something is inverted on the code

@Macacoazul01
There seems to be no problem with the operation.
selectingMode selects a cell or row.

Widget build(BuildContext context) {
  return Scaffold(
    body: Container(
      padding: const EdgeInsets.all(15),
      child: PlutoDualGrid(
        gridPropsA: PlutoDualGridProps(
          columns: columns,
          rows: rows,
          onLoaded: (e) {
            e.stateManager.setSelectingMode(PlutoGridSelectingMode.row);
          },
        ),
        gridPropsB: PlutoDualGridProps(
          columns: columnsB,
          rows: rowsB,
          onLoaded: (e) {
            e.stateManager.setSelectingMode(PlutoGridSelectingMode.cell);
          },
        ),
      ),
    ),
  );
}

The operation is ok. It works on both cases

The problem is that PlutoGridSelectingMode.row selects only one cell and PlutoGridSelectingMode.cell selects the cell with the row. It should behave the inverse way

PlutoGridSelectingMode.row assigns focus color to one cell with no selection.
When selected, the focus color is assigned to the selected rows.
PlutoGridSelectingMode.cell assigns focus color to one row with no selection.
When a selection is made, the focus color is assigned to the selected cell.
As I attached above, grid A is row selection mode and grid B is cell selection mode. As with the attached GIF, there is no problem in operation.

but don't you think that this behavior vs names confuses the dev?
We know what both options do because we're using the package for a while (and it's an awesome package), but for a new user it's not intuitive

This is intended to visually differentiate the current row or cell between unselected and selected states, depending on the selection mode.
In case of row selection, the focus color is set only to the current cell so that the user knows that no row is selected.
For cell selection, set the focus color to the current row so the user knows that no cell is selected.
If you have any other comments, please suggest them.

I undertood your point, but I agree with @Macacoazul01that this is confusing, I think that the solution is the option row only select rows, independent if you are with Shift or now, and cells the same logic. That is my suggestion,, thanks for listening, the question is solved.


Fix the directory iteration in prepare_speculos_args when looking for the main app in plugin mode

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (15a3774) 80.13% compared to head (979f446) 80.13%.

:exclamation: Current head 979f446 differs from pull request most recent head 353b8ed. Consider uploading reports for the commit 353b8ed to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   80.13%   80.13%
=======================================
  Files          34       34
  Lines        1691     1691
=======================================
  Hits         1355     1355
  Misses        336      336

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Validation of reactor component fails due to missing _start export

Hello. I played around with the cargo component and tried building a reactor component.
So I ran cargo component new --reactor ...
My world:
package component:request-component

/// An example world for the component to target.
world example {
    import wasi:http/incoming-handler
    import wasi:http/outgoing-handler

    export hello-world: func() -> string
}

When running cargo component build. I get the following error message:
error: failed to validate component output

Caused by:
    core instance 6 has no export named `_start` (at offset 0x3c55f1)

I understand this doesn't make that much sense since reactor components are not supposed to export _start functions.
My Cargo.toml:
[package]
name = "wasi-http-reactor"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
anyhow.workspace = true
cargo-component-bindings = { git = "https://github.com/bytecodealliance/cargo-component" }

[lib]
crate-type = ["cdylib"]

[package.metadata.component]
package = "component:request-component"
adapter = "../../adapter/wasi_snapshot_preview1.reactor.wasm"

[package.metadata.component.dependencies]

[package.metadata.component.target.dependencies]
"wasi:http" = { path = "../wasi-http/wit" }
"wasi:io" = { path = "../wasi-http/wit/deps/io/"}

Unfortunately, I cannot run the target file that the cargo component build builds since its a core wasm module. When I try to adapt it manually with
wasm-tools component new ./target/wasm32-wasi/release/wasi_http_reactor.wasm  --adapt ./adapter/wasi_snapshot_preview1.reactor.wasm  -o ./crates/wasi-http-reactor/wasi-http-reactor.wasm
I encounter the same error:
error: failed to encode a component from module

Caused by:
    0: failed to validate component output
    1: core instance 6 has no export named `_start`

What am I missing with these adapter components?

i used the wrong adapter file. sorry to bother you!


Class definition message shown by browser for a class with its superclass in Smalltalk may not be compilable

The Class Definition pane shows the class definition message for a class. If the superclass is in the Smalltalk namespace, it will be displayed using it's 'short name' (i.e. unqualified). However, the browser has set the compilation environment to be the namespace of the class itself (which is correct in other respects), but this may mean that the superclass identifier is not bindable as an unqualified name.
To Reproduce
Steps to reproduce the behavior:

Load the 'Scintilla View Generator' package (in the Core\Object Arts\Dolphin\IDE\Professional folder)
Open a class browser and find IntTypeReference
Bring up the context menu on the class, and choose 'Refactorings/Convert to Sibling...'
Press OK in the dialog that comes up without making any changes.
Switch to the class definition pane (IntTypeReference should still be selected).
Add a 'dummy' instance variable
Note that the AbstractIntTypeReference superclass is highlighted as undeclared, and the modified class definition cannot be saved.

Fixed by dc99865bffbeb1e09945cf8b416fbd8c7def8025


Add httpsoft tests

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Related tickets
-

Documentation
-

License
MIT

thanks, cool! looking at the test output, there seems to be one issue with stream setup, otherwise httpsoft passes all tests :+1: