Improve on Union performance

Description
In looking at our application which uses the dotnet Unleash client we found that a large amount of memory was being allocated by the client:

Looking at the callstack the Union call in DefaultUnleash.DetermineIsEnabledAndStrategy is what is allocating so many arrays. These allocations can be reduced by replacing the Union call with a preallocated HashSet (which is what Union uses).
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
The following BenchmarkDotnet code was used to validate that this was better performing:
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

var summary = BenchmarkRunner.Run<UnionExamples>();

Console.WriteLine(summary);

[MemoryDiagnoser]
public class UnionExamples
{
    const int Length = 1000;

    readonly IEnumerable<ExampleConstraint> first;
    readonly IEnumerable<ExampleConstraint> second;

    public UnionExamples()
    {
        first = Enumerable.Range(0, Length).Select(i => new ExampleConstraint { Id = i }).ToList();
        second = Enumerable.Range(0, Length).Reverse().Select(i => new ExampleConstraint { Id = i }).ToList();
    }

    [Benchmark(Baseline = true)]
    public int Union() => first.Union(second).Count();

    [Benchmark]
    public int Preallocate()
    {
        var unique = new HashSet<ExampleConstraint>(first);
        unique.UnionWith(second);
        return unique.Count;
    }

    [Benchmark]
    public int ConcatDistinct() => first.Concat(second).Distinct().Count();
}

class ExampleConstraint { public int Id { get; set; } }

With the results being:

Method
Mean
Error
StdDev
Ratio
RatioSD
Gen0
Gen1
Allocated
Alloc Ratio

Union
53.58 us
1.055 us
1.215 us
1.00
0.00
12.2681
4.0283
150.72 KB
1.00

Preallocate
45.31 us
0.666 us
0.713 us
0.84
0.02
5.4932
1.3428
67.35 KB
0.45

ConcatDistinct
64.52 us
0.762 us
0.712 us
1.20
0.03
12.2070
4.0283
150.77 KB
1.00

So my proposed change uses less CPU and memory then the current Union.

Thank you for your contribution @nathanmascitelli! we'll have a look!

Hey @nathanmascitelli, thanks so much for this contribution, this is awesome!
Kinda curious though, I feel like the numbers here are a bit extreme, any chance you could share how many feature toggles you have in your Unleash instance? I'm just trying to find out if the SDK here is chewing through an excessive amount of memory or if you genuinely have a lot of toggles and this is just streamlining that

@sighphyre we have 326 flags at the moment. I assumed this was a large number and that's why this hasn't been a problem for others. We are working on reducing the number of flags.

@nathanmascitelli Oh. Oh dear. No that's not a large number at all, that's well within reason for the computations (might be a little bit large for users to understand whats going on with their flags in their system though). For some context here, a similar sized feature set uses less than 15MB of RAM in our Edge server under load. And roughly a quarter of the numbers you're reporting for 40K toggles
Gosh time for some optimisation. Thank you so much for the information!

@sighphyre sorry I'm not sure I follow your last statement. Are you saying its time for optimization of the dotnet client or my application? If my application, can you give some guidence on what optimizations you're thinking of? We are just calling IsEnabled on the IUnleash client created by UnleashClientFactory. Admittedly maybe we are calling it too much or something...

@nathanmascitelli Sorry! That was super unclear of me! I mean that the Unleash team probably needs to look this one over and see where the SDK is using these resources. Gut feel is that this isn't your application

@sighphyre oh I would never count me out for doing something silly :). Jokes asside, thanks for clearing that up. I'm happy to help if I can.


Upgrade x86_64 CodeBuild image

There are two reasons to upgrade this image. The x86_64 image we
currently use is deprecated, and this deprecated image is not supported
in govcloud. In order to support that partition we need to use a newer
image.
Signed-off-by: Tim Lane<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is hopefully the last thing needed to unblock #1632.


Incremental cache lost after a compilation error when using Micronaut

The cache is lost after any compilation error when Micronaut-inject is shipped with the project, so for example :
1- Build this project a first time
2- Make a build error, for example by removing any parentheses on the line 12 ( log.debug ) of the test.Application class in the /grails-app/init folder, please note that Micronaut injection must be triggered in the code, that's why I added the first line TriggerMicronaut.getDeclaredField("name") by calling reflection API
3- Build the project, so the build will fails
4- Correct the code, to succeed the next compilation
5- Rebuild the project, here, instead of having an incremental build (just one file), we got the message :
> Task :compileGroovy
Build cache key for task ':compileGroovy' is 8155b9162e73ad3dbcf1e6e45d38c585
Task ':compileGroovy' is not up-to-date because:
  Task has failed previously.
The input changes require a full rebuild for incremental task ':compileGroovy'.
Groovy compilation avoidance is an incubating feature.
Full recompilation is required because no incremental change information is available. This is usually caused by clean builds or changing compiler arguments.

I am using Gradle 7.3.3 ( latest version ), with open JDK 16
micronaut-cache-conflict.zip

This is expected and a duplicate of https://github.com/gradle/gradle/issues/13766.

@oehme I am not sure because when Micronaut is not implicated in the build, it seems working, but maybe the problem could also happening without Micronaut, in this case, yes it’s a duplicate

Ah sorry I misread the steps. You're right, this is not a duplicate. I'll have a look what's going on in this scenario.

@oehme thanks, I hope it gonna be fixed soon

@oehme I am not sure but it seems, that when I cancel the build before it finish it leads to the same problem I think

Any update about this issue ?!

This looks like an issue when compilation fails and we do a full recompilation after the failure. We plan to fix this, but due to other priorities it very likely won't be fixed in next two months.

The linked PR https://github.com/gradle/gradle/pull/20950 probably fixes this issue. The reproducer doesn't work with any of latest Gradle (7.3.3 or 7.4.2) so I can't test it (wrapper has version 5.6.4).
So unless a reproducer that shows this is not an issue with "full recompilation after the failure" is added, this issue will be closed once https://github.com/gradle/gradle/pull/20950 get merged. Of course you can always open new issue.

@asodja hi,  this issue was opened 4months ago, you asked me to try with the last version, so I create a new issue with the last version, but now it’s not the last version anymore, but all you need to check if it fixed or not, is to change the version of gradle in the joined test project, otherwise each time I will create a new issue with the last version, then it had to wait to a new version then you will ask the same thing ….

I understand that it's not feasible for you to update Gradle version for me and that totally makes sense. The problem I am facing is, that when I try to reproduce the issue with the version specified in this issue (7.3.3) and reproducer linked in the issue: https://github.com/gradle/gradle/files/7791258/micronaut-cache-conflict.zip I get:
❯ ./gradlew :compileGroovy

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/asodja/Downloads/micronaut-cache-conflict 3/build.gradle' line: 19

* What went wrong:
A problem occurred evaluating root project 'micronaut-cache-conflict'.
> Failed to apply plugin class 'nebula.plugin.extraconfigurations.ProvidedBasePlugin'.
   > No such property: COMPILE_CONFIGURATION_NAME for class: org.gradle.api.plugins.JavaPlugin

I also tried with version 7.0 and got the same problem. This indicates that the plugin that is used in the reproducer is not updated to work with 7.x.
So it seems to me that the reproducer was actually not run with Gradle 7.3.3.

Strange this test project was created and tested with version 7.3.3 (latest at that date), I will recheck.

Thanks for rechecking it.


Release 0.3.0

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   73.87%   73.87%
=======================================
  Files          46       46
  Lines        3415     3415
  Branches      635      635
=======================================
  Hits         2523     2523
  Misses        892      892

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912e9cf...e4d09db. Read the comment docs.


dbt init --adapter

Description & motivation

dbt init --adapter
new in v0.18.0! I forgot to document in next and just remembered :)

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

This is dope!


Expose all defaults on PooledByteBufAllocator

Motivation:
Most, but not all defaults are statically exposed on
PooledByteBufAllocator.  This makes it cumbersome to make a custom
allocator where most of the defaults remain the same.
Modification:
Expose useCacheForAllThreads, and Direct preferred.  The latter is
needed because it is under the internal package, and public code
should probably not depend on it.
Result:
More customizeable allocators

Cherry-picked into 4.1 (003c8cc7abcfbe0c7a3ce97a23413ba4c336034a) and 4.0 (9e95d4382b08f99a7134c0f88979a8ba9f94d3e9)


Website Link

Website Link
User Story
As A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines
Acceptance Criteria
GIVEN the Horiseon-seo-code refactoring repository
WHEN I view the README
THEN I see a link I can follow to open the website

The README file now contains a link to the live website.


re-generate using svd2rust 0.14.0

I will release this as v0.11.0-alpha.1. This is a pre-release. Depend on it
at your own risk. This version will be yanked when the proper release is made
and there may be breaking changes between this pre-release and the real release.

bors r+

bors r+


Problems with WebGL (x64).

WebGL always breaks down after a while on the 64-bit version of the program (I also checked the 32-bit version, it worked fine). I have been switching chrome flags (vulcan, jungle and other flags related to the video) for a long time and have not been able to solve the problem.
How and where did I see this error:
It was tested on Windows XP x64 sp2 with all updates with an integrated graphics engine from intel core i5 with 256 MB of dedicated video memory. You just install the latest version of Supermium 122 64 and go to some website, after a while everything freezes (for a short time) and WebGL breaks. A complete restart of the browser helps, but it repeats.
Desktop:

OS: Windows XP x64
Bitness of browser: 64 bit only

WebGL always crashes after a while in all tabs at once. It is not necessary that it be used on any of them.

Do any error messages appear? I would also like to see the results of the chrome://gpu page.

about-gpu-2024-05-08T16-08-53-258Z.txt

When I turn on the Unsafe Web GPU Support and Angle-dx9 flags, it tries to run hardware acceleration (and judging by the fragments, it almost succeeds). In the 32-bit version, when setting these flags, it does not include hardware acceleration, but, it doesn't take off there after 1-2 minutes. Here is a file taken from the 32-bit version:
about-gpu-2024-05-08T16-24-13-174Z.txt


Refactor: Plant Layer API

Currently the endpoints of the plant layer only support single planting operations.
This requires the frontend to send multiple requests for each planting affected by an operation.
A good example for this is the move action for multiple plantings.
In the editor it looks like all plantings are moved at once, which is the case in the frontend data store, but the data is persisted to the backend one by one, which could cause, in some error case, unexpected behavior.
Also it is not the most efficient approach.
This issue is a proposal for refactoring the plant layer api to a batch processing approach.
Every action would take a Vec<ActionPayload> which identifies the planting.
Inside a Vec<T> can only be action payloads of the same type T.
Overall, I think this would simplify the action code of the frontend, and be a good guidance for new actions following the same approach.

Thank you for writing the proposal!
I assume  #1023 is needed first?

Thank you for writing the proposal!
I assume #1023 is needed first?

I would make this in one PR. Plays hand in hand.

Did you already work on this? We actually now have a good backend team, so I wouldn't see that this task should to be done by you.

I already talked to @horenso. We will collaborate on this.


Add incremental compilation tests

@elena-lyulina I refactored code a little bit and move common functions into utils of IC tests


docs.microsoft.com Team Blog RSS feed isn't updated

The Team Blog page (https://docs.microsoft.com/en-us/teamblog/) links to an RSS feed (https://docs.microsoft.com/en-us/teamblog/feed.xml).
The RSS Feed is valid, but it's last entry is from 04-2020.  Currently, there are 8 articles published since the last one in the RSS feed.
I realize RSS isn't as popular as it once was, but for technical things, it's great to find a list of content previously published, and I have a fair number of workflows and automations based on feed readers (IFTTT, Zapier, or Power Automate), and that can't really be duplicated.

Hey Evans! Long time!
We are discussing this internally to see who to talk to. ~Jason

Related issue: https://github.com/MicrosoftDocs/blog/issues/480

Related issue: https://github.com/MicrosoftDocs/blog/issues/480


Solve show-password style bug

Description
Solve the style bug of show password icon.
Fixes #391  Positioning of show password icon
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots

Hello @AlfiyaSiddique!
Thank you for submitting this pull request Your pull request will be reviewed by maintainers shortly. Meanwhile make sure you have referenced the respected issue in this pr Your pr will not be merged if it does not have reference to respected issue
please read our Contributing Guidelines https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md And Code of Conduct https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md


[🐛 in esl-event-utils]: fix resize event type check using interface extension (+fix extension)

As an ESL consumer, I want to be able to use:

@listen and ESLEventUtils.subscribe with a correct type handling

class A {
  @listen({event: 'resize', target: ESLEventUtils.resize})
  onResize(e: CustomEvent) { // Error
  }
}

Expected result: no error when the correct type is used for ESLResizeObserverTarget

I want to be able to override ESLListenerEventMap without limitation
Check the possibility of interface merging

Consider a custom Event type definition instead of CustomEvent in purpose to support ESLResizeObserverTarget

:tada: This issue has been resolved in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Disconnected

Normal installation on Mac OS X Mojave
Server seems to run fine in the console except one error message:

[Error] Failed to start stats server: listen EADDRINUSE: address already in use :::88

When I try to join the server in agar.io though, a "Disconnected" text comes up.
I have tried different ports as well as just localhost, but none of them work.
Help would be appreciated.

this port is already used

How do I fix this problem then, so that I can connect. Changing the port doesn't help, the error goes away, yes, but I still can't connect to it.

Have you tried <IP_ADDRESS>:port instead of localhost:port?

Yes, I am using <IP_ADDRESS>:port, also there are no errors when connecting, but there are a few warnings, here are all the console messages

Find out which service is running on your specific port and terminate it, if you don't need it.
lsof -i :port

@KittyTigerWolf Are you connecting to port 88?

kill $(lsof -i:88)
Note: you should change to another unused port, as port 88 is used by kerberos

I believe MultiOgarII does not currently work with agar.io. You may need to use an open source client such as Cigar or Cigar2.

Guys 88 is the stat port, its a system reserved port and therefore requires root permits. 8080 is the server port, so unless you're using the stats for something, you don't really need it.


Some improvements on FreeBSD

Using sysctl instead of procfs.
Enabling features previously left out by conditional compilation.

Merged, thanks! :)


Psr12

Coverage remained the same at 99.364% when pulling 44fc81a741cac7df1187ff54b79d7d791277e611 on c-harris:master into 9f13d4bfe1b8d5bd86fea0f55295da25bd2633a1 on Algo-Web:master.


Update HW-interface API for humble.

Update hardware interface API changed in ros-controls/ros2_control#715

tested locally, CI will be back up and running again soon...


Tile display with price looks strange

The Issue
The folder icon still looks okay with the white background, but the yellow price and white background looks a bit strange. Maybe @Invariant-Change has some ideas on how to improve, he spotted this.

Suggested Solutions
Tell us your suggested solutions if you have any.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Updated this issue to reflect that the price is not show now. See lbry://@LBRY-Tom#c/♒#8 related content as an example.


MAJOR-BUG for node/edge predictions: Added ordered=True to to_mol

A major bug was discovered when working with node, nodepair and edge-level tasks.
The bug is due to RDKIT's weird behaviour in that it takes the AtomMapping and displays them correctly, but doesn't use them as indices. Unless you specify that you want to canonicalize the molecule. In case you have AtomMaps defined, it will NOT search for a canonical form, instead it will use the AtomMaps.
Below is the weird behaviour by RDKIT, the big numbers next to the carbons are the AtomMapping that are used to order the atoms with the same ordering as the labels. The small numbers are the indices. When visualizing the molecules to validate that the code was working, I didn't not look at the intrinsic indices, but only at the big number, assuming that the indices were correct.

I'm sorry for the inconvenience I have caused everyone... This bug was discovered this morning when trying to fix #467 .
I have validated the fix experimentally. Simply adding ordered=True in dm.to_mol yields massive improvements on both the PCQM4M and the PM6 datasets. In the plots below, I randomly subsample 20k molecules and run an MPNN  model on the node-level tasks only. You can see drastic improvements.
What surprises me is that the metrics on PCQM are not that bad, especially since it can reach r2=0.85 on the 4M large-mix dataset. This led me to believe that the ordering was correct. But as you can see here, we can reach r2=0.95 with only 20k molecules and 100 epochs.

Thanks @s-maddrellmander for reviewing that. I have added comments on why the other calls to to_mol don't need ordered=True.
In your examples, in order, here are the reasons:

This is just some profiling code. It could be added or not, but it's just to test the speed. Doesn't serve a use case.
This function only returns the unique_id, and this doesn't depend on the atom ordering, only on the graph structure.
I added a depreciation warning for all functions in graphium.features.properties.py to use datamol.to_fp instead. Also, fingerprints don't depend on the node ordering.

Regarding the testing, I have create issue #504 . I currently do not have time to test it properly and believe I should merge the fix, and test it later. I am confident that it will work thanks to the much better training dynamics observed above. If you disagree, and think that it should be tested before being merged, let me know.


Add option to disable sanitation for column names.

Is your idea related to a problem? Please describe.
Currently I am forced to avoid .to_csv method if I need specific column names (that have spaces in the name for example)
Describe the solution you'd like
It would be great to use .to_csv(sanitize_columns=False) option to keep original column names.

Thanks @ilyanoskov !
I've just fixed it in our development branch, and will be released soon on version 1.5.0.
Now, we have the suggested argument sanitize_columns.
Could you test it, and give us some feedback?
To install the development branch:
pip install git+https://github.com/awslabs/aws-data-wrangler.git@dev

Released on version 1.5.0!

Hi @ilyanoskov !
It is totally off-topic, but we are stating a "Who uses AWS Data Wrangler?" section. So feel free to add yourself if you want 😄 .


terraform-providers.google: v3.62.0 -> v3.72.0

Motivation for this change
Updates google provider to latest version.
Also updates the google-beta provider to the same version.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127485 run on x86_64-darwin 1

1 package marked as broken and skipped:

terraform-full

2 packages built:

terraform-providers.google
terraform-providers.google-beta

/marvin opt-in
/status needs_reviewer


[Docs] Fix Navbar Styling on Mobile Devices

This will change static and hovering colors on the navbar when the viewport is small, on both light and dark modes.
Signed-off-by: crjm<EMAIL_ADDRESS>

Leaving this one with you @slumbering 💪


fix: Validate boolean Access Control Conditions

What
Access Control Validation not happening due to an internal error. Hence all the encryption & decryptions are failing.
How
It's a logical issues in the param-validation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Non-op users cannot use commands

I'm trying to use this mod on my server to give some users access to creative/spectator mode, but they cannot execute any commands.
I'm guessing this is because of the native function-permission level setting, and giving everyone op would remove the spawn protection, so that's not an option.
My current configuration is this:
{
  "admin": {
    "overrides": {
      "name_style": ["red", "bold"],
      "commands": {
        ".*": "allow"
      }
    }
  },
  "moderator": {
    "overrides": {
      "name_style": ["yellow", "bold"],
      "commands": {
        "kick": "allow",
        "ban": "allow",
        "banlist": "allow"
      }
    }
  },
  "builder": {
    "overrides": {
      "name_style": ["blue"],
      "commands": {
        "gamemode (survival|creative)": "allow"
      }
    }
  },
  "everyone": {
    "overrides": {
      "name_style": ["green"],
      "commands": {
        "help": "allow",
        "role": "deny",
        "gamemode (spectator|survival)": "allow"
      }
    }
  }
}

Mods used on the server:

Ok, so I did some testing.
fabric-api + carpet + player-roles: no noticeable issue
fabric-api + worldedit + player-roles: commands are not recognized
So the issue seems to come from worldedit.
Might have something to do with their special commands (// prefixed).

Sorry for late response- there definitely seems to be a recurring incompatibility issue with worldedit. Will have to look into it. Thanks for the report!

Fixed in 1.1.1 :)

I can still reproduce this with 1.1.2 on a dedicated server. It seems like WorldEdit checks directly if the player is an Operator. This returns false obviously. In singleplayer or LAN with cheats enabled this check returns true, but this is unfortunately not the case on dedicated servers.
I was able to get it working with a custom build of WorldEdit that always returns true for that check. Is there anything Player Roles can do in this instance to work around this? If not I understand, thank you!


Framework-relate bug when importing adapters.

Expected behavior
The adapter import should modify the correct chart.js instance.
Current behavior
When importing in a framework like ember, or react, because the package.json points requireJS to the ".cjs" file, and the import in those frameworks happens in node during build time, the adapter does not import the same chart instance, and therefore the adapter does not work.
Reproducible sample
https://github.com/chartjs/Chart.js/discussions/11376
Possible Solution
Perhaps both chart.js and chart.cjs in dist can target the same chart instance? I haven't dug too deep on how this is all setup right now.  Does require really need the .cjs version?
chart.js version
v4

Am trying to use a chartjs plugin (chartjs-financial) and the same code that works perfectly in a simple non-framework app gives an error that it can't find the required controller (candlestick in this case) when using Ember.  So, perhaps this is caused by the same error - is there a workaround right now?


Allowing OpenMP support on Windows at compilation time

Official doc: https://docs.microsoft.com/fr-fr/cpp/build/reference/openmp-enable-openmp-2-0-support

Hi,
There is another python library for primesieve that is well maintained here: https://github.com/hickford/primesieve-python. It currently already supports OpenMP although the upcoming 2.0 version will switch to C++11 multi-threading.

Closing this as I haven't got any feedback


Proposal for a docs working group

Adding a proposal for a working group between the ODH community and members of the Open Services Group to collaborate on updating the docs in https://github.com/opendatahub-io/opendatahub.io .

cc @LaVLaS  @taneem-ibrahim

@MichaelClifford Hi Michael: Thank you for creating the proposal. @LaVLaS and others have an effort undergoing to clean up and organize the docs materials. Your team adding and updating the docs can roll into the existing initiative.
I will let @LaVLaS chime in once he is back from PTO on how we can effectively collab without duplicating efforts.


Sky doesn't work

When I updated to the new 0.8 version, I get the error ERROR bevy_asset::server: path not found: bevy_atmosphere/shaders/skybox.wgsl Which is weird because this plugin used to work when I was testing it earlier on the PR fork and I dropped a comment saying that it worked fine.

Interesting, looks like it works locally (examples still work!), but doesn't work if it's a crate. @sphw maybe you know what could cause it?

My best guess is this is something to do with a bug with embedded_asset and publish crates / libraries. Not exactly sure what. IMO given all the strangeness and bugs with embedded_asset it might make sense to revert the commit that makes that change from my PR, and wait until it stabilizes further.

Agree, could you please open a PR that reverts to the previous approach?

Fixed by #65.


[FCOS]Why can GIOU improve performance?

Giou mainly renormalizes the scope of regression loss, and its most important contribution is to solve the problem that gt and prediction box do not intersect. For fcos or other anchor-free models, their location points are points inside the gt that satisfy the requirements, and the boxes generated by these points must intersect with gt. So I would like to ask, why is there a significant improvement in giou?

giou主要是重新规范化了回归误差的范围，而它最重要的贡献是解决了gt和预测框不相交的问题。然后对于fcos或者类似anchor-free的模型，他们的位置点是满足要求的gt内部的点，而这些点所生成的框必然和gt有交集。所以我想请教一下，为什么giou能够有明显的提升？

请问你在fcos上用了giou涨点明显?

you implement GIOU in FCOS method to get better performance?

you implement GIOU in FCOS method to get better performance?

about 0.3 map

你好，我想请问一下，anchor-based的方法，正样本是和gt的IOU大于一定阈值，这样必然anchor和gt也有交集，这是不是意味着使用GIOU的时候应该把负样本也用上？

Should we implement "MaxGIoUAssigner" for GIoU loss?


Custom resolvers killing server

Dependencies
MacOS mojave
node - 10.12.0
graphql-tools - 4.0.3
graphql - 14.0.2"
apollo-server-express - 2.2.6

I have a remote schema which returns not relay compatible ID, I'm trying to write my own resolvers to generate the proper ID with help of mergeSchemas. But apollo server just dying with JavaScript heap out of memory error.

I was able to replicate the issue by using schema stitching basic example where I just trying to return id without modifying it and resolvers never even called.
id: {
  fragment: `... on Chirp { id }`,
  resolve(chirp) {
    // here I should be able to do some modifications
    return chirp.id;
  },
},

Intended outcome: It'd return id or throw some error if something done incorect
Actual outcome: Server dying with JavaScript heap out of memory error
How to reproduce the issue: clone repo and try to run this query:
{
  chirp {
    id
  }
}

P.S.: Probably there are bettwer aproaches to do it. But, anyways I think heap out of memory is not expected result :-)

This is the same issue with mergeSchemas trying to be smart, related to #1033, #1031, #1035. Have a look at this https://github.com/apollographql/graphql-tools/blob/master/src/stitching/mergeSchemas.ts#L446. Replace L446 like so:
          [resolverKey]: fields[fieldName][resolverKey],
          // [resolverKey]: createDelegatingResolver(
          //   schema,
          //   operationName,
          //   fieldName,
          // ),

No memory issues and no timeouts. A Cannot return null for non-nullable field Chirp.id. though, but I guess that's because of the reduced repro?

The problem here is that you are replacing the id field with an id fragment that contains an id field, which causes an infinite loop. This could be fixed by replacing as one leaves a node rather than as one enters, but not sure if worth it, as fragments should not contain the containing field. Perhaps they should be validated as such. Rolling into #1306

Moving to v5.1, reopening to move any relevant discussion here.

We have moved to selectionSet hints rather than fragment hints, so we won't be pursuing a fix here, but PRs with one by the community will still be accepted if anyone has time to submit.


Think about stress test multi-view scenarios

Some ideas:

Multi-view app with textures (camera plugin, video player)
Multi-view app with platform views (like the macOS map test app)


feat: add CIS v1.0.0 GitHub compliance

Context
As we are adding a new provider we need to ad its compliance.
Description
Added the CIS benchmark v1.0.0 compliance to Prowler.
Checklist

Are there new checks included in this PR? No.
[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[x] Review if backport is needed.

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Still pending to add README.md changes to reflect the final status of the GitHub provider release, like the number of checks, services, etc.


Gallery, Pesto: app bar starts big, shrinks, when recipe is hero'ed down

Open Gallery, tap into Pesto, scroll up enough to shrink the app bar down to the smallest size. Then, tap on a recipe. Then, tap back.
Notice how the app bar starts big and shrinks back to the minimized size as the recipe is transitioning down.
The expected behavior is for the app bar to not shrink from big to small, but to start small and animate of fade in.

Addressing this might improve visual performance of the recipe hero'ing down.

This looks fixed!


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:36:29 on 2023.05.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 5, errors out: 0
Original problem ID: 21575
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=21575

Problem has been resolved in 6m 0s at 10:42:29 on 2023.05.22
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 21575


suggesting a change to example for better flexibility

Sure, the actor part is just experimental, so feel free to use it and improve it.

Superb, thanks!


Big issues

Azure Data Studio Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

### Tasks
- [ ] https://github.com/microsoft/azuredatastudio/issues/21691
- [ ] https://github.com/microsoft/azuredatastudio/issues/24493
- [ ] https://github.com/microsoft/azuredatastudio/issues/24504
- [ ] https://github.com/microsoft/azuredatastudio/issues/24503
- [ ] https://github.com/microsoft/azuredatastudio/issues/24476
- [ ] https://github.com/microsoft/azuredatastudio/pull/24505
- [ ] https://github.com/microsoft/azuredatastudio/issues/18524
- [ ] https://github.com/microsoft/azuredatastudio/issues/24436
- [ ] https://github.com/microsoft/azuredatastudio/pull/24499

Done


custom_profile_fields: Don't manipulate DOM when reading field_data.

Fixes #29879.
If the user had deleted an option and added that same option again, we were manipulating the data-value attribute of that option with the data-value of the deleted option. We were doing this on any change in the edit form. But if the user changed the value of the newly added option to something else, the data-value will remain the same. So, in this commit, we change the field_data values itself without manipulating the DOM.
Also added an extra commit addressing https://github.com/zulip/zulip/pull/29813#discussion_r1581642134

Screenshots and screen captures: (Screenshot won't be meaningful, added gifs)

Bug 1 from  #29879

Bug 2 from  #29879

Self review checklist

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@sahil839 can you review this one?

Regarding the behavior, the first bug mentioned in the issue was because the code was assuming that the user is editing the existing_option to existing_option1  and I noticed one similar behavior in this PR as well. Note that even though Vim option still exists, the setting for user is changed to Sublime because it was considered that Vim option was edited to Sublime. Before the PR the setting would still have been set to Vim.

I am not sure what is the correct behavior here, but just wanted to point this out. It actually is not straight-forward to decide when a user intended to just edit the existing option or add a new option.

If an option is renamed, I think it's safest to remove it from users' profiles. Otherwise, there's a risk that it will look like they chose something they didn't.
So I guess I'm suggesting that options can't be edited at all.

So I guess I'm suggesting that options can't be edited at all, even if you reuse the same text field in the UI.

This will make things much more straightforward in terms of decisions to take. Makes sense from user perspective too.
Do we want to make UI changes to signal this or we keep the UI as is?

I think we should show it in the UI that the options cannot be changed, maybe just not show the existing options as input elements and just show the delete button for them. Or we can show the input element in a disabled state.

Showing them as not editable sounds good. I don't have a clear opinion on which approach to use for that.

I like the idea of the input disabled with the button. Here's a screenshot for reference:
.
In addition to implementing this change on the frontend, we'll need to make sure that the API does not allow editing of the existing fields. I'll start a topic on "api design" channel soon.
As for the original bug, I wanted to check whether we should merge an intermediate solution or not? The API design discussion might take some time to get resolved and I don't have enough data on the usage of this feature to decide the priority of this bug.
Also since this will be a behaviour change from the current one, I think we should open a new issue with all the info nicely laid out once the api-design discussion is resolved. LMK if we should do otherwise.

I don't think this issue is visible enough to require an intermediate solution, so we can wait for the API discussion.

If you plan to finish the work on this, and feel that you understand the plan, we don't need to file a new issue. The PR will be good enough; we don't require every PR to have an associated issue.

If you plan to finish the work on this, and feel that you understand the plan, we don't need to file a new issue. The PR will be good enough; we don't require every PR to have an associated issue.

Okay, will rework this PR in that case.

If an option is renamed, I think it's safest to remove it from users' profiles. Otherwise, there's a risk that it will look like they chose something they didn't.
So I guess I'm suggesting that options can't be edited at all, even if you reuse the same text field in the UI.

I've implemented this and edited the PR description along with a note at end of the original issue.

Let's add a tooltip to the disabled input fields:

Choices cannot be modified.

(@timabbott  can adjust the wording when integrating if he has a better idea.)
While we're here, let's also convert the tooltip on the trash can to Tippy, making sure to add a delay like we usually do.

Otherwise, looks good to me in light manual testing!

@sahil839 Is this ready from your perspective?

Yes, looks good to me,

Cool, @shubham-padia please add the "integration review" label when my feedback above has been addressed.

Fixed the tooptip stuff here and marked for integration review.

So I think we need to revisit the overall design for this change. There's a real problem that someone might accidentally rename an option.
But ultimately, (1) concepts in organizations, like the answer to "What team are you on?", change with time, and it makes sense to be able to update a dropdown format option to reflect that, and (2) organization administrators already have permission to edit custom profile field values for other users, so there's no new security/permissions boundary that we're adding be doing this. I'm pretty sure this change as currently proposed would be experienced as a regression by organization administrators.
I chatted with @alya about this briefly, and I think we should (1) extract the useful refactoring from this PR with no functional changes as a separate PR to merge now, and (2) Go back to #design and discuss what we actually want to do.

@timabbott I've opened a clean-up PR at #30462, I'll start a topic on #design soon


Automation: confirm that static loading indicator respects light & dark mode

Based on work done in https://github.com/rancher/dashboard/issues/6065, let's write an automated test to ensure that the static loading indictor looks good in light & dark mode.
Previously, when dark mode was enabled or picked up by OS theme, the user goes from a dark mode log in page, bright white loading page and then a dark home page. It can be quite a quick transition so the page can flash. Removing Nuxt addressed this but we should make sure that upon login, both light & dark modes stay with the expected colour set.
@richard-cox or @codyrancher can offer guidance.

Additional fix - https://github.com/rancher/dashboard/pull/9022

As suggested, we could have an unit test after replacing inlined code with an imported script.


chore: bump client3:core, client3:zio from 3.9.4 to 3.9.5

About this PR
📦 Updates

com.softwaremill.sttp.client3:core
com.softwaremill.sttp.client3:zio

from 3.9.4 to 3.9.5
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.90%. Comparing base (99c4415) to head (cfa67d6).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   67.90%   67.90%
=======================================
  Files          79       79
  Lines        1087     1087
  Branches      126      126
=======================================
  Hits          738      738
  Misses        349      349


beginner projects

This is for someone who's a newbie to Python where you’ve just learned lists, tuples, dictionaries, and some basic Python modules like the random module. Here are some Python projects with source code for beginners.

All directories have been added


Document the Outputs

Need some information for the analysis outputs - what is produced, what those plots show, what the inputs/outputs will be, some tips on interpreting the outputs.
This information would be held on the repo, but could be linked to in future where we're going from .Rmd to .html outputs (link to repo pages from the .html output).
Would be sensible for me to do this as I'm working on the analysis code in #32

This might follow on from a completed #193 perhaps?

I think this issue is probably duplicated by/superceded by #395, closing this issue (#152) as a duplicate


Rework font-id's to not have size, face, style limitations

This major set of work was completed in the last build.


Mvg tabular

Updated to reflect changes from the tabular update of vibium-cloud. Tests will not pass before vibium-cloud update
Closes #21

The .. note:: markup is not rendered in the notebook, but it is rendered in the built documentation. I think it is an okay trade off, since I think more people are going to be copy-pasting from the documentation than download the complete examples


Throw a better error when enforcing a rule if referenced action doesn't exist

Before this change:
015-05-07 16:56:17,262<PHONE_NUMBER>91280 ERROR engine [-] Exception enforcing rule RuleDB(action=ActionExecutionSpecDB@140034739839824(ref="sdlcm", parameters="{u'change': u'{trigger.body.change}'}"), criteria={u'trigger.body.change': {u'pattern': u'', u'type': u'exists'}}, description="firing the CR submit case from /v1/webhooks/Sdlcm/sdlcm", enabled=True, id=554a7b0b0ba1603bd4571511, name="wh_sdlcm", tags=[], trigger="core.7bfd8485-8c52-4778-ab9e-ae247c1217dd"): 'NoneType' object has no attribute 'parameters'
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/st2reactor/rules/engine.py", line 59, in enforce_rules
    enforcer.enforce()  # Should this happen in an eventlet pool?
  File "/usr/lib/python2.7/dist-packages/st2reactor/rules/enforcer.py", line 48, in enforce
    liveaction = RuleEnforcer._invoke_action(self.rule.action, data, context)
  File "/usr/lib/python2.7/dist-packages/st2reactor/rules/enforcer.py", line 65, in _invoke_action
    params = action_param_utils.cast_params(action_ref, params)
  File "/usr/lib/python2.7/dist-packages/st2common/models/utils/action_param_utils.py", line 86, in cast_params
    action_parameters_schema = action_db.parameters
AttributeError: 'NoneType' object has no attribute 'parameters'

After this change:
2015-05-07 19:32:40,388 ERROR [-] Exception enforcing rule RuleDB(action=ActionExecutionSpecDB@140211180910928(ref="core.localaaa", parameters="{u'cmd': u'echo "{{trigger.executed_at}}"'}"), criteria={}, description="Sample rule using an Interval Timer.", enabled=True, id=554bb2400640fd04aae15ec0, name="sample.with_timer", tags=[], trigger="core.f62572f1-b04e-4583-8495-c562e09d6dd3"): Action "core.localaaa" doesn't exist
Traceback (most recent call last):
  File "/data/stanley/st2reactor/st2reactor/rules/engine.py", line 59, in enforce_rules
    enforcer.enforce()  # Should this happen in an eventlet pool?
  File "/data/stanley/st2reactor/st2reactor/rules/enforcer.py", line 44, in enforce
    raise ValueError('Action "%s" doesn\'t exist' % (action_ref))
ValueError: Action "core.localaaa" doesn't exist

Spotted by @luisgtz on IRC.

Note: We could (and probably should?) do this check during the rule creation as well. Even if we do that, we still need to keep this check since there are many possible "races" and cases which could result in action not being available here (e.g action gets removed after rule creation, etc.).

We could (and probably should?) do this check during the rule creation as well.

No point. Need to check later and also causes a weird dependency between rule and action loading.
Having said taht it is inconsistent as we do require the trigger to be present.

Yeah, that's why I wanted to hear comments from other people about that.
Triggers are a bit different though since they are needed earlier in the rule processing. In any case, I'm fine with keeping it as it is right now and not changing the semantics.

Triggers are a bit different though since they are needed earlier in the rule processing. In any case, I'm fine with keeping it as it is right now and not changing the semantics.

I am +1 to this.

wow we all agree :)
+1


Download Location

It would be nice if there is a way to save downloaded  files to a custom location in the external SD Card. Not everyone has enough space in their Internal Storage and this is a huge let down.

@enwokoma Yes you can do that with Fetch. Provide the FetchConfiguration your implementation of StorageResolver


fix(chapter_02): correctly perform a quadratic approximation

As a disclaimer, I'm a bit clueless about statistics at the moment (hence why I'm going through this book!), but I think the way quadratic approximations have been done in Chapter 2 have been wrong since Max Lapan's original work, and that seems to have been carried over here?
From what  I can tell, the algorithm for quadratic approximation involves finding the mode of some sampled distribution, then calculating the curvature / variance from that peak. I think this is backed up by the book in these sections:

And this approach leads to normal approximations with modes that match the analytical solution (note how all of the peaks align, regardless of the differences in peak-shape):

This can be contrasted from both Max Lipan's notebook:

And this repository's version:

Both of these versions are building normal distributions with a mean that is simply the average of all samples, not the mode of the samples (as I believe it should be). That's why the peak of the normal distribution does not line up with the analytical solution, or even the mode of the sampled distribution.
I've changed the notebook for Chapter 2 to now use the quap() function from the StatisticalRethinking package, which correctly calculates the quadratic approximation (note how the modes are again aligned):

Let me know if I'm barking up the wrong tree, or if this looks good!
Brooks

Hi Brooks, thanks a lot for your pull request.
I need to find some time to make some updates in StatisticalRethinking.jl.
In Turing you get the MAP value by:
map2_0 = optimize(m2_0(6, 3), MAP())
coef = map2_0.values.array

Which in this example gives ~0.66 which is reasonable .
To approximate the curvature around that mode value (MAP), way back, I used:
sigma = std(df.p, coef[1])

which give~ 0.14.
Then the posterior MAP estimate is:
Normal(coef[1], sigma)

Would you agree with that?
Best,
Rob

In an issue from a few weeks ago I mentioned that I really don't have enough bandwidth to work on both the Stan side and the Turing side of StatisticalRethinking.
The current versions of quap() (intended for Stan users) and turing_quap() (intended for Turing users) are outdated. I will try to fix these. The simple variable case is shown above, but multivariable cases get more complicated.
Maybe I don't have enough time, but I certainly appreciate your help as you work through the chapters.

Hi Rob! I've done some playing around (using the excellent starting point you gave me), and I think I've come up with something nice that seems to give some very similar results to the book?
From https://github.com/TuringLang/Turing.jl/blob/c29d36e20f1d61aed2bff118aa4c21694bc9c97c/ext/TuringOptimExt.jl#L76-L102 I found some functions that make fetching the parameters from the mode-estimate a bit nicer, then (and to be clear, I am not 100% certain that this is the "appropriate" approach here) I saw how you could work out parameter standard deviations from the variance-covariance matrix https://stackoverflow.com/questions/52275542/how-to-calculate-the-standard-error-from-a-variance-covariance-matrix. In the Turing code there is talk of Hessians, which makes me think this is the same sort of approach used behind the scenes in the book (from the "The Hessians are coming" overthinking section!)
I also find this nice, because it means we don't have to encounter the MCMC chain stuff before getting to a quadratic approximation. In the end, I've got this?

I'll update the PR to have that version — just let me know if that seems sane! No chain sampling or dataframes needed! (Explicitly anyways — obviously there is some sampling done by optimize behind the scenes).
Of course I'm not fully certain, but I think this approach could work for more parameters? We could call something like params (https://github.com/TuringLang/Turing.jl/blob/c29d36e20f1d61aed2bff118aa4c21694bc9c97c/ext/TuringOptimExt.jl#L100), then loop through all of those — looking up each parameter name in the coefs and on the vcov diagonal?
Let me know what you think! And no worries about bandwidth — being responsive to PRs is more than a lot of maintainers manage!

Hi Brooks, just uploaded SR2TuringPluto.jl v5.3.0. Works fine!

Oh, and thanks for getting rid of the using MonteCarloMeasurements bit! That's something I missed, but by the time I'd remembered it, you'd already fixed it! Thanks!

Yes, MonteCarloMeasurements.jl was a left over dependency from many years ago when Turing didn't have MAP() and MLE() (in fact I asked for such a feature). Before that got implemented I thought MonteCarloMeasurements was my best bet, but I should remove it (not really urgent  because the package is well maintained!).


feat(bdrs): add custom bpndidresolver token address

Description
Add environment variables for bdrs token configuration.
Why
Client id and secret are more secure than API keys.
Issue
Ref: #456
Corresponding Backend PR
https://github.com/eclipse-tractusx/portal-backend/pull/1129
Checklist
Please delete options that are not relevant.

[x] I have performed a self-review of my changes
[x] I have successfully tested my changes
[x] I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
[x] I have commented my changes, particularly in hard-to-understand areas

don't merge until change from BDRS side is clarified.
I was then also under the impression that you prediscussed the change with the BDRS committers, as commented here, but that doesn't seem the case, see https://github.com/eclipse-tractusx/bpn-did-resolution-service/issues/120.


Unable to download xz

With the latest version 2.2.4, spc is unable to download xz version 5.4.6 from fossies.org.
This was fixed in crazywhalecc/static-php-cli#495 by upgrading to xz 5.4.7 but spc remains broken.
Any advice how to solve this with spc version 2.2.4 while waiting for a release?

When downloading, you can override download url using -U {source_name}:{url} option. For example: bin/spc download --for-extensions=XXX,YYY -U "xz:https://github.com/tukaani-project/xz/releases/download/v5.6.2/xz-5.6.2.tar.gz".
And btw, the current spc version is not very meaningful. Generally, the patch version number is updated once a week, or the minor version num add with a big feature added. And if you do not need to use the SPC API and only use the command line, the main branch is more usable.

Thanks!


only tools or research paper

Can we only include pangenome tools, or can research articles be added as well? I'd be happy to submit some PRs to document classic papers.

Hi, yes, there was some discussion of adding papers here : https://github.com/colindaven/awesome-pangenomes/issues/8
I guess we should start adding the papers to the respective tools, since some tools are best described by the papers and not all papers are linked in the tool github repos. PRs are welcome since this will take considerable effort !
Thanks.


GraphQL generated resolvers are ignoring GSI in 1-to-many relationship list calls, doing table SCAN instead of QUERY

Environment information
System:
  OS: macOS 14.5
  CPU: (10) arm64 Apple M1 Pro
  Memory: 152.22 MB / 32.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 22.2.0 - ~/.nvm/versions/node/v22.2.0/bin/node
  Yarn: undefined - undefined
  npm: 10.7.0 - ~/.nvm/versions/node/v22.2.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: 1.0.2
  @aws-amplify/backend-cli: 1.0.3
  aws-amplify: 6.3.4
  aws-cdk: 2.143.0
  aws-cdk-lib: 2.143.0
  typescript: 5.4.5
AWS environment variables:
  AWS_PROFILE = gatecode-deploy
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
The bug:
I have a model defined in resource.ts:
GateCodes: a
  .model({
    gatePhone: a.string().required(),
    ownerCode: a.string().required(),
    name: a.string().required(),
    // create a reference field to the account (there must be an account to have a GateCodes entry)
    owner: a.string().required(),
    // use that reference field to make a belongsTo relationship
    account: a.belongsTo('Account', 'owner'),
  }).identifier(['gatePhone', 'ownerCode'])
  .authorization(allow => [allow.owner()]),
Account: a
  .model({
    owner: a.string().required().authorization(allow => [allow.owner().to(['read'])]),
    comment: a.string(),
    gateCodes: a.hasMany('GateCodes', 'owner'),
  }).identifier(['owner'])
  .authorization(allow => [allow.ownerDefinedIn('owner')]),

So basically a single owner has one Account, and their account can have many GateCodes.  The GateCodes schema uses the owner field as the reference field, so there's a Global Secondary Index on the owner field.  However, when I fetch the GateCodes after loading an account like this:
this.account = data;
let result = await data?.gateCodes();
console.log("got gate codes- ", result);

You'd think it would do a query on the underlying Dynamo DB table because there's a GSI on the owner which is what it's using to query with.  But it does not, it does a scan instead.  In the CloudWatch logs (after turning on API logging in the AppSync settings) I see the following transformed template:

"                \n{"version":"2018-05-29","limit":100,"filter":{"expression":"(((#owner = :and_0_or_0_owner_eq) OR (#owner = :and_0_or_1_owner_eq) OR (#owner = :and_0_or_2_owner_eq)) AND (#owner = :and_1_and_0_owner_eq))","expressionNames":{"#owner":"owner"},"expressionValues":{":and_0_or_1_owner_eq":{"S":"180173d0-4001-70c6-e87f-0e070c83caef"},":and_1_and_0_owner_eq":{"S":"180173d0-4001-70c6-e87f-0e070c83caef"},":and_0_or_0_owner_eq":{"S":"180173d0-4001-70c6-e87f-0e070c83caef::180173d0-4001-70c6-e87f-0e070c83caef"},":and_0_or_2_owner_eq":{"S":"180173d0-4001-70c6-e87f-0e070c83caef"}}},"operation":"Scan"}\n"

The very last entry in there you can see is \"operation\":\"Scan\".  It's the same problem if you try to query the GateCodes directly by passing the owner in (which ought to trigger a query on the GSI as well):
this.client.models.GateCodes.observeQuery({
  filter: {
    owner: {
      eq: this.userService.currentOwner!
    }
  }
}).subscribe({
  next: ({ items, isSynced }) => {
    this.gateCodes = items;
  },
});

This also produces an \"operation\":\"Scan\" in the logs.
The culprit
In the AppSync functions it creates a resolver for this model called QueryListGateCodesDataResolverFn, which has the following relevant code:
#if( !$util.isNull($ctx.stash.modelQueryExpression) && !$util.isNullOrEmpty($ctx.stash.modelQueryExpression.expression) )
  $util.qr($ListRequest.put("operation", "Query"))
  $util.qr($ListRequest.put("query", $ctx.stash.modelQueryExpression))
  #if( !$util.isNull($args.sortDirection) && $args.sortDirection == "DESC" )
    #set( $ListRequest.scanIndexForward = false )
  #else
    #set( $ListRequest.scanIndexForward = true )
  #end
#else
  $util.qr($ListRequest.put("operation", "Scan"))
#end

This code says if there's no modelQueryExpression to do a scan.  There's a related function called QuerylistGateCodespreAuth0Function which builds this variable.  It's too long to put here, but it starts like this:
#set( $modelQueryExpression = {} )
## [Start] Validate key arguments. **
#if( !$util.isNull($ctx.args.ownerCode) && $util.isNull($ctx.args.gatePhone) )
  $util.error("When providing argument 'ownerCode' you must also provide arguments gatePhone", "InvalidArgumentsError")
#end
## [End] Validate key arguments. **
#if( !$util.isNull($ctx.args.gatePhone) )
  #set( $modelQueryExpression.expression = "#gatePhone = :gatePhone" )
  #set( $modelQueryExpression.expressionNames = {
  "#gatePhone": "gatePhone"
} )
  #set( $modelQueryExpression.expressionValues = {
  ":gatePhone": {
      "S": "$ctx.args.gatePhone"
  }
} )

It's looking to see if you set the partition key.  After that, it goes only to check if you passed a sort key, and then how you want to sort, etc.  What it doesn't do is look to see if you are querying on the GSI that was created automatically when you setup a 1-to-many relationship, and instead do a query on that.
On a large table, this would be very wasteful and expensive to do a scan all the time when a developer thought they had passed sufficient information to do a query.

I just wanted to add a couple other notes on these auto-generated GSI. First, you cannot use these as queries in your app code. They don't appear in your client after you set  client = generateClient(); You would need to create another GSI with the same primary key using @secondaryIndexes(). This is a waste because now you have 2 GSI with the same primary key. Also, the auto-generated GSI doesn't have a sort key by default and I couldn't find any information on how to set one in the Gen 2 documentation. In Gen 1 you could use the @key directive to create uni-directional relationships so this wasn't an issue.

This is a waste because now you have 2 GSI with the same primary key. Also, the auto-generated GSI doesn't have a sort key by default and I couldn't find any information on how to set one in the Gen 2 documentation.

@MattWlodarski  Good points!  I had tried that in my second comment and saw that afterwards I was able to see the new listBy... method in my client, but didn't realize it was creating a second GSI.  Checked my DB and it did indeed.  On a write heavy application, this would incur unnecessary extra cost.
I didn't need a sort key in my situation, but you're right, there doesn't appear to be a way to do that.  I tried .secondaryIndexes((index) => [index(["owner", "name"])]), thinking it might be setup like .identifier(['gatePhone', 'ownerId']) where it can take a two element array.  Doesn't compile- it doesn't accept an array.
I'm really wondering what the benefit is for establishing these relationships in the model?  Do you know?  I thought:

simple/efficient query of child objects (half true, it is simple at least but you'd be crazy to use it in a large production application because it would eat read capacity with scans)
delete the parent object in a one-to-many and it'll automatically delete the children for you to avoid orphaned items in your database (nope, doesn't do this- I tried deleting an account and it just left the children in the DB)

Hey @jpangburn, if they are scanning for the child objects instead of using the auto-generated secondary index then there is definitely no point in creating a bi-directional relationship. You would be better off just creating your own secondary index and querying for it manually in your code when needed. The whole point is to be able to pull all the data you need in one single query but scanning will make it way too slow and costly.
In Gen 1 you had to handle deleting the children yourself when necessary. There was never any auto-delete feature and I haven't seen anything in the Gen 2 documentation that says they added this feature. This would be especially nice for many to many relationships because you have to manage a linking table on top of the two parent tables. If you delete a parent but forget to delete all of the references to that parent in the linking table, you will start getting errors with any query that attempts to pull the deleted parent through the linking table.

Stumbled on the GSI sort keys documentation today!  It's at https://docs.amplify.aws/angular/build-a-backend/data/data-modeling/secondary-index/#add-sort-keys-to-secondary-indexes.  Copying here for anyone who came here looking for this and missed it in the documentation:
export const schema = a.schema({
  Customer: a
    .model({
      name: a.string(),
      phoneNumber: a.phone(),
      accountRepresentativeId: a.id().required(),
    })
    .secondaryIndexes((index) => [
      index("accountRepresentativeId")
        .sortKeys(["name"]),
    ])
    .authorization(allow => [allow.owner()]),
});

It creates new listBy... queries for these.
This said, still the main problem remains: GraphQL generated resolvers are ignoring GSI in 1-to-many relationship list calls, doing table SCAN instead of QUERY.
To workaround this, I ended up just dropping the 1-to-many relationship between these models.  This way you can query on the GSI for your child model directly.  It's an extra step in code, which is a bummer because it would be really clean to have the parent model instance and just ask for the children- but to pay for a scan instead of a query, it's a bad trade in terms of price/performance you'll pay.

I see two possible solutions to this issue.

Update the list query to account for automatically generated GSIs when constructing the modelQueryExpression.
Create a listBy query for the automatically generated GSIs and update the client to use this query for lazy loading.

The team will need to discuss internally to decide the path forward.


Flake8 rule 'E999' reported an invalid point

Flake8 reported an invalid point for the rule E999, with the messge SyntaxError: invalid syntax.  It claims the error is on the first line '""Model Runner.
"""Model Runner.

This script consumes a run.json file and executes the contained model scenario.
"""

import json
import logging
import subprocess
from time import time
from typing import Dict

from lxml import etree
from pymongo import MongoClient

from errors import LaunchError
...

Debug information:
Atom version: 1.22.1
Flake8 version: 3.5.0 (flake8-bugbear: 17.4.0, flake8-pyi: 17.3.0, mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 3.6.3 on Darwin

Unfortunately it is only reporting on the first line since, by definition, the point that flake8 reported doesn't exist so it can't use that point.
Are you able to consistently reproduce this? If so, are you able to share the file (if not, can you create a minimal case)?
There was a previous bug in flake8 that was fixed in v3.2.1, but there seems to be at least one more. Please follow the linked issue for any updates (and post a file to reproduce with there please, thanks!).

Duplicate of #505


delete exit_sendmail plugin

Users complain about build systems sending too much email. Let's delete the atomic_reactor/plugins/exit_sendmail.py plugin.

Hi @ktdreyer , any extra info about why is the too much email issue related to this plugin?

That plugin can be skipped by server config. We have users who require those emails

Which users require the emails? They seem to be at odds with the users who complain the build system sends too much email.

I've reviewed OSBS-2267 , and I still think we should remove this plugin.


fix: Check for flow breaks before patching with the repair for S2142

Fixes: #599

Thanks a lot @algomaster99 . Seems to be fine.
Have you tried it on the commit I had referred to in #599 to see if it fixes the problem?

I don't see any commit linked in that issue. There is a code block which describes the bug and I have created tests similar to it. Could you please link the commit?

Oh! You're right. I'll find the commit and send you the link.

I found it. You get that error on joelittlejohn/embedmongo-maven-plugin, commit 72b45f438a69c6ae575aa62c6a536a35905ef7b8.

Yes, it works now! This is the line for future reference.

Thanks @algomaster99

great start @algomaster99


Removes Activity logo

What is the Purpose?
Removes activity logo from login and registration page and navbar
What was the approach?
Removes the img tag
Are there any concerns to addressed further before or after merging this PR?
None
Mentions?
@andrewtpham @Kimaiyo077
Issue(s) affected?
None

Codecov Report

Merging #375 into dev will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #375   +/-   ##
=======================================
  Coverage   72.50%   72.50%
=======================================
  Files          62       62
  Lines        2640     2640
=======================================
  Hits         1914     1914
  Misses        726      726

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64773d...cc95561. Read the comment docs.


Move to Sesame 4.0.0

Keep up with the latest Sesame releases. 2.7.10 dates back to January 2014. Keeping this old dependency makes it hard to use Ontop with other RDF frameworks who have made the switch.
Java 8 is required though for version 4.0.0, so this might be a deal breaker.

@TimmyStorms Indeed we would like to keep all the dependencies up-to-date !
We are in a large research project and we need to sync with all the other parters in the project for updating dependencies.
We have already decided to move to Java 8 soon. Sesame 4.0.0 might come after Java 8. Please be a bit patient :)
Meanwhile, if can tell us more about how you want to use Ontop with other RDF Framework, we will be super happy.

Started tracking in the branch feature/sesame4

Hi guys, any update on this? There hasn't been any development on the feature branch for over 2 months. Would love to see Sesame 4 support in there. Is there a date you're working towards, or has this low priority?
We're working with Stardog and would like to make the move from version 3.x to 4.x. As 4.x works with Sesame 4, we're having classpath issues with both sesame verions on there.

Hi @TimmyStorms ,
Unfortunately your impression it is right. We did not work on sesame v4 recently. The major reason is that we are bound to a large EU project.  Since the migration of sesame from v2 to v4 will be a major effort and break all partners' code, we need to coordinate the dependencies among all partners. Sorry that I could not promise a date now.
I am fully aware of the whole situation. Therefore I created issue #84.

Ontop v3 now supports latest version of RDF4J


Support List Projects

Hi,
Would be nice if the library could have a method to list the projects.

Cf. https://cloud.google.com/bigquery/docs/reference/rest/v2/projects/list

Regards

As a quick workaround:
bigquery.request({
  uri: 'https://www.googleapis.com/bigquery/v2/projects'
}, function(err, resp) {
  if (!err) {
    const projects = resp.projects
  }
});

BQ team has advised us not to support this, but instead to redirect users to the resource client instead.


self_update: Attempt to update without race condition

On Windows, there is a race condition where in self-update
we could end up unable to complete the job.  This is an
attempt at fixing that.
Signed-off-by: Daniel Silverstone<EMAIL_ADDRESS>

I'm not sure how this is race-free: it leaves a clear period while there is no exe at all? There's also no coordination with other processes so nothing preventing read handles on the files being deleted and replaced - see the discussion in the ticket I opened about updates with RLS open, which will impact this too

The race condition in question was regarding the way that a process which invokes rustup update or rustup self update can see its child exit, and then start a new process of rustup which ends up preventing the self-updater from completing.
I'm in no way claiming this is the best way to do it, merely that it would mitigate the race, particularly in the test suite :D

My feeling after revisiting this is that there must be a better way, so I'm abandoning this PR for now.


Username and password checking

Add username and password checking to advancebroker.ino example

Hi, don't delete event, it will be deleted internally


Update resiliency page

This is based on the latest state of https://github.com/elastic/elasticsearch/blob/master/docs/resiliency/index.asciidoc

@seut Does this look good now?

@seut Made adjustments in line with your comments. Could you please have another look?


defending blade prompt will not accept input

both block and pass buttons seem to be disabled
happened twice, then worked once... will try to narrow down the cause. after playing some more, it seems to work most of the time. but, also seeing on the coordinated attack prompt, when there are three characters eligible, the center one has disabled buttons sometimes.  can't close the window when this happens, have to alt-tab and stop the game
playing on a pc using xbox controller and mouse/keyboard. maybe switching controls is the problem?
no other mods, playing temple of elemental evil (https://steamcommunity.com/workshop/browse/?appid=1096530&browsesort=trend&section=readytouseitems&actualsort=trend&p=1&days=-1)
Player.log
chr.zip
AutoSave_17.zip

Unfortunately I don’t have a Xbox controller to properly add support to the mod.


fix: Button behind keyboard

The type of this PR is: Bugfix

This PR is the follow up of https://github.com/artsy/eigen/pull/6391
The button should stay behind the keyboard as per the discussion here.
Before
https://user-images.githubusercontent.com/17421923/157662263-32751a3b-350c-4540-a625-5d1ca412d424.mov
After
https://user-images.githubusercontent.com/17421923/157662234-e8aef3a0-c7fa-481b-ab04-3f8625514bf1.mov
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Button should stay behind the keyboard on MyCollection Add/Edit artwork form - Sam

iOS user-facing changes

Android user-facing changes

Dev changes

This PR contains the following changes:

Cross-platform user-facing changes (Button should stay behind the keyboard on MyCollection Add/Edit artwork form - Sam)

  Generated by :no_entry_sign: dangerJS against f35d33cfc70dbf36e3f2ce7b5fb239fd215fdf33


Edit Charging Station - Back end check for assigning three phased station to single phased site area

QA: fixed.


speed test shows...

... that the acquisition speed is 240Hz for 32k samples at 125MS/s.
so that's 7.7MS/s over the 125MS/s or 6% of the generated data that are transmitted. Not bad but may be improved by accumulating several 32k samples into an array and transferring this array in one connection. What do you think about this?
PS I reached 30% using a code found on RP forum, so it is possible :)

I measured similar speeds (a little above 250 Hz):

Note that only 16k samples (8k for each adc) are transmitted so that corresponds to only 4MSps :snail:
However, each sample is stored on 32 bits (instead of 16 bits in the Red Pitaya design) because averaging is performed on the FPGA.
In the present design, data is read from the Block RAM using a Master GP port in AXI-lite (no burst) configuration clocked at 200 MHz. I measured that 1 read operation (32 bits) takes 80 ns (16 clock cycles). So that's already 16384 x 80 ns = 1.3 ms to transfer the 16k samples from FPGA to CPU...
It is possible to reach much higher speeds using the High Performance port of the Zynq in a DMA configuration. I guess the code you found on Red Pitaya forum uses such a configuration (do you have a link ?)
Concerning your 30% value, I guess you were only transmitting one channel (30% x 125 MS/s x 2 channels x 16 bits/S = 1200 Mbps).

see thread http://forum.redpitaya.com/viewtopic.php?f=7&t=317&p=4494#p4494
with command rp_remote_acquire -m 1 -a <IP_ADDRESS> -p 9930 -u
Laurent

http://forum.redpitaya.com/viewtopic.php?f=7&t=317&p=4520#p4520
see my post updated today. I measured for a single channel 24% = 59.7MB/s / 250MS/s.

Speed has improved a little (release : https://github.com/Koheron/zynq-sdk/releases/tag/v0.6-beta.1)


Guard-splitting for non instantiated mCRL2 models

Currently the -g|--pins-guards option in the lps2lts-sym tool produces an incorrect state space for  201409.1 <= mCRL2 version < r13248.
With these versions the work around is to always use lpssuminst before loading the LPSs with lps2lts-sym.

With these versions the work around is to always use lpssuminst before loading the LPSs with lps2lts-sym.


cursor() insted stream()

Mongoose:Query.prototype.stream() is deprecated in mongoose >= 4.5.0, use Query.prototype.cursor() instead

Fixed here w/ backwards capability:
https://github.com/weisjohn/mongoose-csv/commit/7a0de3d829c14782cab47cb4aba3ad73b266eab7


wordSpacing has no effect on RTL text

Steps to Reproduce

Execute flutter run on the code sample

Expected results:
Setting the wordSpacing in the text style should add more spacing between words.
Actual results:
Setting wordSpacing on RLT text/languageshas no effect.
This happens whether you set the textDirection on the Text widget or not.
See this dartpad.

No issues found! (ran in 0.8s)

PS C:\Users\Moshe Dicker\Documents\DickerSystems\bug_flutter> flutter doctor -v
[✓] Flutter (Channel stable, 3.7.10, on Microsoft Windows [Version 10.0.22621.1413], locale en-US)
    • Flutter version 3.7.10 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4b12645012 (6 days ago), 2023-04-03 17:46:48 -0700
    • Engine revision ec975089ac
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\ANDROID_SDK
    • Platform android-33-ext4, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Build Tools 2022 17.4.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code, 64-bit edition (version 1.76.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.62.0

[✓] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22621.1413]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 112.0.5615.49
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 112.0.1722.34

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hellp @dickermoshe. Is this issue reproducible on the latest master version?

Yes.
[√] Flutter (Channel master, 3.10.0-2.0.pre.30, on Microsoft Windows [Version 10.0.22621.1413], locale en-US)
    • Flutter version 3.10.0-2.0.pre.30 on channel master at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 8eb1c9d1f6 (42 minutes ago), 2023-04-10 08:21:42 -0400
    • Engine revision 44d1656444
    • Dart version 3.0.0 (build 3.0.0-417.0.dev)
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at C:\ANDROID_SDK
    • Platform android-33-ext4, build-tools 33.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2022 17.4.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code, 64-bit edition (version 1.76.2)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.62.0

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22621.1413]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 112.0.5615.49
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 112.0.1722.34

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I can reproduce this issue with Master (3.9.0-22.0.pre.28). wordSpacing works with English words set to RTL as well, just not for native RTL languages.

 Flutter (Channel master, 3.9.0-22.0.pre.28, on macOS 13.2.1 22D68 darwin-arm64, locale en-US)
    • Flutter version 3.9.0-22.0.pre.28 on channel master at /Users/nabeelparkar/fvm/versions/master
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/2.19.5/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nabeelparkar/fvm/versions/master. Consider adding /Users/nabeelparkar/fvm/versions/master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1a6a20cdc6 (2 hours ago), 2023-04-05 06:39:09 +0100
    • Engine revision 4219c72ac8
    • Dart version 3.0.0 (build 3.0.0-408.0.dev)
    • DevTools version 2.23.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-33, build-tools 33.0.0
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/nabeelparkar/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9477386/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.77.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.2.1 22D68 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Brave Browser <IP_ADDRESS>

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I just ran the your code sample on dartpad, all the english text has working wordSpacing

One issue is that the word spacing implementation in ParagraphImpl::applySpacingAndBuildClusterTable currently operates only within each run.
The Hebrew and Arabic text in this example is split into separate runs for each word because the words and the spaces are mapped to different fonts.
@Rusino

Using a font that has explicit Hebrew/Arabic support works.
Thanks so much.
This can be used as a temporary fix.
See the following dartpad

I reproduced it in Skia. Working on it.

Fixed with https://skia-review.googlesource.com/c/skia/+/811817.

Awesome, thanks for the update!
On Tue, Feb 13, 2024 at 12:58 PM Rusino @.***> wrote:

Fixed with https://skia-review.googlesource.com/c/skia/+/811817.
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/124480#issuecomment-1942108174,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASDJ62ZBPBBN5H7SIGVCGNLYTOSUHAVCNFSM6AAAAAAWYFQ4QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGEYDQMJXGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


sample: read fv

Description
Fixes #7895
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist

[x] I have followed Sample Format Guide
[ ] pom.xml parent set to latest shared-configuration
[ ] Appropriate changes to README are included in PR
[ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[ ] Tests pass:   mvn clean verify required
[ ] Lint  passes: mvn -P lint checkstyle:check required
[ ] Static Analysis:  mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
[ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[x] Please merge this PR for me once it is approved

A naive question, where do you see the test fail? I have a problem running tests on my cloudtop so I plan to rely on presubmit error.

@anguillanneuf Can someone from @GoogleCloudPlatform/dee-data-ai  TAL at this?

Still don't see any button to merge? Do I still need more approval?

@anguillanneuf Can someone from @GoogleCloudPlatform/dee-data-ai TAL at this?

Ping


TRG new: Do not use patch versions for images

We need a new TRG which describes the following:
To keep container images up-to-date / secure and compliant, we should not use apt update or any other package manager update mechanism to keep the base os / base image up-to-date.
Instead we need to make sure that we use a secure upstream image in best case one which points to the version the project needs + regular update.
Like instead of alpine 3.3.3 use 3.3
AC:

Create new TRG for not using patch version and highlight security team for feedback / suggestion
Highlight the issue that apt update might pull in a new version of a library which is no longer under the right ip/license

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/594


Fix size constant passed to avahi_address_snprint()

Problem: avahi_address_snprint() takes the size in bytes of the buffer being printed into as its second argument. This library was using std::mem::size_of_val() on a CString type to pass this argument; however, that will return the size of the CString type, which is not necessarily the size of the underlying array that the CString was generated from.
On 64-bit platforms the size of CString happens to be 16, which fits the string representation of most IPv4 addresses, but is lower than AVAHI_ADDRESS_STR_MAX which is defined to 40. This also means:

The avahi_address_to_string() function will probably not work with most IPv6 addresses at all
It won't even work with IPv4 addresses on 32-bit ARM platforms where the size of CString is smaller

I believe the correct solution is to pass the constant that was used to allocate the string buffer instead. I also added 2 tests, the IPv6 one fails using the previous code on 64-bit Ubuntu 20.04, but passes with the modified implementation of avahi_address_to_string().

Thanks again!


2D SLAM with Neato LIDAR

Hi,
I'm currently working on a project where are using a Neato (XV-11) LIDAR sensor for 2D SLAM with cartographer_ros. We have attempted to encode the output from the LIDAR into sensor_msgs/LaserScan messages as input to Cartographer, but the rviz output looks like scattered lines with no loop closure.
My question is, how would you recommend we encode the data into the messages? The LIDAR sensor provides serial output at 4 degrees of distance measurement at a time. Should we populate LaserScan "echoes" with the 4 distances/intensities and send 90 messages with each revolution of the sensor?
Thanks!!!

@bliebman
If you are using the laser standalone (USB) without the rest of the Neato robot I suggest you take a look at this driver (officially supported up to Indigo but shouldn't be too much work to port to kinetic if you need): http://wiki.ros.org/xv_11_laser_driver
tutorial on how to use the driver can be found here: http://wiki.ros.org/xv_11_laser_driver/Tutorials/Running the XV-11 Node
However, if you are running the full Neato robot you are better off going with this driver which also supplies a laser scan topic: https://github.com/jmtatsch/neato_robot
possibly helpful tutorial for Neato with Indigo: http://servo.texterity.com/servo/201412/?folio=42&pg=42#pg42

It sounds to me like you are unsure about how to construct a laserfan from your neato data, which is not a Cartographer related problem. @kentsommer's reply contains every information I could provide either, so I am closing this.
If you believe this is related to Cartographer, please reopen and attach a few screenshots from rviz showing your lasers fans and Carto results.


Function to align bird movement data with a BirdFlow model.

snap_to_birdflow()
The purpose of this function would be to determine the location index and timestep associated with bird locations from movement data and possibly aggregate multiple points from the same individual or track such that there is at most one point per timestep.
Process

match date to a timestep,
reproject to the BirdFlow model's CRS
if requested, aggregate points within week and track
crosswalk the location to a cell
check to make sure that that cell is valid for that date

Arguments

d  a data frame with some sort of tracking data, each row has an associated date, x, and y
bf the bird flow object to align it with
x_col, y_col  the column name for the x and y coordinates, defaults to x = "lon", y = "lat"
id_cols one or more id column names, used to define unique groups if aggregate is not NULL
date_col  the column name for dates in any format that can be handled by lookup_timestep() defaults to "date"
crs the coordinate reference system to use. Defaults to WGS84, consistent with latitude, and longitude.
aggregate If not NULL (the default) a method for determining how to aggregate the points within each group (see id_cols) by week.

Return id_cols from d with additional columns appended:

x and y the x and y coordinates in the CRS of bf. These will replace original x and y columns if present
timestep - the timestep associated with date in bf or NA if it couldn't be resolved
label  - the "month day" label associated with the date or NA if the date couldn't be resolved
i - the location index of the resolved location - or NA if it couldn't be resolved
error - logical indicating whether the point could be aligned with bf
err_message  The first error found.  Errors earlier in the list take precedence

err_date  -  TRUE if the date couldn't be parsed
err_truncated  - TRUE if the model is truncated and the date isn't covered by the model
err_coords  TRUE if the coordinates can't be resolved to a location in the coordinate reference system ( crs(bf)).
err_not_active  If TRUE the start or end point is not within the model mask
err_dynamic   If TRUE eBird S&T has assigned zero probability to the cell and therefore it is excluded by the dynamic mask.
err_sparse   TRUE if the model assigned zero probability to the location and neither not_active nor dynamic_mask  was triggered. This can be caused by sparsify() eliminating model states that the dynamic mask included in the model.

[edited to reflect current function]

It looks like for interval_log_likelihood() I expected the columns lat and lon and that the data was in WGS84.
If we standardize on keeping the cleaned but not BirdFlow aligned data in WGS84 this might be a good option.

Closed with #157


Analisis of warnings reported by Kubelinter

I have been playing with kubelinter to detect issues related to the charts in this repo. I have implemented the github action to run the linter on charts on my fork. The linter has triggered more than 89 warning of different types. Trying to group them to discuss if they need attention or we can ignore them:

Lack of memory / CPU requests and limits: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits
Containers running as root https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
Do not use latest on container images but tags
Containers running without the read-only option for the filesystem
Network space is being shared with the host

After a quick chat with @akash-roboticist some comments for the different categories:

Lack of memory / CPU requests and limits: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits

As a preliminary step, more information needs to be collected on how the different containers are consuming memory/CPU and what the RMF team would expect from them.

Containers running as root https://kubernetes.io/docs/tasks/configure-pod-container/security-context/

This is a high priority that needs to be addressed.

Do not use latest on container images but tags

Since the development is ongoing, we are going to keep using latest tags by now.

Containers running without the read-only option for the filesystem

Good to look. dds config can be read only but database needs inspection.

Network space is being shared with the host

Worth exploring the limitation.


KAFKA-15288: Change BrokerApiVersionsCommandTest to support kraft mode

Change BrokerApiVersionsCommandTest to support kraft mode.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thank you for your advice @dengziming, this is very helpful to me. I have made some changes, PTAL.