[0.32,0.33] Browser field in package.json not working

Issue Description
When using a module which implement browser: {} in their package.json, the corresponding module(s) specified in the package.json will return null (Ref 1 and Ref 2) instead of an empty object as per the spec. This then throws an Unknown module error because the packager assumes that it didn't find a module when getting null (Ref).
I tracked the issue down to the new version of node-haste being used in React Native since the 0.32 version (cc @davidaurelio), but I'm not sure of how to fix it myself.
Steps to Reproduce / Code Snippets
Import a package using the browser field in package.json to ignore modules. https://github.com/yahoo/intl-messageformat for example (Ref package.json and incriminating line)
Expected Results
it should import an empty object instead of throwing an error.
Additional Information

React Native version: [0.32, 0.33]
Platform(s) (iOS, Android, or both?): packager
Operating System (macOS, Linux, or Windows?): *

cc @davidaurelio

I'm seeing this problem too with https://github.com/philikon/ReactNativify

To summarize this problem:
(1) Package.redirectRequire() will return false if the browser field for the dependency is false in that package's package.json: https://github.com/facebook/react-native/blob/0.32-stable/packager/react-packager/src/node-haste/Package.js#L84-L87
(2) Based on that false return value, we return null for the respective module when resolving the dependency: https://github.com/facebook/react-native/blob/0.32-stable/packager/react-packager/src/node-haste/DependencyGraph/ResolutionRequest.js#L342-L345
(3) Later, we filter the dependencies and don't include any that are null (and we have no mocks in the default configuration) for the value that we pass to ResolutionResponse.setResolvedDependencyPairs(): https://github.com/facebook/react-native/blob/0.32-stable/packager/react-packager/src/node-haste/DependencyGraph/ResolutionRequest.js#L161-L178
(4) So by the time we rewrite the require() call in the bundle, we no longer have an record of that dependency, so we simply do not end up rewriting the call: https://github.com/facebook/react-native/blob/0.32-stable/packager/react-packager/src/Resolver/index.js#L197-L204
Without knowing too much of the internals of the packager, I think an elegant way to fix this would be to provide an empty module and return that instead of doing nothing in (3). Then the machinery in (4) simply does its normal thing, rewriting the require() call to require(27) where 27 would be the module ID of the empty module.
Thoughts, @davidaurelio?

Yeah, I guess the time to fix this has finally come :-P
as @philikon suggested, doing the following should work:

Add an empty file somewhere, maybe next to ResolutionRequest. Or maybe in DependencyGraph/assets
Instead of returning null, return the absolute path to that file.

If anybody wants to send a PR, just ping me on Messenger and I will shipit. I don’t always read github notifications. Otherwise I will do it tomorrow, London time.

Thanks much for the fix, @davidaurelio!

This isn't working in version 0.41.2


WIP: DDEV upgrade

We will try to use https://ddev.readthedocs.io/en/stable/users/cli-usage/#nodejs-npm-nvm-and-yarn

^^ @adamhstewart


Cryptoblepharus litoralis is intertidal

currently marked as terrestrial. not an issue now since only has one thermal limit, but when we add species with one thermal limit make sure to change!!

fixed :)


Current Value displaying incorrect data

When Current Valaue toggle is pressed in positions section of portfolio....its displaying the wrong value on 59 of 61 of my markets.....
see screenshot (59 of them all show the same current value)

Fixed by https://github.com/AugurProject/augur-node/pull/843


Small cleanup of green and yellow button/axis.

Lol whoops, that wasn't supposed to happen! Copy-paste error

no worries.  I'm working on a diy drum brain and was looking through your code for hints about how to do the USB HID stuff and came across this ;-)

Nice! Hope that goes well.


Lowered minimum invar cases, so essence replicator multiblock can fit required hatches

Essence replicator can't house required hatches with 26 of possible 31 slots taken by Heat Proof Invar casings
For recipes that require both item and fluid input and output, there is not enought space for energy hatch or parallel hatch. 23 will allow for 1 of each input + output hatch and bus, 2 energy hatches, maintenance hatch and parallel hatch.

Closing as it's duplicate of #83


Matplotlib code is missing plt.show()

Thank you for the amazing resources you have created: the book, python-control, and this example Python code!
Not being a matplotlib expert, I struggled initially with the first example (figure-1.11-cruise_robustness.py), as the script ran without errors but did not produce any visible output.
I eventually realised I just needed to add the line:
plt.show()
Your original development environment is probably Spyder, iPython, Jupyter, or some other shell where matplotlib automatically runs in interactive mode (%matplotlib auto), and therefore you didn't need plt.show().
In my case, I am running the examples in a terminal in VS Code, and plt.show() is needed.
I suggest that the README be expanded to explain this?

Fixed in 4ebb8fa710a55f158d31f1702afe8816d6a3b11d.


Some further docs on HA Matter integration

When I installed the plugin HA also seems to have activated it's default Matter support.
But when I click "Configure" I get the following question that I don't know how to answer:

Perhaps this could be added to the README with advise on what the correct/best/suggested action is?

Hi,
thanks for your interest.
The correct answer is yes use the official Matter Server add-on.
Just to understand, before you installed the matterbridge-home-assistant-addon, you didn't have Matter Server installed?
And this question pops up as consequence of installing matterbridge-home-assistant-addon?

Hi, indeed, AFAIK I did not have the Matter Server installed, it is in the "Discovered" section. And when I clicked configure it asked me that question. I just accepted it and HA proceeded to install the plugin.

I had the same question like @quintesse. HA installed the Matter integration, but if does not shown any devices:

In the Matterbridge addons, I've enabled and configured zigbee2mqtt, and Matterbridge sees the devices.
But the aren't shown in the Matter integration. What am I missing?


Fix broken negation example in documentation

What is this change?
The existing examples for negation when used verbatim result in the following error:
dry-logic-1.5.0/lib/dry/logic/builder.rb:48:in `instance_eval': wrong number of arguments (given 0, expected 1..3) (ArgumentError)

          instance_eval(&context)
                        ^^^^^^^^

From the error and the test cases it looks like this is intended to be invoked with a block.
This PR updates the documentation with a working example.

Thanks @Drenmi!


couldn't access traefik gateway or svc behind it

First, great talk, Meysam. Highlight of the conference.
New to Docker Compose, Followed alone, but not really understand network_mode: "host" option in traefic gateway.
from: https://docs.docker.com/compose/compose-file/#network_mode
gives the container raw access to host’s network interface
not sure what it means
and my setup failed to curl svc.dockercon2022.com and localhost:8080
feel like I missed some point
here's the situation:
vislab@vislab-MS-7845 [10:34:45 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik] [master]
-> % tail -n 3 /etc/hosts
# for dockercon2022 test
<IP_ADDRESS>    svc.dockercon2022.com
<IP_ADDRESS>    svc-crud.dockercon2022.com

vislab@vislab-MS-7845 [10:40:56 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik] [master]
-> % docker-compose version
Docker Compose version v2.5.0

vislab@vislab-MS-7845 [10:41:31 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik] [master]
-> % docker-compose up -d
[+] Running 1/1
 ⠿ Container traefik-gateway-1  Started                                                                                0.2s

vislab@vislab-MS-7845 [10:41:37 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik] [master]
-> % curl localhost:8080
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Connection refused

vislab@vislab-MS-7845 [10:42:38 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik] [master]
-> % docker-compose ls
NAME                STATUS              CONFIG FILES
traefik             running(1)          /home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/individual-services/traefik/docker-compose.yml

or use entire-platform
vislab@vislab-MS-7845 [10:45:29 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform] [master]
-> % docker-compose up -d
[+] Running 13/13
 ⠿ Network dockercon2022_redis             Created                                                                                0.0s
 ⠿ Network dockercon2022_svc1              Created                                                                                0.0s
 ⠿ Network dockercon2022_svc2              Created                                                                                0.0s
 ⠿ Network dockercon2022_svc3              Created                                                                                0.0s
 ⠿ Network dockercon2022_postgres          Created                                                                                0.0s
 ⠿ Container dockercon2022-svc2-copy-1     Started                                                                                1.6s
 ⠿ Container dockercon2022-gateway-1       Started                                                                                0.5s
 ⠿ Container dockercon2022-svc2-1          Started                                                                                1.5s
 ⠿ Container dockercon2022-redis-1         Started                                                                                1.3s
 ⠿ Container dockercon2022-postgres-1      Started                                                                                1.0s
 ⠿ Container dockercon2022-svc1-1          Started                                                                                1.2s
 ⠿ Container dockercon2022-svc3-migrate-1  Started                                                                                1.6s
 ⠿ Container dockercon2022-svc3-1          Started                                                                                2.0s

vislab@vislab-MS-7845 [10:45:45 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform] [master]
-> % docker-compose ls
NAME                STATUS              CONFIG FILES
dockercon2022       running(7)          /home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-traefik.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-svc1.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-svc2.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-svc2-copy.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-svc3.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-postgres.yml,/home/vislab/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform/compose-redis.yml

vislab@vislab-MS-7845 [10:45:50 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform] [master]
-> % curl http://svc.dockercon2022.com/v1/
curl: (7) Failed to connect to svc.dockercon2022.com port 80 after 0 ms: Connection refused

vislab@vislab-MS-7845 [10:47:03 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform] [master]
-> % nslookup svc.dockercon2022.com
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>#53

Name:   svc.dockercon2022.com
Address: <IP_ADDRESS>

vislab@vislab-MS-7845 [10:47:36 PM] [~/Downloads/20220510_DockerConf/testDir/test002/dockercon2022-talk/entire-platform] [master]
-> % curl localhost:8080
curl: (7) Failed to connect to localhost port 8080 after 0 ms: Connection refused

Thanks, @RichardLee0211 for bringing this up and for the kind words. I have faced some issues with the macOS earlier, could you specify why OS you're using?
Also, to answer your question,network_mode: host is just as if you run the application in your host machine without any container because the application inside the container would attach to the network of your local machine; therefore naming "host". This means that if the application is opening ANY port, that port will be exposed on your local machine.
For example, if I run nginx with the network_mode: host mode, it would simply be as if I run the Nginx binary inside my machine, listening on port 80 and giving access to anyone inside my network to see the index page of the Nginx.
I hope this clears things up for you.

weird, It's ubuntu 22.04
-> % uname -a
Linux vislab-MS-7845 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

weird, It's ubuntu 22.04
-> % uname -a
Linux vislab-MS-7845 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux


Add automatic tests for Angular 1.3.x and 1.2.x

Decided not to proceed with this.

Since we expect AngularJS to keep up with Semantic versioning, nothing in the 1.x changes should break compatibility with our directive.
Testing for every possible release in Angular will be a tedious task, for a very small benefit.
Most of the work that the directive does is directly tied to the DOM, so the interaction with Angular itself is pretty minimal, which means that the risk of incurring into an issue with a version of Angular is quite unlikely.


Async Request fix for Dynamic Client

/kind bug
What this PR does / why we need it?
async creation of custom resources (CR) using the Custom Resource Definition is failing with the following error
AttributeError: 'ApplyResult' object has no attribute 'data'
Fix for the issue:
For Async call meta_request(func) is failing because response object is different for async vs sync call.The following fix will make sure that response object is same for synchronous and asynchronous calls.
Which issue(s) this PR fixes:
https://github.com/kubernetes-client/python/issues/1626
Special notes for reviewer:
Usually for all async calls we get the response when we make the following call thread.get() but incase of dynamic client async calls I don't see that behavior because of the meta_request(func) is already parsing the response.
Does this PR introduce a user-facing change?
NONE

/assign @yliaog

/assign @venukarnati92

@yliaog : Can you please review my PR and let me know if I need to make any changes.

/close


Archery butte not work for player

Archery butte not work for player. GM can train
"You can't reach that."
if you stay closer - "You are too close to the target"
also player can take arrows from butte

work fine

not work in latest build again

still not work


Chat breaks if only participant is self

Pariticipants !you could be empty (if you are only participant)

@keybase/react-hackers


fix: displaying duplicate command suggestions

Fixes https://github.com/sxyazi/yazi/issues/955
Also added a test for this bug as a suggestion.
Let me know how you would prefer testing to be done in this project!

Thanks for the PR!
I don't think this test is necessary because KEYMAP.init can only be called once, and it's difficult to assume whether it will appear in other tests.
It contains unsafe code, so currently, it's restricted to only being used in the init method of each crate (like this https://github.com/sxyazi/yazi/blob/3a091553283de223dc664a012ae5cd8e1c35933e/yazi-adaptor/src/lib.rs#L33) and I don't want to spread unsafe code into tests, so could you remove the test and only modify the minimum code?

I think that makes sense. I actually noticed there were issues trying to add another test, probably because the RoCell was already allocated, making for weird errors 😄
The test has now been removed.

Yes, duplicates are removed every time.
@sxyazi I just noticed this doesn't yet preserve the order of the suggestions, so the suggestions can appear in a random order now. I'll fix this soon.

Ok, order is now preserved 🙂

Thanks!

I like your refactoring, nicely done 👍🏻


Modify batcher to send PayloadAttributes.justification to L1 calldata

Depends on #15

This is done automatically by including the justification in the BatchData struct


Handle column key misses

Rendering currently fails with an unhelpful KeyError if a column's key doesn't exist in the source data.
Default to raising a sensible exception, but also add a flag to allow optional keys.

Now that I've looked at the code and refreshed my memory, the intention was always to just return None for missing data.
I've gone as far as to fix that functionality, but I won't add any feature flags until I've got a clearer idea where they would be useful.


Scaleset size update

Summary of the Pull Request
Size is not increased for the scaleset when it is resized, thus leaving it in a hanging state of resize when scaling up.
What is this about?
The condition mentioned at https://github.com/microsoft/onefuzz/blob/3b3572d0b364df0bc9e354804b92f45672259e3e/src/api-service/app/onefuzzlib/pools.py#L684:L690
logging.info(
                    "resize is finished, waiting for nodes to check in: "
                    "%s (%d of %d nodes checked in)",
                    self.scaleset_id,
                    node_count,
                    self.size,
                )

is never fulfilled when I am trying out server side self-scaling especially when I have to scale up. I cannot see the scaleset size increasing when a new node is registered. This condition will add only if number of nodes get greater than scaleset size specified.
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
Also added logging steps, which were helpful in my debugging. let me know if it is not needed.
How does someone test & validate?
Tested manually with pool scaling work.

Scaleset.size is intended to be the "how big does the user want this scaleset".   This PR converts this to "how many nodes have checked in".
In #90, I refactored how resizing works such that we'll maintain Scaleset.size during grow and shrink events in a simpler fashion.

I will wait to check my changes after #90 lands. Thanks for looking into it.


allow any whitespace to be used in auth header

According to RFC 7235 (https://tools.ietf.org/html/rfc7235#appendix-C) Authorization header definition allows multiple whitespaces to be used between scheme and token. Also, we derive a bit from the standard stripping the string (see auth-scheme definition), but for simplicity, I propose just splitting the header value. This should return the following:
>>> '  Bearer  123  '.split()
['Bearer', '123']

Please recreate PR to valid master if you still interested in further duscussion


keyboard not working

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Bug
Cannot type in editor the 'e' or 'r' as they are interpreted as the 'delete' key and 'tab' key respectively.
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:39:46.686Z)
OS version: Linux x64 3.10.0-1160.15.2.el7.x86_64
Restricted Mode: No

System Info

Item
Value

CPUs
AMD EPYC 7742 64-Core Processor (128 x 2246)

GPU Status
2d_canvas: unavailable_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
6, 6, 6

Memory (System)
503.38GB (167.93GB free)

Process Argv
--crash-reporter-id 06994271-a7f4-4774-8b13-5560df0b2d8a

Screen Reader
no

VM
0%

DESKTOP_SESSION
undefined

XDG_CURRENT_DESKTOP
undefined

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
undefined

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392cf:30425750
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30429731
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30433059
pythonvs932:30410667
wslgetstartedc:30433508
vsclayoutctrc:30437038
vsrem710:30416614
vscop841:30437297
dsvsc009:30436279
vsbas813:30436447

Let's first try to find out what command executes on your machine, with your settings and your keybindings when pressing e. Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.


SSR not working correctly

It doesn't do SSR for me. I have changed DISABLE_SSR global variable to false, but when I turn off JavaScript or open source code it doesn't show expected content.

@MartinCerny-awin
SSR doesn't means it can run with .js disabled , I guess you misunderstanding about it.
If SSR doesn't work, you won't see the data is presented on the "source code" window. Speaking to this starter you can see the "user lists" data is presented on the "source code" window. You can set the "DISABLE_SSR" to true to compare it.

I think that mine understanding of SSR is correct. Every article that I found describes it in this way:

Once the request is done processing, your browser gets back the fully rendered HTML and displays it on the screen.
Source

The last project that I did using react doesn't need JavaScript on the client to render the content. You can also view HTML elements when you go to the source code. You can try it here
I do not think that this repository has correct implementation of SSR.

@MartinCerny-awin Yea, I got your point. I will check it, thanks.

Hi @MartinCerny-awin It's just a little bug. I already fixed it, please help to verify it.

It works perfectly now

@MartinCerny-awin Thanks man ;)


issues ui mzformsheet on ios 8

I used mzformsheet on ios8, when i rotate ipad and show formsheet is error UI.
link screen error https://www.flickr.com/photos/129737979@N04/

it is only on iPad ?
On my iPhone 5c in ios8 it good....

Yes, it fail in ipad

Soon i am going to work on version 2.0.0 and iOS8 will be fixed.

I fix that issue adding shouldUseNativeBlurEffect for iOS8 which is default ON.
I also rewritten MZFormSheetController to MZFormSheetPresentationController which is build on iOS8+ and don't use UIWindow tricks. I am sure that you will not have problem if you use it


Check and emit fixes for async iteration

This changes the emit for the __asyncGenerator and __asyncDelegator helpers to fix issues with yield* delegation in an async generator. The main change involves modifying __asyncDelegator to use a two-phase approach to iteration:

Return the iterator result of a next/throw/return to __asyncGenerator as if it were an await and switch phase. After awaiting the result, __asyncGenerator sends it back to the delegator via a call to its next method.
Process and return the sent value and return an iterator result to __asyncGenerator either as a yield or a return and switch phase.

This also addresses a bug in the checker and correctly emits __asyncValues in some cases where it was missing.
This also addresses an issue where a Promise rejection during delegation of an async iterator was not properly handled.
Fixes: #15143, #14725, and #14442
Related: Microsoft/tslib#29

I will cherry-pick these changes into release-2.3 this evening.


Bug: Strange behaviours of Giteabot when request a review of user

ref https://github.com/go-gitea/gitea/pull/26729

I don't see an issue, if @KN4CK3R is requested to review then we ignore his blocking review. Otherwise, his review is relevant and blocks the PR. This matches the icons in GitHub's widget.

What behavior did you expect?

Related https://github.com/GiteaBot/gitea-backporter/issues/74
CC @silverwind

I think lunny talks about the added lgtm/done label in the last line. The review request should not have changed that because I still blocked the PR at that time.

The feature request lists the opposite

But I did not approve the changes previously, I requested changes. Therefore the status should always be blocked.

I did notice the bot sometimes adding wrong lgtm/done while commenting on code too, so there is definitely some bug there. If the checkmark count is correct, I suspect it's a bug on GitHub's side because they should not have set the checkmark.

Please decide what the desired behavior should be, and I will implement it.

But the re-request of a negative review does not clear the merge block on Github.

See this PR https://github.com/go-gitea/gitea/pull/25396
I blocked it and requested changes. My re-review is requested and the icon is yellow. Still the bottom shows that I block that PR at the moment:

How about #105 then?


analyzer: Simplify getting the ProjectAnalyzerResult in tests

Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

This change is

Closing this as it's now included in https://github.com/heremaps/oss-review-toolkit/pull/1475.


Avoid C# GC when deserializing large messages

Progress towards fixing https://github.com/grpc/grpc/issues/13236.

add new SegmentDeserializer field into marshaller (that takes ArraySegment instead of byte[]). the backward compatibility is maintained as the new deserializer fallbacks to older byte[] (with some overhead though) based serializer if not defined explicitly
when deserializing messages, don't always allocate a new byte array, but instead reuse a thread-local byte array that is allocated for that purpose. That byte array is always-growing, but it's a weak reference, so the runtime can free the memory if it grows too big and memory is needed (the expectation is users shouldn't really use messages larger >X MB or so at that makes little practical sense - they could always use streaming).
new ParseFrom(buffer, offset, count) API from Protobuf 3.5+ is used to allow parsing messages from byte array that is potentially larger than the message size.  Users would need to regenerate their .proto generate code to benefit from this optimization.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

CC @azyobuzin

[microbenchmarks] No significant performance differences

It looks great as to deserializing mesages and shows me the expected GC timings (with https://github.com/grpc/grpc/pull/13440#discussion_r155264141 ). Thank you.

@jtattermusch is this waiting on review?

@apolcyn  I temporarily interrupted work on this PR to take care of other things (cmake & test flakiness). I'll get back to it when I'm back from vacation.

Superseded by https://github.com/grpc/grpc/pull/18865 which provides a better solution.


index out of range [0] with length 0

> gdmd google-main/play
panic: runtime error: index out of range [0] with length 0

What is this repo? Can you share a link? Cannot google it.

https://github.com/3052/google

problem is here:
https://github.com/chocolacula/gdmd/blob/42681cc7bcd98ff879186c14104a3996ba6a7fa8/cmd/gdmd/types.go#L99-L102
a receiver does not have to have any names, example
func (GoogleCheckin) Marshal(device *GoogleDevice) ([]byte, error)

some more examples in this section
https://go.dev/ref/spec#Selectors

problem is here:
https://github.com/chocolacula/gdmd/blob/42681cc7bcd98ff879186c14104a3996ba6a7fa8/cmd/gdmd/types.go#L99-L102
a receiver does not have to have any names, example
func (GoogleCheckin) Marshal(*GoogleDevice) ([]byte, error)

as shown here:
ParameterDecl  = [ IdentifierList ] [ "..." ] Type .

a parameter can be just a type without an identifier
https://go.dev/ref/spec#ParameterDecl

problem is here:
https://github.com/chocolacula/gdmd/blob/42681cc7bcd98ff879186c14104a3996ba6a7fa8/cmd/gdmd/types.go#L99-L102
a parameter can be just a type without an identifier:
ParameterDecl  = [ IdentifierList ] [ "..." ] Type .

https://go.dev/ref/spec#ParameterDecl
fix:
recv := ""
if f.Decl.Recv != nil {
   if f.Decl.Recv.List[0].Names != nil {
      recv = f.Decl.Recv.List[0].Names[0].Name
   }
}

https://github.com/chocolacula/gdmd/issues/8


Unable to delete OAuth2 from consumer

Summary
Whenever I try to delete OAuth 2 from a consumer, I get server error.
Steps To Reproduce

Create a new API, consumer and OAuth2 on consumer

http POST http://<IP_ADDRESS>:8001/apis name=my-rest-api request_path=/openapi/v1/my-rest-api upstream_url=http://localhost:8080/provider strip_request_path=true

http http://<IP_ADDRESS>:8001/apis/my-rest-api/plugins/ name=oauth2 config.scopes=email,phone,address config.mandatory_scope=true config.enable_authorization_code=true

http POST http://<IP_ADDRESS>:8001/consumers/ username=apidemo

http POST http://<IP_ADDRESS>:8001/consumers/apidemo/oauth2/ name="Demo App" redirect_uri=http://getkong.org

Try to delete OAuth 2 from the consumer:

http DELETE http://<IP_ADDRESS>:8001/consumers/apidemo/oauth2/1be17fe4-2555-4374-9c88-ef4d04d57af2

HTTP/1.1 500 Internal Server Error
Access-Control-Allow-Origin: *
Connection: keep-alive
Content-Type: application/json; charset=utf-8
Date: Sun, 18 Sep 2016 15:04:15 GMT
Server: kong/0.9.1
Transfer-Encoding: chunked

{
    "message": "An unexpected error occurred"
}

Additional Details & Logs

Kong version: 0.9.1
Operating System: Mac OS X 10.11.6, running in Docker

@petrdvorak are you using Cassandra or Postgres?

Thank you for looking into it - I use Cassandra.

@petrdvorak does creating the following index on Cassandra make it work?
CREATE INDEX IF NOT EXISTS ON oauth2_authorization_codes(credential_id);

Hello @thefosk, yes - adding this index does help, OAuth2 credentials were removed after I called that DELETE method...

@petrdvorak I will submit a patch for 0.10 (since it cannot be included in 0.9.2 because a database schema operation is involved).

No problem, @thefosk - the workaround is quite viable...

Merged #1656, thanks for the report.


Rework how the Kotlin plugin is configured

This doesn't fix the classloading problems that we may encounter in projects (because of conditional application of plugins), but it is technically more correct.


When i train chatbot it show following error.plz help me

(base) C:\Users\syed shah Shah>cd desktop
(base) C:\Users\syed shah Shah\Desktop>cd weatherbot
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>pyhon train_init.py
'pyhon' is not recognized as an internal or external command,
operable program or batch file.
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>python
Python 3.7.3 (default, Mar 28 2019, 10:38:38) [MSC v.1915 32 bit (Intel)] :: Ana
conda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.

(base) C:\Users\syed shah Shah\Desktop\Weatherbot>python train_init.py
Using TensorFlow backend.
Traceback (most recent call last):
File "train_init.py", line 17, in
agent = Agent('weather_domain.yml', policies = [MemoizationPolicy(), KerasPo
licy()])
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\rasa_core\policies\k
eras_policy.py", line 26, in init
import keras
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras_init_.py",
line 3, in
from . import utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils_init_
.py", line 6, in
from . import conv_utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils\conv_uti
ls.py", line 9, in
from .. import backend as K
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend_init
.py", line 1, in
from .load_backend import epsilon
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\load_b
ackend.py", line 90, in
from .tensorflow_backend import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\tensor
flow_backend.py", line 5, in
import tensorflow as tf
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow_init.
py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-im
port
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python_
init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow_internal.py", line 114
def TFE_ContextOptionsSetAsync(arg1, async):
^
SyntaxError: invalid syntax
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>oython train_init.py
'oython' is not recognized as an internal or external command,
operable program or batch file.
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>python train_init.py
Using TensorFlow backend.
Traceback (most recent call last):
File "train_init.py", line 17, in
agent = Agent('weather_domain.yml', policies = [MemoizationPolicy(), KerasPo
licy()])
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\rasa_core\policies\k
eras_policy.py", line 26, in init
import keras
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras_init_.py",
line 3, in
from . import utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils_init_
.py", line 6, in
from . import conv_utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils\conv_uti
ls.py", line 9, in
from .. import backend as K
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend_init
.py", line 1, in
from .load_backend import epsilon
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\load_b
ackend.py", line 90, in
from .tensorflow_backend import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\tensor
flow_backend.py", line 5, in
import tensorflow as tf
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow_init.
py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-im
port
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python_
init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow_internal.py", line 114
def TFE_ContextOptionsSetAsync(arg1, async):
^
SyntaxError: invalid syntax
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>python train_init.py
Using TensorFlow backend.
Traceback (most recent call last):
File "train_init.py", line 17, in
agent = Agent('weather_domain.yml', policies = [MemoizationPolicy(), KerasPo
licy()])
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\rasa_core\policies\k
eras_policy.py", line 26, in init
import keras
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras_init_.py",
line 3, in
from . import utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils_init_
.py", line 6, in
from . import conv_utils
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\utils\conv_uti
ls.py", line 9, in
from .. import backend as K
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend_init
.py", line 1, in
from .load_backend import epsilon
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\load_b
ackend.py", line 90, in
from .tensorflow_backend import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\keras\backend\tensor
flow_backend.py", line 5, in
import tensorflow as tf
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow_init.
py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-im
port
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python_
init_.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\syed shah Shah\Anaconda3\lib\site-packages\tensorflow\python\py
wrap_tensorflow_internal.py", line 114
def TFE_ContextOptionsSetAsync(arg1, async):
^
SyntaxError: invalid syntax
(base) C:\Users\syed shah Shah\Desktop\Weatherbot>

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template


Document how to deploy a workload with the Rancher API

This issue represents a small piece of the work in https://github.com/rancher/rancher-docs/issues/173

Consolidating into https://github.com/rancher/rancher-docs/issues/583.


Updating crates.io index fish: Job 1, 'cargo update' terminated by signal SIGKILL (Forced quit)ing deltas

Problem
The nightly today started what seemed to be a full refresh of the registry when I ran cargo update on a local project.  After getting to ~85% it stopped with the message in the title.   This left behind a zombie cargo update process.
I should note this issue happened on my Linux machine as well as my Mac, with the same message.
Steps

Migrate to a local project
Run cargo update

Possible Solution(s)
No response
Notes
I was able to fix the issue by deleting the ~/.cargo/registry directory and re-running cargo update
Version
cargo 1.68.0-nightly (d992ab4e9 2023-01-10)
release: 1.68.0-nightly
commit-hash: d992ab4e9034930e7809749f04077045af8f4d79
commit-date: 2023-01-10
host: x86_64-unknown-linux-gnu
libgit2: 1.5.0 (sys:0.16.0 vendored)
libcurl: 7.86.0-DEV (sys:0.4.59+curl-7.86.0 vendored ssl:OpenSSL/1.1.1q)
os: Arch Linux [64-bit]

I'm going to consolidate in https://github.com/rust-lang/cargo/issues/11014

Yeah the sigkill here was a red herring.  I was ssh'd from my mac into my linux box and didn't notice it.   I've seen the note about the index normalization today which explains the 95k deltas I was seeing across machines.   Thanks for the update.


feat: Move all constants to Constants class

*added Constants file
*removed unused imports

Opposite of ideal. We want to localize variables as much as possible
Why not also make the recycler view static and global in Constant file AUTH_SIGNUP_RECYCLER_VIEW?
Constants should be in their respective files

Also, never make branches on the repo, create branches on your fork to send PRs

Okay! Got your point :+1:


mongo change stream example for php ?

Bug Report

where can I find any mongo change stream example for php ?
not tailable cursor on a "capped collection", I'd need to "watch" a modifiable collection from php
Environment
WAMP php 7.2 windows

MongoDB support
enabled

MongoDB extension version
1.6.0

MongoDB extension stability
stable

libbson bundled version
1.15.1

libmongoc bundled version
1.15.1

libmongoc SSL
enabled

libmongoc SSL library
OpenSSL

libmongoc crypto
enabled

libmongoc crypto library
libcrypto

libmongoc crypto system profile
disabled

libmongoc SASL
enabled

libmongoc ICU
disabled

libmongoc compression
disabled

Test Script

Expected and Actual Behavior

Debug Log

I see you also posted this question on the mongodb-user mailing list six minutes after opening this issue, and then created https://github.com/mongodb/mongo-php-driver/issues/1050 a few minutes after that (note: change streams are implemented entirely in the library, not the extension).
I've replied on the mailing list thread, and will close both GitHub issues. In the future, please do not cross-post the same question across multiple channels.


Implemented iframe

Codecov Report

Merging #8 into master will decrease coverage by 1.3%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   29.09%   27.78%   -1.31%
==========================================
  Files          22       23       +1
  Lines         488      511      +23
==========================================
  Hits          142      142
- Misses        346      369      +23

Impacted Files
Coverage Δ

src/django_keycloak/urls.py
0% <ø> (ø)
:arrow_up:

src/django_keycloak/views.py
0% <0%> (ø)
:arrow_up:

src/django_keycloak/context_processors.py
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e325e8...0f65813. Read the comment docs.


Search funcion - Peek

Microsoft PowerToys version
0.81.1
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Peek
Steps to reproduce
Clicking the search button or triggering the Ctrl+F shortcut.
✔ Expected Behavior
The text prompt for search terms should appear.
❌ Actual Behavior
The text prompt for search terms doesn't show.
Other Software
No response

Search function inside peek window is not working. Nothing happens after either pressing Ctrl+F or pressing the search icon in the top panel (on the right side).

I finally managed to solve the issue, I disable the Run always without elevated permits even when Powertoys its elevated.
So in the end it was not elevated the Peek powertoy specifically.

I restarted Windows and the problem arised again without changing anything

I figured out that turning off the automatic closing after leaving focusing fix the problem, maybe the search option triggers another app temporarily and the turning off functions takes it as leaving focus and then closes before the search box appears.

Glad you found a solution! I'm unable to reproduce this issue myself as is, so going to close the issue for now. Feel free to open a new issue if you run into a blocking issue here!


Docker is not running after enabling initrd

Running a container is not possible after enabling initrd. It is not possible to enable initrd Jenkins testing (https://github.com/kata-containers/tests/issues/190). The configuration that I used was the following.
$ go get -d github.com/kata-containers/tests
$ cd .ci/
$ export AGENT_INIT=yes TEST_INITRD=yes OSBUILDER_DISTRO=alpine
$ ./setup.sh
After completing the setup of the environment, what I did was
$ docker run --runtime kata-runtime -ti fedora bash
However, the container stays in created
$ docker ps -a
CONTAINER ID   IMAGE    COMMAND             CREATED             STATUS              PORTS               NAMES
7b8f56ba6297   fedora      "bash"              19 minutes ago      Created     affectionate_blackwell
I am using the following configuration:
Ubuntu 16.04.4 LTS
kata-runtime  : 0.0.1
commit   : 427b97c6f53efce2e9a54abf56eff0e75961574d
OCI specs: 1.0.1
Docker version 17.12.1-ce, build 7390fc6

@bergwolf could you please take a look? thanks

@GabyCT what I mentioned in kata-containers/tests#190 is just the suggested environment names for test setup. We need to actually add support for these environment variables in kata-containers/tests before it can work.
From osbuilder side, the accepted environments are DISTRO, DISTRO_ROOTFS, IMG_SIZE and AGENT_INIT.
The suggested TEST_INITRD in kata-containers/tests#190 is to tell the tests to build initrd images and configure initrd images in kata-runtime's configuration file.

@GabyCT Do you still see the issue? I tried ci setup.sh on one of my test machine, found a new issue (kata-containers/tests/issues/333) and fixed it. Then setup.sh sets up initrd test environment properly. Can you please see if kata-containers/tests/pull/334 works for you?

@bergwolf , not anymore. This is already fixed as I was able to run integration docker tests.


CRD State Store Implementation

Create a new State Store called crd that lives here
Use the functions from this package here in the kubicorn code for a new state store

Depends on #579

I can take this one - will start on it today


AugmentedMediaSource not work

The simpleMediaSource and HWMediaSource work well on my computer. But with AugmentedMediaSource, I have tried many times, like using UWP, using Installer, changing some codes, and  virtual camera can be created，but no image shown in preview or CameraApp. When I select the AugmentedMediaSource option, the Installer will crash and UWP reports an unspecified error. the CameraApp also reports an error.

For clean show, I changed some log code. and crash log like below.

Hi,
yes I see the issue, as you can see in the trace, AugmentedMediaStream::Initialize() will filter through the set of MediaTypes exposed on the source you want to wrap and will keep only the one it can understand (i.e. in this case NV12 MediaTypes below 1080p at max 30fps. Problem is that first this routine runs on the client side and I assume your USB camera exposes MJPEG MediaTypes.. which FrameServer duplicates as well as NV12 MediaTypes (decode on the fly. However, when the virtual camera is then created on the frame server side, it does not have access to those MJPEG->NV12 MediaTypes and does not find any other compliant MediaType on any pin of the camera and fails to expose a stream.. (0xc00d36b4 == MF_E_INVALIDMEDIATYPE). There are a couple of things you can do to accommodate your camera in Windows 11 build 22000, although note that in the next release of Windows 11 there will be a new API to avoid this problem entirely..
You could accept MJPEG MediaType to go through in AugmentedMediaStream::Initialize() (and expose them out as NV12 MediaTypes) and insert a MJPEG decoder to decode samples on the fly on your own (see IMFTransform https://docs.microsoft.com/en-us/windows/win32/medfound/basic-mft-processing-model?redirectedfrom=MSDN
I think we need to provide a sample to do this anyway and I will take it as an action item

Thanks very much for the email to guide me fix this, I've made this work.
https://github.com/comor86/Windows-Camera


Fix CI failures with Python 2.7

Fixes #1502
This PR fixes the issues with Python 2.7 in CI. We now use conda to get and install Python 2.7. This is because GitHub decided that it was alright to completely delete their Python 2.7 interpreters from the internet and break the entire world. The funny thing is that they still compile and ship 3.1 and up :shrug:.
~Note that the csh tests are failing for some reasons. I'm really not sure why. I'm tempted to say that we could ditch csh entirely...~
Oh, and I also updated our actions to use more recent versions.

@Jawabiscuit are you of failures on the csh shell tests? You've been running the tests I guess, so maybe you know?

I wouldn't be so quick to throw out csh. Autodesk Flame systems default to it, and I know of environments where rez participates in Flame environments.

@JeanChristopheMorinPerso, csh hasn't posed any problems at all in my testing.

Alright, I fixed the csh issue. It wasn't related to the tests. I fixed it by simply not using fancy action to install conda. Conda already comes pre-installed on the runners so we don't need to install it. I think the action was injecting stuff into the job environment.

Considering that this is only affecting the CI, I'll go ahead and merge with a single approval.


Feature/spellcheck

Fix & reactivate spellcheck

This automatic PR checking is awesome, @ckamm. Feel free to ignore/merge whenever, I mainly wanted to test the new travis integration. :-)

@ludwigschubert Thanks!
It looks like you downgraded the dependencies, was that intentional?

Good catch, updated them instead. ^_^ (This happened when I was automatically resolving merge conflicts. Live & learn.)


Fix the lnd init script

Despite the wallet already being unlocked, the script keeps going into a loop (at least on devnet).

Fixed by this commit


Documentation should be more specific about actions taken

It is not 100% clear from the documentation whether the provider also actually runds grub2-mkconfig after setting/changing settings. It could be argued that it is obvious but for the sake of clarity it would be useful if the documentation could specifically say that grub2-mkconfig is run after setting a value. I looked through the code and that is indeed what happens. I am happy to do a tiny PR for the doc update if there is agreement.

Looks like a duplicate of #40.

Thanks @kenyon

Thanks @kenyon


retry the connection several times

The comment in the code should explain it.
Tried on an Orin: the test passes, but the old version usually passes, too.

:open_mouth: The problem was that I had an ancient version of the Python SDK! Take another look.
This version continues to run fine on an Orin.
The neat thing about this is that canary_tests.sh is auto-updating: tonight it'll run the old script but pull in the new one, and then tomorrow night it'll run the new version.


ISSUE:226 Oracle database support

More info on the pull request :

I have used the following conversions (MySQL -> Oracle)
TEXT -> if data < 4KB then VARCHAR2(4000) else CLOB
TINYINT -> NUMERIC(3,0)
LONG -> NUMERIC(19,0)
INTEGER -> NUMERIC(10,0)
BOOLEAN -> NUMERIC(1,0)
I haven't used Oracle equivalent of "ON UPDATE CASCADE" in migration scripts as Oracle doesn't have any out of box support for this and I couldn't find any use case in SR.
The user has to manually copy the Oracle JDBC driver jar to /bootstrap/lib directory, as it is not straightforward to download the jar from Oracle's website.

Closing this PR as #270 added these changes.
Thanks @raju-saravanan for making these changes in other repo which got pulled into #270


We need wall-mounted TVs

Description

With the advent of entertainment cameras, we could probably use the wall-mounted TVs used by /tg/ and /vg, as there often isn't enough room to place down the wooden television. These could probably be interacted with from a distance to watch, so that multiple people in the bar or kitchen can view them at a time.

Fixed in #8842


Request: vh/vw units, 16px REM

vw/vh: https://css-tricks.com/viewport-sized-typography/

"16px REM" already supports, choose "CSS Rem 12px" and edit scale input to "16".
but vw/vh is not

"16px REM" doesn't work for this. VW/VH calculations don't relate to other elements' font sizes, so we can't just take the numbers calculated from "16px REM", because it doesn't correlate to VW/VH at all. Can we reopen this?


Android emulator not displaying developer menu

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
Running npx react-native run-android builds the app and opens in the android emulator. It will display exceptions as it should in a dev build, but the app doesn't seem to connect to the package manager or allow use of the developer menu.
I have tried adb shell input keyevent 82 as documented, Cmd + M, and shaking the device through the virtual sensors in emulator settings with no results. I also have run adb reverse tcp:8081 tcp:8081 as mentioned in a few issues on stackoverflow.  The yellow warning and red error notification boxes still appear on this build, so it is a certainly a dev build.
This appears to have happened after an update to Android 28 with RN 0.59 and has followed my project on different machines including Windows and Mac.
React Native version:
  React Native Environment Info:
    System:
      OS: macOS 10.15.5
      CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
      Memory: 753.95 MB / 16.00 GB
      Shell: 5.7.1 - /bin/zsh
    Binaries:
      Node: 14.5.0 - /usr/local/bin/node
      npm: 6.14.5 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    IDEs:
      Android Studio: 3.6 AI-192.7<IP_ADDRESS>00805
      Xcode: 11.5/11E608c - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.9.0 => 16.13.1
      react-native: ^0.59.5 => 0.59.10

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Build app with npx react-native run-android
In emulator, try any of the documented methods to display the developer menu

Expected Results
The developer menu should appear with one of the documented steps. However after update to Android 28 it does not.
Snack, code example, screenshot, or link to a repository:
Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

on latest master

True. I'll have a look tomorrow. Related https://github.com/facebook/react-native/pull/29204

The reality is that I never debug Java or JavaScript. I suggest you to use console.log in JavaScript and Log.w in Java, but I'll fix this as soon as I find a solution to https://github.com/facebook/react-native/issues/17530

@fabriziobertoglio1987 I have used logcat in some cases for Android, but a related issue here is that I cannot reload the app from the metro bundler. So when I make changes to my react code, the only way I can reload is by quitting and restarting the app or reinstalling. Is there a better solution that I'm missing with regard to the built in Android Studio debugging tools perhaps?

Hi @ajfick your React Native version is a bit old. Could you verify this still occurs in 0.63?

@safaiyeh I've just verified this on 63.3 - can't pull up the dev menu while in the simulator.

Version 0.63 fixed this issue for my team. @rectified95 Are you able to connect to Flipper? Once we got flipper working, we were able to use the dev tools correctly again by hitting "R,R" in the simulator.


KAFKA-14193: Update expected task configs for FileStream source and sink connectors in ConnectRestApiTest

ConnectRestApiTest is currently failing on trunk and 3.3 with the following assertion error:

AssertionError()
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 183, in _do_run
    data = self.run_test()
  File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 243, in run_test
    return self.test_context.function(self.test)
  File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 433, in wrapper
    return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 106, in test_rest_api
    self.verify_config(self.FILE_SOURCE_CONNECTOR, self.FILE_SOURCE_CONFIGS, configs)
  File "/opt/kafka-dev/tests/kafkatest/tests/connect/connect_rest_test.py", line 219, in verify_config
    assert config_def == set(config_names)

On closer inspection, this is because of the new source connector EOS related configs added in https://github.com/apache/kafka/pull/11775.

Adding the following new configs - offsets.storage.topic, transaction.boundary, exactly.once.support, transaction.boundary.interval.ms in the expected config defs here fixes the tests on the 3.3 branch. However, the tests still fail on trunk due to the changes from https://github.com/apache/kafka/pull/12450.

The plan to fix this is to raise two PRs against trunk patching connect_rest_test.py - the first one fixing the EOS configs related issue which can be backported to 3.3 and the second one fixing the issue related to propagation of full connector configs to tasks which shouldn't be backported to 3.3 (because the commit from https://github.com/apache/kafka/pull/12450 is only on trunk and not on 3.3)

This is the second of the two PRs and should not be backported to 3.3

@C0urante since you also reviewed https://github.com/apache/kafka/pull/12450, could you please review this system test fix whenever possible?


Added the  option, allowing OpenMetrics reports

Codecov Report
Attention: Patch coverage is 85.59322% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.39%. Comparing base (94cfcdb) to head (2d89fbb).

Files with missing lines
Patch %
Lines

src/Report/OpenMetrics/OpenMetricsGenerator.go
87.15%
10 Missing and 4 partials :warning:

src/Command/AnalyzeCommand.go
0.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   53.69%   54.39%   +0.69%
==========================================
  Files          43       44       +1
  Lines        4894     5006     +112
==========================================
+ Hits         2628     2723      +95
- Misses       2038     2050      +12
- Partials      228      233       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Could you provide your training logs of coco caption? Thank you very much!

Could you provide your training logs of coco caption? Thank you very much!

Hi,
Sorry for my late reply.
I only keep this training log of captioning based on X-VLM(16M):
{"train_lr": "0.00001", "train_loss": "3.09465", "test_Bleu_1": 0.7888877725308794, "test_Bleu_2": 0.63571035330044, "test_Bleu_3": 0.5010730538646152, "test_Bleu_4": 0.3913670270575186, "test_METEOR": 0.30496697421985314, "test_ROUGE_L": 0.5970224740919123, "test_CIDEr": 1.317922681426818, "test_SPICE": 0.23711267501362399, "epoch": 0}
{"train_lr": "0.00001", "train_loss": "2.98785", "test_Bleu_1": 0.7908520616358936, "test_Bleu_2": 0.6381588587372502, "test_Bleu_3": 0.5034545904748693, "test_Bleu_4": 0.3940724470046297, "test_METEOR": 0.3044191834423089, "test_ROUGE_L": 0.5968370063641272, "test_CIDEr": 1.324427769391428, "test_SPICE": 0.23648371743116095, "epoch": 1}
{"train_lr": "0.00001", "train_loss": "2.95646", "test_Bleu_1": 0.7900966620445572, "test_Bleu_2": 0.6394082741826733, "test_Bleu_3": 0.5067956381747537, "test_Bleu_4": 0.3990826836166066, "test_METEOR": 0.30812466366805014, "test_ROUGE_L": 0.6003008324478327, "test_CIDEr": 1.335514654758239, "test_SPICE": 0.23785805830856616, "epoch": 2}
{"train_lr": "0.00000", "train_loss": "2.93689", "test_Bleu_1": 0.7885322668167135, "test_Bleu_2": 0.6375335548575466, "test_Bleu_3": 0.5049943737820617, "test_Bleu_4": 0.3974852071709018, "test_METEOR": 0.3076980686063203, "test_ROUGE_L": 0.5984061051446633, "test_CIDEr": 1.332406512277844, "test_SPICE": 0.23666827912166746, "epoch": 3}
{"train_lr": "0.00000", "train_loss": "2.92356", "test_Bleu_1": 0.7897854626961097, "test_Bleu_2": 0.6385248029045398, "test_Bleu_3": 0.5062238463521957, "test_Bleu_4": 0.3988569646467052, "test_METEOR": 0.30886155569362295, "test_ROUGE_L": 0.6002198552354895, "test_CIDEr": 1.3395548597453977, "test_SPICE": 0.2384228247143562, "epoch": 4}


Create GitCheatsheet.md

Git Cheatsheet

Add a link to this cheatsheet in main Readme file.

Have you pushed the changes? I can't see it.


HIDHide Integration goals

A little list and sanity check area for my integration of HIDHide into DS4Windows.
My goal for this is to make DS4Windows completely handle all functions of HIDHide, so that it can do it's job. My mindset is: Seamless, Simple and Clean. Yes, I took any chance I could to mix in some Kingdom Hearts love. Sue me.

Seamless - I don't want it to seem like DS4Windows brings up or talks to HH at all. The user shouldn't notice it, aside from clear messages in the log. If the user has to exit DS4Windows, I've failed my mission. If a CMD window pops up for a moment and exits, I've failed.

Simple - I don't want the user to have to go through multiple tabs and windows to set it all up. I want most of the options grouped together, in a clear area that says "THIS IS WHERE I HIDE MY CONTROLLERS" in a large neon sign. Everything that has to do with managing HH, should be managed here. If the user cannot find the spot to hide their controller, I've Failed.

Clean - No ambiguous wording. No Internal Dev-talk that users won't understand. If there's an error, log it in clear speech. If I'm accessing the driver, Say it in clear speech. The user probably doesn't read the source, so internal comments are fine in dev-talk. But they WILL read the logs occasionally. They will read menus. They will read tooltips. These need to be in clear, clean,  user-friendly speech. Any text that reaches the user must be cleaned. Part of the switch, I believe that getting rid of the term "Exclusive Access" will be required. At-least, in the userland bubble. The user doesn't know what it means, but they will understand what "Hiding the physical controller" means. If the user cannot understand what an option is, I've failed.

With these principals in mind, I have several Main goals, and each have their own sub-goals.

[ ] D4W Adds EXEs to HH

[ ] Check if HidHide exists - HH should give a way to check it's install location (Partially implemented, but not really...)

[X] Check if it can get a hold of HH settings (In main branch)

[x] Check if the inverse whitelist is enabled (Added in https://github.com/Yohoki/DS4WindowsEx/commit/3980836fa35559b9b60ff490104748fb723dcfe9)

[X] Try to add itself to its list and check if it has actually succeeded (Added in https://github.com/Yohoki/DS4WindowsEx/commit/ddd1800284a84cf0a29b7e0fce360959cb714dfe)

[ ] D4W Adds HIDs to HH

[x] Add/remove HIDs from Device list (Fully added in https://github.com/Yohoki/DS4WindowsEx/commit/60bdc0ae244b433e6bbb4bd633a524d1ed5231fc)

[ ] Show HH "Hid Status" and "Exclusive Mode" Separately (Possibly a new Icon)

[ ] Remove references to "Exclusive mode" from user areas

[x] Check if HidHide exists

[x] Check if it can get a hold of HH settings (Finished in https://github.com/Yohoki/DS4WindowsEx/commit/60bdc0ae244b433e6bbb4bd633a524d1ed5231fc)

[ ] Check if the inverse whitelist is enabled

[ ] D4W Is able to clear HH lists to reduce 'clutter' and remove stale HIDs from the lists

[x] Add a clear area to Clear HH's Device list. (Added in https://github.com/Yohoki/DS4WindowsEx/commit/099142e2ee0e6e38d039db85bd6ca60f45ef77a8)

[ ] Annoy user until they know FOR SURE that they're clearing out the damn list and it's not reversible don't start crying afterwards.

[x] Add clear area to Revert HH's Applications list to a default state [with only HH and D4W added] (Added in https://github.com/Yohoki/DS4WindowsEx/commit/099142e2ee0e6e38d039db85bd6ca60f45ef77a8)

[ ] Annoy users before clearing this list as well, because they shouldn't click buttons unless they're ready for the consequence.

[x] Option to clear HH Device list automatically after 100 Devices are added. (if there's 100 devices, they're probably being added automatically anyway) (made it 50 devices. Added in https://github.com/Yohoki/DS4WindowsEx/commit/0f4f8bcdf7729ed60daacc9dd9c61d0506d177c2)

[ ] Safety Checks

[x] Make ABSOLUTELY SURE that paths are being sent properly. If I blue screen, I won't be happy. (Thanks Nefarius https://github.com/Yohoki/DS4WindowsEx/commit/60bdc0ae244b433e6bbb4bd633a524d1ed5231fc)

[ ] Have some testers try it out

[ ] Get feedback from the 2 big devs and some minor devs. Without their hard work, I wouldn't even be doing this.

[x] Preferably use the raw API to handle all code. It's already in the source, so I should use what I can for consistency. But any that is deemed unsafe will use the CLI. It's there for a reason and it has it's own safety checks, I believe. (as of https://github.com/Yohoki/DS4WindowsEx/commit/60bdc0ae244b433e6bbb4bd633a524d1ed5231fc, all code is API driven.)

1st update.
D4W now checks for changes after adding/removing EXEs (either itself or Auto-profile Target). It then reports back if the EXE is currently in the list or not.
Log File - Adding and Removing EXEs
10/16/2022 15:38:35: DS4Windows Assembly Architecture: x64
10/16/2022 15:38:35: OS Version: Microsoft Windows NT 10.0.19044.0
10/16/2022 15:38:35: OS Product Name: Windows 10 Home
10/16/2022 15:38:35: OS Release ID: 2009
10/16/2022 15:38:35: System Architecture: x64
10/16/2022 15:38:36: Running as User
10/16/2022 15:38:36: Some applications may block controller inputs. (Windows UAC Conflictions). Please go to https://docs.ds4windows.app/troubleshooting/kb-mouse-issues/#windows-not-responding-to-ds4ws-kb-m-commands-in-some-situations for more information and workarounds.
10/16/2022 15:38:36: HIDHide: HidHide control device found
10/16/2022 15:38:36: HIDHide: DS4Windows found in current HidHide list.
10/16/2022 15:38:37: Starting...
10/16/2022 15:38:37: Using output KB+M handler: SendInput
10/16/2022 15:38:37: Connection to ViGEmBus 1.21.442.0 established
10/16/2022 15:38:37: Searching for controllers...
10/16/2022 15:38:37: Using Exclusive Mode
10/16/2022 15:38:37: UDP server listening on address <IP_ADDRESS> port 26760
10/16/2022 15:39:06: HIDHide: HidHide control device found
10/16/2022 15:39:06: HIDHide: ACOdyssey not found in HidHide list. Adding to list
10/16/2022 15:39:06: HIDHide: ACOdyssey found in current HidHide list.
10/16/2022 15:39:11: HIDHide: HidHide control device found
10/16/2022 15:39:11: HIDHide: ACOdyssey found in HidHide list. Removing from list
10/16/2022 15:39:11: HIDHide: ACOdyssey not found in current HidHide list.
10/16/2022 15:39:34: HIDHide: HidHide control device found
10/16/2022 15:39:34: HIDHide: Bayonetta not found in HidHide list. Adding to list
10/16/2022 15:39:34: HIDHide: Bayonetta found in current HidHide list.
10/16/2022 15:39:41: HIDHide: HidHide control device found
10/16/2022 15:39:41: HIDHide: Biped not found in HidHide list. Adding to list
10/16/2022 15:39:41: HIDHide: Biped found in current HidHide list.
10/16/2022 15:40:01: HIDHide: HidHide control device found
10/16/2022 15:40:01: HIDHide: CHRONOCROSS not found in HidHide list. Adding to list
10/16/2022 15:40:01: HIDHide: CHRONOCROSS found in current HidHide list.
10/16/2022 15:40:07: HIDHide: HidHide control device found
10/16/2022 15:40:07: HIDHide: cmd not found in HidHide list. Adding to list
10/16/2022 15:40:07: HIDHide: cmd found in current HidHide list.
10/16/2022 15:40:11: HIDHide: HidHide control device found
10/16/2022 15:40:11: HIDHide: cmd found in HidHide list. Removing from list
10/16/2022 15:40:11: HIDHide: cmd not found in current HidHide list.
10/16/2022 15:40:14: HIDHide: HidHide control device found
10/16/2022 15:40:14: HIDHide: CHRONOCROSS found in HidHide list. Removing from list
10/16/2022 15:40:14: HIDHide: CHRONOCROSS not found in current HidHide list.
10/16/2022 15:40:33: HIDHide: HidHide control device found
10/16/2022 15:40:33: HIDHide: Biped found in HidHide list. Removing from list
10/16/2022 15:40:33: HIDHide: Biped not found in current HidHide list.
10/16/2022 15:40:40: HIDHide: HidHide control device found
10/16/2022 15:40:40: HIDHide: Bayonetta found in HidHide list. Removing from list
10/16/2022 15:40:40: HIDHide: Bayonetta not found in current HidHide list. ````

</details>

It already checked if HH was installed before, but now it will also throw a log when an EXE is trying to be added to the list, but HH is not installed. I will probably move this later to a place where it's only run on startup, but for now it's fine.

2nd update.
Added the UI changes for the settings tab, including early tooltips with instructions, warnings, and details.

UI starting to get it's function. D4W now checks HH's state on start-up. Inverse whitelist isn't checked until the API documents are updated. The "Enable HidHide" button works as well. It will turn off device hiding in HH. Should be safely checking if it has permission to read/write (and if HH is even installed) first.
Next up: Clearing the lists and adding controllers.

Got the buttons working to clear the lists.
Clearing the device list will remove ALL devices from the HH device list. This shouldn't be a problem for D4W, since we'll have options to add them back automatically or manually from within the app.
Clearing the Whitelist is a bit more in-depth. It will get a current whitelist from HH and scan each line. It will delete any line from that list unless it ends with "hidhideclient.exe", "hidhidecli.exe", "ds4windows.exe" or the custom EXE name from the settings. This should create a clean and fresh list in case something has been added wrong, or messed up in some way or another.

New feature in commit https://github.com/Yohoki/DS4WindowsEx/commit/0f4f8bcdf7729ed60daacc9dd9c61d0506d177c2
Auto-clearing device list now works.
If the "Keep Dev List Clean" option is set, D4W will check the DeviceList on startup and during refreshing HH's Status. If that number is 50+, it will automatically clear the list, most likely removing mostly stale device HIDs. The list should only get full like that if a user is automatically adding HIDs (Which we'll be doing) so any non-stale devices should get added back in automatically. (at least, when the feature is implemented)

Update on commit https://github.com/Yohoki/DS4WindowsEx/commit/60bdc0ae244b433e6bbb4bd633a524d1ed5231fc
This build is now ready for internal (Dev) testing. Most of the functions I needed are now in. The only thing left is cleaning up and making the user more aware of what's happening. Mainly logs, messages and I have an Icons in mind that need made. At this point, I think the code's ready to take some feedback, and the program is ready to be tested by devs to see if it all works good and if it's clear what everything is doing. I'd love to see @Kanuan and @Ryochan7 try it out. And I'd love to see feedback about the code from @Nefarius and Ryochan7. If I need to make any major changes to the code, now's the time.
This also does not include the newer ViGEm DLL. That's in a separate PR from Nefarius, so I figured I should leave it out.
Features are all inside the Settings Tab. You'll see a group that includes the old Ex-Mode and all the HidHide features.

Status and Check Button
Shows if HH is active, inactive or unknown (uninstalled/tied up)
Enable HidHide
Sets and tracks HidHide's Active state.
Use Blacklist
Sets and tracks HH's "Invert Whitelist" option.... But that sounds intuitive, and I'm sure Nefarius didn't have that function in mind when he named the other lists. XD
Hide new devices
Adds currently connected devices to HH's list, and their parent devices. Adds any newly connected Devices and parents to the list as well. (Persistent)
Keep device list clean
Attempts to keep stale devices out of HH's list by clearing the list completely after 50 devices have been added.

It's a feature that it doesn't add the devices back AFTER clearing them.... not a bug..... I promise....

Clear Device/App list
Clear HH's device or app list from within D4W. Auto-adds HidHide, HidHideCLI, DS4Windows and D4W's Custom named EXE.

Also not a bug that it doesn't then re-add devices, and I definitely won't change that in the next update......

If trying to check HidHide state and it fails, the "Enable HidHide" and "Blacklist" Checkboxes will revert to unmarked instead of "unkown"
If HidHide state is "unkown", it might be useful to set related options to IsEnabled=False,  or maybe hiding them entirely since their information is useless and their actions will not work
Status should show "Active (blacklist)" if blacklist is enabled
Might  be useful to have an option "Auto enable/disable HidHide with DS4Windows" so device hiding is enabled/disabled when starting/stopping DS4Windows
Instead of showing all options directly in the settings, it might be useful to have a "Show advanced options" checkbox. Options that should be hidden as "advanced" could be:

Wipe Apps/Device lists
Enable Blacklist
Enable auto-hiding
Auto enable/disable HidHide along DS4Windows

If trying to check HidHide state and it fails, the "Enable HidHide" and "Blacklist" Checkboxes will revert to unmarked instead of "unkown"

Not sure how to display unknown with a check. That's why they're cleared.

2. If HidHide state is "unkown", it might be useful to set related options to IsEnabled=False,  or maybe hiding them entirely since their information is useless and their actions will not work

-planned

3. Status should show "Active (blacklist)" if blacklist is enabled

-added this morning.

4. Might  be useful to have an option "Auto enable/disable HidHide with DS4Windows" so device hiding is enabled/disabled when starting/stopping DS4Windows

Hmm... possibly. Shouldn't really be a reason to turn it off to begin with. But maybe.

5. Instead of showing all options directly in the settings, it might be useful to have a "Show advanced options" checkbox. Options that should be hidden as "advanced" could be:

   * Wipe Apps/Device lists
   * Enable Blacklist
   * Enable auto-hiding
   * Auto enable/disable HidHide along DS4Windows

Planned. I wouldn't consider them all advanced, but ya. That's something to consider.

Really only 4 more things to add and this is done. Commit https://github.com/Yohoki/DS4WindowsEx/commit/3e551d2281407a557ffe6377209724e15666d939 added a change I'm not sure about, though. Could use some feedback from @Ryochan7.
Any particular reason why it needs to be on the same drive? I've never had D4W on my C drive, except from test builds.

Added New Icons https://github.com/Yohoki/DS4WindowsEx/commit/7c7010297fe8d6ac5d692c99b586d15c47b11fb0
Shared Mode:

Exclusive or HidHide/HidGuardian

Exclusive+HidHide

They're quickly thrown together in GIMP. I need to go back in and clean them up and make them a bit better/vectorize. But they're new, and they display. D4W now also detects if HH is running AND has exclusive access to the controller. If it does, the Locked+ icon is shown. Exclusive affected will share an icon with HH affected, since having only 1 active is mostly no different than having the other. But having both active at the same time is now shown as well.
I will also need to go back and make D4W check each controller for listing in HH device list before granting a Lock icon. Right now, d4w just checks is HH is turned on, afaik.

As of https://github.com/Yohoki/DS4WindowsEx/commit/f6efa36a72b0413c841cc969828ae93c19d460b1, This should be ready for some good testing and feedback. Everything that I've wanted to add is added. If I need to make changes or tweaks, now the time to figure those things out.


Fix: support inserting blankline with github-pr-review suggestion

[ ] Updated Unreleased section in CHANGELOG or it's not notable changes.

Error
time=2024-07-08T14:32:44.154Z level=INFO msg="reviewdog: failed to post a review comment: POST https://api.github.com/repos/reviewdog/reviewdog/pulls/1831/reviews: 422 Unprocessable Entity [{Resource: Field: Code: Message:Pull request review thread line must be part of the diff and Pull request review thread diff hunk can't be blank}]"


Mulitple Nested forms in same view?

Hi, trying to embed two nested forms in the same view (tags and pictures).
Is that a possible thing to with this component as it is today?

I understand this feature will be merged from the live pull-request:
https://github.com/stimulus-components/stimulus-rails-nested-form/pull/5

@ferrisoxide I don't have time to test at the moment, but without the PR I was unable to do something like this (which is what I believe this issue was getting at):
<%= form_with model: @post do |f| %>

    <template data-nested-form-target="template">
      <%= f.fields_for :picture, Picture.new, child_index: 'NEW_RECORD' do |picture_form| %>
        <%= render 'picture_form', f: picture_form %>
      <% end %>
    </template>

    <%= f.fields_for :shipment_broker_accessorials do |picture_form| %>
      <%= render 'picture_form', f: picture_form %>
    <% end %>

    <%= link_to 'Add', '#', data: { action: 'nested-form#add' } %>

    <template data-nested-form-target="template">
      <%= f.fields_for :tag, Tag.new, child_index: 'NEW_RECORD' do |tag_form| %>
        <%= render 'tag_form', f: tag_form %>
      <% end %>
    </template>

    <%= f.fields_for :shipment_broker_accessorials do |tag_form| %>
      <%= render 'tag_form', f: tag_form %>
    <% end %>

    <%= link_to 'Add', '#', data: { action: 'nested-form#add' } %>

<% end %>

Ah, I didn't distinguish between the selector-value data attributes. Both of my nested forms have a div wrapper that looks like this:

Not sure why, but it's working fine with two sets of nested form in the same form. 🤷

tag_form

Hi bro, may I see your 'tag_form' or 'picture_form' files?  I have a problem with the button remove in nested form

Sure, it looks like:
<div class="tag-form-wrapper row gy-2 gx-3 align-items-center mb-4" data-new-record="<%= f.object.new_record? %>">

      <%= f.text_field :name, wrapper: false %>

    <%= f.hidden_field :_destroy, wrapper: false %>
    <%= link_to icon('solid', 'trash', 'Remove'), '#', data: { action: 'nested-form#remove' }, class: 'btn btn-light ml-2' %>


Use https://www.polymer-project.org as homepage

@kevinpschaaf, @valdrinkoshi, @azakus, please merge this pull request.

@notwaldorf, please merge this pull request.

@notwaldorf, @kevinpschaaf @azakus, @sorvell, @justinfagnani, please merge this pull request.

To maintain a clean history, please combine your pull requests together in one pull request that we can then merge. We can not accept the changes to the license, so please leave these changes out of the combined pull request.


General cleanup

Title of change
General cleanup
Checklist

[x] Unit tests written
[x] Manually tested
[x] Prettier & ESLint were run
[x] New dependencies are included in package-lock.json

Screenshot
insert screenshot if needed

Deployed to: http://staging.quran.com:32821


Add 'getUserBy*' methods and generalize REST API services

:rocket: PR was released in v1.3.0 :rocket:


Remove MDNS

(this PR applies on top of https://github.com/Zilliqa/zq2/pull/1829 )
GCP only partly supports mdns and local networks don't support it at all; having it present encourages libp2p to think it can locate peers using mdns and do work that it doesn't need to do. It also leads to an odd situation with local networks (where nodes have no globally visible address) where all packets have to be passed using illegitimate mdns broadcasts because we refuse to accept any of the addresses identify identifies (they are all classed as non-global and our code discards them).
This patch removes mdns, simplifying our libp2p config. zq2-richard is at block 106,000 and some with it, so I hope it's not too deleterious ..

Duplicate of JH's recent PR


Merge: 8 cli core

Add:
  - Github action on main's push
  - Cli core

Fix:
  - Slightly edit the readme file

Gonna need way more context here. 😅 What is all this exactly?


How about simple componentization such as core log start queue timing tasks...Composer? https://www.yiiframework.com/status/3.0

How about simple componentization such as core log start queue timing tasks...Composer?https://www.yiiframework.com/status/3.0
I wanted to return Swoole with Workerman and found it too coupling

Or just do the injection startup and so on and leave it to another framework?

@zhanchmini
few basic points just want to re-iterate

My intention is to make WinterBoot Framework as a stateful  framework.  It maintains it's state between requests.
This is mainly designed for backend processing, rather frontend.
NO Process created per Request  (unlike normal PHP frameworks)

Most of the YII components work just by including them by Composer in your project.  i.e. Components which are stateless such as Arrays, ActiveRecord etc ...

Some Components has to be started on Application startup, such as Logging, Schedulers etc...

Schedulers can be started with a Annotation #[Scheduled].  see https://github.com/suvera/winter-boot/blob/master/docs/async_scheduling.md
WinterBoot already use  Monolog,  incase if you want to do something else, then use #[OnApplicationReady]

      #[Component]
      #[OnApplicationReady]
      class SomthingOnReady implements ApplicationReadyEvent {
      }

YII Components such as Queue listeners, processors  can be started by #[DaemonThread]. See Help here https://github.com/suvera/winter-boot/blob/master/docs/daemon_threads.md
Other Complex Things has to be created as a Module  , see Module Extensions section here https://github.com/suvera/winter-boot/blob/master/README.md


Allow filtering addresses while the page table is being parsed instead of after

My understanding of the code is that we first parse the entire page table, and then apply the filters. This makes sense when the purpose of the filters is just to limit the amount of information seen, but I need to filter out page ranges for performance issues.
I'm running a KASAN AArch64 image, which results in the following additional page table entries:
---[ Kasan shadow start ]---
0xffffffc000000000-0xffffffc004000000          64M PTE       RW NX SHD AF            UXN    MEM/NORMAL
0xffffffc004000000-0xffffffc040000000         960M PMD
0xffffffc040000000-0xffffffc400000000          15G PGD
0xffffffc400000000-0xffffffc480800000        2056M PTE       ro NX SHD AF            UXN    MEM/NORMAL
0xffffffc480800000-0xffffffc481000000           8M PMD
0xffffffc481000000-0xffffffc481399000        3684K PTE       RW NX SHD AF            UXN    MEM/NORMAL
0xffffffc481399000-0xffffffc481400000         412K PTE
0xffffffc481400000-0xffffffc482000000          12M PMD
0xffffffc482000000-0xffffffc483001000       16388K PTE       RW NX SHD AF            UXN    MEM/NORMAL
0xffffffc483001000-0xffffffc483200000        2044K PTE
0xffffffc483200000-0xffffffc4c0000000         974M PMD
0xffffffc4c0000000-0xffffffc7c0000000          12G PGD
0xffffffc7c0000000-0xffffffc7ebe00000         702M PMD
0xffffffc7ebe00000-0xffffffc7ebfee000        1976K PTE
0xffffffc7ebfee000-0xffffffc7ebfff000          68K PTE       RW NX SHD AF            UXN    MEM/NORMAL
0xffffffc7ebfff000-0xffffffc800000000      327684K PTE       ro NX SHD AF            UXN    MEM/NORMAL
---[ Kasan shadow end ]---

I don't really care about these, but gdb-pt-dump still tries to parse them, which ends up taking forever. I'm wondering if instead of filtering addresses after we've parsed the page table, we can skip addresses while the page table is being parsed, so I could specify a range that would completely skip this KASAN memory.

This is a good optimization idea. Would you like to write a patch so that the range gets considered during parsing?
Note that I'm slowly working on an improvement of the project to write the core code in Rust: https://github.com/martinradev/pt-dump
With it, parsing large page tables is significantly faster.

Would you like to write a patch so that the range gets considered during parsing?

Unfortunately I don't have time at the moment, and not sure when I'd be able to look into it.

Note that I'm slowly working on an improvement of the project to write the core code in Rust: martinradev/pt-dump. With it, parsing large page tables is significantly faster.

Awesome! If you could either test that the KASAN use case is reasonably fast when measuring performance or eventually implement this feature request in that version, that would be great.


How skip rows and cells to create the dataset?

Hi guys.
We are using ExcelDataReader and ExcelDataReader.DataSet extension available on NuGet, to have the IExcelDataReader instance as DataSet. It works perfectly for the most of our scenarios and it show us such as a great tool.
There are some scenarios where we need to define the row and column (for sample: B3 or D4 or E10),  where should start reading data and build the dataSet. For sample, I have worksheets where the data that interest me to extract start on F2 column (where F2 is the header line and above it the data).
Is there any way to specify what cell the DataSet should start reading using the configuration objects? Or how rows it should skip (for sample, 6 lines and start reading)?
Thank you.

Hi!
Alas there is no way to exclude columns with AsDataSet currently.
But there are two options for skippings rows. The simplest is probably to use the FilterRow callback:
var dataset = reader.AsDataSet(new ExcelDataSetConfiguration() {
	ConfigureDataTable = _ => new ExcelDataTableConfiguration() {
		FilterRow = rowReader => rowReader.Depth > 6
	}
});

The above reads only rows when the Depth (row index) is greater than 6.
Can also skip rows before the header, with UseHeaderRow = true, and the ReadHeaderRow callback:
var dataset = reader.AsDataSet(new ExcelDataSetConfiguration() {
	ConfigureDataTable = _ => new ExcelDataTableConfiguration() {
                UseHeaderRow = true,
		ReadHeaderRow = rowReader => {
		            rowReader.Read();
		            rowReader.Read();
		            rowReader.Read();
		            rowReader.Read();
		            rowReader.Read();
		            rowReader.Read();
                }
	}
});

The above skips the 6 first rows, uses the next row as headers, then reads the rest as normal.
Which approach to use probably depends on the use case

Thank you @andersnm,
I have tried some code here with your samples and works fine since the data is on the first column. In my case, where column start on the cell F2, I can skip some lines with configuration object and skip column when reading the DataTable. For sample:
foreach(DataRow row in table.Rows)
 {
   for (int c = 0; c < table.Columns.Count; c++)
   {
        // skip column where there is no name and data and start reading columns from second one.
        if (c < 1) continue;

        var column = table.Columns[c];

        // use information here
        var data = row[column];

    }
}

I am not sure if it is a good solution but it works as expected. Is there any const on doing it?
As suggestion, would be great if the ExcelDataSetConfiguration or ExcelDataTableConfiguration have a property to accept a column defined where should it start reading, for sample:
var dataset = reader.AsDataSet(new ExcelDataSetConfiguration() {
	ConfigureDataTable = _ => new ExcelDataTableConfiguration() {
                UseHeaderRow = true,
                StartDataPosition = "F3"
	}
});

Or
var dataset = reader.AsDataSet(new ExcelDataSetConfiguration() {
	ConfigureDataTable = _ => new ExcelDataTableConfiguration() {
                UseHeaderRow = true,
                StartRowPosition = 3,
                StartColumnPosition = 5
	}
});

Thank you :D

I think your first sample looks OK - it does what it needs to do. Alternatively, initialize the for-loop with the first column index to avoid the if-continue statement, f.ex for (int c = 1; c < table.Columns.Count; c++)...
The AsDataSet() options could use a new ExcelDataTableConfiguration.FilterColumn callback to configure which columns to read into the dataset. This would complement the FilterRow callback.

Thank you @andersnm for the suggestions. I will try them on my project.

it would be super useful, if you could say start x and end y, could this be added, basically the start is done, with the FilterRow
not tested but i think this would do it right?
var start = 6;
var end = 50 000

var dataset = reader.AsDataSet(new ExcelDataSetConfiguration() {
	ConfigureDataTable = _ => new ExcelDataTableConfiguration() {
		FilterRow = rowReader => rowReader.Depth > start  && rowReader.Depth < end ,
                FilterRowExit = rowReader => rowReader.Depth == end
	}
});

but wouldn't it be cooler if there was like FilterRowExit condition of sorts
if (configuration.FilterColumn != null && !configuration.FilterColumn(self, i))
{
      //attempting to improve performance but not sure if this just makes it worse,
      //due to the condition checks, maybe only do this on continuous `continue;`'s
      if(FilterRowExit != null &&  !configuration.FilterRowExit (self, i))
      {
             break;
      }
      continue;
}

mmm not convinced this is better, but perhaps someone smarter than i can work out how to include a break; so that it exists faster.
maybe check after every 100-1000 continuous continues, it should check if it should simply exit. maybe this is too much of a mirco improvement? but what is the cost of doing 200 000 + filter columns checks just to continue on all.

Another solution, it is quite tricky
`DataTable resultDataTable = new DataTable();
FileInfo targetFile = new FileInfo(@"C:\Temp\targetExcelFile.xlsx");
using (FileStream stream = File.Open(targetFile.FullName, FileMode.Open, FileAccess.Read))
{
// We return the interface, so that
IExcelDataReader reader = stream.Name.EndsWith(".xls") ? ExcelReaderFactory.CreateBinaryReader(stream)
// xlsx
: ExcelReaderFactory.CreateOpenXmlReader(stream);
            DataTable rawWorkSheet = reader.AsDataSet().Tables[sheetindex];
            resultDataTable.TableName= rawWorkSheet.TableName;
            // Remove unwanted coumns if any
            Enumerable.Range(0, Math.Max(startColumnIndex - 1, 0)).ToList().ForEach(indexToRemove => rawWorkSheet.Columns.RemoveAt(indexToRemove));
            // Add all required columns
            resultDataTable.Columns.AddRange(rawWorkSheet.Rows.Cast<DataRow>().Skip(startRowIndex - 1).First() // Header Row
                                            .ItemArray.Select(obj => new DataColumn(obj.ToString())).ToArray());
            // Add all rows
            rawWorkSheet.Rows.Cast<DataRow>().Skip(startRowIndex).ToList().ForEach(row =>
                {
                    resultDataTable.Rows.Add(row.ItemArray);
                });

        }`

``
``

How to read from "F2" using first row as column headers : I could not get it working using ExcelDataSetConfiguration.
``
using ExcelDataReader;
using System;
using System.Data;
using System.IO;
using System.Linq;
public static DataTable ReadExcelAsDataTable(
FileInfo targetFile,
int sheetindex = 0,
int startColumnIndex = 0,
int startRowIndex = 0)
{
// See ExcelDataReader Github Readme :  Important note on .NET Core
System.Text.Encoding.RegisterProvider(System.Text.CodePagesEncodingProvider.Instance);
        // Declare result table
        DataTable resultDataTable = new DataTable();

        using (FileStream stream = File.Open(targetFile.FullName, FileMode.Open, FileAccess.Read))
        {
            // We return the interface, so that
            using (IExcelDataReader reader = stream.Name.EndsWith(".xls") ?
                            ExcelReaderFactory.CreateBinaryReader(stream)   // XLS  file
                          : ExcelReaderFactory.CreateOpenXmlReader(stream)) // XLSX file
            {
                using (DataTable rawWorkSheet = reader.AsDataSet().Tables[sheetindex])
                {
                    // Cherry on the cake
                    resultDataTable.TableName = rawWorkSheet.TableName;
                    // Remove unwanted coumns if any
                    Enumerable.Range(0, Math.Max(startColumnIndex - 1, 0)).ToList().ForEach(indexToRemove => rawWorkSheet.Columns.RemoveAt(indexToRemove));
                    // Add all required columns
                    resultDataTable.Columns.AddRange(rawWorkSheet.Rows.Cast<DataRow>().Skip(startRowIndex - 1).First() // Header Row
                                                    .ItemArray.Select(obj => new DataColumn(obj.ToString())).ToArray());
                    // Add all rows
                    rawWorkSheet.Rows.Cast<DataRow>().Skip(startRowIndex).ToList().ForEach(row =>
                    {
                        resultDataTable.Rows.Add(row.ItemArray);
                    });
                };
            }
        }

        return resultDataTable;
    }

}

``


Change Hours to AM/PM

Great library! Is there a way to change the hours on the left side to say AM or PM?

There is no way to change that currently, but I can implement it


jgitver configuration closure not used with 0.10.0-rc01

with the simple following build.gradle
plugins {
    id "fr.brouillard.oss.gradle.jgitver" version "0.10.-rc01"
}

jgitver {
    useDirty true
}

the execution gradle version on a dirty repository (with single commit) ends in
> Task :version
Version: 0.0.0-0

whereas with version 0.9.1 it correctly computes to
> Task :version
Version: 0.0.0-0-dirty

running jgitver during configuration phase of gradle might have broken the retrieval of extension values.

Also running into this issue. No closure configuration seems to be taken into account with 0.10.0-rc1. 0.9.1 works as expected.

as already mentionned in #25 I'd need help from gradle users for this to know which way to go is the good one:

stay like 0.9.1 and use lazy evaluation
go with 010.0-rc1 refacto and correct config usage
another way

You might take advantage of the fact that the setVersion method in Gradle Project class takes an Object as parameter, not a String. When Gradle needs to output the value of the version, it calls toString() on the object. So the laziness is somewhere implicit, if you set the version to a custom object.
So, for instance:
class JGitverExtension {
    private final GitVersionCalculator gitVersionCalculator

    JGitverExtension(File rootDir){
        gitVersionCalculator = GitVersionCalculator.location(rootDir)
    }

    void useDirty(boolean useDirty){
        gitVersionCalculator.setUseDirty(useDirty)
    }

    String toString() {
        return gitVersionCalculator.getVersionObject(false).toString()
    }
}

class JGitverPlugin implements Plugin<Project> {
    void apply(Project project) {
        project.setVersion(project.extensions.create('jgitver',
                JGitverExtension, project.rootDir))
    }
}

Now, if you have another plugin
class AnotherExtension {
    private String _name

    def name(String name) {
        this._name = name
    }

    String name(){
        _name
    }
}

class AnotherPlugin implements Plugin<Project> {
    @Override
    void apply(Project project) {
        project.extensions.create('another', AnotherExtension)
    }
}

you may use the calculated version, as far as the jgitver configuration extension precedes the another configuration extension
apply plugin: JGitverPlugin
apply plugin: AnotherPlugin

jgitver {
    useDirty true
}

another {
    name "project version is: ${version}"
}

task useJGitver {
    println another.name()
}

Thanks I definitively need to look at that.

just released 0.10.0-rc02 with lazy evaluation which correct this.
It solves also #25.
@rzabini thanks for your hint

I have tested this change and now the configuration closure is considered correctly. The only change I had to do in my build script was changing project.version in
docker {
  tags project.version, "latest"
  ...
}

to either "{project.version}" or project.version.toString(). The reason is that tags only accepts a list of Strings and not Objects. Now the version is no longer a String but a JGitverLazyVersionHolder Object, but I guess that's fine.
Thanks for fixing this issue! Happy to use the new version once released. I built it myself for now as the snapshot does not seem to be available on https://plugins.gradle.org/m2/fr/brouillard/oss/gradle/gradle-jgitver-plugin/ (yet?).

0.10.0-rc03 & 0.10.0-rc02 were pushed to gradle portal : https://plugins.gradle.org/plugin/fr.brouillard.oss.gradle.jgitver

I'm seeing 0.10.0-rc03 on https://plugins.gradle.org/plugin/fr.brouillard.oss.gradle.jgitver but don't find the artifact on https://plugins.gradle.org/m2/fr/brouillard/oss/gradle/gradle-jgitver-plugin/
0.10.0-rc02 is also missing there. Maybe something went wrong with publishing the new version?

afraid that with the changes to kotlin we faced something related to #12

Thanks for the hint. After changing
classpath "fr.brouillard.oss.gradle:gradle-jgitver-plugin:0.10.0-rc03"
to
classpath "gradle.plugin.fr.brouillard.oss.gradle:gradle-jgitver-plugin:0.10.0-rc03"
it works fine and the result is as mentioned in my comment above. So the issue is fixed.