Zero Bounding Box

Moving this discussion to its own thread: https://github.com/potree/PotreeConverter/issues/421#issuecomment-671675523
@elixirml please send me the las or laz file that causes this issue so that I can take a look at it<EMAIL_ADDRESS>

hello @m-schuetz in this link you can find the .las file with which we are trying to convert to a point cloud

https://drive.google.com/file/d/1UQfnx-M1Z4nDIiM15GcPDxgMN1ZWIE9v/view?usp=sharing

we have tried to convert using
Converter.exe C:\Users\Big\las\2.las -o C:\Users\Big\conv\2
also
Converter.exe C:\Users\Big\las\2.las -rescale 0.0001 0.0001 0.0001 -o C:\Users\Big\conv\2
but we couldn't finish the process
we are using the following hardware:
Intel Core i3 2.13Ghz, 2 cores, 4 threads
6 Gb Ram
Windows 10 Pro
Potreeconverter 2.0
the output is as follows >>
flags:
#paths: 1
output attributes:
name                              offset    size
position                               0      12
intensity                             12       2
return number                         14       1
number of returns                     15       1
classification flags                  16       1
classification                        17       1
user data                             18       1
scan angle                            19       2
point source id                       21       2
gps-time                              23       8
rgb                                   31       6
                                          37

================================================
cubicAABB: {
"min": [0.000000, 0.000000, 0.000000],
"max": [0.000000, 0.000000, 0.000000],
"size": [0.000000, 0.000000, 0.000000]
}
#points: 9'104'949
total file size: 312.6 MB
maxPointsPerChunk: 455247
=======================================
=== COUNTING
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
tStartTaskAssembly: 0.000998s
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
[26%, 1s], [COUNTING: 77%, duration: 1s, throughput: 7MPs][RAM: 0WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
.1GB (highest 0.1GB), CPU: 69%]
countPointsInCells: 1.224424s
finished counting in 1s
createLUT: 0.088526s
=======================================
=== CREATING CHUNKS
distributePoints0: 0.000212s
distributePoints1: 0.002898s
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
[33%, 2s], [DISTRIBUTING: 0%, duration: 0s, throughput: -na'n(i'nd)MPs][RAM: 0.3GB (highest 0.3GB), CPU: 71%]
C:\Users\Big\PotreeConverter_2.0_windows_x64>
any comment will be of great help
Thank you very much for your time
best regards

Hi, I don't have a functional understanding of this but I've encountered the issue. This seems to be a LAS 1.3 or 1.4 format file. When  opening  with the LAS 1.3/1.4 importer in cloudcompare (rather than the standard LAS importer)  I can save it as a standard LAZ file and it works fine in PotreeConverter 2 (file attached).
PDAL's "translate" command gives a similar error for this cloud:
(pdal translate readers.las Error) Global encoding WKT flag not set for point format 6 - 10.
PDAL: readers.las: Unsupported LAS input point format: 7.
https://drive.google.com/file/d/1z0sMDmM15pZrlLfr_U1HYCXkaVor2586/view?usp=sharing

@elixirml Just a point of clarification. When Markus suggested the rescale workaround, it was directed towards a different user experiencing a different problem. Also, it required a separate piece of software from LAS tools called las2las. Notice the different executable in the command line: las2las -i crash.las -rescale 0.0001 0.0001 0.0001 -o no_crash.las - this is not using the converter.
Someone correct me if I'm wrong, but the converter only has a few tags that it accepts as arguments, namely the following:
-i YOUR_INPUT_FILE -o YOUR_OUTPUT_LOCATION -m CONVERTER_METHOD
There is no -rescale flag, so using this wouldn't have a positive result. I'd advise against submitting flags that aren't supported. But absolutely give it a go with the las2las tool if you think scale is part of the problem.
By the way, you can make output easier to read on GitHub if you wrap it with three backticks (```) at the beginning and end. This will prevent GitHub from modifying the format or making text larger when a hash is at the beginning of a line.
I wish I could be of some help here, but I have yet to see this occur and I'm not sure what it's catching on. If I don't lose power due to the hurricanes, I'll spin up a debugger Monday or Tuesday.

Hi, I think your las file is "broken". Report by lasinfo:
  scale factor x y z:         0.0000000041866 0.000000003956875 0.000000004512207
  offset x y z:               6.657199859619141 -0.156700000166893 2941.326416015625
  min x y z:                  0 0 0
  max x y z:                  0 0 0
WARNING: stored resolution of min_x not compatible with x_offset and x_scale_factor: 0
WARNING: stored resolution of min_y not compatible with y_offset and y_scale_factor: 0
WARNING: stored resolution of min_z not compatible with z_offset and z_scale_factor: 0
WARNING: stored resolution of max_x not compatible with x_offset and x_scale_factor: 0
WARNING: stored resolution of max_y not compatible with y_offset and y_scale_factor: 0
WARNING: stored resolution of max_z not compatible with z_offset and z_scale_factor: 0
...
WARNING: real max x larger than header max x by 10.843800
WARNING: real max y larger than header max y by 3.800175
WARNING: real min y smaller than header min y by 0.156700
WARNING: real max z larger than header max z by 2945.838623

The las metadata claims that the bounding box is zero. However, PotreeConverter heavily relies on correct bounding box data for the octree generation. It seems like lasinfo with the -repair argument could be used to compute the correct bounding box.

And you might also have to rescale in addition to repairing the bounding box, until the new PotreeConverter release with automatic rescaling is published
las2las -i crash.las -rescale 0.0001 0.0001 0.0001 -o no_crash.las

More issues:

The las file says it uses format 1.2, but it specifies point data record format 7. Las format 1.2 does not have point record format 7. * Format 7 has a minimum size of 36 bytes but in your las file, points have a size of only 30 bytes.

You'll need to make your las file standard compliant.

hello friends, Thank you very much for your clarifications, advice and dedication to this topic.
We will try to work with las2las too;)
We can instruct the design area to correctly export the .las file to try again, but I would appreciate it if you could please indicate some technical considerations when exporting the new .las file and thus generate one that is compatible with the standard.
Soon I will write to you with the new results.
Thank you very much for your time
Best regards

What exactly is your process to generate LAS point clouds? It would be helpful to see relevant settings and commands (if using command line tools). Do all of the point clouds you generate suffer from this broken state? Also, did you generate your LAS file using the core i3 system with limited RAM?

We can instruct the design area to correctly export the .las file to try again, but I would appreciate it if you could please indicate some technical considerations when exporting the new .las file and thus generate one that is compatible with the standard.

If you're using your own las exporter, try running lasinfo on it, it usually catches many of the main issues of non-conforming las files. And then there is the spec itself, which is relatively intelligible: https://www.asprs.org/wp-content/uploads/2010/12/LAS_1_4_r13.pdf

@m-schuetz Regarding the edit:

The issue with the duplicates isn't against the standard but such a large amount of duplicates indicate some issue with the data set or exporter, so they should be dealt with anyway.

Does this case also involve a large amount of duplicates? I thought that was mainly clouds in #427 like with millions of points near the absolute center. The hallmarks of this one are the mismatched point sizes for the point type declared & the strange zero sized bounding box. Just for documentation sake, did you also find a ton of points on top of each other?

@midnight-dev
Ah you're right, I was confusing this with #427. No duplicates in this issue.

hello Friends
We have carefully followed all the advice listed above. As a result, I comment that we carry out new tests with 2 files:

3.las (1.1 GB.)
4.las (20 Mb)

the steps to follow with both files were the following:
1.- lasinfo -i file_orig.las
2.- las2las -i file_orig.las -rescale 0.0001 0.0001 0.0001 -o file_no_crash.las
3.- lasinfo -i file_no_crash.las
4.- lasinfo -i file_no_crash.las -repair
5.- lasinfo -i file_no_crash.las
6.- Converter.exe file_no_crash.las -o C:\Users\Big\conv
7.- Exit
The conversion of the 4.las file was successful, but when looking in the viewfinder, its color was a bit diffuse black (capture attached). On the other hand the conversion of the 3.las file did not finish.
Below is the detail of the conversion outputs of file 3 and 4 respectively:
console output 3.las
C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\las\3.las
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
lasinfo (200813) report for 'C:\Users\Big\las\3.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          ''
  generating software:        ''
  file creation day/year:     0/0
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          7
  point data record length:   30
  number of point records:    29625116
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.0000000228479 0.0000000217133 0.00000001303186
  offset x y z:               -13.521200180053711 -13.324399948120117 1035.885986328125
  min x y z:                  0 0 0
  max x y z:                  0 0 0
WARNING: stored resolution of min_x not compatible with x_offset and x_scale_factor: 0
WARNING: stored resolution of min_y not compatible with y_offset and y_scale_factor: 0
WARNING: stored resolution of min_z not compatible with z_offset and z_scale_factor: 0
WARNING: stored resolution of max_x not compatible with x_offset and x_scale_factor: 0
WARNING: stored resolution of max_y not compatible with y_offset and y_scale_factor: 0
WARNING: stored resolution of max_z not compatible with z_offset and z_scale_factor: 0
reporting minimum and maximum for all LAS point record entries ...
  X                   0  999999999
  Y                   0<PHONE_NUMBER>
  Z                   0  999999999
  intensity           0          0
  return_number       1          1
  number_of_returns   1          1
  edge_of_flight_line 0          0
  scan_direction_flag 0          0
  classification      0          0
  scan_angle_rank     0          0
  user_data           0          0
  point_source_ID     0          0
  gps_time 0.000000 0.000000
  Color R 0 65280
        G 0 65280
        B 0 65280
  extended_return_number          1      1
  extended_number_of_returns      1      1
  extended_classification         0      0
  extended_scan_angle             0      0
  extended_scanner_channel        0      0
WARNING: 29625116 points outside of header bounding box
number of first returns:        29625116
number of intermediate returns: 0
number of last returns:         29625116
number of single returns:       29625116
WARNING: point type is 7 but (legacy) number of point records in header is 29625116 instead zero.
overview over number of returns of given pulse: 29625116 0 0 0 0 0 0
histogram of classification of points:
        29625116  never classified (0)
WARNING: real max x larger than header max x by 9.326700
WARNING: real min x smaller than header min x by 13.521200
WARNING: real max y larger than header max y by 8.388900
WARNING: real min y smaller than header min y by 13.324400
WARNING: real max z larger than header max z by 1048.917847

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>las2las -i C:\Users\Big\las\3.las -rescale 0.0001 0.0001 0.0001 -o C:\Users\Big\conv\3\3_no_crash.las
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\conv\3\3_no_crash.las
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
lasinfo (200813) report for 'C:\Users\Big\conv\3\3_no_crash.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          'LAStools (c) by rapidlasso GmbH'
  generating software:        'las2las (version 200813)'
  file creation day/year:     0/0
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          7
  point data record length:   30
  number of point records:    0
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.0001 0.0001 0.0001
  offset x y z:               -13.521200180053711 -13.324399948120117 1035.885986328125
  min x y z:                  -13.5212 -13.3244 1035.8860
  max x y z:                  -13.5212 -13.3244 1035.8860

tStartTaskAssembly: 0.000899s
countPointsInCells: 0.029626s
finished counting in 0s
=======================================
createLUT: 0.078962s

=======================================
=== CREATING CHUNKS
=======================================
distributePoints0: 0.000214s
distributePoints1: 0.002157s
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
finished creating chunks in 0s
=======================================

=======================================
=== INDEXING
=======================================

tStartTaskAssembly: 0.001146s
countPointsInCells: 0.016172s
finished counting in 0s
=======================================
createLUT: 0.085859s

=======================================
=== CREATING CHUNKS
=======================================
distributePoints0: 0.000220s
distributePoints1: 0.002199s
WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36
finished creating chunks in 0s
=======================================

=======================================
=== INDEXING
=======================================

At this point the process ended abruptly
Console output 4.las
C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\las\4.las
lasinfo (200813) report for 'C:\Users\Big\las\4.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          'libLAS'
  generating software:        'libLAS 1.8.0'
  file creation day/year:     269/2019
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          3
  point data record length:   34
  number of point records:    532890
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.000000002215626 0.000000001714564 0.000000000782776
  offset x y z:               4.840159416198731 -2.95121431350708<PHONE_NUMBER>359375
  min x y z:                  4.840159416198731 -2.95121431350708<PHONE_NUMBER>359375
  max x y z:                  7.055785655975342 -1.236650705337524<PHONE_NUMBER>1484375
reporting minimum and maximum for all LAS point record entries ...
  X                   0<PHONE_NUMBER>
  Y                   0<PHONE_NUMBER>
  Z                   0<PHONE_NUMBER>
  intensity           0        255
  return_number       0          0
  number_of_returns   0          0
  edge_of_flight_line 0          0
  scan_direction_flag 0          0
  classification      0          0
  scan_angle_rank     0          0
  user_data           0          0
  point_source_ID     0          0
  gps_time 0.000000 0.000000
  Color R 0 0
        G 0 0
        B 0 0
number of first returns:        532890
number of intermediate returns: 0
number of last returns:         532890
number of single returns:       532890
WARNING: there are 532890 points with return number 0
WARNING: there are 532890 points with a number of returns of given pulse of 0
histogram of classification of points:
          532890  never classified (0)

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>las2las -i C:\Users\Big\las\4.las -rescale 0.0001 0.0001 0.0001 -o C:\Users\Big\conv\4\4_no_crash.las
C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\conv\4\4_no_crash.las
lasinfo (200813) report for 'C:\Users\Big\conv\4\4_no_crash.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          'LAStools (c) by rapidlasso GmbH'
  generating software:        'las2las (version 200813)'
  file creation day/year:     269/2019
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          3
  point data record length:   34
  number of point records:    532890
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.0001 0.0001 0.0001
  offset x y z:               4.840159416198731 -2.95121431350708<PHONE_NUMBER>359375
  min x y z:                  4.8402 -2.9512 477.9867
  max x y z:                  7.0558 -1.2366 478.7695
reporting minimum and maximum for all LAS point record entries ...
  X                   0      22156
  Y                   0      17146
  Z                   0       7828
  intensity           0        255
  return_number       0          0
  number_of_returns   0          0
  edge_of_flight_line 0          0
  scan_direction_flag 0          0
  classification      0          0
  scan_angle_rank     0          0
  user_data           0          0
  point_source_ID     0          0
  gps_time 0.000000 0.000000
  Color R 0 0
        G 0 0
        B 0 0
number of first returns:        532890
number of intermediate returns: 0
number of last returns:         532890
number of single returns:       532890
WARNING: there are 532890 points with return number 0
WARNING: there are 532890 points with a number of returns of given pulse of 0
histogram of classification of points:
          532890  never classified (0)

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\conv\4\4_no_crash.las -repair
lasinfo (200813) report for 'C:\Users\Big\conv\4\4_no_crash.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          'LAStools (c) by rapidlasso GmbH'
  generating software:        'las2las (version 200813)'
  file creation day/year:     269/2019
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          3
  point data record length:   34
  number of point records:    532890
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.0001 0.0001 0.0001
  offset x y z:               4.840159416198731 -2.95121431350708<PHONE_NUMBER>359375
  min x y z:                  4.8402 -2.9512 477.9867
  max x y z:                  7.0558 -1.2366 478.7695
reporting minimum and maximum for all LAS point record entries ...
  X                   0      22156
  Y                   0      17146
  Z                   0       7828
  intensity           0        255
  return_number       0          0
  number_of_returns   0          0
  edge_of_flight_line 0          0
  scan_direction_flag 0          0
  classification      0          0
  scan_angle_rank     0          0
  user_data           0          0
  point_source_ID     0          0
  gps_time 0.000000 0.000000
  Color R 0 0
        G 0 0
        B 0 0
number of first returns:        532890
number of intermediate returns: 0
number of last returns:         532890
number of single returns:       532890
number of point records in header is correct.
number of points by return in header is correct.
WARNING: there are 532890 points with return number 0
WARNING: there are 532890 points with a number of returns of given pulse of 0
histogram of classification of points:
          532890  never classified (0)
bounding box is correct.

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>lasinfo -i C:\Users\Big\conv\4\4_no_crash.las
lasinfo (200813) report for 'C:\Users\Big\conv\4\4_no_crash.las'
reporting all LAS header entries:
  file signature:             'LASF'
  file source ID:             0
  global_encoding:            0
  project ID GUID data 1-4:   00000000-0000-0000-0000-000000000000
  version major.minor:        1.2
  system identifier:          'LAStools (c) by rapidlasso GmbH'
  generating software:        'las2las (version 200813)'
  file creation day/year:     269/2019
  header size:                227
  offset to point data:       227
  number var. length records: 0
  point data format:          3
  point data record length:   34
  number of point records:    532890
  number of points by return: 0 0 0 0 0
  scale factor x y z:         0.0001 0.0001 0.0001
  offset x y z:               4.840159416198731 -2.95121431350708<PHONE_NUMBER>359375
  min x y z:                  4.8402 -2.9512 477.9867
  max x y z:                  7.0558 -1.2366 478.7695
reporting minimum and maximum for all LAS point record entries ...
  X                   0      22156
  Y                   0      17146
  Z                   0       7828
  intensity           0        255
  return_number       0          0
  number_of_returns   0          0
  edge_of_flight_line 0          0
  scan_direction_flag 0          0
  classification      0          0
  scan_angle_rank     0          0
  user_data           0          0
  point_source_ID     0          0
  gps_time 0.000000 0.000000
  Color R 0 0
        G 0 0
        B 0 0
number of first returns:        532890
number of intermediate returns: 0
number of last returns:         532890
number of single returns:       532890
WARNING: there are 532890 points with return number 0
WARNING: there are 532890 points with a number of returns of given pulse of 0
histogram of classification of points:
          532890  never classified (0)

C:\Users\Big Science\Downloads\LAStools\LAStools\bin>cd C:\Users\Big\PotreeConverter_2.0_windows_x64
C:\Users\Big\PotreeConverter_2.0_windows_x64>Converter.exe C:\Users\Big\conv\4\4_no_crash.las -o C:\Users\Big\conv
flags:
#paths: 1

output attributes:
name                              offset    size
================================================
position                               0      12
intensity                             12       2
return number                         14       1
number of returns                     15       1
classification                        16       1
scan angle rank                       17       1
user data                             18       1
point source id                       19       2
gps-time                              21       8
rgb                                   29       6
================================================
                                              35
================================================
cubicAABB: {
        "min": [4.840159, -2.951214, 477.986694],
        "max": [7.055759, -0.735614, 480.202294],
        "size": [2.215600, 2.215600, 2.215600]
}
#points: 532'890
total file size: 17.3 MB
maxPointsPerChunk: 26644

=======================================
=== COUNTING
=======================================
tStartTaskAssembly: 0.000666s
countPointsInCells: 0.211520s
finished counting in 0s
=======================================
createLUT: 0.105876s

=======================================
=== CREATING CHUNKS
=======================================
distributePoints0: 0.000243s
distributePoints1: 0.002715s
finished creating chunks in 1s
=======================================

=======================================
=== INDEXING
=======================================
[67%, 1s], [INDEXING: 0%, duration: 0s, throughput: -na'n(i'nd)MPs][RAM: 0.0GB (highest 0.1GB), CPU: 0%]
[67%, 2s], [INDEXING: 0%, duration: 0s, throughput: -na'n(i'nd)MPs][RAM: 0.1GB (highest 0.1GB), CPU: 46%]
sampling: 1.740692s
flushing: 1.764235s
metadata & hierarchy: 1.786577s

=======================================
=== STATS
=======================================
#points:               532'890
#input files:          1
sampling method:       poisson
chunk method:          LASZIP
input file size:       0.0GB
duration:              3.277s
throughput (MB/s)      5MB
throughput (points/s)  0.2M
output location:       C:\Users\Big\conv
duration(chunking-count):       0.223
duration(chunking-distribute):  0.732
duration(chunking-total):       0.982
duration(indexing):     1.789

I hope this information is useful for you as well.
A hug
Thank you very much for your time and dedication.
Best regards

I wanted to put a point cloud through the converter and step through most of the logic until I found something enlightening, but I need to look over my IDE settings. Something isn't chooching and I'm still missing the symbols for a dependency.
From what I can see, the RGB data is completely stripped or clamped to zeros on las version 4. That explains why it's rendered as black - because an RGB of 0, 0, 0 is the color black. There's a clear difference in other stats too.
What I'd like to do is check the original LAS. If you're willing and able to upload the original, we can analyze it and attempt conversions. Checking 2, 3, 4 or other derivatives may not be of much help because the malfunctioning original file was altered during conversion, and that could result in other artifacts that are snowballing into larger errors.
While I work on fixing my debugging configuration, I'd like some more  information.

Which program actually created the original LAS file?
What hardware was used (drone, land-based LiDAR, with or without GPS/RTK/PPK, etc.)?
Have you successfully scanned, exported, and converted point clouds in the past using the same software and hardware with the same order of operations?
Was the record medium an SSD, an SD card, USB thumb drive?
Is the data drive still in its original state (not wiped, formatted, or otherwise overwritten)? I ask because if it's still in the same condition, you can try exporting the data again using the same software as you did the very first time, and you can also run a chkdsk on the drive to see if there are corrupt sectors, which could create significant problems. SD cards used in humid or dusty environments can often become corrupt to varying levels.

hello @midnight-dev ,Thank you for your time and dedication to this topic.
I'll try to answer some of your questions below:
1.- Which program actually created the original LAS file?
R: the design team uses a software called "solid edge", the point cloud is worked in "cloud compare".
2.- What hardware was used (drone, land-based LiDAR, with or without GPS/RTK/PPK, etc.)?
R: I'm not sure but it seems to me that it is  land-based LiDAR technology
3.- Have you successfully scanned, exported, and converted point clouds in the past using the same software and hardware with the same order of operations?
R: the design team has successfully exported point clouds, with their software. we have not succeeded in converting a point cloud using Potree.
4.- Was the record medium an SSD, an SD card, USB thumb drive?
R:I don't have that information exactly, but I'll ask
5.- Is the data drive still in its original state (not wiped, formatted, or otherwise overwritten)? I ask because if it's still in the same condition, you can try exporting the data again using the same software as you did the very first time, and you can also run a chkdsk on the drive to see if there are corrupt sectors, which could create significant problems. SD cards used in humid or dusty environments can often become corrupt to varying levels.
R:I don't have that information exactly, but I'll ask
I will request new .LAS files from the design team for further testing
As soon as I have information I will write to you again
keep in touch
Greetings and thank you very much

3.las doesn't work because it has an invalid combination of las format 7 and byte length 30:
point data format:          7
point data record length:   30

4.las works because las format 3 and byte length 34 are a valid combination:
point data format:          3
point data record length:   34

The message WARNING: point size 30 too small by 6 bytes for point type 7. assuming point_size of 36 is probably coming from laszip (integrated into the converter) trying to work with non-spec-conforming files anyway, but the PotreeConverter doesn't do that.
Maybe las2las with the set_point_type option can help:
las2las -i 2.laz -set_point_type 3 -o format_3.laz


Pregnancy?

Welp, I made the mistake of playing with my womb count.  That broke everything.  Now I can play the game only when I set it to no wombs.  But when doing that if something knocks my character up, I get this error.
_Flash Player: Desktop - Windows 10
Flash Version: WIN 28,0,0,126
Game Version: 0.7.141

Error Name: TypeError
Error Mesg: Error #1009
TypeError: Error #1009
	at classes::Creature/isPregnant()
	at classes::TiTS/bothriocPidemmeLossSelector()
	at classes::TiTS/bothriocPidemmePCLoss()
	at Function/()
	at classes::TiTS/buttonClick()_

Likewise if I try to add a single womb I get another error,
_Flash Player: Desktop - Windows 10
Flash Version: WIN 28,0,0,126
Game Version: 0.7.141

Error Name: TypeError
Error Mesg: Error #1009
TypeError: Error #1009
	at classes::Creature/hasPregnancyOfType()
	at classes.DataManager::DataManager/executeGame()
	at classes.DataManager::DataManager/loadGameData()
	at classes::TiTS/buttonClick()_

So I don't know what to do to fix the problem, and I've been trying to debug it so long that I'm afraid I no longer have a back-up to my original file.
Please help!?

Gonna need a save file to look at.
Also, this is why the pregnancy editing is still experimental :p

There you go.  If it's not too much to ask, could you possibly fix and repost the file for me if you can figure out what's wrong with it.
TiTs_2.zip

Also, yes, I will avoid using the pregnancy editing until it's not experimental.  lol  I just want my game back.    I really ought to have made back-ups like recommended.

TiTs_2.zip
This will be fixed in the next release of the editor.


ES6 example?

Hi,
I'm trying to make use of bar chart in a React app using ES6/Babel, but no matter what I try I'm always getting the following error:
Uncaught TypeError: Cannot read property 'Chart' of undefined
Anyone had this issue before?

In fact this is a webpack related issue, I solved by injection window into module using webpack's import-loader as described here:
http://webpack.github.io/docs/shimming-modules.html#importing

Can you post your full file? ES6 Works fine for me.


Outreach and training

I think in subsequent years we're going to have to start doing more outreach for Dockstore (probably not this year since we still have a lot of development tasks to take care of).  So ideas there:

setting up a training workshop at one of the big yearly conferences like ISMB
doing online training sessions a couple time a year (easiest thing to do really)
look at picking Geraldine's brain at the Broad and someone from the Galaxy/Biocontainers teams for training opportunities here

┆Issue is synchronized with this Jira Epic
┆Issue Number: DOCK-38

➤ Brian O'Connor commented:
[~casloan] did I create this epic correctly to be in our backlog?

Remade this is Seabright so it will not be in github SEAB-83


Async Transformers

I was using Compiler API and basically changed program.emit at host.afterProgramCreate just like examples and hooked my transformers into emit function. But one thing i couldn't find anywhere is a async transformer. Im using PostCSS and some other stuff like that and implementing those to a single typescript compiler but some plugins are async in postcss and i cant use them at the moment. Is there any way to implement this that im missing or undocumented ? And in case somebody offers to use webpack my code is mostly javascript based and i need really good static analysis for it with type data included that's also reason i use typescript's api instead of using babel which have those cases mostly covered with plugins. I'm implementing all-in-one solution for my company/community project so ideally it needs to be inside typescript compiler.

Can you give a concrete example of why the transformations/emit themselves being synchronous is a problem?

@DanielRosenwasser I think he want to integrate an async transform into the compiler, but the compiler expects all transforms to be synchronous.

Basically i need const Template = node.initializer.template as ts.NoSubstitutionTemplateLiteral;         PostCSS.process({ [(Cls as any).Tag]: Template.text }).then(p => {           node.initializer.template = ts.createNoSubstitutionTemplateLiteral(p.css);         }) instead of  const Template = node.initializer.template as ts.NoSubstitutionTemplateLiteral; const p = PostCSS.process({ [(Cls as any).Tag]: Template.text }); node.initializer.template = ts.createNoSubstitutionTemplateLiteral(p.css);
Tbh I dont think this is really necessary if i was writing whole system sync is more than enough but for 3rd party solutions i need this.

You could walk the tree, process all the postCSS tags asynchronously and save the results, then start a compilation/transform pass and perform the transformations synchronously using the saved results, no?

It would feel like a dirty hack but its possible. I will try it out and comment results. I hope it wont mess with watcher.

@kaaninel FWIW, we did what @weswigham suggested and pre-process all CSS into json and inline with https://github.com/longlho/ts-transform-json. The JSONs are then also feed into other toolchain like jest or webpack and prevents things like className gets generated differently. (We regenerate/filter certain class name bc of adblocker)

I implemented it ( in more basic way )
I basically scanned all of the typescript files and generated one big css file and processed it with postcss. Downside is I cant implement string interpolation.
Linker/CSSCompiler (Where i collect all css source)
Linker/CustomElements (Where i detect css sources)
Linker/Compiler (Where I process postcss and emit)


[SPARK-36054][SQL] Support group by TimestampNTZ type column

What changes were proposed in this pull request?

Support group by TimestampNTZ type column
Why are the changes needed?

It's a basic SQL operation.
Does this PR introduce any user-facing change?

No, the new timestmap type is not released yet.
How was this patch tested?

Unit test

Test build #140805 has started for PR 33268 at commit 0ccf08c.

Test build #140805 has finished for PR 33268 at commit 0ccf08c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140805/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45316/

Test build #140808 has started for PR 33268 at commit c47b3b6.

Test build #140808 has finished for PR 33268 at commit c47b3b6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140808/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45316/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45316/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45319/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45319/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45319/

The failed GA is related, it seems:
TwoLevelAggregateHashMapWithVectorizedMapSuite.SPARK-36054: Support group by TimestampNTZ column
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1252.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1252.0 (TID 1028) (localhost executor driver): java.lang.RuntimeException: Unhandled TimestampNTZType
	at org.apache.spark.sql.execution.vectorized.OnHeapColumnVector.reserveInternal(OnHeapColumnVector.java:572)

@gengliangwang Could you fix it, please.

Test build #140815 has started for PR 33268 at commit 032eb76.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45326/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45326/

+1, LGTM. Merging to master/3.2.
Thank you, @gengliangwang and @cloud-fan for review.

Test build #140815 has finished for PR 33268 at commit 032eb76.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140815/


feat(pixels): add my new pixel (17, 39)

Checklist

[x] I ran npm test locally and it passed without errors.

[x] I only edited the _data/pixels.json file.

[x] I entered the username in the pixels.json that I'm also using to create this pull request.
[x] I acknowledge that all my contributions will be made under the project's license.

Closing this as a duplicate. Thank you for your contribution!


Double systemd LimitNPROC to allow more threads

1. What does this change do, exactly?
LimitNPROC in caddy.service changed from 64 to 128
2. Please link to the relevant issues.
This change solved #1723 for me. I arbitrarily doubled 64 to 128, not sure what is a better value. The error seems to be that caddy requests a 65th thread and then gets denied. Not sure if relevant to #1823 since perhaps that will affect restarting (no more "restart too quickly" errors?). Pinging @wmark
3. Which documentation changes (if any) need to be made because of this PR?
None.
4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits (only one commit)
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'd set this to 512 to be on the safe side.
ulimit -u or LimitNPROC limits processes and threads (in the whole tree, with caddy as its parent). You can run into this limit on servers with lots of cores (Golang will start C×cores threads if not instructed otherwise) or if you use a plugin which starts its own processes (≠ goroutines).
Anyway, operators configure a limit here to catch misbehaviour early. (See also max smb processes on Samba.)
The natural limit is the »largest« thread count you can expect these days on a 8-way server. 28 cores it is since Broadwell on non-public cpus, and since Skylake for the public. 8× 28×2 +1 = 449.

Thank you!


Multivalue metrics support

The plugin doesn't support datasource types with multiple values like ps_count from processes plugin. value_list objects on those metrics usually have empty type_instance field and multiple values which aren't currently treated correctly. First value represents number of processes and second number of threads, and they are incorrectly treated as 2 datapoints for a single metric.
In the process example before we had only one metric
processes-some_process.ps_count-
with the changes we correctly have 2 metrics
processes-some_process.ps_count.processes

processes-some_process.ps_count.threads

Same applies to other types like ps_pagefaults, ps_disk_*, mysql_octets, node_octets
https://git.octo.it/?p=collectd.git;a=blob;f=src/types.db;h=68551875f2b3938cc1d8a1cd8c5539c473f6b545;hb=refs/heads/collectd-5.7

Thanks for your contribution. Looks like it is a perfect solution. We will evaluate it as soon as possible.
BTW, please make sure your codes are under MIT license control.

Cool thanks for the answer.
What do You mean by make sure ? I'm the only author and the changes are licensed under MIT. Should I do anything else ?

For the license, as you are the only author, and you claim it is under MIT, you do not need to do anything.
But Looks like the unit test missed.
Could you add some unit test to cover your logic?

I tested your codes on amazon linux,  the collecd is 5.7.1, but following error occurred.
Do you know why?
Failed to load datasource info for ps_cputime: 'module' object has no attribute 'get_dataset'

One thing comes to mind that old collectd.pyc file is still there and the unittest collectd module is loaded instead of the one that is provided by collectd.
I will add the unit tests for the new functionality and update the PR

Then, I think there are some backward compatibility issues.
1, If user installed the new software form old version, the old collectd.py will exist in "/opt/collectd-plugins/cloudwatch/modules/" directory, this function does not work correctly.
I guess we we should add ugly logic in setup.py to remove old collectd.py
2, In the document, the function of get_dataset was added to python plugin from collectd 5.5.0,
If user is using collectd 5.4.0, he can not use the metric will be like ps_count-value0, ps_count_value1.
But after he upgrade to collectd 5.6.0, he will see another extra metrics, ps_count-processes and ps_count-threads. I am afraid user will be confused to mapping the value0 to processes and mapping value1 to threads.
For this one, there is a solution on github, it is MIT license. https://github.com/mjuenema/collectd-plugins/blob/master/write_socket_keyval.py#L135
could you implement your own function to read typesdb?
Thanks for your contribution again.

if I create a class to get the values in a submodule we should get away with not removing collect.pyc or leave it as it was

yeah i was thinking about this, but there is no good way to get the configfile used for collectd so we will still miss some typesdb files or use wrong ones, I think including a static types.db data dict will be a good compromise

I have updated the PR with those 2 changes

It is a perfect solution. Thanks for your contribution again.


Fix Patron Tier Needed Message (OSB & BSO)

Description:

Some patron only commands also allow for server boosters to use. This resulted in the message below which was unclear on what was needed due to the nature of how the tiers are coded:

This will be fixed to say:

Changes:

If the needed perkTier - 1 = 0, use perkTier or server booster instead in the return message.

[X] I have tested all my changes thoroughly.

This needs to target OSB/master.

Fixed in https://github.com/oldschoolgg/oldschoolbot/commit/fe21aa38d8873f59d9d286802ff68c45dc312310


Enhancement: different judgment timings?

and theres this if needed

Safe frames and complex accuracy exist. Also, I mentioned the possibility of a 5th judgement earlier, and Kade said "no, just no" - I think that's really not happening.

nah ^

Safe frames and complex accuracy exist. Also, I mentioned the possibility of a 5th judgement earlier, and Kade said "no, just no" - I think that's really not happening.

^

ok ill try safe frames then


chore(client/radio): make sure to use valid id for inputs

Before this change, id could take value of "HTTP Basic", which is invalid in HTML5 because of the whitespace.
Cf. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id

I commited this: https://github.com/camunda/camunda-modeler/pull/1732/commits/b246412a4b30fc272900520b0867af848d51bc49 to make sure we don't have id clashes with random elements or something, I mean we can still have it but radio-element-XYZ looks like something more suitable for a radio element.. If you think it's useful, you can squash it, than we can merge it.
Nice catch!


PR: Fix DeprecationWarning: module 'sre_constants' is deprecated

Description of Changes
changed instances of sre_constants.error to re.error

re.error has been available since 3.0.0 and is considered the public interface. sre_constants, sre_compile, and sre_parse are considered depreciated as of 3.11. As of 3.13 re.PatternError replaces re.error (which is still kept for backward compatibility).
Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: athompson673

@meeseeksdev please backport to 6.x


Fix Russian locale

Fix the case for “1 minute”.
Also, it’s better to take the number modulo 100, just in case.

Thanks!


Nick wdi8

Would love any feedback especially on the exercises

looks good to me!

Love the club code exercise :+1:


fixbug: 首页图片样式

fixbug: 首页图片样式

Codecov Report

Merging #19 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #19   +/-   ##
=======================================
  Coverage   12.44%   12.44%
=======================================
  Files          30       30
  Lines         466      466
  Branches       58       58
=======================================
  Hits           58       58
  Misses        408      408

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8912c7...75f91ad. Read the comment docs.


OpenCV Image Processing

Image Processing

Require a feature to increase or decrease image brightness [Black to White].

[ ] add open-cv package
[ ] create a function which can be called from main.py
[ ] needs to take image path and lightness ( hsl ) percentage value to be changed.

the input color percentage will be 0.0 - 1.0 value which is in lightness percentage.

git fetch origin
git checkout feat/image-processing
@mallikarjuna478

can i ?

Hello @naveedyassin , sorry but this should have been private repo.


Multi-line strings possibly not corrected properly

In my code base, I usually handle long strings by breaking them within parens. When black puts the split string onto one line, it still keeps the strings separate. The example below should make it clear:
-            raise IndexError("arrays used as indices must be of integer "
-                             "(or boolean) type")
+            raise IndexError(
+                "arrays used as indices must be of integer " "(or boolean) type"
+            )

Question is: Can this be fixed or is there a reason why it needs to be this way?
Operating system: Ubuntu 18.04
Python version: 3.6
Black version: 18.5b0
Does also happen on master: yes

This looks like a duplicate of #26
We're definitely planning to fix this but it's not trivial for the reasons pointed out in #26.


Ftre filter

Hi, SuRaMoN!
I've added simple filter to PathIterator's constructor via forth parameter.
It makes possible to throw out some data from result.
Examples how it use into examples/filter-example{1,2}.php files.
I've used it in project and it realy works.

hey i'm sorry, but as far as i can see the new functionality can already be achieved with the use of a CallbackFilterIterator
If i look at example1 your code can be replaced with:
$animals = new \CallbackFilterIterator($xml->path('root/animal'), function ($animal) {
    return in_array($animal->attributes()->type, ['dog', 'kakariki']);
});
foreach(...) { ... }

The second example can also be replaced with a callbackfilteriterator:
$skipNext = false;
$animals = new \CallbackFilterIterator($xml->path('root/group/*'), function ($animal) use (& $skipNext) {
    if ($animal->getName() == 'type') {
        $skipNext = (string) $animal == 'wild';
        return false;
    }
    return ! $skipNext;
});

I prefer the CallbackFilterIterator approach above yours because it reuses existing iterators in the php standard library.
so unless i overlooked something, i cannot accept this

Hi,
In case huge XML with deep nested structure and requirement to  get a little edge subset data from it.  And when  "a little edge subset data"  depends on some elements/attributes' values of its parents/siblings - my variant, imho,  is consuming less memory/cpu and allows to get data in one pass without its later  postprocessing, in case of using CallbackFilterIterator.
I've added examples/filter-example3.php. The schema of xml data is a little crazy :)
Try to implement such filtering with using CallbackFilterIterator.


providers: add reddit

Partially closes https://github.com/SirCmpwn/pass-rotate/issues/9

Can this be done without relying on old.reddit.com? I have a feeling it's not going to stick around for long.

I have no intentions to try this out on new.reddit.com. In fact I have an extension to redirect me from reddit.com to old.reddit.com all the time in case I get linked to that abomination by mistake. Completely irrational from me, but the new design drives me nuts. Sorry I can't help in that aspect. Happy to let anybody else that wants to experiment (note: it won't be trivial, as I don't think s/old.reddit.com/reddit.com will work).
FWIW, https://old.reddit.com/r/help/comments/8mi7v2/for_how_long_will_old_reddit_be_supported/ reasons that the old version will exist for a long time. Obviously the reddit from years ago is not the reddit now, so we have no idea if the current management will continue to be kind enough to let older versions of their software stay.

Reddit has said they've got no plans to sunset the old design

from that thread; the comment didn't provide an official source, however

FWIW, https://old.reddit.com/r/help/comments/8mi7v2/for_how_long_will_old_reddit_be_supported/ reasons that the old version will exist for a long time. Obviously the reddit from years ago is not the reddit now, so we have no idea if the current management will continue to be kind enough to let older versions of their software stay.

This is a straight-up lie
I'm not comfortable merging a provider that could easily break within months.

Fair enough. I'll close the PR. If someone wants to build on this work, feel free to do so :)
And to whoever implements the more robust code, if it's not too much trouble, if you can mention me when it's merged, that'd be great!
For now I'll be using my fork just for reddit. Sigh, I have to remember to occassionally pull from upstream.

I'm not comfortable merging a provider that could easily break within months.

Just my two cents: frontend interfaces change all the time, and keeping up with them is near impossible. A lot of the code in this repo has hard-coded form IDs and whatnot, which will break eventually. Of course, there's no other alternative, which is pretty sad because these providers could easily provide a simple API for something like this.

Just my two cents: frontend interfaces change all the time, and keeping up with them is near impossible. A lot of the code in this repo has hard-coded form IDs and whatnot, which will break eventually. Of course, there's no other alternative, which is pretty sad because these providers could easily provide a simple API for something like this.

Aye, that's a reality we have to live with. But we could stand to not implement something when we know a breaking change is around the corner, especially when we can already access the new version for developing a more long-term solution with.

I'm not comfortable merging a provider that could easily break within months.

Unfortunately, that's probably true.  I'm sure that as soon as any kind of security vulnerability is found in old.reddit.com's code, or whenever it becomes the least bit inconvenient for them to keep it available, they will drop it.


Detect when user plays video

I can't figure out how to detect when a user plays a video, without having to rewrite all the player controls. I want to do this to collect telemetry on what the user is doing. Here's what I've tried:

Wrapping in a GestureDetector:

GestureDetector(
    onTapDown: (TapDownDetails d) {
        print("TAP");
    },
    child: YoutubePlayer(
        context: context,
        initialVideoId: "videoId",
        flags: YoutubePlayerFlags(
            autoPlay: false,
            showVideoProgressIndicator: true,
        ),
    ),
)

The detector does not detect user taps (I think this is because the youtube player wins the gesture arena?)

Adding a listener to YoutubePlayerController:

YoutubePlayer(
    context: context,
    "videoId",
    flags: YoutubePlayerFlags(
        autoPlay: false,
        showVideoProgressIndicator: true,
    ),
    onPlayerInitialized: (YoutubePlayerController controller) {
        controller.addListener(() {
            print("TAP");
        });
    },
)

Unofrtunately the listener is called multiple times when the player loads, before it is played, and I can't see any way to detect what event has triggered the listener, or query the controlelr for the play state (e.g. controller.isPlaying)
Am I missing something? Can you think of a way to accomplish this? I'm aware that I could use hideControls property to hide the default controls and implement my own set of controls on top of the player, but I'd rather not rewrite the play button, fullscreen button, duration etc. just to detect plays. If not, could you consider adding either a property to the controller which tells us the playing state (playing, paused, stopped) or add an argument to the listener callback which will tell us what event has triggered it?
Many thanks!

controller.addListener(( ){
     if(controller.value.playerState == PlayerState.playing){
          print('playing');
     }
});

You can listen for events like this.

Fantastic, thanks I had missed that. I just tried, it works. Please close the issue.
PS awesome plugin :)


Update Platform.yaml

Context: platform is needed to be added to data dictionary for this project https://www.synapse.org/Synapse:syn26957109


Android app installs without proper permissions

Installing directly from apk file :

Says "Requires no permissions" when installing
Then app doesn't work (because permissions are not granted e.g. Camera)

3772d4496594990921e6c9c623bf40e3325af1f2


Show both mnemonics and Hex seeds for the user wallet

Which package/s are you suggesting this feature for?
Dashboard
Is your feature request related to a problem? Please describe
when the mainnet account is created with 24 words mnemonics;
user will not be able to import his wallet to the TF connect app!
because when try to import using the 24 words it creates a new wallet in the app.
Describe the solution you'd like
showing the Hex seed in dashboard and tell the use the he must use these seeds not mnemonics to import his wallet in the app and can see the same balance.
Related to: https://github.com/threefoldtech/threefold_connect/issues/785

Work Completed

Fixed the copy button
Added a tooltip telling the user to use the hex seed when importing wallet in the app


doc complexity for all algorithms

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 96.632%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
373

Relevant Lines:
386

💛  - Coveralls


🚨 Create Incident Management Process for Operations Engineering

User Need
As a member of the Operations Engineering team
I want a formal process for calling incidents and engaging with stakeholders
so that everyone is aligned on the expectations during an incident and the process is consistent across teams.
Value
Having a well-documented process will ensure that all team members are informed on how to handle incidents, how to notify stakeholders, and how to proceed with resolutions. This will reduce confusion and improve the efficiency of incident management.
Functional Requirements (What):

[ ] Create an incident process runbook to document how to declare and manage incidents.
[ ] Outline the expected behaviour during incidents, including how to notify stakeholders.

Non-Functional Requirements (How):

[ ] Ensure that the runbook is easy to follow and accessible to all team members.
[ ] Include guidelines for how stakeholders should be informed and engaged during incidents.

Acceptance Criteria:

[ ] A formal incident process runbook is created and accessible.
[ ] Incidents are handled consistently according to the process, and stakeholders are engaged effectively.

Notes:
This will be backed up by the Operations Engineering ways of working document to ensure consistency in behaviour across incidents.
This ticket was created off the back of this incident.

Workflow to declare an incident - https://slack.com/shortcuts/Ft07V17L9ACX/4b3fac37f135ffbf6d613b60bfa3e5ea


Run hotspot tests after building OpenJDK artifact

It has been noticed while discussing and investigating issue 7, that hotspot tests do not get run when we run jtreg tests (currently setup to run jdk_core and langtools).
Ideally hotspot tests should also be run, as this does the sanity check on the JVM variant.

Covered by test pipelines


[Bugfix] Sticky - sticky-container should be 0px height when children…

When you have a responsive menu ("drilldown medium-dropdown" for example) and you put the dropdown in sticky mode, if you resize the window to small size to get the drilldown appears, the height of the sticky container will remains as before and you'll have a blank div between your menu and content.
See a codepen here :
https://codepen.io/gehasia/pen/JXMZJB
Just resize from medium to small and you'll se the sticky container, in red, remaining in the small size, pushing the content...
The height of the sticky-container is calculated depending on his children "sticky" element height. When using the responsive menu, if we resize the window until the drilldown breakpoint, the "sticky" dropdown will stay at the same height, but will pass in display="none". The proposal patch just test if the sticky element is displayed or not, and, in the last case, set the height of the sticky-container to 0...

I added another commit to bugfix for a different behavior :
With a sticky top-bar with different height depending on the .is-anchored or .is-sticky class and a css transition effect, there is a visual bug. The .sticky container does not resize when switching from anchored to sticky.
The patch force the _setSizes() after passing into sticky mode. It does it after waiting for all transition effects to be finished on the data-sticky element because if setSize() is fired before waiting for this, the setSize will get the wrong newContainerSize (the one before transition...).
I updated the code pen :
https://codepen.io/gehasia/pen/JXMZJB
Just see the red flashing when scrooling up and down..

Looks good

This messes up the sticky navigation example on the Sticky docs page. See https://github.com/zurb/foundation-sites/issues/8645.


gRPC master. Python tests

dbg on linux
https://grpc-testing.appspot.com/job/gRPC_master/config=dbg,language=python,platform=linux/8345/consoleFull

dbg on macos

https://grpc-testing.appspot.com/job/gRPC_master/config=dbg,language=python,platform=macos/8345/consoleFul
[gw2] FAILED grpc_protoc_plugin/beta_python_plugin_test.py::PythonPluginTest::testStreamingOutputCallCancelled...
[gw5] FAILED grpc_test/_adapter/_event_invocation_synchronous_event_service_test.py::EventInvocationSynchronousEventServiceTest::testSuccessfulStreamRequestStreamResponse <- grpc_test/framework/face/testing/event_invocation_synchronous_event_service_test_case.py
...
[gw5] FAILED grpc_test/_adapter/_event_invocation_synchronous_event_service_test.py::EventInvocationSynchronousEventServiceTest::testSuccessfulUnaryRequestStreamResponse <- grpc_test/framework/face/testing/event_invocation_synchronous_event_service_test_case.py
...
[gw4] FAILED grpc_test/_adapter/_future_invocation_asynchronous_event_service_test.py::FutureInvocationAsynchronousEventServiceTest::testSuccessfulStreamRequestStreamResponse <- grpc_test/framework/face/testing/future_invocation_asynchronous_event_service_test_case.py
...
[gw0] FAILED grpc_test/early_adopter/implementations_test.py::EarlyAdopterImplementationsTest::testStreamStream
...

Pinging this again. All Python MacOS tests are timing out.
https://grpc-testing.appspot.com/job/gRPC_master/11263/config=dbg,language=python,platform=macos/testReport/junit/(root)/tests/py_test/

Pinging
https://grpc-testing.appspot.com/job/gRPC_master/12020/config=opt,language=python,platform=macos/testReport/junit/(root)/tests/py_test/

Seeing this problem again on Linux, dbg

https://grpc-testing.appspot.com/job/gRPC_master/13729/config=opt,language=python,platform=linux/testReport/(root)/tests/py_test/
...
[0mTraceback (most recent call last):
  File "setup.py", line 176, in <module>
    test_runner=TEST_RUNNER,
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/var/local/git/grpc/src/python/grpcio/.tox/py27/local/lib/python2.7/site-packages/setuptools/command/test.py", line 142, in run
    self.with_project_on_sys_path(self.run_tests)
  File "/var/local/git/grpc/src/python/grpcio/.tox/py27/local/lib/python2.7/site-packages/setuptools/command/test.py", line 122, in with_project_on_sys_path
    func()
  File "/var/local/git/grpc/src/python/grpcio/.tox/py27/local/lib/python2.7/site-packages/setuptools/command/test.py", line 163, in run_tests
    testRunner=self._resolve_as_ep(self.test_runner),
  File "/usr/lib/python2.7/unittest/main.py", line 95, in __init__
    self.runTests()
  File "/usr/lib/python2.7/unittest/main.py", line 232, in runTests
    self.result = testRunner.run(self.test)
  File "/var/local/git/grpc/src/python/grpcio/tests/_runner.py", line 213, in run
    result.stopTestRun()
  File "/var/local/git/grpc/src/python/grpcio/tests/_result.py", line 291, in stopTestRun
    self.out.write(summary(self))
  File "/var/local/git/grpc/src/python/grpcio/tests/_result.py", line 419, in summary
    for result in itertools.chain(failures, errors)
TypeError: bad operand type for unary +: 'str'
ERROR: InvocationError: '/var/local/git/grpc/src/python/grpcio/.tox/py27/bin/python setup.py test'
___________________________________ summary ____________________________________
ERROR:   py27: commands failed

https://grpc-testing.appspot.com/job/gRPC_master/13729/config=dbg,language=python,platform=linux/testReport/(root)/tests/py_test/

Again
https://grpc-testing.appspot.com/job/gRPC_master/13753/config=opt,language=python,platform=linux/testReport/junit/(root)/tests/py_test/

The non-timeout one I'll get to tomorrow. The timeout ones still require digging into that I've still not yet gotten around to (Python debugger doesn't handle threads and haven't instrumented code, but that's next!). I have a few theories though.
@ctiller Is it well-defined that a server is ready and listening on a port the moment the grpc_server_start returns? Else is there any way in core to check whether or not a server has finished spinning up?

We call listen() before grpc_server_start, and start waiting for it to turn
readable when grpc_server_start is called, so off the top of my head I can
think of no reason why it wouldn't be ready. You'd need to be blocking in a
completion queue to notice, of course.
On Wed, Dec 16, 2015 at 10:20 PM Masood Malekghassemi <
<EMAIL_ADDRESS>wrote:

The non-timeout one I'll get to tomorrow. The timeout ones still require
digging into that I've still not yet gotten around to (Python debugger
doesn't handle threads and haven't instrumented code, but that's next!). I
have a few theories though.
@ctiller https://github.com/ctiller Is it well-defined that a server is
ready and listening on a port the moment the grpc_server_start returns?
Else is there any way in core to check whether or not a server has finished
spinning up?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/3870#issuecomment-165353046.

That... could be it. Would it be sufficient to pluck a bogus tag with immediate deadline (or even a deadline in the past) to let the server finish its waiting?
Alternatively, if a server isn't ready, a call is made to the server, and later the server starts up while the call hasn't timed out yet (... somehow; the parameters for this aren't clear in my head), does the server manage to respond to the call or is it one of those situations where the message is very likely lost in the aether?

The message won't be lost: the bytes for the request will be sitting in a
kernel buffer waiting to be picked up. If it's too long, what could happen
is that the client cancels its connection attempt, and then retries a few
seconds later (and repeat, with exponentially longer waits).
On Wed, Dec 16, 2015 at 11:02 PM Masood Malekghassemi <
<EMAIL_ADDRESS>wrote:

That... could be it. Would it be sufficient to pluck a bogus tag with
immediate deadline (or even a deadline in the past) to let the server
finish its waiting?
Alternatively, if a server isn't ready, a call is made to the server, and
later the server starts up while the call hasn't timed out yet (...
somehow; the parameters for this aren't clear in my head), does the server
manage to respond to the call or is it one of those situations where the
message is very likely lost in the aether?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/3870#issuecomment-165362383.

Hmm...

Would it be sufficient to pluck a bogus tag with immediate deadline (or even a deadline in the past) to let the server finish its initial waiting?
Does the server also retry if the client disappears before the timeout is up? If so, can a situation arise wherein the client calls (call 1), gives up, the server receives that call (call 1), and the client calls again (call 2), the server also receives that call (call 2), and the client and server talk over call 2 but the server is left hanging with call 1 until the deadline passes?

Each call only ever* goes out on one TCP connection. A bogus pluck or next
will allow the connection to establish. I did exactly this in
https://github.com/grpc/grpc/pull/4482 for similar reasons.

that might change one day, but I expect it'd be very opt in

On Wed, Dec 16, 2015, 11:15 PM Masood Malekghassemi <
<EMAIL_ADDRESS>wrote:

Hmm...

Would it be sufficient to pluck a bogus tag with immediate deadline
(or even a deadline in the past) to let the server finish its initial
waiting?
Does the server also retry if the client disappears before the
timeout is up? If so, can a situation arise wherein the client calls (call
1), gives up, the server receives that call (call 1), and the client calls
again (call 2), the server also receives that call (call 2), and the client
and server talk over call 2 but the server is left hanging with call 1
until the deadline passes?

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/3870#issuecomment-165365410.


Resolve source files later

The cleaning compiler may still remove some of the source files for
some configurations, so we may pass non-existing files to the compiler
which causes the compilation to fail.
See https://github.com/gradle/gradle/issues/5448.

LGTM.


Estimated value should appear on auction artwork pages

An auction artwork's estimated value (which we input in the "Estimate" field in Ohm) should appear on the auction artwork pages. When we launched HJFA Benefit Auction, we noticed that the "Estimate" field was not appearing on the auction lot artwork pages in the App.

Issue moved to artsy/auctions #177 via ZenHub


Bumped up version number - added logo to content library

This PR includes code to both update the content library version number to match the Scala Exercises current one, and also to add the logo to the content library.
Could you please review, @juanpedromoreno? Thanks!

LGTM!


Added code for pull server removal

This update fixes the following issues: #23, #26, #27, #28 and #29
I added an integration test with a few basic tests.
Because this update adds new logic and removes existing code (#29) someone should have a good look.

Hi @hahndorf, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

I spent hour trying to get my tests working on AppVeyor, in the end I gave up. DSC can't find my resources whatever I do.

Do you still need any input from me? I'm note sure why there is a Waiting for the author tag


service NodePaths are the IDs

$ latticectl services

                Service                | State  | Updated | Stale |             Addresses             | Info
---------------------------------------|--------|---------|-------|-----------------------------------|------
 /495a826d-754d-41c7-9524-17db5f69a5e2 | stable |       1 |     0 | 8080: http://<IP_ADDRESS>:32039 |
 /7f60cb1a-4858-45c9-b94b-77735135305c | stable |       1 |     0 |                                   |

Services paths should be like /petflix/api
Similarly --service should take node paths of the form /petflix/api. Currently you need to use the ID form:
$ latticectl services:addresses --service /495a826d-754d-41c7-9524-17db5f69a5e2

no longer an issue


Feature/single iterable parse rdf

implementing #81

Oh and btw, this is unrelated to your work but could you add a defaulted move assignment operator to IStreamQuadIterator? Would be nice to have I just forgot to provide that one

Oh and general PR note: I think everybody of us is totally fine with it if you just mark really simple issues as resolved yourself after you fixed them (for example the issue regarding marking begin() as const). Only if you want to of course, but I usually use that like "checking off entries in a todo list" :)


Update podspec to support watchOS

please update the platforms in the pod spec to support watchOS for 0.6-beta.1

Sorry, but the podspec isn't supported or maintained by this repo. It lies over here. I'd suggest opening a PR there to add watchOS. :smile:

Pull requests on the Specs repo is not recommended way now: https://github.com/CocoaPods/Specs/pull/12199. So you should contact the pod owners listed in the info by $ pod trunk info Result.

Like @ikesyo mentioned, since the introduction of the CocoaPods trunk, it is no longer possible to update a podspec through a PR on the Cocoapods/Specs repo.
A few weeks ago, I updated the podspec for Result by manually pulling the json from the specs repo, making changes and push it again (like @gfontenot described). I'd be ok with doing this again for the requested change. We could also consider adding the .podspec to this repository, so people can update them with a PR if needed. That seems to be the approach most pods take.
@JARinteractive in the meantime, you can make a local copy of Result.podspec with watchOS support and use that one.

We could also consider adding the .podspec to this repository, so people can update them with a PR if needed. That seems to be the approach most pods take.

In the past I’ve been reluctant to add a .podspec because I’m not really able to maintain them myself, and it wasn’t really necessary. I think we have a sufficient mass of invested maintainers here (whether collaborators on the repo or folks willing to fork) that it’d be worth adding one if it will make API consumers’ lives easier.
I’m still not in a great position to write one myself, but if someone would like to submit a PR with one, I’d be grateful!
Going to repurpose this issue to track that in the meantime, too.

I'm happy to maintain that, since I kind of already am. It'd be nice for it to be tracked here instead of in a random dir on my machine.
Opened a simple PR. Please make comments if I'm missing any crucial info.

Thanks @gfontenot :heart:


IPV6_UNICAST_HOPS not defined on Fuchsia

#925 added a bunch of IPV6_MULTICAST_* definitions, and mostly applied them consistently between notbsd unix and fuchsia, but seems to have left off IPV6_UNICAST_HOPS in particular from the fuchsia module. From a shallow look, it seems like a simple oversight, the fix is probably to add it with the same value as notbsd.
This is causing net2 0.2.32 to fail to compile on Fuchsia, I'm temporarily working around this by pinning to net2 0.2.31.
Happy to provide a PR if it's the simple one-liner it appears to be, but wanted to sanity-check first.
ping @bluejekyll as author of the patch

Oh yeah a PR to add any missing constants should be totally fine!

Thanks for taking care of this. Do the automated tests not cover Fuchsia today?

Not covered yet, but we're hoping to at some point. It's not trivial to add because it's a whole operating system; it should be possible to ship images that run in qemu, but we don't have stable releases yet.

Thanks. I'm worried that there will be a similar problem with Redox as well...


chore: add native flag component, ref ref leather-io/issues#262

This PR adds a Flag component for native to the UI library.
Demo:
https://github.com/user-attachments/assets/5cc9a9d7-0cf2-4898-a8fb-f850e8076456

@edgarkhanzadian : Thanks for the approval 🙇
I have refactored it to use Box as you suggested and to use inline props. Do you mind taking another look to double check?


Get started data pipeline misses dvc init

Hi,
It think this file content/docs/start/data-management/pipelines.md misses the dvc init (or the downloaded zip should have the .dvc folder)

The index page has it - https://dvc.org/doc/start
Clearly this index page (the first part of it?) should belong here https://dvc.org/doc/start/data-management
And https://dvc.org/doc/start/data-management should become a separate section
cc @jorgeorpinel @iesahin


Problem the to star edit code

Problem encountered on https://dotnet.microsoft.com/es-es/learn/dotnet/hello-world-tutorial/edit
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

i don´t understand to star code, if are puting a correct code


Linter-Flake8 error

New to Python/programming - trying to set up an environment to learn/practice. I can't get flake8 to work. I keep receiving an error that I believe is stating flake8 is not in the correct path? (see image) I tried changing the path setting in linter-flake8 to match where my Command Prompt is showing flake8 (see other image) was installed, but no luck. Not sure if I'm doing it right.
Thanks for your help.

Assuming Python was installed normally you may just need to fully restart Atom if you haven't since installing Python.
Does where.exe flake8 show a result?

Closing due to a lack of response.


Feature Request: Private git sub-modules on Github

Feature Request
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
insert the output from ionic info here

Describe the Feature Request
A clear and concise description of what the feature request is. Please include if your feature request is related to a problem.
Since couple of weeks it's possible to use public projects on Github as git sub-modules when building in ionic pro.
This ticket is a feature request to also being able to include private Github projects as git sub-modules when building on ionic pro.
Describe Preferred Solution
A clear and concise description of what you want to happen.
Use configured Github credentials to pull down git submodule.
Describe Alternatives
A clear and concise description of any alternative solutions or features you've considered.
None.
Related Code
If you are able to illustrate the feature request with an example, please provide a sample application via an online code collaborator such as StackBlitz, or GitHub.
Additional Context
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to add, use case, Stack Overflow links, forum links, screenshots, OS if applicable, etc.

Hi there! This is the issue track for the Ionic Framework, not Ionic Pro. For feature requests and bug reports, please open a ticket on the official Ionic Pro Help Center.
https://ionic.zendesk.com/hc/en-us

Well I did but they told me to also open a issue here 😄


Custom Microservices section is incomplete

These are issues with the  Custom Microservices section in the docs -

The creating a git push portion does not actually explain how to add the hasura remote or actually use git push to deploy the service.
The Managing a custom microservice portion is completely empty.

Added a commit to pull request #67 with the following changes

Added a deploy subsection to the Create a git push service page.

The following problems still exist

Managing a custom microservice section is still empty.
Images need to be updated with the newer console ui.


[AIRFLOW-1310] Basic operator to run docker container on Kubernetes

Dear Airflow maintainers,
The PR contains implementation of the hook and operator that allow creation,
deployment and tracking of docker containers to Kubernetes pods.
The hook supports crating the specification, deploying,
and deleting the pod, while the operator allows for fire-forget
or wait for completion execution modes.
The feature was requested here https://issues.apache.org/jira/browse/AIRFLOW-1310
Suitable test cases provided.
The operator is being used for last few weeks without any major issues in our internal deployments.

Codecov Report

Merging #2456 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2456   +/-   ##
======================================
  Coverage    69.4%   69.4%
======================================
  Files         146     146
  Lines       11289   11289
======================================
  Hits         7835    7835
  Misses       3454    3454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751e936...c231e0b. Read the comment docs.

As far as I understand #2414 is a larger effort to provide native K8s executor. This is a simple operator that allows spawning any docker based container on a (remote) K8s cluster. Does not require k8s executor so you might stay on your local/celery for general operation and just deploy selected containers to k8s.  I suppose both PRs might be integrated/or this replaced when 2414 is ready


float() argument TypeError in a scan.

Discussed in https://github.com/google/jax/discussions/19057

Originally posted by xaviergonzalez December 19, 2023
I have a really weird jax bug with scan, I'm wondering if anyone else has seen similar issues?
Here's a minimal reproducible example:
import jax
import jax.numpy as jnp
import jax.random as jr

def g(hiddens):
    hiddens_aug = jnp.vstack((hiddens[0], hiddens))
    new_hiddens = hiddens_aug.copy()
    diff = new_hiddens[:-1] - hiddens
    diff = new_hiddens[:-1] - hiddens
    out = jnp.trace(jnp.conj(diff).T @ diff).real
    return jnp.array(out, dtype=jnp.complex64)

def _step(carry, arg):
    primals, f_vjp = jax.vjp(
        g,
        jr.normal(jr.PRNGKey(0), (9, 8), dtype=jnp.complex64),
    )
    out = f_vjp(1.0 + 0j)[0]
    return carry, carry

So far, so good. I've defined a function g, that basically maps from \C^8 to \R (casted to be complex for typing reasons), and used vjp to differentiate it (grad behaves a bit weird with these functions). Now, I'd just like to do a lot of these iterations with a scan.
The following code works completely fine
primals, f_vjp = jax.vjp(g, jr.normal(jr.PRNGKey(0), (9,8), dtype=jnp.complex64))
out = f_vjp(1.0 + 0j)[0]

out has shape (9,8), and dtype complex64, as desired.
Note that this code are basically the two lines of the _step, except they aren't even returned.
However, the following code returns a TypeError
a, b = jax.lax.scan(_step, 0, jnp.arange(4, dtype=jnp.complex64))

Gives error:
TypeError                                 Traceback (most recent call last)
<ipython-input-4-e5de119df33f> in <cell line: 1>()
----> 1 a, b = jax.lax.scan(_step, 0, jnp.arange(4, dtype=jnp.complex64))

    [... skipping hidden 10 frame]

/usr/local/lib/python3.10/dist-packages/jax/_src/lax/lax.py in _convert_elt_type_folding_rule(consts, eqn)
   2375       isinstance(o.aval, core.UnshapedArray) and not np.shape(c) and
   2376       not dtypes.issubdtype(eqn.params['new_dtype'], dtypes.extended)):
-> 2377     out = np.array(c, eqn.params['new_dtype'])
   2378     if not o.aval.weak_type:
   2379       return [out], None
TypeError: float() argument must be a string or a real number, not 'complex'

Notice that _step doesn't even return anything relating to its intermediate computations! Moreover, I can see that when I comment out the line
out = f_vjp(1.0 + 0j)[0]

the error goes away.
I'm really at a loss as to why this line is completely fine outside of a scan, but crashes the scan, even though it is unrelated to either the input or output of _step. I've really been struggling to debug inside of the scan.
If anyone has seen this type of error before, or even just has tips about how to debug inside of a scan, I'd be super grateful to hear them.

We're basically doing this inside a constant folding step:
import numpy as np
np.array(1+0j, np.dtype('float32'))

which gives
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 np.array(1+0j, np.dtype('float32'))

TypeError: float() argument must be a string or a real number, not 'complex'

So our constant folding logic is wrong, just in that apparently NumPy doesn't like when we try to ask for a float32 array containing a complex (builtin) type.

#19061 should fix.
Thanks for reporting this with the easy repro @xaviergonzalez ! It's a big help.


Implement reset-password

This the endpoint that does the actual password reset.

I'll like to work on this
Please assign me

have you worked on this @VictorAO-django or I should @gray-adeyi

Can you attempt #11


If the predicate is a function the error is not passed through to the catch handler

Code to reproduce:
var pCatchIf = require('p-catch-if');

class FooError extends Error {
    constructor(message) {
        super(`Foo error: ${message}`);
    }
}
const isFooError = (err) => err instanceof FooError;
const catchHandler = (err) => console.error(`Caught error '${err}' in catch handler.`);

return Promise.resolve()
    .then(() => Promise.reject(new FooError('Bar happened!')))
    .catch(pCatchIf(isFooError, catchHandler));

Expected Behaviour:

Caught error 'Foo error: Bar happened!' in catch handler.

should be logged to the console as an error
Current Behaviour:

Caught error undefined in catch handler.

is logged to the console as an error instead

Thanks @SamVerschueren   - was going to pick this up after work last night but something came up.


Disable EiraIRC through server

Would it be possible to add something to EiraIRC which would make server owners able to disable the EiraIRC in the client. Some owners doesnt want it, and when they download it they would automatically get it, and they would have needed to restarted the whole pack to remove it.

I don't quite see the point - how does it matter to server owners? Which features of EiraIRC in particular do you want disabled on player clients?
In any case, it would still be a voluntary choice for the user. If I implement this, it'll make use of the same UI as the Redirect dialog, so that users can (always) accept or refuse.

Closed for now since there was no response for nearly two months. Feel free to re-open when it becomes relevant again.


Handle updates, rolling update preferences and revisions in federated deployment controller

 Issue by mwielgus
Monday Nov 28, 2016 at 20:14 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/37570

... in a more consistent way, especially when looking from the cross-cluster perspective. Currently there is no rolling update subresource, sub-deployments may have different revision numbers, max surge/max unavailable are handled separately in each cluster, etc.
cc: @madhusudancs @nikhiljindal

 Comment by nikhiljindal
Wednesday Mar 08, 2017 at 23:02 GMT

no rolling update subresource

We do have the /rollback subresource in federation-apiserver: https://github.com/kubernetes/kubernetes/blob/98ae5722251f5f88474af1a0d91b3244844fa9f6/federation/cmd/federation-apiserver/app/extensions.go#L50. Need tests for it.

 Comment by ethernetdan
Tuesday Mar 14, 2017 at 07:10 GMT

Moving to 1.7 because too late for 1.6. Feel free to move back if this is incorrect.

 Comment by marun
Monday Jun 12, 2017 at 20:42 GMT

I'm assuming this shouldn't be blocking 1.7.

 Comment by quinton-hoole
Friday Aug 04, 2017 at 18:05 GMT

According to #39987, @perotinus will work on this. Assigning accordingly.

 Comment by quinton-hoole
Friday Aug 04, 2017 at 18:06 GMT

/assign perotinus

 Comment by quinton-hoole
Friday Aug 04, 2017 at 18:06 GMT

/unassign mwielgus

 Comment by perotinus
Friday Aug 04, 2017 at 18:41 GMT

/unassign perotinus
I'm not working on this at the moment.

 Comment by quinton-hoole
Friday Sep 08, 2017 at 01:01 GMT

Required for GA.

cc @mwielgus


Support parallel events

Please up-vote if you want this feature. Do not submit a new feature request.

This feature was supported in v3.0. Please open a new issue if the feature is not working as expected. Thanks.


How do we merge schemas?

Describe the bug
When using dbt_project_evaluator I get the error below. I have set  spark.databricks.delta.schema.autoMerge.enabled to true, but it's not evolving the schema.
Ultimately I'd love to know what setting I can add to make this merge the schema
07:55:15    Runtime Error in model base_source_columns (models/staging/graph/base/base_source_columns.sql)
  [_LEGACY_ERROR_TEMP_DELTA_0007] A schema mismatch detected when writing to the Delta table (Table ID: da497304-2797-46fe-9185-037ee80ec708).
  To enable schema migration using DataFrameWriter or DataStreamWriter, please set:
  '.option("mergeSchema", "true")'.
  For other operations, set the session configuration
  spark.databricks.delta.schema.autoMerge.enabled to "true". See the documentation
  specific to the operation for details.

  Table schema:
  root
  -- node_unique_id: string (nullable = true)
  -- name: string (nullable = true)
  -- description: string (nullable = true)
  -- data_type: string (nullable = true)
  -- quote: string (nullable = true)

  Data schema:
  root
  -- node_unique_id: string (nullable = true)
  -- name: string (nullable = true)
  -- description: string (nullable = true)
  -- data_type: string (nullable = true)
  -- quote: string (nullable = true)
  -- col6: boolean (nullable = true)
  -- col7: integer (nullable = true)
  -- col8: string (nullable = true)

  Table ACLs are enabled in this cluster, so automatic schema migration is not allowed. Please use the ALTER TABLE command for changing the schema.

Steps To Reproduce
I added dbt_project_evaluator and it started failing.
models:
  dbt_project_evaluator:
    +schema: dbt_project_evaluator
    +materialized: table
    +databricks_tags:
      project: dbt
    +tblproperties:
      mergeSchema: true

# https://dbt-labs.github.io/dbt-project-evaluator/0.8/#additional-setup-for-databrickssparkduckdbredshift
dispatch:
  - macro_namespace: dbt
    search_order: ['dbt_project_evaluator', 'dbt']

System information
The output of dbt --version:
➜  main git:(develop) dbt --version
Core:
  - installed: 1.8.3
  - latest:    1.8.3 - Up to date!

Plugins:
  - databricks: 1.8.3 - Up to date!
  - redshift:   1.8.1 - Up to date!
  - postgres:   1.8.2 - Up to date!
  - duckdb:     1.8.1 - Up to date!
  - spark:      1.8.0 - Up to date!

The operating system you're using:
OSX 14.3.1 (Sonoma)
The output of python --version:
python --version

 Table ACLs are enabled in this cluster, so automatic schema migration is not allowed. Please use the ALTER TABLE command for changing the schema.

I am not familiar with the dbt_project_evaluator, but the above statement is the key.  We do not generally use schema evolution today, as there are many edge cases that do not work as expected.  The current patterns are:

for non-incremental, use create or replace for Delta, or drop and create for non-Delta
for incremental we make a new table for the incremental data and then merge matching columns from the existing table into the new table.  The details of this are managed by on_schema_change.


Layout Mode is available on Page and Components

This was discussed earlier as well. Basically - since these pages/components are not web components we want to disable layout button (if possible) at Page as well as Component level.

Hello @priyankpardiwala,
I checked the issue mentioned and noticed that the layout mode is still enabled in experience fragment page as well as any component added to that page.
I have since disabled the option, this fix should be available with the next release.
Thank you,
Noor


TFLite produce wrong results when add follows a leakyrelu

1. System information
Reproduced on 2.11.0.dev20220914 and 2.8.2 .
2. Code
Option A: Reference colab notebooks
https://colab.research.google.com/drive/1VfnLOX68h0rMrTA3Fqk4moIOTLOL-P22?usp=sharing
Option B: Paste your code here or provide a link to a custom end-to-end colab
import tensorflow as tf

def get_tflite_callable(model, inp_dict):
    converter = tf.lite.TFLiteConverter.from_concrete_functions(
        funcs=[model.__call__.get_concrete_function(**inp_dict)],
        trackable_obj=model,
    )
    converter.target_spec.supported_ops = [
        tf.lite.OpsSet.TFLITE_BUILTINS, # enable TensorFlow Lite ops.
        tf.lite.OpsSet.SELECT_TF_OPS # enable TensorFlow ops.
    ]
    tflite_bytes = converter.convert()
    interpreter = tf.lite.Interpreter(model_content=tflite_bytes)
    runner = interpreter.get_signature_runner()
    return runner

class MyModule(tf.Module):
    def __init__(self):
        super().__init__()
        self.const = tf.constant([-10.43154963850975037], dtype=tf.float64)

    @tf.function
    def __call__(self, x):
        c = tf.raw_ops.LeakyRelu(
            features=self.const, alpha=0.1,
        )
        x = tf.add(c, x)
        return x

inp = {
    "x": tf.constant([3.12363398], dtype=tf.float64),
}
m = MyModule()

out = m(**inp)
print(f'{out}') # t = <tf.Tensor: shape=(1,), dtype=float64, numpy=array([2.080479])>

runner = get_tflite_callable(m, inp)
out = runner(**inp)['output_0']
print(f'{out}\n{out.dtype}') # out = array([3.12363398])  out.dtype = dtype('float64')

3. Failure after conversion
Model produces wrong results and/or has lesser accuracy.
Actually, in this case, TFLite just outputs the input. It seems that the const number after leakyrelu and then added to the input is omitted.

@Co1lin !
Thanks for reporting this bug.
@sachinprasadhs !
Could you look at this issue. Attached gist in 2.9, 2.10 and nightly for reference.
Thank you!

I can confirm the behavior is only happening with tf.nn.leaky_relu / tf.raw_ops.LeakyRelu and it works well with the Relu.
Thanks for reporting the bug, we will look into it.

Issue still persists on TF 2.11 and TF Nightly. Please find the gist here. Thank you!

Hi, The ideal way to compare would be to define a sample Keras model with leaky relu and compare the results between Keras model and TFLite converted model.
Could you please provide those comparison. Thanks!

Could you please follow the python API from the formats mentioned below https://www.tensorflow.org/lite/models/convert/convert_models#python_api_,

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The TFLite team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the TFLite space.


Initial load of grammar is extremely slow

For the following file...
\documentclass{article}

\begin{document}

Hello world

\end{document}

When ensure_installed = { ..., 'latex' }, loading of this file takes multiple seconds. This only occurs once per instance of neovim. This is in stark contrast to any other treesitter grammar plugin I use.

LaTeX is just a very complicated language to parse, with a lot of hard-coded commands that need to be supported. That just makes for a large (and expensive to load) grammar.
(You're lucky with your other grammars then; LaTeX is by far not the worst offender -- take a look at verilog...)
That being said, I'm sure there's things that can be done to improve size and load speed (see, e.g., https://github.com/tree-sitter/tree-sitter/wiki/Tips-and-Tricks-for-a-grammar-author); help is surely welcome.

I will definitely take a look and see if I can contribute! I just noticed it was slow compared to other languages I have treesitter active for (I haven't use verilog for years!) and wanted to put an issue out.


feature: implement exec and attach method of stream server

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #854 into master will decrease coverage by 0.27%.
The diff coverage is 0.59%.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   14.89%   14.62%   -0.28%
==========================================
  Files         114      115       +1
  Lines        6826     6960     +134
==========================================
+ Hits         1017     1018       +1
- Misses       5723     5855     +132
- Partials       86       87       +1

Impacted Files
Coverage Δ

daemon/mgr/container_types.go
15.38% <ø> (ø)
:arrow_up:

daemon/mgr/cri_stream.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container.go
2.68% <0%> (-0.13%)
:arrow_down:

daemon/containerio/container_io.go
0% <0%> (ø)
:arrow_up:

daemon/containerio/options.go
0% <0%> (ø)
:arrow_up:

daemon/containerio/streams.go
3.7% <3.7%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c235e2...9a4087a. Read the comment docs.

@allencloud PTAL.

LGTM