Prevent image stretching

Hello again
Using markdown for writing my report I've included images.
However small images get stretched over the full page width using this command:
pandoc src.md -o out.pdf \
  --from markdown+yaml_metadata_block+raw_html \
  --template eisvogel \
  --table-of-contents \
  --toc-depth 6 \
  --top-level-division=chapter \
  --highlight-style zenburn \
  --pdf-engine xelatex

Image is included with:
![](/full/path/to/image-20200530001039454.png)

However, images that would overflow the page are reduced correctly to the site's width.
How can I disable stretching the smaller ones?

i'd guess that this is due to the definition in line 368 ff:
% Scale images if necessary, so that they will not overflow the page
% margins by default, and it is still possible to overwrite the defaults
% using explicit options in \includegraphics[width, height, ...]{}
\setkeys{Gin}{width=\maxwidth,height=\maxheight,keepaspectratio}

what happens if you specify the dimensions directly, like ![](/full/path/to/image-20200530001039454.png){width="100%"}?

This produces the same output.
I assume that's caused by the 100% referencing the full page width.
However setting the {width="10cm"} allow me to adjust the size and it also keeps the ratio.
Additionally the image needs to be centered by additional attributes / commands.
Maybe this can be streamlined for a better user experience?
However, the lines you are referencing are within an $if(graphics)$ blocks.
If I comment out the if and endif line to always use this settings, compiling does not work:
Error producing PDF.
! Package keyval Error: width undefined.

See the keyval package documentation for explanation.
Type  H <return>  for immediate help.
 ...

l.169 ...xwidth,height=\maxheight,keepaspectratio}

hmmm, that reminds me of generating beamer slides with pandoc, where the same behaviour can be observed.
the lines mentioned are inherited from the original latex template in pandoc. maybe it's an upstream issue?

However small images get stretched over the full page width using this command:

I can not reproduce this behavior. When I include a small image it gets embedded without stretching:

issue-178-image-stretching.zip

i'd guess that this is due to the definition in line 368 ff:
% Scale images if necessary, so that they will not overflow the page
% margins by default, and it is still possible to overwrite the defaults
% using explicit options in \includegraphics[width, height, ...]{}
\setkeys{Gin}{width=\maxwidth,height=\maxheight,keepaspectratio}

Yes, that is the code to resize images. In full, it looks like this:
$if(graphics)$
\usepackage{graphicx}
\makeatletter
\def\maxwidth{\ifdim\Gin@nat@width>\linewidth\linewidth\else\Gin@nat@width\fi}
\def\maxheight{\ifdim\Gin@nat@height>\textheight\textheight\else\Gin@nat@height\fi}
\makeatother
% Scale images if necessary, so that they will not overflow the page
% margins by default, and it is still possible to overwrite the defaults
% using explicit options in \includegraphics[width, height, ...]{}
\setkeys{Gin}{width=\maxwidth,height=\maxheight,keepaspectratio}
$endif$

the lines mentioned are inherited from the original latex template in pandoc. maybe it's an upstream issue?

It looks like it. If I remember correctly pandoc takes things like DPI into account when embedding images. Maybe your image has embedded dpi information? Can you provide the image in question and a minimal example in a ZIP file?
You may want to report it upstream in the pandoc issue tracker (https://github.com/jgm/pandoc/issues).


Cmd refactor

Implement operator<<() for command classes
Implement Keyfield support for loading keys
Correct missing key denotations in source files

Resolves #222

Looks good to me: especially as someone whose C++ is a bit rustier, the << makes more sense to me than adding a sequence of fields. The only concern that I have is that it will add some extra code if we start needing to support additional types of fields since we have to duplicate add_field and the << operator definition. That being said, the tradeoff is worth it for readability/compactness.


Forcing request.validate() to run only for body

I think maybe this is a bug, or can lead to serious issues about handling user's input; or it's just me using it wrong.
Currently if I use request.validate(), it will merge the query params and body to validate; while our app uses only request.body() to get inputs from users. So if the request.body() contains invalid data, and user tricks the app with correct query params, it will pass the validation.
Is this a bug or it suppose to do this?

Never mind, the validate function returns validated data. I should use it.


Running big SELECT/INSERT takes ages and only uses 1 core

Unsure where it is being caught.... Possible that it is a sled thing... I don't remember this being an issue in the past.

Ah, the query was a bunch of SELECT/INSERTs but still, it was running for ages (~5min) and I only observed 1 core being properly used.


[WIP]feat(github): Add option to override a commit's message through commit comments

Add the option to override a commit's message through a specially formatted comment on GitHub.
When present, the comment text will replace the commit's message for further processing.
This allows to either add or remove a entry from the generated change log through either adding a conventional commit message to a commit or setting the message to an unparsable value.
TODOs

[x] Split loading and parsing into separate tasks
[ ] Load "override comments" from GitHub
[ ] Add settings to enable/disable behaviour
[ ] Update documentation
[ ] Limit comments that can change the change log to certain users?

Overriding of commit messages was implemented through git notes in #297, making this obsolete


Update Features

This PR includes updating feature names and including CPU Frequency. An Issue I wanted clarification on was what are the metric columns for kepler_node_cpu_scaling_frequency_hertz and kepler_container_cpu_cpu_time_us queries to be used as features in node training? It's not very clear what the metric name should be. Refer: https://www.notion.so/Sync-up-Kepler-version-b79303ddc3814308aa9f134b1031c261

For node training, we may need cpu_frequency feature. kepler_node_cpu_scaling_frequency_hertz provides frequency per cpu core. We may simply find stats such as min, max, average, std and use and features. Optionally, we can also use the information of usage on each cpu core from kepler_container_cpu_cpu_time_us to give a weight of frequency for each core too (instead of equally taking an average). We may try multiple ways to generate the features to find the best model.


Allow larger mealtime SMBs

In order to prevent post-meal lows, it would be good to be able to reduce the size of mealtime boluses when autosens is detecting sensitivity (autosens ratio < 1).  With #618 oref0's mealtime dosing will be adjusted for that, but it might also be good to make it easier for PWDs to avoid having to do such calculations themselves, and instead allow them to do a smaller initial meal bolus and let oref1 handle the difference as appropriate for each situation.
Once #618 is merged, we might also want to:

Reduce default remainingCI time from 4h down to 3h, effectively reducing the "default carb absorption time" accordingly, and allowing oref1 to cover more of a meal without always first assuming the meal with absorb slowly and cause a low around 3h afterward.  For example, 90g of COB would be assumed to absorb at 30g/hr over 3h instead of 22.5g/hr over 4h.  In the event of a large slow (pizza-type) meal, the timeframe over which the remaining COB are predicted to absorb would continue to be extended out to 3h from the current time until actual carb absorption ramps up enough to predict absorption of the remaining carbs before then.
Allow oref1 to be configured with a maxBolus value, and use that (rather than 30m worth of basal) when IOB is too low to cover more than a fraction (perhaps 2/3 or 3/4) of COB.  This would allow oref1 to more quickly SMB when a meal is under- (or not) bolused for.  For basals up to 1.5 U/h, a reasonable maxBolus value might be 1 U.
Consider allowing oref1 to SMB for 1/2 of insulinReq (vs. 1/3 normally) when IOB is too low to cover more than half of COB.  This would allow it to more quickly get insulin activity going when carbs are entered but no bolus is given.  For example, if IOB is 0, COB is 60g, and insulinReq is 3U, then oref1 could dose up to 1.5 U (or maxBolus, whichever is lower), and continue to dose half of the remaining insulinReq every 5m until IOB got up to 3U, at which time it would slow down to 1/3 of insulinReq every 5m.
In both of the latter cases, we could consider the SMB-delivered meal boluses as regular boluses that count towards bolus IOB rather than counting them toward basal IOB as we do with smaller SMBs.  Large SMBs could occur right after carb entry (until IOB catches up to COB), so the SMB time period would not be extended much.  This treatment might trigger bolus snooze in some cases, but less so than a (larger) manual bolus would.

These changes will all need to be carefully considered and extensively tested for safety, but my intuition is that allowing larger mealtime SMBs would allow for smaller upfront meal boluses and reduce the risk of post-meal lows for individuals with well-tune basals and ratios (via autotune or manual tuning).

Perhaps a better idea than reducing the remainingCI "default carb absorption" time from 4h down to 3h would be to change remainingCI from a constant to a bilinear curve that increases from 0 to a peak absorption rate (in g/h) of remainingCarbs/2, and then symmetrically decreases back to 0 at the 4h mark.
So if you entered 120g of carbs and had zero absorption so far, oref0 would model absorption starting at 0, increasing to 30 g/h after 60m (1h), 60 g/h after 120m (2h), then back to 30 g/h after 180m (3h), and 0 g/h after 240m (4h).  The average carb absorption over hours 1 and 4 would therefore be 15 g/h, and 45 g/h for hours 2 and 3.
For comparison, the current oref0 code would model that same 120g meal with a remainingCI equivalent to a constant 30g/hr for the entire 4 hours.
As actual carb absorption is observed, the extrapolation of the current rate of carb absorption, linearly decreasing just fast enough to use up all the carbs by the time absorption hits zero, would gradually take over, and the future predicted carb absorption dominated by the /\ shaped remainingCI bilinear curve would transition to a \ shaped linear one.
This change would have a few main benefits.  Firstly, it would eliminate the sudden jumps and drop-offs we see with a constant remainingCI.  Today, if a 120g meal is entered w/o observed carb impact, we assume that carb absorption will instantly ramp up from 0 to 30 g/h, and then instantly drop off from 30g/h to zero after 4h.  That is obviously unrealistic.  Secondly, it would better match predicted CI to what we actually would expect to observe from a typical meal, resulting in more accurate cobPredBGs.  And thirdly, it would continue to allow us to "push out" the predicted remainingCI past 4 hours when current CI is not rising as fast as predicted, while allowing CI predictions to be "pulled in" when carb absorption is actually observed.

This has been implemented in 0.6.0-dev.  Closing this issue in favor of tracking further in #707.


Fix cxxopts passed to C compiles

Previously since the fragment's cxxopts were always passed, these were included in validating C files

Thanks!


glib: replace struct Continue with an enum

Having Continue(true) and Continue(false) does not look very idiomatic. Using an enum is more natural.
However using an enum also means that we need to come up with a name for it... This patch proposes Control, but I am open to any better ideas. For now I did not add Control to the prelude.

glib signal has another similar struct: struct Inhibit. I think we should use an enum for it as well, however there are various things to consider:

Do we really need a generic Propagate/Inhibit mechanism for all signals? glib itself only defines GDK_EVENT_PROPAGATE  and STOP at the Gdk level and only uses it for events.
If we decide to keep it, we have one more naming problem... signal::Control and require the caller to disambiguate with namespaces? Or we go with SourceControl and SignalControl? Or we use something different entirely?

Needs to be (partially) re-opened on gtk-rs-core.


Simply ignore flushes if buffer smaller than block size

The current behavior of raising an assertion causes some small files to be unwritable.
For example, with io.TextIOWrapper used by dask.bytes, a close() call internally first calls a flush(). And if the buffer was less than the block size, the exception would be raised and the file couldn't be written.

Thank you for getting to this so quickly!
Looks good.
Would you please update the docstring for flush(), saying that calling it when the buffer is smaller than the blocksize is a no-op.

Updated!

"It is unsafe to call this function repeatedly." is still in there :|  Sorry.

I mean, could you please remove that phrase, since it is no longer true.

Excellent, thank you!


Update Project.toml

Codecov Report

Merging #457 (37f19f9) into main (1770a20) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   86.98%   86.98%
=======================================
  Files          44       44
  Lines        1698     1698
=======================================
  Hits         1477     1477
  Misses        221      221

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Any idea of why docs are failing?


Fixed #31925 -- Fixed typo in docs/releases/3.0.txt.

Fixed #31925 -- Replaced 'FILE_UPLOAD_PERMISSION' to 'FILE_UPLOAD_PERMISSIONS'

@kc611 Thanks :+1: Welcome aboard :boat:


Fix wheel.js for horizontal scroll

Fix wheel.js for horizontal scroll, when wheelDeltaX more then wheelDeltaY. In this case don't change wheelDeltaX.
This bug on MacBook Pro, when use tachpad & horizontal scroll.

This fix for horizontal scroll, when use scroll 2 fingers on tachpad of MacBook.


isConnected

This will check if there is a SSH connection and will return true if there is and false if there is not

Thank you!


Changed sourcenode to opposingnode

A bug, which made king of the hill not work.
Refer more to this:
https://github.com/efroemling/ballistica/commit/5c601a36df07d5b9dee6ce6bb843d672561eaae9

fixed in sync with master


RFC process

This PR adds an Request for Comments (RFC) process and template based upon that in use by GOV.UK, that is adapted for use by the Cloud Foundry community.
Please have a read through and raise any thoughts, concerns or issues.

#173 mentions WG specific RFCs

Provide GitHub Project per Working Group for large technical proposals/new feature RFCs).

I understood this RFC process for common processes across WGs and crosscutting technical proposals. This should be clarified/mentioned in my opinion and maybe also add a link where to find the WG specific proposals.

#173 mentions WG specific RFCs

Provide GitHub Project per Working Group for large technical proposals/new feature RFCs).

I understood this RFC process for common processes across WGs and crosscutting technical proposals. This should be clarified/mentioned in my opinion and maybe also add a link where to find the WG specific proposals.

I'm a little torn on this, should we have all the RFC's in this repo, possibly under a folder per WG structure to give one central place to make discovery and reuse easier? Or should we go with each WG having a separate set of RFCs, which may fit easier into their workflows and create more focussed discussion on the PRs?

#173 mentions WG specific RFCs

Provide GitHub Project per Working Group for large technical proposals/new feature RFCs).

I understood this RFC process for common processes across WGs and crosscutting technical proposals. This should be clarified/mentioned in my opinion and maybe also add a link where to find the WG specific proposals.

I'm a little torn on this, should we have all the RFC's in this repo, possibly under a folder per WG structure to give one central place to make discovery and reuse easier? Or should we go with each WG having a separate set of RFCs, which may fit easier into their workflows and create more focussed discussion on the PRs?

We definitely need to leave room for working groups like Paketo to opt-out of centrally maintained RFCs.
Other than that, we could use labels or folders or both and have focussed discussions independent from where those RFCs are located.
Having said that, I have no strong opinion on RFC placement.

#173 mentions WG specific RFCs

Provide GitHub Project per Working Group for large technical proposals/new feature RFCs).

I understood this RFC process for common processes across WGs and crosscutting technical proposals. This should be clarified/mentioned in my opinion and maybe also add a link where to find the WG specific proposals.

I'm a little torn on this, should we have all the RFC's in this repo, possibly under a folder per WG structure to give one central place to make discovery and reuse easier? Or should we go with each WG having a separate set of RFCs, which may fit easier into their workflows and create more focussed discussion on the PRs?

We definitely need to leave room for working groups like Paketo to opt-out of centrally maintained RFCs. Other than that, we could use labels or folders or both and have focussed discussions independent from where those RFCs are located.
Having said that, I have no strong opinion on RFC placement.

How about a folder with a link to where the RFCs could be found if they are not in this repo?

@stephanme @loewenstein @dsboulder @emalm I've made some changes as agreed in today's meeting. I'll open it for your review.

All ready for a re review @loewenstein @stephanme @dsboulder @emalm

Merged: open for a week with approval from a quorum of the TOC and with no commentary raised to resolve.


Generate as property with initialization

I think the generated types should be made properties.
For two reasons:

property:
I use inheritance for my views. In the case of properties - I could mark the base class as abstract or use interfaces.

Initialization:
With each call, the search for the element is repeated. I understand that Avalonia is fast in implementation, but even if the difference is in milliseconds, why do we need this delay if we can avoid it.

   internal Grid GridConnector { get; }
   internal TextBox TextBoxConnector { get;}
   internal Ellipse EllipseConnector { get; }

   public Connector()
   {
       GridConnector = this.FindControl<Grid>("GridConnector");
       TextBoxConnector = this.FindControl<TextBox>("TextBoxConnector");
       EllipseConnector = this.FindControl<Ellipse>("EllipseConnector");
   }

We can totally make the source generator behavior configurable, and allow switching the desired behavior based on an MSBuild property (the approach was introduced in https://github.com/AvaloniaUI/Avalonia.NameGenerator/pull/22!) So in the ISourceGenerator.Execute method we can obtain the option value via:
var generateInitializeComponentCalls = context
    .GetMSBuildProperty("AvaloniaNameGeneratorBehavior", "")
    .Equals("InitializeComponent", StringComparison.OrdinalIgnoreCase);

And enable a new ICodeGenerator implementation named e.g. InitializeComponentCodeGenerator (see https://github.com/AvaloniaUI/Avalonia.NameGenerator/blob/main/src/Avalonia.NameGenerator/Generator/FindControlCodeGenerator.cs for a reference implementation)

Do NOT generate constructors. Generate void InitializeComponent() instead

Yeah based on the conversation with @RomanSoloweow we are planning to try out the following:
public void InitializeComponent(bool loadXaml = true)
{
    if (loadXaml)
    {
        AvaloniaXamlLoader.Load(this);
    }

    GridConnector = this.FindControl<Grid>("GridConnector");
    TextBoxConnector = this.FindControl<TextBox>("TextBoxConnector");
    EllipseConnector = this.FindControl<Ellipse>("EllipseConnector");
}

If this approach works, we'll get an InitializeComponent API which is similar to WPF, WinForms, UWP etc.

This is now shipped as 0.3.1-preview to NuGet.


Withdrawal to Ethereum fails

I am trying to withdraw my LRC from Loopring to my Ethereum account but the transaction fails silently. It is not submitted to the chain.

You can use Metamask to retry the tx or speed up the tx. You can also request another withdrawal. Let me know how it goes.

Works now


How do I copy this official Python API to edit my prompt?

curl https://api.openai.com/v1/edits \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $OPENAI_API_KEY" \
  -d '{
    "model": "text-davinci-edit-001",
    "input": "What day of the wek is it?",
    "instruction": "Fix the spelling mistakes"
  }'

I tried
final String instruction_en =
    "Correct all the spelling and grammar errors and explain the errors";

class ChatApi {
  static final openAI = OpenAI.instance.build(
      token: token,
      baseOption: HttpSetup(receiveTimeout: const Duration(seconds: 5)),
      isLog: true);

  ChatApi() {
    openAI.setToken(token);
  }

  Future<String> editPrompt(ChatMessage chatMessage) async {
    final response = await openAI.editor.prompt(EditRequest(
        model: EditModel.textEditModel,
        input: chatMessage.content,
        instruction: instruction_en));

    print("response: $response");
    return response.choices.last.text;
  }
}

and my result was gibberish for my prompt
" I go skool and stady engrish" although VSCode ChatGPT Genie would return a good response and so does the online chatbot at Chatgpt.org/chat.

Also the Python API designates the davinci model for this task but what model is used on chatgpt.org/chat and VSCode chatgpt genie?
Then I can get the response I want as I illustrate in this Reddit post:  https://www.reddit.com/r/ChatGPT/comments/13abui1/what_is_happening_under_the_hood_at/?utm_source=share&utm_medium=web2x&context=3

Also the Python API designates the davinci model for this task but what model is used on chatgpt.org/chat and VSCode chatgpt genie?
Then I can get the response I want as I illustrate in this Reddit post:  https://www.reddit.com/r/ChatGPT/comments/13abui1/what_is_happening_under_the_hood_at/?utm_source=share&utm_medium=web2x&context=3


Fix DeepSpeed checkpointing

This turned out to be a nasty race condition where rank 0 was able to release its temp dir, where various rank-agnostic checkpoint files were stored, before other ranks had finished using it. The fix is to add another dist.barrier().
I was able to reproduce this locally, which made testing much easier. I wrapped test_checkpoint in a dummy fixture that just ran the whole test hundreds of time (commenting out the resnet test, which was slow), which was able to reliably produce plenty of failures. After this fix, I've seen no failures.

Reconfirmed by running with a pytest.fixture(foo, range(25)) around test_checkpoint (without Resnet) - got no failures.


Migrate redis to public

[ ] Migrate GoldenEye redis to public TIM org repo -> https://github.com/terraform-ibm-modules/terraform-ibm-icd-redis

[ ] Ensure after first public version is released, we add the repo to hashicorp

[ ] Also ensure the repo is added to the continuous test pipeline

https://github.com/terraform-ibm-modules/terraform-ibm-icd-redis/pull/188


Fix adding and removing public IPs to VM

Public IP wasn't getting removed from BGPConfig when deleting a VM. Also support adding/removing a public IP to a VM after it is already created. Previously it was only working when public IP was set on VM creation

Codecov Report
Patch and project coverage have no change.

Comparison is base (273ddf1) 0.00% compared to head (e885b32) 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #75   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files           1       1
  Lines         639     639
======================================
  Misses        639     639

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


hash route change can't emit Page.lifecycleEvent event in SPA

Steps to reproduce
Tell us about your environment:

Puppeteer version: 0.13.0-alpha
Platform / OS version: mac os
URLs (if applicable):

What steps will reproduce the problem?
Well, In the source code of the waitForNavigation method. When the client send Page.navigateToHistoryEntry event, the browser will go back or forward, and the browser will emit the event of Page.lifecycleEvent.
However, In SPAs.I jump the page through hash change as the router.But the browser can't emit Page.lifecycleEvent.
So in the method of waitForNavigation:
 async waitForNavigation(entry) {
    this._eventListeners = [];

    const navigationPromises = [];
    if (this._timeout) {
      const watchdog = new Promise(fulfill => this._maximumTimer = setTimeout(fulfill, this._timeout))
          .then(() => 'Navigation Timeout Exceeded: ' + this._timeout + 'ms exceeded');
      navigationPromises.push(watchdog);
    }

    this._eventListeners.push(helper.addEventListener(this._client, 'Page.lifecycleEvent', this._onLifecycleEvent.bind(this)));

    //  This promise will be never resolved. So in the promise.race, the watchdog will resolve before this promise

    const pendingEventsFired = new Promise(fulfill => this._pendingEventsCallback = fulfill);
    navigationPromises.push(pendingEventsFired);

    const error = await Promise.race(navigationPromises);
    this._cleanup();
    return error ? new Error(error) : null;
  }

  /**
   * @param {!{frameId: string, name: string}} event
   */
  _onLifecycleEvent(event) {
    if (event.frameId !== this._frameId)
      return;
    const pptrName = protocolLifecycleToPuppeteer[event.name];
    if (!pptrName)
      return;
    this._pendingEvents.delete(pptrName);
    if (this._pendingEvents.size === 0)
      this._pendingEventsCallback();
  }

What is the expected result?
Page.lifecycleEvent event will emit in the SPA when the hash route hash changed.
What happens instead?
Page.lifecycleEvent never emit in the SPA when the hash route hash changed.

Well, I haven't found some event about hash change in the devtools-protocol page. Or is there any idea to solve the situation above?

Hi @CommanderXL,
Lifecycle events are sent for the document lifecycle; anchor navigation doesn't affect the document per se. Protocol doesn't expose anything related to the anchor navigation for now.
There's #257 to track progress of anchor navigations. Please, upvote!


question zuul RPS optimize

Zuul's RPS are small, not as big as the RPS for a single application. I've optimized a lot of parameters, but RPS is always around 170, and the RPS for a single application is around 2000. How do I optimize it

As I said for the same issue you opened for the Spring Cloud Gateway, please provide a way to replicate your findings.

As I said for the same issue you opened for the Spring Cloud Gateway, please provide a way to replicate your findings.

No matter how I adjust parameters.

Again please provide a sample.

take this fwiw, in my experience i cannot get things to scale with the default client (apache); i opted for okhttp and wrote my notes here

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


External metric not working for Eventhubs

Describe the bug
I've setup the metric adapter successfully and have established external metrics for services such as service bus, application gateway. But however When I tried to setup one for eventhub for the metric "IncomingMessages"  I was displayed with an error "Error from server (ServiceUnavailable): the server is currently unable to handle the request"
Below is my external metric YAML.
apiVersion: azure.com/v1alpha2
kind: ExternalMetric
metadata:
  name: myextmetric
  namespace: mynamespace
spec:
  type: azuremonitor
  azure:
    resourceGroup: myrg
    resourceName: evhubnamespacename
    resourceProviderNamespace: Microsoft.EventHub
    resourceType: namespaces
  metric:
    metricName: IncomingMessages
    aggregation: Total
    filter: EntityName eq 'customname'

related to #84

related to #84

How on earth is this related to #84 ?? Dude read my description, I've setup external metrics for other services and they are working fine. Now in the same cluster using the same adapter I'm unable to implement using event hubs. As per your suggestion if launching in different namespace was the problem nothing should have worked for me.

The error reported above "Error from server (ServiceUnavailable): the server is currently unable to handle the request" was the exact same error message as #84 which was resolved by making sure everything was properly namespaced.
Happy to help resolve if it is not related.  Please be mindful of our contributing guidelines and code of conduct.
Could you provide the logs of the metric adapter (specifically after a request for the eventhubs metric was queried) and the following info:
Kubernetes version (kubectl version):

[ ] Running on AKS

Logs (kubectl logs <metric adapter pod id>)
Additional context
kubectl describe hpa
Adapter version:

The error reported above "Error from server (ServiceUnavailable): the server is currently unable to handle the request" was the exact same error message as #84 which was resolved by making sure everything was properly namespaced.
Happy to help resolve if it is not related. Please be mindful of our contributing guidelines and code of conduct.
Could you provide the logs of the metric adapter (specifically after a request for the eventhubs metric was queried) and the following info:
Kubernetes version (kubectl version):

[ ]  Running on AKS

Logs (kubectl logs <metric adapter pod id>)
Additional context
kubectl describe hpa
Adapter version:

I've corrected my last reply according to the code of conduct. Sorry for that. Below are the details you asked for.
Adapter Version: 0.5.0
Kubernetes Version: 1.14.8
Yes, The cluster is running on AKS
Logs from metric-adapter Pod:

I0303 06:05:07.749429       1 controller.go:149] adding item to queue for 'mynamespace/extmetric03' with kind 'ExternalMetric'
I0303 06:05:07.754483       1 handler.go:82] processing item 'extmetric02' in namespace 'mynamespace'
I0303 06:05:07.754607       1 handler.go:111] adding to cache item 'extmetric02' in namespace 'mynamespace'
I0303 06:05:07.754625       1 controller.go:134] succesfully proccessed item '{mynamespace/extmetric02 ExternalMetric}'
I0303 06:05:07.754634       1 controller.go:91] processing next item
I0303 06:05:07.754640       1 controller.go:98] processing item
I0303 06:05:07.754579       1 handler.go:82] processing item 'extmetric01-eventhub' in namespace 'mynamespace'
I0303 06:05:07.754729       1 handler.go:111] adding to cache item 'extmetric01-eventhub' in namespace 'mynamespace'
I0303 06:05:07.754737       1 controller.go:134] succesfully proccessed item '{mynamespace/extmetric01-eventhub ExternalMetric}'

In the logs, the external metric "extmetric01-eventhub" is the one using event-hubs. You can safely ignore others as they use other Azure services and they are working fine too.
When I enter the command kubectl get hpa I'm getting the same error "Error from server (ServiceUnavailable): the server is currently unable to handle the request"

So it looks like the HPA is not able to find the metric adapter. It is interesting that it is working for the other metrics in the cluster.
A few thoughts:

Is this HPA and External metric in a specific namespace?  Is extmetric02 working as expected? it looks like it is in the same namespace.
Is it possible there is RBAC or networking policy is blocking access to the api server?
Can you share the HPA definition that is pointing at the external metric for event hub?

Can you hit the metric adapter directly using the following command:
kubectl  get --raw "/apis/external.metrics.k8s.io/v1beta1/namespaces/mynamespace/extmetric01-eventhub"

Another thing to check is that the metric adapter is registered:
kubectl describe apiservices v1beta1.external.metrics.k8s.io

I was able to track down the issue.  It appears that IncomingMessages doesn't return any values through the Metric API at the Eventhub level which is where you are filtering with filter: EntityName eq 'customname'.  I am looking into why that metric is not being reported at the EventHub level.  It is reported at the Namespace level.

The reason you are getting the Error from server (ServiceUnavailable): the server is currently unable to handle the request message is because the code for the Metric API checks for null but not length so end up with the following exception:
    1 monitor_client.go:50] resource uri: /subscriptions/b9d9436a-0c07-4fe8-b779-2c1030bd7997/resourceGroups/sb-external-example/providers/Microsoft.EventHub/namespaces/samplejjs
E0310 20:36:05.708112       1 runtime.go:71] Observed a panic: runtime error: index out of range
goroutine 62133 [running]:
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters.(*timeoutHandler).ServeHTTP.func1.1(0xc0004db560)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters/timeout.go:106 +0xda
panic(0x1701480, 0x2bdaa40)
        /usr/local/go/src/runtime/panic.go:522 +0x1b5
github.com/Azure/azure-k8s-metrics-adapter/pkg/azure/externalmetrics.extractValue(0xc0004f7f30, 0x10, 0xc000580bd0, 0x24, 0xc0004f7f40, 0xc, 0xc0004f7f13, 0x9, 0xc000667900, 0x12, ...)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/pkg/azure/externalmetrics/monitor_client.go:81 +0xd56
github.com/Azure/azure-k8s-metrics-adapter/pkg/azure/externalmetrics.(*monitorClient).GetAzureMetric(0xc000530460, 0xc0004f7f30, 0x10, 0xc000580bd0, 0x24, 0xc0004f7f40, 0xc, 0xc0004f7f13, 0x9, 0xc000667900, ...)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/pkg/azure/externalmetrics/monitor_client.go:60 +0x4a0
github.com/Azure/azure-k8s-metrics-adapter/pkg/provider.(*AzureProvider).GetExternalMetric(0xc00052e600, 0xc0000d6491, 0x7, 0x1c15360, 0xc000530320, 0xc0000d6499, 0xf, 0x3860f5559f5, 0xc00cfdb8d9, 0xcfdb8d900000000)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/pkg/provider/provider_external.go:41 +0x4f1
github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/kubernetes-incubator/custom-metrics-apiserver/pkg/registry/external_metrics.(*REST).List(0xc000593ab0, 0x1c04140, 0xc0001aac30, 0xc00037b580, 0x1918386, 0x2, 0x1bd9340, 0xc00037b580)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/kubernetes-incubator/custom-metrics-apiserver/pkg/registry/external_metrics/reststorage.go:79 +0x209
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/handlers.ListResource.func1(0x1bf68c0, 0xc00000e368, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/handlers/get.go:268 +0xc3e
github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/kubernetes-incubator/custom-metrics-apiserver/pkg/apiserver/installer.restfulListResource.func1(0xc0001aab40, 0xc0004fac60)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/kubernetes-incubator/custom-metrics-apiserver/pkg/apiserver/installer/installer.go:288 +0x8f
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/metrics.InstrumentRouteFunc.func1(0xc0001aab40, 0xc0004fac60)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go:272 +0x254
github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/emicklei/go-restful.(*Container).dispatch(0xc000320480, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/emicklei/go-restful/container.go:277 +0x985
github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/emicklei/go-restful.(*Container).Dispatch(...)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/github.com/emicklei/go-restful/container.go:199
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server.director.ServeHTTP(0x192efce, 0x16, 0xc000320480, 0xc000299880, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/handler.go:146 +0x4e4
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithAuthorization.func1(0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters/authorization.go:64 +0x4fa
net/http.HandlerFunc.ServeHTTP(0xc00007b2c0, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /usr/local/go/src/net/http/server.go:1995 +0x44
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters.WithMaxInFlightLimit.func1(0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters/maxinflight.go:160 +0x5c7
net/http.HandlerFunc.ServeHTTP(0xc0003b07e0, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /usr/local/go/src/net/http/server.go:1995 +0x44
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithImpersonation.func1(0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters/impersonation.go:50 +0x1ec3
net/http.HandlerFunc.ServeHTTP(0xc00007b300, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931400)
        /usr/local/go/src/net/http/server.go:1995 +0x44
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters.WithAuthentication.func1(0x7fbf4ccb44c8, 0xc00000e348, 0xc000931300)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/endpoints/filters/authentication.go:81 +0x527
net/http.HandlerFunc.ServeHTTP(0xc00037fb30, 0x7fbf4ccb44c8, 0xc00000e348, 0xc000931300)
        /usr/local/go/src/net/http/server.go:1995 +0x44
github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters.(*timeoutHandler).ServeHTTP.func1(0xc0004db560, 0xc000215a40, 0x1c04480, 0xc00000e348, 0xc000931300)
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters/timeout.go:111 +0xb3
created by github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters.(*timeoutHandler).ServeHTTP
        /go/src/github.com/Azure/azure-k8s-metrics-adapter/vendor/k8s.io/apiserver/pkg/server/filters/timeout.go:98 +0x1b1

At a more meta level, I am not sure you would want to scale on just the number of messages incoming.  I would think you would either want scale bases on the lag of the messages being processed or number of unprocessed messages.  It doesn't look like either of those are captured via the Azure Metrics api.  KEDA does have support for all the metrics you are currenlty scaling on, including supporting the number of unprocessed messages in eventhub.

Following is the output when I enter the command
kubectl  get --raw "/apis/external.metrics.k8s.io/v1beta1/namespaces/mynamespace/extmetric01-eventhub"
Output:

Error from server (ServiceUnavailable): the server is currently unable to handle the request

kubectl describe apiservices v1beta1.external.metrics.k8s.io
Output:

Name:         v1beta1.external.metrics.k8s.io
Namespace:
Labels:
Annotations:
API Version:  apiregistration.k8s.io/v1
Kind:         APIService
Metadata:
Creation Timestamp:  2020-02-13T13:10:23Z
Resource Version:    15729871
Self Link:           /apis/apiregistration.k8s.io/v1/apiservices/v1beta1.external.metrics.k8s.io
UID:                 31955796-4e62-11ea-ad67-1a32613f77cc
Spec:
Group:                     external.metrics.k8s.io
Group Priority Minimum:    100
Insecure Skip TLS Verify:  true
Service:
Name:            azureadapter-azure-k8s-metrics-adapter
Namespace:       custom-metrics
Version:           v1beta1
Version Priority:  100
Status:
Conditions:
Last Transition Time:  2020-03-03T23:50:49Z
Message:               all checks passed
Reason:                Passed
Status:                True
Type:                  Available
Events:

It seems when there are no messages for a period of time the result metric api for IncomingMessage returns an empty time series.  After putting load on it for awhile a while I was getting a correct result back but after letting it sit for awhile I am getting the error again.  The initial time for that value to come back was over several hours though.
Although I understand your current cost constraint, the delay in the initial metrics showing up initially causes me to hesitate that this metric would be correct metric to scale on.  As well, this metric might not work well as it will return the current Messages coming in which might peak then drop zero even though you haven't made a dent in the queue.  Using this metric, you could be in a situation where there are no/low number of  Incoming Messages which would cause the HPA to scale down but the processing pods and yet you could have a really high quantity in the event queue.
KEDA does support the Azure Monitor metrics so you could use it to scale on this same metric there if you wanted thought I think you will run into the same challenges with this particular metric.

@jsturtevant Yeah saw that KEDA has launched 1.3.0 recently with the Azure monitor scaler. Gonna give it a try now. Will update you how that goes, Also with respect to the metric behavior I think that is how it is supposed to behave as there are checkpoints and other stuff. Anyway I'll discuss with my team and update you.

@jsturtevant Just now tried out KEDA's azure monitor scaler and guess what, it is working perfectly for the same IncomingMessages metric. Guess metric adapter can look out on KEDA's code and see how they handle it and fix it here too.

@jsturtevant Just now saw the exact same error in KEDA too. They closed your issue but it seems like they haven't fixed it. I've requested to reopen your issue again there.


Cant Create MSSQL Database

Hi i try 3 days now to get it worked :(
first i try it under Plesk with Windows VPS
not worked now i get it half worked with standalone Apache 2.4
but if i try to create database with mssql i got error in Git Bash:
PHP Fatal error: wrong parameters for Exception([String $exception [, long $code [, Exception $previous = NULL]]]) in c:\Apache2.4\htdocs\pserverCMSFull\vendor\zendframework\Zend-servicemanager\src\ServiceManager.php on Line 945
i only change this
'orm_default' => [
// mssql db @ windows  => 'GameBackend\DBAL\Driver\PDOSqlsrv\Driver'
// mssql db @ linux  => 'GameBackend\DBAL\Driver\PDODblib\Driver',
'driverClass' =>'GameBackend\DBAL\Driver\PDOSqlsrv\Driver',
            'params' => [
                'host'     => '<IP_ADDRESS>',
                'port'     => '1443',
                'user'     => 'sa',
                'password' => 'xxxxxx',
                'dbname'   => 'pserverCMS',
            ],

@elschick
is your mssql running on port 1443?
default is 1433 check also if you added extension=php_pdo_sqlsrv_56_ts.dll in your php.ini and if its working

Hi i installed Now ODBC Driver 11 this error now fixed but now it dont connect to sql server odbc connect error
Mit freundlichen GrüßenH.Schick-------- Ursprüngliche Nachricht --------Von: Oliver<EMAIL_ADDRESS>Datum: 23.08.2016  14:15  (GMT+01:00) An: kokspflanze/pserverCMSFull<EMAIL_ADDRESS>Cc: elschick<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Betreff: Re: [kokspflanze/pserverCMSFull] Cant Create MSSQL Database (#4)
@elschick
is your mssql running on port 1443?
default is 1433 check also if you added extension=php_pdo_sqlsrv_56_ts.dll in your php.ini and if its working
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kokspflanze/pserverCMSFull","title":"kokspflanze/pserverCMSFull","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kokspflanze/pserverCMSFull"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kokspflanze in #4: @elschick \r\nis your mssql running on port 1443?\r\n\r\ndefault is 1433 check also if you added extension=php_pdo_sqlsrv_56_ts.dll in your php.ini and if its working"}],"action":{"name":"View Issue","url":"https://github.com/kokspflanze/pserverCMSFull/issues/4#issuecomment-241712062"}}}

there is a gitter chat =)
https://gitter.im/kokspflanze/PServerCMS?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge


Provide size_2d argument to extract_compute

For global style computes that return an array, this keyword allows you to pre-specify the size of the array and skip the extra extract_compute calls to get SIZE_ROWS and SIZE_COLS.
The context  for this is that I've been developing an interface to the POD potential in LAMMPS (see this PR ), which involves extracting from the pod/global compute. This is a very expensive compute, and the current version of extract_compute repeats it two additional times to get the row and column size, which makes things much slower on my end. I know the exact size of this array in advance, so having this keyword argument allows me to greatly increase performance.
Obviously, this is a very unsafe option, and I've tried to indicate this in the documentation.

Do you know what exactly causes the slowdown? From how I've understood the documentation, calling lammps_extract_compute multiple times during the same timestep should not cause the compute to run again. However, if this does trigger the compute multiple times providing the size manually does seem like a good idea, but we should be consinstent here and also allow the user to do this for TYPE_VECTOR as well.
Another approach we could take is to directly call 'lammps_extract_compute' instead of our wrapper to determine the size of the array, which would save us some time spend on repeated input validation and would also allow us to skip wrapping the pointers in a vector first:
ndata = (style == STYLE_ATOM) ?
        extract_setting(lmp, "nlocal") :
        unsafe_load(reinterpret(Ptr{Int32}, API.lammps_extract_compute(lmp, name, style, API.LMP_SIZE_ROWS)))

count = unsafe_load(reinterpret(Ptr{Int32}, API.lammps_extract_compute(lmp, name, style, API.LMP_SIZE_COLS)))

with the same idea for TYPE_VECTOR as well

This is a very expensive compute, and the current version of extract_compute repeats it two additional times to get the row and column size, which makes things much slower on my end.

That would be a bug  on the LAMMPS side or the potential. The code we are calling is
https://github.com/lammps/lammps/blob/43fbdc2d9385715ac01f9218defc5beca0afc853/src/library.cpp#L2364-L2365
It looks like it is the potential responsibility to set the "computed this timestep flag" https://github.com/lammps/lammps/blob/43fbdc2d9385715ac01f9218defc5beca0afc853/src/ML-PACE/compute_pace.cpp#L165
Which POD does not do https://github.com/lammps/lammps/blob/43fbdc2d9385715ac01f9218defc5beca0afc853/src/ML-POD/compute_pod_global.cpp#L110

Ah I see, yea that does seem to be a bug in ML-POD, I will try to fix it there. I'll close this out since it doesn't seem worthwhile to provide such an unsafe option if it's not necessary.


allow asynchronous blink/flashes

Hey, it would be great if you could add a second input field for the time.
One field is “On” and one is “Off” in ms, to provide asynchronous blink modes, e.g. flashes.
Maybe there is an option to be able to specify double-flashes.
Thanks.

Ok, I added this in v1.1.0 of the module


feat(board): create PBoard component

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[ ] Not that difficult

Type of Change

[x] New feature
[ ] Bug fixes
[ ] Feature improvement

[ ] These changes require a usage change

[ ] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[x] Updated Storybook documents
[ ] Tested with console
Currently, npm link does not work between console and mirinae
Please check on console with released mirinae

Description
Create PBoard component.

Created using PBoardItem.
Update Docs.
pageLimit props will be updated after console feature work.

pageLimit props는 콘솔 작업을 진행하면서 사용성을 고려해 작업할 예정입니다.

:tada: This PR is included in version 1.1.0-beta.454 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix "Tried to use NavigationService before appContainerRef was set".

See discussion.
@gnprice, feel free to make any tweaks as you see fit (or ask me to, and I will). Also, let me know if you'd like to try a different approach, of course. 🙂
Fixes: #4453

@gnprice, I've just pushed a new revision, following our conversations yesterday (here and here). Thanks for your help!
I'm not sure if the reversion to connect for MainTabsScreen is what we'll land on, but I've mentioned that I haven't quite gotten it to work with ReactReduxContext yet.
In case we do want to keep the reversion to connect, would you mind distilling what you've learned about the reason for doing so, into a code comment and the commit message? I think this would help us land the fix more quickly.

Thanks for the review! Revision pushed.

Merged, thanks!
I made one fix, in an intermediate commit in some code a later commit deletes anyway:
 export const initialFetchComplete = () => async (dispatch: Dispatch, getState: GetState) => {
-  if (getNavigationRoutes()[0] === 'loading') {
+  /* flowlint-next-line unnecessary-optional-chain:off */ // [0] may not exist
+  if (getNavigationRoutes()[0]?.name === 'loading') {

Thanks for that catch! 🙂


Response returns 'null' for 'finish_reason'

What is the issue?
I'm using the OpenAI .Net library to connect to Ollama, using the default llama3.2 model. I get an "Unknown ChatFinishReason value." error from the library. You can see in below code from ChatFinishReasonExtensions (from OpenAI lib) that the value returned by Ollama is null.

The finish reason should apparently never be null. Note that this only happens for requests that time out. In normal use, the value 'stop' is returned which is parsed correctly.
OS
Windows
GPU
Intel
CPU
Intel
Ollama version
ollama version is 0.3.14

Why is  ToChatFinishReason being called with an incomplete completion?

No idea. It is code of the OpenAI library.

Hey @debruyckere, thanks for bringing this up. Got a couple questions:

Is this case happening in a longer running tasks, is it flakey, or is it happening in every case?
I'd recommend bumping Ollama to one of our newer releases - it may or may not help but will definitely make it easier to decrease the surface area to help :)

It happens for tasks that time out (see ticket description)
Same behavior with latest 0.4.1

If a request times out, ollama cannot supply a finish reason.  The response is incomplete.  The library should not call ToChatFinishReason with an incomplete response.  It's a bug in the library.

Hi @debruyckere,
@rick-github is correct in this case - it's the library's responsibility to handle issues which occur on the server side - including timeouts.

If a request times out, ollama cannot supply a finish reason. The response is incomplete.
But it does, and that is the issue. Instead of just not providing a finish reason, it explicitly provides one, but with an invalid value 'null'.

How does ollama send "finish_reason":"null" when the TCP connection has been terminated because of timeout?

OK, this is not a timeout, it's the generation going off the rails and getting terminated because it exceeded the maximum token repeat limit: https://github.com/ollama/ollama/blob/a14f76491d694b2f5a0dec6473514b7f93beeea0/llm/server.go#L809
This is generally the result of a mismatch between the prompt and the response_format:
$ curl -s localhost:11434/v1/chat/completions -d '{"model":"llama3.2:3b","messages":[{"role":"user","content":"why is the sky blue?"}],"stream":false,"response_format":{"type":"json_object"},"seed":0,"temperature":0}' | jq
{
  "id": "chatcmpl-951",
  "object": "chat.completion",
  "created":<PHONE_NUMBER>,
  "model": "llama3.2:3b",
  "system_fingerprint": "fp_ollama",
  "choices": [
    {
      "index": 0,
      "message": {
        "role": "assistant",
        "content": "{}\n \n  \n\n\n\n\n\n \n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n \n\n\n\n\n\n"
      },
      "finish_reason": null
    }
  ],
  "usage": {
    "prompt_tokens": 0,
    "completion_tokens": 0,
    "total_tokens": 0
  }
}

The code returns ctx.Err() which results in incomplete generation being returned.  It should probably throw an actual error since the partial result is likely to be discarded anyway.
diff --git a/llm/server.go b/llm/server.go
index 96815826..4c0bb049 100644
--- a/llm/server.go
+++ b/llm/server.go
@@ -809,7 +809,7 @@ func (s *llmServer) Completion(ctx context.Context, req CompletionRequest, fn fu
                        // 30 picked as an arbitrary max token repeat limit, modify as needed
                        if tokenRepeat > 30 {
                                slog.Debug("prediction aborted, token repeat limit reached")
-                               return ctx.Err()
+                               return fmt.Errorf("prediction aborted, token repeat limit reached")
                        }

                        if c.Content != "" {

$ curl -D /dev/stderr -s localhost:11434/v1/chat/completions -d '{"model":"llama3.2:3b","messages":[{"role":"user","content":"why is the sky blue?"}],"stream":false,"response_format":{"type":"json_object"},"seed":0,"temperature":0}' | jq
HTTP/1.1 500 Internal Server Error
Content-Type: application/json
Date: Mon, 18 Nov 2024 16:16:58 GMT
Content-Length: 115

{
  "error": {
    "message": "prediction aborted, token repeat limit reached",
    "type": "api_error",
    "param": null,
    "code": null
  }
}

The OpenAI API recognizes 500s as an internal error and the python library handles it, so I think this is an appropriate way to deal with the failure.
import openai
from openai import OpenAI
client = OpenAI(base_url="http://localhost:11434/v1",api_key="ollama")

response=""
try:
  #Make your OpenAI API request here
  response = client.chat.completions.create(
    messages=[{"role":"user","content":"why is the sky blue?"}],
    model="llama3.2:3b",
    response_format={"type":"json_object"},
    seed=0,
    temperature=0,
    stream=False
  )
except openai.InternalServerError as e:
  print(f"OpenAI API returned an Internal Server Error: {e}")
  pass
except Exception as e:
  print(f"OpenAI API returned an API Error: {e}")
  pass
print(response)

$ python 7547.py
OpenAI API returned an Internal Server Error: Error code: 500 - {'error': {'message': 'prediction aborted, token repeat limit reached', 'type': 'api_error', 'param': None, 'code': None}}

Hey @rick-github thanks for keeping up-to-date with this issue! Will spin out some better error messaging for this.


Simulation with only irrelevant priors uses more, random, prior data than given priors with prior_idx

Describe the bug
When making use of the simulation mode and the prior_idx only has irrelevant papers, the model uses more - random - prior information untill a relevant paper is found instead of only the priors given with prior_idx. It makes sense that the model needs relevant papers, but this makes that the model is different than what you think you simulated (if you do not look at the state file). A solution might be to add a warning that you did not include a relevant paper as prior.
To Reproduce
Steps to reproduce the problem:

Run a simulation with only irrelevant papers as priors;
Look in the state file at the training data used for the first itteration and the labels for result 0;
Repeat the process with a simulation that includes a relevant paper to see the difference.

Version information

OS: Windows
ASReview version .14

Can you open a PR to improve the documentation? Just to be sure, you get 1 random included record, isn't it? This item is returned in the command line, isn't it? I'm not sure whether a warning makes sense. Can you suggest what this should look like?

Laura and I were talking about this yesterday. Currently, if you don't have any relevant priors in simulation, then it just keeps on trying random papers until it hits on a relevant paper. For example, if you run a simulation on the ACE dataset with --prior_idx 0 1, then it ends up with these indices in the priors:
[   0    1 1357 1135 1289   50 2325  442 1115  254 2504  326 1661 2070
1947 1792 1556 2204 1657 1827 1378 1873 2265   35 2505<PHONE_NUMBER>
932 2162]

I compared what you see in the command line with what you see happening in the state file.
When a user (accidently) gives only irrelevant records as prior knowledge – which can happen when the user e.g. forgets to correct for the indexing differences – only the by the user chosen records are returned in the command line, see the jobs file for an example.
However, when you look into the state file, it is seen that records are chosen (randomly I think) until a relevant record pops up, see the R file for an example.
I believe this to be a problem, because you have e.g. 40 in stead of 2 priors without you knowing about it.
I think that you ideally want:

that you know which records are actually used as prior knowledge;
that it is not a random search until a relevant paper is found, but that only one extra paper is used as prior record; a relevant record.

To recreate this with the attached scripts:

change the path in the jobs file to the folder containing the data;
run the jobs file;
install the rhdf5 package in R;
change the path in the R file to the folder containing the data;
run the R script.
Scripts to recreate issue 500.zip

@PeterLombaers can we confirm this issue is resolved with the new state file?

When I try to run a simulation with only included or only excluded priors, I get
ValueError: Not both labels available Make sure there is an included and excluded record in the priors.
so this seems resolved to me.


Information close to elapsed time jumps when time changes

Go to /scanner/ and start a new scan
Look at Errors and Version

Expected: Titles to remain in place
Actual: Titles slightly move depending on the width of the time (00:00 and 01:11, for example)
@ststimac assigning to you, but if anyone wants to take it before you start feel free!

Making a note: This is probably due to flexbox.

And I may move the permalink to the next line if the links are going to have that many characters.


Clean unused reconnecting state

Task/Issue URL: https://app.asana.com/0/488551667048375/1206195889067599/f
Description
Remove the reconnecting state
Steps to test this PR
VPN smoke test

Current dependencies on/for this PR:

develop

PR #4023   👈

This stack of pull requests is managed by Graphite.


Bug in the Kareha image board when uploading pics

When uploading a text only post:

This is because the res directory was missing in /var/www/html/cgi-bin/


Uncaught Error: ENOENT: no such file or directory, lstat '~/OneDrive...

[Enter steps to reproduce:]
I am doing a project using node.js and express.
Then:

I created folder a folder called "public" inside the project directory;
I tried to drag a "CSS" folder inside this "public" folder;
Then, I received this error and the suggestion to create this issue.

Atom: 1.45.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat 'C:\Users\giova\OneDrive\Conhecimento\Cursos\Udemy_Fullstack HTML, CSS, Javascript, Node, React, MongoDB\Section21_EJS\todolist1\ MongoDB'
At fs.js:115

Error: ENOENT: no such file or directory, lstat 'C:\Users\giova\OneDrive\Conhecimento\Cursos\Udemy_Fullstack HTML, CSS, Javascript, Node, React, MongoDB\Section21_EJS\todolist1\ MongoDB'
    at Proxy.realpathSync (fs.js:1435:7)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:306:40)
    at TreeView.moveEntry (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:1005297)
    at TreeView.onDrop (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:1012226)
    at HTMLDivElement.<anonymous> (~/AppData/Local/atom/app-1.45.0/resources/app/static/<embedded>:14:985857)

Commands
     -5:03.0 emmet:insert-formatted-line-break-only (input.hidden-input)
     -5:03.0 editor:newline (input.hidden-input)
     -4:59.3.0 autocomplete-plus:confirm (input.hidden-input)
     -4:59.3.0 snippets:expand (atom-text-editor.editor.is-focused.autocomplete-active)
  6x -4:45.7.0 core:backspace (input.hidden-input)
     -4:36.7.0 intentions:highlight (input.hidden-input)
     -4:36.5.0 core:save (input.hidden-input)
  2x -4:32.6.0 tree-view:move (span.name.icon.icon-file-directory)
     -4:21.5.0 core:confirm (input.hidden-input)
     -0:45.1.0 tree-view:add-folder (ol.tree-view-root.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:42.9.0 core:move-left (input.hidden-input)
  5x -0:42.6.0 core:backspace (input.hidden-input)
     -0:39.8.0 core:delete (input.hidden-input)
     -0:39.6.0 core:confirm (input.hidden-input)

Non-Core Packages
atom-beautify 0.33.4
atom-html-preview 0.2.6
atom-ternjs 0.20.0
autoclose 0.0.2
busy-signal 2.0.1
csslint 1.2.0
emmet 2.4.3
hyperclick 0.1.5
intentions 1.1.5
jshint 1.8.6
language-ejs 0.4.0
linter 2.3.1
linter-eslint 8.5.5
linter-ui-default 1.8.1
pigments 0.40.2
Sublime-Style-Column-Selection 1.7.5

Hey @giovanimachado, thanks for the report!
Are you able to reproduce this in safe-mode?
I would also rename these folders to something basic without spaces or special characters and make sure they exist (Udemy_Fullstack HTML, CSS, Javascript, Node, React, MongoDB and  MongoDB)

Hi @lkashef, I tried the second suggestion and It worked:

I would also rename these folders to something basic without spaces or special characters and make sure they exist (Udemy_Fullstack HTML, CSS, Javascript, Node, React, MongoDB and  MongoDB)

This were the project folder:
C:\Users\giova\OneDrive\Conhecimento\Cursos\Udemy_Fullstack HTML, CSS, Javascript, Node, React, MongoDB\Section21_EJS\todolist1
And, I renamed to:
C:\Users\giova\OneDrive\Conhecimento\Cursos\Udemy_Fullstack_nodeJS\Section21_EJS\todolist1
Then I tried to drag the files and I don't receive the error message anymore.
Thank you.

You are most welcome @giovanimachado.


Weird Graphical Bug

Describe what happened:
When opening vscode in full screen mode on macOS there is this weird graphical bug that shows up. It looks like || essentially. It will disappear if not clicked on after a few seconds, I assume it has to do with the extension loading but it is distracting. Also if you click and drag on it, it can be opened as a window.
What was your system configuration?
Product and Version [VS/VSCode]: 1.43.0
OS Version[macOS/Windows]: macOS 10.15.3 (19D76)
Live Share Extension Version: v1.0.1615
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:
Open VScode in full screen mode with live share disabled
Enable live share

logs.zip

Hi Jordan (@nadrojisk)! thank you for reporting this issue and providing the GIF, very useful.  It is indeed weird ... we'll look into it.

@nadrojisk do you mind trying to reproduce with a different extension? also, what is the title of that window? thanks,

The title just seems to be "Window" as far as i can see. Also it happens with all my extensions disabled, some enabled, and all enabled. Which extensions are enabled does not seem to effect the little pop up from occurring on my side.

Jordan, thank you for the new details.  Sounds like a VS Code issue (not Live Share extension-specific).  Do you mind reporting it in the vscode repo? I suggest setting the title to something like "Ghost window when enabling vscode extension".
thank you again!
(@nadrojisk)

Asking for this to be opened again as vscode deemed this a liveshare issue.
https://github.com/microsoft/vscode/issues/92523

Sure, we'll take a second look and try to reproduce it. However, since you mentioned you saw this behavior with another extension, it will be very helpful to verify to ensure this issue is investigated by the right team.  thanks,

I believe the time it happened with another extensions was with liveshare enabled. With liveshare causing the weird ghost to pop up. I could not get it to occur without liveshare with further testing

Closing this as resolved, since we believe we've fixed this issue and we haven't heard it reported it in a while. Please re-open this if you're still encountering a problem here. Thanks!


Generalize GenerateMissingRecordFieldsFix to work on functions too.

Current behaviour
type R = { A: int; B: int }
let myVariable : R = {}

to
type R = { A: int; B: int }
let myVariable : R = { A = failwith "todo"
                       B = failwith "todo" }

Only works with variable bindings

Enhancement: work with function bindings too
e.g.
type R = { A: int; B: int }
let myFunction a b : R = {}

to
type R = { A: int; B: int }
let myFunction a b : R = { A = failwith "todo"
                           B = failwith "todo" }

Sorry for misunderstanding your comments first time round - I didn't appreciate how RecordExpr.GetFSharpSymbol() was related to everything before.
I'm going to do match, function and if statements now - up to you whether that's part of this PR or a new one.

@mcon Thank you, it's indeed much cleaner now!
I think it'd be good to get it merged and to work on the other construct in separate PRs. Should I merge it if you remove the draft mark and everything rest seems fine?

@mcon Thanks!


Change The Module Name?

Summary
What is your question?
Rename the module name, because:

Obviously "sockets" and "websockets" are different, i think "sockets" would be misleading for the end users
I think websockets is already taken should we move away from "sockets"
I think it would be good we iron this stuff out before v1 so it leads to less problems as sockets gets bigger (user base, or feature wise)

Suggestions:

Ghost (suggested by me), which would make it named after the infamous @saragee3 who built this bad boi of an app
Wocket (suggested by eric

We've decided on Wocket. Leaving issue open until all references to the name are changed

Closing! Thanks @ebebbington 👍

Woop woop!


Problem with libraries

Hi,
It seems I have an issue with YarnSpinner libraries, they work fine in the editor but don't seem to be included in the builds (both iOS and Macos).
More specifically, this is the error: "Dialogue.Run was called, but no program was loaded. Stopping.".
On Unity 2019.1.4f1, .NET 4.x equivalent.
Thanks.

Reloaded 0.9.11, seems to work nicely now.


Made initial version of BlinkLights task.

Modified CarState and Switch Headers to bring in line with the new Struct paradigms from ReadSwitches.

BlinkLights is implemented in PR #199. Closing this now, as it is part of the outdated architecture.


Feat - emit event when shipping method calculated and pass the live-rate object

instead of storing the live-rate object in the fulfillment option data, emit an event and pass it through.
let whoever is doing an implementation do whatever they want with that data...

New event emits when calculatePrice is done
shippo.calculated_shipping_method
{
  cart_id: "",
  rate: {...}   // shippo live-rate object
}


Bug fix/8313 & 8310 Fix

Fix for 8313 and 8310.

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1

See the complete overview on Codacy


Persisting data long term with expiry options

The Observable Store needs to have the ability to persist data after closing the browser tab, window or navigating away from the web application.
This would need to be configurable both at the global level as well as an individual service level. Possible configurations would include how to store the data (i.e. local storage, cookies), assign a time to live, and a mechanism for invalidating data based on the time to live.
This feature could be will be very beneficial when setting and getting data that you expect to rarely or never change.

Thanks for the suggestion. I've tossed that idea around in the past but decided against it since there are multiple ways to store state on the client-side (as you mention) and a dev can already do that on their own if they need it.
While it's not something I'm planning to add at this point since the overall goal is to keep the library super small with a minimal API, I'll add it to the list of future considerations for a potential add-on. Thanks again.


report-ready.Rmd minor bug

Good morning!
Again, excellent pipeline!
in final/project/report/report-ready.Rmd
first table Basic_sample_metrics (built on metrics/metrics.tsv),
columns Mapped_reads_pct, Duplicated_pct are displayed incorrectly
(1% instead of 99%) : in metrics.tsv they
are in the format 0.99 (for 99%) so there is no need to divide them by 100.
Solution: comment two lines:

Adjust some of the text information for formatting purposes
qc_table <- qc[, metrics]

qc_table$Mapped_reads_pct = as.numeric(gsub("%", "", qc_table$Mapped_reads_pct))
#qc_table$Mapped_reads_pct <- qc_table$Mapped_reads_pct / 100

qc_table$Duplicates_pct = as.numeric(gsub("%", "", qc_table$Duplicates_pct))
#qc_table$Duplicates_pct <- qc_table$Duplicates_pct / 100

Unfortunately I did not find where to fix this in the repo.
Best,
Sergey

Thanks a lot, feel free to do a PR to https://github.com/lpantano/bcbio.coverage/blob/master/bcbreport/qc.Rmd https://github.com/lpantano/bcbio.coverage/blob/master/bcbreport/qc.Rmd
If not I will apply the changes.
cheers

On Apr 26, 2016, at 11:28 AM, Sergey Naumenko<EMAIL_ADDRESS>wrote:
Good morning!
Again, excellent pipeline!
in final/project/report/report-ready.Rmd
first table Basic_sample_metrics (built on metrics/metrics.tsv),
columns Mapped_reads_pct, Duplicated_pct are displayed incorrectly
(1% instead of 99%) : in metrics.tsv they
are in the format 0.99 (for 99%) so there is no need to divide them by 100.
Solution: comment two lines:
Adjust some of the text information for formatting purposes
qc_table <- qc[, metrics]
qc_table$Mapped_reads_pct = as.numeric(gsub("%", "", qc_table$Mapped_reads_pct))
#qc_table$Mapped_reads_pct <- qc_table$Mapped_reads_pct / 100
qc_table$Duplicates_pct = as.numeric(gsub("%", "", qc_table$Duplicates_pct))
#qc_table$Duplicates_pct <- qc_table$Duplicates_pct / 100
Unfortunately I did not find where to fix this in the repo.
Best,
Sergey
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/1366

thanks again!


"Parser bug: Mismatched external parser" due to autoload path including unnecessary ./

Tested versions

Reproducible in 4.3.beta (16f98cd7079c2b22248ec358371f17bca355e42e)
Reproducible in 4.3.dev4 to 4.3.beta2
Not reproducible in 4.3.dev3 and earlier dev snapshots, or 4.2.2.stable

System information
Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7600M XT (RADV NAVI33) - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)
Issue description
Copying @Glorax's report from #92233, which was another bug with similar symptoms.
But this one happens straight in the editor.
The Cogito project template raises a bunch of parser errors in 4.3.dev4 and later.

resolve_class_member: Parser bug: Mismatched external parser.
<C++ Error>    Condition "!parser_ref->get_parser()->has_class(p_class)" is true.
<C++ Source>   modules/gdscript/gdscript_analyzer.cpp:909 @ resolve_class_member()

Steps to reproduce

Open Cogito project with zip linked below
After initial import, restart
See "Parser errors" on the main scene or when loading one of the demo scenes

Minimal reproduction project (MRP)
Not minimal, but triggers the error: Cogito-main.zip
Could be reduced further.

I bisected this to #87124, CC @rsubtil @godotengine/gdscript
I added some debug prints around the added simplify_path(), and indeed the reproduction project has some paths saved in scenes which are not "simple", and the mismatch seems to trigger this error.
script path before: res://addons/quick_audio/./Audio.gd
script path after: res://addons/quick_audio/Audio.gd
---
script path before: res://addons/quick_audio/Audio.gd
script path after: res://addons/quick_audio/Audio.gd
ERROR: Parser bug: Mismatched external parser.
   at: resolve_class_member (./modules/gdscript/gdscript_analyzer.cpp:909)
ERROR: Parser bug: Mismatched external parser.
   at: resolve_class_member (./modules/gdscript/gdscript_analyzer.cpp:909)
ERROR: Parser bug: Mismatched external parser.
   at: resolve_class_member (./modules/gdscript/gdscript_analyzer.cpp:909)

This seems to come from the autoload:
project.godot
25:Audio="*res://addons/quick_audio/./Audio.gd"

Removing the extra ./ from that line solves the issue in the linked project.
So that's a workaround for affected users, but the parser bug still needs to be addressed anyway.

On my iMac, whenever I press the command key while the script editor is open, it immediately adds two "Parser bug: Mismatched external parser." errors to the output log. This also triggers when using Command + Tab.

MRP: autoload-path-mrp.zip

It seems that it has been merged for 4.3-RC1 ?
If yes, i'm always having the problem. Cf screenshot.

Do you have autoloads with a non simplified path? If not, this would be a different bug, and we'd need a reproduction project to debug further.

Do you have autoloads with a non simplified path? If not, this would be a different bug, and we'd need a reproduction project to debug further.

what would qualify a "non simplified path" ?
I'm also having this in 4.3rc1
ERROR: Parser bug: Mismatched external parser.
   at: (modules/gdscript/gdscript_analyzer.cpp:909)
ERROR: Parser bug: Mismatched external parser.
   at: (modules/gdscript/gdscript_analyzer.cpp:909)

See https://github.com/godotengine/godot/issues/94098#issuecomment-2215409999
You can just look in project.godot how the oath to your autoloads look like.
But again, this bug was fixed, so most likely what you are both experiencing is an unrelated parser bug. It would be best that you each open an issue with a reproduction project.

And see https://github.com/godotengine/godot/issues/94244 for a still open know parser but with this error message.


Looks like DELETE method is unsupported

Hi Joe,
It appears that mock-s3 doesn't support DELETE method requests to delete objects. I use boto and it gives the error:
S3ResponseError: S3ResponseError: 501 Unsupported method ('DELETE')
Would you know how I could solve this? Thanks a lot!

I just committed a patch that adds that functionality, let me know if that works for you...


Pharo 10 errors

On the new 10th version of Pharo Mocketry fails while creating a new Mock stub or stub:
OrderedCollection(Object)>>errorSubscriptBounds:
OrderedCollection>>at:
SpNotebookPresenter>>selectPageIndex:
StObjectInspectorPresenter>>updatePages
StObjectInspectorPresenter>>refresh
StObjectInspectorPresenter>>initializePresenters
StObjectInspectorPresenter(SpPresenter)>>initializePrivateHooks
StObjectInspectorPresenter(SpPresenter)>>initialize
StObjectInspectorPresenter>>initialize
StObjectInspectorPresenter class(SpPresenter class)>>newApplication:owner:model:
StObjectInspectorPresenter class(StPresenter class)>>owner:on:
StInspector(SpPresenter)>>instantiate:on:
StInspector>>newInspectorFor:
[ :aModel | self newInspectorFor: aModel ] in StInspector>>initializePresenters in Block: [ :aModel | self newInspectorFor: aModel ]
SpMillerColumnPresenter>>newPresenterFor:
SpMillerColumnPresenter>>pushModel:
SpMillerColumnPresenter>>setRootModel:
StInspector>>initializePresenters
StInspector(SpPresenter)>>initializePrivateHooks
StInspector(SpPresenter)>>initialize
StInspector class(SpPresenter class)>>newApplication:model:
StInspector class(SpPresenter class)>>on:
StInspector class>>onObject:
StInspector class>>openOn:
SpCodeInspectItCommand>>inspectObject:
[ :result |
		self inspectObject: result ] in SpCodeInspectItCommand>>execute in Block: [ :result | ...
SpCodeInspectItCommand(SpCodeSelectionCommand)>>evaluate:andDo:
SpCodeInspectItCommand(SpCodeSelectionCommand)>>evaluateSelectionAndDo:
SpCodeInspectItCommand>>execute
SpCommand(CmCommandDecorator)>>execute

GHMetaMessages class(ProtoObject)>>primitiveFailed:
GHMetaMessages class(ProtoObject)>>primitiveFailed
GHMetaMessages class>>setClass:to:
ByteString(ProtoObject)>>injectGHMutation:
ByteString class(GHObjectMutation)>>mutate:
ByteString(Object)>>stub
UndefinedObject>>DoIt
[ receiver withArgs: (context ifNil: [ #() ] ifNotNil: [ {context} ]) executeMethod: self compileDoit] in OpalCompiler>>evaluate in Block: [ receiver withArgs: (context ifNil: [ #() ] ifNot...etc...
FullBlockClosure(BlockClosure)>>on:do:
OpalCompiler>>evaluate
[
		oldBindings := self interactionModel bindings copy.
		receiver := self interactionModel doItReceiver.
		result := receiver class compiler
			source: aString readStream;
			context: self interactionModel doItContext;
			receiver: self interactionModel doItReceiver;
			requestor: self interactionModel;
			environment: self environment;
			failBlock:  [ ^ compileErrorBlock value ];
			evaluate.
		oldBindings size = self interactionModel bindings size
			ifFalse: [ self withAdapterDo: [ :anAdapter | anAdapter refreshStyling ] ].
		result ] in SpCodePresenter>>evaluate:onCompileError:onError: in Block: [...
FullBlockClosure(BlockClosure)>>on:do:
SpCodePresenter>>evaluate:onCompileError:onError:
SpCodeInspectItCommand(SpCodeSelectionCommand)>>evaluate:andDo:
SpCodeInspectItCommand(SpCodeSelectionCommand)>>evaluateSelectionAndDo:
SpCodeInspectItCommand>>execute
SpCommand(CmCommandDecorator)>>execute
[ self decoratedCommand execute ] in SpToolCurrentApplicationCommand>>execute in Block: [ self decoratedCommand execute ]
[ activeProcess
			psValueAt: index
			put: anObject.
		aBlock value ] in SpToolCurrentApplication(DynamicVariable)>>value:during: in Block: [ activeProcess...
FullBlockClosure(BlockClosure)>>ensure:
SpToolCurrentApplication(DynamicVariable)>>value:during:
SpToolCurrentApplication class(DynamicVariable class)>>value:during:
SpToolCurrentApplicationCommand>>execute
[ self decoratedCommand execute ] in SpToolCurrentApplicationCommand>>execute in Block: [ self decoratedCommand execute ]
[ activeProcess
			psValueAt: index
			put: anObject.
		aBlock value ] in SpToolCurrentApplication(DynamicVariable)>>value:during: in Block: [ activeProcess...
FullBlockClosure(BlockClosure)>>ensure:
SpToolCurrentApplication(DynamicVariable)>>value:during:
SpToolCurrentApplication class(DynamicVariable class)>>value:during:
SpToolCurrentApplicationCommand>>execute
[
			aCmCommand canBeExecuted
				ifTrue: [ aCmCommand execute ] ] in SpKMCategoryBuilder>>visitCommand: in Block: [ ...

Running tests render four errors:

Fixed in v6.0.4

I fixed tests. But the issue with inspector integration on the level of Ghost.
GT was removed and it requires adaptation to new framework

Fixed in v7.0.0


manually teardown rtsp connection

System :
window7
anaconda 3.4
python 3.5
conda-forge av 0.4.0

Description :
I use av.open to access a stream and able to select the stream type and parsing to image. However, when I exit the program, I check with wireshark. pyav does not help to send RTSP 'TEARDOWN' request to the server. Server is then keep sending packets till timeout.

url = 'rtsp://url'
video = av.open(url, options)
for packet in video.demux(video.streams):
    for frame in packet.decode():
         if packet.stream.type == 'video':
                img = frame.to_nd_array( format='bgr24' )

While in C, libav can close the input properly by closing the context and free the buf. How should I do that in pyav?
       av_free_packet(&packet);
        av_init_packet(&packet);
    }
    av_free(pic);
    av_free(picrgb);
    av_free(picture_buf);
    av_free(picture_buf2);

    av_read_pause(context);
    avio_close(oc->pb);
    avformat_free_context(oc);

Thank you for maintaining the library!

I'm on the verge of a push to make sure everything is being closed properly, as I'm pretty sure there is a ~250B leak with every output container not being cleaned up.

Does a simple video.close() help?

Does a simple video.close() help?
As i cannot use pip install av successfully in Window anaconda. I am currently using conda-forge av 0.4.0, it does not have this close function for input container.

video.close()
AttributeError: 'av.container.input.InputContainer' object has no attribute 'close'

Does newer version of av lib have this close function for input container?

Hm you're right, I don't see a close() on input containers. How come @mikeboers ?

I guess it never came up before somehow.
It must be closing stuff, but maybe on the destructor.

I have some workaround solution.
Just simply exit the program while putting the input container to one thread and mark it as daemon thread. Main thread then helps to send termination signal to pyav input container.
May be thread join can help but I have not tried it.
I believe pyav itself has some signal interrupt handling scheme.

Does this do anything for you:
container = None
gc.collect()

I had a similar question, that later I answered my self
https://github.com/mikeboers/PyAV/issues/366
As @mikeboers  said the destructor is also closing the ffmpeg connection
import av
container = av.open('/dev/video0')

then
del container or container=None will release the usb camera and probably the rtsp connection.
probably here
https://github.com/mikeboers/PyAV/blob/41a0598a4e7703eff3374d7764d45a56892e5427/av/stream.pyx#L85

Does this do anything for you:
container = None
gc.collect()

it works, thanks.

Awesome, thanks for getting back to us on this!


Decouple engine

Assigning review to @numberoverzero.
Oh god I'm so alone.

Coverage remained the same at 100.0% when pulling 819bddcd0ba0b0d6c28ee4aa758bb25ec889b6da on decouple-engine into 0ae24188fbef15cb26d3b55e402dadeb869b312d on master.

Approved!  Aside from the crippling loneliness this looks great! :tada:


🚀 Feature: Edit StarredEntities default message when no entities are starred

🔖 Feature description
If no entitles are starred, a call to action message displays.
🎤 Context
"You do not have any starred entities yet!" text displays if a user has not starred an entity. Replacing the text with a call to action can help users understand how to use starred entities. Currently, the text cannot be edited directly.

✌ Possible Implementation
Add a prop to the StarredEntities to allow developers to edit the default message or change the default message.
For example: "Click the star beside an entity name to add the entity to this list!"
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Contributing Guidelines

Are you willing to submit PR?
Yes I am willing to submit a PR!

I think this makes sense, we can probably both add a prop that makes the empty state configurable, as well as update the default messaging. What do you think @backstage/techdocs-core?

Are you planning to work on this @estherannorzie? Otherwise I would be happy to give it a go. 😄

Are you planning to work on this @estherannorzie? Otherwise I would be happy to give it a go. smile

Thanks for asking! I am already working on it. 🙂


Statman better off as a normal structure

Right now statman is placed in memory at a fixed location. Which a kind-of a feature, but also just plain annoying. It requires every platform to handle it differently, and adds complexity. Its a known source of bugs.
I want to make dynamically allocate it. Also want to look into serializing it, so that stats can be retained across updates.

https://github.com/hioa-cs/IncludeOS/pull/1839 this solves half the issue, serializing statman

https://github.com/hioa-cs/IncludeOS/pull/1911 solves the issue


Exclusion Report | Integrate exclusion reporting with the compliance reporting feature page |1|

Move New Exclusion Report into Compliance Reporting
https://trello.com/c/2BBKZgLI/1728-exclusion-report-integrate-exclusion-reporting-with-the-compliance-reporting-feature-page-1

 Exclusion Report | Integrate exclusion reporting with the compliance reporting feature page |1|

Resolved in Sprint Tunguska


fix: typos

fix: typos

Hi @omahs :wave:, thank you for catching those and going trough the length of opening a PR!
The README.md file is dynamically generated, so those typos need to be fixed in these files:
src/docs/README.md.tera
src/docs/macros/sections.tera
src/docs/macros/section.QuickStart.tera
src/schemas/postgres-operator.cue

after which, the git commit hooks should re-generate that README.md correctly.
Please let us know if you are interested and willing to take that on make those changes to the PR :)

@omahs thank you! approved :slightly_smiling_face: Feel free to merge :bow:


(docs) Add LookML to supported languages

GitHub: https://github.com/spectacles-ci/highlightjs-lookml
NPM: https://www.npmjs.com/package/highlightjs-lookml
I've added an example HTML file and confirmed it works, plus quite a bit of testing with the browser developer tool.
Changes
Added LookML (data modeling language for Google's business intelligence tool, Looker) to the list of supported languages, linking to 3rd-party language definition repo that I created.
Checklist

[x] Added markup tests, or they don't apply here because... [this is a docs change]
[x] Updated the changelog at CHANGES.md

Please let me know where you'd like me to add my change to the changelog.

Yes, of course.  You'll just need to make a new section for the next minor release.

@joshgoebel out of curiosity, what does it take to get added to the demo page on the website?

The demo page only includes 1st party grammars and currently we're not merging additional first party grammars.


Create Tx if not existing

What does this implement/fix? Explain your changes.
创建交易记录前先检查是否存在相同的 txid 的交易
Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
…
Pull request type

Put an x in the boxes that apply

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Where has this been tested?
…
Any other comments?
…

最终查到啥原因会导致创建两次吗？很是好奇这个原因，我原本以为是广播失败仍然创建，但是看起来并不是...

嗯，大概率是这里的原因。如果 txid 相同情况下会报 TxAlreadyKnow，这时候也会创建


CI Add unit tests running for Spark 3.0.1

Nightly and Premerge run unit tests against Spark 3.0.1 as well. 3.1.0 have a few failures we need to fix first.
Let me know thoughts if we think this will take to long for premerge.

build

yeah I was going to look into running parallel separate. The problem is that unit tests are going to use entire GPU , so we would need multiple GPUs to run in parallel in the same build.  We can certainly leave it out of premerge right now if we think it takes to long, I don't think it will be a big deal for nightly.

I was thinking multiple jenkins jobs.  One to test each platform. We could also drop the initial memory allocated for cudf.  We don't run jobs that are that big for the unit tests.  We probably could run multiple in parallel that way.

sounds good, I'll talk to Tim and Calvin to see what our ci nodes have for gpus

build

looks like this increased premerge build by about 5 minutes.  So its taking around 42 minutes now.


AKS Periscope install error

Hi, I'm trying to install periscope on a single nodepool, single node AKS cluster v1.15.7, but am experiencing the following error:
'The CustomResourceDefinition "diagnostics.aks-periscope.azure.github.com" is invalid: spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:"v1"'
I'm running the latest Az CLI preview version.
$ az version
This command is in preview. It may be changed/removed in a future release.
{
"azure-cli": "2.2.0",
"azure-cli-command-modules-nspkg": "2.0.3",
"azure-cli-core": "2.2.0",
"azure-cli-nspkg": "3.0.4",
"azure-cli-telemetry": "1.0.4",
"extensions": {
"aks-preview": "0.4.35",
"front-door": "1.0.1"
}
}
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T17:01:15Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.7", GitCommit:"c83d931fb9bece427bc63a02349755e0f8696d3e", GitTreeState:"clean", BuildDate:"2020-01-31T20:09:49Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

$ az aks kollect -g k8s-demo-rg -n k8s-demo --storage-account stork8sdemo
This will deploy a daemon set to your cluster to collect logs and diagnostic information and save them to the storage account stork8sdemo as outlined in http://aka.ms/AKSPeriscope.
If you share access to that storage account to Azure support, you consent to the terms outlined in http://aka.ms/DiagConsent.
Do you confirm? (y/N): y
Getting credentials for cluster k8s-demo
Merged "k8s-demo-admin" as current context in /tmp/tmpyhy685qt
Starts collecting diag info for cluster k8s-demo
Cleaning up aks-periscope resources if existing
serviceaccount "aks-periscope-service-account" deleted
serviceaccount "default" deleted
configmap "containerlogs-config" deleted
configmap "kubeobjects-config" deleted
configmap "nodelogs-config" deleted
daemonset.extensions "aks-periscope" deleted
secret "azureblob-secret" deleted
secret "default-token-xfp7q" deleted
clusterrolebinding.rbac.authorization.k8s.io "aks-periscope-role-binding" deleted
clusterrolebinding.rbac.authorization.k8s.io "aks-periscope-role-binding-view" deleted
clusterrole.rbac.authorization.k8s.io "aks-periscope-role" deleted_
Deploying aks-periscope
b'namespace/aks-periscope unchanged\nserviceaccount/aks-periscope-service-account created\nclusterrole.rbac.authorization.k8s.io/aks-periscope-role created\nclusterrolebinding.rbac.authorization.k8s.io/aks-periscope-role-binding created\nclusterrolebinding.rbac.authorization.k8s.io/aks-periscope-role-binding-view created\ndaemonset.apps/aks-periscope created\nsecret/azureblob-secret created\nconfigmap/containerlogs-config created\nconfigmap/kubeobjects-config created\nconfigmap/nodelogs-config created\nThe CustomResourceDefinition "diagnostics.aks-periscope.azure.github.com" is invalid: spec.versions: Invalid value: []apiextensions.CustomResourceDefinitionVersion{apiextensions.CustomResourceDefinitionVersion{Name:"v1", Served:true, Storage:true, Schema:(*apiextensions.CustomResourceValidation)(0xc0096b3320), Subresources:(*apiextensions.CustomResourceSubresources)(nil), AdditionalPrinterColumns:[]apiextensions.CustomResourceColumnDefinition(nil)}}: per-version schemas may not all be set to identical values (top-level validation should be used instead)\n'

:bulb: Further addition: essentially I test with 1.16.* as well, with any higher version beyond the default: 1.14.8 gives the same error.
/triage

Facing the same issue. Recently upgraded AKS to v1.16.7 form v1.14.7. Getting same error,
'The CustomResourceDefinition "diagnostics.aks-periscope.azure.github.com" is invalid: spec.versions: Invalid value:
Wasn't facing this before.

We're experiencing the same.  And we also just upgraded our AKS to v1.16.7 (but I've never run periscope before today).

Update:

Please try again, and this issue is fixed now, for future reference we have added a fix in cli to always grab the latest off periscope repo.
tested on version 1.15 and 1.16

Thanks,

Update: @cbellee + kevin + blackbird

bulb Please try again, and this issue is fixed now, for future reference we have added a fix in cli to always grab the latest off periscope repo.
Tested on version 1.15 and 1.16

Thanks,

Yes, tested with latest yaml. Works well, thank you.


RuntimeException: Caused by java.lang.ArrayIndexOutOfBoundsException: length=0; index=0

version: 0.8.5
Fatal Exception: java.lang.RuntimeException: Unable to unbind to service Caused by java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
at android.support.v4.util.SimpleArrayMap.keyAt(SimpleArrayMap.java:370)
at com.firebase.jobdispatcher.JobService.onUnbind(JobService.java:246)
at android.app.ActivityThread.handleUnbindService(ActivityThread.java:3597)
at android.app.ActivityThread.-wrap28(Unknown Source)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1796)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6938)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)

In April 2019 we announced that Firebase Job Dispatcher would be deprecated today, April 7th 2020.  For this reason we are going to close all open issues and archive the repository.  We will also stop supporting FJD for new app installations (such as those targeting sdk versions greater than Android Q).  Existing apps that rely on FJD should continue to function as usual.
While we will no longer work on FJD, we encourage you to migrate to Work Manager which is a superior tool and fully supported by the Android team.
Thank you for taking the time to try the library and provide this feedback.  We sincerely appreciate your effort and we apologize for not addressing it in time.


Dead codes make severe performance degradation (GLES2)

Godot version:

22ee7ba4f
OS/device including version:

macOS Mojave / Intel HD Graphics 5000
Issue description:

Due to severe fps drops, I was profiling my game with Xcode Instruments,
and I found quite a lot of time is consumed in glGetActiveUnform in ShaderGLES2::bind like below.

After looking at related codes, the function is called for setting uniform_names variable of ShaderGLES2::Version but I couldn't find any reference of that variable.
https://github.com/godotengine/godot/blob/caa42667e801318fcb78c9f52921a48cf985b62f/drivers/gles2/shader_gles2.cpp#L148-L162
Moreover, even though this does not affect the performance, the function bind_uniforms in ShaderGLES2::bind has no effect.(bind_uniforms sets the uniforms according to the variables uniform_defaults and uniform_cameras, but no one access these variables)
Because of this, the variable uniforms_dirty is not necessary since its sole purpose seems to control the behavior of bind_uniforms.
I could've submitted PR according to my analysis but I'd like to confirm this from more involved person.

Ah.. I worked on every file of the GLES2 renderer except this one... you are right, this is a very severe performance bottleneck. Thanks for pointing it out!

Wow, I fixed this and got a massive performance improvement in GLES2, this is pretty cool.


Consider moving back to builder pattern or add Kotlin shim?

Is this your first time submitting a feature request?

[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing functionality

Describe the feature
As of 1.0.0, it is easy to get this wrong, seeing as types like id/namespace are the same, and since this library is written in Java, I can't use named arguments in Kotlin land.
    return index.query(
        topK ?: DEFAULT_TOP_K,
        denseVector,
        filteredSparseVector?.indicesWithUnsigned32IntList,
        filteredSparseVector?.valuesList,
        null,
        namespace,
        filter?.let { PineconeStructUtils.fromMap(it) },
        includeMetadata,
        includeValues,
    )

In the old way, the declarative approach towards specifying arguments was less error prone:
    val queryRequest = QueryRequest.newBuilder()
        .addAllVector(denseVector)
        .setTopK(topK ?: DEFAULT_TOP_K)
        .setIncludeMetadata(includeMetadata)
        .setIncludeValues(includeValues)
        .setNamespace(namespace)
        .apply {
            filter?.let { setFilter(PineconeStructUtils.fromMap(it)) }
            sparseVector
                ?.takeIf { it.indicesCount in 1..MAX_SPARSE_SIZE }
                ?.let {
                    setSparseVector(it)
                }
        }
        .build()

Two questions:

Any reason for the transition away from a builder pattern?
Are you planning on releasing a Kotlin shim?

Describe alternatives you've considered
No response
Who will this benefit?
Anyone who find it currently a bit tedious having to deal with 5+ parameters for a function call.
Are you interested in contributing this feature?
Sure, I can look into helping with this.
Anything else?
No response

Hi @rasharab, thanks for reporting this issue. To answer your questions in order:

Yes, we needed to add custom logic around the proto generated java classes which provided classes with builder pattern, so we have designed this wrapper.
As of now, we don't have any plans on designing Kotlin shim. If this changes anytime in future, I'll update this thread.

Totally!! But building a builder pattern around a builder pattern is not something we are planning in near term.


Spark serialization and shapebuffer not serializable

There is a current known issue with the new shape information impl and spark (no serialization) for ndarrays. Need to modify the readObject method.

This has been fixed.