Check for existence of Element when comparing DOM-nody-things (#7786)

Summary

Comparing things that look like DOM nodes now checks if Element is in scope before usage which would lead to ReferenceError: Element is not defined errors with 'testEnvironment': 'node'.
Test plan

/**
 * @jest-environment node
 */
describe('comparing DOM-nody-things', () => {
  it('should skip the "instanceof Element" check when "Element" is not in scope', () => {
    expect({ nodeName: "div", nodeType: 1 }).toEqual({ nodeName: "div", nodeType: 1 });
  });
});

First contribution and signed the CLA.

Thank you for first contribution to Jest!
In plain node testing environment where Element doesn’t exist, what is the criterion? generic deep equality for properties of expected and received as ordinary objects?
Can you add a test to the positive .toEqual failure snapshots above the .not.toEqual tests?
    [
      {
        nodeName: 'div',
        nodeType: 1,
      },
      {
        nodeName: 'p',
        nodeType: 1,
      },
    ]

It looks like that test might not succeed (by failing :) because fall through to:
    return a.innerText == b.innerText && a.textContent == b.textContent;

Let’s make sure if any code change is needed, it doesn’t break original test because fall through to:
  if (aIsDomNode || bIsDomNode) {
    return false;
  }

Oops, didn't catch that :-).
If you take a look at the current jasmine toEqual implementation they skipped the instanceof Element check on site https://github.com/jasmine/jasmine/blob/master/src/core/matchers/matchersUtil.js#L181 but the isDomNode helper checks for a Node constructor on the global object https://github.com/jasmine/jasmine/blob/master/src/core/base.js#L103
Judging from the comments the code path only seems to be important for IE<9 inside a browser which is probably not a supported target of Jest anyway? Just skipping the whole DOM node detection section if Element isn't in scope and let the deep comparison do the rest should be OK I think. Although that might be problematic if react also relies on that path for its DOM stuff. I'm kind of surprised that I'm the first to stumble upon this ^.^
The latest commit leaves the duck typing in place and lets me (or other fiddlers) reimplement isEqualNode in my fake DOM nodes if I choose to do so but it will skip the IE8 stuff if Element isn't in scope and also skips the early return in that case, what do you think?

So we assume that isDomNode method is available in supported browser testing environments.
I will make sure whether or not isDomNode is available in jsdom testing environment.
@mfeineis in your node testing environment without jsdom, is generic deep equality comparison of properties the desired criterion for objects which match the isDomNode heuristic?
What do you think about cutting the special case to the minimum:
  if (isDomNode(a) && isDomNode(b) && typeof a.isEqualNode === 'tunction') {
    return a.isEqualNode(b);
  }

Yes for my case these false positives should just be handled as plain objects because they are just that. I did something very similar what you suggested in my latest commit, it might be OK to leave out the early return although that might have performance implications. The test suite seems to work on my system, although CircleCI isn't happy on windows apparently.

Yes, it gave me a smile when your commit and my comment crosses paths.
I think it is clearer without the second if statement for node and non-node.
Just verified that element and text node have isEqualNode method in jsdom.
Oh, what do you think about adding isEqualNode method to heuristic function:
function isDomNode(obj) {
  return (
    obj !== null &&
    typeof obj === 'object' &&
    typeof obj.nodeType === 'number' &&
    typeof obj.nodeName === 'string' &&
    typeof obj.isEqualNode === 'function'
  );
}

  if (isDomNode(a) && isDomNode(b)) {
    return a.isEqualNode(b);
  }

Merging the isEqualNode into isDomNode  changes the semantics but may be the way to go, I will try that later today. I can't think of a sensible use-case where it makes sense to compare DOM nodes to something else, could still be costly, though.

Yes, good point that shortcut return reduces cost of comparing.
It is super for this pull request to fix the problem, delete obsolete code, and keep same semantics.

Thank you for thinking about it some more. Two heads are better than one.
Here is my short summary of the solution: for two instances of Node which have DOM3 method isEqualNode then use it as special case; otherwise compare according to deep equality.

For Jest it seems safer to drop the duck type condition:

function isDomNode(obj) {
  return typeof Node !== 'undefined' && obj instanceof Node;
}

because if a is a Node from jsdom environment and b is duck type literal object:
TypeError: Failed to execute 'isEqualNode' on 'Node': parameter 1 is not of type 'Node'.

It doesn’t seem likely if a is duck type object that it would have isEqualNode method.

A style suggestion that you can take or leave is typeof a.isEqualNode === 'function'

Before we merge (but not today) I’ll write local tests comparing a as Node to b as duck type literal object in current baseline and proposed improved comparison to see if fall through seems too risky.

I've added the typeof a.isEqualNode === 'function', I wonder if that is even necessary anymore due to the hard check for instanceof Node without the duck typing, which I also added for good measure :smiley:

While we wait for #7919 conversion of expect package to TypeScript with hopefully not too many merge conflicts, here is what I thought might be a problem, and why it isn’t.
I thought because Object.keys returns empty array for DOM nodes, that without short-circuit:
  if (aIsDomNode || bIsDomNode) {
    return false;
  }

That the following tests would incorrectly pass:
expect(document.createElement('div').toEqual({});
expect({}).toEqual(document.createElement('div');

The reason that they correctly fail is an upstream short-circuit:
  var className = Object.prototype.toString.call(a);
  if (className != Object.prototype.toString.call(b)) {
    return false;
  }

For example:
'[object HTMLDivElement]' !== '[object Object]'
'[object Object]' !== '[object HTMLDivElement]'

Also because '[object HTMLParagraphElement]' !== '[object HTMLDivElement]' different elements don’t always need .isEqualNode comparison.
Except beware that in jsdom that Jest uses at the time of writing, different SVG elements like path and polyline are instances of same SVGElement class.
After this PR has been merged, you or I might add a small matchers-dom.test.js with directives
 * @jest-environment jsdom
 */
/* eslint-env browser*/

as in for example, packages/pretty-format/src/tests/DOMElement.test.ts file
@SimenB @thymikee can you see any problem with the minimal code we kept for DOM elements?

@mfeineis The expect package is now TypeScript, so you can merge changes from master into your branch, and then resolve any conflicts in jasmineUtils.ts file (your local git understands renaming, but if your editor doesn’t, then close renamed .js files without saving changes).
After so many changes in recent days: yarn clean-all && yarn before yarn test

ahh, shoot something went wrong...

I have a feeling I put my commits on the wrong end of the rebase-train but github shows the changes I'm expecting so hopefully I didn't break anything :innocent:

I could also spin up a new branch on top of master and cherry pick my changes on top if that is easier to manage.

At my level of git knowledge, all’s well that ends well. Other collaborators can tell us if they see a problem. Ever since GitHub got Squash and merge option, you can take the term “rebase” loosely on Jest project (unlike some projects whose maintainers mean it literally).  That is the way that I have felt, when I have been you :)

#7995


ENH: add pad

closes gh-69
Add an np.pad replacement, as discussed at https://github.com/scipy/scipy/pull/22122/files#r1895558533

np.pad is a thing
jax.numpy.pad is a thing
torch.nn.functional.pad is a thing
array_api_strict.pad is not
"generic" implementation needs mutable arrays, so is not going to work on jax.numpy

I don't understnd the request, and I though we covered this in the scipy issue.

By the way, if you notice any improvements that we should make to https://data-apis.org/array-api-extra/contributing.html, would be great to hear.

I think we should still just add the "generic" implementation here, then look at dispatching immediately after that.

I still don't follow. This PR is I believe what scipy needs. What is wrong with the PR, what is the request exactly?

What is wrong with the PR, what is the request exactly?

I'll push changes to show you what I mean. Currently, the other functions in this library do not use any delegation to specific namespaces. Since we want to add that in order to use this in SciPy, this PR is doing 2 things which can be quite cleanly split:

add a pad which is similar to all of the other existing functions - array-agnostic, tested against array-api-strict.
add delegation to existing libraries on top, perhaps also test with those libraries

My request was just to do (1) first here before we think about how delegation should work in array-api-extra.

Ah, so the request is to rewrite the history into two commits: one for the "generic" implementation and the other with branching on namespace? This I can do easily. Or, like you said, feel free to rewrite the history here to your liking.

I think there is potential to be smarter about how we do delegation, similar to what you and Matt have implemented in SciPy, if we are going to open up to the possibility of delegating for all functions in this library.

Okay.... I'd expect something like that is an overkill for a handful of if-elif-else branches in pure python code, but this is well in the "tastes differ" territory. Am rather curious to see what you have in mind.


Test newer rubies and railses

In 2.7. BigDecimal.new is gone, and only BigDecimal remains.
cc @pi3r @Shopify/rails @DazWorrall @wvanbergen

Ok, I fixed my fat fingering...
While I was at it I also cleared a good chunk of the warnings, there a bunch left but now the CI output is somewhat readable.

I can't merge this myself though.


"Walkie Talkies" filter does not work

On the US site, clicking the "Walkie-talkies/baby monitors" filter returns nothing even though when browsing the list with no filters, you can see multiple sites accept walkie-talkies.

likely to be solved by any efforts towards this: https://github.com/findthemasks/findthemasks/issues/493
but also likely should be solved on its own in the immediate future


source: Error encountered while sourcing file '/nix/store/izdgybj5b5bwm69xx8mdimdm7q1f04dy-mcfly-0.4.1/share/mcfly/mcfly.fish':

Issue description
❯ env LANG=c fish
source: Error encountered while sourcing file '/nix/store/izdgybj5b5bwm69xx8mdimdm7q1f04dy-mcfly-0.4.1/share/mcfly/mcfly.fish':
source: No such file or directory
~/.config/fish/config.fish (line 14):
mcfly_key_bindings
^
from sourcing file ~/.config/fish/config.fish
	called during startup

Meta
Maintainer CC
@marsam

Technical details

system: "x86_64-linux"
host os: Linux 5.7.10-zen1, NixOS, 20.09pre-git (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
channels(root): "nixos-20.09pre237686.96069f7d890"
nixpkgs: /run/current-system/nixpkgs

Hi, thanks for trying the mcfly module.
You need mcfly 0.5.0 (already in nixpkgs HEAD) for this module. I think you could apply https://github.com/NixOS/nixpkgs/commit/6b8e30c2dc8 to your local nixpkgs as a workaround.

It seems to work fine with 0.5.0. Thanks for the help, and the module :smile:

I have some weird message when I install my nixos config with nixus. and sometimes in emacs too:
Directory `/home/bbigras/dev/neuron/fish: Unknown command: mcfly_key_bindings
~/.config/fish/config.fish (ligne 14) :
mcfly_key_bindings
^
du fichier source ~/.config/fish/config.fish
	appelé pendant le démarrage


Updates for AppFlows

Description
Includes some permission changes in create_vCenter_User.ps1 including added comments to explain why some of the permissions are present in the defined role.
Also adding a new script to handle the cleanup after AppFlows failover.  The script enables a user to cleanup any Deprecated_* VMs left behind in the original primary site.
Related Issue
https://github.com/rubrikinc/rubrik-scripts-for-powershell/issues/187
Motivation and Context
These changes cover existing gaps in coverage for AppFlows.
How Has This Been Tested?
All changes have been tested in the Rubrik Rangers Lab environment.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTION document.
[ ] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Closing in favor of different updates to the create_vCenter_User.ps1 script.


Bigtable example code uses DataConnection

After #8860 is done, we should recommend the DataConnection API over the DataClient API in all sample code.
This also applies to our internal code (integration tests and such)

Only the quickstart remains.


Changed steamapps folder capitalization

Since the default SteamApps folder is lowercase, I think it would be better to change the default.

Thanks

For the Arch linux the default is actually SteamApps


fix: reset to defaults (factory) not implemented

opened https://github.com/ansible-collections/community.general/issues/8163

bug: https://github.com/openbmc/docs/commit/275f271fc44ae3cb52fcbc1ff82e067881482a24


[enhancement]: add back to home page button

back to home page button in all the games, that would facilitate the users

@Spandan-Bhattacharya kindly assign this issue under jwoc'24

Go for it! @Anushkabh

kindly merge my pr #328  @Spandan-Bhattacharya


making address ,call us now ,mail us now section more engaging.

i wanna make this section look attractive.
please assign these issue to me @tushargupta1504 .

change the email to<EMAIL_ADDRESS>too


Detecting jams & Notifying People

[x] On FED_library we want to set a timer that lets us know through serial if clearing jam is not solved within 10 min. Send "special alert"
[X] On FEDWatcher we should be watching for jams. So parse Device_Number, "jam"
[x] Alert user via email

I want to reopen this.
We didn't have the best of experience with setting up emails and stuff...there might be a workaround by using something like twillio (or any other app) + python authomation + whatsapp
See here

We can send messages with something like this (given we have secrets.py) and have done the telegram configuration.
We would need to integrate the proper messaging with parsing data for each FED and/or jamming events and send proper messaging.
Brainstorm of what would be nice to have:

FED00X is jammed
FED00X delivered Y number of pellets in the last n hours

import requests
from secrets import secrets
import seaborn as sns
# Send a telegram message to a given user id
def send_message (chatId, message):
    response = requests.post(sendURL + "?chat_id=" + str(chatId) + "&text=" + message)
    # Close to avoid filling up the RAM.
    response.close()

if __name__ == '__main__':
    botToken = secrets['botToken']
    chatId = secrets['telegramDmUid']

    # Telegram send message URL
    sendURL = 'https://api.telegram.org/bot' + botToken + '/sendMessage'

    iris = sns.load_dataset('iris')
    message =  str(iris.head())

    send_message(chatId, message)

Here's what I've coded for the runHelper and event_summary functions:
Lines 235-247 (runHelper)
            # TODO: replicate this idea but with the notification interval
            if (now - self.last_notif * 3600) > self.notif_interval:
                self._save_all_df()
                # create read_csv_
                self.last_save = now
                current_directory = os.getcwd() # gets path to current folder (src)
                data_folder_path = os.path.join(current_directory, 'data') # gets the path to the data folder
                csv_files = [file for file in os.listdir(data_folder_path) if file.endswith('.csv')]
                for path in csv_files:
                    summary = self.event_summary(path)
                    if self.tg_enabled:
                        self.send_tg_message(message=summary)
                self.last_notif = now # updates last_notif to the current time

Event summary
def event_summary(self, path):
    ## want to return message in format "FED{Device #} delivered {num_rows} pellets since {Time}"
    # INPUTS: data, last time interval
    # OUTPUTS: a summarized message in string form

    # iterate through dataframe
    df = pd.read_csv(path)
    device_number = path.split("_")[0]
    # filter through events using PiTime
    filtered_df = df.loc[df['Pi_Time'] > self.last_notif & (df['Pi_Time'] < self.now) & (df['Event']=="Pellet")]
    # pellets = number of rows in df after filtering
    num_pellets = len(filtered_df.index) # will this work with empty df?
    return f"FED{device_number} delivered {num_pellets} since {self.last_notif}"

The function accesses the 'data' folder by using the os.path.join function. A list of paths to all of the csv files are then created. This list is iterated upon, with each file being read and turned into a pandas dataframe within the event_summary function. After the conversion to a pandas dataframe, the dataframe is filtered to only show the data we are interested in, and a summary message is then created and sent. After all of this happens, we then set the last_notif variable to now, and the process repeats every notif_interval.

As is, this will not run. Here are a few of issues I modified.

now = time.time() (also used for self.last_save) cannot be used to filter a dataframe with a datetime column
self.now does not exist, created a self.now_dt to make it different from the time.time() version of it which is stored at now
path_split will not work as expected when using a full path (which we need for reading!)

These lines are searching for data where the data is not being saved
              current_directory = os.getcwd() # gets path to current folder (src)
                data_folder_path = os.path.join(current_directory, 'data') # gets the path to the data folder

Data gets saved in
self.exp_dir

and split by day into
self.today_dir

Also, this line turned out to be wrong
filtered_df = df.loc[df['Pi_Time'] > self.last_notif & (df['Pi_Time'] < self.now_dt) & (df['Event']=="Pellet")]
TypeError: Cannot perform 'rand_' with a dtyped [bool] array and scalar of type [bool]

The issue were missing parenthesis on the first condition

More importantly this code didn't reset the last_notif and therefore it was blasting notifications one after the other on each iteration. It was missing
self.last_notif = self.now_dt

Looks like mvp is working. Closing until further enhancement is needed.


glfw: support wayland

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

waylandSupport isn't true by default, because it disables xorg support

Result of nixpkgs-review pr 129367 at c3b51a96 run on aarch64-linux 1

4 packages marked as broken and skipped:

embree
embree2
forge
luxcorerender

2 packages failed to build:

ccextractor
vcv-rack

3 packages skipped due to time constraints:

idrisPackages.glfw
tev
tracy

16 packages built successfully:

MIDIVisualizer
glfw (glfw3)
glfw-wayland
glslviewer
goxel
libsForQt5.mapbox-gl-native (libsForQt515.mapbox-gl-native ,plasma5Packages.mapbox-gl-native)
libsForQt5.mapbox-gl-qml (libsForQt515.mapbox-gl-qml ,plasma5Packages.mapbox-gl-qml)
libsForQt512.mapbox-gl-native
libsForQt512.mapbox-gl-qml
libsForQt514.mapbox-gl-native
libsForQt514.mapbox-gl-qml
pixelnuke
pure-maps
raylib
taisei
vlang

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

The changes should not impact glfw or the packages that depend on it.
The hash changed because:
- /nix/store/imznpbb9xpqix45j2fp31z0pfbax3xzk-glfw-3.3.4.drv:{out}
+ /nix/store/988k6apczisb5yrs1kir616g70ynnkb7-glfw-3.3.4.drv:{out}
• The environments do not match:
    + postPatch=

https://github.com/glfw/glfw/pull/1711 This pr fixes freezes and makes glfw usable on wayland, but it has been a year and it's still not merged.
Should I apply the patch here?


Ticket#434 fix frame masking check

Just a minor comment, otherwise looks good to me.

@jitsni Implemented your feedback and added a reply to you comment. Let me know if anything else is required. Thanks!


sharing pytorch starting point

I'd like to pass along the RGCN pytorch code soon, and I was wondering how you would prefer that to be passed along. My goal is to provide the RGCN code that mimics the river-dl model, the published/simplified model, demonstrates all/most of your pipeline needs, and shows some of the UQ that can accompany that. It isn't necessarily my goal to replace tensorflow* for the project but instead I wanted to provide the option or starting point for you all to run with it if it interests you, so I'm interested to hear how you'd like this to be shared (because it doesn't seem like a PR that would normally be forward progress of the project, it's more of a possible side route)

Thanks for bringing this up @jdiaz4302.  I was thinking about this as I reviewed Jeff's most recent PR.  I think that ultimately we want functionality for both PyTorch and TF models.  I've got a branch going right now that includes some  functions to:

Reshape the output of prep_all_data so it can be applied across models with different format expectations, and
Train/predict with Pytorch models within the pipeline while maintaining the same file structure.

I was planning on it being somewhat of a standalone branch to go with the hold-out generalizability manuscript, but it might also just be a good way to incorporate the PyTorch work you've been doing.  Selfishly, merging it with River-dl would also get some more eyes on my code which wouldn't be horrible either.
@janetrbarclay, @jsadler2, what do you think?

I've got a branch going right now that includes some functions to....
2. Train/predict with Pytorch models within the pipeline while maintaining the same file structure.

Nice! For clarification, have you been using the pipeline and RGCN in pytorch already?

I definitely see a lot of pluses to making river-dl play with pytorch as well as TF. If you don't think it's too much of a lift, @SimonTopp, it seems like this could be a good opportunity to at least start to add that functionality. I'd be happy to help with PR reviews for it.

Sounds good.  I'll plan to submit a PR next week sometime after we merge #148.  In terms of

Nice! For clarification, have you been using the pipeline and RGCN in pytorch already?

I've been using the pipeline to train GraphWaveNet, which is also in PyTorch.  Plugging the torch RGCN in should be very straightforward.  I should have it all debugged and ready to go today or early next week.

Okay, if that's the case, my efforts might be better suited supplementing your work. Can you point me to that repo?
Also, let me know if you'd like my torch RGCN code passed along for any help debugging because it's been working for me independent of the pipeline

For sure, branch is here with most of the integration code in gwn_integration_utils.py.  It's a little sandboxy right now, but feel free to poke around all the same.  Particularly would be curious to get some feedback on how I've set up the train_torch function

Nice job! I think the forward passing, weight updating, and early stopping are set up great.
In my experience using the torch dataloaders (as you have) make for a really easy lift to parallel GPUs via torch.nn.DataParallel. At a scan, I think both my RGCN models should feed into that without any big issues ( but I haven't tried to run them together yet.)

Feel free to ping me to contribute those or review when you're ready

Sounds good to me!  If you want to contribute the torch models feel free to make a PR for them, alternatively I can just copy them out of the run-pgdl-da repository and request your review when I submit the PR.  Let me know what you prefer.

I can submit a PR to your branch later today with model code

Addressed in #163


Rename relay::Environment to relay::Module

Rename Environment to Module for consistency with TVM and LLVM.

please fix the lint error http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-2054/4/pipeline


Don't create garbage in System.currentMillis

Date.now() is supported on every browser that supports WebGL, so it's save to use it instead of creating a new object on every call.

I benchmarked this in the past and didn't find it made much of a difference but certainly didn't hurt anything either.


BUG: admin.conf:no such file or directory

Sealos Version
v4.1.4-rc3-43497b9b
How to reproduce the bug?
CentOS7
安装k8s:v1.25.0
运行单节点或多节点安装都报错：
error applied to cluster error:read admin.conf error in guest: open /root/.sealos/default/etc/admin.conf:no such file or directory
What is the expected behavior?
No response
What do you see instead?
No response
Operating environment
- Sealos version:v4.1.4-rc3-43497b9b
- Docker version:
- Kubernetes version:v1.25.0
- Operating system:CentOS7
- Runtime environment:
- Cluster size:single/1Master(4CPU 8G Memory)-2Node(2CPU 4GMemory)
- Additional information:

Additional information
No response

是否在 master0 节点上执行？

遇到同样的问题 sealos run labring/kubernetes:v1.25.0 labring/helm:v3.8.2 labring/calico:v3.24.1 --single

how to do ?

need sync new version config from old version cluster

processor.SyncNewVersionConfig(c.ClusterDesired.Name)


MemSpan: updated comments, some API cleanup.

I simplified the internals and API somewhat, which made a number of tests redundant.
This depends on #3574.

What is all this code for? What uses it ?

It's used by CacheTool and by MemArena. I have other potential uses in mind as well. Ask me on Tuesday.


How to aggregate notifications from multiple apps into one message

Currently I have a lot of applications and want to do aggregate notifications for a type of app

Any update on this one? Alertmanager supports that, could be usefull with other services


Review home-office-kit plugin

What
Review the home-office-kit plugin and provide feedback, including things that we think need to be changed.
Linked to PR #2135
Why
So the plugin authors know what they need to do for the plugin to be listed in the 'manage your prototype' section
Who needs to work on this
Developer
Who needs to review this
Team
Done when

[ ] A review is completed
[ ] A list of recommendations is drafted and shared with the GOV.UK Prototype Kit team
[ ] The recommendations are fed back to the author
[ ] We use this review to create a template for future plugin reviews

Review results:

ran the plugin validator to check the config, no issues were found with it

namespacing does not seem to be consistent

css is namespaced “hods"
nunjucks macros are name spaced "home-office-kit”
nunjucks paths are not namespaced (eg. they are just "/layouts" and "/macros”)

I don't know if we have this as a requirement, but I think the script within the script tag in the template "/templates/add-another.html" should be surrounded by:
window.GOVUKPrototypeKit.documentReady(() => { /* their script code goes here */ })

Is this just about namespacing in which case we can meet and agree on a preliminary rule for that


Misc. Stats

Need some help in identifying these stats:

generalpvp_serveraggression
generalpvp_serverdefender
generalpvp_servershacked

ok think this is what they are

going to close this as there are more i've just found


avoid double forward pass for train metrics

Our current training loop requires an extra forward pass to compute training metrics which creates a considerable slowdown. Since training metrics are pretty useful, this slowdown could be a dealbreaker for some. It also seems completely avoidable, I see two options:
current loop..ish

def fit():
    while timer < max_duration:
        model.train()  # set model to train mode
        for batch in train_dataloader:

            if self.compute_training_metrics:
                model.eval()
                with torch.no_grad():
                    outputs, targets = model.validate(batch)
                    train_metrics.update(outputs, targets)
                model.train()

            optimizer.zero_grad()
            outputs = model.forward(batch)
            loss = model.loss(outputs, batch)
            loss.backward()
            scheduler.step()

        ## Eval
        model.eval()
        eval_metrics = model.metrics(train=False)  # get eval metrics
        with torch.no_grad():
            for batch in eval_dataloader:
                outputs, targets = model.validate(batch)
                eval_metrics.update(outputs, targets)
            eval_metrics.compute()  # compute and sync metrics across devices

Option 1 :
re-use outputs from forward and access targets from state.batch.
upside:

solves the problem
no changes to the model class

downside:

we need to know how to unpack the batch =(

  for batch in train_dataloader:
      optimizer.zero_grad()
      outputs = model.forward(batch)
      loss = model.loss(outputs, batch)
      if self.compute_training_metrics:
          train_metrics.update(outputs.detach(), state.batch[1]) # tuple batch
      loss.backward()
      scheduler.step()

Option 2:
return outputs and targets from model.forward
upside:

solves the problem
user specifies how to unpack the batch
potential to unify forward and validate by having validate call forward by default and allowing users to override if their validation loop requires special logic such as beamsearch decoding for nlp.

downside:

targets return from forward is sort of strange, but we cant use forward for prediction for our current setup anyway as it expects a full batch (with targets). maybe we rename this method as there's already an expectation (though not convention) in pytorch that forward takes model input and returns output?
validate overrides would either be ignored in the training loop, or require two forward steps yet again.

  for batch in train_dataloader:
      optimizer.zero_grad()
      outputs, targets = model.forward(batch)
      loss = model.loss(outputs, batch)
      if self.compute_training_metrics:
          train_metrics.update(outputs.detach(), targets)
      loss.backward()
      scheduler.step()

current  ComposerClassifier's methods, note they're pretty much the same. The only model we have that currently has a special validation method is Unet to the best of my knowledge.
   def forward(self, batch: BatchPair) -> Tensor:
       x, _ = batch
       logits = self.module(x)
       return logits

   def validate(self, batch: BatchPair) -> Tuple[Any, Any]:
       assert self.training is False, "For validation, model must be in eval mode"
       _, targets = batch
       logits = self.forward(batch)
       return logits, targets

proposed, though maybe validate is set to call forward on the base class.
    def forward(self, batch: BatchPair) -> Tensor:
        inputs, targets = batch
        outputs = self.module(inputs)
        return outputs

    def validate(self, batch: BatchPair) -> Tuple[Any, Any]:
        return self.forward(batch)

@hanlint, @Landanjs , @anisehsani

I like Option 2 since I think the name forward() is already confusing for the utility of the function (i.e. split's the batch for forward pass and splits the model output for loss()). I'll have to think which name makes more sense to me...
For Unet, I think the unique validate() function is to handle 3D images from the eval dataloader. Maybe this processing can be moved to eval dataloader or performed as preprocessing? We can chat more.
Higher-level, naive question: what do you think is the utility of the train metrics calculated with model.train() and train data preprocessing? The metrics could become very different with certain algorithms e.g. stochastic depth or cutmix.
I understand we should still have the functionality since people expect it. But should we make it clear that the metrics may be very different than providing the training dataset as another evaluation dataset (with eval preprocessing)? Although there will be a slowdown, the measurement should be more useful for research.

I'm not sure yet about the first two. Definitely going to be ongoing discussions. For example, with unet in particular it's probably better to move the preprocessing to the loader. But in general I don't think we should expect people to modify their datasets.
Regarding training metrics. I think it's useful to compare them to validation metrics during training, even if they are very noisy. Obviously augmentation and stuff like mixup are going to limit the usefulness of these but most people still do log them by default. I also believe it's not unreasonable to assume people know training metrics are noisy since they're normally a moving average of a model that's still being trained. If we wanted truly accurate metrics we would have to do a full pass through the train set at the end of each epoch just as we do with the validation set. There's probably some value in doing this if you really want to make assumptions about overfitting or how well matched your train and validation sets are but I'm not sure how common this is.

In most cases, where the output of forward can be consumed by metrics, this is correct. However, our API only enforces forward -> loss and validate -> metrics, so this seems like a feature that would break that contract.

Brainstorming: what if we had an optional prep_for_metrics method? We wouldn't enforce that forward -> metrics worked, but we would enforce that forward, batch -> prep_for_metrics -> metrics worked. Users doing simple things will never need to touch this method, but would allow arbitrary flexibility.
Might also let us get rid of validate? (low confidence here because I don't really understand why it exists right now)
Also, fwiw, I see avoidance of an extra forward pass for training metrics as a requirement for our API; i.e., if the API doesn't allow it, the API needs to change.

Brainstorming: what if we had an optional prep_for_metrics method? We wouldn't enforce that forward -> metrics worked, but we would enforce that forward, batch -> prep_for_metrics -> metrics worked. Users doing simple things will never need to touch this method, but it would allow arbitrary flexibility for those who need it.
Might also let us get rid of validate? (low confidence here because I don't really understand why it exists right now)
Also, fwiw, I see avoidance of an extra forward pass for training metrics as a requirement for our API; i.e., if the API doesn't allow it, the API needs to change.

Have been thinking of something along these lines ,but perhaps making metrics into more of a run_metrics type method that actually explicitly takes the outputs of forward and computes metrics on them. This way the user can just manually manipulate what they need and they know exactly what's being computed rather than us hiding stuff from them in the training loop.

I haven't looked at all the implications but it would be something like this:
def metrics(outputs, batch, train=False):
   inputs, targets = batch
   if train:
    accuracy = self.train_acc(outputs, targets)
    loss = self.train_loss(outputs, targets)
    return accuracy, loss
  accuracy = self.val _acc(outputs, targets)
  loss = self.val_metric(outputs, targets)
  return accuracy, loss

This is now implemented :)


Channel name placeholder in input

This was suggested in the irc:
15:42   Parabola requests that my name next to the editbox be replaced with the current channel name
15:42   Parabola    seems like seeing my own name is pointless anyway
15:43   gweedo767   channel name could be more help in the mobile view too
15:44   gweedo767   since the channel list isn't visible then

I quite like this idea. Thoughts?

Don't know about removing the username, but having a placeholder like Write to #channel might be helpful.

I really don't like the original idea from a user experience standpoint and, like it or not, when you're on several networks, it's useful to have your nick displayed. Also, it's going to be a very nice place to update your nick.
Plus, the channel name is already repeated at least twice: in the sidebar and in the title bar.
That being said, 👍 to @xPaw's idea, very clever, very simple and rather appropriate! Plus screen readers will be able to read it, so there is that.

when you're on several networks, it's useful to have your nick displayed

As someone who uses the same username everywhere, I don't really mind about that. But if other people find it useful, I'll keep it. I'll just keep it hidden in my css :-P

but having a placeholder like Write to #channel might be helpful.

Yup, I like this.

I'm not sure I like the idea of a placeholder. I think it makes the UI feel more bloated than it needs to be, and there isn't much customization available to placeholder texts. I really don't see the need for this as the channel name is already in the top bar anyway.

I thought this (the placeholder) got implemented at some point, but I guess not.

I forgot about this @YaManicKill (what happens when there are too many issues :D), so just opened #832.


feat: kademlia oversaturation based on an exponential decay formula

Bin oversaturation count is calculated using an exponential decay formula.
The goal is to give more weight to shallower bins (relative to how they are now) as they make up the majority of known peers.
This should improve connectivity and decrease hops in syncing protocols.

This change is

Codecov Report

Merging #2530 (ef98984) into master (c30ba68) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2530      +/-   ##
==========================================
- Coverage   63.57%   63.53%   -0.05%
==========================================
  Files         236      236
  Lines       26557    26561       +4
==========================================
- Hits        16884    16875       -9
- Misses       8154     8168      +14
+ Partials     1519     1518       -1

Impacted Files
Coverage Δ

pkg/topology/kademlia/kademlia.go
75.88% <100.00%> (+0.34%)
:arrow_up:

pkg/p2p/libp2p/stream.go
70.58% <0.00%> (-11.77%)
:arrow_down:

pkg/localstore/subscription_pull.go
84.24% <0.00%> (-6.85%)
:arrow_down:

pkg/localstore/subscription_push.go
73.68% <0.00%> (-3.51%)
:arrow_down:

pkg/chainsyncer/chainsyncer.go
79.71% <0.00%> (-1.45%)
:arrow_down:

pkg/p2p/libp2p/internal/reacher/reacher.go
90.90% <0.00%> (-1.30%)
:arrow_down:

pkg/retrieval/retrieval.go
62.04% <0.00%> (-0.31%)
:arrow_down:

pkg/p2p/libp2p/libp2p.go
61.60% <0.00%> (+0.58%)
:arrow_up:

pkg/p2p/libp2p/headers.go
83.33% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30ba68...ef98984. Read the comment docs.


Add image gallery

We need an image gallery component for the various places this site will use images (page headers, textWithPhoto component, etc).  The user should be able to upload the photo to the library one time and then consume it on multiple pages.
Create a component similar to wordpress.

I would like to keep the library of 4:1 header images needed by the page headers, separated from the library unrestricted aspect ratio images needed by textWithPhoto.  I'd like to be able to point this component to a subfolder like "headerImages" and have it just show the content from (contentRoot)/(churchId)/library/headerImages

The screen shot I used as an example isn't perfect.  Just need a place to select a previously uploaded photo, or upload a new one, then insert that one image into whatever field called this modal.

Also, I don't think we need the title, caption, alt, or description shown in the photo.  Just the image itself.  I don't think we even need a database record for the image.  Can just do a file list from apiBase/FileHelper in ContentApi and the directory contents will be our list.
When including the image in a component we can have an alt field there where applicable (when not a background image).


Adds v1alpha members as reviewers/approvers

Updates Owners to allow v1alpha members to contribute to the repo

Codecov Report

Merging #79 (366a1e6) into main (52e9af3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   42.35%   42.35%
=======================================
  Files          12       12
  Lines         451      451
=======================================
  Hits          191      191
  Misses        250      250
  Partials       10       10

/hold
Need to understand if this will become standard across all repos for all FTs

/lgtm
/approve
@iamkirkbater this looks good on the basis that not everyone is an approver by default, but rather is a reviewer. You as FL are in your power to promote reviewers to approvers when you deem appropriate.

/unhold


Essential code changes needed to load native arm lib on windows based systems

Basic features needed to support native arm lib on windows based system.
See also https://github.com/grpc/grpc/issues/16929
Had to switch to netstandard 2.0, because found no other way to check for arm architecture.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

One or more commits are not associated with a GitHub user. The email used in the Git commit must match a verified email address in a GitHub user profile. For more information, please see https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

Regards,
CLA GitHub bot

@jtattermusch, should we close this obsolete PR?

I'm going to close this because we don't want to require netstandard 2.0 (at least not yet).


gu not found

I've been having issues running mill cli[2.12.18].mostly-static-image.nativeImage on the coursier codebase and I went down a rabbit hole of why this wasn't working. It looks like with some of the new installations of Graal gu isn't where this plugins thinks it is. For example you can see some logic in this plugin here:
https://github.com/alexarchambault/mill-native-image/blob/b97f73908203f561fa80d3bac99e77b202ab9fff/plugin/src/io/github/alexarchambault/millnativeimage/NativeImage.scala#L351-L360
This is supposed to get the graal home and use it to find gu, but this doesn't seem to always work. For example if I do this command locally:
 cs java-home
/Users/ckipp/Library/Caches/Coursier/arc/https/github.com/graalvm/graalvm-ce-builds/releases/download/jdk-21.0.2/graalvm-community-jdk-21.0.2_macos-aarch64_bin.tar.gz/graalvm-community-openjdk-21.0.2+13.1/Contents/Home

I'll see what it ends up using for the graal home. However when I look in bin/gu it's not there like it is in some of my older graalvm installations. This then causes nativeImage to blow up since gu can't be found.
/data/run-native-image.sh: line 13: gu: command not found
1 targets failed
cli[2.12.18].mostly-static-image.nativeImage os.SubprocessException: Result of docker…: 127

    os.proc.call(ProcessOps.scala:95)
    io.github.alexarchambault.millnativeimage.NativeImage.$anonfun$nativeImage$8(NativeImage.scala:219)
    mill.define.Task$TraverseCtx.evaluate(Task.scala:71)

I've read here that on recent GraalVM packages (21), native-image already comes with the default installer and gu was removed.


Instructions for Switching to Developer Preview are incorrect

You have Microsoft Teams Version <IP_ADDRESS>1 (64-bit). It was last updated on 1/31/2023.
I don't see any option to switch to the Developer Preview

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 008da4e2-979e-c396-db28-4acf57deb530
Version Independent ID: f1413f77-5eb3-e1fd-9235-d322d6e4eb6c
Content: Public developer preview for Microsoft Teams - Teams
Content Source: msteams-platform/resources/dev-preview/developer-preview-intro.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@mscherotter - Can you please confirm if follow office preview is enabled or not in admin portal? Can you please try flipping it to just "Enabled" and restart the client (this might take a few minutes for the new policy to be downloaded).

Can you please try above suggestion and let us know if you are now able to see dev preview in About section.


[GitHub] (Readme) Update readme with issue advice

Clarifying the purpose of the repo and the types of issues to file here.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Yep!


Change in regular expression definition and mkfs flag

Hi, I would like to contribute the following changes:

Extension of regular expression to identify # $wheel ALL=(ALL:ALL) ALL in addition to # $wheel ALL=(ALL) ALL. The first scenario was the case while installing Arch using the ISO  ARCH_202202, and without such permission the script wasn't able to install the Arch AUR helper, and everything afterwards failed.
The flag -f is not a valid one for mkfs.ext4 as implement in the Arch ISO. When using -f the terminal outputs mkfs.ext4: invalid option -- 'f'. When removed, the filesystem is created without any problem.

Thanks a lot for the creation of the scripts! They work great as a tool to learn and customize my own Arch paradise, cheers

Merged, thanks for your contribution ;)


fix(instrumentation)!: pin<EMAIL_ADDRESS>

Which problem is this PR solving?
<EMAIL_ADDRESS>and later includes a bug (https://github.com/DataDog/import-in-the-middle/issues/57) where a property we use to distinguish ESM from CJS modules is not present, causing instrumentation to crash end-user apps.
This drops support for ESM instrumentation again for Node.js 18.19 and later.
Short description of the changes
pin<EMAIL_ADDRESS>Type of change
Please delete options that are not relevant.

[x] Bug fix
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

cc @trentm


MINOR: [C++] Update parquet-testing submodule

@pitrou Could you please review this update?

Thanks @sfc-gh-mmuthuraman !


[formatter] minor patches to tree-sitter and qol improvements

Description

mut is now better parsed as mut(param) instead of mut, param
abort allows no expression after
@1 address literals are now allowed
better handling of imm_ref and mut_ref, no more workarounds
qol improvements in block node printing
removes unused code
adds more tests for borrow_expression, index_expression and literal.

Test plan
Features tests, existing tests are not broken.

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Thank you @manolisliolios !


list in wrong order after jquery sort and then update

Hi,
I have a list of items displayed with ractive that can be reordered using jquery sort. If I populate the list then drag some items around and then repopulate the list using ractive.set("list", array); then the list is in the wrong order.
I realise it is probably not advisable to modify the dom with jquery when it's inside a ractive template and I have found a workaround by first setting the list to an empty array, but I was wondering if this is known behaviour and if it is safe to work around it in this way?
Cheers,
Gus

That's because Ractive isn't aware of your DOM changes (it's not part of 2 way binding). So when you call set again, it re-renders the data according to what it knows.
What you could do is keep track of the draggable items (assign them an index or something). When you finish dragging, you could scan the DOM and check the order of the list items. Then mutate list to update their order on the component data. Ractive will re-render, but won't be noticeable because of the already moved items.
By the way, Ractive has a sortable plugin https://github.com/Nijikokun/ractive.sortable.js

Hey @gushogg-blake, it's been awhile since you've responded to the thread, so I'm going to assume your issue has been resolved. If I'm totally wrong, do not hesitate to reopen the thread at any time. :)


GPU utility in training only about 25%

Hi!
When trying to train DeepCpG, on a GPU system, I get very low GPU utility (approximately 25%). Do you perhaps have an idea what could be the cause? I tried increasing the number of workers for the data loader, but it didn't help.
Here are the parameters I have been using:
dcpg_train.py ${mydatadir}/train/* --val_file ${mydatadir}/val/* --out_dir ${mydatadir}/model/  --dna_model CnnL2h128 --cpg_model RnnL1 --joint_model JointL2h512 --nb_epoch 10 --data_nb_worker 8 --data_q_size 20 --batch_size=512
I initially forgot to set data_nb_worker, so it defaulted to 1. I increased it to 8 and found no improvement. In both cases, the GPU utility is constantly at only about 25%.
Thanks,
Rene

I don't know out of the mind why the utilization is only 25%. You could use
cProfile or xprof to analyze what is slow.
On Tue, Aug 6, 2019 at 4:14 AM snajder-r<EMAIL_ADDRESS>wrote:

Hi!
When trying to train DeepCpG, on a GPU system, I get very low GPU utility
(approximately 25%). Do you perhaps have an idea what could be the cause? I
tried increasing the number of workers for the data loader, but it didn't
help.
Here are the parameters I have been using:
dcpg_train.py ${mydatadir}/train/* --val_file ${mydatadir}/val/* --out_dir
${mydatadir}/model/ --dna_model CnnL2h128 --cpg_model RnnL1 --joint_model
JointL2h512 --nb_epoch 10 --data_nb_worker 8 --data_q_size 20
--batch_size=512
I initially forgot to set data_nb_worker, so it defaulted to 1. I
increased it to 8 and found no improvement. In both cases, the GPU utility
is constantly at only about 25%.
Thanks,
Rene
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cangermueller/deepcpg/issues/27?email_source=notifications&email_token=ABEVZM23AWYS6HYVMNF6533QDFMHXA5CNFSM4IJVHMYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDTKENQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEVZM6AWOHB6JMZWSZVY7TQDFMHXANCNFSM4IJVHMYA
.

--
Christof Angermueller
<EMAIL_ADDRESS>https://cangermueller.com


We should add a 'What's Happening' page to the Bolt docs

Describe the Change You Would Like
"As a user, it's hard to tell how half-baked features like the new Bolt projects are eventually expected to work, and how I should use them".
We should include a short "developer update" of sorts for various new features. The page should be limited to 10 'features', and updates can be casual and should emphasize that everything in them is subject to change.

Closed by https://github.com/puppetlabs/bolt/pull/2232


Please document which files are belong to which floppy.

Something like:
floppy 1:

io.sys
command.com

floppy 2:

format.com

1UP

Yes, I agree.

Sorry - no plans. Besides which, OEM's governed how MS-DOS 1.25 & 2.0 were delivered on their hardware, and how files were laid-out on media.


Visual Studio compatibility changes

Still needs to handle __builtin_constant_p() somehow, as described in #35

Coverage remained the same at 100.0% when pulling f1d60947a84b52d24124345232ed026d4ee25748 on vscompat into 45bef9208d02618d0af922db6a31a696b1305dab on master.


URL is out of sync in Time Travel mode

Redux DevTools works fine. Time Travel works fine except the URL bar is not changed when we rewind the state.

@dictions I made it as a new issue. We can leave it until there is a real need to use this feature or we can think of some better ways to do it.
I can think of a hacky way by breaking a uni-directional flow in this mode (so I don't want to use it yet). Assume we can check whether we are in time travel mode (not sure it is possible or not). When router state is changed, we push URL directly to history object if we are in the time travel mode. Then, in history.listen callback, we ignore calling props.onLocationChanged if we are in the time travel mode.


Create Jenkinsfile

new file

@sujunquan
Create Jenkinsfile

merge to master

You should test the pipeline in the fork repository
https://help.github.com/en/articles/fork-a-repo


Rename this project to import-map-deployer

sofe has been superceded by import maps, and I'm now encouraging the single-spa community to use this project to manage deployments. As such, I think the name import-map-deployer would be easier for people to remember and understand. Thoughts?
@nhumrich @blittle @TheMcMurder @frehner

Wow....

Done


Remove rand suffix in test job name

Also added possibility to add additional
annotations for test job.

It is bad practice to use random prefix\suffix in name of resources.

helm template is always different, it is pain for linters
it is convenient to search resource by name when use kustomize.

Also added possibility to add additional annotations, for example it is useful when use ArgoCD.

Hello @mustdiechik,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@stylianosrigas could you please have a look too here?


Fix/spawn async

Extend test-suite with test for already merged PR

@facundominguez please check this PR, I've extended commit message and rebased it on the top of the current work.

:+1:
Maybe d-p should have a test suite for internal functions like sendCtrlMsg.

I agree with possible introduction of test in d-p but I'd like to discuss what should be there before.


Support on_schema_change feature on incremental model #3

Currently, dbt-athena does not support on_schema_change option.
Original work done here https://github.com/dbt-athena/dbt-athena/pull/3/files implemented by @hiro-o918

Should we close this ?


Debugging the Base app showing "No content available" message for some objects

Please include the following with each issue:
1. Describe the bug
debugging the base Business Central application, I noticed that the contents of various objects, eg report 7323 in Create Invt Put-away/Pick/Mvmt, are hidden. While stepping into the object instead of showing the code, it opens a file named Mvmt.dal which displays "No content available" message.
I'm trying to create an inventory pick from a PO. I can see the code for page 50 and table 38 but when it gets to the report it seems like it's not allowed to be read.
Lots of other people experienced the same issue. See the comments from April this year on this community link: https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/readiness/readiness-ready-to-go#developing-for-business-central-in-general

2. To Reproduce
set a breakpoint on action("Create Inventor&y Put-away/Pick") on Page 50 and breakpoints in report 7323 and try to create a pick

Go to '...'

AL code snippet that demonstrates the issue or a link to a code repository the developers can easily pull down to recreate the issue locally.

Note: Because the developers need to copy and paste the code snippet, including a code snippet as a media file (i.e. .gif) is not sufficient.
3. Expected behavior
expecting to be able to view all code from report 7323
4. Actual behavior
A clear and concise description of what happened accompanied by images, animations, or a link to a video showing the issue occurring
5. Versions:

AL Language: 11.0.787898
Visual Studio Code: Version: 1.77.3 (user setup)
Business Central: 21.5.53619.53813
List of Visual Studio Code extensions that you have installed: What's the easiest way to get this list? it will take me all day to type them all up.

Final Checklist
Please remember to do the following:

[ ] Search the issue repository to ensure you are reporting a new issue

[ ] Reproduce the issue after disabling all extensions except the AL Language extension

[ ] Simplify your code around the issue to better isolate the problem

I am experiencing the exact same problem when trying to debug page 408.
As an additional information I have the same problem when trying to view the source code from the new AL Explorer in VS Code for page 408 og report 7323, while it works fine for other objects.

This issue misses the information mentioned in the template. To help us get to the issues faster you must provide all the information in the template.
Please provide the following info
AL Extension version
Server extension version

AL Extension: 11.0.787898
Server: BC Saas Sandbox 22.0.54157.54644

This issue misses the information mentioned in the template. To help us get to the issues faster you must provide all the information in the template.
Please provide the following info AL Extension version Server extension version

AL Extension: 11.0.787898
Server: BC Saas Sandbox 21.5.53619.53813

It seems to be related to slashes included in the object name, at least that's my guess ...

Who's going to fix it I wonder? I logged a case with Microsoft and they referred me here :)

I was debugging OnPrem BC ver 19 today and I got the same issue so the BC version is not the culprit here.  It seems that @fvet was right. I'm getting No content avail for any objects with / in their name.   AL Extension is 11.0.787898 and VSC is 1.77.0

It seems to be related to slashes included in the object name, at least that's my guess ...

Then this is related, it seems
https://github.com/microsoft/AL/issues/7369

This is actually something on the VSCode side. I've raised the issue with them, but I'll ping them again.
https://github.com/microsoft/vscode/issues/172108

This is still an issue also for "Inventory Posting To G/L" and the report 1002 "Post Inventory Cost to G/L".


runscript is not working

Hi,
runscript is not working, giving argv error, Even if I am trying "runscript -CloudFile="test1" ", then it's returning True, but Nothing happens on the actual machine.
runscript  c:\windows\system32\wusa.exe "c:\windows10.0-kb4538461-.msu" /quiet /norestart
Host ID : ******
Complete: False
Stdout  :
Stderr  :
Errors  : [{'code': 40012, 'message': 'Max args is 0. 4 were provided'}]

RTR session started...
type 'bulk ' to execute multiple commands
(type exit to end) > runscript -CloudFile="test1"
Host ID : *************
Complete: True
Stdout  :
Stderr  :
Errors  : []
nothing happens on actual server

Hi,
I verified and had no issues using the runscript command from my end. Following are a couple of things you can try to troubleshoot this

Use this command instead: runscript -CloudFile="test1" -CommandLine=""
Try running the same scripts using RTR feature in CrowdStrike Falcon console to verify that the scripts perform as intended

It's not giving argument error if I am using with -ComandLine switch, and giving True but actually not executed on the machine.
(type exit to end) > runscript -CommandLine="c:\windows\system32\wusa.exe c:\test.exe /quiet /norestart"
Host ID : *************
Complete: True
Stdout  :
Stderr  :
Errors  : []
--
Is there any switch that can refresh/extend the token time? If put command is taking time, then the connection get break after 590 seconds.
{'code': 50401, 'message': 'Exceeded maximum read timeout: 590.00s'}

Unfortunately, 600 seconds is the hard limit set by CrowdStrike for the duration of script execution. I don't think there is any way to bypass that.

As for the runscript error that returns True without execution, pls verify that the runscript command can be successfully executed via CrowdStrike RTR console.

There is an API Endpoint to refresh to keep the session active, I am wondering how to add this.
Roughly every 5 minutes, refresh your Real Time Response session using POST /real-time-response/combined/batch-refresh-session/v1
Every 5 minutes, make a POST /real-time-response/entities/refresh-session/v1 request to keep your session active.
As in the Falcon console, a Real Time Response session automatically ends after 10 minutes. We recommend sending a refresh request every 5 minutes to maintain your connection.

That wasn't implemented perfectly in BulkStrike. It only refreshes the session as necessary when a new command is executed. Hence, if your script command had been running for 10 mins, the session would timeout as well.
However, this wouldn't matter as CrowdStrike does not allow scripts to be executed for more than 10 mins. Even if refresh session was implemented perfectly, your script would still had been terminated prematurely by CrowdStrike as it had exceeded the maximum script execution duration of 10 mins.
Refer to https://www.reddit.com/r/crowdstrike/comments/dyd7o2/rtr_timeout/ for workarounds.

Thanks, yeah it worked, Nice one


Add Environment Filter to artifactory_repositories Data Source

Is your feature request related to a problem? Please describe.
I'm writing custom granular platform permissions and using an artifactory_repository data source to pull in a list of repositories I can then prune. I have implemented a custom environment with remote repositories exempt from our Xray policies specifically for security exceptions that I do not want to be included in the platform permission. The only solution to prune these repos from the repository list seems to be a semantic naming convention.
Describe the solution you'd like
I would like the artifactory_repository data sources to support environments specifically, but more broadly all "compile-time" (plan) repository attributes as suitable filter criteria. Accepting lists as inputs would also be a nice QoL improvement, i.e. environments = ["DEV", "PROD"] would be a list of all repos that are either in DEV or PROD.
Describe alternatives you've considered
As stated earlier, I've devised a semantic naming convention, which gets the job done but is implicit and not self-documenting.  The solution is a for loop with an if !endwith(repo.key, "-deferral"). This works but would require extra intermediate lists if I wished to prune the repo list by additional criteria.

@eelginUPS Thanks for the suggestion. However, the Artifactory API currently does not support environment as a query parameter. The API response also does not contain environment so the provider also can't filter after retrieving the data.

This can probably be implemented by using the project provider, since environment is a project related concept and not an artifact concept, although I defer to @alexhung on this since I am just a lurker and not a maintainer.
So, if you have datasource_project and then apply a filter here, you could get all repos from all projects with a filter of DEV. The implementation though would be in the project provider and not the artifact provider.
Thoughts @alexhung ?

I guess there is some confusion around how the providers are separated as it seems inconsistent. project_environment and project_key' are both repository properties, yet project_keyis technically deprecated and the use of the project_repository is recommended. However, theproject_environment` attribute only exists in the artifactory_repository, not the project_repository resource, and depends on a repository already being assigned a project.
As an end user, it seems that the artifactory_repository data source should have most/all artifactory_repository attributes available to be used as a filter.
Also, if you want to have a project provider with a project_repository resource that applies project attributes to existing repositories, it should be used to apply all project attributes.

Your confusion is understandable. I originally prototyped the implementation for the project provider. The concept of an environment only exists in the scope and context of a project. If you don't have project support in your version of artifactory no amount of cleverness is going to get you all the 'DEV' repos

In theory, we can fetch all repository info (based on the existing filters), then fetch the configuration for each repos in the list separately, then filter the result on the provider side.
This is obviously not a scalable solution. Just putting it out there as a thought experiment.

@alexhung Thanks for the update. Like I said: defer to you. So, this can be implemented, as you mentioned @alexhung by a repository wide search. Usage of go routines to parallelize this definitely help with performance.
As an aside @eelginUPS - I put together this script that demonstrates is:
curl -snLf https://myartifactory/artifactory/api/repositories |
    jq -re '.[].key' |
        xargs printf 'https://myartifactory/artifactory/api/repositories/%s\n' |
            xargs -n 10 -P 10 curl -snlf |
                jq -sre '
                    map(select(.environments?|length > 0)) |
                    map(
                        select(.environments | contains(["DEV"]))
                    )'

This will spawn 10 threads and fetch 10 resources at a time.
Depending on how you want to scale this (client side, server side), the parallelism is an option:
Since this is a request coming long long after the maturity of the provider, it seems to me that it's not a feature request likely to be abused.
Would a brute force implementation be a welcome contribution @alexhung ? Using go routines?

@chb0github We need a way to control the Go routine API request rate, as to not trip the rate limiter on the platform.
Combine with appropriate warnings in documentation, I think this is doable.
The ideal solution is still for the API to include environments as a filter so the load is handled server side 😄

Agreed @alexhung , but you know how long that could take 😁
Let me investigate if there is anyway to do the equivalent of a thread pool in go

@eelginUPS what sort of syntax/hcl are you thinking? Sketch out what you had in mind

@alexhung can you supply a sketch of the syntax you/he had in mind?

For the record, the above is able to fetch and filter, through brute force, 154 repositories in under 2 seconds:
time curl -snLf https://myartifactory/artifactory/api/repositories | jq -re '.[].key' | xargs printf 'https://partnerenttest.jfrog.io/artifactory/api/repositories/%s\n' | xargs -n 10 -P 10 curl -snlf | jq -sre 'map(select(.environments | contains(["DEV"])))' > /dev/null
curl -snLf https://myartifactory/artifactory/api/repositories  0.02s user 0.01s system 3% cpu 0.928 total
jq -re '.[].key'  0.00s user 0.00s system 0% cpu 0.928 total
xargs printf   0.00s user 0.00s system 0% cpu 0.940 total
xargs -n 10 -P 10 curl -snlf  0.18s user 0.18s system 18% cpu 1.935 total
jq -sre 'map(select(.environments | contains(["DEV"])))' > /dev/null  0.02s user 0.01s system 1% cpu 1.935 total

@alexhung how would the current -parallel in tf assist or hinder this?

can you supply a sketch of the syntax you/he had in mind?

@chb0github The data source already has 2 attributes for filtering (repository_type and package_type). Adding a new attribute environments (type schema.SetAttribute) would be consistent.

how would the current -parallel in tf assist or hinder this?

@chb0github For scale testing, I think we need to ensure the instance is healthy even with 5-10k repositories (not uncommon in some of our larger customer installations). Local installation masks a fair amount of network traffic latency, etc. so testing on a SaaS/cloud instance is needed.


Issue: slow update time element widget.

When layers are being displayed and then switching coordinate systems, it takes a long time to update the element widget.

by contrast, the speed is very good in the spatialdata branch

I think it's due to this https://github.com/scverse/napari-spatialdata/blob/e1d308d16a8dcbb7b23de4473de08c1d698b7212/src/napari_spatialdata/_interactive.py#L239
We should pass a list of images to add_image() to make use of the multiscale representation.


Allow custom dimension for uploads to be optional

For: https://trello.com/c/SYgBUl4q/258-develop-an-upload-to-ga-of-link-checker-data
Previous work (seen here: https://github.com/alphagov/govuk_frontend_toolkit/pull/436) has been done to allow us to duplicate the url information we normally store in an event action. We duplicate this info into a custom dimension in order to be able to do a join later within Google Analytics with a custom upload setup to report the status of links.
We weren't able to do the join on the info in an event action, only on a custom dimension.
However, it's been pointed out that the govuk_frontend_toolkit gem is being used for other projects besides gov.uk so would inadvertently use their custom dimension to duplicate this url info, without their approval.
So we've made this behavior optional.
If a custom dimension is not provided, then the behavior is turned off.
Depends on https://github.com/alphagov/static/pull/1192

👌


test: add messaging monitor

Current dependencies on/for this PR:

main

PR #2912   👈

This comment was auto-generated by Graphite.


Excessive startup time (near-hang), then OK

VSCode Version: 1.5.3
OS Version: Win7 Ultimate 32-bit, all Windows updates installed (VMware Fusion 8.5 on OS X 10.11)
Pristine VSCode installation (no extensions installed, default settings)

Symptoms:

On launching, only 2 processes show up: Code.exe without parameters, and the GPU process (running with --disable-gpu to eliminate the latter makes no difference):

No window shows up, and the Code.exe-without-params process is near 100% for ca. 2.5  minutes, with very little memory activity and virtually no IO (the GPU process shows virtually no CPU or GPU activity); the I/O spike and memory increase at the end is when the window finally opens:

Once the window is visible, additional Code.exe processes appear, CPU activity subsides, and things appear to work normally.

@mklement0 does it reproduce with our insider build? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

(I assume you meant https://code.visualstudio.com/insiders.)
Yes, the problem still exists in the latest insider build, with startup times now varying between 1 and 5+ minutes(!).

Does it reproduce when you reload a window? If so we could try to produce a CPU profile maybe?
To create a CPU profile using developer tools in VS Code:

select Help > Toggle Developer Tools
click on Profiles
click the start button
do whatever you need to do to get the CPU spin high
wait for some time (10-20 seconds should be enough)
stop the profiling
click the save button and attach the output file to this issue

Unfortunately, the problem only occurs on startup. If, by contrast, you create a new window after startup has completed (I assume that's what you meant), the problem doesn't occur.

@mklement0 do you have a slow network connection or maybe are offline when you launch it?

No, I can rule that out. It's a VM, but it has a high-speed Internet connection and everything else in the VM works normally; a Windows 10 VM I run in parallel (using NAT in both cases) does not exhibit the problem.

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

This is what I see in the PowerShell console when I start the *.exe directly with --verbose (as opposed to the *.cmd file):
←[93m[main 3:53:41 PM]←[0m Starting VS Code in verbose mode
←[93m[main 3:53:41 PM]←[0m from: c:\Program Files\Microsoft VS Code Insiders\resources\app
←[93m[main 3:53:41 PM]←[0m args: { _: [],
  paths: [],
  performance: false,
  verbose: true,
  debugPluginHost: undefined,
  debugBrkPluginHost: undefined,
  logExtensionHostCommunication: false,
  'new-window': false,
  'reuse-window': false,
  goto: false,
  diff: false,
  extensionHomePath: undefined,
  extensionDevelopmentPath: undefined,
  extensionTestsPath: undefined,
  'disable-extensions': false,
  'open-url': undefined,
  locale: undefined,
  wait: false }
←[93m[main 3:53:44 PM]←[0m IPC#vscode:startCrashReporter
←[93m[main 3:53:44 PM]←[0m IPC#vscode-workbenchLoaded

By contrast, starting the *.cmd file with --verbose shows no output in the developer tools' console at all.
Incidentally, the current insiders build has an extraneous | cat in the *.cmd file, which, while doing no harm, causes an error message to display in the cmd.exe/PowerShell console: The syntax of the command is incorrect.
As an aside, there is no benefit to using call in the *.cmd file; setlocal is automatically scoped to the enclosing batch file, so there's no need to return after invoking the *.exe to make an explicit endlocal call.

@mklement0 weird, on my Windows 7 the output shows up with the help of cat.exe:

Any idea why it would not work for you? Can you share a screen shot when the error shows up for you?
Btw the output does not show anything suspicious to me...

Oops! My bad: I had a broken cat in my %PATH% that preempted the one that comes with VSCode (on a side note: the | cat looks like a no-op - what is its purpose?).
Generally, I would suggest invoking embedded utilities with full paths so as to avoid such situations.
As for the --verbose output looking normal: I forgot to mention (because I only realized right now) that the output doesn't appear until just before the window appears; in other words: VSCode is spinning its wheels at full CPU load for a couple of minutes, then the verbose output appears and the window opens.

Ok thanks, I am out of ideas what this issue could be, sorry.

@mklement0 does it reproduce if you run code --disable-gpu from the command line?

Yes, it does - adding --disable-gpu makes no discernible difference.
To add to the mystery, I'm now seeming similar, but distinct symptoms in a Windows 10 VM (also run in VMware Fusion): startup is fine, but - intermittently - opening another instance - takes far too long and maxes out the CPU.
P.S.: I'm still curious: what's the purpose of the | cat in the startup batch file?

@mklement0 it is needed to get the output to show up when you run from the command line.
I believe this is https://github.com/Microsoft/vscode/issues/13882, lets continue there.


fixed #14

fixed #14 Spacing Issue from the template.
Closed the Html tags on the same line

Tests Failed

Test failed all the times. It's need specific Github token to run and it's only allowed to read that token in my master branch. Don't worry.


Lost alot of sensors, tried reinstalling

I saw the release notes, but i can even measure kW.


REPL Clear Button

Completing the C# Getting started "Hello World!" with my son's Yr6 Class (10/11 year olds) and a suggestion from one of the kids was why is there no Clear button to empty the Editor window?
Suggest this would not be a big one to add, also from another child there is a way to copy the code from the code block using the Copy  button but no Paste button.  I told her she had to type the code which was met with groans...

ping @yunyunyunyun Is this an issue with the REPL engine?

@CliffAgius I agree it's strange that there is no Paste button or Paste option in the right-click menu. As an interim solution Ctrl+V keyboard shortcut might work to paste copied content.

Moved the issue to the more general site feedback repo: https://github.com/MicrosoftDocs/feedback/issues/214


DOC: Add a note on the order of matrix elements of Direction parameter

Triggered by the discussion "Elastix idiosyncracy?", started by Soren Christensen, July 11, 2024, at https://discourse.itk.org/t/elastix-idiosyncracy/7049

For the record, elastix::ResamplerBase::ReadFromFile() did already read the Direction matrix in column-major order with commit 695f922245586d1074ca81c99940c09fb48a4224, "ENH: write result images with correct direction cosines (as in fixed image). Also store direction cosines in TransformParameters file", 19 June 2008:
https://github.com/SuperElastix/elastix/blob/695f922245586d1074ca81c99940c09fb48a4224/src/Core/ComponentBaseClasses/elxResamplerBase.hxx#L329-L332

Just double-checked: a direction matrix for 3D images specified by elastix parameter (Direction v0 v1 v2 v3 v4 v5 v6 v7 v8) will internally be stored in the data buffer of a 3x3 itk::Matrix as { v0, v3, v6, v1, v4, v7, v2, v5, v8 }.

@lassoan I added you as co-author, please check!

For the record, my little test to observe the ordering of matrix elements:
static constexpr unsigned int                       ImageDimension = 3;
itk::Matrix<double, ImageDimension, ImageDimension> direction;

// Create a "flat" array of matrix elements, {1, 2, ..., N}
std::array<double, ImageDimension * ImageDimension> flatArray;
std::iota(flatArray.begin(), flatArray.end(), 1.0);

// Retrieve the elements by a neste for-loop, just like elastix does at:
// https://github.com/SuperElastix/elastix/blob/995f471aeb17929f8c0557135997e78f54326390/Core/Kernel/elxElastixTemplate.hxx#L1081-L1090
for (unsigned int i = 0; i < ImageDimension; ++i)
{
  for (unsigned int j = 0; j < ImageDimension; ++j)
  {
    std::cout << " v" << (i * ImageDimension + j);
    direction(j, i) = flatArray[i * ImageDimension + j];
  }
}

std::cout << std::endl;

for (const double x : direction.GetVnlMatrix())
{
  std::cout << " v" << x;
}

std::cout << std::endl;

Based on https://github.com/SuperElastix/elastix/blob/995f471aeb17929f8c0557135997e78f54326390/Core/Kernel/elxElastixTemplate.hxx#L1081-L1090
Output:

v0 v1 v2 v3 v4 v5 v6 v7 v8
v1 v4 v7 v2 v5 v8 v3 v6 v9

I still wonder, shouldn't "Direction" be documented in "elxResamplerBase.h", if it's actually being retrieved by ResamplerBase::ReadFromFile()...? (It's being used as OutputDirection of its ResampleImageFilter.) But then again, it's also being used for the dummyImage in SimilarityTransformElastix::ReadCenterOfRotationIndex, and for ElastixTemplate::GetOriginalFixedImageDirection.

Related ITK commit: https://github.com/InsightSoftwareConsortium/ITK/commit/a2eccee89a115c5c198a41cb0648f3368fc21eae STYLE: Fixed documentation about the parameters of AffineTransform and Rigid3DTransform. The first parameters are the matrix elements in row-major order an not column-major., Tom Vercauteren, 17 Jun 2009.

I still wonder, shouldn't "Direction" be documented in "elxResamplerBase.h"

Maybe the best could be describe the convention in every method where the user can get or set a direction array, but keep it very short and simple, with a link to more details. Something like "direction: ..., matrix elements in column-major order (conversion may be needed, see details at URL)" .

Going to merge now, but maybe the documentation on Direction and GridDirection should be re-organized somehow, eventually. (Direction is now documented in elastix::TransformBase while it's not specifically used by that base class. On the other hand, GridDirection is documented multiple times, redundantly, for four b-spline transforms.)


i18n

A big thank you for providing this FirebaseUI wrapper, very helpful ❤
Is there a way to specify the locale to enable i18n of the interface? It is possible when using the CDN option. Would love to hear how we can achieve the same with the react wrapper.

Hey @binajmen, i18n/localization is tracked in #21.
This comment describes a potential workaround.


Elements without specified height?

While I like the plugin, I don't understand why you need to set the height for an element - especially the body. It kind of defeats the purpose of using it as a reading indicator, since not all articles are the same length. Isn't there a way to calculate the height of a div/body at page load and use that as a value?

If the page height is 100%, why we would show a scroll progress bar on the page?


Infinite loop when compiling a graph model?

When I build a CNN model using Graph, it takes much more time than a same model built by Sequential to compile. In fact, it never end. I think  the program may fall into an infinite loop, cause by stop the program manually, I always got:
    for i in v.owner.inputs]
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 736, in get_scalar_constant_value
    ret = get_scalar_constant_value(ret)
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 660, in get_scalar_constant_value
    for i in v.owner.inputs]
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 660, in get_scalar_constant_value
    for i in v.owner.inputs]
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 660, in get_scalar_constant_value
    for i in v.owner.inputs]
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 660, in get_scalar_constant_value
    for i in v.owner.inputs]
  File "/usr/local/lib/python2.7/dist-packages/theano/tensor/basic.py", line 660, in get_scalar_constant_value

KeyboardInterrupt
>>>

this is the Sequential model that works, actually it just a copy of the example script "cifar-CNN", except for an extra layer "Dense3D" defined by myself.
def get_sequential_CNN_model(input_shape, N):
    channels, M = input_shape
    l= int(np.sqrt(N))
    model = Sequential()
    model.add(Dense3D((3,N),input_shape=(3,M)))
    model.add(Reshape((3,l,l)))
    model.add(Convolution2D(32, 3, 3, border_mode='same'))
    model.add(Activation('relu'))
    model.add(Convolution2D(32, 3, 3))
    model.add(Activation('relu'))
    model.add(MaxPooling2D(pool_size=(2, 2)))
    model.add(Dropout(0.25))

    model.add(Convolution2D(64, 3, 3, border_mode='same'))
    model.add(Activation('relu'))
    model.add(Convolution2D(64, 3, 3))
    model.add(Activation('relu'))
    model.add(MaxPooling2D(pool_size=(2, 2)))
    model.add(Dropout(0.25))

    model.add(Flatten())
    model.add(Dense(512))
    model.add(Activation('relu'))
    model.add(Dropout(0.5))
    model.add(Dense(10))
    model.add(Activation('softmax'))
    return model

And this is the model that keeps compling....
def get_CNN_model(input_shape, N):
    channels, M = input_shape
    l= int(np.sqrt(N))
    model = Graph()
    model.add_input('input', input_shape=input_shape)
    Dense3D_1 = Dense3D((3,N))
    model.add_node(Dense3D_1,name='dense3D',input='input')
    model.add_node(Reshape((3,l,l)), name='reshape',input='dense3D')
    model.add_node(Convolution2D(32, 3, 3, border_mode='same'),name='conv1', input='reshape')
    model.add_node(Activation('relu'), name='relu1', input='conv1')
    model.add_node(Convolution2D(32, 3, 3, border_mode='same'),name='conv2', input='relu1')
    model.add_node(Activation('relu'), name='relu2', input='conv2')
    model.add_node(MaxPooling2D(pool_size=(2,2)), name='pool1', input='relu2')
    model.add_node(Dropout(0.25), name='drop1', input='pool1')
    model.add_node(Convolution2D(64,3,3, border_mode='same'), name='conv3',input='drop1')
    model.add_node(Activation('relu'), name='relu3', input='conv3')
    model.add_node(Convolution2D(64,3,3, border_mode='same'), name='conv4',input='relu3')
    model.add_node(Activation('relu'), name='relu4', input='conv4')
    model.add_node(MaxPooling2D(pool_size=(2,2)), name='pool2', input='relu4')
    model.add_node(Dropout(0.25), name='drop2', input='pool2')
    flatten1 = Flatten()
    model.add_node(flatten1,name='flatten', input='drop2')

    model.add_node(Dense(512),name='dense1', input='flatten')
    model.add_node(Activation('relu'),name='relu',input='dense1')
    model.add_node(Dropout(0.5), name='dropout', input='relu')
    model.add_node(Dense(10), name='dense2', input='dropout')
    model.add_node(Activation('softmax'),name='softmax',input='dense2', create_output=True)

    return model

Looking for any possible solution, thank you a lot!

To anyone who are interested in this problem:
IT'S NOT A BUG AT ALL!
It takes a long time to compile because it must, as what @pcyin said in [https://github.com/fchollet/keras/issues/666], it takes sevral hours to compile his graph model with many branches....
So I decided to wait for a long time and about 30min later, the model is compiled successfully.

I think we fixed that case in Theano. Be sure to update to Theano 0.8.
Le 10 avr. 2016 10:47, "François Chollet"<EMAIL_ADDRESS>a
écrit :

Also the graph model is getting deprecated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/fchollet/keras/issues/2250#issuecomment-207995266


Add ability to configure remember me cookie as secure and httpOnly.

Add ability to configure remember me cookie as secure and httpOnly. The default values of CookieJar::forever() is kept for backwards compatibility.

This breaks the tests. You also need to update the guard contract. Because of this, this must go to 5.1, not 5.0.

Also these extra boolean parameters in methods go against laravel's ethos of having readable code. It's not immediately clear to users what all these parameters do in their code.

Graham,
It would have been awesome to have been told this when I originally asked about it: https://github.com/laravel/framework/issues/7142
Instead you just closed my question right away. This behaviour is super discouraging.


Focused Weapon Not Working

As the title says, focused weapon seems to not be working. The damage is not shown in the character window and also not added on damage rolls. I have it on two different characters and it works on neither.

Can you give me more context? What weapon, what levels, screenshot, etc. It works in my game when testing.

Correctly working on my pc. Remembering that the dmg is based on fighter's class level, and also that it uses the warpriest dice damage, wich changes over each 5 lvls (commonly lvl5->1d8, lvl10->1d10, lvl15->2d6, lvl20->2d8).
Tested with axe group, throwing group, bow group, close group and hammer group... need more context for shure.

Screenshots provided.
Character has the focused weapon feat, but the damage for it does not seem to show up in the damage window and neither did it when testing when I was in combat. The prerequisites seem to be met. Weapon Focus and Weapon Specialization

At level 6 your weapon damage becomes 1d8 while it is active and that is
what your sheet is showing. This is not extra damage ontop of you normal
weapon damage but is instead a replacement.
On Mon, Jan 17, 2022, 3:09 PM Vexthecollector @.***>
wrote:

Screenshots provided.
Character has the focused weapon feat, but the damage for it does not seem
to show up in the damage window and neither did it when testing when I was
in combat. The prerequisites seem to be met. Weapon Focus and Weapon
Specialization
[image: image]
https://user-images.githubusercontent.com/82162107/149837130-bee25724-237b-450b-9bd8-8a6903bcc57c.png
[image: image]
https://user-images.githubusercontent.com/82162107/149837180-e06ab181-0188-4007-ba67-08cb2a2a790a.png
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/WrathMods-TabletopTweaks/issues/362#issuecomment-1014887195,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPHTPC7IS4KRVFXYXGTUWSARVANCNFSM5MDTD4RA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

:|
Guess I misunderstood. Thank you!


[stable/prometheus-operator] Configurable kubeDns ports

What this PR does / why we need it:
Make the kubeDns exporter ports configurable
Special notes for your reviewer:
Apart from making the ports configurable, it fixes an issue with the last commit where if no service selector is configured for kubeDns then rendering the Chart fails as the evaluation of {{- if .Values.kubeDns.service.selector }} fails for not having the service key defined.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@vsliouniaev just noticed a bug after my PR was merged, I explained it in this PR description. Also used the opportunity to make the kubeDns ports configurable.

/ok-to-test

thx @bismarck

Ready @bismarck

/lgtm

Could you please bump the chart version and we'll re-apply the LGTM label

/lgtm


Fix chunk max age handling

Only close the head chunk if its own first sample is too old, not if the
first sample of the entire series before it is too old.

Approved, but if you want to write a test that'd be awesome.

Won't get to it today, but filed https://github.com/weaveworks/prism/issues/67, which I promise to get to this week :)


Implement LGTM to secure VANotify

As a developer I want to utilize LGTM to identify any security related concerns
Acceptance Criteria:
1. No security related concerns
Given I am deploying VANotify
When I run the pipeline
Then the job successfully completes
2. Security related concerns identified
Given I am deploying VANotify
When I run the pipeline
Then the job fails along with displaying the security related concern(/s)
Notes:
Assumptions:

This involves completing the work identified after the Spike #99 is complete
One card will be created for each tool that we add
Please review the respective ADR for detailed information
During Dev Analysis we need to list what specific security function is covered
Ling's matrix and recommendations documented in this spreadsheet
Discuss where in the pipeline we want to put these security checks, example: is it called from Terraform (this must be finalized in Dev Analysis)
After Dev Analysis or as a part of the kickoff this card will be estimated
Rules used for scanning can be adjusted as part of the implementation

Out of Scope:

Adding monitoring and alerts for this is not in scope
When the tool is successfully implemented, this information must be provided for documentation in the ATO. This will be a separate task not in scope for this card

We'll do a security assessment and create additional tickets as needed.


[Bug] - Resizing the pool causes buggy editor

Describe the bug
When I open a BPMN model in the VS Code Modeler and I want to resize the pool, the behaviour shown in the video occurs.
It can be forced by expanding the pool to the top. Sometimes though, it happens in any given direction.
It was a bit unfortunate to experience this behaviour during a live demo of our VS Code Modeler. 😢
To Reproduce
Steps to reproduce the behavior:

Open a BPMN file in the VS-Code Modeler
Resize the pool in any given direction
If it does not show the behaviour shown in the video redo step 2
See behaviour which is shown in the video

Expected behaviour
Resizing of a pool does not cause the Modeler to reset view point to a white canvas. Editing the size of the pool should be always possible
Screenshots
Video:

Desktop (please complete the following information):

OS: macOS 13.5.2 (22G91)
VS Code Version: 1.82.1
Miranum Modeler: v0.5.3

The bug occurs because of this module.
It is described here

Hey @peterhnm 👋
Thanks for the very fast fix of the problem 🚀
It doesn't crash anymore 👍
But besides, I have found another behaviour related to the viewport, which was a bit unexpected to me:

My expectation would be that the viewport does not change when placing a BPMN-Element on the modelling canvas.
This behaviour can especially be seen when moving only start event on the canvas.
Let me know what you think about this!

I like this behavior because it means less scrolling for me, for example after a resize of a pool.
What do you think about configuring it so that the user can turn this behavior on and off?
Vs Code Setting


Arch Linux example image

Would love to see a sample image for Arch Linux!

Hi @GrabbenD, thanks for opening this feature request. For the time being, we don't have an Arch Linux image planned in our roadmap, but it would indeed be very cool to have an Arch image. I added the appropiate labels, in the hope that someone from the community can pick this up. And if someone does, then a good place to start would be in the build from scratch docs


changes to make it work

see especially demo.md

Thank you! I see that you have used the XML package instead of tm, makes a lot of sense.

sure, hope it gets what you want


improve performance

hoist variables to top
cache array.length
cache document object
reduce filesize

Thanks a lot Marco! 🍻

@MahdiF You are very welcome :)


MES PS5120E no BMS Communication

Hello,
we have Installed MES PS5120E Batterys ( 16S ) the Cerbo detecd this Batery as an Pylontech,
the the Pylontech is an 15S Battery and the MES is a 16S Battery, this is the Problem we have.
We want to in crease the Charge Voltage in the Cerbo.
Please we can we do this?
Or is a other Solution, for this Battery?

Hi
If this battery is detected as a Pylontech, then it is using the standard Victron CANbus implementation and not this serial driver. So  you will have to contact Victron or the battery supplier.
This driver does not support Pylontech batteries.


Collection Metadata Database Column

From #458 we need to add a new database column of metadata = '{}'::json and remove the pedantic Optional to ease migration and prevent conflicts in the future.

For #463 qcfractal/alembic/versions/a2f76bb7be65_updates_collections_table_with_owner_.py add op.alter_column('collection', 'group', nullable=False).

Are you sure the group shouldn't be nullable? It's Optional in our collection datamodel and nullable in the ORM. Also, execute is mispelled in line 22
https://github.com/MolSSI/QCFractal/blob/36352189cb7ec5e91dd8ea15dccf49953d342650/qcfractal/alembic/versions/a2f76bb7be65_updates_collections_table_with_owner_.py#L22

As record @mattwelborn discussed this and we will make the group non-nullable with the current default.


where is the jar?

sorry, I am studing Android ，but I can't find the jar file,thx!

There is no Jar. In Android dependencies are usually not packaged as Jars, because they do not only contain code (class files), but also resources such as images, XML files etc. Instead of manually adding dependencies as files, in Android development dependency management should be automated by using Gradle.
If you are using Android Studio (which I highly recommend), any project you create will contain a Gradle config by default. By declaring dependencies in the build.gradle file, libraries will automatically be added to your project. In case of this library you have to add the following to said file:
dependencies {
    compile 'com.github.michael-rapp:android-bottom-sheet:1.4.3'
}

Got it,thank you.This Project is perfect!

But,  there is a new problem when I use your project  as Library.
When I import the package“import de.mrapp.android.bottomsheet.R”，the  Android Studio hints that can't find R .Look forward to your favourable reply

But you can import the other classes of the library? I can't imagine a reason why you should use the library's R class anyway. Each dependency and your project itself has a own R class. But you should always use the one from your app's package.


Vendor directory affects client library usability

Hi, small feature request. Keeping vendor directory makes client library quite hard to use. For example nat.PortMap creates compile time error.
Best

can you give some more information what exactly you're doing, and what error you get?

In details I'm using github.com/docker/docker/client library in my project.
Im trying to create a container and forward ports. Sadly if i do not remove ./vendor/github.com/docker/docker/vendor from my project ./vendor directory it cant compile. It's because ./vendor/github.com/docker/docker/client imports nat.Port from ./vendor/github.com/docker/docker/vendor/github.com/go-connections/nat while my app has it's own version in ./vendor/github.com/docker/go-connections/nat. Since Go checks type quality based on path nat.Port is recognized as a different type.
Sadly im not able to provide logs atm.

What tool are you using for vendoring? The problem is that that tool appears to use "nested" vendor directories, which is what's causing the problem

glide, but i doubt it has anything to do with it. This is simply how Go works.

You need to use the -v flag with glide so it removes nested vendors, and then vendor those packages into your project.
Closing as this is pretty much expected and is a bug in go that doesn't seem like it will ever be fixed. The solution is to make sure the vendoring tool can strip nested vendors.

Note that this is also a problem when consuming the library with go get.