Model type deepseek_v2 not supported.

I tried using the deepseek-ai/DeepSeek-Coder-V2-Lite-Instruct model and ran into this error:
ValueError: Model type deepseek_v2 not supported.
Any plans to support deepseek_v2 soon?

is this still not supported ??

it is added now this issue can be closed.

While I am trying to port DeepSeek V2, there are a few issues:

Their paper mentions in the MLA attetion only part of the KV cache is cached, but by looking at the model implementation it seems like the entire KV cache is cached. Perhaps I misunderstood either the paper or their implementation code.
The YarnRotaryEmbedding is not supported by MLX, so it may need to be created using base mlx.nn layers.
Unable to find a machine to be able to run deepseek-ai/DeepSeek-Coder-V2-Instruct in fp16, so there is no really good way to test the ported model for it:(

@mzbac  you can try running the lite version, can you share your current code I am as well trying to implement the model.

It seems llama.cpp's implementation also cache the whole KV cache

@mzbac you can try running the lite version, can you share your current code I am as well trying to implement the model.

I have only completed the Rope and Attention modules. The Moe module is partly complete. I will try to combine all the modules tonight and see if I can create a draft PR to share the model.

Very exciting, DeepSeek Coder V2 seems to really good at coding

@awni, I just noticed that the mlx MOE's topk seems to have some issues when the number of experts per token increases. It returns a different topk compared to the PyTorch implementation. I'm not sure if this has something to do with MLX. Here is the test code that you can use to reproduce it. This is currently blocking the deepseek v2 porting since it has a large expert set and tokens per expert.
import torch
import numpy as np
import unittest
import mlx.core as mx

def pytorch_greedy_select(scores, top_k):
    return torch.topk(scores, k=top_k, dim=-1, sorted=False)

def mlx_greedy_select(scores, top_k):
    scores = mx.array(scores)
    idx = mx.argpartition(-scores, top_k-1, axis=-1)[:, :top_k]
    weight = mx.take_along_axis(scores, idx, axis=-1)
    return weight, idx

class TestMoEGatingMethods(unittest.TestCase):
    def setUp(self):
        np.random.seed(42)
        mx.random.seed(42)
        torch.manual_seed(42)
        self.batch_size = 32
        self.num_experts = 8
        self.top_k = 2   # change to 6 the test will fail
        self.np_scores = np.random.rand(
            self.batch_size, self.num_experts).astype(np.float32)
        self.torch_scores = torch.from_numpy(self.np_scores)

    def test_greedy_select(self):
        mlx_weight, mlx_idx = mlx_greedy_select(self.np_scores, self.top_k)
        torch_weight, torch_idx = pytorch_greedy_select(
            self.torch_scores, self.top_k)
        np.testing.assert_equal(mlx_idx, torch_idx.numpy())
        np.testing.assert_allclose(mlx_weight, torch_weight.numpy(), rtol=1e-5)

if __name__ == '__main__':
    unittest.main()

@vovw, here is my porting for DeepSeek-AI/DeepSeek-Coder-V2-Lite-Instruct. However, the MOE doesn't work and I couldn't figure out why. By looking at DeepSeek's implementation, the greedy topk select looks the same as Mixtral MOE but somehow the output doesn't match. I'm not an expert on that so may need some help from @awni.

@awni, I just noticed that the mlx MOE's topk seems to have some issues when the number of experts per token increases.

In general topk should return same indices but they don't have to be in the same order. topk doesn't guarantee that the topk results are actually sorted in MLX.
hough looking at the two implementations they should both be giving sorted results by default (torch takes a sorted kwarg which defaults to True. I ran your test @mzbac and it passes for me. Maybe make sure you are on an up-to-date MLX? pip install -U mlx and try again.

Do you want to send your port so far as a draft PR and we can collaborate on it?

Here is the draft PR https://github.com/ml-explore/mlx-examples/pull/882..

@vovw, here is my porting for DeepSeek-AI/DeepSeek-Coder-V2-Lite-Instruct. However, the MOE doesn't work and I couldn't figure out why. By looking at DeepSeek's implementation, the greedy topk select looks the same as Mixtral MOE but somehow the output doesn't match. I'm not an expert on that so may need some help from @awni.

thanks will look into the implementation.
now we just need to figure out how kv caching is done and greedy topk right ?

@vovw, here is my porting for DeepSeek-AI/DeepSeek-Coder-V2-Lite-Instruct. However, the MOE doesn't work and I couldn't figure out why. By looking at DeepSeek's implementation, the greedy topk select looks the same as Mixtral MOE but somehow the output doesn't match. I'm not an expert on that so may need some help from @awni.

thanks will look into the implementation. now we just need to figure out how kv caching is done and greedy topk right ?

I did some testing for rope and attention implementations. It seems to produce the same output as Deekseek's implementation, but Moe doesn't produce the same output as Deekseek's.

testing for rope and attention implementations. It seems to produce the same output as Deekseek's implementation

how do you test your implementation @mzbac

By the way; just an idea but this specific model size (for most consumer grade hardware) & use-case (i.e. you want your coding assistant to be fast at predicting) would make it a great case for a speculative decoding example.

testing for rope and attention implementations. It seems to produce the same output as Deekseek's implementation

how do you test your implementation @mzbac

Just compare the tensor of each module against the modeling_deepseek.py and MLX implementation. for example
import unittest
import torch
import mlx.core as mx
import mlx.nn as nn
import numpy as np
from pathlib import Path
from safetensors.torch import save_file
import glob

from modeling_deepseek import DeepseekV2Attention as PyTorchDeepseekV2Attention, DeepseekV2Config as PyTorchDeepseekV2Config
from mlx_deepseek_v2_attention import DeepseekV2Attention as MLXDeepseekV2Attention, DeepseekV2Config as MLXDeepseekV2Config

def transfer_weights(pytorch_model, model_path: Path):
    # Save PyTorch weights to safetensor file
    state_dict = pytorch_model.state_dict()
    save_file(state_dict, str(model_path / "model.safetensors"))

def load_mlx_model(model_path: Path, mlx_config: dict) -> nn.Module:
    """
    Load weights from safetensor file and initialize the MLX model.
    """
    weight_files = glob.glob(str(model_path / "model*.safetensors"))
    if not weight_files:
        raise FileNotFoundError(f"No safetensors found in {model_path}")

    # Load weights from safetensor file(s)
    weights = {}
    for wf in weight_files:
        weights.update(mx.load(wf))

    # Initialize MLX model
    mlx_model = MLXDeepseekV2Attention(
        MLXDeepseekV2Config(**mlx_config), layer_idx=0)

    # Load weights into MLX model
    print(weights.keys())
    mlx_model.load_weights(list(weights.items()))

    return mlx_model

class TestDeepseekV2Attention(unittest.TestCase):
    def setUp(self):
        self.config = {
            "hidden_size": 512,
            "num_attention_heads": 8,
            "max_position_embeddings": 2048,
            "rope_theta": 10000,
            "attention_bias": True,
            "q_lora_rank": None,
            "kv_lora_rank": 32,
            "qk_rope_head_dim": 32,
            "v_head_dim": 64,
            "qk_nope_head_dim": 32,
            "attention_dropout": 0.1,
        }
        pytorch_config = PyTorchDeepseekV2Config(**self.config)
        self.pytorch_model = PyTorchDeepseekV2Attention(
            pytorch_config, layer_idx=0)
        self.pytorch_model.eval()

        self.temp_dir = Path("temp_model")
        self.temp_dir.mkdir(exist_ok=True)

        transfer_weights(self.pytorch_model, self.temp_dir)

        self.mlx_model = load_mlx_model(self.temp_dir, self.config)

        torch.manual_seed(0)
        np.random.seed(0)

    def tearDown(self):
        for file in self.temp_dir.glob("*"):
            file.unlink()
        self.temp_dir.rmdir()

    def test_forward_pass(self):
        batch_size, seq_length = 2, 10
        pytorch_input = torch.randn(
            batch_size, seq_length, self.config["hidden_size"])
        mlx_input = mx.array(pytorch_input.numpy())

        pytorch_mask = torch.zeros(batch_size, 1, seq_length, seq_length)
        mlx_mask = mx.zeros((batch_size, 1, seq_length, seq_length))

        print("PyTorch input shape:", pytorch_input.shape)
        print("MLX input shape:", mlx_input.shape)

        with torch.no_grad():
            pytorch_output, pytorch_attn_weights, pytorch_cache = self.pytorch_model(
                pytorch_input, attention_mask=pytorch_mask)

        mlx_output, mlx_attn_weights, mlx_cache = self.mlx_model(
            mlx_input, mask=mlx_mask)

        print("PyTorch output shape:", pytorch_output.shape)
        print("MLX output shape:", mlx_output.shape)

        pytorch_output_np = pytorch_output.numpy()
        mlx_output_np = mlx_output

        np.testing.assert_allclose(
            pytorch_output_np, mlx_output_np, rtol=1e-4, atol=1e-4)

if __name__ == '__main__':
    unittest.main()

This is supported now. Will do a release soon to update the pypi dist.


SAML to prod

No, this does not mean that SAML will immediately be enabled on the prod server.
It only means I can set it up and couple it to the IdP. The actual switching over to SAML will be done through a config change which will then replace the LDAP login button with the SAML login button.

I'd like to propose an alternative:
Do nothing :)
Like you said, the changes that prompt Django's need to create a migration are not actually breaking. (The missing migration won't actually do anything!)
So, it's 100% safe to deploy without said migration.
The other way around: making the migration like you said is not 100% safe. Well, it is for production, but it will break the test server and, more importantly, anyone working from (a branch derived of) develop currently. While obviously those DB's are not holy, I don't think a missing no-op migration really warrants everyone to delete and recreate their DB.
Yes, in a vacuum it's not ideal to have a missing migration, but honestly we've been running prod without this migration for months now. Why invest time in something that does not actually fix anything other than a 'correctness' issue (and that's coming from me), but will break dev environments?

Why invest time in something that does not actually fix anything other than a 'correctness' issue (and that's coming from me), but will break dev environments?

Haha. I can live with doing nothing for the sake of the development servers, but these missing migrations issues have snowballed a bit in the past. Anyone who starts a feature branch off of acc has to think to include the migration manually or we'll be facing an annoying merge with migration re-ordering down the line. Even though the migrations do nothing, Django thinks they are critical. So I do see it as more than just a correctness issue.
But the suggestion to do nothing is a valid one, so I'll change my review to approve this.

Thanks, I'll merge this in a sec.

So I do see it as more than just a correctness issue.

In general, I fully agree! In fact, I'd like to propose adding a new GH workflow that checks if a PR has missing migrations. This would hopefully allow us to catch missing migrations on fix/feature PR's before they even hit one of the main branches.
It's a fairly easy workflow to write, just running manage.py makemigrations --check (the --check will cause the command to return an error code on missing migrations, which will fail the workflow). I'll write a PR for that later today, if that's okay?


Add json serialization tests

Fixes #352 By adding regression tests.
After #995 (Encoding) and #994 (X509Certificate) were resolved the only types left in the config model that can't be deserialized by default are TimeSpan and Version. These are both being fixed in .NET 6 and have easy workarounds so I'm content to leave them.
Marking as draft until I can include the new entries from #997 (Session Affinity cookies).

@Tratcher #997 is merged now, so you can proceed.


Added new devices _TZ3000_upgcbody / TS0207 _TZ3000_mugyhz0q / TS0207 _TZE200_jthf7vb6 / TS0601

Added new device ids and updated readme
Water detector
_TZ3000_upgcbody / TS0207
_TZ3000_mugyhz0q / TS0207
Closes #594, Closes  #587, Closes #568

Tested this change on my homey and the water detector devices worked but not sure why this device type is both a water alarm and a contact alarm since it uses the same sensor to trigger both.

The Water leak sensor tuya did not work. The water alarm isn't triggered in homey.
Just managed to figure out how to build and deploy the app so now time to find out how to debug

Not sure if the sensor code is wrong or this device is not compatible with the other sensor.
From my testing water alarm for _TZE200_jthf7vb6 / TS0601 is reported as dp = 1 and data = 0 not dp = 101 and data = 1

removed _TZE200_jthf7vb6 since not 100% working

Hi All,
Good to see extra sensors that will be available. I have some of them. But maybe I miss something. The app does not seem to be updated. I only see Tuya Zigbee v0.2.18 Experimental in my HP2023. What needs to be done to get the app updated in my system? Am I doing something wrong or do I need to be more patient? Please forgive my ignorance.
Best regards,
Frans

Hi All, Good to see extra sensors that will be available. I have some of them. But maybe I miss something. The app does not seem to be updated. I only see Tuya Zigbee v0.2.18 Experimental in my HP2023. What needs to be done to get the app updated in my system? Am I doing something wrong or do I need to be more patient? Please forgive my ignorance. Best regards, Frans

The repo owner need to merge this PR and create a new testversion  or you need to download the code and deploy it our self to your homey.

Thanks for your quick reply :-)
I hope for the update, I wouldn't know where to start deploying in my own Homey. Don't want to break anything...

Thanks for the extra check with _TZE200_jthf7vb6, I notice this quite often.. devices looking the same but reporting using different data in the datapoint :/
Added the new ID's to next release. Please create a new ticket for _TZE200_jthf7vb6, if this is not already done :)


Build Skeleton React and UI5 Projects

Tutorial URL: https://developers.sap.com/tutorials/luigi-app-basic-setup.html
Please specify the step you are referring to
npm i -P @luigi-project/core @luigi-project/client fundamental-styles fundamental-react @sap-theming/theming-base-content react-router-dom
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/fundamental-react
npm ERR!   fundamental-react@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/i833567/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:

@alexandra-simeonova  Can you respond?

Hello,
This issue is caused by not having the latest npm version installed. (https://www.gitmemory.com/issue/npm/cli/2119/721608949)
Please run npm install npm@latest -g first and try again.
Thank you for checking out the tutorial.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Docs

Pull Request Test Coverage Report for Build 53

20 of 21 (95.24%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 97.727%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

httpbase/client.py
4
5
80.0%

Totals

Change from base Build 45:
-0.3%

Covered Lines:
344

Relevant Lines:
352

💛  - Coveralls


RequestInitCfPropertiesImage missing some types

Hello!
Today I discovered that the RequestInitCfPropertiesImage interface is missing types for the following properties:

[ ] border
[ ] brightness
[ ] contrast
[ ] gamma
[ ] compression

It would also be nice to have exported types for the various union types. For example:
type ImageFormatType = 'avif' | 'webp' | 'jpeg' | 'png' | 'json'
type ImageRotateType = 0 | 90 | 180 | 270 | 360
type ImageFitType = 'scale-down' | 'contain' | 'cover' | 'crop' | 'pad'
type ImageGravityType = 'left' | 'right' | 'top' | 'bottom' | 'center'
type ImageMetadataType = 'keep' | 'copyright' | 'none'
type ImageCompressionType = 'fast'

This would make it easier to cast primitives to the types that RequestInitCfPropertiesImage expects.

I added the following locally to add the missing types in the style of the existing code, though I would like to see the union types exported as their own types as described above.
declare interface RequestInitCfPropertiesImage extends BasicImageTransformations {
   ...existing // The existing definitions on this interface
  /**
   * Adds a border around the image. The border is added after resizing. Border
   * width takes dpr into account, and can be specified either using a single
   * width property, or individually for each side.
   */
  border?: {
    color: string;
    width: number;
  } | {
    color: string;
    top: number;
    right: number;
    bottom: number;
    left: number;
  };
  /**
   * Increase exposure by a factor. A value of 1.0 equals no change, a value of
   * 0.5 darkens the image, and a value of 2.0 lightens the image. 0 is ignored.
   */
  gamma?: number;
  /**
   * Increase contrast by a factor. A value of 1.0 equals no change, a value of
   * 0.5 equals low contrast, and a value of 2.0 equals high contrast. 0 is
   * ignored.
   */
  contrast?: number;
  /**
   * Increase brightness by a factor. A value of 1.0 equals no change, a value
   * of 0.5 equals half brightness, and a value of 2.0 equals twice as bright.
   * 0 is ignored.
   */
  brightness?: number;
  /**
   * Slightly reduces latency on a cache miss by selecting a
   * quickest-to-compress file format, at a cost of increased file size and
   * lower image quality. It will usually override the format option and choose
   * JPEG over WebP or AVIF. We do not recommend using this option, except in
   * unusual circumstances like resizing uncacheable dynamically-generated
   * images.
   */
  compression?: 'fast';
};

Works for me! Thanks Brendan!


Show program leads and assists

Have you thought about a lead / assist report for milestones based on programming? Or a programming report that lists who the leads and assists were for the night?

I have added P/A/L counts to the Attendance report
https://github.com/NomisNostab/Topo/issues/144

Included in v1.35


feat(Topology/MetricSpace): weaker TC assumptions

Assume [WeaklyLocallyCompactSpace α]
instead of [LocallyCompactSpace α]
in 2 lemmas.

bors merge


Optional data argument for gradient and jacobian functions

Would be nice if the gradient and jacobian functions accepted an optional data parameter. The interface would look something like this:
  abstract interface
     function dependent_function (x, data) result (fx)
       import :: var
       type(var), intent(in) :: x(:)
       class(*), optional, intent(in) :: data
       type(var) :: fx
     end function dependent_function
  end interface

A more flexible way to put the dependent function in a module and use whatever the module provides inside the function. This way doesn't require user to unpack data.

But the module approach will make the data global. This makes the code thread-unsafe, if there are work arrays being written to in the data. It also prevents any object/class/type which uses fazang to have multiple different instantiations.

I should've pointed out that fazang itself is not thread safe. Currently one cannot safely call gradient in separate threads. It's planned but not there yet.


Bigger popup

I love this extension!
I would also love the see if the popup was bigger so I could fit more results on the screen. Maybe make it resizable? Or add an option where you can specify how many entries you want to see at once?

Pretty good idea, why not.


Navigation through submenus (Menu/SubmenuTrigger) with key arrows are inverse when the submenu has placement="left"

Provide a general summary of the issue here
It is the horizontal navigation with arrow keys in the menus and submenus that is the problem. My assumption is that it has been developed and tested with the default directions, where it works fine. But when you change the side the popover is displayed on ("left" instead of default "right"), there is no change in behavior of the key arrows. It still follows the right side behavior.
🤔 Expected Behavior?
When opening submenus with arrow keys, the key that opens the submenu should align with the placement of the popover. If the popover is placed to the left, its the left arrow key that opens it and the right arrow key that closes it.
😯 Current Behavior
The current behavior is that popovers placed to the left in a submenu, opens on press of arrow key right, and closes on press of arrow key left.
💁 Possible Solution
Im guessing there are some internal key press logic that can change based on popover placements, for popovers inside a SubmenuTrigger.
🔦 Context
Specifically a menu with a menu item "set status", where the submenu contains three different statuses one can select. The menu trigger is on the right side of the page (settings icon), therefore the submenus needs to expand to the left.
🖥 Steps to Reproduce
Code sandbox
https://codesandbox.io/p/sandbox/priceless-waterfall-c2hwsq
Version
1.2.1
What browsers are you seeing the problem on?
Other
If other, please specify.
Arc
What operating system are you using?
macOS Sonoma 14.1
🧢 Your Company/Team
Propely
🕷 Tracking Issue
No response

I'm not sure if visual placement should have an effect on which key is used based on the ARIA APG. I'll see if I can get some more input on this.

Discussed with @majornista:

No, I don’t think it should change based on the positioning of the menu. The behavior should remain consistent because it is necessary for blind/low-vision users as well as keyboard only users. A good example of this consistency is in the submenus within the Customize and control Google Chrome menu in the upper right corner of the Chrome browser window.

Thanks for creating the issue, it was good to get this clarified!


Error changing material color when adding or removing alpha channel

Hi! I ran into an error trying to change mesh colors on-the-fly, i.e. on a running ,non-blocking window.
>>> # Generate mesh
>>> cube = gfx.Mesh(gfx.box_geometry(200, 200, 200), gfx.MeshPhongMaterial(color="#336699"))
>>> # Add to already being rendered scene
>>> scene.add(cube)
>>> # Changing color like this works like a charm
>>> cube.material.color = gfx.Color("r")

>>> # Now the same thing but we use a (r, g, b, a) color
>>> cube2 = gfx.Mesh(gfx.box_geometry(200, 200, 200), gfx.MeshPhongMaterial(color=(0, 0, 1, .5)))
>>> scene.add(cube2)
>>> cube2.material.color = gfx.Color("r")

Draw error: 0 (57)
No texture to present, missing call to get_current_texture()?

After a bit of experimentation it seems that if the material is initialized with an alpha channel, we break things by trying to assign a color without alpha channel. The other way around causes the same issue. I don't know whether that's expected and/or fixable but perhaps in the first instance the .color setter method could prohibit adding/removing the alpha channel?

Can you share a minimal reproduction script? The error seems to indicate a different cause, so I'd be interested to see how the rest of your code looks.

Sure!
Inipython:
>>> %gui qt6

>>> import pygfx as gfx
>>> from wgpu.gui.auto import WgpuCanvas

>>> canvas = WgpuCanvas()
>>> renderer = gfx.renderers.WgpuRenderer(canvas)

>>> scene = gfx.Scene()
>>> scene.add(gfx.AmbientLight())
>>> scene.add(gfx.DirectionalLight())

>>> camera = gfx.OrthographicCamera()
>>> controller = gfx.TrackballController(camera, register_events=renderer)

>>> def animate():
>>>     renderer.render(scene, camera)
>>>     canvas.request_draw()

>>> # Add a cube
>>> cube = gfx.Mesh(gfx.box_geometry(200, 200, 200), gfx.MeshPhongMaterial(color="#336699"))
>>> scene.add(cube)
>>> camera.show_object(scene)

>>> # After this point the scene is actively rendered
>>> canvas.request_draw(animate)

>>> # Changing color like this works:
>>> cube.material.color = gfx.Color("r")

>>> # Changing color like this breaks
>>> cube.material.color = gfx.Color((1, 0, 0, .1))
Draw error
Traceback (most recent call last):
  File "[...]/python3.11/site-packages/wgpu/gui/_gui_utils.py", line 27, in log_exception
    yield
  File "[...]/python3.11/site-packages/wgpu/gui/base.py", line 135, in _draw_frame_and_present
    self.draw_frame()
  File "<ipython-input-2-abc333fa58e0>", line 15, in animate
    renderer.render(scene, camera)
  File "[...]python3.11/site-packages/pygfx/renderers/wgpu/_renderer.py", line 532, in render
    command_buffers += self._render_recording(
                       ^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]python3.11/site-packages/pygfx/renderers/wgpu/_renderer.py", line 658, in _render_recording
    render_pipeline_container.draw(
  File "[...]/3.11.8/lib/python3.11/site-packages/pygfx/renderers/wgpu/_pipeline.py", line 814, in draw
    pipeline = self.wgpu_pipelines[env_hash][pass_index]
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: 1
No texture to present, missing call to get_current_texture()?

Previously,  had the code for the setup in a module which seems to swallow the detailed traceback and just shows the "No texture present, ..." message. Hope this is more helpful!
PS: this is with pygfx=0.1.18 and wgpu=0.15.0.

Thanks, we'll look into it soon.

The No texture to present, missing call to get_current_texture()? is actually a secondary error/warning message unrelated to the KeyError (the first error messes up the flow so the swap-buffer mechanics warns about the situation)

I think what's going on is that first the meshes are opaque, so no transparency pass is needed. Then the color is changed, making the mesh semi-transparent, so the renderer now needs a pipeline object for the transparency pass, but it does not exist yet.

Thanks for looking into this!
In case that's helpful in homing in on the underlying issue: the same happens when starting with a transparent mesh and changing the color to opaque:
>>> # Using setup from above snippet

>>> # Initialize cube with transparent material
>>> cube = gfx.Mesh(gfx.box_geometry(200, 200, 200), gfx.MeshPhongMaterial(color=(1, 0, 0, .1)))

>>> scene.add(cube)
>>> camera.show_object(scene)

>>> # After this point the scene is actively rendered
>>> canvas.request_draw(animate)

>>> # Change color to opaque
>>> cube.material.color = gfx.Color("b")
Draw error
Traceback (most recent call last):
  File "/Users/philipps/.pyenv/versions/3.11.8/lib/python3.11/site-packages/wgpu/gui/_gui_utils.py", line 27, in log_exception
    yield
  File "/Users/philipps/.pyenv/versions/3.11.8/lib/python3.11/site-packages/wgpu/gui/base.py", line 135, in _draw_frame_and_present
    self.draw_frame()
  File "<ipython-input-2-0f20c2227c86>", line 15, in animate
    renderer.render(scene, camera)
  File "[...]/python3.11/site-packages/pygfx/renderers/wgpu/_renderer.py", line 532, in render
    command_buffers += self._render_recording(
                       ^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]/python3.11/site-packages/pygfx/renderers/wgpu/_renderer.py", line 658, in _render_recording
    render_pipeline_container.draw(
  File "[...]/python3.11/site-packages/pygfx/renderers/wgpu/_pipeline.py", line 814, in draw
    pipeline = self.wgpu_pipelines[env_hash][pass_index]
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: 0
No texture to present, missing call to get_current_texture()?
Draw error: 0 (2)

A nice!  Yes, that's the same problem, except now its the pipeline object for the opaque pass that's missing :)

The cause is pretty clear. The solution ... working on it 😅. Some similar case happens when using vertex colors and changing these from rgb to rgba. Produces a different error though.


Add launch file for pt cloud lsr scan and robot body filter

Adding point cloud to laser scan conversion for navigation purposes. Ability to detect objects which are not vertically uniform such as tables.
Adding robot body filter to point cloud since robot arms will interfere with perception
documentation here: https://bdschnap.atlassian.net/wiki/spaces/FYDP/pages/32079906/Camera+laser+scan+point+cloud+fusion
Packages used: http://wiki.ros.org/pointcloud_to_laserscan http://wiki.ros.org/robot_body_filter

Closing since implemented package needs to be on a branch with sim capabilities and this branch is not of that capability. Branched off of yreda/navigation_bringup at https://github.com/nightingale-project/nightingale/pull/13


Sg/dac

What does this PR do?

This PR incorporates Descript-Audio-Codec in speechbrain.

Before submitting

[ ] Did you read the contributor guideline?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
[ ] Review the self-review checklist to ensure the code is ready for review

Thank you @shubham-gupta-30  for this valuable PR.
Following are some of my comments :

the pre-commit check is failed. You need to follow this doc (https://speechbrain.readthedocs.io/en/latest/contributing.html) to make sure that all the checks are passed. You need to run pre-commit run [your-file] to make sure everything works.
You need to provide a docstring for all your methods(That is why there are some errors in the CI workflow). Also, please check other recipes and provide the docstring in a consistent format.
The docstring of your main model (class DAC(nn.Module) should contain some example. Please refer to this file and follow the same format. (https://github.com/speechbrain/speechbrain/blob/unstable-v0.6/speechbrain/lobes/models/huggingface_transformers/discrete_hubert.py)
The init function of your main module should load the weights. So, when we define the DAC in the hyper-param.yaml file of the recipe, we have a pre-trained model that is ready to be used without the need to call any other function. For example, when we want to define the DAC module in our YAML file, we should be able to pass the   model_type and  model_bitrate, and we get the pre-trained models that the weights are already loaded.
It would be better to have a param called freeze in the DAC module that defines if we want to freeze or fine-tune the model. In our case, I guess we should set freeze to be True, and if it is true all the computation of forward function should be done inside no_grad to be more efficient. You could wrap your forward function with this:  with a torch.set_grad_enabled(not self.freeze):
Right now in both existing discrete models( discrete_ssl and encoded), in the forward/encode function we return the tokens and the embedding. I noticed that the DAC model return more variables. Unless there is a reason for that,  it would be better for all models to have the same returning variables for easier integration across different recipes.
After all these changes, please  follow https://speechbrain.readthedocs.io/en/latest/contributing.html to make sure that all the checks are passed
Thanks for this PR and let me know if you need any help.

Thanks for a detailed review @poonehmousavi
I address all your concerns, please take another look at the PR!
For preloading  DAC through the constructor, I introduced a constructor parameter  load_pretrained which when set to True, a pretrained model is downloaded from the right link. So the easiest way to use the model right now is simply:
model = DAC(load_pretrained=True) and it will load a model based on the default values of otehr params set in the constructor.

@shubham-gupta-30 I reviewed the changes. I left some minor comments, mostly formatting issues. Please apply the changes and re-run all the tests and pre-commit to be sure everything works.

@poonehmousavi  Thanks for the review, I removed the preprocess function entirely. Please take another look!

@shubham-gupta-30 Thanks for the changes. This PR seems fine to me. @mravanelli  Could you please make a final pass?

Thanks @mravanelli  for the review. I addressed all of your comments for the PR. I added runnable examples for all the three major units of DAC - Encoder, ResidualVectorQuantize and Decoder.
I also renamed discrete_tokens to discrete The import statement will now be:
from speechbrain.lobes.models.discrete.dac import DAC
To get rid of the .dac, I will need to create a __init__.py file in the folder, which does not pass the pre commit tests right now as the model is not being used anywhere. I can add this when i add code using this model, and so everywhere we use the model will actually have the import statement you mentioned that is :
from speechbrain.lobes.models.discrete import DAC
Please take another look!

Thank you @shubham-gupta-30 for this PR and @poonehmousavi for helping with the review. I only had to make docstring exampels much smaller to fit them into the CI server.


Run multi-thread tests in spawned processes

Motivation
Our CI sim tests fail at a >90% rate due to a seg-fault see https://github.com/ChainSafe/lodestar/issues/2542. Running the multiple nodes in separate processes instead of separate threads may solve the issue.
Description
Run each node and validator in a separate spawned process

Tracked in https://github.com/ChainSafe/lodestar/issues/4275

Do not delete branch


dodge compact

the "compact" option applies a force simulation after dodge (thus benefitting from a good initial position);

(Not considering this for integration yet, but just to show how we could expand on dodge in the future)

I don’t think we should offer this option as it makes the position encoding inaccurate.

Another drawback is the performance/convergence issue when there are thousands of dots. But I like the aesthetic, and in some cases when the x value is the product of a fuzzy measurement, it doesn't matter that the position is not exact. So, maybe I'll provide this as a plugin :)


Update help.h

hpsjam. Update text in help.h

Patch looks good.
Can you cleanup the commit message?
Just write:
hpsjam. Update text in help.h
And I'll merge it!
Thank you!

And also if possible use (signed off by):
git commit --amend -s

atm I'm not using cli git, only online (learing, so will not be able to do "git commit --amend -s"), sorry

No problem. I'll fix.

Merged manually.


Camera preview

Hi,
Trying to integrate the ring doorbell snapshots with Homebridge. So that I can create a dummy camera that only updates the still image. I found the following in the python-ring:
https://github.com/tchellomello/python-ring-doorbell/pull/108
Looks like it is now possible to download the image so that the above could be possible. Any way to integrate this in the plug-in, or creating a still image source link?

Home assistant has a plugin for ring that has the last video recorded also shows a snapshot hopefully it’s helpful
looking forward to updates :)

This plugin is now DEPRECATED... you will find a vastly superior plugin here!


Merge pull request #1 from microsoft/master

Sync

What is the context for this pull request?

Tracking Issue: If you expect any subjective discussions around this pull request, please consider opening a tracking issue and link to the PR. Write N/A, if this pull request is self-contained.
Parent Issue: Link to the issue that captures the overall plan. Write N/A, if this is a stand-alone pull request with a tracking issue OR self-contained pull request.
Dependencies: Links to issues you depend on for this pull request to work. Write N/A, if no dependencies.

Issue 1
Issue 2

What changes were proposed in this pull request?

Does this PR introduce any user-facing change?

How was this patch tested?

sync with latest changes


index prop required in getItemProps

The Readme mentions that index is optional  parameter in getItemProps.
However omitting index out, leads to error. Checkout https://codesandbox.io/s/rkn35nxjm. Once user types a value into the input field, code throws the error.
Possible fix
Update doc to reflect this behaviour. Happy to send a PR with the change.

Closing because the linked example uses version 1.0.0. index was made optional in 1.2.0. You can get the behavior you want by upgrading.

In that case can we update the example code  & Readme to reflect that update. Latest codebox: https://codesandbox.io/s/3830k2o0yp with updating the dependency.

Nice catch. I've updated it. Thank you!


CouchDB filterParams not working

I'm having exactly the same issue as: https://github.com/couchbase/couchbase-lite-ios/issues/1139
We simply need the ability for CouchDB-based users to be able to set this to false programmatically: https://github.com/couchbase/couchbase-lite-java-core/blob/release/1.3.0/src/main/java/com/couchbase/lite/replicator/ChangeTracker.java#L108
If I were to make a PR for this, would anybody review it?

If I were to make a PR for this, would anybody review it?

Yes, PR is welcome.

I don't see anywhere in the CouchDB docs that mentions filter parameters being used...@hinesmr Could you point that out?

@borrrden It's not used in the POST at all. Only in GET ----- from experience. Not the docs.

Ironically, I have the same request on .NET (https://github.com/couchbase/couchbase-lite-net/issues/719#issuecomment-242912368) for different reasons -> We should talk about this with the rest of the team.

I hacked it into java and everything worked fine, but I'm not proud of it. Really it should be a library level configurable.


GIVGardens - Collateral page

Great to see it is updated to deposit manage but still it needs improvements:

I think it is better to combine the balance and deposit and how I put tokens on various projects would worth having it all together in one place.
I think this can be visual without description: with a donut chart (locked and unlocked amount)

Agree, we need to do a redesign here. Something to consider for a v2


Create PDF in this modal

Please, give  a tutorial to open pdf in this modal. Now, I use yii2-kartik-mpdf

i use https://github.com/Yii2Assets/yii2-pdfjs


Create 02-ajitesh20.md

Hello World code in C language

Hello World code in C programming language
Description

Easily understood
Types of changes

[x] Bug fix or improving code quality
[ ] New language
[ ] New feature

Checklist:

[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly.

"Hello World" code in C programming language


add ruby 2_6_3

Vendoring MRI as the first step to codegenning the stdlib and getting https://github.com/artichoke/artichoke/issues/12 up faster.

@johnwahba once GH-93 lands you should be able to rebase and be all green.

@johnwahba would you mind editing the PR description to explain why we are vendoring MRI? Maybe link to the tracking ticket?

GH-93 is merged.

Thanks @johnwahba. Merged.


adding vyper lexer

adding a lexer for vyper: https://docs.vyperlang.org/en/stable/toctree.html

Thanks for the contribution, but you're missing several things (which is why I'm not even running CI as it'll fail right away):

One example file
The file must adhere to the coding guidelines/format requirements
The lexer is missing an url attribute

You can check this locally using tox, tox -e check, to avoid multiple roundtrips through CI.


Remove duplicate dark mode button which isn't working done ! #750

Remove duplicate dark mode button which isn't working done - #750
Before -

Now -

📄 Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (adds or updates related documentation)

✅ Checklist

[x] I am a participant of GSSoC-ext.
[x] I have followed the contribution guidelines of this project.
[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have added documentation to explain my changes.

Mandatory Tasks

[x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

[x] This PR is submitted under the GSSoC program.
[x] I have taken prior approval for this feature/fix.

@YadavAkhileshh

@YadavAkhileshh

@YadavAkhileshh


query slashing signing-infos: Error: accepts 1 arg(s), received 0

It's not clear what kind of argument this command expects:
$ fxcored query slashing signing-infos
Error: accepts 1 arg(s), received 0
Usage:
  fxcored query slashing signing-infos [flags]

but this works fine:
$ fxcored query slashing signing-infos ""

So if there is no any real argument for this command, it shouldn't error.
Although I'm reading at https://github.com/cosmos/gaia/issues/624 it expects cons_address? However when provided the specific address, the list stays the same.

This is a bug, we have fixed it in 9ba99411061a4926c0892d07aabb4bbb2ae62b23


Improving no results in Workflow D.5 query

https://arax.ncats.io/?source=ARS&id=9b3132c8-58bb-4b4d-933d-73c520a4a7de

{
  "description": "Success. Returning 0 results...",
  "message": {
    "knowledge_graph": {
      "edges": {},
      "nodes": {}
    },
    "query_graph": {
      "edges": {
        "e00": {
          "object": "n01",
          "subject": "n00"
        },
        "e01": {
          "object": "n02",
          "subject": "n01"
        },
        "e02": {
          "object": "n03",
          "subject": "n02"
        }
      },
      "nodes": {
        "n00": {
          "categories": [
            "biolink:ChemicalSubstance"
          ],
          "ids": [
            "DRUGBANK:DB00150"
          ]
        },
        "n01": {
          "categories": [
            "biolink:Protein"
          ]
        },
        "n02": {
          "categories": [
            "biolink:MolecularActivity"
          ]
        },
        "n03": {
          "categories": [
            "biolink:ChemicalSubstance"
          ],
          "ids": [
            "KEGG.COMPOUND:C02700"
          ]
        }
      }
    },
    "results": []
  },
  "validation_result": {
    "message": "",
    "n_edges": 0,
    "n_nodes": 0,
    "size": "2 kB",
    "status": "PASS",
    "version": "1.1.1"
  }
}

We do not model pathways and reactions this way, so we would not expect to get results for this query. Instead, we expect an additional MolecularActivity to be present before n3. This additional node would represent enzymatic activity ( i.e. an EC node).
However, if a canonical way to collapse enzymatic activity and reactions is decided upon, then we may be able to return results for this query.

Agenda item for DM committee.

Discussed in DM call on 22-July-2021.

@suihuang-ISB Out of scope for improving?

Further discussion needed among the team. Check in next week

Returning results


Support single 'Set-Cookie' header via 'setCookie' key in result obj

Implements #47
Enables user to define a single Set-Cookie header in their response object via a setCookie key, which will be defined on headers as Set-Cookie.
Empty setCookie will not add to headers

Only supports a single 'Set-Cookie' as multiValueHeaders is not yet supported in this release.
If we can get multiValueHeaders in I'll implement multiple Set-Cookies.
Also, the assertions I added may not be in the most useful of places, currently we run the setCookie assertion 4 times in the .processResult() tests.

Merged changes by hand


add galler images to vendor, etc

Resolves #62

Feature branch is up on Heroku: https://cincyrefuge.herokuapp.com


Introducing axe-core to cypress for accessibility standards

No jira ref

Cypress updates to introduce axe for a11y checks throughout the different pages

WCAG22AA standard when checking a11y

Pa11y removed

[X] commit messages are meaningful and follow good commit message guidelines

[X] README and other documentation has been updated / added (if needed)

[X] tests have been updated / new tests has been added (if needed)

[ ] Does this PR introduce a breaking change

Do the functional tests fail if there are accessibility issues?
What's happened to the ignored errors we had in pa11y?

Functional tests will fail if any accessibility issues are detected currently. We can view the details via Cypress console to see specifics.
The color-contrast issues we ignored in pa11y aren't being flagged with axe under WCAG22AA


Update AnimatedCounter.tsx

Added fontWeight, padding and class as it was required in a project i was using

Hey @Prajwalmegalamani, thanks for the PR! I'm a little hesitant to simply add a className prop and then have the out-of-the-box styles be fighting against the styles in a given application's stylesheet. What are your thoughts on doing something like adding an optional digitStyles property where a user can pass in CSSProperties type attributes within an object similar to react's native style prop? Let me know your thoughts on these changes in a PR i've pointed toward's your branch https://github.com/Prajwalmegalamani/react-animated-counter/pull/1/files

Hi @TuckerMassad , really appreciate you taking your time, I totally agree with your point, I will look at pr you have raised, Thank you

Hey @Prajwalmegalamani, checking in again here. Looks like the changes I proposed over here weren't actually merged into this PR brach. If you can go ahead and make those updates, i'll make sure to get this merged in! 😄

Hi @Prajwalmegalamani, checking in again on this. I've published a new version of the package that includes two new properties containerStyles & digitStyles. You can use containerStyles to apply any CSS properties you'd like to the component parent element wrapper and digitStyles to apply CSS properties to the digit elements. This should accomplish what you are looking for. Let me know there is anything else on your end that you'd like and I'll go ahead and close out this PR 👍


codecov is being flakey (again)

E.g. see https://github.com/popsim-consortium/demes-python/pull/320/checks?check_run_id=2763665184.
ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')

From my previous investigations, this turned out to be a rate-limiting problem with codecov being denied access to the github API. The previously proposed fix was to either use a codecov access token (supposedly not required for public projects) or to install the codecov marketplace app (which has been done, and is supposedly not required for public projects anyhow).

This seems to have settled down after some upstream codecov action changes.
https://github.com/codecov/codecov-action/issues/330


Add OAI e2e test script to deploy OAI-GNB

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This change include the instructions to deploy OAI gNodeB in core workload clusters
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Close this given that RAN portion will be taken from different place


THANKS!

It may be just a noise, but wanted to say THANKS! for the project. It's a lifesaver! Well structured and well implemented. Thanks! (Feel free to close this anytime.)

Too kind! :) I'm happy it works for your usecase :) If its not too much of a bother could you maybe tell shortly which features you worked with, what worked, what didn't and where the biggest hurdles where? I think this sort of feedback would be invaluable !
No need for polish or kindness, straight  stream of consciousness :)

+1 - this is awesome!


Declarative view events

What is the recommended way to pass events through a declarative view?
vw(CustomerSelector, {
  _events: {
    select: customer => console.log('I am never called from vm.emit')
  }
}),

vw(CustomerSelector, {
  onselect: customer => console.log('Do I put this in the model?')
}, 'key-needed-else-always-remounts'),

Sometimes I use a global state object or sometimes I will pass a model for the view to manipulate vw(CustomerSelector, OrderForm) but there are times when I'd prefer a component that only knows about it's internal state and abstracts underlying input events and exposes it's own set of event handlers.

you can pass extra data through the last opts argument. the full signature is:
domvm.defineView(viewFn, model, key , opts)

currently domvm does reserve diff and hooks [1] in opts that it will auto-process if you wanted to define either of those externally. otherwise you can set custom keys on it and do whatever you need.
another option is to just wrap your model in an ad-hoc object and just provide an explicit key:
if keying by model identity, as would be default without key and wrapper:
vw(CustomerSelector, {model: model, events: ...}, model);

or by some explicit key:
vw(CustomerSelector, {model: model, events: ...}, model.id);

[1] https://github.com/leeoniya/domvm/blob/2.x-dev/src/view/ViewModel.js#L47-L54

@leeoniya how do you feel about changing the model key word to state? I find myself doing model.model a lot.

there's no requirement for the wrapper to have a model key, it's just an example. domvm doesnt care about anything except the identity of the object you pass in and the key. you can have a wrapper {someState: foo, myEvents25: ...} and it'll work fine.
the only place where the literal model exists is vm.model, which you dont ever need to reference because it's passed into the view and render() as an arg, and you can rename that to "state" in your app code if you prefer.
if you're talking more from a documentation / philosophical perspective, i think that "model" is a better fit for domvm since it doesnt advertise itself as a pure/functional solution, although it's easily used this way by simply ignoring the closure state and only ever using the args passed to render().

So, the other option in practice looks like:
vw(CustomerSelector, null, 'still-needed?', {
  onselect: customer => console.log('Called from vnode.opts.onselect?')
}),

I'm referring to a view without any model other than it's own UI state. The example of CustomerSelector might include a list with search functionality. Another example is a PhoneInput that includes a country code selector and number formatter. These views don't manipulate models, they provide abstractions over dumb inputs and events.

@tropperstyle why not just use a template if holding state is not needed?

I think you mean something like:
function customerselect({onselect}) {
  return el('div.customer-selector', [
    // Some form that eventually calls onselect
  ]);
}

Consumed like:
el('div.page', [
   customerselect({
     onselect: customer => console.log('alrighty')
   })
])

So now where do I place my UI state? I can use a closure, but then all instances share the same state, and I need it isolated per instance.
From Sub-views vs Sub-templates:

[vnodes] Can hold data, which can then be accessed from event handlers

So I can initialize private data on the first mount that is accessible during the life-cycle of the vnode? How would I do that with the code above?

I'm referring to a view without any model other than it's own UI state.

if CustomerSelector has no other CustomerSelector siblings, then it will always recycle properly, so you don't need to provide a key in this case. For views that just need some external data i typically do:
vw(CustomerSelector, {
  onselect: customer => console.log('Called from vnode.opts.onselect?')
}, false),

this basically prevents the view from being keyed by the wrapper identity. you can use any static value, it doesn't need to be false ("",0,"blah" will all work fine).

So I can initialize private data on the first mount that is accessible during the life-cycle of the vnode? How would I do that with the code above?

vnodes themselves are destroyed and recreated during each redraw, but they can hold temp data until you redraw:
el("div", { _data: "mooo", onclick: (e, vnode) => console.log(vnode.data) }, "sup");

i think there's enough info here, but feel free to ask for further clarification if needed.

Thanks for the clarification. I haven't found a use case for parameterized handlers nor vnode data, but semi related: how can I clean up an event handler?
_hooks: {
  didInsert({el, data}) {
    data.onclick = function() { };
    el.addEventListener('click', data.onclick);
  },
  didRemove({el, data}) {
    el.removeEventListener('click', data.onclick);
  }
}

This won't work as you stated above, vnodes are recreated each redraw. The only options I can think of is pulling the function up into a closure variable or beefing it up to a subview.

out of curiosity, why aren't you using {onclick: ...}. using hooks this way will be significantly slower.

I updated my previous comment to show more of the desired intent.

you could use a willRecycle hook to do vnew.data = vold.data to transfer it over, but it's unnecessary jumping through hoops that's easily avoided with a subview. i'm also partial to the micro balalaika for jquery-esque dom manip sugar.
here's a quickly-rolled custom dropdown: https://jsfiddle.net/L2sgvvod/
if you're using a much heavier lib like Select2, then YMMV, but since domvm can now ignore foreign elements in its dom ;), you can still append the created wrapper into your own subview rather than <body> globally.

I actually had an example like that originally, but I removed it because I didn't want you to make that leap to hide the event handlers in the sub-view.
Rolling with your example..
el('input', {
  onfocus: => (e, {data}) => { data.dropdown.open() },
  _hooks: {
    didInsert({el, data}) {
      data.dropdown = domvm.createView(Dropdown);
    },
  }
}

There is still a need to access the non-child element from the host event handlers. I think the willRecyle line is what I'm looking for.
Thanks!

it's a rather odd pattern, considering the vm returned by createView holds a partial vtree, which you're storing tangentially on a parent vnode's data. perhaps i'm not understanding the larger context that warrants such an unusual design. i've written pretty complex apps with domvm and never had to do something like this, including transfering over vnode data. any "awkward" code in my domvm apps is almost universally around animations/transitions. i may suggest something else if you can show the fuller use-case.

I build custom UIs with HTML/CSS. Think native feeling, not web standards. I used to use mithril, but 1.0 release was way off the mark for me.
Due to layout limitations, you sometimes cannot have a conceptually related element as a child, or even a sibling.
I added a few lines of CSS to your fiddle to illustrate this:
https://jsfiddle.net/yoqrp6ux/1
So now you must have the dropdown live outside, but it is still managed from a source vnode. Why is storing this on data an odd pattern? Rather than domvm providing some persistent state object, that seems to be opt-in with willRecycle.

Due to layout limitations, you sometimes cannot have a conceptually related element as a child, or even a sibling.

this was actually a core consideration during domvm's design. the conclusion i came to after multiple prototypes is that the least-surprises route is simply not to use declarative views in cases like this. and so, this need is addressed in domvm by either imperative composition, which, i think, is domvm's distinguishing feature; you can inject pre-initialized, partial views into disjoint parts of your templates (or dom mount points) while maintaining isolated redraw control without relying on a global shared state and global redraw.
var el = domvm.defineElement,
    iv = domvm.injectView;

function Dropdown(opts) {
    function InputView() {
        return () =>
            el("input");
    }

    function OptsView() {
        return () =>
            el("ul", opts.map(o =>
                el("li", o)
            ));
    }

    // public api and exposed views for embedding
    const self = {
        open: () => {...},
        close: () => {...},
        redraw: () => {
            for (var name in self.views)
                self.views[name].redraw();
        },
        views: {
            input: domvm.createView(InputView, self),
            opts: domvm.createView(OptsView, self),
        },
    };

    return self;
}

function AppView(vm, state) {
    const myDrop = Dropdown(["A","B","C"]);

    return () =>
        el("body", [
            el("header", [
                "Hello...",
                iv(myDrop.views.input),
            ]),
            el("main", [
                "Options: ",
                iv(myDrop.views.opts),
            ])
        ]);
}

var appView = domvm.createView(AppView).mount(document.body, true);

as a trade-off for giving up declarative view composition, you get shared state without hacks, disjoint and granular redraw control, a user-defined exposed widget API/state. the second example of https://github.com/leeoniya/domvm#hello-world is somewhat like this but exposes a single view from the "component". there's also wiki page (that needs updating to domvm v2) on the flexibility of different patterns. (v1 had JSONML-esque templates, but the semantics remained the same).
anyways, hope that helps or gives you some ideas. regardless, if you found something that works/makes sense for you then go with it :)
[1] https://github.com/leeoniya/domvm/wiki/View-Model-Patterns


[BUG - Question Maybe] - Toolbar is missing

Library version

3.2.2

Describe the bug
When Crop Screen shows up, toolbar is missing and only the picked photo with copper guidelines are available on the screen.
To Reproduce
Steps to reproduce the behavior:

launch the Copper with:
cropImage.launch(          options {              setGuidelines(CropImageView.Guidelines.ON)          }      )
Select a photo or take a picture.
Touch the checkmark
See the crop screen without toolbar

Expected behavior
A Toolbar is needed (with rotate and crop buttons)
Media

Smartphone (please complete the following information):

Device: [e.g. realme 7]
OS: [e.g. Android 11]

Additional context
I'm not sure if this is an expected behavior or a bug.

Hey @TurKurT656 welcome to the lib =D
Do you theme has not action bar? We have this note, maybe help you
<activity android:name="com.canhub.cropper.CropImageActivity"
<EMAIL_ADDRESS><!-- optional (needed if default theme has no action bar) -->

Please let me know if work or not

Sorry my bad. My app was on previous version of Android Image Cropper and because of that I forgot to change the package name to the new one in the manifest. works like a charm :)

Hey @TurKurT656 welcome to the lib =D
Do you theme has no action bar? We have this note, maybe help you.
Add on your manifest:
<activity android:name="com.canhub.cropper.CropImageActivity"
<EMAIL_ADDRESS><!-- optional (needed if default theme has no action bar) -->

Please let me know if work or not

It's working.


Renamed dimention to dimensions

Looks like there was a spelling mistake, I've simply renamed dimention to dimensions

Thanks

👍


still active?

are you guys still accepting pull requests?

+1

+1
I'd like to implement the Minimax search if you're still accepting contributions


Add deb linux target to eletron-builder

Fixes

Checks

[ ] Ran yarn test-build
[ ] Updated relevant documentations
[ ] Updated matching config options in altair-static

Changes proposed in this pull request:

Add support for Linux deb to electron-builder

Hello @dannysofftie thanks for the PR. However the changes here will cause the snap target from being compiled as well. I will need to take a closer look at this to ensure current target configurations aren't affected.

Greatly appreciated. Reach out if you need me to make any changes

I'll probably update this PR with the changes myself

That works for sure. Much appreciated


Provide way to select one of the Recommended Kingdoms

When playing with new people, I often want to use one of the recommended kingdoms.
It'd be awesome if I could select one of these from the site/script, and use it in dominion.games.

Good suggestion. This could either be done with #5 if there’s an easy way to copy those lists, or by adding a fancy dropdown. I’m inclined to the first way to avoid complicating the UI too much.


Use devel repo everywhere, with single point of change

Define MFL copr repo in only 1 place: /Makefile
This modifies everythwere we need MFL_* altered.
Signed-off-by: Nathaniel Clark<EMAIL_ADDRESS>

Codecov Report

Merging #964 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   95.39%   95.39%
=======================================
  Files           2        2
  Lines         152      152
=======================================
  Hits          145      145
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7b698...92646fd. Read the comment docs.

I noticed coverage dropped by 23.12%. Any idea why it dropped so much?

The service tests are looking for:
$ docker exec -i systemd bash -c "./integrated-manager-for-lustre/tests/framework/services/runner.sh"
bash: ./integrated-manager-for-lustre/tests/framework/services/runner.sh: No such file or directory

Which appears to have been renamed to a .in in this patch.


NoMethodError in Applicants#show

Received the following error when clicking "Select Client" on the districthousing.org homepage.
NoMethodError in Applicants#show
Showing /home/jrunning/districthousing/app/views/applicants/show.html.erb where line #98 raised:
undefined method `interval' for #Income:0x000000031d70b0
Extracted source (around line #98):
95
96
97
98
99
100
101
        <%= number_to_currency(income.amount) %>

        <%= income.interval %>

        <%= income.source %>

Rails.root: /home/jrunning/districthousing
Application Trace | Framework Trace | Full Trace
app/views/applicants/show.html.erb:98:in block in _app_views_applicants_show_html_erb__1106361515713071601_87754840' app/views/applicants/show.html.erb:89:in _app_views_applicants_show_html_erb__1106361515713071601_87754840'
Request
Parameters:
{"id"=>"101"}
Toggle session dump
Toggle env dump
Response
Headers:
None

My fault.  I pushed a commit without adding the migration file first.  Fixed now.

No problem, glad to catch these things quick!
--Sent from my mobile device.
On Sun, Feb 8, 2015 at 1:16 AM, Jeff Runningen<EMAIL_ADDRESS>wrote:

My fault.  I pushed a commit without adding the migration file first.  Fixed now.
Reply to this email directly or view it on GitHub:
https://github.com/codefordc/districthousing/issues/220#issuecomment-73398840


Add ability to "refresh" the data from the devtools panel

Some issues wouldn't be as bad (#165 #151 ) if we had a way for the user to manually "refresh" the data in the devtools.
We can use the heroicons reload icon:
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 4v5h.582m15.356 2A8.001 8.001 0 004.582 9m0 0H9m11 11v-5h-.581m0 0a8.003 8.003 0 01-15.357-2m15.357 2H15" />
</svg>

Some suggestions where we could add it (in the tabs, or next to the github icon), there's probably a way to add it in the "components" tab body cc @stephenoldham

Like the idea. As far as where to put it in the UI, I guess it depends on what the refresh is limited to. Are we just refreshing the components or will the refresh also clear any warnings and events in those tabs as well?

Like the idea. As far as where to put it in the UI, I guess it depends on what the refresh is limited to. Are we just refreshing the components or will the refresh also clear any warnings and events in those tabs as well?

Interesting point 🤔 , we could make it so that "refresh" applies only to the current component's data, we would have to rework some of the messaging, guess it would be related to #10


modules: hal: 3rd parties HALs and many different wheel shapes

Problem description

Hello,
I would like to escalate and discuss a problem that arose during the recent ill-fated discussion of the new HAL from Renesas. Specifically, the lack of any requirements for HALs provided by hardware vendors in the form of modules.
Despite the declared goal of avoiding, among other things, the reinvention of the wheel when introducing the modules, we now have a whole set of wheels in different incompatible shapes from various vendors. Or, to put it more seriously, there are some issues that could impact both the current system's stability and performance, and significantly complicate future tree-wide or subsystem-wide changes:

Almost every HAL developer reinvents synchronization primitives. Particularly, interrupts enable/disable functions are being reinvented instead of using the Zephyr's provided irq_lock()/irq_unlock() or spinlocks.

Work queues, semaphores/mutexes and fine grained interrupts locks are rarely used instead of simple global interrupts enable/disable (where possible, of course). However, excessive use of interrupt locks can, in turn, lead to "interesting" consequences, such as hard-to-detect priority inversions. Btw how many vendors actually perform Real Time-related checks?

Each HAL developer uses their own formatting rules, usually undocumented and almost always entirely incompatible with Zephyr's guidelines. As a result, HAL's bug fixes by 3rd party developers (if they will accepted) lead to code that is difficult to read, review and unlikely to pass any automated testing.

Almost each HAL developer uses (if) their own proprietary automated test suites, which are not related to, and unlikely compatible with Twister. As a result, automated test coverage for the customer's system as a whole is likely impossible, making it difficult to evaluate the system's reliability.

Almost each HAL developers reinvent error codes that are incompatible with the error codes used by Zephyr, and the subsequent unnecessary and pointless remapping of errors can significantly impact performance, or mask the real reason of a problem.

...
As a consequence of the above, it is often easier to create a local fork of some parts of the original HAL and bring them into some compatible form with Zephyr (and with Twister) than to reuse it as is. This, in turn, increases the number of new wheel shapes ad infinitum. So we got a situation that is directly opposite to the declared target.
Proposed change

To normalize the current situation to at least a minimally acceptable level, I would like to define some basic requirements for modules supplied by vendors, based on this discussion. We could start with the following:

Vendor-specific synchronization primitives should not be used instead of Zephyr's, unless required by specific hardware characteristics. Also the vendor's code should avoid using any locks whenever possible, leaving synchronization management to the calling side.

Using homebrewed functions for reading from or writing to peripheral registers should not be allowed unless strictly necessary. Zephyr's sys_XXXX functions should be used instead.

Error codes must be identical to Zephyr's ones. In most cases, this can be achieved by simply adding a new header file with code redefinitions in the form of #define VENDOR_ERR_CODE_NAME ZEPHYR_ERR_CODE.

Code style rules should be documented if they differ from Zephyr's guidelines. Or, better, Zephyr's ones should be used instead.

Vendor HALs are often by design OS agnostic as mentioned by @henrikbrixandersen, Vendors have a lot to gain in the lanes of better performance, code size optimization, code reuse, simpler maintenance, CI infrastructure etc. when seen from the perspective of zephyr.
I don't think we should attempt to enforce changes in vendors' downstream HALs to better match zephyr, vendors who wish to support zephyr better will typically opt to adapt their HALs and uses of them to better match zephyr for reasons of the gains mentioned above.


⚠ ClamAV has degraded performance

In cf74245, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 300 ms

Resolved: ClamAV performance has improved in 9e75a14 after 19 minutes.


Create szeitlin.github.io.json

adding my blog and some links to social. Let me know if you want me to delete the ones that are blank or what I should do there.

@szeitlin thanks so much for contributing! 😊
Yes, you're right - you'd need to remove the non-filled rows (so for instance subtitle": "subtitle or tagline", //optional should be removed.
I also think the image URL should be https://girlgeek.io/wp-content/uploads/2020/09/sentry-girl-geek-samantha-g-zeitlin.png (otherwise it won’t be accessible).
I'm not sure but when checking with simple pie it doesn't seem to be able to find your RSS feed. RSS feeds are sometimes tricky and I learnt something about different themes along the way - they are collected here. I think it might be this Hugo theme, so some of the suggestions might be helpful 🙂 Also, with Hugo it’s usually possible to set up categories (or tags, which can be then used for specific RSS feeds). It’d be amazing to have this for your blog feed as well to keep the bot sorted 🙂
Everything else looks great! Thanks so much for taking your time to contribute 🙂

hm. I fixed the json file, and the RSS feed seems fine when I check it. Here's a screenshot of how it looks on simple pie (thanks for that tip btw):

Thanks so much for revising! ☺
I tested the RSS feed and it needs to be https://szeitlin.github.io/index.xml (so the https:// is missing) - if you could change this, I'm very happy to merge it.

updated! Thanks for catching that.

Thanks so much for contributing 🎉


⚠ SceneTime has degraded performance

In a9611b9, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3290 ms

Resolved: SceneTime performance has improved in bc02ec8 after 8 minutes.


"Pocruia" is listed in the drop-down menu

Description:
"Pocruia" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Pocruia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Pocruia, GORJ (TISMANA)".


Add Prettier, Rollup and Docker

Hi @hidarikani,
this seems like a very motivated PR, but also very big - I'm not sure if we actually would want to take it, since it adds a lot more maintenance burden and we don't necessarily recommend using all these tools.
Did you talk with a current maintainer about this (e.g. in an issue) before starting all the work here?

Appreciate that you've put effort into this, but this isn't something we'd want to publish ourselves.


pretrianing or not

i know that FSDA setting need an imagenet pretrained resnet to init
but if the UDG setting need an imagenet pretrained resnet to init or random init?

For UDG we follow the DIUL settings and do not use imagenet pretraining.


Allow the ability to whitelist packages for CVE scans.

Imagine the following use case:

Package X is found vulnerable during the CVE audit.
Upgrading package X imposes a rather large update in the whole OS, so I decide not to upgrade it.
Package X's vulnerability does not affect me very much, in the sense that I can live with it.

Allow me to whitelist package X so that it does not get reported as vulnerable during audits.

Very good use case. I left a comment on your PR -- easy fix and then we'll get it in!

OK, done.


[Doc] Cleanup - delete DEPLOY.md

Minor documentation cleanup - removing old pre-apache docs.

LGTM

Merging as a trivial hotfix


filling in some catty tests

OMG PR DAMIEN!

Coverage increased (+5.7%) to 42.529% when pulling cc403e298b875061a3c7050979177cdf65d7e815 on timczerniak:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.


Create SECURITY.md

A simple instruction for security researchers.

Just wondering: There already is a security section to be found in the README.md. Why is the content in SECURITY.md different? 🙂

There are a few reason for a separate file. If someone had a security-related issue to report, they may not scroll to the bottom of the readme to look for that (and might reach for a SECURITY.md by default). GitHub also used the presence of that file in certain ways, such as showing a link to the file when someone creates a new issue.

There are a few reason for a separate file. If someone had a security-related issue to report, they may not scroll to the bottom of the readme to look for that (and might reach for a SECURITY.md by default). GitHub also used the presence of that file in certain ways, such as showing a link to the file when someone creates a new issue.

Sorry, but I was talking about the content. It's a completely different e-mail address.

Closed by tighten/.github#1 and I'll update the readme to link there instead.


Bumped apt cookbook dependency for 'trusted' apt_repository option to…

apt_repository resource uses 'trusted' option that first appear in apt cookbook of version 2.1.2 (see changelog: https://github.com/chef-cookbooks/apt/blob/master/CHANGELOG.md).
Thus bump of apt dependency in metadata.rb.

:+1: LGTM... thanks for the contribution!


update readme.md.

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #972
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm

/lgtm


Suggestion: Agency Alphabetically

Hi, FOIA Lawya Team,
Thanks so much for all your work on this interface. Love it!
A small suggestion: Is it possible to list the agency names alphabetically or autofill them? The more FOIA we upload, the longer and messier the agency list becomes. (This might also apply to the list of requestors, too).
Many thanks,
Melissa Segura

That's a great idea. Sorting them alphabetically is easy and I'll try to
get to it soon.
If any members of the community want to take on autofill or autocompleting
agency names, it'd be a great first pull request 😀
@melissasegura -- you mention wanting requestor names sorted/autofill too.
Can you tell me more about your use case?
If each user has their own username and logs their own FOIAs, that field
should default to the user's own username. (And I imagined it would be rare
that one user would be entering FOIAs filed by another user.) Is this
feature maybe broken?
In any case, sorting that field should likewise be easy.
Jeremy B. Merrill
Sent from my mobile device
On Aug 31, 2017 4:09 PM, "MelissaSegura"<EMAIL_ADDRESS>wrote:
Hi, FOIA Lawya Team,
Thanks so much for all your work on this interface. Love it!
A small suggestion: Is it possible to list the agency names alphabetically
or autofill them? The more FOIA we upload, the longer and messier the
agency list becomes. (This might also apply to the list of requestors, too).
Many thanks,
Melissa Segura
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/newsdev/foialawya/issues/12, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhdmjcZb67glmh4dTcLTSbD9caHYekHks5sdxLwgaJpZM4PJV_Q
.

Thanks so much, Jeremy!
You're totally right. FOIA Lawya defaults to my name when tracking my FOIAs. I wouldn't want to change that for a second. I was just wondering if it might be wise of list the requestors, the names, in alphabetical order, in the event I'm working with someone else on a project. For example, I might be working with Dan Wagner on investigating Jeff Sessions. Seeing what he's FOIAed is awesome. I can see the day that more and more people contribute to FOIA Lawya, the harder it will be to find Dan's name if it's not ordered in anyway. Does that make sense?
Again, just a suggestion.
Thanks,
Melissa

Hi Melissa,
I'm ecstatic to hear suggestions from users; ecstatic that folks are using FOIA Lawya. (You're at BuzzFeed, yes?)
I may have misunderstood earlier. Are we talking about the list of requests on the front page (that lists all the requests in the organization) or the lists of requestors and agencies on the page where you go to add a FOIA?

I am indeed at BuzzFeed!
If I had to choose, I'd definitely say that alphabetizing the list of
agencies that appear on the "track my FOIA" page would be the top priority.
If I were being greedy, the second, separate request would be to
alphabetize the list of requestors (aka, the person filling out the tracked
FOIA)
Does that make sense?
Many thanks!
Melissa Segura
On Fri, Sep 1, 2017 at 7:56 AM, Jeremy B. Merrill<EMAIL_ADDRESS>wrote:

Hi Melissa,
I'm ecstatic to hear suggestions from users; ecstatic that folks are using
FOIA Lawya. (You're at BuzzFeed, yes?)
I may have misunderstood earlier. Are we talking about the list of
requests on the front page (that lists all the requests in the
organization) or the lists of requestors and agencies on the page where you
go to add a FOIA?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/newsdev/foialawya/issues/12#issuecomment-326586800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeD4PZ4r3ST8am0pJIdCJAgG88F_QLwjks5seA0JgaJpZM4PJV_Q
.

--
Melissa Segura
https://www.buzzfeed.com/melissasegura/detective-guevaras-witnesses?utm_term=.hw3mmb1Ang#.hqk881zDY4
| BuzzFeed News | Reporter |<PHONE_NUMBER> | @MelissaDSegura
111 East 18th St., NY, NY 10003

Hi Melissa,
I think they're both doable (and super easy, I'm pretty sure). I just wanted to make sure that we're talking about the list of requestors _on the "track my FOIA page".

Yes, sir! Thanks much!
On Fri, Sep 1, 2017 at 1:19 PM Jeremy B. Merrill<EMAIL_ADDRESS>wrote:

Hi Melissa,
I think they're both doable (and super easy, I'm pretty sure). I just
wanted to make sure that we're talking about the list of requestors _on the
"track my FOIA page".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/newsdev/foialawya/issues/12#issuecomment-326663354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AeD4PR2DZdxkb5hZgGpfdStB8PAb1Tceks5seFjDgaJpZM4PJV_Q
.

--
Melissa Segura
https://www.buzzfeed.com/melissasegura/detective-guevaras-witnesses?utm_term=.hw3mmb1Ang#.hqk881zDY4
| BuzzFeed News | Reporter |<PHONE_NUMBER> | @MelissaDSegura
111 East 18th St., NY, NY 10003

Totez!

@MelissaSegura Got a preference between sorting on first name or last name (for the requestors)?

I decided to sort by first name, since last name didn't look sorted when I tested it. But if you think last name fits better, let me know, I'm all ears.
This is fixed 9df383e, so you should be able to update your installation and get this fix.


Test Altinn Studio components with design system typography

Description
Before we decide to make the switch to using only typography from the design system, we need to test out how this will look with all the components we now have in our library.
In scope
Testing the components in Altin Studio Komponenter with typography from the Core UI Kit
Out of scope
No response
Additional Information
No response
Analysis
No response
Conclusion
The result from this should be a list of the components and sizes we want to include from the design system.

Testing typography in the Typography sync branch of Altinn Studio Komponenter


Can't add tab without an icon

I get an "Argument null exception" error if I use null as the icon parameter in the FreshTabbedNavigationContainers, AddTab.
If I use whitespace, UIKit.UIImage gives me another error.
The example here uses "null", http://goo.gl/AvlBbO
Maybe it's a change in Xamarin that courses this issue?

Are you using this from nuget?

Yes.

Same problem/issue here

@MBrekhof
The code looks ok and it seems to be working on for me. Can you provide a sample reproduction app?

Hi Michael,
Sorry for not reacting any sooner. It's been kind of busy at the moment.
As for the problem, this code was giving the problem:
public class App : Application
{
public App()
{
FreshIOC.Container.Register<IDatabaseService,DatabaseService>();
var tabbedNavigation = new FreshTabbedNavigationContainer();
tabbedNavigation.AddTab("Inboxen", null);
tabbedNavigation.AddTab("Taken", null);
         MainPage = tabbedNavigation;
     }

However I upgrade to Forms 1.5.1.... (from 1.3.3...) and can not
reproduce the problem anymore ;-).
Not sure if this makes any sense but at least the problem is gone.
While I have your attention: is is possible to programmatically
enable/disable one or more tabs during run-time?
regards
Martin
ps. I really like  FreshMvvm, simple and yet powerfull
Op 20-10-2015 om 12:19 schreef Michael Ridland:

@MBrekhof https://github.com/MBrekhof
The code looks ok and it seems to be working on for me. Can you
provide a sample reproduction app?
—
Reply to this email directly or view it on GitHub
https://github.com/rid00z/FreshMvvm/issues/9#issuecomment-149511874.


Appstudio update test-component-pac-smmm

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-smmm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
13 seconds
init

✅ Succeeded
28 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
28 seconds
sanity-inspect-image

✅ Succeeded
26 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
10 seconds
sanity-optional-label-check

✅ Succeeded
11 seconds
sanity-label-check

✅ Succeeded
10 seconds
show-summary

Pipelines as Code CI/test-component-pac-smmm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
24 seconds
build-container

✅ Succeeded
25 seconds
sanity-inspect-image

✅ Succeeded
25 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
24 seconds
clair-scan

✅ Succeeded
22 seconds
sbom-json-check

✅ Succeeded
13 seconds
sanity-optional-label-check

✅ Succeeded
13 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary


Field Descriptions

This article doesn't explain what each field is. For example, the risk level fields.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6abfd33-5740-865b-24a4-542a989bc399
Version Independent ID: 0139ee02-5fcd-1d2d-800e-d440131348ec
Content: Azure Active Directory sign-in log schema in Azure Monitor
Content Source: articles/active-directory/reports-monitoring/reference-azure-monitor-sign-ins-log-schema.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

@chrisbues Thank you for your feedback! We will review and provide an update as appropriate.

@chrisbues thanks for the feedback.
These are described here. https://docs.microsoft.com/en-us/graph/api/resources/signin?view=graph-rest-1.0
I created a pull request to add this to the document but will leave it to the content author, @MarkusVi , to approve/reject it. https://github.com/MicrosoftDocs/azure-docs-pr/pull/80815


Console being spammed

Describe the bug

This plugin generated a warning from the characteristic 'Brightness': characteristic was supplied illegal value: number 392 exceeded maximum of 100. See https://git.io/JtMGR for more info. being spammed in the console
Steps To Reproduce

I have some kind of lamp that doesnt support the high amounts of brightness/color statuses
Plugin Version

1.0.1
Homebridge Config

{
   "bridge": {
       "name": "Homebridge E7B2",
       "username": "0E:8D:82:07:E7:B2",
       "port": 51404,
       "pin": "715-35-140"
   },
   "accessories": [],
   "platforms": [
       {
           "name": "Config",
           "port": 8581,
           "platform": "config"
       },
       {
           "name": "TuyaWebPlatform",
           "options": {
               "username"<EMAIL_ADDRESS>               "password": "imnotleakingmypassword",
               "countryCode": "xx",
               "platform": "smart_life"
           },
           "defaults": [
               {
                   "id": "bfdf7b1c26cbc45130vyya",
                   "device_type": "light",
                   "light_characteristics": [
                       "Brightness",
                       "Color",
                       "Color Temperature"
                   ]
               },
               {
                   "id": "bf0c14a61a70e85d3fqato",
                   "device_type": "light",
                   "light_characteristics": [
                       "Brightness",
                       "Color Temperature"
                   ]
               },
               {
                   "id": "bf578ad2135ecbe9a060jf",
                   "device_type": "switch"
               }
           ],
           "scenes": false,
           "platform": "TuyaWebPlatform"
       }
   ]
}

Device Config

Additional Context

This issue is currently tracked in https://github.com/milo526/homebridge-tuya-web/issues/158


[SPARK-39022][SQL] Fix combination of HAVING and SORT not being resolved correctly

What changes were proposed in this pull request?
Provide a way to resolve aggregates in Sort nodes if the query also contains HAVING by:

Preventing premature Project nodes before sorting
Allow resolving aggregates in Sort nodes even if there is a Filter node (introduced by HAVING) between the Sort and the Aggregate

Why are the changes needed?
Resolve aggregate correctly in sorting/ordering nodes in plan even if the query contains HAVING.
Does this PR introduce any user-facing change?
Queries that contain aggregates, HAVING, and sorting/ordering should now resolve correctly, and work as expected.
Examples (see SPARK-39022):
SELECT hotel FROM test GROUP BY hotel HAVING sum(price) > 150 ORDER BY sum(price)
SELECT hotel, sum(price) FROM test GROUP BY hotel HAVING sum(price) > 150 ORDER BY sum(price)

How was this patch tested?
Manual testing of examples provided in SPARK-39022.
Additional similar unit tests added in AnalysisSuite.
Run unit test:
$ build/sbt "catalyst/testOnly org.apache.spark.sql.catalyst.analysis.AnalysisSuite -- -z SPARK-39022"

Affected modified tests (see SPARK-39022):
$ build/sbt "sql/testOnly *TPCDSV2_7_PlanStabilitySuite*"
$ build/sbt "sql/testOnly *TPCDSV2_7_PlanStabilityWithStatsSuite*"

Can one of the admins verify this patch?

Can somebody (one of the admins) please give feedback on this patch or verify it?

Can somebody please verify this patch or give feedback on it? (cc @HyukjinKwon from JIRA)


How this repo is related to fused BN in Tensorflow?

How this repo is related to fused BN in Tensorflow? is it doing about the same?
https://www.tensorflow.org/api_docs/python/tf/nn/fused_batch_norm
https://www.tensorflow.org/performance/performance_guide#common_fused_ops
Also maybe from Keras we can export graph to Tensorflow and then freeze it or do even more with TensorRT?

Yes, it's probably the same, but there are not enough details in description.

https://github.com/srihari-humbarwadi/TensorRT-for-keras/blob/master/keras_freeze_model.py
https://github.com/srihari-humbarwadi/TensorRT-for-keras/blob/master/optimize_graph.py
@mrgloom this is something similar to what you were suggesting

Looks like in coreml tools something similar is also implemented
https://github.com/apple/coremltools/blob/da988c683bc466370181e4178b089aa6f07b138f/coremltools/converters/keras/_layers2.py#L502-L522

Yet, another place where similar technique is used
https://github.com/tensorflow/tensorflow/tree/9590c4c32dd4346ea5c35673336f5912c6072bf2/tensorflow/tools/graph_transforms#optimizing-for-deployment
Here it's called batch norm folding.


Fail to configure Novatel gnss in autoware

Fill-out only one section depending on whether you are reporting a bug or a new feature.
Bug

Steps to Reproduce the Problem

Specifications

Ubuntu version:16.04
ROS version:Kinetic
Autoware branch:

New Feature
Describe where the new feature request comes from. Add a high-level diagram of how the new feature should work.

@tsbiosky Autoware use nmea_topic_serial_driver.
So, please check without Autoware.


Remove obsolete change of email on profile page

The change email on the account profile page is out-of-date
and unnecessary.
Changing email should be done using the account page.
Fix #13336
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Another option would be for this page to replicate the options on the account page.

🚀

Codecov Report

Merging #13341 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13341      +/-   ##
==========================================
- Coverage   42.12%   42.09%   -0.03%
==========================================
  Files         689      689
  Lines       75846    75845       -1
==========================================
- Hits        31949    31930      -19
- Misses      38664    38679      +15
- Partials     5233     5236       +3

Impacted Files
Coverage Δ

modules/auth/user_form.go
39.65% <ø> (ø)

routers/user/setting/profile.go
39.88% <ø> (-0.35%)
:arrow_down:

modules/indexer/stats/db.go
52.17% <0.00%> (-17.40%)
:arrow_down:

modules/git/utils.go
73.77% <0.00%> (-3.28%)
:arrow_down:

services/pull/temp_repo.go
26.59% <0.00%> (-3.20%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

services/pull/patch.go
53.97% <0.00%> (-1.71%)
:arrow_down:

modules/queue/workerpool.go
58.77% <0.00%> (-1.23%)
:arrow_down:

modules/git/repo.go
46.19% <0.00%> (-0.51%)
:arrow_down:

modules/process/manager.go
75.00% <0.00%> (+2.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64978d...4c265a4. Read the comment docs.


wrong status thermostats

Describe the bug
Regardless its actual state, home app always shows HEATING, when idle, not heating, or heating.
It will show OFF once switched to OFF
Steps To Reproduce
Set thermostat to lower value than actual temperature
Plugin Version
1.0.2
Homebridge Config
               {
                   "id": "58542378bcddc2408874",
                   "device_type": "climate",
                   "min_temper": "15.0",
                   "max_temper": "25.0"
               }

Device Config
{   'data': {   'current_temperature': 23,
                                                  'max_temper': 35,
                                                  'min_temper': 5,
                                                  'online': True,
                                                  'state': 'true',
                                                  'temperature': 16},
                                      'dev_type': 'climate',
                                      'ha_type': 'climate',
                                      'icon': 'https://images.tuyaeu.com/smart/icon/1522639892fyvv6kiwqyxjbkzjp3rpv6lxr_0.png',
                                      'id': '58542378bcddc2408874',
                                      'name': 'Verwarming'},

I'm currently not able to check, but if I remember correctly this is not something this plugin controls.
I believe that the state is heating if and only if the desired temperature > actual temperature.
Are the temperatures being reported correctly?

The temperatures are reported correctly.
The thermostat either heats (ON), or is OFF... those are the two states in the tuya platform I guess.
But this way it 'heats' a room of 20 degrees to the set 17 e.g. Quite weird.
The plugin reports errors when trying to set on cool or AUTO.
Tuya has also options for  home, away, smart and sleep.
in the developer platform these are the only settings as far as I can find.
Manually setting the JSON 'switch' to false, switches off the thermostat.
temp_set | Integer | {   "unit": "℃",   "min": 5,   "max": 35,   "scale": 0,   "step": 1 }
switch | Boolean | "{true,false}"
child_lock | Boolean | "{true,false}"
temp_current | Integer | {   "unit": "℃",   "min": 0,   "max": 50,   "scale": 0,   "step": 1 }

I’m having the same problem

any fix?


Update live with master

Docs Build status updates of commit 13b5424:
:clock10: Full build: the average full build time is 25 min(s) 10 sec(s), this is based on the last 2 build(s) for this repository.
:warning: This is a FULL build due to a recent Docs Build service upgrade, normally no action is required on your part. In the result you find subsequent builds still performing full builds, please contact your repository admin to manually perform a full build on the 'live' branch. For more detailed info, please click here.

Docs Build status updates of commit 13b5424:
:warning: Validation status: warnings

File
Status
Preview URL
Details

ValidatePublishRequest
:warning:Warning

Details

aspnet-core/xml/Microsoft.AspNetCore.Mvc.Infrastructure/ActionResultObjectValueAttribute.xml
:white_check_mark:Succeeded

ValidatePublishRequest

[Warning-RepositoryOwnerAuthorizedCrendentialInvalid] The owner of the repository https://github.com/dotnet/AspNetApiDocs, 'dotnet-bot' no longer has Admin permission to the repository. This has no impact to published pages or Docs site, but may cause potential issues for repository management. To resolve this issue, please ask anyone of Admin permission of the repo to set a new owner on Docs portal (https://ops.microsoft.com).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[DO NOT MERGE] Adding a comment to check integration testing

This is just testing the integration tests behavior, not intended to be merged.

/ok-to-test


Migrate to Postgres DB

This application currently relies on the Northwest Open Data Exchange's (NODE) CKAN API to fetch the data is consumes.  Since NODE will soon be torn down, we will need to migrate to a Postgres DB that has the PostGIS extension. Things to do:

[x]  research db options (docker, aws, heroku ?)
[ ]  refactor server code / include pg
[ ]  refactor queries to talk to the new db

An alternative to this will be to just use another CKAN instance.

Hey tagging you all here since this is the related issue you have already worked on.
cc @kentpmckinney @wrunion


Backport: Rancher version verification

https://github.com/rancher/rancher/issues/20629

If we add it to 2.2.x, we should merge it after 2.2.5 ships