MODEL_LIST is not accessible in server context so remove check

Fix warning on sass compiler,
MODEL_LIST is not accessible in server context so remove check
Add vs code debug config since most users are using vs code these days
Ignore package-lock.json in case contributor uses NPM instead of PNPM due to crazy windows privileged issues.
NOTE: Only change needed to function is in
app/lib/.server/llm/stream-text.ts
But i made the other changes to clean up NPM and build warnings

fixes issue #249

Thanks for these updates @justindressler! Think you could split the MODEL_LIST fix into a separate PR from the other config changes?

Sure thing. BTW what model do you recommend I tried ollama qwen2.5-coder:7b I had some success but the model wasn't generating fully formatted code. I think the 7b is the biggest I can run the 14b require 4 bit quants which is marginal I prefer 5 bit and up quants. But it did generate a basic project so that is something :)
The PNPM package manager on Windows was giving me alot of headaches I suggest you switch to Yarn or just plain NPM. For open source NPM might be better no one needs to install yarn then.
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Cole Medin @.>
Sent: Saturday, November 30, 2024 9:23:26 AM
To: coleam00/bolt.new-any-llm @.>
Cc: justindressler @.>; Mention @.>
Subject: Re: [coleam00/bolt.new-any-llm] MODEL_LIST is not accessible in server context so remove check (PR #425)
Thanks for these updates @justindresslerhttps://github.com/justindressler! Think you could split the MODEL_LIST fix into a separate PR from the other config changes?
—
Reply to this email directly, view it on GitHubhttps://github.com/coleam00/bolt.new-any-llm/pull/425#issuecomment-2508773979, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETR4LOHP2NOIYNBTBQCF3T2DEHQ5AVCNFSM6AAAAABSPQSUN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYG43TGOJXHE.
You are receiving this because you were mentioned.Message ID: @.***>

MODEL_LIST is not accessible in server context so remove check

I don't think this is right, server can access MODEL_LIST.
can you specify the problem you are trying to fix ?

Im going to retract the pull request i have merged the latest changes and the problem has returned.
APICallError [AI_APICallError]: Not Found     at D:\bolt.new-any-llm\node_modules\.pnpm\@ai-sdk+provider-utils@1.0.20_zod@3.23.8\node_modules\@ai-sdk\provider-utils\src\response-handler.ts:72:16     at processTicksAndRejections (node:internal/process/task_queues:95:5)     at postToApi (D:\bolt.new-any-llm\node_modules\.pnpm\@ai-sdk+provider-utils@1.0.20_zod@3.23.8\node_modules\@ai-sdk\provider-utils\src\post-to-api.ts:81:28)     at OllamaChatLanguageModel.doStream (D:\bolt.new-any-llm\node_modules\.pnpm\ollama-ai-provider@0.15.2_zod@3.23.8\node_modules\ollama-ai-provider\src\ollama-chat-language-model.ts:230:50)     at fn (file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/core/generate-text/stream-text.ts:378:23)     at file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/core/telemetry/record-span.ts:18:22     at _retryWithExponentialBackoff (file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/util/retry-with-exponential-backoff.ts:37:12)     at startStep (file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/core/generate-text/stream-text.ts:333:13)     at fn (file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/core/generate-text/stream-text.ts:414:11)     at file:///D:/bolt.new-any-llm/node_modules/.pnpm/ai@3.4.33_react@18.3.1_sswr@2.1.0_svelte@5.4.0__svelte@5.4.0_vue@3.5.13_typescript@5.7.2__zod@3.23.8/node_modules/ai/core/telemetry/record-span.ts:18:22     at chatAction (D:/bolt.new-any-llm/app/routes/api.chat.ts:73:20)     at Object.callRouteAction (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+server-runtime@2.15.0_typescript@5.7.2\node_modules\@remix-run\server-runtime\dist\data.js:36:16)     at D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:4899:19     at callLoaderOrAction (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:4963:16)     at async Promise.all (index 0)     at defaultDataStrategy (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:4772:17)     at callDataStrategyImpl (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:4835:17)     at callDataStrategy (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:3992:19)     at submit (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:3755:21)     at queryImpl (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:3684:22)     at Object.queryRoute (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+router@1.21.0\node_modules\@remix-run\router\router.ts:3629:18)     at handleResourceRequest (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+server-runtime@2.15.0_typescript@5.7.2\node_modules\@remix-run\server-runtime\dist\server.js:402:20)     at requestHandler (D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+server-runtime@2.15.0_typescript@5.7.2\node_modules\@remix-run\server-runtime\dist\server.js:156:18)     at D:\bolt.new-any-llm\node_modules\.pnpm\@remix-run+dev@2.15.0_@remix-run+react@2.15.0_react-dom@18.3.1_react@18.3.1__react@18.3.1_typ_3djlhh3t6jbfog2cydlrvgreoy\node_modules\@remix-run\dev\dist\vite\cloudflare-proxy-plugin.js:70:25 {   cause: undefined,   url: 'http://localhost:11434/api/chat',   requestBodyValues: {     format: undefined,     model: 'claude-3-5-sonnet-latest',     options: { num_ctx: 32768, num_predict: 8000, temperature: 0 },     messages: [ [Object], [Object] ],     tools: undefined   },   statusCode: 404,   responseHeaders: {     'content-length': '78',     'content-type': 'application/json; charset=utf-8',     date: 'Sat, 14 Dec 2024 06:09:12 GMT'   },   responseBody: '{"error":"model \\"claude-3-5-sonnet-latest\\" not found, try pulling it first"}',   isRetryable: false,   data: undefined,   [Symbol(vercel.ai.error)]: true,   [Symbol(vercel.ai.error.AI_APICallError)]: true }
this is the output i get when selecting Ollama and qwen2.5-coder the code above originally fixed this problem but it has returned the problem in the selected model is not sent to ollama. Instead of 'claude-3-5-sonnet-latest' it should be 'qwen2.5-coder' as selected in the front end i don't have time to trouble shoot the new issue. Maybe later

yes I have seen this issue, this was because server was not able get the dynamic model's list.
i think it is now fixed in a PR @dustinwloring1988 did to get the dynamic model's list working
can you just check once and see if you are still seeing this issue ?

Yep it does seem to work now using latest code main branch. I think there was something strange initially were Ollama and the model was selected but the dropdown under chat had the claude model. But after refresh of browser it worked. I can get coder to write one of the sample apps but the version im running isn't vary smart 🙁

From: Anirban Kar @.>
Sent: Saturday, December 14, 2024 3:31 PM
To: stackblitz-labs/bolt.diy @.>
Cc: justindressler @.>; State change @.>
Subject: Re: [stackblitz-labs/bolt.diy] MODEL_LIST is not accessible in server context so remove check (PR #425)
yes I have seen this issue, this was because server was not able get the dynamic model's list.
i think it is now fixed in a PR @dustinwloring1988https://github.com/dustinwloring1988 did to get the dynamic model's list working
can you just check once and see if you are still seeing this issue ?
—
Reply to this email directly, view it on GitHubhttps://github.com/stackblitz-labs/bolt.diy/pull/425#issuecomment-2542938149, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AETR4LJDABD35NCK25W5DF32FPNGLAVCNFSM6AAAAABSPQSUN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBSHEZTQMJUHE.
You are receiving this because you modified the open/close state.Message ID: @.***>


PropSync is missing but "vue-property-decorator" present

import { PropSync } from 'vue-property-decorator';
@PropSync('currentStep') public step: number = 1;

There is no sync prop in vue3, use v-model instead.


Simplify and improve error handling

This only cleans up some of the internals and avoids some unnecessary function calls.
Running the examples/benchmark-throughput.php script, this change alone increases performance from ~100 MiB/s to ~120 MiB/s on my (rather mediocre) test system, using PHP 7.0.8.
Combined with #53, #54 and #55, it increases performance from ~100 MiB/s to ~2000 MiB/s.
If you want to review, consider looking at the individual commits, this should make the changes pretty obvious.
Marking this as WIP because this will need to be rebased once #52 is in. Edit: done.

Rebased now that #52 is in. Ready for review :shipit:

LGTM :shipit:


Add parameter in the Octokit initialization to support GHES

Hi! We would like to make use of this action, but it won't work with the GitHub enterprise server version:
This initiates an octokit client with the given token. refer here
Octokit is from the @octokit/core and it needs an additional parameter [options.baseUrl] in the Octokit initialization to support the GHES.
Could it be added? Thank you!

Yes, sure, that makes total sense.
I don't have experience with GHES, and I wonder if I can get that URL from the GHA context github.server_url, or if it has to be action input. @Sorana-Maria is it possible to get the GHES URL from github.server_url in your use case? If yes, I could do that internally without adding another user input.

Or maybe it's solved by @octokit/action out of the box, isn't it? I don't know why I am not using that lib instead 😅

There is a new release now https://github.com/Balvajs/delete-stale-branches/releases/tag/v2.1.0, check it out, it should make this work for you 🚀


Add git version conditional for --no-single-branch

On git version 2.32.0 --no-single-branch overrides the --depth setting.
https://git-scm.com/docs/git-clone#Documentation/git-clone.txt---depthltdepthgt
Closes #1120

That is not documented in https://github.com/git/git/blob/master/Documentation/RelNotes/2.32.0.txt. Find the release notes or some issue/ticket/MR that describes this behavior.

See https://github.com/junegunn/vim-plug/issues/864

I would change the PR to add a comment about this in the plugin but the code doesn't have inline comments.


GKE with SharedVPC

Hi,
I've a problem creating GKE cluster with SharedVPC using DeploymentManager. If I'll do manually all works great. All the permissions are setup as specified in the documentation
This is my config:
resources:
- name: gke-tokyo-1
  type: container.v1.cluster
  properties:
    zone: asia-northeast1-a
    cluster:
      name: gke-tokyo-1
      initialClusterVersion: 1.10.4-gke.2
      locations:
      - asia-northeast1-a
      - asia-northeast1-b
      # I've tried with and without 'https://www.googleapis.com/compute/v1/'
      network: https://www.googleapis.com/compute/v1/projects/my-sharedvpc-project/global/networks/net-l2l
      subnetwork: https://www.googleapis.com/compute/v1/projects/my-sharedvpc-project/regions/asia-northeast1/subnetworks/net-l2l-asia-northeast1-10-222-4-0-22
      ipAllocationPolicy:
        clusterSecondaryRangeName: asia-northeast1-gke-pods-1
        servicesSecondaryRangeName: asia-northeast1-gke-services-1
        useIpAliases: true
      addonsConfig:
        horizontalPodAutoscaling:
          disabled: false
        httpLoadBalancing:
          disabled: false
        kubernetesDashboard:
          disabled: true
      enableKubernetesAlpha: false
      legacyAbac:
        enabled: false
      masterAuth:
        clientCertificateConfig:
          issueClientCertificate: false
        username: ''
      masterAuthorizedNetworksConfig:
        enabled: false
      loggingService: logging.googleapis.com
      monitoringService: monitoring.googleapis.com
      networkPolicy:
        enabled: true
        provider: CALICO
      nodePools:
      - autoscaling:
          enabled: true
          maxNodeCount: 3
          minNodeCount: 1
        config:
          diskSizeGb: 20
          imageType: COS
          localSsdCount: 0
          machineType: n1-standard-1
          oauthScopes:
          - https://www.googleapis.com/auth/compute
          - https://www.googleapis.com/auth/devstorage.read_only
          - https://www.googleapis.com/auth/logging.write
          - https://www.googleapis.com/auth/monitoring
          - https://www.googleapis.com/auth/cloud_debugger
          preemptible: false
        initialNodeCount: 1
        management:
          autoRepair: true
          autoUpgrade: true
        name: test

And this is the error:
The fingerprint of the deployment is 7nAEPkF6aMcxaRGKoA7iSA==
Waiting for update [operation-1529481788647-56f0e3ab3e658-00186eb8-5b7b877a]...failed.
ERROR: (gcloud.deployment-manager.deployments.update) Error in Operation [operation-1529481788647-56f0e3ab3e658-00186eb8-5b7b877a]: errors:
- code: RESOURCE_ERROR
  location: /deployments/resources/resources/gke-tokyo-1
  message: '{"ResourceType":"container.v1.cluster","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"message":"must
    use a network belonging to project \"my-service-project\".","status":"INVALID_ARGUMENT","statusMessage":"Bad
    Request","requestPath":"https://container.googleapis.com/v1/projects/my-service-project/zones/asia-northeast1-a/clusters","httpMethod":"POST"}}'

Is not supported this setup in DM?
I've seen that someone with Terraform has had a similar problem (https://github.com/terraform-providers/terraform-provider-google/issues/1532) and was resolved with selfLink.
I underline that I've the same IAM setup as https://github.com/terraform-providers/terraform-provider-google/blob/master/google/resource_container_cluster_test.go#L2129
Thanks

Hi,
When you manually create the cluster, are you using the v1 or v1beta1 cluster API?

Hi,
when I create the cluster manually I'm using the Cloud Console, so i don't know what it use internally.

But I confirm that using v1beta1 cluster API with Deployment Manager I can create a GKE cluster with SharedVPC!
Thanks for the pointer ;)


Upgrade to mechanize 2.8.5

This resolves CVE-2022-31033. Related to #70

Happy to look into these @phillbaker but would you mind verifying that they pass on the master branch? I seem to get the same errors locally before making any changes when using Ruby 3.x.

These appear to be passing on master 😕 I will take a closer look.

@phillbaker I'm unable to reproduce these failures locally even using the same Ruby version and seed. Is there a way I can run these github workflows myself? Can we double-check that they still pass on master?

Thanks, looks like capybara 3.37 was released in may, we'll have to do some updates separately for those new tests. I'll get a release out with this shortly.

Thanks!


Add context example?

I'm trying to use SPF with the built-in Contextualize plugin to add context to my app; specifically I'd like to tie the Sqlalchemy database sessionmaker to the app so anywhere I have the app (I'd like to do this for requests too) I can create a db session. I looked at the Contextualize example but it wasn't clear to me how to add things to the app context (or maybe Contextualize doesn't do that?)

Hi @garyo
The Contextualize is a brand new feature in SPF, only added very recently. I haven't fully thought out the different way users will use it, and I'm aware the single simple example is not very helpful.
I can do some more fully worked examples and so up some documentation for usuage, if it is something that users will want.

@garyo
Ive been thinking about your use case.
Is it critical that you need a context attached to the App object? That's not really how SPF and the Contextualize plugin works.
The way this works is the context you get is attached to the Contextualize plugin, and the plugin is registered against the SPF, and the SPF is installed on the App object.
The context gets automatically injected into the middle eastern handler or route handler where you need it, as seen in the example file. No need to mess around with the App object.
It can do what you want it to do, but it's not quite the same as simply having the context directly on the App object.

Is it critical? I don't know, really -- I'm writing my first Sanic app with a sqlalachemy db, and just trying to figure out the best way to handle the database and its objects I may need at various points in my app (those seem to be: the Engine, the Model base class, and the sessionmaker). Right now I have those as globals in one of my modules, which works, but I was thinking since they're related to the app, and only initialized during app startup, it would be clean if they were attributes of the app somehow.
I've seen that Flask has an app_context where things like this can get stored, and was hoping Contextualize would give me that.
I guess I can just add my own context attribute directly to the app, e.g.
app._app_context = {'db': engine, 'dbsession': sessionmaker(bind=db)}

but that seems dangerous (what if something else wants to use _app_context?) and not that clean, e.g. what if someday app uses slots to prevent random attributes from being attached, or whatever. But maybe that's the best way?

Yes, I understand that is how you want to do it. But as you said, it is not safe and not clean. That is why we don't do it that way in Sanic.
While Sanic is 'Flask-like' in a lot of ways, this is one of the cases where it is quite different. And mimicking the Flask-way and trying to use Sanic as if it was Flask is not a good idea.
The SPF 'shared context' is the closest thing we have a flask-like app_context. That is, it is a context object (a special dict) provided by SPF that all plugins and the app itself can access.
The Contextualize plugin can allow you to use the shared context in your app if you aren't writing your own plugin.
The contextualize example.py file mentioned above does show how to do it, but it may be not very clear.
In the next few days I'll create a specific sqalchemy example that shows exactly how to do what you want, using the Contextualize plugin.

@garyo I realized that I'd forgotten to add the @listener capabilities to the Contextualize plugin.
With version 0.6.3.dev I've now added the @listener functionality to the Contextualize plugin, and I've added an example of how to use it to do what you described above.
https://github.com/ashleysommer/sanicpluginsframework/blob/master/examples/contextualize_sqalchemy_example.py
Let me know if that is what you were looking for.

closed via https://github.com/ashleysommer/sanicpluginsframework/commit/a8b95cc9b57c6e430bd1c82053785a89a687936a

Hi Ashley, yes this looks just like what I need. I think it's best not to create a long-running dbsession for the worker, but just to add the engine and sessionmaker to the app, and then create a dbsession for each request (and similar for websocket requests). But this example now has all the info I need to get that going.

@garyo
Yes, I just took that example code from a sqlalchemy tutorial site and adapted it to make my example. Of course you can take the general idea to do whatever db setup routine you like.
I'm glad to have been able to help you out with your issue.


Can't build; submodule references non-existent commit

»»» Configuring Q³
»»» WARNING: This project is not actively under development
»»» WARNING: This script will build an old Rust version to run Q³
»»» Platform: OSX
»»» Build directory: /Users/ben/play/q3/build
»»» Source directory: /Users/ben/play/q3
»»» Updating submodules
error: no such remote ref 19c3f951efa151292a0d6e07ece41e5528e58863
Fetched in submodule path 'lib/rust-opengles', but it did not contain 19c3f951efa151292a0d6e07ece41e5528e58863. Direct fetching of that commit failed.

I get a slightly different error message, if it helps
»»» Configuring Q³
»»» WARNING: This project is not actively under development
»»» WARNING: This script will build an old Rust version to run Q³
»»» Platform: Linux
»»» Build directory: /home/budkin/Documents/q3/build
»»» Source directory: /home/budkin/Documents/q3
»»» Updating submodules
error: Server does not allow request for unadvertised object 19c3f951efa151292a0d6e07ece41e5528e58863
Fetched in submodule path 'lib/rust-opengles', but it did not contain 19c3f951efa151292a0d6e07ece41e5528e58863. Direct fetching of that commit failed.

Getting a similar error:
»»» Configuring Q³
»»» WARNING: This project is not actively under development
»»» WARNING: This script will build an old Rust version to run Q³
»»» Platform: Linux
»»» Build directory: /home/limeth/workspace/rust/q3/build
»»» Source directory: /home/limeth/workspace/rust/q3
»»» Updating submodules
fatal: reference is not a tree: 19c3f951efa151292a0d6e07ece41e5528e58863
fatal: reference is not a tree: 975d27a098fbf1a1e5a36779dae68e8afdcb8604
Unable to checkout '19c3f951efa151292a0d6e07ece41e5528e58863' in submodule path 'lib/rust-opengles'
Unable to checkout '975d27a098fbf1a1e5a36779dae68e8afdcb8604' in submodule path 'lib/stb-image'

Looks to me like these guys have done a git rebase, so those hashes no longer exist. That's the only way, which comes to mind, that a working and frozen git repo would stop resolving hashes.

Those missing commits are here:
https://github.com/servo/rust-opengles/commit/19c3f951efa151292a0d6e07ece41e5528e58863
https://github.com/servo/rust-stb-image/commit/975d27a098fbf1a1e5a36779dae68e8afdcb8604
Surprisingly both by me. I've repointed them both to master for those repos, but I get warnings when compiling the old Rust compiler on GCC 7.2.0. This would likely require patching either the old Rust code or the build system (to use -Werror=none and -w).
You can more easily debug with this:
diff --git a/configure b/configure
index 25bcaae..7b643ea 100755
--- a/configure
+++ b/configure
@@ -13,7 +13,7 @@
 # and keep the output at bay.
 if [ $# -ne 1 -o "$1" != "quiet" ];
 then
-  $0 "quiet" > /dev/null
+  $0 "quiet" #> /dev/null
   exit $?
 fi

This is what I'm seeing now:
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp: In function ‘tinfl_status tinfl_decompress(tinfl_decompressor*, const mz_uint8*, size_t*, mz_uint8*, mz_uint8*, size_t*, mz_uint32)’:
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp:578:9: error: this ‘for’ clause does not guard... [-Werror=misleading-indentation]
         for ( i = 0; i <= 143; ++i) *p++ = 8; for ( ; i <= 255; ++i) *p++ = 9; for ( ; i <= 279; ++i) *p++ = 7; for ( ; i <= 287; ++i) *p++ = 8;
         ^~~
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp:578:47: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘for’
         for ( i = 0; i <= 143; ++i) *p++ = 8; for ( ; i <= 255; ++i) *p++ = 9; for ( ; i <= 279; ++i) *p++ = 7; for ( ; i <= 287; ++i) *p++ = 8;
                                               ^~~
(cd /home/jeaye/projects/tmp/q3/lib/rust/src/libuv/ && /usr/bin/python2.7 ./gyp_uv.py -f make -Dtarget_arch=x64 -D ninja -DOS=linux -Goutput_dir=/home/jeaye/projects/tmp/q3/build/rust/x86_64-unknown-linux-gnu/rt/libuv --generator-output /home/jeaye/projects/tmp/q3/build/rust/x86_64-unknown-linux-gnu/rt/libuv)
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp: In function ‘void tdefl_find_match(tdefl_compressor*, mz_uint, mz_uint, mz_uint, mz_uint*, mz_uint*)’:
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp:1396:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
     if (!dist) break; p = s; q = d->m_dict + probe_pos; for (probe_len = 0; probe_len < max_match_len; probe_len++) if (*p++ != *q++) break;
     ^~
/home/jeaye/projects/tmp/q3/lib/rust/src/rt/miniz.cpp:1396:23: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
     if (!dist) break; p = s; q = d->m_dict + probe_pos; for (probe_len = 0; probe_len < max_match_len; probe_len++) if (*p++ != *q++) break;
                       ^
compile: x86_64-unknown-linux-gnu/rt/uv_support/rust_uv.o


Add typescript support

Make everything work with .ts files in addition to .js:

[x] index typescript files so they show up in class search
[x] use the custom icons for typescript files in the project tree
[x] can navigate to typescript components from templates

... I think this is all that needs to be done to support typescript. Did I miss something?
/cc @chriskrycho

You're my hero.


Security scan

scan on push, do not save if high vulnerabilities and return 500.
scan on caching, prevent save if issues and return 500.

https://github.com/aquasecurity/trivy/issues/2938


Bosun self metrics zeroed

Many Bosun self metrics are storing only zeros:

bosun.alerts.active_status
bosun.alerts.acknowledgement_status_by_notification
bosun.alerts.last_abnormal_severity

there are probably other metrics doing this as well.
Checking my data history I can see that they were all working in the past and stopped working at the first half of April, so it may be related to the redis stuff

https://github.com/bosun-monitor/bosun/blob/master/cmd/bosun/sched/check.go#L373


Fix bounds

Asserts that cell and frame bounds are kept, clarifies what these bounds mean, and fixes a bug in how many frames are allocated.

Addresses point 5 of #43 .

Exactly. I added a constant to make the code more readable.

The Rust compiler should be able to resolve these constants. There is probably a design guide somewhere that says that magic numbers should be constants.


compute: samples should use accessors

Instead of fetching the fields directly, we should use accessor methods like GetName(), GetMachineType()
For example, in https://github.com/GoogleCloudPlatform/golang-samples/blob/d6e572168a429e67987f6f1046856ff2041c1f24/compute/list_instances.go#L54

Are we sure we want to do this just for compute? I get the argument here since it is a pointer type that needs to be dereferenced, but in general none of our samples use the generated getters. I would say most Gophers are used to working with the structs directly.

An example from secretmanager for instance:
https://github.com/GoogleCloudPlatform/golang-samples/blob/d6e572168a429e67987f6f1046856ff2041c1f24/secretmanager/list_secrets.go#L46-L60

I think it makes sense to do it for all samples for all APIs: using the getters unless we're testing for fields presence explicitly.

If we want to do it for compute I think that is fine, but for non-pointer types the getters don't provide much value imo. Like I mentioned above, I think most people are used to working with struct fields directly and that is the design pattern used by clients that have manual layers built in front of them today. (No getters or setters)
Again from secretmanager:
https://github.com/googleapis/go-genproto/blob/433400c27d0517dc71fad914d494d85afd63c067/googleapis/cloud/secretmanager/v1/resources.pb.go#L186-L191

I think we should at least do it for compute. For other APIs, the advantage of using getters  is that it helps train people to use them in general, so that they're more likely to use them when they do bring some value (like optional fields which have pointer types).
@noahdietz , I know you have some opinions on this as well.

@FrodoTheTrue FYI

Yeah I mean we don't have to change every instance of it everywhere, the primary target is optional fields (which is...every field? in compute) where it is way too easy to deref a nil field.
I understand that most people are probably using direct field access for non-pointers and I guess it's OK, but the "best practice" as documented by the protobuf go folks is to use the getters when possible. Not a hill I will die on here, but there is also the added benefit in using the getter for non-pointer fields in that it protects users from nil deref panics, see here: https://play.golang.org/p/WzS2hdgXo2L
The gettor you mentioned @codyoss handles the case where the pointer receiver is nil and returns "", whereas a direct field access panics. Unfortunately, this surface is rather confusing having both a getter and an exported field.

I guess I am not worried about nil derefs, but I guess it is nice to not have to deref done for users.

The gettor you mentioned @codyoss handles the case where the pointer receiver is nil and returns "", whereas a direct field access panics. Unfortunately, this surface is rather confusing having both a getter and an exported field.

That is true, but in practice will never happen (with this sample or similar code) because the error should be checked before referencing the value. If errors are not checked a lot of Go code would be full of panics as nil refs are generally returned in such cases 😛

That is true, but in practice will never happen (with this sample or similar code) because the error should be checked before referencing the value

Sure, but this also applies to nested messages that are pointer fields & chaining accessors for fields. Like I said, it's a best practice thing, not "the only way." It's a good habit to get into and to share.

I guess I am not worried about nil derefs, but I guess it is nice to not have to deref done for users.

This is very real for optional fields. The field might not be populated in the response. One should either check != nil or use the accessor.

This is very real for optional fields. The field might not be populated in the response. One should either check != nil or use the accessor.

You are right, I take that back for optional fields. If we want to talk about the more general case some more lets add an item to the next Go biweekly. I think this has been a long patten for this repo though to directly access fields. It is too bad the generated getters arn't more idomatic (Not including the word Get)

Was done here: https://github.com/GoogleCloudPlatform/golang-samples/pull/2261


Update typedefRule.ts

PR checklist

[ ] Addresses an existing issue: #0000
[ ] New feature, bugfix, or enhancement

[ ] Includes tests

[x] Documentation update

Overview of change:
Avoid brittle documentation.
Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

Thanks for your interest in palantir/tslint, @bumbleblym! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.


adding abhinav anand name in profile card

Hey @abhinavroy83 !
Thank you for your valuable contribution. As I found, they(Hacktoberfest) are verifying the code in the PR so I recommend that you add your code to a "code folder" as well to avoid any consequences (your code should be in a folder named after you). Sincerely apologize for the inconvenience.


create symbolic link for .oci/config from grafana user

instead of copying the file as the user is expected to do right now

or update Grafana config for oci plugin to refer to ~/.oci


Linux Mono 4.2  and Swashbuckle ->  System.TypeLoadException: Failure has occurred while loading a type.

When trying to run a self-hosted webapi in console project with Swashbuckle that runs well on windows, in linux with mono i get this exception:
I have tried adding the http assembly dependency and neither it works
Exception:
Unhandled Exception:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeLoadException: Failure has occurred while loading a type.
at xxx.Startup.Configuration (IAppBuilder appBuilder) <0x40102a10 + 0x00187> in :0
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x40071370 + 0x000a3> in :0
--- End of inner exception stack trace ---
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x40071370 + 0x000ff> in :0
at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) <0x400ced40 + 0x0002a> in :0
at Owin.Loader.DefaultLoader+<>c__DisplayClass12.b__b (IAppBuilder builder) <0x40102500 + 0x0006b> in :0
at Owin.Loader.DefaultLoader+<>c__DisplayClass1.b__0 (IAppBuilder builder) <0x40102170 + 0x000d2> in :0
at Microsoft.Owin.Hosting.Engine.HostingEngine.ResolveApp (Microsoft.Owin.Hosting.Engine.StartContext context) <0x400d2fa0 + 0x0021c> in :0
at Microsoft.Owin.Hosting.Engine.HostingEngine.Start (Microsoft.Owin.Hosting.Engine.StartContext context) <0x400bd7f0 + 0x0013f> in :0
at Microsoft.Owin.Hosting.Starter.DirectHostingStarter.Start (Microsoft.Owin.Hosting.StartOptions options) <0x40068cb0 + 0x00054> in :0
at Microsoft.Owin.Hosting.Starter.HostingStarter.Start (Microsoft.Owin.Hosting.StartOptions options) <0x400653c0 + 0x0007b> in :0
at Microsoft.Owin.Hosting.WebApp.StartImplementation (IServiceProvider services, Microsoft.Owin.Hosting.StartOptions options) <0x4005ebc0 + 0x0005e> in :0
at Microsoft.Owin.Hosting.WebApp.Start (Microsoft.Owin.Hosting.StartOptions options) <0x4005cfd0 + 0x00027> in :0
at Microsoft.Owin.Hosting.WebApp.Start[TStartup] (Microsoft.Owin.Hosting.StartOptions options) <0x4005cdf0 + 0x00047> in :0
at Microsoft.Owin.Hosting.WebApp.Start[TStartup] (System.String url) <0x4005cb90 + 0x00033> in :0
at xxx.Program.Main (System.String[] args) <0x40013430 + 0x000f7> in :0
[ERROR] FATAL UNHANDLED EXCEPTION: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeLoadException: Failure has occurred while loading a type.
at xxx.Startup.Configuration (IAppBuilder appBuilder) <0x40102a10 + 0x00187> in :0
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x40071370 + 0x000a3> in :0
--- End of inner exception stack trace ---
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) <0x40071370 + 0x000ff> in :0
at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) <0x400ced40 + 0x0002a> in :0
at Owin.Loader.DefaultLoader+<>c__DisplayClass12.b__b (IAppBuilder builder) <0x40102500 + 0x0006b> in :0
at Owin.Loader.DefaultLoader+<>c__DisplayClass1.b__0 (IAppBuilder builder) <0x40102170 + 0x000d2> in :0
at Microsoft.Owin.Hosting.Engine.HostingEngine.ResolveApp (Microsoft.Owin.Hosting.Engine.StartContext context) <0x400d2fa0 + 0x0021c> in :0
at Microsoft.Owin.Hosting.Engine.HostingEngine.Start (Microsoft.Owin.Hosting.Engine.StartContext context) <0x400bd7f0 + 0x0013f> in :0
at Microsoft.Owin.Hosting.Starter.DirectHostingStarter.Start (Microsoft.Owin.Hosting.StartOptions options) <0x40068cb0 + 0x00054> in :0
at Microsoft.Owin.Hosting.Starter.HostingStarter.Start (Microsoft.Owin.Hosting.StartOptions options) <0x400653c0 + 0x0007b> in :0
at Microsoft.Owin.Hosting.WebApp.StartImplementation (IServiceProvider services, Microsoft.Owin.Hosting.StartOptions options) <0x4005ebc0 + 0x0005e> in :0
at Microsoft.Owin.Hosting.WebApp.Start (Microsoft.Owin.Hosting.StartOptions options) <0x4005cfd0 + 0x00027> in :0
at Microsoft.Owin.Hosting.WebApp.Start[TStartup] (Microsoft.Owin.Hosting.StartOptions options) <0x4005cdf0 + 0x00047> in :0
at Microsoft.Owin.Hosting.WebApp.Start[TStartup] (System.String url) <0x4005cb90 + 0x00033> in :0
at xxx.Program.Main (System.String[] args) <0x40013430 + 0x000f7> in :0

I see the same thing, any news?

Unless someone else in the community is willing to investigate this further it's unlikely to be resolved any time soon. I'm not overly familiar with Mono so just getting something setup to reproduce would take time and unfortunately this is time I simply don't have right now :(

Hmm.. I get something similar with OWIN self host (I will try to investigate)

FYI There is a fix https://github.com/domaindrivendev/Swashbuckle/issues/357
Binding the version, this worked for me.
<dependentAssembly>
    <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
    <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
</dependentAssembly>

Closing for now as a fix has been proposed


Media upload request generates repeated query string that cause InvalidQueryStringException in AWS CloudFront gateway

Link to reproduction
No response
Payload Version
3.0.0-beta.56
Node Version
v20.15.0
Next.js Version
15.0.0-canary.49
Describe the Bug
I managed to deploy my app to AWS using ion.sst.dev and i am able to upload file in Media New Form. But when uploading file in Tenant Edit Form, it cause 400 response from AWS gateway.
Request Header
Request URL: https://xxxxxxxx.cloudfront.net/api/media?depth=0&fallback-locale=null&locale=en?depth=0&fallback-locale=null&locale=en <-----------------repeated query string may cause the error
Request Method: POST
Status Code: 400 Bad Request
Referrer Policy: strict-origin-when-cross-origin

------------------
Response Header
Content-Length: 16
Content-Type: application/json
Date: Tue, 02 Jul 2024 06:40:50 GMT
Via: 1.1 xxxxxxxx49ff71df5688c84f41fec8.cloudfront.net (CloudFront)
X-Amz-Cf-Id: xxxxxxxxNjV7J8ndQAslyXxpPYvuuYb1jL1dqkrHp-lqVw==
X-Amz-Cf-Pop: SIN52-C3
X-Amzn-Errortype: InvalidQueryStringException <------------
X-Amzn-Requestid: xxxxxxxx-5f03-492a-9ddf-6e7d3283880d
X-Cache: Error from cloudfront

Reproduction Steps
export const Tenants: CollectionConfig = {
  slug: "tenants",
  admin: {
    useAsTitle: "name",
  },
  fields: [
    {
      name: "name",
      type: "text",
      required: true,
    },
    {
      name: "logo",
      type: "upload",
      relationTo: "media",
      filterOptions: {
        mimeType: { contains: "image" },
      },
    },
  ],
};

export const Media: CollectionConfig = {
  slug: "media",
  upload: true,
  fields: [
    {
      name: "caption",
      type: "text",
    },
    {
      name: "tenant",
      type: "relationship",
      relationTo: "tenants",
      index: true,

      admin: {
        position: "sidebar",
      },
    },
  ],
};

// part of my payload.config.js
import { s3Storage } from '@payloadcms/storage-s3'
...
  collections: [Tenants,  Media],
  localization: {
    locales: ['en', 'fr'],
    defaultLocale: 'en',
    fallback: true,
  },
  plugins: [
    s3Storage({
      enabled: process.env.NODE_ENV === 'production',
      collections: {
        media: true,
      },
      bucket: process.env.AWS_S3_BUCKET || Resource.Media.name,
      acl: 'private',
      config: {
        region: 'ap-southeast-1',
        // credentials: {
        //   accessKeyId: process.env.AWS_S3_ACCESS_KEY_ID || '',
        //   secretAccessKey: process.env.AWS_S3_SECRET_ACCESS_KEY || '',
        // },
      },
    }),
  ],
...

You can reproduce this issue locally:

create a Media upload collection and a regular content collection
add an image field in content collection and config the relationship with Media
upload an image directly in Media create form, it will send a multipart request without repeated query string and that's why its working in my CloudFront prod enviroment.
create a content post with image upload, it will send a multipart request with  repeated query string sth like http://localhost:3000/api/media?depth=0&fallback-locale=null&locale=en?depth=0&fallback-locale=null&locale=en which is not expected in prod env though it's working on localhost

Adapters and Plugins
db-postgres, @payloadcms/storage-s3, @payloadcms/richtext-lexical

Fixed with this PR.


find does not work with some unicode characters

Given doc
{
  foo: 1,
  bar: "とう)京(きょう::\u0123\u0923\u0387;"
}

query find({selector: { foo: 1, bar: "とう)京(きょう::\u0123\u0923\u0387;"}}) returns [].
However, given doc
{
  foo: 1,
  bar: "trucker's atlas"
}

query find({selector: { foo: 1, bar: "trucker's atlas"}}) works as expected.

This issue was moved to pouchdb/pouchdb#6257


Feature 2 - Clean dataset

Clean dataset (empty rows, character encodings)

Some data is cleaned before working with charts, however some issues only pop up when working on a chart. Because of this, all data cleaning code will also be uploaded together with the charts.
GH-3


Feature request numpy.unique

Platform: Ubuntu 16.04
Python version: 3.6
Numba version: 0.37.0
I was trying to get a speedup in my code where I use numpy.unique() to find unique elements in an n-dimensional array. If I use this:
x = np.unique(arr)
this works fine and returns the expected results. But if I do this:
@jit(nogil=True, nopython=True)
def find_unique(arr):
    return np.unique(arr)

x = find_unique(arr)

This throws an error with the following message:
UntypedAttributeError: Failed at nopython (nopython frontend)
Unknown attribute 'unique' of type Module(<module 'numpy' from '/opt/conda/lib/python3.6/site-packages/numpy/__init__.py'>)
File "<ipython-input-15-bd84a508a624>", line 5
[1] During: typing of get attribute at <ipython-input-15-bd84a508a624> (5)

Thanks for the report. You are seeing that message because Numba does not yet support numpy.unique. Functions that are supported are listed here. I'm editing the title and making this a feature request. Thanks.

Thanks for the response. Is there any particular timeline for that? The current numpy version takes too long to compute things and if it's in a loop, you can assign hours for the completion of the loop over thousands of n-dimensional arrays.

No problem. I don't have a time line for implementation I'm afraid. The fastest way to get support is to contribute a patch/implementation, the high level extending API @overload decorator is probably the place to start (http://numba.pydata.org/numba-doc/latest/extending/high-level.html#implementing-functions). I think it'd just be a memory flatten, sort and then loop to extract unique elements, I'd expect the sort to dominate so you may not get much of a speed up over NumPy.
In [1]: import numpy as np

In [2]: x=np.random.rand(10000000)

In [3]: %timeit np.sort(x)
1.09 s ± 11.3 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

In [4]: %timeit np.unique(x)
1.17 s ± 4.11 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

FYI (not sure if you get a notification on mentions), there's a fix in #2902. You can just copy the function decorated with @overload into your program (look for it in the diff) and it'll work.

@Rik-de-Kort if that is the correct implementation, then you can add one more thing to it, the counts for each unique value. This is because in most of the cases, along with unique instances, counts for each value is required

I'm not sure how to work with keyword arguments using the highlevel API (I'd have to spend some time on it), but since it's not going to make it into numba until at least 0.39, here's code for an overloaded implementation which returns the counts as well.
        def np_unique_impl(a):
            b = np.sort(a.flatten())
            unique = [x for x in b[:1]]
            counts = []
            for i, x in b[1:]:
                if x != b[i]:
                    unique.append(x)
                    counts.append(1)
                else:
                    counts[-1] += 1
            return unique, **counts**


Contact is not valid

examples/model_building_test returns with
terminate called after throwing an instance of 'std::runtime_error'   what():  'Contact is not valid!' Aborted
There seems to be an issue somewhere in addPhase

which addPhase? Is it when adding the initial phase?

Now runs successfully (ChatGPT may have helped) with this output:
Built model
Set the end effectors
Set the robot
Set the ground
Set the states
Set the modes
Set the contact sequence
Finished setting up the problem
phase 0 time -- 1
phase 0 contacts --
phase 1 time -- 1
phase 1 contacts --
phase 2 time -- 1
phase 2 contacts --


[bug] Rainbow wallet does not sign a message in Android and iOS.

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.0.5
wagmi Version
2.5.19
Current Behavior
When I sign message with Rainbow Wallet in desktop, it works. But when I try to sign message with android and iOS devices, it does not give any signature and does not return the app.
Expected Behavior
Message can be signed as in mobile phone like in desktop rainbow wallet.
Steps To Reproduce
You can open below link in your mobile phone. You can click all blue button in onboarding screens. At the end you will connect with rainbow wallet and you will sign a message. (This works in desktop but not in mobile phone)
https://digitaliga-development.web.app/
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

@bilgin-kocak Can you share a minimal reproducible example ?


[user] EnumDisplayDevices result

The EnumDisplayDevices function returns a WinResult. I don't see where Ok(true) is ever set. It also seems like it is not required because we also return a result.
Also, the current example in the docs of that function is a bit weird. The function is supposed to be called until the first error because that means that we finished iterating over all displays:
if !is_finished {

will never be the case, because the ? will return the error.

As far as I could investigate, the enumeration ends when EnumDisplayDevices returns zero and GetLastError returns ERROR_PROC_NOT_FOUND, therefore the foolproof implementation has to consider this. The check is necessary to rule out legitimate errors.
I changed the implementation to reflect this. Please let me know if this worked for you.

Wow that was quick :D. I am not too familiar with Windows error handling stuff, but if I try to adjust my code like mentioned in the example:
/// Returns a list of all displays.
pub fn discover_displays() -> Result<DisplaySet> {
    let mut result = Vec::<Display>::new();

    let mut dev_num: u32 = 0;
    let mut display_device = DISPLAY_DEVICE::default();

    loop {
        let has_more = EnumDisplayDevices(
            None,
            dev_num,
            &mut display_device,
            EDD::GET_DEVICE_INTERFACE_NAME,
        )?;

        if has_more {
            result.push(Display::from_winsafe(dev_num, &display_device)?);
            dev_num += 1;
        } else {
            break;
        }
    }

    Ok(DisplaySet { displays: result })
}

Then the fn returns early with the following Err: "[0x00cb 203] The system could not find the environment option that was entered.".
The following works fine:
        let has_more = EnumDisplayDevices(
		...
        ); // no `?`

        if has_more.is_ok() { // `is_ok()` instead
            result.push(Display::from_winsafe(dev_num, &display_device)?);
            dev_num += 1;
        } else {
            break;
        }

This might have to do with the fact that I have one display that is active: false?

When I run your code, I get an infinite loop, because is_good is always true.

Maybe I'll have to add a specific handling inside the implementation... how do you know the display is inactive?

I only have three displays attached to the four DisplayPort ports on my GPU (maybe the forth one is also some kind of virtual display output device).
This is how the API calls look in APIMonitor:

While all other display have the active flag there, my forth monitor shows this flag:

It's just a for iterating from 0 to 7... it can't be an infinite loop.
Are you running this code inside something else?

Agh sorry. Wanted to get back to you ASAP and got sloppy: I had another loop {} around this from code before. This code actually doesn't loop. Output is:
0 Ok true
1 Ok true
2 Ok true
3 Ok true
4 Err [0x00cb 203] The system could not find the environment option that was entered.

5 Err [0x00cb 203] The system could not find the environment option that was entered.

6 Err [0x00cb 203] The system could not find the environment option that was entered.

7 Err [0x00cb 203] The system could not find the environment option that was entered.

What about this example in the docs? Does it still loop?

This means that when the loop ends, GetLastError returns code 203, which should be the stop condition.
However... on my computer, it returns code 127 instead. That's odd.
I'm on Windows 10 x64, what's yours?

Output now is:
0: \\.\DISPLAY1 - NVIDIA GeForce GTX 1080
1: \\.\DISPLAY2 - NVIDIA GeForce GTX 1080
2: \\.\DISPLAY3 - NVIDIA GeForce GTX 1080
3: \\.\DISPLAY4 - NVIDIA GeForce GTX 1080

So it works!
We could also handle 127 as well as 203 as codes for Ok(false).


Passphrase into endpoint is required even if even if none is required on the remote server

Issue Description
I use ssh task that used a specific configured endpoint with

connection name: ok
host name: ok
port: ok
user name: ok
passphrase: ko
private key: ok

About the ssh's configuration of the remote server it is not set with a passphrase so it explain why I didn't set one into my VS endpoint configuration.
Unfortunatly my first observation is that with no passphrase specify the the connection will not be authorized (always fail) and so never will be etablished
I understand this behavior after reading the code here: https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/SshV0/ssh.ts#L37 --> Actually a passphrase is always given regardless of the fact that maybe the remote server does not require one.
it's contradictory to this line https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/SshV0/ssh.ts#L19 where it is said that the passphrase is optionnal...(maybe a bad interpretation of myself?)
In any case, it should be super great to test this before sending it into the setupSshClientConnection I can make a PR if it can be applied into it for the comming further version?
I still managed this issue by temporary adding a passphrase onto the remote and then adding it into the endpoint too --> it allows me to etablish a first connection after what I can remove the passphrase on the remote and the connexion keep goin on...but this is tricky time consuming when I have to create new builds...
Many thanks in advance for your answers
-jne

@madhurig - can you take a look as this is related to SSH endpoint/task?

To make sure I am clear on the problem: you are saying that you are unable to connect with the "SSH" task when you are using a private key without a passphrase?  Can you please run a build with System.Debug=true and send the log file for this build step?

Hello, sorry for the late. This is exactly what I mean: the endpoint seems to work only with a passphrase when using ssh private key. Unfortunatly I think that I can't provide you a system.debug output log
Did you succeed to reproduce this behavior?
many thanks

@brcrista  any news about this issue? :smiley:

I haven't been able to repro it.  What's the issue with getting a debug log?

Honestly I don"t know how to as I 'am only a simple user...or may I miss something with your proposal.
But regarding the source code that I've poitned...isn"t it whare it's wrote: a mandatory passphrase when using ssh key?

I agree the comment is ambiguous but I'm not totally convinced yet that that is the right fix.  It may be but I would like to see the logs first.
You can set System.Debug = true under the "Variables" tab of the definition editor or when you are queueing a build:

OK I ll test this and 'll give you a feedback ASAP

@JonathanNEMRY did this get resolved?

Closing since there is no activity since July. Please reach out to us if this is still blocking you.

@brcrista and @madhurig  sorry for the delay, I just setup a new project with ssh agent and the error is still there I launched a run with debug and can provide you this:

So we clearly see that null passphrase still problematic...when could you provide a fix for this one? many thanks in advance
-jne

Re-opening this issue

Hello, any news about this issue? 😄

hello, any news about this issue?

@JonathanNEMRY looks like it's failing because your private key is encrypted.  That means that when you ran ssh-keygen you set a passphrase.  That's why you need to provide the passphrase for the key.
If you provide an unencrypted private key, then you don't need to provide a passphrase to the task.

That's the intended behavior, though I should add that I would always recommend encrypting your private key.

@brcrista  many thanks for your answer. Howerver as I explained the problem, the current code force me to encrypting my private key. But I don't want to. The current behavior is:

my private key is no protected by passphrase
I don't set passphrase into the wizard that create the ssh connetion from job
Error
Actually the workaround is to temporary set a passphrase , then connect the agent and I have go remove the passphrase after...that is not a easy process to do...please consider this as the bug it is and provide a fix. (I pointed you the implied code)

many thanks in advance,
-jne

I actually see this happening in the service connection for SSH (not in the task):

Is this what you are seeing?
If I just provide a nonsense passphrase here, the SSH task succeeds.  I don't have to remove it afterwards.

No I have no error on this screen. I can close it and go back to my agent job. But when it is running the error of ssh connexion appears

I'm not able to repro this issue.  I set up an SSH service connection with an unencrypted private key and a dummy passphrase.  Here is my build: https://brcrista-expert.visualstudio.com/MyFirstProject/_build/results?buildId=554
The error message in your screenshot says "could not parse private key."  That sounds like to me that the either the key is actually encrypted and needs a passphrase, or the key was not uploaded correctly.
If I change the service connection to use an encrypted private key and don't provide the correct passphrase, I get an error that looks similar.
##[error]Failed to connect to remote machine. Verify the SSH service connection details. Error: Error: Cannot parse privateKey: Malformed OpenSSH private key. Bad passphrase?.

Could you please paste the entire contents of the log for that step (instead of a screenshot)?

hello @brcrista
thanks for your last answer. What do you mean exactly by "unencrypted ssh key"? all keys I have are generated with ssh key-gen and that's all but without passwphrase.
The purpose is to have a ssh key onto the server set WITHOUT passwphrase and the have nothin to specify into a the dev ops box completion...

If you run ssh-keygen without a passphrase, then it will not be encrypted.

Hello @brcrista ,
I have the same problem and i dont want my ssh keys to be encrypted. But when i try to make SSH connection without paraphrase , it doesnt allow me to do as you showed in the attached picture above.
After reading through the comments i concluded that if i create SSH connection by giving bogus paraphrase/password. It will work.
Is my conclusion right? If so it seems to be a bug. I can continue with this hack around for time being but can you please let me know when can this be resolved.
Best Regards
Jashan

Hi @JonathanNEMRY @jashan05 is this issue still reproducible for you? I can't reproduce it at the moment - even if there's no passphrase for ssh key...

Hi @JonathanNEMRY @jashan05 please ping me if it is still actual for you

@JonathanNEMRY @jashan05 I'm closing it at the moment due to inactivity, please feel free to reopen it if it is still actual for you

@anatolybolshakov yes it is always the same :) sorry for the delay

@JonathanNEMRY ok, thanks! Are you using on-premise solution or Azure DevOps Services? Could you please also provide task version which you are currently using? You can find it at the top of task logs:

Hi @JonathanNEMRY jentle ping :smiley: could you let us know if you're using on-premise or cloud solution? Could you also check SSH task version from logs?

Hi @JonathanNEMRY, I'm closing it at the moment due to inactivity - please feel free to reopen it if it is still actual for you


[BUG]  When I pressed login to play Roblox I received this message: " System.Exception: Signature does not match! "  what is this ?

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
The problem I encountered was when I tried to open Roblox and when Blox Strap was installed, this error message appeared: "System.Exception: Signature does not match!"

Read the preliminary instructions. https://github.com/pizzaboxer/bloxstrap/wiki/"Signature-does-not-match!"-error-when-launching-Roblox


apis/core/v1: Register Event and EventList

I see the package I modified is just a codemod of an upstream pkg. Any idea why events is not registered upstream? It is a valid resource to interact with.

@ericchiang  Can you please check if you can merge this request?
I have tried to use events/v1beta1 but didn't work getting page not found, and for core/v1 is wroking

This file is generated, you'll need to modify this instead https://github.com/ericchiang/k8s/blob/master/scripts/register.go
As a workaround, you can just register this in your own code:
func init() {
    k8s.Register("", "v1", "events", true, &v1.Event{})
    k8s.RegisterList("", "v1", "events", true, &v1.EventList{})
}

#118


[FEATURE] #1: update paypal express module for hyva to work with late…

…st stable checkout version

add translation files for various languages

add license file

add credits and license to readme file

Hi Irene, I'm sorry, that PR went completely under my radar. I've merged it and tagged an 1.0.1 release.
Please note that I've also renamed the repo to hyva-themes/magento2-react-checkout-paypal-express.
I've made the repo public and I'll ask people to start testing it now :)
Thanks a lot for your work @nuovecode and @mautz-et-tong

thank you so much!

@wigman may I ask you to add https://github.com/ilanarielbaron to credits?

@nuovecode Yes ofcourse, I missed that because it didn't show in the repo overview :) I've added it, but will wait with tagging another version until we get some feedback on this version.


Clarify RandomizedSearchCV documentation for sampling with replacement

At this line, it may be better to explicitly mention which parameters will be sampled with replacement if any one of them is a distribution:
https://github.com/databricks/spark-sklearn/blob/master/python/spark_sklearn/random_search.py#L27
Are all parameters (those given as distributions and those given as lists of values) sampled with replacement in this scenario, or only parameters given by distributions?
If so, this documentation would be better stated as:

sampling with replacement is used for all parameters.

Let me know if you'd like a pull request. :)

Sure, yeah, I'm sure this could use some clarification. Feel free to open a PR.


Limit graceful CSV error handling to parse errors

The graceful error handling added in v0.5.1 introduced a new error case
where an exporter got stuck in an endless loop when hitting an
unexpected non-parser error. This change ensures that only
csv.ParseErrors get handled gracefully.
Can't read CSV: read tcp <IP_ADDRESS>:30270-><IP_ADDRESS>:5000: i/o timeout

@juliusv @brian-brazil
I tried to write a test for that, but I wasn't able to. Any I/O timeout was already handled during the HTTP Get() method.

:+1:

I have the hunch the i/o timeout errors are the result of locking+timeouts+reading the response body while parsing. I'll finally take a look at a lock free exporter soon.


Can't install from repository, cant build from source.

installing via the repository doesn't work as it looks like the /v0.9.2/linux_amd64_gcc4 doesn't exist in the repository.
D SET custom_extension_repository='http://welsch.lu/duckdb/prql/latest';
D install prql;
Error: HTTP Error: Failed to download extension "prql" at URL "http://welsch.lu/duckdb/prql/latest/v0.9.2/linux_amd64_gcc4/prql.duckdb_extension.gz"

Candidate extensions: "parquet", "sqlite", "sqlite3", "sqlite_scanner"

Copying the file from the remote repository to /home/me/.duckdb/extensions/v0.9.2/linux_amd64_gcc4/ then loading it cuases a segmentation fault.
Building it locally and running it with the version of duck the build process makes results in this result when issuing the PRQL statement from the README.
free(): invalid next size (fast)
Aborted (core dumped)
``

Hi @jdoig, the _gcc4 version is indeed not being built at the moment. I had some trouble getting the build for it to work (see https://github.com/ywelsch/duckdb-prql/blob/c0e847ab1010ec49f989650ccec98549e40a7fbf/.github/workflows/Linux.yml#L20).
Regarding the segfault, see https://github.com/ywelsch/duckdb-prql/issues/10
The statement from the README is indeed broken (but other smaller examples work), and I'm looking into it (Haven't figured out the problem yet, it happens with certain queries, but not others).

I've pushed a fix for the gcc4 build (https://github.com/ywelsch/duckdb-prql/commit/ee7a75936ff07fa938077b0aee649c8aa3fc2276), so in 30mins from now the linux_amd64_gcc4 extension should be available for duckdb 0.10.0 (I'm only doing releases on the latest duckdb).
For the segfault, follow #10.


Updated  react-icons version

Updated  react-icons version to accomodate for new or changed icons such as twitterX

Ive updated the version of react-icons it was working with so it can have some of the latest icosn such as X.com's

This would not have worked as in the newer react-icons version the /all package was remved. But in PR #26 this got fixed and the package got updated to the new version.
Anyway thanks for your effort! :)


nsc-event-nextjs_6_285_nav-bar-modifications

This is a pull request!
Please fill out this description with the following:
Resolves <issue #285 >
https://github.com/SeattleColleges/nsc-events-nextjs/assets/97195623/d1bb61a9-3706-4471-9a21-07e213c3354e

Looks great!

Adding a profile icon is a great addidtion to NSC. Additionally i like the NSC printed name that was added to the top left of the Navbar. I will recommend to replace the android icon with the NSC school logo.
Before:

After:


Feature Proposal: Running until all channels are rebalanced

At the moment from my experience the program completes after only 1 successful rebalance attempt. This means I have to run it again and again until the program cannot find any more at least 1 source and 1 destination channel based on my filters.
Could be possible to automate this manual proceduce or it was designed like this by choice?
Thank you for the help

Yes, it was designed like this. You can run it in a simple loop like this:
while true; do regolancer -a 10000 --to=some_node_pk --pfrom=100 -r 0.7 || sleep 3600; done
So if it exits with an error you pause the loop for an hour and then try again. This way you can react to errors flexibly, for example you might try to reset the lnd's mission control on error to retry all the routes again, or you may exit the loop completely.


Bug: Appearance for other note / link changed after update

Bug Description
When I used old version of this theme & obsidian, style for link was like

Use uppercase for character
Use different appearance style

But after I upgrade, it doesn't seem to work in same way. Is it expected behavior? OR there would be any missing configuration for me to set up?
To Reproduce
Just crate a note link like [[Note Name]]
Expected behavior

Relevant Screenshot(s)
Currently it shows like below

Obsidian Version
1.0
Installer Version
v0.15.9
Font Size
14
Which editor are you using?

[X] New Editor
[ ] Legacy Editor

In which mode(s) does the problem occur? (if applicable)

[ ] Reading View (Preview)
[ ] Editing View - Source Mode
[X] Editing View - Live Preview

Which operating system?

[ ] Windows
[X] macOS
[ ] Linux
[ ] Android
[ ] iOS

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Themes - Manage → Update).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] If the bug occured after updating the theme, I read the last couple Releases to make sure the bug is not an intentional change.

Additional Context
No response

same here on macOS.
V1.1.9 for Obsidian 1.0

Hi! The theme has been rewritten for Obsidian 1.0 and, although that work is still in progress, there are some settings that I still need to "port" back from the old theme, this being one of them. I'll resume development of the theme soon. :)


Fix dead link to Rust toolchain specification

This is just a quick fix to replace the dead link to the GitHub readme with a link to the rustup mdBook according to #115

Awesome, thank you!


zh: sync on reference-commands-istioctl

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rootsongjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [rootsongjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Support shared_preload_libraries etc...

Hi,
Just wanted to know how you'd feel about adding support for shared_preload_libraries / bgworkers \ shared memory (although that's a lot harder) being added?

I’m a big fan of us using this library for extending Postgres in as many different ways as possible.
I’m currently a little concerned about the memory model for a lot of this, but yes, I’m a big supporter.

What are the concerns? I see you’re using palloc in behind a feature gate -
which is neat. I also saw a comment about state being lost - but that’s
what shared memory is for.
Admittedly writing to Shared Memory is a bit iffy in my experience - that
can be worked on though.
On Wed, 22 May 2019 at 8:13 pm, Benjamin Fry<EMAIL_ADDRESS>wrote:

I’m a big fan of us using this library for extending Postgres in as many
different ways as possible.
I’m currently a little concerned about the memory model for a lot of this,
but yes, I’m a big supporter.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bluejekyll/pg-extend-rs/issues/45?email_source=notifications&email_token=AAJJDI5HMMJ6TM7FZXW7MCLPWUMFRA5CNFSM4HORMQD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6SRYQ#issuecomment-494741730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJJDI7EY5ENB3YQPFT7WYTPWUMFRANCNFSM4HORMQDQ
.

I’m working on a patch to try and make things threadsafe in regards to the use of palloc. I can reproduce issues with it right now, but don’t have it isolated to why the exact problem is, yet.

I’m struggling to get my head round a usecase for threading without loading
as a shared library?
Are you on Slack or irc anywhere?
On Thu, 23 May 2019 at 12:49 am, Benjamin Fry<EMAIL_ADDRESS>wrote:

I’m working on a patch to try and make things threadsafe in regards to the
use of palloc. I can reproduce issues with it right now, but don’t have it
isolated to why the exact problem is, yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bluejekyll/pg-extend-rs/issues/45?email_source=notifications&email_token=AAJJDIYGM7NZ472MYDM7H3DPWVMQ7A5CNFSM4HORMQD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7JVWI#issuecomment-494836441,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJJDIZWST3NM7QWFFGQAS3PWVMQ7ANCNFSM4HORMQDQ
.

I hang out in the Rust discord app, we can chat there.
This is all in the context of the shared library loading, as currently implemented. Threading would be from the Rust, though it might be in appropriate in general in Postgres, but I expect people coming from Rust will want to use threading...

Just saw this issue I'd forgotten and thought I'd comment with the current state of play - turns out calling Postgres through FFI (as this crate does) is unsafe even in the presence of threads.
ie: if you use Rayon, or something which starts a thread to do work in the background then you are firmly into the realms of UB - even if the threads never call into Postgres.

I agree that threads with PG FFI are inherently dangerous, given the nature of PG.
I think an option we have is to pass around a & mut instance of the memory context, and that would not be sendable across threads. If we required that handle on all FFI, then it would be possible to reduce mistakes in that context.
Not sure it’s worth it though. BG workers are probably the safe and best model here.

The issue with that approach is usually just because something can’t be
sent between threads doesn’t mean it can’t be created on another thread.
Bgworkers suffer the same fate, with the small proviso that they can thread
if they never connect to SPI, call PG functions, or deal with signals.
On Sun, 30 Aug 2020 at 12:50 am, Benjamin Fry<EMAIL_ADDRESS>wrote:

I agree that threads with PG FFI are inherently dangerous, given the
nature of PG.
I think an option we have is to pass around a & mut instance of the
memory context, and that would not be sendable across threads. If we
required that handle on all FFI, then it would be possible to reduce
mistakes in that context.
Not sure it’s worth it though. BG workers are probably the safe and best
model here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bluejekyll/pg-extend-rs/issues/45#issuecomment-683300823,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJDI6KZLSSZG6BV5XC3G3SDEISXANCNFSM4HORMQDQ
.

So we already mark PgDatum and PgAllocated types as both !Send and !Sync specifically to deny sharing memory managed by PG between threads.
Otherwise we use the default Rust allocator for all memory. Is there a reason you think that isn't safe? I'm not honestly sure we have any changes necessary with those restrictions in place.

The handle on FFI idea is interesting - even things like postgresql logging
from a thread are unsafe sadly.
On Mon, 31 Aug 2020 at 9:38 am, Benjamin Fry<EMAIL_ADDRESS>wrote:

So we already mark PgDatum and PgAllocated types as both !Send and !Sync
specifically to deny sharing memory managed by PG between threads.
Otherwise we use the default Rust allocator for all memory. Is there a
reason you think that isn't safe? I'm not honestly sure we have any changes
necessary with those restrictions in place.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bluejekyll/pg-extend-rs/issues/45#issuecomment-683486204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJDIZD5QJLMUL5TQBFA2TSDLPH3ANCNFSM4HORMQDQ
.


feat: disable save button when savingdatasource is in progress

SUMMARY
Disabled the "Save" button when saving a datasource is still in progress. This way users at least have some feedback in case of slow network/backend response.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Manual

Go edit a datasource
Throttle your network
Click on save

ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11493 into master will decrease coverage by 5.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11493      +/-   ##
==========================================
- Coverage   66.61%   60.98%   -5.63%
==========================================
  Files         862      417     -445
  Lines       41215    26052   -15163
  Branches     3719        0    -3719
==========================================
- Hits        27454    15888   -11566
+ Misses      13660    10164    -3496
+ Partials      101        0     -101

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
60.98% <ø> (-1.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
31.91% <0.00%> (-59.58%)
:arrow_down:

superset/db_engine_specs/hive.py
53.90% <0.00%> (-30.08%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/api.py
83.49% <0.00%> (-7.08%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 461 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3dca4...be1b0cf. Read the comment docs.


Fix for Espanol link

Disable header link
Changes

Updates ' static/css/header.less' file to disable link.

Review

@jimmynotjim
@anselmbradford

Preview

CF has the utility mixin .u-link__no-border() to remove the border on default and hover states. I'd say use that instead.

:+1:


connect finagle filter to specific controller

Hi , it's not clear for m the relation between finatra controllers nd finagle services and how can I compose them with filter, for instance, suppose than I wish than some routes will be filtered and check if the user is authenticate, with finagle you could use a filter which receive some service, but in finatra I dont know how apply the filter to some controllers, this is the only example in the doc
class MyServer extends FinatraServer
addFilter(new SimpleFilter)
register(new ExampleController)
//end <-- BTW seems than the author is rubyst :D
would be cool can do
register(onlyAuthenticateFilter andThen UserController))
but controllers seems not be services, what is the correct approach in this case?

In Finatra v2, please see the following example for adding a per-controller filter: https://github.com/twitter/finatra/blob/master/http/src/test/scala/com/twitter/finatra/http/integration/tweetexample/main/TweetsEndpointServer.scala#L26


why do you forcefully stop editing when scrolling a table?

public func scrollViewWillBeginDragging(_ scrollView: UIScrollView) {
       endEditing()
       onBeginDragging?(scrollView)
}

Hello @ilyatar, it's hard to provide help with little context. Please see our readme and submit a new issue following the template.

Thank you! This problem is no longer relevant


Resolve (hopefully) web-mercator assertion failure

Fixes #139

@rperlin-ela hopefully this fixes it. basically whenever there's a "zoom to bounds", be it a neighborhood, county, filtered lang points, or Zoom Home, i have a bit of "padding" set around the extent so that it's not crammed up against the edges of the map and potentially beneath the map controls, logo, etc.
The problem occurs when (somehow) the screen is not large enough to accommodate both the padding and the bounds (e.g. of the polygon), if that makes sense. I still have no idea how users are triggering it, and I was only able to reproduce it by setting the map container to reeeeeally small, and THEN the problem showed up. I'm guessing it's something to do with resolution, like maybe these users have their screen set to enormously large or small, but it's soooo many people that I'm not sure whether such an edge-casey reason applies.
So now the "fix" is that I'm just checking whether the map height and width are larger than 2x the padding (left + right, or top + bottom). If not, I just fall back to NO padding. Not ideal but at least it won't break. I tested the deploy on as small a screen as Chrome Dev Tools would let me make, and no errors. Did the same in prod, w/same size, and our old friend showed up.
Merging!

as an added preventative measure, i wrapped that whole chunk of code in a try/catch block, which basically "tries" to do the thing, then aborts said thing if something goes wrong.


Add operatorId filter to ArrivalByTime widget

https://github.com/hasadna/open-bus-map-search/assets/62185136/630c92ef-1056-4fbc-9786-9e289eecbd4a
#148
Added a operatorId filter in Arrival widget

I updated the title too, it looks good but I could not verify. I couldn't get the text to update.

I did a --amend commit, droped the title one on force pushed it. Hope it didn't mess anything up

force push are allowed here, but there's no need to amend commits because we squash merge our PRs

@NoamGaash I've tried to yarn lint before commiting and received this error. any advice?

that's just a warning,
seems like the linter is still running on your machine
you can take a look at the linter output of the github runner - https://github.com/hasadna/open-bus-map-search/actions/runs/6859008868/job/18652201225?pr=204
Run yarn lint

/home/runner/work/open-bus-map-search/open-bus-map-search/src/pages/dashboard/ArrivalByTimeChart/ArrivalByTimeChart.tsx
Error:   [4](https://github.com/hasadna/open-bus-map-search/actions/runs/6859008868/job/18652201225?pr=204#step:5:5)2:1  error  Delete `⏎`  prettier/prettier

/home/runner/work/open-bus-map-search/open-bus-map-search/src/pages/dashboard/DashboardPage.tsx
Error:   16[5](https://github.com/hasadna/open-bus-map-search/actions/runs/6859008868/job/18652201225?pr=204#step:5:6):34  error  Replace `·data={convertToGraphCompatibleStruct(graphData)}·operatorId={operatorId}` with `⏎················data={convertToGraphCompatibleStruct(graphData)}⏎················operatorId={operatorId}⏎·············`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

Error: Process completed with exit code 1.

@NoamGaash Just know, what should I run before commiting?

@i5x64BIT build, lint and test


use of undeclared crate or module ufmt

Hi!
Throughout the examples
ufmt::writeln!(&mut serial, ...);

is used. If I do that I'm not able to compile and I get the following error:
48 |     ufmt::uwriteln!(&mut serial, "Hello from Arduino!\r").void_unwrap();
   |     ^^^^ use of undeclared crate or module `ufmt`

I tried to add ufmt under [dependencies] in the Cargo.toml as ufmt = "0.1.0". Doing so gives me access to the ufmt crate with use ufmt;. The code then compiles (although rust-analyzer in VSCode complains that it could not resolve macro `ufmt::uwriteln` ).
Is this how it is intended to work? Would be great if someone could help me with that! :)

Hey!
Yes, you need to add ufmt as a dependency to make this work.  I guess the documentation should be more clear on that ...
Why rust-analyzier is failing, I have no idea.  I'm also using it and did not see any such problems so far.  Can you get a more verbose output of what it is complaining about?

I have the same issue regarding rust-analyzer. Here's my repo: https://github.com/nbigaouette/robot-car/tree/343b89bc397dc99761de583d744ebe8d47dfd135/rust
I can cargo build and flash to my arduino uno (thanks for avr-hal!!) but rust-analyzer cannot find ufmt:

My guess is that rust-analyzer is confused with the target?

I've reported the rust-analyzer issue upstream: https://github.com/rust-analyzer/rust-analyzer/issues/7674

Turns out that ufmt uses proc-macro-hack which rust-analyzer does not supports... 🤷

Okay, as this is not really something related to avr-hal and there is an upstream report now, I'll close this issue here.


fixed bug in code formatting

There are two problems in code formatting:

According to currently gopls's internal implementation, end point's offset  is always -1, which makes the Offset() panic.  Actually, as I tested in my neovim environment, checking file's ending is unnecessary now, so I removed these logic, and it works fine for me.

internal/source's line and column number always starts from 1, so we should correct it first. Otherwise code formatting cannot work properly.

@saibing PTAL

@imjustfly
thank you very much


UI text changes to ellipsis when pressing Enter after changing increase/decrease amount on supply item

Bug Screenshot:

Json File:

Noted.

Steps to replicate

Launch Main.main()
Immediately click on TextField and hit Enter.
Visual bug shows as seen in the screenshot above.

Possible solutions

Remove onAction event handler from this node.
Enable both onAction and onMouseMoved

Taken solution

Solution 2


Fix issue where all features may be filtered out

@jrafanie Please review.
This is an initial fix to handle the case where the requested features may not exist.  Aside from "bad" features, this can happen legitimately if you only ask for dynamic tenant features (i.e. the filtered list will be empty, but then the seed_tenant_miq_product_features will pull in the correct feature right after).
This is only the first part of a "complete" fix.  Ultimately, I think this method should double-check that the features you asked for were actually created, which will prevent the "bad" features, but I'm hesitant to put that in first because it may create more breakage.  I will do that in a follow up.
This is needed so that the tenant_quota_specs will pass in https://github.com/ManageIQ/manageiq-api/pull/1037
Part of #21216

Backported to lasker in commit 839c64fb6b24a0a72d6cf2e24d2c4836afe6a140.
commit 839c64fb6b24a0a72d6cf2e24d2c4836afe6a140
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Thu May 13 17:59:54 2021 -0400

    Merge pull request #21217 from Fryguy/fix_filtered_out_features

    Fix issue where all features may be filtered out

    (cherry picked from commit f3add5710b3c5fe29a36330a9293ec519eea2c68)


Create Simple Example Application

Create a second example application with much simpler implementation.
This should just be a login screen and success screen.

This task was completed from examples/notepad, right?

@pconerly no, I wanted to also add a bare bones example. No styling, two buttons, very basic.


Provided a flag to inhibit sodium in static builds

Fixes #50

cc @bldrvnlw here's a flag as you would have liked.


mermaid support

Is your feature request related to a problem? Please describe.
Including this in the about.md file doesn't show the graph.
graph TD;
   A-->B;
   A-->C;
   B-->D;
   C-->D;

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Why isn't there support for mermaid. Looks like I am missing something here?
Describe the solution you'd like
Is there an error in the syntax?

It surprisingly works on github's issue :)

This may please be marked as resolved. The details to fix this issue is available at: https://alshedivat.github.io/al-folio/blog/2021/diagrams/


Make it easier to point Rapid at non-OSM API and auth provider

Description
I am working on setting up rapid for use by OpenHistoricalMap, and I found it more difficult than I expected to point my local Rapid at our OHM data and auth settings.
The context is here: https://github.com/OpenHistoricalMap/issues/issues/684#issuecomment-1931039860
I thought I would just change these settings in index.html to point at OHM urls and credentials and have the app use those new settings.
As it stands, I changed those but then also had to change what seem like the same values in two other places:

Here for the API endpoints
Here for the OAUTH2 credentials

At that point, I was loading OHM data and my local auth was failing in the same way as Rapid is with OSM (since localhost is not a valid redirect URI for the OAUTH2 credential, and cannot be since URIs for OAUTH2 must be https and localhost is not).
So this is solvable, but it seems strange to have to set these in two places, and ideally they would be easy to set via ENV vars or similar, so that we can easily maintain our own Rapid but pull in upstream changes frequently.

@danrademacher Can you mention precisely which functionality this  issue is raising to ??

Well it's more like developer functionality than user functionality.
As a developer, I should have to specify API endpoint and credentials in only one place, ideally in index.html.
But when I tested that, changing those in that file had no effect and instead I had to change the instances of the default values elsewhere in the code

Thanks @danrademacher  I agree that you shouldn't need to make the changes in a bunch of places.
We don't do a good job explaining the new way to set things up now that our startup process is async.
I guess my intent was that adding something like this to index.html should work, however I see now that it probably won't because the system will already be started and firing off API calls before the then is called.
Elsewhere we differentiate between "init" and "startup" - I think we need to do that in Context also - to allow people to inject some customization before the components really start up.

context.initAsync()
  .then(() => {
     const osm = context.services.osm;
     return osm.switchAsync({
       url: 'https://www.openhistoricalmap.org',
       apiUrl: 'https://www.openhistoricalmap.org',
       client_id: 'HSNR54A1pMDYBBf2eikPkhMt0-eHL6z-E_urfND0CTE',
       client_secret: 'REDACTED'
     });
  });


Compiler crash when mixing goog.module and export

This code is not valid, but the compiler shouldn't crash:
goog.module('ice');
export class Ice {
}

java.lang.RuntimeException: java.lang.RuntimeException: INTERNAL COMPILER ERROR.
Please file a bug at http://go/jscompiler-bug with this stack trace, sponge link, and repro steps (a CL# and a build target).

insertion point must be a statement: CLASS 2 [length: 14] [source_file: input0]
  Node(CLASS): input0:2:7
export class Ice {
  Parent(EXPORT): input0:2:0
export class Ice {

	at com.google.javascript.jscomp.CompilerExecutor.runInCompilerThread(CompilerExecutor.java:126)
	at com.google.javascript.jscomp.Compiler.runInCompilerThread(Compiler.java:763)
	at com.google.javascript.jscomp.Compiler.compile(Compiler.java:733)
	at com.google.javascript.jscomp.Compiler.compileModules(Compiler.java:724)

https://closure-compiler-debugger.appspot.com/#input0%3Dgoog.module('ice')%253B%250Aexport%2520class%2520Ice%2520%257B%250A%257D%250A%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26MISSING_PROPERTIES%3D1%26TRANSPILE%3D1%26CHECK_TYPES%3D1%26COMPUTE_FUNCTION_SIDE_EFFECTS%3D1%26INLINE_VARIABLES%3D1%26SMART_NAME_REMOVAL%3D1%26REMOVE_UNUSED_PROTOTYPE_PROPERTIES%3D1%26REMOVE_UNUSED_PROTOTYPE_PROPERTIES_IN_EXTERNS%3D1%26COLLAPSE_PROPERTIES%3D1%26DEVIRTUALIZE_PROTOTYPE_METHODS%3D1%26VARIABLE_RENAMING%3D1%26PROPERTY_RENAMING%3D1%26CLOSURE_PASS%3D1%26GENERATE_EXPORTS%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1

The debugger link now doesn't crash and reports
WARNING - File cannot be a combination of goog.provide, goog.module, and/or ES6 module: input0

input0:2: ERROR - A file cannot be both a goog.module and an ES6 module.
export class Ice {
^^^^^^^^^^^^^^^^^^^

Closing the issue.


Error in handler leaks_list

if user is not admin: user could not set filter 'search' by field 'message', just change search by name - it will be enough. So... we have not field 'message' only name and content in table leaks

I found the problem with a 'message' field and fixed it. My bad. But how should I handle my first mistake? Do I need to expel this part with setting filter by 'content' at all? Or we need to check somehow our user's status inside the handler one more time and if it's an admin - let him add his filter by 'content'?

Yes you can check who make request to this handler admin or user.
If user is "admin" include filter else not include filter.


Can not process a .JPG (uppercase) file

A .jpg works, but a .JPG does not.
Error: RemoveBg::Error Unsupported file type (/path/to/file.JPG)

Support for uppercase file extensions has been released in v1.2.0:
https://rubygems.org/gems/remove_bg/versions/1.2.0


NullPointerException at org.mobilitydata.gtfsvalidator.validator.ParentLocationTypeValidator.validate(ParentLocationTypeValidator.java:64)

Bug report
SEVERE: Runtime exception when loading stops.txt
java.lang.NullPointerException
	at org.mobilitydata.gtfsvalidator.validator.ParentLocationTypeValidator.validate(ParentLocationTypeValidator.java:64)
	at org.mobilitydata.gtfsvalidator.validator.ValidatorLoader.invokeSingleFileValidators(ValidatorLoader.java:205)
	at org.mobilitydata.gtfsvalidator.table.GtfsStopTableLoader.load(GtfsStopTableLoader.java:152)
	at org.mobilitydata.gtfsvalidator.table.GtfsFeedLoader.lambda$loadAndValidate$0(GtfsFeedLoader.java:113)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)

This happens in a private GTFS feed that I can't provide but based on the file name involved, it looks there was a mismatch between the stop ID and the parent ID. This particular feed provider in the past has had a problem using the same ID for stops and the parent station.
Expected behaviour
Validator should report validation problems instead of crashing.
Observed behaviour
Crasher.
Environment versions

validator version: 2.0.0
Java version: openjdk 11.0.12
OS versions: Arch Linux

Thanks @markstos for flagging that and opening the issue. Work has started in https://github.com/MobilityData/gtfs-validator/pull/1011 to fix this bug.

I've confirmed this issue is fixed in the latest snapshot. I see foreign key validations in the error report, which is perfect.

Thanks for helping Netflix with their transit!

No problem!

My pleasure!


Can we have new custom field similar to State field

In my Jira board there is a custom field as "Change Status" with list of values , so in config-basic.json file  already there is a Status field as default field. I tried same way using mapping below along with default status field .
"source": "Change Status",
"target": "Custom.Change Status",
"for": "Task",
"mapping": {
"values": [
{
"source": "Approved",
"target": "Approved"
},
{
"source": "Completed",
"target": "Completed"
},
{
"source": "Pending Approval",
"target": "Pending Approval"
}
]
}
But its not working and not showing in export.
Also I tried using MapArray but still not working.
{
"source": "Change Status",
"target": "Custom.Change Status",
"mapper": "MapArray"
},
Looking for help

Check the field name: Custom.Change Status. I'm pretty sure you cannot have spaces in field keys in ADO.

That didn't work after removing spaces as "Custom.ChangeStatus" by d way it worked with custom.refid.
By  d way what  is "source-type"  and what value  have to be mention.

That's not my point, again:

Check the field name: Custom.Change Status

Thanks got it.


tpmdd vs. tpm2-abrmd

Hi,
What are the relationships between the kernel resource manager (https://sourceforge.net/p/tpmdd/mailman/tpmdd-devel/) and this project?
What are the guidelines for using one vs. the other?
(this is a followup to https://github.com/01org/tpm2-tss/issues/552#issuecomment-332249601)
Thanks,
Dan

Good question. Jarkko and I did a talk about this very subject @ LPC 2 weeks back but the talk wasn't recorded and the LPC website doesn't have a link to the slide deck (https://www.linuxplumbersconf.org/2017/ocw/proposals/4675) so I'll summarize here a bit.
The current implementations are mostly equivalent. They both provide isolation between objects & sessions created by different connections. Given this, the reason we have both still is that we have customers running with kernels going back to the 3.x series and the kernel RM is only available on very recent kernels. So the user space RM will be around at least till everyone is using the kernel RM.
For how we get to the ideal future of a single RM in the kernel: my plan is to prototype various features in user space as a way to get them tested. There's a lot of stuff in the related TCG spec that we haven't yet implemented and we all agree that trying to put features into the kernel before we really believe them to be useful, understand how they work, and how they're going to be used by applications is a bad idea.
A good example of this are the asynchronous portions of the SAPI. Right now with the kernel RM you can use the async API but it won't really be async (calls to functions that should be async will block) since the kernel doesn't supply user space with an async / polling I/O interface. For the short term, if you want to use the SAPI in an event driven I/O framework you will only get async I/O from the user space resource manager. In the long run though, if this feature is important to folks we can work with the kernel folks to add support there. My plan is to treat future features in the same way.
Hope this helps clear things up a bit.

@flihp that's very good information, do you think that could add something like that in the docs or the project wiki? (instead having it buried in an issue likely to be closed soon).
Also it would be great if you can share your LPC talk slides, maybe in the mailing list.

I'm trying to get the LPC organizers to expose the link through their site. If that fails I'll host them myself.
Getting data on the wiki is always a good idea. I'm planning to dump some hours into documentation once we work out the session mgmt stuff for the tools policy mechanism.

@flihp great, thanks!

FYI, @flihp sildes are now available at LPC site.

Excellent! A friend sent me a link to the Linux Security Summit 2017 roundup (http://blog.namei.org/2017/10/02/linux-security-summit-2017-roundup/) that @xjamesmorris put together after the event and it has a link too. Naturally I have a typo in the file name for the slides (http://linuxplumbersconf.com/2017/ocw//system/presentations/4818/original/TPM2-kernel-evnet-app_tricca-sakkinen.pdf) so at least I'm staying true to form :stuck_out_tongue_winking_eye:

Where did you all find that link? I've been clicking around the LPC website for a few minutes and I can't manage to find it. There's no link from the page for the talk or the schedule ...

@flihp in the TPM micro conf page https://www.linuxplumbersconf.org/2017/ocw/events/LPC2017/tracks/639

thx for the pointer @martinezjavier. I'd hoped it would be linked from the refereed track talk that we gave but this is better than nothing.

@flihp I think this can be closed now.

thx @martinezjavier


footer caption bug fix

Changes made:
Description
Replaces previous functionality with a mutation observer.  We watch the img inside the full img container, and if its src changes, we switch the caption.  So this covers clicks and arrow keys, basically any things that changes the src fires the function.
Testing:
Before making this pull request, I:

[ ] Cleaned the code the way Vue likes it - run 'npm run lint --fix'
[ ] Made sure all tests run
[ ] Ran WAVE plugin 508 compliance tool

I can confirm this has been checked on:

[x] Chrome
[x] Safari
[ ] Edge
[x] Firefox
[ ] Samsung Internet
[ ] Internet Explorer 11 (not supported, but still needs at least a working user redirect page)

Confident we can use the mutation observe api https://caniuse.com/?search=observer
Worked for all my browsers and phone, let me know if it works for you.


add auth.okta to rendered grafana.ini

Description
It seems after a refactor of grafana.ini rendering, the section renderer for auth.okta was missed.

Hey @jaredstehler , can you rebase this PR? thanks! :)

should be set now?

Ahh.. Another rebase please? @jaredstehler

@HubertStefanski it's a setting that I have done that forces all PR:s to be up to date compared to the latest in the master branch. The reason is so we are 100% sure that the PR won't create any issues with something else, It will also make it possible for us to know that the CI pipelines will be working together with everything in the master branch.
@jaredstehler you will have to rebase this PR. Normally us as maintainers can do it but I don't think you gave that access when creating your PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
I noticed this when I cloned down your fork and tried to push to it. To make it easier for us to do please give us as maintainers that access or you will have to keep the PR up to date so we can merge it.

Okay good to know. Thanks for the pr @jaredstehler!
Nice to have this done, I have a bug fix that needs to get out and this so I will create a new release the coming days and this PR will of course be included.


Use unique store enumerator when saving enumerated attribute vectors.

@geirst : please review

Failing travis build is unrelated.


Allow import of Skill descriptions from Oggdudes, and add a tooltip to the skill on your character sheet pulling the description from the skill compendium

If the sheet could pull from skill descriptions, players would know what the skills definitely do, and how to spend Advantages and Threats.

Unfortunately I think this falls foul of the fan content policy as it would involve displaying sourcebook rules within the game system.
It might also cause compatibility issues for vanilla Genesys, but that's only really a secondary concern.
We have to assume that all players and GMs have access to the purchased sourcebooks and will therefore look up the skill descriptions themselves as needed, along with the tables for advantage, triumph, threat and despair uses.


Resolve Issue #984 constructors.md

Change to clarify model constructor access modifier required when using Lazy Loading Proxies #984

@ajcvickers could you take a look?

@divega @jackapie Agree with the sentiment; maybe tweak the wording a little. Something like, "However, lazy-loading proxies require that the constructor is accessible from the inheriting proxy class. Usually this means making it either public or protected."
(Clearly, protected internal is okay too. Technically it can sometimes be internal (or protected and internal--don't remember the name for that one) when using internals-visible-to, but no need to mention that.)

Thanks @jackapie for the contribution.