Add button attached to modal popup so people can review what they're committing to

Related to #34 we should add a very simple button at the top of sign up that people can click on to review what it means to adopt a drain.
We can wait until we have some approved copy to implement, but it'll just mimic the same pattern used for the Terms of Service link, so shouldn't be hard to implement.
Clearly convey who users should contact if they can't clear their drain on the homepage

@jasonlally should this just use the same copy as the e-mail that is sent when the user adopts their first drain?

Closed by #65

One user didn’t find it obvious that the purple box was clickable (“click here to find out what it means to adopt”). She suggested linking to the “what it means to adopt” language/box in the pop up box that appears when someone clicks on a drain where it says “Sign in to adopt this drain.” Not sure if this is the best solution, or if this is even needed.

Added link to modal in #114

i notice that once a user is signed in the purple box disappears and so does the link in the pop up about what it means to adopt a drain. Is this a mistake? once a user is logged in there is no more information about what they are committing to... thoughts?

That is intentional looking at the code, it's easy to add if we want it though -- it feels like a good thing. I'll open a new issue to track that.

Opened #117, thanks for bringing this up @jeanwalshie !

hi all, i reopened this because we got feedback that the safety message needed to be more prominent. the revised text is here.

Updated in #132, now looks like:

Didn't see #130 before I created mine, merged #130 so this should be good

@jeanwalshie feel free to close this if it looks good to you now!

@jszwedko this looks great, but now i'm thinking we should add this legal text at the end from the other copy just to be safe (and consistent):
"Remember, the City and County of San Francisco won't be held responsible for anything that happens to you or others in service of maintaining your drain. Please be careful!"
(Sorry i didn't catch this earlier!)

@jeanwalshie no worries! Added in #139, looks like:

Awesome @jszwedko thank you! This looks great, but I don't see the language in the app...?

@jeanwalshie I hadn't merged it yet since I wanted to see your thoughts first, but I'll push it through now!

hurray, thanks!


fix: optimize connection module export structure

Types

[x] 🐛 Bug Fixes

Background or solution
fix some errors like:
Error: [egg-core] load file: /release/app/index.js, error: Cannot find module '@opensumi/ide-components/lib/utils/warning'
Require stack:
- /release/node_modules/_@opensumi_ide-connection@2.15.3@@opensumi/ide-connection/lib/browser/ws-channel-handler.js
- /release/node_modules/_@opensumi_ide-connection@2.15.3@@opensumi/ide-connection/lib/index.js
- /release/node_modules/_@opensumi_ide-core-node@2.15.3@@opensumi/ide-core-node/lib/connection.js
- /release/node_modules/_@opensumi_ide-core-node@2.15.3@@opensumi/ide-core-node/lib/index.js
- /release/node_modules/_@opensumi_ide-addons@2.15.3@@opensumi/ide-addons/lib/node/index.js

Changelog
optimize connection module export structure

为啥没有跑测试？

为啥没有跑测试？

pick 了一下 main 分支的 workflow 修改

果然不是那么好修，CI 挂了

Codecov Report

:exclamation: No coverage uploaded for pull request base (v2.15@d429708). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             v2.15     #551   +/-   ##
========================================
  Coverage         ?   59.01%
========================================
  Files            ?     1203
  Lines            ?    73933
  Branches         ?    15300
========================================
  Hits             ?    43632
  Misses           ?    27618
  Partials         ?     2683

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d429708...2689bc4. Read the comment docs.

/public

/publish

这个版本有个 BK，不过是合理的


Station Art not Showing on Browse

Station art images are not appearing when browsing mopidy-pandora stations.  I'll work on this and submit a pull request when I have it figured out.

Exception details:
ERROR    2020-07-03 14:43:36,063 [252:Core-7] mopidy.core.library
  PandoraBackend backend caused an exception.
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/cachetools/cache.py", line 39, in __getitem__
    return self.__data[key]
KeyError: 'pandora:genres'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/mopidy_pandora/library.py", line 144, in get_images
    track = self.lookup_pandora_track(uri)
  File "/usr/lib/python3.8/site-packages/mopidy_pandora/library.py", line 235, in lookup_pandora_track
    return self.pandora_track_cache[uri].track
  File "/usr/lib/python3.8/site-packages/cachetools/lru.py", line 14, in __getitem__
    value = cache_getitem(self, key)
  File "/usr/lib/python3.8/site-packages/cachetools/cache.py", line 41, in __getitem__
    return self.__missing__(key)
  File "/usr/lib/python3.8/site-packages/cachetools/cache.py", line 68, in __missing__
    raise KeyError(key)
KeyError: 'pandora:genres'

@jodal can you please review the PR for this issue?


324 Reset State on Logout

Fixes #324
Creator

[ ] Build relevant tests if any apply
[ ] Ensure there are no new warnings
[ ] Upload an animated GIF showcasing the solution (if it applies)
[ ] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

@burkeshartsis @IsaacHardy This looks like it's working, but I'm pretty concerned about the flashing that occurs when the app is reset. It happens both on native and web. Is there anything I can do to make that not happen?

I could probably just use some direction on what I'm looking for to prove that this is even working. Looking at the cache tab in the Apollo Dev Tools, when I start up the web, there is nothing in the cache for currentPerson. When I sign in the currentPerson gets set with data. When I then log out, the currentPerson still shows data in the cache.
But conversely, before signing in, if I run the currentPerson query, it returns null. Then after I sign in the query returns my person data. After I log out, the query returns null again.
So if the Apollo Dev Tools can be believed, the window.location.reload('true'); function doesn't clear out the cache when the page is reloaded. FWIW, if I just refresh the page manually there is no change in the cache either. I have to physically close the tab for the cache to go away.
I'm not sure what I should be looking at as the source of truth that what I'm seeing is either right or wrong.
@IsaacHardy or @burkeshartsis ... Thoughts?

We can use Client.queryManager.dataStore.cache.data to inspect state easier. I'm writing up a function that takes from this to clear the cache instead so we don't need to do any funky resets

Client.queryManager.dataStore.reset <- this seems to be the magic sauce

Here it is working on web, double checking native

Seems to work on native but we're getting some noise from fetchQueryPromises, turning the whole thing into a promise should fix this.

@Lepozepo Is this ready for review?

Ok guys, this should be ok. Locally everything seems relatively stable. I'm concerned about the router though. ProtectedRoute may be doing damage to the log out flow but I haven't been able to pin point exactly what is causing it.

@Lepozepo Is there a way to see how the ProtectedRoute is doing damage to the log out flow? I'd like to understand this a bit better.

@IsaacHardy I'm not 100% certain yet (will look into it further between today and tomorrow) but it seems that after the logout action is triggered the current route reruns the logic in ProtectedRoute causing a redirect but the current function is also redirecting. Actually, now that I'm typing it out, maybe the solution is to remove the redirect from the onPress handler on LogoutTouchable as the logic for the redirect already exists.

Or we would need to route to a placeholder route while logout is occurring and then redirect

@burkeshartsis Do you know what is still needed for this PR? The above comment from @Lepozepo leads me to believe more work is needed.

Definitely seems like there is more work here. @richarddubay or @IsaacHardy do you feel like you can pick up where @Lepozepo left off?

@Lepozepo I commented out that goBackTo() function call inside the onPress handler. Can you see if that takes care of what you were seeing was the problem? Interesting that the goBackTo() was trying to go to /profile but then was redirecting to /login. Any reason why that wouldn't just go back to the home feed?

The redirect was by design. In talking about it with @conrad-vanl, he and I decided the best UX was to send the user to the login screen (marginally better) when they logged out as opposed to the home screen.

@burkeshartsis So when this gets merged with the other modal styling changes maybe this will be better. Right now if you close the login modal you just end up on an empty profile page. 👍

@richarddubay This is labeled ready for review, am I good to go in reviewing? I felt that we were waiting on this for some reason.

@IsaacHardy I made the change that @Lepozepo mentioned above (to remove the goBackTo() route) so I figured that was enough to get this thing reviewed and moving again.

@IsaacHardy can you take over reviewing this. I'm not completely sure where to begin/pickup testing this.

Mmm, I think the nature of branch is causing this. When props change, renderComponent reruns so redirects are called multiple times. Need to dig a little bit more though, there's also a logical error where, if you're in settings and you log out, settings attempts a redirect (so we don't need to have a redirect function because the component knows to redirect the user) but it redirects to /login and sets the referrer to /settings which is blank because it is "protected". We just need to split the flows there :D

All right guys, I feel pretty safe with this now that ProtectedRoute works as expected on web, just need to test it out on native

Ok ^_^ the behavior of ProtectedRoute is consistent across platforms now. There seems to be noise in native though when you hit the close button (as now it's being redirected properly) and you've been redirected to login where you need to click it twice to close. This issue should be treated separately though. @burkeshartsis @IsaacHardy let me know what you guys think


Usability improvement - field change with tabulator

When I am in the "Edit action" mask, the field change via tabulator does not work.
That means: When I enter the IP address, I want to jump to the "Username" field with the tabulator key.

I feel this is logical only for single line fields. Multi-line fields should behave as-is today.


adjust some color

@Gn3po4g  - looks great!
You just bump the version num to 0.13.0 in source.extension.vsixmanifest?
And then just ping me when you're ready and I will publish.

i think you can merge now

i think you can merge now

Can you see my comment from above? Can you please bump the version num in the visxmanifest? That needs to incremented in order to publish an update on the vs marketplace.

i think you can merge now

Can you see my comment from above? Can you please bump the version num in the visxmanifest? That needs to incremented in order to publish an update on the vs marketplace.

sorry I forgot, is it okay now.

i think you can merge now

Can you see my comment from above? Can you please bump the version num in the visxmanifest? That needs to incremented in order to publish an update on the vs marketplace.

sorry I forgot, is it okay now.

Looks great - thank you for your contribution! I will publish the extension shortly! You should see an update in the visual studio extension store soon.


Add Shadow plugin to create fatJar. Fix archiveBaseName.

This PR fixes the standalone Gradle build script to correctly build a fat jar using the Shadow Plugin.
Additionally, it sets the archivesBaseName so that the output JAR always has the exhibitor name.
With this change, the proper invocation to of Gradle to build the standalone Jar is:
$ gradle assemble

And to launch:
$ java -jar build/libs/exhibitor-1.0-all.jar --help

Is this different than #238?

I like the shadow plugin better than the fatJar plugin. Both accomplish same goal.

Yeah sorry, someone mentioned this to me at work today and I didn't look to see if there was an existing PR. I prefer this implementation over the JFrog, though I'm biased because I wrote Shadow :smile:


fix: release configs

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(ux/ui): build of component #5

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #5
Summary:
Built the initial version of the toast with the appropriate width size for all screen sizes for responsive experiences. When testing locally to confirm the width and height size, I set the background color to something obvious like aqua.
Type of change:

[x] New capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

opening new PR with appropriate branch name.


OnNavigatingFromAsync - can't cancel navigation using MessageDialog confirmation

When navigating away from any page where I want the user to confirm that it's OK to leave I set the Cancel property of the args parameter to true and then show a MessageDialog so that the user can confirm or cancel the navigation. The problem is that the navigation completes before the user can confirm or cancel.
However, if I put the same code in the Page.OnNavigatingFrom override, it works correctly.
Here is a simple Template 10 project showing the issue:
NavigationIssue.zip
To illustrate the issue press the Submit button on the MainPage then hit the back button. The page has already navigated back to the MainPage by the time the MessageDialog pops up.
Repeat but check the CheckBox on the DetailsPage, hit the back button or the Home button on the menu and it was correctly. In this case it is using the code in the code behind file.

Yes, this is true.

I believe this is related to #1237 & #1149 . The future will be  IConfirmNavigation  as in #1261 :

Moving to Prism's  IConfirmNavigation  is the current plan
I think we have to stay with the workaround until T10 2.0 is released. Am I right @JerryNixon  ?

Working on this right now.

Resolved in 1.1.13 (preview)


Update Dockerfiles to build image from PyPi packages, deprecating the RPM model

Impact of the new feature
Every single WMCore service
Is your feature request related to a problem? Please describe.
This is part of the effort migration to PyPi packaging and the deprecation of RPM-based deployments.
Describe the solution you'd like
Once WMCore packages are available in PyPi, we should revisit all the WMCore CMSKubernetes/Dockerfiles and build images based on PyPi (pip install). Directory structure and environment might have to be tweaked.
Note that dependencies still have to be sorted out (e.g., jemalloc, gfal2 tools, rotatelogs, etc), given that PyPi is only meant to manage python-based applications.
Describe alternatives you've considered
Likely dependent on this intermediate step: https://github.com/dmwm/WMCore/issues/11309
and this automated packaging and upload to PyPi: https://github.com/dmwm/WMCore/issues/11276
Additional context
None

I reported progress on this issue over here: https://github.com/dmwm/WMCore/issues/11327#issuecomment-1274828413, https://github.com/dmwm/WMCore/issues/11327#issuecomment-1274838526,  https://github.com/dmwm/WMCore/issues/11327#issuecomment-1274847371
The short summary is the following:
docker images
REPOSITORY                        TAG            IMAGE ID       CREATED             SIZE
<none>                            <none>         e8c4c7efc2f7   About an hour ago   982MB
veknet/reqmon                     latest         ee58f6b49f92   About an hour ago   1.08GB
veknet/wmagent                    latest         568b7b13b718   About an hour ago   1.39GB
veknet/reqmgr2ms-rulecleaner      latest         6f6dbdd52fcf   About an hour ago   1.18GB
veknet/reqmgr2ms-monitor          latest         ccb1893afe6c   2 hours ago         1.18GB
veknet/reqmgr2ms-output           latest         3bdc3a0912d5   2 hours ago         1.18GB

We only have unresolved issue with gfal python package on Debian which is required to build reqmgr2ms-unmerged image. All Dockfiles are present over here: https://github.com/dmwm/CMSKubernetes/tree/master/docker/pypi

We also may need this https://github.com/dmwm/WMCore/issues/11338 to include into Dockerfiles

@vkuznet JFYI for gfal2, Rucio installs gfal2 on a debian/ubuntu based container via conda:
https://hub.docker.com/r/rucio/jupyterlab/dockerfile
Here is another example:
https://github.com/JColl88/sdc1-solution-binder/blob/fc6b771e5e5549e6356cea88ee0ecc05bf561f63/ska/notebook/Dockerfile#L84-L88

@khurtado , the Rucio approach does not work for several reasons:

if I'll use their initial image jupyter/scipy-notebook it provides Python 3.10 which is not certified for WMCore
if I'll use their image in order to copy gfal2 library we deal with shared library issue since it requires boost and python libraries from above image, e.g. here is what I get when I copied gfal2 library from their image to python:3.8 image and tried to load it in python

Python 3.8.14 (default, Oct  5 2022, 15:43:08)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import gfal2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: libboost_python310.so.1.78.0: cannot open shared object file: No such file or directory
>>>

In both case we have a problem. There three solutions here:

use jupyter/scipy-notebook but it implies to use their version of python
build our own version of gfal2 using boost, conda, whatever but it is separate work which I suggest to offload to separate image.
I will try with later to see if it can be done.

@vkuznet hopefully the conda lines in the second example work with a generic debian based container. They use conda for both boost and gfal2 itself

I managed to build gfal within python debain image. This was done using two-layer proceudre:

I created independent gfal image based on python image and anaconda, see https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/gfal/Dockerfile
Then, I adjusted reqmgr2ms-unmerged image to use gfal image as seeder and copied miniconda area into python based image, see https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/reqmgr2ms-unmerged/Dockerfile
The trick was to deal with pip install to avoid installing gfal as dependency. For that, I downloaded requirements.txt, and then skipped gfal from it, then I installed all dependencies manually and finally was able to install via pip reqmgr2ms-unmergedvia pip, please see lines https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/reqmgr2ms-unmerged/Dockerfile#L11-L19
The final build looks like this:

docker images
REPOSITORY                        TAG            IMAGE ID       CREATED          SIZE
veknet/reqmgr2ms-unmerged         latest         1db2bed32221   44 seconds ago   2.12GB
registry.cern.ch/cmsweb/gfal      latest         93385e3a2b9f   49 minutes ago   2.42GB

And, I tested that I can load both WMcore and gfal2 libraries within newly build image.
The flaw with this approach is that we need to use two tags, one is what you tag the python package on pypi, see TAG, and another (since the TAG value does not exist in github tags) for fetching requirements.txt file.
For the reference, here are commits to gfal and reqmgr2ms-unmerged:

https://github.com/dmwm/CMSKubernetes/commit/5f8a6c69cf94a583a7364901dba679b9e6ef888b
https://github.com/dmwm/CMSKubernetes/commit/351a1fccebef6cc94358e16f03217405850b67aa

Please review the proposed image procedure and make your suggestions how to improve it. Due to gfal dependency and cumbersome build I suggest to tag WMCore before putting it on pypi with the same tag. This will eliminate usage of REQTAG and we will only rely on TAG which will be used in GitHub Action build workflows.

@todor-ivanov , please notice how easily image size grow by adding only one gfal dependency. It added additional 1GB due to the fact that it requires shared libs from boost, etc. Therefore, a simple additional of one dependency can cost you quite a lot in a final image.

Thanks for pointing this out @vkuznet . I have never performed gfal2 package size  measurements, because:

it is a must for this service and I am not aware of an alternative so far
the gfal2 dependencies in MSUnmerged have  bad history. At some point we were using the system packages and not building it ourselves. This was leading to a really odd and not quite pleasant way of service setup. So any ideas of substituting this dependency are pretty welcome.

As of the shared libraries from BOOST, I do not see a way fro them to be avoided, since gfal2 has no pure python version but instead uses  boost to port its C code in python. I wonder though if nothing could be done for gfal2-python to be compiled in a more cheap way... But as I said I've never done additional investigation on installed package size, so such thing has never been tried actually.

@todor-ivanov , if gfal code will be statically compiled executable, then we will not have this issue with image. The dependency on shared libraries blow up docker images. And, all python packages which rely on C library, e.g. numpy, scipy, etc. will have the same issue. My point is that choice of language influence the final product (in this case docker image).

Now, about security and gains. I scanned newly built pypi based image and found the following:

reqmgr2ms-output image has

Total: 1218 (UNKNOWN: 1, LOW: 614, MEDIUM: 242, HIGH: 339, CRITICAL: 22)

gfal image Ihas

Total: 1186 (UNKNOWN: 1, LOW: 606, MEDIUM: 233, HIGH: 330, CRITICAL: 16)

reqmgr2ms-unmerged image which now include gfal stuff has

Total: 2622 (UNKNOWN: 0, LOW: 1260, MEDIUM: 1319, HIGH: 43, CRITICAL: 0)

This should be compare to RPM based image, e.g. reqmgr2 which has
Total: 2622 (UNKNOWN: 0, LOW: 1260, MEDIUM: 1319, HIGH: 43, CRITICAL: 0)

Therefore, by switch from RPM to pypi deployment method we gain:

about 1/3 in image size, 1GB of reqmgr2ms-output vs 3.5GB of reqmgr2
about 30% for reqmgr2ms-unmerged image size, 2GB vs 3.5GB
we reduce number of vulnerabilities by factor of 2 if we not using gfal
gfal brings back the same amount vulnerabilities we had in RPM based image

Said that, pypi still gives significant gain both in image size and reduces number of vulnerabilities but it is far from what can be achieved by re-writing services in Go (for the record, DAS/WMArchive have 0 vulnerabilities and their image size is 20MB, while DBS has 82 vulnerabilities due to ORACLE shared libs and its image size is close to 800MB).
For the record, the image scans are done using trivy tool which tool (written in Go) which is used by CERN registry portal. You can also find image scans on registry.cern.ch directly or download trivy executable and run it from local node. Please note I used the following options: trivy image --timeout 10m0s --security-checks vuln <image-name> which may be different from what is used inside registry.cern.ch service but should be close enough. For example, I saw this warning '--security-checks vuln' to disable secret scanning and used this option in my scan, therefore I do not know if secret scanning is enabled on registry.cern.ch and I do not know what it exactly means.

I uploaded new pypi based images to registry.cern.ch:

reqmgr2ms-monitor
reqmgr2ms-output
reqmgr2ms-unmerged
reqmgr2ms-transferor
reqmgr2ms-rulecleaner
reqmgr2
wmaget
gfal

The images have pypi tag and therefore you can use them to install on your k8s dev clusters by using this tag.

@amaltaro , @todor-ivanov , @khurtado , @goughes please proceed with testing new pypi based images in your dev clusters. So far I only build the images, but I did not test if they have anything useful and more importantly if it can run the service. For your information all Dockerfiles used to produce these images can be found in CMSKubernetes/docker/pypi area.

@amaltaro ,do we need anything else for this issue. The Dockerfiles for pypi based images are available at: https://github.com/dmwm/CMSKubernetes/tree/master/docker/pypi

I think the last bit that I would like to see fixed before we can declare this task as done, is to have fully functional manage scripts, such that we can perform the very basic operations such as start|stop|restart|status.
There are some use cases where we might want to test a simple change within the POD, so having the ability to restart the service from within the POD is the only option for such cases.

For the record, here is a CMSKubernetes fix for dealing with different directory/file permissions, after the logs volume is mounted in testbed/production: https://github.com/dmwm/CMSKubernetes/pull/1295

@amaltaro , I had a look at test10 cluster where I deployed recent tag, reqmgr2:2.1.6rc4, and the issue is not in manage script per-se, it stop and start the service, but rather that after we stop the service and start it again it miss something which is required to run it, here is the actual error from the log:
<@---------- WMException End ----------@>
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/WMCore/Services/Service.py", line 150, in __init__
    self["requests"] = requests(cfg_dict['endpoint'], cfg_dict)
  File "/usr/local/lib/python3.8/site-packages/Utils/PortForward.py", line 69, in portMangle
    return callFunc(callObj, url, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/WMCore/Services/Requests.py", line 131, in __init__
    self['key'], self['cert'] = self.getKeyCert()
  File "/usr/local/lib/python3.8/site-packages/WMCore/Services/Requests.py", line 469, in getKeyCert
    raise WMException('Request requires a host certificate and key',
WMCore.WMException.WMException: <@========== WMException Start ==========@>
Exception Class: WMException
Message: Request requires a host certificate and key
        ClassName : None
        ModuleName : WMCore.Services.Requests
        MethodName : getKeyCert
        ClassInstance : None
        FileName : /usr/local/lib/python3.8/site-packages/WMCore/Services/Requests.py
        LineNumber : 469
        ErrorNr : WMCORE-11

Traceback:

Honestly, I have no idea which certificates should be read and where they should be located, and I hope you can provide some insight about them. Once we identify what are those certificate I think we'll only need either to define some env in manage script to make it run.

I think I found the issue. If I change in mange script these lines:
#export X509_USER_CERT=/data/srv/state/$srv/proxy/proxy.cert
#export X509_USER_KEY=/data/srv/state/$srv/proxy/proxy.key
export X509_USER_CERT=/etc/proxy/proxy
export X509_USER_KEY=/etc/proxy/proxy

then it starts the reqmgr2 service. The proxy files in k8s are provided via /etc/proxy/proxy and they are not located in /data/srv/state. So, my question is do we change X509 env in manage script or need to copy proxy file to /data/srv/state/$srv/proxy/ are?

I think this dmwm-base script can answer some of these questions:
https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/dmwm-base/run.sh#L27
for possible environment variables, please refer to the corresponding deployment manage script.

I'd like to keep the manage and the run.sh script consistent, so the answer is neither of the options above. Instead, it should use the AUTHDIR, as defined in the run.sh script, which I link here as well:
https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/dmwm-base/run.sh#L30-L31
I'd appreciate if you can make a PR with the relevant changes and request for a proper review, before pushing changes upstream.

ok, thanks, here is relevant PR: https://github.com/dmwm/CMSKubernetes/pull/1296

@vkuznet Valentin, as reported by Todor a few hours ago in this comment:
https://github.com/dmwm/WMCore/issues/11413#issuecomment-1376343339
we are having problems with the t0_reqmon/t0_reqmon-tasks services in CMSWEB testbed.
I just verified that cluster and I see that t0_reqmon pods are running, but it turns out they had a problem when starting up the service. This is what I can see from the logs (skipping some information not suitable to be shared):
amaltaro@lxplus8s17:~/CMSKubernetes/kubernetes/cmsweb $ kubectl logs t0reqmon-tasks-6c4678dcfc-vsbsl t0reqmon-tasks -n dmwm
...
chown: cannot access '_t0_reqmon._t0_reqmon': No such file or directory
t0_reqmon not running, not killing
...

I had a look at the Dockerfiles and the run.sh script, and I cannot spot any errors that could cause it. I could also confirm that those services are using the latest dmwm-base image (from Jan 6th). Could you please have a look into this?

@amaltaro , there are two issues:

issue with chown command in run.sh, see my fix here https://github.com/dmwm/CMSKubernetes/commit/5b8d77ffdec5d07d390699fdea16da161eb6de58
issue with WMCore code

Traceback (most recent call last):
  File "/usr/local/bin/wmc-httpd", line 3, in <module>
    main()
  File "/usr/local/lib/python3.8/site-packages/WMCore/REST/Main.py", line 617, in main
    server.start_daemon()
  File "/usr/local/lib/python3.8/site-packages/WMCore/REST/Main.py", line 406, in start_daemon
    logger = open(self.logfile, "a+", 0)
ValueError: can't have unbuffered text I/O

I saw this issue in my local setup too and it can be fixed by changing
logger = open(self.logfile, "a+", 0)

to
logger = open(self.logfile, "ab+", 0)

Since I did not use this code I saw that may be it was a trick somewhere (or different version of python), but the open should have b flag to avoid this error. Once I manually fixed both problems I was able to start the service in one of the pods.

Thanks Valentin.
I created a new dmwm-base image and provided a PR to use it in the WMCore dockerfiles:
https://github.com/dmwm/CMSKubernetes/pull/1297
once it gets merged, we can cut another WMCore tag and get the images automatically available.
For the python issue, we have been successfully running all the other services with the same codebase. I suspect the issue is somewhere else. Let's see how it goes with the new image.

And reason why t0_reqmon wasn't working is that the namespace map was wrong (other than the run.sh fix provided by Valentin). Here is a reference to the services_config changes:
https://gitlab.cern.ch/cmsweb-k8s/services_config/-/merge_requests/188
Now we have 2.1.6rc6 deployed to cmsweb-testbed (which includes fix to the manage script).

Today we completed the migration away from the RPM model, and CMSWEB production services are now running Pypi-based packages (version 2.1.6).
@vkuznet from my side we can now close this issue out. What do you think?

@vkuznet I think you will agree with me on closing this issue out. In case you do not, please feel free to reopen it. Once again, thanks for driving this migration!


4.3: RichTextLabel.text = "" no longer clears contents and RichTextLabel.clear() no longer has an effect outside of scene tree

Tested versions
Reproduced in 4.3-dev4. Not reproducible in 4.2.1-stable.
System information
Windows 11
Issue description
I'm not 100% sure if this is in fact a bug, but it is at the very least an unexpected version incompatibility.
The behaviour of RichTextLabel.clear() and RichTextLabel.text = "" is different between Godot 4.2 and 4.3.
The context is instantiating a scene with a single RichTextLabel containing some placeholder text, and then immediately clearing the text when adding the instantiated node to the scene tree (the placeholder text is useful for testing the RichTextLabel scene in isolation).
In Godot 4.2:

When calling clear() or setting text = "" before the node is added to the scene tree (between instantiating a scene and calling add_child), the RichTextLabel will appear empty as expected.

In Godot 4.3-dev4:

When calling clear() before the node is added to the scene tree (between instantiating a scene and calling add_child), the RichTextLabel still has the placeholder text from the original scene.
When setting text = "", either before or after add_child, the original text remains visible. This means you essentially have to call both clear() and set text = "" to fully reset the contents.

Steps to reproduce
extends Control

const TextLabel := preload("res://rich_text_label.tscn")

# Produces expected behavior in 4.2, but in 4.3

func _ready() -> void:
	var label := TextLabel.instantiate() as RichTextLabel
	label.text = ""
	add_child(label)
	#label.clear() # uncommenting this line will produce the expected behavior in 4.3
	label.text = "" # commenting this line will still produce the expected behavior in 4.2

Minimal reproduction project (MRP)
RichTextLabel-Bug-4.3.zip

It's due to this code:
https://github.com/godotengine/godot/blob/f2045ba822bff7d34964901393581a3117c394a9/scene/gui/rich_text_label.cpp#L5678-L5681
CC @YeldhamDev


Provide support for building in Intellij Rider

Follow up to https://github.com/3F/DllExport/issues/141#issuecomment-608103235
I just tried using DllExport for a simple task. Found the repository and while using Rider landed on this topic.
Building in Visual Studio just works. I have no idea what is really happening and what steps should one perform to investigate this topic because of my little to non knowledge about C# and build chains. Maybe someone can provide more context.

Hello,
Are there any problems using the msbuild together with Intellij Rider? I think most modern IDEs provide options to build using msbuild, isn't it? it's important part of SDKs including dotnet etc.
As I voiced in #141

Even officially they (*MS team) recommends to use exactly this instead of dotnet build for some related problems with tasks etc.

To build your configured project, for example:

"path to MSBuild.exe" /p:Configuration=Release

or using hmsbuild that helps with MSBuild tools

hmsbuild ~c Release

Hello,
Are there any problems using the msbuild together with Intellij Rider? I think most modern IDEs provide options to build using msbuild, isn't it? it's important part of SDKs including dotnet etc.
As I voiced in #141

Even officially they (*MS team) recommends to use exactly this instead of dotnet build for some related problems with tasks etc.

To build your configured project, for example:

"path to MSBuild.exe" /p:Configuration=Release

or using hmsbuild that helps with MSBuild tools

hmsbuild ~c Release

Hey I am sorry but I don't longer remember anything about the topic.

I see. I'm closing the issue. Feel free to open a new one if you discover a new problem or question.


copy files to different directory

Hello,
I am trying to watch and copy the files to different directory if there's any change to the files. I've tried different combinations/options but still can't get only the files to new directory.
watch directory: src/html/*
new directory: build/html/
The best result I can get is: src/html/build/html/some-files.html
I also tried to give cwd the path (src/html) with the src:"*", but the result is a copy of every files and subdirs of the project root.
I've been googling and going through forums but still can't find an answer to my problem.
Your help is greatly appreciated,
Niusaul

@tkellen very helpful, thank you!


Fix/pagination buttons to move my focus to the top of the page

Description

When a user clicks on a pagination button (either backwards or forwards) they are navigated to the top of the page
Blogs, webinars, search, lesson browsing (units, lessons)
When you are moved to the top of the page, have focus be on the first list item so that you don't have to navigate through nav stuff
adds tests

Notes:
A ref is added to the first item of the list, if there is a page in the query props and a ref it calls focus on the ref.
@jack-skerrett-oak Limitation of this approach is that a shared link with a page in the query will focus on the first list item when the page loads.
Because the the list items already uses a ref from clickableCard I have refactored clickableCard to take an external ref, this is passed to the list item via primaryTargetProps
Issue(s)
Fixes #1354
How to test

Go to Blogs, webinars, search, lesson browsing (units, lessons)

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

:tada: This PR is included in version 1.187.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support for setting balance

I needed to be able to control the speaker balance, so I monkey patched support for it in my own script. I basically copied the volume getter/setter in core and change the volumes of the LF and RF channels. Works nicely on my paired Sonos Ones. Here is the gist of it, if anyone is interested.
def get_balance(self):
    """Get the speaker's balance.

    @return: A 2-tuple with integers between 0 and 100.
    """

    response_lf = self.renderingControl.GetVolume([
	('InstanceID', 0),
	('Channel', 'LF'),
    ])
    response_rf = self.renderingControl.GetVolume([
	('InstanceID', 0),
	('Channel', 'RF'),
    ])
    volume_lf = response_lf['CurrentVolume']
    volume_rf = response_rf['CurrentVolume']
    return int(volume_lf), int(volume_rf)

def set_balance(self, left, right):
    """Set the balance."""
    left = int(left)
    right = int(right)
    left = max(0, min(left, 100))  # Coerce in range
    right = max(0, min(right, 100))  # Coerce in range
    self.renderingControl.SetVolume([
	('InstanceID', 0),
	('Channel', 'LF'),
	('DesiredVolume', left)
    ])
    self.renderingControl.SetVolume([
	('InstanceID', 0),
	('Channel', 'RF'),
	('DesiredVolume', right)
    ])

Inspiration by https://github.com/jishi/node-sonos-http-api/issues/454 and https://github.com/chregu/fhem-sonos/blob/b6a97be8015b70644d71d74bf8224dcb20833a75/FHEM/00_SONOS.pm#L1207

Good work -- this is useful and personally I'd like to see it included in SoCo.
Are you going to put up a PR? If not, I'm happy to do so on your behalf. I've created a commit of the code above, with normalised docstrings at: https://github.com/pwt/SoCo/commit/ee671361768f12fe23124a524840c6ea8b1acaa4.
Feel free to grab this. It passes pep8, flake8, and the docstrings are consistent with the rest of SoCo.

That's great! Please take over, I don't have the time :)
Den tors 28 nov. 2019 12:24pwt<EMAIL_ADDRESS>skrev:

Good work -- this is useful and personally I'd like to see it included in
SoCo.
Are you going to put up a PR? If not, I'm happy to do so on your behalf.
I've created a commit of the code above, with normalised docstrings at:
pwt@ee67136
https://github.com/pwt/SoCo/commit/ee671361768f12fe23124a524840c6ea8b1acaa4
.
Feel free to grab this. It passes pep8, flake8, and the docstrings are
consistent with the rest of SoCo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SoCo/SoCo/issues/692?email_source=notifications&email_token=ACIMF5KM65U4NZD2XSOQRI3QV6S7FA5CNFSM4JSR2CQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFMJYII#issuecomment-559455265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACIMF5JWZBA5P6DO762IUTLQV6S7FANCNFSM4JSR2CQA
.

Ok, great! I'll look at adding some unit tests then pushing it as a PR. I'll credit you. (I've already functionally tested the code against my Sonos systems and it works perfectly.)

Awesome! Thank you!
Den tors 28 nov. 2019 12:38pwt<EMAIL_ADDRESS>skrev:

Ok, great! I'll look at adding some unit tests then pushing it as a PR.
I'll credit you. (I've already functionally tested the code against my
Sonos systems and it works perfectly.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SoCo/SoCo/issues/692?email_source=notifications&email_token=ACIMF5O7UKPJQYMCTMPHQ5TQV6UTTA5CNFSM4JSR2CQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFMK7AY#issuecomment-559460227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACIMF5MHNMHPPPNKHEVZWWDQV6UTTANCNFSM4JSR2CQA
.

The PR (#693) is up. I changed the implementation from method calls to operations on a balance property, to make it more consistent with the rest of SoCo. I added unit tests and normalised the docstrings.

Thanks a lot! :) Yeah, I just monkey patched the instance, and shortcut the whole omg-I-don't-know-if-the-property-and-setter-decorators-work-when-monkey-patching discovery process by using a plain old getter and setter :)

@tephlon thanks a lot for forwarding the information and thanks to @pwt for putting it into a PR. I will have a look at it as soon as I can.

Closed with #693

Thanks a lot, @pwt and @KennethNielsen!


Breaking change: configure the wiki URL instead of confluence domain

@satrox28 do you still need something like this PR or could you make it work without?

Confluence urls not mandate to have /wiki. I feel it's better to let users configure the full url from the app-config.yaml

Hi @K-Phoen any update on this PR?.

@K-Phoen will you be merging this changes?.

@K-Phoen  can it be released?.

@satrox28 Yes, I will be merging this.
One thing I would like to voice though: unless I am sponsored by an individual or a company, I work on this plugin on my own time. If and when I have time. If and when I feel like it.
Pinging me repeatedly on a PR does not help. I hope you will understand my position :)


[UX enhancements] amp stack rm

Include the following output on the CLI when a stack is removed -
    $ amp stack rm counter
    [localhost:50101]
    Removing stack counter
    Stopping services:
    Service go has been successfully stopped.    ← Should block until ready
    Service redis has been successfully stopped. ← Should block until ready

    Stack counter has been successfully removed.

Unfortunately, what we have done with out previous stack management when we handled ourselves stacks is not possible with the docker one.
Docker didn't provide api verbs to manage stack. It only provide CLI commands. We have forked Docker code to make them usable by our api, but we can control the inner work of the command.
Especially, we can't wait at each service. We can act before and after that's all.


Add Bounding Box Ops

As part of #1226, relevant image bounding box operations need to be added to tfa.image. List of ops tracked in this issue (tick the op only once the corresponding PR is merged):

[ ] TranslateX BBox
[ ] TranslateY Only BBoxes
[ ] ShearX BBox
[ ] Rotate BBox
[ ] Cutout Only BBoxes
[ ] ShearY BBox
[ ] ShearY Only BBoxes

Reference: https://github.com/google-research/simclr/blob/master/data_util.py

Similar to #1333, #1353

Per https://github.com/tensorflow/addons/issues/1366#issuecomment-634902190 these features would better fit in:
https://github.com/keras-team/keras-cv


Make sure all standard interceptors work when no db is returned in an fx-handler

All of the interceptors should be checked to make sure that they work correctly when no db is returned in an fx-handler. I know there is a bug in at least enrich.

Enrich was the only one where this was an issue.


chore: add text to bottom tab icons

This PR resolves ONYX-871
Description
This PR adds text to the bottom tabs. This comes as an attempt to make our tabs more clear to users

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

add text to bottom tab icons - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (add text to bottom tab icons - mounir)

  Generated by :no_entry_sign: dangerJS against 4db325d19cbd6a4b37a91d7b04dc722c01a45e91


Change helm chart location to public registry

Description of changes:

Helm charts are currently located in public registry but only images are located in private registry.

Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/cherry-pick release-0.11


Remove image links in PDF

I'm working on a documentation that includes a lot of screenshots. To make small details better readable, each screenshot is linked to the original image. If I click on a screenshot, the corresponding image is opened in its original full screen resolution. This works perfect in the HTML version of the documentation. But in the exported PDF these links are preserved which causes broken links. All images are stored in the folder /images. So, if I click on a linked image in the PDF it tries to open the image from the folder /images, which obviously does not exist.
Is there any way to keep linked images in the HTML output but disable all image links in the PDF output?

I was able to remove the image links by adding the file pdf_event_hook.py as described here. In this file I added the following code to the pre PDF render section:
def pre_pdf_render(soup: BeautifulSoup, logger: logging) -> BeautifulSoup:
    logger.info('(hook on pre_pdf_render)')

    # Remove image links
    for img in soup.find_all('img'):
        if img.parent.name == 'a':
            img.parent.unwrap()

    return soup


Network adapter request

Any way to implement these feature using native WiFi connection or 4G/5G connection?

Is it possible? Maybe.
It's highly dependent on if Talhreth left the network functionality of the core untouched, which knowing him he may have stripped out for performance reasons. We've only started modding the core itself with some reverse engineering, so if it's possible to enable with minor effort, it may be a future feature. If it requires a mountain of work to implement, it probably won't happen

Out of curiosity, mainly just as a check in, do we have an idea on if this development has changed or if it has been looked into? It doesn't seem like a bad idea to have internet functionality, so long as the networking functionality is still intact. I'm hoping so, since many old online games would be wonderful (yet probably insanely difficult) to run through the emulator.


Config option to hide introduction

There's no way to globally hide the introductive help overlay.
Maybe once there was the concrete.misc.seen_introduction option, but now it does not affect anything.
What about adding a new concrete.misc.help_overlay option?

Ohhh, I was exactly looking at this option. Thanks!


Reject parent with overflow set to visible

@iamdustan this fixes issue #36 review when you have time to see if I am missing something.
Description: in cases where the overflow style property is set to visible and children are absolute positioned the script needs to scroll the body instead of the scrollable parent.
@KitaitiMakoto with this fix, the example you provided in theh first comment of the issue is mitigated; after merged test it on your project locally to see if it works there too.

This looks legit to me, @jeremenichelli. Do we want to land this along with any other open PRs and cut another release?

@iamdustan this is en edge case so I prefer to wait a few days and see what happens with https://github.com/iamdustan/smoothscroll/pull/42 so we can ship both.
Plus, if I have time, I might do the regular revision I do and see if there's room for improvements in code or build steps.


Move caser from a global variable to a local variable

(This is split change from https://github.com/Admiral-Piett/goaws/pull/339)
Problem
Parallel "Publish" request to a single goaws instance will randomly corrupt DataType values like below:

S\u0000ring
\u0000\u0000\u0000\u0000\u0000\u0000
Sring\u0000
S\u0000tingg

Cause
We should keep enclosing Caser instance in a request thread.
<EMAIL_ADDRESS>
A Caser may be stateful and should therefore not be shared between goroutines.

There is a similar issue with this problem.
https://github.com/golang/go/issues/59520
How reproduce and confirm the fix
We faced this problem with our business application but you can reproduce the same issue with the below code.
var caser = cases.Title(language.AmericanEnglish)

var dataType = []string{"String", "Binary"}

func TestCaser(t *testing.T) {
	for r := 0; r < 100000; r++ {
		var wg sync.WaitGroup
		for i := 0; i < len(dataType); i++ {
			name := dataType[i]
			wg.Add(1)
			go func() {
				fmt.Println(caser.String(name))
				wg.Done()
			}()
		}
		wg.Wait()
	}
}

You can confirm the fix in this PR works with this code.
var (
	caser = cases.Title(language.AmericanEnglish)
	mu    sync.Mutex
)

var dataType = []string{"String", "Binary"}

func formatTitle(input string) string {
	mu.Lock()
	defer mu.Unlock()
	return caser.String(input)
}

func TestCaser(t *testing.T) {
	for r := 0; r < 100000; r++ {
		var wg sync.WaitGroup
		for _, input := range dataType {
			wg.Add(1)
			go func(input string) {
				defer wg.Done()
				fmt.Println(formatTitle(input))
			}(input)
		}
		wg.Wait()
	}
}

Hi @Admiral-Piett, we found the root cause of the strange behavior of caser we noted in https://github.com/Admiral-Piett/goaws/pull/339. Could you please review this?

@kojisaikiAtSony Awesome!  Thank you so much for the detailed write up as well.  That's SUPER helpful for me to figure out what I'm looking at.  If you want to throw your nice mocked out test in there too for bonus, that would be cool, otherwise I'm ready to merge it as is.  Up to you, so just let me know!

I added the mocked out test but it's not passed CI yet... please wait 🙇

Hi @Admiral-Piett , I added the test TestPublishRequest_SetAttributesFromForm_success_concurrent. If the caser instance moved to global, the test may be failed with assertion error or panic randomly.


Update testfairy-upload-ios.sh to get the direct download URL

Checklist

[x] I've read and followed the Contribution Guidelines
[x] step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update
Context
Quick fix to get the direct download URL, as now, the url given requires users to be logged in.

Changes

Added app_url to the list of variables get from the JSON.
Added this value into a returned variable on bitrise.

Investigation details

Decisions

This works, but does not seem to produce a direct URL. Even when filling in the domain, it requires login too.
* **Build URL**: [https://777267.testfairy.com/projects/6984296/builds/10532949](https://777267.testfairy.com/projects/6984296/builds/10532949)
* **APP URL**: [/projects/6984296/builds/10532949/download](/projects/6984296/builds/10532949/download)

on my case app_url contains exactly the following (extracted from the JSON):
"app_url": "https://my.testfairy.com/download/{RANDOM_NUMBER_HERE}/getapp"
and it goes straight into the download page, working for logged out people too.
Maybe you have some option disabled? because it has also the domain added on my side.


[SPARK-32212][CORE]RDD.takeOrdered can choose to merge intermediate r…

…esults in executor or driver
What changes were proposed in this pull request?
Add an optional config to determine whether the intermediate results(local TopK) of each partition in RDD.takeOrdered will be merged in driver process or executor process. If set to true, merge in driver process(by util.PriorityQueue), which will get shorter waiting time for return. But if the intermediate results are too large and too many partitions, the intermediate results may accumulate in the memory of the driver process, causing excessive memory pressure. If set to false, merge in executor process(by guava.QuickSelect), intermediate results will not accumulate in memory, but will cause longer runtimes.
Why are the changes needed?
The problem with original implementation is that if the intermediate results are too large and too many partitions, the intermediate results may accumulate in the memory of the driver process, causing excessive memory pressure.
Does this PR introduce any user-facing change?
Adds configuration parameter
"spark.rdd.takeOrdered.mergeInDriver" (default: true)
How was this patch tested?
Added UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I'd rather not expose yet another config for this. Are there any heuristics that can select this more intelligently?

Thank you very much for code review.
The idea of heuristic selection is like:
mergeInDriver = intermediateResultsTotalSize < getConf("spark.driver.maxResultSize")
The intermediate result is the local TopK result of each RDD partition. We can know that the total number of items is partitionNum * k. However, due to uncertain length objects such as string or user-defined classes, the total size cannot be estimated before all partitions are executed.
In most user applications, mergeInDriver = true, then the localTopK merge begins after the second RDD partition result is returned, and the merge process and the RDD partition compute process are parallel. This can obtain the shortest result return waiting time. Collecting the information needed for heuristic selection will have a negative impact on the performance of such applications.
mergeInDriver = true may cause program errors in two types of applications:
The result data contains large objects, such as large strings or large user-defined classes.
Driver applications with high memory pressure, such as multi-user spark/sql/hive-thriftserver.
There may not be a good way to not expose this config.
Maybe I can add a user-friendly log about this config.
something like:
try {
    mapRDDs.reduce { (queue1, queue2) =>
     ...
    }
  } catch {
   case e: SparkException if e.getMessage.contains(MAX_RESULT_SIZE.key) =>
     logError(s"Total size of serialized intermediate results is bigger than " +
       s"${MAX_RESULT_SIZE.key} (${Utils.bytesToString(conf.get(MAX_RESULT_SIZE))}). " +
       s"If the final result size is less than this value, you can set the " +
       s"config ${RDD_TAKE_ORDERED_MERGE_IN_DRIVER.key} to false to complete " +
       s"the intermediate result merge in executor. But this config will " +
       s"increase the return time of the takeOrdered function.")
     throw e
  }


Fix typo in README

Ha! 😛 Gosh I never fail to slip in such blatant typos. Thanks for the fix!
p.s. I'd like to more fully flesh out this mode, but would need some help. If you're familiar with writing language modes, I'd love to collaborate!


feature: Use NavigationSplitView rather than TabView for iPad #6

What it Does

Closes #6
I have added NavigationSplitView logic into MainTabView struct. This addition is mutating only iPad version right now (completely works) and should affect MacOS version as well in the future (MacOS isn't building as of now). iPhone proceeds with TabView navigation. I have also refactored the code - added extension to hold @ViewBuilder views for better reusability and more readable code - because at the end of the day TabView and NavigationSplitView use the same content.

How I Tested

I have tested this new feature on Previews first and later on Simulators.
Tested on iPhone 15 Pro Max - 17.0.1
Tested on iPad Pro 12.9 inch - 17.0.1
iPad shows NavigationSplitView navigation - can be toggled to be shown/hidden.
iPhone shows TabView navigation.

Notes

There is a comment I have left in the code that TabSelection enum can be changed to conform to String rather than Int. If needed can be easily swiped out, currently is left as is.

Screenshot

Two screen recordings - iPad and iPhone.

https://github.com/mikaelacaron/Basic-Car-Maintenance/assets/18750749/7eda95ac-3913-426c-b3a7-eb210ba943b9
https://github.com/mikaelacaron/Basic-Car-Maintenance/assets/18750749/d78bad15-0f16-486e-bf8c-3a3612f3d982

@mikaelacaron hi, hope all is well 😄 did you have the chance to look at the PR?

@windrunner21 No I haven't, and it's the holidays so I'm not going to be looking at this today. You'll see my review when I have time

@mikaelacaron oh sorry, you are right, I totally forgot about it. Merry Christmas! Have a great holiday 🥳

hey @mikaelacaron, sorry for the late reply, still on holidays! I'll update PR with requested changes by Sunday latest.

@windrunner21 No worries at all! Take vacation! 👍

@windrunner21  After you address all the comments, please click the re-review button

Also if you fix something I mentioned and don't have any questions, go ahead and click the Resolve button, but if you have a question, you can comment on that question directly

@mikaelacaron I didn't click it yet because I still have to solve the bug with reopening the same tab after relaunching application. I wanted to solve everything and then request review 😄

Yup! You should resolve everything for sure! I just mentioned this cause I got notified you were working on it haha
And I saw that I didn't mention it in my first review

@mikaelacaron just finished with the bug fix, implemented it in such a way that TabView / NavigationSplitView are having the same last opened tab.

@windrunner21 thanks for working on this! haha just now finally getting around to finishing up the final bits of this project to launch it


Add CONTRIBUTING.md with DCO

The DCO is copied verbatim from Helm.
A Github App can be enabled to provide DCO gating for the PRs with https://github.com/apps/dco#usage (click "configure").
I would be happy enabling it once this is merged.

Forced pushed with signoff, DCO bot works.


code / add find_or_create / first_or_create

a la ActiveRecord.
might benefit / need transactional Retrieves for this, also.

All of this now lives on latest_dev


D110 disconnects when I attempt to print the sample figure

I am on Kubuntu 22.04 and tried to use this tool for the D110 model using Python 3.11. Initially, it connects just fine to the Bluetooth, but when I try to print anything like the example picture, it disconnects:
(.venv) *[main][~/.../niimprint]$ python -m niimprint -c bluetooth -m d110 -a 03:04:02:9A:EA:21 -r 90 -i examples/B21_30x15mm_240x120px.png
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/<REDACTED>/Documents/repos/niimprint/niimprint/__main__.py", line 96, in <module>
    print_cmd()
  File "/home/<REDACTED>/Documents/repos/niimprint/.venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<REDACTED>/Documents/repos/niimprint/.venv/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
          ^^^^^^^^^^^^^^^^
  File "/home/<REDACTED>/Documents/repos/niimprint/.venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<REDACTED>/Documents/repos/niimprint/.venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<REDACTED>/Documents/repos/niimprint/niimprint/__main__.py", line 71, in print_cmd
    transport = BluetoothTransport(addr)
                 ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<REDACTED>/Documents/repos/niimprint/niimprint/printer.py", line 66, in __init__
    self._sock.connect((address, 1))
OSError: [Errno 112] Host is down
(.venv) *[main][~/Documents/repos/niimprint]$

I have also tried to connect to it via USB, but when I plug it in, nothing new shows up when I do ls /dev/tty*. Is this a driver issue?

Oh btw, I have also tried it without the -r 90 argument

@icarosadero for bluetooth connection, I suggest trying connecting to different addresses (check readme for details). The problem could also be in keepalive (you need to print something quickly after connecting). For USB connection, by default the printer is just charging, so you need to press its power button to wake it up.


Pre-release is tagged with latest tag

Hi, I'm a big fan of this library because it really helps me in configuring a monorepo with semantic release. However, I've encountered a single issue related to prereleases. In my release configuration, I've specified "beta" as a prerelease, but when I trigger a prerelease, the package gets released with the "latest" tag instead of "beta." Do you happen to know how I can set this up correctly, or is this possibly an issue specific to semantic release? Interestingly, I have a standard repository with a similar configuration, and I don't encounter this problem there. Thank you for your help!
Here it is how I specify branches in config:
branches: ['main', {name: 'beta', prerelease: true}]

Hmm. The library just uses multiple release configs. Did you add the config to the top-level release config or to a release config of a library?

@kreuzerk I just use npx nx g nx-release:configure and then in the root I changed branches: ['main'] to branches: ['main', {name: 'beta', prerelease: true}]
I have lib called foundation and inside project.json I have this
"release": {       "executor": "nx-release:build-update-publish",       "options": {         "libName": "foundation"       }     }
When I created branch beta and pushed to github it released the correct beta version of the lib but the tag was latest and not beta
This is output from github:
npm notice === Tarball Details ===
npm notice name:          @mononxtest/foundation
npm notice version:       1.2.0-beta.1
npm notice filename:      mononxtest-foundation-1.2.0-beta.1.tgz
npm notice package size:  844 B
npm notice unpacked size: 1.3 kB
npm notice total files:   8
npm notice
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access

Hi @kreuzerk and @devdanco,
we have a similar issue which we traced back to this issue: When we are specifying a channel in the release config like it is documented here https://github.com/semantic-release/semantic-release/blob/master/docs/usage/workflow-configuration.md#channel the tag is also always latest.
It looks as if the issue is in https://github.com/kreuzerk/nx-release/blob/main/libs/nx-release/src/executors/npm-publish/executor.ts#L14 because npm publish is called without the --tag option (https://docs.npmjs.com/cli/v10/commands/npm-publish#tag)
Any updates on the issue?

If you're on Nx 18, you can take advantage of Nx Release for the publishing step which allows you to specify a tag. I ended up tweaking the @semantic-release/exec plugin section of release config like so:
[
      '@semantic-release/exec',
      {
        // keep the release target on your publishable projects but update each project.json to use `update-version` executor instead of `build-update-publish`
        prepareCmd: `VERSION=\${nextRelease.version} npx nx run-many -t release`,

        // allow Nx Release to take care of publishing
        prepareCmd: `npx nx release publish --tag=\${nextRelease.channel}  --dry-run`,
      },
],

I also had to make a few changes to nx,json. I had to configure the release section and add the following to targetDefaults. Your configuration may differ based on how your workspace is structured.
      "dependsOn": ["build"],
      "options": {
        "packageRoot": "{workspaceRoot}/dist/{projectRoot}"
      }
    }

Still have some more testing to do but so far it looks pretty good.

@nivekcode I've prepared a Pull Request that could help resolving the issue that people in this thread encountered. Hope it helps :)


camera-imu calibration by Kalibr. OverflowError: bad numeric conversion: positive overflow

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
(Ubuntu 16

Kernel Version (Linux Only)
4.15.0-128-generic

Platform
PC

SDK Version
2.40.0

Language
C

Segment
Robot

Issue Description
<Describe your issue / question / feature request / etc..>
Hi,
I'm sorry to ask about a problem with Kalibr here. I have posted an issue in the Kalibr repository about my problem. I want to calibrate the extrinsic between the camera and IMU. But it seems like the timestamp of IMU causes the kalibr_calibrate_imu_camera of Kalibr crash. How do you calibrate the extrinsic between the camera and IMU? Could you please provide some advice? Thanks a lot!

The link below has a project that provides  an IMU calibration file for D435i.
https://github.com/SainaRez/navigation_scripts#calibration
https://github.com/SainaRez/navigation_scripts/tree/master/Utility/imu_intrinsics

Hi @MartyG-RealSense
Thank you for your reply, but it seems like he did not have the same problem as me.

Their calibration command follows the same structure as the one that you posted in your Kalibr topic.  Does the D435i yaml file provided in that project not assist with your own calibration problem please?


Update cargo import for uuid to enable the V4 features for creating n…

…ew Uuids
I want to use mentat_core::Uuid in the storage prototype, but I want to access some features that are only enabled with the V4 features. This patch enables V4 features for the current version.

RFC 4122 advises that "distributed applications generating UUIDs at a variety of hosts must be willing to rely on the random number source at all hosts. If this is not feasible, the namespace variant should be used."
@fluffyemily, what's missing without this? Is there a reason not to use a type 1 UUID?

@rnewman I guess I was using the new_v4 function already. Even new_v1 requires the enabling of the V1 crate, but I suppose new(UuidVersion::Mac) will do?

Yeah, Mac should be fine — it'll ensure global uniqueness. The only reason to use a V4 UUID is if you would rather have randomness than leak some device identifiers in order to get uniqueness…


Discuss Early Stage Backend RoadMap

Discuss and design the early backend roadmap with @MacAndersonUche
Summary
Looking to build a simple, cost-effective, if not free, backend solution for the https://github.com/TeamPetPoison/pet-poison-alert client app.

Cost-efficient or free
Easy to maintain and scale

Early Requirements
In no particular order

Auth - considering using AWS cognito?

DB - DynamoDB? - form responses and querying/filtering against the DB

users have all CRUD ops for their own created forms
users have read-only access to other forms
users can comment on a form to create a thread/discussion like a post in social media

APIs - API Gateway + Lambda

Storage - S3 for user photos

spam and abuse protection: rate limiting, backoff, and recaptcha

More to follow

@MacAndersonUche can we have your thoughts on this?
Is it feasible to use AWS and keep the cost down to something very affordable or almost zero?

@MacAndersonUche any follow-up on this? Thanks, buddy - CTO👍


Fields that default to empty string have unexpected behavior

Environment

Elixir version (elixir -v): 1.3.2
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): PostgreSQL 9.5
Ecto version (mix deps): 2.04
Database adapter and version (mix deps):
Operating system: OS X

Current behavior
The commit for empty_values (https://github.com/elixir-ecto/ecto/commit/af26b32854dce236cffc7e36ad0b9acad89969b7) has caused some unexpected behavior for fields that you want to default to empty string.
I have a notes field defined like this:
field :notes, :string, default: ""

When I create a changeset without a notes key, the column gets correctly set to "" in the DB.
When I create a changeset with notes set to "", the field gets sent to the DB as NULL. This breaks a not-null constract I have on that column.
Expected behavior
A few things here:

I'm not sure converting to nil is the right answer here. I understand the reasoning to do this (HTML forms don't send nil/null), but is that really in Ecto's scope to handle? Empty string and nil are semantically different and to treat them the same by default feels like over-reach and coupling Ecto too tightly to the web (Ecto 2.0 was designed to be a move away from over-reach, right?). Perhaps empty_values should be opt-in instead of set to [""] by default?
I've set a default on this field. If the default is set and I've set it to an empty value (nil or "" in this case), I'd expect it to use the default value.
empty_values as a setting on the entire changeset feels too coarse. I'd like to say "Hey just for notes, don't use "" as an empty value" instead of setting empty_values to [] for the entire changeset.

Thanks for this great library!

Good catch, this is a bug. We will fix it and release a new version. :)

Thanks José!
On Thu, Aug 25, 2016 at 8:53 AM, José Valim<EMAIL_ADDRESS>wrote:

Closed #1648 https://github.com/elixir-ecto/ecto/issues/1648 via 16d99ed
https://github.com/elixir-ecto/ecto/commit/16d99ed8a98d16c0a4d542cb2d0261d32d8d5ae7
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/elixir-ecto/ecto/issues/1648#event-767657581, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArMuIiLwixOCpMX474Mlhd6pSDrbvRNks5qjbqBgaJpZM4JsxQJ
.

@josevalim just making sure... was that commit supposed to close #1649 instead? This doesn't seem related at first glance.

Yeah, this looks like an error, I'm going to open this back.

Yup, my bad!
--
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I've had to fix some validations when updating to ecto 2.0 because of this issue. Not a big deal, but I was surprised by the new behaviour.

@bgeihsgt can you please try master out and let me know if it works as expected? Thank you!

Worked like a charm, thanks @josevalim!

What is the way to actually change a value from nil to ""?
I have a real use case: answer to a question can be empty, and I won't ask it again. But I can't update a field via changeset:
params = %{"name" => ""}
struct = %Guest{name: nil}
changeset = Ecto.Changeset.cast(struct, params, ~w(name)a)
changeset.changes
%{}

@denispeplin we don't provide an official API for it yet because we are deprecating the existing arguments. However, you can achieve it by doing this:
changeset = Ecto.Changeset.change(struct, %{})
changeset = %{changeset | empty_values: []}
Ecto.Changeset.cast(struct, params, ~w(name)a)

We will provide a better API in future versions.

Wait, @josevalim, how does that work?
changeset = Ecto.Changeset.change(struct, %{})
changeset = %{changeset | empty_values: []}
Ecto.Changeset.cast(struct, params, ~w(name)a)

you're not using the changeset you created in the cast.
I need to use cast AND turn off the empty values


about UAC bypass

uacme has lots of techniques, which of them is implemented into sneakyEXE and works on Win7-10? many of them are detected by WD.

It will sure work on Windows 7 since Microsoft will stop supporting it soon, and on Windows 10, i don't use UAC, i use my own function as you can see in Methods.h. And about the Detection, i made a few mistakes that i am trying to improve to make it undetected, stay tune :}


Create dir before creating a file

The problem:
A call to WriteFileTool and DownloadFileTool would fail when the target file is located in a directory that does not exist. This necessitates at least two more iterations with Gemini to have the directory created and then the file created, increasing the network overhead and tokens count.
The solution:
If a file test_dir/file_name.txt is to be created, at first create the test_dir directory and then create the file.

The target action has been completed by the PR https://github.com/barun-saha/gemini_senpai/pull/3


Queue Implementation in C

Description
Description
In this documentation, I will explain the implementation of Queue Data Structure in the C programming language.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

Kindly review PR #3522

Closing as the PR is now merged


config: Use the latest pre-reqs payload

After the release we should have changed those to be using the :latest, as we do with the kata-containers / enclave-cc payloads.

/test

SNP test is failing with:
13:47:15 INFO: Run tests
13:47:15 Cloning into '/tmp/tmp.MpThi5moUB/src/github.com/kata-containers/tests'...
13:47:17 INFO: Running kata-qemu-snp tests for kata-qemu-snp
13:47:18 1..1
13:48:00 not ok 1 [cc][kubernetes][containerd][snp] Test SNP unencrypted container launch success
13:48:00 # (from function `kubernetes_wait_for_pod_ready_state' in file /tmp/tmp.MpThi5moUB/src/github.com/kata-containers/tests/integration/kubernetes/lib.sh, line 42,
13:48:00 #  in test file snp.bats, line 77)
13:48:00 #   `kubernetes_wait_for_pod_ready_state "$pod_name" 40' failed

SEV is failing with that error and
13:49:26 # Events:
13:49:26 #   Type     Reason                  Age                From               Message
13:49:26 #   ----     ------                  ----               ----               -------
13:49:26 #   Normal   Scheduled               41s                default-scheduler  Successfully assigned default/sev-encrypted-78ddd69dfb-54cck to amd-coco-ci-ubuntu2004-001
13:49:26 #   Warning  FailedCreatePodSandBox  12s (x3 over 40s)  kubelet            Failed to create pod sandbox: rpc error: code = NotFound desc = failed to create containerd container: create snapshot: missing parent "k8s.io/21/sha256:1021ef88c7974bfff89c5a0ec4fd3160daac6c48a075f74cff721f85dd104e68" bucket: not found
13:49:26 # -------------------------------------------------------------------------------
13:49:26 # Incorrect container folder path:

@ryansavino @AdithyaKrishnan are you able to advise if this is a known issue, or if the node needs cleaning up? It looks like the daily baseline failed with the same issue, so I don't think it is related to this PR at all. Thanks!

This PR is not related and can be merged without those CIs passing.
I also am not completely sure this is a "all BMs have this issue" as s390x passed.

@fidencio at release time we will pin to a commit, right?

@fidencio at release time we will pin to a commit, right?

Exactly!


Consider scoping the scala version only in ThisBuild or in Global

problem
scalaVersion is scoped for every build. This often causes problems when people want to set their scala versions globally, because they are overriden by the sbt defaults.
expectation
When people override the scala version in Global or in ThisBuild, sbt should pick up the scala versions from there since sbt does not scope sbt version to every project.
notes
I am not sure this is technically possible. But I think it's an interesting effort that will make sbt more intuitive. @olafurpg has complained several times that this is the current behaviour.
sbt version: 0.13.x and 1.x.

Isn't this already the case?
root> inspect sbtVersion
[info] Setting: java.lang.String = 0.13.16-M1
[info] Description:
[info] 	Provides the version of sbt.  This setting should be not be modified.
[info] Provided by:
[info] 	*/*:sbtVersion
[info] Defined at:
[info] 	(sbt.Defaults) Defaults.scala:137
[info] Delegates:
[info] 	*:sbtVersion
[info] 	{.}/*:sbtVersion
[info] 	*/*:sbtVersion
[info] Related:
[info] 	*/*:sbtVersion
[info] 	*/*:pluginCrossBuild::sbtVersion

I meant scalaVersion, but yeah, it's already scoped in Global. The issue is another one, where I think sbt could improve the experience. I will open a ticket soon. I'm closing this one.

This issue is valid. scalaVersion is defined at project scope: Defaults.scala / JvmPlugin.scala. This is particularly troublesome as it impacts crossScalaVersions which derives from scalaVersion: https://github.com/sbt/sbt/blob/v0.13.16-RC1/main/src/main/scala/sbt/Defaults.scala#L278.
Here's an example where @jvican had to deal with the interaction here in bintry: https://github.com/sbt/bintry/pull/29.
I'm currently having trouble with this in the scalajson build.

Yay! Thanks for the catch @dwijnand. I had the feeling this was not an hallucination...

Guys, in general, we should agree on what's the best and recommended way to have default values for our keys. I think that ThisBuild is almost always preferable. Is there any downside of doing it there?
We should also recommend plugin authors to scope stuff in ThisBuild, especially default implementations for values. Not doing so ends up being a burden for their users, who expect scope delegation to work.

Anything that is global to the entire sbt engine, such as the default version for a key you're introducing, should be defined (defaulted) in Global.
Anything that is not project-specific in your build, such as your organization, in ThisBuild.
We should document this.
It's possible that things are the way things are in JvmPlugin because of https://github.com/sbt/sbt/issues/2899.

Anything that is global to the entire sbt engine, such as the default version for a key you're introducing, should be defined (defaulted) in Global.

Isn't scoping in Global going to break the builds of source dependencies by overriding values that should not be overridden?
In my experience, people do not want to use Global, they generally want ThisBuild and I find it a safer alternative under my previous hypothesis that doing otherwise can generate undefined errors in builds with source dependencies. I think source dependencies are important, and we should give them more focus in 1.x.
It is going to be my recommended way to build software with sbt, and I'll write a blog post about it. It is certainly very useful for sbt plugins, among others.

Due to the mechanics of derive and what we do with it in Defaults (namely define scalaVersion, scalaBinaryVersion and, specifically, crossScalaVersions) this is a regression in sbt 0.13.16-M1.
steps
Given this build:
val t = project in file(".")
aggregateProjects(foo, bar)

      scalaVersion in ThisBuild := "2.11.11"
crossScalaVersions in ThisBuild := Seq("2.10.6", "2.11.11", "2.12.2")

val foo = project
val bar = project

problem
In sbt 0.13.16-M1 or sbt 0.13.16-RC1:
> show crossScalaVersions
[info] foo/*:crossScalaVersions
[info] 	List(2.11.11)
[info] bar/*:crossScalaVersions
[info] 	List(2.11.11)
[info] t/*:crossScalaVersions
[info] 	List(2.11.11)

expectation
How it used to work, such as in sbt 0.13.15:
> show crossScalaVersions
[info] foo/*:crossScalaVersions
[info] 	List(2.10.6, 2.11.11, 2.12.2)
[info] bar/*:crossScalaVersions
[info] 	List(2.10.6, 2.11.11, 2.12.2)
[info] t/*:crossScalaVersions
[info] 	List(2.10.6, 2.11.11, 2.12.2)

notes
The commit that folded sbt-cross-building into sbt introduced the project-scoped scalaVersion setting: https://github.com/sbt/sbt/commit/ff017eb475fbf18b8066125596bcd1a8cd8fb3ff#diff-6373e7f7122325e753b75fe1cc76ff5fR247

It would be lovely to have scripted tests that check the scopes of these things. This way, we won't have regressions on such important keys from now on.

This is a feature interaction between sbt version cross building and Scala version cross building.
Normally I try not to mess with existing globally-scoped keys, and I was aware that people often define scalaVersion in ThisBuild, so I did define a forwarder:
+    scalaVersion := {
+      val scalaV = scalaVersion.value
+      val sv = (sbtBinaryVersion in pluginCrossBuild).value
+      if (sbtPlugin.value) scalaVersionFromSbtBinaryVersion(sv)
+      else scalaV
+    },

I think I just need to do something similar with crossScalaVersions.
Note that recently merged https://github.com/sbt/sbt/pull/3356 re-injects scalaVersion at project-level on ^^. This might allow us to remove project-level scalaVersion initialization in Defaults, but I considering ^ compile etc crossScalaVersions forwarding still might be needed.


Compiler ignores invalid escape sequences

For example 'z' == '\z' is true, and print('\z') outputs z. It looks like the parser/compiler simply ignores the backslash if it does not recognize the escape sequence. I would have expected this to be a compile time error (like in Java strings, for example).

Dart SDK Version (dart --version): 2.1.0 stable
Whether you are using Windows, MacOSX, or Linux (if applicable): n/a
Whether you are using Chrome, Safari, Firefox, Edge (if applicable): n/a

Thank you! I didn't read far enough.
Some typos were exactly our problem. As this is a minor issue and likely a breaking change, I also don't think it's happening. I'll close this issue then.

I created a WIP pull request there: https://github.com/dart-lang/linter/pull/1295
Thank you!


Add figures: Architecture & Docker/Ubuntu/AWS demo environment

Also:

Rewrite related text in the Docker/Ubuntu/AWS procedures to describe
the demo environment

Add a figure for a two-node network (in preparation for a new procedure)

Note: This commit includes the XML (source) version of each new figure.
Signed-off-by: Anne Chenette<EMAIL_ADDRESS>

I am closing this PR to redo the figures and related text for the demo environment.  Given that two of the three environments include the XO transaction processor, I'll use the three-TP figure for all of them to be consistent.  I'll create a separate PR because I also want to correct the branch name.


Feat/show always

Added option show_always which, when set to true will always show the scroll bar even if the buffer can be displayed at once.
By default set to false.
(Should have) close(d) issue #73

This sort of thing would be very useful to lean.nvim, where we show things that don't appear at all in the sign column (something like LSP processing status for lines, see the yellow bars in the screenshot).

Screenshot

In our case though I tihnk this as-is doesn't go "far enough", in the sense that I want my satellite handler to imply always showing the scroll bar without the user having to change a setting (though of course they still should be able to turn things off). That may be different enough that it's separate from this PR, but going to have a closer look to be sure. Mentioning in case that's at all relevant to you as well @Servostar.


Fix markdown  colorization of links inside of lists and quotes

Issue #12344
Bug
Current markdown colorization rules are too relaxed. For example, links inside lists of block quotes end up getting colored differently than normal links.

Fix

Add a scope to the textmate markdown grammar so that we can identify the symbol that starts a list or quote.
Remove text colorization rule for lists and quotes since this just duplicates the normal text color.
Only apply special puctuator colorization to the start symbol for lists and quotes.

This only currently updates the dark and light themes. I'll investigate update the others as well.
Closes #12344

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Coverage remained the same at 61.19% when pulling 81b4c5093254ac75e8452659e9166e037c8f68d4 on mjbvz:fix-colorization-of-list-and-quote-contents-in-markdown into 0cf21a86a10b632afd4334444fb26e50a3ddcc40 on Microsoft:master.


[BUG] Teams/Allies can Attack on Another

What is the bug?
Currently, the plugin works great in my default worlds overworld, nether, and end. However, in a separate world with multiverse core, I have my KOTH set up. In this world, players of the same team, or allies, can attack one another even if they have PvP disabled.
Expected Behaviour
I would like it to sync with the main world, and disable PvP for that team and allyship if they have it disabled, or just make it so that cannot ever hit each other entirely if need be.
How to Reproduce
No real steps, just happens as you play, not off of a command or anything.
Error message
No response
Output of /teama version

Additional Information
No response

As communicated on discord, this is some implementation issue


Riak 2.2.0 and PHP7 support

Which versions of the basho/riak-pb and basho/protobuf packages should I use to accommodate Riak 2.2.0 and PHP7?
I'm currently using the following branch for my PHP extension:
https://github.com/basho/php-protobuf/commits/serggp_php7
because this is the only one that works. I tried the php7_merge branch but that resulted in a segfault from php-fpm.

The php7_merge branch is the ideal branch. Can you share the errors you received on it? I was able to run all of our integration tests against it from our Riak Client library: https://travis-ci.org/basho/riak-phppb-client/builds/197525530

Hi Chris,
All the tests passed for me too when I ran the make tests.
Here was the error produced in the httpd error_log:
PHP Warning:  PHP Startup: protobuf: Unable to initialize module\nModule compiled with build ID=API20151012,NTS\nPHP    compiled with build ID=API20151012,TS\nThese options need to match\n in Unknown on line 0
[Thu Mar 09 13:11:48.429198 2017] [mpm_event:notice] [pid 32090:tid<PHONE_NUMBER>62752] AH00489: Apache/2.4.6 (CentOS) PHP/7.0.15 configured -- resuming normal operations
[Thu Mar 09 13:11:48.429233 2017] [core:notice] [pid 32090:tid<PHONE_NUMBER>62752] AH00094: Command line: '/usr/sbin/httpd -D FOREGROUND'
[Thu Mar 09 13:13:36.004360 2017] [proxy_fcgi:error] [pid 32095:tid<PHONE_NUMBER>24864] (104)Connection reset by peer: [client <IP_ADDRESS>:59472] AH01075: Error dispatching request to :

@kodekraft Try rebuilding the module again, but first do a make distclean on the build files before doing the make and make install. I have had this issue sometimes when attempting to build the module with an unclean directory with leftover build files from previous attempts.


Image does not send Headers correctly

Description
Image tag not sending header tags
CodeSandbox/Snack link
none
Steps to reproduce
<Image source={source} headers={
        {
          Authorization: `Bearer ${auth_access_token}`
        }
      } alt={props?.alt || "Image"} style={props.style}
/>

NativeBase Version
3.4.25
Platform

[ ] Android
[ ] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
web
Additional Information
No response

Thanks for reporting. We will look into this

Hey @NilsBaumgartner1994, can you send your code link


Use win7-x64/x86 rids for runtime store

We should be building the store witn win7-x64 and win7-x86 rids instead of win-x64 and win-x86 rids.
We should also verify that linux-x64 and osx-x64 are sufficient for the xplat runtime stores. It would be a dramatic change if we build one for each possible platform.
cc @DamianEdwards @davidfowl

@davidfowl can you please take a look?

We discussed this offline after lunch. Pushing this change in for the build now. Will speak to @davidfowl offline to verify a few more things.


Make node sniffer more selective

Add support for:
sniff_node_types: {
    data:   "yes | no | fallback",
    master: "yes | no | fallback",
    client: "yes | no | fallback"
}

prefer_nodes: "192.168.*|rack:one|etc"

Closes #71

This was closed without a comment. Does this mean it will not be implemented?
At least the default implementation of should_accept_node still accepts every node in v7.715.


Support parsing Add BeginTransactionStatement for new sharding parser for SQLServer when using new ShardingParser

Add BeginTransactionStatement visitor for SQLServerTCLVisitor.

Fixed at #4337


can't find crate for syntax in rust 1.48

error[E0463]: can't find crate for `syntax`
 --> C:\Users\k\.cargo\registry\src\github.com-1ecc6299db9ec823\hex_literals-0.1.6\src\lib.rs:3:1
  |
3 | extern crate syntax;
  | ^^^^^^^^^^^^^^^^^^^^ can't find crate

hex-literal = "0.3.1"

crate is wrong


res.send(number) to not override statusCode if already defined by res.status(code)

The problem:
res.status(200).send(1000)

returns
invalid status code: 1000

This prevents sending a number as response without converting to string before. If statusCode was set by res.status(code), it should handle the number without override the statusCode.

Yea, but that change would be a breaking change. I would suggest making this change in 5.0, but in 5.0 res.send(number) no longer changes the status code at all to that number, so effectively this issue is resolved in 5.0. This is available in 5.0.0-alpha.1 and higher 🎉


Allow setting external address for master and filer

I am trying to set up seaweedfs over the internet. Volume servers have -publicUrl which I assume should be set to publicip:publicport. However, the master and filer servers only have -ip. It seems there is currently no way to set the external port for master and filer servers, could you add this or point out if I am not understanding these options correctly?

what is your intended use case?

I would like to expose the services on a different port than the http port +10000 (e.g in docker --ports 26493:19333)

please use nginx for port forwarding.

I see, I did not realise gRPC was in fact just HTTP

Actually, even if I used nginx instead of changing a docker port mapping for port forwarding, how would that fix the issue?
However, it seems that at least for now this is not the issue, I first need to figure out of connecting filer to master using gRPC instead of http will work at all

how would that fix the issue?

what is the issue?

As I discovered later there may not be any, apologies for the noise


fix: [#4545] Please upgrade zod package - botbuilder-dialogs

#minor
Description
This PR migrates the use of zod 1.11.17 to ^3.0.0 to avoid ReDoS vulnerability.
Specific Changes

Updated zod version to ^3.22.4 in

botbuilder-dialogs-adaptive-runtime
botbuilder-dialogs-adaptive-runtime-integration-azure-functions
botbuilder-dialogs-adaptive-runtime-integration-express
botbuilder-dialogs-adaptive-runtime-integration-restify
botbuilder-dialogs-adaptive-testing
botbuilder-dialogs-declarative
botbuilder-dialogs

Replaced use of check method with safeParse.

Testing
The following image shows some bot samples working after the update.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 21 (76.19%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.275%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-dialogs-declarative/src/componentDeclarativeTypes.ts
0
1
0.0%

libraries/botbuilder-dialogs/src/prompts/userTokenAccess.ts
11
15
73.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
20248

Relevant Lines:
22752

💛  - Coveralls

/promoted 4563


OpenApi Handler - Overriding all Mutations to Queries results in invalid schema

Issue workflow progress

Progress of the issue based on the Contributor Workflow

[ ] 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
Attempting to override the classification of all operations from an OpenAPI handler from Mutation to Query results in an invalid schema - reports as Type Mutation must define one or more fields.
As long as there is at least one mutation left, this works as expected, but removing all mutations results in this error.
To Reproduce
Steps to reproduce the behavior:

Add an openapi handler that contains queries and mutations, and re-classify all mutations to queries e.g.
        selectQueryOrMutationField:
            - fieldName: 'searchLocation'
              type: Query

Expected behavior
Similar to https://github.com/Urigo/graphql-mesh/issues/1474 the Mutation field should be removed if there are no mutations left after reclassification.
Environment:

OS: macos
@graphql-mesh/openapi: 0.33.39
NodeJS: 16.18.0

Additional context

Please share a reproduction on CodeSandbox or StackBlitz! Thanks!

Closing due to the missing reproduction. Feel free to create a new one with a reproduction if you still have the issue.


Do 2022 for AZ and NV...

Same thing, dumps trickling in from different areas needs checking as such.

I've started this at https://github.com/ppcodeman/nyt-2022-election-scraper

Awesome. Though at this rate only Hobbs/Lake is really competitive and that'll be settled pretty quickly.
I'd figure recoding it for house races would be a bit harder.


wgsl: Fix field semantics even if input struct doesn't need flattening

This fixes an issue where location indices of stage inputs were repeated
https://github.com/shader-slang/slang/issues/5633

I feel like metal needs the same treatment.

I feel like metal needs the same treatment.

Yes, that must be it.

I feel like metal needs the same treatment.

Yes, that must be it.

I feel like metal needs the same treatment.

Here is a PR #5666

Ok the PR fails, I filed https://github.com/shader-slang/slang/issues/5667.
The render0 test is also broken for Metal, so it's probably best to fix that one first, and then enable this test.


redisson-spring-data-27 raise NoSuchMethodError under jdk1.8

Redis version
NA
Redisson version

=3.24.0

Redisson configuration
NA
What is the Expected behavior?
No response
What is the Actual behavior?
We've found redisson-spring raise NoSuchMethodError since updated to the newest version, with jdk1.8 and springboot 2.7.18.
The stack is
java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;
    at org.redisson.spring.data.connection.RedissonBaseReactive.toByteArray(RedissonBaseReactive.java:54) ~[redisson-spring-data-27-3.24.3.jar:3.24.3]
    at org.redisson.spring.data.connection.RedissonReactiveStringCommands.lambda$retset$2(RedissonReactiveStringCommands.java:71) ~[redisson-spring-data-27-3.24.3.jar:3.24.3]

And we found a wiki explained how this error could happen with jdk1.8, the cause may be reddisson was complied with jdk9+ but without setting --release=8 to javac compiler:
https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
This push commit 1 in 3.24.0 delete the configuration <release> to maven-compiler-plugin, and introduce this problem.
And since push commit 2 in 3.25.0, we use properties maven.compiler.source and maven.compiler.target to control the behavior of compiler, but without maven.compiler.release.
Maybe we should add a property maven.compiler.release to fix this issue? Thanks.
Additional information
No response

Fixed. Thanks for report


readarr: <IP_ADDRESS>9 -> <IP_ADDRESS>1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Thanks! Could someone merge this?

Someone will merge it once they have time, it usually does not take more than a week :)
-------- Message d'origine --------
Le 25 août 2023, 09:44, Wietse de Vries a écrit :

Thanks! Could someone merge this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: @.***>