Show tensors shaped [H, W, 1, 1] as images

Mentioned here and elsewhere:
It is fairly common to store a single image in a [H, W, 1, 1] or [H, W, 3, 1] tensor.
However, currently Rerun only shows [H, W, 1|3|4] tensors as images, despite the trailing unit-dimension beeing an noop.
This should be fairly easy to handle by ignoring trailing unit-dimensions in:

Tensor::image_height_width_channels
Tensor::is_shaped_like_an_image
Tensor::is_vector

Preferably they would just use the same function, fn shape_short(&self) -> &[TensorDimension]

Hi!
I would love to contribute to the repo. I saw that the issue is labelled "first time", which is perfect for me as I am new to this project and eager to get started. Could you please assign this issue to me?
If I am not wrong, this is a straightforward implementation change that can be made. The fucntion can simply check if the last dimension of the tensor is a unit-dimension, and if so, remove it before displaying the image.

@tauseefmohammed2 sure go ahead! We actually rarely use the assign feature 😄 , but this way at least nobody else starts working on it redundantly :)
Yeah I think you're right should be as straight forward as you say - returning a subslice of the dimension that ignores trailing unit dimensions. Tbh not sure why @emilk  calls this sort (:


Investigate whether concrete playback can be used for test case generation

As recently suggested by @tedinski, concrete playback could potentially be used for test case generation. This is when a user is trying to generate a concrete test case that reaches a certain code path or triggers a certain failing condition.
I think this might be possible with how the feature is implemented right now. We might just need to test it more and add a section to the documentation for this use case.

I don't think this work is needed for the concrete playback stabilization though. Please let me know if you disagree.

Agreed.

BTW, I'm assuming this is related to generating a test case that reaches a certain part of the code, like a branch condition or a line number.


How to edit map data?

Hi,
I'm beginner using cartographer.
I made a map file(.pgm) from pbstream file.

After that,I ran pure localization and it works.
So, i want to modify a map using external tool(gimp or some image edit tool) to add or remove data(obstacles, walls etc).
But if i edit .pgm file, how can i apply change thing to .pbstream?
As far as i know, cartographer save all SLAM data(trajectory, submap, pose_graph etc) to  .pbstream file.
Running pure_localization, I should load a .pbstream file.
If i want to edit map data what i have to do?
Thank you.

The pgm file is just there for visualization purposes and it is not possible to change the pbstream by editing the pgm file.
Developing a tool to edit map data would be a significant effort and there is no trivial way of doing it.
One "simpler" approach if you need to filter some obstacles and walls is already filtering the corresponding points in the original point cloud that you use to build the map.

The pgm file is just there for visualization purposes and it is not possible to change the pbstream by editing the pgm file.
Developing a tool to edit map data would be a significant effort and there is no trivial way of doing it.
One "simpler" approach if you need to filter some obstacles and walls is already filtering the corresponding points in the original point cloud that you use to build the map.

The pgm file is just there for visualization purposes and it is not possible to change the pbstream by editing the pgm file.
Developing a tool to edit map data would be a significant effort and there is no trivial way of doing it.
One "simpler" approach if you need to filter some obstacles and walls is already filtering the corresponding points in the original point cloud that you use to build the map.

Thank you

As you mentioned makeitjune, you will need the original .pbtream map to use cartographer in pure localization mode.
I understand the need to edit the map and that doing it on .pgm is easier.
Besides what johuber suggested, you can also convert your  .pgm  again to .pbtream with the Ogm2Pgbm package.
Additionally, if you wanna run the tool in a separate docker container, you can follow the instructions in the readme.
Have fun, and enjoy the power of graph-based localization! :D


Use Cooldown Coordinator to notify other transfer mods of cooldowns.

This PR would merge changes to use my Cooldown Coordinator mod and notify other mods when pushing items to their block entities so they can set their own item movement cooldown.  This is necessary in order for heterogeneous networks of item-transferring blocks to move items with the same timings as the vanilla Item Hopper.  For example, if OmniHopper is used in an item sorting system along with vanilla Hoppers, without Cooldown Coordinator the sorter may not work as intended.
On the downside, although I think what Cooldown Coordinator does should eventually be part of Fabric API, at this time it is not and your mod would need to depend on or JiJ the Cooldown Coordinator mod.  My Ductwork mod takes the former approach.  I have extensively tested Cooldown Coordinator and when using it the mods I have tested (which now include yours) behave as expected.
Cooldown Coordinator also patches vanilla Hoppers to implement the notification interface and notify other blocks implementing the notification interface.  This generally includes "for free" descendants of the HopperBlockEntity, such as Hopper+ and Golden Hoppers unless they override the innermost transfer method.
Although it works quite well so far, Cooldown Coordinator is basically an attempt to get a better idea what a Fabric API for this should look like.  I intend to maintain the mod until something better comes along.  Even if you are not interested in merging this PR -- and I promise that won't hurt my feelings :) -- I would love any feedback you have about the mod and what I am trying to do with it.

Oh yeah, I probably should have mentioned that.  I wish github would hurry up and implement anonymous access to their maven.  If you don't want to use a github access token, you can get it via cursemaven instead.  If you'd like I can redo it that way.

Yeah, I dont want to have to authenticate with github to compile my project, so please redo that. Aside from that I'd also like to JiJ the library if I'm going to be using it, since its quite small.
I'm also interested in how this would work with variable cooldown durations, is it as simple as just changing the values in the notifyCooldown method?

OK, will do.
Yes, the CC mod tries to leave that kind of decision up to the individual mods it's coordinating.  Of course, if you adjust it to something else besides 8 ticks, it won't behave exactly like vanilla, but it should work just fine.  The 7 is for the case when j is 1.  I think the reason for it is to make sure the destination ticks first and is empty when the source next pushes an item.  It stabilizes the case where items are flowing through a chain of empty hoppers.

Cursemaven deps are kind of ugly.  :)  I've gone ahead and included the jar since you mentioned wanting that too.

Alright, I'll clone it locally and do a few tests to check if it works as I expect. If it does I'll merge it. Inter-mod compatibility is something I'm always interested in. :)

Me too.  It's more fun that way.

The mod compiles now and behavior between omnihoppers works perfectly. But there is no difference compared to my current branch when combining hoppers and omnihoppers. They should sync up when used in the configuration shown in the attached video right? Would this be an issue with the current implementation into my mod, or the patch applied to vanilla hoppers?
https://user-images.githubusercontent.com/38552516/163706674-328b9e7c-c1c7-4ede-8ef7-117a022d96c5.mp4

Yes they should.  There should be debug log output showing both the omni hopper and the vanilla one notifying each other.  I'll take a look too.

I see.  I didn't notice you don't expose your Inventory.  There's a corner case I haven't dealt with yet where the vanilla hopper can't notify modded entities if they only expose a Storage and not also an Inventory.  The reason is the fabric transfer API completely takes over and no hopper transfer code runs.  This is the main reason I think what Cooldown Coordinator does should really be in the transfer API eventually.  I've considered mixing in to the transfer API.  This might be enough of a nudge for me to do that...

Ah okay, would it take long to make a workaround for this? If not, it I'll hold off on merging until a patch is ready.

I'm not sure.  I didn't implement this at first because it was definitely more difficult than the rest, but I've gotten more familiar with both the hopper code and the transfer API since then.  It's a matter of finding somewhere in the two where I can insert the requisite behavior that won't break anything else.  Given a choice I'd rather avoid messing with transfer API directly.  I'll poke at it some this morning and see what I'm up against...

Alright, I'm working on fluid variants of the omnihopper right now, so I'll probably hold off on pushing an actual update until i finish that either way. No rush.

I wanted to avoid messing with the transfer API but for performance reasons I have to reimplement their HBE mixin.  It's pretty simple code; should be OK and works in testing.  However, I'll have to pay extra attention to transfer API changes going forward.  I doubt that mixin will change anytime soon, though.  I'll have a new CC release out soon and then push an update to this PR (cursemaven hard codes the dep version in that opaque ID number).

OK that should do it.  Or at least it does in my testing.

Yup, it works perfectly now from what I can tell.


deliver init failing

After an update to deliver yesterday morning, "deliver init" no longer works as it did. Here are three scenerios:
If I run "deliver init" in a terminal, it fails with a permissions error trying to create "./screenshots".
If I run "sudo deliver init" in a terminal, it works correctly and everything is downloaded.
If I run "deliver init" or "echo 'password' | sudo deliver init" from a node.js script, it fails.

FYI, when I uninstalled 1.10.2, causing it to drop back to 1.9.0, everything went back to working fine. I can copy/paste the stderr output from the script if it helps.

Can you share the full log please?

I had to drop back a version so it worked. Tomorrow morning I'll update and copy/paste the failure and then drop back down again.
Thanks!

Cool, I'll close this issue for now :+1:


Add CC0 license

Description

Update load_html_files to parse existing zero_(language).html files and
extract the text messages in available languages.
Update the views to display CC0 deed and license in the various languages.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

It looks like for 4.0 licenses that the title is no longer showing up. title does show up for 1.0 licenses; but it's a title for 4.0 licenses.
# what is showing up in 1.0 licenses
Attribution-NoDerivatives 4.0 International

I was just now seeing the same thing, and it was due to the CC0 License object having picked up the wrong value for title_english somehow. Running "python manage.py load_html_files --versions=1.0 ../creativecommons.org/docroot/legalcode" ought to fix it.


fix default locale issue

There was a problem that if the defaultLocale was set to a value that did not exist in PLACEHOLDER_LOCALES(en-US, fr, ru, zh-CN), it would be undefined.
export default withNextra({
  i18n: {
    locales: [
      'en',
    ],
    defaultLocale: 'en',
  },
})

I added a condition and modified it to fall back to DEFAULT_LOCALE if the user-specified defaultLocale is not present.

ping @shuding


problem running inference_images.py

It seems that there arer multiple threads running at the same time since I got this overrride question many times:
This is what I see when answering no (the output folder does not exist before)
(bgm2) C:\ZeroBox\src\BackgroundMattingV2> python inference_images.py --model-type mattingrefine --model-backbone mobilenetv2 --model-checkpoint PyTorch\pytorch_mobilenetv2.pth --images-src Group15BOriginals --images-bgr Group15BBackground --output-dir output-images --output-type com fgr pha
  0%|                                                                                | 0/1 [00:00<?, ?it/s]Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: n
  0%|                                                                                | 0/1 [00:40<?, ?it/s]
Traceback (most recent call last):
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 872, in _try_get_data
    data = self._data_queue.get(timeout=timeout)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\queue.py", line 178, in get
    raise Empty
_queue.Empty

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "inference_images.py", line 123, in <module>
    for i, (src, bgr) in enumerate(tqdm(dataloader)):
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\tqdm\std.py", line 1171, in __iter__
    for obj in iterable:
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 435, in __next__
    data = self._next_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 1068, in _next_data
    idx, data = self._get_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 1024, in _get_data
    success, data = self._try_get_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 885, in _try_get_data
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 54132) exited unexpectedly

If I answer yes (the first yes is normal since the output folder now exists):
(bgm2) C:\ZeroBox\src\BackgroundMattingV2> python inference_images.py --model-type mattingrefine --model-backbone mobilenetv2 --model-checkpoint PyTorch\pytorch_mobilenetv2.pth --images-src Group15BOriginals --images-bgr Group15BBackground --output-dir output-images --output-type com fgr pha
Directory output-images already exists. Override? [Y/N]: y
  0%|                                                                                | 0/1 [00:00<?, ?it/s]Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: Directory output-images already exists. Override? [Y/N]: y
  0%|                                                                                | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 125, in _main
    prepare(preparation_data)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 236, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 287, in _fixup_main_from_path
    main_content = runpy.run_path(main_path,
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\runpy.py", line 265, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\ZeroBox\src\BackgroundMattingV2\inference_images.py", line 123, in <module>
    for i, (src, bgr) in enumerate(tqdm(dataloader)):
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\tqdm\std.py", line 1171, in __iter__
    for obj in iterable:
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 352, in __iter__
    return self._get_iterator()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 294, in _get_iterator
    return _MultiProcessingDataLoaderIter(self)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 801, in __init__
    w.start()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\process.py", line 121, in start
    self._popen = self._Popen(self)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\context.py", line 327, in _Popen
    return Popen(process_obj)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\popen_spawn_win32.py", line 45, in __init__
    prep_data = spawn.get_preparation_data(process_obj._name)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 154, in get_preparation_data
    _check_not_importing_main()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\multiprocessing\spawn.py", line 134, in _check_not_importing_main
    raise RuntimeError('''
RuntimeError:
        An attempt has been made to start a new process before the
        current process has finished its bootstrapping phase.

        This probably means that you are not using fork to start your
        child processes and you have forgotten to use the proper idiom
        in the main module:

            if __name__ == '__main__':
                freeze_support()
                ...

        The "freeze_support()" line can be omitted if the program
        is not going to be frozen to produce an executable.
  0%|                                                                                | 0/1 [00:25<?, ?it/s]
Traceback (most recent call last):
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 872, in _try_get_data
    data = self._data_queue.get(timeout=timeout)
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\queue.py", line 178, in get
    raise Empty
_queue.Empty

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "inference_images.py", line 123, in <module>
    for i, (src, bgr) in enumerate(tqdm(dataloader)):
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\tqdm\std.py", line 1171, in __iter__
    for obj in iterable:
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 435, in __next__
    data = self._next_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 1068, in _next_data
    idx, data = self._get_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 1024, in _get_data
    success, data = self._try_get_data()
  File "C:\Users\jinzi\miniconda3\envs\bgm2\lib\site-packages\torch\utils\data\dataloader.py", line 885, in _try_get_data
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 45488) exited unexpectedly

I do have GPU and I was able to run the other two interference code without any issue.

has anyone seen this problem before? Thank you very much.

Ah I see.
You are running it on Windows and there are some differences in multithreading there. You can disable multithreading by changing num_workers to 0 or 1 in the line:
dataloader = DataLoader(dataset, batch_size=1, num_workers=8, pin_memory=True)

I also made an update to the file to fix some other potential issues, so remember to make a pull.

Thank you @PeterL1n it indeed fixed the problem.
Just curious: what is the primary OS you use for running the code?

We use Linux.

great. I was also able to confirm that the code works on Linux with num_workers=8. thanks


Window resizing causes artifacts on Windows

I know from discussions around other frameworks that properly handling window resizing is a notoriously hard issue, but I hope it is something that will get addressed fairly soon.

And not only on Windows. I think it is an issue on every platform.
For example, the  BottomSheet is not disappearing when you hide it: it is just outside of the window. And when you resize it, you can see the bottom sheet trying to hide :D

The example Code Viewer application being resized, for example:

The example Code Viewer application being resized, for example:

@hakanai could you please give your PC specifications? I cannot reproduce this bug. On Windows, when you resize a window, you can usually get black areas on the right and bottom of the window.

@hakanai could you please give your PC specifications? I cannot reproduce this bug. On Windows, when you resize a window, you can usually get black areas on the right and bottom of the window.

OS: Windows 10 Home 10.0.19041 Build 19041
Graphics card: NVIDIA GeForce GTX 1080 Ti  (ROG-STRIX-GTX1080TI-O11G-GAMING)
Graphics driver: <IP_ADDRESS>71
And although I get this issue, I don't get it every time I launch the demo app. Sometimes it does pad the space with black. The most reliable way to get it to happen so far has been to click around on the tree on the left until the demo app hangs, and then resize the window.

OS: Windows 10 Home 10.0.19041 Build 19041
Graphics card: NVIDIA GeForce GTX 1080 Ti  (ROG-STRIX-GTX1080TI-O11G-GAMING)
Graphics driver: <IP_ADDRESS>71
And although I get this issue, I don't get it every time I launch the demo app. Sometimes it does pad the space with black. The most reliable way to get it to happen so far has been to click around on the tree on the left until the demo app hangs, and then resize the window.

On Windows, when you resize a window, you can usually get black areas on the right and bottom of the window.

@Rsedaikin Will this be fixed ?

Discussed same  here(ru) https://t.me/compose_mpp/1437
I think realtime resizing should be exposed as optional parameter rather than forced for all apps. Intellij idea(swing) for example have same behavior, while chrome hasn't.

Could you please retry with latest versions of Compose?

The latest build number can be found here: https://github.com/JetBrains/compose-jb/tags
When responding with the test results, please mention which version you used, for the sake of posterity

@jimgoog I just tested 0.4.0-build176 and the problem persists.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


greenplum pxf docs to link to docs.vwmare.com

migrating greenplum platform extension framework docs to docs.vmware.com.
HOLD TIL MIGRATION IS COMPLETE.

I've converted this to draft mode, @lisakowen, because it sounds like you don't want it merged yet. When you want it merged, please take it out of draft mode.


[Feature] Realtime updates support in Firestore integration

One of the major strengths of using Firestore as the data store for applications is it's realtime sync capabilities. Having first-class support for this in Appsmith would make the Firestore integration a lot more useful.

Duplicate of #1647

This is not a duplicate. The issue #1647 is about adding support for Firebase's Realtime DB, which is a database offering different from Firestore.
This issue is about Appsmith supporting the realtime updating capability of Firestore itself.

At the moment, attempting to keep an appsmith application in-sync with the database requires a setInterval mechanism to be implemented link.
Firestore exposes functions which can allow the capturing of changes in the db in real-time.
Although, I understand that this is very specific to Firestore request, it would be extremely useful to enable real-time updates without constatnly polling the database. For Firestore in particular, polling the database can prove a rather costly operation since queries are billed based on the number of queries executed by database.

Thanks for the context @harisbal.
cc: @sbalaji1192 @rohan-arthur

I realise not directly related to Firestore, but something similar for Supabase database real-time updates would be nice too! Could there be a unified approach that works for all of these providers of real-time database updates?


Make it possible to import core-js

https://github.com/zloirock/core-js is a remarkably complete and modular collection of polyfills maintained by @zloirock.  They use commonjs to import dependencies.  It would be good to extend the ideas we started working on in #410 (first proposed in https://github.com/Financial-Times/polyfill-service/pull/410#issuecomment-113134056), so that polyfills with varying but common interfaces can be recognised and built by the polyfill service.
@zloirock are you interested in supporting this?  In short the purpose of our service is to automatically polyfill only features that are missing in a particular user-agent.

A PR for this work is at https://github.com/zloirock/core-js/pull/88

I watch your project. One day we were discussing the possibility of adding core-js to polyfill-service in gitter - it's required only commonjs build step. This idea LGTM.

Any news about adding commonjs build step?

I also would like to know the status of this. How's it going? What needs to be done in order for this to work?

We need a build.module property added to config.json so that a module can specify it has a commonjs interface and be built appropriately.  I'm not sure whether we would need to go as far as implementing require, or whether it's just a case of converting module.exports declarations into assignments to the appropriate global.
I don't have time to work on this right now but if anyone wants to do it, your starting point is the buildsources task.

Initial work on this - https://github.com/Financial-Times/polyfill-service/pull/568

Lovely, it would be a very welcome addition I think if you could pull it off.

Here is the latest version -- https://github.com/Financial-Times/polyfill-service/pull/585 -- code reviews welcome!

Using core-js as polyfill would be awesome. :+1:

:+1: the work so far looks great

core-js is a large polyfill and not really sensible to import only a part of it's feature set due to size. If all of core-js' polyfills were included in polyfill-service I think then the size trade-off may be worth it for more robustly tested polyfills. The reasoning behind why the size doesn't matter as much when we include all the polyfills is because many of them require the same modules, which will get bundled together, keeping the size from growing too large.

This work depended on supporting a commonjs build step, which caused significant problems. We don't have any plans to support commonjs right now, and there is also the issue of core-js compatiblity issues with other libraries (see lodash) which suggests it would be a risky move to push it as a polyfill solution.  Let's close this.


docker.WORKDIR does not affect image WorkingDir

Dapp version:
dapp: 0.31.19
dappfile.yml:
from: python:3.5.3-alpine
docker:
  WORKDIR: /app
  ENV:
    TERM: xterm```

docker inspect 25eee340c2cb | grep Working
            "WorkingDir": "/app/src",

Solved!
Inspected wrong container.


sync pull causes DeadlineExceededException

doing a sync pull on a subscription, and if there is no message, it throws DeadlineExceededException.  Usually, if a pull times out, it would just return null.  Also, pull wait time interval is usually configuration, how can this be configured?
Caused by: com.google.api.gax.rpc.DeadlineExceededException: io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: deadline exceeded after 4.978775875s. [buffered_nanos=291856840, buffered_nanos=331252614, remote_addr=pubsub.googleapis.com/<IP_ADDRESS>:443]
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:51)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:72)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:60)
	at com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:68)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1039)
	at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1165)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:958)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:749)
	at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:522)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:497)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:426)
	at io.grpc.internal.ClientCallImpl.access$500(ClientCallImpl.java:66)
	at io.grpc.internal.ClientCallImpl$1CloseInContext.runInContext(ClientCallImpl.java:416)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	... 6 more

When you say "usually, if a pull times out, it would just return null," what do you mean? As in, that used to be the behavior or that is the behavior you expect?

When you say "usually, if a pull times out, it would just return null," what do you mean? As in, that used to be the behavior or that is the behavior you expect?

IIRC, it was the old behavior when the client library had the idiomatic APIs. It's also the behavior for most of the other messaging APIs other than Pub/Sub.

We have a user issue that is related to this -- Pub/Sub timing out on a health check, which performs a synchronous pull with returnImmediately=true: spring-cloud/spring-cloud-gcp#2628.
What should be done here -- should the user open a support ticket for abnormally high pull latency, or is this a normal scenario, and we should adjust the health check indicator to ignore DEADLINE_EXCEEDED? It feels wrong to ignore, since a too-long latency is a valid indicator of a service problem.

We have a user issue that is related to this -- Pub/Sub timing out on a health check, which performs a synchronous pull with returnImmediately=true: spring-cloud/spring-cloud-gcp#2628.
What should be done here -- should the user open a support ticket for abnormally high pull latency, or is this a normal scenario, and we should adjust the health check indicator to ignore DEADLINE_EXCEEDED? It feels wrong to ignore, since a too-long latency is a valid indicator of a service problem.

I'm going to assign this to @anguillanneuf to discuss with Elena and see if we can figure out next steps.

For me it happens when there is no messages available (v1.90.0)

Both gcloud and Python will just return nothing or null if there are no messages. The Java client library behaves somewhat differently. If we do want to change it back, this would be a feature request. FYI - @mmicatka

AFAIK, the current sample no longer returns DeadlineExceededException when there are no messages to be pulled. It fails immediately. Updating the sample to handle the no ackId case.
Exception in thread "main" com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: You have not specified an ack ID in the request.
	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:47)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:72)
	at com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:60)
	at com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:68)
	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1133)
	at com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
	at com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1277)
	at com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1038)
	at com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:808)
	at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:564)
	at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:534)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:562)
	at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:70)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:743)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:722)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
	Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task failed
		at com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
		at com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
		at pubsub.SubscribeSyncExample.subscribeSyncExample(SubscribeSyncExample.java:80)
		at pubsub.SubscribeSyncExample.main(SubscribeSyncExample.java:43)
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: You have not specified an ack ID in the request.
	at io.grpc.Status.asRuntimeException(Status.java:535)
	... 10 more


Looking for UIAViewer

Hi
Trying updating to AHK v2.
I am missing the UIAViewer from v1 with the nice Inspect/capturing feature.
Any hint how to replace, highlight an element?
Many thanks

Run UIA.ahk alone without including it into a script.


Search Editor: Focus on editor with keyboard

After searching in the search editor search box, I would like to be able to press the down key, and have the caret focus on the editor.
I couldn't find a keyboard shortcut to do this.

F4 : search.action.focusNextSearchResult will take you from the search editor input box to the first result and then next, next, next.  Rebind if you want the downarrow instead:
 {
  "key": "down",
  "command": "search.action.focusNextSearchResult",
  "when": "hasSearchResult || inSearchEditor"
},
{
  "key": "f4",
  "command": "-search.action.focusNextSearchResult",
  "when": "hasSearchResult || inSearchEditor"
}

There's also search.focus.nextInputBox

@ArturoDent thanks. is there a way to limit this shortcut to when the focus is on the search box?

Tried textInputFocus and inputFocus but both seem to be false

{
"key": "cmd+down",
"command": "search.focus.nextInputBox",
"when": "inSearchEditor && inputBoxFocus || inputBoxFocus && searchViewletVisible"
}
alternatively just modify/use the existing focus next input.


Autotrain says that it finishes training after only completing a percentage of run

All of my attempted training runs end with autotrain not completing 100% of the run, but outputting "INFO    Finished training, saving model... " and not saving a trained model file.
Has anyone else experienced this? If so, how did you fix the issue? Below is the terminal window showing a run.

sft's estimate is not correct and finishes faster since its grouping texts. its totally fine. your model should be saved in folder specified by project_name param

Thank you for the quick response. The problem is the model is not being saved. He is the model directory when the run completes. There is no config and no model files.

adapter_* are the model files. since you didnt use --merge-adapter param, you are seeing only the adapters and not the full model. you can merge the adapters manually by using the following code:
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
from peft import PeftModel

base_model_path = ...
adapter_path = ...
target_model_path = ...

model = AutoModelForCausalLM.from_pretrained(
    base_model_path,
    torch_dtype=torch.float16,
    low_cpu_mem_usage=True,
)
model = PeftModel.from_pretrained(model, adapter_path)
tokenizer = AutoTokenizer.from_pretrained(base_model_path)
model = model.merge_and_unload()
model.save_pretrained(target_model_path)
tokenizer.save_pretrained(target_model_path)

Fantastic! Thank you. I really appreciate your help. I figured I was missing something obvious.

No worries! Will close the issue for now. Feel free to re-open if there's something missing still :)


Request to make animated QR display size, density, & frame rate configurable

Given the increasing variety of hardware devices using QR codes for PSBT exchange, it would be helpful for Sparrow users to have the ability to adjust settings related to animated QR display size, density and frame rate to accommodate for devices with differing levels of ability to ingest and process frames.

Given there is no way to tell in advance how to adjust these settings, ideally I would like to keep this burden off the user. It seems that we should as a developer community try to find a group of settings that we can all work towards (or perhaps two of them?). I will post to the Airgapped Wallet Standards signal group to see if we can reach any kind of consensus.

As per the Signal discussion, Sparrow now uses 200ms and 250 bytes max fragment length (up from 400ms/100 bytes).
I did implement the ability to increase the max fragment length by resizing the dialog as you suggested, but given that the decoder will need to be reset when this happens I don't think it's a safe change to add, so I've reverted it.

I think the change to 200ms and 250 bytes will go a long way to improve user experience, really appreciate your work on this.


Revisit intellij gitignores (.iml files from deleted modules continue to re-appear)

The phantom iml. We should revisit if we can switch to a more typical idea gitignore now.

Originally posted by @robobario in https://github.com/kroxylicious/kroxylicious/pull/538#discussion_r1294045852
We often see the api/kroxylicious-api/kroxylicious-api.iml return to haunt us.
We should revisit if there are some IDEA files that should be gitignored.
We are trying to make sure that it's easy to run our project in Intellij which is tricky because of our compiler setup where most modules use 17 and integrationtests uses 20.
Also we want to have the IDEA code formatting and import order checked in so we aren't battling with checkstyle and the maven plugins that format the code.
But maybe we don't need to check in the imls?

Updating the .gitignore to remove *.iml and friends is possible and dropping them from the checkout is possible. However it comes with a couple of caveats. Namely

Users have to use Maven auto import in Intellij.
Once we merge the change removing the *.iml files everyone will have to re-import their projects.

I'm +1 to doing that but wanted to flag it before proceeding.

+1 to dropping them.

+1 to this, would be nice to not have to manually exclude *.iml files from every commit.

Triaged 16/08/23


Find Bigfoot using HTML, CSS & Javascript

I would like to add a game to find Bigfoot using HTML, CSS & Javascript to this repo.

Sure, go ahead.
Do follow the guidelines and contributing steps.
Key things to keep in mind:

Create a separate branch
Create your project folder inside /public/Projects
The html file should be named index.html
When project is completed, take a screen shot or a gif and upload it to assets folder by giving proper name.
Finally your project folder should have a info.txt file with required fields (see template for reference)

Happy coding 🚀


Ruby syntax checker does not handle JRuby output correctly

JRuby's syntax checker output doesn't match Ruby MRI's patterns.
Sample JRuby messages:
Syntax OK for config/environment.rb

SyntaxError in app/dispatchers/table_dispatcher.rb|20 col 26 error| unexpected ','

hey, i dont use jruby so dont know the format of the error messages.
I have set up the structure for you to fill in the error format and makeprg for jruby - see syntax_checkers/ruby/jruby.vim. Can you fill in the makeprg and errorformat variables and send a pull request?
You will need to add let g:syntastic_ruby_checker="jruby" in your vimrc to tell syntastic to load the jruby checker.

I don't think it will work that way, since the ruby version is (with RVM) dependent on your working directory. That is, I use JRuby with one project, and MRI with others.
So it's probably best to run ruby --version on startup and check that way.
Fixing the errorformat was the first thing i tried. :) But I got completely confused by the syntax. Maybe you could recommend some resources on writing errorformat strings?


Added Heart Disease Dataset to Datasets.md

I hope this is the right way to edit the Datasets.md file .Actually I am contributing for the first time ,so i am new to these things .In case there is some issue with it , pls help!

@BlueBlaze6335 thanks for merging : ) can u pls provide hacktober-fest label to my contribution ?


How to set up thumbstick/touchpad movement

Use the Axis Move package to show how to set up slide motion on one controller and rotation on another controller, probably just talk about the warp options rather than a separate video showing them or have some option that lets it select between the control types

https://www.youtube.com/watch?v=yhfer9cXHHc


Export only Filtered rows without selection?

Is there any way to export all the filtered rows without select box?
Example:
Total rows in table 10.
I am applying search filter on Name Column.
After applying search filter table shows 2 rows but when I click on export CSV contains all 10 rows.
Is there any way to export only those 2 rows without selection?

@ashishsable27   check exportCSV.exportAll.
Please tag me if this issue still remain, thanks


initial port of ipxebuilder ansible role

#WIP

need to test this flow and make sure I didn't miss anything

porting older ansible role into structure used by on-imagebuilder for invocation locally on an ubuntu-based linux host

Looks good, if we include it in all.yml, is the though to also remove it from on-tftp source control then (I assume yes)?

yeah - that was the idea. In the docs in section 6(http://rackhd.readthedocs.org/en/latest/packaging_and_deployment.html#upgrading-the-code), we have instructions to install on-static-common (as well as the various application deb packages) which is basically what this repository is built to generate from scratch. I don't know if we want to ammend this setup to make that package (it's freakin' huge), or amend the instructions to be more specific about what files need to go where, copying them in from the results that this creates.

:+1:

@benbp @jlongever this one's been tested and verified to build the right stuff. Leaves the output in /tmp/on-imagebuilder/ipxe to follow the general pattern that Ben set up with the overlays

@heckj I'll be sure to include ipxe images in the bintray deploy files.   There may be other updates to the microkernel portion to make travis-ci happy.  Still working through those issues.

grazie @jlongever

:+1:

@heckj @benbp I just noticed the UEFI build steps weren't included.
@keedya did you ever include the ansible task for monorail-efi32-snponly.efi and monorail-efi64-snponly.efi?

@jlongever afraid I didn't see the UEFI build pieces in my edition of on-ansible (the original repo) - not sure what those steps are/were. @keedya if you have that stashed somewhere, would you consider adding as a follow on pull request to this setup so we have the right stuff built to support UEFI booting?

Sure will do!

Building ipxe.efi for 32 bit machine fails if I add COMBOOT syslinux support
@benbp @heckj

@keedya we may not need it any longer, was originally added to support hand-made DOS disks so we could boot and run the seriously ghetto tools that some HW vendors provided in DOS only

@keedya did you remove the COM define from the copied config header?  Otherwise EFI build will fail.

I can succesfully build it if I remove COMBOOT from general.h.
My question here is if we still want to build it this way?

Based on @heckj comment probably not.   But just have your ansible task sed that line out.


<EMAIL_ADDRESS>generates erroneous "Function calls not supported" error.

Please provide us with the following information:

OS?

Breaks on any and all.

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

This question exposes the underlying problem.  You don't really know what version you are running.  If you run ng --version in the project folder it seeks out the node_modules folder looking for ng in the .bin directory, and reports that version. I get the idea but that's a big surprise.  If you run ng --version outside the project folder it will report the globally installed ng version.
In my case I had 1.0.0-beta.20-4 globally and 1.0.0-beta-22.1 locally.  Moreover, my package.json asked for ^1.0.0-beta.19-2 (and the ^ is going to result in the latest beta).
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

Yes.  Added some packages that mysteriously started failing to compile on various machines.
The log given by the failure.

Normally this include a stack trace and some more information.

So, the 22-1 angular-cli compile suddenly fails with this error.  Works fine with 20-4. Here is the error (some AOT compile error with one of the 50 odd modules we have).
Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a... more noise...
Mention any other details that might be useful.
Main issue is compilation breaking in 22-4 beta with this obscure "Function calls are not supported" (on code that's been working up to now and hasn't changed) but also really not being able to determine quickly what actual version of angular-cli you are running.
My fix was to remove the ^ from package.json for angular-cli and pin it to a known-good version, until such times as the compiler or the package is fixed.

Thanks! We'll be in touch soon.

Dupe of https://github.com/angular/angular-cli/issues/3368. See https://github.com/angular/angular-cli/issues/3368#issuecomment-265232700


Terminal settings point at invalid anchor on website

The settings point at https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration
Should be https://code.visualstudio.com/docs/editor/integrated-terminal#_configuring-profiles

can i work in this issue

@AiverReaver sure 👍

@Tyriar  Thanks, I started looking at the vs code a few days ago. can you help me a little bit? how to open vscode user guide link from settings. Like I opened the settings from the file->preferences->settings->terminal but I didn't find any way to open that link in vs code.

These settings are a little special as they're deprecated so they won't show up in the UI. If you switch to the JSON file you can add the setting manually like this and then hover it:


[embeddingapi][XWALK-4167] Add embeddingapi autocase for setDownloadL…

…istener
-add embeddingapi autocase for XWalkView setDownloadListener
-cover the XWalkViewActivity and XWalkInitializer two ways
https://crosswalk-project.org/jira/browse/XWALK-4167
Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 1, fail 0, block 0

@jack-yong why you still put [XWALK-4167] in commit message again and again??

[XWALK-4167] is a task assigned to me, not a feature bug, should not I add it?

LGTM


Support for Enums with raw types

Added a protocol to Storable so that raw type enums can be easily supported.

Missed the new travis config by 3 minutes! I'll check this out tomorrow and we'll get this in.
Thanks! :+1:

Awesome, this is really great.
One thing:

Let's add tests for other raw value types, String at the very least. I always use either String or Int raw values, is there a common case for another one of our default types?

And some minor stuff:

Instead of forcing the cases property to unwrap from the TestStruct warehouse, let's provide a default - Case3 for example - that we don't use for any other purpose. I want to encourage users to provide a default, not crash.
In testEnumStorable, unpackedNested should just be unpacked or unpackedEnum
The same testEnumStorable test should test against TestEnum.Case1, not first
Indicate support for enums on the readme (I can take care of this)

@nickoneill how can I help with this PR? Should I fork litso:enum-support?

Hey @burntheroad, for sure you can finish this off. Fork that branch and submit a new PR with the changes.

Any help is appreciated but I can probably fix up the tests today

On Jan 23, 2016, at 9:02 AM, nickoneill<EMAIL_ADDRESS>wrote:
Hey @burntheroad, for sure you can finish this off. Fork that branch and submit a new PR with the changes.
—
Reply to this email directly or view it on GitHub.

@nickoneill Thanks to @burntheroad this should be good to go

Awesome, thanks to both of you!


Download link broken for book1

https://github.com/probml/pml-book/releases/download/2022-05-05/book1.pdf
shows
not found

Thanks for the excellent book!

A workaround (after checking the tags) is
https://github.com/probml/pml-book/releases/download/2022-04-09/book1.pdf

Fixed. Renamed link to point to https://github.com/probml/pml-book/releases/latest/download/pml1.pdf.

Fixed. Renamed link to point to https://github.com/probml/pml-book/releases/latest/download/pml1.pdf.

Hello. I found this link is not working now.


Wishing you peace and joy in 2019

Looking forward to new challenges in 2019.

Closed by #231 231


使用句子秒回控制家里的台灯

blog

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@cr4fun
Thanks for your blog！
Please make CI green and I will merge this PR.

Also, Cloud you please add your self as an author to the author data file at https://github.com/Chatie/blog/blob/master/docs/_data/authors.yml with your GitHub username?
And please also remember to reference yourself with the Github username in your blog post, so that we can have nice author information besides your blog after we published it!


Required LogAnalyticsQueryPackProperties not included in azure-native.operationalinsights

When trying to create a Pulumi.AzureNative.OperationalInsights.QueryPack (C#), an error is returned.

azure-native:operationalinsights:QueryPack (queryPack): error: autorest/azure: Service returned an error.
Status=400
Code="BadRequest"
Message="Value cannot be null.\r\nParameter name: 'properties' property must be specified"
InnerError={"trace":["System.ArgumentNullException"]}

The Pulumi.AzureNative.OperationalInsights API doesn't include the LogAnalyticsQueryPackProperties resource definition type that is defined as required by Microsoft.
See Microsoft.OperationalInsights queryPacks

Sorry, posted in wrong repo.
pulumi/pulumi-azure-native#2190 already exists.

Thanks @pwretmo , closing this issue as its a duplicate, and I see you've got a conversation going in https://github.com/pulumi/pulumi-azure-native/issues/2190


For branch example

This is a great branch! But I don't like lines 234. @celiafw what do you think?


Make a list of testing scenarios

It would be useful to have a document with scenarios for manual testing. Each scenario would have a list of steps to follow and some assertions. For example:
Scenario: User creates a crowdsale

Given I started the application
And I opened it with a browser connected to a local testrpc
When I start a new crowdsale
And I select "Whitelist with cap"
And I type some name and ticker and put 2 in the decimals input
And I click "Continue"
And Insert 100 as Rate and 100 as Supply
And I click "Continue"
And I submit all the transactions
And I click "Continue"
Then I should be prompted to download a ZIP file with information about the crowdsale
And I should be redirected to the crowdsale page

Here I used Cucumber, but it can be less formal. And I was very specific with the steps, but other scenarios could be shorter:
Scenario: User wants to buy too many tokens

Given I started the application
And I opened it with a browser connected to a local testrpc
And I created a crowdsale with 100 supply
When I go to the invest page of the crowdsale
And I insert 101 in the "Amount to invest" input
And I click "Contribute"
And I submit the transaction
Then The transaction should fail

There's a lot that can be done around this, but I would start with a very basic and non-exhaustive list (just the more important scenarios) and we can iterate after that.
If you want, you can just comment here a list of scenarios and I can create the .feature files.

Brief descriptions of basic scenarios that should be tested.

Basic:

Users can create a crowdsale and invest
If a transaction is rejected during the deploy, the spinner should be hidden
If a crowdsale has reserved tokens, these should appear when inspecting the crowdsale contract (using mist, for example)
If a crowdsale has reserved tokens, these should be distributed when the crowdsale is finalized.
If a crowdsale has a global min cap, a contribution of less than that cap should fail.

Whitelist:

If a crowdsale has whitelisted addresses, other addresses should not be allowed to buy tokens
If an address is whitelisted, it should not be allowed to buy less than the min value and more than the max value.

I started to work on test cases for manual testing
https://docs.google.com/spreadsheets/d/1nsJtlVOa9ZkHCOoBwl8eyQQzxpA0Y5ozfO4-Zu2fMUM/edit?usp=sharing

I'm closing this as seems to be solved. Please, reopen if not.


Update CODEOWNERS

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Testing Notes

Is the release-engineering team new? If so, why not call it release-engineering-reviewers (which I think is more descriptive of the purpose) and avoid the need to update a bunch of repos?

Closing as @jlantz is updating @SalesforceFoundation/release-engineering-reviewers.


⚠ ClamAV has degraded performance

In b2f7b61, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in 58d2c38.


More Commands

Hi Shivam,
would it be possible to add more commands from the language server to your plugin? I'm especially thinking of the casesplit-explicit commands.
Thanks for this plugin!

Hi @mkohlhaas , yes it is possible to add it in the plugin
But I'll not be able to do it right away as I've shifted to neovim LSP
It'll be greate If you want to give it a shot, here is the code to refer https://github.com/shivamashtikar/vimmer-ps/blob/526a77e2fb870816388455d95e1bb4ed9f5f2d3d/autoload/vimmerps.vim#L78
Thanks :)


updating document verbage and formatting

What this PR changes/adds
Updating the system-tests/README.md to make it more user friendly
Why it does that
General clean-up and polishing of documentation after running through the process locally
Linked Issue(s)
Closes https://github.com/agera-edc/MinimumViableDataspace/issues/210
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly?

Updating the documentation to reflect most recent experience when deploying mvd locally.


Doesn't work on the new IIDX INFINITAS

I was using this tool to decrypt the old INFINITAS data, but today there's the new INFINITAS that changed the visual and the system.
And now, I'm having a struggle due to the fact that the resource itself remains simple like this:

They're ifs files, but when I try to decrypt them with your tool, this happened:

This sucks, but if it's possible, would you please update the ifstools.exe and the infinitas_decrypt tool to support the new INFINITAS data please?
I would be glad if you can.

https://www.take-a-screenshot.org/
I will investigate. Please do not nag, it may take some weeks. I do not have much free time.

Thanks.
iPhoneから送信

2020/08/05 12:11、Will<EMAIL_ADDRESS>
https://www.take-a-screenshot.org/
I will investigate. Please do not nag, it may take some weeks. I do not have much free time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

ifs files are encrypted using an algorithm too similar to arcade. I cannot release it. Sorry.


Experiment with test subscriber (IGNORE)

An experiment that I need the Travis ASAN build for.

That experiment worked. Will push that change by itself.


Eslint-loader problems

I've recently tried to add eslint-loader, but I'm facing some strange problems.
My backpack.config.js:
const UglifyJsPlugin = require('uglifyjs-webpack-plugin')

module.exports = {
    webpack: (config, options, webpack) => {
      // Perform customizations to config
      // Important: return the modified config
      config.plugins.push(
        new UglifyJsPlugin(
            {
                parallel: true,
                uglifyOptions: {
                    output: {
                        comments: false
                    }
                }
            }
        )
      )
      config.module.rules.push(
          {
            enforce: "pre",
            test: /\.js$/,
            exclude: [/node_modules/],
            loader: "eslint-loader"
          }
      )
      console.log(config.module.rules)
      return config;
    },
  };

My .eslintrc:
{
    "parser": "babel-eslint",
    "rules": {
      "strict": 0,
      "linebreak-style": false
    },
    "extends": "airbnb-base"
}

Error on build:
This dependency was not found:

* <path to my project folder>\src/index.js in multi ./src/index.js

To install it, you can run: npm install --save <path to my project folder>\src/index.js

All i can see is some problems with backslashes (I am developing on Windows). Don't know if this is relevant.

I've reinstalled eslint-loader and somehow it started working.


Optimization: Loading textures only once.

Is your feature request related to a problem? Please describe.
As of now, the engine loads sprites from local directories literally every frame. This is not performance-friendly at all.
According to SFML:

Using as few textures as possible is a good strategy, and the reason is simple
Changing the current texture is an expensive operation for the graphics card. Drawing many sprites that use the same texture will yield the best performance.
Additionally, using a single texture allows you to group static geometry into a single entity (you can only use one texture per draw call), which will be much faster to draw than a set of many entities. Batching static geometry involves other classes and is therefore beyond the scope of this tutorial, for further details see the vertex array tutorial.

source: SFML tutorial
Describe the solution you'd like
Use a set<pair<string,sf::Texture>> to hold all of the loaded textures. If a sprite requires the engine to load from x (temporary name) directory, go through the set to check if the asset x has been loaded before. If it has, use that texture. If not, load the texture and add this newly loaded texture to the set for reusing.

@sgavil Sure! Although would you mind waiting for a bit? I've been restructering the entire code for a while (#22) and I'm almost finished. So if you worked on this issue after mine has been merged, it would be easier to resolve merge conflicts.

I'll be working on this instead due to inactivity.

Fixed.


A facade root has not been set

Hey.
I use the product laravel-ffmpeg.
Here's my attempt to use the code:
require $_SERVER['DOCUMENT_ROOT'] . '/vendor/autoload.php';
$exporter = Pbmedia\LaravelFFMpeg\FFMpegFacade::open($$_GET['file'])
    ->exportForHLS()
    ->onProgress(function ($percentage) {
        echo "$percentage % transcoded";
    });

But I get the error:
Fatal error:  Uncaught RuntimeException: A facade root has not been set. in /usr/share/nginx/html/vendor/illuminate/support/Facades/Facade.php:218
Stack trace:
#0 /usr/share/nginx/html/system/test/ffmpeg_hls2.php(87): Illuminate\Support\Facades\Facade::__callStatic('open', Array)
#1 {main}
thrown in /usr/share/nginx/html/vendor/illuminate/support/Facades/Facade.php on line 218
What did I do wrong?
Thank you.

In what kind of class do you use this code? It doesn’t seem Laravel related.

I just want to transcode the video file into the HLS format. What do you need to do for this?

The question is how do I use the product laravel-ffmpeg
without Laravel?

When I use the PHP-FFMpeg.
I'm getting a conflict of versions in the composer

It's my composer.json:
{
"require": {
...
"php-ffmpeg/php-ffmpeg": "dev-master",
"pbmedia/laravel-ffmpeg": "dev-master",
...
}
}


Simplify & standardize how to add block patterns to the theme scaffold

Is your enhancement related to a problem? Please describe.
Block patterns can consist of a lot of markup and it is rather difficult to manage that using the plain string of markup like it is currently done here: https://github.com/10up/wp-scaffold/blob/17b7ead7bed851f09f896db39246a37c2b27874a/themes/10up-theme/includes/blocks.php#L118-L145
Proposed Solution:
Create a "block-patterns" folder in the theme where PHP files for each pattern can be located. These files can then get included as the HTML string using a helper function.
block-patterns/buttons.php:

			<?php echo esc_html__( 'Button One', 'my-plugin' ); ?>

			<?php echo esc_html__( 'Button Two', 'my-plugin' ); ?>

blocks/register-paterns.php:

/**
 * Get Pattern Content.
 *
 * @param string $name Pattern name.
 * @return string
 */
function get_pattern_content( $name ) {
     $path    = "block-patterns/{$name}.php";
     if ( file_exists( $path ) ) {
         ob_start();
         require $path;
         return ob_get_clean();
     }
}

register_block_pattern(
    'my-plugin/my-awesome-pattern',
    array(
        'title'       => __( 'Two buttons', 'my-plugin' ),
        'description' => _x( 'Two horizontal buttons, the left button is filled in, and the right button is outlined.', 'Block pattern description', 'my-plugin' ),
        'content'     => get_pattern_content( 'buttons' );
    )
);

Designs
No response
Describe alternatives you've considered
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thinking about this some more I think the API for this should be even simpler. The goal we should be aiming for is that patterns work the same way as page templates in core. They are completely self-contained to one file.
<?php
/**
 * Pattern Name: Example Pattern
 * Pattern Description: description
 * Pattern Categories: common
 *
 * @package tenuptheme
 */

?>

Example

Example

This pattern file should be located in a folder named patterns in the root of the theme. The theme then includes this file and converts it to this internally:
register_block_pattern(
    "$textdomain/$pattern_filename",
    array(
        'title'       => Example Pattern, // taken from the file header of the pattern
        'description' => description, // taken from the file header of the pattern
        'categories' => commom, // taken from the file header of the pattern
        'content'     => // the actual content of the pattern file;
    )
);

This also aligns with what Core has planned for patterns so in the future we can remove this shim in favor of the core API:
https://github.com/WordPress/gutenberg/pull/36751
The approach in this PR is exactly what I had in mind.

Sounds like the right approach to me.

We decided to abandon this approach in favor of waiting for core to implement it here: https://github.com/WordPress/gutenberg/pull/36751


Fix tests

Tests in dummy app technically weren't running, but this wasn't reported as a failure.

Added helper to dummy file
Take advantage of cookies in helpers
Remove mentions of redis
Added back a bunch of gems that make rails work

Nice catch. LGTM.


adding wili-2018 language identification dataset

@lhoestq Not sure what happened, I just changed the py file but it is showing some TensorFlow error now.

You can ignore it.
It's caused by the Tensorflow update that happened 30min ago. They added breaking changes.
I'm working on a fix on the master branch right now

oh okay, btw I have made the required change for reading the CSV, I think it should be fine now, please take a look at it when you have some time.

merging since the CI is fixed on master


add nbinom logpmf

fixes #34
With the new code, I get basically the same answer for the values below as I do in R (value at the optimum agrees to six significant digits, although the optimal values of n and p are more noticeably different).
PS: ACK!  I can create a new PR without this "feature" if you'd like.
ab = [1, 3, 3, 2, 1, 7, 1, 1, 4, 4, 13, 1, 1, 2, 2, 91, 1, 8, 1, 20, 26, 1, 5, 1, 1, 2, 35, 103, 193, 23, 1, 8, 3, 2, 24, 12, 14, 16, 2, 14, 4, 10, 1, 15, 16, 25]

Closing so I can submit a PR that doesn't have extraneous changes


Attempted to load a non-existing mod for the Player. Ignoring. I don't get it...

Is there an existing issue for this?

[x] I have searched the existing issues and none matched.

Operating System
Windows 10
CPU
No response
GPU
No response
Storage
No response
Game Version
4.16.0HF
Game Mode
dance
Theme
DDR A3 (Inori)
Describe the problem
Noteskins that I copied and modified are not loading outside of Soundwaves. and this is shown in the log: Attempted to load a non-existing mod 'Noteskin Name' for the Player. Ignoring. Any solution for this issue? Please let me know as soon as possible.
Describe what should happen
Noteskins should load properly.
Relevant Log output
06:43.976: Attempted to load a non-existing mod 'ddr kids modern note' for the Player. Ignoring.
06:43.977: Attempted to load a non-existing mod 'ddra cel' for the Player. Ignoring.
06:43.977: Attempted to load a non-existing mod 'ddra cel_shock-arrows' for the Player. Ignoring.
06:43.977: Attempted to load a non-existing mod 'ddra-classic reversed brightness' for the Player. Ignoring.
06:43.981: Attempted to load a non-existing mod 'dsdr 9 note' for the Player. Ignoring.
06:43.981: Attempted to load a non-existing mod 'extreme plus' for the Player. Ignoring.
06:43.983: Attempted to load a non-existing mod 'hp3 note' for the Player. Ignoring.
06:43.983: Attempted to load a non-existing mod 'jelly with eyes' for the Player. Ignoring.
06:43.984: Attempted to load a non-existing mod 'kawaii cel' for the Player. Ignoring.
06:43.984: Attempted to load a non-existing mod 'kawaii note' for the Player. Ignoring.
06:43.986: Attempted to load a non-existing mod 'midi-solo (2)' for the Player. Ignoring.
06:43.988: Attempted to load a non-existing mod 'pastel note' for the Player. Ignoring.
06:43.988: Attempted to load a non-existing mod 'pastel rainbow' for the Player. Ignoring.
06:43.988: Attempted to load a non-existing mod 'pastel vivid' for the Player. Ignoring.
06:43.993: Attempted to load a non-existing mod 'reflec arrow' for the Player. Ignoring.
06:43.993: Attempted to load a non-existing mod 'reflec note blue' for the Player. Ignoring.
06:43.998: Attempted to load a non-existing mod 'starlight 2010' for the Player. Ignoring.

All of these errors have a thing in common. Spaces. Noteskins cannot have spaces. You need to rename the noteskins to be all a single string, like replacing the spaces with dashes.
Example.
hp3-note
pastel-note
reflec-arrow


Kivy crashes with "RuntimeError: release unlocked lock"

Versions

Python: 3.6, x64 (virtualenv)
OS: Windows 10, x64
Kivy: Kivy-1.9.2.dev0-cp36-cp36m-win_amd64.whl
Kivy installation method:

Updated an already-installed Visual Studio 2015 to include Visual C++ (Common Tools for Visual C++, Microsoft Foundation Classes for C++, and Windows XP Support for C++) and Python Tools for Visual Studio (January 2017).

Created a directory called C:\projects\kivy-bug,

Downloaded Kivy-1.9.2.dev0-cp36-cp36m-win_amd64.whl, from https://kivy.org/downloads/appveyor/kivy/Kivy-1.9.2.dev0-cp36-cp36m-win_amd64.whl and placed it in C:\projects\kivy-bug.

Installed Python 3.6 into C:\tools\Python\36.

Did the following from a command terminal with Administrator privileges:

cd C:\projects\kivy-bug
virtualenv -p C:\tools\Python\36\python.exe py36
.\py36\Scripts\activate
python -m pip install --upgrade pip wheel setuptools
python -m pip install docutils pygments pypiwin32 kivy.deps.sdl2 kivy.deps.glew
python -m pip install kivy.deps.gstreamer
python -m pip install Cython
python -m pip install Kivy-1.9.2.dev0-cp36-cp36m-win_amd64.whl

Description
Cannot run any of the kivy examples. After a seemingly successful installation with no warnings or errors, kivy invariably fails when a kivy example script is run. The error thrown is RuntimeError: release unlocked lock.
Code and logs
After the above installation, did the following in the same command terminal:
cd C:\projects\kivy-bug
git clone git@github.com:kivy/kivy.git kivy
cd kivy
python ./examples/animation/animate.py

The Result was:
[INFO   ] [Logger      ] Record log in C:\Users\james_000\.kivy\logs\kivy_17-03-04_37.txt
[INFO   ] [Kivy        ] v1.9.2.dev0, git-9f2daa0, 20170302
[INFO   ] [Python      ] v3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)]
[INFO   ] [Factory     ] 193 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_sdl2, img_gif (img_pil, img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [OSC         ] using <thread> for socket
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] Using the "OpenGL" graphics system
[INFO   ] [GL          ] GLEW initialization succeeded
[INFO   ] [GL          ] Backend used <glew>
[INFO   ] [GL          ] OpenGL version <b'4.3.0 - Build <IP_ADDRESS>31'>
[INFO   ] [GL          ] OpenGL vendor <b'Intel'>
[INFO   ] [GL          ] OpenGL renderer <b'Intel(R) HD Graphics 4400'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 3
[INFO   ] [GL          ] Shading version <b'4.30 - Build <IP_ADDRESS>31'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[INFO   ] [Shader      ] fragment shader: <b"WARNING: 0:7: '' :  #version directive missing">
[INFO   ] [Shader      ] vertex shader: <b"WARNING: 0:7: '' :  #version directive missing">
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
 Traceback (most recent call last):
   File "./examples/animation/animate.py", line 42, in <module>
     TestApp().run()
   File "C:\projects\kivy-bug\py36\lib\site-packages\kivy\app.py", line 802, in run
     root = self.build()
   File "./examples/animation/animate.py", line 37, in build
     on_press=self.animate)
   File "C:\projects\kivy-bug\py36\lib\site-packages\kivy\uix\behaviors\button.py", line 121, in __init__
     super(ButtonBehavior, self).__init__(**kwargs)
   File "C:\projects\kivy-bug\py36\lib\site-packages\kivy\uix\label.py", line 291, in __init__
     self._trigger_texture()
   File "kivy\_clock.pyx", line 75, in kivy._clock.ClockEvent.__call__ (kivy\_clock.c:2223)
     self.clock._lock_release()
 RuntimeError: release unlocked lock

Thanks for the report.
@matham was this introduced by the recent change to Clock events returning True? I remember a note about that. Do we have a plan to fix it?

Should be fixed in master already. Can you double check. Maybe try the wheel generated today.

Works now. Thanks!
Specifically, from the same project directory described in the original post, did the following:

Got Kivy-1.9.2.dev0.20170304.1ef5f2fb-cp36-cp36m-win_amd64.whl, generated March 4, 2017, from https://kivy.org/downloads/appveyor/kivy/Kivy-1.9.2.dev0.20170304.1ef5f2fb-cp36-cp36m-win_amd64.whl.
Replaced Kivy-1.9.2.dev0-cp36-cp36m-win_amd64.whl (generated March 3.2017) with Kivy-1.9.2.dev0.20170304.1ef5f2fb-cp36-cp36m-win_amd64.whl in C:\projects\kivy-bug.
Executed the following:

cd C:\projects\kivy-bug
.\py36\Scripts\activate
python -m pip uninstall kivy
python -m pip install Kivy-1.9.2.dev0.20170304.1ef5f2fb-cp36-cp36m-win_amd64.whl
cd kivy
python .\examples\animation\animate.py

The example ran successfully, without any errors.


Add nrf5 version of temperature sensor demo

Problem
Codesize measurements are quite platform-dependent, because of system libraries, and the esp32 system libraries are fairly big, because there's a lot of headroom on that hardware.  If we're trying to measure a "minimal" number, we should measure on a different platform.
Proposed Solution
Create an nrfconnect version of the temperature measurement app.

Is there a reason for it to be marked as TE2 issue? If not please remove the label to have a clear information what else still left to do for TE2.

Agree. Moving it to TE3.

Stale.


[Bug Report] "input" event of el-input-number is emitted twice

Element UI version
2.4.1
OS/Browsers version
Windows 10   Chrome 67 / Electron 2.0.2
Vue version
2.5.16
Reproduction Link
https://jsfiddle.net/4jbq5hvx/
Steps to reproduce
See console output
What is Expected?
The event should only be emitted once.
What is actually happening?
The event is now emitted twice.

Workaround
A workaround would be listen to the "change" event instead of "input"

There is no input event on el-input-number element. Try with change event.
Updated fiddle. -> https://jsfiddle.net/4jbq5hvx/1/
Docs. -> http://element.eleme.io/#/en-US/component/input-number#inputnumber

The input event is the default event for v-model directive.
Here is the reference
v-model on a component uses value as the prop and input as the event
However, I can confirm that it didn't cause problems. The change event worked well and  the watch event of v-model prop in parent component didn't trigger twice.

I guess they did not care input event and provided change event. What are you trying to accomplish?

In fact it is a hint for me that if an event is triggered more than desired, it must be some programming problem in the component (based on my own experience).
It is more of a quality concern now since there is no problem using the component.
FYI: I have used separate event (eg. change or update) for component updates in the past. But I found the input event could also get the job done without adding the separate event. So I changed my way to listen for the input event by the DRY (Don't repeat yourself) principle.

Share your solution, so the issue can help somebody. An close the issue if you solved, please.


Specify permissions required for all steps

Faced with an issue deploying from Azure DevOps.
2019-06-14T08:33:03.2169926Z ##[error]Error: release ingress failed: clusterroles.rbac.authorization.k8s.io is forbidden: User "system:serviceaccount:myaccount:tiller" cannot create resource "clusterroles" in API group "rbac.authorization.k8s.io" at the cluster scope
My cluster is 1.14
Yes, I can do it under my admin credentials, but do such thinks via automated CI/CD is always better.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ada58160-dc50-b977-d3bc-65f92406e16d
Version Independent ID: 5c596e04-fddb-effe-3b72-575f4df42d4e
Content: Create an HTTPS ingress with Azure Kubernetes Service (AKS) cluster
Content Source: articles/aks/ingress-tls.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

@SychevIgor all the steps listed in this doc work as written. I am not sure if there would be any extra steps needed when deploying via DevOps. That being said, if there is it should be listed in the DevOps documentation instead.
Are you following any specific docs in regards to that?

@SychevIgor I will close this for now as no doc enhancements are needed on this doc. If you have further info you want to share feel free to let me know and we can always reopen and continue the discussion.

@MicahMcKittrick-MSFT  if you can complete this tutorial on a new cluster without errors- I'm surprised.
I can't.
What actually helped me:
apiVersion: v1
kind: ServiceAccount
metadata:
name: tiller
namespace: default
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: tiller
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: cluster-admin
subjects:

kind: ServiceAccount
name: tiller
namespace: default

@SychevIgor if you need further help I am happy to help you get in touch with Support to work through this. If that is the case, feel free to email me at<EMAIL_ADDRESS>and provide me with your Azure SubscriptionID and link to this thread.


Clarify no proxy option

Description

https://jira.mesosphere.com/browse/DOCS-1960
Urgency

[ ] Blocker
[ ] High
[ ] Medium

Requirements

Test all commands and procedures.
Build content locally and test for formatting/links.
Add redirects to dcos-website/redirect-files.
Change all affected versions (e.g. 1.7, 1.8, and 1.9).
See the contribution guidelines.

@jsancio @jenafermiller  @surdy how does this look?

@jsancio @surdy let me know what you think https://github.com/dcos/dcos-docs/pull/1130/commits/b3781386bc4648523b0f7d0f16edf1fa06802448


[Graphic design task] Design a GitHub preview image

The InterMine repos in general need to have social preview images.
Task:
Create a social preview image based on the specs shown here: https://help.github.com/en/articles/customizing-your-repositorys-social-media-preview - you can use your creativity to make something that you think looks nice.
Resources you can use include InterMine logos from the logos/intermine folder of this repo (but don't use items from other folders; much of this repo is very old and not in use), as well as any images or text from intermine.org.
if you want to pick up this task

Comment on this issue stating that you intend to work on the task
When you're ready, add your work to the repo and create a pull request.
Bask in glory

What to do if you need help
Mention @yochannah, tweet @yoyehudi, pop by to say hi on chat or if needed email<EMAIL_ADDRESS><3

Hi @yochannah
I wanna take this

@azhsetiawan awesome - go ahead! 👍


Update deps

fix #13

Thank you for the PR, will make a PR that includes the changes that should be added.May I suggest to iron out the issue on the "Issues" side before making a PR; the exception to this advice is if you are certain of the source of the issue.


poetry show -o is broken

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: macOS
Poetry version: 1.0.0b5

Issue
Riley ~/Projects/APPA/account-new % poetry show -o -vvv
Using virtualenv: /Users/xistence/Projects/APPA/account-new/.venv

[ValueError]
'=' alignment not allowed in string format specifier

Traceback (most recent call last):
  File "/Users/xistence/.ve/poetry/lib/python3.8/site-packages/clikit/console_application.py", line 131, in run
    status_code = command.handle(parsed_args, io)
  File "/Users/xistence/.ve/poetry/lib/python3.8/site-packages/clikit/api/command/command.py", line 120, in handle
    status_code = self._do_handle(args, io)
  File "/Users/xistence/.ve/poetry/lib/python3.8/site-packages/clikit/api/command/command.py", line 171, in _do_handle
    return getattr(handler, handler_method)(args, io, self)
  File "/Users/xistence/.ve/poetry/lib/python3.8/site-packages/cleo/commands/command.py", line 92, in wrap_handle
    return self.handle()
  File "/Users/xistence/.ve/poetry/lib/python3.8/site-packages/poetry/console/commands/show.py", line 175, in handle
    line = "<fg={}>{:{}}{}".format(

duplicate of #1323

You are correct!


Setup of Revenue Sharing

Adds a new setup revenue sharing function based on #42
Setup Revenue Sharing
In the main SDK you can now setup revenue sharing after you deploy.
const sdk = new OpenFormatSDK({
  network: 'http://localhost:8545',
  signer: new ethers.Wallet(
    '0x04c65fb1737cf9a5fb605b403b5027924309e53a3433d06029a0441cc03e2042',
    new ethers.providers.JsonRpcProvider('http://localhost:8545')
  ),
});

await sdk.deploy({
  maxSupply: 100,
  mintingPrice: 0.01,
  name: 'Test',
  symbol: 'TEST',
  url: 'ipfs://',
});

const receipt = await sdk?.setupRevenueSharing({
  revShareExtensionAddress: '0x483C3aDD26C87d2F99DcCB84Cbf61844B6aeD212',
  collaborators: [
    '0xee4abd006630aea6fa3e685c99506db31c09b3f4',
    '0x21b2be9090d1d319e57b67c4b5d37bc5ec29a9d0',
  ],
  shares: [7700, 1000],
  holderPercentage: 1000,
});

And there is the equivalent in the React SDK
function Test() {
  const { deploy, data: deployData } = useDeploy();
  const { setupRevenueSharing, data: revenueShareData } = useRevenueSharing();

  return (
    <>
      <button
        data-testid="deploy"
        onClick={() => {
          deploy({
            maxSupply: 100,
            mintingPrice: 0.01,
            name: 'Test',
            symbol: 'TEST',
            url: 'ipfs://',
          });
        }}
      >
        Deploy
      </button>

      {deployData &&

}

      <button
        data-testid="setupRevenueSharing"
        onClick={() => {
          setupRevenueSharing({
            revShareExtensionAddress:
              '0x483C3aDD26C87d2F99DcCB84Cbf61844B6aeD212',
            collaborators: [
              '0xee4abd006630aea6fa3e685c99506db31c09b3f4',
              '0x21b2be9090d1d319e57b67c4b5d37bc5ec29a9d0',
            ],
            shares: [7700, 1000],
            holderPercentage: 1000,
          });
        }}
      >
        Setup Revenue Sharing
      </button>

      {revenueShareData &&

}
    </>
  );
}

Checklist:

[ ] Documentation
[x] Tests
[x] Code complete
[x] Changeset

This looks really good, strong work 👍
One thought though, I know the function arguments match the contracts but considering the collaborators and their shares are so intrinsically linked (and thus those arrays need to be really carefully ordered) does is make sense for them to be separate?
const receipt = await sdk.setupRevenueSharing({
  revShareExtensionAddress: '0x483C3aDD26C87d2F99DcCB84Cbf61844B6aeD212',
  collaborators: [
    {
      address: '0xee4abd006630aea6fa3e685c99506db31c09b3f4',
      share: 7700,
    },
    {
      address: '0x21b2be9090d1d319e57b67c4b5d37bc5ec29a9d0',
      share: 1000,
    },
  ],
  holderPercentage: 1000,
});

// or

const receipt = await sdk.setupRevenueSharing({
  revShareExtensionAddress: '0x483C3aDD26C87d2F99DcCB84Cbf61844B6aeD212',
  collaborators: [
    ['0xee4abd006630aea6fa3e685c99506db31c09b3f4', 7700],
    ['0x21b2be9090d1d319e57b67c4b5d37bc5ec29a9d0', 1000],
  ],
  holderPercentage: 1000,
});

@benjaminreid I think this is a good idea, as it combines their shares with each collaborator. I can then unpick them inside the SDK and pass them to the contract as it expects! 👍

@benjaminreid Update the data structure to reflect your recommendation and also updated the original documentation in this PR 👍


Request credentials for an os-climate bucket for itr-data-pipeline

Requesting credentials for github user: Dhanush-dk
Requesting credentials for the bucket: s3 bucket
Email address to send a credential download link<EMAIL_ADDRESS>Request checklist:

[ ] User can establish connection with the bucket
[ ] User can read files from the bucket
[ ] User can write files to the bucket

@rynofinn

closing - please let us know if you still need access


Tellor Data Dashboard or API endpoint

Create an interface for viewing the data values in the TellorMiner's local database

I am also not a big fan of how the data is saved and retrieved from the DB so will deff do some improvements here.

viewing the data values

Can you give an example of how you imagine this? Just a simple example would help.
Are you thinking maybe some graphql or rest API?

@krasi-georgiev I never saw your comment but I just wanted to bump this, really miners just need an easy way to see the exact values in the database, this becomes more important as we start adding more request IDs, its difficult to verify the data is correct in the database without putting some log messages, or maybe there is and I'm not aware of it. Just any easy way to see the data values in the DB is needed so it can be viewed. Even if its just a log.Info message that can be enabled in loggingConfig.json

but why do you need to see the data? What is just add a way that a stratum server can submit solutions and the miner becomes just a submitter. So all it does is listens for solutions and as soon as there is a solution is submits it to the contract.


Cannot read properties of undefined (reading 'search')

Hi, I'm trying to get into this crate and make some web extension demos.  I found that web_extensions::history::search not working as I expected and threw an error of properties of undefined. I did my investigation for a day, but I‘m new to both wasm&web-extension so I still have not solved this problem. More details will show below:
My main logic is as below, it's very simple:
#[wasm_bindgen(start)]
pub async fn main() {
    std::panic::set_hook(Box::new(console_error_panic_hook::hook));

    let millis_since_epoch = js_sys::Date::now() as i64; // the number of milliseconds elapsed since EPOCH

    let one_hour_earlier = Some(millis_since_epoch - 60 * 60 * 1000);

    let now = Some(millis_since_epoch);

    let q = Query {
        text: "Query",
        start_time: one_hour_earlier,
        max_results: Some(3),
        end_time: now,
    };

    let history_items = search(&q)
        .await
        .expect("Unknow `web_extensions::history::search` bug.");

    // log shows it's stuck here.
}

The search function is an alias of web_extensions::history::search.
pub async fn search(query: &Query<'_>) -> Result<Vec<HistoryItem>, Error> {
    let js_query = js_from_serde(query)?;
    let js_value = sys::chrome()
        .history()
        .search(object_from_js(&js_query)?)
        .await;
    serde_from_js(js_value)
}

In the generated js file, the error line is：
imports.wbg.__wbg_search_5602fc53d1278731 = function (arg0, arg1) {
  const ret = getObject(arg0).search(getObject(arg1)); // <-- this `.search` is properties of undefined.
  return addHeapObject(ret);
};

I see this means the object taken from the heap does not contain the search property.
Version Info
Google Chrome: 107.0.5304.107
wasm-bindgen = "0.2.83"
js-sys = "0.3"
wasm-bindgen-futures = "0.4"
console_error_panic_hook = "0.1.6"
web-extensions = "0.3.0"
I'm not sure any other information is helpful if provided, let me know if you need more to locate the error.

Could you post your manifest.json?

try to add "history" to the permissions.


When starting the server locally the clients connect but don't receive events.

Hey,
Thanks in advance for this amazing, ease-to-use package!
I am currently experiencing something strange whereby if I start my websocket server in my development environment and I head to the page it looks like I'm connected (it shows me in the presence users) but it's not showing anyone else. Next to that I'm not receiving any events either.
The page console doesn't show any errors or anything weird, neither does the information from requests made (in network tab). It all looks fine. Looking at the terminal console where the websocket is running however nothing is being logged (whilst connections or events are normally being logged there).
The only way to solve this issue is to head to the websockets dashboard (/laravel-websockets by default) and click the connect button (which works perfectly!). Then I head back to my page and the websockets work perfectly. It's being logged, I'm receiving events etc...
This only happens on my local development environment (I think). But I thought it might be useful to share if it would ever happen in production.
My laravel echo client if that's relevant information:
import Echo from 'laravel-echo';
import Pusher from 'pusher-js';

window.Echo = new Echo({
    broadcaster: 'pusher',
    key: process.env.MIX_PUSHER_APP_KEY,
    cluster: process.env.MIX_PUSHER_APP_CLUSTER,
    forceTLS: true,
    wsHost: window.location.hostname,
    wsPort: 6001,
    wssPort: 6001,
    disableStats: true,
});

I can't seem to replicate it anymore. I think it was just a coincidence.


Update permission.js

Setting default read for everything and making it hard to change is bad, especially after loading large user sets.

I think an option where you can pass in a config might be a better solution.  Say you can specify in config/permissions.js
module.exports.permissions = {
    grant: {
        registered: []
    }
}


Enable Oauth2 on Swagger-UI

Swagger-UI must have Oauth2 enabled to provider login-ui redirection and execute all further requests with authorization

[ ] Add configuration to enable authorization on swagger-ui. Below is the sample configuration
[ ] Ensure the authentication is enabled only when zitadel profile is activated.
[ ] add a 'web' application on Zitadel for swagger-UI with correct redirect URL
[ ] Document the application creation process.
[ ] Provide documentation to override values of clientid, authurl and token url with startup.

@SecurityScheme(name = "security_auth", type = SecuritySchemeType.OAUTH2,
        in = SecuritySchemeIn.HEADER,
        scheme = "bearer",
        flows = @OAuthFlows(authorizationCode = @OAuthFlow(
                authorizationUrl = "${springdoc.oAuthFlow.authorizationUrl}"
                , tokenUrl = "${springdoc.oAuthFlow.tokenUrl}", scopes = {
                @OAuthScope(name = "openid"),
                @OAuthScope(name = "email"),
                @OAuthScope(name = "profile"),
        })))
@Configuration
public class OpenApiConfig {
}

springdoc:
  show-login-endpoint: true
  swagger-ui:
    oauth:
      clientId: xxxx
      use-pkce-with-authorization-code-grant: true
  oAuthFlow:
    authorizationUrl: http://localhost:8080/oauth/v2/authorize
    tokenUrl: http://localhost:8080/oauth/v2/token

I will take it.