[PE-D][Tester A] Inconsistencies with Case-Sensitivity over different fields.

There are some inconsistencies with the case-sensitivities amongst classes.
For example:
Names are non-sensitive and you cannot create two different Students with same name ie, David Li and David li cannot exist together.
Tags can exist as New and new.
Modules can exist as Literature and literature.
This affects your find and filter commands as they are case insensitive searches. Finding New will show both new and New.
Suggested Changes:
You could standardise Modules and Tags to follow CamelCase? This would be easier for the user and they would have to worry about typing the wrong cases especially for faster typers.
Proof:

Labels: severity.Medium type.FunctionalityBug
original: HanB1n/ped#4

This can be mentioned in the user guide.


some example want

Great and useful project. I'm looking for an application that implements grpc through webrtc datachannel. I want to realize file transfer. Is there an example in this regard， js or go，thanks

I'll try and build something for you!

thanks, I found an example of file transfer in go grpc. You can see if it can be implemented quickly.
https://dev.to/techschoolguru/upload-file-in-chunks-with-client-streaming-grpc-golang-4loc & https://github.com/duysmile/grpc-upload-file

Hey @xiangxud, I added https://github.com/viamrobotics/goutils/tree/main/rpc/examples/fileupload. Can you try using/running that?

this is not base on webrtc datachannel, I want to do something base yours!

It is! When using this it will prefer webrtc!

when i make build ,error like follow, canyou help me
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
Module build failed (from ./node_modules/ts-loader/index.js):
Error: TypeScript emitted no output for /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts.
at makeSourceMapAndFinish (/home/develop/nightingale/src/modules/agent/web/goutils/rpc/examples/fileupload/frontend/node_modules/ts-loader/dist/index.js:53:18)
at successLoader (/home/develop/nightingale/src/modules/agent/web/goutils/rpc/examples/fileupload/frontend/node_modules/ts-loader/dist/index.js:40:5)
at Object.loader (/home/develop/nightingale/src/modules/agent/web/goutils/rpc/examples/fileupload/frontend/node_modules/ts-loader/dist/index.js:23:5)
@ /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientChannel.ts 21:21-46
@ /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/dial.ts
@ /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/index.ts
@ ./src/index.ts
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
/home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts 136:16-36
[tsl] ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts(136,17)
TS2532: Object is possibly 'undefined'.
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
/home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts 137:19-39
[tsl] ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts(137,20)
TS2532: Object is possibly 'undefined'.
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
/home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts 138:30-50
[tsl] ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts(138,31)
TS2532: Object is possibly 'undefined'.
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
/home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts 138:30-60
[tsl] ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts(138,31)
TS2345: Argument of type 'number' is not assignable to parameter of type 'string | string[]'.
ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts
/home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts 140:31-51
[tsl] ERROR in /home/develop/nightingale/src/modules/agent/web/goutils/rpc/js/src/ClientStream.ts(140,32)
TS2532: Object is possibly 'undefined'.

		I modify ClientStream.ts code ,it's work fine ,thank you very much ,i will going to research youre code for my app.
                    statusCode = trailers.getStatus()?.getCode(); //trailers.getStatus().getCode();
		statusMessage = trailers.getStatus()?.getMessage();
		 let statuscodestr = statusCode?.toString();//trailers.getStatus()?.getCode().toString()
		if (statuscodestr !=undefined){
		  headers.set("grpc-status", statuscodestr);
		}
		// this okay?
		// let statusmsg = trailers.getStatus()?.getMessage();
		if (statusMessage !=undefined){
		  headers.set("grpc-message", statusMessage);
		}


automatically focus the operation selector on creation

When the user creates an operation, the first thing they have to do is specify which operation they want to create. To reduce the amount of clicks, when a user creates a new operation (ie adds one to the chain) the md-autocomplete component should be focused without the user needing to click it.

The UI fails to meet our Accessibility policy. It is unmaintainable and will be removed shortly.


Import systems from compendiums

Initial support for custom systems
Register one or more Compendiums in the game with fabricate
Associate those Compendiums with a system description and name
Same import process, just include multiple compendiums in source for first pass
Test with large compendiums for performance implications (memory usage)

No longer required.


Missing NPM Package.json

I cannot find this package on NPM. And it doesn't have a package.json file for use with projects built with NPM.
Can we please have both?

It's available now on v2.


Implement to_wandb() for dendrite and metagraph

Is your feature request related to a problem? Please describe.
Lack of data visibility.
Describe the solution you'd like
Implement to_wandb() for dendrite and metagraph objects for tracking.
Describe alternatives you've considered
No response
Additional context
Reopens https://github.com/opentensor/bittensor/issues/1332 for revolution branch.

Stale


Improve documentation

Description
Fix typo errors from the documentation.
Notorious Changes

Replace can not by cannot in several places.
Replace some a by an when the next word starts by vocal.
Fix typo words such as programm or offical by program or official and so on.
Add a final dot at the end of each phrase in documentation/api.md file.
Replace (__DIR__ ) by (__DIR__) in api.md (line 99).
Add a comma after Otherwise adverb.
Fix some agreement errors (sing + plural).
Minor changes.

omg, I didn't know.
Great, I will take a look this afternoon!

Thanks a lot!

Update the website.


Test arch arm thread swap minor fix

Fixes a bug in erroneous zassert expression in arm thread swap test suite
Fixes #18999

The original version passed under #18991 so this should be good.  Thanks.


Update Appraisals, add rails 5.0.0.alpha support

I'm a big fan of pry so it might be useful to add rails 5.0.0.alpha support for those who developing edge rails.

Thanks!

Just released 0.3.3 with these changes. Thanks again for your contributions.


chore(flagship): upgrade react redux to 6.0

tested in pirateship

This looks good, in the future though it would be best to try not to change the ordering of packages in package.json, just for pr clarityreadability


[WIP] Dismissed notification bucket

Thought brought up in MUMMNG-2071. What do we do with notifications that are no longer relevant?  Here is one take. We move them to another bucket in the notification json.

:+1:  So this gives us expiration on notifications? Also, hover on "i" icon, would be tap on mobile?

@keirserrie : this gives us the illusion of expired notifications. Not sure on the mobile thing. I'll have to check that out when it gets to an env. Could switch to a click if need be.

:+1: .  I love this feature.  As noted inline, there are some details of the implementation and of the user interactions that are, well, complicated.
We have four-ish notifications today, for small values of four.  I'm fine with shipping this feature as-is and learning from it.  I'm also fine with giving some of these details some more thought and tweaking this some before shipping it.

Agreed with @apetro that there's a subtle difference between a user dismissing a notification and us automatically 'dismissing' it for irrelevance. We will probably want to think about addressing that nuance in the future. But I'm also a :+1: for :shipit:

Not shipping as is, but got some great ideas. I think we will revisit this with a better step forward. You will see rev 2 during our next lul

Thoughts--

"Archived" may be a better name than "dismissed," as it seems more likely that stale content would be auto-archived.

"New" sets an expectation of, well, newness. Old notifications wouldn't be there. Logically, they're now in the archived section.

Users probably won't want to move an expired notification back to the new bucket. Extreme edge case.

Assuming this is an edge case, rather than providing more info w/the rollover and icon, we can launch with a blank space there. Don't answer the unasked question.

I thought it may also be nice to have a count next to the tab title (e.g.: New (2)   |   Archived (102) )

Agree

@keirserrie : What are your thoughts on having some icon in place of the x in new if its not dismiss-able. Sort of like the i for dismissed.  It could be another tooltip to tell people they have to take the action in the notification in order to dismiss this notification.

Related to my above comments, I'd err on the side of less...have this area blank if you can't dismiss. We can gauge user confusion/frustration. My guess is that there won't be advanced engagement w/this interface, so simplicity is best for usability and accessibility.
Open to debate...


Add Notebook lint/fmt actions

Tested on my fork, with some manual modifications to notebooks. See this run.

Added support for running manually and re-tested a pull request and running the action manually.
I'll add the website button check back in when nblint supports it.


[crash/fuzzing] "index out of bounds" in wain validate

Hey,
My fuzzer just triggered this panic index out of bounds error.
Crash:
$ ./target/debug/wain index_oob_wain.wasm
thread 'main' panicked at 'index out of bounds: the len is 4 but the index is 93', /home/scop/Documents/wain/wain-validate/src/insn.rs:391:28
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Download:
index_oob_wain.zip
Bug is happening here:
https://github.com/rhysd/wain/blob/27f9ef475ab29adc267b51225ab48288cc498ea3/wain-validate/src/insn.rs#L390-L392

Thank you for catching this. I'll look into.

This issue was fixed at 08527f5. Now it raises validation error as follows:
Error on validation: type index 93 out of bounds 0 <= idx < 4. error while validating callee at call instruction.  caused at byte offset 562

 ... 34 36 37 34 34 30 37 33 37 30 39 35 35 31 36 31 35 01 2b 26 3c 30 81 90 9b
     ^
     starts from here


[1.0] theme() helper doesn't work in complex properties

Hi,
I've noticed the theme() helper doesn't work inside CSS properties that aren't a simple background or color etc. If you use the helper in a statement with multiple values it just outputs nothing.
/* Source */
input::-webkit-autofill {
  -webkit-box-shadow: 0 0 0 30px theme('colors.gray.200') inset !important;
}

/* Outputs */
input::-webkit-autofill {
  -webkit-box-shadow: 0 0 0 30px inset !important;
}

It's working fine for simple statements like color: theme('colors.gray.200'); etc., so I'm working around it by using CSS variables like this for now:
input::-webkit-autofill {
  --shadowColor: theme('colors.gray.200');
  -webkit-box-shadow: 0 0 0 30px var(--shadowColor) inset !important;
}

I'm using Laravel Mix to build, with the following config:
const mix = require('laravel-mix')
const tailwind = require('tailwindcss')
const glob = require('glob-all')
const cssImport = require('postcss-import')
const cssPresetEnv = require('postcss-preset-env')
const cssNested = require('postcss-nested')
const purgeCss = require('@fullhuman/postcss-purgecss')

mix
   .copyDirectory('resources/img', 'public/img')
   .copyDirectory('resources/assets/', 'public/css/assets')
   .postCss('resources/sass/styles.pcss', 'public/css', [
      cssImport(),
      tailwind('./tailwind.config.js'),
      cssNested(),
      cssPresetEnv(),
      purgeCss({
         content: glob.sync([
            path.join(__dirname, 'resources/views/**/*.blade.php'),
            // Add any other files that reference class names here
         ]),
         extractors: [{
            extractor: class {
               static extract (content) {
                  return content.match(/[A-z0-9-:\/]+/g) || [];
               }
            },
            extensions: ['html', 'js', 'php'],
         }]
      }),
   ])
   .options({
      processCssUrls: false,
   })

I'm not sure what the problem here is; I assume it's a bug from further up the chain in post css or something, but thought I'd post here in case that assumption is wrong.
If there's a way to get it working please let me know!

Hmm weird! It seems to work as expected in a very small demo case like this:
https://github.com/adamwathan/tailwind-theme-function-test
I'll try to reproduce with a Mix setup in a few hours, but if you could create a repository that reproduces and provide it that would be helpful.

I'll try and make a reproducible version now.

I've tried to recreate it by forking your repo, converting to Laravel Mix, and trying to simulate my project as best as I can, unfortunately to no avail - still can't reproduce.

However... the issue seems to have disappeared. I can now use the theme helper in my CSS without any problems... I'm not sure what changed. Maybe just restarting the build tools fixed it?
Sorry to have wasted your time! If it happens again I'll try make sense of why it happened again, and re-open the issue.

Haha no problem! Glad it's working now 👍

I have a similar problem!
I have a mixin which takes 3 parameters, the last parameter is optional, the following code works fine:
$colors: ('white', 'black');

@each $color in $colors {
    @responsive {
        @include my-custom-mixin($color, theme('colors.' + $color));
    }
}

But if I include the third parameter, it returns Module build failed (from ./node_modules/css-loader/index.js): Unknown word (6872:3)
$colors: ('white', 'black');

@each $color in $colors {
    @responsive {
        @include my-custom-mixin($color, theme('colors.' + $color), '#eeeeee');
    }
}

Another use case that throwing an error is when multiplying a value from config:
$width: theme('screens.sm');

.element {
    width: $width * 2;
}

That's because Sass runs before PostCSS, so the theme function isn't actually evaluated until after the Sass is finished processing.
Sass is trying to evaluate theme('screens.sm') * 2 because theme('screens.sm') hasn't actually been converted to a real value until after Sass is done.
You should use calc instead:
.element {
  width: calc(theme('screens.sm') * 2);
}


Read the delay value from polling response

Part of the 2.15 OSB API spec (#161)

/assign @jberkhahn

/lgtm
/approve


Unable to install java in centos using ansible

Manually tried the following command executed successfully: "yum install -y java-1.8.0 wget"
Where as when entered in ansible playbook as following it gives error as
"fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "No package matching 'java="1.8.0"' found available, installed or updated", "rc": 126, "results": ["No package matching 'java="1.8.0"' found available, installed or updated"]}
"
Playbook Snippet:
vars:
tomcat_url: https://archive.apache.org/dist/tomcat/tomcat-8/v8.5.38/bin/apache-tomcat-8.5.38.tar.gz
java_version: 1.8.0
tasks:

name: install java 1.8.0
yum:
name: java="{{java_version}}"
state: present

tasks:

name: install java 1.8.0
yum:
name: java-"{{java_version}}"
state: present

try java-"{{ java_version}}"

please close this issue if this was been resolved


Fixed db path creation

[x] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

Resolves #1621

Thanks! This explains the CI failures.


Used checked addition when scanning numbers

Fixes #352

Sorry, that's not something that would interest me.

I mistakenly thought that the addition could not overflow if the multiplication didn't. Still don't completely understand how it happens, but you have proven that it does!
Thanks for this PR!

It can overflow if you have usize::max() / 10 * 10 + 9, because it can't represent the added 9 without overflowing.


ISO missing Partition Table

@covertsh ISO boots up in vmware but throws this error while creating a bootable USB using Etcher

Hi, thank you for your issue report. I will look into this as soon as I get some time. I confirmed that the ISO produced by the tool does work for booting VMs, which was my own primary use case. I will try burning the ISO to USB and check whether that works too.

You just need to run the isohybrid on the generated iso and it will be bootable. See this article: https://ferryhere.wordpress.com/2015/11/01/using-dd-to-create-a-bootable-usb-linux-system-from-iso-file/

I think this will be resolved when I implement the fixes in https://github.com/covertsh/ubuntu-autoinstall-generator/issues/17#issuecomment-902525212.


When will the -U flag work as intended?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

The current release fails to download from Youtube and suggests the user make a bug report.
The official "solutions" provided on github include manually reinstalling a nightly build and using a different program.

When will a conventional update be released?
Can we expect the -U flag to arbitrarily fail in the future, and will the recommended solution be to manually reinstall the program every time?
If the program fails to update, cannot identify the problem, and recommends a bug report be filed, how is the issue "solved"?
Why the opacity? -U has worked for years. Why is it broken now?
Since you have all this free time to close questions asking about it, why not just push the update and put an end to the bug reports?

Every duplicate issue makes it less likely that a new release version will appear.

Oh, I see. You're refusing to provide the update out of spite.


Carthage

Would be pretty good, since you deleted the old MarkupKit repo :(

Sorry for the delay in responding - not sure how I missed this.
Could you elaborate a little on what you are looking for? MarkupKit "just worked" with Carthage. I never had to explicitly add support for it. Lima's project structure is nearly identical, so I imagine it should also work.
You could also try using the pre-compiled release binaries. I believe Carthage basically produces the same thing.

Well I suppose since I didn't see any mention of Carthage in your README, and although I'm not 100% sure, I do believe MarkupKit had a mention about carthage. That coupled with the fact that when I tried to run carthage update Lima , it failed.
Tried that command again, with the addition of platform, so:
carthage update Lima --platform ios
That worked :+1:
I also got a bit scared or confused when I read the line in your readme:
"The Lima framework is a universal binary that must be "trimmed" prior to submission to the App Store:"
Making me worry about rejections and the like, don't remember having to trim or anything for MarkupKit. Am I overly worried?

The MarkupKit README definitely didn't mention Carthage, although it did mention CocoaPods - maybe that's what you are thinking of? In any case, it sounds like you were able to get it working. 🙂
The MarkupKit binaries also needed to be trimmed, although this isn't something you would have needed to do if you were using Carthage. Basically, it just removes the simulator binaries from the framework before the app is uploaded to iTunes Connect.


leiauteNFe.py missing in https://github.com/akretion/nfelib/tree/generated_odoo/odoo/v4_00

(works with v3_10 and not v4_00)

fixed (editix prefix pre-processing was crappy)


Add relevant scientific papers to rtd

resolves #139
resolves #174

I decided to have same label structure for Publications and References and therefore not to order the publications via year but by main author.

!test

There is still the duplication I mentioned in my last review. 🤔
What's the difference between both blocks?

There is still the duplication I mentioned in my last review. 🤔 What's the difference between both blocks @danielfeismann?

@johanneshiry Thanks for your second review and sorry for this! I assumed you ment the two Sections "Publications" and "References" in the References page. My bad! Note to myself, to read carefully. I removed the sections from the about page.

Looks good to me. Thank you very much for your efforts to finalize this!
One final remark @danielfeismann: even though I approve it any, I would really prefer to have to publications order in descending order starting with the most recent ones. Even this is not equal to the references then, I think people interested in SIMONA literate don't care so much about author names but on recent changes of SIMONA. With the current structure its quite hard to find, let's say the most recent 5 publications. So if you don't mind you may considering changing the publications section again or otherwise just merge it :)

Also a reasonable view. I found a way to have the labels in blue but with numbers and the descending order. So it should be a good compromise in my point of view. :) @johanneshiry

Perfect. Thank you!


slurm_test07_interactiveJob fails on DAS-5

slurm_test07_interactiveJob fails, I'm not entirely sure yet why. Possibly it finishes so fast that it is no longer in the queue when submitInteractiveJob() of SlurmSchedulerConnection tries to look up the interactive job by its 'comment' tag using getSqueueInfo().entrySet()

In the docker container this seems to be caused by a timeout that is set way to tight. Increasing the waitUntilDone from 2 to 30 seconds seems to solve this issue. Need to check if this is also the case on DAS.

Working on this now.

All test succeed on DAS5 except slurm_test07_interactiveJob. According to sacct the job ran fine however, so we seem to have a timing issue here....

It seems the job finishes so quickly that we don't actually see it appearing in the queue. It is already done when we check its status after the submit. As a result, the logic at nl.esciencecenter.xenon.adaptors.slurm.SlurmSchedulerConnection.submitInteractiveJob (lines 399-431) fails with an exception even though the job ran fine.

The slurm adaptor now tries to find the jobs several times (with a timeout), both in the queue and in the slurm accounting. There will allways be a timing issue there, as you don't know how long you should wait....
Fixed in cfcf3bf


[ROCKETMQ-101]Fix possible NullPointerException when retry in send Async way

JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-101

Coverage increased (+0.03%) to 31.549% when pulling a8802d0b153e0f452d7147d0f70bc9cbf57e46de on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Coverage increased (+0.09%) to 31.614% when pulling a8802d0b153e0f452d7147d0f70bc9cbf57e46de on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Coverage increased (+0.09%) to 31.614% when pulling a8802d0b153e0f452d7147d0f70bc9cbf57e46de on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Coverage increased (+0.09%) to 31.614% when pulling a8802d0b153e0f452d7147d0f70bc9cbf57e46de on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

This issue is valid and the bug will be triggered under the following conditions:

A target message queue is specified, which will pass null for TopicPublishInfo parameter;
Async sending;
Retry happens;
sendLatencyFaultEnable is enabled(On default, it's not enabled)

The PR, IMO, is not good as it simply disabled promised retry attempts without notice.  Instead of logging retry failure, retry sending should be done against the original chosen broker.

@lizhanhui , # 4 is not the nessary conditions, since even it is not enble, the tpInfo's method is still used.
        try {
            int index = tpInfo.getSendWhichQueue().getAndIncrement();
            for (int i = 0; i < tpInfo.getMessageQueueList().size(); i++) {
                int pos = Math.abs(index++) % tpInfo.getMessageQueueList().size();
                if (pos < 0)
                    pos = 0;
                MessageQueue mq = tpInfo.getMessageQueueList().get(pos);
                if (latencyFaultTolerance.isAvailable(mq.getBrokerName())) {
                    if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
                        return mq;
                }
            }

            final String notBestBroker = latencyFaultTolerance.pickOneAtLeast();
            int writeQueueNums = tpInfo.getQueueIdByBroker(notBestBroker);
            if (writeQueueNums > 0) {
                final MessageQueue mq = tpInfo.selectOneMessageQueue();
                if (notBestBroker != null) {
                    mq.setBrokerName(notBestBroker);
                    mq.setQueueId(tpInfo.getSendWhichQueue().getAndIncrement() % writeQueueNums);
                }
                return mq;
            } else {
                latencyFaultTolerance.remove(notBestBroker);//my npe is thrown here
            }
        }

Besides, if topic route info is null which propably means user is send through my seletor method, resend should still respect user's seletor, so chosen broker is not enough, the chosen queue is needed, which may be another issue, I guess it is not a very minal effort, since the existing interface does not record any chosen queue info.

Yes, #4 is not required as MQFaultStrategy#92 may also generate NPE.
Queue ID info is contained in the request header, minimal effort suffices.

@lizhanhui , please review the updated pr

Looks good.

Coverage increased (+0.02%) to 31.535% when pulling 18de2995e524135144159816dae75e17ebe9d9c1 on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Looks good, please @vongosling help review.

@vongosling @lizhanhui
This bug is crucial and easy to reproduce which makes send with seletor is  not reliable, when can this pr be merged and release?

@Jaskey You are right, I'll follow up and merge this PR ASAP.

LGTM~

@Jaskey I'll merge this PR soon. Please close this issue.

Thank you @vongosling @lizhanhui @zhouxinyu

@lizhanhui @Jaskey we'd better close after merge :-)

Coverage decreased (-0.5%) to 31.043% when pulling 18de2995e524135144159816dae75e17ebe9d9c1 on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Coverage decreased (-0.5%) to 31.043% when pulling 18de2995e524135144159816dae75e17ebe9d9c1 on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Coverage decreased (-0.5%) to 31.043% when pulling 18de2995e524135144159816dae75e17ebe9d9c1 on Jaskey:ROCKETMQ-101-NPE-when-retry into 573b22c37806a21543b90707bcce6022243a62da on apache:master.

Merged


Change, remotes and GitHub

The Remotes and GitHub section focuses more on Bare repositories on a local collaboration. I do not think we use these in real life anymore.
I would like to use a gitbub based example I have, where I  add the participants as collaborators (not the fork/pull cycle). User can use a username/password login (ssh key setup not a must). I believe this will be more realistic. If there is not objection, I will port my power-point to this document.

I agree that an example with GitHub is more realistic than a local bare repo - from my point of view please go ahead.

I have now considerably simplified this section. Resolving this issue.


fix: prompt key stage enum

Description

this adds an enum for key stages
it unions with z.string() just in case, although we might decide to lose that down the line

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BEAM-7680] Removed flaky assertion and separated unit tests in synthetic source test

Synthetic step unit tests was split into separate test cases. Removed flaky assertion which was depending on time.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @chamikaramj R: @laschmidt can you take a look? cc: @pabloem @kamilwu

Thanks @kkucharc! I left two comments.

Run Python PreCommit

@kamilwu any further thoughts on this?

Run Portable_Python PreCommit

Run Python_PVR_Flink PreCommit

Run Python PreCommit

@robertwb No, looks good for me.

Run Python PreCommit

Run Python PreCommit

Thanks all!


Add permission to groups of users access the event_streams_view

This PR is able to:

Add permission to access the event_streams_view in the follow groups:

administrator
desktop
operator
security
support
user
reader

@miq-bot add_reviewer @agrare

@miq-bot add_assign @agrare

@miq-bot assign @agrare

@martinpovolny @h-kataria can you review?

looks good. @CharlleDaniel is this an enhancement or a bug fix, please add labels appropriately.

@miq-bot add_lable enhancement

@miq-bot  add_label enhancement api

@miq-bot add_label enhancement

@miq-bot add_label api

@h-kataria done, could you merge now?


Make the FileprivateAtFileScope rule configurable.

The rule has now been named FileScopedDeclarationPrivacy and supports
making effectively-private file-scoped declarations either fileprivate
or private, instead of forcing fileprivate. This is controlled using
a configuration key (which now defaults to private, based on user
feedback).

cc @dylansturg


statusline overlaps separator when splitting horizontally

Fantastic idea!
Just one thing still bothers me (a little): I am using a statusline (lualine) and when splitting horizontally, it overlaps the window separator.

For special reasons, A friend of mine doesn't want winsep to block statusline,.So winsep will not overwrite statusline. If you want to achieve the demonstration effect, you should set it to laststatus 3

I also would not like to see the statusline disturbed. Maybe there is still a solution though: you could trace the horizontal line at the top of the lower window. So you would decorate 2 windows rather than one but would achieve the desired result.
In poor ASIIART:
 ___________
|                |
|   topwin |
....status....
 ___________

     botwin
....status....

I don't understand, can you draw a demo

Here we go:
We want to decorate the top window (green one) and have the problem that its statusline would be painted over by the lower horizontal separator.
I suggest to draw only the left, top and right separators for the green window
and a top separator for the red window.
This way, top window is surrounded by separators and statusline is untouched.

Here we go:
We want to decorate the top window (green one) and have the problem that its statusline would be painted over by the lower horizontal separator.
I suggest to draw only the left, top and right separators for the green window
and a top separator for the red window.
This way, top window is surrounded by separators and statusline is untouched.

This is a great idea, but the horizontal dividing line will block the red window.

The statusline 3 is the most appropriate

yes... that statusline = 3 is ok, although I have been used to having my statusline direct under the window.
Anyway, thx for the plugin and your answers.
If you do not have any further comments, you may close.

yes... that statusline = 3 is ok, although I have been used to having my statusline direct under the window.
Anyway, thx for the plugin and your answers.
If you do not have any further comments, you may close.

yes


Add style guide and improve documentation

🗣 Description

Adds a style guide and branch protection guide, plus additional project setup documentation and making sure to apply our own style guide to our docs.
💭 Motivation and Context

These documents will help us work together cohesively. The style guide is a living document and will be added to over time as we find more unwritten rules and guidelines to write.
🧪 Testing

Documentation-only - linters pass.
✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

I added a section on capitalization of abbreviations such as HTTPS, from discussion in https://github.com/cisagov/cool-assessment-terraform/pull/93.

I added a section on capitalization of abbreviations such as HTTPS, from discussion in https://github.com/cisagov/cool-assessment-terraform/pull/93.


Displaying map between overlayed content

I have 2 divs, one fixed at the top. As the user scrolls down, the bottom div overlays ontop of the top div.
The map is located in the middle on some content in bottom div.
Would it be possible to stop the map from displaying beneath the top div when the used scrolls?
Please see the attached screenshot for an example.
Also, each portion of the dom as a different background colour... Is it possible to adjust what is being set by the plugin?

The map is always located UNDER the browser.
https://github.com/mapsplugin/cordova-plugin-googlemaps/wiki/Map#how-does-the-plugin-work

So, I take that as it is impossible, and should just use the JavaScript API?

yes


Feature/release v1.3

@DorukAkinci since you've contributed the metrics metering changes in the meantime I sugges to rebase this PR on top of master before relasing v1.3. In this case this PR would however need your additions to release notes in CHANGELOG.md


Performance issue on getCanvasBBox() during graph.render()

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
Sorry, but can't really reproduce that: (client's data) and custom layout
Steps to reproduce
But on a relatively small graph with some 1700 nodes (modelRect), 30 combos (rect), and 6300 edges (cubic-horizontal) graph.render() takes around 60 seconds to finish.
After that all operations with graph do not experience that issue.
Profiling in Firefox shows that it spends most of the time in getCanvasBBox()

I've already set localRefresh, fitView, fitCenter to false to avoid calling those functions as much as possible (because it would crash).
Any ideas on what can be causing that slow-down and how to prevent that?

Environment
Info

g6
4.1.1

System
Windows 10

Browser
Chrome 87.0.4280.141

Sorry, but can't really reproduce that: (client's data) and custom layout

I think most of the getCanvasBBox() is called by the combos since the size and the position of each combo depends on the sub-items' bounding box, including sub nodes and sub combos. And the combos construct a hierarchy tree. Maybe just try remove the combos to see whether it is the reason. If so, we might need to figure out how to optimize the combo mechanism in G6.
And localRefresh might not really relates to the problem. But for the first time rendering, turns localRefresh to be false might help. And turning it to be true after graph.render will be helpful for local interaction and refresh for better local rendering performance.

I think most of the getCanvasBBox() is called by the combos since the size and the position of each combo depends on the sub-items' bounding box, including sub nodes and sub combos. And the combos construct a hierarchy tree. Maybe just try remove the combos to see whether it is the reason. If so, we might need to figure out how to optimize the combo mechanism in G6.
And localRefresh might not really relates to the problem. But for the first time rendering, turns localRefresh to be false might help. And turning it to be true after graph.render will be helpful for local interaction and refresh for better local rendering performance.

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

That is strange, it will be helpful if you can provide a reproduction.

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

That is strange, it will be helpful if you can provide a reproduction.

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

Ahh, toFullDataURL copies the whole canvas onto another one for getting the full picture of the graph. It will be better to generate the image for image minimap in pre-processing progress or in on the server but not on the front-end. If there is no server in your project, what about using minimap with keyShape type instead?

You mean moving the whole G6 on the server side wrapping it with something like node-canvas?
Our graph is not static, it has some interactions that change the way it looks, so we have to regenerate minimap every time graph is updated.

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

Ahh, toFullDataURL copies the whole canvas onto another one for getting the full picture of the graph. It will be better to generate the image for image minimap in pre-processing progress or in on the server but not on the front-end. If there is no server in your project, what about using minimap with keyShape type instead?

You mean moving the whole G6 on the server side wrapping it with something like node-canvas?
Our graph is not static, it has some interactions that change the way it looks, so we have to regenerate minimap every time graph is updated.

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

That is strange, it will be helpful if you can provide a reproduction.

Yeah, I'll try to reproduce that as close as possible.

@Yanyan-Wang By the way, turning localRefresh on after the initial render still makes me run into maximum call stack exceeded error on getCanvasBBox() on large graphs, so I kept it off position

That is strange, it will be helpful if you can provide a reproduction.

Yeah, I'll try to reproduce that as close as possible.

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

Ahh, toFullDataURL copies the whole canvas onto another one for getting the full picture of the graph. It will be better to generate the image for image minimap in pre-processing progress or in on the server but not on the front-end. If there is no server in your project, what about using minimap with keyShape type instead?

You mean moving the whole G6 on the server side wrapping it with something like node-canvas?
Our graph is not static, it has some interactions that change the way it looks, so we have to regenerate minimap every time graph is updated.

Nope, what I mean is the Image Minimap might be more suitable for a graph with static data, and the image of the minimap can be generated only once when the static data is outputted. If the data is not static, you have to generate the image frequently, which will be expensive.
So, maybe just try the Minimap with delegate type.

@Yanyan-Wang Thanks for that comment.
My investigation now showed that it was imageMinimap plugin that was slowing the render down.
When I commented out the
 graph.on("aftergraphrefresh", () => {
    graph.toFullDataURL(img => {
    ...

piece of code - performance changed dramatically (1.5 seconds for graph.render() instead of 38 seconds in my sample).
My guess would be that this event is fired somewhere in between render process?

Ahh, toFullDataURL copies the whole canvas onto another one for getting the full picture of the graph. It will be better to generate the image for image minimap in pre-processing progress or in on the server but not on the front-end. If there is no server in your project, what about using minimap with keyShape type instead?

You mean moving the whole G6 on the server side wrapping it with something like node-canvas?
Our graph is not static, it has some interactions that change the way it looks, so we have to regenerate minimap every time graph is updated.

Nope, what I mean is the Image Minimap might be more suitable for a graph with static data, and the image of the minimap can be generated only once when the static data is outputted. If the data is not static, you have to generate the image frequently, which will be expensive.
So, maybe just try the Minimap with delegate type.

Hi, dear user. Since there was no response for a long time, we cannot figure out the answer of the problem you described. If there is new progress, feel free to open a new issue.


[bug] Sveltekit + Tauri v2 beta automatically closing without any errors

Describe the bug
When I'm developping my Sveltekit + Tauri app and updating a component that's trigger the Vite reload. Tauri just close randomly without any errors, warning or any text.
Reproduction
Generate a Sveltekit + Tauri beta project. (First Sveltekit then Tauri, not from create-tauri-app)
Create a svelte component.
Update it multiples times to trigger the Vite reload each time
Watch Tauri closing after two or three attempts.
Expected behavior
The app should not close at any point.
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 121.0.2277.106
    ✔ MSVC:
        - Visual Studio Build Tools�2019
        - Visual Studio Community 2022
    ✔ rustc: 1.75.0 (82e1608df 2023-12-21)
    ✔ cargo: 1.75.0 (1d8b05cdd 2023-11-20)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.10.0
    - npm: 10.2.5
    - bun: 1.0.18

[-] Packages
    - tauri [RUST]: 2.0.0-beta.2
    - tauri-build [RUST]: 2.0.0-beta.1
    - wry [RUST]: 0.35.2
    - tao [RUST]: 0.25.0
    - @tauri-apps/api : not installed!
    - @tauri-apps/cli [NPM]: 2.0.0-beta.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../build
    - devUrl: http://localhost:5173/
    - framework: Svelte
    - bundler: Vite

Stack trace
No response
Additional context
No response

Seems to be a mouse event. When I'm hovering a button, the cursor change rapidly between the base cursor and pointer cursor and after 5-10 secondes my app just close.

Should be fixed by https://github.com/tauri-apps/tauri/pull/8790 then


Cannot open multiples of same task

Version: 1.30.0-insider (system setup)
Commit: 85f805acf9436381b878cab5ab6c5146beec7893
Date: 2018-12-05T06:19:36.555Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134
Steps to Reproduce:

Add a task like:

		{
			"label": "nodejs environment",
			"command": "../.node/UseNodeEnv.ps1",
			"type": "shell",
			"options": {
				"shell": {
					"executable": "powershell.exe",
					"args": ["-ExecutionPolicy", "Bypass", "-NoExit"]
				}
			},
			"problemMatcher": [],
			"presentation": {
				"echo": false,
				"reveal": "always",
				"focus": true,
				"showReuseMessage": false,
				"panel": "new"
			}
		},

Where ../.node/UseNodeEnv.ps1 could be any powershell script.
2. Run the task twice
3. On second run you'll get a message asking if you want to Terminate or Restart the task.
4. With the config "panel": "new" I expect another task instance to be opened.

"panel": "new" controls if the terminal is re-used, not if a task can have multiple instance.
Duplicate of #32264


Transparent tray icon sometimes

Steps to reproduce
Experienced on my Framework Linux Mint and Ubuntu Pegasus.

Where are you starting? What can you see?
What do you click?
More steps…

Outcome
What did you expect?
What happened instead?
Operating system
No response
Application version
No response
How did you install the app?
No response
Homeserver
No response
Will you send logs?
Yes

Maybe related to Benjamin-Loison/Signal-Desktop/issues/1.


IBMCloud: IBMCloud: Deprecate CISInstanceCRN and AccountID IBM Cloud platform fields

HIVE-1620
CISInstanceCRN and AccountID parameters (required for cluster deprovision) can be retrieved from the IBMCloud API. Hive will no longer require them. These fields are now optional and will not be used.
/hold

This looks sane. Held for testing?
/test e2e

@2uasimojo Yes, also held because I'd prefer to just remove these from the API.

Discussed removal in scrum today. For backwards compat they will need to be optional in the API and then will be unused (deprecated) by hive going forward.

/unhold

/lgtm


Where to get the attributes of Market and dukemetc dataset?

❓ How to do something using fastreid
Describe what you want to do, including:

what inputs you will provide, if any:
what outputs you are expecting:

NOTE:

Only general answers are provided.
If you want to ask about "why X did not work", please use the
Unexpected behaviors issue template.

About how to implement new models / new dataloader / new training logic, etc., check documentation first.

We do not answer general machine learning / computer vision questions that are not specific to fastreid, such as how a model works, how to improve your training/make it converge, or what algorithm/methods can be used to achieve X.

https://github.com/vana77/Market-1501_Attribute and https://github.com/vana77/DukeMTMC-attribute


Add nice support for being logged into multiple Zulip servers at the same time

@timabbott Claimed. I had the same idea for my electronic-wechat. This won't be easy to do and will take some time. Hope to get it done before 21 March.

@geeeeeeeeek basically we want to add something like this -

https://github.com/Thomas101/wmail
Let me know if you need any help in this.

Understand. Will have a try on the weekend.

Update: There will a few changes to our current architecture.

[Front-End] For now we use new-domain to open a new window for one Zulip server. To support multiple servers, we will open a single-instance browser window (like the screenshot attached before). This should be a local webpage which contains a WebView. Each time the user switch to a new server, the webview will be redirected to a new domain.
[Back-End] We need to change the structure of how servers are stored in the local environment. This should be represented as an array of JSON objects, each containing the name, domain, credentials of a server. The array should be in order and remembers the last active index.

Estimated time to complete: 27 March.
In the future, we may also consider:

Introducing a more complicated server management UI in the preference panel.
Multiple servers online at the same time. So that users can receive notifications from different servers.
Seamless loading when switching between servers.

Estimated time to complete: During GSoC.

@geeeeeeeeek I wanted to work on this feature as a part of my GSoC Project. It would be nice if you could be here to guide me for this task during GSoC.

@Lplenka Sure. I am working on the basic functionalities and sure there will be much to improve after.

Thank you @geeeeeeeeek

@geeeeeeeeek I wanted to work on this feature as a part of my GSoC Project. It would be nice if you could be here to guide me for this task during GSoC.

@timabbott  @akashnimare
This issue is first phase of GSoC proposal. Forgot to gave a link to my proposal prototype earlier here.
https://github.com/Lplenka/zulip-electron/tree/Multiple_Server
Will work on this issue more thoroughly and improve minute UI and backend requirements in summer.

This feature has been added and will be pushed in next release.

This feature has been added in https://github.com/zulip/zulip-electron/commit/68c90434b305e107b5bf1e2858f6a05b63a47f07. Thanks, @geeeeeeeeek 💪


GitHub actions

Critical Changes
added cspell and eslint packages and configured github actions to run on every push

W-10004087
W-10004095

Can we delete this PR and branch since it was intended for the cx repository?


The source code of @modulz/primitives

How do I get the source code of @modulz/primitives?
Now I can't find it in any repos.

We're in the process of open sourcing the Modulz Primitives and should be ready in the next few weeks. Once they're ready, they will be made public and we'll be announced via our Twitter, accompanied by documentation for every primitive.
If you'd like early access, reach out to Colm and we'll invite you to the Discord channel.


Allow period and hyphen in attribute names

Moderator:
Moderator Status Review:  New issue, 2023 November 10
Requirement Summary:  None.
Technical Proposal Summary:  Add ASCII period (.) and ASCII hyphen (-) to the set of characters allowed in netCDF attribute names.
Benefits

Support desired new naming patterns for attributes.
Enable the use of IETF BCP 47 language tags for attributes.
Enable the use of other meaningful suffixes for attributes.

Caveats

Name rules in most programming languages will prevent the use of program variables or attributes with exactly matching names for such attributes.
Referencing such attributes with dot notation will be prevented in Python and similar languages.
Special quoting or access functions such as getattr, putattr must be used instead.

Status Quo:  Attribute names are now restricted to letters, digits, and underscore only.
Associated pull request:  #478
Detailed Proposal:  Add a new sentence at the end of the first paragraph of 2.3 Naming Conventions as follows. The remainder of 2.3 is left unchanged.

Variable, dimension, attribute and group names should begin with a letter and be composed of letters, digits, and underscores. Note that this is in conformance with the COARDS conventions, but is more restrictive than the netCDF interface which allows use of the hyphen character. The netCDF interface also allows leading underscores in names, but the NUG states that this is reserved for system use.  ASCII period (.) and ASCII hyphen (-) are also allowed in attribute names only.

Note:  This proposal is a subset of CF #237, and is superseded if #237 is adopted.

I support this proposal.  Given the discussions in #237 and cf-discuss #244, it's clear that there is a need to provide support for localization, but also that there are many hazards to expanding the list of allowable characters.  This approach seems the be the best way to provide that support while opening up the fewest cans of worms.

Is there a reason to to extend it to a few more punctuation characters, e.g. the colon : (Code Point U+003A). I believe that the colon was suggested as a separator in one version of the i18n proposal.
Once names are not longer legal as programming language identifiers, maye there's no reason to restrict them more than necessary maybe a couple more chars?
NOTE: I fully agree that full Unicode letters is a larger proposal that should be handled separately.

I would oppose adding the colon.
Adding . and - can cause problems for programmatically creating variables in a program with names that are the same as the names of the variables/attributes in a netcdf file, but strategies for working around it seem pretty clear and straightforward to me.
However, there are also workflows that involve parsing the text output of ncdump, which uses : as the delimiter between variable/attribute name and value.  In  my experience, it would be much, much harder to modify those to accommodate : as an allowed character in a variable name.
I think we want to be very conservative when it comes to adding allowed characters, and not do it until and unless we have a clear and strong demand for it, and have had a long discussion about what could work and what problems it could cause.  We've done that with . and -, but I don't think that's the case for :.

text output of ncdump, which uses : as the delimiter between variable/attribute name and value

Good point -- yes, that takes colon off the table.

While I am in favor of the general direction this proposal is going, I also very much agree with what @sethmcg writes.  Here I would like to approach this from slightly different angle.
The proposal lists the following benefits:

Support desired new naming patterns for attributes.
Enable the use of IETF BCP 47 language tags for attributes.
Enable the use of other meaningful suffixes for attributes.

As the proposal now stands it will certainly support these benefits but it will also come with some possible drawbacks:

Attribute names can have any combination of the allowed characters, of which some may not be desired (acknowledging that this is a value statement)
it is not clear what a "suffix" is, and how to distinguish one from some other possible usage patterns involving period and hyphen.

I think that we need a deeper discussion on what we want to achieve by allowing the period and hyphen. In netCDF these are already allowed in attribute names, so the question is how CF wants to use them. For example:

Is the period only going to be designated as marker between an attribute (CF meaning) and its suffix, as in attribute.suffix?
If not, how is the specific use case of IETF BCP47 language tags going to be identified in relation to all other possible attribute name patterns that will emerge?
As a middle ground between these two, are there other specific uses of the period that may be impacted if it is used for demarcating a suffix?

Currently, we have one concrete use case and that is the need for localization, for which the requirements are pretty clear: to attach a language tag construct (language-country) to attributes. From the conversation in discuss/#244 there is convergence towards using period as marker to indicate start of a language tag. This is a much more specific need than a general extension of the allowed character set.

@larsbarring,

it is not clear what a "suffix" is, and how to distinguish one from some other possible usage patterns involving period and hyphen.

"Suffix" here is a vague reference to possible future uses for the added characters.  It is not part of the new text.  It does not need further definition at this time.

I think that we need a deeper discussion on what we want to achieve by allowing the period and hyphen. In netCDF these are already allowed in attribute names, so the question is how CF wants to use them.

Is the period only going to be designated as marker between an attribute (CF meaning) and its suffix, as in attribute.suffix?

This particular PR adds two characters without any directed usage.  This will enable any desired future usage, public or private, without violating a CF name rule.  Think of it as adding punctuation characters with equal status to the underscore.

If not, how is the specific use case of IETF BCP47 language tags going to be identified in relation to all other possible attribute name patterns that will emerge?

I have not given it much thought.  Simple pattern recognition should take care of most cases.  BCP47 is highly recognizable.  Hypothetically, the details would be negotiated if there was another "suffix" proposal that had potential conflicts with BCP47.

As a middle ground between these two, are there other specific uses of the period that may be impacted if it is used for demarcating a suffix?

Possibly.  I am not concerned about that at this time.

Currently, we have one concrete use case and that is the need for localization, for which the requirements are pretty clear: to attach a language tag construct (language-country) to attributes. From the conversation in discuss/#244 there is convergence towards using period as marker to indicate start of a language tag. This is a much more specific need than a general extension of the allowed character set.

Agreed.  My intention is a general extension.

it is not clear what a "suffix" is, and how to distinguish one from some other possible usage patterns involving period and hyphen.

In the*nix world (and pretty much everywhere other than the old DOS 8.3 system), a "suffix" is the part after the last dot in a filename. By convension, but not by fiat, that suffix is a short code indicating the file type. As chaotic as that seems, it actually works pretty well. I think that's the case here too.
Step one: allow "." and "-".
Step two: establish one or more conventions for how they can be used, I would think starting with the idea of a "suffix" similar to the above, and then one or more uses for that, e.g. the language spec proposed.
In short, I think it's OK to leave it kind of loosey-goosey.

Hi all,
At @JonathanGregory's request, I've volunteered to moderate this proposal.  It looks like we are in agreement that the proposal is acceptable as-is, and it has received a sufficient amount of support.
Unless anyone has any new concerns to raise, this proposal will be accepted in three weeks.

Thanks, @sethmcg.
PR #478  needs a couple of additions:

the conformance document needs updating
the revision history needs an entry

I don't think that these changes require a clock reset, as long as they're done and agreed before merging. @Dave-Allured - could you possibly add these items?
Many thanks,
David

In my earlier comment I had some concerns, but they were/are not strong enough. As no one else have expressed thought in the same direction I am happy to support this proposal (with the same comment as @davidhassell regarding additions).   Thanks @Dave-Allured and @sethmcg!

Three weeks have passed with no new concerns raised, so this proposal is now slated to be accepted.
@davidhassell is PR #478 ready to go?

Hold until I find time for completions requested by Jonathan.

Will do!

Dear @Dave-Allured and @sethmcg
Maybe I can help this along. One of the two outstanding things is to modify the conformance.adoc. I think the required change is to insert the following:

ASCII period (".", decimal 46, Unicode U+002E) and ASCII hyphen ("-", decimal 45, Unicode U+002D) are also allowed in attribute names only.

as a second bullet in Sect 2.3 of the conformance document.
The other necessary change is to add a line at the top of the history of the working version in history.adoc.
Cheers
Jonathan

@davidhassell @sethmcg @JonathanGregory Conformance and history docs are now updated as requested.  Anything else?

I have just added a couple of nitpicking comments in the PR.

I think it's ready now, thanks @Dave-Allured.
Would you like to merge it, @sethmcg?

@JonathanGregory  Merged!
Note: the "For maintainers" section on the PR boilerplate says "After the merge remember to delete the source branch."  The button to do that isn't showing up for me, but the branch also isn't showing up in the list of branches for the repo.  Has the repo been set to automatically delete merged branches?  If so, that reminder should probably be removed from the PR boilerplate.

Note: the "For maintainers" section on the PR boilerplate says "After the merge remember to delete the source branch." The button to do that isn't showing up for me ...

No.  This is another github thing.  That reminder should be aimed at the requestor, not maintainers.  "Source branch" is referring to the requestor's branch, not necessarily a branch in the CF repo.  It is generally the requestor's duty to clean up their own branches.
Perhaps that reminder should be reworded to clarify.  The way it is now, is good enough for me.

To strictly conform with CF rules, I am considering Lars' last minute PR requests to restart the wait clock for another three weeks.  You can leave this issue closed and merged the way it is now.  However, it would be fair to reopen the issue if anyone thinks it is necessary.  (Hint:  I hope not.)  Sorry I did not catch this technicality before merge.
Follow up here or in the PR #478, I do not care which.

To whom it may concern, I am reverting this change in new issue #548.  This original request was based on my misunderstanding of earlier wording about character restrictions.


Automatically refreshing VAULT_TOKEN

I'm using the kubernetes-vault project to obtain a Vault approle periodic token automatically.
It's just occurred to me that the VAULT_TOKEN itself will expire eventually, causing vault-sidekick to fail. Does vault-sidekick have any mechanism for automatically reloading/updating the token it uses to authenticate with Vault?
If not, I'll have to have (yet another!) sidecar container, that automatically extends the lease of the token.
Thanks

@munnerz May i ask you what args you are passing to vault-sidekick to updated the vault approle periodic token automatically. I am trying to achieve the same but the content of /var/run/secrets/boostport.com/vault-token remains same after the token_ttl passes.

great news, thx roboll for ur efforts :D


[SMALLFIX] wait for file completed in fuse getAttr [WIP]

In tensorflow with Alluxio-Fuse integration, scripts call getAttr() right after written a file. The file may be not completed and getAttr() will show that the file has a size of 0 which script will think as an error.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/1159/
Test PASSed.

will add unit test and integration test later

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/1160/
Test PASSed.

@calvinjia I feel it is a common type of pattern. If people are interested in the file size, they will always want the file to be completed and get a correct number of file size (they can tolerant longer blocking period) , but if they are interested in what files a folder contains or if a file exists, even 5 second blocking is too long for them.

I will merge this PR now and add integration tests and unit tests in other PRs


Handling oversized requests

Would be good to add some sort of oversize handler.

https://docs.aws.amazon.com/waf/latest/developerguide/waf-rule-statement-oversize-handling.html

Got this email.
We are reaching out to request that you inspect your AWS WAF (Web Application Firewall) rules and apply a size restraint rule, or define oversize handling behavior, by October 1, 2022.

With AWS WAF, customers can configure rules that allow, block, captcha, or monitor (count) web requests based on conditions they define. These conditions include IP addresses, HTTP headers, HTTP body, URI strings, SQL injection and cross-site scripting. When customers enable AWS WAF for CloudFront, Application Load Balancer, API Gateway or AppSync, only the first 8 KB of the request body are forwarded to AWS WAF for inspection. The 8 KB limit helps maintain high WAF performance and low latency, even during conditions of exceptional load. However, some bypass attempts intentionally put data towards the end of large (> 8 KB) requests. If your application does not expect requests greater than 8 KB in size, you can prevent them from passing through with a WAF size constraint rule statement. This will result in large requests being denied.

Don't like the sound of that.

Same here. Any solutions?

merged here https://github.com/awslabs/aws-waf-security-automations/pull/222 although pr opened and merged without approval by the same contributor seems like poor practice.


Update basis_mat.py

Hi, i find that in numpy >= 1.17, the 'np.matrix' method is deprecated, it needs to be changed into 'np.array'.

Thanks for your PR, I will check and rerun the code.


Settings File Bloat and Hangs when creating Encounters

Your implementation is insane. I do not know if you intended to do this, but you are copying every combatant to the settings.db file when you start the tracking. This causes the game to hang when you are setting up combat.
Also, the cleanup of the mess this makes does not work. This causes settings file to bloat making creating combat encounters to stall longer and longer each time.

Yeah, I'm aware of this issue. I've been meaning to fix it for a while but haven't gotten around to it. I do have another implementation of it partially finished.

Fixed in v2


change to allow indice options

In order to solve this issue: https://github.com/StarArawn/bevy_tiled/issues/19
Merge this pull request after bevy 0.2.2 is released

This looks to have already made it in


Metadata IG

??? Definite decision pending - 1hr
Juliet (Julie) Hardesty - IU

The HMIG would like to have a 1 hour meeting time if it works in the schedule.


Add cqlOptions to Library refresh

cqlOptions are included in the ELM for a Library, however, they should also be surfaced as a contained Parameters resource in the Library wrapper resource, as specified in the ComputableLibrary profile in the CRMI IG

Resolved by #446


Cloud run jobs specifying an environment via app.stage() with schedule decorator still deploy cloud scheduler to all envs

This works as-expected:
app = Goblet(
    function_name="test-service",
    backend="cloudrun",
    routes_type="cloudrun",
    local="local",
)

@app.job("testjob", schedule="* * * * *")
def test_cloudrun_job(id):
    do_something()

Run into issues we add configs to limit the cloud run job to only deploy to specific envs:
app = Goblet(
    function_name="test-service",
    backend="cloudrun",
    routes_type="cloudrun",
    local="local",
)

@app.job("testjob", schedule="* * * * *")
@app.stage(stages=["TEST","TEST2"])
def test_cloudrun_job(id):
    do_something()

The job itself is successfully limited to deploy only in TEST and TEST2 stages, but the scheduler continues to deploy across all envs. This errors out because the cloud scheduler tries spinning up in all envs (i.e. including TEST3), and tries to point at the cloud run job, but it doesn't exist in the GCP project associated with TEST3 env.

Does it work if you switch the order of the decorators?

ah sorry. i misread the bug. so it works correctly with the job, but not the scheduler within the job.
so it looks like this gets triggered in the job decorator
https://github.com/goblet/goblet/blob/main/goblet/decorators.py#L269
but the resulting function gets skipped correctly here
https://github.com/goblet/goblet/blob/main/goblet/decorators.py#L413

Switching the order of decorators didn't help. But yep, works correctly with the job, but not the scheduler attached to the job.
I have a working fix in https://github.com/goblet/goblet/pull/482 , but I think there might be a better way to go about it?
This PR doesn't tie the decorators together (i.e. @app.stage("TEST") and app.job(schedule="* * * * *") on separate lines), but it works if you specify the stage/stages together in the job decorator args, like @app.job(schedule="* * * * *", stage="TEST).

maybe we can do something in the _register_handler so we would fix it more downstream for other use cases. https://github.com/goblet/goblet/blob/main/goblet/decorators.py#L427

@kylejohnson514 take a look at #484. does that solve your issue?

@anovis yep, that does it. Thanks!


[Example][BERT] No performance improvement on V100 comparing with XLA

Problom Statement
I tried BladeDISC's BERT example on V100. The result, turns out surprisingly that BladeDISC has no performance improvement overt XLA. I'm wondering is it expected? or there is something wrong?
Configuration

GPU: V100
BladeDISC: latest-runtime-tensorflow1.15
Benchmark code:
I did some minor changes to the example code, by simplely testing every batch size multiple times. This is critical to XLA, because it would have a incredible long compiling time at the first few steps. Running every batch size multiple times would help us identify those warmup steps.

Experiment:

XLA:

DISC:

Conclusion:
Excluding those incredible long time XLA warm up steps (it's compiling), I can hardly find any batch size on which DISC surpass XLA.

1，Generally，we do not always expect DISC outperforms XLA since DISC is a fully dynamic shape compiler and use less effective information.
2, For you test case, you may try to set export DISC_ENABLE_STITCH=true, which may help to improve the fusion granularity.

The flowing table is from your number @zhuwenxi , looks like DISC's numbers are pretty close to XLA (or even better in some case), except when batch=1. And could you pls try the following flag:
os.environ["DISC_ENABLE_STITCH"] = "true"
os.environ["DISC_MEM_INTENSIVE_OPT_EXPERIMENTAL"] = "true"

batch
xla
disc
diff(positive is xls faster)

2
0.0178
0.0191
7.30%

4
0.0303
0.0294
-2.97%

8
0.0553
0.0536
-3.07%

16
0.1012
0.1019
0.69%

32
0.1943
0.1969
1.34%

128
0.7671

btw, do you have DISC's number on batch=128?

1，Generally，we do not always expect DISC outperforms XLA since DISC is a fully dynamic shape compiler and use less effective information.
2, For your test case, you may try to set export DISC_ENABLE_STITCH=true, which may help to improve the fusion granularity.

There is significant performance improvement after setting export DISC_ENABLE_STITCH=true, fascinating! I will post the data soon.

The flowing table is from your number @zhuwenxi , looks like DISC's numbers are pretty close to XLA (or even better in some case), except when batch=1. And could you pls try the following flag:
os.environ["DISC_ENABLE_STITCH"] = "true"
os.environ["DISC_MEM_INTENSIVE_OPT_EXPERIMENTAL"] = "true"

batch	xla	disc	diff(positive if XLA is faster)
2	0.0178	0.0191	7.30%
4	0.0303	0.0294	-2.97%
8	0.0553	0.0536	-3.07%
16	0.1012	0.1019	0.69%
32	0.1943	0.1969	1.34%
128	0.7671
btw, do you have DISC's number on batch=128?

batch = 128 on DISC crashes because OOM. Otherwise the other BS got pretty satisfactory performance improvement.

batch
xla
disc
disc-enable-stitch
diff(positive if XLA is faster)

2
0.0178
0.0191
0.0168
-5.9%

4
0.0303
0.0294
0.0251
-20.7%

8
0.0553
0.0536
0.0458
-20.7%

16
0.1012
0.1019
0.0869
-16.5%

32
0.1943
0.1969
0.1681
-15.6%

@wyzero @qiuxiafei Thank you for your replies, very helpful. I'm wondering why "DISC_ENABLE_STITCH" is on by default as long as it has such performance advantages.

@wyzero @qiuxiafei Thank you for your replies, very helpful. I'm wondering why not setting "DISC_ENABLE_STITCH" ON by default as long as it has such performance advantages.

It’s still WIP and will be enabled by default in the near future after we evaluate such feature over a diversified benchmarks.

Amazing!


IOT Central Device Files page is not showing folders

Hi, our IOT Devices are uploading files into daily folders but these folders are not showing on the IOTCentral device Files page.  The folders are being correctly created in the BlobStorage container but folders are just not visible.
If we upload the files without any folder structure then we can see the files.  However we really need to organise the files into yearly, monthly and daily folders or the list becomes un manageable.
How can we enable display of the folders in the Files page or alternately how can we add a custom files page that supports display of the hierarchical folder structure.
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c8c46569-ead4-1f57-ec7b-8860200a1dbe
Version Independent ID: 4c562481-be33-cbf0-e59c-06192d856b2e
Content: Upload files from devices to Azure storage - Azure IoT Central
Content Source: articles/iot-central/core/howto-configure-file-uploads.md
Service: iot-central
GitHub Login: @dominicbetts
Microsoft Alias: dobett

@duncangroenewald
Thanks for your feedback! We will investigate and update as appropriate.

@duncangroenewald
Can you confirm if you are using SDK to upload files? or side loading the files?
The files must be uploaded to a folder with the same name as the device ID. This is by design.
Since the IoT Device SDK uploads the files for each device into their own folder and the files view within IoT Central is per device.
If you are following the doc, and files should uploaded by the device SDK under the device id folder in the Storage account.
I would suggest, you please check below and let me know if you have any further queries.
My DeviceID is ashoktestdevice4 as shown below.

In your case, make sure you are using the correct names. I see two different names configured there while providing storage account details.
I have followed the same and able to see the files.
Storage Account:

Configuration of the Device File Storage:

Final Result:

@duncangroenewald
Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.
Also, if you have a product-related question, please post to Microsoft Q&A and we will happily continue the conversation.

@AshokPeddakotla-MSFT - sorry about the delay in responding.
YES - we are using the device SDK to upload the files and the files are correctly placed in the device ID folder. However we want to organise the files into YEAR/MONTH/DAY folders within the device ID folder.
This works fine and we can upload the files into these folders by including the target path
string filename = @"2024\2024_05\2024_05_01\logfileX.txt";

var fileUploadSasUriRequest = new FileUploadSasUriRequest
{
    BlobName = filename
};

 FileUploadSasUriResponse sasUri = await deviceClient.GetFileUploadSasUriAsync(fileUploadSasUriRequest);
 Uri uploadUri = sasUri.GetBlobUri();
...

The issue is that the IoTCentral device Files tab is not able to list the folder structure and shows the device files as being empty.
If we use the Filter option and enter "2024\2024_05\2024_05_01" then a list of files gets shown including the folder paths.
So the IoTCentral Files tab needs to have its file browser component updated to allow the display of a typical folder tree structure.
I hope this makes sense.


insert rows instead of append to end

how would this line of code be changed to insert at line 2 of the spreadsheet instead of add (append) to the end of document.
await sheet.addRow({ Date: dateTimestr, Event: req.body.event});

rolled into #615


Kraken BTC balance

There seems to be an issue surrounding Kraken BTC balance
Upon calling
print(kraken.fetch_balance()['info'])

I get
{'ZUSD': '0.4271', 'XXBT': '0.0013420000', 'XETH': '0.0093000000', 'BCH': '0.0000020000'}

And upon calling
print(market.fetch_balance()['BTC'])

I get
{'free': None, 'used': None, 'total': None}

Methods for obtaining the eth and usd balance work great.

Thanks! Will fix it asap!

Ok, this should work as of next version, 1.2.37 (should be available for downloading very soon). Please, if you can, update and report if Kraken BTC balance works normally after that. Thanks!

Ok, version 1.2.37 is now available, don't forget to update your package with pip)

Yeah works now properly.
Much obliged.


Price fix

Some refinement on top of https://github.com/credmark/credmark-models-py/pull/131

what's with all the merge conflicts? what happened exactly?

what's with all the merge conflicts? what happened exactly?

The revert has diverged the main branch from this branch. It'll be a painful to merge the conflict but another review is worthwhile.
In my last commit, I removed a few repeating web3 and unnecessary model calls - reducing price.quote time from 25s to 12s. I am re-running the tests now and plan a merge in your early morning. Talked to ivo/Peter, we have updated to minimum of 2 model runners.


PDB Causing TFS Build to "Partially Succeed"

My TFS Build is failing on "index sources" causing it to "Partially Succeed"
Indexed source information could not be retrieved from C:\Builds[My TFS BUILD PATH]\Binaries\Debug\CommonServiceLocator.pdb. Error: Symbol indexes could not be retrieved.

Did you see this issue?

I'me having the same issue with .NET 4.6.1 on TFS 2017 build...
Em qua, 20 de jun de 2018 17:21, Eugene Sadovoi<EMAIL_ADDRESS>escreveu:

Did you see this issue
https://github.com/unitycontainer/commonservicelocator/issues/23?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/unitycontainer/unity/issues/233#issuecomment-398883644,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACRoR5VQOXR0FX6cbDJ512AnF-e5YW1Rks5t-q6vgaJpZM4Uv0H_
.

--
Atenciosamente,
Lucas M. Pereira
Skype: lucas.mendespereira
Celular: (18) 99743-2066

I am not sure what exactly is wrong here. Should I not include PDBs in the package?

ENikS,
I'm not sure about excluding the PDBs in the package...  When you add nuget packages in VS with TFS connected, they automatically get added to source control.  At the point you check in the code and the TFS build kicks off, the "Index Sources" part of the TFS build fails on the PDB file.  It doesn't seems to be only "CommonServiceLocator.pdb" because I deleted that from TFS and it hit the next PDB in the package with this error.

Manu package come with pdb's, i don't think it's the base issue cause... maybe it's the pdb format that is coming on the package..

Maybe changing the debug type from Full to portable could resolve this issue... I'me on mobile right now, so i can't try It ... If anyone can would be helpfull

If you find the type that works let me know, I'll change it...

Sorry for the delay.
Today i have found some time to more investigations and to do some tests.
I can't finish all it today, but will bring here what i've found, so if anyone else is interested:
First, some readings:
Portable PDB from dotnet/core repository
.NET Framework 4.7.1 Announcement: runtime is now supporting Portable PDB's
So:

DebugType Full will be emitting Windows Only PDB's, that just can be read or written on windows systems. (VS Code can't read Windows PDB's, even when running on Windows, as it is deigned to be cross-platform)
DebugType portable will be emitting the new, open-source and cross-platform PDB.

Known throwbacks of Portable PDB's

Older versions of Visual Studio debugger (before VS 2015 Update 2) don't support it;
For runtimes older than .NET Framework 4.7.1 stack traces wouldn't contain line number mappings and source file name if a portable PDB was shipped.
Code Coverage don't work well with portable pdb's with targets less than netcoreapp2.0.

--- by now ---
Probably, would be reasonable to use DebugType Full for debug configuration, and portable for release, on targets equals or above .NET Framework 4.7.1.
The Source Indexing task on the TFS isn't necessary on portable pdbs, it's already done during the Build. reference
On the testings (WIP):
I've compiled unity, with release configuration using portable PDB's and published the packages with   symbols to our TFS package repository.
Re-targeted my projects to .NET Framework 4.7.1, also using portable PDB's.
The build completed and symbols where successfully published.
Now i need to deploy it and test if i'll able to debug using the PDB's from the SymbolStore, but, i'm at home now, and neither i have an environment to deploy here, nor access from here to SymbolStore, so i'll try to finalize the testings on the next Monday. (will update this since it's possible)

Fixed in https://github.com/unitycontainer/container/commit/4090608be0986be25bf32f7029588dd7a13af629

@KveRa Please let me know if new release causes problems again

Ok Eugene, Will try It soon.
Em qui, 23 de ago de 2018 08:49, Eugene Sadovoi<EMAIL_ADDRESS>escreveu:

@KveRa https://github.com/KveRa Please let me know if new release
causes problems again
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/unitycontainer/unity/issues/233#issuecomment-415387094,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACRoR1GsK2tFBbVeaKscjm3p9e8yQ0Kwks5uTpbagaJpZM4Uv0H_
.

--
Atenciosamente,
Lucas M. Pereira
Skype: lucas.mendespereira
Celular: (18) 99743-2066


Some snippet tha make the parser fail

When testing the pr for the loader I found some snippets that fail. For the record:
ls.parser.parse_snippet({trig="for_i", wordTrig=true}, "for ((${0:i} = 0; ${0:i} < ${1:10}; ${0:i}++)); do\n\techo \"$${0:i}\"\ndone\n"),
ls.parser.parse_snippet({trig="for_in", wordTrig=true}, "for ${0:VAR} in $${1:LIST}\ndo\n\techo \"$${0:VAR}\"\ndone\n"),
ls.parser.parse_snippet({trig="case", wordTrig=true}, "case \"$${0:VAR}\" in\n\t${1:1}) echo 1\n\t;;\n\t${2:2|3}) echo 2 or 3\n\t;;\n\t*) echo default\n\t;;\nesac\n"),
ls.parser.parse_snippet({trig="texlr", wordTrig=true}, "\\left\\{ ${1:${TM_SELECTED_TEXT}} \\right\\\\}"),

I think the main issue is that some syntax is slightly off, eg. $$ should be \\$$, ${2:2|3} ${2|2,3|} and the fourth should look something like this: "\\\\left\\\\\\{ ${1:${TM_SELECTED_TEXT}} \\\\right\\\\\\}"(:vomiting_face:).
For the first and second, I'm not entirely sure what is expected to happen with the multiple $0, normally a Snippet should only have one of those I think.

Oh, and SELECTED_TEXT sadly isn't supported yet, but that shouldn't make the parser fail.

I just made it for you to know it, is fine for me if you remove it as I don't use those snippets anyway.

Ah okay, then I'll just close this as the parsers behaviour on invalid Snippets is unspecified, thank you nonetheless.


Refactor of test table

Closes #582
Closes #625
Changed the table to a mat-table.
The new table is scrollable.
If table ever needs to be sorted by columns, the mat-sort can be added like with the debug table

Theres some whitespace under the table, it should fill the rest of the entire page right?

Also why is the font-size so much bigger compare to the old one?

Also why is the font-size so much bigger compared to the old one? Old:  New:

I lowered the font size, but I'm not exactly sure what caused it to be smaller. Since no font-size was actually defined previously. My guess is that bootstrap had some predefined sizes, but those are not in the table, table-responsive or table-hover classes. Maybe it was in one of the parent container classes that used a bootstrap class.
Also added the comment and gave td elements a max width as without this, the table would take up space where the file tree element is.

The table is not taking the full width

 The table is not taking the full width

Changed it so it now takes up the remaining width.


Stage reflection effect

Describe your problem here.
how can I make a reflection effect on a stage similar to the effect in hotline

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

you can use FlxTrail

Basically just make another same image and lower it's alpha


Legal

New PR for updating legal bits. I did each one in a separate commit. So far it contains:
LICENSE/NOTICE update
Typo-fix
Apache Headers on all java files.
I'll update with namespace change after other outstanding PRs are merged.

@klucar is there an open discussion at that JIRA prior to merging this?  or is this ready for more review in order merge?

I had created it as a reminder, then Adam brought it up so I linked the
JIRA. I don't think there has been any discussion so far other than the old
one was out of date.
On Fri, Oct 16, 2015 at 9:17 AM, Ken Sipe<EMAIL_ADDRESS>wrote:

@klucar https://github.com/klucar is there an open discussion at that
JIRA prior to merging this? or is this ready for more review in order merge?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-myriad/pull/7#issuecomment-148714178
.

LGTM  any reason to hold up?  I'm ready to merge.

@klucar myriad-scheduler/src/main/resources/webapp/public/js/myriad.js
has a collision, it shows in your commit 1000+ additions and 700+ deletions... what did you do to this file?

I added the apache header to the index.html file and re-generated the site.
everything in public is auto-generated.
On Fri, Oct 16, 2015 at 11:31 AM, Ken Sipe<EMAIL_ADDRESS>wrote:

@klucar https://github.com/klucar
myriad-scheduler/src/main/resources/webapp/public/js/myriad.js
has a collision, it shows in your commit 1000+ additions and 700+
deletions... what did you do to this file?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-myriad/pull/7#issuecomment-148747405
.

merged!


tensorflow not running on pycharm

ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.

@engmoha80,
Could you please provide the tensorflow and the compatible version which you are trying to install. Also there are at least 3 possible scenarios:
- You need to install the MSVC 2019 redistributable
- Your CPU does not support AVX2 instructions
- Your CPU/Python is on 32 bits
- There is a library that is in a different location/not installed on your system that cannot be loaded.

Also kindly provide the environment details and the steps followed to install the tensorflow.
https://github.com/tensorflow/tensorflow/issues/61887
Thank you!

Duplicate of #19584. Please do a search before opening new issues. This is a very old issue and manifests because old PCs with Windows cannot load libraries needed by TF because they have very old architecture sets.


Flex styles on rowMoved

Hey, this is probably not considered an issue with the library itself but I wonder if someone has experienced this and has any solution.
Whenever I'm moving the row, the following happens:
1 - Expected styles;
2 - Moving row loses height;

This is my row component:
<TouchableOpacity
    onPress={() => { props.openCard(card) }}
    delayLongPress={300}
    style={[styles.card, { borderRadius: 8, overflow: 'hidden' }, card.isMainCard && styles.cardActive]}
     {...sortHandlers}
      >
         <View>
            <View style={[styles.row, { borderBottomWidth: 1, borderColor: '#b2b2b2', marginBottom: 10, paddingVertical: 5 }]}>
                <Text style={{ fontSize: 18, color: '#87c4be' }}>Public</Text>
             </View>
            <View style={[styles.row, { paddingVertical: 0, marginTop: 0 }]}>
                <View style={{ marginRight: 15 }}>
                     <Image source={require('../../assets/placeholder.png')} resizeMode="cover" style={styles.photoSmall}/>
                 </View>
                <View style={{ flex:1, flexDirection: 'column', justifyContent: 'center', alignItems: 'flex-start' }}>
                   <Text style={[styles.text, styles.title]}>{ job }</Text>
                    <Text style={[styles.text, styles.title, { fontWeight: 'bold'}]}>{ email }</Text>
                </View>
             </View>
          </View>
</TouchableOpacity>

const styles = {
   card: {
        alignSelf: 'stretch',
        marginBottom: 15,
        padding: 15,
        backgroundColor: '#fff',
        marginHorizontal: 10,
        shadowOpacity: 0.5,
        shadowRadius: 4,
        shadowOffset: {
            height: 0,
            width: 0
        },
        borderColor: '#fff',
        borderWidth: 2,
    },
  row: {
        flex:1,
        flexDirection: 'row',
        justifyContent: 'flex-start',
        alignItems: 'flex-start',
        paddingVertical: 8
    }
....

Thanks in advance.

Have you tried assigning sortRowStyle? Maybe that is defaulting incorrectly in your case.

I did try a couple of rules on the SortableListView component with sortRowStyle, yes. Did not end up any better, I solved it by removing all flex styles inside my TouchableOpacity

Closing as it seems workaround has been found.

@RUIFERNANDE5 I solved it by removing all flex styles inside ，It‘s work for me


Default values/blocks in global variable declaration and lists are not replacable

some issue with connecting them internally

Remove shadowed blocks here because of the list that have shadows in schadow blocks which causes lot's of problems


Outreachy week one

In this PR I:

cleaned up KeyValueStoreUtilsTest.java
cleaned up RowPathColumnTest
fix null pointer warnings and clean up UTMConverterTest
update test dependencies

runtests

runtests


Provide python-attrs classes?

First, thank you for this great resource.
What about providing python attrs based classes for representing the data structures? This would also double at documenting the meaning of the structures.
Serialization using cattrs would enable typed import of the data.

I haven't used attrs, but have enjoyed using data classes in other projects.
As for a data/protocol - I like JSON as every language can read the files or consume the REST API so it would have to be in addition to JSON
I do like the idea of being able to generate docs from the type annotated structure.
So: No promises this will happen any time soon but I'll have a play sometime and see how it looks


Update year to 2022

Signed-off-by: Matt Dainty<EMAIL_ADDRESS>
Pull Request Motivation

I recently updated to cert-manager 1.9.1 and as part of the git diff output noticed the year had gone backwards from 2022 back to 2021 in the license header.
I think I've found the right place to fix it :smile:
Kind

documentation
Release Note

NONE

/approve

/ok-to-test

/retest

/retest

/lgtm


Deprecated TLS negotiation in URLLIB3 causing issues

In reviewing a number of scrapers today for problem sets, I noticed that there was a pattern for when many started showing.  That pattern was around December 5th.
After investigating further it became clear that three court websites for atleast four courts still use TLSv1.2 - see below.
- https://www.la-fcca.org
- * SSL connection using TLSv1.2 / AES128-SHA

- https://www.jud.ct.gov"
- * SSL connection using TLSv1.2 / AES256-SHA256
- Warning: Ignores instruction to use SSLv3

- https://oag.ca.gov
- * SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256

urllib3 - which underlies requests deprecated the negotiations for older TLS standards when it switched to urllib3 > 2.0.
Four Louisiana Court of Appeals, the Supreme and Appellate courts of Connecticut we can resolve this by keeping urllib3 at the 1.26.18
For whatever reason - I havent found a simple solution for the California AG website.  But writing a custom http adapter with a "legacy server connect" solves California AG.  See below.
class CustomHttpAdapter (requests.adapters.HTTPAdapter):
    # "Transport adapter" that allows us to use custom ssl_context.

    def __init__(self, ssl_context=None, **kwargs):
        self.ssl_context = ssl_context
        super().__init__(**kwargs)

    def init_poolmanager(self, connections, maxsize, block=False):
        self.poolmanager = urllib3.poolmanager.PoolManager(
            num_pools=connections, maxsize=maxsize,
            block=block, ssl_context=self.ssl_context)

def get_legacy_session():
    ctx = ssl.create_default_context(ssl.Purpose.SERVER_AUTH)
    ctx.options |= 0x4  # OP_LEGACY_SERVER_CONNECT
    session = requests.session()
    session.mount('https://', CustomHttpAdapter(ctx))
    return session

Regardless - calag, conn, connctapp and lactapp_1 all have a path to resolve them.
I have a feeling that this change was triggered in Missouri appellate courts - and the errors built up and caused the courts to block us.  Which needs a call to reach out.

Read more about these changes here
Here

connctapp has started failing again. I guess conn may fail too after the fixed scraper is merged
Sentry Issue: COURTLISTENER-7HW

Sadly this is not surprising.

Currently we are using custom adapter, which makes fixed the loading of the HTML results page. However, downloading the actual opinion is failing on the server. It does not fail when running it locally, which adds to the mistery
https://github.com/freelawproject/juriscraper/blob/23c03a2ef6bafa8f18eb93f6f2716eddbfb6f0c9/juriscraper/opinions/united_states/state/conn.py#L41-L42
I propose changing the cipher approach for self.request['verify'] = False and seeing if that works


The custom icon doesn't show with tags

Hello,
Thank you for this amazing plugin for leaflet. It's very interesting and helpful.
I  have an issue and I don't know how to resolve it. The tag filtering is not working if I put the array in third position of the L.marker function. I would like to add custom icons but it doesn't work with the following code.
var icon_custom = L.icon({iconUrl: element.category_img, iconSize:[38, 45], iconAnchor:[0, 0],popupAnchor:[0, 0]}); var marker = L.marker([element.lat, element.lng],{icon:icon_custom},{ tags: [element.category_name]});
Could you help me with it ?

Actually I found  how to solve it using this function:
marker.setIcon(icon_custom);


Add missing commas to app-custom-theme docs

Signed-off-by: Víctor Suárez Fernández<EMAIL_ADDRESS>Hey, I just made a Pull Request!
Just add missing commas to the example which I noticed while copy-pasting.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[X] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Haha, thanks that was on my todo list!

Running prettier locally I get the following diff in the same file, however they seem to be not related with the content of this PR, should I commit this change too?
It seems to be the classic tabs vs spaces :smile:
@@ -123,15 +123,15 @@ const themeOptions = createThemeOptions({
   fontFamily: 'Comic Sans',
   /* below drives the header colors */
   pageTheme: {
-    home: genPageTheme(['#123456','#123456'], shapes.wave),
-    documentation: genPageTheme(['#123456','#123456'], shapes.wave2),
-    tool: genPageTheme(['#123456','#123456'], shapes.round),
-    service: genPageTheme(['#123456','#123456'], shapes.wave),
-    website: genPageTheme(['#123456','#123456'], shapes.wave),
-    library: genPageTheme(['#123456','#123456'], shapes.wave),
-    other: genPageTheme(['#123456','#123456'], shapes.wave),
-    app: genPageTheme(['#123456','#123456'], shapes.wave),
-    apis: genPageTheme(['#123456','#123456'], shapes.wave),
+    home: genPageTheme(['#123456', '#123456'], shapes.wave),
+    documentation: genPageTheme(['#123456', '#123456'], shapes.wave2),
+    tool: genPageTheme(['#123456', '#123456'], shapes.round),
+    service: genPageTheme(['#123456', '#123456'], shapes.wave),
+    website: genPageTheme(['#123456', '#123456'], shapes.wave),
+    library: genPageTheme(['#123456', '#123456'], shapes.wave),
+    other: genPageTheme(['#123456', '#123456'], shapes.wave),
+    app: genPageTheme(['#123456', '#123456'], shapes.wave),
+    apis: genPageTheme(['#123456', '#123456'], shapes.wave),
   },
 });

Sounds good to me :)


How do I do read-write separation？

Can you please add more context here?

Are there any examples