Excessive include directives

Problem
It appears that many Makefile.am instances have unnecessary or incorrect include directives.  This meaningfully slows the build.
Proposed Solution
Analyze and remove unnecessary include directives.

Move to GN should have made this obsolete.


Support for EnableFatFlowLogging parameter on Azure Firewall

Resource Provider
Network (NRP)
Description of Feature or Work Requested
Need to add a new parameter named EnableFatFlowLogging to the base command of creating the Firewall.
az network firewall create -g MyResourceGroup -n MyFirewall --enable-fat-flow-logging true
Only parameter needed is:
enable-fat-flow-logging
Default value is false
No NRP/Swagger change needed
Additional context

Powershell PR for reference
https://github.com/Azure/azure-powershell/pull/18992

Original PR : https://github.com/Azure/azure-powershell/pull/18948
Field renames after discussion with PM team:
https://github.com/Azure/azure-powershell/pull/18992

network feature

@jashwanth, we cannot support this feature since the swagger is not ready.

@jashwanth, we cannot support this feature since the swagger is not ready.

It will be sent to backend as an additional property (Network.AdditionalLogs.EnableFatFlowLogging) like it is done in the above PowerShell PR? Do we still need swagger change?
e.g mapping from SDK to PS => {PSFirewallObj}.EnableFatFlowLogging = {SDKFirewallObj}.AdditionalProperties?.SingleOrDefault(kvp => kvp.Key.Equals("Network.AdditionalLogs.EnableFatFlowLogging", StringComparison.OrdinalIgnoreCase)).Value;

@Gizachew-Eshetie, thanks for your explanation, we'll develop it in this sprint.

Thank you @necusjz and @ZengTaoxu . Please let us know if you need more information to get this work done. Also can you please provide the ETA for the changes?

Thank you @necusjz and @ZengTaoxu . Please let us know if you need more information to get this work done. Also can you please provide the ETA for the changes?

Around 09/06/2022.


Shaded JAR does not shade checker or kotlin

While investigations #214 several dependencies are not shaded when they are put into the uber-jar. These include the Checker Framework library and Kotlin. Shading the Checker classes is probably fine, but I have no idea if shading Kotlin will work as expected. Need more research on that one too.

For now, I will shade the org.checkerframework classes but not the Kotlin ones.


Explicitly mention tnozicka on issues

/kind documentation
What this PR does / why we need it:
I won't get email notification otherwise and has been missing some issues lately.
Does this PR introduce a user-facing change?:

NONE

this doesn't need e2e
/override e2e-cluster-wide
/override e2e-single-namespace


[MX-87] Search Results Pagination + other search improvements

https://artsyproduct.atlassian.net/browse/MX-87
Follow up work

[ ] Hide bottom tabs when in navigation stack
[ ] Add tests

I gave up on testing today because I was wrestling with relay mocking again and I want to get this PR up for review before the weekend so we can get this new search out ASAP.
Basic empty screen(no recent searches, so nothing to put here yet) , we can adjust copy later

Input focus interaction

Type to search

Clearing the search field

Scrolling dismisses keyboard

Infinite scroll

(hmm, looking at this maybe we should hide the vertical scroll indicator 🤔)
End of the results reached

Only a couple of results

## No results (let's adjust copy later)

Scrolls back to the top when you start typing again.

Has loading spinner if you manage to get to the bottom before the next batch is loaded

Deleting recent searches

#skip_new_tests

Ah, just read your note. I'll get this merged and we can release a beta with the changes 🎉

:rocket: PR was released in v1.19.7 :rocket:


MODELIX-777 model-server 4.10.0 does not return any data in ModelQl queries

Otherwise, properties of built-in languages cannot be looked up via ModelQl as the role IDs retranslated into the role name during query execution.
Fixes MODELIX-777, got the ticket number wrong in the Git branch.

:tada: This PR is included in version 4.11.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix Android crash on text string in Button component

Closes #238 and removes TranslatedText component, replacing it with a styled Text component

Still confused. Can you link to a line in the main branch where that lint rule is causing a problem?

My understanding is that any lines like these, where we pass in text="Explore" rather than text={t( "Explore" )} can't be picked up by the linter.
I was removing it specifically because I remember getting feedback in an early PR that using TranslatedText was more convoluted and made the text harder to read than using a regular Text component, so it's been on my personal backlog for a while. Not attached to removing it though.

Weird, for me eslint does not have a problem with that line, so if I ever gave you feedback about that being a problem, I apologize because I don't think it is. I can think of a few other potential problems there (e.g. it makes it harder for tools that automatically extract translations or detect unused translations to do their job), but not the linter.

Well, whichever way we go, I like the idea of us having only one type of Text component throughout the app, and right now we have many -- there's TranslatedText, and we're also importing Text from react-native, react-native-paper, and components/styledComponents in various places.


What is This

Traceback (most recent call last):
File "fsociety.py", line 34, in
import requests
ImportError: No module named requests

Can You tell me what os you are using
ps:Use python mobil.py

Using Ubuntu

Use mobil.py if they Don't Work Tell Me
Thnx For Using Fsociety :+1:

To Fix this proplem:
pip install requests
OR use mobil.py

thanks it worked


[YUNIKORN-2398] Refactor event system mock

What is this PR for?
Move the event system mock into its own package under the events package.
Move the node iterator creation function for tests to the utilities file of the scheduler objects tests
What type of PR is it?

[X] - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2398

How should this be tested?
Update unit tests included. No difference in coverage

@wilfred-s Can you rebase?

I rebased the changes because I need this for YUNIKORN-2116.


2.1.2 build fails (OS X Mavericks 10.9.4)

Using the latest version of ruby-build, I'm not able to install 2.1.2:
Downloading ruby-2.1.2.tar.gz...
->     http://dqw8nmjcqpjn7.cloudfront.net/f22a6447811a81f3c808d1c2a5ce3b5f5f0955c68c9a749182feb425589e6635
Installing ruby-2.1.2...
BUILD FAILED
Inspect or clean up the working tree at /var/folders/v8/8p6rvd8j2657xn8js03nl4t40000gn/T/ruby-build.20140806153344.78015
Results logged to /var/folders/v8/8p6rvd8j2657xn8js03nl4t40000gn/T/ruby-build.20140806153344.78015.log
Last 10 log lines:
file.c:5493: error: expected declaration specifiers before ‘VALUE’
file.c:5550: error: expected declaration specifiers or ‘...’ before ‘VALUE’
file.c:5551: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘attribute’ before ‘{’ token
file.c:5556: error: storage class specified for parameter ‘null_device’
file.c:5556: error: parameter ‘null_device’ is initialized
file.c:5604: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘attribute’ before ‘{’ token
file.c:5844: error: old-style parameter declarations in prototyped function definition
file.c:5844: error: expected ‘{’ at end of input
make: *** [file.o] Error 1
make: *** Waiting for unfinished jobs....
which -a gcc-4.2 outputs /usr/bin/gcc-4.2
Already tried:
brew install ruby-build
brew update
brew install openssl
Latest version of xcode is installed as well. Unfortunately, a fresh install of my dev environment is not an option =/
Any idea how to fix this? Thanks!

@aagarwal92 If you still have this problem, Please reopen this and feedback result of @mislav 's instruction.


Update contributor guide with Windows-specific instructions

"Configure Git for contributing" section does not mention where to configure git in Windows.

+writing +beginner

#dibs

+exp/beginner +kind/writing

@xamyzhao Huge thank you.

Contributed in PR #11781


Unable to get RockPaperShotgun to work

Hi There,
I'm using the below block, and url, however it still shows the footer & sidebar. Can anyone help properly filter these out please?
Thanks!
config:
{
"type": "xpath",
"xpath": "div[@id='content']/div[@class='content']/div[contains(@class, 'block')]",
"cleanup": [
"div[@id='header']/div[@class='header-content']",
"div[@class='header-items']",
"div[@id='footer']",
"ul[@id='sidebar']"
]
}
test url:
http://www.rockpapershotgun.com/2016/01/04/smite-world-championship-2016-everything-you-need-to-know/

Seems to me you are attempting to grab to much and then scrub it clean. I always prefer to do a little more targeted xpath and then the minimal amount of cleanup. Firefox's inspect element is a great way to fine the class name of content you actually want.
{
    "type": "xpath",
    "xpath": "div[@class='post-inner']",
    "cleanup": [
        "nav"
    ]
}

excellent, thank you!


Update Fixed Improper Input Validation improperly handles

Improper Input Validation due to the improper handling of URLs by the url.parse() function. When new URL() throws an error, it can be manipulated to misinterpret the hostname. An attacker could exploit this weakness to redirect traffic to a malicious site, potentially leading to information disclosure, phishing attacks, or other security breaches.

Hello @imhunterand you only changed the yarn.lock here

it is duplicated with https://github.com/Consensys/starknet-snap/pull/192


Replace Invoke-ActivityFunction with Invoke-DurableFunction

Invoke-ActivityFunction has been renamed to Invoke-DurableFunction. The old name still works because of a backward-compatibility alias, but mentioning the old name in the docs creates confuses customers.

Learn Build status updates of commit 91a4e38:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-functions/durable/quickstart-powershell-vscode.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@anthonychu,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

cc @lilyjma @davidmrdavid

cc @lilyjma @davidmrdavid

(for some reason I don't see my other comment...)
Start-NewOrchestration and New-OrchestrationCheckStatusResponse in Http client function has been replaced by Start-DurableOrchestration and New-DurableOrchestrationCheckStatusResponse, respectively in the templates.

@lilyjma Oh no, sorry about the confusion: the PR title and description are incorrect, Invoke-DurableActivity is the correct name, and this is what the proposed change actually has. I'll fix the title and the description.

Start-NewOrchestration and New-OrchestrationCheckStatusResponse in Http client function have been replaced by Start-DurableOrchestration and New-DurableOrchestrationCheckStatusResponse, respectively, in the templates as well.

@lilyjma Good catch, thank you, updated these as well.

Learn Build status updates of commit aa103aa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/active-directory/develop/tutorial-v2-nodejs-desktop.md
:warning:Warning

Details

articles/azure-functions/durable/quickstart-powershell-vscode.md
:white_check_mark:Succeeded

articles/active-directory/develop/tutorial-v2-nodejs-desktop.md

Line 83, Column 5: [Warning: invalid-code] The code snippet "~/ms-identity-JavaScript-nodejs-desktop/App/UIManager.js" could not be found.
Line 87, Column 5: [Warning: invalid-code] The code snippet "~/ms-identity-JavaScript-nodejs-desktop/App/CustomProtocolListener.js" could not be found.
Line 125, Column 1: [Warning: invalid-code] The code snippet "~/ms-identity-JavaScript-nodejs-desktop/App/fetch.js" could not be found.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@AnatoliB Can you make this PR against the internal docs repo? You'll be able to sign off yourself once it's ready. Also feel free to change the author on this doc. 😄

hi @AnatoliB - as @anthonychu  mentioned, you should work in the private repo instead. thanks.

Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.


List commands should return correct error message in case of  excess data

🐞 Bug Report
Affected Command
List commands should return correct error message in case of  excess data
./edgex-cli readings list

 The issue is located in:
Is this a regression?
No
Happens when too many readings and events in a system.

 Yes, the previous version in which this bug was not present was: ....
Description and Minimal Reproduction
🔥 Exception or Error

🌍  Your Environment
Deployment Environment:
EdgeX Version:
Anything else relevant?

Already fix by @mkbhanda in PR https://github.com/edgexfoundry-holding/edgex-cli/pull/165


Fixes #100 - omit issues with pr linked to it

added -linked:pr to query to find open issues with no pr's linked to it

unclear on how to write a jest test for this at the moment

It looks like we don't currently have any tests for gitHubIssueFetcher.ts.
For this specific change, I think the test we would want would be to catch the call to graphqlWithAuth (via mocks), and examine the variables.queryString that got passed.
We should probably create tests for this file at some point, but this change is small enough and easy enough to test manually that I don't think it's worth creating tests as part of this ticket.


zstd-sys: impl wasm32-unknown-unknown support

This PR adds a simple wasm shim to zstd-sys to support wasm32-unknown-unknown arch.
The legacy and dict_builder cannot be compiled on this shim because they depend on stdio.h, so I added a new feature cfg to turning off dict_builder code.
You can test it with wasmtime
> cd zstd-safe/zstd-sys/
> cargo build --target wasm32-unknown-unknown --no-default-features --example it_work
> wasmtime target/wasm32-unknown-unknown/debug/examples/it_work.wasm --invoke test_compress

Hi, and thanks for the work!
I think without dictBuilder, the functions from zdict don't have a definition anymore, and should not be used.
This means that the bindings file needs to depend on this. In practice, the zstd.h file used to generate the bindings should not include zdict.h when the dict builder feature is not enabled.
Rather than adding yet another dimension to the selection of the bindings file, we could split this bindings into the main zstd part and the dict part, and include each file conditionally. I pushed something like that to the bindings_split branch if you want to have a look.
If it looks fine, I'll merge the split, and rebase this PR to not include the zdict bindings without the feature.

Yes, it would be nice to split them. Thanks for your quick work.

Looking good! One last thing: we'll want to add dict_builder features to the zstd-safe and zstd crates, and forward it downstream.
We'll also want to conditionally hide the relevant types in these crates depending on this feature.

Thanks again for the work!


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
19 seconds
sanity-inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
34 seconds
sanity-label-check

✅ Succeeded
58 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
show-summary


php:8.2-fpm-dev php--fpm entrypoint is broken, wrong directory

Which image/versions are related to this issue/feature request?
Hello I'm trying to use cgr.dev/chainguard/php:8.2-fpm-dev but the entrypoint is calling a wrong directory.
When I run
docker run --rm cgr.dev/chainguard/php:8.2-fpm-dev

I got this error

Reproduce
When I exec to the docker container by name
docker exec -it ecstatic_beaver /bin/sh

then do ls -l inside the /usr/bin folder there is no file or folder named php-fpm.

The why the container starts with an endless loop
execlineb: fatal: unable to exec /usr/bin/php-fpm: No such file or directory.
Also when I exec to the container then do
/usr/sbin/php-fpm

I got php-fpm running and ready to handle connection.

Need to fixed
the entrypoint of php-fpm is on /usr/sbin/php-fpm and not on /usr/bin/php-fpm
Please can you fix we need this asap.
Thank youi
Issue/Feature description
No response

Hi @melakhvision thanks for the issue.  Indeed I've recreated the error and will fix.

Hi @rawlingsj Thank you.
Hope we can get a fix asap
And can you add please mongo php extension and enable it
Thank for your effort

Hello @melakhvision !
We are working on a fix to the image, it should be available after the next build cycle tonight. In the meanwhile, you may overwrite the image's entry point to /usr/sbin/php-fpm.
In this repository you can find a working example of a LEMP setup using Docker Compose.
In regards to the Mongo extension, this is currently out of scope for our base PHP images. A possible solution is to use the php:latest-fpm-dev image and include additional apks to build this extension if it's a requirement for your application.

Sorry I don't get for mongo php extension.
Can you explain or give an example ?

Update: the php-fpm image has been updated and the reported issue is now fixed.
About the mongo extension, this package is not available in Wolfi OS, but you can build it from source in a Dockerfile using the php:latest-fpm image as base, which will allow you to install additional packages needed for building PHP extensions. It is not in our roadmap right now to include the mongo extension in our PHP images.
If you think this package should be included in Wolfi OS, I would advise you to open an issue in the Wolfi OS repository.

thanks @erikaheidi and @melakhvision - closing the issue.

I see that the path of the entrypoint has been fixed.
Thank you
Can you please add the pecl php extension. It makes easy for us to add extension like mongo php and so. I try to build it from the Dockerfile and no way to get because some packages missing like musl-dev and so.
You tell above that it can't be added but not clear

@erikaheidi can you help and be more clear ?

Hello again @melakhvision, sorry I missed your last comment. We need to evaluate this request at the Wolfi repository, because that's the main source of our packages. We have a template there for package requests, so that the whole team sees it and we can talk about it / prioritize if that's the case. You can use this direct link to create a new issue of type Package Request. You can ping me in here with the link once you have created it, so that I can highlight it to the team.


Containers provider is always added with port '8443', even if a different port was specified

When adding a containers provider to manageiq it is required to specify a port.
The default port, used for the "default" endpoint, is defined in container_manager_mixin.rb as 8443.
This default number is always used, even if a different port was specified.

@miq-bot add_label bug, providers/containers

@simon3z @yaacov

@dkorn @yaacov can you help @nimrodshn to fix this? Thanks.
@miq-bot assign nimrodshn

@chessbyte can you add @nimrodshn to the organization (for miq-bot). Thanks.

@simon3z already fixed here https://github.com/ManageIQ/manageiq/pull/11391, sorry @nimrodshn :flushed:

@miq-bot assign dkorn


things

:white_check_mark: Build TimeHACK 1.0.19 completed (commit https://github.com/TimeHACKDevs/TimeHACK/commit/1431e27701 by @lempamo)


Fallback between Rss Feed and Atom Feed parser

We should be able to "fallback" on the other parser or identify if a feed is of a certain type or not.

@MaximRouiller
Are you expecting a use case where the type of feed being parsed is not already known?

That seems more like application level logic than API requirement. The common layer is the syndication interfaces. Here are my thoughts:

Factorization of particular interface implementation limits flexibility, especially in low level API.
Our goal is to offer extensible API. Devs can plug, replace or extend at different levels - reader/parser, writer/formatter because feeds can vary.
RSS and Atom handling just happens to be in the same library, but these implementations are completely separated.
Syndication formats are not limited to RSS and Atom only - ex: JSON Feed. These are likely to be in separate libraries and won't know about each other.
There are embedded feeds - for instance RSS feed with Atom elements.

Would it be possible to do feed type detection?
Because right now, I have to do the control flow with try/catch. If based on a feedUrl, we could determine that it's RSS 2.0 or Atom 1.0, it would let me pick the right parser. No idea if we can do read ahead or TryRead() ... I don't want to force the API a certain way.
What I have right now is more Exception based control flow while I would prefer to have Feed Type detection to avoid exceptions altogether.
Thank you so much for the fast responses.

SyndicationFeed.ReaderWriter doesn't distinguish where the content comes from (http, file, memory,  etc.). It operates over a valid XmlReader/XmlWriter instance.
Saying that, a well-formatted HTTP Syndication Feed response should represents with a proper Content-Type response header - it's a proper identification for any response type indeed.
Atom feed:
Content-Type: application/atom+xml
(more info)
Rss feed:
Content-Type: application/rss+xml
(more info)


android studio- VSTS fails to connect while using organizational network

We are using android studio and the Microsoft managed VSTS Plugin to connect. This works fine when on an open internet connection however when connecting via out work proxy we are unable to connect. We can still access VSTS via a browser even through the proxy. Just the connect through the plugin does not work.
Our organisation uses ADFS authentication.
We have tried the following to no avail:

We tried adding proxy settings in Android studio as in system default proxy settings
we have tried adding ADFS SSL certificates to java JVM

Steps we followed in android studio.

changed proxy settings in android studio

VCS->Import into version control->Import into team services Git..->on team services tab ->sign in
when we enter organizayional user id it takes me to the organizational sign in page successfully.

it gives message like plugin error uncaught authorization exception

Everything works fine when we use open network.

Hi @apsuch-cont,
Sorry you're having trouble. Thanks for reporting it. Would you be able to send me a log of the error please? It should help me to see where we are going wrong. Follow the last FAQ at this link for how to get the log: http://java.visualstudio.com/Docs/tools/androidstudio#_frequently-asked-questions-faq
If you don't want to post the log here, feel free to email it to me directly at<EMAIL_ADDRESS>Thanks again,
-Leah

Hi!
The same problem even on open network on a new version.
Version: 1.113.0
After login to TFS no matter if it is Import to TFSC Git/TFSC Preview or checking out from TFSC we get a same RuntimeExc in Android Studio:
17:38:56 Plugin Error: Visual Studio Team Services threw an uncaught RuntimeException. Disable Plugin
17:38:56 RuntimeException: getAuthenticationInfoAsync failed: Could not find any accounts.

Hi Leah,
I have shared the log on mail please suggest.

I'm taking a look at this now. Thanks for sharing the logs. I'll let you know what I find as soon as I can. I apologize for the inconvenience.
Thanks again,
-Leah

The "Could not find any accounts" was caused by a server side bug that is now fixed. If you try to authenticate now, you should be able to do so without issue. I'm closing this issue as resolved since I've had verification from @apsuch-cont that it worked.
@b0rke5 if you are still seeing issues please feel free to reopen this.


Hi @nightwolfz , can you try it with an initial size such as m := haxmap.New[int, string](1 << 12) ?

@nightwolfz yes rapid map growth via Set() creates a lot of grow() goroutines which causes choking and as you said using runtime.Gosched() frees up the CPU hence more time for the growth.
One of haxmap's future goals is a better growth policy which wont choke and hence there is lots more room for improvement

If this is by design, it might be worth mentioning in the README.
Yes, I will mention it

Also the current workaround for this behaviour would be initializing the map with a good size which will cause lesser grow operations and wont choke

Yes, this sounds plausible, if possible can you checkout a branch with these changes ? It would be much easier for both of us to test that way.

@nightwolfz I have updated the main branch with this https://github.com/alphadose/haxmap/commit/d071dd5f749f86017a32bc126ea40eaade5f3dfc
With this commit growth happens synchronously and my benchmarks and tests are passing as well
can you run your tests once again and tell me the results ?


spec: session_id is clearer than UUID

the behavior previously described as UUID is really a session ID.
For implementations with existing behavior this is a nop, but going
forward the header Blob-Upload-Session-ID is more clear than
Docker-Upload-UUID.
Fixes #13
Signed-off-by: Vincent Batts<EMAIL_ADDRESS>

LGTM
Would it make sense to also prefix any headers with X-? e.g. X-Blob-Upload-Session-ID

Would it make sense to also prefix any headers with X-?

Someone recently informed me this practice is deprecated: https://tools.ietf.org/html/rfc6648.html

Would it make sense to also prefix any headers with X-?

Someone recently informed me this practice is deprecated: https://tools.ietf.org/html/rfc6648.html

that's what i thought too, but you found it first

@jonjohnsonjr thought on this PR? You had GCR thoughts on #13

LGTM, this part covers the behavior we expect from clients:

Though the URI format (/v2/<name>/blobs/uploads/<session_id>) for the Location header is specified, clients SHOULD treat it as an opaque url and SHOULD never try to assemble it.

cool cool

@jonjohnsonjr @vbatts oh nice! I'm super late to seeing that RFC.


Merge main WSL guide updates with prework guide?

I'll be updating the hosted version of the WSL guide over the next month. Some of that includes adding a checklist to the main page ( thanks for the idea @johncokos) as well as some simplifications, clarifications, and updates to things like how npm global and local paths work with WSL, and merging any changes from this prework version into the main version as appropriate so they are consistent.
I wanted to get some feedback though to see if there are things we would like removed or added into it. If there are any areas that you've seen students struggle with too I'd like to try and address it all in one go. I'm also curious about how students in other courses such as .NET, Java, and Python are doing with this guide, or if they are even using it at all.
Thanks!

I'll endeavor to get our folks to read over these materials and cross-reference against what we have in place. In particular, @mnfmnfm could provide excellent insight and review at such a time she has bandwidth to do so. But she is early in a Java 401 at the moment, so we'll see.

We're using this guide in Java! Agreed that npm pathing issues are the biggest pain point right now. For Java we've got a couple of other one-off aliases set up, but nothing major that needs to be reconfigured.

Awesome, I'm glad to hear it's able to be used in other 401's.
I know NPM is a bit of an issue, so I'll create a separate issue and share my current solution for it now instead of waiting until an update is ready. Please let me know if there are other issues with NPM that this doesn't cover! Thanks :)

Hey @michaeltreat any updates on this?

@mnfmnfm The version I'm hosting is about 70% complete, but Microsoft just released WSL 2.0, so I will need to review that and update the guide again. I am finally getting into the groove here at work so I'm able to start picking up my side projects again. I will try and get a 1st draft update of this over the next month!


The use of webpack's splitChunks feature causes ExtractTextPlugin to not output css properly

webpack: ^4.1.1
extract-text-webpack-plugin: ^4.0.0-beta.0
My webpack config
// ...
optimization: {
        splitChunks: {
            cacheGroups: {
                commons: {
                    // test: /[\\/]node_modules[\\/]/,
                    name: 'react',
                    chunks: 'all'
                }
            }
        }
    },
plugins: [
     ...htmls,
    new ExtractTextPlugin('style/[name].[chunkhash:8].css')
]

If I do not use splitChunks independent react then outpu
index.css
home.css

Output after use
react.css

I want to know why this is so, I can't find explanation about this on the internet.

I have the same problem with set options allChunk: true

new ExtractTextPlugin('style/[name].[chunkhash:8].css', {
    allChunks: true
})

@Shafley
Thanks, but this property has no effect

@fixterer  I mean if I set allChunks: true, ExtractTextPlugin  just split  css from my .less files,  and lost css from antd-design, if I set allChunks: false, the css from antd-design are injected into html with style tag

Please don't use extract-text-webpack-plugin for extract css for webpack@4, use https://github.com/webpack-contrib/mini-css-extract-plugin, in near future we will update README. Thanks!


Configure Rust nodes to support Elixir ports

Elixir Ockam nodes sometimes use Rust nodes to fill the gaps in the implementation. For example Identity and Credential Verifier services are delegated to Rust nodes.
Currently this means that there should be TCP-accessible Rust node deployed next to the Elixir node and there needs to be some orchestration to manage them. This if fairly simple if Elixir nodes are deployed with orchestration (like k8s), but makes it more challenging to do more portable deployments.
Elixir has Ports as a tool to integrate with external programs. This tool allows to start external programs from Elixir code and also lets Elixir processes to link with them, so they can be a part of the supervision trees.
We can start a Rust node from the Port, but currently when Port terminates the Rust node does not. This is because termination of the Port is communicated to external program by sending it the EOF.
The idea behind Ports is that they communicate with Elixir on STDIN and STDOUT.
If we could have an argument we can add to the Rust node creation so it will monitor STDIN and terminate on EOF it should be easy enough to integrate Rust "sidecar" nodes as a part of Elixir nodes, simplifying deployment.
Another thing we can do is to add a STDIN/STDOUT transport protocol to leverage the Ports even more.

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels -  https://github.com/build-trust/ockam/labels/good first issue or https://github.com/build-trust/ockam/labels/help wanted

I think the first step would be to add an argument to the node create command to make it listen on STDIN and terminate after receiving EOF, this argument should be probably somehow related to the foreground argument since it doesn't make much sense for background nodes.

hey @hairyhum is this a rust only issue? if so, I would like to work on this

@phillyphil91 yes the following part is Rust only:

I think the first step would be to add an argument to the node create command to make it listen on STDIN and terminate after receiving EOF, this argument should be probably somehow related to the foreground argument since it doesn't make much sense for background nodes.

I think the simple solution is when ockam node create --foreground then start reading from on STDIN and stop the node if EOF is received. We may not need an additional argument.

thanks @mrinalwadhwa that sounds doable. let me have a look :smile:


⚠ Bofrost.at has degraded performance

In 0169975, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 935 ms

Resolved: Bofrost.at performance has improved in 5f2b4b5.


feat: YoloChart in repo pages

Description
Implements the YoloChart in repo pages to show YOLO coders, contributors that push commits directly on the "main" branch.

Related Tickets & Documents
Closes #3644
Closes #3584

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

[ ] Tier 1
[x] Tier 2
[ ] Tier 3
[ ] Tier 4

[optional] What gif best describes this PR or how it makes you feel?

This is really cool to see live. I notice a lot more projects than expected have a link to YOLOs.
I.e. Facebook/react

We might to do a similar maintainer QA in the slack channel to get feedback on this.
Also, the link to why this would be a problem goes to the docs. Is there a docs issues for that?

@zeucapua I have the docs up for it, so as soon as it's reviewed, you can link to them.
https://github.com/open-sauced/docs/pull/348

The pill is a little stretched when expanding the screen

This is probably an api side issue, but if we could remove bots from the response that'd be amazing.

This is worth having a quick discussion on:
I believe it would be interesting for maintainers to see what bot are pushing directly to main, partially because bots (like in your example the k8s prow bot or the k8s test infra bot) make up a HUGE part of a project's secure software supply chain. I.e., bots (and the software they consume) are just another piece of the ever expanding puzzle that makes up building and shipping secure software.
Bots committing directly to main are a common practice (generally safer than a maintainer sending something directly to main and are useful in release processes) but can still be compromised: compromised in sometimes extremely catostrophic ways. The SolarWinds attack and data breach was as bad as it was because hacked build system dependencies (like bots or other pieces of build automation) went unnoticed for so long, malicious third party actors were able to inject back doors into many of their products. Then resulting in all their customers becoming compromised.
We can remove bot commits API side for this early iteration. But I'd be more supportive of a long term option that makes it on/off optional. Or we think over / design another piece of this component that incorporates bot commits directly to main.

This is probably an api side issue, but if we could remove bots from the response that'd be amazing.

This is worth having a quick discussion on:
I believe it would be interesting for maintainers to see what bot are pushing directly to main, partially because bots (like in your example the k8s prow bot or the k8s test infra bot) make up a HUGE part of a project's secure software supply chain. I.e., bots (and the software they consume) are just another piece of the ever expanding puzzle that makes up building and shipping secure software.
Bots committing directly to main are a common practice (generally safer than a maintainer sending something directly to main and are useful in release processes) but can still be compromised: compromised in sometimes extremely catostrophic ways. The SolarWinds attack and data breach was as bad as it was because hacked build system dependencies (like bots or other pieces of build automation) went unnoticed for so long, malicious third party actors were able to inject back doors into many of their products. Then resulting in all their customers becoming compromised.
We can remove bot commits API side for this early iteration. But I'd be more supportive of a long term option that makes it on/off optional. Or we think over / design another piece of this component that incorporates bot commits directly to main.

I think a toggle for this is a good idea.

@zeucapua for the bots toggle, here's two ideas:
I prefer the one on the right, but understand the one on the left is possibly easier to implement responsively

YOLO Banner breakpoint designs implemented cc @isabensusan
https://github.com/open-sauced/app/assets/20603494/a74aaae6-208c-45a5-b88b-23e78725b12b

FYI, quickly worth calling out, the bots toggle won't work for accounts that don't end in [bot]. So, the kubernetes bot accounts won't get filtered. I've opened this issue to explore a "well known bot account" service of some kind to start solving for this: https://github.com/open-sauced/api/issues/929

Banner should be fixed for the macbook 13 size cc @isabensusan
https://github.com/open-sauced/app/assets/20603494/ac0d375b-419f-4070-95bc-4289c2aa08a0


Corrected link to the service fabric code samples

@dougperkes,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@vturecek Please review these proposed changes. Thanks.

#sign-off


Fix missing const variable declarations

These implicit global declarations were causing a ReferenceError in my project (not sure when the runtime changed!)

Thanks for the improvement! I merged your pull request and updated the version to 1.1.0. :)


Decoupled front end

project.apiUrl or some other key should allow the server to be hosted into another host away from the client. This might clash with the implementation of project.cdn that allows the assets to be hosted elsewhere.
The difference is that in this case we want to completely skip SSR.
When building, an index.html that points to the client should be generated.
The Virtual Pipeline should be empty before the rendering cycle.
The project should be able to run on both SSR mode and this new mode at the same time, but the HTML file should be served  by the user to simulate a decoupled server.
This is the first step towards Nullstack Native.

Released with 0.11.0


Add export for types in apexcharts.d.ts

Can you add export for types in file apexcharts.d.ts, we can trying add custom locale for global component in vue, but we cant import ApexChart.
https://github.com/apexcharts/apexcharts.js/blob/main/types/apexcharts.d.ts
Yes, i see this PR https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28733, but it was closed, not merge ;(

I'd just like to request that we also export ApexDropShadow (or heck, just export all the types). I'm getting this error when using ng-apexcharts:
✖ Compiling with Angular sources in Ivy partial compilation mode.
error TS4041: Return type of public getter 'plotOptions' from exported class has or is using name 'ApexDropShadow' from external module "node_modules/ng-apexcharts/lib/model/apex-types" but cannot be named.


Fix lint warnings

After #892 is merged, we see many warnings in the lint build. It would be nice if we can exclude or fix them.
The current lint logs looks very noisy and taking care of a new lint issue can be a daunting task in the future, especially for the new contributors.
Screenshot:

Link: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-js/3706/workflows/82bf0bf2-c125-4663-a3b7-2396167d09cd/jobs/20435/parallel-runs/0/steps/0-105
/cc @OlivierAlbertini

I see that most of them aren't really fixable (like use of any or not using all parameters when implementing interfaces). Is it okay to just make eslint to ignore certain rules on those parts of the code?

I see that most of them aren't really fixable (like use of any or not using all parameters when implementing interfaces). Is it okay to just make eslint to ignore certain rules on those parts of the code?

Sounds reasonable to me. @dyladan WDYT?

I think that's fine in many cases. A lot of these rules have configs that allow you to ignore cases where the linting rules commonly fail also so that might be worth looking into.

The other option is to use the --silent option when running lint, which ignores warnings. The advantage of this over marking it as ignored is that it will still highlight issues in your editor, which can help you catch common mistakes. Think this might be a case-by-case decision type of task.

We can make eslint ignore specific rules as well. For instance, we can disable no-unused-vars rule like this:
/* eslint-disable @typescript-eslint/no-unused-vars */
... code that violates rule ...
/* eslint-enable @typescript-eslint/no-unused-vars */

This way we can still catch errors using the linter, even in the ignored section.

Regarding unused vars:
Actually, there are a lot of code which mocks real one, like NoopExporter and so one. These params are needed to not break consistency between components,
There could be a convention to omit such parameters, like prefixing them with underscore
https://eslint.org/docs/rules/no-unused-vars#argsignorepattern

have time to fix that

Should this issue remain open if the above prs fixed some lint warnings?
I do see about 65 lint warning (as of today) when I run it in main. Should we consider fixing those or are we accepting those lint warnings?

I think it is still valuable to fix the warnings.

@dyladan 👋🏽 I am curious, will this issue remain forever-opened?
Running the lint script I see no issues/warnings popping up

Lint warnings are not emitted when running with lerna. You can run lerna run --verbose lint to find all the warnings.

Closing in favor of #4258


persistent backend broken in new persistent release 2.5

Stack LTS support is important for the Windows release, so I should likely just pin the cabal persistent version to something that works, but I will need to add support for the persistent Backend reader/writer division within a few months.

We should bump this up in priority. We are falling behind and it is causing package resolution failures in GHC 8.0.2.

The persistent driver was a proof-of-concept and has been retired for now. It could be resurrected, if there is interest.


max returns NaN under specific conditions

Godot version
4.0 092a2861277e7df87aec10516d713d0bf4adba79
System information
Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
I noticed a NaN popped up while I was porting a project to Godot4, and was very confused to find its origin in the following expression:
distance = max(distance - 1 - distance * 0.1, 0)

distance becomes NaN after this.
I tried a simple repro but could not get it to happen.
So I tried a bit more of the original code, and it started happening:
extends Node3D

@export var distance = 0.0

func _unhandled_input(event):
	if event is InputEventMouseButton:
		if event.button_index == MOUSE_BUTTON_WHEEL_UP:
			assert(not is_nan(distance))
			print("A distance before: ", distance)
			distance = max(distance - 1 - distance * 0.1, 0)
			print("A distance after: ", distance)
			assert(not is_nan(distance))

		elif event.button_index == MOUSE_BUTTON_WHEEL_DOWN:
			assert(not is_nan(distance))
			print("B distance before: ", distance)
			distance = max(distance + 1 + distance * 0.1, 0)
			print("B distance before: ", distance)
			assert(not is_nan(distance))

Still, I have no clue why would NaN originate from this.
Steps to reproduce
With the code above, start the game, and wiggle your mouse wheel back and forth. The game will quickly assert.
Minimal reproduction project
Max.zip

It does not happen if the second argument of max is 0.0 instead of 0. I suspect a bad type conversion issue.


Set timeout for cargo kcov to 20 minutes.

Coverage increased (+0.5%) to 82.657% when pulling b164bd27925cf3ed8c303cd4a431e7238623e901 on tdaede:travis_wait into 93151ecc5245430c521deaee3da11fe2c81b5244 on xiph:master.


main_v2 - fby3.5: cl: Fixing warning messages

fby3.5: cl: Fixing warning messages
Summary:

K_WORK_DELAYABLE_DEFINE needs a callback function with the function parameter type of "struct k_work *".
util_spi.c had a missing header that needed to be included as well as an improperly formatted print statement.
Mark card_type_1ou that is currently unused in Yv3.5 CL as unused to silence compiler warnings.
Initialized status in fall through case.

Dependency: #229
Test Plan:

Build code: Pass

close the PR since the codes have been merged


Clean up mobile/library/common/jni/BUILD targets

Signed-off-by: Ryan Hamilton<EMAIL_ADDRESS>
Remove unnecessary copts now that c++17 is the default.
Rename libndk_envoy_jni.jnilib -> libndk_envoy_jni_jnilib to squelch warning
Use ":base_java_jni_lib" instead of "base_java_jni_lib", per standards
Depend on jni_utility_lib in base_java_jni_lib instead of duplicating the srcs

Fixes #24544

Remove unnecessary copts now that c++17 is the default.

Does that apply to the NDK toolchain too? With your branch, if I pass -s to a bazel test command, I see both -std=c++11 and -std=c++17 in the build arguments, which I find puzzling.

That's probably bazel's default + our .bazelrc, so as long as the 17 is later it should be fine

That's probably bazel's default + our .bazelrc, so as long as the 17 is later it should be fine

Yes, the 17 is later.

/assign @jpsim

Thanks for the double-check, @jpsim and thanks for the comments @keith!

I don't see any issues with this from my testing.
While you're here, maybe we can remove this, which appears to have only been needed for Rust, which Lyft doesn't use in Envoy Mobile anymore: https://github.com/envoyproxy/envoy/blob/eeab187b21e540dbe47b83d023b94f4682fb1179/mobile/library/common/jni/BUILD#L80


fix: update message protobuf

Change Summary

Updates the Message protobuf, which fixes unrecognized user data type errors due to the introduction of new location user data type.
Merge Checklist

[x] PR has a Changeset
[x] PR includes documentation if necessary
[x] PR updates the boilerplates if necessary

@davidfurlong added error handling when decoding user data messages and exposed the location data type


Add Notes in helm install

When we use helm to install hwameistor.  It shows:

The user cannot know whether the install is success or fail.
Show we add Notes in helm like bitnami (https://github.com/bitnami/charts/blob/master/bitnami/nginx/templates/NOTES.txt)
Give the use some suggestion to check the install.

Yes, it's a great suggestion.


Min value max value

I added validators for minimum value and maximum value

Codecov Report

Merging #157 into master will decrease coverage by 0.97%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage     100%   99.02%   -0.98%
==========================================
  Files          20       22       +2
  Lines         401      409       +8
==========================================
+ Hits          401      405       +4
- Misses          0        4       +4

Impacted Files
Coverage Δ

src/validators/index.js
100% <100%> (ø)
:arrow_up:

src/validators/maxValue.js
33.33% <33.33%> (ø)

src/validators/minValue.js
33.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae6d32...6e82a50. Read the comment docs.

Sorry, I forgot to specify in the documentation, I just did this

Hi @FelipeBohnertPaetzold, I'd like to merge that. Could you please take a look at the changes i requested? It shouldn't take too long 😉

Hello, I'll do it as soon as possible ^^

@FelipeBohnertPaetzold ping, I would fix that myself but it's in your repository, and I don't want to mask your contribution 😉

is it possible to open a pull request in my repository? To update the branch of this pull request

@FelipeBohnertPaetzold Technically it is, but it's going to be a mess. The small effort to finish it as I requested shouldn't stop you from doing that altogether, you should feel rather encouraged to do so instead.

Okay, I'll do it until tomorrow :)

Sorry I'm late

Thanks for contribution 🎊

     minValue: value => value > new Date('1950-01-01T00:00:00Z').toISOString(),


Add distillery to getting started

Might be good to mention that an official version of releases is coming in 1.9 as well. After that the distillery releases will be more supplemental than required for creating releases.

Good point on the deployment stuff in Elixir 1.9. I'll make a comment. Thanks!


SipMessageStreamDecoder needs to be updated to work with the latest pkts.sip code

I am not sure if there is a plan to update the versioning dependency with pkts-sip lib. If thats done, the example UAS, UAC will need to be updated because of the change in the builder patterns.
SipMessageStreamDecoder needs to be updated to work with the latest pkts.sip code. I put a small workaround in my repo, putting it in here for my own tracking
/**
 *
 */
package io.sipstack.netty.codec.sip;

import io.netty.buffer.ByteBuf;
import io.netty.channel.Channel;
import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.ByteToMessageDecoder;
import io.pkts.packet.sip.impl.*;
import java.net.InetSocketAddress;
import java.util.List;

/**
 * @author jonas
 *
 */
public class SipMessageStreamDecoder extends ByteToMessageDecoder {

    private final Clock clock;

    private SipMessageStreamBuilder builder;

    public SipMessageStreamDecoder(final Clock clock) {
        this.clock = clock;
        reset();
    }

    public SipMessageStreamDecoder() {
        this(new SystemClock());
    }

    @Override
    public boolean isSingleDecode() {
        return true;
    }

    @Override
    protected void decode(final ChannelHandlerContext ctx, final ByteBuf buffer, final List<Object> out)
            throws Exception {
        byte[] bytes = new byte[buffer.readableBytes()];
        buffer.readBytes(bytes);
        builder.process(bytes);
        if (builder.isDone()){
            long arrivalTime = this.clock.getCurrentTimeMillis();
            final Channel channel = ctx.channel();
            final Connection connection = new TcpConnection(channel, (InetSocketAddress) channel.remoteAddress());
            out.add(new DefaultSipMessageEvent(connection, builder.build(), arrivalTime));
            while (builder.hasUnprocessData()){
                if (builder.process()) {
                    out.add(new DefaultSipMessageEvent(connection, builder.build(), arrivalTime));
                    reset();
                }
            }
        }
    }

    private void reset() {
        final SipMessageStreamBuilder.Configuration config = new SipMessageStreamBuilder.DefaultConfiguration();
        this.builder = new SipMessageStreamBuilder(config);
    }

}

I didn't get around understanding concurrency issues with using SipMessageStreamBuilder since I haven't made myself overly familiar with netty & pkts libraries. I am guessing the Buffer library is queue based so that a subsequent call of a decode doesn't pollute the internals of SipMessageStreamBuilder from a previous decode thread. Again haven't fully got grips with the threading architecture too to fully comprehend if there is locking to prevent multiple decodes in a pipeline.

Hey again,
As I mentioned in my other reply, I haven't found any time to work on stipstack.io in quite some time and not sure when I'll have time again. As far as the threading goes, this has to do with how Netty is functioning and the SipMessageStreamDecoder is one per channel pipeline, which is guaranteed to only be used by a single thread. Netty doesn't have great documentation but there are some info regarding that on their site (or if I found it elsewhere - or just step debuged at some point, dont remember!)

Thanks Jonas
On Sat, Nov 24, 2018 at 4:05 PM Jonas Borjesson<EMAIL_ADDRESS>wrote:

Hey again,
As I mentioned in my other reply, I haven't found any time to work on
stipstack.io in quite some time and not sure when I'll have time again.
As far as the threading goes, this has to do with how Netty is functioning
and the SipMessageStreamDecoder is one per channel pipeline, which is
guaranteed to only be used by a single thread. Netty doesn't have great
documentation but there are some info regarding that on their site (or if I
found it elsewhere - or just step debuged at some point, dont remember!)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aboutsip/sipstack/issues/5#issuecomment-441377692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACn4mmBpRfyLzh7BBn5iaQrYsdO9DysGks5uyW42gaJpZM4YrWo6
.


Tokenview scrollview issue.

Select same entries from list and type 'com'. Hit backspace to remove characters. When last char('c') is removed, scrollview doesn't retain its position.

Sorry for delay, but haven't been able to maintain this library for some time now. If you are willing to make the fix and create a Pull Request, I will happily review and merge in.
Cheers! 🍻


Redis read_write_timeout

Increases to 90 seconds. Predis is abandoned and we should keep an eye out for alternatives that Laravel supports (PHPRedis potentially).

:tada: This PR is included in version 5.8.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


archive focused parallel query tests

The recent work in #1650 and #1635 highlighted a need for more tests that exercise parallel queries against real archives. We can also use this time to restructure the initial parallel analysis code if that's helpful, as we've implemented considerable changes in merge, groupby, etc. since it first went in.

brimsec/rug#189, brimsec/rug#190, brimsec/rug#191, and brimsec/rug#192 update the old boom correctness tests for zqd.


Validation is wrong

Even your test return false, to otherwise valid iban. I'm looking for light version of iban validator, can you maybe fix it :)
runkit
var miniban = require("miniban")
var iban = miniban.isValidIBAN("AL47212110090000000235698741");  //false

Thanks for doing this issue. I'm happy to take on any PRs 🍀


Publisher connecting as a subscriber without video

Bug Report
When connected from ios( ionic 3, cordova-ios 4.5.5,  iphone 6, ios  12.1.2, Cordova Plugin for OpenTok 3.4.4
Current behavior

When you open the playground, Publisher comes under subscribers, but with no audio or video (Just like if a user with subscriber role).

Iphone 6 after clicking start call(Don't mind the white screen. Laptop camera has a tape over it)

How playground shows the iphone stream

Steps to reproduce

Connect as a publisher (valid session id and publisher token)
this.publisher = OT.initPublisher('publisher-div');
this.session.publish(this.publisher);

Example Project

(If possible, please create an example project here on GitHub.com that exhibits the problematic behaviour, and link to it here in the bug report)

https://github.com/opentok/opentok-ionic-samples
What is the current bug behavior?

When you open the playground, Publisher comes under subscribers, but with no audio or video (Just like if a user with subscriber role).

What is the expected correct behavior?

Should come under subscriber with audio and video(Has given the needed permissions)

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's very hard to read otherwise.)

Did you figure out any workaround? I've ran into this exact same problem

@hash-bud Can you please share some more code on how you're running this? Are you seeing an error when you initialize the publisher? Are you calling publish after the session has connected or before?

@msach22 I'm having the same issue, I'm running the Basic Video Example that is provided.
When I try to join a session in the playground, it joins but as a subscriber without video and audio.
The weird thing is that iOS prompt for camera access and shows video in the app, but is not publishing to the session.
The code is the same as the example:
startCall() {
    this.session = OT.initSession(this.apiKey, this.sessionId);

    this.session.on({
      streamCreated: (event) => {
        this.session.subscribe(event.stream, 'subscriber');
        OT.updateViews();
      },
      streamDestroyed: (event) => {
        console.log(`Stream ${event.stream.name} ended because ${event.reason}`);
        OT.updateViews();
      }
    });

    this.session.connect(this.token, () => {
      this.publisher = OT.initPublisher('publisher');
      this.session.publish(this.publisher);
    });
  }

I would appreciate your help! Thank you!

@hash-bud Thanks for sharing the code. I think the following comment should fix your issue. Please see:
https://github.com/opentok/cordova-plugin-opentok/issues/138#issuecomment-466090152

I've updated the Ionic samples with the best practices. Please let me know if you have any questions!
https://github.com/opentok/opentok-ionic-samples/pull/33


MRG: More informative error message when CTF date can't be parsed.

This PR should close #2859. A likely reason why a date can't be parsed is because the users locale might be wrong. Error message now shows hot to set the locale to en_US. I guess en_US is the default for CTF acquisition systems.

merged by rebase after the pep8 fix.
thx @nwilming


fix 2gp beta tags

Changes

The github_release task now has an is_beta option which indicates whether the release is associated with a beta package version.

Issues Closed

Fixed a bug where beta tags created for 2GP packages were not receiving the proper tag prefix.

Should I just make the option required outright? As is, the option is required for a production release (which I don't think is necessarily bad as a precaution). Would the option be better if it were named is_production instead?

Went with an alternate solution: https://github.com/SFDO-Tooling/CumulusCI/pull/2642


Update across-how-to-archive-documents.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav-app/across-how-to-archive-documents.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav-app/across-how-to-archive-documents.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add CACHE_DIR back for CPU

CACHE_DIR on CPU was disabled in https://github.com/huggingface/optimum-intel/pull/164
I don't see the issue anymore in the 2023.0.0.dev20230217 prerelease, which is the current minimum OpenVINO version in setup.py, so we can enable CACHE_DIR for CPU again.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Used URI Component in the mail sent to the user

Used encodeURIComponent instead of replace function #927

Current coverage is 34.08% (diff: 100%)

Merging #937 into development will not change coverage

@@           development       #937   diff @@
=============================================
  Files                7          7
  Lines             1021       1021
  Methods            131        131
  Messages             0          0
  Branches           157        157
=============================================
  Hits               348        348
  Misses             673        673
  Partials             0          0

Powered by Codecov. Last update 68adb9a...c2bde6e

@fatimarafiqui Thanks for joining up.
It seems though like this issue is already resolved. Can you confirm, please?

@fatimarafiqui Thanks for joining up.
It seems though like this issue is already resolved. Can you confirm, please?

Formerly the issue was resolved using replace function for just replacing all “%20” with a space in the URI. My solution makes use of the encodeURIComponent() function that encodes the given string. This function encodes special characters. In addition, it encodes the following characters as well: , / ? : @ & = + $ #. So in a way, It would be a permanent fix to all possible cases we may encounter in future.

Oh nice. Yeah!
Thanks a lot. Merging it.


Run as Windows Service: spawn detached

If the application runs as windows service, use options = { cliOptions: { detached:true}} to avoid error: SetProcessDpiAwareness failed: "COM error 0x80070005  (Unknown error 0x0ffffffff80070005)"
Related Issues: #179 , #251 , #267
Tested on: Windows 10 64, with NSSM service

Is there anyway we could get this one merged? Setting detached = true on Windows Server 2012 solved this issue.

I've tested this locally and on several different servers, windows server 2012 R2 and it works. Have had to fork in order to apply this PR as it was needed in a hurry, but would like to ditch my fork once this is merged.

You can try to pass detached option in your config object.
Because the exec method at node_modules/html-pdf/lib/pdf.js is receiving it.
var child = childprocess.spawn(this.options.phantomPath, [].concat(this.options.phantomArgs, [this.script]), this.options.cliOptions)
Example:
const options = {
format: 'Letter',
cliOptions: {
detached: true
}
};
const createResult = pdf.create(html, options);
Hope it helps.


Add support for interactive auth flow

Implementation for interactive authentication with PKCE.
Launches the default browser with select_account prompt.

Need to add tests but wanted to get the review going.

Need to add tests but wanted to get the review going.

Fixes

Fixes


'@adyen-web' exists twice in node_modules

When installing node_modules, @adyen-web is included twice. Doesn't node_modules/@adyen/adyen-salesforce-pwa/dist/app already include @adyen-web?
Adding @adyen/adyen-salesforce-pwa should be enough and it appears that we should not add @adyen-web of big size which will eventually impact performance:

Looks like that's the way the package is built:
https://github.com/Adyen/adyen-salesforce-headless-commerce-pwa/blob/main/packages/adyen-salesforce-pwa/webpack.config.js#L70C1-L72C29.
Not sure why we need both @adyen/adyen-salesforce-pwa and @adyen-web. The size of @adyen-web is already big and it appears to be included twice.
Can you look into this duplication?

Hi @TayyabSalmanMRM1996
We are investigating this issue internally and will provide a solution of the problem in our future releases.
Kind Regards
Aleksandar
Adyen

Hello @TayyabSalmanMRM1996,
We were looking at this issue, and for us in our retail app node_modules we don't have duplicate adyen-web dependecy.
Can you please explain your use case and how got the duplicate adyen-web libraries in node modules?
Thanks
Aleksandar
Adyen

Thanks @amihajlovski, you can close the ticket. I'll get back if need anything else on this.


Upgrade to latest Zally libraries.

@ethlo Do you have time to review this PR? ;)

BUMP!

Sure, done!
On Wed, Jun 7, 2023 at 1:41 PM s-jepsen @.***> wrote:

Can I request a new release to central? :)
—
Reply to this email directly, view it on GitHub
https://github.com/ethlo/zally-maven-plugin/pull/9#issuecomment-1580619526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKSB4IDCNNSXQF5PLFPTUDXKBSGDANCNFSM6AAAAAAUI6R7AY
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Link to full context of the comment comment with last mention

Simple QoL change.

Nice! I'll merge the changes after bring it back online!


WARNING: Your kernel does not support memory swappiness capabilities

Hello,
I'm trying to run a docker image with:
~# docker run -t -i debian /bin/bash

I always get this warning
WARNING: Your kernel does not support memory swappiness capabilities, memory swappiness discarded.
root@e52597aebf3c:/#

Is there something wrong with my kernel?
Thanks in advance!
Here are my docker and system info:
~# docker version
Client:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:28:37 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:28:37 UTC 2015
 OS/Arch:      linux/amd64

~# docker info
Containers: 4
Images: 7
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 15
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.16.0-0.bpo.4-amd64
Operating System: Debian GNU/Linux 7 (wheezy)
CPUs: 4
Total Memory: 5.732 GiB
Name: homeserver
ID: BBTT:P6ZB:H3NH:XJDW:LINQ:NM7P:LOWY:H4FT:NLMO:67DR:AQOA:INID
WARNING: No memory limit support
WARNING: No swap limit support

~# uname -a
Linux homeserver 3.16.0-0.bpo.4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u3~bpo70+1 (2015-08-08) x86_64 GNU/Linux

@carloscarcamo  Run check-config.sh(https://github.com/docker/docker/blob/master/contrib/check-config.sh) on your machine, you will find what was missing with your kernel.

@coolljt0725 thanks
docker info is also showing your kernel doesn't support memory swap and memory limit, most likely cgroup not mounted. I'm gonna close this as there's no issue but ping me if I'm mistaken and I'll reopen

Is there a way to get rid of this message? Not all machines have swap space and this is really annoying... Maybe display the message in the docker-engine's logs at startup, but not at container startup?

That solves it: https://github.com/docker/docker/issues/4250


feat(NumberTheory/Divisors):  Two lemmas about filtering by divisibility

Add lemmas about filtering the Finsets of divisors or factors by divisibility. These two results came up while developing API for the Finset of tuples with a fixed product n.

bors retry


Stabilize publish-lockfile.

This stabilizes the publish-lockfile feature. Specifically:

Makes Cargo.lock included by default for packages with executables.
Deprecates the publish-lockfile manifest key. It is no longer used.

Additional notes:

Fixed issue where if a Cargo.lock file didn't exist, cargo package would fail the
VCS dirty check.
Changed it so that cargo publish or cargo package will now show manifest
warnings. I believe this was an oversight.

Closes #5654

@bors: r+
Thanks @ehuss for driving this!

:pushpin: Commit 34307c6122eb1b9368c70f3b3ca3900ef08ad6b8 has been approved by alexcrichton

:hourglass: Testing commit 34307c6122eb1b9368c70f3b3ca3900ef08ad6b8 with merge 807429e1b6da4e2ec52488ef2f59e77068c31e1f...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 807429e1b6da4e2ec52488ef2f59e77068c31e1f to master...


Bind immediateCallback

The input "immediateCallback" is bound as a string; it should be a boolean. The conditional is only checking for content length, not actual boolean value.
This fixes #1.

@fjellyman - Thanks !


changefeed restriction

when user creates a new chagnefeed, TiCDC should have some pre verification for the changefeed config, including

[x] The changefeed StartTs must be larger than tikv_gc_safe_point
[ ] The must be unique, which means TiCDC can't have more than one changefeed to replicate to .

Here we should make a definition for unique data flow, maybe (schema, table, target sink)?
We also need to have a boundary for each definition, such as

What if there exist three downstream TiDB addresses and they share the same TiKV store, then how can TiCDC recognize it.
The table-filter in changefeed config may be various, is it possible to check table confliction accurately

What should TiCDC do when it detects data flow confliction

Currently, TiCDC does not provide a consumption that is lower than the table/partition data range. In the user concept, the flow combination [source table/partition -> sink table/partition] needs to be unique, that is, no more than one flow is the from source table./partition to sink table/partition

The above tasks has been added.


Add Oceanic Next colorscheme

Could you please add a link to the source?

There is no specific source, I used the Oceanic Next color palette (which I reckon might originate from Dmitri Voronianski) to set the colors.


Understanding clusters and cluster aliases

@shlomi-noach: I'm trying to understand how Orchestrator clusters work, and how they relate to cluster aliases. My goal is to reliably determine a master of each defined cluster from the API using cluster aliases. Here's an example with a single cluster, but this applies to having multiple defined as well.
Relevant configuration:
$ orchestrator -version
3.0.6
a77ee001dc95b8dc0476b929164f37b1141f54c1

{
  "ApplyMySQLPromotionAfterMasterFailover": true,
  "ClusterNameToAlias": {
    ".*": "my-cluster"
  },
  "DetachLostReplicasAfterMasterFailover": true,
  "DiscoverByShowSlaveHosts": true,
  "HostnameResolveMethod": "none",
  "RecoverIntermediateMasterClusterFilters": [
    ".*"
  ],
  "RecoverMasterClusterFilters": [
    ".*"
  ],
  "RecoveryIgnoreHostnameFilters": [],
}

Initial state:
$ curl -n -s ${orchestrator_url}/api/topology/my-cluster | jq -r '.Details'
data:3306    [0s,ok,5.7.20-19-log,rw,ROW,>>,GTID]
+ data2:3306 [0s,ok,5.7.20-19-log,ro,ROW,>>,GTID]
+ data3:3306 [0s,ok,5.7.20-19-log,ro,ROW,>>,GTID]
+ data4:3306 [0s,ok,5.7.20-19-log,ro,ROW,>>,GTID]

$ curl -n -s ${orchestrator_url}/api/clusters | jq -r .
[
  "data:3306"
]

$ curl -n -s ${orchestrator_url}/api/clusters-info | jq -r .
[
  {
    "HasAutomatedIntermediateMasterRecovery": true,
    "HasAutomatedMasterRecovery": true,
    "HeuristicLag": 0,
    "CountInstances": 4,
    "ClusterDomain": "",
    "ClusterAlias": "my-cluster",
    "ClusterName": "data:3306"
  }
]

$ curl -n -s ${orchestrator_url}/api/masters | jq -r '.[].Key.Hostname'
data

$ curl -n -s ${orchestrator_url}/api/master/my-cluster | jq -r '.Key.Hostname'
data

Everything looks good, and, by running that last command, I can see that data is the master of my-cluster. However, this isn't the case if data fails and data2 is promoted:
$ curl -n -s ${orchestrator_url}/api/topology/my-cluster | jq -r '.Details'
data:3306 [unknown,invalid,5.7.20-19-log,rw,ROW,>>,GTID]

$ curl -n -s ${orchestrator_url}/api/clusters | jq -r .
[
  "data:3306",
  "data2:3306"
]

$ curl -n -s ${orchestrator_url}/api/clusters-info | jq -r .
[
  {
    "HasAutomatedIntermediateMasterRecovery": true,
    "HasAutomatedMasterRecovery": true,
    "HeuristicLag": 0,
    "CountInstances": 1,
    "ClusterDomain": "",
    "ClusterAlias": "my-cluster",
    "ClusterName": "data:3306"
  },
  {
    "HasAutomatedIntermediateMasterRecovery": true,
    "HasAutomatedMasterRecovery": true,
    "HeuristicLag": 0,
    "CountInstances": 3,
    "ClusterDomain": "",
    "ClusterAlias": "my-cluster",
    "ClusterName": "data2:3306"
  }
]

$ curl -n -s ${orchestrator_url}/api/masters | jq -r '.[].Key.Hostname'
data
data2

$ curl -n -s ${orchestrator_url}/api/master/my-cluster | jq -r '.Key.Hostname'
data

There are now two clusters in Orchestrator, and they share the same cluster alias. Why are there two clusters and not one (data2:3306) with a detached and offlined data instance?
Why does data:3306 cluster still have the my-cluster alias? I assume this is due to the all-matching ClusterNameToAlias—if this is the case, should data:3306 cluster not have an alias applied since its sole instance is dead?
Even though data is offline, it still shows up as the master of my-cluster. Why is that?
How can I determine the real master of my-cluster after recovery? /api/masters shows two masters, and /master/my-cluster shows the dead instance.
Thanks!

@shlomi-noach: Orchestrator is still not downtiming the failed master for me. Any suggestions?

Thanks for the reminder!

I'm still unsure why your failed master was not dontimed. It is expected to be so at https://github.com/github/orchestrator/blob/8a0db2b895fb527ced7c51a2cac001ff749c2d77/go/logic/topology_recovery.go#L537
I'm mereley verifying now that the orchestrator service is up and running throughout the operation, is not being killed; is that correct? (As opposed to, say, the orchestrator service not running at all, and all ops are done via the command-line client)
Immediately following the failover, can you query the backed:
select * from database_instance_downtime;

and possibly paste the orchestrator log starting at time of failover, ending after failover is complete?

I'm mereley verifying now that the orchestrator service is up and running throughout the operation, is not being killed; is that correct?

That is correct, Orchestrator continues to run just fine.
I queried the database_instance_downtime table on raft leader during failover:
$ while true; do echo "$(date +'%T.%3N') $(sqlite3 -batch orchestrator.sqlite3 'select * from database_instance_downtime;')" | tee -a database_instance_downtime.log; sleep 0.3; done
[...]
12:21:09.350
12:21:09.658
12:21:09.965
12:21:10.273
12:21:10.580
12:21:10.915
12:21:11.223
12:21:11.530
12:21:11.837
12:21:12.145
12:21:12.453 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:12.771 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:13.078 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:13.385 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:13.693 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:14.002 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:14.321 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:14.629 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:14.936 data.my-cluster.example.com|3306|1|2018-02-14 12:21:12|2018-02-14 12:21:12|orchestrator.my-cluster.example.com|lost-in-recovery
12:21:15.244
12:21:15.551
12:21:15.859
12:21:16.166
12:21:16.473
12:21:16.781
12:21:17.102
[...]

Looks like Orchestrator is downtiming the failed master, but only briefly.
Debug log from this event: https://gist.github.com/stankevich/35edb788c4d320547097c1ec7037ad12

Aha!! I do believe https://github.com/github/orchestrator/pull/411 will fix this issue.

Released in 3.0.7


esp32 wifi: how to use ap mode and ap+station mode?

On V3.1 branch version;
I want to use esp32 wifi as ap mode and ap+station mode. Any suggestion or reference documents?

Please do not create issues (especially bug) for questions.


Update IP Allow List on Install

It would be useful for the IUpgradeable feature to be added that automatically adds the current IP address that's installing the module so it doesn't need to be done via SQL in production environments.

Just a note on this one, I've tried this and it isn't necessarily consistent in the context of IUpgradable due to when it is triggered and how proxy or internal routing might work.  (At least that was my test.)

Ah.. Good point.  Maybe another method could be explored if we can't find something more consistent during IUpgradeable.

I would agree, totally great idea Will, just not sure of the best "accurate" way to make this happen.


Flaky E2E test for pubsub http

In what area(s)?
/area test-and-release
What version of Dapr?
1.11.2
Expected Behavior
Pass in scheduled test workflow
Actual Behavior
High possibilities to fial
Steps to Reproduce the Problem
Here are some latest failed test workflow for reference:
https://github.com/dapr/dapr/actions/runs/5995181354
https://github.com/dapr/dapr/actions/runs/5979607097
https://github.com/dapr/dapr/actions/runs/5971458067
More Note
When it fails, the logs show that its publish-subscribe functionality tends to be fine, and the number of messages published and subscribed match.
The above conclusions can be drawn from the following logs :

subscriber received 60/60 messages on pubsub-a-topic, 60/60 on pubsub-b-topic and 60/60 on pubsub-c-topic, 60/60 on pubsub-raw-topic and 60/60 on dead letter topic

So this issue should not be a bug about the source code of dapr runtime.

closed by #6860


⚠ Bofrost.at has degraded performance

In aecf40e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1955 ms

Resolved: Bofrost.at performance has improved in c8c1668 after 6 minutes.


fix error when loading cl i think

Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes

No, CloudLink works perfectly fine. It just displays a message when you load it. I designed it intentionally.

xD thanks


fixing ignore check for visual selection

addresses https://github.com/MagicDuck/grug-far.nvim/issues/198


Request a reproducible example for SO questions

I've been trying to answer most questions on SO over the past month or so. The quality of questions is not great — is there a way we could encourage people to post reproducible examples? I think our push to do that on GH issues has been broadly successful.
I occasionally reply asking for a reproducible example, but it's not that friendly an approach.
There are some SO docs: https://stackoverflow.com/help/minimal-reproducible-example, but they're not explicitly linked to from SO.

LGTM. Hopefully it works!


2.7.3 transaction is error

@Override
@Transactional(rollbackFor = Exception.class)
public String sayHello(String name) {
var a=UUID.randomUUID().toString().replaceAll("-","");
tmapper.ins(a);
var b=1/0;
return a;
}
dubbo'service transaction isn't roll，the data insert database
2.7.1 is ok

@mercyblitz

Can you try to use <IP_ADDRESS>?

no I used 2.7.3

Did you use an annotation @Reference injecting a local Service Bean? If you did, please switch it to be @Autowired, or wait for 2.7.6 release

thank you itry it


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/100006

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/101327

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109349

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/112668

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114419

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/115766

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118967

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119915


Website Description in Google Search

If you search "sButtons" now, you'll see that the website has the description "You need to enable JavaScript to run this app." We need to replace this with good description.
You'll probably need to use something like react-snap

I think adding longer meta description tag would fix the issue.

Hello @arunes unfortunately, that's not enough. It's not about the page having description (they already do), the pages need to be prerendered so that when Search engines like google can crawl them correctly

Hi @shahednasser, if the sole purpose of this issue to fix description on google. It should be fixed by changing the default meta description on the public/index html.
Right now it is "sButtons"
<meta name="description" content="sButtons">
Later filled with react to this;
<meta name="description" content="Simple buttons you can use easily for your next project.">
As far as I see all the meta descriptions are same for all the pages. So instead of setting the meta description with react, maybe we can try to change meta on /public/index.html, because that's the first thing search engines crawl.
But of course if you need other/different meta information based on the page, this wouldn't work.

@arunes that's not entirly true, as Google would have used the description "sButtons" instead of what it currently shows, which is something regarding Javascript. This is because Google doesn't necessarily abide by "strictly use the description meta tag" it also crawls the website and sometimes uses the description they find fitting.
For this reason, we need to add pre-rendering for the website.

@shahednasser If google cannot find anything meaningful on meta description it looks for the page content, which is "You need to enable JavaScript to run this app."
I made it work for my personal website before, this is the search result;
This is the google search result, when you search "photogrado"

You can check the source code of the html page, google shows the meta description I have in the html.
I'm just trying to help, I think it wouldn't hurt to try.

@arunes i understand and it definitely won't harm, but what I'm saying this is not suitable as the only solution, because if Google decides to crawl the website instead of using the description, we'll still have the Javascript description

Hello, it looks like @arunes is right. Google robot bypass all tags he doesn't find pertinent. Maybe the next most pertinent information after "sButtons" is "You need to enable JavaScript to run this app." on the page. You should try to add to current well-known description of the app into description tag to see if it works.

@0xYoan we need to change that, but I think we also need to add some pre-rendering to make sure that if Google decides to skip the description for whatever reason, there will be other content. This is also better for the SEO of the website.

Hi, @shahednasser
I would like to work on this issue. Is the issue still open?

Hi @medhavisinha sure i'll assign you

@shahednasser thank you :)
I'll get to work on it and once I resolve it, I'll send a pull request.

@shahednasser, as much as I can see from my side, there is no such issue happening as of right now. Please look into it once and let me know.

@medhavisinha that's because with Google, the description changes depending on what they think is best for the search query.
Can you at least change the description in website/public/index.html?

@shahednasser ah, got it. and yes, definitely i can do that. i'll commit changes and send a pull request once i make changes.

Is this issue still open ?
If no one is working on it then please assign it to me.

Hello @Divyanshj, @medhavisinha is working on it

@shahednasser I have created a pull request. Please see whether it is right or not, and if it is right, then merge it and let me know. Thank you!

Unassigning @medhavisinha due to inactivity

can I take up this issue @shahednasser ?

@shahednasser I improve the content for meta description tag in index.html


Need to rename transaction to batch in http and gRPC endpoints.

The transaction support we have added works more like a batch. Let's make that more explicit. This will require us refactoring:

The https endpoint (url)
The gRPC rpc name.
The CRUD interface in crud.go and operations.go
the func name in sql and mongo packages

Here's how the batch API should look for javascript:
const batch = db.beginBatch();
batch.add(db.insert(col).docs(...docs));
batch.add(db.update(col).where(whereClause).set())

// Apply batch
batch.apply().then(res => ...).catch(ex => ...)

Same can be ported to other client libraries as well

Have done the refactoring and have created a Pull Request.


Image.network loadingBuilder not working on web

In my app, I created a simple Image.network() image and added a standard loadingBuilder function. Using the web version, I don't get any progression. The argument ImageChunkEvent loadingProgress is always null. Running the same code on an Android emulator for instance works just as expected.
Steps to Reproduce

Run flutter create bug.
Update the files as follows: add a Image.network() widget in the build function.
Define a loadingBuilder on it.

Code
Here is a simple code that reproduce the bug. I used a huge 54Mb image to demonstrate the problem.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Scaffold(
        appBar: AppBar(
          title: Text("Demo"),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              Image.network(
                "https://effigis.com/wp-content/uploads/2015/02/Airbus_Pleiades_50cm_8bit_RGB_Yogyakarta.jpg?cacheForceUpdate=" +
                    DateTime.now().millisecondsSinceEpoch.toString(),
                fit: BoxFit.cover,
                loadingBuilder: (BuildContext context, Widget child, ImageChunkEvent loadingProgress) {
                  print("loadingProgress: $loadingProgress: " + DateTime.now().millisecondsSinceEpoch.toString());
                  if (loadingProgress == null) return child;
                  return Center(
                    child: CircularProgressIndicator(
                      backgroundColor: Colors.black26,
                      valueColor: AlwaysStoppedAnimation<Color>(Colors.blueGrey),
                      value: loadingProgress.expectedTotalBytes != null
                          ? loadingProgress.cumulativeBytesLoaded / loadingProgress.expectedTotalBytes
                          : null,
                    ),
                  );
                },
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Logs

flutter analyze
Analyzing my_app...
No issues found! (ran in 2.0s)

flutter doctor -v
[√] Flutter (Channel unknown, v1.14.3, on Microsoft Windows [version 10.0.18362.592], locale fr-CA)
    • Flutter version 1.14.3 at D:\_utils\Flutter
    • Framework revision b5a23fdf5b (3 weeks ago), 2020-01-22 02:11:09 +0800
    • Engine revision c15efb9231
    • Dart version 2.8.0 (build 2.8.0-dev.3.0 f910a7575f)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at C:\Users\nicolas.dion\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.0
    • ANDROID_HOME = C:\Users\nicolas.dion\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[!] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[!] IntelliJ IDEA Ultimate Edition (version 2016.3)
    • IntelliJ at C:\Program Files (x86)\JetBrains\IntelliJ IDEA 2016.3.8
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins
    X This install is older than the minimum recommended version of 2017.1.0.

[!] IntelliJ IDEA Ultimate Edition (version 2019.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2019.2
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[√] VS Code, 64-bit edition (version 1.41.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.8.1

[√] Connected device (3 available)
    • Android SDK built for x86 • emulator-5554 • android-x86    • Android 9 (API 28) (emulator)
    • Chrome                    • chrome        • web-javascript • Google Chrome 80.0.3987.87
    • Web Server                • web-server    • web-javascript • Flutter Tools

! Doctor found issues in 3 categories.

+1 same here

@yjbanov @ferhatb
I'm seeing the same problem on mobile, not just web.


Support question - Extra CSV column

thanks for this lib, we have been using it in production for almost a year - can this lib check to see if a CSV file has an extra column? Looks like the checkColumn: true can check for missing headers, but what about an extra header/column in the .csv file? Please let me know, thanks!
(Currently, using this library, it is hard for me to tack on support for extra headers, seems like the best way and the only good way is to do it within this library.)

Hi,
I am not sure why you need check if a CSV file has an extra column.
However try to set parameter ignoreEmpty=true. It will automatically skip empty columns.
~Keyang

Well, I think it's my mistake - looks like checkColumn: true works for both extra columns and missing columns, does that make sense?

Yeah. it will threw error if columns number not equal to that of header -- no matter more or less..
~Keyang


Protect the initial state  of this._activeRenderTarget in _indexContext

    this._activeRenderTarget = null;
    this._activeTextureLocation = 999;
    this._activeTexture = null;

must before this._indexContext() , otherwise  the _activeRenderTarget & _activeTexture init in  _indexContext will back to null.

@bigtimebuddy  @ivanpopelyshev  @englercj  @GoodBoyDigital
This PR is very important.
Review as soon as possible , please .
Thanks.

@finscn Could you please explain what this change is and why it's important?

@bigtimebuddy  please forgive me for my bad english.  It's not important , it's just fix a serious bug.
The bug is serious , but is not usual.
In current PIXI ,   _initContext()  will set
renderer. _activeRenderTarget = renderer.rootRenderTarget;

But, after _initContext() , the code
this._activeRenderTarget = null;

make the _activeRenderTarget  is back to null.
So , after  you new WebGLRenderer() , the renderer._activeRenderTarget === null,
the  things that doing in _initContext()  are in vain.
And there will take a error when we first call
renderer.clear()

example:
var  renderer = new WebGLRenderer({
    clearBeforeRender : false
});

// I clear the canvas by myself.

tick()
{

    // do sth.

    renderer.clear();

    // do sth.

   renderer.render(stage);
}

When the game first call  tick() , there is an error.

This is a bug absolutely.
the current  logic in the constructor of  WebGLRenderer is :
this. _activeRenderTarget = createDefaultActiveRenderTarget();

this. _activeRenderTarget = null;

The bug is  quite obvious.

Why does nobody care about this bug ?

@finscn It's not that no one cares, it's because we all have day jobs. We are not paid to develop pixi.js so please have patience when someone cannot respond quickly enough.

@finscn I cared first :)


ipyvtklink missing warning

Failing to load ipyvtklink. This is a warning. Is it expected?

Note: Do not mind the pyvista deprecation warnings.

It seems more an issue of Pyvista, and it fallback to static image, which is fine.
If needed interactive plot, you can install it with pip install ipyvtklink


Add Timber\Post class as a return type to query_post

Issue
Autocompletion fails with phpStorm because it can't derive the correct class.
Solution
This helps with autocompletion when working with phpStorm.

Coverage decreased (-2.5%) to 91.551% when pulling 22d49659b5bc08e147b25c1d705378aed6defc35 on mweimerskirch:patch-1 into 31d70de34a455f8515c2e3a15e24a941bb8092cb on timber:master.

Thanks for the PR @mweimerskirch. I just merged it and will release later as a new version bump


Implement Hot ranking

Thanks a lot! That's awesome.

I created a separate package (reddit-score) so if there's a bug or something we can update it in different package. So it's totally independent from GitHunt.


Add folders from azure-extension-platform

main folder with extension files
Add extension file, name and version
Add extension test file

I don't think we need this. Closing the request.


删掉无用目录 && 添加 .gitignore

AkaraChen 你好，首先感谢您对TNTJs的项目的贡献，但是这里的GitHub仓库已经是滞后的版本，我们内部的TNTJs从目录结构到运行原理已经全部重构了，如果您需要一份最新的项目结构的话可以联系我的QQ2916467374，我可以给您提供一份最新的项目副本并回答有关新的运行机制的问题，以方便您做出更为有效的贡献。再次感谢您的贡献。
Hello AkaraChen, firstly I have to thank for your contribution, but the repository here isn't the newest version. We rebuild the project recently and now the structure of the project and the runtime system are both different from this repository. If you need the newest project folder please contact me on QQ<PHONE_NUMBER>, and I can provide you the newest project folder and answers any question about the new runtime system in order to make it easier for you to make more useful contribution. Thanks for your contribution again.

_ No description provided. _

AkaraChen 你好，首先感谢您对TNTJs的项目的贡献，但是这里的GitHub仓库已经是滞后的版本，我们内部的TNTJs从目录结构到运行原理已经全部重构了，如果您需要一份最新的项目结构的话可以联系我的QQ2916467374，我可以给您提供一份最新的项目副本并回答有关新的运行机制的问题，以方便您做出更为有效的贡献。再次感谢您的贡献。
Hello AkaraChen, firstly I have to thank for your contribution, but the repository here isn't the newest version. We rebuild the project recently and now the structure of the project and the runtime system are both different from this repository. If you need the newest project folder please contact me on QQ<PHONE_NUMBER>, and I can provide you the newest project folder and answers any question about the new runtime system in order to make it easier for you to make more useful contribution. Thanks for your contribution again.

Thank you for contributing to BugDuck. And btw - did I saw you on QQ? Your avatar seems familiar.
However, we're currently focusing on transporting our project to fit the ES6 syntax and already added those dependences.
This pull request will be closed for now. Thank you!


Mapboxgl already in use in an app

I'm working with a complex website that loads the mapbox-gl library elsewhere, as well as react-mapbox-gl for some specific React based components and I want to avoid loading the library twice.  Can I setup react-mapbox-gl to use either the already loaded mapbox-gl library or even a global version of mapbox-gl?

mapbox-gl is a peer dependency – it doesn't include its own. This means you can indeed have a single mapbox-gl in your code.