Missing BNF code changes

The BSA provide code maps on an annual basis to map where BNF code changes.  We have a list of what we have used here.
However we appear to have a number of missing years:
2016
Using the code below suggests there are no missing BNF code changes between December 2015 and January 2016 data
WITH
  bnf_details AS (
  SELECT
    bnf_name,
    bnf_code
  FROM
    `ebmdatalab.hscic.normalised_prescribing`
  WHERE
    month BETWEEN '2015-12-01'
    AND '2016-01-01'
  GROUP BY
    bnf_name,
    bnf_code)
SELECT
  bnf_name
FROM
  bnf_details
GROUP BY
  bnf_name
HAVING
  COUNT(bnf_code)>1

2019
Using similar code to above, with WHERE month BETWEEN '2018-12-01' AND '2019-01-01'  also returns no data.
2021
NHSBSA have released a BNF code change map for 2021 here.  Running the code above suggests that this file hasn't been imported.
2022
NHSBSA have released a BNF code change map for 2022 here.  Running the code above suggests that this file hasn't been imported.
Can we import these as soon as possible to ensure that there aren't issues with data quality please.  Also it's likely the 2023 map will be out in February 2023, so we need to check then for any code change maps.

I think there's going to be some quite serious software archaeology required to understand what's needed here.
The comments here suggest that the original files were supplied privately via email and than manually corrected:
https://github.com/ebmdatalab/openprescribing/blob/dfd7e4f92dbac10739203027d90dafb577abdfd3/openprescribing/frontend/management/commands/generate_presentation_replacements.py#L30-L32
But then they also suggest that 2017 is the last year they should be needed, which is obviously not the case:
https://github.com/ebmdatalab/openprescribing/blob/dfd7e4f92dbac10739203027d90dafb577abdfd3/openprescribing/frontend/management/commands/generate_presentation_replacements.py#L75-L77
There's an open issue here on the question of exactly how these changes are supposed to work:

https://github.com/ebmdatalab/openprescribing/issues/456

I think it would be reasonably straightforward to generate 2021.txt and 2022.txt files from the XLSX files linked above. And then assuming that the generate_presentation_replacements command still works it should be possible to import these in the same way as the existing replacements.
I've no idea how we'd go about obtaining the missing 2016 or 2019 data though — this predates even my tenure here.

I think @inglesp and @sebbacon are going to need to go email spelunking to find out how we obtained the 2018 file from NHSBSA. (It was added by Peter on 14 Aug 2018 if that helps narrow things down.)
Possibly the same process can be used to get the missing 2019 and 2016 files.

Have forwarded some breadcrumbs by email

@evansd I'm not sure there are any 2016 and 2019 changes - there are no BNF codes with a COUNT>1 in the search that I did.

The 2017 changes are on the BSA website here

I'm not sure there are any 2016 and 2019 changes - there are no BNF codes with a COUNT>1 in the search that I did.

Ahhh, right — sorry! I think I totally misunderstood what you were getting at here. You had the line "we appear to have a number of missing years" followed by a list of year headings so I just assumed these were all missing years. But if I've understood correctly 2021 and 2022 are the only actually missing ones, and both of those are available for download already. Is that correct?
If that's the case then @inglesp and @sebbacon can stand down. I can just try to use the existing command with the new data and see what happens.

Sorry @evansd , yes I started here and worked through, which is why I said several years missing - but I don't think there were any changes in those two years.

Yes, that makes sense now. It just ended up down the wrong garden path and then confused myself!

Sigh
I've deployed the PR with the new files and first tried running the generate_presentation_replacements as the ebmbot user. That got me a permissions error:
PermissionError: [Errno 13] Permission denied: '//mnt/database/tmp/unused_codes_section_code.csv'

That file (and a few others like it) are all owned by hello so I tried running as that user. That then died with a protected foreign key error:
ProtectedError: ("Cannot delete some instances of model 'Presentation' because they are referenced through a protected foreign key: 'Presentation.replaced_by'", <QuerySet [<Presentation: 0101021B0BEAKAL: Gaviscon Advance oral suspension peppermint>, <Presentation: 0105000B0BDAFAN: Salofalk 1g gastro-resistant modified-release granules sachets>, <Presentation: 0106040M0BBAEAF: Movicol Chocolate oral powder 13.9g sachets>, <Presentation: 0206010F0BBABAA: Coro-Nitro 400micrograms/dose pump sublingual spray>, <Presentation: 0206010F0BFABAA: Nitrolingual 400micrograms/dose pump sublingual spray>, <Presentation: 0206010F0BRABAA: Glytrin 400micrograms/dose aerosol sublingual spray>, <Presentation: 0301011Y0AAAAAA: Fluticasone furoate 184micrograms/dose / Vilanterol 22micrograms/dose dry powder inhaler>, <Presentation: 0301011Y0AAABAB: Fluticasone furoate 92micrograms/dose / Vilanterol 22micrograms/dose dry powder inhaler>, <Presentation: 0301011Y0BBAAAA: Relvar Ellipta 184micrograms/dose / 22micrograms/dose dry powder inhaler>, <Presentation: 0301011Y0BBABAB: Relvar Ellipta 92micrograms/dose / 22micrograms/dose dry powder inhaler>, <Presentation: 030902000BECEA0: Boots Catarrh Cough syrup>, <Presentation: 040101000BBADA0: Bio-Melatonin 3mg tablets>, <Presentation: 040101000BBAHA0: HealthAid Melatonin 3mg tablets>, <Presentation: 0407010T0BBAABP: Veganin tablets>, <Presentation: 0410000B0BBAKBB: Nicorette Citrus 2mg medicated chewing gum>, <Presentation: 0410000B0BBALBE: Nicorette Citrus 4mg medicated chewing gum>, <Presentation: 0410000B0BBAPBK: Nicorette Freshmint 2mg medicated chewing gum>, <Presentation: 0410000B0BBAQBL: Nicorette Freshmint 4mg medicated chewing gum>, <Presentation: 0410000B0BBARBM: Nicorette Fruitfusion 2mg medicated chewing gum>, <Presentation: 0410000B0BBASBN: Nicorette Fruitfusion 4mg medicated chewing gum>, '...(remaining elements truncated)...']>)

Will have to pick this up afresh tomorrow.

The problem turned out to be here:
https://github.com/ebmdatalab/openprescribing/blob/57d217d788dc206be850f849ddd2d1d664754d92/openprescribing/frontend/management/commands/generate_presentation_replacements.py#L114
We had some presentations where their replaced_by field referenced a presentation which was itself replaced by some other presentation. Deleting all of these together shouldn't involve an integrity error but Django's emulation of integrity constraints in Python can't handle this properly and so throws an error.
My workaround was just to perform the equivalent delete directly in the psql console and then run the command which then completed successfully.
I'm still not closing this ticket because we need to re-import (at least some of) the data. This means rebuilding the matrixstore prescribing file using the new presentation replacements. And possibly re-importing the measures if any of them are affected (@richiecroker is checking this).

I've now rebuilt the MatrixStore file using the updated BNF code replacements and deployed it.
I've also generated a list of all BNF codes used in all measures, using this script:
from collections import defaultdict
from frontend.models import Measure

bnf_codes = defaultdict(set)

for measure in Measure.objects.all():
    for c in measure.numerator_bnf_codes or ():
        bnf_codes[c].add(measure.id)
    for c in measure.denominator_bnf_codes or ():
        bnf_codes[c].add(measure.id)

for code, ids in sorted(bnf_codes.items()):
    print(f"{code},{','.join(sorted(ids))}")

@richiecroker is working on assessing the impact of the code changes on any measures and will amend and re-import the measures as needed.

For an assessment on the impact on measures, see #3746.  Several are affected, and for expediency we're reimporting all of them.

Upading this issue for future archaeologists
The mapping emails were originally supplied in  August 2016, by a Graham Mitchell from NHSBSA.
In June 2017 we were given a contact Margaret Dockey, Prescription Information Services Manager who provided the latest spreadsheet entitled DRUG_SNOMED_BNF_20170714.xlsx. In October she provided an updated entitled Converted Snomed - BNF.XLSX


[CDAP-14571] Support for macros in dataprep

Changes tested on standalone.
These changes use SystemHttpServiceContext#evaluateMacros api to evaluate macros for below fields:

Database Connection

username
password

S3 Connection

access key
access id

With macro support, Database connection and S3 connection can provide secure macros for these fields.

Tested on the cluster


Missing "hostname" key in logs

Description
As discovered here: https://github.com/jcmoraisjr/haproxy-ingress/pull/964#issuecomment-1322546679
Logs appear to be missing the hostname key (newlines inserted for visibility):
Loading 1 applications
time="2022-11-21T19:21:07Z" level=info msg="spoe: listening on [::]:9000"
{"level":"error","ts":1669058760.188159,"msg":"[client \"<IP_ADDRESS>\"] Coraza: Warning. OS File Access Attempt
[file \"/etc/coraza-spoa/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf\"] [line \"0\"] [id \"930120\"] [rev \"\"]
[msg \"OS File Access Attempt\"] [data \"Matched Data: etc/passwd found within ARGS:p: /etc/passwd\"] [severity \"critical\"]
[ver \"OWASP_CRS/4.0.0-rc1\"] [maturity \"0\"] [accuracy \"0\"] [tag \"application-multi\"] [tag \"language-multi\"]
[tag \"platform-multi\"] [tag \"attack-lfi\"] [tag \"paranoia-level/1\"] [tag \"OWASP_CRS\"] [tag \"capec/1000/255/153/126\"]
[tag \"PCI/6.5.4\"]
[hostname \"\"]   <---
[uri \"/?p=/etc/passwd\"] [unique_id \"260e3d15-dd04-41b7-a634-45d17f0a8390\"]\n"}

If I'm reading the code correctly, that log value is always set to an empty string: https://github.com/corazawaf/coraza/blob/9d003ed52753367b75383566ca69bc3d467cc8a0/internal/corazarules/rule_match.go#L123-L139
When multiple sites are fronted by a single server running Coraza, you need the hostname field to tell which site triggered the rule.
Since Coraza scans the headers anyway, it might be possible to just grab the Host header to populate that hostname field. HTTP says that header is required anyway.

Related issue https://github.com/corazawaf/coraza-caddy/issues/35

Current situation and Coraza/Modsec comparison:
ModSec v3:

Populates m_variableServerName looking for the host header (see here).
Logs side: the hostname field is populated with the server IP (see here).

Currently Coraza:

tx.variables.serverName is never populated, therefore SERVER_NAME is always empty.
Logs: the hostname field is empty.

Possible Fixes
SERVER_NAME:

Populate it with host header Coraza side (just like ModSec)
Just like other connection details (IP, ports), let's delegate its retrievement to the connectors adding one field to ProcessConnection. If empty string, let's populate it with the IP address. (Accoring to ModSec doc: SERVER_NAME: contains hostname or IP address.

Logs:

Current PR adds the server IP to the hostname field for logging.
Once tx.variables.serverName is populated we may sanitize (at least check allowed characters?) and two different fields for address and hostname.

I'm happy to work on it, I just want to agree on the implementation. At first sight, I would go for adding one field to ProcessConnection, could some connectors be aware of the hostname there are listening at and not have to look at the headers?

@fuomag9 @mac-chaffee we just medged the fixing PR. Could you please test it?

The merged PR aligns the hostname field for logging to the ModSec behaviour, still, I think that it is a partial fix mainly because of the never populated SERVER_NAME field. I'm gonna open a PR that proposed to delegate it to ProcessConnection (Option 2 of my above comment).


Remove GitHub pre-commit workflows

I've taken the liberty of installing the pre-commit GitHub app (https://pre-commit.ci) for the imperialCHEPI org, which replaces the need for these GitHub Actions. For some reason the auto-update workflow failed this week, so I figured we might as well change over now. We use the app for loads of other projects and haven't had issues with it.

Provided you've accepted the request to add the app to the org, then it should just show up automagically in PRs :crossed_fingers:


[WIP][da-vinci] Allow for custom materialized views in Da-Vinci

Summary
This is a work in progress to give users the ability to create different ‘views’ of a given Venice data set without having to either reimplement Venice versioning/bootstrapping or push a transformed copy of a dataset which might already exist in Venice.
Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[x] Yes. Make sure to explain your proposed changes and call out the behavior change.

We would like to give users the ability to set up individual application specific data transformation, storage or filtering to specify what Davinci should do as it ingests every record.

Should we also add an overloaded constructor for the generic/specific davinci cliens?


Data Preprocess

May I ask how I can run through my own data? Is there a formalized data preprocessing scheme? Thank you for your great work.

Also by the way, are there any pre-trained models available for download? Thank you for your open source work!

Hi,
You can refer to NeuS and Vis-MVSNet to generate the cameras_sphere.npz file and the files under cam4feat, respectively.

Hi,
You can refer to NeuS to generate the cameras_sphere.npz file, and Vis-MVSNet to generate the files under cam4feat.
To get the .ply point cloud file, you can use our colmap-with-pose code.
Our pretrained weights on DTU/BlendedMVS will be released a few days later together with ours mesh results. Thanks for your interest in our work.

It works! Thanks for your help.


Port workspace and script without shebang to v1alpha2

Changes
This port some recent updates to the Task struct and validation into v1alpha2

workspace support
script without a shebang (#!)

/cc @sbwsg @bobcatfish
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

/lgtm
i'll rebase and update the confirmap and secret volume support once this is merged.

/approve


Test incorrectly logs the total test time (Codecept + Testcafe)

What are you trying to achieve?
Having the correct total test time logged.
What do you get instead?
An obviously incorrect test time. I executed a really short starter test and it logged 14 seconds, while it undoubtedly took only around 2 seconds.

You can see the incorrect total time back in Allure.
The weird thing is that the step times are correct. This is a really important feature for me, I need the correct total test time, otherwise I can't make any legit test reports.

Provide console output if related. Use --verbose mode for more details.

TodoMVC --
Running tests in:

Chrome 78.0.3904 / Windows 10.0.0
√ create todo item in 2509ms

OK  | 1 passed   // 14s

Provide test source code if related

Feature('TodoMVC');
Scenario('create todo item', (I) => {
I.amOnPage('http://todomvc.com/examples/angularjs/#/');
I.fillField('.new-todo', 'spelen')
I.pressKey('Enter');
I.seeNumberOfVisibleElements('.todo-list li', 1);
I.see('1 item left', '.todo-count');
});
Details

CodeceptJS version:  2.3.5
NodeJS Version: 10.16.3
Operating System: Windows 10
Testcafe 1.6.0
Configuration file:

exports.config = {
output: './output',
helpers: {
TestCafe: {
url: 'http://todomvc.com/examples/angularjs/#/',
browser: 'chrome',
show: true
}
},
include: {
I: './steps_file.js'
},
mocha: {},
bootstrap: null,
teardown: null,
hooks: [],
gherkin: {
features: './test/features/.feature',
steps: ['./test/step_definitions/steps.js']
},
plugins: {
screenshotOnFail: {
enabled: true
},
allure: {
}
},
tests: './_test.js',
name: 'TestCoSuite'
}

seems like not on TestCafe helper


technitium-dns-server: 13.2 -> 13.3, merge library and server

Things done
Update Technitium DNS Server to 13.3. More important: undo split / re-merge the library into the file so that automatic updates are possible. Refer to the closed PR at https://github.com/NixOS/nixpkgs/pull/363529 for details.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Yes... Because of https://github.com/NixOS/nixpkgs/commit/1cd9516969553291792021f1b327f0e2e2775b3c. -.-
I'll try to fix that.

This now has a merge conflict.

Should be fixed now. Both nuget-deps are now jsons.

This would allow us to test that the update of both together works well with the update script.

Thank you for your suggestion! However, the update script has never worked. Initially, the script's author suggested splitting the package -- which we did and which led to problems. Now we (re-)merge it in order for a new update script to work properly.
So it would be great if you could merge it as is so that we can work on the new update script which updates both components simultaneously in one package.

So, you split the package to make the update script work. It didn't work.
No. Another contributor asked to split the package and separate the library for an update script. I approved that PR. However, that attempt failed.

Now you merge the package again - to make update script work. But we can't confirm.
No. This update script will probably not work -- it has never worked before. However, in the current state, the update script will never work.

This seems pointless. We should make sure that the update script works after merging the packages - before merging the PR.
It hasn't worked. Perhaps a new update script will work, but I don't know. I haven't created any update scripts yet.

In any case, the commits should be split into merge and update - independently of whether we can confirm the update script working this way or not. Different kind of changes shouldn't be in the same commit.
OK. I removed the update part and only included the merging of the library into the package -- e.g. the original state.


Cassandra migrations

Following https://github.com/jhipster/jhipster-lite/issues/877

Hi @pascalgrimaud,
Thank you for the review+merge, and adding a bug bounty on it, it was pleasant surprise for me :)
I have a last cassandra PR, to add the dummy-cassandra module.
Could you create an issue and assign it to me as you did for this one ?
I dont have a lot of free time this week, so the PR should come around the weekend

Thanks for your work @Yourgene
No worry, it's open source, so no hurry. Take your time :-)
I'll create the ticket right now


Doc doesn't explain why healthcheck cannot be exposed as external endpoint

Doc doesn't explain why healthcheck cannot be exposed as external endpoint.   This would be a logical assumption since Spring-Book services all expose a public endpoint to the service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20c42a13-f6cb-1e60-0438-f7f32b86a336
Version Independent ID: 79e7dd15-24aa-2e6d-cee7-7714e1940c11
Content: Monitor the health of App Service instances - Azure App Service
Content Source: articles/app-service/monitor-instances-health-check.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@djangofan, Thanks for the feedback! I have assigned the issue to the content author to evaluate and update this doc as appropriate.

@JasonFreeberg Let me know your thoughts on this feedback.

#needs-sme-input

Hey @djangofan,
Health Check endpoints are owned by the users and should be exposed however you'd like.  If this is still an issue, can you elaborate on the broken scenario please so we can investigate?

@please-close


Add examples for import

Description of the Change
Add examples of import to the documentation.
Why Should This Be In The Package?
Its a good enhancement to the docs. Someone had a question about it earlier and it took some time to figure out. Save the future person a bit of time
Benefits
Better docs and save future users time
Possible Drawbacks
None
Verification Process
View PR using rich display option

Addresses #70


[Draft][dunfell] Add support for ROS 2 rolling

Forgot to change to draft PR before create, closing.


express deprecation warning (change req.host to req.hostname)

Receiving the following warning:
express deprecated req.host: Use req.hostname instead at node_modules/bunyan-logstash/lib/logstash.js:19:26

are you using req.host in your express app?  this package just reported the error to you from that location.


Kernel updates for 2023-09-23

Description of changes
NFS fix. Hardened update-script failed for some reason?
Closes #256526.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

6.5.5 compiles.


remove TB_OPT_TRUECOLOR

It shouldn't matter whether uintattr_t is typedef'd as uint16_t or uint32_t as long as the correct TB_* macros are used, so this macro is redundant. This also fixes compile errors when building without truecolor.

TB_OPT_EGC enables an extra harmless feature too, any reason to not remove it aswell?

Agree the ifdefs are annoying. They are both efforts to allow library users to have an 8-byte-aligned tb_cell if needed. IIRC there are some people using termbox on vintage hardware and it's nearly a requirement for them.


[6.0] Fix cache not cleaned up if download fails

Cherry-pick of https://github.com/apple/swift-package-manager/pull/7663.
Explanation: If a server returns an error when trying to download a binaryTarget an invalid file remains in the artifacts cache.
Scope: Isolated to binary targets cache.
Risk: Low, scope is isolated, and the change has a corresponding test.
Testing: Automated with an existing test case refined.
Issue: rdar://123897276
Reviewer: @MaxDesiatov

@swift-ci test


Allow using env vars in project.yml

Similar to how SwiftLint does: https://github.com/realm/SwiftLint/pull/1703

Hm, this might conflict with template attributes which use the same syntax. Which one would win when you have an environment variable ${SOME_VAR} and a template attribute ${SOME_VAR}?


Update README.md

Minor typo fixed
-very
+every

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@bobychaudhary Thanks for opening this PR. Since we don't accept changes to this file, I am going to close this PR now 💛.  I went ahead and opened an internal PR with this fix ✨
Thanks so much for contributing to GitHub docs 💖


Added support for one shot on OnSemi NCT sensors

Hi there, and thanks for a neat library :)
I found myself with a box of NCT75 chips from OnSemi, and was interested in using the one-shot feature, as they're for a batter powered project that'll spend most of its time sleeping.
As the one-shot implementation is onsemi specific, I added a class for it. The onsemi implementation is fairly simple. When setting config bit 5, the chip immediately shuts-down, and is now ready for a oneshot trigger. That trigger is writing anything to register 0x04
It is unclear if the shutdown-bit overwrites this behavior, however it does so in other, similar chips, so to be safe this is set to 0.
There's no way to check if a conversion is done, so the datasheet spec of 48.5 ms typical one-shot conversion time is doubled to hopefully be a sensible "worst case" time.
The sensors doc is updated to reflect this support, and a specific example is added.

Thanks for the quick review!
I'm just happy there's such a general library there! Allows me to not worry too much about which chip I pick. If I can't get that in the future, there'll be a compatible version, and a single define to change :D

I know what you mean! This is my test setup for the library:

Verified working fine after the commit above on my OnSemi NCT75!

I just released version 1.0.3 including your fixes which should show up on the Arduino library manager shortly!

Awesome! :) it's rare to see libraries with a full hardware test-suite to back it up! :)


Strange line splitting choice for logical operator

Before:
    disallowed_headers.iter().any(|header| *header == name) ||
        disallowed_header_prefixes.iter().any(|prefix| name.starts_with(prefix))

After:
    disallowed_headers.iter().any(|header| *header == name) || disallowed_header_prefixes
        .iter()
        .any(|prefix| name.starts_with(prefix))

This is another interesting case I discovered.
Before:
            (root.is_parent_of(elem.upcast())
                || self.sections.iter().any(|ref section| section.is_parent_of(elem.upcast())))

After:
            (root.is_parent_of(elem.upcast()) || self
                .sections
                .iter()
                .any(|ref section| section.is_parent_of(elem.upcast())))

The following method allows a binary operator to go multiline:
https://github.com/rust-lang-nursery/rustfmt/blob/e2b9c66cc9d3228339d07cb5410f6cabdac97de8/src/pairs.rs#L60-L62
Out of curiosity, I have made the following condition in that method return None so that it fails if it tries to put a multiline branch:
https://github.com/rust-lang-nursery/rustfmt/blob/e2b9c66cc9d3228339d07cb5410f6cabdac97de8/src/pairs.rs#L98
The result is the following formatting:
    disallowed_headers.iter().any(|header| *header == name)
        || disallowed_header_prefixes
            .iter()
            .any(|prefix| name.starts_with(prefix))

The 2nd branch went multiline because it didn't have enough allocated width (since it was to be placed after the first branch on the same line). With that other formatting, the 2nd branch would fit on a single line.

IMHO the second approach is better, though it still looks clunky because of the || at the front of the chain. Putting binary operators at the front doesn't really work well with block-indent + multi-line chain.

Looking at the changes with @scampi 's suggestion, the changes which look much better with the current special case are those where the lhs is very short. I'm not sure exactly how to tweak this - maybe the tab width (since we use that elsewhere, although in this case we don't actually indent the second line) or maybe some custom heuristic (though I am not keen on adding more of these).

And note that in the OP, the chain is put on multiple lines because it is longer than the chain heuristic value, so the only question is whether `|| disallowed_header_prefixes`` should be on the first line or the second.


Change notifier messager

"Layer traffic_control_officer was deleted"
Remove layer name

For the time being we should avoid adding layer_names to the messages on the notifier since they make the errors very hard to scan.


Packet Manager Ubuntu 15.10

error: NoSources("/SwiftExpress/Packages/CLibvenice-0.4.0/Sources/include")
Installed: postgres
Installed:
echo "deb [trusted=yes] http://apt.zewo.io/deb ./" | sudo tee --append /etc/apt/sources.list
sudo apt-get update
sudo apt-get install libvenice
Installed:
echo "deb [trusted=yes] http://apt.zewo.io/deb ./" | sudo tee --append /etc/apt/sources.list
sudo apt-get update
sudo apt-get install zewo
Any idea on how to make it work? Thanks!

It seems that the Zewo dependencies have moved again, will look into how to resolve this


channels example - Hello message sent/received twice

I couldn't reproduce this on master

I couldn't reproduce this on master


Hi there,
This PR just removes a few trailing whitespaces to quiet git commit warnings.
Let me know if you have any questions on this PR!
-Mark

Awesome, thanks!

I'm sorry Lorenz, it looks like I didn't have my Nuttx module updated and that went in with this PR.  I was just pushing up a commit to fix it, I didn't think you would be so fast.

I've created PR #10543 to correct the Nuttx submodule commit.  I aplogize for making that oversight in the first place.


update to use 'main' instead of master?

The filter step is able to detect my modules (yay!) but I'm getting fatal: ambiguous argument 'master': unknown revision or path not in the working tree., I think because modern repos all use main instead of master ? Not sure if this is in your code or CircleCI's, so feel free to tell me to go make a ticket there instead (or in addition).

Hello @szeitlin , yes this is defaulted to master. I can update it in the next release to main. You can fix this by specifying the default branch, such as
setup: true

orbs:
  dynamic: bjd2385/dynamic-continuation@<version>

workflows:
  on-commit:
    jobs:
      - dynamic/continue:
          context: circleci
          default-branch: main

Default branch of this repo & default branch of the job have been updated. I'll cut a release 3.7.0 with these changes.

awesome, thank you for the fast response!


Issue  #1249 fix - replacing $ placeholders in order when logging

When using the LogMode(true), the SQL produced during the log message…, places the bounded variables in the wrong location, this is due to the fact that the current implementation splits the values with a regex similar to: ($\d+)|?.
That works well for ? placeholders because they should be replaced in order.
However, the numeric placeholders should be replaced based on their value, for instance:
SELECT name,last FROM contact WHERE name=$2 and age=$1
Should NOT be replaced in order, because it will yield an incorrectly formed SQL command, which is not very useful for debugging.
Fixes issue: #1249

@jinzhu  have you had a chance to look into this? it would be great if you could merge this in, thanks

Hi @fobispo-link
Thank you for your PR.


Update README.md

-add a trick for solving an existing problem of incomplete webhook from line to ngrok server.

lgtm


fix: bucket already exists error

Description of changes
Customers sometimes get a deployment error that states that an S3 bucket already exists. More than 1.75% of customers (55 out of 3148) ran into this issue while running push/publish. This error is caused because Amplify storage buckets have a retain policy to prevent accidental data loss and are named by appending the stack ID to the given name. So the issue arrises if a user removes storage and then add it again with the same bucket name.
This PR adds more robust error handeling by throwing an AmplifyError with a suggested remediation.

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #12109 (c21b87e) into dev (984c0f8) will decrease coverage by 3.15%.
The diff coverage is 55.82%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #12109      +/-   ##
==========================================
- Coverage   49.45%   46.31%   -3.15%
==========================================
  Files         692      821     +129
  Lines       33424    37595    +4171
  Branches     6840     7646     +806
==========================================
+ Hits        16529    17411     +882
- Misses      15370    18521    +3151
- Partials     1525     1663     +138

Impacted Files
Coverage Δ

...sync-simulator/src/data-loader/opensearch/index.ts
45.45% <0.00%> (ø)

...s/amplify-appsync-simulator/src/type-definition.ts
100.00% <ø> (ø)

...sync-simulator/src/velocity/util/dynamodb-utils.ts
6.55% <0.00%> (ø)

...y-appsync-simulator/src/velocity/util/map-utils.ts
10.00% <ø> (ø)

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...ync-simulator/src/velocity/util/transform/index.ts
21.05% <0.00%> (ø)

...appsync-simulator/src/velocity/value-mapper/map.ts
86.88% <ø> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

... and 537 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


vertical integration to the free surface

Recently I want to perform an integration of velocity from the bottom to the free surface to get the barotropic velocity.  I've read the document here that gives an example on how to use xgcm.integrate to do this.  Notice that the example integrates to z=0 (the top level), not to free surface.
I think the water volume could be exactly conserved only if the integration is performed to the free surface.  Although this may not be a big deal if long-time average is used.  Just to be exact.  So is it possible to do it like this: add ETAN (sea level height anomaly) to drW[0] and then perform the integration in a similar way:
ds['drW2'] = ds.drW # is this a deep copy?
ds['drW2'][0] += ds.ETAN

ubt = (ds.UVEL * ds.drW2).sum('Z')

That heavily depends on which vertical coordinate system is used.
I am not sure what the example uses but if it is a z (not z*) coordinate system, then you are right in adding the surface elevation.
I personally have dealt with a lot of z* model output (MOM5) and there you have to infer the vertical cell depth as a function of (x,y,z,t) using something like this.
 The values of the depth dimensions are then only approximate but the budgets should be conserved. There are still issues with time averaging, but adding the surface should be a good first step.

Thanks @jbusecke.  My data are on a z coordinate so I'll just add the surface elevation to get the right dz.
I happen to have a dataset from CM2.1 in which the coordinates are ['st_ocean', 'yt_ocean', 'xt_ocean'] (just the dataset no model info).  Is there any simple way to justify what kind of z-coordinate (z or z*) the data are defined on?  Could it be z* if the metrics are time varying?  If I understand it right, the model-output in case of z* would be more disk-consuming than that of z if we add more metrics variables?

Oh sorry just realized I never answered to this. I am pretty sure CM2.1 is run in z* coordinates. But I am not sure what a general way to determine this is...There are ways to reconstruct the time/space variable cell thickness (and thus the actual cell depth) if they werent saved, but the best thing is to output e.g. budget terms integrated over the cell depth.
For the examples, the cell depth should take care of any variability, so I think we could close this?

Hi @jbusecke, thanks for your explanation.  So cell-weighting is important to generalize the flux calculation in different grids.


Feature - Custom Positions

It is really annoying being stuck to the limiting default positions built into Magic Mirror. I would like to be able to set custom X and Y values for positioning modules.

You can use position absolute in the CSS and move your module anywhere you like, regardless of the position setting

can you tell me where you want to move this

i can work on this

Something interesting I've noticed is when I set an absolute position in the CSS, it's still relative to the area and gets messed up when other modules are toggled.

this thread in the forum is an example how to override module positions.
I don't think we will change something concerning the module positions which will break existing mm instances.

@Entropy159

when I set an absolute position in the CSS, it's still relative to the area and gets messed up when other modules are toggled.

that is not correct... absolute is absolute.
see here on how to use the developers console.
https://forum.magicmirror.builders/topic/14862/help-with-a-couple-css-issues?_=1696866322265
you can see and change the classes & styles live..

I have the CSS for the custom positioning, and it looks like this:
#module_14_MMM-TouchButton {
top: 150px;
left: 200px;
position: absolute !important;
}
When I toggle the modules above it, the button moves to the right. I used the developer console, and it's applying the position correctly, but it still seems like it's relative.

yes, you are using the relative dimension tags..  top and left
use x and y

X and Y don't seem to do anything...


Page is an Entity

When building a Foundation doc, one way of representing pages might be to group them in with the rest of the Entities in the doc.
Downstream consumers of fnd.Entity can build up the appropriate document representations using Page's bbox to determine which entities are part of which page.
Why not associate the entities on a page as its children? It might be tricky to serialize such entity types -- protobuf messages aren't meant to be too huge, and a repeated entities field in the Page message could easily grow to thousands of entities large.
Alternatively Page could be a sort of metadata struct -- a foundation Document having its stream of entities as well as a list of Pages. Page could keep its data definition, but not explicitly as an Entity.

Debate/Idea: I actually think a page entity doesn't really need a special reason as to why it doesn't have children. Maybe the way to think about it is that the children are the entities that define the entity. In the case of an Address Entity, it is defined by the OCR words, the zip code, house number, etc... For all word-based entities, actually, it is defined by the words. But for a page, it is simply defined by an image region, or a region in a document, meaning that it does not have any children.
TLDR I want to make sure we don't have entities that are "special cases", and what this PR does makes sense, so I think we need to explicitly define why this makes sense.


What is ScreenPopPath in App.config file?

please help me ...What is ScreenPopPath in App.config of Astray application.can  you please give me a  sample path.

please  help me to solve this issue...

You can find an example in the App.config.example file.
<!-- Screen Popping -->
    <!--  Arguments:
            {callerid-number}    CallerID Number of the inbound call
            {callerid-name}      CallerID Name of the inbound call

          E.g.
          http://crm.mywebste.co.uk/pop?clid={callerid-number}
    -->
    <add key="ScreenPopPath" value=""></add>

https://github.com/skrusty/asttray/blob/master/AstTray/AstTray/App.config.example


Fix issue where null collapse throws a type error

When compiled with typescript the following example from the documentation throws a type error because collapse is sometimes null:
<button id="collapseButton" class="btn btn-primary" type="button" aria-expanded="false" aria-controls="collapseExample"
  data-toggle="collapse" data-target="#collapseExample">
  Button with data-target
</button>

    ...

let myCollapseInit = new BSN.Collapse('#collapseLink')

I've applied the fix to my local repository and will commit as soon as I finish, currently running some code cleanup.
Thanks

I've applied the fix to my local repository and will commit as soon as I finish, currently running some code cleanup.
Thanks


Admin - Login Backend

Sorry for the delay, took longer than expected.

Added admin model.
Added AdminController, hooked it up to the router.
Added Create / Login / Logout.
Tests.

Good job :+1: No other comments from me.


Potential memory leaks addressed

Base on document https://people.freedesktop.org/~aacid/docs/qt5:
Poppler::Document::load

The caller owns the pointer to Document, and this should be deleted when no longer required.

document->page()

The caller gets the ownership of the returned object.

page->formFields()

Returns the form fields on the page The caller gets the ownership of the returned objects.

document->pdfConverter

The caller gets the ownership of the returned converter.

also same as cairo_surface management. create should be destroy also.

Thank you very much for your contribution!


[TASK] Pass Non-Capacity Variables Sampled in Outer Through to Catch in Inner

Issue Description
Is your feature request related to a problem? Please describe.
We need to allow <constant> and <variable> nodes from OUTER to be included in the magic passthroughs to INNER without the user having to update the list.
Describe the solution you'd like
HERON can write this list as arguments to the DispatchManager in a node or something along those lines.
Describe alternatives you've considered
Furthermore, I don't think there's a way to systematically add parametric variables that aren't part of unit descriptions (such as these magic terms) to the HERON input, so that might need to come with the PR.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[ ] 1. Is it tagged with a type: defect or task?
[ ] 2. Is it tagged with a priority: critical, normal or minor?
[ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[ ] 1. If the issue is a defect, is the defect fixed?
[ ] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

I think these could be included in OUTER by adding a new node set to HERON specifically for "additional sampled variables" or something similar.

I think these could be included in OUTER by adding a new node set to HERON specifically for "additional sampled variables" or something similar.


Add details to metadata.json

The metadata.json file is reasonable, but needs more details before pushing to the Forge.

Should add a requirements section, which commently is used to show compatibility with Puppet and PE versions.
  "requirements": [
    {
      "name": "pe",
      "version_requirement": "3.x"
    },
    {
      "name": "puppet",
      "version_requirement": ">=2.7.20 <4.0.0"
    }


Bug fix for document_store.py

Fixed a bug where we ensure that a doc isn't already in our new_documents array before we consider adding it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BUG] Incorrectly encoded Repositories key in Nominee JSON

@nathanfletcher @lacabra  In an attempt to resolve the CI failing on https://github.com/DPGAlliance/publicgoods-candidates/pull/936, I got the above error which shows the repositories payload is not generated correctly i.e. it duplicates the repositories key. The new culprit seems to be here, but suprisingly the form renders perfectly. The above bug has been propagated to recently created PR Aajeevika

A couple of trial and error attempts show that using this convention (name & url) for naming variables versus repositories.name & repositories.url yields correct JSON structure.

PS: This issue continues the discussion that started on #98

I'm wondering if it may be because the schema that tests the nominee JSON still has the repositoryURL key and still checks for it. Initial thoughts.

Fixed through #101


Monitor Events of IoT Hub functionality

Be able to view all JSON events being sent to IoT Hub given through connection string.
Following #13

Optional: we can add a direct link to the metrics page in iothub to verify the flow of events received.


Add system-level PRBS test from FFE output

Once issue #70 is resolved and we have a more system-level test of PRBS function (working directly from the ADC output), then we can move on to testing the PRBS checker functionality using the FFE output as input.

This is checked with cpu_system_tests/mm_cdr


[Unity][Pass] BindSymVar pass

This PR introduces an utility pass that binds symbolic variables to user-provided integer values.
For example, say we have a following IRModule.
@tvm.script.ir_module
class Before:
  @R.function
  def main(
    x: R.Tensor(("m", "n")),
    y: R.Tensor(("m", "n"))
   ) -> R.Tensor(("m", "n")):
      m = T.Var("m", "int64")
      n = T.Var("m", "int64")
      with R.dataflow():
        out = R.matmul(x, y)
        R.output(out)
      return out

We can conveniently bind the symbolic variable by applying After = relax.transform.BindSymVars("main", {"m": 10, "n": 10})(Before).
@tvm.script.ir_module
class After:
  @R.function
  def main(
    x: R.Tensor((10, 10)),
    y: R.Tensor((10, 10))
   ) -> R.Tensor((10, 10)):
      with R.dataflow():
        out = R.matmul(x, y)
        R.output(out)
      return out

This would be useful when specializing shape and providing compile-time shape info (e.g., model params or batch sizes) by eliminating the need to rewrite the model.
cc. @tqchen @psrivas2

@tvm-bot rerun

Closed as it is merged with another PR https://github.com/apache/tvm/pull/15509


noscript fallback?

Thanks for your hard work on docs.rs!
I really liked how the previous version(s) of docs.rs didn't need javascript to render essential content.
Is there an option to make the new docs.rs not require javascript to render (what seems to be 100%) static content?

What isn't working with the noscript?

@GuillaumeGomez The following doesn't show the "Methods"/"Implementations" sections with Javascript disabled in my Chrome browser:
https://docs.rs/slab/0.4.2/slab/struct.Slab.html
I see an error in the console that the following file was not found, maybe that's the problem?
https://docs.rs/noscript-20190110-1.33.0-nightly-c2d381d39.css

Oh I see. Opening an issue on rustdoc about it.

This is fixed in latest docs.rs, see e.g. https://docs.rs/odrive-rs/0.1.0/odrive_rs/ascii/struct.ODrive.html. Fixing slab/0.4.2 would require #464 which is separate from the problem itself.

@GuillaumeGomez @jyn514 Unfortunately this appears to still occur, at least in the ODrive example you provide.
The following sections still have "display: none" set:

Trait Implementations
Auto Trait Implementations
Blanket Implementations

With the last version of ODrive?

@GuillaumeGomez Thanks for the quick response. I think it's an issue with how Chrome and uBlock Origin interact. I don't know the root cause.
If I disable Javascript in the Chrome tab, and disable Javascript in uBlock Origin, the page does not render fully.
Any other combination of enable/disable causes the page to render fully.
I suspect that a lot of Rust users use ad blockers, so it might be worth keeping an eye on this. However, I don't know the root cause.


docs: add "troubleshooting" for macOS

Signed-off-by: HaoTu<EMAIL_ADDRESS>Commit Message: add "trouble shooting" for macOS
Additional Description:
Risk Level:
Testing:
Docs Changes: https://github.com/envoyproxy/envoy/blob/main/bazel/README.md
[Optional Fixes #Issue] Fixes #20046

The format check fails with the following suggestions:
##[error]: TESTS FAILED:
##[error]:  main@ /source/ci/format_pre.sh :47 (glint)
##[error]:      Please fix your editor to ensure:
##[error]:        - no trailing whitespace
##[error]:        - no mixed tabs/spaces
##[error]:        - all files end with a newline

/assign @adisuissa

##[error]: trailing whitespace: bazel/README.md

##[error]: ERRORS found
##[error]: 0 files with missing newline
##[error]: 0 files with mixed tabs and spaces
##[error]: 1 files with trailing whitespace

It seems no line has trailing whitespace 😭  @rojkov @adisuissa

Could you please merge the latest main branch to fix the tests?

/retest

Could you please merge the latest main branch to fix the tests?

Please disregard. No need to merge yet.


Release/2.0.0

Codecov Report

Merging #64 (41c1170) into master (5fe555c) will decrease coverage by 0.21%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   90.08%   89.87%   -0.22%
==========================================
  Files          10       10
  Lines         464      464
==========================================
- Hits          418      417       -1
- Misses         46       47       +1

Impacted Files
Coverage Δ

src/qe_tools/exceptions.py
100.00% <ø> (ø)

src/qe_tools/parsers/_input_base.py
88.21% <66.66%> (ø)

src/qe_tools/__init__.py
100.00% <100.00%> (ø)

src/qe_tools/_constants.py
100.00% <100.00%> (ø)

src/qe_tools/_qe_version.py
100.00% <100.00%> (ø)

src/qe_tools/converters/__init__.py
100.00% <100.00%> (ø)

src/qe_tools/converters/_structure.py
100.00% <100.00%> (ø)

src/qe_tools/parsers/__init__.py
100.00% <100.00%> (ø)

src/qe_tools/parsers/_cp_input.py
100.00% <100.00%> (ø)

src/qe_tools/parsers/_pw_input.py
68.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Wordpress is adding in nbsp after images and messing with the way text is rendered

http://wordpress.stackexchange.com/questions/29702/wordpress-automatically-adding-nbsp here's something about the nbsp
and here are screenshots of the text – it was only happening with text following an image
Text editor:

visual editor

The recommended fix from that article has a couple of comments saying it doesn't work.
Are you switching between visual and text editor mode in WordPress as per the answer below the accepted one? We should be able to do that (I can't imagine editing without doing so), I'm just checking to see if what we are experiencing matches what other people are reporting.

Yes – That's exactly what I'm doing... Even when it looks right in text
mode, it's still messing up in visual mode, which is what the screenshots
are showing.
On Tue, Nov 22, 2016 at 11:03 AM, Rob Myers<EMAIL_ADDRESS>wrote:

The recommended fix from that article has a couple of comments saying it
doesn't work.
Are you switching between visual and text editor mode in WordPress as per
the answer below the accepted one? We should be able to do that (I can't
imagine editing without doing so), I'm just checking to see if what we are
experiencing matches what other people are reporting.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/creativecommons.org/issues/510#issuecomment-262282220,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGw-Tp42AyxQzBdJcXK-KbBib2TcwVHKks5rAxJlgaJpZM4K5j9h
.

--
Jennie Rose Halperin
Communications Manager
Creative Commons
Invest in an open future. Support Creative Commons today:
http://bit.ly/19IjSKl

@little-wow I'm checking old tickets. Is this still an issue?

Closing this since we've upgraded WordPress multiple times since this was filed, please reopen with updated information if needed @little-wow.


Different result on different machines for same input and random seed

Hi,
I am getting different results on different machines for the same inputs and random seed. Though the results on any single machines are consistent.
My questions are -

What might be the possible reasons behind the same?
What can be done to avoid it?

Thanks.

Within the library all sources of random behaviour are deferred to an instance of np.random.RandomState. This is used for random number generation when needed, but is also passed as a parameter to sklearn's GP. I don't know what else can be done, to be honest.

Thanks @fmfn for the quick reply. In that case, Can you please let me know whether you were previously aware of this issue or this is the first time you encountered this via this thread?

Thanks @fmfn for the quick reply. In that case, Can you please let me know whether you were previously aware of this issue or this is the first time you encountered this via this thread?

After np.random.RandomState was added everywhere I imagined this would not be a problem, but never really tested it, to be honest.

To my knowledge the package is setting a seed to all possible sources of randomness that allow for seed control. I suspect scipy.minimize might be the source of problem here, but, as I said, not sure.
Help with debugging this is more than appreciated. I won't have the opportunity to chase this bug down for a little while still.

Yes, I suspect the same. But I don't have time this weekend. I will give it a shot next weekend.

When you know the solution, please post it in the comments, thank you very much!

there is a same problem in skopt.....
https://github.com/scikit-optimize/scikit-optimize/issues/682

@jiayeah9508 Hi, Do you mind sharing the processor information of your two machines on which you have tested the code that you posted in #682?
Specifically, I am interested in the output of the below command. I have a hunch which I need to confirm.
cat /proc/cpuinfo | grep "model name"

OK
the first one is: Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz 2.40GHz
and the second one is Intel(R) Core(TM)2 Duo CPU E7500 @2.93GHz 2.94GHz

I used windows system so I can not cat...
the  first one is Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz 2.40GHz
and the second one is Intel(R) Core(TM)2 Duo CPU E7500 @2.93GHz 2.94GHz
I wonder if it meets your requirements~

Yes, this is what I needed and this strengthened my hunch. Here is what I feel about the underlying problem.
The Root cause I believe is the underlying instructions set of the machine. Older machines which are configured to use SSE4.2 instruction set behave differently than the new ones using AVX. It is possible that numpy/scipy operate differently under these instructions set. I am not still 100% sure about this hunch since I do not have access to a SSE4.2 only machine.
The first time I encountered this bug was on running test cases on a jenkins server to which I do not have an SSH access. I will try to get access to the server and see if my current hypothesis is correct or not.

For reference, this link might help which points at the same problem.

How about AMD processor?
optimization becomes more and more important for deeplearning...
That seems like bad news for Intel,haha..,


Add fp32 to the set of valid inputs to attention layer

Description
Add fp32 to the set of valid inputs for attention layer.
Note:

flash attn is incompatible with torch.float32 🔴
torch attn is compatible with torch.float32 ✅

Tests:

Before:  full-eval-fp32-train-fp8-llama3-8b-metamath-4ep-ObqlFj  🔴

mixed_precision: full

After: torch-attn-full-eval-fp32-train-fp8-metamath-4ep-pmGJKN ✅

mixed_precision: full

Tested manually, there is no unit test for this.

@j316chuck I don't think this is correct. Flash attention does not support fp32 (unless that changed recently?)


Fix GitHub Action

The GitHub Action fails because of ExperimentalCoroutinesAPI usages at the build iOS step. This PR resolves this issue by adding the necessary compiler arguments.

The warning for the Android build can be removed as well by adding the same Compiler Option, but it does not cause the build to crash.

Thanks for that.  It had seemed to be failing intermittently for some reason but hadn't had chance yet to check why.


Tooltip position wrong when there is horizontal scrolloffset v3.3.7

It seems that if we have the window page smaller enough that there is an horizontal scroll bar, the position of the tooltip when we mouse over the text,  will be wrongly affected, as we can see in the picture:

The problem seems to be the applyPlacement method:
` Tooltip.prototype.applyPlacement = function (offset, placement) {
var $tip   = this.tip()
var width  = $tip[0].offsetWidth
var height = $tip[0].offsetHeight
// manually read margins because getBoundingClientRect includes difference
var marginTop = parseInt($tip.css('margin-top'), 10)
var marginLeft = parseInt($tip.css('margin-left'), 10)

// we must check for NaN for ie 8/9
if (isNaN(marginTop))  marginTop  = 0
if (isNaN(marginLeft)) marginLeft = 0

offset.top  += marginTop
offset.left += marginLeft

// $.fn.offset doesn't round pixel values
// so we use setOffset directly with our own function B-0
$.offset.setOffset($tip[0], $.extend({
  using: function (props) {
    $tip.css({
      top: Math.round(props.top),
      left: Math.round(props.left)
    })
  }
}, offset), 0)

$tip.addClass('in')

// check to see if placing tip in new offset caused the tip to resize itself
var actualWidth  = $tip[0].offsetWidth
var actualHeight = $tip[0].offsetHeight

if (placement == 'top' && actualHeight != height) {
  offset.top = offset.top + height - actualHeight
}

var delta = this.getViewportAdjustedDelta(placement, offset, actualWidth, actualHeight)

if (delta.left) offset.left += delta.left
else offset.top += delta.top

var isVertical          = /top|bottom/.test(placement)
var arrowDelta          = isVertical ? delta.left * 2 - width + actualWidth : delta.top * 2 - height + actualHeight
var arrowOffsetPosition = isVertical ? 'offsetWidth' : 'offsetHeight'

$tip.offset(offset)
this.replaceArrow(arrowDelta, $tip[0][arrowOffsetPosition], isVertical)  }  `

This is probably related to elements with specific width values too and regarding the possible solution
It seems if i comment the last two lines of the method it fixes the position.
Here's the example i've created with bootstrap 3.3.7 version:
boostrap -3.3.7 example tooltip.zip

Bootstrap v3 is unfortunately no longer officially supported.
See https://github.com/twbs/bootstrap/blob/v4-dev/README.md#community for links to our community support forums.

Hi! Isn't the v3.3.7 the latest final release?

See #20631.

I too am suffering from this bug, and its siblings, in v3.3.7.
Given that v3 is now in "critical fixes only" mode, is there any wisdom on a workaround - CSS, or JS or both?

Yes,
My solution was, go to the method  Tooltip.prototype.applyPlacement in bootstrap.js, and either comment the last two lines or create a condition to only use them in case there is no left scrolloffset:
if($( document, window ).scrollLeft()===0){
$tip.offset(offset)
this.replaceArrow(arrowDelta, $tip[0][arrowOffsetPosition], arrowPosition)
}

Probable duplicate of #15590.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-04-16)
Features

add ErrorEntity + ErrorCommon (ae2faa6)
add hash tool (4ea19e4)
add I18n tools (7944679)
add main file to cli for later (ef18d2a)

Build System

check if tsconfig.tsbuildinfo before delete him (cf8dfa4)
setup build environments (9045b1f)
Update .npmignore, .gitignore, .eslintrc, and package.json (5b701ba)
update packages (7b041e2)

Tests

add test for ErrorCommon (5b4c92a)
add tests for ErrorEntity (956ff73)
add unit test for hash (e551e2d)
add unit tests (e30f312)

Continuous Integration

add workflows (f40049c)
update command build in workflow (3fd2a08)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Andesite-Lab/Core/releases/tag/v1.0.0 :sunflower:


Log crash tracebacks to file

Added

Unexpected exceptions are caught and tracebacks logged to wificom_log.txt in CIRCUITPY. File rotated to wificom_log_old.txt according to size. Reboot made easier after a crash.

The problem here is that the computer doesn't display the updates to CIRCUITPY until the drive is reconnected.

During "Hold C to reboot" I think the screen isn't reacting until the button is released causing me to enter dev mode when I do eventually release


Add hover effect on button

Issue Type:

[x] Feature Request

Description

Want to add some styling (hover effect) in the button of Animated UI Design.

Screenshots

There's no hover effect.

hello ,can i get myself assigned to this issue?

@VidhiBhatt01 Hey, I think I unassigned myself mistakenly. Can you please reassign me?


Support user-friendly browsing of the mutants that Dredd has created

At present, Dredd mutates the given program source files and provides no information about the mutants that it applied. You can diff the source files with their original versions, but because the changes Dredd makes are so intrusive, it is difficult to understand the form of the mutants in this way.
Dredd could emit a mutation database: a JSON file with one entry per mutant, providing details of:

The location in the unmodified source file at which the mutant has been applied
The text of the relevant range in the source file before mutant application
What said range would look like had the mutation been applied in place, rather than being hidden under Dredd's conditional switch
Other information such as the mutation operator that was applied, and mutants that are mutually incompatible with the mutant (in the sense that it would not be possible to simultaneously enable them, e.g. because they apply to the same operator, or one removes a statement that the other mutates)

Scripts could then be written to allow this database to be queried in useful ways.

#111 makes a start on this, by emitting a JSON file.

Plan for this issue:

[ ] Change Dredd so that a protobuf binary blob is emitted instead of JSON. The JSON can get very large for big projects.

Write a tool that processes the binary blob to allow various queries, including:

[ ] How many mutants are available?
[ ] For a given mutant, which mutants are incompatible with it, because they have a parent-child relationship in the mutation tree? (The idea here is to avoid simultaneously enabling mutants that are likely to interfere with each other)
[ ] For a given mutant, show a summary of the effect that it has (based on the snippets in the protobuf data)

The tool should provide a Python API for these queries, so that it can be linked up with other scripts, as well as providing a command-line version to make browsing easier.


Transfer account functionality, login overhaul

Users can now transfer their account to another phone
Once logged in, that account is saved on the device

Go to the profile page to generate a code. The code will be newly generated if one does not already exist in the database, otherwise it just displays the one previously generated. You can put your transfer code on another phone in the login page, and if it will delete the code from the DB and log in as that user who generated the code on the phone you're transferring to.

The plan is to remove the login button on the login page but I will do this tomorrow because we should keep a login feature to help us test our app. Logout buttons for both CP and Patient have been added as well to help us test.

Note that there is duplicate code in SplashActivity and LoginActivity but this will be refactored out when I remove the normal login functionality.

We'll need to merge RegisterActivity and LoginActivity eventually, but it looks fine for now