Use reserved ports for LocalFirstPolicyIntegrationTest

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6023/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6789/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6791/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6793/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6795/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6797/
Test PASSed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6799/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/8561/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/9431/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder-jdk11/37/
Test FAILed.


increase width of textarea to be 50% of the page

Set the width of all editable fields on the page to 50%.
Textarea height is set to default but can be increased by manully dragging it.

Verified.


Clicking An Element

Issue Type: Feature Request
VS Code can be a little bit of confusing, and it has a lot of good staff in the vs code but,, the most important fix that most of us wants is element highlights.
example:

VS Code version: Code 1.32.3 (a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4, 2019-03-14T23:43:35.476Z)
OS version: Windows_NT x64 10.0.17763

@MisterJ936 this actually exists already for HTML. In the bottom right corner of VS Code there is a Language Mode option. Yours is set for PHP. If you set it for HTML you will get the highlighting behavior you want.
@roblourens possible PHP feature request?

@alexr00 I also did that but still highlights every element, see image bellow

@MisterJ936 you might find this extension useful https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client

thanks!
On Thu, Apr 4, 2019 at 1:05 PM Rob Lourens<EMAIL_ADDRESS>wrote:

Closed #70810 https://github.com/Microsoft/vscode/issues/70810.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/70810#event-2251770842, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AeNXAwobms6cd4AvqH9J8aNSJEo7rZsNks5vdYg0gaJpZM4b-uVz
.


Implemented the suggestion box clipped border radius feature.

I've added a ClipRRect at two places so that we can add a cropped border radius to the suggestionBox. This is necessary so that the inner content of the suggestion box is cropped too.
If only relied on the box decoration of the suggestion box, we could add rounded corners, but the suggestion items separators for example, would be shown outside of the box at the corners.

Looks like the tests are failing, You may verify this locally by running flutter test or make an empty commit for the checks to run on github.

@romain-pattyn I am closing this PR due to lack of inactivity. Incase you want to work on this PR again feel free to write back and I would be happy to reopen and review.


[FEATURE] Better hover effect in the footer section

Description
Hey @apoorvaron , I want to add better hover effects to the footer section icons
Can you please assign this to me as a GSSOC'23 contributor
Screenshots
No response
Additional information
No response

@Aditi323 , No need of it. Please find improvement in functionality.
Thanks


Introduce LF ending for commits & check out

Is the idea that people can copy this into their project directories? Or can we use symlinks?

The idea is to use symlink like the symlink to .clang-format file.

Is the idea that people can copy this into their project directories? Or can we use symlinks?

My idea is to use a symlink to dev-tools/.gitattributes. (like we use a symlink to .clang-format)


Update dependency

Update dependency

Closing this one as I've created a new PR with proper upgrade #35


cmd/server: lookup individual and entiy SDNs from Watchman

When doing OFAC searches for a Customer these will either be an individual or entiy (corporation) and never something like a vessel. We need to add those filters to searches and find which matched higher.

Codecov Report

Merging #68 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   61.06%   60.89%   -0.18%
==========================================
  Files          16       16
  Lines        1739     1790      +51
==========================================
+ Hits         1062     1090      +28
- Misses        528      544      +16
- Partials      149      156       +7


Fix spelling errors in specification and enable spellchecking in CI

This PR adds a spellcheck to the audit tests run by the CI.
Previously, had make audit_spelling, which launched an interactive aspell session. This clearly hadn't be run for a while, as a few minor spelling errors had crept into the specification. To remedy this, this PR does the following:

[x] Changed make audit_spelling/make spell to call aspell non-interactively, returning a list of suspected spelling errors. This is now run in the CI.
[x] Created a new make target make fix_spelling that calls the previous interactive aspell.
[x] Used the aforementioned make fix_spelling to update the specification and the allowed .words.lst (see the diff for 9c42850 for new words added to .words.lst, the overall PR diff is messy as it also includes automatic sorting .words.lst file by aspell).

Does anyone else have time to review this?

However, I've reviewed this as a Comment, since I am confused about the results of the spell audit CI (see the messages here) from the latest check.
Some files are missing/not found and is it actually changing stuff, but still exiting with return code 0?

Well spotted, unfortunately this has been the case in the CI for a while. There is some Makefile magic going on before the tests actually run that (I think) extracts parts of the specification to be tested as filters, but this seems to have been broken for some time (see e.g. https://travis-ci.org/github/Materials-Consortia/OPTIMADE/builds/704036295) and I didn't want to break it further in this PR...

There is some info about the GNU make build system we have in the discussions around PR #195 that covers why there is "unrelated printout" when running make on rules like, e.g., spellcheck. But, in short, the make system dynamically generates make rules which requires these commands that extracts info from the specification to run before anything else runs.
I don't have any idea why they seem to fail in this case, though.

About the review of this PR: if I read the code correctly, it does not avoid spell-checking code blocks etc. I've previously argued not to add spellcheck to the automatic audit until we handle skipping over code sections (https://github.com/Materials-Consortia/OPTIMADE/pull/122#pullrequestreview-249928842). Are we okay with every PR that edits code having to deal with the aspell wordlist?


Problemdetailsmiddleware

Fix for this issue https://github.com/dotnet/AspNetCore.Docs.Samples/issues/60 @Rick-Anderson

@sammychinedu2ky  normal work flow is after a PR is merged you:
git checkout main
git pull origin main
git checkout -b MyNewBranch

Then you get a cleaner PR without all the old commits.

@sammychinedu2ky normal work flow is after a PR is merged you:
git checkout main
git pull origin main
git checkout -b MyNewBranch

Then you get a cleaner PR without all the old commits.

alright thanks. sorry about that was a mistake from my end

I have reverted it @Rick-Anderson

Thanks for the quick solution and code.

My pleasure. Thanks @Rick-Anderson


Apply tensor modify update to given field value.

@geirst: please review

Will open a new pull request for merging to a different branch.


Added count param to phrase param and return plural form accordingly

Details
This PR added a count parameter to the phrase parameter to return the plural form when necessary. Also In this PR we
updated the types to support PluralizeValues and refactored the code so that all translation functions now use a single object containing all the necessary parameters
Fixed Issues

$ https://github.com/Expensify/App/issues/38614
PROPOSAL:
Tests

Open App
Open few screens and verify that the translations are displayed correctly.

[x] Verify that no errors appear in the JS console

Offline tests

Open App
Open few screens and verify that the translations are displayed correctly.

QA Steps

Open App
Open few screens and verify that the translations are displayed correctly.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/689b6246-38ed-4817-bc4d-561014d5fe46

Android: mWeb Chrome
https://github.com/user-attachments/assets/8913de4b-3e41-4948-9316-a3b35b17dee8

iOS: Native
https://github.com/user-attachments/assets/2566276d-c473-42c8-8ac6-4983a2641a07

iOS: mWeb Safari
https://github.com/user-attachments/assets/bfbd100f-9cfe-40f7-9ad9-db1bdb6dd5d1

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/02009ece-be40-4b89-97e2-87452d3af9a7

MacOS: Desktop
https://github.com/user-attachments/assets/c8b5f7d1-68ca-46d6-8a4c-e9c641df7878

Assume this needs no design review? If so, let me know and I'll check it out :)

@blazejkustra And have you noticed its not giving any error on using Array as output? Example: mmk: ['jjkkkjk', 'bb2'],
And add a key in en.ts, and not in es.ts, and linter does not complain

Will look into it tomorrow morning, interesting. Have you found any other edge cases? @shubham1206agra

@ZhenjaHorbach Meanwhile could you have a look at this commit? I moved all params to a separate file params.ts, and renamed/added useful comments to existing type helpers. I think it would be nice to apply some of these changes here, what do you think?

@blazejkustra And have you noticed its not giving any error on using Array as output? Example: mmk: ['jjkkkjk', 'bb2'],
And add a key in en.ts, and not in es.ts, and linter does not complain

Will look into it tomorrow morning, interesting. Have you found any other edge cases? @shubham1206agra

Oh, sorry
My fault
Today I also noticed this issue
Here is an example of my fix
https://github.com/Expensify/App/pull/48229/commits/554611ccf0914458a49e4eef0a342516b3fe958d#diff-d5ecc5286b0686d54ec1fb926d76a79a5d8ecaeaed8a2366c7c9ce37a1ffabecR298

@ZhenjaHorbach Meanwhile could you have a look at this commit? I moved all params to a separate file params.ts, and renamed/added useful comments to existing type helpers. I think it would be nice to apply some of these changes here, what do you think?

I will check today or tomorrow morning !

@ZhenjaHorbach Meanwhile could you have a look at this commit? I moved all params to a separate file params.ts, and renamed/added useful comments to existing type helpers. I think it would be nice to apply some of these changes here, what do you think?

About this
Changes looks good !
But I see we have a couple of errors
If we have an object with params that has optional values
I think it's okay if we don't pass the object itself
At the moment we are required to pass an empty object
title={translate('iou.deleteExpense', {})}

@ZhenjaHorbach fixed it in the latest commits on my PR

@ZhenjaHorbach One more commit to fix the last TS error - I adjusted the logic inside of getTranslatedPhrase function

We are really close to the final solution, great job!

I feel it 😀
Only this issue remains
https://github.com/Expensify/App/pull/48229#discussion_r1755276048
And this
https://github.com/Expensify/App/pull/48229#issuecomment-2344374348
First part i fixed
But about second I am not sure
Not sure how best to fix this
Because our objects with translations may differ slightly
Since the Spanish translation may have additional values (For example allCountries and allStates)

We are really close to the final solution, great job!

I feel it 😀
Only this issue remains #48229 (comment)
And this #48229 (comment)
First part i fixed But about second I am not sure how best to fix this Because our objects with translations may differ slightly Since the Spanish translation may have additional values (For example allCountries and allStates)

Let me look for a fix 👀

Oh, I forgot to look into it today, will do first thing in the morning, sorry!

And add a key in en.ts, and not in es.ts, and linter does not complain

diff --git a/src/languages/es.ts b/src/languages/es.ts
index 3454fd47dd4..3c66c5d20b4 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1,5 +1,6 @@
 import {Str} from 'expensify-common';
 import CONST from '@src/CONST';
+import type en from './en';
 import type {
     AccountOwnerParams,
     ActionsAreCurrentlyRestricted,
@@ -194,7 +195,7 @@ import type {
 import type {TranslationDeepObject} from './types';

 /* eslint-disable max-len */
-const translations = {
+export default {
     common: {
         cancel: 'Cancelar',
         dismiss: 'Descartar',
@@ -5414,6 +5415,4 @@ const translations = {
         time: 'Hora',
         none: 'Ninguno',
     },
-};
-
-export default translations satisfies TranslationDeepObject<typeof translations>;
+} satisfies TranslationDeepObject<typeof en>;

@blazejkustra And have you noticed its not giving any error on using Array as output?
Example: mmk: ['jjkkkjk', 'bb2'],

Can't reproduce it @shubham1206agra 🤔 It's giving me an error:

Cool! This means all issues should be now resolved, let's aim to merge this bad boi finalyl 😄

We can ignore Changed files ESLint check on this one 👍

Since I may need to enforce count key to pluralized translations.

Could you give an example for it?

Both of these keys are in fact invalid because other has to be a function:
type PluralForm = {
    zero?: string;
    one: string;
    two?: string;
    few?: (count: number) => string;
    many?: (count: number) => string;
    other: (count: number) => string;
};

These are valid keys:
    key1: ({additionalProp}: {additionalProp: string}) => ({
        one: `1 b ${additionalProp}`,
        other: (count: number) => `${count} bs`,
    }),
    key2: () => ({
        one: '1 b',
        other: (count: number) => `${count} bs`,
    }),

You don't need to pass count as parameter because count is passed in the nested function to comply with Intl.PluralRules

@ZhenjaHorbach can you check the 2 failed checks please?

Oh, can you also pick some existing translation, for example these ones and change them to use the new pluralization methods?
Just to leave as an example in real code.
I think I will create a new issue later to remove all usages of Str.pluralize which should not be needed anymore

Since in this case only TS will break on main after merging PR with wrong format of translates

Not sure I follow. Are you saying that if you call translate(key, 'one', 'two') it would still work?

This will be done by me in https://github.com/Expensify/App/pull/45892

Ah nice!

Yes

Ah nice, thanks for checking and explaining!

We are skipping ESLint checks because this PR is touching 76 unrelated files and fixing all the previously existing lint errors would make this PR riskier.
Thanks so much for this, great job!!!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


[feature] consider using fancy-regex to support look-around and backtracking

⭐ Suggestion
Currently ast-grep regex support is missing a couple of features

The regular expression is written in Rust syntax, not the popular PCRE like syntax. So some features are not available like arbitrary look-ahead and back references."

However, there is this fancy regex crate that implements "look-around and backtracking" https://github.com/fancy-regex/fancy-regex, so it might be better to use that instead of the default regex
💻 Use Cases
Same use cases where you'd use regex, but richer and allowing for better matches

Hi, thanks for the suggestion.
fancy-regex looks like not as mature as regex. I would await more feedback and benchmarks about fancy-regex for its integration.

From fancy-regex's README

Still in development, though the basic ideas are in place. Currently, the following features are missing:

The status is committed 7 years ago...

Well, you could get feedback and benchmarks in the most important use case - AST-grepping - by adding that as an optional engine :)
Though from my "searching end user" perspective the issues linked are dwarfed by the lack of look-ahead and back-references, those I use often in alternative engines, and it's a big limitation of the "production ready" Rust's default one (even if the back-references,bugs in cases like [\042\223\224\262\263\271]{2}\S{0,16}[\042\223\224\262\263\271]{2} that I'll never encounter and some fuzzed incantation I'll also never use fails)


System order may cause ParticleSystem to play twice

While playing around with this crate, I found that some runs of my app will have a ParticleSystem play twice despite only spawning a single system. One of these systems will play at the spawned transform and the other plays at the world origin. These two systems play at the same time.
Bevy by default randomizes the execution order of systems registered in the app. My impression is that some order of the particle system systems may cause the double play. haven't dug too deeply into the code to make any more specific guesses as to where things are going wrong. It can take a few reloads of the app to see the behavior pop up.
It's possible that I'm doing something wrong on my end, but my basic printf debugging shows that I only spawn a single ParticleSystemBundle every time and when this bug shows up, it happens every time I spawn a bundle. I'll try to set up a minimal example to confirm this.

Could not reproduce in the MRE, most likely my fault then. Apologies.


Add the ability for ribbon clients to specify response status codes they would like to retry

Fixes #1540.
Build will fail until spring-cloud/spring-cloud-commons#197 is merged

Meeds to be merged to 1.2.x as well

Codecov Report

Merging #1836 into master will increase coverage by 0.27%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1836      +/-   ##
==========================================
+ Coverage   75.18%   75.45%   +0.27%
==========================================
  Files         204      205       +1
  Lines        6286     6270      -16
  Branches      791      783       -8
==========================================
+ Hits         4726     4731       +5
+ Misses       1220     1199      -21
  Partials      340      340

Impacted Files
Coverage Δ

.../cloud/netflix/ribbon/RibbonAutoConfiguration.java
90.9% <ø> (ø)
:arrow_up:

...tflix/feign/ribbon/RetryableFeignLoadBalancer.java
96.66% <100%> (+0.23%)
:arrow_up:

...bon/okhttp/RetryableOkHttpLoadBalancingClient.java
74.28% <100%> (+2.41%)
:arrow_up:

...x/ribbon/RibbonLoadBalancedRetryPolicyFactory.java
100% <100%> (+4.34%)
:arrow_up:

...apache/RetryableRibbonLoadBalancingHttpClient.java
86.66% <100%> (+1.3%)
:arrow_up:

...x/ribbon/support/RetryableStatusCodeException.java
100% <100%> (ø)

.../netflix/ribbon/RibbonLoadBalancedRetryPolicy.java
83.33% <83.33%> (ø)

...ngframework/cloud/netflix/zuul/RoutesEndpoint.java
93.33% <0%> (-6.67%)
:arrow_down:

...rk/cloud/netflix/eureka/EurekaDiscoveryClient.java
52.63% <0%> (-1.22%)
:arrow_down:

...ork/cloud/netflix/zuul/ZuulProxyConfiguration.java
63.41% <0%> (-0.88%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62408af...6290859. Read the comment docs.


#3 Added Inception quote

Issue #3
Added famous Inception quote: "An idea is like a virus...."
npm test showed no duplicates

I know i changed a few spaces, but I think it looks more clean now.
Should I change that?

@ryuakaa awesome. Thanks


HMR not working with imported CSS (Module) files

Describe the bug
Editing CSS Module files that are imported in .svelte components causes a full page reload, while hot-reloading is expected (and demonstrably possible, but more on that in the "Additional information" section).
Before somebody asks "why aren't you using the <style> tag directly in your Svelte components and taking advantage of Svelte's built-in CSS scoping?", because they are not good enough, and I'm not alone in thinking that.
Reproduction

Clone https://github.com/aradalvand/sveltekit-hmr-css-test
Run pnpm install
Run pnpm run dev
Go to the src/lib/Button.module.css file, and change the background-color to blue.
Save the file.
Notice how a full page reload is triggered in the browser

Logs
No response
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 7.21 GB / 11.63 GB
    Container: Yes
    Shell: 3.6.1 - /home/linuxbrew/.linuxbrew/bin/fish
  Binaries:
    Node: 20.6.0 - /home/linuxbrew/.linuxbrew/bin/node
    npm: 9.8.1 - /home/linuxbrew/.linuxbrew/bin/npm
    pnpm: 8.7.1 - /home/linuxbrew/.linuxbrew/bin/pnpm
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.1.0
    @sveltejs/kit: ^1.20.4 => 1.26.0
    svelte: ^4.0.5 => 4.2.2
    vite: ^4.4.2 => 4.5.0

Severity
annoyance
Additional Information

Put the following code in the <script> section of your root +layout.svelte file (or, in the repro app linked above, it could be in the +page.svelte file):

if (import.meta.hot) {
    import.meta.hot.on('vite:beforeFullReload', () => {
        throw '(skipping full reload)';
    });
}

Make a change to the Button.module.css file again (change the background-color back to red), and save the file.
At this point, if you look at the browser console, you'll see Uncaught (in promise) (skipping full reload), as expected; the full page reload is prevented.
Now, make a meaningful change (not just whitespace, change the button's label for example) to the Button.svelte file, and then save the file.
Back to the browser, you can see that the new CSS change has been hot-reloaded as well. I think this showcases that HMR for these CSS files is perfectly possible, so this has to be a matter of misconfiguration or something similar on the part of SvelteKit.

Let me know. Thanks.

I'm also encountering this issue. We (unfortunately) have to edit global css files in our SvelteKit project and the full reloads are a killer. It appears as if SvelteKit hot reloads first, and then follows with a full reload. Is that expected behavior?

I got the same issue as you @john-michael-murphy
I import my global css in my +layout.svelte file and whenever I make change to the css the page reload. I expect svelte+kit+vite to be able to handle hot reload by swapping css

We have this problem as we use a global scss file.
I monkey patched kit, this line: https://github.com/sveltejs/kit/blob/<EMAIL_ADDRESS>- !(query.has('raw') || query.has('url') || query.has('inline'))
+ !(query.has('raw') || query.has('url') || query.has('inline') || query.has('noinline'))

and then in my +layout.svelte, the following change:
- import "../scss/app.scss";
+ import "../scss/app.scss?noinline";

TL;DR: I made sveltekit ignore inlining the css when that particular search param noinline exists.
Seems to be working well.

Thanks @ekhaled !
I can confirm it works.
Is that something we should merge in somehow ?

Thanks @ekhaled ! I can confirm it works.
Is that something we should merge in somehow ?

Feel free to create a PR.
I'll see if I can create one when I have a bit of time in hand.
@dummdidumm do you think this is something that might get accepted into core?
I'm sure a lot of people use global css with sveltekit. And this does increase productivity a lot when building site templates etc.

We have this problem as we use a global scss file.
I monkey patched kit, this line: https://github.com/sveltejs/kit/blob/<EMAIL_ADDRESS>- !(query.has('raw') || query.has('url') || query.has('inline'))
+ !(query.has('raw') || query.has('url') || query.has('inline') || query.has('noinline'))

and then in my +layout.svelte, the following change:
- import "../scss/app.scss";
+ import "../scss/app.scss?noinline";

TL;DR: I made sveltekit ignore inlining the css when that particular search param noinline exists.
Seems to be working well.

Wow this is sooooo cool!! Still working with @sveltejs/kit v2.5.20, svelte v4.2.18 and vite v5.3.5.
No PR yet? I am not familiar with the Svelte/Kit codebase, so I would be afraid to (move fast and) break things in unexected ways, but I'm very excited to see it seems to be just around the corner!

There is this library called patch-package which can be used to to automate the patching on postinstall.
Your would end up with something like this structure:

I'm also including the patch file, I'm sure it will help.
The name of this patch file matters. Please read up on the patch-package docs.
@sveltejs+kit+2.5.18.dev.patch

There is this library called patch-package which can be used to to automate the patching on postinstall.

Awesome thanks! I was trying to setup something similar! :)

Just found out about pnpm patch command in the patch-package readme.

Run pnpm patch <package> :

$ pnpm patch @sveltejs/kit
Patch: You can now edit the package at:

  /tmp/e86e895e5b7d2b3e21ca36d5c57bdc19

To commit your changes, run:

  pnpm patch-commit '/tmp/e86e895e5b7d2b3e21ca36d5c57bdc19'

Edit relevant file (here src/exports/vite/dev/index.js) and save
Commit patch :

$ pnpm patch-commit '/tmp/e86e895e5b7d2b3e21ca36d5c57bdc19'

This gets added to package.json :
{
        "...": "...",
	"pnpm": {
		"patchedDependencies": {
			"<EMAIL_ADDRESS>"patches/<EMAIL_ADDRESS>		}
	}
}

IDK yet about maintenance and updates but it look great for now!


Updated properties in security_policy for client 14.x

version 0.3.8
changed property calls to use new_resource. in place of
removed unnecessary string interpolation
updated line 41 to use property policy_template instead of local variable (undefined?) template

This PR addresses issue https://github.com/grdnrio/windows-security-policy/issues/25


Drop AppEngine text from README

dart-services no longer supports AppEngine as a deployment target

PTAL @RedBrogdon


ci: add Linux aarch64 build

Looks like elp is properly built for aarch64, however, that doesn't seem to be the case for eqwalizer

Hi @asabil Thanks for working on this. Maybe it would be a good idea to split the refactoring into smaller PRs, to avoid a single PR that modifies the whole CI pipeline and to reduce/speed up the review process, making it more incremental.

Yes of course, what I have here is more of a draft. I initially opened this PR thinking I was mostly done, until I realized that elp depended on eqwalizer which is built in Scala and makes use of GraalVM to produce a native binary.
Life would have been easier if GraalVM's native-image supported cross-architecture cross compilation, as it turns out, it doesn't.
Before I head into thinking about how to split this into multiple PRs, there are few points that I would very much appreciate feedback/opinion on the following:
1. Pipeline architecture
The pipeline architecture in this PR is much more involved, which makes it more flexible, but also more complex: The build makes use separate workflows and jobs, sharing artifacts between the jobs using actions/upload-artifact and actions/download-artifacts.
This inevitably slows down the build in exchange for flexibility (with some minor effort we should also be able to support windows).
2. eqwalizer on macOS/arm64 is actually built for macOS/x86_64
This is not new to this PR, but was also an issue in the previous PR. The binary works thanks to Rosetta. This can only be resolved by using a macos building running arm64.
3. eqwalizer build for linux/arm64 takes 1.5h on the standard GitHub runner
This is due using qemu for emulation. Again, this could be sped up by using a native Linux/arm64 runner.
4. Change in naming convention
I chose to using standardized triplets and arch names such as x86_64-unknown-linux-gnu and aarch64-apple-darwin so as to be able to support other linux builds if needed/wanted, such as musl libc based ones.
Thank you.

@asabil
1. Pipeline architecture
The CI pipeline originally started as multiple workflows, but that led to various discrepancies so unifying was also a way to avoid code duplication and keep everything consistent. The easier the better.
I like the idea of splitting jobs such as publish-extension.
2. eqwalizer on macOS/arm64 is actually built for macOS/x86_64
3. eqwalizer build for linux/arm64 takes 1.5h on the standard GitHub runner
Correct. This is because (as far as I know) GitHub public runners do not include a arm variant.
As long as the eqwalizer and elp are separate, I wonder if instead we should skip building eqwalizer itself and use the artifacts from there, instead.
4. Change in naming convention
That should already be the case when it comes to targets. See for example:
platform-arch: ubuntu-20.04-x64
platform: ubuntu-20.04
os: linux
target: x86_64-unknown-linux-gnu
vscode-target: linux-x64

I like the existing kind of structure since it allows us to provide "aliases" for the target which we can use in different contexts (e.g. when you publish to the marketplace you need to map the standard target to something like linux-x64. This mechanism allows us to avoid things like:
          case "${{ inputs.target }}" in
            x86_64-unknown-linux-gnu) vscode_target=linux-x64 ;;
            aarch64-unknown-linux-gnu) vscode_target=linux-arm64 ;;
            x86_64-apple-darwin) vscode_target=darwin-x64 ;;
            aarch64-apple-darwin) vscode_target=darwin-arm64 ;;
            *)
              echo "Unsupported target platform" >&2
              exit 1
          esac

Which can distract from what the action is trying to do and are more error prone (in my view).

As an additional consideration, it is now be possible to run ELP without eqwalizer (see #14), so for Linux Arm we could simply publish a version of ELP which does not include eqwalizer and report the issue in whatsapp/eqwalizer. You can still build eqwalizer from source (yes, it's inconvenient).

Thank you for the feedback. It has been a bit of a busy week for me, but I will try to pick this up again soon and open a new set of PRs.


[Question] How to control layoutServiceHost value during build?

We have a necessity to define different layoutServiceHost based on environment/build context for headless SSR.
The community approach is to perform token replacement, which smells a bit hacky.
The alternative is to maintain a list of configs, and place proper one based on build context, looks as a variation of previous hack.
@anastasiya29 Could you please suggest an approach/direction to take?
Thanks.

@mitikov You can try this approach:

npm i dotenv
https://www.npmjs.com/package/dotenv

Create .env file, and add required env variables, for example:
LAYOUT_SERVICE_HOST=https://super_hero.host.com

Edit scripts/bootstrap.js:

const configGenerator = require('./generate-config');
const scjssconfig = require('../scjssconfig.json');

require('dotenv').config();

/*
  BOOTSTRAPPING
  The bootstrap process runs before build, and generates JS that needs to be
  included into the build - specifically, the component name to component mapping,
  and the global config module.
*/

const disconnected = process.argv.some((arg) => arg === '--disconnected');

/*
  CONFIG GENERATION
  Generates the /src/temp/config.js file which contains runtime configuration
  that the app can import and use.
*/
const port = process.env.PORT || 3000;
const configOverride = disconnected
  ? { sitecoreApiHost: `http://localhost:${port}` }
  : {
      sitecoreApiHost: process.env.LAYOUT_SERVICE_HOST || scjssconfig.sitecore.layoutServiceHost
    };

configGenerator(configOverride);

/*
  COMPONENT FACTORY GENERATION
*/
require('./generate-component-factory');

We initialized dotenv in order to read env variables from .env file.
And we can override part of config, where we will take env var LAYOUT_SERVICE_HOST or value from scjssconfig.json
{
    sitecoreApiHost: process.env.LAYOUT_SERVICE_HOST || scjssconfig.sitecore.layoutServiceHost
};

configGenerator function responsible for creation of config file: src/temp/config.js. All references of sitecoreApiHost are linked to src/temp/config.js

Let's run jss build and check src/temp/config.js file:

/* eslint-disable */
// Do not edit this file, it is auto-generated at build time!
// See scripts/bootstrap.js to modify the generation of this file.
module.exports = {
  "sitecoreApiKey": "5BABD942-ED4F-475E-90CE-787E3D5A4E42",
  "sitecoreApiHost": "https://super_hero.host.com",
  "jssAppName": "JssReactWeb",
  "defaultLanguage": "en",
  "graphQLEndpointPath": "/api/jssreactweb",
  "graphQLEndpoint": "https://super_hero.host.com/api/jssreactweb?sc_apikey=5BABD942-ED4F-475E-90CE-787E3D5A4E42"
};

@mitikov What do you think, does this solution fit for you?
@anastasiya29

Thanks!

Thanks!


Resolving confusion between fine-grained classes

My dataset has 131 classes. Some of them are fine-grained, for example:

Flag fraud on the account -> Open Dispute
Find out if there is a fraud hold on my debit card ->Dispute Inquiry

The model is getting confused between such classes. I have roughly 20 samples per class in my dataset and I am using mpnet-base-v2 with num_iterations=25.  Is there a way to specify which classes to draw the negative samples from given a positive class? Should I just add more data into the confusing classes?

Hello!
There is no way to specify which classes should be used to draw negative samples from. These similar cases are definitely tricky. More training data for the disputing classes in particular may certainly help, but I suspect that it will continue to struggle somewhat to distinguish them, as they are quite similar in nature.
Another alternative approach (which I'm sure you've already considered) would be to separate the problem into multiple SetFit models by grouping the fine-grained labels. If a fine-grained label is then chosen, a second SetFit model is applied to distinguish the cases further. This second model could be trained on only the problematic fine-grained classes, and this model should be able to discern the differences between the classes much more effectively.
That said, I understand the negative latency consequences.

Tom Aarsen


refactor: set default api url to api.nyk.io

Description
snyk.io/api is the legacy and deprecated API url.
Let's favour api.snyk.io instead.
Checklist

[x] Tests added and all succeed
[x] Linted
[x] README.md updated, if user-facing
[x] License file updated, if new 3rd-party dependency is introduced

🚨After having merged, please update the CLI go.mod to pull in latest language server.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[QUESTION] Excuse me

Bro, when will you consider adding a new tag？

Tonight.

Tonight.

Thanks！


add chr6.C4 to test-files

The graph chr6 is not the monster that chr8 is, and should perhaps have been in our fetch-list the whole time. @susan-garry, could you please check if its addition causes any problems on your end? If not, merge away!

Adding chr6.C4 to the test suit did not break anything, but it turns out that I broke the exine API when I moved the files into a different directory while making the parser. I have fixed it and all of the exine and slow-odgi tests pass, so I will go ahead and merge this branch


python: Depends on bzip2 (was: node fails to upgrade to 5.7.0)

upgrading to the latest node is causing issues, it seems like its being halted by python not finding bz2, bz2 is installed via brew as is python.
gist: https://gist.github.com/dcee03896735c61ed1f9
Last 15 lines from /usr/users/sl/pagem/.cache/Homebrew/Logs/node/02.make:
  touch /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj.target/tools/icu/icu_implementation.stamp
  touch /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj.target/tools/icu/icu_uconfig.stamp
  touch /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj.target/tools/icu/icu_uconfig_target.stamp
  touch /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj.host/tools/icu/icu_implementation.stamp
  touch /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj.host/tools/icu/icu_uconfig.stamp
  LD_LIBRARY_PATH=/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/lib.host:/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/tools/gyp; mkdir -p /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj/gen; python ../../tools/gen-postmortem-metadata.py "/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj/gen/debug-support.cc" ../../src/objects.h ../../src/objects-inl.h
  LD_LIBRARY_PATH=/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/lib.host:/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/tools/gyp; mkdir -p /tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj/gen; python ../../tools/js2c.py "/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj/gen/libraries.cc" CORE ../../src/macros.py ../../src/messages.h ../../src/prologue.js ../../src/runtime.js ../../src/v8natives.js ../../src/symbol.js ../../src/array.js ../../src/string.js ../../src/uri.js ../../src/math.js ../../src/third_party/fdlibm/fdlibm.js ../../src/date.js ../../src/regexp.js ../../src/arraybuffer.js ../../src/typedarray.js ../../src/iterator-prototype.js ../../src/generator.js ../../src/object-observe.js ../../src/collection.js ../../src/weak-collection.js ../../src/collection-iterator.js ../../src/promise.js ../../src/messages.js ../../src/json.js ../../src/array-iterator.js ../../src/string-iterator.js ../../src/templates.js ../../src/harmony-array.js ../../src/harmony-typedarray.js ../../src/debug/mirrors.js ../../src/debug/debug.js ../../src/debug/liveedit.js ../../src/i18n.js
Traceback (most recent call last):
  File "../../tools/js2c.py", line 37, in <module>
    import bz2
ImportError: No module named bz2
make[1]: *** [/tmp/node20160224-11191-1016eki/node-v5.7.0/out/Release/obj/gen/libraries.cc] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/tmp/node20160224-11191-1016eki/node-v5.7.0/out'
make: *** [node] Error 2

I was about to report the same thing. I am getting the same error.
However, I was able to successfully work around it with brew install bzip2 (I did not try bz2) and then brew reinstall node.

Please report
brew list python |grep bz2.so

You should see a file named lib/python2.7/lib-dynload/bz2.so.
If not, please run
brew install bzip2
brew reinstall python

If this resolves your issue, then it looks as though python and python3 should depend on bzip2.

I had the same issue, after installing bzip2 Python worked.

Did you have to reinstall python after installing bzip2?

Fixed. Thanks for the bug report, Martin, and others for help troubleshooting.

FWIW, I believe I did not have to reinstall python.

Oh. I didn't expect that. Perhaps I should have made bzip2 a dependency of node then rather than of python. Oh well. I'm going to leave it as a dependency of python, because the bz2 module of Python won't work without it.


Articols matter in Italian

@Padanian it's a forward port of a suggested change introduced in 1.14, to 1.21. Can you be more specific about the problem with it? Although fully admit I'm taking the commit on trust

The title of the pull is a mispronounced translitteration of the italian word "Articolo" which stands for the "Definite article". Then, nouns in Italian do not require the capital letter, which is only required in German nouns. Finally, the former translation is perfectly understandable, and is common practice in software engineering or user interfaces to omit the definite article.

The translation is correct in both ways, I can't understand why you're pointing this out and you don't just approve it. To me, it is just someone from 2017 trying to improve the italian translation, not a troll.

It's not wrong in the strict term, it's just useless, tipical trolling, definitely not improving anything.

Yeah, I agree, that's why I approved and moved on... I mean, you're right and this could be avoided but at this point let's close this commit as soon as possible and let's move on lol
Also, I'm a Padanian too hahaha


[C++] Hash aggregate functions to return first and last value from a group.

Follow-up to ARROW-13993, which implemented hash_one to select an arbitrary value, as the core engine lack support for ordering. I think first and last will still be in demand though, based on pandas and sql usage.
It could be done without core changes by using min_max on an array of indices. For that reason, maybe it would be better as hash_\{first,last}_index, suitable for use with take.
Reporter: A. Coady / @coady
Assignee: Sanjiban Sengupta / @sanjibansg
PRs and other links:

GitHub Pull Request #15159

Note: This issue was originally created as ARROW-15735. Please see the migration documentation for further details.

Done in #34912.


Refactor of the secrets manager

Issue
Current secrets manager implementations have the following drawbacks by saving the JSON objects as a secret:

It adds a lot of complexity to our code, e.g., migrations, dealing with retro compatibility, extra serialization/deserialization of objects, etc.
Scalability and compatibility among different available secrets manager implementations. The amount of data you can save on each one differs and is limited. We are storing JSON objects as string values that do not have fixed lengths.
The user loses the advantage of using a secret manager store/vault since we store the JSON object.

New approach
What we want to achieve is to be able to recover those passwords/secrets during the workflow execution. We can achieve the same by using a CustomSecretStr in our pydantic models and using values like secret:my-secret-id for the passwords. So each time we want a value for a password, we call get_secret_value(), and our CustomSecretStr will check if the value starts with secret: and recover it from the configured secrets vault.
The advantages of the new approach are:

Reduce the complexity of the backend, and we can remove the SecretsManager dependency from many places and the CLI code.
It is easy to implement and valuable for the user.
It still makes our application secure since no sensitive values are stored.

Tasks

[x] Replace the current managed secret manager implementation with a non-managed version. This will include adding CustomSecretStr when the code is generated and migrating the connection parameters and options into a list of values and passwords so the same approach can be applied to these objects.

https://github.com/open-metadata/OpenMetadata/pull/8617

[x] Review connection JSON schemas to see if there is any sensitive value that is not being treated as a password.

Moved into a separate issue: https://github.com/open-metadata/OpenMetadata/issues/8728

[x] Implement managed secret manager where the secrets inside the connection objects which are sensitive are automatically stored in the secrets manager.

https://github.com/open-metadata/OpenMetadata/pull/8671
https://github.com/open-metadata/OpenMetadata/pull/8720
https://github.com/open-metadata/OpenMetadata/pull/8725

The pending task for reviewing the connection JSON schemas to see if any sensitive value is not being treated as a password will be handled in a separate issue.


Bugfix/630 ts units message

Closes #631

I created a new issue for your comment about the sanitizers


Feature Request: Keep cluster peer name on restart

What did you do?
Peer
What did you expect to see?
When the alertmanager process is restarted, it should not be recognized as the old peer to the cluster. A possible solution would be an manual given peer name (like --cluster.peer-name=), or the use of a deterministic peer name generation.
What did you see instead? Under which circumstances?
When the process is restarted for whatever reason, the alertmanager joins as a new peer. The old peer is present as "failed", which is not correct.
Environment

System information: n/a

Alertmanager version: version 0.20.0 (branch: HEAD, revision: f74be0400a6243d10bb53812d6fa408ad71ff32d)

Prometheus version: n/a

Alertmanager configuration file: n/a

Prometheus configuration file: n/a

Logs: n/a

This sounds like it should not happen in the first place. Do you know why it is changing?
Overall this feature seems dangerous; it should probably work out of the box.

@roidelapluie the peer name has always been auto-generated since the clustering has been refactored to use hashicorp/memberlist. I'm not sure if there was a technical reason for this... I can only assume that not requiring an explicit peer name was deemed easier from a configuration point of view.
https://github.com/prometheus/alertmanager/blob/1895fde85692bd18dca69cbf96a7b67a3e519b22/cluster/cluster.go#L167-L170

Wanted to ask about the state of this issue. Recently after restarting our Alertmanagers and looking at the dashboards, we noticed  the alertmanager_cluster_failed_peers metric from several peers was non-zero. This caused confusion until we realised that the restart caused this and the cluster was indeed okay, while some information about the old peers was retained. After about 6h the metric went back to zero, this seems to be controlled by --cluster.reconnect-timeout (we didn't override it).
In our case alertmanager_cluster_failed_peers was misleading, so having the option to keep old peer names after a restart would be nice to have.


Switched to secure cdn

The problem is when the page loaded via https it is not allowed to load the script from this url.

@DavidSichau Good catch!

Could you merge it and publish an update?

@DavidSichau Published ...


How can i fix this

Failed to listen on <IP_ADDRESS>:80 (reason: Address already in use) how can i fixed this please help

basically your port 80 already in used by some other process
either serve on other port or find out culprit
see also https://stackoverflow.com/questions/27900174/artisan-error-failed-to-listen-on-localhost8000


API access to the feature key points used in tracking from T265

Required Info

Camera Model
{ T265 }

Firmware Version
<IP_ADDRESS>29

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Platform
PC

SDK Version
{ 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
Feature request - API access to the feature key points used in tracking from T265:

Can be either as a per frame matched features or stored key frame features
The features should contain a 3D position of each feature in world coordinates
Add a callback whenever new features are added to the map

The main premise behind this FR is to get a sparse depth map

I am also looking for a function that can extract feature point data from T265.
Will this functions be available in the future?

+1 for this. Would be very useful for multiple camera tracking configurations.

Although we don't yet have exposing this functionality on our roadmap we do like the suggestion. In the meantime, if you have host compute available you may be interested in https://github.com/IntelRealSense/librealsense/pull/3951 which is a python example that uses the T265 intrinsics and extrinsics to compute a stereo image in OpenCV.

Thank you for highlighting this new feature. We have moved our focus to our next generation of products and consequently, we will not be addressing this in T265.


Add -disable-sil-linking to four simple SIL serialization tests.

What these tests are testing has nothing to do with whether or not we deserialize anything from the standard library, and not doing so saves more than two minutes (single-threaded) on my machine from each test.

@swift-ci Please smoke test


Meow package as dependency

Should be moved to devDependency section

Sorry I didn't realize that running from console is a requirement. I will create a new issue that will make more sense because I do not need the CLI part of this library.


GEODE-6283: have the management rest controller call the internal man…

…agement service

fix copy and paste error

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@onichols-pivotal @Petahhh


barrel files break modular generation

Describe the bug
In my app I am using barrel files to bundle my exports.
When using those barrel files to access my modularly generated Tables, drift fails to correctly associate them.
When running build_runner, I get the following warning:
The referenced element, MyTable, is not understood by drift.
And a broken generated file, where MyTable is not a getter.
I have setup a reproducible sample for this issue.
The following files are required:
my_table.dart
import 'package:drift/drift.dart';

// ignore: unused_import
import 'my_table.drift.dart';

class MyTable extends Table {
  IntColumn get id => integer().autoIncrement()();
}

barrel.dart
export 'my_table.dart';

database.dart
/// demonstrate a weird issue with drift and barrel files
///
/// this is valid:
/// import 'my_table.dart';
///
/// this is not valid:
/// import 'barrel.dart';
///
/// instead we get:
/// [WARNING] drift_dev:analyzer on lib/database.dart:
/// line 27, column 7 of package:barrel_example/database.dart: The referenced element, MyTable, is not understood by drift.
///    ╷
/// 27 │ class AppDatabase extends $AppDatabase {
///    │       ^^^^^^^^^^^
///    ╵
library;

import 'package:drift/drift.dart';
import 'database.drift.dart';

import 'barrel.dart';

// uncommenting this "fixes" the issue
// import 'my_table.dart';

@DriftDatabase(tables: [MyTable])
class AppDatabase extends $AppDatabase {
  AppDatabase(super.e);

  @override
  int get schemaVersion => 1;
}

using package imports over relative imports made no difference in my testing.

Thanks for the report!
This bug has probably been introduced by a recent optimization: We serialize which file defines which tables during the build. When analyzing files later, we can then quickly check whether a given class is a valid drift table without having to analyze the file again. This is more relevant for imports in SQL, where we don't know the table class beforehand and would potentially have to analyze every import. This optimization requires us to serialize Dart's import model as well though, and this hasn't considered export elements yet. This has been fixed in 79dda8668b8b4280dcb346cc87e2c8d3dacc260a.

When a new hotfix release is planned?

I've just published drift_dev version 2.11.2 which contains the fix.

I contune to have problems.
I have a multipackage repo, something like the following struct:
app
|_features
    |_featureA
    |_featureB
    |_db

every feature exports its own tables and daos are properly configured. All has worked fine since version 2.11.1, now:

in the db package I have the following error:

The referenced element, FeatureADataSourceImpl, is not understood by drift

but in the fetureA I have:

@LazySingleton(as: FeatureADataSource)
@DriftAccessor(tables: [FeatureA])
class FeatureADataSourceImpl extends DatabaseAccessor<AppDatabase> with _$FeatureADataSourceImplMixin implements FeatureADataSource {
  FeatureADataSourceImpl(super.attachedDatabase);
  ...
}

and the export in the feature_a.dart file.
How i can solve?

Does featureA depend on drift_dev as well? That's necessary now for drift to see its members now since the analysis happens on a per-file basis instead of crawling from a single entrypoint (something that generally makes builds more efficient).
If that doesn't fix it either, can you provide a simple repository where this behavior can be observed? I'll take a look at what's going on then.

Ye

Does featureA depend on drift_dev as well? That's necessary now for drift to see its members now since the analysis happens on a per-file basis instead of crawling from a single entry point (something that generally makes builds more efficient).
If that doesn't fix it either, can you provide a simple repository where this behavior can be observed? I'll take a look at what's going on then.

yes featureA depend on drift_dev.
here is a small replica repo I hope it is all correct, I did it faster.
The error appears if you run melos build_runner:build .

here is a small replica repo I hope it is all correct, I did it faster.

The repository seems to be empty.

here is a small replica repo I hope it is all correct, I did it faster.

The repository seems to be empty.

sorry, check now

I really don't like this, but I think it's a build_runner quirk. I was able to resolve it, but it's ugly. You need to create two files, db.build.yaml and feature_a.build.yaml in features/db:
# feature_a.build.yaml
targets:
  $default: {}
  drift:
    auto_apply_builders: false
    dependencies: []
    builders:
      drift_dev:analyzer:
        enabled: true

Then, also create a build.yaml file in db with this content:
# db.build.yaml
targets:
  $default:
    dependencies:
      - feature_a:drift

The problem is that build_runner refuses to run builders that claim to generate visible sources (which drift_dev in combination with source_gen:combining_builder does) outside of the root package. So in the default config, drift doesn't run on feature_a at all. Drift's default builder is a three-step pipeline, with the first two steps being responsible for finding elements relevant to drift in source files. When the last step (responsible for codegen) runs, it expects that the analyzing steps already ran. Since they didn't on feature_a, the last step in the main package thinks that feature_a doesn't define anything relevant for drift.
Luckily, drift exports the first two steps as a separate builder, and since that one doesn't claim to generate anything user-visible, it can be applied to dependent packages. The trick of introducing another target is necessary because feature_a depends on db, so they form a cycle and the order in which builders run in a cycle is undefined. That wouldn't be a problem if we were able to use the default builder thanks to the pipeline setup, but we can't. So we need to setup a special drift target that doesn't depend on the db target, and then have the db target depend on that. This breaks the cycle, running the analyzer on feature_a first and the error goes away.
We only need this hack for builds running in the db folder, so I can prefix the package names of the overridden builders to only apply these config files to builds happening in that directory.
I'm not a fan of that build_runner behavior, but that's the way it is. I don't really see a non-breaking way to fix this in drift, so I'm afraid you'd have to use this setup for every package that defines drift elements.

Thank you so much


feat: inherit labels annotations from resource request in output object manifest in operator promise aspect

Context
closes #63
Set outputed object manifest's labels and annotations to resource request labels and annotations.

@aclevername replied in original issue


Remove mention of contact@ and the slack

The contact@ address for "For general enquiries and press" is unattended. No one is handling these since @btcdrak became inactive, so imo it's better to remove it.
As far as I know, no bitcoin core developers regularly attend the Slack, so remove it from contact information as well.

I recently rejoined the slack and noticed at least a couple other devs there, but I support removing it anyway. (cc @achow101)
Concept ACK

utACK!

utACK, I'm in the slack but literaly never log in and check it

Could remove the slack from _includes/references.md?

Concept ACK. There are also a bunch of slack links in various release announcements. Should we also remove those?

Could remove the slack from _includes/references.md?

Agree.

Concept ACK. There are also a bunch of slack links in various release announcements. Should we also remove those?

At least for the code repository we have a policy, more or less, not to change historical announcements. But don't really have a strong opinion in this case.

At least for the code repository we have a policy, more or less, not to change historical announcements.

Right - I'm refering to the release announcements (eg https://bitcoincore.org/en/2017/10/02/release-<IP_ADDRESS>/) rather than the release notes which are copied from the repo (eg https://bitcoincore.org/en/releases/<IP_ADDRESS>/).
I don't think we need to remove those links, but I have a slight preference to get rid of them.

I've removed all references to slack.

ACK 762cb76a48e5807e274e53f91d56e47309959e4f

ACK 762cb76a48e5807e274e53f91d56e47309959e4f.
Can't verify the chinese/japanese, but otherwise looks good. Thanks!

utACK 762cb76


Add a LICENSE file

According to the README, SwiftGit2 is available under the MIT license. This PR adds the full text of the license in a LICENSE file.

Thanks for adding this!


Automated tests for CLI

We should create a new package com.centurylink.mdw.tests.cli and provide testing of the CLI to ensure it's always working.  The tests can simulate the command line by directly invoking the Main.main() method.

I think we should use this:
https://github.com/sstephenson/bats


Host is not allowed to connect to this MariaDB server error

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
Similar error to #4296 where I can not get this working and I'm not sure what I'm doing wrong.
My docker-compose is the following (all 3 passwords are the same and are alphanumerical)
services:
  bookstack:
    image: lscr.io/linuxserver/bookstack
    container_name: bookstack
    environment:
      - PUID=1026
      - PGID=1000
      - APP_URL=https://<IP_ADDRESS>:6875
      - DB_HOST=bookstack_db
      - DB_PORT=3306
      - DB_USER=bookstack
      - DB_PASS=password
      - DB_DATABASE=bookstackapp
    volumes:
      - ./config:/config
    ports:
      - 6875:80
    restart: unless-stopped
    depends_on:
      - bookstack_db

  bookstack_db:
    image: lscr.io/linuxserver/mariadb
    container_name: bookstack_db
    environment:
      - PUID=1026
      - PGID=1000
      - TZ=Removed/Removed
      - MYSQL_ROOT_PASSWORD=password
      - MYSQL_DATABASE=bookstackapp
      - MYSQL_USER=bookstack
      - MYSQL_PASSWORD=password
    volumes:
      - ./configdb:/config
    restart: unless-stopped

In the bookstack container I get the following error in the logs instead of it doing the migration:
SQLSTATE[HY000] [2002] Connection refused (SQL: select * from information_schema.tables where table_schema = bookstackapp and table_name = migrations and table_type = 'BASE TABLE') {"exception":"[object] (Illuminate\\Database\\QueryException(code: 2002): SQLSTATE[HY000] [2002] Connection refused (SQL: select * from information_schema.tables where table_schema = bookstackapp and table_name = migrations and table_type = 'BASE TABLE') at /app/www/vendor/laravel/framework/src/Illuminate/Database/Connection.php:760)

If I restart the bookstack container I get a different message
SQLSTATE[HY000] [1130] Host 'bookstack.bookstack_default' is not allowed to connect to this MariaDB server (SQL: select * from information_schema.tables where table_schema = bookstackapp and table_name = migrations and table_type = 'BASE TABLE')

In the bookstack_db container I receive the following in the logs
Warning: World-writable config file '/etc/my.cnf.d/custom.cnf' is ignored
In the .env file the database details are the following. So even though I specify DB_USER and DB_PASS it turns into USERNAME and PASSWORD, not sure if that's an issue or not.
DB_HOST='bookstack_db'
DB_PORT='3306'
DB_DATABASE='bookstackapp'
DB_USERNAME='bookstack'
DB_PASSWORD='password'

and in the mysqld custom.cnf file the user is abc instead of bookstack, not sure if thats also an issue.
user            = abc
I have tried removing containers, pruning everything and creating containers again but I still have the same error. It looks like a permissions issue with the database but I don't know how to resolve.
Exact BookStack Version
Latest
Log Content
No response
PHP Version
No response
Hosting Environment
Docker on Synology 920+

Ok so I have this working now. I think it was the bookstart_db container which wasn't working and wasn't starting MariaDB. I just restarted the bookstack_db container a few times and waited a little while and MariaDB finally started. Then I recreated the bookstack container and it managed to connect to the db and start the migration work and now all working.


Add warning when attempting to use the analytical NSI matrix

According to an existing comment (L390 of the edited file), the analytical version of the NSI matrix is not implemented correctly.  Since this function is called in the PISA tests that run on changes to be merged, I'm writing a warning here rather than an error.

Isn't there already a warning like this?
[ WARNING] Warning: the analytical NSI matrix is not yet properly implemented. Instead, use the numerical NSI matrix.
[ WARNING] Evaluating analytical expressions for NSI matrix elements does not give agreement with numerical calculation! Elementwise agreement:
[[ True False  True]
 [False  True False]
 [ True False  True]]
This is expected. Going ahead with numerical calculation for now


vs2017 compile failed: use undefined type “std::_Get_first_parameter<_Ty>” error:c2027

sol: v3.23
vs: vs2017   already set c++ lastest and set the permissive
lua: v5.43

I can build successfully by sol:v3.21 with lua:v5.36

I'm currently experiencing this issue @ThePhD -
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\xmemory0(266): error C2027: use of undefined type 'std::_Get_first_parameter<_Ty>'
[C:\Users\User\Desktop\Repos\horizon\build\src\Server\Auth\auth.vcxproj]

I can build successfully by sol:v3.21 with lua:v5.36

Please  ,  May I ask how you resolved this bug ?


Flexible Tracker: Widgets with apostrophes don't work

Widgets with apostrophes (and probably other weird characters) cause that widget to not respond.

Fixed in https://github.com/Cosmic-Chatter/Exhibitera/commit/dc22eba8f49e80917a9d42e4d8e2ec53ec8fe6f1


[FLINK-18958] Lose column comment when create table

What is the purpose of the change
add colum comment  when users use describe instruction .
Verifying this change
Tested manually on a local cluster.
UT case see  BatchTableEnvironmentTest.testExecuteSqlWithDescribeForComment  and BatchTableEnvironmentTest.testExecuteSqlWithDescribe
also I have test in my production env as follow.

@oikomi Thanks for your contribution. But could you offer some test cases to verify your work? I think you should offer tests that when users use describe instruction, they can also have information about column comments.  You can take a look at org.apache.flink.table.api.batch.BatchTableEnviromentTest#testExecuteSqlWithDescribe as an example.

hi  @fsk119  I have commited  a UT for colum comment and I have found a bug when not use blink planner, thank you very much!

@flinkbot run azure

@wuchong can you help review this pr when you are free？

@flinkbot run travis
@flinkbot run azure

@flinkbot run azure

Thanks for the contribution @oikomi , after going through it roughly, I have some concern that we are making the TableSchema fatter and fatter. The community had some discussion to introduce a CatalogTableSchema to preserve the metadata information of catalog table and keep TableSchema clean to describe a schema (see FLINK-17793).
So I'm hesitated whether we should wait for FLINK-17793 or update TableSchema further.

@wuchong  OK , let's wait for FLINK-17793 .


Core Developer: system sends email

We need to send emails from the system for various reasons.
We need an internal plan for SMTP. We also need to plan how this will work within the open source system.
Feature: System sends emails
  As a core developer
  I want the system to have the ability to send emails
  So that users can be notified or receive CTA in their email inbox.

  Scenario: Password recovery
    Given that password recovery needs to send a recovery link to the user
    When a user wants to receive a recovery link
    Then the system should be able to send them an email with that link.

  Scenario: Approval requested
    Given that an editor needs to know when content is available for approval
    When a content creator wants their content approved
    Then the system should be able to email the editor an approval request.

Feature: SMTP hosting
  As a core devloper
  I want SMTP hosting
  So that I can integrate the ability to send emails into the CMS

  Scenario: Hosting needed
    Given that I need smtp
    When I need to add smtp mailing
    Then I need a consistent, hosted solution for that functionality

System sends emails

[ ] password recovery
[ ] approval requested

SMTP hosting

[ ] hosting needed

Blocked: need ability to send email


supabase db reset Error reloading PostgREST schema cache

Bug report
Describe the bug
When running supabase db reset, I get this error:
Error: Error reloading PostgREST schema cache: Error response from daemon: Cannot kill container: supabase_rest_limey: Container c3ab24899b3c8d822145ec89b854a23c121f3f2d1652b965d09cd70045bf5029 is not running

To Reproduce
Not sure what caused this to start happening
System information

OS: macOS
Version of supabase-js: 0.28.1
Version of Node.js: 16.15.0

I've tried doing that, but didn't fix it unfortunately. iirc running supabase stop didn't work.
I've had this issue twice, and fixed it by manually removing all Docker containers and images through CLI (Docker Desktop gave an error)

Yeah, seems like thesupabase stop script could use a touch-up -> Maybe it should be able to detect when there was an issue stopping the containers, and provide the workaround as a suggested output on stdout? @soedirgo

To address this specific issue of db reset failing, we no longer return an error when PostgREST container is not found. https://github.com/supabase/cli/blob/main/internal/db/reset/reset.go#L216 Reason is purging schema cache is more of a post run action that shouldn't affect the exit code of db reset.
Regarding the broader issue of supabase stop not working, we would need more details to reproduce, such as screenshots or error logs, because the code for stop command looks ok to me https://github.com/supabase/cli/blob/main/internal/stop/stop.go#L29. Once we know the exact cause, it will be easier to come up with a proper fix. Let's track this in a new ticket if you agree.

Sounds good! I've only ran into this twice, so I'll just make sure to open another issue if it ever happens again


Ambermini tests fail?

It looks like ambermini15 is building, but running antechamber -h must return a failure or something.
From Jenkins:
TEST START: ambermini-15.0.0-0
Fetching package metadata: ........
Solving package specifications: .+ antechamber -h
Usage: antechamber -i   input file name
                   -fi  input file format
                   -o   output file name
                   -fo  output file format
                   -c   charge method
                   -cf  charge file name
                   -nc  net molecular charge (int)
                   -a   additional file name
                   -fa  additional file format
                   -ao  additional file operation
                        crd   : only read in coordinate
                        crg   : only read in charge
                        radius: only read in radius
                        name  : only read in atom name
                        type  : only read in atom type
                        bond  : only read in bond type
                   -m   multiplicity (2S+1), default is 1
                   -rn  residue name, overrides input file, default is MOL
                   -rf  residue toplogy file name in prep input file,
                        default is molecule.res
                   -ch  check file name for gaussian, default is 'molecule'
                   -ek  mopac or sqm keyword, inside a pair of quotes
                   -gk  gaussian job keyword, inside a pair of quotes
                   -gm  gaussian memory keyword, inside a pair of quotes, such as"%mem=1000MB"
                   -gn  gaussian number of processors keyword, inside a pair of quotes, such as "%nproc=8"
                   -gv  add keyword to generate gesp file (for Gaussian 09 only)
                        1    : yes
                        0    : no, the default
                   -ge  gaussian esp file generated by iop(6/50=1), default is g09.gesp
                   -df  am1-bcc precharge flag, 2 - use sqm(default); 0 - use mopac
                   -at  atom type, can be gaff (the default), amber (for PARM94/99/99SB), bcc and sybyl
                   -du  fix duplicate atom names: yes(y)[default] or no(n)
                   -bk  4-character component Id, for ccif
                   -an  adjust atom names: yes(y) or no(n)
                        the default is 'y' for 'mol2' and 'ac' and 'n' for the other formats
                   -j   atom type and bond type prediction index, default is 4
                        0    : no assignment
                        1    : atom type
                        2    : full  bond types
                        3    : part  bond types
                        4    : atom and full bond type
                        5    : atom and part bond type
                   -s   status information: 0(brief), 1(default) or 2(verbose)
                   -eq  equalizing atomic charge, default is 1 for '-c resp' and '-c bcc' and 0 for the other charge methods
                        0    : no use
                        1    : by atomic paths
                        2    : by atomic paths and structural information, i.e. E/Z configurations
                   -pf  remove intermediate files: yes(y) or no(n)[default]
                   -pl  maximum path length to determin equivalence of atomic charges for resp and bcc,
                        the smaller the value, the faster the algorithm, default is -1 (use full length),
                        set this parameter to 10 to 30 if your molecule is big (# atoms >= 100)
                   -i -o -fi and -fo must appear; others are optional
                   Use 'antechamber -L' to list the supported file formats and charge methods

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    ambermini-15.0.0           |                0         8.1 MB

The following NEW packages will be INSTALLED:

    ambermini: 15.0.0-0
    zlib:      1.2.8-0

TESTS FAILED: ambermini-15.0.0-0

Can you open an issue in ambermini for this?

Oh, sure, will do, though the issue is just that the tests chosen to be
included in the omnia conda recipe should be adjusted to eliminate those
that return nonzero integers when they actually succeeded.

Huzzah!
https://binstar.org/omnia/ambermini/files


add a command prompt to show shell is alive

As suggested by @brucemack in #17, this PR adds a command prompt to the shell.
At this time it's a fixed prompt; "> ".  I'm not sure making the prompt adjustable is worth the complexity.  That said, if the default prompt should be something else it could be changed.

Looks good, thank you!!!
Minor comment: it might be worth highlighting in the releaseNotes.md that this is a breaking change, in case anyone has unit tests that aren't expecting that new character in the stream.  I had a few things that failed in unexpected ways.  But it's all good now, and I think the user experience is a lot better.


SoftwarePlatform and CloudService functionality

Short Description
Adds SoftwarePlatform and CloudService related controller, services, classes and controller tests
Proposed Changes

Adds SoftwarePlatform repository, dto, service, controller and controller test
Adds CloudService repository, dto, service controller and controller test
Moved @EnableJpaRepositories to different class to enable the usage of @WebMvcTest in JUnit5 tests from #32

Could you add OpenAPI annotations in the controller classes? If they are not present the generation for the frontend will not work, examples for the annotations can be found here

Could you add OpenAPI annotations in the controller classes? If they are not present the generation for the frontend will not work, examples for the annotations can be found here

Added, did I miss any?

Could you add OpenAPI annotations in the controller classes? If they are not present the generation for the frontend will not work, examples for the annotations can be found here

Added, did I miss any?

seems fine!


Rename translations dir to resolve upcoming hass incompatibility

I got an error from hass on the latest beta:

logbook_cache: the ‘.translations’ directory has been moved, the new name is ‘translations’, starting with Home Assistant 0.111 your translations will no longer load if you do not move/rename this

Figured I'd offer a patch.

Awesome, the first PR 😃. Thanks!
I guess this should be merged when 0.109 goes final.

Yeah, its gated on that: https://github.com/home-assistant/core/pull/34494

I merged so you can test it on "master" if you want. Will make a new release next week.


Support for mc 1.19.21 (protocol 545)

Please update the proxy software to protocol 545

And also change the java version to 1.19.1 pls

        <dependency>
            <groupId>com.github.steveice10</groupId>
            <artifactId>mcprotocollib</artifactId>
            <version>1.19.1-SNAPSHOT</version>
        </dependency>


Update Sync for updated DATAFilter (DATAFilter v0.11)

You should be very cautious with that added catch in: 18e70caa79d7dec73fc016a96a5743306793e66d. I have no idea why I had to add this but it didn't compile without it.

Fantastic!


Issue Fix #705

As per the recommendation on the official badger GitHub repo on https://github.com/dgraph-io/badger/issues/246 , I have applied the fix .

fixes #705


Switch to C++20

The main motivation here is support for the upcoming Unreal Engine 5.5. It uses the GSL library, as cesium-native does, but it's a modified (broken) version of it, so we can't use UE's version in cesium-native. Using our own copy creates conflicts with Unreal's. So one possible solution is to switch to C++20, change all the gsl::span to std::span, and drop the dependency on GSL. This PR is the first step in that.
Some notes:

The version of Async++ that we were previously using, via vcpkg, does not work in C++20. A new version that fixes this was only tagged very recently, and is not yet in a tagged vcpkg release. Which means that this branch uses a prerelease vcpkg for the moment. We should probably wait until the next vcpkg release, and then use that, before we merge this. I think it should be really soon.
Compiling TestPropertyTableView.cpp for C++20 RelWithDebInfo on Ubuntu 22.04 uses a ton of memory, crashing the GitHub Actions runner. We should be able to fix this by moving away from std::variant, as we've done in Unreal and Unity, now that we're on C++20. But for now I've just added a build step to increase available swap space so that the build can complete successfully.
C++20 made the u8string method of std::filesystem::path returning a std::u8string instead of a regular std::string. This is fairly painful because we were already using std::string to represent a UTF-8 string (in C++17 there was no better alternative), and there's apparently no conversion between u8string and string. We should consider whether we should standardize on u8string everywhere, but I'm not sure of the implications. For now I've done the simplest thing: I've added a conversion and called it where we need it.
Our generated Spec classes had a private constructor, when it should have been protected. C++17 didn't care (surprisingly!), but C++20 does. C++20 also requires that derived classes explicitly declare a public constructor if they're expected to have one.
I reworked how we interface with STB Image Resize, because slamming it in a namespace is a bit dodgy and was creating compiler errors (not sure if it was a result of C++20 or a result of the changed vcpkg version). Now we just mark it static and expose helper functions that can be used to call it from outside the one module where it's defined.

I'm marking this ready to review. My only small reservation is that it still uses (by necessity) a pre-release vcpkg repo. I think the new version, including the fix we require, should be out by the end of the month.

New release of vcpkg is out, which should let us move off the prerelease one used in this branch. I'll do that today.
https://github.com/microsoft/vcpkg/releases/tag/2024.11.16


Integrate LLVM at llvm/llvm-project@af5be38a0103

Update BUILD files and submodule for
af5be38a0103

Indentation seems off, but might be the mobile GitHub app. LGTM.

I think that must be the app. This includes running buildifier and looks normal in the web ui on my end.


browse v0.1.1 (minor release)

fix get_institution call
fix arXiv ID linking

Pull Request Test Coverage Report for Build 431

32 of 86 (37.21%)  changed or added relevant lines in 8 files are covered.
13 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.7%) to 83.325%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

populate_test_database.py
0
2
0.0%

browse/util/id_patterns.py
6
9
66.67%

tests/test_id_patterns.py
1
5
20.0%

tests/legacy_comparison/html_comparisons.py
0
20
0.0%

tests/legacy_comparison/abs_page_comparison.py
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

browse/services/search/search_authors.py
2
96.3%

tests/legacy_comparison/html_comparisons.py
4
0.0%

tests/test_browse.py
7
92.57%

Totals

Change from base Build 422:
-0.7%

Covered Lines:
3178

Relevant Lines:
3814

💛  - Coveralls


Can't get Lambda invocation to work

Hi!
I'm trying to get this to work with a lambda. My setup is:
<AssignMessage name="AM-Construct-Outgoing-AWS-Message">
    <AssignTo createNew="true" type="request">outboundLambdaMessage</AssignTo>
    <Set>
        <Verb>POST</Verb>
        <Headers>
            RequestResponse
        </Headers>
        <FormParams/>
        <Payload contentType="application/json">{"name":"foo", "type":"bar"}</Payload>
        <Path>/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations</Path>
    </Set>
</AssignMessage>

<JavaCallout async="false" continueOnError="false" enabled="true" name="JC-AWS-Signature-V4">
    <DisplayName>JC-AWS-Signature-V4</DisplayName>
    <Properties>
        <Property name="debug">true</Property>
        <Property name="service">lambda</Property>
        <Property name="endpoint">https://lambda.eu-west-1.amazonaws.com</Property>
        <Property name="region">eu-west-1</Property>
        <Property name="key">....</Property>
        <Property name="secret">....</Property>
        <Property name="source">outboundLambdaMessage</Property>
    </Properties>
    <ClassName>com.google.apigee.callouts.AWSV4Signature</ClassName>
    <ResourceURL>java://apigee-callout-awsv4sig-20210609.jar</ResourceURL>
</JavaCallout>

<ServiceCallout async="false" continueOnError="false" enabled="true" name="SC-LambdaCallout">
    <DisplayName>SC-LambdaCallout</DisplayName>
    <Request clearPayload="false" variable="outboundLambdaMessage">

    </Request>
    <Response>uploadResponse</Response>
    <HTTPTargetConnection>
                <URL>https://lambda.eu-west-1.amazonaws.com/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations</URL>
    </HTTPTargetConnection>
</ServiceCallout>

However I'm getting the following error from the serviceCallout
404

Page Not Found

Page Not Found

Any pointers would be greatly appreciated!

Hmmm, the configuration you are using looks correct to me.
When you say you are getting "404" and "Page Not Found" - where do you see that?
Have you used the Apigee trace to see the result of the ServiceCallout ?  Is that what is showing you the 404?
Have you used Apigee trace to verify that the Java Callout has succeeded? (With the debug flag for that callout set to true, Apigee should show you extra information in trace variables)

thanks for getting back to me Dino!
I'm seeing this in the trace indeed:

The java callout seems to be working fine:

Sure thing, Guy. I'm happy to try to help.
The Java callout DOES appear to be working correctly.  It has produced a signature, and you can see the value in the variable awsv4_sig_header.Authorization.  That variable gets set if and only if the debug property is true.  The actual Authorization header gets set on the variable outboundLambdaMessage , but that operation is not shown in Apigee trace because the Authorization header is treated as sensitive.  But the same value will be placed in the appropriate header on that message. If you would like some assurance of that, you can interject an AssignMessage between the JavaCallout and the ServiceCallout that will allow you to examine the value via trace.  Configure the policy like this:
<AssignMessage name='AM-Diagnostics'>
  <AssignVariable>
    <Name>diags</Name>
    <Ref>outboundLambdaMessage.header.Authorization</Ref>
  </AssignVariable>
</AssignMessage>

In any case, what appears to be happening is the ServiceCallout is actively receiving a 404 not found from the target you've configured.  I wouldn't expect a 404.  Normally a service that exists will respond with 403 or 401 if the authorization header is incorrect. Not a 404.
Just as a test I used the command-line tool "curl" to invoke the endpoint, in the same way your ServiceCallout would, and I'm getting a 403 Forbidden, with an appropriate security denial message, telling me the signature is expired.  That is what I would expect.
So why would servicecallout be receiving a 404?
You didn't mention which variant of Apigee you are using, or how the networking is configured. Is it possivle that there is something between the Apigee MP and the Amazon target system, that is returning the 404?  If you are running Apigee Edge OPDK, or Apigee hybrid, maybe an internal firewall or network gateway might do this.  If you are running Apigee X, then maybe your cloud networking configuration might prevent the call and return 404.
To diagnose, see if you can use curl in the same way I tried.... from a workstation that you know has good access to the internet, and then also from the system that runs the message processor.
My curl command is like this:
curl -i https://lambda.eu-west-1.amazonaws.com/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations
  -H "Authorization: AWS-HMAC-SHA256 Credential=AKIAUKXMQORYKGDIOMW3/20230414/eu-west-1/lambda/aws4_request, SignedHeaders=content-type;host;x-amz-date;x-amz-invocation-type, Signature=0e434522a6c157f7011d10772ef3cb61adc55692d3af22c6982d3ef5701ebca4"
   -H "x-amz-date: 20230414T063223Z"
   -X POST -d '{"foo": "bar"}'

hi Dino,
I've tried to run a curl and it provides the same response as Apigee, so that's good to know indeed. I've tried a million things, but one thing that's maybe good to know:
When I change the  property of the serviceCallout to:
    <Response>uploadResponse</Response>
    <HTTPTargetConnection>
        <URL>https://lambda.eu-west-1.amazonaws.com/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations</URL>
    </HTTPTargetConnection>
</ServiceCallout>

then I get the 404, but the trace also shows the requesturi is:
/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations
which makes sense, this function doesn't exist.
When I change it back to:
    <Response>uploadResponse</Response>
    <HTTPTargetConnection>
        <URL>https://lambda.eu-west-1.amazonaws.com</URL>
    </HTTPTargetConnection>
</ServiceCallout>

I get the following response (also when trying to curl the request:
{"message":"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details."}
the Authorization header seems to be created fine so I'm really not sure what is up. My full config now is:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<AssignMessage name="AM-Construct-Outgoing-AWS-Message">
    <AssignTo createNew="true" type="request">outboundLambdaMessage</AssignTo>
    <Set>
        <Verb>POST</Verb>
        <Headers>
            RequestResponse
        </Headers>
        <FormParams/>
        <Payload contentType="application/json">{"name":"foo", "type":"bar"}</Payload>
        <Path>/2015-03-31/functions/arn:aws:lambda:eu-west-1:297922491504:function:bookingExampleFunction/invocations</Path>
    </Set>
</AssignMessage>

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<JavaCallout async="false" continueOnError="false" enabled="true" name="JC-AWS-Signature-V4">
    <DisplayName>JC-AWS-Signature-V4</DisplayName>
    <Properties>
        <Property name="debug">true</Property>
        <Property name="service">lambda</Property>
        <Property name="endpoint">https://lambda.eu-west-1.amazonaws.com</Property>
        <Property name="region">eu-west-1</Property>
        <Property name="key">AKIAUKXMQORYKGDIOMW3</Property>
        <Property name="secret">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</Property>
        <Property name="source">outboundLambdaMessage</Property>
    </Properties>
    <ClassName>com.google.apigee.callouts.AWSV4Signature</ClassName>
    <ResourceURL>java://apigee-callout-awsv4sig-20210609.jar</ResourceURL>
</JavaCallout>

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<ServiceCallout async="false" continueOnError="false" enabled="true" name="SC-LambdaCallout">
    <DisplayName>SC-LambdaCallout</DisplayName>
    <Request clearPayload="false" variable="outboundLambdaMessage">

    </Request>
    <Response>uploadResponse</Response>
    <HTTPTargetConnection>
        <URL>https://lambda.eu-west-1.amazonaws.com</URL>
    </HTTPTargetConnection>
</ServiceCallout>

oh! You're getting closer. You have seen that the Path you specify in the AssignMessage, is appended to the Path you specify in the HTTPTargetConnection/URL field.  So you corrected that, good.
OK that leaves the signature match problem.  Solving that kind of problem can be frustrating, but it's usually something basic.  You're certain of the key I suppose. The signing method is the tricky part.
For your lambda to accept inbound POST messages, what is the policy? Must the payload be signed?  I am not an expert on AWS lambda so am not certain what the default behavior is.  By default the callout does not include the sha256 of the payload (POST body) in the list of signed headers.   And in your case I can see that the callout is signing these headers:

content-type
host
x-amz-date
x-amz-invocation-type

and it is not including a header like x-amz-content-sha256 in the request, which inevitably means that header is not included in the signed base.
To ask that the callout include the SHA256 of the payload in the list of signed headers, you need to set the property sign-content-sha256 to true in the JavaCallout policy.   This should be easy to try.

thanks for all the help Dino!
I tried your suggestion and a lot of other things but I can't get it to work...
Calling the lambda does work for example through Postman where one can configure the AWS authorization settings in th app itself, so not sure what's going on in Apigee.

Hello,
in case somebody else is struggling: I had the same issue with {"message":"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details."}.
I don't know if that is the issue, but the value of the canonical request (awsv4sig_creq) was POST↵/2015-03-31/functions/arn**%3**aaws**%3a**lambda**%3**aeu-central-1**%3**...
I suspect, that there is a problem with special character like the semicolon (arn**:aws:**lambda...) which is encoded to %3a.
Thats why made use of  lambda function URL.
How to invoke a lambda function url with AWS signature: https://www.youtube.com/watch?v=MXXq1M9gYY0
Hope that helps anybody.


Invalid request to outbound when sending attachment

same as https://github.com/nhsconnect/integration-adaptor-gp2gp/issues/311

Upstream issue is closed, closing this one too.


[7.1.0] Final testing :)

Forked from #497

name 'cherry_picked_pr_number' is not defined

awfafwfwfeawefawfawf


Create bx.cmd

Summary of the Pull Request
Adds a bx script that only builds the project in your current directory (and all the project's dependencies).

Detailed Description of the Pull Request / Additional comments
When we were in Windows, bz behaved a lot more like this, because obviously you don't want to build all of Windows when just working on the Console. However, when we moved the console to MsBuild, the solution only took like 4s to build, so we never bothered with creating a script to build a single project.
However, the Terminal projects take a very long time to build. So rebuilding the entire solution from the commandline became increasingly painful. This change should alleviate that pain. Hopefully quickly iterating on code in the Console codebase should be much more manageable with this change.
Building a single project in a solution is a little tricky however. You need to supply the target name to msbuild.exe, which is not as simple as just the Project's name or path. So we need to parse the sln's .metaproj file to correlate vcxproj file to target name. That's what bx.ps1 is for.
This change could use some extra love - generating the metaproj takes a little while, as does parsing it. There might be a way to only generate the metaproj if it's changed, I didn't really investigate this, but presumably it could be done with a powershell script. I'll leave that for another work item in the future. It's still much faster to build with bx than before, but it could be faster.

Validation Steps Performed
Built the thing using bx and bcx.

@miniksa Yea I totally agree. Consider bx.ps1 as me trying to get my feet wet with powershell :P

Considering that the rest of the powershell scripting we have is contained in a module (openconsole.psm1) it seems like the bx.ps1 script should be turned into an exported function from the module.
We could think about adding razzle-like aliases to the module as well, but I don’t know if that’s a typical thing for powershell modules to define aliases or if it’s better for the user to.