Offer caching

node-fetch is a pleasure to use and has made my api fetching much easier to work with and manage. Thanks!
I was wondering if it would be possible to add request caching support? While I'm sure such an implementation isn't trivial, it would save lots of resources and speed up fetching for already known responses. Thanks!
(Im not sure it's of any use, but here is a caching implementation offered for superaget)

You would be better off using your own cache (use whatever caching library you like), mostly because server-side usage varies greatly and what browsers offer is very limited.

@mbrevda FYI superagent-cache is not RFC7234 compliant. What the browser offer is caching that honors http headers, so if it's implemented on the server side, it would make sense to follow the same caching behavior.

I tried using some caching on my own and experience some issue when body was not being used and fetched from cache instead, described in #83
I would also think this would be better suited as a sub module and then use fetchEvent to intercept all request and do caching and responseWith(). read this
That way we can keep node-fetch small and modular

@jimmywarting that's an interesting approach, I like it, however I agree with the responses on that thread, it shouldn't be necessary to implement WebWorkers to offer cache. I think the best approach is to offer caching at the http/https Node library layer, with a drop-in replacement, as follow-redirects does, then enable that based on the cache option on fetch.

@tarikjn We don't exactly have to implement WebWorkers, We could just use node's EventEmitter and send a fetchEvent, and then node-fetch provides us with the api that is similar to a WebWorkers, mainly: respondWith, waitUntil, request and isReload
With that there is no need to change http/https layer. If you would like to respond with something from the cache then it would have to be a Response constructor
let respond = new fetch.Response(fs.createReadStream(...), {status: 304, header: {...}})
evt.respondWith(respond)

Sure, it's a matter of internal preference, also, while the caching logic and storage would be outside node-fetch, I believe hooking up the two should happen in node-fetch to be consistent with the browser cache option.
So node-fetch would either need to choose a caching library, or add an option for a user-provided caching library (better, since a cache would most likely take a number of options when initialized) that provides a given API, say http/https or the fetchEvent approach you are suggesting. A suggested implementation could be to start with offering the default and no-store (which would be the actual default on node) options to cache, and a cacheObject option where the user provides a cache implementing said API.
One thing I agree with, it would be easier to provide the other cache options with your approach, but as an implementation detail, the events used by the cache hook up should be black-boxed so they cannot be intercepted or be erased when say, removing all listeners to fetch, i.e. so that there is a separation between userland fetchEvent and some fetch polyfill capabilities where fetchEvent was picked as a method of implementation.

I have been working for some time to implement html5 CacheStorage for node. But it wasn't so useful without FetchEvent so i have built that too: https://www.npmjs.com/package/fetch-event.
Haven't tested this in any project yet so it's alpha for now (both of them) Would like it if you could check it out and provide any feedback you may have

See npm.im/make-fetch-happen for a wrapper around node-fetch with ~full http caching support built in. It includes a mechanism for cache manager injection, but has one by default.

I am adding this issue to wontfix but keep it open for new users.
As zkat mentioned, make-fetch-happen is one of the libs that does comprehensive caching automatically. (I should note that it doesn't directly use node-fetch stable releases, but a fork of node-fetch 2.x releases)
Other libs includes:

https://github.com/janneh/fetch-cached
https://github.com/letsrock-today/caching-fetch

Or if you need robots.txt support

https://github.com/voxpelli/node-fetch-politely

@bitinn I do not understand why this would not get into node-fetch by default and this issue carries the wontfix flag today. It’s a standard feature we can rely on within browsers, and the goal of node-fetch is to bring window.fetch to Node.js. Implementing caching outside this library is troublesome for redirects: a new URL redirecting to a URL that was already fetched would have to be downloaded again.

@pietercolpaert See zkat's code on why there won't be an agreement on how caching should be done on Node.js;
Also we never promised a full port of windows.fetch, just a compatible API.

Imo the usefulness of this port (or whatever you want to call it) is severely limited without the implementation of this option. For example, APIs like the GitHub REST API for notifications expect you to poll in intervals and to send If-Not-Modified from the value of Last-Modified in the previous last poll. If no new notifications are there, GitHub returns a 304 Not Modified and does not count towards the rate limit. If the header is not send, every poll will count towards the rate limit and will eventually error. This is logic that could be easily handled by the fetch implementation as it's specced out by WHATWG. Anyone who has custom use cases can set the cache option to no-cache. But the majority of users would benefit from having solid caching by default as specced.

Just stumbled across both this issue and the following repo from google, adding here in case it’s helpful to anyone:

https://github.com/mistval/node-fetch-cache


Issue on page /notebooks/22-ModelFitting-Bayesian.html

Can't find "mcmc_utils.R" script

Have removed bayesian chapter for now. Plan to redo it from scratch.


[shader-slang] Add cmake targets

Is your feature request related to a problem? Please describe.
There are no cmake targets added when you use this port, which means there is manual work to find the libs for linking for the end user
Proposed solution
I don't know how to author vcpkg ports so I don't know how this is done to generate cmake targets. I assume there is something in the vcpkg portfile functions to define a cmake target.
Describe alternatives you've considered
The shader-slang port seems to be installing from the released zip files, maybe it is possible to be configured to use the cmake directly that is part of the regular github repo.
Additional context
No response

Shader-slang directly downloaded the release version without source code for compilation, so no cmake usage was generated. If you want to use it in cmake, you can use find_path and find_library to find header files and calling libraries.

I assume there is something in the vcpkg portfile functions to define a cmake target.

No. Portfiles are just vcpkg scripting, not using CMake project mode.

maybe it is possible to be configured to use the cmake directly that is part of the regular github repo.

Not easily: there is a number of vendored, and possibly patched, dependencies. This needs work.
And AFAICS upstream's CMake doesn't install a CMake config package.
https://github.com/search?q=repo%3Ashader-slang%2Fslang+export+language%3ACMake&type=code&l=CMake
https://github.com/search?q=repo%3Ashader-slang%2Fslang SlangTargets&type=code

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


Mouse cursor doesn't show as hand hovering on tab header

"name": "angular-bootstrap",
"version": "1.0.3",
See the example code here: http://plnkr.co/edit/?p=preview

this is because we had to change the tab template to use <div> instead of <a> to prevent a bug whereby browsers were interpreting the click as a navigation and the page was reloading.  Let me look at the Bootstrap CSS to see what they do and we may need to add cursor: pointer to our tab.css.

This is working on our demo page and your plunker link is invalid.

I'm closing until this is fixed and it can be confirmed that it's a legitimate bug.

The plunker link is from your demo page. The plunker link is the real working code. That should count. Your demo page could use a different set of source code. I don't think your demo page should count. You should not close this ticket until it's fixed or you rejected it.

@elgs, the plunker is a button that when you click sends our tab demo HTML/JS to plunker to create a new, working one from which you can test stuff out.  If you look at a legitimate plunker URL, it has an ID string after the URL - the one you pasted does not.
Our demo page does not use different source code - it uses the exact same code for the project - not doing this defeats the entire purpose of having a demo page.  You can see this by executing a build yourself and looking in the dist folder at the index.html file that is created.
RE your comment about not closing a ticket until it's fixed or rejected:  please read my comments on your other issue entered (that I also closed due to not following instructions, #5248).  Researching every issue someone enters can take quite a bit of time.  Basically, it boils down to this:  if people cannot be bothered to take the time to read our documentation for how to properly enter issues (which makes our jobs enormously easier) then why should we enable that behavior with negative reinforcement by doing a person's work for them?

Hmmm... interesting. When I clicked the blue Edit in Plunker button, it indeed showed that url in my browser bar. But indeed, it's a wrong url. What you said is correct. Now I clicked the save button, and a new url is generated: http://plnkr.co/edit/GZyaXHpYWVLoypXWSldf?p=preview

Thank you.  I have confirmed that this is a bug and have a fix.

@elgs, I'd forgotten we had this listed in our breaking changes section here so I cannot guarantee that #5250 will be merged.  However, this was before we realized we need to add our own tab.css file to manage the changes of switch to a <div> from an <a>.
Unfortunately, this also means you did not read our CHANGELOG or did not read it thoroughly enough.  This goes back to my previous statements about respecting our time by putting forth the effort to properly research the issue on your end first.  I hope by now you can put yourself in our shoes to see how much time this takes (and this is just ONE issue).  Imagine having dozens of issues and doing this in your spare time.

@icfantv ok, I read the follow statement from the breaking changes:
tab: This causes the cursor style to be removed from the tab - implement CSS on the .uib-tab > div selector, or similar, accordingly
Does it mean I should implement something like this in my own css code?
.uib-tab > div {
   cursor: pointer;
}

I understand your time is precious. My time is also precious. I would certainly post my problem here rather than spending hours to figure it out, unless I'm really interested in the dirty details of the code. I assume people with expertise or who had similar problems could give a hint just in a minute.
If you use that fact that it is being listed in the breaking changes as an excuse that this is not a problem and may not fixed, I would assume this is a new feature of the uib-tab, rather than a bug at all. If this is the case, I have no problem, and I apologize your time being wasted by me.


Add support for new flags in PROCESS_MITIGATION_USER_SHADOW_STACK_POLICY

I modified the strings to be consistent and start with a lower letter after : in long descriptions.

I wasn't able to merge this right away as it was blocked on this commit: https://github.com/processhacker/processhacker/commit/aa7a04476982425cd654dfd042bee8bbaf1a877c
It's now been merged 👍🏿

It was unrelated to the PR but there was an internal compiler and linker error building the source that required investigation. The issue was because LTGC wasn't defined and defaulted to LTGC:Incremental which produces corrupted PDBs and several random internal compiler errors when combined with the CET, XFG, EHCONT and some other options:

So if you have issues compiling code with CET, XFG, EHCONT etc... make sure LTGC has been defined otherwise MSVC defaults to LTGC:Incremental and produces corrupted PDBs and/or unexplained internal compiler/linker errors.

So if you have issues compiling code with CET, XFG, EHCONT etc... make sure LTGC has been defined otherwise MSVC defaults to LTGC:Incremental and produces corrupted PDBs and/or unexplained internal compiler/linker errors.

Interesting, thanks for the info 👍. By the way, XFG isn't available in VS yet, at least not publicly, you have to use switch /guard:xfg to turn it on.

use switch /guard:xfg

Yep, also ehcont will be delayed until the next SDK update since the current CRT libs don't support it properly yet.
It's similar with the /brepro switch except Microsoft created a webpage stating all unofficial builds of Process Hacker source-code are malicious and added signatures to Defender enforcing it. So if builds are reproducible then both official and unofficial would be byte identical possibly creating some issues... I'm waiting for a response to an email before enabling brepro.

Yep, also ehcont will be delayed until the next SDK update since the current CRT libs don't support it properly yet...

Yes and a fact that 20H1 kernel checks for flag 0x00200000 while the newest VS sets 0x00400000 😄 so even if you set the flag and generate the data kernel ignores them. But who know maybe they'll release a fixed SDK with 20H2

/brepro is another issue which is also delayed.

Got more information on this somewhere?

Got more information on this somewhere?

Random compiler/build errors caused by LTGC:Incremental when combined with /BREPRO. I found disabling /MP fixed the initial few errors but it caused a much longer compile time for the project. The actual issue was LTGC being undefined in the solution and defaulting to LTGC:Incremental instead of LTGC which when combined with /MP (build with multiple processes) produces invalid executables when used with /BREPRO.

Antivirus false positives... Antivirus doesn't support the image timestamp field as the deterministic hash and incorrectly determine the binary as malicious because of the invalid timestamp.

Stripping PDB paths using PDBALTPATH

@TheEragon
EHCONT has now been enabled and the nightly build was updated successfully 👍

@dmex  Nice, have you switched the SDK to 21H1 or have they fixed 20H2?

@TheEragon
I fixed the buildtools ignoring the status code which was successfully compiling but being ignored. When the SDK updates or you install a newer version it will now also automatically switch to the newer version.
VS is compiling fine and generating the tables for the nightly executables so it should be working on 21H1 but other than that there isn't much else I can do if Windows isn't working properly.

@TheEragon
EHCONT seems to be completely broken in Visual Studio at the moment. No images are compiling with GuardEHContinuationTable despite the /guard:ehcont flags in the solutions?

@TheEragon
EHCONT seems to be completely broken in Visual Studio at the moment. No images are compiling with GuardEHContinuationTable despite the /guard:ehcont flags in the solutions?

That is strange, did it break after switching to VS16.9.4?

@TheEragon
Yeah, looks like it. There's a patch coming in one of the next updates:
https://developercommunity.visualstudio.com/t/Enabling-EH-Continuation-Metadata-doesn/1400623

@dmex
Just great, I wonder how much stuff gets broken with each new VS update, it feels like they fix 5 things and break another 6 sometimes.


Couple nits for dnsConfig doc

Missed a mistake from previous review --- "options" in resolv.conf should be multi-line.

This change is

@zacharysarah This one should be in.


All service methods should take into account the query parameter

Steps to reproduce
Do a PUT /service/:entityId?query=.... The query parameter is ignored and is not used to filter (where clause) the entities updated as the service update uses findById. PATCH works well.
The SQL that gets generated from the update service when retrieving the existing entity (https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L191) is SELECT * FROM entities WHERE id ='entityId' instead of SELECT * FORM entities WHERE id ='entityId' AND query='...'.
Expected behavior
Entities should be filtered with the query-string parameters before being updated.
The actual SQL query should be SELECT * FORM entities WHERE id ='entityId' AND query='...'
Actual behavior
Entities are not filtered.
System configuration
The reason this is needed is to allow updating nested services/entities which is helpful for managing many-to-many relationships.
Example
Two models User and Project with a many-to-many relationship (belongsToMany).
A User service is mounted on /users/:userId and a Project service is mounted on /users/:userId/projects/:projectId.
A before hook automatically transforms the :userId into a query parameter (hook.params.query['userId']).
The find/patch methods behave correctly. For instance, GET /users/u123/projects/p456 creates the SQL query SELECT * FROM projects WHERE userId='u123' AND projectId='p456'.
UPDATE does not behave that way as it uses findById(projectId) and, hence, makes it impossible to enforce the userId constraint. The many-to-many table has the same projectId multiple times so it cannot work.
I have not tested the get and remove method yet. I assume that they'd have the same issue as the update method.

What you want to accomplish should be doable by changing the id to null in a hook to update multiple records and setting the query parameters accordingly:
app.service('users/:userId/projects/:projectId').hooks({
  before: {
    patch(context) {
      context.id = null;
      context.query = {
        userId: context.params.userId,
        projectId: context.params.projectId
      }
    }
  }
});

Any call that has an id will always use that id to retrieve the record.

@daffl
It does not seem to work as I am in an update request and not a patch (the patch works well by rewriting the ``hook.params.queryobject as it is taken into account by the service). The documentation explicitly states thatidcannot be null for update requests with a database adapter (https://docs.feathersjs.com/api/databases/common.html#adapterupdateid-data-params---promise). I get aNo record found for id 'null'` when I try your solution.
Any reason why we can't switch the update method to use the _getOrFind method, for instance, instead of findById? I am happy to work on a PR for that if that sounds like a viable option.
Another option could be to rewrite/redirect my update request to a patch request but I haven't seen anything about that in the docs.

What is the reason to use update at all? An update to patch redirect hook can be done pretty easily by setting hook.result:
app.service('myservice').before({
  update(hook) {
    return hook.service.patch(hook.id, hook.data, hook.params)
      .then(result => {
        hook.result = result;
        return hook
      });
  }
});

@daffl
The main reason is consistency, to offer all standard REST methods on all my services. update makes some operations a little easier like removing fields from an existing object. It's really the same reasons as all other REST APIs offering update + patch and Feathers supporting it in the first place :)
Redirecting the update to patch is an ok short-term fix but does not actually implement a real update behavior (obviously) so it'd be great to be able to support the real update use-case for nested services in feathers-sequelize which requires the update method of the service to support query filtering.
I still want to point out that the fact that update has a different behavior than all the other methods (get, find, patch and remove) is a little confusing and unexpected as a user of Feathers. Let me know if I can help fix that. Again, I can work on a PR if you are open to that change (or to a different implementation that'd bring the same result).
PS: Thanks a lot for your quick answers, it's pretty impressive to see the level of support you guys are doing on top of your great work on Feathers!

It's a service adapter specific implementation, Feathers does not have any restrictions to support this functionality.
I just can't think of many use cases where you would replace an entire set of instance with the exact same data (in fact very early versions of the adapters supported this and it led to a lot more mistakes and questions than it was useful).

All right, I'll close this ticket then as the solution works for me. Thanks!


FastKafka-AI: Generate test code for the generated application code

FastKafka-AI related changes are moved to a separate repo


Register as a community plugin

Thank you for this! I find typst so much more enjoyable than latex for writing math equations. The only thing I'm missing is the ability to use this plugin on my phone to view typst equations (I use obsidian sync so I can sync to my phone).
Making this an official community plugin would make that possible.

Looks like this can be done by making a pull request here

Hi I'm glad you're enjoying it :) and I've finally made the PR! https://github.com/obsidianmd/obsidian-releases/pull/1996
I'll close this once it gets submitted!

Apparently they don't like having obsidian in the name :/

Its been accepted!


dbt==0.18.1 Package failing to install starting on March 10, 2021.

Describe the bug
Package failed to install dbt==0.18.1 starting on March 10, 2021.
Steps To Reproduce

Inside docker ubuntu:bionic with python 3. (see Dockerfile below for details)
Installing package dbt==0.18.1 started failing on March 10, 2021.
This seems to be due to a failure while installing a dependency of dbt-core==0.18.1 namely agate<2,>=1.6 which resolves to agate==1.6.2.
agate 1.6.2 was released on March 10, 2021. agate release history

Expected behavior
It should install properly.
Screenshots and log output
Collecting dbt==0.18.1 (from -r ./requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/57/06/b9a5ccb8c5e89d7295ef6a46d3c1cfd58fa48a2e705d7f03284590eeafa2/dbt-0.18.1-py3-none-any.whl
.
.
.
Collecting PyICU>=2.4.2 (from agate<2,>=1.6->dbt-core==0.18.1->dbt==0.18.1->-r ./requirements.txt (line 1))
  Downloading https://files.pythonhosted.org/packages/31/46/fa08c8efae2951e67681ec24319f789fc1a74e2096dd74373e34c79319de/PyICU-2.6.tar.gz (233kB)
    Complete output from command python setup.py egg_info:
    (running 'icu-config --version')
    (running 'pkg-config --modversion icu-i18n')
    Traceback (most recent call last):
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 63, in <module>
        ICU_VERSION = os.environ['ICU_VERSION']
      File "/usr/lib/python3.6/os.py", line 669, in __getitem__
        raise KeyError(key) from None
    KeyError: 'ICU_VERSION'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 66, in <module>
        ICU_VERSION = check_output(('icu-config', '--version')).strip()
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 19, in check_output
        return subprocess_check_output(popenargs)
      File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
        **kwargs).stdout
      File "/usr/lib/python3.6/subprocess.py", line 423, in run
        with Popen(*popenargs, **kwargs) as process:
      File "/usr/lib/python3.6/subprocess.py", line 729, in __init__
        restore_signals, start_new_session)
      File "/usr/lib/python3.6/subprocess.py", line 1364, in _execute_child
        raise child_exception_type(errno_num, err_msg, err_filename)
    FileNotFoundError: [Errno 2] No such file or directory: 'icu-config': 'icu-config'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 69, in <module>
        ICU_VERSION = check_output(('pkg-config', '--modversion', 'icu-i18n')).strip()
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 19, in check_output
        return subprocess_check_output(popenargs)
      File "/usr/lib/python3.6/subprocess.py", line 356, in check_output
        **kwargs).stdout
      File "/usr/lib/python3.6/subprocess.py", line 423, in run
        with Popen(*popenargs, **kwargs) as process:
      File "/usr/lib/python3.6/subprocess.py", line 729, in __init__
        restore_signals, start_new_session)
      File "/usr/lib/python3.6/subprocess.py", line 1364, in _execute_child
        raise child_exception_type(errno_num, err_msg, err_filename)
    FileNotFoundError: [Errno 2] No such file or directory: 'pkg-config': 'pkg-config'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-bwz5wo1k/PyICU/setup.py", line 74, in <module>
        ''')
    RuntimeError:
    Please install pkg-config on your system or set the ICU_VERSION environment
    variable to the version of ICU you have installed.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-bwz5wo1k/PyICU/

The output of dbt --version:
N/A. It would be 0.18.1

The operating system you're using:
ubuntu:bionic
The output of python --version:
Python 3.6.1
Additional context
Installing dbt==0.18.1 in a Dockerfile during build process via requirements.txt
Dockerfile:
FROM ubuntu:bionic

RUN apt-get update \
    && apt-get install -y  \
    gcc \
    groff \
    jq \
    libevent-dev \
    libffi-dev \
    libpq-dev \
    make \
    musl-dev \
    netcat-openbsd \
    python-dev \
    python3-pip \
    python3-venv \
    && rm -Rf /var/lib/apt/lists/*

COPY ./requirements.txt ./requirements.txt
RUN pip3 install -r ./requirements.txt   # <---fails here
.
.
.

Requirements.txt
dbt==0.18.*
awscli==1.*
dsnparse==0.*
boto3==1.*
jmespath==0.*

For anyone experiencing the same issue, here is a workaround.
In your requirements.txt lock the agate version to agate==1.6.1.
requirements.txt
dbt==0.18.*
# dbt's 3rd level dependency broken, so locking said dependency "agate" to working version 1.6.1
agate==1.6.1
.
.
.

Two other workarounds (thanks to @sean-rose in Slack):

Upgrading pip + setuptools to the latest version does allow the dbt installation to complete, despite the PyICU error—but the package is not installed, and it's likely to have a subtle and negative effect on agate/dbt operation.

Install icu4c (e.g. via Homebrew), and make sure its icu-config utility is accessible via the PATH. After doing this, dbt installation can complete with the latest version of agate, and its new dependency PyICU successfully installed.

However, both of those workarounds seem far from ideal! In the meantime, I agree it makes most sense to pin dbt's dependency to agate>=1.6,<1.6.2. This shouldn't be a breaking change for any users, so we'll try to include the fix in v0.19.1.


Add NullParameterCheck, closes #49

I think this check should be called ParameterAssignmentCheck and either allow parameter assignment or not.
In Java world, parameter assignment is usually considered as a bad practice http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheck.html
The check can be customised and check for null assignments if parameter assignment is allowed.
Thoughts?

Trying to keep the checks as close as possible to original checkstyle wherever possible http://checkstyle.sourceforge.net/checks.html

I think that would be a bit confusing, parameter default values aren't really the same thing as reassigning them. Java doesn't even have parameter default values. I wouldn't consider having default values for parameters bad style either.

Considering that, it's not really a deviation from the original checkstyle, it's just an additional, Haxe specific check.. The ParameterAssignmentCheck could still be added later.

Yes in Java it checks for parameter assignment in the function body but we can use the same and tweak it for haxe.
For example, I don't like default assignment like this function test(i = 12, s = "bar")  and always prefer making the parameters optional.
ParameterAssignmentCheck

allowNullDefault - false

test(i = 12, s = "bar") - invalid
test(?i = 12, ?s = "bar") - valid
test(?i = 12, s = "bar") - invalid
test(?i = 12, s = null) - invalid
test(?i = 12, ?s) - valid
test(?i = 12, ?s = null) - invalid
test(i = 12, ?s) - invalid
test(i, ?s = "bar") - valid
The check should never allow either as it's equivalent to disabling the check.
We can change the name to ParameterDefaultCheck if you think ParameterAssignmentCheck is confusing.

Regarding the first two examples:
test(?i = 12, ?s = "bar")
test(?i = 12, ?s)

These are bad code style IMO - you know about implied nullability? Because of the ?, you end up with Null<Int> which has a runtime overhead on some targets. See #86.
The either option still checks for redundancy (specifying both a null default value and marking the param as optional with ?):
// this is redundant
test(?s = null)

You have answers for everything :)
Checkstyle is about code style and consistency so worrying about the runtime performance is up-to the user but it's important for the check to have all the options covered.
So if some targets have runtime overhead using ? then the check should have an option to not allow optional parameters at all.
ParameterAssignmentCheck

allowDefaults - true/false
allowNullDefault - true/false
allowOptionals - true/false

Can we cover all the scenarios with the above options?
BTW totally off topic, I can add you as a collaborator to this repo if you are interested. Let me know.

Just to be clear, optionals are only problematic on types that are not already nullable (i.e. Int, Float and Bool on static targets). I don't think disallowing optional parameters in general makes sense (at least for this case, maybe for style preference), you'd have to check if the argument has one of these three types.
I think the check should be called ParameterDefaultCheck, not ParameterAssignmentCheck to avoid confusion like you suggested earlier. So you think both #86 and #49 should be covered with a single check?
Regarding the options:

allowDefaults and allowNullDefault seem reasonable.
allowOptionals - for the case I mentioned, this would have to be allowOptionalBasicTypesWithDefaultValueDifferentFromNull. :P The implied nullability is only really relevant for basic types. There are still valid use cases for nullable basic types though, Flixel has these in a few places for example. It only becomes pointless when you have a nullable basic type with a non-null default value - like I described in #86, in that case the user probably didn't know about implied nullability. Because of how specific this is, I originally suggested having a separate check for this.

Being added as a collaborator could be cool. I can't make any promises regarding my activity in the future though.

You are now a collaborator :+1:
Let's go with ParameterAssignmentCheck with allowDefaults and allowNullDefault for now.
You can merge whenever you are happy with this check.

Welcome to the team!

Thanks. :)
Are you sure about the name? Like I mentioned, this is not really about assignment, it's about default values.
What happens to the redundancy check (specifying both = null and ?)? Is that always run like I have it implemented right now, or is it simply covered by allowNullDefaults = false?

Sorry my bad, I mean to say ParameterDefaultCheck

I think allowNullDefaults = false? should cover redundancy check (specifying both = null and ?)

I have started documenting all the checks sometime back. If you guys have gitbboks account I can add as collaborators there as well.
https://adireddy.gitbooks.io/haxe-checkstyle/content/

@adireddy I now do, signed up with GitHub so same account name.

I signed up for an account when you moved docs to gitbook, but it didn't allow me to edit, so I didn't pursue it further.

Awesome. Just added both of you.

Gonna start with a fresh branch for this.


Contributors profile added

I have added the profile picture and GitHub link of every contributor and fixed a card bug.
@smaranjitghose Have a look :)

I guess we have some people left out. Cross-check with this please


Updating tests to run with UI changes - MANY problems commented out -…

… changes in Detail pane are causing failures. These test issues must be addressed - and the tests must be run every day.

@ldimaggi ,
Those tests are failing due to https://github.com/fabric8io/fabric8-planner/issues/1347 , https://github.com/fabric8io/fabric8-planner/issues/1348
Let's wait for them to fix !
@sanbornsen can you look into those bugs!


Reduce storage on RequestManager

During the work in #203 , #201 , #202 , etc I discovered that the contract's logic mainly comes into play when challenge or L1 resolution is triggered.
The main task is to check what was forwarded by the L1 Resolver. In the previous work, information have been more and more encapsulated into a hash defining specific information.
Since the L1 resolver can be trusted the RequestManager only needs to look at the correct row in the resolution registry and act based on the submitted address (eligibleClaimer).
The request manager does it by recreating the hash based on the stored information and then use it as the key. The actual plain information are not needed as they are only compared (indirectly by comparing the hash) with what was forwarded to the registry.
We mainly don't need most of the information of requests.
The contracts need to make sure that deposits are paid out to the rightful claimer. The information of a claim cannot be trusted anyway as they are submitted by a claimer. Here the other challengers must step in.
In case of L1 resolution the contract only needs to identify the correct entry in the mapping. this is done by the hash. Thus, it is enough to store only the hash in the first place and dump most other information in the contract.
todos
It needs to be sorted out which information can be stored in the hash and which we still need in the contract. For Example, amount needs to stay.
Remove all unnecessary information and just store it in the form of the request hash.

@fredo this one may be relevant to our discussions next week. Also related to #927.

This can be closed now that the pre-audit contract changes have been done. Further ideas regarding storage reduction should be outlined in new issues.


[Editors] Form based editor for hdbtable

Form based editor for hdbtable

to be tracked in

#1190


NotImplementedError: Conversion for TF op 'Bucketize' not implemented.

Error encountered while converting the TensorFlow model to CoreML model:
NotImplementedError: Conversion for TF op 'Bucketize' not implemented.
TensorFlow uses the following code for training:
numeric_column = tf. Feature_column. Numeric_column (col)
buket_col = tf. Feature_column. Bucketized_column (numeric_column, boundary_dict [col])
embedding_column = tf.feature_column. Embedding_column (buket_col, K + 1)
How do I skip support for bucketized_column?

Could you ask a feature request for the CoreML converter instead? The missing support should be completed in the Core ML conversion side not in the TensorFlow project.


pyvisa can write but cannot read from Keithley 2602A

I’m connecting my Keithley 2602B directly to my mac via ethernet.
import visa
rm = visa.ResourceManager()
keithley=rm.open_resource(“TCPIP::<IP_ADDRESS>::5025::SOCKET")

below is my system information
python -m visa info

Machine Details:
Platform ID:    Darwin-15.0.0-x86_64-i386-64bit
Processor:      i386
Python:
Implementation: CPython
Executable:     /Users/Guozheng/anaconda/bin/python
Version:        2.7.11
Compiler:       GCC 4.2.1 (Apple Inc. build 5577)
Bits:           64bit
Build:          Dec  6 2015 18:57:58 (#default)
Unicode:        UCS2
PyVISA Version: 1.8
Backends:
ni:
Version: 1.8 (bundled with PyVISA)
#1: /Library/Frameworks/visa.framework/visa:
found by: auto
bitness: 32, 64
Vendor: National Instruments
Impl. Version: 14680064
Spec. Version: 5243904

It is totally OK when I write something to Keithley
keithley.write("smua.measure.count = 1")
keithley.write("smua.measure.r(smua.nvbuffer1)")

I knew that worked because if I go to Keithley recall the value I can see it there.
However, when I tried to read the value by setting
keithley.term_chars = '\n'
resist = keithley.ask("printbuffer(1, nvbuffer1.n, nvbuffer1)")

it gives me error message:
pyvisa.errors.VisaIOError: VI_ERROR_TMO (-1073807339): Timeout expired before operation completed.
and on the Keithley display it said:
ERROR CODE:-286
attemped to index global 'nvfugger1' (a nil value)
Another symptom is that when I do:
keithley.query("*IDN?")
it gives me this error:
pyvisa.errors.VisaIOError: VI_ERROR_TMO (-1073807339): Timeout expired before operation completed.
I have no idea what that means. Thanks for any suggestion!

Using python3.5 cleared the issue.

I am anyway surpirsed becasue I am using python 2.7 without any trouble. Thanks for the information.


[Material 3] DatePicker misses "Clear" button

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Users should be able to use a "Clear" button in the DatePicker (possibly in the TimePicker too), to allow users to clear an already selected date.
Proposal
Material 3 specifies a "Clear" button in the bottom-left corner for date picker, alongside the "Cancel" and "OK" buttons.
Some time ago, this was visible in a screenshot on the M3 specs tab.
However, this screenshot seems to have been replaced, but the old screenshot can still be seen in the following issue: #114088
Additionally, it is also mentioned in the accessibility section:
https://m3.material.io/components/date-pickers/accessibility#4104e0b7-f40b-4e33-9b90-432c0e2dec5e

Hey can you assign this task to me.

Hey can you assign this task to me.

Thanks for your interest. However, we don't have the M3 token defaults or know much about this. If we get more details, I'll ping you here.

Okay, Thanks for the reply

@TahaTesser
This concludes everything that I could publicly find about such a button in Material Design, maybe your cc can gather more official information.

Unfortunately, https://archive.org only has a few versions of https://m3.material.io so even using an archive I couldn't find any more details, however I also didn't find the screenshot which I mentioned above, so we don't know if there was a version with more details that since has been silently removed.
Other projects that use Material Design (or a variant of it), are implementing clear buttons on their one but seemingly without any official specification. (at least I couldn't find any links to MD specifications)
The most information, I found about such a use case, were in the material-components-android repository.
There were even several comments about the design team being aware and wanting to implement it, for example: https://github.com/material-components/material-components-android/pull/2371#issuecomment-1123894012
There is also this ongoing issue for it in the same repo, which seems to receive more traction even from the official MD side:
https://github.com/material-components/material-components-android/issues/1332
and
https://github.com/material-components/material-components-android/pull/3145
Besides all that, the demand for such a button seems to be high, not only for Flutter but also in other UI toolkits (Angular, React, Vue, Android, MD Bootstrap, ...).
Therefore, I think it would probably be very beneficial to either directly provide a solution in Flutter or push it again to the Material Design guys/gals for a definitive solution, which can then be implemented into Flutter.
Links to projects that implemented a similar functionality in their "Material" date pickers: (not exhaustive)

https://mdbootstrap.com/docs/standard/forms/datepicker/
https://github.com/mui/material-ui/issues/30676#issuecomment-1073744821

An optional clear button driven by a bool on the pickers and their themes sounds good to me


[ISSUE ##3832] in order to improve the performance by change the variable location of queueId

Make sure set the target branch to develop
What is the purpose of the change
#3832
Brief changelog

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

The wildcard import is not allowed. Revert.

+1

the problem about wildcard have fixed

Coverage decreased (-0.04%) to 51.259% when pulling f2fb730fe2f5710c491ec31afab480c47aed2e74 on Aaron-TangCode:develop into 810b75766b7cd6692f871208aaec43f6132abfe1 on apache:develop.

Codecov Report

Merging #3833 (f2fb730) into develop (810b757) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #3833      +/-   ##
=============================================
- Coverage      47.25%   47.18%   -0.07%
+ Complexity      4892     4884       -8
=============================================
  Files            636      636
  Lines          42468    42467       -1
  Branches        5553     5553
=============================================
- Hits           20068    20040      -28
- Misses         19900    19922      +22
- Partials        2500     2505       +5

Impacted Files
Coverage Δ

...main/java/org/apache/rocketmq/store/CommitLog.java
74.21% <100.00%> (-0.03%)
:arrow_down:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...apache/rocketmq/remoting/netty/ResponseFuture.java
85.00% <0.00%> (-5.00%)
:arrow_down:

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...rocketmq/remoting/netty/NettyRemotingAbstract.java
46.88% <0.00%> (-4.03%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
50.74% <0.00%> (-1.50%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
61.00% <0.00%> (-0.92%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.28% <0.00%> (-0.67%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
67.99% <0.00%> (-0.52%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810b757...f2fb730. Read the comment docs.


Reconcile the purpose and usage of Analysis Type override and Inclusion override in rules engine

AnalysisType can be three things: ALLOWED_HEATING_USAGE, ALLOWED_NON_HEATING_USAGE, or NOT_ALLOWED_IN_CALCULATIONS.  This value is set for each billing period by an algorithm, one for Natural Gas, and one for Oil/Propane.  The result of these calculations then determines whether a particular bill is appended to bills_winter or bills_summer or bills_shoulder.  The user is then allowed to override this algorithm for a particular bill in the UI by setting inclusion_override for that bill to True.  The result in the rules engine should be then that that bill is either included or excluded from winter or summer calculations (whichever it is in).  However, if a bill is added to bills_shoulder and the user sets inclusion_override to True on that bill, we don't necessarily know whether they intended for that bill to be added to winter or summer calculations, although we could make an educated guess.  But in that situation, we would need to add that bill to the appropriate "bills" list.  The question I had is, in reacting to inclusion_override settings by the user, should we be writing the code to add or remove bills from the winter or summer bills lists prior to various calculations, or should we be simply inserting "inclusion_override truth" tests in various calculation functions.  Given that this inclusion_override feature was not designed into the rules_engine from the start, I think this question must be tackled before we attempt to write code.

This week I got curious about how to reconcile analysis_type_override and inclusion_override in the code.  So, I made a number of changes and verified that the tests still run.  These are staged in PR#241.  Comments and questions are welcome.

This issue is fixed by the changes committed in PR#241


Disk-AccessPath: fixing get-partition to pull current state of object

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md in the resource folder.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #198 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@        Coverage Diff         @@
##           dev   #198   +/-   ##
==================================
- Coverage   94%    93%   -1%
==================================
  Files        8      8
  Lines      889    889
==================================
- Hits       837    832    -5
- Misses      52     57    +5

Updated with the patch. I want to run this through some integration tests before calling it good.

Updated with the patch. I want to run this through some integration tests before calling it good.

I've tested this in a live environment and confirmed this fix.

@JoshuaJSwain - when this one https://github.com/PowerShell/StorageDsc/pull/201 goes through then you can rebase and see if your tests still pass (I'd expect some to fail).

Ok @JoshuaJSwain - #201 has gone through. Can you rebase and see if your tests pass and correct if necessary?

Hi @JoshuaJSwain - this is what I expected- the tests to fail as they weren't actually very good. Now they are better tests you will need to correct them to validate your code correctly.

I take a look at this one week of 4/8. Should be straight forward to fix
them up. Thanks!
Josh Swain
On Thu, Mar 28, 2019, 5:25 AM Daniel Scott-Raynsford <
<EMAIL_ADDRESS>wrote:

Hi @JoshuaJSwain https://github.com/JoshuaJSwain - this is what I
expected- the tests to fail as they weren't actually very good. Now they
are better tests you will need to correct them to validate your code
correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PowerShell/StorageDsc/pull/198#issuecomment-477493451,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdawlETt0V1NeKeptgjAxeYQIHwPuTKMks5vbHpBgaJpZM4bdbOw
.


Missing word in documentation

Documentation states:
"All operators and functions are constexpr and use attribute whenever possible."
And I wonder which attributes is used whenever possible.

that's in my .adoc file
All operators and functions are constexpr and use attribute [[nodiscard]] whenever possible.
using
All operators and functions are constexpr and use attribute +[[nodiscard]]+ whenever possible.
works!


ev.srcEvent.srcElement is not where Swipe began

I suspect my issue might be related to #815
The following code isn't accurately showing where swipe action has started. Instead it output the name where swipe is completed.
hammertime.on('swipeleft', function(ev) {
   console.log(ev.srcEvent.target);
});

Also it seems these three items always share the same values ev.srcEvent.target, ev.srcEvent.toElement and ev.srcEvent.srcElement

The problem is still present. When will this be fixed?


move IRC formatting over to IRCJ

Currently formatting like colours are added directly to the string, which hurts readability, IRCJ now provides these colours as an enum, which would help with readability of the codebase

implemented in commit 607978123f2bbdf2addcc7ef6b3b249647c326d7


Fix vulnerability in objectToCamelCase

Don't let objectToCamelCase overwrite an existing property

Do we even need this method. Can't we just use camelcase lib inside ssz.toJson instead of doing it here?

Good question, this was just a specific issue that the auditors found. I don't think the way we're using this function is currently a problem, but this is just to say that we've "addressed" the audit issues.
Definitely would love to remove this function if we can.


Manacher's Algorithm For (Longest Palindromic Substring)#76

Related Issue

[ADD] Manacher's Algorithm For (Longest Palindromic Substring) #76

Proposed Changes

I have added the short and crisp explanation with comments and code, You can check if something better i can do Let Me Know !!

Additional Info

Manacher’s Algorithm helps us find the longest palindromic substring in the given string in better complexity then the Brute Force Solution also the Dynamic Programming Solution in Linear Time and Linear Space.It will reduce the number of expands for the each index it saves the length of previously occured palindrome length.

Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the documentation.
[x] 🎀 I have updated the documentation accordingly.
[x] 👀 I have read the CONTRIBUTING document.
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[x] 🌟 ed the repo

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1
Screenshot #2

Main Code
Code with Solution

hey @miraj0507 is it everything fine ?

Delete the unncessary png Files
Fetch Upstream And EDIT README of the folder according to your algorithm
Uncheck all the checks which do not apply to you

You need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

Sure i will change all the changes you want @Lakhankumawat give me some time.

Hi @Lakhankumawat  can you please help me that what are you waiting for ?? Is there any problem in my solution ?

Closing this pr!


Create Java cfn-response equivalent (#558)

Introduce Java implementation of the cfn-response module based on NodeJS design.
Issue #, if available:
Addresses #558
Description of changes:

Add new powertools-cloudformation Maven module to house the sole Java class, CloudFormationResponse.
Include one new parent POM dependency on software.amazon.awssdk:http-client-spi:${aws.sdk.version}.
Add Unit Test class with 100% code coverage.

Checklist

[ ] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[ ] PR title follows conventional commit semantics

Breaking change checklist
None. New code.
RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Is the SpotBugs / codecheck failure a false positive?
The logs do not show any violations for the impacted module:
/home/runner/work/aws-lambda-powertools-java/aws-lambda-powertools-java/powertools-cloudformation/target/spotbugsXml.xml has 0 violations

A couple of questions from me.

Do you think it would be useful to include a builder for ResponseBody this would give customers a similar feel to using the v2 SDK and other AWS Java libraries?
Can you add documentation for this module so it appears on the website - https://awslabs.github.io/aws-lambda-powertools-java/

ResponseBody is currently more of an internal object for producing the desired JSON payload. We could directly expose that object for maximal control and have that be passed to a singular "send" method instead of having various polymorphic "send"s with different parameters. Alternatively, we could make the overall class follow the builder pattern, culminating in a "build" that would actually perform the "send". I do like the idea of having a builder here one way or another. I'm not particularly fond that I cannot specify a noSend arg without having to explicitly specify a physicalResourceId arg as well.
Certainly! I totally didn't notice the docs folder earlier.

Another design issue for your consideration: Right now there's a single ObjectMapper that arguably does double-duty: format the overall JSON in the HTTP request and format the Object responseData that gets included in that payload.
For my own application, e.g. I would ideally like to pass a software.amazon.awssdk.services.chime.model.CreateAppInstanceResponse as the "responseData", but this class does not serialize nicely. I could pass in my own ObjectMapper that would support serializing this type, but then that might interfere with overall JSON serialization (which is why I've currently made the constructor that accepts the ObjectMapper arg protected). Some ideas:

Instead of a generic Object arg, use Map<String, Object> or possibly Map<String, String> to better mimic the "list of name value pairs" described in the JS/Python versions.
Allow a custom ObjectMapper to be provided on init, but keep it separate from the generic ObjectMapper used to produce the overall JSON (might be a bit tricky to implement)
Or just leave things the way they are.

Is the SpotBugs / codecheck failure a false positive?
The logs do not show any violations for the impacted module: /home/runner/work/aws-lambda-powertools-java/aws-lambda-powertools-java/powertools-cloudformation/target/spotbugsXml.xml has 0 violations

Yeah I have been trying to figure this one out. It looks like it fails on PRs where author donot have access to repo. I need to find some time to troubleshoot this further.

@bdkosher Firstly, Thanks for opening the issue and PR.
I am thinking out loud here but will it be better developer experience if we provide abstract implementation like this:
public abstract class CloudformationCustomResource {

    public Object handleRequest(CloudFormationCustomResourceEvent input, Context context) {
        Response response = null;

        switch (input.getRequestType()) {
            case "CREATE":
                response = create(input, context);
                buildAndSendCfnResponse(response, input, context);
                break;
            case "UPDATE":
                response = update(input, context);
                buildAndSendCfnResponse(response, input, context);
                break;
            // and so on
        }

        return response;
    }

    protected void buildAndSendCfnResponse(Response response, CloudFormationCustomResourceEvent input, Context context) {
        // Map Response to Response Body
        // Send response
    }

    public abstract Response create(CloudFormationCustomResourceEvent input, Context context);

    public abstract Response update(CloudFormationCustomResourceEvent input, Context context);

    public abstract Response delete(CloudFormationCustomResourceEvent input, Context context);
}

Then from builder perspective, we can control alot of things, for example, Response object can have all the builder goodness and be very specific to what we expect users to provide us. It can be a good place to capture mapper as which they would want us  to use to serialize response data.
Also then builders wont need to know too much details about how to handle custom resource events etc. From their perspective, they just need to do their stuff for create, update and delete and provide us a response object.
What do you think? I believe this is closer to the implementation we have for python one.
Builder experience then looks something like this:
public class CustomResourceHandler extends CloudformationCustomResource {

    @Override
    public Response create(CloudFormationCustomResourceEvent input, Context context) {
        return null;
    }

    @Override
    public Response update(CloudFormationCustomResourceEvent input, Context context) {
        return null;
    }

    @Override
    public Response delete(CloudFormationCustomResourceEvent input, Context context) {
        return null;
    }
}

Seems like a good idea; as far as I know, CloudFormationResponse only gets used in the context of a handler that does some sort of one-time stack setup action based on the event type. So if I understand you correctly, we'd add two more classes:

An abstract base handler class that would allow subclasses to just "do their stuff for create, update and delete and provide us a response object"

Should we have the create/update/delete methods call send() with ResponseStatus = SUCCESS, Response = null by default? Subclasses would only need to override the methods they care about.
What's the proper way to handle the situation when communication to the custom resource fails? Invoke some other method that subclasses could override if they wanted to?
Should this class itself implement RequestHandler?

A custom Response type to model the response data included in the send payload, plus a nested Builder for that type.

I'm debating between having Response hold name/value pairs vs. essentially be a wrapper for some java.lang.Object with option to customize its ObjectMapper. I know for my application's case, it's more convenient to manually convert my response object to a Map than configuring a custom ObjectMapper.
void sendResponse(event, context, status, CreateAppInstanceResponse chimeResponse) {
    // easier to do this than configure a mapper to serialize artifact object type
    Map<String, String> data = Map.of("AppInstanceArn", chimeResponse.appInstanceArn());
    new CloudFormationResponse(ApacheHttpClient.create()).send(event, context, status, data);
}

Should we have the create/update/delete methods call send() with ResponseStatus = SUCCESS, Response = null by default? Subclasses would only need to override the methods they care about.

Idea was to basically let users return a custom response object which we provide with builders etc. Users can decide based on the processing what will be the status etc. But basically we accept most of the parameters (Some optional probably) which users would want to send in response. This will include a custom object as well as part of response. The response object can then as well provide a method to accept custom object mapper which they would probably want to use when serializing response object. Builder dont need to then worry about sending the repsonse itself. That will be taken care by the handler which we implement as part of CloudformationCustomResource  . Makes sense ?

What's the proper way to handle the situation when communication to the custom resource fails? Invoke some other method that subclasses could override if they wanted to?

It might be an idea to give an optional hook which is called in case send response invocation fails. Although I wonder what would user do in that case ? But still it might be a good idea to provide that flexibility .

Should this class itself implement RequestHandler?

That was my thought yes. So Builder just need to provide implementation of three methods and return the response object.

I'm debating between having Response hold name/value pairs vs. essentially be a wrapper for some java.lang.Object with option to customize its ObjectMapper. I know for my application's case, it's more convenient to manually convert my response object to a Map than configuring a custom ObjectMapper.

I believe it can accept any object, which could be a map as well if they want it to be. We can document that by default it will be serialized using default instance of object mapper, but if they want to use specific object mapper configuration, they can provide one as part of the custom Response object.

Is the SpotBugs / codecheck failure a false positive?
The logs do not show any violations for the impacted module: /home/runner/work/aws-lambda-powertools-java/aws-lambda-powertools-java/powertools-cloudformation/target/spotbugsXml.xml has 0 violations

Yeah I have been trying to figure this one out. It looks like it fails on PRs where author donot have access to repo. I need to find some time to troubleshoot this further.

Try rebasing with master and that should now fix spotbugs check issue for now.

Pushed another commit taking most of your feedback into consideration.

I left CloudFormationResource public for the time being. Since other language modules effectively provide that object alone, I was hesitant to make it inaccessible for Java classes.
The abstract Handler class still requires an SdkHttpClient arg at present. Still unsure about adding a default impl and dependency.
No documentation updates included as of yet. I plan to add them to the PR once we finalize the APIs.

I think everything looks much better. This is seems to shape up real nice now.
I still believe it's better to close CloudFormationResource down. See it's easier to open it up based on community feedback and hearing use cases around it later than starting with an open one. Then it's impossible to close it ever.
For Default client, I think especially for the use case of Custom resource, Cold start is a big problem, so if I have to choose taking a extra dep over better builder experience and ease of use, I would say latter wins :)

True. OK with "software.amazon.awssdk:url-connection-client" as the default client? Looks to be the smallest client size-wise.

Sounds good


collect host connection state for all power states

fixes https://github.com/pryorda/vmware_exporter/issues/120

Lgtm, needs a test though?

Lgtm, needs a test though?

not sure, I think current tests cover this, but could add additional scenarios.


Extension api: WorkspaceSymbolProvider.resolveWorkspaceSymbol is never called without working around the type system

Version: 1.32.0-insider
Commit: ce073b0076ac2f69faf2c609af72f9b81506c791
Date: 2019-02-27T06:15:35.767Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Darwin x64 18.2.0
Docs for WorkspaceSymbolProvider.provideWorkspaceSymbols state that:

To improve performance implementors can implement resolveWorkspaceSymbol and then provide symbols with partial location-objects, without a range defined. The editor will then call resolveWorkspaceSymbol for selected symbols only.

Unfortunately, there is no type-safe way of creating Location objects with an undefined Range.
Using Range or Position in the only constructorconstructor(uri: Uri, rangeOrPosition: Range | Position); results in resolveWorkspaceSymbol never being called.
If you hack around the type system, you can get around this constraint. e.g. undefined as any as the constructor arg, or (location as any).range = undefined; after construction.  Once you do this, resolveWorkspaceSymbol is called as expected.
So the logic does work, it's just awkward to get there without battling the type system.
Thanks!

@mjbvz Do you have a good idea? Technically we should allow to have Location#range be Range | undefined. That how it used to be but didn't spec it like that and doing so seems less pretty ;-)
How about asking to resolve an item independent of having a range but whenever the provider has a resolve function? Optionally we can add a isResolved property so that we avoid asking too many times.

Interesting. From a type perspective, we would need to remove the location property from SymbolInformation and add it back with a different type. Something like this would work:
type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>;

provideWorkspaceSymbols(query: string, token: CancellationToken): ProviderResult<
    Array<Omit<SymbolInformation, 'location'> & {
        location: Omit<Location, 'range'> & { range?: Range }
    } >
>;

This makes intellisense pretty ugly and you still would not be able to use the Location or Range constructors so I don't think this is a good solution.
Another option would be to create constants for unresolved ranges:
// In d.ts
export const UnresolvedRange: Range;

// Which behind the scenes could be defined as:
export const UnresolvedRange = new Range(-1, -1, -1, -1);

Or maybe just treat any invalid range (such as having a negative line number) as unresolved?

Moving this out, the easiest is to use the ! operator for now

This is a valid issue but we have no simple fix for it. I believe doing special type gymnastics just for this case isn't worth the gain. Sorry, but closing without fix.

The plan is as follows:

When a provider implement "resolve" we will always call that function when an item is being opened. In real life that's once
With that in mind in doesn't matter what range a provider returns, a good default would be (0,0,0,0)

fyi @dbaeumer

Added support to LSP.


[8.x] Add invisible modifier for MySQL columns.

This PR adds support for the new invisible modifier for columns introduced in MySQL 8.0.23: https://dev.mysql.com/doc/refman/8.0/en/invisible-columns.html
Columns marked as invisible are not implicitly selected by SELECT * and therefore, the columns will also not be automatically hydrated in a Laravel model. Those columns can still be selected explicitly, however, making it useful for columns that contain data that should only be fetched if really needed.
A concrete use case might be a model that contains several big JSON structures (e.g. with translation strings in multiple languages), but you only want to select specific keys out of those structures (only translations for the current language and a fallback language, for example). If you always fetched the whole translation structure, a lot of bandwidth and memory are wasted, and you will quickly run into sort buffer limits (which is the main reason why I would love to see this supported).
With this, you can use a new ->invisible() method on the table Blueprint:
Schema::table('users', function (Blueprint $table) {
    $table->string('secret')->nullable()->invisible();
});

This feature is not available in PostgreSQL and I am not aware of any other DBMS supporting this.
I am not sure if you want any modifiers in that are not widely supported, so this is only a suggestion.
However, I do not see an easy way to turn this into a package?

Great feature added!!!


dbus-glib: 0.110 -> 0.112

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dbus-glib/versions.
meta.description for dbus-glib is: "Obsolete glib bindings for D-Bus lightweight IPC mechanism"
meta.homepage for dbus-glib is: "https://dbus.freedesktop.org"
meta.changelog for dbus-glib is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.112 with grep in /nix/store/0kipsvfqjw38y60halz6bc2659radibm-dbus-glib-0.112

found 0.112 in filename of file in /nix/store/0kipsvfqjw38y60halz6bc2659radibm-dbus-glib-0.112

directory tree listing: https://gist.github.com/6ec3b6ec55f60c61222e663805a3fadd

du listing: https://gist.github.com/d4ef4bcd6a9e6fc9e73fea81fcaee038

Rebuild report (if merged into master) (click to expand)

5883 total rebuild path(s)

2671 package rebuild(s)

2633 x86_64-linux rebuild(s)
1376 i686-linux rebuild(s)
517 x86_64-darwin rebuild(s)
1357 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
DisnixWebService
R
Sylk
_1password-gui
a2jmidid
abcl
adapta-gtk-theme
adoptopenjdk-icedtea-web
agi
aiodnsbrute
airtame
aj-snapshot
alarm-clock-applet
alchemy
alda
aldor
alfred
alloy
alloy4
alloy5
almanah
ammonite
ammonite_2_12
ammonite_2_13
android-studio
androidStudioPackages.beta
androidStudioPackages.canary
androidStudioPackages.dev
androidStudioPackages.stable
anki
anki-bin
ankisyncd
ansible-lint
antlr
antlr3
antlr3_4
antlr3_5
antlr4
antlr4_8
anydesk
apache-airflow
apache-directory-studio
apache-flex-sdk
apache-jena
apache-jena-fuseki
apacheKafka_2_4
apacheKafka_2_5
ape
apeClex
apktool

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0kipsvfqjw38y60halz6bc2659radibm-dbus-glib-0.112 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dbus-glib https://github.com/r-ryantm/nixpkgs/archive/62241854d1a914291be37fa094032a3a116526c8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0kipsvfqjw38y60halz6bc2659radibm-dbus-glib-0.112
ls -la /nix/store/0kipsvfqjw38y60halz6bc2659radibm-dbus-glib-0.112/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

Changes look okay: https://gitlab.freedesktop.org/dbus/dbus-glib/-/blob/dbus-glib-0.112/NEWS

Result of nixpkgs-review pr 120982 at 62241854 run on x86_64-linux 1

235 packages marked as broken and skipped:

aldor
atom-beta
bonfire
cassandra_2_1
cassandra_2_2
displaycal
dockbarx
electron_3
electron_4
electron_5
...

1987 packages skipped due to time constraints:

DisnixWebService
R
Sylk
_1password-gui
a2jmidid
abcl
adapta-gtk-theme
adoptopenjdk-icedtea-web
agi
aiodnsbrute
...

56 packages built successfully:

alfred
authy
azuredatastudio
bluez (bluez5)
cdemu-client
chromedriver
connman-notify
dbus-glib
dee
electron (electron_12)
electron_10
electron_11
electron_6
electron_7
electron_8
electron_9
encryptr
gnome2.GConf
gnome2.gnome_vfs
gnome2.libbonoboui
gnome2.libgnome
gnome2.libgnomeui
gpsd
gromit-mpx
hubstaff
jdk (jdk16 ,jre ,openjdk ,openjdk16)
libappindicator (libappindicator-gtk3)
libappindicator-gtk2
libaudclient
libdbusmenu
libdbusmenu-gtk2
libdbusmenu-gtk3
libunique
lightlocker
lighttable
marp
mattermost-desktop
networkmanager
networkmanager098
obex_data_server
openobex
openrazer-daemon (python38Packages.openrazer-daemon)
python38Packages.dbus-next
python38Packages.dbus-python
python38Packages.desktop-notifier
python38Packages.keyring
python38Packages.notify2
python38Packages.openrazer
python38Packages.poetry
python38Packages.pybluez
python38Packages.swspotify
sweep-visualizer
systemd-wait
throttled
tixati
vscode

2 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/libraries/dbus-glib/default.nix:34:5:
   |
34 |     maintainers = [ ];
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/development/libraries/dbus-glib/default.nix:32:5:
   |
32 |     license = with lib.licenses; [ afl21 gpl2 ];
   |     ^


Download Demo Videos 404

Can you please fix the demo download link for the testsets? Itś currently 404. Thanks a lot.

Solved!
Sorry for late:<

@PJunhyuk Seeing 404s again:
❯ cd testset && chmod u+x ./download_testset_wget.sh && ./download_testset_wget.sh && cd -
--2018-10-17 02:03:37--  http://flovill.com/dataset/shoulder_press_1.mp4
Resolving flovill.com... <IP_ADDRESS>
Connecting to flovill.com|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2018-10-17 02:03:38 ERROR 404: Not Found.

--2018-10-17 02:03:38--  http://flovill.com/dataset/shoulder_press_2.mp4
Resolving flovill.com... <IP_ADDRESS>
Connecting to flovill.com|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2018-10-17 02:03:39 ERROR 404: Not Found.

--2018-10-17 02:03:39--  http://flovill.com/dataset/shoulder_press_3.mp4
Resolving flovill.com... <IP_ADDRESS>
Connecting to flovill.com|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2018-10-17 02:03:40 ERROR 404: Not Found.

Solved!
Thx for your comment :>


Add Philip Bolting to Contributors list

Hi Roshan, please add me to the list. Thank you for the tutorial. Cheers, Philip

@conphibo, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Allow changing paypal email when editing expense

Sometimes people want to change the paypal address after submitting an expense. The submitter, core contributor, and host admin should be able to change the paypal email when needed.
Here's an example.

Yes please, we stumbled on this issue.

I've been thinking about this, and I believe the issue is that the Open Collective system is designed to associate one email address per user, and also use that as their paypal address. If everyone has their own OC account and directly submits their expenses, this works. However, in practice, sometimes admins are submitting expenses on behalf of other people. This comes up fairly often (again today which is why I thought about it).
I can see arguments for both approaches (requiring expenses be submitted by that person with their own account, and allowing people to submit expenses on behalf of others). But Open Collective should make a clear decision about it, and either allow inputting alternative payment info or some documentation/help text explaining that we don't do that and asking them to get the payee to create their own account and submit the expense.
Personally I would suggest allowing expense submission on behalf of others, because it's more permissive, and it's pretty common that someone does paperwork on behalf of others in practice. Maybe the expense for could have an option saying "pay to me" or "pay to someone else > input their name and paypal address".
@cuiki  @piamancini or @xdamman do you have an opinion?

I agree. Maybe. I’d love to rethink the flow of submitting an expense to integrate this but also the difference between submitting an expense (to be reimbursed for) and submitting an invoice (to pay the vendor).
This is a big work and we should include @cuiki in the conversation so that he can help us through the design process.

You could coordinate with @cuiki on this. But right now he is busy on the foundation UI elements to make the entire platform more consistent. And after that his priority will be to redesign the create order flow which is the most important flow and that needs love.
So not sure when he will be available for this :-(
But I would definitely love to also give some love to the expense flow.

We still need this fixed

This is now possible in the new expenses page, but not yet in the host dashboard.


Catch up with modern scrcpy

scrcpy-gui was built off of scrcpy_helper, and such only has features from up to scrcpy version 1.4. More options need to be added to the GUI to catch up to scrcpy's latest release.

The program is mostly caught up as of commit 9c6c59e which was released as version 1.2.0. Even though screen recording hasn't been added just yet, I'm going to close the issue for now. May re-open it or create a separate issue later.


ci: Build on windows

This requires a few hacks to avoid hitting the Windows path limit, plus a few generalisations around path names and usage of platform-specific extension traits.

Hey @cameron-martin, would like help on this one?

Yes please. I believe the problem is that paths of certain files in the runfiles tree exceed the 260 character limit imposed by Windows. I fixed this for the rules_rust bzlmod examples in https://github.com/bazelbuild/rules_rust/pull/2454, but for some reason the paths here are still exceeding this limit. I'm yet to work out why this is, so help is very much appreciated.

Added commit to fix failing tests under windows in https://github.com/cameron-martin/bazel-lsp/pull/55, feel free to cherry-pick that commit to this PR or close the other PR if not useful.

Thanks. I've added your commit to this PR since I had to fix a rust-analyzer issue too. I'll close your PR, but thanks for fixing this issue!

I believe this issue is fixed, but I've enabled a setting that should make builds public in #58.


Linking directly to the thread view from a comment notification is confusing

As a member of an organization, when I get an email about a new comment with no context of the document, it's hard for me to understand what's happening on the page:

/cc @max @teich

Wrong repo, can you re-open on web?


switch custom form control

I see another day that the issue https://github.com/twbs/bootstrap/pull/23004 is no longer in Project 4.2, is it possible to reconsider this? would be a very important component.
Thanks.

No need to make new issues for this though.


feat(schematron): replace skeleton with SchXslt as built-in Schematron

Background: #1380 set up a separate schxslt branch that uses SchXslt as the Schematron implementation instead of the skeleton implementation. That work enabled us to test XSpec against SchXslt without changing the built-in implementation that ships with XSpec. That arrangement made sense while SchXslt was still maturing.
Now that SchXslt is mature, this PR drops support for the skeleton implementation and uses SchXslt as the built-in Schematron implementation on the master branch.
This PR mostly addresses #1828, except that deleting the schxslt branch will happen after this PR is merged onto the master branch.

Compatibility Note
Dropping support for the skeleton implementation is a breaking change. Schematron users should migrate to SchXslt; see https://github.com/Schematron/schematron#readme .

Happy 3rd anniversary since #1380 was merged. I'm going to merge this one now.

except that deleting the schxslt branch will happen after this PR is merged onto the master branch.

I deleted the schxslt branch protection rules and then the branch itself, which was item 2 that #1828 called for.


The todo get that overwrites the the content

todo.get()
Overwriting the code each time without checking if there were actually any changes.
You mentioned it would be a problem in the future.

Yep, good idea. We should fix this sooner rather than later, for sure


ASP.NET Core + Angular template doesn't support monorepo projects

Describe the bug
The ASP.NET Core (2.2) + Angular template doesn't work in a monorepo setup.
The template puts everything in the root:
/
  bin/
  obj/
  ClientApp/
  Server.csproj
  Startup.cs
  etc.

A monorepo has more structure because there are multiple library and client (angular) projects:
/
  libs
    client --------------------------------------->  was originally in the root
    client2
    server
      bin/ -------------------------------------
      obj/                                     |
      Server.csproj                            |-->  was originally in the root
      Startup.cs                               |
      etc. -------------------------------------
    lib1
    lib2

To Reproduce

dotnet new angular
Move directories to suit the structure above
Edit paths in Startup.cs to match the new structure
Run server app

Expected behavior
I expect it to work, but I get InvalidOperationException: Failed to start 'npm'
Both the server and client work properly when run separately (dotnet run and npm run start), but not when run together.
Additional context
aspet core 2.2.4
sdk 2.2.105
ubuntu 18.10
vscode

I got it working like this:

changed to monorepo structure as shown in my question above

edited Server.csproj (paths are relative to server app's directory):

<!--<SpaRoot>ClientApp\</SpaRoot>-->
<SpaRoot>../client/</SpaRoot>

edited Startup.cs (paths are relative to workspace's directory):

services.AddSpaStaticFiles(configuration => {
  //configuration.RootPath = "ClientApp/dist";
  configuration.RootPath = "./libs/client/dist";
});

and
app.UseSpa(spa => {
  //spa.Options.SourcePath = "ClientApp";
  spa.Options.SourcePath = "./libs/client";
  // etc.
});

This is not explained anywhere, and would be a good idea to have as documentation or a sample repo - most devs who work on client and server (and supporting libs) separately, will be using a monorepo structure.

Thanks for contacting us, @lonix1.
Glad you've found solution to your problem. Happy to accept a PR for docs if you want.

I take back what I wrote - the fix wasn't reproducible. Right now no way to get this to work in monorepos. (Which it the default for large systems)
Please reopen.
If someone gets this working, please comment here.


Add basic test for coverage example and library

The coverage code is not currently exercised by any test.

Add a test to the coverage example so that it can run in PR builds.
Specify --all-targets so that example tests are run.
Install and use nextest instead of the standard test runner.

This will parallelize test runs across binaries so the overall test run is faster.

Make sleep duration of agent configurable and reduce it in the test run so that it doesn't wait for 30 seconds.

Codecov Report

Merging #3035 (a11f5e8) into main (bd2b109) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
- Coverage   29.43%   29.05%   -0.38%
==========================================
  Files         305      125     -180
  Lines       36544    13703   -22841
==========================================
- Hits        10755     3981    -6774
+ Misses      25789     9722   -16067

see 180 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


8.0.0

TBD, but this will be the last release with breaking changes for a long time, I hope.
AFIT will be added in 8.1.0 alongside the associated MSRV update. Any important bug fixes added after 8.1.0 will be backported to the 8.0.x branch for the next few Rust releases to hopefully make this upgrade less annoying easier.

Is there a release timeline for this?

Hey @TroyKomodo, I'm looking to release it this week or by the end of the weekend.

Sounds great! Thanks


It does not remember dark theme on Linux

Bug Report
App Version: [Enter app version here]
2.0.0.dev17
Platform: [Windows / macOS / Linux]
Debian
Installation Method: [App Store / Direct Download / Other]
.deb
Bug Description:
It does not remember the dark theme
Steps to Reproduce:
pref->dark theme->quit->open sleek->light theme
Expected Behavior:
it should always set to dark theme
Actual Behavior:
sets to light theme
System Information:

OS Version: Debian testing x64, Cinnamon desktop
Processor: Intel Core i5
RAM:  8GB
Graphics Card: Intel
Reproducibility:
[Always / Sometimes / Rarely / Unable to Reproduce]

@gerroon I can't reproduce this on Arch Linux and on Ubuntu using the AppImage. Unfortunately I can't test the .deb since my architecture (arm64) won't let me install nor build it.
Can you start the Debian build using your terminal and if so do you see any errors popping up?
Also if you switch to dark or light theme, does this change the colorTheme value in your your config file?

And also: if you're using the .deb release, does sleek has an app icon in your app bar / dock?

the colortheme in the config below is set to dark it still opens the light theme.
config.ts: Tray created
main.ts: Main window has been created successfully
main.ts: Menu created
main.ts: Tray created
config.ts: Tray created
config.ts: Tray created
config.ts: Tray created
Styles injected found in CSS file: /home/USER/.config/sleek/userData2.0.0-dev17/customStyles.css
MESA-INTEL: warning: Haswell Vulkan support is incomplete
libva error: /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so init failed
ipcEvents.ts: Received config value for language

Perhaps somewhat related: the button View -> Toggle theme doesn't work at first (neither does the associated shortcut Alt+Ctrl+D).
However, if I go to settings and change the theme from there, both the button and shortcut start working to toggle the theme as expected (until sleek is closed).
(Version is: 2.0.0.dev17)

(until sleek is closed).  I have the same experience.

Perhaps somewhat related: the button View -> Toggle theme doesn't work at first (neither does the associated shortcut Alt+Ctrl+D).
However, if I go to settings and change the theme from there, both the button and shortcut start working to toggle the theme as expected (until sleek is closed).
(Version is: 2.0.0.dev17)

Are you on Linux (Cinnamon?) as well?

@gerroon @Bleskocvok also, can you provide me with some feedback, if you're also affected by this on Cinnamon? https://github.com/ransome1/sleek/issues/550

Are you on Linux (Cinnamon?) as well?

I am on Xubuntu (using XFCE as my desktop environment).
Ad https://github.com/ransome1/sleek/issues/550: I used to be affected, but yesterday's 2.0.0-dev19 fixed the icon for me.
The issue with dark theme not being remembered and the Toggle theme button issue still persist in 2.0.0-dev19.
Both using .AppImage and .deb installation methods yield the same behaviour for me.
(I also tried sleek 2.0.0-dev19 on Windows 10 and the dark theme works perfectly fine there, if that's helpful.)
If I run sleek from the command line, it outputs similar errors to what @gerroon sent above:
$ sleek
config.ts: sleek userdata is located at: /home/USER/.config/sleek/userData2.0.0-dev19
config.ts: Tray not shown
main.ts: Main window has been created successfully
main.ts: Menu created
main.ts: Tray not shown
config.ts: Tray not shown
config.ts: Tray not shown
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
[8678:1028/170936.513739:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
config.ts: Tray not shown
Styles injected found in CSS file: /home/USER/.config/sleek/userData2.0.0-dev19/customStyles.css
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
[8723:1028/170936.647900:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
libva error: vaGetDriverNameByIndex() failed with unknown libva error, driver_name = (null)
[8697:1028/170936.710193:ERROR:command_buffer_proxy_impl.cc(128)] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.
ipcEvents.ts: Set sorting to [object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]
ipcEvents.ts: Set isDrawerOpen to false
ipcEvents.ts: Set isSearchOpen to false
ipcEvents.ts: Set zoom to 100

I think I have just been able to reproduce this. Thanks for reporting it.
A fix will be part of the next release.


Snapshots desappear after rebot instance from CS. XCP-NG hypervisor

ISSUE TYPE

Bug Report

COMPONENT NAME

VM Snapshots

CLOUDSTACK VERSION

4.16.x.x 4.17.x.x

CONFIGURATION

XCP-NG 8.2.0, 8.2.1, LVM over iSCSI storage
OS / ENVIRONMENT

OracleLinux 8
SUMMARY
When I create VM snapshot and force reboot or stop and start  instance via CS, snapshot dissapears from XCP-NG.
STEPS TO REPRODUCE
1. Push the button "Take VM snapshot"
2. Stop and start or force reboot selected instance
3. Try "Revert to VM snapshot"
4. Get the error.

ACTUAL RESULTS

Snapshot dissapears from XCP-NG

and after reboot

Did you tried to stop the VM and reverting it to the vm-snapshot? Do you still see the VM-Snapshot in Cloudstack? It is possible that Cloudstack takes care of the VM-Snapshot chain but it will be not visible anymore in XCP-ng.

@sbrueseke I've tested reverting another VM from power off VM state on a clean installation and all is ok . CS manages VM snapshots correctly without visability on XCP-NG.
I dont know why, but several VMs with 2 TB disk had problems on production installtion. I think it is my local problem.
Thank you and sorry. I am gonna close this issue


ww49.4 MediaSDK debug release

WW49.4 mediasdk omx release
Add mediasdk omx license

Tracked-On: OAM-72790
Signed-off-by: tianmi.chen<EMAIL_ADDRESS>

is the license already added here?
https://github.com/projectceladon/mediasdk_release/blob/master/PV Intel OBL Software License Agreement 11.2.2017.pdf

yes, the license is included in this PR.

little confused,  the master still not get WW49.4, why you want to send this to stable?
could we check in it to master firstly, then stable?


EC2: Add Amazon Linux 2022 AMI

This MR adds the new Amazon Linux 2022 AMIs that will replace current Amazon Linux 2 images in the future.
https://github.com/amazonlinux/amazon-linux-2022

Codecov Report

Merging #5388 (c91b0e6) into master (6d96370) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5388      +/-   ##
==========================================
+ Coverage   96.00%   96.05%   +0.04%
==========================================
  Files         708      708
  Lines       70806    71000     +194
==========================================
+ Hits        67980    68198     +218
+ Misses       2826     2802      -24

Flag
Coverage Δ

servertests
35.83% <100.00%> (-0.05%)
:arrow_down:

unittests
95.99% <100.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/__init__.py
97.26% <100.00%> (ø)

moto/instance_metadata/responses.py
96.15% <0.00%> (-3.85%)
:arrow_down:

moto/core/utils.py
93.72% <0.00%> (-1.35%)
:arrow_down:

moto/elasticbeanstalk/models.py
91.56% <0.00%> (-0.30%)
:arrow_down:

moto/efs/models.py
91.09% <0.00%> (-0.28%)
:arrow_down:

moto/ec2/utils.py
93.63% <0.00%> (-0.27%)
:arrow_down:

moto/glacier/models.py
82.70% <0.00%> (-0.26%)
:arrow_down:

moto/s3control/config.py
93.22% <0.00%> (-0.23%)
:arrow_down:

moto/ec2/models/carrier_gateways.py
90.47% <0.00%> (-0.23%)
:arrow_down:

moto/ec2/models/network_acls.py
87.30% <0.00%> (-0.20%)
:arrow_down:

... and 214 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Feature Request] Reacting to individual parts of a message with multiple parts

https://github.com/BlueBubblesApp/bluebubbles-app/issues/542
https://github.com/BlueBubblesApp/BlueBubbles-Desktop-App/issues/196
https://github.com/iandwelker/smserver/issues/81
https://github.com/sgtaziz/WebMessage/issues/51
https://github.com/open-imcore/imcore.react/issues/8
https://github.com/airmessage/airmessage-android/issues/3

Completed


Separate the 'if' expression from its statement

Conform to https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#separate-the-if-expression-from-its-statement

Nice. Thanks!


ci(node): just rate limit

run: https://github.com/GlareDB/glaredb/actions/runs/7560954189
Error:
Status: Downloaded newer image for ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
+ curl --proto =https --tlsv1.2 -sSf https://just.systems/install.sh
+ bash -s -- --to .
curl: (22) The requested URL returned error: 403

Cause:
https://github.com/GlareDB/glaredb/blob/690b74f287e45108d9ca28c91608359f07441d25/.github/workflows/nodejs-release.yml#L54-L55
Referring to https://just.systems/man/en/chapter_5.html it seems like we need to add --tag:

Note that install.sh may fail on GitHub actions, or in other environments where many machines share IP addresses. install.sh calls GitHub APIs in order to determine the latest version of just to install, and those API calls are rate-limited on a per-IP basis. To make install.sh more reliable in such circumstances, pass a specific tag to install with --tag.

Fixed in https://github.com/GlareDB/glaredb/pull/2442

Still seeing this

@greyscaled link to a recent failure?

@greyscaled link to a recent failure?

https://github.com/GlareDB/glaredb/actions/runs/7610842049/job/20725034938


Ch1 comibine_country_stats

The line gdp_per_capita.set_index("Country", inplace=True) should be remeved. The index is already set to country in  pd.read_csv().

Thanks for your feedback. However the code fails when I remove this line, and the country is not set as the index in pd.read_csv(). Perhaps it was an old version of the code?


Fix pagination for getOUs

Issue #, if available:
#58
Description of changes:
Add pagination to retrieving OUs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please approve this PR.

@tomerr-ma  done