mlp_vision node dies consistently after a few seconds (Docker)

Error overview
Within any ROS Docker container (including the Astrobee container), run roswtf or rosnode ping -a. Example:
docker exec -it astrobee /ros_entrypoint.sh roswtf

ERROR Could not contact the following nodes:
 * /mlp_vision

ERROR The following nodes should be connected but aren't:
 * /mlp_vision->/mlp_monitors (/heartbeat)
 * /mlp_vision->/rosbridge_websocket (/rosout)
 * /gazebo->/mlp_vision (/clock)

How to reproduce
I've made it as easy as possible to get everything up and running (Astrobee/ISAAC sim + IUI). Check out this script. I also recorded an asciinema of myself running that script which can be found here, and the error shows up at around 1:15. Btw I get IMU bias calibration errors at 0:50 which I think is because I didn't init the imu_biases.config file? Possibly unrelated to mlp_vision dying though.

@marinagmoreira I think we can close this because it stopped happening after the Docker images were changed.


merge Dataset search fails for some checklists

Description
The dataset Lista taxonómica de las especies de equinodermos de México contributes  163 names to the xrelease, but is not possible to reach these names vía the dateset search, only by directly editing the url.
This issues comes and goes, in every release there are  different datasets that present this problem

What browsers are you seeing the problem on?
No response
ChecklistBank URL
No response

Looks like there is an issue with non ascii characters in the search:
https://api.checklistbank.org/dataset/3/source/suggest?merge=true&q=Lista taxonomica de las especies de equinodermos de
https://api.checklistbank.org/dataset/3/source/suggest?merge=true&q=Lista taxonómica de las especies de equinodermos de


Add support for configuring nodes with multiple listener types

Currently all nodes except the router are limited to using the cluster for communication. All services must be able to listen on any supported transport by configuration.
Blocked by 'move listeners to core'.

A single handler may be reused by multiple listeners, or multiple listeners may each own an instance. To deploy with multiple listeners use a CoreService. Context.deploy(handler) deploys a handler with a default listener that listens on the eventbus on the handlers address. context.deploy(listener) deploys the listener with a handler that pushes messages onto the eventbus. The default address is the classname. Fixed.


Replace "backward" stack trace with absl::Stacktrace.

Description:
Use the absl::Stacktrace library along with absl::Symbolize to generate
symbolized stack traces without requiring any external tool or post
processing.
Remove the external dependency on "backward" library.
This deprecates stack_decode.py, which is removed. References to the
stack_decode.py process are removed from README.
Risk Level: Low (may break tooling that interpreted stack traces in logs)
Testing: bazel test //test/... , manually examined symbolized backtrace in killed binary.
Docs Changes: Changed bazel/README.md
Release Notes: The stack_decode.py script is removed, stack traces should include decoded names without it when the binary has appropriate debugging symbols.
Signed-off-by: Dan Noé<EMAIL_ADDRESS>

@dnoe before your changes, If I want to test a new arch, I just added
#elif defined(__s390x__)
    error_pc =  reinterpret_cast<void*>(ucontext->uc_mcontext.psw.addr);

insignal_action.cc
Could you point me where I should add in the new code? I have successfully compiled the envoy in s390x, but failed to run with this error.
[2019-05-23 02:28:13.551][9111][critical][assert] [external/envoy/source/exe/signal_action.cc:72] assert failure: mprotect(altstack_, guard_size_, PROT_NONE) == 0.

Thanks.


usb: Add reset, power features

This adds PORT_RESET and PORT_POWER USB hub features. Within the shell, it allows the foobaz device to be behind a hub.

Thanks, few comments. We will need some kind of synchronization if you would like to submit more patches. We have some host code that is not yet public.

I will try to take care of these changes early next week.
I have another commit that adds request codes for PSTN subclasses, and some corresponding functionality. On the other side of the hub, I have a device that implements the CDC ACM from the nRF5 SDK.

@mateusz- Sorry, I will come back to you as https://github.com/zephyrproject-rtos/zephyr/pull/38679 is merged, what should happen soon.


iOS IT for Windows

iOS integration tests for windows are most likely a feasible goal for flank and should be implemented.
The tickets included within this epic break down the steps needed to achieve the goal.

Please consider the following ticket as a lookup: https://github.com/Flank/flank/issues/1180


Implement Gemini Vision

Feature request
We would like to implement Gemini 1.5 and/or Gemini Vision in openadapt.adapters.gemini.
Related: https://github.com/OpenAdaptAI/OpenAdapt/issues/565
Gemini 1.5: https://blog.google/technology/ai/google-gemini-next-generation-model-february-2024/#sundar-note
Gemini Vision:
Motivation
https://blog.google/technology/ai/google-gemini-next-generation-model-february-2024/#sundar-note

1 million tokens

https://www.linkedin.com/feed/update/urn:li:activity:7140972956314247168/

Gemini Pro Vision (multimodal) works good and is available to everyone! I did a quick test and the results I got were similar to GPT4-Vision.
Descriptions are accurate. Colors, and directions of objects are correct! Something Llava did not get right, unfortunately ...
⚡The good thing is you can use Gemini Pro already today, at 1 𝐫𝐞𝐪𝐮𝐞𝐬𝐭 𝐩𝐞𝐫 𝐬𝐞𝐜𝐨𝐧𝐝 compared to 100 requests per day for GPT-4 vision.
Google has enough GPUs to serve the world apparently 😏

Implemented in https://github.com/OpenAdaptAI/OpenAdapt/pull/610


Refactoring and Find Usages do not work with @Accessors(fluent = true)

Short description
I have a class like this:
@Value
    @ToString
    @Accessors(fluent = true)
    @Builder
    class DataItem {
        @NonNull String name;
        @NonNull Instant createTimestamp;
        @NonNull String content;
    }

and then Find Usages for fields doesn't give anything.
Expected behavior
Find Usages will show reads (e.g. dataItem.name()) and writes (e.g. DataItem.builder().name()).
Version information

IDEA Version: 2017.3.5
JDK Version: JDK 1.8.0_171
OS Type & Version: MacOS 10.12.6
Lombok Plugin Version: 0.16-2017.3.3
Lombok Dependency Version: 1.16.12

Steps to reproduce

Create a Java class as in the example above
Construct an instance and call its getters
Try to find usages of a field (e.g. name)

E.g.
DataItem item = DataItem.builder()
                        .name("a")
                        .createTimestamp(Instant.now())
                        .content("content")
                        .build();
System.out.println("Item.name = " + item.name());

Stacktrace
No error happens. Just silently shows nothing.

Updated IntelliJ to 2018.1 and the Lombok plugin to 0.17-2018.1 still no success.
It highlights fields as if they are used somewhere, but it doesn't show where.

Closed as duplicate of #186


Analyse findings on form design content

What
Analyse the data collected about the 'Questions page' and the 'Recover from validation errors' page and assess whether there are different ways to structure the information. Draw up a plan to create one or more examples.
Why
To plan next stage of potential content restructuring for these pages
Who needs to work on this
Claire

Analysis doc


merge function and test case

added function to merge two binary discodb blobs.
added a test case in util

thanks @bauman - i will test and merge. Sorry about the delay!

any word on this?  I included a test file.


Add Czech (cs) Language Support

Changes:

Added cs directory under locales, with common.json and config.json translated to Czech.
Created README.cs.md for Czech language documentation.
Updated i18n.tsx to add cs in availableLanguages and Czech-specific date and time formatters.
Modified i18n.js to add cs in the list of supported languages, sorted alphabetically by language code.

Testing:

Verified Czech translations by running the application locally with yarn dev and inspecting the UI for correct display across different elements.

Additional Notes:

Maintained Czech pluralization rules and ensured alphabetical consistency in language entries across files.

Díky!


Handle timezones

The purpose of this PR is to close https://github.com/aqualinkorg/aqualink-app/issues/384 and https://github.com/aqualinkorg/aqualink-app/issues/445.

So the thing that caused the deprecation warning was that we were using moment(convertToLocalTime(...)).format(...), but moment accepts only ISO formatted strings and convertToLocalTime(...) didn't return such a string. I removed all convertTo... utils and changed displayTimeInLocalTimezone so that it accepts a desired format which is then passed to moment. Now all the dates are in ISO format, but when they are being displayed, they are displayed in the reef's local time thanks to displayTimeInLocalTimezone. @ericboucher @Ry-DS Let me know what you think :slightly_smiling_face:

Made some final changes so that the picker's date corresponds to site's local time.


Remove message acknowledgement to fix issues

Messages were queuing behind an unacknowledged message. This attempts to remove the use of acknowledgement.

Fixed in #5, thank you!


Update markdown code extractor to use parser

Why are these changes needed?
This uses a full blown markdown parser rather than regex. This means that nested codeblocks no longer break the extractor.

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: Patch coverage is 29.41176% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 25.52%. Comparing base (0a49f2a) to head (7e19889).

Files
Patch %
Lines

autogen/coding/markdown_code_extractor.py
29.41%
12 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1837       +/-   ##
===========================================
- Coverage   35.69%   25.52%   -10.18%
===========================================
  Files          63       63
  Lines        6625     6630        +5
  Branches     1454     1579      +125
===========================================
- Hits         2365     1692      -673
- Misses       4067     4725      +658
- Partials      193      213       +20

Flag
Coverage Δ

unittests
25.47% <29.41%> (-10.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


derive: no panics, less work, more compatibility

Some minor stuff I found while implementing #127; extracted from there.

allow any amount of invisible delimiters: more compatibility with generated TokenStreams
don't panic if source+path are missing: print an error message instead
don't write empty string: because even printing nothing causes work

Thanks!


Updates to example script

Added a required "=" for the CREATE EXTERNAL DATA SOURCE command.
Removed an unnecessary comma breaking the CETAS command at the end of the example for "[dbo].[PopulationCETAS]".

@sqlarcher : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Add performance optimisations with inlining and less state

Inlined a couple of classes and operators. I also pumped up the versions of a few libraries since they usually come with optimisations of their own. Also, I inlined all of the delegate property operators because of this (scroll to Optimized delegated properties) lesser known optimization that removes the KProperty objects altogether from ever being created. Also whoops I think I ran the code reformatter automatically so sorry for that.

I am also not too sure what exactly is the very optimization that gives performance boost, could you give me a hint? I expected to see all operator functions etc inline

I am also not too sure what exactly is the very optimization that gives performance boost, could you give me a hint? I expected to see all operator functions etc inline

I think that the IR backend might be causing problems yeah. I turned it on temporarily because there was a weird bug with the normal compiler where when you have inline operators for properties (for the KProperty optimisation) it crashes when compiling but yeah I'll try to turn it off now. The main performance optimisation is removing the memberStructs list and also removing the backing fields of a couple of properties. There's now also a registerInlineProperty function because the regular register function accepted the interface which meant that every property was being boxed automatically and so the inline modifier on the classes had nearly no effect, but now the properties are never used as their interface types which means that the compiler can always use them as just their long offset value. I also removed a couple of lazy evaluations that didn't need to be there (they were used for calculating like a single int) because the actual lazy delegate itself uses more memory than just eagerly calculating the int value.
I didn't think about running the benchmarks but yeah I'll turn off the IR backend now and fix a couple of things until everything runs successfully. Obviously you can't merge this pr like that lol.
I did also make the LongToDoubleDelegate and the SlidingWindow classes inline which should be helpful for performance.

I think that the IR backend might be causing problems yeah. I turned it on temporarily because there was a weird bug with the normal compiler where when you have inline operators for properties (for the KProperty optimisation) it crashes when compiling but yeah I'll try to turn it off now. The main performance optimisation is removing the memberStructs list and also removing the backing fields of a couple of properties. There's now also a registerInlineProperty function because the regular register function accepted the interface which meant that every property was being boxed automatically and so the inline modifier on the classes had nearly no effect, but now the properties are never used as their interface types which means that the compiler can always use them as just their long offset value. I also removed a couple of lazy evaluations that didn't need to be there (they were used for calculating like a single int) because the actual lazy delegate itself uses more memory than just eagerly calculating the int value.
I didn't think about running the benchmarks but yeah I'll turn off the IR backend now and fix a couple of things until everything runs successfully. Obviously you can't merge this pr like that lol.
I did also make the LongToDoubleDelegate and the SlidingWindow classes inline which should be helpful for performance.


PLAT-52103: Add a11y props in Picker, RangePicker, DatePicker, TimePicker, EditableIntegerPicker

Issue Resolved / Feature Added
There's no way to override a11y string on Picker, RangePicker, DatePicker, TimePicker, EditableIntegerPicker
Resolution
Added a11y props in Picker, DatePicker, TimePicker

Picker

decrementAriaLabel
incrementAriaLabel
joinedPickerAriaLabel

DataComponentPicker

hintAriaLabel

DateComponentRangePicker

hintAriaLabel

DatePicker

dayAriaLabel
joinedPickerAriaLabel
monthAriaLabel
yearAriaLabel

TimePicker

hourAriaLabel
joinedPickerAriaLabel
minuteAriaLabel

RangePicker, EditableIntegerPicker does not add props because it will pass all prop with the picker.
Additional Considerations
Links
PLAT-52103
Comments
Enact-DCO-1.0-Signed-off-by: Baekwoo Jung<EMAIL_ADDRESS>

Could you add unit tests for setting this props like other PRs?

Could you add unit tests for setting this props like other PRs?

Unit test will be implemented on the PLAT-54096 ticket.

LGTM

@ryanjduffy

On DatePicker and TimePicker, let's use xxxAccessibilityHint and xxxAriaLabel for each date component picker to maintain consistency with the accessibilityHint on Picker.

I changed the prop name of all buttons to xxxAccessibilityHint.
Because it is a prop that changes the String after {Value}.
If we use the name aria-label or xxxAriaLabel, Perhaps the App developers are misunderstood as changing from reading all string "{Value} {Hint}" when focused.
Let me know if you have any other comments.

If you think this change is correct, we should also change the prop name of the IncrementSlider.
(AS-IS: IncrementAriaLabel, TO-BE: IncrementAccessibilityHint)

Made a few prop naming changes which I'm going to go ahead and merge but we can revisit later if need be. In short, instead of using xxxAccessibilityHint which mirrored the label below the picker, I changed them to xxxLabel and used the same value for both the visual label and the aural label.
Also added some aria debugging CSS complements of @Djspaceg. Now, you can add .debug.aria to a node and its descendants will display a tooltip with the current aria-label and/or aria-valuetext. :tada:


Saleor 2966 add html report

I want to merge this change because I want to have html report for cypress tests

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

Task linked: SALEOR-2966 Add html report to cypress tests


fix: Add HuggingFaceInference includeCredentials param

IncludeCredentials parameter added to HuggingFaceInference to address the issue "The 'credentials' field on 'RequestInitializerDict' is not implemented." when using HuggingFace's HfInference on Cloudflare Workers.

Thank you for this!


Plotting smooth gene expression trends along lineages

Hello,
Thank you for the wonderful pipeline.
I am facing an issue while running the section of 'basics', plot smooth gene expression trends along lineages.
As before that we need to run scv.tl.diffmap(adata)
When i run it, it shows an error :
TypeError: '>=' not supported between instances of 'tuple' and 'int'
Please help as what could be the possible reason for that. I have already run dynamical mode of scVelo.
Thank you for the help in advance.

Hi @sidrahmaryam ,
it's more of a scanpy issue, since scvelo just imports diffmap from there: https://github.com/theislab/scvelo/blob/master/scvelo/tools/init.py#L12
I remember encountering this error myself using scanpy==1.5.* and updating to scanpy==1.6.0 seems to have fixed it.
Let me know if this helps - if not, please try opening an here: https://github.com/theislab/scanpy/issues

Thank you so much for the suggestion.
Yes it did solve. 💯

Glad that it worked.


resource_control: reset resource group virtual time when it is about to overflow

What is changed and how it works?

Issue Number: ref #14353, ref https://github.com/pingcap/tidb/issues/42595
What's Changed:

After pingcap/tidb#42596, the default group's ru quota is very big(i32::MAX), so it is possible that resource group's virtual time can overflow after running for a long time. This PR resolve this issue by resetting the virtual time base to a small value when it about to overflow.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

Side effects
Release note
None

/test

/merge

/merge

/merge


⚠ Bofrost.lu has degraded performance

In 4a1d56d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1161 ms

Resolved: Bofrost.lu performance has improved in 2636a00 after 24 minutes.


Android device connect to OpenVPN, can resolve dns and route, but Internet not working

Hello there and first thanks for this product !
I'm having a strange behavior.
I have a small computer with LUBUNTU.
On this small computer I've installed PIHOLE and PIVPN.
PiHole is working great.
PiVPN is also working. I can connect from outside with an Android device and a Windows OS.
But on both devices I have the same issue :
I can resolve DNS (for example www.google.fr), I can ping, I can trace route ... BUT I just can't go on Internet (email or web browser for example). I just can't understand what's happening here.
Any idea ? The UFW is disabled.
***** Server conf *****
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/ASROCK_96a0d03d-ab8e-4a94-9fea-6b8b17df363b.crt
key /etc/openvpn/easy-rsa/pki/private/ASROCK_96a0d03d-ab8e-4a94-9fea-6b8b17df363b.key
dh none
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
push "dhcp-option DNS <IP_ADDRESS>"
push "block-outside-dns"
push "redirect-gateway def1"
client-to-client
keepalive 1800 3600
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user nobody
group nogroup
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 3
******* user conf *******
client
dev tun
proto udp
remote **** 1194
resolv-retry infinite
nobind
persist-key
persist-tun
remote-cert-tls server
tls-version-min 1.2
verify-x509-name ASROCK_96a0d03d-ab8e-4a94-9fea-6b8b17df363b name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3

Please properly fill the Issue template .. that's why it is there, not to be ignored, without those details no one cant help you to properly troubleshoot the issue.
that sounds pretty much like browser issue .. what browser are you using?  Have you tried with different browsers?

Try to change the MTU https://github.com/pivpn/pivpn/issues/54

Hello
I've reinstalled everything and now it's working.
I've must had make a mistake the first time.
Thanks for your time !


Add parse_args

This combines the argument parsing logic from the request handler into a new function, in order to reduce the redundancy of the argument parsing logic.
It is declared as pub so that it can be used by crates implementing custom request handlers.

Superseded by #73.


how do I write the number of the question into the .xlsx file?

thank you very much  for this useful tool.
I am conducting a PPGIS survey where subjects are asked to take pictures. However, taking the pictures is not mandatory. How can I change loop  that the number of the question is also in the table, so that I can assign the pictures to the questions?
Thank you very much!

Hello @f2502 I am guessing you are referring to the Export survey data with attachments tool, can you provide more details on what you mean by the "number of the question"? Are you referring to the name of the image question that generated the photo?
In the last line of code in the last code block where the csvwriter is writing a row, that's where it's writing the information about the attachment to the CSV. You can modify this to include additional information to be written into the CSV. You can extract the attribute information of the parent record by modifying the feature_object_ids variable to set return_ids_only to False. With this, though you will need to modify any reference to feature_object_ids to then be feature_object_ids.attributes['objectid'].


is bloom filter not have a responsive usage?

Is your feature request related to a problem? Please describe.
i wanna use Bloom Filter in webflux
Describe the solution you'd like
Describe alternatives you've considered

Same Questions , I used to springcloud gateway

Done


Fix Linking docs

Linking.addEventListener(url, callback) tempts the reader to pass in a URL, when it should be the hardcoded string "url" instead
Linking.getInitialURL doesn't take an argument

Done! It only affected v62 and v63.


[DOCFIX] Fix "building from source" doc

see title

@Xenorith I think this is ready for merge and cherry-pick

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.7 please


[cert] fix 5.3.3 random fail by small chance

5.3.3 pktverify fail by small chance when the ping reply is forwarded from Router3 -> Leader -> Router2 instead of  Router3 -> Router2. In such case, the direct wpan.dst16 is not Router2's RLOC16, but Leader's RLOC16.
This commit change 5.3.3 to check for both 6lowpan mesh dst16 and wpan.dst16 against Router2's RLOC16.

There is no link quality configuration in this test, generally in a stable topology, it should always choose the lowest cost route, that is, generally the response route should be ROUTER_3->ROUTER_2.
My guess is 10s time might not be enough for the routers to sync link/routes completely, specifically the link between ROUTER_3 and ROUTER_2 is not established.
https://github.com/openthread/openthread/blob/b4120128433571741fcd5da73255e2a138f7b8cb/tests/scripts/thread-cert/Cert_5_3_03_AddressQuery.py#L110-L114
One alternative option might be to extend the wait time to fix the random failing.

My guess is 10s time might not be enough for the routers to sync link/routes completely, specifically the link between ROUTER_3 and ROUTER_2 is not established.

Agree.

One alternative option might be to extend the wait time to fix the random failing.

Yes. My consideration is that the behavior (i.e. ping Router3 -> Leader -> Router2) itself is in line with the Test Spec, thus should be allowed technically.

Yes. My consideration is that the behavior (i.e. ping Router3 -> Leader -> Router2) itself is in line with the Test Spec, thus should be allowed technically.

I would agree it doesn't violate the test plan which only validate the DUT's forwarding functionality.
Either option looks fine to me.


proposal: Support defining probes through CRD in k8s environment

In the k8s environment, all detection targets are dynamic, so cloudprober has designed the k8s endpoint to support dynamic service discovery. However, this mode still needs improvement in terms of configuration file management and detection source definition.Below is a brief description of these two requirements
1. Definition of cloudprober source location:
cloudprober recommends managing all probes through deployment and configuration files. Each cloudprober instance reads the same configuration file. In this deployment mode, if I want to initiate probes on different nodes and availability zones, I must control the node where the cloudprober instance is located through affinity scheduling during deployment. And when I have many detection tasks, which node cloudprober should be deployed on becomes an extremely complex management task.
2. Define detection tasks through CRD
So can we define the detection task through the CRD of k8s, such as' CloudProberTask '. When we receive a user-defined 'CloudProberTask' object, we can decide to create a cloud probe workload that meets the user's scheduling needs based on the cloud probe source location defined by the object. When the user deletes the 'CloudProberTask', we can remove the workload. All cloudprober instances in this workload use the configuration in CRD to create probes and alarms.
Another benefit of doing this is that in large k8s clusters, each namespace may represent an organization, allowing each organization to easily meet their network monitoring needs through 'CloudProberTask'.

I think this kind of feature would require doing something along the lines of what Prometheus does with prometheus-operator - an operator app would be able to:

Define a cloudprober deployment, including a config reloader (assuming rds is not used)
Define a cloudprober rds deployment (if rds is desired to be used)
Define the spec for how to convert a CRD schema to a Cloudprober probe schema.

This is a pretty large undertaking.


Update Mangabat.kt

Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[ ] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[ ] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

in Mangabat go to the file called "Build.gradle", update the baseUrl and OverrideVersionCode: as it is in 4 it goes to 5
don't add the "/" at the end, leave it as the example below:
https://h.mangabat.com

Add the: "Closes: #1985"
on top of the checklist


Make UndoRedo use Callables

This PR makes UndoRedo use Callables instead of method names and hardcoded argument list. I added add_undo_method_compat and changed all old calls to this. We need to port them later and cleanup needlessly bound methods.
Likely fixes #26483
And likely fixes #36895
Sumbitting as draft, because I'm not yet sure what to do with
https://github.com/godotengine/godot/blob/7e009a167110e79caa102c5b88363fd32b75293c/core/object/undo_redo.cpp#L301-L303
Either I need to figure out how to change it to Callable or extract arguments from callable and push them here. For now this part is commented out, everything else seems to work.
Bugsquad edit: This closes https://github.com/godotengine/godot-proposals/issues/5038.

Why does CI fail all jobs except Windows builds and static checks?

Why does CI fail all jobs except Windows builds and static checks?

Click "Details" next to the failed job to check build logs.
core/object/undo_redo.cpp:308:24: error: non-const lvalue reference to type 'Variant' cannot bind to a temporary of type 'Variant'
                                c.call(nullptr, 0, Variant(), ce);
                                                   ^~~~~~~~~
./core/variant/callable.h:70:66: note: passing argument to parameter 'r_return_value' here
        void call(const Variant **p_arguments, int p_argcount, Variant &r_return_value, CallError &r_call_error) const;
                                                                        ^
1 error generated.

Ok, finished this. I had to add CallableCustomBind.get_binds() and with some dynamic casting I managed to resolve the callback issue. It was something with live edit, seems to work now. At least when you change properties in the inspector, but when you move nodes it doesn't seem to synchronize properly, no idea why.

Ok, finished this. I had to add CallableCustomBind.get_binds() and with some dynamic casting I managed to resolve the callback issue. It was something with live edit, seems to work now. At least when you change properties in the inspector, but when you move nodes it doesn't seem to synchronize properly, no idea why.

For the record, I suggest closing this. Using callables in UndoRedo means that contributors will be able to provide function pointers instead of instance/string. This breaks live editing, hence it should not be used.

This breaks live editing, hence it should not be used.

Live editing uses method pointer, so I just extract it from the callable (including arguments, I added a method for that). So live editing still works (except one small issue, see my previous comment).

Closing, as there is too many conflicts. Could be revisited after #59564 is merged.
The status is this:
Godot has live scene edit, i.e. when you run the game from the editor, any change you do in the editor (not on remote tree) is synced via debugger to the running scene. This is done via UndoRedo actions - the method name is sent to the running instance and is executed remotely. Method pointer Callables don't provide method names, so they can't be called remotely.
HOWEVER, as I mentioned sometime before, most of the editor changes sent via live edit comes from property changes, which don't use methods. They just send property name and value. Also most editor changes done via methods aren't synced anyway (node renames, animation edits etc). So IMO we could change everything to Callables, but still keep the bindings for methods that need to be synchronized (live edit with named Callables should be possible, because you can get the method name). It's probably a few % of the methods, so it shouldn't be a problem. We'd change all methods to callable_mp and use Callable(object, "method") for methods that matter for live edit. Although reduz was opposed to doing it last time it was mentioned (you need to know whether the method is relevant for live edit or not and it will confuse users etc)
Another option is that we could keep all bindings and use named callables everywhere. This is rather meh IMO.
tl;dr this can be revived in the future, but should be done carefully to avoid breaking live edit™

Superseded by #66070.

Not really. The current equivalent of this PR would be making EditorUndoRedoManager use callables, but it has the problems I mentioned in the above comment.


JavaMOP Parser Misinterprets "to" as a Keyword Instead of an Identifier

Hi, I recently encountered an issue with JavaMOP where the parser seems to misinterpret "to" as a keyword instead of a variable name. The error occurred when I included the Arrays_SortBeforeBinarySearch.mop spec to make the agent . The error message I received is attached as error_trace.txt for your reference. error_trace.txt
Personally, I addressed this issue by changing all the "to"s into "dest"s as the variable names, but I think you may also check the parser logic to see this problem.
Thank you and Look forward to your reply.
Best

The interpretation is correct, as "to" is now a Java identifier.
I suspect that you are using an older set of specs than the ones in this repo's props directory. If so, it is up to you to update them.


Nginx multi servers

I need the collection functionality given from many nginxes at the same time.
I created it.
If you find him quite useful. Use it.

@hnlq715 Are you going to accept this pull request eventually?

@apsega you can use my repo. I was merge into master.

@apsega @StereoRu Thank you guys :-)
Sorry, I don't have enough time on this feature recently. But I was wondering if we should consider to support static config and service discovery like prometheus did with static_config file_sd_config and so on, what do you think?
I would like to merge this PR, but maybe we need to consider more situations.

Hi @hnlq715 and everyone!
Do you have any plans to implement this feature soon?
It would be really useful (especially via static config and service discovery).

It would be great to support static_config or file_sd_config, but I don't have enough time on this feature recently.
Anyway, PR would be welcom ;-)


Cannot disable auto update for vscode

VSCode Version: 0.9.2 (or any other version that is not the latest one)
OS Version: 10.10.5 Yosemite

Steps to Reproduce:

Install visual studio code.
Put:
"update.channel": "none"
in user settings.json
Restart visual studio code.
Wait for Info message: Visual Studio Code will be updated after it restarts.

I cannot opt-out from auto update. I am using this:
https://code.visualstudio.com/docs/supporting/faq
Furthermore my default settings are different from these:
https://code.visualstudio.com/docs/customization/userandworkspace#_settings-file-locations
I do not have:     "update.channel": "default", option on the left side.
I have Intellisense Omnisharp Unity issue, that is why I need to use the older version.
Any Ideas how can I disable auto update?
Thank you.

Can't reproduce. Updates stop coming when I set that setting and restart. Even the Check for Updates option is not there:

0.9.2 is way too old, and it could be that this was not even implemented by then, given the lack of that setting in the left side.
Try changing the value of quality to none in Visual\ Studio\ Code.app/Contents/Resources/app/product.json.

Thank you :-)
I changed it "update.channel": "none" here: "~/Library/"Application Support"/Code (Mac)." and now it works.
Got help here: https://github.com/OmniSharp/omnisharp-vscode/issues/269#issuecomment-220969116

I'm facing this issue with the latest Insiders builds. Even though, I have "update.channel": "none", in settings.json, it keeps updating itself and the Check for updates... menu item is still there. I'm on mobile data now and would be happy to disable these updates ASAP.

@thorn0 Are you on OS X?

Windows 7, x64.

Thanks for the ping, @thorn0

Verified via code review :+1:

did you guys fix it?


[BUG]: (v. 2.7 - 2.8) ITS Theme duplicate icons

Describe the bug
When the ITS theme and its snippets are installed, the icons on the records and the folder are duplicated. The problem is missing in version 2.6.1, but after this version there are problems in ITS theme.
Screenshots

I don't think that the issue is related to Iconize. ITS theme seems to add icons by default without any other customization. So please feel free to report the issue there.

But in version 2.6.1, everything was fine... :cry:

But in version 2.6.1, everything was fine... 😢

It's because of renaming classes within Iconize. I've created a pull request which should fix this issue.


error "Could not locate data" when adding a lot of files to dat.archive

This looks very similar to joehand/dat-next#122, but as suggested I'm cross-posting here, because I use dat-node directly.
In build-wikipedia-feed, I'm directly calling dat.archive.writeFile. It fails reproducibly after 128 pages with the following error:
Error: Could not locate data
    at /root/wiki-dumps/build-wikipedia-feed/node_modules/dat-storage/index.js:61:30
    at loop (/root/wiki-dumps/build-wikipedia-feed/node_modules/dat-storage/index.js:132:19)
    at /root/wiki-dumps/build-wikipedia-feed/node_modules/dat-storage/index.js:97:5
    at /root/wiki-dumps/build-wikipedia-feed/node_modules/hypercore/index.js:1107:5
    at onread (/root/wiki-dumps/build-wikipedia-feed/node_modules/random-access-file/index.js:130:14)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:665:17)

turns out I already reported this once at https://github.com/mafintosh/hyperdrive/issues/154#issuecomment-320746714 . also, the link to project-related #165 might be useful.

To give you more details, this is the full log with env 'DEBUG=*': errlog.txt


Allow per-project installations for Homestead 2

With the rewrite of Homestead v2, it is now considerably more difficult (if not impossible) to share development environment code on a project. One of the key benefits of Vagrant is committing the Vagrantfile to a repository and thereby having all developers working from the same environment. (Isn't that the whole point of Vagrant?) But with Homestead 2, all your config lives in your own personal ~/.homestead directory, and is non-shareable.
I was never really a fan of the instructions for Homestead 1 which advocated using a single, central clone of the homestead repository. (Am I really the only one who uses separate homestead boxes per project? Do other people prefer not to segregate environments? That's like developing on our own little shared hosting boxes, allowing different project code and installation requirements to co-mingle.) But at least with the original Homestead it was possible to put the homestead files inside your project's repo (I used subtree add, since I'd customize the provision scripts.) With Homestead 2 and after.sh, the ability to customize the environment is getting better (and somewhat more reproducible), but taking a huge step backwards in shareability.
While bundling homestead commands as a composer project is great, further centralizing config seems to be taking Homestead in a wrong direction...

+1 Agree with this. It's a nice idea, but it would be great to have the option to use Homestead as a standalone vagrant project as well.

I agree with this as well. It would be great to have a .homestead.yml file per project. It could work like Vagrant does. homestead init would create a homestead.yml in your project root folder (similar to  vagrant init ) instead of using a global file.
For now, I am using only the homestead box directly with vagrant.

+1

Project specific Homestead environments are absolutely critical for our workflow. We will quite simply not be able to utilise Homestead as it stands at present.

+1

So question
if you want homestead to work like vagrant why don't you just use vagrant?

The last commit on https://github.com/zoontek/purestead was today so it is being worked on and it uses the same Box that Homestead does so it is the exact same software stack

i think, the discussion "if you want homestead to work like vagrant, than use vagrant" leads to nowhere. An example?
Laravel (git)ignores the vendor dir per default but the default vm for laravel gives us no direct automatism to install the vendor dir?! Every team - my team, team of @joearcher, etc. - needs to implement provisioning additionally for getting even the minimum of loading the vendor dir.

@ThatTomPerson I find your "I work this way, and so should you, or go elsewhere" attitude to this issue unconstructive and opinionated. "Use another product" is not an appropriate response to this issue.
Because the product fits your needs does not make it appropriate for everyone, especially when the issue is with functionality which has been removed.

I've experimented lot's of frameworks since ruby on rails first came out, maybe 10 years ago from today, and what I like and amazed about laravel is there's a decent answer to virtually any common problem (which is the definition of a framework), without sacrificing flexibility and with great documentation.
Homestead is a good utility for building up the dev. environment but it sacrifices some flexibility this time and I believe this is a very common case.
Yes you can always set your own vagrant box or use an alternative but that's what we do with zend framework or symfony or any other popular framework, isn't it?

I agree it's a missing feature.
Vagrant supports multiple VMs per environment. Maybe this can somehow be used to allow for per-project VMs?

I'm not saying you cant use homestead
I'm working in a group of 3, so homestead wouldn't work for us because if one person makes a change  like installs Mongo how do you handle that??
homestead as it is, does not handle stuff like this,
so I made some changes to homestead and just copy them into the root of my project
you can see my changes at https://github.com/ThatTomPerson/homestead
this is more customisable and all configuration is now in the repo
if you want mongodb on your vm just write a create-mongo.sh in the scripts and change homestead.rb to run it
I have no idea who you would get homestead to do this

@ThatTomPerson You got the provisioning script in your project, which everyone uses? I don't understand, how you point invalidates provisioning per project for homestead?

I think the best you could get homestead to do is copy the files into you project for you
and maybe be a wrapper around vagrant to tell you when you may need to provision again
but that is a big change from how homestead works at the moment
and I would not be opposed to homestead being able to do that but it should be to do this as well as have it's original functionality
homestead init --local
to copy files to you current directory
then if homestead see that there is a Homestead.yaml or Vagrantfile it can go into local mode where is just runs vagrant in the current directory
but if it doesn't find one of those files it runs it in the global version
that would be cool
but now this is just how vagrant works but with some sugar

"just how vagrant works but with some sugar" sounds perfectly fine to me. Homestead was (prior to version 2) essentially a Laravel-ready Vagrant configuration with some helpful wrappers around configuration and cli commands. There's nothing wrong with that; it was very useful.
I've been happily using Purestead on recent projects anyway, so this isn't a massive issue for me (i.e. alternatives are available). I'm just not aware of a good argument for this change to a "global Homestead" in version 2.
It's a lot of extra steps now to get my team on the same environment, and I don't see what's been gained.

You can also still use Homestead 1.

@micflan I will have to find a source for this but the goal with Homestead was to have a way to quickly set up a new laravel site in vagrant and making a new box in vagrant is slow so put them all in the same box
I think homestead is good for personal projects and tests
eg trying out a new package or trying out a new concept
I think @taylorotwell mentioned this in the lavavel podcast ep 19 but I could be wrong
I will listen to it again and find out after work

If you want to have a look at how i think local installs of homestead could work have a look at
laravel/framework#173
just an idea
discuss

I have been using a customized version of homestead after version 2 because of this issue, today this issue came to my attemption and made me figure other people shares this same opinion, so i open sourced my customized version:
https://github.com/dbpolito/firestead
This is basically homestead, no customizations at all, only simplified and per project based.

I think this global homestead is a step backwards, it makes it really hard to commit the dev environment to source control and for other devs to simply vagrant up and get cracking. Plus the provisioning script is running for every homestead up? Each project has it's own provisioning requirements....

Have to agree here, it seems a bit backwards. If we could add something similar to what @ThatTomPerson said above (check project folder first, then user folder) then that would be awesome.

I tried to talk to Taylor about it and he said that he though Homestead was ok as it is
so if we want a feature like this we will have to fork
but there is already projects around that do this eg purestead and firestead
I also don't think another homestead fork is a good idea

Sucks to hear that :disappointed:

so, no original homestead in bigger teams with multiple homestead projects for me ... -1

I feel bad about this too, but there is no way to please everyone... I don't know if the majority liked this new way, but seems to, as it's simpler... That's why forks exists, someone doesn't like the direction of the main project and fork and customize.
We have two good alternatives, as @ThatTomPerson pointed, purestead and firestead, i haven't tested purestead but seems pretty good to me.

:+1: I agree with many of the opinions stated in this thread. I love Homestead. I think it has been a great project but with Homestead 2, the added /.homestead directory has caused more problems than solutions for me. I don't really like having Homestead in 2 different directories either. I have started opting for other solutions but would prefer to stick with Homestead if possible.

ping @GrahamCampbell this is already achieved so probably you can close this.

Thanks @ArjanSchouten.


Blast output

I just blasted the K-12 16S gene against itself.  I end up with 5 or 6 HSPs representing hits to  the 16S genes in this genome but there is no way to tell which contig they are on.  Probably not a problem for K-12, but its  a huge problem for other genomes.   Also, the alignment view is good, but the list output is also necessary for getting a fast idea of what was matched.  For instance I am attaching a list output from the seed.

Also to clarify, in this case, I had one result because I went against one genome, but I should have had a table row for each HSP.

contig accession and descriptions have been added in the resulttable. verified on beta.


Fix typo in SerializerableDocumentation

@bot-gradle merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


2.2.0 breaks something in cornerstone-tools

I'm not sure what it is exactly but<EMAIL_ADDRESS>breaks some<EMAIL_ADDRESS>functionalities.
When loading a dicom image using the cornerstoneWADOImageLoader or the cornerstoneWebImageLoader it won't enable panning or zooming.
I built a small codepen showing the problem here
The problem does not seem to happen when using<EMAIL_ADDRESS>or the exampleImageLoader which can be seen by uncommenting line 2 of the codepen.

Thank you @fcortes for reporting this. I've verified the issue exists in the new cornerstone core when the image.rowPixelSpacing and/or image.columnPixelSpacing is not provided.
This is causing the scale factor to be calculated as NaN and thus, the math to pan/zoom the image breaks.
There is an issue that was reported addressing the same thing here

@fcortes this is now fixed in 2.2.2
I checked your example by updating the cornerstone reference and it is working as expected.


chore(devenv): fix dev env for older browsers

Overview
Fixes #640. Sorry @alisonjoseph for this!
Removed
Inadvertent addition of object spread operator, etc. in <script> tag in .dust
Testing / Reviewing
Testing should make sure the dev env is not broken.

Thanks @alisonjoseph for reviewing! Merging. @alisonjoseph and everybody feel free to let me know if any of you find other issues here!


Roll Flutter Engine from b4d916a5914c to e06970334bc3 (1 revision)

https://github.com/flutter/engine/compare/b4d916a5914c...e06970334bc3
2022-05-28<EMAIL_ADDRESS>[Impeller] Compile simulator specific Metal shader variants. (flutter/engine#33670)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Fix dotnet test Command Not Recognizing NUnit3TestAdapter

Fix for Issue #109
This fix addresses the issue where the dotnet test command cannot recognize the NUnit3TestAdapter in existing ItemGroup elements.
Changes Made:
Moved the reference to NUnit3TestAdapter to an ItemGroup without a TargetFramework condition.

@mobilebilly Thank you very much for your contribution.
I retargeted you pull request to Feature/111... because this is our current development branch for 3.0.0.
Can you please fix the conflicts and test the changes?

@FreeAndNil , no problem.
The conflicts have been fixed, and my branch is now up-to-date with the latest changes from the upstream branch Feature/111....
Please review the updated pull request and let me know if there are any further changes needed.

@FreeAndNil, the additional change in the test project is done. thank you


Sheets are transparent and many icons have lost support

Updated from 1.6.2 to 1.6.3 today and all character sheets went transparent instead of the normal tan background. Many profile pictures have lost support, as have feature and spell icons, reverting back to the default icons or error image icons.
Edit: To clarify, this was tested on multiple worlds with and without modules.
Using Foundry v9 - build 269
Edit again:

Error message shown due to the tokens folder no longer being present.

Your system install is corrupted or incomplete. Delete the /dnd5e folder entirely, from /systems in your userdata, then install the system again in Foundry Setup.

Did that just now and it resolved it. Thanks.


Update HomeWhySection.md

Update stale documentation to point to correct link.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @JennHaggerty!

Oh, whoops, didn't notice that this was pointing at gh-pages instead of master.
We actually don't serve react-server.io on github pages, since the site itself is run on React Server. :)


Show the highest rank an item achieved

Something users tend to do is post screenshots when their item is on the frontpage (also seen this for HN and reddit). It'd be nice for the post to simply indicate the highest rank the posts have received instead - this is complicated by boost in our case but still an interesting habit we can maybe make easier.

I think most posts will have had a pretty high rank since it's pretty to easy to become the top post for a few minutes.
Maybe the duration can be added?

Good point


Add last couple of release notes to docs

Update the docs with the release notes.

Docs Build status updates of commit 312a4fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/changelog/odatalib-7x.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Altered ui-router definitions

Allow trailing slash in urls
Use integer ids for detail views as default

Ok.


refactor: add billing and shipping details to payment method data

Feature Description
linking #347 for reference. Since the billing and shipping address used for payment should be stored in basillisk as per the discussion we had. This is to avoid

Any PII information to be stored in db which will be used for payments.
Avoid changes to payments if the address table undergoes any major changes ( like encryption ).

Possible Implementation

[ ] Have a struct under payment_method_data.pay_later that will have all billing and shipping related data required for payments. All paylater payments will have the mandatory details of address taken from here.
[ ] Save pay_later data in basillisk.
[ ] Add  payment_method_issuer and payment_experience in payment_attempt. This will be used to decide which issuer the payment has to go through and what should be the experience ( either sdk flow or redirection flow ).

Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to submit a PR?
None

Let me know your thoughts on this change @bernard-eugine.

Let me know your thoughts on this change @bernard-eugine.

This works! Let's go ahead.

One doubt that is bugging me is, the shipping address will be available with the merchant and should be sent by merchant during creating the payment, and billing address or details can be sent in the payment_method. This is why stripe has billing details in the payment method and shipping address outside payment method

Closing this issue as these changes are included the billing_address refactoring.