Conflict with the Bob Logistic mod and its submods

Good day! I found that your mod conflicts with mods:
Bob Logistic Krastorio2 Nuclear Locomotive https://mods.factorio.com/mod/BobLogisticKrastorio2NuclearLocomotive
Bob's Logistics mod https://mods.factorio.com/mod/boblogistics
Bob Logistic Zone Expander Radius https://mods.factorio.com/mod/BobLogisticZoneExpanderRadius
Could you please tell me - can you fix this conflict?
Thanks!

Hi,
please provide:

Logfile https://wiki.factorio.com/Log_file
Explanation: what is the conflict - a crash or an unintended behaviour ?
(optional): a minimal save game to reproduce the error.

factorio-previous.log
factorio-current.log

Local list of mods that causes this error:
Inserter Cranes
Bob's Logistics mod
Bob Logistic Krastorio2 Nuclear Locomotive
Bob Logistic Zone Expander Radius
Bob's Functions Library mod
Factorio Library
Krastorio 2
Krastorio 2 Assets

There was an issue with recipe generation if the data model of the ingredients was non-uniform like
  {
    "long-handed-inserter",
    1
  },
  {
    amount = 5,
    name = "steel-gear-wheel",
    type = "item"
  }

Should be fixed in 0.0.6
Thanks for the report !

Thanks a lot!


driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings

compilation failed with:
driver: fix: driver/mysql/mysql.go:89:23: undefined: mysql.MySQLWarnings
MySQLWarnings was removed from the mysql driver
(https://github.com/go-sql-driver/mysql/pull/676), remove it from
migrate

Duplicate of db-journey/mysql-driver#1
FYI, this repo is not maintained any more, in favor of db-journey.


⚠ Bofrost.es has degraded performance

In 0c15505, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1541 ms

Resolved: Bofrost.es performance has improved in a6a2173 after 6 minutes.


Sass support please :)

Please add support for .sass and .scss files. Thanks!

+1 for .scss support

Bump

Pull request is open at - https://github.com/javaguirre/comment/pull/2


kevm foundry-show test failed

kevm version:

v1.0.126

commit:

79530db  "Proof digests for better rebuilding (#1755) *..."

the issue:

the calculated proof file name  does not match the proof file generated by pyk.proof.proof

the error message:

File "/nix/store/35mk26r5cqzns4zwxnxyy6n6f1hhkiis-python3.10-pyk-0.1.265/lib/python3.10/site-packages/pyk/proof/reachability.py", line 46, in read_proof
raise ValueError(f'Could not load APRProof from file {id}: {proof_path}')
ValueError: Could not load APRProof from file ...

steps to reproduce:

$ cd tests/foundry
$ forge build

$ kevm foundry-kompile

$ kevm foundry-prove --test AssertTest.test_assert_true

$ kevm foundry-show AssertTest.test_assert_true

I'm sorry for not getting back to you sooner. I could not reproduce this issue, but it may have been fixed since. I'll close this for now. Please reopen if the problem persists.


Add #insert directive for glsl shaders

Picked from #1105.
Adds the ability to insert text from a specified glsl shader file into an arbitrary place in another shader.

The existing "include" method (vertexInlines/fragmentInlines) uses the #line directive so that compiler errors have the right line number. It would be nice to have that here too (and also #file I guess, if that's supported).

Please use the feature at least once in some shader. That way we can see how it is supposed to be used and verify that it really works.

Usage is expected to be done when merging the material branch:

https://github.com/DaemonEngine/Daemon/pull/1105

This is simply a process of splitting that branch in smaller chunks to review and to merge separately when possible.
I will not oppose at merging this as a structural foundation for what's coming.

I agree with the idea of just writing the file name with the suffix _fp/_vp. Having the ability to include the same file in both vertex and fragment shaders is useful. When working on the sRGB code in some of my various attempts I had to include my sRGB colorspace conversion function in both fragment shaders (for lightmaps) and in vertex shaders (for vertex lighting), and using the vertexInline/fragmentInline thing I had to duplicate the file that was annoying…
I'm not sure for the requirement about also writing .glsl extension, it should always be that anyway, and I like that in C++ it is possible to do #include <cstdio> without requiring the extension like in C.
I also agree with the remark about being able to comment out an #insert instruction.

Please use the feature at least once in some shader. That way we can see how it is supposed to be used and verify that it really works.

Like illwieckz said, it is just a smaller part of #1105. I don't support adding useless things just for the sake of an "example", this on the other hand is just something that has a proper use in another pr (that pr also shows that this works).

The existing "include" method (vertexInlines/fragmentInlines) uses the #line directive so that compiler errors have the right line number. It would be nice to have that here too (and also #file I guess, if that's supported).

I can add that, though personally I found it annoying rather than useful, because some errors didn't make sense with that directive (I had to comment it out at some points while working on #1105).

I agree with the idea of just writing the file name with the suffix _fp/_vp. Having the ability to include the same file in both vertex and fragment shaders is useful. When working on the sRGB code in some of my various attempts I had to include my sRGB colorspace conversion function in both fragment shaders (for lightmaps) and in vertex shaders (for vertex lighting), and using the vertexInline/fragmentInline thing I had to duplicate the file that was annoying…

Agreed on that, I thought the same when writing the changes in this pr, I only went with the suffixes because that's what the rest of the code that was already there was doing.

I think it's helpful to split up a large PR even if all the work isn't used in each PR.

OK, I thought it would be easy to add an example since once of the fragmentInlines/vertexInlines could be trivially replaced with a #insert but maybe I'm wrong.

The existing "include" method (vertexInlines/fragmentInlines) uses the #line directive so that compiler errors have the right line number. It would be nice to have that here too (and also #file I guess, if that's supported).

Actually, this seems like a bad idea to me now. If there's some error we'll suddenly have a line count restart in the middle of main() or similar.

I agree with the idea of just writing the file name with the suffix _fp/_vp. Having the ability to include the same file in both vertex and fragment shaders is useful. When working on the sRGB code in some of my various attempts I had to include my sRGB colorspace conversion function in both fragment shaders (for lightmaps) and in vertex shaders (for vertex lighting), and using the vertexInline/fragmentInline thing I had to duplicate the file that was annoying…

I also agree with the remark about being able to comment out an #insert instruction.

Done now.

OK, I thought it would be easy to add an example since once of the fragmentInlines/vertexInlines could be trivially replaced with a #insert but maybe I'm wrong.

It would be trivial to do so, but I just don't see the point of it. The shaders we had worked fine with the inlines thing, so why change them just for the sake of changing? #1105 works as the example IMO.

The existing "include" method (vertexInlines/fragmentInlines) uses the #line directive so that compiler errors have the right line number. It would be nice to have that here too (and also #file I guess, if that's supported).

Actually, this seems like a bad idea to me now. If there's some error we'll suddenly have a line count restart in the middle of main() or similar.

What do you mean?

What do you mean?

For example if there's:
void main()
{
	#insert material_fp

	// Compute view direction in world space.
	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

in a shader, then if there's an error you're gonna see something like this if there's an error:
59: void main()
60: {
0:  	  // A bunch of inserted stuff
132:
133:  	// Compute view direction in world space.
134:  	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

I think that'd be annoying.

I was thinking mainly to have the line directive after the insertion, to maintain correct line numbers for the main file. So #line 61 in your example.
Additionally adding line directives at the beginning of the insertion is also possible, but it seems there is no way to set the file name to that of the included shader, so maybe there is no point.

Actually if you have an insert on line 60, maybe the best thing would be to put #line 59 before every single line so the user will know any error came from the insert on line 60 😂

Just an idea that crosses my mind, but I wonder if that's doable, even if ugly, to assume we will never have GLSL files of 10k lines, and then we may prefix insert with #line 10000, with 1 being the first insert.
Let's imagine we have this:
void main()
{
	#insert material_fp
	#insert blabla_fp
	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

We would do:
#line 0
void main()
{
#line 10000
	#insert material_fp
#line 20000
	#insert blabla_fp
#line 4
	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

So we would get:
0: void main()
1: {
10000:	code_from_material_fp;
10001:	code_from_material_fp
10002:	code_from_material_fp
10003:	code_from_material_fp
10004:	code_from_material_fp
20000:	code_from_blabla_fp;
20001:	code_from_blabla_fp;
20002:	code_from_blabla_fp;
4: 	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

Actually if you have an insert on line 60, maybe the best thing would be to put #line 59 before every single line so the user will know any error came from the insert on line 60 😂

Lol, that doesn't sound too bad. Something better in general than just doing #line 0 everywhere would be great, e. g. keep a table that matches the non-reset line count to filename + line, then if an error occurs try to get the reported line and lookup in that table... The problem is I don't think shader compiler errors are standardized in any way.

Just an idea that crosses my mind, but I wonder if that's doable, even if ugly, to assume we will never have GLSL files of 10k lines, and then we may prefix insert with #line 10000, with 1 being the first insert.
Let's imagine we have this:
void main()
{
	#insert material_fp
	#insert blabla_fp
	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

We would do:
#line 0
void main()
{
#line 10000
	#insert material_fp
#line 20000
	#insert blabla_fp
#line 4
	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

So we would get:
0: void main()
1: {
10000:	code_from_material_fp;
10001:	code_from_material_fp
10002:	code_from_material_fp
10003:	code_from_material_fp
10004:	code_from_material_fp
20000:	code_from_blabla_fp;
20001:	code_from_blabla_fp;
20002:	code_from_blabla_fp;
4: 	vec3 viewDir = normalize(u_ViewOrigin - var_Position);

This looks like a good idea to me.

Squashed the small fix, no actual changes.


What resources are needed for custom Ig dbs and/or other species?

If I want to use BALDR with a custom IG gene database, which items in the resources folder do I need to replicate/change? Just the IgBlast (assuming still want to use IG-mapped_Unmapped or FilterNonIG modes only)?

For human, if you just replace the files in the <BALDR_path>/resources/IgBLAST_DB/human folder, it should work.
For rhesus, I can make some minor changes so you can do the same. Presently, the files in the internal data are being used for rhesus macaques that is based on Sundling et al.  2012.

I have added a db flag that allows you to specify the folder containing the custom IgBLAST files. Please note that filenames have to be the same as specified:
human_IG_V.,human_IG_D.,human_IG_J.,human_IG_C.,human_gl.aux
OR
rhesus_monkey_V.,rhesus_monkey_D.,rhesus_monkey_J.,rhesus_monkey_C.,rhesus_monkey_gl.aux

For the moment, mostly interested in using custom databases for human. May get into other species down the road. Thanks for the info/help, will test later this week!


Question about custom theming

Just have a question - when designing your own theme, why is there a need for 4 parameters for mat-palette?
From the guide here https://github.com/angular/material2/blob/master/guides/theming.md
// Define the palettes for your theme using the Material Design palettes available in palette.scss
// (imported above). For each palette, you can optionally specify a default, lighter, and darker
// hue.
$candy-app-primary: mat-palette($mat-indigo);
$candy-app-accent:  mat-palette($mat-pink, A200, A100, A400);

I don't quite understand how the mat-palette works and why it needs 4 parameters. I understand the first parameter which specifies the color. I do not understand why there is a default, lighter and darker color.
I thought the primary and accent were used like this
<md-toolbar color="primary">
text
</md-toolbar>

Is here a way I can specify that I want the toolbar a little dark or little lighter than primary?

It doesn't need it. it's just to show that you can specify colors apart from selecting the primary color.
btw, this kind of questions is better for StackOverflow.

Thanks Nikki1993 - just to clarify - I know that the values are optional, but I want to know if these extra values are used at all. If so where? And if not, what is the purpose of specifying them in the theme if they cannot be used anywhere.
And I did create a question on Stackoverflow but I didn't get any answers there.

@waiholiu It's got something to do with hues which are part of the Material spec (colors).
View this: https://github.com/angular/material2/blob/master/src/lib/core/theming/_theming.scss#L12-L36

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


Not all storage clients are named in the same way

Super nit
BlobStorageClient

vs
QueueServiceClient
TableServiceClient
FileServiceClient

I'm not sure that this warrants a breaking change. It seems pretty mundane to me. What are your thoughts, @jhendrixMSFT?

I think there is some value in uniformity, however I wouldn't introduce such a breaking change just for that sake.  However since we'll be refactoring the blob storage APIs anyways (and introducing breaking changes) we can fix the client name at that time.

Sweet, what's the milestone we're going to be using there? Is that scheduled for 9.0?

(Tagging the PR associated with this conversation) #532

For further conversation on this topic, please see this issue linked above.

I don't think this is worth fixing. I'm going to close it out.


Tour of Ingest

Describe the bug
faker.optional throws error:
Traceback (most recent call last):
File "/Users/jdority/src/tour_of_ingest/./data_generator.py", line 44, in
print_lift_ticket()
File "/Users/jdority/src/tour_of_ingest/./data_generator.py", line 34, in print_lift_ticket
'phone': fake.optional(fake.phone_number())
TypeError: 'OptionalProxy' object is not callable
URL of where you see the bug
Test Data Generator
https://quickstarts.snowflake.com/guide/tour_of_ingest/index.html?index=..%2F..index#2
To Reproduce
Try to execute the code and you will experience
Expected behavior
Cutting and pasting the quickstart code should work.  :-)
Additional context
[Add any other context about the problem here.]
https://pypi.org/project/optional-faker/
Note that faker added own optional proxy, which however can be used only with callables. This is why in version 2.0.0 we renamed our method to none_or.
If I replace optional with none_or method, the code works as advertised.

fixed in #1585


License of this template

Hi, it seems like this repository is meant to be public so that it can be reused. However, it is missing a license file which makes reusing a bit difficult. Is this intended? Otherwise, it would be nice if a license was added to this project 😀.

good eye! added, thank you.

Great, thanks!


Explicitly schedule codesigning on luci for release branches

This is blocking https://github.com/flutter/flutter/issues/81795
Infra is bringing up a new postsubmit scheduler which is blocked on ensuring all existing targets are scheduled on luci.
https://github.com/flutter/flutter/pull/92218 needs to be cherry-picked into the beta and stable release branches, and then for the configs to be rolled into flutter/infra.
Cherrypicks for next beta hotfix

[x] https://github.com/flutter/flutter/pull/92218
[x] https://github.com/flutter/engine/pull/29213
[x] https://github.com/flutter/flutter/pull/92442

Closing as the CPs window closed. Feel free to reopen if there's more infra changes to CP.


Problem when building brutal

It returns me this error:
In file included from sources/kernel/x86_64/boot.c:21:
sources/kernel/x86_64/stivale2.h:4:10: fatal error: 'stivale/stivale2.h' file not found
#include <stivale/stivale2.h>
^~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [sources/kernel/.build.mk:37: build/x86_64-llvm/cross/kernel/x86_64/boot.c.o] Error 1

Did you pull the submodules ?

Uh oh
i forgot that :')

Run git submodule update --init --recursive and retry, it should work just fine.

Ok, build works, but lol your kernel is unstable :')
cpu0: panic: vmm.c: 69: 0xffffffff80201000 is already mapped to 0xa30000

Or when you clone the repositiry you can add the flag —recursive.

cpu0: panic: vmm.c: 69: 0xffffffff80201000 is already mapped to 0xa30000

Could you share all the logs please ?

Ok, build works, but lol your kernel is unstable :')
cpu0: panic: vmm.c: 69: 0xffffffff80201000 is already mapped to 0xa30000

This bug is now fixed with commit 69b1a89d51fba1dc09edf87cca4d23b7a169c47e


Remove react from dependencies

(should be only in peer dependencies)

This kind of driving me crazy though. Issues like #102 ...

I +1 this pull request. It makes sense to remove it from dependencies. I currently have my project depending on React 0.14.0-rc1 using NPM 3. Because there is a conflict of dependencies, react-google-maps has its own version of React being installed. If we were to remove the dependency, then react-google-maps would inherit from the peer dependency.

Released v3.0.0 so that it doesn't accidentally breaks the old versions.


fix: exclude @carbon/charts and @carbon/charts-react from ssr

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Fixed in v0.16.15. Also tried the build on the website with the latest version of charts, it's working well


TN-1163 cleanup & py3 compatibility for test_celery.py

Hello @John0Randolph! Thanks for submitting the PR.

In the file tests/test_celery.py, following are the PEP8 issues :

Line 13:80: E501 line too long (87 > 79 characters)
Line 13:88: W291 trailing whitespace
Line 14:17: E128 continuation line under-indented for visual indent
Line 16:50: E222 multiple spaces after operator


Tables are not responsive and breaks viewpart in mobile

Is it working in our current docs.minio.io?

breaks in mobile. desktop is fine


Removing unused thirdparty dependency - jquery-effen.

@tractorcow - part of the Open Sorcerers internal backlog. Last one of the removals!

One less effen thirdparty.


Performance issues on large files

I noticed some poor performance when using this extension on large files. For some files the extension is basically unusable due to how long it takes to process.
When I was developing atom-parinfer, I tested against cljs.core - which has over 10k lines. Had to come up with some performance hacks to improve Parinfer performance for that threshold.
Mainly:

Only sending the code that had likely changed to Parinfer instead of the whole file. See: this code as well as Issue #9
The use of a small LRU cache to prevent repeated processing.

I'm not sure these are perfect solutions and @shaunlebron has expressed improving performance in the main Parinfer algorithm, but these tricks might be helpful in the meantime.

Since this issue was opened, parinfer.js has been re-written and is substantially faster than the implementation currently being used for this plugin.
atom-parinfer still uses the "parent expression" performance hack described here, although to be honest I'm not sure this is even necessary anymore. Either way, there have been zero complaints from users about speed issues.
FYI

fixed by https://github.com/shaunlebron/vscode-parinfer/pull/10


Feature/344 enable scoring for selectize and multipleselectize fields again

Description
Before I disabled options scoring for all selectize field types, Selectize, SelectizeMultiple and SelectizeMultipleAutocomplete. And it perfectly works for autocomplete fields, which loads proper results for each query.
But regular Selectize fields have loaded options once on rendering, and disabling scoring them shows inappropriate search results, matched options are on their positions in all options list and not moved to the top.
So, equal scoring for non-autocomplete field should be disabled.
Fixes #344
Type of change

Bug fix (non-breaking change which fixes an issue)

Coverage remained the same at 73.318% when pulling f73b480af0653fcbdbd9c7b4182f645fe1c9b720 on feature/344-disable-options-ordering-by-Selectize into bc577bd4c86d479932aab96474409338446657f9 on develop.

can you fix the merge conflict, then it's possible to merge this pull request


fix: disable number change in case of scrolling

Closes  https://github.com/nextui-org/nextui/issues/4238
📝 Description
added a prop disableScrollChange to disable change in the input when the type is number
⛳ Current behavior (updates)
disable change in number on scrolling with mouse wheel or touchpad, since it can change value without user noticing when in scrollable container
🚀 New behavior
prop added to disable if needed
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

Summary by CodeRabbit

New Features

Introduced an optional property disableScrollChange to enhance input control during scrolling.
Added functionality to prevent value changes when the input is scrolled, improving user experience.

please don't work on assigned issue
we plan to have NumberField so we shouldn't add a new prop to input.

Ok thanks @wingkwong


Can we run Portainer without Installing Docker on Cent OS.

Question:
How can I install Portainer on Cent OS without Installing Docker?
I just want to Install Portainer On my main machine which will be used to connect to different machines running different containers and portainer agent.
Is there any way to do Install portainer on local machine instead of creating its container?

Running Portainer outside of a container isn't something that we support. There are likely to be some issues with how it works as we don't build with this scenario in mind. While you could certainly try this setup, we wouldn't be able to provide any assistance with doing so.

Okay No problem!
Thank you for your support !


Assistance with lockup after boot?

This is such a great project! Thank you for making it available.
I followed the steps in the readme to set everything up on a NodeMCU and did need to use the 1.4 instead of 2.0. I've configured wifi and It boots just fine after that however, it seems to freeze about 15 seconds after that. I have just enough time to open the root web page but it stops responding after that.
Can you offer any ideas one what I can check? Here is the output of the serial monitor with ext ip and pwd redacted.
ESP8266 IR Controller
Config pin GPIO10 set to: 1
mounted file system
reading config file
opened config file
{"hostname":"irblast","passcode":"****","port_str":"80","user_id":"","ip":"<IP_ADDRESS>","gw":"<IP_ADDRESS>","sn":"<IP_ADDRESS>"}
parsed json
*WM: Adding parameter
*WM: hostname
*WM: Adding parameter
*WM: passcode
*WM: Adding parameter
*WM: port_str
*WM: Adding parameter
*WM: user_id
Using Static IP
*WM:
*WM: AutoConnect
*WM: Connecting as wifi client...
*WM: Custom STA IP/GW/Subnet
WM: <IP_ADDRESS>
WM: Using last saved values, should be faster
WM: Connection result:
WM: 3
WM: IP Address:
WM: <IP_ADDRESS>
WiFi connected! User chose hostname 'irblast' passcode '' and port '80'
WiFi configuration complete
Local IP: <IP_ADDRESS>
URL to send commands: http://irblast.local:80
ArduinoOTA started
MDNS http service added. Hostname is set to irblast.local:80
HTTP Server started on port 80
External IP: xxx.xxx.xxx.xxx
External IP address request took 376 ms
Ready to send and receive IR signals
Turning off the LED to save power.
Connection received

Hm that’s a tough one it looks like everything is working as it should. What exactly freezes and after freezing does it crash or do you get any reports in the serial log or just what’s posted?
If you remove all connections from your board (disconnect from breadboard) and try again does that make any difference?
Sent from my iPhone

On Mar 16, 2018, at 4:42 PM, chrislawson<EMAIL_ADDRESS>wrote:
This is such a great project! Thank you for making it available.
I followed the steps in the readme to set everything up on a NodeMCU and did need to use the 1.4 instead of 2.0. I've configured wifi and It boots just fine after that however, it seems to freeze about 15 seconds after that. I have just enough time to open the root web page but it stops responding after that.
Can you offer any ideas one what I can check? Here is the output of the serial monitor with ext ip and pwd redacted.
ESP8266 IR Controller
Config pin GPIO10 set to: 1
mounted file system
reading config file
opened config file
{"hostname":"irblast","passcode":"****","port_str":"80","user_id":"","ip":"<IP_ADDRESS>","gw":"<IP_ADDRESS>","sn":"<IP_ADDRESS>"}
parsed json
*WM: Adding parameter
*WM: hostname
*WM: Adding parameter
*WM: passcode
*WM: Adding parameter
*WM: port_str
*WM: Adding parameter
*WM: user_id
Using Static IP
*WM:
*WM: AutoConnect
*WM: Connecting as wifi client...
*WM: Custom STA IP/GW/Subnet
WM: <IP_ADDRESS>
WM: Using last saved values, should be faster
WM: Connection result:
WM: 3
WM: IP Address:
WM: <IP_ADDRESS>
WiFi connected! User chose hostname 'irblast' passcode '' and port '80'
WiFi configuration complete
Local IP: <IP_ADDRESS>
URL to send commands: http://irblast.local:80
ArduinoOTA started
MDNS http service added. Hostname is set to irblast.local:80
HTTP Server started on port 80
External IP: xxx.xxx.xxx.xxx
External IP address request took 376 ms
Ready to send and receive IR signals
Turning off the LED to save power.
Connection received
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the quick response. I am currently testing with board only with nothing connected and no breadboard.
I am not sure how else to describe the 'freeze'. The board no longer responds to HTTP requests nor does it respond to IR signals when I had the receiver hooked up. Nothing else appears on the serial monitor after this point. The only way to get it to respond again is to press the reset button but then it just freezes again.
I tried another quick test by rebooting and then refreshing my browser as quickly as I could. I was able to get 3 requests in before it died. Here's all that is at the end of the log.

Turning off the LED to save power.
Connection received
Connection received
Connection received
I am sure that the issue is related to my setup or something that I did, not necessarily a bug with your code. I'm a noob to this and was hoping for any guidance to help me troubleshoot and resolve.

I have the same problemma, the receive-transmits about 5 times and freezes. only the reboot works.

Hm I have about 4 primary devices and multiple test devices and most of them have uptime measured in the months without rebooting. What hardware are you guys using that’s definitely not a standard issue

I'm using LoLin's new NodeMcu V3 (serial ch340g). And the reset of the pins does not work, maybe this problem?
....I'll try to disable today the transfer serial, maybe can help.

Yeah I haven’t tested V3 all my boards are V2 so it might be a short on a pin. You can play around with the default pin outs and maybe try moving the receive and send pins around too. If you notice it fails after receiving a signal then maybe the receive pin is an issue and needs to be changed.
Sent from my iPhone

On Mar 17, 2018, at 7:54 AM, FCustoms<EMAIL_ADDRESS>wrote:
I'm using LoLin's new NodeMcu V3 (serial ch340g). And the reset of the pins does not work, maybe this problem?
....I'll try to disable today the transfer serial, maybe can help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I tried the full setup again from my mac instead win laptop and get the same results though, I was able to use the IwIP v2 instead of the v1. Upon boot the board responded for about a full minute then quit.
I am not sure what version my board is but I think at this point I need to order a new one and try again.
Feel free to close this. Thanks!!

Hey guys, I have a similar problem. I'm also using the so called "V3" variant of this board from LoLin. Everything seemed to work fine, but when I send multiple commands in a row, like pulse=3, the device will freeze and I will have to press RST button. By freeze I mean it will not respond to ping anymore and is not accessible. I have noticed, when I send a single IR command, the command gets executed, but one ping packet will be highly delayed (like 200ms compared to 3ms normally).
I wonder if it could be an "out of power" issue or something like that?
While assembling the board I found out that apparently you cannot use VIN with these boards; instead I used VV for 5V power supply.
The reason I hope to find a fix for that is because first tests looked good so I have just finished soldering everything together what took hours (guess I'm not too good in soldering) so it would be a pain to do it again with another board. Hope someone has a hint for me! Thanks!

I was able to resolve my freezing issues by downgrading the esp8266 board library in Arduino board manager from version 2.4.1 to version 2.4.0. This has been mentioned in issue #160 and this worked for me.

It’s a memory leak in lwip in 2.4.1, there is a bug raised in the project, hopefully fixed in 2.4.2, but as mentioned above 2.4.0 works fine..

I confirm! changed version to 2.4.0 and it all worked
18 мар. 2018 г. 3:48 ПП пользователь "Jake"<EMAIL_ADDRESS>написал:

It’s a memory leak in lwip in 2.4.1, there is a bug raised in the project,
hopefully fixed in 2.4.2, but as mentioned above 2.4.0 works fine..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mdhiggins/ESP8266-HTTP-IR-Blaster/issues/163#issuecomment-373995992,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af01mLSHC08ac-NC-24qsFDfViIAtgDTks5tflesgaJpZM4SuaQN
.

I have had limited success with changing to 2.4.0.  I no longer experience freezes but only if I choose the the IwIP v2 Lower Memory or v2 Higher Bandwidth. Using v2 prevents retrieval of my external IP when I bring up web interface. It reports this message:
Error - unable to retrieve external IP address, this is likely due to improper network settings
Error - EPOCH time is inappropraitely low, likely connection to external time server has failed, check your network settings
If I use the IwIP v1.4 in combination with 2.4.0, I still get the lockup.

@chrislawson In 2.4.0 I don't get those options.. I only get the below, so may not be removed correctly?

v2 Prebuilt (MSS=536)
v2 Prebuilt (MSS=1460, unstable)
v1.4 Prebuilt <<< I'm using this
v1.4 Open Source

I'm not using external IP so can't add much more, although the guide does say to use lwip 1.4 as 2.0 causes issues.

@jebbett you are correct. I looked at the list of boards and found there to be TWO ESP8266 Modules sections. I selected the correct board from the other list and found the v1.4 Prebuilt that was described.
Everything is now working exactly as expected. Very happy!

Glad its all working


About validation set in training pharse

Does validation set play a role in training parameters for model? Or it's just used to choose hyperparameters (e.g numer of epochs...).
Thank you.

Yes, you can do an ablation study of hyper-parameters using the validation set.


rn 0.60.5 support

react-native 0.60.5 - package android.support.v4.content does not exist
See Issue https://github.com/react-native-community/react-native-geolocation/issues/52

@xuwilliam in the meanwhile you can fork and pull from your fork.
In my case I just change this line on my package.json file
from "@react-native-community/geolocation": "^1.4.2"
to "@react-native-community/geolocation": "git+https://github.com/jgtoriginal/react-native-geolocation.git#master"
It's a good workaround, but when you got too many of these on your dependencies it might be hard to manage.

This broke support for react-native 0.59


Does hklight work on OSX?

Hi,
I just wanted to dip my toes into this project by playing with hklight. But after starting it my iPhone does not see the accessory. Before I investigate further, is this known?
regards

Yes, it does work on OSX


Refactor PanResponder example to avoid componentWillMount()

React Native v0.54 uses React v16.3, which deprecates various lifecycle methods including componentWillMount(). In the PanResponder docs, the recommended approach is to set up PanResponder methods in componentWillMount(). Could the docs now be updated with the recommended replacement approach?

Thank you for taking this @andrwsalcdo.

would it be best to add a description or a link describing the various lifecycle changes

Where would you add this? If it's inside the PanResponder docs, I don't think it worth mentioning as after the refactoring, beginners won't notice the changes from the previous version.

ah fair, but for those beginners that were learning from outdated resources? eh, it's probably a bit of a stretch, but I thought I ask.


dune: init at 2.0.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg fstar

@GrahamcOfBorg build fstar

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/explicit-runhook-in-derivation/4614/34

Do you want to add dune-configurator as well or it would be better to add it in a separate PR?

Why would we want to keep Dune 1.11 in nixpkgs?

dune 2 is a major version bump, a there are multiple packages which still haven't been migrated, for instance, janestreet packages.
I tried to set dune 2 as default, but I encountered various errors, hence only added dune_2 only as another attribute.
Only the last three commits are relevant; @vbgl should I cut the other commits into a separated PR?

dune 2 is a major version bump, a there are multiple packages which still haven't been migrated, for instance, janestreet packages.

In theory, Dune 2 shouldn't break Dune projects which set the Dune language version to a lower version than 2.0. However, it does break the projects that have not migrated to Dune from jbuilder. Did you find examples beyond this? If yes, it could be interesting to look into them more closely and possibly report the issues to Dune developers.
In any case, this PR LGTM (in full, including the version bumps) and I'm in favor of merging it as-is now (without splitting).

@marsam I'd like to encourage you to go ahead and merge this without waiting further.

@marsam or @vbgl: please merge this now.
BTW: PR title should be edited to reflect the change (dune_2: init at 2.1.0).

@Zimmi48 sorry for the delay, I was waiting for another review; merging as-is because it shouldn't introduce any major change. @vbgl I hope you don't mind

Thanks!

@marsam This PR included an update for cppo from 1.6.5 to 1.6.6. This broke building cppo with ocaml 4.02, which is still needed for some things.

@Shados sorry about that, reverted in https://github.com/NixOS/nixpkgs/pull/76942


Front-end web programming: mention templating

Another area for improvement, IMHO:

Haskell tools tend to focus on building HTML pages without writing HTML.  That's cool, but not appropriate for everyone.  Projects to watch: Hastache for Mustache templates (fairly mature), and @sourrust's Karver (inspired by Jinja) which finally provides some whole-page HTML templating.

Yeah, I will definitely add Hastache / Karver.  I also want to mention lucid if you haven't checked it out already (it's an in-language DSL for building HTML).


Check whether conditionals use different types in branches

We should catch this common error and report it.
See also: https://jira.hl7.org/browse/FHIR-42731

I left a comment in the Jira tracker, we may want to start with just providing a mechanism to have a "code" for errors and warnings and start using that for any warnings we want to be able to suppress?


Substituting '-index.html' to 'txt' doesn't work now

Hi all,
For recent 10-K files, this mechanism doesn't work. It works for AAPL 2001 but not for 2017.

Hey everyone, first I have to say im a total noob.
I am also getting an issue with recent statements. Tried with APPL and PM and the files I end up with are formatted wierdly.
Output looks like:
`UNITED STATES  SECURITIES AND EXCHANGE COMMISSION  WASHINGTON, D.C. 20549
FORM 10-Q  (Mark One)

(X)
 QUARTERLY REPORT PURSUANT TO SECTION 13 OR 15(d) OF THE SECURITIES EXCHANGE ACT OF 1934
For the quarterly period ended September 30, 2011  OR

(  )
 TRANSITION REPORT PURSUANT TO SECTION 13 OR 15(d) OF THE SECURITIES EXCHANGE ACT OF 1934
For the transition period from
to
Commission File Number 001-33708  Philip Morris International Inc.
(Exact name of registrant as specified in its charter)
`

I will check out this and fix it.

@yunjianyang have you tried working with the most recent version (0.1.4)? Now it should work. I did note when using a later date for AAPL that the documents were out of order, but the documents were still downloaded.

Using the following should work:
from SECEdgar.crawler import SecCrawler

crawler = SecCrawler()
crawler.filing_10K('AAPL', '0000320193', '20190101', '10')

Thank you. I'll try it later.


If I want to use the method in Chinese Audio DeepFake Detection Task

Hello. I want to use the method on Chinese dataset, the pre-training model is not doing well. It prefer to generate "Fake" if the input is Chinese and "True" if input is English.

So If I want to retrain  it with Chinese, What should I change? If the Whisper tiny.en is still work? Thank you so much,


MODNet demo

Are there instructions how to use MODNet with tensoreflow.js WebGL and WASM backends?
https://github.com/w-okada/image-analyze-workers/issues/30#issuecomment-809368284

Please consolidate your questions into the original repository.

I'm trying to to multiply the matting with the original image to remove the background but getting strange results:

When testing with test2.jpg the hair is cut. Shouldn't  MODNet preserve hair?
When testing with this image there is an offset between the matte and image. Am I doing something wrong?

This is the code I've added at the bottom of https://github.com/PINTO0309/PINTO_model_zoo/blob/main/078_MODNet/test_tflite.py
img = Image.open('test2.jpg')
w = img.size[0]
h = img.size[1]
img = np.asarray(img)
img = img / 255.
img = img.astype(np.float32)

matte = Image.fromarray(((matte * 255).astype('uint8')), mode='L')
matte = matte.resize((w, h), Image.LANCZOS).convert("RGB")
matte = np.asarray(matte)
matte = matte / 255.
matte = matte.astype(np.float32)
img = img * matte
Image.fromarray(((img * 255).astype('uint8')), mode='RGB').save('test2_full.jpg')

Is it a problem with the model translation to tensorflow.js? I don't have this issue in the demo.


DUPLO-1389 fix: update provider docs for ECS service and task definition

Change description

Description here

Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Related issues

Fix #1

Checklists
Development

[ ] Pull requests may not be submitted to the master branch (use develop instead) - or they will be closed.
[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer.
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

Task linked: DUPLO-13189 TF Provider Docs: duplocloud_ecs_task_definition and duplocloud_ecs_service docs need to be updated


As a developer, I need to delete all annotations that have a no longer existing user project ID

Where
Workspace / User projects
Current situation:
If a user deletes a user project s(he) is not aware that the annotations that have the ID of that user project are not deleted (since they are stored in a different index).
Because of this there are several "orphaned" annotations (with a project ID that no longer exists)
Short term solution:

After the release of version 3.2 we'll ask the users to delete their unused projects.
A script that runs periodically deletes the resulting "orphaned" annotations

Acceptance criteria

[ ] write a script that deletes orphaned annotations (loop through all annotations and check if the project still exists)
[ ] do NOT delete annotations without a project ID (these are used in motu/arttube)
[ ] test the script first on the test cluster only
[ ] finally deploy the script on xeniaonatopp and hook it up to a cronjob. Use it to clean both test & prod (make sure it can connect to both APIs)

@lilimelgar thanks for creating the issue. Added the technical details & put it in the backlog

Issue moved to beeldengeluid/labs-annotation-api #7 via ZenHub


Missing Part of I80 (stock map)

I today i found a missing part of the Interstate 80 between Cheyenne (WY) and Sidney (NE).
The ramp in booth citys is there but nothing between.
Mobile version 4.0.9

ATS (stock map) 1.50

Missing part

Thank you for reporting this. I have uploaded the updated tiles, try to download and replace them for ATS
https://github.com/meatlayer/ets2-mobile-route-advisor/tree/master/maps/ats/tiles
This should solve the problem with the road display

Thx for the fix. Works for me


Module compiled with Swift 4.0.2 cannot be imported in Swift 4.1

I'm still getting this error: Module compiled with Swift 4.0.2 cannot be imported in Swift 4.1 with realm 3.3.2. I added Realm.framework and RealmSwift.framework manually to my project.
Realm framework version: 3.3.2
Xcode version: 9.3
iOS/OSX version: 8+

@iGranDav I suppose you have the same (wrong) assumption as I did. Realm doesn't provide a binary for Swift 4.1 through Carthage yet. See my other issue: https://github.com/realm/realm-cocoa/issues/5725

@EmDee exactly! Thanks a lot for your help 👍


Add guidance about using example dates in hint text

Add the following sentence to the guidance for Date input:
Make sure that any example dates you use in hint text are valid for the question being asked.
This came up in our support channels and is particularly relevant when the date you are asking for must fall with in a range relative to the current date (eg. 'within the last 2 weeks'). In cases like this example dates in hints would need to be programatically generated, to make sure they don't keep falling outside of the permissable date range.

Content review requested


Make menu props driven

It should be possible for the menu to handle isOpen change so it's possible to keep its state in e.g. Redux store and use actions instead to operate on its behaviour.
I think its similar to #76 but it was closed by the author (unfortunately, because it's way better approach).
That's what I am using in my wrapped side-menu version to handle that use-case:
  constructor(props) {
    super(props);
    this.isOpen = this.props.isOpen;
  }

  componentWillReceiveProps(props) {
    if (this.props.isOpen !== props.isOpen) {
      this.toggleMenu();
    }
  }

CC: @steida that's actually what we have in Este as well.

https://github.com/react-native-fellowship/react-native-side-menu/blob/master/index.js#L71-L75 already

Cool, so this can be closed, CC: @steida


Fix/prioritize concrete branches

Change PathFinder to prefer concrete paths over template paths.

@grinspins thank you for the contribution .That's very useful fix.

@grinspins thank you for the contribution .That's very useful fix.


Add keys, values and items methods to SkiffOtherColumns

It is impossible to iterate over yt.wrapper.schema.OtherColumns right now.
I tried to fix this, but then I realized that it is not enough to patch the TSkiffOtherColumns class and patches to LazyDict and YsonLazyMap are needed.
I tried to do it here: https://github.com/chegoryu/ytsaurus/commit/b2fc1a368f2eed5bd2c39357b860f0cbbe698d5d#diff-acb34ed36b4af9761bbb1023c42f1cba447c1dd7493756e80a819ed51dd4c912R84-R101
And it works when TSkiffOtherColumns::Map_ backend is default python dict ( test_typed_api.py::TestTypedApi::test_other_columns[v4-False] passed), but sometimes it is YsonLazyMap (in test test_typed_api.py::TestTypedApi::test_other_columns[v4-True] for example):
yt/python/yt/wrapper/tests/py3_only <py3test> [size:large] [tags: ya:external, ya:fat, ya:force_sandbox, ya:full_logs, ya:noretries, ya:yt, ya:ytexec]
------ sole chunk ran 3 tests (total:20.85s - test:20.83s)
[fail] test_typed_api.py::TestTypedApi::test_other_columns[v4-True] (levysotsky) [default-linux-x86_64-debug] (13.15s)
yt/python/yt/wrapper/tests/py3_only/test_typed_api.py:750: in test_other_columns
    assert list(other_columns.keys()) == ["y"]
E   AttributeError: 'yt_yson_bindings.yson_lib.YsonLazyMap' object has no attribute 'keys'
Log: /home/echunaev/git/ytsaurus_v2/yt/python/yt/wrapper/tests/py3_only/test-results/py3test/testing_out_stuff/test_typed_api.py.TestTypedApi.test_other_columns.v4-True.(levysotsky).log

Then I tried to add keys/values/items methods to LazyDict, but unfortunately I don’t have enough time for this right now, so I found workaround and decided to just create an issue.
Workaround is:
for key_column, key_column_value in yson_loads(yson_dumps(other_columns, yson_format="binary")).items():
    pass

I really needed it, thanks for workaround
Hope this issue will be solved some day


[KILO]: Quarantine paymentDescriptor to the lnwallet package

Change Description
This PR's main contribution is quarantining the paymentDescriptor type to the lnwallet package. This is in preparation for upcoming changes where we try and change the fundamental unit of the update log to a LogUpdate, as opposed to the former PaymentDescriptor. This is because we will functionally eliminate the PaymentDescriptor as a meaningful idea and instead just have a linear sequence of log updates accompanied by some sparse indices for other metadata. To effectively accomplish this, however, we have to reduce the scope of making significant changes to this data structure and that begins by making sure it does not leak outside the package.
The primary observation that allows us to do this is to realize that the only other place this is currently used is in the processRemote[Adds|SettleFails] functions within the ChannelLink. What is notable about this is that this information is already duplicated in the forwarding package itself. A forwarding package is already a sequence of updates that is committed by a given commitment transaction. Since the link does not make use of the metadata beyond that we simply just make it use the LogUpdates inside the forwarding package rather than the accompanying payment descriptors.
In my best assessment this is completely safe to do and so far none of the testing I have done has revealed that we cannot do this. However, it is worth paying special attention to what I am doing here and ensuring that it does not miss an important detail on which we rely.
Steps to Test
make unit pkg=lnwallet
make itest
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ] There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

@proofofkeags, remember to re-request review from reviewers when ready

+1 for YY's commit restructuring comments.

I will do that but I don't want to hear any complaints about diff churn. There was a reason this was done as one commit originally.

Note: will sign commits prior to merge. I just forgot my Yubi today.

cACK, did a first pass on this and the structure looks great - thanks for breaking it up!
Will do a more in depth pass tomorrow 🔎
There is a suss-ish looking itest failure - listsweeps failing in a few CI cases. Flagging because I'm out of touch with the known flakes, probably unrelated.

Note: will sign commits prior to merge. I just forgot my Yubi today.

kek thoughts and prayers, this small annoyance ruins my entire day when it happens 💀

Rebase locked and loaded. Game on @guggero

Looks like the only test failures are from something going on with the sweeper?

This PR is ready for merge if @Roasbeef or @Crypt-iQ do not object by EOD Wednesday.


Test Python 3

The docker container currently only tests Python 2.  It would be nice to extend this.

It looks like we can pass environment variables into the docker containers http://stackoverflow.com/questions/30494050/how-to-pass-environment-variables-to-docker-containers


Errors and warnings during startup

Hey!
First off, thanks for the great mod. I noticed that there are some errors during startup:
[11:28:31] [main/WARN]: Mod `sign_editor` (mc-1.16.1-0.6.1) does not respect SemVer - comparison support is limited.
[11:28:31] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.2 Source=file:/fabric-server-launch.jar Service=Knot/Fabric Env=SERVER
[11:28:38] [main/INFO]: Loaded configuration file for Lithium: 63 options available, 0 override(s) found
[11:28:38] [main/WARN]: Error loading class: net/minecraft/class_498 (java.lang.ClassNotFoundException: net/minecraft/class_498)
[11:28:38] [main/WARN]: @Mixin target net.minecraft.class_498 was not found signEditor.mixins.json:SignEditScreenMixin
[11:28:46] [main/INFO]: Better Signs & Frames Initializing

I think it's nothing major, but I didn't see an open issue for it :)

SemVer warning has been fixed. Please open another issue if you're still seeing warnings =)


FINERACT-1429 : FD Interest Transfer on a backdated account

Description
There is an erratic behaviour when the transfer job runs and transfers posted interest in a backdated FD account to a linked savings account.
This happens especially when  Interest posting is set to  be in the end of period.
(https://github.com/apache/fineract/pull/1284).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[x] Create/update unit or integration tests for verifying the changes made.

[x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Lets give this sometime before Travis can run..Or maybe in time the new Github Actions based CI in https://github.com/apache/fineract/pull/1955 will already be in place to test this.

Trying to Trigger Travis build

One test case failed on Travis
Test testLoanImport() FAILED (19.2s)
@shreyas-s-k , please retry.

@ptuomola (cc @awasum @fynmanoj @vidakovic ):
Please find 2 new additions to the list of flaky tests :-
testCenterReschedulingLoansWithInterestRecalculationEnabled
testCenterReschedulingMultiTrancheLoansWithInterestRecalculationEnabled
Merging the PR as it's not the committer's responsibility to get a proposed PR to pass the build when there are 25+ flaky tests. Committer has checked with gradle test command that all non flaky tests are passing.
The data points you are referring to in the other thread to deny the existence of flaky tests is not valid as they are manipulated.
Perhaps a way of not stepping on each other's feet is to separate the services as you were discussing with Aleksander. I think Batch API module is a good place to start as it's already decoupled at the service and domain layer.

@avikganguly01 (cc @awasum )
We have all agreed to a common way of dealing with flaky tests, as discussed on the mailing list and documented here: https://github.com/apache/fineract#pull-requests
It's rather disappointing that a prominent member of the community such as yourself is ignoring the agreed community guidelines, and independently rewriting the rules as you see fit.
If you'd like to propose a different way of dealing with failing tests, perhaps you could propose it on the mailing list and get agreement around the new rules?

@avikganguly01 (cc @awasum @fynmanoj @vidakovic)
Just like last time, I've debugged your "flaky test".
Yet again, there was nothing flaky about this.
The test is broken by PR #1917 that was merged by you earlier.

I have now fixed the issue introduced by PR #1917 and the "flaky" tests (as you called them) are now passing again.


Adding assertion prompts no alert dialog and does not flush into test.

Attempting to add an assertion by highlight some text and pressing Control + Shift + A. I don't receive an alert dialogue confirming the assertion has been generated. Instead, nothing happens, and when I flush in the terminal nothing is recorded.
If someone could suggest how I can debug this. Console in chrome is recording nothing but errors:
sign_in:192 Uncaught TypeError: Cannot read property 'observe' of undefined
at mutationStart (sign_in:192)
at HTMLDocument. (sign_in:338)
I'm attempting to assert the sign in flash error is there as in the demonstration on Twitter, I am using Devise.

@cheesam Hey, sorry you're having trouble, but thanks for writing up an issue! What about regular form field stuff? Was that able to record and flush out?

@cheesam - what browser were you using?
My guess is this PR #22 will resolve the bug.

@cheesam Sorry, didn't mean to automatically close this issue. Can you try:
gem 'magic_test', github: 'bullet-train-co/magic_test', branch: 'main'

Then do bundle install and see whether your issue is resolved? 🙏

Thank you @andrewculver. I've edited the Gemfile with the recommended line and commented out the previous one.
I've run bundle install. Bundle has returned Using magic_test 0.0.6 (was 0.0.4) from https://github.com/bullet-train-co/magic_test.git (at main@1c44e38)
Now when I attempt to run MAGIC_TEST=1 rails test:system test/system/basics_test.rb, the terminal returns NoMethodError: undefined method jquery_already_included=' for MagicTest:Module`.

@cheesam Yes, sorry, broke that in 0.0.5. You need to remove config/initializers/magic_test.rb from your project.

@andrewculver I can now confirm that I'm experiencing the desired behaviour, in addition 'click_on' is now included where it wasn't previously.
Thanks for the assist in getting me up and running and thanks for making such a great gem.

@cheesam So glad it's working for you!
@tleish Thanks for your help with this one!


User can set page querystring higher than total pages

Resulting in the helper rendering as many page links as the page number.
For instance, here I tried entering the page number 100 even though there is only 11 pages in total:

At first sight this might just seem like a minor inconvenience for the user, but you could also enter a really high number like say<PHONE_NUMBER> which would make the backend try to render that many page links, causing the elixir process to hang. Do this enough times and you have an easy way to DDOS the site.

Hmm ok, I'll have to add a test to check for this then

Theres a PR opened to fix this issue now, thanks for reporting!

Released in v.1.6.0, thanks!


Release Timeline for 5.0.0

I was very happy to see that v5.0.0 now supports all platforms. I was wondering if there is a release timeline for when 5.0.0 would move to a stable release.
Reason is that I need it for a package itself and pub is complaining that I'd need to move my own package to a pre release as well. So checking for a rough timeline.

It seems like it is not yet stable on some devices. I am still waiting for someone to provide a fix because i can't reproduce the issues that are described here.

5.0.0 has been released


Move Flux docs to /flux

@stefanprodan had the idea of bringing us (long-term) to a
fluxcd.io / <project> / <version> / <document>
structure.
A first step would be to move to these URL categories:

fluxcd.io/flux
fluxcd.io/flagger
fluxcd.io/legacy

This would mean to move Flux docs under /flux and add redirects.
Thoughts?

+1 on the new approach, it sounds reasonable and easier to structure our docs going forward.


Get authenticated user in Public home page to redirect to private page

Hello, first thanks for the library, easy to use and well documented. I would like to get if user is authenticated in the public home page to redirect them to the private page. Here's how I'm trying to do it:
In App.js:
<Route exact path="/" component={Public} />
Public.js
function Public() {

    const history = useHistory();

    return (
        <AuthenticationContext.Consumer>
            {authContextValue => {
                if(authContextValue.oidcUser == null){
                    return (
                        <h2>
                            Home
                        </h2>
                    );
                }
                else{
                    history.push('<private-home-page>');
                    return (
                        <></>
                    );
                }
            }}
        </AuthenticationContext.Consumer>
    );
}

The problem is I can't access the oidcUser because the component is not wrapped in <OidcSecure />. I would like to know if there's a way to do that, and if there is not, whether it would be safe to access the user using the function getUser() in oidc-client directly.

Hi @ysabih, I think it should work if you use the user hook or HOC.

Thanks, I'll try again.


Fix OpenApi tests due to quarkusio/quarkus/pull/19148

Fix OpenApi tests due to quarkusio/quarkus/pull/19148

@rsvoboda for the failure, please add this line in the ci.yml: https://github.com/quarkus-qe/quarkus-test-suite/blob/e2aa3345dfd6161e861f32509f1167e930a06e2c/.github/workflows/ci.yml#L159
The same happened in this repository and this line had to be added to ignore this error.


Add path filter to CD

The Continuous Delivery (CD) pipeline is triggered every time a push to main branch occurs. Add a file filter that only trigger it when certain files change. Current idea:

config file with versions
template folder
version folders (i.e. 1.1, 1.2, etc)

Maybe add .github/workflows/cd.yml in the future too.


[HOLD] add keenio read key to preprints serializer

Purpose / Changes
Make the Keen.io public analytics read token available through the nodes serializer, so that preprints can display download and view counts for the file.  Document that this is a private attribute and that we can change it without notice.
Side effects
None expected.
Ticket
No ticket.

We'll need to discuss if this is the proper design going forward, attaching analytics keys to models seems impractical as these could end up all over the place...
Do we need a standard endpoint for these? I just don't see how the added attribute enriches the object.

Can we change keenio_read_key to analytics_read_key and update the text to indicate it as an unsupported api attribute.

@binoculars will be working on the write capabilities on the preprints side, some help will be needed to determine how to hand out the public/private scoped keys for each type of object on the API. <- @brianjgeiger

I think the major options are "proxy" or "serialize". We can do some scope restriction or only allow it to happen if you're, for example, using a cookie. But yeah, we can go over options.

Closing, as this is now stale.


Update normalizeSearchTerm Function

Updates the normalizeSearchTerm function in utils.js in line with simple-icons/simple-icons#4833.

Just realised: as this PR only deals with the search and not the file naming, the PR in the main repo isn't blocking it.

Just realised: as this PR only deals with the search and not the file naming, the PR in the main repo isn't blocking it.


Lib coverage is missing in codecov.io

The tarpaulin run appears to gather proper coverage numbers:
'[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/travis/build/nils-ohlmeier/rsdparsa/target/debug/deps/webrtc_sdp-6f99e4cb8ed68118
running 116 tests
.................................................................................................... 100/116
................
test result: ok. 116 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/travis/build/nils-ohlmeier/rsdparsa/target/debug/deps/file_parser-5d6b69a2245a5154
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[INFO tarpaulin] Launching test
[INFO tarpaulin] running /home/travis/build/nils-ohlmeier/rsdparsa/target/debug/deps/unit_tests-b2dc59ad04daa1de
running 10 tests
..........
test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[INFO tarpaulin] Coverage Results:
|| Tested/Total Lines:
|| src/attribute_type.rs: 1460/1662
|| src/bin/file_parser.rs: 0/16
|| src/error.rs: 106/151
|| src/lib.rs: 466/556
|| src/media_type.rs: 293/346
|| src/network.rs: 34/39
|| tests/unit_tests.rs: 245/245
||
86.37% coverage, 2604/3015 lines covered'
But then on codecov.io I only see coverage reported for the file_parser executable and the unit_tests https://codecov.io/gh/nils-ohlmeier/rsdparsa/branch/tarpaulin
The unit test coverage in the source file itself appears to be missing. Is this a feature or a bug?

It would be a bug, but when I go on the codecov link I see coverage for the whole project and for each file in files. I've attached a screenshot of what I see

Yes I fixed it last night by moving the example code from src/bin/file_parser.rs to examples/file_parser.rs. That's why there is now proper coverage showing up.
If you are interested I can drop the links to the previous code and the results on codecov.io here. But since I have a workaround now feel free to close the issue.

I would be interested in having a look just to see if it's a bug or not :+1:

Looks like it is a bug in xml or on codecov side.
I have several projects and the issue appears only after last release.
Example:

last good result with the previous tarpaulin version: https://codecov.io/gh/AnderEnder/s3find-rs/tree/cd3ed5e71604283a238c19ff6260271103c144f9
next run with only dependency changes with new tarpaulin version: https://codecov.io/gh/AnderEnder/s3find-rs/commit/10394cabd9e11b898a73e7c68bc3f37446679475

The most interesting thing is that only files in src are disappeared. Any src/bin/* or next level nested library files are present.

So here is the codecov result from where when I still had 'src/.rs' & 'src/bin/.rs'
https://codecov.io/gh/nils-ohlmeier/rsdparsa/tree/d7d8f53aa43e917bef25175e5a6094f32bdbe1a0
Using tarpaulin's file exclusion resulted in the coverage for 'src/*.rs' showing up here:
https://codecov.io/gh/nils-ohlmeier/rsdparsa/tree/0519f18c8bb7de77f17ba3d59ba4cab78b15d891
And moving /src/bin to /examples also results in coverage for 'src/*.rs' showing up properly:
https://codecov.io/gh/nils-ohlmeier/rsdparsa/tree/42b2a655824520b99ade009f9dc8ea65cd97d19f
You can find my attempts to get useful numbers in codecov in my tarpaulin branch:
https://github.com/nils-ohlmeier/rsdparsa/commits/tarpaulin

cobertura-reports.tar.gz here is a tarball of the two different cobertura XML files.

Thank you @AnderEnder. Super quick turn around time :-)
Is there a way for me to help testing the fix?

The latest build on the develop branch has it in so you can test from there :smile:


Decrease Space Bear Hitbox

About the PR

Space bears previously couldn't fit through one tile gaps. This PR makes them the same size as a Gorilla so that they can fit through airlocks.
Media

https://user-images.githubusercontent.com/44417085/222742268-6a853dfb-6a7b-40da-bb60-cce4aeb1bfd2.mp4

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: crazybrain

tweak: Space bears can now fit through doors

bors r+

bors cancel

bors r+


Fixing dependencies for shared functions

Needed to use a different approach for shared dependencies

Approving to prevent downtime. Bypassing security protection


up and down controls for volume stop working after a ad gets skiped

Script version
3.9
Describe the bug
the up and down keys that control volume, stop working after a ad gets skipped
Expected behavior
to be able to control the volume
Screenshots
not sure how i would screenshot this issue?
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 121.0.6167.185 (Official Build) (64-bit)

Additional context
happened in the 3.8 version of the script too.

to add something to this thread, when i press the buttons is scrolls the page up and down.


Dependency Injection and Field Validation

Privileged issue

[X] I'm @tiangolo or he asked me directly to create an issue here.

Issue Content
code
def get_db():
    db = SessionLocal2()
    try:
        yield db
    except Exception as e:
        logger.exception(e)
        db.rollback()
        raise e
    finally:
        db.close()
class NurseNewSchema(BaseModel):
    family_user_id: str
    time_day: int
    nurse_master: str
    nurse_remarks: str | None
    nurse_title: str

async def post_new_nurse(item: NurseNewSchema, db=Depends(get_db)):
    pass

When nurse_master is not filled in, data verification fails, but the interface executes to get_db, and when yielding db, it reports data verification failure.
2024-11-06 09:58:29.965 | ERROR    | core:get_db:59 - [{'loc': ('body', 'nurse_master'), 'msg': 'field required', 'type': 'value_error.missing'}]
Traceback (most recent call last):
File "/usr/lib/python3.10/threading.py", line 973, in _bootstrap
self._bootstrap_inner()
│    └ <function Thread._bootstrap_inner at 0x7fd6edf39090>
└ <WorkerThread(AnyIO worker thread, started<PHONE_NUMBER>60064)>
File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
│    └ <function WorkerThread.run at 0x7fd6c1500430>
└ <WorkerThread(AnyIO worker thread, started<PHONE_NUMBER>60064)>
File "/home/ouyang/.env/paper/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
│       │   │      └ (<class 'fastapi.exceptions.RequestValidationError'>, RequestValidationError([{'loc': ('body', 'nurse_master'), 'msg': 'field...
│       │   └ <bound method _GeneratorContextManager.exit of <contextlib._GeneratorContextManager object at 0x7fd6c154d930>>
│       └ <method 'run' of '_contextvars.Context' objects>
└ <_contextvars.Context object at 0x7fd6d9e22700>
File "/usr/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
│    │   │     │    │      └ None
│    │   │     │    └ RequestValidationError([{'loc': ('body', 'nurse_master'), 'msg': 'field required', 'type': 'value_error.missing'}])
│    │   │     └ <class 'fastapi.exceptions.RequestValidationError'>
│    │   └ <method 'throw' of 'generator' objects>
│    └ <generator object get_db at 0x7fd6c1537b50>
└ <contextlib._GeneratorContextManager object at 0x7fd6c154d930>

File "/home/ouyang/Desktop/poc/core.py", line 55, in get_db
yield db
└ <sqlalchemy.orm.session.Session object at 0x7fd6c154de10>
fastapi.exceptions.RequestValidationError: [{'loc': ('body', 'nurse_master'), 'msg': 'field required', 'type': 'value_error.missing'}]

The error is happening because FastAPI is trying to yield the db session in get_db() before it handles the validation error. By ensuring that the validation happens before calling the dependency (get_db), the session will only be created if the input is valid. This prevents unnecessary database connections in case of invalid input.
1)Refactor get_db() as a Context Manager: This keeps the session logic clear and prevents unnecessary session creation before validation.
2)Ensure Validation Happens First: FastAPI will validate item (which is the body input) before get_db is even called. So if there’s any validation failure, it will happen before the DB session is created.
3)Error Handling in get_db(): If an exception is raised (such as a validation error), get_db() will log and handle it without impacting the database session.

This prevents unnecessary database connections in case of invalid input.

In production applications it is common to create SQLAlchemy's Engine, and then use it so create sessions. Engine is a connection pool, so it doesn't really create new session each time, but reuses already opened session from the pool.


Click/tap truck to save, instead of a separate "save" button

not really sure how feasible this is since you have to click a marker to drag it. I think the only option would be to save each time a marker is moved, and remove any previous locations from this session.
i would like another dev’s opinion on this, but I don’t think it’s feasible.

We could track the mousedown and mouseup times, and if they're below some hysteresis, assume it was a click rather than a drag.

How about moving the "save" button to an info window that appears on dragend of the marker.

@jjandoc , I like the idea of having the save button near the truck itself. It's way less confusing for the user. Here's an idea that might be the easiest to develop, and the easiest to use:

Once the truck is dragged, the popup changes from "Drag the taco truck, then click Save" to the "Save" button itself.
After the first save, the button disappears until the truck is dragged again, then reappears.
The instructions "Drag the taco truck, then click Save" never appear again.
Remove the option to close the popup.

Thoughts?

Sounds perfect. I can take a crack at this this morning.

Thank you, Jon!

Pull request #48 submitted.


What is the Copy last frame?

Hello,
First of all, thank you for publishing great study.
The question is that What is the “Copy-Last-Frame”?
I don’t know exactly how I can use this approach as a baseline.
Could you tell me about the “Copy-Last-Frame”?

You compare the MSE of the following:
1.) Your t+1 prediction vs. the ground truth of t+1
2.) Ground truth of t+1 vs. ground truth of t
Here, 2.) is your baseline (copy last frame). The assumption is that my simplest prediction is just not changing anything. t+1 will exactly be like t.
So, when your MSE of 1.) is lower than 2.) your model is actually better than your baseline.
@kimna4


Need Source Data on cover crop images

What's wrong

There is text under the carousel of images in the cover crop information sheet that says "Need Source Data". What is that?

that signifies that an image doesn't have an author listed in the api

this was actually displaying on all images in error. i just linked a pr to this issue to resolve it


⚠ Bofrost.lu has degraded performance

In 81d43b5, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1441 ms

Resolved: Bofrost.lu performance has improved in d3bbf53 after 22 minutes.


The PowerShell command under "Deploy the Bicep file" seems not to work fine.

The PowerShell command under "Deploy the Bicep file" seems not to work.
New-AzResourceGroupDeployment -ResourceGroupName myResourceGroup -TemplateFile ./main.bicep -clusterName= -dnsPrefix= -linuxAdminUsername= -sshRSAPublicKey=""
Customer open one case for the error message, "New-AzResourceGroupDeployment: A parameter cannot be found that matches parameter name" when creating AKS cluster with Bicep file.
I can also reproduce the issue in my side as below.

The workaround which I find is to modify the relevant parameter and value inside the bicep file and then run the command, "New-AzResourceGroupDeployment -ResourceGroupName <rg_name> -TemplateFile <bicep_file_name>".
Please help to double check this part in the document. Thank you!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e1fc0ce1-15cd-f452-bf59-8af6ada60a68
Version Independent ID: 7958b15a-8dc7-6a07-b340-560cf487805d
Content: Quickstart - Create an Azure Kubernetes Service (AKS) cluster by using Bicep - Azure Kubernetes Service
Content Source: articles/aks/learn/quick-kubernetes-deploy-bicep.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@SnoWolfT
Thanks for your feedback! We have assigned the issue to author and will provide further updates.

#reassign:schaffererin

Hi, @SnoWolfT! Thank you for your feedback. I just tested the deployment, and you're right - since the Bicep file already defines a cluster name, the deployment creation command doesn't work.
I created and signed off on a PR with updates to the doc. These updates included a callout explaining that if you want to use a different cluster name than the one defined in the file, you must update it before saving the Bicep file, and updating the deployment creation command to remove the cluster name parameter. You can view these changes in the PR, and they will be published in the AKS documentation shortly.
I will now close this issue. Thank you again for your help! 👍
#please-close


How to apply for mws developer ID?

Have you applied for the mws developer ID recently?
After I applied, I waited for 40 days, Amazon told me that I was not qualified, and told me that I needed to learn Acceptable Use Policy and Data Protection Policy.
Can you provide help?
thank you very much!

Sorry, I can't help you with that. Besides, this question isn't really about the library anyway.


Contains fix for proxy issue in non distributed flow

Contains fix for proxy issue in non distributed flow

dup of #11427


Allow a relation with a schema be in multiple containers

This fixes https://github.com/rom-rb/rom-sql/issues/78

@solnic is it fine?


Store alks.db in a ~/.alks folder

Just thinking it might be a bit cleaner to store the alks.db file (and any future config files) under a dedicated hidden folder in the user's home dir instead of the home dir root.

This was something initially considered, but since we use a database we don't see a need of there ever being more than one file. Its also only visible to the owner, any reason why you think it should be in its own directory?

Maybe use something like https://www.npmjs.com/package/appdirectory to store it (and log files, etc.) in the standard application data location per platform...?  (The ALKS Desktop tool uses something similar provided by Electron).

No reason really other than asthetics. Just thought I'd mention it. Makes sense though about there only being one file.


can't connect the mongodb.

install the bot by the docker step by step.but can't connect the mongodb.the error msg is:
{"name":"binance-api","version":"0.0.65","hostname":"ba34d97d72c3","pid":17,"level":30,"NODE_ENV":"production","msg":"API logger loaded","time":"2021-03-30T05:28:12.841Z","v":0}
{"name":"binance-api","version":"0.0.65","hostname":"ba34d97d72c3","pid":17,"helper":"mongo","level":30,"uri":"mongodb://binance-mongo:27017/?poolSize=20&retryWrites=true&writeConcern=majority","msg":"Connecting mongodb","time":"2021-03-30T05:28:13.302Z","v":0}
[ioredis] Unhandled error event: Error: connect ETIMEDOUT
at Socket. (/srv/node_modules/ioredis/built/redis/index.js:308:37)
at Object.onceWrapper (events.js:421:28)
at Socket.emit (events.js:315:20)
at Socket._onTimeout (net.js:483:8)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)

This is not a bug.
And the log said, it cannot connect Redis, not MongoDB.
You need to check what happened to the Redis container.

I will close the issue as I didn't get any feedback from you. Please open new issue if you still have an issue.


Sanitizer in Validator middleware does not work

I tried to make some params always have lowercase, and figure that using the addSanitizer func in the validation pipe would be the most intuitive, except that it doesn't work at all 😅 (tried the trim function, but it also does nothing)
You can check the code below to reproduce it:
Reproduce code:
import { Hono } from<EMAIL_ADDRESS>import { serve } from<EMAIL_ADDRESS>import { validator } from<EMAIL_ADDRESS>
export const lowCase = (s: unknown) => `${s}`.toLowerCase()

const app = new Hono()
app.post(
  '/json',
  validator(v => ({
    trim: v.json('trim').trim().isOptional(),
    low: v.json('low').addSanitizer(lowCase).isOptional(),
  })),
  ctx => ctx.json(ctx.req.valid())
)

await serve(app.fetch)

Sample request (using Httpie)
http POST localhost:8000/json 'trim==    b    ' low==CDF --raw '{
  "trim": "   a   ",
  "low":"ABC"
}'

Expected result
{
  "trim": "a",
  "low": "abc"
}

Actual result 🚫
{
  "trim": "   a   ",
  "low": "ABC"
}

Hi @Toanzzz !
Thank you for creating the issue.
Currently, the result values are not sanitized as you said. Some codes have to implement are lacking. I'll try to write them. Please wait.

Hi @Toanzzz !
This is fixed with #661 by @yujong-lee , we'll release the new version including this fix soon. Thank you!

It's released! I'll close this issue.


allow editing pools in instance details ui

This is a simple ui feature + bugfix. Today there's two issues:

there's no way from the UI to easily create or update pools from the instance details config page
if you are using pools, and you accidentally use the Edit Config modal, you will delete your pools because they get reset to null (this should probably be fixed in the java API)

This just puts the pools field in the instancePutObj var so it's always included in the edit UI.

I tested a few scenarios here:

going from null -> a correctly formatted pool map works

there's no validation that the pool name is one of the tags which I think is necessary, but the current API isn't doing that validation

adding pools works
removing pools works
setting it back to null also works
trying to use a non-map value like a string breaks with a 400 error which is likely good enough for now

Codecov Report

Merging #10153 (70c2e2c) into master (c9ef76f) will decrease coverage by 56.71%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #10153       +/-   ##
=============================================
- Coverage     70.35%   13.65%   -56.71%
+ Complexity     5134      176     -4958
=============================================
  Files          2000     1951       -49
  Lines        108454   106232     -2222
  Branches      16481    16207      -274
=============================================
- Hits          76302    14503    -61799
- Misses        26812    90583    +63771
+ Partials       5340     1146     -4194

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
13.65% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


[Static Page - Design Implementation] FAQ

NOTE: MOBILE DESIGN COMING SOON
Quick summary:
Adding a new static page for helping answer general questions users may have about the app.
Issues:
Users may be confused on how to proceed with the app or just have questions that they want answered.
Get Started:
Get started with our onboarding, https://github.com/waterthetrees/waterthetrees/wiki/Onboarding and read through the epic for relevant details of this ticket. https://github.com/waterthetrees/wtt_front/issues/503
Resources:

Epic discussion https://github.com/waterthetrees/wtt_front/issues/503
Design Figma: https://www.figma.com/file/5C3v1LUNwMPQy9JOgnKEtr/Water-the-Trees?node-id=1355%3A9085

What the final design should look like:

I would like to work on that issue can you please assign it to me ?

@sumitshinde-84 assigning!

When would you like this issue to be completed by?

When would you like this issue to be completed by?

There is no deadline, have fun with the ticket.

@sumitshinde-84 hows progress any updates?

I apologize for the delay. I was occupied with other tasks, but I am now ready to begin working on it. Thank you for your understanding.

I wanted to inform you that I encountered an error while setting up Storybook for our project. It seems to be related to missing dependencies and the Yarn Plug'n'Play manifest. I would appreciate your guidance in resolving this issue. Thank you for your support.

Hi Sumit, did you follow these steps from the README?
npm install
npm run storybook

Can you show me the error message you're seeing? We're not currently using Yarn, and AFAIK there is no plug-n-play manifest .pnp.cjs. It might help with our builds if we moved to yarn though.

[ERROR] Could not resolve "@storybook/addon-controls/manager"
...
[ERROR] Could not resolve "@storybook/addon-toolbars/manager"
...
[ERROR] Could not resolve "@storybook/addon-actions/manager"
...
[ERROR] Could not resolve "@storybook/addon-measure/manager"
...
[ERROR] Could not resolve "@storybook/addon-outline/manager"
...
[ERROR] Could not resolve "@storybook/addon-backgrounds/manager"
...
[ERROR] Could not resolve "@storybook/addon-viewport/manager"
...
[ERROR] Could not resolve "@storybook/global"
...
[ERROR] Could not resolve "@storybook/instrumenter"
...
[ERROR] Could not resolve "polished"
...

I wanted to inform you that I encountered an error while setting up Storybook for our project. It seems to be related to missing dependencies and the Yarn Plug'n'Play manifest. I would appreciate your guidance in resolving this issue. Thank you for your support.

Hi @sumitshinde-84, did you follow these steps from the README?
npm install
npm run storybook

Can you show me the error message you're seeing? We're not currently using Yarn, and AFAIK there is no plug-n-play manifest .pnp.cjs. It might help with our builds if we moved to yarn though.

@sumitshinde-84 I'm not able to repro the issue locally, so I would suggest blowing away your node_modules folder rm -rf node_modules then doing npm install. If you don't have any local changes in your worktree, you can also clear everything out with git clean -fdx.
Are you on the sfbrigade slack? We can also try to arrange a quick call.


Passing errors to the stream

As is tested in my case, this allows handling the errors of initializing the request and errors during data transmission.

@foxB612 thanks for the PR


Demo for NATOPS Dataset

I only find the demo files for MHAD and MUG in the demo folder. Will be the demo of NATOPS publicly available?

Hi, @Michel-liu, thanks for your interest in our work! I am busy with some projects now but I can release the demo of NATOPS at the end of this month. The part of this code is very similar to the demo of MUG and MHAD. So you can also use my released pre-trained model and the NATOPS dataset to run a demo if you need it right now. I will also let you know after I release the demo of NATOPS.

Hi, @Michel-liu, I have released the demo of the NATOPS dataset. I also update the link to the pre-trained DM model of the NATOPS dataset. You may need to download this latest model for the demo. Please feel free to let me know if you have any other questions.

Nice! Thanks! 😄


Style attribute support

I think every Component should support the style attibute in case we want to add inline styles.
i.e Radium

They should already support it, do you have an example of a component which doesn't support it?

Sure.
CheckBox renders a label tag and an input tag.
When I use a style attr in a Checkbox Component the style goes to input. I need access to the parent label tag

Good point, I forgot about that.
It's hard to fix before v2 though. In the end, component should have a custom inputProps instead of applying all props on the input instead of the root element :/


Error for '/auth/azureactivedirectory' (AWS Elastic Beanstalk)

I have my azure ad up and running, my app works fine on my local machine, but once deployed to AWS EB, I am getting the following error for route '/auth/azureactivedirectory'.

A really lowlevel plumbing error occured. Please contact your local Maytag(tm) repair person.

I have checked logs in AWS and getting this one:
Rack app error: #<NameError: uninitialized constant OmniAuth::Strategies::AzureActiveDirectory::Net>
Any ideas what is causing this?

Hey @abezulski , what versions of Ruby are you using locally and on AWS?

Hi @aj-michael, locally I have 2.1.2 with RubyGems 2.2.2
Here is the AWS Elastic Beanstalk breakdown:
64bit Amazon Linux 2015.09 v2.0.6 running Ruby 2.1 (Puma)

Ruby 2.1.7
RubyGems 2.2.5
Puma 2.10.2
nginx 1.8.0

I fixed this issue by adding require 'net/http' to lib/omniauth/strategies/azure_activedirectory.rb

Thanks @flojon, I see that you created pull request but it has not been done yet. Looking forward to get that done, thanks for your input!

I had the exact same problem. Thanks for the fix! This should really be merged... @aj-michael any chance of getting this merged?


Health drain thing

What is your question?
So because I got tired of that engine's source code because nothing happens to psych engine after I edited and saved playstate.hx or other things, can we make health drain with Lua script or no?

#703 <--- A script I made for this, careful, any event will stop that one and you need to add a new Drain event

Yes, the files .lua with the name of stage (mods/stage) for example, school.lua
Type this:
function onBeatHit()
--for every beat
health = getProperty('health')
if getProperty('health') > 0.2 then
setProperty('health', health- 0.03);
end
end
the last number is the speed health
https://github.com/ShadowMario/FNF-PsychEngine/wiki/Lua-Script-API

If you want a passive health drain then the answer above is what you are looking for. If you want it to happen on opponent's note hit, then:
function opponentNoteHit(id, direction, noteType, isSustainNote)
	setProperty('health', getProperty('health')-0.01)
end

If you want it to not be able to kill the player, then:
function opponentNoteHit(id, direction, noteType, isSustainNote)
	if health > 0.01 then
	  setProperty('health', getProperty('health')-0.01)
       end
end

Furthermore, if you want it to only happen on your special note, but not kill the player, then:
function opponentNoteHit(id, direction, noteType, isSustainNote)
	if health > 0.01 and noteType == 'special_note' then
	  setProperty('health', getProperty('health')-0.2)
       end
end

The maximum health is 2 (100%), and you start with 1 (50%) by default.

function opponentNoteHit(id, direction, noteType, isSustainNote)
if getProperty('health') < 0.025 then -- basically the damage number but + .02
setProperty('health', getProperty('health') + 0.023) -- MAKE SURE ITS THE SAME NUMBER AS THE DAMAGE NUMBER
end -- this makes it so it does not kill bf, delete the if then statement to make it kill bf.
setProperty('health', getProperty('health') - 0.023); -- enemy drains health, simple
end
Enemy drain made by me :D

health = getProperty('health')
if getProperty('health') > 0.1 then
	if string.match(getProperty('dad.animation.curAnim.name'), "sing") then
		setProperty('health', getProperty(health - 0.001))
	end
end

end
much more simple checks if the opnt is singing and health is bigger than 0.1 then reduces health
@ShadowMario  close this issue it has already gotten multiple answers

Yes, the files .lua with the name of stage (mods/stage) for example, school.lua
Type this:
function onBeatHit() --for every beat health = getProperty('health') if getProperty('health') > 0.2 then setProperty('health', health- 0.03); end
end
the last number is the speed health
https://github.com/ShadowMario/FNF-PsychEngine/wiki/Lua-Script-API

what about every other beat


Members in role command needed

?roles to show how many people are in each role. Would be good to be able to specify roles too e.g. by first letters.

what roles a user has is part of the ?userinfo command, we can do a for or something to get a list of users with that role


Remove current directory from sys.path in python invocations

Fixes #8400.
Uses this solution for python -c invocations, and the -I option (added in Python 3.4) for module loading.

This solution can be phased out in the near future in favor of -I, once Python 2 is dead and we can be sure people are using a version older or equal to 3.4 (which was released 5 years ago).

Another, potentially more robust solution (that doesn't require quotes!):
import sys; sys.path = list(filter(None, sys.path))

This will remove all falsy values (including the empty string), so it is more robust than sys.path.remove("") (which will only remove the first occurence).

The Python docs say the current directory / empty string will be added at the start of sys.path:

If this option is given, the first element of sys.argv will be "-c" and the current directory will be added to the start of sys.path (allowing modules in that directory to be imported as top level modules).

If this option is given, the first element of sys.argv will be the full path to the module file (while the module file is being located, the first element will be set to "-m"). As with the -c option, the current directory will be added to the start of sys.path.

If this option is given, the first element of sys.argv will be "-" and the current directory will be added to the start of sys.path.

If the script name refers directly to a Python file, the directory containing that file is added to the start of sys.path,

I understand that, however users may have different environment setups that cause paths to prepended to sys.path after the empty path is prepended. I think we should err on the side of caution when it comes to potential security issues.

From what I've read in the docs re: environment variables, the "current directory"/"script directory" will always be put first in sys.path. See for example PYTHONPATH:

An additional directory will be inserted in the search path in front of PYTHONPATH as described above under Interface options.

I'm comfortable enough with my assessment here. I do not like the solution, but as I said before, this is only temporary until we can get rid of Python 2 and use -I which will be secure by default.

Python has had numerous regressions in the past, so I am incredibly wary about relying on close reading of the documentation. I also wouldn't rely on specifics about the user's environment (especially when working on a framework intended for users who heavily customize their environment!).
But I don't use Oh My Zsh, so I'm not going to argue this any further ¯_(ツ)_/¯


Dev

I'm sure this will require quite a bit of discussion before it may or may not be added to the library. The animation plugin (would be) requires quite a bit of work as it currently contains copies of some of the functions from impress.js. This is because I wanted to keep the animation framework separate from the impress.js file. I was hoping to find time to refactor it into something that could be passed into the impress.js init as an option of sorts. This is my first time making a pull request on github so I hope I'm going about this correctly. The substep changes could probably benefit from some codereuse reduction. It may seem slightly chaotic as I got stuck at a certain point and seeing as how I also wanted to finish the presentation. Hope I can clean this up and if you're interested I'd gladly contribute my work to the benefit of the impress.js project.

Hi @wojtossfm, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.
To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older PRs like this one to see if the OP is still interested in keep it going.

Hi. I'm not really tacking it actively seeing as how there wasn't much of a response originally. I would need to check how compatible the changes are with the current code base (not sure how much has changed in the meantime). If the proposed changes sound like something you would be interesting in adding to the project then let me know how I can help make integrating the changes into the codebase go smoother.

@wojtossfm Thanks for the feedback, we will revisit this later thanks.

As stated in the contributing guidelines it is required that a PR is creating using a "topic branch". Basically it means that a PR should do one thing and one thing only.
In the current state of this PR there are a lot of code changes that will make it harder to review, so I can't say if this s useful or not.
@wojtossfm is it possible that you create a PR splitting each specific change so that we can look each small feature separately? This is not a confirmation that it will be landed, it is just that we need to have a better view of what is being proposed in order to consider this. If you believe it is not possible, then there is no problem, we can close this and you can open a PR later when we have a better plugin structure to be build on top of.

Quoting guidelines that were instated long after my PR is a bit...
surprising.
At the moment I probably won't find time to split it into smaller
chunks. I can try splitting it in the future although I'm not sure if
I'll be able to split it into more than 2 chunks - one adding the idea
of substeps to the original code and a second one being the
transition/animation extension that utilizes both steps and substeps. At
the moment then you'll probably want to reject the PR and possibly when
I'll be able I can try to submit it in separate chunks.
Kinds regards,
Wojciech Michalak
W dniu 2016-03-05 o 05:14, Fagner Brack pisze:

As stated in the contributing guidelines
https://github.com/impress/impress.js/blob/8159876c980d409a85f538ea27d524a5f899328a/CONTRIBUTING.md
it is required that a PR is creating using a "topic branch". Basically
it means that a PR should do one thing and one thing only.
In the current state of this PR there are a lot of code changes that
will make it harder to review, so I can't say if this s useful or not.
@wojtossfm https://github.com/wojtossfm is it possible that you
create a PR splitting each specific change so that we can look each
small feature separately? This is not a confirmation that it will be
landed, it is just that we need to have a better view of what is being
proposed in order to consider this. If you believe it is not possible,
then there is no problem, we can close this and you can open a PR
later when we have a better plugin structure to be build on top of.
—
Reply to this email directly or view it on GitHub
https://github.com/impress/impress.js/pull/305#issuecomment-192566204.

Quoting guidelines that were instated long after my PR is a bit... surprising.

Why is that suprising? It is just justifying the need for topic branches, which was not documented clearly earlier.

At the moment then you'll probably want to reject the PR and possibly when I'll be able I can try to submit it in separate chunks.

@wojtossfm Thanks for the response! We will be closing this for now then but feel free to submit in the future when we hope to have a better structure to build on top of :+1: