Problems while installing the package

I am trying to install react-table with npm but getting this error .
Unexpected end of JSON input while parsing near '...t":"^15.4.2","react-d

Looks like a local environment issue

@filangi could you say what the problem was? Running into a similar error.

Awesome thanks


test: add cypress testing for pages

Resolves #[Issue number]
🔧 What changed
This PR focuses on improving code quality by implementing testing for pages. Focus was put on testing pages rather than individual components, to cover how the layout appears when everything is rendered together.
🧪 Testing instructions

Check that CI is passing
Start the frontend server with yarn dev and run Cypress locally with yarn cypress open
Confirm that everything in the preview still works

@SocketSecurity ignore-all


V1 and V2 Protocols

Can you please update the readme to include that the V1 Protocol is used with the Unreal plugin. Thanks

Done !
I did update it here : https://github.com/Theoriz/AugmentaUnreal


Rails g rails_admin:install wont do anything and just freezes?

I have added the gem to my application however when I run rails g rails_admin:install nothing happens the command just hangs or freezes. Anyone know how to fix this?

Actually just fixed the issue - it had something to do with spring not sure what or why but running spring stop then rails g rails_admin:install seemed to work


Smart Touch Switch 8 Gang

Hi.
I have this module
https://www.aliexpress.com/item/4000297406413.html?spm=a2g0o.order_list.order_list_main.83.29a91802dNow78

Here a Full Dump
readResult_BK7231N_QIO_2024-28-1-18-44-34.zip
Thanks for all the help...

Added as Tuya Generic 8 Button Touch Switch.  There is no device configuration as this is a TuyaMCU device.

I was able to make all buttons work with the following autoexec.bat
`startDriver TuyaMCU
tuyaMcu_defWiFiState 4
setChannelType 1 toggle
linkTuyaMCUOutputToChannel 1 1 1
setChannelType 2 toggle
linkTuyaMCUOutputToChannel 2 1 2
setChannelType 3 toggle
linkTuyaMCUOutputToChannel 3 1 3
setChannelType 4 toggle
linkTuyaMCUOutputToChannel 4 1 4
setChannelType 5 toggle
linkTuyaMCUOutputToChannel 5 1 5
setChannelType 6 toggle
linkTuyaMCUOutputToChannel 6 1 6
setChannelType 7 toggle
linkTuyaMCUOutputToChannel 102 1 7
setChannelType 8 toggle
linkTuyaMCUOutputToChannel 101 1 8
`


Updated the documentation, did favourite.html, rating functions and filtering functions

please check all new changes and we will discuss further details.

Resolved all the conflicts, good job Majd


When logged out, the ASL-signbank search button leads to an error page

Ha, I think this was already solved as part of #222


Enable CI testing with multiple clusters using kind

This adds support for running CI with multiple clusters using the new tool kind(kubernetes in docker). You can also run the pre-commit.sh script locally as well. The number of clusters is 2 by default, but you can override this if you'd like to test with a different number.
There are a few kind workarounds that are implemented in this PR until these issues are resolved:
https://github.com/kubernetes-sigs/kind/issues/110
https://github.com/kubernetes-sigs/kind/issues/111
https://github.com/kubernetes-sigs/kind/issues/112
https://github.com/kubernetes-sigs/kind/issues/113
Also, adding a versioned release for kind is still WIP (PR is at https://github.com/kubernetes-sigs/kind/pull/81). For now we have to rely on a git sha.
Lastly, this adds ~3 minutes to the CI job run time. There is perhaps some savings by not having to launch a minikube cluster anymore, albeit with some kind workarounds for the time being, but this adds a crucial extra cluster to each test.
Next will be to add docs for a dev workflow.

Awesome sauce, multiple clusters at last!!
I figure it's worth restarting the job a few times to confirm that it's stable.  The code LGTM, and in any case it looks likely that the added code will evolve as features and bugs are resolved in the kind repo.

This LGTM. Excited to merge this soon. Also look forward to stable release of kind. I did give a try by locally running the CI script pre-commit.sh and had an issue with image push to local registry
Successfully built ce06ba4d9eee
Successfully tagged <IP_ADDRESS>:5000/federation-v2:e2e
The push refers to repository [<IP_ADDRESS>:5000/federation-v2]
Get http://<IP_ADDRESS>:5000/v2/: dial tcp <IP_ADDRESS>:5000: getsockopt: connection refused

None the less, CI seems to be successful all the time. So will figure out the issue in my dev env
Thanks @font!

Successfully built ce06ba4d9eee
Successfully tagged <IP_ADDRESS>:5000/federation-v2:e2e
The push refers to repository [<IP_ADDRESS>:5000/federation-v2]
Get http://<IP_ADDRESS>:5000/v2/: dial tcp <IP_ADDRESS>:5000: getsockopt: connection refused

None the less, CI seems to be successful all the time. So will figure out the issue in my dev env

@shashidharatd I believe you're hitting that because the docker daemon on your host needs to be configured with the insecure registry. To do that, have you tried setting CONFIGURE_INSECURE_REGISTRY=y before launching the script locally? That's how the script is run in travis. Basically, assuming that's the IP address of your docker bridge interface docker0, the docker daemon will be configured with that insecure registry in /etc/docker/daemon.json. Then the script reloads dockerd by sending it the SIGHUP signal. This should only ever need to be done once and afterwards you no longer need to CONFIGURE_INSECURE_REGISTRY. I am adding some docs around this workflow that should also help.

@font, there could be some corner cases while running in dev environment, which we could eventually fix. Like couple of them i faced.

docker daemon was down after reboot. the reason is we are specifying insecure registry through flags as well as file:

Nov 20 15:40:08 shashi-laptop dockerd[932]: unable to configure the Docker daemon with file /etc/docker/daemon.json: the following directives are specified both as a flag and in the configuration file: insecure-registries: (from flag: [<IP_ADDRESS>:5000], from file: [<IP_ADDRESS>:5000])
Nov 20 15:40:08 shashi-laptop systemd[1]: docker.service: Main process exited, code=exited, status=1/FAILURE
Nov 20 15:40:08 shashi-laptop systemd[1]: docker.service: Failed with result 'exit-code'.
Nov 20 15:40:59 shashi-laptop dockerd[2719]: unable to configure the Docker daemon with file /etc/docker/daemon.json: the following directives are specified both as a flag and in the configuration file: insecure-registries: (from flag: [<IP_ADDRESS>:5000], from file: [<IP_ADDRESS>:5000])

Failed to delete the 2nd kind cluster although deleting the first cluster was fine. Maybe there is a bug in kind.

CI environment is good and so lets merge this and deal with dev environment issues and documentation in subsequent pr's.
/lgtm
Thanks @font !

Very cool!
Apologies for the issues in kind, I've been reading back through @font's issues filed there and looking into options for resolving them.
I'm also aiming to eventually get to a place where we have proper releases and strictly require compatibility with future changes, but we're definitely not there yet. There will probably be a few more sweeping changes to enable multi-node support and improve logging in particular.

@BenTheElder Not a problem. Thanks for all the great work to create kind! Looking forward to the future updates.
We are currently versioning using a specific git sha, so hopefully that should allow us to keep using kind even as future compatibility changes are made.

Very happy to hear that, especially pinning a specific sha, discussing getting a release out the door as well with @munnerz :+1:


Refactor to stop using deprecated request module

A very-compatible option is to use teeny-request, which is a sub-set of the request API. We would still declare it a breaking change, but it would be less of a breaking change than a complete refactor to use the Fetch API directly.

Closed with #161


consider more fancy CLI output

yargonaut looks cool, and it might be nice to use its color capabilities.

(I wouldn't want to use the silly ASCII fonts)
@mochajs/core anyone opposed to more fancy output?  @plroebuck?

closing due to inactivity.


Add glTF buggy with Draco mesh compression to validation tests

Please don't merge until I confirm the validation tests are working properly on the build machines.

Ready to merge. tests-whatsnew failed but that's expected.

Thanks


Move vscode from dependencies to devDependencies

Move vscode out of dependencies

out can also add the entire out folder to the vscodeignore and also add the out folder to the vscode ignore of the big-data-cluster extension

@aaomidi , Don't you need to make changes to the extensions.ts to verify ?

@alanrenmsft I do, but this is something that has to be done anyway.

@aaomidi PR build passed, good to go

I'll schedule an insiders build.


pt.I: InactivateSponsorship service object

Do not merge!
Part I of IV - replace model callbacks handling sponsorship events with service objects.
The main point of concern for me in undertaking this was the fact that the Sponsorship model had been made responsible for ensuring that pertinent Sponsor & Orphan objects were updated synchronously whenever the sponsorship changed (was created, destroyed or inactivated). Secondarily, though still importantly, both Sponsor & Orphan had become loaded with many methods that went well beyond the core responsibilities of an AR model, namely persistence, validations & associations.
Here, a InactivateSponsorship PORO class is created to handle sponsorship inactivation and attendant changes to the associated sponsor & orphan records. The sponsorships controller (AA) is modified to use this service object instead of calling sponsorship, sponsor & orphan instance methods.
Most of this code will change in parts 2-4, so focus on the approach rather than the implementation.

:+1:

Part IV merged


Minor adjustment

[x] remove duplicate private
[x] adjust indentation to increase readability

Details
Compare to v0.3.0,

call private twice in line 75 and line 125, so removed second private.
line 84  and range #L86-L109 easy to make people confusion, inside if ... end  using indention better, so I adjust it.

@NickWarm the builds didn't kick in, I guess maybe you're not in GitHub action's beta program? If you aren't, would you mind joining the program? https://github.com/features/actions

@st0012 thank for your reminder, I had join Github Action, and ci rerun on my forked repo

but this PR's actions didn't rerun, could you give me some advice, thx

@NickWarm I've updated the workflow setting on master. Can you rebase and push again?

@st0012  it work, much thx


Variable modifiers join & transform-

Looking at the possible modifiers for variables the following two seem a bit specific:

transform-
join

The first looks to be a very specific/strange use-case can you elaborate on its use @ttveldhuis ?
The second is a way to join array values with a comma.
It is not only a join but also provides a way to provide a selector of a sub-object with the join-field argument (correct me if I'm wrong here).
Maybe this should be simplified so you can join an array of strings string with a delimiter/glue. If sub selection is needed probably asking the user to write a specific function would be a better option.
What are your ideas on this @ttveldhuis ?

Join
There are two ways in which the join argument can be used, with or without the join-field argument;
// array is ["A", "B", "C", "D", "E"]
[array join=","] and [array join="-"]

// array is [{ "id": 1, value: "A" }, { "id": 2, value: "B" }, { "id": 3, value: "C" }]
[array join="," join-field="id"] and [array join="-" join-field="value"]

renders to
A,B,C,D,E and A-B-C-D-E

1,2,3 and A-B-C

This can probably be improved, have any suggestions?
Transform-
This is a bit of an obscure argument created out of need in an earlier concept-version of Xentriq, which can now probably replaced by using the language functionalities.
// enum is STATUS_NONE
[enum] and [enum transform-STATUS_NONE="There is no status."]

renders to
STATUS_NONE and There is no status.

Basically when the value to be rendered matches the value after transform- it renders the arguments value instead. Because the language functionality supports tags I think it might be best to remove the transform- functionality.

I think the transform- is indeed a bit obscure. I would suggest removing this.
Regarding the join I'm inclined to suggest removing the join-field option.
Using join with join-field basically gives the user a very limited array_map functionality.
This looks to me like something that if you want to do should be done in an addon method as it probably means the data needs to be prepared a bit more before it goes to the template.

Adressed by latest changes


fix typo in docstring

Coverage remained the same at 99.744% when pulling a010eda0e7dc1fb1930c20e535b2b83578cf39be on alexsavio:patch-1 into 475a977e4790283502a0a52286f419f2f601b15f on timothycrosley:develop.

Thanks!


Use theme provided by theme.js file and not css.

In the [theme.js] every used color should be written. (Primary, Seccondary, warning, success, error, ...)
These colors should be used throughout the UI and imported from the Theme instead of setting them in the css files.
For example in the check.css
success {
    color: #008643;
}

The theme of the color should be used instead.
How To:

import the Theme to the check.js file
import { useTheme } from '@material-ui/core/styles';
use the Theme

function Status(status) {
    const theme = useTheme();
    switch (status.status) {
        case 'success':
            return Success

belongs to #191

See also first changes in #199

See also first changes in #199

It's enough for now that for our OJS use case that the use can set the important theme values manually.


Complete bipartite graph

This PR adds a Complete bipartite graph.

I really appreciate the outneighbor vector, I guess we will move it to LG at some point

I think travis crashed for some reason, but otherwise this could be merged

indeed sorry, don't know what's going on


[base-ui][material-ui] Uncontrolled Switch component do not fully reset when inside a  with a reset button

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example without using state: https://codesandbox.io/p/sandbox/eager-rgb-m43d9q
Link to live example using state: https://codesandbox.io/p/sandbox/focused-hellman-z83g9c
Current behavior 😯
When using Switch component, Pressing the reset button in a form does not revert value of the Switch to its default value.
If I use Switch with state then it will work properly.
Expected behavior 🤔
Changes in the value of the Switch will get reset while clicking on the reset button when we are not using the state (for the first codesandbox).
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 20.9.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Chromium (120.0.2210.77)
  npmPackages:
    @emotion/react: ^11.11.1 => 11.11.1
    @emotion/styled: ^11.11.0 => 11.11.0
    @mui/base:  5.0.0-beta.28
    @mui/core-downloads-tracker:  5.15.1
    @mui/material: ^5.15.1 => 5.15.1
    @mui/private-theming:  5.15.1
    @mui/styled-engine:  5.15.1
    @mui/system:  5.15.1
    @mui/types:  7.2.11
    @mui/utils:  5.15.1
    @types/react: ^18.2.45 => 18.2.45
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^4.9.5 => 4.9.5

Hi guys can I Work on this one ?

This should be supported in Base UI, getting it in Material UI after refactoring to use Base UI's Switch.


Not working in angular 18.

Hi,
When i am trying to install this package in Angular 18 which gives peer dependency error:
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>
Could you please update and support for Angular 18?

Thanks for the note, I have updated it. Please verify that it works correctly for your case.
https://github.com/AngelCareaga/ngx-custom-modal/releases/tag/18.0.2

Thanks for quick update. its working fine now.


GeoServer authentication often fails when the stack is first spun up

The initialisation code doesn't wait for GeoServer to have finished starting up before it tries to modify the default password or enable proxy support.

Fix merged in MR #279.


Questions about different root passwords in the cluster.

In the doc of tidb-ansible.
Step 5. After configuring the host.ini, execute ansible-playbook -i hosts.ini create_users.yml -u root -k to create users for each host.
But here must be the same root password for each host.
If the root passwords are different, what should i do?
Can this only be the case (Manually configure ssh mutual trust and sudo password-free)

You can edit host.ini as the following format:
[servers]
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='123456'
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='234567'
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='123435'
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='346546'
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='436547'
<IP_ADDRESS> ansible_ssh_user=root ansible_ssh_pass='436547'

[all:vars]
username = tidb
ntp_server = pool.ntp.org

Then run ansible-playbook -i hosts.ini create_users.yml -u root to create tidb user.

Thank you.


Icon packs are not fingerprinted

When doing a production build, most of our base assets are fingerprinted, which helps with cache issues when we update the app. However, icon packs are not among those resources which receive fingerprints.
The current implementation of frost-icon would not work if the icon packs received fingerprints either: https://github.com/ciena-frost/ember-frost-core/blob/81e9629a75d5b75ca090fcd454309e39f7c6f87d/addon/templates/components/frost-icon.hbs#L2
It would be great if we had some mechanism for identifying the version of the icon-pack .svg files so that browsers always had the proper version w/o users needing to clear their cache.

I'm re-opening this because I believe it's still an issue with #432 having reverted the change delivered in #427 that closed this.

@sglanzer Just wondering if there's any update on the second try at implementing this?

@job13er was #429 reverted?  If so we can look at another pass at this, but it'll be in the second half of June

It looks like it: https://github.com/ciena-frost/ember-frost-core/blob/master/addon/templates/components/frost-icon.hbs

JIRA: https://agile-jira.ciena.com/browse/FROST-1379


 Needs to be done before #8684.

SpecFlow test execution is broken at the moment since this commit: 0c34ca3dd51fbdd11122446daaf79aa89286ec1e (that fixes #8445 with PR #8446).
I managed fix some startup errors by adding assembly binding redirects (see aa710394167cd4813f58f776f486ece2af9563c9), but now it throws the following error:

None of the constructors found with 'Autofac.Core.Activators.Reflection.DefaultConstructorFinder' on type 'Orchard.Environment.DefaultOrchardShell' can be invoked with the available services and parameters:Cannot resolve parameter 'Orchard.IWorkContextAccessor workContextAccessor' of constructor 'Void .ctor(Orchard.IWorkContextAccessor, System.Collections.Generic.IEnumerable1[Orchard.Mvc.Routes.IRouteProvider], System.Collections.Generic.IEnumerable1[Orchard.WebApi.Routes.IHttpRouteProvider], Orchard.Mvc.Routes.IRoutePublisher, System.Collections.Generic.IEnumerable1[Orchard.Mvc.ModelBinders.IModelBinderProvider], Orchard.Mvc.ModelBinders.IModelBinderPublisher, Orchard.Tasks.ISweepGenerator, System.Collections.Generic.IEnumerable1[Orchard.Owin.IOwinMiddlewareProvider], Orchard.Environment.Configuration.ShellSettings)'.

#5490 and #7785 are about the same error, but in a different situation. The suggested fix was related to file access permissions, which is not the problem here (I tested the compiled Spec test app from IIS). Any suggestions?

Looks like IWorkContextAccessor is inaccessible. Did you try injecting Lazy?

Yeah, I got as far, and my guess would be that the HttpContext is the underlying problem. I tried wrapping it in Lazy, but that doesn't help (because work context is used during shell activation, so very early on).

Working on this and #8683 in parallel to validate results in GHA - so far unit tests are all fixed where necessary and each one is passing. Continuing with the SpecFlow test execution mentioned above.

I've made good progress over the past few days and the build (including static Razor compilation) is completely warning-free + managed to fix all the failing tests (due to breaking changes in the code in recent years) except for one: Orchard.Specs.DateTimeFieldFeature.CreatingAndUsingDateTimeFieldsInAnotherCulture.
The problem arises when adding a new culture and selecting it as the site culture through the DefineDefaultCulture binding, because cache invalidation through the signal in DefaultCultureManager doesn't seem to take effect. Signal usage was added to DefaultCultureManager in 2010 (!) and then caching was added in 2014, so I'm pretty sure the tests were all green back then (the test itself was created in its current form in 2012). This is only true for running SpecFlow tests - running the "normal" Precompiled application or even the application running the SpecFlow tests from IIS and IIS Express both works fine. If I add an extra step to the SpecFlow test to enable a feature (which restarts the shell and resets the cache) the problem is gone.
Any ideas why signals/caching could be different when running the application through NUnit? CC @sebastienros

No idea

I've updated the issue description with the action plan to get 1.10.x and dev back into shape and the first step is to review and merge #8687.
@sebastienros I'd like to ask you to review this PR carefully + I'd appreciate input from the Laser team (tagging @HermesSbicego-Laser, but please pass it on in the team) due to working on improving Orchard 1 so much recently + everyone else, of course.
I've added a dozen or so comments to my PR with some additional context.

If running Orchard.Framework.Tests in VS, it still gets 27 Failed
...
Mocking Orchard.Tasks.IBackgroundService
NUnit VS Adapter <IP_ADDRESS> executing tests is finished
========== Test run finished: 791 Tests (759 Passed, 27 Failed, 5 Skipped) run in 7.2 min ==========

@lbcsy on which branch? 1.10.x should be all green now, dev isn't yet (but issue/8686-dev should be all green, which will be merged into dev).

I tried dev as I thought you were referring to dev in your step 3. Good to know dev will be fixed soon.

@sebastienros after our discussion yesterday, I merged in #8685, then I made some further updates to #8686 and squash-merged that, so to sum up this journey:

Builds (with Razor compilation and warnings treated as errors), unit tests and SpecFlow tests all pass on 1.10.x and dev.
Compile workflow runs on PRs and commits on 1.10.x and dev: runs the build and unit tests.
SpecFlow test workflow runs every day at midnight and also executes the SpecFlow test on top of what Compile does (so it's the same as the nightly builds in TeamCity).
Deleted the TeamCity project.

Yeah, I've got the same locally - I couldn't find a fix so far, but it's almost certainly down to culture / date formatting settings, so I just deferred to the GitHub Actions execution, which is successful.

When DateTime.Parse is used, specify Culture.Invariant if you assume it's the ISO format


charts version upgrade of stable/nginx-ingress

change stable/nginx-ingress to version 1.3.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: markhuyong
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rawlingsj
If they are not already assigned, you can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @markhuyong. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks! The version is already added.


Android Hardware back button does not work after modal and only if "focusFirstInput: true"

Title said it all :)
After showing a popup, the input is focused and things are fine.
But when I close, the popup ( whatever the way : button or hardware button ), go to another page I cannot use the hardware button ( back button in header works fine ) to go back.
Meanwhile, adblogcat is reporting this while pressing the hardware button so something is happenning ( this is the same log that when i do no use 'focusFirstInput', except that it does go back):

D/CordovaWebView( 9377): The current URL is: http://<IP_ADDRESS>:8100/#/app/search
D/CordovaWebView( 9377): The URL at item 0 is: http://<IP_ADDRESS>:8100/#/app/search

I'm also using crosswalk, if that's any help.
Thanks

Am i the only one seeing This?

More on this : only happens if you open the modal with an ng-focus on a text input. Does work with ng-click on a button.

I also faced the same problem , when closing the ionic modal i can not user the hardware back button.

Greetings @apavillet!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Change link css

The website's links are not clearly visible.   The link's colour change when hovered is not clear.

So,

Make links bold when hover
Make links underline, when not hover

Currently, I don't find much problem with that and the underline is not suitable to the links. It makes the website not attractive. If you wish you can bold the things


Can I override making new line with "ctrl+Enter" key?

Informations
Browser version: Chrome 60.0
OS: Windows10
Screen resolution:
How to reproduce the bug?
Actually not a bug, but I want to override the key   which takes the user to next line. I want this functionality with "Ctrl+Enter" key. SO could you please help me?

You can't without fork and modifying source code since Trumbowyg listen some things on the enter key.

I'm not sure how valid my solution is for this issue, but I've managed to add such functionality: https://stackoverflow.com/a/49920323/1004946


feat: update to 1.21.4

Hi @sarunint thanks for your contribution, actually the game still crash due to cloth-config dependency (version: 17.0.142)

Neoforge ✅
Fabric ✅
Quilt ❌
Forge ❌

We will wait compatibility of cloth config to apply the patch ! :)

ClothConfig support 1.21.4 integrally now, I will add the support soon


Python: disable dependency installation on GHES

After succesfully rolling out this change to all customers on github.com (see https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/), this PR will ensure it is also disabled for new GHES releases.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

Looks good, just a small suggestion for the changelog note for consistency.

thanks :heart:


NSTimeZone.SystemTimeZoneTests fails on OSX

[ RUN      ] NSTimeZone.SystemTimeZoneTests
NSTimeZoneTests.m:55: Failure
Value of: [systemTZ name]
Actual: US/Pacific
Expected: [expectedTZ name]
Which is: America/Los_Angeles
[  FAILED  ] NSTimeZone.SystemTimeZoneTests (4 ms)

Seems to be caused by my reference machine not having a timezone... Closing.


Fix instructions to start minikube with RBAC

Minikube version:  v0.30.0
When starting minikube with --extra-config=apiserver.Authorization.Mode=RBAC, the apiserver
container exits with the following error:
error: unknown flag: --Authorization.Mode

Starting it with --extra-config=apiserver.authorization-mode=RBAC
instead fixes the issue.

/lgtm
/approve


Extra stuff in type 5 shading (Gouraud mesh)

tested with
http://<IP_ADDRESS>:8877/2d43c75f950d82e/web/viewer.html
The file
https://issues.apache.org/jira/secure/attachment/12658599/LATTICE1.pdf
has some "extra stuff" at the bottom left, near the number 1.

Closing as fixed by PR #7184.


Misinterpreting italicsnormalitalics

Library seems to have problem with correct interpretation of strings like this *italics*normal*italics*.

Is it a bug, or a feature? Can I somehow alter how library deals with that?

The behavior for this scenario is a bit ambiguous since it appears to be all one word, I made the decision to parse the outermost syntax first. Therefore for *italics*normal*italics* the whole string would be italic. If you put a space before "normal" then it will break the italics, e.g. *italics* normal *italics*

I am aware of that, but most libraries that I have tested - Github included, deal with it in a way I have described. I can offer help in making a change, if time is a factor here.


add credit card recurring in client & example

Problem:
We create new endpoint for recurring payment, so we need to add it in php clients
Solution:
Add client and example for subscribing recurring payment and capture subsequent recurring payment

You need to also update the docs in .md file @afik

LGTM


Incorrect linestring clipping: missing geometries

A testcase came in that shows that, in some rare cases, the line clipping inside vtcomposite will discard geometries incorrectly that are within the clipping bbox.

Added a testcase in 466d654. To replicate do:
git checkout linestring-clipping-bug
make
make test

Until this bug is fixed you should see:
ok 9 should be falsy
not ok 10 should be equal
  ---
    operator: equal
    expected: 5
    actual:   4
    at: composite (/Users/danespringmeyer/projects/vtcomposite/test/vtcomposite-linestrings.test.js:89:12)
    stack: |-
      Error: should be equal
          at Test.assert [as _assert] (/Users/danespringmeyer/projects/vtcomposite/node_modules/tape/lib/test.js:225:54)
          at Test.bound [as _assert] (/Users/danespringmeyer/projects/vtcomposite/node_modules/tape/lib/test.js:77:32)
          at Test.equal.Test.equals.Test.isEqual.Test.is.Test.strictEqual.Test.strictEquals (/Users/danespringmeyer/projects/vtcomposite/node_modules/tape/lib/test.js:388:10)
          at Test.bound [as equal] (/Users/danespringmeyer/projects/vtcomposite/node_modules/tape/lib/test.js:77:32)
          at composite (/Users/danespringmeyer/projects/vtcomposite/test/vtcomposite-linestrings.test.js:89:12)
  ...

What I think is happening is that a multilinestring is disappearing during the call to boost::geometry::intersection(multi_line, bbox_, result); at: https://github.com/mapbox/vtcomposite/blob/baf3b420a6e3f4c8dab9f329dfa6caab9205c234/src/feature_builder.hpp#L191
Very curiously the multipolygon does not disappear if the buffer_size in the test is set to 4079 or 4081.
/cc @artemp

I have a handful other test cases I can provide if needed, but I suspect they are all the same root cause.
When I first ran into the problem, I tried to replicate using vtcomposite but I couldn't replicate, but I used buffer_size: 0, which could have been the reason, if it only happens for some buffer_size values.

@andrewharvey - could you verify df0f462fb1f3bb44106882f6da7b141ab0434545 fixes this issue

@andrewharvey - could you verify df0f462 fixes this issue

Yes, thank you! I tested two different places, and it fixed it in both cases, when buffer was set to 4080, which I assume is what's in use in the Mapbox API.

@andrewharvey appreciate your patience with this issue! The fix will go out in 0.2.1, and should go live into Mapbox's vector tile endpoints sometime tomorrow.

@andrewharvey 👋 vtcomposite 0.2.1 is now deployed to Mapbox's vector tile APIs 😄


[IDEA] ASCII Export

It would be cool if we could somehow export to ASCII so that folks can use for markdown/code comment diagrams

I think it would be cool, I have absolutely no idea how to make that happen though :(

I'm not sure if that's feasible or worth doing it in the end of the day!
If anything just use this: http://asciiflow.com

I think it's far fetched for now :)


Added Favicon

Favicon was added to the project.

ok,reply to the issue first so that I can assign it to you then you can go for making a pr

ok, reply to the issue first so that I can assign it to you then you can go for making a pr

okay, from now onwards I will do it.


Code First related internal classes for non SQL Servers

Hi,
we are investigating into the work involved in supporting Code First for one of our Database Servers and as a first step, we were looking into Create Database and Create Table from models workflow. We need to access some of the internal classes of MS Entity Framework(DatabaseTableChecker and DatabaseExistenceState as examples). Can you please let us know what is the best practice for using these? Also, we see the DefaultScheme being tied to dbo which is not our default schema. Are there any design guidelines for supporting code first workflow?
Thanks for the help
Vishwa

@VishDev2018 Internal classes are internal to the EF code and should not be used from your code. With regard to "design guidelines for code first workflow" can you be more specific?

Thanks for your quick response.
I understand the intent of Internal namespace, but what is not clear is, if other providers of EntityFramework have to support Code First workflow, what are the guidelines. For example, if we use the existing EF workflow, it has code suited to SQL Server. We see code such as DefaultSchema as dbo which is not valid for others. I assume there must be some guidelines for other providers on how to use existing infrastructure and classes such as Database Initializers, CreateDatabaseIfNotExists, InternalContext etc. Specifically, I am looking for what to re-use and how and what custom code we have to develop specific to our providers.


Updates

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Gid733:x: Roomey12You have signed the CLA already but the status is still pending? Let us recheck it.


supabase db pull doesn't pull storage policies

Describe the bug
Running supabase db pull --schema storage doesn't generate any SQL for the storage policies.
To Reproduce
Steps to reproduce the behavior:

Create some storage schema policies on dashboard
Run supabase db pull --schema storage locally
Inspect generated migration SQL and see that no SQL is generated for storage policies
Run studio via supabase start and see that no policies are under storage either

Expected behavior
Expected that storage policies would be generated in the migration
Desktop (please complete the following information):

OS: MacOS
Browser (if applicable) chrome
Version of CLI [e.g. v1.60.0] 1.131.4

closing as a duplicate https://github.com/supabase/cli/issues/1623

Hi @zhadavi, I can't reproduce this problem using cli version 1.131.4.
Could you share the output of supabase services for a quick version check?

@sweatybridge sure:
❯ supabase services

        SERVICE IMAGE      │        LOCAL         │ LINKED
  ─────────────────────────┼──────────────────────┼─────────
    supabase/postgres      │ <IP_ADDRESS>           │ -
    supabase/gotrue        │ v2.130.0             │ -
    postgrest/postgrest    │ v12.0.1              │ -
    supabase/realtime      │ v2.25.50             │ -
    supabase/storage-api   │ v0.43.11             │ -
    supabase/edge-runtime  │ v1.29.1              │ -
    supabase/studio        │ 20240101-8e4a094     │ -
    supabase/postgres-meta │ v0.75.0              │ -
    supabase/logflare      │ 1.4.0                │ -
    bitnami/pgbouncer      │ 1.20.1-debian-11-r39 │ -
    darthsim/imgproxy      │ v3.8.0               │ -

@sweatybridge sure
❯ supabase services

        SERVICE IMAGE      │        LOCAL         │   LINKED
  ─────────────────────────┼──────────────────────┼─────────────
    supabase/postgres      │ <IP_ADDRESS>           │ <IP_ADDRESS>
    supabase/gotrue        │ v2.132.3             │ v2.132.3
    postgrest/postgrest    │ v12.0.1              │ v12.0.1
    supabase/realtime      │ v2.25.50             │ -
    supabase/storage-api   │ v0.43.11             │ v0.43.11
    supabase/edge-runtime  │ v1.29.1              │ -
    supabase/studio        │ 20240101-8e4a094     │ -
    supabase/postgres-meta │ v0.75.0              │ -
    supabase/logflare      │ 1.4.0                │ -
    bitnami/pgbouncer      │ 1.20.1-debian-11-r39 │ -
    darthsim/imgproxy      │ v3.8.0               │ -
    ```

The versions look ok.
Could you double check that you have linked the right project by running supabase projects list?
If that's also ok, it might be specific to your hosted project. Please run supabase db pull --schema storage --create-ticket and reply the ticket id so we can look into it further.

Oh I see. This is indeed a misleading behaviour of CLI.  I will make a PR to address this but meanwhile, you can work around it by pulling twice.
supabase db pull
supabase db pull --schema storage

This seems to still be an issue. Running the command twice, the first time without the schema flag, doesnt help @sweatybridge

yeah also experiencing this issue still

Any update on this? Encountering the same problem


fixfix case test_outfile_orc_max_file_size by replace table_export_name

Proposed changes

fix case test_outfile_orc_max_file_size by replace table_export_name
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


change to a maven project

change to a maven project. and refact part of class name and code.

Thanks for your effort. However since I'm using this repository mainly for feeding the code snippets of my blog posts, moving everything to unit tests is counter productive to me. I'd have to strip all JUnit related stuff for my blog.


Is the project still active?

Even the forums seems to be down?

Doesn't seem so :-( unfortunately....
Did you find any other Resources/Projects for maybe updated hardware @NemoN ?

ping

pong ;-)
Has anyone built the hardware lately?
Maybe with a pcb layout (https://pcbs.io/)

just uploaded the Eagle file to pcbs.io
4 pieces of the pcb will costs $47.48
(anyone from germany is interessted?)

@NemoN ~50USD seems on the pricey side of PCBs.

@corbolais the pcb is HUGE. and this is the price for 4 of them  i will share the project.

@corbolais i'm open for cheaper alternatives/design

@corbolais the pcb is HUGE. and this is the price for 4 of them i will share the project.

How "HUGE" can it be with one handfull of parts? See schematic.
It's mostly empty: https://www.altium.com/viewer?token=RCPrv1w3Z06RtPVzClU0qLAb .
That's alot of cash for empty FR4.
Cheers.

@corbolais yes the mostly empty, but the dimensions are large: https://PCBs.io/share/zabeJ

Recently I started to Update the HumPi Project.
https://github.com/gillhofer/HumPi


Tiagoferreira wex rfc0001

Adding base structure for the RFC platform

First Commit

This PR was opened by accident. Please disregards.
Thank you


possible C# support?

i have been asking around and c# on psvita is already difficult given only unity and psm, so this is less a feature request and more a way to open up conversation. id love to use c# on vita in an open source non-abandonware way.

It might be possible through some CIL (what C# compiles into) conversion layer like what Unity does. In fact, not Sony related, but that's what Nintendo did/does for Unity for 3DS, Wii U, Switch, etc.

does godot not already compile to cil? what does godot compile c# to then?

Well, from what I understand, C# gets compiled into CIL, and then that CIL is then read by the .NET runtime to run tasks.
So, someone would either have to port .NET itself to the Vita, or make something that takes the functional place of it.
Which imo, Godot should look into doing the latter anyways, but I digress.

what would you say is the best method? porting dotnet or making an interpreter for psvita?

I don't know, I've never messed with .NET nor C# much. But if a CIL interpreter that directly talked to Godot was made, it would be possible to add that to Godot as a whole, not just this project, and then Godot wouldn't need the .NET runtime per say. Or, in down-the-river terms, it would help everyone everywhere, official or fork, so you might be able to get more people interested in making/helping on such a thing, not just us who are interested in Godot on a depreciated handheld.

If you are talking about something similar to IL2CPP VM, I doubt it's possible to achieve on that Godot end (Unity itself is tightly integrated with their custom fork of Mono VM where Godot is not).
The NativeAOT publish mode of the modern dotnet (.Net 6+) might be a good entry point. It compiles the CIL directly into native code. However, I think is a long journey to add extra platform support for NativeAOT.
A feasible option would be writing a custom GDExtension plugin or modifying the source code to boot the PSVita built-in dotnet runtime at the initialization level, similar to how Godot mono module bootstrapping the CoreCLR runtime via HostFXR, however, I only have very limited knowledge about how the PSVita built-in dotnet runtime works.

I disagree. Remember, GDscript itself is a module in Godot, not integrated as part of the main engine, and it is capable of interacting with 90% of the engine. I don't think something that would communicate with Godot on the same level, except with CIL instead of GDscript scripts, would be impossible by any means.
Furthermore, modules are essentially an even more integrated version of GDNative/GDExtension, so if it's possible in a GDExtension, it's possible in a module.

The thing is, CIL itself cannot be run directly by the operating system, you require at least a VM to translate it into the native code on the fly. The elephant in the room is to find a way to execute CIL on the PSVita platform.

Yes. This module would ultimately not replace the full capabilities of current C# in Godot, rather making it possible for people who only use C# as a more familiar/comfortable alternative to GDscript (ie. Exclusively in the engine, for engine scripting) to export their game to more platforms.
And no, GDscript is not any more complicated than C#, at least on an overall level. Both compile to bytecode files, and then a runtime does something with those bytecode files at program execution, whether it's JIT compilation, AOT compilation at startup, simply parsing it as an instruction sheet, whatever. However GDscript has been doing it, seems to work for exported platforms, so this would likely be a mimic of that, but interpreting CIL instead of gdscript's bytecode language (I couldn't find an actual name for it).

I might give it a shot later, if I don't forget it lol

if you do i would be very thankful. if i wanted to get deeper understanding what would you recommend? right now i only really know c# for game design.

I'd just try to port Godot's current approach to the Vita's mono runtime. The only 2 things I am afraid of, is that it wouldn't make the port all too legal (same level as the unity vita games) and second that the runtime is too old.

Yes. This module would ultimately not replace the full capabilities of current C# in Godot, rather making it possible for people who only use C# as a more familiar/comfortable alternative to GDscript (ie. Exclusively in the engine, for engine scripting) to export their game to more platforms.
And no, GDscript is not any more complicated than C#, at least on an overall level. Both compile to bytecode files, and then a runtime does something with those bytecode files at program execution, whether it's JIT compilation, AOT compilation at startup, simply parsing it as an instruction sheet, whatever. However GDscript has been doing it, seems to work for exported platforms, so this would likely be a mimic of that, but interpreting CIL instead of gdscript's bytecode language (I couldn't find an actual name for it).

Just to be clear, this module we are talking about is intended for PSVita use right?
Currently, the best way to use C# as a more familiar/comfortable alternative to GDscript is the current C# in Godot. Stripping out most of C#'s BCL(base class library) is not considered as use C# as a more familiar/comfortable alternative to GDscript.
For example, the most recent version of Unity supports .Net Standard 2.1 (which one or two functions/modules unavailable), which you can consider as a subset of C# functionality, which is already giving dotnet developers headaches due to lack of Nuget Package support and newer C# version support (that's why they are slowly migrating to modern dotnet), I doubt the definition of your use C# as a more familiar/comfortable alternative to GDscript does not fit the actual familiar/comfortable need for dotnet development.
In conclusion, this custom C# language interpreter module with minimal BCL would be a feasible trade-off for cross-platforming support, but why not look towards a typed script language such as TypeScript?

The module would be for general Godot, not just Vita. A Vita specific solution could be implemented, but imo, it would be more worth it to make this a universal module for as many platforms to use. So, this applies to Vita, but is also a more general solution to a much wider issue with Godot.
And what exactly is implemented on the C# side of things is not my wheelhouse. I'd imagine a lot of the BCL can be substituted by Godot's in-house functions, and the rest can be filled in courtesy of taking notes from .NET or Mono's source code and recontextualizing that in the context of how Godot works. Or, make a while mini .NET port inside Godot. Idk. As long as the backend code handling the CIL does what the dev wants/expects it to do, I'm not amazingly concerned with how the backend is implemented.
And who said anything about a trade off? No, this would exist alongside current C# support. In fact, for platforms like Windows and Linux, the current C# solutions would probably still be preferred. This solution fills the need in cases where
A. The dev wants a completely self contained export (no need for the user to have a CIL runtime installed)
B. The platform in question does not have a CIL runtime, or its current solutions are undesired for whatever reasons there may be.
And I'm not looking at other languages here because C# has official Godot integration while those others do not. But yeah something like this could probably be implemented for any other language too I guess lol

Well... I totally understand that version of minimal C# language you described, and probably even know the details about implementation.
I'm just expressing the point that implementing such minimal C# with godot BCL would take too much effort (not worth it) than just creating a binding for scripting language...
Or I can say what you just described is another scripting language that's similar to C# in syntax.

That sounds good to me. I'll go ahead and throw it out there, though, that I have no personal experience with needing a solution to this issue (I have never used C#, whether with Godot or otherwise, and at most have only read over other people's code), so I'm also not the right person to bounce ideas off of if you want a real "game dev who uses C# in Godot" take. I myself think that if the syntax is identical, C# devs probably wouldn't mind using a scripting language C# clone, or at the very least they can copy-paste their C# when they need to use the integrated clone language instead, but I'm also not an actual C# dev, so idk if that would be good enough in practice or not.
But, for what it's worth, it gets my thumbs up of approval

From my experience in Unity and Godot-Mono, I'm afraid the answer is no.


Refactor set_estimator files and add tests

@dguijo would you mind checking over set_regressor? I don't want to interfere with any of your workflows.


Dual Monitor Support

I think there should be dual monitor supper, when a user has another monitor connected through HDMI. I realise this may be hard, but I think it is worth the try!

No dip sherlock, I cannot reply to myself for this issue...

Interesting idea. Triple monitor support?

Interesting idea. Triple monitor support?

Very interesting idea quadruple monitor support?

Very Very interesting idea. Quintuple monitor support?

Very Very interesting idea. Quintuple monitor support?

Very, very, very interesting idea (this one is a little sus), sextuplet monitor support?

Very Very interesting idea. Quintuple monitor support?

Very, very, very interesting idea (this one is a little sus), sextuple monitor support?
Wall Street be like...
Very very very interesting idea, septuple monitor support?

Very Very interesting idea. Quintuple monitor support?

Very, very, very interesting idea (this one is a little sus), sextuple monitor support?

Wall Street be like...

Very very very interesting idea, septuple monitor support?

Insanely interesting idea, octuple monitor support?

OK that's enough. I was serious about triple monitor support.

Besides, you currently can't connect more than 4 monitors to even a RTX 3090

Besides, you currently can't connect more than 4 monitors to even a RTX 3090

Very interesting, non-tuple monitor support?

Bruh I -  I give up.

Bruh I - I give up.

Ok ok... How bout, Dectuple monitor support (Ok, I am actually serious about Dual and Triple monitor support tho).

I will get to work on this tomorrow.

@Lukas-Batema
This may help.
https://medium.com/geekculture/web-based-multi-screen-apps-including-drag-drop-5e161da6507b

I will get to work on this tomorrow.

So , functionality can be added or would it be too complicated ?

I will get to work on this tomorrow.

So , functionality can be added or would it be too complicated ?

Not sure, but I'll try.

I will get to work on this tomorrow.

So , functionality can be added or would it be too complicated ?

Not sure, but I'll try.

O.K. ! Good luck !

.

I am starting work on this right now.

@Lukas-Batema This may help. medium.com/geekculture/web-based-multi-screen-apps-including-drag-drop-5e161da6507b

The problem with this, is it uses .mjs files, as opposed to .js files, as well as adding in a new framework.

There are dual monitor support ?

Gonna work on this now!

[x]  HAVE YOU SIGNED THE CLA?
[ ]  HAVE YOU VISITED THE CIA?
[ ]  HAVE YOU ASSESS THE CTA?

@andrewstech tf

[x] signed


Bug: Replace extra_registries with extra_public_registries

Feature or Bugfix

Bugfix

Detail

Replace extra_registries with extra_public_registries in emr.py to conform to the arguments.

Relates

https://github.com/aws/aws-sdk-pandas/issues/1755

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 2e6d5afa82d81e4971ab54af834125ba194b555d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: de734ca31d4b6607ce7996ca0fb80feb30f8c984
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 05c129e70600e7c0a56862d8502f04ff2a93702b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Chakra failed with error C4596 when build with permissive- + MSVC on windows.

Chakra failed with error error C4596: '{ctor}': illegal qualified name in member declaration when build with permissive- on Windows, I use latest source on master branch. Could you please help take a look at this? Noted that this issue only found when compiles with unreleased vctoolset, that next release of MSVC will have this behavior.
You can repro this issue as the steps below:

git clone -c core.autocrlf=true https://github.com/microsoft/ChakraCore D:\Chakra\src
Open a clean x86 prompt (C:\windows\syswow64\cmd.exe) and browse to D:\Chakra\src
set  CL=-wd4471 /permissive-
msbuild /m /p:Platform=x86 /p:Configuration=Test /p:WindowsTargetPlatformVersion=10.0.16299.0 Build\Chakra.Core.sln /t:Rebuild

Error info:
D:\Chakra\src\lib\Runtime\PlatformAgnostic\Platform\Windows\HiResTimer.cpp(25): error C4596: '{ctor}': illegal qualified name in member declaration
D:\Chakra\src\lib\Runtime\PlatformAgnostic\Platform\Windows\HiResTimer.cpp(71): error C4596: 'QuantizedQPC': illegal qualified name in member declaration

Woops, my bad.

The toolset is released, you can could fix this issue.

Fixed in 1fc4e1f.


getting hyper debug/trace logs

Hi!
I would like to see the debug/trace logs hyper is emitting. Is there a way to get it somehow?
RUST_LOG=hyper=debug has not worked.
Thanks

You can enable -v to see DEBUG logs while running a load test, and this includes hyper debugging. (Use -vv if you want TRACE level logs, too.)
Alternatively, you can enable -gg -G goose.log if you want to save the logs to a file (in this case named goose.log). (Use -ggg if you wan the log file to include TRACE level logs.)
In all cases, Trace level logging is extremely noisy and will negatively impact performance.


Visual tweakz

Making the styleguide pagez pop

Make the sidebar 250px width
Put main content inside a <Container size="2"> so it's centered in the remaining space (minus the sidebar)
Make menu items 35px tall (I had the 31px exclusively for the layer tree. I thought all other menu items would be 25px or 35px).
Give menu items 25px left and right padding
Make sidebar headings gray600...I think that's 5 in your fancy new scale? They could either be dark and bold if you prefer.
The main text in tables should be one notch smaller
Can we add our custom scrollbar to the sidebar? The same one we're using throughout the core product

e voila!

Much better ✨
I'll address the following in different PRs:

Custom Scrollbar
MenuItem updates


v-memo on child  of v-for does not render or updates properly

Version
3.2.0-beta.7
Reproduction link
sfc playground repro
Steps to reproduce
open the Reproduction link
click  on inc button, every 5 clicks the memo should trigger an update
there are 2 lists.

the first one the v-memo is on the child element
the 2nd list the v-memo is on the element with the v-for.

in the second list all items will update when the memo dependency changes.
in the first list, there are 2 problems.

only the last item gets updated.
the props passed to the component all render as 0 in all items. ( except  for odd values on the last item in the list)

What is expected?
2nd list should probably render the same as 1st list
What is actually happening?
inconsistent render with missing values of props

This is not correct usage:

flip is not even reactive
flip isn't used in the subtree where memo is placed

It's great you're playing around with the API and trying to report back bugs but as said in the PR, if you think memo could be used in other scenarios, described those scenarios first instead of showing abstract cases that are not realistic and are not what memo is trying to solve either

in the example the count increment is what triggers the component update.
forcing the reevaluation of the memo to check if the value changes since last render
https://github.com/vuejs/docs/blob/55505e758466a43e7e9c6e406dc2be4632604f71/src/api/directives.md#v-memo-

Memoize a sub-tree of the template. Can be used on both elements and components.
The directive expects a fixed-length array of dependency values to compare for the memoization.
If every value in the array was the same as last render, then updates for the entire sub-tree will be skipped. For example:

no where in the docs it is indicated that flip has to be reactive.
using flip in the subtree reactive or not makes no difference

makes no difference
also a minimal reproduction of a problem should not reflect a business problem or a use case, it sufficient to show that there is a problem in the most simplistic way for developers to find or identify the bug.
there are 2 v-for list that seemingly should have behaved the same and they are not, this is indicative of a bug.

Thanks for the repro. I actually misread this issue, the different behavior is indeed a bug.

no where in the docs it is indicated that flip has to be reactive

There are: non-reactive variable changes don't trigger template updates in general. In this case, it makes no difference because other variables are triggering a template update but if there are none, you won't see any updates (click 5 times to see no changes)

(
+ because we disable tracking the block tree here.
_openBlock(true),
_createElementBlock(_Fragment, null, _renderList(_unref(items), (id, index, ___, _cached) => {
      const _memo = ([ _unref(flip) ])
+ here currentBlock is null, As a result, the block tree is not tracked correncly in isMemoSame.
      if (_cached && _cached.key === id && _isMemoSame(_cached, _memo)) return _cached
      const _item = (_openBlock(), _createBlock(Item, {
        count: count.value,
        index: index,
        key: id
      }, null, 8 /* PROPS */, ["count", "index"]))
      _item.memo = _memo
      return _item
    }, _cache, 1), 128 /* KEYED_FRAGMENT */))

Ok, this is not a bug, but this is currently by design: v-memo does not work inside v-for, it can only be used with v-for. Could probably be improved though.

From the user's point, maybe add this into syntax/context checker of Vue compiler?
As mentioned above, for current state, v-memo cannot be inside v-for".


Idea: API Extensions

Basically a npm module can have a setting called "BeApiExtention" where it just runs and puts the contents in a file for BeApi to read from on startup of the world or something. Where it can extend the classes before the globalthis  override is run. This can be useful for adding additional command options to the base BeAPI command handler for example. As there may be modules that add two good features to the same class and you want to use them both without extra imports.

Make an example then I will review it.

Still working on this, just to note


DL-165 : Add TestTimedOutTestsListener to dump timed out cases thread dump

what's wrong?  i can build successful on my local box...

@xieliang I think you need to generate test-jar for distributedlog-protocol and include the test-jar for other modules, no?

@sijie good catch. i verified it works by adding Thread.sleep(xxx) into a random test case, i could see the dump info.

@xieliang could you provide a description of the change in your commit message ?


Cleanup dependencies

This cleans up our dependencies slightly through version matching or dependency removal.
Fixes #2436

Removes failure

failure's README describes that it's in a bit of flux as improvements are being made to Rust's stdlib upstream, so we might want to avoid relying on it too greatly in its current state
we aren't really using failure consistently throughout, and many of the messages are just taken directly from doc comments anyway. While we could make usage more consistent, it's not clear that this effort will be very useful if it's incompatible with upstream changes in Rust itself.

Matches spirv_cross version across all backends
Removes derivative

most existing usages seem like they could be treated as opaque types because they don't provide much debug information, so we could just write custom debug implementations wherever it's noticeably useful

PR checklist:

[x] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends: Metal
[ ] rustfmt run on changed code

bors r+

bors r=kvark

bors r=kvark

bors r=kvark

Looks like the GitHub outage caused some issues staging the latest set of commits
bors r=kvark

bors r-

bors r=kvark


Feature request: brew cask list/outdated should distinguish moved and renamed casks

Description of feature/enhancement
It would be great if there was some command that would alert the user of removed and moved/renamed casks. I imagine that this should be done in both list and outdated commands. I am not sure if brew update does this, and if it does I do not believe that is enough of a notice.
Justification
I found recently that some of my casks were renamed, but I do not recall any notification of this in the brew update message, and couldn't find any brew cask commands that would systematically show me all moved/removed casks. I searched for documentation or issues on the subject and couldn't find anything, so I apologize if this already exists in code or discussion somewhere.
Example use case
Currently brew cask commands might output something like so (asterisks denote moved or deleted casks, added for emphasis):
$ brew cask list
ffmpegx *
filebot
macupdate-desktop *
malwarebytes-anti-malware *
meld
mendeley-desktop *
skim
$ brew cask outdated
filebot (4.7.2, 4.7.5) != 4.7.9

The casks indicated actually don't have formulae anymore under those names, they were renamed or removed, but still exist in the Caskroom directory and still show the old metadata via brew cask info.
I would propose the following changes (or similar) to the output:
$ brew cask list
ffmpegx ✘
filebot
macupdate-desktop ♺
malwarebytes-anti-malware ♺
meld
mendeley-desktop ♺
skim
$ brew cask outdated
ffmpegx (x.y, x.z) -> REMOVED
filebot (4.7.2, 4.7.5) != 4.7.9
macupdate-desktop (a.b, a.c) -> macupdate
malwarebytes-anti-malware (d.e, d.f) -> malwarebytes
mendeley-desktop (g.h, g.i) -> mendeley

Proposed icons could be changed or have color as needed, of course. Output for brew cask info could also be adjusted if desired.

https://github.com/caskroom/homebrew-cask/issues/29716


Can't install on React Native CLI

When I run 'pod install' I get this error:
[!] Unable to find a specification for ExpoModulesCore depended upon by ReactNativeIosContextMenu
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

I am using cocoa pods v 1.14

same issue here. can't install anymore the pods

I am having the same issue. Vanilla react native

Install react-native-ios-context-menu 1.15.1 .  That version doesn't use expo modules and it doesn't require react-native-ios-utilities

Hey @nandorojo I think it would be great to mention this in the docs.
Because when I tried to use the lib in Bare RN project, pod install broke

Because of react-native-ios-utilities
https://github.com/dominicstop/react-native-ios-utilities/blob/572947169ef9896763eaee797192f5a8d63f723c/ReactNativeIosUtilities.podspec#L18
Let me know if this makes sense, I will raise the PR

same issue here

also getting this issue


Skewness/Kurtosis

Recreate sample code in Python to calculate skewness.

As the corresponding code has been merged successfully, I reckon that this issue can be closed now.


Adapting to Unseen Chess Set

Based off the instructions in Appendix C.2.6, it says I should only need two images along with two .json files inside data://transfer_learning/images/train. However, when I go to run the transfer_learning training command (python -m chesscog.transfer_learning.create_dataset and then python -m chesscog.transfer_learning.train), I get multiple errors along the lines of:

File "/chess/chesscog/core/dataset/dataset.py", line 70, in build_dataset
dataset = torchvision.datasets.ImageFolder(root=URI(cfg.DATASET.PATH) / mode.value,
File "/usr/local/lib/python3.8/site-packages/torchvision/datasets/folder.py", line 310, in init
super(ImageFolder, self).init(root, loader, IMG_EXTENSIONS if is_valid_file is None else None,
File "/usr/local/lib/python3.8/site-packages/torchvision/datasets/folder.py", line 146, in init
samples = self.make_dataset(self.root, class_to_idx, extensions, is_valid_file)
File "/usr/local/lib/python3.8/site-packages/torchvision/datasets/folder.py", line 192, in make_dataset
return make_dataset(directory, class_to_idx, extensions=extensions, is_valid_file=is_valid_file)
File "/usr/local/lib/python3.8/site-packages/torchvision/datasets/folder.py", line 102, in make_dataset
raise FileNotFoundError(msg)
FileNotFoundError: Found no valid file for the classes empty, occupied. Supported extensions are: .jpg, .jpeg, .png, .ppm, .bmp, .pgm, .tif, .tiff, .webp

For this particular error I was able to fix it by manually moving my white and black starting position images into the generated folder of data://transfer_learning/occupancy/occupied. I then assumed that the empty folder required a picture of an empty board, which I put into data://transfer_learning/occupancy/empty. However, once it finished training the occupancy, it errored on the piece_classification, saying it lacked images for black_bishop, black_king, etc. Do I need to take separate images for each piece? Am I running the wrong commands? This seems to be a whole of a lot more complex than two supplied images with supplied positions. (I also didn't need to move the position .jsons apparently?) Also note that I've tried running this both using the dockerfile and poetry and run into similar problems.
As an aside, I'd like to say this is absolutely amazing work and thank you! Very well written and explained, I am excited to get this to work :)

Oopsies, I think .jpg vs .png was the problem, still diagnosing the RANSAC failing to detect my chessboard.

Hi @Krakenmeister, did you manage to fix the problem? Also see https://github.com/georg-wolflein/chesscog/issues/15 which might be related.

As this https://arxiv.org/abs/2310.04086 pointed out, it seems that ChessCog's weakest point is the chessboard recognition step. I might clean up my manual corners code and submit it, but I think combining forces with some other techniques for this could be very powerful. Am delighted to get it working though!

Ah, interesting! Yes indeed the corner recognition is the main weakness. If you find a better solution please let me know!

Yes, it is related and that issue helped, but is solved now. I think part of the hang up is that the data:// folder is unintuitively created in a completely different directory (~/chess_data) despite the existence of a "data" folder inside the repo. I think it was pointed out somewhere, but an extra note to that effect couldn't hurt (or even moving the fens.txt file so that it's clear that folder isn't the data:// directory).


Unable to finalize the release 0.2.7

Onto the last step:
TAR=gtar CP=gcp  githubctl --token_file=/Users/linsun/.git/istio-token
--op=uploadArtifacts --base_branch=master --next_release=0.2.7
i've got gtar and gcp installed, failed at this error, even tho the release archives are created in /tmp/release/archives dir.  But it seems to fail at uploading to git.
adding: istio-0.2.7/samples/sleep/sleep.yaml (deflated 54%)
~/go/src/istio.io/test-infra/istio
Archives are available in /tmp/release/archives
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x133147b]

goroutine 1 [running]:
istio.io/test-infra/toolbox/util.GithubClient.CreateReleaseUploadArchives(0xc4200a2900, 0x141660f, 0x5, 0xc4200190e0, 0x28, 0x141660f, 0x5, 0xc420186370, 0x5, 0x141c5c4, ...)
  toolbox/util/githubClient.go:338 +0x10b
main.CreateIstioReleaseUploadArtifacts.func1(0xc400000010, 0x142a978)
  toolbox/githubctl/main.go:206 +0xea
main.cloneIstioMakePR(0xc42013c500, 0x15, 0xc4201a65d0, 0x2e, 0xc42013c540, 0x1f, 0xc42013c560, 0x0, 0x0)
  toolbox/githubctl/main.go:154 +0x19f
main.CreateIstioReleaseUploadArtifacts(0x7fff5fbff3d8, 0xf)
  toolbox/githubctl/main.go:220 +0x261
main.main()
  toolbox/githubctl/main.go:248 +0x124```

I'm on Mac OS 10.12.4 (Sierra).

i think we are getting nil on this:
release := github.RepositoryRelease{TagName: &releaseTag}

https://github.com/istio/test-infra/blob/master/toolbox/util/githubClient.go#L338
Line 338 of githubClient.go is a comment. Perhaps try again using the latest master?

Which sha of test infra did you run that from ? For some reason the line number don't match.

I was not able to reproduce this on linux, @chxchx could you try to reproduce this on mac, in your repo ?

--next_release=0.2.7 is wrong, you shuld have used  --next_release=0.2.8

yes, that must be it, even tho i can't validate it as you already run that step @sebastienvas

Lin, can we close this issue now? If not, what's still pending?

Added more clarification steps for this in the release engineer doc page.  closing it for now.


[Feature] BFloat16 SDPA

The training with bfloat16 gets extremely slow if the input length is long enough (e.g. 256/512). Hopefully, we can have BF16 SDPA to enjoy faster training experience.

BF16 is likely because it's not a native type. A BF16 SDPA wouldn't help with that specifically.
Can you share the benchmark you are running?

@awni I have M3 Pro. I guess it is a native type for me, no?

model: Qwen2 1.8B
batch size: 2
input length: 256
training speed: 12s/Iter

What were you running? LoRA/ QLoRA? Maybe just share the command?

What were you running? LoRA/ QLoRA? Maybe just share the command?

I was trying to run LoRA with my training framework which has data packing enabled. But to my surprise, it is actually slower with MLX.
Code for monkey patching to enable data packing:
            def patched_call(self, inputs, cache=None):
                h = self.embed_tokens(inputs)

                ## Using cache for attention mask, since cache is not used in training
                mask = cache
                if mask is None:
                    if h.shape[1] > 1:
                        mask = nn.MultiHeadAttention.create_additive_causal_mask(h.shape[1])
                        mask = mask.astype(h.dtype)
                else:
                    slices = [mask[i] for i in range(mask.shape[0])]
                    masks = [(~mx.triu(m[:, None] == m[None])) * -1e9 for m in slices]
                    mask = mx.expand_dims(mx.stack(masks, 0), 1)
                    mask = mask.astype(h.dtype)

                cache = [None] * len(self.layers)

                for e, layer in enumerate(self.layers):
                    h, cache[e] = layer(h, mask, cache[e])

                return self.norm(h), cache

            model.model.__call__ = patched_call.__get__(model.model, type(model.model))

Also did you try in fp16? Was it much faster?

Yeah, I just tried fp16. It yields 10.6s/Iter, which is 10% faster. This is still below my expectations.

How fast is it without your batch packing?
Also you might want to check that your packing is actually being uses. Does not look like you are overriding __call__ properly there (though I can't be sure given I don't know what else is going on in your code).
E.g. see the following:
class M:
    def __call__(self):
        print("hi")

def patch(self):
    print("bye")

m = M()
m.__call__ = patch
m() # prints hi
type(m).__call__ = patch
m() # prints bye


Python2 compat

Work required was annoying but it's complete, and doesn't complicate any future development for pgsheets.
I added travis-ci config and used travis-ci to confirm the new python 2.6 and 2.7 compatibility: https://travis-ci.org/robin900/pgsheets/builds/117465021
Feel free to set up your own travis-ci free account and let the travis builds do their thing.

I have another branch, oauth2client-token, that is pre-merged with this python2-compat branch. I can create a PR for that branch for you if you accept and merge this Pytonn2 -compatibilty PR.

Also, I reference the travis-ci links in the README.rst, but github does not support any referencing of the current branch, only hard links. So I've added a commit to this PR that references your master branch and not mine.

Still interested in merging this PR @henrystokeley  ?


Add info about cached processes to docs

Added info that for the total CO2e of a pipeline all completed and cached processes are used.
@mirpedrol Actually, I usually also use "CO2e" for the equation, in the slides at least (just realizing that it's different in the code), could we change this for the formula in the docs as well (currently using "C")?

I modified the formula to use CO2e


Calling TrackPlayer.Destroy() in useEffect cleanup function crashes ios and "fries" android on 2.2.0-rc4

Describe the Bug
A clear and concise description of what the bug is.
On the page where we use the track player we have a useEffect cleanup function that when the page is unloaded the TrackPlayer is destroyed. On RC4, calling this function on iOS causes an immediate hard crash. The type that triggers a popup from MacOs saying the app quit unexpectedly. On Android it technically doesn't crash, but the app begins to display extremely weird behavior afterwards. For instance, despite not saying so, it loses connection to metro. At least so far as fast refresh goes. Additionally, we are using Firebase and all of our Firestore listeners stop working. Like I said... weird behavior.
Steps To Reproduce
How can someone else reproduce this bug?
Call TrackPlayer.Destroy() during unmounting of the track player on RC4
Code To Reproduce
Please provide a simple code example that allows others to replicate the bug.
useEffect(() => {     return () => {               TrackPlayer.destroy();         };  }, []);
Environment Info:
Paste the results of npx react-native info
System:
OS: macOS 12.4
CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Memory: 791.21 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.13.2 - /usr/local/bin/node
Yarn: 1.22.19 - ~/.yarn/bin/yarn
npm: 8.1.2 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK:
API Levels: 29, 30, 31
Build Tools: 29.0.2, 30.0.2, 31.0.0, 32.0.0
System Images: android-29 | Intel x86 Atom, android-29 | Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8512546
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.13 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.68.2 => 0.68.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
info React Native v0.69.1 is now available (your project is running on v0.68.2).
Paste the exact react-native-track-player version you are using
Exact same code works on 2.2.0-RC3, the crash occurs on 2.2.0-RC4
Real device? Or simulator?
Both (iOS and Android)
What OS are you running?
MacOS
How I can Help
What can you do to help resolve this?
Have you investigated the underlying JS or Swift/Android code causing this bug?
Can you create a Pull Request with a fix?
There's a potential this is related to this issue, but for now, I suggest to anyone encountering this issue just roll back the version.
I can post the crash log from MacOs, but to be honest, I spent hours trying to figure it out before posting here and I didn't see anything worth while in it. But happy to share it if you think it can help!

Update: Rolling back to RC3 only fixes iOS, Android remains "fried"

@marcfrankel I'm not able to reproduce your issue. When I call destroy I do not get any fatal exception. I tested on both Android & iOS.
Please create a reproducible example by forking the project and updating the code in example to demonstrate your issue.

The .reset(); crash on iOS is occurrd by an ‘index out of range’ error in handleAudioPlayerQueueIndexChange. It happens when there is only one track in the queue (namely the current track)
This is the code that seems to cause the error
if let nextIndex = nextIndex, nextIndex < player.items.count {             let track = player.items[nextIndex]             isTrackLiveStream = (track as? Track)?.isLiveStream ?? false         }
I have commented out that code and the queue succesfully resets without crashing. It seems the code assumes there is a next index, even when there is not. Thus it crashes because the index is out of range.
Haven’t tested Android yet, as I want some sleep now. :)

@DennisdeWitNL
This is a separate issue. The reset issue has already been solved on iOS via another ticket (please see the PR I linked above).

@jspizziri Look at the code above. It seems the code is the same as your PR, but it still didn’t fix the issue. Or am I really so tired that I am misreading your PR?

@DennisdeWitNL this is the wrong ticket to discuss reset, as it's about destroy.
Please hop onto this one https://github.com/doublesymmetry/react-native-track-player/issues/1585

+1 on this. Both the reset() and the destroy() are causing iOS crashes while on the following setup:
 "react": "17.0.2",
 "react-native": "0.68.2",
 "react-native-track-player": "2.2.0-rc4",

Code snippet from my component:
 useEffect(() => {
   TrackPlayer.addEventListener(Event.PlaybackError, () =>
      setHasError(true),
    )

    return () => {
      TrackPlayer.destroy() // Causes a crash

       // TrackPlayer.reset() // Also causes a crash :(
     }
 }, [])

From the discussions above it looks like you have found the problem though. Is there a patch release incoming?

The reset issue has been fixed on another ticket. The destroy issue I have not been able to reproduce. Please try to create a repro based on the example project.
I don't have the ability to release. But I hope for one in the next week or two. I suggest using RC3 if this is a showstopper for you.

I have managed to repro using the example code (which I have embedded into a screen within my existing app). All example code was copied and pasted directly and plays the tracks as expected.
To see the crash - the only change is adding a cleanup function to the effect in App.tsx:
    useEffect(() => {
        async function run() {
            const isSetup = await SetupService()
            setIsPlayerReady(isSetup)

            const queue = await TrackPlayer.getQueue()
            if (isSetup && queue.length <= 0) {
                await QueueInitalTracksService()
            }
        }

        run()

        return () => {
            TrackPlayer.destroy()
        }
    }, [])

This is causing iOS to crash every time I navigate away from the screen showing the audio player.

@cashtotalszero
I need you to send me a link to a forked of this repo with the reproduction added as a commit. Thanks!

@jspizziri sorry to ping you if it's night.
Take a look at @cashtotalszero's code above, this issue comes from with SetupService
in the example,
https://github.com/doublesymmetry/react-native-track-player/blob/d961abe733a77ba9d5b0cffb193cb864eaf0c784/example/src/services/SetupService.ts
after TrackPlayer.destroy is called, TrackPlayer.getCurrentTrack() will cause the crash due to  player is destroyed.

As I've mentioned a few times now. I cannot reproduce this despite my best efforts. I'm going to close this, if someone is having the issue still I'll happily reopen it if they provide a fork of the repository with a reproduction in the example project.

Still same issue with iOS, crashing on destroy and reset

It worked thank you
https://github.com/doublesymmetry/react-native-track-player/issues/1585#issuecomment-1194163796

To summarize for future readers, this bug happens on versions 2.2.0-rc3 and 2.2.0-rc4, and it seems related to the issue #1585. This other bug was already solved and by consequence this one is too.
The solution isn't released yet, so if you want to solve this on your end you have two options:

Downgrade to versions below 2.2.0-rc3 (I don't know in which one the bug was introduced, so I'm not sure which one you have to downgrade to)
Or update the package to the nightly version (click here for more info)

By the way, I guess that @jspizziri wasn't able to reproduce the issue because it was testing in the nightly version, and in that version, the issue was already solved (but anyway, the bug is solved 🎉)

Looks like it's fixed on the latest 2.2.0-rc4-e36a016d1640e75649d6da4056f8977da33864e1 version.
You can upgrade it with :
yarn upgrade<EMAIL_ADDRESS>


Problem with Advanced Example

When using the function
$qrCode->setLogoSize(150, 150);
i get an error that there is no function "setLogoSize". Looking into the code, there is indeed no such fucntion. I replaced it with setLogoWidth() which works. Maybe its an outdated example?!
Installed via composer directly
Btw: Awesome Library! Thanks!

Hi @bendspoons when I look at the current version I see the method is present, see https://github.com/endroid/qr-code/blob/3.6.0/src/QrCode.php so maybe you are using an older (and possibly inconsistently documented) version.


Fix 500 when edit hook

Fix #3696 . A mirror repository will not create gitea hooks directory hooks.  This PR will check and create that if not exist.

Codecov Report

Merging #8782 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #8782      +/-   ##
==========================================
- Coverage   41.35%   41.35%   -0.01%
==========================================
  Files         541      541
  Lines       69487    69491       +4
==========================================
+ Hits        28738    28739       +1
- Misses      37064    37071       +7
+ Partials     3685     3681       -4

Impacted Files
Coverage Δ

modules/git/hook.go
49.31% <25%> (-1.41%)
:arrow_down:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

modules/task/migrate.go
24.35% <0%> (-3.85%)
:arrow_down:

models/error.go
32.08% <0%> (-1.25%)
:arrow_down:

models/repo_list.go
73.3% <0%> (-0.98%)
:arrow_down:

models/repo.go
48.62% <0%> (+0.05%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

modules/migrations/gitea.go
11.77% <0%> (+1.49%)
:arrow_up:

modules/migrations/migrate.go
22.9% <0%> (+1.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d663df...629bffa. Read the comment docs.


AttributeError: '_TfDeviceCaptureOp' object has no attribute 'node_def

Hi, i'm sorry to bother you, but i was meet a error when I use keras. my envs as follow: tensorflow-gpu==1.12, keras==2.2.4 , tensorpack==<IP_ADDRESS>
the error is:

and i use functions of keras by follow way:

of course, it has the same error when i use ConvLSTM2D have get while i use the function "BatchNormalization()", which belong to keras. but the function 'Reshape()' and 'concatenate()' are run well .
Could you help me slove this error? I'd appreciate it if you could help me with this error.

Kindly install the latest version of ImageAI to address this issue.
https://imageai.readthedocs.io/en/latest/index.html#installing-imageai

Kindly install the latest version of ImageAI to address this issue.
https://imageai.readthedocs.io/en/latest/index.html#installing-imageai


Simplify Mask Handling When Only One Object is Detected

Description
When using sam2_models, I encountered an issue related to processing images that contain only one detected object. Specifically, the current code may raise the following error:

ValueError: cannot select an axis to squeeze out which has size not equal to one

This issue arises when the masks are squeezed without proper dimension checks.
I propose enhancing the logic to handle cases where only one object is detected by implementing additional checks before squeezing the masks. This improvement will ensure that the code executes smoothly regardless of the number of detected objects.
https://github.com/opengeos/segment-geospatial/blob/8888ba6471cedc22ba790601b058cd33d5544257/samgeo/text_sam.py#L338
if len(boxes) > 0:
            masks = self.predict_sam(image_pil, boxes)
            print("Masks shape before squeeze:", masks.shape)

            # Squeeze masks based on their shape
            if masks.ndim == 4 and masks.shape[1] == 1:
                masks = masks.squeeze(1)  # Squeeze the channel dimension
            elif masks.ndim == 3 and masks.shape[0] == 1:
                masks = masks.squeeze(0)

By implementing this suggested change, we can prevent errors related to dimension squeezing when processing images with single object detections. Additionally, since masks.ndim will either be 4 or 3, we can simplify the code by removing the elif statement that checks for masks.ndim == 3 and masks.shape[0] == 1.

Good suggestion. I encourage to submit a pull request to fix this. Thanks.

Fixed in #352


Generic syntax ambiguity is handled incorrectly

🔎 Search Terms
generic syntax ambiguity
🕗 Version & Regression Information

I was unable to test this on prior versions because there is no online tooling for it

⏯ Playground Link
https://www.typescriptlang.org/play/?#code/MYewdgzgLgBAhjAvDAjAGhgIyTATB4HAZgwBMcAWDAUxwFYBuAKFEhABtqA6dkAcwAUCADxYMAwgD4YA8gDIY1AJQrmQA
💻 Code
const a = 1, b = 2, c = 3, d = 4, e = 5;
console.log(a < b, (c > (d & e)));

🙁 Actual behavior
This expression is not callable.
🙂 Expected behavior
true false
Additional information about the issue
While there might be some justification for why
const a = 1, b = 2, c = 3, d = 4, e = 5;
console.log(a < b, c > (d & e));

doesn't work as it did in JS, in the provided example there isn't even any disambiguity.

from trying variations on this, a little bit of testing in the online playground it seems like this is related to the < b, c > being parsed as a type cast instead of a < b and  c > (d & e)
you can see that the code
(playground)
const a = 1,b = 2,c = 3,d = 4,e = 5;
console.log(a <any> (d & e)));

produces the same output as the original ticket.

The general Relational Expression ambiguity is a long-standing known issue.  But as you mention, this is a more specific case where there's no ambiguity given that < b, (c > cannot be parsed as type arguments.
Whilst the TypeScript parser deems < b, (c > to be erasable types, most other mainstream parsers do not.  These parsers correctly preserve the original JS semantics when attempting to parse as TS:

Babel
esbuild
Oxc
SWC


[BUGFIX] contract staking context management

This PR fixes contract staking and extends test coverage.
#4999

bors r+


[speculative idea] enable node redefinitions

Is your feature request related to a problem? Please describe.
it is common outside of hamilton for people to "redefine columns" without mutation in value, e.g. in the case of filtering & joining data sets, the values wont change, but the indexes might. This right now forces one to rename things in hamilton if you want
to stitch together a single DAG.
Describe the solution you'd like
Idea:

module crawling order matters. e.g. data_loaders, transforms, model_pipelines, etc. vs model_pipelines, transforms, data_loaders...
enable one to explicitly "redefine" columns via some sort of decorator. If it's not explicit, Hamilton should error.
then any downstream functions that depend on those columns, would depend on the least previously defined version.
this means you can effectively also treat your modules as stages in a pipeline too.

@redefinition
def date(date:pd.Series) -> pd.Series:
     return pd.datetime(date)

@redefinition
@extract_columns("date", "bar")
def some_filter_step(date:pd.Series, bar: pd.Series, filter: str) -> pd.Series:
     df = pd.DataFrame({"date": date, "bar" : bar})
     df = df[data < filter]
     return df

Describe alternatives you've considered
You rename columns in these cases.
Additional context
Not sure how good an idea this is. But it's something to potentially try out and see how it looks.

Some of this could also be mitigated by functionality in https://github.com/stitchfix/hamilton/issues/86#issuecomment-1407582031

OK, so this makes implementation/onboarding easier, but doesn't help readability/maintainability of pipeline... However, its nice to not have to draw up a bunch of different functions.
The cool thing about this is this could actually be syntactic sugar for merging nodes together/composing -- doesn't even have to be its own nodes.
Implementation could be tricky -- with the current decorator model (decorator => multiple nodes, no context), we'd have to have some notion of state, otherwise we'd have no idea what to call them. OTOH, we could take a click-like approach, which might make this easier to implement:
What this does is it allows us to attach this function to the end of the date function
def date() -> pd.Series:
    return ['20230101', '20230102', ...']

@date.redefine
def date(date:pd.Series) -> pd.Series:
     return pd.datetime(date)

@date.redefine
@extract_columns("date", "bar")
def some_filter_step(date:pd.Series, bar: pd.Series, filter: str) -> pd.Series:
     df = pd.DataFrame({"date": date, "bar" : bar})
     df = df[data < filter]
     return df

This also clarifies what is being redefined...
The way this would work is:
(1) the date function (all but the last) don't actually get outputted by the module -- they turn into None or get name-mangled in some way
(2) Each date refers to the prior one -- we could use __ if we want them around for later
(3) Each date effectively prepends the DAG created by the upstream node to the overall DAG created by that node.
This gets ugly when we have extract_columns/multiple outputs that get redefined, but I'm happy for that not to be allowed. That said, we could always do:
@some_filter_step.bar.redefine
// or
@some_filter_step.redefine('bar')
def bar(bar: pd.Series) -> pd.Series:
    return bar*2

Which would give us the information we need.

We are moving repositories! Please see the new version of this issue at https://github.com/DAGWorks-Inc/hamilton/issues/65. Also, please give us a star/update any of your internal links.
Note that everything else (slack community, pypi packages, etc...) will not change at all.


Navigator doesn't work from initState()

Using a Navigator from initState(), causes it to crash.
For example, the following code, will result in
   ...
  @override
  void initState() {
    super.initState();
    Navigator.pushReplacementNamed(context, '/home');  // This is the culprit
  }

This error -
I/flutter (30816): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (30816): The following assertion was thrown building Builder:
I/flutter (30816): setState() or markNeedsBuild() called during build.
I/flutter (30816): This Overlay widget cannot be marked as needing to build because the framework is already in the
I/flutter (30816): process of building widgets. A widget can be marked as needing to be built during the build phase
I/flutter (30816): only if one of its ancestors is currently building. This exception is allowed because the framework
I/flutter (30816): builds parent widgets before children, which means a dirty descendant will always be built.
I/flutter (30816): Otherwise, the framework might not visit this widget during this build phase.
I/flutter (30816): The widget on which setState() or markNeedsBuild() was called was:
I/flutter (30816):   Overlay-[LabeledGlobalKey<OverlayState>#c75f5](state: OverlayState#db278(entries:
I/flutter (30816):   [OverlayEntry#c188f(opaque: false; maintainState: false), OverlayEntry#70486(opaque: false;
I/flutter (30816):   maintainState: true), OverlayEntry#4ccb0(opaque: false; maintainState: false),
I/flutter (30816):   OverlayEntry#f1654(opaque: false; maintainState: true)]))
I/flutter (30816): The widget which was currently being built when the offending call was made was:
I/flutter (30816):   Builder

Steps to Reproduce
Run this file inside a flutter application.
main.dart
Logs
output.txt
$ flutter doctor -v
[✓] Flutter (Channel beta, v0.5.1, on Linux, locale en_US.utf8)
    • Flutter version 0.5.1 at /home/dev/Apps/flutter
    • Framework revision c7ea3ca377 (6 weeks ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
    • Android SDK at /home/dev/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.1
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.1)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] Connected devices (1 available)
    • Nexus 5 • 0553a8d90a662209 • android-arm • Android 7.1.2 (API 25)

• No issues found!

Something to note:
If I somehow delay the call to pushReplacementNamed(), then the application works fine.
import 'package:flutter/material.dart';
import 'dart:async';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'MyApp',
      initialRoute: '/',
      routes: {
        '/': (context) => LandingPage(),
        '/home': (context) => OtherPage(),
      },
    );
  }
}

class LandingPage extends StatefulWidget {
  @override
  LandingPageState createState() {
    return new LandingPageState();
  }
}

class LandingPageState extends State<LandingPage> {
  @override
  void initState() {
    super.initState();

    // The delay fixes it
    Future.delayed(Duration(milliseconds: 100)).then((_) {
      Navigator.pushReplacementNamed(context, '/home');
    });
  }

  @override
  Widget build(BuildContext context) {
    return Center(
      child: CircularProgressIndicator(),
    );
  }
}

class OtherPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text('other page'),
        ),
        body: Center(
          child: Text('other page content'),
        ));
  }
}

The problem is that by the time you get to initState, the Navigator has already been built. If you tell it to build again, it can't really do anything useful: it's already been built this frame.

Did you see my last comment z explaining how it doesn't throw an error when the call to push() is delayed?

Did you see my last comment explaining how it doesn't throw an error when the call to push() is delayed?

Right, if you do it not while we're building widgets, then it'll work fine. It'll be a bit weird in that there'll be one frame where the page before the one you pushed is interactive. The right solution is to push before you build the "background" page.

Which is contradictory to

We build the widgets one by one going down the tree. The Navigator is above your widget, so it gets built first, but then we get to your widget, and it tells the navigator to do something new (to mark itself dirty). Since we're building the widgets for this frame already when initState runs, and since the Navigator has already been built, it's too late to go and update the Navigator to build something else (which we would need to do to put up another dialog).

Thanks for the detailed explanation

I believe this is the correct way?
bool _isAuthenticated = false;

void main() async {
  _isAuthenticated = await checkIfAuthenticated();
  print('app loaded!');
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'secure pdf viewer',
      initialRoute: '/',
      onGenerateRoute: (RouteSettings settings) {
        switch (settings.name) {
          case '/':
            return MaterialPageRoute(builder: (_) {
              return _isAuthenticated ? BrowseScreen() : LoginScreen();
            });
          case '/login':
            return MaterialPageRoute(builder: (_) => LoginScreen());
          case '/browse':
            return MaterialPageRoute(builder: (_) => BrowseScreen());
        }
      },
    );
  }
}

if you look inside the internals of the Navigator widget, you will realize it is a stateful widget that calls setState when you call pushReplacementNamed. This is like calling setState inside initState. Since setstate builds the widget tree and initstate also does, it throws and error to avoid a race condition. The solution of calling it with a delay work because by the end of the delay, the widget tree would have been built.

The solution is to do the decision as to what route to show before the build method. Delaying isn't the solution as it causes a flash.

agreed, but trying to navigate away in initState is the first culprit. I don't know or understand why that will be in the first place, except a splash screen is being built.

FFR: You can use Navigator from didChangeDependencies. It is guaranteed to be called for the first time immediately after initState. It's like with InheritedWidget.

the following code is working.
@override
void initState() {
Future.microtask(dothings);
}

@taojoe I'd guess that this solution causes one frame delay, which sounds kind of acceptable, but also like a possible source of difficult to debug bugs