Fix open api key error handling

Fixes #421
This PR adds a check for the presence of the OPENAI_API_KEY environment variable. Also it fixes a typo in the config.json in the README (and a couple of linting changes).

I considered wrapping the code between line-91  and line-99 inside a try/except block and checking for the Validation error message for a missing API key(I am not completely sure if there is a better way), but in that case I thought the code should handle all sorts of Validation errors and not just this one. However since there can be many such Validation Errors, where one Validation Error object may contain more than one error, it seemed like a better idea to check for the API key separately.
This was the code I thought would work but not sure how to handle other validation errors.
try:
    if self._engine == "chat":
        self.model_params = {**self.DEFAULT_PARAMS_CHAT_ENGINE, **model_params}
        self.llm = ChatOpenAI(model_name=self.model_name, **self.model_params)
    else:
        self.model_params = {
            **self.DEFAULT_PARAMS_COMPLETION_ENGINE,
            **model_params,
        }
        self.llm = OpenAI(model_name=self.model_name, **self.model_params)
except ValidationError as err:
    if err.__str__().find("Did not find openai_api_key") != -1:
        raise ValueError("OPENAI_API_KEY environment variable not set") from None
    else:
        raise err from None

This is what it looks like.
from autolabel import LabelingAgent
agent = LabelingAgent(config='downloads/config.json')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/packages/venv/env-1/lib/python3.11/site-packages/autolabel/labeler.py", line 49, in __init__
    self.llm: BaseModel = ModelFactory.from_config(self.config, cache=self.cache)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/packages/venv/env-1/lib/python3.11/site-packages/autolabel/models/__init__.py", line 58, in from_config
    return model_cls(config, cache)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/packages/venv/env-1/lib/python3.11/site-packages/autolabel/models/openai.py", line 103, in __init__
    raise ValueError("OPENAI_API_KEY environment variable not set") from None
ValueError: OPENAI_API_KEY environment variable not set

If you haven't already, also consider joining our Discord: https://discord.gg/fweVnRx6CU


Failed to clean stale beacon headers     err="filled header below beacon header tail: 45987 < 67388"

Describe the bug
Failed to clean stale beacon headers.
I don't think there is a solution at the moment other than having to rebuild the docker
Steps to reproduce

If node isnt sync and stopped node ( i have editeded .env too),
run node
you may have this error:
Beacon backfilling failed                err="syncing canceled (requested)"
ERROR Failed to clean stale beacon headers     err="filled header below beacon header tail: 45987 < 67392"

Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

same here. tested several endpoints
l2_execution_engine-1    | INFO [05-01|07:08:51.150] Restarting sync cycle                    reason="chain gapped, head: 70168, newHead: 70170"
l2_execution_engine-1    | ERROR[05-01|07:08:51.150] Failed to clean stale beacon headers     err="filled header below beacon header tail: 70002 < 70168"

I installed Nimbus for local Holesky beacon node. It didnt solve syncing speed issue still very slow and not usabe

###Solved:
I'm using my own beacon RPC by port 5052
###Open REST port:
add in your Holesky .env:
COMPOSE_FILE......:cl-shared.yml
###STEPS
update your holesky node: sudo ./ethd update
Add the new TAG in Holesky .env: TRAEFIK_TAG=v3.0
Restart: sudo ./ethd up
Add: enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303 to BOOT_NODES in taiko node .env
Restart and delete old images:
docker compose --profile l2_execution_engine down -v && docker rmi -f $(docker images -aq) && docker compose --profile l2_execution_engine up -d

Solved:
I'm using my own beacon RPC by port 5052
STEPS
Open REST port: add in your Holesky .env: COMPOSE_FILE=......:cl-shared.yml
update your holesky node: sudo ./ethd update Add the new TAG in Holesky .env: TRAEFIK_TAG=v3.0 Restart: sudo ./ethd up
Add in taiko node .env: BOOT_NODES=<enode://......>,enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303
You can add more separated by a "," without spaces, find how and more BOOT_NODES here: https://github.com/taikoxyz/simple-taiko-node/blob/main/.env.sample
and L1_BEACON_HTTP=http://<YOUR_HOLESKY_NODE_IP>:5052
Restart and delete old images: docker compose --profile l2_execution_engine down -v && docker rmi -f $(docker images -aq) && docker compose --profile l2_execution_engine up -d

solved? i dont use own beacon rpc node

Solved:
I'm using my own beacon RPC by port 5052
STEPS
Open REST port: add in your Holesky .env: COMPOSE_FILE=......:cl-shared.yml
update your holesky node: sudo ./ethd update Add the new TAG in Holesky .env: TRAEFIK_TAG=v3.0 Restart: sudo ./ethd up
Add in taiko node .env: BOOT_NODES=<enode://......>,enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303
You can add more separated by a "," without spaces, find how and more BOOT_NODES here: https://github.com/taikoxyz/simple-taiko-node/blob/main/.env.sample
and L1_BEACON_HTTP=http://<YOUR_HOLESKY_NODE_IP>:5052
Restart and delete old images: docker compose --profile l2_execution_engine down -v && docker rmi -f $(docker images -aq) && docker compose --profile l2_execution_engine up -d

solved? i dont use own beacon rpc node

yes it's fixed.
Simple, follow this: https://github.com/taikoxyz/simple-taiko-node/issues/222#issuecomment-2089016632 and use it,
or try with your public RPC but having our own nodes, I see it as something quite unnecessary...

Thanks for workaround
Worked for me and L2 synced in 8min only !

same here. tested several endpoints
l2_execution_engine-1    | INFO [05-01|07:08:51.150] Restarting sync cycle                    reason="chain gapped, head: 70168, newHead: 70170"
l2_execution_engine-1    | ERROR[05-01|07:08:51.150] Failed to clean stale beacon headers     err="filled header below beacon header tail: 70002 < 70168"

Thanks for your feedback. I'm looking for the reason. This kind of problem will be very helpful for us to make the node more stable.

I installed Nimbus for local Holesky beacon node. It didn't solve syncing speed. still very slow and not usable

You can try to start snap sync.

@amis13 your bootnode is not working 🙂
original workaround working bootnode:
enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303

@amis13 your bootnode is not working 🙂
original workaround working bootnode:
enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303

previous enode that @amis13 provided was working perfectly and still is if I'm not mistaken

@amis13 your bootnode is not working 🙂
original workaround working bootnode (which I manage):
enode://0b310c7dcfcf45ef32dde60fec274af88d52c7f0fb6a7e038b14f5f7bb7d72f3ab96a59328270532a871db988a0bcf57aa9258fa8a80e8e553a7bb5abd77c40d@<IP_ADDRESS>:30303

Fixed, I've tested and you were right, the request port isn't the 30303, it's 30306:
enode://1d3cbb450d07d0657c0636528a25b26232d1c9cf5b7fc2eec22a29b5bde58b9227cb88bca388d822f26662705221e77c07153bc3fc4cb06472d0e09e9208b9bc@<IP_ADDRESS>:30306


Update node modules and CLIs 2.2.2

Fix for https://github.com/open-cluster-management/backlog/issues/9592 and https://github.com/open-cluster-management/backlog/issues/9602 to update lodash to v4.17.21 and CLI binaries to OCP 4.7 level.

PR not constructed correctly for 2.2.2, so closing.


Add ability to navigate search results with keyboard arrow keys

When someone makes a search, we show a list of results that match that search
We should allow someone to navigate that list using their arrows keys to change the focus of which element is selected, in addition to the already supported-by-default tab key
The feature needs to not negatively impact accessibility
The search form and results are inside of the Nav.js component:
https://github.com/colbyfayock/next-wordpress-starter/blob/master/src/components/Nav/Nav.js

Added in #49


Thoughts on using  Producer instance as a singleton.

Description
Would it be recommended to use the same instance of producer instead of creating and disposing it again and again in a producer client which is supposed to be running 24/7 and processing messages most of the time.
How to reproduce
NA
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[ ] Confluent.Kafka nuget version.
[ ] Apache Kafka version.
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

using Confluent.Kafka;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using System;
using System.IO;
namespace KafkaExtensions
{
class Program
{
public static IServiceProvider serviceProvider;
    static void Main(string[] args)
    {
        try
        {
            RegisterServices();

            var producer = serviceProvider.GetRequiredService<IProducer<Null, string>>();
            var message = new Message<Null, string>();
            message.Value = "Testing_Singleton";
            var topicName = serviceProvider.GetRequiredService<IConfiguration>()["TopicName"];
            producer.Produce(topicName, message,deliveryHandler=> {
                if (deliveryHandler.Error.IsError)
                    Console.WriteLine(deliveryHandler.Error.Reason);
                else
                    Console.WriteLine(deliveryHandler.TopicPartitionOffset);
            });
            Console.ReadLine();
        }
        catch(Exception ex)
        {
            Console.WriteLine(ex.Message);
        }
        finally
        {

        }

    }
    static void RegisterServices()
    {
       var services = new ServiceCollection();
       services.AddProducer<Null, string>();
       serviceProvider = services.BuildServiceProvider();

    }
    private static void DeliveryReportHandler(DeliveryReport<Null,string> deliveryReport)
    {
        if (deliveryReport.Error.IsError)
            Console.WriteLine(deliveryReport.Error.Reason);
        else
            Console.WriteLine(deliveryReport.TopicPartitionOffset);
    }
}

}
namespace Microsoft.Extensions.DependencyInjection
{
public static class KafkaProducerServiceExtension
{
    public static void AddProducer<TKey, TValue>(this IServiceCollection services)
    {
        var config = new ConfigurationBuilder()
          .SetBasePath(Directory.GetCurrentDirectory())
          .AddJsonFile("appSettings.json", optional: false)
          .Build();
        services.AddSingleton<IConfiguration>(config);

        var producerConfig = new ProducerConfig();
        config.GetSection("ProducerConfigurations").Bind(producerConfig);
        producerConfig.ClientId = Environment.MachineName;

        var producerBuilder = new ProducerBuilder<TKey, TValue>(producerConfig);
        services.AddSingleton(producerBuilder.Build());
    }

}

}

Yes. Re initialising the producer again and again can be very expensive and not recommended. You will find reusing the same producer is far more efficient and the number of messages you can produce per second will increase dramatically.

Yes. Re initialising the producer again and again can be very expensive and not recommended. You will find reusing the same producer is far more efficient and the number of messages you can produce per second will increase dramatically.

Thanks for the response, just want the official confirmation from Kafka team. Also , can Confluent team can come up with an extension method for creating the objects of Producer and Consumer client , that would be great.

yes, creating a singleton service like that is a good pattern. you definitely should not create a producer each time you want to produce a message - it is approximately 500,000 times less efficient.

yes, creating a singleton service like that is a good pattern. you definitely should not create a producer each time you want to produce a message - it is approximately 500,000 times less efficient.

So this means, I need to call the Flush() and Dispose() method only once when my service is being terminated or stopped.
Well making it singleton will keep the connection open with the broker all the time, that may be an issue for the broker adminstrator for my application.

i have save question. i create a producer each time when produce a message now, but it inefficient

the broker kills open connections that aren't being used (by default after
10 minutes), and they will be reopened again as required.
On Mon, Sep 28, 2020 at 1:03 AM moxixuan<EMAIL_ADDRESS>wrote:

i have save question. i create a producer each time when produce a message
now, but it inefficient
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/confluentinc/confluent-kafka-dotnet/issues/1346#issuecomment-699848729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEVZQOZLIN4WTN2GXPKNLSIA7NHANCNFSM4OS2PRHQ
.

Hi @mhowlett , I have a few questions about using the producer as a singleton.
I understand that its better performance wise, but what happens when there is an exception producing a message? Is there a chance that the producer ends in a bad state and must be disposed and create a new one?

in some very rare circumstances: https://github.com/edenhill/librdkafka/blob/master/INTRODUCTION.md#fatal-producer-errors . you shouldn't write your application expecting that will be common.

@mhowlett - are there any recommendations for lifetimes on the consumer side of things? is it similar that creating a consumer is expensive like a producer?

yes, it's similarly expensive. depending on your use-case, you could consider building a consumer pool.

@mhowlett - Could you please update the web-example to include examples of utilizing JSON Serializer as well?
Existing serializer samples are disposing the client after each request, which is not efficient.

@mhowlett hello!
If Producer is recommended as Singleton, does it mean that it is also thread-safe?
Should we create a Singleton Producer per application or a Singleton Producer per topic?

Oh, I've already found the answer this question here:
https://github.com/confluentinc/confluent-kafka-dotnet/issues/1041
Sorry to bother you. Thanks for addressing this other issue though! :)

Closing, as all the queries are answered.


Fixing the assignment of the embedded manifold (hle).

Previously hle was being set to the autoencoder hidden layer, rather than the UMAP manifold.
The only impact of this was in terms of visualization, as the objects reference to hle was only used for visualization - for clustering the local (correct) hle reference was used.

Makes sense, merging!

Thanks for merging. It may be a good idea to update the README with the new visualizations too!

Will do! Currently updating tensorflow which has turned into rebuilding it, so ill fix it when that is finished, and get the proper code on Pypi :)

Actually ill rebuild in the morning this is much more enjoyable

I'm not sure what happened but it looks like this commit [1] brought in the old incorrect visualisations rather than the visualisations from this pull request.


Fix delete button for dashboard message

Couple of (small) questions:
While I was fixing this, I noticed the dashboard message looks a bit wide when set on the school group page:

This is easy enough to fix by putting it in inside a container:

However, the alignment inside the notice doesn't look perfect either. Want to leave it wide or go with this option?
Also, I switched the buttons over on the dashboard message form - before the save button was on the left and the back button on the right. Even though I initially wrote it, it feels like the save button should be on the right. What do you think?
Old version:

New version:

Thanks @ldodds. I meant horizontally really as there is probably too much space to the left of the icon (in my head anyway) - feels like the icon should align with the "Recent Usage" text. Vertically it doesn't quite look right either though with less text. One to be done separately?


Sentiment Analysis of IMDB Movie Reviews

Hi. I wanted to develop a sentiment analysis model, implementing various classification models to predict the number of positive and negative reviews based on sentiment in the IMDB movie dataset.

pls assign me the issue,i will make sure the task is done,I have prior experience with the model too.

sanjay-kv
Hi! Can you kindly add a level to this issue.


Using a svg image for the node image

How am i able to use a svg image for the node image?

Since image is also an SVG component, you can just pass

nodeSvgShape={                         {                             shape: 'image',                             shapeProps: {                                 href="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png",                                 width: 40,                                 height: 40,                             }                         }                     }


Migrate SDK6 Observables to GOVS Components in SDK7 + OnChange event

WHY
Currently the observables used in SDK7 are the old SDK6 structure of observables to keep feature parity, but observables should be removed from SDK7 altogether and be replaced by components, ideally GrowOnlyValueSet Compoents (GOVS) since the value of those components would only be read from the sdk runtime and not written.
Also some kind of 'OnChange' event would be needed to keep the desired functionality of previous observables (https://github.com/decentraland/sdk/issues/740 would implement the needed 'OnChange' functionality, so that other issue should be tackled first).
WHAT
Convert the old observables into GOVS component usable from scenes with its 'OnChange' event (that should've been implemented first with https://github.com/decentraland/sdk/issues/740):
State related

[x] onSceneReadyObservable -> The tick #0 wont execute until all the main.crdt models are loaded. Other components may use the GltfContainerLoadingState component
[x] onCameraModeChangedObservable -> CameraMode component of static entity CameraEntity
[x] onPointerLockedStateChange -> PointerLocked component
[x] onIdleStateChangedObservable -> IdleState component

Players present

[ ] onPlayerConnectedObservable
[ ] onPlayerDisconnectedObservable
[ ] onEnterSceneObservable
[ ] onLeaveSceneObservable
[ ] onRealmChangedObservable

Player interactions

[ ] onPlayerExpressionObservable
[ ] onPlayerClickedObservable

Video related

[ ] onVideoEvent

Some of these are already converted into LWW components
onSceneReadyObservable -> This one is nolonger necessary since the tick #0 will only execute AFTER scene is ready.
onCameraModeChangedObservable -> CameraMode component
onPointerLockedStateChange -> PointerLock component
onIdleStateChangedObservable -> IdleState component
The following are definitely GOVS but are blocked until comms specification and foreign keys are finalized:

onPlayerClickedObservable
onPlayerExpressionObservable
onPlayerConnectedObservable
onPlayerDisconnectedObservable

Awsome, thx for updating the issue!

OnChange component already implemented.
Maybe it need's some love for all this components, but the work is almost done.

@pravusjif  is there anything left to do here? or can we consider it closed?


[jax2tf] Added utils to generated stats on generated HLO IR (WIP)

Opening as draft so we can discuss this.
Maybe measuring the size at the character level is not so helpful without deeper investigation, as shown by the difference in the sizes in the resulting file.
Part of it is simply that TF generated code seems to have more metadata, as you can see in the example below:
>>> print(tf.function(lambda x: x, experimental_compile=True).experimental_get_compiler_ir(1)())
HloModule a_inference__lambda__28__.5

ENTRY %a_inference__lambda__28__.5 () -> s32[] {
  %constant.1 = s32[] constant(1)
  %reshape.2 = s32[] reshape(s32[] %constant.1), metadata={op_name="XLA_Retvals"}
  %tuple.3 = (s32[]) tuple(s32[] %reshape.2), metadata={op_name="XLA_Retvals"}
  ROOT %get-tuple-element.4 = s32[] get-tuple-element((s32[]) %tuple.3), index=0, metadata={op_name="XLA_Retvals"}
}

vs
>>> print(jax.xla_computation(lambda x: x)(1).as_hlo_text())
HloModule xla_computation__lambda___6.4

ENTRY xla_computation__lambda___6.4 {
  constant.2 = pred[] constant(false)
  parameter.1 = s32[] parameter(0)
  ROOT tuple.3 = (s32[]) tuple(parameter.1)
}

I haven't looked yet into whether it is possible to strip it. It might be enough to count the number of lines instead, which should be closer!

It seems that TF constant folded the parameter when it was a scalar. Using an otherwise shaped array gives something like this:
>>> print(tf.function(lambda x: x, autograph=False, experimental_compile=True).experimental_get_compiler_ir(np.ones((2, 3)))())
HloModule a_inference__lambda__76__.6

ENTRY %a_inference__lambda__76__.6 (arg0.1: f64[2,3]) -> f64[2,3] {
  %arg0.1 = f64[2,3]{1,0} parameter(0), parameter_replication={false}, metadata={op_name="XLA_Args"}
  %reshape.2 = f64[2,3]{1,0} reshape(f64[2,3]{1,0} %arg0.1)
  %reshape.3 = f64[2,3]{1,0} reshape(f64[2,3]{1,0} %reshape.2), metadata={op_name="XLA_Retvals"}
  %tuple.4 = (f64[2,3]{1,0}) tuple(f64[2,3]{1,0} %reshape.3), metadata={op_name="XLA_Retvals"}
  ROOT %get-tuple-element.5 = f64[2,3]{1,0} get-tuple-element((f64[2,3]{1,0}) %tuple.4), index=0, metadata={op_name="XLA_Retvals"}

vs
>>> print(jax.xla_computation(lambda x: x)(np.ones((2, 3))).as_hlo_text())
HloModule xla_computation__lambda___7.4

ENTRY xla_computation__lambda___7.4 {
  constant.2 = pred[] constant(false)
  parameter.1 = f32[2,3]{1,0} parameter(0)
  ROOT tuple.3 = (f32[2,3]{1,0}) tuple(parameter.1)
}

I haven't looked yet into whether it is possible to strip it.

TF is simply choosing to print more of its metadata by default. I don't know whether it's easy to make TF print without metadata, but you can make JAX print with metadata (also a semiprivate API):
In [43]: options = jax.lib.xla_client._xla.HloPrintOptions()

In [44]: options.print_metadata = True

In [45]: print(jax.xla_computation(lambda x: x + 2)(1).as_hlo_module().to_string(options))
HloModule xla_computation__lambda___12.6

ENTRY %xla_computation__lambda___12.6 (parameter.1: s32[]) -> (s32[]) {
  %constant.2 = pred[] constant(false)
  %parameter.1 = s32[] parameter(0)
  %constant.3 = s32[] constant(2), metadata={op_type="add" op_name="xla_computation(<lambda>)/add" source_file="<ipython-input-45-380200ef996d>" source_line=1}
  %add.4 = s32[] add(s32[] %parameter.1, s32[] %constant.3), metadata={op_type="add" op_name="xla_computation(<lambda>)/add" source_file="<ipython-input-45-380200ef996d>" source_line=1}
  ROOT %tuple.5 = (s32[]) tuple(s32[] %add.4)
}

Note I slightly change the example to contain an operator, not just a constant.

As a high level point, if your goal is to count the number of HLO operators, you should probably do that at the C++ level on the HloModule data structure rather than by looking at the string representation.

Closing as stale.


Set collapse: none when option Collapsible by default isnt activated

Hey,
after the latest update 5.0.1 my beloved feature isnt working anymore.
I always used the admonition without any title
```ad-ai
title:
##### Was versteht man unter [[Machine Learning]]?
Some Text

and it rendered nicely to this block without the big titlebar.

Right now, with even "Collapsible by default" not set, it appears following notification:

with the titlebar rendered:

Is it possible to set collapse: none as default, when the option Collapsible by default isnt activated?
If I add collapse: none everything works fine, but than i had to edit all my blocks..

Sorry about that - missed this condition when fixing #41. Once I can get on my computer I'll have a fix out.

5.0.2 should fix this, sorry!


[vcpkg] Implement --editable

--editable suppresses binary caching and source re-extraction for packages listed on the command line (similar to --head).
This fundamentally changes the port maintenance loop, so several example documents were updated. To avoid users having substantial changes suddenly destroyed by forgetting to pass --editable, "clean" sources have different extract locations.
The undocumented command build implies --editable.
See also #11204.
+@cenit +@Neumann-A as recent prolific contributors who can help confirm that this new inner-loop is still solid :)

Thanks for asking. I am not fully understanding the goal here, I will check it better in the weekend looking at the code

So basicly we should start using vcpkg build or vcpkg install --editable if we want to do some changes to the build of a port.
It seems to work as intended. I just tested zlib and it seems to work as intended. hashes are completly different to master which will make merging a bit difficult if you are currently working on something.
The nice side effect is I don't need to copy the sources once as a baseline for git diff i can just use the *.clean folder

Thanks for the feedback!
@cenit I'd be happy to answer any questions; it is also discussed a bit in https://github.com/ras0219-msft/vcpkg/blob/dev/roschuma/binarycaching-spec/docs/specifications/binarycaching.md#better-control-over-source-modifications

... hashes are completly different to master which will make merging a bit difficult if you are currently working on something.

I don't quite understand what you mean by this, could you explain a bit more?

I don't quite understand what you mean by this, could you explain a bit more?

Seems like your master branch is just too outdated. I tested it with zlib and the initial build was with your master branch. It had a extracted source dir of 1.2.11-f690224aeb. I switched to your dev branch and got a extracted dir of 1.2.11-deec42f53b(.clean). I thus thought the hash has changed. Compared it now against other builds of zlib on my PC and saw that deec42f53b is the current one so the hash did not change and your master branch just needs updating to produce current hash values ;)

@ras0219 sorry I had no time to test your PR. Maybe also my workflow is different from what you describe (I usually do not work in the buildtrees folder, I had some scripts to automatically create patches from commits in outside folders, tracked so that patches can be pushed upstream easily.
In any case, no objection to any feature that might help contributors do the best work they can

@ras0219 sorry I had no time to test your PR. Maybe also my workflow is different from what you describe (I usually do not work in the buildtrees folder, I have some scripts to automatically create patches from commits in outside folders, tracked so that patches can be pushed for upstream PR easily).
In any case, no objection to any feature that might help contributors do the best work they can


Brace expansions

e.g. :echo h{i,o}p produces hip hop.
The implementation differs from GNU Bash and other general purpose shells in a few ways. First, there are a few deliberate things that I think improve the consistency of the language:

Single-option expansions behave like strings, e.g. {x} is like 'x'.

Unclosed braces cause a parse error, not a literal brace.
Spaces inside of expansions don't need to be escaped.
Quotes inside of expansions are literals not string delimiters, which mirrors the fact that braces inside of quoted strings are literals not expansion delimiters.

There are also a couple of differences that we might want to consider changing:

Expansions can't be used inside of variable names, e.g. in GNU Bash echo $FOO{1,2} is like echo $FOO1 $FOO2 (but echo ${FOO1,FOO2} is an error).

To support this new behaviour this PR also updates all of the various Gitsh::Arguments::* classes'
#value methods to produce Arrays instead of single values. The Gitsh::ArgumentList class takes on the responsibility of flattening the results.
Begins to address #145

I've been using this version for a few days, and I think I want to revisit some of the deliberate differences from how GNU Bash et al. handle things. Specifically these two:

Single-option expansions behave like strings, e.g. {x} is like 'x'.

I'll frequently diff my local branch against upstream, e.g. after a complex interactive rebase to make sure I didn't introduce accidental changes. The easiest way I know of doing that is diff @{u} @. After this change, that's pretty cumbersome (either diff '@{u}' @ or diff @\{u\}).
There are other similar shorthands, which I use less often but others might not, like @{-1}.
Three solutions I can think of:

Do the Bash-like thing, and treat {} or {x} as literals, only doing expansion when there's at least one comma.
Introduce a magic variable for upstream, e.g. $_u, and advise gitsh users to use that.
Leave things as they are, alias diff @{u} @ to diffu for my own use case, and trust others will find similar work arounds.

Following the principal of least astonishment, I'm inclined to do the first one.
What do other gitsh users things? /cc @sharplet @mike-burns

I’m also in favour of option 1. I regularly use this syntax to inspect my stash:
git show stash@{1} # show me the next stash below the top

Finally got back to this and (pairing with @seanpdoyle) figured out how to make this behave more like general-purpose shells. As of now:

Two or more items in braces will expand, e.g. {a,b}1 is equivalent to a1 b1
One item in braces will not expand, e.g. @{u} is a literal argument
Empty braces will not expand, e.g. {} is a literal argument

We had to make some minor compromises to get there, specifically an unmatched brace is now a parse error, but it's possible to work around by using an escaped brace e.g.
gitsh@ :echo }
gitsh: parse error
gitsh@ :echo \}
}


Fix potential vulnerability alerts

Upgrade protobufjs 6.8.0 => 6.8.6
Upgrade electron 1.8.6 => 1.8.8

:white_check_mark: Build plexus-interop 0.4.0-411 completed (commit https://github.com/finos-plexus/plexus-interop/commit/c1ee587b00 by @udalmik)


Add validate button and link it with dryRun cli supported backup restore funcationality

This PR adds validate button, which is equivalent of Dry Run in cli, it autofills the ealiest and latest restore point timestamps, so user can use it to perform an actual restore.

@shagunt @candiceye Is this something you're still planning on getting in?


fix: crash in IO.Process.wait on 32-bit architecture

The implemetation of unbox_uint32 is the same as unbox on 64-bit
but it is different for 32-bit platforms
Fixes #290

BTW, I don't have access to Windows development environment, neither do I use Lean on Windows. This fix is for Linux only.

BTW, I don't have access to Windows development environment, neither do I use Lean on Windows. This fix is for Linux only.

It should be a relatively safe bet to change https://github.com/leanprover/lean4/blob/master/src/runtime/process.cpp#L63 in the same way. Our CI will complain if that did somehow break the 64-bit build.

It should be a relatively safe bet to change https://github.com/leanprover/lean4/blob/master/src/runtime/process.cpp#L63 in the same way. Our CI will complain if that did somehow break the 64-bit build.

Ok, if you say so :smile:

Ok, if you say so :smile:

Thanks!

Thanks!


beforePopState() does not fire at all

Bug report
Describe the bug
When the user clicks on their browser's back button, I want to execute some custom logic for my app. I tried using Router.beforePopState() in my React component, but it never gets called. My goal is to be able to detect when the back button is pressed. I found example code in #6784  that shows the behaviour that I am talking about.
To Reproduce
Repo: https://github.com/mlnor27/nextjs-bug-to-reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

go to http://localhost:3000/
manually type out the link to the about page in your browser's url bar and press enter: http://localhost:3000/about
click your browser's back button
there is no alert popup, beforePopState never seems to get called

You can see that pop up if you click the link to 'about' page from the '/', instead of manually typing it into the url bar as in step 2.
Expected behavior
I want to detect when the user clicks their back button. In the provided example I expect to see an alert popping up.
Screenshots
Here is a screen capture:

manually typing into the address bar results in no popups
clicking the link, then pressing the back button to show that popup

System information

OS: Linux
Browser (if applies) Firefox Version 64.0.2 (64-bit)
Version of Next.js: 8.1.0

https://github.com/zeit/next.js/blob/00e8ba49819274564249cb55950841b3555d5929/packages/next-server/lib/router/router.ts#L110-L118
this will return true when visiting the page from the url bar
e.state.options && e.state.options.fromExternal

@timneutkens should I make a PR to switch the first if with the second one? I don't think that there will be any problem in doing so.

Hi, this doesn't appear to actually be a bug in Next.js. In the case you are describing popState isn't fired by the browser. This is to prevent a website from locking a user to a certain page I believe.

@mkondel I'm gonna close this now. If you believe this is still an issue feel free to leave another reply with more info.


Upcoming Events and Recent Events should be under tabs in the Events Page than one below another

This is more of a suggestion from a UX than a bug.
Upcoming and Recent Events are one below another. When someone clicks a couple of times "load more" button, they could be easily lost which one is Upcoming vs Recent Events. Hence, am suggesting the Events page to be modified with having tabs, one for Upcoming Events and another for Recent Events.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

cc @duttakapil

@duttakapil I ain't much aware of the frontend, but will surely give this one a try.


[0.0.43] Android/Rollup production build output is missing custom CSS

Short description of the problem:
When I build my app using ionic run android using Rollup as the bundler, the app's custom CSS is missing and everything looks bad.
I am currently seeing this issue on Windows 10, so that may be relevant. I have attempted to replicate this on iOS with my Mac, but that seems to work fine. I have not tried Webpack on either system. I have tested this on<EMAIL_ADDRESS>and everything works correctly.
What behavior are you expecting?
The app's custom CSS should be included in the Android package.
Steps to reproduce:

Create a new project (ionic start test --v2 --ts)
Change the bundler to Rollup.
Install<EMAIL_ADDRESS>Edit one of the page stylesheets with something obvious. For my test, I added the following to src/pages/home/home.scss:

page-home {
    .content-ios,
    .content-md {
        background-color: red;
    }
}

Run the app on an android device (ionic run android). For my example, the background of the home page should be red, but it will be white instead.

insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
0.0.43
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Ever since they moved to 0.4+ i am also having problems with roll-up.

Same problem. with both 0.0.43 & 0.0.44
ionic-app-scripts build --bundler webpack will output the right css.

i am having the same issue with 0.0.46

It's caused by bundle.modules of rollup, the path on Windows is something like \rootpath\path\ but not D:\rootpath\path.
So the finding in replace logic will not work. ( https://github.com/driftyco/ionic-app-scripts/blob/master/src/sass.ts#L163 )
Wish this info will help you guys to fix this bug.

Our temporary solution was adding the following line to sass.ts:
`function addComponentSassFiles(componentPath: string, collectedSassFiles: string[], context: BuildContext, sassConfig: SassConfig) {
let siblingFiles = getSiblingSassFiles(componentPath, sassConfig);
if (!siblingFiles.length && componentPath.indexOf(sep + 'node_modules') === -1) {
// if we didn't find anything, see if this module is mapped to another directory
for (const k in sassConfig.directoryMaps) {
  if (sassConfig.directoryMaps.hasOwnProperty(k)) {
    var actualDirectory = replacePathVars(context, k);
    var mappedDirectory = replacePathVars(context, sassConfig.directoryMaps[k]);

    **componentPath = path_1.resolve(componentPath);**
    componentPath = componentPath.replace(actualDirectory, mappedDirectory);

    siblingFiles = getSiblingSassFiles(componentPath, sassConfig);
    if (siblingFiles.length) {
      break;
    }
  }
}

}`

This is just happening on windows, on Mac env is working properly.

This is working now with latest version (0.0.47)

This should be resolved in 1.0.0. Please let me know if it's not.
Thanks,
Dan


[MSG] Long delay before conversations get sorted correctly in Inbox

If you send a new message in conversation and go back to the Inbox view, the message won't jump to the top right away. In this case, it took about 4 minutes. The 4th conversation in the list should be at the top of the Inbox.

Also, what’s that warning about?

It shows up when you do a pull to refresh, it has to do with the InboxRefetchQuery not including a cursor and count. It's probably just a matter of adding those to the query.

I’m not even sure why the inbox would reload at all. Do you know why?

@alloy this ticket seems a bit out of date, I'm not seeing anything noticeable when refreshing the inbox view..something we can close?

Probably. @l2succes can you reopen if there’s still a problem?


Portfolio: details popup window

In this pull request, I've implemented the following,

Add the following features

When the user clicks (or taps) the button to check project details, the popup with details about the project appears.
When the user clicks (or taps) the close (X) button, the popup disappears.

Add linters configuration for HTML, CSS, and Javascript.
Store store all of the information for all projects in a JavaScript array.
Store data of each project in a JavaScript object (name, description, featured image, technologies, link to live version, link to source.)

Hello code reviewers 👋😄 ,
This is the commit of my coding partner but somehow his profile is not showing.


fix: Fix key access to possibly non-existent location

Reverts Disane87/spoolman-homeassistant#89

:tada: This PR is included in version 0.4.1-dev.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.4.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SPIKE: evaluate if we can run kubernetes policies client side only

We are looking into a way to be able to run a set of policies in Busola to validate if best practices are followed.
Evaluate if we can utilize some of the shelf  solutions.
Some links to consider for evaluation:

https://github.com/kubevious/rules-library
https://www.jspolicy.com/
OPA
https://kyverno.io/

PW: I'm assuming we'd want to not only have baked-in standard validation policies, but also support custom ones via ConfigMap-defined entries.

Engine
Custom CRDs?
Rule language
Ran as an admission controller?
 How would it work anyway? It would deny the requests that violate the rules - so it's NOT running locally.

OPA - just the same as kyverno, it needs to install custom CRDs.

jsPolicy - it also requires a custom CRD, e.g.
apiVersion: policy.jspolicy.com/v1beta1
kind: JsPolicy
metadata:
  name: "deny-default-namespace.mycompany.tld"
spec:
  operations: ["CREATE"]
  resources: ["*"]
  scope: Namespaced
  javascript: |
    if (request.namespace === "default") {
      deny("Creation of resources within the default namespace is not allowed!");
    }

kubevious - it doesn't require any CRDs, runs via port forward. It also has a metalanguage - https://github.com/kubevious/rules-library/tree/master/library/pvc-outside-statefulset

To sum up, none of those expose a clear API we could grab and use - we could just get inspired by their rulesets. I'm against importing their Go codebase and using some of their functions - we would rely on their implementation that's likely to prone.

Seeing that Datree Spike looks better (validation mechanism is in JS, universal schema), we won't pursue other solutions. We can grab some of their rules during implementation task, though.


Remove stale branches in github

20 branches exist for StrategyIA at the opening of this issue. We should'nt have that much. Someone need to go through them and remove the stale one.

I have remove some stale branch and merged one.

Complete for now. Will reopen if needed.


New package: Kingdee.CloudHub version 4.1.9

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/110598&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Domain Policy-Test-2.7


Deleted Microgateway labels are still visible on the Devportal

I created a label by admin portal and published an API along with that Micro gateway label. Although Admin has deleted it by admin portal it still keeps visible under Available Microgateways. But that label is not visible in the Publisher even. It is only visible the name of the micro gateway label. Micro gateway URLs have disapered.

Closing because of : https://github.com/wso2/carbon-apimgt/pull/7634


Google SSO sign in stuck in silent-callback

when i get kicked out using Google SSO sometimes I sign in again and the page stays blank in the http://localhost:8585/silent-callback .

Fixed with #7227


This extension may be taken down on August 1

I received this email from<EMAIL_ADDRESS>on July 5. The counter argument would be: this extension does not redirect search requests, and the new tab page API is insufficient to provide all the features needed in this extension.

Updates to Chrome Web Store Policy
Dear Developer,
Protecting users and user choice have been long-standing principles of Google's core philosophy. That is why three years ago, Chrome released an extension-based Settings Overrides API for Chrome on Windows that ensures all users have notice and control over any settings change that take place in their browser. Earlier this year, we implemented the same API for macOS.
Starting August 1, the only compliant way to programmatically change the startup page, homepage, search provider setting, or any other setting that has an API is via the appropriate API. If your extension affects changes to any of these functions, it must use the API.
Extensions that have been using the Webrequest API (or other mechanisms) to redirect search requests from the new tab page or the omnibox, must now use the search provider and/or new tab page API. After August 1st, extensions redirecting search requests from the new tab page or omnibox without using these APIs will be removed from the store.
Extensions that perform automatic redirections from a web page URL must display a prominent notice informing the user of the redirection. For example, if an extension redirects search queries from www.google.com (or any other search provider), the extension's notice must:
Be prominent: large, conspicuous, and close in proximity to the search box and on the search engine results page
Be timely: shown prior to the user executing the search
Be persistent: the prominent notice (including the name) cannot automatically disappear or be dismissable; it must show up every time, not just prior to the first redirect
Must show the name of the extension (and the brand of search engine, if different) and what will happen
Not look similar to a system or Chrome dialog box or user-interface element; for example, disclosures in yellow bars that look similar to Chrome's yellow ("butter") bars are not permitted.
Extensions must also comply with other Chrome Web Store policies and Google's Unwanted Software Policy.
Sincerely,
Chrome Web Store Team
You have received this mandatory service announcement to update you about important changes to your account.
© 2016 Google Inc., 1600 Amphitheatre Parkway, Mountain View, CA 94043, USA

I am sorry to hear this.. I first heard about this was happening a month or so again, I was hoping due to the reasons you listed that this would not affect this extension.. :crossed_fingers:

@wjywbs This mail has reached every developer in the Chrome Webstore. I don't think it specifically targets your extension.


Bitfinex Api Improvements

PR contains:

Rework of payload building and signing
Ticker error handling
Request rate error handling
Some PEP-8 and pylints fixes

PR should solves:

#447, #466, #471 : Exceptions will catched now and ticker retrieving continue whit next currency. No changing time when an error occurs or ticker list is empty.
#484: Now conversion rates are shown for all currency with active lending positions.
#490: I implemented not a limitation but now additional sleep time is added like with Poloniex.

PR makes following PRs obsolete:

#463, #476

TESTING STAGE
I tested it for more than 2 days without any issue. But please test it too esp. to catch rare issues, like the ticker problem.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read CONTRIBUTING.md
[x] I fully understand Github Flow.
[x] My code adheres to the code style of this project.
[ ] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
[ ] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
[x] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

Does this also solved the ticker issue? @mahiso @utdrmac

His PR seems very similar to one of my other fixes so it'll probably be fine. I will swap out my bitfinex code for this PR and give it a run.

Nope. Within 30 seconds:
[root@gasgiant bitfinex]# python lendingbot.py
Starting WebServer at <IP_ADDRESS> on port 8001 with template www
Welcome to Lending Bot on BITFINEX
Started WebServer, lendingbot status available at http://<IP_ADDRESS>:8001/lendingbot.html

2017-08-30 09:26:07 Error USD_ETH
Traceback (most recent call last):
  File "lendingbot.py", line 94, in <module>
    Lending.lend_all()
  File "/usr/src/bitfinex/modules/Lending.py", line 234, in lend_all
    usable_currencies += lend_cur(cur, total_lent, lending_balances, ticker)
  File "/usr/src/bitfinex/modules/Lending.py", line 431, in lend_cur
    raise msg
KeyError: u'USD_ETH'

Unhandled error, please open a Github issue so we can fix it!

The problem is here: https://github.com/mahiso/poloniexlendingbot/blob/ecdd54df156f0808634bcfc5f9f9e5186a54655a/modules/Bitfinex.py#L243
self.return_ticker() doesn't return what is needed and therefor the ticker array doesn't have all the information.

@mahiso #463 is still needed. Otherwise, on first run, self.usedCurrencies is empty and the for-symbols that follows doesn't add any ticker data to the array and then you get the missing key error above.

Hrm. Not sure why this is actually an issue. If you look at the main loop, it does this:
 Lending.transfer_balances()
 Lending.cancel_all()
 Lending.lend_all()

transfer_balances does call api.return_available_account_balances but for ('exchange') values. That's fine.
Next is cancel_all() which DOES call api.return_available_account_balances('lending') which SHOULD update self.usedCurrencies at this time but does not.

Hrm. Something is going out of order. return_ticker was called before cancel_all

Data.update_conversion_rates is the first thing called, which calls ticker_response = api.return_ticker() which as an empty self.usedCurrencies which returns an empty ticker (initially), but also caches the empty ticker for 60 seconds.

Two proposed solutions:
diff --git a/modules/Bitfinex.py b/modules/Bitfinex.py
index 6415b8b..b7b3332 100644
--- a/modules/Bitfinex.py
+++ b/modules/Bitfinex.py
@@ -133,6 +133,9 @@ class Bitfinex(ExchangeApi):

         setTickerTime = True

+        if len(self.usedCurrencies) == 0:
+            _ = self.return_available_account_balances("lending")
+

or
Move Lending.cancel_all() to fire before Data.update_conversion_rates
Either of those will cause usedCurrencies to be populated when return_tickers() is called.

Now I have it... I had always set analyseCurrencies=ACTIVE. And this calls before the main loop return_available_account_balances
MarketAnalysis.init
-> config.get_currencies_list()
-> ACTIVE -> Data.get_lending_currencies()
-> api.return_available_account_balances()
return_available_account_balances() is now called in api's init.

Thanks! re-pull'd PR. testing.

Looking good so far. Would be nice if it could gracefully handle some errors better:
Unhandled error, please open a Github issue so we can fix it!
2017-08-31 15:31:02 Error ('Connection aborted.', error(104, 'Connection reset by peer')) Requesting https://api.bitfinex.com/v1/credits
Traceback (most recent call last):
  File "lendingbot.py", line 90, in <module>
    Data.update_conversion_rates(output_currency, json_output_enabled)
  File "/usr/src/bitfinex/modules/Data.py", line 84, in update_conversion_rates
    total_lent = get_total_lent()[0]
  File "/usr/src/bitfinex/modules/Data.py", line 44, in get_total_lent
    crypto_lent = api.return_active_loans()
  File "/usr/src/bitfinex/modules/Bitfinex.py", line 122, in return_active_loans
    bfxResp = self._post('credits')
  File "/usr/src/bitfinex/modules/Bitfinex.py", line 78, in _post
    return self._request('post', payload['request'], signed_payload, verify)
  File "/usr/src/bitfinex/modules/Bitfinex.py", line 71, in _request
    raise ex
ConnectionError: ('Connection aborted.', error(104, 'Connection reset by peer'))

@utdrmac could easily add a catch for all ConnectionError here:
https://github.com/BitBotFactory/poloniexlendingbot/blob/master/lendingbot.py#L104

@mahiso any thing else before this is merged?


Cannot join slack ISSUE

the slack link at  http://slack.libgit2.org/ does not work

this image is showing what error is returned

any help would be appreiciated since i have questions about libgit2 and cant find any help to resolve the issue on the internet and was hoping for some guidance.

slack works now, just successfully joined. Dunno if slack fixed an issue or the libgit team.


Spinning-Rotating 2D Lidar

Hi!
Thank you for this project!
I would like to ask, the imu is on the rotating-spinning lidar or on base robot frame?
Thank you!

I'm not sure exactly what you're asking for. There's no specific support for a rotating planar LIDAR at the moment, see #40.
If you're referring to sample data, the URDFs, which describe the sensor configuration, are available for everything. We have no sample data with a rotating planar LIDAR.

Thanks for the response!
I mean a rotating Hokuyo 30LX.

In that case, there's no special support for that currently. You can configure it however you see fit. Refer to #40 for suggestions on how use the data with Cartographer.


Support to Full Calendar v2

Hi all,
In case you didn't know, a v2 beta of the Full Calendar has been released last month, and i was wondering whether a new branch could/should be started aiming to support the v2? FYI, compatibility with the 1.x versions has been broken.
You will find the improvements brought by the v2 here:
http://arshaw.com/fullcalendar/wiki/Upgrading-to-2/
Mehdi-Loup

+1 for me

1 for me


Support /get_block endpoint

Hey guys! I wanted to ask if /get_block endpoint is going to be supported/is planned for implementing anytime soon?
If not, what work could be done to implement this or help you with that?
I'm willing to contribute to the repo, any guidance would be much appreciated :)

Hi! Are you getting any issues with this endpoint? It is implemented and working
https://github.com/Shard-Labs/starknet-devnet/blob/2eab61e6262c6955cb6b3c37ba39c643aaa40686/starknet_devnet/server.py#L85

Issue resolved outside of github


[Epic]: Optimise first load time

Objective
Optimise and serve the javascript efficiently to reduce the first load time for users on a slow connection.
There are 4 stages to a page load

Orange status bar appearing, this starts after the blocking css and main chunk are loaded.
A 5MB chunk of javascript is loaded, after this we see the editor header.
A 4MB Js chunk is loaded, after this we see the spinner.
Execute calls are made, evaluations happen and we paint actual data in screen.

Median mobile internet speed is 8Mbps, on a connection like this it takes 20seconds to show the spinner and make the user defined API calls.
Goal is to bring that down to 5 Seconds.
| Editor Header | Spinner
-- | -- | --
8Mbps | 10 | 18
16Mbps | 6 | 10
Second load | 2.5 | 4
With Gzip Enabled
8Mbps | 5 | 8
16Mbps | 4 | 6
Note:

These tests are run on a throttled broad band connection, real world mobile connections are usually more erratic and slower.
With cache headers set, the number will be similar to second load above for returning users.
Numbers above will be updated after we automate the measurement.

Success Metrics

Goal
Metric

Bring the first load time for users on slow connections under 5 seconds
Customer satisfaction score increases

Optimise view mode
Our customers users will love the app, and our customer will recommend Appsmith

Stretch, optimise navigating between pages
Users are able to build their apps faster and navigation is upto their speed

Requirements

Requirement
User Story

Automate testing
Write a test to automate this testing to save developers time

Optimise chunking
Optimise chunking and serve essential code on priority

Separate editor specific code
Editor code is not required on the view mode, don't serve it

Optimise TTFB for internal API's
TTFB for some internal API's is high, optimise them, may be cache them in redis?

Serve static resources efficiently
Set expiry headers and enable gzip

Documentation
No response
Out of Scope

Optimising the rendering performance

Developer Handoff Document in Figma
No response
RACI matrix

Responsible
@SatishGandham

Accountable
@SatishGandham

Consulted
@riodeuno , @mohanarpit, @areyabhishek

Informed
@somangshu

[ ] Identify essential code and find a way to customise the chunks with it.
[ ] Log performance runs data to a persistent storage.


POST commands to container in DIND not supported?

On the PWD site, i setup the following Ethereum JSON RPC server (https://github.com/ethereum/wiki/wiki/JSON-RPC#web3_clientversion), here are the commands I used to install:
apk add --update nodejs
npm install ganache-core -g
sudo npm install ganache-core -g
sudo npm install ganache-cli -g
docker run -d -p 8545:8545 trufflesuite/ganache-cli:latest
At this point, the port shows up as expected. My instance ID:
https://labs.play-with-docker.com/p/bdeaqvkhlgn000f8q2b0#bdeaqvkh_bdear0khlgn000f8q2bg
I try to curl POST request:
curl -X POST --data '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":67}'  http://ip172-18-0-3-bdeaqvkhlgn000f8q2b0-8545.direct.labs.play-with-docker.com
I don't get the expected response, instead I get:
curl: (52) Empty reply from server
When I use the same commands against a Docker container on my local machine or AWS instance [not in PWD infrastructure], the POST command works fine and returns results as expected:
{   "id":67,   "jsonrpc":"2.0",   "result": "Mist/v0.9.3/darwin/go1.4.1" }
On the same PWD instance, I can launch an nginx container:
docker run -d -p 8080:80 nginx
and CURL successfully with a PUT request.
Are POST commands routed into the PWD infrastructure?
I'm assuming yes, but wanted to check if there are any special considerations that I'm missing.

Sorry, but we don't provide support for custom projects. We just can't allocate the time to test them


The "r" key (Dvorak) will double type the character

I've noticed recently that my keyboard will sometime double type the r character using the custom dvorak layout (the o character in QWERTY).  It appears to only be this specific character on all layers I've defined including the numpad (the 9 character).
  I'm curious if there's a firmware issue or if there's something that I can do to debug this.
My specific keyboard settings can be found here: https://github.com/mertzjames/Adv360-Pro-ZMK-Dvorak

Hi James,
That sounds more like dirt/debris in the key switch then a firmware issue. Try some canned air. Would be worth while reverting to a different version of firmware also and seeing if the problem persists.
If it does, please submit a trouble ticket to us and we can issue an RMA
https://kinesis-ergo.com/support/contact-a-technician/

This definitely sounds like a hardware issue, I'm aware that certain mechanical switches are bouncy enough to cause problems with the stock debounce settings (Boba U4 switches) but this would only be a concern if you got a signature series 360 pro from upgrade with those switches fitted and it wouldn't be limited to only one key. Closing as unplanned


Squad Leader for Military Operations - post PPT & video for Ops Server release

@garys-esri - check email reminder for details of what goes where.

Posted slides, video, and script in internal directory


how does flutter implement jetpack

io18 just announced Android Jetpack https://developer.android.com/jetpack/
which simplifies and implements best practices for modern android development, along with kotlin and kotlin-ktx. my question is that when flutter generates android apps, does it also apply those best practices to ensure better quality apps? or does flutter just have their own independent architecture?

maybe this question clarifies in detail what I want to actually know. :) https://www.reddit.com/r/androiddev/comments/8j6jju/kotlin_with_jetpack_or_flutter_which_one_is/

Sorry I don't have a Reddit account.
I found a video about some of the new jetpack features :
https://www.youtube.com/watch?v=IrMw7MEgADk
I think there is no competition - Flutter is easier for a beginner to get started with.
The flutter tutorials I have viewed have been straightforward to follow :
https://www.youtube.com/watch?v=CEPCGXQ7IQg

yes I already watched these sessins from io 18 but still thanks :) @Rockvole  I just want some technical insights between two technologies because I dont wanna choose 1 of them , build my complex app on it and later on regret that I didnt choose the other better option and then migrating would be very tough, so I want to choose best option before hand.

There are probably not many people who know both of those well right now. Maybe just a few people in google, and they don't want to say anything bad about another project.
You can assume you can do anything its possible to do using jetpack and android native - so you wont have any restrictions. It would probably be easier to ask a few questions about whether flutter can do what you need. There are a lot of experts on the flutter gitter you can ask :
https://gitter.im/flutter/flutter

I do think the poster raises an interesting point. It took Android a long time before it introduced an "opinionated" framework (Jetpac) that provided a canonical architecture, separation of concerns and better testability, all helping to avoid Android's many pitfalls. When I look at Flutter examples, I'm concerned that history is repeating itself. I realize there are many competing architectures and approaches (MVP, MVVM, MVC, ...), but it might be useful for the team to start encouraging appropriate separation of concerns.

also am not sure if this is relevant but introducing functional programming into the mix will make the code less error prone and even more testable and many more benefits which only a FP expert can tell ( which I am not ) dart does look like a language relevant to FP, so if flutter can also have a built in framework or even a separate one to just plug in like jetpack which encourages separation of concerns and maybe encourage functional programming, it can be beneficial for long term maintenance of the framework and also maintenance of the apps built with the framework

I think it would be better to raise individual issues for features you're missing.
I just had a brief look at the jetpack page linked in the initial comment, but it seems like a collection of features and tools from all kind of areas.
Requesting to add an "all-covering" framework to a framework seems to be a weird request to me.

I don't really understand the request here. We do intend to do the right thing on each platform, though we may not always yet do so. I recommend filing specific bugs on any issues that need work.


Immediate accessibility fixes for RWD: Learn Accessibility by Building a Quiz

Describe the Issue

[X] The "CSS" h2 and the textarea have the same id value. This is affecting screen reader users since this involves an input and associated label.
[ ] The logo in the upper left needs alt text. I would suggest it just be "freeCodeCamp".

Affected Page
A lot of them.
Your code
N/A
Expected behavior
- Either the "CSS" h2 or the textarea needs to use a different id value. Changing the textarea would probably be easier since its id is added after the h2 in step 39. This is actually one of those instances where the user can choose any value for the id and then we put our own value in there for the remaining steps. Resolved

Add alt text to the logo. Do we need to add an extra step for this or can we just add it to step 7?

Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

Seeing as the logo is non-functional, do we want the alt to be null? alt=""? If it does require an alt, then this should get its own step, and a clear description as to why it needs one should be given.
I suggest changing the id of the textarea (and associated label for) to question.

Per WCAG 1.1.1: Non-text Content, the logo does require alt text. Functionality isn't the deciding factor here, it's if the image conveys information (i.e. is not purely decorative), which this image clearly does.
Do we want to split this off into its own issue if we are going to create a new step?

Do we want to split this off into its own issue if we are going to create a new step?

I would say yes, but it is not fun to deal with the merge conflict, when two PRs are opened at the same time.

The logo still needs an alt text.
The logo is introduced in step 7: https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-accessibility-by-building-a-quiz/step-7
That step should be updated to instruct campers to give the img an alt text of freeCodeCamp. The seed code in all subsequent steps should be updated to include that new attribute.

@naomi-lgbt hey may i work on this issue? if so please assign it to me

Hey @mehraTushar
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.
Issues labelled with help wanted or first timers only are open for contributions.
Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.


Ghostwriter 2.0.1 doesn't recognize theme

It seems after getting to version 2.0.1 of ghostwriter this theme doesn't work.
inxi output:

CPU: Quad Core AMD Phenom II X4 810 (-MCP-) speed/min/max: 1900/800/2600 MHz  Kernel: 5.12.9-1-MANJARO x86_64 Up: 4d 1h 22m Mem: 5744.5/16009.8 MiB (35.9%)  Storage: 7.74 TiB (51.4% used) Procs: 274 Shell: fish inxi: 3.3.04

Screenshots:

It appears after creating my own, they use JSON now in this format:
{     "dark": {         "accent": "#575b5f",         "background": "#282a36",         "block": "#bd93f9",         "cursor": "#3daee9",         "emphasis": "#f1fa8c",         "error": "#ff5555",         "foreground": "#f8f8f2",         "heading": "#ff79c6",         "link": "#8be9fd",         "markup": "#50fa7b",         "selection": "#93cee9"     },     "light": {         "accent": "#bdc3c7",         "background": "#eff0f1",         "block": "#31363b",         "cursor": "#3daee9",         "emphasis": "#31363b",         "error": "#da4453",         "foreground": "#31363b",         "heading": "#31363b",         "link": "#3daee9",         "markup": "#bdc3c7",         "selection": "#93cee9"     } }

I can confirm that the original theme does not work on a fedora34 box with ghostwriter 2.0.2 either.
However, using the current instructions, I was equally as unable to make it work with the JSON one that you put together @GregTheHun , placing it in ~/.config/ghostwriter/themes/dracula/theme.cfg (I even tried renaming it to .json there) - ghostwriter simply doesn't see anything from the themes' subdirs.
What did work for me was placing a <theme-name>.json (i.e. dracula.json, .cfg didn't work) directly in the ~/.config/ghostwriter/themes directory.

@GregTheHun Sorry for the late response. I do not use ghostwriter often anymore. The update to 2.0.0 broke the compatibility of this theme with ghostwriter as the theming system got completely redesigned.
I just updated the theme with PR #3. Please check if this works for you.
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf I also updated the installation instructions, so please take a look at them as long as the Dracula Theme website has not yet been updated.
If you're still having problems installing the theme please just ping me here.

@GregTheHun Sorry for the late response. I do not use ghostwriter often anymore. The update to 2.0.0 broke the compatibility of this theme with ghostwriter as the theming system got completely redesigned.
I just updated the theme with PR #3. Please check if this works for you.
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf I also updated the installation instructions, so please take a look at them as long as the Dracula Theme website has not yet been updated.
If you're still having problems installing the theme please just ping me here.

hey, thanks for the update.
in the meanwhile (fedora 35 + ghostwriter 2.1.0) I have been using a manually added Dracula colorscheme.
I can confirm that having Dracula.json in ~/.config/ghostwriter/themes (I even have it symlinked from the folder where I have the repo cloned and I kept up to date) shows an option in the app (as per installation instructions), both the dark and the light mode work.

Thanks for your response! Glad you made it work in the meantime.
I'm going to close this issue then.


error: Found argument '--disable-cache' which wasn't expected, or isn't valid in this context

Looks like wasmtime doesn't support that flag in the MakeFile. Currently I am removing those flags but was wondering if I am doing something wrong on my end?

Different wasmtime version, I assume. CI is using the one from NixOS, which is still at 0.21.0 it seems. Just remove the flag locally while working on this.

Changes I made https://github.com/dfinity/motoko-base/compare/master...cybrowl:bugfix/wasmtime_run?expand=1

That fixed the problem but not sure what cranelift does

Getting a newer wasmtime onto our CI requires someone to bump it in nixpkgs: https://github.com/NixOS/nixpkgs/pull/109571

That will be me, probably! I am trying wasmtime-0.32.0 as we speak: https://github.com/dfinity/motoko/pull/3009.

@cybrowl I made https://github.com/dfinity/motoko-base/pull/320 from your patch. Thanks a buch!
We can discuss further steps over there.


libGLESv2.so doesn't work in raspbian stretch

Hi,
I'm running into this issue, as outlined in https://www.raspberrypi.org/forums/viewtopic.php?t=191857
pi@raspberrypi:~/vol_overlay $ sudo python vol_overlay.py Traceback (most recent call last):   File "vol_overlay.py", line 3, in <module>     from display_bcm import Display   File "/home/pi/vol_overlay/display_bcm.py", line 21, in <module>     cdll.LoadLibrary("/opt/vc/lib/libGLESv2.so")   File "/usr/lib/python2.7/ctypes/__init__.py", line 440, in LoadLibrary     return self._dlltype(name)   File "/usr/lib/python2.7/ctypes/__init__.py", line 362, in __init__     self._handle = _dlopen(self._name, mode) OSError: /opt/vc/lib/libGLESv2.so: cannot open shared object file: No such file or directory
Any easy fix for this?

You could try changing the libGLESv2.so to libbrcmGLESv2.so on this line?
https://github.com/meekys/vol_overlay/blob/master/display_bcm.py#L21
If that isn't enough, you could try changing lib%s.so to libbrcm%s.so on this line too?
https://github.com/meekys/vol_overlay/blob/master/display_bcm.py#L21

Hey meekys, this worked thanks! I will close this one but I have another question so will open another one


Extract estimated noise

Hi!
First off, excellent paper and code! I learnt a lot about SE from the paper and find your code very well structured and clear. Thank you!
 I have experimented a little with the code but not got been able to extract the noise. Is this supported by the model structure, and if so, how?
Kindest wishes.

Thanks for your interest! I think you can get the estimated noise by doing output minus input, since the noise is additive. Specifically, estimated noise = x - net(x), but make sure the input is normalized.

Thanks Ruiz, turns out that the normalization was the missing ingredient. Just in case you're interested, the reason I seek the noise is to perhaps apply RemixIT to the model such that I can try unsupervised domain adaptation.
Again, I learned a lot from the paper. So thanks for your work!


Color changing when using saturation in HSL mode

What I did:

Opened a color picker (chrome on Android)
Switched to HSL
Moved around the color
Moved the saturation
Noticed that it changed the color to red

Fixed ! thx :)


Is This Still Being Worked on?

wondering if this is being kept up to date with Gmod :)

Yeah, its working!


chore: refine lifetime for rotate_last_mut

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
For rotate_last_mut only apply for &self.buffers, restricting the lifetime of the closure parameter &mut Vec<_> to outlive the &mut self parameter of the function is okay.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)
#5119
#6025

Why are there 2 commits on the main branch? 🤣


F5 appsvcs throwing 404 when the admin user is disabled (URI:/mgmt/shared/appsvcs/info)

Environment

Application Services Version: 3.36.0/3.37.0/3.38.0/3.39.0
BIG-IP Version:  <IP_ADDRESS> (Hosted on Azure)

Summary
F5 AppSvcs is throwing 404 when the admin user is disabled. URI is /mgmt/shared/appsvcs/info which is required by the F5 CIS to function.
Steps To Reproduce
Disable the admin user by navigating to System -> Platform ->User Administration -> Disable default admin, use alternate.
Optionally restart the services by running bigstart restart restjavad restnoded
Issue is not seen when the admin user is enabled.
Observe the following error response:
curl -k -s -u 'testuser:pass' https://<IP_ADDRESS>/mgmt/shared/appsvcs/info  | jq .
{
  "code": 404,
  "message": "",
  "referer": "<IP_ADDRESS>",
  "errorStack": []
}

Expected Behavior
curl -k -s -u 'testuser:pass' https://<IP_ADDRESS>/mgmt/shared/appsvcs/info | jq .
{
  "version": "3.38.0",
  "release": "4",
  "schemaCurrent": "3.38.0",
  "schemaMinimum": "3.0.0"
}

Actual Behavior
GET request to /mgmt/shared/appsvcs/info is failing.
curl -k -s -u 'testuser:pass' https://<IP_ADDRESS>/mgmt/shared/appsvcs/info  | jq .
{
  "code": 404,
  "message": "",
  "referer": "<IP_ADDRESS>",
  "errorStack": []
}

tail -f restnoded/restnoded.log

Tue, 20 Sep 2022 12:02:03 GMT - finest: socket 193 opened
Tue, 20 Sep 2022 12:02:03 GMT - severe: [RestOperationDispatcher] 'shared/appsvcs/info' not found.
Tue, 20 Sep 2022 12:02:03 GMT - severe: [ErrorHandlingModule] RestOperation failed: "/shared/appsvcs/info". {"code":404,"message":"","referer":"<IP_ADDRESS>","originalRequestBody":"","errorStack":[]}
Tue, 20 Sep 2022 12:02:04 GMT - config: [RestWorker] /shared/appsvcs has started. Name:RestWorker
Tue, 20 Sep 2022 12:02:11 GMT - finest: socket 193 closed
Tue, 20 Sep 2022 12:02:14 GMT - finest: socket 194 opened

Hi @uts09, does testuser has administrative role based access? Please find this article for prerequisites & requirements for using BIG-IP AS3. https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/userguide/prereqs.html

Yes, testuser has admin privileges.

Thank you. I have added this issue to our internal product backlog as AUTOTOOL-3470

HI @uts09, would like to put a name to AUTOTOOL-3470 internally. Please can you reach out to us at<EMAIL_ADDRESS>so we can prioritize.

This will be in 3.42, but you will need to bigstart restart restjavad restnoded after disabling the default admin user

This has been resolved in the 3.42.0 release of AS3.


Error 400

Since a few day there is "Error 400" an Fedora 36.
https://support.deepl.com/hc/en-us/articles/360020031740-Error-code-400

fixed, i used wrong parameters.


Commented CSS import in <script> is used.

Environment

Operating System: Darwin
Node Version:     v16.20.0
Nuxt Version:     3.5.2
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      vite, build
Runtime Modules:  -
Build Modules:    -

Reproduction
Repo: https://github.com/ThornWalli/nuxt-testing/tree/feature/comment-css-import
npm i
npm run generate

To compare, look in the file .output/public/index.html.
Vite Config
{
  vite: {
      build: {
          cssCodeSplit: false
      }
  },
}

Describe the bug
Although the import is commented, it is still implemented as a style tag in the page.
https://github.com/ThornWalli/nuxt-testing/blob/29548464d6c4bf21dc15cd26323adccd4199d2d5/pages/index.vue#L7-L11
Additional context
No response
Logs
No response

This has been resolved upstream in mlly.


bug: case sensitive check for the headers in the Access-Control-Request-Headers

The code here expecting that the allow_headers and request_headers are the iterables with strings in the same registry
response.access_control_allow_headers = HeaderSet(
    set(allow_headers).intersection(set(request_headers))
)

Instead there should be used smth like this
response.access_control_allow_headers = HeaderSet(
    allow_headers.as_set().intersection(request_headers.as_set())
)

Fixed in 458afde4632a3de22bf66bb6287d7c274c032c9a


[Bug] Unable to correctly specify multiple additional workers with unique groupnames in ray-cluster helm chart

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
Others
What happened + What you expected to happen
When trying to specify some additionalWorkerGroups: in a a ray cluster helm chart i could not get the correct syntax to specify more than one, or indeed have a different group name other than "smallGroup" to mach the values.yaml.
Is there a way to specify different and multiple additional group names?
Attempting to run (with attached zip):
helm install raycluster kuberay/ray-cluster --version 0.5.2 -f raycluster_autoscaling_multi_group.yaml -o yaml --dry-run

producedError: INSTALLATION FAILED: YAML parse error on ray-cluster/templates/raycluster-cluster.yaml: error converting YAML to JSON: yaml: line 74: could not find expected ':'

If i remove the 2nd entry and just have one additionalGroup called smallGroup, then it matches the values file entry and succeeds.
Reproduction script
raycluster_autoscaling_multi_group.yaml.zip
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Just coming across this issue and noting that it still exists in chart version 0.6.0

Just coming across this issue and noting that the bug still exists in chart versions 0.6.0 and 1.0.0

Confirm. I have the same issue with 1.0.0 - I can't create an additional worker group with the name different from smallGroup

I was trying to rename smallGroup to defaultGroup and get the same error. chart version 1.0.0

Closed this issue because it has been fixed in some version between v0.5.2 and v1.2.2
Running helm install raycluster kuberay/ray-cluster --version 1.2.2 -f raycluster_autoscaling_multi_group.yaml -o yaml --dry-run with the following yaml does not raise error.
image:
  repository: rayproject/ray
  tag: 2.5.0-gpu

common:
  containerEnv: []

head:
  rayVersion: 2.5.0
  enableInTreeAutoscaling: true
  autoscalerOptions:
    #upscalingMode: Default
    idleTimeoutSeconds: 120
  resources:
    limits:
      cpu: "500m"
      memory: "512Mi"
    requests:
      cpu: "500m"
      memory: "512Mi"
  nodeSelector:
    controller.nodeSelector.node.kubernetes.io/instance-type: "t3.xlarge"
  containerEnv: []

worker:
  containerEnv: []
  groupName: general
  replicas: 1
  minReplicas: 0
  maxReplicas: 4
  resources:
    limits:
      cpu: "1"
      memory: "2G"
    requests:
      cpu: "1"
      memory: "2G"
  nodeSelector:
    controller.nodeSelector.node.kubernetes.io/instance-type: "t3.xlarge"

additionalWorkerGroups:
  myGPUGroup:
    disabled: false
    containerEnv: []
    replicas: 0
    minReplicas: 0
    maxReplicas: 3
    resources:
      limits:
        cpu: 3
        memory: "14G"
      requests:
        cpu: 3
        memory: "14G"
    nodeSelector:
      controller.nodeSelector.node.kubernetes.io/instance-type: "g4dn.xlarge"

  anotherGPUGroup:
    disabled: false
    containerEnv: []
    replicas: 0
    minReplicas: 0
    maxReplicas: 3
    resources:
      limits:
        cpu: 14
        memory: "54G"
      requests:
        cpu: 14
        memory: "54G"
    nodeSelector:
      controller.nodeSelector.node.kubernetes.io/instance-type: "g4dn.4xlarge"


[Definition, Definition Table] Display object data using DictList and array data using TextList

Is your feature request related to a problem? Please describe.
object, array data was not readable.

Describe the solution you'd like
Display object data with Dict component. (Not developed yet.)
Display array data with TextList component. (It's console component now, but must be moved as mirinae component)
Describe alternatives you've considered
Additional context
Dict component is not developed yet. Must be developed after this issue.

This issue has beeb resolved.

This issue has beeb resolved.


Support batch deletion

Description:
Support batch deletion: https://github.com/ARK-Builders/ARK-Memo/issues/47
Screenshots:

SVID_20241022_213104_1.mp4

[ ]  Long click must select the item
[ ]  Back button should deselect all
[ ]  Switch off screen after selection and all checked states are lost

SVID_20241023_153320_1.mp4

[ ]  Ripple should have shape of the note item. Observe carefully

@shubertm These issues have been fixed.
Could you please verify again?
Thanks.

Good work @tuancoltech

Good work @tuancoltech
SVID_20241029_103736_1.mp4

[ ]  While in selection mode, clicking a note should add it to selection not open it. Opening should happen out of selection mode.

@shubertm This has been fixed. Please help check again!

https://github.com/user-attachments/assets/e4c31afd-b43e-49f2-9a0e-e51047f33ad3

[ ] Ripple goes below extra view on notes with previews. In other versions it is ok

SVID_20241114_062853_1.mp4

[ ]  Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is.
Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

SVID_20241114_062853_1.mp4

[ ]   Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is. Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

Yes, exactly

SVID_20241114_062853_1.mp4

[ ]    Ripple goes below extra view on notes with previews. In other versions it is ok

@shubertm I haven't been clear what the issue is. Do you mean, the ripple is partially below the graphic thumb, while it should be on top of it?

Yes, exactly

@shubertm It's fixed. Please check again.

Looks good

@shubertm Have you done with QA?

Looks good

@shubertm Have you done with QA?

QA not done, wait for the label


fix: reset default grimoire preference

The super(tasks); call in the constructor instantiates grimoire's default propertyManager that the declared propertyManager was shadowing; this means that in the destructor, super.destruct(); actually destroyed the shadowed one instead of the default one, and the defaultSettings in grimoire were assigned and never removed.
Among other things, this means that logPreferenceChange is set to true and never unset.
Move things around so that shouldn't happen.

Okay, that fixes the issue, but seems to break setting choice for wandered zones :/

You need this.propertyManager = propertyManager as part of the constructor

If you have that, it shadows the grimoire-created one, which was already populated earlier in the constructor.

So, to be explicit about the issue:

CandyEngine constructor runs
this calls super() which means Engine constructor runs
constructor calls this.initPropertiesManager(this.propertyManager); which populates the default property manager with default settings
CandyEngine constructor later sets this.propertyManager to the static it declared earlier
When the destructor runs, it calls Engine's destruct, which clears this.propertyManager.. but this clears the static, and not the default one, because it was overwritten in CandyEngine's constructor

Ideally I guess grimoire would expose a constructor for Engine that lets you pass in a property manager.

Obsoleted by #39.

Superceded by #39, but we should make the aforementioned grimoire changes long-term


Fix issue

Pull Request Type
What kind of change does this PR introduce?
[x] Solved an issue/task
[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: [#1441]
What is the new behavior?

Converts temperatures between Fahrenheit and Celsius.
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


App name

We are big fans of the work you are doing here and want to support third party clients as much as possible. We do request that third party apps avoid using the name Jellyfin in the name of the app. This is just to try to make it clear for users that the app is not an official project so any issues, feedback, etc. get directed to the right place. Thanks!

@thornbill again, this is a fair request and I probably should have seen this coming 😅. If it's okay with you, I will need to take some time to dream up a name hits all the right SEO spots and integrate it in the app itself.

👍 I would just say preferably before you release on the App Store. I just wanted to bring it up now so hopefully it won’t be too much of a headache.

@leinelissen good luck with the SEO efforts, I'm pretty sure every possible variation of JellyX or jf-x is taken by now :laughing:

👍 I would just say preferably before you release on the App Store. I just wanted to bring it up now so hopefully it won’t be too much of a headache.

That works for me. The headache is mostly in losing that sweet sweet SEO haha. I'll get over it :)

Closing this as v2.0.0 changed the app name to Fintunes. It's also on the App Store now.


Require constant() for large constants and fix a type resolving bug

@lesters please review

Bugfix -> merging


The golang go mod zed editor dependency package check is not updated

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
The golang go mod zed editor dependency package check that it has not been updated, in fact it has already been updated. Turn it off and back on to display no red underline normally
Environment
golang 1.20
macos 12.7
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.
No response

@ConradIrwin, for go knowledge.

Duplicate of #1342, I think?
If another tool (commonly go mod tidy) updates go.mod, zed does not notice until you restart the language server

How is vs code implemented?

I think the bug comes about in Zed because we do not inform the LSP of file changes on the file-system that we did not make.
It is definitely something we need to fix though.

thinks.


Revert "Add cy8cproto 062 4343w"

Reverts ARMmbed/mbed-os-example-pelion#70
This target no longer compiles after update to Mbed OS 5.15

Thanks for your changes.
@ARMmbed/pdmc-integrators please review.

build-only

build-only

Test run: SUCCESS

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/


Request - post list of servers

Hi! If anyone installs your software on their server, would it be possible to post a list of available sites for people to use instead of sharenews.ca? Unfortunately, I don't have access to a compatible web server to install the software.
Thanks.

Good idea. I have added information on how to view and submit servers to the Public Access Servers list in the README.md.