Crash on [SDWebImageDownloaderOperation reset]_block_invoke

[X] I have read and understood the CONTRIBUTING guide
[X] I have read the Documentation
[X] I have searched for a similar issue in the project and found none
I got this crash twice. Unfortunately cannot reproduce it.
Just can provide info from Fabric.
Issue Info

Info
Value

Platform Name
iOS

Platform Version
10.3.1

SDWebImage Version
4.0.0

Integration Method
Cocoapods

Xcode Version
Xcode 8.0

Repro rate
twice

Repro with demo prj
cannot reproduce

Demo project link
cannot reproduce

Issue Description and Steps
Crashed: com.hackemist.SDWebImageDownloaderOperationBarrierQueue
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x000000092a29beb8
0  libobjc.A.dylib                0x184424150 objc_msgSend + 16
1  SDWebImage                     0x1013d31e0 __38-[SDWebImageDownloaderOperation reset]_block_invoke (SDWebImageDownloaderOperation.m:227)
2  libdispatch.dylib              0x1848669e0 _dispatch_call_block_and_release + 24
3  libdispatch.dylib              0x1848669a0 _dispatch_client_callout + 16
4  libdispatch.dylib              0x184878578 _dispatch_queue_concurrent_drain + 1372
5  libdispatch.dylib              0x18486a2d4 _dispatch_queue_invoke + 892
6  libdispatch.dylib              0x184876a50 _dispatch_root_queue_drain + 540
7  libdispatch.dylib              0x1848767d0 _dispatch_worker_thread3 + 124
8  libsystem_pthread.dylib        0x184a6f1d0 _pthread_wqthread + 1096
9  libsystem_pthread.dylib        0x184a6ed7c start_wqthread + 4
Also downloaded crashreport from Apple
- (void)reset {
    dispatch_barrier_async(self.barrierQueue, ^{
        [self.callbackBlocks removeAllObjects]; // crash is here
    });
    self.dataTask = nil;
    self.imageData = nil;
    if (self.ownedSession) {
        [self.ownedSession invalidateAndCancel];
        self.ownedSession = nil;
    }
}

This is very strange, will look into it.

Also experiencing this issue!

We are facing same issue.

Also facing this issue.

I come a cross to this issue in pressure test frequently

Same issue here! Caught using Fabric.io Crashlytics during a user session.
Issue Info:

Platform Name:	         iOS
Platform Version:	        10.3.1 (14E304)
SDWebImage Version:	4.0.0
SDWebImage/Core:       4.0.0
Integration Method:      Cocoapods
Device Version:	       iPad Mini 2
Repro rate:	               Once so far (just pushed to TestFlight last night).
Repro:                          Caused when scrolling fast through a table of images. Each table cell's image is retrieved from the cloud and saved into mem via SDWebImage when the cell is loaded.

Methods used in tableView 'cellForRowAt':

SDImageCache.shared().imageFromMemoryCache()  // First try to get from RAM.
SDImageCache.shared().queryCacheOperation()  // Then try to get from Disk.
SDWebImageDownloader.shared().downloadImage()  // Finally download from cloud.

Thread #0:
Crashed: com.apple.main-thread EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000004bbcbbeb8
0  libobjc.A.dylib                0x181a78150 objc_msgSend + 16
1  Foundation                     0x1839f29c8 +[NSConcreteNotification newTempNotificationWithName:object:userInfo:] + 132
2  Foundation                     0x1839f2904 -[NSNotificationCenter postNotificationName:object:userInfo:] + 40
3  SDWebImage                     0x100b5b2ec __47-[SDWebImageDownloaderOperation cancelInternal]_block_invoke + 72
4  libdispatch.dylib              0x181eba9e0 _dispatch_call_block_and_release + 24
5  libdispatch.dylib              0x181eba9a0 _dispatch_client_callout + 16
6  libdispatch.dylib              0x181ebf5e8 _dispatch_main_queue_callback_4CF + 996
7  CoreFoundation                 0x182fb10c0 _CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE_ + 12
8  CoreFoundation                 0x182faecdc __CFRunLoopRun + 1572
9  CoreFoundation                 0x182eded94 CFRunLoopRunSpecific + 424
10 GraphicsServices               0x184948074 GSEventRunModal + 100
11 UIKit                          0x189190130 UIApplicationMain + 208
12 AppName                       0x100048900 main (AppDelegate.swift:18)
13 libdyld.dylib                  0x181eed59c start + 4

Thread #9:
com.apple.NSURLConnectionLoader
0  libsystem_kernel.dylib         0x181fdf224 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x181fdf09c mach_msg + 72
2  CoreFoundation                 0x182fb0e88 __CFRunLoopServiceMachPort + 192
3  CoreFoundation                 0x182faeadc __CFRunLoopRun + 1060
4  CoreFoundation                 0x182eded94 CFRunLoopRunSpecific + 424
5  CFNetwork                      0x1836eaca4 +[NSURLConnection(Loader) _resourceLoadLoop:] + 404
6  Foundation                     0x183af62c8 _NSThread__start_ + 996
7  libsystem_pthread.dylib        0x1820c575c _pthread_body + 240
8  libsystem_pthread.dylib        0x1820c566c _pthread_body + 282
9  libsystem_pthread.dylib        0x1820c2d84 thread_start + 4

We also facing the same issue and the crash only happens in iOS 10 devices.

I used v4.1 facing same issue.

Do we have solution for this crash issue please?

👀 We have it also

Should be fixed by #1940 - closing for now

When will be released the 4.1.0 with the fix?

@lauramejiaarroyave 4.1.0 was just released.

@bpoplauschi I'm still seeing this crash after the changes in #1940 are applied.
Looking at the code in reset , shouldn't the block dispatched to dispatch_barrier_async be retaining a weak self?

@piercifani the problem is multiple crashes being almost randomly added to tickets :) so you're referring to the one at the top of this thread described by @EugeneGoloboyar. Indeed that can still happen. I will reopen this ticket and look for a fix.

@piercifani we can try to use a weakSelf reference in this case because the crash does look like a message sent to deallocated instance. Do you have any other info that might help us? Like a link to Crashlytics or whatever crash reporting tool you use? Frequency? OS versions ...

Here's the full stack trace out of Crashlytics (I redacted some info, off course)
com.hostapp.hostapp_issue_1165_crash_567b2d42fcb145f18709320b204a6a47_4fce22b77c1b11e784ae56847afe9799_0_v2.txt
It appears to be happening a lot more on iOS 10 than iOS 9 (99% vs 1%), Only 24% when "App In Focus" and all devices are experiencing this issue.

Thanks for the info @piercifani - it appears you are correct, we need a weak reference there. Probably a race-condition because otherwise I cannot explain how a strong reference to an object can lead to a "message sent to deallocated instance" crash.

@piercifani I made a commit 2f892f9 with the solution we talked about. Can you try it before we release 4.1.1 - this can take a few more days.

Thanks! I'll try this on my next release and let you know what I find

I can confirm that this made the crash disappear on Fabric/Crashlytics so I think it's safe to merge

Can we assign this to the 4.1.1 release and merge it?

@piercifani The commit 2f892f9 has already in the master branch. So when the 4.1.1 release, it will be right there.

Hi, I am facing the same crash issue in 4.1.0 release. When will be 4.1.1 available with this fix? I want to submit my app to app store.

@VidhyaJain we will release in a couple of days - sorry for the delay

4.1.1 is now released.

@bpoplauschi :Thanks for release

@VidhyaJain Please use 4.1.2 patch version instead of 4.1.1. We forgot a bug in 4.1.1 and fixed in 4.1.2(only with this fix and no extra feature changes)

@dreampiggy  Thanks! Will take 4.1.2


chore: add custGeom "custom geometry" to types for shapes

This PR adds the types needed to actually get TypeScript support when inserting custom geometry as shown in this demo: https://github.com/gitbrent/PptxGenJS/blob/master/demos/modules/demo_shape.mjs
@gitbrent Can we include this in a new release so we don’t have to monkey patch the types in our implementation?

Ping @gitbrent (!)

@gitbrent Ping :)


Regenerate recipe using grayskull.

The constraints in here were overly restrictive since the poettry constraints are caret ^ which translates to major compatible pins

@conda-forge-admin, please rerender

Thanks @mariusvniekerk!


Add alert with error when there is form submission error

User/group edit nicely have error messages for the fields, but its not super obvious that there was an error at the moment
Also add these potential error messages into the report/negotiation card along with the same error pop up

Added error pop up for all forms except report. Look into adding error tags to more fields in the negotiation card and report to continue this task


Timesheet - 20/04/2021 - Chrisha Canete

Task 1
Sending Payment for April 16, 2021
Proof of Work

https://docs.google.com/spreadsheets/d/1JozxnpNVRpV2kTVm_c28oIOwCqYOjiwVO0NVSMomT_A/edit#gid=0

Time Spent
1 hour

Task 2
finalizing Community Feedback Report (April 14-21,2021)
Proof of Work

https://docs.google.com/document/d/1ipDBiM9fZmry3ocb55_1SPCq1qyJBd4f8uJ6moz5-qo/edit#

Time Spent
.5 hour

Task 3
Making the April 17, 2021-TNB-Core Team Payment Calculation
Proof of Work
-https://docs.google.com/spreadsheets/d/1C4rfwWjwylXiT_u-CdpZoauj2_iBhjkdFo_KWlEF5dM/edit#gid=0
Time Spent
1 hour

Total Time Spent
2.5 hours
Account Number
a405669fd88dc7eaa3ec86e4b4164ca66dbd5f9befbdb5a89f0b28a5a1902dbe

Approved


Missing function central index

Hello,
/Users/apple/Documents/Range/Range/controllers/PropertyNearByViewController.swift:398:13: Value of type 'ScalingCarouselView' has no member 'currentCenterCellIndex'
when try to use your libraray as pod

Hi,
Are you using the latest release of the pod? Maybe you need to run 'pod repo update’.

On 1 Nov 2017, at 17:38, anshulmahipal<EMAIL_ADDRESS>wrote:
Hello,
/Users/apple/Documents/Range/Range/controllers/PropertyNearByViewController.swift:398:13: Value of type 'ScalingCarouselView' has no member 'currentCenterCellIndex'
when try to use your libraray as pod
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/superpeteblaze/ScalingCarousel/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCK6fZGckU5JskWr4xCrhp09uc8FukUks5syEoKgaJpZM4QOBQX.

I did already

And what do you see when you look in ScalingCarouselView? Is the property there?
Sent from my iPhone

On 1 Nov 2017, at 17:48, anshulmahipal<EMAIL_ADDRESS>wrote:
I did already
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

At time of download, I get the property but on time of download dependencies property is not there

The issue is now solved.
I have created a new release - v2.0.1. To get the latest, run the following:

pod repo update
pod update

You should see Cocoapods installing version v2.0.1.
Pete

On 1 Nov 2017, at 18:19, anshulmahipal<EMAIL_ADDRESS>wrote:
At time of download, I get the property but on time of download dependencies property is not there
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/superpeteblaze/ScalingCarousel/issues/16#issuecomment-341079688, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCK6SBoNr0BKGAjBE9Nz0-vmTt0TmlJks5syFO7gaJpZM4QOBQX.


support json openapi files, validate file formats more strictly during setup

test run reads like:

if needed, tool for converting yml to json https://www.browserling.com/tools/yaml-to-json

I've added a commit so you should re-review


Good

Go to moon

Mail received but not understood
On Mon, Jul 12, 2021, 11:02 AM herrie23 @.***> wrote:

Go to moon
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Aircoin-official/AirCash/issues/4, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUOFLHTGAEV2IZMBBUVW47TTXK4R7ANCNFSM5AGQFSLA
.

Thank's
Pada tanggal Sen, 12 Jul 2021 18:08, Chimnecherem @.***>
menulis:

Mail received but not understood
On Mon, Jul 12, 2021, 11:02 AM herrie23 @.***> wrote:

Go to moon
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Aircoin-official/AirCash/issues/4, or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AUOFLHTGAEV2IZMBBUVW47TTXK4R7ANCNFSM5AGQFSLA
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Aircoin-official/AirCash/issues/4#issuecomment-878148890,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQVTRJYLDS333JQ25OTPPKLTXK5JZANCNFSM5AGQFSLA
.

Thanks

Good Project

Good


Display suggestions when importing seed phrase

Please use Moonlight app as a reference.
Please improve the look of segmented controls.

https://github.com/AlphaWallet/alpha-wallet-android/issues/976

@tomekalphawallet to save you some effort, you only need to mention the issue/PR in a corresponding repo (Android/iOS) on one of them. ie. only mention Android issue in iOS repo, or vice versa. GitHub will link the other one for you.

 [1400] As a wallet user, I want to import my wallet's SEED phrase more readily, so that I'm not frustrated with typing long seed phrases

Only other requirement is that the dictionary is not a full english dictionary, but rather just the bip39

@hboon In above screenshot shows a number of counts so we need to add into ios or not.

@nimitparekh2020 keep it

Will implement and do commit.

@hboon Do you have enough to take over and close this issue?


4 Digit 7 Segment Display

May be an SPI component, may be I2C, may be DigitalOutput, answer is unclear. Unfortunately CrowPi does not have support for this component so code will have to be handled manually

@GreihMurray  comments
May be an SPI component, may be I2C, may be DigitalOutput, answer is unclear. Unfortunately CrowPi does not have support for this component so code will have to be handled manually


Updated information about media logging defaults

This includes a list of CPUs that should have media logging enabled by default.

Copy review - @dorichardson, kindly commit the suggested changes. Many thanks.

@JohanFreelancer9, committed the suggested changes, please let me know if there are any additional steps

@scanum @SerdarSoysal are there any additional steps needed to get this merged?

@scanum @SerdarSoysal ping to review please

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


modify_enchantment_damage_taken crashes the game if given to another entity (?)

Crashlog: https://gist.github.com/DaedalusGame/02093131962bbb4abe722ee969463fc8
I tested modify_enchantment_damage_taken with the same example as modify_enchantment_damage_dealt but swapped out the type, then i gave it to all entities with /power grant  @e and smacked an entity with a sharpness sword, crashing the game.

I simply forgot a null check here, will be fixed in 2.0.6.

Fixed in v2.1.0.


Fix flickering and column sizes.

Avoid flickering in default view mode, by properly setting the default (horizontal-scroll) layout
directly in CSS. This flickering was introduced with #675 pull request. This also fixes the layout
of the public board. Javascript is now used only to activate the 'compact' mode, thus still causing
a slight flickering, but in that mode only.
Use fixed-layout on the table to improve layout and rendering speed.
Slightly reduce the width of the swimlane header column, and make it fixed-width.
Slightly simplify the Javascript/jQuery code for activating compact mode.

This is replaces pull request #688, with only the table layout fix, since I have no proper solution
for the scrolling problem.

I still having the same issue as before due to the fixed layout of the table:

I don't see the flickering with my own boards, how many tasks do you have on your board?

This is fixed now, the header does not move anymore.
I have a board with more than 400 tasks (luckily, most of them in 'Done' or 'Backlog' columns :-) ), and i cannot miss the resizing of columns with Chrome on my Linux machine.
The other problem with this "large" board is that I need to scroll down to the bottom of the page to see the horizontal scrollbar. This is the problem I tried to fix as well in #688, causing the header regression. This patch addresses only the board layout/flicker issue, to avoid the header regression.

Thanks it's merged.
I see your point about the horizontal scrollbar. I didn't notice that because I use a macbook and I can scroll horizontally with the touchpad without using the scrollbars.


Thank You!

You have the only decent angular library seed project that exists. All others are lacking, broken, outdated, or over-complicated in some way. I hope you keep up with this project because the world needs it.

Thank you for these words @wgwine! Unfortunately there is not too much time I have for this project at the moment...


Should there be an impl std::error::Error for anyhow::Error?

When anyhow::Error is an associated type of a trait, such as TryFrom, then calling code cannot propagate the inner anyhow::Error into an outer anyhow::Error generically, as this playground demonstrates.
In my project I initially thought I could just make the bound precise to anyhow::Error, like this:
fn do_stuff<T>(arg: T) -> anyhow::Result<()>
  where Thingy: TryFrom<T, Error=anyhow::Error>,

-but this precludes other impls that I do want to cover generically, including impl TryFrom<Thingy> for Thingy which has Error = Infallible. (I'm not sure if this is from a blanket impl in std or a dependency I'm using to define Thingy.)
-so I attempt to specify all of the anyhow::Error construction constraints:
fn do_stuff<T>(arg: T) -> anyhow::Result<()>
  where
    Thingy: TryFrom<T>,
    <Thingy as TryFrom<T>>::Error: 'static + Send + Sync + std::error::Error,

Now I can pass any T with any TryFrom error that can be converted to an anyhow::Error. Great!
…except anyhow::Error does not implement std::error::Error, so it cannot wrap itself.
Is this simply a bug, or is there a design rational for not providing impl std::error::Error for anyhow::Error ?

Duplicate of #136.
Into<anyhow::Error> is probably the trait bound you are looking for.


Update free-courses-en.md

Added some new and best courses in *kotlin and * Android
What does this PR do?
Add resource(s)
For resources
Description
Android and Kotlin Resources
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Added some new Courses


Prevent duplication of the PHN : URGENT PLEASE

Now the PHN Generation algorythm is corrected. The corrected version is deployed in the production system and testing system. The list of clients with wrong PHN can be find in Menu > System Administration > Manage Metadata > Development > Clients with wrong PHN. (This report can be later removed.)
An algorithm can be develop to identify affected clients and give a warning to take corrective actions.

I close the issue. Please check and open if there is an error. Need QC.


Your Results in New Super-Resolution Benchmarks

Hello,
MSU Graphics & Media Lab Video Group has recently launched two new Super-Resolution Benchmarks.

Video Upscalers Benchmark: Quality Enhancement determines the best upscaling methods for increasing video resolution and improving visual quality.
Super-Resolution for Video Compression benchmark aims to test Super-Resolution methods on compressed videos and select the best model for each video codec standard.

Your method BasicVSR++ achieved 22nd place in Video Upscalers Benchmark: Quality Enhancement in 'Animation 2x' category. We look forward to your future work!
We would be grateful for your feedback on our work.

@EvgeneyZ How long sequence you fed into the model ?
Did you fed one sequence after another or you implemented kind of a sliding window with overlapping approach ?

We used a sliding window with overlapping. If you get better results by applying your model to our test video differently, please send us this result, and we will update your position in the leaderboard.


e2e tests: Color output

Currently it is really hard to read the output because it is only a wall of text.
Another improvement would be to not print the output of vcpkg twice.

Another improvement would be to not print the output of vcpkg twice.

Megaderp, I didn't even notice that bug, sorry, I probably broke that.

Yeah it broke here: https://github.com/microsoft/vcpkg-tool/commit/0cba610af71441e734ec8a13ac29670fdbc092ed#diff-c379a6362a99daa09862f9a97c7ef3895cf8fa441539e6d36ecbfe04f031570e

Thanks!


Poor Graticule Performance in Chrome

I noticed when when using the Graticule feature in Chrome, some intermediate zoom levels render very slowly relative to other zoom levels. Sometimes a zoom action will lock up for a number of seconds.
Steps to reproduce:

Open http://openlayers.org/en/latest/examples/graticule.html in Chrome
Zoom in about 5 zoom levels
Notice that the animation gets slower as you continue to zoom in.
If you continue to zoom in, it begins to render quicker again.

I was able to reproduce this in Chrome Version 59.0.3071.115 (Official Build) (64-bit) on Windows 7 and Ubuntu 16.04

I also tested this in Firefox and did not see significant lag when zooming in.

I noticed that if I remove the lineDash stroke style on the graticule, performance is much better. So this may be specific to Chrome and lineDash styling.

Another variable that seems to help is keeping the lineDash but using a lineCap other then the default of 'round'. Using square or mitre appears to perform better for me.

Profiling showed that it was the the actual context.stroke call that was taking all the time. This was odd to me because the zoom levels with the most lag were not the zoom levels with the most meridian and parallels.
I dug in a bit more to try and find out why there was lag only at a particular range of zoom levels. I put some debug statements in the ol.render.canvas.Immediate.moveToLineTo_ when it calls transform2D to transform the coordinates into pixel coordinates. Some of the values coming back look odd.

Does the situation improve when you use Math.round() on the pixel coordinates?

Unfortunately, that does not appear to help. Thanks for the suggestion.

It looks like it wasn't the meridians but the parallels that were problematic. Super wide parallels were being created and this seemingly causes issues in Chrome in some cases.


Add the ability to cut out a Rectangle from ImageryLayers

This PR adds the ability to cut out a Rectangle from ImageryLayers.

A caveat that I feel needs defense: this doesn't influence imagery tile selection. The intent was for this Rectangle to be dynamic, and it looked to me like getting this to function with the existing imagery tile selection code would have been pretty complicated. Let me know if I was wrong and I should fix that.
Besides this just being kind of a fun feature, we likely need this to implement https://github.com/AnalyticalGraphicsInc/cesium/issues/6531.

The layers can be transparent, so layering them directly on top of each other isn't acceptable.

@likangning93 This looks good to me. Can you merge in master?

@bagnell merged in master

@bagnell this is up-to-date!


Show collaboration stats in the stats dialog

Add new category Collaboration

[ ] Total users
[ ] Traffic in
[ ] Traffic out
[ ] Ping with the server

For the traffic we can use the nFormatter to show per second the average speed.. (no clue how to get that info)

we can use something like network-speed?

we can use something like network-speed?

@ad1992  Are you up for it?

@ad1992  Are you up for it?

Sure will pick it up soon 👍

Sure will pick it up soon 👍

I have been checking few libraries as network speed doesn't have ping ability.
Listing few of the libraries 👇
speedtest-net ~332.1kB (minified+gzipped).
speed-test - has only cli support.
ng-speed-test - Unfortunately its just for angular.
So I think we can try with two libraries instead 👇

network-speed ~ 753bytes (minified+gzipped)
ping-monitror - 2kb(minified + gzipped)
what do you say?

I think rolling our own is the way to go.. I just have no idea how :)

We basically want to check how fast is the connection to our collaborator server: https://portal.excalidraw.com

Not sure how helpful it would be but you could request a pixel image with a random URL (each time a new one) on each hear beat and set up a PerformanceObserver to get stats on a regular basis.

Maybe useful one way or another:

navigator.connection
window.performance

I have been checking few libraries as network speed doesn't have ping ability.
Listing few of the libraries 👇
speedtest-net ~332.1kB (minified+gzipped).
speed-test - has only cli support.
ng-speed-test - Unfortunately its just for angular.
So I think we can try with two libraries instead 👇

network-speed ~ 753bytes (minified+gzipped)
ping-monitror - 2kb(minified + gzipped)

what do you say?

Sharing my findings here as discussed with @lipis
There are few challenges for this since we are doing it for the client.
the library I finalized doesn't seem to work as expected. ping-monitor works for node not browser so can't use it.
tried is-reachable and it's working fine, however, it just checks if endpoint/favicon.io is reachable so we might just want to have our custom code instead of adding a library.
network-speed is not maintained and had to add some fix to make it work as it's broken but still, the data it gives doesn't seem to be right so can't trust the values.

navigator.connection.downlink is not supported in all browsers so might not be a good option.
One more way could be by loading an image with a known file size then in its onload event measure how much time passed until the event was triggered, and divide this time in the image file size as suggested here.

Even if it's not supported in all browsers it's not an issue.. we can simply disable (not showing the traffic) it. It will be mainly for us to monitor and make improvements/optimizations.

I like the idea of the image trick.. is basically what @tomayac mentioned in a way.. right?

Even if it's not supported in all browsers it's not an issue.. we can simply disable (not showing the traffic) it. It will be mainly for us to monitor and make improvements/optimizations.

Yeah, but it will always show max value as 10 for chrome based browsers as that's the max cap.

I like the idea of the image trick.. is basically what @tomayac mentioned in a way.. right?

I think yeah but calculate speed instead of using perf observer.

I like the idea of the image trick.. is basically what @tomayac mentioned in a way.. right?

Correct, that's what I was proposing. Here is an article paragraph that outlines the approach. The trick would be to create images with random URLs regularly to measure any changes over time.

Almost needless to say: for all of these approaches we need to carefully balance wasted bandwidth vs. the actual usefulness of the obtained insights.

Almost needless to say: for all of these approaches we need to carefully balance wasted bandwidth vs. the actual usefulness of the obtained insights.

Uncertainty principle, also called Heisenberg uncertainty principle or indeterminacy principle, statement, articulated (1927) by the German physicist Werner Heisenberg, that the position and the velocity of an object cannot both be measured exactly, at the same time, even in theory.

Will take a shot at it this weekend.

The attempt was left in this branch: https://github.com/excalidraw/excalidraw/compare/net-stats


Added create connector API for MLClient

Description
Added create connector API for MLClient.
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-ai-flow-framework/issues/70
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 could you also please raise a backport PR for 2.x branch? Thanks.

@owaiskazi19 could you also please raise a backport PR for 2.x branch? Thanks.

@dhrubo-os this needs to be merged before backporting this.


HG_Bulk_access() does not work in read-write mode

Hello,
I am trying to use HG_Bulk_access() to directly access the pointers from an existing HG bulk handle of another process (on the same node). I understand that the flags of HG_Bulk_access() are currently unused, so the read-only or read-write access is set when the bulk handle is created with HG_Bulk_create().
Now, if the bulk handle is created with the HG_BULK_READ_ONLY flag in process 1, HG_Bulk_access() works as expected and the pointers can be accessed in process 2. But if the HG_BULK_READWRITE flag is used in process 1 to create the bulk handle, the pointers cannot be accessed (not even for reading) and, therefore, their data cannot be modified either in process 2.
Am I missing something here to be able to use HG_Bulk_access() in read-write mode?
Note that using HG_Bulk_access() to access the pointers of an existing bulk handle, created with the HG_BULK_READWRITE flag, works in a single process setting. For example, to access the pointers to the internally allocated buf_ptrs array if NULL has been passed to buf_ptrs in HG_Bulk_create(). I believe this case is also covered by Mercury tests.
Thanks!

Hi Marc, thank you for reporting that. If you are trying to access the memory from another process on the same node, I'd recommend that you use the NA shared memory plugin though since transfers in that case will be done using cross-memory attach. HG_Bulk_access is more convenient when you are accessing memory within the same process. I will look at the potential flag issue though.

Ah I think I figured out what was going on in your case but to confirm can you please let me know what was the size of your data?
I believe that the bulk handle that you are creating has a size small enough that the data can actually fit in the RPC request and I also assume that you have MERCURY_USE_EAGER_BULK turned ON in the mercury cmake options. In that case, when the bulk handle is created with the HG_BULK_READ_ONLY flag, the data gets actually copied/encoded along with the RPC request message (to prevent an extra transfer). So when you call HG_Bulk_access() on that bulk handle, you can indeed access its data since the data has been transferred already. So in your case you get the illusion of accessing the memory of process 1 but you are actually accessing the memory of process 2 since there has been a transfer / data copy already. This mode only works with HG_BULK_READ_ONLY. With HG_BULK_READWRITE, we cannot allow the same type of optimization as we do not really know if you are only going to read or also write. Assuming we were allowing it and you were writing data in that case, it would only be reflected locally but not to the other process.

Hi Jerome, thanks for your quick reply! Thanks for the clarification. I was unaware that a transfer on the na+sm plugin is using cross-memory attach.
Regarding your second post, with your explanation, the behavior makes perfect sense. Yes, Eager mode is turned on and the size is quite small (~800 bytes), because I am in the developing process and testing things out. Now, I tested the same code with MERCURY_USE_EAGER_BULK turned OFF and HG_Bulk_access() wouldn't work (the same way as earlier) anymore with an  HG_BULK_READ_ONLY created bulk handle of another process. It behaves like HG_BULK_READWRITE. With your explanation, this makes sense as the data is not copied along with the RPC message anymore. But is this the desired behavior, because it is not immediately clear from the documentation of HG_Bulk_access()? For now, I can circumvent my issue by disabling Eager mode or by using read-write handles.

Further, I believe that there is another issue with MERCURY_USE_EAGER_BULK=ON, the na+sm plugin, and multiple segments, which might be related to the above situation. For example, when data is pulled (on process 2) from an HG_BULK_READ_ONLY created bulk handle (on process 1), only the first segment, i.e., the data of the first pointer in void** buf_ptrs, is actually transferred. I made sure the hg_size_t* buf_sizes are correctly set by debugging into the Mercury code. This scenario works fine with bmi+tcp. As far as I see, the transfer with na+sm works with multiple segments in the following cases: (1) MERCURY_USE_EAGER_BULK is turned OFF; (2) the bulk handle that is being pulled from is created with HG_BULK_READWRITE; and (3) the data is large enough so that it is not transferred along with the RPC message. Essentially, Eager mode is not used in the cases 2 and 3 implicitly.
For instance, a simple way to test this is by putting a number of int* (one per segment) into the array of pointers void** buf_ptrs when creating the bulk handle as read-only and checking what another process, that pulls the data with HG_Bulk_transfer(), receives. Case 3 (from the above paragraph) is triggered when 112 or more segments are used (assuming an int is 4 bytes in size). Fewer segments result in only the first segment being transferred.
Hope this helps.

Thanks for letting me know. Yes I can see where there can be confusion and will fix the documentation of HG_Bulk_access. I will also have a look at the other issue.

As a quick follow up. I finally got around to test your fix and it was good timing. While the fix in this thread didn't resolve the issue, 7cf076e2567d842f5066e6a203a5172f8106449f from 3 days ago did. Thanks!

Oh ok, I guess I had missed the case in the first place. Thanks for letting me know.


bumped to version 0.8

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This release is packaged with poetry as per the upstream changes.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

There are too few lines.  There should be one empty line at the end of the file.

@conda-forge-admin, please rerender


Fix incorrect variable for url() options array.

Changes
Fixes a typo noted by @sergii-tkachenko in #5643.
Where should the reviewer start?
Preferably on line 229 of helpers.inc.
How should this be manually tested?
Before, I was dumb and none of the tiles on taxonomy pages/campaign groups were getting ?source=xxxx appended to their links.


Select cell with multiple options

I found myself in a scenario where I need to have an EnumFlags column.
In order to do that, I'm using a select typed cell, the same type that I'm using for FK constraints on the sheet. The problem is that EnumFlags requires multiples entries, not only one single value, I'm wondering if someone else have been through a similar scenario or if there is a better approach to this, maybe with a component that I don't know yet.

I'm thinking about just opening a modal from this cell and using checkboxes for each enum field and some other work arounds as well, but it would be brilliant if there is something like that native from your repository.

Hi @lucasmoraiss there's no default component for sort of thing - we have an enum select component but it's for single values.
It should be pretty easy for you to add your own renderer / editor component, you can look at the examples for the custom editor and custom renderer

Another example of using a custom renderer is here: https://github.com/anmcgrath/BlazorDatasheet/issues/80

@anmcgrath - Can you close this?


Fine tuning compiler options for removing comments

Talk with @CyrusNajmabadi . Currently we have following different types of comments:

Pinned comment
Triple-slash
Detached comment (i.e. copy right)
Normal comment (//, /* /, /* **/)

Currently, compilerOptions.removeComments will remove everything but pinned comment and detached comment. However, in some case, users may want to preserve triple-slash or may want to get ride of detached comment. Thus, it will be useful to have a compiler flag that allows users to specify what kind of comments to be remove and by default compilerOptions.removeComments should remove all but pinned comments

To clarify the comment, pinned comments in every circumstance should be preserved (even if it is used with interface which will not be emitted in js)

As a result of PR #3883, our --removeComments will remove all comments except pinned comment at the top of the file (i.e Copyright header comments). This change eliminate the original functionality of the pinned comment. It is possible that we will go even further to totally remove the differentiation between /!* and /// and /* (see issue #4734)

We have not got much feedback about this issue, and thus, do not see the value of adding additional complexity here.


Update SSH keys and user names controller changes

Issue #, if available:
#1208
Description of changes:
The changes for the controller to update the spec and create a new kubeadm config template were a part of the PR where we update the cli changes.
Testing (if applicable):

Created management cluster

Updated worker node's user name and ssh keys, tested by logging in using new keys and name

Updated control plane and etcd node's user name and ssh keys, got an error saying the update was immutable

Created workload cluster

Updated worker node's user name and ssh keys, tested by logging in using new keys and name
Updated control plane and etcd node's user name and ssh keys,  tested by logging in using new keys and name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes added in #1461


With NO_UNSET, highlight unset parameter expansions as errors

It would be nice for —
set -u
unset foo
echo "$foo"

— to highlight the $foo as an error (= in red), since that line would fail to execute.

I worry about adding this because I suspect if we do, someone will some along asking why
unset foo; echo "$foo"

doesn't highlight that $foo in red.

Note also #239 which is the same thing but with $options[unset] at its default setting.
@phy1729 Is there an analogy we can use?  E.g., touch foo; : foo and the second foo isn't underlined.  This may be a hard sell though so I wonder whether we have a more convincing analogy.

Perhaps cc foo.c -o foo; ./foo, but both are false positives not false negatives. Although in all cases it is arguable z-sy-h shouldn't become a perfect zsh oracle and the highlighting behaves in an expected although technically incorrect way.

It's easy to convert between false positive and false negative, e.g., rm foo; make foo or foo=42; echo "$foo".
I think the expected behaviour should be to highlight according to the state before the line is executed.  I could see us support some additional simple cases (like how master supports $foo and ${foo} but nothing more than that) if somebody wrote the code.

.. meant in a "patches welcome" sense.

I'm not sure what I had in mind when I mentioned history modifiers.
Related: In master we now highlight unset parameters in command position as comments.

This should happen for both echo $foo (unquoted) and echo "$foo" (double-quoted).


redirect backTo not working correctly

I'm trying to configure a dynamic redirect on successful login.  My Caddyfile looks like
my.domain.com {
    root /var/www
    header / Cache-Control "no-cache"

    fastcgi / /var/run/php-fpm/php-fpm.sock php

    jwt {
      path /
      except /favicon.ico
      redirect /login?backTo={rewrite_uri}
    }

    login {
      htpasswd file=/var/lib/caddy/passwd
    }
}

From what I can gather the referrer host must match the current request host by default.
Here what my request headers look like:

You can see that the host and the referrer host are the same.  However, the redirect is not working and in the log I am seeing:
"2018-12-10T23:20:29Z" level=warning msg="redirect from referer domain: '', not matching current domain 'ec2.parkerspot.com'" type=application

This seems like a bug.  Am I missing something?

Try changing to this:
jwt {
      path /
      except /favicon.ico
      redirect /login
}

Then try clicking on a link like this one:
login with backTo
Worked for me locally with Windows 7 x64.
Then adjust as needed.
If it doesn't work please share both your client browser and OS as well as your server OS.

Ref: https://github.com/tarent/loginsrv#redirects
You can use these two to adjust behavior:
--redirect-check-referer=false

--redirect-host-file=/some/domains.txt

If you simply browse to a URI without actually clicking a link your referer would be empty. Accepting that by default would open the user to phishing or login attacks even if user visited site before from same session.

Ok, thank you for your response.  I understand the behavior now and can see that this is how it was designed to work to be more secure by default.  I will add redirect_check_referer false so that browsing directly to a URI redirects correctly.
Thanks!


Bump azure-maven-plugin version for release

Bump azure-maven-plugin version  for release

Codecov Report

Merging #875 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #875   +/-   ##
==========================================
  Coverage      44.46%   44.46%
  Complexity       766      766
==========================================
  Files            135      135
  Lines           5184     5184
  Branches         748      748
==========================================
  Hits            2305     2305
  Misses          2705     2705
  Partials         174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77dd202...e7af35d. Read the comment docs.


Cannot select text in multi-line SelectableTextBlock easily

Describe the bug
I dont really know how to explain the bug but it is difficult to select text manually in a SelectableTextBlock that has multiple lines in it. See the video below.
To Reproduce
Steps to reproduce the behavior:

Add a SelectableTextBlock.
Add some texts with multiple line.
Try to select the text as shown in the video.

Expected behavior
Can easily select the text inside the control as shown with Notepad in the latter part of the video below.
Desktop (please complete the following information):

OS: Windows
Version 11.0.999-cibuild0032750-beta

Additional context
Sample project
https://user-images.githubusercontent.com/12814796/230022153-e57ba4b2-832b-4f1c-ae6e-7e0ddd2533eb.mp4

I am also experencing this. I've made a video that shows another scenario with unexpected behavior, it's easily seem with alternating lines of different widths. I've also included the same movements in a notepad++ window as a way to show expected (at least to me) behavior.
https://github.com/AvaloniaUI/Avalonia/assets/29486064/c85ec6f5-8d11-46df-a0f8-25ccf3a886af
The app used is the sample project provided by the OP, with just the text in some of the lines made wider to properly show the issue.

@diogotr7 please make sure that SelectabeTextBlock has a background, at least Transparent. (from the video I am not sure if it's a Border behind or not).

@maxkatz6 Here's the axaml from the video:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="AvaloniaApplication.MainWindow"
        Title="AvaloniaApplication">

	<Border HorizontalAlignment="Center"
			VerticalAlignment="Center"
			Width="300"
			BorderThickness="1"
			BorderBrush="Black">
		<SelectableTextBlock Background="LightGray">
			<Run>Hello World!Hello World!Hello World!Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!Hello World!Hello World!Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!Hello World!Hello World!Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!Hello World!Hello World!Hello World!</Run>
			<LineBreak/>
			<Run>Hello World!</Run>
			<LineBreak/>
		</SelectableTextBlock>
	</Border>
</Window>

There's a border and a Background. Should i try with any other change?

+1 it is pretty annoying. Anyway, thank you a lot for the text rework in Avalonia 11, including new SelectableTextBlock :)

Fixed in current master


Fix RPI WS281x LED device initialization

When initializing LedDeviceWS281x _led_string field (ws2811_t) was not filled with zeros (thus was filled with garbage) and that prevented proper initialization of it's gamma pointer, accessing which causes a SIGSEGV.
Added initialization of _led_string field with zeros which results in proper memory allocation for gamma.
Tested locally.
Fixes #564

Thank you for the detailed description and the fault clearance. We hope you will stay with us for a long time. :+1:


I can do this

I can take this up

I will work on it

i can take this up

i can take this up

I would like to take this issue

i can take this up !

I want to take this issue

I want to take this issue

I want to work on this.

I will work on it !!

I WILL WORK ON IT

I want to work on this.

I will work on this too

i want to work

i want to work

I want to work on this

I want to try

i want to take it

i want to work as well

i would like to take this issue

I want to work on this

I would like to take this issue


Add github workflow

Add jobs for phpunit, ecs and psalm

Hey there and sorry for the late answer. Thank you for the contribution
LGTM, but is it possible to use our make commands instead? Should we better move them to composer scripts to not leave the PHP stack?

I personally would prefer to move them to composer scripts because you are able to pass extra options to the script with e.g. composer run ecs-dry -- --ansi. This enables the scripts to be aimed at a dev environment and the CI to add additional arguments for its need.

Yes, I think creating composer commands would be more efficient.
I don't know if there is a way to pass command-line arguments to make, either. I only know that you can only pass environment variables to scripts or you have to build a very complex target to read variables. Additionally, Ubuntu does not ship with make installed. So we'd have to install it on the GitHub flow. The only benefit of make is that you can have dependencies that are run if a folder does not exist.
Looks pretty good with the composer commands :smiley:

I ported the scripts to composer scripts and made the bin-plugin to always install it's dependencies now. Pipeline is succeeding again too.


Fix missing start dates

Rows with missing start dates are still present in data_timeline_treatment.txt files

We need a way to track the missing start dates if we remove them, because this is usually an error with the upstream data

Why does the following line not remove these rows?
https://github.com/Sage-Bionetworks/GENIE-Sponsored-Projects/blob/ea33ed8a587a3e8f53c4d504842606da83cb6f7b/geniesp/bpc_redcap_export_mapping.py#L590

There are timeline files that are created by this function too: https://github.com/Sage-Bionetworks/GENIE-Sponsored-Projects/blob/ea33ed8a587a3e8f53c4d504842606da83cb6f7b/geniesp/bpc_redcap_export_mapping.py#L664

Would adding the equivalent filter on null values to the create_fixed_timeline_files function cause any issues?
In terms of tracking, missing start dates for treatments are flagged by the stats team's complex queries and resolved by sites on subsequent data uploads.  Maybe we can just output warnings that we have removed them, but I don't think that we need track them closely.

I'm honestly unsure of the impact, but we can always try it.


Refactor checkpointing

What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Current implementation doesn't guarantee that checkpointing would work after changing DRA data structures, which was explained in the @123552
This PR changes checkpointing implementation by isolating DRA checkpointing into a separate API maintained as other Kubernetes APIs.
Which issue(s) this PR fixes:
Hopefully fixes #123552
Special notes for your reviewer:
This is just a first step, a base for further work.  The next step would be checkpointing data optimisation, i.e. only the data that's required should be checkpointed, which is currently not the case.

/cc @pohly @klueska @moshe010

/assign @pohly @klueska @moshe010
PTAL if this approach makes sense, thanks.

@pohly @klueska Updated code to use common API management approach, PTAL.

Glancing through https://github.com/pohly/kubernetes/tree/master/pkg/kubelet/apis/config, this PR doesn't seem to adhere to the organization we would need to eventually support automatic generation of the conversion code.
Most of what you currently have under checkpoint/v1alpha1 would need to be moved up to checkpoint and then the folder for v1alpha1 (or just v1 as I have suggested) would only contain a single file, with contents similar to the following:
https://github.com/pohly/kubernetes/blob/master/pkg/kubelet/apis/config/v1alpha1/doc.go

Glancing through https://github.com/pohly/kubernetes/tree/master/pkg/kubelet/apis/config, this PR doesn't seem to adhere to the organization we would need to eventually support automatic generation of the conversion code.
From what I can tell, most of what you currently have under checkpoint/v1alpha1 would need to be moved up to checkpoint and then the folder for v1alpha1 (or just v1 as I have suggested) would only contain a single file, with contents similar to the following: https://github.com/pohly/kubernetes/blob/master/pkg/kubelet/apis/config/v1alpha1/doc.go

This is an internal-only API, so it doesn't need internal and external parts. When we create v1/ folder, the conversion-gen machinery should be able to generate v1->v2 conversion code.
@pohly Is this a correct assumption?

nlike kubelet/apis/config, this is an internal-only API, so it doesn't need internal and external parts. When we create v2, the conversion-gen machinery should be able to generate v1->v2 conversion code.
@pohly Is this a correct assumption?

I would think that the code in pkg/kubelet/cm/dra/checkpoint should always be the latest, with any generated conversion code living in checkpoint/v1, checkpoint/v2, etc. Where (for now) the code under checkpoint/v1 is simply an "identity" conversion (i.e. it is a 1-1 mapping where no real conversion takes place), but will be updated if / when we ever add a v2 -- at which point v2 will be the "identity" conversion mapping to the latest changes in pkg/kubelet/cm/dra/checkpoint.

Unlike kubelet/apis/config, this is an internal-only API, so it doesn't need internal and external parts. When we create v2, the conversion-gen machinery should be able to generate v1->v2 conversion code.
@pohly Is this a correct assumption?

I am not sure. The code generator should be able to do it, but I am less sure about how to configure the scheme to use such a direct conversion path. I know for "normal" APIs, the conversion path is always "version A" <-> "internal" <-> "version B". That means conversion back and forth is only needed between each version and the internal representation. I've not seen it being used with just conversion from "version A" -> "version B".
No matter whether this works or not, we can start with just encoding/decoding "version A", without any conversion. Then if, and only if we need conversion, we can add it, either with such an internal representation or directly.

No matter whether this works or not, we can start with just encoding/decoding "version A", without any conversion. Then if, and only if we need conversion, we can add it, either with such an internal representation or directly.

That was my intention. I didn't do any conversion as we have only one version. I can try to add a new verson locally and see if conversion-gen is able to create v1->v2 and v2->v1 conversion, but in my understanding it should. That's why I think that we don't need "internal" part of the API, it would be just a duplication of the latest API version.

@pohly btw, do we really ever need to convert from v2 to v1? to do that we'd need to backport v2 types and conversion code to the previous kubelet version as far as I understand. Please, clarify.

btw, do we really ever need to convert from v2 to v1? to do that we'd need to backport v2 types and conversion code to the previous kubelet version as far as I understand. Please, clarify.

I think we need to support downgrades. It's not okay if kubelet v1.32 encounters a checkpoint file written by kubelet v1.33 and then refuses to start. That's the opposite direction of what we encountered before, but it's also a problem.

@pohly @klueska I've just pushed new changes:

used checkpoint structure proposed by @pohly
tested downgrades and upgrades
moved checkpoint APIs (not versioned) to the dra/checkpoint/
moved versioned API to the dra/state/v1
renamed non-versioned apis and structures as @klueska suggested

@pohly Is it ok to use versioned checkpoint structures (e.g ClaimInfoStateList) in the manager.go and claiminfo.go or we should avoid it. If yes, how to better do it? Should we use "internal" API and conversions for this?

@klueska @pohly let's continue in the k/k upstream PR: https://github.com/kubernetes/kubernetes/pull/126303


Rearrange rows according to article week number

I will like to do this task

@Enecode Approved.
Please proceed

Thank you. I have completed the task.


MM-56933 - password field do not disable autocomplete

Summary
Disable autocomplete during login while tipying password and visible password is selected.
Ticket Link
https://mattermost.atlassian.net/browse/MM-56933
Checklist

[ N/A] Added or updated unit tests (required for all new features)
[ x] Has UI changes
[N/A ] Includes text changes and localization file updates
[ X] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information
This PR was tested on:
Screenshots
Before:
https://github.com/mattermost/mattermost-mobile/assets/10082627/b1165005-4fa3-4390-b83b-1b7ec12fb921
After:
https://github.com/mattermost/mattermost-mobile/assets/10082627/9fe8c9a3-4a77-4b57-b247-9f80187e38f6
Release Note
NONE

/cherry-pick release-2.19

Cherry pick is scheduled.


clone fails on long CSV

@rultor release, tag is 0.6.3

@rultor release, tag is 0.6.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.6.3

@yegor256 Done! FYI, the full log is here (took me 7min)


PR File list visual bug

Description
When viewing PRs, the list of files to the left is now very small and you have to scroll no matter how many files there are

Example PR on demo site: https://try.gitea.io/wxiaoguang/test/pulls/27/files (Just one i found, it seems to be on every PR)
Gitea Version
1.19.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
ECS Linux instance with RDS MySql database
Database
MySQL

More specifically, the linked PR will fix it in 1.19.x. This still appears on try because the fix isn't in main yet, but will be once https://github.com/go-gitea/gitea/pull/23553 is merged.

Sweet, thanks. I spent ages looking for a duplicate but knew as soon as i opened an issue someone would know where it was :D
Thanks


Node client with server-only stream doesn't seem to work properly

First, the server-sided stream request from the node.js client requires a callback function. This doesn't make sense as there's no single error or result callback. As far as I can tell, this is never called with anything but an error.
If I return an error from the server side, metadata, "status", and the error callback provided in the function call get called. If I return a single message and then hold the stream open, I don't get anything over the data event, nor over the regular callback.
Golang clients work fine for the golang grpc server I'm testing against.

If you are seeing a server streaming method that requires a callback on the client, then something is set up incorrectly. That's not what is supposed to happen.
Can you make sure that the .proto file is identical on the client and server, and provide the contents of the .proto file?

Yes, I'll try to get a reproduce for you here. Thanks for the response.

@murgatroid99 Okay I think I know the problem. I use the pbjs binary from Protobuf.JS to compile a lot of proto files together into a single Javascript object (using the JSON output). I then use ProtoBuf.loadJson(definitions). I load this into grpc by doing grpc.loadObject(builder.lookup('mynamespace.MyService')).
This works fine for regular protobufs, as well as non-streaming grpc calls. I think the streaming information is lost somewhere in the mix.

This also relates to: https://github.com/dcodeIO/protobuf.js/issues/468

You're right. I totally missed this in my tests, but it looks like Protobuf.js does in fact drop the streaming information when it converts to JSON. The funny thing is that grpc can actually load those JSON files directly with grpc.load(json_filename, 'json'), but it just calls ProtoBuf.loadJson anyway, so that wouldn't help.
Why don't you want to load the proto files at runtime? It isn't really much different from loading JSON files at runtime.
And yes, this is a bug in Protobuf.js, and it needs to be fixed there. That pbjs tool is discarding information, and it should not be doing that.

@murgatroid99 the proto files are scattered all over the place in a number of different projects, for example, the codebases for each of the services I call. I have a build step that collects these with pbjs into a single definitions file, and also builds Typescript definitions for all the messages.
I'll have a look at fixing the pbjs implementation.

@murgatroid99 PR sent to Protobuf.JS

As this is a Protobuf.JS issue and not a GRPC issue (just confirmed it works great now that I've fixed the pbjs bug) I'll close this. Thanks!


Implementing null-aware operators throughout the repository

This pull request fixes #143803 by taking advantage of Dart's null-aware operators.
And unlike switch expressions (9 PRs and counting), the Flutter codebase is already fantastic when it comes to null-aware coding. After refactoring the entire repo, all the changes involving ?. and ?? can fit into a single pull request.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

LGTM 👍. 200+ lines saved! Thanks for all of these code migrations. Out of curiosity are you using scripts or regexes or something to help do this?

Thanks very much! I've just been using VS Code's built-in regex search to look for potential stuff to improve.
For this PR it was == null or != null with something being assigned or returned in the next line.

Ah got it. Maybe at some point we can add analyzer/lint rules for stuff like this.

BEAUTIFUL


change default azure disk storage class for managed disk cluster

What this PR does / why we need it:
Usually customer would use default azure disk to create k8s objects, e.g. helm char, when user create a k8s cluster with managed disk agent pool, the default azure disk storage class should also be set as managed_standard.
I have done test for deploying both managed and unmanaged k8s cluster, it works well.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1736
Special notes for your reviewer:
BTW, there is condition that customer would deploy two agent pool, one is unmanged, another is managed, then default storage class won't work for both. In that situation, we would suggest customer not use default azure disk storage class.
Release note:

change default azure disk storage class for managed disk cluster

/assign @jackfrancis

@andyzhangx You're going to have to account for the delivery of the file to the master at /etc/kubernetes/addons/azure-storage-classes.yaml. See here:
https://github.com/Azure/acs-engine/blob/master/parts/kubernetesmastercustomdata.yml#L165

@jackfrancis yes, MASTER_ADDON_AZURE_STORAGE_CLASSES_B64_GZIP_STR will be changed to managed storage class if it's a agent pool with managed disk. And I have tested it works well.

Thanks @andyzhangx !


use midas

@timkral

I'm not sure how to update the travis stuff. May as well get this one up and ready.


Promote on https://pre-commit.com/hooks.html

We should make a PR here https://github.com/pre-commit/pre-commit.com to make scss-compile appear on https://pre-commit.com/hooks.html

Yep cheers, just "solidifying" it a bit, and also there's a bit of an open question about how it interacts with PR merging (https://github.com/executablebooks/sphinx-panels/pull/32#issuecomment-692791196)


Creating an authtoken comp

What does this PR do?
The new component ensure the creation of the auth_token. This is now required by other component than the api.
Without this, the inventoryagent comp would tries to contact other process before the auth_token was created.
Describe how to test/QA your changes

Make sure the auth_token is not already present
Run the Agent and check that you don't have log like:

2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch security-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.
2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch process-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.
2024-02-16 22:35:09 EST | CORE | INFO | (comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go:192 in getCorrectConfig) | could not fetch trace-agent process configuration: unable to read authentication token file: open C:\ProgramData\Datadog\auth_token: The system cannot find the file specified.

/merge


Normalize overwrites moves that change type

Set all the moves that change type, such as Hidden Power,
Natural Gift, Judgment, and Technoblast, to change their
types within a volatile to guarantee proper interaction
with Normalize and all other effects.

Weather Ball is missing! Otherwise this looks good to me. :+1:
For the tests, maybe check for the type you expect Shuckle to be, and not the type you don't expect?

Volatiles are bad for performance, bad for readability, and bad for America. >:(

We may instead wish to introduce a ModifyMoveType event

Events don't pick up event handler callbacks from moves, only from volatiles set by moves, hence this change. Unless there's a way to call an event and also include event handlers directly from moves as well?

(Also Weather Ball fix is in now, so if we can't deal with the volatiles issue, it's basically ready for merge)

We can manually run ModifyMoveType on the move.

That doesn't fix anything – the bug is happening because we're running ModifyMove manually for the move, when its exact timing needs to be in between the timing checks for various abilities! (Specifically, as discussed in #1437, it overrides Normalize's type change but then could be affected by the -ate abilities, Ion Deluge, and Electrify)
The only other possible fix is to hardcode every type-changing move out of Normalize, then put it back in the Gen 4 versions. Other than that, I don't see any reason to take the move type changing out of ModifyMove into a brand-new event, because new redundant events are also bad for performance and bad for America.

Hardcoding Normalize might be a good solution.
For a better solution, we can make the event runner include active moves, but that's a pretty in-depth refactor.

Done. Gen 4 didn't really need the small change that I did, but it doesn't need the priority change because it actually doesn't do anything for the code.
Actually, Normalize and the -ate abilities can probably all have their onModifyMovePriority properties set back to 0 since they can't overlap.

You forgot Natural Gift this time!

I had an even better idea that doesn't require hardcoding! Comments on my thought process are in the commit summary

This seems to be hardcoding to me. I don't have anything against hardcoding, but let's be fair, that's what this is.

Uh, did anything change between your last two comments @ascriptmaster? It looks the same to me (and you didn't address Natural Gift which makes me think you committed the previous version again).

My bad, I forgot to push.

The day that moves change type and don't default on Normal, I will be very sad, lol
But at that point we could just attach a changesType flag of sorts to the relevant moves and fix everything that way

Added a Natural Gift test.

No objections, I'll let @Marty-D make the call

Great, thanks!


Pass dotnet host options to worker nodes

Multiprocess builds were hanging when called through dotnet build3,
because the child process spawned from LaunchNode failed immediately on
start with
A fatal error was encountered. The library 'hostpolicy.dll' required to
execute the application was not found

That was because MSBuild preserved the path to dotnet, but not the
additional arguments required for it to assemble a runtime environment.
This commit uses the property bag that the host provides to find the right
deps file. At the moment, there is no programmatic way to access the
runtimeconfig, so I'm relying on a heuristic--that it'll match the deps
file.
The property-bag access code is based on
https://github.com/dotnet/cli/blob/b7075b857b48b08908bd340ffd3f41f756318339/src/Microsoft.DotNet.Cli.Utils/Muxer.cs#L36-L40

@piotrpMSFT, @eerhardt--I have some questions!
Is this temporary?
Is there a bug or PR I can crosslink for the "programmatically get runtimeconfig" part?

@rainersigwald I'm working on a PR now. Once it's ready you won't need to get runtimeconfig anymore. Feel free to create an issue on /cli if you want a reference.

:shipit:


CH12 Unkonwn loss function: HuberLoss?

Hi @CoderZYQin ,
Unfortunately, this seems to be a bug in TensorFlow. There was a similar bug earlier this year, so I filed the issue #25938, and it was resolved after a while.
Could you please create a minimalistic code example that highlights the problem, and open a new TensorFlow issue? Thanks a lot!


Installing on Windows

Is the installation process still up-to-date and do you know if I can also install it on a windows machine?
I tried to use cygwin64 for the installation and followed the commands of building the native TensorFlow Library.
When executing the sbt compileNative command, I get the following output:

$ sbt compileNative
[info] Loading project definition from C:\TensorFlow\tensorflow-scala\project
Missing bintray credentials C:\Users\XXX.bintray.credentials. Some bintray features depend on this.
[info] Set current project to tensorflow-scala (in build file:/C:/TensorFlow/tensorflow-scala/)
error: pathspec 'v0.10.0' did not match any file(s) known to git.
mv: cannot stat 'tensorflow/bazel-bin/tensorflow/jna/libtensorflow.so': No such file or directory

Do you might know how to resolve this problem? Bazel is installed however highly experimental for Windows as stated on the official TensorFlow homepage

Sorry, this issue is also shown in my osx machine. Could you try
rm -rf tensorflow
git submodule init
git submodule update
#then
sbt compileNative

.
As you see, This problem is that submodule is not initialized. (I will update the README.md)
By the way, I plan to use the pre-built binary of pip then no sbt compileNative is required.
Thanks

Still having difficulties even after executing your suggested code:

$ sbt compileNative
[info] Loading project definition from C:\TensorFlow\tensorflow-scala\project
Missing bintray credentials C:\Users\XXX.bintray.credentials. Some bintray features depend on this.
[info] Set current project to tensorflow-scala (in build file:/C:/TensorFlow/tensorflow-scala/)
HEAD is now at c715c31... Merge pull request #4284 from caisq/r0.10-fixes
mv: cannot stat 'tensorflow/bazel-bin/tensorflow/jna/libtensorflow.so': No such file or directory

@cklat How about use TensorFlow Java API in https://www.tensorflow.org/api_docs/java/reference/org/tensorflow/package-summary
It contains not only Windows Native Library but also more intuitive for TensorFlow users.

I Changed the objective of this project to Serving TensorFlow Models with Scala. From now on this project uses Java API provided by TensorFlow which supports Windows as well.
If sbt is installed on your system, the following commands will work
$ git clone https://github.com/mskimm/tensorflow-scala.git
$ cd tensorflow-scala
$ (cd model; sh download.sh) # download inception-v3
$ sbt "run-main tensorflow.TensorFlowExample cropped_panda.jpg"
or
$ sbt "run-main tensorflow.TensorFlowExample /path/to/jpg/image"


CI: CircleCI test runs take too long

As I was recently looking into insights on Thanos CircleCI, I discovered that the tests take far too long in comparison with local runs - for example, the median for the last 7 days is ~30 minutes and the 95th percentile is whooping 1 hour. This is incomparable to the tests timed locally which run (with uncached test results) for roughly 2 and a half minutes.
My suspicion is that when bingo installs the dependencies (prometheus, alertmanager, minio), it is always downloading the required packages again (whereas locally this is done only the first time tests run). This is adding significant overhead; if possible, we should find a way to cache the dependencies between CI runs.

Still needed 😢


Toggle graphs in the training board olena

Client-side
Additions & Modifications:

Enhanced DropdownCard Component:

The DropdownCard component was refactored to allow dynamic control over its state (collapsed or expanded) based on a passed parameter.
By default, the component remains open.

Refinements in the Training Information Section:

Graphs within the Training Information section were encapsulated within the newly refactored DropdownCard component. This provides users the option to expand or collapse the graphical data, improving the clarity and organization of training details.

Removed Training Logs from Training Information:

The Training Logs information was removed from the Training Information section, streamlining the display and focusing user attention on more important information.

Hey @iamsherlocked1891, could you wait until Dec 5th to merge this PR? There a DISCO demo happening tomorrow so it would be safer to wait until it's past :)


Document span header delay

Confused me at first, span is delayed until Send or Close now also Receive. Document the waiting for stream headers.

Closing in favour of #143 which also enforces the span intialization.


pinnwand: add reaper, update hardening, test reaper, improve default settings

Motivation for this change
The reaper expires pastes in the background. If it doesn't run things will accumulate....
Currently there is something wrong with reaping, it seems to remove even the newest pastes, hence I've set this do draft until I can talk to the upstream.
database_uri = "sqlite:///var/lib/pinnwand/pinnwand.db"
footer = "View source code, the removal or expiry stories, or read the about page.\n"
paste_help = "
Welcome to pinnwand, this site is a pastebin. It allows you to share code with others. If you write code in the text area below and press the paste button you will be given a link you can share with others so they can view your code as well.

People with the link can view your pasted code, only you can remove your paste and it expires automatically. Note that anyone could guess the URI to your paste so don't rely on it being private.
\n"
paste_size = 262144

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test pinnwand


Mass Mindflay is confusing, and doesn't seem to work reliably

Documentation is vague, cant quite tell if I'm doing this right, and if I am, can't tell if it's working. Upon completion of the circle it neither mishaps nor spawns a slipway. Also does not appear to effect the villagers in the circle.
 So confusing.

It appears the current version of the source code does not have this crash. I built from source and found that the spell worked perfectly.


fix: Use visibility server when defining visibility config

What was changed

Why?

When the default store uses cassandra and the visibility store sql the config was not including the sql part
Checklist

Closes

How was this tested:

Using the following values
server:
  replicaCount: 1
  config:
    persistence:
      default:
        cassandra:
          hosts:
            - cassandra
          port: 9042
      visibility:
        driver: "sql"
        sql:
          driver: "postgres"
          host: "postgres"
          port: 5432
          database: "temporal_visibility"
          user: "postgres"
          password: "postgres"
          maxConns: 20
          maxConnLifetime: "1h"

Any docs updates needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks :)


Add left, right bitshift for Limb

Convenience methods to avoid wrapping and unwrapping the Limb.

Thanks!


Update dotnet base images

This commit contains the following changes:

Drop support for dotnet 2.x
Add support for dotnet 6.0
Add support for Alpine Linux and Ubuntu

Change-type: patch
Signed-off-by: Trong Nghia Nguyen<EMAIL_ADDRESS>

@balena-ci I self-certify!


react-native-paper ProgressBar hangs detox indefinitely

What happened?
One of my screens renders an indeterminate ProgressBar (i.e. <ProgressBar indeterminate/>). When reaching that screen, detox pauses indefinitely (until the test times out) printing this message every couple of seconds:
19:36:27.642 detox[8754] i The app is busy with the following tasks:
• 1 enqueued native timers:
  - Timer #1:
    + Fire date: none.
    + Time until fire: 0.000.
    + Repeat interval: 0.
    + Is recurring: YES.
• Run loop "Main Run Loop" is awake.
• There are 1 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".

The test runs normally if I comment out the ProgressBar component before running it.
Happens with both react-native-paper v 4 and 5.
What was the expected behaviour?
Detox to interpret the indeterminate progress bar as something it doesn't need to wait for.
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[X] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
I might be able to spare some time in the weekend to set up a small example to reproduce this if needed.
In what environment did this happen?
Detox version: 20.13.5
React Native version: 0.72.0
Has Fabric (React Native's new rendering system) enabled: no
Node version: 18
Device model: iPhone 14 simulator
iOS version: 16.4
macOS version: Sonoma 14.0
Xcode version: 15.0.1
Test-runner (select one): jest
Detox logs
Pasting logs in a comment, else PR body is too long.
Device logs
Couldn't find this file under the artifacts folder.
More data, please!
No response

Detox logs (too long to paste in comment too)
Detox logs.txt

@ianspektor did you figure out the root cause?

I had an animation that was not stopped properly which was casing this error.
So maybe pass indeterminate={!ENV_IS_TESTING} -- not ideal, but not sure how we can tell Detox to ignore waiting for animation

@mwmcode Seems like a decent workaround tbh! Will give it a try :) Thanks!


[ci:component:github.com/gardener/dependency-watchdog:v0.7.2->v0.8.0]

Release Notes:
A bug is fixed which allowed dependency-watchdog to not ignore scaling operations on deployment which are not enabled/deployed in a given cluster
A bug with uploading of a rotated dependency-watchdog-probe secrets is now fixed by refreshing the clients with updated secrets.

Switch default leader election resource lock for `dependency-watchdog` from `endpointsleases` to `leases`.

A dependent's scaling up/down can be ignored by DWD now by adding the annotation `dependency-watchdog.gardener.cloud/ignore-scaling` to the deployment

Published docker images for Dependency-Watchdog are now multi-arch ready. They support `linux/amd64` and `linux/arm64`.

The `dependency-watchdog` now uses `distroless` instead of `alpine` as a base image.

DWD client shall no longer use long running TCP connections when attempting to probe Kube ApiServer via internal endpoint.

/assign @unmarshall

What about https://github.com/gardener/dependency-watchdog/pull/44 - can we now drop the RBAC rules for endpoints or are then still needed for something?

We do not need this for dependency-watchdog-probe but it is still needed for dependency-watchdog-endpoint as it watches service endpoints.

We do not need this for dependency-watchdog-probe but it is still needed for dependency-watchdog-endpoint as it watches service endpoints. I see that cluster role rules does not have endpoints resource listed for RoleProbe and that is correct. For RoleEndpoint it is required and what is currently configured should not be changed.

Can you prepare a follow-up PR to drop the endpoint rules that are no longer required?

Can you prepare a follow-up PR to drop the endpoint rules that are no longer required?

The current set of roles are correct and there is no change required.

Do you talk about role-binding?
I also checked the existing role for dependency-watchdog-probe and you are right it has an additional role for endpoints which is no longer required. I will create a follow-up PR for this soon.

Ok, please do so. Thanks!

I also believe that rules for leases (ref and ref) can be moved from the ClusterRoles to the Roles.

ping @unmarshall for https://github.com/gardener/gardener/pull/6436#issuecomment-1207681032 and https://github.com/gardener/gardener/pull/6436#issuecomment-1207684345. Are you looking into it?

Yes i will start working on the PR tomorrow.


[Logs] print size and caps when malloc fails (IDFGH-9267)

Before: Memory allocation failed.
After: Mem alloc fail. size 1600 caps 0x8
When memory allocation fails, we don't get many details. This adds a little bit more info.
I avoided using snprintf, due stack size concerns.

I avoided using snprintf, due to locking concerns.

@chipweinberger  Thanks for the update. I will sync the PR if you don't plan on adding more changes.

@chipweinberger,
There seem to be an issue with this PR. The function fmt_abort_str() needs to placed in RAM as the caller heap_caps_alloc_failed() has to be placed in RAM as well. Unfortunately for us, itoa() is placed in flash on certain boards which makes it impossible to use in fmt_abort_str().
The only viable alternatives I can see here are:

implement ourselves print_hex() and print_dec() and put them in RAM, and lose available RAM
drop the feature all together.

I'll update the PR. A simple function will suffice for hex.
// print a hex number to a buffer
void shex(char buf[8], uint32_t n) {
    for (int i = 0; i < 8; i++) {
        uint8_t b4 = (n >> 28 - (i * 4)) & 0b1111;
        buf[i] = b4 <= 9 ? '0' + b4 : 'a' + b4 - 10;
    }
}

updated!

should be all good now. tested it.

@chipweinberger, I just merged this feature on our gitlab repository. It should be available in master on github in the next sync.

appreciate your work on the PRs. thanks


[Bug][KafkaSource]Fix the default value of commit_on_checkpoint.

Fix the default value of commit_on_checkpoint,it is different from the default value described in the document, and the modification is consistent.

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

LGTM

@EricJoy2048 please merge, thanks.


Question: Why was avcodec and avformat dll file size was big in versions prior to 2.0?

In scrcpy-win32-v1.24, these 2 files were very big in size:

In scrcpy-win64-v2.4, the same files are much smaller in size.

Was there a malware in these dll files?
If not, what caused the files to reduce in size?

That's very nice!


Road to v1.0.0

This is a meta issue to discuss and track progress to a v1.0.0.
A PR exist and is prepared and approved for v1.0.0:

[ ] #491 Typo in CostUpdated Action
[ ] #495 Type of v16.datatypes.SampledValue.context is incorrect
[ ] #496 v201.datatypes.ChargingNeedsType.request_energy_transfer is mistyped
[ ] #497 v16/schemas/StopTransaction.json missing "Hertz" #207

A PR exist and requires review or approval:

[ ] #172  Add dataclasses for ChargingProfile and its constituents
[ ] #475 Add support for python3.11, drop support for python 3.7

The following enhancements can be considered, however, a PR is required:

[ ] #102 Return CallError if Call fails to unpack
[ ] #136 Rewrite API for hooking into requests and responses. Implementation is unknown, maybe #168?

Note that this list can be changed

I removed #136 from the list. The current routing system has it flaws, but I consider it "good enough". It gets the job done.
Rewriting the routing API would probably cause significant breaking changes that puts a massive burden users.

See pre-release - https://github.com/mobilityhouse/ocpp/pull/611

1.0.0-rc.1 released so will close


Update handoff config callbacks for new clique API

The latest version of clique changes the API for config change callbacks, and fixes some issues with the callback behavior when using the --node or --all flags on the "set" command.
NOTE - do not merge this PR until the new clique version is tagged and rebar.config is updated appropriately.

+1 4e90079d1e89f0bc4380b9b01047f71a95b8bd42

@borshop merge


[BUG] only 20 first branches are listed per project

Describe the bug
The branches listed are limited to 20 results
Expected behavior
The branch selector should allow to select any branch in the project.
Actual behavior
The selector allows to select only one of the 20 first branches.
Steps to reproduce

select a project with more than 20 branches.
open the branches selector
see there is only 20 branches listed

Environment

JETBRAINS PLUGIN version 2.0.8
Linux

Additional comments
I think i've identified the cause of this error.
By default the cx CLI returns only the 20 first branches with cx project branches --project-id xxxxx.
You should add --filter limit=1000 to list the 1000 first branches instead.
This plugin code seems to somehow wrap the CLI.

Not related, it would be nice if it could automatically select the current opened projects and branches

Hi @DBarthe!
This is fixed in version 2.0.10.
Thank you for reporting the issue.


Remove skip_before_filter :set_user_by_token in OmniauthCallbacksController

I believe this is unnecessary? It's throwing an error when starting Sidekiq: Before process_action callback :set_user_by_token has not been defined
The stack trace for this error originates from:
... .rvm/gems/ruby-2.2.3@rails5.0/bundler/gems/devise_token_auth-8a6ba641445e/app/controllers/devise_token_auth/omniauth_callbacks_controller.rb:5:inclass:OmniauthCallbacksController'`

Hi there @britg   ,
In an effort to cleanup this project and prioritize a bit, we're marking pull requests that haven't had any activity in a while with a "close-in-7-days" label. If we don't hear from you in about a week, we'll be closing this pull request. Obviously feel free to re-open it at any time if it's the right time or this was done in error! If you do, please rebase it with the latest master and explain why it's still needed.
We really appreciate your contribution, we're just trying to make this project manageable again to move it forward.
Hope all is well.

I've forgotten the context around this PR and will close it. Thanks for the heads up.


[consoleApp] Adding a New IDP via provisioning tab for applications - Crashing

Describe the issue:
When creating an IDP for an application, when finish is clicked without providing any details, the window goes blank.
How to reproduce:
1.Access https://localhost:9443/console
2.Login as super admin
3.Navigate to Develop > Applications > New Application > Vendor Integrations > BOX and add a sample application
4.In the edit view go for the provisioning tab
5. Click + New IDP
6. Click Finish without providing any details
Expected behavior:
The finish button should not be available without the user providing the mandatory details.
Environment information

Product Version: 5.11.0 Beta3
OS: Ubuntu 18.04 LTS
Database: Maria DB 10.4
Userstore: JDBC

Related issue : #10089
This issue was resolved by making the "Provisioning Connector" mandatory.

Making the "Identity Provider" mandatory would fix this issue

This issue has been fixed but the application-create request is sent twice. The first one fails since it is sent without a callback URL.


Update introduction.md

Submitted via Learn Editor.

Internal previews

📄 File
🔗 Preview link

docs/core/introduction.md
What is .NET? Introduction and overview

docs/fundamentals/languages.md
Microsoft .NET language strategy

want to work with me on my branch?
https://github.com/dotnet/docs/pull/38967

Hi @richlander - our repo has been used as a test playground for well over a year now for the Learn Editor that's being worked on. You can ignore this, as it doesn't relate to your work in your branch.