How does one 'start' the app on a connected device?

I'm using "node node_modules/react-native/local-cli/cli.js start"
This is working, but since I'm new at this, just wondering what is the right way to "start" the app, i.e. make it available on my test device over wifi.
Thanks - this repo looks awesome!

gulp android
or
gulp ios

Where is AppDelegate.m ? I'm running android.
I get this when I run gulp android
Installed on 1 device.
BUILD SUCCESSFUL
Total time: 17.943 secs
This build could be faster, please consider using the Gradle Daemon: http://gradle.org/docs/2.4/userguide/gradle_daemon.html
Starting the app (/home/james/Android/Sdk/platform-tools/adb shell am start -n com.este/.MainActivity)...
Starting: Intent { cmp=com.este/.MainActivity }
[bg] Exited with code 0
But I look at my phone and I get the 'unable to download js bundle' message.

Try running adb reverse tcp:8081 tcp:8081 before gulp android

I think these questions belong to stackoverflow.com, sorry. This is for Este only issues.

@steida It might be a good idea to include "common trouble shooting" section for both Android/iOS to save people time. Assuming my suggestion fixes his problem :)

Do it please. I am overloaded with own projects and Este itself.

No worries .. I'll post on SO. I don't have a 'reverse' command.
Don't see one here: http://developer.android.com/tools/help/adb.html
version 1.0.31
SO: http://stackoverflow.com/questions/36205930/este-js-starting-the-android-app

Not sure what you mean, but adb reverse is a command that's been around for awhile. Be sure you're only typing this:
adb reverse tcp:8081 tcp:8081
Looks like you typed incorrectly on the SO question, not sure if you're doing the same thing elsewhere.

Here's the full output:
james@james-Inspiron-5737:/var/www/este-app$ adb reverse tcp:8081 tcp:8081
Android Debug Bridge version 1.0.31
-a                            - directs adb to listen on all interfaces for a connection
-d                            - directs command to the only connected USB device
returns an error if more than one USB device is present.
-e                            - directs command to the only running emulator.
returns an error if more than one emulator is running.
-s           - directs command to the device or emulator with the given
serial number or qualifier. Overrides ANDROID_SERIAL
environment variable.
-p      - simple product name like 'sooner', or
a relative/absolute path to a product
out directory like 'out/target/product/sooner'.
If -p is not specified, the ANDROID_PRODUCT_OUT
environment variable is used, which must
be an absolute path.
-H                            - Name of adb server host (default: localhost)
-P                            - Port of adb server (default: 5037)
devices [-l]                  - list all connected devices
('-l' will also list device qualifiers)
connect [:]       - connect to a device via TCP/IP
Port 5555 is used by default if no port number is specified.
disconnect [[:]]  - disconnect from a TCP/IP device.
Port 5555 is used by default if no port number is specified.
Using this command with no additional arguments
will disconnect from all connected TCP/IP devices.
device commands:
adb push      - copy file/dir to device
adb pull  []  - copy file/dir from device
adb sync [  ]     - copy host->device only if changed
(-l means list but don't copy)
(see 'adb help all')
adb shell                    - run remote shell interactively
adb shell           - run remote shell command
adb emu             - run emulator console command
adb logcat [  ] - View device log
adb forward --list           - list all forward socket connections.
the format is a list of lines with the following format:
 " "  " "  "\n"
adb forward   - forward socket connections
forward specs are one of:
tcp:
localabstract:
localreserved:
localfilesystem:
dev:
jdwp: (remote only)
adb forward --no-rebind
- same as 'adb forward  ' but fails
if  is already forwarded
adb forward --remove  - remove a specific forward socket connection
adb forward --remove-all     - remove all forward socket connections
adb jdwp                     - list PIDs of processes hosting a JDWP transport
adb install [-l] [-r] [-s] [--algo  --key  --iv ]
- push this package file to the device and install it
('-l' means forward-lock the app)
('-r' means reinstall the app, keeping its data)
('-s' means install on SD card instead of internal storage)
('--algo', '--key', and '--iv' mean the file is encrypted already)
adb uninstall [-k]  - remove this app package from the device
('-k' means keep the data and cache directories)
adb bugreport                - return all information from the device
that should be included in a bug report.
adb backup [-f ] [-apk|-noapk] [-shared|-noshared] [-all] [-system|-nosystem] [<packages...>]
- write an archive of the device's data to .
If no -f option is supplied then the data is written
to "backup.ab" in the current directory.
(-apk|-noapk enable/disable backup of the .apks themselves
in the archive; the default is noapk.)
(-shared|-noshared enable/disable backup of the device's
shared storage / SD card contents; the default is noshared.)
(-all means to back up all installed applications)
(-system|-nosystem toggles whether -all automatically includes
system applications; the default is to include system apps)
(<packages...> is the list of applications to be backed up.  If
the -all or -shared flags are passed, then the package
list is optional.  Applications explicitly given on the
command line will be included even if -nosystem would
ordinarily cause them to be omitted.)
adb restore            - restore device contents from the  backup archive
adb help                     - show this help message
adb version                  - show version num
scripting:
adb wait-for-device          - block until device is online
adb start-server             - ensure that there is a server running
adb kill-server              - kill the server if it is running
adb get-state                - prints: offline | bootloader | device
adb get-serialno             - prints:
adb get-devpath              - prints:
adb status-window            - continuously print device status for a specified device
adb remount                  - remounts the /system partition on the device read-write
adb reboot [bootloader|recovery] - reboots the device, optionally into the bootloader or recovery program
adb reboot-bootloader        - reboots the device into the bootloader
adb root                     - restarts the adbd daemon with root permissions
adb usb                      - restarts the adbd daemon listening on USB
adb tcpip              - restarts the adbd daemon listening on TCP on the specified port
networking:
adb ppp  [parameters]   - Run PPP over USB.
Note: you should not automatically start a PPP connection.
 refers to the tty for PPP stream. Eg. dev:/dev/omap_csmi_tty1
[parameters] - Eg. defaultroute debug dump local notty usepeerdns
adb sync notes: adb sync [  ]
 can be interpreted in several ways:

If  is not specified, both /system and /data partitions will be updated.

If it is "system" or "data", only the corresponding partition
is updated.

environmental variables:
ADB_TRACE                    - Print debug information. A comma separated list of the following values
1 or all, adb, sockets, packets, rwx, usb, sync, sysdeps, transport, jdwp
ANDROID_SERIAL               - The serial number to connect to. -s takes priority over this if given.
ANDROID_LOG_TAGS             - When used with the logcat option, only these debug tags are printed.

Try updating to the newer adb? I'm on .32

Done, OK, now I get
adb reverse tcp:8081 tcp:8081
error: cannot bind to socket: Address already in use
I tried this
adb reverse --remove-all
but it didn't have any effect. I couldn't find anything googling about it.
Thanks for staying with me on this.

You're going to have to google that one, that is something with your computer using up the ports

After run npm start on terminal, in your phone, go to Dev Settings -> Debug server host & port for device and set your ip and :8081.
Ex: <IP_ADDRESS>:8081
it works for me.
And my english is terrible, so sorry :v:


Fix the hero image (hopefully) once and for all

Shame on me for testing in prod, but this did indeed work.


WorldBoss Battles bug

Describe the bug
When trying to enter a world boss battle it lets you enter the battle then instantly kicks you out of the battle
To Reproduce
Steps to reproduce the behavior:

Wait for a world boss
do /boss battle
enter battle
see results

Expected behavior
It should allow the player to enter the battle and fight the boss instead of kicking the player out
Username:
itsAmaze
Server name (all applicable):
ALL

This has been moved to our internal tracker, thanks Amazee

no longer an issue, closing


Default configuration can break build

Hi,
First of all - thanks for putting this library together. My wrapper code didn't work nicely with subcharts but this works wonderfully!
I have a quick thought on the default configuration used:
https://github.com/ABTSoftware/scichart-react/blob/50c138d40ef0676bef29206125ce49bdfe564a4d/src/SciChart.tsx#L12-L16
I run my application via Electron, so bundle the scichart data/wasm files in the root directory. Adding this library broke my build as it was looking for the files at my hard drive root, rather than the relative root.
I previously didn't set this configuration, and it worked fine when hosted via a webserver and when bundled in Electron. It took me a while to track down this bug, so I wonder:

Is this a sensible default? Does Scichart not have a built-in sensible default?
Should some documentation be added to let users know that this configuration is being set, and set to something that does not match the usual defaults?

Hello @emab,
First of all, thanks for the feedback. We appreciate it!
Regarding the WASM/data loading configuration:

The core SciChart.JS lib uses an equivalent of

SciChartSurface.configure({
    wasmUrl: undefined,
    dataUrl: undefined
});

SciChart3DSurface.configure({
    wasmUrl: undefined,
    dataUrl: undefined
});

And we have faced multiple issues with this approach especially while using some frameworks.
The configuration used for SciChartReact, on the other hand, seems to be more straightforward and predictable.

You are right about making this difference more explicit in documentation. We'll update it.

For electron, we have created a boilerplate scaffolded with Electron Forge - https://github.com/ABTSoftware/scichart-react/tree/electron-demo/demos/electron
Let us know if there are any issues with a specific setup that we may need to check.

Interesting! For reference, I'm using the React Vite template, and the defaults worked well for dev mode plus my hosted versions in electron and via a web server. I used a plugin to copy the wasm/data files to the public folder on build.
Documentation update sounds like a good plan! And thanks again for putting this package together.


responsive Snackbar?

The Snackbar component is built for a desktop browser, as are the rest of these components. See src/styles/spacing.js to see what I mean. I can only guess that the intention is to also support mobile spacing sometime in the future.


Support conditional requirements in old versions of pip

idea from https://github.com/jkbrzt/httpie/blob/master/setup.py#L46

@IvanMalison I see you made a comment, (I got an email notification) but it's gone now...

Yeah i was worried that we would do things unconditionally, but I was just misreading the code. Looks good to me. I wish there were a way we could test.

I did a:
pip install pip==1.5
pip install .

in my local checkout

yeah I guess we could add a travis environment that does the same thing?

closes #169

Nice! Thanks @graingert.


Can I use it with avfoundation?

Can I use it with avfoundation or only ARKit is available?

Hi, you can use our code with avfoundation too.
You would need to write a dataloader for it similar to this: https://github.com/spla-tam/SplaTAM/blob/main/datasets/gradslam_datasets/nerfcapture.py


gym: error: unable to rename temporary 'xx-yy' to output file 'xx': 'No such file or directory'

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
When running fastlane gym on a VirtualBox VM, it often failed with error: unable to rename temporary 'xx-yy' to output file 'xx': 'No such file or directory'
This issue is same as https://github.com/fastlane/fastlane/issues/4692
Complete output when running fastlane, including the stack trace and command used
+---------------------------+--------------------------------------------------------------+
|                                  Summary for gym 1.8.0                                   |
+---------------------------+--------------------------------------------------------------+
| scheme                    | A                                                       |
| workspace                 | A/A.xcworkspace                                    |
| include_bitcode           | false                                                        |
| output_name               | A                                                  |
| codesigning_identity      | iPhone Distribution: XX |
| provisioning_profile_path | ./fastlane/provisions/x-general-inhouse.mobileprovision |
| export_method             | enterprise                                                   |
| destination               | generic/platform=iOS                                         |
| clean                     | false                                                        |
| output_directory          | .                                                            |
| silent                    | false                                                        |
| use_legacy_build_api      | false                                                        |
| buildlog_path             | ~/Library/Logs/gym                                           |
+---------------------------+--------------------------------------------------------------+

[02:22:46]: $ set -o pipefail && xcodebuild -workspace A/A.xcworkspace -scheme S -destination 'generic/platform=iOS' -archivePath '/Users/vagrant/Library/Developer/Xcode/Archives/2016-05-13/A 2016-05-13 02.22.46.xcarchive' archive | tee /Users/vagrant/Library/Logs/gym/A-A.log | xcpretty
[02:22:48]: ▸ Building Pods/Pods-AFNetworking [Release]
[02:22:48]: ▸ Check Dependencies
[02:22:48]: ▸ Precompiling Files/Pods-AFNetworking/Pods-AFNetworking-prefix.pch
[02:22:56]: ▸ Precompiling Files/Pods-AFNetworking/Pods-AFNetworking-prefix.pch
[02:22:58]: ▸ Precompiling Files/Pods-AFNetworking/Pods-AFNetworking-prefix.pch
...(hide verbose build log)
[17:59:44]: ▸ Compiling JSONAPI.m
[17:59:44]: ▸ Compiling JSONHTTPClient.m
[17:59:44]: ▸ Compiling JSONKeyMapper.m
[17:59:44]: ▸ Compiling JSONModel+networking.m
[17:59:44]: ▸ ❌  error: unable to rename temporary '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/JSONModel+networking-5cdab4.bc-ccc7bbb4' to output file '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/JSONModel+networking-5cdab4.bc': 'No such file or directory'
[17:59:44]: ▸ Compiling JSONModel.m

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
opt_out_usage
fastlane_version "1.102.0"
default_platform :ios
platform :ios do
  lane :test do
    gym
  end
end

Environment
fastlane version (run fastlane -v): fastlane 1.102.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? rbenv

It's not 100% reproduce, and the error is occurred while compiling source code. So I think it's not problem of code signing.

Hi @cybertk Can you share you full input to you gym command? I want to take a look. Thanks!

Full gym parameter is attached,
    gym(
      scheme: "A",
      workspace: "A/A.xcworkspace",
      include_bitcode: false,
      output_name: "A.ipa",
      codesigning_identity: "iPhone Distribution: XX",
      provisioning_profile_path: "./fastlane/provisions/x-general-inhouse.mobileprovision",
      export_method: "enterprise"
    )

@cybertk Do you have read and write access to that temporary folder from the command line in VirtualBox? Thanks!

Yes, I have. It's reproduce at ~5% percent. So most time it works fine, and I used the same VM snapshot for every build job.

Hi @cybertk Can you let me know if the issue is ever reproducible by running the command set -o pipefail && xcodebuild -workspace A/A.xcworkspace -scheme S -destination 'generic/platform=iOS' -archivePath '/Users/vagrant/Library/Developer/Xcode/Archives/2016-05-13/A 2016-05-13 02.22.46.xcarchive' archive | tee /Users/vagrant/Library/Logs/gym/A-A.log | xcpretty
Thanks!

I tried to use the underlying scripts (instead of gym) for ~200 times, can not reproduce the issue.

@cybertk Thanks for following up. I've marked this to see if we can get some help from the community. 👍

This issue is still there on latest gym 1.12.0

@cybertk Sorry to hear that! We'll leave this open until we've confirmed this issue is no longer affecting anyone. Thanks!


Register each item projector as a service

Is it possible have each ItemProjector registered in the container as a separate service with it's own id?
Currently ItemProjector services don't have service id's and there is no way to reuse them or make decorators for each service.
Same goes to the doctrine event listeners (CategorySavedListener etc.).
Is there a reason for this, if not could they be added?

Sorry for such a late response, I'm all for it, but won't have time to do so. If you're willing to add ids to these services, feel free to send a PR :)


Some minor fixes

This change is

Changes Unknown when pulling 15182bbcf618a63a6bb75d2e5370f5022eb8dafe on fixes_0.8.6 into ** on master**.


AGCEvent 2014 (Unable to connect to lobby)

AGCEvent is broken. In event log you will get a 2014 event with the following content:
Description:
Allegiance Server Error
%Message%
This should be easy to fix (See FedSrv\fslobby.cpp line 190).
Imported from trac ticket #79,  created by pkk on 03-26-2010 at 21:37, last modified: 06-29-2010 at 22:34

My patchfile won't fix anything... Just a hazard guess.
Trac comment by pkk on 03-27-2010 at 14:25

r599
Trac comment by Imago on 06-29-2010 at 22:34


Can't host import map inside a folder in google cloud storage

Import map deploy doesn't support a path like gs://bucketname/prod/importmap.json. It throws a 404 error and dies.
But it works when file is hosted directly inside the bucket.

It looks like the problem is related to this regex:
https://github.com/single-spa/import-map-deployer/blob/585b24120846a7f70b00588c9e555b3158ec2a97/src/io-methods/google-cloud-storage.js#L5
It tries to capture the bucket name separately from the object key, but fails to do so because the first .+ is greedy in the regex, but should be lazy. I'll put together a pull request with the fix

Fix is released in https://github.com/single-spa/import-map-deployer/releases/tag/v4.0.1

@joeldenning Many Thanks!


Add decap_permit_packet.o in ebpf-for-windows. msi

Describe the bug
ebpf-for-windows-demo project uses ebpf-for-windows as a nuget package.
For Cilium L4LB test in ebpf-for-windows-demo requires decap_permit_packet.o to be added in ebpf-for-windows.<version>.msi, to help the user to avoid building ebpf-for-windows separately.
This request was brought in PR comment:
https://github.com/microsoft/ebpf-for-windows-demo/pull/69
Requirement:

Add decap_permit_packet.o to .msi
Modify the cilium/load_balancer/docs/CiliumL4LBSetup.md in ebpf-for-windows-demo in Steps 3 - 4 in
"Set Up Windows Backend Node(s)" section.

OS information
Windows 10 and above
Steps taken to reproduce bug
cilium/load_balancer/docs/CiliumL4LBSetup.md in https://github.com/microsoft/ebpf-for-windows-demo/
Expected behavior
Use decap_permit_packet.o from the .msi installation directory.
Actual outcome
The user has to manually build and copy the decap_permit_packet.o from the build machine to the test machine.
Additional details
No response

Verified that the test files are present. Hence closing this issue.
https://github.com/microsoft/ebpf-for-windows/blob/main/docs/InstallEbpf.md#method-1-install-a-release-with-the-msi-installer
decap_permit_packet.o and all the testing files are already present when installed using ebpf-for-windows..msi.
When installing, please select 'Testing'

Testing (optional): this feature adds tests for the eBPF runtime for use by eBPF runtime developers.

PS C:\Program Files\ebpf-for-windows\testing> dir decap*

    Directory: C:\Program Files\ebpf-for-windows\testing

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         7/18/2023   7:58 PM          12384 decap_permit_packet.o
-a----         7/18/2023   7:59 PM          11600 decap_permit_packet.sys

PS C:\Program Files\ebpf-for-windows\testing>


[BUG] All games have no downloads available

Describe the bug
I've been on Hydra for almost a week now and absolutely all the games have no downloads available. On any screen of the application or on the screen of the game itself. The repack sites are working normally when I access them via the browser.
Steps to Reproduce

Open Hydra normally (with or without administrative privileges)
Wait for the games and their respective covers to load
After the games have loaded, no download option appears for any game
Closing and reopening Hydra doesn't change anything. I've tried using a VPN and virtual machines, but the error always persists

Expected behavior
Until a week ago everything worked normally, I opened Hydra and the download options appeared correctly.
Screenshots

Operating System
Microsoft Windows 11 Pro
Hydra Version
2.0.3
Additional Information
No response
Before opening this Issue

[X] I have searched the issues of this repository and believe that this is not a duplicate.
[X] I am aware that Hydra team does not offer any support or help regarding the downloaded games.

I found the solution, I didn't have any download sources. The issues https://github.com/hydralauncher/hydra/issues/937 and https://github.com/hydralauncher/hydra/issues/851 helped me with this.


fix(README.md): wrong cht doc link

There is a wrong link to cht within README.md

Good catch! Thanks


Question about ManualCommitEventConsumer logic

@conker84
I am a little bit confused about the current implementation of KafkaManualCommitEventConsumer. I am looking at the read method, and it looks like it always commits the offset. It doesn't matter if cypher query succeeded or not, because there is a try..catch block around action method calls, and commit happens outside of try..catch. I thought that the logic should be like:
try {
    action()
    commit()
}
except {
    log errors, do smth
}

Can you please explain, what is the point of having such logic that us currently implemented? How it will help us to solve https://github.com/neo4j-contrib/neo4j-streams/issues/102 and how can we achieve "at-least-once" delivery with such logic?

Hi @sintezcs our idea is to always commit with the daemon job and then with the #177 re-route all the failing messages to the DLQ, we allow the manual commit behaviour with the streams.consume procedure where the user can specify if he wants to commit or not the offset. But we are absolutely open to this so please let's discuss.

@sintezcs do you need further details? Or can we close this?

I'm closing this, feel free to reopen in case need additional info


GH-35274: [Java][CI] Enable GCS on MacOS

Rationale for this change
Enables GCS on MacOS when building the Arrow Dataset for Java.
What changes are included in this PR?
CI build to enable GCS
Are these changes tested?
import org.apache.arrow.dataset.file.FileFormat;
import org.apache.arrow.dataset.file.FileSystemDatasetFactory;
import org.apache.arrow.dataset.jni.NativeMemoryPool;
import org.apache.arrow.dataset.scanner.ScanOptions;
import org.apache.arrow.dataset.scanner.Scanner;
import org.apache.arrow.dataset.source.Dataset;
import org.apache.arrow.dataset.source.DatasetFactory;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.memory.RootAllocator;
import org.apache.arrow.vector.ipc.ArrowReader;
import org.apache.arrow.vector.types.pojo.Schema;

public class Test {
  public static void main(String[] args) {
    String uri =<EMAIL_ADDRESS>// Google Cloud Storage
    ScanOptions options = new ScanOptions(/*batchSize*/ 32768);
    try (
        BufferAllocator allocator = new RootAllocator();
        DatasetFactory datasetFactory = new FileSystemDatasetFactory(allocator, NativeMemoryPool.getDefault(), FileFormat.PARQUET, uri);
        Dataset dataset = datasetFactory.finish();
        Scanner scanner = dataset.newScan(options);
        ArrowReader reader = scanner.scanBatches()
    ) {
      Schema schema = scanner.schema();
      System.out.println(schema); // Schema<vendor_name: Utf8, pickup_datetime: Timestamp(MILLISECOND, null), dropoff_datetime: Timestamp(MILLISECOND, null), passenger_count: Int(64, true), trip_distance: FloatingPoint(DOUBLE), pickup_longitude: FloatingPoint(DOUBLE), pickup_latitude: FloatingPoint(DOUBLE), rate_code: Utf8, store_and_fwd: Utf8, dropoff_longitude: FloatingPoint(DOUBLE), dropoff_latitude: FloatingPoint(DOUBLE), payment_type: Utf8, fare_amount: FloatingPoint(DOUBLE), extra: FloatingPoint(DOUBLE), mta_tax: FloatingPoint(DOUBLE), tip_amount: FloatingPoint(DOUBLE), tolls_amount: FloatingPoint(DOUBLE), total_amount: FloatingPoint(DOUBLE), improvement_surcharge: FloatingPoint(DOUBLE), congestion_surcharge: FloatingPoint(DOUBLE), pickup_location_id: Int(64, true), dropoff_location_id: Int(64, true)>
      while (reader.loadNextBatch()) {
        System.out.println("RowCount: " + reader.getVectorSchemaRoot().getRowCount()); //2979
      }
    } catch (Exception e) {
      e.printStackTrace();
    }
  }
}

Are there any user-facing changes?
No

Closes: #35274

@github-actions crossbow submit java-jars

I am seeing error on MacOS aarch_64 with message dyld: lazy symbol binding failed: Symbol not found: _curl_multi_poll @kou / @assignUser  Do you have any idea about the reason of?
Running arrow-gcsfs-test, redirecting output into /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/build/test-logs/arrow-gcsfs-test.txt (attempt 1/1)
/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp/build-support/run-test.sh: line 91: 33793 Abort trap: 6           $TEST_EXECUTABLE "$@" > $LOGFILE.raw 2>&1
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on http://localhost:63593
INFO:werkzeug:Press CTRL+C to quit
INFO:werkzeug: * Restarting with stat
Running main() from /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/googletest_ep-prefix/src/googletest_ep/googletest/src/gtest_main.cc
[==========] Running 99 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 26 tests from TestGCSFSGeneric
[ RUN      ] TestGCSFSGeneric.Empty
dyld: lazy symbol binding failed: Symbol not found: _curl_multi_poll
  Referenced from: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/release/arrow-gcsfs-test
  Expected in: /usr/lib/libcurl.4.dylib

dyld: Symbol not found: _curl_multi_poll
  Referenced from: /Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp-build/cpp/release/arrow-gcsfs-test
  Expected in: /usr/lib/libcurl.4.dylib

...
...

Total Test time (real) = 121.27 sec

The following tests FAILED:
	 61 - arrow-gcsfs-test (Failed)
Errors while running CTest

I think the installed curl version is too old. It looks like libcurl 4 is installed but multi pool was introduced in 7 https://curl.se/libcurl/c/curl_multi_poll.html

@github-actions crossbow submit java-jars

This should fix the m1 issues
--- a/dev/tasks/java-jars/github.yml
+++ b/dev/tasks/java-jars/github.yml
@@ -108,6 +108,7 @@ jobs:
           set -e
           # make brew Java available to CMake
           if [ "{{ arch }}" = "aarch_64" ]; then
+            export CURL_ROOT=$(brew --prefix curl)
             export JAVA_HOME=$(brew --prefix openjdk@11)/libexec/openjdk.jdk/Contents/Home
           fi
           arrow/ci/scripts/java_jni_macos_build.sh \

@github-actions crossbow submit java-jars

Revision: 26d808d
Submitted crossbow builds: ursacomputing/crossbow @ actions-ef819b2719
Task	Status
java-jars

Thank you @assignUser !

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@lidavidm do you have some insight about what I could review to solve this error https://github.com/apache/arrow/actions/runs/5274483912/jobs/9538989549?pr=35277:
[70/122] Generating arrow-flight-glib/ArrowFlight-1.0.gir with a custom command (wrapped by meson to set env)
FAILED: arrow-flight-glib/ArrowFlight-1.0.gir
env PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/build/c_glib/meson-uninstalled /usr/bin/g-ir-scanner --quiet --no-libtool --namespace=ArrowFlight --nsversion=1.0 --warn-all --output arrow-flight-glib/ArrowFlight-1.0.gir --c-include=arrow-flight-glib/arrow-flight-glib.h --warn-all --include-uninstalled=./arrow-glib/Arrow-1.0.gir -I/arrow/c_glib/arrow-flight-glib -I/build/c_glib/arrow-flight-glib -I/arrow/c_glib/. -I/build/c_glib/. --filelist=/build/c_glib/arrow-flight-glib/libarrow-flight-glib.so.1300.0.0.p/ArrowFlight_1.0_gir_filelist --include=Arrow-1.0 --symbol-prefix=gaflight --identifier-prefix=GAFlight --pkg-export=arrow-flight-glib --cflags-begin -I/arrow/c_glib/. -I/build/c_glib/. -I/usr/local/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gobject-introspection-1.0 -DARROW_NO_DEPRECATED_API --cflags-end --add-include-path=/build/c_glib/arrow-glib --add-include-path=/usr/share/gir-1.0 -L/build/c_glib/arrow-flight-glib --library arrow-flight-glib -L/build/c_glib/arrow-glib -L/usr/local/lib -L/usr/local/lib --extra-library=arrow_flight --extra-library=arrow --extra-library=arrow_acero --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=girepository-1.0 --sources-top-dirs /arrow/c_glib/ --sources-top-dirs /build/c_glib/ --warn-error
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::CrcCordState()'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::operator=(absl::lts_20230125::crc_internal::CrcCordState&&)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::CrcCordState(absl::lts_20230125::crc_internal::CrcCordState&&)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::base_internal::StrError[abi:cxx11](int)'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::~CrcCordState()'
/usr/bin/ld: /usr/local/lib/libarrow_flight.so: undefined reference to `absl::lts_20230125::crc_internal::CrcCordState::Checksum() const'
collect2: error: ld returned 1 exit status
linking of temporary binary failed: Command '['x86_64-linux-gnu-gcc', '-pthread', '-o', '/build/c_glib/tmp-introspectci4byn1o/ArrowFlight-1.0', '-DARROW_NO_DEPRECATED_API', '/build/c_glib/tmp-introspectci4byn1o/ArrowFlight-1.0.o', '-L.', '-Wl,-rpath,.', '-Wl,--no-as-needed', '-L/build/c_glib/arrow-flight-glib', '-Wl,-rpath,/build/c_glib/arrow-flight-glib', '-L/build/c_glib/arrow-glib', '-Wl,-rpath,/build/c_glib/arrow-glib', '-L/usr/local/lib', '-Wl,-rpath,/usr/local/lib', '-L/usr/local/lib', '-Wl,-rpath,/usr/local/lib', '-larrow-flight-glib', '-larrow_flight', '-larrow', '-larrow_acero', '-lgobject-2.0', '-lglib-2.0', '-lgirepository-1.0', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0']' returned non-zero exit status 1.
[71/122] Compiling C++ object gandiva-glib/libgandiva-glib.so.1300.0.0.p/expression.cpp.o
[72/122] Compiling C++ object arrow-flight-sql-glib/libarrow-flight-sql-glib.so.1300.0.0.p/server.cpp.o
ninja: build stopped: subcommand failed.

Hmm. It's not reproduced on local...
It seems that the error message show that we need to add Abseil's CRC related modules to https://github.com/apache/arrow/blob/main/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2856-L3756 .
BTW, can we use 20230125.3 https://github.com/abseil/abseil-cpp/releases/tag/20230125.3 ?

@github-actions crossbow submit java-jars

@lidavidm please could you help me to move this PR to draft?, there are some problems on the CI that I need to test and probably need to call it again and again. Thank you in advance

You can find the "Convert to draft" link in the right side bar.

You can find the "Convert to draft" link in the right side bar.

Thank you

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

@github-actions crossbow submit java-jars

In order to define a better alternative solution, the current pull request has been closed.


[DON't MERGE]add list command to click

Next step is
https://stackoverflow.com/questions/48391777/nargs-equivalent-for-options-in-click

Done by Michelle!


Debug console: does not properly handle extended color sequences

VSCode Version: Version 1.15.0 (1.15.0)
OS Version: Darwin ecvaawplun5.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64

Steps to Reproduce:

Run a task which executes a command that generates extended color sequences (such as the rainbow Ruby gem).
As can be seen, certain escape sequences (probably traditional ANSI codes) work, whereas the extended ones are failing. More info about extended color codes can be found here, where the 38,5 prefix is explained more.

The debug console doesn't support extended color sequences because it was never meant to be a real terminal (e.g. it does not even support any input!).
We have no plans to change this.
Please configure your launch config to use an "integratedTerminal" or "externalTerminal". They might support extended colors.

Thanks @weinand

Please configure your launch config to use an "integratedTerminal" or "externalTerminal". They might support extended colors.

I will give this a try. I tried to change this by setting this:
      "console": "integratedTerminal"

...however, it didn't seem to make any difference. I guess this is a problem with the extension being used, not supporting integratedTerminal etc.
I will discuss with the extension author(s). Thanks anyway! 😄

@perlun yes, the debug extension have to opt into the terminals but after they have done, this get the functionality basically for free (because it is implemented on the VS Code side).
Here is the link to the terminal feature that we've added a year ago: https://code.visualstudio.com/updates/v1_5#_additions-to-the-debug-protocol


Cask request: shortcuts

Cask details
Name - shortcuts
Homepage - https://github.com/siong1987/shortcuts
License - MIT
Download URL -
https://github.com/siong1987/shortcuts/releases
https://github.com/siong1987/shortcuts/releases/download/1.0.0/restart.sleep.shutdown.logout.lock.zip
served as .zip file
Description - Five simple apps - that serve five simple purposes: restart, sleep, logout, shutdown, lock.

Added in https://github.com/caskroom/homebrew-cask/issues/16249

Added in https://github.com/caskroom/homebrew-cask/issues/16249

Thank you!


Drop _commit_comment_already_added()

and reuse comment() which runs _has_identical_comment() which can also check commit comments.
comment() now has a new to_commit switch which forces it to operate (check and add) on commit comments even when the instance is tied to a PR.

recheck


feat(navigation): export DaffMagentoNavigationService

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?
[ ] Yes
[x] No

This should be hidden behind the DaffNavigationDriver I don't think that this should be open for interaction at the moment.


[stable/unifi] add mongodb dep requirement

Signed-off-by: Wei Cheng<EMAIL_ADDRESS>
What this PR does / why we need it:
Adding mongodb as part of the requirement to allow this chart to run without setting up an external mongodb resource. While still keeping existing functionality to define external mongodb resource.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @billimek

@billimek would love to get some eyes on this.

Hi @cpwc, this change results in the default behavior to move away from the built-in mongoDB to either an external mongoDB or a sub-chart (external) mongoDB, is this correct?  Is this what we want to do?
I wonder what the issue is with the (current) default built-in mongoDB?  Does it make sense to retain this default behavior and optionally allow for a sub-chart mongoDB, if desired?

@billimek looks like I've missed out the part where unifi already have built-in mongodb packaged together. Should close this PR.


Not agree with that the variable is not used when it used in assignment expression

Example 1 (OK)
No warning because varibale is used.
var x = 0;
x = x + 1;

Example 2 (BAD)
Warning about that the varibale is not used.
var x = 0;
x += 1;

But variable also used because before to add a value (1) to variable x this variable x is used to get it value (as for me, this has no sence which form of assignment I use if I know that variable would be used for read in the expression, explicitly or implicitly).
But if variable x is used to get their value then why I should get message about that the variablex not used?

For me this looks very strange when I do same work but I get a some strange warnings on similar work.
Example:
class Parent {
  Parent() {
    var child1 = child("[");
    var child2 = child("]");
    var child3 = child("("); // <============ The value of local variable `child` is not used
    var child4 = child(")");

    child1 = child1 + child2;
    child3 += child4; // <============ Is this form of assignment is very bad?
  }

  Map<String, Child> children = <String, Child>{};

  Child child(String name) {
    var child = children[name];
    if (child != null) {
      return child;
    }

    child = new Child(name, this);
    children[name] = child;
    return child;
  }
}

class Child {
  Parent parent;

  String name;

  Child(this.name, this.parent);

  Child operator +(Child other) {
    return new Child(name + other.name, parent);
  }
}

Sorry for the delayed response. x is used to get the value for +, but is otherwise unused. This is considered unused.


compactor: Race of sharded compactors causing data loss.

As per discussion, https://github.com/thanos-io/thanos/pull/1901 sharding compactor is currently not fully safe. Please do not use it or use only for smaller setups.
We are working on this, but the reason is also partially explained in https://docs.google.com/document/d/1QvHt9NXRvmdzy51s4_G21UW00QwfL9BfqBDegcqNvg0/edit#
TL;DR:

Compactor A for shard cluster = A is uploading the block X - upload takes more than 30m
Compactor B is syncing all blocks. It see block X that is being uploaded for more than 30m, removing block.

The workaround here is to change --consistencyDelay on Compactor to larger value like 2h, given upload time being quicker than this. This has side effect of compaction process being delayed by 2h which should be fine.
cc @mattrco

[ ] Delay clean up of potential partial uploads to 2 days: https://github.com/thanos-io/thanos/pull/1937
[ ] Add ModifiedTime attribute per object for all object storages and base on that: Help wanted.

@mattrco this should be fixed on master now.

Thanks @bwplotka, is --consistencyDelay required for the master release too?

It is required but for different reasons, mainly for non-consistent object storages. I would suggest leaving the default value.


guard ckpt imports

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

If the user tries to use torchtune without torchvision, it errors, because:
from torchtune.training.checkpointing._checkpointer import ...
from torchtune.models.clip._convert_weights import clip_text_hf_to_tune

which tries to import torchvision
Test:
new env without torchvision
tune run --nproc_per_node 4 full_finetune_distributed --config llama3_2/1B_full

CLI

Should torchvision be an optional dependency? We specify it in our install instructions pytorch/torchtune#install-stable-release

I had the same question. Joe said "Should not need it for anything non-VLM", and Philip agreed too.
As a rule of thumb, if we can avoid importing torchvision for non vision related tasks, its probably better


System.ArgumentNullException with .NET 4.5.2 WebApi

Followed the instruction from
http://hangfire.readthedocs.io/en/latest/tutorials/send-email.html
    [HttpPost]
    public IHttpActionResult SendPostal([FromBody] MyMailModel objModelMail)
    {
        if (ModelState.IsValid)
        {
            try
            {
                var email = new NewCommentEmail
                {
                    To = objModelMail.To,
                    UserName = objModelMail.Subject,
                    Comment = objModelMail.Body
                };

                email.Send();

            }
            catch (Exception e)
            {
                return Ok(e);
            }
        }

        return Ok("Email sent");
    }

Got an exception:
{
"ClassName": "System.ArgumentNullException",
"Message": "Value cannot be null.",
"Data": null,
"InnerException": null,
"HelpURL": null,
"StackTraceString": " at System.Web.HttpBrowserCapabilitiesWrapper..ctor(HttpBrowserCapabilities httpBrowserCapabilities)\r\n at System.Web.HttpRequestWrapper.get_Browser()\r\n at System.Web.WebPages.BrowserHelpers.GetOverriddenBrowser(HttpContextBase httpContext, Func2 createBrowser)\r\n at System.Web.WebPages.DisplayModeProvider.<.ctor>b__2(HttpContextBase context)\r\n at System.Web.WebPages.DefaultDisplayMode.CanHandleContext(HttpContextBase httpContext)\r\n at System.Web.WebPages.DisplayModeProvider.<GetAvailableDisplayModesForContext>d__4.MoveNext()\r\n at System.Web.Mvc.VirtualPathProviderViewEngine.GetPath(ControllerContext controllerContext, String[] locations, String[] areaLocations, String locationsPropertyName, String name, String controllerName, String cacheKeyPrefix, Boolean useCache, String[]& searchedLocations)\r\n at System.Web.Mvc.VirtualPathProviderViewEngine.FindView(ControllerContext controllerContext, String viewName, String masterName, Boolean useCache)\r\n at System.Web.Mvc.ViewEngineCollection.<>c__DisplayClass6.<FindView>b__4(IViewEngine e)\r\n at System.Web.Mvc.ViewEngineCollection.Find(Func2 lookup, Boolean trackSearchedPaths)\r\n at System.Web.Mvc.ViewEngineCollection.FindView(ControllerContext controllerContext, String viewName, String masterName)\r\n at Postal.EmailViewRenderer.CreateView(String viewName, ControllerContext controllerContext)\r\n at Postal.EmailViewRenderer.Render(Email email, String viewName)\r\n at Postal.EmailService.Send(Email email)\r\n at Postal.Email.Send()\r\n at MyTestApp.Controllers.EmailController.SendPostal(MyMailModel objModelMail)",
"RemoteStackTraceString": null,
"RemoteStackIndex": 0,
"ExceptionMethod": "1\n.ctor\nSystem.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a\nSystem.Web.HttpBrowserCapabilitiesWrapper\nVoid .ctor(System.Web.HttpBrowserCapabilities)",
"HResult": -2147467261,
"Source": "System.Web",
"WatsonBuckets": null,
"ParamName": "httpBrowserCapabilities"
}

@youngki924 Can I get a little more info?  What type of project and what target framework version?
Thanks.

@phantomtypist
My current application is deployed to company's app server. So view engines might be different from typical use.
packages.config
package id="Microsoft.AspNet.Mvc" version="5.1.2" targetFramework="net452"
package id="Microsoft.AspNet.Razor" version="3.1.2" targetFramework="net452"
package id="Microsoft.AspNet.WebApi.Client" version="5.1.1" targetFramework="net45"
package id="Microsoft.AspNet.WebApi.Core" version="5.1.1" targetFramework="net45"
package id="Microsoft.AspNet.WebPages" version="3.1.2" targetFramework="net452"
package id="Microsoft.Web.Infrastructure" version="<IP_ADDRESS>" targetFramework="net452"
package id="Newtonsoft.Json" version="4.5.11" targetFramework="net45"
package id="Postal.Mvc5" version="1.2.0" targetFramework="net452"
package id="RazorEngine" version="3.4.1" targetFramework="net452"
//company packages
package id="XXXX.Toolkit.Interfaces.Shared" version="<IP_ADDRESS>" targetFramework="net452"
package id="XXXX.AppServer.Interfaces" version="<IP_ADDRESS>" targetFramework="net452"
I tried FileSystemRazorViewEngine and it worked but that is not what I can use for actual implementation.
https://github.com/andrewdavey/postal/issues/36
Instead of email.Send(), I tried EmailService and customized EmailViewRenderer to set HttpContextWrapper and got the different exception. FindView looks had a problem.
Before
var httpContext = new HttpContextWrapper(
new HttpContext(
new HttpRequest("", UrlRoot(), ""),
new HttpResponse(TextWriter.Null)
)
);
After
HttpRequest request = new HttpRequest("", UrlRoot(), "");
request.Browser = new HttpBrowserCapabilities
{
Capabilities = new Dictionary<string, string>
{
{"majorversion", "10"},
{"browser", "IE"},
{"isMobileDevice","false"}
}
};
// A dummy HttpContextBase that is enough to allow the view to be rendered.
var httpContext = new HttpContextWrapper(
new HttpContext(
request,
new HttpResponse(TextWriter.Null)
)
Exception
{
"ClassName": "System.NullReferenceException",
"Message": "Object reference not set to an instance of an object.",
"Data": null,
"InnerException": null,
"HelpURL": null,
"StackTraceString": " at System.Web.WebPages.FileExistenceCache.<.ctor>b__4(String path)\r\n
at System.Collections.Concurrent.ConcurrentDictionary2.GetOrAdd(TKey key, Func2 valueFactory)\r\n
at System.Web.WebPages.FileExistenceCache.FileExists(String virtualPath)\r\n
at System.Web.Mvc.BuildManagerViewEngine.FileExists(ControllerContext controllerContext, String virtualPath)\r\n
at System.Web.Mvc.VirtualPathProviderViewEngine.<>c__DisplayClass7.b__3(String path)\r\n
at System.Web.WebPages.DefaultDisplayMode.GetDisplayInfo(HttpContextBase httpContext, String virtualPath, Func2 virtualPathExists)\r\n  at System.Web.WebPages.DisplayModeProvider.GetDisplayInfoForVirtualPath(String virtualPath, HttpContextBase httpContext, Func2 virtualPathExists, IDisplayMode currentDisplayMode, Boolean requireConsistentDisplayMode)\r\n
at System.Web.Mvc.VirtualPathProviderViewEngine.GetPathFromGeneralName(ControllerContext controllerContext, List1 locations, String name, String controllerName, String areaName, String cacheKey, String[]& searchedLocations)\r\n  at System.Web.Mvc.VirtualPathProviderViewEngine.GetPath(ControllerContext controllerContext, String[] locations, String[] areaLocations, String locationsPropertyName, String name, String controllerName, String cacheKeyPrefix, Boolean useCache, String[]& searchedLocations)\r\n  at System.Web.Mvc.VirtualPathProviderViewEngine.FindView(ControllerContext controllerContext, String viewName, String masterName, Boolean useCache)\r\n  at System.Web.Mvc.ViewEngineCollection.<>c__DisplayClass6.<FindView>b__5(IViewEngine e)\r\n  at System.Web.Mvc.ViewEngineCollection.Find(Func2 lookup, Boolean trackSearchedPaths)\r\n
at System.Web.Mvc.ViewEngineCollection.FindView(ControllerContext controllerContext, String viewName, String masterName)\r\n
at XXX.MyTestApp.Controllers.CustomEmailViewRenderer.CreateView(String viewName, ControllerContext controllerContext)\r\n
at XXX.MyTestApp.Controllers.CustomEmailViewRenderer.Render(Email email, String viewName)\r\n
at Postal.EmailService.Send(Email email)\r\n
at XXX.MyTestApp.Controllers.TestController.SendPostal(MyMailModel objModelMail)",
"RemoteStackTraceString": null,
"RemoteStackIndex": 0,
"ExceptionMethod": "8\n<.ctor>b__4\nSystem.Web.WebPages, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35\nSystem.Web.WebPages.FileExistenceCache\nBoolean <.ctor>b__4(System.String)",
"HResult": -2147467261,
"Source": "System.Web.WebPages",
"WatsonBuckets": null
}
Thanks

Dumb question, but I want to cover the bases.... this exception occurs on both your machine and the actual server the application is deployed to OR does the exception only occur on the server?

I'll just throw this out there too.  In the folder that I keep the views I had to create a web.config with the following content:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <system.web.webPages.razor>
    <pages>
      <namespaces>
        <add namespace="Postal" />
      </namespaces>
    </pages>
  </system.web.webPages.razor>
</configuration>

This was in an MVC 5 project targeting .NET Framework 4.5.

And another "double-checking" question: Did you try to scaffold a completely blank MVC 5 project with Postal and your Razor view and try to send the email?  You know, just for sanity sake?
I'm somewhat wondering if there is a dependency/reference issue.

With regards to the NuGet packages you have installed... is there anything prohibiting you from upgrading to the newer/latest minor and patch versions of the following packages?:

Microsoft.AspNet.Mvc 5.2.3
Microsoft.AspNet.Razor 3.2.3
Microsoft.AspNet.WebApi.Core 5.2.3
Microsoft.AspNet.WebPages 3.2.3

@phantomtypist
Even on my local, I need to install company's app server locally and deploy my application there.
I am developing Web api and got an error after configuration change to App.conf.
(I don't have web.conf)
pageBaseType was added because it was required:
<system.web.webPages.razor>

</system.web.webPages.razor>
Error: Could not process request: http://localhostxxxx. Exception has been thrown by the target of an invocation.
I did not try pure MVC5 yet.
Thanks.

It seems like you encountered an exception related to the HttpBrowserCapabilitiesWrapper in the provided code. This might be caused by the context in which you're trying to create the email object. The stack trace suggests an issue with the HttpContextBase and HttpBrowserCapabilities. Double-check that you're using the correct context and that all Postal Codes required dependencies are properly set up. It's also beneficial to ensure compatibility with the version of .NET and libraries you are using. Debugging step by step and verifying the inputs could help pinpoint the exact cause of this exception.

Encountering a System.ArgumentNullException in .NET 4.5.2 en vivo WebApp. Any guidance on resolving this issue would be greatly appreciated!

Encountering System.ArgumentNullException with .NET 4.5.2 WebApi can be frustrating. Have you tried debugging your code to pinpoint the source of the null argument? image It might help to review your method parameters and ensure all required values are properly passed. Feel free to share more details for targeted assistance.


Modify the wrong link.

Modify the page with the wrong link.
Add css and code conventions also modified with.

Fixed


Github request: use issue labels

Please start using Github issue labels for all issues. I planned to submit few more issues (feature requests, general discussion, and of course actual issues) but I've been holding off on them partly due to the lack of differentiation between issues. Also, having to prepend each title with the issue type is redundant...
Some of these issues I might end up closing myself in future commits (like I've been doing so far with this week's merges), but it's still good to use labels so that the issues tab isn't so cluttered. And, more importantly, it gives us a chance to discuss things before others (like me) start working on them, thus avoiding wasted work.

The project is just using GitHub's default labels, as you know, which I think are almost adequate for the amount of contributors to the project (aka just you and me really at this point). Remember, there are only two issues open on this project, (and this is one of them! :smile:). I don't we need to worry about hyper-categorizing the issues just yet.
With that said, I'll look into adding a few minor basic ones, but the tagging system should not prevent you from reporting issues!


Ability to set advanced WiFi options

This fixes #10 on Websettings side. :exclamation: Additionally changes in startup script (https://github.com/woutervanwijk/Pi-MusicBox/pull/271) are required!

Changing the startup script, and more importantly testing it with a variety of wifi cards (most of which are full of driver bugs) is the challenge here. There is no point merging this without the corresponding changes.

Thanks! I was developing startup script changes and I just created a pull request for them.
I am testing all of this now on my Raspberry Pi model B with TP-Link TL-WN725N Ver:2.1 adapter.

Looks like there is another bug - wifi_scan_ssid has a default value of true in settingsspec.ini but if it is not mentioned in .ini file it is disabled by default in Websettings.

I have done some tests.
Preparations
pip install -U https://github.com/DavisNT/mopidy-websettings/archive/develop.zip
curl https://raw.githubusercontent.com/DavisNT/Pi-MusicBox/develop/filechanges/opt/musicbox/startup.sh > /opt/musicbox/startup.sh
chmod 4755 /opt/musicbox/startup.sh

Test results
Test case 1: new settings are not present in .ini file
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        key_mgmt=WPA-PSK
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=1
    }

Defaults are also shown in Websettings.
Test case 2: Websettings is opened and Update settings (reboot) is clicked without opening/changing anything.
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
wifi_wpa2_aes = false
wifi_scan_ssid = true
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        key_mgmt=WPA-PSK
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=1
    }

Defaults are also shown in Websettings.
Test case 3: both settings changed in Websettings
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
wifi_wpa2_aes = true
wifi_scan_ssid = false
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        key_mgmt=WPA-PSK
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=0
        proto=RSN
        pairwise=CCMP
        group=CCMP
    }

Changed settings are also displayed in Websettings.

If none of the new settings are changed in Websettings, these pull-requests only add key_mgmt=WPA-PSK parameter inside file /etc/wpa.conf.
@kingosticks Can you do the testing with various adapters?
Another alternative would be adding key_mgmt=WPA-PSK only if Use only WPA2-AES is enabled. Then there would be no changes to /etc/wpa.conf when both new settings have default values.

Is there any way I can facilitate review of this change and get it merged?

Hi sorry I forgot to reply to this one. I don't have any spare wireless sticks to do any useful tests I am afraid.
As a general rule, advanced/specific options which most people don't care about/need, are generally left out of musicbox.The few that do want them can then go on to customise their install as needed. I haven't really had look at this yet to see where this stuff falls.

Thanks for response!
Will adding key_mgmt=WPA-PSK only if Use only WPA2-AES is enabled facilitate the review/merge?
In that case there will be no changes to /etc/wpa.conf in default configuration (if default configuration is not changed).

That certainly sounds like a good idea. Lets try and keep the simple case simple.

I have made this change (it is referenced in pull request https://github.com/woutervanwijk/Pi-MusicBox/pull/271). Repeated test results are here.
Test results
Test case 1: new settings are not present in .ini file
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=1
    }

Defaults are also shown in Websettings.
Test case 2: Websettings is opened and Update settings (reboot) is clicked without opening/changing anything.
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
wifi_wpa2_aes = false
wifi_scan_ssid = true
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=1
    }

Defaults are also shown in Websettings.
Test case 3: both settings changed in Websettings
Files viewed in SSH session:
root@Player:~# grep wifi_ /boot/config/settings.ini
wifi_network = Demo network
wifi_password = Demo Key 12345
wifi_wpa2_aes = true
wifi_scan_ssid = false
root@Player:~# cat /etc/wpa.conf
    ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=netdev
    update_config=1
    network={
        ssid="Demo network"
        psk="Demo Key 12345"
        scan_ssid=0
        key_mgmt=WPA-PSK
        proto=RSN
        pairwise=CCMP
        group=CCMP
    }

Changed settings are also displayed in Websettings.

Currently there are no changes to wpa.conf if new settings are not changed.
Can you please do review and merge this? Or are there any other issues/impediments associated with this change?

I will get to this, sorry.
On 1 May 2015 22:13, "Dāvis Mošenkovs"<EMAIL_ADDRESS>wrote:

Currently there are no changes to wpa.conf if new settings are not
changed.
Can you please do review and merge this? Or are there any other
issues/impediments associated with this change?
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-98240043
.

Hey, finally had a good look at this. The code technically looks fine and I appreciate all your efforts here but I've got a couple of questions.

More options = more confusion and having scan_ssid configurable doesn't gain you anything (except speed, but there are much better optimisations available in that department). So I am afraid i don't see the point there.
Having spent some time looking over wpa_supplicant it looks like all the options you are setting here are already covered by the defaults. What does explicitly restricting them to these options give you? Is it just to force AES encryption and presumably fail if that's not supported (by either end), is that useful behaviour?
What is the point in changing key_mgmt from the default?

I'd imagine most people just leave the wifi_network undefined and provide their own fully customised copy of /etc/wpa.conf. Are these settings really useful enough to other people they belong in the user interface?

Hi! Thanks for looking into this and sorry for my late response!
Here are my comments:

Disabling scan_ssid will (AFAIK only in cases when booted player is moved into range of WiFi network) improve scanning speed and mitigate a theoretical "security risk" (ability for the intruder to determine to what WiFi network the player tries to connect when the player is not within the range of the network). I mainly added this because wpa_supplicant docs states "this will add latency to scanning, so enable this only when needed" and (before you mentioned that it is a workaround for buggy drivers) scan_ssid=1 looked like a default providing no real benefits, but promoting hiding SSID (which is a false-sense-of-security measure as SSID is sent in 802.11 management frames).
Setting proto=RSN, pairwise=CCMP and group=CCMP should help preventing some really complex attacks (e.g. RSN to WPA downgrade + TKIP explotation) on WiFi networks allowing WPA and legacy ciphers.
key_mgmt=WPA-PSK should do nothing unless there is some kind of unknown bug in wpa_supplicant (or the defaults will gt changed). This was the reason I added it into default configuration in the beginning.

Mostly this patch is for "security paranoids" and I know that there are bigger security issues in Pi MusicBox (e.g. globally writable boot partition that contains files modified by Mopidy process).
I agree that these options will not be usable for most users and keeping settings as simple as possible is a good point for not including these changes in Pi MusicBox.
However I think that possibility to customize Pi MusicBox configuration could be improved. May be we could introduce an option (that would be hidden in interface) in settings.ini that would contain a list of files that startup.sh will not overwrite? AFAIK this would solve many other customization issues as well.
Currently I didn't found any cleaner ways to customize wpa_supplicant configuration than changing /etc/network/interfaces and creating modified wpa.conf with another filename.

I think that is a very good idea. As it is, providing you don't set the
wifi_network option, musicbox won't overwrite any wpa_supplicant config
that you setup yourself. But that fact could be made more obvious, and it
could extend to other things (as you say).
Regarding scan_ssid, its just a case of having something that works for
everyone (albeit unnecessarily slowly in some cases) versus something more
complicated and potentially confusing for users, many of which are new to
this. The security risk here is really quite paranoid! But anyway, if we
sort out a clear way for people to easily provide their own custom settings
this isn't an issue.
On 10 May 2015 22:21, "Dāvis Mošenkovs"<EMAIL_ADDRESS>wrote:

Hi! Thanks for looking into this and sorry for my late response!
Here are my comments:

Disabling scan_ssid will (AFAIK only in cases when booted player is
moved into range of WiFi network) improve scanning speed and mitigate a
theoretical "security risk" (ability for the intruder to determine
to what WiFi network the player tries to connect when the player is not
within the range of the network). I mainly added this because
wpa_supplicant docs states "this will add latency to scanning, so enable
this only when needed" and (before you mentioned that it is a workaround
for buggy drivers) scan_ssid=1 looked like a default providing no real
benefits, but promoting hiding SSID (which is a false-sense-of-security
measure as SSID is sent in 802.11 management frames).
Setting proto=RSN, pairwise=CCMP and group=CCMP should help
preventing some really complex attacks (e.g. RSN to WPA downgrade + TKIP
explotation) on WiFi networks allowing WPA and legacy ciphers.
key_mgmt=WPA-PSK should do nothing unless there is some kind of
unknown bug in wpa_supplicant (or the defaults will gt changed). This was
the reason I added it into default configuration in the beginning.

Mostly this patch is for "security paranoids" and I know that there are
bigger security issues in Pi MusicBox (e.g. globally writable boot
partition that contains files modified by Mopidy process).
I agree that these options will not be usable for most users and
keeping settings as simple as possible is a good point for not
including these changes in Pi MusicBox.
However I think that possibility to customize Pi MusicBox configuration
could be improved. May be we could introduce an option (that would be
hidden in interface) in settings.ini that would contain a list of files
that startup.sh will not overwrite? AFAIK this would solve many other
customization issues as well.
Currently I didn't found any cleaner ways to customize wpa_supplicant
configuration than changing /etc/network/interfaces and creating modified
wpa.conf with another filename.
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-100703556
.

We could allow people to just drop their custom asound.conf or
wpa_supplicant.conf or samba whatever configs in the /boot/config
directory. The  startup script can then copy the files to the correct place
if they exist, and otherwise run through the current script as normal.
On 10 May 2015 22:57, "Nick Steel"<EMAIL_ADDRESS>wrote:

I think that is a very good idea. As it is, providing you don't set the
wifi_network option, musicbox won't overwrite any wpa_supplicant config
that you setup yourself. But that fact could be made more obvious, and it
could extend to other things (as you say).
Regarding scan_ssid, its just a case of having something that works for
everyone (albeit unnecessarily slowly in some cases) versus something more
complicated and potentially confusing for users, many of which are new to
this. The security risk here is really quite paranoid! But anyway, if we
sort out a clear way for people to easily provide their own custom settings
this isn't an issue.
On 10 May 2015 22:21, "Dāvis Mošenkovs"<EMAIL_ADDRESS>wrote:

Hi! Thanks for looking into this and sorry for my late response!
Here are my comments:

Disabling scan_ssid will (AFAIK only in cases when booted player
is moved into range of WiFi network) improve scanning speed and mitigate a
theoretical "security risk" (ability for the intruder to determine
to what WiFi network the player tries to connect when the player is not
within the range of the network). I mainly added this because
wpa_supplicant docs states "this will add latency to scanning, so enable
this only when needed" and (before you mentioned that it is a workaround
for buggy drivers) scan_ssid=1 looked like a default providing no
real benefits, but promoting hiding SSID (which is a
false-sense-of-security measure as SSID is sent in 802.11 management
frames).
Setting proto=RSN, pairwise=CCMP and group=CCMP should help
preventing some really complex attacks (e.g. RSN to WPA downgrade + TKIP
explotation) on WiFi networks allowing WPA and legacy ciphers.
key_mgmt=WPA-PSK should do nothing unless there is some kind of
unknown bug in wpa_supplicant (or the defaults will gt changed). This was
the reason I added it into default configuration in the beginning.

Mostly this patch is for "security paranoids" and I know that there are
bigger security issues in Pi MusicBox (e.g. globally writable boot
partition that contains files modified by Mopidy process).
I agree that these options will not be usable for most users and
keeping settings as simple as possible is a good point for not
including these changes in Pi MusicBox.
However I think that possibility to customize Pi MusicBox
configuration could be improved. May be we could introduce an option (that
would be hidden in interface) in settings.ini that would contain a list
of files that startup.sh will not overwrite? AFAIK this would solve many
other customization issues as well.
Currently I didn't found any cleaner ways to customize wpa_supplicant
configuration than changing /etc/network/interfaces and creating
modified wpa.conf with another filename.
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-100703556
.

Ability to place config files inside FAT32 partition sounds like a great idea! :+1:
A related off-topic: The only thing I am wondering now is how to protect /boot from being world-writable (and preferably also from being world-readable). Are /boot/config/settings.ini and /boot/config/streamuris.js only files that are used by Mopidy?

Yes. Just those two currently I think.
Ability to place config files inside FAT32 partition sounds like a great
idea! [image: :+1:]
A related off-topic: The only thing I am wondering now is how to protect
/boot from being world-writable (and preferably also from being
world-readable). Are /boot/config/settings.ini and
/boot/config/streamuris.js only files that are used by Mopidy?
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-101018644
.

I have two ideas about this:

Some kind of bind (or most likely bindfs) mount that could control access.
Mounting /boot with umask=027 and having a temporary folder /opt/musicbox/config writable by Mopidy. A startup script (e.g. existing startup.sh or a separate script) would copy files from /boot/config to /opt/musicbox/config and a shutdown script would copy files back from /opt/musicbox/config to /boot/config.

What do you think about these options? I actually like second idea much better, because it is much more simple.

With the hope of preventing what exactly?
On 11 May 2015 21:36, "Dāvis Mošenkovs"<EMAIL_ADDRESS>wrote:

I have two ideas about this:

Some kind of bind (or most likely bindfs) mount that could control
access.
Mounting /boot with umask=027 and having a temporary folder
/opt/musicbox/config writable by Mopidy. A startup script (e.g.
existing startup.sh or a separate script) would copy files from
/boot/config to /opt/musicbox/config and a shutdown script would copy
files back from /opt/musicbox/config to /boot/config.

What do you think about these options? I actually like second idea much
better, because it is much more simple.
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-101040383
.

With the idea of preventing globally writable /boot. It is very good that Mopidy already is not running as root, but currently any application (running under any user account) can gain unlimited access to entire OS (by installing so called insecure kernel or compromising boot configuration and waiting for the user to reboot).
I assume that Raspbian originally had /boot writable only by root (or mounted read-only).

I'm not sure what it originally had but you'd hope so.
Would an additional very small partition specifically for the two musicbox
config files be another alternative?
There is the possibility that we'll want the musicbox process to be able to
write to some of the other files in /boot. Specifically to handle the new
device tree overlay stuff when switching soundcards.
On 12 May 2015 06:52, "Dāvis Mošenkovs"<EMAIL_ADDRESS>wrote:

With the idea of preventing globally writable /boot. It is very good that
Mopidy already is not running as root, but currently any application
(running under any user account) can gain unlimited access to entire OS (by
installing so called insecure kernel or compromising boot configuration and
waiting for the user to reboot).
I assume that Raspbian originally had /boot writable only by root (or
mounted read-only).
—
Reply to this email directly or view it on GitHub
https://github.com/woutervanwijk/mopidy-websettings/pull/12#issuecomment-101140519
.

Hi! Sorry for my late response!
I think additional partition is not very good idea! I suggest staying as close to Raspbian as possible. Actually I think it would be a great idea to create apt package of Pi MusicBox that could be used to update Pi MusicBox specific customizations (or even installed on vanilla Raspbian to turn it into Pi MusicBox).
For making parts of /boot writable I would suggest one of these options:

Copying files back and forth by scripts.
Using BindFS to do the re-mounting with less restrictive permissions.


How are file Pointers passed

`* (py4cl2-cffi:import-module "pickle" :as "pkl")
T

(with-open-file (stream "/mnt/d/Worker/Lisp/test/xx.plk" :element-type '(unsigned-byte 8))
(py4cl2-cffi:pycall "pkl.load" (sb-sys:fd-stream-fd stream)))

debugger invoked on a PY4CL2-CFFI:PYERROR in thread
#<THREAD tid=53 "main thread" RUNNING {1001128093}>:
A python error occurred:
file must have 'read' and 'readline' attributes
Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.
restarts (invokable by number or by possibly-abbreviated name):
0: [CONTINUE-IGNORING-ERRORS]
1: [ABORT                   ] Exit debugger, returning to top level.
(PY4CL2-CFFI::PYTHON-MAY-BE-ERROR)
source: (ERROR 'PYERROR :FORMAT-CONTROL "A python error occurred:~%  ~A"
:FORMAT-ARGUMENTS (LIST VALUE-STR))`

Currently, there is no native translation for file stream objects. To implement this, one would have to implement a py4cl2-cffi:pythonize method returning a pointer to an appropriate CPython object.
However, you can also write a python function that takes a lisp object, like string, and read the file in python itself. So, something like -
(py4cl2-cffi:raw-pyexec "
def read_python_object(filename):
  with open(filename, 'b') as f:
    return pkl.load(f)
")

Okay, thank you！


add check for SA to client if not found in cache

Issue #, if available:
#174
Description of changes:
Trying to solve a race condition in aws-identity pod where serviceaccount and pod get created at the same time. It uses cache to check SA which might not be ready when the pod was created. In order to solve this if a SA is not found in the cache but is expected do not allow the request through so it gets retried later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jsilverio22 We're encountering this issue in our clusters and wondering if this fix could get merged. Have you heard from any maintainers on this?


no builds inside 1.0.25 folder on buildbot

Thanks for updating the latest build link, however it looks like there arent any builds in your folder.
https://buildbot.vigem.org/builds/Legacinator/master/1.0.25/

True, let me check that 🤔

Ah I see why, because the build for that version already expired, triggering a new one.

Here we go.

Very cool. Buildabot doesn't have a URL like https://buildbot.../latest that you could link to in the readme?

Nope, the concept of "latest" doesn't exist on CI. Only build numbers which correspond to the build output version numbers. Why would you need a link like that? It's not recommended to share that anyway, only advanced users should tinker with the build artifacts, everyone else is supposed to use the GitHub releases, which do in fact offer a "latest" URL.

Nope, the concept of "latest" doesn't exist on CI. Only build numbers which correspond to the build output version numbers.

I understand what you are saying but this is not necesarilly true. If you were publishing with GitHub actions and releasing, there are URLs that correspond to different artifact paths.  There is a URL that is quite popular that people use to pull the "latest" build, this can be "pre releases" or regular releases. https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases

Why would you need a link like that? It's not recommended to share that anyway, only advanced users should tinker with the build artifacts, everyone else is supposed to use the GitHub releases, which do in fact offer a "latest" URL.

Its not that I personally need it, but your Readme insinuates that you are linking to the latest "beta" or "pre release" "experimental" release.  It seems with buildbot you either have to link to the base folder or manually update to the latest artifact path which is not ideal from a functional perspective. Not a big deal, but just trying to provide some helpful feedback from the context of your Readme.

I removed it as it seems to be only confusing, GitHub releases are the relevant ones anyway 😉

I understand what you are saying but this is not necesarilly true.

It is on my particular setup 😉


Configuration file format support

Is there a reason you can't support both YAML and JSON? A lot of people (myself included) would rather use JSON instead of YAML. Given this module appears to have once supported JSON, it seems odd that support for it would be completely removed instead of just supporting both formats.

You're right that the jobber file was originally in JSON.  I switched to YAML b/c I felt that JSON was quite verbose.    A big advantage to YAML is that you can plop a whole shell script into the "cmd" attribute without having to escape quotes, as long as you add appropriate whitespace at the beginning of each line.  But then, a disadvantage is that, if you're not familiar with YAML, the syntax is not obvious.
Why do you prefer JSON?
I'm reluctant to support both since it adds complexity without (I think) a huge benefit.

By the way, at the very beginning one had to name each time component in the config file, thus:
 [
    {
        "name": "Echo",
        "cmd": "(echo \"Hello\" >> result) && whoami",
        "time": { "sec": 0, "min": 0 }
    }
]

I switch to the cron way of specifying the time b/c I figured it would be more familiar to ppl.  What do you think would be best?


Support managing credentials

Hi,
This is a wishlist item to request support for credential management: https://juju.is/docs/olm/manage-credentials

This includes:

juju add-credentials
juju update-credential
juju remove-credential


fix: update patch to use DefaultBackoff

using DefaultBackoff rather than DefaultRetry should result in fewer conflicts with other controllers.
in addition, we also change removeFinalizer() to use our patch function.

closing in favor of using controllerutil's createOrPatch() rather than our own Patch with Retry


Swift 3

Hey @anatoliyv,
I'd love to help InfoView to be ported to Swift 3. Can we create a new branch for that?

Hey @lfarah
Sure. Here it is swift3
Thank you in advance!


Better handling of empty base_machineset

Before this change, not specifying the base machineset would cause an
error because the ansible code treated an empty "" string differently
from an unset variable altogether.
This change makes it so the toolbox script leaves the base_machineset
variable empty, rather than have it be an empty string

/test gpu-operator-e2e

/cc @kpouget

Thank you for the PR, Omer.
/lgtm


Software pop-up position problem

Hi！After right-clicking, the pop-up menu is located in the taskbar, can it appear on the top of the taskbar, so that it looks more reasonable!
Have you considered left-clicking and then the selection menu appears? Or offer similar setup options

All the Windows builtin tray icons show their context menu on top of the taskbar so I think that's the convention. Is there something it is blocking that you would like to look at while the menu is open?
Since left clicking does nothing now, I can update the code to make the menu open on both left and right clicks


WFCORE-6716 Drop obsolete default getStability() method…

… now that WFCORE-6650 is available in WF full.
https://issues.redhat.com/browse/WFCORE-6716

Core -> Full Integration Build 13318 outcome was FAILURE using a merge of 40bc4332638341d8cb2ecb305231c87f00f144f1
Summary: Compilation error: Compiler (new) Build time: 00:06:20

Core -> WildFly Preview Integration Build 13375 outcome was FAILURE using a merge of 40bc4332638341d8cb2ecb305231c87f00f144f1
Summary: Compilation error: Compiler (new) Build time: 00:06:52

Core -> Full Integration Build 13560 outcome was FAILURE using a merge of 40bc4332638341d8cb2ecb305231c87f00f144f1
Summary: Tests passed: 1404, ignored: 21; compilation error: Compiler (new) Build time: 00:10:56

Adding hold label until remaining WF-full changes are in place.

Thanks @pferraro


[IMPROVEMENT] Add prep work for fixing the corrupted filesystem using fsck in KB

Is your improvement request related to a feature? Please describe
fsck usually needs to be run to fix a corrupted filesystem. It is possible, however, that the incorrect fsck fix might cause serious data loss and corruption.
To mitigate the risk, a snapshot of the corrupted filesystem should be taken before any fix attempts are made. In case of an accident, the user can recover the volume. We can suggest the prep work in the KB.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
https://serverfault.com/questions/786648/when-is-fsck-dangerous
https://docs.portworx.com/reference/cli/volume-check/

@derekbit Can you please help with the reproduction steps, so that we can test this?


Some concurrency fixes, some configurability

Trying to fix blocking operations, such as objects patching, event posting, etc

Issue : https://github.com/zalando-incubator/kopf/issues/111

Description

Added config - kopf.config.WorkersConfig - class attributes based options to control async workers. So user can just import it before all other kopf modules and change values to required. Maybe not the best decision, but any.
So now can be configured number of next types of workers: queue processing, object patching, event creation.
Blocking synchronous operations such as event creation, changed objects patching, are now asynchronous (i guess).
Added kopf.config.EventsConfig.events_loglevel  to control what types of logs should trigger event sending - INFO/WARNING/ERROR/CRITICAL

Existing tests updated for new async functions.
E2E tests required to test performance(how fast large number of new/changed objects can be processed). Such tests would prove efficiency of kopf concurrency.
Types of Changes

New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Configuration change
Refactor/improvements

Tasks
List of tasks you will do to complete the PR

[ ] Documentation
[ ] E2E performance tests
[ ] Review?

Review
List of tasks the reviewer must do to review the PR

[ ] Tests (don't know if there could be tests to do)
[ ] Documentation (maybe?)

As a side-note: I tried to check why Travis CI pipeline is not triggered for this PR, and for this PR only — it works for other PRs & contributors. Travis CI says "Abuse detected" without any additional explanation.
I will try to contact Travis CI support to clarify what is the actual reason.
My only assumption for now is that this is a PR from the "master" branch of a fork to the "master" branch of the upstream — maybe Travis does not like it. This is the only "unusual" thing in this PR. Just guessing.


Avoid using unsupported methods

Object.keys and Array.prototype.map are not supported in older browsers (IE8 and lower)

Will let @thlorenz have the final word here but I think it's perfectly reasonable in 2015 to assume that people who need to support older browsers will use an ES5 polyfill.

Since this is a testing tool, it would be great if it worked seamlessly in IE8!
I am using this to build an npm package so a polyfill doesn't really work for me

I don't think it would be good to include a polyfill along with an npm package as it would monkey-patch globals
Using a polyfill just for testing would defeat the point of testing the module on IE8.

Including it in the source of an npm package is a definitely a bad idea, no questions there. And yes, requiring a polyfill does mean that it's tricky for you're basically assuming that your users are supplying a polyfill as well, at least as far as the tests are concerned. I think it's fair to start insisting people do that in order to support a browser that's less than a year from being end-of-lifed in order to write code that's better for everyone else.

I appreciate your sentiment, there is nothing I would like to do more than drop IE8 support. Unfortunately I am building a tool that will track browser usage share among other things so I don't really have an option.
For me, the only alternative is to fork the repo and publish it to npm under a different name. I would like to avoid this if possible so I will wait for @thlorenz to weigh in before going further.
I would agree with you that this bloats the code for no good reason however since it is a testing tool I think it is a reasonable patch. That being said, I think proxyquireify is pretty awesome, it would be a shame to have to use a fork every time I want to use it!

Unfortunately I am building a tool that will track browser usage share among other things so I don't really have an option.

You couldn't add a polyfill to your tests?
If you give me a use case which cannot be fixed with a polyfill I'm actually open to adding this feature to proxyquireify.
I'm just not convinced that you couldn't just require('some-polyfill-module') at the top of your test which then fills in the missing methods before proxyquireify uses them.

I could polyfill the test however this would defeat the point of running the test on older browsers e.g. if I was to use a method like Object.keys in my code, the test would pass despite it being unsupported.

Why don't you just run those tests, then polyfill before running  the tests that depend on proxyquierify?
Yours is a very unique use case and since a workaround exists, even for your case I'm hesitant to change this module for it.
However you're free to publish a proxyquireify-es3 in case you're not satisfied with the work around.

I can't really afford to test any part of the code with a polyfill as it would be wrong to claim IE8 support if I did so. I have used this module multiple times in the project (because it seems to be by far the best way to do dependency injection).
If you don't want to merge, I will go ahead with a fork. This library has been pretty helpful so keep up the good work :+1:.

@roberttod Just a heads up that proxyquireify will be adding more ES5 code soon (Object.defineProperty), see https://github.com/thlorenz/proxyquire/issues/64#issuecomment-103401453. I'll ship an ES3-compatible method in the key filling lib that you can use in your fork.

Thanks!


Remove use of real_center_indices

This PR removes some real_center_indices loops. A step towards https://github.com/CliMA/ClimaAtmos.jl/issues/887.

bors r+


fix: Ensure resourceDuration variables in metrics are always in seconds

Fixes: https://github.com/argoproj/argo/issues/4402
~Still needs tests~
Signed-off-by: Simon Behar<EMAIL_ADDRESS>Checklist:

[ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ ] My organization is added to USERS.md.
[ ] I've signed the CLA.
[ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[ ] My builds are green. Try syncing with master if they are not.

Back-ported to 2.11


Support selecting albums to use in the screensaver

With Photos integration on the Chromecast, you have to select specific albums to display. I think for most people, showing all photos randomly is good. However, I really liked being able to limit the slideshow to photos that we'd curated and shared. Any thoughts on adding this as a feature?

Excellent Roku app, Chris - yes I'd love to have this feature too

would love this feature too, I never really prune my pictures so lots of boring pics that i'd prefer not to be on the screensaver.  being able to point to an album(s) of favorite pics would be awesome!

Thumbs up...  The one thing ChromeCast and Amazon fire have over Roku is awesome screensavers.  But your app could resolve this shortcoming with this feature.  If the screensaver could be limited to a folder then a user could download the same images Chromecast has (https://gist.github.com/dconnolly/8188825)  or Amazon fire has (https://mega.co.nz/#F!thFw3aLY!OWSR9oW5BXNHdbm3No19iw) and then upload those into a custom album and make that album the Roku screensaver. In fact, you could setup a single public album with these pictures and then make this a setting for the users to use these albums.

I'd love to make a plug for this, too, and wish I could help make it happen. My photo collection is a huge assortment ranging from the sentimental to the practical (e.g. a can of paint whose color I want to remember). At the moment the proverbial can of paint pops up alongside my more meaningful photos. Being able to point to an album as a source would be fantastic.

Agreed with all the above comments.  Your app is great, this additional feature would make it phenomenal.

Targeted for inclusion in the new version, during the move over to screen graphs.

This much requested feature as made it into the v2.0 release!  You can check out the BETA VERSION here: https://my.roku.com/account/add?channel=RZ5TQ6
Testing is continuing and will be published to the public channel soon.


[chip,external_clock] Improve clkmgr_external_clk_src_for_sw tests

Add code to disable external clocks after they have been enabled and, using cycle counts, verify the system is back to running with nominal frequencies.
Fix a bug in the clkmgr's external clock SVA.
Fixes #16836

This PR depends on https://github.com/lowRISC/opentitan/pull/18049, and will fail until that is merged.


Temporarily "leaving" the curses mode

I am asking for help.
Problem description
Hi,
I am trying to figure out how to temporarily leaving the curses mode so that I can spawn a command-line program (for example, bash), and the user can interact with it.
I have searched the documentation and can't find a specific function to achieve this. The best I could think of was to save the current state, exit Cursive entirely using siv.quit() and when the external program is finished, a new Cursive instance is started. But I think this is too inconvenient and prone to mistakes.
During my research, I found out a library from another language contains such functionality: https://metacpan.org/pod/Curses::UI#leave_curses-(-) so I think Cursive should be able to do the same.
Did I miss something or Cursive currently does not have similar functionality?
Thanks!
Environment

Operating system: Arch Linux (x86_64)
Backend used: ncurses

If using ncurses on linux, ncurses version? 6.2

Current locale

LANG=zh_CN.UTF-8
LC_CTYPE="zh_CN.UTF-8"
LC_NUMERIC="zh_CN.UTF-8"
LC_TIME="zh_CN.UTF-8"
LC_COLLATE="zh_CN.UTF-8"
LC_MONETARY="zh_CN.UTF-8"
LC_MESSAGES="zh_CN.UTF-8"
LC_PAPER="zh_CN.UTF-8"
LC_NAME="zh_CN.UTF-8"
LC_ADDRESS="zh_CN.UTF-8"
LC_TELEPHONE="zh_CN.UTF-8"
LC_MEASUREMENT="zh_CN.UTF-8"
LC_IDENTIFICATION="zh_CN.UTF-8"
LC_ALL=

Cursive version crates.io version 0.15.0

Hi, and thanks for the report!
This is a planned feature, however it's not currently available. See also #199 and #358.
Right now the only alternative is to stop cursive entirely (and drop the Cursive object); this will revert the terminal to normal; then start cursive again when desired.
Note that you can keep views around even if you drop Cursive. StackView::pop_layer returns the view it removes, so you can pop all layers, save them, drop Cursive, run another program, create a new Cursive, and push the layers back.

Note: to ease the "dump it all, bring it back", we could help define a cursive::Dump struct, and provide methods on Cursive to generate and load that.
It'd include the list of layers, the current global callbacks, and maybe would re-connect the callback sinks.

Note: to ease the "dump it all, bring it back", we could help define a cursive::Dump struct, and provide methods on Cursive to generate and load that.
It'd include the list of layers, the current global callbacks, and maybe would re-connect the callback sinks.

Thanks for your reply! Yeah, a cursive::Dump would be awesome to have! This opens up much more possiblities.

Hi, and thanks for the report!
This is a planned feature, however it's not currently available. See also #199 and #358.
Right now the only alternative is to stop cursive entirely (and drop the Cursive object); this will revert the terminal to normal; then start cursive again when desired.
Note that you can keep views around even if you drop Cursive. StackView::pop_layer returns the view it removes, so you can pop all layers, save them, drop Cursive, run another program, create a new Cursive, and push the layers back. (EDIT: just realized that's exactly what you're suggesting >_< )
It's far from ideal, so we still plan on adding proper "pause" support later on.

Right. Thanks for the links to the issues, and sorry for opening a duplicate issue report. I think I will stick to the original plan then.
Also thank you for making Cursive!

Just added on master Cursive::dump and Cursive::restore. Tell me if it works for you!

Just added on master Cursive::dump and Cursive::restore. Tell me if it works for you!

Will do with pleasure!

Just added on master Cursive::dump and Cursive::restore. Tell me if it works for you!

Hi there, I just tried and it worked in my case (yay!).
Although I have a complain which you might not be able to / want to address: because I used siv.run() in my main loop, the current dump/restore implementation does not allow me to do it easily in a callback (Cursive does not have Copy or Clone), thus I need to use a hack to pass a state to my main (telling that it's a pause, not a quit) to do something after the callback.
I understand the reason behind the current implementation, so if you are reluctant to make dump not moving out the reference, I am fine with the hacks.
Also, huge thanks for the incredibly fast implementation!

On latest master Cursive::dump takes a &mut self instead of consuming self.
Note that the resulting Cursive instance will be cleaned out, like new.

On latest master Cursive::dump takes a &mut self instead of consuming self.
Note that the resulting Cursive instance will be cleaned out, like new.

Thanks for the changes! Now it works like a charm in my case.
Because I need to reset the terminal, I need to drop the previous instance anyways. So I am not worried about the previous instance being wiped clean.

Is there any way to restore terminal without dropping Cursive?


Make VictoryAnimation wrapper optional

I've encountered a perf problem with views that 1.) contain multiple Voronoi backgrounds and 2.) rely on a (debounced) window resize listener to resize/randomize the Voronoi elements--resizing the window gets super laggy (happy to demonstrate in person, if you're interested). Thing is, I don't want the triangles to animate at all: they're a static background, and it's OK if their resize transition isn't animated. Profiler confirms that VictoryAnimation is what's slowing things down (regardless of velocity, etc).
This simply makes the VictoryAnimation wrapper optional (via animate prop, default true), as a quick fix for use cases like mine.
/cc @boygirl @angelanicholas @exogen

cc/ @david-davidson approved. code nitpick at your discretion since this one is slated for refactor anyway.