--help for migrate doesn't print anything.

Trying to follow the instructions deploying this to a Docker Swarm and struggling to get ./citadel migrate to run.
~ # ./citadel migrate --help
Run the database schema migrations

Usage:
  citadel migrate [flags]

Flags:
  -h, --help   help for migrate

Can this migration not be smarter like can it just detect if the migration hasn't been done and then just do it?    Ideally, just migrate the database automatically if there's nothing detected in the tables so that the app can work out of the box.

The --help flag literally just prints the usage. Not very helpful I know but that's what it does right now.
As far as migrations running automatically, I'm hesitant to do this as I prefer them to be separate steps. Perhaps I will change this in the future.

That’s not a useful command in a Docker swarm deployment sadly but i
understood how to translate it. The less mocking about I’m required to do
in a container command line the better really.
On Sat, Jul 25, 2020 at 3:48 AM Jordan Knott<EMAIL_ADDRESS>wrote:

The --help flag literally just prints the usage. Not very helpful I know
but that's what it does right now.
As far as migrations running automatically, I'm hesitant to do this as I
prefer them to be separate steps. Perhaps I will change this in the future.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JordanKnott/project-citadel/issues/25#issuecomment-663824523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIE2VX52KTYEGTUZFNP3G3R5KE5TANCNFSM4PHKSLOQ
.

Oh, docker swarm. I've never used that so I'm not much help.
I might add a way to have migrations run on app start-up if an env flag is set ( which would be useful for me during dev) so that its at least an option for those that want it.

I’ll take it! Can it be used momentarily in deployment and have a bit of
smarts in it for the sake of not clobbering the preexisting data?
On Sat, Jul 25, 2020 at 4:00 AM Jordan Knott<EMAIL_ADDRESS>wrote:

Oh, docker swarm. I've never used that so I'm not much help.
I might add a way to have migrations run on app start-up if an env flag is
set ( which would be useful for me during dev) so that its at least an
option for those that want it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JordanKnott/project-citadel/issues/25#issuecomment-663825543,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIE2VTP4LMH5Y2AAUSHU4DR5KGI3ANCNFSM4PHKSLOQ
.

Hmm, I'm not sure what you mean?
Migration steps only run if they haven't been ran already.

Then why not just run the migration steps always?
On Sat, Jul 25, 2020 at 4:10 AM Jordan Knott<EMAIL_ADDRESS>wrote:

Hmm, I'm not sure what you mean?
Migration steps only run if they haven't been ran already.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JordanKnott/project-citadel/issues/25#issuecomment-663826499,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIE2VQEXCKQEAH6JUFUVV3R5KHN5ANCNFSM4PHKSLOQ
.

Because sometimes you want to run migrations as separate step (such as if you have multiple web instances) however I do think at least having the ability to run migrations on startup would be helpful (especially in a dev env)
Closed in favor of #29


[PE-D][Tester E] Chinese character set not recognised as 'm/' argument for add command

Input:
add aw m/你好 by/3
Expected output:
added a new 'aw' task with module code 你好 and deadline 3pm
Actual output:

Labels: type.FunctionalityBug severity.Low
original: yeehaoo/ped#4

We forgot to update the usage text. We will clarify that module codes are alphanumeric in v1.4 .


Xcode 9.3+ recommended addition of IDEWorkspaceChecks.plist

Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace's shared data, to store the state of necessary workspace checks. Committing this file to source control will prevent unnecessary rerunning of those checks for each user opening the workspace. (37293167)

https://developer.apple.com/library/archive/releasenotes/DeveloperTools/RN-Xcode/Chapters/Introduction.html

Good stuff! Thanks!


Exception processing PDF with bad character encoding (0.5.4+)

When processing a PDF that has bad character encoding, GROBID now responds with error 500 because it can't parse the generated LXML:
ERROR [2019-07-29 15:19:19,034] org.grobid.service.process.GrobidRestProcessFiles: An unexpected exception occurs.
! org.apache.xerces.impl.io.MalformedByteSequenceException: Invalid byte 2 of 3-byte UTF-8 sequence.
! at org.apache.xerces.impl.io.UTF8Reader.invalidByte(Unknown Source)
! at org.apache.xerces.impl.io.UTF8Reader.read(Unknown Source)
! at org.apache.xerces.impl.XMLEntityScanner.load(Unknown Source)
! at org.apache.xerces.impl.XMLEntityScanner.scanLiteral(Unknown Source)
! at org.apache.xerces.impl.XMLScanner.scanAttributeValue(Unknown Source)
! at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanAttribute(Unknown Source)
! at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown Source)
! ... 80 common frames omitted
!  Causing: org.grobid.core.exceptions.GrobidException: [PARSING_ERROR] Cannot parse file: /path/to/grobid/grobid-home/tmp/PwmNNKmeZ2.lxml
! at org.grobid.core.document.Document.addTokenizedDocument(Document.java:404)

xmllint isn't happy either:
$ xmllint special-characters.lxml
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : Char 0xD835 out of allowed range
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : invalid character in attribute value
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : attributes construct error
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : Couldn't find end of Start Tag String line 3
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : Char 0xD835 out of allowed range
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^
/home/deuser/_git_/elife/pdf-xml/data/elife/issues/issues-grobid-0.5.4-plus-conversion/sample/special-characters.lxml:3: parser error : PCDATA invalid Char value 55349
font0"/><SP WIDTH="2.75" VPOS="72.35" HPOS="83.25"/><String ID="p1_w2" CONTENT="
                                                                               ^

In GROBID 0.5.3 the string is extracted as 10 í µg of special characters which is also what is in the LXML for the latest version.
There is obviously an issue further in the document conversion. And in this case it seems to stem from the .docx file to use a Windows font that wasn't available when it was converted to .pdf. But it would be nice if it extracted what it could.
Files:
special-characters.docx
special-characters-bad-character-encoding.pdf
special-characters.lxml.zip

The difference with previous versions, could be related with pdfalto?

It's actually an issue primarily for pdfalto. pdfalto should detect all invalid character codes - so if we have something which cannot be solved into a correct UTF-8 code, for some various reasons, we should have a place holder and not propagate some invalid unicode range to the ALTO file. Why it's not working here is unclear at first look, and it requires to look at the character encoding with pdfalto.

Hello,
I don't know where to comment about this issue, but as far as I remember, I've added an option in pdfalto (-ocr)  which is meant to recognize such characters, since I didn't make much improvements regarding the ocr, those chars are replaced with some placeholders.
I need to do some tests to make sure


fix(tree): use on-load will cause infinite loop

closes #4038

Codecov Report
Base: 62.60% // Head: 62.62% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (7057c15) compared to base (946af01).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4043      +/-   ##
==========================================
+ Coverage   62.60%   62.62%   +0.01%
==========================================
  Files        1069     1069
  Lines       22357    22351       -6
  Branches     5854     5852       -2
==========================================
  Hits        13997    13997
+ Misses       6844     6838       -6
  Partials     1516     1516

Impacted Files
Coverage Δ

src/tree/src/Tree.tsx
34.84% <ø> (ø)

src/tree/src/TreeNode.tsx
64.51% <0.00%> (+2.97%)
:arrow_up:

src/tree/src/interface.ts
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fixed in https://github.com/tusen-ai/naive-ui/commit/b74d62a5e9732ee66d38523f6d57bf2a7105e328


Review a binary file returns an error message

When clicking [Review] on a binary file, the following message shows up:
Command execution failed:
fatal: cannot stat path 'Binary file gradle/wrapper/gradle-wrapper.jar matches': No such file or directory
Consider handling this better way:

do not allow for viewing such a file
open a file by browser

Bin files are ignored.


Document website flags/data

layout: docs
title: babel-register (require hook)
description: How to use babel-register, the require hook.
permalink: /docs/usage/babel-register/
redirect_from:
 - /docs/usage/require/
package: babel-register <--

If we add more of these we should explain them somewhere on the readme

cc @xtuc
If someone is new they might not include what
{% include package_readme.html %}

does so I wonder if we should add like an html comment above all of these to point to the readme in the repo to edit it?

I'm not sure if the implementers need to know where the README is expected to be.
We should tell them that if they implement package A, they need to specify package: A in the header.
Also if the repo isn't Babel, add the from parameter in the include.
Do you think this is clear enough ?

Yeah just some way in general to let them know what's going on

Since we documented this in the README, can we close this ?

Yeah


Update build to 1.1.0

Signed-off-by: Vijayan Balasubramanian<EMAIL_ADDRESS>Description
update build settings to 1.1.0
Issues Resolved
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This is already merged #91


Move RcaConf into AppContext

Fixes #:
Description of changes:
Move RcaConf into AppContext. The current rcaconf object can only be read from vertices in RCA graph. By moving this into AppContext, we can read it from any other places(action object etc.)
Tests:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Are there any other changes depending on this PR?


Add extra info on annotation inexact type

For most builtin types, Cython interprets an annotation to mean that an exact type is required. This is stricter than PEP-484 and occassionally causes confusion.

Adds a bit more detail to the exception message in these cases (or to __notes__ in Python 3.12+) to explain.
Add a note in the migration guide.

I've only applied this to function arguments. Applying it to general assignments would be possible but looks significantly more complicated so I thought it better to cover the main case.
Related issue: https://github.com/cython/cython/issues/5908

I'm taking an executive decision that this is good....

3.0.x 04502f6af

I've reverted this on 3.0.x. Things have been refactored slightly here so it doesn't merge correctly onto that branch.  It doesn't seem like a significant enough improvement to justify too much effort backporting this. It'll be in 3.1.


Is pagination now forcefully the rightmost element on the heading?

Prior to v8 buttons could be moved to the right side of it, now it appears pagination is always on the right end.

Could be a bug, I'll look into it.

It seems pagination is not on the list of dragable items


Remove Buoy

This wasn't moved/updated in the dist file: https://github.com/cferdinandi/smooth-scroll/blob/master/dist/js/smooth-scroll.js#L14

Right you are!


Adds before/after app get/list. And some bug fixes/cleanup.

This looks bigger than it is since there's a search and replace for server.Database -> server.Database().
Main gist is that it adds:
+	BeforeAppGet(ctx context.Context, appName string) error
+	AfterAppGet(ctx context.Context, app *models.App) error
+	BeforeAppsList(ctx context.Context, filter *models.AppFilter) error
+	AfterAppsList(ctx context.Context, apps []*models.App) error

And some changes to support this.
Example where these changes are required is: https://github.com/treeder/fn-ext-auth/tree/master/simple

I was wondering where you were going with that, first off, you can't have the method and the var with the same name, so we can't just keep it as it was unless we call it something else. Which is fine, I don't care, call it Datastore2 if you want, but it's also not used anywhere that requires it to be exported, so....

Maybe we can come back to that if it needs to be exported for something?

Even then, it might make sense to have it as a function so extensions could swap it out via the interface, ie: SetDatastore(...).

i see. meh, GetDatastore is fine. i'm just anal and everything else is exported on *Server, but for what reason i'm less sure of since we provide options for configuring it and it probably shouldn't change after configuration and as long as we provide access to those things (through a method or an exported field), then sure whatever.

anyway, approved.. i can make vanity patches with some tools for however we want to munge stuff. i'm leaning towards lower casing the other things like datastore is now (can do that separate)


Document Pipeline

Create a simple pipeline to help compose loaders and transformers to yield document loaders.

Can we add also text splitters to this pipeline? I'm not sure this addition fits the current design, just a thought.

Converted back into draft mode. We'll try to find a more general approach using runnables. Otherwise we're re-inventing sync/async/batch/abatch and concurrency every time.
@leo-gan text splitters are instances of transformers so they will be accommodated by this design, but we're going to hold off for a bit to see if we can handle more known requirements for a pipeline design

@eyurtsev If this PR is not needed anymore, could you, please, let me know or close this PR?


Move to Netlify

As discussed in #1 we can't really use Glitch, because the server goes to sleep very quickly and it requires a long wait every time it's queried.
This PR changes the code from an Express server to a Netlify static site (which is currently just a single page) with a serverless function that generates the pdfs.

@danfishgold Have you deployed this to a production netlify somewhere? I'd like to link out to it from the www site. Maybe add the url to the README here?


use spotMin/Max instead of spotRatio

this is to support spotInstance. Originally spotInstance use spotRatio to set the size of spotInstance ASG which is not flexible. by using min/max to allow user define what they need independent of the base ASG. We also remove the Free Instances Lending setting as it is not currently implemented and not used.

I have two questions:

UI buttons: previously "sensitivity ratio" is only displayed when "Allow Spot Instances" is checked. now with this change is "sensitivity ratio" box always there or still controlled by "Allow Spot Instances"?
still controlled by allow spot instances.
Is there a limit of max size? when % was used, there is an upper limit.
there is no limit of max size. this is to allow flexibility of any size of spot instance indenpendent of base ASG. for example to have a 0 size base ASG and an any size spot ASG.

after talking to customer, hide the sensitivity ratio and default it to 0 so the spot ASG has the same alarm setting as the base ASG to avoid complexity and confusion.


Clarify the options to return the access_token

I had a bad time trying to return access_token from Azure B2C because it was not so clear that I should pass the client_id in the list of scopes to return the access_token. This is particularly painful in Postman's OAuth2 authentication because it only supports access_tokens today (may/2022).
Please clarify this issue with more emphasis. Also, it would be ideal to add and example of how to perform the whole auth process on Postman :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 836ec1be-7675-d0f1-c861-0520dc3ea01e
Version Independent ID: c6a2a6f6-57fd-20ae-36f7-b6db1987ebe5
Content: Request an access token - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/access-tokens.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@mariomeyrelles Thank you for your feedback. We will review and update as appropriate.

@mariomeyrelles The scope doesn't necessarily has be the application ID. Ideally you should expose the app as api, set the App ID URI and then add the scope, as highlighted below. You should then pass the app-id-uri/scope in the authentication request.


memory setting ignored for Vbox

Trying to set memory with the following
driver:
  name: vagrant
  provider:
    name: VBox
platforms:
  - name: ubuntu14
    box: ubuntu/trusty64
    memory: 8192

But the memory remains at 512.

As may be seen in examples of Vagrantfiles with virtualbox here: https://www.vagrantup.com/docs/providers/virtualbox/configuration, the provider name is virtualbox (all lower case), so your molecule.yml should look like:
driver:
  name: vagrant
  provider:
    name: virtualbox
platforms:
  - name: ubuntu14
    box: ubuntu/trusty64
    memory: 8192

For now, using the wrong provider name will still get a VM created, even if the settings are kind-of ignored. I've been wondering for quite some time to add to the vagrant up command the --provider $providername argument which will possibly result in an error if the provider name is wrong. Unfortunately it may break some people setup....

Thanks for the quick response. Having a warning about provider name mismatch might be a good start. I don't remember where I found the configuration example that had VBox, but and example on the readme page would be a nice-to-have.  If I have time this weekend, I will submit a PR to add it.

Related regarding the usage of VBox: https://github.com/ansible-community/molecule-vagrant/issues/91


feat: automatically tune GOMEMLIMIT and GOMAXPROCS

Description
github.com/KimMachineGun/automemlimit is an imported package that automatically sets the GOMEMLIMIT runtime variable.
go.uber.org/automaxprocs is an imported package that automatically sets the GOMAXPROCS runtime variable.
Both of these variables tune the Golang runtime to prevent consuming too many resources. In particular, GOMEMLIMIT tells the Golang runtime to by default only use 90% of the detected environment's available memory.
Purpose
Helps with memory leaks.

In my opinion I would not add these kind of things to the node.

Closing since we can manually set these variables in our iac code.


draper doesn't work with ActiveModelSerializer 0-9-stable branch

I caught the following error:
/Users/tricknotes/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/draper-1.4.0/lib/draper/railtie.rb:48:in `block (2 levels) in <class:Railtie>': uninitialized constant ActiveModel::ArraySerializerSupport (NameError)

see: https://github.com/drapergem/draper/blob/v1.4.0/lib/draper/railtie.rb#L48
Work versions:

AMS 0.8.x: It has ActiveModel::ArraySerializerSupport
AMS 0.9.0: It has no ActiveModel::ArraySerializerSupport. But it doesn't run load hooks - so it works.

Doesn't work version:

AMS 0.9.1: It has no ActiveModel::ArraySerializerSupport. And run load hooks - so it doesn't work.

@tricknotes Are you saying Draper is working for you with 9.2 version of AMS? Because I am getting this same error with 9.2

Me too :+1:

Last working version is 9.0.0

Receiving the same error.

@KurtRMueller on version 0.9.0 you still have error?

Hey @savroff, after reverting back to 0.9.0, I no longer receive the error.

I have addressed this in #596, which I'm going to rebase atop the latest master and hopefully we can get it merged.

Hi there. Any news on this one? Thanks.

Same error on 0.9.3 :squirrel:

we are having this error with 0.9.3, too. but for other colleagues that have 0.9.0 it works perfectly fine.

@nirnaeth We have the same issue that we discovered during Rails4.2 upgrade. 0.9.3 gives this error, while 0.9.0 does not. Though 0.9.0 has another big bug - #746, which is affecting us now. Any idea when will a fix for this issue be released? So that we can have a gem which has both these bugs fixed?

Hi @drapergem, any news on this one? Thanks.

+1

+1

+1

+1

I'll jump on board too. :+1: I currently use @stevenharman's branch.

+1

+1

+1

+1

+1

+1

Pull request patch fixes the issue for me.
+1

Please try 2.0 and reopen if the problem pops up again.

:heart: thank you @jcasimir

It works fine for me. Thanks :whale:

Sweet!

This is going to be so helpful for us... I'm so glad we trusted you'd get
this sorted and worked on some other items the past few weeks. Thanks for
getting this all figured out so quickly.
On Thu, Mar 26, 2015 at 10:22 PM, Jeff Casimir<EMAIL_ADDRESS>wrote:

Sweet!
—
Reply to this email directly or view it on GitHub
https://github.com/drapergem/draper/issues/644#issuecomment-86828967.


fix: allow rest parameters to follow multiple optional - or not - parameters

Fixes https://github.com/sveltejs/kit/issues/8601
Actually, managed to clean up the whole thing and make it work with every valid test case I could think of.
It's not pretty (it's not that bad either), but it works.
There's still a case it doesn't solve though, but I'm fairly confident we got time before someone actually goes for such thing.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[X] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[X] This message body should clearly illustrate what problems it solves.
[X] Ideally, include a test that fails without this PR but passes with it.

Tests

[X] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[X] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

this is a thing of real beauty — thanks so much! absolutely fantastic


Movement Mechanic Added

Two way mechanic added

Pull Request To Merge feature/protoype

Pull request to merge feature/protoype into feature/development


super in initialize does not catch type error when given a union

Bug Report
Reduced:
class A
  def initialize(x : Int32)
  end
end

class B < A
  def initialize(x)
    super(x)
  end
end

B.new(nil.as(Int32?)) # crashes
B.new("hello".as(String | Int32)) # crashes
B.new(123.as(String | Int32)) # crashes
# etc...

The error:
Module validation failed: Load operand must be a pointer.
  %5 = load half, i32 %4, align 2, !dbg !11
 (Exception)
  from /crystal/src/range.cr:450:9 in 'finish'
  from /crystal/src/compiler/crystal/codegen/codegen.cr:71:7 in 'codegen'
  from /crystal/src/compiler/crystal/compiler.cr:162:16 in 'compile'
  from /crystal/src/compiler/crystal/command.cr:215:5 in 'run_command'
  from /crystal/src/compiler/crystal/command.cr:64:5 in '__crystal_main'
  from /crystal/src/crystal/main.cr:115:5 in 'main'
  from src/env/__libc_start_main.c:95:2 in 'libc_start_main_stage2'

Related to (is the cause of?) #9249.
The second part of this bug is that this way, we can cause Crystal to compile (and run!) invalid stuff. I believe this only works with objects -- with e.g. Int32, it'll crash as above. If you make Chicken a struct, it'll print weight: 0.
class Chicken
  def initialize(@weight : Int32)
  end

  def die
    # The object was allocated but ivars have no values (?)
    puts "Chicken dead with weight: #{@weight}"
  end
end

class Cook
  def initialize(@chicken : Chicken)
  end

  def fry
    @chicken.die
  end
end

class Pete < Cook
  def initialize(chicken)
    super(chicken)
  end
end

c = Pete.new(nil.as(Chicken?))
c.fry # Segfaults

And of course we can get junk!!
struct Chicken
  def initialize(@x : Int32)
  end
end

struct Mammoth
  def initialize(@x : Float64, @y : Float64 = x, @z : Float64 = x)
  end
end

class Cook
  def initialize(@mammoth : Mammoth)
  end
end

class Pete < Cook
  def initialize(mammoth)
    super(mammoth)
  end
end

p Pete.new(Chicken.new(456) || Mammoth.new(123)) # Chicken | Mammoth
# #<Pete:0x7f3d972f0f90<EMAIL_ADDRESS>@y=4.65929017468467e-310, @z=5.0e-324)>

... etc
Version:
Crystal 1.6.2 [879691b2e] (2022-11-03)

LLVM: 13.0.1
Default target: x86_64-unknown-linux-gnu

I think it might be related to https://github.com/crystal-lang/crystal/issues/2293 and probably a duplicate


npm run dev is broken with<EMAIL_ADDRESS>

Describe the bug
I bootstrapped new project using solid-start but when trying to start it I get the error originating from solid-js/dist/server.cjs
To Reproduce
Provide a code snippet and steps to reproduce the behavior:

mkdir my-app
cd my-app
npm init solid@next
npm install
make sure that only version 1.2.6 of solid-js is intalled: npm ls solid-js
npm run dev -- --open

Expected behavior
No error, example app runs correctly.
Actual behavior
$ npm run dev -- --open

> dev
> solid-start dev "--open"

Pre-bundling dependencies:
  solid-js
  solid-js/web
  solid-js/store
  solid-js/html
  solid-js/h
(this will be run only when your dependencies or config have changed)
http://localhost:3000
TypeError: Cannot read properties of undefined (reading 'id')
    at wrap (C:\dev\my-app\node_modules\solid-js\dist\server.cjs:385:37)
    at Proxy.createComponent (C:\dev\my-app\node_modules\solid-js\dist\server.cjs:229:10)
    at Object.element.component.element.element [as outlet] (/node_modules/solid-app-router/dist/routing.js:59:35)
    at Object.get children [as children] (c:/dev/my-app/node_modules/solid-app-router/dist/components.jsx:56:57)
    at C:\dev\my-app\node_modules\solid-js\dist\server.cjs:138:35
    at C:\dev\my-app\node_modules\solid-js\dist\server.cjs:106:43
    at createMemo (C:\dev\my-app\node_modules\solid-js\dist\server.cjs:54:13)
    at children (C:\dev\my-app\node_modules\solid-js\dist\server.cjs:106:10)
    at C:\dev\my-app\node_modules\solid-js\dist\server.cjs:138:14
    at createMemo (C:\dev\my-app\node_modules\solid-js\dist\server.cjs:54:13)

Additional context
Downgrading solid-js to 1.2.5 fixes the issue:

Make sure you're using npm that supports overrides: npm i -g<EMAIL_ADDRESS>Apply this change:diff --git a/package.json b/package.json
index b7bd862..21928be 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
   "type": "module",
   "devDependencies": {
     "solid-app-router": "^0.1.14",
-    "solid-js": "^1.2.6",
+    "solid-js": "1.2.5",
     "solid-meta": "^0.27.2",
     "solid-start": "next",
     "solid-start-node": "next",
@@ -16,5 +16,8 @@
   },
   "engines": {
     "node": ">=12"
+  },
+  "overrides": {
+    "solid-js": "1.2.5"
   }
 }

rm -rf package-lock.json node_modules
npm install
make sure that only version 1.2.5 of solid-js is intalled: npm ls solid-js
npm run dev -- --open

$ npm run dev -- --open

> dev
> solid-start dev "--open"

Pre-bundling dependencies:
  solid-js
  solid-js/web
  solid-js/store
  solid-js/html
  solid-js/h
(this will be run only when your dependencies or config have changed)
http://localhost:3000
You appear to have multiple instances of Solid. This can lead to unexpected behavior.
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed
computations created outside a `createRoot` or `render` will never be disposed

Let me guess.  You're building on Windows?  Me too.
I've filed an issue with Vite.

It's funny the change was specifically to handle something in Vite 2.7.x which was resolving dev mode on the server rendering. Is it possible different deps are pulling in different versions. vite-plugin-solid has been particularly problematic. Also moving to SolidStart as this seems Solid Start related.


Sentinl plugin for Kibana 6.5.1

Hi there,
First thank you for Sentinl.
Is there a chance to get a Sentinl v6.5.1 for Kibana 6.5.1 ?

@StefanSa  @SexyCatGirls  here is the package https://github.com/sirensolutions/sentinl/releases/download/tag-6.5.0-0/sentinl-v6.5.1.zip


Show system notifications for errors

Uses webpack-notifier under the hood. No setup necessary.
Supports Notification Center on OS X, Toaster on Windows 8 and later.
Falls back to Growl if present.
(https://github.com/mikaelbr/node-notifier/blob/master/DECISION_FLOW.md)
Ref #89.
Notifications look like this:

for this error:
Error in ./src/App.js
Syntax error: /Users/goshakkk/Projects/oss/create-react-app/demo/src/App.js: Unexpected token (11:38)
   9 |

  10 |
> 11 |
Welcome to React z
<<div
     |                                       ^
  12 |

  13 |

  14 |           To get started, edit src/App.js and save to reload.
 @ ./src/index.js 11:11-27

Possible to supply a custom image to webpack-notifier, could be React logo. Considerations: eject will have to copy the logo as well. Might be okay though.

Custom title is supported by webpack-notifier. "React" might be a bit too broad, "React Scripts" or "Create React App" or "React CLI" might be better.

Custom error formatter is not supported, plus terminal coloring artifacts are present ([4m). Not currently possible to supply a custom formatter to webpack-notifier. Ideally the message should have been

Error: ./App.js
Unexpected token (11:38)

Full path & parts of stack trace seem irrelevant for the notification. Error message is much more informative.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Maybe consider name from package.json for a custom title?

Why do you want a system notification for every error? - they are already displayed from the npm start process. To me this seems like a customization that some but not most developers will want, and so the right thing to do if you would like system notifications for each error is to eject and then customize webpack accordingly, rather than turn it on for everyone by default.

I’m not sure we’ll want to go with this but I’d like to try it out this week and see what it feels like.
If notifications can be muted on system level, maybe we could include this by default.
But I haven’t tried it so can’t say whether it’s annoying or useful to me.

By default notifications are turned off from 8pm to 8am on mac, which is very confusing when it stops working for no apparent reason :(
Unrelated but this little script is awesome: http://frantic.im/notify-on-completion

Thanks for the PR. I think we won’t go ahead with this as it seems a little too intrusive.


FPDM Output Not Saving File

Using FPDM and instead of viewing the merge doc I am attempting to auto-save the doc on the server with variations of this syntax:
$pdf -> Output('filename.pdf', \folder\Destination::FILE);
No matter what I try I get an error and it will not save the results in a PDF file on the server.
(if i do not specify the DESTINATION:: i get incorrect output destination, if I include it then I get a class Destination not found error)
Can anyone help me with a variation of this command that will save the merged PDF doc?  or perhaps a different method?
Thanks!

I also found a constructor for the FPDM class where there is a var for output, and the second parameter is used for an FPDF file if any, so it would be the third parameter, but have had no luck passing the ouput file name as a parameter or getting the class to simply save the PDF


Why Blockchain Why Web3?

utilities in blockchain(Crypto, Defi, NFT) through web3
60-90 Mins Teach Me Something Workshop
Advance
Blockchain&cryptocurrency

Hey!
Can you please describe in detail what your talk covers?


Issue with Import for ApplePass

I appreciate the work done to setup this wonderful library that helps Python developers to generate Apple Passes smoothly.
I found that inside client.py, the import is done by the following statement:
from models import ApplePass
But, there is no module with ApplePass inside applepassgenerator. I suggest the import should like the following because ApplePass belongs to models module:
from applepassgenerator.models import ApplePass
Please let me know if any more information is required.

hey @viral-vora , Thanks for reporting this issue, we have fixed it in the latest 0.0.2 release 🚀

Do you have anything similar for generating Google Wallet passes?

No, we haven't explored Google Wallet Passes yet.

Ok, Thank you.


Fix race condition in filters

This fixes an extremely rare race condition where packets that arrive between a filter update and the clearing of the filter input are ignored.

@neworderofjamie, are you happy with this? If so I'll squash and merge.


i18n(ko-KR): create astro-assets.mdx

Description (required)

create astro-assets.mdx

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
reference/modules/astro-assets.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[nrf fromlist] zephyr: enable usb by the application

Since https://github.com/zephyrproject-rtos/zephyr/pull/20375
Need to enable USB by the application.
merge after #81

for usb-cdc-acm recovery: USB is enable only if recovery was trigrred
for usb-class -dfu: USB is enable always

Notice that usb_disable() can be called even if USB was not enabled as it is self protected against not initialized USB.
upsteram patch https://github.com/JuulLabs-OSS/mcuboot/issues/651
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

To be merged post-release

This repository's history has been rewritten for the v1.2 release. Please rebase this PR if still relevant, or close it if no longer needed. Thanks!

rebased
[DNM] as prefer to have this in upcoming upmerge, keep this PR just in case.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update TSIG key algorithm

Update TSIG key algorithm from HMAC-MD5 to HMAC-SHA512.

Codecov Report

Merging #190 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #190      +/-   ##
=========================================
+ Coverage    93.6%   93.6%   +<.01%
=========================================
  Files         113     113
  Lines        3880    3881       +1
  Branches       83      78       -5
=========================================
+ Hits         3632    3633       +1
  Misses        248     248

Impacted Files
Coverage Δ

...cala/vinyldns/api/domain/zone/ZoneViewLoader.scala
100% <100%> (ø)
:arrow_up:

.../scala/vinyldns/api/domain/dns/DnsConnection.scala
92.42% <100%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f2c96...c734aa5. Read the comment docs.

@pauljamescleary That's a good point. I will close this and reference it in https://github.com/vinyldns/vinyldns/pull/190 for later pick up.


Errors installing<EMAIL_ADDRESS>

I get the following permission errors, tho I am installing with sudo. This is on OSX 10.6. I can't follow the directions it gives (sudo npm install...) b/c I can't run npm commands b/c no such commands exists until it is installed...? I previously had an old unsupported version working, but it was cleaned up with the install (is that correct?)
Here is the readout:
fetching: http://registry.npmjs.org/npm/-/npm-1.0.6.tgz
0.4.7
1.0.6
prefix=/usr/local
This script will find and eliminate any shims, symbolic
links, and other cruft that was installed by npm 0.x.
Is this OK? enter 'yes' or 'no'
yes
All clean!
! [ -d .git ] || git submodule update --init
node cli.js cache clean
node cli.js rm npm -g -f --loglevel error
node cli.js install -g -f
npm ERR! Could not create /usr/local/lib/node_modules/___npm.npm
npm ERR! error installing<EMAIL_ADDRESS>Error: EACCES, Permission denied '/usr/local/lib/node_modules/___npm.npm'
npm ERR! Error: EACCES, Permission denied '/usr/local/lib/node_modules/___npm.npm'
npm ERR!
npm ERR! Please use 'sudo' or log in as root to run this command.
npm ERR!
npm ERR!     sudo npm "install" "-g" "-f"
npm ERR!
npm ERR! or set the 'unsafe-perm' config var to true.
npm ERR!
npm ERR!     npm config set unsafe-perm true
npm ERR!
npm ERR! System Darwin 10.7.0
npm ERR! command "node" "/private/var/folders/xZ/xZ-ZGx7IFA4ttzcWpT6zbE+++TI/-Tmp-/npm.751/package/cli.js" "install" "-g" "-f"
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /private/var/folders/xZ/xZ-ZGx7IFA4ttzcWpT6zbE+++TI/-Tmp-/npm.751/package/npm-debug.log
npm not ok
make: *** [install] Error 13
npm WARN Not installed in /usr/local/lib/node_modules npm
npm ERR! Could not create /usr/local/lib/node_modules/___npm.npm
npm ERR! error installing<EMAIL_ADDRESS>Error: EACCES, Permission denied '/usr/local/lib/node_modules/___npm.npm'
npm ERR! Error: EACCES, Permission denied '/usr/local/lib/node_modules/___npm.npm'
npm ERR!
npm ERR! Please use 'sudo' or log in as root to run this command.
npm ERR!
npm ERR!     sudo npm "install" "." "--force" "--global"
npm ERR!
npm ERR! or set the 'unsafe-perm' config var to true.
npm ERR!
npm ERR!     npm config set unsafe-perm true
npm ERR!
npm ERR! System Darwin 10.7.0
npm ERR! command "/usr/local/bin/node" "/private/var/folders/xZ/xZ-ZGx7IFA4ttzcWpT6zbE+++TI/-Tmp-/npm.751/package/cli.js" "install" "." "--force" "--global"
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /private/var/folders/xZ/xZ-ZGx7IFA4ttzcWpT6zbE+++TI/-Tmp-/npm.751/package/npm-debug.log
npm not ok
It failed

putting sudo before sh worked for me too.

curl http://npmjs.org/install.sh | sudo sh


Properly implement Processor() objects, including unit tests

Currently, Processor() objects are skipped in the AML. They should be implemented in a similar way as Device.

Resolved in d60a1f6


Compare ancestry inference performance of v4 RF models

This ticket is aimed at doing the analysis for v4 population assignments (as opposed to writing the PR #494)

Someone (Alicia? Konrad?) reported getting excellent results training an ancestry RF on 1KG+HGDP and applying to UKBB pan-ancestry project. Let's compare to the gnomAD RF performance and see if we can get better results.

Someone (Alicia? Konrad?) reported getting excellent results training an ancestry RF on 1KG+HGDP and applying to UKBB pan-ancestry project. Let's compare to the gnomAD RF performance and see if we can get better results.

This really only applies WGS data (v3) instead of exome (v4)

we don't have labels for v4 that we can use (we have labels for v3). Mike was planning on looking at whether we should use only use known labels (HGDP/TGP) or v3 imputed labels

I moved the wrong ticket here. This will happen later in analysis, not this sprint.

Decided on:

20 PCs
Training samples:
hgdp/tgp samples
v2 samples with known pops
v3 samples with known pop for certain cohorts only (Decisions were made based on results of an analysis to determine which v3 samples/cohorts to use as training samples. This analysis consisted of computing per sample mean Euclidean distances to all samples in a given population, and per sample the mean Euclidean distances limited to only HGDP/1KG samples in each population)
Spike in v4 samples with race/ethnicity of "Arab" of "Persian"
min_prob parameter decided per pop using min_recall and min_precision of 0.99 ( Minimum recall (min_recall) is used to choose per ancestry group minimum RF probabilities. This min_recall cutoff is applied first, and if the chosen minimum RF probabilities cutoff results in a precision lower than min_precision, the minimum RF probabilities with the highest recall that meets min_precision is used.)

min_prob_cutoffs={'afr': 0.93, 'ami': 0.96, 'amr': 0.86, 'asj': 0.88, 'eas': 0.96, 'fin': 0.91, 'mid': 0.56, 'nfe': 0.78, 'sas': 0.96}


[ISSUE] / [REQUEST] Tag Attribute for String array

Hello, hello dev. 👋
Just wanted to ping ya that the Tag attribute does not work for string[] type. Dare I request a fix for this issue (if it is an issue) or a new attribute (Tags maybe?) to handle string[] types? 😀

In the meantime, I found a solution for this scenario. Here's a link to anyone who might wanna check it out: http://www.brechtos.com/tagselectorattribute/

After Unity updated their UI in 2019.3, it started working, so I will be closing this one.


Clarify connection state.

.join()-ing a swarm will execute the callback once the announcement to the bittorrent network went through. However, during the announcement-process peers are already added as they appear, making the network basically usable. To clarify the state I suggest the implementation of a "connection-state".
What I am thinking about looks something like this:
swarm.on('connection-state-change', state => {
  switch (state) {
     case 'disconnected': break; // Not connected
     case 'connecting': break; // Join called but no peer connected
     case 'connected-one-peer': break; // One peer is connected but not connected to wider network
     case 'connected-many-peer': break; // Connected to more than one peer
     case 'connected-wellknown-peer': break; // Connected to a well-known-peer - aka. the internet.
  }
})
swarm.connectionState; // Current state available as property
swarm.join(); // No callback ... necessary?!

I would very much appreciate this as well! +1


Speed up Link Validation

Description:
db.value_cache is erased every time get_single_value is called and doctype is not found in cache.
This causes an endless loop of erasing and recreating it if two different single doctype values are requested in a transaction, which essentially make this cache useless overhead.
As a Temprorary fix, Don't erase the whole cache, just initiate new dictionary for missing doctype.

@Akash-Ramjyothi  can you send this PR to upstream(https://github.com/frappe/frappe)


Remove TranslateUnicodeToOem and all related code

The overarching intention of this PR is to improve our Unicode support. Most
of our APIs still don't support anything beyond UCS-2 and DBCS sequences.
This commit doesn't fix the UTF-16 support (by supporting surrogate pairs),
but it does improve support for UTF-8 by allowing longer char sequences.
It does so by removing TranslateUnicodeToOem which seems to have had an almost
viral effect on code quality wherever it was used. It made the assumption that
all narrow glyphs encode to 1 char and most wide glyphs to 2 chars.
It also didn't bother to check whether WideCharToMultiByte failed or returned
a different amount of chars. So up until now it was easily possible to read
uninitialized stack memory from conhost. Any code that used this function was
forced to do the same "measurement" of narrow/wide glyphs, because of course
it didn't had any way to indicate to the caller how much memory it needs to
store the result. Instead all callers were forced to sorta replicate how it
worked to calculate the required storage ahead of time.
Unsurprisingly, none of the callers used the same algorithm...
Without it the code is much leaner and easier to understand now. The best
example is COOKED_READ_DATA::_handlePostCharInputLoop which used to contain 3
blocks of almost identical code, but with ever so subtle differences. After
reading the old code for hours I still don't know if they were relevant or not.
It used to be 200 lines of code lacking any documentation and it's now 50 lines
with descriptive function names. I hope this doesn't break anything, but to
be honest I can't imagine anyone having relied on this mess in the first place.
I needed some helpers to handle byte slices (std::span<char>), which is why
a new til/bytes.h header was added.
As such I've opted for freestanding functions which take slices as mutable
references and "advance" them (offset the start) whenever they're read from
or written to. I'm not particularly happy with the design but they do the job.
Related to #8000
Fixes #4551
Fixes #7589
Fixes #8663
Validation Steps Performed

Unit and feature tests ✅
Far Manager ✅
Fixes test cases in #4551, #7589 and #8663 ✅

Also related to #4551?

Also fixes #7589.

Now after rewriting half of InputBuffer::Read I think that this is pretty solid.  Instead, it'd be much better to simply add support for surrogate pairs to KeyEvent itself (i.e. have it store up to 2 wchar_t), so that we don't have to do any stitching in the first place. Or if that's not possible, I'll add support for the stitching some time in the future. For this particular case it was just too much.

Just wanted to check: With this PR merged, is the ReadFile w/ UTF-8 code page situation supposed to be improved?

Yes, the test case as described in #4551 is now fixed. However, I believe that "improved" is just the right choice of words: There's still no consistent internal support for surrogate pairs for instance, but this is something that I'm actively working on.

Has this fix shipped in Windows 11 conhost already?

This will not ship for quite a while unfortunately. 10000s of lines of other changes are also waiting to be shipped, including massive correctness and performance improvements, and I'm quite excited to see when it does.

(It will ship in the Terminal in 1.18 SoonTM though)

Thank you!

Is this related to #12626?


Add tvOS support

Working on tvOS support in this branch.
Note that tvOS supports scrolling label by default if you use UITableViewCell.textLabel.
The default scrolling behavior differs a bit from of MarqueeLabel.

On focused : starts scrolling
On unfocused : stops scrolling and back to home position without animations .
Scrolling speed is bit slower than MarqueeLabel. (Maybe scrollDuration = 20.0 ?)
lineBreakMode is ByTruncatingTail while unfocused

My motivation is to make these behavior available for other tvOS labels in addition to UITableViewCell.textLabel.
Please give feedbacks if any.😀

Awesome! I have a few tweaks that I might make (or do a PR back to your branch before we merge it) here in the next few days, but looks good!

I merged this in (manually), but I guess Github didn't track it. Thanks for getting it started!

Right, thanks for review and merging ! 🎉


Fix resource build

fix #104

$ openssl s_client -connect *************:443
CONNECTED(00000003)
(snip)
---

HEAD /assets/9118f799/main.css HTTP/1.1
Host: *************
Accept-Encoding: gzip
Connection: keep-alive

HTTP/1.1 200 OK
Date: Wed, 16 Mar 2016 09:48:44 GMT
Server: h2o/2.0.0-beta1
Connection: keep-alive
Content-Length: 1018
content-type: text/css
last-modified: Wed, 16 Mar 2016 09:47:28 GMT
etag: "56e92bb0-3fa"
vary: accept-encoding
content-encoding: gzip
accept-ranges: bytes
x-xss-protection: 1;mode=block
x-content-type-options: nosniff
x-frame-options: DENY
x-ua-compatible: IE=Edge
strict-transport-security: max-age=31536000
cache-control: no-transform, max-age=1209600

HEAD /assets/9118f799/main.css HTTP/1.1
Host: *************
Accept-Encoding: br
Connection: keep-alive

HTTP/1.1 200 OK
Date: Wed, 16 Mar 2016 09:48:48 GMT
Server: h2o/2.0.0-beta1
Connection: keep-alive
Content-Length: 825
content-type: text/css
last-modified: Wed, 16 Mar 2016 09:47:28 GMT
etag: "56e92bb0-339"
vary: accept-encoding
content-encoding: br
accept-ranges: bytes
x-xss-protection: 1;mode=block
x-content-type-options: nosniff
x-frame-options: DENY
x-ua-compatible: IE=Edge
strict-transport-security: max-age=31536000
cache-control: no-transform, max-age=1209600

HEAD /assets/9118f799/main.css HTTP/1.1
Host: *************
Connection: close

HTTP/1.1 200 OK
Date: Wed, 16 Mar 2016 09:48:52 GMT
Server: h2o/2.0.0-beta1
Connection: close
Content-Length: 3397
content-type: text/css
last-modified: Wed, 16 Mar 2016 09:47:28 GMT
etag: "56e92bb0-d45"
vary: accept-encoding
accept-ranges: bytes
x-xss-protection: 1;mode=block
x-content-type-options: nosniff
x-frame-options: DENY
x-ua-compatible: IE=Edge
strict-transport-security: max-age=31536000
cache-control: no-transform, max-age=1209600

Looks good.


Removed test file with the output from some tests

It was me... pushing a wrong file :(

Codecov Report

Merging #1434 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   60.32%   60.45%   +0.12%
==========================================
  Files         119      119
  Lines       11134    11134
==========================================
+ Hits         6717     6731      +14
+ Misses       3762     3749      -13
+ Partials      655      654       -1

Impacted Files
Coverage Δ

remoteworkitem/scheduler.go
63.41% <0%> (+9.75%)
:arrow_up:

models/transaction.go
70% <0%> (+20%)
:arrow_up:

remoteworkitem/github.go
100% <0%> (+22.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b95d8...1790184. Read the comment docs.


IPv6, domains and wildcard are not supported in TrustedHostsNetworkResolver::withAddedTrustedHosts ($hosts argument)

Related - https://github.com/yiisoft/validator/issues/605.

Wildcard and domain are needed to support at least AWS ELB.


cookies aren't enable - selenium webdriver.io phantomjs

The documentation says: Cookies are enabled in PhantomJS by default. But not sure why Amazon returns that page.

Here is my code:
var webdriverio = require('webdriverio');

var opts = desiredCapabilities: {
    browserName: 'phantomjs',
    javascriptEnabled: true
  },
  "host": "localhost",
  "port": 4444
};

var email = ''; // your email
var password: ''; // your password

var client = webdriverio
      .remote(opts)
      .init()
      .url('https://www.amazon.co.uk/gp/sign-in.html')
      .setValue('#ap_email', email)
      .setValue('#ap_password', password)
      .submitForm('form[name="signIn"]')
      .then(function() { // save the screenshot
              this.saveScreenshot(__dirname + '/loginPage.png');
      })
      .end();

I had logged the cookies object it returns empty/none:
{
  sessionId: 'a96eb340-bb6a-11e5-ae83-c52b2435a008',
  status: 0,
  value: []
}

, and tried to set a custom Cookie with
.setCookie({name: '', value: '', domain: 'amazon.co.uk'})
But still have the same problem..
As I think phantomJS is blocking it because when i changed the browserName with chrome then it works fine.. Still, I want it work via PhantomJS.
Any help will be appreciated - Thanks.

I'm having a similar issue with cookies seemingly not being enabled by default. I'm using Karma.

Hi @thesciz The problem actually was that Amazon server blocks the IP, so to achieve we have used Tor instances through which we dynamically change/switch over the IP.


link

added babel link

@anurse Ok got it this time. Ugh was looking at a cached copy with the link before.


Change the invoker to DaemonSet

This is a WIP for changing Invokers to a DaemonSet. It relies on this PR https://github.com/apache/incubator-openwhisk/pull/2689 to be merged first.

@DanLavine @dgrove-oss PR https://github.com/apache/incubator-openwhisk/pull/2689 is now merged

One final tweak needed;  the final PR that was merged used INVOKER_NAME (not INVOKER_ASSIGNED_NAME) for the envvar.

Hi Dan.  I've created an updated version of this (#107).  I hope to get it merged ASAP (it is working nicely for me on both single-node and multi-node clusters).  I think you can go ahead and close this PR as being superseded by 107.


add new attribute for number of features

Fixes an issue related to #17353 in scikit-learn and #3129 in LightGBM (see SLEP010 for further details). It also fixes an issue related to the behavior of StackingClassifier, where the returned error is AttributeError: 'XGBClassifier' object has no attribute 'n_features_in_' (see code below).
import xgboost as xgb
from sklearn.model_selection import train_test_split
from sklearn.datasets import load_iris
from sklearn.svm import LinearSVC
from sklearn.linear_model import LogisticRegression
from sklearn.preprocessing import StandardScaler
from sklearn.pipeline import make_pipeline
from sklearn.ensemble import StackingClassifier

X, y = load_iris(return_X_y=True)
estimators = [
    ('gbm', xgb.XGBClassifier()),
    ('svr', make_pipeline(StandardScaler(),
                          LinearSVC(random_state=42)))
]
clf = StackingClassifier(
    estimators=estimators, final_estimator=LogisticRegression()
)

X_train, X_test, y_train, y_test = train_test_split(
    X, y, random_state=42
)
clf.fit(X_train, y_train).score(X_test, y_test)

Codecov Report

Merging #5780 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5780      +/-   ##
==========================================
+ Coverage   82.59%   82.61%   +0.01%
==========================================
  Files          12       12
  Lines        2724     2726       +2
==========================================
+ Hits         2250     2252       +2
  Misses        474      474

Impacted Files
Coverage Δ

python-package/xgboost/sklearn.py
91.35% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3028fa6...fd632e6. Read the comment docs.

@trivialfis the stacking errors pertain to the regressor and the classifier. All three models can access the attribute now. There are also two new tests for stacking.

Thanks!


0.19.0 -> 0.19.1 regression: compiler goes into infinite lool

Quick Summary: The well-typed program which is accepted by 0.19.0 results into infinite loop of 0.19.1
SSCCE
module Weak exposing (..)

type alias X1 r a = {r | x : a}

type alias X2 t = X1 t t

x2 : X2 {}
x2 = {x = {}}

id : X2 a -> X2 a
id x = x

x3 = id x2

elm 0.19.0:
elm make src/Weak.elm
Success!

elm 0.19.1: loop

Elm: 0.19.1
Browser: Google Chrome 78.0.3904.87
Operating System: MacOS 10.14.6

Additional Details
Actually, the program is well-typed.

Same happens for the following code
type alias Lens a b = {
    get : a -> b,
    set : b -> a -> a
  }

type alias State inputState = {
    input : inputState
  }

inputLens : Lens (State inputState) inputState
inputLens = Lens .input (\ a b -> { a | input = b })

@ilya-klyuchnikov I cannot reproduce the example in the first post:

@nikita-volkov It's usually best to create a separate issue. Your example is not well-typed, btw. set should be b -> a -> a but you're giving it an a -> b -> a. Try (\b a -> { a | input = b }).

@zwilias Yes, my code is ill-typed, but it's not the point. The point is that there is a bug in the compiler that throws it into an infinite loop on that code.

I've created a dedicated issue for my code sample: #2036


Support media queries with React Native

Thanks for the fantastic project guys, I am primarily targeting RN and I though it would be awesome if styled components could provide support for media queries seamlessly in RN.
Turns out that there is a new very promising project to add media queries support to both React and React Native.

https://github.com/tuckerconnelly/uranium

It would be pretty neat if a bridge would exist to embed this functionality so that I dont have to wrap my style component (which is already a wrapper) with Uranium wrapper.

@mxstbr any though on the subject ?

Just so I understand correctly, are you looking to have this,
height: 120;

@media (min-width: 600) {
  width: 56;
}

Go to,
const styles = {
  base: {
    height: 120,

    '@media (min-width: 600px)': {
      height: 56,
    },
  },
}

I'm curious what would media queries in RN do? What sort of problems are you trying to solve? Would you like to get something what https://github.com/aybadb/react-native-responsive does?

@knowbody you can check this proposal https://gist.github.com/grabbou/72767db51f97fe86cfea
That should give you an idea on what media queries could do on RN.
It addresses the same kind of problem domain that media queries solve on the web. When you have an RN app that target ios, android, phones and tablets alike and need to adapt its layout depending on the device orientation and so on...
I dont really like how react-native-responsive is implementing media queries, for me, media queries should be expressed as css rules, just like on the web. In that regard, Uranium is a much better prospect imho.
Extended Stylesheet implemented the proposal above:

https://github.com/vitalets/react-native-extended-stylesheet#media-queries

As nobody has asked for this custom extension in more than half a year I doubt we'll include it in the library. On top of that many workarounds already exist that make media query functionality possible on ReactNative.
Thank you for suggesting improvements to the library!

Why didn't https://github.com/shripadk/styled-components/commit/d4fe1a9acd82d2f44d11012f5e18140453f5e38d get merged?
Does it add support for this?
I would love to use styled-components with RN but I need media queries. react-native-extended-stylesheet syntax is RN pojo nastiness...
Seems like a really valid request. Please re-open.

So, is media-query not possible in React-Native? Why not support all CSS3?

I'm open to it if someone wants to make a new PR and lots of tests.

Any new information on this? what does community use right now?
there are many projects support the feature but all of them use different ways of defining styles and queries, making projects unintegrated and messy.

@HosseinAlipour Look at the PR I linked above. It's really simple. See if you can replicate that into a new PR like Evan suggested.
If that solution works for you locally, I'm sure someone could point you towards where a small test suite like that might live.
I haven't used RN in a long time, but would love media queries to be available next time I need to. :)

I'm working on a responsive, Theme UI-like library for React Native. It would be great if the styled.View from styled-components/native supported the web media queries the way styled.div does. This would be fine even if it only works on web. On web, it makes the most sense for media queries to be done using CSS, not JS, as some people have mentioned above.
I already got the media queries to work on native using the useDimensions hook from @react-native-community/hooks.
That said, if you try to use React Native's Dimensions API to create JS-based media queries on web (instead of using CSS,) you'll break server side rendering (see https://github.com/vercel/next.js/discussions/14469#discussioncomment-29741.) That's why it would be great if the styled.View had the same functionality as styled.div for media queries.

Is this something that's being considered?


Investigation: As a node operator I want to upgrade PANIC as easy as possible (PANIC-606)

We need to perform the following investigation:
We would be able to facilitate the node operators life by including a very simple upgradeability
process for PANIC. Ideally, this should be done in the UI itself. The UI can monitor a list of releases from the PANIC repository, and when a new upgrade is available, the user is notified in the UI accordingly. If the user wants to update, the new code-base is downloaded from the PANIC repository. In this repository we should also include a bash script which performs the update, such as:
Clearing Redis
Migrates how data is stored in Mongo to possibly new ways
Migrates how data is stored in Redis to possibly new ways
Clears rabbitmq
Updates configs

Guilherme Zimmermann added -
Suggestion for a "mini-roadmap" related to installing/upgrading PANIC: * release Installer/Settings UI
work on the OS specific scripts to manually download PANIC and release this
integrate PANIC upgrading into UI and release
add an UI on top of the scripts (nice to have, more friendly) but also support script only installations/upgrading


Support for org-refile-use-outline-path

Does this feature exist in Emacs orgmode core?
Yes
Orgmode link

Manual mention: https://orgmode.org/org.html#index-org_002drefile_002duse_002doutline_002dpath
Additional explanation: https://emacs.stackexchange.com/questions/36505/org-mode-refile-multiple-locations-with-same-name-as-target

While the manual mentions the variable, I can't actually find manual documentation on its values. There are multiple website discussions such as stackexchange that provide examples of the options, though.
Feature value
No response
Additional context
Suppose I want to have an org file named work.org that looks like this:
* Project 1
** Tasks
* Project 2
** Tasks

I can only refile today using a destination like work.org/Tasks, which will place  under the first heading that matches. I'd like to have a singular file where I can file tasks into different headings without either
a. Making them top-level and distinct such as Project 1 Tasks and Project 2 Tasks
b. Breaking out into separate files such as project_1.org/Tasks and project_2.org/Tasks when refiling

Seems related to https://github.com/nvim-orgmode/orgmode/discussions/513.

Interesting issue, which exposes a feature gap between nvim-orgmode and Emacs Orgmode. I would be curious to implement it, but I would prefer to first refactor the refiling code a bit more seriously, because this feature touches a couple of points, which currently treat headline names like a unique identifier within one org file.
This includes also some user interface decisions, which we need to discuss.

@seflue what can I do to help here? Is there a tracker for the refile refactoring?
I've got experience writing neovim plugins such as https://github.com/chipsenkbeil/distant.nvim, so maybe I can pitch in a bit.

There is currently no tracker regarding this refactoring, but because I spend some time in the refiling code the last days while fixing some issue, I came to the conclusion, that it would make future changes easier to refactor it a little bit. Currently the code is sometimes a little bit ambiguous to read, also a bit entangled, which makes it challenging to understand. But because I already invested some time to grasp it, it would make sense to use this knowledge, to improve it.
I deferred such a refactoring, because the fixes I did recently were only small changes. The feature you suggest is a bit larger, so doing the refactoring before that would make things easier. @kristijanhusak is the decision maker here, I don't know, how he sees the priorities. But generally speaking: if you are currently very motivated to contribute on this particular topic, feel free to create a PR.
I currently cannot promise, when I would find time for the mentioned refactoring and I also have other bugs and feature gaps, which are higher on my priority list, because they have a higher impact on my day-to-day work.


#485: FreelancerRates tests makeover

Hello dear Exercism team! Recently I stumbled upon a strange issue: when test of FreelancerRates exercises are run, no communication is provided on failure, please see the screenshot.
IMHO this can be due to lack of XCAssert messages (Xcode errors may not be communicated to web frontend, dunno). So I slightly rewritten the tests and made them more well-looking and documented, please have a look!
Do not hesitate to write if you have any questions!

Addition:

swiftlint autocorrect --format applied to file in the PR
xcodebuild checked (succeeded)

I'm going to go ahead and close this. If the problem persists, please open an issue in the test runner repository as Erik suggested.


(fleet) installer as a separate command

This PR makes the daemon call the installer as a command instead of instantiating an installer internally.

/merge -p urgent


fails to use system-installed simdjson

Building pcm with simdjson currently requires a copy of the latter to be placed inside the source tree.  This might be reasonable on systems without a good way to install dependencies (ie, Windows), but on Linux/BSD distributions, bundling copies of unrelated libraries is severely frowned upon, and attracts bad words from the Security Team who demand explanation for every such copy.  They do so for a good reason: whenever the library in question requires an update, every in-tree copy in the whole distribution needs to be fixed.
Thus, please #include <simdjson.h> instead if it's available.
It's best to do so via a cmake check rather than __has_include.

thanks for reporting the issue. I am not sure about a cmake check but adding a new #if block here https://github.com/opcm/pcm/blob/fd11f3f87a136cd7c832b888fc9460256b8ee996/src/simdjson_wrapper.h#L11
to
https://github.com/opcm/pcm/blob/fd11f3f87a136cd7c832b888fc9460256b8ee996/src/simdjson_wrapper.h#L16
with <simdjson.h> instead of "simdjson/singleheader/simdjson.h" would work, right?

There's at least -lsimdjson which can't be done from C code.

ok, I see, simdjson/singleheader/simdjson.h is self-contained, it does not need -lsimdjson

In my case it's version 1.0.2-2, as packaged in Debian unstable = bookworm = Ubuntu jammy, but I see that the packaging is same in older releases.
Relevant versions are:
[~]$ rmadison -u debian simdjson
simdjson   | 0.6.1-2~bpo10+1 | buster-backports       | source
simdjson   | 0.7.1-1         | stable                 | source
simdjson   | 1.0.2-2         | testing                | source
simdjson   | 1.0.2-2         | unstable               | source
[~]$ rmadison -u ubuntu simdjson
 simdjson | 0.2.1-1build1 | focal/universe  | source
 simdjson | 0.7.1-1       | impish/universe | source
 simdjson | 1.0.2-2       | jammy/universe  | source

In my case it's version 1.0.2-2, as packaged in Debian unstable = bookworm = Ubuntu jammy, but I see that the packaging is same in older releases.
Relevant versions are:
[~]$ rmadison -u debian simdjson
simdjson   | 0.6.1-2~bpo10+1 | buster-backports       | source
simdjson   | 0.7.1-1         | stable                 | source
simdjson   | 1.0.2-2         | testing                | source
simdjson   | 1.0.2-2         | unstable               | source
[~]$ rmadison -u ubuntu simdjson
 simdjson | 0.2.1-1build1 | focal/universe  | source
 simdjson | 0.7.1-1       | impish/universe | source
 simdjson | 1.0.2-2       | jammy/universe  | source

Thanks! I have the same version. My investigation showed that copying of singleheader/simdjson.h and singleheader/simdjson.cpp to project is still required due to usage of simdjson structures (e.g. simdjson::dom, etc.).
System file simdjson.h (/usr/include/simdjson/simdjson.h) doesn't have required definitions.
This observation aligned with simdjson guidlline - https://github.com/simdjson/simdjson/blob/master/doc/basics.md:

To include simdjson, copy simdjson.h and simdjson.cpp into your project. Then include it in your project with:
#include "simdjson.h"

Also guideline has option to use simdjson as CMake dependency , then simdjson will be downloaded during cmake configuration. In my point of view it can improve user experience.
Will implementation of solution with simdjson as CMake dependency cover Security requirements you mentioned in issue description?

In my case it's version 1.0.2-2, as packaged in Debian unstable = bookworm = Ubuntu jammy, but I see that the packaging is same in older releases.
Relevant versions are:
[~]$ rmadison -u debian simdjson
simdjson   | 0.6.1-2~bpo10+1 | buster-backports       | source
simdjson   | 0.7.1-1         | stable                 | source
simdjson   | 1.0.2-2         | testing                | source
simdjson   | 1.0.2-2         | unstable               | source
[~]$ rmadison -u ubuntu simdjson
 simdjson | 0.2.1-1build1 | focal/universe  | source
 simdjson | 0.7.1-1       | impish/universe | source
 simdjson | 1.0.2-2       | jammy/universe  | source

Thanks! I have the same version. My investigation showed that copying of singleheader/simdjson.h and singleheader/simdjson.cpp to project is still required due to usage of simdjson structures (e.g. simdjson::dom, etc.). System file simdjson.h (/usr/include/simdjson/simdjson.h) doesn't have required definitions.
This observation aligned with simdjson guidlline - https://github.com/simdjson/simdjson/blob/master/doc/basics.md:

To include simdjson, copy simdjson.h and simdjson.cpp into your project. Then include it in your project with:
#include "simdjson.h"

Also guideline has option to use simdjson as CMake dependency , then simdjson will be downloaded during cmake configuration. In my point of view it can improve user experience. Will implementation of solution with simdjson as CMake dependency cover Security requirements you mentioned in issue description?

@kilobyte , could you please comment "simdjson as CMAKE dependency" behavior. Will it be suitable in your case?


🚧chore: Add support for Django 4.2

fixed #114
adopted some of the changes in #115
and those in https://github.com/rsinger86/django-lifecycle/compare/0.9.2...0.9.3
PS
After this is merged, the next PR i will likely make is to drop support for Django versions that are outdated. This will be everything before 3.2 and 4.0.

@EnriqueSoria this is my attempt to bump the support for Django 4.2 which is my primary concern. Do let me know if there are any changes I need to make.
Thank you

Thank you @rsinger86
How do I help release the new version on pypi?

Oh ignore my last statement @rsinger86
I just saw 1.0.2
Thank you


Backtrack missing one value declaration which points to backtrack not working with ignore smoke option

Value bestTargetHead is never set to an real value in Backtrack.cpp

simple fix

@danielkrupinski urgent fix for master?

i saw this and fixed on my pull today #1922 , but yeah wierd stuff mans


LSI-16: remove GPL code

The second commit will mark this repo as read-only.

Could we do both? I'm operating under guidance from @swinslow

That would be fine with me. However, we should probably update its README.md to explain that it was archived, and to note that despite its Apache 2 LICENSE, it contains an artifact that uses a GPL license; it is therefore not usable as Apache 2 source if it is ever copied out of the archive.

Does this look OK? https://github.com/hyperledger/indy-agent/blob/9de6cdc8c7f8cd00f8bf2d5cc1c9fcdb950f9df4/README.md

Yep. That looks good to me. I'm happy to merge this if I can get @TelegramSam to buy off.

See also: https://jira.hyperledger.org/browse/LSI-20


Apply patches for Debian Stretch and modern Ruby compatibility

Ref nedap/steppingstone/pull/4239

Can one of the admins verify this patch?


Add visa pages for non-UK trainees

Add visas page for non-UK trainees

@philspray @EllieNodder can we merge and deploy?


Triage of necessary node modules

I want to closely look through the current node modules in package.json and see what we can eliminate so we won't have to worry too much about dependency/security updates.

That's a good idea. There are basically three categories of dependencies:

Visualizations
Stuff for Foundation
eslint

Maybe the Foundation stuff can go. They probably pull in the majority of other dependencies.
However, I think our security implications are low. We aren't running this JS server side.

This should also include removing any lingering gulp files, etc.


Timeline

Picking up where the discussion left off in #505. I made another iteration of a timeline mockup. Notable changes:

The bars for the guide being followed starting today is more distinctly separate from the "growing season" bars which shows more of a window of opportunity for the plant
Tooltips, tooltips, tooltips!
Adjusted the subtext next to the 'Timeline' header to reflect the fact that the timeline is dplayed as though the user will be starting to follow the guide today.

Feedback and other design ideas welcome! I'll try and whip something together for timeline creation tomorrow.

So is the "Plant's Lifetime" section referring to when you actually planted the crop, vs the window section is when you think people could possibly plant the crop?

Yes almost. The plant's lifetime isn't necessarily historical data from when you actually planted the plant. Its more of a projection/forecast saying 'if you actually planted this today, this is how long it will take'. You got the window section spot on.

I imagine the tooltips of the time bar options will explain that in more detail

I haven't tried looking at the site on a tablet myself, but be careful with tooltips and hovers since they can be a problem when it comes to touch-screen user experience.

How can it be a problem? Inadvertant touches? Lack of 'hoverimg' makes it less intuitive to activate the tooltips?
Perhaps if we can detect a tablet interface, we can explicitly tell the user to click things for more info.

OOOOOH this all makes sense now!

How can it be a problem? Inadvertant touches? Lack of 'hoverimg' makes it less intuitive to activate the tooltips?

Exactly. Unless you want to have tooltip trigger buttons all over the place or something.

Can't the elements themselves be the trigger buttons?

Sure. That seems reasonable in this case.

Hey all, I've made a mockup for Timeline Creation, which will be a step in Guide Creation just before the end. The flow is focused on walking the author through the process so as to teach them what it means and to not overwhelm them with too many things to adjust at once. Looking forward to your feedback:

See now: Guide Creation Flow V2 (with integrated/tweaked Timeline building) #638


SYSVAD audio driver: are APOs active?

I installed SYSVAD audio driver with APOs, but I am not sure if the APOs are working.
I have done the steps as in the SYSVAD documentation:

devcon install ComponentizedAudioSample.inf Root\Sysvad_ComponentizedAudioSample, and received a message "Drivers installed successfully."
Right clicked on ComponentizedAudioSampleExtension.inf and install. After some time a message box poped-up saying the install was OK.
Right clicked on ComponentizedApoSample.inf and install. Waited, but no pop-up message box appeared as in step 2, so I am not sure this step finished successfuly.

What I see in the Device Manager is:

under Sound, video and game controllers: SYSVAD (with APO Extensions)
under Software components: Audio Proxy APO Sample
Is that all I should see?

I tried to check if all is working: I played back some audio, and I found the wav files are dropped at C:\STREAM_HOST_*.wav, which means the driver is working.
Howerver, my goal are the APOs.
Is there a way to check if APO components are active?

if you are intresting APO, you can let the APO to print logs, write some files...
I am testing APO in a VM.
on the VM, the speaker created by SYSVAD can't be list.
do you know why ?


Explainer functionality in UI has changed and instructions do not reflect changes

Lab: 07 AutoML
Task: Train a classification model with automated machine learning
Step: 07
Description of issue
Original Instructions:
The Models tab will show all models that have been trained. Select View explanation for the best model to understand which features influenced the target value the most.
Issue: The UI and functionality has changed. After running the AutoML experiement, model explanation is initiated in the portal for each model, it doesnt just offer explainability for the best model. Also, once the explain is initited, it creates a new job and based on observations, it runs explainer twice and RAI dashboard once. The explainations are available after about 5 min., the RAI dashboard takes 15 min. Im not sure if the product team is aware that both operations are running on this selection and would result in unnecessary computational expense and unnecessary features created.
Here are supporting images:

Thanks for pointing that out! The instructions are updated to reflect the changes in UI.
As for the child jobs being generated, AzureML Studio will only run these additional jobs for the model with highest accuracy by default. If we select any other algorithm, it'll generate only one child job for explanation and no Responsible AI dashboard is created.
Since the explanation dashboard becomes available independently of the RAI job run, for the scope of the exercise, the RAI dashboard can be ignored and you don't have to wait for its job to finish.


Android 11 will prevent meta reflection

Apps targeting Android 11 can no longer use an extra layer of reflection to access non-SDK interfaces that are restricted.

See https://developer.android.com/preview/test-changes#prevent_meta_reflection_blacklist_access.

I will publish a new way to bypass it after Android 11 released.

Just curious, will the new way be Java-only or require native code?

It depends

It depends

six，eat gua

https://github.com/ChickenHook/RestrictionBypass

https://github.com/tiann/FreeReflection/commit/f1a175e231bd50866e8521772b264ec58f287336

It depends

six，eat gua

wo cao, six six six

Android 11
https://github.com/ChickenHook/RestrictionBypass

I find this way too. But now it has been published to github, and google is forbidding it.


Simplify truffleruby+graalvm-dev build definition re: download redirect

The http get <url> <destfile> utility had a bug with aria2c downloader where it couldn't properly save to destfile if it was an absolute path.
I have tried having http get <url> - consistently print the downloaded file to stdout, but this conflicted with the output of log_command (which is also to stdout) so for now let's keep using the temporary file to resolve manual URL redirects.
Followup to https://github.com/rbenv/ruby-build/pull/2356 /cc @rwstauner

FWIW I also tried to pass - as the file but aria2c creates a file named -, unlike wget/curl which behave as expected and print to stdout, oh well.

Yeah, that inconsistency worries me. I think a future change to our http get <url> <dest> helper should either prohibit the - value or make it work consistently across all downloaders. But for now, I'm happy with at least having aria2c download respect the destination file argument consistently.


Footer is not being responsive

In mobile versions the footer is extending the page width more than 100%

Closed as part of #10


Universal Unit Test project does not work once you reference the Template10 project

I could not re-open this:
https://github.com/Windows-XAML/Template10/issues/178
so I created new issue. Problem still exists and is related with Template10. Please provide solution.

I tried to run a unit test with xUnit.net and same problem as described in #178 comes up. The test project works fine until Template10 project is referenced upon which the following error is raised:
Cannot deserialize XBF metadata type list as 'BootStrapper' was not found in namespace 'Template10.Common'.

@labretrox could you share with me what is not working?

I've seen this too. It is failing in the following scenario:

Create a new Minimal Template10 app project and build it.
Add a new Universal Unit Test project to the solution.
Add a reference from the test project to the app project.
Add a unit test that references a type from the app project's MainPage view model and build.
Run the unit test in the debugger.

As the test loads, you get an error this exception:
"Cannot deserialize XBF metadata type list as 'BootStrapper' was not found in namespace 'Template10.Common'. [Line: 0 Position: 0]"
These steps work fine in the basic Blank project that comes with VS. As a way around this behavior, I moved my source code and xaml files to a class library that is referenced in the app and test projects. The app project just holds App.xaml & cs, Assets folder, Styles folder, and appx manifest.

Is your universal test app of the same type as the universal app? I came across this thread trying to debug a similar issue while using Prism...
App.xaml.cs for the UAP using Prism had this:
sealed partial class App : PrismUnityApplication
which is a departure from the default:
sealed partial class App : Application
A newly created unit test app will also inherit from Application.
Looking at the Blank app sample, I see a customized Application class:
sealed partial class App : Template10.Common.BootStrapper
Is the universal testing problem resolved duplicating this class definition into
Template10/Template10 (Tests)/UnitTestApp.xaml.cs
and changing the root of UnitTestApp.xaml from <Application ..../> to <Template10:Bootstrapper xmlns:template10="using:Template10.Common ..../>"?

I also see this issue:

Create a Hamburger (Template 10) app.
Create a Unit Test App (Universal Windows) in same solution.
Reference the Hambuger app from the Unit Test app and then when you run he default test in UnitTest.cs, you get the following:

"A user callback threw an exception.  Check the exception stack and inner exception to determine the callback that failed.
========== Run test finished: 0 run (0:00:07.6862905) =========="
Will this be fixed soon as writing unit tests is a must have strategy for us whilst developing our UWP commercial app?

Regarding the last suggestion by @jamesfisher314, I tried changing the class definition of the UnitTestApp to Template10.Common.BootStrapper, but it still produced the run time issue when trying to execute the tests:

A user callback threw an exception.  Check the exception stack and inner exception to determine the callback that failed.
========== Run test finished: 0 run (0:00:03.4230976) ==========

Has anyone any other ideas to resolve this?

I'm not certain why this is marked as an enhancement/question.  If this problem can't be fixed, Template 10 becomes pretty much impossible to use in a BDD/TDD solution.
I'm hoping there is a quick resolution to the problem, because I've otherwise liked the product.

Hello, for what I found the issue seems not specific to Template10, but arises every time you inherit your App class from a custom class (not Windows.UI.Xaml.Application). In fact, similar issues are open on GitHub for Prism (https://github.com/PrismLibrary/Prism/issues/313) and Caliburn.Micro (https://github.com/Caliburn-Micro/Caliburn.Micro/issues/238). A solution is given by Brian Lagunas for the Prism issue, and consists in decorating the App class (the one that inherits from Template10.Common.BootStrapper) with the Windows.UI.Xaml.Data.Bindable attribute.
If the workaround seems not working at first, try to clean the solution and then build it again, it should work.
After some testing, I discovered that if you have a ResourceDictionary defined in a xaml file with an x:Class declaration (that's needed if you want to use x:Bind inside the resources defined in the dictionary), you have to apply Bindable attribute to that classes too.

Hi @effpath999, I have just tried your suggestion as below:
[Bindable]
sealed partial class App : Template10.Common.BootStrapper
{ ... }

Rebuilt the solution, but I am still seeing the following error when I execute the unit tests:

------ Run test started ------
Updating the layout...
Checking whether required frameworks are installed...
Registering the application to run from layout...
Deployment complete (926ms). Full package name: "c735c6b7-cdab-4278-b3ff-f1e84013266b_<IP_ADDRESS>_x86__vyscnqpsyk0kg"
A user callback threw an exception.  Check the exception stack and inner exception to determine the callback that failed.
========== Run test finished: 0 run (0:00:04.1231897) ==========

Is there anything else that I should be doing to get this workaround working?

Hi @SandipAhluwalia, I see from a comment above that you tried changing the class definition of the UnitTestApp to Template10.Common.BootStrapper. So, if you still have that class definition in your unit test app, you have to apply the Bindable attribute both to that class and to the app class of the app you want to test. Or, maybe better, just revert the class of the unit test app to a normal Application class.
Also, if you have any xaml file with an x:Class attribute defined, you have to apply the Bindable attribute to that class too (in my case I had two resource dictionaries defined in this way).
If this does not work, I fear I can't help more. Honestly I have not had the time to investigate why Bindable attribute should make the trick, I only found the suggestion in the link I posted above and found it worked in my case (with the already mentioned addition about the resource dictionaries files).

Thank you @effpath999 for your help. I finally got it working as per your suggestions :)
Because my App.xaml file contained my ViewModelLocator class for MVVM Light purposes, I had to also decorate that with Bindable attribute:
<Application.Resources>
        <ResourceDictionary>
        <ResourceDictionary.MergedDictionaries>
            <ResourceDictionary Source="Styles\Custom.xaml" />
        </ResourceDictionary.MergedDictionaries>
            <vm:ViewModelLocator x:Key="Locator" />
        </ResourceDictionary>
    </Application.Resources>

[Bindable]
public class ViewModelLocator
{...}

So this workaround works for me, so it does suggest this issue isn't specific to Template10 as already discussed, but a general UWP issue.

@effpath999 can you (or anyone) confirm this workaround?

Yes @JerryNixon, I confirm that I was able to run unit tests on a Template10 app with this workaround.
It definitely seems a bug related to how the UWP Unit Tests app works rather than to Template10.
@SandipAhluwalia, nice to know the thing about ViewModelLocator. I am using MVVM Light too with a ViwModelLocator, but I didn't run into the issue because I slightly modified it to return the ViewModel instances via static properties that I call in the code behind of the views, in order to have a compile-time, strongly-typed DataContext that is more x:Bind-friendly, so I didn't have to store a ViewModelLocator instance in the application resources.

Okay, so I'm not exactly sure what I'm supposed to be doing here, but when I change the unit test's application from:
sealed partial class App : Application
to
sealed partial class App : Template10.Common.BootStrapper
I get a number of compilation errors.
Is there something more that should be done here?

@PaulMouchet,  you don't have to change the class of the unit test app.
Instead, try to apply the Bindable attribute (Windows.UI.Xaml.Data.Bindable) to the class of the app you want to test (which already inherits from Template10.Common.BootStrapper).
Also, if you have a ViewModelLocator class defined as a resource in your App.xaml file, apply the Bindable attribute to that class too, as described in the latest comment from @SandipAhluwalia.

Hi @PaulMouchet, yes, in the end I only needed to apply the Bindable attribute to 2 classes, my Template10 App class and the ViewModelLocator class. I left my UnitTest App class deriving from Application.
@effpath999, I also use x:Bind too, but like setting the DataContext using the ViewModelLocator for normal run-time binding purposes within the page. Thanks again for your help as it means now we can properly progress at my company using Template10 commercially :)

Thanks!
I haven't tested it out thoroughly yet, but putting the [Bindable] decoration on my view model class seems to have done the trick.  I can now include a reference to Template10 in my test application and get a successful test result.

For any other random googlers out there, applying [Bindable] to my resource class worked, but only after I completely cleaned and rebuilt my entire solution. So, if you're struggling, rebuild.

Has anyone been able to debug their unit tests after adding [Bindable] to their application class to address this issue?
This exception is thrown for me:
Catastrophic failure (Exception from HRESULT: 0x8000FFFF (E_UNEXPECTED))

   at Windows.UI.Xaml.Application..ctor()
   at My.WindowsMobile.UI.App..ctor()
   at My.WindowsMobile.UnitTest.My_WindowsMobile_UnitTest_XamlTypeInfo.XamlTypeInfoProvider.get_OtherProviders()
   at My.WindowsMobile.UnitTest.My_WindowsMobile_UnitTest_XamlTypeInfo.XamlTypeInfoProvider.CheckOtherMetadataProvidersForName(String typeName)
   at My.WindowsMobile.UnitTest.My_WindowsMobile_UnitTest_XamlTypeInfo.XamlTypeInfoProvider.GetXamlTypeByName(String typeName)
   at My.WindowsMobile.UnitTest.App.GetXamlType(string fullName = "Windows.Foundation.IReference`1<Windows.UI.Xaml.Automation.Peers.AccessibilityView>")

I run into the same issue during debugging. Did you found the solution for this error (Catastrophic failure (Exception from HRESULT: 0x8000FFFF (E_UNEXPECTED))).
Many thanks.
Krisztian

Just to add some additional info about debugging: Although the Catastrophic Failure exception is thrown, it is not fatal. In fact, if you turn off 'Break when this exception type is user-unhandled', the unit test app will continue to run and the tests can be debugged as normal (and the test runner does not hang and can be re-ran without relaunching VS). Any code in the app-under-test's constructor does not get executed due to the exception, but this at least helped me debug some tests that were self-contained. Still not sure of the root cause (I know the Prism team said that UWP testing in this manner is not supported, but VS does support it and it works for apps that dont use a custom Application class, so there must be some way to get it to work).

Hi,
I run into the same issue trying to test my Template 10 app. But, the problem come when I add a reference to the UWP project it's using Template 10.
Error detail when run the tests:

Deployment complete (0:00:01.603). Full package name: "xxxx9927-b827-4b2b-8d3b-23ea8ad697ec_<IP_ADDRESS>_x86__rzzbfy5xexxxx"
A user callback threw an exception.  Check the exception stack and inner exception to determine the callback that failed.

Any idea/help will be appreciated
Thanks a lot

It's 28.7.2017 and the issue is still well and alive :(

Hi, can I get help on this issue? My App class is decorated with Bindable, I can find any other custom xaml that use x:Class. However I get this very issue when I try to use an xunit project

Still an issue in February 2018... Unit testing in UWP is seriously flawed!

Actually, it is not UWP but, it has to do with template 10, ALL my experimentation works, except when you use it with T10


Hide git prompt completely if git config flag "oh-my-zsh.hide-status" is set

Currently, when handling large git repositories on weak machines, generating the prompt can be really slow. For most oh-my-zsh themes, a good workaround is to manually set the "oh-my-zsh.hide-status" git config flag, which causes the git_prompt_info function to do nothing.
However, bullet-train does some extra work besides calling git_prompt_info. Therefore, setting this flag causes the git part of the prompt to be only partially hidden, and there is still an annoying delay. This should be fixed.
I have tested this fix successfully on my machines, and the check is basically the same as in Oh My Zsh (see https://github.com/robbyrussell/oh-my-zsh/blob/master/lib/git.zsh#L4).

Why not simply set BULLETTRAIN_GIT_SHOW to false? Or remove git segment entirely? (see #188). Won't the effect be the same?

@dawikur Can the BULLETTRAIN_GIT_SHOW flag can be set on a specific directory?

@reaktivo Unfortunately not, it ~is~ was global setting (which was removed in #188). What is your use case?

Same use case as @grensjo, I have a few git repositories where I want to completely disable any git status checking since it takes around 4 seconds, but ideally would like to only disable it for this directories and not globally.

I'm not a big fan of having too different ways to configure a similar feature, but I see the value.
I worked on a big git repo as well, and it took quite a while too show the prompt.
I vote for merging that in.

I see the point of it. Setting it per-repo might be a useful feature. We should only add comment about it to README so it would not be a hidden feature.

What I don't like is that, for doing the same thing for, let's say, mercury, that would be a different process.

Well, this is a built-in oh-my-zsh feature, and right now Bullet Train is incompatible with it. If the "oh-my-zsh.hide-status" is set in a git repo, the git info is currently partially visible with Bullet Train, which is clearly not desirable behavior.
Bullet Train should either show the git info in its entirety, or do as oh-my-zsh itself and hide it if the flag is set. Since the latter option is consistent with how other themes behave, and since it is a nice feature, I think that is the better option.
I agree that it is not optimal that this only works for git, but since we're talking about a repo-level config it is probably difficult to make this more general in a good way. Either way, since the behavior is already partially there it makes sense just fix this. If the feature is wanted for mercurial as well, I'm sure it's possible to do something similar there, but that is another issue.

👍
Still think it should be merged.

@grensjo Can you add documentation to README so I can merge your PR?

@caiogondim Done!


Assumption that newly published games will appear immediately

I've seen a lot of people panic when they don't see their game show up right away.
This is because the metrics lists only update a few hundred games every 2 minutes. With many thousands of games, it takes up to 15 minutes before all games have been updated.
That said, new items are inserted every 2 minutes, but their stats aren't necessarily calculated. This should be checked if the logic updates them too.
Also, it should be made clear (education) that your game wont show up right away.

I suggest a little notification when pressing publish that upon the 200 response says just This.

Closing this for #2046


Using SD prefix instead of adding it to the tokens json file

Summary
Not working yet for

[x] ts
[x] ts definition
[ ] js module
[ ] rm js module and repalce with ts-style commonJs module but make sure to fix: https://github.com/primer/brand/blob/fbb228eb76375456937c9e9ea548bad2b76afd5b/apps/docs/src/components/content/ColorScales.js#L4

It seems to not be possible with SD to have a prefix for the source tokens but not for the included ones. At least not without a custom format.

As expected docs are broken without reworking the color scale, after replacing js modules with commonjs:

With a slightly hacky transformer it is now working. We will need to remove this later: https://primer-5bb7c18307-26139705.drafts.github.io/brand/primitives/color


Actualized github help links

BTW, I think you meant updated or refreshed. The word actualized means something different in English so it's a false friend.


Show frame on reload or login if cooldowns exist

It would be nice to have the ability to show the panel by default post login or reload if there are cooldowns visible in the frame ("PLAYER_ENTERING_WORLD" event?).  People might want to only show if they are available for the current character but personally I want it to show if any character has one.
Thanks!

Added with 1.24.