Ask review of concluded Rakuten Backend Code Challenge

Hi @rpanachi
I finished the challenge, so let me explain briefly what I have done.
I chose Hanami in order to develop this app, because there is a nice use case in production on Rakuten as I read in your blog, so I took the opportunity to learn something new and I really loved the experience.
I built and Hanami app named Shipping with 2 controllers#actions, distances#create and costs#show.
On distances end point, exposes the creation of Distance entities, composed by origin, destination and value fields, this is all we need to reconstruct a graph of locations.
On costs end point, there are other objects envolved in order to make possible to calculate the short distance path between two locations, a class called DijkstraGraph where I calculate the shortest_path between 2 points (this version was slightly inspired by https://github.com/mburst/dijkstras-algorithm, but with use of a more updated heap implementation from https://github.com/kanwei/algorithms), a class Location responsible to the communication between the graph and repository and a class Cost that is responsible by calculation.
I prepared some load tests as well where is possible to see how the app respond to high load access.
That is all! I'm available to answer any questions.

@rpanachi I committed some mistakes on indentation settings of my editor at home, but I have fixed right now.

@rpanachi I took the liberty to make some refactorings in order to improve performance and after some tests the /shipping/cost endoint that previously show an average of 20 req/sec, now reach the mark of 200 req/sec. I can explain what I did in detail if you want.


Kafka TCP connection leak

Howdy.  We're having an issue where Secor steadily opens connections to Kafka brokers but does not close them.  Eventually, Secor will eat up all its FDs, unless it causes our Kafka brokers to fall over first.
For now, we just restart Secor daily.

Hey did you find any work around or fix in terms of code change ? I am also observing res. memory increasing steadily unless one of the processes getting killed


Recorded date is missing from current profiles

@SmalsJulien @annenerenhausen
from https://github.com/hl7-be/referral/issues/400 :
The creation date is mapped to authoredOn, previously also recordedDate was mapped to authoredOn. Do we need to add the extension?
Please provide advice.

@annenerenhausen  I think the "recordedDate" is based on your request, or maybe due to "Cosign" specifications ? Can you precise this need to be sure we actually need it ?
"AuthoredOn" is indeed something that we want to use for "CreationDate in LogicalModel" (in the soft of the prescriber, not when stored in DB).


[BUG]: IOS preroll ads issue

Version
6.0.0
What platforms are you having the problem on?
iOS
System Version
IOS
On what device are you experiencing the issue?
Real device, Simulator
Architecture
Old architecture
What happened?
play any video with adtag url containing preroll ads. On android the ad will play perfectly and then the video will play. But on IOS the video plays for almost 2 seconds then ad plays and then video plays again. It should play the ad fist then play video on IOS too as on Android.
Reproduction
repository link
Reproduction
Step to reproduce this bug are:
Play any video just add preroll adtagUrl.

I close the issue as duplicate of: https://github.com/TheWidlarzGroup/react-native-video/issues/3114
There is a workaround in this ticket (even if I don't like it)


Hanoi University of Public Health

@ththuph Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

You can provide us with any of the following as the proof:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@ththuph You might miss my previous comment. Please react.

@ththuph I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


Update pre-commit Config

Description
Updates our pre-commit config file with latest versions of hooks. See #334
Fixes
Warnings produced by pylint for usage of dict() rather than {}.

Codecov Report

Merging #335 (6c865d8) into master (2ca9886) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   41.87%   41.87%
=======================================
  Files          15       15
  Lines         905      905
=======================================
  Hits          379      379
  Misses        526      526

Flag
Coverage Δ

gha
41.87% <50.00%> (ø)

python-3.6
41.87% <50.00%> (ø)

unit
41.87% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

snafu/benchmarks/_benchmark.py
46.47% <0.00%> (ø)

snafu/config.py
97.95% <100.00%> (ø)

snafu/registry.py
90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ca9886...6c865d8.


Bug: Files cannot launch

Description
With the “Set Files as the default file manager” option enabled, when I try to start Files by “Win + E” or “Settings->About->Open log location” in Files, I get the following screenshot is displayed and it does not start.

Translation:
This application cannot be run on your PC
Check with your software publisher for the version of the app that can be used on this PC.
Steps To Reproduce

Enable “Set Files as the default file manager” option
Win + E
Click “Settings->About->Open log location”

Files Version
<IP_ADDRESS>
Windows Version
10.0.26100.2605
User ID
82ac0941-3dfe-4f9d-95f1-03fd3754e7ad
Log File
debug.log

Thanks for the report, You have to turn off Files settings > Advanced > Set as default, then reinstall Files and turn it on again.

I tried it once and it didn't work out.

Did you reinstall files before turning it on again?

I did it again and it worked.
I don't think I did the procedure wrong last time, but it worked this time anyway.
Thanks for the response.


ISPN-6851 Use SYM_ENCRYPT protocol in JGroups encrypt test

https://issues.jboss.org/browse/ISPN-6851

I haven't seen this failure for a long time: http://ci.infinispan.org/viewLog.html?buildId=41027&buildTypeId=bt9&guest=1#testNameId5960055477641039061
Let me retrigger CI to see if it's related.

Pushed to master, thanks


Vv 143 manager api tests

What
Added unit test for the following apis

archive-manager
update-a-manager-status

Why
Because tests are very essential.
Screenshots
N/A
Notes
N/A

Please see Vv 143 edit and archive manager api tests pull request instead. Thanks

Please see Vv 143 edit and archive manager api tests pull request instead. Thanks


Header Redesign - Material UI

The Current header design needs a Fresher Look. Come up with your creativity and be a part of the Alexa Community Jaipur Developers.
Before asking for assigning the issue, make sure you are able to run the project locally. If you face any errors, comment down. 😄

Can I do that?

Sure, were you able to run the project locally without any errors?

is it open?

Yes @harshalkaigaonkar it is open. Would you like to work?

@tarunnsingh yes!!

I want to ask that is there more buttons or functions do we need on the header?

We would need a Drop Down button for Blogs and a Logout button only as of now.
Thanks!

Yeah okay!

If you want to add more functions, you are always welcome.
Or if not now then later on I'd put more issue on any such requirements and assign them to you.
As making a successfull PR on this issue, you'd be a part of contributors.

is the Login State is created?

And What about the blog section?

is the Login State is created?

We are working on Login, but it's not yet implemented.

And What about the blog section?

The current pages displays blogs on the first page itself, in future we'd separate this into different pages, for that we would require a blogs drop-down, the drop down menu would contain the different categories of blogs. As of now if a dummy implementation of the same (the drop-down) is required

just check the PR . And respond.

whats the issue with the PR?

Sorry for late response, I'll review your PR in a while.

Closing since Done.


#164694221 Biuld out Rest endpoints for articles

Description of tasks to be completed
Have the following endpoints working
POST api/articles
GET api/articles
GET api/articles/<slug>
PUT api/articles/<slug>
DELETE api/articles/<slug>
How should this be manually tested

clone the repo and cd into the directory then create a virtualenv and activate
install all the requirements using command 'pip install -r requirements.txt'
ensure to set all the environment variables in the .env file and the run the server using command 'python manage.py runserver'
open postman or your favourite client and test out all the endpoints listed above
use this data format in the body {"article":{"title":"title","body":"body","description":"description"}}

Alternatively

You can test out the above endpoints using a link provided by the review app with the same data format

What are the relevant pivotal tracker stories
#164694221
Screenshots

successfully created article

view all articles

article updated successfully

artical successfully deleted

Coverage decreased (-2.5%) to 90.548% when pulling 39e38c19ae91b2c15898f15cb87ca29f108c6386 on ft-create-articles-164694221 into 82fe8087fbd94a5072aecd9437334dcee9537609 on develop.

@frankopkusianwar , correct the typo in your PR name


MAINT: Speed up some slow tests

In https://github.com/scipy/scipy/pull/16487 several tests are decorated with @pytest.mark.timeout(120) because they exceeded 1 minute runtime on at least one CI run -- pinging people based on a rough blame look:

[ ] scipy/optimize/tests/test_linprog.py : test_mip6 -- #15294 @mckib2 @mdhaber
[ ] scipy/optimize/tests/test_milp.py : test_milp_6 -- #15460 @mdhaber
[ ] scipy/sparse/linalg/_dsolve/tests/test_linsolve.py : test_random -- > 5 years old
[ ] scipy/sparse/linalg/tests/test_propack.py : test_examples -- #14433 @mckib2 @tupui
[x] scipy/stats/tests/test_continuous_basic.py : test_moments for skewnorm -- fixed by #16503
[ ] scipy/stats/tests/test_continuous_basic.py::test_kappa4_array_gh13582 -- macOS CI

It would be great to speed these up!

@larsoner, https://github.com/scipy/scipy/pull/16503 should fix the slow test_moments test for skewnorm.

This one is making the macOS CI fail: scipy/stats/tests/test_continuous_basic.py::test_kappa4_array_gh13582

@tupui want to open a quick PR to add a pytest.mark.timeout(120) or so to that test?

scipy/sparse/linalg/_dsolve/tests/test_linsolve.py : test_random has already been parametrized.
https://github.com/scipy/scipy/blob/26445e52e8c92757b3c45d33e9529c8bbdcc392c/scipy/sparse/linalg/_dsolve/tests/test_linsolve.py#L832-L841
scipy/sparse/linalg/tests/test_propack.py : test_examples has already been marked xslow.
https://github.com/scipy/scipy/blob/26445e52e8c92757b3c45d33e9529c8bbdcc392c/scipy/sparse/linalg/tests/test_propack.py#L92-L96
scipy/stats/tests/test_continuous_basic.py::test_kappa4_array_gh13582 has also been marked xslow.
https://github.com/scipy/scipy/blob/26445e52e8c92757b3c45d33e9529c8bbdcc392c/scipy/stats/tests/test_continuous_basic.py#L963-L964


Do not error on certain GPU's

This will handle edge cases where the GPU is not an expected value.
An example of this is if your on your phone.
Oh, I also replaced a case of var with const cause it's bad to use var unless you need it,

We should use the GPU name queried from the server


Add 'browse list' as a pattern

In reference to a conversation @tombye and I had in person: this pull request represents an iteration on the current homepage design which @ralph-hawkins has been working on. The intention would be to roll out this change from the toolkit to the Marketplace, whose homepage currently looks like this:

:+1:


Don't preprend v when elixir version does not start with digits

Closes #60
This commit conditionally prepends v on an elixir version. Specifically, when the elixir version starts with digit, we prepend v, otherwise we leave it as is.

@wojtekmach


Dark mode

I want to change the bottom sheet colour to dark theme instead of just white.
It will be great if we have a prop such as mode light or dark
Reference image

Hey @mominnawaf actually you can do this with the prop "theme". We discovered yesterday that it's not well documented and we will update the docs. Here is the example of the darkMode picker
https://github.com/TheWidlarzGroup/rn-emoji-keyboard/blob/master/example/src/Dark/Dark.tsx

I've also added theming section to the docs. You can check it out here:
https://thewidlarzgroup.github.io/rn-emoji-keyboard/docs/api/theme
https://thewidlarzgroup.github.io/rn-emoji-keyboard/docs/api/styles


Rewrite a lot of Lights Out so it looks nicer and performs better

Design
Cache jQuery objects

var $table = $('table');
// Use $table instead of $('table') below

Shrink that flip function; it seems to do a lot more than flip

start by fixing the damn buttons

@Bergenfrundt That was actually fixed when you changed the font.

i'm a god


Improve Resolver

@JanTvrdik, I think we must see this and the ideas in #6 and #11 as a whole and put a little more thought in it. AFAIK the issue isn't about correctness but usability. What's needed is a more convenient API to deal with paths/URIS in general (relative/absolute/not-specified). Implementation may then vary wildly.
I won't have much time in the next days unfortunalely, so here are just quick notes:

A solution for #6 is a must-have IMO, but it's actually a little trickier than I thought, given we'll also want some kind of cache for resolved pointers.
Opening registerSchema could have its uses, but allowing to register relative URIs might be a source of problems (how do we resolve relative URIs within the included schema, if any?) and in some cases, contrary to the spec (we'll just make blind substitutions instead of following the official resolution algorithm)
There are probably other things to explore, like adding shortcut methods on the validator for the most common cases (validateFromUri($instance, $schemaUri), validateFromFile($instance, $schemaPath), etc.).

This should now hopefully solve #6 and #11. #15 is out of scope of this already large PR.

Thanks for your work. On the positive side:

Conformance to RFC 6901 is a really good catch. The only missing part to make it complete now is the treatment of malformed pointers as errors.
Changes to Uri are most welcome.
Storing the root schema separately does solve #11.

On the other hand:

#6 isn't solved yet
There's something wrong in the refactoring of the resolver. The test you've deleted was failing for a good reason. You may have over-simplified the resolver behaviour.

#6 isn't solved yet

It should be. Functionally mentioned in https://github.com/stefk/JVal/issues/6#issuecomment-207998771 remained intentionally unimplemented because relative URLs cannot be handled reliably.

The test you've deleted was failing for a good reason.

I disagree. The specification regarding $ref and id is terrible, but the way I understand it, the evaluation process of the scoped-references.json schema should work as follows

The whole schema has assigned URI http://localhost:1234/valid/scoped.json
First $ref is resolved against current schema URI to http://localhost:1234/valid/items-array.json and fetched from disk
Second $ref is resolved against current schema URI to http://localhost:1234/valid/exclusiveMinimum-not-present.json and fetched from disk
New schema is declared with URI resolved to http://localhost:1234/valid/exclusiveMaximum-not-present.json
Third $ref is resolved against current schema URI (which was changed!) to http://localhost:1234/valid/exclusiveMaximum-not-present.json and fetched from memory

Note: the schema is actually sort-of invalid because content of http://localhost:1234/valid/scoped.json#/properties/baz should be identical to http://localhost:1234/valid/exclusiveMaximum-not-present.json but it not.

I don't see anything in the spec to support that reasonning. Scopes have nothing to do with "declaration" of schemas, they're just a way to alter the URI against which references will be resolved. They're also completely indifferent to the way references will be fetched (disk/memory/...). Reading the relevant section of the spec, I think the only possible interpretation is:

The original resolution scope is the URI of the file (file://path/to/scoped-references.json).
The first id creates the scope http://localhost:1234/valid/scoped.json.
References in foo and  barare resolved against that scope, which gives:

http://localhost:1234/valid/item-array.json
http://localhost:1234/valid/exclusiveMinimum-not-present.json

The id in baz alters the parent scope, making it http://localhost:1234/valid/exclusiveMaximum-not-present.json
The $ref in oneOf is resolved against that scope, leading to http://localhost:1234/valid/exclusiveMaximum-not-present.json#

The expected content of #/baz/oneOf/0is thus the whole schema located at that last URI, i.e.:
{
  "maximum": 2
}

It is the case in the current implementation, and that's what the test is checking.


README: Add MS Edge to Browser Support table

i.e. https://en.wikipedia.org/wiki/Microsoft_Edge

We actually haven't fully tested in Edge. So this would be us saying we fully support something we haven't checked. I'd rather we just not as this and move forward with testing in Edge for 2.x.

Thanks, @cvrebert! We'll be sure to add some information to the table once we've done some proper testing.
Sadly, until recently the Windows 10 modern.ie VMs had an issue with Edge sending the wrong user agent, which threw some of our dependencies off (namely, Google Fonts) and prevented us from doing full testing. We'll go back to it at some point (probably during 2.0 development) and see if the issue has been fixed!


Local repository is not tried when downloading dependencies, failing download

Describe the bug
When scanning my project, the Maven part fails because of one the dependencies cannot be downloaded.
This dependency is defined in the multiplatform/lib folder of my project which I'm using as a local repository, and defining like so in my pom.xml:
        <repository>
            <id>multiplatform-local-repository</id>
            <url>file://${project.basedir}/multiplatform/lib/</url>
        </repository>

When building with Maven as I usually do, this works fine, but for some reason the scan does not pick it up as a valid location to find dependencies, it tries other repositories (Maven Central + my other remote repositories definitions) and thus, fails to download the specific dependency from my local repository.
SBM Version
0.15.0
SBM Application
spring-boot-upgrade.jar
To Reproduce
Steps to reproduce the behavior:

Define a pom.xml with a local repository definition like my example above
Create the corresponding folder and Maven nested repository structure and put a dependency (JAR + POM) in it
Declare it as a dependency
Scan the project with spring-boot-upgrade.jar

Expected behavior
All dependencies should be downloaded, including the one from the local repository.
Stacktrace
Caused by: org.openrewrite.maven.MavenDownloadingExceptions
	at org.openrewrite.maven.MavenDownloadingExceptions.append(MavenDownloadingExceptions.java:47)
	at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:184)
	at org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:124)
	... 19 more
	Suppressed: org.openrewrite.maven.MavenDownloadingException: Unable to download POM. Tried repositories:
https://jitpack.io: HTTP 404
https://repo.maven.apache.org/maven2: HTTP 404
		at org.openrewrite.maven.internal.MavenPomDownloader.download(MavenPomDownloader.java:561)
		at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:579)
		at org.openrewrite.maven.tree.ResolvedPom.resolveDependencies(ResolvedPom.java:502)
		at org.openrewrite.maven.tree.MavenResolutionResult.resolveDependencies(MavenResolutionResult.java:179)
		... 20 more

Desktop (please complete the following information):

OS: MacOS
Version: Sonoma 14.5
(M2 with Apple Silicon chip)

Chiming in to say the same happens for me. Some manner of flag to check local repos, or just automatically check for them when the pom.xml mentions them, would be nice.


ng update @angular/cli error

debian:~/projects/myapp# rm -rf node_modules dist
debian:~/projects/myapp# cnpm uninstall --save-dev angular-cli
npm WARN deprecated<EMAIL_ADDRESS>1.2.0 should have been a major version bump

<EMAIL_ADDRESS>install /root/projects/myapp/node_modules/node-sass
node scripts/install.js

Cached binary found at /root/.npm/node-sass/4.9.0/linux-ia32-57_binding.node

<EMAIL_ADDRESS>postinstall /root/projects/myapp/node_modules/webpack/node_modules/uglifyjs-webpack-plugin
node lib/post_install.js

<EMAIL_ADDRESS>postinstall /root/projects/myapp/node_modules/node-sass
node scripts/build.js

Binary found at /root/projects/myapp/node_modules/node-sass/vendor/linux-ia32-57/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"ia32"})
added 1182 packages from 1146 contributors in 43.208s
debian:~/projects/myapp# cnpm install --save-dev @angular/cli@latest
⠼ [0/1] Installing<EMAIL_ADDRESS>unsupported<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>›<EMAIL_ADDRESS>Package require os(darwin) not compatible with your platform(linux)
<EMAIL_ADDRESS>optional install error: Package require os(darwin) not compatible with your platform(linux)
✔ Installed 1 packages
✔ Linked 202 latest versions
================================================================================
The Angular CLI configuration format has been changed, and your existing configuration can
be updated automatically by running the following command:
ng update @angular/cli
✔ Run 1 scripts
Recently updated (since 2018-06-03): 7 packages (detail see file /root/projects/myapp/node_modules/.recently_updates.txt)
✔ All packages installed (226 packages installed from npm registry, used 5s, speed 556.83kB/s, json 203(2.6MB), tarball 0B)
debian:~/projects/myapp#   ng update @angular/cli
schematics_1.HostSink is not a constructor
TypeError: schematics_1.HostSink is not a constructor
at NodeWorkflow.execute (/root/projects/myapp/node_modules/@angular-devkit_schematics@0.6.8@@angular-devkit/schematics/tools/workflow/node-workflow.js:75:24)
at Promise (/root/projects/myapp/node_modules/@angular_cli@6.0.8@@angular/cli/models/schematic-command.js:140:22)
at new Promise ()
at UpdateCommand.runSchematic (/root/projects/myapp/node_modules/@angular_cli@6.0.8@@angular/cli/models/schematic-command.js:139:16)
at UpdateCommand. (/root/projects/myapp/node_modules/@angular_cli@6.0.8@@angular/cli/commands/update.js:70:25)
at Generator.next ()
at /root/projects/myapp/node_modules/@angular_cli@6.0.8@@angular/cli/commands/update.js:7:71
at new Promise ()
at __awaiter (/root/projects/myapp/node_modules/@angular_cli@6.0.8@@angular/cli/commands/update.js:3:12)
at UpdateCommand.run (/root/projects/myapp/node_modules/_@angular_cli@6.0.8@@angular/cli/commands/update.js:69:16)
debian:~/projects/myapp#
debian:~/projects/myapp#
debian:~/projects/myapp# node --version
v8.11.2
debian:~/projects/myapp# npm --version
<EMAIL_ADDRESS>(/usr/lib/node_modules/cnpm/lib/parse_argv.js)
<EMAIL_ADDRESS>(/usr/lib/node_modules/cnpm/node_modules/npm/lib/npm.js)
<EMAIL_ADDRESS>(/usr/local/bin/node)
<EMAIL_ADDRESS>(/usr/lib/node_modules/cnpm/node_modules/npminstall/lib/index.js)
prefix=/usr/local
linux ia32 4.9.0-6-686-pae
registry=https://registry.npm.taobao.org
debian:~/projects/myapp#

I checked out Angular5 source code on new machine where latest version of npm installed (6.1.0).
old version was 5.1.0
i am geting same error on executing NPM install
any solution available.?


Introducing ThingSpeak webhook template

Summary
Adding ThingSpeak webhook template.
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Compatibility: The changes are backwards compatible, they don't break existing deployments.
[x] Testing: The changes are tested.
[ ] Documentation: Relevant documentation is added or updated.

@johanstokking adding you as a reviewer since Adrian is off


Unnatended manual site with alternate names?

I am not using iis and want to create a single cerrificate with a few alternate names. Can this be done unnatended?

Yes.
You can run the command line tool with the "--san" option. Answer the prompts, then press "m" at the menu to choose "manual". You will give your primary fqdn, then a list of ALL SAN fqdns (including the primary fqdn).
After that you specify a webroot. This is the base path of a webserver that responds to all of the SAN fqdns that you listed above. The tool will validate each fqdn separately, then generate a single cert if they all pass. Afterwards a scheduled task will be created to perform the same process automatically every 2 months.

You can do a manual unattended request for only a single site right now.
You can do a manual request for SAN but it isn't unattended. All SAN support isn't unattended.

The manual plugin won't automatically renew. The app will only automatically renew if you are using IIS.

@rkerber once the cert is generated it will renew unattended, right?

Wow sure enough. I was very much under the impression that the manual plugin could renew.

so... @rkerber i just did a quick scan of the issues and don't see anything about it. Are there plans to have the manual plugin be able to renew? I don't understand why it doesn't. The registry has all the information it should need.

Nope it can't. Plus if it did, it would renew the cert but it would just save it on the server but wouldn't be used by anything so the admin would have to remember to get the cert from there and install it every 2 months.
Only the IIS plugin, and the IISSiteServer plugin (IIS with SAN support) allow for automatic renewals.

Wouldn't it be better to have a cert waiting for you than having to renew then import?
On a side note, I have written a powershell script to import my cert into my RDS deployment if the cert is new (I guess a poor-man's method instead of writing a proper plugin) that runs 60 seconds after the LE renewal task.

@LBegnaud maybe you should open up a separate issue so we can talk about this more there since it's not completely on track with this issue.

sure thing, sorry for derailing

Thanks for the info, to make things easy (or maybe more comlplicated) I have installed IIS and configured a site on an unused port with all the San names. I will then use the automated  process to create the certs and handle the renewal and just grab the certs   from the lets-encrypt directory on a schedule for may alternate purpose. (In this case a nginx reverse proxy)


Enhancement: Viewer Options

The Viewer should support options upon construction as well as run time. These include:
drawAxis : true,
axisSize : 300 + 10, // must be even
axisXColor: [1.0,0.0,0.0,1.0], // RED in positive direction
axisYColor: [0.0,1.0,0.0,1.0], // GREEN in positive direction
axisZColor: [0.0,0.0,1.0,1.0], // BLUE in positive direction
drawLines: false,
drawPlate: true,
plateSize: 300,      // must be even
plateMajor: [0.5,0.5,0.5,0.5], // color of plate major division
plateMinor: [0.8,0.8,0.8,0.5], // color of plate minor division
perspective: 45,
viewpoint: [0,-5,100],
meshColor: [1.0000,0.4000,1.0000,1.0000], // PURPLE

Closing. Viewer options are available from Alpha Release 0.5.0


Make listen check before daemon fork

There seems to be a race condition related to sesman_listen_test() when  xrdp-sesman is run in daemon mode.
Because sesman_listen_test() is called after the daemon fork() call, there is a chance that it will be called in the parent at the same time as the child trying to listen. The following log was produced on a RHEL 7.4 system when this happens:-
xrdp-sesman[11958]: (11958)(139665042258048)[DEBUG] libscp initialized
xrdp-sesman[11961]: (11961)(139665042258048)[INFO ] starting xrdp-sesman with pid 11961
xrdp-sesman[11958]: (11958)(139665042258048)[DEBUG] Testing if xrdp-sesman can listen on <IP_ADDRESS> port 3350.
xrdp-sesman[11961]: (11961)(139665042258048)[INFO ] listening to port 3350 on <IP_ADDRESS>
xrdp-sesman[11958]: (11958)(139665042258048)[ERROR] Failed to start xrdp-sesman daemon, possibly address already in use.
systemd[1]: xrdp-sesman.service: control process exited, code=exited status=1
xrdp-sesman[11961]: (11961)(139665042258048)[INFO ] shutting down sesman 1
xrdp-sesman[11961]: (11961)(139665042258048)[DEBUG] Closed socket 9 (AF_INET <IP_ADDRESS>:3350)

With the attached patch, the two processes did not interfere with each other, and this log was produced:-
xrdp-sesman[11991]: (11991)(140064586561664)[DEBUG] libscp initialized
xrdp-sesman[11991]: (11991)(140064586561664)[DEBUG] Testing if xrdp-sesman can listen on <IP_ADDRESS> port 3350.
xrdp-sesman[11994]: (11994)(140064586561664)[INFO ] starting xrdp-sesman with pid 11994
xrdp-sesman[11991]: (11991)(140064586561664)[DEBUG] Closed socket 7 (AF_INET <IP_ADDRESS>:3350)
xrdp-sesman[11994]: (11994)(140064586561664)[INFO ] listening to port 3350 on <IP_ADDRESS>
systemd[1]: Started xrdp session manager.

I'lll look at this after new year's vacation.


Bring http-client and time deps up-to-date.

The new http-client package causes no API issues.
The new time package has a deprecation notice on parseTime in favor
of parseTimeM. Docs for this are here: https://hackage.haskell.org/package/time-<IP_ADDRESS>/docs/Data-Time-Format.html
It also provides its own defaultTimeLocale instance, replacing the
previous one imported from System.Locale. Though tests still pass, their
implementation is at least slightly different. Because of this we bump
the major version number of twilio-haskell in this commit.

Thanks for the PR.
Just wondering about

Though tests still pass, their implementation is at least slightly different. Because of this we bump the major version number of twilio-haskell in this commit.

Reading through Package versioning policy, it seems like we may be able to just bump component C:

If any entity was removed, or the types of any entities or the definitions of datatypes or classes were changed, or orphan instances were added or any instances were removed, then the new A.B must be greater than the previous A.B. Note that modifying imports or depending on a newer version of another package may cause extra orphan instances to be exported and thus force a major version change.
Otherwise, if only new bindings, types, classes, non-orphan instances or modules (but see below) were added to the interface, then A.B may remain the same but the new C must be greater than the old C. Note that modifying imports or depending on a newer version of another package may cause extra non-orphan instances to be exported and thus force a minor version change.
Otherwise, A.B.C may remain the same (other version components may change).

I'm leaning towards <IP_ADDRESS> rather than <IP_ADDRESS>--what do you think?

Let's go with that. As far as I can tell the package versioning policy doesn't have any requirement to bump major or minor versions as long as the package still compiles the same.
I had totally misunderstood it. I hadn't realized the policy had such a strong emphasis on what will compile over changes in general.
I amended the commit to <IP_ADDRESS> and force pushed.

thanks!


Popper causing warnings when running tests

Reproduction demo

https://github.com/mogusbi/react-popper-test-error
Steps to reproduce the problem

Clone the repo
Install dependencies
Run npm test

What is the expected behavior?
Tests to run without any warnings being emitted
What went wrong?
Any test that contains a component that has popper causes this warning to be outputted.
This is happening when using hooks and when using the older render method.
console.error node_modules/react-dom/cjs/react-dom.development.js:88
      Warning: An update to Hook inside a test was not wrapped in act(...).

      When testing, code that causes React state updates should be wrapped into act(...):

      act(() => {
        /* fire events that update state */
      });
      /* assert on the output */

      This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act

Packages versions

Popper.js: 2.3.2
react-popper: 2.2.2

We have a couple of those warnings in our test suite too, I don't know how to fix them, but I'm almost positive it's not an issue with the library itself, but with the way the tests are written.

I'm not so sure as these warnings were not appearing in version 1 of the library

v1 didn't use React Hooks, those warnings appear only if the component is using them and the tests are not properly written

Please take a look at this commit to see how I fixed the warnings in react-popper's tests, you should do something similar in your tests.
https://github.com/popperjs/react-popper/commit/8074c07a35c264d08b31d847a64c8cf05c0aa813

@FezVrasta I think this should be re-opened....
By my reading, the warning is exactly right, and it's up to react-popper to help. The problem is: createPopper() runs its first update() asynchronously.
For instance, with this code and test (pseudo-code, just so we're all talking about the same thing):
// Popup.js
export default function Popup() {
  const [referenceElement, setReferenceElement] = React.useState(null)
  const [popperElement, setPopperElement] = React.useState(null)
  const { styles, attributes } = usePopper(referenceElement, popperElement)

  return (
    <>

Reference

Pop!

    </>
  )
}

// Popup.test.js

it('should mount', () => {
  act(() => {
    const wrapper = mount(<Popup />) // enzyme, @testing-library ... same problem
  })
  expect(true).to.be(true)
})

Here's what happens when the test is run:

Popup mounts. referenceElement and popperElement are null, so styles and attributes come back empty.
During mount, setReferenceElement() and setPopperElement() are called. That leads to a re-render with new referenceElement and popperElement. Now, usePopper() can take action. react-popper returns some styles and attributes ... and its internal createPopper() schedules an update (this is the problem!)
The test finishes! act() returns. Popper never updated.
Popper updates ... which leads to a re-render with new styles and attributes. React warns, because the test executed out-of-order.

Indeed, @FezVrasta, there is a very subtle trick in commit 76822a25ebb87592ad7faea7c3c407f5be1f2da0 that seems unintentional. I think it's erroneously hiding the warning.
The code added in that commit:
  await act(async () => {
    result = await render(

render() is synchronous, so await ought to do nothing, right? But of course, JavaScript is more nuanced than that! Calling await render(...) runs render() synchronously, and then it flushes the Promise microtask queue. I suspect that's the only reason update() finishes before the act() code block finishes.
How to solve?
 Nix the await render() from the test suite: instead, write an await null with a comment after render(). Document that all unit tests must wrap all actions in act() (unless they kick off a code path that calls forceUpdate()?), and explain that they need an await null in them.
Make react-popper prevent Popper from calling update(); instead, make react-popper call useLayoutEffect() at the right times. For instance, react-popper would attach scroll-event handlers, and it would prevent @popperjs/core from doing so. I don't know how perilous this path would be ... but as a React user I mistrust all libraries that touch the DOM outside of event handlers and useLayoutEffect().)

Here's what I write in my own unit tests:
    wrapper.find('button.context-button').simulate('click')
    await act(async () => await null) // Popper update() - https://github.com/popperjs/react-popper/issues/350

@srosato works perfectly, thanks!


export problems for healthyAirwaysAtlas

submission in ui
error message during export of metadata when writing the staging_area.json file:
Could not verify completed upload for blob prod/ef1e3497-515e-4bbe-8d4c-10161854b699/staging_area.json within maximum wait time of 3600 seconds

This is related to https://app.zenhub.com/workspaces/operations-5fa2d8f2df78bb000f7fb2b5/issues/zh/23

The problem is reproduced when I export the project again.
I still don't know what the cause is.

The failed export produced at least the project json so we filled out the import form to get the new lung atlas metadata to the browser.
The project has been forced to exported status - the export issues are not solved but might not show up again

Closing the ticket because this is low priority and we don't have capacity to investigate


Add a bot filter to the onjoinrole feature

seems obvious, why didnt i thought about it sooner?

done


Unload failing

System Health details
System Information

version
core-2024.7.3

installation_type
Home Assistant Container

dev
false

hassio
false

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
4.4.302+

arch
x86_64

timezone
Europe/Rome

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
5000

Installed Version
1.34.0

Stage
running

Available Repositories
1383

Downloaded Repositories
19

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Dashboards

dashboards
3

resources
16

views
2

mode
storage

Recorder

oldest_recorder_run
July 16, 2024 at 10:10 AM

current_recorder_run
July 24, 2024 at 10:08 AM

estimated_db_size
558.72 MiB

database_engine
sqlite

database_version
3.45.3

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
Every morning integration show the message "Failed to unload" and i need to restart HA to let the inverter integraton works again.
I have spook that unload the integration when the inverter goes off in the evening and reload it when the inverter restart in the morning
Debug log show many things but (in my own opinion) i think the problem could be the "unloading" process that recently doesn't work.
Thanks, Gianluca
Reproduction steps
unload integration with spook
Debug logs
2024-07-24 21:08:01.977 ERROR (MainThread) [homeassistant.config_entries] Error unloading entry ABB Inverter for abb_powerone_pvi_sunspec
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 801, in async_unload
    result = await component.async_unload_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/abb_powerone_pvi_sunspec/__init__.py", line 146, in async_unload_entry
    hass.data[DOMAIN][config_entry.entry_id].update_listener()
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '68e100a5b589d468733b76141e936def'

Diagnostics dump
No response

You should not unload the integration in the evening, leave it working, you will have a warning when the inverter goes offline, then HA retries to reconnect quietly, without any entry in the log, since I'm using DataCoordinator that handles this scenario automatically.
Have you tried "disabling" the integration from HA? does it give you an error?

Ok Alex, i've removed spook automation, let's see.......thank you for your reply.
Manual disabling require a HA reboot to completely disable ABB integration. After that the integration could be enabled without any problem.
Thanks

Nope. I used Spook in the past to enable/disable the integration on the fly, before I implemented DataCoordinator, because it spammed the log. No need to restart HA.
This was the automation to disable/enable it on VSN300 disconnect:
alias: State of ABB Custom Component
description: >-
  Ensure ABB Component is running in the morning and disable it at sunset to
  avoid filling log with errors
trigger:
  - platform: state
    id: trigger_abb_vsn300_connected
    entity_id:
      - binary_sensor.ping_sensor_abb_vsn300
    from: "off"
    to: "on"
    for:
      hours: 0
      minutes: 0
      seconds: 20
  - platform: state
    id: trigger_abb_vsn300_disconnected
    entity_id:
      - binary_sensor.ping_sensor_abb_vsn300
    from: "on"
    to: "off"
    for:
      hours: 0
      minutes: 0
      seconds: 20
condition: []
action:
  - choose:
      - conditions:
          - condition: trigger
            id: trigger_abb_vsn300_connected
        sequence:
          - service: homeassistant.enable_config_entry
            data:
              config_entry_id: 54dcc9b0ac601ef0a7d78ebcd861cc76
          - service: homeassistant.reload_config_entry
            data: {}
            target:
              device_id: ab0bea32218dfd580d560e46fc85c722
      - conditions:
          - condition: trigger
            id: trigger_abb_vsn300_disconnected
        sequence:
          - service: homeassistant.disable_config_entry
            data:
              config_entry_id: 54dcc9b0ac601ef0a7d78ebcd861cc76
mode: single

Anyway, like I said, don't disable it, there's no need.


Make HitTestParameters.sprites readonly

Per the discussion on #26, this change makesHitTestParameters.sprites readonly Sprite[] rather than Sprite[].
Tested as follows, but let me know if some other form of testing is appropriate:
$ npm test                                                                                ⬡ 16.15.1 [±dev ✓]

><EMAIL_ADDRESS>test
> karma start karma.conf.ts

webpack was not included as a framework in karma configuration, setting this automatically...
Webpack bundling...
Webpack starts watching...
...
webpack 5.27.2 compiled successfully in 7752 ms
26 06 2022 16:20:16.832:WARN [karma]: No captured browser, open http://localhost:9876/
26 06 2022 16:20:16.852:INFO [karma-server]: Karma v6.3.17 server started at http://localhost:9876/
26 06 2022 16:20:23.291:INFO [Chrome <IP_ADDRESS> (Mac OS 10.15.7)]: Connected on socket QqMQXNVZEfDdZG6VAAAB with id manual-2158
Chrome <IP_ADDRESS> (Mac OS 10.15.7): Executed 110 of 110 SUCCESS (1.837 secs / 1.743 secs)
TOTAL: 110 SUCCESS

Thanks! Unfortunately, there aren't unit tests for hit testing specifically (yet). But if this had caused compilation issues, I would have expected the Selection tests to have failed to compile, since the Selection-level hit test passes its internal sprites array (which is mutable) to the Scene's hitTest() method. So I vote to merge and if it causes issues down the line we'll deal with them.


Support ingresses annotations and default config

I'd love to be able to add SSO to a Ingress only by adding annotations in my ingresses. It could then use the config I saved in the initial sso-operator deployment as default to create a SSO resource (or handle it directly).
I'd love to try to build the integration if it fits anyone.
WDYT?

/close


Use rem for layout units

I think it would be better to use rem like tailwind does for layout size definitions as well. If all sizes are based on rem then the user can change the default font size and the layout of the page will not break.
If you're open to the idea I can create a PR.
Thanks for this excellent library!

Hey, not using rem for everything other than font was a conscious decision. All browsers fully support UI scaling without rem, except for the user specified base font size, which is why the font scale is in rem.
It would be really unintuitive if the entire layout scale changed if you had a different base font size for a project. There have been several discussions on the tailwind repo to undo that design decision, and it was only decided against because it would be too much of a breaking change for them.
So gonna flag this one as wontfix, but v open to further discussion!

Thanks for your detailed reply @madeleineostoja . That's interesting. I always found that this was an interesting topic since, as you said, scaling the UI is supported by all browsers, so why would you change the base font size. I guess, the question then is, why it's possible to change the default font size in the first place.
If you have a good article on that subject I'd be very interested!

Users can still change their base font size in the browser independently of UI scaling, which is why rem is still important for font sizes. And browsers didn’t used to all support full UI scaling, which is why using rem for all the things was a prominent best practice for so long. Now it’s largely an anti-pattern imo. If a user changes their base font size they prob don’t want the entire UI to scale, and moreover for a css library the units provided shouldn’t be relative to a font size, especially for embedded contexts (eg: widgets)


Update expo version

👌

Hix, There is no update after three months. :(
The current version of Exp is 41.3.0, while you're still running 36.0.0

Hi @giautm ! Apologies for not seeing this PR before. For some reason I was not watching this repository, so I never received any notifications. Because I am not actively working on the project, it went unnoticed.
Have you tested Appr on the latest commit version, 0.42?


Dev center reports deployment as failed when actually succeeded

This is a tricky report because it only happened once, and we could not replicate it anymore.
We created an environment, for a catalog item that took close to 4 minutes to complete. The devcenter project reported that the deployment failed, although the deployment was still in progress in the resource group. The deployment completed successfully but the dev center project did not update the status of the environment as successful.
Our best guess was regarding some timeout on the devcenter, however in subsequent environment creations this error did not occurred anymore.
The catalog item is based on this resource group: https://github.com/Azure/aks-baseline-automation/tree/main/IaC/bicep/rg-hub

I have seen this happen a few times now and similar experience -  devportal reports failure but deployment is actually successful. A redeploy fixes it and shows successful in devportal without any changes having been made

What was the specific failure that your environment reported with? If it was a timeout error, it is definitely possible that the reported failure was due to the environment hitting the deployment runtime but the resources themselves continued. Details on what the limits for ADE deployments are can be found here https://azure.microsoft.com/en-us/pricing/details/deployment-environments/#:~:text=Azure Deployment Environments has the following limits%3A Runtime,1 GB Enterprise might qualify for additional limits. and the limits can be raised via a request following the process described in the link

I cant remember exactly , but looking at those limits I can see how a deployment can easily go over the 10 min deployment run time limit  for the things I was testing with. I was deploying Vnet, App Service Plan, Web Apps along with managed service identities. I was thinking it could very much be that the web apps get deployed as resources, but what ever checks are performed to confirm success rely on them being fully up, and they seem to take a little while to spin up fully post deployment. Redeployment without changes to the bicep will of course be faster and then succeed.
I am glad you posted those limits though, as I was not aware and 200 mins per region, per sub  for runtime deployments does not seem like  a lot - at least not with how I envisaged using it (allowing devs  lots of spin up test and destroy) and I will need to rethink things as  this , along with several bugs Im finding, mean I dont think I can go ahead and use this currently.

Hi @philricelf,
As mentioned, it is a really straightforward process to extend those limits through the official request process if they seem too low for your needs. Each request is personally reviewed by the ADE team and providing appropriate business justifications for the increases you request can help us work with you to get what you need. These limits also apply at a per-region per-subscription level, so if your use case is more region spread, these limits will feel higher.
Can you elaborate on what bugs you are currently facing? We'd be happy to take a look and see if we can get you unblocked! you can also reach out to<EMAIL_ADDRESS>if there are any details related to your bugs that you'd rather not put on a GitHub issue.

@ericaguthan  - sorry for the delay in replying - been a bit full on with some deadlines. I have had to shelve the idea of using ADEs for now for the use case I had due to the issues I was encountering, some of which I have logged  or commented like this one, but I will try to list at a high level what I can remember I encountered:
Deployment/deletion failures - as per issue #59 that I logged and also as mentioned above . I think for this one , the documentation should be made a bit cleared about the limits, as I can see that can effect   planning of how you might approach things. For example, I was using templates that deployed complete environments including vnet, subnets, managed identities, storage accounts, container apps environments and container apps, private endpoints etc etc - obviously these take longer when multiple resources and certain resource types add further delays to spin up. After learning about the job time limits I can see how it may need to be approached / used as a solution to deploy info already existing base infrastructure (so vnet, identities etc already in place in preconfigured 'dev/test/ networks'  and just using the ADE to spin up VMs , Functions etc . I was thinking of potential use cases that would allow certain engineers to use ADE to spin up ready made test platforms, potentially with quite complex configs , so they can have 'lab's to try things in, but these time limits seem to handicap what is possible a bit.
Deleted Global catalog still showing for end users after being deleted. This happened when I did the following:

Initially I deployed a catalog at dev center level
I realised that this was automatically available in all projects so I deployed a catalog at project level (same source for this but had to name the catalog with a different name) and deleted the global one
Tried deploying resources from devportal and could see both catalogs, which showed both sets of definitions - confusing for enduser
Tried various things like deleting the project level one (so no catalogs) and redeploying to see if caused by deploying from same source at same time, but no change. As there was no longer any catalogs at global level, I tried deploying the default samples one to see if that forced an update but the old 'ghost' one still remained also

Other comments/suggestions:
Would be useful to have a more detailed catalog interface for the end users , as when you launch an environment you are presented with limited info. Making catlog navigation front and center , and providing a launch button from there which steps into the launch details would be a better experience.
I could not see any way that an admin can limit the length of time that an environment can be running in the manifest. E.g Users can set an expiry when launching and admins can add/edit this later, but I would want to be able to configure environments to have 'max lifetime' = 7 days  for example , only overidable by an admin and nice if there was a 'request extention' button for the end user
I couldnt see documentation that showed how to use dynamic values in a manifest . For example having  parameter1 requiring input and parameter2 being displaying different options (or not displayed at all) based on the chosen value of parameter1 . That could be a powerful feature. There may be more advanced configurations available that what I found in the documentation of course, but if so it would be good to have this more readily available also.
Thanks
Phil


Is the background color of diff as expected?

Reproduction steps：

open vscode.dev
new a file
Copy the following to show the effect of the diff code

<<<<<<<
11
=======
aa
>>>>>>>

Version: 1.83.1
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: vscode.dev

Looks fine at first glance. What would you expect to be different?

Looks fine at first glance. What would you expect to be different?

When there is no diff contrast effect, I see some small details on the scroll bar: for example, the approximate position of the cursor focus in the editor and the approximate range of the code error. It didn't make me feel weird, it felt great.
However, when the background color of the diff code is revealed, I have a kind of css that is not well written, causing the module below to exceed the boundary.
In fact, if the diff background color was not displayed on the scroll bar, I would not have noticed that the minimap turned out to be floating above the editor. I used to think the editor and minimap were similar to a grid layout.

Hey @chrmarti, this issue might need further attention.
@yiliang114, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


FIX: Incorect boschloo pvalue

Reference issue
should closes gh-15345
What does this implement/fix?
boschloo_exact had incorect pvalue (See #15345).
Clip the result of the two-sided case between 0 and 1.
It may happen in some edges cases that both pvalues
from less and greater alternatives have a value > .5 leading to a two-sided pvalue > 1

Thanks for submitting this. I worked on fisher_exact recently, so this is fresh in my mind: are there different conventions for calculating a two-sided p-value for this test? If so, what is done here should probably be documented. I can merge this as-is if you want that in a second PR, but it is pretty closely related.
(For fisher_exact, the two-sided p-value is the probability of observing, under the null hypothesis, a table with probability mass less than or equal to the probability mass of the observed table. Since the null distribution of the test statistic is not symmetric, this is not the same as twice the smaller of the one-sided p-values.)

Please consider V0lantis/scipy#7 before this is merged.

Please consider V0lantis#7 before this is merged.

My apologies @mdhaber for this late answer. I used the definition defined by @jb-leger in this comment. Should I add more documentation to explain how we compute the two-sided test?
Please know that before, I was using the fisher way of computing the two-sided test and I had slight differences with the expected and computed result from the R algorithm

@V0lantis no need to add more documentation yourself. Please see the PR V0lantis/scipy#7 I submitted against your fork. If you merge it, it will show up here.

@V0lantis no need to add more documentation yourself. Please see the PR V0lantis#7 I submitted against your fork. If you merge it, it will show up here.

Thank you so much @mdhaber, very nice help !


Remove unnecessary call to __requireComputeDerivative

When SPIR-V uses operators whose name has a keyword, "Implicit", they require calling a function "__requireComputeDerivative()".
When it uses "Explicit", the function doesn't need to be called.

Is our HLSL intrinsic definitions correct? SampleLevel for example shouldn't need this either, right?

SampleLevel (including other explicit LOD functions) and gradient functions do not need __requireComputeDerivative.

That's a good catch.
I didn't think about hlsl.meta.slang.
I spotted a few functions that uses Implicit but not calling __requireComputeDerivative().
I am pushing the new change for a review.


All of the preview is same

Expected behavior
with different mail and the preview should not same.
Actual behavior
all of previews is same,but actually they are different.
Steps to reproduce

Environment
K-9 Mail version:?
Android version:6.0.1
Account type (IMAP, POP3, WebDAV/Exchange):IMAP

The preview is extracted from the text/plain part while most of the time the text/html part is displayed when the message is opened. If your emails all contain some placeholder text/plain part the preview will be the same.
But with the little information in your report there's no way to tell what's actually going on. Please attach a screenshot and find out what K-9 Mail version you're running. See https://github.com/k9mail/k-9/wiki/GetVersionNumber

I know they are from the text/html part. when I open one of the messages and i found the message content is right ,back to mail list,the content is still wrong.
With debug mode,I see the method which called appendMessages return wrong result.I mean the preview and the details of message is not matching.

I don't understand your report. Can you please describe in more detail what you believe is going wrong.

K9 version:4.409
Android version:5.1.1


handle ssl encryption in route

I'm currently deploying to heroku and it appears that I get this error:

Mixed Content: The page at 'https://onsortirapeutetre.herokuapp.com/' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://onsortirapeutetre.herokuapp.com/api/city'. This request has been blocked; the content must be served over HTTPS.

Does it handle ssl encryption? Because when i do
route('api....').url()
this is the result :
http://onsortirapeutetre.herokuapp.com/api/excursion

I looked into this is noticed that the method prepareDomain() uses the url method of laravel, which as described in the documentation creates a url designed for non ssl encryption in contrary to the secure_url() method.
I think that the environment variable APP_URL could be used and parsed to create the domain base variables.
private function prepareDomain()
    {
        $url = url('/');
        $parsedUrl = parse_url($url);
        $this->baseUrl = $url . '/';
        $this->baseProtocol = array_key_exists('scheme', $parsedUrl) ? $parsedUrl['scheme'] : 'http';
        $this->baseDomain = array_key_exists('host', $parsedUrl) ? $parsedUrl['host'] : '';
        $this->basePort = array_key_exists('port', $parsedUrl) ? $parsedUrl['port'] : 'false';
    }

This is what i think about :
Just add : $url = env('APP_URL', url('/'));
private function prepareDomain()
    {
        $url = env('APP_URL', url('/'));
        $parsedUrl = parse_url($url);
        $this->baseUrl = $url . '/';
        $this->baseProtocol = array_key_exists('scheme', $parsedUrl) ? $parsedUrl['scheme'] : 'http';
        $this->baseDomain = array_key_exists('host', $parsedUrl) ? $parsedUrl['host'] : '';
        $this->basePort = array_key_exists('port', $parsedUrl) ? $parsedUrl['port'] : 'false';
    }

What do you think of this @DanielCoulbourne  ?

Fixed by #111


Feature request: allow custom colorTitlebar based on severity

Hello,
Thanks for the awesome project -- we use it everyday to help us monitor our network.
We have this running on a large TV and we want an easy way to identify critical alerts from far away. The colorTitlebar feature is nice, but is limited to red (non-silenced) or green (silenced).
It would be great if I could pass in a custom mapping of severity to color for the titlebar (similar to how the label color config is done). When using this feature, you could force the alert count to have a black background with white text.
The yaml could maybe look something like this (just a sketch, feel free to change):
titlebar:
  color:
    silenced: "#18bc9c"
    custom:
      severity:
        - value: info
          color: "#87c4e0"
        - value: warning
          color: "#ffae42"
        - value: critical
          color: "#ff220c"

Thanks

Got some work done on this via #1559, should be ready in a few days

Great, thanks. When it's released I'll give it a quick test.

This is now merged and you can test it on the demo site

Awesome, this will help us out a lot. The UI is intuitive and the grid config is generic, but still easy enough to setup useful value sorting. Thanks for implementing it, I hope you find it useful too :)


Update Ruby to 3 in Gemfiles

Summary
Ruby 2 is end of support this month. Also, the Jammy builder does not support Ruby 2.
I therefore update the samples to Ruby 3 and tried the build run and run with the latest Jammy full builder.
Use Cases
As a Paketo user, I want to have up-to-date Ruby samples so that I can use them with the provided builders
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Partially related to #465

@paketo-buildpacks/content-maintainers can you merge this please? I don't have access to merge things in.


Refactoring for concurrency security

I appreciate your work on this, and I will consider the possibility of merging this. However, I need to investigate the cause of the map panic first. I should have a decision for you tomorrow.

There is currently an initialization issue that causes the text editor widget to not work, after this fix all demos and apps will run normally, it is located here

The Map problem is completely gone, and the next step is to get more unit tests to work

I am going to try to figure out the underlying cause of several of these crashes and implement a more optimized solution. If that does not work, then I will consider merging your PR. I should be able to get back to you later today.

I am going to try to figure out the underlying cause of several of these crashes and implement a more optimized solution. If that does not work, then I will consider merging your PR. I should be able to get back to you later today.

OK, thanks

I am going to try to figure out the underlying cause of several of these crashes and implement a more optimized solution. If that does not work, then I will consider merging your PR. I should be able to get back to you later today.

Can you fix the vulkan error again, I forgot where you fixed it last time, the latest commit recurred, or async minimized or the example in goosi minimized triggers panic, thanks

I did batch code cleaning with goland, there are too many godoc and the like, plus I can't understand the comments 100% because I don't speak good English, which requires you to optimize. TI did batch code cleaning with goland, there are too many godoc and the like, plus I can't understand the comments 100% because I don't speak good English, which requires you to optimize. The rest of the redundant type conversions and so on have been changed in batches, and now the issue tab on goland is much cleaner. he rest of the redundant type conversions and so on have been changed in batches, and now the issue tab on goland is much cleaner. I remember there was a proposal to push the repository to the go curated list, so this cleanup was necessary, in addition to that, it needed to go through all the unit tests and github deployment tests, and finally it might be necessary to deal with a lot of spell checking and interface signatures or struct field renaming, in general, if the names are not shorthanded, you can recognize the function function at a glance without looking at the comments, but naming them requires re-running the core gen command, which I am not very familiar with, and there is no further optimizationI remember there was a proposal to push the repository to the go curated list, so this cleanup was necessary, in addition to that, it needed to go through all the unit tests and github deployment tests, and finally it might be necessary to deal with a lot of spell checking and interface signatures or struct field renaming, in general, if the names are not shorthanded, you can recognize the function function at a glance without looking at the comments, but naming them requires re-running the core gen command, which I am not very familiar with, and there is no further optimization.

I used goland for batch code cleanup, there are too many godoc and the like, plus I don't speak English well, I can't understand the comments 100%, which requires you to optimize. The rest of the redundant type conversions and so on have been changed in batches, and now the issue tab on goland is much cleaner. I remember there was a proposal to push the repository to the go curated list, so this cleanup was necessary, in addition to that, it needed to go through all the unit tests and github deployment tests, and finally it might be necessary to deal with a lot of spell checking and interface signatures or struct field renaming, in general, if the name is not shorthand, you can recognize the function function at a glance without looking at the comments, but naming them requires re-running the core gen command, which I am not very familiar with, and there is no further optimization.

We are currently working on a major redesign of async updating that should fix the vulkan, window closing, and concurrent map access issues. I agree that it makes sense to have clear function and field names, and I am willing to consider renaming some of those things. You do not need to worry about updating the generated code, but if you want to, all you have to do is run go generate in any directory where you change the names of widget types and their fields. I will consider your changes to documentation and struct literal initialization, but I do not think that it is completely necessary to rewrite all of our documentation comments. As you can see, we already score A+ on the Go Report Card, and we will have addressed all of the complaints from Awesome Go by the time we do our v1 release.

We completed an extensive redesign of our asynchronous updating process, and all of the issues that you had with the nil panics and the map concurrency should be fixed now. Can you try examples/async in the latest version of the main branch and tell me if you have any issues?

We completed an extensive redesign of our asynchronous updating process, and all of the issues that you had with the nil panics and the map concurrency should be fixed now. Can you try examples/async in the latest version of the main branch and tell me if you have any issues?

Sorry I fell asleep, I played with the code for too long yesterday and I don't know when I fell asleep, wait for me for 5 minutes and I'll go buy a cigarette and come back and continue testing your commit

We completed an extensive redesign of our asynchronous updating process, and all of the issues that you had with the nil panics and the map concurrency should be fixed now. Can you try examples/async in the latest version of the main branch and tell me if you have any issues?

vulkan error
Details

<EMAIL_ADDRESS>#gosetup
GOPATH=C:\Users\Admin\go #gosetup
<EMAIL_ADDRESS>build -o C:\Users\Admin\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand___go_build_cogentcore_org_core_examples_async.exe cogentcore.org/core/examples/async #gosetup
C:\Users\Admin\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand___go_build_cogentcore_org_core_examples_async.exe
2024/02/17 18:16:37 panic: vulkan error: vulkan error: out of host memory (-1)
2024/02/17 18:16:37
2024/02/17 18:16:37 ----- START OF STACK TRACE: -----
2024/02/17 18:16:37 goroutine 8 [running]:
runtime/debug.Stack()
C:/Users/Admin/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.windows-amd64/src/runtime/debug/stack.go:24 +0x5e
cogentcore.org/core/goosi.HandleRecoverBase({0x7ff6f2d0daa0, 0xc001563c50})
C:/Users/Admin/Desktop/core-main/goosi/recover.go:49 +0x4b
cogentcore.org/core/gi.HandleRecover({0x7ff6f2d0daa0, 0xc001563c50})
C:/Users/Admin/Desktop/core-main/gi/recover.go:32 +0x4b
cogentcore.org/core/gi.(*RenderWin).EventLoop.func1()
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:546 +0x24
panic({0x7ff6f2d0daa0?, 0xc001563c50?})
C:/Users/Admin/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.windows-amd64/src/runtime/panic.go:770 +0x132
cogentcore.org/core/vgpu.IfPanic(...)
C:/Users/Admin/Desktop/core-main/vgpu/errors.go:39
cogentcore.org/core/vgpu.(*Surface).ConfigSwapchain(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:254 +0x906
cogentcore.org/core/vgpu.(*Surface).ReConfigSwapchain(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:302 +0x25
cogentcore.org/core/vgpu.(*Surface).AcquireNextImage(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:347 +0x105
cogentcore.org/core/vgpu/vdraw.(*Drawer).StartDraw(0xc000310488, 0x0)
C:/Users/Admin/Desktop/core-main/vgpu/vdraw/draw.go:234 +0xa7
cogentcore.org/core/gi.(*RenderWin).DrawScenes(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:984 +0x262
cogentcore.org/core/gi.(*RenderWin).RenderWindow(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:948 +0x3b9
cogentcore.org/core/gi.(*RenderWin).HandleWindowEvents(0xc00022b0e0, {0x7ff6f3258f40, 0xc00047eb60})
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:610 +0x5ac
cogentcore.org/core/gi.(*RenderWin).HandleEvent(0xc00022b0e0, {0x7ff6f3258f40, 0xc00047eb60})
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:594 +0x11c
cogentcore.org/core/gi.(*RenderWin).EventLoop(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:560 +0x125
created by cogentcore.org/core/gi.(*RenderWin).GoStartEventLoop in goroutine 1
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:514 +0xa5
2024/02/17 18:16:37 ----- END OF STACK TRACE -----
2024/02/17 18:16:37 SAVED CRASH LOG TO C:\Users\Admin\AppData\Roaming\Async Updating\crash-logs\crash_2024-02-17_18-16-37
panic: vulkan error: vulkan error: out of host memory (-1) [recovered]
panic: vulkan error: vulkan error: out of host memory (-1)
goroutine 8 [running]:
cogentcore.org/core/gi.HandleRecover({0x7ff6f2d0daa0, 0xc001563c50})
C:/Users/Admin/Desktop/core-main/gi/recover.go:69 +0x23b
cogentcore.org/core/gi.(*RenderWin).EventLoop.func1()
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:546 +0x24
panic({0x7ff6f2d0daa0?, 0xc001563c50?})
C:/Users/Admin/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.windows-amd64/src/runtime/panic.go:770 +0x132
cogentcore.org/core/vgpu.IfPanic(...)
C:/Users/Admin/Desktop/core-main/vgpu/errors.go:39
cogentcore.org/core/vgpu.(*Surface).ConfigSwapchain(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:254 +0x906
cogentcore.org/core/vgpu.(*Surface).ReConfigSwapchain(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:302 +0x25
cogentcore.org/core/vgpu.(*Surface).AcquireNextImage(0xc0002440b0)
C:/Users/Admin/Desktop/core-main/vgpu/surface.go:347 +0x105
cogentcore.org/core/vgpu/vdraw.(*Drawer).StartDraw(0xc000310488, 0x0)
C:/Users/Admin/Desktop/core-main/vgpu/vdraw/draw.go:234 +0xa7
cogentcore.org/core/gi.(*RenderWin).DrawScenes(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:984 +0x262
cogentcore.org/core/gi.(*RenderWin).RenderWindow(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:948 +0x3b9
cogentcore.org/core/gi.(*RenderWin).HandleWindowEvents(0xc00022b0e0, {0x7ff6f3258f40, 0xc00047eb60})
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:610 +0x5ac
cogentcore.org/core/gi.(*RenderWin).HandleEvent(0xc00022b0e0, {0x7ff6f3258f40, 0xc00047eb60})
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:594 +0x11c
cogentcore.org/core/gi.(*RenderWin).EventLoop(0xc00022b0e0)
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:560 +0x125
created by cogentcore.org/core/gi.(*RenderWin).GoStartEventLoop in goroutine 1
C:/Users/Admin/Desktop/core-main/gi/renderwin.go:514 +0xa5
进程 已完成，退出代码为 2

When does this happen? When you close the app? Are you running the latest version of the async example?

I just pushed a change that should fix the Vulkan issue and other crashes.

I just pushed a change that should fix the Vulkan issue and other crashes.

Change this to wait for a second, https://github.com/cogentcore/core/blob/main/examples%2Fasync%2Fasync.go#L40-L40, and then after adding more than 10 lines, you will find that the operation of the selected line is obviously delayed, which means that the rendering of the line selection cannot keep up with the speed of the mouse machine, and this problem has been appearing for a long time

When does this happen? When you close the app? Are you running the latest version of the async example?

yes，latest

I just pushed a change that should fix the Vulkan issue and other crashes.

i will try

I just pushed a change that should fix the Vulkan issue and other crashes.

Still panic, need debug on my machine?

Yes, I will debug it on your machine.

I am ready to debug it on your machine whenever you are.

I am ready to debug it on your machine whenever you are.

1957149762


Overhaul control states and colors

Updating controls and their various states.
Proposed changes

Using the palette system for control and context colors - removing the use of darken/lighten as much as possible.
Decoupling hover/focus, disabled, and active states for buttons.
Adding a new high-visibility focus ring in place of the default browser outline.  This will also potentially be optional.

Other changes

Merge .custom-select to align with .form-control - also removes a bunch of settings vars

Ok, so this PR is turning into more of a catch-all for a ton of changes that I am currently working through.  It might end up just getting merged so I can get back to smaller PRs.

While I am sad to see the hover/focus states go for active and inactive states, the consolidation and decoupling -- from the inactive, inactive hover+focus, active, active hover+focus, disabled, disabled hover+focus states to inactive, hover, focus, active, disabled -- significantly reduces the generated CSS by ~10%, which is huge.

Added the focus ring that is enabled by default.  It is optional, but I think it bridges the gap between accessibility and usability rather well.  The focus ring has been extended to hit a large portion of the components (and some default HTML elements), but there might be places where it does not trigger for non-Figuration classed elements.

Reworked the disabled states a bit get them aligned to use a more consistent color scheme across different components.

However, disabled .nav-links now use opacity instead of a forced color.  Hopefully this will allow better inheriting the visual style when customized.

Consolidated transitions so they can all be found in the _settings.scss file.

More upcoming changes:

Finish removing darken()
Make sure to use palette system in most places

Creating a new v3-dev branch and moving this PR over.
Since so many things are changing again (sorry for the rapid pace) it would probably be better to look at a major version bump again.

Pulling this in so that development can get back to smaller PRs.


Cannot add custom attributes to a flambe module

Describe the bug
If you try to follow this example, you get an error Unexpected key(s) in state_dict. This is b/c of a bug in this if clause: https://github.com/asappresearch/flambe/blob/aad135b6177713b786fdf07f08a4165ef0c1dfd4/flambe/compile/component.py#L1264-L1269
The else clause is never hit if module is flambe.nn.Module b/c it inherits from torch.nn.Module, and therefore any custom attribute is treated as an unexpected key.
To Reproduce
Follow the example in the doc.
Expected behavior
The custom attribute should be loaded correctly.
Screenshots
If applicable, add screenshots to help explain your problem.
Software Versions (please complete the following information):

OS: macOS 10.14
Python Version: 3.6
PyTorch Version: 1.1
Flambé Version: 0.4.6

Additional context
Add any other context about the problem here.

Hey @peterAsapp nice catch, you are right that this error shouldn't be thrown, but the problem is actually misuse of the load method in the trainer. I'll try to explain why:

The code you point out is actually correct; _load_from_state_dict in Pytorch will still call our hook. Notice in Component.__init__ how we register the hook that appears in the else case. The hook mechanism is new in PyTorch 1.1+ I believe, and you can learn more by diving into the source code for torch.nn.Module if you're curious
On the other hand, because our saving mechanism uses these hooks to add extra things to the state_dict that pytorch doesn't expect, one should basically always use strict=False when using either our state or PyTorch's native state dict methods. (see https://flambe.ai/en/v0.4.6/autoapi/flambe/compile/component/index.html#flambe.compile.component.Component.load_state)
The error you see here is actually caused by Trainer not using strict=False when loading the weights of the best model. I'll submit a PR to fix this shortly.


[iOS] check app availability by URL scheme

fixed https://github.com/doefler/react-native-social-share/issues/60

To avoid "not_available" issue on iOS 11, check app availability by url scheme instead of using SLComposeViewController isAvailableForServiceType method.
Added how to setup to README .

This is an easy implementation. For more functions, Facebook SDK and Twitter SDK should be integrated (but it should need more setup).

Looks great, thanks for your contribution 🙌

I guess it would be great with this image in the README file as well, what do you think?

@doefler The image may be a help, but someone may think it's redundant. How about adding pages to wiki?
https://github.com/doefler/react-native-social-share/wiki

Hey @ariiyu
I see what you mean.
What pages do you think we should add to the wiki?

@doefler I thought adding a page of detailed version of  "Getting Started".
Especially these procedures will be easier to understand with screenshots of Xcode.

In XCode, in the project navigator right click Libraries ➜ Add Files to [your project's name]
Go to node_modules ➜ react-native-social-share➜ iOS and add KDSocialShare.h and KDSocialShare.m
Go to your project's Build Phases ➜ Link Binary With Libraries phase
Add Social.framework to ➜ Link Binary With Libraries build phase of your project (click the '+' and search for 'social').
Add 'LSApplicationQueriesSchemes' key (Type: Array) with items (Type: String) 'fb' and 'twitter' to Info.plist of your project

https://github.com/doefler/react-native-social-share#getting-started
I think it's not always necessary, though it can be helpful to developers who are not used to Xcode operation.

For anyone who tries to install to update to the latest version of this plugin because of this update: Please note that additions to Info.Plist. These were note needed with the old version of this plugin but seem to be necessary now.

@ariiyu @angusmccloud
I am starting to think maybe the README could use an overall rewrite.
Making the structure more easy to read and then provide screenshots where necessary or maybe even a video screencast?

What do you think?
@angusmccloud
Thank you for sharing your observations, it is so long time I built an app using the repo, so it is really good for me to get some feedback on what works and what doesn't. These learnings could be implemented in an improved README.

@angusmccloud
Awesome app idea 😄
Usually, contributors have made pull requests and I have merged it in, does that work for you?
Right no now the table in the README makes it seem like all cases are possible, but maybe it should be explained more as a decision tree like you described it. Like "if you want to share a link do like this, if you want to share a text do that" and then some kind of graphic visualization 😃

Sorry about that @doefler - done!
I'm not a professional developer, never contributed to someone else's repo before (even if this is just ReadMe) :)

Hey @angusmccloud
No worries, I also sometimes feels that there are many things related to Github and coding collaboration that is a bit of a mystery 😆
Thank you for the README pull request you made (https://github.com/doefler/react-native-social-share/pull/64 ).
Think we misunderstood each other.
I am thinking of a complete rewrite of the README (you don't have to do it), with the purpose of avoiding confusion. Adding extra notes, in the bottom, will make it more confusing.

In that case, ignore my ReadMe changes and we'll suffice with my iOS 11 usage notes in this thread for now.  Agreed that I don't want to undertake a full re-write, but let me know if there's anything I can do to help.

Thank you for your understanding. I apologize I didn't make it clear enough from the beginning. Either way, your input has been valuable for me in relation to a future rewrite.
Would be happy to add your app to the "Who is using it" list btw. Do you want me to do that?
Thank you for offering to help 😄

Would also like to make a section featuring developers like you who have contributed as well as a improve the section with what people made with the repo.

@doefler
I think it's a good idea. I'm glad that names of other contributors and me are in the section.


CPP/taskcpp/Pairofroses.cpp

Do you have a Girlfriend?😉...If yes then this question is for you...If no then also try it😂...Your want to surprise your girlfriend and how will you do that just open the task😏
NOTE:- Screenshot of the code and output is required

i don't have a girlfriend😂 so a i can get some feels working on this issue 😂 . Please assign this to me

noicee @akash-1107


CryptographyClient: some progress

Here I'm trying to expand into encrypt and decrypt to work both with the
remote service and the local NodeJS API. Not only that, but I'm also
trying to make it work as part of our build bundle.
I was successful to call encrypt and decrypt with the live services,
but once I added the code related to Node crypto, I started finding
problems. I was not successful to build it with the local node
implementation (so I also wasn't able to finish testing it). The last
error I'm getting is that apparently "crypto.constants" does not exist
in @types/node
I had this error in my local tests. I was able to fix it by upgrading
@types/node to ^12.6.1. We're currenlty using 8.0.0. Would it be ok to
upgrade this package?

Closing on favor of: https://github.com/sadasant/azure-sdk-for-js/pull/3


MAINT: collection of small fixes to test suite

This fixes several 32-bit-specific problems, as well as the current test errors with numpy 1.10.1 on TravisCI.

All green now, yay! Thank Ralf, merging.


Add min and value value validation

Add min and value value validation.

This was an idea that has been superseded by Issue#201


Add support for Valhalla style polyline

In the support for polylines added in https://github.com/mapbox/geojson.io/issues/553 it doesn't seem to support Valhalla style 6 decimal precision roads (Google's default implementation supports 5 only). Add an option that defaults to 5, but allows 6.

Example input:
kqe`gAjdmthFpCm@fh@sFzFm@FxCLhBFzAFvCvH{@zF_@hCM|J}@|DMbAOfS}@V?jFMjF?nD?|EOnINdJL|IN~I\\vH^zQjAtI\\~CNxBLtF?bF?bF?lEMvD?xGm@t@}@l@{ATyAFkAOuEUgNGyCjnByL`B?hpAoIh\\iBvD]`RmAf`B{JMaI{AgaA{AwaAaBgbA{AwaAcBgbA{AwaAyAgbAcBwaA{AwaAaBgbA{AwaA{AebA]oTOcFMqHGcF_@oTyAwaAcBebA{AgbAyAwaAcBwaA{AgbAaBwaA{AgbA{AwaAcBgbAyAwaAcBwaAe@_^u@gc@yAgbAcBwaAm@k`@m@k`@aBgaAGcGsAsz@{AwaAcBgbAaBaeAOoIsAsz@{AebAaBwaA{AyaA{AebAaBwaA{AgbAcBwaAzsBcG`nBcGhpAuD|EOjF?tEN|DLvDl@tDl@l_@bGdEl@~D\\lDNdEL~DMdE_@|EkAdEkAtEiB|DkBvDyB|DyBnDgC~CiCfDwCvCyCvCgDhCgDnCsEpCgEhCeEnCuDpCgDnCgDvCgDhCiC~CgCfDyC~CwC`XgYrAiBl@m@bAkAzEuExHaHjFuDjFiCfEiBd@Ofh@mUxB{@tDkBjGuDlDwC|@m@lYc[`SaS~MgN`RsQrAyArAkAtEuEhBkBrByA`C}@hB]zA]pB?hBLbB\\zA^`Bz@jBzA`ChBbKzKhBjBzBfCxAkAhCgCjK}JdA{AbAkAl@iB\\yBVgDLwD?yBs@kLDkUl@mJlEse@xByWdAmJbAaHt@qGz@sF|@cGlJya@nHse@d@iC|@wCz@iBvDaIjGaRnCaHpB_It@sFd@cGNcFDsFFiv@|@cRFsFTuD\\gD^yBd@iBlD}J{@gDm@yBoDuOoHq\\qCuPyBcPcAyMqBm^cBuPyBsPeJ}h@mEq\\uJyl@aCeOqBeOkBeP{Aed@?gDFwDNuDd@wDl@uEz@sErAqH^iC\\sFNyB?yBOyBcAoI_@uDm@eEcAwDkAwCqBwDkBwCoCwCgNgOuZuY{UkV_DuDqCwDoCeE_DcGqCcGiBaGkBsGqAqGmAqHs@oHe@qHOoHGqHUqoA?qq@?{_@?gEGsEmEuwBO_IUcGeFcwBMqGWoIcFuvBOqHMcGeFqxBMaHvCO`f@yBvDMnDOre@yBfDOOsEcFcyBWaHMqGuFe`CMaHeE_gB?aR?iLGeFgDm~@O_Ie@a\\Go]kA}|BUce@O}IMsFWiMU{`@e@yk@_@{t@GyC?gDe@qp@EeOGcG?eEeA}}AUwa@U}_@OwXWo]MwXW_^EsFD_TNuEOeZMsFWqGyAqHsBoH{P}s@oCkLiC{Ku@sFwCeZiHyu@}O_{Ae@sG]sF?m@NeOl@}TTePcAkKOwDcAsd@{Asp@sF{|BwCsnAkBku@MaG}@__@u@a\\s@q\\kAce@ToJNkK_@sP]}JeEm}@]sFm@yM]uOOyLTa|@EeE?cGGo]GmUGaGcA{j@wDeFMqGsA}i@xjAcFjUkAd_@{Ax\\iB|d@yBtI}@dU{@lOm@tEObAgDl@{AdAwCr@iBl@{ApBuErQm_@Tm@rGwMfD{AjFkLt|A}dDjk@i`AdTk`@jV_h@pBuEjBuEd|A}cDdAyB

With expected output:

https://gist.githubusercontent.com/nvkelso/8a066359dbe7e773926fe01c44c793d4/raw/d32bbf3221a8d8ef47cf22de706768a92ed645d9/map.geojson

Is valhalla sticking with 6? We did the same with OSRM, but ended up pretty much regretting it and defaulting to 5 in newer endpoints.

The precision=5 assumption was based into a few parsers, so we had to implement there, and even then there was (and still is) a bunch of support load from users who don't read the docs or rightfully assume that polylines are just polylines.

"always read the docs" ;)
On Thu, Feb 23, 2017 at 3:00 PM, Tom MacWright<EMAIL_ADDRESS>wrote:

The precision=5 assumption was based into a few parsers, so we had to
implement there, and even then there was (and still is) a bunch of support
load from users who don't read the docs or rightfully assume that polylines
are just polylines.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mapbox/geojson.io/issues/555#issuecomment-282149797,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO6dZjnlrxU5lfHU9LyaI3m9RXTQoks5rfg9ygaJpZM4MKmhD
.


Octopus - Modify BulkVerifyVolumes API to make use of cached values

AreDisksAttached function has nodename as parameter.
Using cach, locate the appropriate VM object for the operation.

Abrar can you take this up?


SEC200-VPC change Flow Logs Log Group to a dynamically created name

Issue #, if available:
Description of changes:

This avoids the problem where a stack create - delete - create will fail because the VPC Flow Logs with that name already exists

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks @setheliot


Enable enhanced customization of server options

This pull request aims to enhance the user's ability to customize the options passed to broccoli.server.serve() in a couple different ways.
First, users can customize the http response headers created within lib/middleware.js by including a headers property in the main options object passed in broccoli.server.serve(builder, options).  For example, the following options would enable Broccoli to include a CORS header when serving files on http://localhost:4200:
var options = {
  headers: {
    'Access-Control-Allow-Origin': '*'
  }
};

broccoli.server.serve(builder, options);

To allow advanced options like these to be easier configure when using Broccoli CLI, this pull request also expands on lib/cli.js by allowing users to define an optional .broccoli JSON-formatted file within the root directory of their projects.  Any configurations defined within that .broccoli file will be pulled whenever calling broccoli serve.  For example, the following .broccoli file would cause Broccoli to serve on port 12345 with a CORS header:
//  `.broccoli` file saved in project root
{
  "headers": {
    "Access-Control-Allow-Origin": "*"
  },
  "port": 12345
}

This pull request includes 5 new passing tests in test/options_test.js.  To help clean up the console output when running Mocha, there is new option defined called disableLogging which (when set to true) will cause lib/server.js to not call console.log() while the Mocha tests are running.

@joliss: Any feedback?

@joliss @jakedetels When do you merge this feature? I need this feature for adding custom headers to server response. Thank you

@jakedetels / @oksuz sorry for the long delay in response. I believe in broad-strokes I agree with this approach.
The code-base has changed some, if you are still using broccoli and would like to rebase and update the code. I would love to revisit this, and help get it in.

@stefanpenner: I'll aim to get this PR updated by the end of the month (12/31/2017).  If needed sooner, let me  know.

Friendly ping 🏂

Faced the issue today, this PR would be very helpful 😊

I like idea about additional customization, but I think having multiple ways to do it - not an optimal direction.
We could have .broccoli.js (no need to escape comments, able to have dynamic logic in it for different purposes - serve, build-dev, build-prod) file, with all needed things, including middleware, but it's requires more design work here.


Removed fixed size for screenshots

Not sure why I did that. Doesn't break on mobile now.

You'll need to pull the current master branch to get up to date in order for me to merge the PR.


[Added] Custom fonts on active type

It is merged in https://github.com/optonaut/ActiveLabel.swift/pull/193


Fix #5646, ignore .swp files in config folder

fixes #5646

It would be nice if this change was merged in after #5657

I fixed this in https://github.com/gohugoio/hugo/commit/3244cb3b31f8f8c39d9dfa82bc01fb2d6db59257 -- this PR looks correct, but I had to get it ready to ship in the near future patch release, with tests and all.
Thanks!


GEODE-7863: Reduce ServerCQImpl Contention

Use ConcurrentMap and CopyOnWriteHashSet instead of locking the
entire map on every operation.
Reduced time we hold the lock on the ServerCQImpl instance while
executing the query.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[X] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[X] Is your initial contribution a single, squashed commit?

[X] Does gradlew build run cleanly?

[X] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@jhuynh1 : I think you're right... thanks for raising these concerns.
Let me try a different approach, will open a new PR with the changes once I'm done.


Fix default slider partial and home index Deface override.

Fixes #12 #13 #14 #15
I've committed to master but it needs backporting to 3.0 branch as well. The branches look the same though so shouldn't be any conflicts.

Yay, thank you for the fast merge!
Any plans to update 3.0 branch?

There you go!

Perfect! Thanks very much.


Add --renderToDisk scripts

Summary
Brief explanation of the feature.
--renderToDisk: serve all files from disk (default is from memory)
See also:

hugo-starters/default-template
hugo-starters/bootstrap-template
Hugo Tips: Avoid Crashes With '--renderToDisk'

Basic example
Include a basic example or links here.
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome?

Render to Disk is now the default from Hugo 0.123.0.

Resource: hugo server

Now using hugo server --disableFastRender --noHTTPCache" with v2.3.0


Use units and UDUNITS conversions on formulation response (runoff)

Currently, the logic in Layer.hpp update_models() is hard-coded to assume that the formulation's main/response variable is in units of m/s.
Current behavior
This is problematic in at least two fashions:

The dimensions are unchecked to be length / time
We don't apply unit conversions like we do for other variables, or use them for scaling

Expected behavior

Check that dimensions make sense for the quantity described. We've taken length / time as the convention for an equivalent precipitation rate, that we then scale by area, but that's not truly necessary. We could equally accept the formulation itself integrating over the time step it was asked to take, and some may quite sensibly do so, giving just length with no denominator. We could also accept a numerator with dimension length^3, letting the formulation account for the catchment area for which it's responsible
Use UDUNITS to convert from whatever units of acceptable dimension to the desired m^3/hr, with possible multiplication by the catchment area to get there.

Maybe Catchment_Formulation::get_response should be doing some of the checking or conversion, but we definitely shouldn’t be blindly multiplying by conversion factors in the engine's core update loop.


✨ [New Demo Request]: The Page Visibility API Demo

Please include the request by answering these questions.
What is the Example and Demo Topic?
Page Visibility API
Please explain why do you need it?
Let’s say that you want to check if the page is currently focused before executing something. The Page Visibility API has been designed for this purpose and provides events you can watch to know when a document becomes visible or hidden. This means that when the user minimizes the window or switches to another tab, an event will be sent.
Any Links, Reads?

Do you want to contribute to the source code for this example?
Yes
If you are picking up this request to implement, PLEASE READ THIS

HOW TO ADD A DEMO

@williamssam Are you able to get started?

Yes

Hi @atapas I just made a PR for this Issue, kindly check


No Idea how to use the new version of the mod, color wheel gone, replaced with paint buckets

The mod has changed yet the description of it remains the same. How do we use the paint mixer? How do we use anything on this mod? Please help.

yeah ever since the original dude retired we've gotten no updated recipes, guides on how to use blocks. nothing...
the paint mixer you just stick the two colors you wanna blend and use redstone to turn it on. it's not very intuitive. i wish there was a way to change this but at least as of the 1.19.2 version there's no config file anymore!! not ingame or in the files like oml....
the way they have it now, it's kinda not worth the download. literally can't see the blocks you can create EVEN IN CREATIVE! you have to individually mix each color.. there's no more color crafter block where you can just SEE it. The best work around I have is using the chisel and bits mod's clipboard to save the colors hough i have no idea what's the limit on how many blocks you can have on that.
bring back the option to have all the blocks generated already... please


Add extension function to turn OTel Attributes into a map of strings

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#902  👈
#897 : 1 other dependent PR (#867 )
#896
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite