Your authentication token has expired

Hello,
I get this error message when I try to use chatGPTBox (with all chatgpt API). I am well connected to chatgpt and (I opened the chatgpt openai window before using it). Everything was working correctly yesterday.
Erreur:
{"detail":{"message":"Your authentication token has expired. Please try signing in again.","type":"invalid_request_error","param":null,"code":"token_expired"}}
Merci and good job with this extension !

same issue here

Same here!

open https://chat.openai.com/api/auth/session to refresh your token

open https://chat.openai.com/api/auth/session to refresh your token, I will check this issue

I already did it yesterday. expires : "2023-05-18T09:46:05.756Z" / mfa : false
it does not change anything.

This is strange. Try to reinstall this extension to see if it can solve this problem.

open https://chat.openai.com/api/auth/session to refresh your token, I will check this issue

I did this, now it come back normal. issues resolved.

This is strange. Try to reinstall this extension to see if it can solve this problem.

I did it and it worked ! The issue is solved for me ! Tanks !

fixed in v2.2.8


Exception during index creation leads to missing schema in entityClassToSchema map which causes Query by Example to fail

Hello
Assuming having a simple document like this
@RequiredArgsConstructor(staticName = "of")
@NoArgsConstructor
@Data
@Document
public class Product {

    @Id
    @Indexed
    @NonNull
    private String sku;

    @Searchable
    @NonNull
    private String title;
}

When the application first starts the index will be created properly but on the next run you will see a warning message in the console.
WARN 27424 --- [           main] com.redis.om.spring.RediSearchIndexer    : Skipping index creation for com.example.ProductIdx because Index already exists
One would assume this is not an issue but it is when you want to run a Query by Example
Product template = new Product();
template.setTitle("abc");
Example<Product> example = Example.of(template, ExampleMatcher.matchingAll());
return repo.findAll(example);

In this example redis should search in the title field but instead follwing command gets executed
com.example.ProductIdx" "*" "LIMIT" "0" "10000" "DIALECT" "1"

This is because the call to entityClassToSchema.put(cl, schema); in com.redis.om.spring.RediSearchIndexer#createIndexFor gets ommited because of the exception during index creation.
In com.redis.om.spring.search.stream.ExampleToNodeConverter#processExample the schema will be queried from the indexer. Since it does not get added because of the exception nothing gets processed.
Ist this a bug or am i doing something wrong here?
I am using version 0.8.7 of this library
Thank you for helpful input!

One workaround is this #366 but still seems a bug to me. I dont't want to drop the index any time my application starts up

This is a bigger issue that's being discussed here https://github.com/redis/redis-om-spring/issues/26


Add NetBSD support

This is the result of running the ioctl_list command on NetBSD 9.
cargo test passes (as in, the code compiles, I guess). Tested on evbarm (aarch64).

@bsiegert Thanks. To be clear, this is for aarch64? Do you know if the definitions are any different than for x86_64?

@bsiegert Thanks. To be clear, this is for aarch64? Do you know if the definitions are any different than for x86_64?

The definitions for x86_64 are exactly the same (I tried). I just happened to use an aarch64 machine to prepare the patch.
(Sorry for the delay.)

any update?


Option series type (Sonarr v4 bug Anime)

Description
Currently on V4 of sonarr if the option series type is in anime, the search is done episode by episode only, so no season pack which are however majority once the anime finished. So, most of the dated anime are not available in full...
Desired Behavior
It would be nice to be able to set the "series type" option to be used by default
Additional Context
No response
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

Added in feat: Add default seriesTypes for anime


MiniImagenet Integrity Check Failure

Hello, This seems like an error in my torchmeta setup, but wanted to get your perspective if otherwise. thanks in advance - VV
(dsai20) dg8965@mb-qs-pp-v100:~/GBML$ python3 main.py --alg=Reptile
using gpu: 0
Traceback (most recent call last):
File "main.py", line 225, in
main(args)
File "main.py", line 115, in main
target_transform=Categorical(num_classes=args.num_way)
File "/home/dg8965/.conda/envs/dsai20/lib/python3.6/site-packages/torchmeta/datasets/miniimagenet.py", line 89, in init
download=download)
File "/home/dg8965/.conda/envs/dsai20/lib/python3.6/site-packages/torchmeta/datasets/miniimagenet.py", line 127, in init
raise RuntimeError('MiniImagenet integrity check failed')
RuntimeError: MiniImagenet integrity check failed

This is very simple to solve. put all your files in data_path/miniimagenet/.
If you put a breakpoint there, you can find this solution by yourself.

If you put a breakpoint there, you can find this solution by yourself.

Put a breakpoint where? And then what do I check?

https://github.com/sungyubkim/GBML/blob/master/main.py#L115
just add
,download=True

https://github.com/sungyubkim/GBML/blob/master/main.py#L115
just add
,download=True

I do have download true...
import torch

import torchvision.transforms as transforms

from torchmeta.datasets.helpers import miniimagenet
from torchmeta.utils.data import BatchMetaDataLoader

from tqdm import tqdm

from pathlib import Path

meta_split = 'train'
data_path = Path('~/data/').expanduser()
dataset = miniimagenet(data_path, ways=5, shots=5, test_shots=15, meta_split=meta_split, download=True)
dataloader = BatchMetaDataLoader(dataset, batch_size=16, num_workers=4)
print(f'len normal = {len(dataloader)}')

num_batches = 10
with tqdm(dataloader, total=num_batches) as pbar:
    for batch_idx, batch in enumerate(pbar):
        train_inputs, train_targets = batch["train"]
        print(train_inputs.size())
        # print(batch_idx)
        if batch_idx >= num_batches:
            break

print('success\a')

hopefully this will solve it: https://stackoverflow.com/questions/64451179/how-does-one-resolve-the-miniimagenet-data-integrity-issue-with-torchmeta

I am going to try to send my local copies after deleting all the HPC copies.


PEP8 requirement

There are a lot of files and lines that do not adhere to PEP8 as required based on the documentation. When testing, most tests fail because of this.

Yeah, it looks like the recent additions were not properly formatted or checked against flake8. To help resolve these errors and get the tests working again, I am going to use ruff to help with the formatting and get the flake8 linting working again.
In v2, we'll re-tool to use ruff for formatting and linting.


Twitter summary automation

Automate posting the summary to Twitter.
Only manual trigger, no CRON job or any other condition.
Maybe use https://github.com/choldgraf/threader.

I think we can make a js script for it and run it through an action

Okay, go ahead.

I'm assuming you only want a link to the summary right?

No, we want to automate our summary threads.
Eg: https://twitter.com/OurTechComm/status/1497968093787672577

Taking over this, since it doesn't look like anybody is working on it.
/assign

Yeah, you can take this up.
Looking at this line I feel we have access
https://github.com/OurTechCommunity/catchup/blob/1bf1f596dc78b29812650e57fff22b90e5709f0c/.github/workflows/joining-tweet.yaml#L25

We are definitely have access to the Twitter API @sreekaransrinath, but I'm not sure which version it is. We definitely don't have elevated access though. Do we really require it?

@sreekaransrinath any updates on this?
Please let us know if you have any questions.

@sreekaransrinath any updates on this? Please let us know if you have any questions.

He is busy with KubeCon😅

@sreekaransrinath any updates on this? Please let us know if you have any questions.

He is busy with KubeCon😅

Ah.
Let me know if you have time, or I can assign it to someone else.

If someone requests then assign it... Else keep it as it is.

I won't be free till end of next week @KartikSoneji - if it's still open then, I'll get to it. Feel free to assign it to someone else if they're interested


Create brand bible

Including:

brand colors for website for tailwind
font
logos
social media needs ?

We are meeting with @Yoonie458 August 26

Communities:

https://designx.community/
http://pdxhcd.org/groups
https://www.womenwhocode.com/
https://womenhack.com/


add luajit coroutine implementation

Woo, powerful Lua!

I've wanted to make this pull since February but I didn't find the "time".
Kudos for lua!. :)


Model Parallel LSTM Example

cc @antinucleon @pluskid @mli

I used the old executor API. tested a bit on Mu's CI mahine, adding GPU can indeed get some speedup for large workload

see https://github.com/dmlc/mxnet/pull/1781/commits/68513c07c903a7fb77f30c1f053a5ee42dc47a77 for changes I made.
Change this line https://github.com/tqchen/mxnet/commit/5d1da317494bad4d2a5793dc0c3a7e5dcfb288b9#diff-535d0615f09506053f7e903437a4cf36R71
for device placement

can you please give a rough speedup? we may include them on the slides

Is this example not using the bucketing API intentionally? I and @harouwu talked to @mli, and we are doing some benchmarking on the PTB example this week to checkout the bucketing performance on multi-GPU nodes and if any improvement can be made

I just pick the simper version for demonstration. I think the same philosophy applies to bucketing case.


[WebView iOS] add allowsInlineMediaPlayback prop to play inline html5 video

Allow an html5 video to be played inline. (see #3112)

@ide Done. The contributing guide says for documentation "do not wrap lines at 80 char"

+1

@facebook-github-bot shipit


Feature/brings back midi to export

I'm not sure it's the best way to bring back midi support to executable, but it works
I had to revert Text Points commit (ee05a26fdc7996205d5cc2a943ff3d2847cae468) in order to test the standalone

Thanks!


Error on run-android:  ERROR  unable to resolve root

I worked for a few days and everything worked normal, until today, ran the command react-native run-android and the error happened, as if he did not find the project ... I updated the watchman, but the error persists: (
react-native-cli: 0.1.10
react-native: 0.22.2
SO: Mac
Occur on both

@alexandref93 Did you try running watchman watch-del-all? You might also want to try reinstalling your node_modules via rm -rf node_modules && npm i.
It would probably be best to ask this question on Stack Overflow though since this doesn't seem like a packager bug but really an issue with your local project.

I'm currently running into the same problem. I upgraded my existing project React-Native version to 0.22.2 based on this - https://facebook.github.io/react-native/docs/upgrading.html
I upgraded all my dependencies, got Android emulator all setup and connected but was getting the above error. If I uninstall watchman I can get some JS from my project to load in iOS simulator and Android emulator.

Sorry @dsibiski ..... i running watchman watch-del-all & rm -rf node_modules && npm i, but the problem remains the same :(

Hi @alexandref93!
This appears to be a watchman issue :( Can you report it to https://github.com/facebook/watchman please? Sorry about that, hope it gets resolved!


Updated readme

Just updated the readme to reflect the merged changes. Feel free to merge if you'd like.

Thanks!


Files v2 bug/Problemes

1: The file app can't be opened when minimized to the backround
2: It crashes
3: you can't drag "files/apps" and drop it to the file manager
4: It's laggy
5: opening files and folders take too long to execute
These problemes made me uninstall the programes

This is the repo for the website, not the app. Please open the issue again in https://github.com/files-community/files.


Kerberos Authentication to Proxy on EventProcessorClient

Query/Question
Currently EventProcessorClient supports Proxy Authentication via Basic and DIGEST. I need to setup the EventProcessorClient behind a corporate secure proxy and I need to authenticate to proxy via Kerberos.
I was able to create a custom HttpClient via implementing HttpClient of Azure and used it in BlobContainerAsyncClient as a result it connected to Blob Storage via using custom HttpClient configured with Kerberos authentication successfully.
I have also implemented HttpClientProvider of Azure and overriden createInstance method where I have returned my custom HttpClient implementation and forced it to use my implementation via setting the environment property like below:
AZURE_HTTP_CLIENT_IMPLEMENTATION: com.*.ApacheHttpClientProvider (full path here - star only for hiding details)
However EventProcessorClient doesn't work and logs below message on onError() callback with the below error message
Error occurred on partition: NONE. Error: java.io.IOException: Attempted read from closed stream.
Why is this not a Bug or a feature Request?
A clear explanation of why is this not a bug or a feature request?
On EventProcessorClient there is no direct call to .httpClient() or Kerberos Authentication under .proxyOptions().
Setup:

OS: Windows
IDE: IntelliJ
Library/Libraries: azure-messaging-eventhubs-checkpointstore-blob :1.19.0, azure-messaging-eventhubs:5.18.0

Information Checklist

[ x ] Query Added
[ x ] Setup information Added

At the moment we’ve only Digest and Basic authentication built in. We’ve a feature request to make the pluggable Proxy contract, so users with need for any specific authentication mechanisms can implement challenge handshaking (e.g., by inspecting proxy-authorization headers, connecting to external token auth-source etc..) for their proxy server and plugin it in.


Added e2e tests

Signed-off-by: ashish<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@jbyers19 Can you review this?

@jbyers19 Can you review this?

@leecalcote  the tests are failing because the script in core workflow has one problem. Although I already have merged two PRs fixing that. I will create one last PR, so that this issue does not come again. Sorry for not getting it right the first time.

@leecalcote  the tests are failing because the script in core workflow has one problem. Although I already have merged two PRs fixing that. I will create one last PR, so that this issue does not come again. Sorry for not getting it right the first time.

@Revolyssup I sympathize. PRs with workflow changes feel like a chicken before the egg problem... particularly with GH's nasty caching issues.

@Revolyssup I sympathize. PRs with workflow changes feel like a chicken before the egg problem... particularly with GH's nasty caching issues.


[DROOLS-860] Retract the core object on the retraction of a trait.

Ensure that on the retraction of a traited object, the underlying core object is retracted as well.

Can one of the admins verify this patch?

Kevin and I found (and fixed) this bug the other day
On Fri, Jul 24, 2015 at 10:17 PM, kie-ci<EMAIL_ADDRESS>wrote:

Can one of the admins verify this patch?
—
Reply to this email directly or view it on GitHub
https://github.com/droolsjbpm/drools/pull/470#issuecomment-124792631.

ok to test

Merged by https://github.com/droolsjbpm/drools/commit/11f2b3022


does it work in ps2?

Hello. I have a ps2 that I am currently using free mcboot, and I want to install your memory card images on a sd card on mx4sio, is it possible ? if it's possible how do I handle it ?
thank you!

Hello. I have a ps2 that I am currently using free mcboot, and I want to install your memory card images on a sd card on mx4sio, is it possible ? if it's possible how do I handle it ?
thank you!

On a PS2 it does not work


Fix playlist description 'helloaf'

Fix this issue:

Hahahaha never did I imagine someone would actually say something about this - it's a very dumb inside joke


Providing explanation of .env variables

Hey there,
I tried to start your services without all having the environment variables set (only the open ai key). I get the following return value when running docker compose up:
abi-1  | Run `poetry install` to resolve and get rid of this message.
abi-1  |
abi-1  | Traceback (most recent call last):
abi-1  |   File "<string>", line 1, in <module>
abi-1  |   File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
abi-1  |     return _bootstrap._gcd_import(name[level:], package, level)
abi-1  |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
abi-1  |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
abi-1  |   File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
abi-1  |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
abi-1  |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
abi-1  |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
abi-1  |   File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
abi-1  |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
abi-1  |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
abi-1  |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
abi-1  |   File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
abi-1  |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
abi-1  |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
abi-1  |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
abi-1  |   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
abi-1  |   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
abi-1  |   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
abi-1  |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
abi-1  |   File "/app/src/__init__.py", line 1, in <module>
abi-1  |     from abi.services.secret.Secret import Secret
abi-1  | ModuleNotFoundError: No module named 'abi'
abi-1 exited with code 1

While I think the most apparent suspicion is the missing environment variables, then this error could (1.) potentially produce a more helpful message and (2.) your .env-variable contains a lot of environment variables that honestly seem to be somewhat optional (LinkedIn, github). I also do not have all the services (e.g., Hubspot, Stripe). This is potentially mainly a documentation issue, knowing what is a must and what is a optional value.

Hello @achiminator, thank you for trying our project. I updated the .env.example to explain a bit more and also comment everything that is optional.
I tried to setup the project from scratch again, just putting an openai api key and it worked for me.
To run the project, you must run make chat once you cloned the repo and copied/edited the .env
Let me know how it goes please.

@achiminator, Have you been able to follow the procedure from @Dr0p42? Is it working on your side now?

Hey @all, sorry for taking so long. I finally got it up and running. I first ran into the following problem:
[+] Building 0.0s (0/0)  docker:default
[+] Building 1.8s (5/9)                                                                                docker:default
 => [abi internal] load build definition from Dockerfile                                                                  0.0s
 => => transferring dockerfile: 205B                                                                                0.0s
 => [abi internal] load metadata for docker.io/library/python:3.9                                                         0.6s
 => [abi internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [abi 1/5] FROM docker.io/library/python:3.9@sha256:dd8b65c39a729f946398d2e03a3e6defc8c0cfec409b9f536200634ad6408b54   0.0s
 => ERROR [abi internal] load build context                                                                               1.1s
 => => transferring context: 57.28MB                                                                                1.1s
------
 > [abi internal] load build context:
------
failed to solve: archive/tar: unknown file mode ?rwxr-xr-x

I was able to solve it using the last comment of https://stackoverflow.com/questions/78523506/docker-error-failed-to-solve-archive-tar-unknown-file-mode-rwxr-xr-x - I needed to delete the automatically created .venv folder after every previous docker build. Maybe that is something that can be done automatically.
Unfortunately, I ran into a different challenge.
 ✔ Network 2608naasabi_default  Created                                                                         0.0s
 ✔ Container 2608naasabi-abi-1  Created                                                                         0.0s
Attaching to abi-1
abi-1  | Creating virtualenv src in /app/.venv
abi-1  | Command not found: chat-single-assistant
abi-1 exited with code 1

Any ideas on where it goes of?

Hey @ALL, sorry for taking so long. I finally got it up and running. I first ran into the following problem:
[+] Building 0.0s (0/0)  docker:default
[+] Building 1.8s (5/9)                                                                                docker:default
 => [abi internal] load build definition from Dockerfile                                                                  0.0s
 => => transferring dockerfile: 205B                                                                                0.0s
 => [abi internal] load metadata for docker.io/library/python:3.9                                                         0.6s
 => [abi internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [abi 1/5] FROM docker.io/library/python:3.9@sha256:dd8b65c39a729f946398d2e03a3e6defc8c0cfec409b9f536200634ad6408b54   0.0s
 => ERROR [abi internal] load build context                                                                               1.1s
 => => transferring context: 57.28MB                                                                                1.1s
------
 > [abi internal] load build context:
------
failed to solve: archive/tar: unknown file mode ?rwxr-xr-x

I was able to solve it using the last comment of https://stackoverflow.com/questions/78523506/docker-error-failed-to-solve-archive-tar-unknown-file-mode-rwxr-xr-x - I needed to delete the automatically created .venv folder after every previous docker build. Maybe that is something that can be done automatically.
Unfortunately, I ran into a different challenge.
 ✔ Network 2608naasabi_default  Created                                                                         0.0s
 ✔ Container 2608naasabi-abi-1  Created                                                                         0.0s
Attaching to abi-1
abi-1  | Creating virtualenv src in /app/.venv
abi-1  | Command not found: chat-single-assistant
abi-1 exited with code 1

Any ideas on where it goes of?

Yes! This command does not exist anymore. Since, you open this issue, we added more agents and now you can start with "make" to start chatting with the default agent. You can also pick any agent available from the list in the README 4. : https://github.com/jupyter-naas/abi?tab=readme-ov-file#getting-started
What would you like to do? Do you already have something in mind?


Update App.php

Added ability to override the default block size used to retrieve the contents of the body of a response.

/cc @codeguy

/cc @codeguy Updated.


Route our application logs to Azure Event hubs for eventual CDC splunk ingestion

Work with Brookshire, Thomas H. (CDC/OCOO/OCIO<EMAIL_ADDRESS>to ingest into splunk
Resource: https://azure.microsoft.com/en-us/services/event-hubs/

slunk ingestion is complete


Upgrading to Kotest 5.7.1 leads to errors in NonEmptyList.forOne assertions

When coming from Kotest 5.6.2 with kotest-extensions-arrow 1.3.3 and upgrading to Kotest 5.7.1, using the matcher
io.kotest.assertions.arrow.core.forOne leads to this exception
java.lang.NoSuchMethodError: 'void io.kotest.inspectors.ElementFail.<init>(java.lang.Object, java.lang.Throwable)'
at io.kotest.assertions.arrow.core.NelnspectorsKt.forOne(Nelnspectors.kt:104)

Workaround is to explicitly cast the Nel to a Collection and use the Kotest matcher io.kotest.inspectors.forOne instead!
Could it be that this extension needs to be updated to work with Kotest 5.7?

Hm, not a very active project here?

I'll raise a PR really soon @Zordid sorry been caught in various work commitments

Thanks @myuwono !


fix duplicate register attribute during sync scenario

in the past, the register attribute was exclusively applied to the partial class defined in the *.designer.cs files.
however, xcsync uses roslyn for dotnet type processing and relies on the presence of the register attribute to detect if it is a type that should be synced to the Xcode environment.
so as is, after syncing the dotnet project is in a non-compilable state because of CS0579 error. the simple fix is to just remove the extra, no longer needed register attribute during the sync back.
before:

after:

Microsoft Reviewers: Open in CodeFlow
expected test results need to be adjusted still..

the simple fix is to just remove the extra, no longer needed register attribute during the sync back.

Are we 100% sure about this? @rolfbjarne do we still need the Register attribute for NSObject derived subclasses? Or does the registrar takes care of it for us?

@dalexsoto the register attribute is still present/required for the types, it's now just added to the partial class present in the original file rather than the *.designer.cs file. but if i'm missing something here, happy to adjust!

Can you provide a set of repro steps for this? I have yet to see this happen and would like to see what conditions this happens under.

Can you provide a set of repro steps for this? I have yet to see this happen and would like to see what conditions this happens under.

@mcumming to repro the error, just add a action/outlet and run xcsync sync. the synced back project will contain the error

Would it make sense to wrap the [Register] attribute in an #if instead of removing it entirely and then set the value before sync?
#if XCSYNC
[Register("whatever")]
#endif

Would it make sense to wrap the [Register] attribute in an #if instead of removing it entirely and then set the value before sync?
#if XCSYNC
[Register("whatever")]
#endif

That would require modifying the users csproj file to set the XCSYNC directive, not something I want to do if it can be avoided. Technically, this change would be removing the generation of a duplicate attribute in the {class}.designer.cs file, since it already exists on the partial class definition in the {class}.cs file.

users are expected to add the register attribute exclusively to the partial class counterpart in the *.designer.cs files. doing so will avoid the use case this pr addresses


trackerctl setup user raises error

Good evening,
running trackerctl setup user --username luca --email<EMAIL_ADDRESS>--password aaaaaaaaaaaaa fails after setting the role to any value with this message
arch-security-tracker on  add-footer [!] via .virtualenv took 2s
➜ ./trackerctl setup user --username luca --email<EMAIL_ADDRESS>--password aaaaaaaaaaaaaaaa
Role (administrator, security_team, reporter, guest) [reporter]:
Traceback (most recent call last):
  File "/home/neutrin0/Repos/arch-security-tracker/./trackerctl", line 5, in <module>
    cli.main()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/flask/cli.py", line 596, in main
    return super().main(*args, **kwargs)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1666, in invoke
    sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 923, in make_context
    self.parse_args(ctx, args)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1379, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 2364, in handle_parse_result
    value = self.process_value(ctx, value)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 2320, in process_value
    value = self.type_cast_value(ctx, value)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 2307, in type_cast_value
    return convert(value)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/types.py", line 75, in __call__
    return self.convert(value, param, ctx)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/types.py", line 284, in convert
    if normed_value in normed_choices:
TypeError: unhashable type: 'UserRole'

I already have a fix for this and make a PR. Basically the click option for role returns a value of the Enum UserRole which is not hashable. Two possible solutions are possible: either implementing __hash__ for the Enum or just making it return a string and converting to the Enum value after which is the one i have done.

Fied in da69dabf07fa033434996bb6a41207696a8a5058


Fix typo in context processor names

Coverage decreased (-0.39%) to 90.73% when pulling 091c69f667ca760513f8928b0dcdcecc43c92b63 on julienp:patch-1 into c3f3af496520a3e27cb8161f13b2bd869207f82b on divio:develop.

@julienp thanks!


Segmentation Fault on Bayesian Hidden Markov Model Tutorial

I am getting stuck running the HMM tutorial.
The problem is with running the sampler; everything up to then runs perfectly.
When I run the sampler code via the Julia REPL:
chn = sample(BayesHmm(y, 3), g, 1000);

I get a segmentation fault. This is running Julia 1.7.1 on Linux. My package environment is:

Julia 1.7.1
Turing v0.15.1
StatsPlots v0.14.30

Is there something I should do to make the sampler run?

signal (11): Segmentation fault
in expression starting at REPL[9]:1
getproperty at ./task.jl:170 [inlined]
n_copies at /home/trent/.julia/packages/Libtask/OtgFl/src/ctask.jl:35
n_copies at /home/trent/.julia/packages/Libtask/OtgFl/src/ctask.jl:33 [inlined]
tzeros at /home/trent/.julia/packages/Libtask/OtgFl/src/tarray.jl:165
unknown function (ip: 0x7f1cd4170c51)
tzeros at /home/trent/.julia/packages/Libtask/OtgFl/src/tarray.jl:171 [inlined]
#1 at ./REPL[7]:7 [inlined]
#1 at ./none:0
macro expansion at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/model.jl:0 [inlined]
_evaluate at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/model.jl:154 [inlined]
evaluate_threadunsafe at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/model.jl:127 [inlined]
Model at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/model.jl:92 [inlined]
VarInfo at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/varinfo.jl:126 [inlined]
VarInfo at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/varinfo.jl:125 [inlined]
#step#18 at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/sampler.jl:73
step at /home/trent/.julia/packages/DynamicPPL/SgzCy/src/sampler.jl:66 [inlined]
macro expansion at /home/trent/.julia/packages/AbstractMCMC/oou1a/src/sample.jl:97 [inlined]
macro expansion at /home/trent/.julia/packages/AbstractMCMC/oou1a/src/logging.jl:15 [inlined]
#mcmcsample#19 at /home/trent/.julia/packages/AbstractMCMC/oou1a/src/sample.jl:88
unknown function (ip: 0x7f1cd41707c5)
mcmcsample##kw at /home/trent/.julia/packages/AbstractMCMC/oou1a/src/sample.jl:85
unknown function (ip: 0x7f1cd414df65)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
#sample#3 at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:156
unknown function (ip: 0x7f1cd414dc3d)
sample at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:155 [inlined]
#sample#2 at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:142 [inlined]
sample at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:142 [inlined]
#sample#1 at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:132 [inlined]
sample at /home/trent/.julia/packages/Turing/uAz5c/src/inference/Inference.jl:132
unknown function (ip: 0x7f1cd414d9d2)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
do_call at /buildworker/worker/package_linux64/build/src/interpreter.c:126
eval_value at /buildworker/worker/package_linux64/build/src/interpreter.c:215
eval_stmt_value at /buildworker/worker/package_linux64/build/src/interpreter.c:166 [inlined]
eval_body at /buildworker/worker/package_linux64/build/src/interpreter.c:587
jl_interpret_toplevel_thunk at /buildworker/worker/package_linux64/build/src/interpreter.c:731
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:885
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:830
jl_toplevel_eval_flex at /buildworker/worker/package_linux64/build/src/toplevel.c:830
jl_toplevel_eval_in at /buildworker/worker/package_linux64/build/src/toplevel.c:944
eval at ./boot.jl:373 [inlined]
eval_user_input at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/REPL/src/REPL.jl:150
repl_backend_loop at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/REPL/src/REPL.jl:244
start_repl_backend at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/REPL/src/REPL.jl:229
#run_repl#47 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/REPL/src/REPL.jl:362
run_repl at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/REPL/src/REPL.jl:349
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
#930 at ./client.jl:394
jfptr_YY.930_40362.clone_1 at /usr/lib/julia-1.7.1/lib/julia/sys.so (unknown line)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
jl_f__call_latest at /buildworker/worker/package_linux64/build/src/builtins.c:757
#invokelatest#2 at ./essentials.jl:716 [inlined]
invokelatest at ./essentials.jl:714 [inlined]
run_main_repl at ./client.jl:379
exec_options at ./client.jl:309
_start at ./client.jl:495
jfptr__start_40531.clone_1 at /usr/lib/julia-1.7.1/lib/julia/sys.so (unknown line)
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2429
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1788 [inlined]
true_main at /buildworker/worker/package_linux64/build/src/jlapi.c:559
jl_repl_entrypoint at /buildworker/worker/package_linux64/build/src/jlapi.c:701
main at julia (unknown line)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x400808)
Allocations: 144520746 (Pool: 144483959; Big: 36787); GC: 113
Segmentation fault (core dumped)

See https://github.com/TuringLang/Turing.jl/issues/1738. Should be fixed very soon.


feat: forward card props

forward props to header, action and content of a card
add some basic card tests

Looks good, however let's merge this after we release.


Fixes the issue described in #423

Fixes the issue where the change from day to week view would display the wrong week when the startOfWeek is not the default, closes #423

Thank you very much!


[WIP] S3 source refactor

This PR converts the client side S3 dataset to an S3 source, and adds support for an S3 source on the backend.
Still some Todos.

Todos all done.  This refactors the source panel and dataset panel a bit, hopefully making it easier to add new sources.
I've removed the upload link for Datasets.  We can bring that back once we have some more specific use cases and clean up a lot of the associated client side code.

S3 is now displayed as an available source type to add.

Ug.  Seeing the repeated word "source" in that screenshot bothers me.  I'll push a fix.
After selecting S3, you can enter the details of the new source.

Adding the S3 source will trigger an import job just like before, and will add a new source to the source panel.

You can click on the cloud icon in the source panel to get a read only hierarchy view of the S3 data that has been imported.

Clicking on the mean contour analysis allows you to select from the available S3 sources, navigate their imported hierarchy, and select an item.  That, plus specifying a parameter as before allows you to start a mean contour analysis job.

A mean contour analysis job is created, as before, and the result of the job is a new dataset as before.

You can still display the resulting contour json, i.e. I didn't break that.

Ready for review.  @kotfic is probably best to review this.
It isn't as bad as it seems.  You can follow along with the documentation changes describing how to create a source and look at the screenshot driven narrative in the comment above.
@mbertrand @essamjoubori PTAL if you are curious about the S3/spark/contour analysis pipeline.

I've removed the upload link for Datasets. We can bring that back once we have some more specific use cases and clean up a lot of the associated client side code.

+1. Can we add a "Local source" option? The idea is that using that source you can load files from your local filesystem. More specific sources such as "Raster" and "Vector", "Gridded" can be added later.

I think that will work--the harder part will be setting up the right UI to allow specifying the source type.
Do you want to see the Local source as part of this work, or can I add an issue for it?

Do you want to see the Local source as part of this work, or can I add an issue for it?

Not part of this work. A new issue would be ideal. The use case we have is this:

Use uploads PDF from her/his filesystem
We run some analysis on those PDF's that generates tabular data
We upload that data into MongoDB via Girder

So I am thinking having a "Local" source would be nice here that enables you to load any filetype to our system.

Issue added.  The local source upload part is easy.  Dealing with arbitrary file types is the hard part.  We could do just a pdf uploader as a first pass (select local source type, then select pdf).

Issue added. The local source upload part is easy. Dealing with arbitrary file types is the hard part. We could do just a pdf uploader as a first pass (select local source type, then select pdf).

Roger that. Yes, think dealing with arbitrary formats would be hard. I think we may need to work on file type specific readers (one solution).

@kotfic can you review this when you get some time?

Looks like this is not working on girder master,  I am seeing the following
{field: "bucket", message: "Unable to connect to bucket "nasanex".", type: "validation"}

when trying to create a new s3 source through the frontend.

This is a problem in Girder, see https://github.com/girder/girder/issues/1056.

@kotfic could you please review this soon?

@mgrauer LGTM !


Fix exporting trigger shapes in GLTF

This is a minor but critical bug that broke exporting trigger shapes. It's a regression I introduced in #78967. This is only merged in master, so this PR is only relevant for master.
The intention of this internal helper method is to start with the parent, because it's used in places where the child may not even exist yet. However, in the export code, since there is no p_scene_parent like with the import code, I made a mistake of writing p_scene_node instead of p_scene_node->get_parent().

Thanks!


feat: implement new functions

About
This PR:

Adds new functions:

Channel:

pin_message()
unpin_message()
publish_message()
get_pinned_messages()

Message:

pin()
unpin()
publish()

Guild:

get_all_channels()
get_all_roles()
modify_role_position()
get_bans()

Role:

modify_position()

Adds missing return and rtype to docstrings

Checklist

[x] I've ran pre-commit to format and lint the change(s) made.
[x] I've checked to make sure the change(s) work on 3.8.6 and higher.
[ ] This fixes/solves an Issue.

(If existent):

[ ] I've made this pull request for/as: (check all that apply)

[x] Documentation
[ ] Breaking change
[x] New feature/enhancement
[ ] Bugfix

I also see that you're importing specific models per iteration in a method, which can affect performance. (although it should be a very tiny amount because it'll recall upon loaded memory) Is there any reason why they're being done in the methods instead of an import in the file itself?

Circular import


Fork Reward Recovery (fd-cli) - not building on Ubuntu 22.04 base image

Even with cmake installed, there is an error on Jammy that is not seen on Focal (Ubuntu 20.04):

Fixed in v0.8.5 release.


Check on ribasim.Model construction if used node types are given

In ribasim-python, creating a Model object looks like this:
model = ribasim.Model(
    modelname="basic",
    node=node,
    edge=edge,
    basin=basin,
    level_boundary=level_boundary,
    level_control=level_control,
    pump=pump,
    linear_level_connection=linear_level_connection,
    manning_resistance=manning_resistance,
    tabulated_rating_curve=rating_curve,
    fractional_flow=fractional_flow,
    starttime="2020-01-01 00:00:00",
    endtime="2021-01-01 00:00:00",
)

We know the used node types from node. If you use say a LevelBoundary, this will not work unless you pass a (non-empty) LevelBoundary instance to the Model constructor.
Right now this works, and only fails during model runtime. I think we should probably fail early here, since this is a relatively easy check.

Closed by add API.


update minimum Hugo version

Hi @yihui,
I tried to build/deploy the site via Netlify using the current minimum version 0.54.0 and ran into build errors:
https://github.com/yihui/hugo-prose/blob/master/theme.toml#L8
Here is my log:
https://app.netlify.com/sites/sharp-colden-263590/deploys/5fae99f929769000f09eba3b
I upgraded to my local Hugo version 0.71.1 and it worked, but not sure if there is anything in between that would work :)

Also I just noticed that you are using 0.78.0 to build on Netlify right now 😄

I meant to figure out the min version a few days ago but forgot it. It should be 0.55.0. Thank you!


ExecuteScriptAtBlockHeight() and GetAccountAtBlockHeight() are not working for query-only transaction

Instructions
Query on the latest block using ExecuteScriptAtLatestBlock() are working fine. However, query the state of block at certain block height by executing script is not working. The only way now to view historical data is listening for the events that emitted from the transactions in every block.
Steps to Reproduce
For example, I want to query account balance from certain block height:
acc,err:=flowClient.GetAccountAtBlockHeight(ctx,flow.HexToAddress(hex),17572032)

It gives out the following error:
err: client: rpc error: code = Internal desc = failed to get account from the execution node: 3 errors occurred:
        * rpc error: code = Internal desc = failed to get account: failed to get account at block (1b0fc9dd8d981dbb05758a53cae9ef8eeb10f9b7ae6f38c816064752232f8c0c): cannot get account: failed to read key exists on account �N���&�: [Failure Code: 2002] ledger returns unsuccessful: get register failed: error getting register (exists) value at 7262931c5a33d810696e3c13fc5d053a48bedf141ece51c3bee3b93d49b0ee14: trie with the given rootHash [37323632393331633561333364383130363936653363313366633564303533613438626564663134316563653531633362656533623933643439623065653134] not found

Acceptance Criteria
Execute script that query-only on certain block height should work.
Context
I am working on a database parser that store all historical data on chain into a database, in order to quickly query historical chain data for users.

I'm also interested in this. There are no workarounds to get the state at a given block height?


Tagging

Is your feature request related to a problem? Please describe.
Tagging doesn't seem to be implemented yet.
Describe the solution you'd like
I'd enjoy a tagging interface just like Magit's tagging.
Describe alternatives you've considered
For the moment I just use the CLI or LazyGit.
Additional context
It could be that this is already implemented, and I'm blind but I don't see it, nor conversations about it, and I didn't see it in the umbrella list.

Yup! Not implemented yet. It's on the roadmap, but it's also a good first issue if someone wants to take a swing at it.

I can pick up the basic tagging popup

Nice :D lemme know if you have any questions


XIVY-13226 fix flickering when frame content gets unloaded

this fix was already there, see https://github.com/axonivy/dev-workflow-ui/pull/149/files
fix does not work for safari...

Maybe move the visibility to the stage where the window location is not set? https://github.com/axonivy/dev-workflow-ui/pull/299/files#diff-790c37ac9843e50d81342d5f20c92efc12d587d849e80f9360a2ddbbe087b37eR120-R122
if (newPage) {
  window.location = newPage;
} else {
  iframe.style.visibility = 'visible';
}

and remove it on line iframe.style.visibility = 'visible';
And I think we should merge this down to 10.0 and 11.2 if it is there a problem too and this really fixes it stable :)

nice thanks, works now also with safari. I will merge it down to 10.0 and 11.2


Table resize

Hey, I am trying to use your editor but I have hard time with tables, they work fine but I can't resize them(I installed the editor with npm)

the buttons have the config, I tried to use all the config from Jodit.defaultConfig and still no success.

if anyone wants the answer for this, is that you need the iframe: true flag


Added Java 6 Support.

Cordova Android 6.x compiles code by default using java 6, so plugins need to support Java 6, otherwise the following error will be reported:
Error: diamond operator is not supported in-source 1.6
(use-source 7 or higher to enable diamond operator)

Thanks for this pull request. I'm not going to merge this for now. This plugin is going to require newer versions of Java (and Javascript). Upgrading cordova and cordova android should fix most projects.


Siaf updates nirspec16may22

Note: generate_nirspec.py results in two assert errors that are benign - improper field points tested for NRS. The current test routines inappropriately test locations outside the valid range.  Fixed test code gives good results.

I missed that this PR was against "master". We need to change it to "siaf-updates" before merging and starting the CR process.

@Witchblade101 just changed the base to siaf-updates. If you want to re-review because it can cause history gaps.

History looks good so I'll go ahead and merge.


function(e) get "e.id" not working

Hi, my datasource has the structure:
[ {   id:  1,
name:  todo,
startDate:   xxxxx,,
endDate:  xxxx  } ]
When I use "dayClick: function(e) { alert( "Event ID = " + e.id ) } " I want to get the ID of the event.
BUT  I always get "Event ID = undefined " ....
How can I get the ID of the underlaying Event ??

Hi,
There is few errors in your code:

The event name is clickDay, not dayClick
The event parameter is an object that contain several properties, including the list of events. So if your param is named e, you can use the following code to get the id alert(e.events[0].id) (if you are sure about the number of events on this day)

Moreover, I introduced a bug yesterday concerning the computation of the event parameters, which I fixed this morning (commit 8ab60d22bab8048ca62f5fbaad14ec2c3fdf640b), so if you took the last GitHub version yesterday, update the calendar code).

Thank you very much, it works now ! ;-)


[BUG] importing _Qhull from scipy causes crash

I freshly installed ESCALATE on my system. When running migrations, I hit the following error:
  File "/Users/mtynes/repos/escalate/escalate/core/utilities/__init__.py", line 3, in <module>
    from .enumerativeSampling import *
  File "/Users/mtynes/repos/escalate/escalate/core/utilities/enumerativeSampling.py", line 19, in <module>
    from scipy.spatial.qhull import _Qhull
ImportError: cannot import name '_Qhull' from 'scipy.spatial.qhull' (/Users/mtynes/miniconda3/envs/escalate/lib/python3.10/site-packages/scipy/spatial/qhull.py)

I checked, and my scipy version is '1.8.0'.
Paths to fix this:

Specify the version of scipy where _Qhull exists in scipy.spatial.qhull
Update to use current scipy interface

I would lean towards option 2. I would especially try to see if its possible to keep the qhull functionality without importing _Qhull at all: its bad form to rely on private interfaces because they are subject to change without notice -- that's how we got here.

Question: Is it possible to replicate the convex hull functionality using this class?

Awesome, thanks for the quick fix and info @vshekar!


Figure out how best to use these definitions

As mentioned by @danvk, we need to figure out how best to instruct others to obtain and use these definitions. I'll be back next week to discuss more.

cc @gabelevi who's working on some related things WRT interface definitions that can easily be shipped alongside (but decoupled from) the library implementation

I do like the idea of libraries distributing their own typings.
Some pros:

typings are tied to the version of the library to which they apply
Installation is simple (type definitions come with the node module)

Some cons:

Owners of major libraries may not care to distribute type definitions (especially older ones which aren't updated often)
When there's a new version of Flow, it's harder for the Flow owners to check for regressions against all type definitions (which they could do with this repo).

When there's a new version of Flow, it's harder for the Flow owners to check for regressions against all type definitions (which they could do with this repo).

Yea agree with the problem, though I see this as a separate problem that we need to work on even independent of interface definitions.
One thing that we do with our codebases to address a part of this is to explicitly set the version= option in the config. Then we use a wrapper script for the flow command that reads this and then runs the appropriate version of flow (rather than a single global version of Flow installed). I really think this is the right direction for the command you should get through homebrew/opam/flow-cli.
It doesn't quite solve another problem, though: What to do when two libraries used by a single project dictate that they rely on disjoint versions of flow? For this I don't have a good answer yet...but it's probably something we need to consider soon. We haven't had to address it with our own projects yet because we don't sub-version project dependencies...but with npm and such there's no getting around it as a common case.

@jeffmo As a starter, since there will be a lot of unknowns how to do the versioning and similar stuff... would it be a good idea to start a new cli-tool to retrieve definitions from this repository, similar how DefinitelyTyped's cli-tool does? I would be keen to invest some time in this and get something going.

@magicpat I think it's for sure a good idea. In fact, I think @jeffmo has already done some thinking in this area.

In my opinion, the simplest useful option would be to push FlowTyped to npm as-is. Users could include it as a dependency, and add lines in .flowconfig to point to the type definitions that they want to use. For example:
[libs]
node_modules/FlowTyped/underscore/underscore.js

That would make it hard for consumers to pick and choose different versions of type definition files. But it would get something useful out into the world quickly.
A simple way to make multiple versions of definitions available for a single file would be to encode versions in file paths. Eg, node_modules/FlowTyped/underscore/1.8/underscore.js vs node_modules/FlowTyped/underscore/1.7/underscore.js.

Great idea, @hallettj. I've published it here:
https://www.npmjs.com/package/flow-typed
And I'll get to reviewing your PRs soon, thanks so much for contributing!

So I haven't had time to write all of this up yet, but I was actually hoping that we could use the npm package to do a little more of an interesting integration (you add it as a dependency and it automatically scrapes your package.json's list of dependencies and fetches the relevant libdefs for you).
I'm really hoping I can write these thoughts out in a more coherent way this week so we can talk through them, but I'd really like for this repo to be a defacto part of using Flow with npm

One downside to publishing the entire repo is just that it means you'll get libdefs for packages that you don't actually have installed. I think it'll be important to keep the installed libdefs as close to reality as possible. There are also versioning concerns to be taken carefully into account.

Right, good points, @jeffmo. It shouldn't be a problem to have published what we have now, and change it when we get the rest figured out, should it?

Oh no I don't see any issues here -- mostly just wanted to lead in with some context :)

I don't want to spoil this idea with premature optimization issues, but if I look at DefinitelyTyped, I would rather not have to install thousands of files (especially for every project I install flow-typed in my devDependencies).
But I really like the versioning idea i.e. node_modules/FlowTyped/underscore/1.0/underscore.js.
If we concise to a proper versioning structure and maybe add something like a underscore/1.0/flow_version file for describing compatible flow versions I will additionally create an complementary commandline tool for those who do not want to pull the whole repo.
Example of underscore/1.0/flow_version:
{
  "flow": "~0.22"
}

CLI concept
Just so I have this somewhere in place and for the sake of this discussion, I will write this here...
Interface of the cli-tool:
# Reads ./flowtyped.json for configuration
flow-typed install <dependency>

Config file <Project>/flowtyped.json:
//Default-Values
{
   "source": "https://github.com/splodingsocks/FlowTyped",
   "destination": "interfaces/"

   //Will parse the package.json file for dependency-versions and
   //then tries do match a proper declaration file to it from our source
   "autodetect": true,

   "dependencies":  {
      //i.e. I want this exact version
      "underscore": "1.0",

      //or maybe enable me to use my own local files (which will be copied / symlinked)
      "immutablejs": "~/flow_declarations/own_immutable.js"
   }
}

The tool could also check if .flowconfig has an [included] configuration with proper destination set, otherwise it may put out a warning or autofixes it.

@magicpat: Yea, I agree -- I think we can do a lot better than DefinitelyTyped in these areas.
Between good versioning, automating libdef generation where possible (I'll go into this in more detail a little later), a good libdef testing setup, and making it super easy get exactly the libdefs you need at the version you need with as little effort as possible, I think we can MakeLibdefsGreatAgain™.
As for a CLI tool -- this looks great and I think we might need one at some point, but I actually think we should explore options that require minimal configuration (if any?).
For example: I was thinking it would be cool if the flow-typed npm package just had a postinstall script that actually fetched the correct lib-version/flow-version tuple from FlowTyped for you (based on your project's stated package.json dependencies) and placed that in a specific dir (say, `flow-typed?). Then Flow just knows to check that specific dir for libdefs out of the box.
There might still be a use for a CLI down the road that lets you do more specific things (I.e. test an update to a libdef, fetch specific libdefs ad-hoc, etc), but I'm betting the postinstall stuff could cover most of what we need at the outset.

Do we need a seperate config and CLI?
How about we just use npm?
Just found out about flow-typed - I'm managing some flow interfaces myself @ https://github.com/marudor/flowInterfaces
It started as a simple Repo I used as submodule. But it grew and some other people wanted to use it so I made a monorepo and just publish each libdef to npm (as iflow-)
That way someone can just install it via NPM.
My only bummer is that I have to add each module to the [lib] section of flow manually.
Any thoughts?

@marudor: Yea, I agree that a new CLI/config shouldn't be the default/common-case usage.
Having individual npm packages is definitely an option, but the only annoying bit about this I can foresee is just that you have to explicitly (1) look to see if a lib def exists for a given dependency (2) specify both the real dependency and the libdef in your package.json (once for each dependency) (3) bump the versions of both the libdef and the real dep at the same time in the future.
Also @mroch brought up a good point yesterday that we should probably always install the lowest-compatible-version of a library definition for a given dependency (to ensure that Flow understands the most stable version of the libdef you have installed).
So for example:
Say that package 'foo' depends on package 'bar' like this:
{
  "name": "foo",
  "version": "1.0.0",
  "dependencies": {
    "bar": "1.x"
  }
}

Package 'bar' has two versions, with interfaces like this:
 // 1.0.0
declare function bar(x: string);

// 1.1.0
declare function bar(x: string);
declare function baz(y: number);

Per npm's semver rules, it's fine to use either version of 'bar' because 1.1.0 is backwards compatible with 1.0.0; its changes are purely additive.
The problem
If I run npm install and get bar-1.1.0, and then add a call to baz(123), everything typechecks and I land it. But someone else, who npm install-ed before me and has bar-1.0.0, will get errors. Booooo, Flow failed us.
So to solve this, we should just always install the lowest-compatible-version of a libdef and, if someone wishes to use an API introduced in a higher/compatible version (say, bar-1.1.0) they just need to explicitly state that minimum-viable version in their package.json. Really they should do this anyway -- it was just easier to miss prior to tools like Flow warning them.

Proposal
Ok, so to kick off a solid plan, here's a holistic proposal I'd like to put forth for discussion. Obviously we'll need to build this iteratively, but I'm willing to dedicate time to help build this (and would certainly be willing to work with anyone else who is interested in doing the same).
Also, this is totally a community discussion -- so if you see issues or things this doesn't address, let's talk through them and make sure we build something excellent here!
FlowTyped Repo
This repo is the structured data-store for library definitions. Adding a new library definition is as simple as sending a pull request that includes the libdef, a specification of the package-version the libdef was generated for, and the version(s) of Flow the libdef is known to be compatible with.
A proposed file/directory structure for the repo is as follows:

(dir) lodash // exact npm package name

(dir) v4 // "v" + semver-comparable package version. "v4" matches *all* of "v4.x.x"

(file) test-lodash-v4.1.js // Lodash v4 test file. Runs for all versions of Flow
(file) test-lodash-v4.2.js // A second lodash v4 test file
(dir) flow-all // "-all" means "works with all Flow versions"

(file) lodash-v4.js // The flow-0.22 libdef. Always named "PKG-vVERSION.js"
(file) test-flow-v0.22.js // Flow 0.22-specific test. Hopefully these are rare
(file) .flowconfig // used for specifying the root of the test flow-project

(dir) v3.2.1 // Matches exactly<EMAIL_ADDRESS>Most specific

(file) test-lodash-v3.2.1.js
(dir) flow-v0.22 // semver-comparable Flow version. More specific than "-all"

(file) lodash-v3.2.1.js
(file) .flowconfig

(dir) underscore

(dir) v1.8 `// Matches all of "v1.8.x"

(file) test-underscore.js
(dir) flow-all // I expect "flow-all" to be most common

(file) underscsore-v1.8.js
(file) .flowconfig

...

Directory structure conventions (which are checked/verified and relied on by tooling like Travis, an eventual flow-typed package, etc):

Package dir names (toplevel dirs) must always match the npm package name exactly.
Package-version sub-directories are always named "v" + SEMVER_VERSION.
Flow-version sub-sub-directories are always named "flow-v"  + FLOW_VERSION or "flow-all".
There is intentionally no form of "-all" for package-version subdirectories. Each package-version dir must correspond to a published npm package version (or a semver string that resolves to at least one published npm package version).
Test files must always be prefixed by "test-" followed some name for the test file.
Test files may appear in either the toplevel package dir (i.e. lodash/test-lodash.js), or in the version-specific dir (i.e. lodash/v4/test-lodash.js), or in the flow-version-specific dir (i.e. lodash/v4/flow-v0.22/test-lodash.js).

Testing
Given the aforementioned dir structure, there should always be at least one test file for each libdef submission. Tests run as follows:
A test file should exercise the library definition to a suitable degree (when accepting a PR submission, we'll use good judgement here). This includes testing APIs in ways that both expectedly do not incur type errors, and ways that do. For type errors that are expected, we'll use a $ExpectError suppression comment. For a given test file to pass, it must produce no Flow errors when run with all relevant libdefs.
To run tests: For each package/version/flow-version subdirectory, run the specified version of Flow with a temporarily modified version of the .flowconfig which adds all relevant (outer) test-* files to the [includes] section. If no Flow errors are surfaced, the package/version/flow-version is considered passing (and can be published). Obviously we'll script this out and run tests in Travis to ensure that we maintain quality.
Typically, tests at the package-version level are preferred to flow-version-specific tests. Flow-version-specific tests are only meant for cases where a new version of Flow adds or fixes some libdef features that weren't available in prior versions.
Retrieving Library Definitions
We should get the testing and submission infrastructure set up and in place first and foremost (it serves as the foundation of what follows), but once that is in a reasonable state we should be primed to build automated tooling for retrieving library definitions for all stated dependencies of a given project (assuming libdefs for said project/version exist).
Two options: We can either do this with an explicit CLI or we can explore less explicit automated tools.
If we choose to go with an explicit CLI, this means developers would (a) npm install -g flow-typed (b) run something like cd MyPackage && flow-typed install to analyze + download all available libdefs for their project.
Alternatively (and my preferred solution), we can go with a more automated approach by way of an npm package intended to be installed as a dev-dependency exactly once. This package would have a postinstall script that analyzed the depending project's package.json, extracts a list of package/version pairs, and automatically installs the corresponding libdefs into the project -- all at npm install time.
The reason I prefer the second solution is that it needs to be set up only once and it slipstreams nicely into the existing npm install step that people already need to do.
Whichever approach we choose, the retrieval of a libdef for a given Package/Version pair should be done by getting the libdef for the lowest-compatible-package-version as stated in the project's package.json file. (See the later sections of this comment for details on why this is important).
If a developer retrieves a libdef using a particular version of Flow (let's say they're using Flow v0.X.Y), and there is both a "flow-all" and a matching "flow-v0.X.Y" version of the requested libdef, the "flow-v0.X.Y" version of the libdef is chosen over the "flow-all" version.
Publishing Library Definitions
Pull request! We'll make sure we outline all of the requirements for contributing a libdef (tests, naming conventions, etc) -- and tests + automated CI will help us maintain order in that area.
It's important that we have a well-defined (and enforced) structure convention for libdefs in order to support the eventual goal of being able to simplify and automate the process of retrieving libdefs as much as possible.

Looks fine to me.
I'm definitively for the 2nd approach of using a postinstall script.
Only question is how should updates be handled? (Updates to libs that is)
If the libs for (as an example) lodash get updated to be more precise/fix some edge case that was not handled before or whatever it will be distributed the next time someone uses npm install.
But a postinstall script definitively sounds better than a new explicit CLI.
The structure itself should give us a lot of flexibility while still easily allowing the most basic approach.

@jeffmo This looks really awesome!
So for the npm release, are all libdefs of the FlowTyped repository already included?
And for the testing, is it easy to switch between different flow versions? Today I realized that it's hard to maintain different projects with different flow requirements and a globally installed flow binary...

@marudor

Only question is how should updates be handled? (Updates to libs that is)

This is a good question. One thing I left out (mostly to keep discussion a little focused) is that eventually (read: probably not v0?) it would be cool to have a bot running that periodically scans npm for new versions of packages that have a toplevel dir in FlowTyped.
If a new version is discovered and Flow is able to reasonably infer an interface definition (i.e. if the package has .js.flow files, this is easy), the bot generates a libdef from that and just checks it in (not sure what to do about tests here -- but given that the libdefs are autogenerated, maybe that's a good enough quality marker).
If a new version is discovered and Flow cannot reasonably infer an interface definition "automatically", then we could add it to a list somewhere or something (especially if it's not covered by an existing libdef version). I would guess that most library updates are minor-version updates, so for those it should always be safe to fall back to a libdef for the prior minor version (the libdef might just lack a few things -- but easily fixed by a dev by creating an updated libdef for the new minor). For major versions that can't be auto-inferred, it would be just as if there were no libdef for the package and no libdef would be found.
@magicpat

is it easy to switch between different flow versions?

Good question. I think we (the Flow team) have some work to do here, and I know several people on the team are hacking on ways to manage this.
What we do internally at FB is we put a [version] entry in all of our .flowconfig files. This does two things: (1) It will cause Flow to error if the .flowconfig version doesn't match the version of Flow you're running and (2) We use a wrapper-script around the globally-installed flow CLI that reads this version, finds the real bin for that version on the FS (usually at a known location), and then executes that correct version. I know that @mroch is working on turning this into something more general that we could release to open-source -- so if we can make some headway there, it would be cool to make flow-bin do something along these lines.
That said, for the purposes of FlowTyped, the installation mechanism would probably just run flow version in the context of the local project (or, if available, check the [version] of the .flowconfig) to see what Flow version is being used and use that to match against what it queries for in the repo.

@jeffmo I think this is a great proposal.
Re: updating 🎯
I like the second approach a lot. And to handle updating, we could also provide a CLI that, when run, checks for new deps in the project package that don't yet have a flow definition downloaded, and will pull those down. This CLI would be available globally if installed that way, or from within node_modules/.bin/flow-typed
Re: downloading all definitions 📦
If I understood correctly, @magicpat asked if all libdefs would be downloaded to disk when a user runs npm install flow-typed. It seems like a good approach would be to have the NPM package only contain the CLI, and have the post-install script be responsible for fetching the appropriate files from the Github Repo directly (or a Couch DB instance, if we got really huge and wanted to be cool like NPM)
Re: what to do next 🐮
I think we should get a branch made, with the current definitions moved into the suggested file structure, and then we can work on getting the tests running on Travis with different flow versions as appropriate.
Any thoughts on those things?

Consider me on-board with everything you said!
Having the npm package work dually as a CLI and a downloader seems really simple and clean and probably gives us the best of both approaches

Super! Anyone want to take a look at #11 and see if I interpreted the approach correctly?

PR for the CLI that validates libdefs per the expected structure and runs in Travis: https://github.com/flowtype/flow-typed/pull/14
Still todo:

Add a run-tests command to the CLI that runs at Travis-time
Add /flow-typed as a default [lib] entry to Flow (if such a dir exists)
Build the aforementioned postinstall script that fetches appropriately-versioned libdefs from github and puts them into /flow-typed

For the run-tests command....
So we need a specific set of flowtype-binary versions to test through the definitions... would it be a good idea to write a script which downloads / builds a specific subset of flowtype binaries (i.e. >= 0.19) and puts it in some bin folder inside the flow-types node-module (development only)?
Then we just need a script which takes these specific versions from this local bin... or is it more complicated than I anticipate?

In fact, I'm about 80% of the way through writing the run-tests script that does just that :)
For each test it basically copies the libdefs+test files into a temporary dir, solves the set of versions of Flow that need to run on that for, grabs those versions of Flow (from the GitHub releases URL), and runs 'flow check' for each of them.
(I'm out of town for the weekend so I likely won't be able to finish and send the PR for review until Monday, but happy to discuss more thoughts here if there are any)

@jeffmo man, you are a machine! I try to find something to contribute here, so I might as well just write some libdef declaration files :-)

libdef files would be awesome (I wonder which ones are in highest demand and still missing?).
Also if you want to start working on the postinstall downloader script, that would be pretty sweet too

Just an update: It still needs clean-up, but I now have a branch with a working test-runner.
It's still dev-time messy, so I'll work through cleaning up the code tomorrow to get it ready for a PR.

Also possibly worth considering an alternate format for specifying the expected compatible Flow version(s). Right now it's a bit awkward to have directories named things like SomeLib/v1.x/flow-v>=0.20

Test runner PR here: https://github.com/flowtype/flow-typed/pull/15
Still haven't gotten to debugging the Travis issues, but worth reviewing the PR in the meantime if anyone has some time to take a look

Awesome, @jeffmo! I'll take a look in the morning. Thank you!

Can anyone provide a tldr on how to consume, for example, redux definition today.
Is it like

git clone this repo somewhere
Add required definition in [include] section of .flowconfig, or symbolic link to interfaces folder??
It will have a bit awkward path name like definitions/redux_v3.x.x/flow_>%3Dv0.23.x/redux_v3.x.x.js

thanks

@bsr203: Good question. At the moment things are a bit awkward because we haven't shipped the CLI yet (aiming for that next week I hope).
In the meantime, the process is:

Create a dir called flow-typed in the same directory as your .flowconfig file.
Copy the libdef you're interested in from this git repo into that directory.
Profit

Flow v0.24 and later will automatically recognize this flow-typed directory as an entry in [libs] (in other words, no need for config -- just create the directory, put library definitions in it, and Flow will pick them up).
After we ship the CLI, step 2 will be a little less hand-wavy and the workflow will look more like: flow-typed install<EMAIL_ADDRESS>

Copy the libdef you're interested in from this git repo into that directory.

I'm sorry, but I don't quite yet understand what files precisely you mean with "Copy the libdef". I've had trouble recognizing classnames declarations, and I'm not sure how my ./flow-typed/ directory should look like.

Wow, this topic is already reallly really old!
Actually, to answer more appropriately, as @jeffmo already wrote, flow-typed is already released as CLI tool (although it's still in beta).
So what you really should do is:
npm install flow-typed -g
cd your-project

flow-typed install<EMAIL_ADDRESS>-f 0.25

The last command will eventually create your flow-typed directory and put the classnames definition in flow-typed/npm.
If you have an empty lib section in your .flowconfig, flow will automatically look into the flow-typed dir... if you already defined some lib paths, you have to append flow-typed/ to this section (I think the auto-assuming is only available for flow >= 0.25).
Whatever you do, don't copy the files manually, that's just a chore :-)

@splodingsocks @jeffmo ... should we close this issue and maybe change the first README lines with an appropriate show-case example? (thinking about an install command?)

So what you really should do is:
npm install flow-typed -g

Eesh, doesn't seem to be quite easy. Running on OS X El Capitan, npm version 2.15.2 and node v4.4.0, I get this:
$ npm install flow-typed -g
-
><EMAIL_ADDRESS>install /Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/flow-typed/node_modules/nodegit
> node lifecycleScripts/install

[nodegit] Fetching binary from S3.
[nodegit] Failed to install prebuilt binary:
{ [Error: Command failed: /bin/sh -c "/Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/flow-typed/node_modules/nodegit/node_modules/.bin/node-pre-gyp" install --fallback-to-build=false
module.js:327
    throw err;
    ^

Error: Cannot find module 'nopt'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/flow-typed/node_modules/nodegit/node_modules/node-pre-gyp/lib/node-pre-gyp.js:14:12)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
]
  killed: false,
  code: 1,
  signal: null,
  cmd: '/bin/sh -c "/Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/flow-typed/node_modules/nodegit/node_modules/.bin/node-pre-gyp" install --fallback-to-build=false' }
[nodegit] Building manually. (You'll be here a while.)
[nodegit] Regenerating and configuring code
<EMAIL_ADDRESS>/Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/nodegit
├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
[nodegit] Configuring libssh2.
ERROR - Could not generate native code
[TypeError: _(...).forEach(...).value is not a function]
[nodegit] Everything is ready to go, attempting compilation
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: spawn /Users/vesa/.nvm/versions/node/v4.4.0/lib/node_modules/flow-typed/node_modules/nodegit/node_modules/.bin/node-gyp ENOENT
    at exports._errnoException (util.js:870:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)
npm ERR! Darwin 15.5.0
npm ERR! argv "/Users/vesa/.nvm/versions/node/v4.4.0/bin/node" "/Users/vesa/.nvm/versions/node/v4.4.0/bin/npm" "install" "flow-typed" "-g"
npm ERR! node v4.4.0
npm ERR! npm  v2.15.2
npm ERR! code ELIFECYCLE

Do you want me to open a new issue for that?

should we close this issue and maybe change the first README lines

Yea, good idea. Will do in just a second...

Do you want me to open a new issue for that?

Hmm, yes please do. I haven't seen this before so will need some time to dive in

@valscion Hmm... strange, so I could install it successfully with node version 4.0.0... then I tried it with 4.4.0 and it failed for me as well...


fix: elude lifetimes where possible

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.97%. Comparing base (85e0df0) to head (9e255ef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   78.97%   78.97%
=======================================
  Files          52       52
  Lines        6834     6834
=======================================
  Hits         5397     5397
  Misses       1437     1437

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add brand assets

Motivation

Adding new brand assets ✨
Description
You'll need to delete the old ones after, didn't want to remove them yet at risk of breaking live imgs.
suggestions:

use the square icon for touch icon in index.html
when using full mark for web apps, set maxHeight to 40px
stacked mark works well when we're sitting next to other brands :D

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@dapplion we might save & delete a few of the larger files to keep the repo size down. See https://github.com/ChainSafe/lodestar/issues/1554

I'm going to commit over this, removing the MB+ images. I've got them saved locally so we can still use them where desired.


Milestone2 dataset description

Worked on the kaggle mental health data set discription
I created a dir for the data_collection and worked on it

Looks live our research will be hold on several datasets. Maybe it would be wise to make several .md files for each (with corresponding name), and a general README.md for this milestone.
If you agree can you rename Data_Set_Discription.md to Global_Trends_in_Mental_Health_Dataset_Discription.md ?
And we will add addtional descriptions here

Okay I'll work on that

i fixed the file name


Add support for evalulating {{env.}} within a template node

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Proposed changes

This feature adds template node be able evaluate env variables within the mustache template.
It solves adding intermediate change node which is the goto solution.
Very useful in subflow to evaluate the subflow properties.
Checklist

[X] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[X] I have run grunt to verify the unit tests pass
[X] I have added suitable unit tests to cover the new/changed functionality

Coverage decreased (-0.2%) to 68.289% when pulling 01d9affe61efbf35fdeb304985dfc5061d24299e on cow0w:env_evalulating_in_template into 1af56a7f00f6265d28fb5609b70711a708f66423 on node-red:dev.


build-bottle-pr: check existence of the required remote repository

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?

make sure that we have remote repositories before we attempt to build bottles

Looks good. Thanks, Maxim.

So, I'll squash and merge then!


Rename parsers to their function

Instead of having a genericly named css parser, should we name it cssmin as we might also get a criticalcss and uncss? The same holds for the other parsers (htmlmin, imagemin, jsmin).

Currently we run all the parsers at the same time, changing to accommodate this, we could need to control each parser individually to be sure that we could only run criticalcss after cssmin for example.
Why don't we just keep like now, but add criticalcss to the css parser?
It's a more all or nothing optimization for a specific parser.

I like the idea of having small parsers which all do one thing.
How about, when we start criticalcss we extend the parser config object:
parsers: {
  cssmin: {
    pattern: '**/*.css',
    parser: require('./lib/parse-cssmin')
  },
  htmlmin: {
    after: ['criticalcss'],
    pattern: '**/*.html',
    parser: require('./lib/parse-htmlmin')
  },
  criticalcss: {
    after: ['cssmin', 'uncss'],
    pattern: '**/*.html',
    parser: require('./lib/parse-criticalcss')
  }
}

As an analogy Docker does this similarly in docker-compose using dependsOn.


mmcsd: replace cmd12(stop transimission) with cmd23(set block count)

Summary
Impact
Testing

Please fill the Summary/Impact/Testing fields. Please include explanation why to replace CMD12 with CMD23, what is the needs or advantage of doing it.

OK, I will add it in the next few days after I have time, thanks

Please fill the Summary/Impact/Testing fields. Please include explanation why to replace CMD12 with CMD23, what is the needs or advantage of doing it.

CMD12 support should not be replaced or removed. Some cards do not support CMD23. If the cards are removable, this support should be determined at runtime. The driver should check BIT 33 in the SCR register to see if the card supports the command.

Please fill the Summary/Impact/Testing fields. Please include explanation why to replace CMD12 with CMD23, what is the needs or advantage of doing it.

CMD12 support should not be replaced or removed. Some cards do not support CMD23. If the cards are removable, this support should be determined at runtime. The driver should check BIT 33 in the SCR register to see if the card supports the command.

@ldube
hello ldube,  do you mean I should add code like this, and then check if it's zero in mmcsd_writemultiple() ?

@gneworld
Yes, but I would separate CMD20 and CMD23 bits.
CMD23 is bit 33 so you should be testing only one bit.
#ifdef CONFIG_CMD23_SUPPORT
   priv->cmd23_support = ...
#endif

CMD23 support should be off by default.
If a user inserts a card without CMD23 support the behavior of the driver should be identical to what we have today whether CONFIG_CMD23_SUPPORT is defined or not.
The value of cmd23_support should be zero for cards without CMD23 support.
The value of cmd23_support should be zero for all cards if CONFIG_CMD23_SUPPORT is not enabled.
If cmd23_support is zero the sd driver act like it did before your change.

@ldube   Are you sure that bit 33 being 1 definitely indicates support for cmd23? Isn't it possible that some manufacturers use this bit as a flag for supporting other commands?

I got that from a 2010 document :(
I can't guarantee anything, I have not used this feature. Please double check in a new spec if you can find it.

Please fill the Summary/Impact/Testing fields. Please include explanation why to replace CMD12 with CMD23, what is the needs or advantage of doing it.

@acassis
I have fill the Summary/Impact/Testing fields, maybe I should make cmd12 and cmd23 compatible instead of getting rid of it, thanks

@acassis @ldube  please make a review again, thanks


Add golang and .Net to the ootb language subcategories

Fixes https://github.com/openshift/origin-web-catalog/issues/259

@spadgett updated to make tag matching case insensitive


feat: set JWT token field name with saveToJWT

Description
When using API key authentication with 3rd party systems it can sometimes be necessary to have control over the attribute names in the JWT token.
This change widens the type of saveToJWT to be a string that can set the name of the attribute in the JWT token instead of using the field name.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[x] I have made corresponding changes to the documentation

I did a quick search for saveToJWT and I see that it is used in auth/operations/resetPassword and src/collection/graphql, do those files need adjustment? I feel like reset password will, unsure of the graphql file.

Thanks for the review @JarrodMFlesch. I addressed the resetPassword, that was missed. The GraphQL change is not an option unfortunately.
I tried to refactor to allow for the JWT type to support savetToJWT fields inside rows and also the name change feature. The trouble though is that you might might want to have a kebab-case saveToJWT string, but GraphQL doesn't support names that do this.
I wrote this code in src/collection/graphql/init.ts that was trying to handle this change (and have to throw it away):
      const jwtFields = config.fields.reduce((reducedFields, field: Field) => {
        if (!fieldAffectsData(field) && fieldHasSubFields(field)) {
          field.fields.forEach((subField) => {
            if (fieldAffectsData(subField) && subField.saveToJWT) {
              const sanitizedField = subField;
              sanitizedField.name = typeof subField.saveToJWT === 'string' ? subField.saveToJWT : subField.name;
              reducedFields.push(sanitizedField);
            }
          });
        }
        if (fieldAffectsData(field) && field.saveToJWT) {
          const sanitizedField = field;
          sanitizedField.name = typeof field.saveToJWT === 'string' ? field.saveToJWT : field.name;
          reducedFields.push(sanitizedField);
        }
        return reducedFields;
      }, [
        ...authFields,
        {
          name: 'collection',
          type: 'text',
          required: true,
        },
      ]) as FieldAffectingData[];

      collection.graphQL.JWT = buildObjectType({
        payload,
        name: formatName(`${slug}JWT`),
        fields: jwtFields,
        parentName: formatName(`${slug}JWT`),
      });

@DanRibbens oh interesting, we should document that shortcoming in the docs alongside the saveToJWT definition that you added then.

Is it worth it? The actual token will have the same decoded values whether from REST or GraphQL. I don't want there to be any confusion there.
I'm not sure I understand when somebody would use this extra JWT type or if it is even accurate how it is being used in the graphql schema to begin with.


function parameter of type Literal[-1] gives incorrect error

Environment data
Pylance language server 2020.8.1 (pyright 0916fb9e)
def foo(neg1: Literal[-1]) -> None:
    pass

def bar(pos1: Literal[1]) -> None:
    pass

# the following results in error:
#     "int" cannot be assigned to type "Literal[-1]"Pylance
foo(-1)

# this is ok
bar(1)

Expected behaviour
No error for foo(-1) above
Actual behaviour
"int" cannot be assigned to type "Literal[-1]"Pylance

Thanks for the bug report. The type evaluator wasn't properly evaluating the type of expressions with unary +/- operators and integer literal operands. These should result in a literal type, but the literal value was being omitted when the unary expression was applied. I've fixed it in a way that +/- operations can be applied in a chained manner (e.g. "-(-++(-3))" evaluates to the type "Literal[-3]".

This issue has been fixed in version 2020.8.2, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202082-20-august-2020


Removed common now oas-kit does all that

Coverage increased (+0.5%) to 86.835% when pulling e3edb1d2f972d60568b14c37c7a1ad2677295ed6 on remove-common into 5bf62c53c26cf1bacee9bd62fc2016cc4e0bf88c on release/0.8.0.

Coverage increased (+0.5%) to 86.835% when pulling e3edb1d2f972d60568b14c37c7a1ad2677295ed6 on remove-common into 5bf62c53c26cf1bacee9bd62fc2016cc4e0bf88c on release/0.8.0.

Coverage increased (+0.5%) to 86.835% when pulling e3edb1d2f972d60568b14c37c7a1ad2677295ed6 on remove-common into 5bf62c53c26cf1bacee9bd62fc2016cc4e0bf88c on release/0.8.0.

Coverage increased (+0.5%) to 86.835% when pulling e3edb1d2f972d60568b14c37c7a1ad2677295ed6 on remove-common into 5bf62c53c26cf1bacee9bd62fc2016cc4e0bf88c on release/0.8.0.


HTTPCLIENT-2293: Via header improvements

ResponseCachingPolicy optimized to generate less intermediate garbage while paring Via headers
Via request and response header generation moved from the caching exec interceptors into separate protocol interceptors

@arturobernalg Please take a look


Fix issue with unavailable server retry codes

Currently when populating the list it checks for >500, this should be 499 to not exclude 500
Also adding warnings during token parsing to notify if a user has added an erroneous err code to the unavailable or simple codes list

Cherry-picked to v9.0.x branch.


feat: add KITTY_SCROLLBACK_NVIM_TMUX env var

[x] TODO: add test for presence of KITTY_SCROLLBACK_NVIM_TMUX in a tmux session

doesn't work on linux runner
approach won't work without TMUX_PANE env var


fix gui timer cancellation

the timer cancellation per gui didn't work as expected. Always the first timer in the timer list was cancelled due to a call to _cancel_single_timer()
Fixes:

deletes the timer properly
does away with the "cancel all" workaround (TimerCard.qml) when only one timer is present and should be removed
pickles properly (so it doesn't  _load_timers() on skill reload)
updates the widget

tested both with unnamed and named timers

@builderjer made the request in chat i should add a hearable confirmation on gui timer cancellation.
Since i have no stakes in this, make the call.


Implement Stalebot

Codecov Report

Merging #36 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   60.33%   58.95%   -1.38%
==========================================
  Files          23       23
  Lines         653      653
  Branches       27       27
==========================================
- Hits          394      385       -9
- Misses        253      262       +9
  Partials        6        6

Impacted Files
Coverage Δ

src/app/core/models/package.model.ts
35.13% <0%> (-8.11%)
:arrow_down:

src/app/core/services/package.service.ts
37.59% <0%> (-4.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31c282...8864e3e. Read the comment docs.


Add ImageNet-Sketch dataset

This PR adds the ImageNet-Sketch dataset and resolves #3953 .

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I think you can go ahead with uploading the data, and also ping the author in parallel. I think the images may subject to copyright anyway (scrapped from google image) so the dataset author is not allowed to set a license to the data.
I think it's fine to upload the dataset as soon as we mention explicitly that the images may be subject to copyright.


PowerToys Overwrites Windows Precision Touchpad Settings

Environment
Windows build number: 10.0.18363.836
PowerToys version: 0.18.0

Steps to reproduce
Installed PowerToys. All modules were enabled.
Expected behavior
Since there is no module that involves the touchpad, I would expect the touchpad to function as it was prior to installed PowerToys.
Actual behavior
My Windows precision touchpad's three-finger tap and four-finger tap are permanently remapped. The three-finger tap now opens the Project panel and the four-finger tap does nothing. Uninstalling PowerToys fixes the issue. I tried changing the settings with PowerToys installed and running, but this does not fix it.

we don't touch any OS settings like this.

Does the behavior also happen if PowerToys is not running?

we synced with the team, nothing we are doing would mess with OS settings.  We override a shortcut here or there but that is all done in-memory.
Did you install anything else recently?

I'm seeing this behavior as well. Turning off the key remapping PowerToys fixes 3 and 4 finger taps, but it seems to be because of remapping the left control key. Remapping to left alt makes 3 and 4 finger taps not work. Remapping to a (just to test things out) does something weird with the activity center. Remapping to b doesn't break things. Hopefully this helps further diagnosis.


Add simple action to activate GH actions

This PR adds a simple action to activate GitHub Actions (ref https://github.com/dask/dask/pull/5617#issuecomment-556158572)

Thanks.


Downloading ImageNet21k-OVR

Thank you for sharing your code. However, I noticed that the download link for imagenet21k-OVR (including shot_64-seed_1.pkl) is not provided in the repository. Would it be possible to share the link? It would be greatly appreciated.

I have uploaded the dataset to the huggingface. Please manually download the files from https://huggingface.co/datasets/zehongma/ImageNet21k_OVR


Force browser closing in case of active downloading is in progress

If browser currently is in progress of any file downloading, attempt to close browser from Selenide before downloaing end process may be failed.
If it is possible, please force browser closing.
Tell us about your environment

**Selenide Version 6.7.4:
Firefox 102:

Screenshot of the dialog:

@ilya-corp I think there should be some option for Firefox to avoid this dialog. Can you google for such an option?

FYI I found a collection of all podible chrome options:
https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md

I'm not sure what will work, but it can be useful if you want to abort the download of the file and close the browser without waiting for the complete download, then you can try using a separate thread to download the file and abort its execution
As example:
Thread downloadThread = new Thread(() -> {
Selenide.$("a.download-button").click();
Selenide.downloads().getDownloadedFile("file.txt");
});
downloadThread.start();
try {
downloadThread.join(Duration.ofSeconds(15).toMillis());
} catch (InterruptedException e) {
}
if (downloadThread.isAlive()) {
downloadThread.interrupt();
}
Selenide.closeWebDriver();

@jazzboy65 I think it doesn't help. Even if you stop the thread that is waiting for the file, browser still continues the download process. The question is, how can we say browser "please stop".

Is it possible to identify PID of the browser and kill process?


CLOUDSTACK-9244 Fix setting up RFC1918 routes

Public ip var was empty so routes were always set. Corrected this.

Fixed my problem, my routing tables are now looking as I expected.
Thanks

If this helps @nislim And is tested it should go in.
I feel uncertain of this functionality. It is called from sestro and console proxy setup functions but the code is also present in those functions. I think the lines 1195 and 1252 should be removed and the functionality abstracted out.

@DaanHoogland I think we agree cloud-early-config needs major refactoring as it is one big copy/paste thing. Just don't think this is the time to do it.
All this does is pickup the public ip address and use it, like other parts also do.

Discussed with @DaanHoogland and he sent me a patch ;-)

@nislim Can you please test the enhanced patch?

cloud-early-config now logs:
Not setting up route of RFC1918 space to <IP_ADDRESS> befause <IP_ADDRESS> is RFC1918..

Routes are not set as expected:
root@v-85-VM: # route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
<IP_ADDRESS>         <IP_ADDRESS>    <IP_ADDRESS>         UG    0      0        0 eth2
<IP_ADDRESS>     <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 eth0
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth1
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth2

And when it has a real public ip a route is set to the internal gw. That functionality still works and didn't change.
Setting up route of RFC1918 space to <IP_ADDRESS>

Routes are setup now:
root@v-1357-VM: # route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
<IP_ADDRESS>         x.y.227.1       <IP_ADDRESS>         UG    0      0        0 eth2
<IP_ADDRESS>        <IP_ADDRESS>    <IP_ADDRESS>       UG    0      0        0 eth1
<IP_ADDRESS>     <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 eth0
<IP_ADDRESS>      <IP_ADDRESS>    <IP_ADDRESS>     UG    0      0        0 eth1
<IP_ADDRESS>     <IP_ADDRESS>    <IP_ADDRESS>     UG    0      0        0 eth1
<IP_ADDRESS>    <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth1
 x.y.227.0      <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth2

looks good

Same result with the refactored code:
root@v-23-VM:~# route -n
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
<IP_ADDRESS>         <IP_ADDRESS>     <IP_ADDRESS>         UG    0      0        0 eth2
<IP_ADDRESS>       <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth1
<IP_ADDRESS>       <IP_ADDRESS>         <IP_ADDRESS>   U     0      0        0 eth2
<IP_ADDRESS>     <IP_ADDRESS>         <IP_ADDRESS>     U     0      0        0 eth0

Code looks good to me