No data in response.

Hi,
I installed this on a test grafana instance at work and hooked it up to snowflake.
I can see the query going out to snowflake and returning results, but there's no data being plotted on the graph.
I've attached the panel JSON and the query JSON from the query inspector.
panel.txt
query.txt

Hi,
Can you please give me your Grafana version ?
Do you see the data in the Query inspector panel (In the Data tab) ?

It's current development version Grafana v8.1.0-pre (9b518669dd) from git clone.
The data tab says there's no data.

However the query tab says there is:

I have not yet tested with the current development version of Grafana.
Can you try with the latest stable version if you have the same issue ?

The same query works fine in Grafana v7.5.7 (91de51771c)
Interestingly the response looks different in this version:

I have tried yesterday with the latest nightly build without issues https://grafana.com/grafana/download/8.1.0-23487pre.
The UI is not the same as the one in your capture https://github.com/michelin/snowflake-grafana-datasource/issues/1#issuecomment-847681918, maybe you have an issue with the frontend when you built it from source.

If that's the case, that would be really embarrassing. I'll check it out.

That's what was wrong, I wasn't putting the public files into the correct directory in my docker container, so it was using the old interface instead of the new one.
When I put it in the correct directory it all works fine.
How awkward :(


Explicitly specify where tcmalloc comes from

This change adds a declaration that libtcmalloc_minimal.a is generated
by the external project. This is needed by the Ninja generator to
properly build.
To reproduce:
run cmake -GNinja path/to/quickstep
then cmake --build path/to/build/dir and see it fails.

@d. Ok -- I'm rethinking this PR as it builds now in the third_party/gperftools rather than under the build directory. Would you be ok if we revered this PR, by commenting out the change, so that if you need you can build. I think the common case is now broken.

Yes @pateljm please revert if the change blocked everybody else or broke the build. But can you show me a travis link where it was broken?

Just came back from manual testing, and I can confirm that the Makefile generator will not pollute your source tree with tcmalloc static library files


Set friendlier zstd options

During a recent deploy, we noticed that our encoding options were no longer being set for the zstd encoder and decoder. The lack of these options almost 2x'ed our memory usage. Given that this library is used mostly for RPC, we thought it would be good to upstream these so that everyone could see reduced memory usage.

For what it's worth, I did some profiling of the OTel collector before and after the change in this PR. Below are the screenshots of a flamegraph of the heap profile for each run.
Before (~160MB spent in ensureHist):

After:


Reduce memory allocation for AnalyticReporter service

I created this service for calculating data for admin charts. But I think we can make this code better.
It's a not easy task

I can try


Starting to add some real doc

Adding a lot of documentation for:

load a dataset
explore the dataset object
process data with the dataset
add a new dataset script
share a dataset script
full package reference

Also:

fix a bug in train_test_split
update the csv script
add a verbose argument to the dataset processing methods

Still missing:

doc for the metrics
how to directly upload a community provided dataset
add the features argument to load_dataset (should be another PR)

Ok this is starting to be really big so it's probably good to merge this first version of the doc and continue in another PR :)


Use "x mod 1" to generate [0, 1)-uniform random

Fix #1614.

Jenkins, test this please.

Jenkins CI test (for commit 47570d6815f34d3336a125cb69d61536889960a7, target branch master) succeeded!

So clever, LGTM!


Fix - NPE when recover route from queue properties.

Motivation
PersistentQueue.routers is empty before add queue.
PersistentQueue
amqpQueueProperties.stream().forEach((amqpQueueProperty) -> {
            // recover exchange
            String exchangeName = amqpQueueProperty.getExchangeName();
            Set<String> bindingKeys = amqpQueueProperty.getBindingKeys();
            Map<String, Object> arguments = amqpQueueProperty.getArguments();
            CompletableFuture<AmqpExchange> amqpExchangeCompletableFuture =
                    exchangeContainer.asyncGetExchange(namespaceName, exchangeName, false, null);
            amqpExchangeCompletableFuture.whenComplete((amqpExchange, throwable) -> {
                AmqpMessageRouter messageRouter = AbstractAmqpMessageRouter.
                        generateRouter(AmqpExchange.Type.value(amqpQueueProperty.getType().toString()));
                messageRouter.setQueue(this);
                messageRouter.setExchange(amqpExchange);
                messageRouter.setArguments(arguments);
                messageRouter.setBindingKeys(bindingKeys);
                amqpExchange.addQueue(this).thenAccept(__ -> routers.put(exchangeName, messageRouter));
            });
        });

PersistentExchange
    @Override
    public CompletableFuture<Void> addQueue(AmqpQueue queue) {
        queues.add(queue);
        if (exchangeType == Type.Direct) {
            for (String bindingKey : queue.getRouter(exchangeName).getBindingKey()) {
                bindingKeyQueueMap.compute(bindingKey, (k, v) -> {
                    if (v == null) {
                        Set<AmqpQueue> set = new HashSet<>();
                        set.add(queue);
                        return set;
                    } else {
                        v.add(queue);
                        return v;
                    }
                });
            }
        }
        updateExchangeProperties();
        return createCursorIfNotExists(queue.getName()).thenApply(__ -> null);
    }

NPE
queue.getRouter(exchangeName) is null
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

can you describe how to recreate it?

Test setp

Use rabbitmq client create exchange, queue and then bind.
Send and receive some message.
Restart amqp broker.
Use rabbitmq client connect broker to receive message, but not declare queue, exchange.
Use rabbitmq client connect broker to send message, but not declare queue, exchange.

Expect result
Client can receive message.
Currently result
Client can not receive message.
If you add try/catch on code PersistentQueue -> recoverRoutersFromQueueProperties, you will see a NPE in amqpExchange.addQueue(this).thenAccept(__ -> routers.put(exchangeName, messageRouter));.
The reason is PersistentExchange -> addQueue need PersistentQueue.routers, but PersistentQueue.routers is empty in recovery logic.


Performed EDA: Handled Missing Values and Outliers in Stock Price Data

I have handled the data quality issues in the stock price dataset and fixed the problems related to missing values and outliers mentioned in issue #137 :
Fixes: #137
Handling Missing Values:
Used forward fill (ffill) to fill missing values in the Open, High, Low, Close, Adj Close, and Volume columns, ensuring data continuity for time-series analysis.
Outlier Treatment:
Applied the Interquartile Range (IQR) method to detect and cap outliers in the stock price columns, preventing distortion from extreme values and creating a more reliable dataset.
These fixes enhance the dataset's quality, making it ready for further analysis and predictive modeling.
Before:

After:

Added documentation to enhance code readability :

I’ve handled missing values and outliers and added some documentation.
Have a look at it, review it, and kindly accept my PR! @rohitinu6

@Mayureshd-18 Thanks for the approval! Please add the gssoc-ext, hacktoberfest, hacktoberfest-accepted, and suitable level labels, and kindly merge it to close the issue. @rohitinu6

@rohitinu6 @Mayureshd-18
Thanks for approving. The issue seems fixed, so please merge my PR and close the issue.

@rohitinu6 @Mayureshd-18
Also, please label it as level 2, as it matches the difficulty level of data refinement.  and outliers handling

@RB137 The assigned level 1 is appropriate based on the root objective which is the refinement of code. Higher levels are reserved for new algos and procedures.
Thanks for understanding! Merging!


Login / Forgot Password - Link to return to main login screen is not clear for the user

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to e.cash
Enter an email for an existing user
Click on Forgot? link

Expected Result:
There should be clear message for the user to return to the main login screen like Not <email>? Sign in with email and password.
Actual Result:
There's a link with Not<EMAIL_ADDRESS>which can be unclear to the user.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Web ✔
iOS✔
Android✔
Desktop App✔
Mobile Web✔
Version Number: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @rafecolton https://expensify.slack.com/archives/C01GTK53T8Q/p1626290568254500

It is also not obvious how to get to the screen where I can log in with a password, so I suggest we updated the text below the button to something like Not ? Sign in with email and password.

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposed fix is to change the text to Not<EMAIL_ADDRESS>Sign in with email and password. @Expensify/design any thoughts on this issue?

I think it is too big. My suggestion Not<EMAIL_ADDRESS>switch here| change here | change it

The problem with that is it's confusing if the email address is correct, which is the use case that prompted this issue.

Proposed fix is to change the text to Not<EMAIL_ADDRESS>Sign in with email and password. @Expensify/design any thoughts on this issue?

Hi @rafecolton,  Sign in with email and password. looks little wrong since User can in fact choose to sign in with Phone Number as well.
And as we're basically going back to the signup page. I think a better solution would be Not<EMAIL_ADDRESS>Go back.
and We can wrap only the Go back text with TouchableOpacity.
It will look like this :

hi there, I'm noticing that the font here isn't our brand font GT America Exp Regular, not sure what's causing that?
I'm fine with the "go back"  but I wonder if we should edit the line above, Just click on it to log in! reads a bit confusing with  the big button below. Maybe We've sent a magic sign in link to your email.  instead?
cc @Expensify/marketing

I like the sound of We've sent a magic sign in link to your email. better, and I'm also fine with "Go back." - good call @aman-atg about being able to log in with a phone number too. Pulling in somebody from marketing to comment on exact words and capitalization/punctuation.

Triggered auto assignment to @nicktooker (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

I'm good with "We've sent a magic sign in link to your email." and "Go back."  Thanks!

@NickTooker, @isagoico Whoops! This issue is 2 days overdue. Let's get this updated quick!

@NickTooker, @isagoico 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

I've confirmed the copy for this issue, removing myself while we wait for it to be deployed - thanks!

@isagoico Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@rafecolton , Can I take on this issue. It has been already delayed a lot.

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Thanks @aman-atg - looks like @mallenexpensify will be the sherpa for this issue and getting it assigned over to you.

Please confirm the translations.
English

We've sent a magic sign in link to your email.
We've sent a magic sign in link to your phone number.

Spanish

Hemos enviado un enlace de inicio de sesión mágico a su email.
Hemos enviado un enlace de inicio de sesión mágico a su número de teléfono.

Mmm the Spanish translations are not entirely correct:

Hemos enviado un enlace mágico de inicio de sesión a tu email
Hemos enviado un enlace mágico de inicio de sesión a tu número de teléfono
Regresar

Thanks for correcting them.

Putting on hold for week-ish while we focus on internal priorities.

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

The process wasn't precisely followed here. @NikkiWines, can you

Review @aman-atg's proposal and, if you approve it then review @aman-atg's
If you don't approve, drop in a comment here.

Job is posted here https://www.upwork.com/jobs/~01857c14c7be600717, invited you to apply @aman-atg
Also took this job off hold

Review @aman-atg's proposal

I didn't officially add a proposal but this is the comment where I proposed a solution. https://github.com/Expensify/App/issues/4111#issuecomment-884817325

and if you approve it then review @aman-atg's

I think we meant PR here, it's ready for review : https://github.com/Expensify/App/pull/4644

Yep! @aman-atg's proposal looks good 👍, will review the PR today

Hired @aman-atg in Upwork.  Heads up @aman-atg , as stated in #expensify-open-source last week, it might take a lil longer for us to move this along due to some internal priorities, please be patient.

@NikkiWines, @mallenexpensify, @isagoico it looks like no one is assigned to work on this job.
Please double the price or add a comment stating why the job isn't being doubled.

This job is completed. Paid @aman-atg  in Upwork


Сreating a federated plugin

:memo: Links to relevant issues/docs
#8

Writing Yookassa SDK Platform Interface

[ ] Russian documentation for the code
[ ] Minimum tests
[ ] Changelog
[ ] License
[ ] Russian readme

Writing Yookassa SDK for Android

Need to add an example of using the plugin.


The scrollbar still displays on Account Panel after maximizing Storage Explorer

Storage Explorer Version: 1.1.0 RC
Platform: Windows/Linux/Mac
Architecture: ia32/x64
Build Number: 20180507.1
Commit: bcc8990d
Regression From:  Not a regression
Steps to Reproduce:

Launch Storage Explorer and sign in with your account.

Maximize Storage Explorer and check whether scrollbar displays on Account Panel or not.

Expected Experience:

No scrollbar displays on Account Panel after maximizing Storage Explorer.
Actual Experience:

The scrollbar still displays on Account Panel after maximizing Storage Explorer.

The scrollbar is there because the subscription text overflows horizontally. You can resize the panel.


monitor all Organisations on Veeam Server

Hi Stefan
How can I customize the script so that it monitors all organizations in Veeam? If I want to monitor all 40 organizations individually, the requests overload the server.
Best regards
Monika

I have the same problem and need a solution across all organizations. Additionally, I encounter an issue when adding more than 4-5 organizations: the sensor status fluctuates between UP and Warning, displaying the following message:
"XML: The returned XML does not match the expected schema. (code: PE233) -- JSON: The returned JSON does not match the expected structure (Invalid JSON.). (code: PE231)"
Any insights or solutions would be appreciated.

Hi Stefan How can I customize the script so that it monitors all organizations in Veeam? If I want to monitor all 40 organizations individually, the requests overload the server.
Best regards Monika

Hi Monika
Just to be sure. You would like to use the skript without the -orgName parameter and then have the results for all companies in one sensor. Right?
The actual skript overloads the which server? The Veeam server or the PRTG Server?

Hello Steff
Yes exactly, I want to use the script for all organizations in Veeam.
If I enter each organization with its own sensor, I get the same error as Florian reported yesterday from the fifth organization onwards. I think the Veeam server is then overloaded with the requests.
Kind regards
Monika

Hello Monika
Would you mind to set the sensor to save the result and post it here?

What info would you like to get if the skript pulls the info for every company?
Does the skript work if you set -jobsOnly $true ?

Hello Steff
The individual jobs work with the “Save result” setting. I have already created 14 and they are all green!
The parameter -jobsOnly $true does not work.
For a “general” script, the information of the current “individual” jobs would be sufficient. So the status, last execution, transferred and the information of the repositories.
But since the individual ones now work, I no longer need the script with all organizations. :-)
Thank you very much for your help!

Hello Steff
I celebrated too soon. The errors (currently still warnings) are back:

Hi Monika
Could you please post the saved result for one of the failed sensors? Make sure to delete any sensitive data ;-)

Store result: Store the last sensor result in the \Logs\sensors subfolder of the PRTG data directory on the probe system. The file names are Result of Sensor [ID].txt and Result of Sensor [ID].Data.txt. This setting is for debugging purposes. PRTG overwrites these files with each scanning interval.

Hi Steff
Enclosed are the desired logs:
Result of Sensor 21818.txt
Result of Sensor 21818.Data.txt
Kind regards,
Monika

Hello Steff
The script can be executed directly in PowerShell. However, as soon as there are more than 5 sensors, the script also fails directly from PowerShell.
The organization exists in Veeam. The script works perfectly if I “only” use 5 sensors. But as soon as there are more than 5, the Veeam server blocks and apparently can no longer find the organization.
The PRTG server is Windows Server 2016 and the Veeam server is Windows Server 2022

OK Perhaps this may help
https://helpcenter.veeam.com/docs/vac/rest/throttling_config.html?ver=81
or eventually this?
#2

OK. I'll try to make a script or switch to get all last backup state into one sensor. But this may take some time...

Hello Monika
Just got a quick question. Do you have multiple jobs per organization configured? Actually the script does only work with one job per organization.
Kind regards
Stefan

Hi Stefan
No, we only have one job configured per organization. So that would be enough for us.
Kind regards
Monika


No easing setting

There no way to set the easing in beta 3. Let's look at line 886-889 of the unminified source:
this.$stage.css({
    transform: 'translate3d(' + coordinate + 'px,0px,0px)',
    transition: (this.speed() / 1000) + 's'
});

Nothing about easing. The transition property is literally just the time (free tip: can more easily be written in ms so you don't have to divide by 1000). No effort is made to set the easing, leaving it up to the browser to decide which to use.

At the very least I think the transition property should be updated to transitionDuration to allow controlling the transition-timing-function in our own stylesheet. The use of the shorthand transition property is overriding my attempts to do so.

That would fix it too, I suppose. Altough inline styles are overridable using !important if need be, however ugly that is ;)

This is a good feature to have so I'm opening it up for development.


problem

thank you for sharing this code ，I want to run your code ，but I miss  this problem ，can you solve it?
File "D:/deeplearning/DeepDenoisingAutoencoder-master/python/main.py", line 122, in
main()
File "D:/deeplearning/DeepDenoisingAutoencoder-master/python/main.py", line 70, in main
data_num=data_num, ADD_CLEAN=True, cpu_cores=ncores)
File "D:\deeplearning\DeepDenoisingAutoencoder-master\python\preprocessing.py", line 57, in gen_noisy
pool.map(func, num_list)
File "E:\anaconda\lib\multiprocessing\pool.py", line 288, in map
return self._map_async(func, iterable, mapstar, chunksize).get()
File "E:\anaconda\lib\multiprocessing\pool.py", line 670, in get
raise self._value
ParameterError: data must be floating-point

You have to make sure your data type which is float32.

I have changed the data type to float32, but I still get an error

Remove float32

Remove float32

I met this problem that made me cry. So, is there any solution for this problem?


nightly Pepr test intermittent failure

Describe what should be investigated or refactored
The store test on the e2e excellent examples intermittently fail
Links to any relevant code
(optional) i.e. - https://github.com/defenseunicorns/pepr/blob/24f1f253b1db4c9d97717c0282b8f39c74d3ace1/README.md?plain=1#L3

Additional context
Add any other context or screenshots about the technical debt here.

This is not an issue. We have a story related to store.clear() but this is not related.


Style is not working for QR code image

I have added qrc-class. but css style is not working.

its working now


[VEW-03M] Insufficient Enforcement of Minimum Vesting Duration

VEW-03M: Insufficient Enforcement of Minimum Vesting Duration

Type
Severity
Location

Logical Fault

VotingEscrow.sol:L303

Description:
The VotingEscrow::mint function will ensure that the input vestingDuration is not less than the MIN_VESTING_DURATION, however, this validation can be circumvented by:

Creating a deposit of 1 wei with the MIN_VESTING_DURATION specified
Vesting the token ID via the VotingEscrowVesting contract for MIN_VESTING_DURATION - 1 seconds
Withdrawing the token ID via VotingEscrowVesting::withdraw and resulting in a VotingEscrow entry with a 1 value as the _remainingVestingDuration
Depositing an arbitrary amount of funds, thereby inflating the user's voting power whilst reserving funds for a very small amount of time

Impact:
A user can reserve a significant amount of funds for only one second and participate in governance which closely resembles flash-loan based manipulation attacks and thus is deemed of medium severity.
Example:
/**
 * @notice Mints a new voting escrow NFT to a receiver with a specified locked balance and vesting duration.
 * @dev Creates a new token representing locked tokens in the VotingEscrow contract. The amount of locked tokens and
 * vesting duration determine the voting power of the NFT. Reverts if locked balance is zero or if the vesting
 * duration is outside the allowed range. Transfers the locked tokens from the sender to the contract.
 * @param receiver The address to receive the newly minted NFT.
 * @param lockedBalance The amount of tokens to be locked.
 * @param vestingDuration The duration for which the tokens will be locked.
 * @return tokenId The unique identifier of the newly minted NFT.
 * @custom:error ZeroLockBalance Indicates that the locked balance is zero.
 * @custom:error InvalidVestingDuration Indicates that the vesting duration is outside the allowed range.
 */
function mint(address receiver, uint256 lockedBalance, uint256 vestingDuration)
    external
    returns (uint256 tokenId)
{
    if (lockedBalance == 0) {
        revert ZeroLockBalance();
    }
    if (vestingDuration < MIN_VESTING_DURATION || vestingDuration > MAX_VESTING_DURATION) {
        revert InvalidVestingDuration(vestingDuration, MIN_VESTING_DURATION, MAX_VESTING_DURATION);
    }
    tokenId = _incrementAndGetTokenId();
    VotingEscrowStorage storage $ = _getVotingEscrowStorage();
    $._mintingTimestamp[tokenId] = clock();
    _mint(receiver, tokenId);
    _updateLock(tokenId, lockedBalance, vestingDuration);
    lockedToken.safeTransferFrom(msg.sender, address(this), lockedBalance);
}

/**
 * @notice Burns a voting escrow NFT and unlocks the associated tokens.
 * @dev Destroys a token and releases the locked tokens to a specified receiver. Reverts if the vesting period of
 * the token is not yet finished. Transfers the previously locked tokens to the receiver upon successful burning of
 * the token.
 * @param receiver The address that will receive the unlocked tokens.
 * @param tokenId The unique identifier of the NFT to be burned.
 * @custom:error VestingNotFinished Indicates that the vesting duration for the token is still ongoing.
 */
function burn(address receiver, uint256 tokenId) external {
    VotingEscrowStorage storage $ = _getVotingEscrowStorage();
    if ($._remainingVestingDuration[tokenId] != 0) {
        revert VestingNotFinished();
    }
    uint256 _lockedBalance = $._lockedBalance[tokenId];
    _updateLock(tokenId, 0, 0);
    _burn(tokenId);
    lockedToken.safeTransfer(receiver, _lockedBalance);
}

/**
 * @notice Deposits additional tokens to extend the lock for a specific tokenId.
 * @dev Allows additional tokens to be locked, increasing the voting power of the specified tokenId. The function
 * updates the locked balance and maintains the same vesting duration. This is useful for increasing the locked
 * amount without altering the vesting period. Transfers the additional tokens from the sender to the contract.
 * @param tokenId The unique identifier of the NFT representing the locked tokens.
 * @param amount The amount of additional tokens to be locked.
 */
function depositFor(uint256 tokenId, uint256 amount) external {
    VotingEscrowStorage storage $ = _getVotingEscrowStorage();
    _updateLock(tokenId, $._lockedBalance[tokenId] + amount, $._remainingVestingDuration[tokenId]);
    lockedToken.safeTransferFrom(msg.sender, address(this), amount);
}

Recommendation:
We advise the code to prevent deposits for partially vested entries that have fallen below the MIN_VESTING_DURATION limit thus preventing manipulations of voting power as described.

Acknowledged, but I disagree with it being an issue. Note, that the voting power depends on the locked amount and the remaining lock duration. Let's say you manage to actually get your lock duration down to 1 second and you lock up 1 million Pearl:
voting power = 1,000,000 * 1 second / 104 weeks
voting power = 1,000,000 * 1 second / 728 days
voting power = 1,000,000 * 1 second / 17,472 hours
voting power = 1,000,000 * 1 second / 1,048,320 minutes
voting power = 1,000,000 * 1 second / 62,899,200 seconds
voting power = 0.015898453

So you spend an insane amount of money to get a voting power that will barely move the needle. I think the voting power calculation accounts well for those cases.


Corrected related links and Description text

Added in description that you need to connect to the satellite location and corrected the related link to point from (get to set cmdlet).

Docs Build status updates of commit 1930d88:
:clock10: Full build: the average full build time is 11 min(s) 51 sec(s), this is based on the last 981 build(s) for this repository.

Docs Build status updates of commit 1930d88:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantTaxonomyReplicationParameters.md
:warning:Warning
View (sharepoint-ps)
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantTaxonomyReplicationParameters.md

[Warning] Invalid file link:(~/sharepoint-ps/sharepoint-online/Connect-SPOService).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


'Local Pods' question

@rnystrom, am i right that 'Local Pods' are somehow modified copies of libraries?
If so i think that in long-term perspective this 'll bring too much pain since it'll be hard to keep them up-to-date and make additional changes.
I suggest flow where:
— We try to isolate and get shared knowledge of which modifications were made to those libs
— We create fork per library and try to merge our needed change to upstream if possible (if not — just keeping our forks up-to-date)

re: changes, those are easy to find via the history:
https://github.com/rnystrom/GitHawk/commits/master/Local Pods/SlackTextViewController
re: fork, I'm ok with this but also don't want to be the one to do it 😆 I'm more concerned about keeping this project moving w/out getting distracted. If you want to manage it, you've got my support!
Some notes:

SlackTextViewController is basically dead
My changes to SwipeCellKit are basically copy/pasting and replacing UITableViewCell with UICollectionViewCell. I tried finding an easy change to contribute back, but the lib is pretty coupled to UITVC, and I didn't want to spend weeks just for this.
My changes to MMMarkdown break its behavior (some things commented out, replaced) but most updates would be great upstream (e.g. Swift interop). Lib is hella old and has no CocoaPods.

Maybe a better idea is to fork them to the @githawkapp org and maintain them there?

+1 on moving forks to @GithawkApp if we take that route 👍

not sure who should get an ownership for forks. Maybe there is a need to setup Organization for GitHawk?

@Austinate see @githawkapp 😉

@rnystrom ah, silly me! 🙃

so i'm in for switching to forks and can't take this. Won't be easy, but better to make it now than later

Ya, I'm down w/ this

awesome, i'll start playing around with forks while someone will manage Organization access and forks on it's side


Detect in-progress rebases during repository normalization

Within M-x straight-normalize-package, we should check if there is a rebase in progress, and handle appropriately (much like we already do for checking if there is a merge in progress). This issue replaces a long-standing FIXME notice in the code for straight.el:
https://github.com/raxod502/straight.el/blob/eb2da3dcd590e258578203a112b894fa98e98944/straight.el#L1369-L1388

See code in Magit:
(defun magit-rebase-in-progress-p ()
  "Return t if a rebase is in progress."
  (or (file-exists-p (magit-git-dir "rebase-merge"))
      (file-exists-p (magit-git-dir "rebase-apply/onto"))))

Fixed by #711


Introduction of Non-ES5 APIs in ES5 Output in 7.5.5

Describe the bug
The most recent 7.5.5 release which includes #6842, introduces usage of Array.from() in Subject.prototype.next().
It may have been present in other areas of the codebase previously, but our codebase hits this path regularly, so it was noticed immediately on upgrade to this version.
We have to support older ES5 runtimes back to circa 2015 webkit browsers (for smart TVs), and avoid excessive polyfilling for performance and bundlesize reasons. Due to the fact RxJS is transpiled to ES5 by default, we've never had runtime issues on these platforms before. However on upgrade to 7.5.5 the absence of these more modern APIs now require that we polyfill around RxJS. Because we do not know which non ES5 APIs are in use, this is a somewhat difficult and risky task (if we miss something, we may experience fatal runtime errors).
What is the intention here? Should ES5 output be limited to ES5 APIs only, or should we be polyfilling?
Thanks!
Expected behavior
RxJS ES5 output should be limited to usage of ES5 language features and APIs only.
Reproduction code
No response
Reproduction URL
No response
Version
7.5.5
Environment
ES5 runtimes
Additional context
No response

In my opinion, this looks unexpected mistake - we are supposed to support IE11 with version 7, and actual deprecation would be in v8. @benlesh thoughts?

Any update on this? Thanks

CORE TEAM: We should fix this in v7... v8 gets rid of ES5 support, so it's a non-issue there.


Add Entity.getById() and entity.save() methods

This introduces the following changes:

The generated SomeEntity constructor now requires an ID to be provided (e.g. new Collateral('some-id')). This is a breaking change that guarantees there is always an ID.

A new static method SomeEntity.getById(id: string): SomeEntity | null is generated for entity types, preventing developers from having to call store.get('SomeEntity', id) and then having to cast the return type from Entity | null to SomeEntity | null, which is not obvious.

A new someEntity.save() method is generated for entity types. It is a simple wrapper around store.set('SomeEntity', id, entity). Makes life a little easier for developers and also asserts that there is a value for id.

This a much nicer API! What about renaming getById to something simpler like get or find?
We should be careful with generating constructors of subclasses (like we do now with Entity) because they won't call the super constructor. And calling super() doesn't in AS right now.

@leodasvacas Agree about being careful about constructors.
My first thought was get but then that conflicts with the get method inherited from TypedMap. find could work but I'd like to keep the available for more powerful queries later. How about findOne?

Other idea: SomeEntity.getOne(id: string)

If we're going w/ an ORM-style API, I think of fetch or load as being the inverse operations of save.

@leodasvacas @Zerim Changed it to SomeEntity.load(id). Remember that this still uses store.get() and store.set() under the hood, so these two methods are just convenience wrappers.

Otherwise it looks good to me. I would have liked to have tested the subgraph, but I guess that contract doesn't exist anywhere in the real world .

@davekaj I've made the changes you've asked for.


Font rendering

Rinvid needs ability to render fonts. For this issue to be closed, the following needs to be done:
-Render ttf functionality should be added.
-Add label element to GUI package.
-Showcase font rendering in testing_grounds
-Create separate GUI example showcasing buttons and labels. (OPTIONAL)
Would appreciate if someone would take this on.

PR: #100


Adding transform example links to documentation

Objective
Working on issue #1934 , with linking examples to the documentation. PR for transform examples.
Solution
Added to the documentation in bevy_transform transform.rs and global_transform.rs utilizing links from examples.
[X] 3d_rotations.rs linked to rotate in Transform
[X] global_vs_local_translation.rs linked to top of Transform and GlobalTransform documentation
[X] scale.rs linked to scale Struct in Transform
[X] transform.rs linked to top of Transform documentation
[X] translation.rs linked to from_translation in Transform

You can also see in the CI that it's complaining about lack of formatting :) https://github.com/bevyengine/bevy/actions/runs/3070501643/jobs/4960290437
That's an easy fix; just follow the directions there.

Can you mention that this is for the Transform examples in your PR title? They get turned into commit names so it's useful to see what exactly was done at a glance.

@bwhitt7 you can press "Resolve conversation" on the comments you've addressed. It's very useful for reviewers so they can have a better idea of the current state of the PR.

@alice-i-cecile gotcha! thank you for your help

@Nilirad thank you for your suggestions, i think these are really nice changes. i've never used github much before, so I'm unsure where to go from here. would i commit your suggestions?

You can go the Files Changed tab, add the suggestions to a batch and then commit the suggestions :)

You can also check this page to see how to apply suggestions:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

Congrats on your first merged PR :)
bors r+


add new client troubleshooting section on poor performance in U-boot

Changelog: None
Signed-off-by: Mirza Krak<EMAIL_ADDRESS>

Also my editor seems to have cleared some trailing white spaces :)

Very clear!
Regarding the location, my intent at least was that "Mender client" troubleshooting would be board-agnostic. It's assuming the board integration is working.
I think this would fit better under https://docs.mender.io/2.0/troubleshooting/running-yocto-project-image, there are other sections about GRUB and U-Boot there. We might also want to rename that doc page to "Boot" or something similar, now that we have more than just Yocto.

Changed section for troubleshooting and updated wording based on your comment @drewmoseley


Testing unattended upgrades

This isn't quite complete, but a start at least.

These tests should probably check file contents, but for now test all the parameters in the templates can be set, and test all the validation.


chore: release  cli 0.4.1

:package: Staging a new release
0.4.1 (2023-08-04)
Bug Fixes

attach cli artifact to release (#38) (50aa988)
fix release-action pattern resolve issue (#40) (c66ffd9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/carbynestack/cli/releases/tag/cli-v0.4.1 :sunflower:


'hidapi-libusb' is required but it could not be found

Hi,
As said in the title, hid require the hidapi-libusb package, which can't be found. I read that the file has been renamed, or something, but I don't have all the informations (I'm not really familiar with Haskell).
The consequence is that the package can't be installed anymore.

Hi,
Thank you for your report. Do you have an idea what is the new name? Do you have a CHANGELOG somewhere about that?

Ok, I should have read more carefully.
Actually, hid doesn’t require any other package else other than base, bytestrings and transformers. What you’re refering to is a C library. You have to install the C library before attempting to install the Haskell package. :)

If you're talking about the language-c package, I've already installed it. Or are you talking about something else?

The C library. This.

It works fine, thanks! And sorry for mistaking the library with a package :)

No problem, that happens! I should update the documentation, it’s not even rightly written. Good luck with your HID needs. ;)


[GRM] Label managed resources

How to categorize this PR?

/area dev-productivity robustness
/kind enhancement
What this PR does / why we need it:
This PR labels all resources managed by GRM with a resources.gardener.cloud/origin label so that they can be easily described with selectors. It uses a similar to the resources.gardener.cloud/origin annotation convention.
Which issue(s) this PR fixes:
Fixes #6385
Special notes for your reviewer:
Release note:

Gardener resource manager now labels all managed objects with `resources.gardener.cloud/origin` label. This is an improvement which will allow these objects to be easily described with a label selector.

/retest-required
Not sure why apidiff is failing. All changes seem compatible to me. Logs show:
FAIL: contains incompatible changes:
github.com/gardener/gardener/pkg/apis/resources/v1alpha1
  Compatible changes:
  - OriginLabel: added
github.com/gardener/gardener/pkg/apis/resources/v1alpha1/helper
  Compatible changes:
  - OriginLabelForManagedResource: added
  - SplitOriginLabel: added
make: *** [Makefile:238: check-apidiff] Error 1

/test pull-gardener-e2e-kind

/retest-required
Not sure why apidiff is failing. All changes seem compatible to me. Logs show:
FAIL: contains incompatible changes:
github.com/gardener/gardener/pkg/apis/resources/v1alpha1
  Compatible changes:
  - OriginLabel: added
github.com/gardener/gardener/pkg/apis/resources/v1alpha1/helper
  Compatible changes:
  - OriginLabelForManagedResource: added
  - SplitOriginLabel: added
make: *** [Makefile:238: check-apidiff] Error 1

This is expected. api-diff is not a "required" test to merge.

/retest-required

There is some issue with this PR. I will try to reproduce it locally and see what is going on.

But do we need the origin annotation now? Can we not replace its usage with the label instead?

I think that the annotation may not be necessary any more. This can be addressed at a later stage.

Label values were exceeding 63 symbols which is a limitation on the label itself (ref). I changed to constant labeling across all objects managed by the GRM.

@rfranzke The rationale behind the "random" name was that it can serve in two scenarios:

I want to select all objects where the label exists
I want to select all objects where the label exists and has a particular value (not sure if there is such use cases)

Anyway this approach was in the end not feasible due to label length constraints. I am not set on the current label value resources.gardener.cloud/managed-by: resource-manager so I can change it to resources.gardener.cloud/origin: gardener (or something else) if this is the consensus.

OK, thanks. I'm also fine with .../managed-by, this sounds better and given that we already have this origin annotation is probably less confusing. However, as said, I think the value should be configurable

Do you mean configurable like part of the ControllerConfig and probably passed as a flag on GRM start? If this is done all workloads that want to use this label in a selector should also know about its value (unless they use the "exists" label operator). Do we have any use case or immediate benefit to doing this?

Thanks. Then I can add this addition and leave a default value. One last thing. Do you prefer this value to be "gardener" or "resource-manager"?

I think GRM is just the mechanism to deploy the resources, but the actually originator of the source is gardener, so I would use gardener as default.

/unassign @rfranzke

Thanks for this PR, well done!

/retest


Add cheat sheet for some commands

Especially for podman
(I don't have much experience for docker, sp may be same)
We can override the entrrypoint via podman run --entryoption. It can take JSON array syntax. And last should be image name
But podman exec can only accespt splat string in the rest arguments

https://github.com/kachick/dotfiles/pull/484 is NOT relating to this issue

[ ] git reset, and the reset

Writing in https://github.com/kachick/dotfiles/wiki/Workflows for now

Initial motivation is providing a workaround for https://github.com/kachick/dotfiles/issues/173, if it is realized, this issue might be closed

Wiki and several *.md are enough for now


Fix typo in comment in template

Jenkins, test this please.

Jenkins CI test (for commit 1a3cfaf32f8ac5bdd858f3f984b2ddabdc418d15) succeeded without errors!

LGTM!


[backport] Add NCCL broadcast

Backport of #2303

[automatic post] Jenkins, test this please.

Just I missed making this backport when I merged the original one.

Jenkins CI test (for commit 9ae314be136d4fba1a14a74bb93c416f45dceb30, target branch v6) failed with status FAILURE.

Let me close this PR for now.


read doesn’t impose any memory limits

Bash’s read command doesn’t impose any limits on how much data it will read, so it is easy for the sender to cause the receiver to run out of memory.

Good catch! I didn't even consider that. I actually just tested it myself with:
python3 -c "print ("A" *<PHONE_NUMBER>)" | read
And instantly all my memory was consumed.
I was looking at the bash manual (because read is a built-in command) and it looks like this can be fixed with the -N option.

Turns out I needed to use -n because of space being a delimiter for the separate variables. I figured a 32 character limit (total for all the variables combined) would a reasonable limit.

python3 -c "print ("A" *<PHONE_NUMBER>)" | read

That was python3 using up all your memory, not bash :slightly_smiling_face:.  bash only uses memory very slowly, since it reads one byte at a time.

Still, thanks for the fix!

Oh, good point. I was just looking the free memory pie chart in the "Resources" tab of GNOME System Monitor. Should've checked processes too.
Here is a good PoC of the actual memory issue with read (same effect, memory usage slowly but surely rises until there's none left):
print.py:
#!/usr/bin/python3

while True:
    print('A')

In terminal:
chmod +x print.py
read <<< "$(./print.py)"


app-operator allows deleting an App in a non-healthy status without removing its chart

It seems that if an App CR is in a non-healthy state, for example chart pull failed, then when that App CR is deleted app-operator will happily allow the App CR to be deleted without actually cascading that delete down to the Chart and the associated chart resources.
We have seen this happen a few times now with E2E tests where the upgrade test fails (e.g. for incorrect chart pull) and then during the AfterSuite stage the App is successfully deleted but all the cluster resources remain behind.

To reproduce this issue:

Create a new CAPA workload cluster
Create a new test Release CR that references an invalid version for the cluster-aws value
Update your workload cluster's uservalues to reference your new, invalid, Release version
Wait for the cluster-aws App CR to report a chart pull failed error
Perform a kubectl delete on that App CR
Verify that the Chart and all resources contained within it are still present on the MC.

Desired outcome: App operator should correctly handle the delete operation and remove whatever chart was previously created for that App.

Ok, I'm currently unable to reproduce this now so I think something else might be going on. 😞
I'm going to close this issue for now until I have a better idea what is going on.


Provide an options file which includes package:lints/recommended.yaml

Now that a Dart team-recommended set of lint rules has been published, I think it makes sense to think of pedantic as the layer on top of those rules which we value highly internally.
(I know that that is not the actual situation; the pedantic rules are just completely separate, but in terms of analysis options files for users, I think it would be pragmatic to think of pedantic this way.)
Only one analysis options file can be included into another; you cannot include a list of analysis options files. Perhaps you can some day, but there is some hashing out w.r.t. merging that needs doing, and it might not be a high priority item. In the meantime, the only way to include multiple analysis options files into your own is by daisy chaining them. package:lints/recommended.yaml includes package:lints/core.yaml, so you get the lint rules from each.
It would be great for pedantic to provide a new analysis options file which includes package:lints/recommended.yaml. Something like package:pedantic/recommended.yaml. WDYT?

/fyi @davidmorgan @mit-mit

SGTM, but this is really David's call

Hmmmm looking at the delta between pedantic and recommended, I'm not sure it's worth it; it doesn't seem like a lot of value.
I'd actually go in the other direction: is there any value left in publishing/using the google3 lint set externally? It gives a little more consistency for google3 developers working on third_party packages, but there is anyway a delay in publishing so they're not usually fully in sync. I'm not sure external users care too much. And, it's potentially confusing.
WDYT?

The delta is only 6 removed lints: https://github.com/dart-lang/lints/issues/37
I originally thought that all pub packages imported into Google internal had to be pedantic-compliant, but forgot we have a different rule set for third party, so I think you're right; I'll just be migrating my own packages to package:lints.

That sounds right.
The last question is the old chestnut of what we do with unawaited :)
At this point I think that will mostly follow how/if Flutter ends up using unawaited_futures, so nothing to do right now from here.
@pq do you plan to update the linter docs to add tags/links into package:lints? Per the discussion here I think it makes sense to remove pedantic links at the same time. WDYT please?
Thanks.

The last question is the old chestnut of what we do with unawaited.

I don't think we need to do anything with it. It was created for internal use because we didn't want internal users to use ignore comments, but Flutter doesn't have a policy against using ignore comments, so they already have a valid way of disabling the lint when necessary.

@pq do you plan to update the linter docs to add tags/links into package:lints? Per the discussion here I think it makes sense to remove pedantic links at the same time. WDYT please?

Tags will be updated on next release.
Since pedantic is still used by googlers who might value these docs are you sure we want to remove the badge?

I'd actually go in the other direction: is there any value left in publishing/using the google3 lint set externally?

Sorry, I was reading backwards...
If you do decide to remove the lints or stop updating/maintaining them, I'd suggest a deprecation period and some good messaging but you've probably already thought of that! :)

Note that unawaited_futures specifically does call out using package:pedantic:

Future results in async function bodies must be awaited or marked unawaited using package:pedantic.

I just sent @pq a CL explicitly setting the lint message in google3, then we can drop the reference to pedantic externally.
For pedantic, I suggest: I'll update the README to point to package:lints then stop publishing new versions.

Is it not better to wait a bit, and then see if these actually do continue to be used?

It appears that a getter named unawaited is being added to the SDK (as an extension): https://dart-review.googlesource.com/c/sdk/+/200428. We'll need to update the lint to recognize it, then we can decide whether to deprecate the method in pedantic in favor of the getter.

The lint should just work :) it doesn't do anything specific to the current unawaited method, either.
Then, I agree, pointing in the lint message to the SDK-based solution seems right.


Add prepublish hook for JS

Fixes #6

Can you add source-maps?
https://github.com/evanw/node-source-map-support

Also how is this affected by https://github.com/npm/npm/issues/3059 ?


Beautify the About Section and developers section

I can modify the UI of the about section and developers section of the page. Please assign me this

Yes Sir I completely understand your problem statement and I have fixed this one Sir and here are the images of both small and medium devices about us section. sir if you like it please assign me as contributor.

Hi, I would like to work on this issue, please can you assign this to me.

Hey, I would like to work on the same. Can you please assign this to me under GSSoC'24.


append provenance index file on anchored preston track cmd

In situation of existing Preston package (like [1]), I'd like to be able to append a new version without having to clone to entire package with history from the beginning of time.
However, while,
preston track\
 --remote https://zenodo.org/record/8125362/files\
 --anchor hash://sha256/0e9bc57bc082b58a2c7a509bb73362b258ec8ddfc6664898e25c639786413fda\ "https://www.discoverlife.org/mp/20q/?act=x_checklist&guide=Apoidea_species&flags=HAS"

produces a linked provenance log (preston ls | grep "0e9bc57bc082b58a2c7a509bb73362b258ec8ddfc6664898e25c639786413fda" with statement:
<hash://sha256/0e9bc57bc082b58a2c7a509bb73362b258ec8ddfc6664898e25c639786413fda> <http://www.w3.org/ns/prov#usedBy> <urn:uuid:c93732f1-58dc-4bd2-9fca-db6ad9301748> <urn:uuid:c93732f1-58dc-4bd2-9fca-db6ad9301748> .

it does not produce a provenance query index. Instead, a "root" query index is generated with query hash hash://sha256/2a5de79372318317a382ea9a2cef069780b852b01210ef59e06b640a3539cb5a is generated.
e.g.,
find .

produced:
.
./data
./data/2a
./data/2a/5d
./data/2a/5d/2a5de79372318317a382ea9a2cef069780b852b01210ef59e06b640a3539cb5a
./data/c4
./data/c4/fc
./data/c4/fc/c4fc072c4977b8a55fc386402b6b2b3128f9de27349e61b369c887ce88e525e8
./data/37
./data/37/48
./data/37/48/37489fc6e5bcfb53e996ddfbc28ef0bb8c00470891f31bb91370953f05235a1d

This means that when the provenance query index file is added to an existing publication, the corpus would not allow for traversing from the first version (the provenance "root") to the most recently added version.
Suggest to instead generate a provenance query index that answers the question: what is the provenance log that came after  0e9bc57bc082b58a2c7a509bb73362b258ec8ddfc6664898e25c639786413fda ? Instead of the current provenance query index that answers the question : what is the first provenance log?
References
[1] Poelen, Jorrit H. (2023). Nomer Corpus of Taxonomic Resources hash://sha256/0e9bc57bc082b58a2c7a509bb73362b258ec8ddfc6664898e25c639786413fda hash://md5/91dd844e787ffae8f0a2bbb8c1f29192 (0.16) [Data set]. Zenodo. https://doi.org/10.5281/zenodo.8125362

On a related note, preston head --anchor https://sha256/123... is expected to return the most recent provenance log, even if an anchor has been provided and a local pointer to a newly appended provenance log exists.


Can't even install.

The installer won't let me press the check mark box to agree to the terms and conditions.

This is very well known, click the text next to the box and it will work.
Should be fixed in the next installer update.
Duplicate of #947

Oh okay thanks that was such a quick response lol

Oh okay thanks that was such a quick response lol

It's an extremely common error, and any new GitHub issues posted are shown in both BetterDiscord support servers.

Okay so now that I've installed it, it keeps crashing my discord...

Please read: https://github.com/BetterDiscord/BetterDiscord/issues/995#issuecomment-901337922
If this doesn't work, please join the community support server: https://discord.gg/0Tmfo5ZbORCRqbAd

Waiting for closure.


Notifications

On-site notifications of changes to entities a user is watching.

Endpoints exist for subscribing/unsubscribing to site entities (genes/variants/evidence items) as well as topics like "all new comments" "all new evidence items" etc. Will need to coordinate with Josh to build a UI.
For the time being (until we have a UI), we can subscribe interested parties manually to email notifications.


Issue on creating annotation on DateTime text Phase (e.g. last year)

Hi,
I'm experiencing the issue on creating annotation on DateTime text phase, e.g. 'Last year'. It works for other text except any DateTime text phase.  The strange thing is it works under 'Debug' configuration, but not under 'Release' configuration.
I'm using Stanford.NLP.CoreNLP 3.5.2 version. I appreciate if you could shed some light on this.
The error message is  below:  ( This error was reported in this web page by user Antonio de Perio as well:
http://webcache.googleusercontent.com/search?q=cache:9v_lDNl4pkEJ:https://sergeytihon.wordpress.com/2013/10/26/stanford-corenlp-is-available-on-nuget-for-fc-devs/+&cd=3&hl=en&ct=clnk&gl=uk )
Provider com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl not found
IKVM.OpenJDK.XML.API
at javax.xml.transform.FactoryFinder.newInstance(Class , String , ClassLoader , Boolean , Boolean )
at javax.xml.transform.FactoryFinder.find(Class , String )
at javax.xml.transform.TransformerFactory.newInstance()
at edu.stanford.nlp.time.XMLUtils.printNode(OutputStream out, Node node, Boolean prettyPrint, Boolean includeXmlDeclaration)
at edu.stanford.nlp.time.XMLUtils.nodeToString(Node node, Boolean prettyPrint)
at edu.stanford.nlp.time.Timex.init(Element )
at edu.stanford.nlp.time.Timex..ctor(Element element)
at edu.stanford.nlp.time.Timex.fromMap(String text, Map map)
at edu.stanford.nlp.time.TimeExpressionExtractorImpl.toCoreMaps(CoreMap , List , TimeIndex )
at edu.stanford.nlp.time.TimeExpressionExtractorImpl.extractTimeExpressionCoreMaps(CoreMap annotation, String docDate, TimeIndex timeIndex)
at edu.stanford.nlp.time.TimeAnnotator.annotate(Annotation annotation)
at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(Annotation annotation)
at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(Annotation annotation)
at MyApp.NLP.StanfordExtractor.Annotate(String text) in C:\MyApp\Source\NLP\StanfordExtractor.cs:line 288
at MyApp.NLP.StanfordExtractor.ExtractQueryTerms(String inputText) in C:\MyApp\Source\NLP\StanfordExtractor.cs:line 241
at ConsoleApplication1.Program.Main(String[] args) in C:\Users\MyUser\Documents\Visual Studio 2015\Projects\NLP\ConsoleApplication1\Program.cs:line 17
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()

Close as an old issue


New DX events

Signed-off-by: Gabriel Indik<EMAIL_ADDRESS>

Something that was previously discussed but not yet implemented: currently there are only 3 operation status:

Pending
Succeeded
Failed

When sending a message through Data Exchange, the message would go through the following stages:

Sent
Received
Acknowledged
(and Error if there is a communication issue)

Note that a recipient may choose not to acknowledge a message. This is why keeping the status in "pending" after the message is sent/received doesn't seem like the right approach. Instead we could incorporate a new state called either "Acknowledged" or "Confirmed".


model package, user persistence

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 1min)


Existing App does not get Service Worker capabilities

Versions
Angular CLI: 1.6.0
Node: 9.2.0
OS: win32 x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

@angular/cli: 1.6.0
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.41
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.0
@schematics/angular: 0.1.10
@schematics/schematics: 0.0.10
typescript: 2.6.2
webpack: 3.10.0

Repro steps
Have an existing app with no PWA capability and apply steps to upgrade it as described in docs.
Observed behavior
Despite the fact it builds with no error and dist folder has files like ngsw.json & ngsw-worker.js as expected, they are not loaded on network request when browsed. (Tested with incognito mode as well)
No service-worker effect at all in app.
Desired behavior
Service Worker added to built app when steps in official docs are applied.
Mention any other details that might be useful
On the same machine, a new app generated with Angular-CLI 1.6.0 with --service-worker flag. That app loads service worker as expected.

Same problem, with same versions.

Hello @alxhub
I can confirm I followed the guide. Only piece of code which differs on my side is this part:
providers: [
    CheckForUpdateService,
    LogUpdateService,
    PromptUpdateService,
  ]

which I excluded.

Hi @sntmrtn,
Can you publish a repo which reproduces the problem?
Thanks,
Alex

@alxhub I confirm I've followed those steps, I can not publish that repo, it's an app for a client.

I am seeing the same. I followed the guide to the T but service worker won't load.

@alxhub Please see the following repo:
https://github.com/sntmrtn/testsw

@sntmrtn thanks for the reproduction!
Can you confirm exactly what steps you're taking to build and serve the project, where you would expect to see the Service Worker?
As mentioned in the documentation, ng serve --prod will not cause a Service Worker to be registered, only a true ng build --prod will run the SW build step and produce a dist directory with the Service Worker configured.

Hi @alxhub
First, thanks a lot for your help!
I confirm that I build the project through ng build --prod. I then serve the dist folder with http-server as suggested in the guide. I also tried to serve the dist folder on a pre-prod HTTPS environment with the same result.
I expect to see the SW registered and activated in the "Application" tab of Chrome devtools, but nothing shows up.
From my terminal:
MacBook-Air:testsw sntmrtn$ ng build --prod
Date: 2017-12-09T08:08:45.452Z
Hash: fe12f6c535c8e1842392
Time: 29354ms
chunk {0} polyfills.169c804fcec855447ce7.bundle.js (polyfills) 60.9 kB [initial] [rendered]
chunk {1} main.d0d19976182286b68554.bundle.js (main) 171 kB [initial] [rendered]
chunk {2} styles.d41d8cd98f00b204e980.bundle.css (styles) 0 bytes [initial] [rendered]
chunk {3} inline.92d63502b90fcb9628dd.bundle.js (inline) 1.45 kB [entry] [rendered]
MacBook-Air:testsw sntmrtn$ cd dist/
MacBook-Air:dist sntmrtn$ http-server
Starting up http-server, serving ./
Available on:
  http://<IP_ADDRESS>:8080
  http://<IP_ADDRESS>:8080
And the result:

I have the same issue for an existing app. I followed the steps mentioned on https://angular.io/guide/service-worker-getstart but still no luck :(

I encountered also this issue on my existing app. So I tried to generate a new app like so
ng new my-project --service-worker

and after a ng build --prod it did work as expected, the service worker is registered and visible in the dev tools.
Then I tried to generate a new app like so
ng new my-project

I then followed the steps described in the guide and it did also work as expected.
So I decided to dig deeper in my own app.
After removing some code, I was able to get a service worker running and it appeared that it was due to a conflict with Pusher from the pusher-js package.
@Injectable()
export class SearchService {
  // having this assignment in a service class injected in a component in use at the startup of the app
  // makes the service worker not running (and not visible in the service worker list of the dev tools)
  pusher = new Pusher('key', { cluster: 'eu' })
  // after removing this line and doing an `ng build --prod` the service worker was running as expected.
  ...
}

I have no ideas what could be the root cause of this interaction between this line of code and the service worker as no errors are thrown in the console neither at compile time nor at runtime, but maybe this experience could help solving this issue.
The last thing I did is moving the assignment in a method that is never called at the startup of the app so I could have both a service worker registered and an instance of Pusher running.

The same here...
I find out that service-worker is not registered after I inject AngularFirestore from angularfire2/firestore to a component or a service.
See https://github.com/angular/angularfire2/issues/1347

Service worker won't run because of ng app is not stable (ApplicationRef.isStable (https://angular.io/api/core/ApplicationRef#members), application is not becoming stable if there is a code which runs intervals (setInteral or Observable.timer and etc. which come from setInterval or setTimeout).
As example of such behaviour:

Generate app ng new my-project --service-worker;
First ensure what service-worker works as expected;
Then add to app.component.ts constructor setInterval(t => { console.log('Ping')}, 500);
Try run app again - you will see what service-worker will stops to work

Workaround for such behaviour wrap - wrap all timer-code to this.applicationRef.isStable.subscribe(isStable => {  if (isStable) { <code goes here> } })
Full code
import 'rxjs/add/observable/interval';
import { Component, ApplicationRef, OnInit } from '@angular/core';
import { Observable } from 'rxjs/Observable';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent implements OnInit {
  title = 'app';

  constructor(private applicationRef: ApplicationRef) {
  }

  ngOnInit() {

    this.applicationRef.isStable.subscribe((s) => { // #1
      if (s) { // #2
        setInterval(t => { console.log('Ping')}, 500);
      } // #3
    }); // #4
    // If you uncomment 1-4 - service-worker will not run

    this.applicationRef.isStable.subscribe(t => {
      console.log('App stable: ' + t);
    });
  }
}

I also had this issue, the culprit seams to be angularFire2. I worked around it by registering the service worker in main.ts.
platformBrowserDynamic().bootstrapModule(AppModule).then(() => {
  if ('serviceWorker' in navigator && environment.production) {
    navigator.serviceWorker.register('/ngsw-worker.js');
  }
}).catch(err => console.log(err));

@alxhub , I am trying to make my existing app into pwa and for that I am following https://angular.io/guide/service-worker-getting-started. Now, the point is I have ejected ng command and hence using webpack. Upon the running the build command, ngsw.json is not getting created in dist folder although, ngsw-worker.js file is getting created. For your review, I am pasting the snippets below.
angular-cli.json code
{   "$schema"<EMAIL_ADDRESS>  "project": {     "name": "core",     "ejected": true   },   "apps": [     {       "root": "src",       "outDir": "dist",       "assets": [         "assets",         "manifest.json",         "icons"       ],       "index": "index.html",       "main": "main.ts",       "polyfills": "polyfills.ts",       "test": "test.ts",       "tsconfig": "tsconfig.app.json",       "testTsconfig": "tsconfig.spec.json",       "prefix": "app",       "serviceWorker": true,       "styles": [         "styles.css"       ],       "scripts": [],       "environmentSource": "environments/environment.ts",       "environments": {         "dev": "environments/environment.ts",         "prod": "environments/environment.prod.ts"       }     }   ],   "e2e": {     "protractor": {       "config": "./protractor.conf.js"     }   },   "lint": [     {       "project": "src/tsconfig.app.json",       "exclude": "**/node_modules/**"     },     {       "project": "src/tsconfig.spec.json",       "exclude": "**/node_modules/**"     },     {       "project": "e2e/tsconfig.e2e.json",       "exclude": "**/node_modules/**"     }   ],   "test": {     "karma": {       "config": "./karma.conf.js"     }   },   "defaults": {     "styleExt": "css",     "component": {     }   } }
Package.json file
{   "name": "kognifai-poseidon-next-core",   "version": "0.0.1",   "description": "",   "main": "index.js",   "author": "KDI",   "publishConfig": {     "registry": "https://kdi.jfrog.io/kdi/api/npm/npm-local/"   },   "scripts": {     "ng": "ng",     "start": "webpack-dev-server --port=4200",     "build": "webpack",     "test": "karma start ./karma.conf.js",     "lint": "ng lint",     "e2e": "protractor ./protractor.conf.js",     "pree2e": "webdriver-manager update --standalone false --gecko false --quiet",     "versionup": "npm-version-up",     "pwa": "npm run build --prod && sw-precache --root=dist --config=precache-config.js",     "ngsw-config": "node_modules/.bin/ngsw-config dist src/ngsw-config.json",     "ngsw-copy": "cp<EMAIL_ADDRESS>dist/",     "build-prod-ngsw": "npm run build --prod && npm run ngsw-config && npm run ngsw-copy",     "serve-prod-ngsw": "npm run build-prod-ngsw && http-server dist -p 8080"   },   "private": false,   "dependencies": {     "@angular/animations": "^5.0.0",     "@angular/common": "^5.0.0",     "@angular/compiler": "^5.0.0",     "@angular/core": "^5.0.0",     "@angular/forms": "^5.0.0",     "@angular/http": "^5.0.0",     "@angular/platform-browser": "^5.0.0",     "@angular/platform-browser-dynamic": "^5.0.0",     "@angular/router": "^5.0.0",     "@angular/service-worker": "^5.2.3",     "core-js": "^2.4.1",     "kognifai-design-system": "^0.7.2",     "kognifai-poseidon-authenticationservice": "0.1.1",     "kognifai-poseidon-settingsservice": "^0.1.2",     "lodash": "^4.17.4",     "ng-pwa-tools": "0.0.15",     "rxjs": "^5.5.2",     "uuid": "^3.2.1",     "zone.js": "^0.8.14"   },   "devDependencies": {     "@angular/cli": "^1.5.5",     "@angular/compiler-cli": "^5.0.0",     "@angular/language-service": "^5.0.0",     "@types/jasmine": "~2.5.53",     "@types/jasminewd2": "~2.0.2",     "@types/lodash": "^4.14.97",     "@types/node": "~6.0.60",     "autoprefixer": "^6.5.3",     "circular-dependency-plugin": "^3.0.0",     "codelyzer": "~3.2.0",     "copy-webpack-plugin": "^4.1.1",     "css-loader": "^0.28.1",     "cssnano": "^3.10.0",     "exports-loader": "^0.6.3",     "file-loader": "^1.1.5",     "html-webpack-plugin": "^2.29.0",     "istanbul-instrumenter-loader": "^2.0.0",     "jasmine-core": "~2.6.2",     "jasmine-spec-reporter": "~4.1.0",     "karma": "~1.7.0",     "karma-chrome-launcher": "~2.1.1",     "karma-cli": "~1.0.1",     "karma-coverage-istanbul-reporter": "^1.2.1",     "karma-jasmine": "~1.1.0",     "karma-jasmine-html-reporter": "^0.2.2",     "karma-junit-reporter": "^1.2.0",     "karma-phantomjs-launcher": "^1.0.4",     "less-loader": "^4.0.5",     "npm-version-up": "^0.1.5",     "phantomjs-prebuilt": "^2.1.16",     "postcss-custom-properties": "^6.2.0",     "postcss-loader": "^2.0.8",     "postcss-url": "^7.1.2",     "protractor": "~5.1.2",     "raw-loader": "^0.5.1",     "sass-loader": "^6.0.3",     "source-map-loader": "^0.2.0",     "style-loader": "^0.13.1",     "stylus-loader": "^3.0.1",     "sw-precache-webpack-plugin": "^0.11.4",     "ts-node": "~3.2.0",     "tslint": "~5.7.0",     "typescript": "~2.4.2",     "uglifyjs-webpack-plugin": "1.0.0",     "url-loader": "^0.6.2",     "webpack": "~3.8.1",     "webpack-concat-plugin": "1.4.0",     "webpack-dev-server": "~2.9.3"   } }
manifest.json
`{
"name": "Poseidon Next, The Complete Solution ",
"start_url": "/",
"orientation": "any",
"scope": "/",
"display": "standalone",
"short_name": "Poseidon",
"theme_color": "#472D21",
"background_color": "#C0B764",
"icons": [
    {
        "src": "icons/icon_96.png",
        "sizes": "96x96"
    },
    {
        "src": "icons/icon_144.png",
        "sizes": "144x144"
    },
    {
        "src": "icons/icon_192.png",
        "sizes": "192x192"
    },
    {
        "src": "icons/icon_512.png",
        "sizes": "512x512"
    }
]

}`
ngsw-config.json file
`{
"routing":{
"index":"/index.html",
"routes":{
"/":{
"match": "exact"
},
"/coffee":{
"match": "prefix"
}
    }
},
"static.ignore":[
    "^\/icons\/.*$"
],
"external":{
    "urls":[
        {
            "url" : ""
        },
        {
            "url" : ""
        }
    ]
},
"dynamic":{
    "group":[
        {
            "name" : "api",
            "urls" : {
                "http://localhost:8080/#/" :{
                    "match" : "prefix"
                }
            },
            "cache" :{
                "optimizeFor" : "freshness",
                "networkTimeoutMs" : 1000,
                "maxEntries" : 30,
                "strategy" : "lru",
                "maxAgeMs" : 36000000
            }
        }
    ]
},
"push" : {
    "showNotification" : true,
    "backgroundOnly" : true
}

}`
main.ts file
`import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { AppModule } from './app/app.module';
import { environment } from './environments/environment';
if (environment.production) {
enableProdMode();
}
platformBrowserDynamic().bootstrapModule(AppModule)
// waiting for angular to load bootstrapping and then only loading service worker
.then(()=>{
if ('service-worker' in navigator){
navigator.serviceWorker.register('/ngsw-worker.js')
// navigator.serviceWorker.register('/ngsw-worker.js')
}
})
.catch(err => console.log(err));
`
app.module.ts file
`import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { HttpModule } from '@angular/http';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { LoginComponent } from './login/login.component';
import { HomeComponent } from './home/home.component';
import { AboutComponent } from './about/about.component';
import { NavigationService } from './navigation/navigation.service';
import { HeaderComponent } from './header/header.component';
import { FooterComponent } from './footer/footer.component';
import { SidebarComponent } from './sidebar/sidebar.component';
import { DasboardComponent } from './dasboard/dasboard.component';
import { MainComponent } from './main/main.component';
import { ModuleLoaderService } from './services/module-loader.service';
import { OverlayService } from './services/overlay.service';
import { InitializeService } from './services/initialize.service';
import { CookieService } from './services/cookie.service';
import { SettingsService } from './settings/settings.service';
import { ServiceWorkerModule } from '@angular/service-worker';
import { SettingsServiceTestPageComponent } from './settings/test/settingsservice.testpage.component';
import { AuthenticationService } from 'kognifai-poseidon-authenticationservice/dist/AuthenticationService';
import { AuthenticationServiceTestPageComponent } from './authentication/test/authenticationservice.testpage.component';
import { environment } from '../environments/environment';
// import { HelloPoseidonModule } from 'kognifai-poseidon-hello-poseidon';
@NgModule({
declarations: [
AppComponent,
LoginComponent,
HomeComponent,
AboutComponent,
HeaderComponent,
FooterComponent,
SidebarComponent,
MainComponent,
DasboardComponent,
SettingsServiceTestPageComponent,
AuthenticationServiceTestPageComponent
],
imports: [
BrowserModule,
FormsModule,
HttpModule,
AppRoutingModule,
// ServiceWorkerModule.register('/woker-basic.min.js',{ enabled: environment.production })
ServiceWorkerModule.register('/ngsw-worker.js', {enabled: environment.production})
// HelloPoseidonModule
],
providers: [
NavigationService,
ModuleLoaderService,
SettingsService,
AuthenticationService,
OverlayService,
InitializeService,
CookieService
],
bootstrap: [AppComponent]
})
export class AppModule { }
`
Having said that, while running the build command say npm run build-prod-ngsw it gives below error

<EMAIL_ADDRESS>ngsw-config D:\PoseidonNext\Core
ngsw-config dist src/ngsw-config.json

(node:23044) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'startsWith' of undefined
(node:23044) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled
will terminate the Node.js process with a non-zero exit code.

<EMAIL_ADDRESS>ngsw-copy D:\PoseidonNext\Core
cp<EMAIL_ADDRESS>dist/

I have also attached screenshots for your review. Kindly, let me know what is wrong going here?
Thanks,
Rahul

I have fixed the above issue, now ngsw.json is getting generated in dist folder and I am seeing that no service worker registered is coming. Here is the screen shot.

I am also confused about 'ngsw-worker.js' or 'woker-basic.min.js'. Like which one I should be using? Thanks,
Rahul

@rahulsahay19  Try to post a question @ stackoverflow.com

@odahcam not a problem. Its fixed. Thanks!

@rahulsahay19 , can I know what the fix is?

@zendizmo In my case, my ngsw-config.json file was not on latest schema. When I took the sample config, then it worked later on moved my changes in there!

This issue is still marked as open. Can I get a solid confirmation that Angular CLI now fully supports Service Worker? Has anyone put a larger Angular app in production with Service Worker enabled successfully? Cheers

Apparently there are cases that prevent PWA work properly in Angular, but they are not clearly stated in documents or any errors get returned while building your app. If you are only dealing with Angular's own packages you are supposed to be fine, when you are using external libraries (even ones developed by Google's own people, like AngularFire2) chances are it will fail by default, then you search and patch your code to make it work.
So I believe now it's rather a problem of properly informing erroneous cases & documentation issue than service worker part of Angular itself. Still it didn't work for me as is.

@bjornharvold, for me it doesn't 😢

One more question wanted to check, whether below urls can be relative.
{
"name": "api-performance",
"urls": [
"https://www.xyz.com/Security/auth/.well-known/openid-configuration",
"https://www.xyz.com/Security/auth/interaction/7bc4260e-b1df-4e6c-8b17-"
]
}
So, If i am deploying app in different environments, this xyz can be replaced accordingly with that environment. Thanks.

There own example did not work, when applying an update service like described in https://angular.io/guide/service-worker-communications#checking-for-updates. So probably more an Angular ticket and not a problem of angular-cli?

Maybe both?

@markus-heinisch I had the same problem as you. I solved it using a manifest.json with the following:
    "external": {
        "urls": [
                {"url": "http://fonts.googleapis.com/icon?family=Material+Icons"}
        ]
   }

@markus-heinisch @alxhub You know the problem with this approach is, you need to enable to download .json file from server, which is not a good idea. I mean you can have meaningful json files at server side, which you don't want to get downloaded upon any http request and manifest.webManifest approach is giving unable to detect manifest error.

@abariatti Thanx for your tip. I have tested with some config changes and found a working solution in file ngsw-config.json:
"urls": [           "https://fonts.gstatic.com/s/materialicons/**/*.woff2",           "https://fonts.googleapis.com/icon?family=Material+Icons"         ]

I confirm that I am having this issue as well. I followed the exact procedure (Adding a service worker to an existing app) as described in https://angular.io/guide/service-worker-getting-started
Except I have commented out the following
    CheckForUpdateService,
    LogUpdateService,
    PromptUpdateService,

Project builds and I can see ngsw-worker.js in my /dist folder after building (ng build --prod) however the service worker seems not activated. I can see in this thread some people have resolved the issue using a manifest.json file. Could someone elaborate on configuring this file and whether it is required or not for all application? I raised this question on Stackoverflow and it appears to me this file plays quintessential role in getting service worker started.

I am using Angular CLI 1.7.3 and Service Worker 5.2.8. With an existing app It doesn't work. However,
in  new CLI app works fine

alright, I found the issue. You should check again what 3rd party libraries or dependencies you have installed. in my case, I have installed particle.js via npm, and it somehow stopped service workers from working. I'm trying to find a compatible way to use both of them

Argentan's solution about regiter service worker in main.ts worked perfect to me!

Hi, a quick note, updated to angular 6, firebase 5 and angularfire2 5rc10 and the fix is no longer needed, service workers works out of the box.

Based on https://github.com/angular/angular-cli/issues/8779#issuecomment-397844943, this seems to have been resolved.

I struggled with something similar for a long time, but my problem was different. I used http://<IP_ADDRESS>:8000 as my URL, but then the serviceWorker is not present as navigator.serviceWorker.
I just changed it to http://localhost:8000 and everything works. It must be because localhost is considered a secure origin.
Maybe that will help someone.

@dirand analysis solved my problem: SW did not get registered because of some external code running intervals in the default routed component.
To detect it, I simply started to comment everything suspicious and then go by exclusion, wrapping the unstable code in this.applicationRef.isStable.subscribe((isStable) {}.
@dirand Thanks for your great contribution, I struggled with this way to much!

With angular-cli 6.2.5 and angular 6.1.10, this issue still exists. Also related to angular#20970

This costs me few hours to find out what is not working. My service worker dont register in whatever.
The problem is, service worker only worked on HTTPS(secure content)

The solution from @Argentan works and is more simple.

I know its an old old thread and @Argentan's solution has worked for me for most browsers. However for some weird reason it sends back a rejected promise in Safari 12.1.1
This is the error i get:
Promise Rejection: TypeError: TypeError: Type error

Am i the only one who is having this problem?

Apparently its an issue with the latest Angular 8 release.
https://github.com/angular/angular/issues/31061

@hassanasad I am also having the same issue. With Version 8.2.2
Chrome is detecting Manifest but not detecting Service Workers...
Angular CLI: 8.2.2
Node: 10.16.3
OS: linux x64
Angular: 8.2.3


Fixed address & balance summary.

By default address summary would show spending tokens(centrapay) balance, in some cases like staking tab, staking token(cennz) balance would be shown.
Fixes #1

Needs fix build issue

The build failure is caused by some legacy linting errors non-related to this PR.
Will fix them anyway.


Choice nodes: put cursor at the end

Can we put cursor at the end of the word every time we cycle through it by luasnip.change_choice(...)?
I request to make it configurable.

You can control where the cursor ends up by using an insertNode.

What about vs code snippets?

Mhmmmm yeah, that doesn't work there (maybe as a side-effect only, since we (IIRC) accept placeholders in choices).. you'll have to write those snippets in lua

Nevermind, we really only allow text in vscode-snippet-choices.


Pass vCenter secrets to create VM wizard

vCenter secrets need to be passed to the create VM wizard to enable saving vCenter credentials.
Bug: https://bugzilla.redhat.com/1714004

Backport of: #399


New ColumnAutosizeOptions and bufferPxOverride config

Bundles autosize-related config on Column into a single autosizeOptions property

New ColumnAutosizeOptions typedef
New ColumnAutosizeOptions.bufferPxOverride config to support overriding GridModel.autosizeOptions.bufferPx applied on all columns.

Toolbox PR: https://github.com/xh/toolbox/pull/529
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

I'm like this! Bundling these options into an object gives us a hook to extend in the future, and allows us to shorten the property names by removing redundant autosize prefix. And allowing the dev to set bufferPx on a per column basis is a clear win. 👍
I'd still like to go over the issue that prompted this change though, to get a better understanding of why the autosizing wasn't working for you.

I asked Petra to look into the new override on bufferPX, so thanks for putting this together!.
But unfortunately,  at this point I have some misgivings with this PR:

We now think we don't actually need column specific bufferPx.  Tom is working on an unrelated fix to the problem that originally made it seemed like we needed that new flag.
Columns already have very flat options for many things (especially export).  It actually
We need to avoid API churn unless we have a clear feature, or bug we are fixing.

Thoughts?

Tom -- let me know what you think of my reasoning?  I see you were liking it...

Lee -- you make a good point about API churn. It seems overkill to bring breaking changes to the API if we're able to solve the underlying issue in the other PR.
That said, I do think being able to set bufferPx on a per column basis is still valuable. I think of these Column.autosizeXXX options as "escapes hatches" for the dev to make autosize more stable (similar to autosizeMaxWidth, etc). If you have one particular column that could benefit from increasing the bufferPx, it seems reasonable to be able to do so, especially since we have these other column-specific flags available. It certainly seems better than the current solution of having to increase the bufferPx of every column, and widening every column in the grid, to fix an issue with a specific column.
I would vote for not adding the ColumnAutosizeOptions, but keeping the ability to set column specific bufferPx as a flat Column.autosizeBufferPx option, to make this a purely additive non-breaking change.
Thoughts?

Sounds like a good compromise, and nice pickup!
On Wed, Sep 15, 2021, 4:54 AM Tom Tirapani @.***> wrote:

Lee -- you make a good point about API churn. It seems overkill to bring
breaking changes to the API if we're able to solve the underlying issue in
the other PR.
That said, I do think being able to set bufferPx on a per column basis is
still valuable. I think of these Column.autosizeXXX options as "escapes
hatches" for the dev to make autosize more stable (similar to
autosizeMaxWidth, etc). If you have one particular column that could
benefit from increasing the bufferPx, it seems reasonable to be able to
do so, especially since we have these other column-specific flags
available. It certainly seems better than the current solution of having to
increase the bufferPx of every column, and widening every column in
the grid, to fix an issue with a specific column.
I would vote for not adding the ColumnAutosizeOptions, but keeping the
ability to set column specific bufferPx as a flat Column.autosizeBufferPx
option, to make this a purely additive non-breaking change.
Thoughts?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/pull/2660#issuecomment-919828879, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2LFD7TBK27DYM4ORI3UCBNKPANCNFSM5DX3ZNAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Change in model of Alert and Trigger added Note

Alert - Add extra class Lister to turn Alert properly parcelable, few extra items for additional features
Trigger - add detail field
Note - Model for Comments on Alert

Hi Anuj.
I'm not familiar with specific of android classes but I didn't see anything suspicious.


find-all-issues.rb

Let's add a new judge, which will take the smallest issue in a repository (using issue-was-opened facts) and then add more facts, with smaller numbers. Such issues definitely exist in the repository, anyway.

which will take the smallest issue in a repository

What the means "smallest issue"?

with smaller numbers

What is it? (maybe issue without comments?)
@yegor256 Can you give more information about this?

@Yegorov first, we scan all issue-was-opened facts and find the smallest value of their issue properties. This is the "smallest issue" in the repository that we are aware of. However, this is not the smallest number in GitHub: there are smaller numbers too. This happens because github-events.rb doesn't scan all events, but only the latest 1000 (or so). In order to fix this, we should add issue-was-opened events to the factbase, pretending we've seen them in github-events (even though we haven't).

@yegor256 may I take this one?

@Yegorov sure, please!

@rultor release, tag is 0.0.55

@rultor release, tag is 0.0.55

@yegor256 OK, I will release it now. Please check the progress here.

@rultor release, tag is 0.0.55

@yegor256 Done! FYI, the full log is here (took me 7min).


Remote; difference between msi and zip on Windows

To provide the podman support with CRC we would like to use an easy way to embed/provide the client binary to install on the user's machine. using the *.msi is not preferred, but we noticed the *.zip is not made the same. See: https://github.com/code-ready/crc/issues/961#issuecomment-594913942

https://github.com/containers/libpod/releases/tag/v1.8.1  <-- how does this work!
fwiw, i put the msi there and a zip containing just the podman-windows-remote.exe and a docs dir with the html files

Looks good, do we have the readme.md links to there?

Should we have MAC Version there as well.

Why are the contens of the Windows zip archive so different from the MSI and also when compared to even the macOS release? podman-remote-windows and podman
podman-remote-latest-master-darwin-amd64.zip - ZIP archive, unpacked size 50,308,978 bytes
podman-v1.6.2-75-g6c6e7837/docs/
podman-v1.6.2-75-g6c6e7837/podman

podman-remote-windows.zip - ZIP archive, unpacked size 51,827,111 bytes
docs/
podman-remote-windows.exe

Note the names and the additional directory

look, i did what i thought would be helpful.  given this is almost entirely being done for you, what do you want?  i could just zip the executable and drop the docs.  let me know.

you

/s/you/CRC. The process for extracting and handling these archives should not have to inlvolve additional platform logic to deal with. It is NOT about t=having docs in there, as I could care less about those, but the subdirectory and the differently named platform executable (podman, podman-remote-windows.exe).
Are these created by a build script? If so, let me know since if this seems too much I can patch it.

Yes I agree, the executable should be podman.exec not podman-remote-windows.exe

Any update on this?

@gbraad What exactly would you like the Zip file to look like.
Do you want the help files and podman.exe?
Do you want the podman-v1.8.2-rc1-11-g6a261844/ removed?

How does this look
podman-remote-release-windows.zip

That looks better. Can this be available on the same location for all
platforms?
From the code we use google storage:
https://storage.googleapis.com/libpod-master-releases/
It would be great to have a consistent location with tags
On Thu, Mar 19, 2020 at 8:55 PM Daniel J Walsh<EMAIL_ADDRESS>wrote:

How does this look
podman-remote-release-windows.zip
https://github.com/containers/libpod/files/4354623/podman-remote-release-windows.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/issues/5477#issuecomment-601161854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZUMD6XSFKFTZ2DXDODRIII4RANCNFSM4LGN6QCA
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]


prevent-link-loss misaligned on mobile

Description

How to replicate the issue + URL

In a comment field, paste this https://github.com/refined-github/refined-github/pull/6018/commits/3626c1861cdd39d6341ac2fdaa49e0885873eeb2
Resize window to 400px in width

I think we can just use our Banner component.
Additional related issue

Visit https://github.com/refined-github/refined-github/issues/new?assignees=&labels=bug&template=1_bug_report.yml
Paste that link in a field
See how the border awkwardly wraps both the field and the banner

We might have to move our banner outside that bordered element.

Extension version
23.4.15
Browser(s) used
Safari iOS

Additional related issue

Ignored because their own CSS is messy, see bottom border:

Related:

https://github.com/refined-github/refined-github/issues/6512#issuecomment-1508229958


How to run the jar file?

https://github.com/javaterminal/TerminalFX/blob/master/releases/com/kodedu/terminalfx/terminalfx/1.0.5/terminalfx-1.0.5.jar
When I run this jar file it comes like this.
no main manifest attribute, in terminalfx-1.0.5.jar

As I said previously, we don’t provide self contained jar for terminalfx. You should care yourself how to package your JavaFX application.


Explicitly enable CGO

Previously CGO was not disabled, but we were relying on CGO being enabled by default - in future when we move to golang 1.20 there may be envs where CGO gets turned off at build time.
Ensure CGO is always enabled
Will cherry-pick this into release-2.5-2.8

/cherry-pick release-2.7


Use /usr/bin for sti scripts

Since we're trying to come up with guidelines and best practices for creating docker images, I'm also thinking about things like locations of files within the container. This is a proposal to change location of sti scripts.
The reasons for this change are:

what FHS says about '/usr/local':
The '/usr/local' hierarchy is for use by the system administrator when installing software locally. It needs to be safe from being overwritten when the system software is updated. It may be used for programs and data that are shareable amongst a group of hosts, but not found in '/usr'. (http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLOCALLOCALHIERARCHY)
we may include the sti scripts in the RPMs once (in that case it would probably be links managed by alternatives, since various implementations of /usr/bin/run will be different across images)
we need to have those commands available for and run by users, so I don't see any special reason to handle them differently than other commands

this is going to require downstream changes in the s2i image assemble scripts.  i'd like to at least hold off on this until we get 3.0.1 out the door.

specifically these lines:
https://github.com/openshift/sti-python/blob/master/3.3/Dockerfile#L19
we used to use ONBUILD to avoid this problem but that introduced its own complications.

There is already STI_SCRIPTS_URL variable defined. If we have also STI_SCRIPTS_PATH, we could change it once to COPY .sti/bin $STI_SCRIPTS_PATH and avoid similar issues in case the path changes again..

the STI_SCRIPTS_URL env variable was deprecated in favor of labels.  Which we recognized had the negative impact of making it impossible to use from assemble scripts.
but yes we can introduce a scripts_path env variable in the base image that's not part of the s2i API, but is used by our downstream images' Dockerfiles.

@hhorak @bparees i'm a little bit worried that having /usr/bin/run and /usr/bin/assemble can lead into conflict with other RPM's. Also moving the scripts to that location makes them automatically available in PATH (not sure if it can break something, but I have mixed feelings about that ;-)
I'm fine with following FHS and 'standardizing' the way how files are organized in our Docker images, but I also think that we should be careful.

agree, particularly given how generic "run" is.
@hhorak is there another option here?

If the potential conflict is the issue, we may probably use /usr/lib/sti/bin, similar to what qt uses. And add /usr/lib/sti/bin into path in dockerfiles...

yeah i think that would be better. (to avoid the conflict)

+1 for /usr/lib/sti/bin or /usr/libexec/sti/bin (we have at least more control on what will be in PATH)

@hhorak can you update this to use /usr/lib/sti/bin and introduce an env var that the downstream images can use for the COPY command?

@hhorak actually let's make it /usr/lib/s2i/bin  @mfojtik agree?

@bparees to me /usr/lib is strange because it usually doesn't contain any binaries, just .so files. The /usr/libexec is more appropriate (that is for example where gcc/go stores binaries).

So, /usr/libexec/s2i and having this path in $PATH? It seems less correct to me:
/usr/libexec includes internal binaries that are not intended to be executed directly by users or shell scripts. (http://www.linuxbase.org/betaspecs/fhs/fhs/ch04s07.html)

I think there are not more than two options here:
(1) either run/usage/build are expected to be run directly by users within the container; in that case those libraries cannot conflict with any other package (they don't now and I don't believe any other package will start using such general binary names)
(2) or run/usage/build are only expected to be run from outside using source-to-image (sti) tool; in that case they don't have to be in $PATH and placing them into /usr/libexec/s2i is totally correct
Which of the two options above do we talk here? AFAICT it is about (2).
But if we want to allow to do something like:
#> docker run -ti ... bash
docker> run

... is there a possibility to rename those libraries to something like s2i-run, s2irun insider the container or whatever like that? Then sti tool would simply use $STI_SCRIPTS_URL/run and users would call s2i-run when running the commands directly (without source-to-image).

@hhorak i'm really not sure why we are adding them to the path today.  @mfojtik @soltysh can you think of a reason we did that?  we should be invoking them with an absolute path anyway when s2i runs them.
and no we wouldn't expect a user to invoke run/assemble/save-artifacts/usage directly.  so yeah, I think we're in scenario (2)

@bparees I don't remember why we ended up with adding those scripts to $PATH but I'm positive (see here) we are prefixing the script name with a full path to it, so I'm ok with @hhorak scenario (2).

@hhorak so let's put them in /usr/libexec/s2i and set an env variable pointing there.
the downstream images can then copy their scripts to that location using the env variable.
can you update this PR to do that and i'll work on PRs for the downstream images and then we'll have to merge it all at once.

s2i image update PRs:
https://github.com/openshift/sti-perl/pull/51
https://github.com/openshift/sti-nodejs/pull/69
https://github.com/openshift/sti-php/pull/59
https://github.com/openshift/sti-python/pull/67
https://github.com/openshift/sti-ruby/pull/76
https://github.com/openshift/sti-wildfly/pull/59
@mfojtik please sanity check.

LGTM


Create works section for mobile portfolio project

The following additions were made to the portfolio project:

[ ] Create works branch
[ ] Add works section to portfolio project
[ ] Check linters working properly

Since the last review, the following changes were made:

[ ] Align both sections with flexbox
[ ] Add hover and pressed effect on buttons

Since the last review, the following changes were applied:

[ ] Add flexbox to .container-aboutme
[ ] Use responsive values in CSS rules where had not been applied [optional]