Remove deprecated method Window::move_to_foreground()

Follow-up of #83014, self-explanatory.
This PR can be merged as soon as the time is deemed right.

I don't see this being removed any time soon, so I don't think this is necessary to open at this point, I wouldn't delete this method until 5.0

I wouldn't delete this method until 5.0

That's one option, another would be to choose a standard number of minor releases until a deprecation gets removed, say 3 (which would make this PR mergeable after Godot 4.6), so that the whole process in standardized and understandable for the end user - instead of saying "this will get removed" we could say "this will get removed by version 4.x" instead.

That's not how we've done things in the past and I would say it shouldn't be done, it isn't an issue to have it there IMO, it's only very minor overhead, and honestly I'd say keeping the rule that we don't remove them until the next major release is a good incentive to not just casually deprecate things because it doesn't add as much baggage

Once it's going to be time everything that's marked as deprecated in the codebase will be removed. Doing this now for one specific method is asking to ruin someone's day.

Would absolutely have to be discussed extensively with regards to policy, I'd suggest someone should open a proposal for this

That's not how we've done things in the past and I would say it shouldn't be done, it isn't an issue to have it there IMO, it's only very minor overhead, and honestly I'd say keeping the rule that we don't remove them until the next major release is a good incentive to not just casually deprecate things because it doesn't add as much baggage

Sure, I can see why you'd prefer it that way. PR is already up, so it might as well wait for Godot 5.0.

Once it's going to be time everything that's marked as deprecated in the codebase will be removed. Doing this for one specific method is asking to ruin someone's day.

Oh, I didn't mean for my solution to only apply to this specific case, more so to set a precedent that would eventually apply to all other deprecations.

Would absolutely have to be discussed extensively with regards to policy, I'd suggest someone should open a proposal for this

https://github.com/godotengine/godot-proposals/discussions/10583


add version info and support reading from stdin

It would be useful if the tool's current version was displayed in the help text and/or via a -v or --version command line param
also as a command line tool IMO it should be able to accept the migration script from stdin. I have a tool that generates migration scripts and would like to pipe the output of that directly into contentful-migration
Thanks!

+1 for the version info!!

The version has been added


[Network] bump version from '2020-07-01' to '2020-08-01'

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network

For consumption and relay, there is no _py3.py for them, does the change for patch_model.py affect them?


Implementation of the Swap component

Closes https://github.com/yamada-ui/yamada-ui/pull/2740
Description
I developed a new animation component using Motion.
Initially, we planned to create the Swap component, but we decided to break it down and develop three separate components: Airy, Rotate, and Flip.

@kaehehehe
Great PR!
However, there is one thing I would like to confirm.
Since the <button> element is rendered in the browser, the Name attribute is essential for accessibility (e.g. by using aria-label, aria-labelledby, and more...).
Should we require users to always pass it, or should we set default values for these components internally?
Which specification will you adopt?

@koralle
These components provide animations and can be used in various ways depending on the user's preferences. Therefore, I believe it is better to require users to specify the values rather than setting default values.

@kaehehehe
Please summarize your commitments.


Update CONTRIBUTING.md Hernando Velez Ortiz cédula 93395393

aliases: algorithms
display_name: Algorithm
short_description: Algorithms are self-contained sequences that carry out a variety of tasks. topic: algorithm
wikipedia_url: https://en.wikipedia.org/wiki/Algorithm ---
Algorithms are detailed sets of guidelines created for a computer program to complete tasks efficiently and thoroughly.

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[x] My suggested edits are not about an existing topic or collection, or at least not a single one
[x] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

https://www.facebook.com/pages/AnexoPresidentes-del-Senado-de-la-República-de-Colombia/556338657806599?mibextid=ZbWKwL

https://www.facebook.com/pages/AnexoPresidentes-del-Senado-de-la-República-de-Colombia/556338657806599?mibextid=ZbWKwLEl 16 jun 2024 2:19 p. m., Soheil @.***> escribió:
@dnabookofficiaal commented on this pull request.
Review
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

https://www.facebook.com/pages/AnexoPresidentes-del-Senado-de-la-República-de-Colombia/556338657806599?mibextid=ZbWKwLEl 16 jun 2024 9:35 p. m., Eric Sorenson @.***> escribió:
Closed #4370.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


No problem with OSVRServer build, but samples will not work on NVIDIA Shield with Android 'M"

Created the build and it installed properly.  Started with screen identifying to wait a little before starting client app.  Started client app (both demos)  and no IMU tracking or stereo imaging.

It seems I am not installing the "binaries"  Where are the server binaries?

This is the output from Android Monitor when launching com.osvr.serverlauncher
It appears I don't have anything in the bin directory to run.
03-24 01:37:55.635 28899-28899/? I/art: Late-enabling -Xcheck:jni
03-24 01:37:55.653 28899-28905/? I/art: Debugger is no longer active
03-24 01:37:55.662 28899-28899/? W/ActivityThread: Application com.osvr.serverlauncher can be debugged on port 8100...
03-24 01:37:55.664 28899-28899/? W/System: ClassLoader referenced unknown path: /data/app/com.osvr.serverlauncher-1/lib/arm64
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libcrystax.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libfunctionality.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libgnustl_shared.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libjsoncpp.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libosvrClient.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libosvrClientKit.so already extracted.
03-24 01:37:55.679 28899-28899/? V/OSVRFileExtractor: libosvrCommon.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrConnection.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrJointClientKit.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrPluginHost.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrPluginKit.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrServer.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrUtil.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libosvrVRPNServer.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: libusb1.0.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: com_osvr_android_sensorTracker.so already extracted.
03-24 01:37:55.680 28899-28899/? V/OSVRFileExtractor: xusb already extracted.
03-24 01:37:55.702 28899-28899/? E/com.OSVR: Error when starting process: Error running exec(). Command: [/data/data/com.osvr.serverlauncher/files/bin/osvr_server] Working Directory: /data/data/com.osvr.serverlauncher/files/bin Environment: [ANDROID_ROOT=/system, ANDROID_BOOTLOGO=1, LD_LIBRARY_PATH=/data/data/com.osvr.serverlauncher/files/lib, EXTERNAL_STORAGE=/sdcard, SYSTEMSERVERCLASSPATH=/system/framework/services.jar:/system/framework/ethernet-service.jar:/system/framework/wifi-service.jar, ANDROID_SOCKET_zygote=12, PATH=/sbin:/vendor/bin:/system/sbin:/system/bin:/system/xbin, ANDROID_DATA=/data, ANDROID_ASSETS=/system/app, ASEC_MOUNTPOINT=/mnt/asec, BOOTCLASSPATH=/system/framework/core-libart.jar:/system/framework/conscrypt.jar:/system/framework/okhttp.jar:/system/framework/core-junit.jar:/system/framework/bouncycastle.jar:/system/framework/ext.jar:/system/framework/framework.jar:/system/framework/telephony-common.jar:/system/framework/voip-common.jar:/system/framework/ims-common.jar:/system/framework/apache-xml.jar:/system/framework/org.apache.http.legacy.boot.jar, ANDROID_PROPERTY_WORKSPACE=10,0, ANDROID_STORAGE=/storage]
03-24 01:37:55.709 28899-28916/? D/OpenGLRenderer: Use EGL_SWAP_BEHAVIOR_PRESERVED: true
03-24 01:37:55.754 28899-28916/? I/OpenGLRenderer: Initialized EGL, version 1.4

Similar experience, app runs but no server registering


Add guard for null organisations

When setting this up locally against a playground repository, I had the following exception:
Exception: java.lang.NullPointerException: Cannot invoke "org.kohsuke.github.GHOrganization.getLogin()" because the return value of "org.kohsuke.github.GHEventPayload$PullRequest.getOrganization()" is null
at io.quarkus.bot.PushToProjects.pullRequestLabeled(PushToProjects.java:78)
at io.quarkus.bot.PushToProjects_Multiplexer_Subclass.pullRequestLabeled$$superforward1(Unknown Source)
at io.quarkus.bot.PushToProjects_Multiplexer_Subclass$$function$$9.apply(Unknown Source)
at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:53)

The docs at https://docs.github.com/en/developers/webhooks-and-events/events/github-event-types say, for organisation, "The organization that was chosen by the actor to perform action that triggers the event.
The property appears in the event object only if it is applicable."

Makes sense, will do, thank you!


Configuration of group players

Update 'Manage Players' dialog to allow creating, updating, and deleting of group players. Will require updating the group players plugin to support these actions via CLI.
["groupmac", ["playergroup", 0, 100]] lists group details
["groupmac", ["playerpref", "playername", "X"]] sets group name
["groupmac", ["playerpref", "plugin.groups:members", ["maca", "macb"]]] sets group members

Initial work implemented for Material, and pull request created for Group Player plugin.

Group player changes have been merged.


Support Auto Compaction

Description

Support Auto Compaction described in:
https://docs.databricks.com/delta/optimizations/auto-optimize.html#how-auto-compaction-works
We can support Auto compaction via a new post commit hook and OptimizeCommand with less size threshold.
spark.databricks.delta.autoCompact.enabled (default: false)
spark.databricks.delta.autoCompact.maxFileSize (default: 128MB)
spark.databricks.delta.autoCompact.minNumFiles (default: 50)
The configs above are same as Databricks Auto compaction.
New config1 - autoCompact.maxCompactBytes
As it will be triggered after every table update, I introduced another config to control the total amount of data to be optimized for an auto compaction operation:
spark.databricks.delta.autoCompact.maxCompactBytes (default: 20GB)
In Databricks, it's adjusted based on available cluster resources. The config is a quick and easy workaround for it.
New config2 - autoCompact.target
The PR adds another new config - autoCompact.target to change target files for auto compaction.
spark.databricks.delta.autoCompact.target (default: "partition")

table: target all files in the table
commit: target only added/updated files of the commit which is triggering auto compaction.
partition: target only the partitions containing any of added/updated files of the commit which is triggering auto compaction.

Users are usually writing/updating data only for few partitions, and don't expect changes in other partitions.
In case the table is not optimized, the default behavior table might cause some conflicts between other partitions unexpectedly and added/updated files in the triggering commit might not be optimized if there are many small files in other partitions.
Fixes #815
How was this patch tested?

Unit tests
Does this PR introduce any user-facing changes?

Support Auto compaction feature

I didn't write a design doc & issue since it's straightforward.
Please let me know if we need a design documentation.

Hi @sezruby - thanks for this PR! It will take some time for us to review and verify it. We will get back to you.

Hi @sezruby - just updating you with the status on our end. We are very busy with planned features for the next release of Delta Lake, as well with preparation for the upcoming Data and AI summit in June.
So, it will take us some time to get back to you on this.

@vkorukanti Could you review the PR when you have the time? TIA!

@vkorukanti Could you review the PR when you have the time? TIA!

@vkorukanti @scottsand-db  A gentle reminder. This one is simpler than Optimize Write so I would like to merge this PR first.

Can you please fix the conflicts?

@scottsand-db @zsxwing  Could you review the PR?

We are also having this issue, we can't define disjoint conditions from both merge and optimize if they are done concurrently.

We are also having this issue, we can't define disjoint conditions from both merge and optimize if they are done concurrently.

@pedrosalgadowork which issue do you mean by? is it related to auto compaction?

@scottsand-db @zsxwing @tdas  Could you review the PR?

@scottsand-db @zsxwing @tdas - can you help review this PR? Its been open for several months now with no updates/comments recently.

Would be great to have this on Delta 2.3. Is it the plan to merge it soon?

Looks like there's some conflicts with the new DV stuff, had to update some things rebasing things on the 2.3 release in my fork.
Would be great to get some more looks at this and get this merged in, this is a highly valuable and missing feature.

@dennyglee @scottsand-db @zsxwing @tdas  Could you review the PR?

@dennyglee @scottsand-db @zsxwing @tdas  Could you review the PR? I'll resolve the conflict once you started actively reviewing.

@dennyglee @scottsand-db @zsxwing @tdas @allisonport-db  Could you review the PR?

Is there any obstacle to the review of this PR?

I am using your PR for optimize write in my EMR streaming use cases.
I want that optimize write should create around 128m parquet files but it is topping at 64m.
Configuration I am using is as below
"spark.sql.catalog.spark_catalog": "org.apache.spark.sql.delta.catalog.DeltaCatalog",
"spark.databricks.delta.autoCompact.enabled": "true",
"spark.databricks.delta.optimizeWrite.enabled": "true",
"spark.databricks.delta.autoCompact.minNumFiles": "500",
"spark.sql.adaptive.enabled": "true",
"spark.sql.adaptive.coalescePartitions.enabled": "true",
"spark.sql.adaptive.advisoryPartitionSizeInBytes": "128m",
"spark.sql.adaptive.coalescePartitions.minPartitionNum": "1",
"spark.sql.adaptive.coalescePartitions.initialPartitionNum": "200",
"spark.databricks.delta.optimizeWrite.binSize": "134217728
2023-09-22 08:22:54   61.9 MiB part-00000-eb8c145c-7ac4-420c-8b85-c6fd58861e40.c000.snappy.parquet
2023-09-22 08:24:55   43.7 MiB part-00001-4fbd8215-5129-48aa-b858-d2ab9d2ca7a6.c000.snappy.parquet
2023-09-22 08:24:58   54.8 MiB part-00000-de4d1a37-543c-4c80-a2dd-9cbc06af7b3c.c000.snappy.parquet
2023-09-22 08:27:06   52.7 MiB part-00000-c6cf2c15-8dc3-4346-a03c-eb83171fdf46.c000.snappy.parquet
2023-09-22 08:27:06   59.3 MiB part-00001-a5f3db2e-e352-45b0-aa1b-bbf1570ebb6f.c000.snappy.parquet
2023-09-22 08:28:56   69.1 MiB part-00000-697cca77-e7ea-4267-9f7b-3fd406678b31.c000.snappy.parquet
2023-09-22 08:31:03   52.8 MiB part-00000-3dfbf27e-53f3-4f35-8955-7675d0ec86bf.c000.snappy.parquet
2023-09-22 08:31:05   60.5 MiB part-00001-6b7bc1d7-9882-4ba0-a01b-619a0a424ae4.c000.snappy.parquet
2023-09-22 08:32:58   32.5 MiB part-00001-ea4d882a-f182-48d4-a3e8-bc23260e617e.c000.snappy.parquet
2023-09-22 08:33:03   54.1 MiB part-00000-4c53bf10-eede-45c3-b178-f9d4f2895956.c000.snappy.parquet
2023-09-22 08:35:00   45.7 MiB part-00001-138bdaab-8d77-4faf-af49-489c4cfad4f6.c000.snappy.parquet
2023-09-22 08:35:01   51.7 MiB part-00000-62a2bdfa-9dea-41ff-9f8c-4e3ebcb12d04.c000.snappy.parquet
2023-09-22 11:42:10   52.0 MiB part-00000-64bccc7b-2664-4e67-b478-413a5a7554db.c000.snappy.parquet
2023-09-22 11:42:12   57.9 MiB part-00001-b79e83d9-c65e-438b-a555-aa2028320ea5.c000.snappy.parquet
2023-09-22 11:45:20   56.4 MiB part-00001-1ef411fb-160c-4cba-a5e7-cdee540295a5.c000.snappy.parquet
2023-09-22 11:45:20   57.0 MiB part-00004-fa51fd84-c4d3-4980-9a88-5566283d3234.c000.snappy.parquet
2023-09-22 11:45:20   57.5 MiB part-00005-80e03284-a8a6-4937-857c-1c434527c956.c000.snappy.parquet
2023-09-22 11:45:20   57.8 MiB part-00000-a347b170-d15f-4328-b402-ccdc099e94da.c000.snappy.parquet
2023-09-22 11:45:20   57.9 MiB part-00006-d566e257-f0cf-4cf9-b968-cad449784226.c000.snappy.parquet
2023-09-22 11:45:20   57.9 MiB part-00009-18a54bcf-3d53-4766-b485-62332266c974.c000.snappy.parquet
2023-09-22 11:45:20   58.5 MiB part-00003-8cf66203-9a32-41b5-a617-a3a9e9b2e465.c000.snappy.parquet
2023-09-22 11:45:21   38.7 MiB part-00010-1b8e65ae-b366-46fa-818e-d8ac95fd5904.c000.snappy.parquet
2023-09-22 11:45:22   57.1 MiB part-00007-05dc33ff-5125-435f-b0f1-f4215fba9d5b.c000.snappy.parquet
2023-09-22 11:45:22   58.9 MiB part-00008-5c99002a-1d7b-4db5-8c14-8e3f966773ec.c000.snappy.parquet
2023-09-22 11:45:23   57.6 MiB part-00002-6844ca06-b437-486f-b15b-ebf93fc0e740.c000.snappy.parquet

@sezruby  In Class spark/src/main/scala/org/apache/spark/sql/delta/OptimisticTransaction.scala method "groupFilesIntoBins"
val filteredByBinSize = bins.filter { bin =>             // bin size is equal to or greater than autoCompactMinNumFiles files             bin.size >= autoCompactMinNumFiles ||             // or bin size + number of deletion vectors >= autoCompactMinNumFiles files             bin.count(_.deletionVector != null) + bin.size >= autoCompactMinNumFiles           }.map(b => (partition, b))
why are we using  individual bin.size while comparing to autoCompactMinNumFiles ?
If total files size are greater than  autoCompact.maxFileSize and total number of files are >  MinNumFiles, but after segregating it in bins by size the individual bins will always have lesser files than MinNumFiles and hence it will not auto-compact  the files.
Any particular reason for doing that ? i understand it might cause compaction of some small file but isn't it better than no compaction ?

I think autoCompact should be available now? since it's documented here

Yes, since Delta 3.1. This PR can be closed now.

Thanks! Do you know whether autoCompact would work when using with spark structured streaming with delta table as the sink?

Hi @sezruby
Please can you close this PR because it is available since 3.1.


ja: Make docs/concepts/configuration/manage-resources-containers.md follow v1.18 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/configuration/manage-resources-containers.md to follow v1.18 of the original (English) text.
Why is this needed
content/ja/docs/concepts/configuration/manage-resources-containers.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.18-ja.2/content/ja/docs/concepts/configuration/manage-resources-containers.md
Original
https://github.com/kubernetes/website/blob/fb6364d/content/en/docs/concepts/configuration/manage-resources-containers.md
diff between translated and v1.18
https://gist.github.com/dad447f1ac6bd6b5f84849e064837fbc
Note
Currently, we use dev-1.18-ja.2 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

Note
manage-resources-containers.md was renamed as manage-resources-containers.md at release 1.18.
Actual diff is here.

/triage accepted

/assign

/close

/close

/close


Warnings with ITKv5.1 + clang11

In file included from /user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/src/itkBioGene.cxx:19:
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:35: warning: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
using ControlDomainType = struct
^
ControlDomainType
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:29: note: type is not C-compatible due to this member declaration
using ControlDomainType = struct
^~~~~~
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:9: note: type is given name 'ControlDomainType' for linkage purposes by this alias declaration
using ControlDomainType = struct
^
1 warning generated.
[289/3196] Building CXX object Modules/Remote/BioCell/test/CMakeFiles/BioCellTestDriver.dir/itkBioGeneTest.cxx.o
In file included from /user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/test/itkBioGeneTest.cxx:21:
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:35: warning: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
using ControlDomainType = struct
^
ControlDomainType
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:29: note: type is not C-compatible due to this member declaration
using ControlDomainType = struct
^~~~~~
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:9: note: type is given name 'ControlDomainType' for linkage purposes by this alias declaration
using ControlDomainType = struct
^
1 warning generated.
[314/3196] Building CXX object Modules/Remote/BioCell/CMakeFiles/BioCellHeaderTest1.dir/test/BioCellHeaderTest1.cxx.o
In file included from Modules/Remote/BioCell/test/BioCellHeaderTest1.cxx:28:
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:35: warning: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
using ControlDomainType = struct
^
ControlDomainType
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:29: note: type is not C-compatible due to this member declaration
using ControlDomainType = struct
^~~~~~
/user/iibi/johnsonhj/src/ITK/Modules/Remote/BioCell/include/itkBioGene.h:52:9: note: type is given name 'ControlDomainType' for linkage purposes by this alias declaration
using ControlDomainType = struct
^

@mseng10  Please fix this when addressing other remote issues.

@hjmjohnson I am having issues reproducing this error. I am using ITKv5.1 and clang11. I was able to reproduce the other clang error for BSplineGradient.


Bash-Problems with 1.10.1

I´m Using macOS 10.15.7 and have updated to Bitbar 1.10.1.
After this Update:

Linefeed in the menubar (\n) doesn't work anymore
Buttons like "echo "View Realtime Log | color=back bash='$0' param1=show_tm terminal=true refresh=false" doesn't work anymore.

=> after 1h of trying I´m now back on 2-beta10 without this problems :-(

Okay -it´s reproducebal, the option
terminal=true doesn't work anymore.
The Terminal opens, but the script doesn't start

Sorry @warmup72, this is annoying. There's some work to do to figure out what's changed here.


KerbalStuff PR catchup

Each passes local, Jenkins can't handle all this awesomeness though.

Re-tested, all working today. Merging before any of them issue an update that breaks the netkans. =)


gondatsu everywhere

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #230

PR #235   👈

This stack of pull requests is managed by Graphite.


Chore/upgradedeps414141

Cannot parse part of the signature header, key "v42" is not supported by this version of Blockfrost SDK.

Cannot parse part of the signature head

that's a warning and it is fine. it is an output of a test that verifies the  thrown an error on unsupported version. It has been there since webhooks.
the problem is here (current epoch has empty list of retiring pools or something like that) and I already fixed it in another PR. I'll rebase and everything should be stellar!
@blockfrost/blockfrost-js:test:     Expected: ArrayContaining [ObjectContaining {"epoch": Any<Number>, "pool_id": Any<String>}]
@blockfrost/blockfrost-js:test:     Received: []


Add telemetry with the exception call stack

Make sure you don't send the entire exception since message can contain paths, file names and other PII information. Call stack and type of exception is typically sufficient.


Your documentation page is down

Your documentation link isn't working:

wtf, now its not anymore. sorry, very weird


fix(jwt): replace deprecated gorilla/securecookie [EE-5153] (#9262)

fix EE-5822

opened by mistake


Does lightning attention cause improper parallelization pthreads in memory?

I try to replace the Attention layer in a typical Transformer with lightning attention, however, when I run the code, some unexpected error happens.
Here is what I test to do:

The original code snippets:

class FullAttention(nn.Module):
    def __init__(self, mask_flag=True, scale=None, attention_dropout=0.1, output_attention=False):
        super(FullAttention, self).__init__()
        self.scale = scale
        self.mask_flag = mask_flag
        self.output_attention = output_attention
        self.dropout = nn.Dropout(attention_dropout)

    def forward(self, queries, keys, values, attn_mask, n_vars=None, n_tokens=None, tau=None, delta=None):
        B, L, H, E = queries.shape
        _, S, _, D = values.shape
        scale = self.scale or 1. / sqrt(E)

        scores = torch.einsum("blhe,bshe->bhls", queries, keys)

        if self.mask_flag:
            if attn_mask is None:
                attn_mask = TriangularCausalMask(B, L, device=queries.device)

            scores.masked_fill_(attn_mask.mask, -np.inf)

        A = self.dropout(torch.softmax(scale * scores, dim=-1))
        V = torch.einsum("bhls,bshd->blhd", A, values)

        if self.output_attention:
            return V.contiguous(), A
        else:
            return V.contiguous(), None

The replaced code snippets:

class LightningAttention(nn.Module):
    def __init__(self, mask_flag=True, scale=None, attention_dropout=0.1, output_attention=False):
        super(FullAttention, self).__init__()
        self.output_attention = output_attention
        self.s = _build_slope_tensor(self.n_heads).to(torch.float32)
        self.s.requires_grad = False

    def forward(self, queries, keys, values, attn_mask, n_vars=None, n_tokens=None, tau=None, delta=None):
        B, L, H, E = queries.shape
        _, S, _, D = values.shape
        queries = queries.permute(0, 2, 1, 3)
        keys = keys.permute(0, 2, 1, 3)
        values = values.permute(0, 2, 1, 3)
        V = lightning_attn_func(queries, keys, values, self.s.to(queries.device))

        return V.contiguous(), None

I intended to simply test whether lightning attention could process data in a causal manner. However, after the replacement, although the model could normally complete the training process in one epoch, it will encounter segment faults or LLVM ERROR: pthread_join failed: Invalid argument on the valid Dataloader. Specifically, the error would happen at such a line:
for i, (batch_x, batch_y, batch_x_mark, batch_y_mark) in enumerate(vali_loader):

And all the above would not happen with the original FullAttention layer.
I search for the solutions, but get confused. Some recommand me set num_workers to 0 and persistent_workers to False to check whether it's because of errors related to parallelization. And, well, it works. I have noticed that lightning attention uses thread block operations via triton, do these steps cause improper resource competition when multiple Dataloaders work together? (I don't know much about this, but from the current situation I can only solve this issue by canceling parallel data loading, which greatly slows down the data loading speed T_T)
Could the author help figure out where the problem might be?

Thank you for your interest in the project. In fact, I encountered a similar error in another project, but it hasn't been completely resolved yet. My current hypothesis is that it might be related to num_warps. You can pass num_warps=2 or num_warps=4 at this location, this location, and this location. If you encounter any new issues, please feel free to ask.


Error detected while processing function 33_BufWritePostHook

I'm using MacVim and after editing .slim file I get the following error (I don't get it when using vim from console)
Error detected while processing function <SNR>33_BufWritePostHook..<SNR>33_UpdateErrors..<SNR>33_CacheErrors..15..14..SyntaxCheckers_slim_slimrb_GetLocList..Sy
ntasticMake..syntastic#preprocess#slimrb:
line   24:
E684: list index out of range: 0
Error detected while processing function <SNR>33_BufWritePostHook..<SNR>33_UpdateErrors..<SNR>33_CacheErrors:
line   35:
E170: Missing :endfor
Error detected while processing function <SNR>33_BufWritePostHook..<SNR>33_UpdateErrors:
line   15:
E171: Missing :endif

Then your MacVim uses a different version of syntastic than your console Vim.  Please see #1587 for a solution (tl; dr: upgrade syntastic to master HEAD).

Indeed, thank you!


Add Device Integration page

Description
We need to create a page that documents how hardware vendors can pre-load our device agent on to their hardware platform.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

https://docs.google.com/document/d/16A98K6eQyJhoKc5H5oO7ZfAZOxRSZQqZHMXwWmjPVm0/edit?usp=sharing

Hi @MarianRaphael in the document you shared, there's the first part (only text), and the second part: an image as an idea for the layout. The image has more/different content. Which one should I use as a guide? In case is the text, for certification it only says: book a meeting, this should link to /book-demo, am I correct?

Here's a proposal using the content from the first section of the document

Design looks great!

Is this going to be under "product"?


Add feature guard to native assets build system target

Fixes https://github.com/flutter/flutter/issues/138855

This test failure looks legit
[2023-11-21 16:09:40.972003] [STDOUT] stderr: [   +1 ms] CMake Error at cmake_install.cmake:124 (file):
[2023-11-21 16:09:40.972072] [STDOUT] stderr: [        ]   file INSTALL cannot find
[2023-11-21 16:09:40.972096] [STDOUT] stderr: [        ]   "/b/s/w/ir/x/t/flutter_devicelab_plugin_test.ASDOPE/plugintest/example/build/native_assets/linux":
[2023-11-21 16:09:40.972281] [STDOUT] stderr: [        ]   No such file or directory.
[2023-11-21 16:09:40.972738] [STDOUT] stdout: [        ] FAILED: CMakeFiles/install.util

@christopherfujino are you still working on this?

No, I'm not.


feat(export): add --export-upper and --export-include-path options

fixes #270
Adds the following options to vkv export:
--export-upper will upper-case all env var keys:
> vkv export -p secret/sub/demo -f export --export-upper
export DEMO='hello world'
export PASSWORD='s3cre5<'

--export-include-path will prefix the secrets path and use _ as the delimiter:
> vkv export -p secret/sub/demo -f export --export-upper --export-include-path
export SECRET_SUB_DEMO_DEMO='hello world'
export SECRET_SUB_DEMO_PASSWORD='s3cre5<'
export SECRET_SUB_DEMO_USER='admin'

Thanks for taking a stab at it.
FWIW, at the moment it wouldn't be of much value to me because the secrets are stored with just 1 key (value) per secret (instead of multi-key secrets), so this would print out something like:
> vkv export -p secret/sub/demo -f export --export-upper
export VALUE='hello world'

> vkv export -p secret/sub/demo -f export --export-upper --export-include-path
export SECRET_SUB_DEMO_VALUE='hello world'

eg the secrets are put into vault like so
vault kv put ${VAULT_NAMESPACE//\//_}_secret/sub/foo value=bar
vault kv put ${VAULT_NAMESPACE//\//_}_secret/sub/baz value=qux
vault kv put ${VAULT_NAMESPACE//\//_}_secret/sub/admin value=password
vault kv put ${VAULT_NAMESPACE//\//_}_secret/sub/creds<EMAIL_ADDRESS>
Ideally how I'd like to use this is
> vkv export -e secret -p sub -f export --export-field=value --export-include-path
export SUB_FOO=bar
export SUB_BAZ=qux
export SUB_ADMIN=password
export SUB_CREDS='{
  "json": true
}'

Note that --export-field is akin to vault kv get --field=value and --export-include-path is only including the value passed to the -p flag, because the engine is actually quite a long path in my use case (-e something/team/kv1 or -e something/app/kv2) and I don't want that to be included in the env var name.

Okay, I see.. . I understand now. --export-flatten is indeed the correct wording for such output format.
In #265 I'm working on a complete refactor of vkv and adding a new output format would be much easier, until then I think I'm just going to add export-flatten  format which outputs the examples you've provided, even though I would argue it's a rather niche use case.
Will give you a heads-up once I'm done adding the format :)

Sounds good to me! Thanks for considering this use case in the first place

superseeded by #277


Match the latest LNPBP-6 spec

See https://github.com/LNP-BP/LNPBPs/pull/116 for the details

Deprecated since switch to TapRet commitments


[BUG] Methods not seen as keywords from inherited class

Describe the bug
When using custom Python library and class inheriates another class.
Methods from inherited class are not seen as a keywords.
If I move method to main class then plugin can use those methods normally.
To Reproduce
Create a two classes e.g. A and B.
A inheriates B class.
Implement method in class B
Import custom python library in robot with name and try to call method from robot which is defined in class B
Expected behavior
Methods in all class hierarchy seen as keywords if not defined private or annotated to behave differently.
Screenshots/ Videos

Desktop (please complete the following information):

VS Code Version: 1.75.1
RobotCode Version: 0.27.1
OS: Windows
Python Version: 3.8.10
RobotFramework Version: 4.1.3

This should work, maybe the cache is not valid.
can you try to clear the cache by pressing F1 and execute the command "RobotCode: Clear Cache and Restart Language Servers" and see what happens?
If this does not fix the issue, can you give an exact example, because I cannot reproduce this error.

Yes, that helped.
Thanks.
Solved.


Addribute not passed to include:template[]

We use the Include directive to render a Template. We pass a attribute to the template so we can conditionally render stuff.
Main
:template: template
include::../../../_template-printer.adoc[]

_template-printer.adoc
ifndef::template[]
WARNING: This is allways printed
endif::[]

ifdef::template[]
This is not printed
endif::[]

Within the PDF render from adoc and the IDEA extension this is rendered.
Any idea how to solv this problem? or

Ok this is not a bug or Problem here.
I was a Preprocessor of our internal tooling.


Re-evaluate BUIC vars

We have about ~500 hits for BUIC vars within the AppUI repo

In 4.0, we switched to using iTwinUI vars, and most of these BUIC vars are aliases for iTwinUI vars.
Does having both BUIC and iTwinUI vars add confusion? If so, remove all BUIC vars in a new major, and just use iTwinUI all the way through
### Tasks
- [ ] Change scss from `var(--buic` to `var(--iui` (Non breaking) (134 hits)
- [ ] Remove `--buic` vars (**Breaking**) (85 hits)
- [ ] Reduce number of `$buic-` sass variables (**breaking**) (91 hits)

Duplicate of https://github.com/iTwin/appui/issues/958


[Fix] Proposal fails bcz few transmissions

This PR is to fix this bug：https://github.com/AleoNet/snarkOS/issues/3263

Let's await this discussion first: https://github.com/AleoNet/snarkOS/issues/3263#issuecomment-2120311895


Chrome V66 placeholder doesn't dissapear on-focus

Hello,
With Chrome version 66 when you focus on the input field the placeholder text doesn't disappear until you start typing, however in IE11 it does.
EDIT:
I added to css:
.fl-form .fl-has-focus input.fl-input::-webkit-input-placeholder {
color: #fff;
}
Seems to have fixed it. Not sure if this is best way to go around it.
You can close ticket if so.

This is non-standard behaviour that is caused by a bug in Internet Explorer 10-11.
As it does not affect the functionality of Float Labels, I am closing this issue.
Please also see:
https://stackoverflow.com/questions/14445891/keep-placeholder-on-focus-in-ie10/16138480#24319798


dark mode functionality added

Description:
I have added Dark Mode functionality, and it is globally set. This means that once you toggle it, it will work throughout the entire site.

Thanks @meetamjadsaeed  for this feature

Thanks @meetamjadsaeed for this feature

I'm glad I could help.


Conflicting description of calculating address into data region

The descriptions showing how to calculate addresses into the data section are in conflict and the example doesn't help (I think it's wrong).
$offset_in_file = ( $record_value - $node_count )
+ $search_tree_size_in_bytes + 16
I think the above is correct, but it conflicts with the description below and the example given.
$data_section_offset = ( $record_value - $node_count ) - 16
The -16 should either be deleted, or it should be +16 if referenced from the end of the search tree.

Actually, it's the "+ 16" that's wrong. We had fixed that a while back but apparently forget to update the GitHub pages. Thanks!

Hmm, or maybe not. We'll discuss this a bit more internally.


fix: show display name (if not username) instead of email on front end

Show the logged in user's display name (if not username) instead of email on the front end.

I suspect that we are passing more than we need to for user to the front end. This works fine (though one small change is needed before we can merge); however, we may want to instead explicitly return the attributes we need:
json.user do
  json.(current_user, :role, :display_name, :other_attrs)
end

thanks, that is a smarter way of doing it. adapted the code.


Cowboy server is attacked

=ERROR REPORT==== 2-Jan-2016::01:24:05 ===
Error in process <0.867.0> with exit value:
{function_clause,
[{cowboy_protocol,parse_method,
[<<>>,
{state,#Port<0.2244>,ranch_tcp,
[cowboy_router,cowboy_handler],
false,
[{listener,http},
{dispatch,
[{'_',[],
[{[],[],cowboy_static,{priv_file,kuai,"index.html"}},
{[<<"search">>],[],search,[]},
{['...'],[],cowboy_static,{priv_dir,kuai,[]}}]}]}],
undefined,5,1,100,4096,64,4096,100,5000,-576251932192},
<<0,0,0,113,106,129,110,48,129,107,161,3,2,1,5,162,3,2,1,10,164,129,
94,48,92,160,7,3,5,0,80,128,0,16,162,4,27,2,78,77,163,23,48,21,
160,3,2,1,0,161,14,48,12,27,6,107,114,98,116,103,116,27,2,78,77,
165,17,24,15,49,57,55,48,48,49,48,49,48,48,48,48,48,48,90,167,6,2,
4,31,30,185,217,168,23,48,21,2,1,18,2,1,17,2,1,16,2,1,23,2,1,1,2,
1,3,2,1,2>>],
[{file,"src/cowboy_protocol.erl"},{line,175}]}]}
i think cowboy need add the code
parse_method(<< C, Rest/bits >>, State, SoFar) ->
case C of
$\r -> error_terminate(400, State);
$\s -> parse_uri(Rest, State, SoFar);
_ -> parse_method(Rest, State, << SoFar/binary, C >>)
end;
parse_method(<<>>, State, _SoFar) ->
error_terminate(400, State).

#448


Invoking Dockerfile commands from a script

Hello, I'm writing a small shell script called DHELPER which I can use from my Dockerfiles to simplify a few issues, it has a few subcommands. One that I'm trying to add is INSTALL, which would work like this:
# My docker image
FROM pomke/base
MAINTAINER pomke<EMAIL_ADDRESS>
# install some services
RUN DHELPER INSTALL example.com/nginx/Dockerfile
RUN DHELPER INSTALL example.com/munin/Dockerfile

# .. do my own stuff here

The DHELPER INSTALL command fetches a dockerfile, strips out FROM and MAINTAINER etc commands and would execute ADD, RUN, WORKDIR etc commands in place, as if they were included in my current dockerfile.
So I'm trying to work out of there is a way I can invoke Dockerfile commands from a script of my own, within the context of a building image.
Thanks!
- Pom

hmm  could this be solved with ONBUILD
@tiborvass did you have something in mind i see you are assigned

This is similar to #7277 (although more precise in what it would be doing). We could close this as a dupe but that other issue has two distinct threads that are somewhat related (I intend to add a long comment on that one).

Hello!
We are no longer accepting patches to the Dockerfile syntax as you can read about here: https://github.com/docker/docker/blob/master/ROADMAP.md#22-dockerfile-syntax
Mainly:

Allowing the Builder to be implemented as a separate utility consuming the Engine's API will open the door for many possibilities, such as offering alternate syntaxes or DSL for existing languages without cluttering the Engine's codebase

Then from there, patches/features like this can be re-thought. Hope you can understand.


Fix #1241: File transport, pagination not working when order = "desc"

This corrects file transport query code,  to leverage fs-reverse new dependency, and allow correctly paginate logging results from newer to older logs

@DABH as you wish:

I can fork and publish under my own name (being me the maintainer)
The code is so simple that i can put the code on vey self winston and be maintained alongside winston repo (ie. const fsReverse = require('./fsReverse.js')

What do you prefer?

@DABH  tough option 2 was better; rebased on top of master.

@DABH now that you have publish access, can you move this please? Need it a lot! Cheers

@DABH ping!


Lookahead decoding | forking + "appending" to child sequences.

Hi, @WoosukKwon  and @zhuohan123 ,
Fantastic project!
I was taking a stab at implementing a version of greedy lookahead-decoding. Given some candidate completions, I was trying to:

Fork children from the parent sequence
Append new tokens (from the candidates) to the children sequences
Call step in the engine to parallelize the next token prediction across candidates
Verify and select the longest prefix
Append this to the parent sequence
Discard all children sequences created in step#1

I had a question about the behavior of Sequence.append_token_id, and its implications on the future engine steps.
https://github.com/vllm-project/vllm/blob/24f60a54f42076e0bfa49fde113756bf4e95f9ef/vllm/sequence.py#L159-L167
From the looks of it, if I append a token here, it should add the token to the appropriate blocks.
But when I try this in practice, I get a different output. Suppose the LLM was generating
912 -> 442 -> 42

I intervene after it has generated 912, and append 442 using .append_token_id , and then call step(). But I see
912 -> 442 -> 10

Seeding is not the problem -- I have accounted for that.
Tagging some folks who had previously participated in lookahead/speculative decoding discussions.
@simon-mo @LiuXiaoxuanPKU @skrider @beginlner

I found the problem. This is fixed.
I'll leave the issue open in case someone has thoughts on this approach. Now that the outputs are matching (with and without the interventions) I'll try to finish a draft and see if it works.

I'll try to finish a draft and see if it works.

Hi @priyamtejaswin do you have a draft already? I am also interested in taking this further (especially Lookahead + PagedAttention)

I believe once https://github.com/vllm-project/vllm/pull/2188 is merged you can add Lookahead as the proposer, since verification of tokens is the same.

lookahead decoding supports flash attention and sampling both now.
https://github.com/hao-ai-lab/LookaheadDecoding

Closing this as a duplicate of #1742.
The work @cadedaniel mentioned has been completed and the discussion for this feature is more active in the issue I linked above.


RFC: WIP: add dynamic cyrillic translit linguistic skill

This is an attempt to add support for a Cyrillic-to-Latin transliteration skill that would also be language aware.
This is not validated and not working well with the default prompt defined in cli repo. (The prompt produces new instructions that are not retaining the transliteration scheme.)
Whether we need to use a model to generate variations of the generated instructions is itself a topic for exploration. (Perhaps we could live with feeding the seed samples generated by the skill directly into fine tuning.) But if so, additional changes may be required on cli side to e.g. allow to use modified (or completely new?) prompts if needed for a particular skill.
This is work-in-progress and is posted as a discussion starter.
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

...
...
...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

[ ] The contribution was tested with ilab generate
[ ] No errors or warnings were produced by ilab generate
[ ] All commits are signed off (DCO)
[ ] The qna.yaml file contains at least 5 seed_examples
[ ] The qna.yaml file was linted and prettified (yaml-validator can do both)
[ ] An attribution.txt file in the same folder as the qna.yaml file
[ ] Content does not include PII or otherwise sensitive or confidential information
[ ] Content does not include anything documented in the project's Avoid these Topics guidelines

I don't think this is in plan for the overall InstructLab project. So I think we should close this here until such time as dynamic qna.yaml generation is planned.

Agreed, this would actually probably better in the dev-doc repo too because this would require a much larger scope then just our taxonomy repository.


fix: fix docs search

Coverage remained the same at 76.297% when pulling 46f5bff40e87d71eb6d3fcc07c76e6368eaa8338 on Swilder-M:docs-search into 677930f6ecadd3c579c4e7e535236a9f153c1356 on emqx:main.


Add support for knowledge provider configuration

This issues aims to extend Smarti for „Knowledge Provider“ configuration support.
As Smarti extracts keywords and other facts from a conversation, these should be used to query external information sources, called knowledge provider. Currently only one Solr endpoint can be configured. In order to attach enterprise search engines or public web searches as google, we need a flexible deployment configuration as well as a runtime configuration for client* specific settings. Also endusers should be able to modify search parameters (filters, keywords, etc.) via the Smarti UI.
*Remark: A client is identified by a "domain" which is already part of all requests issued to Smarti.
1. deployment configuration (for all customers, target group: operations)

Additional Search/Knowledge Provider like google, Solr or other external search providers are added with essential configuration (e. g. which token types are forwarded as search terms)
Changing this configuration needs a server reboot
Maybe this will be done via the application.properties

2. runtime configuration (per customer, target group: development)

The development team should be able to select and configure the specific knowledge providers that are relevant for the client
In the case of google and or Solr multiple instances of the same source must be configurable
This configuration should have a UI

3. UI integration (user behavior, target group: enduser)

At run-time users should be able to select sources they want to search, e.g. by selecting/changing a source in the Smarti UI. This is important if Smarti suggest the "wrong" source or if another source is more appropriate.
the user is able to initiate a search in a specific source when the "human intelligence" knows the right way to search
the interaction with the results of external sources gives us information about the relevance of result entries. This information should not be lost. Instead the usage of search result suggestions should be tracked somehow, in order to improve the scoring

Acceptance criteria

[ ] Several Solr endpoints can be configured (server-side)
[ ] Google search can be configured (server-side)
[ ] Multiple websites/instances of google site search can be configured via Smarti admin UI
[ ] Special search parameters can be configured for each client/search config
[ ] The end user is able to change/select/deselect search sources, keywords etc. via the Smarti UI

@westei: Underlying structural changes will be applied starting this week:

Component lifecycle of Spring components: If a user changes configuration, the normal component lifecycle cannot be used, as components are usually being loaded only on application startup
Customer specific configuration needs to be stored somewhere => Mongo

Configuration for the generic SolrQuery provider
    {
      "_class": "io.redlink.smarti.query.solr.SolrEndpointConfiguration",
      "name": "solrsearch",
      "displayName": "solrsearch",
      "type": "solrsearch",
      "enabled": false,
      "unbound": false,
      "solrEndpoint": "http://search.db.de/change/me",
      "search": {
        "title": {
          "enabled": true,
          "field": "text"
        },
        "fullText": {
          "enabled": true,
          "field": "text"
        },
        "spatial": {
          "enabled": false,
          "locationNameField": null,
          "latLonPointSpatialField": null,
          "rptField": null,
          "bboxField": null
        },
        "temporal": {
          "enabled": false,
          "timeRangeField": null,
          "startTimeField": null,
          "endTimeField": null
        },
        "related": {
          "enabled": false,
          "fields": []
        }
      },
      "defaults": {},
      "result": {
        "title": "title",
        "description": "description",
        "icon": "icon",
        "url": "url",
        "keywords": "keywords"
      }
    }


Right-hand side of 'instanceof' is not an object

Hi,
Im getting the below-mentioned error, please check and clarify
"Right-hand side of 'instanceof' is not an object" (In Process.php line 230:)
When I turn on the debug true,
TypeError: Right-hand side of 'instanceof' is not an object
      at PuppeteerConnectionDelegate.handleInstruction (/media/administrator/Storage/Projects/vp/BssApi/vendor/extractr-io/puphpeteer/src/P
  uppeteerConnectionDelegate.js:44:19)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

I actually removed the lines instance of Brower checking and it is working fine.
My Environment details

ubunto os: 16.04
PHP: 7.1.15
Node: 8.9.3 (NPM: 5.6.0)

Coul you please give me a reproducible example?

Im using this in the laravel project -> commands (console), below is my handle function
        $puppeteer = new Puppeteer([
            'read_timeout' => 100,
            'debug' => env('APP_DEBUG')
        ]);
        $browser = $puppeteer->launch([
            'headless' => env('APP_DEBUG'),
            'ignoreHTTPSErrors' => true
        ]);

        $page = $browser->newPage();
        $page->setViewport(['width' => 1920, 'height' => 1080]);

        // Login first
        $page->goto('http://xxxxxx.in/home.do#', ['waitUntil' => 'networkidle2']);
        $page->type('.loginEmail', env('xxxxxx_USERNAME'));
        $page->type('.loginPassword', env('xxxxx_PASSWORD'));
        $page->click("#login input[type='submit']");
        $page->waitForNavigation();

I think this project is really cool, but I'm getting the same error as the OP.
Here is my configuration:

Windows 10 Pro
Running in Git for Windows bash (version 2.16.0.windows.2)
PHP 7.1.16 (cli) (built: Mar 28 2018 21:15:22) ( NTS MSVC14 (Visual C++ 2015) x64 )
Node v8.9.4

I'm using the 0.2.1 version of puphpeteer.
My PHP code is something like this:
$puppeteer = new Puppeteer(['debug' => true]);
$browser   = $puppeteer->launch();

$page = $browser->newPage();
$page->goto('https://example.com');
$page->screenshot(['path' => 'example.png']);

$browser->close();

My code is failing on the call to launch().
Here is the error I receive:
Fatal error: Uncaught ExtractrIo\Rialto\Exceptions\Node\FatalException: Right-hand side of 'instanceof' is not an object

TypeError: Right-hand side of 'instanceof' is not an object
    at PuppeteerConnectionDelegate.handleInstruction (vendor\extractr-io\puphpeteer\src\PuppeteerConnectionDelegate.js:42:19)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7) in vendor\extractr-io\rialto\src\ProcessSupervisor.php:230
Stack trace:
#0 vendor\extractr-io\rialto\src\ProcessSupervisor.php(322): ExtractrIo\Rialto\ProcessSupervisor->checkProcessStatus()
#1 vendor\extractr-io\rialto\src\ProcessSupervisor.php(285): ExtractrIo\Rialto\ProcessSupervisor->readNextProcessValue()
#2 vendor\extractr-io\rialto\src\Traits\CommunicatesWithProcessSupervisor.php(83): ExtractrIo\Rialto\ProcessSupervis in vendor\extractr-io\rialto\src\ProcessSupervisor.php on line 230

Let me know if you need any more information or want me to test something.
Thanks!

Actually, I have a hard time reproducing the issue. Could you edit vendor/extractr-io/puphpeteer/PuppeteerConnectionDelegate.js in your project and add this code in line 41 (provide a valid file path in this code)?
const filePath = '/path/to/a/safe/directory/to/write/debug.txt';
require('fs').writeFileSync(filePath, typeof Browser);
if (Browser && Browser.toString) require('fs').appendFileSync(filePath, '\n\n' + Browser.toString());
require('fs').appendFileSync(filePath, '\n\n' + JSON.stringify(Browser));

Then run (new \ExtractrIo\Puphpeteer\Puppeteer)->launch() in PHP and send me the contents of the generated debug.txt file.

Thank you for your help @egifford, I'm starting to understand what's happening. NVM is probably what causes the issue. (@pavankumarkatakam, are you using NVM too?)
I will start working on a fix asap.

Yes, I'm using the NVM. In this context, my NVM points to 8.9.3 NodeJs version.

I've created a branch to support NVM in Rialto and PuPHPeteer, it would be great if both of you could clone this repository and run the following commands (use the same environment as before):
composer install
npm install
php run.php

The latest command should output OK, otherwise you will get an error, if its the case copy/paste it here.

ooh! Actually, it could be much simpler! Could you tell what's returned by npm list --depth=0 when you this command in your original projects? (not in my custom repository just above)
I've just found that PuPHPeteer doesn't work with Puppeteer v1.2+ with exactly the same error as you, so I wnat to check the version you're using.

For the test project, I received OK as output.
For npm list --depth=0:
C:\Work\projects\BusinessSkills.D7\project\tools\testing
+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>

I think you are correct that the Puppeteer version was causing my issue.  I did a clean install with composer and npm, made sure I had<EMAIL_ADDRESS>and my screenshot script worked perfectly.
Before I found PuPHPeteer, I was evaluating spatie/browsershot and must have still had a newer version of puppeteer installed.
This project is really good.  I hope I didn't take too much of your time to resolve this.
If you decide to setup a project funding mechanism, like Patreon, I'd contribute some USDs.  Though it looks like you might have some funding via a startup.  Anyway, good luck!

For npm list --depth=0
/media/XXXX/Storage/Projects/vp/XXXX
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>
For the test project, I received below output.
PHP Fatal error:  Uncaught Symfony\Component\Process\Exception\ProcessFailedException: The command "'node' '/home/administrator/Practise/puphpeteer-nvm-support/vendor/extractr-io/rialto/src/node-process/serve.js' '/home/administrator/Practise/puphpeteer-nvm-support/vendor/extractr-io/puphpeteer/src/PuppeteerConnectionDelegate.js' '{"idle_timeout":60}'" failed.

Exit Code: 1(General error)

Working directory: /home/administrator/Practise/puphpeteer-nvm-support

Output:
================

Error Output:
================
module.js:538
    throw err;
    ^

Error: Cannot find module 'puppeteer'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/administrator/Practise/puphpeteer-nvm-support/vendor/extractr-io/puphpeteer/src/PuppeteerConnectionDelegate.js:3:19)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at  in /home/administrator/Practise/puphpeteer-nvm-support/vendor/extractr-io/rialto/src/ProcessSupervisor.php on line 232

Version 0.2.2 is now available and supports Puppeteer v1.3+. Additionnally, from now you will be warn in the logs if the installed version of Puppeteer doesn't match the requirements. 😉
Since it should be solved, I'm closing the issue.

Hello, I get on php error log
PHP Fatal error:  Uncaught Nesk\Rialto\Exceptions\Node\FatalException: Right-hand side of 'instanceof' is not callable in /home/myuser/public_html/tmp/pjs/vendor/nesk/rialto/src/ProcessSupervisor.php:230

Paste here the logs emitted by PuPHPeteer, you can obtain them by using the logger option in the constructor.

@7starsone If necessary, I've just created a guide to help you providing logs.

[2018-06-07 16:53:14] PuPHPeteer.WARNING: The installed version of Puppeteer (v1.1.1) doesn't match the requirements (~1.4.0), you may encounter issues. [] []
[2018-06-07 16:53:14] PuPHPeteer.DEBUG: [options] {"read_timeout":35,"logger":{}} [] []
[2018-06-07 16:53:14] PuPHPeteer.DEBUG: Starting process... [] []
[2018-06-07 16:53:14] PuPHPeteer.DEBUG: [PID 482] Process started [] []
[2018-06-07 16:53:14] PuPHPeteer.DEBUG: [PORT 33505] [sending] {"type":"call","name":"launch","catched":false,"value":[{"args":["--no-sandbox","--disable-setuid-sandbox"]}]} [] []
[2018-06-07 16:53:14] PuPHPeteer.DEBUG: [PORT 33505] [receiving]  [] []
[2018-06-07 16:53:14] PuPHPeteer.ERROR: [PID 482] [stderr] {"__rialto_error__":true,"message":"Right-hand side of 'instanceof' is not callable","stack":"TypeError: Right-hand side of 'instanceof' is not callable\n    at PuppeteerConnectionDelegate.handleInstruction (/home/myuser/public_html/tmp/pjs/vendor/nesk/puphpeteer/src/PuppeteerConnectionDelegate.js:42:19)\n    at <anonymous>\n    at process._tickCallback (internal/process/next_tick.js:182:7)"} [] []

so, is it about a Puppeteer update? I thought that
composer require nesk/puphpeteer
npm install @nesk/puphpeteer

was enough to update Puppeteer. So, how to update it, instead?
Thanks

Ah! I knew it! 😁
You have to run npm update @nesk/puphpeteer. If it doesn't work, try deleting the node_modules directory and run npm update.

that's fixed now but always an issue about the page content
eg. URL https://icecat.de/search?keyword=ie-3000-8tc
the var_dump($page->content()); doesn't retrieve the container on the center, eg. the class _3rsz9QKOF3v-TD6wzRdTxc in this case.
What's the reason, please?
thanks

Probably because you're trying to read the content before the JS has finished to retrieve the server data. Try to use the following method: page.waitFor(selectorOrFunctionOrTimeout[, options[, ...args]]).
If you have more questions about this, please head over to StackOverflow, because this doesn't seem to be related to a bug in PuPHPeteer or Puppeteer.

yes, the waitFor could be useful for a selector but if the content is dynamically loaded the real solution
in this case is something like
$response = $page->goto($url, [
    'waitUntil' => 'networkidle0',
]);

it works, I didn't try other options there but for now is good as it is....
thank you very much


Using netplan on WSL2

Is your feature request related to a problem? Please describe.
I've tried this on both Ubuntu 18.04 and 20.04 WSL2.
My /etc/network/interfaces on Ubuntu 18.04 says:
cat /etc/network/interfaces
# ifupdown has been replaced by netplan(5) on this system.  See
# /etc/netplan for current configuration.
# To re-enable ifupdown on this system, you can run:
#    sudo apt install ifupdown

on 20.04 this file is absent.
Netplan is installed on both distros:
18.04
apt-cache policy netplan.io
netplan.io:
  Installed: 0.98-0ubuntu1~18.04.1
  Candidate: 0.98-0ubuntu1~18.04.1
  Version table:
 *** 0.98-0ubuntu1~18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     0.40.1~18.04.4 500
        500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages
     0.36.1 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

20.04
apt-cache policy netplan.io
netplan.io:
  Installed: 0.99-0ubuntu1
  Candidate: 0.99-0ubuntu3~20.04.1
  Version table:
     0.99-0ubuntu3~20.04.1 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
 *** 0.99-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status

But I cannot use it.
I've created netplan config file:
cat /etc/netplan/01-netcfg.yaml
network:
  version: 2
  renderer: networkd
  ethernets:
    eth0:
      dhcp4: true

but when I run sudo netplan apply it shows me parsing error:
sudo netplan apply
/etc/netplan/01-netcfg.yaml:1:9: Error in network definition: expected mapping (check indentation)
network:
        ^

Describe the solution you'd like
Be able to control networking stack via netplan including IPv6.
Describe alternatives you've considered
I don't understand how WSL2 distros get IPv4 addresses from HyperV.

Try sudo netplan --debug apply and share the output please.

Here it is
sudo netplan --debug apply
** (generate:81): DEBUG: 18:22:20.698: Processing input file /etc/netplan/01-netcfg.yaml..
** (generate:81): DEBUG: 18:22:20.731: starting new processing pass
(generate:81): GLib-GIO-DEBUG: 18:22:20.738: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ?gio-vfs?
/etc/netplan/01-netcfg.yaml:1:9: Error in network definition: expected mapping (check indentation)
network:

IPv6 is not supported. There's another issue filed for that already. Localhost works for both WSL2 and Windows as many people wanted that experience from WSL1. Other IPv4 addresses should still work.

It was probably related to some spacing issues. I manually deleted all whitespaces and put them again and this is what I get now:
sudo netplan --debug apply
** (generate:598): DEBUG: 20:30:37.486: Processing input file /etc/netplan/01-netcfg.yaml..
** (generate:598): DEBUG: 20:30:37.486: starting new processing pass
** (generate:598): DEBUG: 20:30:37.486: eth0: setting default backend to 1
** (generate:598): DEBUG: 20:30:37.486: Configuration is valid
** (generate:598): DEBUG: 20:30:37.487: Generating output files..
** (generate:598): DEBUG: 20:30:37.487: NetworkManager: definition eth0 is not for us (backend 1)
DEBUG:netplan generated networkd configuration changed, restarting networkd
System has not been booted with systemd as init system (PID 1). Can't operate.
Traceback (most recent call last):
  File "/usr/sbin/netplan", line 23, in <module>
    netplan.main()
  File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
    self.run_command()
  File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
    self.func()
  File "/usr/share/netplan/netplan/cli/commands/apply.py", line 44, in run
    self.run_command()
  File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
    self.func()
  File "/usr/share/netplan/netplan/cli/commands/apply.py", line 102, in command_apply
    utils.systemctl_networkd('stop', sync=sync<EMAIL_ADDRESS>  File "/usr/share/netplan/netplan/cli/utils.py", line 82, in systemctl_networkd
    subprocess.check_call(command)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['systemctl', 'stop', '--no-block', 'systemd-networkd.service'<EMAIL_ADDRESS>returned non-zero exit status 1.

So now it is now working due to systemd is not working on WSL?!

Another interesting note: I've enabled systemd support by running this
https://github.com/DamionGans/ubuntu-wsl2-systemd-script
After I was able to commit sudo netplan apply successfully...well, kind of. It broke WSL2 distro with systemd completely AND network stack for all other distros (because all of them somehow and for some reason share ALL network settings). The was neither IPv4 address on eth0 nor default route.
Anyway, after reboot network stack healed itself.
So, results:

I can't use netplan (without systemd).
I can't use different IPv4 addresses for various distros (why?).
I have no IPv6 connectivity (again, why?).
I can't bridge WSL2 distro network interface to Windows system network interface to get IPv4/IPv6 from same subnets (why?).

<IP_ADDRESS>.

We can let this float for a bit in case there is some community input to share, but this one just went:

If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.

I haven't dove netplan except to look at the landing page (because no CLI repro to cut and paste), but on a broad glance it seems to require as a dependency network-manager or systemd-networkd, which (to put it lightly) would require a lot of hypothetical CLI steps before one ever made it to "netplan".

netplan itself should work after systemd finally arrive at WSL.
But I still don't have clear understanding regarding what is going with network stack.
2) Why all distros share the same network stack? Is it going to change? Is there a thread for this one?
3) IPv6 discussed here https://github.com/microsoft/WSL/issues/4518 and this one is mandatory for 2020.
4) Bridging is being discussed here https://github.com/microsoft/WSL/issues/4150, but as I understand there are no dates when (or even if) it might be implemented.


Lose code when typing into interactive console

Environment data

VS Code version: 1.51.1
Extension version (available under the Extensions sidebar): 2021.2.633441544
OS and version: Debian Buster
Python version (& distribution if applicable, e.g. Anaconda): 3.8

Steps to reproduce:

Start typing test code in interactive console
Fat finger the up arrow key and the previous command is shown
No way to get back half typed code from step 1

Unfortunately we are not involved with the terminal/interactive console. If your shell doesn't keep your history when you hit the up arrow and you want that feature then you may need to choose a different shell (either as your login shell or setting VS Code to use a different shell).

/cc @greazer @DonJayamanne @rchiodo


[ADAM-1170] Deprecate SAMFileHeaderWritable

Fixes #1170

Coverage decreased (-0.04%) to 78.842% when pulling 003aa6c185541163920b08b2084c10ecaf87bf79 on heuermh:prepare-for-convert into 38f916f6147547545d73a74680474dd2ba21f6ee on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3006/
Test PASSed.

Some local benchmarks
800MB bam file:
OLD:
real	2m13.281s
user	11m40.431s
sys	0m10.263s

NEW:
real	2m5.253s
user	11m16.020s
sys	0m10.250s

3.6GB SAM file
OLD
real	2m7.400s
user	11m56.519s
sys	0m15.019s

NEW
real	0m2.623s
user	0m5.010s
sys	0m0.484s

What, did that last run terminate early or something?

Fixed

Thanks, that looks better.  I only expect to see differences (if any) across multi-node clusters, because this pull request changes how the headers are serialized.
Unfortunately, this https://github.com/bigdatagenomics/adam/issues/2157 prevents running on 2.2.x on the bdg cluster, and we don't have Spark 2.4.x available there yet.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3019/
Test PASSed.


Adds a note to the README about mobile fullscreen issues.

I would like to save others the several days I spent trying to get fullscreen videos working properly on mobile devices by including a note in the README.
A bit more background on the problem in case it might be considered for later improvement:
The iframe element inserted by this plugin via the YouTube API is not recognized by videogular. Videogular attaches listeners to and calls methods on its mediaElement, which via vgType can be either a video or audio element. This plugin inserts some behavior into the mediaElement to bridge it with the YouTube API. Fullscreen operations in videogular that call methods on the mediaElement do not work since there is no video in the DOM (the iframe content is off-limits due to cross-domain security, I don't think we can work around that).
On Android I experimented with setting API.mediaElement = elem.closest('videogular'); at the top of the plugin's onVideoReady function. This was actually kind of nice on Android since the fullscreen button in videogular's controls made the entire videogular element fullscreen, with consistent media controls. There are some non-insurmountable problems with that on Android, but unfortunately it does not work at all on iOS since webkitEnterFullscreen() and company are only defined on video elements.
The only option left to me was to disable (ngIf) everything from Videogular that overlays the iframe in order to use the YouTube controls. I am still enjoying the benefit of a consistent API for tracking playback status, but unfortunately abandoning the videogular controls and overlays for YouTube was the only option.

Thank you very much for this great explanation and great comments on the docs.


new Validator CASNumberCheckDigit for Chemical Registry CAS Numbers

CASNumberCheckDigit - CAS Chemical Abstracts Service RN Registry No
CAS Numbers are unique identification numbers used to identify chemical
substance described in the open scientific literature.
see wikipedia CAS_Registry_Number
Also add Validator for EC number - ECN is a unique seven-digit identifier that is assigned to chemical substances
regards

close this - open new PR #216


labhub: Add missing whitespace

changed ourcommunity to our community
closes https://github.com/coala/corobo/issues/214
Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

Added the changes as requested, sorry for the lousy commit in the first place.

Added -> Add.
Also, changing PR title is not equivalent to changing commit messages

@vaibhavgarg11 hey the change looks good , before i pull request i always go through this unless or until am sure about the commit message :D

@meetmangukiya sorry about that I'll try to fix it. The thing is I made these changes directly on github so I am having some trouble finding how to change the commit message.

@vaibhavgarg11 you have two commits now. You need to squash those in one.

The thing is I made these changes directly on github so I am having some trouble finding how to change the commit message.

Github UI doesn't allow changing commit messages. Git is best used with the git cli. You should read this http://coala.io/git

@meetmangukiya I originally inteded to do that but I couldn't  find the file path. Do i also need to clone https://github.com/coala/corobo inorder to do that

@meetmangukiya can you help we with a issue I'm facing using git
so I cloned the corobo repository in order to change the commit message
but when I use git branch command in order to change to the branch that I had made changes to it only shows the master branch

@vaibhavgarg11 you need to git fetch --all first so you get all the remote branches.

@vaibhavgarg11 you didn't squash correctly

I tried to but I got a error saying cannot squash without a previous commit.

@meetmangukiya please suggest me what should I do further ?

@vaibhavgarg11 :
git checkout patch-1 # checking out the branch
# to sync with remote
git fetch origin
git rebase origin/patch-1
# remove extra commits and commit again
git reset HEAD~4
# assuming you are in repo root
git add plugins/labhub.py
git commit

@meetmangukiya done

@vaibhavgarg11 this is just getting worse, I think it'd be better to create a new PR from a new branch branched off master. ;)

Created new PR #266


Rename all Git Repo's under control of ii.coop to align with the CNCF and K8s Naming Working Group vision

Description of the Issue:
In alignment with the CNCF vision to Eradicate Racial Bias from Code and the direction of the k8s Naming Working Group's vision, ii.coop would rename the primary branch form MASTER to MAIN for all git repositories under the control of ii.coop and request changes where we do not have direct write access to make the change.
Community interaction:
CNCF Inclusive Naming Initiative
Kubernetes Naming Working Group
Target outcome for this issue:
Renaming of existing git repositories primary branch form MASTER to MAIN
All future git repositories created by ii.coop will follow the same convention.

Done!
Thank you @zachmandeville & @hh


fix(jqLite): Check "length" in obj in isArrayLike for iOS JIT bug

to prevent iOS8 JIT bug (https://bugs.webkit.org/show_bug.cgi?id=142792) from surfacing
This is the fix implemented in underscore.js and most likely the fix that will be implemented in jQuery.
It's not a very easy to recreate bug, but I stumbled upon it myself in our production app and was able to narrow it down to isArrayLike after several hours of banging my head.  This plunkr was the closest I got to consistently surfacing the bug in Angular: http://plnkr.co/edit/UQ5NhZnRuafNxWiJuuyN
That ng-repeat will fail, but only on iOS8 (and i've personally only had it fail on iPad) about 50% of the time after a few digests.  If it doesn't fail quick reloading the plunkr a few times will usually get it to fail.

Updated pull request to follow updated isArrayLike solution in jQuery https://github.com/jquery/jquery/pull/2185
Unfortunately no tests since this is iOS8 only and doesn't surface in iOS simulator.

@snapwich Could you add a comment explaining why it's needed? Otherwise someone will probably try to remove it in a couple of months or years ;)

@realityking sure.  I just added a comment similar to the jQuery commit.

Any update on merging this?  This fix has made its way into jQuery now and would be a quick fix for Angular.

LGTM

jQuery found that based on their usage they didn't need the Object(...) use. Might be worth checking out here too.

@jdalton that works in jQuery's case because the caller knows that it's a non-null "object" already, I'm not sure the same assumptions fly here. It would be good to make those assumptions work but I won't consider that a blocker

@jdalton @caitp yeah jQuery and Angular make some different assumptions I think.
Removing the Object(...) causes these unit tests to fail that otherwise don't:
angular forEach should handle string values like arrays FAILED
angular forEach ES spec api compliance should follow the ES spec when called with string FAILED

For reference https://github.com/jquery/jquery/issues/2145

@mzgol - you worked on this bug in JQuery - what is your recommendation here?

We should work around it; relevant jQuery commit: https://github.com/jquery/jquery/commit/154166458284bcce7d6a86328b7fd13483232a1a

This looks good but in jQuery it turned out some people relied on undocumented behavior that jQuery.map worked on strings and not just arrays (this broke a popular DataTables jQuery plugin). Not sure if this is an issue here.

OK, LGTM. Let's merge this.


go build ./cmd/... fails

go build ./cmd/... fails with the below error
💰 go build ./cmd/...
cmd/capd-manager/main.go:23:2: cannot find package "github.com/chuckha/cluster-api-provider-docker/actuators" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/github.com/chuckha/cluster-api-provider-docker/actuators (from $GOROOT)
	/Users/ashisha/go/src/github.com/chuckha/cluster-api-provider-docker/actuators (from $GOPATH)
cmd/capd-manager/main.go:24:2: cannot find package "k8s.io/client-go/kubernetes" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/k8s.io/client-go/kubernetes (from $GOROOT)
	/Users/ashisha/go/src/k8s.io/client-go/kubernetes (from $GOPATH)
cmd/capd-manager/main.go:30:2: cannot find package "sigs.k8s.io/controller-runtime/pkg/client/config" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/sigs.k8s.io/controller-runtime/pkg/client/config (from $GOROOT)
	/Users/ashisha/go/src/sigs.k8s.io/controller-runtime/pkg/client/config (from $GOPATH)
cmd/capd-manager/main.go:31:2: cannot find package "sigs.k8s.io/controller-runtime/pkg/manager" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/sigs.k8s.io/controller-runtime/pkg/manager (from $GOROOT)
	/Users/ashisha/go/src/sigs.k8s.io/controller-runtime/pkg/manager (from $GOPATH)
cmd/capd-manager/main.go:32:2: cannot find package "sigs.k8s.io/controller-runtime/pkg/runtime/signals" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/sigs.k8s.io/controller-runtime/pkg/runtime/signals (from $GOROOT)
	/Users/ashisha/go/src/sigs.k8s.io/controller-runtime/pkg/runtime/signals (from $GOPATH)
cmd/capdctl/main.go:26:2: cannot find package "github.com/chuckha/cluster-api-provider-docker/execer" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/github.com/chuckha/cluster-api-provider-docker/execer (from $GOROOT)
	/Users/ashisha/go/src/github.com/chuckha/cluster-api-provider-docker/execer (from $GOPATH)
cmd/capdctl/main.go:27:2: cannot find package "k8s.io/apimachinery/pkg/apis/meta/v1" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/k8s.io/apimachinery/pkg/apis/meta/v1 (from $GOROOT)
	/Users/ashisha/go/src/k8s.io/apimachinery/pkg/apis/meta/v1 (from $GOPATH)
cmd/kind-test/main.go:25:2: cannot find package "github.com/chuckha/cluster-api-provider-docker/kind/actions" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/github.com/chuckha/cluster-api-provider-docker/kind/actions (from $GOROOT)
	/Users/ashisha/go/src/github.com/chuckha/cluster-api-provider-docker/kind/actions (from $GOPATH)
cmd/kind-test/main.go:26:2: cannot find package "sigs.k8s.io/kind/pkg/cluster/constants" in any of:
	/usr/local/Cellar/go/1.12.6/libexec/src/sigs.k8s.io/kind/pkg/cluster/constants (from $GOROOT)
	/Users/ashisha/go/src/sigs.k8s.io/kind/pkg/cluster/constants (from $GOPATH)

There are multiple references to github.com/chuckha which needs to be removed.

/assign
/lifecycle active

I think this is a go mod thing – it worked fine for me with GO111MODULE=on (or, presumably, if I cloned it outside my GOPATH with the default GO111MODULE=auto).
That said, I think it works because the module still declares itself as github.com/chuckha/cluster-api-provider-docker: https://github.com/kubernetes-sigs/cluster-api-provider-docker/blob/master/go.mod#L1

yes, try:
GO111MODULE=on go build ./cmd/...

/kind documentation

sent fix here:
https://github.com/kubernetes-sigs/cluster-api-provider-docker/pull/11


[Bug] [Local] Caused by: java.lang.NumberFormatException: For input string: 'abc'. Invalid character found

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
在local  模式下执行 select CAST('abc' as int)；语句，无报错提示，正常页面因该提示类型转换错误，系统日志里面是存在报错的
What you expected to happen
正常页面因该提示类型转换错误，控制台打印报错日志，提示类似ava.lang.NumberFormatException: For input string: 'abc'. Invalid character foun报错 ，execute job finished,status is Fail
How to reproduce

Anything else
no
Version
1.0.2
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

这个错误本身就应该是 flink 抛出来的


Fix KeyValue Component.

Summary

#7073

Technical notes summary
Currently within KeyValue component this.value is not mutated. It's been mapped to data.rows. So user can add multiple key/values without mutating the this.value.
For CustomLink Component, if applying defaultValues  then this.value need to remapped to data.rows again.
So proposed solution is pass the defaultValue already at the component initialisation as well as override this.value when resetting to default.

Codecov Report
Base: 36.30% // Head: 36.78% // Increases project coverage by +0.48% :tada:

Coverage data is based on head (4038d85) compared to base (29e666c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7093      +/-   ##
==========================================
+ Coverage   36.30%   36.78%   +0.48%
==========================================
  Files         967      977      +10
  Lines       17225    17254      +29
  Branches     4463     4482      +19
==========================================
+ Hits         6253     6347      +94
+ Misses      10972    10907      -65

Flag
Coverage Δ

e2e
47.35% <ø> (+0.59%)
:arrow_up:

merged
36.78% <ø> (+0.48%)
:arrow_up:

unit
5.29% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

shell/components/form/KeyValue.vue
100.00% <ø> (ø)

shell/pages/c/_cluster/settings/links.vue
0.00% <ø> (ø)

shell/plugins/plugin.js
51.61% <0.00%> (-28.39%)
:arrow_down:

shell/utils/grafana.js
12.76% <0.00%> (-21.93%)
:arrow_down:

shell/plugins/steve/steve-class.js
33.33% <0.00%> (-16.67%)
:arrow_down:

shell/plugins/extend-router.js
56.00% <0.00%> (-8.00%)
:arrow_down:

shell/utils/url.ts
38.88% <0.00%> (-1.39%)
:arrow_down:

shell/models/provisioning.cattle.io.cluster.js
63.80% <0.00%> (-0.53%)
:arrow_down:

shell/utils/socket.js
48.52% <0.00%> (-0.50%)
:arrow_down:

shell/nuxt.config.js
0.00% <0.00%> (ø)

... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Issue while installing Realm pod via Cocoapods

I have been facing below issue while installing Realm pod.
[!] /bin/bash -c
set -e
sh build.sh cocoapods-setup
core is not a symlink. Deleting...
Downloading dependency: sync 4.9.0 from https://static.realm.io/downloads/sync/realm-sync-cocoa-4.9.0.tar.xz
tar: Error opening archive: Unrecognized archive format

Having the same issue

+1 on this. It happened yesterday and just started happening again today

➤ Lee Maguire commented:
Hi,
Can you tell us what version of cocoapods you are using and can you also send us your podfile.
Thanks,
Lee

Having the same issue

I am using pod version 1.9.1 and got the same issue. @RealmBot


Failure of recording a scenario simulation

Describe the bug
A clear and concise description of what the bug is.
The scenario simulator cannot perform normally when I set the record to true, which means:

it cannot do the scenario test simulation
it cannot record the simulation.

To Reproduce
Steps to reproduce the behavior:

Run the scenario test simulation with the command ros2 launch scenario_test_runner scenario_test_runner.launch.py   architecture_type:=awf/universe record:=false scenario:='t4v2.yml'   sensor_model:=sample_sensor_kit   vehicle_model:=sample_vehicle
The scenario is simulated and played on the rviz.
Run the scenario test simulation again with the command ros2 launch scenario_test_runner scenario_test_runner.launch.py   architecture_type:=awf/universe record:=true scenario:='t4v2.yml'   sensor_model:=sample_sensor_kit   vehicle_model:=sample_vehicle
Rviz is successfully started, but the scenario is not simulated, along with console error output.

Expected behavior
The scenario test simulator should run the scenario normally and record the whole simulation messages.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 22.04
ROS 2 version: humble

The file is attached here: https://drive.google.com/file/d/1LDSyvA9PUEf58OzcS4sJ-3XLTVgAnOPJ/view?usp=drive_link

As we infer from the error text, it is probably an error in the DDS communication process.
It may be cured by reviewing the DDS communication settings, etc.

Got it, I will try to inspect the DDS settings first.

@hakuturu583 Thanks, after configuring the DDS settings I can record and replay the scenario mentioned above successfully. But there is another issue, when I replay the rosbag file, the steering angle and speed were not displayed. I also tried the sample file from https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/rosbag-replay-simulation/, and there was also no such information. Screenshot is attached.


Keepalive Throttling

Fix #16210
Changes -

Add a key for keepalive_throttling named "grpc.internal.keepalive_throttling" in the absl::Status object when we notify a state change due to a GOAWAY received with "too_many_pings". The value associated with this key is the new keepalive time period that the channel/subchannel should use.
When the subchannel sees the connectivity state change notification, it checks for the key and updates the channel_args with the new keepalive time period so that new transports will use the new value.
When the channel sees the notification, it updates its keepalive_time_ value so that future subchannels will be created with the newer value. (The updated value is the max of its current value and the value in the status payload, so that we can handle the case of receiving GOAWAYs on two separate transports for the same channel.)

This change is

I overwrote the files here with the changes from #23480 instead of rebasing this pull request, so that previous commits and comments can be preserved.
The keepalive throttling changes have been recreated on top.

@markdroth The merge with master after the merge of the absl::Status PR had a lot of conflicts, so I ended up cherry-picking the keepalive commits on top of master.

Thanks for reviewing!


Pregel additional test & TSan error fix

Scope & Purpose
Add a test for the 'hits' pregel algorithm, fix a lock-inversion warning when running with the thread sanitizer

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] The behaviour change can only be verified via automatic tests

Testing & Verification
This change is already covered the existing pregel tests

[x] Added new integration tests (i.e. in shell_server / shell_server_aql)

Additionally:

[x] I ensured this code runs with ASan / TSan or other static verification tools

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/6601/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5000/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5054/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5060/


round-start-rating is respected after first hover

This is how I set the initial rating.
    <star-rating ref="widget"
        v-model="rating"
        @rating-selected="setRating"
        :round-start-rating="false">
     </star-rating>

        beforeMount: function() {
            this.ratingIdentifier = this.getRatingIdentifier();
            this.readOnly = undefined !== localStorage[this.ratingIdentifier];
            this.maxRating = window.vueData.rating.maxRating;
            this.getRating();
        },
        methods: {
            getRating: function() {
                  // 3.5 is actually from an async callback
                  this.rating = 3.5;
            }
        }

Expected behavior:

initial rating shows 3 1/2 stars.
rating should be possible in increments of 1, no half stars

Actual behavior:

initial rating shows as 4 stars.
rating is possible in increments of 1, no half stars
after hovering (not selecting anything) the widget shows a rating of 3 1/2 stars.

Am I setting the rating at a wrong time?
I'm using version 1.6

Thanks for opening the issue, this shouldn't happen, but it appears to be an issue with the async call. I've set up a JSFiddle to show the issue: https://jsfiddle.net/fhj35zq0/22/ and I'll look in to getting this fixed ASAP,