Off positioned cursor/touch origin

Hi,
First of all, thanks for the neat plugin. You did a great job!
I noticed an annoying bug when the component is used in the right side of the window and you start scrolling to zoom which results in off positioned originX and originY.
The possible solution could be using a ref for div.pinch-scroll-zoom and calculating the refs' absolute position with .getBoundingClientRect().left for horizontal axis and .getBoundingClientRect().top for vertical axis, then extracting these distances from originX and originY accordingly.

Hi,
First of all, thanks for the neat plugin. You did a great job!
I noticed an annoying bug when the component is used in the right side of the window and you start scrolling to zoom which results in off positioned originX and originY.
The possible solution could be using a ref for div.pinch-scroll-zoom and calculating the refs' absolute position with .getBoundingClientRect().left for horizontal axis and .getBoundingClientRect().top for vertical axis, then extracting these distances from originX and originY accordingly.

Thanks for reporting the bug.
The bug has been fixed and closed - https://github.com/coddicat/vue-pinch-scroll-zoom/commit/2fc1c0e9d352f49f7eaf5652cecce64c1357f399.


Incorrect syntax in code sample

Missing $ in the groupId=$(az group show... command to get the id of the resource group.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c5d2898-9714-9b98-f065-66a59889f909
Version Independent ID: 6a7e0145-9e57-b2e6-04f6-9aeda314bad7
Content: Deploy container instance by GitHub action - Azure Container Instances
Content Source: articles/container-instances/container-instances-github-action.md
Service: container-instances
GitHub Login: @macolso
Microsoft Alias: macolso

@rabindra-harlalka The document is updated and changes will go live soon.


🐛 Bug Report: Entra ID Consent for Azure DevOps Shows Error, despite then working

📜 Description
I'm using Entra ID authentication into backstage, with users auto-populated in the catalog from Entra, and this is all working fine. I am no creating a software template that uses the Git Repo picker and I want it to get a token for Azure DevOps. I have configured the Git Repo picker with the requestUserCredentials option.
When a user first attempts to use this, they are presented with an Entra ID consent page for permission to Azure DevOps, the user consents and then is returned to Backstage where they get an error stating "Login failed, user profile does not contain an email". However, if the user then dismisses the error, everything works and backstage can access ADO as that user.
I have also tried changing the resolver to emailMatchingUserEntityAnnotation and it then complains that Microsoft profile contained no email. I have checked the user entity in Backstage and can see all the appropriate annotations are correct so my only guess at this point is that what comes back from Entra is missing something, but I'm not in control of that, and it doesn't seem to matter anyway, as it all works.
👍 Expected behavior
User should not get any error when completing consent to ADO, given that the access actually works.
👎 Actual Behavior with Screenshots

👟 Reproduction steps

Configure a git repo picker to obtain the user secret, and configure it to use dev.azure.com as the domain
Attempt to use Git repo picker and get presented with a window indicating login to Microsoft is required
Complete consent to allow access to Azure DevOps
Get error message
Dismiss error and see that all is working as expected

📃 Provide the context for the Bug.
I'm trying to allow the user to perform software template operations using their own ADO credentials.
🖥 Your Environment
Running locally in docker, and in Azure App Service, both experience the same issue
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Further debugging confirms that the token that comes back from Entra ID does not include the email field, so none of the resolvers will work. I can see the initial login to backstage gets this token, then calls the user profile API in Entra to get the email, but this consent step does not do this. Not sure if the token changed recently to remove email, but if not then I'm unsure how this ever worked.

Ok, that makes sense. A quick fix for this was to ask for the additional ADO permissions up-front at initial login, this avoids the additional pop-up altogether, but obviously not a great long term solution.

Actually, that didn't work. It now complains about asking for a token with multiple audiences.
I'm not sure I fully understand the proprose workaround, how does a separate auth provider for sign-in help with the the delegation prompt, surely that will still want to sign in again still?


python312Packages.google-cloud-securitycenter: 1.28.0 -> 1.29.0

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-securitycenter-v1.29.0/packages/google-cloud-securitycenter/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 295520 run on x86_64-linux 1

4 packages built:

python311Packages.google-cloud-securitycenter
python311Packages.google-cloud-securitycenter.dist
python312Packages.google-cloud-securitycenter
python312Packages.google-cloud-securitycenter.dist

Result of nixpkgs-review pr 295520 run on x86_64-linux 1

4 packages built:

python311Packages.google-cloud-securitycenter
python311Packages.google-cloud-securitycenter.dist
python312Packages.google-cloud-securitycenter
python312Packages.google-cloud-securitycenter.dist


How can i make two drawers?

Hello, i want to make specific two drawers on the left and right. I colud not find a solution for this. I can make only one drawer. Also i can open that drawer with Actions.openDrawer(). But openDrawer() method doesnt take arguments like key. Is there any soluiton for this?

@frndmr Did you ever find a solution to this?


Add C#

📥 Pull Request
Description
Add C# with three pages  Introduction, Variables, Operators
Fixes #1347
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar  Please add label  level-3 or level-2


Kubefix is surprisingly race-y with flux itself

Often races with releases themselves.
Solution is to integrate the kubediff & fixing diffs into flux itself, as a serialized job. But, how to do the diff over the platform.Platform interface is difficult to do in a non-k8s-specific way.
In general it would be good to fix the issue and define what flux should do if a user manually edits stuff in the definitions repo.
It seems we could do the diff by:
a) Doing aplatform.Platform.AllServices() []platform.Service which returns a list of everything currently running, then doing the diff on fluxsvc.
b) Having a platform.Platform.Apply(definitions []Definition) []Update which sends all the relevant definitions (or whole git repo?) to the fluxd, and it diffs/fixes stuff, and returns a list of what it did.
c) Have something similar to the kubernetes events API, which fluxsvc could subscribe to, and get "pushed" notifications from the platform when things change. This would be the most responsive.
With a small amount of thought, I favour B (which seems simpler) or C (which seems more responsive). Though A would be a fine stopgap to C.

Also, it is unclear what the terminology and UI for switching this on should be. Either in config, or could be conflated with "automating" a service.

I've now removed kubefix from dev, as it was causing more issues than it was fixing.
Based on various conversations people expect automated services to automatically get configs applied too, not just images. We should prioritize fixing this.
It might just be possible for a to just have fluxsvc ask about automated services, not all of them.

Not relevant to this repo. No idea if the general problem still exists for anyone.


Lua Coroutine error when trying to create commit message

Description
I can stage and unstage files/hunks. When I attempt to use cc to create a commit message, I get a lua error.
Neovim version
NVIM v0.9.0-dev-1640+gc0840087c-dirty
Build type: Release
LuaJIT 2.1.0-beta3
Operating system and version
macOS 11.5
Steps to reproduce

Be in a git repo
Stage files with Neogit
Use cc to attempt to create commit message

Expected behavior
Expect to open new line at top of buffer for a commit message
Actual behavior
The following Lua error is thrown:
Error detected while processing BufUnload Autocommands for "*":
Error executing vim.schedule lua callback: ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...pack/packer/start/neogit/lua/neogit/
lib/notification.lua:36: Vim:E937: Attempt to delete a buffer that is in use: NeogitCommitPopup
stack traceback:
        [C]: in function 'error'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
        ...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:45: in function <...ck/packer/start/plenary.nvim/lua/plenary/async/async.lua:44>
        [C]: in function 'wait'
        .../packer/start/nvim-tree.lua/lua/nvim-tree/git/runner.lua:137: in function '_wait'
        .../packer/start/nvim-tree.lua/lua/nvim-tree/git/runner.lua:156: in function 'run'
        ...ck/packer/start/nvim-tree.lua/lua/nvim-tree/git/init.lua:47: in function 'reload_project'
        ...ck/packer/start/nvim-tree.lua/lua/nvim-tree/git/init.lua:31: in function 'reload'
        ...m-tree.lua/lua/nvim-tree/actions/reloaders/reloaders.lua:41: in function 'reload_explorer'
        ...m/site/pack/packer/start/nvim-tree.lua/lua/nvim-tree.lua:375: in function <...m/site/pack/packer/start/nvim-tree.lua/lua/nvim-tree.lua:373>
        [C]: in function 'nvim_buf_delete'
        .../site/pack/packer/start/neogit/lua/neogit/lib/buffer.lua:102: in function 'close'
        ...m/site/pack/packer/start/neogit/lua/neogit/lib/popup.lua:63: in function 'close'
        ...m/site/pack/packer/start/neogit/lua/neogit/lib/popup.lua:220: in function 'cb'
        .../site/pack/packer/start/neogit/lua/neogit/lib/buffer.lua:328: in function <.../site/pack/packer/start/neogit/lua/neogit/lib/buffer.lua:327>
        .../packer/start/neogit/lua/neogit/lib/mappings_manager.lua:9: in function 'invoke'
        [string ":lua"]:1: in main chunk

Minimal config
vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

I couldn't reproduce it, It worked successfully here, but I'm in Ubuntu.
If you can provide further details, I think I can help

I'm certain the problem exists on my end. Let's close this for now since it's probably just noise.

@nobleach How did you install Neovim?
I think I have this kind of problem using null-ls, but when I reinstalled it, it worked

On this machine, I've installed it via Homebrew (HEAD, not stable). And I think you're right about null-ls being the culprit. I had switched from using asdf's node install to using nvm... so many of my terminals in Tmux couldn't find a node executable. Thus null-ls couldn't attach to eslint/prettier/etc. Rebooting seems to have sorted it out. I could not repro on my Linux box, so I'm 99.99% sure it was just a flub. My apologies for reporting an issue.


Deprecate SwiftMailerHandler in 2.x

Perhaps add a new one based on symfony/mailer? Not sure if it is needed or if symfony's monolog-bridge covers that well enough already.
Also deprecate MandrillHandler's SwiftMessage arg

As far as I can see right now, the symfony/monolog-bridge provides a handler, though we can't use it in Laravel projects.
If I'm not mistaken, Laravel doesn't use the Symfony\Component\Mailer\Mailer class directly. Thus, we don't have an instance of the Symfony\Component\Mailer\MailerInterface required by the symfony/monolog-bridge handler as a first argument.
All we have in Laravel is app('mailer')->getSymfonyTransport() which returns the Symfony\Component\Mailer\Transport\TransportInterface (but, again - we can't use it in symfony/monolog-bridge handler).
I guess we need the LaravelMailerHandler as well? 🤔
@driesvints Could you please take a look at this?
Thank you!

Related issue for a mailer handler https://github.com/Seldaek/monolog/issues/1621
This issue is really just about marking the SwiftMailerHandler as deprecated.

See https://github.com/Seldaek/monolog/pull/1663

Heya, sorry I seem to have missed this. We indeed don't directly use the Mailer interface because it would collide with our own send method. We thought it wasn't necessary for our implementation.
The PR by @Seldaek lgtm 👍


New Chinese Text

Provides Chinese text of new Open Encyclopedia contents written by DragonRatTiger, descriptions of folders, an option with its description, and Shop texts.
Before the formal release, I hope I can work on Chinese texts as much as possible, as a Chinese text assistant.

I don't know if this will actually happen, but it was announced like this:

The ingame "Open Encyclopedia" menu (that was barely started) will be removed and replaced by actual documentation (either .pdf or .html) that will be complete and easier to read around the 0.6.0 release date

I don't know if this will actually happen, but it was announced like this:

The ingame "Open Encyclopedia" menu (that was barely started) will be removed and replaced by actual documentation (either .pdf or .html) that will be complete and easier to read around the 0.6.0 release date

I have no idea about this plan, but what I can do is follow the current formats.

I think that existent encyclopedia entries will be reused in the new documents (not officially confirmed?).

I don't know if this will actually happen, but it was announced like this:

The ingame "Open Encyclopedia" menu (that was barely started) will be removed and replaced by actual documentation (either .pdf or .html) that will be complete and easier to read around the 0.6.0 release date

This is correct, and most of the translations here will likely end up in the new format as well.

As said previously the format will be updated in a short future in order to be easier to make and to read, apologies for the very little information about it
Merging the PR for the moment, as in addition to the entries it also contains translations for the new folders box.def
There is a translators channel on the discord where we share the latest informations related to translations (the new format for the Encyclopedia will be posted in there as well), I can give you access to it too


Update docs.md

corrects typo in Redemption Period section ("the cost to due this" should read "the cost to do this"); also fixes comma splice in Availability section (replaces ", however" with ", but").

Awesome, thanks!


Update README.md

The PR will update the README to fix not appearing Play Store image on the app link. Also it aims to exchange Markdown with html

Maybe it is a good idea to adipt the top part of the Readme to be like in the iOS repo so on mobile clients there is a direct link to the stores


Wallet removed when you close the alert to enter a password.

Steps to reproduce behavior:

Go to the wallet.
go to the "Settings" screen.
Tap the "Remove current wallet" button.
On "Remove current wallet" alert tap the "Remove wallet" button.
When prompted for a password, close alert with the cross in the upper right corner.
Expected: wallet doesn't remove.
Actual: wallet removed.

checked


Error: No context provided: useLeafletContext() can only be used in a descendant of

Hi huys,
I'm trying to use this library but i got this problem:
Error: No context provided: useLeafletContext() can only be used in a descendant of <MapContainer>
When i 'm trying to create a  in my
I tried the @monsonjeremy's version but it didn't work better.
There is my package.json:

Thanks you so much for replies !

Hey, I am getting same issue, did you get any fix?

Hey, I am getting same issue, did you get any fix?

Sadly no


Installing instrain

Hey Michael,
Having trouble installing instrain. Conda was taking forever so I tried pip and tried from the source code, both of which threw this error
× Encountered error while trying to install package.
╰─> biopython
I installed biopython with conda separately and that didn't seem to fix anything. I will leave conda spinning overnight to see if it resolves, but any suggestions? Couldn't find many potential fixes online.
Thanks,
Josh

That's interesting, I don't think I've ever had trouble with installing inStrain but have only done it a few times. I just tried to create a new test environment to install it and it looks like I'm getting the same error(s) you are with pip, conda, and installing from source...
Babiker recently was able to install it on the cluster at Ga Tech, I wonder if he knows a solution.
It's not ideal but I'll try to upload some output files to OneDrive so we can look at them together and imagine what it would be like to have inStrain running... If we don't find a group solution tomorrow to run inStrain, it is probably worth posting an issue for biopython.

i think we sorted out that this was a resolved issue with inStrain (though I may have lost the link). Will close for now.


Custom Deploy Collector - Servers Online Issue

I have a custom deploy collector the following is in the mongo data
{
	"_id": ObjectId("5796784b4b2f7fc86c2a3ce8"),
	"environmentID": "Environments/QA",
	"environmentName": "QA",
	"collectorItemId": ObjectId("57966a92d9846e0f6081f1c9"),
	"componentName": "app1",
	"componentVersion": "4",
	"servers": [{
		"name": "app1-4-hwmb6",
		"online": true
	}],
	"deployTime": NumberLong("1469479507907"),
	"environmentUrl": "https://server/console/project/app1-qa",
	"_class": "com.capitalone.dashboard.model.EnvironmentComponent",
	"componentID": "app1",
	"deployed": true,
	"asOfDate": NumberLong("1469479507907")
}

However the calls to the API is not returning servers.  What am I missing?
{
	"result": [{
		{
		"name": "QA",
		"url": "https://server/console/project/app1-qa",
		"units": [{
			"name": "app1",
			"version": "4",
			"deployed": true,
			"lastUpdated":<PHONE_NUMBER>907,
			"servers": []
		}]
	}],
	"lastUpdated":<PHONE_NUMBER>907
}

Which collection did you store it to?

I'm storing them in environment_components , I'm guess that's wrong since they aren't displaying :)

There are two collections for this . Try storing this way:
Collection: environment_component
{
"_id" : ObjectId("56d9ec207fab7c452af8088c"),
"_class" : "com.capitalone.dashboard.model.EnvironmentComponent",
"collectorItemId" : ObjectId("56d825c07fab7c76a1453332"),
"environmentName" : "QA",
"environmentUrl" : "https://udeploy.com/#environment/945f5524-88e3-4fe2-a992-80871341e302",
"componentName" : "app1.tar",
"componentVersion" : "<IP_ADDRESS>",
"deployed" : true,
"deployTime" : NumberLong(1469479507907),
"asOfDate" : NumberLong(1469479507907)
}
Collection: environment_status
{
"_id" : ObjectId("56d9ec217fab7c452af8090c"),
"_class" : "com.capitalone.dashboard.model.EnvironmentStatus",
"collectorItemId" : ObjectId("56d825c07fab7c76a1453332"),
"environmentName" : "QA",
"componentName" : "app1.tar",
"resourceName" : "app1-4-hwmb6",
"online" : true
}
`

That did it.  Thanks. :)


Create an endpoint that provide a way for user register on application

This endpoint must to be public. Anyone must to be able to register on the application

Done


Fix broken reference in README

README refers to "#willow channel at ba-st.slack.com" but I couldn't see it:

There's a #willow channel. Click on the plus sign and add it. Not all the
channels are added by default on Slack
On Tue, Jun 2, 2020, 19:25 Martín Dias<EMAIL_ADDRESS>wrote:

README refers to "#willow channel at ba-st.slack.com" but I couldn't see
it:
[image: Screenshot from 2020-06-02 18-19-12]
https://user-images.githubusercontent.com/3044265/83575572-d1b1e800-a4fd-11ea-9658-ffa3ab660e76.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ba-st/Willow/issues/168, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCK6EI4UMHJFC3MDHORSTRUV35TANCNFSM4NRECTIQ
.

Didn't know it works like that. In Discord/pharo you see the channels when you enter, I think.
So... do we consider this issue as invalid?


Source control not working

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T14:00:34.044Z)
OS Version: Darwin x64 15.6.0
Extensions:

Extension
Author
Version

githistory
donjayamanne
0.2.0

python
donjayamanne
0.6.0

vscode-clang
mitaki28
0.2.2

cpptools
ms-vscode
0.10.4

csharp
ms-vscode
1.8.0

gitblame
waderyan
1.3.0

Steps to Reproduce:

After update 1.11.*, Source control was showing blank.
After installing an extension "git", source control tab started showing the files modified. But, the diffs between modified files (right pane after clicking on modified file) shows blank and there is a progress in source control.

Disabling SCM, shows GIT entry fine.

@bpasero FYI

Does "Switch SCM Provider" show Git as a choice?

"Switch SCM Provider" does not show Git as a choice. "Disable SCM" solves the problem temporarily

#23977


⬆<EMAIL_ADDRESS>

Bumps jasmine-reporters from 1.1.0 to 2.3.2

Closing this for now. We are currently using a modified version of jasmine. Bumping this requires us to substitute our modifications to what is provided for by the latest jasmine api's. We plan to address this at a later date.


How would one proceed to write the Tree sturcture to a file for later read

Basically, my use case is to build tree once and then write it to a file (similar to a DB) with the value of this referencing another data (integer).
Then other process/services/libaries can just read the DB in memory and get the associated data to it.
I dont want to read the IP file to contruct the tree in memory everytime as the IP list is huge.
Any suggestion?

You'd have to write a custom serialization method, which is outside the scope of this project.


emojidata 5.0.1, skin variation crash fix and misc improvements

Hi @maxoumime - this PR adds support for the most recent emoji data release 5.0.1, and also includes fixes and improvements by @rursache and @onurgenes from their respective branches, in particular fixes a crash for unknown skin variations, and a previous addition I made for adding watchOS as a supported deployment target - for your consideration.
Cheers.

Hey @crafterm ! Sorry this library has been idle for a while. I'm working on implementing the new emojis from emoji-data and implementing the changes. I've reviewed the other PRs and merged some. I'll close this PR and will make a release, hopefully sometime this week


April public comment resolution

Addressed all public comments.

All changed reviewed by committee.

Completing review to enable merge of this PR to master

didn't meant to close.   Wanted to approve PR to merge this branch into master.


get track current tracking location

is there any way to get the current location in a Stream?
streamLocationActive   <-- get the current coordinates

Currently not, though this is technically possible, albeit with a little bit of effort. I'm not sure though how sensical this would be - this plugin primarily supports the two "long-term, battery saving location providers", that being SignificantLocationChange on iOS and Fusedlocationprovider on Android. These Providers share the location very infrequently anyways, not sure what you'd like to do with this information in the running App.
For the "running App" use-case, you probably want the high-accuracy, real-time location anyways. There are other plugins for that already. Last time I checked, the geolocation plugin was quite excellent.


[Implement rule] License file exists and has content

The file might be called LICENSE or  COPYING.

Please also accommodate LICENSE.txt, e.g., as https://github.com/EFForg/https-everywhere/ uses.

And LICENSE.md, as https://github.com/swcarpentry/git-novice/ uses.

And COPYING.txt, as in https://gitlab.com/mailman/hyperkitty/tree/master .

And README.rst, as in https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/ .

@brainwane: I'll implement a check for multiple possible filenames for a single file--this should be a pretty simple change. Right now, the tool checks for the presence of a given string ("LICENSE", for instance) as a substring of any of the filenames present in the given directory, so LICENSE.md and LICENSE.txt will both be detected. Is this reasonable behavior?

@fhocutt Thanks -- that is reasonable behavior in my opinion. :)


Update Anchor File

Protocol change:
https://github.com/decentralized-identity/sidetree-core/blob/master/docs/protocol.md#anchor-file-schema

fixed in https://github.com/decentralized-identity/element/pull/17


Upgrade SQLite to v3.35.2

Includes improvements to the download script, generously contributed by @mceachen

The new download script fails on my machine

How did it fail?
I tested it on Ubuntu 20.04.2, which comes with bash v5.0.17.

I'm using OSX. The readlink command failed on the unsupported option -f

The readlink command failed on the unsupported option -f

Sorry about that! https://github.com/JoshuaWise/better-sqlite3/pull/587 fixes this (and I verified that it works on my mac running Mojave).


Fix #2

Add missing override annotations
Fix NPE on Android 6.0+

Nice work! I wonder why I never saw this issue when I was testing on my 6.0 device....


Add HttpClientBuilder::with/withoutHeaderIfUnset()

Useful when we want to disable the default interceptors, as in https://github.com/symfony/symfony/pull/35115#pullrequestreview-337184875

I think these should be separate functions to opt-out of any of these

updated

I've implemented it slightly differently in #241, what do you think?

Works for me thanks!


Is Email functionality can be integrated with Hygieia?

Hi, We are trying to use Hygieia dashboard with SVN for first time.So do not have much idea, hence this might a stupid question:
Q: Based on the details that we have in DB for SVN, can we configure anything in Hygieia to send mails for  SVN details as report.
Or please let me know if we have any script available separately that we use to get the details and send the report.
Thanks !
-Akhilesh

@AkhileshKJ You could do an svn post-commit hook to send an email and provide the hygieia dashboard url within it. You could add email functionality within hygieia by changing some code in the svn collector, but you would need to think about what causes the email to be triggered.


Parallel execution

Make supports the -j argument for parallel execution
Propose a -s or -p flag to bake.run to support running multiple functions at once. Some related things:

Prefix different output so it's clear where it's coming from
Automatic zellij or Tmuxinator configuration for auto multiplexing instead of slower Bash thing
bake.run will replace bake-pedantic-cd

Closing as this is feature creep


New session setup page when opening microbit.org project

If no resource can be fetched from microbit.org, it start a new empty session.
Project name validation and default project name have been factored out so that it can be shared between edit project name dialog and new session set up page.

Hey sorry, picked the wrong order for merge and made another conflict. I can fix later!

Hey sorry, picked the wrong order for merge and made another conflict. I can fix later!

Just need to apply the change in https://github.com/microbit-foundation/ml-trainer/pull/399 to every use of navigate in the ImportPage file I think.

Is "Back" the right button text to use here? I'm not sure I'd expect it to take me to the app homepage.
It's less clear that the navigation should replace state now that import is actually a page that doesn't just redirect immediately. Maybe we just take the current changes and re-review the window.history changes after this is in?

Hey sorry, picked the wrong order for merge and made another conflict. I can fix later!

No worries! I think it's a simple conflict fix anyway.

Is "Back" the right button text to use here? I'm not sure I'd expect it to take me to the app homepage.

Not sure either, I was trying to mimic the "Open in classroom" experience.
If we want to keep a button that navigates home, perhaps we don't need the button since we already have a "Home" icon in the toolbar.

It's less clear that the navigation should replace state now that import is actually a page that doesn't just redirect immediately. Maybe we just take the current changes and re-review the window.history changes after this is in?

Sounds good

There are still things to discuss, so have put it to draft for now till ready for review again.

@microbit-grace I've asked Rob to pick this one up so you can focus on UT feedback.

The back button now navigates correctly using window.history so should always do the right thing.
useMicrobitResourceSearchParams has been inlined as useSearchParams being used there instead of the caller was causing the useEffect to run twice.
There is now a loading state on the start button to prevent the user from clicking on it before the fetch has completed.

5c50681

An aside, but we've now seen this test fail enough times for it to be irritating, so relaxing the accuracy we require here abaf4b2


LINK : fatal error LNK1104: cannot open file 'itkjpeg12.lib' in user projects

This happens when another project is building against ITK.
Steps to Reproduce

Configure and build ITK
Configure a project using ITK (a remote module such as https://github.com/InsightSoftwareConsortium/ITKFPFH will do)
Try to build it - it runs into LINK : fatal error LNK1104: cannot open file 'itkjpeg12.lib'

Reproducibility
100% on my Windows machine. I first noticed it in an incremental build, and confirmed it in a clean build.
Versions
It started with PR #4979. Latest good commit is 6a704aaadef717113aa80e7e021c408c086b3677.
Environment
Fully updated Windows 11 x64 version 24H2, with fully updated Visual Studio 2022, and CMake 3.31.1.

The problem is likely related to these lines:
https://github.com/InsightSoftwareConsortium/ITK/blob/948e77ae7da6395aaa42ed274b1c5eb8dde22c68/Modules/ThirdParty/JPEG/src/itkjpeg-turbo/CMakeLists.txt#L131-L143
Perhaps the commented out lines are needed.

Uncommenting lines 134 and 135 unfortunately does not help.

I just confirmed this happens with Ubuntu 22.04, cmake version 3.30.2, gcc 11.4.0.

I am looking into it. The itklibjpeg12 and itklibjpeg16 are created as "OBJECT" libraries. I am looking into the implications of that noq.


docs($animateCss): describe your change...

There was an extra asterisk, the second stagger is just a reference by the documentation, not the definition of a new field

I signed it!


Investigate and Fix Non-deterministic Halting Behavior in Square Fuzzer with Max Blob Size Close to Square Row Size

Problem
Originally raised in this comment
When setting the max blob size close to the square row size (# shares per row * share size), the square fuzzer exhibits non-deterministic halting behavior (on my local machine).  This  issue is to investigate this problem and identify a fix. This problem has not been noticed previously since all the test fixtures used a max blob size  around 1000 bytes.

Upon further investigation, it has been determined that this issue is not consistently occurring across all machines. It seems to be isolated to my local machine only. Therefore, I will be closing this issue.


Cleanup of code in the SubscriptionSerivce

make private variables readonly
don't convert enum to a string to check equality
remove unnecessary initialization
remove unnecessary ToList
fix spelling mistakes
add missing params to docs
remove unused code

Nothing happening here. Closing.


Add Miscellaneous POT file to account for straggling strings to translate

Some strings that are from core and being used on the platform won't be translated unless we add the full core translations, or just account for those strings we find in our own miscellaneous POT file :dancer:

Going the miscellaneous POT file route for now : red_car:


Extract array_dims, array_ndims and flatten functions from functions-array subcrate' s kernels and udf containers

Is your feature request related to a problem or challenge?
This issue aims refactoring by addressing following requirements:
functions-array subcreate is introduced in terms of Epic: https://github.com/apache/arrow-datafusion/issues/9285 and we can breakdown its kernels and udf containers to individual functions by aligning with our new pattern (a.k.a single func per file) for the consistency. This effort will extract array_dims, array_ndims and flatten functions.
Describe the solution you'd like
Extract array_dims, array_ndims and flatten functions from functions-array subcrate' s kernels and udf containers
Describe alternatives you've considered
No response
Additional context
No response

take


no http:// in canonical URL bug

Having a canonical URL not starting with http:// breaks everything. This modification throws an error in that case. Same with SSL canonical URL and https://
Franz suggested a pull request for this problem: http://www.concrete5.org/developers/pro-accounts/community-leaders-area/community-leaders-discussion/help-canonical-url-without-http-broke-complete-site-even-backend/
Here's Franz comment: http://www.concrete5.org/developers/pro-accounts/community-leaders-area/community-leaders-discussion/help-canonical-url-without-http-broke-complete-site-even-backend/#766489

And here's the bug report http://www.concrete5.org/developers/bugs/5-7-5-1/no-http-in-canonical-url-breaks-everything1/


Better syntax

Translated some elements in the code snippet
Better syntax in paragraphs

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@artigas Can you please change the sh to shell in the following section of the file?
```sh
> Tenemos Jim
 > Tenemos Jane
 > Tenemos Jack

```

Thank you.

Hi @artigas
As there has been no response from your end for a while, we are closing this PR.
Feel free to request this PR to be reopened or create a new PR, if you still wish to make the changes you originally added plus any additional change requests asked of you.  Also, remember to update your fork, so you have the latest version of master in case it has changed significantly.
Happy Coding!


[Death on the Reik] Missing journal entries

Cargo table from Death of the Reik Companion (page 72) is missing along with the Wine and Brandy tableFrom: Perkuns#9523foundry: 9.269wfrp4e: 5.2.0wfrp4e-altdorf: 2.0.1wfrp4e-archives1: 2.4.1wfrp4e-core: 2.4.2wfrp4e-dotr: 2.3.2wfrp4e-eis: 2.3.2wfrp4e-middenheim: 2.4.1wfrp4e-pbtt: 2.2.2wfrp4e-rnhd: 2.4.1wfrp4e-starter-set: 2.3.2wfrp4e-ua1: 2.3.1wfrp4e-ua2: 2.0.0

Included via the /trade function


UI: Make Activity Log an Activity Log, not a log of active stacks

User Story
As a user, I want to see a log of all activity I have on templates, not just the active templates being shown
Acceptance Criteria

[ ] The activity log shows all activity, not just non delete activity

after some discussion, we decided we don't want to show deleted templates, only installed ones.


Show alert if fan is not spinning

Fan without control wire, so maybe control overheat and show warning?

The panda measures fan rpm. I was thinking an alert which shows if there is a command above 10% fan speed, but the rpm reads zero.

The panda measures fan rpm

How does it do this?

an alert which shows if there is a command above 10% fan speed, but the rpm reads zero.

This will be annoying for those of us with Noctua fan mod, and soldered directly to 5V rails on EON board.
If possible, maybe a way to disable the alert? Or else the end user will need to edit the code to disable the alert.

I’m about to finish a first pass at this, what would be a good way to test this?

You could make a change to boardd to ignore the fan command.

Sweet, I'll test it out tonight.

Opened #2258 for this.


[TEST][TPCDS] Introduce schema check for queries-3

Why are the changes needed?

Introduce schema check for queries(thirty plus)
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #593 (a796af1) into master (1820864) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   79.86%   79.86%
=======================================
  Files         118      118
  Lines        4545     4545
  Branches      549      549
=======================================
  Hits         3630     3630
  Misses        608      608
  Partials      307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1820864...a796af1. Read the comment docs.

thanks meging to master for v1.2.0


iOS MLKInvalid Local Model

Hi, my app is running fine on android but on iOS I am getting an error, 'Terminating due to uncaught exception "MLKInvalidLocalModel" reason: Local model path (model.tflite) is invalid."
My tflite file is placed is ios/Runner/Resources/model.tflite. Model is showing in Copy Bundle Resources. I experimented with trying to use flutter_assets/ and with CustomLocalModel.file and CustomLocalModel.asset. My google_ml_kit version- 0.7.0 and have followed all the steps for installation. Can somebody please help me with this issue. I have been trying for a long while without any luck.

The model is working and runs fine on Android. Only getting this issue on iOS

Hi, can someone please help me with this issue, I'm really struggling a lot. @bharat-biradar

We released a new version of google_ml_kit in which we have split all the plugins in multiple plugins to avoid removing the models for API you are not using, go to our readme and start using the new plugin you need.
More details here:
https://github.com/bharat-biradar/Google-Ml-Kit-plugin/tree/master/packages/google_ml_kit


✨ No nested fetch

Summary
This PR changes the executable docs to not fetch the KubeStellar repo but rather use the copy of the repo that they find themselves executing in.
This makes the executable documents useful as tests, to developers and to CI.
Related issue(s)
Fixes #720

@MikeSpreitzer I checked out this PR and did mkdocs serve.  When viewing each of the examples I noticed you are doing a "make build" sequence twice in each.  Is this intentional?

@clubanderson: I just reviewed http://<IP_ADDRESS>:8000/Coding%20Milestones/PoC2023q1/example1/ and found make build twice, as expected --- once for kcp and once for kubestellar.  Are you seeing something different?

Ok. That's what I thought. Just checking to make sure that was your intent.

/ok-to-test

@MikeSpreitzer the reason why the docs-ecutable were skipped is because you currently need 'ok-to-test' label to allow those tests to run.  With changes to the workflows for pull and push, this may no longer be necessary


Fix wkt math transform record id

Stumbled upon a small typo in the OGC MATH TRANSFORM WKT RECORD

Thanks 👍


change sublayer renderer sample

shows how to change a sublayers renderer. no offline data required

@john0005 please review when you get a chance


Remove some code for old-style IIIF Manifest URLs

The context here is that our IIIF manifest URLs used to look something like:
https://wellcomelibrary.org/iiif/b12345678/manifest

and if you clicked "View item" on a work with a digitised item and one of these URLs, we'd send you to the Universal Viewer (aka the UV, an open-source viewer) on the old Library site.
At some point we started rendering digitised items on wc.org, and we moved all the IIIF manifests to a new domain, e.g.
https://iiif.wellcomecollection.org/presentation/b12345678

It looks like we kept the redirects for "permission required" items after we started rendering items ourselves, and maybe the UV had some sort of clickthrough that would handle that for us, I don't remember.
It's a moot point now, because:

We'll never send a user over to the old Library site, because the regex for getting the Sierra ID from the manifest URL will always return undefined – it's looking at the old URL pattern
If you did go to the page on the old Library site, we'd redirect you back to the new site because the old site is gone

I noticed this code last month; it wasn't until today that I remembered it was relying on old/new URL patterns, and so all this code is unreachable and can be safely deleted. And then I did that.
This starts by modifying sierraIdFromPresentationManifestUrl to return undefined, and working outwards from there.

I'll rewrite the getItemLinkState function now it only needs to return a boolean state. I'll do this as part of the work on the works tabbed navigation.


Publish @carbon/ibm-cloud-paks npm module

Acceptance criteria to be defined in Slack

Publishing/modifying npm packages is restricted to owners. There is only one level of access.
https://docs.npmjs.com/cli/owner
A list of owners for carbon-components-react, for instance, is as follows. It is of note that they have a carbon-bot email address which I suspect is for automated publishing. Confirmation will be sort from @joshblack
$npm owner ls carbon-components-react
abbeyhrt<EMAIL_ADDRESS>adavila<EMAIL_ADDRESS>carbon-bot<EMAIL_ADDRESS>dakahn<EMAIL_ADDRESS>emyarod<EMAIL_ADDRESS>jnm2377<EMAIL_ADDRESS>joshblack<EMAIL_ADDRESS>tjegan<EMAIL_ADDRESS>vpicone<EMAIL_ADDRESS>

Without an automated build (as is the case for @carbon/vue) 'lerna publish' can be used to manage the publication of multiple packages from a repo.
https://www.npmjs.com/package/@lerna/publish

Let me know if we can help out with this, if publishing from CI we can provide an NPM_TOKEN for the carbon-bot.
Similarly, we can create a group of users under the @carbon scope and give them access to the relevant packages.
Lerna is a great tool for publishing, especially with the conventional commit flag. Let me know if you want to chat about it at all!

For the first release, I'd be happy with enough configuration that enables us to automate the publishing of a package and tag based on conventional commits.

@SimonFinney very nice, lerna version has a --conventional-commits option for this: https://github.com/lerna/lerna/tree/master/commands/version#--conventional-commits
Similarly, you can use --conventional-prerelease and --conventional-graduate for a prerelease workflow.
It should help generate relevant tags and release changelogs (and CHANGELOG.md files) too!

There's also the option to use lerna publish, which includes a call to lerna version from the command line to publish to npm.

@carbon-design-system/ibm-cloud-paks See https://github.com/carbon-design-system/carbon/blob/master/docs/guides/endgame.md for how we might want to model our release process

@SimonFinney if it helps out, we simplified a bit from that end game process to basically the following:

We follow 2 week sprints
We're on a time-based release cycle
Every other week (the second and fourth of each month) we do a minor release
In between minor releases, we can still patch or do hotfixes in a patch release
Before every minor release, we ship a Release Candidate for a sample of teams to verify

One flow that we used before (that unfortunately is busted because of a lerna challenge we have) is a nightly release flow (published under the nightly tag) that is a nice complement to the time-based cycle for teams that want to stay up-to-date (or if we want teams to help with experimented with stuff)
The last part of this process is that our "release team" cycles every month. The release team has two members, a lead and a side-kick. The lead owns the release along with training the side-kick. They are also on-deck for handling any release-related problems reported on GH or Slack, alongside determining release scope (what should / should not go into a release)

Thanks @joshblack ! That certainly helps simplify it - So far, my current thinking is:

Time-based minor releases at a minimum once a month
Hotfix and patch releases in-between minor releases where necessary
A release candidate cut the week before a minor release for verification


Can we add a new 'between' type?

The screenshot shows a previous implementation that serves as an example of what we want to do with this library. We basically want to add a between function to it.
We know that there's a couple of previous requests for this function and we would like to implement it ourselves  and share it with the community:
https://github.com/react-querybuilder/react-querybuilder/pull/96
https://github.com/react-querybuilder/react-querybuilder/issues/73
We would use html’s native date input, but the difference is that between would, under the hood, there would be two inputs.
We want to add a case to the switch statement in ValueEditor.tsx. Does this sound ok? Before we start working on this, we want to make sure that we're implementing things in a way that you'll be ok with

Hi @laportabellita, sorry it took me so long to get to this request.  In general I think this would be a good enhancement, and the ValueEditor.tsx modifications would be fairly straightforward, but you would probably need to modify the structure of the internal JSON representation of the query to accommodate two separate values.  That would be the bulk of the work -- making sure all the various TypeScript code conformed to the new format.  I might even make it a major version bump because of the new structure.  Just thinking out loud.  Go ahead and start your work and if you have any questions just reach out to me.  Thanks for being willing to contribute!

Anything new about this feature ? is it possible to implement it? Thanks

I had an epiphany and realized this can be accomplished with the current feature set.  See this codesandbox for a simple example.
The key was to use an array of two elements instead of a primitive for value and handle it appropriately in a custom ValueEditor. I then passed a custom valueProcessor to the formatQuery function to produce the correct SQL. Voilà!

Update:  this codesandbox uses react-datepicker to select a proper date range! :)

Hi @jakeboone02 , I think the above expample is working based on field . But its should work based on operator this example not working as expected when I selected =

I think all you have to do is include operator in your criteria for using the dual inputs.  Like this:
import {
  ValueEditor as DefaultValueEditor,
  ValueEditorProps
} from "react-querybuilder";

const ValueEditor = (props: ValueEditorProps) => {
  const { field, value, handleOnChange, operator } = props; // <-- deconstruct `operator` from props

  if (field === "field1" && operator === 'between') { // <-- check for `operator === 'between'`
    const [val1, val2] = value === "" ? ["", ""] : value;

    return (
      <>
        <input
          type="text"
          value={val1}
          onChange={(e) => handleOnChange([e.target.value, val2])}
        />
        and
        <input
          type="text"
          value={val2}
          onChange={(e) => handleOnChange([val1, e.target.value])}
        />
      </>
    );
  }

  return <DefaultValueEditor {...props} />;
};

export default ValueEditor;

It would be awesome if between and not between is available in default operator's list, then not everyone has to implement the same logic. just a thought...

@vijayky - I could easily add "between" and "notBetween" to the defaultOperators list, but implementing the array-based value handling logic I think would be a little too specialized to include in the standard distribution. There are instructions here, and working examples linked, for using custom ValueEditor and valueProcessor functions to accomplish the desired result. I believe that would be sufficient for those who are required to implement a "between" rule.

Yes, that's fine. Thank you for everything.
On Thu, Sep 30, 2021, 8:18 PM Jake Boone @.***> wrote:

@vijayky https://github.com/vijayky - I could easily add "between" and
"notBetween" to the defaultOperators list, but implementing the
array-based value handling logic I think would be a little too specialized
to include in the standard distribution. There are instructions here, and
working examples linked, for using custom ValueEditor and valueProcessor
functions to accomplish the desired result. I believe that would be
sufficient for those who are required to implement a "between" rule.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/react-querybuilder/react-querybuilder/issues/201#issuecomment-931796238,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCDZALLRTUQCUHPEWPVYPTUET47BANCNFSM453KKKEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Awesome Jake! Thanks a lot...
On Mon, Oct 4, 2021, 12:45 PM Jake Boone @.***> wrote:

@vijayky https://github.com/vijayky - actually I changed my mind and
went ahead and added between/notBetween operators to the default set. See
PR
#225 https://github.com/react-querybuilder/react-querybuilder/pull/225.
formatQuery will also handle them by default, if the rule value is an
array of length 2 or a string with exactly one comma that is not the first
or last character.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/react-querybuilder/react-querybuilder/issues/201#issuecomment-933664038,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCDZAOOHMJ5MIVIUOSAFE3UFHK2TANCNFSM453KKKEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

The between and notBetween operators are in the default list in v3.12.0.


Bug: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found

Bug report
just updated sdkman via cli today (2023-06-08) and now get the following error:
/****/.sdkman/libexec/help: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /****/.sdkman/libexec/help)

To reproduce
On Linux Mint 19.3 install/update sdkman
System info
$ uname -a
Linux oni 5.4.0-146-generic #163~18.04.1-Ubuntu SMP Mon Mar 20 15:02:59 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

$ lsb_release -a
No LSB modules are available.
Distributor ID: LinuxMint
Description:    Linux Mint 19.3 Tricia
Release:        19.3
Codename:       tricia

$ sdk version
/home/fredo/.sdkman/libexec/version: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /home/fredo/.sdkman/libexec/version)

$ cat /****/.sdkman/var/version
5.18.1

$ cat /****/.sdkman/var/version_native
0.1.3

Resolution Proposal
do a static link of your binaries against musl to make them distro/version agnostic.

update
i cleared out the .sdkman directory and reinstalled sdkman as per usual instructions ... still same error.


feat: Implement range table function

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?

add new_range() entry point in src/expr/src/table_function/mod.rs
add the Range test cases according to GenerateSeries
add _stop_inclusive property to GenerateSeries, to control whether the stop is inclusive or exclusive, making it to be true for GenerateSeries
use GenerateSeries with _stop_inclusive as false to be the Range

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes

SQL commands, functions, and operators

Release note
Support range function described in https://duckdb.org/docs/sql/functions/nested#range-functions .
Refer to a related PR or issue link (optional)
#6570

This PR is reopened in #6604 due to some problems in CI


Add a Troubleshooting section to the Build Speed guide

Added a small section that the first build with --active-arch-only on a clean environment might break (it does on 0.68). The issue is fixed on main and will land on 0.69: https://github.com/facebook/react-native/commit/5dff920177220ae5f4e37c662c63c27ebf696c83
(maybe we want to backport it to 0.68.1 @kelset ?)
Aside from that, better to have it on paper somewhere.

yeah I think backporting is a good idea 👍 I'll add to the relevant issue

Can we merge this?


Add Vagrantfiles to Zookeeper

JIRA: AN-79

@abelboldu Please review these basic vagrantfiles which I have added. I will add Ansible provisioning to it. So do not merge it yet.

Actually, there is no need to make two different vagrantfiles. I will combine those two into one.

@abelboldu Added Ansible provisioning. Please review and let me know if its correct.


fix(checkpoint): bumps save interval to 1GB

As per the title. Systems with slower disks were showing delays with writing save files so often.
@allisonheath
@millerjs r?

👍


[CQ-4351856] Check syncing of HTML for each core component in repeatability.

Description
Tests for repeatability for each core component and make sure none of the Id's are duplicated. Currently excluding the ones that have a bug in them (Radiobtn, checkbox, fileinput).

Related Issue
CQ-4351856

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Closing the PR since additional changes are needed.

is this required now after https://github.com/adobe/aem-core-forms-components/pull/471 ?

@nit23uec Looks like @deepprakash345 pulled in the code from this branch in his PR.

Merged in https://github.com/adobe/aem-core-forms-components/pull/471


ignore non-jest workspace roots

I have a workspace with folders without tests:

...
and I always get errors:

After this fix they're just ignored

Not having tests in wiki sounds perfectly legit to me :)

Firstly, thanks for being willing to contribute to this project - you're the first 🥇.  I like the idea of omitting projects that do not have tests in them - I have a monorepo with a bunch of projects that don't have tests in them.
However, I'm not sure that the changes you've made are in line with what I had originally intended.  I think it may be to do with the setup of your multi-project solution.  The reason I say this is because the names of your projects are all the same: "default".  This is the name that the StandardParser gives to projects when it can't figure out the name of the project from package.json.  That parser is the one intended for a single project solution not a multi-project/monorepo solution.  Which I see one of your other PRs is trying to address.
My intent is that this.projectManager.getTestState() returns the state for all the projects in the solution, which is why holds a WorkspaceRootNode with multiple ProjectRootNodes.  The latter holding the state for an individual project.  I admit the naming of some of this stuff is not great - I intend to do a bit of refactoring before writing tests, so I can understand that it probably isn't clear.
I see that vscode_abap_remote_fs is on GH, in your screenshots above, is that the only repository you have open?  I.e. can I reproduce your original issue if I checkout that source?

Nono, the "default" is its parent, and can only be one of "react","angular" or "default" (or something similar). You can set up the gui to merge those with the same name, which is probably a better ux when they're all the same. Honestly I would just drop the root when has only one child (I suspect always for how is designed now, but wasn't sure)

Added a picture on #28 about the label

Ok, as I mentioned, I like the idea of this.  Couple of things:
What do you think about a setting flag to enable disable this functionality?  Just in case someone wants them to display.  Or for debugging purposes, we want to see if a particular project is actually discovered?
Also, I question the implementation.  My preference would be to handle this as late as possible.  Either in the mapWorkspaceRootToSuite method (filtering out any projects with no tests in them) or in the calling method.  That way the ProjectManager functions the same either way and if the test count drops to zero or increases from zero the project should disappear/appear appropriately.
Other things that I've considered in the same vein is collapsing down some of the folders that just add clutter (e.g. the src folder that is often the direct child of every project doesn't add much value - just increases the hierarchy).

It's not skipping folders without tests, it's skipping folders without a valid test model aka when it can't detect jest.
If I delete the tests in my repo, will look like this:

...instead of this:

Same for workspaces:

Wiki doesn't show up but I don't have jest in that, on top of not having any test
For this reason I see little value adding a flag. If we do we should also extend the error message to mention what folder it came from, or would be pretty useless. Logging it makes more sense imho
About handling this later, I don't like it as then you need a lot of defensive code to prevent accessing the undefined model and stuff coming from it.
In mapWorkspaceRootToSuite you would have to raise an exception, or add a test from the caller to check if the suite is valid. If I don't have jest at all in a workspace folder I don't want an empty suite, I just don't want to see it. Also because quite possibly I have another test framework there. Or stuff which I don't test, like documentation

Do you want to have a look at this branch which is an incomplete implementation of what I expect this feature to look like.  It doesn't handle one of your projects (the root one) which cannot locate Jest (because it isn't a dependency, so it is not found).  I think that is a separate issue though.  Will have to think about the correct way to handle that.

Works fine. I do see the value of making this one optional, as one might wonder where's his empty suite :)

Ok, cool.  Did you want to complete the development on that branch?  The code could be cleaned up a little and as you mentioned, someone might want to see their empty projects, so a setting might be a nice touch.

No sorry, it's good enough as it is for me, and have a ton of other things to do.


Add Gray to System Related Tools

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
This is for all the people that want to tailor their macOS experience.

Added Gray to the list of System Related Tools

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[ ] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thanks @zenangst


Range slider

Could you please add range slider widget?
Same as slider but with two selections - from and till

Sorry for a late response. We will consider it when planning for the 1.6 release.

hi. Do we have this in our roadmap ?

Since this is not a widget natively available on all platforms there are no immediate plans. It would be great to see a third party widget adding support for by wrapping platform specific libraries.


Please add some means to let us know the lost of connection.

Currently, we have no means to handle the lost of connection .
When the connection broke unexpectedly, the whole ruby script just crashed.
Please add some means to catch this kind of exception, so that we can reconnect manually in our code.
See the attachment log, when connection was lost, the whole process just crashed.
connectionLostCrash.txt

Your log file shows a Segmentation fault.
This is a bug in Event Machine, it is not something that can be caught in ruby / ruby-em-mqtt.
unbind should be called and an exception thrown when the connection is lost.

@njh Why raising a global error though? It makes reconnecting/etc harder

EventMachine uses event processing rather than threads to handle multiple connections (a bit like node.js) - everything runs in the main thread.
I am going to lock this conversation because it doesn't seem related to the original issue.


AutoIndent funk

re #29492
See attached recording and source. With a two line selection things get weird, I cannot describe what it actually does.

        move it

I know try to explain what's happening is not ideal but let me try
If there is no auto indent of moving lines, you will get

        move it

But since we add indentation regex rules (which is not context aware or smart), we decrease the indentation of
 as it's a closing tag. And then all moving block aligns to the new indentation.
The final correct fix is the closing tag
 should align to its opening tag. We can enhance this in our bracket matching part but not in indentation rules (at least current TextMate 4 indentation rules). Hope my explaination makes sense.

Also facing this issue when trying to move lines - it just breaks everything you move it across. Auto-indent per se I love, but this makes moving lines super painful. Perhaps the easiest solution would be a setting to simply not apply auto-indent on move line commands?

This is due to the limited architecture (regex based indentation rules), we may want to consider using formatters if they exist for indenation adjustment (if interested, we can discuss in https://github.com/microsoft/vscode/issues/19847).
For this particular issue, if the indentation rules are leading to more trouble than having no auto indent, you can set editor.autoIndent to advanced to disable the regex based indentation adjustment. As we don't have an easy good-enough fix for it, we close it for now and explore better solutions through issues like https://github.com/microsoft/vscode/issues/19847.


iframe resources load event

create function to observe iframe resources load status.
use it to optimize when iframe height calculation call should happen.
loading indicator for iframe.
remove FOUC, especially for static snippets.

Works on first load, while on second or further loads there is just a static delay.
IE still has some timing issues due to CSS transitions or perhaps something else.
Done.

Done.

Needs testing.
Also some changes might be needed after CSS resource loading workflow will be changed.


Issue with TanStack Query Plugin: asClass Field Not Grouping Output Properly

Description
The TanStack Query plugin does not follow the asClass field in the configuration. When I set the asClass field to true, the generated react-query.gen.ts file is not grouped like the service.gen.ts file.
Reproducible example or configuration
https://stackblitz.com/edit/hey-api-client-fetch-example
OpenAPI specification (optional)
No response
System information (optional)
No response

Hi @dengyong-ola:

Why would you expect the TanStack plugin output to follow the same pattern?
What would you expect the output to look like, including query keys, mutations, queries, and infinite queries?

Sorry, maybe I was hasty. I just had a gut feeling it should be this way.

@dengyong-ola Well, maybe! I'd like to understand why people prefer certain syntax over another. Previously I've been told they don't mind what this output looks like


Vector serialization

Added serialization and test for vector type.

Add version constraints to vector in the library.
Rebase this on the latest master


Thank you for  not making me pay hundreds for new Razer Keyboard!

Ur the best!

<3


workflows: Bump the timeout for Ginkgo tests

We've recently reenabled some quarantined tests and the workflow is therefore hitting the 35min timeout once in a while. That timeout didn't make a lot of sense anyway since a substep has a timeout of 40min. Let's bump it to 45min.

/test


Sceneform support GLB and GLTF for animated models

Hello! Are there any news on animated models support for GLB and GLTF?
Conversion to SFB is a huge pain in the back - it takes great amount of resources with little reward. A lot of objects are not converted properly because of textures problems and some are crashing the app even after successful conversion.

Yes, I too had similar problem. I want to covert obj+mtl+textures in SFB file format but it is time and resource consuming.

1 vote for this support.


Move database configuration to their most relevant "home" projects

I think we're settling on:

copresentation, cosearch, externalmeta, filemeta, internalmeta -> cihm-metadatabus
tdrepo -> cihm-repomanage (already done)
wipmeta -> cihm-ingestwip
cms -> cap

As a reminder, where is the design document with the view used by the parl project?

/copresentation/_design/parl). (It's an upholstery link, so you'll need to set the cookie). I don't believe I've added this design doc to couchdb-config yet.


Defaults python2 readline support broken?

Readline cursor motion support seems to be broken with the defaults install of python=2.7.14 and the conda-forge version of r-rpostgresql. I'm running based off of an Anaconda 5.1.0 install (conda info below).
$ conda info
     active environment : None
            shell level : 0
       user config file : /home/s1/kadrlica/.condarc
 populated config files : /home/s1/kadrlica/.condarc
          conda version : 4.5.1
    conda-build version : 3.4.1
         python version : 2.7.14.final.0
       base environment : /home/s1/kadrlica/software/anaconda/anaconda2-5.1.0  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/linux-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/free/linux-64
                          https://repo.anaconda.com/pkgs/free/noarch
                          https://repo.anaconda.com/pkgs/r/linux-64
                          https://repo.anaconda.com/pkgs/r/noarch
                          https://repo.anaconda.com/pkgs/pro/linux-64
                          https://repo.anaconda.com/pkgs/pro/noarch
          package cache : /home/s1/kadrlica/software/anaconda/anaconda2-5.1.0/pkgs
                          /home/s1/kadrlica/.conda/pkgs
       envs directories : /home/s1/kadrlica/software/anaconda/anaconda2-5.1.0/envs
                          /home/s1/kadrlica/.conda/envs
               platform : linux-64
             user-agent : conda/4.5.1 requests/2.18.4 CPython/2.7.14 Linux/2.6.32-696.20.1.el6.x86_64 scientificfermi/6.4 glibc/2.12
                UID:GID : 47737:9620
             netrc file : /home/s1/kadrlica/.netrc
           offline mode : False

conda create -n rpsql-test python=2.7.14 r-rpostgresql --channel defaults --channel conda-forge

Solving environment: done

## Package Plan ##

  environment location: /home/s1/kadrlica/software/anaconda/anaconda2-5.1.0/envs/rpsql2

  added / updated specs:
    - python=2
    - r-rpostgresql

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    setuptools-39.0.1          |           py27_0         582 KB
    pip-9.0.3                  |           py27_0         2.4 MB
    certifi-2018.4.16          |           py27_0         142 KB
    wheel-0.31.0               |           py27_0          61 KB
    ------------------------------------------------------------
                                           Total:         3.2 MB

The following NEW packages will be INSTALLED:

    bzip2:           1.0.6-h9a117a8_4
    ca-certificates: 2018.03.07-0
    cairo:           1.14.12-h77bcde2_0
    certifi:         2018.4.16-py27_0
    curl:            7.59.0-h84994c4_0
    fontconfig:      2.12.6-h49f89f6_0
    freetype:        2.8-hab7d2ae_1
    glib:            2.53.6-h5d9569c_2
    graphite2:       1.3.11-hf63cedd_1
    gsl:             2.4-h1bed415_3
    harfbuzz:        1.7.6-hc5b324e_0
    icu:             58.2-h9c2bf20_1
    jpeg:            9b-h024ee3a_2
    krb5:            1.16-h3f6afd0_6
    libcurl:         7.59.0-h1ad7b7a_0
    libedit:         3.1.20170329-0     conda-forge
    libffi:          3.2.1-hd88cf55_4
    libgcc:          7.2.0-h69d50b8_2
    libgcc-ng:       7.2.0-hdf63c60_3
    libpng:          1.6.34-hb9fc6fc_0
    libpq:           10.3-h1ad7b7a_0
    libssh2:         1.8.0-h9cfc8f7_4
    libstdcxx-ng:    7.2.0-hdf63c60_3
    libtiff:         4.0.9-h28f6b97_0
    libxcb:          1.13-h1bed415_1
    libxml2:         2.9.8-hf84eae3_0
    ncurses:         5.9-10
    openssl:         1.0.2o-h20670df_0
    pango:           1.40.11-h8191d47_0
    pcre:            8.39-1
    pip:             9.0.3-py27_0
    pixman:          0.34.0-hceecf20_3
    python:          2.7.14-ha6fc286_23
    r-base:          3.4.1-3            conda-forge
    r-dbi:           0.6_1-r3.4.1_0
    r-rpostgresql:   0.6_2-r3.4.1_0     conda-forge
    readline:        7.0-hb321a52_4
    setuptools:      39.0.1-py27_0
    sqlite:          3.23.1-he433501_0
    tk:              8.6.7-hc745277_3
    wheel:           0.31.0-py27_0
    xz:              5.2.3-h55aa19d_2
    zlib:            1.2.11-ha838bed_2

Proceed ([y]/n)? y

Downloading and Extracting Packages
setuptools 39.0.1############################################################ | 100%
pip 9.0.3#################################################################### | 100%
certifi 2018.4.16############################################################ | 100%
wheel 0.31.0################################################################# | 100%
Preparing transaction: done
Verifying transaction: done
Executing transaction: done
#
# To activate this environment, use
#
#     $ conda activate rpsql2
#
# To deactivate an active environment, use
#
#     $ conda deactivate

$ python
Python 2.7.14 |Anaconda, Inc.| (default, Nov  8 2017, 22:44:41)
[GCC 7.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> abcd^A^A^F

Ctrl-A should take the cursor to the beginning of the line, but instead it prints ^A.

I'll note that using just --channel conda-forge does not have this problem. It's ok to tell me "conda-forge never promised compatibility with defaults", but if there's an easy fix that would be great.

This problem does not occur with r-rpostresql from --channel chenghlee.

It's ok to tell me "conda-forge never promised compatibility with defaults",

You guessed it!
https://conda-forge.org/docs/conda-forge_gotchas.html#using-multiple-channels

but if there's an easy fix that would be great.

Is there a particular reason you want to use python from defaults and r-base from conda-forge? In general if you want to use conda-forge packages, you should prioritize it over the defaults channel. Either in your ~/.condarc file or at the command line, e.g. -c conda-forge -c defaults prioritizes conda-forge.
https://conda-forge.org/docs/conda-forge_gotchas.html#how-to-fix-it

Thanks. There are reasons that I prefer defaults (but perhaps not a particularly good ones). I've got this working with the older version from chenghlee.


duplicate oldUrl fix

When there are duplicated urlOld's on the DB table, _customRedirects.Add(); crashes and does not continue with completing list.
I added try clause on each iteration to continue building list even if duplicates are present.

I don't think that catching an exception is the best solution. It would be better to check if a key already exists in a dictionary and update the value.
https://stackoverflow.com/questions/12416735/containskey-vs-try-catch

Fixed in https://github.com/Geta/404handler/pull/209


Header style

Was trying to figgure out why I couldn't manage to get a header in bold and the message in normal style.
Figgured out that I was testing it in the error case and this css was beeing set as default:
this.$message.css({fontWeight: 'bold'});
Maybe abit confusing that this css is only applied to error and overrides what's beeing set in the text?

Yep, sorry about that. v3 released and js themes are deprecated now. All themes are uses css now.


Usage of String::push_str instead of write macro

I have seen in codegen.rs, that you use String::push_str:
            output.push_str("enum class ");
            output.push_str(&enum_.name);
            output.push_str(": ");
            output.push_str(&codegen_type(ty, project));
            output.push_str(" {\n");

This could be replaced with the write! or writeln! macro, if std::io::Write is in scope.
            writeln!("enum class {}: {} {{", enum_.name, codegen_type(ty, project));

This would also be a good first step into moving away from heap allocated strings as output and using the Write trait as output.
But while String::push_str returns a () type, the write! macros return Result<(), std::io::Error, which would need to be handled in some capacity.
I would be interested to hear, how you feel about this.

push_str generates less code and usually can't fail

Hmm, I have to admit, I wasn't aware of String::push_str generating less code. Maybe one could argue in favor of readability, but I was not aware of the drawbacks. 😅

Can this be acceptable?
    if enum_.underlying_type.is_some() {
        let ty = enum_.underlying_type.unwrap();
        if is_integer(ty) {
            let mut output = format!(
                r#"enum class {}: {} {}"#,
                enum_.name,
                codegen_type(ty, project),
                "{"
            );
            for variant in &enum_.variants {
                match variant {
                    CheckedEnumVariant::Untyped(name, _) => {
                        output.push_str(format!("    {name},").as_str())
                    }
                    CheckedEnumVariant::WithValue(name, value, _) => {
                        output.push_str(
                            format!("    {name} = {},", &codegen_expr(0, value, project)).as_str(),
                        );
                    }
                    _ => unreachable!(),
                }
            }
            output.push_str("};\n");
            return output;
        } else {
            todo!("Enums with a non-integer underlying type")
        }
    }

I mean acceptable is anything, I am not the one accepting. I just took the enum as a example and meant more the whole file. 😅
But yeah, I think this is better readable. I still think using write! would be shorter to write, but I understand, that that is not really important.

When the toolchain updates to use Clippy v0.1.63, clippy will get mad at the push_str(format!(...)) pattern, anything else is better left as push_str().

Ok thanks! We can close this :D


Timestamp displaying invalid date in mozilla and Edge.

Hi @sujeetjaiswara,
Thanks for getting in touch.
Can you provide some context of this issue? Are you using Azure Mobile Apps on Cordova? What is the reproduce steps of your issue?

I am using vanilla js.
function successD(rs) {
let obj = rs;
console.log(rs[0].lastAccessed);
}
getRecords();
function getRecords() {
table
.read()
.then(successD, failure);
}

What's the table definition for the table? Can you share a reproducible demo?

Can I see students table declaration?

@andreujuanc  You mean table in azure portal ?

Oh sorry, you are not using the sync functionality. I thought you were.
Let me see if I can repro that on my side.

@sujeetjaiswara, in case you haven't seen it yet, I recommend following Azure Mobile Apps get started doc and How to use Apache Cordova client library doc . Please share detailed repro steps of your issue.

Hi @dhei
I am using following doc for my app.
https://docs.microsoft.com/en-us/azure/app-service-mobile/app-service-mobile-html-how-to-use-client-library

@dhei and @andreujuanc
I just returned plain text in "tryParseIsoDateString()" function then i get desired  results.(timestamp).
I think, problem in "tryParseIsoDateString" function. Could you fix this ?
exports.tryParseIsoDateString = function (text) {
    return text; /* For debugging purpose. (sujeet)  */

    /// <summary>
    /// Try to parse an ISO date string.
    /// </summary>
    /// <param name="text" type="String">The text to parse.</param>
    /// <returns type="Date">The parsed Date or null.</returns>

    Validate.isString(text);

So, if I understand correctly, this is a workaround that you've implemented and you get the desired results?  If you're happy with that I would continue using the workaround.  If you think these is a bug in our SDK then you're welcome to make a PR.

@jwallra
In chrome, i am getting correct timestamp.

This should be cover by a test. @sujeetjaiswara can you cline the project, run the unit tests in ur machine and see if they pass? Might be some localization issue.

@andreujuanc
I am using 2018-07-21 08:31:05.623 & 2018-07-23T09:31:18.82Z timestamp.

@here
I fixed this issue after update of following line:
// Matches an ISO date and separates out the fractional part of the seconds
// because IE < 10 has quirks parsing fractional seconds
// var isoDateRegex = /^(\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2})(?:\.(\d*))?Z$/;
var isoDateRegex = /(\d{4})-(\d{2})-(\d{2})T(\d{2})\:(\d{2})\:(\d{2})[+-](\d{2})\:(\d{2})/; //(fixed for mozila & edge browser)

Thanks @sujeetjaiswara for your help!  I'll close the issue now :)

@jwallra
Could you commit this fixed applied in your cdn library ?

@sujeetjaiswara Actually, the regex above doesn't looks correct. The groups are changed and that broke usage in the code below.


doc frequency for wiki corpus results?

For the wikipedia corpus output you provide (link in README), when calculating weight1 and weight2, what is the correct document frequency to use?

Output file consists of six columns following the output format in README.
Specifically, weight1 uses the total number of Wikipedia pages (4,379,810) and sdf (fifth column) and
weight2 uses them and df (fourth column).

thanks, that answers my question.


Added Contribution Guidelines

Add Contribution Guidelines and Link in README.md
fixes issue #57
Description
This PR introduces the following changes:

Created a CONTRIBUTION.md file:

Added clear guidelines on how to contribute, including:

How to fork and clone the repository.
How to create a new branch for feature or bug fixes.
Steps for committing and pushing changes.
Submitting a pull request.
Coding standards, commit message guidelines, and issue reporting instructions.

Included details about reporting bugs, creating pull requests, and the project's code of conduct.

Linked CONTRIBUTION.md in README.md:

Updated the README.md to add a link to the contribution guidelines under the "Contribution" section.

Motivation and Context
These changes aim to make it easier for new contributors to understand how to contribute to the project and ensure consistency in contributions. The contribution guidelines provide clear instructions and best practices, helping maintain a smooth collaboration process.
How Has This Been Tested?

Reviewed the markdown formatting to ensure proper display.
Checked that the README.md link correctly points to the CONTRIBUTION.md file.

Types of Changes

[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Code refactor
[ ] Other (Please specify):

Checklist:

[x] My code follows the code style of this project.
[x] I have thoroughly tested my changes.
[x] I have updated the documentation if necessary.
[x] I have linked relevant issues in the PR description (if applicable).

@ag21o9
LGTM!


Fix computation of foo.count.XXX, foo.rate.XXX counters

foo.count.60, foo.count.600, etc. counters should return the number of samples, not the sum.
foo.rate.60, foo.rate.600, etc. counters should compute their value as "sum" / "period in seconds".

This PR fixes both computations and add unit tests to check for them.

my rate computation is not correct. Will open a new PR just the count fixes.


If the directory doesn't exist

Details
new Dubnium() will not work if the directory doesn't exist.
Method
Dubnium
Device info
n/a

Resolved in v2.3.1


[Feature Request] Commands on hitting border

Hi i would like to know if it would be possible to get server owners to set a command depending on where someone hits the world border.
Let me explain.
if they hit the northern border i would like them to be teleport-ed to a multi-world setup ie. /server North
If they hit the southern border i want them to just be pushed back as by default in the plugin
East and west similar either a /teleport to spawn or maybe a /give command as reward for reaching it
on a round border it would be much harder but i can imagine setting angles between which command X runs ?
Thank you for reading this and possibly considering (or telling me its not possible)

hey im a bit late, but did you manage to do this? im looking for something similar


956 package tree report

implements #956
Tests on 3.6 are passing.
I have run it on python 2.7 but not the tests as pip will not install dependencies due to ssl errors.
On 2.7 only tests/test_html.py::HtmlGoldTests::test_bom is failing but I can't figure out why.

Codecov Report

Merging #961 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #961      +/-   ##
=========================================
+ Coverage   94.09%   94.1%   +0.01%
=========================================
  Files          86      86
  Lines       12089   12182      +93
  Branches     1210    1228      +18
=========================================
+ Hits        11375   11464      +89
- Misses        580     582       +2
- Partials      134     136       +2

Impacted Files
Coverage Δ

coverage/html.py
100% <100%> (ø)
:arrow_up:

tests/test_arcs.py
98.51% <0%> (-1.49%)
:arrow_down:

coverage/xmlreport.py
100% <0%> (ø)
:arrow_up:

tests/test_xml.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2e0e4...b0276bd. Read the comment docs.

The tests are currently failing with:
Traceback (most recent call last):
  File "/Users/ned/coverage/trunk/.tox/py36/bin/coverage", line 11, in <module>
    load_entry_point('coverage', 'console_scripts', 'coverage')()
  File "/Users/ned/coverage/trunk/coverage/cmdline.py", line 827, in main
    status = CoverageScript().command_line(argv)
  File "/Users/ned/coverage/trunk/coverage/cmdline.py", line 597, in command_line
    **report_args
  File "/Users/ned/coverage/trunk/coverage/control.py", line 929, in html_report
    return reporter.report(morfs)
  File "/Users/ned/coverage/trunk/coverage/html.py", line 244, in report
    self.merge_single_folders()
  File "/Users/ned/coverage/trunk/coverage/html.py", line 430, in merge_single_folders
    self._merge_branch_folders(tree_info)
  File "/Users/ned/coverage/trunk/coverage/html.py", line 436, in _merge_branch_folders
    path, child_info = next(iitems(tree_info['children']))
TypeError: 'dict_items' object is not an iterator

I wanted to try running this code to see the report that was generated, but I also get this error.

Sorry about that - I was not being careful with my code tidying

Thanks for fixing the error.  I don't understand why the indentation is off though?  When I run this on coverage itself (with ARGS="-e py36" make clean metacov metahtml), I get:

Me neither.  I couldn't figure it out so I raised in issue upstream
https://github.com/kanety/jquery-simple-tree-table/issues/8

It seems neither of us have the energy to make this happen.  How about closing this PR?

Maybe someday...


Pitch data constructor

Closes #69

There is something horrible about MSVC 19.25.28614.0 and I don't have time to chase it down. It's possible that there's undefined behavior in the mx code, but the last time I chased a Windows crash I ended up here: https://developercommunity.visualstudio.com/content/problem/847490/msvc-codegen-error-vector-reverse-iterator-x64-c17.html
The fix for mx was basically 'move something around so the buggy compiler doesn't make bad code'
#61 had the fix and it was here: https://github.com/webern/mx/blob/20796cd4638b8beec6f7833c436a7e267a5699c1/Sourcecode/private/mx/core/ElementInterface.cpp#L142...L150


fix: removed cache manager, implement manual redis integration

Dependencies added
ioredis

DescriptionA robust, performance-focused and full-featured Redis client for Node.js.
AuthorZihua Li
LicenseMIT

Development dependencies added
@types/ioredis

DescriptionStub TypeScript definitions entry for ioredis, which provides its own types definitions
LicenseMIT


Cannot run validate or package on v3.2.0

When updating zendesk_apps_tools to v3.2.0 the follow error message is appearing when running either zat verify or zat package
Everything working fine when rolling back to zat 3.1.0 or lower
$ ruby -v
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin18]

/Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2/ipv4.rb:71:in `initialize': Invalid IP "2.59.287.094" (ArgumentError)
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `new'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `parse'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:55:in `blocked_ip_type'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:41:in `block in blocked_ips_validation'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:40:in `each'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:40:in `each_with_object'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:40:in `blocked_ips_validation'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:30:in `block in call'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:16:in `each'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/validations/requests.rb:16:in `call'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_support-4.21.0/lib/zendesk_apps_support/package.rb:40:in `validate'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_tools-3.2.0/lib/zendesk_apps_tools/command.rb:92:in `validate'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_tools-3.2.0/lib/zendesk_apps_tools/command.rb:121:in `package'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
        from /Users/myuser/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/zendesk_apps_tools-3.2.0/bin/zat:13:in `<top (required)>'
        from /Users/myuser/.rbenv/versions/2.3.0/bin/zat:23:in `load'
        from /Users/myuser/.rbenv/versions/2.3.0/bin/zat:23:in `<main>'

The same issue:
$ zat package
/Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2/ipv4.rb:71:in `initialize': Invalid IP "128.664.299.002" (ArgumentError)
        from /Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `new'
        from /Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `parse'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:55:in `blocked_ip_type'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:41:in `block in blocked_ips_validation'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `each'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `each_with_object'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `blocked_ips_validation'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:30:in `block in call'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:16:in `each'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:16:in `call'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/package.rb:40:in `validate'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/lib/zendesk_apps_tools/command.rb:92:in `validate'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/lib/zendesk_apps_tools/command.rb:121:in `package'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/bin/zat:13:in `<top (required)>'
        from /usr/local/bin/zat:22:in `load'
        from /usr/local/bin/zat:22:in `<main>'

$ ruby -v
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin18]


Fix links

Broken links in docs/HandlingTouches.md

By analyzing the blame information on this pull request, we identified @hramos and @mquandalle to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Check and see if this is already fixed in master. If it isn't, then please open a PR against master instead.


Hide slots that don't contain searched text - check for Slot#isActive

Hello,
I'm hiding slots that are included within a scrollbar or hidden in a different page.
It seems like the "hide slots that don't contain searched text" functionality ignores Slot#isActive.

It doesn't make sense to render the highlight for non-interactable slots.
(NeoForge 1.21 - EMI 1.1.10+1.21)

Peculiar oversight, resolved in 1.1.11


Windows Support

Hi,
Cool library. I would like to suggest windows support, that would be really helpful. So far, I'm just manually patching loader.dart with this:
if (Platform.isWindows) {
  Logger('membrane').info('Opening native library example.dll');
  return DynamicLibrary.open('example.dll');
}

Thanks.

I'm not sure how membrane automatically moves the shared libs to the root of the dart package, but it'd also be great to get the Windows DLLs moved.

And I just tried the example on windows 10 x64 and got errors like this
#[async_dart(namespace = "locations")]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `i64`,
found `i32`

The moving of the so/dylib/dll is usually done via something like xtask. Membrane doesn't automatically do the moving for you so you can choose how you want it done as part of your build process.
I don't have access to a Windows machine to develop on but if it mostly Just Works:tm: and needs the loader addition then I'm happy to accept that. Would you want to open a pull request?
So @jc324 is it working for you on Windows but not working at all for @LambdaMan2K? Is there a difference in OS versions or something?

well I just ried the example and  it wont compile do to wrong input somehow.  it seems strange if this runs for others :)

I'm running it on Windows 11, maybe that makes a difference, idk. In example/src/application.rs these two functions work:
#[async_dart(namespace = "accounts")]
pub fn contacts() -> impl Stream<Item = Result<data::Contact, data::Error>> {
  futures::stream::iter(vec![Ok(data::Contact::default())])
}

#[async_dart(namespace = "accounts")]
pub async fn contact(user_id: String) -> Result<data::Contact, data::Error> {
  Ok(data::Contact {
    id: user_id.parse().unwrap(),
    ..data::Contact::default()
  })
}

Most of the rest fail with the error mentioned by @LambdaMan2K.

#[async_dart(namespace = "locations")]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `i64`,
found `i32`

There also seems to be an error on the dart side when calling a rust function that accepts Vec<String> as an arg.

Yes, I got those errors too. But using the gnu tool chain worked fine for
me, at least for sending basic data over.
On Sat, 09 Apr 2022, 6:22 pm LambdaMan2K @.***> wrote:

And I just tried the example on windows 10 x64 and got errors like this
#[async_dart(namespace = "locations")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected i64,
found i32
—
Reply to this email directly, view it on GitHub
https://github.com/jerel/membrane/issues/8#issuecomment-1094078440, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUD5AA6BC56RAOZVAFIPN33VEGVGBANCNFSM5S654T3Q
.
You are receiving this because you authored the thread.Message ID:
@.***>