Plotting Coastlines with ortographic projection

Hello,
I was trying out this nice package and found an issue when trying to run the example on the repository landing page using a destination projection that does not represent the full earth (like the ortographic one for example).
Here is the code I used to run the example
using GeoMakie, Makie

lons = LinRange(-89.5, 89.5, 180)
lats = LinRange(-89.5, 89.5, 180)

field = [exp(cosd(l)) + 3(y/90) for l in lons, y in lats]

source = GeoMakie.LonLat()
# dest = GeoMakie.Proj4()
dest = GeoMakie.Projection("+proj=ortho")

xs, ys = GeoMakie.xygrid(lons, lats)
GeoMakie.Proj4.transform!(source, dest, vec(xs), vec(ys))

scene = Makie.surface(xs, ys; color = field, shading = false, show_axis = false, scale_plot = false)

GeoMakie.geoaxis!(scene, extrema(lons), extrema(lats); crs = (src = source, dest = dest,))

GeoMakie.coastlines!(scene; crs = (src = source, dest = dest,))

which throws an error transform error: tolerance condition error at the last line coming from the Proj4 dependency.
The problem is that the transform function from the proj library return an err code when a single point is provided to the function and this lies outside of the visible earth in the projection.
When multiple points are provided to the transform function instead, points that lie outside of the visible earth are simply transformed to Inf without throwing an error.
This error could then be solved either by changing the behavior of Proj4 (maybe with a flag or something to disregard error code -20 related to this transformation problem), or by passing the vector of coastlines point to the plot function as a full vector instead of doing it point-by-point.
I decided to open an Issue here because I thought the latter would be preferable if possible but being quite new to Julia and especially Makie I am not sure how much problematic following this approach could be.

This is something I figured would happen eventually :) - the solution on GeoMakie's end is to check the limits of the projection and filter the lines appropriately, but I am not sure exactly how that might be done.

So Makie always inherently plot vectors in a broadcast way?
I did try a simple workaround without really knowing anything about how Makie works and I can reliably generate the coastlines in the ortographic projection by calling lines with the pre-computed vector instead of coastlines.
import GeoMakie, Makie

lons = LinRange(-89.5, 89.5, 180)
lats = LinRange(-89.5, 89.5, 180)

field = [exp(cosd(l)) + 3(y/90) for l in lons, y in lats]

source = GeoMakie.LonLat()
dest = GeoMakie.Projection("+proj=ortho")

xs, ys = GeoMakie.xygrid(lons, lats)
GeoMakie.Proj4.transform!(source, dest, vec(xs), vec(ys))

scene = Makie.surface(xs, ys; color = field, shading = false, show_axis = false, scale_plot = false)

GeoMakie.geoaxis!(scene, extrema(lons), extrema(lats); crs = (src = source, dest = dest,))

proj_lines = GeoMakie.Proj4.transform(source,dest,hcat(first.(GeoMakie.COASTLINES_LINEVEC),last.(GeoMakie.COASTLINES_LINEVEC)))
xl,yl = proj_lines[:,1],proj_lines[:,2]

Makie.lines!(scene,xl,yl)

Isn't something similar feasible inside GeoMakie? This could be useful also for finding the points outside of the projections, as they would be all the rows equivalent to [Inf Inf]

Aha, good point!  The reason I was broadcasting was purely because of my use of Point2f0, which doesn't lend itself to being passed to C functions very well.  I can definitely decompose the vector, transform, and then reconstitute the vector of Point2f0 before plotting.
I can get to this tomorrow, will ping you when I make a PR.

Cool!
Thanks a lot
Don't worry if you can't make it tomorrow as Makie is more of a future project as I am trying to learn PlotlyJS decently first.
I stumbled upon this nice repo and noticed this while trying out some things I needed to handle with projections :)

#84 is still hitting this. Right now the projections are done differently, so this line in the top post is always the case:

points that lie outside of the visible earth are simply transformed to Inf without throwing an error.

I haven't checked yet if this workaround still works: https://github.com/JuliaPlots/GeoMakie.jl/issues/47#issuecomment-621288976

Should be solved now.


Youtube-dl bug

Trying to download an awesome video. Told me to report it here.
youtube-dl https://www.youtube.com/watch?v=fdOcOtPqcIs --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=fdOcOtPqcIs', '--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.05
[debug] Python version 2.7.9 - Linux-4.4.13-v7+-armv7l-with-debian-8.0
[debug] Proxy map: {}
[youtube] Setting language
[youtube] fdOcOtPqcIs: Downloading webpage
[youtube] fdOcOtPqcIs: Downloading video info webpage
[youtube] fdOcOtPqcIs: Extracting video information
[youtube] fdOcOtPqcIs: Encrypted signatures detected.
WARNING: unable to extract html5 player; please report this issue on http://yt-dl.org/bug
[youtube] {22} signature length 43.40, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflIB5TLK/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflIB5TLK/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 516, in extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 170, in extract
    return self._real_extract(url)
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 860, in _real_extract
    encrypted_sig, video_id, player_url, age_gate)
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 489, in _decrypt_signature
    u'Signature extraction failed: ' + tb, cause=e)
ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 479, in _decrypt_signature
    video_id, player_url, s
  File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 356, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflIB5TLK/base.js'; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

[debug] youtube-dl version 2014.08.05

As @Hrxn has correctly identified, your version of youtube-dl is ancient. See our FAQ on how to update.


Test docs deploy

Github Actions to publish documentation site to GitHub Pages.
The actions include:

generate client/java javadoc
generate openapi page
generate latest version spec definition to be put in static pages

Actions run:

https://github.com/pawel-big-lebowski/OpenLineage/actions/runs/10196995458
https://github.com/pawel-big-lebowski/OpenLineage/actions/runs/10196995471

https://pawel-big-lebowski.github.io/OpenLineage/apidocs/javadoc/io/openlineage/client/OpenLineageClient.html ->

https://pawel-big-lebowski.github.io/OpenLineage/apidocs/openapi/ ->


Can't currently rename all files in zip using addFiles

Hi again. I have a couple instances where I am creating an archive with multiple files that need to be renamed -- for instance, from a UUID to a user-friendly file name or vice versa. I'm not seeing any way to do that with addFiles(), and looping through an array of files to add each one individually with addFile() means that the information returned by progressMonitor only reflects the progress for each individual file, not the group of files as a whole. In the source for AbstractAddFileToZipTask.addFilesToZip(), I can see that the ZipParameters are changed every time a new file is added, so at least in theory, a new name could be set for each file before it is added.  But since that function takes a list of file objects, with no way to specify ZipParameters for each individual file, there's currently no way to make that happen.

There is a feature request open to rename files. I think that is what you are looking for. I haven't gotten around to implementing this feature yet because of lack of time, but hopefully I can get it done in the next few days. But it is good to have ready your use case, I can implement this feature to take in a list of entries to be changed, and not only just one entry.

Sorry for the delayed response. That's not quite what I was looking for.  I'm not looking to rename files in a zip after they have already been added. I'm looking to add them to the zip with new names. When adding a single file, I can use setFileNameInZip() on a zipParameters object that I pass in the arguments. (Note: I had to add a function to get the zipParameters from zipFile in order to make that happen.) There's currently no way to do that for multiple files.

Ok. I get your requirement. It will be slightly hard to come with a solution for this. Because that would mean taking in a Map or something equivalent with the mappings of the original file names and the file names to be changed to. I will spend some thoughts if a solution for this is possible, although at the moment, it seems difficult. I also have to consider how often such a feature will be used. A workaround would still be to rename the files in the zip after they have been added, although I agree that it takes some slight overhead of changing the zip file again, but as I said earlier, an easy solution to this, without drastically changing the api, seems a little difficult at the moment. If you have any ideas, I would be happy to hear them.

To be honest, this is really a unique request to be able to rename files when being added to a zip or when creating a zip file. The parameter fileNameInZip of ZipParameters is supposed to be used when working with streams. (Ideally, there should have been different objects for streams and ZipFile api, but for historical reasons they are the same).  This can also come in handy when adding a single file. But it is not meant to be used for multiple files.
You can achieve that by renaming the entries after they have been added. I have implemented the feature request #72 , by which it will now be able to rename entries in a zip, and you can also rename multiple files at once. Please note that the feature is not yet released, but I plan to release it in a few hours from now.
I will close this issue for the reasons mentioned above.

Renaming files after they are added will not work when files with the same name from different source folders are involved -- a scenario I deal with often.


Enable diagonal scroll on the session list without using custom layoutmanager

Issue

Not exact one, but related with https://github.com/DroidKaigi/conference-app-2017/issues/72

Overview (Required)

Enable diagonal scroll on the session list to use motion event dispatch/simulate process.

Known issue

You couldn't see any effects when pressed a session long

Links

None

Screenshot

:eyes:

Cool :cool:


Missing relationship information for Website Review activity in Task 3

To complete the website review activity, we need to create a relationship to another table.  The task is missing to what table you expect us to create a relationship to AND what fields to use.
The activity cannot be saved without this relationship.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4da05ce6-4723-2ebc-8019-295d7b43f510
Version Independent ID: 4da05ce6-4723-2ebc-8019-295d7b43f510
Content: Customer lifetime value (CLV) prediction sample guide - Dynamics 365 Customer Insights
Content Source: ci-docs/sample-guide-predict-clv.md
Service: customer-insights
GitHub Login: @yashlundia
Microsoft Alias: yalundia

Thanks for your comment, @semberley. This issue has been assigned to the doc author for review.

Hello @semberley . Thanks for your feedback! I'm contacting the product team to provide additional information to add to the documentation. I'll let you know when I have a timeframe on when the update will be published.  Thanks.

Hello @semberley. We will have the doc updated by the end of the month. Thanks again for your feedback.

Doc was updated: https://learn.microsoft.com/en-us/dynamics365/customer-insights/data/sample-guide-predict-clv

Thanks for your comment, @semberley. This issue has been assigned to the doc author for review.

Closing this as completed.


chore: add normalizeOptions

add normalizeOptions，Easy to expand options later

Sounds interesting, thanks for the addition!


Make this an entire wrapper for tkinter

tkinter has so many weird parts that are obviously just because the library is a very thin wrapper over Tcl/Tk.
Here are my issues with the library:

sometimes ids are strings, sometimes they are numbers, other times you just pass around the whole widget. It is annoying
typing is wack for pretty much everything so I would like to have type definitions for everything

There are a bunch of constants that tk supplies globally because for some reason tcl/tk uses strings for things that should be something like enums

document what things do!! the documentation is pretty rough around this library :(
add wrappers for components/functionality that are just plain strange to use

I started this already with the Scrollable class I made wrapping mouse scroll events

add better typing for binding event handlers including the type signature of the handler itself!!
I would be the styling API is rough but I haven't really used it much so idk

Also tkinter uses A LOT of non-inclusive language that feels a bit yucky


Deleting a feed causes the article list to be cleared until refresh.

Describe the bug
Deleting a feed causes the article list to be cleared until refreshes.
To Reproduce
Steps to reproduce the behavior:

Add two or more feeds.
Go to the feed view.
Delete one of the feeds.
Go to article view.
See that there are no articles.
Articles will come back after a refresh.

Expected behavior
After deleting a feed, only articles from that feed should disappear.

I think I know how to fix it. I will do so soon.


Manual color input

Being able to manual type in the color no longer works.

Thank you for reporting this should be fixed once the deployment is done 👍:)


Fixes to outdated language

Resolves #34 and does some other things

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

81 of 171 (47.37%)  changed or added relevant lines in 4 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.8%) to 43.713%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/mfccs.jl
26
40
65.0%

src/io.jl
3
19
15.79%

src/rasta.jl
38
64
59.38%

src/feacalc.jl
14
48
29.17%

Files with Coverage Reduction
New Missed Lines
%

src/mfccs.jl
1
59.5%

src/rasta.jl
2
47.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
219

Relevant Lines:
501

💛  - Coveralls

Thanks!


Failed To Start -- No such file or directory

This docker will not start for me. However, if I use

militellovinx/mssql-server-linux:latest

then it will run. Not sure why. I would prefer to use the latest release from MS.
Command

root@localhost:#
/usr/local/emhttp/plugins/dynamix.docker.manager/scripts/docker run -d --name="KE-MSSQL" --net="bridge" -e TZ="America/New_York" -e HOST_OS="unRAID" -e "ACCEPT_EULA"="Y" -e "SA_PASSWORD"="password" -p 1433:1433/tcp -v "/var/dockers/ke/sql/":"/var/opt/mssql":rw -m 4GB microsoft/mssql-server-linux:latest
8619b44395377d22250742557e1f586ec4e2cbab6de91f716d7c194f96b53738
The command finished successfully!

Log
Configuring Microsoft(R) SQL Server(R)...
sqlservr: vm.cpp:38: BOOLEAN IsPossiblyValidPalAddress(const void *): Assertion `result' failed.
cat: /proc/22/sched: No such file or directory
No journal files were found.
No journal files were found.
ls: cannot access '/var/opt/mssql/log/errorlog*': No such file or directory
ls: cannot access '/var/opt/mssql/log/exception.log': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.txt': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.mdmp': No such file or directory
ls: cannot access '/var/opt/mssql/log/system_health*': No such file or directory
Configuration complete.
paltelemetry: Loading the directory /var/opt/mssql/.system/.system/telemetry failed. Errno [2]
This is an evaluation version. There are [174] days left in the evaluation period.
sqlservr: vm.cpp:38: BOOLEAN IsPossiblyValidPalAddress(const void *): Assertion `result' failed.
Capturing core dump and information for sqlservr (pid 151)...
cat: /proc/151/sched: No such file or directory
No journal files were found.
No journal files were found.
SQL Log Directory /var/opt/mssql/log
ls: cannot access '/var/opt/mssql/log/errorlog*': No such file or directory
ls: cannot access '/var/opt/mssql/log/exception.log': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.txt': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.mdmp': No such file or directory
ls: cannot access '/var/opt/mssql/log/system_health*': No such file or directory
Packaging core dump and information into compressed files.
Core dump and information will be written to /var/opt/mssql/log/core.sqlservr.01_24_2017_23_34_22.151 and logs in /var/opt/mssql/log/core.sqlservr.01_24_2017_23_34_22.151.log

What OS distro, version, and file system do you have on the host?

UnRaid 6.0, XFS
Sent from my iPhone

On Jan 25, 2017, at 2:01 AM, Travis Wright<EMAIL_ADDRESS>wrote:
What OS distro, version, and file system do you have on the host?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

We think this is the assert that happens when the container starts up and has less than the required 4 GB of RAM.  It looks like you are trying to limit the container to -m 4GB, but does Docker Engine itself have at least 4 GB of available capacity for hosting containers?  We see this kind of thing quite often when people are using Docker for Mac or Docker for Windows which default to Docker Engine only have 2 GB by default.

The server has 24 GB of RAM, 16 GB available for use. Its weird. The other docker image, referenced above, works (except volume mapping). I think its based off your older image. Thanks for your assistance. Im trying to test the potential of moving away from MySql and start using MSSQL and NET Core. Any help and or direction with this SQL matter is greatly appreciated.

Can you please try without the -m 4GB and without the volume mapping?

Command

root@localhost:# /usr/local/emhttp/plugins/dynamix.docker.manager/scripts/docker run -d --name="KE-MSSQL" --net="bridge" -e TZ="America/New_York" -e HOST_OS="unRAID" -e "ACCEPT_EULA"="Y" -e "SA_PASSWORD"="password" microsoft/mssql-server-linux:latest
191c66324a91a13bfa06957bd8596c5a85db6fbd2554614a36f3842f416d773c
The command finished successfully!

Log
Configuring Microsoft(R) SQL Server(R)...
sqlservr: vm.cpp:38: BOOLEAN IsPossiblyValidPalAddress(const void *): Assertion `result' failed.
cat: /proc/21/sched: No such file or directory
No journal files were found.
No journal files were found.
ls: cannot access '/var/opt/mssql/log/errorlog*': No such file or directory
ls: cannot access '/var/opt/mssql/log/exception.log': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.txt': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.mdmp': No such file or directory
ls: cannot access '/var/opt/mssql/log/system_health*': No such file or directory
Configuration complete.
paltelemetry: Loading the directory /var/opt/mssql/.system/.system/telemetry failed. Errno [2]
This is an evaluation version. There are [173] days left in the evaluation period.
sqlservr: vm.cpp:38: BOOLEAN IsPossiblyValidPalAddress(const void *): Assertion `result' failed.
Capturing core dump and information for sqlservr (pid 150)...
cat: /proc/150/sched: No such file or directory
No journal files were found.
No journal files were found.
SQL Log Directory /var/opt/mssql/log
ls: cannot access '/var/opt/mssql/log/errorlog*': No such file or directory
ls: cannot access '/var/opt/mssql/log/exception.log': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.txt': No such file or directory
ls: cannot access '/var/opt/mssql/log/SQLDu*.mdmp': No such file or directory
ls: cannot access '/var/opt/mssql/log/system_health*': No such file or directory
Packaging core dump and information into compressed files.
Core dump and information will be written to /var/opt/mssql/log/core.sqlservr.01_25_2017_21_30_57.150 and logs in /var/opt/mssql/log/core.sqlservr.01_25_2017_21_30_57.150.log

OK, thanks.  Same result.  We made some changes in between 1.1 and 1.2 in how we manage memory so there could be an undiscovered bug here.  Could we trouble you to upload the dump so we can take a look at it?  If so, please contact me via email at twright a t  microsoft and I'll provide you the instructions on how to upload to our secure upload store.

Will do thanks.

Exactly same issue here. I'm using Unraid 6.3.2
Attached the logs : https://drive.google.com/open?id=0B2l7au-TREeXYzJYVjJxVURldFk

@hcgonzalezpr -- I created an lean Ubuntu VM in UnRaid with docker installed and it ran fine. Currently that is how I am operating with this docker image to date.

Thanks I'll got that route for now. Sadly this defeats the purpose of using docker to stay away from spinning up a whole a VM.

Any chance for a fix to this, I would really like to use this docker on my unraid system directly.

Hello all,
I have same issue, it is possible to be related with the filesystem of our storage? in my case I have GlusterFS running on XFS, but if I run in a EXT4 filesystem the container works properly.
I see something similar here #126

@twright-msft -- Its been a couple years and I wanted to circle back and see if running mssql in a docker on Unraid has been updated? Thanks in advance.

@ckiszka I came across a solution a few days ago from another user, I'm up and running in unraid now.
Try adding the parameters  -m 8g --ulimit stack=8192000:8192000  (based on 8GB allocation)
Reasons explained in detail here: https://support.microsoft.com/hr-ba/help/4134638/sql-server-2017-terminates-and-generates-a-core-dump-on-rhel-7-4-when

@tjb-altf4 -- Great find. I read the post.
I think the minimum memory requirement for Linux based Sql is 3GB. I am going to try your discovered solution with that to see if it solves the persistent storage blocker for me in unraid.
Again, great find man! Thanks!

Just tested @tjb-altf4 solution in my docker compose file with 3GB. All works.


Dowloading all attachments at once fails

Clicking an individual attachement downloads it using the default browser.
Clicking the link to download all attachments at once in a zip file does nothing (nothing happens).
See attached screenshot and screen recording.

https://user-images.githubusercontent.com/559346/104807669-e0c17e00-57e0-11eb-82c1-9cde5f495f65.mov

Thanks for reporting! I’ll try take a look at this within the week.

Thanks for reporting! I’ll try take a look at this within the week.

Fixed in 1.6.3, thanks again for reporting!

Fixed in 1.6.3, thanks again for reporting!

I've tested it with the earlier message and can confirm that it's working now. Thanks.

I've tested it with the earlier message and can confirm that it's working now. Thanks.


Controller refactoring

The problem the component solves
Currently, most of the mailbagit functionality is run step-by-step in the main controller, controller.py. This works fine, but there might be a more optimized way to structure some of this code.
Relevant part of mailbag spec?
n/a
Type of component

[x] Core
[ ] Input
[ ] Attachments
[ ] Derivatives conversion
[ ] Reporting/Exporting
[ ] GUI
[ ] Distribution

Expected contribution

[x] Pull Request
[x] Comment with proposed solution

Major challenges or things to keep in mind

Disambiguation between accounts and messages is needed. This will this clean up duplicate logic that could be moved to the controller.
I believe that this is also blocking us from addressing #151, as mail.attachments objects  can also return message objects. If much of the outside-of-message logic can be removed from .messages() then that method could potentially be called to parse message objects in mail.attachments.

attached_msg-151 makes a poor attempt at this.


Error in console

Description
The dimensions that are mentioned in the manifest.json for the icons don't seem to be the same as the actual size for both the logo192.png and logo512.png.
Screenshots

Additional information
It's a beginner-friendly issue to solve and if you are having experience in this project kindly leave it for other newcomers. If anyone is not able to solve it feel free to ask me on the discord server or tag me here, I will help you out.

@krishguptadev leave it for beginners 😆

I would like to work this issue @Guneetsinghtuli

sure @krishguptadev


Add FdtWriter::property_cstring

Summary of the PR
Since FdtWriter only accept &str, it does a validation to make sure it's NULL-terminated and copies the whole string in Cstring::new().
This is unnecessary in some circumstances. For example, for "bootargs" property, linux_loader can create CString [1]. However, library users need to convert it into String [2].
This patches adds another property helper property_cstring, which accepts a CStr value directly to eliminate the overhead.
[1] https://docs.rs/linux-loader/latest/linux_loader/cmdline/struct.Cmdline.html#method.as_cstring
[2] https://github.com/firecracker-microvm/firecracker/blob/3853362520b81efc8ce6559148d023379a5a4da4/src/vmm/src/arch/aarch64/fdt.rs#L240-L246
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[x] All commits in this PR have Signed-Off-By trailers (with
git commit -s), and the commit message has max 60 characters for the
summary and max 75 characters for each description line.
[ ] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

All added/changed functionality has a corresponding unit/integration test.

I've skipped adding tests because the new method is covered through property_string(&mut self, &str), but lmk if we should add another one 😃

@danielverkamp Good point I was wondering that too. The problem is convenient traits such as TryInto for &CStr/&str conversion are not implemented in the standard library.
BTW, the review requires at least 2 approvers. Whom should I ask for another review? 🙏

BTW, the review requires at least 2 approvers. Whom should I ask for another review? 🙏

Sorry, I missed this notification - I think it needs someone from https://github.com/rust-vmm/community/blob/main/MAINTAINERS.md#gatekeepers (I haven't been involved much lately, but it seems like there is supposed to be some automation for this, possibly not enabled for this repo though?)

Thank you for pointing it out! I'll ask for another review in a community channel.


nested fragment call a new fragment!

hi... I'm using this sliding tab... and i have separated fragment in every tab! this sliding tab in within a frame container in main activity!
now i want to replace new fragment from one child (tab) of this fragment! and set it to frame container! how can I do this?
thanks...

This sample has been deprecated/archived (check README for more information on newer samples related to this technology).
As recommended by GitHub, we are closing all issues and pull requests.


[Bug]: AttributeError: 'TimmImage' object has no attribute 'input_schema'

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
There was an error building the image using the triton script

Successfully clone the repo: image-embedding/timm.
Traceback (most recent call last):
File "/usr/local/bin/triton_builder", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/builder.py", line 208, in main
if not Builder(dag, model_root).build():
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/builder.py", line 194, in build
if not self.load():
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/builder.py", line 179, in load
config = self._create_node_config(node_id, node)
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/builder.py", line 149, in _create_node_config
return self._pyop_config(op, node_id, node)
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/builder.py", line 117, in _pyop_config
converter = PyOpToTriton(op, self._model_root, model_name,
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/to_triton_models.py", line 146, in init
super().init(op, model_root, model_name, op_config)
File "/usr/local/lib/python3.8/dist-packages/towhee/serve/triton/to_triton_models.py", line 91, in init
self._inputs = TritonModelConfigBuilder.get_input_schema(self._obj.input_schema())
AttributeError: 'TimmImage' object has no attribute 'input_schema'
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Towhee version(e.g. v0.1.3 or 8b23a93): 0.9.0
- OS(Ubuntu or CentOS):Ubuntu
- CPU/Memory:
- GPU:
- Others:

Anything else?
No response

@lvmnn Are you running image_embedding.timm operator with triton? Can you show the code?

@lvmnn Are you running image_embedding.timm operator with triton? Can you show the code?

I did it according to this. serve/triton/readme.md

@lvmnn Can you share exact code & towhee version?

I think the issue is that the latest timm operator does not work according to serve/triton/readme.md, we will update the documentation for the latest dc2, please stay tuned with 0.9.1.

I think the issue is that the latest timm operator does not work according to serve/triton/readme.md, we will update the documentation for the latest dc2, please stay tuned with 0.9.1.

ok, Are there any examples or other documentation available about triton?


Problems with destroy ergonomics when using it from Drop

Currently, when destroying any backend structure explicitly, such as a buffer, you need to pass it by value.
device.destroy_buffer(vertex_buffer);

These semantics make sense in principle, but in practice it makes it hard to write simple wrappers that RAII wrap around these types.
impl Drop for Mesh {
    fn drop(&self) {
        let device = &self.common.device;
        unsafe { device.destroy_buffer(self.vertex_buffer); } // < can't move out of reference error
    }
}

A solution is to wrap all these types in Option, but this quickly becomes very cumbersome just for this one specific use. Since these functions are already unsafe, why not just allow them to take &mut?

I use ManualDrop wrapper

How can ManuallyDrop be used to solve this problem?

These semantics make sense in principle, but in practice it makes it hard to write simple wrappers that RAII wrap around these types.

I have many thoughts on the issue, but no solution:

Did you consider not using RAII for graphics stuff?
I'd really like to see drop accepting things by value. This has been my pet peeve with Rust since the beginning. I don't care how special should the compiler glue be, moving out of life just makes so much more sense as borrowing.
https://github.com/gfx-rs/wgpu will have droppable objects, but it's a slightly higher level API.

The more specific use case I'm running into is, for example, putting a rendering System in a specs World. The rendering system itself owns some graphics resources, but there's no way to entirely get back ownership to the system, or even access it again.
There may be some better ways to solve this issue, perhaps this is enough of a common use case that it would make sense to have an example on it to both inform gfx and specs' design?

Personally, I really enjoy working at a low level like gfx-hal provides, while still having the benefits of easier cross-platform-native porting. This specific API issue is the main one I ran into when using gfx-hal in this way. Is there any problem with changing the API to use &mut instead? To compare it to other libraries, when working with Ash you would pass a Copy handle to the destroy method, and as a result it doesn't have this issue.

@LaylConway @omni-viral please have a look at #2457 RFC

This question also came up on Stack Overflow. One answer there shows usage of Option as well as ManuallyDrop.


feat: remove the need for forRoot on material NgModules

Dialog and snackbar use their parent's state if there is one
Other service that we want to be singletons and have state use a useFactory provider to get the ancestor and provide that if it exists

cc @IgorMinar can you provide thoughts on this?
cc FYI @josephperrott @mmalerba @andrewseguin @tinayuangao

Seeing some failures w/ AoT that don't quite make sense to me. Consulting w/ core team.

Also cc FYI @DevVersion @crisbeto @EladBezalel

@jelbourn looks reasonable. please file an issue @ angular/angular if you haven't yet. Let's see if the core can help with this pattern as it looks better to me from the user perspective than the forRoot pattern.

@jelbourn Were the errors on the AOT mode valid? - Also nice change. Should avoid future provider issues as in #2538

@DevVersion yes, it caught some real errors


[JS][11.QnAMaker] Update for 4.3.4

Proposed Changes
Updates JS QnAMaker Sample to 4.3.4.
Testing

No errors:

@mdrichardson - couple of conflicts that need to be resolved in .env and readme.

@Kaiqb Fixed.

@stevengum Implemented your requests.


Lags when scrolling on a page with TOC and a large number of headings

Hi! We use Doxygen Awesome on the userver documentation site. Unfortunately, on pages with a large number of headings, there is a slowdown when scrolling down the page. Similar behavior can be seen on this page.
The slowdown is due to the updating of classes at the TOC headers, I tried to show this in the video. It would be cool to fix this loss of performance.
https://github.com/jothepro/doxygen-awesome-css/assets/29949782/a7817de5-500b-4ce8-a7fc-42f2cb9c6fcb

The update() function in doxygen-awesome-interactive-toc.js is being called on every scroll event. This results in a significant performance delay. We can batch the class change events after exiting the loop if that works, or maybe call the update() function in a scheduled manner (every 50ms or so). I have a potential solution but unsure how to test it. Can I create a pull request for your review?

@iamAyushChamoli Yes, I can review and test changes. It will be very cool!

I'd really appreciate if you open a pull request with a suggestion on how to fix this, @iamAyushChamoli. :)

Hi, @jothepro & @atlz253, created a pull request for the same. Introduced throttling of the update() function to enhance UX by reducing function calls. This is my first pull request so let me know if I accidentally messed something up.

@iamAyushChamoli upload before/after comparison. It became much smoother! Congratulations on your first contribution!
One moment. This line is missing the keyword "this". It should be like: document.getElementById("doc-content")?.addEventListener("scroll", this.throttle(DoxygenAwesomeInteractiveToc.update, 100)). Otherwise, the fix does not work :(
https://github.com/jothepro/doxygen-awesome-css/assets/29949782/00e9790f-3f8a-4222-99e2-4982b0d7ae88

@jothepro I have updated the code and included "this" keyword as you suggested, please review the code and let me know if it works well now!
btw Thanks! this is quite pleasant to have my first pull request accepted :D


Sandbox system bug

Hi, first tks for the module! I use it a lot!
Just one issue, clicking on a imagem on chat created by chat image module do not open a preview if using sandbox system.
May you take a look if you can?
tks!

I can't do much about this. The sandbox system messes with how the messages are rendered.

I will give it a shot after I finished the 3.0 version


Implement code action provider

This issue will be blocked while there's no public access to the fixer api for ruff, so for now is used as a placeholder for when it becomes possible.

@Seamooo - What can I do to enable this?

@charliermarsh Ideally the public API "check" would expose the Checks rather than the messages such that the optional "Fix" type is available. Fix has exactly the information required to facilitate the request behaviour


Implement '--watch' for tsc.exe

error TS5001: The current host does not support the '--watch' option.
I got the really cool watch option working using the typescript spirce cde. but wouldn it be cool to have it working with tsc?

So watch does not work on windows?

for making it work on .win too.

Just to be clear, --watch does work on Windows if you're using node.js/io.js, but the tsc.exe program distributed with VS does not support it; you still have Compile on Save for similar functionality anyhow.

As Daniel says, and as I wrote: "The current host" does not support the watch. I use node now as a host and come along well. So for me this is not an issue anymore and I think others will be fine as well with node as a host.

I realy do not get what means - "node as a host"

javascript code needs some program that executes it. That is either a browser or node.js or something else, like tsc.exe.
The typescript compiler is tsc.js and you can use it for instance by running
tsc.exe
node tsc.js

First time, tsc.exe is a javascript runner, or in other words a "host" for tsc.js . In the second line, node.js is the runner, or "host". Besides executing the js code, the host provides some services like file-watching to the js code. And here is the missing piece: tsc.exe does not implement file watching, while node.js does. So using
node tsc.js -w  mycode.ts

you get file watching while
tsc.exe -w  mycode.ts

will throw
error TS5001: The current host does not support the '--watch' option.

I'm not sure why this was closed.  Supporting --watch for our tsc.exe host would both be possible and desirable.  Right now the limiting factor is that our tsc.exe host is a bit of ugly C++, that uses some ancient COM interfaces for Chakra that we haven't spent much effort on.  Our options are:

Implement --watch functionality in that C++ code.  Given an appropriate C++ file watcher, this shouldn't be too difficult.
Move to a managed code host and use the rich .Net functionality here.  This would be a lot of work, but it would be nice to have a cleaner and more welcoming host for people to work in.
Move to a more modern, native, Chakra host API (i.e. jsrt, and then expose file watching through that as well.

i closed it, because i opened it and found a workaround.
but appreciate your efforts for a watching tsc.exe.

So workaround for winodws is to search tsc.js and make cmd file to start it with node. :)

jsrt is only available on Windows 10 right? So that might not be the best solutions right?
Or is It that on Windows 8 the current tsc.exe would be used and for Windows 10 a new one? BTW I know this (probably) isn't happening anytime soon :)

So workaround for winodws is to search tsc.js and make cmd file to start it with node. :)

No, if you're going to use node, we'd recommend you install TypeScript via npm and make sure that node's tsc comes before Visual Studio's tsc in your PATH.

@DanielRosenwasser : right, this is clean and portable
@gintsgints; yes, this is what I ended up with. since I have several tsc verisons, i brutally hard coded the path getting this ts.cmd:
rem usage: ts app
node X:\typescript\bin\tsc.js -w --sourcemap %1.ts --out js%1.js

@urbanhop hope you won't mind, I modified your script to be in a code block so it's a little more readable.

thx!

one more funny way to start tsc would be npm run.

put tsc script run into npm config like this:

  "scripts": {
    "tsc": "tsc -w"
  },

Then execute your tsc by issuing:
npm run tsc

Please add to the "tsc --watch" doc that it is not supported on straight windows hosts but works on node on windows. That would save everyone's time.
Thanks

Would it be possible to get a cmd file that watches the .ts files and recompiles them?
Thanks

@fjanon not really, we'd be better off adapting the host to take on this functionality.

How about this approach around this line:
https://github.com/Microsoft/TypeScript/blob/master/src/compiler/sys.ts#L324
        declare hostSystemSupport: ts.System;

        if (typeof hostSystemSupport !== 'undefined') {
          return hostSystemSupport;
        }
        else if (typeof WScript !== "undefined" && typeof ActiveXObject === "function") {
            return getWScriptSystem();
        }
        else if (typeof module !== "undefined" && module.exports) {
            return getNodeSystem();
        }
        else {
            return undefined; // Unsupported host
        }

So rather than faking WSH or node (both rich and complex apis), your Chakra host will implement exactly what tsc needs in the first place.
And as a side effect it will open the door for easy hosting of tsc in other weird and wonderful scenarios.

Correct me if I'm wrong but if I create a new .ts file into the folder been watched by the --watch option of the tsc compiler, I need to execute again the tsc --watch command in the bash or terminal? It is this behavior by design? This occurs on Mac and also on Windows.
Will be possible to add into the --watch options the functionality to not be necessary to re execute the command each time a new file is added to the project (or folder)?

currently the compiler only adds watches to files. the problem is node does not provide a native directory watcher capabilities. we would have to either do it based on file watchers, which would not scale, or include a timestamp based implementation. we are open to suggestions here if any one has better ideas on how to get this to work.
I do not think this is related to this issue. this issue is to enable --watch for tsc.exe. we should file a different issue for the directory watcher in --w.

I agree with you @mhegazy, that was my impression when I start writing the comment. I will continue the discussion in other issue. Thanks for the feedback and the information about Node.js.

This has been implemented, I think this issue can be closed?

This has been implemented, I think this issue can be closed?

no. this has not been implemented.

This is the solution which works for me. see

I'm looking for a way to build ts into javascript files not run them. Those are two completely different things. So I don't need node. I need tsc.exe.  If tsc.exe does not support --watch, then why does Visual Studio Code have that as an out-of-the-box build task to do that? Nothing in this entire post makes any sense at all. I just want my ts project to build when I save something in VS code.
Any help would be appreciated. I've been a developer for 14 years on the .Net stack, but working in the JavaScript/NPM world everything is like pulling teeth! Sorry, just really frustrated. I should be off the ground by now. I already know TS and I've been writing javascript for more than a decade. It's the tooling that is terrible.  I just can't get VS Code to work right. I think I might just go back to Visual Studio where things actually work. I just feel like you all make things way harder than they need to be just so you can feel like hackers.

Sorry again. I think I'll just get by manually building after every single save like it's the 1990's.

Can someone explain to me if tsc.exe does not support --watch. Why does Visual Studio Code have a tsc --watch -p build task? Also, tsc doesn't run code. I have no idea what you guys are talking about there. It compiles typescript into javascript. Personally, I'm writing typescript to run in the browser.  I don't need node. I just want VS Code to build javascript from my tsconfig.json when I save a typescript file. I'm new to VS Code, but this is a really simple thing for a program to solve. Building it manually works just fine.
Sorry, but I'm really frustrated and finding this command line stuff to be a bit unnecessary.

Since tsc.exe is being discontinued (new versions of Visual Studio and NuGet will be shipping with tsc.js and expect Node to be installed), I think it's appropriate to close this issue. Users will now be able to install Node and get the expected --watch functionality.


bind-* on ICollection not working for HashSet or List

We are working on an input element that binds to an ICollection.  Its works fine when we bind an actual ICollection variable to it. But not when the bouded variable is a HashSet or a List.
We are using the binding with the EventcallBack.
[Parameter] public ICollection<string> TagList { get; set; }
[Parameter] public EventCallback<ICollection<string>> TagListChanged { get; set; }

and we call it like this
<TagEditor @bind-TagList="Model.ICollectionList" /> // Working
<TagEditor @bind-TagList="Model.HashSet" /> // Not Working

Describe the bug
The compiler throwes the following error

Fehler CS1503 Argument "2": Konvertierung von "Microsoft.AspNetCore.Components.EventCallback<System.Collections.Generic.HashSet>" in "Microsoft.AspNetCore.Components.EventCallback" nicht möglich.

Thanks for contacting us, @oiBio .
@pranavkm can you please look into this? Thanks!


Known Issue: Partially completed commit can leave unused Node(s) behind

Discussed in https://github.com/SharedCode/sop/discussions/8

Originally posted by grecinto January 21, 2024
During application crash and SOP transaction(s) are in the middle of "commit", temporary Node(s) used by these transaction(s) can be left orphaned. These Nodes' references are recorded in the registry as "inactive" ID(s). They can be cleaned up by SOP on succeeding transaction(s) involving their "active" Node(s).
BUT in order not to impact I/O or performance of the system, they were decided to be left as such. It is anticipated that occurrence of this kind of partially completed transactions will be very scarce to zero, thus, it will not impact storage efficiency in time. The other approach known, is to issue a "delete" on these Node(s) part of future transactions, thus, doing an auto-cleanup. However, these are expensive operations and potentially be doing nothing, as most leftover unused Node(s) will be serviced by the "Delete Service" or the SOP commit's cleanup phase. (see here where the auto-cleanup for this use-case was being done, was commented out: https://github.com/SharedCode/sop/blob/c6d8a1716b1ab7550df7e1d57503fdb7e041f00f/in_red_ck/node_repository.go#L288)
If in case your setup produces many occurrences of this kind of transactions, pls. feel free to report it(together with repro steps, as usual).
Or, if you have a suggestion how to better handle this scenario, and how to introduce a cleanup task for such kind of Node(s), pls. do suggest for discussion.
Thanks & kind regards,

SOP maintainer

Being addressed in "value data segment" branch.

Fixed in latest checkin in master branch.


Add WorkflowJob to GitHubEventScaleUpTriggerSpec types

Currently, HorizontalRunnerAutoscalerSpec allows you to scale up in response to GitHub events, but only specificies CheckRun, PullRequest, and Push in the types—not WorkflowJob, which is surprising because it's mentioned in the README as "the preferred way of autoscaling".†
I hope this helps and that I've added the type correctly! (This is my first code contribution to the repo.)
†: (In practice, people may be using githubEvent: {} and (presumably?) just configuring their github repo settings to only send workflow_job events. Example)

Hi
Was going to raise a similar PR. One thing that would be handy to add is to use the workflow_job.runner_group_name github event.
Our scenario at the moment is we have 1:1 app/aws account/eks cluster so if we use unique labels (app1-dev-build) with our runner groups this is well targeted, but there is a chance that a dev by mistake could start a workflow and choose runs-on and a label outside of their application, and then we would have pods scaling on accounts/clusters not associated with the application. In this scenario, the workflow would fail as the repo would more than likely not be part of the repo list associated with the runner group but this would still trigger the workflow autoscaling trigger (havent tested).
Another benefit is we could have the label be pretty generic such as build/deploy and have the added event to match the runner_group_name so that the apps are scaling pods up into the correct accounts/clusters.
E.g.
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: build-autoscaler
spec:
  scaleTargetRef:
    name: build
  minReplicas: 0
  maxReplicas: 12
  scaleUpTriggers:
  - githubEvent:
      workflowJob:
        runner_group_name: app1
    duration: "5m"

@brunnes Hey! Thanks for chiming in. I think I almost understand what you say, but still have one question- How does runner groups resolve that situation?
Do runner groups isolate runners in a way so that duplicate runner labels "across" runner groups are fine? (Just asking, because I had been blindly thinking that you need unique runner labels across runner groups. But I may have been completely missed the truth

Hey @mumoshu  thanks for getting back to me so quick.
So we are specifying repos and assigning to runner groups.
Runner Groups:
  Name: Team1
  Repos:
    - team1-app1
    - team1-app2
  Name: Team2
  Repos:
    - team2-app1
    - team2-app2

At the moment if you wanted to run a runner in the Team1 Account/cluster then you would in the workflow
runs-on: ['self-hosted', 'team1-build']

and we have the runner deployments with
group: Team1
      labels:
        - self-hosted
        - team1-build

And that all works fine, but we were thinking a scenario might happen that someone might accidentally from a Team2 repo run a workflow and have runs-on: team1-build. The expected behavior is that the workflow would fail as the repo/runner group doesn't match, but I believe that it would still fire the webhook workflow_job event and expose the label, and then scale the team1-build pod.
To add to that, we were thinking (but havent tested) if we can make the autoscaler github event match to a runner group name, then a user could run-on: 'build' and use that same label for all repos and it would know which account/cluster to run a runner.

And that all works fine, but we were thinking a scenario might happen that someone might accidentally from a Team2 repo run a workflow and have runs-on: team1-build. The expected behavior is that the workflow would fail as the repo/runner group doesn't match, but I believe that it would still fire the webhook workflow_job event and expose the label, and then scale the team1-build pod.

I believe the runner group information isn't included in the workflow_job event at the point of it being in a queued status, the event will look something like this:
{
  "action": "queued",
  "workflow_job": {
...
    "status": "queued",
    "conclusion": null,
    "started_at": "2021-11-15T13:14:32Z",
    "completed_at": null,
    "name": "my-job-name",
    "steps": [

    ],
...
    "labels": [
      "ubuntu-latest"
    ],
    "runner_id": null,
    "runner_name": null,
    "runner_group_id": null,
    "runner_group_name": null
  },
...

The runner_group_id and runner_group_name will only be populated once the job has been allocated to a runner. How do you envision resolving the runner group?

@toast-gear Ah I see. Well what I was thinking won't work then. Will just have to have unique/targeted labels, which is fine.

@brunnes As a workaround, although I really wish GitHub had included the repository runner groups in the event whilst queued so we could actually scale stuff correctly without a load of faff 😞, you could:

install an instance of actions-runner-controller per runner group
expose each install with a unique endpoint
create a unique GitHub App per runner group and point the webhook in the app to the corresponding endpoint

Until GitHub provide proper support for runner groups in workflow_jobs events this would probably work.

@toast-gear Yeah agree it would be good if runner_group event was there in the queue status.
The workaround looks worth a try though, thanks for that.

the runner group information isn't included in the workflow_job event at the point of it being in a queued status (it would be great if it was 😞)

@toast-gear The reason GitHub can't include runner/group data for queued events is by definition: queued means "not yet assigned to a runner". We literally don't know yet which runner will pick up the job.

I really wish GitHub had included the repository runner groups in the event whilst queued so we could actually scale stuff correctly without a load of faff 😞

@toast-gear  Ah, I just re-read this earlier comment. So you're saying that, within each workflow_job.queued event, you'd like to have GitHub include a list of the runner groups that could potentially run the job? Am I understanding that correctly? Could you describe that a little bit more?

@pje

The reason GitHub doesn't include runner/group data for queued events is by definition: queued means "not yet assigned to a runner". We literally don't know yet which runner will pick up the job, nor which group that runner will be part of.

Correct, those attributes in the workflow_kjob event relate to the actual runner that takes on the job, not the repository.

So you're saying that, within each workflow_job.queued event, you'd like to have GitHub include a list of the runner groups that could potentially run the job? Am I understanding that correctly? Could you describe that a little bit more?

This basically. Without this information you are relegated to doing something hacky:

Unique labels for each runner group. This is a bit rubbish as the workflow author now needs to know about the implementation details of the runner group setup, it's very leaky.
A unique GitHub App per runner group with the same set of repositories associated with the app as with the runner group. You would then subscribe to the workflow_job in the GitHub App. This is not exactly clean and lots of engineers who use GitHub don't know this level of detail about the platform.
With this PR merged the repositories attribute would work but this is more effort than it should be and makes changes more complicated as I now have to manage multiple things (the runner group and my HRAs)
Don't use runner groups and use labels to drive the entire thing. Labels are client-side, they can be changed in a PR and take effect in that PR. Runner groups are sever-side so I probably don't want to swap a server-side control for a client-side control.

As you can see there are ways around this limitation but it's all very messy.
In an ideal world I should be able to have a single install instance of actions-runner-controller, set up a single GitHub App and a single webhook and be able to scale runners accurately using any of GitHub Actions features, of which Runner Groups are one. I don't want to have to configure stuff in GitHub server-side and then have to make configuration changes to actions-runner-controller, I'd like all repository configuration information that could relate to how / what runners are sclaed in the payload at the queued state so keep my actions-runner-controller setup as simple as possible.

@pje I think myself and many others have totally misunderstood the design of runner groups and how they are intended to be used, with how they are designed to be used it makes sense not including the runner group in the webhook https://github.com/actions-runner-controller/actions-runner-controller/issues/1055.

Also see https://github.com/actions-runner-controller/actions-runner-controller/pull/1361 for the corresponding documentation update!

Well done guys!
I looked at the readme in master, and i quickly navigated here somehow: https://github.com/actions-runner-controller/actions-runner-controller/blob/master/README.md?plain=1#L678
While Example 1 covers this new way of doing things, I think this has to be the most preferred way to do the webhook scaling (at least from my experience). I think we should have it as the first example configuration snipped shown.
Are there any scenarios wherein anyone would want
  - githubEvent:
      checkRun:
        types: ["created"]
        status: "queued"

over the new method
  scaleUpTriggers:
  - githubEvent:
      workflowJob: {}

I cannot come up with a reason why anyone would want or need the older way.
And first impressions are great, it looks very promising!
We used to have starvation issues (we have a construction also where we skip steps).
Have to give it a bit more time, but the way it looks right now, for webhook scaling, I would almost suggest to release current master. It's a big improvement

Yeh, raise a PR to swap them around, it's just an artefact of history really as to why we don;t have workflow job as the first example yaml.

Have to give it a bit more time, but the way it looks right now, for webhook scaling, I would almost suggest to release current master. It's a big improvement

we're testing master atm to hopefully release soon


[feature]  Custom data attributes on shapes

it is not  support custom attributes in shapes? when I selected one shape or line or text , it is excepted to show the username over the shape, but I am not found how to do this. And I cant see the performance and the scenes to be used of 'custom-cursors' component. when should i use it？

Hi, closing this as we won't be adding new features to this version of tldraw. Check https://github.com/tldraw/tldraw for the latest! I think you'd find the meta property helpful there.


Document the Koop-FDA provider

Add docs to http://github.com/koopjs/koop-fda explaining how to use and install the provider

Done, please visit the repo to see the updated documentation.


added grpc support

gRPC support docs

@tharun208 would you please rebase this to the latest docs and apply the suggested changes.

@nickolaev @tharun208 this has already been updated: https://kuma.io/docs/0.7.1/policies/protocol-support-in-kuma/#http-2-support


firestore permission error on products collection

Got error on new seller product as following:
[cloud_firestore/permission-denied] The caller does not have permission to execute the specified operation
I tried open all permission, but no use. here is my rules:
match /products/{document=**} {
allow read: if true;
allow create, write, delete: if true;
}

Create a firebase project for your account and connect this flutter app to it.


Serve production build

First of all,  thanks for this amazing work. Really helpful to setup your own project.
I have a doubt about how can I serve a production build. When I run npm run build.prod and then serve dist/prod with python like python3 -m http.server and check the browser, I got the next errors:
Failed to load resource: the server responded with a status of 404 (File not found) http://localhost:8000/bootstrap.js
Error: XHR error (404 File not found) loading http://localhost:8000/bootstrap.js(…) "Report this error at https://github.com/mgechev/angular2-seed/issues" localhost/:37

and the site keep loading forever (with Loading...).
I tried to change the System.import('bootstrap') in index.html without results.
I use npm 2.14.7, node v4.2.2, chrome v47 and Ubuntu 15.10

Most likely related to https://github.com/mgechev/angular2-seed/issues/350

I'm not sure yet what is the exact issue but the problem is related to the version of systemjs. It works fine with 0.19.9. Does not work anymore with 0.19.12. Changing the version should help at least as 'quick fix'.

@czaktesta thanks for pointing this out! We'll need to take a further look at this issue, for now I workarounded it with the fix you suggested.


Update README.md

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1 (7076d64) into master (8f5b889) will decrease coverage by 1.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   21.08%   19.24%   -1.84%
==========================================
  Files          58       60       +2
  Lines        2201     2411     +210
==========================================
  Hits          464      464
- Misses       1688     1898     +210
  Partials       49       49

Impacted Files
Coverage Δ

pkg/ddc/alluxio/cache.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/dataset.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/engine.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/metadata.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/operations/base.go
39.44% <0.00%> (-9.33%)
:arrow_down:

pkg/ddc/alluxio/shutdown.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/status.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/transform.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/transform_hadoop_config.go
0.00% <0.00%> (ø)

pkg/ddc/alluxio/types.go
0.00% <ø> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e77feb...7076d64. Read the comment docs.


Missing include

Looks like context.h should include logging.h to use mk_logger_c at line 50. Right now all works because of current include order.

My expectation is that code requiring the logger would include core.h, which is the umbrella header for the Core submodule.  It includes logging.h and context.h.
I suppose I could add some macros to make it explicit.


NullPointerException when setViewPager

java.lang.NullPointerException at
    me.relex.circleindicator.CircleIndicator$1.onPageSelected(CircleIndicator.java:179)
    me.relex.circleindicator.CircleIndicator.setViewPager(CircleIndicator.java:151)

At first, setViewPager with 3 items.
User selected page at 3rd, and then call setViewPager again with only 2 items.
getChildAt(mLastPosition) will be null.
need to consider handle NullPointerException when currentIndicator is null.
Thanks.

You have set two different ViewPager to the Indicator?

@ongakuer No. I just use this lib in RecyclerView. so i have to setAdapter again when every onBindViewHolder() called.

I think you can setAdapter on onCreateViewHolder, and update Adapter outside.

@ongakuer thanks. that's perfect. why can't i think this way. thanks again.
i will close this issue.


Document the unavailable folder names, when creating new project.

There need to be more documentation available, when the user wants to create new project via clicking on "New Project" and then naming the folder, where the project files will be generated.
I tried it on Windows 10 Home, once or twice it froze and i had to kill it with task manager via process kill. When i 've ran it the third time, it just wrote the alert that the folder couldn't be created, but did not mention why. Some of us know that there are some illegal or better said forbiden names, for naming folders/files on Windows, especially on Desktop, but the beginners and some people doesn't know that. It is simply not enough, just to say that folder cannot be created, without explaining why and how to fix it.
**

List of reserved file names on Windows 10:
The following are (case insensitive) reserved names which cannot be assigned to a directory or file in Windows 10 :
CON
PRN
AUX
NUL
COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8, COM9, COM0
LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, LPT9, LPT0

**
src --> https://kizu514.com/blog/forbidden-file-names-on-windows-10/

Duplicate of #20110 and #38198.


Retry to upload

Uploading is failed sometimes, so I'll implement the option of retry.
When uploading, user can set the number of trial for retry uploading.
See #229.

Fixed at v2.0.1


Implement Scale Operate??

System information

Have I written custom code: N/A:
OS Platform and Distribution: openSUSE Leap 42.3:
TensorFlow installed from: binary:
TensorFlow version: tensorflow_gpu-1.4.0:
Python version: 2.7.13:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 8.0/6.0:
GPU model and memory: 11GB:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
In Caffe, Scale layer could do this:
top = alpha∗bottom+beta
where bottom is the input, top is the output, alpha and beta are the learnable params.
In Tensorflow, what operate could implement above layer?
Thanks, Help a lot.

@ly-atdawn  Yes, but I find this is even slower than the fused-batchnormalization  (NCHW format)

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If this is a feature request, please create a new issue by providing all the details asked in this template. Thanks !


change the include style in _pymodule.h and remove unused or duplicate headers in two header files

Hi, guys.
In this PR, I changed the include style from <..> to ".." in _pymodule.h. Since I want to use some Numba headers in my numba extension, and meanwhile I use bazel to build a cc file in my extension (because I also depends on a 3rd C++ library). But because of these "ill-formed" include usages, bazel will output some errors to me, like this:
external/numba/cext/../_pymodule.h:6:10: error: 'Python.h' file not found with <angled> include; use "quotes" instead

Meanwhile, I also deleted Python.h in listobject.h and dictobject.h, because cext.h will include this for them. I also deleted ../_pymodule.h in dictobject.h, since they seem not use any marcos or other things in it.
After these changes, the building process seems still good.
PS, I hope these changes in _pymodule.h can be merged into a recent Numba release version at least, thanks.
=============
updates [Sept. 29]: After changing the include style in the _pymodule.h, bazel can successfully compile the cc file for me.
Sure, I have done some tricky things in WORKSPACE:
# Convert the python include dir to a local repo
new_local_repository(
    name = "python",
    # FIXME: DON'T use hardcode python include path
    path = "/Users/ld/opt/anaconda3/envs/numba-pandas/include/python3.10",
    build_file_content = """
package(default_visibility = ["//visibility:public"])
cc_library(
    name = "headers",
    hdrs = glob(["**/*.h"])
)
"""
)

# Convert the site-packages/numba dir to a local repo
new_local_repository(
    name = "numba",
    path = "/Users/ld/opt/anaconda3/envs/numba-pandas/lib/python3.10/site-packages/numba",
    build_file_content = """
package(default_visibility = ["//visibility:public"])
cc_library(
    name = "headers",
    hdrs = glob(["**/*.h"])
)
"""
)

Then, add these two headers into the cc_binary arguments.

@esc / @stuartarchibald Could this have a buildfarm run please?

Thanks for writing up our OOB discussion @gmarkall. The cext.h header already uses #include "Python.h" and as a result the explicit inclusion of this in the typed container headers is indeed superfluous. Changing the search path also makes sense for the reasons outlined by @gmarkall.
Thanks for the patch @dlee992 !

@sklam / @stuartarchibald Can this have a buildfarm run please? I think it's the only thing it's waiting on since we decided this change was OK, but want to check there's no surprises on all platforms.

BFID: numba_smoketest_cpu_yaml_158

BFID: numba_smoketest_cpu_yaml_158

This passed with the exception of a known failure on osx-arm64 due to #8567.


Grafana: Install required plugins automatically?

Not sure if there is a built in way to auto install grafana plugins, I had to add
pi chart and discreet
grafana-cli plugins install grafana-piechart-panel
grafana-cli plugins install natel-discrete-panel
Might be worth adding to docs if it has to be done manually, I did not see another way.

Seems to be in the docs. https://github.com/unifi-poller/unifi-poller/wiki/Grafana#Plugins

Geez I skipped over that whole part of the docs somehow


Improve test coverage of JSON API

As discovered during #3820, many fields are not actually set in the tests, meaning they aren't really tested. This is a follow-up ticket to improve the test coverage of the existing fields in the JSON API.
I'm willing to be assigned this ticket.

@nixjdm You got it!


Asset Service Blacklist

Overview
Currently the app will display any asset with a balance in your portfolio if it is on the asset list, and soon even assets not on the asset will be displayed too. There are a handful of known scam tokens that have been airdropped to many users' wallets and display misleading fiat values (ie. KICK and Minereum). As app maintainers, we want to be able to prevent known scam tokens from appearing in users' wallets and portfolios. Contributors should be able to make pull requests to an open source repo to add new known scam tokens to the blacklist.
Reference
This was a pervious bounty that was closed, but KICK is still showing in Production the asset KICK (0x426CA1eA2406c07d75Db9585F22781c096e3d0E0).
The following assets no longer display in v2, even if users have a balance in their wallet:
KICK (0x426CA1eA2406c07d75Db9585F22781c096e3d0E0)
Minereum (0x426CA1eA2406c07d75Db9585F22781c096e3d0E0)
UNIH (0x4bf5dc91e2555449293d7824028eb8fe5879b689)
0x7761c09EA2DE3F7205Dba784Fd87Fd196E019D2A
0x6f0371247d21d7afad6e624f6e8dbb3bff0455c2
0xF9d25EB4C75ed744596392cf89074aFaA43614a8
0x0f8b6440a1f7be3354fe072638a5c0f500b044be
0x1412ECa9dc7daEf60451e3155bB8Dbf9DA349933
0x34278F6f40079eae344cbaC61a764Bcf85AfC949
Acceptance Criteria

blacklist.json file added somewhere in the asset service with a list of blacklisted asset ids, using our asset id implementation in the format ["eip155:1/erc20:0x426ca1ea2406c07d75db9585f22781c096e3d0e0", "eip155:1/erc20:0x4bf5dc91e2555449293d7824028eb8fe5879b689"]
your implementation should filter out blacklisted tokens somewhere in this function or another appropriate place
your implementation should be cross-chain and not ethereum specific
add all the tokens listed above to the blacklist
asset ids in the blacklist should be lowercase and not checksum format
run the yarn generate script to regenerate asset data, verifying blacklisted tokens do not appear in the generatedAssetData.json file, commit the updated file
add documentation to the repo how to add blacklisted tokens to the list
raise a corresponding preemptive PR in the web repo and bump the asset service version in web after your PR in this repo is accepted and merged

Need By Date
NA
Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort
No response
Sponsor / Stakeholder
No response
Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

@Neverwas-dev Looks like KICK is not in the blacklist list

Probably because the asset address in the description is wrong and I didn't take attention


support streaming for functions

Hello,
@hwchase17
could you add support of streaming for _agenerate as well?


Try vm-actions instead of cross-platform-actions

This uses VirtualBox instead of xhyve.  It might be slower, but should be more reliable.

This is running the tests on {Net,Free,Open}BSD.  The tests currently fail on Net- and OpenBSD, though for different reasons.  I've wired up FreeBSD to the all-checks action, but not the other two, so the failing tests don't break merging but it's easy to see if a commit fixes them (once they're fixed, hopefully we can keep them from breaking again).

@devnexen, it looks as if some of the tests fail on NetBSD as well.

@devnexen, it looks as if some of the tests fail on NetBSD as well.

it comes down to the access enforcing thing. Once disabled all pass.

@devnexen, please feel free to push to this branch or raise a PR against it.

Can we merge this to unblock the CI?


Fix app for case sensitive file systems

typo (uppercase instead of lower case)
This breaks the app on *nix system using case sensitive file systems by default

Thanks Systho!


Biology and Photography Classes music doesn't loop

It only plays once and then it's silent besides the sound effects. The only other mod I use is ThirteenAG's Widescreen Fix.

Photography class's music also doesn't loop.

Most classes music doesn't loop. It's set to play x amount of times before stopping, due to it usually not taking people longer than a minute or two to complete the task. This isn't a bug with the patch, this has always been a feature of the game as far as I can remember.


Login to OneDrive get some error log

What is your rclone version (eg output from rclone -V)
rclone v1.39
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Windows10,64 bit
Which cloud storage system are you using? (eg Google Drive)
One Drive

WEB page show "Success Go back to rclone to continue", but rclone show message is "2017/12/24 13:39:30 Failed to configure token: failed to get token: oauth2: cannot fetch token: 401 Unauthorized
Response: {"error":"invalid_client","error_description":"The provided value for the 'client_secret' parameter is not valid."}"
I'm sure my Microsoft client secret is no wrong. How to do?

+1 same error
OneDrive (Personal) in unusable right now

Closing because this is obsolete.


Problems to connect companion to Livecore Nextstage 0802-4k

Hi
I am having some problems to connect companion to Livecore Nextstage 0802-4k
I am entering the right ip address and the right port 10600 for third party control, but nothing
the error in the log is:
16. 15:02:11 instance(livecore): Network error: connect ETIMEDOUT <IP_ADDRESS>:10600
16. 15:01:48 instance(livecore): Network error: connect ETIMEDOUT <IP_ADDRESS>:10600
and before:
16. 14:26:13 instance(livecore): Network error: connect EADDRNOTAVAIL <IP_ADDRESS> - Local (<IP_ADDRESS>:55938)
if someone can help me it should great!

This is for sure not a problem with the module but with your network or network settings.
First make sure you can ping that ip and if that works use a terminal (e.g. putty if you're on a pc) to connect to the nextage with the port 10600. Only if get to the shell of the Nextage with the terminal but are not able to connect with companion at the same time come back here.

Hi!
Thanks a lot for your reply, in fact I found the problem, it was something
wrong with the firewall settings, then I also changed all the network
cables because I suspect too from that side, and know it working perfectly!
Sorry I didn't mute the thread, just because I was and still very busy in
this work, tomorrow I will do !
Thanks a lot !
Il sab 21 set 2019, 22:29 dnmeid<EMAIL_ADDRESS>ha scritto:

This is for sure not a problem with the module but with your network or
network settings.
First make sure you can ping that ip and if that works use a terminal
(e.g. putty if you're on a pc) to connect to the nextage with the port
10600. Only if get to the shell of the Nextage with the terminal but are
not able to connect with companion at the same time come back here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bitfocus/companion-module-livecore/issues/5?email_source=notifications&email_token=ALOZHPVUCFOEKGPU4U6OJXTQKZ73PA5CNFSM4IXC532KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IZD4I#issuecomment-533828081,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALOZHPVM3756UJ4BXRFV2XTQKZ73PANCNFSM4IXC532A
.


Make it possible to fill same form over two different data tasks

Description
In some scenarios it is a need for several people will be involved in reporting on different parts in the same form.
Example scenario.

Reportee fill out some data in the form
Auditor fill out some additional fields in the same form

One option to solve this is to make it possible to fill out the same data element over two different tasks and allow to have a different form layout for this.
This is partially supported, at least on the form layout level, but this needs to be investigated. At least the locking of dataelements is not defined.
Flow could be
Data -> Data -> Confirmation
or
Data -> Data -> Confirmation - > Sign -> End
Or any other functional flow that makes sense.
Services where this functionality is required is
KRT-1008, KRT-1009 and KRT-1010 for finanstilsynet
Screenshots

Considerations

Locking/unlocking of form when the data is gone be modified before
What when the form is sent backward in the process?

Ops requirements

Acceptance criteria

Possible to have a different design for the same data element type in two different tasks
Data created should be resued in the next step
data created and updated Task 1 should be editable in Task 2.
Should be possible to send from Task 2 to Task 1 if the flow is defined in the process.
Possible to define different authorization requirements for the two different tasks

Specification tasks

[ ] Development tasks are defined

Development tasks

Test

Definition of done

[ ] Documentation (docs.altinn.studio) is updated (if relevant)

[ ] Technical documentation
[ ] User documentation

[ ] QA
[ ] Manual test is complete (if relevant)
[ ] Automated test is implemented (if relevant)
[ ] All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

#16


add two cities

Added two major cities in my country

Thanks for the contribution, @danielmuthama! I've merged it in my fork (see the commit referenced above) and the changes are live.

you are welcome
On Mon, Jan 3, 2022 at 10:53 AM Ashish Kulkarni @.***>
wrote:

Thanks for the contribution, @danielmuthama
https://github.com/danielmuthama! I've merged it in my fork
https://github.com/ashkulz/committers.top (see the commit referenced
above) and the changes are live https://committers.top/kenya.
—
Reply to this email directly, view it on GitHub
https://github.com/lauripiispanen/most-active-github-users-counter/pull/110#issuecomment-1003918861,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJVSXQVCF5LAPXWOAAPK57LUUFIYBANCNFSM4SVIDPYQ
.
You are receiving this because you were mentioned.Message ID:
<lauripiispanen/most-active-github-users-counter/pull/110/c1003918861@
github.com>


Patterns for dealing with concurrency in Knative controllers

I'm writing a Knative controller that creates, updates and deletes certain Github resources (e.g. hooks, keys, etc.) when a custom resource definition changes. I've been noticing race conditions that arise when two concurrent reconciliation operations are fired what leads to certain resources to get duplicated (e.g. two hooks are created). Currently, after creating a Github hook I'm saving its identifier in the resource's status to avoid calling the Github API to list existing hooks what might cause issues with rate limits or lead me to implement a complex logic to deal with pagination. So, the controller checks if the resource being reconciled has a hook ID in its status to decide if a new hook must be created or if the corresponding hook must be updated according to the current state of this resource.
Sometimes it seems that a new reconciliation flow is being triggered while the Github API is creating a new resource or before the new status is available in the shared cache, what causes the duplication. So, I was wondering whether there are known patterns in Knative to deal with this sort of concurrency in which a controller is used to reconcile an external resource whose identifier must be saved to be used later. I thought about using an external storage (such as Redis), but it seemed too intrusive or perhaps a lock based on the resource's key, but I'd like to know if Knative provides an out-the-box feature to help us to solve that problem.

/remove-lifecycle stale
Sorry for not answering this earlier @alan-ghelardi!
Knative's reconciler framework provides no additional tooling over concurrency control vs. reconcilers built with, for example, kubebuilder. The invariant that's kept is that a given "main" resource (the main driver of the reconcilation process) is only reconciled once at a time. The same CR should never be reconciler twice, regardless of how many threads the reconciler runs with. In general however, the reconciler can reconcile different CRs in parallel. The default worker size is 2.
We do have additional measures to allow these invariants to hold across scaling out the reconciler deployment, but it doesn't sound like that's what you're asking for.

Thank you for the answer @markusthoemmes. I solved the issue by postponing update events for a few seconds (i.e. through the EnqueueAfter function) to reduce the risk of reconciling an object whose status isn't up to date yet. I'm not certainty that it's the safest solution, but it has been working so far.


Problem with CssText output of "text-decoration"

For css definiton:  a {text-decoration:underline;}
The parsed CssText output is:
a { text-decoration-line: underline; text-decoration-style: initial; text-decoration-color: initial; }
Since the later is not supported in most major browsers, the rendering result in browser is totally different.
Is there any specific reason for rendering the CssText the current way?

Not supported in major browsers? text-decoration was a longhand in CSS 2 but changed with CSS 3 to a shorthand. Every modern browser should support this.
What you see here is the expansion as it is stored inside the StyleDeclaration. What obviously does not work (but that is only due to some bugs in the conversion process; which is new in v0.8.5 and will become more mature until v0.9) is the back transformation from longhands to shorthand properties for serialization.
So this is a minor bug that has only (afaik) cosmetic consequences in form of an uglier serialization.

Thanks for your quick response.
I was saying "text-decoration-line" is not supported by major browsers. Thus the longhand CssText output of the parsed css definition will generate different look in browser.
You can check it out here: http://www.w3schools.com/cssref/css3_pr_text-decoration-line.asp .  My test in IE, Chrome and Firefox confirmed it, too.

Apparently only Firefox follows the specification here. Either way the serialization will be fixed in the upcoming release.


worldpop.csv contains no data

(except for its col headings)
https://storage.googleapis.com/covid19-open-data/v2/worldpop.csv

looks fixed

Great! I was just about to check. Thank you for reporting and for verifying.


Use maskUtils to match the import on line 113

flake8 testing of https://github.com/opencv/open_model_zoo on Python 3.7.1
$ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
./tools/accuracy_checker/accuracy_checker/representation/segmentation_representation.py:132:20: F821 undefined name 'maskUtils'
            rles = maskUtils.frPyObjects(mask, height, width)
                   ^
./tools/accuracy_checker/accuracy_checker/representation/segmentation_representation.py:133:19: F821 undefined name 'maskUtils'
            rle = maskUtils.merge(rles)
                  ^
./tools/accuracy_checker/accuracy_checker/representation/segmentation_representation.py:136:19: F821 undefined name 'maskUtils'
            rle = maskUtils.frPyObjects(mask, height, width)
                  ^
./tools/accuracy_checker/accuracy_checker/representation/segmentation_representation.py:158:26: F821 undefined name 'pycocotools'
            areas.append(pycocotools.mask.area(mask))
                         ^
4     F821 undefined name 'maskUtils'
4

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

F821: undefined name name
F822: undefined name name in __all__
F823: local variable name referenced before assignment
E901: SyntaxError or IndentationError
E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

Jenkins: test this please

Jenkins please retry a build

Jenkins: test this please

@cclauss There's a syntax error (see the build output).

Jenkins: test this please