Offload multipolygon storage to disk (reduce memory usage by 10-15gb)

The next biggest object held in memory after node locations is multipolygon way geometries. This was storing node IDs in an HPPC LongLongMap which makes a copy every time it expands. The list was getting up to 5-7GB, which requires an extra 5-7GB each time it expands.  This change moves that to a more memory-efficient AppendStore that doesn't require an extra 5-7GB memory to expand, and can also be offloaded to disk save another 5-7GB.
I tested this out on the planet twice:

-Xmx32g on a 16 cpu/64GB digitalocean droplet: finished in 2h19m (osm_pass2 took 1h36m)
-Xmx20g on a 16 cpu/32GB digitalocean droplet: finished in 2h58m (osm_pass2 took 2h5m)

Checklist:

[x] expose settings so you can switch the append store implementation
[x] estimate memory usage
[x] report memory usage in logs

Some stats from the -Xmx32g on a 64GB machine:
0:07:27 DEB [osm_pass1] - Processed 18,767 blocks:
0:07:27 DEB [osm_pass1] -   nodes: 7,546,573,682 (32M/s) in 3m55s cpu:52m15s gc:5s avg:13.3
0:07:27 DEB [osm_pass1] -   ways: 841,994,745 (9.6M/s) in 1m28s cpu:21m1s gc:5s avg:14.4
0:07:27 DEB [osm_pass1] -   relations: 9,718,612 (852k/s) in 11s cpu:59s avg:5.2
...
1:43:11 DEB [osm_pass2] -   nodes: 7,546,573,682 (11M/s) in 11m22s cpu:2h45m5s gc:17s avg:14.5
1:43:11 DEB [osm_pass2] -   ways: 841,994,745 (200k/s) in 1h9m58s cpu:13h8m7s gc:2m53s avg:11.3
1:43:11 DEB [osm_pass2] -   relations: 9,718,612 (11k/s) in 14m26s cpu:2h57m49s gc:17s avg:12.3
...
2:19:17 INF - 	overall          2h19m18s cpu:26h50m15s gc:4m47s avg:11.6
2:19:17 INF - 	lake_centerlines 2s cpu:4s avg:2.7
2:19:17 INF - 	  read     1x(70% 1s)
2:19:17 INF - 	  process 16x(4% 0.1s wait:1s)
2:19:17 INF - 	  write    1x(0% 0s wait:2s)
2:19:17 INF - 	water_polygons   1m34s cpu:17m49s gc:3s avg:11.3
2:19:17 INF - 	  read     1x(18% 17s wait:1m8s done:5s)
2:19:17 INF - 	  process 16x(61% 57s wait:28s)
2:19:17 INF - 	  write    1x(50% 47s sys:8s wait:46s)
2:19:17 INF - 	natural_earth    10s cpu:27s avg:2.8
2:19:17 INF - 	  read     1x(72% 7s wait:2s)
2:19:17 INF - 	  process 16x(6% 0.5s wait:8s)
2:19:17 INF - 	  write    1x(0% 0s wait:9s)
2:19:17 INF - 	osm_pass1        5m35s cpu:1h14m31s gc:11s avg:13.3
2:19:17 INF - 	  read     1x(22% 1m12s sys:46s wait:2m37s done:4s)
2:19:17 INF - 	  process 15x(84% 4m43s sys:6s block:11s wait:19s)
2:19:17 INF - 	osm_pass2        1h35m44s cpu:18h50m49s gc:3m27s avg:11.8
2:19:17 INF - 	  read     1x(1% 1m20s sys:55s wait:1h32m9s done:1m28s)
2:19:17 INF - 	  process 15x(74% 1h10m28s sys:2m12s block:28s wait:5s)
2:19:17 INF - 	  write    1x(21% 19m47s sys:3m40s wait:1h14m27s)
2:19:17 INF - 	boundaries       15s cpu:19s avg:1.3
2:19:17 INF - 	sort             6m44s cpu:1h7m35s gc:34s avg:10
2:19:17 INF - 	  worker 16x(44% 2m59s sys:23s wait:1m12s done:9s)
2:19:17 INF - 	mbtiles          29m6s cpu:5h18m26s gc:34s avg:10.9
2:19:17 INF - 	  read    1x(81% 23m41s sys:3m12s wait:2m23s done:4s)
2:19:17 INF - 	  encode 16x(58% 16m51s sys:3s wait:10m40s done:4s)
2:19:17 INF - 	  write   1x(54% 15m43s sys:2m19s wait:12m2s)

And it took 5.3 CPU-hours fetching way geometries

From https://observablehq.com/@msbarry/planetiler-log-visualizer

And some stats from the -Xmx206 on a 32GB machine:
0:09:34 DEB [osm_pass1] - Processed 18,767 blocks:
0:09:34 DEB [osm_pass1] -   nodes: 7,546,573,682 (22M/s) in 5m30s cpu:48m51s gc:18s avg:8.9
0:09:34 DEB [osm_pass1] -   ways: 841,994,745 (7.6M/s) in 1m51s cpu:25m8s gc:10s avg:13.6
0:09:34 DEB [osm_pass1] -   relations: 9,718,612 (855k/s) in 11s cpu:1m14s avg:6.5
...
2:14:22 DEB [osm_pass2] - Processed 18,767 blocks:
2:14:22 DEB [osm_pass2] -   nodes: 7,546,573,682 (9M/s) in 13m58s cpu:3h22m42s gc:22s avg:14.5
2:14:22 DEB [osm_pass2] -   ways: 841,994,745 (151k/s) in 1h32m20s cpu:12h35m29s gc:2m56s avg:8.2
2:14:22 DEB [osm_pass2] -   relations: 9,718,612 (8.7k/s) in 18m32s cpu:2h52m54s gc:16s avg:9.3
...
2:58:08 INF - 	overall          2h58m8s cpu:26h39m53s gc:5m21s avg:9
2:58:08 INF - 	lake_centerlines 1s cpu:5s avg:3.5
2:58:08 INF - 	  read     1x(75% 1s)
2:58:08 INF - 	  process 16x(5% 0.1s wait:1s)
2:58:08 INF - 	  write    1x(0% 0s wait:1s)
2:58:08 INF - 	water_polygons   1m44s cpu:20m30s gc:3s avg:11.9
2:58:08 INF - 	  read     1x(18% 18s wait:1m12s done:5s)
2:58:08 INF - 	  process 16x(64% 1m7s wait:27s)
2:58:08 INF - 	  write    1x(45% 46s sys:8s wait:56s)
2:58:08 INF - 	natural_earth    8s cpu:24s avg:2.9
2:58:08 INF - 	  read     1x(82% 7s)
2:58:08 INF - 	  process 16x(7% 0.6s wait:7s)
2:58:08 INF - 	  write    1x(0% 0s wait:8s)
2:58:08 INF - 	osm_pass1        7m32s cpu:1h15m20s gc:28s avg:10
2:58:08 INF - 	  read     1x(15% 1m6s sys:44s wait:1m36s done:3s)
2:58:08 INF - 	  process 15x(60% 4m31s sys:9s block:12s wait:2m9s)
2:58:08 INF - 	osm_pass2        2h4m49s cpu:18h50m55s gc:3m35s avg:9.1
2:58:08 INF - 	  read     1x(1% 1m11s sys:49s wait:1h59m35s done:1m59s)
2:58:08 INF - 	  process 15x(56% 1h10m21s sys:3m3s block:27s wait:6s)
2:58:08 INF - 	  write    1x(15% 18m47s sys:3m22s wait:1h44m40s)
2:58:08 INF - 	boundaries       14s cpu:19s avg:1.3
2:58:08 INF - 	sort             14m25s cpu:51m5s gc:39s avg:3.5
2:58:08 INF - 	  worker 16x(15% 2m8s sys:19s wait:5m12s done:11s)
2:58:08 INF - 	mbtiles          29m6s cpu:5h21m2s gc:35s avg:11
2:58:08 INF - 	  read    1x(77% 22m32s sys:3m6s wait:2m50s done:2s)
2:58:08 INF - 	  encode 16x(59% 17m6s sys:3s wait:10m32s done:2s)
2:58:08 INF - 	  write   1x(53% 15m23s sys:2m14s wait:12m24s)

And it took 5.3 CPU-hours fetching way geometries

From https://observablehq.com/@msbarry/planetiler-log-visualizer


libbytesize: 2.7 -> 2.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/storaged-project/libbytesize/releases.
meta.description for libbytesize is: A tiny library providing a C “class” for working with arbitrary big sizes in bytes
meta.homepage for libbytesize is: https://github.com/storaged-project/libbytesize
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.8 with grep in /nix/store/fwrqp0yzmhywsnwiwa0gasvxfjlq2dw3-libbytesize-2.8
found 2.8 in filename of file in /nix/store/fwrqp0yzmhywsnwiwa0gasvxfjlq2dw3-libbytesize-2.8

Rebuild report (if merged into master) (click to expand)

128 total rebuild path(s)

128 package rebuild(s)

First fifty rebuilds by attrpath
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys
adapta-gtk-theme
almanah
bubblemail
budgie.budgie-control-center
calls
cantata
chatty
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.nemo
cinnamon.nemo-fileroller
cinnamon.nemo-python
cinnamon.nemo-with-extensions
clementine
deepin.dde-control-center
deepin.dde-device-formatter
deepin.dde-dock
deepin.dde-network-core
deepin.dde-session-ui
deepin.deepin-album
deepin.deepin-compressor
deepin.deepin-image-viewer
deepin.deepin-music
deepin.udisks2-qt5
deepin.util-dfm
elementary-planner
endeavour

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fwrqp0yzmhywsnwiwa0gasvxfjlq2dw3-libbytesize-2.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libbytesize https://github.com/r-ryantm/nixpkgs/archive/5eb6f12f863f3e59a7ddb328cdb9f93e7f2b10c2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fwrqp0yzmhywsnwiwa0gasvxfjlq2dw3-libbytesize-2.8
ls -la /nix/store/fwrqp0yzmhywsnwiwa0gasvxfjlq2dw3-libbytesize-2.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages marked as broken and skipped:

elementary-planner
gnomeExtensions.easyScreenCast
mailnagWithPlugins
pantheon.elementary-tasks
xmonad_log_applet

119 packages built:

CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys
adapta-gtk-theme
almanah
bubblemail
budgie.budgie-control-center
calls
cantata
chatty
cinnamon.cinnamon-common
cinnamon.cinnamon-control-center
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.nemo
cinnamon.nemo-fileroller
cinnamon.nemo-python
cinnamon.nemo-with-extensions
clementine
deepin.dde-control-center
deepin.dde-device-formatter
deepin.dde-dock
deepin.dde-network-core
deepin.dde-session-ui
deepin.deepin-album
deepin.deepin-compressor
deepin.deepin-image-viewer
deepin.deepin-music
deepin.udisks2-qt5
deepin.util-dfm
endeavour
enlightenment.enlightenment
eos-installer
evolution
evolution-data-server
evolution-data-server-gtk4
evolution-ews
evolutionWithPlugins
exaile
folks
gfbgraph
gnome-browser-connector
gnome-multi-writer
gnome-online-accounts
gnome-photos
gnome-recipes
gnome.cheese
gnome.geary
gnome.gnome-applets
gnome.gnome-calendar
gnome.gnome-contacts
gnome.gnome-control-center
gnome.gnome-disk-utility
gnome.gnome-flashback
gnome.gnome-initial-setup
gnome.gnome-music
gnome.gnome-notes
gnome.gnome-online-miners
gnome.gnome-panel
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.gvfs
gnome.nixos-gsettings-overrides
gnome.totem
gnomeExtensions.gsconnect
gnomeExtensions.system-monitor
grilo-plugins
gvfs
libblockdev
libbytesize
libgdata
libzapojit
mate.mate-utils
mojave-gtk-theme
monitor
pantheon.elementary-calendar
pantheon.elementary-greeter
pantheon.elementary-mail
pantheon.elementary-session-settings
pantheon.switchboard-plug-about
pantheon.switchboard-plug-onlineaccounts
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-datetime
pantheon.wingpanel-with-indicators
phosh
phosh-mobile-settings
psensor
rabbitvcs
rapid-photo-downloader
spaceFM
udiskie
udisks
usbimager
usermount
valent
vifm-full
vimix-gtk-themes
whitesur-gtk-theme

Maintainer pings

I will adopt this!


@mention system

@mention system

Originally posted by @Apidwalin in https://github.com/Apidwalin/hello-world/issues/1#issuecomment-861124880


A little thought about README.md

The example here uses withState along with pure  function, which seems a little bit weird.
If I understand correctly the pure function implements shouldComponentUpdate and compares only props, then what's the point to ship states with a pure component?
https://github.com/acdlite/recompose#composition

It's perfectly fine, because map props may return a new reference of props but no new values. So pure will prevent the enhanced component to render with no changes.
pure only prevent renders with no changes on the data.
As the react.js documentation states:

If your React component’s render() function renders the same result given the same props and state, you can use React.PureComponent for a performance boost in some cases.

NVM.. I might have some misunderstanding about stateless component and pure component, thx for the reply!


High speed causing lag / rollback on multiplayer

The Dodge using 2000 strenght in multiplayer mode is causing rollback / lag

This will not be fixed until it's moved to the new Network Prediction system


this.agent.response_.json is not a function

Hi,
I am trying to use this library with fastify
I am passig the request response to the WebhookClient
But when the endpoint is hit, it gives the following erro
(node:9984) UnhandledPromiseRejectionWarning: TypeError: this.agent.response_.json is not a function
    at V2Agent.sendResponses_ (G:\Nodes\sjpl-graph-ql\node_modules\dialogflow-fulfillment\src\v2-agent.js:255:26)
    at WebhookClient.send_ (G:\Nodes\sjpl-graph-ql\node_modules\dialogflow-fulfillment\src\dialogflow-fulfillment.js:505:17)
    at promise.then (G:\Nodes\sjpl-graph-ql\node_modules\dialogflow-fulfillment\src\dialogflow-fulfillment.js:316:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Please let me know if this library can be used with fastify?

See #246


Use constituency and dependency features for training

🚀 Feature

Motivation

Alternatives

Pitch

Additional context

@colabofficial3 thanks for raising the issue! Can you please elaborate a bit more on this?

This issue is closed as no details are provided. Please add more information when creating an issue. @colabofficial3


The log given by the failure.
ng g component r101c --module=eis/eis.module
Unknown collection "@schematics/angular".
Error: Unknown collection "@schematics/angular".
at SchematicEngine.createCollection (C:\PI-Data-Center-App\node_modules@angular-devkit\schematics\src\engine\engine.js:45:19)
at Object.getCollection (C:\PI-Data-Center-App\node_modules@angular\cli\utilities\schematics.js:32:31)
at Class.run (C:\PI-Data-Center-App\node_modules@angular\cli\tasks\schematic-get-options.js:11:41)
at Class.beforeRun (C:\PI-Data-Center-App\node_modules@angular\cli\commands\generate.js:89:31)
at Promise.resolve.then (C:\PI-Data-Center-App\node_modules@angular\cli\ember-cli\lib\cli\cli.js:150:24)

fix by
npm i @schematics/angular

npm ERR! code ENOLOCAL
npm ERR! Could not install from ".schematics\angular'" as it does not contain a package.json file.

npm i @schematics/angular
(typos above)

Did try it without "." yesterday at the time of the post.
But it did not work, now it works, thanks 👍

@erika9star  you are a life saver :+1 :)

Npm install works too


ipa file  has wrong entitlements

HI,
I use fastlane and have configured the fastlane file like below.
lane :fir do
    sigh
    ENV["PROFILE_UDID"] = lane_context[SharedValues::SIGH_UDID]
    gym(scheme: "gaibianjia",use_legacy_build_api: true)
    sh "../fir.sh"
  end

And my project file has sign，just like below

My gym version is 0.9.0,fastlane version is 1.32.1.
When I choose the fir lane in command line, it build success, but the ipa's entitlements is not correct,it's entitlements is product what i selected is development.
What's wrong with it? Thank you.

I' am sorry I have opened the same issue twice. Ignore this one, Thank you!


Fix, update and automate generation of detailed_gene and summary_gene tables #2

My previous PR was getting Ensembl gene info from GRCh38 instead of GRCh37, this fixes that.
The column transcript_tsl / transcript_status was changed to transcript_gencode_basic - more info here.
Updated generated detailed_gene_table_v95 and summary_gene_table_v95 can be found here: https://drive.google.com/drive/u/0/folders/1q5geCRd0EPqGJcJQ0j2D_V0IO7Z0Q3vq
Apologies for the oversight regarding GRCh37 vs. GRCh38, I'm always bugging people to check genome build versions, and now it was my turn to get burned!
Addresses #902 and #912.

Great work! I just checked the updated gene tables on google drive, but the HGNC names seem to not have been updated yet, i.e. they do not match the table downloaded from HGNC in hgnc.query.pl. Using issue #902 as an example, CECR1 is now a previous symbol for ADA2 in the downloaded table, yet in summary_gene_table_v95 it is still the approved symbol.


[NextJS template] Reduce scroll animation

Design is putting together a direction on how to use scroll animation. Once done, we need to update NextJS templates to be less scroll woozy.

Potentially schedule in Sprint 11.  Animation is assigned to sprint 10.  This issue can be taken up after the animation work is finished.

Closing dup of (#


Fix scrollspy regression on nested navs

I noticed that in scrollspy, nested navs started to have different behavior in v4 when applying '.active'.
Problem demonstrated here:
http://jsbin.com/liseqalevu/1/edit?html,output
Expected:
Only 'd' and 'e' should be active.

Also, please add a relevant unit test. See https://github.com/twbs/bootstrap/tree/v4-dev/js/tests for instructions.

OK, no problem, I updated the pull request with a unit test and fixed the string concat.

Did you guys get to review the pull request?

Parent/nested styles are meant to be applied in scrollspy—so first-child isn't an option. Thanks though!


Add Windows builds to CI

Duplicate of ros-industrial/abb_libegm#92, but for abb_librws.

#91 added this.


Box2D Testbed is not compatible with Box2D-optimized

I got some compiler errors...
Once be:  b2ChainShape  unknown
I thought In can use Box2D-optimized without any changes on my Box2D app.
Only switching from  Box2D to Box2D-optimized and can use my original sources whitout any changes.

Hi @aismann !
Unfortunately there are some breaking changes and incompatibilities with the original box2D, but only where it was necessary to provide superior performance. The chain shape is one such case. It is no longer a single shape, so you have to add the edge shapes in your body.
I have created helper functions specifically for this case, in b2_geometry. Can you check out https://github.com/mtsamis/box2d-optimized/blob/master/src/common/b2_geometry.cpp and see if these can be used as a replacement?
These function are used in the testbed examples so you can find an example there. They were made to provide a similar alternative to working with chain shapes.
Let me know if this helps
Thanks!

Thanks for this hint.
I will use/test it later some weeks.
Currently on another project.


Bump MudBlazor from 6.11.0 to 6.14.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.487%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12220

Relevant Lines:
13810

💛  - Coveralls


Calibration failed error

Hello, my code is producing the error "! Calibration failed".
Below is the code snippet that produced the error. pop_long is the target dataset with the factor variables, country, Age (group), female. all is the dataset I'm trying to rake and includes the 3 variables.
targets <- create_raking_targets(pop_long, vars = c("country", "Age", "female"), wt = "frac")
all_raking <- all %>% mutate(rk_country = dk_to_na(country), rk_Age = dk_to_na(Age), rk_female=dk_to_na(female))
all_imputed <- impute_vars(all_raking, seed = 739)

No input to to_impute argument found. Imputing variables with prefix rk_ by default.
iter imp variable
1   1  rk_Age  rk_female
2   1  rk_Age  rk_female
3   1  rk_Age  rk_female
4   1  rk_Age  rk_female
5   1  rk_Age  rk_female

all_raked <- all %>% dplyr::mutate(weight2 = rake_survey(all_imputed, pop_margins = targets))

Error in dplyr::mutate():
ℹ In argument: weight2 = rake_survey(all_imputed, pop_margins = targets).
Caused by error in calibrate.survey.design2():
! Calibration failed
Backtrace:

all %>% ...
pewmethods::rake_survey(all_imputed, pop_margins = targets)
survey:::calibrate.survey.design2(...)
base::stop("Calibration failed")

Here is my R version:

R.Version()
$platform
[1] "aarch64-apple-darwin20"

$arch
[1] "aarch64"
$os
[1] "darwin20"
$system
[1] "aarch64, darwin20"
$status
[1] ""
$major
[1] "4"
$minor
[1] "4.1"
$year
[1] "2024"
$month
[1] "06"
$day
[1] "14"
$svn rev
[1] "86737"
$language
[1] "R"
$version.string
[1] "R version 4.4.1 (2024-06-14)"
$nickname
[1] "Race for Your Life"

Hello,
This error appears to originate from the survey package that rake_survey is wrapping around, so my first couple of thoughts would be to check whether country, Age and female have the same categories between the all dataset and in the targets, and if so, whether the cells created by those categories are of a sufficient size to conduct raking. If, say, the data does not contain any observations for a particular country, or contains only a handful of observations, the raking algorithm may not converge, in which case you might need to collapse some countries together in order to create cells with around 30 or more cases or so.
If the cells are all a sufficient size, another possibility is that the marginal distributions from the dataset are so wildly far from the targets that the algorithm cannot converge. This sort of thing might occur if there was a coding error with the raking variables.


Modding YOTD features

I am very new to modding so I have no idea how to mod (but I do have some programming experience) anything other than images which you have helped with and thank you, but how would I add or modify the game features. I know that is a general topic, so is there anything you would suggest to mod the game features. I know tag duels is in the game, but there is no display to get to it. So where could I start to get started on a project like that?

If you want to do anything like that you're going to need to learn a lot about Assembly and reverse engineering since you're going to need to hack a lot of logic into the game that doesn't already exist in it.

Ouch that sounds intense. Well I think it might already be in the game though. I found some evidence that tag duels are in the code, but not used. It is quite strange. In fact, I think like half the game was left out. There were towers too and other things I don't understand.

Yeah a lot of stuff was ditched and it used to be in the engine, to uncover and unlock it you'd need to find every reference and patch stuff in yourself, so a lot of work for not much gain.
Goodluck though

I will keep trying. lol
I hope I am not bothering you too much, and thanks for the help!

Nah not at all, keep it up my dude and feel free to reach out if you need help

Awesome! I appreciate it! So, would it be like what you did with the shop plugin, but on a much bigger scale?

Pretty much, you'll need to figure out all the entry points you need to hijack, set up the game state in a way that won't crash the game, I'm not seasoned at RE but I wouldn't attempt something like this, and if it's your first time dipping the toes into RE I'd avoid against this since it is a MASSIVE underaking

I don't know if I want to mod this. This seems intense and not for much reward like you said. I might mod it later, but definitely not now. Still, thank you for all your help! I still learned a lot from this.


Add TxController for resource aware access control

This change adds a new package access with an implementation of the Controller interface to limit access to clients when local transmit rate is too high.

This change is

Pull Request Test Coverage Report for Build 1135

60 of 62 (96.77%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.4%) to 79.697%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

access/tx.go
53
55
96.36%

Files with Coverage Reduction
New Missed Lines
%

ndt7/upload/sender/sender.go
5
67.65%

Totals

Change from base Build 1111:
0.4%

Covered Lines:
1629

Relevant Lines:
2044

💛  - Coveralls

https://github.com/m-lab/dev-tracker/issues/542

https://github.com/m-lab/ndt-server/issues/221


Add audio/focus options to AudioSwitchHandler

Also changed the default audio mode to MODE_NORMAL and focus mode to AUDIOFOCUS_GAIN

Fixes #242.


Bump versions

This upgrades the versions of Rails, Ruby and Mongo to the most recent security releases.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Presumably these version bumps will propagate to our devops repos once merged here?

I have to put in a separate PR for that repository, the rails version will propagate however the ruby version and mongo versions require manual intervention.

After re-reviewing this I would really like to close and re-perform this upgrade after https://github.com/projectcypress/cypress/pull/961 is merged since the performance validators seem to have some issues with specific versions of gems.


fzf shows no results in tab-completion of command expansion in zsh and fish

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux

Shell

[x] zsh
[x] fish

Problem / Steps to reproduce

Enter a zsh or fish shell
observe that tab-completing a command expansion works

type $(echo hello)<Tab>
observe that the prompt now contains hello

observe that tab-completing with fzf works for explicit input

type $(echo hello | fzf)<Tab>
observe that fzf shows hello
select hello
observe that the prompt now contains hello

observe that fzf on its own does not allow you to select any results

type $(fzf)<Tab>
observe that there are no items to select in fzf

For the final case I would expect to be able to select from the files under the current directory.
A workaround is to run $(find . | fzf).
It's not clear to me if this is:

expected behavior
a bug in fzf
bugs in zsh and fish

Hi @expipiplus1,
What's your $FZF_DEFAULT_COMMAND? I managed to almost reproduce your scenario, and if I'm in a directory that's empty, then no files show up, but if there are, I most certainly can see the files to pick, this is my $FZF_DEFAULT_COMMAND: rg --files --no-ignore --hidden --follow --glob "!.git/*".
Try changing the environment variable and try again.
Also, the way you wrote your commands is a bit odd, does $(fzf)<Tab> mean
$ fzf
<tab>

Meaning, running the command fzf by itself, and pressing tab afterwards? This syntax is more intuitive to me.

Hi @LuRsT,
FZF_DEFAULT_COMMAND isn't set, there's no change in behavior when it is set.
By $(fzf)<TAB> I meant tab completing the command substitution, i.e. having entered $(fzf) into the terminal (and not pressing CR) press the Tab key to trigger zsh's or fish's completion (replacing $(fzf) with the standard output of running fzf).

I've never used fzf that way, because I'm a bash user and bash doesn't expand command substitution on tab. So I am not completely sure what is going on under the hood.
Anyway, it looks like in that case, the standard input for the command is not the tty device, so fzf reads from that non-tty input zsh injects instead of launching the default command.
[ -t 0 ] || echo "stdin is not tty"
  #

: | ([ -t 0 ] || echo "stdin is not tty")
  # stdin is not tty

$([ -t 0 ] || echo "stdin is not tty")<TAB>
  # command-line becomes "stdin is not tty"

So in order to use fzf in this scenario, you'll have to manually feed in some input to fzf through pipe. I wouldn't say that this is a bug of fzf or a bug of zsh. It's just how zsh and fzf operates.

Makes sense, thanks!
On Tue, Feb 25, 2020, 10:32 PM Junegunn Choi<EMAIL_ADDRESS>wrote:

Closed #1863 https://github.com/junegunn/fzf/issues/1863.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junegunn/fzf/issues/1863?email_source=notifications&email_token=AAGRJXEH2KQFXPMIFZW334LREUTXJA5CNFSM4KSNZWY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW33Z6UI#event-3069681489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGRJXD2DBZJGHPE5YLXPX3REUTXJANCNFSM4KSNZWYQ
.

For posterity, psprint on #zsh suggested using https://raw.githubusercontent.com/psprint/zsh-navigation-tools/master/znt-usetty-wrapper. Indeed $(zsh znt-usetty-wrapper fzf)<Tab> works exactly as expected.

I'll note here that in Zsh, $(<$TTY fzf) will tab-complete.


New category for ABNF, Regex, etc.

See #72
Regex and ABNF both fall under "data," but this isn't necessarily accurate. Perhaps "grammar" or "pattern" makes the most sense as a category?

My two cents is that "Grammar" makes the most sense, as they're both specifying a "set of things that can be matched". This probably wouldn't be super familiar to your layperson, though, so I don't think "Pattern" would be that bad either.

Thanks for the input! I do like "grammar" myself. If/when this project gets sufficient usage, perhaps I'll put out a poll.


Fix src dir support

Closes #1
Tested locally, did not add to CI but we could

Self-merging @tmeasday


feat: The modal sheet for the 4 main photos with the date

Hi everyone!
The date of the 4 main photos was not accessible from the gallery.
It's now accessible via a long-press:

FYI, in French, the separator is wrongly translated, hence the missing space.

Codecov Report
Attention: Patch coverage is 2.17391% with 90 lines in your changes missing coverage. Please review.

Project coverage is 6.53%. Comparing base (4d9c7fc) to head (ce63f84).
Report is 533 commits behind head on develop.

Files with missing lines
Patch %
Lines

.../gallery_view/product_image_gallery_photo_row.dart
0.00%
78 Missing :warning:

...generic_lib/bottom_sheets/smooth_bottom_sheet.dart
9.09%
10 Missing :warning:

packages/smooth_app/lib/resources/app_icons.dart
33.33%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5957      +/-   ##
==========================================
- Coverage     9.54%   6.53%   -3.02%
==========================================
  Files          325     440     +115
  Lines        16411   24836    +8425
==========================================
+ Hits          1567    1623      +56
- Misses       14844   23213    +8369

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


View controller: Send layout traits for component appear/disappear

This change makes HUBViewController send a component’s layout traits to its delegate as part of the methods called whenever a component is either about to appear, or just disappeared from the screen.
The reason for this change is that we want to enable API users to make decisions based on the layout traits, instead of resorting to comparing view frames (which are bound to change during the layout cycle).

@spotify/objc-dev

Current coverage is 92.90% (diff: 100%)

Merging #106 into master will increase coverage by 0.08%

@@             master       #106   diff @@
==========================================
  Files            58         58
  Lines          4038       4057    +19
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3748       3769    +21
+ Misses          290        288     -2
  Partials          0          0

Powered by Codecov. Last update e9d6522...926c98b

👍


feat(httpserver):  add new router

benchmark
Preparing
(4core/32GB/) * 4

Name
port
vm
version

ordered-v1
10080
vm1
main(golang 1.18.7)

ordered-v2
10080
vm2
feat/router(golang 1.18.7)

radixtree
10080
vm3
feat/router(golang 1.18.7)

hey
-
vm4
v0.1.4

case
Start up the easegress server on vm1, vm2, vm3 and create the mock-pipeline
egctl object create -f eg-router-benchmark/static/mock-pipe.yaml

Summary
The performance of ordered-v1 and ordered-v2 is basically the same, and the performance of radixtree is much better than them.
static: radixtree is about 3 times the performance of ordered
prefix: radixtree is about 3 times the performance of ordered
regexp: radixtree is about 40 times the performance of ordered
static
The test case for static routes will create 10000 routes with md5 values from 1 to 10000, and test requests will be accessed using md5 values of 5000.
1. ordered-v1
vm1:
egctl object create -f eg-router-benchmark/static/order.yaml

stress test
vm4:
url:  http://vm-1:10080/a35fe7f7fe8217b4369a0af4244d1fca
eg: ./hey -n 900 -c 50 -m GET http://vm-1:10080/a35fe7f7fe8217b4369a0af4244d1fca

requests
concurrency
tps

900
50
24068.3219

90000
100
26077.3742

90000
120
27219.1946

2. ordered-v2
vm2:
egctl object create -f eg-router-benchmark/static/order.yaml

stress test
vm4:
url:  http://vm-2:10080/a35fe7f7fe8217b4369a0af4244d1fca
eg: ./hey -n 900 -c 50 -m GET http://vm-2:10080/a35fe7f7fe8217b4369a0af4244d1fca

requests
concurrency
tps

900
50
25078.4517

90000
100
27391.6867

90000
120
27401.6701

3. radixtree
vm3:
egctl object create -f eg-router-benchmark/static/redixtree.yaml

stress test
vm4:
url:  http://vm-3:10080/a35fe7f7fe8217b4369a0af4244d1fca
eg: ./hey -n 900 -c 50 -m GET http://vm-3:10080/a35fe7f7fe8217b4369a0af4244d1fca

requests
concurrency
tps

900
50
41687.5741

90000
100
65122.1171

90000
120
65638.4786

prefix
The test case for prefix-matching routes will create 10000 routes with md5 values from 1 to 10000, and test requests will be accessed using md5 values of 5000
1. ordered-v1
vm1:
egctl object create -f eg-router-benchmark/prefix/order.yaml

stress test
vm4:
url:  http://vm-1:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix
eg: ./hey -n 900 -c 50 -m GET http://vm-1:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix

requests
concurrency
tps

900
50
22110.7111

90000
100
26023.5309

90000
120
26016.2430

2. ordered-v2
vm2:
egctl object create -f eg-router-benchmark/prefix/order.yaml

stress test
vm4:
url:  http://vm-2:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix
eg: ./hey -n 900 -c 50 -m GET http://vm-2:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix

requests
concurrency
tps

900
50
25449.3521

90000
100
28119.3687

90000
120
27882.9445

3. radixtree
vm3:
egctl object create -f eg-router-benchmark/prefix/redixtree.yaml

stress test
vm4:
url:  http://vm-3:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix
eg: ./hey -n 900 -c 50 -m GET http://vm-3:10080/a35fe7f7fe8217b4369a0af4244d1fca/suffix

requests
concurrency
tps

900
50
36541.2653

90000
100
58698.0033

90000
120
65060.4261

regexp
The test case for regular matching routes will create 10000 RESTful style routes with the template /users/{username}/<i> and the test requests will be accessed using the md5 value of 5000
1. ordered-v1
vm1:
egctl object create -f eg-router-benchmark/regexp/order.yaml

stress test
vm4:
url:  http://vm-1:10080/users/aniaan/5000
eg: ./hey -n 900 -c 50 -m GET http://vm-1:10080/users/aniaan/5000

requests
concurrency
tps

900
50
1769.1021

90000
100
1743.7057

90000
120
1743.2940

2. ordered-v2
vm2:
egctl object create -f eg-router-benchmark/regexp/order.yaml

stress test
vm4:
url:  http://vm-2:10080/users/aniaan/5000
eg: ./hey -n 900 -c 50 -m GET http://vm-2:10080/users/aniaan/5000

requests
concurrency
tps

900
50
1733.3634

90000
100
1707.0785

90000
120
1686.6228

2. radixtree
vm3:
egctl object create -f eg-router-benchmark/regexp/radixtree.yaml

stress test
vm4:
url:  http://vm-3:10080/users/aniaan/5000
eg: ./hey -n 900 -c 50 -m GET http://vm-3:10080/users/aniaan/5000

requests
concurrency
tps

900
50
38619.2734

90000
100
66155.8978

90000
120
66357.7316

Codecov Report
Base: 76.86% // Head: 76.84% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (2c97631) compared to base (6681fac).
Patch coverage: 84.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   76.86%   76.84%   -0.02%
==========================================
  Files         103      108       +5
  Lines       11579    12197     +618
==========================================
+ Hits         8900     9373     +473
- Misses       2172     2299     +127
- Partials      507      525      +18

Impacted Files
Coverage Δ

pkg/object/httpserver/spec.go
76.19% <ø> (+1.19%)
:arrow_up:

pkg/protocols/httpprot/request.go
74.33% <9.09%> (-5.99%)
:arrow_down:

pkg/object/httpserver/routers/routers.go
39.13% <39.13%> (ø)

pkg/object/httpserver/routers/spec.go
74.70% <74.70%> (ø)

pkg/object/httpserver/routers/order/router.go
77.50% <77.50%> (ø)

pkg/object/httpserver/mux.go
80.28% <92.68%> (-6.93%)
:arrow_down:

pkg/object/httpserver/routers/art/router.go
93.86% <93.86%> (ø)

pkg/object/httpserver/runtime.go
58.63% <100.00%> (ø)

pkg/util/ipfilter/ipfilter.go
62.19% <100.00%> (ø)

pkg/filters/proxy/pool.go
79.17% <0.00%> (-0.88%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

If a request path match several rules, should we give the result by the order in definition?
For example
...
routerKind: RadixTree
rules:
  - paths:
    - path: /user/{username}/123
      backend: h1
    - path: /user/wang/{num}
      backend: h2
    - path: /{type}/wang/123
      backend: h3
...

for path /user/wang/123 it match all three paths, should we return the first one define in yaml file, which should be /user/{username}/123? currently it returns /user/wang/{num}...

Is rules like "/123/123/123/123{name}" allowed? Is not allowed, you may need add some validation for the parameter match...

This is allowed

/user/wang/{num}

This is because the matching order of the prefix tree is decided, full path -> regexp path -> parameter path -> prefix path, so it will return /user/wang/{num}, RadixTree, compared with Ordered, is lost its definition order, so the user needs to understand the rules of RadixTree before using RadixTree.

ok, know i fully understand this, is this case, match order is /user/wang/{num} > /user/{username}/123 > /{type}/wang/123 for /user/wang/123.
So if a path matches several rules, we can split a path into chars, for every char follow the order of full path -> regexp path -> parameter path -> prefix path.
...
routerKind: RadixTree
rules:
  - paths:
    - path: /users/{u:[a-z]+}sername/hovercard
      backend: h1
    - path: /users/u{sername}/hovercard
      backend: h2
...

so in this case, /users/username/hovercard will match /users/u{sername}/hovercard.
Very amazing work, so could you please update the doc, maybe add more examples to show this char level matching priority? there maybe some users make the same mistake like me.

ok, know i fully understand this, is this case, match order is /user/wang/{num} > /user/{username}/123 > /{type}/wang/123 for /user/wang/123.
So if a path matches several rules, we can split a path into chars, for every char follow the order of full path -> regexp path -> parameter path -> prefix path.
...
routerKind: RadixTree
rules:
  - paths:
    - path: /users/{u:[a-z]+}sername/hovercard
      backend: h1
    - path: /users/u{sername}/hovercard
      backend: h2
...

so in this case, /users/username/hovercard will match /users/u{sername}/hovercard.
Very amazing work, so could you please update the doc, maybe add more examples to show this char level matching priority? there maybe some users make the same mistake like me.

The document has been updated, you can re-read it


ServiceAccountName not being specified in Pipelinerun on Openshift console.

When starting a pipelinerun through the Openshift CLI I have specified the necessary serviceAccountName to required my to pull the necessary docker images.
 resources:
    - name: git-source
      resourceRef:
        name: nodejs-repo
  serviceAccountName: pipelinerunner

However when I start the pipeline again through the Openshift console It seems to ignore the previously specified serviceAccountName and overwrite this with a default name.
  resources:
    - name: git-source
      resourceRef:
        name: nodejs-repo
  serviceAccountName: pipeline

Is there a way to specify the serviceAccountName in the console when deploying a pipeline instead of using the CLI?

@Homopatrol Currently we do not have an option to specify the serviceAccountName while starting the pipeline from web console.
However if you have created a pipelinerun through the Openshift CLI and added your serviceaccount, then from the UI you have an option to start last run, which will reuse the serviceaccount you referenced in earlier run.

@Homopatrol Currently we do not have an option to specify the serviceAccountName while starting the pipeline from web console.
However if you have created a pipelinerun through the Openshift CLI and added your serviceaccount, then from the UI you have an option to start last run, which will reuse the serviceaccount you referenced in earlier run.

@karthikjeeyar Thanks for clearing this up.
Is this on the roadmap to be included in later updates? If not could I request it be since it would allow pipelines to be deployed with less errors in the future.

@karthikjeeyar Thanks for clearing this up.
Is this on the roadmap to be included in later updates? If not could I request it be since it would allow pipelines to be deployed with less errors in the future.

Agreed, this will definitely improve the user experience. Thanks @Homopatrol for bringing this up, This will be included in upcoming release .

Agreed, this will definitely improve the user experience. Thanks @Homopatrol for bringing this up, This will be included in upcoming release .


Make use of doctrine/instantiator

Hopefully this will make things a little easier going forward, phpunit are already using it and of course doctrine

Closing this in favour of #403 for now, may revisit at a later date


update transform-vue-jsx to 4.0.1

for Babel 7

Can you update the lockfile as well?

@egoist o la...

Is there a release coming with this? Currently the version on npm uses<EMAIL_ADDRESS>

Can we publish a new release to have this babel-plugin-transform-vue-jsx version upgraded?


feat(fibery): Fibery Integration

Add integration to fibery.io, a work management platform by targetprocess
closes #1411

@nmrony The popup's styling should be fixed once you rebase the branch on latest master
(fixed in #1425)
So just fixing the descripitionElement's calculation should make this ready to ship

@shantanuraj Awesome I am on it.

@shantanuraj I have pushed fixing the descriptor selector elements. Thanks for your cool suggestions. While applying realised that, $('.HeaderLayout textarea', $container) is enough for getting description from all wiki, tutorials, task items, work items. I have rebased master into my branch and seems like the popup issue is gone. Adding some snaps for your convenience

@nmrony thanks for your contribution 🙌
We'll release this in the next update (most probably on Monday)


maya omm-status command places the " m-apiserver listening at http://ip:port" output line in STDERR instead of STDOUT

An ansible playbook command to print details of maya installation, when run with verbose logging showed the following :
changed: [localhost -> None] => {
"changed": true,
"cmd": "source ~/.profile; maya omm-status",
"delta": "0:00:00.033736",
"end": "2017-05-29 11:53:07.946624",
"invocation": {
"module_args": {
"_raw_params": "source ~/.profile; maya omm-status",
"_uses_shell": true,
"chdir": null,
"creates": null,
"executable": "/bin/bash",
"removes": null,
"warn": true
}
},
"rc": 0,
"start": "2017-05-29 11:53:07.912888",
"stderr": "mesg: ttyname failed: Inappropriate ioctl for device\n\nm-apiserver listening at http://<IP_ADDRESS>:5656",
"stderr_lines": [
"mesg: ttyname failed: Inappropriate ioctl for device",
"",
"m-apiserver listening at http://<IP_ADDRESS>:5656"
],
"stdout": "Name               Address      Port  Status  Leader  Protocol  Build  Datacenter  Region\nMayaMaster.global  <IP_ADDRESS>  4648  alive   true    2         0.5.5  dc1         global",
"stdout_lines": [
"Name               Address      Port  Status  Leader  Protocol  Build  Datacenter  Region",
"MayaMaster.global  <IP_ADDRESS>  4648  alive   true    2         0.5.5  dc1         global"
]
}
Ideally, this should also be part of stdout

This was the part of checking the return status code but inside the Error print statement.
Now changed to 'Sprintf' which will be stdout result for the status command.

This code has been deprecated.


Fix examples, fixes #1331

All work well!
I would propose that in the pedestal calibration example we mode the plotting command inside the for cycle.
There are many other examples that work in the same way and it it sufficient to ctrl-c to exit.
At least the user sees something :)

It think you can remove calc_pedestals.py - it doesn't use the real pedestal calculation I think (and calib/pedestals.py doesn't even exist anymore)

It think you can remove calc_pedestals.py - it doesn't use the real pedestal calculation I think (and calib/pedestals.py doesn't even exist anymore)

it uses ctapipe.calib.camera.pedestals

For the test data there is this issue: https://github.com/cta-observatory/ctapipe/issues/558

For the test data there is this issue: #558

yes using (even the same) 2/3 events for every test that uses data is a good alternative that won't need to implement any additional interactive code in the examples

yes using (even the same) 2/3 events for every test that uses data is a good alternative that won't need to implement any additional interactive code in the examples

it's already mostly like that.  I think we can ignore this for this release.

Sure! this PR was not really urgent, it was just triggered by a clean installation I tried to play with the DL1 writer...
We can leave this for later if you want.
What to we want to do with the pedestal example?

What to we want to do with the pedestal example?

It's ok now that it uses the correct method at least. We can improve it later

@HealthyPear Could you make clear what changes you requested? Given that the example about pedestals states pretty clearly how to get the plots for all events, I would leave it like it is.

@HealthyPear Could you make clear what changes you requested? Given that the example about pedestals states pretty clearly how to get the plots for all events, I would leave it like it is.

It was just to make it more direct and useful for an eventual user: right now the last event (which is what the script plots) gives an empty plot.
I was suggesting to place the plotting command inside the events cycle (which is the case anyway for many other examples), so at least we show something without the need for the user to modify the script.

@HealthyPear I added a check for num_samples > 1 so that the plot shows an image and no nans are reported on the command line.
@kosack please review again


Update a connection in CRM

Describe the task

[ ] Update the existing connection in CRM

References

Refer to laravel docs

This needs more details. Will come back with more requirements.


Rotate should use next threshold as default value

When building the next state for rotation it uses the current threshold state.kt to build the next state.
https://github.com/WebOfTrust/signify-ts/blob/2a95620742a5a28cb1d27468e13a1597b3cc08dd/src/keri/app/aiding.ts#L296
If I'm understanding the rotation logic correctly it should use the let isith = state.nt instead?
If this is the only place we build a new state the fix is easy.
But I'm not that up to speed of the entire code base. Are there more places?
When looking at signifypy they seem to have the same bug.
https://github.com/WebOfTrust/signifypy/blob/8f086a60ad15d81a78dfc3653af9e1fa5f775ac1/src/signify/app/aiding.py#L133
However Keri seems to use the next threshold when building the state.
https://github.com/WebOfTrust/keripy/blob/67eece0c00be7318f01bdf507621824e45c03bca/src/keri/app/habbing.py#L1219

@pfeairheller @SmithSamuelM can we get clarification on how this effects partial rotation?


Removed incorrect negation in Spanish translation

Why:
The current documentation is wrong.

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@drackp2m Thanks for opening this! ✨ Unfortunately, we are not able to accept changes for translated content. Our translation process involves an integration with an external service, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet.
See https://github.com/github/docs/blob/main/contributing/types-of-contributions.md#earth_asia-translations.
I'll open this issue internally for our partner service to review.
Thank you for your passion in improving our docs! 💖

Yes, I realized after opening the issue, so I apologize for anticipating trying to help with such a trivial problem.
I found the external translation system too complex to simply try to provide proofreading for such a small piece of text.
I'm pretty clumsy with these processes, so I left the matter unattended on my end. I'm very sorry, but thank you for taking your time to answer me.

@drackp2m No worries! We appreciate your desire to improve our docs! We have many issues open on our help wanted board if you'd like to find one of interest to you and contribute.
Thanks again! ✨


clean up compile error push to main

Changes to a branch never pushed to main
https://github.com/dnschneid/crouton/commit/2da67e629c407d960b9d383146b214e73a0a1e6a
make.txt
I also had to comment the Makefile to finish the compile with no errors
$(EXTTARGET): $(EXTSOURCES) Makefile
#rm -f $(EXTTARGET) && zip -q --junk-paths $(EXTTARGET) $(EXTSOURCES)

vscode will  not run on arm64
jupyterlab does
with the clean up changes installed and comment the make file it seem to doing just fine

somehow this is backward
clean up compile error push to main #4886
Open
TomTravis wants to merge 35 commits into findnacld_cleanup from master
should be
master  from /dnschneid/crouton/tree/findnacld_cleanup)
close and submit again

somehow this is backward
clean up compile error push to main https://github.com/dnschneid/crouton/pull/4886
Open
TomTravis wants to merge 35 commits into findnacld_cleanup from master
should be
master from /dnschneid/crouton/tree/findnacld_cleanup)
close and submit again


Fix live score

The name and the logos on the live score is not working well, for example today's match is Falcons vs Eagles and the live score is showing that today the match is miami dolphines vs bills.

done


Collector::~Collector was called from non-main thread

I just had this once in the Unity Editor: The Collector destructor has apparently been called from a thread other than the Unity main thread. I do some multithreading in my app and maybe the GC got triggered from a background thread. Since it gets triggered by the GC, I don't think we have any control over which thread this call comes from?
In my specific case, the destructor called deactivate, which in turn released some entities which then got destroyed, which triggered an OnComponentRemoved callback which attempted to remove a unity gameobject in my code, which didn't work because GameObject manipulation is only allowed on the main thread.

That's a good find!
The destructor deactivates the collector as a last resort to avoid leaks if the user didn't clean up.
Is it possible for you to clean up (deactivate) the collector manually at a controlled point of time from the mainthread instead?

That's the thing. It happened only once, in the Unity Editor. I have no clue which collector that was and why it didn't get cleaned up. I don't use collectors outside of the ones needed for reactive systems and I don't destroy/remove systems at all. Does the Visual Debugging code create additional collectors maybe?
I think the collector destructors should log an error and report a leak instead of silently cleaning up after the user in this case. The intention is good but Deactivating a collector undeterministically will eventually lead to other problems even outside of threading scenarios.

Reminder and Note to myself:
Can reproduce sth similar in Tests/Unity/VisualDebugging/Assets/Tests/Manual Tests/ReactiveSystem Destructor
get_gameObject can only be called from the main thread.
Constructors and field initializers will be executed from the loading thread when loading a scene.
Don't use this function in the constructor or field initializers, instead move initialization code to the Awake or Start function.
UnityEngine.Component:get_gameObject()
Entitas.VisualDebugging.Unity.EntityBehaviour:onEntityReleased(IEntity)
Entitas.Entity:Release(Object)
Entitas.Collector`1:ClearCollectedEntities()
Entitas.Collector`1:Deactivate()
Entitas.ReactiveSystem`1:Deactivate()
Entitas.ReactiveSystem`1:Finalize()

Will close, this can only happen in the Unity Editor but never in a release build.


add callerid information to tablet errors, when TerseErrors is false

Fixes: #3016
@bbeaudreault
@alainjobart

LGTM. Can you add a test case for it with a dummy caller id?
I'll pull this into our internal tablets tomorrow. Will leave it up to @alainjobart with regards to the formatting of the log.

we can see what it looks like from the failing test on travis:
compatibility_test.go:742: Error: (callerid dev) Data too long for column 'vb' at row 1 (errno 1406) (sqlstate 22001) during query: insert into vitess_strings(vb) values ('12345678901234567') /* _stream vitess_strings (vb ) ('MTIzNDU2Nzg5MDEyMzQ1Njc=' ); */, want Data too long
test fixes incoming

@sougou or @alainjobart can you guys comment on the formatting? I see parenthesis are used for other metadata, but the new commit uses square brackets. Also wonder where in the string is best to place it.
This has been running in our environment for a few days and looks fine other than that.

when TerseErrors is turned on, i can easily make the caller id part of the error sit next to errno and sqlstate, (and of course use parens and downcase to make it look similar). when TerseErrors is turned off, to get the same placement, i'd have to do some silly regex thing to get "(callerid foo)" to sit in the right place.
i opted not to mess around with regexes here, and do something that:

looked clearly different, so we know (if we care) that this is inserted by vitess, not coming from mysql
necessitated the modification of the fewest tests

i don't feel super strongly about any of this though, so if people have opinions, def chime in.

will leave that up to @sougou or @alainjobart -- unrelated note:
I noticed that in convertError we only apply this new formatting if the error is of type *mysql.SQLError). That check makes sense for the other context added here. But we should add the callerId in either case. Can you add the callerid to the if branch at the top of convertError?

Two things:

anyone know why travis isn't being shown here?
i've made vterrors.Suffix not do anything to a non-vtError, b/c in order to do so i'd have to make a new error and just pull in the msg from the given error, thus throwing away any special metadata the thrower might have included

i think i own the tabletserver test failure. fix incoming

acharis@ wrote:

anyone know why travis isn't being shown here?

No, I cannot explain it.
Travis still gets triggered, so all the webhooks are working.
I sent a message to GitHub about this. So far they haven't replied yet.

This looks good to me. Are you still doing work on this? If you're done, I can merge.

i'm done. i think the remaining travis failures are flakiness


Check JS env for react 16

https://gist.github.com/gaearon/9a4d54653ae9c50af6c54b4e0e56b583#javascript-environment-requirements
Also add a check for support in legacy browsers, if not load in the polyill

https://github.com/michaelBenin/react-ssr-spa/commit/1e76fa18233be37ce2af0904d2e390c509a1f132


Expose no_stale_markers through vm_scrape_params

Small attempt to implement VictoriaMetrics/VictoriaMetrics#3292 myself.
Gave it a shot by deploying
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMStaticScrape
metadata:
  name: no-stale-marker-test
spec:
  targetEndpoints:
  - path: /metrics
    targets:
    - test.de:1234
    vm_scrape_params:
      no_stale_markers: false

and got
scrape_configs:
...
- job_name: staticScrape/default/no-stale-marker-test/0
  metrics_path: /metrics
  static_configs:
  - targets:
    - test.de:1234
  no_stale_markers: false

in my VMAgent's config.

Thanks for contribution!


Add snippet tag

Snippet will be referenced from Use a keyword model with the Speech SDK.

@rhurey @dargilco - can you please merge?


'--imdb_name', dest='imdb_name',  "imdb"   means?

Hello, could you tell me what imdb means?

the definition of imdb is just the same with https://github.com/rbgirshick/py-faster-rcnn


Ensure that all migration requests are cancellable

When doing any requests in migration we should set the context for these requests to ensure that they are cancellable.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #12669 into master will decrease coverage by 0.03%.
The diff coverage is 12.12%.

@@            Coverage Diff             @@
##           master   #12669      +/-   ##
==========================================
- Coverage   43.31%   43.28%   -0.04%
==========================================
  Files         646      646
  Lines       71588    71624      +36
==========================================
- Hits        31010    31001       -9
- Misses      35569    35608      +39
- Partials     5009     5015       +6

Impacted Files
Coverage Δ

modules/migrations/gitlab.go
1.13% <0.00%> (-0.02%)
:arrow_down:

modules/migrations/base/downloader.go
17.64% <5.12%> (-5.72%)
:arrow_down:

modules/migrations/github.go
83.36% <100.00%> (-0.41%)
:arrow_down:

modules/migrations/migrate.go
23.95% <100.00%> (-0.46%)
:arrow_down:

modules/sync/unique_queue.go
38.77% <0.00%> (-6.13%)
:arrow_down:

services/pull/update.go
51.92% <0.00%> (-5.77%)
:arrow_down:

modules/migrations/git.go
43.33% <0.00%> (-3.34%)
:arrow_down:

services/pull/temp_repo.go
26.59% <0.00%> (-3.20%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.54%)
:arrow_down:

cmd/serv.go
2.08% <0.00%> (-0.78%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807a41c...dcb8986. Read the comment docs.


fix: Reduce svg assets size

Description
reduced svgs file size for : -
(these files are in src/assets)
voice_icon from 10.26kb to 7.30kb
chat_icon from 24.53kb to 16.13kb
audio_icon from 5.30kb to 3.96kb
file_attachment_icon from 4.13kb to 3.08kb
notification_icon from 4.61kb to 3.49kb
I wasn't able to compress WAV file
Closes #21
What change does this PR introduce?
reduced svg file sizes to make the package smaller
Please select the relevant option(s).

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (changes to docs/code comments)

What is the proposed approach?
Please give a short overview/explanation on the approach taken to resolve the issue(s).
used an online svg compressor to compress the images
Checklist:

[ ] The commit message follows our adopted guidelines
[ ] Testing has been done for the change(s) added (for bug fixes/features)
[ ] Relevant comments/docs have been added/updated (for bug fixes/features)

LGTM, thanks!

that's great! :)


Create API endpoints

In this milestone I created API endpoints for performing the following requests:

List all posts for a user.
List all comments for a user's post.
Add a comment to a post.

Hi @Tshobohwa,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that doesn't have contributions from your coding partner. The commits I see here are not from your coding partner. Kindly contact your coding partner and work with them or contact student success.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


added test_make_job_object to test_utils

Hi @JuriBog
thanks for your contribution! Can you run fix the formatting issues on your code, then we can see if the tests actually work :)

Very nice,
if you would remove the unrelated changes in docs and  .gitignore, this would be ready to merge.
@piontec WDYT?


Feature/exclude sensors

Closes #79 and closes #161

Hello! Thank you for the amazing plugin. I have just added an accessory to the exclude list and verified I'm using the right serial number (both in the SS app and Home) but it still is exposed. Is there a regression or is there something I need to do differently?
        {             "name": "Simplisafe",             "cameras": false,             "debug": false,             "sensorRefresh": 15,             "persistAccessories": true,             "cameraOptions": {                 "enableHwaccelRpi": false             },             "excludedDevices": [                 "018037a3"             ],             "_bridge": {                 "username": "0E:E6:B3:E3:39:EB",                 "port": 49794             },             "platform": "homebridge-simplisafe3.SimpliSafe 3"         }

If you’ve already set things up you’ll want to remove that accessory (by default the plug-in prevents this with the persistAccessories setting to avoid mistakenly losing things)


Document possible integration with miniredis for unit testing

Library can be easily used with miniredis for unit testing.
I think it's worth mentioning in Readme
Example:
package main

import (
	"github.com/alicebob/miniredis"
	"github.com/go-redis/redis"
	"fmt"
	"os"
)

func main() {
	mini, err := miniredis.Run()
	if err != nil {
		fmt.Println(err)
		os.Exit(1)
	}

	goredis := redis.NewClient(&redis.Options{
		Addr:mini.Addr(),
	})
	fmt.Println(mini.Addr())

	data, err := goredis.Set("test", "Zażółć gęślą jaźń", 0).Result()
	fmt.Println(data, err)

	resp, err := goredis.Get("test").Result()
	fmt.Println(resp, err)
}

Sounds good - do you want to send a PR?

This is neat, and very helpful. I'll try to get to prepare a PR for this in a few days. Thanks @piotr-srebniak-limango


Make arguments 'a', 'alias' and 'arch' consistent

Currently -a is synonymous with -arch for dnvm use, but -a is synonymous with -alias for dnvm install. This is confusing for someone like myself who skim-reads the help text. :smile:
This makes them the same for each, changing -a on dnvm install to be
synonymous with -arch.
This also adds -arch to the help text for dnvm use.

Hi @yaakov-h, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Hi @yaakov-h, can you make this change in the DNVM repo? The copy of DNVM here is the output of a build rather than the source that we modify.

Whoops, I didn't know there was a DNVM repo! I thought it was a little bit quiet here...


select! after(timeout) invalid

rust version: nightly-2020-12-31-x86_64-apple-darwin
crossbeam-channel version: 0.5.0
code
use crossbeam_channel::{after, select, Receiver};
use crossbeam_utils::thread;
use std::time::Duration;

fn recv_data(receicer: Receiver<i64>, thread_no: i32) {
    loop {
        select! {
            recv(receicer) -> num => {
                match num {
                    Ok(n) => println!("thread {}, num: {}", thread_no, n),
                    Err(e) => {
                        if receicer.is_empty() {
                            println!("empty quit. thread {}", thread_no);
                            break;
                        }
                        println!("receive error: {}", e.to_string());
                    }
                };
            }
        }
    }
}

#[test]
fn timeout_quit_test() {
    // set timeout 2 seconds
    let timeout = after(Duration::from_secs(2));
    let (sender, receiver) = crossbeam_channel::unbounded();

    thread::scope(|scope| {
        for i in 0..1 {
            let c_reveicer = receiver.clone();
            scope.spawn(move |_| recv_data(c_reveicer, i));
        }

        scope.spawn(move |_| {
            for i in 0..5000000000 {
                select! {
                    recv(timeout) -> _ => {
                        println!("timeout quit sender. {}", i);
                        break;
                    },
                    send(sender, i) -> _ => {},
                }
            }
        });
    })
    .unwrap();
}

timeout in sender select. I deliberately put the code that receives the timeout message first(this is required under golang). But after 2 seconds it still won’t timeout.
add sleep in loop, can timeout normally
code:
use crossbeam_channel::{after, select, Receiver};
use crossbeam_utils::thread;
use std::thread::sleep;
use std::time::Duration;

fn recv_data(receicer: Receiver<i64>, thread_no: i32) {
    loop {
        select! {
            recv(receicer) -> num => {
                match num {
                    Ok(n) => println!("thread {}, num: {}", thread_no, n),
                    Err(e) => {
                        if receicer.is_empty() {
                            println!("empty quit. thread {}", thread_no);
                            break;
                        }
                        println!("receive error: {}", e.to_string());
                    }
                };
            }
        }
    }
}

#[test]
fn timeout_quit_test() {
    let timeout = after(Duration::from_secs(2));
    let (sender, receiver) = crossbeam_channel::unbounded();

    thread::scope(|scope| {
        for i in 0..1 {
            let c_reveicer = receiver.clone();
            scope.spawn(move |_| recv_data(c_reveicer, i));
        }

        scope.spawn(move |_| {
            for i in 0..5000000000 {
                select! {
                    recv(timeout) -> _ => {
                        println!("timeout quit sender. {}", i);
                        break;
                    },
                    send(sender, i) -> _ => {},
                }

                // sleep here
                sleep(Duration::from_millis(500));
            }
        });
    })
    .unwrap();
}

output
thread 0, num: 0
thread 0, num: 1
thread 0, num: 2
thread 0, num: 3
timeout quit sender. 4
empty quit. thread 0

The reason for this may be because the timeout code cannot get a piece of cpu time, but I think rust should solve this problem. After all, golang does not have such a problem

Can you try with this line commented out: https://github.com/crossbeam-rs/crossbeam/blob/06d77d35ce7165f04d7027608a99331a2e3e0f9c/crossbeam-channel/src/select.rs#L193

The code works as written, but probably doesn't reflect your expectations.

You can see that the timeout has triggered and the sender thread has exited. However, as you can see i = 31000654 as the thread exists which is way higher than the reader thread which lags far behind. Now the reason is kinda obvious by now that you are printing to stdout for each received element which takes somewhat longer than just receiving and dropping the value.
You can try commenting out the receivers println and you will observe that the first example exits just fine in time.

Thanks @cynecx , you are right, i change receiver code, remove println! program quit normally.
change recv_data function code to
fn recv_data(receicer: Receiver<i64>, thread_no: i32) {
    loop {
        select! {
            recv(receicer) -> num => {
                match num {
                    Ok(n) => println!("thread {}, num: {}", thread_no, n),
                    Err(e) => {
                        if receicer.is_empty() {
                            println!("empty quit. thread {}", thread_no);
                            break;
                        }
                        println!("receive error: {}", e.to_string());
                    }
                };
            }
        }
    }
}

output
timeout quit sender. 2329225
empty quit. thread 0


Corrected link. The old link was giving 404 error.

Hello, this should be resolved or addressed in Unirest 2. Please see the upgrade guide for important changes.
I merged in another Fork to supply this and the code is now drastically different so this can't merge anyway. In any case thank you so much for your time and patience. I hope as one of the new maintainers we can more responsive in the future.


Keyboard coveres textfield

Hi. I am facing the issue that the keyboard is not following the input toolbar. I am calling [super viewDidAppear] ... and nothing changes.
Moreover, i removed the code where [super viewDidAppear] is called from the demo, and the keyboard is working perfectly without this method:

(void)viewDidAppear:(BOOL)animated
{
[super viewDidAppear:animated];
/**

Enable/disable springy bubbles, default is NO.
You must set this from viewDidAppear:
Note: this feature is mostly stable, but still experimental
*/
//self.collectionView.collectionViewLayout.springinessEnabled = [NSUserDefaults springinessSetting];
}

I know this is a duplicate, but in my case, the proposed solution is not solving my problem.
Other possible solutions?
In iOS 8, in every simulator size.

Hey @SimonaMilchevska :smile:
You should be calling super on all view lifecycle methods.

Hi,
my code is exactly the same like the code from the demo project. Still in the demo works perfectly, in project the keyboard behaves different.

- (void)keyboardController:(JSQMessagesKeyboardController *)keyboardController keyboardDidChangeFrame:(CGRect)keyboardFrame
{
    if (![self.inputToolbar.contentView.textView isFirstResponder] &&     self.toolbarBottomLayoutGuide.constant == 0.0f) {
        return;
 }

    CGFloat heightFromBottom = CGRectGetMaxY(self.collectionView.frame) -     CGRectGetMinY(keyboardFrame);

    heightFromBottom = MAX(0.0f, heightFromBottom + 40);  <----- here

    [self jsq_setToolbarBottomLayoutGuideConstant:heightFromBottom];
 }

heightFromBottom = MAX(0.0f, heightFromBottom + 40);  added +40 here. Is this telling you something, what can be causing the issue?

ok, now i got it. Once i did some changes on the JSQMessagesViewController and the constraints where messed up :)
Problem solved! :+1:

"You should be calling super on all view lifecycle methods." solved my problem.
Added scrollToBottomAnimated in viewDidAppear, but didn't called super.viewDidAppear(animated).
Thx Jesse

Hey. Even I've the same issue. I'm calling super on every life cycle methods and I'm still not able to solve this? can someone please help?
I noticed the textview gets hidden only when I open the app from notification & otherwise it works like charm. Really weird.


configured routing to recognize json extension

I seems to be necessary to configure the json-extension in the routes.php of the plugin, even if you have it configured in the routes.php of your app. Otherwise this route: /oauth/access_token.json will not be recognized.

Our server application declares .json in the core routes file, which is why we never picked this up. Thanks :+1:


Alpha API Audit

This issue is an umbrella issue and a blocker for the alpha release. It aims to act as an audit to ensure that the mentioned APIs below are feature complete and not missing functionality (as this has on occasion caused me embarassment when I go to show something and realize that the code has been temporarily disabled due to a bug elsewhere)
Luckily, having this umbrella issue will allow us to also know what general documentation for a given section must be written.
APIs
Dict API
Some work is needed to also add the ability to deserialize an IXM file onto any set_property(<type>). This will let us deserialize IXM files into add_test calls as desired.

[ ] LOAD/SAVE (Deserialize and Serialize to and from the IXM format)
[ ] JSON (Serialize a dictionary to the JSON format) -- Honestly, this should be removed.
[ ] APPEND/ASSIGN/CONCAT (Modify values within the dictionary)
[ ] REMOVE/CLEAR (Remove specific key-values. Completely empty the dictionary)
[ ] KEYS (Return a list of all keys in the dictionary)
[ ] GET (Return the value associated with a key in a dictionary)
[ ] TRANSFORM Equivalent to the cmake list(TRANSFORM) subcommand, but operates on a key's value

Find API

[ ] FRAMEWORK -- Can find an Apple Framework library. Versions are not taken into account
[ ] PROGRAM -- Can find an executable program, and optionally its version
[ ] LIBRARY -- Can find a library (static or shared) and possibly its version
[ ] INCLUDE -- Can find a header file, possibly its version, and create an INTERFACE library (this behavior should be placed into LIBRARY, however)

Target API
This API is still in flux and does not quite exist in a "stable" manner. The idea is to replace the target_XXX commands such that we do not need to override them while also allowing custom user defined hooks without having to break existing APIs. No idea if this will actually work well. We'll leave this section blank as #18 is still open.
Project API
These are commands related to common project settings, such as options, features, and 'optional dependencies'. Currently the existing API/Project.cmake file is an absolute mess. Better support is desperately needed :(

[ ] with() -- Build ${PROJECT_NAME} with the provided dependency if the given option is set. Generates an option named ${PROJECT_NAME}_WITH_${dependency}. If the project is a so-called top level project, a WITH_${dependency} name is generated as well.
[ ] feature() -- Build ${PROJECT_NAME}. Currently this is just an option added as ${PROJECT_NAME}_ENABLE_${feature}, however it could be expanded to do things such as automatically add lint build flags (for either the primary component or a sub-component such as docs or unit tests) and to add settings to a configure header.
[ ] workspace() -- This should be a special version of project() intended for more monolithic projects. This will then prepend the workspace name to each subproject. It'll also allow us to declare that this "workspace" is not meant to be used as a subdirectory. Though, this could lead to people assuming that a workspace based project is a "bad actor" in the world of CMake.

Logging API
The logging API is working fairly well. A few options should be dropped to work better with CMake's newer --log-level settings, but otherwise it's going very well. One thing that is still needed is

Knowing when to "cycle" a logging file (something that should be handled only on configure start, not after)
Require JSONL support to be explicitly enabled via a cache variable. This speeds up logging tremendously per message.
Better detection of when to print color output or not. If there was a way to detect if we're on the Windows Terminal vs a default cmd.exe or pwsh.exe instance, we should use that. This detection should be placed in the prelude file.

Otherwise, we'll leave this section blank for now.
Introspection API
This API is currently used internally for the invoke() command. While dynamic command invocation is neat and all, its something that should be phased out within IXM. This means getting rid of the event API, which will be mentioned later in this issue. That said everything is working quite well, and is quite simple, though the inspect() command itself needs some love as its quite a nightmare to view at the time of this writing:
macro (inspect)
  foreach (@inspect:var ${ARGV})
    set(CMAKE_MESSAGE_INDENT "${CMAKE_MESSAGE_INDENT}${\@inspect\:var}: ")
    if (DEFINED ${\@inspect\:var})
      list(LENGTH ${\@inspect\:var} @inspect:length)
      if (@inspect:length GREATER 1)
        string(JOIN " " ${\@inspect\:var} ${${\@inspect\:var}})
      endif()
      _message("${\@inspect\:var}: ${${\@inspect\:var}}")
    else()
      _message("${\@inspect\:var}: $<UNDEFINED>")
    endif()
    void(CMAKE_MESSAGE_INDENT @inspect:var @inspect:length @inspect:prefix)
  endforeach()
endmacro()

Hopefully it can be cleaned up in time for the alpha release.
Event API
Because of its dynamic invocation internally, we need to get rid of this. It's not even used internally, except for the still in flux Target API.  :/
Import and Module API
This is kind of a mistake in hindsight. It's nice to do things like import(IXM::API::*), but at the same time only we currently use it, the behavior for it hides errors for includes, and it makes it difficult to know if a file is even being used when it might be 'optional' to begin with. Whether it exists in the alpha release or not depends on whether I have time to kill it now and I kind of hope I do.
That said, declaring a "MODULE_ROOT" isn't such a bad idea as it allows a better extension approach when adding additional libraries to support or extend IXM (such as adding tooling support or generation)
Generate API
This was basically butchered recently because of the additions made in CMake 3.16. Its still useful, as we can generate flex, bixon, protobuf (sort of... some work is needed to keep things nice and clean here because the cmake support for protobuf is a shitshow). The big point is that we can generate a response file from a target (not source files, because generator expression limitations), which makes generating source files from other tools easier! hooray!
But we still need an overhaul for this...
Fetch API
This is in DESPERATE need of an major overhaul. Current issues include

No progress bar when enabled. This can be worked around, but requires some magic on our part
No caching of multiple versions if a user desires. i.e., vendoring is always enabled and stored in the build directory. There is no reason why we can't keep the source directory in a central location (we do have some rudimentary $XDG_DATA_HOME support!) so that debug and release builds pull from the same location. With CMake 3.17 adding multi-config Ninja build support, this is important as it'll reduce pain for many users, while still allowing the vendoring of assets and better CI integration
the custom reference syntax is nice, but a more explicit syntax would be nicer. I've experimented with it a bit, but am unsure how to proceed. A LOT OF WORK is needed to get this all setup :(

Additionally CLONE should be enabled by default, and instead something like CACHE or DOWNLOAD should be an option for when you can download a package instead of just clone it via git or hg or svn or whatever.
Aspect API
I like it! It's been useful for setting certain values and keeping properties inheritable in a proper manner such that a top-level project is always in charge. However I'm unsure if users are going to enjoy it or not. Additionally, it's an important command and should be placed into API/Core.cmake.
Console API
This is fine as is. The hard part is placing everything into the prelude and keeping it readable. I'm unsure how to proceed with this portion of it.
Builtin Blueprints
Coven
This is the "recommended" blueprint for new projects, as an upgrade path will be provided when the actual coven build system is released in a few years (yes, years... I'm a busy girl). A lot of work is needed here.

[ ] Automatic documentation generation
[ ] Automatic benchmark generation
[ ] Automatic unity build generation
[ ] Automatic PCH generation for dependencies?
[ ] Automatic library/binary/interface/install files generation is needed
[ ] Custom CTestConfig.cmake file is needed. This will let us have better control over how our files are generated (in other words, we can use the IXM binary format when generating a CTest build, and also use a custom test target that actually builds the project before running the tests)
[ ] CPack support for both components as well as generating an AppImage

Brujeria
This one is much simpler, as it's ONLY used to generate a single add_library(MODULE) per project, and is intended for use with the brujeria python library. The hard part of course is making sure folks have an update to date IXM instance when building from source, but we can add some CI tooling to help ensure that.
Final Notes
IXM is currently a loose collection of ideas that need to be locked down and finalized before the "stable alpha" release. We also have a large number of deprecated modules and files that have been kept around for historical reasons. These need to be removed ASAP.
This concludes the umbrella alpha release issue (for now).

After doing a manual audit of everything in IXM, I've come to the conclusion that large bits of it need to be cut out and removed. I'll be closing this and creating a different "minimal" audit.
Sadly, a lot of the serialization and various APIs are being completely removed in favor of reducing CMake's overhead. Oh well :(


chore: update chinese locales

Update the latest translation for promptbar and fix previous translations that are no longer working.

Thanks for helping keep this up to date!


impl Debug for Device

The internal alsa, null and emscripten Device implementations already implemented Debug; but the coreaudio and wasapi ones, and therefore also the wrapper, did not.
I decided to eschew the Device(…) wrapping in the outer layer (hence a custom implementation rather than #[derive(Debug)]), because Device(Device), Device(Device { … }) and so forth all look better without the extra Device(…) wrapping.
On the wasapi and coreaudio implementations I put both the pointer and name. Name because it’s useful, pointer because on Windows at least I believe duplicated names are possible. (e.g. two monitors that include monitors, of the same type; I haven’t strictly confirmed this, because I killed those off harshly on my machine and don’t want to reinstate them.)
I do not have access to a macOS device to confirm that the coreaudio implementation is sane, but I think it is.

Ran this on macOS 10.14 and it looks good 👍
for device in cpal::devices() {
    dbg!(device);
}


Deploy to R5

 Issue by landonreed
Tuesday Aug 07, 2018 at 14:48 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/issues/234

Add option to deploy to servers running R5 (in addition to the currently supported OTP servers).
This would likely be done by starting up a new EC2 server with instructions to download a specific R5/OTP version plus the relevant GTFS feeds and OSM data and kick off the application.  This requires adding user data similar to the R5 worker script.

Closing this issue. R5 deployments are no longer supported since #519 and #638.


Wrong number of arguments passed to FastSpringException

FastSpringException's constructor takes 3 arguments, but it is called with 4 arguments in the code.
raise FastSpringException('Could not get order information', status, message, reason)

Dear John Louis Del Rosario,
We have absolutely no idea what this message means.
Please can you explain it? If there was an error, what was the URL, what parameters or arguments were sent? I hope you can help.
Best wishes,
David

David Hooper - Director - Artlogic Media Ltd.
t: 0845 838 1588  /  + 44 (0) 20 7627 0774
f: 020 8497 6555 skype: artlogicmedia
e<EMAIL_ADDRESS>w: http://www.artlogic.net
Postal address: 83 Leathwaite Road, London SW11 6RN
Office address: 28 Old Town, London SW4 0LB

To find out more about our sensational app for iPad visit https://privateviews.com
On 25 Mar 2015, at 03:17, John Louis Del Rosario wrote:

FastSpringException's constructor takes 3 arguments, but it is called with 4 arguments in the code.
raise FastSpringException('Could not get order information', status, message, reason)
�
Reply to this email directly or view it on GitHub.

Hi. Sorry for not being clear, but it seems it's fixed now :+1:

Hi John,
Thanks for your input.
Do you work for Fastspring? I don't know who you are!!
Thanks anyway.
David
On 26 Mar 2015, at 05:35, John Louis Del Rosario wrote:

Hi. Sorry for not being clear, but it seems it's fixed now
�
Reply to this email directly or view it on GitHub.


Idle Notifier - Notify immediately if someone else depletes the same vein in MLM

Would it be possible for idle notifier to notify as soon as the ore vein is depleted in MLM if multiple people are on the same vein? (Mostly helps with upstairs mining)
Currently if you deplete a vein yourself, idle notifier goes off instantly, but if there are multiple players on the same vein and someone else depletes it, your animation continues and the notification is delayed until it finishes...

The notifier is solely based on animations, which is why it behaves as you describe. There probably isn't a good way to do this that isn't overly complex.

Vein depletion can be detected by AreaSoundEffectPlayed with soundId 2661 on an adjacent tile that your character is facing.  That's the sound id for the prospect sound that plays when the vein depletes.  I am currently sound swapping that sound at calcified deposits to notify me of vein depletion, but it's not ideal, as others depleting nearby veins also trigger the sound.  If a check such as this were added to Idle Notifier, you could immediately be notified of depletion of the vein immediately in front of you.


Error: [$injector:unpr] Unknown provider

Hi,
I'm running Grafana 7.4.2 locally.
I've built a data source plugin using grafana-starter-datasource. I pointed Grafana to its dist folder.
Grafana's defaults.ini:
# Directory where grafana will automatically scan and look for plugins
plugins = C:\src\grafana-starter-datasource\dist

When I run yarn watch, everything works fine.
However, when I run yarn build (in order to build a plugin to install to remote Grafana server), my data source stops working:
FooBar Datasource plugin failed
Error: [$injector:unpr] Unknown provider: tProvider <- t http://errors.angularjs.org/1.6.9/$injector/unpr?p0=tProvider%20%3C-%20t

This seems to be because of minification.
Unminified (208 KB), result of yarn watch - works:

Minified (39 KB), result of yarn build - doesn't work:

I noticed this happening only recently.
My dependencies (package.json):
{
  "name": "simple-datasource",
  "version": "1.0.0",
  "description": "Grafana Data Source Plugin Template",
  "scripts": {
    "build": "grafana-toolkit plugin:build",
    "test": "grafana-toolkit plugin:test",
    "dev": "grafana-toolkit plugin:dev",
    "watch": "grafana-toolkit plugin:dev --watch",
    "sign": "grafana-toolkit plugin:sign"
  },
  "author": "Grafana Labs",
  "license": "Apache-2.0",
  "devDependencies": {
    "@grafana/data": "7.4.2",
    "@grafana/runtime": "7.4.2",
    "@grafana/toolkit": "7.4.2",
    "@grafana/ui": "7.4.2",
    "@testing-library/jest-dom": "5.4.0",
    "@testing-library/react": "^10.0.2",
    "@types/lodash": "latest",
  },
  "dependencies": {
    "grafana": "^1.0.1"
  }
  "engines": {
    "node": ">=14"
  }
}

@dkozar have you made any changes to the data source?
I tested with the latest version of the grafana-starter-datasource and yarn build worked fine. This is my package.json - it does not have the dependencies section that you have:
{
  "name": "simple-datasource",
  "version": "1.0.0",
  "description": "Grafana Data Source Plugin Template",
  "scripts": {
    "build": "grafana-toolkit plugin:build",
    "test": "grafana-toolkit plugin:test",
    "dev": "grafana-toolkit plugin:dev",
    "watch": "grafana-toolkit plugin:dev --watch",
    "sign": "grafana-toolkit plugin:sign",
    "start": "yarn watch"
  },
  "author": "Grafana Labs",
  "license": "Apache-2.0",
  "devDependencies": {
    "@grafana/data": "latest",
    "@grafana/toolkit": "latest",
    "@grafana/ui": "latest",
    "@types/lodash": "latest",
    "@testing-library/jest-dom": "5.4.0",
    "@testing-library/react": "^10.0.2"
  },
  "engines": {
    "node": ">=14"
  }
}

Usually this error would occur for minified code if an @ngInject annotation was missing for an Angular constructor. Example of a constructor: https://github.com/grafana/grafana/blob/main/public/app/plugins/datasource/postgres/query_ctrl.ts#L42
/** @ngInject */  constructor(    $scope: any,    $injector: auto.IInjectorService,    private templateSrv: TemplateSrv,    private uiSegmentSrv: any  ) {

But the starter data source doesn't have any Angular constructors so it must be a dependency that is causing this.
Have you tried removing the node modules and doing a yarn install --pure-lockfile?

Hi, @daniellee.
I tried both approaches, and it didn't help.
yarn install for some reason didn't work for me ("Couldn't find package "tslib" on the "npm" registry"), but I did npm install without package-lock.json and it's still the same.
As for the Angular - no Angular here, our plugin is a pure React plugin.
Here's the error message:
FooBar Datasource plugin failed
Error: [$injector:unpr] Unknown provider: tProvider <- t https://errors.angularjs.org/1.8.2/$injector/unpr?p0=tProvider%20%3C-%20t

There's nothing more specific in the console.

@dkozar can we book a session to have a look at this? I can't recreate this bug.
Which OS (Windows 10?) are you running on and which version of Node/npm?

No, that was never resolved. I was not able to figure out what causes, since there is this "disconnect" between our plugin and Grafana, which hosts the plugin. I there a way to make Grafana print out more about error?


feat: require Node.js 8.3

BREAKING CHANGE: remove support for Node.js < 8.3

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


added --throttle option

hey, dude!
take a look at the throttling option.
I think it is better to keep the default as no throttling. What do you think?

Awesome, thanks dude!
Yeah, --throttle looks good -- I can use the full speed version locally, and the throttling one when presenting! :+1:


Singularity UI 404's on direct access

With version 0.10.0, every time I directly access a UI url it shows a 404 screen. This wasn't happening with versions 0.7-0.9. When I click any link in the UI it works fine, but using the back button also results in 404's.
Example: Refreshing a page or accessing myserver.com/singularity/:

Then clicking on the go home link takes me to a working page with the same url.
Not sure if this has anything to do with my proxy settings:
singularity.yaml:
server:
  type: simple
  applicationContextPath: /singularity
  connector:
    type: http
    port: 7092

/etc/nginx/conf.d/proxy/singularity.conf:
location  /singularity {
    proxy_pass_header Server;
    proxy_set_header Host $http_host;
    proxy_redirect off;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Scheme $scheme;
    proxy_set_header X-Request-Start "${msec}";

    proxy_pass http://singularity;

    proxy_connect_timeout 55;
    proxy_read_timeout 60;
}

/etc/nginx/conf.d/upstreams/singularity.conf:
upstream singularity {
    server myserver.com:7092;
}

@jaredstehler what do you have for the ui settings portion of your config? Specifically the baseUrl field?

Opened #1238 to (hopefully) fix this.

thanks!


feat: edit plaintext body

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


added pullConfig

Added pullConfig support for private registries. https://mesosphere.github.io/marathon/docs/native-docker.html#provisioning-containers-with-the-ucr

Merged; thanks for your contribution. ❤


how to install?

How do we install this in python?

Clone seems to be the only way to go. This does not correctly install using the egg forced on pip

Sorry for the install issues;  I haven't maintained this since 2012
Planning a py3k reboot next month, though!  Supposing my priorities at work stay the same :)


Forwarder doesn't restart on momentary network outages

This is a bug report for the packet forwarder.

I am using the TTN Packet Forwarder on a MultiTech Conduit

uname -a on the Conduit: Linux ttn-nyc-1140_6th_mcci_production 3.12.27 #1 Thu May 5 18:53:23 CDT 2016 armv5tejl GNU/Linux
I am using V2.0.2 of the TTN packet forwarder.
I am using Jeff Honig's Ansible provisioner for Condit, which does the work to convert the release into an .ipk file.

I use /etc/init.d/ttn-pkt-forwarder, locally modified to preserve the log file. File is attached as a zip:
ttn-pkt-forwarder.zip.  This preserves the log file in /var/log/lora-pkt.log.

The packet forwarder exits periodically, leaving the gateway non-functional until I notice that the forwarder is dead and manually restart it. This is obviously bad for production.

There is no other evidence of anything other than transient network problems.  The network is part of an office building, probably with several layers of NATing.

The old Kersing packet forwarder (V2) ran for months in the same environment without difficulty.

It is possible that a firewall/router upstream is causing the TCP connection to be dropped, either due to NAT table aging or slight instability.

This failure results in loss of data, as there is no other gateway coverage for this experiment.

Expected Behavior

The pkt-forwarder should try to reconnect a few times with a timeout if the connection is dropped, prior to giving up.  While it's possible to wrap this with a process, the pkt-forwarder has more knowledge about what kind of outage has caused this -- "connection reset by peer" should cause a simple attempt to reestablish. If successful re-establishing, the retry count should be reset.  This would be enough to fix this problem.

Log at shutdown

Here is the relevant section of the log:

  INFO Sending status to the network server     Altitude=0 CpuPercentage=27.49416 FrequencyPlan=US_902_928 Latitude=40.75602 Load1=0.92 Load15=0.74 Load5=0.8 Longitude=-73.98285 MemoryPercentage=9.2206955 RTT=85 RXPacketsReceived=37 RXPacketsValid=120 TXPacketsReceived=0 TXPacketsValid=0 Uptime=5m34.969076s
  INFO Sending status to the network server     Altitude=0 CpuPercentage=27.494387 FrequencyPlan=US_902_928 Latitude=40.75602 Load1=0.79 Load15=0.73 Load5=0.78 Longitude=-73.98285 MemoryPercentage=9.079032 RTT=84 RXPacketsReceived=37 RXPacketsValid=120 TXPacketsReceived=0 TXPacketsValid=0 Uptime=5m50.080823s
2017/07/17 14:09:04 transport: http2Client.notifyError got notified that the client transport was broken read tcp <IP_ADDRESS>:46375-><IP_ADDRESS>:1901: read: connection reset by peer.
2017/07/17 14:09:48 grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: context deadline exceeded"; Reconnecting to {us-west.thethings.network:1901 <nil>}
 ERROR Program ended after one of the network links failed
  INFO Stopping downlink manager
  INFO Closing downlinks queue
  INFO Closing uplinks queue
  INFO Concentrator stopped gracefully
 ERROR The program ended following a failure    error=Status routine error: Network server health check error: Health check with the router failed source=(*Manager).startRoutines.func1: /builds/thethingsnetwork/packet_forwarder/gopath/src/github.com/TheThingsNetwork/packet_forwarder/pktfwd/manager.go:284

Environment

<packet-forwarder> version returns:

  INFO Got build information                    BuildDate=2017-06-07T07:5554Z Commit=b64203b985c02a82ab4f3cb41d907be85fcb04e6 Version=

My gateway:

Manufacturer: Multi-Tech
OS: mLinux; Linux ttn-nyc-1140_6th_mcci_production 3.12.27 #1 Thu May 5 18:53:23 CDT 2016 armv5tejl GNU/Linux
Type of concentrator: MTAC (old style, FTDI, not raw SPI).
Type of interface with the concentrator: USB

Is connected to: The TTN community network

I am observing the same issue, see above referenced ticket.

@SloMusti The logs mentioned in this issue are logs written by the mp-pkt-fwd, for which you can find the repository here. The development of the TTN packet forwarder is on hold for the moment!

@kersing maintaining the mp-pkt-fwd has been notified of the issue and is working on it.


Update info for building from source

Fix #131
Update and streamline README.md

I'm requesting your review especially because of wanting your input on how I streamlined README.md. I've tested the dev setup instructions and scripts both in Debian 12 and Ubuntu 20.04.

Looks good. If you want, you can complete my migration to using the wiki for Logos deps by replacing all the distro packages for Logos with a link to the following page:
https://github.com/FaithLife-Community/LogosLinuxInstaller/wiki/System-Dependencies