Expose style prop of chidren of KeyboardAwareScrollView

Is your feature request related to a problem? Please describe.
When using the KeyboardAwareScrollView component with react-native-web there is no way in styling it's internal child (<Reanimated.View style={view}>{children}</Reanimated.View>) which I need to do because it needs to span the whole screen for me and therefore i have to add flex: 1 to it somehow.
Describe the solution you'd like
Expose the style prop of that child.
Describe alternatives you've considered
Importing a css file on some other way and target that div.

@sem4phor will this PR https://github.com/kirillzyusko/react-native-keyboard-controller/pull/321 fix your problem?
I think then you can specify contentContainerStyle={{flex: 1}} and it should work, right?

Yes thank you 🙏


What az command can I run to get this information

Operators can't use the browser for automation. How can I find this either with the azcli, or on my local machine?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14ab965b-dc45-f450-1302-5ffe491ca129
Version Independent ID: 0d96d50d-a349-3408-3b93-d8b084e1cbd1
Content: Create an Azure Active Directory tenant
Content Source: articles/active-directory/develop/quickstart-create-new-tenant.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

Closing this, as the doc I've created this issue on probably isn't intended for the audience I've mentioned.

az account list will list tenantIDs if anyone else lands on this page and is looking for the cli command.

@ryanhartje thanks for reaching out and closing once you found the answer :)


Failure to Compile on openSUSE Linux

ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ cabal --version
cabal-install version <IP_ADDRESS>
using version 1.16.0 of the Cabal library
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ nice -n20 make
cabal sandbox init
cabal: unrecognised command: sandbox (try --help)
Makefile:23: recipe for target 'cabal.sandbox.config' failed
make: *** [cabal.sandbox.config] Error 1
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ uname -a
Linux linux-0fiz 3.16.7-29-desktop #1 SMP PREEMPT Fri Oct 23 00:46:04 UTC 2015 (6be6a97) x86_64 x86_64 x86_64 GNU/Linux
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ date
Tue Dec 22 23:40:21 EET 2015
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ ls
CODE_OF_CONDUCT.md  ivory-backend-c     ivory-hw           ivory-quickcheck  Makefile
ivory               ivory-eval          ivory-model-check  ivory-serialize   Makefile.sandbox
ivory-artifact      ivory-examples      ivory-opts         ivory-stdlib      README.md
ivory-backend-acl2  ivory-formal-model  ivory-paper        LICENSE
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$ ghc -v
Glasgow Haskell Compiler, Version 7.6.3, stage 2 booted by GHC version 7.6.3
Using binary package database: /usr/lib64/ghc-7.6.3/package.conf.d/package.cache
wired-in package ghc-prim mapped to ghc-prim-<IP_ADDRESS>-d5221a8c8a269b66ab9a07bdc23317dd
wired-in package integer-gmp mapped to integer-gmp-<IP_ADDRESS>-2f15426f5b53fe4c6490832f9b20d8d7
wired-in package base mapped to base-<IP_ADDRESS>-8aa5d403c45ea59dcd2c39f123e27d57
wired-in package rts mapped to builtin_rts
wired-in package template-haskell mapped to template-haskell-<IP_ADDRESS>-a3012803fde1dc362e555b35a1a78e6d
wired-in package dph-seq not found.
wired-in package dph-par not found.
Hsc static flags: -static
*** Deleting temp files:
Deleting:
*** Deleting temp dirs:
Deleting:
ghc: no input files
Usage: For basic information, try the `--help' option.
ts2@linux-0fiz:~/tmp/xx9/2015_12_22_Ivory_Programming_Language/uhuu/ivory$

What it looks like to me: The build uses a Cabal sandbox, but your version of cabal-install is too old to support sandboxes. If your repos don't have a newer version, you may need to do something like cabal install cabal-install, and add ~/.cabal/bin to the beginning of your PATH variable.

This problem should be deprecated as we've now moved to a Stack-based build.


"CleanCommitLogService#deleteExpiredFiles", remove redundant code

optimize DefaultMessageStore.CleanCommitLogService#deleteExpiredFiles
remove redundant code

Coverage decreased (-0.06%) to 50.934% when pulling 8b8a8cc8a2887414550c8c6db3276872f9daf632 on rushsky518:deleteFiles into 35c38888e0d5678fb4aaad5ba8534b7552d9a9a0 on apache:develop.

@rushsky518 The code is okay, the more refer by  https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Git-Commit-Message-Conventions


Leave ProjectExtensionsElement if namespace is only diff

When setting a ProjectExtensionsElement value, MSBuild diffs the current
and desired XML and writes only in the case that they differ. But this
is producing false negatives because the InnerXml may have a namespace
inherited from the project that isn't represented in the "real" XML.
Allow the current to be equal to the desired modulo that namespace.
Fixes #3904.

I applied bits with this change and it fixed the scenario in #3904. Trying to figure out if I can add a test quickly.
fyi @PavelUstinovMS

Annoyingly, the round-trip and the VS scenario have different namespace-stripping behaviors. I'm going to force-push back to the manually-verified-but-no-tests case, because I don't see how the VS scenario does its thing.


AWS Cost diagram

AWS Cost diagram to be added to the AWS Cost docs page.

Don't you have to reference the image somewhere?


Improvements in Ticketcc views and templates

I updated code on TicketCC in order to fix some issues :

provide error message in add view
bug in delete view
better visual appearance
check that user has an email address before adding to ticket cc

Codecov Report

Merging #896 into master will decrease coverage by 0.11%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   73.39%   73.28%   -0.12%
==========================================
  Files          51       51
  Lines        4879     4888       +9
  Branches      565      568       +3
==========================================
+ Hits         3581     3582       +1
- Misses       1141     1149       +8
  Partials      157      157

Impacted Files
Coverage Δ

helpdesk/views/staff.py
48.08% <0.00%> (-0.32%)
:arrow_down:

helpdesk/models.py
81.51% <50.00%> (-0.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d8046...4c0b9b0. Read the comment docs.


Email sent out using legacy OME emails doesn't get branding applied using OME V1

[Enter feedback here]
Branding is only for OMEv2. OMEv1 does not support custom branding. It is by design. There was documentation error and we need to update it as soon as possible. Legacy OME does not support branding for the notification mail.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 820a7382-167a-e81f-bc8f-a565d14c662d
Version Independent ID: 31cb2b1b-e56c-ffa2-e56b-0a19142123d4
Content: Legacy information for Office 365 Message Encryption - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/legacy-information-for-message-encryption.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@raneem634 Thank you for your feedback. We have added a line stating that this feature is available in the new OMEV2. this can be tracked via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/3474
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @raneem634 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


docker: command not found

I tried to install it with the command in the READ ME file and the run-compose.sh file, both come with the same result of saying "docker: command not found" please help or add a word around. I'm running Steam OS if it's any help.

That is not a supported platform.


MacOSX 13 Ventura: oc("mps_multiply"("(mpsFileLoc): /AppleInternal/Library/BuildRoots/4883e71d-37bd-11ed-b0ef-b25c5e9b9057/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm":228:0)): error: input types 'tensor<2xf32>' and 'tensor<2xsi64>' are not broadcast compatible

Describe your environment

GPU: CPU
VRAM: n/a
CPU arch: [x86]
OS: [macOS Ventura Beta]
Python: miniconda
Branch: main
Commit: Merge: e23dfef 2b9f8e7

Describe the bug
I can run "python scripts/dream.py", but when I type a "dream", I get this error:

Request to generate with prompt: house on the beach at sunset
/Users/massa/AI/stable-diffusion/ldm/modules/embedding_manager.py:153: UserWarning: The operator 'aten::nonzero' is not currently supported on the MPS backend and will fall back to run on the CPU. This may have performance implications. (Triggered internally at  /Users/runner/work/pytorch/pytorch/pytorch/aten/src/ATen/mps/MPSFallback.mm:11.)
placeholder_idx = torch.where(
Generating:   0%|                                                                                | 0/4 [00:00<?, ?it/sloc("mps_multiply"("(mpsFileLoc): /AppleInternal/Library/BuildRoots/4883e71d-37bd-11ed-b0ef-b25c5e9b9057/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm":228:0)): error: input types 'tensor<2xf32>' and 'tensor<2xsi64>' are not broadcast compatible
LLVM ERROR: Failed to infer result type(s).

It seems it may be a problem with the new MacOSX and the MPS Metal Library. Does anyone know help? THANKS.
To Reproduce
Steps to reproduce the behavior:

python scripts/dream.py
"House on the beach at Sunset"
Error appears

Is this a new install or are you updating an older one? If it is an update, could you delete the previous environment and start from scratch with environment-mac.yml?

New install. I have it running on my macPro in the office (macOS 12, late 2013) and wanted to run it on the iMac from 2020.


Error: useNames = NA is defunct

Dear sir,
I ran the test dataset, and got the error below

Hi @deb0612 , as mentioned by @Aokht17 there was an issue with matrixStats versions which is fixed in the new FRASER versions >= 1.99.4
I will close the issue in two weeks if it stays inactive since it's resolved in newer FRASER versions.


[AA]: fix inconsistnet userOpHash

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Change 1
Change 2
...

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Codecov Report
Patch coverage: 64.00% and project coverage change: +0.01 :tada:

Comparison is base (a07ee58) 52.42% compared to head (2ab9a53) 52.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #757      +/-   ##
===========================================
+ Coverage    52.42%   52.44%   +0.01%
===========================================
  Files          167      168       +1
  Lines         7622     7644      +22
  Branches      1572     1572
===========================================
+ Hits          3996     4009      +13
- Misses        3626     3635       +9

Flag
Coverage Δ

coverage
52.44% <64.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...nt-abstraction/contracts/samples/SimpleAccount.sol
93.61% <ø> (ø)

...ontracts/samples/callback/TokenCallbackHandler.sol
0.00% <0.00%> (ø)

.../account-abstraction/contracts/core/EntryPoint.sol
98.20% <100.00%> (+0.01%)
:arrow_up:

...oba/account-abstraction/contracts/core/Helpers.sol
100.00% <100.00%> (ø)

...abstraction/contracts/interfaces/UserOperation.sol
88.88% <100.00%> (+5.55%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

note: to be merged after https://github.com/bobanetwork/boba/pull/698 and ensure tests pass
thanks for the review guys!


Clients - React native upgrades - Expo, sentry-expo deprecation, NativeWind v4

What this does

Upgrade to expo latest
Deprecate sentry-expo in favo rof @sentry/react-native
Add changes for Upgrading to Nativewind v4

Checklist

[ ] Todo 1
[ ] Todo 2
[ ] Todo 3

How to test
Add user steps to achieve desired functionality for this feature.

@lakardion lint will fail until merged with main so I think this is ready

Even though not all checks are passing, I will go ahead and merge this. The checks are not passing because there was a change in the package.json and the linting YAML file that will not take effect as it


Lunaris doesn't work?

To keep it short, Lunaris worked for a quite a while flawlessly and then yesterday I had an incident with it: I couldn't get it to work! It was open, but no features worked at all. It ended up fixing itself after about 5 minutes, I've no idea how.
But today it happened again when I got online, been trying to get it to work again for about 1 hour now. Tried reinstalling multiple times, also changed the POESESSID multiple times. Tried keeping only it and PoE open, didn't work either. No idea what the issue is, but figured I should throw it out here..

My bad, this should populate the logs.txt file with logs: image\bin\java.exe  -Dorg.slf4j.simpleLogger.logFile=log.txt  -jar update4j.jar --remote https://raw.githubusercontent.com/mtricht/lunaris/master/autoupdater.xml --singleInstance
It could be something windows 7 specific, I'll see if I can test that out in a VM.

Those are the only logs in the file now:
18:59:25.409 DEBUG dev.tricht.lunaris.com.pathofexile.PathOfExileAPI - Saving explicit mods 18:59:25.410 DEBUG dev.tricht.lunaris.com.pathofexile.PathOfExileAPI - Saving fractured mods 18:59:25.411 DEBUG dev.tricht.lunaris.com.pathofexile.PathOfExileAPI - Saving crafted mods 18:59:25.412 DEBUG dev.tricht.lunaris.com.pathofexile.PathOfExileAPI - Getting leagues from pathofexile.com

Had no luck finding the issue mate? :(

There is nothing after 18:59:25.412 DEBUG dev.tricht.lunaris.com.pathofexile.PathOfExileAPI - Getting leagues from pathofexile.com? Does the command prompt window stay open?

There's nothing. And the command prompt window stays open.

I finally fixed it by deleting the file with the tool's settings (the ones that remain even if you reinstall the tool). I have no clue why that would interfere with the tool functionality though.

@BarnOwlet Do you happen to still have the 'corrupted' settings file you deleted?

Sorry, no >.> I'll make sure to let you know if it happens again though

Please do!


Sock paths > 108 chars breaks local test env

Running nix build .#ci.<long_test_name> -L fails locally.
fedimint-test-latency-ci> Error: polling lightningd after 10 retries
fedimint-test-latency-ci> Caused by:
fedimint-test-latency-ci>     0: connect to lightningd
fedimint-test-latency-ci>     1: path must be shorter than libc::sockaddr_un.sun_path

We construct the path using the pname, which can cause the cln socket path to exceed the character limit.
https://unix.stackexchange.com/a/367012
"/tmp/nix-shell.j6e6nW/nix-build-fedimint-test-latency-ci-0.1.0.drv-0/devimint-91483/cln/regtest/lightning-rpc".length
res0: Int = 109

Originally posted by @bradleystachurski in https://github.com/fedimint/fedimint/pull/3982#discussion_r1434099704

Duplicate of https://github.com/fedimint/fedimint/issues/3856?

@justinmoon Ahh, thanks for highlighting! This is a dupe, I'll close.
I'm on ubuntu.
It looks like the char limit for mac is 104 and certain linux distros is 108 (referencing bottom of this answer https://unix.stackexchange.com/a/367012)


RC1

These should be autogenerated.  Fixed the issue in powershell and merged this PR:   https://github.com/PowerShell/Homebrew-Tap/pull/412

Here is the PR to fix PowerShell release process:  https://github.com/PowerShell/PowerShell/pull/16335


Fix notification count mechanism.

Created by: qnikst
When notification came we should increment drives with current
fix status, instead of a target status.

Closing as an obsolete


Birthday Sample List formatting not working with @now

I'm using the Birthday Sample List Format to show birthdays on my sharepoint site, however, the @now is not functioning correctly. On my list, it just shows Next Birthday even though I have today's date in. I haven't modified anything in that part of the formatting and I can't seem to find anything to fix it. Thanks.
Sample (which sample are you having trouble with)
https://github.com/pnp/List-Formatting/blob/master/view-samples/birthdays/README.md
What Should Happen

What Actually Happens

Ah, I'm sorry, it appears my filter got wiped out for some reason. I think it's working now.


[docs] Add Pilcro to showcase apps

I have added Pilcro to showcase app. Thanks.

@hugowoodhead This is such a high-quality project ✨. Thanks for trusting us!


it should clear input.value after emit image-added event for same image uploading

if i upload same image twice, the second time wont work because of the input value is already exist and it wont trigger the @change event.
https://github.com/davidroyer/vue2-editor/blob/e22dc5fcabd71a11f42fbd9e0daec8d2f5ace42e/src/components/VueEditor.vue#L12
https://github.com/davidroyer/vue2-editor/blob/e22dc5fcabd71a11f42fbd9e0daec8d2f5ace42e/src/components/VueEditor.vue#L204

This issue is stale because it has been open for 60 days with no activity.


Update metamask.ts

Changes made to indicate that MetaMask supports autoswitching between networks and supports Base on both Mobile and Extension.

MetaMask also supports Gnosis: https://support.metamask.io/networks-and-sidechains/how-to-connect-to-the-gnosis-chain-network-formerly-xdai/

Browser ENS Compatibility should be:
    ensCompatibility: {
      mainnet: true,
      subDomains: true,
      offchain: true,
      L2s: true, /* change this one */
      customDomains: false,
      freeUsernames: false,
    },


Not cleaning up ClipRecord when subsetting COLRv1?

pyftsubset --unicodes='U+004e U+006f U+0074 U+0020 U+0043 U+006c U+0072 U+0045 U+006d U+006a U+0069 U+0063 U+0066 U+0030' color-fonts/fonts/noto-cff_colr_1.otf
WARNING: ClipRecord[0] range references missing glyph IDs: [13-13]
...many more such warnings...

color-fonts is https://github.com/googlefonts/color-fonts. Guessing we aren't subsetting the clip records yet.

Hm. I don't see this on main and I do on the latest release. Might be all we need is a release.

Yes, sorry, I had fixed this directly on main branch but didn't cut a release since. I'll do that today
https://github.com/fonttools/fonttools/commit/99743c14

https://github.com/fonttools/fonttools/releases/tag/4.27.0


Bug: Latest HA Core update 2024.5.0 breaks notification entities.

Please make sure that the issue you're planning to report is not already registered :)

Describe the bug
The latest HA Core update (2024.5.0) stops hass.agent from creating any notify entities.
To Reproduce
Steps to reproduce the behavior:

Update HA Core to 2024.5.0
When the server restarts it won't have any hass.agent notification entities.

Expected behavior
That the notify entities are created like normal.
Misc info (please complete the following information):

Windows' UI language: English
HASS.Agent version: 2.0.1 and 2.1.0 Beta

Aaand moved to the proper repository :D

I have tried everything on this site!! But nothing works for me at all. What am I doing wrong?

You'll need to provide us with more information because without it it's guessing what might be wrong - what exactly is not working, has it been working before, what you've tried, are there any Home Assistant errors in the log?

I installed the HASS.agent2 in HA and also in Windows. I restarted HA. All connections are OK but I still don't see 'notify_entity and no media player entity. I'm fairly new here!

And as far as I can see as a newbie, there are no mentions of HASS.agent in the logs

Can we move this conversation to discord please? - https://discord.gg/ed4B4cdG - as I'm not sure that your issue is related to this one I don't want to spam all the participants of this thread

@amadeo-alex I'm a little confused. I deleted all my computers and removed the legacy HASS.Agent from my Home Assistant. I then installed your forked version under HACS custom repository. Unfortunately I don't see the agent anywhere nor do I see my computers showing up. Do I need to reinstall the original HASS.Agent, edit the files as you posted earlier then install your forked version?
I guess what I am asking is what are the required steps to go from the broken original HASS.Agent to you corrected/working version?

@entirelynutz the general steps I'd say are:

remove the original/old HASS.Agent integration (of course it'll require you to remove the devices as well)
restart Home Assistant
install the forked version of the integration
make sure HASS.Agent (client) is running on the PC devices)
restart Home Assistant

After doing so they should be discovered in the HA
If not, I'd propose creating a topic on the Discord and doing some additional investigation there.

I'm not able to get my media player to show up either. I have added the fork in hacs and restarted HA. It still does not show up for my media player. Do I need to uninstall and reinstall Hass on my PC?

did the init adjustments and now everything is working again ! thanks !!!

did the init adjustments and now everything is working again ! thanks !!!

what adjustments did you do for it to work?

Ok, so, quick&dirty fix for anyone that can/wants edit the files manually :D

Navigate to "/config/custom_components/hass_agent" - either inside the container or via some editor when using the supervisor enabled HA.
Edit "init.py" file (for example "vi init.py")
Add "async" in following places:
a) line 27: "async def update_device_info(hass: HomeAssistant, entry: ConfigEntry, new_device_info):"
b) line 139: "async def updated(message: ReceiveMessage):"
Add "await" in following places:
a) line 124: "await update_device_info(hass, entry, response_json)"
b) line 144: "await update_device_info(hass, entry, payload)"
Restart Home Assistant

What I did was do the above changes on version lower than 2024.5.0, confirmed that notifications and media player are working, then I upgraded to 2024.5.0 and tested the same - appears to work as expected.
Additional images:

@shedman214 these

Ok, so, quick&dirty fix for anyone that can/wants edit the files manually :D

Navigate to "/config/custom_components/hass_agent" - either inside the container or via some editor when using the supervisor enabled HA.
Edit "init.py" file (for example "vi init.py")
Add "async" in following places:
a) line 27: "async def update_device_info(hass: HomeAssistant, entry: ConfigEntry, new_device_info):"
b) line 139: "async def updated(message: ReceiveMessage):"
Add "await" in following places:
a) line 124: "await update_device_info(hass, entry, response_json)"
b) line 144: "await update_device_info(hass, entry, payload)"
Restart Home Assistant

Worked for me, thank you very much!!

When is this fix planned on being released?

It has been fixed in this(forked) repository. The issue is still open as people tend not to check the closed ones - I'll close it at the end of this week probably.
Please follow those steps for the installation - https://github.com/hass-agent/HASS.Agent-Integration?tab=readme-ov-file#installation

Well that's forking annoying. :D
Thanks for the link.

can confirm that on the latest HA and HASS its not working..


go parallel

I don't see how to do this in Modelica, but going parallel could significantly speed up things:
All 5-14 HelmholtzDerivs can be calculated simultaneously, see HelmholtzDerivs and setHelmholtzDerivs
and all 12 up to 50 terms of each HelmholtzDeriv could be evaluated simultaneously, see e.g. f_r
Combining these two should give 60 or more independent threads.
This should be investigated in combination with (automatic?) common subexpression elimination, because the f_r etc function calls have very many terms in common! Maybe combine with #26 ?

Nothing to fix here, currently.

There are many other places where two or more functions could be called in parallel:

more sum() operators:
https://github.com/thorade/HelmholtzMedia/blob/7b867a59b0556b443b2ad463bf3d21d9e1d5537d/HelmholtzMedia/Interfaces/PartialHelmholtzMedium/Ancillary/saturationPressure_T.mo#L21
setSat functions:
https://github.com/thorade/HelmholtzMedia/blob/7b867a59b0556b443b2ad463bf3d21d9e1d5537d/HelmholtzMedia/Interfaces/PartialHelmholtzMedium/setSat_d.mo#L42-L43

@mahge, do you think we can exploit such a fine-grained parallelism? I'm afraid the overhead could kill any potential speedup.

I can not say much without looking at it further. However, the design and implementation is intended to be used for fine-grained parallelism, i.e., at equation level instead of just strongly connected components. Unfortunately, it will not go down into functions and parallelize things there yet.
The good news is that, if these large functions (computations) are attached (called from) equations that can be computed independent from each other in a single time step, it should be parallelizable. In other words, consider each instance of the call to these functions from different equations as part of that equation's computation. If, after causalization, one of the assignments does not use the LHS of the other equation, it is all the same for the implementation and we should be able to run them in parallel.
As for the sum() operators and similar data-parallel computations within functions/algorithms there is another parallelization implementation I did a while back that can handle them even on GPUs. However, this will require modifications to the library source code making it unusable on other Modelica tools. Plus the arrays/computations need to be quite large (by Modelica standards) to see any speedup. We can look at that afterwards if you are interested.

I can not say much without looking at it further. However, the design and implementation is intended to be used for fine-grained parallelism, i.e., at equation level instead of just strongly connected components.

OK.

Unfortunately, it will not go down into functions and parallelize things there yet.

I guess this issue could be solved by clever generation of auxiliary variables. We already have some kind of Common Subexpression Elimination on functions carried out by wrapFunctionCalls, which generates auxiliary equations $cseNN = f(...); for each function call in the model, and use $cseNN in place of that in the functions inside equations. Maybe this could be good enough to get separate function calls in parallel.

The good news is that, if these large functions (computations) are attached (called from) equations that can be computed independent from each other in a single time step, it should be parallelizable.

Yes, that is the point.

In other words, consider each instance of the call to these functions from different equations as part of that equation's computation. If, after causalization, one of the assignments does not use the LHS of the other equation, it is all the same for the implementation and we should be able to run them in parallel.
As for the sum() operators and similar data-parallel computations within functions/algorithms there is another parallelization implementation I did a while back that can handle them even on GPUs. However, this will require modifications to the library source code making it unusable on other Modelica tools. Plus the arrays/computations need to be quite large (by Modelica standards) to see any speedup. We can look at that afterwards if you are interested.

Yeah, I guess the size of arrays is not so large that we can benefit from that. After all, a double-precision summation is one clock cycle on modern CPUs (or even less for superscalar architectures), so if you need to sum a few dozen numbers going paralle probably doesn't make sense.


eslint command added to package.json

Ability to run Eslint from command contained in package.json
Connected with discussion: https://github.com/facebookincubator/create-react-app/issues/1217

This is not quite what I meant.
I don't want to add a new entry to scripts, as I said in https://github.com/facebookincubator/create-react-app/issues/1217#issuecomment-311098466:

We won't add it to the project scripts by default

But I want the script in bin/react-scripts to work so that people who need it can add react-scripts lint.

I believe this has moved to https://github.com/facebookincubator/create-react-app/pull/2729.


Setup / Install References Missing CMD File

Hey Team, the Setup / Install (md) docs reference a CMD file that appears to have move or no longer exists.
Link should be updated or removed.

Per @JPRuskin:

For the Cmd file, that appears to be case sensitive - try https://chocolatey.org/installChocolatey.cmd.

Updating the link now.


White boxes showing instead of arbitrary hologram models

E2 Doesn´t work right; If i use an E2 from any other server on my server, it will not work. If i use an E2 wich spawn models/props, there are only white boxes instead of props -.- There are other bugs too for example; I´ve got an "autoforce" E2 (Handling fix for cars) and if I use it, my car gets pulled to the ground :/ Can you help me (Sry for my bad english (im from Germany))

White boxes was, as @Divran mentions, just a configuration issue. If you need help with the other issue you mentioned feel free to make a new issue about it (being sure to share the E2 source code).


The Jupyter note book does not work

Below is the error seen when running the cell with code -
"wml_models = wml_client.repository.get_details()
model_uid = None
for model_in in wml_models['models']['resources']:
if MODEL_NAME == model_in['entity']['name']:
model_uid = model_in['metadata']['guid']
break
if model_uid is None:
print("Storing model ...")
published_model_details = wml_client.repository.store_model(model=model, meta_props=model_props, training_data=train_data, pipeline=pipeline)
model_uid = wml_client.repository.get_model_uid(published_model_details)
print("Done")"

2019-07-15 06:27:06,712 - watson_machine_learning_client.wml_client_error - WARNING - Publishing model failed.
Reason: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Server': 'nginx', 'Date': 'Mon, 15 Jul 2019 06:27:06 GMT', 'Content-Type': 'application/json', 'Content-Length': '166', 'Connection': 'keep-alive', 'X-Frame-Options': 'DENY', 'X-Content-Type-Options': 'nosniff', 'X-XSS-Protection': '1', 'Pragma': 'no-cache', 'Cache-Control': 'private, no-cache, no-store, must-revalidate', 'X-WML-User-Client': 'PythonClient', 'x-global-transaction-id': '423161n6m4d1d3f9f6c13759kew16c2e9f7b', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains'})
HTTP response body: {"trace":"423161n6m4d1d3f9f6c13759kew16c2e9f7b","errors":[{"code":"invalid_framework_input","message":"The framework value specified: mllib, 2.4 is not supported."}]}

Spark 2.4 is not supported by WML. Downgrading the spark instance to 2.1.2 or other supported versions.
Code to be added in first cell-
!pip install -U pyspark==VERSION_YOU_NEED

Under "Feedback logging" section, the following code need to be added -
!wget https://raw.githubusercontent.com/IBM/monitor-wml-model-with-watson-openscale/master/data/additional_feedback_data.json
wget is missing

Cell containing the code "subscription.quality_monitoring._get_data_from_rest_api()" need not be there as it is calling the private methods.


add wrapper for ScheduledExecutorService

as title.

Now that context propagation via ActiveSpan is part of the OT API, we're moving away from Jaeger's custom instrumentation of frameworks in favor of respective opentracing-contrib libs. You can already use those libs with Jaeger today, and there is https://github.com/opentracing-contrib/java-concurrent

According to my understanding ActiveSpan is a good abstract for context propagation, I can implement wrapper of ScheduledExecutorService with ActiveSpan more easily. But i think whether wrapper of ExecutorService or ScheduledExecutorService are should be exists for low invasive.

Closing please use opentracing instrumentations from opentraicng-contrib


Fix CA mount problems in local dev

Fix CA mount problems in local dev
Fix https://github.com/matrix-org/complement/pull/283#discussion_r783448724

Fix mount type not being defined on for the CA cert bind mount:failed to deployBaseImage: Error response from daemon: invalid mount config for type "": mount type unknown

Fix CA volume being created even when the COMPLEMENT_CA environment variable isn't defined which leads to unable to load certificate errors because /ca/ca.crt does not exist.

Dev notes
logrus.WithFields(logrus.Fields{
  "mounts": fmt.Sprintf("%+v", mounts),
}).Error("ContainerCreate")

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
Images built; running complement
2022/01/12 14:50:45 config: &{BaseImageURI:complement-synapse BaseImageArgs:[] DebugLoggingEnabled:false AlwaysPrintServerLogs:true BestEffort:false SpawnHSTimeout:30s KeepBlueprints:[] PackageNamespace:pkg}
=== RUN   TestImportHistoricalMessages
2022/01/12 14:50:45 pkg.hs_with_application_service.hs1 : failed to deployBaseImage: Error response from daemon: invalid mount config for type "": mount type unknown
2022/01/12 14:50:45 pkg.hs_with_application_service.hs2 : failed to deployBaseImage: Error response from daemon: invalid mount config for type "": mount type unknown
    msc2716_test.go:63: Deploy: Failed to construct blueprint: Error response from daemon: invalid mount config for type "": mount type unknown
--- FAIL: TestImportHistoricalMessages (0.10s)
FAIL
FAIL	github.com/matrix-org/complement/tests	0.522s
2022/01/12 14:50:45 config: &{BaseImageURI:complement-synapse BaseImageArgs:[] DebugLoggingEnabled:false AlwaysPrintServerLogs:true BestEffort:false SpawnHSTimeout:30s KeepBlueprints:[] PackageNamespace:csapi}
testing: warning: no tests to run
PASS
ok  	github.com/matrix-org/complement/tests/csapi	0.270s [no tests to run]
FAIL

2022/01/12 16:25:11 pkg.hs_with_application_service.hs1 : Server logs:
Signature ok
subject=CN = hs1
Can't open /ca/ca.crt for reading, No such file or directory
140140056409408:error:02001002:system library:fopen:No such file or directory:../crypto/bio/bss_file.c:69:fopen('/ca/ca.crt','r')
140140056409408:error:2006D080:BIO routines:BIO_new_file:no such file:../crypto/bio/bss_file.c:76:
unable to load certificate

Thanks for the review and merge @kegsay 🦒


Create protoc workflow

Run protoc in GitHub Actions

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.49%. Comparing base (b6b5ca3) to head (a949795).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   37.49%   37.49%
=======================================
  Files          20       20
  Lines        1427     1427
=======================================
  Hits          535      535
  Misses        829      829
  Partials       63       63

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enable uploading of vCard files

This commit adds support for uploading vCard files with the .vcf extension, as per the guidance at https://www.gov.uk/government/publications/open-standards-for-government/exchange-of-contact-information.

Could you mention in the commit message why this is being added. Also, if possible, avoid having very long lines in the commit message (the styleguide recommends 72 characters max https://github.com/alphagov/styleguides/blob/master/git.md#structure ).


[YUNIKORN-2481] Convert yunikorn-site to use pnpm

What is this PR for?
Use pnpm instead of yarn for yunikorn-site. This results in a much faster, more reliable build.

Update build scripts to use pnpm for dependency management
Ensure node_modules is not shared between Docker and host
Update Dockerfile to allow pre-caching pnpm dependencies

What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2481
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Most of the weirdness in the old build was due to node_modules being (incorrectly) shared between the host and the Docker environment. This has been fixed and the build steps re-ordered to allow caching intermediate Docker steps as long as dependencies have not changed. This should also eliminate the need to explicitly add the algolia search theme every time.

Most of the changes looks good, tested in local and docker.
One more minor change required:

yarn.lock in .gitignore could be removed. (https://github.com/apache/yunikorn-site/blob/master/.gitignore#L9)

I'd rather leave this in since we have historically used yarn. Otherwise others may end up committing it accidentally.

Most of the changes looks good, tested in local and docker.
One more minor change required:

yarn.lock in .gitignore could be removed. (https://github.com/apache/yunikorn-site/blob/master/.gitignore#L9)

As I replied to the top level comment, I'd rather leave this in to prevent committing the lock file accidentally by other users since we previously used yarn.


Support for VS Mac 2017

I'm not sure about whether that's possible, but that'd be awesome.

Im gonna look into it for you.

@arjankuijpers thanks!


[Hotfix] 3.4.3 to develop

[HotFix] getInstallments in GuessingCardPresenter (#653)
Updated CHANGELOG and README (#654)

Codecov Report

Merging #656 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #656      +/-   ##
===========================================
- Coverage    28.97%   28.97%   -0.01%
===========================================
  Files          237      237
  Lines        17336    17335       -1
  Branches      1499     1499
===========================================
- Hits          5023     5022       -1
  Misses       11791    11791
  Partials       522      522

Impacted Files
Coverage Δ

...c/main/java/com/mercadopago/CardVaultActivity.java
67.84% <ø> (-0.1%)
:arrow_down:

.../mercadopago/presenters/GuessingCardPresenter.java
55.61% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbf5d0...8051708. Read the comment docs.


cffi version mismatch

The following error appeared when running simulator = circuit.simulator() in the last cell, and I needed to run !conda install cffi==1.15.1 to update it.
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
<ipython-input-6-496ab6cd4415> in <module>
     15                            pulse_width=1@u_ns, period=2@u_ns, delay_time=1@u_ns)
     16 print(str(circuit))
---> 17 simulator = circuit.simulator()
     18 analysis = simulator.transient(step_time=10@u_ps, end_time=2@u_ns)
     19 print('done')

4 frames
/content/conda-env/lib/python3.7/site-packages/PySpice/Spice/Netlist.py in simulator(self, *args, **kwargs)
   1290
   1291     def simulator(self, *args, **kwargs):
-> 1292         return CircuitSimulator.factory(self, *args, **kwargs)

/content/conda-env/lib/python3.7/site-packages/PySpice/Spice/Simulation.py in factory(cls, circuit, *args, **kwargs)
   1156                 sub_cls = NgSpiceSubprocessCircuitSimulator
   1157             elif simulator == 'ngspice-shared':
-> 1158                 from .NgSpice.Simulation import NgSpiceSharedCircuitSimulator
   1159                 sub_cls = NgSpiceSharedCircuitSimulator
   1160         elif simulator in ('xyce-serial', 'xyce-parallel'):

/content/conda-env/lib/python3.7/site-packages/PySpice/Spice/NgSpice/Simulation.py in <module>
     30 from ..Simulation import CircuitSimulator
     31 from .Server import SpiceServer
---> 32 from .Shared import NgSpiceShared
     33
     34 ####################################################################################################

/content/conda-env/lib/python3.7/site-packages/PySpice/Spice/NgSpice/Shared.py in <module>
    108 ####################################################################################################
    109
--> 110 ffi = FFI()
    111
    112 ####################################################################################################

/usr/local/lib/python3.7/dist-packages/cffi/api.py in __init__(self, backend)
     54                     raise Exception("Version mismatch: this is the 'cffi' package version %s, located in %r.  When we import the top-level '_cffi_backend' extension module, we get version %s, located in %r.  The two versions should be equal; check your installation." % (
     55                         __version__, __file__,
---> 56                         backend.__version__, backend.__file__))
     57                 else:
     58                     # PyPy

Exception: Version mismatch: this is the 'cffi' package version 1.15.1, located in '/usr/local/lib/python3.7/dist-packages/cffi/api.py'.  When we import the top-level '_cffi_backend' extension module, we get version 1.15.0, located in '/content/conda-env/lib/python3.7/site-packages/_cffi_backend.cpython-37m-x86_64-linux-gnu.so'.  The two versions should be equal; check your installation.

was this with the analog-inverter-magic notebook?
https://github.com/chipsalliance/silicon-notebooks/blob/main/analog-inverter-magic.ipynb

Yes, it happened with the analog-inverter-magic notebook.


feat: use connector_request_reference-id as referemce to connector

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Use connector_request_reference_id as reference to the connector #2311
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Following are the paths where you can find config files:

hyperswitch/crates/router/src/connector/opennode/transformers.rs

Motivation and Context
To solve inconsistency in RouterData and it solves the Issue #2311
How did you test it?
Need help in doing  test?
Checklist

[x] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Hey @shakeel-3, can you please revert the top most commit in your PR? It looks like you cherry-picked it. Since it is already merged I to main, I would suggest you using git pull origin main --no-rebase instead.

Hi @pixincreate, @swangi-kumari
I have revert to top most commit and have Run cargo +nightly fmt and also generated and validated openApi spec file.
If there is any  changes to be made please guide me

LGTM!

Hey @shakeel-3 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!


Update dependencies

Hello,
Thank you for the really nice crate.
I've bumped up the versions of tokio, pin-utils and futures-time.

0.6.1 was released with your changes. Thanks again @amrhassan. ✌


[Request] es6 model support

it's My Fault , i set something wrong in webpack
I use webpack make me use es6, so that i can import jquery in my conponents like this
import $ from 'jquery'

but it seems that jquery-validation doesn't support the ES6 moldel ?
Or maybe i didn't found how to use
However, thanks

dulicate of https://github.com/jzaefferer/jquery-validation/issues/1829


Flutter v1.2.0

After update Flutter to version 1.2.0 and run flutter packages upgrade i get error:
The current Dart SDK version is 2.1.1-dev.3.2.flutter-f4afaee422.
Because every version of flutter_test from sdk depends on source_span 1.5.3 and reflectable >=2.0.2 depends on source_span >=1.0.0 <1.5.0, flutter_test from sdk is incompatible with reflectable >=2.0.2.
And because reflectable <2.0.2 requires SDK version >=1.8.0 <2.0.0-dev.infinity, flutter_test from sdk is incompatible with reflectable.
So, because netmetr_flutter depends on both reflectable any and flutter_test any from sdk, version solving failed.
pub upgrade failed (1)
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel unknown, v1.2.0, on Linux, locale cs_CZ.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Android Studio (version 3.3)
[✓] Connected device (1 available)
• No issues found!

Flutter v1.1.9 works ok.

It looks like a very small adjustment will help, for now. You could try to use this entry in pubspec.yaml for reflectable:
  reflectable:
    git:
      url: git://github.com/dart-lang/reflectable.git
      ref: version_fix_feb19

I'll get that landed and published such that you can return to use a published version.

It works. Thank you.

There will be further issues when I adjust the version constraints of reflectable to allow for analyzer versions up to '<0.36.0', but that seems to involve deprecation of some methods that reflectable depends on in substantial ways, so that will take more work. I've requested some more information about this, so I hope it'll be resolved soon. In any case, Flutter does not yet require those analyzer versions.

I just published the updates as version 2.0.10. I'll delete the branch soon, so please revert to use something like reflectable: ^2.0.10 in 'pubspec.yaml.

Thanks! Deleting the branch and closing the issue now.


Feature request: Adding a greeting message

I just thought it would be cool to add a greeting message above the rectangle. It could be configured to display time, temperature or a custom message etc.

yeah!

This is not our focus right now. Maybe one day :)


Introduce ToBits::to_bits_le_into and use it in Vec/[T]

This PR targets the feat/narwhal branch, but it's quite likely it would result in a performance improvement in other use cases as well; it introduces a ToBits::to_bits_le_into method that allows us to avoid a lot of allocations when calling Vec::to_bits on large collections.
In a 1-minute run of test_state_coherence in snarkOS/narwhal, this PR reduces the number of allocations from ~4.2M to ~2M, and temporary allocations from ~2.2M to ~0.7M, as measured with heaptrack.
I've investigated the option of calling to_bits_le directly in BatchHeader::compute_batch_id, but that would require plenty of additional implementations of ToBits, and it wouldn't have the potential to reduce other allocations in snarkVM, so I decided against that.
I'm filing this as a draft until all the tests have run - it's possible that I might need to introduce another impl of ToBits::to_bits_le_into, which should be trivial.
before:

after:

The CI failures appear to be unrelated, so it's ready for review.

I am retargeting this PR to testnet3 since the changes are applicable to all snarkVM constructs that use this.

Rebased against testnet3 and added one additional commit which provides a small further improvement; that one was also found via profiling.

Superseded by https://github.com/AleoHQ/snarkVM/pull/1836; the drive-by commit will be filed as its own PR.


Kustomize cleanup error handling

My main goal here was just surfacing the error here: https://github.com/kubeflow/kfctl/pull/264/files#diff-85e9677c1c2a51f1c1d287363401b6a7R438
But since I've been at it, I've also tried to improve the error formatting/logging in general:

Uppercase log entries
Lowercase errors
Always add err to returned err
Replace " Error " prefix by ": " to be consistend and more go
idiomatic

This change is

Can't really figure out what failed.. Maybe it's just temporarily
/retest

Let's hope this fixes it. If not, some input would be welcome. Dunno what is going on with the code gen.
/assign @kunmingg

This was the issue before I've added the GOROOT workaround:
go: error loading module requirements
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x68f4e6]
goroutine 1 [running]:
k8s.io/gengo/parser.(*Builder).AddDirRecursive(0xc0000b16d0, 0xc0000ce340, 0x30, 0x1, 0xc0000d7c88)
        /go/src/k8s.io/gengo/parser/parse.go:233 +0xb6
k8s.io/gengo/args.(*GeneratorArgs).NewBuilder(0xc0000b8aa0, 0xc0000aec40, 0x10, 0x28)
        /go/src/k8s.io/gengo/args/args.go:143 +0x22e
k8s.io/gengo/args.(*GeneratorArgs).Execute(0xc0000b8aa0, 0xc0000d7e48, 0x758567, 0x6, 0x784420, 0x0, 0x0)
        /go/src/k8s.io/gengo/args/args.go:192 +0x4d
main.main()
        /go/src/k8s.io/code-generator/cmd/deepcopy-gen/main.go:77 +0x45d
Makefile:81: recipe for target 'pkg/apis/apps/kfdef/v1alpha1/zz_generated.deepcopy.go' failed
make: *** [pkg/apis/apps/kfdef/v1alpha1/zz_generated.deepcopy.go] Error 2

@kunmingg Looks like the unit tests pass now but the 'upgrade' and 'go-iap' workflows fail. I can't find any error there though, not in the build log. Can you tell me what is going wrong here?

@kunmingg I've just rebased this and fixed the merge conflicts. Can we get this through before this happens again?

The only issues I see in the build log are with failing workflows. But the only step that failed in the workflows is the exit handler and the wait for kubeflow steps.. unclear why. Let see if restarting the test makes a difference.
/retest

error from delete:
couldn't delete KfApp:  (kubeflow.error): Code 500 with message: kfApp Delete failed for kustomize:  (kubeflow.error): Code 400 with message: Cluster name doesn't match: KfDef(dummy) v.s. current-context(gke_kube flow-ci-deployment_us-central1-a_kfctl-358f)
Can you try rebase master head?

Sorry tests were flaky recently.

Rebased, let see..

@kunmingg Same error.. can you help me understand why it's failing? Neither the buildlog nor the logs of any of the workflow steps reveal anything. It looks to me like an issue with the tests themselves, unrelated to this PR. Can you confirm that? If so, can we still merge this as-is? I can't really justify spending more time on this right now..

@kunmingg I've rebased this again

On the most recent test run.
katib failed the is ready test.
The ugprade test failed on the delete test.
The periodic tests are showing some failures
https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-periodic-kfctl
The tests will need to be fixed in order to unblock this and other PRs.
@discordianfish I understand your frustration and totally get it if you can't spend more time on this. We do however need to get the tests fixed first.

btw instructions for debugging failed tests are here:
https://github.com/kubeflow/testing#debugging-failed-tests
In my reply above I followed the links to the Argo Workflows UI for the workflows and then looked at the logs for the failed steps.

#57 is tracking some larger improvements to testing for KFCTl to reduce the impact of flaky E2E tests on presubmits.

So I saw that the end2end tests failed, but I didn't (and still don't) see why, so I can't help fixing them. From looking at the the dashboard, it seems like almost all tests fail. But looking that the PRs, it seems they eventually succeeded. Still confused tbh..
But I guess I just try to re-run the test, hoping it will succeed eventually..
/test kubeflow-kfctl-postsubmit

/test kubeflow-kfctl-presubmit

/retest

Ok looks like the workaround of setting GOROOT is needed after all. Still don't understand why other PRs don't run into these same issues. I'll keep trying to rerun the tests a few more times.

Testing infra is kind of flaky now..

Ok, I've rebased this again and looks like the tests have been fixed. Can we get this merged now @kunmingg?

@yanniszark Can you maybe approve/review?

/lgtm
/approve


Permission assignment not possible

The permission assignment in the  Browser tab of iBridges seems to be non-functional.
I cannot assign new permissions and also cannot modify already assigned permissions. The Permission type and Recursive selections have no function in the current version (no selection is possible).
I am currently testing the develop branch with commit deefbece17f4d75e5da0457c3536ddf3b9195c07

@jnimoth This is why:
https://github.com/rijksuniversiteit-groningen/iBridges/blob/91a1d914b872eb13ddd8537e1b4879b3e96cd70b/gui/irodsBrowser.py#L52-L57
I feel this is overly restrictive and so does @simstoica.  In the RDMS GUI, there is no such restriction.  Indeed, this protects the user from her/himself!  I think it unnecessary.
Any objections to removing it?

ACL setting is available again and working quite well.  Just a few more tweaks and it should be ready for testing.

@jnimoth Give it a try!

Works!


Mocking files including EventLoop and similar structs

Hello @gloveboxes,
Thanks again for looking into that dx_utilities issue I posted last week.
I continue to make unit tests for my Azure Sphere project.  And, of course, complications continue to rise.  I am currently mocking some files (eventloop.c and eventloop_timer_utilities.c) that use the EventLoop, EventLoopTimer, and EventRegistration structs.  However, my mocking tool (and myself) cannot seem to find the definitions for those structs.  I can stub in some definitions for them to continue my work.  But, if anyone re-creates my mocked files (auto generated by Ceedling), my hand-made stubs will disappear and break my test suite.
Am I missing something here? Are these definitions somewhere that I'm just not seeing? Or, are they hidden from me (intentionally or otherwise)?
Regards,
Craig
Edit: I am away from my work computer, but I recall finding one of those definitions in a C file (don't recall which one).  But that still makes mocking difficult.

I am leaving my stubbed definitions so my tests will run.  Closing.

I am leaving my stubbed definitions so my tests will run. Closing.


error in docker-compose.yml

Hi,
Thanks for this wonderful example :-)
Unfortunately, I think there's a mistake in the docker-compose.yml file that prevents your demo from running on a remote docker machine.
In the web section, the following lines overrides the app.py you add in DockerFile and make the image fail if app.py is not deployed on the host machine.
  volumes:
   - .:/code

Best regards,
Jean-Marc Astesana

Hi @fathzer thanks for the comment. Are you using Swarm or how are you managing the remote server? Unfortunately, this demo was only intended to run locally but I will have a look to see how to fix it.
Brian

Hi Brian,
I use a single remote machine created with docker-machine create (not a swarm cluster).
Your demo works well in this context if you remove the lines mentioned above.
As the app is already included in the built web container, there's no need to share volume between the host and that container.
Best regards,
Jean-Marc Astesana
PS: I hope I'm clear. I don't speak English very well.

I added a new section which includes the version 2 compose file format and accompanying docker-compose-v2.yml file. This may fix your issue as well. - version 2 compose


404 Not Found - What Am I Doing Wrong??

I'm trying to create an endpoint with Dingo API, but every attempt results in a 404. Here's what I'm trying to do:
$api = app('api.router');
$api->version('v1', ['prefix' => 'api'], function($api) {
  $api->get('influencers', 'App\Http\Controllers\TestController@index');
});

My .env settings:
API_PREFIX=api
API_VERSION=v1
API_STRICT=false

Shouldn't this load properly when accessing /api/v1/influencers? What am I missing..?
If I delete the $api->get call, then I get a 400 instead of a 404.

I believe it should be available at /api/influencers.

Version does not get placed in the URI. As Lee has pointed out it should just be /api/influencers. The version is altered by using content negotiation, namely, the Accept header. Refer to the wiki: https://github.com/dingo/api/wiki/Making-Requests-To-Your-API


Not working - Cannot process argument because the value of argument "path" is null.

Doesn't work for me and I get no reply when asking on Technet.
Can you please resolve?
https://social.technet.microsoft.com/Forums/msonline/en-US/30ce1b57-6dc7-462d-b4fa-24950ed3fc27/connect-to-exchange-online-powershell-using-multifactorauthentication-error-when-loading?forum=onlineservicesexchange

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65e527db-a4c2-782e-5a5f-ad8b3159a977
Version Independent ID: f2de1272-5e37-c59f-fcb9-34fa66b0d268
Content: Connect to Exchange Online PowerShell using multi-factor authentication
Content Source: exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

@a7259w I cannot. Since this isn't a documentation issue, your best bet is to file a support case.


CoreData Model support and Assets catalog creation

create CoreDataModel (.xcdatamodel) source files
creare empty Assets Catalog

Thank you @JoelGerboreLaser !


Mute microphone and turn off video when screen saver runs

Description of the new feature / enhancement
Please add the following features:

Mute all microphones and disable all cameras when the screen saver runs, i.e. the computer is locked.
Prevent programs from enables these devices when the computer is locked.

Scenario when this would be used?
In corporate settings it is important that users are fully aware when a microphone and camera are operating.  In tight quarters, like trading desks, users may walk away from the computer while in a Zoom call or similar virtual meeting exposing their nearby colleagues to potential eavesdropping. Corporations consider open microphones and cameras a security risk and may resist using these devices until adequate controls and protections are available.
Supporting information
The way microphones, including those on telephones, are handled on a trading floor is by having 'push-to-talk' un-mute buttons on handsets to avoid open microphones.
See https://www.startechtel.com/products/clarity-500mnc100-50771001-push-to-talk-handset-cla50771001

A screensaver shouldn't kick on in this scenario.  Locking a computer would be.

Thanks for the feedback but VCM is moving to maintenance only in the 0.67 timeframe. Our team will only directly address critical bugs, security and accessibility issues.
We'll accept community PRs for enhancements.


Google Translate skipping paragraphs

Improved the issue of Google Translate skipping paragraphs due to network problems by increasing the number of attempts (defaulting to 3 attempts).

Thanks


Detect if pixi is installed via homebrew or other package managers

Problem description
We have the self-update in place now. To give more helpful messages to the users, we could detect what package manager was used to install pixi (e.g. homebrew, winget etc.) and give a really helpful error message. @pavelzw pointed out how gh is doing this: https://github.com/prefix-dev/pixi/issues/362#issuecomment-1927189142

https://repology.org/project/pixi/versions shows a list of most (not conda-forge) package repositories.


[spi_device] Change addr_latched to a pulse signal

Problem:
`addr_latched_i` in `spid_readsram` module is expected to be a pulse
signal. The `spi_readcmd` module generates the signal as a level by
comparing `addr_cnt_d` with all zero value.

As a result, the `strb` register in `spid_readsram` follows the
current address, which is increased by when a byte is sent to the
host system. However, the `spid_readsram` logic pushes the data into
the FIFO already. As the FIFO depth is 2, one more entry has been
added to the FIFO, which results the host system sees the a byte has
been shifted.

Resolution:
Revised the `addr_latched` logic to be a pulse. Either `addr_cnt_d`
or `addr_latched` can be revised. I chose the latter. Latching the
latched signal and generated a pulse.

This PR contains #11829  Please review the last commit only. I will rebase once the PR is merged

Rebased.

lgtm! although quick question, why didn't you use your prim_edge_detector? :)

lol. forgot that..


Ranged levels

When equipped with a Shortbow and arrows, no ranged xp is gained, Attack Strength and Defense Experience rise normally with or without the bow.

Unfortunately Ranged and Magic haven't yet been implemented. They're very high on the priority list though.

Ranged Max hit has been added to the game (aswell as the attack styles), but not yet the hit rolls and Ranged equipment. Arrows also don't have a function other than increasing max hit yet.

Thoughts on adding crossbows (i already have it ready to go in a branch) and forcing a match between ammo type and weapon?

Thoughts on adding crossbows (i already have it ready to go in a branch) and forcing a match between ammo type and weapon?

Crossbows will be added to the game. But probably not Bronze-Adamant. I was thinking about the Dorgeshuun crossbow, Rune crossbow, Karil's crossbow and the Armadyl crossbow.


Upgrade Electron.app to v0.28.3

Thank you for the contribution. It was merged directly as 94dfeb29c1a1ac8f2d5d826a1b795de6ba4465d7 to keep commit history cleaner. Your contribution is still credited to you.


[stable/redis-ha] Allow templating in customConfig blocks

What this PR does / why we need it:
The customConfig blocks when passed through tpl can contain Helm
templating placeholders to make more dynamic configurations possible.
Which issue this PR fixes

fixes #16065

Special notes for your reviewer:
@ssalaues  PTAL
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

Solid idea but with https://github.com/helm/charts/pull/16080 going in first, you'll have to rebase and force push.

@ssalaues done!

/lgtm

Thank you very much to all!!! Excellent community!!


Circle CI README Badge

Awesome! @pavanramkumar please merge if you're happy

Coverage remained the same at 93.854% when pulling 46de06d3db5c4c2fcd6647e05afb919fc8a839de on timshell:badge into 154251a3565b63ff301f0d4b63160e7b23f1b620 on KordingLab:master.

awesome


fix: Wrong positioning of filter tooltips on scroll

SUMMARY
Fixes the positioning of filter tooltips on scroll. Previously, the tooltips were unanchored to their elements and ended up in wrong positions when scrolling.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Tooltips following the scroll
https://github.com/apache/superset/assets/70410625/89894d64-34ed-4bdf-ad7b-7b911b219194
After: Tooltips anchored to their elements
https://github.com/apache/superset/assets/70410625/ed888132-bd27-47eb-9600-01231d0f9d3d
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Did this fix the popover of the time filter control, too?

Did this fix the popover of the time filter control, too

By time filter control, do you mean the one that appears in the video called time_range? If yes, then it's fixed.

I meant this popover. Didn't see it in the video.

I meant this popover. Didn't see it in the video.

Oh, it's also following the scroll :man_facepalming: I'll add a commit to fix it

@ktmud I'll add a follow-up to fix the popover element because it involves a shared component that is used in many use cases and may require additional context.

I registered the issue here.


Add event picture

A user has requested via e-mail that they would be happy to optionally display the events' picture in a widget or a shortcut.

I think this is a must... AFAIK mobilizon-connector only displays events info in the form of text. The ideal would be to get events images, that would be beautiful.
thanks.

I have been working on this recently and got stuck with the caching. I was not able to cache the pictures as base64-encoded string in the database; Maybe, I went over a limit. I need to think of another solution.

This feature will land with the next release.


Jade support for templates

How can I add jade support for the templates?

Simply be installing the webpack jade-loader then piping your html through it. @vtllr can help if I am wrong!


is there a "columns compact" mode?

Hello,
thanks for TableFilter, it's magic :)
i have a webpage showing a table: http://sandrotosi.me/debian/py2removal/index.plain.html which i then converted to use TF: http://sandrotosi.me/debian/py2removal/index.html
i'm wondering if there's a way to have more "compact" columns (and now that i compare the 2 pages side-by-side, even the rows). f.e. "Bug No." is always going to be a 6-character string, but it uses a lot more space than actually needed; and that applies to several other columns too.
it would make it more readable if we can set an option to try and keep the column width as close to the content of that column as possible.
i tried cols_width but that's just a static width, and i'd rather have something dynamic, that ideally would change depending on what sorting you're doing.
thanks for considering!
EDIT: just to make it clear: i want to have the table using the whole width of the browser window, but columns that dont need that much space should be get their width reduced, while others should get enough space to show their cell without wrapping. as i said, i tried cols_width all set to null but that shrinks the whole tables to the minimum, which is not what i want

Hi @sandrotosi,
have you tried to apply a 100% width to the table and a arbitrary fixed width for the Bug No. column?

tbh, so much time has passed i dont remember all the permutations/attempts i made (the final version of the table configuration is here)
but what i wanted is something that would require me to specify a fixed width, but that would be able to just shrink a column to its minimum required width to contain the data selected by the filter.
if you go to http://sandrotosi.me/debian/py2removal/index.html and enter "yes" in the py3k? column, you see that the string "yes" and the column title are both using more width than necessary,  same goes for the columns on the right; but the maintainers column would benefit from additional space to show more value in a single row instead of wrap it up 2/3 times


Allow for a default load order as a convention

Configuration allows for a very rich way to specify multiple sources for configuration information with priority ordering. However, for many applications, a convention that does the equivalent of:
let config = ConfigurationManager
                                 .load(file: "config.json")
                                 .load(.environmentFiles)
                                 .load(.commandLineArguments)

So that the user simply has to do:
let config = ConfigurationManager.default()

 configMgr.load(file: "../../\(cloudConfigFile)")
 configMgr.load(file: cloudConfigFile, relativeFrom: .pwd)

All, just sharing some additional context:
let cloudConfigFile = "cloud_config.json"
…

configMgr.load(file: "../../\(cloudConfigFile)")
configMgr.load(file: cloudConfigFile, relativeFrom: .pwd)

where cloud_config.json is found in the root folder of the repo. For instance, see: https://github.com/IBM-Swift/swift-enterprise-demo. If we can come up with a way we can abstract this logic inside CloudConfiguration, that would remove the need for this boilerplate code in the app.


Add dev container

This PR provides a developer container for the template repository.
New Features

It is now possible to start the package template inside a containerised environment with minimal installation and setup required.
Updates to README.MD

Linked to

Provide a link to any other PRs or GitHub issues associated with this PR

Codecov Report

Merging #18 (5d72f69) into develop (3ba9722) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            5         5
=========================================
  Hits             5         5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba9722...5d72f69. Read the comment docs.

This is failing because the virtual environment is not activated for each command in the pipeline.
I can get around this by adding preamble to each command but a cleaner implementation is to run CI inside the Docker container


What is the state of this project?

Looking to integrate this into a new project i'm working on but theres a vibe of a deprecated project here.
The first reason is because there's no docs or even links to docs. A Google search pulls up this outdated version of docs. I ended realizing that doc_src of this repository contains some unbuilt docs.
The second reason is because the README says this project uses django-mptt under the hood. But that repo says that the project is currently unmaintained and to use something else.
What's confusing is that both of these repos appear to have commits in the recent past giving evidence that they're not abandoned. Is it worth integrating this into a new project? Or is doing that risky?

Not sure what would take to transform this to other library than django-mptt.
I am using this project for my project and I am interested in keeping it maintained, so I am willing to invest some maintenance work.


Running python setup.py validate results in 12 reformatted files

When running python setup.py validate, even if no files have been touched, it results in 12 reformatted files.
Reproducible in:
python setup.py validate
...
Running black…
/Users/arenz/Developer/python-slackclient/venv/bin/python -m black /Users/arenz/Developer/python-slackclient/slack
reformatted /Users/arenz/Developer/python-slackclient/slack/errors.py
reformatted /Users/arenz/Developer/python-slackclient/slack/signature/verifier.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/async_base_client.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/async_slack_response.py
reformatted /Users/arenz/Developer/python-slackclient/slack/webhook/webhook_response.py
reformatted /Users/arenz/Developer/python-slackclient/slack/webhook/internal_utils.py
reformatted /Users/arenz/Developer/python-slackclient/slack/webhook/client.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/classes/views.py
reformatted /Users/arenz/Developer/python-slackclient/slack/rtm/client.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/classes/blocks.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/async_client.py
reformatted /Users/arenz/Developer/python-slackclient/slack/web/client.py
All done! ✨ 🍰 ✨
12 files reformatted, 21 files left unchanged.

Per request, diffs look as such:
diff --git a/slack/errors.py b/slack/errors.py
index db79d4c..fb494ac 100644
--- a/slack/errors.py
+++ b/slack/errors.py
@@ -35,7 +35,7 @@ class SlackApiError(SlackClientError):

 class SlackClientNotConnectedError(SlackClientError):
     """Error raised when attempting to send messages over the websocket when the
-    connection is closed. """
+    connection is closed."""

 class SlackObjectFormationError(SlackClientError):
diff --git a/slack/rtm/client.py b/slack/rtm/client.py
index 64aeedc..f0a812d 100644
--- a/slack/rtm/client.py
+++ b/slack/rtm/client.py
@@ -578,7 +578,8 @@ class RTMClient:
         close_method = getattr(self._websocket, "close", None)
         if callable(close_method):
             future = asyncio.ensure_future(
-                close_method(), loop=self._event_loop,  # skipcq: PYL-E1102
+                close_method(),
+                loop=self._event_loop,  # skipcq: PYL-E1102
             )
             futures.append(future)
         self._websocket = None
diff --git a/slack/signature/verifier.py b/slack/signature/verifier.py
index e42ca60..9217502 100644
--- a/slack/signature/verifier.py
+++ b/slack/signature/verifier.py
@@ -23,7 +23,9 @@ class SignatureVerifier:
         self.clock = clock

     def is_valid_request(
-        self, body: Union[str, bytes], headers: Dict[str, str],
+        self,
+        body: Union[str, bytes],
+        headers: Dict[str, str],
     ) -> bool:
         """Verifies if the given signature is valid"""
         if headers is None:
@@ -36,7 +38,10 @@ class SignatureVerifier:
         )

     def is_valid(
-        self, body: Union[str, bytes], timestamp: str, signature: str,
+        self,
+        body: Union[str, bytes],
+        timestamp: str,
+        signature: str,
     ) -> bool:
         """Verifies if the given signature is valid"""
         if timestamp is None or signature is None:
diff --git a/slack/web/async_base_client.py b/slack/web/async_base_client.py
index 053c4fa..e8efa08 100644
--- a/slack/web/async_base_client.py
+++ b/slack/web/async_base_client.py
@@ -111,7 +111,9 @@ class AsyncBaseClient:
         show_2020_01_deprecation(api_method)

         return await self._send(
-            http_verb=http_verb, api_url=api_url, req_args=req_args,
+            http_verb=http_verb,
+            api_url=api_url,
+            req_args=req_args,
         )
diff --git a/slack/web/async_slack_response.py b/slack/web/async_slack_response.py
index 462b7d2..83a3e42 100644
--- a/slack/web/async_slack_response.py
+++ b/slack/web/async_slack_response.py
@@ -133,7 +133,9 @@ class AsyncSlackResponse:
             self.req_args.update({"params": params})

             response = await self._client._request(  # skipcq: PYL-W0212
-                http_verb=self.http_verb, api_url=self.api_url, req_args=self.req_args,
+                http_verb=self.http_verb,
+                api_url=self.api_url,
+                req_args=self.req_args,
             )

             self.data = response["data"]
diff --git a/slack/web/classes/blocks.py b/slack/web/classes/blocks.py
index f995e3c..011d049 100644
--- a/slack/web/classes/blocks.py
+++ b/slack/web/classes/blocks.py
@@ -159,7 +159,10 @@ class DividerBlock(Block):
     type = "divider"

     def __init__(
-        self, *, block_id: Optional[str] = None, **others: dict,
+        self,
+        *,
+        block_id: Optional[str] = None,
+        **others: dict,
     ):
         """A content divider, like an <hr>, to split up different blocks inside of a message.
         https://api.slack.com/reference/block-kit/blocks#divider
diff --git a/slack/web/classes/views.py b/slack/web/classes/views.py
index b56f7e1..440a36b 100644
--- a/slack/web/classes/views.py
+++ b/slack/web/classes/views.py
@@ -159,7 +159,9 @@ class ViewState(JsonObject):
         )

     def __init__(
-        self, *, values: Dict[str, Dict[str, Union[dict, "ViewStateValue"]]],
+        self,
+        *,
+        values: Dict[str, Dict[str, Union[dict, "ViewStateValue"]]],
     ):
         value_objects: Dict[str, Dict[str, ViewStateValue]] = {}
         new_state_values = copy.copy(values)

The Slack SDK version
slackclient==2.8.1
Python runtime version
Python 3.8.3
OS info
ProductName:	Mac OS X
ProductVersion:	10.15.6
BuildVersion:	19G2021
Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64

Steps to reproduce:

source venv/bin/activate
python setup.py install
python setup.py validate

Expected result:
No formatting to be applied to files that haven't been touched or created
Actual result:
Formatting of 12 already-present files that haven't been touched
Requirements
For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@misscoded Thanks for flagging this! Your current code seems to be different from the latest revision formatted by black.
https://github.com/slackapi/python-slackclient/blob/v2.8.2/slack/web/async_slack_response.py#L135-L139
            response = await self._client._request(  # skipcq: PYL-W0212
                http_verb=self.http_verb,
                api_url=self.api_url,
                req_args=self.req_args,
            )

diff --git a/slack/web/async_slack_response.py b/slack/web/async_slack_response.py
index 462b7d2..83a3e42 100644
--- a/slack/web/async_slack_response.py
+++ b/slack/web/async_slack_response.py
@@ -133,7 +133,9 @@ class AsyncSlackResponse:
             self.req_args.update({"params": params})

             response = await self._client._request(  # skipcq: PYL-W0212
-                http_verb=self.http_verb, api_url=self.api_url, req_args=self.req_args,
+                http_verb=self.http_verb,
+                api_url=self.api_url,
+                req_args=self.req_args,
             )

I found that this is due to the discrepancy between VS Code Formatter settings and the black formatted. Although the settings use the black formatted too, it works a bit differently. https://github.com/slackapi/python-slackclient/blob/v2.8.2/.vscode/settings.json#L7-L8
A possible workaround here is to remove the settings from .vscode/settings.json. If there is no concern with this, I will create a pull request for it.

I found that this is due to the discrepancy between VS Code Formatter settings and the black formatted. Although the settings use the black formatted too, it works a bit differently. https://github.com/slackapi/python-slackclient/blob/v2.8.2/.vscode/settings.json#L7-L8

It seems this is not always true. We should keep an eye on this.

As long as you use the scripts under scripts directory and use the right version of black code formatter, this situation should not arise. Let me close this issue now but feel free to write in or reopen when you detect this issue again.


3DSSD runs in 13.23FPS, it is not reach 25FPS in the article, Does Pytorch runs lower than tensorflow?

Thanks for sharing mmdetection3d framwork, It is gorgeous！
But I found a question，why mmdetection3d  3DSSD implementation runs slower?
I modified mmdet3d/apis/test.py line29-49 as below:
    duration = []
    for i, data in enumerate(data_loader):
        with torch.no_grad():
            # added by physu, calculate the FPS
            start = time.time()
            result = model(return_loss=False, rescale=True, **data)
            end = time.time()
            duration.append(end - start)

        if show:
            model.module.show_results(data, result, out_dir)

        results.extend(result)

        batch_size = len(result)
        for _ in range(batch_size):
            prog_bar.update()
    time_sum = 0
    for i in duration:
        time_sum += i
    print("FPS : %f" % (1.0 / (time_sum / len(duration))))

FPS:13.23（official：25fps）

The time calculation in the code is inaccurate because the CUDA computation is asynchronous. To benchmark the speed, you should use this script. Our implementation basically follows that in TensorFlow but we have not checked the speed yet.

Furthermore, from the paper, we are not sure how they benchmarked their speed, so the speed tested in MMDetection's criterion might be different.

Thanks for you reply @ZwwWayne


Non-public Abseil API is used for CLI parsing

Description
Non-public APIs from the absl::flags_internal namespace are used for command-line option parsing.
https://github.com/google/mozc/blob/88d5ef3ff738c9574112c0afba1d2f982ceaa461/src/base/init_mozc.cc#L88-L94
Since this interface is removed in the latest abseil-cpp release, this blocks upgrading Abseil.
Steps to reproduce
Steps to reproduce the behavior:

Examine the lines in the Description section.
Observe that non-public APIs are used.

Expected behavior
Only public APIs are used; upgrading abseil-cpp to the latest LTS release is possible.
Actual behavior
Some non-public APIs are used; upgrading abseil-cpp to the latest LTS release is not possible, resulting in an error like:
../../base/init_mozc.cc: In function ‘void mozc::{anonymous}::ParseCommandLineFl
ags(int, char**)’:
../../base/init_mozc.cc:90:29: error: ‘absl::lts_20230802::flags_internal::ArgvListAction’ has not been declared
   90 |       absl::flags_internal::ArgvListAction::kRemoveParsedArgs,
      |                             ^~~~~~~~~~~~~~

Screenshots
N/A
Version or commit-id
Current master 88d5ef3ff738c9574112c0afba1d2f982ceaa461.
Or, 2.29.5111.102.
Environment

OS: Fedora Linux Rawhide; but this is not a platform-dependent issue
IMF (for Linux) [e.g. Ibus, Fcitx, etc]: N/A
Related Applications [e.g. Chromium 109, gedit, etc]: N/A

Investigations

Whether this issue happens on both Ibus and other IMF (e.g. Fcitx, uim).

N/A

Whether this issue happens on other IMEs (e.g. Anthy, SKK).

N/A

What applications this issue happens on (e.g. Chromium, gedit).

N/A

What applications this issue does not happen on (e.g. Chromium, gedit).

N/A

(optional) What versions or commit-ids this issue did not happen on
(e.g. Mozc-2.28.4960.100+24.11.oss).

N/A

Additional context
I discovered this problem while attempting to upgrade the abseil-cpp package in Fedora Linux, where a patch is used to build mozc with the system copy of Abseil.
https://github.com/abseil/abseil-cpp/blob/20230802.0/absl/flags/internal/parse.h#L45-L53
// This is not a public interface. This interface exists to expose the ability
// to change help output stream in case of parsing errors. This is used by
// internal unit tests to validate expected outputs.
// When this was written, `EXPECT_EXIT` only supported matchers on stderr,
// but not on stdout.
std::vector<char*> ParseCommandLineImpl(
    int argc, char* argv[], UsageFlagsAction usage_flag_action,
    OnUndefinedFlag undef_flag_action,
    std::ostream& error_help_output = std::cout);

Hi musicinmybrain,
Thank you for the feedback.
We are going to update the Abseil version to 20230802.0 in near future. However the latest release of Protobuf does not support the latest Abseil yet. It's a blocking issue for us.

https://github.com/protocolbuffers/protobuf/pull/13534

So we start updating the Abseil version after the new Protobuf (e.g. 24.1) is released. Meanwhile, I hope the following change works on your side. We'd also like to recommend to use a static link without the patch.
void ParseCommandLineFlags(int argc, char **argv) {
  absl::flags_internal::ParseCommandLineImpl(
      argc, argv,
      // Abseil 20230802.0 does not use ArgvListAction
      // absl::flags_internal::ArgvListAction::kRemoveParsedArgs,
      // Suppress help messages invoked by --help and others.
      // Use UsageFlagsAction::kHandleUsage to enable it.
      absl::flags_internal::UsageFlagsAction::kIgnoreUsage,
      absl::flags_internal::OnUndefinedFlag::kIgnoreUndefined);
}

Thanks,

https://github.com/protocolbuffers/protobuf/pull/13534
So we start updating the Abseil version after the new Protobuf (e.g. 24.1) is released. Meanwhile, I hope the following change works on your side. We'd also like to recommend to use a static link without the patch.

Just fyi, the above change in protobuf 24.x branch got reverted at https://github.com/protocolbuffers/protobuf/pull/13597. Whether protobuf 24.x is going to be related with Abseil 20230802.0 looks to be unclear at this moment.

So we start updating the Abseil version after the new Protobuf (e.g. 24.1) is released. Meanwhile, I hope the following change works on your side. We'd also like to recommend to use a static link without the patch.

The patch works perfectly; thank you! For our purposes, the benefits of linking against system-wide shared libraries outweigh the costs of carrying the patch.

We are going to update the Abseil version to 20230802.0 in near future. However the latest release of Protobuf does not support the latest Abseil yet. It's a blocking issue for us.

Just fyi, the above change in protobuf 24.x branch got reverted at protocolbuffers/protobuf#13597. Whether protobuf 24.x is going to be related with Abseil 20230802.0 looks to be unclear at this moment.

Thank you both for mentioning this. We aren’t blocked from updating Abseil for Fedora 39 (largely because we haven’t been able to make the transition to protobuf v4, 22.x and later, yet), but these links will save some time down the road.

cad4064c8884eb711e0e19b4b79d2ff5610823dc fixes the build error with Abseil 20230802.0 by adding the version check.
Thank you for your feedback.

The patch works perfectly; thank you! For our purposes, the benefits of linking against system-wide shared libraries outweigh the costs of carrying the patch.

@musicinmybrain, just fyi, it seems that Abseil exposes different ABIs depending on what C++ language level is chosen when building it. See the following discussions for instance.

https://github.com/gentoo/gentoo/pull/32281
https://github.com/gentoo/gentoo/commit/61d0b43d739b703ee9f25abefb04ba0bdf1ac158

So it's not only about a classical "diamond dependency problem" (*) any more but also a "diamond C++ language level problem". Just as a heads up Mozc will soon start to using C++20 (#783), and what Mozc would expect are abseil built with -std=c++20 and protobuf built with -std=c++20. Perhaps you may end up having to create things like libabsl_base_cpp14.so.2308.0.0, libabsl_base_cpp17.so.2308.0.0 and libabsl_base_cpp20.so.2308.0.0.
(*) https://abseil.io/resources/swe-book/html/ch21.html

The diamond dependency problem, and  other forms of conflicting requirements, require at least three layers of dependency, as demonstrated in Figure 21-1.

Figure 21-1. The diamond dependency problem

@musicinmybrain, just fyi, it seems that Abseil exposes different ABIs depending on what C++ language level is chosen when building it.

Thanks for pointing that out. I’m aware of the significant ABI difference from C++14 to C++17; we handled it by making sure all packages that depend on abseil-cpp are compiled as C++17 or later. So far, we haven’t encountered any problems linking packages built as C++20 to abseil-cpp built as C++17, but it’s possible we are just living dangerously and have yet to encounter the problems we are creating. It’s possible to bump everything up to C++20, but once we move over to protobuf v4 (22.x, 23.x, ...) and the generated protobuf bindings start to depend on Abseil, the number of packages impacted by such a change will be much larger, so I hope this won’t be necessary. It would still probably be a more workable approach than having multiple versions of the Abseil shared libraries with different ABIs that can’t be linked together.


Regarding Spelling Error model

Thanks for amazing toolkit :) Can you please share your views on below questions

How does correct_prior & incorrect_prior calculation done in Error model ?
How do we incorporate "count" with incorrect-correct pair e.g. if training data is in form of (intended_word, observed_word, count).
Is there any other way we can combine LM score & EM score in LM beam search method ?

Thanks a lot !!

Hi @smilenrhyme,
Thank you for your kind comment

The priors were chosen empirically when trying to maximize accuracy on the kartaslov dataset for Russian language
The simplest way, I think, would be to just repeat the pair that many times.
One could try and add some constant scaling to EM probabilities. Or train a simple ranking model that would do the same but automatically. We tweaked the probabilities for the simple Levenshtein model but not the BrillMoore one.

Thanks for quick response :) Some more points

Do you mean maximizing accuracy on End-to-End Spell task w.r.t above point 1 ? Or measure Error model in isolation ?
Just to clarify, even with "occurance_count" equation would be same because  p = c / e (ignoring priors) so p = (c * occurance_count) / (e * occurance_count). So the "p" value remains same. Is this correct ?

In addition,
3. Getting edit distance = 3 for 'invetar' <-> 'inverter' while training (where we are splitting word into chars with spaces) otherwise if we call directly "_distance_edits" its 2. Is that correct ? and any reason for not to consider words with more than 2-edit in training.
Thanks once again !!

Hi @yoptar, Could you please share your thoughts for above points. It would be very helpful for me. Thanks a lot.

Hi @smilenrhyme, sorry for the late response.

I meant error model in isolation
Yes, occurrence count by itself does not change the p value, but since we are talking about characters and character groups, c and e ration will most likely change, because the same characters and character groups also occur in other words
I didn't understand about splitting words in chars, I'm not sure it should happen. We skipped errors with more that 2-edit because in the kartaslov dataset most of those words are really weird, they would just mess up the probabilities.

@yoptar Thanks a lot once again :)

Could you please suggest some metric to measure error model accuracy in isolation (Task independent).
It clears out my doubts 👍
For example :
print(model._distance_edits("invetar", "inverter"))  --> 2
print(model._distance_edits("⟬i n v e t a r⟭", "⟬i n v e r t e r⟭"))   --> 3  [It got filters out in error_model .fit() method as we are ingoing pairs with more than 2 edit. ]
Note : this is happening because '⟬{}⟭'.format(' '.join(correct)) [Join with space character]
This might be a bug, not sure just wanted to highlight here.

In addition,

Could you please suggest performance improvements for _find_candidates_window_n method given that all valid words are provided as input for given incorrect token (no need for trie/dictionary based lookup). Due to multiple nested levels of for-loops, its taking huge amount of time when using in practice.

Would like to add improvements as PR 👍

I couldn't think of anything better than a simple accuracy when comparing misspellings with the highest error model probability against a correct word. One could also look at top 2 and top 3 corrections.

Yep, that's a bug, thank you for noticing. I think, I added that to be able to build error models on sentences and not just words, but it did not work then and I just left it there... It also looks like it's not the only problem, because I still get scores worse than on a pretrained error model for Russian language that one can download form our servers,  even after the spaces are removed. I'll try to figure it out, thanks again.
I couldn't find other ways to improve the algorithm itself when I wrote it. One can try and rewrite it using Cython or even raw C, it should add some boost in performance, but I'm not sure if it's worth it.

I'll assume that the issue is resolved for now. Feel free to reopen it or create a new one if you have any further questions.

@yoptar Thanks for overwhelming response :)
Few more points, after using in practice

Should we do inference only on max-edit=2 in error model as we are training with same max distance ?
What is intuition behind having this threshold : prop_threshold=1e-6 and how its obtained.
The output score which comes out at spell correction level is log_prob. If we convert into usual probability, the output_prob is very very small (of order of 10 ^ -28). Given this range, how do we compute model operating point (with some precision & recall). Any thoughts.
Could you suggest some hints w.r.t  conditioning on the position of the
edit relative to the source word (which is mentioned in noisy channel error model paper) w.r.t current code e.g. {start_of_word, middle_of_word, end_of_word}
Is this useful https://nlp.stanford.edu/pubs/toutanova2002spelling.pdf (modelling phonetic errors) ?

Thanks a lot once again 👍

if I remember correctly, we can use any max-edit smaller or equal then the one we used in training, as "training" itself is just a statistics calculation.
1e-6 was set empirically to speed up the trie search a little without drastically affecting scores on our data. but it should have been an initialization parameter.
I don't know what model operating point is, sorry
For this I've added special characters to mark word's beginning and end (⟬ and ⟭) so that they would be taken into account in the model.
sure, I think that phonetics should be used as a feature in a perfect spelling correction algorithm, but it can also slow everything down even more :slightly_smiling_face:

@yoptar Thanks a lot :)

@yoptar Found some more points for discussion,

Here candidate is getting split into words. Shouldn't we query LM directly without split ? (pros/cons)
https://github.com/deepmipt/DeepPavlov/blob/c10b079b972493220c82a643d47d718d5358c7f4/deeppavlov/models/spelling_correction/electors/kenlm_elector.py#L67

Here we are overriding error probability to its max value, that means only LM score will going to play role into final ranking. Is there any better way of handling this.
https://github.com/deepmipt/DeepPavlov/blob/c10b079b972493220c82a643d47d718d5358c7f4/deeppavlov/models/spelling_correction/brillmoore/error_model.py#L138

Thanks a lot for the throughout support 👍

@yoptar please share your thoughts for above points. Thanks a lot !!

Hi @smilenrhyme,

the LM wont know how to score two or more tokens disguised as one, it wasn't trained on such data. This is done for cases where we assume spaces were skipped in a correct sentence.
We do not change this word so it doesn't really matter what probability to it, only LM score will fluctuate depending on a beam in the beam search.

Thanks @yoptar :)
Just to clarify point number 1, is this true even when LM(KenLM) was trained with order 4 and each training instance was "a sentence including spaces" per line.

@yoptar please share your views on above point. Thanks a lot :)

Hi @smilenrhyme,
I think the order was 3. And yes, there was a sentence per line with spaces included

@yoptar if it is trained on such data then should not we query LM directly without split into words ?
Thanks !!
P.S Sorry for asking too many questions.

Tokenization is included in the training process. We're using a low level method for calculating current score, and it requires a single token as its input.
You can try it and prove me wrong, of course. :slightly_smiling_face:

@yoptar Yes its at word level, just went through the code documentation. Below is the example but not sure what is the difference though. (It does not throw any error)
In [60]: s1 = kenlm.State()
In [61]: s2 = kenlm.State()
In [62]: model.BeginSentenceWrite(s1)
In [63]: accum = 0.0
In [64]: accum += model.BaseScore(s1, "a", s2)
In [65]: accum += model.BaseScore(s2, "sentence", s1)
In [66]: accum += model.BaseScore(s1, "</s>", s2)
In [67]: accum
Out[67]: -9.504997849464417

In [68]: accum = 0.0
In [69]: s1 = kenlm.State()
In [70]: s2 = kenlm.State()
In [71]: model.BeginSentenceWrite(s1)
In [72]: accum += model.BaseScore(s1, "a sentence </s>", s2)
In [73]: accum
Out[73]: -8.628549575805664

@yoptar Got the answer, In the second case its "unknown" probability. It does not change even we add tokens to that.
Thanks for your time and support :) 👍

@yoptar
One suggestion to improve on current strategy, in below code snippet we are iterating over all prefixes. Can we use LevenshteinSearcher style to lookup candidates up to certain edit distance with combination of error model probabilities.
https://github.com/deepmipt/DeepPavlov/blob/c10b079b972493220c82a643d47d718d5358c7f4/deeppavlov/models/spelling_correction/brillmoore/error_model.py#L110
Please share your thoughts. Thanks 👍

@yoptar In addition to above,
Could you please suggest some pointers/code changes required to support "Phrase based" error probabilities. I have come across this but not sure how this can be fit in current settings.
Thanks a lot :)

@yoptar Please provide your useful comments on above questions, Thanks a lot !!

@yoptar please provide your views. It would be a lot of help for us. Thanks.

Hi @smilenrhyme,
I'm sorry, but I didn't read that paper. I haven't done anything in spelling correction for some time so I'm not really up to date in that field. We do have a new spelling correction model in development, but I don't know a lot about it yet. I suggest you ask this question in our forum.

Thanks a lot 👍


feat: Qdrant vector storage

Description
This PR adds support for Qdrant - https://qdrant.tech to be used as a vector storage.
Notes
To run Qdrant
docker run -p 6333:6333 qdrant/qdrant

To use the vector store,
store = QdrantVectorStore(collection_name="some-name")

store.connect(url="http://localhost:6333") # Accepts all the Qdrant client options

store.load_documents(...) # Auto-creates a collection

store.similarity_search_by_vector(...)

store.similarity_search_by_text(...)

Currently milvus do not support higher version of environs, so we change it into environs = "^9.5.0", but from what I have tested, it does not affect other normal usage.

Thank you for this contribution. Please give us just a little time to decide on an appropriate approach to take for community contributions, to make it easy without too much coupling.

Hey @jgbradley1. Just bumping this.

Hey @jgbradley1. Just bumping this PR. Is there any progress on this?

@AlonsoGuevara, could you help review please?

Hey @jgbradley1. Just bumping this PR. Please take a look when possible.
Thanks.

Any update on this PR ?


chore(main): release remnote-plugin-template-react 0.2.3

:robot: I have created a release beep boop
0.2.3 (2024-11-30)
Bug Fixes

release (e0a57e6)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

remnote-plugin-template-react-v0.2.3
:sunflower:


Add support for ocamlformat

It would be nice to support ocamlformat as an alternative to ocp-indent. In order to do this we will need to add a setting to allow the user to configure which formatter to use.

:necro: it would be nice indeed :D

And there was much joy
Thank you!