Roll Engine from fab19829949d to 83d99a58097b (31 revisions)

<EMAIL_ADDRESS>2022-01-14<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 35I2K_Bou... to V541xkYVr... (flutter/engine#30879)
2022-01-14<EMAIL_ADDRESS>Roll Dart SDK from dcab0d0b2f6c to d0d4dbfc6e69 (1 revision) (flutter/engine#30878)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 1f0e64acd621 to f260a297c68d (1 revision) (flutter/engine#30877)
2022-01-14<EMAIL_ADDRESS>[fuchsia] stamp package with target api level (flutter/engine#30857)
2022-01-14<EMAIL_ADDRESS>Roll Skia from dd9e165ef7d0 to 1f0e64acd621 (1 revision) (flutter/engine#30876)
2022-01-14<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from BQ2l2096A... to bGW3xlB1D... (flutter/engine#30875)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 7aec4b164e79 to dd9e165ef7d0 (1 revision) (flutter/engine#30874)
2022-01-14<EMAIL_ADDRESS>Roll Dart SDK from 68ccd13498be to dcab0d0b2f6c (1 revision) (flutter/engine#30872)
2022-01-14<EMAIL_ADDRESS>Roll Dart SDK from aa6fbac07951 to 68ccd13498be (1 revision) (flutter/engine#30870)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 76e62d32d979 to 7aec4b164e79 (1 revision) (flutter/engine#30869)
2022-01-14<EMAIL_ADDRESS>Roll Skia from a6f2ebf30fea to 76e62d32d979 (1 revision) (flutter/engine#30868)
2022-01-14<EMAIL_ADDRESS>Roll Dart SDK from ba044d5e9c03 to aa6fbac07951 (1 revision) (flutter/engine#30867)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 7c80b2f08ead to a6f2ebf30fea (1 revision) (flutter/engine#30863)
2022-01-14<EMAIL_ADDRESS>[Windows, Keyboard] Lift key event redispatching to KeyboardManagerWin32 (flutter/engine#30702)
2022-01-14<EMAIL_ADDRESS>Ensure that PlatformViewIOS does not call into Shell semantics APIs during destruction (flutter/engine#30835)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 119fb6bb2568 to 7c80b2f08ead (1 revision) (flutter/engine#30862)
2022-01-14<EMAIL_ADDRESS>Roll Dart SDK from b36d861d5487 to ba044d5e9c03 (1 revision) (flutter/engine#30861)
2022-01-14<EMAIL_ADDRESS>Roll Skia from 62b32180c192 to 119fb6bb2568 (1 revision) (flutter/engine#30860)
2022-01-14<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from Uvw9UoGSm... to BQ2l2096A... (flutter/engine#30859)
2022-01-13<EMAIL_ADDRESS>Move SoftwareCanvasProvider into its own source file (flutter/engine#30856)
2022-01-13<EMAIL_ADDRESS>Roll Skia from c505bdca9d60 to 62b32180c192 (1 revision) (flutter/engine#30855)
2022-01-13<EMAIL_ADDRESS>Create a DisplayList benchmarks dylib on iOS (flutter/engine#30833)
2022-01-13<EMAIL_ADDRESS>Don't retain the MTLTexture or MTLDevice in TestMetalContext (flutter/engine#30832)
2022-01-13<EMAIL_ADDRESS>Roll Skia from 455e580b9c78 to c505bdca9d60 (1 revision) (flutter/engine#30852)
2022-01-13<EMAIL_ADDRESS>Roll buildroot to 7effd69. (flutter/engine#30851)
2022-01-13<EMAIL_ADDRESS>Remove unused field initializing formal parameters. (flutter/engine#30822)
2022-01-13<EMAIL_ADDRESS>Roll Dart SDK from f1c98a571d1a to b36d861d5487 (1 revision) (flutter/engine#30850)
2022-01-13<EMAIL_ADDRESS>Roll Skia from 759bc62a06d2 to 455e580b9c78 (2 revisions) (flutter/engine#30849)
2022-01-13<EMAIL_ADDRESS>Remove usages of deprecated setSystemUiVisibility() (flutter/engine#29493)
2022-01-13<EMAIL_ADDRESS>Roll Skia from b21c4af0f670 to 759bc62a06d2 (3 revisions) (flutter/engine#30848)
2022-01-13<EMAIL_ADDRESS>[fuchsia] Switch from core-jit to core snapshots. (flutter/engine#30744)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 35I2K_BouXUN to V541xkYVrdUC
fuchsia/sdk/core/mac-amd64 from Uvw9UoGSmIjy to bGW3xlB1DoAm

@iskakaushik Do you still need this PR or can we close it?


Ventifus/security waves 2 vulns

Which issue this PR addresses:

Fixes
What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?


BUG: List of favorites is not updated after first visit to "Favorites" page

After initially viewing a set of favorite bike stations in the "Favorites" page, the list remains static no matter how many favorite stations are added/removed from the list.
To reproduce:

Launch the app and select a city from the list
When the bike stations draw, click a few stations in the map and then click the button in the callout to make them favorites

Go to the favorites page; you will see the list of stations you made favorites

Return to the map and add more favorites (or unfavorite some of your favorite stations)
Go to the favorites page again and you will see the same list

I see the issue with this one.
The favorites list in XAML is bound to this dictionary in the VM:
    [ObservableProperty]
    private Dictionary<long, Favorite> _favoriteBikeStations = new();

The dictionary is an observable property in the VM, but the dictionary itself is not observable (indeed, no ObservableDictionary exists in standard .NET). The first time the page is opened it picks up the initial values from the dictionary as this is the first time the VM is accessed and bound; but, once the page is setup, the dictionary gives no INPC / collection-changed notifications so new favorites are not updated in the list.
This fix is probably to make FavoriteBikeStations an ObservableCollection<Favorite>. This does force a search of the collection in CheckIsFavorite which could be slow if there are tons of favorites - but doesn't seem like that would be the case.

Thanks, @gdestigter!
I kept the dictionary for maintaining a unique list of favorites and then use an observable collection to bind the favorites. I might clean up this logic later, but it works for now 👍
https://github.com/ThadT/bike-rental-stations-maui/blob/main/ViewModel/CityBikesViewModel.cs#L149-L166


Only show welcome text on MyObs header when scrolled to the top

Currently we show the welcome text whenever the user scrolls up, no matter where they are in the list. The welcome text is mostly a nicety and isn't necessary when you're scrolling through your observations, so let's only show it when the top of the list is on screen.
This might also be a solution to #1258

Not happening after redoing header scroll hiding.


[V3-RC3] Tilling sprite have a wrong internal scale with WebGLRenderer

Hello,
When using a TillingSprite with a WebGLRenderer, the sprites are not correctly displayed. Each repetition occured at the correct position, but the texture itself is streched (and croped by the repetitions).
The display is correct with the CanvasRenderer.
You can see this behavior here : http://jsfiddle.net/99L7nwaw/4/
I suspect the method TilingSprite.generateTilingTexture, but it's just a blind guess.

should work like a champ now! thanks for sharing, the fiddle made it easy to diagnose and fix :+1:

Hi!,
It's fine now, but if you use a texture with alpha, and create two TilingSprite with different textures with a WebGLRenderer, the second sprite is a mix of both textures. -> https://jsfiddle.net/99L7nwaw/5/

great catch! fixed now in the dev branch. :+1:


Bump fastavro to 1.7.0

This is the version which contains the fix for #44 as seen on waldo

(Was just released today)

Closing as we don't actually pin fastavro right now... (arguably we should, but only arguably)


Running a script without --zksync triggers missing libraries check for zksync

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.0.2 (13497a5 2024-05-15T00:25:37.094964000Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
When running a script without the --zksync flag, it seems missing libraries check is triggered anyway. It then crashes, because it can't find zksolc compile output.
❯ forge script script/DeployL1.s.sol --legacy --ffi --rpc-url=http://localhost:8545 --broadcast --slow --private-key=REDACTED
[⠒] Compiling...
No files changed, compilation skipped

The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error("missing field `contracts`", line: 1, column: 1217)
Location: crates/zksync/compiler/src/zksolc/compile.rs:1107

This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 9 frames hidden ⋮
  10: foundry_zksync_compiler::zksolc::compile::ZkSolc::compile::he41cab4779f2902c
      at <unknown source file>:<unknown line>
  11: forge::cmd::script::build::<impl forge::cmd::script::ScriptArgs>::build::hf8194dad283e01fa
      at <unknown source file>:<unknown line>
  12: forge::cmd::script::cmd::<impl forge::cmd::script::ScriptArgs>::run_script::{{closure}}::hc24074b4a4e2d0b9
      at <unknown source file>:<unknown line>
  13: foundry_cli::utils::block_on::hfa647b8d8000f303
      at <unknown source file>:<unknown line>
  14: forge::main::h85a69268cabd810c
      at <unknown source file>:<unknown line>
  15: std::sys_common::backtrace::__rust_begin_short_backtrace::hc3326221b2ab2c14
      at <unknown source file>:<unknown line>
  16: _main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
zsh: abort      forge script script/DeployL1.s.sol --legacy --ffi  --broadcast --slow

Gd


Add debug logging in teardown

Signed-off-by: Peter Gubka<EMAIL_ADDRESS>

Coverage increased (+0.07%) to 50.538% when pulling a687ad6104fa733cc31cbb4b5e0d36de510bd76a on pgubka:master into 83504cb83b2c28548c69d3c339aae032804e6426 on contiv:master.


Deleting OBJ file in FileSystem dock doesn't remove the corresponding MTL file

Godot version
4.0.3
System information
Windows 10, RTX3070
Issue description
When you delete an obj file in the editor, the file gets deleted but not the mtl. This results in many unnecessary files - unused data blocks.
Steps to reproduce
import any .obj file and delete it inside Godot.
Minimal reproduction project
not needed

Currently Godot has no way to track that a given MTL file is related only to a given OBJ, and no logic in place to delete the MTL if the OBJ is deleted.
This could possibly be added, but there are some issues to consider:

As far as I know, a MTL file can be used by multiple OBJ files. So it would need some form of dependency tracking so it doesn't remove MTL files shared between multiple OBJ files, unless all those OBJ files are being deleted.
There's just no system in place to delete multiple files when the user asked to delete a single one. Since the MTL files don't show in the FileSystem dock, this can be unexpected and confusing.

if you can make the mtl visible then you can consider closing this issue. Thank you for your kind explanations everyone.

if you can make the mtl visible then you can consider closing this issue. Thank you for your kind explanations everyone.

If you add ,mtl at the end of Docks > FileSystem > Textfile Extensions in the Editor Settings, MTL files should appear in the FileSystem dock in 4.0 and later:


glMultiDrawArrays/glDrawArrays show-stopper

For some unknown reason these two just deny working on "windows":

on "nvidia" - segfault
on "ryzen" - black screen

glGetError() remains silent.
Doesn't fix the issue:

init. the wgl procs using the "SDL2" "Open GL" context
pass pre-allocated buffer to glBufferData()
_aligned_malloc()/_aligned_free()
profile: core/compat
"glee"

Solution: glDisable (GL_COLOR_ARRAY) for a VBO that is not using it - no matter it is not setting glColorPointer() ever.


Fixup docs changes lost in the aether

Not sure what happened here but the 0.2.0 => 0.3.0 change got swallowed up.
cc @ehazlett @moxiegirl
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

LGTM

LGTM


Permit nested block elements

A TODO comment in the original html-janitor.js mentioned that nested block elements are removed automatically but that nested blocks aren't invalid mockup. I needed nested blocks in my code so I coded this TODO with an option to keep nested blocks.

Looks good to me! I'll try and put a release together soon.

Actually @christopherliu it might be good to have tests for both conditions on the config otherwise I'm worried we might regress this in future

@christopherliu I actually wrote the tests this afternoon and it does all look good I will merge and sort out later

Thanks @rrees!


expose Parser.Advanced

some docs seem to speak as though Parser.Advanced should be exposed
https://github.com/elm/parser/blob/828a7903226430e86eb644d89f49dd901990f79b/src/Parser.elm#L133-L134
but it isn't exposed
https://github.com/elm/parser/blob/828a7903226430e86eb644d89f49dd901990f79b/elm.json#L7-L9

I'm working on it! I wasn't able to get it out with the initial release of 0.19.


Entropy-based password length

Since it's possible to use different wordfiles, using number of words to specify the passphrase length can produce variably strong passphrases, depending on the wordfile.
User should have an option to specify required entropy / password strength which would take into account the length of the wordfile and produce a passphrase of similar strength regardless of the wordfile that is used.
Example:
$ xkcdpass -w legacy -e 75
nucleus Mboya Moldova Scopes parody
$ xkcdpass -w eff-long -e 75
affair ounce hatchback guidance cubical onlooker
$ xkcdpass -w eff-short -e 75
delay dizzy agile ebony twirl tweak aloft quake

This approach should be used as default when no specific word limit is provided. Entropy could be specified in passphrase strength levels instead of bits. A warning could also be displayed on error output for low entropy passphrases.
This feature would most likely have to be mutually exclusive with acrostic.

This feature would most likely have to be mutually exclusive with acrostic.

See PR #61, which should address your concerns. With that fix implemented, I suppose you could repeat the acrostic as many times as necessary to reach the desired entropy (or use less letters, if the requested entropy is low).


Fix a bug where biometrics button was not showing

This PR should fix a bug where the biometrics button was not showing after the user deleted the previously inputted value

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (c6d7cde) 66.90% compared to head (b7da43b) 72.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
+ Coverage    66.90%   72.54%   +5.64%
===========================================
  Files          137        3     -134
  Lines         5055       51    -5004
===========================================
- Hits          3382       37    -3345
+ Misses        1673       14    -1659

see 134 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing due to the issue being outdated.


Add accessibility label to touchbar buttons

Hey,
the buttons in VSCode are not labeled for VoiceOver, because this buttons use only icons. I understand, that icons are better as text labels. I searched in the code of electron, whether we can easily use a accessibilityLabel, that VoiceOver can read out. This has the advantage that the design of the Touch Bar-elements haven't to change, only a attribute have to add.
I found out, that electron don't offer a accessibilityLabel for Touch Bar-controls, so I opened a issue.
here is the issue fixed, very fast. :-)
So, electron offers now an AccessibilityLabel for Touchbar-controls.
Hopefully this feature can be merged in VSCode.
When this is not possible, in the next time, a work-around can be, to use text labels, if the accessibility mode is turned on.
What do you think?
best regards,
Christopher

Sounds good. It will probably be another 3-6 months before we go with a newer Electron version (>6) so we need to wait for that.

What's the Roadmap on updating Electrons? I just received my first 1.45 nightly, but it's still not got even Electron 8 (stable since 2 months ago: https://www.electronjs.org/releases/stable?page=2), and judging by the VSC release history (https://github.com/microsoft/vscode/releases), Electron 9 could still even make it to stable before the final 1.45 is out (https://www.electronjs.org/docs/tutorial/electron-timelines).

@christopherpross unfortunately I do not see support for an accessibility label in the touchbar classes we use in VSCode: TouchBarSegmentedControl has an array of SegmentedControlSegment which do not provide any accessibility label:

Maybe you could ask for support in Electron repo.

Hm, so here is the issue I had created for this:
https://github.com/electron/electron/issues/20443
and this is the pr which resolves my issue, there is also a small description how it is now resolved:
https://github.com/electron/electron/pull/20454
I hope it helps.
all the best,
Christopher

@christopherpross I am aware of the issue and the change, but VSCode is not using TouchBarButton or TouchBarLabel for the touchbar support. We need this API on the level of TouchBarSegmentedControl.

Touchbar is going away on latest macs. thus closing as out of scope


Update pull request template to include tips

Signed-off-by: Rabi Panda<EMAIL_ADDRESS>Description
Add commented tips in pull request template
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #4851 (8a0ffaf) into main (ec34737) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4851      +/-   ##
============================================
+ Coverage     70.70%   70.82%   +0.11%
- Complexity    57852    57912      +60
============================================
  Files          4689     4689
  Lines        277080   277080
  Branches      40302    40302
============================================
+ Hits         195917   196236     +319
+ Misses        64935    64592     -343
- Partials      16228    16252      +24

Impacted Files
Coverage Δ

...ch/transport/ReceiveTimeoutTransportException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

.../index/shard/IndexShardNotRecoveringException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

...opensearch/persistent/PersistentTasksExecutor.java
22.22% <0.00%> (-44.45%)
:arrow_down:

.../admin/cluster/reroute/ClusterRerouteResponse.java
60.00% <0.00%> (-40.00%)
:arrow_down:

...luster/routing/allocation/RoutingExplanations.java
62.06% <0.00%> (-37.94%)
:arrow_down:

...java/org/opensearch/threadpool/ThreadPoolInfo.java
56.25% <0.00%> (-37.50%)
:arrow_down:

...nsearch/index/shard/IndexShardClosedException.java
66.66% <0.00%> (-33.34%)
:arrow_down:

.../search/aggregations/pipeline/HoltLinearModel.java
20.33% <0.00%> (-32.21%)
:arrow_down:

...cluster/routing/allocation/RerouteExplanation.java
70.00% <0.00%> (-30.00%)
:arrow_down:

... and 482 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I believe this has been fixed in https://github.com/opensearch-project/OpenSearch/pull/4270, rebase?


Add PMIC, ADC, and GPIO Expander targets

You cannot add generic i2c devices anywhere in the system tree.  If you want to use access them via i2c bus, then there needs to be a right i2c bus with driver before you can start adding i2c devices.

Are all the targets at the same level as DIMM target in P10 device tree?
All the patches require fixing spaces to tabs.

Are all the targets at the same level as DIMM target in P10 device tree?

No, All these targets are placed under OCMB like MEM_PORT.

All the patches require fixing spaces to tabs.
Sure, will fix it

@amitay @ojayanth addressed the comments, please take a look

Merged.


wpewebkit: Remove patch to FELightningNEON

Remove patch to FELightningNEON. This commits removes the patch to FELightningNEON from recipe wpewebkit version 2.40. In this version of wpewebkit the patch is not correctly applied and causes a build error.

Which one is the build error? can you upload it somewhere and paste here the link to the log with the build error?

Hi @clopez
The error is when the patch is applied in the source code. The error reported with the patch is below:
log.do_patch.126979.txt
The target machine in the local.conf is:
MACHINE = 'raspberrypi4'
If you need any more information or testing, please contact me.

I see that the patch applies but with fuzz.
It seems Yocto 4.2 Mickledore made this warning a fatal error by default:\
documentation/migration-guides/migration-4.2.rst-Patch QA checks
documentation/migration-guides/migration-4.2.rst-~~~~~~~~~~~~~~~
documentation/migration-guides/migration-4.2.rst-
documentation/migration-guides/migration-4.2.rst-The QA checks for patch fuzz and Upstream-Status have been reworked
documentation/migration-guides/migration-4.2.rst-slightly in this release. The Upstream-Status checking is now configurable
documentation/migration-guides/migration-4.2.rst-from :term:`WARN_QA` / :term:`ERROR_QA` (``patch-status-core`` for the
documentation/migration-guides/migration-4.2.rst-core layer, and ``patch-status-noncore`` for other layers).
documentation/migration-guides/migration-4.2.rst-
documentation/migration-guides/migration-4.2.rst:The ``patch-fuzz`` and ``patch-status-core`` checks are now in the default
documentation/migration-guides/migration-4.2.rst-value of :term:`ERROR_QA` so that they will cause the build to fail
documentation/migration-guides/migration-4.2.rst-if triggered. If you prefer to avoid this you will need to adjust the value
documentation/migration-guides/migration-4.2.rst-of :term:`ERROR_QA` in your configuration as desired.

The right fix is not to remove the patch but to update it to apply without fuzz
Can you try PR https://github.com/Igalia/meta-webkit/pull/472 to see if it fixes the issue for you?

Hi @clopez
PR #472 worked fine for me, without compilation or patching errors. Wpewebkit worked fine too
Thanks.

Closed in favour of #472


Content group simple:  Image and video variations designs & design specs provided by the AEM designers

Notes

The AEM team is responsible for creating the visual designs and design specs for the additional variations to the content group simple.   This issue is to track the transition of the AEM design work to the DDS design & engineering team members.

Additional Information

Visual Designs & Design Specs Box folder link
Delivery date to be provided by Sandeep Bahl

Acceptance Criteria

[ ] Visual designs and specs received from AEM designers
[ ]  A pdf file is created and placed in the Box folder with the updated Sketch file
[ ] Meetings conducted with DDS team members to review the designs

This a feature that will be delivered in the April release.  video player onclick enhancement.  (#5245 )  Closing


[DOCFIX] - Updates + small fixes

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15807/
Test PASSed.


path to 1.0

Ive been going through our dependencies and I saw that this crate is pre-1.0 and also didn't have a tracking issue for getting there. I wanted to post this to see if there was a plan for getting to 1.0. Considering how few issues have been posted with this crate and how often it's used, I'd think it would be pretty close to a 1.0, so wanted to check in here to see what the maintainers think.

See #28

Sorry, was looking for it in the title.


Suggestion: Watch/Monitor Folder for New Images

Love this app as-is.
One additional feature that would be great is the ability to monitor/watch the folder for new image additions.

Yeah, I'm planning on adding a refresh feature. Having some sort of watch system would be great too

https://github.com/JonahGrimm/Meisunry/releases/tag/v11


has python 3.6 support been dropped?

I get the follwing error using python 3.6:
Traceback (most recent call last):
  File "C:/Users/chrisb/GitWS/pyadsStructureNotificationTest/main.py", line 1, in <module>
    import pyads
  File "C:\Users\chrisb\GitWS\pyadsStructureNotificationTest\venv\lib\site-packages\pyads\__init__.py", line 10, in <module>
    from .ads import (
  File "C:\Users\chrisb\GitWS\pyadsStructureNotificationTest\venv\lib\site-packages\pyads\ads.py", line 8
    from __future__ import annotations
    ^
SyntaxError: future feature annotations is not defined

looks like the last version to support python 3.6 is 3.3.4


Tests

We need more tests. Let's add some. I will link it with CI.

Are there some thing already set up?

Yes Sir there is. Just a single unit test. https://github.com/x-team/mr.moody/blob/master/modules/tests/attachmentsResolver.test.js
We are testing with jest.
Now, I think there is little need for unit tests in here. It might be cool to add some mocks for services we use and write tests for some of the modules ( chat, report ). Possibly controllers as well.
Chat is using slack api and report firebase api.


agg: disable building of examples to fix build

Motivation for this change
Previously the build was failing with due to not being able to find libexamples.la.
/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash ../libtool  --tag=CXX   --mode=link g++  -g -O2 libexamples.la  .
./src/platform/X11/libaggplatformX11.la ../src/libagg.la  -o alpha_mask2 alpha_mask2.o
libtool:   error: cannot find the library 'libexamples.la' or unhandled argument 'libexamples.la'

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build agg

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: agg
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: agg
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggplatformX11.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggfontfreetype.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libaggplatformsdl.so.2.0.4
shrinking /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib/libagg.so.2.0.4
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5/lib
patching script interpreter paths in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5
checking for references to /build in /nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5...
/nix/store/iciqiganyw47hgw1ba0jjl2y13xhi4yc-agg-2.5

Success on aarch64-linux (full log)
Attempted: agg
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggfontfreetype.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggplatformsdl.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libaggplatformX11.so.2.0.4
shrinking /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib/libagg.so.2.0.4
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5/lib
patching script interpreter paths in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5
checking for references to /build in /nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5...
/nix/store/cq49x3m06qd9gsp6gf79nwm6vrhm626v-agg-2.5


Add handling for a 5-green-fake-out

This is when your answer has five greens but one of them is a lie (meaning it must be a black, can't be yellow because there's nowhere it could go).

Done in 292a180


How do I get it to work with Affinity Photo 2?

I want to use stable diffusion in affinity but I seem to get issues with the repo

I have the same question, I'm very interested in making this work inside Affinity Photo :)


New Website Logo: ProtoPie

Please fill the following out:

Name: ProtoPie
Homepage url: https://www.protopie.io
Brand Guidelines/Licensing: -
Logo:

Thanks. Added to the site. Should be live next week.


Multi fixed Columns can't show the scroll-x

for the issue
https://github.com/wenzhixin/bootstrap-table/issues/2031

Thanks!


[1.11] Fix validation of overlay backends

High-level description
test_endpoints.test_if_overlay_master_agent_is_up fails for 1.11 upgraded clusters.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-46506 test_endpoints.test_if_overlay_master_agent_is_up fails for 1.11 upgraded clusters

Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: it's a fix for integration tests.
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label [Ready For Review]


Add Emigo Connector

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@microsoft-github-policy-service agree [company="{Sagra Technology}"]
From: microsoft-github-policy-service[bot] @.>
Sent: 03 November 2022 14:49
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
@tomaszsagrahttps://github.com/tomaszsagra please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
Contributor License Agreement
Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1302143634, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFDYK77W323QRPLA7DTWGO7GNANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

@microsoft-github-policy-service agree company="Sagra Technology"
From: microsoft-github-policy-service[bot] @.>
Sent: 03 November 2022 14:53
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
@tomaszsagrahttps://github.com/tomaszsagra the command you issued was incorrect. Please try again.
Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1302147805, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFE4B3EA37R4VLAB5WLWGO7SFANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

Hello @tomaszsagra,
Thank you very much and congratulations on your new submission. Our Certification Engineers will review it within 1-2 weeks.
Please let us know if you have any questions.
Thank you very much again for working with us.

Hi Amjed, I’ve some issue during publishing Custom Connector for my Company Sagra Technology with API Properties Validator. The errors are not clean for me. Could you help me please? Best Regards Tomasz Margacz @.*** From: Amjed Ayoub @.> Sent: 03 November 2022 22:08 To: microsoft/PowerPlatformConnectors @.> Cc: Tomasz Margacz @.>; Mention @.> Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118) Hello @tomaszsagrahttps://github.com/tomaszsagra, Thank you very much and congratulations on your new submission. Our Certification Engineers will review it within 1-2 weeks. Please let us know if you have any questions. Thank you very much again for working with us. — Reply to this email directly, view it on GitHub<#2118 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFC7FBZ5J2GME65JVBTWGQSTRANCNFSM6AAAAAARVCEDWQ. You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

@tomaszsagra you can ignore those errors.

Hi Amjed,
Thank you so much for your suggestions.
I have one more question: Do I need to generate script.csx file? If so, do you have instruction how to create this file.
Best Regards
Tomasz Margacz
senior software developer
+48 606 250 070
<EMAIL_ADDRESS>30 years of activity
www.sagratechnology.comhttp://www.sagratechnology.com/
@.***
This e-mail is property of Sagra Technology and may contain business secrets, confidential and/or privileged information. If you are not the intended recipient (or have received this e- mail by mistake) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
From: Amjed Ayoub @.>
Sent: 04 November 2022 20:26
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
@Amjed-Ayoub requested changes on this pull request.

In certified-connectors/Emigo/Readme.mdhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#discussion_r1014283015:

@@ -0,0 +1,48 @@

+#Title
+It will enable the achievement of goals set for the sales force. It will ensure effective activities in shops, pharmacies or with medical staff. Connector Emigo will be increase the effectiveness of sales teams in their daily activities.
@tomaszsagrahttps://github.com/tomaszsagra all files should be free of grammatical errors and typos. please remove "be" from the sentence "Connector Emigo will be increase" => "Connector Emigo will increase".

In certified-connectors/Emigo/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#discussion_r1014285460:

   "OpuId",

   "Message"

 ],

 "type": "object",

 "properties": {

   "OpuId": {

     "format": "int32",

     "type": "integer"

   },

   "Message": {

     "type": "string"

   }

 }

},

"TableMetadata": {

 "description": "Metadane tabeli",

@tomaszsagrahttps://github.com/tomaszsagra can you please explain what you mean by "tabeli", is it table? if yes, may I ask you please to change it in the swagger file

In certified-connectors/Emigo/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#discussion_r1014287939:

"TableCapabilitiesMetadata": {

 "description": "Metadane tabeli (mo\u017cliwo\u015bci)",

 "type": "object",

 "properties": {

   "sortRestrictions": {

     "$ref": "#/definitions/TableSortRestrictionsMetadata"

   },

   "filterRestrictions": {

     "$ref": "#/definitions/TableFilterRestrictionsMetadata"

   },

   "isOnlyServerPagable": {

     "description": "Ograniczenia stronicowania serwera",

     "type": "boolean"

   },

   "filterFunctionSupport": {

     "description": "Lista obs\u0142ugiwanych mo\u017cliwo\u015bci filtru",

@tomaszsagrahttps://github.com/tomaszsagra all files should be written in English language. please fix all descriptions in the swagger file.

In certified-connectors/Emigo/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#discussion_r1014289781:

@@ -0,0 +1,1141 @@

+{

"swagger": "2.0",

"info": {

"version": "v1",

@tomaszsagrahttps://github.com/tomaszsagra plesae change the version to "1.0"

In certified-connectors/Emigo/apiProperties.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#discussion_r1014296241:

@@ -0,0 +1,51 @@

+{

"properties": {

"connectionParameters": {

 "token": {

   "type": "oauthSetting",

   "oAuthSettings": {

     "identityProvider": "aad",

     "clientId": "ea03594e-dfc3-44c3-aa5f-28233df95b7f",

@tomaszsagrahttps://github.com/tomaszsagra plesae remove your clientID and replace it with dummy data "<>".
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#pullrequestreview-1168925431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFEWERA6X5A7YGMO5QTWGVPNLANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

Hi @tomaszsagra no you don't need to generate script.csx if your connector doesn't require that.

Hello @tomaszsagra,
I hope you are doing well.
I am following up with you to see how things are going with preparing your connector.
Please let us know if you have any questions.
Thank you.

Hi Amjed,
Could you provide me information what I should do now? I want to publish my Emigo Connector.
I can see there are some issues. The status is "Some checks were not successful".
https://github.com/microsoft/PowerPlatformConnectors/pull/2118
API Properties Validator Failed: As I remember you said I can ignore these errors.
Swagger and Change Validation Failed: I previously had this value set to 2.0 but you said to change it to 1.0, is that true?
Best Regards
Tomasz Margacz
senior software developer
+48 606 250 070
<EMAIL_ADDRESS>30 years of activity
www.sagratechnology.comhttp://www.sagratechnology.com/
@.***
This e-mail is property of Sagra Technology and may contain business secrets, confidential and/or privileged information. If you are not the intended recipient (or have received this e- mail by mistake) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.
From: Amjed Ayoub @.>
Sent: 11 November 2022 18:00
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
Hello @tomaszsagrahttps://github.com/tomaszsagra,
I hope you are doing well.
I am following up with you to see how things are going with preparing your connector.
Please let us know if you have any questions.
Thank you.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1311948046, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFG3WF3TN7EQPN2GAB3WHZ3Q7ANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

@tomaszsagra May I ask you please to resolve the conversation when you fix? Thank you so much

Hi Amjed,
I appreciate for your help. Thank you so much!
I changed and uploaded all files. Should I do anything else?
From: Amjed Ayoub @.>
Sent: 29 November 2022 21:11
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
@tomaszsagrahttps://github.com/tomaszsagra May I ask you please to resolve the conversation when you fix? Thank you so much
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1331238773, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFALQRJAQIGXS7RR3NLWKZPO7ANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

Hello @tomaszsagra,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.

Hi Amjed,
I have an issue with my Emigo Connector. The Connector is in Preview region and is available for testing. I am testing it right now. The Connector is working properly for Flow Actions but not working for Power Apps. Four actions (GetProductList, GetProductItem, GetOperationalUnitList, GetOperationalUnitItem) does not return values. I checked apiDefinition.swagger.json everything looks good.
I created a Power App (emigo test) with two Data tables, one for GetOperationalUnitList and second for GetProductList. Rows number into these tables are correct but without values.
Environment: https://make.powerapps.com/environments/b44365d7-adb3-e420-bfd4-20e9d1e91e10/apps
Could you provide me what is wrong there or can we meet via Teams?
Best Regards
Tomasz Margacz
Sagra Technology
+48 606 250 070
From: Amjed Ayoub @.>
Sent: 30 November 2022 19:41
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
Hello @tomaszsagrahttps://github.com/tomaszsagra,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studiohttps://docs.microsoft.com/en-us/connectors/custom-connectors/submit-for-certification#submit-to-isv-studio or update your submissionhttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-updates using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirementshttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-submission#design-an-icon-for-your-connector, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this pagehttps://docs.microsoft.com/en-us/connectors/custom-connectors/submit-for-certification#submit-to-isv-studio at step 6.
Please Create an environment in the Preview regionhttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-testing#create-an-environment-in-the-preview-region. You will use this environment later to test your connectorhttps://docs.microsoft.com/en-us/connectors/custom-connectors/certification-testing#test-your-connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1332582426, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFDHA6DC54QM2Y7OCI3WK6NSNANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

Hello @tomaszsagra,
Thank you so much for reaching out. I started an email thread regarding this.
May I ask you please to share some screenshots? I want to make sure that you are using the correct environment in Power Apps. The environment should be created in the US Preview region.
I look forward to hearing from you.
Thank you so much again.
Best regards,
Amjed Ayoub.

Hi Amjed,
Thank you for your response 😊
I was testing the Emigo Connector in the right Environment (US Preview region). I also created Custom Connector in my Europe Environment.
I already found the issue and solved it. The problem was with NULL data/values. Now on the screen below you can see data/values correctly but previously all data/values were empty (only number of rows was correct).
The problem was with properties with NULL values. For instance, I tried to display List of products. The result of the method was:
Just an example:
{
“ID”: 1,
“name”: “name of product”,
Price: null
}
I changed the result to:
{
“ID”: 1,
“name”: “name of product”,
Price: 0
}
If my method returns any property with NULL value, then Power App do not display any data into Data Table. PS. FLows work good with NULL values.
@.***
I accepted the Emigo Connector and I waiting to deploy it to all regions. Thank you so much for help.
The publish path will be the same when I want to add new actions and triggers?
Best Regards
Tomasz Margacz
Sagra Technology
From: Amjed Ayoub @.>
Sent: 13 January 2023 23:38
To: microsoft/PowerPlatformConnectors @.>
Cc: Tomasz Margacz @.>; Mention @.>
Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
Hello @tomaszsagrahttps://github.com/tomaszsagra,
Thank you so much for reaching out. I started an email thread regarding this.
May I ask you please to share some screenshots? I want to make sure that you are using the correct environment in Power Apps. The environment should be created in the US Preview region.
I look forward to hearing from you.
Thank you so much again.
Best regards,
Amjed Ayoub.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1382491471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFFJ5RBFA55HK3BAFEDWSHKLPANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED

Hi Amjed,
For my company replacing null to 0 is not always good for the business reasons. Is there any chance to return fields with null values? Now fields with null do not working into Power Apps with Data Table. I mentioned it in the previous email.
Best Regards
Tomasz Margacz
Sagra Technology
From: Tomasz Margacz
Sent: 14 January 2023 13:00
To: microsoft/PowerPlatformConnectors @.>; microsoft/PowerPlatformConnectors @.>
Cc: Mention @.***>
Subject: RE: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
Hi Amjed,
Thank you for your response 😊
I was testing the Emigo Connector in the right Environment (US Preview region). I also created Custom Connector in my Europe Environment.
I already found the issue and solved it. The problem was with NULL data/values. Now on the screen below you can see data/values correctly but previously all data/values were empty (only number of rows was correct).
The problem was with properties with NULL values. For instance, I tried to display List of products. The result of the method was:
Just an example:
{
“ID”: 1,
“name”: “name of product”,
Price: null
}
I changed the result to:
{
“ID”: 1,
“name”: “name of product”,
Price: 0
}
If my method returns any property with NULL value, then Power App do not display any data into Data Table. PS. FLows work good with NULL values.
@.***
I accepted the Emigo Connector and I waiting to deploy it to all regions. Thank you so much for help.
The publish path will be the same when I want to add new actions and triggers?
Best Regards
Tomasz Margacz
Sagra Technology
From: Amjed Ayoub<EMAIL_ADDRESS>Sent: 13 January 2023 23:38
To: microsoft/PowerPlatformConnectors<EMAIL_ADDRESS>Cc: Tomasz Margacz<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerPlatformConnectors] Add Emigo Connector (PR #2118)
Hello @tomaszsagrahttps://github.com/tomaszsagra,
Thank you so much for reaching out. I started an email thread regarding this.
May I ask you please to share some screenshots? I want to make sure that you are using the correct environment in Power Apps. The environment should be created in the US Preview region.
I look forward to hearing from you.
Thank you so much again.
Best regards,
Amjed Ayoub.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/2118#issuecomment-1382491471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGFTNFFJ5RBFA55HK3BAFEDWSHKLPANCNFSM6AAAAAARVCEDWQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>RESTRICTED


Losing storage after each compilation even after using flutter clean

Hello everyone, I'm new to flutter and I'm facing an issue, a storage problem to be exact.
Each time I compile a flutter project I'm losing approximately 1.3 GB from my hard drive permanently .
I've searched the WEB and found the command flutter clean. And what this command does to me, it just removes the build and dart_tool folders and that gives me back approximately 350 MB from the taken 2 GB.
I'm still learning flutter so I'm working for the moment just with the base project of flutter (I mean by the base project here, when we create a new project by using flutter create project_name and compile it directly).
So let's put down the numbers:

Lets say that I have approximately 20 GB free hard drive storage.
If I hit compile or flutter run I've just lost approximately 2 GB.
I stop the execution of flutter run.
I use the command flutter clean, and it gives me back just ~ 350 MB back.
I've just lost ~ 1.5 GB of storage.
Each time I hit compile or flutter run to the base project or any flutter project the same process happens again.

The only workaround I've found to escape the repeated compile process is to use the hot reload option, which I have no problem with it.
I'm using VS Code on Windows 10.
Target Platform: Windows 10
Target OS version/browser: API 28 / Android 9
Devices: Pixel 2 Emulator
Logs

Logs
flutter analyze
C:\Users\Ayoub\Documents\flutter_projects\flutter_basics>flutter analyze
Running "flutter pub get" in flutter_basics...                      5.9s
Analyzing flutter_basics...
No issues found! (ran in 93.7s)

flutter doctor -v
C:\Users\Ayoub\Documents\flutter_projects\flutter_basics>flutter doctor -v
[√] Flutter (Channel stable, 1.22.5, on Microsoft Windows [Version 10.0.19041.685], locale en-US)
    • Flutter version 1.22.5 at C:\Users\Ayoub\Flutter
    • Framework revision<PHONE_NUMBER> (2 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Ayoub\AppData\Local\Android\Sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Ayoub\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[!] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2019.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2019.3.1
    • Flutter plugin version 45.1.2
    • Dart plugin version 193.7547

[√] VS Code (version 1.52.1)
    • VS Code at C:\Users\Ayoub\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.17.0

[√] Connected device (1 available)
    • AOSP on IA Emulator (mobile) • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 1 category.

Hi @hadran9
I cannot reproduce the issue on Macbook Pro. What happens here is that after I stop the debugging process the memory gets back to where it was before. Tested with emulator (Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)).
Can you please share how are you evaluating the memory usage?

[✓] Flutter (Channel master, 1.26.0-2.0.pre.137, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.26.0-2.0.pre.137 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision 8f5d0371af (2 days ago), 2020-12-26 11:07:36 +0330
    • Engine revision f5364860ab
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.1.5
    • Dart plugin version 203.5981.152

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • Redmi 5 Plus (mobile)              • 0258ff700005  • android-arm64  • Android 8.1.0 (API 27)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • macOS (desktop)                    • macos         • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 87.0.4280.88

! Doctor found issues in 1 category.
Process finished with exit code 0

Hi @pedromassango, so sorry for the late response.

Can you please share how are you evaluating the memory usage?

Well I've used  spacesniffer.
Once that've been said, when I used space sniffer I've noticed that the consumed space was gone into the AVD each time.
So I don't think that the issue should be open here anymore because I think that's an issue of android studio. Regardless, I've found that I can use flutter hot reload to avoid recompiling each time, and after a few hot reloads I need to delete the AVD and create a new one again. I know it's not an efficient solution but it's the only way how I can get back some of my lost storage.
I'm closing this issue, and if you need any more details please feel free to reopen it back and ask me about anything, I'm happy to help.

Hi @pedromassango, so sorry for the late response.

Can you please share how are you evaluating the memory usage?

Well I've used  spacesniffer.
Once that've been said, when I used space sniffer I've noticed that the consumed space was gone into the AVD each time.
So I don't think that the issue should be open here anymore because I think that's an issue of android studio. Regardless, I've found that I can use flutter hot reload to avoid recompiling each time, and after a few hot reloads I need to delete the AVD and create a new one again. I know it's not an efficient solution but it's the only way how I can get back some of my lost storage.
I'm closing this issue, and if you need any more details please feel free to reopen it back and ask me about anything, I'm happy to help.


chore(pkger): add tests to pkg new cli command

Add some small integration tests to validation cobra commands are all working as expected.  Inspiration taken from the kubectl here

[x] Well-formatted commit messages
[x] Rebased/mergeable
[ ] Tests pass

@kelwang pushed up changes we spoke of on the slack call 👍


Change how strong the blur effect is?

The code gives a way of change the tint color and the opacity of it but, there is any way of change how strong is the blur effect?.
Thanks you anyway.

The underlying API does not allow for this kinda thing afaik.


Unable to generate widths dynamically

Problem

This is more of a question. I am wondering why the widths field in the Table struct is a reference ? This force me to either create the constraint statically at compile time or to define them in an upper lifetime scope. Simply said, I can't create a Table in a fonction if I compute the constraint dynamically. Maybe I am not using the widthscorrectly ?
I am really new to this lib, so any comments are welcome. Thanks

I'm having the same issue. I've written a my own Table that dynamically assigns column lengths based on the data, but I'm having a hard time specifically around passing around a dynamically generated &[Constraint]. A rough example of what I tried to do looks like this:
struct MyTable {
  title: Option<String>,
  data: ...,
}

impl MyTable {
  pub fn widget(&self) -> tui::widgets::Table {
    let constraints = ...;

    tui::widgets::Table::new(...).widths(&constraints)
  }
}

I ended up solving this by having my struct implement Widget and StatefulWidget. Ownership of the constraints doesn't matter as much because rendering destroys the table. Maybe this will help you @hommeabeil

I will looks into it thanks.

Hello! Faced with the same issue. I need to calculate table's widths for changing width of a terminal. I Did not understand advice about StatefulWidget. Can somebody help please?

Here's a simplified version of what I did. I have a custom MyTable structure:
pub struct MyTable {...}

with all of the data required to compute the table widths. Then you can implement Widget for your table:
impl<'a> Widget for Table<'a> {
  fn render(self, area: Rect, buf: &mut Buffer) {
    let constraints = self.constraints();

    Widget::render(self.widget(&constraints), area, buf);
  }
}

I had to make a MyTable::constraints function that would return the computed constraints as a Vec<Constraint>, and then MyTable::widget takes in the constraints and returns a tui::widgets::Table that can be rendered.
If you implement the Widget trait for your table then you can render it like this
frame.render_widget(MyTable::new(...), table_rect);

Hopefully this helps!


Expose linkWithPopup and linkWithRedirect

Feature suggestion:
https://firebase.google.com/docs/reference/js/firebase.User#linkWithPopup
Linking with multiple providers is supported by the firebase library, but is tedious with angularfire2, since I cannot pass a AuthProviders enum into linkWithPopup() and have to convert between the AuthProviders enum and firebase.auth.AuthProvider.
Exposing linkWithPopup in some easier way or creating a function to convert between AuthProviders and firebase.auth.AuthProvider would solve this issue.

@Maistho Right now you're best off using the regular SDK. I'm planning some changes to auth that should simplify things.

Cool, nice to know that changes are on the road map. =)

@jeffbcross did your fix here possibly address this?


Docker file arm setting

in the following line what does -d16 refer to, or enable:
ENV CFLAGS_armv7_unknown_linux_musleabihf='-mfpu=vfpv3-d16'

As far as I understand this is device specific, that is -mfpu=vfpv3 will apply to more (Broadcom?) armv7 devices that have a vfpv3

See https://wiki.debian.org/ArmHardFloatPort/VfpComparison#FPU

rustc uses vfp3-d32, perhaps we should use that as well.
$ rustc +nightly --print target-spec-json -Zunstable-options --target armv7-unknown-linux-musleabihf
{
  "abi": "eabihf",
  "arch": "arm",
  "crt-objects-fallback": "musl",
  "crt-static-default": true,
  "crt-static-respected": true,
  "data-layout": "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64",
  "dynamic-linking": true,
  "env": "musl",
  "features": "+v7,+vfp3,-d32,+thumb2,-neon",
  "has-rpath": true,
  "has-thread-local": true,
  "is-builtin": true,
  "llvm-target": "armv7-unknown-linux-gnueabihf",
  "max-atomic-width": 64,
  "os": "linux",
  "position-independent-executables": true,
  "post-link-objects-fallback": {
    "dynamic-dylib": [
      "crtendS.o",
      "crtn.o"
    ],
    "dynamic-nopic-exe": [
      "crtend.o",
      "crtn.o"
    ],
    "dynamic-pic-exe": [
      "crtendS.o",
      "crtn.o"
    ],
    "static-dylib": [
      "crtendS.o",
      "crtn.o"
    ],
    "static-nopic-exe": [
      "crtend.o",
      "crtn.o"
    ],
    "static-pic-exe": [
      "crtendS.o",
      "crtn.o"
    ]
  },
  "pre-link-objects-fallback": {
    "dynamic-dylib": [
      "crti.o",
      "crtbeginS.o"
    ],
    "dynamic-nopic-exe": [
      "crt1.o",
      "crti.o",
      "crtbegin.o"
    ],
    "dynamic-pic-exe": [
      "Scrt1.o",
      "crti.o",
      "crtbeginS.o"
    ],
    "static-dylib": [
      "crti.o",
      "crtbeginS.o"
    ],
    "static-nopic-exe": [
      "crt1.o",
      "crti.o",
      "crtbegin.o"
    ],
    "static-pic-exe": [
      "rcrt1.o",
      "crti.o",
      "crtbeginS.o"
    ]
  },
  "relro-level": "full",
  "supported-split-debuginfo": [
    "packed",
    "unpacked",
    "off"
  ],
  "target-family": [
    "unix"
  ],
  "target-mcount": "\u0001mcount",
  "target-pointer-width": "32"
}

Ok, but you should test it on a RPi too, as I have never seen it there or used it there (I did some research when the RPi3 came out while trying to compile RetroArch, before they released a RPi3 version - ie I dont think it will work on the older RPi2 boards)

it might be that even vfp is enough, it depends on how the compile handles it. That link implied that D32 was the default, but I think it might be more the case of "the chip defaults to whatever the hardware has"

are you able to test it on device(s) that are different?

No, I only have a RPi4.
I think it might be better to align with whatever rustc defaults to? A mismatch between gcc and rustc may also cause trouble. And user can always override that env var when building.

No, I only have a RPi4.

actually should be able to test the -d16 option on that. I should "do something different" if its not valid?

actually you should be able to test the -d16 option on that.

Do you have a list of steps to do the test? I'm not total sure how.

I should "do something different" if its not valid?

Sorry, what do you mean?

And user can always override that env var when building.

To clarify, docker run --rm -it -v "$(pwd)":/home/rust/src --env CFLAGS_armv7_unknown_linux_musleabihf='-mfpu=vfpv3-d32' messense/rust-musl-cross:armv7-musleabihf should do.

NOTE: If no one is complaining or a having problems then it is probably OK. I just braught it up because I have never seen or used it, and I have a few RPi's


On creation of Edit Request if Product has email(-s) lacking IDIR or UPN show the error message and restrict Submit

Currently if we make an Edit Request for the Product which has email lacking IDIR or UPN the Submit button is clickable but doesn't give any result leaving user on the same page.
We need to add the error which will inform user about Submit restriction and its reason.

Now in case if one of the contacts doesn't have IDIR or UPN the error is shown immediately after opening the Product page:
Private Zenhub Image


"Overflow in AddressInfo" when using variable length non-blittable types

From what I see current implementation only support variable length key/values if and only if both key and value are blittable types. For my scenario I'd like to have string/byte[] as keys and byte[] (or even a custom object I could (de)serialize during Read/Write) values.
I could follow the variable length example to implement a struct which would contain string/byte[] data. One issue with that approach is that I'd need to do additional copy from string/byte[] to allocated memory block (and back but this is expected), for it to be simply copied by FASTER to its own buffers (though as I understand this still happens when using custom serializer for cases when key/value has objects). Another issue - pointer/managed ref lifetime, when can I release (or unpin) the memory, is it safe to do just after Upsert/Delete/Read? When implementing IFunctions - do I need to pin src/dst?

For now I opted to go with wrapping variable length structs with custom serializers (https://github.com/marius-klimantavicius/mister).

There are two ways to support variable length values, as you have noticed. One is to just treat the key and values as class objects and use FASTER's support of objects via a custom serializer. This is the safe technique, but may incur overhead when reading objects that need to be fetched from storage. This is because the objects are stored in a separate object log, with the main log storing pointers to the object log. Thus, a read would first go to the main log, determine the offset in object log, and issue another IO to fetch the object.
The other technique is to store variable length objects in place in the main hybrid log. This is illustrated in the example here.
You are right that you would need to copy the bytes over from/to this struct during the operation, and FASTER would then copy it to its own log later. The pointer lifetime is not as hard as you might think though. You just need to keep it pinned (or use stackalloc) until Upsert/Read returns. When it returns, you can safely unpin. This is because if the operation goes pending, then FASTER will deep-copy the data to its internal pending context here before returning to the caller.
The "variable length struct" feature is rather low-level -- it is possible to build a layer on top that can directly support byte-arrays or MemorySpan for users. This is an open enhancement.
If you have ideas on better support for such types, feel free to suggest.

For my project I ended up going with variable length struct. When I started working on my project I tried using the object log, but it was failing for me. I was witnessing "Overflow in AddressInfo" when trying to insert ~4M entries to FKV where key was i.ToString() and value was byte array of length 7. I was also experiencing memory corruptions randomly when working with smaller number of entries (mostly during recovery in form of FatalEngineException caused by access violation).
Initially I thought that the issue was that object log did not support variable length non-blittable types, but now looking into code it seems to be something else.

Do you have a repro for the 'overflow in addressinfo' issue? This sounds like a bug that needs to be fixed.
You need to do compete pending, but not immediately. You can do it after some number of operations. That said, upserts almost never go pending (only in special case when taking checkpoint and also using RMW) so it doesn't matter in your case.

Created a gist (https://gist.github.com/marius-klimantavicius/370a42e3ae698dc17959994908ff33c3) for this case - need to take checkpoint to reproduce the issue.

I ran this sample in net46 Debug and net46 Release, both attached and detached to debugger, several times, on Windows. No error. Can you clarify your environment/OS and what platform/config you are hitting the error on? I used the latest in master. Thanks!

Ah, I see the error occurs in 32 bit mode. This is expected, as the addressable space is much lower in 32 bit as compared to 64 bit. We only have 32 bits to store AddressInfo, so we do not have much budget in terms of bits to store large offsets within a page there.
I recommend you run your program in 64 bit mode (right click project, choose platform target as x64). We will update the error message to make this situation clearer. Thanks, and let me know if you still hit the issue. :)

I can confirm that I cannot reproduce the issue with 64-bit target.
This is not an issue for me as I switched to using variable length structs strategy to work this one around.
If there are no plans to support large number of non-blittable key/value in 32-bit environment, then this issue can be closed. It is really easy to fall into this trap as VS generates "Prefer 32 bit" by default for new projects.

This isn't easy to fix with the current design of FASTER, where the pointer is used to store object log offset and object size. We have updated the error message to suggest moving to x64.


weird formatting (on Safari)

on safari

[ ] "See Our Data Sources" link
[ ] "Expand Data"


deep update on one to many composition

Hello Team,
I have an entity like below
entity Students {

key id: string(10);

name: string(30);

title: localized string(40);

}

I want to do deep update on Students entity.
I do put request.
My URL is 'http://localhost:4004/v2/StudentService/Students(1)'
and Payload is :
{ id : '1',

name: 'test',

texts:[{locale: 'en',title: 'Guntur'}]

}

It shows error like below

I am using Node js with PostgreSQL Database. It's working SQLite Database.
Please help me

Hi @lellavasundhara ,
right now we've not used localized in our datamodel. It would be great if you can enhance the cds-pg project and add an Entity Styles to tests/assets/cap-proj/db/schema.cds. That would make a good example for a localized entity. Then also add a test that replicates the issue.
Best regards
Gregor

Hello @gregorwolf
I ran into similar issue when try to update one to many composition.
Here is the model with one to many composition:
entity Req {
key Id        : UUID;
title     : String(100);
amount    : Amount;
status    : Status;
comments  : String(1000);
reqLines  : Composition of many ReqLines
on reqLines.req = $self
}
entity ReqLines {
key Id        : UUID;
req       : Association to Req;
item      : String(100);
quantity  : Integer;
price     : Price;
}
when I try to send the payload using PUT method  in postman like this:

Error messages:

The same use case works fine for sqlite.
Best Regards and Thanks.

hi @tiger0328 - the same thing indeed applies to your example: you're using a pseudo-localized version of currency; that -as @gregorwolf pointed out- we do not yet have available in cds-pg.
And, as also @gregorwolf has pointed out above, "it would be great if you can enhance the cds-pg project and add an Entity Styles to tests/assets/cap-proj/db/schema.cds. That would make a good example for a localized entity. Then also add a test that replicates the issue."

Hello Team,
I have entities like below (with many to many relations)
entity WorkSpace : managed {
key ID               : String;
Editable         : Boolean;
WorkPages        : Composition of many { // many-to-many relationship
key Instance : Association to WorkPage;
}
Sites            : Association to many Site.WorkSpaces
on Sites.Instance = $self; // many-to-many backlink
Roles            : Association to many Role.WorkSpaces
on Roles.Instance = $self; // many-to-many backlink
}
entity Role {
key ID           : String;
WorkSpaces   : Composition of many { // many-to-many relationship
key Instance : Association to WorkSpace;
}
}
When I tried to patch Specific Role with WorkSpaces
PATCH {{path}}/Roles('R_1')
We get the same error @lellavasundhara got.
version of cds-pg - 0.1.14
version of cds - 5.1.5
version of cds-dbm - 0.0.27


GPL-861 consolidated plates

Closes #261
Changes proposed in this pull request:

...

Also related with changes in https://github.com/sanger/lighthouse/pull/274

Might be worth trying lefthook or runing ./forlint.sh - it's a little script which runs black, flake8 and mypy. This should catch the bulk of the formatting/linting issues.

Todo
update from develop
deploy from branch
merge into develop
deploy from develop


[Enhancement][Consumer] Parallel Execution of Interceptors in beforeConsume Method

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently, the beforeConsume method in ConsumerInterceptors.java executes each interceptor sequentially. Since the interceptors operate independently without dependencies on one another, introducing parallel execution can potentially improve performance.

Solution
No response
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Good suggestion. However I have another word, sometimes you need multiple interceptors are executed in extremely order.
Maybe you can add a new boolean parameter requireOrder flag to determine whether to execute interceptors in order or parallel.

@visxu @ZhaoGuorui666
I would like to work on this issue if no one already is.

@visxu @ZhaoGuorui666
I would like to work on this issue if no one already is.
Thanks!

Hi, @TheMarvelFan. Thanks for your attention on the issue, while I'm working on it. If you wanna start to contribute to Pulsar, Flaky-Test is a good beginning.
https://github.com/apache/pulsar/issues?q=is%3Aopen+flaky+sort%3Aupdated-desc


fix: wrap return value of useOnEvent in useMemo

Description
Since useOnEvent returns an object which gets recreated on every render, this makes the value returned unstable and cause bug by retriggering useEffects when the value did not really change.
Assume the following:
import {useEffect, useState} from 'react';
import {useIsHeadphonesConnected} from 'react-native-device-info';
function App() {
  const isHeadphonesConnected = useIsHeadphonesConnected();
  const [_, setCounter] = useState(0);

  useEffect(() => {
    const intervalId = setInterval(() => {
      setCounter(prev => prev + 1);
    }, 1000);

    return () => {
      clearInterval(intervalId);
    };
  }, []);

  useEffect(() => {
    // some intensive work
    console.log('isHeadphonesConnected', isHeadphonesConnected);
  }, [isHeadphonesConnected]);
  return null;
}

export default App;

Since useIsHeadphonesConnected uses useOnEvent this will make the useffect with the isHeadphonesConnected to retrigger every time a rerender happens which cause unexpected behavior
Compatibility

OS
Implemented

iOS
✅

Android
✅

Windows
✅

Checklist

[x] I have tested this on a device/simulator for each compatible OS
[ ] I added the documentation in README.md
[ ] I updated the typings files (privateTypes.ts, types.ts)
[ ] I added a sample use of the API (example/App.js)

hm... I'm not sure why the tests haven't reported back yet. Nonetheless, I'll let it in.

@mikehardy, good to know. I'll try that next time.


Project Future Plan?

It's been a year since the last commit. This repo need maintainers.

I thought about making a PR but decided against due to inactivity. Would be cool to get some feedback in order to see whether the effort is worth it.
In fact, I ended up implementing my own version that suits my needs and by now I feel confident enough to help you with project maintenance. What do you think @clemfromspace?

@0b11001111 Same! I've been making updates to a local fork of mine because this project seems dead. @clemfromspace any update would be helpful. If not, I believe we can start working on a fork of our own?

I've got the same concerns.
Thanks for taking the time to write this, by the way @clemfromspace! It's been super helpful! I think Selenium + Scrapy is a great combination.


[BUG] CREATING A SEQUENCE ( BY RENAMING AN ALREADY EXISTING ONE ) GIVES COMPILE ERROR.

🔵 Describe the bug:
Hey Tim, found minor bug here .
It doesn't get in the way at all, and allows you to use all the functionality of gse.
When you create a sequence ( as title says, by renaming an existing one ), gives compile error ( it gets saved, but gives compile error )
🔵 To reproduce: (Steps to reproduce the behavior)

Create or have a pair new sequences with these names for example ( fury_single & fury_aoe ) ---> important here having underscore bar in the name ---> _

Mark any of these 2 new sequences created, and rename it just fury

See error printed on chat ( compile error )

🔵 Screenshots:

🔵 Expected behavior:
There may be a problem when renaming specifically with underscores and spaces ?!
🔵 GSE.lua file:
GSE.lua.txt
🔵 Desktop (please complete the following information):

OS: Windows 11 Pro 23H2 22631.3958

Game Version <IP_ADDRESS>960

🔵 GSE Version:

Version: 3.2.07

Downloaded From: https://discord.com/channels/486059368983429131/1019032009911308359

You can’t call something just “fury” it’s too generic and thee are other things already called fury

The bug here is you called it fury - what if came from
Or the _ is irrelevant.  The solution to this is not to try to call this by common wow names like PVP or Arms or Frost etc

Oh boi, i have been soo wrong these past years?!
So nothing remotely similar in name to whats lets say active or in use.
 Have a wonderful day.

It’s a super easy mistake to make and everyone has made it.

If you called it DJ_Fury of DJ_Fury_ST you would have zero issue it’s only the super common names that other mods or terms blizzard would use.


HELP Nginx configuration

Hi!
I'm not sure to understand the following sentence from your installation docs:
'Add the following lines to your server's configuration block...'
Am I supposed to add the specified code (big paragraph) into a file located in "default" (small paragraph)?
Or am I supposed to add the small paragraph (/etc/nginx/sites-available/default) in a certain file? If so, which file?
Thank you in advance!

You edit the file /etc/nginx/sites-available/default
In it you'll find a server {} block, and you should modify the 'big paragraph' code to be inserted there.
You'll find answers to this question on the forum.
Can you close the issue, as we like to use Github issues for bug reports only.


pull request for e2e test at 11/07/2016 08:56:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Override DirectorySeparatorChar / AltDirectorySeparatorChar

Sometimes I need to test a code that uses Path.DirectorySeparatorChar from MockFileSystem. But today it's can't be mocked, because Path is not overridable.
Describe the solution you'd like
virtual getter or something like this:
public class MockPath // ...
{
  public char DirectorySeparatorChar {get; set;}  = Path.DirectorySeparatorChar;
}

Thanks, for the issue. I don't fully understand what you're asking for as the property MockPath.DirectorySeparatorChar is already virtual:
https://github.com/System-IO-Abstractions/System.IO.Abstractions/blob/352f6002196b7f3428df7192eaae6520fbcff6f7/src/System.IO.Abstractions/PathWrapper.cs#L15-L18

        [Fact]
        public void Test()
        {
            MockFileSystem fs = new MockFileSystem(new Dictionary<string, MockFileData>{
                {"C:\\file.txt", MockFileData.NullObject}
            });
            // now for example I want to change PathSeparator, but Path only have getter and I have to use another approach for testing
            // (for example vitual method for accessing Path.DirectorySeparator) or reflection.
            var mockPath = (MockPath)fs.Path;
            // can't do this
            // mockPath.PathSeparator = '\\';
            var moqPath = new Mock<MockPath>(fs, MockUnixSupport.Path("C:\\temp"));
            moqPath.Setup(m => m.DirectorySeparatorChar).Returns('#');
            var fi = fs.GetType().GetField($"<Path>k__BackingField", BindingFlags.Instance | BindingFlags.NonPublic);
            fi.SetValue(fs, moqPath.Object);
            Assert.Equal('#', fs.Path.DirectorySeparatorChar);
            moqPath.Verify(m => m.DirectorySeparatorChar, Times.Once);
        }

This is what I'm talking about.

This can solved without reflection or any other hacks. You just to make sure that the Mock is working on the interfaces, not on the Mock* classes:
        [Test]
        public void Test()
        {
            var fsMock = new Mock<MockFileSystem>(new Dictionary<string, MockFileData>{
                {"C:\\file.txt", MockFileData.NullObject}
            }, "").As<IFileSystem>();
            var pathMock = new Mock<MockPath>(fsMock.Object);
            pathMock.Setup(x => x.DirectorySeparatorChar).Returns('#');
            fsMock.Setup(x => x.Path).Returns(pathMock.Object);
            var fs = fsMock.Object;

            Assert.AreEqual('#', fs.Path.DirectorySeparatorChar);
            pathMock.Verify(m => m.DirectorySeparatorChar, Times.Once);
        }

Hm, thanks.

@fgreinacher I've tested your code fragment and it throws here:
var pathMock = new Mock<MockPath>(fsMock.Object);

Object reference not set to an instance of an object.
at System.IO.Abstractions.TestingHelpers.MockFileSystem.FixPath(String path, Boolean checkCaps)
at System.IO.Abstractions.TestingHelpers.MockFileSystem.AddFile(String path, MockFileData mockFile)
at System.IO.Abstractions.TestingHelpers.MockFileSystem..ctor(IDictionary2 files, String currentDirectory)    at Castle.Proxies.MockFileSystemProxy..ctor(IInterceptor[] , IDictionary2 files, String currentDirectory)


Logging out on refresh

I've integrated redux-token-auth into an application I'm building. Login and logout functionality is working well. However, it seems like experiencing some sort of race condition with regards to the VERIFY_TOKEN_REQUEST_SENT action.
When I navigate to a page, the VERIFY_TOKEN_REQUEST_SENT action is triggered and the reduxTokenAuth state gets updated to isSignedIn: false, isLoading: true. By the time the page loads the redirectPathIfNotSignedIn method on my routes gets hit and it directs the user to redirectPathIfNotSignedIn: '/',. When I view the state on / after this occurs, I see the state has isSignedIn: true, isLoading(pin): false.
My app.js code is as follows:
const requireSignIn = generateRequireSignInWrapper({
  redirectPathIfNotSignedIn: '/',
})

const App = () => (

    <Router history={history}>

        <Route exact path="/" component={LoginForm} />
        <Route path="/dashboard" component={requireSignIn(Dashboard)} />
        <Route exact path="/posts/:postId" component={requireSignIn(PostDetail)} />

    </Router>

);

export default App;

My index.js code:
const reducer = combineReducers({
  posts: posts,
  reduxTokenAuth: reduxTokenAuthReducer,
});

// create the redux store
const store = createStore(
  reducer, composeWithDevTools(
    applyMiddleware(logger),
    applyMiddleware(thunk)
  )
);

// Checks if user has existing session in localStorage
verifyCredentials(store)

ReactDOM.render(
  <Provider store={store}>
    <App />
  </Provider>,
  document.getElementById('root'),
)

Any help on this issue would be greatly appreciated.

Same issue. And you are quite right. There is a race condition.
`async function demo() {
console.log('Taking a break...');
verifyCredentials(store);
await sleep(3000);
console.log(store.getState());
ReactDOM.render(

{indexRoutes.map((prop, key) => {
return ;
})}

,
document.getElementById("root")
);
console.log('Five second later');
}
demo();`
This works perfectly but is a horrible solution as server response times can vary.

There also appears to be an issue with devise-token-auth producing this behavior, for anyone using the two in tandem.


Format changelog for the forge

The changelog isn't being parsed properly by the Puppet forge. Links to the closed issues would be nice too.

Fixed in e96457e5ce7e092df93d3f611a569dd4dfe867e2


Remove nonexistent ws.port value from Erigon allowedTCPPorts

Currently the module for Erigon adds the value of the ws.port option to allowedTCPPorts, but this option does not exist either as an option in the module, nor on the Erigon command line.  Because the option does not exist, starting Erigon with openFirewall = true currently fails.  This PR removes the reference to ws.port in allowedTCPPorts.

Hi, @RichardWarfield thanks for your contributions! In order to keep the flow going I think we can cherry-pick your commits and prepare separate PRs so we get those commits in the main branch so everybody can benefit us.
@selfuryon can you help me with this?

Please feel free.  Apologies, I've been travelling lately and just haven't
been able to attend to this. I actually didn't realize that pushing to the
branch would also enlarge the PR (oops).  I've added modules for some
additional components (prysm validator, mev boost) but please check whether
these are implemented the way you would like.  For example, I've added an
option to set the user and datadir for the Prysm services so the validator
and beacon clients can be set to the same user and access the same data
dir.  There may be a cleaner way to do this while continuing to use the
systemd state dir as the datadir but I'm not such an expert on systemd
options.
On Fri, Apr 28, 2023 at 3:41 PM Aldo @.***> wrote:

Hi, @RichardWarfield https://github.com/RichardWarfield thanks for your
contributions! In order to keep the flow going I think we can cherry-pick
your commits and prepare separate PRs so we get those commits in the main
branch so everybody can benefit us.
@selfuryon https://github.com/selfuryon can you help me with this?
—
Reply to this email directly, view it on GitHub
https://github.com/nix-community/ethereum.nix/pull/230#issuecomment-1527198979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7JIMEBUBDLSGZTNMU2L73XDN7EVANCNFSM6AAAAAAXH4PR2A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Closing this PR in favor of #280 and #279 (let's move the discussion there, if necessary)


[LANG-1539] Add allNull() and anyNull() methods to ObjectUtils.

Coverage increased (+0.0006%) to 95.094% when pulling 83ebec5a786498adaab94dd986e53015f8e47641 on Isira-Seneviratne:Add_anyNull_and_allNull_to_ObjectUtils into 7f45b8898b804f0fe4fa55c088ff4a99a56af277 on apache:master.

On Wed, May 6, 2020, 1:44 PM Rajesh Kumar Karnena<EMAIL_ADDRESS>wrote:

@raj76kk commented on this pull request.
Method doc is incorrect
In src/main/java/org/apache/commons/lang3/ObjectUtils.java
https://github.com/apache/commons-lang/pull/522#discussion_r420615217:

* If all the values are {@code null} or the array is {@code null}

* or empty, then {@code true} is returned, otherwise {@code false} is returned.

Wrong method doc. Shouldn't it be?
If any of the values are {@code null} or the array is {@code null}, then
{@code true} is returned, otherwise {@code false} is returned
In src/main/java/org/apache/commons/lang3/ObjectUtils.java
https://github.com/apache/commons-lang/pull/522#discussion_r420615752:

* ObjectUtils.anyNull(*, null)          = false

* ObjectUtils.anyNull(null, *)          = false

* ObjectUtils.anyNull(null, null, *, *) = false

Incorrect examples
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/commons-lang/pull/522#pullrequestreview-406388821,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHMXFEW7JXTI2Q5V52UA6JTRQEL6FANCNFSM4MMCUNVQ
.

My bad, thanks!

Corrected the Javadoc. Please tell me if there's anything else :)

Looks Good :)

@Isira-Seneviratne
May you resolve here this one as well please?