Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Hi,
When I am trying to run ubuntu-bionic-docker with runtime=sysbox-run, docker service isn't starting inside my docker container automatically.
So here I am running it manually by logging inside container.
But is there any way that we can start docker service automatically when running the container?
sysbox status
sudo systemctl status sysbox -n20
● sysbox.service - Sysbox container runtime
     Loaded: loaded (/lib/systemd/system/sysbox.service; enabled; vendor preset: enabled)
     Active: active (running) since Sat 2024-03-02 08:44:02 UTC; 18s ago
       Docs: https://github.com/nestybox/sysbox
   Main PID: 4457 (sh)
      Tasks: 2 (limit: 4575)
     Memory: 428.0K
        CPU: 32ms
     CGroup: /system.slice/sysbox.service
             ├─4457 /bin/sh -c "/usr/bin/sysbox-runc --version && /usr/bin/sysbox-mgr --version && /usr/bin/sysbox-fs --version &>
             └─4475 /bin/sleep infinity

Command used to run my container
docker run --runtime=sysbox-runc -it nestybox/ubuntu-bionic-docker:latest

Docker status inside my container.
root@43a09fbb2ade:/# docker ps
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
root@43a09fbb2ade:/#
root@43a09fbb2ade:/#
root@43a09fbb2ade:/# service docker status
 * Docker is not running
root@43a09fbb2ade:/#
root@43a09fbb2ade:/# service docker start
mount: /sys/fs/cgroup/cpuset: permission denied.
mount: /sys/fs/cgroup/cpu: permission denied.
mount: /sys/fs/cgroup/cpuacct: permission denied.
mount: /sys/fs/cgroup/blkio: permission denied.
mount: /sys/fs/cgroup/memory: permission denied.
mount: /sys/fs/cgroup/devices: permission denied.
mount: /sys/fs/cgroup/freezer: permission denied.
mount: /sys/fs/cgroup/net_cls: permission denied.
mount: /sys/fs/cgroup/perf_event: permission denied.
mount: /sys/fs/cgroup/net_prio: permission denied.
mount: /sys/fs/cgroup/hugetlb: permission denied.
mount: /sys/fs/cgroup/pids: permission denied.
mount: /sys/fs/cgroup/rdma: permission denied.
mount: /sys/fs/cgroup/misc: permission denied.
 * Starting Docker: docker                                                                                [ OK ]
root@43a09fbb2ade:/#
root@43a09fbb2ade:/# service docker status
 * Docker is running
root@43a09fbb2ade:/#

Can someone please help me here?

Hi @anveshmuppeda, thanks for giving Sysbox a shot, hope you find it helpful.
The ubuntu-bionic-docker image includes Docker Engine in it, but does not start it automatically; if you wish to use this image, you have to start Docker Engine inside the container manually:
$ docker run --runtime=sysbox-runc -it --rm nestybox/ubuntu-bionic-docker

root@bf5a22b6bafe:/# docker ps
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

root@bf5a22b6bafe:/# dockerd > /var/log/dockerd.log 2>&1 &
[1] 83
root@bf5a22b6bafe:/# docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES

If you want Docker Engine to start automatically, the easiest way is to use the nestybox/ubuntu-bionic-systemd-docker image, which includes systemd as the process manager inside the container and it starts docker engine automatically.
$ docker run --runtime=sysbox-runc -it --rm nestybox/ubuntu-bionic-systemd-docker
...
7ce735b157d6 login: admin
password: admin
...
admin@7ce735b157d6:~$ docker ps

If systemd is too heavy, you can use a lighter weight process manager such as supervisord (see this example Dockerfile).
Note that the above Docker images are provided for reference only. The Dockerfiles are here and you can copy them and modify them to your needs.
Hope that helps!

(Closing issue, please re-open if neccesary).

@ctalledo
I appreciate your swift response; it made a significant difference for me.


Won't download

Checklist

[x ] I'm reporting a broken site support
[x ] I've verified that I'm running youtube-dl version 2019.06.27
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x ] I've searched the bugtracker for similar issues including closed ones

Verbose log

goose@t410:/tmp$ youtube-dl --verbose 'https://www.spiked-online.com/podcast-episode/the-boris-delusion/' 2>&1 | tee y.log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.spiked-online.com/podcast-episode/the-boris-delusion/']
[debug] Encodings: locale UTF-8, fs UTF-8, out None, pref UTF-8
[debug] youtube-dl version 2019.06.27
[debug] Python version 2.7.13 (CPython) - Linux-4.9.0-9-amd64-x86_64-with-debian-9.9
[debug] exe versions: avconv 3.2.14-1, avprobe 3.2.14-1, ffmpeg 3.2.14-1, ffprobe 3.2.14-1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] the-boris-delusion: Requesting header
WARNING: Falling back on generic information extractor.
[generic] the-boris-delusion: Downloading webpage
[generic] the-boris-delusion: Extracting information
[download] Downloading playlist: The Boris delusion
[generic] playlist The Boris delusion: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[soundcloud] 643402425: Downloading info JSON
ERROR: Unable to download JSON metadata: HTTP Error 500: Internal Server Error (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 627, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2227, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python2.7/urllib2.py", line 435, in open
response = meth(req, response)
File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
'http', request, response, code, msg, hdrs)
File "/usr/lib/python2.7/urllib2.py", line 473, in error
return self._call_chain(*args)
File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
Description

Won't download

Sorry - can you link to the fix please?

f7a147e, c560680


Fix commas in prices, add gitignore and requirements.txt

locale.atof was failing (on my Mac) on values like "40,500.00".
gitignore is just for my convenience; i put my virtualenv in the directory.
requirements.txt added so now you can just say "pip install -Ur requirements.txt"

Thanks man!

That locale stuff is a little tricky. It's supposed to be able to handle that comma correctly...

Thanks for letting me use your code!  I was thinking... we could easily make a 402 payment required wrapper around this<EMAIL_ADDRESS>:D


Shuriken

add shk configs
integrate hp and callbacks in main loop
add a Dockerfile for shk

Looks good to me


Fixed Spell Check error.

Hi,
thank you for contributing to our project. This issue was due to Quickblox SDK update and fix (as well as new Quickblox iOS SDK) is already available in our master branch. Check it out! :)


This LESS code generates error

Hey guys, i was just trying to see why this PHP library didn't compile my less file, and i've narrowed it down to this piece of code.
.transition(@duration, @property: all) {
	.transition-single(@properties, @i) when (@i <= length(@properties)) {
		-webkit-transition+: extract(@property, @i) @duration ease-in-out;
		-moz-transition+: extract(@property, @i) @duration ease-in-out;
		-o-transition+: extract(@property, @i) @duration ease-in-out;
		-ms-transition+: extract(@property, @i) @duration ease-in-out;
		transition+: extract(@property, @i) @duration ease-in-out;
		.transition-single(@property, @i + 1);
	}
	.transition-single(@property, 1);
}

This is a mixin to easily set up transitions using on simple call to this. It's recursive, and it compiles perfectly with JS in browser. But it doesn't compile with this PHP library, since it's throwing this:
Uncaught exception 'Less_Exception_Compiler' with message 'variable @property is undefined in file ....

I've tried reviewing the code quickly, and didn't know how can i possible figure this one out. I hope you can ;)

I've revisited this issue... and changing the code to this solves it
.transition-single(@properties, @i) when (@i <= length(@properties)) {
	-webkit-transition+: extract(@properties, @i) @duration ease-in-out;
	-moz-transition+: extract(@properties, @i) @duration ease-in-out;
	-o-transition+: extract(@properties, @i) @duration ease-in-out;
	-ms-transition+: extract(@properties, @i) @duration ease-in-out;
	transition+: extract(@properties, @i) @duration ease-in-out;
	.transition-single(@properties, @i + 1);
}
.transition(@duration, @properties: all) {
	.transition-single(@properties, 1);
}

Seems like the problem is with nested mixins.


XDG Support for ivi-shell: ivi-id-agent for weston v6

This is a reference implementation of an ivi-id-agent plugin. It
creates surface-ids for desktop-surfaces depending on the configuration
provided in "weston.ini". For more please refer to the reference
implementation in this commit.
The only public interface available is the "id_agent_module_init"
function. It is responsible for initialization of structs and reading
the configuration.
In the reference "weston.ini" two types of configurations can be found:
[desktop-app] is used to configure a particular application. Therefore
the desired surface-id must be provided. Moreover "app-title" is the
title that is provided by the desktop application (xdg-protocol).
"app-id" behaves accordingly. Although both parameters can be set, it
is not mandatory. Finally at least one has to be set.
[desktop-app-default] enables the id-agent to generate generic
surface-ids for unconfigured applications, e.g. for development. This
tag is optional. To generate the id an interval starting from
"default-surface-id" to "default-surface-id-max" is used. The id is
incremented until the interval is exceeded.
In the function "get_id" a surface-id is assigned by means of the
configuration. It can be adjusted, if another behavior is desired.
In this plugin the parameters, that are described above, are evaluated.
To use these patches please also apply the dedicated patches for
weston: https://github.com/mtey/weston/tree/xdg_support_ivi_id_agent
Since libweston-desktop is used to introduce desktop-surface support,
xdg-protocol is supported.
More Info:
https://wiki.automotivelinux.org/_media/agl-distro/agl_amm_xdg_support_a04.pdf

Dependent on Weston MR: https://gitlab.freedesktop.org/wayland/weston/merge_requests/86

If i want to run chromium browser on weston 10.0.1 with wayland-ivi-extension 2.3.1. Do i need to build weston with patches for xdg desktop?
What do we need to change in Weston.ini for running chromium browser?

@bhupiister not sure if chromium browser is able to run on weston at all!?
even it is chromium supports wayland it would need some wayland protocols to be supported by the compositor, the xdg protocol is typically not enough for desktop applications.
so typically a chromium installation will support some GUI framework like gnome, kde, mate which providing wayland support and also come with its own wayland compositor, they will support xdg protocol but also a set of additional protocols which  are not supported by weston.

@bhupiister not sure if chromium browser is able to run on weston at all!? even it is chromium supports wayland it would need some wayland protocols to be supported by the compositor, the xdg protocol is typically not enough for desktop applications. so typically a chromium installation will support some GUI framework like gnome, kde, mate which providing wayland support and also come with its own wayland compositor, they will support xdg protocol but also a set of additional protocols which are not supported by weston.

Well it does work well on normal Weston desktop shell on wayland. I am having issues on the ivi-shell and ivi-controller on wayland. It does run for the first time, but then it gives below error
$ WAYLAND_DISPLAY=wayland-0 chromium --use-gl=egl --ozone-platform=wayland --in-process-gpu www.google.com
[328:372:1106/032615.159552:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:372:1106/032615.161190:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:362:1106/032615.177154:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[328:362:1106/032615.177265:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[328:362:1106/032615.348613:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[328:362:1106/032615.356354:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[328:328:1106/032615.571872:ERROR:cursor_loader.cc(116)] Failed to load a platform cursor of type kNull
[328:429:1106/032615.831765:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:429:1106/032615.836475:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:429:1106/032615.842669:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:429:1106/032615.843888:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:429:1106/032615.846824:ERROR:bus.cc(398)] Failed to connect to the bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[328:328:1106/032615.881050:ERROR:system_web_app_manager.cc(314)] Exceeded SWA install retry attempts.  Skipping installation, will retry on next OS update or when locale changes.
[     1] ioctl(DRM_IOCTL_GEM_CLOSE) failed
)
[328:376:1106/032616.169577:ERROR:gbm_pixmap_wayland.cc(80)] Cannot create bo with format= RGBA_8888 and usage=SCANOUT
[328:376:1106/032616.170042:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(198)] Failed to create pixmap 1280x1024, RGBA_8888, usage SCANOUT
[     2] ioctl(DRM_IOCTL_GEM_CLOSE) failed
)
[328:376:1106/032616.170442:ERROR:gbm_pixmap_wayland.cc(80)] Cannot create bo with format= RGBA_8888 and usage=GPU_READ
[328:376:1106/032616.170484:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(198)] Failed to create pixmap 1280x1024, RGBA_8888, usage GPU_READ
[328:376:1106/032616.170513:ERROR:shared_image_backing_factory_gl_image.cc(359)] CreateSharedImage: Failed to create bindable image
[328:376:1106/032616.170537:ERROR:shared_image_factory.cc(608)] CreateSharedImage: could not create backing.
[328:396:1106/032616.170700:ERROR:skia_renderer.cc(624)] Failed to create the promise sk image or get paint ops.
[328:376:1106/032616.171451:ERROR:shared_context_state.cc(537)] Failed to make current since context is marked as lost
[328:376:1106/032616.171511:ERROR:skia_output_surface_impl_on_gpu.cc(1775)] Failed to make current.
[328:376:1106/032616.175500:ERROR:shared_context_state.cc(537)] Failed to make current since context is marked as lost
[328:376:1106/032616.175631:ERROR:skia_output_surface_impl_on_gpu.cc(1775)] Failed to make current.
[328:376:1106/032616.176556:ERROR:shared_context_state.cc(537)] Failed to make current since context is marked as lost
[328:376:1106/032616.176757:ERROR:skia_output_surface_impl_on_gpu.cc(1775)] Failed to make current.
[328:376:1106/032616.195952:ERROR:shared_image_stub.cc(519)] SharedImageStub: context already lost
[328:328:1106/032616.198994:ERROR:command_buffer_proxy_impl.cc(328)] GPU state invalid after WaitForGetOffsetInRange.
[328:376:1106/032616.201483:ERROR:shared_image_stub.cc(519)] SharedImageStub: context already lost
[     3] ioctl(DRM_IOCTL_GEM_CLOSE) failed
)
[328:376:1106/032616.320100:ERROR:gbm_pixmap_wayland.cc(80)] Cannot create bo with format= RGBA_8888 and usage=SCANOUT
[328:376:1106/032616.320244:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(198)] Failed to create pixmap 1280x1024, RGBA_8888, usage SCANOUT
[     4] ioctl(DRM_IOCTL_GEM_CLOSE) failed
)
[328:376:1106/032616.320771:ERROR:gbm_pixmap_wayland.cc(80)] Cannot create bo with format= RGBA_8888 and usage=GPU_READ
[328:376:1106/032616.320823:ERROR:gpu_memory_buffer_factory_native_pixmap.cc(198)] Failed to create pixmap 1280x1024, RGBA_8888, usage GPU_READ
[328:376:1106/032616.320888:ERROR:shared_image_backing_factory_gl_image.cc(359)] CreateSharedImage: Failed to create bindable image
[328:376:1106/032616.320918:ERROR:shared_image_factory.cc(608)] CreateSharedImage: could not create backing.
[1106/032616.380657:ERROR:file_io_posix.cc(144)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq: No such file or directory (2)
[1106/032616.380925:ERROR:file_io_posix.cc(144)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq: No such file or directory (2)
Trace/breakpoint trap (core dumped)

To launch it again successfully, i need to run WAYLAND_DISPLAY=wayland-0 layer-add-surfaces -l 1000 -s 2 again and then launch chromium to launch it successfully.


No TUN/TAP kernel module?

It seems like the TUN/TAP kernel module is missing from a lot of, or most of the Scaleway kernels. Has anyone else noticed this? So far I've found no module in these kernels for VC1S:
x86_64 4.10.8 std #1
x86_64 mainline 4.13.11 rev1

depmod -a, nothing. modprobe tun, nothing. lsmod, nothing. Grepping for the actual .ko returns nothing as well.
root@scw-6ee98f:~# ls /lib/modules/4.13.11-mainline-rev1/kernel/drivers/net | grep tun
root@scw-6ee98f:~# ls /lib/modules/4.10.8-std-1/kernel/drivers/net | grep tun

So I'm pretty sure it doesn't exist. But why? I hope this is added ASAP. If anyone knows of a kernel that has the tun module, please let me know. I'll be testing more in the meantime.

CONFIG_TUN is enabled in all mainline bootscripts, it's only loaded as a module on ARM though. zcat /proc/config.gz | grep "CONFIG_TUN" will confirm that.

@superseed When you say only loaded as a module on ARM. Does that mean I can't load it on x86_64? Because I can't seem to get it to work on x86_64.
If that's the case, can you add support for x86_64 and all the other architectures on Scaleway?

I mean it's enabled as a kernel built-in on all other arch (x86_64, arm64): you'll only find it through lsmod and in /lib/modules on arm. But it's always enabled in the mainline bootscripts.
You can always check /proc/config.gz as shown above.

@superseed
There is no tun/tap module in lsmod or in /lib/modules:
test:~$ lsmod | grep tun
test:~$ lsmod | grep tap
test:~$

test:/lib/modules/4.4.127-mainline-rev1$ find . -type f | grep tun
./kernel/drivers/media/tuners/tuner-simple.ko
./kernel/drivers/media/tuners/tda18271.ko
./kernel/drivers/media/tuners/tda18212.ko
./kernel/drivers/media/tuners/tuner-types.ko
./kernel/drivers/media/tuners/tuner-xc2028.ko
./kernel/drivers/media/tuners/mt2060.ko
./kernel/drivers/media/tuners/fc2580.ko
./kernel/drivers/media/tuners/tda827x.ko
./kernel/drivers/media/tuners/r820t.ko
./kernel/drivers/media/tuners/mt20xx.ko
./kernel/drivers/media/tuners/qt1010.ko
./kernel/drivers/media/tuners/mc44s803.ko
./kernel/drivers/media/tuners/fc0013.ko
./kernel/drivers/media/tuners/fc0012.ko
./kernel/drivers/media/tuners/max2165.ko
./kernel/drivers/media/tuners/tda18218.ko
./kernel/drivers/media/tuners/m88rs6000t.ko
./kernel/drivers/media/tuners/mt2266.ko
./kernel/drivers/media/tuners/xc5000.ko
./kernel/drivers/media/tuners/si2157.ko
./kernel/drivers/media/tuners/tea5767.ko
./kernel/drivers/media/tuners/xc4000.ko
./kernel/drivers/media/tuners/tea5761.ko
./kernel/drivers/media/tuners/msi001.ko
./kernel/drivers/media/tuners/e4000.ko
./kernel/drivers/media/tuners/qm1d1c0042.ko
./kernel/drivers/media/tuners/mxl5007t.ko
./kernel/drivers/media/tuners/tda9887.ko
./kernel/drivers/media/tuners/tda8290.ko
./kernel/drivers/media/tuners/it913x.ko
./kernel/drivers/media/tuners/fc0011.ko
./kernel/drivers/media/tuners/mxl301rf.ko
./kernel/drivers/media/tuners/tua9001.ko
./kernel/drivers/media/tuners/mxl5005s.ko
./kernel/drivers/media/tuners/mt2131.ko
./kernel/drivers/media/tuners/mt2063.ko
./kernel/drivers/media/v4l2-core/tuner.ko
./kernel/drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.ko
./kernel/net/ipv4/ip_tunnel.ko
./kernel/net/ipv4/udp_tunnel.ko
./kernel/net/ipv4/xfrm4_tunnel.ko
./kernel/net/ipv4/xfrm4_mode_tunnel.ko
./kernel/net/ipv4/tunnel4.ko
./kernel/net/mpls/mpls_iptunnel.ko
./kernel/net/ipv6/ip6_tunnel.ko
./kernel/net/ipv6/ip6_udp_tunnel.ko
./kernel/net/ipv6/tunnel6.ko
./kernel/net/ipv6/xfrm6_mode_tunnel.ko
./kernel/net/ipv6/xfrm6_tunnel.ko
test:/lib/modules/4.4.127-mainline-rev1$ find . -type f | grep tap
./kernel/drivers/net/wireless/hostap/hostap_plx.ko
./kernel/drivers/net/wireless/hostap/hostap.ko
./kernel/drivers/net/wireless/hostap/hostap_pci.ko
./kernel/drivers/net/macvtap.ko
./kernel/drivers/misc/altera-stapl/altera-stapl.ko
test:/lib/modules/4.4.127-mainline-rev1$

But yes, module is enabled in /proc/config.gz
test:/proc$ zcat config.gz | grep "CONFIG_TUN"
CONFIG_TUN=y
# CONFIG_TUN_VNET_CROSS_LE is not set
test:/proc$


Unknown bootloader CRC - 0x0939FCDA - please report this on GitHub issues

This is a Tongou TO-Q-SY1-JWT DIN rail power switch/meter: https://www.elektroda.com/rtvforum/topic3990985.html
It had already stopped working, so I got brave and opened it up. Appear to flash firmware just fine (ESPHome, then OpenBK7231N_QIO_1.17.654.bin
|-- Unknown bootloader CRC - 0x0939FCDA - please report this on GitHub issues!
|   |-- Success! Chip info: BK7231N
|-- Writing '/home/dwmw/Downloads/OpenBK7231N_QIO_1.17.654.bin'
|   |-- Start offset: 0x11000 (auto-detected)
|   |-- Write length: 1.1 MiB (auto-detected)
|   |-- Skipped data: 68 KiB (auto-detected)
  [################################################################]  100%          |-- The current command timeout of 1.0 second(s) is too low for reading 1150976 bytes CRC. Increasing to 3 second(s).

|   |-- Finished in 61.297 s

Still doesn't work afterwards. The LEDs come on but there's no apparent WiFi activity, nothing on the serial port if I configure ESPHome to use UART1. But it was like that before with the Tuya firmware (although it was only the status LED that came on, IIRC, while now both do).
Will order a new one to sacrifice and see if that one works.

Your device most likely needs different encryption keys. OpenBeken currently doesn't have means to change encryption keys, LibreTiny/ESPHome does.
But in order to find the encryption keys for your device, you will need to post a stock firmware dump here.

Thanks. What would the failure mode be in that case? It seemed to flash successfully but then just doesn't boot; is that what we'd expect?
New unit will be here tomorrow.

Yes, flashing a firmware with different keys will make it unable to boot.
Depending on whether you've flashed OpenBeken using their official tool (which overwrites the bootloader) you might be able to still retrieve the stock bootloader firmware dump. That could be enough to uncover the encryption keys.

I only flashed with ltchiptool, so should a 'flash read' give us the bootloader?

Yes. With no parameters it should give a full 2 MiB firmware dump, which will most likely include the stock bootloader and your firmware flashing attempts.

http://david.woodhou.se/frombk.bin
SHA256 f414981edc35e348524ae21a73295ac4522191f38d83f1bce5c0104cf4b391ca

This device uses default encryption keys - it's a Tuya device, they all use the same keys.
Flashing ESPHome should work with no issues, using the default config. Make sure you're checking the right UART port.
The bootloader might be corrupted - the binary differs from a known-good BK7231N bootloader by one byte. Try flashing just the bootloader from the OpenBeken's firmware image:
ltchiptool flash write -s 0x0 -l 0x11000 OpenBK7231N_QIO_1.17.654.bin

Then flash the firmware of choice without passing -s and -l.

I had originally flashed with esphome run....
Will try the above.

Aug 11 13:52:41 lantiq.infradead.org dnsmasq-dhcp[24570]: DHCPACK(tag.2) <IP_ADDRESS> a0:92:08:23:d8:00 upk2esphome-bk7231n

Just flashing the bootloader worked. Thanks!

Depending on whether you've flashed OpenBeken using their official tool (which overwrites the bootloader)

this is no longer the case. This can be checked if bootloader overwrite is desired

OpenBeken currently doesn't have means to change encryption keys, LibreTiny/ESPHome does.

It's a lot easier with LT/ESPhome but OpenBeken can tried by changing key in https://github.com/openshwprojects/OpenBK7231N/blob/master/platforms/bk7231n/bk7231n_os/build.sh


Show name on polygon symbols has no effect on map

According to signature symbols there is a name field and a checkbox for display name on the map
for signatures the name apperas below the symbol
but on polygons the name does not appear on the map
maybe check if the checkbox has to be hidden or the text on polygons should appear somewhere else... referring to ticket #17
note: there are signatures in combination with polygons where the name appears below the signature

When creating a polgyon without signature the name does not appear anywhere because the name is always related to the signatures.


Interactive tutorials

Some basic interactive tutorials in all 3 clients, Node, Python, Java to control mouse movement with a joystick.
I did debate making them screen controls but joysticks help teach the user control editor operations.
All comments welcome.
We need to decide where more advanced discussions about how interactive works goes too.
Anything from http://beam-interactive.readthedocs.io/en/latest/ thats not a tutorial basically.

@ProbablePrime, thanks for your PR! By analyzing the blame information on this pull request, we identified @SimonSchick to be a potential reviewer

Minor comments about js example, rest looks good tho.

@SimonSchick Can you take a look at the latest commit regarding your comments. Want to get the full code good before i backport the tutorial to match.

Looks fine.


No cameras found

Hey there,
i try to figure out why i cannot download any data from my UDMP. I checked via interface and there is data for the specific time and i can download it from the interface.
i run Docker for Mac.
xxxx@XXXX ~ % docker run -v /var/lib/docker/volumes/730ee565bf8c8945422cf50dbc507ecc06c3e583903dd0849179336c8e2f7a07/_data:/downloads unifitoolbox/protect-archiver download --address <IP_ADDRESS> --username="local_username" --password="local_user_password" --use-subfolders --start="2021-09-01 02:00:00" --end="2021-09-05 02:00:00"  --ignore-failed-downloads   --skip-existing-files  --cameras=all  --touch-files /downloads
Getting camera list
Successfully authenticated as user backup using a session cookie
Successfully retrieved data from https://<IP_ADDRESS>:443/proxy/protect/api/cameras
0 files downloaded (0.0 b), 0 files skipped, 0 files failed, 0 files total
Cameras found:

Hi there!
Are (some of) the cameras offline? There's a bug that, last time I checked, causes offline cameras not to be returned from the API, resulting in the tool not knowing that they're there.
Other than that it could also be either some kind of permissions issue or a more general problem with (or a change in) the API itself.
What's your current Protect version? Do you have G3 Instant cameras in your setup?

Its up and running. Actually the cameraas where unplugged. So easy. Thx.
Did you ever try it with docker for mac? Its working fine but i do not know how to get the data out of docker. ^^is there a possibility to add a process working indicator to the cmd line? maybe for each file? filesize and then percentage?

Nice! Yeah, hopefully I can fix that soon so that all cameras, even the ones that are offline, will show up.
Yes, I'm using Docker for Mac during development. Have a look at the 'File Sharing' tab in Docker Desktop --> Settings --> Resources (https://docs.docker.com/desktop/mac/#file-sharing)
Docker on macOS runs within a VM in the background, that's why you can't natively access your host's paths. So in order to use a 'real' local directory, you have to forward it first and then use it as a volume mount. Let me know if you need additional help with that and I'll guide you through setting it up.
I've added a feature request (#64) for your suggestion with the progress indicator. Thanks for the idea!

Great. Docker takes ages to startup at my MacBook. And trust me it is not a performance issue. 😅
THIS EMAIL WAS SENT FROM A MOBILE DEVICE. - JH //<PHONE_NUMBER>31 // @.***

From: Daniel Fernau @.>
Sent: Thursday, September 16, 2021 10:52:57 PM
To: unifi-toolbox/unifi-protect-video-downloader @.>
Cc: thx4-jh @.>; Author @.>
Subject: Re: [unifi-toolbox/unifi-protect-video-downloader] No cameras found (#63)
Nice! Yeah, hopefully I can fix that soon so that all cameras, even the ones that are offline, will show up.
Yes, I'm using Docker for Mac during development. Have a look at the 'File Sharing' tab in Docker Desktop --> Settings --> Resources (https://docs.docker.com/desktop/mac/#file-sharing)
Docker on macOS runs within a VM in the background, that's why you can't natively access your host's paths. So in order to use a 'real' local directory, you have to forward it first and then use it as a volume mount. Let me know if you need additional help with that and I'll guide you through setting it up.
I've added a feature request (#64https://github.com/unifi-toolbox/unifi-protect-video-downloader/issues/64) for your suggestion with the progress indicator. Thanks for the idea!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/unifi-toolbox/unifi-protect-video-downloader/issues/63#issuecomment-921236693, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASMCHSJE4IMC362ZEBNQHODUCJKKTANCNFSM5D4CPHFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


feat: add CloudNativePG

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[X] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[X] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[X] Have you added your SVG to hosted_logos and referenced it there?
[X] Does your logo clearly state the name of the project/product and follow the other guidelines?
[X] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

We do not have an entry in Crunchbase. Our goal is to apply again for the CNCF and donate the IP to the CNCF (currently the IP is owned by the CloudNativePG community).


Error parsing attribute "@relation" when unique/id index is in different order

Bug description
The Prisma model will not generate if there is a valid key whose columns are in a different order than it expects them.
How to reproduce

Create a model from the template below
See the file and observe the highlighted error

Expected behavior
It should work.
Prisma information
model nabzak {
  offerID         Int             @db.UnsignedSmallInt
  periodID        Int             @db.UnsignedSmallInt
  carrierID       Int
  reservation     String?         @db.Char(2)
  wanted          Int?            @db.TinyInt
  carrierInPeriod CarrierInPeriod @relation(fields: [offerID, periodID, carrierID], references: [offerID, periodID, carrierID], onDelete: Cascade, onUpdate: NoAction)

  @@id([offerID, carrierID, periodID])
  //@@unique([offerID, periodID, carrierID]) // This would fix it, but it is not necessary as for uniquess the order of columns does not matter
  @@index([offerID], map: "idZak")
  @@index([offerID, periodID, carrierID], map: "nabzak_zaknos")
  @@index([carrierID], map: "ncis")
}

model CarrierInPeriod {
  offerID   Int     @map("idZak") @db.UnsignedSmallInt
  periodID  Int     @map("idObdobi") @db.UnsignedSmallInt
  carrierID Int     @map("ncis")
  nabzak    nabzak?

  @@id([offerID, periodID, carrierID])
  @@index([offerID, periodID], map: "IDZak & IDObdobi")
  @@index([offerID, carrierID], map: "IDZak & ncis")
}

Environment & setup

OS: Windows
Database: MySQL
Node.js version: v16.13.2

Prisma Version
prisma                  : 4.1.1
@prisma/client          : 4.1.1
Current platform        : windows
Query Engine (Node-API) : libquery-engine 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 8d8414deb360336e4698a65aa45a1fbaf1ce13d8 (at<EMAIL_ADDRESS>Default Engines Hash    : 8d8414deb360336e4698a65aa45a1fbaf1ce13d8
Studio                  : 0.469.0
Preview Features        : interactiveTransactions

Hi, @pantharshit00 would you look into this? This very nasty bug prevents me from using Prisma 4 and above.
There is also a problem with introspection (prisma db pull), the introspection only populates one column in fields and references.
Created:
@relation(fields: [offerID], references: [offerID], onDelete: Cascade, onUpdate: NoAction)

What it should be:
@relation(fields: [offerID, periodID, carrierID], references: [offerID, periodID, carrierID], onDelete: Cascade, onUpdate: NoAction)

CREATE TABLE `nabzak` (
  `offerID` smallint unsigned NOT NULL,
  `periodID` smallint unsigned NOT NULL,
  `carrierID` int NOT NULL,
  `reservation` char(2) CHARACTER SET cp1250 COLLATE cp1250_czech_cs DEFAULT NULL,
  `wanted` tinyint DEFAULT NULL,
  PRIMARY KEY (`offerID`, `carrierID`, `periodID`),
  KEY `nabzak_zaknos` (`offerID`,`periodID`,`carrierID`),
  KEY `carrierID` (`carrierID`) /*!80000 INVISIBLE */,
  KEY `offerID` (`offerID`),
  CONSTRAINT `nabzak_zaknos` FOREIGN KEY (`offerID`, `periodID`, `carrierID`) REFERENCES `CarrierInPeriod` (`offerID`, `periodID`, `carrierID`) ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=cp1250 COLLATE=cp1250_czech_cs;

The uniqueness of the group of columns is given by their presence in @id or @unique, not the order; but, for performance sake,  if the order in @id or @unique is not the same, it should probably warn about missing index in the correct order.

Please create a separate issue for the second problem so we can treat this separately. We will focus on the text of your original issue description here.

Here is a more minimal reproduction based on your schema of what you are describing:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

model nabzak {
  offerID         Int
  periodID        Int
  carrierID       Int
  carrierInPeriod CarrierInPeriod @relation(fields: [offerID, periodID, carrierID], references: [offerID, periodID, carrierID], onDelete: Cascade, onUpdate: NoAction)

  //@@unique([offerID, periodID, carrierID]) // This would fix it, but it is not necessary as for uniquess the order of columns does not matter
  @@id([offerID, carrierID, periodID])
}

model CarrierInPeriod {
  offerID   Int
  periodID  Int
  carrierID Int
  nabzak    nabzak?

  @@id([offerID, periodID, carrierID])
}

Validation error:
> npx prisma validate
Error: Get DMMF: Schema parsing - Error while interacting with query-engine-node-api library
Error code: P1012
error: Error parsing attribute "@relation": A one-to-one relation must use unique fields on the defining side. Either add an `@@unique([offerID, periodID, carrierID])` attribute to the model, or change the relation to one-to-many.
  -->  schema.prisma:14
   |
13 |   carrierID       Int
14 |   carrierInPeriod CarrierInPeriod @relation(fields: [offerID, periodID, carrierID], references: [offerID, periodID, carrierID], onDelete: Cascade, onUpdate: NoAction)
15 |
   |

Validation Error Count: 1

Prisma CLI Version : 4.1.1

Uncommenting the @@unique index which has the to be unique fields in the same order as defined in fields removes the validation error.
So the bug should be that uniqueness of fields are guaranteed by @@unique and @@id in any order of the combined fields, not just by the one in use in fields. Correct @Akxe?

So the bug should be that uniqueness of fields are guaranteed by @@unique and @@id in any order of the combined fields, not just by the one in use in fields. Correct @Akxe?

@janpio Yes but, I am not sure if it is MySQL only error

Next step: Look into database behavior.

If I understand the issue correctly, and my reproduction is correct, it looks like the PSL validation we have matches what the database expects (i.e. the fields in the right order).
Reproduction:

@Akxe  Are you using innodb? Do you have other particularities about your mysql instance that might explain the discrepancy?

If I understand the issue correctly, and my reproduction is correct, it looks like the PSL validation we have matches what the database expects (i.e. the fields in the right order).
Reproduction:

@Akxe  Are you using innodb? Do you have other particularities about your mysql instance that might explain the discrepancy?

I do have a foreign key check off, but usually, these errors are fought anyway. I know for certain that I cannot create the link between tables when an index is missing, but maybe if check is off and a primary key exists in a different order it will still work? I don't know, it is very interesting...

@janpio @tomhoule I have used the expression SET foreign_key_checks = 0 to disable foreign key checks off.


No.") THEN
        ERROR(Text038,Cont."No.",Cont.Name,"Bill-to Customer No.");
END;

UpdateBillToCust("Bill-to Contact No.");

In Our Solution we have contacts that are not linked to a company but can also become customers that can order items and so on. We need to be able to skip the default error here to be able to use these kind of customers. Can you please add this publisher?

Already done for https://github.com/microsoft/ALAppExtensions/issues/6866.


GH #173 L3 ds composite-In Low level Test specification and procedure document

_ No description provided. _

please add description


feat(starter): add vitest

What is it?
New starter command for implementing vitest npm run qwik add vitest

[x] Feature / enhancement

[X] My code follows the developer guidelines of this project

[x] I have performed a self-review of my own code

[X] I have made corresponding changes to the documentation

[x] Added new tests to cover the fix / functionality

Amazing job Leifer!! merged!


Updated my London Underground solution to also have an Azure Logic Apps option for the processing

Q
A

Bug fix?
No

New sample?
yes

What's in this Pull Request?
Hello
I have updated my London Underground solution to use Azure Logic Apps so have updated my london-tubes-status folder to include the Logic apps JSON and added instructions to install using Azure Logic Apps.
Thanks again
Leon

Thanks @LeonArmston!

Thanks @LeonArmston!

Thanks @thechriskent


Run a custom script at renewal time

Some applications don't notice when their certificates are changed on disk after auto-renewal.
step ca renew has an --exec option to allow arbitary code to be run at renewal time, but the existing autocert-renewal container doesn't hook into that.
This pach updates autocert-controller to add a volumeMount to the renewal container if the user has created an autocert.step.sm/renewalVolume annotation (with a value of the name of the volume to mount).
It also updates autocert-renewal to check for a file at /renewer/renewal.sh and, if found, adds an --exec=/renewer/renewal.sh option to step ca renew.
It's a bit of a hack, I'm not entirely happy with it, but it does work, allowing users to signal the main application in the appropriate way after a renewal.
Feedback/advice/suggestions welcome/encouraged!

Hi @Moosemorals, it makes sense to be able to execute a script after creating or renewing a certificate; your implementation has good ideas, but I don't think it is the right approach.
As you mentioned, it will require shareProcessNamespace: true. This can be solved if the main pod has some inotify-based script, but this is not my main concern. A user might want also to change the bootstrapper image or perhaps add something more complex that is difficult to achieve with the --exec option.
Right now, you always have the option to change the images or even add volumes in the autocert config.yaml. However, these are global variables, and making it work on every deployment might not be trivial.
We'll have to figure out a way not just to add the --exec option, an easy way to mount a ConfigMap with one or more files, and execute those instead of just step ca renew .... As I said, config.yaml is an option, but it will be hard to generalize. A better option that comes on the top of my head (which might or might not work) is to label the ConfigMap with something special, so it gets automatically loaded for a specific pod/deployment on the bootstrapper or the renewer image. Then, a script automatically runs instead of the predefined one if it has a fixed name or, if needed, it has a label with the command to run.
We'll have to come up with a design on how to make this work, but I think it will provide more flexibility than this.
I'd like to hear from you, what do you think?
@areed @mmalone @jdoss Ideas?

I think we should solve the problem of restarting services after renewal in the simplest way possible for users.
I propose adding an annotation autocert.step.sm/term: nginx. When that is present:

the admission controller sets shareProcessNamespace: true on the pod
the renewal container runs kill $(pgrep "nginx") after renewal

I think that's probably a little too simple, I'd want to be able to at least choose the signal (eg, postgres will reload config on a SIGHUP, haproxy wants a SIGUSR2)

Would something like autocert.step.sm/kill/9: nginx work?

I'm new to this whole k8s thing so I don't know the culture/style, but I'd just add another attribute for signal name/number, unless there's some cost I'm missing?
(Although I'm still voting for running a script, as that gives most flexibility to users.)
I had a bit of a play with shared volumes, but the problem comes down to the renew container (and step ca renew specifically) needs to send some kind of message to the prime container at renew time. Once that message is received, then the prime container can do whatever it needs
Shared process space allows signals, which are easy at both ends.
Without that, then something like a shared volume and inotify should work but that would need more cooperation from the prime container (some services can be setup to listen on a unix socket for commands, but I think that's probably less common than signals, and the format for the 'reload config/certs' command will almost certainly be different per service) (also, do unix sockets work cross container?)

@areed I kind of prefer something more flexible and mount a configmap with a special set of labels for different actions:

For which pod I should mount this - mandatory.
A fixed filename to replace completely the bootstrap script.
A fixed name to replace the completely renew script.
An action for --exec (or a set of environment variables, STEP_EXEC defines the flag --exec too.
Pre-bootstrap-script, Pre-renew-script to run.
Post-*-script to run.7.
If we need to set shareProcessNamespace: true
...

Then both bootstrap and renewer scripts can be aware of all that.

My proposal is perhaps to complex and for just --exec it might make more sense something simpler, but if we're mounting configmaps like this PR proposes, I think we can make it more flexible. but if it's just sending a signal I might accept it.
This is the set of related flags that step ca renews accepts:
--pid=value
    The process id to signal after the certificate has been renewed. By
    default the the SIGHUP (1) signal will be used, but this can be
    configured with the --signal flag.

--pid-file=file
    The file from which to read the process id that will be signaled after
    the certificate has been renewed. By default the the SIGHUP (1) signal
    will be used, but this can be configured with the --signal flag.

--signal=number
    The signal number to send to the selected PID, so it can reload the
    configuration and load the new certificate. Default value is SIGHUP (1)

--exec=command
    The command to run after the certificate has been renewed.

I had a look at --pid-file and --signal, and I can't see a way of using them that doesn't use both shared process and a shared volume.


Rollup bug for un-minified UMD output with regard to constants

Minified works likely because of Terser doing a better job of understanding what's going on
For reasons only known to Rollup.... it seems to get confused when it starts resolve module dependencies.... when the same constant is referenced from to distinct entry points.

instead of normal output:
const noAccountFound = "no_account_found";
You see:
const index.noAccountFound = "no_account_found"
This PR is a temporary fix?? Until we have time to understand rollup better and propose a PR to them.  OR until it gets fixed in a future release of rollup.

Codecov Report

Merging #6565 (f09ceb0) into dev (81d34b4) will increase coverage by 9.24%.
Report is 351 commits behind head on dev.
The diff coverage is n/a.

Flag
Coverage Δ

msal-angular
?

msal-browser
?

msal-common
?

msal-core
?

msal-node
?

msal-node-extensions
?

msal-react
94.24% <ø> (-0.45%)
:arrow_down:

node-token-validation
?

see 226 files with indirect coverage changes


Update with "show more reviews" and "write a review" features

cannot test right now, but the code looks fine. I will merge, trusting your skills :wink: thank you very much for contributing AND writing documentation to the Readme :tada:

cannot test right now, but the code looks fine. I will merge, trusting your skills 😉 thank you very much for contributing AND writing documentation to the Readme 🎉

Documentation already written! 😉


Query result type inference often not working with getOneOrNullResult

See failures in https://github.com/phpstan/phpstan-doctrine/pull/270, all the new getOneOrNullResult are infered as mixed even though the getResult works fine.
E.g. here

/cc @arnaud-lb

Hi @janedbal
Currently, Query result type inference supports only HYDRATE_OBJECT mode. What happens here is that we don't know the hydration mode of getOneOrNullResult() when called with 0 arguments, because it defaults to $this->_hydrationMode.
getResult() is different because its default hydration mode is HYDRATE_OBJECT.
One way to get type inference out of getOneOrNullResult() is to specify the hydration mode when calling it: getOneOrNullResult(Query::HYDRATE_OBJECT).
(See https://github.com/phpstan/phpstan-doctrine/pull/232#issuecomment-1015686749 for details on how each getResult() variant is supported.)

I see, thanks for response, I'll force passing hydration type to getOneOrNullResult in our codebase to make it analysable.


Revocation notification

https://github.com/hyperledger/aries-rfcs/tree/main/features/0721-revocation-notification-v2
Signed-off-by: Miroslav Kovar<EMAIL_ADDRESS>

Codecov Report

Merging #608 (972bfd0) into main (d55260e) will decrease coverage by 11.34%.
The diff coverage is 10.38%.

@@             Coverage Diff             @@
##             main     #608       +/-   ##
===========================================
- Coverage   58.99%   47.64%   -11.35%
===========================================
  Files         199      200        +1
  Lines       19218    14376     -4842
  Branches     4369     2770     -1599
===========================================
- Hits        11337     6849     -4488
- Misses       3547     5333     +1786
+ Partials     4334     2194     -2140

Flag
Coverage Δ

integration-aries-vcx
?

unittests-agency-client
29.12% <ø> (ø)

unittests-aries-vcx
47.17% <10.38%> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aries_vcx/src/handlers/issuance/issuer.rs
52.55% <0.00%> (-5.36%)
:arrow_down:

aries_vcx/src/protocols/issuance/actions.rs
20.00% <0.00%> (-31.86%)
:arrow_down:

messages/src/a2a/message_family.rs
30.13% <0.00%> (-55.38%)
:arrow_down:

messages/src/a2a/mod.rs
22.16% <0.00%> (-37.84%)
:arrow_down:

messages/src/a2a/protocol_registry.rs
0.00% <0.00%> (-61.71%)
:arrow_down:

messages/src/ack/mod.rs
56.41% <0.00%> (ø)

messages/src/connection/response.rs
81.81% <ø> (+0.42%)
:arrow_up:

messages/src/issuance/credential.rs
55.31% <ø> (+0.97%)
:arrow_up:

messages/src/issuance/mod.rs
72.22% <ø> (ø)

messages/src/issuance/revocation_notification.rs
0.00% <0.00%> (ø)

... and 116 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Menus are too big for Gameboy screen size

Pause doesn't show at all, and Pokedex is too big.

In general, the menus should really just be identical to the original game.


Fixed holiday expand logic

Fixed logic for holidays starting before the span provided, added optional start_date to from which the holiday should be measured.
Added expand logic for business days.

LGTM


New glibc changes causing headmaster grief

During the build process when headmaster is invoked it results in the following errors:
import.h:144:1: <bits/libio.h> is not found.
/usr/include/netdb.h:608:11: macro AI_IDN_ALLOW_UNASSIGNED is failed to preprocess.
/usr/include/netdb.h:610:11: macro AI_IDN_USE_STD3_ASCII_RULES is failed to preprocess.
/usr/include/netdb.h:649:11: macro NI_IDN_ALLOW_UNASSIGNED is failed to preprocess.
/usr/include/netdb.h:651:11: macro NI_IDN_USE_STD3_ASCII_RULES is failed to preprocess.
/usr/include/sys/cdefs.h:423:10: macro __attribute_nonstring__ is failed to parse.
/usr/include/bits/byteswap.h:37:10: __builtin_bswap16 is undeclared.
/usr/include/bits/types/struct_FILE.h:112:37: currently, macro argument could not be inferenced as struct or union.
/usr/include/bits/types/struct_FILE.h:112:9: expression-like macro __feof_unlocked_body is failed to interpret.
/usr/include/bits/types/struct_FILE.h:115:39: currently, macro argument could not be inferenced as struct or union.
/usr/include/bits/types/struct_FILE.h:115:9: expression-like macro __ferror_unlocked_body is failed to interpret.
/usr/include/bits/types/struct_FILE.h:103:22: currently, macro argument could not be inferenced as struct or union.
/usr/include/bits/types/struct_FILE.h:102:9: expression-like macro __getc_unlocked_body is failed to interpret.
/usr/include/bits/types/struct_FILE.h:107:22: currently, macro argument could not be inferenced as struct or union.
/usr/include/bits/types/struct_FILE.h:106:9: expression-like macro __putc_unlocked_body is failed to interpret.
make: *** [Makefile;737: adainclude/c.ads] Error 1

Oh my system (running a very recent build of glibc) libio.h is now gone, instead of being deprecated.  They recommend you use stdio.h instead.
See https://sourceware.org/git/?p=glibc.git;a=commit;h=a4fea3f2c3253b9ae6ffacd3747034ccbe56bc60

As for the rest, here's the offending lines and a bit of context for the rest:

netdb.h:

#  define AI_IDN_ALLOW_UNASSIGNED \
  __glibc_macro_warning ("AI_IDN_ALLOW_UNASSIGNED is deprecated") 0x0100
#  define AI_IDN_USE_STD3_ASCII_RULES \
  __glibc_macro_warning ("AI_IDN_USE_STD3_ASCII_RULES is deprecated") 0x0200

cdefs.h:

# define __attribute_nonstring__ __attribute__ ((__nonstring__))

byteswap.h:

static __inline __uint16_t
__bswap_16 (__uint16_t __bsx)
{
#if __GNUC_PREREQ (4, 8)
  return __builtin_bswap16 (__bsx);
#else
  return __bswap_constant_16 (__bsx);
#endif
}

struct_FILE.h:

/* These macros are used by bits/stdio.h and internal headers.  */
#define __getc_unlocked_body(_fp)					\
  (__glibc_unlikely ((_fp)->_IO_read_ptr >= (_fp)->_IO_read_end)	\
   ? __uflow (_fp) : *(unsigned char *) (_fp)->_IO_read_ptr++)

#define __putc_unlocked_body(_ch, _fp)					\
  (__glibc_unlikely ((_fp)->_IO_write_ptr >= (_fp)->_IO_write_end)	\
   ? __overflow (_fp, (unsigned char) (_ch))				\
   : (unsigned char) (*(_fp)->_IO_write_ptr++ = (_ch)))

#define _IO_EOF_SEEN 0x0010
#define __feof_unlocked_body(_fp) (((_fp)->_flags & _IO_EOF_SEEN) != 0)

#define _IO_ERR_SEEN 0x0020
#define __ferror_unlocked_body(_fp) (((_fp)->_flags & _IO_ERR_SEEN) != 0)

Thanks.
The glibc's headers (<= 2.27??, current stable version at least) have the problem of circular reference between stdio.h and libio.h. So libio.h should be included before malloc.h that is includes stdio.h, to control the order of their declarations.
I have not understood and will explore what about the problem has become in the recent version...

I has built latest glibc just now, and noticed that __GLIBC_MINOR__ is still 27, not incremented yet.
We can not determine the under-development version by #if at this time.
https://sourceware.org/git/?p=glibc.git;a=blob;f=include/features.h;h=d22c32eee6a98c350cad4267b15355fb271b9818;hb=HEAD#l420
BTW, libio.h may be replaced to struct_FILE.h.

I use glibc built from git master, so these changes are probably coming in the next release version.

https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=3c03baca37fdcb52c3881e653ca392bba7a99c2b
__GLIBC_MINOR__ has been incremented now.
I'll retry to build...


Report task dependencies access at execution time as an instant execution problem

Accessing task dependencies expose the project state thus is a problem with instant execution.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


unable to install brackets extension unknown internal error (ubuntu 14.10)

@raminox Can you please do troubleshoot given in https://github.com/adobe/brackets/wiki/Troubleshooting#extension-install Are you able to use Live Preview ?

Yeah live preview it seems working well

@raminox Hii. Some steps:

Have you tried the troubleshoot guide given above?

Can you do following -
Go to Debug -> Show Developer Tools
Go to the Console tab

If you see any error there, can you paste it here.

Are you able to install the extension manually i..e. by dragging the zip file.

I did what you mentioned above & all i got this message
[node-error 10:28:32 AM] [Launcher] uncaught exception
at top level, exiting. Error: listen EADDRINUSE
at errnoException (net.js:901:11)
at Server._listen2 (net.js:1039:14)
at listen (net.js:1061:10)
at net.js:1135:9
at dns.js:72:18
at process._tickCallback (node.js:415:13) ErrorNotification.js:125
[node-info 10:28:32 AM] [Server] stopping NodeDebugUtils.js:114
[NodeDomain] Error loading domain "staticServer": [object Object] ErrorNotification.js:125
Failed to load resource

I have the same problem (on 15.04) but running within a docker container

was this ever fixed ? I want to be able to run brackets on a docker process - are there any readme's on how to do this ?

+1

bump ? Anyone ? We've got 1.6 running in a docker container, but have the same issue again. I also see that there is something in the about page ..

the last sentence kinda hints that there's a problem somewhere, I was just wondering if it were related
thanks

This Usually happens when brackets cant access the network.

what kind of access is needed ? We're trying to get this running in docker - so the shell inside the docker container (bash) can access the outside world (npm install etc) ... so I would imagine a process started from that shell would also have access. Unless there's something being blocked somewhere .. ;) Any hints ?

Weel I do not know that, The message (we are having trouble accessing..) is the fail handler for the ajax request.
Which means that the network access didn't go through.

when you say "brackets" are you talking about the client side (in the browser) or the node side ? what is port 9234 used for ? I'm wondering if docker / firewall is blocking this port  - as it may explain the other issues (help/about, install extensions, can;'t debug->show dev tools

port 9324 is the debug port for brackets. If that is blocked, then debug>show developer tools will fail. It should not affect functioning of any other parts of brackets.


[KOGITO-3917] Adding state filtering

Adding state filtering support
See modified example here https://github.com/kiegroup/kogito-examples/pull/1017

The (build) kogito-runtimes check has failed. Please check the logs.

The (build) kogito-examples check has failed. Please check the logs.

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

The (build) kogito-apps check has failed. Please check the logs.

The (build) optaweb-employee-rostering check has failed. Please check the logs.


ImGUI for other process

How can I render ImGUI in another DirectX game?

Not really sure I can help here -- it's a bit outside my area of expertise. The rendering itself would look the same, but the main issue you'll face is getting your code to run at the right time.


Add a generic return type to autoreleasepool()

This is a general usability improvement that lets users
easily get values out of the closure.
While this is technically a breaking change I think it would be best to let it slide. I don't think there are any users of autoreleasepool() yet and even if there are this change is unlikely to break them.

@kvark

Thanks! Agreed, I'm going to keep this in the 0.2.x version.


PowerToys 0.59.0 support for ARM64

Add ARM64 installer link for PowerToys (ARM64 builds are available since 0.59.0).

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@ktos thanks!


Problems with loading CSVDatSet with no header

Description
Hi, I meet one problem with CSVDataSet when the file contains no header. Here I will show how to reproduce it using the official example "pandas-iris".
Context
I encounter this problem when loading a partitioned dataset with gzip compression. It is a little complex to add all gzip files with header lines. After I find this error, I do the testing on the example project and reproduce the error.
Steps to Reproduce

Download the example project
kedro new --starter=pandas-iris
Delete the header of iris.csv
Modify catalog.yml as (here I made 3 trials, I will explain the results later):

# Case 1
example_iris_data:
  type: pandas.CSVDataSet
  filepath: data/01_raw/iris.csv
  load_args:
    header: false

# Case 2
example_iris_data:
  type: pandas.CSVDataSet
  filepath: data/01_raw/iris.csv
  load_args:
    header: None

# Case 3
example_iris_data:
  type: pandas.CSVDataSet
  filepath: data/01_raw/iris.csv
  load_args:
    header: 0

Expected Result
Load the iris.csv file with no header. 0, 1, 2, 3, ... are automatically generated as the column names. The expected behavior should be exactly the same with pd.read_csv('iris.csv', header=None)
Actual Result
In case 1, it generates the error message as:
kedro.io.core.DataSetError: Failed while loading data from data set CSVDataSet(filepath=E:/work/kedro-example-iris/data/01_raw/iris.csv, load_args={'header': False}, protocol=file, save_args={'index': False}).
Passing a bool to header is invalid. Use header=None for no header or header=int or list-like of ints to specify the row(s) making up the column names

Following this error message, I change to case 2, and get the error message as:
kedro.io.core.DataSetError: Failed while loading data from data set CSVDataSet(filepath=E:/work/kedro-example-iris/data/01_raw/iris.csv, load_args={'header': None}, protocol=file, save_args={'index': False}).
header must be integer or list of integers

Following this error message, I change to case 3. This time it runs without error message, but when I check the data it reads, I find it does not assume there is no header by printing out the data on the first line of split_data.
def split_data(data: pd.DataFrame, example_test_data_ratio: float) -> Dict[str, Any]:
    print(data.head())
    data.columns = [
        "sepal_length",
        "sepal_width",
        "petal_length",
        "petal_width",
        "target",
    ]
   ...

Your Environment
Include as many relevant details about the environment in which you experienced the bug:

Kedro version used (pip show kedro or kedro -V): Kedro 0.17.5
Python version used (python -V): python 3.8 and 3.6
Operating system and version: Windows and CentOS

Thanks.

Can you try using a YAML null?
https://stackoverflow.com/a/34089604/2010808


REST service to update existing Rasa test stories

AS AN Architect
I WANT to have a REST service to update an existing Rasa test story
SO THAT there wouldn't be duplicate services for it
Acceptance Criteria

[ ] Use POST service /rasa/test-stories/update
[ ] Apply changes on Rasa tests/test_stories.yml
[ ] Changes apply for the chosen test story only
[ ] Input as valid JSON
[ ] Convert input JSON to YAML by using #45
[ ] Changes apply only in case #106 responds with HTTP 200

Examples
Input
An existing tests/test_stories.yml
stories:
- story: greetings
  steps:
  - user: |
      aitäh
    intent: greetings
  - action: utter_greetings
  - user: |
      Head aega
    intent: tänamine

- story: common_tervitus
  steps:
  - user: |
      tere
    intent: common_tervitus
  - action: utter_common_tervitus

- story: common_hüvasti_jätmine
  steps:
  - user: |
      headaega
    intent: common_hüvasti_jätmine
  - action: utter_common_hüvasti_jätmine

New input for test story greetings instead of "aitäh" is "aitüma" and "laters" instead of "Head aega"
Output
New content of tests/test_stories.yml
stories:
- story: greetings
  steps:
  - user: |
      aitüma
    intent: greetings
  - action: utter_greetings
  - user: |
      Laters
    intent: tänamine

- story: common_tervitus
  steps:
  - user: |
      tere
    intent: common_tervitus
  - action: utter_common_tervitus

- story: common_hüvasti_jätmine
  steps:
  - user: |
      headaega
    intent: common_hüvasti_jätmine
  - action: utter_common_hüvasti_jätmine

sample input for /rasa/test-stories/update
{
  "story": "common_tervitus",
  "steps": [
    {
      "user": "tere tere\n",
      "intent": "common_tervitus"
    },
    {
      "action": "utter_common_tervitus"
    }
  ]
}

@RaulAltmae please link this issue with an appropriate pull request.

Pull request https://github.com/buerokratt/Training-Module/pull/166


adding is.vivaldi() support

Dup of #126. Since vivaldi is built of off chromium + blink I think it's fine that it's detected as is.chrome.
Is.js is not intended to be the be-all-end-all of UA sniffing. There are projects like ua-parser for that.

Ok :+1:


Add date time skew check to both v2 and v4 authentication

1/2 for RCS-118

I believe this is ready to review.

Nice work :smile_cat: All riak_test passes.
I want to discuss the comment just above before merge.

Updated and see whether external_client_tests

Should the last argument AnonOk be wildcard?
https://github.com/basho/riak_cs/blob/feature/check-signed-date/src/riak_cs_wm_common.erl#L478-L479

I haven't tested AWS behaviour. And looks like AnonOk doesn't make sense to me, the whole code. parse_auth_header/1 is supposed to return undefined|list() and looks like never returns boolean. Am I wrong?

Memo to self

anon_ok was introduced at https://github.com/basho/riak_cs/commit/28c98d975c3318067306ce75d639cdf978cdaf02
only riak_cs_wm_buckets returns false, others used default impl which returns true

parse_auth_header/1 is supposed to return undefined|list() and looks like never returns boolean.

AnonOk is not a return value from parse_auth_header/1. It's wm callback that
submodules may implement.

And looks like AnonOk doesn't make sense to me, the whole code.

It looks like almost true.
If riak_cs_wm_buckets implements its own authorize/2 and forbids anonymous access,
we can get rid of anon_ok callback completely.

Looks like AnonOk is also generated from keystone authentication. I'd better be rain check.

This is ready again for review.

Checkout slightly old riak_cs_multibag repo : git checkout 7da4f32

All riak_test passed :bangbang:

@borshop merge


Tomm/database config

Fix database config
Adjust not found and error handler

Codecov Report

Merging #41 (402c71d) into dev (37faa7c) will decrease coverage by 44.30%.
The diff coverage is 40.80%.

@@             Coverage Diff             @@
##              dev      #41       +/-   ##
===========================================
- Coverage   85.71%   41.40%   -44.31%
===========================================
  Files           1        8        +7
  Lines           7      128      +121
  Branches        0       16       +16
===========================================
+ Hits            6       53       +47
- Misses          1       67       +66
- Partials        0        8        +8

Impacted Files
Coverage Δ

src/middleware/bearer.js
15.38% <15.38%> (ø)

src/handlers/error.js
16.66% <16.66%> (ø)

src/handlers/not-found.js
25.00% <25.00%> (ø)

src/routes/public.js
25.64% <25.64%> (ø)

src/models/user.js
31.25% <31.25%> (ø)

src/routes/user.js
75.00% <75.00%> (ø)

src/models/index.js
81.81% <81.81%> (ø)

src/server.js
93.33% <100.00%> (+7.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b59ca4...402c71d. Read the comment docs.


Form Submission?

Is there a way to use this library to submit forms and get the resultant HTML back? I am attempting to crawl on a webpage that uses a javascript form for 'pagination', and there's content hiding behind these other pages.

Figured it out. Incase anyone else is curious,
I just did this:
c.queue([{         url:  url,         method: "POST",         form: postBody,         callback: function(error, res, done){             $ = res.$;             console.log(res.body);         } }]);
and postBody is a javscript object like so:
postBody = {    key: "value",    key2: "value" }

close because it gets solved


Set padding_idx=0 by default in nn.Embeddings

By default padding_idx is set to None. Just based on how we do embedding mappings, this should be 0.

Snorkel MeTaL is moving into maintenance mode, as its features have been merged into Snorkel proper (https://github.com/snorkel-team/snorkel). As of Snorkel v0.9, abstains are represented with a -1, and we no longer natively support individual end model component modules, so I think we're safe to close this. Feel free to reopen if not. Thanks!


1 - Create the skeleton of the React SPA

What this PR does / why we need it:
This PR creates the React application skeleton for the frontend rarchitecture. It provides with a basic skeleton with all the needed configuration to start developing a feature/component for the Dataverse SPA. Additionally, React default component has been replaced by a HelloDataverse component.
Which issue(s) this PR closes:
Closes https://github.com/IQSS/dataverse-frontend/issues/1
Special notes for your reviewer:
Changes

React App with TypeScript
Jest and Testing Library  configured for unit tests
Cypress for e2e tests
i18next English language configuration for internationalization
ESlint and Stylelint for linting
Prettier formatter
Workflows for lint and tests
React Router
SASS and Bootstrap for stylesheets
Add HelloDataverse component

React Starter
More common tools:

Vite. Uses different bundler for production and development. The development bundler is faster but more unstable. This option was discarded because it may be differences between dev and production environments because of this 2 different bundlers.

Create React App. Uses webpack which is slower but the most stable solution right now. Really easy set up with the integrated scripts. In the future React may change the bundler from webpack to another better solution but our code doesn't know anything about the bundler so it won't be affected. The code is not coupled to the bundler.

Testing
Jest with Testing Library chosen because it allows unit testing of the React components from the user perspective instead of directly testing the business implementation. This means that the unit tests are not modified after refactoring a component because the user should see the same behaviour. Some other libraries check directly the props or states which means that if you refactor a prop variable name then the unit test will stop working.
Cypress has great support for React and Testing Library. It is a widely used solution that works great.
i18next
i18next is already being used in the Dataverse project. It has been configured in the React skeleton because in the very first component there is going to be text to translate, so it is easier to have the i18n configuration from the beginning.
I also see an advantage in not having to see the text in the components because it allows you to see a structure instead of a component with a concrete use case, for example in HelloDataverse.tsx I know there is a translated title but I don't know what the specific text is:

{t('title')}

It is really recommended to see the video on i18next Introduction
ESlint, Stylelint and Prettier
A basic ESlint configuration has been added, we may want to add more rules in the future or change the existing ones but the configuration is already done to ensure the whole project is following the same linting rules.
It is recommended to run prettier formatted on save, see IntelliJ and VSCode configuration
React Router
From React Router:

React Router enables "client side routing".
Client side routing allows your app to update the URL from a link click without making another request for another document from the server. Instead, your app can immediately render some new UI and make data requests with fetch to update the page with new information.

It has been configured since the beginning because it is going to be used with every new page.
SASS and Bootstrap
Bootstrap is being used in the current Dataverse frontend so it will be used in the SPA too to maintain the UI appearance.
SASS is a really useful CSS extension, it has nesting, mixins and inheritance among other features to help with the CSS maintenance.
In React it can used like:
import styles from './HelloDataverse.module.scss'

{t('title')}

I really like that there is no need to think of class names, you can just call the class name .container in every component and there are not going to be conflicts between any other classes because  .container is automatically compiled to the class name .HelloDataverse_container.
This also forces you to not reuse CSS classes between components. Reuse the component, not the CSS class.
Workflows
I added 2 basic workflows to check the linting and the tests. They are configured to run on push and for the moment they are not taking so long. Test (5min) and lint(2min) but if they start to take longer then they might be configured to run only on merge.
The test workflow runs both unit and e2e tests. We may want to split them at some point and for example run the unit tests on push and the e2e on merge.
Hello Dataverse component
HelloDataverse.tsx is just the default Create React Component but adapted to Dataverse to have an overview of what a component would look like and test some initial configurations such as the translation hook from i18n.
This component will be removed once the first feature is developed.
Suggestions on how to test this:
Install node v19 and npm v9.
Run npm install
Run npm run start and go to http://localhost:3000 to see the application
Run npm run test for the unit tests
Run npm run cy:run for the e2e tests
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Hello Dataverse screen If you cannot access the screen please contact<EMAIL_ADDRESS>Is there a release notes update needed for this change?:
Not sure, the Hello Dataverse component will be removed for the release, but the skeleton will remain.
Additional documentation:
Dataverse - SPA Development Strategy

Looks great and everything worked well on my system 😊
One thing I wanted to ask you if instead of going purely React Router, wouldn't it make sense to choose Next.js? Especially the SSR and CSR capabilities are quite nice since I guess a big portion of Dataverse will be server-side. Also the (forced) directory structure could help overview all pages. What do you think?
Other than that, great stuff! Thanks for bringing Cypress on my radar, its insane 😍

Looks great and everything worked well on my system 😊
One thing I wanted to ask you if instead of going purely React Router, wouldn't it make sense to choose Next.js? Especially the SSR and CSR capabilities are quite nice since I guess a big portion of Dataverse will be server-side. Also the (forced) directory structure could help overview all pages. What do you think?
Other than that, great stuff! Thanks for bringing Cypress on my radar, its insane 😍

@JR-1991 great! 😊 Thank you for your comment. I can't answer directly the comment so I answer you here
I am not sure if I understood you correctly about using next.js for SSR. I think the goal is to have the SPA completely uncoupled from the backend, so no server side rendering for the frontend. Just an SPA connected to an API. Then I think React Router would work for this case.
And about the forced folders structure, I am not a big fan of having the folders structure imposed so I'll go with React Router approach. In general I think next.js will impose many things since it is a framework and React is a library. And at the moment I don't see clear advantages, maybe you were thinking about something in specific about next.js?

I am not sure if I understood you correctly about using next.js for SSR. I think the goal is to have the SPA completely uncoupled from the backend, so no server side rendering for the frontend. Just an SPA connected to an API. Then I think React Router would work for this case.

My bad, was mixing things up. Makes totally sense to use React Router, Next would be an overkill in that case 🙂

And about the forced folders structure, I am not a big fan of having the folders structure imposed so I'll go with React Router approach. In general I think next.js will impose many things since it is a framework and React is a library. And at the moment I don't see clear advantages, maybe you were thinking about something in specific about next.js?

Yea that's true, Next imposes a lot of things and regarding the folder structure, I guess thats where tastes go apart 😄 One specific advantage I see in using Next is the flexibility it offers for CSR/SSR and since we are interfacing a database, being as close as possible to the server for some components, like displaying a dataset, could benefit performance-wise. But as said above, I was mixing things up and for an SPA Next is overkill.

We are using react-query with Axios for API request and it made our lives a bit easier with refreshing, error handling and caching API request in the SPA. Maybe, its worth to explore/test those libraries for the dataverses SPA.

We are using react-query with Axios for API request and it made our lives a bit easier with refreshing, error handling and caching API request in the SPA. Maybe, its worth to explore/test those libraries for the dataverses SPA.

Hi @johannes-darms thank you for your comment! React query is really useful, I added it to the SPA MVP document to take it into account for API requests

Vite. Uses different bundler for production and development. The development bundler is faster but more unstable. This option was discarded because it may be differences between dev and production environments because of this 2 different bundlers.

Create React App. Uses webpack which is slower but the most stable solution right now. Really easy set up with the integrated scripts. In the future React may change the bundler from webpack to another better solution but our code doesn't know anything about the bundler so it won't be affected. The code is not coupled to the bundler.

Can we please talk a little more about Webpack vs. Vite? I am by no means an expert in this matter but mostly from podcasts I listen to, I get the impression that Vite is faster and more modern than Webpack. (The same observation about speed is already above.) I also get the impression that the "cool kids" are moving away from Webpack.
I understand the part about Create React App might switch away from Webpack to something better in the future. I don't see a direct dependency on Webpack in our package.json so it does seem like the code is not hard coded to use Webpack.
Vite was discarded because "may be differences between dev and production environments because of this 2 different bundlers"? I'm having trouble understanding what this means. In short, I'm wondering if we can use Vite. And if not, why not. 😅
We can talk this out in Slack or in our weekly meetings, of course, I just wanted to put this here in case we're close to merging this pull request (I have no idea).

Vite. Uses different bundler for production and development. The development bundler is faster but more unstable. This option was discarded because it may be differences between dev and production environments because of this 2 different bundlers.
Create React App. Uses webpack which is slower but the most stable solution right now. Really easy set up with the integrated scripts. In the future React may change the bundler from webpack to another better solution but our code doesn't know anything about the bundler so it won't be affected. The code is not coupled to the bundler.

Can we please talk a little more about Webpack vs. Vite? I am by no means an expert in this matter but mostly from podcasts I listen to, I get the impression that Vite is faster and more modern than Webpack. (The same observation about speed is already above.) I also get the impression that the "cool kids" are moving away from Webpack.
I understand the part about Create React App might switch away from Webpack to something better in the future. I don't see a direct dependency on Webpack in our package.json so it does seem like the code is not hard coded to use Webpack.
Vite was discarded because "may be differences between dev and production environments because of this 2 different bundlers"? I'm having trouble understanding what this means. In short, I'm wondering if we can use Vite. And if not, why not. 😅
We can talk this out in Slack or in our weekly meetings, of course, I just wanted to put this here in case we're close to merging this pull request (I have no idea).

Hi @pdurbin ! I'll try to answer you here just to keep the answer here for  future reference, but we can still discuss it in the weekly meeting
I know many people is choosing Vite over CRA, mostly because of the speed of Vite during the development
What I meant by "there may be differences between dev and production environments" is because Vite pre-bundles dependencies using esbuilt for the local development but it doesn't use it for the production build, so there may be inconsistencies between local and production build. It doesn't give me confidence that they do not use their esbuilt super fast solution for the real production build.
For me there was a decision, speed or stability, and I chose stability because I don't see that major difference in speed. I have used both Vite and CRA in different projects and I still haven't seen that speed difference. Stability and reliability I think is more important when speaking about a large and complex project like this one.
Moreover, CRA is designed specifically for React and it has a higher level of customisation than Vite, because Vite is designed to be a simple, fast solution, not just for React but for any project using JavaScript. I prefer that higher level of customisation because this is going to be a huge project and we don't know what we are going to need in the future, how specific do we need to get with the project build.
I hope I explain it better this time, and of course we can move to Vite if CRA still doesn't convince you 🙂

Vite pre-bundles dependencies using esbuilt for the local development but it doesn't use it for the production build, so there may be inconsistencies between local and production build. It doesn't give me confidence that they do not use their esbuilt super fast solution for the real production build.

For production builds, Vite uses Rollup, which is very popular. In all cases ES Modules are used so I'm not worried about inconsistencies.

For me there was a decision, speed or stability, and I chose stability because I don't see that major difference in speed. I have used both Vite and CRA in different projects and I still haven't seen that speed difference. Stability and reliability I think is more important when speaking about a large and complex project like this one.

Dataverse is built on stable tools like PostgreSQL, Solr, and the Jakarata EE APIs so I'm easily convinced by the stability argument. However, while CRA the technology seems stable enough, CRA the project shows some warnings signs.
Just yesterday I was listening to a podcast where the creator of Svelte said, "You mentioned Create React App, which is essentially a single page app framework, even the React team are now trying to get rid of. It kind of codifies a lot of bad practices."
The React team is trying to get rid of CRA? Is that right? I googled and easily found  a long comment from only a month ago by CRA co-creator Dan Abramov who had this to say:
"As the years passed, Create React App has stagnated."
"We could suggest people to migrate from Create React App to something like Vite."
He lays out five options for the future for CRA, from a huge rewrite to smaller endeavors. He says the React team is leaning toward option 5, which even mentions possibly moving to Vite under the hood:
"Option 5: Turn Create React App into a launcher
We could keep Create React App as a command, but turn it into a launcher. It would suggest a list of recommended frameworks, followed by the "classic" framework-less approach being the last option. That last "classic" approach would produce a client-only app like CRA does now (to avoid breaking tutorials), but could eventually move to Vite under the hood."
This leave me wondering, with so much talk of Vite from the creators of CRA, why not just use Vite?
Finally, to go back to the speed option, Dataverse is a big app and I do think we should be concerned about speed. Speed should be a feature. (That's what the creators of Stack Overflow said.)

Moreover, CRA is designed specifically for React and it has a higher level of customisation than Vite, because Vite is designed to be a simple, fast solution, not just for React but for any project using JavaScript. I prefer that higher level of customisation because this is going to be a huge project and we don't know what we are going to need in the future, how specific do we need to get with the project build.

I heard you on this concern. I'm sure we'll want customization. I just don't know if using Vite will be a problem in this regard or not. I guess we'll learn more if we try Vite.


The parent selection or operation does not resolve to a valid schema type

Before you create the issue

[x] Please search the existing issues at https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/issues?q=sort%3Aupdated-desc before opening a new issue.
[ ] Read the FAQ at https://github.com/jimkyndemeyer/js-graphql-intellij-plugin#faq - no FAQ there

Version and Environment Details
Operation system: Ubuntu 20
IDE name and version: WebStorm 2020.2 EAP, Build #WS-202.4357.21, built on May 26, 2020
Plugin version: 2.4.0
Steps to Reproduce / Link to Repo with Reproduction and Instructions
I use graphql-modules on the server, and in my web app I have a .tsx file with this query
gql`
    query($id: ID!) {
      product(id: $ID) {
        id
      }
    }
  `

On the server, the schema looks like this:
export const ProductModule = new GraphQLModule({
  imports: [
    AuthModule,
  ],

  typeDefs: gql`
    scalar DateTime

    input ProductInput {
      ...
    }

    "Alias: Item"
    type Product {
      id: ID!
      "Alias: title"
      name: String!
      ...
    }

    type Query {
      "Find product by id"
      product(id: ID!): Product
      ...
    }

I can work on a reproduction repo upon request.

Hi Dan,
Thanks for using the plugin.
Using the SDL you've shown I don't get an error. Please add a reproduction.
Thanks.

@jimkyndemeyer Hi!
Thanks for the plugin!
I also had this error after upgrading to version 2.5.0. All my queries became invalid, and all had this error The parent selection or operation does not resolve to a valid schema type.
I downgraded to version 2.4.0 and everything works fine

@davoam hello! I'm trying to reproduce this one, could you please provide a minimal reproducible example? Or if it's not possible, provide any information as described in this comment https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/issues/348#issuecomment-680949314?

@vepanimas I read your comment and solved the problem. Thanks!
I have a script which generates GraphQL schema. When I run it, it uses some files to generate final schema. It complained that some instances are defined in final schema and in these files. For example, SomeInput was defined in final schema file and in these files which I use to generate final schema.
input SomeInput {
        someNumber: Int!
        someString: String!
    }

I have added files which I use to generate final schema to excludes section of plugin config file (.graphqlconfig).
Now everything works

@davoam thank you for the info, that's very helpful! I'm working now on improving the user experience for the case when some types/fields are duplicated. It definitely shouldn't break such features as resolve and autocomplete, and the errors should be more meaningful.

@dandv it should work better with graphql-modules in the 2.6.0 version, so I'm closing this now. If you encounter any problems, please feel free to report them, it will be very appreciated!


Allow Script to run at AWS Org level

Run Cloud Benchmark script at AWS Org Level (and other cloud equivalents) to more easily obtain numbers.

I like this idea! We'll definitely take a look at this to see how it can be accomplished. For AWS, this should be pretty simple since AWS Organizations creates a role in all child accounts (by the default name OrganizationAccountAccessRole).

AWS Org update should be done with #17

Right, this is issue can now be closed.


doc(README): remove grammertical mistakes

Description:
This Pull Request fixes a typographical error in the README.md file.
Changes Made:
Grammatical changes
Additional Information:
This fix is not related to any existing issue. It's a minor typo that I noticed while reviewing the README.
Thank you for considering this contribution.

You added a typo in your typo fix. :)
Plus it's ok to use 'that' the way the author has done so. It might even be more common.


Enhancement: initialise git for the generated project

Thanks for an excellent tool.
Is there any appetite to extend what is generated to give a head-start for git within the generated project?
e.g.

generate a basic .gitignore
generate a stub for README.md (and maybe an empty LICENCE.txt)
if we find a runnable git

git init in the generated project directory
an initial git commit of the generated files

If you think this would add value, I'm happy to put together a PR.

That sounds useful! It would need to have a checkbox in the GUI and a command line option to match. I'd just have one checkbox that does all of the above.

Super, I'll put something together

@JamesH65 could you have a look at the PR when you get time? thanks


refactor(player): More files

Changes

Simplified functions
Moved MPVLib observer functions to its own file
Moved most player control binding functions to the PlayerControlsView.kt file
Made every icon and text on the player slightly smaller
Moved most UI handling functions into the refreshUI() function
Fixed sheet peek size
Separated Screenshot Sheet to have parity with the manga reader
Refactored and removed String keys

Bruh-oriented programming better, that's why I set it as that
As for the anime... Anyone new looking at the code will just think that whoever made it was horny..... So it's perfect


postgresql16Packages.pgrouting: 3.6.1 -> 3.6.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/pgRouting/pgrouting/releases.
meta.description for postgresql16Packages.pgrouting is: A PostgreSQL/PostGIS extension that provides geospatial routing functionality
meta.homepage for postgresql16Packages.pgrouting is: https://pgrouting.org/
meta.changelog for postgresql16Packages.pgrouting is: https://github.com/pgRouting/pgrouting/releases/tag/v3.6.2
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.6.2 with grep in /nix/store/blywc62z2vngnnfsjzn2hg4qyjnms571-pgrouting-3.6.2
found 3.6.2 in filename of file in /nix/store/blywc62z2vngnnfsjzn2hg4qyjnms571-pgrouting-3.6.2

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath
postgresql12JitPackages.pgrouting
postgresql12Packages.pgrouting
postgresql13JitPackages.pgrouting
postgresql13Packages.pgrouting
postgresql14JitPackages.pgrouting
postgresql14Packages.pgrouting
postgresql15JitPackages.pgrouting
postgresql15Packages.pgrouting
postgresql16JitPackages.pgrouting
postgresql16Packages.pgrouting
postgresqlJitPackages.pgrouting
postgresqlPackages.pgrouting

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/blywc62z2vngnnfsjzn2hg4qyjnms571-pgrouting-3.6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A postgresql16Packages.pgrouting https://github.com/r-ryantm/nixpkgs/archive/d6279ec23b75ea116edd237161be7919af5126ed.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d6279ec23b75ea116edd237161be7919af5126ed#postgresql16Packages.pgrouting

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/blywc62z2vngnnfsjzn2hg4qyjnms571-pgrouting-3.6.2
ls -la /nix/store/blywc62z2vngnnfsjzn2hg4qyjnms571-pgrouting-3.6.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

10 packages built:

postgresql12JitPackages.pgrouting
postgresql12Packages.pgrouting
postgresql13JitPackages.pgrouting
postgresql13Packages.pgrouting
postgresql14JitPackages.pgrouting
postgresql14Packages.pgrouting
postgresql15JitPackages.pgrouting
postgresql15Packages.pgrouting
postgresql16JitPackages.pgrouting
postgresql16Packages.pgrouting

Maintainer pings
cc @imincik @nh2 @nialov @sikmir @willcohen @steve-chavez for testing.

Duplicate to #300347 .


⚠ Jenkins Plugins Artifactory has degraded performance

In 7e48a62, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 9ee102a after 12 minutes.


Update code owners for ADT

Priyanka has moved teams and need not be pestered with our PRs. :)

/check-enforcer override


Update CONTRIBUTING.md

CONTRIBUTING.md needs to be updated to include more info about gVisor project contributing
guidelines, governance etc.

Hey @ianlewis, I would like to contribute for the same!


An extra action 'Set Public Access Level...' shows for one premium blob container under Quick Access

Storage Explorer Version: 1.15.0-dev
Build: 20200812.2
Branch: master
Platform/OS: Windows 10/ CentOS 7.6.1810 (Core) / MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one premium storage account -> Blob containers.
Create a blob container -> Check its context menu.
Add the blob container to Quick Access -> Check its context menu under Quick Access.

Expect Experience:
No extra action 'Set Public Access Level...' shows.

Actual Experience:
An extra action 'Set Public Access Level...' shows.

More Info:
This issue also reproduces under one Name & Key attached premium storage account.

For Quick Access container nodes, since we don't store the skuTier information of its account, we always enable the action. For Name & Key attached storage accounts, we are not loading its skuTier which is a bug we can fix.

I just found that the Account level API for getting accountKind doesn't support using just account name and account key. Move to 1.16.0 to see if we can support it via the blob SDK.

Move to 1.17.0 since this is not feasible with the current SDK.

I added attributes for such containers nodes to get skuTier and accountKind for them. Key attached storage accounts should be able to show/hide this action properly now.


[ISSUE #3751] docs: Fix typos and other little error in the document 'Configuration_Client.md'

Make sure set the target branch to develop
What is the purpose of the change
For issue #3751
Brief changelog
Fix typos and other little error in the document 'Configuration_Client.md'.

Coverage decreased (-0.02%) to 53.18% when pulling b3a61953333b5a65c7ee1d945a522af3adf17394 on XiaoyiPeng:docs_configuration_client into 0b612ff813051cb3d4272bbd50ed280cbe4da244 on apache:develop.

Codecov Report

Merging #3752 (b3a6195) into develop (0b612ff) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3752      +/-   ##
=============================================
- Coverage      47.22%   47.21%   -0.01%
+ Complexity      5034     5030       -4
=============================================
  Files            628      628
  Lines          41406    41406
  Branches        5379     5379
=============================================
- Hits           19553    19551       -2
- Misses         19425    19429       +4
+ Partials        2428     2426       -2

Impacted Files
Coverage Δ

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
39.47% <0.00%> (-2.29%)
:arrow_down:

...rocketmq/client/impl/factory/MQClientInstance.java
51.30% <0.00%> (-2.00%)
:arrow_down:

...mq/client/impl/consumer/RebalanceLitePullImpl.java
48.52% <0.00%> (-1.48%)
:arrow_down:

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
41.40% <0.00%> (-0.79%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
43.68% <0.00%> (-0.73%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
29.31% <0.00%> (-0.66%)
:arrow_down:

...ocketmq/client/consumer/DefaultMQPushConsumer.java
55.94% <0.00%> (-0.50%)
:arrow_down:

...pl/consumer/ConsumeMessageConcurrentlyService.java
47.57% <0.00%> (-0.49%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
60.55% <0.00%> (-0.46%)
:arrow_down:

...main/java/org/apache/rocketmq/store/CommitLog.java
74.40% <0.00%> (-0.12%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b612ff...b3a6195. Read the comment docs.