[go_router] two Navigator.pop() calls drops the whole navigation stack inside StatefulShellRoute

Steps to reproduce

Create a shell route.
Go to a shell branch, push a detail screen with context.push().
Show a modal bottomSheet (without any GoRoutes), then show a modal dialog (again, without a GoRouter).
Try to remove both with two Navigator.pop() calls in a modal dialog callback.

Expected results
Before introducing StatefulShellBranch, it worked as expected, both modals were closed
Actual results
It puts an app into the inconsistent state with a black screen, when no pages are in the navigation stack.
Code sample
Code sample
      StatefulShellBranch(
          routes: [
            GoRoute(
              path: '/wallet',
              name: RouteNames.wallet,
              builder: (context, state) => WalletScreen(),
              routes: [
                GoRoute(
                  path: 'exchange-coins-requests',
                  name: RouteNames.exchangeCoinsRequests,
                  redirect: loginRedirect,
                  pageBuilder: (context, state) => CupertinoPage(
                    child: ExchangeCoinsRequestsScreen(),
                  ),
                ),
           ]),

Screenshots or Video

Screenshots / Video demonstration
ExchangeCoinsRequestTile
onTap:

ExchangeActionsBottomSheet
onTap:

RequestRejectModal:

Bug Demo:
https://github.com/flutter/flutter/assets/12999702/61b034f8-f15c-4cd1-8205-9043a39e9482

Logs
Logs
E/flutter ( 7075): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'package:go_router/src/delegate.dart': Failed assertion: line 116 pos 7: 'currentConfiguration.isNotEmpty': You have popped the last page off of the stack, there are no pages left to show
E/flutter ( 7075): #0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
E/flutter ( 7075): #1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
E/flutter ( 7075): #2      GoRouterDelegate._debugAssertMatchListNotEmpty (package:go_router/src/delegate.dart:116:7)
E/flutter ( 7075): #3      GoRouterDelegate._completeRouteMatch.<anonymous closure> (package:go_router/src/delegate.dart:156:7)
E/flutter ( 7075): #4      GoRouterDelegate._completeRouteMatch (package:go_router/src/delegate.dart:158:6)
E/flutter ( 7075): #5      GoRouterDelegate._handlePopPageWithRouteMatch (package:go_router/src/delegate.dart:132:7)
E/flutter ( 7075): #6      _CustomNavigatorState._handlePopPage (package:go_router/src/builder.dart:408:42)
E/flutter ( 7075): #7      NavigatorState.pop (package:flutter/src/widgets/navigator.dart:5245:28)
E/flutter ( 7075): #8      Navigator.pop (package:flutter/src/widgets/navigator.dart:2569:27)
E/flutter ( 7075): #9      RejectRequestModal.build.<anonymous closure> (package:goldy/features/wallet/widgets/exchange_coins_requests/bottomsheets/exchange_actions_bottom_sheet.dart:280:19)
E/flutter ( 7075): #10     ModalCardDialog.build.<anonymous closure> (package:mts_granat/src/widgets/modal_card_dialog.dart:103:53)
E/flutter ( 7075): #11     _InkResponseState.handleTap (package:flutter/src/material/ink_well.dart:1183:21)
E/flutter ( 7075): #12     GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24)

Flutter Doctor output
Doctor output
Flutter (Channel stable, 3.16.2, on macOS 13.0.1 22A400 darwin-arm64, locale ru-RU)
    • Flutter version 3.16.2 on channel stable at /Users/svmolchan1/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (9 weeks ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/svmolchan1/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (3 available)
    • M2101K9AG (mobile) • cc706425 • android-arm64  • Android 13 (API 33)
    • macOS (desktop)    • macos    • darwin-arm64   • macOS 13.0.1 22A400 darwin-arm64
    • Chrome (web)       • chrome   • web-javascript • Google Chrome 116.0.5845.96

[✓] Network resources
    • All expected network resources are available.

Hi @subzero911
Please provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code so that we may verify this. Thanks!

I can provide it after vacation (after next Wednesday).
I currently found a following workaround:
Navigator.pop(context); // close the modal dialog
context.pop(); // close the bottom sheet

For some reason, a bottom sheet should be closed via context.pop, despite it's not a GoRoute.
Maybe because a bottom sheet is inside the inner navigator, go_router considers it as its route? O_o
If it has been closed by Navigator.pop, we have a black screen crash.
If I'm doing
context.pop();
context.pop();

then bottom sheet (behind the modal dialog) is closed, then the details screen is closed, while the dialog remains untouched.

@huycozy
Here you are! I created a minimal example.
https://github.com/subzero911/gorouter_branch_bug

Thanks for the update. But I see your second pop call using a wrong context. It should use showModalBottomSheet's builder context instead. Let's try below updated sample code and confirm if it works for your case:

Sample code (only main.dart in your repository above)
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
import 'package:gorouter_branch_bug/routes.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      title: 'Go Router Branch Bug',
      routerConfig: router,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.amber),
        useMaterial3: true,
      ),
    );
  }
}

class HomePage extends StatefulWidget {
  const HomePage({super.key, required this.title});

  final String title;

  @override
  State<HomePage> createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          children: [
            ElevatedButton(
              child: const Text('show bottomsheet'),
              onPressed: () {
                showModalBottomSheet(
                    context: context,
                    builder: (ct) {
                      return Padding(
                        padding: const EdgeInsets.all(20.0),
                        child: Column(
                          crossAxisAlignment: CrossAxisAlignment.stretch,
                          children: [
                            const Text('BottomSheet'),
                            const SizedBox(height: 32),
                            ElevatedButton(
                              child: const Text('show modal dialog'),
                              onPressed: () {
                                showDialog(
                                    context: context,
                                    builder: (context) {
                                      return SimpleDialog(
                                        title: const Text('dialog'),
                                        children: [
                                          ElevatedButton(
                                            onPressed: () {
                                              // I wanted to close both this dialog and bottomsheet...
                                              Navigator.pop(context);
                                              Navigator.pop(ct); // CRASH!
                                            },
                                            child: const Text('close dialog'),
                                          ),
                                        ],
                                      );
                                    });
                              },
                            ),
                            const SizedBox(height: 32),
                            ElevatedButton(
                                child: const Text('close bottomsheet'),
                                onPressed: () {
                                  context.pop();
                                }),
                          ],
                        ),
                      );
                    });
              },
            ),
          ],
        ),
      ),
    );
  }
}

Yes, this config worked properly:

But this one still working incorrect:

Here I just dropped both the bottomSheet builder context and the Dialog builder context, and used a parental HomePage context.
Expected behaviour: a dialog popped, than a bottomsheet popped.
Actual behaviour: Navigator.pop(context) skipped the modal dialog and closed the bottomsheet, then a HomePage, and it crashed.
Also, I tried this config:

I opened the dialog using the bottom sheet context.
Now a Navigator.pop(context); call tries to close the root HomePage right away, and it leads to crash
Also, I believe you should think about a more meaningful error message:

Something like You used the wrong context and accidentally popped the topmost page from the StatefulBranch.

Thanks for checking it. I can reproduce that case as well. Whereas, the issue doesn't appear without using go_router (run an example with a single HomePage class).

Complete error stack trace
Launching lib/main.dart on Chrome in debug mode...
This app is linked to the debug service: ws://<IP_ADDRESS>:61534/9Jt4cyWZjpQ=/ws
Debug service listening on ws://<IP_ADDRESS>:61534/9Jt4cyWZjpQ=/ws
Connecting to VM Service at ws://<IP_ADDRESS>:61534/9Jt4cyWZjpQ=/ws
══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
The following assertion was thrown while handling a gesture:
Assertion failed:
file:///Users/huynq/.pub-cache/hosted/pub.dev/go_router-13.2.0/lib/src/delegate.dart:116:7
currentConfiguration.isNotEmpty
"You have popped the last page off of the stack, there are no pages left to show"

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 294:3       throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3        assertFailed
packages/go_router/src/delegate.dart 116:28                                       [_debugAssertMatchListNotEmpty]
packages/go_router/src/delegate.dart 156:7                                        <fn>
packages/go_router/src/delegate.dart 157:14                                       [_completeRouteMatch]
packages/go_router/src/delegate.dart 132:7                                        [_handlePopPageWithRouteMatch]
packages/go_router/src/builder.dart 409:42                                        [_handlePopPage]
packages/flutter/src/widgets/navigator.dart 5284:18                               pop
packages/flutter/src/widgets/navigator.dart 2573:25                               pop
packages/gorouter_branch_bug/main.dart 71:57                                      <fn>
packages/flutter/src/material/ink_well.dart 1171:21                               handleTap
packages/flutter/src/gestures/recognizer.dart 315:24                              invokeCallback
packages/flutter/src/gestures/tap.dart 652:11                                     handleTapUp
packages/flutter/src/gestures/tap.dart 309:5                                      [_checkUp]
packages/flutter/src/gestures/tap.dart 242:7                                      handlePrimaryPointer
packages/flutter/src/gestures/recognizer.dart 670:9                               handleEvent
packages/flutter/src/gestures/pointer_router.dart 98:7                            [_dispatch]
packages/flutter/src/gestures/pointer_router.dart 143:9                           <fn>
dart-sdk/lib/_internal/js_dev_runtime/private/linked_hash_map.dart 21:7           forEach
packages/flutter/src/gestures/pointer_router.dart 141:17                          [_dispatchEventToRoutes]
packages/flutter/src/gestures/pointer_router.dart 127:7                           route
packages/flutter/src/gestures/binding.dart 495:5                                  handleEvent
packages/flutter/src/gestures/binding.dart 475:14                                 dispatchEvent
packages/flutter/src/rendering/binding.dart 425:11                                dispatchEvent
packages/flutter/src/gestures/binding.dart 420:7                                  [_handlePointerEventImmediately]
packages/flutter/src/gestures/binding.dart 383:5                                  handlePointerEvent
packages/flutter/src/gestures/binding.dart 330:7                                  [_flushPointerEventQueue]
packages/flutter/src/gestures/binding.dart 299:9                                  [_handlePointerDataPacket]
lib/_engine/engine/platform_dispatcher.dart 1418:5                                invoke1
lib/_engine/engine/platform_dispatcher.dart 332:5                                 invokeOnPointerDataPacket
lib/_engine/engine/pointer_binding.dart 398:30                                    [_sendToFramework]
lib/_engine/engine/pointer_binding.dart 224:7                                     onPointerData
lib/_engine/engine/pointer_binding.dart 1001:20                                   <fn>
lib/_engine/engine/pointer_binding.dart 930:7                                     <fn>
lib/_engine/engine/pointer_binding.dart 531:9                                     loggedHandler
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 426:37  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 431:39  dcall

Handler: "onTap"
Recognizer:
  TapGestureRecognizer#df3e0
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: Assertion failed: file:///Users/huynq/Documents/GitHub/flutter_master/packages/flutter/lib/src/widgets/navigator.dart:3882:12

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.1, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision abb292a07e (29 hours ago), 2024-02-20 14:35:05 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 121.0.6167.184

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.20.0-11.0.pre.106, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.20.0-11.0.pre.106 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 59da873ef0 (4 minutes ago), 2024-02-22 19:16:20 -0800
    • Engine revision 0f3ad23b84
    • Dart version 3.4.0 (build 3.4.0-167.0.dev)
    • DevTools version 2.33.0-dev.11
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 122.0.6261.57

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Oh you're using go_router v13. Downgrading to v12 fixed the issue 🤣

I have the same problem. The downgrade to v12 recommended by @myxzlpltk fixes this problem. But I wonder if this issue can be expected in newer version of go_router? Is there a solution or is the only solution currently not updating go_router?

any update on this?

go_router 14.2.0 still has this problem, it works fine when downgrading to 12.1.3

any update?

This is a major issue. I use statefulshellroute for my bottom navigation bar. navigating to a page from one of the shell branches and popping that page pops everything on the navigation stack.

Hi, I found a great solution to solve this issue
and it works pretty amazing for me !!
just instead of scaffold for your tab page wrap it with CustomScaffold:
import 'package:flutter/material.dart';

class CustomScaffold extends StatelessWidget {
  const CustomScaffold({
    super.key,
    required this.body,
  });
  final Widget body;

  @override
  Widget build(BuildContext context) {
    return PopScope(
      canPop: false,
      onPopInvoked: (didPop) {
        if (Navigator.of(context, rootNavigator: true).canPop()) {
          Navigator.of(context, rootNavigator: true).pop();
        } else {
          Navigator.pop(context);
        }
      },
      child: Scaffold(body: body),
    );
  }
}


$ref to local definition not working

Given the following reference:
(...)
"children": {
    "type": "array",
    "items": {
        "type": "object",
        "oneOf": [
            { "$ref": "#/definitions/Node" }
        ]
    }
}
(...)

The validator fails with:
Fragment "/definitions/Node" not found in file:///path/to/current/location#/definitions/Node

Expected: The validator looks for the definition of Node inside the same schema file, under the property "definitions".

:+1:


Retrieve more info with Get-AuthenticodeSignature

PR Summary
Adds the Signatures property to the Signature output object of
Get-AuthenticodeSignature and Set-AuthenticodeSignature. This new object
is an array of signature detail objects that contains the signing and
digest algorithm as well as the timestamp information of the signature.
It does this for all the entries in the authenticode block and not just
the first entry
PR Context
I was trying to get this information to test out the changes in https://github.com/PowerShell/PowerShell/pull/17560 and found the Get-AuthenticodeSignature was lacking some of the data needed. This hopefully expands the functionality of the cmdlet and expose more data that might be useful for others.
Still need to finalise the tests and fix up a few things before I can mark this as ready.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Reopen PR to re-trigger the CI runs.

I'd prefer to have https://github.com/dotnet/runtime/issues/34042 :-)

An issue from nearly 3 years ago with no progress + a somewhat vague request. Is that asking for cross platform support, more implementations in dotnet or something else? If this isn't wanted in PowerShell it would be great if I could put it in https://www.nuget.org/packages/Microsoft.Security.Extensions but it doesn't appear to be open source or available for contributors. Ultimately I'm hoping to add more information for Get-AuthenticodeSignature which includes the various signature details rather than just a general overview of the trust.

@jborean93 A lot of code exists in PowerShell only because these features are missing from the .Net Runtime and Libraries. We have already removed a lot of code as .Net went from version 1 to 7. This is the preferred path. There is not much point in repackaging the code - only the risk of regression. It is more valuable to spend this effort to extend .Net.

The bulk of the code is very PowerShell specific. It's adding extra info the the return object of Get-AuthenticodeSignature or Set-AuthenticodeSignature. The only real code that is generic enough to potentially go in dotnet are the PInvoke defs that retrieve the signature byte array which yes it might be nice in dotnet but I honestly am not prepared to learn the whole development process there.
If the changes here aren't wanted in PowerShell that's fair enough, I won't add any more efforts in moving it to a ready state.


Adds documentation for sphinx

This PR adds the following to documentation:

[x] Makefile documentation for building HPX application and components
[x] Installation scripts and commands to make it easier for the user to install HPX (The current version is already well written, I will add a bit more to make it even clearer)

I would discourage the use of makefile for building HPX applications since pkg-config and cmake system templates generate appropriate flags.
Edit
I found the current documentation nicely written. There's a separate fedora section that makes it easier to install hpx on fedora. I've added arch to the list so as to provide installation guide for most Linux distros

@NK-Nikunj just checking: did you possibly already do the changes and forget to push them?

@msimberg , sorry I was a bit busy last week. I'll push the changes tonight.


TripAdvisor icon request

Describe the requested icon(s)

Useful for restaurant websites, linktree-like pages of various businesses.
References

Their website: https://www.tripadvisor.com/
Icon that can be used as a reference: https://www.flaticon.com/free-icon/tripadvisor_732153

Additional context

I know there was already opened issue (https://github.com/phosphor-icons/homepage/issues/519), but it didn't include a description, so I went ahead and opened a new one.

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

+1


Feature/common UI

Prerequisite

[x] Self-review :monocle_face:
[x] No Crashes ☠

Root cause

Add CommonUI

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


Text gets cut off after the "<" sign

Describe the bug
I have a specific text. I type it in, save to the database in HTML. When I load this HTML into the SunEditor, the SunEditor cuts off everything after the "<" sign. This happened several types, every time after the "<" sign.
To Reproduce
Steps to reproduce the behavior:

Paste as HTML:

Let $\Omega$ be the underlying randomness space. In this case, the variables $X^-$ and $X^+$ collapse to $U$.  In this case, the variables $X^-$ and $X^+$ collapse to $U$. To see why, pick an arbitrary $\omega \in \Omega$:

\begin{align*}X^-(\Omega) = \sup\left\{y\in [0,1]: F(y)

Expected behavior
Most of the times HTML is loaded exactly as it is from the database and SunEditor makes no changes to the text.
Desktop (please complete the following information):

OS: Linux
Browser: Firefox
Version: latest

The 2.42.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Improve Header and Metadata of OWL dumps

The header and metadata of the OWL dumps could be improved.
Here a current header example:
<rdf:RDF xmlns="http://purl.obolibrary.org/obo/chebi.owl#"
     xml:base="http://purl.obolibrary.org/obo/chebi.owl"
     xmlns:chebi1="http://purl.obolibrary.org/obo/chebi#3"
     xmlns:chebi2="http://purl.obolibrary.org/obo/chebi#"
     xmlns:chebi3="http://purl.obolibrary.org/obo/chebi#1"
     xmlns:chebi="http://purl.obolibrary.org/obo/chebi#2"
     xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
     xmlns:owl="http://www.w3.org/2002/07/owl#"
     xmlns:oboInOwl="http://www.geneontology.org/formats/oboInOwl#"
     xmlns:xml="http://www.w3.org/XML/1998/namespace"
     xmlns:xsd="http://www.w3.org/2001/XMLSchema#"
     xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#"
     xmlns:obo="http://purl.obolibrary.org/obo/">
    <owl:Ontology rdf:about="http://purl.obolibrary.org/obo/chebi.owl">
        <owl:versionIRI rdf:resource="http://purl.obolibrary.org/obo/chebi/225/chebi.owl"/>
        <rdfs:comment rdf:datatype="http://www.w3.org/2001/XMLSchema#string">ChEBI subsumes and replaces the Chemical Ontology first</rdfs:comment>
        <rdfs:comment rdf:datatype="http://www.w3.org/2001/XMLSchema#string">Author: ChEBI curation team</rdfs:comment>
        <rdfs:comment rdf:datatype="http://www.w3.org/2001/XMLSchema#string">developed by Michael Ashburner & Pankaj Jaiswal.</rdfs:comment>
        <rdfs:comment rdf:datatype="http://www.w3.org/2001/XMLSchema#string">ChEBI Release version 225</rdfs:comment>
        <oboInOwl:saved-by rdf:datatype="http://www.w3.org/2001/XMLSchema#string">chebi</oboInOwl:saved-by>
        <oboInOwl:date rdf:datatype="http://www.w3.org/2001/XMLSchema#string">27:08:2023 19:12</oboInOwl:date>
        <oboInOwl:hasOBOFormatVersion rdf:datatype="http://www.w3.org/2001/XMLSchema#string">1.2</oboInOwl:hasOBOFormatVersion>
        <oboInOwl:default-namespace rdf:datatype="http://www.w3.org/2001/XMLSchema#string">chebi_ontology</oboInOwl:default-namespace>
        <rdfs:comment rdf:datatype="http://www.w3.org/2001/XMLSchema#string">For any queries contact chebi-help@ebi.ac.uk</rdfs:comment>
    </owl:Ontology>

Some thoughts what could be improved:

cleanup namespaces

let prefix chebi refere to namespace http://purl.obolibrary.org/obo/chebi#
remove some unnecessary namespaces (chebi1, chebi2, chebi3, chebi4, xml, xsd), as they will survive further processing and will then be used for e.g. http://purl.obolibrary.org/obo/chebi#3_STAR

owl:versionIRI should incorporate LITE / CORE / FULL
owl:versionInfo, dcterms:creator, schema:email/foaf:mbox should be used instead of rdfs:comment (see Metadata usage in WIDOCO)
add dc:license for license information
maybe add schema:discussionUrl

Thanks @jmkeil!
Additionally:

Don't split sentences across different rdfs:comment statements, these are not ordered (I am guessing no one has looked at the header in ~20 years, there are probably better ways to credit the original work by Michael and @jaiswalp)

I would offer different advice from @jmkeil though, CHEBI should be consistent with OBO Metadata standards and OMO (https://obofoundry.org/ontology/omo)

I think versionIRI should be kept as is. But if CHEBI were to make different subsets for LITE/CORE these would have their own URIs and would be versioned with distinct IRIs
use dcterms:contributor over dcterms:creator, using orcid https URIs (but if there is not an attempt to populate this consistently it should be left out)
use dcterms:license (I am surprised there is not an open issue about this already, cc @matentzn)

@jmkeil you may want to petition OMO to include schema:discussionUrl or schema:email, see https://github.com/information-artifact-ontology/ontology-metadata/issues

Hi all, many points of the above are already resolved in our current development for ChEBI 2.0 here.

We let only one chebi prefix along all the ontology: prefix http://purl.obolibrary.org/obo/chebi/ (not #)
The extra namespaces chebi1, chebi2, chebi3, chebi4 have been quite difficult to delete, we are using robot to generate the ontology right now (which is a process completely different than before, in the past was used an OBO file and robot just converted it to OWL) and, we suspect that because the resource starts with a number (i.e. 1_STAR, 2_STAR, 3_STAR) robot does not understand and the generated owl file has those extra namespaces.
RDF comments were unified.
As mentioned @cmungall, versionIRI keeps it as it is.
dcterms:license was added and dcterms:creator as well. But for sure, we are going to check if it is possible to use dcterms:contributor.
We are using a number to tag a version, but I realise that it is better to use the current date in the IRI, we re-check this as well.
Other thing like xmls types and foaf:homepage was added

@cmungall we are planning to have LITE and CORE variants as well, as you can see on the FTP link, so yes, we would need to generate other ontology iris, I guess we would need to include in the PURL repository??
Last but not least, @jmkeil you can start to play with the new ontology, just taking into account it is in the development phase yet and it is not official.

Hi all, many points of the above are already resolved in our current development for ChEBI 2.0 here.

Awesome!

we suspect that because the resource starts with a number (i.e. 1_STAR, 2_STAR, 3_STAR)

Why not make new PURLs for your subsets?

We are using a number to tag a version, but I realise that it is even better to use the release' current date in the IRI, we'll re-check this as well.

It's more conventional in OBO to use ISO-8601-based versionIRIs (please don't invent a different way!) but bear in mind that you'll need to support the old versionIRIs and you can't retroactively give date based versionIRIs for these.
https://obofoundry.org/principles/fp-004-versioning.html

we are planning to have LITE and CORE variants as well, as you can see on the FTP link, so yes, we would need to generate other ontology iris, I guess we would need to include in the PURL repository??

You can list different products in your OBO metadata entry. Each product has its own PURL. See for example CL https://obofoundry.org/ontology/cl which has a common pattern of providing the full ontology plus basic

Sorry for the delay.

I would offer different advice from @jmkeil though, CHEBI should be consistent with OBO Metadata standards and OMO (https://obofoundry.org/ontology/omo)

Agree. It should adhere to the community's standards.

many points of the above are already resolved in our current development for ChEBI 2.0 here.

Great.
Are there planes to switch to HTTP instead of FTP for the ontology download? Using HTTP transport encoding for transparent compression (i.e. requesting chebi.owl, but only transferring chebi.owl.gz) would be a real relief.

I just want to note that changing some of the header may mean changing some of the IRI's of concepts used in ChEBI owl today. This would be a breaking change for a number of tools, and as such I encourage the ChEBI team to announce these changes well ahead of time. e.g. a SPARQL query or a parser expecting chebi#is_conjugate_base_of would need to be rewritten to chebi/is_conjugate_base_of


setup-java should search in /usr/lib/jvm as well as the tool cache

Given that the JDKs are not installed into the hosted toolcache, the current code searching for a JDK on a GitHub hosted runner will always be a "cache miss" the first time:
https://github.com/actions/setup-java/blob/5c87b70ffefc9ca2e77153b3528c6b7bc85a84a9/src/installer.ts#L35
At the recommendation of one of the virtual-environments maintainers, I'm raising the issue here.

Adding a check to see if the desired version is pre-installed could make sense,a nd may reduce traffic for many common cases (latest 8, 11, 13) for several weeks at a time. But it's important to keep in mind that java packages get updated quite frequently,  and potentially more frequently than the OS images do, and that in the days or weeks immediately following a Java quarterly update, the OS-image-pre-installed java update versions is unlikely to match what e.g. "11", "8.0.x", "13", or "14" mean in semver terms: E.g. 7.0.262, 8.0.252, 11.0.7, 13.0.3, and 14.0.1 all came out on April 14, 2020, and they will all rev again on July 14 at the latest...
We could try to separate the specific version determination from the download of the determined bits. E.g. once the desired version has been determined (by scanning the CDN for semver-matching things and choosing one), we could see if the exact same package we want is already in /usr/ib/jvm, and skip the download if it is... This would certainly help reduce download bandwidth if the OS images get updated with versions from the same CDN in a timely manner (but will also likely leave traffic spikes in the days that follow each quarterly update, until the OS image catches up). It also has the downside of not address older versions (many tests like to nail down a specific update version top test against) and rapidly changing versions (e.g. the EA builds that rev as often as once a week).
An alternative (and more time-robust approach IMO) is to look to incorporate actions/cache in some way. This would create much more consistent caching (which would work even in the days following a quarterly update, and even for rapidly changing packages like the current 15-ea packages), and would likely reduce the download traffic loads during peak times (right after updates) better than an attempt to sync up the contents of the OS images would. It would be great if action/cache was directly leverageable from other actions in some way. But until it is, perhaps we can do a subtree trick like e.g. https://github.com/lukka/run-vcpkg does?

Hello everyone. We moved our precached java versions to /opt/hostedtoolcache/Java_Adopt_jdk directory on hosted runners. Recently we released setup-java@v2 and new task version will be able to consume pre-installed java version. You can see migration guide from v1 to v2 here. If you have any concerns feel free to reopen the issue.


SRGR Create by UserGroup endpoint doesnt work

The endpoint  /api/userGroups/${userGroupId}/securableResourceGroupRoles does not work as intended, currently throws an exception
{
    "status": 400,
    "reason": "Bad Request",
    "errorCode": "SRGRS01",
    "message": "SecurableResourceGroupRole retrieval for securable resource [UserGroup] with no supporting service",
    "path": "/api/userGroups/07cc0e4f-c356-4e9a-ae32-509fbcd1915f/securableResourceGroupRoles",
    "environment": "DEVELOPMENT",
    "version": "5.1.0-SNAPSHOT"
}

there are currentlt NO FTs or E2Es for SRGRs. The PR for this issue MUST include at least the E2E UserAccessFunctionalSpec extended tests


I know when there are no results for my filter combination

So that I know that the empty page is because nothing matched my filter request, rather than thinking it's a bug, I should see a message telling me that
Acceptance Criteria
Given that I'm an 18F employee
And there are no team members who have CHI as their location, and have listed Javascript as a skill
When I filter for team members in the Chicago Office (CHI) who are skilled in Javascript
I should see a message telling me that there are no matches to my request

@andrewmaier can you take a look at this? The pull request is failing tests. If you don't have time, let me know and we can reassign

Don't have time :(


Sticky Scroll support for flutter

I would like to request sticky scroll support for flutter. I noticed that sticky scroll responds to { and } to determine scope.
What would it take for it to support things like ClassInstance(?

See https://github.com/microsoft/vscode/issues/157891#issuecomment-1211970075

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


Request to make dropping ticks optional

https://github.com/cloudfoundry/clock/blob/02e53af36e6c978af692887ed449b74026d76fec/fakeclock/fake_timer.go#L79-L81
Can we make this behavior optional (configurable)? sometimes in tests, we want to make sure a receiver consumes certain number of ticks before we proceed. However with the possibility that tick may be dropped, we have no control of that, and have to introduce real time intervals between incrementing fake block, so that a slow receiver will eventually consumes that many ticks.

Hi @guoger. Sorry for the late response. Can you please provide an example of the behavior you expect to see if it is no longer possible to skip sending on ft.channel? Would this behavior now be blocking until another goroutine reads from ft.channel?

@n4wei yes, i'd expect it to be blocking, so we can know deterministically number of ticks consumed by the receiver. (obviously this should be optional so the original behavior is preserved for other lib users)
Another request we have is to be able to label the timer, so when we have multiple timers created, we can explicitly wait for a specific watcher in test. for example, say we have 2 timers T_a and T_b, and we want to wait for T_b to start before performing some assertions in test. Instead of WatiForNWatchers(2), we could WaitForWatcherWithLabel("T_b"). The benefit is two-fold:

this comes handy when T_a may or may not start, and we only care about T_b
when we introduce 3rd timer T_c, we don't need to change all existing test to be WaitForNWatchers(3)

let me know if these requests make sense. I'm happy to contribute as well.

@guoger I am a bit unclear about how you would use this in a test code. It sounds like you would have to create a fakeclock.NewTimer somewhere in your codebase. We haven't needed to use something like this in our test files yet. Assuming this was implemented, what would a test example look like that utilizes this that we can't already do with the current interface?

I guess I'm mixing two requests in this thread and caused some miscommunication. Let's focus on dropping ticks for now.
Suppose i have following code
ticker := clock.NewTicker(time.Second)
for {
  select {
    case <-ticker:
      // periodic job
    case <-taskChan:
      // some heavy task
  }
}

and following code in test
clock.Increment(time.Second)
clock.Increment(time.Second)
clock.Increment(time.Second)

I'd like to be sure that periodic job is executed exactly 3 times. Although, with the possibility that tick may be dropped, this number is not deterministic.
hope this helps @aminjam
as for the other request, i'll create another issue

In a scenario where we have a slow consumer e.g. some heavy task, couldn't you use the fake version of the heavy task, this way you would know how many times this timer.C() was called? This is because the heavy task causes the select to be blocked and even if the ticker was not dropping on the floor, you still wouldn't be able to catch it.
Though there is a small difference in timing, it seems like using a Timer, resetting it instead of a Ticker, and using clock.WaitForWatcherAndIncrement() in your tests sounds like it would achieve the behavior you want.

you still wouldn't be able to catch it.

not sure i understood this correctly... if it's block, i would be sure that all the ticks are consumed deterministically, no?
otherwise i'll have to put a little pulse (real time) between each increment, which theoretically still doesn't make test deterministic. As for the "heavy task", it's part of the target we are testing, i.e. sending out heartbeat every tick, and doing real job with taskChan.
IMHO, adding a toggle-able behavior to fake timer would be less invasive for most users, rather than converting all the ticker to timer.

@guoger could you please make a PR for this change in behavior? The old behavior where ticks can be dropped should be the default; and the new behavior where ticks are not dropped should be opt-in.

closing issue in favor of a PR, we will accept this change but it isn't a priority for us to implement ourselves at this time


How to run?

How do I run the project? I already installed everything necessary, I only failed in the last step, running the project

RESTART: C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\main.py
Traceback (most recent call last):
File "C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\main.py", line 3, in
from gui.main_window import MainWindow
File "C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\gui\main_window.py", line 5, in
from gui.device_list_frame import DeviceListFrame
File "C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\gui\device_list_frame.py", line 3, in
from gui.selected_device_frame import SelectedDeviceFrame
File "C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\gui\selected_device_frame.py", line 10, in
from bot_related.bot import Bot
File "C:\Users\fabri\OneDrive\Escritorio\Rise-of-Kingdoms-Bot-<IP_ADDRESS>721_beta\bot_related\bot.py", line 5, in
from Task import Task
ModuleNotFoundError: No module named 'Task'

A new problem appeared when trying to execute

It was able to execute successfully, my question is why it does not attack the barbarians? he manages to select the troops, but he does not send them.


Revendor hcsshim and go-winio for compute storage and vhd package changes

Revendor in go-winio at: d1ffc52c73318019ce58aaa5282588c52df029b7
Revendor in hcsshim at: 11f327c43c16594f9163254c6ccb247dfba35920
Signed-off-by: Daniel Canter<EMAIL_ADDRESS>

@anmaxvl @kevpar @ambarve @katiewasnothere

Should this just go to jterry75/cri? We don't build containerd from this repo.

That's true, I'll push the snapshotter changes here and then we can pull those into cri when they're merged. Getting confused here


Configurable styling through XML attributes and themes

Bring back the old XML-attribute/theme mechanisms for styling Atlas components.

Any idea on timeline for this?

there's a PR under review for it now: #41

#41 merged


Fix Accessing Async Resource Attributes Before Promise Resolution

Packages impacted by this PR
@azure/monitor-opentelemetry
Issues associated with this PR
Describe the problem that is addressed by this PR
Errors were being thrown from OpenTelemetry regarding accessing asynchronous attributes of the resource before the asyncAttributesPending flag was false.
Are there test cases added in this PR? (If not, why?)
Yes, in config.test.ts
Checklists

[x] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


BITCODE support

Building archive fails. Modification must be done to the project settings:
Carthage/Carthage#535

This is fixed in new version of Carthage (0.9.4).


[MBP] Sorting customs by most recent not working as intended on Web

:sob:

Fixed in https://github.com/RandomityGuy/MBHaxe/commit/1e5227b4fadb7414afb9ca52ceba9cebd3d97582


ci(ssh): revert using ssh-compute action & increase sshd connection limit

Motivation
We've been having multiple errors (more than before) after implementing ssh-compute
Solution

Revert the ssh-compute implementation
Stop using IAP for TCP forwarding as there are known limitations which might be counterproductive for our use cases
Keep using sudo in some docker commands as we might be connecting with a non-root user to the VMs
Set the MaxStartups setting in sshd to 500 to avoid a failing SSH connection causes GitHub Action to fail

Note: tj-actions/changed-files file comparison was failing in this PR and it has been failing in the main branch, so we're adding a fix here too as this would halt the PR from merging. Here's the actual explanation on this fix https://github.com/tj-actions/changed-files/issues/639#issuecomment-1256442729
Closes #5358
Closes #5365
Fixes #5362
Fixes #5361
Review
If CI passes, anyone can review this PR
Reviewer Checklist

[x] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[x] Are the PR labels correct?
[x] Does the code do what the ticket and PR says?
[x] How do you know it works? Does it have tests?

Tested I've tested this is working doing a manual SSH into the VM and confirming the file has changed with the actual configuration being used in the script file gcp-vm-startup-script.sh

Follow Up Work
We might also want to wait up to 90 seconds after a VM has been created, just so we're sure all configurations are complete.

Sorry for adding chore: fix tj-actions/changed-files file comparison to this PR. But it's annoying having an ❌ in this PR and this will be pulled to main, fixing it here is minimal.

CI is failing with a new (unrelated?) error 🥲
e2fsck: Cannot continue, aborting.
/dev/sdb is in use.

CI is failing with a new (unrelated?) error 🥲
e2fsck: Cannot continue, aborting.
/dev/sdb is in use.

We've changed two things related to the disk in this PR:

bullseye image, which worked in PR #5365: https://github.com/ZcashFoundation/zebra/actions/runs/3216898611/jobs/5263285350#step:11:103
moving the script to the image creation, which is new

Here are some things we could try:

checking the server logs
find out what is using the disk, by calling lsof when e2fsck or resize2fs fail
moving e2fsck and resize2fs to the startup script

Is there anything else we could try?

Is there anything else we could try?

Using ssh to adjust the sshd config, like PR #5365

That would only work if the instance startup script is causing the disk to be used.

@gustavovalverde I just realised that these disk resize commands are only needed when we change the disk size.
Specifically, they are only needed between:

when we merge the change to main, and
when we stop using cached states with the smaller size (after the new larger full sync image is generated, or we've created new updated cached states with resized disks).

So let's ignore the failure for now, and fix it if it becomes a problem after #5085 ?

So let's ignore the failure for now, and fix it if it becomes a problem after #5085 ?

If a re-run fixes the issue, we can ignore it for now. I'm anyways testing a PR here to handle this repartitioning: https://github.com/ZcashFoundation/zebra/pull/5371


fix-resolv-conf-search.service: run after NM

Fixes https://github.com/openshift/okd/issues/978
Ensure that resolv.conf search domain patching runs after NM has built a new resolv.conf. This should prevent coredns from picking up stub resolver

/override ci/prow/e2e-aws-upgrade
Disruption


feat: better support for offline buffering

When the MindSphere is offline it would be nice to have a support for bulk-upload of the buffered data.
Describe alternatives you've considered
An alternative is to create a separate flow which will handle the buffered data.
Additional context
This feature requires the MindSphere to support bulk upload for performance assets.

Question
Is the purpose of this feature just too improve the node's "bulk-upload" of the buffered data? (buffered with other node-red logic)
Or does it also include the buffering functionality within the node (when the node can't connect to mindsphere/is offline saves a certain amount of data) and then bulk upload the buffered data when connection is reestablished?

@EliasReuter buffering within the node. This can be solved already now with buffering in the flow using more sofisticated flow design.

@sn0wcat Great feature 💡
Do you have any example of this sophisticated buffering flow you mentioned?
Is there any estimated release date for this feature/version 3.9.0?
Thank you 👍

Hi. I've been trying to make my own buffering flow but I've not been successful. It would be very helpfull if you have any example of how you solved it so us to give it a try.  @sn0wcat
Thank you!

@rcarreir could you post what you were trying to do?

@rcarreir @EliasReuter  take a look at the new flows which can buffer the data if the node is under high pressure
https://playground.mindconnect.rocks/#flow/676a86e4.fe7888


Fix Basic Auth through SSL

Added a delegate function to allow basic http through SSL

LGTM. Thanks.


PMID:24322298 poly (A) polymerase  related

PMID:24322298
normal poly(U) polymerase/PUP activity
reduced poly(A) polymerase/PAP activity
decreased poly(U) RNA binding

abnormal poly(A) polymerase activity FYPO:0005098
decreased poly(A) polymerase activity FYPO:0005099
normal poly(U) polymerase activity FYPO:0005100
decreased poly(U) RNA binding FYPO:0005101

edit file: 0ced6bfa9217652be586f19ff66c40f7058eacc9
release: 494d8d1501aa70b5aa96f73b38d012267f3e8bf5


Friendly jenkins checks

Improve scripts to make jenkins error friendlier about licenses, signed-off-bys and whitespaces.
Scripts now write sentences and add a final note in case of error to explain how to solve the issues.
Once #1639 is merged, the life of new contributors will never be that easy.
Examples of new messages:

./checklicense.sh v0.7 63e0f2c gives:

checklicense v0.7 (68561eb8d91800ccb3fa289bff6721ddd11dbe25) .. 63e0f2c (63e0f2c7cd96f4c40366d92614785b1006e52367)
These files are missing their licence:

benchmarks/polygons/nit/bench_polygon.nit

Please double check that the licence text (i.e. `This file is part of NIT...`) is included at the begin of these files.

./checksignedoffby.sh origin/master 63e0f2c7cd96f4c40366d92614785b1006e52367 gives:

checksignedoffby origin/master (b144984d92908662f47a251f1cca1fd8e57b2594) .. 63e0f2c7cd96f4c40366d92614785b1006e52367 (63e0f2c7cd96f4c40366d92614785b1006e52367)

Bad or missing Signed-off-by for commit
63e0f2c lib/graphs: add module for directed graphs
Expected (from local git config):
Signed-off-by: Alexandre Blondin Massé<EMAIL_ADDRESS>Got:
Signed-off-by: Alexandre Blondin Massé<EMAIL_ADDRESS>
Please check that each commit contains a `Signed-off-by:` statement that matches the author's name and email.

Please check that each file in each commit does not contain whitespace errors.
Note that existing commits should be amended; pushing new commit is not sufficient.
Hint: use "git log --check" to see whitespace errors.

I should have shown full examples of error messages in the cover letter to help reviewers. So here the last one:
for ./checklicense.sh v0.7 63e0f2c, the output is:
These files are missing their licence:

benchmarks/polygons/nit/bench_polygon.nit

Please double check that `This file is part of NIT`... is included in the listed files.

reroll: improved spelling and message. Also updated the cover letter with examples of new messages

+1

:shipit:


Fix FastEmit kernel

This PR fixes the GPU implementation of the FastEmit gradient computation.
Specifically, the FastEmit gradient formula in the CUDA kernel has been modified based on the logit-based formula (See documents).
Also, when FastEmit is not enabled, the conventional gradient calculation kernel is used because there is a small difference in execution efficiency.
We have confirmed on a small test case (B=1, T=7, U=5, V=5) that the original FastEmit implementation has a gradient error of 0.1% compared to the CPU version, while our implementation reduces the gradient error to about 0.01-0.001%.
@yusshino helped to create this PR.

Thanks again!
If you're doing some experiments with FastEmit, feel free to report them in this PR or via Shinji's slack!


Create SMAPSoilMoisture.md

[Tutorial proposal] Introduction to SMAP #652

The tutorial is live!
https://developers.google.com/earth-engine/tutorials/community/smap-soil-moisture
Thank you for contributing this tutorial to help developers learn about the SMAP dataset and how to start working with it!
If you'd like to make changes to it in the future, you can sync your fork of the https://github.com/google/earthengine-community repository, edit the index.md file and submit a pull request.


Tests for /wallet

[ ] User can GET their own wallet
[ ] User cannot GET someone else's wallet if not authorized
[ ] If No wallet is found, an empty wallet is created for the user and 1000 dineros is added
[ ] Authorized user can GET wallet by username

Can I take this up?

Hi @ankushdharkar sorry about the delay.
About this issue, I was not able to find the API contract for the wallet, so what are the expected response/errors?
For the 3rd point, we by default create a wallet when adding a new user #285 , what exactly is the 3rd scenario to check if the new wallet is created for a new user with 1000 dinero?


Removes requirement to have Ignite attached to add a plugin

There's no compelling reason to error when you're not in an Ignited project. This removes that requirement. If plugins want to write to a non-existent Ignite config, it'll be created for them (as long as they use setIgniteConfig).
This also fixes an issue I'm having with Ignite CLI 3.1.0.

@ryanlntn I merged this, but I'd still like your thoughts.

:tada: This PR is included in version 3.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

I’m guessing the original intent behind that was to prevent accidentally adding plugins when in a subdirectory. What would happen if you try to add from a subdirectory of an ignite project now?

I'll check that, good question.


Add model for streaming events

I've been using something like this by overriding on_data in my application to handle favourite/RT/follow events, and it works fine there. I've tested this branch locally (manually), and added a very cursory case to the test suite.

Rebased, with support and a test for the quoted_tweet event added since I first submitted this PR.

Rebased again, nothing needed changing.

Time for the annual ceremonial rebase!

This PR is stale now, since it seems to be for User Streams, which have been deprecated and retired in favor of the new Account Activity API.
For Account Activity API support, see #1075.
Also see:
https://developer.twitter.com/en/docs/accounts-and-users/subscribe-account-activity/migration/us-ss-migration-guide.html
https://blog.twitter.com/developer/en_us/topics/tools/2018/enabling-all-developers-to-build-on-the-account-activity-api.html
https://blog.twitter.com/developer/en_us/topics/tools/2017/announcing-more-functionality-to-improve-customer-engagements-on-twitter.html
https://blog.twitter.com/developer/en_us/topics/tools/2017/building-the-future-of-the-twitter-api-platform.html
https://twittercommunity.com/t/details-and-what-to-expect-from-the-api-deprecations-this-week-on-august-16-2018/110746
https://twittercommunity.com/t/reminder-site-streams-user-streams-and-legacy-dm-endpoints-will-be-sunset-august-16th/109482
https://twittercommunity.com/t/building-on-site-streams-user-streams-or-direct-messages-action-required-to-preserve-and-prevent-disruption-to-your-twitter-integration/105736
https://twittercommunity.com/t/date-for-full-deprecation-of-user-streams-site-streams-and-legacy-direct-message-api-endpoints/98734


Update PVGIS docs and test to comply with PVGIS version 5.2

[x] Closes #1415
[x] I am familiar with the contributing guidelines
[x] Tests added
[ ] Updates entries in docs/sphinx/source/reference for API changes.
[ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR removes references to the retired PVGIS irradiance databases CMSAF and COSMO. The CMSAF test file has been replaced with a SARAH2 test file. Additionally, minor doc updates were made, e.g., PVGIS_VARIABLE_MAP was renamed to VARIABLE_MAP.

There's hardly anything to add to the whatsnew as the functionality has not changed. If anyone thinks that it would be meaningful I'll be happy to add an entry though.

@pvlib/pvlib-maintainer feel free to leave a second review, otherwise, I'll go ahead and merge this PR on August 12th.


feat(add): minio-client for minio-application loadgen and liveness

Signed-off-by: shashank855<EMAIL_ADDRESS>What this PR does / why we need it:
Minio-client for  application liveness an loadgen.
main.go is the primary execution script which runs in two mode based on environment variable passed.

liveness mode which creates minio bucket and do the following operations

Loads data in minio bucket.
Unload minio bucket.
For each successful load and unload operation client says Liveness Running.

loadgen mode which simply writes amount of data provided as env-variable. Note: The exution time of loadgen mode may vary depending on the amount of data to be written

Containerizing minio-client application.

Keep main.go and docker file at go-path inside a same directory (ex: minio-client) and install the minio-client dependency by GO111MODULE=on go get github.com/minio/minio-go/v6.
Then execute CGO_ENABLED=0 go build main.go. This will generate the go binary.
Then using docker file build your own image for minio-client.
Use minio-job.yaml and replace the image name name with your own. And finally tune the environment variables in mini-job.yml based on use-case.
Finally apply minio-job.yaml in the cluster to benchmark mini0-application.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Following is the log of minio-client container running in liveness mode:
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Put http://minio-service3.minio.svc.cluster.local:9000/test-bucket-1575280351/test-object: dial tcp <IP_ADDRESS>:9000: connect: no route to host
Liveness failed, Retrying...
Put http://minio-service3.minio.svc.cluster.local:9000/test-bucket-1575280351/test-object: dial tcp <IP_ADDRESS>:9000: connect: no route to host
Liveness failed, Retrying...
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152
Liveness Running
Successfully uploaded bytes:  2097152

Following is the log of mini-client container in loadgen mode
Successfully Created bucket with name:  test-bucket-1575281034
Load generation may take some time
Successfully uploaded bytes:<PHONE_NUMBER>

Thanks @shashank855 ! Good one. Have a few comments


Update youtube_channel_info.txt

Approved.....done!

https://github.com/gift4bd/yt-to-m3u/blob/main/youtube_channel_info.txt
Why isn't the update still shown in this text file?🥺


Forking this project, I'm not seeing many objects that are part of the Nuget package

I've written a simplistic trading tool using the Nuget package linked within this application.  I need to make some minor additions for my own needs, so I forked and pulled down the project. I'm sure this isn't an exhausted list but I can't find project members like IPublicOrder or PublicTicker.  Specifically, these are within the Poloniex library.
Is a part of this project source missing from this repo, that's built into the Nuget package?

Poloniex's PublicOrder is CCXT.NET.Poloniex.Public.PTradeItem and PublickTicker is CCXT.NET.Poloniex.Public.PTickerItem.

Thank you for responding.  I'll update my code.  Was this a code change that's not propagated to the nuget package?  I'm curious why there's a difference.  Again, thanks, especially for the quick response.

I just uploaded it to Nuget.


Move Python wrapper files to new directory

Since the original structure of the project merely contained all the source files in the src directory, I kept it that way, but now that the number of files has increased quite a bit, it might make more sense to move the Python module files into a separate directory. This shouldn't create a problem for the Python module to find the header files of the C++ classes and functions, because the setup.py file can just be altered to set the include_dir keyword argument to be something like '..' instead of '.'.

Fixed in #20


[2257] Send Big Query events

Context
Sending web requests from TTAPI. Largely based on @FriedSock 's PR on publish https://github.com/DFE-Digital/publish-teacher-training/pull/1761
Changes proposed in this pull request
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Send BigQuery events from TTAPI


Any support for adding a "kick" button next to certain replies?

Would be great to kick after "thanks" for instance..

Yes, there are plans to make two-step buttons.


Seems not to work with the latest haskell-ghc-mod

As far as I can tell this package just stopped working after upgrading to haskell-ghc-mod that introduced the data constructor completions.
I don't see any errors related to it in the console log. Is there something I can do to provide more info?

Oops, that's my bad. Should be fixed now.


Warn if ref.watch is used in a showDialog/showModal without a Consumer

Bad:
Button(
  onPressed: () {
    showDialog(builder: (_) => ref.watch(...),
  },
)

Good:
Button(
  onPressed: () {
    showDialog(builder: (_) =>Consumer(builder: (_, ref, __) => ref.watch(...) ),
  },
)

Another case:
final value = ref.watch(provider);
...

onPressed: () => showDialog(builder: (_) => return Text(value));

Not sure how to make this not directly coupled with showDIalog
Maybe one possibility would be anything of the form:
final notAWidget = whatever(builder: (...) { <here> });

As in, if whatever returns a Widget, we assume that. this is a widget, not a "show modal"


Release 0.27.0

Preview at https://github.com/bcardiff/crystal/blob/changelog/0.27.0/CHANGELOG.md

Missing: #6485 also added File#delete, Dir#tempdir and API docs for File

If we're doing to enable overflow checking by default in 0.28.0, it would be nice to have a compile-time flag to enable overflow checking in 0.27.0 so that packages can be tested properly and move to the new operators beforehand.

The stdlib can’t use &+ until 0.27 is released. We would need to add a bunch of version checks like the one in checked/unchecked scope.
I understand it would be good to have a compiler flag to let libraries test before the behavior is changed, but that only can happen after 0.27.0. Unless the stdlib is plagued with lots of checks. I would prefer to avoid that. But we can schedule 0.27.1 for that maybe.

Thanks everybody for the feedback.

I never got a time to read the changelog  before merge :(
I hate the way the breaking changes aren't all at the beginning

@RX14 the structure has been the same for a couple of releases. We can keep changing it of course but I was not aware of a proposal. Regarding this PR, the gross of the content has been there since a week ago, and for a Release PR it's a reasonable time window.

@bcardiff sorry about that - I didn't realise it has been a week. I guess I'm busier than I thought...
The current release note format is better than before.


When to use vec! instead of Vec::new()?

https://github.com/BurntSushi/advent-of-code/blob/d5e3fe31ccc4b260e7377cb1d88ba78438840655/aoc03/src/main.rs#L26

I think I pretty much always use vec![]. I can't think of any specific instance where I'd want to use Vec::new, unless I wanted to use it as a function value. e.g., if you have
fn build_a_vec(build: impl Fn() -> Vec<i32>) {
    let vector = build();
    // do something with vector
}

fn main() {
    build_a_vec(Vec::new);
}

But even then, that's not code I can remember writing.
Note that in the code you referenced, I did include the type, Vec<Claim>, which I believe is optional in that context. I include the type sometimes to make the code clearer. It's a judgment call. :-)


Packaged app won't authorize

Just updated my repo and things stopped working a la #1296
Completely deleted the repo and re-cloned and ran npm install with apparently no issues. npm install gist
npm start returns "Error: Cannot find module 'mapnik'" gist
So I downloaded the packaged app and got a "Connect to your account" screen
When I click Connect, I get a message: {"message":"Not Found"}
So I run the app on localhost:3000 and this is in the URL bar:
https://api.mapbox.com//oauth/authorize?response_type=code&redirect_uri=http%3A%2F%2Flocalhost%3A3000%2Foauth%2Fmapbox&client_id=d8e0abd43fdbafe43c4fdc6059039595bd95518c4982050662d94c134c5538ea
2010 MBP
OS X 10.9.5
Node 0.10.26
Thanks

It looks like there is a double slash in that request URL. Try opening ~/.mapbox-studio/app.db and check for a trailing slash for the MapboxAPIAuth setting. It should be set to https://api.mapbox.com and not https://api.mapbox.com/.

Thanks @willwhite. I'm not sure how to open the app.db file, so I fixed the URL in the browser to do the authorization. Now I'm getting an "Authorization Failed" message when I do that, but when I look at my account on mapbox.com I see a new authorization for Mapbox Studio.

Great, glad there was some improvement.
Which specific error are you hitting when you run with npm start? Is your repo up-to-date with mapbox-studio master?

It appears that trailing slash made all the difference. Doing a fresh clone and npm install resolved it.
Thanks!


Code changes in LAMMPS implementation to fix the 3B symmetry

Fixed the symmetry bug in the pair_uf3.cpp. Now the energy and forces from the lammps implementation of uf3 matches the energy and forces from featurizer and UFCalculator.

Merging this pull request!


[BEAM-4283] Write Nexmark execution times to bigquery

This is to write Nexmark execution times to BigQuery to be able to integrate Nexmark output in perfkit dashboards.
@jkff I did not do a proper test, can you please advice me on a way to properly unit test a simple insert (no PCollection) into Big Query. I left a TODO and comment in the test.
@chamikaramj I heard that @jkff was not very available at the moment. I saw your name in the BigQuery git history. Do you have an advice on the above  question?
Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[X] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Can you use the fake BQ service used by our unit tests ?
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/FakeBigQueryServices.java

@chamikaramj yes as I wrote in the comment in the code I took a look at FakeBigQueryServices and it is PCollection oriented. My use case is a simple insert of values outside a PCollection to BQ. I was searching for a more simple way of testing

@chamikaramj Thanks for your review, I answered all your comments. PTAL

@chamikaramj thanks for the review. Can you please answer my questions above? In the last commit I assumed that you meant what I wrote above. PTAL
Also can you please take a look at the serialization issue and give me your opinion?
Thanks

@chamikaramj I missed part of the stacktrace. I know where the serialization issue come from: I use PipelineOptions in a SerializableFunction used to configure the IO.

Yeah, probably just pass values that you need from options object to ' NexmarkUtils.tableSpec' instead of the full options object ?

@echauchot please let me know if this is ready for another look.

Hi Cham, I fixed the serialization issue and some other things. I should be OK now. PTAL

Please resolve the conflict and reduce the change to one (or few) commits. LGTM other than that.

Hi Cham, thanks, done

Retest this please

Hi Cham, is it ready for merging? If so, can you merge it ?


Update PublishSymbolsV2 to support publishing Dwarf and Elf files on …

…nonwindows agents
Task name:
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

/azp run

/azp run

/azp run

/azp run

/azp run


Add support for more repo settings

The settings I would like to be able to control are:
Repo level

Require contributors to sign off on web-based commits
Always suggest updating pull request branches

Branch protection level

Dismiss stale pull request approvals when new commits are pushed
Require approval from someone other than the last pusher
Require conversation resolution before merging
Require signed commits
Require linear history

But in general it would be best if this contained all possible settings

This would be nice, and also Deployment Environments


Question: what if we have multiple input files?

I'm in a situation where we rely on at least three swagger files for 3rd party APIs that we consume.
What is the recommendation for setting up a gradle file to generate code for three or several dozen swagger files?
Thanks!

I'm in a situation where we rely on at least three swagger files for 3rd party APIs that we consume.

Are those swagger files all independent? If that it's the case, then the simplest approach would be to create 3 gradle modules and apply swagger-gradle-codegen on each of the module with a separate input file

Yeah, they do need to be independent of each other. 😕
Can we turn this question intern a feature request? I think a dozen gradle modules is a bit excessive. 😁

Can we turn this question intern a feature request? I think a dozen gradle modules is a bit excessive. 😁

Well, I'd argue that having a dozen modules is actually better than having a single module with 12 input files.
Currently, the generateSwagger is incremental and you can leverage this feature by making sure that you run the generator only for the spec files that actually changed.
Having multiple files as Input of a single task, will most likely result in calling the generator on every single file (even if just one was edited).

@cortinico I have approx. 30 files I need to generate specs for. Do i make 30 gradle modules? lol


Proxy setting not being applied to api calls

Description
Adding "proxy": "url:port" to my package.json does not alter the port used in fetch requests.
Expected behavior
I have added "proxy": "http://localhost:8080" to my package.json within my root folder and so would expect that my fetch requests will be directed to this port.
Actual behavior
The requests are still going through to the port on which the create-react-app server is running, 3000 in this case. This has been observed using chrome network tools as well as using postman.
Environment
Run these commands in the project folder and fill in their results:

<EMAIL_ADDRESS>node: 7.2.0
npm: 4.0.5
yarn: 0.19.0-20161207.1240

Then, specify:

Windows 10
Chrome 55

Reproducible Demo
I'm not 100% sure on how to get a demo up and running, but here is the code that I am making my api call with and my package.json file for reference.
export function fetchEvents() {
  return dispatch => {
    fetch('/api/events')
      .then(res => res.json())
      .then(data => dispatch(setEvents(data.events)));
  }
}

package.json
{
  "name": "cra",
  "version": "0.1.0",
  "private": true,
  "devDependencies": {
    "flow-bin": "^0.36.0",
    "react-scripts": "0.8.3"
  },
  "dependencies": {
    "react": "^15.4.1",
    "react-dom": "^15.4.1",
    "react-redux": "^4.4.6",
    "react-router": "4.0.0-alpha.6",
    "redux": "^3.6.0",
    "redux-devtools-extension": "^1.0.0",
    "redux-thunk": "^2.1.0"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test --env=jsdom",
    "eject": "react-scripts eject"
  },
  "proxy": "http://localhost:8080"
}

Have you restarted the server after adding the setting?

Yeah restarted both the api server and the create-react-app server multiple times

It does look like you're getting 400 ERROR. Doesn't this mean the request gets proxied (but server fails for some reason)?
The request would appear to be to 3000 port in the browser because that's the point of the proxy feature. It is needed so that browser lets us make the request without enabling CORS on that server. However the actual request gets proxied so while you see it as a request to 3000, CRA will pipe it to 8080 port instead, undetectable to the app itself.

If I change to fetch('http://localhost:8080/api/events') it works though, so the api seems to be ok

I was using the 8080 port for another process and didn't realise because the express server was still working fine on that port. Issue was on my end so can close this, apologies. I've changed the port and updated the package.json and it works as expected.

Glad you found the issue!
Let us know if you have any other probles.

I'm having the same problem, but no matter what port I change it to, React still points api calls to http://localhost:3000/ instead of the proxy I provide.

I am trying to deploy React to production and I discovered that the proxy settings are not being passed. I use nginx in production. But even in my localhost with serve -s in port 5000 the api does not even get called. I know I am doing something wrong but I do not know what it is. My settings work perfectly with npm start.

Proxy does not influence production at all; it's strictly for development.

@Timer never heard of that before, know a good link for me to read?

@ProductOfAmerica Did you figure out the problem?

@AdityaAnand1 nope

I just ended up moving all my API endpoints to /api (and my static assets to /assets)
"proxy": {
    "/api": {
      "target": "http://localhost:3001"
    },
    "/assets": {
      "target": "http://localhost:3005"
    }
  },

Now my server only cares about the /api stuff and service static files and react handles everything else.

@AdityaAnand1 I'd just like to say thank you for sharing that solution. I was having issues getting the proxy setup and felt quite frustrated that fixed it and now React forwards certain requests to the API :)

Hi I been trying the proxy solution to avoid the cors problems in CRA but it doesn't seem to work, i restarted my machine so many times and that made no difference. Basically the CRA is using fetchApi  to call another domain (localhost:8090) which is a SpringBoot application endpoint. I added in package.json   "proxy": "http://localhost:8090/" but the api still return calls with localhost:3000.
Am i missing anything else ! any help would be appreciated as I am kind of new to UI development and running out of options.
thanks
Aveen

@aaveen  same problem here. been looking for a solution for hours with no luck =[

@AdityaAnand1 This worked. Thank you

I might shine a little light for someone else who will run into this issue.
Here is my proxy:
"proxy": "http://localhost:3001"

Here is my console.log(err) in fetch which shows in broswer console:
Response {type: "basic", url: "http://localhost:3000/api/user", status: 500,...}

At first, I thought, for some reason, React app does not know my proxy and assume that this is create-react-app's fault
However, I put a console.log inside the api call.
server.post('/api/user', (req, res) => {
     console.log("here");
     .....
});

And able to see "here" in server terminal.
The error message in browser might be misleading! So, double check!

@iamthuypham This problem has been giving me a headache for the past two hours, I looked through the comments on all the proxy issues and nothing worked. This whole time the proxy was working, but the error kept saying the request was being made to the wrong URL, so I just assumed the proxy was not working. Would've never thought it was the browser spitting out a misleading error message. Thanks for your help!

You could also use this, to target every route
"proxy": {     "/*": {        "target": "http://localhost:3001"     }   }

I'm having the same problem as @juanjoseluisgarcia, I think it might have something to do with react router blocking calls to the backend server. I also can't quite tell how to configure the production server for these kinds of requests so any help is much appreciated!


20000Hz tone

If you do this:
tone1.play(20000);
you should actually notice/hear something that is barely audible. But this generates some weird raspy sound no matter what speaker is used.
Is it even possible to generate such a tone with this library and hardware (Arduino)?

Did you use a tone generator to determine that you can physically hear 20 KHz? I can only hear up to about 17 KHz myself. I noticed a similar sound, too. Ramp the frequency up from 5 KHz to see how high you can hear that speaker. I am not super educated in frequencies, but you could be hearing a constructive combination of harmonics that is within your hearing range.

I haven't thought of this! Thanks for the reply.


Added java folder

Sorry, but moving all files to another folder is not a good idea. I will add Ignore intellij IDE files commit manually.


Move to running on a Worker

Update and refactor the bot logic to run on a Cloudflare Worker instead of as a continually running Node process.

This is running in production, with the fallback being the Express app for now.

This is running in production, with the fallback being the Express app for now.

This has been working flawlessly as a worker, merging.

This has been working flawlessly as a worker, merging.


Support app-defined Anchor instructions

Resolves #148
This is being created as DRAFT for discussion.

The feature added is described in the README.
Change is additive in a single file, with one exception: a change to make findProgramAddress public.
Note that findProgramAddress could actually be internal - but it seems like it should be a public utility function for any programs using this package (fixes #144 too).
Sadly, the existing tests are broken (see #149), and I didn't write any new tests for this - I would love to add some tests but I'm trying to encourage some discussion around how to best achieve this (Anchor support) before spending lots of time on it. It works for our Anchor program, and provides a cleanish way for apps to talk directly to their own Solana programs.
I know there's a separate Anchor.swift repo, but it appears to be abandoned.
There are many fancy things that could be done - parsing IDL; property wrappers to provide function parameter hints and auto-implement serialization; but this seems like a good place to start discussion. It's simple, it works, it can be extended.
I put all the Anchor support code in one file, but its location is probably wrong, and perhaps some of these bits could be elsewhere - I welcome discussion/suggestions on how to tidy this up.

Sorry I hit the wrong button by mistake

Can you rebase please?

@ajamaica Rebased - I think this one might need some discussion around the approach. It's probably a good way to go forwards with Anchor support but it'd be great to discuss the points raised in the PR description to make sure this is a good start to incrementally improving Anchor support longer term.

This is now possible


Finalizing LUKE model

This pull request aims to finalize the integration of the LUKE model and contains the following fixes:

Add entity_span_classification task to the tokenizer
Fix typos in documents
Improve documents

Looks great!
Could you also update the code examples defined after the forward method of each head model? Thanks!


Drag files into folder tricker media keys

Description
When drag multiple files into a folder
And having some media player in background
Files tricker media key to resume playing video
Steps To Reproduce

Open any media video with MPC and leave it paused in the background
Create a new folder with Files
Drag files into the new folder
Files is moved but also the video got resume playing back

Expected behavior
It shouldnt affect the video playback in the background which is paused
Files Version
Version: <IP_ADDRESS>
Windows Version
Windows 10.0.19044.1466
Relevant Assets/Logs
debug_fulltrust.log
debug.log

Is this still an issue in <IP_ADDRESS>?


”Dagâța”, ”Bălușești”, ”Boatca”, ”Buzdug”, ”Mănăstirea” are listed in the drop-down menu

Description:
When user writes ”Dagâța”, ”Bălușești”, ”Boatca”, ”Buzdug”, ”Mănăstirea” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Dagâța"

Expected results
The location appears in the drop-down menu as "Sat Dagâța, IAȘI (Dagâța)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Bălușești"

Expected results
The location appears in the drop-down menu as "Sat Bălușești, IAȘI (Dagâța)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Boatca"

Expected results
The location appears in the drop-down menu as "Sat Boatca, IAȘI (Dagâța)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Buzdug"

Expected results
The location appears in the drop-down menu as "Sat Buzdug, IAȘI (Dagâța)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Mănăstirea"

Expected results
The location appears in the drop-down menu as "Sat Mănăstirea, IAȘI (Dagâța)".