Restructure code in Router

The route calculation in Router now uses different 'Solver's depending on request. Plugging in different solvers allows modifying profile selection, weighting creation, snapping behavior and routing algorithm selection.

Thanks for providing this PR. I was just wondering, what are the reasons to have the solver as static inner class? Wouldn't it be cleaner to break this down into multiple classes?

Hm no real reason I think, just no real reason to separate it, yet. You mean we should make the solver classes separate public (?) classes? Btw currently you can also override createSolver if you want to provide your own.

I am still not sure about these abstractions, so I am trying to be careful, I guess.

Yes I totally get that. Unless it is required, code can be easier without abstraction, so makes sense 👍 .

You mean we should make the solver classes separate public (?) classes?

Yes :). I don't have any strong points for that, it's more a feeling:

The Router is now at ~550 lines, this makes it more complicated, so having this split into smaller parts would be beneficial (The solvers are in total about 230 lines).
Somehow the inner class feels a bit weird. Usually I try to avoid inner classes.

To be honest I was mostly wondering about the usage of static at the inner class. So I took a closer look.

To be honest I was mostly wondering about the usage of static at the inner class.

Ah I make every inner class static if its possible. When it's static it means its unrelated or decoupled to the actual class, so it can be easily moved somewhere else if need be. I usually try to avoid non-static inner classes.

When it's static it means its unrelated or decoupled to the actual class, so it can be easily moved somewhere else if need be.

Yes, and I think that was the reason why I thought it should be moved out :).

non-static inner classes also have a slight overhead ;)
https://rules.sonarsource.com/java/RSPEC-2694

I don't think the router is more complicated because the file is longer. It would be more complicated if it contained more entangled code, but since the solvers are more or less independent its easy to reason about them or about the rest of the router in isolation. But sure maybe the next step would be moving them to separate files. That would be an indication for me that they should/can be used by themselves, but currently I am not sure about it :) Well, it does not matter that much, basically a static inner class just belongs to another 'namespace'. But obviously if there is any valid use-case that requires moving the solvers that should not be a big deal.


feat: Raise an error when invalid custom field is specified.

Raise an error when an invalid custom field is specified.
Currently, the invalid custom field is silently ignored which creates a wrong impressing that everything is OK.

The CLI behavior is same as this and I am not sure if we need to be strict on the CLI side. Also, this would be sort of a breaking change IMO. Thoughts?

The problem is that when you (as a user) have incorrectly set Custom fields in the configuration file, you have no idea, what is happening because the invalid custom field is silently ignored.
That is confusing and creates frustration when using the feature.
At the very least there should be a warning. You are passing an argument and expect it to have an effect. There's none.
I would not consider it a breaking change when the CLI newly checks this. It merely points out an error situation that was previously wrongly ignored.

I would not consider it a breaking change when the CLI newly checks this. It merely points out an error situation that was previously wrongly ignored.

I think we should start with the warning and fail in future release. I would suggest the following:

Add a warning when running the command so the users of this feature are aware of the incoming change.
Do a new minor release with this change in place.
A version after that will include the patch to fail for invalid custom field.


Autorest Regen Preview to 3.0.0-alpha.20231116.9 by Michael Nash from refs/heads/mnash-tsp50

Triggered from refs/heads/mnash-tsp50

API change check
API changes are not detected in this pull request.


[New game]: PIXEL PAINTER

🎮 Game Request
Pixel Painter is a drawing game where players can create pixel art. The game features a grid canvas where each cell represents a pixel. Players can select colors from a palette and fill in the pixels to create their artwork.
Point down the features
Pixel Painter Game Features

Interactive Grid Canvas-
Pixel Grid: The game features a dynamic grid where each cell represents a pixel. Users can draw by clicking on the cells.
Customizable Size: The canvas size can be adjusted, allowing users to choose the number of pixels horizontally and vertically.

Extensive Color Palette-
Color Selection: A wide range of colors is available for users to select from and apply to their pixel art.
Color Preview: The selected color is displayed prominently to provide visual feedback.

Versatile Drawing Tools-
Pencil Tool: Users can click on individual pixels to color them with the selected color.
Eraser Tool: Users can click on pixels to revert them to the default background color (white).
Fill Tool: Users can click on a pixel to fill an area with the selected color, similar to a paint bucket tool in traditional drawing applications.
Clear Canvas: A button to reset the entire canvas, clearing all drawings.

Save & Share Functionality-
Save Artwork: Users can save their artwork locally as an image file.
Shareable Links: Users can generate a shareable link that encodes their artwork, allowing others to view it by opening the link.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @aadyagupta44 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hello @aadyagupta44, Time's up!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @aadyagupta44 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Enum cases encoding

Enum cases will encode as nested containers and I don't think there's enough unit tests around this — I didn't try associated values at all and I'm sure something, somewhere will crash. Ollie pointed this use case in chat: https://github.com/thousandyears/AnyCoding/blob/trunk/Tests/AnyCodingTests/AnyCodingTests.swift#L48-L50
PS: How would that even look like in Markdown so that is human-editable friendly?

I see here two issues that need to be resolve before MarkCodable can encode enums by default

Cases without assoc. values

The current issue with encoding enums is that their keys are empty containers which don't translate very well to encoding as markdown. For example this is a unit test encoding an enum:
func testPlainEnums() throws {
    struct Str: Codable, Equatable {
        enum Kind: Codable, Equatable {
            case basic(String, Int), intermediate, advanced
        }
        var kind: Kind
    }

    let encoder = MarkEncoder()
    let markdown = try encoder.encode(Str(kind: .intermediate))

    print(markdown)
}

And that prints just:
||
||
||

I've done some thinking about this and it does seem very, very reasonable to provide a stable encoding for enum cases at the top level by default.

Cases with associated values

The same code from above but using the .basic case produces:
|kind.basic._0|kind.basic._1|
|-------------|-------------|
|asdasd       |15           |

which isn't human friendly.

Closed with https://github.com/MarkCodable/MarkCodable/pull/39


Unify extraction and serialize to both use the serialize format

Right now extraction extracts to an Expr, but this has the big downside of not sharing subexpressions.
The new serialization format supports terms, so we should extract to that.

Not sure about this one yet. The serialization format is stringly typed, so
extracting straight into it risks losing something for sure.
On Thu, Jul 20, 2023 at 12:52 PM Oliver Flatt @.***>
wrote:

Right now extraction extracts to an Expr, but this has the big downside
of not sharing subexpressions.
The new serialization format supports terms, so we should extract to that.
—
Reply to this email directly, view it on GitHub
https://github.com/egraphs-good/egglog/issues/172, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANTPTB5CF4ZO4NDUQZTDCTXRGD6LANCNFSM6AAAAAA2R4354E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I guess we should keep the TermDag data structure in #158 then?

Something like that probably. Currently the serialization data structure
isn't well-suited to use a data structure in itself. It's really only for
serialization. Perhaps we could improve that at some point, but for now, it
seems like you need something else. It would be nice if whatever data
structure you use (TermDag, perhaps) mirrors the serialized e-graph in
structure, but just with actual types.
On Thu, Jul 20, 2023 at 2:03 PM Oliver Flatt @.***>
wrote:

I guess we should keep the TermDag data structure in #158
https://github.com/egraphs-good/egglog/pull/158 then?
—
Reply to this email directly, view it on GitHub
https://github.com/egraphs-good/egglog/issues/172#issuecomment-1644602740,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANTPTDCP7RPOCCYB5AL6Q3XRGMJBANCNFSM6AAAAAA2R4354E
.
You are receiving this because you commented.Message ID:
@.***>

The serialization format is stringly typed, so extracting straight into it risks losing something for sure.

By stringly typed, do you mean that the sorts are encoded as strings or that the primitive values are encoded as strings? Can you imagine a scenario where you do lose something? Curious b/c I was also thinking of using it for custom extraction by exposing it to Python.

Both? It's just not what you would typically do for extraction. It could work, assuming you can parse everything back correctly. Just a little wonky for "normal" use cases.


API Updates as of 7/27/2015

This change is

build failed?

Comments from Reviewable

PlanGrid.Api/Date.cs, line 9 [r1] (raw file):

namespace PlanGrid.Api
{
    public struct Date

any particular reason it's a struct?

Comments from Reviewable

@marchello2000 The build failed because I removed the test API url from the config file (per Rob's request).  Need to make it an environment variable on the build server.  Since it's using Jenkins, I suppose I can do that msyelf.
The reason it's a struct is it's an immutable value type like DateTime.  Seemed to make sense to me to follow its lead.

:+1:
(p.s. enabled reviewable on this repo)

Comments from Reviewable

PlanGrid.Api/IPlanGridApi.cs, line 154 [r1] (raw file):

        Task<ShareableObject> CreateSheetPacket(string projectUid);

        [Post("/projects/{projectUid}/sheets/packets/{packetUid}")]

should it be a POST when the method names says Get?

Comments from Reviewable

:+1:

Review status: 0 of 42 files reviewed at latest revision, 2 unresolved discussions, some commit checks broke.

PlanGrid.Api/IPlanGridApi.cs, line 154 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> should it be a `POST` when the method names says `Get`?

Ah, nice catch.  Missed the test for these two methods.  Will add.

Comments from Reviewable

PlanGrid.Api/PlanGridApiExtensions.cs, line 109 [r1] (raw file):

        }

        public static async Task UploadVersion(this IPlanGridApi api, string projectUid, string versionName, params VirtualFile[] files)

nit: is UploadVersion the right name... I thought we are moving towards UploadGroup or something like that? If that's what the API says then keep it obviously.. just  curious

Comments from Reviewable

PlanGrid.Api/PlanGridHttpHandler.cs, line 40 [r1] (raw file):

            request.Headers.Accept.Add(MediaTypeWithQualityHeaderValue.Parse("application/vnd.plangrid+json; version=1"));

            HttpResponseMessage response = await base.SendAsync(request, cancellationToken);

does SendAsync not throw?

Comments from Reviewable

PlanGrid.Api/PlanGridHttpHandler.cs, line 40 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> does `SendAsync` not throw?

As in, do we need this in a `try`/`catch`? or have the clients handle that?

Comments from Reviewable

PlanGrid.Api/Rfi.cs, line 37 [r1] (raw file):

        [JsonProperty("sent_date")]
        public Date? SentDate { get; set; }

Hm... did they actually change this to a Date object? I thought all of backend moved to always have DateTime

Comments from Reviewable

PlanGrid.Api/RfiUpsert.cs, line 28 [r1] (raw file):

        [JsonProperty("sent_date")]
        public Date? SentDate { get; set; }

same here, re: Date

Comments from Reviewable

Review status: 0 of 42 files reviewed at latest revision, 6 unresolved discussions, some commit checks broke.

PlanGrid.Api/PlanGridApiExtensions.cs, line 109 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> nit: is `UploadVersion` the right name... I thought we are moving towards `UploadGroup` or something like that? If that's what the API says then keep it obviously.. just  curious

The endpoint (https://developer.plangrid.com/docs/upload-version-to-project) names it "Upload Version to Project" :)

PlanGrid.Api/Rfi.cs, line 37 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> Hm... did they actually change this to a `Date` object? I thought all of backend moved to always have DateTime

See: https://developer.plangrid.com/docs/timestamps
For some fields (issue due date, for example) they require the date version.

Comments from Reviewable

PlanGrid.Api/JsonConverters/DateUrlParameterFormatter.cs, line 13 [r1] (raw file):

            if (value is DateTime)
            {
                return ((DateTime)value).ToString("yyyy-MM-ddTHH\\:mm\\:ss");

This is ISO8601? do we need Z at the end to indicate UTC?

Comments from Reviewable

PlanGrid.Api/JsonConverters/DateConverter.cs, line 11 [r1] (raw file):

        {
            var date = (Date)value;
            writer.WriteValue(date.ToString());

not sure this will be right in all locales?
Maybe .ToString("yyyy-MM-ddTHH:mm:ssZ", DateTimeFormatInfo.InvariantInfo)

Comments from Reviewable

PlanGrid.Api/JsonConverters/DateConverter.cs, line 17 [r1] (raw file):

        {
            string s = (string)reader.Value;
            return Date.Parse(s);

as above, assume this is for ISO8601 dates? Then we should:
DateTime.ParseExact(s, "u", System.Globalization.CultureInfo.InvariantCulture);

Actually, prob should use u above as well

Comments from Reviewable

Review status: 0 of 42 files reviewed at latest revision, 9 unresolved discussions, some commit checks broke.

PlanGrid.Api/JsonConverters/DateConverter.cs, line 17 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> as above, assume this is for ISO8601 dates? Then we should:
> ```
> DateTime.ParseExact(s, "u", System.Globalization.CultureInfo.InvariantCulture);
> ```
> Actually, prob should use `u` above as well

What is `"u"`?  I don't see it [here](https://msdn.microsoft.com/en-us/library/8kb3ddd4(v=vs.110).aspx).  Did you mean `"o"`?  If so, we can't use that because the API currently has a bug which doesn't allow the "Z".  (at least, that was the case yesterday when I reported it to the channel, though Ky was working on it)

Comments from Reviewable

Review status: 0 of 42 files reviewed at latest revision, 9 unresolved discussions, some commit checks broke.

PlanGrid.Api/PlanGridHttpHandler.cs, line 40 [r1] (raw file):
Previously, marchello2000 (Mark Vulfson) wrote…
> As in, do we need this in a `try`/`catch`? or have the clients handle that?

Not sure I entirely follow.  Why would we do a try/catch?  What can we do in the catch?

Comments from Reviewable

PlanGrid.Api/PlanGridHttpHandler.cs, line 40 [r1] (raw file):
Previously, kirkplangrid (Kirk) wrote…
> Not sure I entirely follow.  Why would we do a try/catch?  What can we do in the catch?

Don't some network issues manifest as exceptions here? We wrap `SendAsync` in try/catch in our app

Comments from Reviewable


Re-encode topic from WAMP msg to safeguard

The client is supposed to send a string as a topic but we're going to re-json'ify the topic in case of bad client input.
fixes #516

I think I'm going to update this and close the connection instead of supporting invalid params...


Fix run notifications bugs and improve accuracy

This fixes a few issues with the run app, mostly ones I introduced with the notifications, but not exclusively. It also removes an unnecessary variable assignment in the recorder app.

Don't try and enable/disable recording if the recorder widget is unavailable
Don't configure notifications for stats which do not have a box enabled
Look up the vibTimes rather than the vibPatterns to determine the current notification configuration
Use the previous notification state to determine the next state, rather than the current stat (decreases notification drift)
Reset GPS state in reset to prevent distance miscalculation when stopping one run and starting another

Thanks! Does the GPS state thing really help to fix a problem though?
It seems that because we measure distance as that between the current and last period, setting it to {} may actually have the effect of skipping out one second's worth of distance?

Thanks! Does the GPS state thing really help to fix a problem though?
It seems that because we measure distance as that between the current and last period, setting it to {} may actually have the effect of skipping out one second's worth of distance?

If you stop a run and start another it would have the old GPS state and if you had moved at all it could cause the initial distance calculation of the second run to be wrong by the distance you had traveled between stopping and starting.

Do you actually see this happening though? Or is it just what you think might be an issue?
Because I believe GPS is on all the time so those should update every second regardless of whether you have started the run or not.

I see what you're saying and it might have then been a coincidence because I was having trouble with the initial distance on a second run and then it went away after making that change. Perhaps I had a better GPS fix by that point, though it had been around 30 minutes of consistent testing by then. I had assumed that when run told the recorder widget to setRecording(false) it would stop GPS updates to exstats too, but see now that wouldn't be the case because exstats is doing its own setGPSPower.
If the GPS is always on with exstats then does that mean leaving the watch on the run app screen will run the battery out faster than not having the app open, even when not running? The run app is my primary use of the watch and I leave it open a lot, even between runs.

It looks like the GPS 'fix' likely caused this issue? https://github.com/espruino/BangleApps/pull/1630

If the GPS is always on with exstats then does that mean leaving the watch on the run app screen will run the battery out faster than not having the app open, even when not running?

Yes, that's the case. But it's important the GPS is turned on as soon as possible, because it can take a while to get a lock. Last thing you want it to start recording and then have it miss the first 10 minutes of your run

@gfwilliams I went back and tested and retested and could not duplicate the issue that caused me to introduce this breaking change, instead confirming the GPS fix is updating nearly once per second as you said, regardless of whether a run is active. Would you like me to revert it and/or the change from #1630 or leave things as-is?

Thanks for checking into this! I've just removed the ={} bits - I guess #1630 is probably a good thing to have in anyway as maybe there's a case where you start the app and then start the run within 1 sec of boot - and you could hit the issue in that case :)


SWARM-1318: Update okhttp to 3.4.2 and okio to 1.9.0

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

I'll have to add a test for this

We are waiting for @michalszynkiewicz to verify the okio update.

okio 1.9.0 will be productized (hopefully today), so we should be ok to use these two.
Looks good to me.


[Bug]: chrome in puppeteer can't play video

Bug description
Steps to reproduce the problem:
I use puppeteer with "headless: false" mode to visit a page with video, the url is https://tv.cctv.com/2020/02/06/VIDEQdsZLhKCkQSAhAqG9wQG200206.shtml,
but after the page has loaded, the video can't play.

My code is as follows:
var browers = await puppeteer.launch({
//headless: headless,
headless: false,
defaultViewport: {width: 1440, height: 800}
});
...
Puppeteer version
12.0.0
Node.js version
16.13.0
npm version
8.1
What operating system are you seeing the problem on?
Windows
Relevant log output
No response

@OrKoN I use v17.1.3 to play video but still failed. The page url is https://mp.weixin.qq.com/s/WGFSzJ0IDZmzRaV5qE_-jQ

@libofei2004 I am able to reproduce. But I think there is not much we can do: the Chromium binary might not have all codecs required to play a video. I see that the same happens with YouTube https://stackoverflow.com/questions/60307750/puppeteer-unable-to-play-video so I think this site as well as YouTube require some proprietary codecs that only exist in the Chrome binary. You can provide a custom executable path to a Chrome binary to have it working.

@OrKoN Thank you, I'll try to use Chrome to solve it.

@OrKoN I use ' let videos =  await page.$$eval('video', eles=>eles.map(ele=>ele.src)) ' to get video src in the page is aslo failed, the length of videos is 0, Is it caused by the same reason?

@libofei2004 I believe the page might be removing the video tag from the page if the playback failed

@OrKoN I think you are right.

@OrKoN I think you are right.


Is this mod just dead..?

A lot of issues have been reported with little to no response, plug there's been a vast lack of updates despite many of these issues being quite problematic.
It's fine if the project is abandoned, but please give some form of confirmation if it is?

its not abandoned

This mod is undergoing a large-scale rewrite for modern versions (1.20+) and will be repackaged into an all-in-one MCD content mod with Dungeons Mobs. I am also currently the only maintainer for this version, and I haven't had time to address any of the issues plaguing the 1.19.2 version of this mod and the ones related to it (Libraries, Mobs).


fix!: Updated schema to use title attribute for schema name

To better comply with JSON schema standard. Updating TigrisDB schema to read the schema name from title attribute. (It was name before)

Codecov Report

Merging #207 (1d49d24) into main (db39a92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   39.82%   39.82%
=======================================
  Files          35       35
  Lines        3134     3134
=======================================
  Hits         1248     1248
  Misses       1724     1724
  Partials      162      162

Impacted Files
Coverage Δ

schema/schema.go
69.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db39a92...1d49d24. Read the comment docs.


Watt usage monthly consumption

Would it be possible to collect the usage and create a monthly watt usage for calculating cost ?

The power sensors are not present in all servers. For example my microserver does not have them.
I suppose you can use what @molekylspektroskopi suggests.


fix: copy from the correct folder

it looks like due to the folder structure the target folder is one level up

bors r+


Feature request: investigate how to improve highlighting

Is your feature request related to a problem? Please describe.
We want to improve highlighting of liquid in VSCode, including if possible Silverfin flavored liquid elements. We still need to investigate what is the best way to approach it.
Describe the solution you'd like
Every element in the code is highlighted properly. For example, custom drops:  custom.foo.bar where namespace and key should be highlighted properly
Describe alternatives you've considered

Investigate if it's possible (and viable) to use (and/or extend?) Shopify's tree-sitter https://github.com/Shopify/tree-sitter-liquid.
Existing (deprecated)  extension VS-Code for tree-sitter that may give some ideas on how to implement a new language. https://github.com/georgewfraser/vscode-tree-sitter

I've been playing around with tree-sitter, basically cloning Shopify's repo and trying to extend it. So I wrote the grammar rules for translations tags and I think I got something really interesting! This is how the tree of a liquid file looks and the items identified in translations (notice the highlighting on top of the translation key)

Picked up translations because I though it could be useful to address #54, but also could be done with parts and shared parts for #55 and so on!

Include tags to identify parts and shared parts


Default initializers on required parameters

Fixes #3604.
This PR relaxes our rules to allow default initializers to be present on required parameters as well as optional parameters. To be concrete, we allow default initializers on all parameters. To be considered an optional parameter, the parameter must have a question mark, or it must have an initializer and not be followed by a required parameter anywhere in the rest of the signature.
For example, in the following signatures, a is optional:
(a = 0, b = 0);
(a = 0, b?);
(a = 0, ...b);

But in the following signature, a is not optional:
(a = 0, b);

One thing to note is that an optional parameter corresponds to an argument slot that is allowed to be missing. The default initializers for required parameters kick in when undefined is passed, but the argument is not allowed to be omitted entirely.
This should not be a breaking change.

:+1:

@JsonFreeman do we have any issue tracking the associated spec change? :)

Oh man, I keep forgetting. And you always catch it!


CRITICAL: Could not initialize SDL: windib not available

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Windows 10 Pro N  [20H2] [19042.1320]
scrcpy version: 1.19
installation method: Chocolatey
device model: Google Pixel 6 Pro
Android version: 12

Describe the bug
Upon starting scrcpy, the following error occurred:
CRITICAL: Could not initialize SDL: windib not available
Both scrcpy and adb were installed via choco
On errors, please provide the output of the console (and adb logcat if relevant).
F:\>scrcpy
INFO: scrcpy 1.19 <https://github.com/Genymobile/scrcpy>
C:\ProgramData\chocolatey\lib\scrcpy\tools\scrcpy-server: 1 file pushed, 0 skipped. 33.8 MB/s (37330 bytes in 0.001s)
CRITICAL: Could not initialize SDL: windib not available
[server] INFO: Device: Google Pixel 6 Pro (Android 12)
[server] ERROR: Exception on thread Thread[main,5,main]
java.io.IOException: Connection refused
        at android.net.LocalSocketImpl.connectLocal(Native Method)
        at android.net.LocalSocketImpl.connect(LocalSocketImpl.java:259)
        at android.net.LocalSocket.connect(LocalSocket.java:148)
        at com.genymobile.scrcpy.DesktopConnection.connect(DesktopConnection.java:40)
        at com.genymobile.scrcpy.DesktopConnection.open(DesktopConnection.java:63)
        at com.genymobile.scrcpy.Server.scrcpy(Server.java:57)
        at com.genymobile.scrcpy.Server.main(Server.java:255)
        at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
        at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355)

Try with another SDL version (replace SDL2.dll with one from the release archive of an older scrcpy version).

I'm not sure if that would help because I think the underlying issue may be that my Windows 10 system is using DirectX 12 - which I don't believe SDL fully supports yet.  I think the max supported right now is DirectX 11.
Can anyone confirm this suspicion?
@rom1v What SDL (or scrcpy version) would you recommend?


[Hive] Samples are only created using Text file format

In Hive, there are several file formats that one can use to load the data for its tables (e.g., Text, SequenceFile, RCFile, Avro, ORC, Parquet). However, Verdict currently only creates samples in Text file format regardless of the file format of the original table.
Since other file formats like ORC and Parquet can provide drastically better query performance than Text, it would be better if Verdict can create samples using file formats other than Text.
This may not be a Hive-specific issue and may be applicable to other HDFS-based DBMS (Impala? - check required).
One way to solve this issue without adding too much burden on users (i.e., having to specify file format for samples) would be to automatically create samples in same file format as the original table (e.g., ORC table -> ORC samples,  Parquet table -> Parquet samples, etc.).

The issue has been moved to the private repo.


作者你好，我在复现您代码的过程中，运行trainer.py中的代码后出现了以下错误。请问您方便告知我一下如何解决吗？

running integrity checks
No embeddings have been generated for _utils
datafolder is: E:\lh\SpaceRL-KG-master/datasets/COUNTRIES
generating embeddings for dataset COUNTRIES and models ['TransE_l2']
Selected embedding TransE_l2 is already generated for COUNTRIES dataset, if you want to regenerate use the regenerate boolean option
calculating embedding minimums and maximums...
100%|██████████| 4/4 [00:00<00:00, 4011.77it/s]
100%|██████████| 271/271 [00:00<00:00, 7356.62it/s]
triples: 1159, nodes:271, edges:2587
restoring model...
WARNING:tensorflow:Layer lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer lstm_1 will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer last_lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer lstm_1 will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer last_lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer lstm_1 will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
WARNING:tensorflow:Layer last_lstm will not use cuDNN kernels since it doesn't meet the criteria. It will use a generic GPU kernel as fallback when running on GPU.
Running episodes for: COUNTRIES-TransE_l2:   0%|          | 0/231800 [00:00<?, ?it/s]
running for 231800 iterations
Traceback (most recent call last):
File "E:/lh/SpaceRL-KG-master/model/trainer.py", line 377, in
main(True)
File "E:/lh/SpaceRL-KG-master/model/trainer.py", line 372, in main
hasFinished = m.run()
File "E:/lh/SpaceRL-KG-master/model/trainer.py", line 217, in run
action, observation, reward, max_rew = self.agent.select_action()
File "E:\lh\SpaceRL-KG-master\model\agent.py", line 579, in select_action
inputs, rewards = self.get_inputs_and_rewards()
File "E:\lh\SpaceRL-KG-master\model\agent.py", line 479, in get_inputs_and_rewards
self.get_next_state_rewards(it)
File "E:\lh\SpaceRL-KG-master\model\agent.py", line 357, in get_next_state_rewards
encoded_action = self.encode_action(action_taken[0], action_taken[1])
File "E:\lh\SpaceRL-KG-master\model\agent.py", line 339, in encode_action
rel_emb = self.relation_emb[chosen_rel]
KeyError: '\xacneighborOf'

你好，我在Windows系统上部署好该代码的环境。屡次调试始终出现：KeyError: '¬neighborOf'这个错误。我怀疑是这个¬否定符号的编码格式问题。请问我该如何解决呀？


XJC: cannot use non-XML catalog files

When using a catalog in non-XML format, this fails as XJC always parses catalog files as if they were XML. This worked prior to XJC 2.3.0 but stopped working with that release.
Ideally, this could also be fixed in version 2.3.3 which is still in heavy use. Right now it is for example impossible to use the jaxb2-maven-plugin on Java 11 with a non-XML OASIS catalog file.

see https://bugs.openjdk.java.net/browse/JDK-8231578 - there is not much we can do unless someone provides a PR workarounding this...

see https://bugs.openjdk.java.net/browse/JDK-8231578 - there is not much we can do unless someone provides a PR workarounding this...

@raphw are you using mojohaus plugin ?
We found a way with Matt to solve an issue with catalogs handling in the former maven-jaxb2-plugin from highsource when uptading to xjc 2.3.4+
We have projects that works with xml and non-xml catalogs.
You can look at it when 2.0.5 release will be out if you want

This is the repository I mentionned https://github.com/highsource/jaxb-tools

Certainly, but this remains a problem in the official plugin.

Yes of course.I understand your point.
The plugin I mentionned and the mojohaus one are the oldest maven plugins I know about generating java from xsd, that's why I mentionned the highsource one in the comment


Error on initializing stepper

I'm getting error "Cannot read property 'classlist' of null" on the line that creates a stepper instance.  My code is:

$(document).ready(function () {
    var stepper = new Stepper($('.bs-stepper')[0])
})

There is a div with class bs-stepper on the page.  The stepper is within a bootstrap modal in case that matters.

Never mind, fixed it.

I have the same issue but I am using vue.js.
Could you tell me how to fix the bug?

Never mind, fixed it.

I have the same issue but I am using vue.js.
Could you tell me how to fix the bug?

@sky7st if you can provide a live example using CodePen/JS Bin or Stackblitz and report back with your link I can help you 😉


Add PHP 8.0, 8.1 and 8.2 to CI test range

Build on top of: https://github.com/Jan0707/phpstan-prophecy/pull/309
Diff:
https://github.com/Jan0707/phpstan-prophecy/pull/310/commits/b1ac773821710fe77f787047f13af61abf1035b3
TODO:

[ ] wait for #309 getting merged
[ ] rebase to master

close in favor of #351 thx @Jean85


Documentation isn't really clear for new setup

Not sure what category this should be in, but setting up a new instance is not terribly easy.
A few issues that could be better documented:

When creating a new instance and using CAS auth, you have to use your netid (or any cas username) as you login. The directions seem to say that you can just leave the password field blank, but with the wrong username you can't log in at all.
Possibly a better designed "error denied" page. I couldn't figure out why it failed for a while and had to dig through the database.
For some reason, when I created a new location and loc group I wasn't authorized to start a shift in it.  This is due to the can_signup? function in user.rb. I'm not exactly sure what the problem was but modifying the function to always return true made it work temporarily.
If you don't have a payform the app crashes. This is from app/views/payforms/show.html.erb

Explanations/Improvements for the few issues about setting up new instance:

We can add to the first-run page that if using CAS, you need to enter the correct netid as login
Maybe we should single out the "User netid not found in DB" scenario and have a special error page for that
this is due to "Permission" not set, and that is one thing I have in mind for a while now too. The user needs to have signup permission of the loc_group to be able to view open_signup slots in the shifts schedule. The way a user acquires a certain permission is through the roles it has. Each role has a set of permissions. One would expect a superuser to have all the permissions there are, but that is not the case, since no roles are defined yet after the first-run configuration, thus the superuser has no permissions. I would propose circumvent this by checking for superuser in every method like "can_signup?". As far as I know, these few predicates in user.rb are the only ones that do not check for superuser, that's why superusers can do most of things but not sign up for shifts.
Again, this is due to the fact that no roles have not been defined yet but the name of the role is requested in the payform view. Counter-intuitively, it is not due to non-existent payform, which I believe would give a 500 error.

One addition to the first-run script might be to create a location / loc group for the department; trying to start a shift and seeing a blank drop-down box is slightly counterintuitive.


QUIRK: Fix quickstart on webOS 3.x TVs QUIRK_DILE_VT_DESTROY_ON_STOP

In latest unicapture changes, we have changed how TVs powerstate is processed. In older versions we have used to completly stop capture on standby. Now we only stop capture and let capture interfaces in memory.
The problem with older webOS TVs is, that in standby it regardless kills hyperion-webos after awake, which leads to not fully shut down capture interfaces and because of that a new interface can't be created.
This PR will introduce another quirk QUIRK_DILE_VT_DESTROY_ON_STOP, which will destroy DILE_VT interface, when a standby is in progress, so it can be created on next TV awake, without the need of disabling QuickStart+ or completly reboot TV.
This addresses https://github.com/webosbrew/hyperion-webos/issues/95
@tuxuser Can you please review?

I've just realized we don't actually call capture_cleanup anywhere.
Wouldn't it make sense to implement this in unicapture.c instead?
We could add an extra "initialized" field into capture_backend_t that'd be set to true at the end of unicapture_init_backend on success (since we depend on init call for backend autodetection), then at the end of unicapture_run shutdown add apropriate backend->cleanup() calls, set that flag back to false, and add backend->init() call at the beginning of unicapture_run if said flag is false again. (aka. unicapture_run has been rerun once again)

@Informatic
Yeah, that was also something I have seen. In my first attempt I have also tried to do things like you have described, but to be honest I'm not that experienced and haven't managed to get something useful. I'm more in a manner of doing things in a trial and error way, so as I don't have a WebOS 3 TV, I'm a bit lost in testing changed things.
Because of this and the reason that no one else has tried to fix this issue, I have done it in this way.
I would appreciate your opinion in merging anyways and create a issue for this, so users can use this fix, while someone else might contribute in a correct way. Or otherwise, if you mean that we should keep things clean and in a correct way, but as a bummer that this issue might not be fixed in near future, as currently no one had time, or wanted to do this.

Not needed due to https://github.com/webosbrew/hyperion-webos/pull/105 Thanks @Informatic ! <3


bug(cfd-virtual-scroll-viewport): *ngIf with more than one condition problem

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Hi, if I try to use *ngIf on ng-container with 2 conditions (*ngIf="cfgPayrollTabel.salary !== false && !cols.allPayRollCounselor") I get this error: ERROR TypeError: Cannot read properties of undefined (reading 'headerCell')
With one condition it works perfectly...
Any way of fixing it?
Reproduction
Steps to reproduce:

Use CDK-virtual-scroll
Use a ngIf on a ng-container with more than 1 condition

Expected Behavior
Normal rendering of the table.
Actual Behavior
ERROR TypeError: Cannot read properties of undefined (reading 'headerCell')
Environment

Angular: 13.3.2
CDK/Material: 13.3.2
Browser(s): Chrome 100.0.4896.75
Operating System (e.g. Windows, macOS, Ubuntu): Windows 11 PRO

I can't reproduce this. Can you add a StackBlitz with your example?

Closing this issue due to no recent activity. If this issue still persists please create a new issue with a reproduction.


Library doesn't work on a Teensy 3.2 + ARM processors

Couldn't find anything about this, so I figured I'd post it here even though I solved the issue.
I tried using the library with a RN2903 and a Teensy 3.2 and I couldn't get it to work because all of the strings were corrupted and creating some other bizarre memory issues. I stripped out all of the AVR related PROGMEM statements and replaced the related functions like P_strcpy with their normal variants (strcpy) and the library works fine.
Here is the modified code if anyone needs it:
https://pastebin.com/gBdHCAMJ

Solved -- see above.


Update the e2e runner to be able to start and stop CometBFT testnet processes on non-local machines

Tasks:

[x]  Familiarize with PR tendermint/tendermint#9801
[x]  Clone it to Comet (merge to main)
[x] Drive it to completion, including any non-CI testing needed

[x] Refactor to enable start and stop (#796)
[x] Add the DO infra and test

#846
cometbft/qa-infra#16

DoD:

The Comet PR (cloned from tendermint/tendermint#9801), and subsequent PRs, are approved, tested, and merged

Original issue: tendermint/tendermint#9790

Closed by #796, #846, and cometbft/qa-infra#16


Update 'resin help envs' help message

The message suggests using the device name:
 --device, -d <device>                  device name

when it should prompt for device UUID.

@lekkas Fixed, thanks!


A few thoughts to improve the convenience and appearance

If you find my thoughts interesting, then I hope you will bring them to life :)

Make it possible to change the dimension of the sketch grid;
Add the ability to change the shape and edges of landscape sketches;
Add to the video player the ability to put the start button in the center of the screen, as well as start and stop the video with one click;
When viewing the album, put the album name instead of the word "collection", quick the menu that appears when the photo is selected, put it in the place where the album name is now.
That's it for now:) then maybe I'll add more

Make it possible to change the dimension of the sketch grid;

Are you talking about the thumbnails in the Collection page? If so, you can pinch-to-zoom on thumbnails to change their size.

Add the ability to change the shape and edges of landscape sketches;

I don't understand. Could you illustrate what you mean with a screenshot?

start and stop the video with one click;

You can enable double-tap to play/pause in the Settings > Video > Controls.

When viewing the album, put the album name instead of the word "collection",

I won't do that. It would be redundant with the album filter just below it.

"Are you talking about the thumbnails in the Collection page? If so, you can pinch-to-zoom on thumbnails to change their size." - unfortunately I have not found where this size changes
"I don't understand. Could you illustrate what you mean with a screenshot?"

here is a preview of the album and it would be nice to be able to change its shape
"You can enable double-tap to play/pause in the Settings > Video > Controls." - that's exactly what a double tap is, but I would like a single tap
"I won't do that. It would be redundant with the album filter just below it."

I think the screenshots show what I meant
in principle, I don't care, I suggested it, you didn't like it, close the topic.

Resizing thumbnails: https://www.swisstransfer.com/d/26cb44cb-7b27-4191-a3cf-104f8b0dfaec
As for the UI, thanks for the suggestions but I will leave it as it is.


Unbelievable values

Hello,
at first, thanks for your great work.
I use a SUN-12K-SG04LP3 and it works (almost) fine. Unfortunately, some values are absolutely unbelievable. I found this concerns  "SingleRegisterSensor" register with values they can become negative values. As example the battery  current in case of charging/discarding.
I cannot remember where, but somewhere I have read this values has to treated as signed integer.
I have made a short (and dirty) modification in "deye_sensor.py" in SingleRegisterSensor class.
This shows values they are more  trustful.
´´
retval = int.from_bytes(reg_value, 'big')
if retval>32767:
retval=retval-65536
#return int.from_bytes(reg_value, 'big') * self.factor + self.offset
return retval * self.factor + self.offset
´´
Best regards
Detlef

@DetlefR Yes, this sounds about right. I had a similar suspicion, and described it here https://github.com/kbialek/deye-inverter-mqtt/issues/47#issuecomment-1483890552
I do not own SG04LP3, so I couldn't verify it on my own. Now with your report I'm sure how to fix it. Thanks.

Fixed version is out https://github.com/kbialek/deye-inverter-mqtt/releases/tag/2023.03.4

I have tested it. For me, it's working well.
Thank you.
BTW: A wish for the next greater change. Please divide date from code. See deye_sensors_deye_sg04lp3.py. Put the config data to a separate file.


Flags not visible to some players

Most recently happened to zero. https://clips.twitch.tv/FilthyEntertainingChowderFreakinStinkin-vb35pzDpTtqUlVqM

Zero's not been able to reproduce this.  If you see this bug, please try to get your output_log immediately after the game it happens in, and post it here.

Happened again today to Zero on a different map.  We got an output_log! \o/
output_log.txt


Maintain section

Plan
Apply
Grow
Maintain (for the existing business owners)

Is this still on the table?

This would require a homepage redesign (among other things) for a fourth category/column of steps.


Deploy failed. No such file or directory

I'm using

rbenv, ruby 2.5.3
jets 1.3.6
bundler 1.17.2

global config 「BUNDLE_PATH: "vendor/bundle"」

Flow of reproduction

created Gemfile 「gem "jets"」in empty folder. And  bundle install
created skeleton jets project. bundle exec jets new v1 --mode api
cd v1
bundle exec jets deploy

Tidying project: removing ignored files to reduce package size.
bundler: failed to load command: jets (/Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/bin/jets)
Errno::ENOENT: No such file or directory @ rb_file_s_rename - (/tmp/jets/v1/stage/code/vendor/bundle/ruby/2.5.0, /tmp/jets/v1/stage/opt/ruby/gems/2.5.0)
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:471:in `rename'
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:471:in `block in mv'
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:1463:in `block in fu_each_src_dest'
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:1479:in `fu_each_src_dest0'
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:1461:in `fu_each_src_dest'
  /Users/user/.rbenv/versions/2.5.3/lib/ruby/2.5.0/fileutils.rb:460:in `mv'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/lambda_layer.rb:34:in `move_vendor_to_opt'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/lambda_layer.rb:18:in `build'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/code_builder.rb:114:in `build_lambda_layer'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/code_builder.rb:104:in `code_finish'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/code_builder.rb:42:in `block in build'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/code_builder.rb:38:in `chdir'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/builders/code_builder.rb:38:in `build'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/build.rb:26:in `build_code'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/deploy.rb:50:in `build_code'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/deploy.rb:29:in `run'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/main.rb:21:in `deploy'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/base.rb:38:in `dispatch'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/commands/base.rb:27:in `perform'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/cli.rb:21:in `start'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/lib/jets/cli.rb:5:in `start'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems/jets-1.3.6/exe/jets:14:in `<top (required)>'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/bin/jets:23:in `load'
  /Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/bin/jets:23:in `<top (required)>'

When I comment out 'tidy' function,  deploy succeed.
https://github.com/tongueroo/jets/blob/master/lib/jets/builders/ruby_packager.rb#L31

Thanks for providing so much debugging details. Unbelievably, I was not still able to reproduce even with all of your great details. 🤦🏻♂
Unsure why uncommenting out the call to tidy fixes it 🧐  The stack error says:
Errno::ENOENT: No such file or directory @ rb_file_s_rename - (/tmp/jets/v1/stage/code/vendor/bundle/ruby/2.5.0, /tmp/jets/v1/stage/opt/ruby/gems/2.5.0)

So the complaint is about a missing folder, even though commented out tidy fixed the issue?
There's a call to created the destination parent directory: FileUtils.mkdir_p(File.dirname(gems))  here: https://github.com/tongueroo/jets/blob/40ee8bb36673fd4cb7f60837b13d28effe4977d0/lib/jets/builders/lambda_layer.rb#L33 So we know the destination folder exists. It seems like the source folder doesn't exist. Tried reproducing with the clues from the details above and no luck yet.
The bundler config gives me an idea though:

bundler 1.17.2

global config 「BUNDLE_PATH: "vendor/bundle"」

Wondering since Jets bundles also to the vendor/bundle, if that somehow screws things up.  Wanted to avoid the possible collision anyway, so went ahead and moved the path where the gems get bundled into by Jets to vendor/gems instead in this PR #100.
Went for it and released it and am interested in seeing if this fixes this odd issue. Can you give Jets v1.3.7 CHANGELOG a try and see if it helps?
If that does not work, can you try to unset your bundle config global BUNDLE_PATH value. Wondering if that is somehow related.
Could be completely on an incorrect path here also. Still unsure why commenting out tidy for you fixed the issue. 🤔  Thanks for helping.

So read through the issue again. This stood out.
bundler: failed to load command: jets (/Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/bin/jets)

Thinking that by moving the bundling of the gems from vendor/bundle to vendor/gems in #100 In theory, this should fix it.  Let's see. Interested to see when you get a chance to test it out. Thanks!

Closing this out to keep tickets tidy. Feel free to open if it's still an issue.

@tongueroo
Thank you for quick response!
I recreated projects by 'jets 1.4.0' but, have another error message.
Bundle complete! 8 Gemfile dependencies, 52 gems now installed.
Gems in the groups development and test were not installed.
Bundled gems are installed into `/tmp/jets/v1/cache/vendor/gems`
Bundle install success.
Tidying project: removing ignored files to reduce package size.
=> rsync -a --links /tmp/jets/v1/stage/code/vendor/gems/ruby/2.5.0/ /tmp/jets/v1/stage/opt/ruby/gems/2.5.0/
rsync: link_stat "/tmp/jets/v1/stage/code/vendor/gems/ruby/2.5.0/." failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at /BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-52.200.1/rsync/main.c(996) [sender=2.6.9]
rsync -a --links /tmp/jets/v1/stage/code/vendor/gems/ruby/2.5.0/ /tmp/jets/v1/stage/opt/ruby/gems/2.5.0/ failed to run.
/Users/uxmobile/Desktop/sasry-server/api/vendor/bundle/ruby/2.5.0/gems/jets-1.4.0/lib/jets/builders/lambda_layer.rb:33:in `rsync_and_link'

Is this case, folder permission?

tmp/jets/v1/cache  directory is complete bundle installed.
tmp/jets/v1/stage/code/vendor directory is empty.
tmp/jets/v1/stage/opt/ruby/gems/2.5.0 directory is empty.

I forgot to write it.

OS: mac OS Mojave 10.14.2

@s1140227 Thanks for debugging info! 👍
Wondering what's in the /tmp/jets/v1/cache folder?
It's weird that both /tmp/jets/v1/stage/code/vendor and /tmp/jets/v1/stage/opt/ruby/gems/2.5.0 are both empty. This seems to indicate the /tmp/jets/v1/cache/vendor/gems might not exist.
Jets copies the gems from /tmp/jets/v1/cache/vendor/gems to /tmp/jets/v1/stage/code/vendor/gems earlier in the process before later moving things around and setting up the structure for AWS Lambda.
https://github.com/tongueroo/jets/blob/master/lib/jets/builders/ruby_packager.rb#L172-L175
You can see that it will only copy the vendor/gems folder though if it exists. So wondering what's in the /tmp/jets/v1/cache folder.

@tongueroo Thank you for your reply!
/tmp/jets/v1/cache include

.bundle
Gemfile
Gemfile.lock
vendor/gems/ruby/2.5.0/... (bin, build_info, cache, doc, extensions, gems, specifications)

The list of gem files is different.
/tmp/jets/v1/cache/vendor/gems/ruby/2.5.0/gems/
actionpack-5.2.2		aws-sdk-sqs-1.10.0		mimemagic-0.3.3
actionview-5.2.2		aws-sigv4-1.0.3			mini_portile2-2.4.0
activemodel-5.2.2		builder-3.2.3			minitest-5.11.3
activerecord-5.2.2		colorize-0.8.1			mysql2-0.5.2
activesupport-5.2.2		concurrent-ruby-1.1.4		nokogiri-1.9.1
arel-9.0.0			crass-1.0.4			rack-2.0.6
aws-eventstream-1.0.1		dotenv-2.5.0			rack-test-1.1.0
aws-partitions-1.127.0		erubi-1.8.0			rails-dom-testing-2.0.3
aws-sdk-apigateway-1.23.0	gems-1.1.1			rails-html-sanitizer-1.0.4
aws-sdk-cloudformation-1.14.0	hashie-3.6.0			railties-5.2.2
aws-sdk-cloudwatchlogs-1.12.0	i18n-1.3.0			rake-12.3.2
aws-sdk-core-3.44.1		jets-1.4.0			recursive-open-struct-1.1.0
aws-sdk-dynamodb-1.19.0		jmespath-1.4.0			text-table-1.2.4
aws-sdk-kms-1.13.0		kramdown-1.17.0			thor-0.20.3
aws-sdk-lambda-1.16.0		loofah-2.2.3			thread_safe-0.3.6
aws-sdk-s3-1.30.0		memoist-0.16.0			tzinfo-1.2.5
aws-sdk-sns-1.9.0		method_source-0.9.2

/Users/user/Desktop/project/api/vendor/bundle/ruby/2.5.0/gems
actionpack-5.2.2		capybara-3.12.0			nokogiri-1.9.1
actionview-5.2.2		colorize-0.8.1			public_suffix-3.0.3
activemodel-5.2.2		concurrent-ruby-1.1.4		rack-2.0.6
activerecord-5.2.2		crass-1.0.4			rack-test-1.1.0
activesupport-5.2.2		diff-lcs-1.3			rails-dom-testing-2.0.3
addressable-2.5.2		dotenv-2.5.0			rails-html-sanitizer-1.0.4
arel-9.0.0			erubi-1.8.0			railties-5.2.2
aws-eventstream-1.0.1		gems-1.1.1			rake-12.3.2
aws-partitions-1.127.0		hashie-3.6.0			recursive-open-struct-1.1.0
aws-sdk-apigateway-1.23.0	i18n-1.3.0			regexp_parser-1.3.0
aws-sdk-cloudformation-1.14.0	jets-1.4.0			rspec-3.8.0
aws-sdk-cloudwatchlogs-1.12.0	jmespath-1.4.0			rspec-core-3.8.0
aws-sdk-core-3.44.1		kramdown-1.17.0			rspec-expectations-3.8.2
aws-sdk-dynamodb-1.19.0		launchy-2.4.3			rspec-mocks-3.8.0
aws-sdk-kms-1.13.0		loofah-2.2.3			rspec-support-3.8.0
aws-sdk-lambda-1.16.0		memoist-0.16.0			shotgun-0.9.2
aws-sdk-s3-1.30.0		method_source-0.9.2		text-table-1.2.4
aws-sdk-sns-1.9.0		mimemagic-0.3.3			thor-0.20.3
aws-sdk-sqs-1.10.0		mini_mime-1.0.1			thread_safe-0.3.6
aws-sigv4-1.0.3			mini_portile2-2.4.0		tzinfo-1.2.5
builder-3.2.3			minitest-5.11.3			xpath-3.2.0
byebug-10.0.2			mysql2-0.5.2

That's really strange that the list of gems is different. Think bundler is always installing them into current folders vendor/bundle vs in the cache area. So it seems like BUNDLE_IGNORE_CONFIG is  not working 😔
https://github.com/tongueroo/jets/blob/3e007d4dc853f1c3bdc679253862a9a728eb5854/lib/jets/builders/ruby_packager.rb#L57
Wondering if there is something funny with Jets and how bundler is set up on your environment. 🧐 Would like to see if we can eliminate your bundler environment. Wondering if you can you make a backup of your ~/.bundle folder.
 mv ~/.bundle ~/.bundle.backup

Then open up a new terminal and try a jets deploy with what I'm hoping is a completely clean bundler environment.
Would actually like to dig into the issue if it turns out that its the specific bundler environment on your setup. But let's see if we can eliminate it first.
When you're done just restore your bundler env:
mv ~/.bundle.backup ~/.bundle

Also, can you post your bundle env? Thanks again for providing helpful debugging information, even though we haven't nailed this one down yet. 🤔

Oh duh. The gem list files should be different because jets runs bundle install --without development test. So a different gem list is a just red herring.
Anyway, let’s try a clean bundler environment.

@tongueroo
yep. my projects directory include development libs, but tmp directory not include.
I recreated project and, removed local bundler settings.
Deploy succeed!
Thank you your support.


carousel: new component

Design: https://www.figma.com/file/NkNv37AVyGdeCa62CEBiOtOl/DS-Carousel?node-id=0%3A1

Design decision input doc: https://docs.google.com/document/d/1Kp1pwSNz7laU0-HD-t4VqAJvG1YyYwM01ObsJ4M36fs/edit?ts=5ce44c38#

Design review

S/M/L sizes on Carousel - drive the min/max on grid cells
TODO: Brian/Dmitry - decide on S/M/L mins/maxes
Show as many items as mins on items will allow
Items in a carousel all the same width
Left-aligned in grid cell
Right-Arrow right-aligned with carousel list container
Partial pages - use blank space, even on first page
Transition - slide, decide easing
Gutter - fixed
Height determined by items, no constraints
Gestures - likely equals a click effect; explore, maybe dev limitations

Questions

Paging button hover/focus state, transitions?
Smaller arrows on smaller screens?

Later (or never 🤷♂):

Paging UI - is it helpful? deal-breaker to Home for some reason?
Multi-row pages
Loading states
Empty items
Start over

Todo

When figma updated, that's the src of truth.


 This is to compare with #432 and make an informed decision on which tools to use for load testing.
This PR only handles load testing instrumentaiton and do not involve:

Adding new metrics
Enancing the AppGate Server supplier selection strategy (which is needed to distribute the load across RelayMiners

Issue

#20

Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[ ] Unit Tests: make go_develop_and_test
[ ] LocalNet E2E Tests: make test_e2e
[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
[ ] Documentation changes: make docusaurus_start

Sanity Checklist

[ ] I have tested my changes using the available tooling
[x] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[x] I create and referenced any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

It appears that there are some challenges w.r.t. using k6 to implement our load testing plans executions, with the most impeding ones being:
Shared mutable state
There seems to be no way to share mutable state across different scenarios or VUs. This is helpful to:

Inform the sendRelay scenario of the available gateways and applications  to use since those are changing throughout the test progression.
Inform the applications about the gateways to delegate to

Unreliable plugins
The plugins needed to execute the staking actions do not behave as desired:

We need the avitalique/xk6-file plugin to write staking configuration files before execution the stake command. It seems that this function does not block until the file is effectively written, leading to the poktrolld tx <actor> stake-<actor> command to fail because of a lacking config file. A sleep command was needed to ensure that the file was created.
We need the grafana/xk6-exec plugin to execute poktroll and ignite. This plugin offer a command function that does not provide a way to catch a command error or to get the stderr output. Making the scenario relying probing the command's output, loops and sleeps

New block/event info
There is no way to  (globally/not per iteration) listen for blocks or transactions. The poktrolld tx commands rely on blocks duration to estimate when a transaction has been committed on-chain and proceed with the next step.
Lack of precise iteration count needed to stake the actors.
Only one execution plan (per-vu-iterations) seems to fit that use case, as we need a precise number contrary to other scenarios (sendRelay) where losing a few iterations is not as critical.

Closing it in favor of #432


flac feature name

Currently reads:
Friendly name: Flattened ascent forms
Should be:
Friendly name: Flattened accent forms

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fb16259e-1f7c-4e96-02b8-f692eb3e77e7
Version Independent ID: eab1b2c5-0209-ccdf-b898-bbc5b5dbbe0f
Content: Registered features, f-j (OpenType 1.9) - Typography
Content Source: typographydocs/opentype/spec/features_fj.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: alib

Or, indeed
Friendly name: Flattened Accent Forms
for consistency in capitalisation with other feature names.

Already reported in https://github.com/MicrosoftDocs/typography-issues/issues/1013

Duplicate, so closing.


Fix inconsistency of utilities names in the documentation

This is a documentation issue.
In the README file, the name of the utilities does not always match the name of the actual python script.
For example, the utility sbol-converter is actually being handled by the script conversation.py.
So it is either changing the script name, or its reference in the documentation - @jakebeal is there a guideline or something?
I think it would be better to change the script name, if we want to keep the utilities names consistent with the "SBOL-" prefix. But it could be ugly to change a script name, so whatever you prefer...

This is a good question, @karin-sionov . The names of the command-line utilities are being set in setup.py, which gives the names for "wrapper" scripts that call functions in packages.
For example, sbol-converter is defined on this line as a call to the main function in sbol_utilities.conversion:main. The next few lines define the other converter utilities as calls to other entry-point functions in the same Python module.
https://github.com/SynBioDex/SBOL-utilities/blob/3fa0f3a2bac2833f82c486a6cfb0d66660963ceb/setup.py#L48-L54
Clearly the either the current naming scheme or its documentation could be improved. What do you think would be a good approach?

@karin-sionov, @jakebeal some utility names are descriptive like sbol2to3 but we can name it sbol2-to-sbol3 to make it more clear, others like sbol2fasta may be confusing because we have sbol2, so I suggest making it sbol-to-fasta

@ahmedtarek26 That sounds like a reasonable proposal. Want to set up a pull request for that change?

@karin-sionov, @jakebeal I did a pull request for that changes, have a look at it, and if there are more suggestions I'm waiting to hear them.


Superhost is not allowed to login if the host IPAddress is not allowed in IPFilter

Description of Problem
Enable IP Filter and restrict the IP Address to particular IP. Try to login with superhost user. Login is denied.
Proposed Solution Option 1
Superhost user should supersede IP Filter restriction.
Affected version

[x] 10.0.0 nightly build
[x] 9.4.1 nightly build
[ ] 9.4.0 release candidate
[ ] 9.3.2 latest supported release

I am pretty sure this is by design and is a security feature, if I am wrong @dnnsoftware/tag please comment.


Bitbucket Auth Provider docs

Description
Added the documentation for Bitbucket Authentication (implemented in https://github.com/pusher/oauth2_proxy/pull/201)
Motivation and Context
By looking at the documentation itself it's not clear if Bitbucket is supported or not. I also struggled to select proper scope for the App. Hopefully this short documentation section will save others time.
How Has This Been Tested?
Reviewed with make serve
Checklist:

[ ] My change requires a change to the documentation or CHANGELOG.
[ ] I have updated the documentation/CHANGELOG accordingly.
[x] I have created a feature (non-master) branch for my PR.

The GitHub line suggestion system is broken for me so I'll leave the comment here.
docs/2_auth.md L349 should look like this:
* In "Callback URL" use `https://<oauth2-proxy>/oauth2/callback`, substituting `<oauth2-proxy>` with the actual hostname that oauth2_proxy is running on.

Typo fixed, thanks!


MAISTRA-2274: Workaround client-go issue 91073

workaround client-go issue

/retest

/test integration

/test integration

/test integration

/test integration

/test integration


Class called Entity or Concept - fix inconsistency

When creating a Class, it should be called a Class.
Not an Entity

Not a Concept

The same in modification dialogs


[stable/jenkins] Add Kubernetes plugin parameters

Signed-off-by: Bryan Hunt<EMAIL_ADDRESS>
Is this a new chart
No
What this PR does / why we need it:
It add additional configuration parameters to the Kubernetes plugin
Which issue this PR fixes

fixes # 22212

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign wmcdona89

Please also update the CHANGELOG

I've made most of the changes requested.  I need to resolve the question on the JENKINS_URL environment variable and default provider template with a co-worker when they get in.

I think I've got all the requested changes in.  I still need to test locally and resolve the changelog conflict.

My co-worker has a couple of issues that need to be sorted out.  Please don't merge this just yet.

We are good to merge with my last fix if y'all are.

Did something go wrong with the rebase?  Why are there so many commits?  Sorry, I'm not a git expert :(

what you pushed looks more like a merge than a rebase. are you aware of git push --force-with-lease?
first ensure your fork is up to date. see Syncing a fork or Syncing your fork to the original repository via the browser.
then try the following...
git fetch
git rebase -Xtheirs origin/master
# if the previous CHANGELOG entry was deleted, replace it and commit
git push --force-with-lease

this article explains -Xtheirs

I'm getting error messages about cherry picking and could not apply a commit.  I'm going to close this and start over.  That will be like 10x faster than trying to fix whatever git did.

I'm getting error messages about cherry picking and could not apply a commit. I'm going to close this and start over. That will be like 10x faster than trying to fix whatever git did.

@BryanHunt good idea. please link to #22276 for reference. and one more request here if you don't mind.


Add support for TLS-enabled Cassandra configurations

What was changed
We add support for TLS-enabled Cassandra-based persistence stores.
Why?
Production best practices prescribe TLS-enabled connections wherever available, and Cassandra databases offer this feature.  This patch allows consumers of the Temporal helm-chart to configure TLS-enabled Cassandra clusters as a persistence store using established idioms such as additionalVolume configuration.  We also extend the mechanism for setting admintools environment variables like TLS support for SQL databases.

Sorry for the delay here, please re-base and I'll get this merged.

@robholland I used the GH UI interface to resolve the conflcts, and it created a merge-record.  If accepted, please squash-merge this PR. I'm happy to re-do it on my workstation if preferred.  Ty!


bug: prefixItems schema does not evaluate

The following schema does not produce an error as expected where idddd is an additional property.  Is this a bug or is my schema wrong?
{
    "$id": "https://www.freecodecamp.org/classroom/userDataRequest",
    "$schema": "https://json-schema.org/draft/2020-12/schema",
    "title": "UserDataRequest",
    "description": "Queries a collection of users and certifications",
    "users": {
        "type": "array",
        "uniqueItems": true,
        "prefixItems": {
            "type": "object",
            "additionalProperties": false,
            "properties": {
                "id": {
                    "type": "string"
                }
            }
        },
        "items": {
            "description": "name of the certification block",
            "type": "string",
            "pattern": "^[A-Za-z][\/A-Za-z0-9-]*[A-Za-z]$"
        }
    },
    "required": ["users"]
}

{
  "users": [
    {
      "idddd": "123456"
    },
    "2022/responsive-web-design",
    "quality-assurance"
  ]
}

I missed the root level properties definition
also the prefixItems is an array schema.


Upgrade to PyTorch 1.10

Package upgrade. By default, models are now non-deterministic. With the deterministic flag set to True, training times for the Prostate model went from 280 sec/epoch to 360 sec/epoch. All PR models are still built deterministically.
Please follow the guidelines for PRs contained here. Checklist:

[ ] Ensure that your PR is small, and implements one change.
[ ] Add unit tests for all functions that you introduced or modified.
[ ] Run PyCharm's code cleanup tools on your Python files.
[ ] Link the correct GitHub issue for tracking.
[ ] Update the Changelog file: Describe your change in terms of
Added/Changed/Removed/... in the "Upcoming" section.
[ ] When merging your PR, replace the default merge message with a description of your PR,
and if needed a motivation why that change was required.

Putting that on hold.


CI: k8s upstream tests failing in session affinity test cases

Example failures:
https://jenkins.cilium.io/job/cilium-master-K8s-Upstream/485/execution/node/67/log/
https://jenkins.cilium.io/job/cilium-master-K8s-Upstream/484
https://jenkins.cilium.io/job/cilium-master-K8s-Upstream/483
https://github.com/cilium/cilium/pull/13480 was supposed to help here, but the test still failed: https://jenkins.cilium.io/job/Cilium-PR-Kubernetes-Upstream/2601/

A few datapoints - it seems to be a new test. Also, it's worth checking whether the affinity was indeed enabled by #13480.


[sepolia] deploy revshare contracts to sepolia

Similar to this task https://github.com/base-org/contract-deployments/tree/main/goerli/2023-08-23-deploy-revshare, to deploy revenue share contracts to sepolia.
The contracts are identical to the goerli contracts.
Deployed contracts:

BalanceTracker: https://sepolia.etherscan.io/address/0x3a92d1b1df54870245eff0c8b1a2ebf16d997caa
BalanceTrackerProxy: https://sepolia.etherscan.io/address/0x8D1b5e5614300F5c7ADA01fFA4ccF8F1752D9A57
FeeDisburser: https://sepolia.basescan.org/address/0xCA9be02F8e417D20f33551BA22ddf3f7623FB345
FeeDisburserProxy: https://sepolia.basescan.org/address/0x76355A67fCBCDE6F9a69409A8EAd5EaA9D8d875d

In addition, added another script UpdateFeeVaultRecipient.s.sol to deploy new L2 fee vaults contract in order to point the recipients to the FeeDisburser. This is needed since recipient is immutable.
This script needs to be ran by the ProxyAdmin.

Review Error for mdehoog @ 2024-01-29 19:00:51 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


global search does not work

hi zepernick,
libary that you create is very helpful for me in making program, I am very grateful for your libary,
but there I want to ask why the global search does not work ??
While some individual columns searches can work.
sorry if my english is not good, I hope you understand my question.
regards
karel

hi zepernick,
sorry I used your old libraries from www.paulzepernick.com/ci-zepernick.
after I use your new libraries  global search, it has been functioning well.
thank you very much for your libraries
regards
karel


add ExampleEncode function

今天写文档的时候发现漏了一个Example

Codecov Report

Merging #1795 (3628b1e) into master (793e862) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
- Coverage   71.27%   71.16%   -0.12%
==========================================
  Files         452      459       +7
  Lines       43336    43571     +235
==========================================
+ Hits        30889    31008     +119
- Misses      10470    10570     +100
- Partials     1977     1993      +16

Flag
Coverage Δ

go-1.15
?

go-1.16
71.13% <ø> (-0.12%)
:arrow_down:

go-1.17
71.15% <ø> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

database/gdb/gdb_core_ctx.go
60.86% <0.00%> (-31.44%)
:arrow_down:

os/glog/glog_logger_level.go
40.00% <0.00%> (-24.00%)
:arrow_down:

os/gspath/gspath_cache.go
75.43% <0.00%> (-19.30%)
:arrow_down:

os/gsession/gsession_storage_file.go
45.96% <0.00%> (-16.54%)
:arrow_down:

os/gsession/gsession_storage_memory.go
76.92% <0.00%> (-14.75%)
:arrow_down:

errors/gerror/gerror_error.go
61.44% <0.00%> (-4.25%)
:arrow_down:

util/guid/guid.go
88.23% <0.00%> (-4.08%)
:arrow_down:

database/gdb/gdb_model_update.go
76.62% <0.00%> (-2.25%)
:arrow_down:

database/gdb/gdb_model_cache.go
64.86% <0.00%> (-1.81%)
:arrow_down:

os/gsession/gsession_session.go
56.63% <0.00%> (-1.63%)
:arrow_down:

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793e862...3628b1e. Read the comment docs.


Allow using collier provided externally

collier (version 1.2.4) is available in LCG software stacks†, so there is no need to build it if this environment is used. This commit will skip the build of collier if environmental variable COLLIER_ROOT_DIR is set. In that case the rest of JHUGenMELA will assume that the interface modules and the shared library of collier are located within directories $COLLIER_ROOT_DIR/include and $COLLIER_ROOT_DIR/lib respectively. If this variable is not set, collier will be built in place as before.
Skipping compilation of collier reduces the total build time (run in one thread) from 470 to 310 s.
I checked that the package compiles both when COLLIER_ROOT_DIR is set and not set. After building with COLLIER_ROOT_DIR, all tests in test/testME_all.py succeed.
†This works with LCG_97a and later. collier was included also in earlier releases, but they missed collier.mod interface module.

Hi @andrey-popov
I think it is better to keep the build customized because Fortran interface to C++ might depend on what flags are used. This is why we have our own makefile to control the compilation a bit more strictly than to rely on externally-provided libraries (just like MCFM).

But if JHUGenMELA compiles successfully, doesn't this mean that there are no problems in the interface with Fortran?

Right now, it might (and the main reason is probably because there is no C-interface done yet to COLLIER itself; it is in the plans though), but if the flags change, causing changes in the expressions of the functions in the library (e.g. when you run 'nm'), then linking via extern statements in the interface would need to be modified for how many underscores are needed (and where), logical -> bool vs int C correspondence etc. (see for example interface/TMCFM.hh vs interface/TModJHUGen.hh). Using an externally-compiled library would not be sustainable for this reason; this is why we choose the flags to fix the interface details explicitly.

Sorry, meant to point to interface/TModJHUGenMELA.hh, which illustrates the logical->int type of interface need, not interface/TModJHUGen.hh.

BTW, I think it is good that you point there is v1.2.4 available. We should probably test that for compatible results and upgrade to it.

Are you saying that Fortran doesn't provide a stable interface with C? That's unfortunate… Feel free to close my PR then.

There are certain basic rules, but the signature of the functions in the libraries might change depending on the flags. This is where dependency on the flags come in. There are also differences between F77 vs F90+ interfacing details as you might have noticed (necessarily because of how Fortran modules operate wrt plan Fortran functions), but that is more stable since the Fortran code written in F77 or F90 rarely changes its language type (not that it doesn't ever happen though).


Add be_deadable matcher and fix RSpec

Add the RSpec dependency needed in order to fix Rspec-Sidekiq tests.
Add be_dadable matcher & tests
Make little refactoring

Thanks to @pavel-jurasek-bcgdv-com for the support/help.

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.361% when pulling f5e4d0a12f56a59def4981d6d85902c4292a19cd on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.361% when pulling 948d4cf0583a4973e62ff90aa2993a013e427c72 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.375% when pulling b686a6dc43273df338aaec87a734983a4f5a17aa on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.4%) to 97.389% when pulling ea1621aacd49fb8c23818efaa4d54abbd7aafd34 on nelantone:Add_deadabiity_matcher_and_fix_rspec into e5ede7a6812dcd307733e7d6504b96c3b47ffd37 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.2%) to 97.375% when pulling c07556322488e16b8f0b0e5d62ebf59dc0b9d20d on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling 78ad38d1bad81852a1bd75b2515bc0f7753d453a on nelantone:Add_deadabiity_matcher_and_fix_rspec into fd6ffa7564931aba67db76f52f5fb06327af0395 on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

Coverage increased (+0.1%) to 97.34% when pulling c13ab30b279d961b061ceb425ac767840498e9da on nelantone:Add_deadabiity_matcher_and_fix_rspec into 7efdfd7a419716040b221017f89ccbf4f591204c on philostler:develop.

Hi @packrat386 & @mathieujobin,
We know it sounds weird but explains much better what the test is doing checking be_dead.
be_dead sounds like you are testing if the job is dead.
But what we want to do is different. we are checking if the class has the option :dead
Of course we are open to discuss about it and we will be happy to read some feedback for you guys.
Thanks :)

Hi guys! @packrat386 @mathieujobin Let me know if I can help you somehow in order to change and hopefully merge this branch :).

@philostler do you have some news about this PR ?
Actually I'm using 'be_deadable' and I'm looking froward to take out from my code and use it from the rspec-sidekiq gem.
Waiting for some feedback & hopefully to be able to :shipit:  :)

Thanks for keeping this up to date, I should be able to take a look at it soon.

#119 is merged if you want to rebase this, but every time I come back to this, it seems like a lot of framework for a matcher to essentially just check what's in the job options. Can you not just do expect(JobClass.get_sidekiq_options[:dead]).to be_truthy?


Remove duckdb as libapi dependency

Remove duckdb from libapi by moving the function duckdb_connect to the "search" service.
In the future, if this function is required by other components, I would suggest to create a new duckdb-specific lib, so that we decouple API and DuckDB functionalities.
Additionally update all components that depend on libapi and remove their dependency on duckdb if they do not need it. These are:

admin
api
rows
sse-api

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bdf7951) 87.04% compared to head (579feac) 89.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
+ Coverage   87.04%   89.64%   +2.60%
==========================================
  Files          43      163     +120
  Lines        2531     9289    +6758
==========================================
+ Hits         2203     8327    +6124
- Misses        328      962     +634

Flag
Coverage Δ

jobs_cache_maintenance
95.32% <ø> (?)

jobs_mongodb_migration
86.32% <ø> (?)

libs_libapi
88.50% <ø> (ø)

libs_libcommon
92.35% <ø> (?)

services_admin
85.91% <ø> (?)

services_api
86.79% <ø> (ø)

services_rows
85.55% <ø> (ø)

services_search
81.20% <100.00%> (+0.38%)
:arrow_up:

services_sse-api
94.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

services/search/src/search/duckdb.py
100.00% <100.00%> (ø)

services/search/src/search/routes/filter.py
53.08% <100.00%> (+0.58%)
:arrow_up:

services/search/src/search/routes/search.py
62.50% <100.00%> (+0.47%)
:arrow_up:

... and 119 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🐛 [firebase_auth_web] Phone Auth reCAPTCHA hangs when clicking outside the reCAPTCHA modal

Bug report
When using Flutter Web Firebase Phone authentication and a reCAPTCHA modal dialog shows, you can hang the app by clicking outside the modal instead of solving the CAPTCHA.
The modal will close and the app will keep on waiting forever.
Steps to reproduce
Steps to reproduce the behavior:

call var confirmation = await FirebaseAuth.instance.signInWithPhoneNumber(testPhoneNumber);
click outside reCAPTCHA modal in case it shows
wait forever.

Expected behavior
The call should return either will NULL or by throwing an error.
Sample project
This problem only shows on a real Firebase instance, not with the emulator. Here is an example project that you just need to link up with an instance to test the issue.
https://github.com/Aurangseb/firebase_auth_web_recaptcha_problem
The problem occurs here:
                  try {
                    setState(() => _calling = true);
                    log.info('signInWithPhoneNumber called for $testPhoneNumber...');
                    var confirmation = await FirebaseAuth.instance.signInWithPhoneNumber(testPhoneNumber);
                    log.info('returned from signInWithPhoneNumber: ${confirmation.toString()}');
                  } catch (err, stack) {
                    log.shout('signInWithPhoneNumber failed', err, stack);
                  } finally {
                    setState(() => _calling = false);
                  }

signInWithPhoneNumber will never return when clicking outside the modal.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.16.2, on Microsoft Windows [Version 10.0.19045.3930], locale en-PK)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    ! Some Android licenses not accepted. To resolve this, run: flutter doctor --android-licenses
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.0.5)
[!] Android Studio (version 3.5)
    X Unable to determine bundled Java version.
[√] Android Studio (version 2023.1)
[√] IntelliJ IDEA Ultimate Edition (version 2023.3)
[√] VS Code, 64-bit edition (version 1.85.1)
[√] Connected device (3 available)
[√] Network resources

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.2.2
Flutter SDK 3.16.2
firebase_auth_web_recaptcha_problem 1.0.0+1

dependencies:
- cupertino_icons 1.0.6
- firebase_auth 4.16.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.24.2 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math web sky_engine]
- logging 1.2.0

dev dependencies:
- flutter_lints 2.0.3 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math async boolean_selector characters collection material_color_utilities meta source_span stream_channel string_scanner term_glyph web]

transitive dependencies:
- _flutterfire_internals 1.3.16 [collection firebase_core firebase_core_platform_interface flutter meta]
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- collection 1.18.0
- fake_async 1.3.1 [clock collection]
- firebase_auth_platform_interface 7.0.9 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.8.13 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser js meta]
- firebase_core_platform_interface 5.0.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.10.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math web]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- js 0.6.7 [meta]
- lints 2.1.1
- matcher 0.12.16 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.5.0 [collection]
- meta 1.10.0
- path 1.8.3
- plugin_platform_interface 2.1.8 [meta]
- sky_engine 0.0.99
- source_span 1.10.0 [collection path term_glyph]
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.6.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- typed_data 1.3.2 [collection]
- vector_math 2.1.4
- web 0.3.0

Reproducible using the plugin example app.
https://github.com/firebase/flutterfire/assets/88313112/8cbc7dc5-79f3-4c1a-a970-4c3c00abb151
cc @russellwheatley

We already have an open issue for this: https://github.com/firebase/flutterfire/issues/9489


GitHub Secret Names

It probably makes sense to keep this PR in a draft state until we've got Maven Central release working for this project, as it may need additional details adding as we discover new things.

Relates to https://github.com/ably/ably-asset-tracking-android/issues/318


I18n: improve handling of "default" text-domain

PR #1141 changed the behaviour of the I18n sniff to ignore a missing text domain argument if default was one of the allowed text-domains.
This was overshooting a little as this effectively disabled the complete "missing domain argument" check if default was one of the passed text-domains.
This PR changes that behaviour as well as addressing the remaining comment made in the original PR:

If the text_domain in the ruleset is default and the $text_domain has explicitly been set to default as well, then this would seem like a good redundancy warning to trigger, though it shouldn't be an outright error.
I would like to suggest making it a fixableWarning in that case.

Ref: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1141#issuecomment-329317824
If default is the only text-domain set in the ruleset:

The sniff will now not trigger an error for a missing text-domain (= same as in PR #1141).
Trigger an auto-fixable warning about the text-domain argument being redundant when the text-domain in a gettext function call is explicitly set to default.

If default is one of an array of text-domains set in the ruleset:

The sniff will now trigger a warning instead of an error for a missing text-domain. The warning has a slightly different error message and a different error code. This fixes the "overshooting".

Additionally, this PR also:

Fixes a potential "undefined index" notice for line 375.
Reduces some code duplication in the examination of text string tokens.

Includes adjusted unit tests.
Fixes #1212

:blush:


Support Enum types

In addition to supporting plain Python enum types, we could provide EnumObject for scenarios where more graphql-specific enum type is needed (eg. to include directives, extend existing type, create GraphQL enum that's only a subset of python enum).

Done in #32