Not reporting tsc compile errors correctly in the problems view

From @httpdigest on September 21, 2016 15:49

VSCode Version: 1.6.0-insider (commit: 90dda7af)
OS Version: Windows 7 x64

Steps to Reproduce:

Create a project with Angular CLI
Observe, that the tsconfig.json is not in the root directory of the project, but under src/
Add a readonly class member field "readonly readOnlyProperty" to a class
Add a method to this class which assigns to this.readOnlyProperty
Observe that the editor does not flag this as an error
Add a typescript compilation task in Visual Studio Code with "args": ["-p", "src"]
Execute that task
Observe that there is no error output
Execute tsc -p src from the command line (using the same tsc version)
Observe that the "assignment to readonly field" error is shown

Also, it looks like other errors, such as real syntax errors, are only reported as warnings in the Visual Studio Code editor "problems" view, whereas the tsc command line compiler flags them as real errors.
It might have something to do with the tsconfig.json file not residing under the root of the project, but inside the "src/" directory, as seems to be best-practice with Angular 2 projects. At least this is how Angular CLI creates the project.
Copied from original issue: Microsoft/vscode#12390

From @chrmarti on September 21, 2016 18:29
I've added this class to the main.ts of a new created Angular2 project:
class MyClass {
  public readonly foo = 2;
  public bar() {
    this.foo = 3;
  }
}

That correctly shows an error in the editor. I chose to use Typescript 2.0.2 when asked by VS Code if I wanted to use the version installed in the workspace. Which version of Typescript are you using?

From @httpdigest on September 21, 2016 18:53
It happens with both 2.0.2 and the latest 2.1.0-dev.20160921.
I narrowed it down to the following case:

add a folder app/ under /src/
add a file with the exact name "app.component.ts" in /src/app/
add your test class to it

The result for me is that once the file is called "app.component.ts" Visual Studio fails to compile it correctly. When I simply rename the file to "ap.component.ts" (notice the misspelling of "app") the compilation in the editor works again...

From @httpdigest on September 21, 2016 18:55
When I rename the folder "app" to something else (such as "app2") and keep the file "app.component.ts" in it (with that exact name), everything also works correctly... :(
This looks like a really weird file path computation bug.
This is what it looks like for me currently:

The error message in the view below comes from executing a typescript compile task. Note that Visual Studio does not recognize the error in the "0 errors, 0 warnings" counter and also does not underline the erroneous line in the editor.
This is my tsconfig.json:
{
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "mapRoot": "./",
    "module": "es6",
    "moduleResolution": "node",
    "outDir": "../dist/out-tsc",
    "sourceMap": true,
    "target": "es6"
  }
}

And this is the .vscode/tasks.json:
{
  "version": "0.1.0",
  "command": "tsc",
  "isShellCommand": true,
  "args": ["-p", "src"],
  "showOutput": "silent",
  "problemMatcher": "$tsc"
}

From @chrmarti on September 21, 2016 19:22
Cannot reproduce. Have you tried pointing the settings at the workspace's typescript install:
"typescript.tsdk": "node_modules/typescript/lib"

From @httpdigest on September 21, 2016 19:33
Yes, I also tried that. It had no effect.
For me it is perfectly reproducible with creating a default angular-cli project:

npm install -g<EMAIL_ADDRESS>ng new test-project
open folder test-project in Visual Studio Code
open the src/app/app.component.ts file
make some changes that would produce a compile error

Even stripping down that project to the setup I showed earlier did not get rid of the issue.

From @httpdigest on September 21, 2016 19:59
I just tried that procedure on Ubuntu 16.04.1 with the latest Visual Studio Code Insiders .deb download, and there the issue does not occur. Only on Windows 7 x64.

From @chrmarti on September 21, 2016 20:55
Works for me with Windows 10. Could you open the Output panel and switch that to show the TypeScript output? Any hints there? That should at least tell you where it is running the tsserver from.

From @httpdigest on September 21, 2016 21:2
Okay, that is a bit disappointing.

Could you open the Output panel and switch that to show the TypeScript output?

The "Output" view shows:
[Info  - 22:59:41] Using tsserver from location: d:\projects\test-project\node_modules\typescript\lib\tsserver.js

after I execute the typescript compiler. But the thing is, that the hidden editor typescript auto-compilation, which should immediately show any errors once I type them, also does not work. And once I manually execute the typescript compilation task it also does not recognize the error.

From @chrmarti on September 21, 2016 21:19
Got it reproduced with the above steps you gave on Windows 8.1 (not sure if that makes a difference to Windows 10). It indeed only reproduces in src/app/app.component.ts with any compile error. It does not reproduce for me with the build task, that correctly reports the compile error.
Not sure if that has a chance of being on our side, @dbaeumer?

From @httpdigest on September 21, 2016 21:27
Thanks for trying, I'm glad you could reproduce it. It's pretty strange. When I create a new empty folder and just add a src/app/app.component.ts, everything works fine. It seems to have to do with the "complexity" of the project (maybe number of node_modules).
But I have yet to figure out what exactly triggers the issue.
The first time I encoutered that issue was with an Angular 2 CLI-generated project.

From @chrmarti on September 22, 2016 3:3
Figured we can take traces from the communication with the tsserver. This one shows me opening app.component.ts in a first editor and then app.module.ts in a second editor. Both have compile errors, but only those in app.module.ts are reported:
[Info  - 7:56:54 PM] Using tsserver from location: e:\vscode\helloangular2\node_modules\typescript\lib\tsserver.js
[Trace - 7:56:54 PM] Sending request: open (0). Response expected: no. Current queue length: 0
Arguments: {
    "file": "e:/vscode/helloangular2/src/app/app.component.ts",
    "fileContent": "import { Com ponent } from '@angular/core';\n\n@Component({\n  selector: 'app-root',\n  templateUrl: './app.component.html',\n  styleUrls: ['./app.component.css']\n})\nexport class AppComponent {\n  title = 'app works!';\n}\n"
}
[Trace - 7:56:54 PM] Sending request: geterr (1). Response expected: no. Current queue length: 0
Arguments: {
    "delay": 0,
    "files": [
        "e:/vscode/helloangular2/src/app/app.component.ts"
    ]
}
[Trace - 7:56:58 PM] Sending request: open (2). Response expected: no. Current queue length: 0
Arguments: {
    "file": "e:/vscode/helloangular2/src/app/app.module.ts",
    "fileContent": "import { Brows erModule } from '@angular/platform-browser';\nimport { NgModule } from '@angular/core';\nimport { FormsModule } from '@angular/forms';\nimport { HttpModule } from '@angular/http';\n\nimport { AppComponent } from './app.component';\n\n@NgModule({\n  declarations: [\n    AppComponent\n  ],\n  imports: [\n    BrowserModule,\n    FormsModule,\n    HttpModule\n  ],\n  providers: [],\n  bootstrap: [AppComponent]\n})\nexport class AppModule { }\n"
}
[Trace - 7:56:58 PM] Sending request: geterr (3). Response expected: no. Current queue length: 0
Arguments: {
    "delay": 0,
    "files": [
        "e:/vscode/helloangular2/src/app/app.module.ts",
        "e:/vscode/helloangular2/src/app/app.component.ts"
    ]
}
[Trace - 7:56:58 PM] Event received: syntaxDiag (0).
Data: {
    "file": "e:/vscode/helloangular2/src/app/app.module.ts",
    "diagnostics": [
        {
            "start": {
                "line": 1,
                "offset": 16
            },
            "end": {
                "line": 1,
                "offset": 24
            },
            "text": "',' expected."
        }
    ]
}
[Trace - 7:56:58 PM] Event received: semanticDiag (0).
Data: {
    "file": "e:/vscode/helloangular2/src/app/app.module.ts",
    "diagnostics": [
        {
            "start": {
                "line": 1,
                "offset": 10
            },
            "end": {
                "line": 1,
                "offset": 15
            },
            "text": "Module '\"E:/vscode/helloangular2/node_modules/@angular/platform-browser/index\"' has no exported member 'Brows'."
        },
        {
            "start": {
                "line": 1,
                "offset": 16
            },
            "end": {
                "line": 1,
                "offset": 24
            },
            "text": "Module '\"E:/vscode/helloangular2/node_modules/@angular/platform-browser/index\"' has no exported member 'erModule'."
        },
        {
            "start": {
                "line": 13,
                "offset": 5
            },
            "end": {
                "line": 13,
                "offset": 18
            },
            "text": "Cannot find name 'BrowserModule'."
        }
    ]
}

Moving to the TS team. There is little we can do if the tsserver doesn't report the problems.

Got it repro with master, however it seems to have been addressed in release-2.0.5 branch with the new tsserver.

Can you give instructions on how to use that 2.0.5 version, then, please? Will it be in npm? Currently, with 2.0.2, 2.0.3 and 2.1.0-"nightly" the issue persists and it is a showstopper for using Visual Studio Code with one of our projects.

We do not have this release on npm yet. sorry about that. it should be available on npm in the next few weeks. it should ship with VSCode 1.7 i would expect.
You could get the latest copy the files in https://github.com/Microsoft/TypeScript/tree/0a0b7e4baad912a9353dd69488247cb8e1d3f75c/lib  (you mainly need tsserver.js and lib.*.d.ts) and update your typescript.tssdk property to point to it.


Latency tweaks

David - these are a few tweaks I've been toying with to improve latency. They're not extensively tested, more of 'here's some initial thoughts'.
The first is a maybe that's worth exploring, to avoid kicking unnecessarily - I don't think it immediately buys us anything meaningful, but it might open the way to something - so keep it in the toolchest for now.
The second seems to help on my localhost tests on my mac. We kick every fd on the watcher list on a notify - we probably only need to kick one, and only if there's nothing listening for the event that just came up. We certainly don't need to kick the fd that just woke up though - so we remove that one from the list before starting notifications.

The final change kicks only those pollers that are not looking for the event we now need on a given fd.

Also - if after consideration you decide to merge something along these lines - and whatever you do still requires a thread local - please come to some consensus with @nicolasnoble and @a11r on whether that's ok to do in this codebase, and what level of macro magic we should wrap around everything to make it 'portable'.

The second change (poller should avoid kicking itself) seems like it is unambigously a good idea, and I may cherry pick it and merge it separately. I've yet to fully digest the other two changes.
For what it's worth, I'm sure I'm missing something, but I don't see where thread locals are involved here. (I do fully expect to eventually need them for iomgr changes though.)

polling_cq in the first change is declared static __thread (making it thread local).
FWIW I'm torn between taking thread locals, and plumbing through some kind of global context object that gets created (on the stack) at our public entry points and passed through everywhere - such an object could help clarify the boundaries of some of these operations a little more strongly than thread locals could, but would of course mean a bunch of typing for someone.

Makes sense, I'll give it some thought. It's very similar to some of the stuff we do in EventManager, but there we 100% know all environments we care about have fast TLS. That's probably true here too, at least as long as we're at the iomgr/posix layer.
Meanwhile I've created a separate pull request cherry-picking just the second commit.

We will likely want similar techniques in chttp_transport to avoid some
potential long recursions there.
On Thu, Mar 12, 2015, 11:26 David Klempner<EMAIL_ADDRESS>wrote:

Makes sense, I'll give it some thought. It's very similar to some of the
stuff we do in EventManager, but there we 100% know all environments we
care about have fast TLS. That's probably true here too, at least as long
as we're at the iomgr/posix layer.
Meanwhile I've created a separate pull request cherry-picking just the
second commit.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/980#issuecomment-78405063.

Is this PR still relevant, or has it been subsumed by more-recent ones that have already been merged?

I think we can nuke it.
We still have wakeup problems, but I think the solution is different.


publish jars to Maven

Hello! Thanks for your work.
Could you publish this to Maven? It would help many of your users.
Cheers!

Hi @blbradley
Thanks, we will get that done. We are working on dockerizing streamx too (which makes it easier to get started)
Thanks

HI @PraveenSeluka , I'm thinking about working on a way to dockerizing Kafka connect + streamx. Is someone already worked on it ? :)

HI @jocelyndrean I have done some work on it already. So, I will push those changes soon. You can try it out and add features if necessary.

@jocelyndrean Confluent released a set of images for Kafka Platform that are great.

@jocelyndrean I believe you have checked it out already. We added dockerfile to repo, enables you to build streamx image now.

 I consider this issue closed.
Bring up another issue if the Docker images don't work.


Property '__useParseTailwind' doesn't exist

Hey, I see this is very new, but I love the idea and I'm excited to use it in a new project.
I'm getting a Property '__useParseTailwind' doesn't exist error when adding it to a React Native app, in the iOS simulator.
It happens both when using the babel plugin as 'tailwindcss-react-native/babel' or ['tailwindcss-react-native/babel', { platform: 'native' }]

Hi! Yes sorry this is still a work in progress. Can you please try version 0.0.11 which resolves a couple of issues.
Unfortunately I don't have immediate access to an iOS simulator, so I won't be able to test it for a little bit. I'm currently just testing with android simulator with Expo and on web with @expo/next-adapter.
I'm not sure if it helps but my test repo is https://github.com/marklawlor/solito-tailwind

Cheers, just watch the repo for releases. I'll tag version 1.0.0 when its stable.
Just curious - are you using Expo or vanilla react-native?

@jmeistrich I fixed an issue that caused babel asynchronous builds to produce a similar error message. Can you please try 0.0.14. That version will also skip trying to transform native elements.

Great, it works now! I tried it in 0.0.15. Now that it works I'll post a few other issues I encountered.


New version: Ripose.Memento version 1.2.0

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Manual Validation ended with:

2023-10-03 15:49:32.744 [CLI ] Installer [X86,burn,Unknown,] not applicable: Architecture was excluded by caller : X86
2023-10-03 15:49:32.746 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2010.x86 with version 10.0.40219
2023-10-03 15:49:32.746 [CLI ] Terminating context: 0x8a150104 at D:\a_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DependenciesFlow.cpp:11a

@wingetbot waivers Add Validation-Executable-Error


Revert "Added multiheader support."

Reverts synchronizing/httpq#1.

Reverted to add further tests & capabilities that were not included in the original MR. See #3 for updated version.


emails: Add<EMAIL_ADDRESS>to email the realm admins.

This requires a few things:
(1) edit the email mirror code zerver/lib/email_mirror.py to process a new type of recipient and do the right thing and
(2) setup the appropriate MX records so that those emails get delivered to the appropriate postfix server.
We can start with (1) first, since that's 90% of the work.

@zulipbot claim.

@zulipbot claim


Ticker name "NA" makes the exists_qlib_data function report errors.

🐛 Bug Description

The ticker name "NA" in the "all.txt" under /instruments makes the exists_qlib_data function fail due to the string "NA" being wrongly converted to the float "nan" but not a string.
To Reproduce
Steps to reproduce the behavior:

Save the attached all.txt under the ~/.qlib/qlib_data/us_data/instruments.
Run the following code:

provider_uri = "~/.qlib/qlib_data/us_data_new"  # target_dir
if not exists_qlib_data(provider_uri):
    print(f"Qlib data is not found in {provider_uri}")
    sys.path.append(str(scripts_dir))
    from get_data import GetData

    GetData().qlib_data(target_dir=provider_uri, region=REG_US)

Expected Behavior

The code should run without errors.
Screenshot

Environment
Note: User could run cd scripts && python collect_info.py all under project directory to get system information
and paste them here directly.

Qlib version: 0.93
Python version: 3.8.10
OS (Windows, Linux, MacOS): Windows
Commit number (optional, please provide it if you are using the dev version):

Additional Notes

The bug is caused by the wrong usage of pandas.read_csv in the following line of exists_qlib_data under qlib\utils\__init__.py. Refer to the page for more details.

 miss_code = set(pd.read_csv(_instrument, sep="\t", header=None).loc[:, 0].apply(str.lower)) - set(code_names)

The cause of the bug can be further verified by the following code:

temp = pd.read_csv("all.txt", sep="\t", header=None).loc[:, 0]
non_string_values = [i for i in temp if not isinstance(i, str)]
print(non_string_values)

[nan]

The bug can be easily fixed by adding keep_default_na=False

temp = pd.read_csv("all.txt", sep="\t", header=None, keep_default_na=False).loc[:, 0]
non_string_values = [i for i in temp if not isinstance(i, str)]
print(non_string_values)

[]

I can help with the fix, just want to ask what tests I need to run to make sure whether the fix would cause any other issues.

Would you like to create a PR to fix this and be one of the contributors to qlib.

@SunsetWolf Sure. Then I will double-check whether my fix will cause any issues, if not, then I will create a PR to fix it. And I am happy to be a contributor to Qlib and try to help with other issues.

@OzzyXu Let me know about it. I'd like to help.


Formatting issue in installation instructions

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
https://ddev.readthedocs.io/en/stable/users/install/ddev-installation/
At the bottom in the section called "WSL2 hostname management", there is a problem with the code formatting.
Expected Behavior
Formatting should be correct.
Actual Behavior
There's probably a missing ending code tag, or a typo.
Steps To Reproduce
No response
Anything else?

You can just click the pencil at the top of that page to edit it, would you like to try that? Thanks for pointing this out!


How to fetch file from google drive using file_id

Hi,
While I can fetch files of a folder by passing folder_id, I want to know how I can do the same with the file IDs,
I tried using file_ids, it fetches the file perfectly but at the same time I get a warning that it has been deprecated and it tells me to use a template instead. Can you show some examples?

Use the template gdrive-by-name-in-folder, folder_id and filename in query.
loader = GoogleDriveLoader(
    folder_id=folder_id,
    template="gdrive-by-name-in-folder",  # Default template to use
    query="MyFileName.pdf",
    num_results=2,  # Maximum number of file to load
    supportsAllDrives=False,  # GDrive `list()` parameter
)

The list() api of Google Drive, can not find a find by id.
See the filter syntax.


[BUG]: Can't find the file /config/server.sh in EnergonAI docker

🐛 Describe the bug
I built the docker with Dockerfile of EnergonAI, then I execute the launch.sh, it tells me /config/server.sh doesn't exist.
Dockerfile:

(opt) [worker@bj3-136-162-18-s1 docker]$ ./launch.sh
bash: /config/server.sh: No such file or directory
Environment
CUDA=11.4
python=3.10.8

you have to map your local directory to docker with -v to do column mapping. For docker volumn mapping usage please refer
https://www.geeksforgeeks.org/mounting-a-volume-inside-docker-container/

We have updated a lot. This issue was closed due to inactivity. Thanks.


(PUP-10364) Add pp_owner ppRegCertExt OID

In Puppet-as-a-Service use cases it is common for individual nodes to be owned by various different tenant, or customer, teams. None of the registered ppRegCertExt OIDs we currently provide cleanly allow generic specification of an owner in this context.
Provide a new OID, pp_owner, which generically fits this use case.

@mwaggett are any of the failed tests related to this? At first glance, the failures seem unrelated or transient to me.

@reidmv rekicked 'em, looks like they were transient 😊

CLA signed by all contributors.

Target branch seems maybe odd here, I think 6.4.x is not in use anymore, right?

ahh yeah, this should probably target master, as 6.4.x is EOL

Changed PR base branch and rebased


Provide prelude

I think it is time to export the most important types and traits in a prelude to increase usability.

I think so too, when I finish the job at hand, because I have added some new types. 😂

Just to give a hint on what should be in prelude, currently my project is not that much advanced but this might help a bit:
$ grep -irn 'use async_graphql' src

use async_graphql::{Context, FieldResult, ID};
use async_graphql::{Context, FieldResult, ID};
use async_graphql::{guard::Guard, Context, FieldResult, ID};
use async_graphql::{Context, FieldResult, ID};
use async_graphql::{Connection, Context, DataSource, FieldResult, ID};
use async_graphql::ID;
use async_graphql::{Connection, Context, DataSource, FieldResult, ID};
use async_graphql::SimpleBroker;
use async_graphql::{Connection, Context, Cursor, DataSource, EmptyEdgeFields, FieldResult, QueryOperation}
use async_graphql::FieldResult;
use async_graphql::{Json, ID};
use async_graphql::extensions::ApolloTracing;
use async_graphql::http::{playground_source, GQLResponse};
use async_graphql::{Data, QueryBuilder, Schema};

I personally write macros with full path, eg #[async_graphql::Object] I feel that having just #[Object] on top of the declaration is a too much generic name, if macros were renamed #[GraphQLObject] I think I'll go for this style.
So I'd definitly put Context, FieldResult, FieldError, InputValueError, InputValueResult ID for sure
Connection, Cursor et al is really tied to Relay, the usage seems pretty wide on the different places I worked with graphql

Good suggestion, I will make a list tomorrow. 😊

Just my input, I think custom scalars and relay stuff shouldn't exist in the prelude. It would be very nice to have async_graphql::relay::prelude::* and async_graphql::custom_scalars::prelude::*

@phated I don't think relay and custom scalars need their own prelude, there's not much in those modules, they can be used as async_graphql::relay::* and async_graphql::scalars::*


Rename physics layers and name dialog box

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10, Godot 3.0
Issue description:
Clicking the Collision Layer or Collision Mask in the Inspector opens a dialog box named "Physics Layers" in both instances and should probably be called layers when clicking the layers filed and masks when clicking mask field to not confuse the user
Steps to reproduce:
Click the Collision Layer or Collision Mask in the Inspector
Link to minimal example project:
https://filebin.ca/3jqBcPyctHdN/masksandlayersrename.gif

Duplicate of #14363 filed a couple hours before :)


(maint) spec/fixtures/ip_route_show_default: correct output

"ip route show default" would only output one line, the default route. So remove the other line.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@kenyon thank you for your contribution! As what you stated is right for some operating systems, there are some OSes for which this is not applicable (Ex: for Centos 7 the output is not a single line):
~ip route show default
default via 10.16.x.y dev ens160  proto static  metric 100
10.16.x.y/20 dev ens160  proto kernel  scope link  src 10.16.x.y  metric 100
10.32.x.y via <IP_ADDRESS> dev ens160  proto dhcp  metric 100

@kenyon thank you for your contribution! As what you stated is right for some operating systems, there are some OSes for which this is not applicable (Ex: for Centos 7 the output is not a single line):
~ip route show default
default via 10.16.x.y dev ens160  proto static  metric 100
10.16.x.y/20 dev ens160  proto kernel  scope link  src 10.16.x.y  metric 100
10.32.x.y via <IP_ADDRESS> dev ens160  proto dhcp  metric 100

Yes, that's weird, I guess because EL7 is quite old and it was different back then. EL8 gives only the single line. Oh well.

Yes, that's weird, I guess because EL7 is quite old and it was different back then. EL8 gives only the single line. Oh well.


fallback to util.path.dirname for all languages with warning

There are basically three usability complaints with lspconfig

we don't automatically provide language servers (solved by lspinstall)
we don't set up autocompletion + snippet for you (solved by nvim-compe + vnsip)
Occasionally servers fail to start

3 is because lspconfig tries to find the correct root directory for the project, many language servers are picky about this, but some will still provide some utility without the correct directory. I'm leaning towards adding a vim.notify hook for root directory detection that notifies you we are falling back to the current file's working directory.
Alternatively, lsp-mode prompts the user for a root directory. We could do this.

I think an lsp-mode style prompt is better for usability and troubleshooting. Granted, users will have to (be patient enough to) read through the different options selected in the prompt.

We got a lot of complaints last time I put an interactive prompt, so mixed.

Please test #1066
I had to make sweeping changes to root directory detection (mainly disabling working directory and parent directory fallback) to support this change.
You will be able to override the fallback behavior, but I think this is generally a better default for everyone.

I can't get the interactive root directory picker to trigger/start, but the root directory isn't being detected either. At least I don't think so, maybe I missed something. It only works when I create a softlink build/.....command.json (something like that) to root manually.

That's strange, if you mkdir test && cd test && touch main.c && nvim main.c, it immediately pops up for me. If you run :LspInfo do you see a root? The server can still detect a root and fail to (appropriately) start because compile_command.json is missing. In the event any root is detected, lspconfig will never show you the popup.

You should make it more obvious what this is for, i.e., the popup should mention LSP somewhere. This is important because "Ignore this file" has no context otherwise (you may also want to reword it to "Don't enable LSP on this file" or something of the sort).

Also, would there be a way to use ShaDa or some other persistent method to remember a user's decision? I am repeatedly asked for root dir on opening Neovim when I have already chosen it previously. If you were to do that, you would additionally need a way to manually configure, for example if the user changes their mind.

Also, would there be a way to use ShaDa or some other persistent method to remember a user's decision? I am repeatedly asked for root dir on opening Neovim when I have already chosen it previously. If you were to do that, you would additionally need a way to manually configure, for example if the user changes their mind.

Yes, but I'm not going to implement this yet until we have workspace support, at which point it will be written to a project local json file.

I don't think that dropping existing fallbacks in favour of the interactive picker should be the out-of-the-box experience.
The existing fallbacks work pretty solidly. Anyone wanting a picker at runtime canconfigure that manually (and disable the current mechanism), not have that as the default, that would be incredibly annoying.
I'm not a fan of dropping something that works automatically in favour of something that needs to be done manually, at very inconvenient times, over and over by the user.

You will almost never see the interactive picker if you've configured your project correctly and if the settings have same root directory detection.

Gotta say I'm with @WhyNotHugo on this. Not all files are part of projects. And I definitely don't want a popup every time I edit those.

In that case it's extremely easy to override the default behavior with a fallback to util.path.dirname which I will document.
As it stands, people are putting util.path.dirname as a fallback for everything, which is not in compliance with the specification and will result in broken behavior (servers will fail to index the whole project) and getting confused when language servers do not work correctly. The root of the project is not/should not be the parent directory of the current file. We can special case a few (EFM, jsonls, for example).

What about:
If a project root is not detected, fail with a message in the echo area telling the user to start it manually (e.g., LSP failed to autostart, pick a root directory with :LspStart), and have :LspStart display the interactive menu as a fallback?

What about:
If a project root is not detected, fail with a message in the echo area telling the user to start it manually (e.g., LSP failed to autostart, pick a root directory with :LspStart), and have :LspStart display the interactive menu as a fallback?

That would add an additional step over the behavior of the PR, making hugo's conern worse.

Op 2021-07-21 om 19:28 heeft Michael Lingelbach @.***> het volgende geschreven:

In that case it's extremely easy to override the default behavior with a fallback to util.path.dirname instead which I will document.
As it stands, people are putting util.path.dirname as a fallback for everything, which is not in compliance with the specification and will result in broken behavior (servers will fail to index the whole project) and getting confused when language servers do not work correctly. The root of the project is not/should not be the parent directory of the current file. We can special case a few (EFM, jsonls, for example).

This sounds like a very legit issue, so I can align with the interest in wanting to address this.
Maybe having the UI picked as a non-default would suffice - it sounds like exactly what those users are looking for, and they're already overriding the defaults due to their unusual setup and lack of expertises in setting it up further.
I personally don't have any overrides for finding the root directories: I've upstreamed all edge cases into this repo, hence why I'm not a fan of dropping these. They work in many common scenarios. Or sometimes it a matter of improving the LSP a bit.
I think this is generally what we'd want to do: continuous refine these defaults so they work in as many scenarios as possible. Dropping these fallbacks kills room for further improvement.

Maybe having the UI picked as a non-default would suffice - it sounds like exactly what those users are looking for, and they're already overriding the defaults due to their unusual setup and lack of expertises in setting it up further.

That defeats the purpose. You are the advanced user who is opting-in to having the language server attach to a buffer with an incorrect root (thus you should not expect the language server client to operate as designed). It should be trivial for you to change the fallback to util.path.dirname

They work in many common scenarios.  Or sometimes it a matter of improving the LSP a bit.

They don't, that's the issue, and I don't understand the second point.

I think this is generally what we'd want to do: continuous refine these defaults so they work in as many scenarios as possible. Dropping these fallbacks kills room for further improvement.

That's exactly what I'm doing, the PR changes it such that the language server will only start when it will not error or fail to index your project files.

Yeah, the assumption that the parent directory should "just work" for LSP is false. For editing files not in projects, wouldn't the normal assumption be to simply not enable LSP (maybe with a little reminder in the echo area)? Hence my suggestion above.

You are the advanced user who is opting-in to having the language server attach to a buffer with an incorrect root (thus you should not expect the language server client to operate as designed).

I'm the exact opposite of an advanced user; I've a very simple setup, sticking to upstream defaults as much as possible. I've no projects or codebases where the LSP misbehaves with these (though I'm sure they exist!).
If you have scenarios where they break, I'd advise researching them and figuring out how to improve the defaults this package provides. I don't think showing a UI to every single user every single time is a solution that makes sense: it promotes redoing the same work manually countless times instead of fixing how this package handles those scenarios. Users would be prompted to pick a root over and over and over and over.
Generally, showing a UI / prompt when starting up neovim is as invasive as a plugin can get, and something that, IMHO, should be avoided as much as possible. If I open a file, I want that to be opened, not to be distracted configuring an LSP. Like I said, I'm not an advanced user: if neovim distracts me with configuration questions, I'm most likely to lose forever whatever I was going to do.

This repo provides static configuration to rely on, and not things like prompts and wizards. I'd really prefer if it can stick to the purpose it has now, at least in its default behaviour.

If you have scenarios where they break, I'd advise researching them and figuring out how to improve the defaults this package provides.

I have. The majority of the defaults are correct. You will almost never see the interactive prompt.

I don't think showing a UI to every single user every single time is a solution that makes sense: it promotes redoing the same work manually countless times instead of fixing how this package handles those scenarios. Users would be prompted to pick a root over and over and over and over.

You will almost never see the interactive prompt. It will only happen when we cannot automatically choose the root for you which will, as I said, rarely happen.

Generally, showing a UI / prompt when starting up neovim is as invasive as a plugin can get, and something that, IMHO, should be avoided as much as possible. I

Then disable it, it will be a one line config option to do it.

I feel like the most intuitive solution would be:

If a proper project root directory can be resolved, enable LSP
If not, don't enable LSP. If possible, display a small unintrusive message saying "LSP not enabled: A project root directory could not be resolved."

If the user wants to enable LSP anyway, they could run :LspStart. At this point, an interactive menu makes sense to me.
I don't think vim should ever "get in the way" by immediately displaying a prompt when the user opens a file.

@Hubro thanks for the feedback. I've come to a similar conclusion (mostly because of some annoyances I found regarding the timing of treesitter highlighting, which means the document is unhighlighted when the prompt is shown), however I would like to add as an option the automatic fallback.
As it stands, the user will be able to have two behaviors:

(default) the user will since a printed error that no root detected, and we can not automatically start the language server, at which point the user can call LspStart which will show the interactive root picker (which again, will check for a root, and only show the popup if no root is found)
The popup will be automatic if no root is found.
every single server defaults back to util.path.dirname, I will modify the issue template to make it clear this is unsupported and you must disable this when filing an issue


Routes

Why are the routes like /?r=main/index?
Is it possible to be just /main/index?

Implemented for Xavante and Apache :dancer:


close before unmount

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10261

[x] Fill up your DOT address: Payout

pay 20 usd


fix: npm releases failing to generate provenance

We are seeing the following error in NPM releases:
npm ERR! Can't generate provenance for new or private package, you must set `access` to public.

As of Feb 14, projen has started generating provenance statements for NPM releases (on by default for public packages).
It is not clear why we are seeing the failure above because access should be public by default for public packages.
My suspicion is that for the very first version of a package, access must be explicitly set. Trying this out.

💚 All backports created successfully

Status
Branch
Result

✅
k8s-26/main

✅
k8s-27/main

Questions ?
Please refer to the Backport tool documentation


Permit arbitrary size CLKs in similarities.dice_coefficient_x86

Currently the CLK length needs to be a multiple of 64. For consistency with similarities.dice_coefficient_python, we should relax this. This can be achieved by filling with zeros.

This may be easier done at the same time as #168.


Add Decidim

Add https://github.com/decidim/decidim/ to project

This is a rails app generator rather than a rails app


Rewriting the build

Sorry for the size of this, and I realise I need to catch up with master (ugh) before we can even think about merging this.
But, results are promising.
Our fresh build times have gone from 17s to 14s. But our repeat builds have gone from 16s to 8s.
Watch mode works too, and makes changes even quicker.
I need to review this myself, as it involved a lot of hacking, so might not be worth looking at yet.

Somehow the size of the site has dropped by about 20k too. Hmm. Not sure how.

My current theory is we were duplicating some TS helpers before, and now we're not. But I'm not sure.

Ok, ready to review 😈

For history: The reason I gave up on JSDOM is it didn't understand the linear gradient we use on our nebula background. I could have hacked around it, but it felt like a sign of things to come. Better to run it in a real browser.
I could also introduce a 'turbo watch' mode which skips things like minification & static render. Might be useful for quick iteration.


[SUGGESTION] Method to override default effects

Short Description
There's always the possibility someone might not be comfortable with the effects on the mod and decides to make their own. It'd be a nice addition to make this kind of task as free from overrides as possible by providing a hook that gets called every time an effect is created by ACF. That way people won't have to mess with ACF code or override vanilla effect functions by adding pointless overhead.

Added the hook ACF_PreCreateEffect in 28916bc to allow overriding effect names and attributes for ACF-produced effects.


Android: Un-pausing media does not raise MediaManager.StatusChanged event

If you have a song playing and pause it, the MediaManager.StatusChanged event is raised, but when you un-pause it, the event is not raised.

I have the some problem to. Still no solution?

Also facing this issue on the pre-release version. Is there a workaround for it ?


Scrcpy turns off gamepad when screen is set to off

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Android
scrcpy version: 2.3.1
installation method: extracted win64.zip of this release
device model: Retroid Pocket 3+
Android version: 11

I am not very educated in how programs like this work, so I apologize if I simply gazed right over something that was relevant when I checked other issues. With that said...
I am using a Retroid Pocket 3+, a device with a built-in game pad. Connecting via USB-C or TCP/IP method actually works so much better than I could hope, and if I leave the screen on, the whole experience is flawless. Thank you for that, by the way!
However, when I tell it -S or --turn-screen-off, it turns off the input from the built-in gamepad as well. I was hoping to simply sit down, run the .bat, and move from handheld to computer kind of like docking a Switch and pulling the joycons off, rather than having the screen reflected twice (one on the device in my hands, the other on the PC). Is there any method to, uh, not turn off the "attached device"?
I've seen this linked on what looks like similar issues, but also don't see how it can relate to the specific issue I'm facing. Please let me know if I'm incorrect.
(I've posted a request on the Retroid discord channel to keep the gamepad on when the screen is off, as well, but figured I'd ask on this side of things since I'm not sure where the exact issue is.)

To turn the screen off, scrcpy just requests the device to change its "power mode" to off. The impacts of this change depend on the Android system (and the specific ROM).
Unfortunately, there's nothing scrcpy can do.

Thank you for the quick reply. I wasn't sure, so I wanted to ask in the official space rather than malinger over it and doing nothing.


Accumulo 4558 Added shell command to display server status

Fixes ACCUMULO-4558, the shell now has a command to display tablet server status.
After I started this pull request, I realized that some of the changes come from #198, so I think that merging this should also close #198.

@keith-turner @ctubbsii is this ready to go in your opinion?

@mjwall I'll defer to @keith-turner regarding the design of the new public API method. I can take another look after that.

I just pushed the rebasing onto master and recompiling of thrift.

I just fixed the conflict with the main branch (it was due to the change being done to the old monitor code), I spoke with @milleruntime offline and he might take over fixing what had been discussed on this PR.

Discussed this some today offline with the team and there seems to be resistance to creating new API methods for this change.  @lstav you could pull out the changes for getting the version for ACCUMULO-4061

@milleruntime you mean to just leave the status report on the shell? if so I can do that.

What @milleruntime was referring to was a conversation with @keith-turner and myself (a small subset of the overall Accumulo "team", but a team in another sense). In that conversation, I had suggested we omit the shell and API changes for now, and limit the change to updating the Thrift to include the version, so that the monitor can display it in a REST endpoint. That way, there's still a way to access the version information and other tablet server status details programatically, but no need to decide on a particular public API just yet, and no need to add any new command to the shell either, until the public API exists.

Sounds good, I'll probably create a new PR to add the Thrift update to include the version, that way I can keep the Shell changes as a reference for when we decide to add the new command.

@lstav I was thinking we could just save the commit as an attachment to the JIRA, for future reference. That way, we're not relying on an old PR if we revisit it, and can move on with another PR or just pull out what we want out of this one.

@ctubbsii that sounds like a good idea to me, would you mind adding the commit to JIRA?

@lstav Done.

@ctubbsii Thanks! I'll try to get the code for ACCUMULO-4061 ready soon and I'll make a PR for it. Also, closing this PR.


Make sds logs less verbose

There is no need to add the "connection id" to the SDS logs -- its always localhost.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-galley-k8s-tests_istio

lint_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-galley-k8s-tests_istio

lint_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test lint_istio

gencheck_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-galley-k8s-tests_istio

lint_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test lint_istio

gencheck_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
e0de2a31eab02e632c739bc00855fbcf83b6f305
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
9311a667984b345b5003502f43e54ef0fb9ce082
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Use Nexus (sonatype.org) to cache the download repo and cache on the local repo

Is your feature request related to a problem? Please describe
Currently, the build system uses mirror sites for downloading the dependencies and we observed an issue with the mirror site being down during OpenSearch 2.9 release. To mitigate the issue for future releases, please consider using  Nexus (sonatype.org) to cache the download repo and cache on the local repo.
Describe the solution you'd like
Please consider using  Nexus (sonatype.org) to cache the download repo and cache on the local repo.
Describe alternatives you've considered
No response
Additional context
No response

[Triage] Hi @praveensameneni,
Can you add more details on what kind of dependencies we want to cache?
The direct dependencies are published to maven local and are used directly by OpenSearch and its components. For external dependencies, we might need to create a support ticket with nexus to configure those proxy URLs and accordingly create a campaign to add that URL in all components' build.gradle.
Let me know if I am getting it right or not.
Thanks!

@gaiksaya , During the 2.9 release, we experienced an outage on one of the mirror sites hosting distribution of Node and teams were stuck waiting for the site to come back online.
@joshuarrrr , @ashwin-pc , Would you like to chime in here?

I forget which workflow failed that caused it because the github action we use to download and install node does not mention any mirror. https://github.com/actions/setup-node/tree/v3/. Maybe i'm looking at the wrong workflow so looping in @kavilla since he has more context here.

@kavilla @ashwin-pc @AMoo-Miki We would like to know if it really make sense to cache these dependencies using local repo implementation. Do you see significant benefits in doing it? We don't want to create a complex solution for a transient problem. Can you please provide your inputs?

Yeah we had a mirror for downloading and distributing a Node executable with OpenSearch Dashboards.
We originally switched to the mirror because the traffic to the original download was too much and it was faster to switch the mirror. But then they stopped hosting the mirror and proceeded to now download any copy of Node.
IMO, this would be great because instead of every build for each platform/arch we download a ~20 MB file to bundle with the release. So unless the build system has some caching mechanism built in already then the amount of time saved could really add up. I am also currently seeing check sum failures for the build coming from these downloads but that is also a transient issue.

Yeah we had a mirror for downloading and distributing a Node executable with OpenSearch Dashboards.
We originally switched to the mirror because the traffic to the original download was too much and it was faster to switch the mirror. But then they stopped hosting the mirror and proceeded to now download any copy of Node.
IMO, this would be great because instead of every build for each platform/arch we download a ~20 MB file to bundle with the release. So unless the build system has some caching mechanism built in already then the amount of time saved could really add up. I am also currently seeing check sum failures for the build coming from these downloads but that is also a transient issue.

@kavilla Thanks for your inputs. Based on your comments, it looks like the issue that we faced during 2.9.0 was already remediated by moving out of using mirror site and caching it to local would be a "nice to have" feature and not a "must have" feature at this point in time. Do you agree?

@bbarani Another issue we are seeing related to build failures while downloading node executable for v14.20.3 Darwin + arm64 issue is due to 404 error on access to https://nodejs.org/dist/v14.21.3/node-v14.21.3-darwin-arm64.tar.gz  If we continue to support Darwin arm64 for node v14, this might need to build and cached.

Hey @manasvinibs there is an open issue related to node-v14.21.3-darwin-arm64.tar.gz please check https://github.com/nvm-sh/nvm/issues/3148. Looks like this 14 darwin-arm64 version is not available to even download and cache.
Ideally we should cache the artifacts for building internet restricted applications, where the build process cannot reach internet to fetch dependencies when running a given build task, but this is not the case for OpenSearch. As @bbarani mentioned its good to have as fallback but my point is its not recommended for Open Source applications.


[IA-4075] add types to cost utils

Jira Ticket: https://broadworkbench.atlassian.net/browse/IA-4075

Summary of changes:

What

Added default return 0 to cost-utils functions to prevent null edge cases from causing breaking errors

Why

The original cost-utils changes caused a prod incedent

Testing strategy

[testing not necessary unless specified by reviewers, this regression will soon be fixed by typescript upgrades ]

Just so it can be seen, I'm also going to revise the tests to use a mock because it's far too brittle just using the hardcoded disk/etc costs

Could you write a unit test for deleting a dataproc runtime?
I mainly ask because that's what caused the breaking issue in the first place, I would be happy to see that case covered now.

was doing some testing and noticed that the disk cost looks incorrect:
 with the following console error upon inspect

was doing some testing and noticed that the disk cost looks incorrect:  with the following console error upon inspect

oh darn that new merge must've set something off, looking now


Windows Secure Storage Details

Where exactly is data stored in windows? Looking through the code I couldn't seem to find the resource that makes calls to the OS to store/retrieve data. Thanks

Hi,
depending on the version that you are using the data is either stored in /Users/<Username>/AppData/Roaming/<CompanyName>/<ProductName>/ or in the windows credential system.
You can find the values for  and  in your Runner.rc file
Hope that helps.

I am closing all older issues. If this issue still exists in the latest version, please let me know.


RCTEventDispatcher.h' file not found

Hello, thanks for this project.
I'm could install it successfully but as soon as I try yo build it, I get RCTEventDispatcher.h' file not found.
No sure what to do.
Thanks in advance.

It seems not link OK, or react-native module not build OK.
Check your environment.


Update documentation based on Shakapacker 7

We need an overall update in our documentation so that it is based on Shakapacker 7 with some guidelines on how to apply the documentation for Shakapacker 6 and Webpacker.

Done in https://github.com/shakacode/react_on_rails/pull/1551


Items for dead players

So as a fan of "everyone has equal stuff", I find it kinda bad that when someone actually dies, others get all the good stuff aaaand the dead person does not, which means he lags behind in equipment and is even more prone to death.
So I'd like to suggest a "give items even when dead" version of the dll if possible? I've tried deleting the "alive if's" and either screwed up compilation or really misunderstood their purpose, as instead of receiving items when dead, the items were not duping for everyone at all even alive.
Can I get some advice here, please? Is it even possible to have it like this?

Your code looks like this?
private void GrantItem(CharacterBody body, Inventory inventory) 		{ 			if (!NetworkServer.active) 			{ 				Debug.LogWarning("[Server] function 'System.Void RoR2.GenericPickupController::GrantItem(RoR2.CharacterBody,RoR2.Inventory)' called on client"); 				return; 			} 			foreach (PlayerCharacterMasterController playerCharacterMasterController in PlayerCharacterMasterController.instances) 			{ 				playerCharacterMasterController.master.GetBody().inventory.GiveItem(this.pickupIndex.itemIndex, 1); 			} 			GenericPickupController.SendPickupMessage(inventory.GetComponent<CharacterMaster>(), this.pickupIndex); 			UnityEngine.Object.Destroy(base.gameObject); 		}

Exactly. Sadly, when I die as host, my friend cannot pick up items from the ground at all.


Paths with spaces are not parsed correctly

When MILK is called with arg parse, a split by space is used on arguments. This does not work when there is a space in a directory name since it is split up.

Hi djm87, you can try treating directory address strings as raw string types. This is achieved by adding 'r' before the strings that give you errors. I leave you a link here with more information about it: RawString

Thanks for the tip, I didn't know that raw strings were a thing. In this case the issue is that MILK was original written for use with argparse and bash. Currently, the new pythonic MILK interfaces with these old routines by passing a string of arguments which are delimited by spaces. I just need to choose a better delimiter and probably should do away with the argparse routines.

If you feel that changing the argparse is not much of a deal you can try it. I also think that you can fix it using the implementation of argparse and keep going that way.
Here is a link with a possible implementation to solve it: Argparse Raw String input


🚀 Feature: Clearer messaging around E2E test failures

🔖 Feature description
Our E2E tests run @backstage/create-app to create a new app and run tests. It does so without locking down version ranges in any ways, which means we get the most recent versions of all published packages. This means that our E2E tests can break whenever any upstream package breaks.
With our current setup there's no great fix for this problem except fixing the breakage upstream. We are able to add resolutions in our create-app template, but that is a very short-term fix and it won't apply to existing projects. It also means all projects creating with this temporary resolutions fix should remove it in the future once the issue is fixed.
Another potential solution is to ship a yarn.lock as part of @backstage/create-app. This would cause us to discovery version incompatibilities in dependencies much later, and there would also need to be some points where we update the yarn.lock, which would add friction. Nevertheless this is still a solution we should consider.
Lastly we could improve the messaging around E2E test breakages so that users are informed that it's expected that the tests are failing. Taking that a step further we could potentially have a list of allowed errors that might instead just cause a warning to be logged.
🎤 Context
Discussed in the Adoptions SIG (CC @jamieklassen, the existing issue was a bit off topic, so I created a new one instead)
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Closing this as there's now a solution to the underlying problem in place through #22659


MappingIsoparametric, multiple element support

Add multiple element support to MappingIsoparametric.F so that in the future, when InteriorBasis.interpolator is extended to work with quadrilateral and hexagonal meshes, ElementH2.gbasis works as expected.

By multiple element support I mean that one should be able to map different local points in different elements.

... when InteriorBasis.interpolator is extended to work with quadrilateral and hexagonal meshes, ElementH2.gbasis works as expected.

I cannot recall what was the point here. Isn't interpolator already working for quadrilateral meshes? Hexahedral is still TODO.

This is already fixed.


[Bug][CI] integration tests not currently running in ci_gpu image

When looking at recent CI test run (which I'm enabling torch/ONNX tests on AArch64), I noticed an issue with a missing transformers package while executing test_meta_schedule_integration_extract_from_bert_base , causing the integration tests to fail on AArch64.
Investigating the issue a bit deeper, it seems that integration tests are not running on ci_GPU image, which is the one that is supposed to contain torch and therefore would reproduce the problem.
I'm raising this issue just because I won't have the time in the next weeks to enable that package and test the GPU image and test it to solve the problem. So I create this PR https://github.com/apache/tvm/pull/12528 to make the test to be properly skipped if transformers is not installed, but leaving this issue so that we can investigate two potential problems:

Integration tests not running in the GPU environment
Missing transformers installation, if that is what we want (pending to be confirmed, I didn't fully investigate)

cc @Mousius @areusch @driazati @gigiblender

ONNX testing that runs as part of Integration tests is also not running anywhere.
https://github.com/apache/tvm/pull/12532

@gigiblender is it possible to leverage https://github.com/apache/tvm/pull/12436 to add another GH check to assert we aren't skipping a couple of critical integration tests in a PR?

@gigiblender is it possible to leverage #12436 to add another GH check to assert we aren't skipping a couple of critical integration tests in a PR?

Sure thing. We could change that script to pass a list of critical tests to ensure that some tests are not skipped and call it in a GH check.


Check release 0.1.7 / 0.2.0

I believe the release for #5 might have an issue, because when I look at npm: https://www.npmjs.com/package/payload-plugin-oauth?activeTab=code
I still find this line, which should have || webpackConfig at the end, I believe! 😬
const config = ((_b = (_a = incoming.admin) === null || _a === void 0 ? void 0 : _a.webpack) === null || _b === void 0 ? void 0 : _b.call(_a, webpackConfig)) || {};

The original error I got was
TypeError: Cannot read properties of undefined (reading 'publicPath')
    at initWebpack (my-project/node_modules/payload/src/webpack/init.ts:18:14)
    at initAdmin (my-project/node_modules/payload/src/express/admin.ts:29:34)
    at initHTTP (my-project/node_modules/payload/src/initHTTP.ts:51:14)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Payload.init (my-project/node_modules/payload/src/index.ts:14:21)

and an easy workaround is to simply change the payload config like this:
export default buildConfig({
  // ...
  admin: {
    user: Users.slug,
    webpack: config => config,    // <-- add this line
  },
  // ...
});

Indeed that's a bug that should be released soon! I have several other fixes that I would like to add to. Like removing the dependency on the plaintext password.

Hi, do you mind trying again with v0.3.0?

With 0.3.0, I get a different error:
Error! Error: Cannot find module 'connect-mongo'
Require stack:
- ~/my-project/node_modules/payload-plugin-oauth/dist/index.js
- ~/my-project/src/plugins.ts
- ~/my-project/src/config.ts
- ~/my-project/node_modules/payload/dist/config/load.js
- ~/my-project/node_modules/payload/dist/payload.js
- ~/my-project/node_modules/payload/dist/initHTTP.js
- ~/my-project/node_modules/payload/dist/index.js
- ~/my-project/src/server.ts
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1021:15)
    at Function.Module._load (node:internal/modules/cjs/loader:866:27)
    at Module.require (node:internal/modules/cjs/loader:1093:19)
    at require (node:internal/modules/cjs/helpers:108:18)

Somehow I cannot see the changes in the repository, but when looking at my node_modules folder, it looks like "connect-mongo" has been added as a dependency. But it's in devDependencies, so it's not used by depending modules

Ow, will fix! You can workaround it by installing it with npm install connect-mongo

Released v0.3.1


Inform new users about their sandbox

In order to encourage usage and deter support requests, new users should be informed about the existence/restrictions/acceptable use of their sandbox, and a pointer to further docs.

@nikzei @berndverst turning this one over to you to determine if it's still useful or not.

Long since done.


Questions regarding CDR results and noise_classifier

Hello.
I have run this bran code for the CDR dataset several times and now I have few questions.
I found that the results printed on the STDOUT are from the ner_eval and the relation_eval functions.
Also I found that the "Best" score in the following sentence "Eval decreased for %d epochs out of %d max epochs. Best: %2.2f" is the result from the development part most of the time.
For some reason, when I run the code for CDR dataset (with no additional data), the F-score from the test set is 60% in average. I think my configuration is the problem. I have following weird STDOUT logs. But I got stuck here with no improvement for days.  Could you give me some help, please?

The performance difference may be due to the embedding dimension?
In the paper, the authors used embedding dimension 128 for CTD dataset, while default code setting of dimension size is 64.
Then again, why do you set the default dimension size as 64?

I don't think it is the embedding dimension, the numbers I got were using 64 dim for the CDR dataset. Running the code as is will train a model with early stopping defined by the 'best score' on the development set. Then that best model would be used to generate a test set score.
A few possibilities  for your issue could be
1- the train / development split is being selected by a random 85/15 % split. This causes variance in the performance of the model. The reported numbers were averaged over 10 runs.
2- the tensorflow version could be impacting the results. I was using tf version 1.0.1. I noticed different versions of tf sometimes led to slight variations in the models performance.

Thank you for the answer.
I am using the tensorflow 1.0.1 version. The train/dev split may be the cause, I guess?
What do you think about the  "Couldnt get noise_classifier/score_sentence/ner_w_1" log? If you give a hint, I could look for the root of the problem.

This message is coming from here: https://github.com/patverga/bran/blob/master/src/train_multiclass_classifier.py#L362
This is a vague and poorly worded warning that comes up when creating moving averages for the trainable variables in the graph. This is something I need to fix.
For each variable in tf.trainable_variables, we try to set up a moving average. For those that do not succeed, it prints out this 'could not get variable' message. I believe that this may be something you don't have to worry about and results from tf.trainable_variables simply returning things that can't be set up with a moving average.

Okay, Thanks for a lot of help.


How to get a hold of the Testnet collateral token?

I'm trying to run the test_integration.py file, and I want to make some orders with fake money on ropsten. I've made a lot of progress up until the deposit_to_exchange line. It looks like I need to have some USDC to deposit into my account, and I have tried that on the mainnet and it works!
However this doesn't seem to be working on the ropsten testnet! I used uniswap to get some usdc, but looks like dydx is using this token instead. Is there a faucet for this token? How can I get a hold of this token? I can see the token on ropsten, and that a whole bunch of people own it, but I don't know how to get some for my own testing purposes.

What node do you use? You have encountered the error code The method eth_signTypedData does not exist/is not available

you can open a Live Chat request on the exchange, and customer service can send you testnet usdc token


hello,  Will they keep updating CI3?

hello,
Will they keep updating CI3?

Hopefully 🚀

yes they will

Cheers for v3 staying v3 :clap: it's a classic.
To this day Code Igniter v3 is still highly unique and innovative in the PHP ecosystem-

Simplicity, low code.
Low cognitive overhead.
Zero dependencies.

I am so thankful that v4 was a fork. It would have been a major loss if architecture astronauts messed up v3.

Any news on php 8.2 support for ci3?

Following the discussion in the CodeIgniter Forum it looks like there is no one left to maintain CI3, so its not likely to get any more updates here.

Cheers for v3 staying v3 👏 it's a classic.
To this day Code Igniter v3 is still highly unique and innovative in the PHP ecosystem-
* Simplicity, low code.

* Low cognitive overhead.

* Zero dependencies.

I am so thankful that v4 was a fork. It would have been a major loss if architecture astronauts messed up v3.

I am extending a copy of CodeIgniter 3 here: https://github.com/sylynder/webby, https://github.com/sylynder/engine. I am also borrowing some concepts from CodeIgniter 4


Run all rust code through rustfmt

I've set up my Vim to run rustfmt whenever I save a file. It helps give
all of our code a consistent style which I think makes work easier.
 My commit might be changing a single test, but every line
of the file would get tweaked by rustfmt.
So I'm rustfmting everything to get us to a common baseline.
Still have to figure out how to make all future code use rustfmt.

I don't see anything controversial, but I'm open to any feedback before merging.

nice, there are a few changes in here (nitpicky things like the presence or absence of spaces or trailing commas) that I would have liked to see, good that they're getting done automatically
I have a few questions about places where specific placements of newlines really help to visualize the input better. as I mentioned in line comments, I don't like having to fight an automated tool by reverting its change every time; is there a way we can signal it that the newlines should stay for those cases? you may have to bear with me on that question since I've not used rustfmt before :x

When I get a chance I want to see how/if rustfmt can be customized. Then maybe we can address some of the more problematic changes it made.

I decided that I didn't want to fight all the cases where our current formatting was appropriate. Closing.


Cannot install new plugins due to error of another plugin

Explain the problem here ...
I want to install some new plugins and I typed 'PlugInstall'. However, I observe the following:
Error Detected while processing .vim/plugged/LaTeX-Suite-aka-Vim-Latex/plugin/remoteOpen.vim
line 33:
Command already exists: add ! to replace it
After that, I find that my new plugin is not installed...

:version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jan  2 2014 19:39:47)
Included patches: 1-52
Modified by<EMAIL_ADDRESS>Compiled by buildd@
Huge version with GTK2-GNOME GUI.  Features included (+) or not (-):
+acl             +conceal         +farsi           +libcall         +mouse_netterm   +profile         +syntax          +visualextra
+arabic          +cryptv          +file_in_path    +linebreak       +mouse_sgr       +python          +tag_binary      +viminfo
+autocmd         +cscope          +find_in_path    +lispindent      -mouse_sysmouse  -python3         +tag_old_static  +vreplace
+balloon_eval    +cursorbind      +float           +listcmds        +mouse_urxvt     +quickfix        -tag_any_white   +wildignore
+browse          +cursorshape     +folding         +localmap        +mouse_xterm     +reltime         +tcl             +wildmenu
++builtin_terms  +dialog_con_gui  -footer          +lua             +multi_byte      +rightleft       +terminfo        +windows
+byte_offset     +diff            +fork()          +menu            +multi_lang      +ruby            +termresponse    +writebackup
+cindent         +digraphs        +gettext         +mksession       -mzscheme        +scrollbind      +textobjects     +X11
+clientserver    +dnd             -hangul_input    +modify_fname    +netbeans_intg   +signs           +title           -xfontset
+clipboard       -ebcdic          +iconv           +mouse           +path_extra      +smartindent     +toolbar         +xim
+cmdline_compl   +emacs_tags      +insert_expand   +mouseshape      +perl            -sniff           +user_commands   +xsmp_interact
+cmdline_hist    +eval            +jumplist        +mouse_dec       +persistent_undo +startuptime     +vertsplit       +xterm_clipboard
+cmdline_info    +ex_extra        +keymap          +mouse_gpm       +postscript      +statusline      +virtualedit     -xterm_save
+comments        +extra_search    +langmap         -mouse_jsbterm   +printer         -sun_workshop    +visual          +xpm
system vimrc file: "$VIM/vimrc"

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[x ] Linux (Ubuntu 14.04)
[ ] OS X
[ ] Windows

Vim:

[ ] Terminal Vim
[x ] GVim
[ ] Neovim

It doesn't sound like a bug of vim-plug. Can you provide the steps to reproduce the problem?
Another issue is that I cannot delete the LaTeX-Suite-aka-Vim-LaTeX plugin. I tried to delete the folder ~/.vim/plugged/LaTeX-Suite-aka-Vim-LaTeX and remove Plug 'https://github.com/vim-scripts/LaTeX-Suite-aka-Vim-LaTeX.git' from .vimrc. However, whenever I run PlugInstall, it keeps trying to install the plugin for me which consistently run into the same problem
Error Detected while processing .vim/plugged/LaTeX-Suite-aka-Vim-Latex/plugin/remoteOpen.vim
line 33:
Command already exists: add ! to replace it

It means that the plugin is installed but it is broken. You might want to look for the alternatives.

Another issue is that I cannot delete the LaTeX-Suite-aka-Vim-LaTeX plugin.

Make sure to restart Vim or reload your .vimrc after modifying the plug section.

If you already created another vim source file (vimrc or init.vim) that pointed on the same folder than '/tmp/plugged', it is normal.
To one Plug folder associate an unique vim  source file!


Migrate documentation for all datetime functions from scalar_functions.md to code

Is your feature request related to a problem or challenge?
As part of https://github.com/apache/datafusion/issues/12740 this ticket is to migrate all the existing documentation for the above named functions from the static documentation to code and to remove them from the static file.
Here is the current static content:

doc source: https://github.com/apache/datafusion/blob/main/docs/source/user-guide/sql/scalar_functions.md
rendered: https://datafusion.apache.org/user-guide/sql/scalar_functions.html
Code source: https://github.com/apache/datafusion/tree/main/datafusion/functions/src/datetime

Need Functions:
(see source)
Describe the solution you'd like
One (or more) PRs that

port the documentation for the above named functions from the static docs to code
Bonus points:  add sql examples should be added for all functions
Remove the documentation from the static docs

Here are some example PRs of doing this:

https://github.com/apache/datafusion/pull/12840 from @jonathanc-n
https://github.com/apache/datafusion/pull/12775 from @Omega359
https://github.com/apache/datafusion/pull/12742

Describe alternatives you've considered
No response
Additional context
No response

I think this is a good first issue as the pattern is clear and it would be a good way to learn how the process works

take

take

Thanks @jatin510  🙏
BTW @jonathanc-n notes on https://github.com/apache/datafusion/issues/12740#issuecomment-2406512268

@alamb I think it should be mentioned here that ./dev/update_function_docs.sh should be ran, as it wasn't immediately obvious, and when I did my first migration I took a bit of time to find it.

Just checking in on how this is going @jatin510  -- if you don't have time, perhaps I can unassign you so others could work on it

I will create a PR by tomorrow @alamb


[feature] painted redstone Block

for some occasions it would be nice to be able to "hide" a redstone block .. making it paintable would definately be handy for that case

Since this suggestion is already up, I give this an imaginary upvote. More paintable "utility blocks" could be handy.


[Question] Working with DnD and PrimeReact's DataTable

So I'm currently working on a new React page that uses PrimeReact's DataTable and React DnD.
On this page, the user will be able to drag a specific table cell, to a grid
Cell: (the other cells of this table are irrelevant)

Grid:

I managed to implement the drag and drop correctly (nice documentation btw :))
Main.tsx:
const [list, setList] = useState<...>(...)

myDropMethod = () => {...}

return (
        <>

            <Grid />
        </>
    )

Table.tsx:
    const myNumberBody = (rowData) => {
        return <MyNumber number={rowData.myNumber} />
    }
    return (
        <DataTable value={[...list]}>
            <Column field="..." header="..." body={myNumberBody} />
        </DataTable>
    )

MyNumber.tsx (drag) :
export const MyNumber = ({myNumber}) {
    const [, drag] = useDrag(() => ({
        type: 'MyNumber',
        item: { myNumber: myNumber },
    }))

    return
{myNumber}

}

Grid.tsx (drop) :
const [myNumber, setMyNumber] = useState<...>(...)

    const [{ isOver }, drop] = useDrop({
        accept: 'MyNumber',
        drop: () => myDropMethod(),
        collect: (monitor) => ({
            isOver: !!monitor.isOver(),
        }),
    })

    return (

            <MyNumber myNumber={myNumber!} />

    )

To improve my page's UX, I decide to remove the rows that were dropped on my grid. To do that, i changed the myDropMethod on my Main.tsx:
myDropMethod = (myNumber) => {
    setList((oldList) => oldList.filter(number) => number !== myNumber)
}

So, theoretically, if my list is: [1, 2, 3] and I drag and drop the number 1, "myNumber" will be 1 and my list will turn into [2, 3]
(And that's what it happens):

The problem is that, when I try to move the number 2 (whose index is now 0), "myNumber" will still be number 1 and it won't drag to my Grid... If I try to move the number 3 (whose index is now 1), "myNumber" will be number 2 (not 3).
So it seems like DnD is using the original list instead of the one that was filtered on myDropMethod()
Is this supossed to happen? Am I doing something wrong?

It turns out that that I was missing 'deps' on my useDrag:
export const MyNumber = ({myNumber}) {
    const [, drag] = useDrag(() => ({
        type: 'MyNumber',
        item: { myNumber },
    }), [myNumber])

    return
{myNumber}

}


Code Quality Checks

This PR adds the below code quality checks

[X] linting
[X] undefined behavior checks
[X] formatting

All checks are currently done in a non-blocking way so you can still merge on code quality failures if you so choose.

The formatting and linting issues noted can be remedied by running the following commands and pushing back to the repo
cargo fmt
cargo clippy --fix

I can do so within this PR if desired.

Miri check takes a while might be best to limit it to a set of packages. Right now, I have it do everything which might not be necessary.

adding clippy and rustfmt to the CI are good ideas. but i think we should wait a bit before adding miri. i need to adjust the tests so they don't take forever with miri, by limiting the input sizes and whatnot.

On a subsequent run if files reduce coverage it'll be output see https://github.com/nextest-rs/nextest/pull/625#issuecomment-1304278083
In terms of seeing how it stands today as far as I know it requires going to see the full report on codecov. But I'll look into it to see if it can be placed in the comments

I'll comment it out with a note stating it should be readded at that time

perfect! merging this


fix: loading page buttons

This PR basically provides a fix for the issue #728 in which there was a problem with the buttons in the loading screen component whose content was overflowing while the screen size was transitioning from medium screen size to phone screen size.
On fixing the css I could fix the overflowing issue and made it responsive for all screen sizes below is a screenshot of the fixed component.

Summary by CodeRabbit

Style

Updated the layout of buttons on the loading screen for improved alignment and spacing.

Too many formatting changes

Initially the checks were failing due to formatting issues but I fixed them and now all of the checks are passing, is there any other issue with the PR ?

We dont have a formatting check yet, your files have so many double single quote changes

I just made necessary changes for one file how come there are issues in the other files?

Probably some extension like Prettier, check -> https://github.com/digitomize/digitomize/pull/771/files

Is there any suggested formatter that this project uses so that I can make the formatting according to that?

Try running npm run eslint-fix and/or npm run format:write

Too many changes + conflicts


the prolem is with npm installation.What is that issue related with call.Thanks in adance

C:\Users\sys>npm clear cache
'CALL "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js"
prefix -g' is not recognized as an internal or external command,
operable program or batch file.

This looks like an npm issue, not a CLI issue... closing.


Update documentation for flatten

Thanks! Perhaps this could be changed to say "roughly equivalent"? I like the brevity of just using then, and I feel like being 100% correct is why the combinator exists and we perhaps don't need to spell it out in the docs.

Perhaps I am misunderstanding something, but self.then(|x| x) does not typecheck in my head, nor can I get a variation of it to typecheck in my test program.
Perhaps you meant "roughly equivalent to self.and_then(|x| x)? I actually considered writing something along those lines initially.

Oh hm yes I think you're right! I do think this is more equivalent to and_then(|x| x)

PR updated!

Thanks!


x/tools/godoc/vfs: missing root directory listing when mounting vfs.NameSpace via httpfs and serving by http.FileServer

I'm trying to mount a few folders into a virtual file system via vfs.NameSpace and serving them using http.FileServer through a httpfs.New(). I am unable to see a listing of the root folder of NameSpace and get a 404 page not found.
Interestingly, when i do NameSpace.ReadDir("/") on the NameSpace and loop through the results, i see the expected folders. There are also no problems getting a directory listing via either http.Dir() or httpfs.New(vfs.OS("FolderName")).
Also when I directly browse the mounted folders (as explained below), I see the folders mounted properly. Only the root directory is not listing.
package main

import (
	"golang.org/x/tools/godoc/vfs"
	"golang.org/x/tools/godoc/vfs/httpfs"
	"log"
	"net/http"
	"os"
)

func main() {
	// Binding two folders to the namespace
	ns := vfs.NameSpace{}
	ns.Bind("/music", vfs.OS("Folder1"), "/", vfs.BindReplace)
	ns.Bind("/videos", vfs.OS("Folder2"), "/", vfs.BindReplace)

	// Reading the root of the namespace. This works as expected and prints "music" and "videos"
	fis, err := ns.ReadDir("/")
	if err != nil {
		log.Println(err)
		os.Exit(1)
	}

	for _, fi := range fis {
		log.Println(fi.Name())
	}

	// This works when browsing http://<IP_ADDRESS>:9090/music/ or http://<IP_ADDRESS>:9090/videos/
	// but produces a 404 not found when browsing http://<IP_ADDRESS>:9090/. The expected behavior
	// should be that a directory listing showing the folders music and videos should be displayed.
	http.Handle("/", http.FileServer(httpfs.New(ns)))
	http.ListenAndServe(":9090", http.DefaultServeMux)
}

godoc never relies on that functionality so it's possible it's just a bug we never noticed.

I have figured out the reason this bug is happening. The issue is that behavior of vfs.NameSpace is not consistent with expectations of how a normal file system behaves and that causes typical directory traversal algorithms to break on vfs.NameSpace.
The issue is that NameSpace is implemented with the implicit assumption that it will be used with a FileSystem mounted at root mount point with other FileSystems mounted somewhere within that. This is of course the use case of godoc as also explained in the  documentation of vfs.NameSpace where GOROOT is being mounted at root.
The use case above mounts several folders under root but nothing at root breaking this implicit assumption. Unless we explicitly bind a FileSystem directory at root mount-point "/" of vfs.NameSpace , running Open() or Stat() on root "/" causes a not found error (or a return value that won't be a directory if we mount a file). This happens even though ReadDir() correctly resolves and lists the contents of the root directory as expected.
Most algorithms that traverse a directory structure either Open() or Stat() the root before reading the contents. The not found error that comes when a directory is not explicitly bound at the root mount causes the traversal routine to fail fast without trying to list directory contents. This happens in http.FileServer and I had a similar failure in another piece of directory traversing code I am writing.
I was able to get the right behavior by If i mount an empty directory at root like below.
package main

import (
	"golang.org/x/tools/godoc/vfs"
	"golang.org/x/tools/godoc/vfs/httpfs"
	"log"
	"net/http"
	"os"
)

func main() {
	ns := vfs.NameSpace{}
	// Folder3 is simply an empty folder to be mounted at the root mount point
	ns.Bind("/", vfs.OS("Folder3"), "/", vfs.BindReplace)
	ns.Bind("/music", vfs.OS("Folder1"), "/", vfs.BindReplace)
	ns.Bind("/videos", vfs.OS("Folder2"), "/", vfs.BindReplace)

	fis, err := ns.ReadDir("/")
	if err != nil {
		log.Println(err)
		os.Exit(1)
	}
	for _, fi := range fis {
		log.Println(fi.Name())
	}
	http.Handle("/", http.FileServer(httpfs.New(ns)))
	http.ListenAndServe(":9090", http.DefaultServeMux)
}

I think the least disruptive resolution to this issue will be to add a NewNamespace() function to create a NameSpace that automatically mounts at root mount point "/" an implementation of FileSystem that simply emulates an empty directory so this surprising behavior doesn't occur. The advantage of this approach is that absolutely nothing would change for any current usage of NameSpace by godoc and any other existing programs while new programs can just use the provided function.
Happy to work on a CL if the approach sounds ok.

I have a working implementation of a fix for this issue at https://github.com/srinathh/emptyvfs for review/discussion of the proposed solution approach.
If the approach looks ok, I can move the implementation into vfs package and initiate the code-review package.

Feel free to send a code review. In addition to being easier to review in Gerrit, it will also guarantee that you've signed a CLA (since our Gerrit doesn't allow uploads before a CLA is signed). Reviewers shouldn't be reviewing code elsewhere (e.g. your personal github repo) without knowing a CLA is on file anyway.

Thanks! Submitted CL https://go-review.googlesource.com/19445

Hi Brad, did you get a chance to review the CL?


The location of buttons in wiki home page is wrong?

Description

Gitea Version
latest
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None

Looks a regression from https://github.com/go-gitea/gitea/pull/29894, I will investigate. Looks this CSS is missing:
.ui[class*="right aligned"].grid > .column,
.ui[class*="right aligned"].grid > .row > .column,
.ui.grid > [class*="right aligned"].row > .column,
.ui.grid > [class*="right aligned"].column.column,
.ui.grid > .row > [class*="right aligned"].column.column {
  text-align: right;
  align-self: inherit;
}


TypeError: undefined is not a constructor (evaluating 'new nativescript_geolocation_1.Location()')

My package.json is as follows:
"nativescript": {
"id": "org.nativescript.test",
"tns-ios": {
"version": "2.5.0"
}
},
"dependencies": {
"@angular/common": "2.4.3",
"@angular/compiler": "2.4.3",
"@angular/core": "2.4.3",
"@angular/forms": "2.4.3",
"@angular/http": "2.4.3",
"@angular/platform-browser": "2.4.3",
"@angular/platform-browser-dynamic": "2.4.3",
"@angular/router": "3.4.3",
"nativescript-angular": "1.4.0",
"nativescript-couchbase": "^1.0.17",
"nativescript-geolocation": "0.0.19",
"nativescript-theme-core": "~1.0.2",
"reflect-metadata": "~0.1.8",
"rxjs": "~5.0.1",
"tns-core-modules": "2.5.1"
},
"devDependencies": {
"babel-traverse": "6.23.1",
"babel-types": "6.23.0",
"babylon": "6.16.1",
"lazy": "1.0.11",
"nativescript-dev-android-snapshot": "^0..",
"nativescript-dev-typescript": "~0.3.5",
"typescript": "~2.1.0",
"zone.js": "~0.7.2"
}
I get the following error at runtime when it tries to create a new instance of the Location class on iOS:
TypeError: undefined is not a constructor (evaluating 'new nativescript_geolocation_1.Location()')

Hello
Just got nativescript_geolocation_1.Location is not a constructor on Android

Hi
I'm getting  "nativescript_geolocation_1.Location is not a constructor" on android when tried to use: let myLocation = new Location();

I get the same error when I tried to getDistance() with nativescript-sdk-examples-ng....
Any idea?

@MentalRender Here's my comment from the other now closed ticket.

This issue stems from the fact that Location is defined in location.d.ts, but in reality is not exported by nativescript-geolocation module, so the following code compiles but fails at runtime.
import { isEnabled, enableLocationRequest, getCurrentLocation, Location, distance } from "nativescript-geolocation";
The solution is to import module that exports the class for real, which is nativescript-geolocation-common. The following code works correctly:
import { isEnabled, enableLocationRequest, getCurrentLocation, distance } from "nativescript-geolocation";
import { Location } from "nativescript-geolocation/nativescript-geolocation-common";

I don't know how such discrepancy between definition file and real code got into the release. Feel free to tag is a bug.

@MentalRender, thanks for investigating that.
The Location class is now exported by default and the issue is not reproducible anymore.


Update travis to build checker

hmm tried a few things, doesn't seem to be working.
@bucaran @sijad any ideas?
go get github.com/fisherman/index-check works locally, and the PATH seems to be exported.

maybe $GOPATH/bin/index-check ./index instead?

weird, but adding go install worked.


Add SkipRequest field to proxy to be able to blacklist requests

[x] Add tests
@rainforestapp/core

@shosti ready to go


Copy to Clipboard Copies $ Symbol with Command

Describe the bug
When using the "Copy to Clipboard Icon" feature on the web page, the $symbol (which denotes the command prompt) is also being copied along with the actual command. This causes issues when pasting the command into a terminal, as users have to manually remove the $ symbol to execute the command.
To Reproduce
Steps to reproduce the behavior:

Go to https://google.github.io/mesop/getting_started/installing/
Click on the "Copy to Clipboard icon" next to the command.
Paste the copied command into a terminal.
$ will also be copied there

Expected behavior
Only the command should be copied to the clipboard, without the $ symbol.
Actual Behavior
The command, along with the $ symbol, is copied to the clipboard.
Example
For instance, if the command displayed is:
$ pip install mesop
The copied content should be:
pip install mesop
However, the actual copied content is:
$ pip install mesop
Impact:
This issue requires users to manually remove the $ symbol every time they paste the command, leading to a less smooth user experience.
Suggested Solution:
Modify the "Copy to Clipboard Icon" functionality to exclude the $ symbol from the copied content.
Desktop System Info

OS: Ubuntu
Browser: Chrome

Additional context
Add any other context about the problem here.

I would love to work on this issue, please assign it to me.
Thank you!

Hi @DeepakKumarKhatri thanks for reporting this! I noticed this too and I agree it's annoying.  We use mkdocs material for our docs site: https://squidfunk.github.io/mkdocs-material/
Specifically it's this feature https://squidfunk.github.io/mkdocs-material/reference/code-blocks/?h=code#code-copy-button which does the copy to clipboard. Maybe you could file an issue at https://github.com/squidfunk/mkdocs-material and see if you can contribute a fix there? Thanks.