RFC: Tech Plan Decision Making Process

Proposal:
The goal of this RFC is to clarify our decision making process for Technical Plans and ensure that teams know how to proceed forward with the highest quality decision. This RFC will focus on roles and responsibilities as well as expected resolution time (72hrs).
tl;dr

Get feedback fast, from the relevant folks and async if need be.
Don’t wait for the next practice meeting to work on stuff laid out in a tech plan. Resolve tech plans in 72hrs.
Practice meetings are best for radiating intent and information. You can always incorporate more feedback on the fly if relevant.
In doubt, escalate for quick resolution.

Roles & Responsibilities
Disclaimer: The characters mentioned in the examples below are for illustrative purpose only. Any resemblance to reality is purely coincidental. ;-)
Any engineer can take the initiative (and is encouraged) to write/champion a technical plan for a project they lead.

Erik, as the Project Lead for Avalara integration, takes on the technical plan for tax calculations.

The Tech Lead of a team is ultimately the DRI for the tech plans in their team. Their role is to ensure that any meaningful project has the appropriate amount of technical planning, that this tech plan gets the right feedback and that the right decision is landed in a timely manner. The Tech Lead also ensures that technical decisions are in line with our engineering wide technology choices and strategy.

Chung-Yi, as the Tech Lead for Purchase team, ensures that every meaty project has a tech plan and that these tech plans help the Purchase team deliver the right features at the right time and that, overall, they get our company-wide tech stack to a better place. He is glad to see that Erik volunteered for the Avalara tech plan. He’ll keep a close eye on it and will provide Erik with the support and guidance he needs to make it successful.

Stakeholders review and give feedback on the technical plan. It is preferable that key stakeholders are explicitly named in the tech plan. They will usually have specific domain expertise or be closely impacted by the decisions made in this tech plan. By default, if no stakeholder group is provided, all the tech leads will be stakeholders. Stakeholders should provide feedback and inputs. If any stakeholder vetoes the tech plan, they should pair with the DRI to come up with a better plan. It is the DRI’s responsibility to digest all the feedback and land a final proposal. If it’s unclear how to resolve the feedback, they should escalate to the Decider.

To properly compute taxes, Erik needs a lot of information both from the buyer and the seller. He decides to name Jackie as a key stakeholder since she solved similar issues for shipping and also Sepand given his expertise with Exchange. Data Security is key for this project so he also seeks Jian’s advice. The finance team will need some automated reporting so Erik also adds Emma to validate the data pipeline approach.

Every tech plan needs a Decider. By default the Decider is the Product Area Engineering Lead. They may decide though to appoint someone else as the Decider if they feel the other person would be better qualified to help make the right decision. Since not all Product Areas have an Engineering Lead yet, the DRI should suggest any of the other Product Area Leads as a Decider.

Erik works with Chung-Yi on integrating the feedback from the stakeholders, they got conflicting advice and they feel stuck. They ask Sarah to step in and validate the final recommendation.

Anson wrote a tech plan for an integration with a feature flagging tool. Even if this integration will be driven by the Partner Experience team in Core Marketplace, this closely maps closely with the Platform mandate. Sarah decides to make Joey the decider for this tech plan.

The practices should be used as ideation and information radiation forums. The main goals of the practice are: to get ideas and feedback one may have missed otherwise, and to keep a broader informed of the evolution of the platform. (They are not a decision making forum.)
Suggested Timeline & Tech Plan Stages

Draft Tech Plan can be brought to practices at an early stage to ideate and workshop the best way to achieve some objectives.
Once the Tech Plan has reached the right level of clarity, it should be transitioned to the Proposed stage. At this point, the goal is to get feedback and validation from Stakeholders and Deciders within 72 hrs. The Tech Plan should be shared in the open (practice channels or #dev are good forums for this.)

By no means should the champion wait for the next practice meeting to get unblocked.

Once the final recommendation is landed, then the tech plan is Accepted (or Abandoned)
The Accepted Tech Plan can be shared with the practice for information / clarity / additional inputs.
The DRI should continue to incorporate meaningful learnings and feedback as we execute on the tech plan and can issue some Revisions.

Reasoning
Our current process is unclear and doesn't always yield high quality / fast decision making. Too often, people wait for a meeting 10 days away to land a decision. This process should clarify expectation. And as usual, I'm in favor of making more and more expectations explicit as we scale.
Exceptions:
This process is meant to be a suggested guideline to help make things more explicit. If for a specific reason, on certain occasions, you want to proceed differently, you can do so as long as you share why and explain why this process doesn't work for you so that we can iterate on it.
Additional Context:
Prior context on Technical Plans available in our playbook here.
How is this RFC resolved?

I'm looking for feedback on this way of managing technical plans. I’ll incorporate any suggestions that would make this process easier / more efficient.
If approved, then we should update the Tech Plan template to make it easier to put this into practice (i.e. clear table with Roles & Responsibilities, RFC Stage, Created Date, Due By Date, etc.).

I like the expliciteness of the technical plan procedure. I have a few questions about the practice meetings though.  How do I know which practice meeting to approach for technical plans that might have some interdisciplinary scope? I am still struggling to understand the scope/meaning of the practice groups.
In order to being able to propose innovation, one needs to have enough breathing time to grow ideas in their minds. I have seen/heard from a lot of people that they feel stressed/burned out/ overwhelmed with the sprint work and don't have the resources to focus on things aside from the tickets that they work off. Maybe this would be a topic for another RFC, but I think we need designated time slots aside from sprint work, that lets people come up with things like technical plans or sparks for ideas of improvement.
Another thing I like about this proposal is the low barrier. I feel like anyone is invited and included to switch on their brains and spark decision making.

@SamRozen I have a few points.

Resolve tech plans in 72hrs.

I think we should think in some terminal condition after this 72 hours in case of no response; even some kind of implicit acceptance/rejection, or some kind of parking lot where we can set a minimum process to drop move forward with the Technical Plan.
My suggestion here is: We can keep 72 hours with an implicit rejection (for the lack of a better term) or longer (5 working days) with an implicit acceptance. The idea would be to have some grace period to not rush the TP or not have enough eyes to check what is going to be made.
Two suggestions (and I think maybe they are out of scope):

Would be great to see somehow some clarification between the Engineering and Product technical plans.

My reasoning here is that the first one is generally more related to aspects that doesn't involve a direct proposition of value (e.g. change of processes, optimization in repositories, include a new pre-commit security check, etc ) and the last one has a direct impact on our collectors and artists (e.g. a faster load page, a new recommender system, data quality for auction results, etc).
And for the last one, would be great to have some expected results that can be attached in some KPI, metric, or product strategy (e.g. product wants to experiment with a new ranking system). This can lead to 3 things: (a) the engineer will consider a broader impact and because of that they will be more insightful when to propose a TP, (b) the team PM will see the estimated impact and will buy in the initiative, (c) as we have (a) and (b) initiatives that can steal our focus will be dropped right away even before to be proposed (and it's fine to drop ideas or rethink about them).

I think worth it at this moment do a small effort to evaluate all Technical Plans and see what makes sense and what doesn't and drop non-useful initiatives. This can help us to have a clear picture of what needs or can be done and give some sense of urgency. For instance: There are technical plans of 2019 without follow-up or even status if will be done in the future or not.

@kajatiger

How do I know which practice meeting to approach for technical plans that might have some interdisciplinary scope? I am still struggling to understand the scope/meaning of the practice groups.

I can speak for the Data Practice that I'm helping to facilitate; other practices can have different processes and specificities.
In every engineering standup on Monday, we have the round of each one of the practices with their updates and subjects. Topics vary a lot, but in Data Practice we discuss aspects that will impact other teams beyond the Data/Platform teams in a way that a bigger forum would bring not only a better collective intelligence but most of the time we have people with skin in the game participating in all discussions and giving their feedback or areas of concern.
Practical example: In a Platform Practice in April we started with the following question: "How should Artsy's system interface with Redshift?"
Basically, the goal was to discuss and align the best practice(s) related to future directions of Redshift's utilization by Artsy's systems.
Before the meeting, @ansor4 and I prepared to research, and during the discussion several points were highlighted like: (a) platforms that depend on this database, (b) concerns about latency, (c) the current state or our cluster and how near are we in the full capacity, (d) optimization avenues and future directions, (e) caveats.
If we discussed inside of Platform/Data forums I think that maybe we would go for a suboptimal route, but because our colleagues of CX and Auctions we realized that this was not the best route to take due to some limitations.

I really like this thinking overall, thanks for taking the time to write it up! I did have a question for you when I saw this part:

The Tech Lead of a team is ultimately the DRI for the tech plans in their team.

and

By default the Decider is the Product Area Engineering Lead.

I'm concerned when neither party is the author of the tech plan - are we missing an opportunity to empower the people closest to the work?

Thanks everyone for the comments so far, I'll do my best to answer everything here.
Technical plan are most often used as part of a larger project brief that includes details as to why we're doing this, measures of success etc. See for instance this one for CMS Checklist🔒
@fclesio maybe your suggestion then is just about adding a lighter weight version of the Brief Template🔒  alongside a technical plan if it's engineering driven.
@kajatiger we encourage teams to take advantage of Future Fridays to have time to ideate and explore tech driven improvements. It's a great opportunity to make incremental progress on tech initiatives outside of the normal product work. If teams get closer to an important release and don't feel they have the breathing room to take advantage of the Future Fridays, then we're also encouraged them to save these day and use multiple at once post release to catch up.
To your comment @jonallured about why being so explicit about TL and Product Area Lead responsibilities there: the intent is to provide a quick escalate path if the feedback is hard to integrate, the tech plan champion is ensure as to how to move forward. The stakeholders should be the close to the work and have valuable inputs to contribute. I also expect the Tech Lead to have a clear idea of the technical decisions made across the team and be able to support the champion even if they don't author the tech plan. Finally I've seen some tech plans in the past stuck after a discussion at the platform practice because everyone is confused as to the next step / how to proceed to decide. Having an explicit decider should help us remediate that going forward. I welcome your suggestions about a different model if you have something else in mind.

@SamRozen When you have a moment, it might be nice to update this thread with our RFC resolution template.


UX Improvements, Performance Improvements, Bug Fixes

Closes #14, closes #12, closes #9, closes #8, closes #15, closes #10, closes #7, closes #2. This PR also implements all of the necessary logic to execute arbitrage trades, which is general to specific strategies, and available in strategies/util.py. Logic for executing arbitrage trades is chain-agnostic, and incorporates IBC transfers when necessary. This PR also implements a strategy called "bellman ford," which uses negative logs to find negative cycles in a graph, which are profitable cycles. Notable performance improvements in this PR include:

async support for all queries
async utilization in DFS
Threaded separation of route execution from route discovery to enable parallel discovery and execution
Support for building with nix, which automates installation of dependencies
Implements bellman ford strategy
Implements naive strategy
Implements generic order execution

Among others.

LGTM


Create PasswordInputFieldWithToggle and

create update password dialog component

Type of change

Enhancement / new feature

Description

Create PasswordInputFieldWithToggle and
Create update password dialog component

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@ajaypratap003 Please update the PR template, and check the appropriate options, as discussed


Forgot Password Doesn't Work.

Describe the solution you'd like
The current auth solution only allows one default policy. We've added a the Sign in v2 type and would also like to add Password reset v2 but at the moment it doesn't seem like there is a way to do that.
Describe alternatives you've considered
I've added Password reset v2 in B2C and can't get App Center to use it.
Additional context
The app is written using React Native and Typescript.
Here are the userflows I've setup.

Here are the error messages I receive from iOS logs:
2020-01-07 08:02:36.243207-0700 [32910:2127782] [AppCenterAuth] ERROR: -[MSAuth startWithChannelGroup:appSecret:transmissionTargetToken:fromApplication:]_block_invoke/91 TID=2113679 MSAL 0.7.0 iOS Sim 13.3 [2020-01-07 15:02:36 - 54C4301A-3BA0-4532-AFFF-191D8F8A7570] [MSAL] acquireToken returning with error: (MSALErrorDomain, -50000) Masked(not-null)

2020-01-07 08:02:36.243219-0700 [32910:2113679] [AppCenterAuth] ERROR: -[MSAuth acquireTokenInteractivelyWithKeyPathForCompletionHandler:]_block_invoke/526 User sign-in failed. Error: Error Domain=MSALErrorDomain Code=-50000 "(null)" UserInfo={MSALErrorDescriptionKey=AADB2C90118:+The+user+has+forgotten+their+password.
Correlation+ID:+321c5073-bf17-4f98-bfcb-231044fee9d8
Timestamp:+2020-01-07+15:02:36Z
, MSALOAuthErrorKey=access_denied, MSALInternalErrorCodeKey=-42104}

This is my sign in code:
		try {
			const userInformation = await Auth.signIn();

			if (userInformation.accessToken) {
				console.log(userInformation.accessToken);
			}
		} catch (e) {
			console.log(e.message);
		}

Hi @rockarts, thanks for reaching out! We currently only support the sign-in user flow or custom policy, unfortunately. We currently don’t have an ETA on this feature yet. If it’s a blocking feature for your apps, I’d advise you to use Azure AD B2C and the MSAL SDK directly.
There's another feature request to support the forgot password user flow or custom policy. Adding it here to keep track of both requests!

@amchew Is there a way to hide the forgot password link? We put a lot of effort into getting this working with AppCenter and don't have the budget to switch to MSAL directly.


Bag file can not be used

Hi.
With recorded bag files including camera info topics and stereo images, the SLAM does not work.
It generates following error
[ERROR]: Transform is impossible. canTransform(camera_infra1_frame->camera_link) returns false
With live topics, the SLAM works super well.
Thanks.

Is the tf topic being recorded in your bag? The static transform are likely not available if I read the error correctly for the frames on the camera (the imager and the camera frame).

@hemalshahNV
Thanks for your reply.
I thought the SLAM node only subscribes stereo images and camera info topics by looking into rqt_graph.
Let me try to record /tf_static as well. I will be back soon.

For anyone who wants to try this algorithm with recorded bag files,
since recording and replaying /tf_static is not implemented in ROS2,
Use tf2_ros package's static_transform_publisher node as my launch file.
You can see the result video here: https://youtu.be/V24_xtkscjc


refactor the kubernetes provider to be provider-agnostic

Description:
For now, all the resources related process method in k8s provider are coupling deeply with k8s client, we should free these method from it.
https://github.com/envoyproxy/gateway/blob/e8b8074fc7e9a23e3e12d6ade55307b618f421fa/internal/provider/kubernetes/controller.go#L698
So I propose a refactor: the basic idea is to separate how we process resources and how we retrieve resources.
By defining Operations interface and ResourceProcessor structure, each provider can maintain their own implemention of Operations, and different provider can share the same ResourceProcessor.
type Operations interface {
    ListGateways()
    ListHTTPRoutes()
    FindReferenceGrant()
    ...
}

type ResourceProcessor struct {
    Operations
}

func (r *ResourceProcessor) ProcessGateways() {
    // use r.ListGateways() to retrieve all Gateway resources
}
func (r *ResourceProcessor) ProcessHTTPRoutes() {}
func (r *ResourceProcessor) findReferenceGrant() {}
...

we can

let k8s provider only foucs on how to retrieve resources, so does file provider
the k8s and file provider can share the same process logic for resources, and we don't need to maintain two places of code for each provider type

[optional Relevant Links:]

Any extra documentation required to understand the issue.

Make sense to me, it helps for multi-provider support.

will try to first refactor the current existing k8s provider, and then implement for the new coming file provider.

Is it possible with this refactoring that part of the gateway resources come from k8s and another part from files ( Gateway api related)?

hey @sky92zwq we'll need to update the Custom provider API and add a Aggregate ish resource provider to handle the case you highlighted


Need Laravel 10 support

Do you have a plan to release Laravel 10 support?

Yes, we will be releasing support for laravel 10 on Monday. I will try to talk to one of our devs, in case we can get it done sooner :👍. You can see the latest release PR
https://github.com/ably/laravel-broadcaster/pull/27

Meanwhile, you can install package as a GitHub package , to use it in laravel 10 https://stackoverflow.com/questions/38323965/installing-github-package-into-laravel-project-using-composer

Hi @takielias, we have made the official release. You should now be able to use the package using composer install  .
Thanks


Kconfig.mcux: Implicit selection of HAS_CMSIS_CORE leads to config warnings in external module

Describe the bug
After https://github.com/zephyrproject-rtos/zephyr/pull/63120 got merged, some Kconfig-related warnings started appearing in SOF CI builds. An example of such warnings can be found at https://github.com/thesofproject/sof/actions/runs/6399998324/job/17372971808 (i.MX93) and https://github.com/thesofproject/sof/actions/runs/6333016092/job/17200480375 (i.MX8MP). The i.MX8MP-related issues were fixed by https://github.com/zephyrproject-rtos/zephyr/pull/63279 but then the i.MX93-related issues started appearing.
To Reproduce
Steps to reproduce the behavior:

inside the sof directory, run: west build -p --build-dir build-imx93_a55 -b mimx93_evk_a55 ${SOF_PATH}/modules/audio/sof/app, where SOF_PATH is the path to the SOF root directory.
See error

Expected behavior
There should be no HAS_CMSIS_CORE-related warnings.
Impact
I'd say it's rather an annoyance as it makes the CI builds fail.
Fix
https://github.com/zephyrproject-rtos/zephyr/pull/63558 should solve this.

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/63558, closing.


[Bug]: ngx-Editor text and text field hidden

What happened?
when adding multiple ngx-editor on same page,
( 1 ) when I have one editor on top and typed something then add another editor on the same page, previous typed value automatically gone.
( 2 ) placing multiple editors column wise on the same page text field ( editor menu and editor ) only showing on last editor, other only have ( editor menu )
Version
v13
Angular Version
v13.1.3
What browsers are you seeing the problem on?
Chrome
Link to reproduce
No response
Relevant log output
No response
Willing to submit a PR?
No response

Make sure you are creating new Editor instance for each editor. If you use the same editor instance for all components. Only the last item will be rendered.

It Works , Thanks for the Valuable Comment 👏

I created different instance for each editor but not working

Sorry for the delay in response. Please share a reproducible stackblitz to help debug this better.

Please reopen the issue with a reproducible example if the issue still exists


Can not create multiple assignments

Describe the bug
After creating an assignment, instructors can not create another assignment. When clicking on the create button nothing happens. (no request is sent as well)
It looks like the assignment creation form is not correctly initalised the second time around.
Only after closing the course management window and reopening it the assignment creation works again.

Closed by PR https://github.com/TU-Wien-dataLAB/Grader-Service/pull/154


AMBARI-24259. Let custom TrustStore settings saved in ambari.properties when configuring LDAP just like we did it in 2.6

What changes were proposed in this pull request?
Due to our changes in 2.7 we kept the reference of two different trust stores within Ambari:
the trust store created just after HTTPS was enabled
the optional custom trust store that the user could setup while configuring LDAP
In Ambari 2.6 we used the same properties in ambari.properties when setting any of the above; the related properties became overwritten. Whereas in 2.7 we saved the LDAP data in the DB which led to different security issues (such as Ambari's TS could not be open because of password mismatch, errors while syncing LDAP users/groups, etc...)
To avoid this issue we decided to follow the same pattern we had before and save LDAP TS related properties in ambari.properties in 2.7 too. Therefore the functionality does not change and end users can configure their environment as usual.
How was this patch tested?
Manually testing ldap-configuration and ldap-sync:
Setup custom LDAP TS, restarted the server and synced test users/groups:
root@ctr-e138-1518143905142-391100-01-000006 ~]# ambari-server setup-ldap --ambari-admin-username=admin --ambari-admin-password=admin
Using python  /usr/bin/python
...
====================
Review Settings
====================
Primary URL Host* :  XXX
Primary URL Port* :  636
Use SSL* [true/false] (false):  true
User object class* (person):  user
User name attribute* (uid):  XXX
Group object class* (posixGroup):  group
Group name attribute* (cn):  cn
Group member attribute* (memberUid):  member
Distinguished name attribute* (dn):  distinguishedName
Base DN* (dc=ambari,dc=apache,dc=org):  XXX
Referral method [follow/ignore] :  follow
Bind anonymously* [true/false] (false):  false
Handling behavior for username collisions [convert/skip] for LDAP sync* (convert):  convert
Force lower-case user names [true/false] : false
Results from LDAP are paginated when requested [true/false] : false
ambari.ldap.connectivity.bind_dn: XXX
ambari.ldap.connectivity.bind_password: *****
ssl.trustStore.type: jks
ssl.trustStore.path: /tmp/ambari-server-truststore
ssl.trustStore.password: *****
Save settings [y/n] (y)? y
Saving LDAP properties...
Saving LDAP properties finished
Ambari Server 'setup-ldap' completed successfully.

[root@ctr-e138-1518143905142-391100-01-000006 ~]# grep ssl.trustStore /etc/ambari-server/conf/ambari.properties
ssl.trustStore.password=${alias=ambari.ssl.trustStore.password}
ssl.trustStore.path=/tmp/ambari-server-truststore
ssl.trustStore.type=jks

[root@ctr-e138-1518143905142-391100-01-000006 ~]# ambari-server restart
...
Server started listening on 8443

DB configs consistency check: no errors and warnings were found.

[root@ctr-e138-1518143905142-391100-01-000006 ~]# ambari-server sync-ldap --user /tmp/users.txt --groups /tmp/groups.txt --ldap-sync-admin-name admin --ldap-sync-admin-password admin
Using python  /usr/bin/python
Syncing with LDAP...

Fetching LDAP configuration from DB.
Syncing specified users and groups....

Completed LDAP Sync.
Summary:
  memberships:
    removed = 0
    created = 3
  users:
    skipped = 0
    removed = 0
    updated = 0
    created = 20
  groups:
    updated = 0
    removed = 0
    created = 2

Ambari Server 'sync-ldap' completed successfully.

Removed custom LDAP TS:
[root@ctr-e138-1518143905142-391100-01-000006 ~]# ambari-server setup-ldap --ambari-admin-username=admin --ambari-admin-password=admin
Using python  /usr/bin/python
...
Do you want to provide custom TrustStore for Ambari [y/n] (y)?n
The TrustStore is already configured:
  ssl.trustStore.type = jks
  ssl.trustStore.path = /tmp/ambari-server-truststore
  ssl.trustStore.password = ${alias=ambari.ssl.trustStore.password}
Do you want to remove these properties [y/n] (y)? y
====================
Review Settings
====================
...
Save settings [y/n] (y)? y
Saving LDAP properties...
Saving LDAP properties finished
Ambari Server 'setup-ldap' completed successfully.

[root@ctr-e138-1518143905142-391100-01-000006 ~]# grep ssl.trustStore /etc/ambari-server/conf/ambari.properties
[root@ctr-e138-1518143905142-391100-01-000006 ~]#

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3004/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3006/
Test FAILed.
Test FAILured.


Packaging on OSX using Kivy.dmg is not working

With Kivy 2.0 and master:

The Script at Kivy.app/Contents/Resources is currently broken.

Does not account for spaces in path
Does not work with main.pyc
Instructions are too verbose and don't always work.

App launched in low res mode when packaged.

@akshayaurora: This has been self-assigned for a while. Are you still working on it, or should we unassign it?


!tts reload - make sure to do cacheless reload

location.reload(true); instead of location.reload();

location.reload(true) is deprecated. Will have to use some version string stuff

Seems to be working just fine without.


Considerer using cross in our CI

We should discuss using cross in our CI infrastructure.
Pros

easier to maintain
support to new targets when they are added
faster builds? (download the docker image vs build the docker image)
...

Cons

not all targets are available for testing (like bsd targets, in this case we would continue to use the actual approach)
lost of control (we are adding a external dependecy)
...

What do you think @alexcrichton?

I'd personally prefer to stick to custom docker images because we tend to want pretty fine-grained control over things like the libc version and versions of various tools installed, and yeah we'd still have to carry support for things like freebsd/openbsd I believe?

I'd personally prefer to stick to custom docker image

cross allows you to specify your own docker images, which don't necessarily need to be based on the cross ones (although cross provides some images that one can build on top). I've been able to reuse cross one in some cases (e.g. adding objdump for usage in stdsimd), but I had to specify my own in other cases (cross ships an "as old as reasonable" libc, and if you need a newer one, you can't build on top of a too old ubuntu distribution).

and yeah we'd still have to carry support for things like freebsd/openbsd I believe?

Yeah in complicated projects cross isn't a replacement for everything, but more like a replacement for X% of the boilerplate. For example, in stdsimd we have the Intel SDE emulator which cross does not "natively" support, so for some "weird" targets one will always need some sort of custom ci system.

However, stdsimd only currently uses qemu-user which is relatively simple to set up. The amount of boiler-plate required to use, for example, qemu-system is much larger. Iff cross is able to remove that it might be worth considering using cross at least for the qemu-system targets.

@malbarbo for targets that we are not currently testing, but that cross does support, I wouldn't mind us to start adding CI build jobs that use cross to test them. I think something is better than nothing here.
However, as @alexcrichton pointed out, we want some fine grained control about some parts of the environment used, like the glibc version. It would be great if cross could support that.

So cross is so unmaintained that I don't think this makes sense anymore. Basically cross goals are only supporting the oldest possible glibc versions that actually can compile, while libc needs also to expose newer APIs and be able to test them.


Trigger imgix modal

Stacked PR Chain: PE-1579-1

PR
Title
Status
Merges Into

#86
👉 PE-1579-1 Trigger imgix modal
Pending
-

#88
PE-1579-1 refactor: memoise handle-breakout-open
Pending
#86

#89
PE-1579-1 feat: show selected image in sidebar
Pending
#88

conflicts resolved.

Closing this in favor of #93


Doesn't work for tmux >= 3

I upgraded to tmux 3 on my mac Catalina, o-my-tmux doesn't work anymore. Is there any patch I can use?

Worked with new update. Thanks.


Handle falsy boolean environment variables better

Now only empty value is seen as False and everything else is True like "0", "False".
Variables (in lower case) should be false for values: empty, n, no, f, false, off and 0

Can we unify this behavior with BigQuery
https://github.com/valohai/library-sandbox/blob/c58276aa260a2676d704ca27ab243e3b1bb4c4ae/connectors/steps/bigquery/query.py#L13


host_name not declared in EthernetClient

Just udpated my PLatformio native ethernet to a fresh zip from here and get
.platformio\packages\framework-arduinoteensy\libraries\NativeEthernet\src\NativeEthernetClient.cpp: In member function 'virtual int EthernetClient::connect(const char*, uint16_t)':
C:\Users\david.platformio\packages\framework-arduinoteensy\libraries\NativeEthernet\src\NativeEthernetClient.cpp:45:5: error: 'host_name' was not declared in this scope
host_name = host;
^
*** [.pio\build\pre_and_post_hooks\lib37c\NativeEthernet\NativeEthernetClient.cpp.o] Error 1
I assume the host_name is only used for TLS as its declared
#if FNET_CFG_TLS
fnet_tls_desc_t tls_desc = 0;
bool _tls_en = false;
const char* host_name = NULL;
fnet_uint8_t* ca_certificate_buffer = (fnet_uint8_t*)mbedtls_test_ca_crt; /* Certificate data. /
fnet_size_t ca_certificate_buffer_size = mbedtls_test_ca_crt_len;              / Size of the certificate buffer. */
#endif
I assume it can be managed by adding "#if FNET_CFG_TLS" around its use

I fixed  my copy by moving declaration of "    const char* host_name = NULL;
" outside of #ifdef

I didn’t realize I wasn’t receiving notifications for issues, this did get fixed in a previous commit.


feat(s3): allow user to specify s3 endpoint for non aws usage

This PR does the following:

Updates the Dockerfiles to be based on a newer version of alpine
Adds the DRONE_S3_ENDPOINT environment variable to allow users to specify the s3 endpoint to connect to

This is needed for services like DigitalOcean spaces and other s3 compatible services
You could argue that the AWS library should support something like AWS_ENDPOINT historically they haven't been willing to do this for any language. For example, https://github.com/aws/aws-sdk-php/issues/1239 has been open for almost two years.

Note: I've tested this update on AWS and DigitalOcean spaces.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

the build failure is a problem with the Go modules. I will patch this tomorrow morning.

Tools like Minio also require path style being set to true, otherwise it won't work.

ok, thanks for this!  do you have an example environment variables for digital ocean spaces? I would love to include them in the docs.

@tboerger I do not think digital ocean requires path style, but for minio we can definitely enable with a separate pull request. I think we will need to add a DRONE_S3_SKIP_VERIFY and DRONE_S3_PATH_STYLE variables, like this:
https://github.com/minio/cookbook/blob/master/docs/aws-sdk-for-go-with-minio.md

ok, thanks for this! do you have an example environment variables for digital ocean spaces? I would love to include them in the docs.

The instructions for DigitalOcean Spaces is almost identical to AWS, you just need to specify DRONE_S3_ENDPOINT=<region>.digitaloceanspaces.com. For example, my space (the digitalocean term for bucket) is located in the digitalocean region of sfo2, so I would set AWS_REGION=sfo2 and DRONE_S3_ENDPOINT=sfo2.digitaloceanspaces.com.
As with AWS you still need to set AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and DRONE_S3_BUCKET for everything to work. The credentials for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY can be generated on the api page.


fix: surface storage interface expectations correctly.

cc: @dmitry-fa , @athakor based on pending PRs.
We will continue to update the Storage interface and mark it as InternalExtensionOnly.

This fix is a good solution for the situation with extending the Storage interface. My question, is this change allowed?
Quoting: InternalExtensionOnly

Adding this annotation to an API is considered API-breaking.

Hi @dmitry-fa, +1 to being allowed. I went through internal review/discussion with folks. The annotation is only documentation and doesn't change how the interface can be used.
Also acknowledging that this library doesn't follow Semantic versioning strictly but looking for input from @JesseLovelace and @crwilcox on this point. I may end up removing it until later.


fabricjs scale cuts off image when using aws lambda

Steps To Reproduce
I am not sure if this is an issue with fabricjs, aws lambda, node-canvas, or I am not setting this up correctly on lambda.

Install lambda-layer-canvas-nodejs layer on lambda function
Utilize scaling to adjust image inside of canvas
height of image is then cut off, see below
I have tried using scaling by directly editing json and using loadfromjson as well as using fabric.Image.fromURL and then using scaleToWidth(1000); to scale image.
This works correctly in browser, and in nodejs example on codesandbox.io
https://codesandbox.io/s/boring-minsky-j3jxi1?file=/src/index.js
However, in lambda the image is cut off.
If I leave the scaling at the original setting of .09 then it loads correctly

Example of code from lambda:
import { fabric } from 'fabric';
export const handler = async(event, context, callback) => {
    var data = '{"version":"3.6.2","objects":[{"type":"image","version":"3.6.2","originX":"left","originY":"top","left":0,"top":0,"width":5400,"height":5400,"fill":"rgb(0,0,0)","stroke":null,"strokeWidth":0,"strokeDashArray":null,"strokeLineCap":"butt","strokeDashOffset":0,"strokeLineJoin":"miter","strokeMiterLimit":4,"scaleX":0.18,"scaleY":0.18,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"clipTo":null,"backgroundColor":"","fillRule":"nonzero","paintFirst":"fill","globalCompositeOperation":"source-over","transformMatrix":null,"skewX":0,"skewY":0,"crossOrigin":"","cropX":0,"cropY":0,"src":"https://printtech-builder.s3.amazonaws.com/tmp/27afaa61-5c7e-4307-8620-7faf14a3789d.jpeg","filters":[]},{"type":"text","version":"3.6.2","originX":"left","originY":"top","left":123,"top":125,"width":150,"height":45,"fill":"#000000","stroke":null,"strokeWidth":1,"strokeDashArray":null,"strokeLineCap":"butt","strokeDashOffset":0,"strokeLineJoin":"miter","strokeMiterLimit":4,"scaleX":1,"scaleY":1,"angle":0,"flipX":false,"flipY":false,"opacity":1,"shadow":null,"visible":true,"clipTo":null,"backgroundColor":"","fillRule":"nonzero","paintFirst":"fill","globalCompositeOperation":"source-over","transformMatrix":null,"skewX":0,"skewY":0,"text":"Some text goes here","fontSize":26.21919234397663,"fontWeight":"normal","fontFamily":"aguafina_script-regular","fontStyle":"normal","lineHeight":1.16,"underline":false,"overline":false,"linethrough":false,"textAlign":"left","textBackgroundColor":"","charSpacing":0,"styles":{}}]}';
    var canvas = new fabric.StaticCanvas(null, { width: 1000, height: 1000 });
    const resultsOf = await new Promise((resolve, reject) => {
        canvas.loadFromJSON(data, function() {
            canvas.renderAll();
            resolve('done');

        });
    });
    const response = {
        statusCode: 200,
        body: JSON.stringify(canvas.toDataURL()),
    };
    return response;
};

Generated Image:

image should look like:

No, and its been long enough now I honestly dont remember what I did to fix it.

@chrismeats , my apologies for my late response. Good to hear that it was fixed already. Hope you enjoyed using the layer. Thank you~


sbt version 1.1.4

Can you please fix conflicts and use 1.1.6 instead?

@regiskuckaertz  Conflict resolved.

Thanks a lot for your contribution 👍


Fuzzer: assertion in multi-node DCR

Failure mode:
fuzzer: .../legion/runtime/legion/legion_replication.cc:431: void Legion::Internal::ReplCollectiveVersioning<OP>::create_collective_rendezvous(unsigned int) [with OP = Legion::Internal::CollectiveViewCreator<Legion::Internal::DependentPartitionOp>]: Assertion `collective_versioning_rendezvous.find(requirement_index) == collective_versioning_rendezvous.end()' failed.
Backtrace:
#9  0x00007f2e89216f60 in Legion::Internal::ReplCollectiveVersioning<Legion::Internal::CollectiveViewCreator<Legion::Internal::DependentPartitionOp> >::create_collective_rendezvous (this=this@entry=0x7f2e0c00d420,
    requirement_index=<optimized out>, requirement_index@entry=0) at /usr/include/c++/9/bits/move.h:74
#10 0x00007f2e8921712c in Legion::Internal::ReplCollectiveViewCreator<Legion::Internal::CollectiveViewCreator<Legion::Internal::DependentPartitionOp> >::create_collective_rendezvous (this=this@entry=0x7f2e0c00d420, tid=<optimized out>,
    requirement_index=requirement_index@entry=0, analysis_index=analysis_index@entry=0)
    at /usr/include/c++/9/bits/stl_tree.h:348
#11 0x00007f2e891f3122 in Legion::Internal::ReplDependentPartitionOp::trigger_dependence_analysis (this=0x7f2e0c00d420)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/legion.h:253
#12 0x00007f2e890fc0b4 in Legion::Internal::Operation::execute_dependence_analysis (this=<optimized out>)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/legion/legion_ops.cc:1666
#13 0x00007f2e89013b3b in Legion::Internal::InnerContext::process_dependence_stage (this=0x7f2e0a787e00)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/legion/legion_context.cc:8471
#14 0x00007f2e8942c528 in Legion::Internal::Runtime::legion_runtime_task (args=0x7f2e0a7a9550, arglen=12,
    userdata=<optimized out>, userlen=<optimized out>, p=...)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/legion/runtime.cc:32372
#15 0x00007f2e88078865 in Realm::LocalTaskProcessor::execute_task (this=0x55b66d943010, func_id=4, task_args=...)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/realm/bytearray.inl:150
#16 0x00007f2e880ca953 in Realm::Task::execute_on_processor (this=0x7f2e0a7a93d0, p=...)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/realm/bytearray.inl:39
#17 0x00007f2e880caa0a in Realm::UserThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/realm/tasks.cc:1687
#18 0x00007f2e880c8e94 in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x55b66db4d550)
    at /scratch/eslaught/fuzzer-experiment-5/legion/runtime/realm/tasks.cc:1158

Command line:
cd /scratch/eslaught/fuzzer-experiment-5
salloc -n 1 -N 1 -c 40 -p all --exclusive
REALM_FREEZE_ON_ERROR=1 srun -n 2 -c 20 ./build_debug_multi/src/fuzzer -fuzz:ops 2 -fuzz:replicate 1 -lg:prof 1 -lg:prof_logfile prof_%.gz

Note that I'm adding -lg:prof because it increases the probability of reproduction in manual runs. So far I have only reproduced without -lg:prof in my automated runs where I massively oversubscribe the machine, which is just more of a pain to run.
Note that I have validated this run with -lg:safe_ctrlrepl 1 and 2.
Rebuild instructions:
srun -n 1 -N 1 -c 40 -p all --exclusive --pty bash --login
cd /scratch/eslaught/fuzzer-experiment-5/legion/build_debug_multi
make install -j20
cd ../../build_debug_multi
make clean && make -j20

Fuzzer version: https://github.com/StanfordLegion/fuzzer/commit/3ef4c19266907eee6c5df86d9dc25b79b47f2d4b
Legion version: d741d2f53bca565b3bc5701ba0a939305e319c76

Should be fixed with: https://gitlab.com/StanfordLegion/legion/-/merge_requests/1420

Merged


Add Service Account Name Undefined Or Empty query for Kubernetes

Platform
Kubernetes
Description
A Pod should have a Service Account defined so to restrict Kubernetes API access, which means the attribute 'serviceAccountName' should be defined and not empty.

Hi. I am not sure why a pod that does not communicate with kube api should have SA at all.


Clone graph under LGMSOC'21

Aim
Clone Graph
Details

Clone Graph
Medium

Given a reference of a node in a connected undirected graph.
Return a deep copy (clone) of the graph.
Each node in the graph contains a value (int) and a list (List[Node]) of its neighbors.
class Node {
public int val;
public List neighbors;
}
Test case format:
For simplicity, each node's value is the same as the node's index (1-indexed). For example, the first node with val == 1, the second node with val == 2, and so on. The graph is represented in the test case using an adjacency list.
An adjacency list is a collection of unordered lists used to represent a finite graph. Each list describes the set of neighbors of a node in the graph.
The given node will always be the first node with val = 1. You must return the copy of the given node as a reference to the cloned graph.
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python

please allow me to do in java @Ayush7614


Make<EMAIL_ADDRESS>email account

Also get:
<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS><EMAIL_ADDRESS>

To confirm, the email inboxes created are:
<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>forward
to same address)
and<EMAIL_ADDRESS>(ideally for tech support)
On Fri, Feb 22, 2019 at 9:29 AM Rasmus Storjohann<EMAIL_ADDRESS>wrote:

<EMAIL_ADDRESS><EMAIL_ADDRESS>—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/pg-irc/pathways-frontend/issues/436#issuecomment-466478114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU-NUBUeEpj2BmwMo5dsahPkmPtYkhPxks5vQCjtgaJpZM4ac_y0
.

--
https://peacegeeks.org/
Cherrie Lam, Digital Projects and Fundraising Manager
#210 - 128 West Hastings Street
Vancouver, BC, V6B 1G8
p.<PHONE_NUMBER> | e<EMAIL_ADDRESS>skype. cherrie.l | peacegeeks.org
*Book a meeting with me: *https://calendly.com/cherrie-peacegeeks
https://calendly.com/cherrie-peacegeeks
PeaceGeeks offices are situated on unceded xʷməθkwəy̓əm (Musqueam),
Skwxwú7mesh (Squamish), and Səl̓ílwətaʔ/Selilwitulh (Tsleil-Waututh)
territory.


Custom DateTime format

Allows the user to define a user-defined date format, whereby the date information is not lost.
this will be fix also the issue #424
sorry but I also had to remove the goto 😄

thanks for your pull request,
i have replied issure #424,
Do we really need this feature?
We should discuss this seriously.

Hi,
For me, the main reason for this feature is that it makes it easier to use the filter for a date in Excel.
Which unfortunately is not the case if the date is a string.

Hi, For me, the main reason for this feature is that it makes it easier to use the filter for a date in Excel. Which unfortunately is not the case if the date is a string. Maybe I didn't understand the issue correctly. I thought that would pursue the same goal.

No, you are correct, but we have to consider whether this approach makes sense and whether it will cause trouble in the future.
It's really hard to decide.

Format = "dd.mm.yyyy hh:mm:ss"
doesn't actually work for excel，Maybe this is not the result we want.

It was never my intention to change the default date format to dd.mm.yyyy hh:mm:ss.
My PR rather referred to the comment // TODO: now it'll lose date type information.
As a result, nothing should change for the users, except that the date information will now be available in Excel.
Of course, if users have been further processing the string within the Excel table, this would be a breaking change since it is now a DateOA double instead of a string.

I understood what you meant before.
Can SaveAsync also be supported？
And GenerateSheetByIDataReader thanks,

Hi, yes no problem.
I think the reference to the issue took things in the wrong direction.
Support for async should not be a big effort anymore.
The support for GenerateSheetByIDataReader is already provided.
DynamicColumnsConfigurationIsUsedWhenCreatingExcelUsingIDataReader
Additionally, I was considering implementing the support for the templates as well. For that, I will open a new PR when the time comes.

Hi, yes no problem. I think the reference to the issue took things in the wrong direction.
Support for async should not be a big effort anymore. The support for GenerateSheetByIDataReader is already provided. DynamicColumnsConfigurationIsUsedWhenCreatingExcelUsingIDataReader
Additionally, I was considering implementing the support for the templates as well. For that, I will open a new PR when the time comes.

Hi,please sign your commits

👍👍👍
@DancePanda42  Could we invite you to our team?


💡[FEATURE]: Change the text colour to white

issue picture :

i will change the text colour to white

Kindly assign me this issue

I would like to work on this issue , please assign this to me.
@akshitagupta15june


[FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

What is the purpose of the change
Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.
Verifying this change
Add test FlinkRuntimeFilterProgramTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not documented)

cc @lsyldliu

Could you help to review this PR when you have time @swuferhong

Thanks for review @lsyldliu @swuferhong . All comments have been addressed or replied ,PTAL.

Thanks for review @lsyldliu @swuferhong . All comments have been addressed or replied ,PTAL.

Hi, Thanks! @wanglijie95 . Now LGTM for this PR.  I wish the itcase can be supplemented after all PR development is completed, And after the TPC-DS testing is completed, more test patterns can be added.

Thanks for comments @lsyldliu. I 've addressed all comments, PTAL. Besides, I add probe side push down logic in the last commit, to get better performance

@lsyldliu I 've addressed or replied your comments, PTAL.

Thanks for review @lsyldliu @swuferhong ! I'll merge this PR once the CI done.


updating current greenfield hcx version

Learn Build status updates of commit 07230ae:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-vmware/includes/vmware-software-versions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


jQuery 3.0 deprecated event

Following the jQuery upgrade guide .bind and .unbind are deprecated. Will you update the plugin ?

That's a good question.  I haven't been in a hurry to do that because Colorbox has many legacy users.

Fork incoming !

Will be any updates planned?
I would be grateful !

We are also in the process of upgrading a site to jQuery 3.x. Since jQuery 1.x/2.x seem to be unsupported since mid 2017 and taking @Taxman972's last comment into account, I'd also suggest a version that doesn't use the deprecated functions.

@jackmoore  Any plan on release new version with jQuery 3+ support. Its long time since jquery version updated. Old legacy systems will be continue to work as it is with the older colorbox version.

A update for jquery v3.4.1 would be great.


[Tree-widget]: added missing tooltips

Fixes https://github.com/iTwin/viewer-components-react/issues/1033
Added missing tooltips:
2D button

3D button

Visibility icon

Visibility icon's tooltip is placed to the left of the icon with the intention of the tooltip not blocking other icons.

Visibility icon's tooltip is placed to the left of the icon with the intention of the tooltip not blocking other icons.

What happens if the tree widget is on the left? Hopefully the tooltip will render to the right then?


Use the latest Docker images in the workflows

Problem
Github workflows don't use the latest Docker images (0.4.16 vs 0.4.18).
Summary of Changes
Update the workflows.

it's possible that the 0.4.18 images aren't actually the latest/correct images...


TICtxtWrd-nuget: Test Improvement, Context Wording, for the ecosystem nuget

Test Improvement, Context Wording, for the ecosystem nuget

Feature covered in https://github.com/dependabot/dependabot-core/pull/9883


Add Scoop installation method to the README

Preflight checklist

[ ] Code formatted rustfmt ($ cargo fmt)
[ ] Code linter check with clippy ($ cargo clippy)
[ ] Relevant tests added
[x] Any new documentation added

Thanks @brian6932!

Very sorry for the delay, but this is in 6.0.0 now


Unable to retrieve dependencies

Hello 👋,
I've been trying to write a simple Puppet module which require one dependency.
This Puppet module is uploaded in Artifactory and I'm using the command librarian-puppet install --no-use-v1-api --verbose unfortunately it's failing with this error message :
[pomme@arbre osx]$ librarian-puppet install --no-use-v1-api --clean --verbose
[Librarian] Ruby Version: 3.0.0
[Librarian] Ruby Platform: x86_64-linux
[Librarian] Rubygems Version: 3.2.3
[Librarian] Librarian Version: 1.1.1
[Librarian] Librarian Adapter: puppet
[Librarian] Librarian Adapter Version: 3.0.1
[Librarian] Project: /home/pomme/test/osx
[Librarian] Specfile: Puppetfile
[Librarian] Lockfile: Puppetfile.lock
[Librarian] Git: /usr/bin/git
[Librarian] Git Version: 2.30.1
[Librarian] Git Environment Variables:
[Librarian]   (empty)
[Librarian] Pre-Cached Sources:
[Librarian]   [:forge, "https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/", {}]
[Librarian] Post-Cached Sources:
[Librarian]   [:forge, "https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/", {}]
[Librarian]   [:forge<EMAIL_ADDRESS>{}]
[Librarian] Analyzing spec and lock:
[Librarian]   Removed:
[Librarian]   ExplicitRemoved:
[Librarian]   Added:
[Librarian]   NonMatchingAdded:
[Librarian]   Changed:
[Librarian]     pomme-mypackage
[Librarian]   DeepKeep:
[Librarian]   ShallowStrip:
[Librarian]     pomme-mypackage
[Librarian] Resolving pomme-mypackage (= 0.1.3) <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/> (from Puppetfile)
[Librarian]   Checking manifests
[Librarian]   Module pomme-mypackage found versions: 0.1.4, 0.1.3, 0.1.2
[Librarian]     Checking pomme-mypackage/0.1.4 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]       Conflict between pomme-mypackage/0.1.4 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/> and pomme-mypackage (= 0.1.3) <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/> (from Puppetfile)
[Librarian]       Backtracking from pomme-mypackage/0.1.4 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]     Checking pomme-mypackage/0.1.3 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]       Resolved pomme-mypackage (= 0.1.3) <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/> (from Puppetfile) at pomme-mypackage/0.1.3 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]   Resolved pomme-mypackage (= 0.1.3) <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/> (from Puppetfile)
[Librarian] Resolving gildas-homebrew (= 0.4.16) <(no source specified)> (from pomme-mypackage)
[Librarian]   Checking manifests
[Librarian]   Module gildas-homebrew found versions: 0.4.16, 0.4.15, 0.4.14, 0.4.13, 0.4.12, 0.4.11, 0.4.10, 0.4.8, 0.4.7, 0.4.6, 0.4.5, 0.4.4, 0.4.3, 0.4.2, 0.4.1, 0.4.0
[Librarian]     Checking gildas-homebrew/0.4.16 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]       Resolved gildas-homebrew (= 0.4.16) <(no source specified)> (from pomme-mypackage) at gildas-homebrew/0.4.16 <https://pomme.jfrog.io/artifactory/api/puppet/pomme-forge/>
[Librarian]   Resolved gildas-homebrew (= 0.4.16) <(no source specified)> (from pomme-mypackage)
[Librarian] Bouncing Puppetfile.lock
[Librarian] Install: dependencies resolved
Puppetfile and Puppetfile.lock are out of sync!
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/action/install.rb:32:in `check_consistent'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/action/install.rb:20:in `check_preconditions'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/action/install.rb:10:in `run'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarian-puppet-3.0.1/lib/librarian/puppet/cli.rb:101:in `install!'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarian-puppet-3.0.1/lib/librarian/puppet/cli.rb:70:in `install'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/thor-1.1.0/lib/thor/command.rb:27:in `run'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/thor-1.1.0/lib/thor/invocation.rb:127:in `invoke_command'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/thor-1.1.0/lib/thor.rb:392:in `dispatch'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/thor-1.1.0/lib/thor/base.rb:485:in `start'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/cli.rb:26:in `block (2 levels) in bin!'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/cli.rb:31:in `returning_status'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/cli.rb:26:in `block in bin!'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/cli.rb:47:in `with_environment'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarianp-1.1.1/lib/librarian/cli.rb:26:in `bin!'
/home/pomme/.rvm/gems/ruby-3.0.0/gems/librarian-puppet-3.0.1/bin/librarian-puppet:7:in `<top (required)>'
/home/pomme/.rvm/gems/ruby-3.0.0/bin/librarian-puppet:23:in `load'
/home/pomme/.rvm/gems/ruby-3.0.0/bin/librarian-puppet:23:in `<main>'

You can find here below, the Puppetfile used by librarian-puppet :
forge<EMAIL_ADDRESS>
mod 'pomme-mypackage', "0.1.3"

And the metadata.json of pomme-mypackage :
{
  "name": "pomme-mypackage",
  "version": "0.1.3",
  "author": "pomme",
  "summary": "this is my test module",
  "license": "proprietary",
  "source": "https://git.pomme.io/test/_git/mypackage",
  "dependencies": [
    {
      "name": "gildas-homebrew",
      "version_requirement": "0.4.16"
    }
  ],
  "operatingsystem_support": [
    {
      "operatingsystem": "Darwin",
      "operatingsystemrelease": [
        "16"
      ]
    }
  ],
  "requirements": [
    {
      "name": "puppet",
      "version_requirement": ">= 6.0.0 < 7.0.0"
    }
  ],
  "pdk-version": "2.2.0",
  "template-url": "pdk-default#2.2.0",
  "template-ref": "tags/2.2.0-0-g2381db6"
}

When I check in Artifactory it seems that the pomme-mypackage module is available but somehow the dependency is not loading.
However if I run the command puppet module install pointing to Artifactory, the dependency is downloaded and available in the cache :-/ it's a bit hard to point where the issue is.
Thanks a lot the help 🙇♂,
Josué

Fixed by using this fork https://github.com/ahmet2mir/librarian-puppet

That fork looks out of date.

Puppetfile and Puppetfile.lock are out of sync

You didn't post what's in your Puppetfile.lock file.

@ekohl, indeed it's an old fork.
Here is the puppetfile.lock :
FORGE
  remote<EMAIL_ADDRESS>  specs:
    gildas-homebrew (0.4.16)
    pomme-mypackage (0.1.3)
      gildas-homebrew (>= 0.4.0)

DEPENDENCIES
  pomme-mypackage (= 0.1.3)

It seems that this commit : https://github.com/ahmet2mir/librarian-puppet/commit/71bd4cfa83eed487307511b23dcc6b9a7b324a98 is handling Artifactory somehow in a better way.

Looks like https://github.com/voxpupuli/librarian-puppet/pull/69 should do the same. It mentions the same errors. Perhaps it's just time for a new release? Can you confirm that it works with git master?

Yep it's working while using master :
gem specific_install https://github.com/voxpupuli/librarian-puppet.git

No complains everything is good


docs(TableExampleSortable): your description

Updated for react hooks

Codecov Report

Merging #3964 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3964      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%
==========================================
  Files         184      183       -1
  Lines        3220     3157      -63
==========================================
- Hits         3215     3152      -63
  Misses          5        5

Impacted Files
Coverage Δ

src/elements/Button/Button.js
95.45% <0.00%> (-0.11%)
:arrow_down:

src/modules/Popup/Popup.js
98.71% <0.00%> (-0.04%)
:arrow_down:

src/modules/Search/Search.js
99.53% <0.00%> (-0.03%)
:arrow_down:

src/modules/Sticky/Sticky.js
99.07% <0.00%> (-0.01%)
:arrow_down:

src/modules/Tab/Tab.js
100.00% <0.00%> (ø)

src/views/Card/Card.js
100.00% <0.00%> (ø)

src/elements/Flag/Flag.js
100.00% <0.00%> (ø)

src/elements/Icon/Icon.js
100.00% <0.00%> (ø)

src/elements/List/List.js
100.00% <0.00%> (ø)

src/elements/Step/Step.js
100.00% <0.00%> (ø)

... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de506d5...74a7fde. Read the comment docs.


Move log API to stardew.chat

In the event of my server completely dying (such as last night), the log API goes down so I thought it'd be good idea to move it to stardew.chat.

In response to question 1:
Doing it all in python is a good point, I didn't think of that. It probably wouldn't use a huge amount of resources either.
question 2:
I'll add more things when I have time, was planning to but never got around to it.

Added requested changes

Oops i think i did the line ending thing again
i'll fix that as soon as i can (may be a few days)

fixed

Should I just close the pull request and open another with the python stuff rather than making more commits to delete it again?


Add HCL Support

Add support for HCL/Terraform:

ASCII art generated from image_to_ascii.py and the Terraform
logo.

TrueColor values derived from the RGB values therein.

As per the contribution guidelines, specifically that the ASCII logo's "dimensions must fall below 25*40", the logo is 25x40 but the addition of {0} and {1} push the width to 46—is that a concern?

It shouldn't be a concern. It's the rendered width/height that we're trying to enforce. As long as the rendered characters stay within the dimensions, it should be OK :slightly_smiling_face:

Thanks a lot for your contribution @PsypherPunk, in d591e1b I cleaned the ASCII art to make it more symmetrical.


[SMALLFIX] Add requirement on maven version to build Alluxio

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15795/
Test FAILed.

It looks like Jenkins is using an older version.

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15797/
Test PASSed.

Merged build finished. Test PASSed.


redwood-lazylayout-dom artifact not being published in maven central version 0.9.0

It looks like the artifact redwood-lazylayout-dom did not make it on maven central:
https://search.maven.org/search?q=redwood-lazylayout-dom
Probably because it's missing the gradle publishing directive here:
https://github.com/cashapp/redwood/blob/trunk/redwood-lazylayout-dom/build.gradle#L4

Thanks. Want to send a PR? 0.10.0 goes out here in a few days. If not someone will get to it.

This is actually intentional since it doesn't work right now. Adding behavior is tracked by #1048.


Reverted orientation checking fix

This caused layout issues where if you swiped left/right on the
real device, you wouldn't be able to see the other views.
UIDevice.currentDevice().orientation.isPortrait checks the
physical orientation of your device, which may not be the same as
your application's orientation. Please refer to
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIDevice_Class/#//apple_ref/occ/instp/UIDevice/orientation

UIDevice.currentDevice().orientation ignore Deployment Info > Device Orientation better if it's use UIApplication.sharedApplication().statusBarOrientation


Update Puma dependency to ~> 3.10

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version(related issue).
This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.

@premist Interesting crash on JRuby; different than other crashes.
Idea: Can you change the "dist" in .travis.yml to be trusty instead?

I did that change in #167, and it did the trick for the build, in general.
We shall see how it fares with this core-dump.

We'll probably want to rebase this on top of #167 and see if that fixes the build?

@premist Now you can rebase on master to retry.

@indirect Can you retry the Travis build?

\o/

@bundlerbot r+

@bundlerbot retry

@bundlerbot retry


add_aur_release

Current dependencies on/for this PR:

main

PR #20   👈

This comment was auto-generated by Graphite.


Added screenshots to the document

Added screenshots to the document
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12051

@JohanFreelancer9 Please copy review

@kwekuako Please merge this PR. Thanks

@kwekuako Gentle reminder


Make SSE action execution use an internal PubSub implementation

The mechanism introducted in this commit causes ingested ledgers to notify SSE action handlers, letting them know they should query the database for new related information. This causes every SSE connection to query the history database only when a ledger was ingested that contains explicit information related to that SSE request. This is in contrast to the current way it's done - where every SSE action handler queries the database in a periodic manner e.g. every 5s, regardless of that ledger's contents.
For example /accounts/{account_id}/transactions will query the history database only when a ledger containing a transaction affecting that specific {account_id} is ingested.
This greatly reduces the performance load on the history database belonging to Horizons handling a large number of SSE connections.
In addition:

Add a new GetPubsubTopic() function to actions.EventStreamer interface.
It returns the specific URL parameter used to notify on related ledger ingestions.
Remove sse-update-frequency command line argument, since the feature introduced in this commit makes it obsolete.
Added new services/horizon/internal/sse_test.go with related unit tests.

Thanks, this is something we wanted to do. There are some problems with this PR unfortunately:

It only works within a single ingesting node. If you run a cluster, say 4 servers and 1 ingestion it won't work. We use Redis in Horizon so you could try to use PUBSUB from Redis. Also, Redis is not required by Horizon (and probably shouldn't be) so we should leave the old method as an option.
I'm wondering if return value of GetPubsubTopic should be something like:type Topic struct{
  Ledger uint
  Account string
  // ...
}

just in case there's another object type that is identified by the same key space as existing one in a future.

@bartekn thanks for the comments. We'll review them and update the PR as necessary.

Closing because the Horizon codebase changed a lot since then. Right now we're using the new ingestion system in Horizon that would make this much easier. However, I think a pubsub system like this would be complex in an environment where multiple Horizon instances are running. We'd need to use a DB as a queue and we already use a DB in an existing code.


Paper test problem

Reflecting changes suggested by CAC

Hi Dave,
You merged your branch into the master branch. You should actually do the
inverse, which is merging the differences between the master and yours into
your branch. I reverted your commit but you should still have all the code
in your computer. If not, just look at one commit ago in the master branch.
Bernardo
On Thu, Jan 3, 2019 at 7:23 PM dgoldri25<EMAIL_ADDRESS>wrote:

Reflecting changes suggested by CAC
You can view, comment on, or merge this pull request online at:
https://github.com/bernardoct/WaterPaths/pull/8
Commit Summary

Creating new branch for paper test problem.
Creating new branch for paper test problem.
Added water balance
Updated water balance, still need to fix graph, create utilities and
test.
Fixed problem with Graph
We are free of syntax/coding errors! Still could be errors in model
structure, next step is testing of the continuity model.
Updated PaperTestProblem. Still having issues running continuity
simulation. right now problem seems to be with water_sources vector being
created in the simulation object.
Fixed inputs.
Fixed inputs.
Merge remote-tracking branch 'origin/PaperTestProblem' into
PaperTestProblem
Fixed test case inputs -- there are 3 utility allocations in lake
Changed Continuity graph, Sugar Creek now in Autumn watershed.
Testing reservoir simulations for 30 years. Need to make sure
inflows and demands are realisticly balanced.
Added policies, instruments seem to be working. ROF tables being
constructed and working properly. Need to test the system across multiple
realizations and make sure balance is working.
Updated Dryville/Fallsland allocations for Autumn Lake, Fallsland
was routinely running into trouble while dryville always had enough water
(over a small number of realizations). Need to extensively test on the
cube, 1000 realizations without tables takes far too long in serial (around
~22 hours). Output is not currently being printed when tables are
generated, need to figure out why.

File Changes

A .idea/codeStyles/Project.xml
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-0 (29)
A .idea/codeStyles/codeStyleConfig.xml
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-1 (5)
M CMakeLists.txt
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-2 (10)
M Tests/Tests.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-3 (31)
M src/ContinuityModels/Base/ContinuityModel.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-4 (38)
M src/ContinuityModels/Base/ContinuityModel.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-5 (8)
M src/Controls/Base/MinEnvFlowControl.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-6 (9)
M src/Controls/InflowMinEnvFlowControl.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-7 (2)
M src/DataCollector/AllocatedReservoirDataCollector.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-8 (2)
M src/DataCollector/MasterDataCollector.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-9 (30)
M src/Problem/Base/Problem.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-10 (6)
M src/Problem/Base/Problem.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-11 (2)
A src/Problem/PaperTestProblem.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-12 (815)
A src/Problem/PaperTestProblem.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-13 (68)
M src/Problem/Triangle.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-14 (12)
M src/Simulation/Simulation.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-15 (67)
M src/SystemComponents/Utility/InfrastructureManager.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-16 (17)
M src/SystemComponents/Utility/Utility.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-17 (61)
M src/SystemComponents/Utility/Utility.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-18 (2)
M src/SystemComponents/WaterSources/AllocatedReservoir.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-19 (22)
M src/SystemComponents/WaterSources/Base/WaterSource.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-20 (10)
M src/SystemComponents/WaterSources/Base/WaterSource.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-21 (4)
M src/Utils/Graph/Graph.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-22 (22)
M src/Utils/Graph/Graph.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-23 (4)
M src/main.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-24 (64)

Patch Links:

https://github.com/bernardoct/WaterPaths/pull/8.patch
https://github.com/bernardoct/WaterPaths/pull/8.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bernardoct/WaterPaths/pull/8, or mute the thread
https://github.com/notifications/unsubscribe-auth/AIlZrVNOJq0g54StGUBGTMnig9Yr-RPwks5u_oLcgaJpZM4Zo3U8
.

Thanks! I thought something seemed off about the way I had done it, sorry
about that.
On Thu, Jan 3, 2019 at 8:19 PM bernardoct<EMAIL_ADDRESS>wrote:

Hi Dave,
You merged your branch into the master branch. You should actually do the
inverse, which is merging the differences between the master and yours into
your branch. I reverted your commit but you should still have all the code
in your computer. If not, just look at one commit ago in the master branch.
Bernardo
On Thu, Jan 3, 2019 at 7:23 PM dgoldri25<EMAIL_ADDRESS>wrote:

Reflecting changes suggested by CAC
You can view, comment on, or merge this pull request online at:
https://github.com/bernardoct/WaterPaths/pull/8
Commit Summary

Creating new branch for paper test problem.
Creating new branch for paper test problem.
Added water balance
Updated water balance, still need to fix graph, create utilities and
test.
Fixed problem with Graph
We are free of syntax/coding errors! Still could be errors in model
structure, next step is testing of the continuity model.
Updated PaperTestProblem. Still having issues running continuity
simulation. right now problem seems to be with water_sources vector being
created in the simulation object.
Fixed inputs.
Fixed inputs.
Merge remote-tracking branch 'origin/PaperTestProblem' into
PaperTestProblem
Fixed test case inputs -- there are 3 utility allocations in lake
Changed Continuity graph, Sugar Creek now in Autumn watershed.
Testing reservoir simulations for 30 years. Need to make sure
inflows and demands are realisticly balanced.
Added policies, instruments seem to be working. ROF tables being
constructed and working properly. Need to test the system across multiple
realizations and make sure balance is working.
Updated Dryville/Fallsland allocations for Autumn Lake, Fallsland
was routinely running into trouble while dryville always had enough water
(over a small number of realizations). Need to extensively test on the
cube, 1000 realizations without tables takes far too long in serial
(around
~22 hours). Output is not currently being printed when tables are
generated, need to figure out why.

File Changes

A .idea/codeStyles/Project.xml
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-0 (29)
A .idea/codeStyles/codeStyleConfig.xml
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-1 (5)
M CMakeLists.txt
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-2 (10)
M Tests/Tests.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-3 (31)
M src/ContinuityModels/Base/ContinuityModel.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-4 (38)
M src/ContinuityModels/Base/ContinuityModel.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-5 (8)
M src/Controls/Base/MinEnvFlowControl.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-6 (9)
M src/Controls/InflowMinEnvFlowControl.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-7 (2)
M src/DataCollector/AllocatedReservoirDataCollector.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-8 (2)
M src/DataCollector/MasterDataCollector.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-9 (30)
M src/Problem/Base/Problem.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-10 (6)
M src/Problem/Base/Problem.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-11 (2)
A src/Problem/PaperTestProblem.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-12 (815)
A src/Problem/PaperTestProblem.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-13 (68)
M src/Problem/Triangle.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-14 (12)
M src/Simulation/Simulation.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-15 (67)
M src/SystemComponents/Utility/InfrastructureManager.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-16 (17)
M src/SystemComponents/Utility/Utility.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-17 (61)
M src/SystemComponents/Utility/Utility.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-18 (2)
M src/SystemComponents/WaterSources/AllocatedReservoir.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-19 (22)
M src/SystemComponents/WaterSources/Base/WaterSource.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-20 (10)
M src/SystemComponents/WaterSources/Base/WaterSource.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-21 (4)
M src/Utils/Graph/Graph.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-22 (22)
M src/Utils/Graph/Graph.h
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-23 (4)
M src/main.cpp
https://github.com/bernardoct/WaterPaths/pull/8/files#diff-24 (64)

Patch Links:

https://github.com/bernardoct/WaterPaths/pull/8.patch
https://github.com/bernardoct/WaterPaths/pull/8.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bernardoct/WaterPaths/pull/8, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AIlZrVNOJq0g54StGUBGTMnig9Yr-RPwks5u_oLcgaJpZM4Zo3U8
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bernardoct/WaterPaths/pull/8#issuecomment-451329757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASgHLluF6HZBZkCD4LztqpbkKTYuqAx0ks5u_qwigaJpZM4Zo3U8
.

--
David Gold
PhD Candidate
Environmental & Water Resources Systems
School of Civil & Environmental Engineering
207 Hollister Hall
Cornell University
Ithaca, NY 14850-3501


[Feature][Dependent] Ignore failed instances that are not scheduled normally during job instance dependency check

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Sometimes developers will manually run workflows, such as trial runs after editing workflow definitions. These failed workflow instances that are not generated by scheduled scheduling should not affect dependency checks in normal scheduled workflow instances.
In addition, it is recommended to add a button to force success or ignore failure in the workflow instance list, indicating that it is considered successful during dependency checking. Instead of the existing delete button, as users may need to be able to audit each workflow instance. Regarding this, you can refer to the design of Huawei Cloud DGC.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Currently, you can first force all the workflow jobs to execute successfully in Task Instance. If you rely on the entire workflow, a single failed recovery of the workflow instance is sufficient.


Updates to the index/home page

Whatchu think?

Having a wider nav makes me want to do something with the use of whitespace overall. How does this change look on mobile? If the nav isn't collapsible (not sure on this) it could end up dominating the screen.

It kinda looks like trash, but without these changes it's also not great either.

vs.

Made #17 to tackle mobile responsiveness issues.


Consumed vertical scroll if rating is nested in LazyColumn

RatingBar consumes vertical touch if inside LazyColumn in Compose

It does because of detectDragGestures, it should be changed to detectHorizontalDragGestures or custom Modifier.pointerInput that doesn't call consume


Fix Remix's params object parsing

The README states that getParams can be used with Remix's params object. When I tried doing so, it failed to parse its contents. It seems this was due to the code in getParamsInternal relying on params being an iterable. Because the params object isn't this produced an empty array when calling Array.from(params) in the for...of.
This PR attempts to fix this. I've also included a couple of small type edits and an updated lock file. Feel free to suggest any changes that you'd like to work into the PR.

@kiliman, since this just a bug fix, shall I also update the version to 0.3.2?

Also, not sure what to do about the example folder. It seems to include duplicate code from helper.ts. Should I update it?

Yes, simple bug fixes just need to update the patch number.
Yeah, the example app simply copies the current version so I have to keep them in sync. Need a better solution for this (monorepo?).

Thanks. This was pushed in v0.4.0

Thanks @kiliman


chore: fall back into vuln-list-reserve

See https://github.com/aquasecurity/vuln-list-update/pull/229
Also, this PR drops Arch Linux since Trivy doesn't support it.

worked
https://github.com/aquasecurity/trivy-db/actions/runs/5654264373/job/15316989713


Is the tier 1 build environment still required in a project ?

Microsoft removed the tier1 build environment (that used to come with the license subscription) stating we should be using Azure pipelines. Do we still need to consider a tier 1 environment for build as shown below ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2402dfea-008a-c7bb-8a3b-1d0457a39665
Version Independent ID: 4936afad-9a39-e65d-a00c-81246de632cb
Content: Environment planning - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/fin-ops/imp-lifecycle/environment-planning.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @skaue-ms
Microsoft Alias: toskaue

Bug 760871 has been logged to address this issue.

The tier1 build environment comes with a runtime (AOS) which enables post-build testing that is not possible on a hosted built. The hosted build will only be able to do compile-time verification and check that the code can successfully compile. You can combine this with making sure the successfully built package gets deployed to a tier2+ sandbox as a next step, and run test against the sandbox if you prefer.

The tier1 build environment comes with a runtime (AOS) which enables post-build testing that is not possible on a hosted built. The hosted build will only be able to do compile-time verification and check that the code can successfully compile. You can combine this with making sure the successfully built package gets deployed to a tier2+ sandbox as a next step, and run test against the sandbox if you prefer.

Thanks for the clarification @skaue-ms, that makes sense.


[es] Machine learning tips and tricks

Thanks David for your awesome work!
Now let's wait for a reviewer to go through this translation as well.

Maybe we can do peer-review David: https://github.com/shervinea/cheatsheet-translation/pull/27

The translation is very well made. I agree with all the points of @gustavovelascoh. But I think after a few changes it can be merged. Good job!

Thank you @gustavovelascoh and @fdiazgon , I'll check your suggestions!

Hey @djpg. How are you doing with the changes? I think it will be a good idea to merge this one to use it as a baseline for other translations...

Hey @djpg. How are you doing with the changes? I think it will be a good idea to merge this one to use it as a baseline for other translations...

Sorry, during the day I will make the changes suggested by all of you.

Thank you everyone for your work!
@djpg have all changes been done yet, i.e. may I move forward with the merge?

Thank you everyone for your work!
@djpg have all changes been done yet, i.e. may I move forward with the merge?

@shervinea All changes are already done, so you may do the merge.

@shervinea LGTM

It seems that translations of questions 44-48 are still missing. Could someone take a look at it?

Done! But I could not add the commit to this same pull request. This is what should be added:
**44. Regression metrics**

⟶ Métricas de regresión

**45. [Classification metrics, confusion matrix, accuracy, precision, recall, F1 score, ROC]**

⟶ [Métricas de clasificación, matriz de confusión, precisión, sensibilidad (ó exhaustividad), puntuación F1, Característica Operativa del Receptor (ROC, por sus siglas en inglés)]

**46. [Regression metrics, R squared, Mallow's CP, AIC, BIC]**

⟶ [Métricas de regresión, R cuadrado, CP de Mallow, Criterio de información de Akaike (AIC, por sus siglas en inglés), Criterio de información bayesiano (BIC, por sus siglas en inglés)]

**47. [Model selection, cross-validation, regularization]**

⟶ [Selección de modelo, validación cruzada, regularización]

**48. [Diagnostics, Bias/variance tradeoff, error/ablative analysis]**

⟶ [Diagnósticos, Compensación sesgo/varianza, error/análisis ablativo]

Thanks @fdiazgon! I will commit your changes.


Login with Patreon logic

First time commenter, so go easy.  Im trying to integrate Patreon with my wordpress site.  I was able to get the oAuth working by creating credentials in Patreon and adding them to the WP settings.  I am able to click the login with patreon button and authorize my WP site to share credentials.  I know your readme file states user creation scenarios.
Using
WP 4.4.1
Buddypress 2.4.3
bbPress 2.5.8
Github Patreon commit 1fe961a

User does not exist in WP, I login with Patreon, it makes a new user and logs them in (fine).  I then logout the user, then try and login to the WP site again using the login with patreon button, it takes me to patreon again and I authorize the connection again to my site, then in the login area, it says.  "You can now login with your wordpress username/password."  Which username and pass is it referring to? I know the username is the persons name that they used on patreon.  So what password would they use?  When the user gets created, it uses a random password when creating there WP account and does not email the user there username or pass.  Attached is a modified patreon_login.php which will notify user of there username and allow them to change there password.
When I try and login with patreon, the 2nd time or more, Is it supposed to actually log me in, because it currently does not, and just update that users patreon meta info?  Seems stuck at this point.  Always says  "You can now login with your wordpress username/password."
Is the intent of the login with patron button for them to always use this button, or just use it once, and then the user would forever use the new WP login and pass after the initial login with patron process?
Im sure I will be contacting you guys more, so is this where you want me to submit my questions and requests?

patreon_login.zip

I think i answered my own #2.  It looks like in patreon_login.php in the else was commented out lines to log the user in.  I also just redirected to the home_url().

Hi BigT,
I modified that functionality slightly due to a possible security threat but commented out the old implementation. Basically its a bad idea to have Wordpress auto login after connecting with Wordpress.
Wordpress also doesn't send passwords over email, so the user will need to follow the reset password flow. This is also a security consideration.
Basically the idea is for the Patreon user to connect once, then utilise their Wordpress accounts.

OK how about this.  the user initially uses the connect with patreon, it creates them an account.  Then redirects to the reset your password page automatically, so then and there they can reset the random generated password.  This page will also tell them there username.  The line of code I sent, will notify them via email of the username that was created and offer a password reset link as well, dont know if that would be redundant though.  After the user resets the password, they will be redirected to the login page.  It seems that this reset password page might have to be custom compared the the built in WP reset password page to allow for the constant redirects and the ability to show username?

Since the ultimate goal is to have the user become a WP user, the update the users meta with Patreon info, the act of updating the user meta would trigger when attempting to view patreon content?
Would the only way to know a user is Patreon oriented (originated) is to do a quick user meta check to see if anything is in the patreon user meta without having to ping patreons servers?  The only difference it seems between a naturally signed up new user compared to a Patreon user is that extra meta data?
So lets say they now do the steps im my above comments.  When they login, the login with patreon button will still show, they will have a harder time knowing not to hit the login with patreon button again because they have an account now, and it will not log them in.  Should a error message come up directing them that they have already created an account and to use there username and pass to login, and offer a link to the login page.  Obviously if they re-use the login with patreon button again, it should update there user meta again.

I know in your notes that it mentions A connect this account with patreon.  Do you think maybe that the user should just create an account naturally, then connect it with patreon, if having them login with patreon then reset password and all that eventually gets too complicated?

Outdated old issue. Closing.


Work in progress

This repo is marked as WIP without many open GitHub issues. I'm looking at conformance testing for the CloudEvent SDKs, but I don't understand how this repo can solve that. It seems like a CLI for testing CloudEvents in yaml format?
Ideally there would be some way to use a project (maybe this one) to ensure CloudEvent SDKs can properly handle HTTP requests with CloudEvents.
CC @grayside

@grant we just merged the Cucumber-based option to test the SDKs. The idea is to have a runnable spec that every SDK can run by adding a bit of a blue code.
Here are some examples of it integrated:
https://github.com/cloudevents/sdk-go/pull/474
https://github.com/cloudevents/sdk-java/pull/130
Note that the feature set is a very basic at the moment (and will definitely be extended), yet it covers quite a few aspects of the SDK.
See https://cucumber.io for more info on how to run Cucumber-based tests with your language if choice.

Great to hear @bsideup. I'm interested in understanding the conformance of the various SDKs and to which degree end-users can rely on these libraries.

Can we add more of a description to the repo? Is this a CLI for manual testing? Testing SDKs or clients? Maybe remove the Work in progress and add issues for new features?
I'm unfamiliar with "blue code", do we mean "glue code"?

There are only 2 GitHub issues attached to this repo. I think it would be good to add a couple more issues to see what's left to do for newcomers to this repo, but not CEs, like me. I guess I can add some, but I don't have context as to why this repo exists.

@grant

I'm unfamiliar with "blue code", do we mean "glue code"?

Ooops! :D "glue code" of course, sorry :)

but I don't have context as to why this repo exists.

At the moment, the repo is a mix of two things - the CLI @n3wscott created and the feature files for testing with Cucumber. You don't need the CLI to run Cucumber tests.
I will sync with Scott on how we should proceed to make the purpose of the repo more clear.

yeah I think we could have a talk about what to do with this next.
I like the cucumber tests and I like the simple cli (i use it all the time) but it needs a couple new features. I can start making issues to track those ideas.

Btw @n3wscott, this tool is incredibly useful. I know we're all strapped with time, but if I could do 2 things I would:

Rename the repo from conformance to cli
Add more and full examples to the README.md such that it is easy to copy/paste:cloudevents send http://localhost:8080 \
  --id abc-123 \
  --source cloudevents.conformance.tool \
  --type foo.bar \

I don't have perms for the 1st bullet, but I could make a PR for the 2nd one.

Rename the repo from conformance to cli

Or maybe create a new repo and move the CLI there while keeping the Cucumber stuff here, in conformance

Again, thanks for this tool! It's useful.
I'm not too familiar with the inner working of the repo. This repo seems more like a CLI and has a couple conformance testing files.
I'd really like the CLI and would love to recommend it to devs/customers, as we use cURL right now. Not sure where the renaming discussion landed, I'd just rename the repo from conformance to cli and maybe move the small conformance part in a separate project?
This is my proposal:

Not mark the repo as WIP: https://github.com/cloudevents/conformance/pull/16

Reasons in the PR.

For renaming the repo, I think we'd need to contact @duglin to rename this repo to cli and create a new repo conformance with the conformance files, as in the features/ directory.

That way, we can keep the Cucumber stuff here and the SDK scripts that use the download-and-run script should still work:

Commands like like this seen in SDK repos: ... https://raw.githubusercontent.com/cloudevents/conformance/master/features/http-protocol-binding.feature && cucumber-js /tmp/http-protocol-binding.feature -p default

👍  / 👎  ?

I think the cli is an interesting usage of the repo but not the pure focus, I think we should not rename or move.


Is it possible to associate methods in code to test cases using Visual Studio Code?

Hello. I see that the documentation is really good and covers associating code with test cases using Visual Studio.
Is it possible to do the same with Visual Studio Code? possibly with Azure Repos extension or any other VSC extension?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d8a7e40-73d6-795f-7b8c-77104ef606e8
Version Independent ID: 8f15995b-bd94-8d9f-1e8b-82f1f364d221
Content: Associate automated tests with test cases - Azure Test Plans
Content Source: docs/test/associate-automated-test-with-test-case.md
Product: devops
Technology: devops-test
GitHub Login: @steved0x
Microsoft Alias: sdanie

@alexpercont -- Alex, thank you for your positive feedback. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options where you might consider asking your questions:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.

@WilliamAntonRohm
Hello!
Case is still relevant. As I understand there is no feature that replicates associating code(auto tests) with manual test cases  functionality. Is there any workaround?
Sorry if it's off topic here

@SHarrySeldon -- thank you for your question.  Please consider this resource:

Azure Q & A

You are welcome to submit your idea here.
cc @steved0x for awareness


Add LinkedIn Icon in Footer

Add LinkedIn icon similar to Facebook and Twitter icon in the Footer.

Are you working on this? (Yes/No)
No

Can I work on this?

Sure, Go ahead!

Can I work on this if @animesh-007 isn't doing it.

Can I go for this if @animesh-007 isn't doing it?

@hdck007 Sure😀


Chaining the tasks

Hi, is it possible to stitch the tasks? For example, metaworld has door-open and door-unlock. I want to create a task to open a locked door. Do you have any tricks/suggestions to create this kind of task?

@reginald-mclean Might know but to my knowledge, I don't think this is easily possible without implementing a custom environment

That sounds like a custom environment (and also a really hard task). All the pieces are there for you to create that yourself if you wanted


Manually deleted folder is is shown as present in azure databricks

I manually deleted a folder from Blob containers.
however when I check execute the command 'os.path.exists(path of deleted folder folder)' it return True.
When I delete the folder using 'shutil.rmtree(path)' the command 'os.path.exists(path)' return False which is correct

Couple of questions:

Is your storage account and ADLS Gen2 account (is HNS enabled)?
Do you have soft delete turned on?
If you go and look today, do you see the folder in Storage Explorer?
Do any other non-command-line/non programming tools show the folder? Say, the blob viewer at the Azure Portal?

Is your storage account and ADLS Gen2 account (is HNS enabled)? - Yes
Do you have soft delete turned on? - Yes
If you go and look today, do you see the folder in Storage Explorer? - No, the folders were not showing from the moment they were deleted
Do any other non-command-line/non programming tools show the folder? Say, the blob viewer at the Azure Portal? Nope, it is not showing  in blob viewer of azure portal

If you have soft delete enabled then maybe it's possible that databricks considers soft deleted blobs to affect whether or not a folder exists. You should check with the databricks team about if this is true or not. Does that make sense?

Closing due to lack of response from original issue opener. Please open a new issue if you are continuing to have problems.


WIP: Migrate Kubeflow, Vertex, Tekton integrations to KFP 2

[ ] add a tekton2 integration
[ ] add a kubeflow2 integration
[ ] adapt / upgrade vertex to use kfp2 syntax

@fa9r Now tekton released 2.0 support, do you think we should also update? https://github.com/kubeflow/kfp-tekton/releases

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: strickvl:x: Felix AltenbergerFelix Altenberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

As we upgraded to pydantic v2, our kubeflow, tekton, and vertex integrations were also bumped to use KFP 2. Closing this PR.