🐛 [firebase_auth]Auth allows login after user deleted

Bug report
Describe the bug
Not sure if this is a bug or intended behaviour, but here it is:
If I login to my app using firebase_auth and subsequently delete my user from firebase backend. Upon restarting the app, firebase_auth still pulls the deleted user credentials and allows the login
Steps to reproduce
Steps to reproduce the behavior:

Login as test_user
delete test_user in the firebase backend, stop and restart the app
newUser variable in checkAuthState() contains the test_user credentials (although this user no longer exists in firebase backend) and therefore allows the login to proceed

Expected behavior
I would expect checkAuthState() to throw an error that this user does not exist or return a null newUser
Sample project
void checkAuthState() {
    userAuthSub = auth.FirebaseAuth.instance.authStateChanges().listen((newUser) async {
      firebaseUser.value = newUser;
      if (newUser != null) {
        isLoggedIn.value = true;
        userDataController.userID = newUser.uid;
        userDataController.userEmail = newUser.email;
        await userDataController.refreshUserData();
      } else {
        isLoggedIn.value = false;
      }
    }, onError: (e) {
      print('AuthStateProvider - FirebaseAuth - onAuthStateChanged error - $e');
    });
  }

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.0.6, on Microsoft Windows [Version 6.1.7601], locale en-CA)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Chrome - develop for the web
[√] Android Studio (version 4.1.0)
[√] VS Code
[√] Connected device (2 available)

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.12.3
Flutter SDK 2.0.6
nearby 1.0.0+1

dependencies:
- cloud_firestore 2.1.0 [cloud_firestore_platform_interface cloud_firestore_web firebase_core firebase_core_platform_interface flutter meta]
- cupertino_icons 1.0.3
- firebase_auth 1.1.4 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.1.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- font_awesome_flutter 8.12.0 [flutter]
- geocoding 2.0.0 [flutter geocoding_platform_interface]
- get 3.26.0 [flutter]
- google_sign_in 5.0.2 [google_sign_in_platform_interface google_sign_in_web flutter meta]
- http 0.13.3 [async http_parser meta path pedantic]
- image_picker 0.7.5 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface image_picker_for_web]
- mockito 5.0.7 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api]
- modal_progress_hud 0.1.3 [flutter]
- path_provider 2.0.1 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- proximity_hash 1.1.0 [dart_geohash]
- url_launcher 6.0.3 [flutter url_launcher_platform_interface url_launcher_linux url_launcher_macos url_launcher_windows url_launcher_web]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanne
r term_glyph typed_data]

transitive dependencies:
- _fe_analyzer_shared 21.0.0 [meta]
- analyzer 1.5.0 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml pedantic]
- args 2.1.0
- async 2.5.0 [collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 1.6.3 [analyzer async convert crypto glob logging meta path]
- built_collection 5.0.0
- built_value 8.0.6 [built_collection collection fixnum]
- characters 1.1.0
- charcode 1.2.0
- cli_util 0.3.0 [meta path]
- clock 1.1.0
- cloud_firestore_platform_interface 5.0.1 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.0.1 [cloud_firestore_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- code_builder 3.7.0 [built_collection built_value collection matcher meta]
- collection 1.15.0
- convert 3.0.0 [typed_data]
- crypto 3.0.1 [collection typed_data]
- dart_geohash 1.0.2
- dart_style 1.3.14 [analyzer args path pub_semver source_span]
- fake_async 1.2.0 [clock collection]
- ffi 1.0.0
- file 6.1.0 [meta path]
- firebase_auth_platform_interface 4.2.2 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 1.1.2 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.0.1 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.0.3 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.0.0
- flutter_plugin_android_lifecycle 2.0.1 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- geocoding_platform_interface 2.0.0 [flutter meta plugin_platform_interface]
- glob 2.0.1 [async collection file path pedantic string_scanner]
- google_sign_in_platform_interface 2.0.1 [flutter meta quiver]
- google_sign_in_web 0.10.0 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- image_picker_for_web 2.0.0 [image_picker_platform_interface meta flutter flutter_web_plugins]
- image_picker_platform_interface 2.1.0 [flutter meta http plugin_platform_interface]
- intl 0.17.0 [clock path]
- js 0.6.3
- logging 1.0.1
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- package_config 2.0.0 [path]
- path 1.8.0
- path_provider_linux 2.0.0 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 2.0.0 [flutter]
- path_provider_platform_interface 2.0.0 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.1 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.11.0
- platform 3.0.0
- plugin_platform_interface 2.0.0 [meta]
- process 4.2.1 [file path platform]
- pub_semver 2.0.0 [collection]
- quiver 3.0.1 [matcher]
- sky_engine 0.0.99
- source_gen 0.9.10+3 [analyzer async build dart_style glob meta path pedantic source_span]
- source_span 1.8.0 [charcode collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.2.19 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- url_launcher_linux 2.0.0 [flutter]
- url_launcher_macos 2.0.0 [flutter]
- url_launcher_platform_interface 2.0.2 [flutter plugin_platform_interface]
- url_launcher_web 2.0.0 [url_launcher_platform_interface meta flutter flutter_web_plugins]
- url_launcher_windows 2.0.0 [flutter]
- vector_math 2.1.0
- watcher 1.0.0 [async path pedantic]
- win32 2.0.5 [ffi]
- xdg_directories 0.2.0 [meta path process]
- yaml 3.1.0 [collection source_span string_scanner]

Hi @yulkin2002
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/4950.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Copy-Paste inop in XUbuntu

Unable to user Copy-Paste in XUbuntu.
Tried middle click, ctrl-c, ctrl-v to no avail

did you copy the alacritty.yml file from the repo root to ~/.alacritty.yml?
that file contains configuration settings including keybindings.  the default for copy/paste is command-c/command-v.

Yes, in my current user dir, saw theses bindings. Let me know if need more details to reproduce bug, really loved the snappyness!

The default is NOT Ctrl-C / Ctrl-V but Super-c / Super-V.
Super = Command on Macs or the Windows key on Win keyboards...

It'd be also cool if there was a right click menu, gnome-terminal style with copy/paste options there.

I second sokoow's comment. Issue might need renaming: Right-click menu feature request.

Right-click menus are not going to happen. It's just too much work for a tiny quality-of-life feature. What's wrong with just having key bindings?


Bug: bdgbroadcall reporting problem

Describe the bug
I’m trying to call peaks using bdgbroadcall from bdg generates by cmbreps and -m fisher  But the out put of the bdgbroadcall contain no p – value or any other than coordinate (below you can find the heading of the output)
track name="peak" description="peak" type=gappedPeak nextItemButton=on
chr1<PHONE_NUMBER>40 H3K4me1_H0_1_2_G840.bdg_broadRegion1 0 .<PHONE_NUMBER>40 0 2 1,1 0,209 0.00000 0.00000 0.00000
chr1<PHONE_NUMBER>78 H3K4me1_H0_1_2_G840.bdg_broadRegion2 0 .<PHONE_NUMBER>78 0 3 1,632,1 0,37,678 0.00000 0.00000 0.00000
chr1<PHONE_NUMBER>04 H3K4me1_H0_1_2_G840.bdg_broadRegion3 0 .<PHONE_NUMBER>04 0 3 1,212,1 0,1915,2177 0.00000 0.00000 0.0000
To Reproduce
So this what I did
1 call peaks after removing all duplicates
macs2 callpeak -t $INDIR/ Sample1_Mkdup_fliter.bam
-c $Input/Input_Mkdup_fliter.bam
-f BAM -g hs -n H3K4me1_H0_1 -B --broad -q 0.01 --keep-dup all --nomodel --extsize 210 –outdir
2 compare pileup and lambda for each replicates to get pvalue track
macs2 bdgcmp -t rep1_pileup.bdg -c rep1_lambda.bdg -m ppois -o rep1_pvalue.bdg
macs2 bdgcmp -t rep2_pileup.bdg -c rep2_lambda.bdg -m ppois -o rep2_pvalue.bdg
3- combine both files
macs2 cmbreps -i rep1_pvalue.bdg rep2_pvalue.bdg -m fisher -o rep1_rep2_pvalue.bdg.bdg
4 recall peaks
macs2 bdgbroadcall -i rep1_rep2_pvalue.bdg.bdg -c 8 -l 210 -g 76 -o rep1_rep2.bdg
Expected behavior
I think it is a reporting problem by macs2 , since the narrow peak calling with bdgpeakcall tool work fine
Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

OS: [e.g. Linux, Mac OSX]

Additional context
Add any other context about the problem here.

Hei
Do you have any update on the issue

@Me6me82 I will fix that. The plan is to output the average score in the 5th column.

Thank you , yes

Hei
Do you have any update on the issue

@Me6me82 I am currently working on other issues (359 and 351). Will work on this later...

@Me6me82 Fixed in PR #373. Will be included in the next release.

@taoliu Thanks, when do you expect the next release will be available!

@Me6me82 This week.

@Me6me82 v<IP_ADDRESS> is out.


Clean up conversations

As Conversations API does not provide an efficient way to look up open Conversations, we can mitigate this by removing closed conversations on  a regular basis.
Acceptance criteria:
Provide an example of how to trigger the deletion of conversations

This is handled here: https://github.com/aymenn/masked-comms-app/blob/master/src/routes/index.ts#L6


[FormRecognizer] Updated CHANGELOG and version number

API change check
API changes are not detected in this pull request.


Analytic Updates - 01262021

New Analytic Stories:

Trusted Developer Utilities Proxy Execution
Trusted Developer Utilities Proxy Execution MSBuild

New Analytics:
Trusted Developer Utilities Proxy Execution MSBuild

Suspicious MSBuild Rename (Passed)
Suspicious MSBuild Spawn (Passed)
Suspicious msbuild path (Passed)

Trusted Developer Utilities Proxy Execution

Suspicious microsoft workflow compiler rename (Passed)
Suspicious microsoft workflow compiler usage (Passed)

Suspicious MSHTA Activity

Suspicious mshta child process
Detect MSHTA Url in Command Line (Passed)
Detect Rundll32 Inline HTA Execution (Passed)
Suspicious mshta spawn (Passed)
Detect mshta inline hta execution (Passed)

Ryuk Ransomware

NLTest Domain Trust Discovery
WBAdmin Delete System Backups (Passed)

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.7020000000000001s
scanCount: 12

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.7020000000000001s
scanCount: 12

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :x:

diskUsage: 339968
runDuration: 0.937s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :x:

diskUsage: 339968
runDuration: 0.937s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 339968
runDuration: 0.921s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 339968
runDuration: 0.921s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :x:

diskUsage: 335872
runDuration: 0.873s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :x:

diskUsage: 335872
runDuration: 0.873s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 344064
runDuration: 0.961s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 344064
runDuration: 0.961s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.706s
scanCount: 13

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.706s
scanCount: 13

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.6960000000000001s
scanCount: 10

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :x:

diskUsage: 270336
runDuration: 0.6960000000000001s
scanCount: 10

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 335872
runDuration: 0.9550000000000001s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :x:

diskUsage: 335872
runDuration: 0.9550000000000001s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :white_check_mark:

diskUsage: 364544
runDuration: 2.987s
scanCount: 3192

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect wmiprvse spawn msbuild :white_check_mark:

diskUsage: 364544
runDuration: 2.987s
scanCount: 3192

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :white_check_mark:

diskUsage: 368640
runDuration: 2.922s
scanCount: 3192

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect moved msbuild execution :white_check_mark:

diskUsage: 368640
runDuration: 2.922s
scanCount: 3192

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :white_check_mark:

diskUsage: 294912
runDuration: 2.599s
scanCount: 3208

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :white_check_mark:

diskUsage: 294912
runDuration: 2.599s
scanCount: 3208

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect microsoft.workflow.compiler.exe rename :white_check_mark:

diskUsage: 299008
runDuration: 8.677s
scanCount: 14230

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect microsoft.workflow.compiler.exe rename :white_check_mark:

diskUsage: 299008
runDuration: 8.677s
scanCount: 14230

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect microsoft.workflow.compiler.exe usage :white_check_mark:

diskUsage: 360448
runDuration: 9.65s
scanCount: 14217

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect microsoft.workflow.compiler.exe usage :white_check_mark:

diskUsage: 360448
runDuration: 9.65s
scanCount: 14217

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect rundll32 executing hta with inline protocols :white_check_mark:

diskUsage: 360448
runDuration: 6.6290000000000004s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect rundll32 executing hta with inline protocols :white_check_mark:

diskUsage: 360448
runDuration: 6.6290000000000004s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta url in command line :white_check_mark:

diskUsage: 348160
runDuration: 6.5360000000000005s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta url in command line :white_check_mark:

diskUsage: 348160
runDuration: 6.5360000000000005s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawn :white_check_mark:

diskUsage: 360448
runDuration: 6.605s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawn :white_check_mark:

diskUsage: 360448
runDuration: 6.605s
scanCount: 9131

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
WBAdmin Delete System Backups :white_check_mark:

diskUsage: 348160
runDuration: 1.222s
scanCount: 29

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
WBAdmin Delete System Backups :white_check_mark:

diskUsage: 348160
runDuration: 1.222s
scanCount: 29

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :x:

diskUsage: 126976
runDuration: 0.004s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :x:

diskUsage: 126976
runDuration: 0.004s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :x:

diskUsage: 126976
runDuration: 0.003s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :x:

diskUsage: 126976
runDuration: 0.003s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 376832
runDuration: 0.9390000000000001s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 376832
runDuration: 0.9390000000000001s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 368640
runDuration: 0.917s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 368640
runDuration: 0.917s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :white_check_mark:

diskUsage: 430080
runDuration: 1.1500000000000001s
scanCount: 4

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
NLTest Domain Trust Discovery :white_check_mark:

diskUsage: 430080
runDuration: 1.1500000000000001s
scanCount: 4

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 376832
runDuration: 0.937s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :x:

diskUsage: 376832
runDuration: 0.937s
scanCount: 0

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :white_check_mark:

diskUsage: 397312
runDuration: 11.790000000000001s
scanCount: 17702

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect mshta spawning a process :white_check_mark:

diskUsage: 397312
runDuration: 11.790000000000001s
scanCount: 17702

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :white_check_mark:

diskUsage: 299008
runDuration: 2.657s
scanCount: 3205

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect renamed msbuild execution :white_check_mark:

diskUsage: 299008
runDuration: 2.657s
scanCount: 3205


TypeError: mixed.hasOwnProperty

Environment
Knex version<EMAIL_ADDRESS><EMAIL_ADDRESS>Database + version: PostgreSQL 10.3 (Debian 10.3-1.pgdg90+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit
OS: Debian GNU/Linux 9 (stretch), macOS 10.11.6, and Ubuntu 18.04.1 LTS (Bionic Beaver)
Bug

Explain what kind of behaviour you are getting and how you think it should do
Not error out on checks for undefined properties on an object.

Error message

TypeError: mixed.hasOwnProperty is not a function:
      at Object.containsUndefined (./node_modules/knex/lib/helpers.js:40:17)
      at Object.containsUndefined (./node_modules/knex/lib/helpers.js:42:37)
      at Object.containsUndefined (./node_modules/knex/lib/helpers.js:42:37)
      at Object.containsUndefined (./node_modules/knex/lib/helpers.js:36:35)
      at Raw.toSQL (./node_modules/knex/lib/raw.js:135:17)
      at ./node_modules/knex/lib/runner.js:39:32
  From previous event:
      at Runner.run (./node_modules/knex/lib/runner.js:34:31)
      at Raw.Target.then (./node_modules/knex/lib/interface.js:20:43)
      at process._tickCallback (internal/process/next_tick.js:189:7)

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to mysql or postgresql, then single file example which initializes
needed data and demonstrates the problem.
I think trying to use anything that uses a null prototype, which does not inherit the base properties and methods of ordinary Object instances (see: hapijs/hapi#3280 for a similar issue) in bindings.

I have a PR ready to go that fixes this (its one line)...

@mwilliammyers Could you please add test to that fix as well?

What is the status of this, I am having the same issue?

status is cannot reproduce. not enough details in issue to take any actions.


aixPB: remove unneeded libXrender-devel and related packages

Closes: #2069
Closes: #1772

Checklist

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

FYI: manually applying it to systems adopt-01, 03 and 04 (05, 06, 07, 08 were built after the merge, 02 was used to test PR effectiveness).

Before:

adopt01:
libXrender-0.9.8-2waixX11.ppc
libXrender-devel-0.9.8-2waixX11.ppc
==============
adopt02:
==============
adopt03:
libXrender-0.9.8-3waixX11.ppc
libXrender-devel-0.9.8-3waixX11.ppc
==============
adopt04:
libXrender-0.9.8-2waixX11.ppc
libXrender-devel-0.9.8-2waixX11.ppc
==============
adopt05:
==============
adopt06:
==============
adopt07:
==============
adopt08:
==============

After:
root@nim.bak:[/home/root]dsh-adopt.ksh "rpm -qa | grep libXrender"
adopt01:
==============
adopt02:
==============
adopt03:
==============
adopt04:
==============
adopt05:
==============
adopt06:
==============
adopt07:
==============
adopt08:
==============


Disagreement about design

I can tell right now that to finish this challenge, I need to store a third private member - fullName - so that firstName and lastName remain undefined. But this doesn't seem like good OO practice to me. getFullname() should only ever be a method that aggregates firstName and lastName. I will tweak my class appropriately, but I felt strongly enough (not too strongly, because obviously it only takes 2 minutes to register this disagreement) to drop a message about it.
Challenge Make a Person has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
class Person {
  constructor() {
    var arr = [];
    if(arguments.length === 1) {
      arr = arguments[0].split(" ");
      this.firstName = arr[0];
      this.lastName = arr[1];
    } else if (arguments.length === 2) {
      this.firstName = arguments[0];
      this.lastName = arguments[1];
    } else {
      this.firstName = undefined;
      this.lastName = undefined;
    }
  }
  setFirstName(first) {
    this.firstName = first;
  }
  setLastName(last) {
    this.lastName = last;
  }
  setFullName(firstAndLast) {
    var arr = firstAndLast.split(" ");
    this.firstName = arr[0];
    this.lastName = arr[1];
  }
  getFirstName() {
    var str = this.firstName;
    return str;
  }
  getLastName() {
    return this.lastName;
  }
  getFullName() {
    return this.firstName + " " + this.lastName;
  }

}

var bob = new Person('Bob Ross');
bob.getFirstName();

@attributeofextension I am not sure, is this a bug report for a issue with the challenge, or you are looking for feedback on your code?
Please clarify further about the exact issue?

Hi @attributeofextension
Thanks for the report. The issue tracker is for reporting bugs only.
Please use the chat rooms:

HTML/CSS help chat room
JavaScript help chat room
Other Official Rooms

or try looking through our forum for help with a specific challenge.
Happy Coding!


Missed file in models directory

Hello, thanks for the code again. I found many files that are imported in models/__init__.py are missed, e.g., .face_gan, leading to many dependency errors when running train.py. Would you please check on the model files? Many thanks.

@GolferChen Hi man, thank you for pointing this out. The aforementioned FaceGan is actually located in models/face_decoders.py. Actually, the open-source version of models/__init__.py is a bit outdated. You can checkout models/model_setup.py to see which modules in models/__init__.py are actually needed and delete the redundant parts.
Since I am currently on vacation and have limited access to my computing clusters. As it is, would you please fix the issue above, and send me a pull request if it is convenient for you?
Thank you for your kind help.

Hello, @BAI-Yeqi, I have uncommented the useless import in models/. Now it works now. Please check the pull request.

@GolferChen Good evening, I have merged the aforementioned pull request and removed redundant comments.
If this repo is currently working fine on your machine, would you like to close this issue? Thank you~


Random performance drops on Mac OS when running simple animation

Details
Even the simplest animating flutter app drops frames.
This is the issue pertaining Mac OS but I was able to reproduce it on iOS, Android and Windows as well.
https://user-images.githubusercontent.com/9286493/214910746-0e00648c-a3fa-45b6-a0bd-57c631b591e0.MOV
trace

Target Platform: Mac OS
Target OS version/browser:  Ventura 13.2
Devices: MacBook Pro 2017 (3.1 GHz Dual-Core Intel Core i5, Intel Iris Plus Graphics 650 1536 MB, 8 GB 2133 MHz LPDDR3)
Logs

Logs

tristan@MacBook-Pro performance_test % flutter analyze
Analyzing performance_test...
No issues found! (ran in 4.3s)

tristan@MacBook-Pro performance_test % flutter doctor -v
[✓] Flutter (Channel master, 3.7.0-28.0.pre.7, on macOS 13.2 22D49 darwin-x64,
    locale en-US)
    • Flutter version 3.7.0-28.0.pre.7 on channel master at
      /Users/tristan/development/bin/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c9affdba9d (12 hours ago), 2023-01-25 21:25:02 -0800
    • Engine revision 8f1e5dc1b1
    • Dart version 3.0.0 (build 3.0.0-157.0.dev)
    • DevTools version 2.20.1

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/tristan/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Ultimate Edition (version 2022.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (3 available)
    • Tristan’s iPhone (mobile) • 00008020-001D0C2E1A12002E • ios            •
      iOS 16.2 20C65
    • macOS (desktop)           • macos                     • darwin-x64     •
      macOS 13.2 22D49 darwin-x64
    • Chrome (web)              • chrome                    • web-javascript •
      Google Chrome 109.0.5414.119

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

Same as
https://github.com/flutter/flutter/issues/119254#issuecomment-1406060260


Handle tenant domain properly for SaaS applications in WS-Trust

Is your suggestion related to an experience? Please describe.
Once https://github.com/wso2/product-is/issues/9483 is fixed, the STS service supports tenanted calls. However, if the user's tenant domain is not present in the request, the service will assume that the user belongs to the service tenant domain which is derived based on the sts service request URI.
But ideally, we should do this assumption only for non-SaaS apps. For SaaS apps, we still need to mandate tenant domain in the user's username.
Describe the improvement
When the STS request comes, it includes the WS-trust audience URL in the request. This URL is added to the service provider configuration in WSO2 IS, therefore it should allow identifying the SP eventually allowing to figure out whether the targetted application is SaaS or not. If the app is SaaS, the tenant domain in the username is a must. Otherwise, the tenant domain is assumed as same as the service tenant domain, if it's not available in the username.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Bug: If you change the language while the user profile page is open, the Purpose and Sex fields will not be translated until you re-enter the page or open a different profile

Fixed by 8ce6944 commit


Jupyter unicycle: plot issue with ubuntu 1604

In GitLab by @cmastalli on Jan 30, 2019, 10:49
You can solve them by upgrading your matplotlib
pip install --upgrade --user pip
pip install --upgrade --user matplotlib
Restart you kernel.

In GitLab by @cmastalli on Jan 30, 2019, 10:50
changed the description

In GitLab by @cmastalli on Jan 30, 2019, 14:22
sudo apt install ffmpeg

In GitLab by @nmansard on Jan 30, 2019, 17:50
@cmastalli could you please add these instructions to the jupyter in the first part?
We also needed a recent version of matplotlib.

In GitLab by @cmastalli on Jan 31, 2019, 13:33
mentioned in merge request !84

In GitLab by @cmastalli on Jan 31, 2019, 13:34
This issue will be closed after merging !84.

In GitLab by @nmansard on Feb 2, 2019, 09:24
mentioned in commit ff17958013127bddd924ca9f35967ce9381696a1

In GitLab by @nmansard on Feb 2, 2019, 09:25
closed


[windows] bundler installs multiple platforms when platform ruby is present

ruby 2.2.2p86 (2015-03-03 revision 49825) [x64-mingw32]
IMO bundler should not install additional platforms if platform ruby is present.
ruby require is not aware of platforms and platform ruby has precedence over other platforms (e.g. x64-mingw32).
e.g. building mysql2 with devkit and up2date libmysql
gem install mysql2 -N --platform=ruby -- "--with-mysql-dir=c:/apps/redmine_dev/mysql-5.6.23-winx64"
now running bundle install (e.g. with redmine) will install additionally mysql2-0.3.18-x64-mingw32.gem

Please follow ISSUES and provide a complete description of your environment, what you are doing, what happens, what you expect to happen instead, and why you expect that. Thanks!

on a fresh ruby installation
compile gem mysql2 with devkit (only possible for platform ruby)
require test succeeds
run bundle install
installs additional mysql2 gem for platform x64-mingw32
require test failes
workaround: manually uninstall platform x64-mingw32
C:\apps\redmine_dev\test>ruby -v
ruby 2.2.2p86 (2015-03-03 revision 49825) [x64-mingw32]

C:\apps\redmine_dev\test>more mysql.rb
require 'mysql2'
C:\apps\redmine_dev\test>gem list

*** LOCAL GEMS ***

bigdecimal (1.2.6)
io-console (0.4.3)
json (1.8.1)
psych (2.0.8)
rake (10.4.2)
rdoc (4.2.0)

C:\apps\redmine_dev\test>gem install bundler
Fetching: bundler-1.8.3.gem (100%)
Successfully installed bundler-1.8.3
1 gem installed

C:\apps\redmine_dev\test>gem install mysql2 -N --platform=ruby -- "--with-mysql-dir=c:/apps/redmine_dev/mysql-5.6.23-winx64"
Fetching: mysql2-0.3.18.gem (100%)
Building native extensions with: '--with-mysql-dir=c:/apps/redmine_dev/mysql-5.6.23-winx64'
This could take a while...
Successfully installed mysql2-0.3.18
1 gem installed

C:\apps\redmine_dev\test>ruby mysql.rb

C:\apps\redmine_dev\test>more Gemfile
source 'https://rubygems.org'

gem "mysql2", "~> 0.3.11"

C:\apps\redmine_dev\test>bundle install
Fetching gem metadata from https://rubygems.org/..
Fetching version metadata from https://rubygems.org/.
Resolving dependencies...
Installing mysql2 0.3.18
Using bundler 1.8.3
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.
Post-install message from mysql2:

======================================================================================================

 \ You've installed the binary version of mysql2.
  It was built using MySQL Connector/C version 6.1.5.
  It's recommended to use the exact same version to avoid potential issues.

  At the time of building this gem, the necessary DLL files were retrieved from:
  http://cdn.mysql.com/Downloads/Connector-C/mysql-connector-c-6.1.5-winx64.zip

 \ This gem *includes* vendor/libmysql.dll with redistribution notice in vendor/README.

======================================================================================================

C:\apps\redmine_dev\test>gem list

*** LOCAL GEMS ***

bigdecimal (1.2.6)
bundler (1.8.3)
io-console (0.4.3)
json (1.8.1)
mysql2 (0.3.18 ruby x64-mingw32)
psych (2.0.8)
rake (10.4.2)
rdoc (4.2.0)

C:\apps\redmine_dev\test>bundle env
Environment

    Bundler   1.8.3
    Rubygems  2.4.5
    Ruby      2.2.2p86 (2015-03-03 revision 49825) [x64-mingw32]
    Git       2.3.1

Gemfile

    source 'https://rubygems.org'

    gem "mysql2", "~> 0.3.11"

Gemfile.lock

    GEM
      remote: https://rubygems.org/
      specs:
        mysql2 (0.3.18-x64-mingw32)

    PLATFORMS
      x64-mingw32

    DEPENDENCIES
      mysql2 (~> 0.3.11)

C:\apps\redmine_dev\test>ruby mysql.rb
C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- mysql2/2.2/mysql2 (LoadError)
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from C:/apps/redmine_dev/ruby/lib/ruby/gems/2.2.0/gems/mysql2-0.3.18-x64-mingw32/lib/mysql2/mysql2.rb:2:in `<top (required)>'
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from C:/apps/redmine_dev/ruby/lib/ruby/gems/2.2.0/gems/mysql2-0.3.18-x64-mingw32/lib/mysql2.rb:31:in `<top (required)>'
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:128:in `require'
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:128:in `rescue in require'
        from C:/apps/redmine_dev/ruby/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:39:in `require'
        from mysql.rb:1:in `<main>'

C:\apps\redmine_dev\test>
C:\apps\redmine_dev\test>gem uninstall mysql2

Select gem to uninstall:
 1. mysql2-0.3.18
 2. mysql2-0.3.18-x64-mingw32
 3. All versions
> 2
Successfully uninstalled mysql2-0.3.18-x64-mingw32

C:\apps\redmine_dev\test>ruby mysql.rb

C:\apps\redmine_dev\test>

What does "compile gem mysql2 with devkit" mean? What are the steps I need to follow to reproduce this problem? If possible, please provide a ruby script I can run that will demonstrate the problem. Please keep in mind that I don't use Windows on a daily basis, so your reproduction instructions will need to include how to install Ruby in the first place.

@ABaumgaertner is the problem that there's no way to force Bundler to compile a gem's extension from source when there is a platform-specific binary version available? That's how I interpret what you're saying. I think that's correct that Bundler currently has no way to do that, and it does sound like a reasonable thing to want to do.

the relevant feedback from this issue:

there's no way to force Bundler to compile a gem's extension from source when there is a platform-specific binary version available

This keeps on biting me with the sqlite3  gem , the mysql gem.  Any movement on this?  Can someone knowledgeable with bundlers code base outline the tasks needed to make this happen so that I or someone else can attempt to fix this?

Master now has a configuration option for this, but I can't remember what it is

bundle config force_ruby_platform should address this issue, so I think it's safe to close.


Drop dirs in favor of home

This replaces the usage of the dirs crate with home (sans a couple of cleanup commits)
The dirs crate somewhat recently decided to transitively pull in option-ext for "stylistic reasons" instead of using a trivial comparison. Frankly this is NodeJS levels of silliness that I won't entertain. The home crate does everything we need for our supported platforms, and is maintained by the Rust project whom I actually trust to be reasonable

And here's the backlink

https://github.com/dirs-dev/dirs-sys-rs/issues/21


Publish to Artifactory on release

something is wrong here. we build our libs with simplified workflow https://github.com/enonic/lib-cache/blob/master/.github/workflows/enonic-gradle.yml

We need to publish on NPM with every release. Do we need two separate actions for release?

we could improve simplified workflow to do that @alansemenov

we could improve simplified workflow to do that @alansemenov

Then we need to rename the workflow file, otherwise it will be overwritten on the next batch update of the standard workflow

next batch update

we don't do it anymore


Wrong description op OptionMembers.

Sets the list of options that are available in the field that is currently selected? Nope, it does not set, but defines ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e845063-6484-9104-1441-042482cc55ec
Version Independent ID: 33f0aa0d-598d-2b30-7659-45aaf317da6c
Content: OptionMembers Property (Field) - Business Central
Content Source: dev-itpro/developer/properties/devenv-optionmembers-field-property.md
Service: dynamics365-business-central
GitHub Login: @ailie13
Microsoft Alias: solsen

Thanks for the feedback. This will be fixed with our next refresh.

This was never changed. What should it have been changed to? I don't see how this defines anything; it looks to be only a getter.

Changed get to set in my initial post.

OK, so it was wrong but is not OK :-)

OK, so it was wrong but is now OK :-)


[openmvg:x64-windows-static-md] build failure with static CRT linking.

as it is mentioned in #12229
`
main_ComputeFeatures.cpp.obj : error LNK2019: unresolved external symbol __imp_vl_constructor referenced in function "public: __cdecl openMVG::features::SIFT_Image_describer::SIFT_Image_describer(struct openMVG::features::SIFT_Image_describer::Params const &,bool)" (??0SIFT_Image_describer@features@openMVG@@QEAA@AEBUParams@012@_N@Z)
`
I would like to use x64-windows-static-md to build openmvg[software].

@cenit  Could you please take a look?
Thanks.

It's an open issue that the software feature of openmvg does not build correctly with statically linked libs.
I will investigate it more and I hope it can be fixed soon

Ping @cenit, any progress?

to be honest, i don't know.
I saw that openmvg was updated to v2.0 by others, maybe the update fixed the error? sorry i don't have much time

@FishHe Is this issue still exist?

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.


ECVRF integration

The lottery should be based on random that's not influencable by validators, such as https://github.com/ProgramCrafter/ecvrf-coordinator-contract.

Developers are welcome to work on this issue! It's part of Hack-TON-berfest and as such participants are eligible for more merch.

Hi @ProgramCrafter , is this issue still valid for hacktober fest? I would like to work on this one.

@Prajjawalk Hello!


Removes trace agent experiments while failures are investigated

What does this PR do?
This removes the trace_agent_* experiments from main
Motivation
The trace_agent_json has been observed to fail frequently which is harming all jobs executing.
We can investigate from a branch, so no need to harm all jobs.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes

/merge


amod_legacy: rewrite cached invites logic

This PR aims to rewrite the logic of the cached invites in the automod_legacy package.
The old logic was messy, I find this new one much cleaner.
Other than that, this logic is orders of magnitude faster: (Benchmark with 100k cached invites)
BenchmarkOldInviteLogic-16       10000		107938 ns/op		0 B/op		0 allocs/op
BenchmarkNewInviteLogic-16    53481894		 22.52 ns/op		0 B/op		0 allocs/op

The reason behind this change is that the old logic cached the invites in a map but used guildIDs as the keys, which is not efficient at all for this use case: CacheMap map[int64][]oldCachedInvite
This gave no performance benefit over a simple slice of cached invites. It might even be slower than a slice of invites.
In this new logic, I'm caching the invites in a map using their code as the keys. This is much faster, because we are always searching for the invite by it's code. invites map[string]cachedInvite

I have no doubt that this is faster, but the benchmark appears flawed in multiple ways to me. For one, it never retrieves an entry that is actually in the map -- instead, it looks up the same entry over and over, which is not a representative scenario. In the case that there are no hash collisions, the branches in the map access call should be predictable and thus avoid the cost of incorrect branch prediction.
More importantly, the benchmark is not concurrent and does not interleave writes with reads. Instead, it performs a large number of writes and then a large number of reads on a single thread. These two factors cause the cost of the mutex to essentially not be factored in at all as there is no possible contention, starving, etc.
Ultimately, while the increased performance of this implementation is not in question, I recommend that the benchmark be either removed or rewritten to address these concerns. As it stands, it does not provide an accurate picture of the absolute performance of this implementation and may mislead future contributors who attempt to optimize this code further (given that it is a hot spot.)


Ability to specify source directory for Lambda@Edge submodule

what

Ability to specify source directory for Lambda@Edge submodule

why

Currently, we can pass the list of files that will be archived and uploaded as Lambda sources. This is not an option if more advanced logic is used and a lot of files should be used.

Example
For example, we have the following file structure for lambda@edge submodule:
lambda_edge_example/
    lib/
        node_modules/
        index.js
        package.json
        package-lock.json
    context.tf
    main.tf
    outputs.tf
    variables.tf

And we want the whole directory lib to be packaged.
With this enhancement path to lib might be specified like this
module "lambda_edge" {
  source  = "cloudposse/cloudfront-s3-cdn/aws//modules/lambda@edge"
  version = "x.xx.x"

  functions = {
    viewer_request = {
      source_dir   = "${path.module}/lib/"
      runtime      = "nodejs12.x"
      handler      = "index.handler"
      event_type   = "viewer-request"
      include_body = false
    }
  }

  // ...
}

/test all

/test all

/test all

/test all

/test all

/test all


Remove api from readme

Plus some more code examples, more ES6, more cross-links to docs, move .md files to /docs.

:+1:

Ready to review and merge. Please, check.


Add pagination to blog articles

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)
Blog
Describe the feature you'd like to request
Add pagination to the list of blog articles at https://podkrepi.bg/blog
Describe the solution you'd like
Use Material UI pagination component in similar way to donation wishes pagination
https://github.com/podkrepi-bg/frontend/blob/00f1d20f757220058aa3f7eef71c7600e0848109/src/components/campaigns/DonationWishes.tsx#L81-L85
See documentation on Ghost Content API at https://ghost.org/docs/content-api/#filter

Can I be assigned to this ?


Show commits in changelog even if they don't follow format

Pretty simple usage question, but is there a way to show commits that don't follow the conventionalcommits format? It would be convenient if they appeared under e.g. an "Other" heading.

Not as far as I'm aware, sorry.
From a quick glance at the conventional-changelog-config-spec I don't see a way to do this, but that doesn't mean it isn't possible with some option.
Following the fork rationale, this might be a little outside the remit, but I'd be happy to expose anything that you can make the conventional-commit related dependencies do.

Thanks for the quick response. conventional-changelog-cli adds the commits without sections if no preset is set, so
I'm guessing the undefined types are discarded here. Is there a way to define writerOpts.transform  in the package.json, or use a custom preset? I'm not very experienced with JS so I'm stabbing in the dark.

You can use a custom preset with the preset option - which I believe you can set on the command line or in the package json like this:
{
  "commit-and-tag-version": {
    "preset": "alternative-preset-name"
  }
}

Looking at the code, I think it will treat preset: "" as no preset, and then override it with the default. So you might have to figure out which preset will do what you want.

I'll close this for now. Please feel free to reopen (or make another issue) if you have any further questions


Remove composer

Composer is now using the new dependency workflow: https://github.com/paketo-buildpacks/composer/issues/55
See #237  for a similar example of removing a dependency.

BLOCKED because passenger is not (yet) using the new workflow.

@joshuatcasey this is unblocked, right?

You are correct @sophiewigmore , I will fix up this PR and make it as ready.


chore: add security policy, elaborate on test policy

Based on code-scanning feedback for https://github.com/jenstroeger/python-package-template/security/code-scanning/36 and issue https://github.com/jenstroeger/python-package-template/issues/13, this change adds a security policy to our template repo.

…we should probably do with SECURITY.md what we did with README.md and CHANGELOG.md — make it a symlink to UPSTREAM_SECURITY.md 🤔

…we should probably do with SECURITY.md what we did with README.md and CHANGELOG.md — make it a symlink to UPSTREAM_SECURITY.md 🤔

…we should probably do with SECURITY.md what we did with README.md and CHANGELOG.md — make it a symlink to UPSTREAM_SECURITY.md thinking

I wonder if Scorecards would be sensitive to names?

I wonder if Scorecards would be sensitive to names?

Or is able to follow symlinks 😉

I wonder if Scorecards would be sensitive to names?

Or is able to follow symlinks wink

We will find out!

Hmm, is this PR a chore: (no version bump) or a fix: (patch version bump)?

Hmm, is this PR a chore: (no version bump) or a fix: (patch version bump)?
docs: is not accepted?

Hmm, is this PR a chore: (no version bump) or a fix: (patch version bump)?

docs: is not accepted?


HWP-497 Update tests.

Description
This PR includes the following proposed change(s):

Temporarily remove user deletion. (not needed during test runner anyway)
Lessen timeout time.

Goal is to speed up test runner.
Requires
Add 'Requires Attention' label if appropriate.

[ ] Requires an update to the .env file
[ ] Requires adding a file listed in the .gitignore
[ ] Requires an opinion or answer to a question, see comments.
[ ] Requires other attention, see below.

If there are any requirements for the developer to make after this PR is merged please list them here.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Tested locally by running API tests.
For pull requests that are not just a simple fix, please check that the branch works on your local machine.

[ ] Tested by Zach.
[ ] Tested by Brandon.
[ ] Tested by Brady.

Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes
[ ] If attention is required by the developer such as updating the .env file, these requirements have been listed.

Still suffering from hang up issues in testing workflow. Need to wait until that issue is resolved before continuing.

~40 minutes with hangs to < 4 minutes. A few more issues to trim out for fastest runtime.

Down to 2m 37s. 👍


Update docker readme - move reviewed items into main area

Guidance on testing PRs has been reviewed and updated or had small changes made

@dmilet fyi - just some small changes to the docker steps for testing PRs and a reduction of the page area marked as under review. Nothing major, so merging these.


Modified contact us page to the current version of EvalAI

For the right side icon of all input, changed to use font-awesome icon instead of having image for all of them, so for all other input icons like in Login or Signup we'll change that in coming PR's

In the html of Input Component, added the input for textarea

Used package ngx-textarea-autosize for dynamically changing the height of textarea when input length grows

Link to live demo: http://pr-133-evalai.surge.sh

Here's the screenshot:

Codecov Report

Merging #133 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #133      +/-   ##
=========================================
- Coverage   53.43%   53.4%   -0.03%
=========================================
  Files          55      55
  Lines        2360    2348      -12
  Branches      253     253
=========================================
- Hits         1261    1254       -7
+ Misses       1025    1020       -5
  Partials       74      74

Impacted Files
Coverage Δ

src/app/components/contact/contact.component.ts
78.78% <ø> (+7.67%)
:arrow_up:

...rc/app/components/utility/input/input.component.ts
59.45% <0%> (ø)
:arrow_up:

src/app/services/mock.window.service.ts
83.33% <0%> (-16.67%)
:arrow_down:

Impacted Files
Coverage Δ

src/app/components/contact/contact.component.ts
78.78% <ø> (+7.67%)
:arrow_up:

...rc/app/components/utility/input/input.component.ts
59.45% <0%> (ø)
:arrow_up:

src/app/services/mock.window.service.ts
83.33% <0%> (-16.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac2b4f...fdad8aa. Read the comment docs.

@Sanji515 Please resolve the conflicts here.

@Sanji515 Please resolve the conflicts here.

@RishabhJain2018 done

@RishabhJain2018 @galipremsagar @lunayach @Shekharrajak
Please review

@Shekharrajak Please review

Also please write better commit messages from next time --  'suggested changes' doesn't tell anything about commit.


Created first working libgd wrapper

Wrote wrapper method for gdImageCreate in DLLImports.cs
Tested the wrapper in UnitTests.cs
Added a x86 build of libgd to make it run with Developer Command Prompt

Looks good to me

thumbs up


Large language models

Which recent large language models are supported?

GPT-2 models. Basically all models supported by NanoGPT.


@orta => [Fair Map] Allow for more textual content on callout.

For examples see https://github.com/artsy/eigen/issues/127#issuecomment-73930642

Decrease font sizes to 14 and 11 points.
Decrease horizontal margins around views on right side.
Always show arrow chevron at native size.

Fixes #127.

Code looks :+1:
Good for merge

This is green locally.

:+1: Looks great

but needs a rebase

@orta did done it!

Awesome.


Api Released for Scala 3

Hello!
Will the coursier library be released for scala 3?
I searched the other issues but didn't anyone requesting this

This is a duplicate of https://github.com/coursier/coursier/issues/2001


breaking(minimal): handleBuild API for build

also changes define-router

this change is significant. I'm curious, what was the motivation for this refactor?

It's to support api routes. Long journey.

It's to support api routes. Long journey.

wow! I did not expect this to be so disruptive to the current code 😲

API routes are technically already possible with 39_api example.
But, I would like to build static files like RSS. It's completely a new capability.


Teal color in checkbox/radiobutton/switch

Hello, I was wondering if there was an easy way to override the color on a selected checkbox/radiobutton/switch?  The teal color is set in the _.scss but I'm not sure I always want that (unless that's some kind of material design standard thing or something).  Currently, I have changed that color to a $primary-color var in my app but would prefer not to change source like that. If this is intended and there's a simpler way to override in my own sass, that would be great also.
Thanks!
EDIT:  I searched for this issue, but did not look for closed issues.  Sorry!!  I see #142 addresses this.

Dup of #142.  Apologies.


feat(tree): Added longest univalue path.

Coverage remained the same at 100.0% when pulling e43d15eccbc5a541a626fe21e73b4f72764acee8 on longest-univalue-path into 85886ec1184c7ed885659088aa6df05d3d0be4a5 on master.

Coverage remained the same at 100.0% when pulling e43d15eccbc5a541a626fe21e73b4f72764acee8 on longest-univalue-path into 85886ec1184c7ed885659088aa6df05d3d0be4a5 on master.


Added TableDrivenAgentProgram tests

I was going through PR #770  and #749 for adding tests for TableDrivenAgentProgram.
It seems to me that the main purpose of TableDrivenAgentProgram is to append the "percepts" list in the function and take the decisions accordingly.
It would be great if we add tests to check the status of the environment after every step when a new percept is encountered.
This would not only ensure that final environment status is correct but also that the "percepts" list is updated in a right manner.
PR #749 also takes this thinking into account. But, it is always great to add a test which was discussed in the book.
I have implemented the same.
Please have a look @delaray , @MrDupin , @norvig

Sorry; an earlier PR introduced Conflicts here.

Okay! I will try implementing with respect to the recent PRs merged.

Can you please give your inputs now @norvig


Alternative file extension

Apologies if this was brought up previously, I didn't see anything in the issues.
The templated yaml isn't really yaml, it's yaml with the helm template syntax embedded into it. However, Helm still requires the "yaml" extension. This confuses editors because they try to parse the the file as normal yaml and spew out errors since it isn't truly yaml. For example, this confuses VS Code's Kubernetes extension by default, at least without extra configuration.
I think any extension that's unique to helm but also indicates it's not valid yaml is more reasonable than requiring the "yaml" file extension.

Helm doesn't necessarily require the .yaml extension for templates. That's just a common convention.
I'm surprised the VSCode Kubernetes extension does not detect that it is opening a helm template file. IIRC it checks whether it's within the context of a helm chart which disables the syntax highlighter. Source: https://github.com/vscode-kubernetes-tools/vscode-kubernetes-tools/issues/1044#issuecomment-1046353905
Can you make sure you're using the most recent version of the extension?
Anyhoo, this is valid:
$ ls templates/
NOTES.txt  _helpers.tpl  deployment.txt
$ helm template . | head -n 5
---
# Source: test-10771/templates/deployment.txt
apiVersion: apps/v1
kind: Deployment
metadata:

Closing as the original ask (supporting alternative file extensions) is already supported.

Yeah, unfortunately the detection doesn't seem to work on any templated files so I suppose I'll have to figure out why. My original thought was to just change the extension to something other than yaml and make a file association. Thanks for the lead regardless.


Fix memory leak

A huge heap consumption was seen, around 3.8 gigs at the end of the program, need to figure out what caused this leak

A debug build showed much more details :

All i found out was the loop where i used getMessage is causing a lot of allocations, a lot in a loop

Found out that in getMessage(), the KEEP_ALIVE message was getting constantly allocated on the heap as messages.push(msg)

Not clearing the buffer before returning Message::KEEP_ALIVE as causing Message::KEEP_ALIVE to be pushed continously,
    if bytes.len() == 0 {
        // If the buffer is empty then it means there is no message
        None
    } else if bytes.len() == 4 {
        // TODO : Check if the length is (0_u32) as well
        Some(Ok(Message::KEEP_ALIVE))
    } else {
        let pstr_len = bytes[0];

        if pstr_len == 19u8 {

clearing the buffer before returning Message::KEEP_ALIVE can fix this issue

f29ef8a8a60f19c3785a0abb041d6526ec75dcdb fixes the memory allocation


Implement terra-form and related components

Summary
These are the base components needs to build forms using the Terra Framework
Additional Details
This is barebones components. Validations will come at a later time.
Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.
Thanks for contributing to Terra.
@cerner/terra

I moved this to a different pull request due to build issues. I also used a different generator as well on the other pull request, one that is more upto date than the one used here I believe.


Dungeon Enhancements

[x] option to hide dungeon chest popup (#406)
[x] add dungeons to the objective timer (#221)
[x] ~Figure out how to handle Slavers (currently only includes Duncan)~ (See here)
[x] ~Include the dungeon name when pinging levels? Not sure how useful that is as you'll only ping them when talking about that dungeon anyways.~ (See here)
[ ] Show the sum of all levels in the header

With the latest changes I made a few decisions regarding the open points.

For Slaver's Exile only the floor with Duncan is included. Timing the other bosses might be possible by looking at quest updates, walls/doors disappearing/opening or their respective chests appearing (without the giant popup) - but I didn't come up with a reliable way to handle all cases. Unless someone has any new ideas on how to do this I wouldn't know how to implement this properly.
I decided not to include dungeon names when pinging the timers for sake of simplicitly.

KISS - Make them all separate objective sets

I've cleaned up the code a bit and fixed an issue with transitioning between dungeons (Heart of the Shiverpeaks to Bogroot Growths and vice versa).
Is this what you had in mind when asking me to separate objective sets? I could probably group the MapIDs together by dungeon but I feel like that would add more complexity.

I finally got around adding the total time to the header of each objective set, so this should be ready for review now.

This has been merged into dev but I've had to refactor some of the callbacks etc and cleaned the lambdas etc within the whole module, so its not exactly the same logic https://github.com/HasKha/GWToolboxpp/commit/49d9be985a82a058e75b77d211474ff6faebbaa7


Remove positional assignment of QUALIFIER for SPLIT-PATH

Summary of the new feature/enhancement

The call SPLIT-PATH C: $NULL should report an error.
Proposed technical implementation details (optional)
The parameter Qualifier should not be positional.

Closed via #12960


VSCode on Ubuntu 16.04 docker having very weird key bindings

VSCode Version:
1.19.1
OS Version:
Ubuntu 16.04 (Docker)
Steps to Reproduce:

Launch vscode with 'code .'
No plugins installed,  nothing changed but apparently 'e' is backspace, r is 'go right' and 's' is delete line. I have no idea where this keymap comes from, nor did I select it, nor do I find the config back in the keymap.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

For keybinding related issues please follow this guide https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings

Okay, I did not see those, thanks for the quick answer. And btw, the "keyboard.dispatch": "keyCode" helped me out.


Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Version
1.0.3
Installation Type
Official Docker Compose
Service Name
DongTai-Engine
Describe the details of the bug and the steps to reproduce it
1.当我从1.0.0分支切换到1.0.3分支，执行 ./install.sh 进行升级操作时，升级过程显示正常，docker ps 查看显示也正常；
2.但是登录到后台以后，提示接口异常：

Additional Information
No response
Logs
No response

This problem is because the data initialization of the mysql database is not completed or an error occurs. You can view and upload logs through docker logs -f dongtai-mysql to help locate the problem.


Mention Custom Hooks for Redux Integration Docs

I was reading through these Redux Integration docs when I had a bit of a realization:
Now that there are custom hooks for both react-router and react-redux, the new preferred way to integrate redux and react-router is should be a custom hook 🎉.
This issue exists as a feature request to add this information to the docs.
I would be willing to work on that if I have your blessing.
Example:
import { useSelector } from 'react-redux';
import { useRouteMatch } from 'react-router';

function useCurrentMovie() {
  const currentMovieMatch = useRouteMatch('/movies/:movieId');
  const movieId = currentMovieMatch?.params?.movieId;
  const movie = useSelector(state => state.movies[movieId]);
  return movie;
}

Let me know what you think!

There are known disadvantages to React Redux's hooks, namely the loss of top-down updates. We still recommend connect for most use cases.
The main point of the article is pointing out the problem of blocked updates. I don't think we need to expand its scope at this time.

There are known disadvantages to React Redux's hooks, namely the loss of top-down updates.

I thought issues related to top-down updates were mostly fixed with batched updates. Am I missing something?

The main point of the article is pointing out the problem of blocked updates. I don't think we need to expand its scope at this time.

I also thought blocked updates was fixed by updating to the new React context.

I would argue repurposing this doc might help a lot of people. I found that custom hooks are great for doing joins from global sources and redux and react-router are that.

Nope, batches don't change control flow. Only connect can do that, as it can run code before a render even happens; Hooks happen too late.


Settings - Notification mode value

In settings screen, it should display notification mode value with unit, whether it's minutes or hours.

@the-dagger this is already implemented, close this.


[multistage] Use RNG for Request Id Generation

cc: @walterddr
request id collisions across brokers can cause weird query failures (we are seeing this in our production).
Later we should switch to string based request-id. For now going with RNG to avoid having to deal with broker response changes and b/w incompatibility issues.

Codecov Report

Merging #10789 (12172da) into master (3851f33) will decrease coverage by 44.47%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #10789       +/-   ##
=============================================
- Coverage     68.51%   24.05%   -44.47%
+ Complexity     6479       49     -6430
=============================================
  Files          2159     2143       -16
  Lines        116044   115613      -431
  Branches      17569    17514       -55
=============================================
- Hits          79510    27811    -51699
- Misses        30899    84861    +53962
+ Partials       5635     2941     -2694

Flag
Coverage Δ

integration1
24.05% <100.00%> (+0.06%)
:arrow_up:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...requesthandler/MultiStageBrokerRequestHandler.java
62.96% <100.00%> (-4.71%)
:arrow_down:

... and 1548 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


response.ok undefined when response is served from cache

Describe the bug
response.ok is undefined on a first call, when the response is cached
take the Basic Usage example (snippet):
  const [todos, setTodos] = useState([])

  const [request, response] = useFetch('https://example.com')

  async function initializeTodos() {
    const initialTodos = await request.get('/todos')
    if (response.ok) setTodos(initialTodos)    // <------ problem here on first request
  }

response.current is never set when the data was served from cache, so response.ok is undefined
Expected behavior
Either set response.current.ok true, ór update basic usage example

Thank you for the bug report! I will get to this as soon as possible! A workaround while you're waiting for this patch is cachePolicy: 'no-cache'.  I know how to fix this.

thanks for the quick response!
I already implemented the workaround, but would be nice to have caching as well

I have a branch with this fix. Lots of stuff going on so bare with me!

@TheDuc can you confirm this works? v0.3.2?

Going to close this. If the issue persists, just comment back here letting me know and I'll reopen.

Yes, problem persists on my side also (version 0.3.4).

Okay, I found the problem. Premature optimizations. See it working here. This should work in v0.3.6


Camera not supporting

https://github.com/bwp91/homebridge-ewelink/wiki/How-to-set-up-Sonoff-Camera#1-find-the-ip-and-password-for-your-camera
There are no "More Settings" as mentioned under my Camera settings to get the RTSP password. Any other way?

Details of your setup.

Do you use Homebridge (with config-ui?) or HOOBS?
Yes

Which version of Homebridge/HOOBS do you have?
1.1.1

Which version of this plugin (homebridge-ewelink) do you have? Has the issue started since upgrading from a previous version?
3.9.0

Which eWeLink devices do you have that are causing issues? Please include product models if applicable.
Camera

Do you use your main eWeLink credentials or do you use a secondary eWeLink account for Homebridge?
Main

Hi @rashmendis
You don't appear to have the Sonoff Camera model GK-200MP2B? Your model shows as BIT-EYE-GL so perhaps this is why the "More Settings" option doesn't appear?

Are you using the ewelink android camera app?


Add Programming Fundamentals - A Modular Structured Approach using C++ book to free-programming-books.md

Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s)
For resources
Description
The approach of this text is to take learners through a progression of materials in order to develop skills of modular, structured programming using C++.
Why is this valuable (or not)?
Conceptual Approach
The learning modules of this textbook/collection were written with the C++ language to explain modular programming. Often the examples used for C++ are exactly the same for the Java programming language. However, some modules were written specifically for the C++ programming language. This could not be avoided as the C++ language is used in conjunction with this textbook/collection by the author in teaching college courses.
Bloodshed Dev-C++ 5 Compiler/IDE
This open source compiler/IDE (Integrated Development Environment) was used to develop the demonstration source code files provided within the modules of this textbook/collection. The compiler/IDE is presented to the student in the second module of Chapter 1, with instructions for downloading, installing and using the compiler/IDE. A more complete explanation of the IDE along with demonstration source code listings with errors is presented in first module of Chapter 5. All of the source code files provided in this textbook/collection contain only ANSI standard C++ code and should work on any standard C++ compiler like Microsoft Visual Studio (which includes C++), Microsoft Visual C++ Express or Borland C++ Builder.
How do we know it's really free?
The link provided is provided by the Houston Community College which in turn is referenced by the Author Kenneth Busbee's own faculty website.
Kenneth Busbee is a Professor of Computer Science at Houston Community College in Houston, Texas.
The book is licensed under the Creative Commons Attribution 2.0 Generic License, under the purview of which we are free to:
Share — copy and redistribute the material in any medium or format
Adapt — remix, transform, and build upon the material for any purpose, even commercially.
The licensor cannot revoke these freedoms as long as you follow the license terms.
For book lists, is it a book? For course lists, is it a course? etc.
It is a book.
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

Thanks for accepting the PR. I am liking the resources here. I would like to add one other book for C++ with a different PR.
@eshellman Could you please label this PR as ‘hacktoberfest-accepted’ and approve it for the same?
The deadline for completions, merging, labeling, and approving is November 1 as per the site.
Thank you very much for your time and consideration.


Support default event and secret files for terser invocations/deploys?

Deploys and invocations can get a bit cumbersome. E.g.,:
$apex invoke myFunction --env-file functions/myFunction/secret.json < functions/myFunction/event.json

How about apex looking for these filenames by default and, if present in, e.g., functions/myFunction/, deploying/invoking with them?

I don't think the default event JSON file thing is a bad idea, but it's maybe a bit magical. As far as --env-file goes I kind of feel the same there, not everyone will have secrets per-function so that might not be a safe default.
I'm not super happy with how secrets are managed though, maybe supporting a default dotfile at the project root would be enough there to make it less annoying, or specifying a path in project.json? Not sure.
Open to ideas!

Definitely agree it is a bit "magical" and not ideal.
I am coming from node-lambda and am fact still using that for "local" invocations (vs apex for remote invocations). I quite like their approach of accepting, e.g., context.json, event.json, deploy.env, etc, if present, by default. I mean, pretty much every Lambda save for a few are gonna have some event, right? Nice to bake that in if possible.
Why not structure it the same way you have for project.json and function.json? That is, use a project level event.json or secret.json, unless a function level file is available??

Sounds good to me! We merge non-secret env vars, so the function level one could inherit (but take precedence of course). Maybe .secrets.json to signal that it shouldn't be stored in GIT

How do you feel about a similar approach for a project/function(s) event.json (sorry can't find backticks on iPhone)?


cmd/gofmt: quadratic handling of large addition expressions

Given a program with a large string addition
var x = 1 + 1 + 1 + ... 1

gofmt takes time quadratic in the size of the expression to print it back out. Note that this is an integer addition, not a string addition: the problem does not involve string concatenation.
go get -u rsc.io/tmp/bigprog
bigprog gofmt

prints on my system:
          1000  int   0.035s  strbal   0.008s  strbigbal   0.030s  str   0.026s  strbig    0.047s
          2000  int   0.071s  strbal   0.012s  strbigbal   0.051s  str   0.079s  strbig    0.115s
          4000  int   0.291s  strbal   0.022s  strbigbal   0.092s  str   0.271s  strbig    0.362s
          8000  int   1.049s  strbal   0.032s  strbigbal   0.173s  str   1.092s  strbig    1.249s
         16000  int   4.332s  strbal   0.070s  strbigbal   0.346s  str   4.338s  strbig    4.852s
         32000  int  18.897s  strbal   0.112s  strbigbal   0.662s  str  18.212s  strbig   18.889s
         64000  int  82.845s  strbal   0.224s  strbigbal   1.292s  str  84.138s  strbig   83.718s
        128000  int 382.780s  strbal   0.425s  strbigbal   2.588s  str 381.781s  strbig  392.788s

See #23222 for full description of this table, but the important part here is that the int, str, and strbig columns are addition chains like above, while the faster strbal and strbigbal columns have parentheses added to make the addition parse trees balanced. The balanced times double nicely as the input size doubles, so there is no problem with actually generating large outputs. In contrast the unbalanced inputs quadruple as input size doubles, a clear quadratic slowdown. The obvious guess is that it is in the code that decides how to format expressions, and probably in the code that decides whether to insert spaces around expressions. (If so, it's my fault and I apologize.)
This is a fairly minor issue, but it would make gofmt 4X faster even on concatenations of size 1000, which are plausible in generated code (I started this after finding one of size 729).
/cc @griesemer

Too late for 1.11.

Too late for 1.12.


Make filter_record public to enable subclasses to override

Subclasses are quite likely to want to override this if they want to provide custom fitlers, so let's make it public.

Consider this a first draft of the level of customization that I would like. I'm open to suggestions for other approaches. See here for how it was used to implement custom filtering: https://github.com/mood-mapping-muppets/repo/blob/2bc4f5e/ingress/covidmarch.py https://github.com/mood-mapping-muppets/repo/blob/2bc4f5e73c55adb6f35ce1dc848e39b58378bfbd/ingress/mynewsplease.py

Done.


chore(functions/OCR): fix using reserved var name

Do not merge until cl/354393805 is approved.

Edit: I'm closing this request for now, as this change may break more things than I expected. (In particular, default credential behavior.)


fix division by zero errors

@Yarin78 This should fix your issue with division by zero error.

:+1:


Docs - wrong installation commands

The installation command is wrong because tailwindcss should be installed as a dev dependency.
The correct commands are:
# Using npm
npm install tailwindcss --save-dev

# Using Yarn
yarn add -D tailwindcss

I.e. in the upgrade guide (https://tailwindcss.com/docs/upgrading-to-v1/#1-update-tailwind) the commands are correct.

It doesn't matter if you install it as a dev dependency or a regular dependency, it won't end up in your client bundle either way.
These days I personally prefer using regular dependencies for anything needed for building the production code (Tailwind is needed for this), and dev dependencies for tools used during development, like Prettier, Jest, etc.


fixing example in readme

@jeregrine I'm using Phoenix 1.3.2 and I can't get JSON API working without including this two methods in my view. Am I doing something wrong? Here is my view:
defmodule DrivemeterApiWeb.TransactionView do
  use JSONAPI.View, type: "transactions"
  alias DrivemeterApiWeb.TransactionView

  def fields do
    [:amount,:category,:description,:distance,:duration,:incurred_at]
  end

  def render("index.json", %{transactions: transactions, conn: conn}) do
    TransactionView.index(transactions, conn, conn.params)
  end

  def render("show.json", %{transaction: transaction, conn: conn}) do
    TransactionView.show(transaction, conn, conn.params)
  end
end

When I remove these two render methods above, I'm getting this error: no function clause matching in DrivemeterApiWeb.TransactionView.render/2

@gushonorato you appear to have found a bug. If possible could you try and reproduce this in a test and or fix the bug? If not I will take a look.

@jeregrine / @gushonorato I'm not 💯 this is a bug.  If you look at the code we generate it, it's looking for data: and you're relying on transaction.  Could you try changing that and see if you still need those methods?


Added OS X compatibility (and explanation)

It's still not a walk in the park but should be doable now.
Better would be to replace the commands within the script so these steps aren't needed.

If the script would use shasum -a 512 instead of sha512sum it would work just fine on both Linux and OS X.
If the script would try /usr/local/Cellar/gnu-getopt/*/bin/getopt before the regular getopt it would fix that symlink as well.

Instead of creating symlinks, how about a wrapper?
#!/bin/bash

function sha512sum {
    if [[ -e /usr/bin/sha512sum ]]; then
        echo "available"
    else
        echo "not available"
    fi
}

sha512sum

A wrapper would work too but I think using shasum -a ... might be a better solution
And I don't think dropping md5sum is needed, it's just that the sha+sum methods are missing, shasum and md5sum are usually available.

@WoLpH thanks for the feedback! I've pushed some more commits with fixes and new features. It would be nice if you can give it a test on your non linux systems. I hope everything works fine so far.
Just FYI with the new -f, --force option you can force to recreate a tag if you missed something minor in a short time after the release. You can also specify with commit/object to tag, as git tag also does.

I will close the PR, as 1.3.1 should address your problems. If you have any new problem, let me know. I will update the AUR package now.


New meshio convention

https://github.com/nschloe/meshio/issues/615
If the above suggestion is going to be implemented, we need to change the following lines:
https://github.com/GeoStat-Framework/ogs5py/blob/426115c217b428b2e1a4d0151fe3a80c2d5aaa4d/ogs5py/fileclasses/msh/msh_io.py#L775
This is just a pin.

With the release of meshio 4, this is now a serious issue.

Fixed by: https://github.com/GeoStat-Framework/ogs5py/commit/b701d252af7884010237a00e4da443bd73649976


Unable to export form field through API fields

Hi All,
I am trying to choose a created form through WagtailFormBlock() using ChoiceBlock and then export the selected form through API fields.
Code for ChoiceBlock is as below -
def getFormblockChoices():
choices = []
forms = Form.objects.all()
for form in forms:
choices.append((form.id, form.title))
return choices
class WagtailFormBlock(blocks.StructBlock):
# FORMBLOCK_CHOICES = getFormblockChoices()
form = blocks.ChoiceBlock(choices=getFormblockChoices, required=False)
form_action = blocks.CharBlock(
required=False,
help_text=(
'The form post action. "" or "." for the current page or a url'))
form_reference = InfoBlock(
required=False,
help_text=("This form will be given a unique reference once saved"), )
However, I am able to choose a form and publish the page but the fields are not visible through API.
Please let me know.

You can override the get_api_representation() method to get your fields. Here an example:
class StreamFormBlock(blocks.StructBlock):
form = WagtailFormBlock()
def get_api_representation(self, value, context=None):
    value_dict = dict(value)
    form = model_to_dict(value_dict['form']['form'])
    fields = form['fields']

    return {
        'id': form['id'],
        'title': form['title'],
        'slug': form['slug'],
        'submit_button_text': form['submit_button_text'],
        'success_message': form['success_message'],
        'error_message': form['error_message'],
        'process_form_submission_hooks': ['save_form_submission_data'],
        'form_action': f"/api/v2/streamforms/{form['id']}/",
        'form_reference': value_dict['form']['form_reference'],
        'fields': fields._raw_data,
    }

class Meta:
    icon = "form"
    label = _("Stream Form")


Add option to launch server using HTTPS

I like to run my dev servers w/ HTTPS.  That way I get warnings if anyone hard codes an HTTP url and allows remote demos, etc. without worrying about what data is transmitted.
Please let me know if this works for you.

Wow– I'm impressed that adding HTTPS support is this straightforward!
The design goal for elm-spa server was to create an elm reactor-like server for spinning up projects. The server command is an easy way to get a new projects up-and-running with zero configuration.
My hesitation on merging this feature is that it will start to overlap with tools like elm-live, which are well-designed for more advanced dev server configuration.
If you'd like to get HTTPS support for your elm-spa projects, I recommend using elm-spa watch with a more configurable dev server, as shown in the vite example. These more advanced dev servers provide support for environment variables, NPM packages, and other things you'll likely need for a real-world single page application.
All that being said: I recognize that you gave up your free time to help the project, and I genuinely appreciate it.
Thanks @rosensama, I hope the above explanation makes sense! ❤


Improve GitHub actions

Some small improvements, since my other pull request  #177 was already a bit older.

Update dependencies of Github Actions
Fix outdated build status picture
Fix typo in readme

Thanks @Rotzbua!


Adding a custom view to a node

Hello,
Is there a way to add a custom view to a node instead of a label?
Thanks

@bakhtiyork
is there any way to add an image to a node?


Site isn't mobile friendly

The meta tags for making site mobile friendly doesn't included

Fixed


Qt 6.3 support

Please add Qt 6.3 support. At the moment attempt to install 6.3.0 results in the following:
Specified Qt version is unknown: 6.3.0.
Specified target combination is not valid or unknown: windows desktop win64_mingw81
Some of specified modules are unknown.

Qt 6.3.0 is already fully supported.
That's not a valid architecture for 6.3.0; try using aqt list-qt for valid architectures. Perhaps you're looking for win64_mingw?


how to save mimetype in db

Hi, there's a way to save in db the mimetypes of the files I'm uploading?
like 'root' or 'dir' ther's an option to declare mimetypes ?
Thanks

No, it's not supported in the plugin. You'd have to extend the behaviour with your own class and implement this. Perhaps in the beforeSave method.


PoC: use of Redis as backend, drop relational database

Description
I forked the repo (https://github.com/maxux/pogom) and replaced (easier) the sql backend with a proof-of-concept with Redis backend.
I actually run this code and I test it, if someone else is interrested by this, it's a way to show it.
Why Redis ?
Redis is a in-memory data structure store. Using Redis dramatically reduce ressource usage and make the pogom query/response lot faster than the SQL version. To make it works, just install redis-server locally and run the version in my fork with your configuration.
I use the expiration key feature of redis to keep only current pokemon visible and save the stats in another hash.
My actual tests runs on 2x 1km radius and I hit about ~2% cpu usage with 30 users simultaneously connected to the website.
Everything is not yet fully ported, but if some guys can test it, it would be nice.

What is the memory footprint like?  I know a lot of people like to use Raspberry Pis, so memory is a concern.

Currently, with 6500 pokemons found (in stats) during the night, the database use 1.46 MB of memory. After couple of days, the memory size can explode on small devices, definitely.
Some rethought need to be done about how to save the stats to avoid to explode the database size. But for a PoC right now, it's pretty acceptable I think.

How to store those when the server goes down?  I have had to shut mine down to let the soft bans clear.

You can dump the database with SAVE command


Using for Sign in with Apple verify token

Seems this package can be used token verification in Sign in with Apple.
how do I use it exactly? How do i get the secret and compare with "sub"?
When will this package be upgraded to support Swift 5 and Xcode 11?
Thanks
Ashish

Swift 5 and XCode 11 support would be great! 👍


Release 1.1.2

What does this PR do

Prepares release 1.1.2

Task
See milestone 1.1.1

Warnings

:warning:
The library files were changed, but the tests remained unmodified.
Consider updating or adding to the tests to match the library changes.

  Generated by :no_entry_sign: Danger Swift against aa70e3f3c40d66039aedd1aaba8e8bdf118ae929


exit queue introspection

The test adds two exit queues:
16:44:55.122 [info]  ETH exit queue missing. Adding...
16:44:57.149 [info]  ERC20 exit queue missing. Adding...
after which I immidiately call: getNextExit(uint256,address)
data =
ABI.encode("getNextExit(uint256,address)", [Itest.PlasmaFramework.vault_id(Currency.ether()), Currency.ether()])
{:ok, result} = Ethereumex.HttpClient.eth_call(%{to: Itest.PlasmaFramework.address(), data: Encoding.to_hex(data)})

case Encoding.to_binary(result) do
  "" ->
    :queue_not_added

  result ->
    next_exit_id = hd(ABI.TypeDecoder.decode(result, [{:uint, 256}]))
    next_exit_id &&& (1 <<< 160) - 1
end

result is consistently a binary (on a clique geth node): <<8, 195, 121, 160, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 32, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 14, 81, 117, 101, 117, 101,   32, 105, 115, 32, 101, 109, 112, 116, 121, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,   0, 0, 0, 0, 0, 0>>
which is decoded to<PHONE_NUMBER>197344453575983046348115674221700746820753546331534351508065746944 and the biwtise operation turns it into:
next_exit_id &&& (1 <<< 160) - 1
0
looking at the plasma contracts code... that's not what it's supposed to happen:
https://github.com/omgnetwork/plasma-contracts/blob/ba662a978bf0158a1ca4e86fa707213531224193/plasma_framework/contracts/src/framework/ExitGameController.sol#L234-L237
https://github.com/omgnetwork/plasma-contracts/blob/655a792436194f43fb06d0e1f501fbff055501a9/plasma_framework/contracts/src/framework/utils/PriorityQueue.sol#L76-L79
So on ethhash node the transaction is reversed with this:
require(queue.currentSize > 0, "Queue is empty");
The question is... why do contracts behave differently on different eth nodes?

ehhh....can you elaborate the test setup a bit more (cabbage test? and not the Geth snapshot?)
And you're saying even when there is nothing in the exit queue, it somehow still returns a result when you're calling getNextExit?

found some references:

https://github.com/ethereum/solidity/issues/4840
https://github.com/ethereum/web3.js/issues/1903

would adding sth like this in ethereumx help? https://github.com/ethereum/web3.js/pull/3248/files

Seems like Geth actually fixed the issue:

https://github.com/ethereum/go-ethereum/issues/19027
https://github.com/ethereum/go-ethereum/pull/21083

Probably check the release and update the Geth


Update Python-lsp-server to version 1.5.0

python-lsp-server version 1.5.0

[x] Check the upstream
https://github.com/python-lsp/python-lsp-server/tree/v1.5.0

[x] Check the pinnings

pluggy>=1.0.0
https://github.com/python-lsp/python-lsp-server/blob/v1.5.0/pyproject.toml#L18
setuptools>=39.0.0
https://github.com/python-lsp/python-lsp-server/blob/v1.5.0/pyproject.toml#L20

[x] Check the changelogs
https://github.com/python-lsp/python-lsp-server/blob/v1.5.0/CHANGELOG.md

The changes mentioned were bug fixes and new features.

[x] Additional research
https://github.com/conda-forge/python-lsp-server-feedstock/issues

There is only one open issue at the time of the review. It is a request to simplify the optional dependencies needed. This should not affect our ability to build the package.

[x] Verify the dev_url
https://github.com/python-lsp/python-lsp-server

[x] Verify the doc_url
https://github.com/python-lsp/python-lsp-server/blob/develop/README.md

[x] License is spdx compliant

[x] License family is present

[x] Verify that the build_number is correct

[x] Verify if the package needs setuptools

[x] Verify if the package needs wheel

[x] pip in the test section

[x] Veriy the test section

[x] Verify if the package is architecture specific or Noarch

[x] Private variables are not mentioned on the recipe For example: (_private_variable)

Results:
Based on the research findings and the results we can conclude
that it is safe to update python-lsp-server to version 1.5.0

whatthepatch is missing as a runtime dependency.

added whatthepatch as a dependency
https://github.com/AnacondaRecipes/python-lsp-server-feedstock/blob/d4289ed4722d5f28454d7529c5cd15128d7c3f70/recipe/meta.yaml#L43

@varlackc python-lsp-black v1.2.1 is waiting for python-lsp-server v1.5.0 https://github.com/AnacondaRecipes/python-lsp-black-feedstock/pull/1

whatthepatch is missing as a runtime dependency.

Whatthepatch was added as a run time dependency
https://github.com/AnacondaRecipes/python-lsp-server-feedstock/blob/69e81a93eb04fc78fc3f1ab0e9b2ada97f94ab33/recipe/meta.yaml#L43


problem - the character doesn't say anything

Traceback (most recent call last):
File "/content/text-generation-webui/modules/callbacks.py", line 56, in gentask
ret = self.mfunc(callback=_callback, *args, **self.kwargs)
File "/content/text-generation-webui/modules/text_generation.py", line 311, in generate_with_callback
shared.model.generate(**kwargs)
File "/usr/local/lib/python3.10/dist-packages/auto_gptq/modeling/_base.py", line 443, in generate
return self.model.generate(**kwargs)
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py", line 1642, in generate
return self.sample(
File "/usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py", line 2724, in sample
outputs = self(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/modeling_llama.py", line 809, in forward
outputs = self.model(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/modeling_llama.py", line 697, in forward
layer_outputs = decoder_layer(
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/modeling_llama.py", line 426, in forward
hidden_states = self.mlp(hidden_states)
File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/modeling_llama.py", line 210, in forward
[F.linear(x, gate_proj_slices[i]) for i in range(self.config.pretraining_tp)], dim=-1
File "/usr/local/lib/python3.10/dist-packages/transformers/models/llama/modeling_llama.py", line 210, in
[F.linear(x, gate_proj_slices[i]) for i in range(self.config.pretraining_tp)], dim=-1
RuntimeError: mat1 and mat2 shapes cannot be multiplied (1848x5120 and 13824x640)
Output generated in 4.45 seconds (0.00 tokens/s, 0 tokens, context 1848, seed<PHONE_NUMBER>)

which colab?

which colab?
redmond-puffin-13b-GPTQ-4bit.ipynb

same i have this problem on others colabs

fixed thanks ❤

redmond fixed thanks ❤

YO THANKS ITS WORKING!


Upper part of long characters (f, l) missing a few pixels using small font sizes

Which operating system does the issue occur on? Mac OS 10.12.6, Macbook Pro Retina 13inch, late 2013.
Using certain font sizes a few pixels of the top of long letters are missing. I've only seen this happen with quite small font sizes, which isn't a problem on my 13 inch screen (since they don't need to be small) but is a problem when using a bigger screen.
This is happening while using the "IBM Plex" font. Possibly a bug of IBM Plex and not alacritty? I've tried adjusting the x-offset which isn't helping.
Correct F

Wrong F (look very closely)

Alacritty.conf: https://pastebin.com/7TsE5QwC
On a side note: what is the correct way to define the font to use for certain styles? I can't seem to get it to work.

There have been a lot of changes to the computation of font metrics since this issue has been created. As a result I'm closing it since it should be resolved with the latest master.
If this issue is still present, please let me know and I'll re-open it.


[BUG] Error during PDF creation during OspreyFit outside GUI

Describe the bug
When running the OspreyFit function from the terminal with the 'savePDF` flag set the following errors result when figures are being created:
Error 1
Reference to non-existent field 'diff1'.

Error in osp_plotModule (line 333)
                        ' ppm\nNumber of metabolites: '
                        num2str(MRSCont.fit.resBasisSet.(which){1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMets)
                        '; Number of macro moclecules: '
                        num2str(MRSCont.fit.resBasisSet.(which){1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMM)
                        ...

Error in osp_plotAllPDF (line 86)
                    osp_plotModule(MRSCont, 'OspreyFit', kk, Names{ss});

Error in OspreyFit (line 215)
    osp_plotAllPDF(MRSCont, 'OspreyFit')

Modifying the relevant line (333) in ops_plotModule.m from
' ppm\nNumber of metabolites: ' num2str(MRSCont.fit.resBasisSet.(which){1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMets) '; Number of macro moclecules: ' num2str(MRSCont.fit.resBasisSet.(which){1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMM) ...

to
 ' ppm\nNumber of metabolites: ' num2str(MRSCont.fit.resBasisSet.conc{1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMets) '; Number of macro moclecules: ' num2str(MRSCont.fit.resBasisSet.conc{1,MRSCont.info.A.unique_ndatapoint_indsort(kk)}.nMM) ...

appears to resolve the issue and I think retains the intended function.
Error 2
Not enough input arguments.

Error in osp_plotFit (line 56)
            figTitle = sprintf([fitMethod ' ' fitStyle ' ' conc ' fit plot:\n' filen
            ext]);

Error in osp_plotModule (line 419)
            temp = osp_plotFit(MRSCont, kk,Style,which);

Error in osp_plotAllPDF (line 86)
                    osp_plotModule(MRSCont, 'OspreyFit', kk, Names{ss});

Error in OspreyFit (line 215)
    osp_plotAllPDF(MRSCont, 'OspreyFit')

Modifying the relevant line in osp_plotFit.m from
figTitle = sprintf([fitMethod ' ' fitStyle ' ' conc ' fit plot:\n' filen ext]);

to
figTitle = sprintf([fitMethod ' ' fitStyle ]);

resolves the issue. It's not clear if any functionality is lost.
Computer configuration (please complete the following information):

OS: Ubuntu 18.04
MATLAB version: 2020b

Hi!
Thanks for pointing out this issue. We have fixed it in #245.
Apparently this bug is related to the 'Concatenated' fit style for edited data only. I'd advise you to not use the 'Concatenated' fitting, as it appears to be unreliable in its current implementation. Therefore, we did not test the plot outcome of this model recently.
Best,
Helge

That's useful to know, thank you.
Niall