[FLINK-31162][yarn] Use currUsr.getCredentials.getTokens instead of currUsr.getTokens

... to avoid including private tokens in AM container context

What is the purpose of the change
Avoid setting private tokens to AM container context when kerberos delegation token fetch is disabled and DTs are managed.
Brief change log
Currently while setting user credentials to the AM container context, ugi.getTokens() is used which also returns the private tokens along with UGI tokens. But it should not be passed to the AM container context. This causes the launch of YARN RM app to fail in some cases for example when Consistent Reads from HDFS Observer NameNode feature is enabled.
Instead, change it to ugi.getCredentials().getAllTokens() to only get user credentials tokens. Spark uses similar way of setting the user credentials to AM container context as well.
Verifying this change
Tested this changed internally in our environment as this requires a managed way of Delegation token fetch. Also tested enabling kerberos delegation token fetch feature to make sure it doesn't regress.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Please take a look. cc @gaborgsomogyi @MartijnVisser @becketqin

Re title: You mean 'Use currUsr.getCredentials().getAllTokens() instead of currUsr.getTokens() to avoid including private tokens' ?

Re title: You mean 'Use currUsr.getCredentials().getAllTokens() instead of currUsr.getTokens() to avoid including private tokens' ?

Oh. Yes. Thanks for pointing out.

Change looks good to me. Not sure how testable this is ...

Yeah not sure how we can add either unit tests or integration tests.

@venkata91 This PR should first be targeted towards master before creating backports.

@venkata91 This PR should first be targeted towards master before creating backports.

The issue here is different and is only specific to 1.16 and the code in master has changed quite a lot.
Since we also discussed about https://issues.apache.org/jira/browse/FLINK-31109, I am working on that as well and would raise a PR with the fix targeted towards master.

The issue here is different and is only specific to 1.16

So this issue only occurs in 1.16 and not in 1.17 and later? Then we're good yes :)

The issue here is different and is only specific to 1.16

So this issue only occurs in 1.16 and not in 1.17 and later? Then we're good yes :)

There is some what a bigger issue in 1.17 which I am looking at as part of https://issues.apache.org/jira/browse/FLINK-31109 and address this smaller issue as well as part of it.


Feature: Implement unmanaged CNI for CLI based clusters

Implement the behavior for the SkipUpgrade Cilium flag on CLI based clusters (i.e. not FLC).
When creating a cluster without specifying SkipUpgrade the cluster should continue updating the embedded Cilium. When SkipUpgrade is true on create the system should install embedded Cilium but not upgrade it. If a user toggles on SkipUpgrade after creating the cluster we should no longer attempt to upgrade it.
Toggling off SkipUpgrade is disabled until we've explored the implications.

/approve

/lgtm

/override eks-anywhere-cli-attribution-presubmit eks-anywhere-e2e-presubmit eks-anywhere-mocks-presubmits
Quelling the retesting churn

/override eks-anywhere-presubmit


Error with Envoy Docker

Hi, I feel I'm almost there, but getting a weird error. I've updated all paths to the correct location on my Unraid install, however I can't figure out what to change for the Envoy install?
Any hints?
.env file:
NODE_TAG=3.0.1-2_1
NODE_NAME=https://concordium-explorer.nl
COMPOSE_PROJECT_NAME=mainnet
DOMAIN=mainnet.concordium.software
GENESIS_DATA_FILE=./genesis/mainnet-0.dat
NODE_IMAGE=bisgardo/concordium-node:3.0.1-2_1
NODE_DASHBOARD_IMAGE=bisgardo/concordium-node-dashboard:node-3.0.1-2_1

.yaml file:
version: '3.9'
services:
  node_oob_catchup:
    image: curlimages/curl:latest
    pull_policy: always
    user: root
    volumes:
    - data:/mnt/cache/appdata/ccdnode/data
    entrypoint:
    - /bin/sh
    - -c
    - |
      [ -f /mnt/cache/appdata/ccdnode/data/blocks.mdb ] ||
        curl -sSf https://catchup.${DOMAIN}/blocks_to_import.mdb -o /mnt/cache/appdata/ccdnode/data/blocks.mdb
  node:
    image: ${NODE_IMAGE}
    entrypoint: /concordium-node
    environment:
    - CONCORDIUM_NODE_DATA_DIR=/mnt/cache/appdata/ccdnode/data
    - CONCORDIUM_NODE_CONFIG_DIR=/mnt/cache/appdata/ccdnode/config
    - CONCORDIUM_NODE_CONSENSUS_IMPORT_BLOCKS_FROM=/mnt/cache/appdata/ccdnode/data/blocks.mdb
    - CONCORDIUM_NODE_CONSENSUS_GENESIS_DATA_FILE=/mnt/cache/appdata/ccdnode/genesis.dat
    - CONCORDIUM_NODE_CONNECTION_BOOTSTRAP_NODES=bootstrap.${DOMAIN}:8888
    - CONCORDIUM_NODE_RPC_SERVER_ADDR=<IP_ADDRESS>
    - CONCORDIUM_NODE_PROMETHEUS_SERVER=1
    - CONCORDIUM_NODE_PROMETHEUS_LISTEN_ADDRESSS=<IP_ADDRESS>
    # Defer container start until the init containers have completed successfully.
    # Note that no logs are emitted on stdout until all containers have started.
    # Also, this syntax requires Docker Compose v. 1.29+.
    depends_on:
      node_oob_catchup:
        condition: service_completed_successfully
    networks:
    - concordium
    ports:
    - "8888:8888"   # P2P
    - "10000:10000" # gRPC
    - "9090:9090"   # Prometheus (metrics)
    volumes:
    - ${GENESIS_DATA_FILE}:/mnt/cache/appdata/ccdnode/genesis.dat
    - data:/mnt/cache/appdata/ccdnode/data
    - config:/mnt/cache/appdata/ccdnode/config
    build:
      context: .
      args:
        tag: ${NODE_TAG}
  node-collector:
    image: ${NODE_IMAGE}
    entrypoint: /node-collector
    environment:
    - CONCORDIUM_NODE_COLLECTOR_URL=https://dashboard.${DOMAIN}/nodes/post
    - CONCORDIUM_NODE_COLLECTOR_GRPC_HOST=http://node:10000
    - CONCORDIUM_NODE_COLLECTOR_NODE_NAME=${NODE_NAME}
    depends_on:
    - node
    networks:
    - concordium
    restart: on-failure # service may time out before the node is operational
  node-dashboard-grpc-proxy:
    image: envoyproxy/envoy:v1.18-latest
    pull_policy: always
    entrypoint: /usr/local/bin/envoy --config-path /etc/envoy/envoy.yaml
    depends_on:
    - node
    networks:
    - concordium
    ports:
    - "9901:9901" # admin
    - "9999:9999" # proxy
    volumes:
    - ./node-dashboard/envoy.yaml:/etc/envoy/envoy.yaml:ro
  node-dashboard:
    image: ${NODE_DASHBOARD_IMAGE}
    depends_on:
    - node-dashboard-grpc-proxy
    networks:
    - concordium
    ports:
    - "8099:80" # web
    build:
      context: ./node-dashboard
      args:
        tag: main
volumes:
  data:
  config:
networks:
  concordium:

Error response from daemon: OCI runtime create failed: container_linux.go:367: starting container process caused:
process_linux.go:495: container init caused: rootfs_linux.go:60: mounting
 "/boot/config/plugins/compose.manager/projects/bisgardo/node-dashboard/envoy.yaml"
to rootfs at "/var/lib/docker/btrfs/subvolumes/a96c66fb08d1462628c64dc89188004102cf4c320738bd40abf457d5d1d6c1ae/etc/envoy/envoy.yaml"
caused: not a directory: unknown:
Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type```

I don't think this relates to your error, but to be clear, the paths that you changed are all inside the Docker containers. The host volumes data and config are managed by Docker (see docker volume ls and docker volume inspect <name> for details). If you want them to be mounted to specific host directories you need to change the left part of the volume entries to absolute or relative (prefixed with ./) paths.
But for your particular error, it looks like /boot/config/plugins/compose.manager/projects/bisgardo/node-dashboard/envoy.yaml is a directory. Did you accidentally create that somehow?
What exact command are you running and from what working directory? The config assumes that the file ./node-dashboard/envoy.yaml is available relative to that dir.

Thank you for your reply. I looked at the file structure and indeed that envoy.yaml directory is present (and created somehow by the command).
I’m using compose manager plugin on unraid to run this, not immediately clear what command is being run, will investigate (and try to change the paths as well).

I've updated all volumes to point to a local location.
I've run the following command in the folder /mnt/cache/appdata/ccdnode:
docker-compose --env-file mainnet.env --project-name=mainnet up,
where mainnet.nev:
NODE_NAME=https://concordium-explorer.nl
NODE_TAG=3.0.1-2_1
COMPOSE_PROJECT_NAME=mainnet
DOMAIN=mainnet.concordium.software
GENESIS_DATA_FILE=./genesis/mainnet-0.dat
NODE_IMAGE=bisgardo/concordium-node:3.0.1-2_1
NODE_DASHBOARD_IMAGE=bisgardo/concordium-node-dashboard:node-3.0.1-2_1

and docker-compose.yml:
version: '3.9'
services:
  node_oob_catchup:
    image: curlimages/curl:latest
    pull_policy: always
    user: root
    volumes:
    - /mnt/cache/appdata/ccdnode/data:/mnt/data
    entrypoint:
    - /bin/sh
    - -c
    - |
      [ -f /mnt/data/blocks.mdb ] ||
        curl -sSf https://catchup.${DOMAIN}/blocks_to_import.mdb -o /mnt/data/blocks.mdb
  node:
    image: ${NODE_IMAGE}
    entrypoint: /concordium-node
    environment:
    - CONCORDIUM_NODE_DATA_DIR=/mnt/data
    - CONCORDIUM_NODE_CONFIG_DIR=/mnt/config
    - CONCORDIUM_NODE_CONSENSUS_IMPORT_BLOCKS_FROM=/mnt/data/blocks.mdb
    - CONCORDIUM_NODE_CONSENSUS_GENESIS_DATA_FILE=/mnt/genesis.dat
    - CONCORDIUM_NODE_CONNECTION_BOOTSTRAP_NODES=bootstrap.${DOMAIN}:8888
    - CONCORDIUM_NODE_RPC_SERVER_ADDR=<IP_ADDRESS>
    - CONCORDIUM_NODE_PROMETHEUS_SERVER=1
    - CONCORDIUM_NODE_PROMETHEUS_LISTEN_ADDRESSS=<IP_ADDRESS>
    # Defer container start until the init containers have completed successfully.
    # Note that no logs are emitted on stdout until all containers have started.
    # Also, this syntax requires Docker Compose v. 1.29+.
    depends_on:
      node_oob_catchup:
        condition: service_completed_successfully
    networks:
    - concordium
    ports:
    - "8888:8888"   # P2P
    - "10000:10000" # gRPC
    - "9090:9090"   # Prometheus (metrics)
    volumes:
    - /mnt/cache/appdata/ccdnode/${GENESIS_DATA_FILE}:/mnt/genesis.dat
    - /mnt/cache/appdata/ccdnode/data:/mnt/data
    - /mnt/cache/appdata/ccdnode/config:/mnt/config
    build:
      context: .
      args:
        tag: ${NODE_TAG}
  node-collector:
    image: ${NODE_IMAGE}
    entrypoint: /node-collector
    environment:
    - CONCORDIUM_NODE_COLLECTOR_URL=https://dashboard.${DOMAIN}/nodes/post
    - CONCORDIUM_NODE_COLLECTOR_GRPC_HOST=http://node:10000
    - CONCORDIUM_NODE_COLLECTOR_NODE_NAME=${NODE_NAME}
    depends_on:
    - node
    networks:
    - concordium
    restart: on-failure # service may time out before the node is operational
  node-dashboard-grpc-proxy:
    image: envoyproxy/envoy:v1.18-latest
    pull_policy: always
    entrypoint: /usr/local/bin/envoy --config-path /etc/envoy/envoy.yaml
    depends_on:
    - node
    networks:
    - concordium
    ports:
    - "9901:9901" # admin
    - "9999:9999" # proxy
    volumes:
    - /mnt/cache/appdata/ccdnode/node-dashboard/envoy.yaml:/etc/envoy/envoy.yaml:ro
  node-dashboard:
    image: ${NODE_DASHBOARD_IMAGE}
    depends_on:
    - node-dashboard-grpc-proxy
    networks:
    - concordium
    ports:
    - "8099:80" # web
    build:
      context: ./node-dashboard
      args:
        tag: main
volumes:
  data:
  config:
networks:
  concordium:

This pulls all images, but then the following error occurs:
2 errors occurred:
	* unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /mnt/cache/appdata/ccdnode/node-dashboard/Dockerfile: no such file or directory
	* unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /mnt/cache/appdata/ccdnode/Dockerfile: no such file or directory

If I run the same docker-compose command again, these errors do not occur.
Note that I had to copy the envoy.yaml file manually to this location /mnt/cache/appdata/ccdnode/node-dashboard/envoy.yaml, otherwise I would get the error mentioned above (dir vs file).
It seems the node is running (it's log says it's receiving blocks), but the other containers have stopped. I've started all containers again (except the catchup), and they keep running, but the node dashboard at port 8099 reports:
Failed polling node With error message: Http response at 400 or 500 level
Getting closer!

Addendum: the node-collector logs have the following entry:
INFO: Collecting node information via gRPC from https://concordium-explorer.nl/http://node:10000/rpcadmin
Can this be related to the node-dashboard reporting a 400/500 HTTP error?

Glad to hear :+1:
The project expects to be run from the root directory of your project or, more precisely, that all the files it needs are available in the specific paths relative to the current working directory. Instead of copying envoy.yaml you could just replace /mnt/cache/appdata/ccdnode/node-dashboard/envoy.yaml in the volume binding with it's actual location wherever it is.
The errors indicate that Compose tried to build the images but couldn't find the Dockerfiles for the same reason as above. Not sure why you didn't get the same error the second time. Did you somehow pull the public images in between and/or pass --no-build?
The node-collector logs indicate that the node is indeed up. Your node is also shown to be catching up correctly on the dashboard.
The node dashboard is a completely independent component that only depends on the Envoy and the node. I just tried it and it's up for me on http://localhost:8099. I think the node has to be completely caught up before it starts its gRPC server (which the node dashboard uses). It may also be because you're using out-of-band catchup (this is also the reason why you don't have any peers btw.). Not competely sure. Maybe there are hints in the Envoy logs.
In any case, try waiting until the node has caught up - this will take a while ;)

Restarted everything again after being bitten by having 2 nodes on the same external IP...but the good news is, it's working again, thanks!


Change PipelineCore namespace to Http.Core. Part-1.

#162
This is part 1 to break the namespace in the existing package and flush out who is depending on it. Part 2 will rename the package itself.
@muratg @davidfowl @Eilon

@davidfowl said :shipit: offline.


Support snapshot UI releases

Adds the ability to generate "snapshot" UI releases after pushing to branches prefixed with "snapshot/" to help with complex testing use cases.
Signed-off-by: Julie Pagano<EMAIL_ADDRESS>Notes for reviewers

I recommend starting with the RELEASE.md change to get some context from the docs before reviewing the code.
My bash is very rusty, so please let me know if any of that is ugly/suboptimal/etc.

Versioning
In our Monday discussion, we talked about using a release based on the most recent version instead of my suggested approach of using 0.0.0. I tried it out, but was concerned that it bumped the snapshots to the top of the versions list in the npm UI (see screenshot). I think this could be confusing to consumers of the project and might be misconstrued as prereleases.

Based on this, I think it would be safer to stick with the 0.0.0 versioning. It will keep the snapshots below latest (the actual version most consumers will want). That versioning also communicates that it's probably something internal to the project not for external consumption and is unlikely to be confused with prereleases. Project developers can look up information about the snapshot by going to the associated branch in github, which is included in the tag and version name.
Testing out the functionality
I created a simple test project that uses a barebones version of the scripts from perses, so I could safely play with this without breaking anything in the real perses project.

https://github.com/juliepagano/julie-test-changesets
https://www.npmjs.com/package/@julie-test-changesets/core?activeTab=versions
https://www.npmjs.com/package/@julie-test-changesets/components?activeTab=versions

Screenshots
Create branch named snapshot/test-refactor

Note the latest git sha is c66a944

Snapshot releases made to npm for packages with version that includes the branch name and the git sha and a tag that includes the branch name.

Push a new commit (d9cef4f) to snapshot/test-refactor

Note a new snapshot version was published to the same tag.

After deleting the branch in github, the tags will automatically be deleted from npm. The versions will still remain.

I did one final test on my test repo before merging this and found an edge case I hadn't hit before. The use of carets in the cross-linked internal dependencies (e.g. components depending on core) could lead to some unexpected snapshot versions being used because npm seems to sort versions reverse alphabetically for the text after the semver content (e.g. 0.0.0-zzzz will get used over 0.0.0-aaaa). I think I didn't hit this with my previous testing because of some luck with branch naming.
Based on talking with @LukeTillman  and @sjcobb, there's not a compelling reason why we're using carets for our internal dependencies, so I created https://github.com/perses/perses/pull/846 to adjust that (see more details in the PR). I thought it was good to introduce that change in a separate PR for clarity in the repo. I've also updated this PR to account for the changes.


Fix comment overflow and ensure content fits within div

Proposed Changes

Fixes #8699
Fixed the comment overflow issue in shifting and Resource to ensure content stays within the div

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

[X] Add specs that demonstrate bug / test a new feature.
[X] Update product documentation.
[x] Ensure that UI text is kept in I18n files.
[X] Prep screenshot or demo video for changelog entry, and attach it to issue.
[X] Request for Peer Reviews
[X] Completion of QA

LGTM


chore: fix file path ref in import statement

Description:
when a typescript project with sats-connect as a dependency is being built by tsc getting below error
node_modules/sats-connect/dist/capabilities/types.d.ts:1:33 - error TS2307: Cannot find module 'src/provider' or its corresponding type declarations.

1 import type { Capability } from 'src/provider';
                                  ~~~~~~~~~~~~~~

Found 1 error in node_modules/sats-connect/dist/capabilities/types.d.ts:1

Changes:

fix import statement file path format.

@yknl please review


release<EMAIL_ADDRESS>

0.1.0 - 2022-11-09
Added

Added BindingService.
Added BindingServiceImplementation.
Added ContainerModule.
Added ContainerModuleClassMetadata.
Added ContainerModuleFactoryMetadata.
Added ContainerModuleMetadata.
Added ContainerModuleMetadataType.
Added ContainerRequestService.
Added ContainerRequestServiceImplementation.
Added ContainerSingletonService.
Added ContainerSingletonServiceImplementation.
Added createInstance.
Added createInstanceFromBinding.
Added createInstancesByTag.
Added getBindingMetadata.
Added getBindingOrThrow.
Added getClassMetadata.
Added getDependencies.
Added loadContainerModule.
Added TaskContext.
Added TaskContextActions.
Added TaskContextServices.

Codecov Report

Merging #361 (0b861a5) into master (b4f4419) will increase coverage by 8.70%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #361      +/-   ##
===========================================
+ Coverage   91.29%   100.00%   +8.70%
===========================================
  Files          60        25      -35
  Lines         701       292     -409
  Branches      121        51      -70
===========================================
- Hits          640       292     -348
+ Misses         58         0      -58
+ Partials        3         0       -3

Flag
Coverage Δ

iocuak
?

iocuak-benchmark
?

iocuak-common
?

iocuak-core
100.00% <ø> (ø)

iocuak-decorators
?

iocuak-reflect-metadata-utils
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../services/api/ContainerServiceApiImplementation.ts

...etadata/utils/api/convertToClassElementMetadata.ts

...assMetadata/utils/api/convertToClassMetadataApi.ts

...rc/binding/utils/api/convertBindingToBindingApi.ts

packages/iocuak-common/src/utils/isPromiseLike.ts

...ors/src/classMetadata/decorators/injectFromBase.ts

...assMetadata/utils/api/isClassElementMetadataApi.ts

...ing/models/api/bindingScopeToBindingScopeApiMap.ts

...ges/iocuak/src/binding/utils/domain/bindToValue.ts

packages/iocuak-common/src/utils/mapIterable.ts

... and 25 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


How to handle no connection from the Token provider?

I have a React Native app running with @pusher/chatkit-client v1.2.2
When I run it locally in development and I have forgotten to start the Token provider server, I get this error:
Unhandled Promise Rejection

Shouldn't this code catch a connect() Promise rejection?
or do I need to something with the TokenProvider class contructor?
    const chatManager = new ChatManager({
      instanceLocator: config.PUSHER_INSTANCE,
      userId,
      tokenProvider: new TokenProvider({
        url: config.PUSHER_TOKEN_PROVIDER,
        headers: {
          token,
        },
      }),
      logger: {
        error: console.error,
        warn: console.log, // adding these console.logs do not catch it
        info: console.log,
        debug: console.log,
        verbose: console.log,
      },
      connectionTimeout: PUSHER_CONN_TIMEOUT,
    });
    chatManager
      .connect()
      .then(user => {
        console.log('Pusher: connected');
        resolve();
      })
      .catch(error => {
        reject(error);
      });

It certainly should, and that is a very unhelpful error to boot... 😬
Thanks for reporting, we'll look in to it.


Add 9.18.0 ruleset (based on EasyList version<PHONE_NUMBER>14) and update symlinks

9.18.0 is based on easylist version<PHONE_NUMBER>14. (Note that 9.17.0
was based on<PHONE_NUMBER>14.) The symlinks were invalid (had new
lines as part of the link) and latest/ was out of date. They should
now work and reflect the current state.

@jkarlin could you PTAL?

Can you add the easylist version<PHONE_NUMBER>14) to the name of the PR please? Thanks!

Should be done


added break

Signed-off-by: subhamkrai<EMAIL_ADDRESS>

Sounds real good, @subhamkrai. Closing out this PR in favor of #185


doc: update the merge requirement for tck

Description:
update the merge requirement for sdk tck
Related issue(s):
closes 235
Fixes #
#235
Notes for reviewer:

Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

@rwalworth I had to open a new PR. I closed the previous PR and reopen another. I followed the last instruction, but I noticed it reverted the changes back to the initial and the merge was now done automatic. It will be merged completed but it will be realized in the future, so I had to close the PR and reopen this.

@rwalworth I had to open a new PR. I closed the previous PR and reopen another. I followed the last instruction, but I noticed it reverted the changes back to the initial and the merge was now done automatic. It will be merged completed but it will be realized in the future, so I had to close the PR and reopen this.

It can be tricky to meet Github GPG and DCO requirements after the fact.  For a simple PR, in particular, this close-and-reopen-with-fixed-commit is often the easiest solution.


Base Info for this issue

Version：Latest Version as here
Language of App ：Objective-C
iOS System Version：iOS12
Prototype（是否是真机）：YES
Issue Type：Bug

1. How to reproduce the problem.

项目中使用FDFullscreenPopGesture，导致状态栏偏移和透明
2. Please help me in this way.

3. Here is a Demo.

4. Here is my Debug log

我也遇到这个问题


Remove pykde4

Motivation for this change
See also: #70102
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Please don't. I still use and maintain it. You may mark it as broken instead.

maintained yet broken? We can mark it as insecure, but really, it's a very old package. I think at this point you better use it from an older Nixpkgs version.

@FRidh Since there are no other known users of it... Actually @ttuegel made a patch for that CVE in #70102 that went into 19.03, why not merge it to master too? I would prefer to keep it since pykde5 is an old wip.

Actually @ttuegel made a patch for that CVE in #70102 that went into 19.03, why not merge it to master too?

@gnidorah I didn't make the patch, it comes from upstream. I cherry-picked the changes from release-19.03, marked you as maintainer of both packages, and disabled the Hydra build.


Force requiring properties

All required properties are now required for all actions by default
even if the action does not reference the property.
In order to only make the property required for a subset of the
actions, specify them as an array of symbols to the required
options on the property.
property :whatever, String, required: %i{start stop}

action :start do
end

action :stop do
end

action :enable do
end

action :disable do
end

That property will be required for start+stop but not for
enable+disable.
There's an unaddressed edge case here where if you reference the
property in an action which was not specified that it will also
fail validation.  That is correct behavior.  We should probably
dig into how to warn the user that they must either remove the
reference to the property from that action or else to add the
action to the list of required actions on the property.
Closes #4596

The API of required on certain actions is something people have asked for repeatedly. We need that internally to cleanup a lot of terrible code as well.


Use apk package for Eclipse Temurin instead of tarball or Official Eclipse Temurin Alpine Image

Stop using Eclipse Temurin tarball and instead use:

Official Eclipse Temurin packages for Alpine or
Official Eclipse Temurin Alpine image

Forgot that I changed to use apk before. Closing.


Add integration tests

It would be nice to merge https://github.com/Dania02525/apartmentex/pull/7 first and enable CircleCI first 😄
This commit adds end-to-end integration tests, which:
1.) Creates a tenant (new schema in postgres DB)
2.) Inserts/updates/deletes/reads tenant data
These tests will be very useful when upgrading the library to support newer versions of ecto and postgrex.
This commit also locks Ecto to 1.1.x and postgrex to 0.10.x, which should have been done as part of https://github.com/Dania02525/apartmentex/pull/5
Without locking these, mix could resolve the libraries to versions which are not compatible with the code changes made as part of https://github.com/Dania02525/apartmentex/pull/5

@Dania02525 anything I can do to help move this forward?


Update configure-data.md

Learn Build status updates of commit 793043b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerapps-docs/sample-apps/crisis-financial-impact-tracker/configure-data.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


⚠ pishem-otzivi has degraded performance

In 4d02f49, pishem-otzivi (https://пишем-отзывы.рф/) experienced degraded performance:

HTTP code: 200
Response time: 9709 ms

Resolved: pishem-otzivi performance has improved in 6adde79.


fix: handle multiple return values in promisified client

Description

the get_children2 and w_get_children2 methods of the promisified zookeeper client should return both an array of children and stats. The promisified version only returns the array.
Motivation and Context

This bug have most likely been existing for a long time and should be fixed ASAP, because of the new recommendation to use promises/async/await instead of callbacks.

Fixes issue #203
How Has This Been Tested?

Travis CI build OK.
npm test
node examples/index.js

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have read the code of conduct.
[x] I have read the contributing guide.
[x] I have updated the documentation accordingly (if applicable).

If possible, maybe @jbienkowski311 could have a look at this PR and give some feedback?

As promise can return only one value (same as JS function), therefore the only way to return multiple values is to use array/object. It is not a case when we use callbacks - callback can take many parameters, not just one. Take this snippet as an example:
function someFunc(callback) {
  callback('value1', {key: 'value2'});
}
// or
function someFuncPromise() {
  return Promise.resolve(['value1', {key: 'value2'}]);
}
const [value1, obj] = await someFuncPromise();

So, to sum up, the code looks alright, moreover I have used the code that was already provided by the old promise implementation. Have you confirmed that the promisified version returns incorrect values?

Thank you for feedback @jbienkowski311! I will verify the functionality of the old version, to make sure the API is the same.
If possible, I am thinking about a solution in the get_children function. Something like this:

return {children: res[0], stat: res[1] };```

If not, I'll go with the array solution.

The array solution is easier to implement and to consume IMHO, but the object solution is more OOP-like. I guess it's a matter of taste :wink:

Just verified that the old version is working fine and returns an array with [children, stats]. So, I'll stick to the array style of the API.


Analysis unittest gives wrong failure on 32-bit Linux

The fit results of a threshold scan are different on different Linux architectures and thus cannot be compared for exact similarity. The test_threshold_analysis test case fails therefore for no reason. The first observation was posted here.

This for example is the threshold of one pixel in PlsrDAC (S-Curve mu if fit):
32-bit: 25.440000000000001
64-bit: 25.439999999999998


records: api hardcodes localhost for schema field

The CommonFieldsMixin is defining a schema field that is hardcoded to locahost. This causes problem when a site hostname is defined other than localhost and the latter is not accessible.

I'm temporarily solving it by adding the following to the image Dockerfile:
COPY ./records_api.py /usr/local/lib/python3.8/site-packages/invenio_rdm_records/records/api.py
COPY ./vocabularies_api.py /usr/local/lib/python3.8/site-packages/invenio_vocabularies/records/api.py

And having, for example in records_api.py, something like the following:
import os
site_hostname = os.environ.get('INVENIO_SITE_HOSTNAME', 'localhost')

And:
    schema = ConstantField(
       '$schema', f'https://{site_hostname}/schemas/records/record-v1.0.0.json')

RFC for changes to Invenio-Records and Invenio-JSONSchemas that would solve this issue: https://codimd.web.cern.ch/x9wZmPRsQoO8SrZkl57PlQ


Upload multiple images from tweet to imgur album.

See for example this comment - original tweet has two images, but only first one was added.

Bump.  I'm seeing this too, and it's kinda annoying.


hands on azuread provider

Manage Azure Active Directory (Azure AD) users and groups

fixed by #18


[feature request] dust's iconic "long" location on map

New Map Location: Long
Summary
One of Dust's most popular parts is the A long, (my fav part as well).
I want to propose to add this part in the game.
reason: i am bored and i don't want to study :')
Details
At A long, the logic of the game could be to shoot enemies and not shoot allies,
although suggestions are welcome.
Additional Information
I'd like to work on this issue myself. if possible, the maintainers can later supervise the changes.
Checklist

[x] I have searched existing issues to ensure this is not a duplicate.
[x] I have provided clear and detailed information about the issue.
[x] I have included any necessary screenshots or files.

If its fine. Should I make these changes to my existing branch or wait for my already opened pr for issue #3 and #1 to close first?

@PythonicBoat  alright! thanks

Looks amazing ! you can change the position for the doors button so its all spaced out nicely :D


Incorrect warning message

When compiling a C++ source to produce a library, I get spurious warning:
cpp_set_stdlib is specified, but the Gnu compiler does not support this option, ignored

Here's my build.rs:
extern crate gcc;

fn main() {
    gcc::Config::new()
        .file("src/foo.cc")
        .cpp(true)
        .compile("libfoo.a");
}

and here's src/foo.cc:
int addone(int n) {
    return n + 1;
}

and here's Cargo.toml
[package]
name = "testgcc"
version = "0.1.0"
authors = [""]

build = "build.rs"

[dependencies]

[build-dependencies]
gcc = "0.3"

This warning does not show up when compiling C library source.
uname -a
Darwin myiMac.local 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64

c++ --version
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Closed in https://github.com/alexcrichton/gcc-rs/pull/132


Avoid commonly used layout name

Version Choicesdk-maps 0.2
I realise that an internal layout named fragment_map is used. Generally it is bad practise if an library internal layout is named in a very common way. Library caller can easily have to same layout name and this would cause runtime conflict, where the library would use the layout of the consumer instead of it's own.
I recommend to add at least a prefix to avoid naming conflicts, like choice_fragment_map.
See also this SO post.

Issue should be fixed with version 0.3.0.


On Win7 system, an exception is triggered with the message 'Could not locate Performance Counter with specified category name 'Processor Information', counter name '% Processor Performance'

Library version
11.1.0
OS & OS version
Win7 Sp1
Describe the bug

Thank you for noticing this, I will look into it!

Fixed in https://github.com/Jinjinov/Hardware.Info/releases/tag/v<IP_ADDRESS>


"Invariant Vilation:[8, { "type":"value","value":<>}] is not usables as a native method argument

Current behaviour
After seting up done , I'm geting error : "Invariant Vilation:[8, { "type":"value","value":<>}] is not usables as a native method argument
Expected behaviour
it should be run correctly without error...
Code sample
@withTheme
export default class TabChannel extends BaseScreen {

    state = {
        routes: [
            { key: 'first', title: 'First' },
            { key: 'second', title: 'Second' },
        ],
    }

    render() {
        return (
            <View>
                <TabView
                    navigationState={this.state}
                    renderScene={SceneMap({
                        first: FirstRoute,
                        second: SecondRoute,
                    })}
                    onIndexChange={index => this.setState({ index })}
                    initialLayout={{ width: dimensions.width }}
                />
            </View>

        );
    }
}

Screenshots (if applicable)

9-09-10 14-25-47.png…]()
Your Environment

software
version

android
27

react-native
0.59.1

react-native-tab-view
2.10.0

react-native-gesture-handler
^1.4.1

react-native-reanimated
^1.2.0

node
8.10.0

yarn
1.17.3

react-native-navigation
^3.1.2

state = {
        index: 0,
        routes: [
            { key: 'first', title: 'First' },
            { key: 'second', title: 'Second' },
        ],
    }

Had the same error, for me it was because I set a percentage value as width in initialLayout props, when I stick to the initial example it works: initialLayout={{width: '100%'}} -> initialLayout={{width: Dimensions.get('window').width}}

I am currently experiencing this error. Any solution as the one mentioned by @SimonPotier didn't work for me. I am actually using the example given.

@briantical make sure that you initialize index state with 0.

Still exists

I had the same problem and the following addition did the trick:
Example was:
navigationState={{ index, routes }}
Solution was:
navigationState={{ "index": tabIndex, routes }}
As @jordangrant correctly pointed out, there must be an index key in the navigation state. I don't know how the example is supposed to work?!


Role permissions matrix navigation

PublicKB/Accounts & Users/role-permissions-matrix.md
Scroll bar for role permissions matrix is at bottom of very long list.
When I first opened this matrix, I needed to see a column that was off to the right.
I scrolled to the bottom of the document to expose the scroll bar at the bottom to use my mouse to scroll to the right.  I lost track of the section that I was trying to verify when scrolling back up because the 1st column had scrolled off the screen, now it was just permissions with no context.

We should probably convert this matrix to a filter system of some kind by role & action group.

Move to JIRA for planning.


Simplify restoring all functions for a test

Currently for each spy or stub on an instance method, you need to manually call restore on them to restore the original function. The test code needs to be in a try block and the restore calls need to be in a finally block to ensure the instance methods are always restored before the tests exit.
My proposal is to add 3 new functions. I'm open to suggestions on better names for these functions. I think the function name mock might cause some confusion.

startMock: void

This creates a checkpoint to restore to. We would need to keep track of all the functions that are stubbed or mocked from the checkpoint on so that when restore is called, it can call restore on each of the mocks created after this function was called.

restore(): void

This would cleanup all mocks created since the last startMock call. This would make it possible to restore just the mocks in the test while leaving mocks created before the last startMock call in place.

mockFor(fn: () => void | Promise<void>):  () => void | Promise<void>

This function will just have a try/finally, where startMock is called, then the test callback funtion is called in a try block, then restore is called in a finally block. For all your test functions that have mocks, you could simply use mockFor to wrap them.

The mockFor function should be able to take an fn argument with generic arguments, return, and this type. Similar to how spy can when spying on functions. This would make it useful in more situations. Then fn should be called like fn.apply(this, args) so that this and args just pass right through.
I believe mockSession would be a better name than startMock. Then the restore function would restore all mocks created during the current mockSession. If a mock is created outside of a mock session, a new mock session should be created automatically so that calling restore will still restore any mocks created at that level. This would effectively make it so you never have to use mockSession if you just want to restore all mocks whenever restore is called.


Improve Accessibility and SEO Scores

Describe the enhancement
Improve the lighthouse scores for the accessibility and SEO of the website.

git fetch origin
git checkout 122-improve-accessibility-and-seo-scores


Spyder python freezes version 5.5.1

Whenever I try to use Spyder, it freezes with (not responding).

Hey @amitrajtopno, thanks for reporting. This can be a problem with your firewall and/or antivirus.
So, please disable them and try again.

Closing due to lack of response.


Move IterableResponse to appropriate package

IterableResponse is not related to HTTP/REST response type. It is located in the wrong package.

Pull request #4986 has the fix for this

Fixed by #5002


Avoid sync committee without proof in LightClientUpdate

Currently some of the light client tests include next_sync_committee
without a corresponding next_sync_committee_branch when the sync
committee is not changed by the update. This data is not useful for
a light client, as it cannot be validated without the merkle proof.
This patch ensures that the next_sync_committee member is also kept
empty in such cases.

Hmm, it would probably be cleaner to do the opposite and just always include the next_sync_committee instead of zeroing it out in certain conditions. Also makes it easier for the LightClientUpdate producer that does not usually know the current sync progress of the client.

Postponing this until the network protocols are specced out more concretely.


Update Inline Entity Form

Updates the Inline Entity Form, so that it is not locked into a specific version.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update Simplified Chinese Translation

I've updated a translation that was no longer working and fixed an inaccurate translation, so let me know if there are any problems, thanks!

I've updated a translation that was no longer working and fixed an inaccurate translation, thanks!

I've updated a translation that was no longer working and fixed an inaccurate translation, thanks!

Thanks


[BEAM-5978] Changing parallelism for wordcount to 1

Local execution environment sets the parallelism of the pipeline same as the number of cores on the machine. In my case, its 12. As we have 12 threads in SDKHarness, we get a deadlock on my machine.
Running on a cluster does not have this issue as the default parallelism there is 1.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Thanks. I will apply this parameter to batch only then.

Updated!

We could also fold this change into https://github.com/apache/beam/pull/7180
Unrelated to this change, note that currently wordcount doesn't work on macOS with the docker jobserver:
./gradlew :beam-sdks-python:portableWordCount
...
INFO:root:Using latest locally built Python SDK docker image.
docker: Error response from daemon: driver failed programming external connectivity on endpoint cranky_pasteur (f9b3843dada38679d655f258ca40af36b030b469f2abbd2277db199683018b53):  (iptables failed: iptables --wait -t nat -A DOCKER -p tcp -d 0/0 --dport 32817 -j DNAT --to-destination <IP_ADDRESS>:0 ! -i docker0: iptables v1.6.2: Port `0' not valid

Try `iptables -h' or 'iptables --help' for more information.
 (exit status 2)).

@mxm The underlying issue of flink and sdkHarness scheduling is still pending and requires more thought and discussion.
@tweise Mac wordcount should be working with https://github.com/apache/beam/pull/7178 Let me know if its otherwise.

Shall we merge this PR?

Go ahead :)

Updated the PR


Haskell support

I did not put much effort into getting your_git.sh to be in a maintainable state. It works that is where I stopped.
Haskell land is very gung-ho about nix (as an alternative to stack), so I added support where these can work simultaneously.

@sherubthakur what are the flake.nix & lock files used for? Can we remove them? If we add these, I think we'd want to do it across all challenges / languages, and make sure we have docs around it

@libmartinito could you look into why the haskell tests are failing here? @sherubthakur mentioned:

looks like the compile_and_test script just hangs
7:23
Tried it on local after cleaning up everything in docker and it is just stuck (from the looks of it)
7:25
On the other hand if I build it using docker build ./starter_templates/haskell -f ./dockerfiles/haskell-9.4.6.Dockerfileand re-run dc run tester scripts/compile_and_test.sh courses/build-your-own-git haskell it finishes up immediately (both commands)

@sherubthakur if you've got the time to debug/fix these, feel free too - else we'll get to it sometime in the future. Haskell support isn't something we're actively prioritizing at the moment, but that will change someday


Inconsistent names in EditPreferencesDlg

Reported by Peter Csala in code review.

findDefaultFolderLocationExecute: this does not follow your snake casing naming
Once again the naming of your variables are inconsistent
findDefaultFolderLocationExecute's fbd vs findTenantRosterExcelFile's FindTenantRoster

Reported by Peter Csala in code review.

And here comes my favourite control name: EP_RentRosterSheetName_LISTBOX
Please try to consolidate your variables names as well (ExcelFile vs sheetNames)


[TT-727] Update Linea Confirmation Type

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a915f62) 31.07% compared to head (63d7400) 31.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   31.07%   31.07%
=======================================
  Files          41       41
  Lines        5352     5352
=======================================
  Hits         1663     1663
  Misses       3510     3510
  Partials      179      179

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Problem with build - CSC : error CS8785: Generator 'RazorSourceGenerator' failed to generate source.

PS C:\Users\adamk\source\repos\eShop\src\WebAppComponents> dotnet build
MSBuild version 17.8.3+195e7f5a3 for .NET
Determining projects to restore...
All projects are up-to-date for restore.
CSC : error CS8785: Generator 'RazorSourceGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FormatException' with message 'T
he input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.'. [C:\Users\adamk\source\repos\eShop\src\WebAppComp
onents\WebAppComponents.csproj]
Build FAILED.
CSC : error CS8785: Generator 'RazorSourceGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FormatException' with message 'T
he input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters.'. [C:\Users\adamk\source\repos\eShop\src\WebAppComp
onents\WebAppComponents.csproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.01

@GrtlinG0 Thanks for reporting this issue!
Our CI builds are passing here so I assume that this issue is related to specific edits or configuration on your machine. @dotnet/razor-compiler in case this exception looks familiar or can be handled better.

Do you have a repro for this that we could look at?

From the exception I would guess this is an editorconfig issue. Certain things are base64 encoded to survive round tripping. I'll bet something there is getting encoded wrong and we're blowing up trying to decode it.
If we can't get a full repro then the \obj\Debug\net8.0\WebAppComponents.GeneratedMSBuildEditorConfig.editorconfig should be able to give us the relevant information.

Closing this issue since this is tracked in https://github.com/dotnet/razor/issues/9629


Support parameter ($1) type inference for LIKE predicates

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We are trying to run a query like this:
SELECT ... WHERE col LIKE $1

However the type inference logic in https://github.com/apache/arrow-datafusion/blob/0f6931caa6f8b48e116a8e77e989c404f31f3f8d/datafusion/sql/src/expr/mod.rs#L503
only handles = predicates
cc  @avantgardnerio
Describe the solution you'd like
I would like the type inference logic to handle LIKE, NOT LIKE, ILIKE and NOT ILIKE
Describe alternatives you've considered

Additional context
Found while implementing FlightSQL (via parameterized queries) in IOx: https://github.com/influxdata/influxdb_iox/pull/7213

I found a workaround that works for https://github.com/influxdata/influxdb_iox/pull/7213

What is the outcome of the SQL query SELECT ... WHERE col LIKE $1? 🤔


Docs:  Cluster Management

We need to write the documents for cluster management, and I highly recommend you to have a looking at the following codes.

The HTTP endpoints of cluster management can be found at here, which may help write documents.
Join / Remove implementations
Currently, we still don't support the management cluster via gRPC. It will be implemented later.

Hi @WenyXu ,
I'm a beginner at contributing to this repo and would like to try adding the documentation. Please tell me if this needs to be added to the Readme or in some other docs.
The Readme contains the HTTP endpoints of cluster management, but not the Join/ Remove implementations.


[Question] How i can make the autocompletion of the preview video?

In the video, when a autocomplete option is selected the text appears in the file with a gray color:
https://user-images.githubusercontent.com/629908/139000570-3ac39587-a88b-43c6-b35e-207489719359.mp4
Also, how can i make nvim-cmp automatically put the closing parenthesis/quote when i put the opening one?
Sorry if this is a dumb question or if you dont understand, im new in neovim and english is not my native language.

Hello,
I was wondering this myself and found the answer you should add this to your lua file to get that gray color text (ghost text)
cmp.setup {
  ...
  experimental = {
    ghost_text = true
  }
  ...
}


UTF-8 eof cause truncation of html.

Jsoup.parse(String html) function parse html as utf-8, if a character like xefxbfxbf(utf-8, in unicode as \uffff just EOF) in html, Jsoup will think reading the end of html, but exactly not reading to the end of html. For example: class="msgCnt">xEFxBFxBF什么是子女？就是您一天暴打八回也不让别人辱骂一句的人。什么是老婆？就是您八天不想亲一次也不让别人亲一下的人。xEFxBFxBF什么是老公？就是您八月不让碰一次也不许他在外胡搞的人。xEFxBFxBF什么是朋友？就是您一天联系八次也不嫌烦的人！xEFxBFxBF什么是好友？就是您一天收一短信开心一笑也不用回复的人。
this is a problem, I think when parse String, Jsoup can't treat EOF as the end of html, Jsoup should offer a option for use other character replacing xEFxBFxBF, as  web browser use other character replacing xEFxBFxBF.

(Closing out old, dormant bugs. If you are still impacted by this, please reopen & vote.)

May be it would be better to cover it with test before closing?


adding nodejs devops script

Hi Brady/Sachin,
I have pushed the nodejs devops script. Let me know for any changes if any.
Thanks,
Srivatsa

@SrivatsaMarichi,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


Set up PgHero to monitor Postgres performance

PgHero provides a performance dashboard as well as some recommendations and monitoring for Postgres databases. An instance should be added to the k8s cluster to monitor the current queries and make sure all bottlenecks get adressed appropriately.

Tasks

[x] Configure required Postgres extensions, permissions and tables
[x] Set up PgHero instance and secure it
[x] ~Add scheduled PgHero tasks for historical data~

At the moment, CronJobs can only be created in a kubernetes cluster with alpha features enabled, which automatically gets deleted after 30 days in GCP. Due to this, PgHero is currently running without the historical data added.


Update README: link all bash code as code snippets

Purpose
Import code in the README dynamically to avoid updating duplicate code when making changes.
Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

To test this pull request read the README file using this URL:
https://github.com/Azure-Samples/aks-multi-cluster-service-mesh/tree/import-scripts-markdown/istio


Support max batch size

Description of problem
Our application has a search bar that allows a user to search for items on our site. On click the search bar, relay grabs all data for the items that is searchable. When they select an item they are routed to a page that shows all items but the item that they clicked is focused (modal).
The problem is that because we are requesting more data on these items on this page, relay issues a node query for the missing data for each item (315 node queries). relay-network-layer correctly batches these together into one request but i get a 'payload too large' error (413).
Is there a way to specify a batch size so that i can avoid this issue?

HTTP 413 Request Entity Too Large
The server may reject your request in different places:

Nginx, apache, load-balancer. Solution for nginx http://www.daveperrett.com/articles/2009/11/18/nginx-error-413-request-entity-too-large/
express-graphql middleware. It has 100kb limit for body (source). And this problem was discussed here and was declined. I think, that this hard coded limit should be changeable. Developers may have different scenarios when a request is too big (bulk loading, raw base64 file).

RRNL does not have the batch size option. It should be done somehow here https://github.com/nodkz/react-relay-network-layer/blob/master/src/relay/queriesBatch.js
PR welcome. Sorry, I have no free time to do it myself 😔

So, if so many problems: on server-side, on client with batching (413) and without batching (too many requests). Anyway 315 times clien, network and server generate/transmit/parse quite huge queries - wasted work.
So:

Try to fetch data for search with all required data for displaying in list+modal.
Or rewrite modal without using fragments connected your components tree. Fetch required data for modals manually like here https://github.com/nodkz/relay-northwind-app/blob/master/app/components/orders/ToggleOrder.js#L29-L44. And rerender component when data will be retrieved for one modal. Also may be useful such wrapper  https://gist.github.com/nodkz/03f28aaa1b66195b517ecf06e92487bf#gistcomment-2023207

@nodkz Thanks for such a detailed response and all the solutions you've suggested. I think i might take a stab at doing the batch size but until then i'll implement the primeCache call you've suggested. Really appreciate it. 👍


Expand meaning of allocatedBy beyond identifiers

Current definition: Connection between an ID and the thing that minted the ID.  It may be a person or organization, or could be an algorithm (next available or random number generator)
Range: gist:IntellectualProperty or gist:Organization or gist:Person
This could be extended to degrees, certificates, other things that can be issued. In fact "issuedBy" might be a better term.

See also #94 and #339


Extend student class

Add new files specific to students. The keyword for the edit command has been changed to the editStudent command

EditStudentCommand
EditStudentDescriptor
EditStudentCommandParser
EditStudentDescriptorBuilder
EditStudentCommandTest
EditStudentCommandParserTest

In addition, EditStudentDescriptor has been moved out of the EditStudentCommand and made into it's own class.

Codecov Report

Merging #49 (a91c2a8) into master (00024bf) will decrease coverage by 0.08%.
The diff coverage is 88.59%.

:exclamation: Current head a91c2a8 differs from pull request most recent head 38c1942. Consider uploading reports for the commit 38c1942 to get more accurate results

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
- Coverage     73.53%   73.45%   -0.09%
- Complexity      445      488      +43
============================================
  Files            75       78       +3
  Lines          1383     1405      +22
  Branches        152      152
============================================
+ Hits           1017     1032      +15
- Misses          321      323       +2
- Partials         45       50       +5

Impacted Files
Coverage Δ

...a/seedu/address/logic/commands/StudentCommand.java
100.00% <ø> (ø)

...c/main/java/seedu/address/model/person/Person.java
87.50% <ø> (ø)

...java/seedu/address/logic/commands/EditCommand.java
77.77% <50.00%> (-16.85%)
:arrow_down:

...address/logic/parser/EditStudentCommandParser.java
94.59% <75.00%> (ø)

.../main/java/seedu/address/model/person/Student.java
91.30% <75.00%> (-2.45%)
:arrow_down:

...ic/commands/descriptors/EditStudentDescriptor.java
88.46% <88.46%> (ø)

...gic/commands/descriptors/EditPersonDescriptor.java
90.00% <90.00%> (ø)

...edu/address/logic/commands/EditStudentCommand.java
93.93% <93.93%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00024bf...38c1942. Read the comment docs.


Replace long-lived tokens with short-lived OTP tokens

User account creation verifies email addresses with a token that is valid for 24 hours. This is also used in "forgot password": a user gets a 24-hour valid token by email in the form of a link.
Instead of that, this PR provides a 6-digit one-time-password that is used to verify an email address or allows to change a password.

First impressions look good to me. Do you also plan to make frontend changes in this PR? We can also do that in another PR.

I'd like to do this, won't take too much time, can do it in this PR but if you want to organize things differently let me know. I just read your comment after I submitted some frontend work. Let me know if you are OK with this PR.

Let me know when I can start the review (by removing the draft mode label). Ideally with all checks on green.


docs: refactor the first half of modAL.models

Autoconversion of docstrings with pyment doesn't work well, because the initial format was not following a strict standard.  So there are a lot of manual corrections. I have chosen Google style for docstring, however conversion from it to NumPy style with pyment could be easier.
The first half of modAL.models looks good, but there may be some improvements (further deduplication) in coming days. Review and comments on committed parts could help to finish the whole refactoring (I hope, by the weekend).

Thanks, awesome! I'll review the commit ASAP.

I have reviewed the changes and made a few commits myself. Shall I push them to the corresponding branch in your fork or do you prefer for me to push the commits to a new feature branch here?
Aside from some minor changes, something happened in the models.py file which caused some trouble with the BaseCommittee, Committee, CommitteeRegressor classes to be indented one level further. I have fixed this and now the code passes all tests.

Oh... Haven't notice these indents, and Travis didn't show test result for PR... It is better if you commit directly to my fork. You should have write access to the branch, but anyway I add you as a collaborator.

Codecov Report

Merging #23 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev      #23      +/-   ##
==========================================
+ Coverage   97.44%   97.45%   +<.01%
==========================================
  Files          26       26
  Lines        1333     1337       +4
==========================================
+ Hits         1299     1303       +4
  Misses         34       34

Impacted Files
Coverage Δ

modAL/models.py
91.97% <100%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1aa878...1dd8bb8. Read the comment docs.

I have pushed the commits. In addition to some minor changes like fixing headers and broken links, I have removed the link to Ranked-batch-queries.rst for now. The page is not written yet.
Also, I have realized that replacing all pages with Jupyter notebooks is a good idea, so thanks for suggesting to use notebooks in the docs! I believe it would make the documentation more accessible and interactive.

I'll review the changes hopefully today, merge them to the master branch and make a new release during the weekend. Thank you for your work! The documentation and the website is much better than it was before!

Actually, I haven't finished with docstrings yet... I will try to do that tomorrow (in the next pull request)... Hope to finish before the release :)

Yeah, I was too fast :) I'll wait for you, no need to rush with the new release.


Bash hash problems upon removal / installation

Problem 1
When removing packages (brew rm <formula(e)>), information about them can still be in Bash's hash preventing users from executing corresponding commands that might be provided by the underlying operating system or other packages.
Example:
hash -d git # or simply do that in a newly opened shell
brew install git
git
hash -t git
# output: /usr/local/bin/git
brew remove git
git
# output: -bash: /usr/local/bin/git: No such file or directory

The problem is caused by Bash's algorithm that remembers used paths and tries to use them:
hash -t git
# output: /usr/local/bin/git

Feature request: before removing the package, for every executable in a bin directory execute
hash -d <executable> if hash points to the binary being removed.
Problem 2
When installing new apps, their usage can be hindered due to path hashing done by Bash.
Example:
type -a git
# output: git is /usr/bin/git  ## no Homebrew'd git
hash -t git
# output: /usr/bin/git
git --version
# output: git version 2.17.1 (Apple Git-112)
brew install git
git --version
# output: git version 2.17.1 (Apple Git-112)

Feature request: after installing the package, for every executable in a bin directory execute
hash -d <executable> if hash does NOT point to the newly installed binary. This way we will allow PATH to come into play and decide the right executable to be called.
This should be relevant to 100% of Homebrew users.
Alternatives: run hash -d <executable> or hash -r manually. The latter command is easier to remember but removes ALL remembered (hashed) paths. Proposed mechanism could provide a more targeted solution than hash -r.

@maxim-belkin Come on, fill in the issue template, you really know better by now.

😕
I did!

Detailed descriptions and motivations are there.
Assessment of relevance to Homebrew users is there.
Alternatives are listed.

This might be quite difficult to do, since it would require running hash in the parent bash shell that called the brew command, not the subshell that is executing brew. The hash state is internal to each bash process.

Agreed. But some sort of a recommendation or a reminder could be issued, right?

This might be quite difficult to do, since it would require running hash in the parent bash shell that called the brew command, not the subshell that is executing brew. The hash state is internal to each bash process.

I think given this it's worth passing on, sorry @maxim-belkin.

I did!

I would like to apologise @maxim-belkin for my comment earlier; it wasn't polite or kind.


Create m_analytic_patches in pre_process/ for initial condition edge cases

In situations where the analytic features (thanks to #176) built into the input.py files are not sufficient to represent a case, due to weird geometries (or whatever), we can have a separate module that accommodates these. It could be called m_analytic_patches, for example. This is an alternative to having many hard-coded cases living in s_analytic_patch_2D even when #176 is available.

closed by #201 and #188


Code Generation - Simplify completion pattern

We can remove the use of an isInstanceOf clause and instead use a typed pattern

yeah I remember I spent quite some time to make this work like this but annoyingly didn't manage to. it looks like it fails in the GenBCode phase. happy to help you debug it if you need to see the tree that fails etc. it would be nice if we manage to do it.

An update on this work: yesterday @gregorath and I started looking at the trees generated by the compiler phases. We found the problem to be in the pattern-matcher. Before this phase, the body . However, within the pattern matcher the variable x$0 is renamed to a fresh variable x1, but only in the pattern itself, not in the body of the first case.

An update on this work: yesterday @gregorath and I started looking at the trees generated by the compiler phases. We found the problem to be in the pattern-matcher. Before this phase, the body . However, within the pattern matcher the variable x$0 is renamed to a fresh variable x1, but only in the pattern itself, not in the body of the first case.

It seems that by adding an extra wrapper of a Bind, with the Typed on the right hand side, it now works fine and recognises as a variable (waiting for CI)


Update to support .NET 4.5

Is there any chance you could just update the target framework to 4.5 and recompile/release. We use this and on windows 10 machines it's asking us to download and install .net 3.5

I don't want to release without testing, and I don't have Windows 10 to test on right now, or the time to do it. So you're probably better off just getting the source code and compiling a new version yourself, since I don't know when I can get to this.
Also, it sounds strange that it's asking you to download .NET 3.5, I thought newer .net version should always be able to run older assemblies?

As long as it's tested on 4.5 it will work, I just get the prompt saying 3.5 is not installed click here to install

To any who see this,
I have created a fork of InsertIcons which has a simple to use GUI that runs on the latest .NET Framework (4.6.1 as of the time this was written) and is available here: https://github.com/ntegrl/XInject
Hopefully this will help out anyone in need of injecting icons into their assemblies and I also wish to thank Einar for his original contribution.

@einaregilsson any chance we can get an updated official release? I'm going to recompile it myself for now.

@niemyjski Still don't have a Windows machine, although I have a virtual machine somewhere. I'll try to get to it in the next couple of weeks, but no promises.


🚀 Massively speed up fetching of image dimensions

no issue
Fetching images across the network to get their dimensions is really slow. In the previous implementation we were fetching the entire image before using it to determine the image dimensions. However, for most images we don't need all of the data! Image dimensions can usually be determined from the headers or other information that is stored near the beginning of an image file, we should take advantage of that to massively speed up our dimension calculations and save a lot of network bandwidth.
In addition to partially fetching files, this PR also addresses the sequential nature of the DOM traversal and associated network requests. By pulling img tag handling out of the traversal we're able to run those tasks in parallel as a preliminary parsing step - this results in much better utilisation of the available network capacity for another big performance increase.

use probe-image-size to fetch only enough of an image that is needed to get the dimensions
fall back to image-size for formats which probe-image-size doesn't support
replace got with request so we're not including two different request libraries
use request-promise wrapper library to simplify the code (uses bluebird under the hood which is the same as the async library that we're using
move img tag handling out of the sequential traversal loop

use domutils to pull out an array of img elements for processing
create an async task for processing each img element
use async.parallelLimit to process 10 img tasks at a time

As an example of the speedup offered, here are my tests which were using this library inside Ghost. The test page had 10 reasonably sized external images and the reported time is the initial amperization before caching.
image-size only:
INFO amp.parse http://ghost.blog/2019/06/08/test/ 52278ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 52717ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 50582ms

average: 51,859ms

probe-image-size w/ image-size fallback:
INFO amp.parse http://ghost.blog/2019/06/08/test/ 11147ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 12297ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 11188ms

average: 11,544ms
speedup: ~4.5x

parallel image fetch before traversal:
INFO amp.parse http://ghost.blog/2019/06/08/test/ 1629ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 1744ms
INFO amp.parse http://ghost.blog/2019/06/08/test/ 1398ms

average: 1,590ms
speedup: ~7.2x

Result: ~32.5x faster 🚀

Coverage decreased (-4.3%) to 95.69% when pulling 5890a496ddaae21a869839f1ff6a8e0da2777c81 on kevinansfield:probe-image-size into 99064b8e01189d6c414171947b4adb3899f280aa on jbhannah:master.

This is an amazing improvement!!! 🚀

@kevinansfield please submit a release PR, so we can publish the new speedy version.


Suspicious implementation of UCB formula in MCTS algorithm

Hi All
Firstly, thanks for this fantastic repo!
Looking at the python/algorithms/mcts.py function SearchNode.child_value it seems UCB is implemented as follows:
return (
        self.player_sign * child.total_reward / child.explore_count +
        uct_c * math.sqrt(math.log(child.explore_count) / child.explore_count))

In the usual UCB formula (wiki or link) the second term contains log(parentN) / childN, while above is log(childN)/childN.
I tested both formulas on different implementation of MCTS and both work, but log(childN)/childN seems to degrade performance.
There seems to be equivalent issue in C++ version in mcts.cc
Is this a potential bug, or am I missing something?

Thanks for reporting! Yes, I agree this is an error; we will fix it.


[2.0] Upgrade PHPUnit

This PR moves the 2.0 codebase onto PHPUnit 5.7/6, using the new namespaced classes, so we will be more future-proof.

I also took the liberty of fixing a few PSR-4 violations in the tests.
The build is green, this is no longer WIP, requesting reviews! :tada:

@nokitakaze that could be done on merge, easily from the web interface.

Seems fine for me too, I will let you squash and merge 😃


Exposing control of shadow light

Use case
I would like to avoid the animation connected to a device orientation change. Instead, I am locking the app to one preferred orientation and detect orientation changes using the accelerometer. Then, only the necessary widgets are rotated as necessary.
Now, I have the little aesthetic problem that Material shadows are cast in a way that is connected to the current device orientation: They always point downwards.

However, if the orientation is locked to one side and I rotate the screen by 180°, my widgets rotate as wanted, but the shadows are now pointing upwards instead of downwards.

Now, I would like to adjust the position of the light to change the shadow for all widgets and avoid having to implement custom shadows for every widget. However, as far as my research brought me, is the position of the shadow light hardcoded in this line of code.
Proposal
I would like Flutter to give control over the light that is casting the shadows. Maybe, an interface like this could be possible:
SystemChrome.setShadowLight(lightPos, lightRadius);

Another idea for the interface would be to introduce a widget (animated or not) that sets the shadow light parameters for its child's widget tree. I think, I would prefer this over an asynchronous SystemChrome call, because it would allow selective application and easier animation.
One question would be, in which coordinate system the position of the light should be defined.
Using such a widget might look like this:
AnimatedShadowLight(
  position: Vector3(0, -1, 1),
  radius: 0.2,
  child: MyApp(),
)


USPS Expected Delivery Date

Im getting some strange results with the USPS Expected Delivery Date, even tho the packages are more expensive the date stays the same. Also I havent found a way to remove certain service types by USPS, I currently do so like this:
shipment.Rates.Where(r => r.Name != "USPS Library Mail Parcel" &&
r.Name != "USPS Media Mail Parcel" &&
!r.Name.Contains("Hold For Pickup")
).OrderBy(s => s.TotalCharges).ToArray();

Never mind, I found the API documentation and added support to add a ShipDate to the request, this then returns a CommitmentDate to be used as the expected delivery date.
Documentation
https://www.usps.com/business/web-tools-apis/rate-calculator-api.htm

@MichaelQuint glad you got it figured out. this something I should consider adding to core? if so do you mind putting together a pull request? thanks,
kyle

Im not really sure how to do that, but here is my changes. very small.
USPSProvider.cs.txt

merged this in. thanks @MichaelQuint !


[BUG] Timed Out error whenever I'm trying to send a broadcast message

it works perfectly well for private message but get error on broadcast
Error sending message Error: Timed Out
at /Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Utils/generics.js:145:32 {
data: {
stack: 'Error\n' +
'    at promiseTimeout (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Utils/generics.js:140:19)\n' +
'    at waitForMessage (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/socket.js:119:53)\n' +
'    at query (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/socket.js:141:22)\n' +
'    at groupQuery (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/groups.js:12:55)\n' +
'    at groupMetadata (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/groups.js:22:30)\n' +
'    at /Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/messages-send.js:323:47\n' +
'    at /Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/messages-send.js:326:23\n' +
'    at Object.transaction (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Utils/auth-utils.js:136:32)\n' +
'    at relayMessage (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/messages-send.js:306:30)\n' +
'    at Object.sendMessage (/Users/ganiuadelekeaderibigbe/Desktop/projects/Personal/bwb/node_modules/@whiskeysockets/baileys/lib/Socket/messages-send.js:664:23)'
},
isBoom: true,
isServer: false,
output: {
statusCode: 408,
payload: {
statusCode: 408,
error: 'Request Time-out',
message: 'Timed Out'
},
headers: {}
}
}
Here is my implementation:
try {
await sendMessageWTyping(
{ text: "Hello there!" },
msg.key.remoteJid!
);
await sock.sendMessage(
msg.key.remoteJid!,
{
image: {
url: "src/assets/IMG_3184.jpeg",
},
caption: Hello ${msg.pushName}\nCheck this out! :D,
},
{
quoted: msg,
}
);
await sock.sendMessage(
jid,
{
image: {
url: "src/assets/IMG_3184.jpeg",
},
caption: Hello ${msg.pushName},
},
{
statusJidList,
broadcast: true,
}
);
console.log("Story message sent");
} catch (err) {
console.error("Error sending message", err);
}
the first to sendMessage functions work perfectly but the third one doesn't, it was working before I don't know why it stopped working

I also have the same error.

try this fix https://github.com/WhiskeySockets/Baileys/pull/986

Thank you @devlikepro i'll try this now


Cannot build mruby(1.2.0) test and cannot run mruby on Windows.

Cannot build mruby(1.2.0 and current master) test and cannot run mruby on Windows.
I tried this (named build_run.rb),
VCVAR_PATH = 'C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat'
MINIRAKE = '.\minirake'

unless Dir.exists? "build_tmp/mruby"
  system "git clone https://github.com/mruby/mruby.git build_tmp/mruby"
end
Dir.chdir 'build_tmp/mruby'
if ARGV[0] == "master"
  system "git fetch"
  system "git checkout origin/master"
else
  system "git checkout refs/tags/1.2.0"
end
cmd = "cmd /c \"call \"#{VCVAR_PATH.gsub("\\", "\\\\")}\" x86 & ruby #{MINIRAKE.gsub("\\", "\\\\")} -v\""
puts "-> #{cmd}"
STDOUT.flush
system cmd

system "bin/mruby -e \"puts 'test'\""

Dir.chdir '../..'

and got followings.
$ ruby build_run.rb
HEAD is now at 22464fe... mruby-1.2.0
-> cmd /c "call "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86 & ruby .\minirake -v"
mkdir -p C:/work/dycoon_labo/experimentals/mruby_tests/windows_build/build_tmp/mruby/bin
libmruby.lib(gem_init.obj) : error LNK2019: unresolved external symbol _mrb_mruby_test_gem_init referenced in function _GENERATED_TMP_mrb_mruby_test_gem_init
libmruby.lib(gem_init.obj) : error LNK2019: unresolved external symbol _mrb_mruby_test_gem_final referenced in function _GENERATED_TMP_mrb_mruby_test_gem_final
C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\bin\mirb.exe : fatal error LNK1120: 2 unresolved externals
libmruby.lib(gem_init.obj) : error LNK2019: unresolved external symbol _mrb_mruby_test_gem_init referenced in function _GENERATED_TMP_mrb_mruby_test_gem_init
libmruby.lib(gem_init.obj) : error LNK2019: unresolved external symbol _mrb_mruby_test_gem_final referenced in function _GENERATED_TMP_mrb_mruby_test_gem_final
C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\bin\mirb.exe : fatal error LNK1120: 2 unresolved externals
(in C:/work/dycoon_labo/experimentals/mruby_tests/windows_build/build_tmp/mruby)
"link.exe" /NOLOGO /DEBUG /INCREMENTAL:NO /OPT:ICF /OPT:REF /OUT:"C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\bin\mirb.exe" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\mrbgems\mruby-bin-mirb\tools\mirb\mirb.obj" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\lib\libmruby.lib"
link.exe /NOLOGO /DEBUG /INCREMENTAL:NO /OPT:ICF /OPT:REF /OUT:"C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\bin\mirb.exe" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\mrbgems\mruby-bin-mirb\tools\mirb\mirb.obj" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\lib\libmruby.lib"
rake aborted!
Command Failed: [link.exe /NOLOGO /DEBUG /INCREMENTAL:NO /OPT:ICF /OPT:REF /OUT:"C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\bin\mirb.exe" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\mrbgems\mruby-bin-mirb\tools\mirb\mirb.obj" "C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\build\test\lib\libmruby.lib"   ]
rakefile:70:in `block (4 levels) in <top (required)>'
trace:
        [0] C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\mrbgems\mruby-math\\test\math.rb:18
C:\work\dycoon_labo\experimentals\mruby_tests\windows_build\build_tmp\mruby\mrbgems\mruby-math\\test\math.rb:18: undefined method 'assert' for main (NoMethodError)

I'm using.
Microsoft Visual Studio Community 2013
Version 12.0.31101.00 Update 4

Windows 8.1

Also, it doesn't seems to work on MinGW.
It seems to work on Linux.

Sorry.
This problem is caused by CRuby for windows.
I used this version.
$ ruby --version
ruby 2.2.0p0 (2014-12-25 revision 49005) [x64-mswin64_100]

I upgrade to Ruby 2.2.3 of
http://rubyinstaller.org/downloads/
This problem is solved.


plotting tests

Is there a reason that the test for the interpolation routines are in the src folder as opposed to the test folder?

I see. I agree that tests for the plotting scripts are low priority. Having these stubs floating around in the src directory may be more confusing than helpful though, so I recommend we simply remove them for now.


reproduce issue where stackoverflow happens in unstash

see #1327
This doesn't cause the test to fail or abort - for some reason testkit/scalatest logs the stackoverflow but then claims no tests were run.
Uncaught error from thread [EventSourcedStashOverflowSpec-pekko.actor.default-dispatcher-9]: null, shutting down JVM since 'pekko.jvm-exit-on-fatal-error' is enabled for ActorSystem[EventSourcedStashOverflowSpec]
java.lang.StackOverflowError
	at org.apache.pekko.actor.typed.internal.StashBufferImpl.unstash(StashBufferImpl.scala:206)

[info] Run completed in 3 seconds, 635 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[info] No tests to run for persistence-typed-tests / Test / testOnly

Without this PR change, the test runs and succeeded: 1 is logged.

I have a possible solution but it is breaking quite a few tests so it needs more debugging. It is only one approach but by passing back a behavior wrapping the unstash instead of running the unstash in place - this avoids stack overflow issues.
The broken tests show that it is not quite this simple and it may prove to the dead end.

I have a possible solution but it is breaking quite a few tests so it needs more debugging. It is only one approach but by passing back a behavior wrapping the unstash instead of running the unstash in place - this avoids stack overflow issues. The broken tests show that it is not quite this simple and it may prove to be a dead end.

This 'solution' isn't working out.


Array serializers don't handle null resource

In Scope class there is method for serializing resource object serializeResource:
protected function serializeResource(SerializerAbstract $serializer, $data)
{
    $resourceKey = $this->resource->getResourceKey();

    if ($this->resource instanceof Collection) {
        return $serializer->collection($resourceKey, $data);
    }

    if ($this->resource instanceof Item) {
        return $serializer->item($resourceKey, $data);
    }

    return $serializer->null();
}

As you can see, if resource is not Item nor Collection, serialiazer calls null() method, which is implemented only in JsonApiSerializer class.
In order to fix that, I've created PR - https://github.com/thephpleague/fractal/pull/277

+1 for this

This has been merged in now!

Why would null be serialized as an empty array, and not, you know, null?

@andrewtweber because it is array serializer? Imo, serializer should return always the same type of data.

An empty array, from a JSON/JavaScript perspective, seems to imply that it is a collection to me. Which is misleading if that object is usually a single item and not a collection.
Ideally there should be two methods, $this->nullItem() and $this->nullCollection()
Anyways I can just extend the ArraySerializer so I don't feel too strongly about it, I just think it's a flaw of the serializers in general.

@andrewtweber Hi Andrew, I hope you don't mind me asking, how would you extend ArraySerializer to return null? I'm at my wits end trying to figure this out. Thank


CloudQuery Source Plugin?

Hi Team, hopefully this is right place to ask, if not, I'd appreciate if you can direct me.
I'm the founder of cloudquery.io, a high performance open source ELT framework.
Our users are interested in a MongoDB Atlas plugin, but as we cannot maintain all the plugins ourselves, I was curious if this would be an interesting collaboration, where we would help implement an initial source plugin, and you will help maintain it.
This will give your users the ability to sync MongoDB Atlas APIs to any of their datalakes/data-warehouses/databases easily using any of the growing list of CQ destination plugins (We already support MongoDB destination, which is quite popular destination for ELT workloads and hence the request for the Atlas connector).
Best,
Yevgeny

hi @yevgenypats great to meet you! Happy to learn more and explore ways we can collaborate together on this for our joint-customers. Feel free to drop me an email and we can better coordinate (zuhair.ahmed@mongodb.com). Can find time to sync this Friday on zoom or later next week if that works on your end as well.

@yevgenypats Thank you for reaching out. As this is a nonsoftware related request I'm closing the issue.


Gopass not pushing all keys to remote

Summary
Not all keys seem to be pushed to the remote gitlab repo.
I have used gopass for a few years now on only one machine.
Since, after editing or creating a new key gopass always pushes changes to git, I always thought that the git repo is always up to date.
Recently, I cloned this key store from another computer gopass clone <repourl>.
After running gopass sync and looking into the keys I noticed that like 50% of keys were missing and there were some keys which I actually deleted long ago.
Then I started browsing the actual repo on gitlab and noticed that it's the same situation on the remote.
I went back to my first machine and did gopass sync which then says:
Sync starting ...
[<root>]
   git pull and push ... OK (no changes)
   importing missing keys ... OK
   exporting missing keys ... nothing to do
   done
All done

Does anyone have an idea what the problem could be?
Edit
I tried adding a new key on machine 1, then sync machine 2, and delete it on machine 2, then sync on machine 1:
Sync starting ...
[<root>]
   git pull and push ... OK (Removed 1 entries)
   importing missing keys ... OK
   exporting missing keys ... nothing to do
   done
All done

So, this worked as expected.
But somehow there is this a 50% mismatch of keys on machine 1 and the remote.
gopass sync doesnt seem to see this mismatch.
Environment
On my first machine:

OS: Ubuntu 20.04.2 LTS
gopass Version: gopass 1.9.2+e2d1549f452a0df1fc52e42e7d0f654334d7144e (e2d1549f452a0df1fc52e42e7d0f654334d7144e) go1.14.2 linux amd64
Installation method: via gopass_1.9.2_linux_amd64.deb

Edit 2
I just went into the .password-store on machine 1 and did git status.
There are many untracked files and unstaged changes.

Can I just manually add . and commit or will gopass be confused then?
Shouldn't gopass sync see these changes?

One thing you might want to check is whether the passwords stored in these
untracked files are correct or not.
Did you have any merge conflicts when pushing these untracked files? If so,
then some passwords might have been overwritten by wrong ones...
If not, then indeed everything should work.


How can I see Document folder in actionsheet ?

icloud files are working pretty good , though as I am using react-native-fetch-blob which integrates fs system already, I am doing pretty good with it. however, i see only icloud option in actionsheet , how can I access/add DocumentDir  into that actionsheet ?

Same question here.

Anyone figure this out?

Same question here. I wanna pick a local pdf to then upload it with RNFS, how can I do it?

How is this not answered?
Makes the library useless imo.


Fix the grammer mistake on Code of Conduct page

In the Reference of #256
fix the mistake

Thanks for making these changes, but we will not be merging this. See the comment on the related issue.


doctrine/dbal after vendor:publish

Hi when i install this package. And run php artisan vendor:publish
i get this one

Can u document this is the readme?

Hotfix is created and running in travis. Thanks for the hint!
To fix it now and yourself simply require doctrine/dbal with composer:
composer require doctrine/dbal

i did that. But i thought it was user unfriendly to not fix this one or not document this one.

Like I said - the hotfix is pushed and PR is open - but it's in travis now. If it passes I will merge it and create a hotfix tag.

PR is now merged and taged with <IP_ADDRESS>

Thx for the quick fix


My slide

my new changes is come out

created a branch, created a file and made a commit, and opened a pull request


Submission by Touami

Hadamard Test plus Minigame

Congrats for wining the qBraid Qiskit Fall Fest Algiers @Touami-M loved the game where you applied the Hadamard test for rolling dice. Would be great to see various unitaries to be used in the circuit including the CNOT you used to make an "unfair" dice. In fact, what would be really cool would be to have the outcome of the dice decided by several unitaries player 1 and play 2 add together but they don't know what gates the other player is adding! The goal of the game would be to make the dice fall more favorably for yourself and perhaps include a second dice.
👍 💯 🥇

Thank you so much @rryoung98 ! The idea for the game actually came to me at the very last second, to be honest the toughest part was making the two Hadamard tests, I found myself struggling to find courses about quantum states and their implementations with Qiskit (being a beginner also didn't help). Thanks as well for the suggestions to the game, I will definitely try to implement them when I get to it, I think it's going to be really cool when it's done.


--list-extensions "installed" category filter doesn't work

#78106

Should just show everything?

Installed is not a valid category if you do code-insiders --list-extensions --category without specifying a category it will list out all the valid categories. I also have pushed a change which should be in todays insiders to tell you if you specify a valid category. Valid categories are the ones that you can search with in the extension viewless when doing @category:.


Add a new table option under "Resolv and Host Files", Advance DNSMa…

…sq Configuration. (this will enable additional configuration of dnsmasq)

Check if dnsmasq.conf exist in /etc/dnsmasq.conf, otherwise the section "Advance DNSMasq Configuration" will not appear.
Directly modifies the dnsmasq.conf file.
restart's the dnsmasq service

@nivranaitsirhc Some Questions:

Why did you not sign your work ?
Why implement to "old" BB 14.07 branch and not to "master" branch ?
Why not extending language template for creating translations ?
Why not creating a totally separated tab like "System->Software->Configuration"

@chris5560 Good day sir.

I forgot the signing part..

I need to support this branch first because most of my stable builds are from this branch and the later if it gets accepted.

I did not really considered the translation part, that was out of my attention.

For the purpose putting it at the best place possible for simplicity and and easy orientation.
I chose that tab because all of the DNSMasq and dhcp configuration is all there. although I think I should have put it in the "Advance Settings" taboption Under "DHCP and DNS" > Server Settings.

My intention is to implement an access to dnsmasq.conf file. for an optional advance full usage of the DNSMasq for the features that cannot be accessed by the web interface.

@nivranaitsirhc
If updating old branches, it is not compiled into the builds on the download servers.
Old Branches are releases possibly with fixes but without extensions.
So best place is the master branch (trunk) to offer new extensions (because everybody knows it might have bugs).
I general I think it's a helpful extension.
If using a separate tab there is more space to edit and it's separate from UCI settings.
Language template updates are useful for everybody who want to help translating into other languages.
Christian

@chris5560
I see. thank you for the tips and clarification.
I will work on your suggestion but I'm still not really familiar with the inner workings of LuCI. If someone can better implement than me. Then that would be much better i guess.
For the mean time guess I have to locally implement it in my local build.
Christian Arvin


Not downloading more than 100 files content in a directory

Expected Behavior
Download All files in the directory via download/sync to local command
Actual Behavior
It creates all the files, but only first 100 files have content and rest all files are blank everytime. It throws Below error on rest of all files. we can still open blank file and click download it fetches that file.
[debug]:
------
target: /path1/file2.txt
context: transmission file
error: Error: Failure
	at SFTPStream._transform (C:\Users\*\.vscode\extensions\liximomo.sftp-1.0.3\node_modules\ssh2-streams\lib\sftp.js:405:27)
	at SFTPStream.Transform._read (_stream_transform.js:167:10)
	at SFTPStream._read (C:\Users\*\.vscode\extensions\liximomo.sftp-1.0.3\node_modules\ssh2-streams\lib\sftp.js:181:15)
	at SFTPStream.Transform._write (_stream_transform.js:155:12)
	at doWrite (_stream_writable.js:329:12)
	at writeOrBuffer (_stream_writable.js:315:5)
	at SFTPStream.Writable.write (_stream_writable.js:241:11)
	at Channel.ondata (_stream_readable.js:557:20)
	at emitOne (events.js:96:13)
	at Channel.emit (events.js:191:7)
------

Steps to Reproduce the Problem

sftp connection with interactiveAuth
download/sync to local directory with more than 100 files

I am not sure if it has anything to do with server configuration or not.
If sftp has some configuration that at max 100 or some configurable download are allowed, how to configure extension to do so.
I do not have permission to change any setting in ftp server. It has strict checks like interactiveAuth only etc.
Requisites (important to diagnose the problem!)
Extension Logs
[debug]: task: download c:\Users\*\Desktop\*\Dir1
[debug]: transmission file /path1/file1.txt at Tue Feb 06 2018 13:51:13 GMT+0530 (India Standard Time)
[debug]: transmission file /path1/file2.txt at Tue Feb 06 2018 13:51:13 GMT+0530 (India Standard Time)

 ---- 98 more such successful transmission  and below error for rest of all files ---

------
[debug]:
------
target: /path1/file101.txt
context: transmission file
error: Error: Failure
	at SFTPStream._transform (C:\Users\*\.vscode\extensions\liximomo.sftp-1.0.3\node_modules\ssh2-streams\lib\sftp.js:405:27)
	at SFTPStream.Transform._read (_stream_transform.js:167:10)
	at SFTPStream._read (C:\Users\*\.vscode\extensions\liximomo.sftp-1.0.3\node_modules\ssh2-streams\lib\sftp.js:181:15)
	at SFTPStream.Transform._write (_stream_transform.js:155:12)
	at doWrite (_stream_writable.js:329:12)
	at writeOrBuffer (_stream_writable.js:315:5)
	at SFTPStream.Writable.write (_stream_writable.js:241:11)
	at Channel.ondata (_stream_readable.js:557:20)
	at emitOne (events.js:96:13)
	at Channel.emit (events.js:191:7)

Specifications

Extension Version: 1.0.3 - 2018-02-05
Platform: Windows 10 , VSCODE 1.19.3

I'm going to need some more information:

OpenSSH sftp server debug output with -l DEBUG3

Sorry i don't have access to server log files.
is there any configuration like  max concurrent connection or something ?
Do you know how to request file one after another if i don't care about performance?
i am trying to understand code but never worked on ts and promises so could not update it.
if you know let me know, i can test and report back.
Real problem here is once you do sync to local, it gets content of only 100 files by any chance you had noticed and updated any file, tried to sync to remote it will upload rest all files empty making all other files in server getting empty. and could result in data loss if you have missed status of error for few seconds.
i suggestion, to prevent this, if you get error while file transfer it should delete that file in local copy so it does not cause data loss on sync to remote

Please try debug-pacakge. Set concurrency: 99 in config file see if it can solve your problem.

Works Like a Charm. I set it at 20 to be on safe side.
Add this to feature list 👍
Thanks a lot @liximomo
Issue #61 may be the same.
You can ask them to confirm.

V1.0.4 has been published.


Expose Agent Hyperparameters

For example, PID settings for UAV.
This should be fairly easy. Something like giving HolodeckAgent some "settings buffer", and have the child class define the size. Then, index into that buffer in C++ for each variable, setting the default values. Then connect to this buffer with Python and somewhere define what each index in the buffer corresponds to.
That's just an initial idea, if you can think of a better way, we can do it that way.

Added in command center update to develop branch.


Fix rename dialog too large

Fixes https://github.com/godotengine/godot/issues/35008

popup_centered now takes p_minsize which is does the same behaviour as done in this pull request. See 4758057f205a7d2e0d2db2c034705b7afcdf310f