[KYUUBI #5451] Ignore NoSuchFileException during OperationLog.close()

Why are the changes needed?

OperationLog.close() try to close BufferedReader, but it says file is missing(NoSuchFileException). This happens a lot after restarting kyuubi-server and PV is not set for kyuubi.operation.log.dir.root.
Logs are like this:
2023-10-18 04:16:34.296 ERROR KyuubiTBinaryFrontendHandler-Pool: Thread-113 org.apache.kyuubi.operation.LaunchEngine: Failed to remove corresponding log file of operation: /opt/kyuubi/work/server_operation_logs/26434238-5615-456a-aa7b-fad4dde8da27/43a9bfd4-6795-422c-8031-5409d7fe3732
java.io.IOException: Failed to remove corresponding log file of operation: /opt/kyuubi/work/server_operation_logs/26434238-5615-456a-aa7b-fad4dde8da27/43a9bfd4-6795-422c-8031-5409d7fe3732
	at org.apache.kyuubi.operation.log.OperationLog.trySafely(OperationLog.scala:230) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.log.OperationLog.close(OperationLog.scala:201) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.KyuubiOperation.$anonfun$close$2(KyuubiOperation.scala:119) ~[kyuubi-server_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.KyuubiOperation.$anonfun$close$2$adapted(KyuubiOperation.scala:119) ~[kyuubi-server_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at scala.Option.foreach(Option.scala:407) ~[scala-library-2.12.15.jar:?]
	at org.apache.kyuubi.operation.KyuubiOperation.liftedTree2$1(KyuubiOperation.scala:119) ~[kyuubi-server_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.KyuubiOperation.close(KyuubiOperation.scala:116) ~[kyuubi-server_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.OperationManager.closeOperation(OperationManager.scala:126) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.session.AbstractSession.$anonfun$close$2(AbstractSession.scala:89) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_342]
...
Caused by: java.nio.file.NoSuchFileException: /opt/kyuubi/work/server_operation_logs/26434238-5615-456a-aa7b-fad4dde8da27/43a9bfd4-6795-422c-8031-5409d7fe3732
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) ~[?:1.8.0_342]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) ~[?:1.8.0_342]
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) ~[?:1.8.0_342]
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214) ~[?:1.8.0_342]
	at java.nio.file.Files.newByteChannel(Files.java:361) ~[?:1.8.0_342]
	at java.nio.file.Files.newByteChannel(Files.java:407) ~[?:1.8.0_342]
	at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384) ~[?:1.8.0_342]
	at java.nio.file.Files.newInputStream(Files.java:152) ~[?:1.8.0_342]
	at java.nio.file.Files.newBufferedReader(Files.java:2784) ~[?:1.8.0_342]
	at org.apache.kyuubi.operation.log.OperationLog.reader$lzycompute(OperationLog.scala:89) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.log.OperationLog.reader(OperationLog.scala:89) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.log.OperationLog.$anonfun$close$1(OperationLog.scala:201) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	at org.apache.kyuubi.operation.log.OperationLog.trySafely(OperationLog.scala:221) ~[kyuubi-common_2.12-1.6.1-incubating.jar:1.6.1-incubating]
	... 34 more

OperationLog.trySafely()is called by OperationLog.close() only, so we can ignore this exception.
This closes #5451
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[X] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No

Codecov Report

Merging #5453 (b957314) into master (c5854f7) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #5453   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         588     588
  Lines       33454   33455    +1
  Branches     4401    4401
======================================
- Misses      33454   33455    +1

Files
Coverage Δ

...org/apache/kyuubi/operation/log/OperationLog.scala
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thanks, merged to master and 1.8

backported to 1.7.4


How to run Kitematic on Mac with proxy?

I am running docker under corporate firewall.
As a result, tls certification failed when I tried to login dockerhub.
It seems that below package is internally used to make a http request.
https://www.npmjs.com/package/request#tlsssl-protocol
I think there are two way to workaround; proxy or tls config.
The former has an advantage not to change code.
But I don't know how to set proxy settings to kitematic.
Please let me know how to do that.
Best regards.

Are you behind a firewall or VPN?
See our wiki for possible solutions:
https://github.com/docker/kitematic/wiki/Common-Proxy-Issues-&-Fixes

@FrenchBen  I asked how to use proxy on mac.
When I did following the document you mentioned, it doesn't work well.
Can you let me know how to use proxy on mac?
Thanks in advance.

proxy on mac is a feature that is often requested as part of the docker toolbox and why I forwarded you there.
It's impossible for me to know your setup, unless you share it.
For the desktop product called Docker for Mac, please see the information here: https://docs.docker.com/docker-for-mac/networking/

@FrenchBen
My company firewall uses its own certificate to monitor network traffic.
It needs to install self-signed certificate on my mac.
But it seems like that kitematic doesn't use the certificate installed on mac to execute https request  such as login to docker hub.
On my mac, I set HTTP(S)_PROXY and checked whether docker hub login is available or not using chrome. And it is available. In the same environment, I run kitematic and tried to login but it showed x509 certificate problem.
I checked a source, https://github.com/docker/kitematic/blob/master/src/utils/HubUtil.js#L150,  about login to dockerhub;
I tested curl -XPOST https://hub.docker.com/v2/users/login/ on my terminal with(out) web proxy and cerificate verification is passed, which means a http settings(firewall) is right.
As I said, npm request package is used to make a http request.
There is no code about certificate settings in kitematic.
Look at the following link. https://www.npmjs.com/package/request#tlsssl-protocol
Could you tell me how to properly run kitematic with http proxy or skip to check certificate?


Icon does not work well with light theme

As seen in the image - the recall icon does not fit well when using any light theme in VS Code. Would it be possible to make it adaptive?

Hi. This is strange, the icon should be adapting. I tested it with a bunch of different color themes and it works.
What color theme and what version of Recall are you using? Let me know and I'll investigate it.

Hi, thanks for the quick response!
My setup:

Recall v0.11.1 (the current, latest version from open-vsx.org: https://open-vsx.org/extension/frenya/vscode-recall )
Atom One Light Theme v2.2.3
VS Codium 1.66.2 (latest)

I just discovered you released a v0.11.2 back then (fixing brain icons SVG) - it does not seem to be available at open-vsx. Would you be able to update the extension there?

Ok, that explains it. I'll try to publish the update on open-vsx soon and let you know.

Hi. So I have uploaded version 0.11.5 to open-vsx and tested it with VSCodium 1.66.2. All seems to be working correctly.


⚠ Spryr has degraded performance

In 87b4dd6, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4608 ms

Resolved: Spryr performance has improved in b2952c2 after 8 minutes.


dev branch bower version

incorrect cornerstone bower version.
CornerstoneTools (dev) and WadoImageloader (dev) need 0.10.0  but dev branch verson 0.9.0
try install cornerstoneTools#dev
bower cornerstone#~0.10.0      ENORESTARGET No tag found that was able to satisfy ~0.10.0

The /dev branch is for work currently in development (not yet released) and is releasing the other libraries that are not yet released.  You will have to manually copy them down (without bower) to work with the dev branch

I understand but no need release 0.10.0 version, if change bower.json in
cornerstoneTools#dev and
cornerstoneWADOImageLoader#dev    "dependencies": { "cornerstone": "dev", maybe solve the problem.
sorry my bad english.


Upper bound wrong?

@pavelzw pointed out that some upper bound calculation might be slightly off:

${{ pin_subpackage('foo', lower_bound="x.x.x", upper_bound="x.x.x") }}

Apparently results in >=0.11.1post1+HASH,<1
Should double check what's going on!

this is fixed with the latest release. thanks @wolfv


move configuration inside config.before_configuration block

This makes sense to me, was the issue that config is no longer available outside of configuration blocks in <IP_ADDRESS>?

Nope that isn't it because you are calling before_configuration on it. Can you clarify what the specific issue was?

@nextmat  yeah the issue is if the configuration isn't loaded in the block I can't use Rails.application.secrets because the Application isn't initialized yet and therefore Rails.application is nil, that was the problem. when I put it in the config.before_comfiguration block I am sure that the application has already been initialized and the secrets have been loaded and I can use them in my yml file.

@zacksiri In general I agree with what you said & I definitely think we want to support Rails.application.secrets as an option going forward. However that doesn't exist in Rails versions prior to 4.1 and we support all the way back to Rails 3.0 (and have a large existing userbase).
How is using Rails secrets hash different from your perspective from using the librato.yml file? Both are yml and both allow ERB to let you embed values from other sources, including the filesystem or env vars (both are pretty common practice). Is there something special about the Rails secrets hash that makes it an improvement? My impression was it was mostly a way to introduce consistency in an area where lots of folks were handrolling.
If your point is that we should detect secrets from Rails hash instead of detecting our own config file or env vars, really what that would mean is just adding a third way to configure librato-rails for users of 4.1+. Is that what you are suggesting?
Thanks for your feedback and the PR!

Related: https://github.com/librato/librato-rails/wiki/Configuration#combining-config-files-and-environment-variables

yes, the soul purpose is consistency's sake, I mean you could go down the route of detecting from the secret hash, that would make me have to not add a librato.yml file to my app. but you could keep it this way, too my solution shouldn't effect the people who want to use the config the old way, it just adds the ability for me to pull stuff from the secrets hash, as you can see the tests are passing for all the versions.
think about it for a sec, there are now 4 different ways to store and consume secrets depending on which infrastructure you use, etcd, consul, environment variables, kubernetes volume, zookeeper, depending on the solution you'd have to manually put code in place to consume the secrets, if moving forward we stick to supporting Rails secret, it no longer matters, people can be doing what they want to inject things into secrets, but now the entire app is using one consistent way to access all of that.

Sounds good, thanks for the clarification.
To summarize the issue here was that if you tried to interpolate values from the Rails.application.secrets hash in your librato.yml it wasn't available because the file hadn't been evaluated by Rails yet. Moving our prefconfiguration logic into a config.before_configuration block addresses this.
Thanks for the patch!

Released in v1.2.0


Fix RBD primary storage host port null error

Description
Ubuntu 20.04 +KVM +CEPH 15.2
Add RBD main storage through UI, it will fail when there is no host port parameter;
Because when we created the pool, we did not add the port target in the xml

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@div8cn with you comment https://github.com/apache/cloudstack/pull/4568#issuecomment-754321932 do we need this PR?

@div8cn with you comment https://github.com/apache/cloudstack/pull/4568#issuecomment-754321932 do we need this PR?

@rhtyd I think this PR is necessary,
The best practice is to let libvirt decide to use port 3300 or 6789 to communicate with CEPH.
Therefore, it is best not to enter any port when adding mon;
@wido What do you think?

@rhtyd I think this PR is necessary,
The best practice is to let libvirt decide to use port 3300 or 6789 to communicate with CEPH.
Therefore, it is best not to enter any port when adding mon;
@wido What do you think?

I agree @div8cn , this PR is needed.
In the early days of Ceph you needed to specify the port. Now we should have libvirt/qemu/librados/librbd handle this. We shouldn't interfere.
People running Ceph monitors on alternative ports are rare, very rare. I have never encountered them recently.
So yes, just a hostname should be sufficient without a port number.

I agree @div8cn , this PR is needed.
In the early days of Ceph you needed to specify the port. Now we should have libvirt/qemu/librados/librbd handle this. We shouldn't interfere.
People running Ceph monitors on alternative ports are rare, very rare. I have never encountered them recently.
So yes, just a hostname should be sufficient without a port number.

@wido @DaanHoogland @GabrielBrascher @weizhouapache  should this be treated as a blocker then, or good to have?
@blueorangutan package

@wido @DaanHoogland @GabrielBrascher @weizhouapache  should this be treated as a blocker then, or good to have?
@blueorangutan package

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2525

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2525

@blueorangutan test

@blueorangutan test

Trillian test result (tid-3372)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30348 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4565-t3372-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@rhtyd it would be great to have this one on board, but I don't see reason in blocking a release because of it.
Any comments, @wido @DaanHoogland @div8cn @weizhouapache?

@rhtyd it would be great to have this one on board, but I don't see reason in blocking a release because of it.
Any comments, @wido @DaanHoogland @div8cn @weizhouapache?


K8SPXC-683 Add check for backupName and backuoSource fields simultane…

…ous setting

Test name
Status

scaling
passed

big-data
passed

upgrade-haproxy
passed

recreate
passed

haproxy
passed

storage
passed

scaling-proxysql
passed

init-deploy
passed

self-healing
passed

upgrade-proxysql
passed

restore-to-encrypted-cluster
passed

limits
passed

self-healing-advanced
passed

monitoring-2-0
passed

smart-update
failed

demand-backup
passed

affinity
passed

operator-self-healing
failed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

pitr
failed

users
passed

security-context
passed

upgrade-consistency
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

demand-backup-encrypted-with-tls
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/822/commits/0d5786329d192018aece0b3baa7f1d4ac7f157bb
image: perconalab/percona-xtradb-cluster-operator:PR-822-0d578632

Test name
Status

scaling
passed

scaling-proxysql
passed

security-context
passed

storage
passed

haproxy
passed

self-healing
passed

init-deploy
passed

self-healing-advanced
passed

limits
passed

operator-self-healing
passed

monitoring-2-0
passed

big-data
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

recreate
passed

upgrade-haproxy
passed

tls-issue-self
passed

restore-to-encrypted-cluster
passed

tls-issue-cert-manager
passed

demand-backup
passed

tls-issue-cert-manager-ref
passed

pitr
failed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/822/commits/0d5786329d192018aece0b3baa7f1d4ac7f157bb
image: perconalab/percona-xtradb-cluster-operator:PR-822-0d578632

Test name
Status

scaling
passed

scaling-proxysql
passed

security-context
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

big-data
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

storage
passed

upgrade-haproxy
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/822/commits/0d5786329d192018aece0b3baa7f1d4ac7f157bb
image: perconalab/percona-xtradb-cluster-operator:PR-822-0d578632

Test name
Status

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

haproxy
passed

upgrade-haproxy
passed

pitr
failed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

storage
passed

one-pod
passed

self-healing
passed

scaling
passed

self-healing-advanced
passed

auto-tuning
passed

scaling-proxysql
passed

operator-self-healing
passed

proxysql-sidecar-res-limits
passed

security-context
passed

users
passed

tls-issue-self
passed

big-data
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/822/commits/0d5786329d192018aece0b3baa7f1d4ac7f157bb
image: perconalab/percona-xtradb-cluster-operator:PR-822-0d578632


SWMF Binary File Support

Add support to read SWMF files. This needs to:

Incorporate the single file reader from Gabor
have python code for turning (for example) SWMF runs into SWMF files
have a test for functionality

Ok, I am not going to use the file output from Gabor, since there are no example files, but the general functionality of this has been finished.  A python code exists that read in the IE files and output SWMF-ready AMIE files.  Then a code was developed to read in these files into the electrodynamics library.
Still to do - read in all of the MAGNIT variables (wave, mono, and ions).  This should be easy, but needs to be completed.


hostname/nameservers can be regenerated from cron

As suggested in https://github.com/opnsense/plugins/issues/3090

Merged, thanks!


LevelEnum type error; Cannot access ambient const enums with --isolatedModules

Operating System (or Browser): Arch Linux
chalk Version: 3.0.0
Node Version: 13.7.0
TypeScript Version: 3.7.5

How Do We Reproduce?

Import chalk in a TypeScript project
Attempt to build the project with the --isolatedModules option

See minimal repro: https://github.com/MaxMilton/repro-chalk-enum-type
Expected Behaviour
Project builds without type errors.
Actual Behaviour
Type error is thrown due to ambient const enums not supported with the --isolatedModules option.
❯ yarn run build
yarn run v1.21.1
$ tsc --isolatedModules --esModuleInterop index.ts
node_modules/chalk/index.d.ts:403:16 - error TS2748: Cannot access ambient const enums when the '--isolatedModules' flag is provided.

403  Level: typeof LevelEnum;
                   ~~~~~~~~~

Found 1 error.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Changing chalk/index.d.ts from...
declare const enum LevelEnum {

... to...
declare enum LevelEnum {

... resolves the issue. Since chalk.Level is already defined in the source, this change shouldn't impact consumer functionality.
There is a similar issue https://github.com/chalk/chalk/issues/363 which took a step towards fixing this but didn't quite get all the way there.
Developers upgrading to Jest v25.1.0 packages are going to run into this.

Seeing this too

Thank you for switching to a union :tada: :tada:
I've been patching chalk across all projects I touch so very much looking forward to using the stock standard types!


Default strings aren't localized

It'd be nice if the strings in the library were localized. To do that, we should use string resources instead of hard-coded string constants.

from version 1.1.0 strings are localized

How to do it?

You can either overwrite the following strings or add your custom buttons.
<string name="colorpicker_dialog_title">Choose the color</string>
<string name="colorpicker_dialog_cancel">CANCEL</string>
<string name="colorpicker_dialog_ok">OK</string>


Ah/dcos 38248 1.10

High-level description
This is a backport of https://github.com/dcos/dcos/pull/2989 for 1.10
The lua code has been using ngx.timer.at() for the AR cache update. This can lead to the problem described in the JIRA ticket below. This PR replaces ngx.timer.at() with a more robust alternative of ngx.timer.every(), which also fixes the problem described in the JIRA ticket below.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:
https://jira.mesosphere.com/browse/DCOS-38248
Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ x ] Read the DC/OS contributing guidelines
[ x ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@jgehrcke indeed, I had copied the files from master over. Sorry for the extra review work this caused, @jgehrcke @gpaul @vespian
Corrected the patch, could you take a look please? Thank you!


Update documentation for vSphere Policy API

Added information about VM placement in static Load Balancer Pools when using NSX-T Policy API.
Added NSX-T configuration option use_policy_api to the  Global Configuration section of the vSphere CPI.

Tagging some bosh people cause we made a new release with these swanky updates that's been released and I can't add reviewers @klakin-pivotal @cunnie @jpalermo

@cunnie damn cunnie

Yo who are you? @drnic @mariash

Looks good! Merging.

Um hmm

@Amybakes91 Thanks for commenting on this thread. I assume you're taking some type of course, and the instructor asked you to comment on a pull request (or something similar). At any rate, we want to welcome you to the GitHub community & hope your experience here is both enjoyable and educational.


Queries RFC - custom language edition

This is an alternative to #165, the JavaScript based query language.
This proposes a custom query language, which is easier to type and allows us to provide immediate feedback to users. On the other hand, it will require significantly more work to develop.

Using javascript is more powerful but leaves as open to a large attack surface since opening a note can now potentially run an arbitrary script.
Instead of creating a custom language vs using an existing full blown programming language, I would propose using an existing query spec.
The two that come to mind:

GitHub - google/cel-spec: Common Expression Language -- specification and binary representation

HN: https://news.ycombinator.com/item?id=25377620
this powers Writing conditions for Cloud Firestore Security Rules
GitHub - google/cel-go: Fast, portable, non-Turing complete expression evaluation with gradual typing (Go)

The Dhall configuration language


Handling of spoken numbers

I cannot find a way of making Alexa handle numbers correctly in all cases. If I enter a decimal such as 22.2 alexa will say 22 comma 2, ignoring whatever punctuation character I put there. The work around is I substitute the word point for the DP. I couldn't find any other way of getting this to work.
I also think the interpretation of time ins a string is variable (possibly context sensitive).
I now can have a message such as this "Completed at 22:54" and Alexa will announce as expected. A bit earlier  I had a similar but subtly different string and Alexa would announce the time as 2 thousand 2 hundred and fifty four.
I tried using the Alexa speech markup SSML but she simply spoke the contents as normal text, ignoring the  headers.
Is there any way of forcing numbers to be spoken as intended?
Coppo

The library was replacing dots with commas. That now no longer happens. (version 3)
Please check out the example for how you can get ssml to work.


<IP_ADDRESS>: cramfs module has to be explicitly deny-listed for ending up with a CIS-compliant state

Describe the Issue
0. Initial CIS Assessment, before executing Ansible role:
** PASS **
- Module "cramfs" doesn't exist on the system

1a. Running the Ansible role
2a. Afterwards CIS assessment: Rule reported as failed.
Expected Behavior
2b. Afterwards CIS assessment: Rule reported as passed:
  ** PASS **

 - module: "cramfs" is not loadable: "install /bin/true "
 - module: "cramfs" is not loaded
 - module: "cramfs" is deny listed in: "/etc/modprobe.d/cramfs.conf"

Actual Behavior
2a. Afterwards CIS assessment: Rule reported as failed.
- Audit Result:
** FAIL **
- Reason(s) for audit failure:
- module: "cramfs" is not deny listed
- Correctly set:
- module: "cramfs" is not loadable: "install /bin/true "
- module: "cramfs" is not loaded

Control(s) Affected
Rule <IP_ADDRESS>
Environment (please complete the following information):

branch being used: [e.g. devel]

Additional Notes

Red-Hat's approach on preventing kernel modules to be automatically loaded: Step2 & Step3
STIG for RH8, cramfs configuration
OpenSCAP's way of doing it, even if for other OS-baselines( e.g. Oracle Linux )

To configure the system to prevent the cramfs from being used, add the following line to file /etc/modprobe.d/cramfs.conf:
blacklist cramfs

Possible Solution
I'll add a PR immediately.

hi @ipruteanu-sie
Thank you for raising the issue regarding the cramfs and blacklist. Can you please confirm the branch you are using?
Basing in on devel branch
The problem we see very often is that scanners all work differently and some are very restricted and brittle. In this case they are looking for the blacklist in cramfs.conf rather than ensuring a blacklists exists.
If you look at the system it should be blacklisted in /etc/modprobe.d/blacklist.conf.
This means that is passes the requirement but the scanners are too restrictive on how people may configure their systems.
This is the reason we developed our own configuration so we can amend and fix these as quickly as issues arise to try and remove these false positives
Please let me know if this working as expected?
many thanks
uk-bolly

Hi @uk-bolly ,
Thanks for your explanation, I was using indeed devel branch, but a not updated version of it.
Last week's update fixed it indeed, CIS reports it properly:
- Audit Result:
** PASS **
- module: "cramfs" is not loadable: "install /bin/true "
- module: "cramfs" is not loaded
- module: "cramfs" is deny listed in: "/etc/modprobe.d/blacklist.conf"


Benchmark extensions to test creation from snapshots and against es6 & raw mobx

This adds a couple more bits to the benchmarking setup to help compare MST and this awesome library:

Add a benchmark for creating instances from snapshots that already have data in them
Add raw es6 classes comparison and raw mobx comparison to the benchmark

Plain old JS classes are not really a substitute for mobx-y anything, but, it's useful to know how much overhead the libraries introduce over the simplest way you might do the same thing in plain old JS. Similarly, it's nice to know what overhead is mobx's fault vs these libraries fault. I kept the benchmark reporting smart enough to only compare mobx-keystone and mobx-state-tree, and then log how much faster the es6 implementation is and the mobx implementation is just for reference.
Here's what I get when running with typechecking on and typechecking off locally:
empty creation (type checking enabled) - mst is usually faster here due to lazy creation
mobx-keystone x 4,169 ops/sec ±6.12% (75 runs sampled)
mobx-state-tree x 4,545 ops/sec ±6.51% (85 runs sampled)
raw es6 x 191,813 ops/sec ±2.73% (90 runs sampled)
raw mobx x 17,260 ops/sec ±1.07% (90 runs sampled)
Fastest is mobx-state-tree by 1.09x
raw mobx is faster by 3.80x
raw es6 is faster by 42.20x

empty creation + access all simple props (type checking enabled)
mobx-keystone x 4,668 ops/sec ±3.54% (81 runs sampled)
mobx-state-tree x 2,334 ops/sec ±3.36% (82 runs sampled)
raw es6 x 196,179 ops/sec ±0.45% (93 runs sampled)
raw mobx x 17,918 ops/sec ±0.58% (94 runs sampled)
Fastest is mobx-keystone by 2.00x
raw mobx is faster by 3.84x
raw es6 is faster by 42.02x

already created, access all simple props (type checking enabled)
mobx-keystone x 341,406 ops/sec ±0.56% (95 runs sampled)
mobx-state-tree x 297,739 ops/sec ±2.64% (90 runs sampled)
raw es6 x 3,294,078 ops/sec ±2.71% (91 runs sampled)
raw mobx x 989,796 ops/sec ±1.02% (93 runs sampled)
Fastest is mobx-keystone by 1.15x
raw mobx is faster by 2.90x
raw es6 is faster by 9.65x

snapshot creation (type checking enabled)
mobx-keystone x 4,384 ops/sec ±2.92% (82 runs sampled)
mobx-state-tree x 5,130 ops/sec ±2.07% (90 runs sampled)
raw es6 x 190,180 ops/sec ±0.48% (95 runs sampled)
raw mobx x 17,085 ops/sec ±1.43% (91 runs sampled)
Fastest is mobx-state-tree by 1.17x
raw mobx is faster by 3.33x
raw es6 is faster by 37.07x

already created, access all simple props (type checking enabled)
mobx-keystone x 331,105 ops/sec ±1.15% (92 runs sampled)
mobx-state-tree x 312,005 ops/sec ±1.80% (91 runs sampled)
raw es6 x 3,448,649 ops/sec ±0.59% (93 runs sampled)
raw mobx x 986,882 ops/sec ±1.24% (89 runs sampled)
Fastest is mobx-keystone by 1.06x
raw mobx is faster by 2.98x
raw es6 is faster by 10.42x

already created, change all simple props (type checking enabled)
mobx-keystone x 1,903 ops/sec ±1.84% (87 runs sampled)
mobx-state-tree x 1,447 ops/sec ±3.06% (83 runs sampled)
raw es6 x 1,717 ops/sec ±1.40% (89 runs sampled)
raw mobx x 1,605 ops/sec ±2.18% (87 runs sampled)
Fastest is mobx-keystone by 1.32x
raw mobx is faster by 0.84x
raw es6 is faster by 0.90x

already created, change one simple props + getSnapshot (type checking enabled)
mobx-keystone x 62,599 ops/sec ±1.76% (90 runs sampled)
mobx-state-tree x 34,634 ops/sec ±1.91% (90 runs sampled)
raw es6 x 7,136,654 ops/sec ±62.88% (30 runs sampled)
raw mobx:
Fastest is mobx-keystone by 1.81x
raw mobx is faster by 0.00x
raw es6 is faster by 114.01x

empty creation (type checking disabled) - mst is usually faster here due to lazy creation
mobx-keystone x 4,305 ops/sec ±6.24% (79 runs sampled)
mobx-state-tree x 4,165 ops/sec ±8.03% (80 runs sampled)
raw es6 x 186,264 ops/sec ±7.02% (86 runs sampled)
raw mobx x 16,673 ops/sec ±2.56% (85 runs sampled)
Fastest is mobx-keystone by 1.03x
raw mobx is faster by 3.87x
raw es6 is faster by 43.27x

empty creation + access all simple props (type checking disabled)
mobx-keystone x 4,146 ops/sec ±18.43% (76 runs sampled)
mobx-state-tree x 2,339 ops/sec ±3.22% (83 runs sampled)
raw es6 x 183,910 ops/sec ±1.26% (93 runs sampled)
raw mobx x 16,579 ops/sec ±2.49% (89 runs sampled)
Fastest is mobx-keystone by 1.77x
raw mobx is faster by 4.00x
raw es6 is faster by 44.35x

already created, access all simple props (type checking disabled)
mobx-keystone x 314,256 ops/sec ±1.00% (94 runs sampled)
mobx-state-tree x 368,448 ops/sec ±1.29% (93 runs sampled)
raw es6 x 3,300,070 ops/sec ±2.22% (91 runs sampled)
raw mobx x 927,336 ops/sec ±2.16% (88 runs sampled)
Fastest is mobx-state-tree by 1.17x
raw mobx is faster by 2.52x
raw es6 is faster by 8.96x

snapshot creation (type checking disabled)
mobx-keystone x 4,685 ops/sec ±4.67% (84 runs sampled)
mobx-state-tree x 5,090 ops/sec ±1.80% (88 runs sampled)
raw es6 x 184,028 ops/sec ±1.21% (88 runs sampled)
raw mobx x 16,780 ops/sec ±2.55% (87 runs sampled)
Fastest is mobx-state-tree by 1.09x
raw mobx is faster by 3.30x
raw es6 is faster by 36.15x

already created, access all simple props (type checking disabled)
mobx-keystone x 326,125 ops/sec ±1.50% (90 runs sampled)
mobx-state-tree x 298,691 ops/sec ±2.33% (92 runs sampled)
raw es6 x 3,443,478 ops/sec ±1.23% (94 runs sampled)
raw mobx x 940,590 ops/sec ±0.77% (94 runs sampled)
Fastest is mobx-keystone by 1.09x
raw mobx is faster by 2.88x
raw es6 is faster by 10.56x

already created, change all simple props (type checking disabled)
mobx-keystone x 3,711 ops/sec ±4.80% (84 runs sampled)
mobx-state-tree x 1,406 ops/sec ±2.91% (87 runs sampled)
raw es6 x 1,573 ops/sec ±3.45% (88 runs sampled)
raw mobx x 1,604 ops/sec ±2.10% (90 runs sampled)
Fastest is mobx-keystone by 2.64x
raw mobx is faster by 0.43x
raw es6 is faster by 0.42x

already created, change one simple props + getSnapshot (type checking disabled)
mobx-keystone x 137,831 ops/sec ±1.62% (87 runs sampled)
mobx-state-tree x 34,752 ops/sec ±1.66% (85 runs sampled)
raw es6 x 8,884,053 ops/sec ±22.73% (48 runs sampled)
raw mobx:
Fastest is mobx-keystone by 3.97x
raw mobx is faster by 0.00x
raw es6 is faster by 64.46x

on top of the other PR cause I thought this one might be a bit more controversial

hey, nice work :)
just a thing, is this test broken in raw mobx?
already created, change one simple props + getSnapshot (type checking enabled)
mobx-keystone x 62,599 ops/sec ±1.76% (90 runs sampled)
mobx-state-tree x 34,634 ops/sec ±1.91% (90 runs sampled)
raw es6 x 7,136,654 ops/sec ±62.88% (30 runs sampled)
raw mobx:
Fastest is mobx-keystone by 1.81x
raw mobx is faster by 0.00x
raw es6 is faster by 114.01x

Oops, fixed that broken benchmark, here's what I get locally when running it now:
already created, change one simple props + getSnapshot (type checking enabled)
mobx-keystone x 99,567 ops/sec ±20.44% (89 runs sampled)
mobx-state-tree x 39,384 ops/sec ±0.91% (89 runs sampled)
raw es6 x 7,005,461 ops/sec ±59.85% (39 runs sampled)
raw mobx x 639,409 ops/sec ±2.23% (87 runs sampled)
Fastest is mobx-keystone by 2.53x
raw mobx is faster by 6.42x
raw es6 is faster by 70.36x

already created, change one simple props + getSnapshot (type checking disabled)
mobx-keystone x 160,108 ops/sec ±1.51% (89 runs sampled)
mobx-state-tree x 36,479 ops/sec ±0.62% (91 runs sampled)
raw es6 x 7,039,694 ops/sec ±57.68% (43 runs sampled)
raw mobx x 598,158 ops/sec ±2.97% (87 runs sampled)
Fastest is mobx-keystone by 4.39x
raw mobx is faster by 3.74x
raw es6 is faster by 43.97x

also, when you say "raw mobx is faster by xxx" is it compared to keystone always or the faster between keystone and mst?

Ah, that's kinda unclear, it's that raw mobx is faster than the fastest full-state-management library (keystone or MST). I can change that to be faster than keystone specifically if you'd prefer

I can change that to be faster than keystone specifically if you'd prefer

That would be great 😊

Ok, here's the result after that change:
empty creation (type checking enabled) - mst is usually faster here due to lazy creation
mobx-keystone x 5,177 ops/sec ±4.85% (83 runs sampled)
mobx-state-tree x 5,179 ops/sec ±1.55% (89 runs sampled)
raw es6 x 205,976 ops/sec ±1.74% (95 runs sampled)
raw mobx x 18,615 ops/sec ±0.51% (93 runs sampled)
Fastest is mobx-state-tree by 1.00x
raw mobx is faster than mobx-keystone by 3.60x
raw es6 is faster than mobx-keystone by 39.79x

empty creation + access all simple props (type checking enabled)
mobx-keystone x 5,047 ops/sec ±3.08% (84 runs sampled)
mobx-state-tree x 2,576 ops/sec ±3.43% (88 runs sampled)
raw es6 x 193,001 ops/sec ±1.74% (95 runs sampled)
raw mobx x 17,676 ops/sec ±4.68% (93 runs sampled)
Fastest is mobx-keystone by 1.96x
raw mobx is faster than mobx-keystone by 3.50x
raw es6 is faster than mobx-keystone by 38.24x

already created, access all simple props (type checking enabled)
mobx-keystone x 357,440 ops/sec ±0.51% (95 runs sampled)
mobx-state-tree x 336,369 ops/sec ±0.35% (96 runs sampled)
raw es6 x 3,473,536 ops/sec ±1.86% (93 runs sampled)
raw mobx x 1,024,684 ops/sec ±0.37% (95 runs sampled)
Fastest is mobx-keystone by 1.06x
raw mobx is faster than mobx-keystone by 2.87x
raw es6 is faster than mobx-keystone by 9.72x

snapshot creation (type checking enabled)
mobx-keystone x 4,851 ops/sec ±2.05% (87 runs sampled)
mobx-state-tree x 5,329 ops/sec ±1.25% (93 runs sampled)
raw es6 x 192,508 ops/sec ±1.98% (97 runs sampled)
raw mobx x 17,932 ops/sec ±0.96% (94 runs sampled)
Fastest is mobx-state-tree by 1.10x
raw mobx is faster than mobx-keystone by 3.70x
raw es6 is faster than mobx-keystone by 39.68x

already created, access all simple props (type checking enabled)
mobx-keystone x 359,517 ops/sec ±0.31% (96 runs sampled)
mobx-state-tree x 332,320 ops/sec ±1.53% (96 runs sampled)
raw es6 x 3,481,793 ops/sec ±0.56% (97 runs sampled)
raw mobx x 1,046,507 ops/sec ±0.38% (96 runs sampled)
Fastest is mobx-keystone by 1.08x
raw mobx is faster than mobx-keystone by 2.91x
raw es6 is faster than mobx-keystone by 9.68x

already created, change all simple props (type checking enabled)
mobx-keystone x 2,040 ops/sec ±0.69% (91 runs sampled)
mobx-state-tree x 1,523 ops/sec ±2.12% (90 runs sampled)
raw es6 x 1,755 ops/sec ±1.00% (92 runs sampled)
raw mobx x 1,770 ops/sec ±0.58% (95 runs sampled)
Fastest is mobx-keystone by 1.34x
raw mobx is faster than mobx-keystone by 0.87x
raw es6 is faster than mobx-keystone by 0.86x

already created, change one simple props + getSnapshot (type checking enabled)
mobx-keystone x 63,527 ops/sec ±0.83% (89 runs sampled)
mobx-state-tree x 34,329 ops/sec ±2.24% (89 runs sampled)
raw es6 x 6,232,439 ops/sec ±59.44% (41 runs sampled)
raw mobx x 645,647 ops/sec ±3.50% (82 runs sampled)
Fastest is mobx-keystone by 1.85x
raw mobx is faster than mobx-keystone by 10.16x
raw es6 is faster than mobx-keystone by 98.11x

empty creation (type checking disabled) - mst is usually faster here due to lazy creation
mobx-keystone x 4,600 ops/sec ±5.09% (81 runs sampled)
mobx-state-tree x 4,469 ops/sec ±8.94% (85 runs sampled)
raw es6 x 205,163 ops/sec ±0.32% (97 runs sampled)
raw mobx x 18,039 ops/sec ±1.84% (92 runs sampled)
Fastest is mobx-keystone by 1.03x
raw mobx is faster than mobx-keystone by 3.92x
raw es6 is faster than mobx-keystone by 44.60x

empty creation + access all simple props (type checking disabled)
mobx-keystone x 5,245 ops/sec ±4.36% (79 runs sampled)
mobx-state-tree x 2,397 ops/sec ±3.18% (85 runs sampled)
raw es6 x 188,875 ops/sec ±1.68% (96 runs sampled)
raw mobx x 17,128 ops/sec ±0.79% (92 runs sampled)
Fastest is mobx-keystone by 2.19x
raw mobx is faster than mobx-keystone by 3.27x
raw es6 is faster than mobx-keystone by 36.01x

already created, access all simple props (type checking disabled)
mobx-keystone x 334,405 ops/sec ±0.84% (95 runs sampled)
mobx-state-tree x 375,393 ops/sec ±1.26% (94 runs sampled)
raw es6 x 2,226,953 ops/sec ±10.42% (64 runs sampled)
raw mobx x 629,110 ops/sec ±4.47% (74 runs sampled)
Fastest is mobx-state-tree by 1.12x
raw mobx is faster than mobx-keystone by 1.88x
raw es6 is faster than mobx-keystone by 6.66x

snapshot creation (type checking disabled)
mobx-keystone x 3,822 ops/sec ±5.10% (72 runs sampled)
mobx-state-tree x 4,014 ops/sec ±4.38% (83 runs sampled)
raw es6 x 157,622 ops/sec ±0.13% (95 runs sampled)
raw mobx x 15,334 ops/sec ±0.50% (87 runs sampled)
Fastest is mobx-state-tree by 1.05x
raw mobx is faster than mobx-keystone by 4.01x
raw es6 is faster than mobx-keystone by 41.24x

already created, access all simple props (type checking disabled)
mobx-keystone x 316,679 ops/sec ±1.77% (93 runs sampled)
mobx-state-tree x 362,996 ops/sec ±0.47% (86 runs sampled)
raw es6 x 3,364,192 ops/sec ±0.36% (97 runs sampled)
raw mobx x 1,014,370 ops/sec ±1.76% (89 runs sampled)
Fastest is mobx-state-tree by 1.15x
raw mobx is faster than mobx-keystone by 3.20x
raw es6 is faster than mobx-keystone by 10.62x

already created, change all simple props (type checking disabled)
mobx-keystone x 3,917 ops/sec ±2.30% (89 runs sampled)
mobx-state-tree x 1,668 ops/sec ±0.80% (95 runs sampled)
raw es6 x 1,673 ops/sec ±0.54% (94 runs sampled)
raw mobx x 1,632 ops/sec ±2.14% (92 runs sampled)
Fastest is mobx-keystone by 2.35x
raw mobx is faster than mobx-keystone by 0.42x
raw es6 is faster than mobx-keystone by 0.43x

already created, change one simple props + getSnapshot (type checking disabled)
mobx-keystone x 142,311 ops/sec ±0.69% (96 runs sampled)
mobx-state-tree x 34,185 ops/sec ±0.38% (92 runs sampled)
raw es6 x 9,633,969 ops/sec ±19.89% (31 runs sampled)
raw mobx x 636,578 ops/sec ±2.86% (89 runs sampled)
Fastest is mobx-keystone by 4.16x
raw mobx is faster than mobx-keystone by 4.47x
raw es6 is faster than mobx-keystone by 67.70x

I think running it with and without type checking is actually a good idea

thanks!


ParseError causes Elysia to crash when using this plugin

What versions are running?
"elysia": "1.0.11",
"@bogeychan/elysia-logger": "0.0.20",
What steps can reproduce the bug?
import { Elysia, t } from "elysia";
import { logger } from "@bogeychan/elysia-logger";

export const app = new Elysia()
    .use(
        logger({
            level: "trace",
            autoLogging: true,
        }),
    )
    .post("/test", (ctx) => "ok", {
        body: t.Object({
            test: t.String(),
        }),
    });

app.listen(3000);

Send empty body to provoke the error:
curl 'http://localhost/test' --data-raw '' -H 'content-type: application/json'

The response is:
Failed to parse body as found: [object Object]%

What is the expected behavior?
No response
What do you see instead?

41 |         return app
42 |             .onRequest((ctx) => {
43 |             ctx.store = { ...ctx.store, startTime: performance.now() };
44 |         })
45 |             .onResponse({ as: "global" }, (ctx) => {
46 |             if (log.level == "silent") {
                     ^
TypeError: undefined is not an object (evaluating 'log.level')
      at /home/haakon/repos/nxtest/node_modules/.pnpm/@bogeychan+elysia-logger@0.0.20_elysia@1.0.11/node_modules/@bogeychan/elysia-logger/dist/index.js:46:17

Additional information
No response

Hi 👋
this should be fixed with 0.0.21. Let me know if the issue persists.


MSAL support for UWP on Win 8.1

MSAL doesn't seem to support UWP on Win 8.1 platform. The lowest is uap10.0 as per this wiki.
This doc should be updated. It says Win 8.1 should work with the flag (UseCorporateNetwork) turned on, as per the documentation.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e437621-5643-b856-9be8-9dcb5686bbd0
Version Independent ID: 1daf42b4-f6bc-9540-6edf-429c454a2814
Content: UWP considerations (MSAL.NET) - Microsoft identity platform
Content Source: articles/active-directory/develop/msal-net-uwp-considerations.md
Service: active-directory
Sub-service: develop
GitHub Login: @mmacy
Microsoft Alias: marsma

@Rinki-MSFT
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@Rinki-MSFT
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@jmprieur It looks like we need to delete this doc. Per this MSAL.NET wiki article:

Support for Windows 8/8.1 and Windows Phone 8/8.1 was removed

Can you confirm, please?

@mmacy. It's still useful for UAP.
@Rinki-MSFT : I don't understand what the problem is. Is it? UWP us not only Windows Phone? Is it? From my understanding it means Universal Windows Platform, and is used for XBox etc ...

@mmacy. It's still useful for UAP.

@jmprieur OK, should it then be updated to replace all instances of Windows 8.1 with Windows 10?

Yes, @mmacy

Thanks @jmprieur and sorry for the confusion.
Thank you @mmacy.


New ESMValTool logo

Hey guys, I know this may be a bit of a side-problem, but I think the logo is a very i,portant thing for a product, so I had a bit of a remake done to our nice logo - I really like @axel-lauer new site and actually borrowed the logo and font layout from the new site but I made a couple changes:

enhanced colours of the globe,
added an actual (toy) satellite and put a couple lights on it;
added monochrome patch where the satellite's field of view is blind - ie our analyses are fully coloured only when there is OBS data
changed the writing to white and gave it a very dark grey background, much more visible -> and I think we need to get rid of that grey band on the new website as well, just leave it black with white font and menu entries

What do you think? @ESMValGroup/esmvaltool-coreteam

Nice logo, couldn't find the submarine yet, though ;-) But I think we have to discuss a possible change of logo with @veyring first before deciding anything...
Regarding the gray bar on the website, I just changed that to slightly funkier semi-transparent dark blue and modified the current logo so that text and satellite orbit are now in white. The menu font is now also white. I think not having the menu items floating in "space" is kinda nice, but that can be up for discussion.

nice one @axel-lauer - like the blue band much better :beer: Yes, of course -- discussing the logo change with @veyring is a must -- I am just starting this thread to put forward propositions, we can have a few of them and a bunch of ideas to choose from. The submarine is in the North Atlantic but you can't see it since it's currently at 400m depth :grin:

Hi,
I've been following and learning a lot from your threads, so I wanted to pay it back now with some advice about the logo. First of all I see that the font style in the logo seems to be off with the scaling, could be that it is not an font style that is done in vectorized format, that is both on the ESMValTool, and the smaller text (scale the browser window and you will get quick response).
Then I looked it up on my phone (read a lot on the train and bus to learn me more), there I saw the menu bar is disappears on smaller screen.
So just some few thougths from a destroyed frontend mind trying to learn more on climate data.

"New" logo used on current ESMValTool website:

Two of the monochrome versions:

Nice. Could you post the names of the fonts you used?

@zklaus font used is Futura (medium).

@lukruh was very kind and implemented dark mode logos, and, as it stands, the logo is very nice and I don't think we need to change it anytime soon, so am closing this. Many thanks, Lukas! relevant PRs https://github.com/ESMValGroup/ESMValCore/pull/2532 and #3751

and of course, many thanks to @axel-lauer for creating the current, and very pretty logo (3 years old already!) :beer:


fix ApplyConfigMapWithData

What sort of test should we have in place to have caught this before?
/lgtm

What sort of test should we have in place to have caught this before?

Linter could be a start (unused parameter). For e2e: routing for https service (see USHIFT-541)


chore: Add release notes for PR #11561

Overview
This adds release notes for PR #11561. This should merge into edge when PR #11561 merges into edge.
The internal-release_0.5.0 branch has already been cut off of edge, so it won't make it into that. I'm assuming it will make it into internal-release_0.6.0.
I also added a note to the public release notes file, because this seems like the kind of thing that would otherwise be easy for us to forget. Note that PR #11561 is a refactor, so it won't show up in the autogenerated changelogs.
Review requests

Is it correct to put this in the v0.6.0 internal release notes?
Is my "Update notes" subheading an okay place to put this, for now?

We decided to follow a different approach in https://github.com/Opentrons/opentrons/pull/11561#issuecomment-1526137525 that will have different caveats. I'll close this PR and note the new caveats in #11561.


Added a simple secretsmanager test that creates and fetches a secret.

hi @ausarb,
What would be the purpose of having this test? I would say the LocalStack team should test it, not us :)

I was following the pattern where SQS and S3 had a simple smoke test.  This will verify the basic plumbing between testcontainers-java and localstack secretsmanager works.  For example, if someone were to accidentally remove the secretsmanager from the org.testcontainers.containers.localstack.Service enum this test would then fail.

One reason for adding extra tests around Localstack is where our own code has scope to affect behaviour. For example I think S3 needs a test due to the fiddly nature of HTTP routing to the container; SQS needs a test because there is a queue URL concept that needs to work properly. Our getEndpointConfiguration method could, if broken, mess up both of these features.
I'm not too familiar with secrets manager, but are there similar risks for it? Otherwise I'd be inclined to agree with @bsideup.
(Either way though, thank you, for taking the time to contribute to #1504!)

I'm not aware of any bootstrapping type of work needed for secretsmanager.  I originally wrote this test in a fork of testcontainers-java that I made to get secretsmanager working, since I've got a current need for it.  When I saw #1504 and the tests in there I thought it would be a good home for this test.  Won't hurt my feelings if you'd rather not have it in there.
If you don't want the test in there, I'd suggest added a command inside SimpleLocalstackTest.java to hopefully avoid something similar.  If you'd like, I can take a stab at that.  "Only tests that should go here are for those services that require special Localstack specific code to work with that service.  For example, S3 needs a test to ensure special HTTP routing to the container works."

I've just pushed a change that reverted my test and put in a comment on what would require future tests.

@ausarb thank you - that's an excellent idea. Very easy to approve this one :)
Thanks for the contribution.


display user information - group 15

Is your feature request related to a problem? Please describe.
Currently, there's no way to search for other users to add them as friends in the app.
Describe the solution you'd like
I propose implementing a feature that displays user information when searching for users to add them as friends in the app. This feature should include elements such as user profiles, displaying information such as username, profile picture, mutual friends (if applicable), and any additional relevant details users choose to share.
Describe alternatives you've considered
One alternative could be displaying minimal information such as username and profile picture in the search results, with the option to view more detailed user profiles upon selection. Another alternative could be incorporating a preview feature that allows users to see a brief overview of the searched user's profile before adding them as a friend. Additionally, integrating a mutual friends feature could help users gauge their connection to the searched users and make more informed decisions about adding them as friends.

Description:
This feature involves the addition and implementation of a profile button
Expected Outcomes:
The expected outcome is to have a profile button at the bottom app bar and make the button take you to the profile page made by another team mate
Alternatives:
No alternative
Completeness Requirements:
Ensure that the profile button is on the bottom app bar
Ensure the button is displaying the correct icon
Ensure the button works when clicked

The button is successfully added and works perfectly. Issue is now closed.

The button is successfully added and works perfectly. Issue is now closed.


PHP7.4RC2 incompatibility

There were a couple of errors with PHP 7.4RC2.
Trying to access array offset on value of type null

Looks like this behavior was deprecated in 7.4.

Looks like this behavior was deprecated in 7.4.

It wasn't. Now that PHP 7.4 has been released I started to get the notice.

Waiting for this PR to be merged.
Any other way to handle it, please?

Waiting for this PR to be merged.
Any other way to handle it, please?

You can use the @ operator in the meanwhile.

Waiting for this PR to be merged.
Any other way to handle it, please?

I switched to https://github.com/thephpleague/commonmark which is very active

@erusev if you're in need of maintainers, I'd gladly volunteer to help triage/maintain things in this repo.


More information about boilerplate iosing

Hello wonderful React Native people!
I am proposing this change because it took me a frustratingly long time to see why my component wasn't rendering any children.
I feel like something like this would have helped me.
However, I may be an edge case as my first attempt at any React Native was doing a Navigator...
Your call! This is my feedback!

By analyzing the blame information on this pull request, we identified @janicduplessis and @katrinanova to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

What about we just set NavigatorIOS to have {flex: 1} by default. It doesn't really make sense to have a non-fullscreen navigator and we already do that for some components like ScrollView for example https://github.com/facebook/react-native/blob/master/Libraries/Components/ScrollView/ScrollView.js#L476.
cc @mkonicek

That would be even better and wouldn't pollute the readme with tangential info :)
My vote is for this to be a default setting on NavigatorIOS!
Thanks for such a speedy response :)

Setting flex: 1 by default seems reasonable. Can you update this PR or close this and send a new one please?

Sounds good @mkonicek :)
So, adding a flex: 1 to here?
Is what needs to be done? Will get right on it!

It's probably on this view: https://github.com/facebook/react-native/blob/master/Libraries/Components/Navigation/NavigatorIOS.ios.js#L698


API Error: Too Many Attempts

Describe the Bug
So I made a program which uses the API to periodically download my entire wiki as markdown, change URLs in pages to preserve interlinking, save it with git and generate a static site of the wiki with Hugo.
It downloads less than half the wiki and then all page downloads start erroring out with:
{"error":{"message":"Too Many Attempts.","code":429}}

I limited my concurrency to 10 page downloads at a time but its still happening. Any slower than that and it'll take hours to download my wiki.
Can I tweak the rate limiter ?
Steps to Reproduce
I'll put the entire code on github after cleaning it up but basically its downloading pages using /api/pages/<pageid>/export/markdown 10 at a time
Expected Behaviour
No rate limits when using the API, especially for admin users.
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
BookStack v22.04.1
PHP Version
No response
Hosting Environment
Linuxserver container image running on rootless Podman + mariadb from Rocky Linux repos

Hi @IceWreck,
You should be able to configure this rate limit by using adding the following options to your .env file then tweaking:
https://github.com/BookStackApp/BookStack/blob/ca09ed916f73ae53998703bfe0e3489798485971/.env.example.complete#L346-L347
It does look like we need to add this option to our documentation though since it's quite hidden right now.

Thanks. Its working now.


About integrating ixa-pipe-tok, pos and nerc and using them along with OpenNLP

First, thank you for your work on ixa-pipe!
I'm using ixa-pipe-* in a larger application along with OpenNLP.
I'd like to upgrade to the latest OpenNLP version but it appears that upgrading uniformeously to OpenNLP 1.8.0 breaks iixa-pipe-nerc (or pos).
In addition, ixa-pipe-tok and ixa-pipe-pos are not using the same version of the morfologik library from carrot2. (I could isolate the two versions with a jar dependency renaming tool though. But that does not work with OpenNLP because of its object factories)
Finally ixa-pipe-nerc depends on ixa-pipe-pos 1.5.1 but latest version is 1.5.2
Thus, my general question is how should we integrate ixa-pipe-* together within an application? And especially in an application using OpenNLP on its own.
Thank you very much in advance

Hello,
As you know, OpenNLP 1.8.0 is not backward compatible on some issues. I am working on a new version of IXA pipes and part of the work is to make them compatible with OpenNLP 1.8.0. This will hopefully be ready by the end of July (also the other dependencies issues you commented upon).
Thanks for your interest.
R

That is great news! I look forward getting your update.
Thank you so much!
Julien

Hi Rodrigo!
Sorry to bother you but when do you think you'll release the new versions of ixa-pipe-pos and ixa-pipe-nerc compatible with OpenNLP 1.8.0?
Thank you so much?
Julien

Hi Rodrigo,
Do you still plan to release the OpenNLP 1.8.0 compatible version of Ixa-pipes tools on Maven repo?
Thanks!
Julien

Yes,
but time is limited... :)
I will do it as soon as I can. Sorry for the delay and thanks for the
interest.
Rodrigo
On Mon, Nov 20, 2017 at 12:11 PM, Julien Martin<EMAIL_ADDRESS>wrote:

Hi Rodrigo,
Do you still plan to release the OpenNLP 1.8.0 compatible version of
Ixa-pipes tools on Maven repo?
Thanks!
Julien
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ixa-ehu/ixa-pipe-nerc/issues/13#issuecomment-345665247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZl_5-uFL2Yddcw-f_uuLrYtZRWdTn1ks5s4V5-gaJpZM4N7Hc-
.

Alright, that is good news! :)
And you're welcome, I do think your work deserves it.
Thank you
Julien

+1 on getting those compatible with latest OpenNLP version.  Appreciate your work!
If you happen to have a rough estimate of when you expect to be able to have these out, it would help us plan whether we wait for this or try to find an alternative way.  We're working on open source software also.

Hello,
I will work on this on January. It should not take me long.
Best,
R
On Thu, Dec 14, 2017 at 8:56 PM, Boris Capitanu<EMAIL_ADDRESS>wrote:

+1 on getting those compatible with latest OpenNLP version. Appreciate
your work!
If you happen to have a rough estimate of when you expect to be able to
have these out, it would help us plan whether we wait for this or try to
find an alternative way. We're working on open source software also.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ixa-ehu/ixa-pipe-nerc/issues/13#issuecomment-351818902,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZl_6IznYzeAl_jeqKBbh_yyZjnSo-gks5tAX14gaJpZM4N7Hc-
.

Hi there, how is it going? :)
Cheers,
Julien

Has this project been abandoned? Thanks.

Nope, I am just too busy with a new job, things are hapenning but no
release yet.
On Wed, 28 Nov 2018 at 18:20, Boris Capitanu<EMAIL_ADDRESS>wrote:

Has this project been abandoned? Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ixa-ehu/ixa-pipe-nerc/issues/13#issuecomment-442530485,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZl_4SELZMX7_xxsSLQcTBkCQpd1ifdks5uzsXZgaJpZM4N7Hc-
.


Add devcontainer.json

Problem
To set up an environment with the best Noir developer experience currently requires:

Manually search for and install the Noir Language Support
Manually install Nargo following the steps in the docs

Not the end of the world, but not the smoothest onboarding experience we could attain either.
Happy Case
A development container allows one to use a container as a full-featured development environment. Containers can be run locally or remotely, in a private or public cloud, and in a variety of supporting tools (e.g. VS Code, GitHub Codespace).
A devcontainer.json with settings that automatically:

Install the Noir VS Code extension
Fetch and initialize a docker instance with noirup and nargo readily available (once the below prerequisite is closed)

could greatly smoothen the onboarding experience of Noir developers.
### Pending
- [ ] https://github.com/noir-lang/noir/issues/3621

Having one here in this repository could serve as a recommended example that the community can copy into their Noir projects and ease developers working on such projects.
Alternatives Considered
No response
Additional Context
This, when paired with GitHub Codespace, could greatly minimize the friction of spinning up a cloud development environment instance.
There is a seemingly similar initiative in noir-lang/noir on https://github.com/noir-lang/noir/pull/3097. While we can certainly make reference to how it is written, that issue is gearing towards easing development on Noir itself while this issue focuses on easing development of Noir projects.
Would you like to submit a PR for this Issue?
No
Support Needs
No response

I love this, me or @critesjosh will give it a try ASAP

@Savio-Sou https://github.com/noir-lang/noir/issues/3621 is a blocker for this, correct?

@critesjosh blocker to item 2 (but not item 1) under Happy Case.


Update scala-library to 2.13.9

Updates org.scala-lang:scala-library from 2.13.8 to 2.13.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.13.8).
You might want to review and update them manually.
.github/workflows/ci.yml
zio-aws-codegen/src/main/scala/zio/aws/codegen/generator/GithubActionsGenerator.scala

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #988.


Add an employee cell copy with auto scaling policy

To test zero scaling policy, a copy of employee cell was created with auto scaling policy with minimum number of replicas zero.

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #471   +/-   ##
======================================
  Coverage    82.6%   82.6%
======================================
  Files          29      29
  Lines         891     891
  Branches       69      69
======================================
  Hits          736     736
  Misses        109     109
  Partials       46      46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6cc5e...1b225ac. Read the comment docs.


The space or hyphen (-) should be replaced with underscore (_) automatically in 'xx.consumption.cs' and 'xx.training.cs' files.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2022: <IP_ADDRESS>0401 (Main Build)
Microsoft Visual Studio Enterprise 2022: 17.1.3
.Net: 6.0
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window.
Choose the C# Console App (.NET Core) project template with .Net 6.0 and give the project name with space or hyphen (-).
Add model builder by right click on the project.
Choose a Scenario, Environment and Data.
Train the model complete;
Start debugging this project.
See error: the debug cannot continue because exist some code error in namespace area.

Expected behavior
Can debug the project successfully.
The space or hyphen (-) should be replaced with underscore (_) automatically in 'xx.consumption.cs' and 'xx.training.cs'
Screenshots
If applicable, add screenshots to help explain your problem.

Gif:

@zewditu Has this been addressed before?

This is not exactly, we had a similar issue in generated projects this is only for mbconfig behinds

The bug has been fixed on the latest main branch: <IP_ADDRESS>2101


@conda-forge-admin, please add bot automerge

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/mne-faster-feedstock#2.


How to show multiple tables in 1 page

Hi nacasha.
is possible to use this library to build multiple table in 1 page?
because i always use iframe to hotfix (shortcut) this issue.
thanks for advanced.

Sorry for being late to reply
i will add the feature as soon as possible, thanks for you suggestion

nah, just do that if you have free time only. i still can use manual script for another table.
anyway this library really help me alot. i never think that create datatables with CI will be so easier.
great job @nacasha

added 1631892

omg, you already do that. Great job man. i hope this repo will significant increase your CV


Add BN support to the test infrastructure.

[x] tests are added or updated

This includes support for:

comparisions between pairs of BIGNUMs
comparisions between BIGNUMs and zero
equality comparison between BIGNUMs and one
equality comparisons between BIGNUMs and constants
parity checks for BIGNUMs

And updated to an array.

I'm like to see a corresponding test suite in test/test_test.c

The test_dec2bn and test_hex2bn do a pretty good job stressing the various calls already, so I didn't include anything in test_test.c.  Still, I can add some.

test_test tests added.

The test_dec2bn and test_hex2bn do a pretty good job stressing the various calls already, so I didn't include anything in test_test.c.  Still, I can add some.

I just wanted to make sure there are some tests that guarantee that we get to see what a test failure looks like.  I don't trust the other tests to do so, even if they are good for the moment.

@richsalz, changes have been made, please reconfirm?

Seeing sample output is a good reason.  It won't be visible in other tests normally.
I'm toying with the idea of suppressing the output from test_test by default to reduce noise in the test output.  The failure output would be enabled using a command line option or somesuch.  I'm not convinced it is a good idea though...

reconfirm.  please merge.

I'm toying with the idea of suppressing the output from test_test by default to reduce noise in the test output.  The failure output would be enabled using a command line option or somesuch.  I'm not convinced it is a good idea though...

It's not.  We are, after all, asking for verbosity.  The test harness redirects the recipes' stdout and stderr to /dev/null when running non-verbose, so...

Merged.  dc352c193755525292310c8992e3c9b81a556a31 and 03d8e9cb43da5c524e5890a5a51e2c77f1fbd789


PASE CLI enhancements

better error reporting
allow setting of the control and IPC; control was significant as SSH/local transports had no way to control the behaviour of XMLSERVICE (i.e. *cdata)

Question period:

What's with the CCSID stuff there? We're assuming 1208 (probably for the best), but the EBCDIC CCSID is set to 0.
I'm assuming the 64-bit stuff not working is because of 32-bit PASE requirements somewhere in XMLSERVICE from skimming issues, but why/where?

Can you split out the error reporting to a separate PR? Because of the use of stdin/stdout in xmlservice-cli, I think that needs more contemplation in how the error messages will affect it.
Otherwise, I think the changes look good.

What's with the CCSID stuff there? We're assuming 1208 (probably for the best), but the EBCDIC CCSID is set to 0.

0 is job CCSID. If that's useful to change, maybe we could add another option for that? Unfortunately, we're going to conflict on -c for ctl/ccsid then. (Maybe -e for "ebcdic" or "encoding"?)

I'm assuming the 64-bit stuff not working is because of 32-bit PASE requirements somewhere in XMLSERVICE from skimming issues, but why/where?

https://github.com/IBM/xmlservice/issues/17
https://github.com/IBM/python-itoolkit/blob/main/docs/api.rst#direct-memory-transport
At the time, we didn't want to depend on the PTF being installed and the bitness of xmlservice-cli doesn't really matter unless you're trying to call in to PASE from whatever ILE code you're calling through XMLSERVICE. Is a 64-bit version something you want/need?

Can you split out the error reporting to a separate PR? Because of the use of stdin/stdout in xmlservice-cli, I think that needs more contemplation in how the error messages will affect it.

I've tried to make sure error messages only get written to stderr. I think if something is conflating both output and error, something's wrong with it - besides, it'd have been broken if it got to a point where cli was printing to stderr anyways.

0 is job CCSID. If that's useful to change, maybe we could add another option for that? Unfortunately, we're going to conflict on -c for ctl/ccsid then. (Maybe -e for "ebcdic" or "encoding"?). I'm personally think UTF-8 is the only sensible PASE encoding to use and wouldn't want to add an option to change it, unless someone provided a very strong use-case.

Yeah, I think the default PASE CCSID is fine. I'd suggest maybe using cl builtin in bash and calling chgjob ccsid(n) might be OK for job CCSID, but perhaps inconvenient for i.e. SSH transports.

At the time, we didn't want to depend on the PTF being installed and the bitness of xmlservice-cli doesn't really matter unless you're trying to call in to PASE from whatever ILE code you're calling through XMLSERVICE. Is a 64-bit version something you want/need?

I was looking into calling XMLSERVICE from 64-bit PHP. cli does make a useful testbed to see if it'd even work. The PTF or building the latest XMLSERVICE from source didn't seem to change anything, so I wonder if it actually fixed it or not.

I'd suggest maybe using cl builtin in bash and calling chgjob ccsid(n) might be OK for job CCSID, but perhaps inconvenient for i.e. SSH transports.

So if I understand this, you're suggesting that if the user wanted to change the XMLSERVICE EBCDIC CCSID, they could use the bash builtin to change the job CCSID prior to calling xmlservice-cli and we wouldn't have to add a parameter?

I was looking into calling XMLSERVICE from 64-bit PHP. cli does make a useful testbed to see if it'd even work. The PTF or building the latest XMLSERVICE from source didn't seem to change anything, so I wonder if it actually fixed it or not.

You're looking at making a PHP equivalent of DirectTransport I take it? It should be working, since otherwise DirectTransport wouldn't work. If you want to verify that the PTF has resolved the issue, you can try testing with it.

So if I understand this, you're suggesting that if the user wanted to change the XMLSERVICE EBCDIC CCSID, they could use the bash builtin to change the job CCSID prior to calling xmlservice-cli and we wouldn't have to add a parameter?

Yeah, although it'd mean bash overhead every time you'd want to do it.

You're looking at making a PHP equivalent of DirectTransport I take it? It should be working, since otherwise DirectTransport wouldn't work. If you want to verify that the PTF has resolved the issue, you can try testing with it.

I have the source for it, but I haven't had luck with getting it to work even with xmlservice master (since I'm unsure if the system I was developing on had it applied to system xmlservice); I think the PTF might not have fixed it as a result.

If you're curious about said code: https://github.com/SeidenGroup/php-ibmi/blob/xmlservice/xmlservice.c
Unfortunately, it just gets 0xF1 return (so, true), but comes back with empty strings - seemingly what I get if I build xmlservice-cli as 64-bit too. It's been a while since I looked into this, so the details are fuzzy here.

Ok, I think things look fine. Can you make the const/style change and appease the DCO bot?

The variables should be const (though C isn't as picky as C++ in this regard it seems). Can you also merge the two commits please?

Working on it


Sending several notifications just shows the last one

Hi,
I've tried sending several notifications to an Android device but only the last one is displaying. Is it possible to generate more than one notifications, or at least increase the badge number for android notifications?

add  notId while sending Push.send
ex ;  Push.send({
from: 'Test',
title: 'Hello Demo',
text: 'Hello dude ',
gcm: {
style: 'picture',
summaryText: 'The internet is built on cat pictures'
} ,
query: {} ,
notId: id
});

add  notId while sending Push.send
ex ; Push.send({
from: 'Test',
title: 'Hello Demo',
text: 'Hello dude ',
gcm: {
style: 'picture',
summaryText: 'The internet is built on cat pictures'
} ,
query: {} ,
notId :  id
});

@ omsharma007 Thanks


Send initial state is always true when node red starts?

No matter what I do, if Nodered restarts, alarm is always set to "armed Home" even If the state of the alarm was "Disarmed" before restart. its always "Home".
I have tried to uncheck "send initial state" box, but still logs show:
"initialState": true,
"payload": {
"SecuritySystemCurrentState": 0,
"alarmState": "Home",
"SecuritySystemAlarmType": 0,
"isAlarm": false
}
}
Tried to change or set msg.initialState message to false or to "0" value with a change node to make it restart with "Disarm", still every time it arms itself to "Home".
Coud you please help me figure this out? It would be good if it remembered the last state of the alarm and set it at the restart instead of always arming "Home".

Please confirm you are saving global context.
Please refer to : https://nodered.org/docs/user-guide/context#saving-context-data-to-the-file-system
The alarm state is stored in global context and you therefore need to save global context to disk to survive restarts.

Please confirm you are saving global context.
Please refer to : https://nodered.org/docs/user-guide/context#saving-context-data-to-the-file-system
The alarm state is stored in global context and you therefore need to save global context to disk to survive restarts.

I don't think I save it.
Unfortunately I don't know have much experience with these and don't know coding so I just follow instructions most of the time to solve issues.
How would I save global context? Contrib-alarm nodes don't have a section to write a JSON.
Do I put a change node after a specific node and write a JSON there?
If you could guide me how and where to do it I will be grateful.

I figured out how to write to global.js or flow.js but for the love of god nothing works. I am beyond pissed. I put a change node after "state changed" and write msg.payload to global.initialState, I go double check global.js and its in there but after nodered restart never sends what's in file. Keeps sending
"SecuritySystemCurrentState": 0
"SecuritySystemAlarmType": 0     after every restart. There isn't even such entry in /context/global.js file. no such thing exists but still keeps sending it as an initial state.
I tried to even catch the initial state message with switch node, separate it and put a change node to change it with what's written in file ( "SecuritySystemCurrentState": 3) but still doesn't work.
Even if I uncheck "send initial state" from the node, it still keeps restarting with "armed home" and logs still show
"initialState": true,
"payload": {
"SecuritySystemCurrentState": 0,
"alarmState": "Home",
"SecuritySystemAlarmType": 0,
"isAlarm": false
}
}
Spent literally 10h on this today and really need help.

Hi, sorry to hear you have had such an issue.
Writing manually to the global state is not required, the nodes manage that for you.
By default mode-red only stores global state in memory, so a reboot will not persist anything. So even if you use a node to write to disk, it won’t know to read from disk on reboot.
You need to alter the node red configuration to tell it to persist on disk, and remove the node you added to write to disk.
You need to set this option in your settings.is:
contextStorage: {
storeName    : { module: "localfilesystem" }
},
More information: https://discourse.nodered.org/t/a-guide-to-understanding-persistent-context/4115
Let me know if that does not resolve your issue.
Sent from my iPhone

On 8 Feb 2021, at 9:54 am, warfanax<EMAIL_ADDRESS>wrote:

I figured out how to write to global.js or flow.js but for the love of god nothing works. I am beyond pissed. I put a change node after "state changed" and write msg.payload to global.initialState, I go double check global.js and its in there but after nodered restart never sends what's in file. Keeps sending
"SecuritySystemCurrentState": 0
"SecuritySystemAlarmType": 0 after every restart. There isn't even such entry in /context/global.js file. no such thing exists but still keeps sending it as an initial state.
I tried to even catch the initial state message with switch node, separate it and put a change node to change it with what's written in file ( "SecuritySystemCurrentState": 3) but still doesn't work.
Even if I uncheck "send initial state" from the node, it still keeps restarting with "armed home" and logs still show
"initialState": true,
"payload": {
"SecuritySystemCurrentState": 0,
"alarmState": "Home",
"SecuritySystemAlarmType": 0,
"isAlarm": false
}
}
Spent literally 10h on this today and really need help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I already entered that in settings. No problem with that. I even have a drop down menu now to select memory or file if you choose "flow" or "global", means I entered it correctly.
If I don't have to write to memory myself then I don't know what to do?

node-red-contrib-alarm uses "default" global state, so please confirm you
have this exactly in your settings.js:
contextStorage: {

    default: {

        module: "localfilesystem"

    }

},

If not, please make sure it does and test again, you should see that if the
state changes on the alarm system, the global persisted state file on disk
should change within about 30 seconds. It uses the "default" context
storage for loading the state on restart.
If this is definitely not working for you, can you post any errors that
might be getting thrown? Maybe something else is getting in the way.
On Tue, Feb 9, 2021 at 9:02 AM warfanax<EMAIL_ADDRESS>wrote:

I already entered that in settings. No problem with that. I even have a
drop down menu now to select memory or file if you choose "flow" or
"global", means I entered it correctly.
If I don't have to write to memory myself then I don't know what to do?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Anamico/node-red-contrib-alarm/issues/19#issuecomment-775521412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGHK2LH5UHTN4AX73AITEQTS6BUR3ANCNFSM4XE6KCJQ
.

Alarm was set "off" for a while (not less than 30sec) and I just restarted Nodered and its set to "Home" again by itself. Here are Nodered restart log  and my settings.js entry:

where is the state exactly saved? I can't find it in:
/config/node-red/context/global/global.json

Ok found the problem and I think it is almost solved.
In my entry "default" location was memory. Although when I first tried the entry with "localfilesystem" as being default, it never worked. I changed it to what is it now when playing with change nodes.
I made localfilesystem default now and I can see the global.js entry as "SecuritySystemCurrentState": 3.
After the restart log shows the "SecuritySystemCurrentState": 3. Great! I am very grateful for your help!
However there is one minor problem.After bordered restart iOSHome app shows the alarm as constantly stuck at "arming home". Only after the restart. iOS Home app displays the correct state changes any other time.
Seems like initial state message doesn't have "target state" and if I am not mistaken it is the one that sets the Home app icons display correct state. Do you have any idea how can this be fixed?

Seeing the same issue and it does come down to when the state is loaded from the localfilesystem the "SecuirtySystemtTargetState" is not loaded on a node-red restart and only "SecuritySystemCurrentState" is loaded. That causes Homekit and the UI to go to "arming..." state and not finalize. The code needs to be changed to send both states on restart of node-red and it will be fixed.

I modified the callback in panel.js in .node-red/node_modules/node-red-contrib-alarm/alam/panel.js to be the following:

By uncommenting the "SecuritySystemTargetState" area and using the exact same variable to set it to the same setting as Current State I am able to maintain system status across restarts of node-red without issue now.

wow. That was it. Amazing. Thank you so much for the fix!!!

rolled in to 1.2.5


You Made the Demo Worthless

By putting the 3 videos all together you made this project worthless for anyone wanting to use it. Why bother even going open-source

what's that mean


How to make a custom mask

I'd like to make a mask to only accept 10 digits in a input, how could I do it?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29690757-how-to-make-a-custom-mask?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github).

We do not have a generic mask that can be parametrized yet.
A pull request with this feature will be welcome.

Hello, anyone implemented a custom mask?
Thanks


Increase memory available on Windows

Prevents Memory Exhausted problems in some cases. See #11390 et al.

Could you please it wrap it for x86 only? Will be useful in future. Thanks!

@Vitallium  I'm not sure what you're asking.

@mepard nvm. I thought that this option should be disabled for 64-bit. But according to this, it's enabled by default.
Sorry for bothering you! I'll merge it in a few minutes.

Landed in https://github.com/ariya/phantomjs/commit/4f48c360c65046f111477b4a0ee168d4c3ca32a8
Thank you!


CLI: more metadata for get-aqs

This adds a few more site metadata fields, including CBSA name, state abbreviation, and EPA region.
cc: @btang1

@btang1 sites where city name is "Not in a city" might be a good rural indicator.

Current CI failures related to NCEI websites being down.

@btang1 did you end up trying this out?

@btang1 did you end up trying this out?

I will try it later today or tomorrow @zmoon

Yeah this is on my fork's branch cli-aqs-meta.

Yeah this is on my fork's branch cli-aqs-meta.

Is it in Monet? or Monet io?

Yeah this is on my fork's branch cli-aqs-meta.

Is it in Monet? or Monet io?

ok. I found it! it is in your melodies-monet. let me test it quick!

Yeah this is on my fork's branch cli-aqs-meta.

Hi Zach, I tested and it works!!!

I can find new variables you mention in so2 data from AQS.

@zmoon


Deprecate the Api keys

Deprecate the API Keys functionality as this has been superceeded by the key directory and also moving to a static token for admin auth.

:heavy_check_mark: correct


Cleanup DLP Inspect snippets.

Clean up of DLP Inspect snippets.
Addresses #1479.

There are also some tests outside of the InspectTests and RedactTests still failing. Will continue to fix in separate PRs.


subquerying a query that selects a literal atom value is broken

Environment

Elixir version: 1.13.1
Database and version: PostgreSQL 13.4
Ecto version: Ecto 3.7.2, Ecto SQL 3.7.2
Database adapter and version: Postgrex 0.16.2
Operating system: macOS 12.2.1 (21D62)

Current behavior
Looking back at the Ecto changelog from release 3.5.0, it looks like the ability to have literal atom values within queries was added in Ecto 3.5:

[Ecto.Query] Allow atoms in query without interpolation in order to support Ecto.Enum

I seem to have found a case where this doesn't work correctly. If I select from a table with a literal atom value:
from tt in "test_table", select: %{test: tt.test_column, literal_value: :value}

The generated query looks like this:
SELECT t0."test_column" FROM "test_table" AS t0

It looks like literal_value select is excluded, which I assume is because it will later be merged back into the results, since running the query yields rows with atom values as expected. The issue comes when this query is passed to subquery:
subquery(from tt in "test_table", select: %{test: tt.test_column, literal_value: :value})

The generated SQL attempts to select the literal atom value as a field from the subquery:
SELECT s0."test", s0."literal_value" FROM (SELECT st0."test_column" AS "test" FROM "test_table" AS st0) AS s0

Which breaks when trying to run the query:
** (Postgrex.Error) ERROR 42703 (undefined_column) column s0.literal_value does not exist

Expected behavior
Either:

Querying with a literal atom values should work in all circumstances, even within a subquery. (Preferable)
Querying with a literal atom values should be banned in subqueries (like maps, lists, tuples and sources).

Can you please try master? I remember tackling some related issues recently.

I changed my mix.exs to use the master branch for both ecto and ecto_sql:
# ...
{:ecto, git: "git@github.com:elixir-ecto/ecto.git", branch: "master", override: true},
{:ecto_sql, git: "git@github.com:elixir-ecto/ecto_sql.git", branch: "master", override: true},
# ...

And I confirmed that ecto and ecto_sql both resolved to the latest commit in both repos in my mix.lock (https://github.com/elixir-ecto/ecto/commit/5537422e567a100bb5e5dc60ff4a10865c7cfc16 and https://github.com/elixir-ecto/ecto_sql/commit/5a2d7e00dc140996b543cdc55c587f0dd93bbac4). The issue still occurs in exactly the same way.


Missing mutable colorization in Visual Studio

Currently Visual Studio shows mutable variables and mutation in different color (yellow in dark theme) like in code below foo is colored yellow

But lst.[0] <- is not colorized

Same problem here

Would it be possible to also colorize known mutable methods? like example. System.Collections.Generic.List's Add, Remove Sort
This might be a huge list or different types and methods, so i'm not sure if it's feasible.
Related information
Provide any related information

Operating system
Windows 10 64bit
.NET Runtime, CoreCLR or Mono Version
CoreCLR 2.1.4
Editing Tools (e.g. Visual Studio Version)
Visual Studio 2017 15.5.6
Indications of severity
Not severe

This is a bit tricky. The colorizer is for mutable bindings, which means that it's technically fulfilling its role here. Although the contents of the array foo3 can change, foo3 itself will always refer to that array.
Colorizing all things whose contents could be mutated is tricky. That would require all classes which hold values that can change to be colored in this manner as well - this is tricky because you're now also differentiating between objects whose contents can change and objects whose contents cannot. This was discussed briefly in #3455, but it wasn't clear what the takeaway was.

Ok then working as intended. Thanks for info! I'll close this.


report: Downsample time series in plot reporter

This commit introduces timeseries downsampling in the plot reporter
with the aim to be performant even with very large result sets.
Fixes #137
TODO:

[ ] Parameterise downsampling threshold in the reporter command CLI.

Here's a visual representation of the effect of this change set. As for the performance effects, you can test by downloading the attached HTML files and opening each of them.
Plot Reports
Before

After


Bidirectional table of strings/numbers can be shared.

Then a JsonTree would be just a seq[Node] with either an extra ref field or a hidden argument passed to all the procs.
Pros:

LitId's are sufficient to check for equality since they're global.

Cons:

Difficult to manage lifetimes of the stored entries
May grow large
Difficult to multithread

meh.


Scope dependency is upgraded by major after install

When installing connectkit using a newly created generator, one of the scope dependencies is bumped a major.

This does not happen when using the same generator instance between installs, but due to our worker setup at Framer we are not able to share the same generator instance, which leads to this bug.
Repro using @jspm/generator beta.35:
(This does not happen in beta.31)
import { Generator } from "@jspm/generator";

const RESOLUTIONS = {
  "@react-three/fiber": "7.0.27",
};

const PROVIDED_DEPENDENCIES = new Set([
  "react",
  "react/jsx-runtime",
  "react-dom",
  "react-dom/server",
  "framer",
  "framer-motion",
  "framer-motion/three",
]);

const BASE_CONFIG = {
  mapUrl: "about:blank",
  ignore: Array.from(PROVIDED_DEPENDENCIES),
  env: ["production", "browser", "module"],
  resolutions: RESOLUTIONS,
};

async function Repro() {
  const generatorOne = new Generator(BASE_CONFIG);

  await generatorOne.install("@react-three/fiber");
  console.log(generatorOne.getMap().scopes["https://ga.jspm.io/"].zustand);

  const generatorTwo = new Generator({
    ...BASE_CONFIG,
    inputMap: generatorOne.getMap(),
  });

  await generatorTwo.install("wagmi");
  console.log(generatorTwo.getMap().scopes["https://ga.jspm.io/"].zustand);

  const generatorThree = new Generator({
    ...BASE_CONFIG,
    inputMap: generatorTwo.getMap(),
  });

  await generatorThree.install("connectkit");
  console.log(generatorThree.getMap().scopes["https://ga.jspm.io/"].zustand);
}

Repro().catch((e) => console.error(e));

I managed to track down the issue here, and it's an interesting edge case. Unfortunately won't get a fix together today, but we can definitely get one through by Monday / Tuesday next week.

amazing, thank you!

Turned out to be a big and important reworking, thanks for sharing the case. Fix released in 1.0.0-beta.36.


Revert "Add link to user start page in logo image".

Revert https://github.com/ManageIQ/manageiq/issues/11664 until a more performant solution is found.
Ping @chrisarcand, @kbrock .

:+1: LGTM. @chrisarcand ?

IMO the savings of 1.7% of the load time seems like a pretty minor regression to care about, at least without just implementing a faster way instead of straight up removing. Still, there's certainly a better solution that can be done here so... alrighty. 👍

@chrisarcand  : sorry, I am busy with other stuff to fix in a better way for now :-( But I'll keep that on my TODO list.

Euwe Backport details:
$ git log
commit da8cad02e568bdde3889f2493f7c0dc080f31c85
Author: Chris Arcand<EMAIL_ADDRESS>Date:   Tue Oct 4 09:03:23 2016 -0500

    Merge pull request #11675 from martinpovolny/revert_start_url

    Revert "Add link to user start page in logo image".
    (cherry picked from commit 959232821e713c7f80dfab412b0447997e438034)


[$30] Nice to have: Changes for Working Days field

Description:

Currently if we change the daysWorked for a resource, there is no way to ensure it's changed except refreshing. can we add a green colour blink or some checkmark near the field to denote it is updated to the server?

Also is it possible to add some form of warning for the user to know that if the daysworked set (if user sets the days) for the first, second of first, last and second of last WP's are subjected to change if there is Change in the Resource Booking dates? Otherwise if user sets daysworked and then if RB dates changed, the daysworked will also be changed. User won't be aware of it.

Also is it possible to add some form of warning for the user to know that if the daysworked set (if user sets the days) for the first, second of first, last and second of last WP's are subjected to change if there is Change in the Resource Booking dates? Otherwise if user sets daysworked and then if RB dates changed, the daysworked will also be changed. User won't be aware of it.

@sandhiyakavi I think if we add some message for the first and last WPs it would be not enough. Because if we change RB dates for example in half, then half of the WPs would be removed and WP which would be the new last/first one, would be also updated, even though, before it was in the middle.
So far I don't see a good solution for such edge cases. I think what we can do, is log this issue separately, and we could try to discuss it with Will or other end users of the TaaS Admin App. We could learn from them their usage patterns, or maybe they would have some idea regarding this, how do they feel would be natural for them.

Sum up:

For now we would only implement the first part of this issue.
When we change Working Days, we send the API request to the server. If request failed, we already show the error toastr.

if the request is successful we have to indicate it by showing the green checkmar in the green circle with some animation, for example this one https://codepen.io/kuvinod5/pen/WNvzazr

but use our green color #137D60

this checkmark should be show next to the Wokring Days input field like this

after 2 seconds (this time should be configurable) this checkbarm should fade away.

@maxceem Currently if we try to increase WorkingDays beyond its fitting to the RB dates,error message is getting displayed but if we try to again change it back to its previous number(without refreshing), the green tick mark is getting displayed which should not happen as the number is not changed in this case.
https://user-images.githubusercontent.com/55895538/124448821-cd6d9380-ddbd-11eb-917c-562ea955b25c.mp4

@sandhiyakavi this is a bit tricky issue.
The reason for this, when we increase the number it send to the server and gets error, but visually, the number stays as increased. When we decrease it back to previous value we send request to the server again, and this time server returns success - actually value is not changed we just send request to set the same value which is already there.
So the green tick kind of works correctly, it is shown when request is successful.
I'm not sure how it would be better to handle such case if error happened, but if you think we should do something about, I suggest logging a separate issue for this case.

Verified on Dev Env. Working as expected.

Paid via https://www.topcoder.com/challenges/dd90e9bb-eff7-4cbe-aa67-0c3791379de0

Verified on Prod Env with @nkumar-topcoder


Update request: warp-terminal 0.2<IP_ADDRESS>.02.stable_03 → 0.2<IP_ADDRESS>.49.stable_00

Package name: warp-terminal
Latest released version: 0.2<IP_ADDRESS>.49.stable_00

Current version on the unstable channel: 0.2<IP_ADDRESS>.02.stable_03
Current version on the stable/release channel: 0.2<IP_ADDRESS>.02.stable_02

[x] Checked the nixpkgs pull requests

Notify maintainers
@emilytrau
@imadnyc
@DontEatOreo
@johnrtitor

Note for maintainers: Please tag this issue in your PR.

Hey @ProxyVT warp-terminal is already updated to 0.2<IP_ADDRESS>.49.stable_00 on Oct 24, 2024, you can find the PR here: https://github.com/NixOS/nixpkgs/pull/350987
You can track when it's going to arrive to unstable over here: https://nixpk.gs/pr-tracker.html?pr=350987

Hey @ProxyVT warp-terminal is already updated to 0.2<IP_ADDRESS>.49.stable_00 on Oct 24, 2024, you can find the PR here: #350987
You can track when it's going to arrive to unstable over here: https://nixpk.gs/pr-tracker.html?pr=350987

Oh sorry, my bad. Should be more careful next time)


Support listing and creating Notes in merge requests.

Could you add a test for the serialisation of notes?