add keep-dispositions options to audio and subtitles

Is your feature request related to a problem? Please describe.
Foreign language films that don't have eng audio streams get stripped of all audio.
Describe the solution you'd like
An option to always keep the default disposition.  The ideal way would be a keep-dispositions option analogous to the ignore-dispositions option.

allow-language-relax is probably what you want

Not really, no.  If I've got a file with a few different dubs, I don't want all of them.  I just want the default one, which should hopefully be the native one for the video.

Solved with 501fcf3

Actually, it's only partly complete, I spoke to soon.
If I have set languages = eng, the file contains audio jpn +default and eng -default.  jpn will get deleted.  I'd like to keep it because it's +default.
I know you're busy for the next few days.  The more I think about this, the more I'm thinking it might just be easier to let sma do downmixing, not touching anything else, and then run a post process script to fetch subtitles, delete unwanted audio/subs etc, but then sma is so so close to being able to do it all.  I haven't programmed in over a decade, I'm an algorithm/logic/design type person now, or I would try and help.

c9b6aca8ff6ccb30ee429b066720b5b23af5ca74
Put that together real quick, see if that works
Added a force-default option for audio and subtitle that will bypass the usual language/disposition/unique checks if a stream is marked as default

Sorry, ended up being busier than I thought the past few days myself!
sdfg@heracles ~/scratch $ sma -i Ghost\ in\ the\ Shell\ 2.0\ \(2008\)\ \[imdb-tt1260502\]\[Bluray-1080p\]\[DTS-ES\ 6.1\]\[x264\]-MOOVEE.mkv
Manual processor started.
Python 64-bit 3.10.6 (main, Aug  3 2022, 17:39:45) [GCC 12.1.1 20220730].
Guessit version: 3.4.3.
/usr/bin/python3
Loading config file /home/askesis/sickbeard_mp4_automator/config/autoProcess.ini.
Processing file Ghost in the Shell 2.0 (2008) [imdb-tt1260502][Bluray-1080p][DTS-ES 6.1][x264]-MOOVEE.mkv
Input Data
{
    "format": "matroska,webm",
    "format-fullname": "Matroska / WebM",
    "video": {
        "index": 0,
        "codec": "h264",
        "bitrate": 9756363,
        "pix_fmt": "yuv420p",
        "profile": "high",
        "fps": 23.976023976023978,
        "framedata": {
            "pix_fmt": "yuv420p",
            "side_data_list": [
                {
                    "side_data_type": "H.26[45] User Data Unregistered SEI message"
                }
            ]
        },
        "dimensions": "1920x1080",
        "level": 4.1,
        "field_order": "progressive"
    },
    "audio": [
        {
            "index": 1,
            "codec": "dts",
            "bitrate": 768000,
            "channels": 7,
            "samplerate": 48000,
            "language": "jpn",
            "disposition": "+default-dub-original-comment-lyrics-karaoke-forced-hearing_impaired-visual_impaired-captions"
        },
        {
            "index": 2,
            "codec": "dts",
            "bitrate": 768000,
            "channels": 7,
            "samplerate": 48000,
            "language": "eng",
            "disposition": "-default-dub-original-comment-lyrics-karaoke-forced-hearing_impaired-visual_impaired-captions"
        }
    ],
    "subtitle": [
        {
            "index": 3,
            "codec": "subrip",
            "disposition": "+default-dub-original-comment-lyrics-karaoke-forced-hearing_impaired-visual_impaired-captions",
            "language": "eng"
        }
    ],
    "attachment": []
}
Reading video stream.
Video codec detected: h264.
Pix Fmt: yuv420p.
Profile: high.
Video codec parameters None.
Creating hevc_nvenc video stream from source stream 0.
Reading audio streams.
The following stream indexes have been identified as being copies: [] [stream-codec-combinations].
Audio detected for stream 1 - dts jpn 7 channel.
Unable to generate options, unexpected exception occurred.
Traceback (most recent call last):
  File "/home/askesis/sickbeard_mp4_automator/resources/mediaprocessor.py", line 123, in process
    options, preopts, postopts, ripsubopts, downloaded_subs = self.generateOptions(inputfile, info=info, original=original, tagdata=tagdata)
  File "/home/askesis/sickbeard_mp4_automator/resources/mediaprocessor.py", line 858, in generateOptions
    self.log.debug("Audio stream %s is flagged as default, forcing inclusion [Audio.force-default]." % (s.index))
UnboundLocalError: local variable 's' referenced before assignment
There was an error processing file Ghost in the Shell 2.0 (2008) [imdb-tt1260502][Bluray-1080p][DTS-ES 6.1][x264]-MOOVEE.mkv, no output data received

e9f15183f89b90f083226f03c5cf953da52638d4
That should fix that

Ok I didn't forget about you
https://github.com/mdhiggins/sickbeard_mp4_automator/tree/ffsubsync
This branch is the one I'm working on, still testing the ffsubsync stuff but I also included a force option, manually filtering subliminal results for forced subtitles if the option is enabled

Oh I don't expect anything instantly, please don't think that!  I very much appreciate any effort you put into this.
I've been finding that a number of my media files have multiple different language tracks all labelled +default, which is infuriating.  I'm actually playing with the idea of fetching the 'original language' data from TMDB API instead of relying only on what is in the file itself.  I also realise it's probably getting way out of scope for this project XD

Hm that's actually probably easily doable, I'll look into things
Either way the above branch at least gives you the option for forced subtitles through subliminal so give that a try

https://github.com/mdhiggins/sickbeard_mp4_automator/commit/6112f2a4d88cf2b9e07c015777c53e2bdafa94a7
How's that

Just checking in again to see if you got a chance to test these changes

302fa7ec388036b91a3cae1688a867e2e76aea36
Tweak the forced option so you can download both forced and standard

Sorry, I was on holiday!  Just catching up now.
First attempt:
askesis@heracles ~/scratch $ sma -i Ghost\ in\ the\ Shell\ 2.0\ \(2008\)\ \[imdb-tt1260502\]\[Bluray-1080p\]\[DTS-ES\ 6.1\]\[x264\]-MOOVEE.mkv
Manual processor started.
Python 64-bit 3.10.6 (main, Aug  3 2022, 17:39:45) [GCC 12.1.1 20220730].
Guessit version: 3.4.3.
/usr/bin/python3
Loading config file /home/sdfg/sickbeard_mp4_automator/config/autoProcess.ini.
Processing file Ghost in the Shell 2.0 (2008) [imdb-tt1260502][Bluray-1080p][DTS-ES 6.1][x264]-MOOVEE.mkv
Unable to generate options, unexpected exception occurred.
Traceback (most recent call last):
  File "/home/sdfg/sickbeard_mp4_automator/resources/mediaprocessor.py", line 134, in process
    options, preopts, postopts, ripsubopts, downloaded_subs = self.generateOptions(inputfile, info=info, original=original, tagdata=tagdata)
  File "/home/sdfg/sickbeard_mp4_automator/resources/mediaprocessor.py", line 662, in generateOptions
    awl, swl = self.safeLanguage(info, tagdata.tmdbid, tagdata.mediatype)
AttributeError: 'NoneType' object has no attribute 'tmdbid'
There was an error processing file Ghost in the Shell 2.0 (2008) [imdb-tt1260502][Bluray-1080p][DTS-ES 6.1][x264]-MOOVEE.mkv, no output data received
✓ 0 [843ms]

Figured out it was because tag = False, but might need a catch for that.  Continuing tests...

How do I enable debug mode?  I see a lot of self.log.debug in the code but don't see how to enable it to check stuff.
I've spent a lot of time adding the new config options and trying to figure out the combinations to use, and I have a few suggestions.
Separate out the languages from the technical codec stuff.  Streamline the language/disposition options.
[Audio.Tracks]
languages = original,jpn,fre,ita,default,nor
dispositions = default,dub,comment
maximum-tracks-per-language = 1
maximum-tracks-total = 3
at-least-one-track = True

languages and dispositions are ordered.  Then you can do a loop like this (it's been a very long time since I've done any pseudocode, please be kind!)
for each language in languages
    for each disposition in dispositions
        if exists language.disposition
            add language.disposition to track list
            current-language-track-count++
            current-total-track-count++
        if current-language-track-count == maximum-tracks-per-language
            break
    if current-total-track-count == maximum-tracks-total
        break
if maximum-tracks-total == 0 && at-least-one-track
    add first language.disposition in original file

By my reckoning you could then get rid of these:
[Audio]
include-original-language - covered by languages
first-stream-of-language - covered by maximum-tracks-per-language
allow-language-relax - covered by languages and at-least-one-track - maybe don't even need the at-least-one-track, make that built in
relax-to-default - covered by languages
ignored-dispositions - covered by dispositions
force-default - covered by languages
unique-dispositions - covered
Similar kind of thing for subtitles - technical stuff (burning, embedding, codec etc) in the main bit, then:
[Subtitle.Tracks]
languages = original,jpn,fre,ita,default,nor
dispositions = forced,default,hearing_impaired,comment
maximum-tracks-per-language = 2
maximum-tracks-total = 2

Use a similar loop as above (except including a search in subliminal for each combination as well)
for each language in languages
    for each disposition in dispositions
        if exists language.disposition
            add language.disposition to track list
            current-language-track-count++
            current-total-track-count++
        else
            subliminal search for language.disposition
            if downloaded language.disposition
                add language.disposition to track list
                current-language-track-count++
                current-total-track-count++
        if current-language-track-count == maximum-tracks-per-language
            break
    if current-total-track-count == maximum-tracks-total
        break

Then you can get rid of
[Subtitle]
default-language
include-original-language
first-stream-of-language
ignored-dispositions
force-default
unique-dispositions

[Subtitle.Subliminal]
download-forced-subs
include-hearing-impared-subs

I just think there are a lot of true/false options that can be difficult to follow when in combination with each other (forced,default,relax etc).  With these changes a user knows at a glance what the priorities and limits are without having to create a semantic tree to figure it out!

8fb1022d5945c7f0ec26d083737d5669d0ed9f75
Fixes the error from your last post
Reworking all the audio and subtitle options would be a big undertaking, challenging to maintain backwards compatibility, and I think personally a disposition whitelist approach is not a great one.
Disposition and language data is very often lacking and unreliable, inconsistently implemented across different containers (quick example is that mp4 containers don't even store a 'forced' flag), and not really consistent with what I've found most users over the years are looking to do with this automation step. Lots of media will have no positive disposition flags or will just inappropriately flag all dispositions as default. From my experience most users are looking to preserve what is there and only explicitly eliminate what they know they don't want when taking an approach to media automation. I do think I can probably eliminate some of the options added by your recent feature requests (relax to default being the first one to drop) to make things clearer but I probably would not look to rewrite the whole settings approach unless there was a compelling reason.
Debug logging is covered in the wiki

Apologies about the debugging, I could have sworn I checked the wiki.  My bad!
Sure, if the compatibility and work involved is too much I completely get that.    If anything, that's at the crux of what I've been asking for (without realising it) - external validation of what was originally intended (tmdb language lookup, forced subs).  I was just trying to offer a more general, agnostic approach that can handle what is and isn't there in any given source media.
There's one thing I can't seem to figure out if it's possible or not, and that's to only fetch full subtitles if there is not a matching language audio stream.  i.e I've filtered all the audio to just the original audio as tmdb provides, it isn't English, in that case I want full English subtitles.  But if the original audio is English, then I only want to check for forced subtitles.

https://github.com/mdhiggins/sickbeard_mp4_automator/commit/d3f8b7a01a4e28f84f4d09f732bccd21732b908e
Take a look at that
Removed some legacy options which I felt weren't needed
Added a new dynamic-download option which will set subtitle downloading preferences based on original language when compared against your set default language
Also included 'original-language' as a valid parameter for the sorting function

I think I mis-spoke when I said 'fetch'.  I didn't specifically mean 'download' but 'obtain', whether or not that is from the existing file or from an external source.  My test media (eng audio) already has eng-forced and eng subtitles embedded.  Both get added to the resulting file when I only want the forced ones.

Killing me
I'm going to say this needs to move to the custom functions then too niche of a request
I went ahead and included the tagdata object as a parameter in the skipStream and validation custom methods (though tagdata will not always be present on the validation call depending on what script is calling it) so that you can have easy access to the original language

https://github.com/mdhiggins/sickbeard_mp4_automator/commit/cd1b6fc4c7130d84c9d6ce8f2e27f7ff08c5dc56

Ah, I thought there was a flow what subtitles do I need -> what subtitles do I have -> what subtitles do I need to download.  I was just suggesting moving the dynamic-download logic from what subtitles do I need to download to what subtitles do I need.
But sure, having the tags there is super useful.  It should be trivial to add the logic necessary to an external script now.  Did you just remove dynamic-download entirely, or am I misreading the diffs?

Yeah just nuked it entirely. It was half baked anyway. Similar functionality should be doable via custom functions

Sure, just more inefficiently.  Now I'm going to have to ensure that full subtitles are always present, and then do a removal pass if they don't match.  At least with dynamic-download sma wouldn't download extra subs it definitely knew I didn't want.
Before:
file (english audio) -> known 'native' audio track -> post process to remove full subs
Now
file (english audio) -> unknown audio track -> get full subs -> post process to remove full subs

You can change settings on the fly exactly the same way the proposed dynamic download feature was implemented in your custom function

The only thing it was doing was setting which type of subtitle to download
            self.settings.downloadforcedsubs = (self.settings.adl == original_language)
            self.settings.downloadsubs = (self.settings.adl != original_language)

which from any of the custom functions can be set after checking if tagdata is available
            mp.settings.downloadforcedsubs = (mp.settings.adl == tagdata.original_language)
            mp.settings.downloadsubs = (mp.settings.adl != tagdata.original_language)

Yeah, I misunderstood how you were doing custom functions - I thought you were just passing environment variables to external scripts.  I was expecting my script to get the file name or other environmental data, then for me to ffprobe, parse that data, and then ffmpeg myself to remove unnecessary subtitles.
I've got very little experience with python, and that was ten years ago, so I haven't a clue how to write a custom function for this.  My best option is to handle it in the external script I need to write, given I have to pass the resulting file to another program afterwards anyway.

Thanks for your help and patience.  I've got it working just how I want with 6 lines of bash :-)

Should share it in case others have the same issue
I threw this together as a quick pass to get you started if you ever wanted a more integrated solution
def skipStream(mp, stream, info, path, tagdata):
    mp.log.info("Initiating custom stream skip check method.")

    if tagdata:
        foreign_language = tagdata.original_language != mp.settings.adl and any(a for a in info.audio if a.metadata.get('language') == tagdata.original_language and mp.validDisposition(a, mp.settings.ignored_audio_dispositions))
        mp.settings.downloadsubs = foreign_language and not any(s for s in info.subtitle if not s.disposition.get('forced') and not s.disposition.get('comment') and mp.validDisposition(s, mp.settings.ignored_subtitle_dispositions))
        mp.settings.downloadforcedsubs = not foreign_language and not any(s for s in info.subtitle if s.disposition.get('forced') and mp.validDisposition(s, mp.settings.ignored_subtitle_dispositions))
        if foreign_language and stream.type == "subtitle":
            return stream.disposition.get("forced")
        elif not foreign_language and stream.type == "subtitle":
            return not stream.disposition.get("forced")

    return False

Should share it in case others have the same issue

Yeah, I just wanted to do more testing on it.  There are probably edge cases where it won't work.
For anyone reading this:  DO NOT USE IT.  It's for guidance to write your own only, and has hard coded preferences for me.
BASETMPDIR="/store/.transcode/video"

if [ "$radarr_eventtype" = "Test" ] || [ "$sonarr_eventtype" = "Test" ]; then
    exit 0
elif [ -n "$radarr_moviefile_path" ]; then
    INPUTFILE=$radarr_moviefile_path
    ID="-tmdb $radarr_movie_tmdbid "
elif [ -n "$sonarr_episodefile_path" ]; then
    INPUTFILE=$sonarr_episodefile_path
    ID="-tvdb $sonarr_series_tvdbid "
elif [ -n "$1" ]; then
    if [ "${1::1}" != "/" ]; then
        INPUTFILE="$(pwd)/$1"
    else
        INPUTFILE=$1
    fi
fi

mkdir -p "$BASETMPDIR"
fullfile=$(basename "${INPUTFILE}")
filename=$(basename "${INPUTFILE%.*}")
filetype=${INPUTFILE##*.}
tmpdir="$BASETMPDIR/$filename"
mkdir -p "$tmpdir"
cp "$INPUTFILE" "$tmpdir"

infile="$tmpdir/$fullfile"
smafile="$tmpdir/$filename.mkv"
subsfile="$tmpdir/$filename.mkv.subs"
normfile="$tmpdir/$filename.mkv.norm"

# sma
if ([ "$filetype" = "mkv" ] && [ ! -f "$smafile.original" ]) || ([ "$filetype" != "mkv" ] && [ ! -f "$smafile" ]); then
        /store/.bin/sma/manual.py "$ID"-a -i "$infile" || rm -f "$smafile" "$infile" "$smafile.original"
fi

# post-process sma
if [ ! -f "$subsfile" ]; then
    eval $(ffprobe -v 0 -show_entries stream=index:stream_tags=language,title -select_streams a -of flat=s=_ "$smafile")

    audio_lang=$streams_stream_0_tags_language

    eval $(ffprobe -v 0 -show_entries stream=index:stream_tags=language,title -select_streams s:0 -of flat=s=_ "$smafile")

    if [ "$audio_lang" = "eng" ]; then
        if [ "$streams_stream_0_tags_title" = "Forced" ]; then
            ffmpeg -v 0 -err_detect ignore_err -fflags +igndts -f matroska -i "$smafile" -c:v copy -c:a copy -c:s copy -map 0:v:0 -map 0:a:0 -map 0:s:0 -f matroska "$subsfile" || rm -f "$subsfile"
        else
            ffmpeg -v 0 -err_detect ignore_err -fflags +igndts -f matroska -i "$smafile" -c:v copy -c:a copy -c:s copy -map 0:v:0 -map 0:a:0 -f matroska "$subsfile" || rm -f "$subsfile"
        fi
    else
        ffmpeg -v 0 -err_detect ignore_err -fflags +igndts -f matroska -i "$smafile" -c:v copy -c:a copy -c:s copy -map 0:v:0 -map 0:a:0 -map 0:s:0 -f matroska "$subsfile" || rm -f "$subsfile"
    fi
fi

# ffmpeg-normalize
if [ ! -f "$normfile" ]; then
    ffmpeg-normalize "$subsfile" -c:a ac3 -pr -nt rms -t -23 -f -of "$tmpdir" -ofmt matroska -ext norm || rm -f "$normfile"
fi

mv -f "$normfile" "$INPUTFILE" || exit 1
rm -r "$tmpdir"

302fa7e
Tweak the forced option so you can download both forced and standard

Now I've got something (vaguely) production ready, I've been testing it more thoroughly on edge cases.  I've noticed that the forced download doesn't seem to work.  I'm not sure if you'd rather open a new issue for that to keep this clear.
I've attached a very cut down file that I've been using to test. (Just remove .csv, seems github doesn't like mkv).  Here is one of a couple of 'foreign parts only' (forced) subtitles that are available.  sma doesn't find any forced subtitles.
War of the Worlds (2019) - S01E01 - Episode 1.cut.mkv.csv


Verbiage next to balance XEM (might be inaccurate)

Please consider using (Possibly inaccurate until fully synced)

agree


Oci support

Adds OCI support for kpt pkg get
First PR of a small series to add OCI to an experimental kpt branch

Hey @loudej we just launched a public design document template.  Could be good to describe how OCI will work in a way that's visible to the user base: https://github.com/GoogleContainerTools/kpt/blob/main/CONTRIBUTING.md

Hi @mikebz Sounds like a great idea. As I understand the procedure - this idea is to have an additional PR that contains only a copy of the md and it should be in the same folder as the template?
@droot Sounds good - I'll take a look. I think I know what layer you're talking about (something to use just under the util/*/Command logic)

Yes. What I have seen with other products is the same folder but maybe start with a different number. Thank you!

@droot Hi again! Well, there was already a fetch Command package and I was concerned fetch and fetcher would be very easy to confused. Instead I added an upstream package because all of the work will be dealing with the upstream sources and upstream/upstreamLock Kptfile properties.
It has anupstream.Fetcher interface that duck types onto upstream.gitUpstream and upstream.ociUpstream. Let me know if that resonates with you or if the names should be shuffled around to something better.
Ah - the impact on the code is that it is cleaner, but it will make it harder to keep the branch in line with main.

I am looking forward to the design document, especially highlighting the user guide/journey for get, update and diff commands before I take a stab at reviewing the code.

@phanimarupaka sounds great, sorry for the delay! That is my next task on deck, and thanks for the help!

Added companion PR #2589 with design doc. Happy to iterate and collaborate on that, hoping it aligns with what you were expecting!
Also PR is smaller scope than design doc - it doesn't support sub-package or diff yet - and push/pull commands aren't added.
/cc @phanimarupaka @droot @mikebz

Closing this PR in favor of #2621 which is rebased on current main


Control widgets disappear when zooming into rainfall demo

Describe the bug
Zooming in to the rainfall map causes the GUI widgets to disappear after about 100 steps.
Expected behavior
The GUI widgets should remain and there should be no flickering when zooming into a .asc image.
To Reproduce
In the rainfall demo simply add a return as the first line to the Rainfall::step() function. Run the demo and after about 100 or so steps, zoom into the image. You'll see the widgets disappear and flickering in the image.
Additional context
This bug is repeatable on Linux and Windows. My application is similar to the rainfall demo. After about 200 steps (for my application) widgets disappear and the image and agents start flickering. But the rainfall demo exhibits the bug even without any agents.

Thanks for reporting this! The issue was probably automatically closed because it was linked to the fix. Now that the fix is merged, would you like to try it out and see if the issue is still there?
Since the fix is not yet released, you'll need to install Mesa-Geo from source. I would recommend installing it in a new virtual environment. In an existing environment it's better to first uninstall Mesa-Geo, then install it from source.
Plus, when the model webpage is open, you'll also need to do a hard refresh, so that cached js files are removed and updated js files are used.
Please feel free to reopen this issue if it's not working.


Add async Mutex.

What it says on the tin :)
It allows sharing data between tasks when you want to .await stuff while holding it locked.

bors r+


fix: return stderr while reading kubeconfig via kwokctl

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR  ensures that the error message from kwokctl get kubeconfig is captured and returned as part of the wrapped error.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., Usage docs, etc.:

None

/ok-to-test

The tests directly affected by this PR sigs.k8s.io/e2e-framework/examples/kwok/kwok_with_config are passing successfully. However, sigs.k8s.io/e2e-framework/examples/third_party_integration/flux/kyverno  tests in the suite are currently failing which this PR does not affect.

/retest

xref: https://github.com/kubernetes-sigs/e2e-framework/issues/440
Created a tracker for the kyverno failures. That test has been flaking to much lately. cc @vladimirvivien @cpanato
I will take a look at this over the weekend to get it fixed.

Thank you @harshanarayana for the pointers related to the flaky tests. I've added logic to check for the availability of all Kyverno related deployments before running tests. And after this change, the tests have not failed in subsequent runs. As indicated previously the tests related to  sigs.k8s.io/e2e-framework/examples/kwok/kwok_with_config are passing successfully.
CC @vladimirvivien @cpanato

/lgtm

/lgtm
/approve


[move-lang] allow _x to bind but do not warn as unused local

Motivation
_ patterns are used to not introduce a binding, e.g. let (x, _, z) = (0, 1, 2);

In Rust, if you do _y instead of _, e.g. let (x, _y, z) = (0, 1, 2); This introduces a binding _y = 1 but it will not complain if you don't use it
In Move currently _y is just sugar for _ which isn't really helpful

The fix:

make _y not remap to _, this will automatically fix being able to use it
add an exclusion for underscore prefixed locals in the unused local warning

Test Plan
cargo xtest

Updated test, almost_invalid_local_name.move is still valid. The invalid test is moved to invalid_local_name.move.

Rebased past the renaming. @tnowacki would you mind having a final look on the PR?

Rebased to master.

/land

:exclamation: Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

Rebased, see if this may avoid the Circle CI glitch (2xlarge docker).

/land


[BUG]: Vision models don't retain memory of images past one prompt

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?
When I upload a file, I can use a vision model like llama3.2-vision:11b to describe it, but then subsequent prompts don't have any memory of the image.

I would expect that I can ask repeated questions of the image and that it would remain in my current context until my context window was exhausted.
Are there known steps to reproduce?
No response

Tried on 1.2.3 docker version, pixtral 12B, and worked.

At least on docker version looks right.
I just tried on 1.2.4 desktop version, pixtral 12B and it fails:

Looks like if data is not on first description he hallucinate colors... (on desktop version)

Correction seen exact same behviour on docker :), 1.2.3, pixtral 12B.

Any update?


Cannot read properties of undefined (reading 'transcriptBodyRenderer')

Describe the bug
It worked well until yesterday.
i have tried  few minutes ago, It comes to error as blow
Cannot read properties of undefined (reading 'transcriptBodyRenderer')
Please fix for this issue

It seems like they changed the API for getting the video transcript, I'll get this fixed soon.

OK. Thank you. I will wait!

When you fix it, Please Let me know. ^^
Thank You
2024년 4월 5일 (금) 오후 11:25, SuspiOwl @.***>님이 작성:

It seems like they changed the API for getting the video transcript, I'll
get this fixed soon.
—
Reply to this email directly, view it on GitHub
https://github.com/SuspiciousLookingOwl/youtubei/issues/95#issuecomment-2040924434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZMXY5EDV6WPW37DB2AVVLY35TJJAVCNFSM6AAAAABF2AJ3L2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHEZDINBTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fixed on 1.4.0, please update your version.
I also added more complete support for captions
const video = client.getVideo("...");

// printing out available languages (and its code) for captions
console.log(video.captions.languages.map((l) => `${l.code} - ${l.name}`));

// printing out captions of a specific language using language code
console.log(await result.captions.get("en"));

Hello~ Thank you.
but I tried that you show the code, it did not work well!
installed 1.4.0 but didn't work. Can you Please what is wrong this code?
[image: Screenshot 2024-04-06 at 6.22.47 PM.png]
[image: Screenshot 2024-04-06 at 6.24.04 PM.png]
2024년 4월 6일 (토) 오후 2:50, SuspiOwl @.***>님이 작성:

Closed #95 https://github.com/SuspiciousLookingOwl/youtubei/issues/95
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/SuspiciousLookingOwl/youtubei/issues/95#event-12382214737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZMXY5BL2P5CLUFK4EXUYTY4A7WBAVCNFSM6AAAAABF2AJ3L2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM4DEMRRGQ3TGNY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Thank You so much . Now is working!


Component Relationship section

Why not to use SPDX ID instead of SPDX license URL? ID is shorter and is more consistent (URL may change).
Also in relation to all licenses needing to link to a public page:
This is impractical. Many proprietary licenses are.. well… proprietary and as such cannot be published on the public web sites.

I pondered that too. From 40,000ft we're writing to a "link" element, so it somewhat makes more sense to write a link than a random bit of text. I'm not against supporting a <Meta> element of spdxId which contains this data, although we should probably also talk to the DTMF about an actual registered ID for it too.

Also in relation to all licenses needing to link to a public page: This is impractical

So what would you put for a nonfree license? Standard NonFree AMI license? If it's not public what the license terms are then how are end users supposed to validate the SBoM licencing? If it's a secret agreement, then don't include the license tag at all.

Many proprietary licenses are.. well… proprietary

I understand the binary deliverable covered by the license is proprietary, but the same can't be said for the license text itself surely?

cannot be published on the public web sites

As a short term workaround, the license URL you could use could be https://www.ami.com/aptio/
But, playings devils advocate, how am I supposed to know if the BIOS firmware on my system right now can or can't be be rebranded and relicensed? At some point the SBoM has to convey that "this specific binary component is non-free, non-redistributable except by the OEM" and without some kind of public statement to that effect the user won't know. This is exactly the transparency the EO and CRA are asking vendors to provide.
This is the kind of thing Intel did for microcode: https://web.archive.org/web/20180824090009/https://01.org/mcu-path-license-2018


SMF does not connect via PFCP

Hello everyone!
I'm starting to use Aether to test some gNB solutions. At first I installed OnRamp, following the instructions here: https://docs.aetherproject.org/master/onramp/start.html
I changed some parameters to match my network: plmnid, mcc, mnc, imsi and dnn
After uploading k8s, 5gc and amp, I was finally able to connect gNB to authenticate a UE.
The problem is that it still hasn't authenticated. After some time trying to figure out what's going on, I noticed that there are some flaws in the SMF pod. Does anyone know how to solve this?

Edit: I couldn't find any endpoint with this address <IP_ADDRESS>

Questions about AMF internals are probably best asked on Slack: https://onf-community.slack.com/
(either the aether-onramp or aether-dev channels).

Thanks for your quick answer! @llpeterson, how can I join Slack? I don't have an account in any of those domains listed.

Send me an email (so I have your email), and I'll send an invitation. My email is the first three letters of my GitHub id, at opennetworking.org.


Update and simplify the user-interface

The current UI was written in the past, but now reduces our single-threaded JavaScript processing.

The first phase is finished, other changes will be made over time.

Completely fixed the lag issue and also added some web workers to prevent the UI from freezing.


Request permission optional at init

Hello, I want to inform the user before requesting the permission for notifications which is done now at lib init which is done when the app starts. Could you please make the permission request optional in order to have the possibility to request ourselves this when deemed necessary?  And later as an improvement expose the request permission method so we can use directly your impl.
Thank you for your great work.

@corneloaie I'll consider to implemen this. Thank you!

This is implemented in version 0.6.0
For more information about usage you can check comment in PR: https://github.com/mirzemehdi/KMPNotifier/pull/27


No docker image for v1.12.5

The assets which were built in release 1.12.4, were not built for 1.12.5, so the Dockerfile can't be built
And - no image here for v1.12.5: https://hub.docker.com/r/vernemq/vernemq/tags

Closing as this was not built by intention.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.


docs: update documentation

What's the comment to generate it ? I'm going to try and automate it using GitHub actions

The cmd is npm run doc, but it's not in final state yet - I'm moving docs to gh pages. Most likely it will need at least one more adjustment


tests: initial commit of the manual tests

Please do not merge this PR.
In order to use these tests you need to set your working directory to tests/leonardo and then execute the outer shell scripts one by one.
Each one of these will start a data source (fluent-bit, vector, opentelemetry collector, shell scripts, etc.) and a data sinc which is the fluent-bit binary we are trying to test.
The path to the binary (as well as other settings) can be passed through environment variables, otherwise the shell script will look for fluent-bit inside the bin directory and its parents bin directory (in case this is executed inside the build directory of a fluent-bit working tree).
The scripts will automatically elevate privileges when required and also perform a crude teardown after the test is terminated.
These are manual tests, there is no automatic compliance detection at all so far and that's not the intention either.

Let's adapt these over to BATS and then can go straight in as integration tests: https://bats-core.readthedocs.io/en/stable/

@leonardo-albertovich anything specific you still need on top of this? Cluster creation, etc.?

Just the test cases for filter_kubernetes, filter_aws and filter_ecs.

Just the test cases for filter_kubernetes, filter_aws and filter_ecs.

So filter_kubernetes should drop straight into the current integration tests as these all run on KIND, EKS and GKE already.
We can add some simple basic checks that it provides kubernetes metadata in the output.
use_kubelet was the other area I wanted to test as seems problematic with TLS but I think not for an initial one.
Any other specific K8S filter checks you think @leonardo-albertovich ?
filter_ecs - what does this filter do? It looks to be this one: https://docs.fluentbit.io/manual/pipeline/filters/ecs-metadata
Too many ECS acronyms! We will need to provision an ECS cluster for this in Terraform then run the tests on it explicitly. We can do that with some BATS set up easily enough (e.g. use tags or just skip the test if not on ECS).
filter_aws is this one: https://docs.fluentbit.io/manual/pipeline/filters/aws-metadata
I think the best option here is to spin up a dedicated test VM for it with Terraform and then skip the test unless we're on that VM. When we are on it then we can check the output of the example in the docs: https://docs.fluentbit.io/manual/pipeline/filters/aws-metadata#command-line

Let's move the common functions into the helpers file for BATS.
Let's then move the test scripts into BATS test functions we can invoke with the integration tests.

We can do that once I'm done with the PR but right now all I need are those three test cases, keep in mind that at the moment this was shared as a reference.


Bug: uuid.New as Default causing schema creation to fail

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
We use UUIDs as PKs within our schema like so:
func (User) Fields() []ent.Field {
	return []ent.Field{
		field.UUID("id", uuid.UUID{}).
			Default(uuid.New). // <-- ISSUE
			Unique(),
	}
}

We then attempt to output the SQL for the above like so:
if err := store.Client.Schema.WriteTo(context.Background(), os.Stdout, migrate.WithGlobalUniqueID(true)); err != nil {
	log.Fatalf(err)
}

Which ends up with the following error in our logs:
sql/schema: unsupported default type: [16]byte

It seems like .Default(uuid.New) is causing the issue. The uuid.New function returns a [16]byte UUID, which seems to be an issue when building the schema, resulting in the above error.
Expected Behavior 🤔
We expect the SQL to be generated, appropriately representing the above data type for our ID.
Steps to Reproduce 🕹
Above code sample should suffice to reproduce.
Your Environment 🌎

Tech
Version

Go
1.16.2

Ent
0.7.0

Database
Postgres

Driver
github.com/lib/pq

Minor note that everything else works with the above, and we're extremely grateful to @a8m for this package.

Hey @TomOperator and thanks for reporting this issue.
I created an example in integration-tests that works with UUID fields as unique identifiers without any issues. See https://github.com/ent/ent/pull/1362
However, note that migrate.WithGlobalUniqueID(true) was created for numeric-type identifiers and shouldn't be used in this example.
If this still doesn't work for you, please create an example repository to simulate this bug and paste here a link for it.

Minor note that everything else works with the above, and we're extremely grateful to @a8m for this package.

Thanks for the kind words 🙏

Thanks @a8m - we removed the default, and for some reason still getting the same error. We'll investigate it further; closing this ticket.

Thanks for the update @TomOperator.
Please join our Slack channel and feel free to ping me there privately if you have any troubles with it.


Error in biblio module: citar required by biblio/config.el but only optionally installed

What did you expect to happen?

I enable the new biblio module
I run doom sync
I start emacs successfully without errors

What actually happened?

I enable the new biblio module
I run doom sync
I start emacs, but get a startup error
Error in a Doom module: modules/tools/biblio/config.el, (file-missing Cannot open load file No such file or directory citar-org)

The emacs --debug-init output is included in the pastebin below.
Describe your attempts to resolve the issue
I believe the issue is because the config.el file references citar-org: https://github.com/hlissner/doom-emacs/blob/180a7c261f99c0a0e38207aa0e834cba17f8d6d2/modules/tools/biblio/config.el#L56-L60
but the citar-org package is only optionally installed in the packages.el https://github.com/hlissner/doom-emacs/blob/180a7c261f99c0a0e38207aa0e834cba17f8d6d2/modules/tools/biblio/packages.el#L10-L11
I've worked around this in two ways, locally:

Just removing the org-citar config block, since I wasn't using citar anyways
Enabling the :completion vertico flag so that the citar package is picked up and the config works as expected.

Both of these workarounds are what make me believe the explanation above.
I'd expect that the biblio module is self-sufficient and doesn't require any other flags to be enabled for it to successfully work. citar-org should either always be installed or otherwise its config block should gated so it only gets evaluated if citar is installed, but I don't know how to accomplish that best.
Hopefully my guess is right, but my apologies if this is not actually the source of the issue!
Steps to reproduce

Install the latest commit of the doom emacs branch
Enable the new biblio module, with the :completion vertico flag disabled
Launch emacs (and see the error)

System Information
https://pastebin.com/E9Z9xSby

cc @bdarcus as I know you're heavily involved in the biblio module (and citar of course!)
While I'm here, thank you bdarcus, and everyone else involved, so much for your work on the biblio module, and your work on org citations in general! I've been following the biblio PR since it got spun up and I'm so excited to get it all working as an official doom module. This bug report is just a minor friction point I wanted to point out, no big deal in comparison to the amazing work you've done on this project!

So to be clear,  @natejlong, you got the error when using the ivy or helm completion module?

I can confirm that testing for the use of vertico completion fixes this error for me (I use Ivy still):
diff --git a/modules/tools/biblio/config.el b/modules/tools/biblio/config.el
index 6d0cd390f23e..cc5c575ea48b 100644
--- a/modules/tools/biblio/config.el
+++ b/modules/tools/biblio/config.el
@@ -53,8 +53,9 @@

 ;;;; Third-party

-(use-package! citar-org
-  :when (featurep! :lang org +roam2)
-  :config
-  ;; Include property drawer metadata for 'org-roam' v2.
-  (setq citar-org-note-include '(org-id org-roam-ref)))
+(when (featurep! :completion vertico)
+    (use-package! citar-org
+      :when (featurep! :lang org +roam2)
+      :config
+      ;; Include property drawer metadata for 'org-roam' v2.
+      (setq citar-org-note-include '(org-id org-roam-ref))))

Can you please confirm the solution in #5810 works for you, and weigh in there?

Just to confirm, those changes did resolve the issue. Thank you everyone!


build: improve the download script to show percentage / ratio progress of libcc download

The easiest way to show how much better this is than the old dots is a GIF
https://i.imgur.com/6214pKI.gif
cc @deepak1556 I did it 😄

When using a light theme, the first number is invisible 😄

@zcbenz Maybe we should change it to -> XX% 🤔 I'll put that up in PR 👍


Remove BOLT11 Receiving Support; Remove Python 3.8 from CI

This PR resolves the issue described here: https://github.com/gudnuf/bolt12-prism/issues/101 Basically it makes no sense to track outlays for BOLT11 since they are independent from each other!
This commit also includes fix for the CI issue. I just removed the 3.8 python from the testing. Maybe we can add it back later after the issue is resolved upstream?

Yeah I agree. It does clean up the code quite a bit.


Add ability to tombstone user accounts

I wrote a long description but it was swallowed by SNCB wifi, basically need a mechanism to be able to prevent people from logging in/writing, whilst still retaining their data. Perhaps important for #468

Tombstoning should also have an option for full anonymisation (I think by law), I'm not sure how this interacts with e.g., wanting to keep an email address for contact regarding samples, and the logic here becomes very convoluted (i.e., if a user tombstones their account and thus can no longer login, how do they request for their data to be anonymized).


Disable failed unit test.

Fixes https://github.com/istio/istio/issues/4144. Will add the test back after the fix.

/lgtm
Should we just comment out rather than deleting?

@ZackButcher I think that's fine. I can easily restore this simple test set.

@myidpt: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
bef42fa5e24ff45a047319ac56de041158d44364
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Determine method for tracking Discogs requests

Some kind of permanent logging solution would work here

This needs some kind of basic logging, maybe Loki, but that needs storage

Let's go with Loki and figure that whole thing out


everything

Closes #1

Thanks for looking it over @safareli!

@davidchambers how do I set up CircleCI for this repo?

how do I set up CircleCI for this repo?

I just visited https://circleci.com/gh/sanctuary-js/sanctuary-tuples and followed the project. I believe that's all that's required.

Is there any particular configuration necessary to run a build for PRs?

@davidchambers aside from removing README.md and changing the ASCII art, I think this is ready.

@davidchambers do you think this is good to go (minus the ASCII art)?

I would very much like to incorporate fantasyland/fantasy-laws#1. I intend to complete and merge that pull request this weekend. In the interim, you could add fantasy-laws to package.json as a Git dependency and use it to test the lawfulness of this algebraic data type. :)

@gabejohnson, what do you think of the idea of exporting Pair, Pair.fst, Pair.snd, … rather than P.Pair, P.fst, P.snd, …?

I think that makes sense. The current method is a holdover from a previous implementation when we were exporting more types.

We should define Pair.chainRec. As usual, I think I'll need help from you, @safareli. ;)

Thank you for your significant contributions, @gabejohnson and @miwillhite! :beers:

Woohoo, great work all!


feat: cherry-pick Add RPC gw_get_mem_pool_state_root

Tested
https://github.com/nervosnetwork/godwoken-docker-prebuilds/actions/runs/2011995215


Prism Instances

Just putting this here, we won't support this in prism instances initially. Is there a use case for this in prism instances?

Yeah there probably is - to be discussed.


Update page titles & add page descriptions

Change the site template so that page metadata has

the variable part of the title first (so it is visible in small browser tabs) Button - Carbon Design System
an abstract/summary that matches the page url (e.g. summary of Button, from first paragraph) rather than the general site (summary of Carbon)

blocked by https://github.com/carbon-design-system/gatsby-theme-carbon/issues/403 to add prepend titleType


log bank account balance to Librato

Probably a new dashboard?
Probably would have to go through Xero (#1039)?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Going with Beancount.


How to set Values in create_pet_tf_record.py

I am following your Doc : https://www.kdnuggets.com/2018/02/building-toy-detector-tensorflow-object-detection-api.html
i am trying to set value in create_pet_tf_record.py, Where i am getting the issue as follows -
File "C:\Aniket\TensorflowObjectDetection\Objectdetection\create_pet_tf_record.py", line 45, in
from object_detection.utils import label_map_util
File "C:\Python35\lib\site-packages\object_detection\utils\label_map_util.py", line 21, in
from object_detection.protos import string_int_label_map_pb2
ImportError: cannot import name 'string_int_label_map_pb2'
need your suggestion.
Thanks in Advance.

Please follow instructions for installing tensorflow object detection at :+1: https://github.com/tensorflow/models/blob/master/research/object_detection/g3doc/installation.md


[femutils] Use all available cores for the linear system solver

Before that we only used one core.
And example simulation of Poisson with 4 cores repots the following in -ksp_view
  Mat Object: 1 MPI processes
    type: seqaij
    rows=151, cols=151
    total: nonzeros=959, allocated nonzeros=2265
    total number of mallocs used during MatSetValues calls=151
      not using I-node routines

Two issues here:

used matrix type is seqaij it should be mpiaij
And only 1 MPI process is used Mat Object: 1 MPI processes

I guess the implementation is correct. The CI tests have failed because of  PASSMO not being stable at the moment. I will remove PASSMO from CI for now.

Ok so I can merge ?

Perfect I confirm it works well I can clearly see 4 procs in use
  Mat Object: 4 MPI processes
    type: mpiaij
    rows=151, cols=151
    total: nonzeros=959, allocated nonzeros=3030
    total number of mallocs used during MatSetValues calls=202
      not using I-node (on process 0) routines

Perfect !
We can also use less CPU cores than the number of available MPI ranks. It may be useful in when we do not have a lot of cells in a sub-domain.

There is two tests which failed but they are working on my laptop. It may be because of the version of PETSc used.


Sample/demo of FSK

Hi,
Great library, I am working through the demos of FSK, but facing the following issue on decode. (Displayed in console)
warning: fskframesync_decode_header(), packetizer_decode failed
tested with ultrasonic-fsk-robust, however all the FSK options seem to show same issue.
Would you have any working demos of the FSK library?
Cheers

Hello,
Assuming you mean https://quiet.github.io/quiet-js/fsk-robust that demo does work so if you're getting those errors it's because of a difficult transmission. Can you describe the environment and devices used?

Thank you, I have it working
Forgot one line
var onReceive = function(recvPayload) {
content = Quiet.mergeab(content, recvPayload); // Needed this
console.log("onReceive payload: " + Quiet.ab2str(content));
}


XMLConverter should not hard code encoding="utf-8"

Code:
from pdfminer.converter import XMLConverter
rsrcmgr = PDFResourceManager()
xmlstream = StringIO()
device = XMLConverter(rsrcmgr, xmlstream)

# xmlstream now contains something like:
# '<?xml version="1.0" encoding="utf-8" ?>'

While that encoding is pretty reasonable, it causes problems later with pedantic XML parsers like lxml that raise an exception because of the encoding declaration. (On their web site they explain why they think this is "wrong", and I'm not here to debate it, just trying to make my code work.)
In order to "fix" this in my code, I've made a simple override of XMLConverter that removes the hard-coded "encoding" declaration in the write_header method, but it would be nice if XMLConverter took in an option of some sort to not include it.

Suggested fix with test:
XMLConverterSuggestion.zip


HL-412: Employer calculator to API

Description :sparkles:

Employment calculator connected to api
Basic validation to the date fields added
Temporary errors from the backend shown in the toast message (have to be replaced with notifications later)

Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #721 (eb0599c) into develop (7f9d510) will decrease coverage by 59.58%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #721       +/-   ##
===========================================
- Coverage    63.60%   4.01%   -59.59%
===========================================
  Files          766      23      -743
  Lines        19135     274    -18861
  Branches      1831      32     -1799
===========================================
- Hits         12170      11    -12159
+ Misses        6601     236     -6365
+ Partials       364      27      -337

Impacted Files
Coverage Δ

...forms/application/deMinimisAid/utils/validation.ts

...ations/forms/application/step1/utils/validation.ts

...ations/forms/application/step2/utils/validation.ts

frontend/benefit/applicant/src/constants.ts

...components/applicationReview/ApplicationReview.tsx

...ymentAppliedMoreView/EmploymentAppliedMoreView.tsx

frontend/benefit/handler/src/constants.ts

...c/components/benefit/summaryView/SummaryView.sc.ts

frontend/shared/src/utils/date.utils.ts

frontend/shared/src/components/layout/Layout.tsx

... and 733 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9d510...eb0599c. Read the comment docs.

I also suggest to rebase or merge develop, it has some fixes that might help to github actions deploys to work better.


How to set up an account?

When you enter appropriate data in MySQL, I can not log in osu!
What is going on?

This source is only meant as reference for developers, you should use another bancho clone if you want to set up your own server.


support newer PuTTY key format

While attempting setup PuTTY and SuperPutty on new machine I found that SuperPutty can't read my private putty key file
I would like SuperPutty to support the latest release of the putty private key file
Message: Unable to load private key file "C:\Users\wamitef\.ssh\id_rsa.ppk" (PuTTY key format too new)
PuTTY release version 0.79

Check your putty version, superputty itself doesn’t touch puttys files. You probably need to upgrade your putty version would be my gfuess.
From: WilliamMiteff @.>
Sent: Monday, November 13, 2023 8:20 AM
To: jimradford/superputty @.>
Cc: Subscribed @.***>
Subject: [jimradford/superputty] support newer PuTTY key format (Issue #918)
While attempting setup PuTTY and SuperPutty on new machine I found that SuperPutty can't read my private putty key file
I would like SuperPutty to support the latest release of the putty private key file
Message: Unable to load private key file "C:\Users\wamitef.ssh\id_rsa.ppk" (PuTTY key format too new)
PuTTY release version 0.79
—
Reply to this email directly, view it on GitHub https://github.com/jimradford/superputty/issues/918 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4ZXW3JAVWQYJVJZFA5M7DYEJCCDAVCNFSM6AAAAAA7JNCU5GVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TAOJZGYYTAOA .
You are receiving this because you are subscribed to this thread.  https://github.com/notifications/beacon/AB4ZXWYOTNO5V47E6DT5EGDYEJCCDA5CNFSM6AAAAAA7JNCU5GWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHNLBQRQ.gif Message ID: @.*** @.***> >


Add support for custom vendor path

https://github.com/m2mdas/phpcomplete-extended/issues/43

It should be fixed after https://github.com/mkusher/padawan.php/commit/9df387c9a50dd83237971c89f52a911dd09284a2


[BUG] ignoreHeaders as part of config does not build with typescript

Description/Screenshot
Reading Application Insights Javascript SDK configuration documentation I understood that ignoreHeaders can be given as part of config to limit headers being included to dependency telemetry in case of enableResponseHeaderTracking being enabled.
The documentation explicitly state:

These configuration fields are optional and default to false unless otherwise stated.
For instructions on how to add SDK configuration, see Add SDK configuration.

And in the add sdk configuration documentation:

The optional SDK configuration is passed to the Application Insights JavaScript SDK during initialization.
To add SDK configuration, add each configuration option directly under connectionString.

Steps to Reproduce
With node v18.18.1 and npm 9.8.1

Checkout repo: https://github.com/aviita/react-typescript-app-application-insights-ignore-headers-bug.git
Run npm run build or see eslint output for telemetry.ts.

OS/Browser: Not relevant as this is typescript build error
SDK Version [e.g. 22]<EMAIL_ADDRESS><EMAIL_ADDRESS>How you initialized the SDK: See src/telemetry.ts from https://github.com/aviita/react-typescript-app-application-insights-ignore-headers-bug.git

So the repro is in the app in github. Using
Firstly I also tried updating my app insights web and react js packages with:

npm i @microsoft/applicationinsights-react-js@latest @microsoft/applicationinsights-web@latest

How I try to init:
import {
  ApplicationInsights,
  ITelemetryItem,
} from "@microsoft/applicationinsights-web";
import { ReactPlugin } from "@microsoft/applicationinsights-react-js";
import { createBrowserHistory } from "history";

const history = createBrowserHistory();

const reactPlugin = new ReactPlugin();

const appInsights = new ApplicationInsights({
  config: {
    connectionString: process.env.VITE_APP_AI_INSTRUMENTATION_CONNECTION_STRING,
    disableFetchTracking: false,
    //enableRequestHeaderTracking: true, // Enable to get request headers in dependency logs
    enableResponseHeaderTracking: true, // Enable to get response headers in dependency logs
    ignoreHeaders: [
      "Authorization",
      "X-API-Key",
      "WWW-Authenticate",
      "date",
      "x-ms-blob-type",
      "x-ms-lease-status",
      "x-ms-request-id",
      "x-ms-version",
      "content-type",
      "X-Powered-By",
      "X-Firefox-Spdy",
      "Set-Cookie",
      "Request-Context",
      "Content-Encoding",
      "Access-Control-Allow-Origin",
      "Content-Encoding",
      "Vary",
    ], // Ignore these headers in dependency logs
    disableAjaxTracking: false,
    enableCorsCorrelation: true,
    extensions: [reactPlugin /* debugPluginInstance */],
    extensionConfig: {
      [reactPlugin.identifier]: {
        history,
      },
      /*
        [DebugPlugin.identifier]: {
          trackers: toTrack
        }
        */
    },
  },
});

appInsights.loadAppInsights();
export { reactPlugin, appInsights };

Expected behavior

ignoreHeaders can be passed as a parameter to config
ignoreHeaders is documented clearly.

Actual behvior:
Currently I get build error on npm run build:

Object literal may only specify known properties, and 'ignoreHeaders' does not exist in type 'IConfiguration & IConfig'.ts(2353)

Additional context
I would like to be able to include some specific headers to my dependency telemetry from our react app. I am specifically interested in X-Cache, cache-control and Content-Length headers to se relevant data to determine if our caching configuration needs improvement or if we should do improvements to our backend performance (Azure Storage Account tier selection in this case).
It would also be nice to have rather an include headers clause than exclude headers in our case, but anyways I can work with this if I figure out how to get it working.

Also reproduces with<EMAIL_ADDRESS>

The "correct" location of the configuration is actually part of the extensionConfig so it should be something like
extensionConfig["AjaxDependencyPlugin"]: { ignoreHeaders: [] }

@siyuniu-ms we don't have any documentation in the dependency extension about how to configure these, can you please

Add to the readme
Update the typedoc (comments in the code with examples <- part of the longer term documentation "fix")
Sync with PM's to figure out who should update the azure monitor docs

The "correct" location of the configuration is actually part of the extensionConfig so it should be something like
extensionConfig["AjaxDependencyPlugin"]: { ignoreHeaders: [] }

Thanks, it did look like an extension when I searched the repo code, but the way it was documented seemed like it was supposed to be usable from the main config. From code I could not figure out thought what was the extension name and it seemed to be also part of the core package, so that confused me further.
Another confusion is that lots of the other properties in ICorrelationConfig are accepted by the main configuration.
Can I still configure the enableResponseHeaderTracking through main config while just adding this single ignore?
Will anyways now configure it with these extension configs.

And I think I got it working otherwise, but I likely still need to ensure the X-Cache header is also exposed to the frontend (with Access-Control-Expose-Headers in my response headers) to allow SDK to get hold of it and log it. This is because we are currently doing cross origin requests for the requests we are interested in to check the headers for.


Document escaping of single quotes

I'm no sure if I'm just missing this in the Dhall.Tutorial, but I was a bit confused by the fact that strings in dhall cannot contain single quotes, as in:
{ foo : "bar'baz" }

which gives
(stdin):1:11: error: expected: "${",
    "''${", "\"", literal character
{foo= "bar'baz"}

Is that even the intended behavior?

That's definitely a bug in the parser.  The code example you gave is supposed to be valid Dhall code.  I'll fix this


[BUG] Prevent upgrades that skip versions

Describe the bug
Gravity doesn't seem to currently prevent upgrades that skip too many versions. This should be enforced in the upgrade scripts and/or tele build to prevent the cluster from breaking when using unsupported upgrade paths.

As we already have a basic way of enforcing the installed version minimum we could follow the same version skew rules as kubernetes (using the version of k8s bundled by the runtime application).
But after the work on allowing multiple intermediate kubernetes upgrades, it will probably matter less so we could stay with a single version minimum known to support them.

I suspect the really tricky part though, is the intermediate upgrade stages requires tele build flags, so installation restrictions should react to that. IE an upgrade for 5.0 -> 5.5 that doesn't specify 5.2 as an intermediate stage should prevent the upgrade, where as one that does have the intermediate stage to do 5.0 -> 5.2 -> 5.5 should complete the upgrade.
Also, the way the basic check is setup now leads to the variable not keeping up to date. So process wise or test wise, we should likely ensure that the minimum version is set to a version that we actually test upgrades from in robotest.

I agree. One way we could expose the minimum version if in the gravity version command. There could be some extended view with additional metadata.

This work is being tracked in #1064 now.


Fix log messages from StreamProcessor(onJobModelExpired event).

Log messages published in onJobModelExpired event have processorId as null. processorId is cached as final var in jobCoordinatorListener method. JLS for final fields/variables states that they're initialized before the constructor. This sets local final variable copy as null(since it relies upon value of instance variable to be set in constructor).
Changes

Use processorId directly in createCoordinatorListener method.
Remove StreamProcessor.toString since it has no usages.

@navina Please take a look when you get a chance.
Before fix:
INFO org.apache.samza.processor.StreamProcessor - Shutting down container done for pid=Processor:null; complete =false

After fix:
INFO org.apache.samza.processor.StreamProcessor - Shutting down container done for pid=0000000001; complete =true


fix: removed the diff when default profile changes. Printed the current profile info instead

…ofile info

when finished, if you can put into the PR a triple backticked shell output of what it looks like now, or a screen grab, thanks


Secret no longer matches

I have my own implemention of previews as I'm using graphql and something has changed where the secret sent to api/preview no longer matches what I've set in the module settings. In fact it changes everytime the cache is cleared.
This is what I have in my api/preview
import { NextApiRequest, NextApiResponse } from 'next';
const setCookieSameSite = (res) => {
  const cookies = res.getHeader('Set-Cookie');
  res.setHeader(
    'Set-Cookie',
    cookies?.map((cookie) =>
      cookie.replace('SameSite=Lax', 'SameSite=None;Secure')
    )
  );
};

interface PreviewOptions {
  errorMessages?: {
    secret?: string;
    slug?: string;
  };
}

export default async function preview(
  request: NextApiRequest,
  response: NextApiResponse,
  options?: PreviewOptions
) {
  const { slug, resourceVersion, secret } = request.query;

  if (secret !== process.env.DRUPAL_PREVIEW_SECRET) {
    return response.status(401).json({
      message: options?.errorMessages.secret || 'Invalid preview secret.',
    });
  }

  if (!slug) {
    return response
      .status(401)
      .end({ message: options?.errorMessages.slug || 'Invalid slug.' });
  }

  response.setPreviewData({
    resourceVersion,
  });

  setCookieSameSite(response);

  response.writeHead(307, { Location: slug });

  return response.end();
}

@dottodot Which version of the Next.js module are you using? We switched to preview url generators in Next 1.3 which is more secure than using the preview secret.
Any chance you could try this?

@shadcn I'm using the latest versions for both drupal and next.
I've tried using
export const drupal = new DrupalClient(
  process.env.NEXT_PUBLIC_DRUPAL_BASE_URL,
  {
    frontPage: '/home',
    previewSecret: process.env.DRUPAL_PREVIEW_SECRET,
    auth: {
      clientId: process.env.DRUPAL_CLIENT_ID,
      clientSecret: process.env.DRUPAL_CLIENT_SECRET,
    },
  }
);

await drupal.preview(request, response);

but this gives the following error
Failed to load resource: the server responded with a status of 422 (Unprocessable Entity)

ok found the issue, using https://www.drupal.org/project/require_login so just need to whitelist the /next/preview-url route

ah ha! I see a lot of headless sites now using this module (we do too). I think we should document the routes to whitelist somewhere. I'll work on this.

@shadcn yes that sounds good otherwise it require a bit of digging through the src to work it out


pdns-recursor: 4.3.3 -> 4.3.4

Motivation for this change
Version bump. Changelog is minimal.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I should have done this but can you add the NixOS test to passthru here as well? Thank you.

I should have done this but can you add the NixOS test to passthru here as well? Thank you.

You got it :+1:


Middleware support

Hello,
Following-up to #12, you'll find here support for middlewares + examples. I'm not really yet satisfied about how those are tested and the middlewares should have their own example. I'll rebase the commits along the way.
@tony612 Could you make a quick pass to check if overall the changes are in the right direction and that's it's the kind of design you expected ?

There's an issue with OTP 19.1, I'll check it :)

Don't worry about that CI failure. I just retried it. Sometimes, it failes :(

Hi，I'd like to join this work. I want to migrate the middleware in the golang implenment of gRPC directly.
Do you guys think this is a good idea?

@tooooolong I think we'd better add middleware feature when the next branch is merged to master. I'm not very familiar with middleware in golang grpc, but Elixir and Go are very different, so I doubt that we have to figure out how to do in Elixir.

@tony612 shouldn't we close this now you're working on interceptors?
Also, you were talking about a next branch which I'd love to follow but couldn't find, any infos regarding that?
Thanks for the hard work, cheers :)

@jhchabran next has been merged to master. I'm still working on the client interceptors.


Changed DatabaseUtil (static) into instantiable database manager

This allows us to use the manager in different test harnesses.

Coverage remained the same at 100.0% when pulling 88255148f078fd994ebcc3ddfced3bd0a461c3ad on feature/jersey_test into 31fdc7a099c20e1adc64f0e237f320f61aa5288b on develop.


active.open_and_wait_until_communicating return  False

 active.open()
r = active.open_and_wait_until_communicating(5)
active.add_recv_all_msg_listener(self._recv_all_msg_listener)
# self._send_hand_shake(active)
if not r:
    get_logger().warn('connect open_and_wait_until_communicating return false')

The method open_and_wait_until_communicating returns false. What is the general reason for this

Hi,
I guess that HSMS-SS-state wasn't SELECTED in timeout.
Return True if communicating success.
HSMS-SS-communicating-success is SELECTED state.
Otherwise return False.
If parameter 'timeout' is None, blocking until communicating success, return True.
If parameter 'timeout' is Number value, waiting for timeout value, and return result.
This method is not published in 'README.md'. because the explanation is too long.
I am happy to have found this method.
Thanks regards.


Move websocket to the internal package

This is a proposal of moving WebSocket code into the internal folder and, with that, hiding it from the users and only providing a straightforward interface using the DB implementation
⚠ This PR is based on #25.
⚠ The relevant commit on this one is https://github.com/surrealdb/surrealdb.go/commit/a49d7bfbbf93498667abf5a70fe1499cd39a519a

Hi @ffrizzo I'm not sure if this is relevant since #27 has been merged?


Error: Could not resolve module<EMAIL_ADDRESS>

Environment

Operating System: Linux
Node Version:     v18.17.1
Nuxt Version:     3.8.2
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      app, sourcemap, vite, components, modules, i18n, runtimeConfig, googleFonts, build, css
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-ihvwd9-nbwn5u
Describe the bug
After the release of RC6 I'm getting this error in my projects, with npm run dev, npm run build or even on a fresh install (see reproduction):
 ERROR  Could not resolve module<EMAIL_ADDRESS>                                   2:47:20 PM

  at setupAlias (node_modules/@nuxtjs/i18n/dist/module.mjs:120:13)
  at async setup (node_modules/@nuxtjs/i18n/dist/module.mjs:1243:5)
  at async normalizedModule (node_modules/@nuxt/kit/dist/index.mjs:2224:17)
  at async Module.installModule (node_modules/@nuxt/kit/dist/index.mjs:2522:95)
  at async initNuxt (node_modules/nuxt/dist/index.mjs:3719:7)
  at async loadNuxt (node_modules/nuxt/dist/index.mjs:3806:5)
  at async loadNuxt (node_modules/@nuxt/kit/dist/index.mjs:2667:19)
  at async Object.run (node_modules/nuxi/dist/chunks/prepare.mjs:71:18)
  at async runCommand$1 (node_modules/nuxi/dist/shared/nuxi.4fde776c.mjs:1678:16)
  at async runCommand$1 (node_modules/nuxi/dist/shared/nuxi.4fde776c.mjs:1669:11)

Additional context
No response
Logs
No response

same problem

Let's track this issue here https://github.com/nuxt-modules/i18n/issues/2556

Same problem


Can't install goby with "go get"

Before you submit the issue, please provide us following information:

Your operating system

Linux version 4.4.0-93-generic (buildd@lgw01-03) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) ) #116-Ubuntu SMP Fri Aug 11 21:17:51 UTC 2017

How did you install Goby
Goby version
The value of $GOBY_ROOT
Error messages

If you have trouble building Goby on your machine, please check $GOPATH and $GOROOT
I'm trying to install goby with go get github.com/goby-lang/goby and i'm getting the folowing error: package plugin: unrecognized import path "plugin" (import path does not begin with hostname)
go version:  go1.7.3 linux/amd64

The reason of this error is because Go can't find its plugin standard package. Can you type go env and post the result here?

@st0012  I just noticed the plugin standard package was introduced in Go 1.8 and i'm using Go 1.7
So an update to the installation from source section should be made specifying Go 1.8 is needed?

Sorry I forgot to mention that we're currently using Go 1.9. Other versions won't compile


Redefinition of module 'CommonCryptoBridge'

I am writing a framework and an app that consumes the framework. However the framework is not contained as a sub-project in the app. The framework compiles and I link to this compiled framework from the app. I am using CommonCryptoModule in my framework (through cocoapods) and everything works fine. Now when I try to integrate the framework with the app and run it I get the error dylib not found. So I again linked the app to CommonCryptoModule (in addition to the framework) using cocoapods and attempted to recompile and I get this error:
TestApp/Pods/CommonCryptoModule/CommonCryptoModule/CommonCryptoBridge/module.modulemap:1:8: error: redefinition of module 'CommonCryptoBridge'
module CommonCryptoBridge [system] {
^
SwiftProtocols/Pods/CommonCryptoModule/CommonCryptoModule/CommonCryptoBridge/module.modulemap:1:8: note: previously defined here
module CommonCryptoBridge [system] {
^
:0: error: could not build Objective-C module 'CommonCryptoModule'
I am unable to get past this issue. Any help would be greatly appreciated. Thanks

Hey, I'm not yet sure how to solve your particular issue. But please be aware that using this module may cause iTunes Connect to reject your binary. Link: https://stackoverflow.com/a/48481667/1607485


Can't debug on Linux because source paths are mangled

After building on Ubuntu, I tried to use VS Code to debug into MSBuild and it almost worked, but failed because the debug information maps the root of the MSBuild repo to /_/, and VS Code can't find those files.

I worked around this with
sudo ln -s /home/raines/src/msbuild /_

but that's pretty annoying.


Can't change zoom level in Slack

Describe the bug
When using Slack you cannot change the zoom level as described in the Slack help:
https://slack.com/intl/en-ca/help/articles/236067467-adjust-your-zoom-level-in-slack
To Reproduce
Steps to reproduce the behavior:

Add Slack
Use the steps in the help article linked above
Alternatively use View > Zoom In

Expected behavior
Text becomes bigger
Desktop (please complete the following information):

OS: macOS

Happens to me too (Windows 10) and isn't limited to Slack, but all the services. I can CTRL-0 to reset the zoom, but the CTRL- and CTRL+ do nothing. Trying the Zoom In/Out from the View menu does nothing either.
It used to work, but not now. Version 5.4.0-beta-3.

As a fix in the meantime, View -> Toggle Developer Tools and execute this Javascript in the console:
const webviews = document.getElementsByTagName('webview');
for (let e of webviews) {
  e.setZoomLevel(2);
}

Where 2 is the zoom level you want.


Suggest to support "clever references" with "+"

Since pandoc-xnos seems to be dead for now and it doesn't really support pandoc 3.x (e.g. pandoc-fignos is broken due to the new AST format), migrating to this native LUA implementation sounds like a good idea. But it would be beneficial if we could keep the documents written for pandoc-xnos...
So one of the differences is the "clever references" feature available in pandoc-xnos. The difference is the following:

pandoc-xnos:

@fig:myfigure is simply replaced with the number of the figure (e.g. 1).
+@fig:myfigure is replaced with the caption + number (e.g. Figure 1)

luarefnos:

@fig:myfigure is replaced with the caption + number (e.g. Figure 1)

Ideally, my suggestion is to implement exactly the same syntax as pandoc-xnos.
But if that is too complex, maybe it is possible to implement deletion of the + sign right before the reference.
Explanation:

Today @fig:myfigure in luarefnos does the same as +@fig:myfigure in pandoc-xnos. Namely, it emits caption + number (e.g. Figure 1)
If someone has a document written for pandoc-xnos, they are likely to have something like:Please see +@fig:myfigure for more details.

If they migrate to luarefnos, this line will be rendered as:Please see +Figure 1 for more details.

So it is almost like the clever reference, but there is this + that should not be there...

Sounds good, but it's not straightforward at all to implement this. @fig:myfigure is parsed as a native Citation:
ts@liag0002:~$ echo '@fig:myfigure' | pandoc -t native
[ Para
    [ Cite
        [ Citation
            { citationId = "fig:myfigure"
            , citationPrefix = []
            , citationSuffix = []
            , citationMode = AuthorInText
            , citationNoteNum = 1
            , citationHash = 0
            }
        ]
        [ Str "@fig:myfigure" ]
    ]
]
$ echo '+@fig:myfigure' | pandoc -t native
[ Para
    [ Str "+"
    , Cite
        [ Citation
            { citationId = "fig:myfigure"
            , citationPrefix = []
            , citationSuffix = []
            , citationMode = AuthorInText
            , citationNoteNum = 1
            , citationHash = 0
            }
        ]
        [ Str "@fig:myfigure" ]
    ]
]

This is handled by the citation handler.
+@fig:myfigure is parsed as the string + followed by the citation, so it's not possible to match on prefixes before the @ sign.

$ echo '+@fig:myfigure' | pandoc -t native
[ Para
    [ Str "+"
    , Cite
        [ Citation
            { citationId = "fig:myfigure"
            , citationPrefix = []
            , citationSuffix = []
            , citationMode = AuthorInText
            , citationNoteNum = 1
            , citationHash = 0
            }
        ]
        [ Str "@fig:myfigure" ]
    ]
]


Update scalafmt-core to 2.7.2

Updates org.scalameta:scalafmt-core from 2.7.1 to 2.7.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #434 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #434   +/-   ##
========================================
  Coverage    77.25%   77.25%
========================================
  Files           46       46
  Lines         1051     1051
  Branches        30       30
========================================
  Hits           812      812
  Misses         239      239

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf2c60...3b31cd6. Read the comment docs.


Add rate-limiting on successful signons on the RequestTokenSignOn handler

Add rate limiting on successful sign-ons
BigCache global eviction window
The global eviction window is 12 hours
There was no way to set a 24 hour window on
a bigCache key so I set the limit at 5 requests/12 hour window.
/fixes #116
/claim #116

@dm161 golangci-lint seems to always fail. Is there a way I can try it locally to make sure I fix any lint issues before "pushing"

@dm161 requested changes completed

thank you @jemiluv8


fix: use BrowserRouter instead of HashRouter

📝 Description
HashRouter doesn't support the location.state as seen here
We use electron-serve to support the BrowserRouter
❓ Context

Impacted projects: ledger-live-desktop
Linked resource(s): ``

✅ Checklist

[ ] Test coverage Manually tested
[x] Atomic delivery
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Close for now as I cannot make it work for now with the asar builds for prod


[Bug](thread token) Fix invalid thread token

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.94 seconds
load time: 452 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215105510_clickbench_pr_63920.html


"ignoreKeywords" for "selector-no-redundant-nesting-selector"

Context : to enhance the lisibilty of our SCSS files,  we have decided to use nesting sign & before  > and +.
So we've tried to add stylelint rule selector-no-redundant-nesting-selector with the option ignoreKeywords for > and +, but the use of this rule exception seems to doesn't work (with string or regex).
In the documentation, it's writthen "if you are using Less or some other non-SCSS syntax, the warnings can be disabled by using ignoreKeywords option".
Is ignoreKeywords only available for other framework than sass ?
Is it a bug ?
Did we made a mistake in implemantation ?
Here is the different codes we've tried :
"scss/selector-no-redundant-nesting-selector": [       true, {         "ignoreKeywords": ["[>+]"]       }     ]
"scss/selector-no-redundant-nesting-selector": [       true, {         "ignoreKeywords": ["/[>+]/"]       }     ]
"scss/selector-no-redundant-nesting-selector": [       true, {         "ignoreKeywords": ["+", ">"]       }     ]
Thanks in advance for you're feedback

Thanks @malika-hanotte !
I think that the problem is that the ignoreKeywords option was added for a different use case.
It's meant to allow the rule to ignore keywords that can be used in some non-SCSS syntaxes (e.g. LESS) to allow it work as it should, but you are trying to use it to ignore the combinators in the selector (e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/Adjacent_sibling_combinator).


Add optional notify param. Default to false

This commit is in response to my issue #169
By default, angular-permission sets {notify: false}, so when the a permission is denied and redirectTo is present, $state.go(...) is called to transition to the state but with {notify: false} I only get a changed URL with no page loaded. It seems some others are having this issue as well.
This commit keeps the default false value but provides an optional true value for someone like me having an issue.

Your solution is right.
I think Narzerus had problems with his karma system...


Adding features

added compile_filter and pcap_loop
Trying to have Incoming but I'm having a LIFETIME of headache BaDamTSS

Look at the commits to see the added features


Azure Blob Storage List Blobs does not return Marker

Expected Behavior
When using the following code on a Azure Blob storage account with more than 10 files the marker value is not returned, but always returns an empty string:
var bindingSettings = new { maxResults = 10 };
var bindingSettingsBytes = JsonSerializer.SerializeToUtf8Bytes(bindingSettings);
bindingRequest.Data = new ReadOnlyMemory<byte>(bindingSettingsBytes);
var response = await _daprClient.InvokeBindingAsync(bindingRequest);

response.Metadata.TryGetValue("marker", out marker);

I would expect the marker variable to have the marker value.
I have tested it with a local Azurite blob storage account, but also an online Azure Blob Storage account. Both just return the first 10 results and an empty string as marker. This way we don't got any way to iterate through all pages.
Tested the same query using the AZ CLI, to confirm that it wasn't an issue in Azure, but that returns the "nextMarker" field correctly as the last object of the result:
az storage blob list --connection-string "[connstring]" -c [containername] --num-results 10 --show-next-marker

Will return:
[
  {
     [blob 1]
  },
  {
    [blob 2]
  },
  .... (total 10 results)
  {
    "nextMarker": "e61534b1-9010-4e8e-838a-46049d01b393/54-spiderfull/property-models/18216611.json"
  }
]

Actual Behavior
The marker value in the response.Metadata object is always ""
Steps to Reproduce the Problem
Use the above code using Dapr with C# and invoke the "list" operation on the binding with a maxResults lower then the number of items in the blob storage account.

Thanks for reporting this, we'll take a look

I don't think this is fixed, so needs to stay open.

Dapr will always iterate through all pages and return everything. However, you can provide the marker to start from in your request if you know the marker.
https://github.com/dapr/components-contrib/blob/2cb3c1cce1de407913615aa0296cba6db34205f7/bindings/azure/blobstorage/blobstorage.go#L298-L321
It's unclear what marker we should return here, other than the provided marker which is empty if none was provided.
I don't see any issue here, but perhaps you are asking for a feature request where Dapr does not iterate through all pages, but only returns a certain number of results. In that case I could certainly understand needing the marker! @rodyvansambeek

For convenience I am adding a new property pagesTraversed in the response metadata of the list operation. This will return the number of pages that were internally traversed.
However, I maintain that I do not see any issue with the component @rodyvansambeek
https://github.com/dapr/components-contrib/pull/3126

@berndverst Thanks for clarifying the inner workings. I will check in the next few days in the project I am working on if it does what it says when don't sending in the maxResults and wanting to retrieve more than 5000 results. I am pretty sure it returned only the first 10 results (while there were hundreds in the blob storage account) without a marker in my test setup. Will let you know as soon as possible. Will also try with a storage account with over 5000 results, to see if it then returns a marker.

@rodyvansambeek if you don't mind - wait until Dapr 1.12 - or the 1.12.0-rc.2 version (if you don't mind trying out our release candidate). That will include the change I made yesterday to also show how many pages were traversed, and that will report the number of items were returned (which now can be at most maxResults + pageSize)

@rodyvansambeek one additional comment here:
If you specify maxResults = 10 -- that is not the page size. This actually tells the server to only return 10 results. Even if more results exist, that does not mean there will pagination for additional results beyond 10 results - the server will not actually return more results.
We do not have a way to control the page size.

@berndverst That was the issue. I assumed that would be the page size, and the marker would be returned after that amount of results. I understand the inner workings now. Maybe it's a good idea to change this in the documentation because if you read the part of the data parameters on: https://docs.dapr.io/reference/components-reference/supported-bindings/blobstorage/#list-blobs
It looks like you need to specify a maxResults and get a marker back for every page to iterate through all the results.


Deletable event lines

You should be able to delete new lines you add to events.

@thatoddmailbox i dont understand what you are saying... please explain. events? lines? deletion? I DONT UNDERSTAND

@willweinstein
tl;dr: if it doesn't have a subId of 0, it's stuck forever/until I clear the db.
Steps to reproduce

go to planner

write two lines in any box
reload
look at box
delete second line
reload
notice how the box still has a line (it probably will have two blank line)
try to delete the blank lines
reload
see how lines are still there
be sad

@thatoddmailbox why u make me so sad

@willweinstein what?

@thatoddmailbox

be sad

@willweinstein
Oh, that.
:P

This is partially fixed as of the latest commit.

Yay I think it's fixed (haven't yet merged to master though)

Um don't think so unless you didn't yet put it on stable...

@robotXlabs:

haven't merged it to stable yet though
@thatoddmailbox

Sorry, Closed by accident

This is finished, so it should be closed.

:facepalm:

^What happened to the emoji?^

@nywillb we had a facepalm icon?

I thought so
On Thu, Dec 10, 2015 at 9:38 PM thatoddmailbox<EMAIL_ADDRESS>wrote:

@nywillb https://github.com/nywillb we had a facepalm icon?
—
Reply to this email directly or view it on GitHub
https://github.com/PlanHubMe/PlanHub/issues/173#issuecomment-163818709.

Look at #167
On Thu, Dec 10, 2015 at 9:39 PM William B<EMAIL_ADDRESS>wrote:

I thought so
On Thu, Dec 10, 2015 at 9:38 PM thatoddmailbox<EMAIL_ADDRESS>wrote:

@nywillb https://github.com/nywillb we had a facepalm icon?
—
Reply to this email directly or view it on GitHub
https://github.com/PlanHubMe/PlanHub/issues/173#issuecomment-163818709.


Update Strings.pl-PL.axaml

Updated the Polish translation as a large chunk of strings were simply missing a translation
hopefully nothing get accidentally broken in the strings

What exactly is a "workflow awaiting approval" this request appears to be a bit stuck with, if I may ask?


IE11: Fallback to MediaElement not working, it always tries to access AudioContext

README says that the player will fall back on audio element (without graphics) on browser that don't support WebAudio (i.e. IE 11), but still it doesn't look to work at all if WebAudio is missing.
IE 11, for example, throws an error because wavesurfer tries to access AudioContext or window.webkitAudioContext, I think from here: https://github.com/katspaugh/wavesurfer.js/blob/ff5d8b442bc503890068b5a206eaf9142fffbf1f/src/webaudio.js#L76-L77
You can test the issue just by opening the audio element example page on your site in IE 11. Here's the error in the browser console (pardon the Italian locale, the red text says something like "Invalid action for the object"):

Maybe the fallback mechanisms has been dropped in newer releases? Thanks.
Wavesurfer.js version(s): 2.2.1
Browser version(s): Internet Explorer 11

@lorenzos the MediaElement extends the WebAudio backend, so it shares that code.
what does wavesurfer.backend.supportsWebAudio() return?

@lorenzos the MediaElement extends the WebAudio backend, so it shares that code.

In fact, I see. I think the problem is exactly here. The MediaElement backend constructor calls super(), so this line in WebAudio is run, and the getAudioContext() method is called, throwing the error in IE 11.

what does wavesurfer.backend.supportsWebAudio() return?

I can't tell, because I'm not able to construct any wavesurfer instance in IE 11. However, if the code is simply !!(window.AudioContext || window.webkitAudioContext) as I see, it will return false.

@lorenzos that's the line, yep. What if you pass in a fake audiocontext using the options, e.g. audioContext: {}?

@thijstriemstra It does work!

So we need some check in the MediaElement class that makes sure params.audioContext is an empty object when it's run in the IE11 browser. Want to make a PR for that @lorenzos?

Sure.

Done. The Audio Element demo still doesn't work in IE 11, but now it's just because IE doesn't support WAV files playback. I tried using an MP3 instead (this is not included in the PR, obviously) and it works as expected: plain line, no waveform, but playing and seeking correctly.

Thanks. Perhaps we can have the main example on the website (and the audio element example) load an mp3 instead. Is mp3 supported on all browsers?

Looks like it's supported everywhere.

I tried using an MP3 instead (this is not included in the PR, obviously) and it works as expected: plain line instead of waveform, but playing and seeking correctly.

Maybe I misunderstand, but are you saying it also doesn't work with mp3 in IE11?

Once the AudioContext issue is fixed, the demo still doesn't work in IE 11 since it doesn't support WAV files. It works if you use an MP3 instead.

That's good news. Leaving the demo's with .wav is fine then, if people want to use IE11 they'll figure out MP3 is their only option.

Thanks for this fix!
I have to use a minified version for work & had to add this fix in the minified way.
Here it is in case anyone needs to replace before the new release
i.ac = e.audioContext || (i.supportsWebAudio() ? i.getAudioContext() : {}),


Refactor the WorkspaceSettingsPage

cc @HorusGoul @tgolen
Details

This PR refactors some bad smells:

It moves API actions from WorkspaceSettingsPage.js to actions/Policy.js
The actions do not return Promise anymore as this is not required in this case
Use Onyx as source of truth

Additionally, I have added a small change in the flow (which we can discuss if we want to keep) which is the avatar being saved in the policy when it is uploaded. Currently, user needs to upload the avatar, wait for it to load and then click Save to actually save the avatar into the policy.
After this refactoring, the avatar flow is independent on the name/currency flow, so the new picture is saved to our database once it is uploaded.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180546
Tests

This is a refactoring of the Workspace settings editor. We need to make sure uploading a new avatar for workspace or changing name/currency still works as expected.

Go to your workspace's General settings.
Click on the avatar and pick some image to use as avatar and upload it.
Success Growl message should show indicating the upload has been successful.
Exit the right hand side panel, reload the page (potentially even clearing your cache) and make sure the workspace has the new picture as its avatar.
Go back to the workspace settings and change name of the workspace. Click Save.
Exit the setting page, reload the page and make sure the name of the settings is changed.
Lastly, go back to the settings page, click on the Avatar and remove it. Make sure it is removed and the placeholder image is shown (even after reloading).

QA Steps

Same as tests above.
Tested On

[x] Web
[ ] Mobile Web
[x] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

https://user-images.githubusercontent.com/36083550/138750619-a624f6b7-a6f3-4b42-8016-2a5dd982c1fb.mov
Mobile Web

Desktop

iOS

Android

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update pre-commit configuration

@TomasTomecek could you please have a look regarding the mypy corrections?
It's in separate commit with comment in commit description.


add attrs accessor

For some reasons, one might want to access the inner type language field since the high-level api grammers-client haven't caught up yet. In my case, I want to access the InputStickerSet of the Sticker struct.
I saw that we already have a unstable_raw feature so how about adding something like raw_tl function. I am willing to contribute if that makes sense.

Reusing the unstable_raw feature to expose raw types is the way to go. Yes please, send a PR. Add what you need under the feature. Although we should probably return the entire raw media, not just attrs.


first contributing

A project in react to visualize the sorting algorithm with vertical bars and colors switching.

this repo has been excluded


Documentation Updates

Some small tweaks to documentation.

@blowmage Thank you for following up on these issues!


Create set up associations

This PR contains the creation of the Classroom, Book & Rental classes for our School Library and created the Associations between them.

A school library app to record what books are in the library and who borrows them. The app that you will create will allow you to: add new students or teachers, add new books and save records of who borrowed a given book and when.

Highlights:

Created a class Classroom with the following:

@label instance variable, should be initialized in the constructor.
Setter and getter for @label (remember about attr_accessor).

Created the has-many/belongs-to relationship between Classroom and Student. The following should be implemented:

Created the has-many side (a classroom has many students).
Created the belongs-to side (a student belongs to a classroom).
Made sure that when adding a student to a classroom it also sets the classroom for the student.
Made sure that when setting the classroom for a student it also adds it to the classrooms' students.

Created a class Book with the following:

@title and @author instance variables, should be initialized in the constructor.
Setters and getters for instance variables (remember about attr_accessor).

Created a class Rental with the following:

@date instance variable, should be initialized in the constructor.
Setter and getter for @date (remember about attr_accessor).

Created the many-to-many (also has-many-through) relationship between Person and Book using the intermediate class Rental. The following should be implemented:

Created the has-many side of Book and Rental (a book has many rentals).
Created the belongs-to side of Rental and Book (a rental belongs to a book).
Created the has-many side of Person and Rental (a person has many rentals).
Created the belongs-to side of Rental and Person (a rental belongs to a person).
Modified the constructor of Rental so Book and Person are set in it.

Thanks @DeliceLydia, for approving my PR. 🙏🏾


Fix/tune some tests

Try reduce some of the flaky tests that caused recent Travis failures.

LGTM - Thanks


Understanding the structure of H3.6M dataset

Hi Una-dinosauria,
First of all, I need to thank you for making this fantastic paper and code available publicly and it is really helpful for my academics.
I have a very basic question. Can you please explain the structure of the dataset and what is the meaning of 99 numbers in each row? In the site, they are describing 96 data, but in H3.6M dataset there are 99 data in each raw.

IIRC, the first three numbers are the global translation. The rest are (99-3)/3 = 32 articulations that define the joint angles of the human body.
You may want to look at https://github.com/una-dinosauria/human-motion-prediction/issues/21#issuecomment-348038807 to get see how you can visualize the data. Following the visualization code should make it clear what the data means.
Cheers,

Hi!
No, sorry I can't do that. You can use our code to visualize and perhaps some more code to measure standard deviations so you can find out.
Cheers,

Thank you for the support.