Evaluate expression for index iterator.

@erizocosmico - PTAL if it really makes sense.
It should fix https://github.com/src-d/go-mysql-server/issues/238, but maybe there is a simpler/nicer fix.
Signed-off-by: kuba--<EMAIL_ADDRESS>

If we extend 	IndexKeyValueIter by expressions:
IndexKeyValueIter(ctx *Context, colNames []string, expressions []Expression) (IndexKeyValueIter, error)

@ajnavarro what's the specific reason we need to return the column values instead of the value of the indexed expressions if that's what we're going to store?

IndexKeyValueIter is used to generate the index, so the implementation must be done by the data source implementor, in this case, gitbase.
IndexValueIter is used to retrieve index values from given keys. The implementor of this interface is the specific index, in this case ´pilosa´ index.
I think we shouldn't give the responsibility of evaluating the expression to gitbase in this case, and do it in a generic way on go-mysql-server side.
To be able to get the expression to evaluate it, first of all, we need to check into the indexes rule if any of the expressions has an index. If yes, we should keep that expression, because we cannot transform an Expression hash into an Expression object.

@kuba-- can you rebase instead of creating a merge commit?

I'll send update in a minute

@erizocosmico can you have a look please?


Add Homebrew release as the final step of the release

Homebrew releases should happen after we successfully release to GitHub and PyPI.
Release to homebrew if:

This is not a test run
The release was otherwise successful
We are not releasing dbt-spark

Unknowns

Should we release every pre-release?  Only some?
How can we determine if this should be marked as latest?  #73 might help inform this.
Is there a way to test this?

Current release workflow live in homebrew-dbt: formula.yml

This makes this most sense to be it's own workflow.  Not really sure it should live in here or just be a step in the existing release flows in each repo (ex: dbt-core release.yml) where we callout to formula.yml.


Makefile deploy-with-olm: override the csv version

When running the CI from a tagged version (i.e. when doing releases), we need to override the csv version too as the tagged version is not main and CI would fail.

Is this a BUG FIX or a FEATURE ?:
Fixing release CI when the pinned version is not main and the csv version gets scrambled.

Uncomment only one, leave it on its own line:
/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:
Special notes for your reviewer:
Release note:

NONE

We are hitting this failure https://github.com/metallb/metallb-operator/actions/runs/8815094152/job/24197005667?pr=464
Tracked on https://github.com/microsoft/linux-package-repositories/issues/130


Video option

# Configure the Libvirt provider
provider "libvirt" {
  uri = "qemu:///system"
}

resource "libvirt_domain" "pfSense" {
  name = "pfSense"
  vcpu = 4
  memory = 4096
  running = true
  autostart = true
  disk {
    volume_id = "${libvirt_volume.pfSense.id}"
  }
  network_interface {
    network_name = "pfSense"
    hostname = "pfSense"
  }
}

resource "libvirt_volume" "pfSense" {
  name = "pfSense"
  source = "/var/lib/libvirt/images/pfSense.qcow2"
}

Generates error and will not start, but going into virt-manager, changing video from Cirrus to QXL and container boots successfully.  There was also a device called qemu-ga, but no idea what that even is, deleted as well from config.

Try defining graphics few options that have worked for me.
https://github.com/dmacvicar/terraform-provider-libvirt/blob/master/website/docs/r/domain.html.markdown#graphics-devices
  graphics {
    type = "vnc"
    listen_type = "address"
  }

  graphics {
    type = "spice"
    listen_type = "address"
    autoport = true
  }

-HTH

the options you listed are for VNS vs.SPICE, but not the actual graphics hardware for the guest, but thanks

Feel free to send a pull request adding the video option.

I would, but I'm not a programmer.  Do not pass go, and do not collect $200.

I am working on some vnc additions so I'll see if I can include this. No promises however.

@deasmi Always appreciated.  It's on my list to start learning go, but currently working on a lot of "infrastructure as code".  Once I get that done, I might have a few working brain cells left to start learning something new.

Can we add this to 0.1 ?

@jfgibbins Can you test if my patch fixes your issue please.
Branch graphicsandvnc on https://github.com/deasmi/terraform-provider-libvirt.git
Pull request #198

We use now xslt for allowing custom parameters to domain network etc. Look at the doc or examples. Tia


test: fix readline test case in node@6

closes #36

Coverage remained the same at 92.0% when pulling 500dc5998d7a5a85d44c2975b09f652cd4cf0b54 on fix-test-in-6 into 1704ccd4b630961deb437f79098cad0d46dd25ea on master.

Nice :tada:


Add initial OS X support

This was originally #5 by @dirk. I rebased and made it build on Linux.

@kamalmarhubi: Thanks so much for finishing this up! Been too busy with work the past couple days to get back to it. 😞


Configure this repo not to allow issues

I think many users won't notice this in the README

Pull requests and issues should be raised at facebook/buck2 as that project is more closely monitored and contains CI checks.

I've love to, but I'm not sure if it is possible (the facebook github org is centrally managed). I'll ask internally.


'for' are faster than 'foreach' in StringValues case

On my computer, for loops are about two times faster than foreach in the StringValues case.
I made the same comparison for string, but foreach is faster in this case.

Hi @Yves57, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

It appears this is indeed faster in micro benchmarks.
@Yves57 How did you compare the performance of for vs foreach? Can you squash the PR?
BenchmarkDotNet=v0.10.0
OS=Windows
Processor=?, ProcessorCount=4
Frequency=2435872 Hz, Resolution=410.5306 ns, Timer=TSC
Host Runtime=.NET Core 4.6.24410.01, Arch=64-bit  [RyuJIT]
GC=Concurrent Server
dotnet cli version=1.0.0-preview2-1-003177
Job Runtime(s):
        .NET Core 4.6.24410.01, Arch=64-bit  [RyuJIT]

RemoveOutliers=False  Runtime=Core  Server=True
LaunchCount=3  RunStrategy=Throughput  TargetCount=10
WarmupCount=5

                      Method |       Mean |    StdErr |    StdDev |     Median | Scaled | Scaled-StdDev |            RPS |
---------------------------- |----------- |---------- |---------- |----------- |------- |-------------- |--------------- |
       ForeachNoStringValues |  9.7111 ns | 0.1124 ns | 0.6155 ns |  9.5933 ns |   1.00 |          0.00 | 102,974,432.55 |
    ForeachSingleStringValue | 11.3858 ns | 0.3622 ns | 1.9841 ns | 10.0909 ns |   1.18 |          0.21 |  87,828,853.88 |
 ForeachMultipleStringValues | 19.8694 ns | 0.1962 ns | 1.0748 ns | 19.4505 ns |   2.05 |          0.17 |  50,328,603.19 |
           ForNoStringValues |  1.8708 ns | 0.0242 ns | 0.1326 ns |  1.8189 ns |   0.19 |          0.02 | 534,517,672.06 |
        ForSingleStringValue |  5.5029 ns | 0.0736 ns | 0.4029 ns |  5.2699 ns |   0.57 |          0.05 | 181,723,118.03 |
     ForMultipleStringValues |  9.0090 ns | 0.0716 ns | 0.3921 ns |  8.8759 ns |   0.93 |          0.07 | 110,999,988.57 |

@halter73
I did the comparison with a simple Console Application, Nothing specific...
About the PR squashing, I'm sorry but I'm definitely better in C# than in GitHub administration! I think that I will restart a new clean PR, and close this one after.

@Yves57 It's not hard 😄 Check this out: http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

Closing this one in favor of https://github.com/aspnet/KestrelHttpServer/pull/1241.

GitHub 1 - Me 0.

Beats me often.
On 29 Nov 2016 9:46 p.m., "Yves57"<EMAIL_ADDRESS>wrote:

GitHub 1 - Me 0.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/KestrelHttpServer/pull/1233#issuecomment-263709732,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APpZufa6JDsgLP6koIuzPy_0giBLEVYxks5rDJ1OgaJpZM4K8UlN
.


Bug for _index_documents_actions when the batch is too large

Package Name:  azure-search-documents==11.5.2
Package Version:  azure-search-documents==11.5.2
Operating System: Linux
Python Version:  python 3.10

Describe the bug
The exception's handling will trigger keyerror for error_map
Function: def _index_documents_actions(self, actions: List[IndexAction], **kwargs: Any) -> List[IndexingResult]:
The key reason is the index() function will expect to pop error_map from kwargs, so you have to include it in the kwargs
To Reproduce
Steps to reproduce the behavior:

Simply read a json file over 2k documents and upload the documents
`

read json file
with open(json_file_path, "r") as file:
    documents = json.load(file)

search_client = SearchClient(
    endpoint=service_endpoint, index_name=index_name, credential=credential
)

result = search_client.upload_documents(documents=documents)

`
Expected behavior
Items should be splitted by half and get inserted to the index
Screenshots

Additional context
I fixed the hanlding by having the error_map in the kwargs:
`
def _index_documents_actions(self, actions: List[IndexAction], **kwargs: Any) -> List[IndexingResult]:
error_map = {413: RequestEntityTooLargeError}
kwargs["headers"] = self._merge_client_headers(kwargs.get("headers"))
kwargs["error_map"] = error_map
batch = IndexBatch(actions=actions)
try:
batch_response = self._client.documents.index(batch=batch,  **kwargs)
return cast(List[IndexingResult], batch_response.results)
except RequestEntityTooLargeError:
if len(actions) == 1:
raise
pos = round(len(actions) / 2)
batch_response_first_half = self._index_documents_actions(
actions=actions[:pos],  **kwargs
)
if batch_response_first_half:
result_first_half = batch_response_first_half
else:
result_first_half = []
batch_response_second_half = self._index_documents_actions(
actions=actions[pos:], **kwargs
)
if batch_response_second_half:
result_second_half = batch_response_second_half
else:
result_second_half = []
result_first_half.extend(result_second_half)
return result_first_half
`

Thanks for the feedback, we’ll investigate asap.


Pinky joints when using rigged hand mesh on Leap Motion needs investigation

Describe the bug
User feedback: Pinky joints in the rigged hand mesh behave weirdly when using Leap Motion. Needs further investigation to determine if resolved.

This is due to some joint alignment weirdness in the hand model we're using. The pinky joint is a little bit crooked for some reason. I can take another look at our mesh and try and un-kink the pinky joint.


0.20.0 release notes typo

The GCP section of the 0.20.0 release notes contains the following:
BOSH AWS CPI 29.0.0
Pretty sure that is supposed to reference GCP.  The download link is correct.
There... I've added value today!  ;-)

Mmmm, nothing quite like tasty copypasta.
Thanks for pointing this out, we'll fix that :)

I've fixed it in the 0.20.0 release. Will also fix the script that generates that part of the release notes.


Correct the typo in Juniors

There was a small typo on one of the pages.
JIRA:
https://netguru.atlassian.net/browse/PEOPLE-44

:+1:


odo url create with --secure flag does not create secured url for both route and ingress flags

/kind bug
What versions of software are you using?
Operating System:
MacOS v11.6
Output of odo version:
odo v2.4.1 (143a1b31e)
Server: https://c100-e.eu-de.containers.cloud.ibm.com:30467
Kubernetes: v1.20.0+bbbc079
How did you run odo exactly?
Ran
TEST_EXEC_NODES=12 make test-cmd-devfile-status
For:
odo url create my-url --port 3000 --secure --ingress --host dytetdpoqmaf.com
See that secure returns false when expecting true, and url is http instead of https
{"urlReachable":{"name":"3000-tcp","url":"http://3000-tcp-app-cmd-devfile-status-test53kfe.odo-tests-cluster-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud","port":3000,"secure":false,"kind":"route","reachable":true,"timestamp":"1636393576.306407"}}
Actual behavior

Returns "secure":false
url is hhtp

Expected behavior

Should return "secure":true
url should be https

Any logs, error output, etc?
Creating a new project: cmd-devfile-status-test53kfe
Running odo with args [odo project create cmd-devfile-status-test53kfe -w -v4]
[odo] I1108 12:45:49.367147   47366 preference.go:210] The path for preference file is /Users/rnapoles/.odo/preference.yaml
[odo] I1108 12:45:49.368057   47366 util.go:787] HTTPGetRequest: https://raw.githubusercontent.com/openshift/odo/master/build/VERSION
[odo] I1108 12:45:49.368347   47366 segment.go:246] Checking telemetry enable status
[odo] I1108 12:45:49.368361   47366 segment.go:259] Sending telemetry disabled by ODO_DISABLE_TELEMETRY=true
[odo] I1108 12:45:49.368435   47366 util.go:808] Response will be cached in /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/odohttpcache for 1h0m0s
[odo] I1108 12:45:49.368916   47366 util.go:482] path /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:49.368972   47366 util.go:482] path /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/.devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:49.369023   47366 util.go:821] Cached response used.
[odo]  •  Waiting for project to come up  ...
[odo] I1108 12:45:50.041179   47366 kclient.go:231] Checking if "projects" resource is supported
[odo] I1108 12:45:51.428848   47366 projects.go:192] Status of creation of project cmd-devfile-status-test53kfe is Active
[odo] I1108 12:45:51.428869   47366 projects.go:197] Project cmd-devfile-status-test53kfe now exists
[odo] I1108 12:45:51.574422   47366 namespace.go:186] Status of creation of service account &ServiceAccount{ObjectMeta:{default  cmd-devfile-status-test53kfe /api/v1/namespaces/cmd-devfile-status-test53kfe/serviceaccounts/default f99ee1e6-ebb8-41f8-88c5-1931b32de7b0 26591565 0 2021-11-08 12:45:50 -0500 EST <nil> <nil> map[] map[] [] []  []},Secrets:[]ObjectReference{ObjectReference{Kind:,Namespace:,Name:default-token-lpn27,UID:,APIVersion:,ResourceVersion:,FieldPath:,},ObjectReference{Kind:,Namespace:,Name:default-dockercfg-rz7k7,UID:,APIVersion:,ResourceVersion:,FieldPath:,},},ImagePullSecrets:[]LocalObjectReference{LocalObjectReference{Name:default-dockercfg-rz7k7,},},AutomountServiceAccountToken:nil,} is ready
 ✓  Waiting for project to come up [2s]
[odo]  ✓  Project "cmd-devfile-status-test53kfe" is ready for use
[odo] I1108 12:45:51.578027   47366 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  New project created and now using project: cmd-devfile-status-test53kfe
Running oc with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-devfile-status-test53kfe]
[oc] configmap/config-map-for-cleanup created
Current working dir: /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile
Running odo with args [odo registry update DefaultDevfileRegistry https://registry.stage.devfile.io -f]
[odo] I1108 12:45:52.515713   47387 preference.go:210] The path for preference file is /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/preference.yaml
[odo] I1108 12:45:52.515830   47387 util.go:808] Response will be cached in /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/odohttpcache for 1h0m0s
[odo] I1108 12:45:52.516050   47387 preference.go:210] The path for preference file is /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/preference.yaml
[odo] Successfully updated registry
[odo] I1108 12:45:52.516254   47387 util.go:821] Cached response used.
[odo] I1108 12:45:52.516517   47387 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
Setting current dir to: /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461
Running odo with args [odo create --project cmd-devfile-status-test53kfe qmhhhq --devfile /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/examples/source/devfiles/nodejs/devfile.yaml]
[odo] I1108 12:45:52.580845   47388 util.go:482] path /private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.580835   47388 util.go:808] Response will be cached in /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/odohttpcache for 1h0m0s
[odo] I1108 12:45:52.581063   47388 util.go:482] path /private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/.devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581095   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581100   47388 util.go:482] path .devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581105   47388 util.go:482] path .odo/env/env.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581151   47388 util.go:482] path .odo/env/env.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581156   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581160   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581341   47388 util.go:821] Cached response used.
[odo] Devfile Object Validation
[odo] I1108 12:45:52.581558   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581566   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581575   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581579   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581629   47388 util.go:482] path /private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.581638   47388 util.go:482] path /private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/.devfile.yaml doesn't exist, skipping it
[odo]  •  Creating a devfile component from devfile path: /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/examples/source/devfiles/nodejs/devfile.yaml  ...
 ✓  Creating a devfile component from devfile path: /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/examples/source/devfiles/nodejs/devfile.yaml [63145ns]
[odo] Validation
[odo]  •  Validating if devfile name is correct  ...
 ✓  Validating if devfile name is correct [38148ns]
[odo] I1108 12:45:52.581701   47388 util.go:482] path devfile.yaml doesn't exist, skipping it
[odo] I1108 12:45:52.582527   47388 content.go:33] converted devfile YAML to JSON
[odo] I1108 12:45:52.582584   47388 apiVersion.go:45] devfile schemaVersion: '2.0.0'
[odo] I1108 12:45:52.582593   47388 helper.go:41] devfile apiVersion '2.0.0' is supported
[odo] I1108 12:45:52.588951   47388 schema.go:46] validated devfile schema
[odo] I1108 12:45:52.590110   47388 validate.go:45] Successfully validated devfile sections
[odo] I1108 12:45:52.590120   47388 validate.go:45] Successfully validated devfile sections
[odo] I1108 12:45:52.590129   47388 preference.go:210] The path for preference file is /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/preference.yaml
[odo] I1108 12:45:52.590588   47388 context.go:141] absolute devfile path: '/private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml'
[odo] I1108 12:45:52.590598   47388 context.go:92] absolute devfile path: '/private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml'
[odo] I1108 12:45:52.590859   47388 content.go:33] converted devfile YAML to JSON
[odo] I1108 12:45:52.590899   47388 apiVersion.go:45] devfile schemaVersion: '2.0.0'
[odo] I1108 12:45:52.590904   47388 helper.go:41] devfile apiVersion '2.0.0' is supported
[odo] I1108 12:45:52.594104   47388 schema.go:46] validated devfile schema
[odo] I1108 12:45:52.594227   47388 validate.go:45] Successfully validated devfile sections
[odo] I1108 12:45:52.595173   47388 writer.go:30] devfile yaml created at: 'devfile.yaml'
[odo]
[odo] Please use `odo push` command to create the component with source deployed
[odo] I1108 12:45:52.596359   47388 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo with args [odo url create my-url --port 3000 --secure --ingress --host dytetdpoqmaf.com]
[odo] I1108 12:45:52.656850   47389 util.go:808] Response will be cached in /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/odohttpcache for 1h0m0s
[odo] I1108 12:45:52.657263   47389 util.go:821] Cached response used.
[odo] I1108 12:45:53.479652   47389 context.go:141] absolute devfile path: '/private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml'
[odo] I1108 12:45:53.479663   47389 context.go:92] absolute devfile path: '/private/var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461/devfile.yaml'
[odo] I1108 12:45:53.479976   47389 content.go:33] converted devfile YAML to JSON
[odo] I1108 12:45:53.480018   47389 apiVersion.go:45] devfile schemaVersion: '2.0.0'
[odo] I1108 12:45:53.480026   47389 helper.go:41] devfile apiVersion '2.0.0' is supported
[odo] I1108 12:45:53.483772   47389 schema.go:46] validated devfile schema
[odo] I1108 12:45:53.485216   47389 validate.go:45] Successfully validated devfile sections
[odo] I1108 12:45:53.485244   47389 validate.go:45] Successfully validated devfile sections
[odo] I1108 12:45:53.703781   47389 kclient.go:231] Checking if "routes" resource is supported
[odo] I1108 12:45:53.908275   47389 writer.go:30] devfile yaml created at: 'devfile.yaml'
[odo]  ✓  URL my-url created for component: qmhhhq
[odo]
[odo] To apply the URL configuration changes, please use `odo push`
[odo] I1108 12:45:53.908618   47389 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo with args [odo push -o json --project cmd-devfile-status-test53kfe]
[odo] {"devFileCommandExecutionBegin":{"commandId":"devbuild","componentName":"runtime","commandLine":"npm install","groupKind":"build","timestamp":"1636393567.124796"}}
[odo] {"logText":{"text":"npm notice created a lockfile as package-lock.json. You should commit this file.","stream":"stderr","timestamp":"1636393570.516822"}}
[odo] {"logText":{"text":"npm WARN<EMAIL_ADDRESS>No repository field.","stream":"stderr","timestamp":"1636393570.584368"}}
[odo] {"logText":{"text":"added 66 packages from 58 contributors and audited 66 packages in 2.098s","stream":"stdout","timestamp":"1636393570.584397"}}
[odo] {"logText":{"text":"","stream":"stderr","timestamp":"1636393570.584406"}}
[odo] {"logText":{"text":"found 0 vulnerabilities","stream":"stdout","timestamp":"1636393570.584427"}}
[odo] {"logText":{"text":"","stream":"stdout","timestamp":"1636393570.584437"}}
[odo] {"devFileCommandExecutionComplete":{"commandId":"devbuild","componentName":"runtime","commandLine":"npm install","groupKind":"build","timestamp":"1636393570.584468"}}
[odo] {"devFileCommandExecutionBegin":{"commandId":"devrun","componentName":"runtime","commandLine":"npm start","groupKind":"run","timestamp":"1636393570.584509"}}
[odo] {"logText":{"text":"devrun: started","stream":"stdout","timestamp":"1636393572.492499"}}
[odo] {"devFileCommandExecutionComplete":{"commandId":"devrun","componentName":"runtime","commandLine":"npm start","groupKind":"run","timestamp":"1636393572.494571"}}
Running odo with args [odo component status -o json --project cmd-devfile-status-test53kfe --follow]
[odo] {"kubernetesPodStatus":{"pods":[{"name":"qmhhhq-app-6d7fd45fb9-j9n74","uid":"75b61f73-cae8-40f5-b0ad-56d873f7e279","phase":"Running","labels":{"app":"app","app.kubernetes.io/instance":"qmhhhq","app.kubernetes.io/managed-by":"odo","app.kubernetes.io/managed-by-version":"v2.4.1","app.kubernetes.io/name":"","app.kubernetes.io/part-of":"app","component":"qmhhhq","pod-template-hash":"6d7fd45fb9"},"startTime":"1636393557.000000","containers":[{"name":"runtime","state":{"running":{"startedAt":"2021-11-08T17:46:01Z"}},"lastState":{},"ready":true,"restartCount":0,"image":"registry.access.redhat.com/ubi8/nodejs-12:1-36","imageID":"registry.access.redhat.com/ubi8/nodejs-12@sha256:c691d5de6ddefe45bec53a35f6bc54a0fe420960196ddb12656c6f9331a39c03","containerID":"cri-o://c76019056fe158960d93887c02650adfa633733e837c4f0ed851bfc31ec8ecd0","started":true}],"initContainers":[{"name":"copy-supervisord","state":{"terminated":{"exitCode":0,"reason":"Completed","startedAt":"2021-11-08T17:45:58Z","finishedAt":"2021-11-08T17:45:58Z","containerID":"cri-o://c000c46ac5b8e353e44dd1e63100bb0b78306426010486d263c2ebe4db9c4041"}},"lastState":{},"ready":true,"restartCount":0,"image":"registry.access.redhat.com/ocp-tools-4/odo-init-container-rhel8:1.1.10","imageID":"registry.access.redhat.com/ocp-tools-4/odo-init-container-rhel8@sha256:0b25f37779ac09c197ef18e003cc6e49ac590cc79b058783f6f0a21eeb81581b","containerID":"cri-o://c000c46ac5b8e353e44dd1e63100bb0b78306426010486d263c2ebe4db9c4041"}]}],"timestamp":"1636393575.768510"}}
[odo] {"urlReachable":{"name":"3000-tcp","url":"http://3000-tcp-app-cmd-devfile-status-test53kfe.odo-tests-cluster-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud","port":3000,"secure":false,"kind":"route","reachable":true,"timestamp":"1636393576.306407"}}
[odo] {"supervisordStatus":{"programStatus":[{"program":"debugrun","status":"STOPPED"},{"program":"devrun","status":"RUNNING"}],"timestamp":"1636393576.586252"}}
Deleting project: cmd-devfile-status-test53kfe
Running odo with args [odo project delete cmd-devfile-status-test53kfe -f]
[odo] I1108 12:46:24.649517   47422 util.go:808] Response will be cached in /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/odohttpcache for 1h0m0s
[odo] I1108 12:46:24.649974   47422 util.go:821] Cached response used.
[odo] I1108 12:46:25.319749   47422 kclient.go:231] Checking if "projects" resource is supported
[odo] I1108 12:46:25.634760   47422 kclient.go:231] Checking if "projects" resource is supported
[odo]  ✓  Deleted project : cmd-devfile-status-test53kfe
[odo]  ⚠  Warning! Projects are asynchronously deleted from the cluster. odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I1108 12:46:25.801875   47422 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
Setting current dir to: /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile
Deleting dir: /var/folders/h0/fmlrbvjd7dg9157p0mpnv0zw0000gn/T/158216461

• Failure [36.629 seconds]
odo devfile status command tests
/Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/cmd_devfile_status_test.go:19
  Verify URL status is correctly reported
  /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/cmd_devfile_status_test.go:338
    when Creating a nodejs component using devfile
    /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/cmd_devfile_status_test.go:48
      Verify that odo component status detects the URL status: Ingress Secure [It]
      /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/cmd_devfile_status_test.go:53

      Expected
          <bool>: false
      to equal
          <bool>: true

      /Users/rnapoles/go/src/github.com/rnapole-rh/odo/tests/integration/devfile/cmd_devfile_status_test.go:91

no odo url create command in v3
/close


patron at $2 but not working

sorry don't know how else to contact u. i've been patron for a couple of months at first i was able to see the Fitness Tracking and Peak Performances but now it just kicks me to a screen that says I need to be a patron to access. When i click on that it shows that i'm a patron and i'm being billed at $2 but i can't access all those features. what do i do?

Hi @1cavr sounds like it just got unlinked.  Click on the "Link with patreon" link in the options panel or just click here from the browser you use sauce on, https://saucellc.io/patreon-oauth

did that... now it's showing me nothing when i click on Fitness Tracking and Peak Perf ...  BTW, this problem is when i'm using my firefox browser...
this morn i started enabling sauce on Chrome and it looks like its connected and loading in my history for the analytics pages. i sure would like to get firefox solved tho as its my preferred browser... thx for any guidance.

@1cavr Let's pick this up via email.  Can you send me message with a screencap of what you're seeing in FF to<EMAIL_ADDRESS>


Switch to uwsgi instead of gunicorn

Hi @murilobr,
This PR switch from gunicorn to uwsgi
The performance are slightly the same, but uwsgi is referenced in cherrypy doc :stuck_out_tongue:
@webknjaz Do you approve this change ?
Regards,
PS : Do not merge until approval

I think it's ok

It's ok for me :heart:


Issue #3  Fix to add content-type as well

For POST requests the content-type is in the RequestBody and will not be set in the retro headers.

thanks, I'll bump the vertx version and do a release


verilog: fix dynamic dynamic range asgn elab

Fixes #3085 @ZachGu
Fixes #3051 @tcal-x

The recent force-push simply rebased and resolved a merge conflict within the changelog.


spring-cloud-config bootstrap.properties need to change to application.properties/yml

spring-cloud-config bootstrap.properties need to change to application.properties/yml in the latest version of spring boot

Hi @m-thirumal ,
We updated the code and the article. Thanks for the feedback.


Tooltip

How can I change a color of full Tootlip ? I got something like this, but it doesn't fill full Tooltip.
.rangeslider__handle-tooltip {
background: #f79651;
}

You need to also style the border-top-color of the  ::after psuedo element:
.rangeslider__handle-tooltip { background: #f79651; }
.rangeslider__handle-tooltip::after{ border-top-color: $acc; }


Fatal runtime error CLI OSX

intstalled cf CLI, when attempt to run the following throws:
fatal error: runtime: bsdthread_register error
runtime stack:
runtime.throw(0x9e5a20, 0x21)
/usr/local/go/src/runtime/panic.go:530 +0x90 fp=0x7fff5fbffb10 sp=0x7fff5fbffaf8
runtime.goenvs()
/usr/local/go/src/runtime/os1_darwin.go:76 +0x8d fp=0x7fff5fbffb38 sp=0x7fff5fbffb10
runtime.schedinit()
/usr/local/go/src/runtime/proc.go:440 +0xa7 fp=0x7fff5fbffb80 sp=0x7fff5fbffb38
runtime.rt0_go(0x7fff5fbffbb8, 0x1, 0x7fff5fbffbb8, 0x0, 0x0, 0x1, 0x7fff5fbffcb8, 0x0, 0x7fff5fbffcf3, 0x7fff5fbffd0f, ...)
/usr/local/go/src/runtime/asm_amd64.s:138 +0x132 fp=0x7fff5fbffb88 sp=0x7fff5fbffb80
can't seem to get it working. Running Mac with Yosemite 10.10.5

Hi @rpmirish,
"when attempt to run the following"... Can you provide more information, such as the commands you tried, cf CLI release version, etc. (see https://github.com/cloudfoundry/cli#filing-bugs)?
Cheers,
Dies Koper
CF CLI PM

Same issue, just typing "cf" after install gives the above error on yosemite 10.0.5. you should be able to reproduce very easily

@rpmirish @kchawla19 we believe this error is happening due to Anti-Virus/Security software. do you have one of the following, or other Anti-Virus/Security software installed?

McAfee Endpoint Protection for Mac
Trend Micro Data Loss Prevention
Websense Endpoint
Digital Guardian

@rpmirish  @kchawla19 Also, if you temporary disable your antvirus/security software, does cf 6.16.x work?
Knowing that would help us tremendously in pinpointing the cause of the issue.

HI, 6.16.X do not work for me neither on mac 10.10.2 Yosemite
Error performing request: Get https://api.run.pivotal.io/v2/info: dial tcp: i/o timeout
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_proxy environment variable is correctly set. Else, check your network connection.

I have the McAfee Endpoint Protection for Mac  (2.2.0) but difficult to desactivate (Corporate Laptop)
CLI 6.15.x works well

The command: export DYLD_INSERT_LIBRARIES= seems to fix this error for me... See https://github.com/direnv/direnv/issues/194

@benschenker when you get an error, does it say:
runtime: bsdthread_register error
or
runtime: bsdthread_register error (unset DYLD_INSERT_LIBRARIES)

the former
fatal error: runtime: bsdthread_register error

runtime stack:
runtime.throw(0x9e5a20, 0x21)
	/usr/local/go/src/runtime/panic.go:530 +0x90 fp=0x7fff5fbff0e0 sp=0x7fff5fbff0c8
runtime.goenvs()
	/usr/local/go/src/runtime/os1_darwin.go:76 +0x8d fp=0x7fff5fbff108 sp=0x7fff5fbff0e0
runtime.schedinit()
	/usr/local/go/src/runtime/proc.go:440 +0xa7 fp=0x7fff5fbff150 sp=0x7fff5fbff108
runtime.rt0_go(0x7fff5fbff180, 0x1, 0x7fff5fbff180, 0x0, 0x1, 0x7fff5fbff400, 0x0, 0x7fff5fbff43b, 0x7fff5fbff47d, 0x7fff5fbff4c9, ...)
	/usr/local/go/src/runtime/asm_amd64.s:138 +0x132 fp=0x7fff5fbff158 sp=0x7fff5fbff150

@rpmirish @kchawla19 @shinji62 @benschenker
We have built a new binary that we think might fix this issue. Please give it a try and let us know if it fixes the issue you're seeing.
Installer: https://s3.amazonaws.com/go-cli/releases/v6.16.1-2016-03-17/cf-cli-installer_6.16.1_osx.pkg
Binary: https://s3.amazonaws.com/go-cli/releases/v6.16.1-2016-03-17/cf-cli_6.16.1_osx.tgz

Hi @rpmirish, @kchawla19, @shinji62, @benschenker,
We have ported the fix into our edge binaries. Could try out our edge binary and confirm the issue is addressed?
https://cli.run.pivotal.io/edge?arch=macosx64&source=github
Cheers,
Dies Koper
CF CLI PM

Seems ok for me.

Thanks @shinji62!

Had the same issue earlier and the new binary fixed the problem.. Thanks

The fix has been included in cf CLI v6.17.0.
https://github.com/cloudfoundry/cli#downloads
Thanks again!
Dies Koper
CF CLI PM


feat: call xunfei spark with stream, and fix the temperature bug

Description
feat: call xunfei spark with stream, use http not ws;
fix: temperature bug
How Has This Been Tested?
test on my pc
Snapshots:
None
Checklist:

[x] My code follows the style guidelines of this project
[x] I have already rebased the commits and make the commit message conform to the project standard.
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged and published in downstream modules

@hiyizi Hi， please fix the Pylink check errors accoring to CONTRIBUTING

Can any one tell me why ?
ERROR: /home/runner/work/DB-GPT/DB-GPT/dbgpt/agent/core/plan/awel/agent_operator_resource.py Imports are incorrectly sorted and/or formatted.
ERROR: /home/runner/work/DB-GPT/DB-GPT/dbgpt/app/knowledge/api.py Imports are incorrectly sorted and/or formatted.

Can any one tell me why ? ERROR: /home/runner/work/DB-GPT/DB-GPT/dbgpt/agent/core/plan/awel/agent_operator_resource.py Imports are incorrectly sorted and/or formatted. ERROR: /home/runner/work/DB-GPT/DB-GPT/dbgpt/app/knowledge/api.py Imports are incorrectly sorted and/or formatted.

i will fix that.


Fix quotation marks for json example

@bexxx : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@heikora
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Trouble converting Linestring and Polygon example KML files

Hey thanks for the great library. I'm having trouble getting valid GeoJSON back from some of the test files when running toGeoJSON.kml() in the browser.  I think there error is on my side, but having trouble finding it.  Using the example linestring.kml file, notice the funky coordinate output below.  Any idea what would cause this?  My first hunch was some line ending issue in the coordinates tag of the input file.  I'm having the same trouble with the polygon.kml example.  Any advice would be super appreciated.
Result:
"{"type":"FeatureCollection",
"features":
[
    {"type":"Feature","geometry":{
        "type":"LineString",
        "coordinates":   [[-122.364383,37.824664,0,37.824322,0]]},
        "properties":{"name":"unextruded"}},
    {"type":"Feature","geometry":{
        "type":"LineString","coordinates":[[-122.364167,37.824787,50,37.824423,50]]},
        "properties":{"name":"extruded"}}
]
}"

linestring.kml
<?xml version="1.0" encoding="UTF-8"?>
<kml xmlns="http://www.opengis.net/kml/2.2">
<Document>
  <name>LineString.kml</name>
  <open>1</open>
  <LookAt>
    <longitude>-122.36415</longitude>
    <latitude>37.824553</latitude>
    <altitude>0</altitude>
    <range>150</range>
    <tilt>50</tilt>
    <heading>0</heading>
  </LookAt>
  <Placemark>
    <name>unextruded</name>
    <LineString>
      <extrude>1</extrude>
      <tessellate>1</tessellate>
      <coordinates>
        -122.364383,37.824664,0
        -122.364152,37.824322,0
      </coordinates>
    </LineString>
  </Placemark>
  <Placemark>
    <name>extruded</name>
    <LineString>
      <extrude>1</extrude>
      <tessellate>1</tessellate>
      <altitudeMode>relativeToGround</altitudeMode>
      <coordinates>
        -122.364167,37.824787,50
        -122.363917,37.824423,50
      </coordinates>
    </LineString>
  </Placemark>
</Document>
</kml>

I think i have a kml -> xml_dom object issue.  Probably specific to my handling of the kml.  For me, a line change here treated the symptom...not root cause:
var coords = v.trim().replace(trimSpace, '').split('\\n');
https://github.com/mapbox/togeojson/blob/master/togeojson.js#L41


use devicevector

Fixes #795
Instructions to reviewer on how to test:

Do dodal connect i22
Confirm connection happens
Do dodal connect p38
Confirm sim mode connection happens

Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards
[ ] If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
[ ] Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram at the moment I only see the Slits device used at i22 and p38, where I know the scientists and their ways of working and for now they don't write tests themselves. And the device is just in the devices/i22 folder and any beamline can use the single Slits device however they want.

With SixSlits the whole device will fail to connect and throw errors.

that is a valid point, might need a decorator 'allow fail'? I am not sure if the slits are used independently like what you're describing now at i22

If we go this way I don't think it should be called six_slits: we'd still be able to address individual slits with e.g. inject by doing inject = ("slits.1") (NB: Might not work for device vectors? Would this work with inject("slits[1]")?)

at the latest version it's a SlitsCollection. testing out ipython behavior of device factor shortly

@DominicOram what is a plan that you'd like to define in ipython and then run it that the inject behavior would be used?

@DominicOram what is a plan that you'd like to define in ipython and then run it that the inject behaviour would be used?

Something like:
def slit_scan(slit: Slits = inject("slits_1"), i0: TetrammDetector = inject("i0"):
    yield from bps.scan([i0], slit.x, 0, 100)

ok how do I get the beamline module to be referred to with inject?
I don't see this in tutorials
search also does not provide information on the use of dodal in ipython https://diamondlightsource.github.io/dodal/main/search.html?q=ipython

ok how do I get the beamline module to be referred to with inject?

It's a blueapi-ism, assuming that there is a device with that name in the blueapi context that will be able to be fetched when the pydantic model is deserialised: regardless of what beamline module is loaded. It's not particularly well developed or documented, I'm hoping there's something in Pydantic 2 that we'll be able to leverage for the same effect but I will have to look after I get back.

@DominicOram  on re-reading your initial comment I see that the granularity of skip_device decorator is decreased as a result of this PR, closing the PR then


ZTag generic modbus manufacturer

We should create an annotation that pulls out manufacturer and model from any modbus scan and generically assigns it.

I don't think we should do this until we can guarantee that this will be "stomped" by vendor-specific tags.

Yeah. :| I thought about that too. The good news is that we could actually do this in ZTag since it's all in a single protocol.


Stop importing _editor_js.html everywhere

wagtailadmin/pages/_editor_js.html was only ever meant to be used on the page add/edit views, but is currently imported in various templates throughout Wagtail admin because it's a convenient grab-bag of JS functions that saves the effort of actually thinking about what JS you're using. Some of the code there is generally reusable (e.g. page chooser modals) and some of it is relevant to other edit-handler-based interfaces (snippets, settings) but a lot of it is only specific to the page editor (e.g. setting up behaviour for the slug field and preview button). We really ought to refactor these templates so that they only import and run the JS that's actually meaningful to each page.

Have been looking into what it would take to allow AdminPageChooser to be used on pages outside the page editor, without importing all of _editor_js.html, and it seems like it's going to be more involved than just shuffling some import lines around...
AdminPageChooser requires the following JS code to work:

the (dynamic) snippet that sets up window.chooserUrls
modal-workflow.js
page-chooser.js

We could easily split these off into a new _page_chooser_js.html include, included from _editor_js.html and any other templates that require AdminPageChooser. However, this is going to lead us down a path of messy dependency tracking: a page that includes _page_chooser_js.html has to know not to import modal-workflow.js itself. And if we do the same decoupling exercise on another component, such as the image chooser, there's no way to include both of them without importing modal-workflow.js twice.
To make this work, then, we'll need a helper that keeps track of the JS imports that are already present, and de-duplicates them - something like Django's form media, but globally for the template, and able to handle arbitrary snippets such as the one for window.chooserUrls, not just <script> file imports. Perhaps the building block would be a template tag like:
{% includeonce chooser_urls %}
    <script>
        window.chooserUrls = {...};
    </script>
{% endincludeonce %}
{% includeonce modal_workflow %}
    <script src="{% static 'modal-workflow.js' %}"></script>
{% endincludeonce %}

This sounds like the textbook use case for a module system and a bundler like Webpack. I think we should move the dependency graph management there, further away from Django land.
I'm not sure how this fits with dynamic snippets that generate arbitrary JS.

Flagging as potentially in scope of the RFC78 stimulus project - much of the JS in this file will be replaced with Stimulus controller logic most likely.

@Lovelyfin00 please have a read of this issue and also a read of what's in this file. I'm hopeful we can get a solid chunk of this done before the Stimulus Outreachy project finishes.
We have discussed the individual JS items before and they are on the roadmap spreadsheet. However, I think it would be good for you to take a fresh look at the things inside this file and how they could be migrated to Stimulus.

Have created a few issues (Stimulus) that will help us move towards removing page-editor.js and then removing _editor_js.html usage.
One thing to consider is the hooks (editor js/css) and expectations of behaviour for that.

Update

Progress continues for this, however it turns out we will likely need to add editor_js to even more views in the meantime - see https://github.com/wagtail/wagtail/pull/11571
Related PR up https://github.com/wagtail/wagtail/pull/11166 - this will hopefully give us a refined approach to how global configs get added
Next bigger thing to maybe tackle is chooser URLs, this is now the only global config injection left in this file.

With https://github.com/wagtail/wagtail/pull/11620 no Wagtail admin core code will use the hook "insert_editor_js" and we will also clean up even more usage of the _editor_js.html template.
Which is an awesome win, in doing this we get closer to supporting CSP and have provided a better way for RichText to leverage custom URL values and be used in more cases across the admin.

Another PR up to get us closer to this https://github.com/wagtail/wagtail/pull/12496

I am thinking, maybe the comments.js could use the Form media instead of being declared in editor_js.
https://github.com/wagtail/wagtail/blob/246f3c7eb542be2081556bf5334bc22256776bf4/wagtail/admin/templates/wagtailadmin/pages/_editor_js.html#L7

OK, validated with a POC and it's possible that we can finalise the clean up of _editor_js with this.
See https://github.com/lb-/wagtail/commits/poc/2936-remove-final-imports-editor-js-html/

Updating wagtail/admin/forms/pages.py with a media property, but need to ensure this has tests and supports overrides/extending easily.

    @property
    def media(self):
        media = super().media
        if self.show_comments_toggle:
            media += forms.Media(
                js=["wagtailadmin/js/comments.js"],
            )
        return media

Remove the comments.js from wagtail/admin/templates/wagtailadmin/pages/_editor_js.html
Move the privacy switch adding (used in a few templates) to the centralised wagtail/admin/templates/wagtailadmin/admin_base.html, this is where we already import other common items for modal-workflow and avoids issues where the JS is not included when needed.
Remove the privacy-switch from wagtail/admin/templates/wagtailadmin/pages/_editor_js.html

I may not have time to do a PR until the new year but posting here for feedback and seeing if anyone else may be keen to pick this up.
Any thoughts @gasman (what should we consider if using the media property on WagtailAdminPageForm to ensure it gets correctly leveraged when developers extend this class for custom forms.


[shiva_sfml] Portfile needs refactoring

Tries to manually link all dependencies from the portfile (although cmake port):
https://github.com/microsoft/vcpkg/blob/52dfee03b570971599767e10508e54bff95dc4cd/ports/shiva-sfml/portfile.cmake#L69-L141
Better:
Patch find_package und find_libraries call in shiva_sfml to do the right thing. The current way is probably also susceptible to OS changes and static/dynamic name changes in libraries.

@Neumann-A , @FrankXie05
It seems that the port shiva-sfml is kind of a duplicate of shiva. Both ports use the same repo and the same tag.
 The description says that shiva-sfml contains plugins for shiva but I can't see that shiva-sfml adds any functionality.

@Neumann-A What do you think about what Thomas1664 said ？

@FrankXie05 I don't know anything about the details of shiva-sfml/shiva. I just observed the portfile and saw it did questionable stuff. Maybe the port was created when features in vcpkg were not yet available?

cc @BillyONeal Both port shiva and port shiva_sfml seem to be doing the same thing, is it necessary to keep two identical ports?

Both ports are unmaintained... and only ci.baseline.txt ensures that they are not build in the same triplet.
Now I have to add shiva-sfml fails for android.

cc @BillyONeal Both port shiva and port shiva_sfml seem to be doing the same thing, is it necessary to keep two identical ports?

Hi @Milerius, since you are the author of this port, can we merge shiva and port shiva_sfml togather, is it possible to use SHIVA_USE_SFML_AS_RENDERER and SHIVA_INSTALL_PLUGINS as features in shiva instead?

Related to https://github.com/microsoft/vcpkg/issues/9116


Running the brain demo gets warning every iteration

I get a warning every loop when running the brain demo code:
  if(this.regression && y.constructor !== Array)
    console.log("Warning: a regression net requires an array as training output vector.");

This is the basic code from demo/rldemo.html
function start() {
	// var brain = new deepqlearn.Brain(num_inputs, num_actions);
	var brain = new deepqlearn.Brain(3, 2); // 3 inputs, 2 possible outputs (0,1)
	var state = [Math.random(), Math.random(), Math.random()];
	for(var k=0;k<10000;k++) {
		// var action = brain.forward(array_with_num_inputs_numbers);
	    var action = brain.forward(state); // returns index of chosen action
	    var reward = action === 0 ? 1.0 : 0.0;
	    brain.backward(reward); // <-- learning magic happens here
	    state[Math.floor(Math.random()*3)] += Math.random()*2-0.5;
	}
	brain.epsilon_test_time = 0.0; // don't make any more random choices
	brain.learning = false;
	// get an optimal action from the learned policy
	var action = brain.forward([.9, .3, .1]);
	console.log(action);
}

@salamanders – were you able to solve this issue?

I'm also experiencing this. @salamanders, @nemo - did you figure this out?

Gah, sorry about this. Do braina.backward([reward])

Yup ^ that did it for me as well :)

@karpathy - That didn't work for me. This is because the "y" variable in the train function is a structure ({dim: i, val:x}, not an Array, in the case of the deep-q-learning example.

hey @karpathy – that actually doesn't fix the problem.
You can get rid of the warning by changing this line in deepqlearn.js#254:
          var loss = this.tdtrainer.train(x, ystruct);

to
          var loss = this.tdtrainer.train(x, [ystruct]);

Though, I'm not sure if this breaks anything or not.

@nemo - While that removes the logged error (because you're now sending in an Array), I think the logic in the RegressionLayer "backward" function is no longer correct. The this.out_depth variable is 5, but y is a 1-dimensional array - so when you loop i from 0 to 5, the loss function becomes undefined (NAN) for i>0. I didn't see any errors in the output, but (to me at least) I don't think this will actually train correctly.

@DrGlennn – I thought the backward function is the one in the RegressionLayer class (which accounts for an arrayed y value.
        for(var i=0;i<this.out_depth;i++) {
          var dy = x.w[i] - y[i];
          x.dw[i] = dy;
          loss += 0.5*dy*dy;
        }
      }

I am not getting the error from the latest hosted build - but I may not be running it the same way, I had to whip together what I think I did last time.

@nemo - Yes. The backward function is the one in the RegressionLayer and, in general, it will handle an Array (as per the code you included). However, this won't work correctly when the array you are sending in is an array of a single element like:
[{dim: 0, val:2.356]
If you just convert {dim:0, val:2.356} into an array (by putting [] around it) then it will use that code, but will loop from i=0 to i=this.out_depth (here out.depth=5). After the first element, this will produce an overall loss of NAN.
Anyway, that's my understanding but I'm not an expert by any means, so happy to receive clarification if you think I've misunderstood what's going on.
@salamanders - I still get the logging error, when running the rldemo.html example. As I see it, the basic issue is that thedeepqlearn.jscode (line 253) is sending in the following structure to the trainer:
      var ystruct = {dim: e.action0, val: r};
      var loss = this.tdtrainer.train(x, ystruct);

As such the test in the train method:
  if(this.regression && y.constructor !== Array)
   console.log("Warning: a regression net requires an array as training output vector.");

is correctly (at least as written) logging a warning that y is not an Array. However, despite the warning, the Regression method does not seem to require an array as a training output vector. It can also handle this {dim: ?, val: ?} structure.
Happy to hear if I'm misunderstanding what is happening here. I'm still trying to really understand, so happy to be corrected if my understanding is way off base.
That being said, my guess is that the "if statement" just needs to include the condition where y is of the form {dim: e.action0, val: r}
Thoughts?


bug(BlockchainProvider): CanonStateSubscriptions

Describe the bug
On the standalone BlockchainProvider, trait CanonStateSubscriptions does not work as expected. Both, CanonStateNotificationStream and Receiver<CanonStateNotification> futures never return and are just stuck on .await.
I narrowed down the problem to reth::blockchain_tree::BlockchainTree and the method subscribe_canon_state has the same never returning future.
P.S. I tried several versions for both, crate as a lib and the node itself: 1.1.1, 1.1.0, 1.0.8. As well as --engine.legacy for the node flag.
Steps to reproduce
use std::{path::Path, sync::Arc};

use eyre::Result;

use reth_beacon_consensus::EthBeaconConsensus;
use reth_blockchain_tree::{BlockchainTree, BlockchainTreeConfig, TreeExternals};
use reth_chainspec::ChainSpecBuilder;
use reth_db::{open_db_read_only, DatabaseEnv};
use reth_node_ethereum::{EthExecutorProvider, EthereumNode};
use reth_node_types::NodeTypesWithDBAdapter;
use reth_provider::{providers::StaticFileProvider, ProviderFactory};

const NODE_PATH: &str = "/storage/reth/mainnet";

#[tokio::main]
async fn main() -> Result<()> {
    let db_path = NODE_PATH.to_string();
    let db_path = Path::new(&db_path);
    let db = open_db_read_only(&db_path.join("db"), Default::default())?;
    let spec = Arc::new(ChainSpecBuilder::mainnet().build());

    let provider_factory =
        ProviderFactory::<NodeTypesWithDBAdapter<EthereumNode, Arc<DatabaseEnv>>>::new(
            db.into(),
            spec.clone(),
            StaticFileProvider::read_only(db_path.join("static_files"), true)?,
        );

    let tree_externals = TreeExternals::new(
        provider_factory.clone(),
        Arc::new(EthBeaconConsensus::new(spec.clone())),
        EthExecutorProvider::mainnet(),
    );

    let tree_config = BlockchainTreeConfig::default();

    let blockchain_tree = BlockchainTree::new(tree_externals, tree_config)?;

    let mut rx = blockchain_tree.subscribe_canon_state();

    while let Ok(notification) = rx.recv().await {
        match notification {
            reth_provider::CanonStateNotification::Reorg { old, new } => {
                dbg!(old);
                dbg!(new);
            }
            reth_provider::CanonStateNotification::Commit { new } => {
                dbg!(new);
            }
        }
    }

    Ok(())
}

Node logs
No response
Platform(s)
Linux (x86)
What version/commit are you on?
reth Version: 1.1.1
Commit SHA: 15c230bac20e2b1b3532c8b0d470e815fbc0cc22
Build Timestamp: 2024-11-05T19:31:40.894690335Z
Build Features: asm_keccak,jemalloc
Build Profile: maxperf
What database version are you on?
2
Which chain / network are you on?
mainnet ethereum
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

so you're running this without a CL?
then there are no new block events emitted, because there's nothing that handles new FCU in your setup

so you're running this without a CL?
then there are no new block events emitted, because there's nothing that handles new FCU in your setup

Totally makes sense, i thought of it, are there any straight forward ways to add it into BlockchainProvider that is ran externally?


[kv] Support first row merge engine

Purpose

Linked issue: close #133

Introduce first row merge engine for primary key table
Tests
FlussTableITCase#testFirstRowMergeEngine
FlinkTableSinkITCase#testFirstRowMergeEngine
API and Format

N/A
Documentation
I'd like to complete the document in another pr #241  since after introduce merge engine, we may need to refactor the document struture about primary key table.

@wuchong Comments addressed...

@wuchong Comments addressed again...


Documentation review

Fixing typos from 'Overview' to 'Using Datasets --> Configuration'.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Rustlang.Rust.GNU version 1.57.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Changed parent dir name to match version number (Rustlang/Rust/GNU/1.57.0/ -> Rustlang/Rust/GNU/<IP_ADDRESS>/).

Is it possible to rerun the validation process?

Close and reopen the PR (same button)


Consider static types

Most of the changes currently being considered will probably require rewrites on most of the codebase. Might be a good time to try and slip some static analysis in to get around the refactoring pains and lack of test coverage.
I'm strongly inclined towards TypeScript, primarily because large swathes of the industry seem to be moving towards it, whereas Flow seems to be struggling to break out of React's shadow. Also, I have an inherent distrust for daemon processes (Flow).

I would also suggest Typescript. It has a massive collection of library types, first-class editor integrations, and Typescript 2.0 is coming soon which includes features that have previously set flow apart.

Quickly ran into a number of blocks when attempting to wire in immutable. Only solutions seem to involve a ridiculous amount of boilerplate with getters+setters for every property.
Immutable data structures is something that I feel is much more important for a heavily async system than static types. That being said, this is still considering once the story for integrating immutable data and static types has improved.

As a small aside, the editor integration (in webstorm, at least) for TS was pretty fantastic. I'd forgotten how handy static types can be :)


Runtime picture have an error

https://substrate.dev/docs/en/knowledgebase/runtime/

one is elections, other is elections phragmen?

This image also appears here: https://substrate.dev/docs/en/tutorials/build-a-dapp/pallet and possible in other places in the devhub. 😬

We still need a specific request on how to update this @sacha-l , do you have a vision in mind for how this could be improved and "future proofed"? We can pass that to Dan M.

Apologies - this slipped. We just need a clean png of it. The latest version is a hack I did with Inkscape, it looks fine but you can tell it's not transparent if you open the standalone file. I'll ask Dan M to have a look.


Driver/bq35100

Something is messed up with this PR. 111 commits with 260 files changed. I suggest you close this and try again with a clean PR.

Please rebase to the latest main branch and force push, this will reduce your PR to just your own commits. You can find more details here: docs.zephyrproject.org/latest/contribute/index.html#contribution-workflow

Please let us know if you need help with this. You will also need to squash your fixup commits

@Emir-Oguz - there are too many commits in this PR. I think you need to rebase as @MaureenHelm has said.
You may need to check that your remotes and branches are set up properly. Can you check the following?

git remote -vv should look something like this

arithmetics-ITS	git@github.com:arithmetics-ITS/zephyr.git (fetch)
arithmetics-ITS	git@github.com:arithmetics-ITS/zephyr.git (push)
origin	https://github.com/zephyrproject-rtos/zephyr (fetch)
origin	https://github.com/zephyrproject-rtos/zephyr (push)

git branch -vv should look something like this

...
main                                                             c817a09b0a [origin/main] ..
...

At that point you should be able to do this:

git checkout main
git fetch origin && git pull
# below, we assume you have a local branch driver/bq35100 which tracks remote branch arithmetics-ITS/driver/bq35100
git checkout driver/bq35100
git rebase main
git push --force arithmetics-ITS

It looks like this branch is still under development and not ready for code review.


virtualdub2: Add version 20

Closes #10719

[x] I have read the Contributing Guide.

/verify

Do you know can specify which architecture using the -a parameter?
scoop install virtualdub2 -a 32bit

2. Besides associations the settings are stored in HKEY_USERS\*\SOFTWARE\VirtualDub.org,
so after uninstall this registry key can be removed. The extra\auxsetup.exe has option for that, not sure if it accepts command line. Not sure if it should be default behavior of scoop, just letting you know.

auxsetup.exe does not accept any command-line parameters


Conflict Error Among Poetry Package Dependencies: lazytransform, tqdm, featurewiz

Error message:
Because no versions of lazytransform match >1.2,<1.3 || >1.3,<1.4 || >1.4,<1.5 || >1.5
and lazytransform (1.2) depends on tqdm (>=4.61.1,<4.62.0), lazytransform (>=1.2,<1.3 || >1.3,<1.4 || >1.4,<1.5 || >1.5) requires tqdm (>=4.61.1,<4.62.0).
And because lazytransform (1.3) depends on tqdm (>=4.61.1,<4.62.0), lazytransform (>=1.2,<1.4 || >1.4,<1.5 || >1.5) requires tqdm (>=4.61.1,<4.62.0).
And because lazytransform (1.4) depends on tqdm (>=4.61.1,<4.62.0)
and lazytransform (1.5) depends on tqdm (>=4.61.1,<4.62.0), lazytransform (>=1.2) requires tqdm (>=4.61.1,<4.62.0).
Because no versions of featurewiz match >0.4.2,<0.5.0
and featurewiz (0.4.2) depends on lazytransform (>=1.2), featurewiz (>=0.4.2,<0.5.0) requires lazytransform (>=1.2).
Thus, featurewiz (>=0.4.2,<0.5.0) requires tqdm (>=4.61.1,<4.62.0).
Steps to Reproduce:
poetry add featurewiz
python = ">=3.8,<=3.10"

Thank you, your update of the tqdm requirements solved problem.
However, there is similar problem with scikit-learn: featurewiz (>=0.4.4,<0.5.0) requires scikit-learn (>=0.24.2,<0.25.0).
Can  you please remove upper-limit  <0.25.0 ?

Hi @ferrotem :
Sorry I cannot remove the upper limit since scikit-learn 1.0 breaks a lot of things in lazytransform.
Auto Vimal

Hi Auto Vimal,
I am sorry, but I found out that featurewiz works well with scikit-learn 1.2.2 when we install via pip. For example, this is message during the installation: Requirement already satisfied: scikit-learn>=0.22.0 in /usr/local/lib/python3.10/dist-packages (from tsfresh) (1.2.2)
Problem occurs when I install featurewiz via poetry. Could you please explain, why there are different requirements  poetry and pip?

I have no idea about Poetry. For now, let's close this.
Auto Vimal

@AutoViML adding to this I ran into a similar problem
featurewiz (0.4.4) depends on tqdm (>=4.61.1,<=4.62.0), featurewiz (>=0.4.4,<0.5.0) requires tqdm (>=4.61.1,<=4.62.0).
The question is does featurewiz really depend on such a tight range for tqdm? Could you losen this restriction up?
In my opinion I prefer a package being installable without version conflicts over a progressbar

Ok @ferrotem 👍 I agree and have made the changes to featurewiz requirements.txt and setup.py files. Please take a look and close it if this is what you needed.
Thanks for being patient,
Auto Vimal

Thanks very much. Could you make a release (to pypi)? It is prohibited for my environment to install from Githuib.


Fix FORGPREP_* when safeenv is false

Fixes #679

See #679, this is intentional for now, potentially pending bytecode redesign around this area.


CL merging

There are a handful of CLs that are getting merged together. I think that this must be due to some internal CL xrefs?  Not sure....

This is happening for only a single CL pair now (2382/2383) and is apparently driven by an FAO xref.


Fix Workspace - Name RHP stays open while not found view is loading

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40488
PROPOSAL: https://github.com/Expensify/App/issues/40488#issuecomment-2071484249
Tests

Create a workspace
Go to workspace settings > Profile > Name
While the RHP is open click on URL and change the workspace ID to something invalid
Navigate to settings/workspaces/<invalidID>/*
Verify that: The not found view is displayed

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a workspace
Go to workspace settings > Profile > Name
While the RHP is open click on URL and change the workspace ID to something invalid
Navigate to settings/workspaces/<invalidID>/*
Verify that: The not found view is displayed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/3de50c3c-7fbd-474d-ac62-52eb09e73e07

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/4f1796e6-c967-44d8-baa0-7c09f664914c

iOS: Native

https://github.com/Expensify/App/assets/161821005/3de50c3c-7fbd-474d-ac62-52eb09e73e07

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/a8bd27e7-d420-4671-a59b-f2aa7806ef0c

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/8c5108cb-50ee-4d8f-9cf8-d093052bf34a

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/6cb6905c-97d0-4458-b707-0ca6b3bd6ff6

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@Pujan92 i updated, please check again 🙏

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.67-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Merkle proof smoke test failing a lot of time

The header merkle Proof is failing regularly for smoke test in the CI, this should be investigate as it may hint an underlying issue in the feature
orchestrator  | =======================================
orchestrator  | Merkle Proof
orchestrator  | =======================================
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | WARN: block header not found; retrying... error: rpc error: code = NotFound desc = not found
orchestrator  | test finishes in 1m49.061668534s
orchestrator  | Smoke test took 5m40.57848617s
orchestrator  | panic: block header not found

Not having seen this issue for a long time, closing


Upgrade Hadoop to 3.3.4

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

the build will pass, I tried till 3.3.3 when trying to upgrade, hive doesn't pose any issues there, but Tez doesn't work with Hive in actual cluster that is why we settled to 3.3.1. You need to upgrade Tez as well to 3.3.4 and then upgrade Hive to that Tez version. Can check more details on the previous 3.3.1 upgrade PR...

@ayushtkn Thanks for the info. Maybe i should test this PR with actual cluster and i will check this.  I also foud the Tez ticket about upgrading hadoop to 3.3.3 https://github.com/apache/tez/pull/213. If I understand you correctly, we should deal with both tickets at the same time. As hadoop-3.3.4 is a latest stable version, updating hadoop from 3.3.1 to 3.3.4 is a good choice.

Yes. you got me right, we should do both the tickets

Tested this Pr with Hadoop3.3.4 & Tez0.10.2, and HS2 started failed with above WARN. This is because Tez0.10.2 added related hadoop3.3.1 jars(e.g. hadoop-hdfs-client-3.3.1.jar) to binary package and this cause some conflict in hive's classpath.
If i change the hadoop version to 3.3.4 in Tez0.10.2, hs2 will run successfully.  :)


Error:TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined

After deploying and logging in I get the following error on all pages.
TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined

@allenjeter, Did you manage to fix the issue?

Look at issue #386.  This error occurs when a user does not have an email address.


Library Config File

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1084
What are the significant changes in functionality due to this change request?
Removes the "RavenUtils" module, replacing it with two files:

raven/dependencies.ini, a config file with Python dependencies categorized by section, and
raven/scripts/library_handler.py, which compiles the library sets to use and returns completed conda/pip commands.

The old command line arguments to RavenUtils were quite hard to follow, so those have been retooled a bit for maintainable clarity; no functionality has been changed.
That said, we now always report being in python3 since we're not python2 compatible.
The new structure should facilitate a plugin-based library extension much more easily than the old system.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL I think this new structure very much.

All jobs on 507fda4 : canceled by @PaulTalbot-INL
problems ending tests

Tests are passing, could someone review?

Since we are working on this, we should add documentation in the wiki on how to modify/add new libraries in the config file.

Since we are working on this, we should add documentation in the wiki on how to modify/add new libraries in the config file.

Yeah, I can do that once it looks like we're ready to merge, or right after it's merged.

@PaulTalbot-INL  changes are good to me.
@alfoa two questions for you: 1. with this PR, we will pin our libraries versions, and no ranges of libraries can be accepted.
2. snake case is used in some utils scripts that are used by rook to conduct the regression test. Are you ok with it?

FYI, I am changing the pylinting for the testers in RAVEN from the rook linter to RAVEN linter. This requires rewriting of a lot of variables in the testers.
This isn't very consistent, since they are extensions of rook, not RAVEN, and our linter doesn't cover anything else in scripts; however, it will look a little more RAVEN-ish (except the inherited methods from rook).

@PaulTalbot-INL sorry for the late. Checklist is good to me. In addition, you need to modify the wiki for the updated libraries.

Wiki modified: https://github.com/idaholab/raven/wiki/Developer_Information#adding-new-python-dependencies


GROOVY-7105 Add try/catch for NoClassDefFoundError

SAM method resolution can cause loading of classes used in method
arguments (or as a return type).
When such a class is not present on a CLASSPATH, it causes a
NoClassDefFoundError even though the class may actually not be needed
for program execution.
This is the naive sollution, but I think it may work. It suppresses the NoClassDefFoundError when resolving SAM method, but in the case when the class is really needed for execution, it will throw the exception then.

just noticed, that this is for the 2.3.x branch... the fix should of course into master and all maintained versions

Thanks!


Exclude non directories from icon path cache

I had an issue with /usr/share/icons/hicolor/48x48/audacity.png with was included in paths (l. 105).

thanks


[WIP] Support portable.exe apps and better error reporting

I'm going to fix/add more tests.

d:\j\workspace\windows-confi---dfc477d1\src\aspnetcoremodulev2\commonlib\handlewrapper.h(26): error C2131: expression did not evaluate to a constant (compiling source file FileOutputManager.cpp) [D:\j\workspace\windows-Confi---dfc477d1\src\AspNetCoreModuleV2\CommonLib\CommonLib.vcxproj] [C:\Users\runner.dotnet\buildtools\korebuild\2.2.0-preview1-20180816.6\KoreBuild.proj]


Adding Ansible install instructions

This fixes #71.
Also adds cross references to the other GreenPiThumb repos.

Coverage remained the same at 80.066% when pulling 8ed33d6e445542ce8d1cf0b6771485d586e7a003 on mtlynch:ansible-instructions into 981f04875fc2661f65ca1bd41e45c92fb8c09089 on JeetShetty:master.


HAProxy / statistics table style off

The overview tab seems to have a small style issue

@fraenki I will push a fix later, but for reference I'm opening an issue.

@fraenki this https://github.com/opnsense/plugins/commit/e38d58ae88d79ddb80548ebd57fdd5e03409a992 ok ?

@AdSchellevis Much better, thanks!

Will be bundled in 2.7, thanks!


Not able to preview local file selected through input tag.

I am facing problem to show local files which user has selected throgh the input
let file = '';
 <input type="file" accept=".pdf" id="" multiple onChange={(el) => file = el.target.files }/>
 <DocViewer             pluginRenderers={DocViewerRenderers}             config={{               header: {                 retainURLParams: false               }             }}             documents={[{               uri: file ? file[0] : ''             }]}

@shubhambatra Please update your @cyntler/react-doc-viewer to v1.6.2. Then below code should be working:
const DocViewerWithInputApp = () => {
  const [selectedDocs, setSelectedDocs] = useState<File[]>([]);

  return (
    <>
      <input
        type="file"
        accept=".pdf"
        multiple
        onChange={(el) =>
          el.target.files?.length &&
          setSelectedDocs(Array.from(el.target.files))
        }
      />
      <DocViewer
        documents={selectedDocs.map((file) => ({
          uri: window.URL.createObjectURL(file),
          fileName: file.name,
        }))}
        pluginRenderers={DocViewerRenderers}
      />
    </>
  );
};

@cyntler doesnt work :(

@cyntler doesnt work with docx files

@siduck Sure! I am really sorry but at this moment it cannot work. File inputs work at the browser level, we have not a public URL to the uploaded file. The library uses Office Viewer from Microsoft using iframe and this supports public files only, served at the some URL.
All you can is upload files to the backend firstly and generate public URLs to the files. Then render  using generated URLs.

@siduck Sure! I am really sorry but at this moment it cannot work. File inputs work at the browser level, we have not a public URL to the uploaded file. The library uses Office Viewer from Microsoft using iframe and this supports public files only, served at the some URL.
All you can is upload files to the backend firstly and generate public URLs to the files. Then render using generated URLs.

no worries! btw does it work with blob?
for example I have this api at my work
/api/customer/milestonedetailsfileupload?type=getfile&blobNam=abc.docx

would it be possible to make it work with that?


[Persistence] Implement Local context for persistence module

Objective
Implement the Local context of persistence module, introduced by #803.
Origin Document
Introduced by #803, as part of work on  #754.
Local context is required to complete the servicer functionality.
The interface to be implemented:

The usage of Local context of persistence module in servicer:

and

Goals

Implement the Local context to the extent required by the servicer.

Deliverable

[ ] Updated Persistence module
[ ] Updated Documentation
[ ] Updated minimal E2E tests to validate the functionality

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: make ...
[ ] New tests or benchmarks: make ...
[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
[ ] k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @adshmh
Co-Owners: [@Olshansk ]

@adshmh You should mark yourself as the creator at the bottom of the ticket by referencing your github username.
You can add co-owners if someone else has context into the work. @Olshansk for this specific one.
Also, please update the iteration (if you plan on doing this now or in a future iteration) and change to Backlog or up next appropriately.

@adshmh  For tickets like this, to avoid spending too much time on the context in the origin document (which would be nice but I know is overkill), feel free to just insert a screenshot from a different PR or discussion we had.

@adshmh is the local context going to be a postgres instance or a badger db?

@adshmh is the local context going to be a postgres instance or a badger db?

@adshmh Friendly bump on this.

@adshmh is the local context going to be a postgres instance or a badger db?

@adshmh Friendly bump on this.

Thank you for the reminder.
I think it is going to be using SMST backed by the kvstore.


Add heap_free_all.

This API takes a heap capability and frees all memory that can be freed by that capability.
The current implementation holds the heap lock for the entire heap walk. This may not be ideal but it's somewhat complex to avoid.  We would need to ensure that the chunk that we are currently inspecting is not coalesced when we yield.

I want to leave the long-held lock to a future commit.  We should have a baseline 'make it work' before we add a 'make it fast' on top.  I'd also quite like to see some timing results with a realistic heap because I don't think the lock is actually held very long (for things with no claims, we scan them very quickly, the worst case is if we have a lot of objects with multiple claims on them).