Can't play content with 48k rate

Hello,
librespot-java release 1.4 throws following exception when playing certain podcast episodes.
I honestly wasn't even aware, there is some Spotify content served with native 48k rate, but it looks like that can also happen.
2020-07-02 00:15:10,919 FATAL Log4JUncaughtExceptionHandler:15 - [player-queue-7173442]
java.lang.UnsupportedOperationException: From 'PCM_SIGNED 48000.0 Hz, 16 bit, stereo, 4 bytes/frame, little-endian' to 'PCM_SIGNED 44100.0 Hz, 16 bit, stereo, 4 bytes/frame, little-endian'
        at xyz.gianlu.librespot.player.codecs.StreamConverter.converter(StreamConverter.java:40) ~[librespot-core-jar-with-dependencies-jdk8.jar:1.4.1-SNAPHOST]
        at xyz.gianlu.librespot.player.codecs.Codec.setAudioFormat(Codec.java:95) ~[librespot-core-jar-with-dependencies-jdk8.jar:1.4.1-SNAPHOST]
        at xyz.gianlu.librespot.player.codecs.Mp3Codec.<init>(Mp3Codec.java:31) ~[librespot-core-jar-with-dependencies-jdk8.jar:1.4.1-SNAPHOST]
        at xyz.gianlu.librespot.player.playback.PlayerQueueEntry.load(PlayerQueueEntry.java:112) ~[librespot-core-jar-with-dependencies-jdk8.jar:1.4.1-SNAPHOST]
        at xyz.gianlu.librespot.player.playback.PlayerQueueEntry.run(PlayerQueueEntry.java:248) ~[librespot-core-jar-with-dependencies-jdk8.jar:1.4.1-SNAPHOST]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:1.8.0_251]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:1.8.0_251]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_251]

An example of such episode for possible reproduction:
https://open.spotify.com/episode/6dh5gAXM6enMzVbHiPWEBU
The behavior is consistent at Java 8 and Java 11 JREs, at Windows, macOS or Linux. In general audio devices at Windows and MacOS should accept whatever common sample rate and automatically insert system resampler to adjust to actual rate of physical device. I also tried to somehow workaround the issue on Linux with rate conversion plugin in ALSA setup, but it didn't helped.
Thank you!

The problem here is that librespot forces PCM_SIGNED 44100.0 Hz, 16 bit, stereo, 4 bytes/frame, little-endian without trying to open a line for the other format. I'm changing that to hopefully make use of rate conversion plugins.

@msmucr Should be fixed. Let me know.

@devgianlu Great, thanks a lot for the fix. 48k content there was quite surprise for me.
I've just tried the fix and it works.
At Windows it will play at current working rate of audio device, system level resampler is employed.
The same thing happens on macOS with Core Audio, it also automatically resample according to working rate of the device.
At Linux via ALSA it switches hardware sample rate of audio device.. I successfully tested it as desktop with RME card and on Raspberry Pi with own BCM audio interface.
If such switching of rate isn't feasible for any reason, it's possible to insert rate parameter for default ALSA slave device, so everything gets resampled from to 44,1k, when desired. I've also tested that with no issues.
Not sure which implications this change would have for someone, who use librespot-java via FIFO pipe output (guessing he would need to also relaunch some other process reading from the pipe with different raw PCM format parameters after possible rate change to 48k), but I haven't tried it so far and direct output to audio interfaces works well.
Thanks again!


:goal_net: Make Watcher not throw an exception if network idle times out

Fixes AP-3761.
Issue: AP-3761
What Changed
Previous to this, Watcher would throw an exception if the global network idle timer timed out. This changes it to not throw an error, and instead log the error and move on. It also adjusts the default timeout to be configurable, defaulting to 10s.
How to test
Follow the reproduction steps in AP-3761.
Change Type

[ ] maintenance
[ ] documentation
[x] patch
[ ] minor
[ ] major

📦 Published PR as canary version: 0.0.29--canary.25.4e99d70.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.0.29 :rocket:


Safari sound lag

I love this plugin but it has lag issues with Safari. See how this was implemented: http://lowlag.alienbill.com/

Done in 3.0


Make sure all notebooks run

Take a pass at all the notebooks and make sure they all run.
For some notebooks (like risky_domains) it needs third-party data files, so  put in some super helpful messages for those.
Notebooks known to run:

Anomaly_Detection.ipynb
Bro_to_Scikit_Learn.ipynb
Bro_to_Spark_Cheesy.ipynb
Clustering_Picking_K.ipynb

This is pretty much done, I still need to do #90 but since there is a ticket for that I'm closing this one since all the rest of the notebooks have been fixed/updated.


Fixes broken pipe error due to closed client socket

The broken pipe error occurs when master tries to write to a closed client socket. Browsers closes connections automatically when the idle to long or users switch tabs for example. Therefor we need to check if the client is still connected and his socket is writable.

Master can read/write data from/to existed workers (forks). It does not communicate with client-sockets directly. By the way, what's in the $meta['url'] in this case?
I suppose that this fix should be applied in Handler.php?

No it should be in Master.php. When a client (Chrome browser for example) disconnects, $client in the write method of master is invoked to send data. Obviously $client is still a resource because it's not yet removed from memory but its not writable any longer because the disconnection is initiated. Therefor we need to check if the stream is still writable.
the $meta['url'] is a reference to the actual datastream of the socket

Let me focus your attention on scheme of component's connection:

So Master doesn't have direct connections for clients. Moreover when you'll add this check to master, and worker will be unable - that's mean that worker wouldn't send the data to any connected client.
On the other hand we have Workers, that might can check resource connection before writing. Therefore you might want to modify Worker's code.
That's why I mention Handler.php. While this class has a protected method write on line 128 you can override it with code that you need or modify it with pull request cause I think that it is a good idea to check before instead of ignore error.
Thanks!

yeah if you look at it like that then I agree. The checks should be done one step back.


Line ending shenanigans

This one's for you, *nix users

For https://github.com/lonekorean/wordpress-export-to-markdown/issues/74


http live streaming (MPEG-2 transport stream) output

Hi.  I was wondering if any work has been done to create an output module + segmenter that would support HTTP live streaming?

No, but if it's something you're looking at it would be a great contribution.  Basically you would want to create a Transform module similar to the RTMP packetizers likely to do the segmenting/muxing to TS format and then perhaps an appropriate output session for whatever you're going to do with that data (be it save to disk or send over a network or whatever).

Yes, it's something I'm definitely interested in.  I just wanted to ensure that I wasn't duplicating effort before I did too much work on it.  I'm just starting to familiarize myself with the codebase, so thanks for the info about what areas I should be looking at for the structure.

kickflip use hls, but big problem is delay

@bitjeep @tonyisid Is there any process?


Fixes and improvements for some of Qwik examples

I've come across this website (this whole thing is a great idea btw) and while looking at the examples for Qwik I found some of them has issues that either cause errors, or they just overcomplicated. This PR fixes and improves upon these examples. Namely:

Declare state: This fix is rather a simplification to be more comparable with the competitors (compared React, Vue, Svelte 5 and Qwik);
Update state: This example results in error, because the state must be updated within useTask$ callback when updated on initial render. In this example it will behave like an "on mount" lifecycle hook from other frameworks;
Computed state: This example is just misleading, because Qwik also has useComputed$ function for when you need computed state, just like the other frameworks (I compared with Vue, React, Svelte and Qwik on the site);
Event click: This example gives an error, because Qwik components are split into symbols, so they are not closures as in React. To fix this error, you either inline event handlers (as in their official examples https://qwik.dev/docs/components/overview/#counter-example) or use the $ function to mark a function as lazy-loadable chunk referenced by QRL;
Conditional templating: This example should use the useComputed$ function because it's recommended way to derive computed values from application's state. Again, components are not closures, they are lazy-lodable chunks.
Form input text: Qwik supports two-way binding in some cases, like form inputs with reactive state. This example can be simplified using bind:value property;
Checkbox: As in previous example, we can use Qwik's two-way binding via bind:checked property;
Select: Simplified using two-way binding via bind:value property;
I also replaced useStore with useSignal in every example I've changed, since reactive objects are not necessary in any of those, and also examples for other frameworks use appropriate APIs for state, unlike for Qwik examples.

You can also play with these examples here: https://stackblitz.com/edit/qwik-starter-dxeodc

One more thing. When you type event handlers in extracted function in Qwik there's better way to do it. Event handlers in Qwik take two arguments: an event (typically would be Event interface), and target (any Element interface descendant), so if you need a value from underlying element, you can use second argument instead of the first one. Then there's also EventHandler type exposed from @builder.io/qwik package and you can use this type to add types onto your event handlers. It takes 2 type parameters: event type and target element type. Here's how radio button example can be improved:
import { component$, useSignal, $, type EventHandler } from<EMAIL_ADDRESS>
type PickColorHandler = EventHandler<Event, HTMLInputElement>

const PickPill = component$(() => {
  const pickedColor = useSignal("red");

  const handleChange = $<PickColorHandler>((_, {value}) => {
    pickedColor.value = value;
  });

  return (
    <>

Picked: {pickedColor.value}

      <input
        id="blue-pill"
        checked={pickedColor.value === "blue"}
        type="radio"
        value="blue"
        onChange$={handleChange}
      />
      Blue pill

      <input
        id="red-pill"
        checked={pickedColor.value === "red"}
        type="radio"
        value="red"
        onChange$={handleChange}
      />
      Red pill
    </>
  );
});

export default PickPill;

For some reason ESlint was complaining about unused variables in event handler (about the first argument) so I decided not to include this change. But now I don't see any error other than VSCode complaining that I need to enable --jsx in order to use this syntax, so I'm gonna add this example to the PR too.

Actually I found better way to improve radio button example for Qwik, thanks Vue 3 example for inspiration. The trick here is the props order, but it works same way, so no need for manual updates via event handler :)

Qwik snippets are so much better, thanks a lot for your contribution ! You really understand the purpose of Component Party


feat(product): add upsell and related products

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?
Adds related and upsell fields to DaffProduct
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
The reason why the Magento product preview contains so much info is to allow prices to be computed for composites and configurables

I think the transformMagentoProductResponse transformer needs updated too, so the upsell and related products can be added to the DaffProductDriverResponse.products array.

I think the transformMagentoProductResponse transformer needs updated too, so the upsell and related products can be added to the DaffProductDriverResponse.products array.

Yeah it does but I'm working through the infinite recursion that it causes

I think the transformMagentoProductResponse transformer needs updated too, so the upsell and related products can be added to the DaffProductDriverResponse.products array.

Yeah it does but I'm working through the infinite recursion that it causes

I think I'm missing something. Wouldn't it just be:
export function transformMagentoProductResponse(product: MagentoProduct, mediaUrl: string): DaffProductDriverResponse {
  const daffProduct = transformMagentoProduct(product, mediaUrl);
  return {
    id: daffProduct.id,
    products: [daffProduct, ...daffProduct.upsell_products, ...daffProduct.related_products],
  };
}

?

I think the transformMagentoProductResponse transformer needs updated too, so the upsell and related products can be added to the DaffProductDriverResponse.products array.

Yeah it does but I'm working through the infinite recursion that it causes

I think I'm missing something. Wouldn't it just be:
export function transformMagentoProductResponse(product: MagentoProduct, mediaUrl: string): DaffProductDriverResponse {
  const daffProduct = transformMagentoProduct(product, mediaUrl);
  return {
    id: daffProduct.id,
    products: [daffProduct, ...daffProduct.upsell_products, ...daffProduct.related_products],
  };
}

?

Yes it is, good call. However that's not the issue that causes the infinite recursion.
The existing transforms assume that the product is a full product, and not just a preview. Therefore I had to separate out the bundle and configurable transforms that dealt with the extra fields from the full transform that spread in the simple product.
I kind of hate my solution so suggestions about a more elegant solution is appreciated.

@lderrickable oh sorry I misread your initial comment, you were only talking about the response transformer. The changes to the response transformer don't cause the recursion. Hopefully all the issues have been resolved.

The existing transforms assume that the product is a full product, and not just a preview. Therefore I had to separate out the bundle and configurable transforms that dealt with the extra fields from the full transform that spread in the simple product.

I kind of hate my solution so suggestions about a more elegant solution is appreciated.
I think I've got an idea. What do you think of this:
export function transformMagentoProduct(product: MagentoProduct, mediaUrl?: string): DaffProduct {
  switch(product.__typename) {
    case MagentoProductTypeEnum.BundledProduct:
      return transformMagentoBundledProduct(
         transformMagentoSimpleProduct(product, mediaUrl),
         <MagentoBundledProduct>product
      );
    case MagentoProductTypeEnum.ConfigurableProduct:
      return transformMagentoConfigurableProduct(
         transformMagentoSimpleProduct(product, mediaUrl),
         <MagentoConfigurableProduct>product,
      );
    default:
      return transformMagentoSimpleProduct(product, mediaUrl);
  }
}

export function transformMagentoBundledProduct(daffProduct: DaffProduct, product: MagentoBundledProduct, mediaUrl: string): DaffCompositeProduct {
  return {
    ...daffProduct,
    price: 0,
    discount: {
      amount: 0,
      percent: 0,
    },
    type: DaffProductTypeEnum.Composite,
    items: product.items.map(transformMagentoBundledProductItem),
  };
}

export function transformProductPreview(product: MagentoProductPreview, mediaUrl: string): DaffProduct {
  switch(product.__typename) {
    case MagentoProductTypeEnum.BundledProduct:
      return transformMagentoBundledProduct(
         transformMagentoSimpleProductPreview(product, mediaUrl),
         <MagentoBundledProduct>product
      );
    case MagentoProductTypeEnum.ConfigurableProduct:
      return transformMagentoConfigurableProduct(
         transformMagentoSimpleProductPreview(product, mediaUrl),
         <MagentoConfigurableProduct>product
      );
    default:
      return transformMagentoSimpleProductPreview(product, mediaUrl);
  }
}

wouldn't we want these on the preview fragment? That way, the configurable and bundle fields will be on both previews and products. And we'll want those fields for upsell and related products.

It's spread in the parent product fragment so the fields are there. It doesn't matter too much either way; I can change it if you feel strongly.

@lderrickable

I think I've got an idea. What do you think of passing an already transformed DaffProduct into the bundle/configurable transformer functions:

nice one, its certainly better than what I had. I also changed the switch case transform to accept a daff product so we only needed one switch case.

wouldn't we want these on the preview fragment? That way, the configurable and bundle fields will be on both previews and products. And we'll want those fields for upsell and related products.

It's spread in the parent product fragment so the fields are there. It doesn't matter too much either way to me; I can change it if you feel strongly.

Oh, I see. I didn't realize you'd spread those fragments into the upsell and related fields. lgtm

lgtm


Event size limit

As far as I understand the quotas and limits of Event Hubs the maximum size of a single event is 265kb and not 1mb.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b109d8b1-4a76-6c2c-b7a1-f473c3723a68
Version Independent ID: 2ffb9a42-52e2-8aa1-86cc-d1033c42ec49
Content: Programming guide - Azure Event Hubs
Content Source: articles/event-hubs/event-hubs-programming-guide.md
Service: event-hubs
GitHub Login: @ShubhaVijayasarathy
Microsoft Alias: shvija

@adoelger As per the Azure Event Hubs quotas and limits Maximum size of Event Hubs event is 1 MB. Please check the link for more details.
We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Do not use git:// protocol

According to recent GitHub changes, git:// protocol is treated as insecure and must not be used anymore. This PR replaces git:// usages with https:// ones wherever possible.

LGTM

@pablogtzgileta
Seems like you need to click "Approve" button or so somewhere in this PR.


Enable tables which interrupt a paragraph (like GFM does)

Input markdown:
A:
|a|b|
|-|-|
|a|b|

ast_renderer outputs:
    {
      "type": "Paragraph",
      "children": [
        {
          "type": "RawText",
          "content": "A:"
        },
        {
          "type": "LineBreak",
          "soft": true,
          "content": ""
        },
        {
          "type": "RawText",
          "content": "|a|b|"
        },
        {
          "type": "LineBreak",
          "soft": true,
          "content": ""
        },
        {
          "type": "RawText",
          "content": "|-|-|"
        },
        {
          "type": "LineBreak",
          "soft": true,
          "content": ""
        },
        {
          "type": "RawText",
          "content": "|a|b|"
        }
      ]
    },

I believe Table should be output, not RawText.
Actual output in GitHub:
A:

a
b

a
b

@minaminao, thanks for the report. After some analysis, I would consider this as a change request which could be stated like this:
Enable tables to interrupt a paragraph
Let me explain why:

Table like this works fine:

FYI, by mistake, I have submitted the previous comment before finishing it. It is ready now. :)

Thanks for the analysis :)
(I found this in a table with more than 3 consecutive -'s, but simplified the table for reporting, and then have related it to another isssue #131 unexpectedly)

As mistletoe has the ambition to support custom tokens, it would be nice if it also had a mechanism to customize which tokens are allowed to interrupt a paragraph. As you point out @pbodnar , this is currently hard coded in Paragraph.read(). With such a mechanism in place, it should be straightforward to enable the desired behavior for tables.
I have some ideas about how to do this, so I'll try and make a PR out of them.

@anderskaplan, that looks promising - having it implemented in a more generic way, not just for Table, would be great. :)

Created two PR's: one "infrastructure" fix (#186) and a draft PR for the new mechanism + table change (#187).


Get all followers

Hello, I want to get all the followers of an user. I managed to get 5000 followers but, after, the max_time and min_time from the response were -1. From what I understand, tiktok won't let me get more followers, even though they exist.
Does anyone know if there is a way to get all followers of an user?
Thank you!

Hello please does this api works ?

There is no way to get more than 5000 subscribers, this is the tiktok limit

Closing as this project is no longer maintained.


Add average, min, max, std values for each measurement type in query details page

A different solution was implemented for displaying measurement data.


config.mode = ios not working when building for browser

Ionic version:  (check one with "x")
[ ] 1.x
[x ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The config.mode var is not working when I'm compiling the app for platform browser. I'm using the iOS style in my web app but it's using md by default. Setting the variable works when I'm running the app with ionic serve.
Expected behavior:
config.mode = 'ios' should set the default style accordingly
Steps to reproduce:
Set config.mode = 'ios' in your app config and compile for platform browser.

Hello, thanks for using Ionic! Could you please post how you're setting the mode config?

Hello! So if I'm thinking correctly here since your using the Cordova browser platform isCordova is true when you're running your app in the browser. Could you console.log that variable out and see if that's correct?

Hi @jgw96 , that is correct. I also tried setting the config.mode outside the if, so that the mode is always set to ios, but the effect is the same.

Hello @marcelgoya , unfortunately, i cannot reproduce your issue. Can you try just putting mode: ios in your actual config object and see if that works for you?

Hello! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


ci: move envvars to run step in release job

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


WS port (9090) do not repond in one case

When there is Popup Dialog of any kind in Kodi 11ft interface (confirmation, question, etc.) WS port 9090 still opens, but do not respond at all.
But HTTP port is working properly.
I've investigated, that almost all Kodi apps (iOs: Sybu kodi, Android: Yatse) using HTTP wervice, instead of WS.
Did you see such problems?

Yeah I saw that recently actually. Not sure why this is happening. It might be a bug from Kodi, or maybe I handled the websocket connection wrongly... I'll investigate. Thanks for reporting it :)

It seems to be a known issue. see here : http://forum.kodi.tv/showthread.php?tid=240590

I propose to create workaround:

Send all Input commands from remote interface through HTTP
transport
Look at JSON RCP API for Notifications of some kind 'the dialog box was
shown'

чт, 4 авг. 2016 г. в 13:19, Gabriel de Tassigny<EMAIL_ADDRESS>
It seems to be a known issue. see here :
http://forum.kodi.tv/showthread.php?tid=240590
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gabriel-detassigny/kodi-angular/issues/3#issuecomment-237513536,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABl5LOme6jg0-aPklBHyd0BXmUAXMwQoks5qcby5gaJpZM4JYE4m
.

--
[image: BeeToo] http://beetoo.me/
Когда умный дом по-настоящему умный
Александр Боровский, Технический директор
Alexander Borovsky, CTO, Co-Founder
+7-926-0-945-00 <+7926094500>
+7-499-391-33-62
<EMAIL_ADDRESS>http://beetoo.me

I've tested it and wrote forum post: http://forum.kodi.tv/showthread.php?tid=240590&pid=2567940#pid2567940
Please, close this ticket.

Great, thanks!


Request New Feature: allowing the ability to reset password during runtime for Jedis's auth

Expected behavior
When Redis's password changed, without redeploy, the JedisFactory can get the new password during making a new incoming Object.
Actual behavior
JedisFactory is package protected, we couldn't extend from it to make our own customized factory.
Our proposal
1, Inside JedisPool.java, add a new constractor
public JedisPool(final GenericObjectPoolConfig poolConfig, final PooledObjectFactory<Jedis> factory) {
  	  super(poolConfig, factory);
}

2,  Change JedisFactory.java to public if possible
3, Inside JedisFactory.java (Optional)

add  private final AtomicReference<String> password = new AtomicReference<String>();
add setPassword(final String password) method

If above is approved/accepted, our application can use the new constructor to pass in JedisFactory or our own customized factory to allow reset password.
Redis / Jedis Configuration
Jedis version:
3.0.0-SNAPSHOT
Redis version:
2.8/3.0
Java version:
1.8
Thanks,
Yan

The pull request:
https://github.com/yapei123/jedis/commit/c895309a6085c873e0fcf868e93b51dea7f46057


ETIMEDOUT when attempting to login

I'm attempting to publish a new vscode extension I'm following the official guide.
Attempting to login fails with ETIMEDOUT.
vsce --version
2.19.0

vsce login <publisher>
https://marketplace.visualstudio.com/manage/publishers/
Personal Access Token for publisher '<publisher>': ****************************************************

 ERROR  The Personal Access Token verification has failed. Additional information:

Error: connect ETIMEDOUT 2620:1ec:a92::175:443

HI @brumm
Thank you for reaching out to us. This appears to be a support request for which we recommend contacting VS Marketplace support team by visiting https://marketplace.visualstudio.com/manage and accessing ‘Contact Microsoft’ at the top right. We look forward to helping you.
-VS Marketplace Team

@joaomoreno I had intermittent issues, but managed to verify my token and even publish my extension in the meantime. Seems like some service was having temporary issues :)


[Feature Request] HUB for tools

Is your feature request related to a problem? Please describe.
For starting point a little amout of tools provided.
Describe the solution you'd like
It will be very useful if some kind of HUB for tools is launched (if this can be done through the VSCode Extension UI - it will be very good!)

We have some doc site update to add a place to explore some of the tools not owned by prompt flow team. @jiaochenlu  @ChenJieting  please help provide the update of adding the docs of this.

Hi @ArtyomZemlyak , we do have a tool hub page to collect all integrated custom tools. Integration here means that you contribute a one-page document of your built custom tool to our doc site, and then the doc page index will be in Listed here -- https://microsoft.github.io/promptflow/integrations/tools/index.html
For maintenance flexibility, we recommend that custom tool owners host such documentation separately in their own repository. If the doc repo is not ready yet, you can add such a page of doc introducing the tool package under: promptflow/integrations/tools.
In addition, we now have a feature that we are working on, which is to support access to this central page in the vscode extension tool list.


[4.2] Add optional cancel button url

Allow the cancel button url to have a custom
refs: #3247

A new inspection was created.

A new inspection was created.

A new inspection was created.

Ofcourse @tabacitu , totally agree with you.
Just submitted the PR with the changes (they are non breaking)
We can't use closures in config files, routes .. etc. Nothing that can be cached by Laravel.
So my solution is to provide a macro check that would allow the developers to change all they cancel button urls in one go.
This needs to be documented, but should be very trivial.
In any provider:
use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;

...

    public function boot()
    {
        CRUD::macro('cancelButtonUrl', function() {
            //here we don't need to pass $crud as parameter because we have it with `$this`
            return 'https://google.pt';
        });
    }

Of course we will respect if they override some particular crud cancel button url with:
$this->crud->setOperationSetting(
            'cancelButtonUrl',
            function($crud) {
                return 'https://omg.com';
            },
            'create' //this can be ommited if you are adding in a specific operation
        );

Let me know,
Pedro

Excellent! Much better. Looking good! 💪 😄

Nobody has asked for this in 2 years so I recommend we close it and forget about it. If somebody does stumble upon this and wants it, we can create a different PR for it. This one has changes to select2_from_array to it, and has too many conflicts.
Sorry Pedro. If you think I'm wrong, you know what to do. Argue, convince me it's worth doing, then let's do it.
Cheers!


[codelab] @use is coming soon, but it's not supported in this version of Dart Sass.

Followed the instructions exactly as in the lab, noticed the error on the console and as a result the fields are not displayed correctly ..
https://codelabs.developers.google.com/codelabs/mdc-101-web/#2

any step missing in the lab? kindly assist.

Edit the package.json file and change the dart sass version number
"dart-sass": "^1.25.0"
Then run npm install

Thanks @lmbell89 ! That did the trick! :)


Failed to run RenderDoc capture

I want to launch an UE4 Android game from RenderDoc on Windows， but failed

The apk is development build.
When I seleted Executable Path，RenderDoc eject：

Environment

RenderDoc version: 1.5
Operating System: Windows 10
Game Runnning System: Android
Game engine： Unreal 4

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


Make first argument to @nnbench.parametrize a single iterable

The stararg change made the decorator unnecessarily inflexible, as no more plain iterables were allowed.
Adjusts the parametrization example to take a raw tuple instead of unraveled arguments.

Forgot to mention in the commit message, this also removes the leftover return type hints of the parametrize and product decorators that were stale when we removed the func arguments.


Build with enable_webvr=0 by default.

IMPORTANT
We actually intend to fix this properly. We are cherry-picking
this commit from the crosswalk-18 branch first in order to have a stable
baseline with no WebVR support propagating from Crosswalk 21 to 20 to 19.
After that, we can start working on fixing this in 21 and 20 and, if there
is enough time, 19 too.
From the original commit message:
Disable WebVR support on Android by default, since it depends on
third_party/cardboard-java which in turn needs
third_party/android_protobuf.
The dependency on android_protobuf means xwalk_core_library_java.jar
bundle Protobuf and cause build conflicts for users depending on Protobuf
themselves (or using other libraries that pull it).
Related BUG=XWALK-6597

rs=me


Hovers over Iframes are broken

When I hover over Iframe trying to use this plugin there is an error:
Uncaught TypeError: Cannot read property 'x' of undefined
    at HTMLDivElement.getValues (tilt.jquery.js:91)
    at HTMLDivElement.updateTransforms (tilt.jquery.js:106)
getValues @ tilt.jquery.js:91
updateTransforms @ tilt.jquery.js:106

It works perfectly with everything else, but not with one thing I need. I wanted to apply this effect to google maps iframe.
I guess this is kind of issue so here I am :)

Hey, thanks for reporting. Can you provide a codepen example so i can see the issue?

@gijsroge Here is an example: https://jsfiddle.net/orpavLep/
If you hover over iframe it doesn't work, but it works on everything else.

I don't think it's just iframes, I also get it but i'm not sure on what currently
the error appears to be in
https://github.com/gijsroge/tilt.js/blob/a92d1bda917e1ba0d0981a6d5cf539917e3cc13b/src/tilt.jquery.js#L119
const percentageX = (this.mousePositions.x - left) / width;
thanks
J

@gijsroge
I temporarily added this line to the top of  getValues
if(!this.mousePositions) this.mousePositions = getMousePositions.call(this);
that theoretically would get rid of the error cannot read property 'x' of undefined
however it suggests something is getting called in the wrong order or not being instantiated in time
thanks
j

Thank you so much you saved my life!!!


Subnet option for ip_type() function.

Make ip_type function work for both IPs and subnets.

Mostly done.

Fully done.


commands to hserver need a timeout

otherwise they hang indefinitely if it cannot be reached, e.g online freezes GUI

fixed by https://github.com/StuartLittlefair/hcam-drivers/commit/c39dfe711143f9fb0d93554666835e9b9fc962be


2.3

Thank you for submitting a pull request!
Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.

[ ] I have signed the Contributor License Agreement (CLA)

@zjw1176 I'm assuming this PR was filed as a mistake?

Closing this as there has been no feedback and it looks like this was opened as a mistake.


fix(linter): fix crashing with unwrap in import/no-cycle

closes #3034

#3035  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Using sphinx to generate the documentation as an HTML page

Sphinx is a very popular library used to gather all the docstrings of each function and class into a single document/web page.
When this is done, we can also consider uploading the documentation to the internet, probably through "readthedocs".

Done in #15!


Calculating $(TargetPlatformSdkPath) takes up 1.2% of evaluation of a solution-wide design-time build

See: https://github.com/dotnet/sdk/issues/1586
Note: None of the project types that were used in this solution actually even use TargetPlatformSdkPath.

Pass
File
Line #
Expression
Inc (ms)
Inc (%)
Exc (ms)
Exc (%)
#
Bug

Total Evaluation

6159
100%
54
0.9%

Properties (Pass 1)

3312
53.8%
9
0.1%

ItemDefinitionGroup (Pass 2)

14
0.2%
2
0%

Items (Pass 3)

566
9.2%
24
0.4%

Lazy Items (Pass 3.1)

1826
29.6%
158
2.6%

UsingTasks (Pass 4)

59
1%
59
1%

Targets (Pass 5)

327
5.3%
208
3.4%

Properties (Pass 1)
Microsoft.Common.CurrentVersion.targets
92
<TargetPlatformSdkPath Condition="'$(TargetPlatformSdkPath)' == ''" >$([Microsoft.Build.Utilities.To...
54
0.9%
54
0.9%
223

Properties (Pass 1)
Microsoft.Common.CurrentVersion.targets
91
<TargetPlatformSdkPath Condition="'$(TargetPlatformSdkPath)' == '' and '$(TargetPlatformIdentifier)'...
21
0.3%
19
0.3%
223

This is also producing 42 MB of garbage opening a large partner's solution:

When we fix this - please provide opt out for all project types that are not UWP including .NET Framework and .NET Core.


[Bug] added theme must be restricted for selected account and not for all the account

https://www.notion.so/added-theme-must-be-restricted-for-selected-account-and-not-for-all-the-account-9660829216474d649134ce935694cb38

The theme does not get saved into the profile ie: once the user logout and re login  it is observed that the profile navigates back to default mode.Hence reopening the issue
Please find the attached video below:
https://www.loom.com/share/f7b14abdef9f47edb23d4a8bff9de423

@mohanarpit Do we want to save the theme for each user? Will this be a client side save only?

Themes are only to be saved locally for now. We're tracking saving this server side here #2702


[UX/UI] Fullscreen image(list) viewer not taking full screen depending on device/orientation

Describe the bug
It appears the nav isn't positioned consistently at the bottom of the viewport on android phones/tablets, at least in chrome. Sometimes the collapse/exit button is not clickable.

This appears to already have been fixed, perhaps with the viewport changes we've been making.


Makefile: Restrict make verify diff to specific files/directories

In openshift CI our Dockerfile gets rewritten, and the .dockerfileignore isn't copied either. So restrict the make verify diff to files we expect to change after re-generating manifests and running go fmt.

/lgtm


SAK-29105 - Relocate methods related to course grade calculations out of

the app

This is pretty great IMO.  Maybe @steveswinsburg wants a quick look because of the GB-NG project.

This didn't actually end up "relocating" anything since the code was already there. I just change the class this extends to GradebookServiceHibernateImpl (which also extends BaseHibernateManager and deleted all of the methods related to grading that were duplicated. The methods in the service were actually more complete than the methods in the tool and appeared to have consideration for some things like drop highest/lowest and some other edge cases that weren't synced up with the tool.

Ship it!


Update languages.json with missing languages

Let's use this issue to keep track of languages that need to be added to languages.json and bulk-process them once we have a longer list:
ISO 639-3 code | ISO Language name
bre | Breton
san | Sanskrit
gle | Irish
gla | Scottish Gaelic
glv | Manx
cor | Cornish
tet | Tetum
tok | Toki Pona

Was this done @jesseallhands ?

I can confirm this has not been taken care of. Should be a quick fix so I updated as such.


typo present, <double "it" was present>

Line 9 had two "it", changed it to single "it"

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


SS2.0 method parameters should follow API definition

Hi,
I started writing SuiteScript a few days ago and this Atom extension is a big help.
I noticed though that the autocomplete feature for 2.0 method parameters do not follow the API definition downloadable from Netsuite.
For example, given the API definition:
/**

Load an existing nlobjRecord from the database based on provided type, id

@governance 10 units for transactions, 2 for custom records, 5 for all other records

@param {Object} options
@param {string} options.type record type
@param {number|string} options.id record id
@param {boolean} [options.isDynamic=false] record is dynamic
@param {Object} [options.defaultValues={}] record default values
@return {Record}

@throws {SuiteScriptError} SSS_MISSING_REQD_ARGUMENT if options.type or options.id is missing

@since 2015.2
*/
function loadRecord() {}

When using autocomplete for record.load, I get this

Shouldn't it be like this one?

I'd be happy to work and submit a PR for this. Right now, I could not find a way to export the API definitions from JSDOC to JSON similar to what's used in netsuite-api2.json. Can anyone share how they did it? Thanks!

Hi @owieboy,
Yes I think some of the SS2.0 method definitions are incorrect. I'm not sure how the netsuite-api2.json was generated, I've a feeling it was done manually. (They were added as part of another PR https://github.com/3EN-Cloud/autocomplete-netsuite/pull/2)
Any help you can offer for this would be appreciated. This plugin is used heavily in our organisation but we are all a bit busy on other projects ATM. We will be focusing on this in the future though.
Thanks
Matthew

Noted on that @matthewcodes. Hope I can find a way to convert the JSDOC to the same JSON format used here.

@owieboy If it's not possible, we could move the SS2.0 code to use a different format.

@owieboy a script was used to parse the JSDOC into JSON it missed some cases.

Hi guys, I was able to write a script to parse JSDOC of SS2.0 and to export a newer version of netsuite-api2.json. I will be submitting a pull request containing the updated netsuite-api2.json file.

thanks @owieboy, I have merged your PR and deployed, its available in version 1.5.0


Make TMX level parser more robust by removing whitespace.

I propose to make the TMX level parser more robust by trimming strings before converting them to integers in parseData. Someone might do what I did, edit the TMX file by hand and let IntelliJ format it...

Codecov Report

Merging #834 into dev will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev     #834   +/-   ##
=========================================
  Coverage     59.23%   59.23%
  Complexity     2204     2204
=========================================
  Files           237      237
  Lines         10731    10731
  Branches        994      994
=========================================
  Hits           6356     6356
  Misses         4086     4086
  Partials        289      289

Impacted Files
Coverage Δ
Complexity Δ

...m/almasb/fxgl/entity/level/tiled/TMXLevelLoader.kt
80.80% <100.00%> (ø)
41.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 796f3bc...01bf9fc. Read the comment docs.

Great patch! Many thanks


Only show recipes where you have the required resources.

Very simple implementation, totally not stolen from https://github.com/NotNite/ReSanctuary.
I don't have everything unlocked yet and am missing a lot of materials. So I can't properly test it, but at least it shows me more reasonable combinations.
Fixes: #13

The main problem with being low level is that you can't just go out and gather more, because some gatherables may still be locked. But I understand that when you have maxed out everything you just want to gather what you actually need.
For me the whole thing takes 2.5 seconds, which is fast enough I would say.

I'm taking a slighly different approach to tackle your problem and another open FR to exlude only rare items.   I'll have an update ~soon.
Thanks!

Just pushed another update which should take almost everything into account. It not only checks the inventory, but also checks if a missing material is gatherable and if it is unlocked (even if the required tool is crafted).
Also added a little check if the Item to be crafted is even available at the current level.

Hey! I just pushed the version I was working on (that also checks for rare vs common materials). I do like the idea of checking for unlocked items.  Things you can merge it?

BTW; thanks for your help!

I rebased my changes on the current main. I'm not 100% sure about this line: https://github.com/belzaru17/WorkshopOptimizerPlugin/pull/14/files#diff-5aa0f579e08557690b322e3fa4f1ff19b93705a84c4b2af118997274eac39b9fR195
As I can't test it right now, because of the maintenance.


page.collection() returns true even if there is no page collection defined in .md

In my .md file page.collection('similarProjects') is not defined, but while using {% if page.collection('similarProjects') %} returns TRUE. This appeared after the (v1.1.14) update.

In 1.1.14 we fixed a bug where an empty collection was returned as an empty array. It will now return an empty collection, so check for page.collection('similarProjects')|length instead

(linked change: https://github.com/getgrav/grav/commit/e2ee02a71d4fb0b0100008a5ff49dbe01ccdbfd5) - cause of the problem: an empty array is evaluated by Twig as false, while an empty Collection object is not.

actually i would use this:
{% if page.collection('similarProjects') is not empty %}
...
{% endif %}


Make the result count toggleable

One note: couldn't figure out how to refactor the result counts into a single method. The prop types were a little too complicated for me to properly unify. Would appreciate help.

Context: https://discord.com/channels/686053708261228577/707816848615407697/1049149578873671792


Ignores the ICC warning on expression constants to asserts

Maybe. We might want to look at replacing that use of TSAssert with something like TSTrembleLikeALeif to be clearer about what's going on.


[query] Add a no-dedup query parameter and UI support for it.

Related to https://github.com/improbable-eng/thanos/issues/107

This https://github.com/improbable-eng/thanos/pull/135 and this https://github.com/improbable-eng/thanos/pull/131 fixes it


More public tests

Adds remaining testing in terms of a public API.
Ooff. I caught some things along the way.

Codecov Report

Merging #388 into public-registration will increase coverage by <.01%.
The diff coverage is 100%.

@@                   Coverage Diff                   @@
##           public-registration     #388      +/-   ##
=======================================================
+ Coverage                99.77%   99.77%   +<.01%
=======================================================
  Files                       25       25
  Lines                      880      881       +1
=======================================================
+ Hits                       878      879       +1
  Misses                       2        2

Impacted Files
Coverage Δ

src/history.js
100% <100%> (ø)
:arrow_up:

src/utils.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc78d7...7a80ae6. Read the comment docs.


Passing merged string arrays into makeExecutableSchema fails unexpectedly

> Error: "users" defined in resolvers, but not in schema
Does not throw error when Schema and Resolvers reside in singular file (example: server/index.js)
Does not throw error if Schema is modularized, but Resolvers passed in directly as one object.
Schema Array  , joined using spread, Passed to makeExecutableSchema
[ '
 type Mutation {
createUser(input: UserInput): User
updateUser(id: ID!, input: UserInput):User
}

input UserInput {
userName : String
friends: String
interests: String
}

schema {
mutation: Mutation
query: Query}
',
'    type User {
id: ID!
userName: String
friends: [String]
interests: [String]
}
type Query {
users: [User]
}
' ]

Resolvers joined with merge( ), passed to Make Executable Schema
 { users: [AsyncFunction: users],
  createUser: [AsyncFunction: createUser] }

Can you show the code where you are actually passing these in to makeExecutableSchema? Better yet, post an example with Launchpad.


Searching empty string

Hi there,
here we are doing a multi filter with aggregations and in some cases the search query string is nothing and what is valuable in those cases is all the logic inside the callback function.
Does anybody know if there is a way to avoid getting 0 results when $string is ''?;
Product::search($stringEmptySometimes, function($client, $body) {
//all the valuable logic ...
});

Regards

Hello.
Try to use an asterisk instead of an empty string.
$stringEmptySometimes = empty($stringEmptySometimes) ? '*' : $stringEmptySometimes;

Thanks!


Block all commands except 'setLeoID' if leoID is 'None' or falsy.

For now, cancelling leo id input sets it to 'None'.
But It should instead be set to empty string, and let the startup finish, but set the leoReadyFlag to false (making all commands unavailable except 'setLeoID') until a valid leo id is entered via the setLeoId command.
(Once a valid leoid is entered the 'setLeoID' command should then be hidden and unavailable.

Comments for commit https://github.com/boltex/leojs/commit/6079c8d35f69037062b05deb71573378a3b4737c references this issue, but that commit does not fix it adequately.


Flask Project : Report On Any topic

Using Gemini Pretrained LLM , Making a very nice generative report On any user entered Topic
Flask Backend And React Frontend.
I hope you will assign this issue to me As I will push my project to this repo and Look for further contribution.

@Ayushparikh-code
I am closing my all issues because I have posted it all 2 weeks ago , And Now it is not time to work upon this issues , even hactoberfest is ending in 2 days  I will not able to complete those all issues  , I would do better if it was assigned earlier to me .
Thanks.


roxctl: 4.4.3 -> 4.4.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/stackrox/stackrox/releases.
meta.description for roxctl is: Command-line client of the StackRox Kubernetes Security Platform
meta.homepage for roxctl is: https://www.stackrox.io
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.4.4 with grep in /nix/store/2py90qdx53s35rmpxbc76yr3bl7g4a9k-roxctl-4.4.4
found 4.4.4 in filename of file in /nix/store/2py90qdx53s35rmpxbc76yr3bl7g4a9k-roxctl-4.4.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

roxctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2py90qdx53s35rmpxbc76yr3bl7g4a9k-roxctl-4.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A roxctl https://github.com/r-ryantm/nixpkgs/archive/0b36b8a5f026f7adc1d7d6f6655f187b20e65e7a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0b36b8a5f026f7adc1d7d6f6655f187b20e65e7a#roxctl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2py90qdx53s35rmpxbc76yr3bl7g4a9k-roxctl-4.4.4
ls -la /nix/store/2py90qdx53s35rmpxbc76yr3bl7g4a9k-roxctl-4.4.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

roxctl

Maintainer pings
cc @stehessel for testing.

Result of nixpkgs-review pr 324237 run on x86_64-linux 1

1 package built:

roxctl


added visual basic language file

Please Star this repo so more people can reach out

Please Star this repo so more people can reach out


[semantic-highlighting] functions that consume  are marked as HlMod::Consuming

Does as the PR title says, functions that consume self, are marked as consuming.

bors r+


Security Vulnerabilities in Multivendor Admin - Username Gap and Negative Values in Restaurant Parameters

Describe the bug
When creating a new restaurant in the multivendor admin system, there are serious security vulnerabilities present. The system allows the acceptance of gaps in usernames and negative values in crucial parameters such as delivery time, minimum order, and sales tax, compromising the system's integrity.
To Reproduce
Steps to reproduce the behavior:

Log in to the multivendor admin system.
Navigate to the "Create New Restaurant" section.
Submit the form with a gap in the username field.
Observe that the system accepts the submission without displaying any error messages.
Submit the form with negative values for delivery time, minimum order, and sales tax.
Note that the system also accepts these negative values without proper validation.

Expected behavior

The system should disallow the submission of the form with gaps in the username field, displaying a clear error message.
The system should validate and reject the submission if negative values are provided for delivery time, minimum order, and sales tax, displaying appropriate error messages.

Screenshots

Desktop:

Browser: chrome

Hi @Inshirah23,
The issue regarding space allowed in the username has been resolved successfully, Thanks for spotting the issue.
@ninjas-code-official/ninjas-code
@beKashif

now negative values are not accepting and in case of blank user name doesn't accept and give error message

Hi @Inshirah23,
The issue regarding space allowed in the username has been resolved successfully, Thanks for spotting the issue.
@ninjas-code-official/ninjas-code @beKashif

waiting for publish


add a filter_empty optional param to Dream.query

My attempt at implementing #204
@aantron on a side note, I'm using vscode together with ocaml-lsp-server and the official OCaml extension. I wanted to format I've edited but it leads to lots of changes 😅 Do you manually format the code?

(But note, if you'd like to format some code you're adding, Dream does have an .ocamlformat in its repo that produces some approximation of a modern, diff-friendly, and Web-oriented style, to the extent that's currently possible with Ocamlformat.)

Nice to see you back working on this project @aantron 🤗😍

Thank you :)

After the huge delay (apologies!) I think this behavior is too niche to support directly in Dream, given a user can easily write their own wrapper to deal with the inconveniences of their client's behavior. I'm going to close this, but we can resurrect it if we have claims otherwise. Sorry and thank you!


Potential login bypass?

If you load the application, and then go to the admin interface in the same application before logging in, then without logging in, hit the back button to go to the application, sometimes the login form disappears and the application shows. I've not yet been able to investigate if it's actually getting a token for the Anonymous user, or getting something else that makes the is_logged_in action trigger, without an actual token (and thus not actually loading the application data in the background either).

I haven't observed anything like this happening after login changes since it was filed

I haven't observed anything like this happening after login changes since it was filed


[Feature] Git repo component

With raw kube approach, we can easily have a built-in ComponentDefinition to reference a Git repo as a component (using Flux Kustomization as example but there're many approaches indeed):
apiVersion: core.oam.dev/v1beta1
kind: ComponentDefinition
metadata:
  name: foo-service
  namespace: default
spec:
  workload:
    definition:
      apiVersion: apps/v1
      kind: Deployment # so the system know this is a deployment type workoad
  schematic:
    kube:
      template:
        apiVersion: kustomize.toolkit.fluxcd.io/v1beta1
        kind: Kustomization
        spec:
          interval: 10m0s
          sourceRef:
            kind: GitRepository
            name: test-repo # ref to a GitRepository resource
          path: test-path
          prune: true
          validation: client
      parameters:
      - name: repo
        required: true
        type: string
        fieldPaths:
        - "spec.sourceRef.name"
      - name: path
        required: true
        type: string
        fieldPaths:
        - "spec.path"

Cool, this is a good practice, hope some one can help write this and add a demo doc.


404 on username change

I changed my username, so for example all my repositories changed from github.com/oldusername/repo to github.com/newusername/repo.
In the github android app, then, in the repositories section, I can view all my old repositories (created before the username changed), and I can click and view into their content, but I can't see any of the repositories created AFTER the username change.
I think the problem is that after a username change,  github maintain a redirection from old urls (with the old username) to new urls. So surely the app is trying to access the old username repositories..
Anyway, when i do "refresh" in any of the sections, a little 404 popup appears.

I tried logging in the first time today and got a 404

Aashrai please see CONTRIBUTING.md. your issue is not related to this one.
On Sun, Jul 26, 2015, 1:36 AM aashrai ravooru<EMAIL_ADDRESS>wrote:

I tried logging in the first time today and got a 404
—
Reply to this email directly or view it on GitHub
https://github.com/forkhubs/android/issues/819#issuecomment-124957772.


Fix wrong references

Description

Fix wrong references
Backporting
This change should be backported to the previous releases, please add the relevant labels.
Refer here to resolve backport conflicts if any.

[x] 2016
[x] 2017
[x] 2018
[x] 2019
[x] 2020
[x] 2021
[x] 2022

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Merged this in #2847.


noir-compiler should have better support for mixed remote and relative dependencies

Prior to #3604 the dependency manager in noir-compiler would selectively unarchive the libraries listed in a Nargo.toml and this worked well as long as the top-level Nargo.toml listed all dependencies to be extracted from a particular archive.
This stopped working once aztec.nr added a 'private' dependency on noir-protocol-circuits. The dependency manager would extract aztec.nr from aztec-packages but when it compiled it, the compiler couldn't find ../../noir-protocol-circuits, so #3604 we've removed the optimisation and now the whole archiver is extracted, which should create the exact tree hierarchy required by libraries.
We should look for a better solution than extracing the whole archive (e.g. depending on aztec.nr inside aztec-packages would extract 80MB of code that's not used in compiling noir contracts).

with the activity around aztec-nargo, it doesn't make sense to pursue this.


{mariadb} HTML tag isn't allowed in example syntax

Describe the bug
The source code for mariadb server is using HTML tags for examples
There are 6 instances

<SingleIP> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L79
<StartIP-DestinationIP> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L79
<SingleIP> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L468
<StartIP-DestinationIP> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L468
<indexToRemove> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L472
<value> in https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml#L479

All six instances render as blank in our autogenerated reference content.  Modify these instances to use some other character like a backtick or escape character.
Example screen print:

Contributor's Guide guideance:
https://review.learn.microsoft.com/en-us/help/platform/validation-ref/disallowed-html-tag?branch=main
This impacts \latest only.

https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/mariadb/server.yml

Related command
az mariadb server create --public --public-network-access
az mariadb server update --public --public-network-access
az mariadb server update --remove
az mariadb server update --set
Errors
MicrosoftDocs/azure-docs-cli build warning:

Issue script & Debug output
See "Describe the bug" section above.
Expected behavior
See "Describe the bug" section above.
Environment Summary
See "Describe the bug" section above.
Additional context
No response

Thank you for opening this issue, we will look into it.

Since this is non-customer reported, Adding Service team to look into this.

@yonzhan, do you know if this issue made it to anyone's backlog to get fixed?

For

az mariadb server update --remove
az mariadb server update --set

This issue is a duplicate of https://github.com/Azure/azure-cli/issues/27054


web portal customization

Customize web portal.
Use Case

Words
ICP# if provided
Hide hardcode mirrors, such as AUR
only keep Mirrors in nav bar
News only for this site
Hide Domains selection
Hide Server status section

This is a :rocket: Feature Request

Hardcode mirror AUR still is showing.

It would be better if we can hide 服务器状态 in related links.

Hardcode mirror AUR still is showing.
It would be better if we can hide 服务器状态 in related links.

These are solved in #46, but CloudFront has cached the old version.

Hardcode mirror AUR still is showing.
It would be better if we can hide 服务器状态 in related links.

These are solved in #46, but CloudFront has cached the old version. The ALB host has the newest one.

After invalidating the js cache, it works.


Remove mod vendor

The -mod=vendor argument in GOFLAGS is causing issues in OSBS.    I'd like to remove it from the defaults in camel-k.
The PNC build does need it, but we can pass it in through the GOFLAGS environment variable.

Created against wrong branch, trying again.


Fix : protractor 3.x not compatible with node v0.12.x + chromedriver …

Hi,
I am currently using node v0.12.x on which protractor 3 does not work : i have to fallback to version 2.5.1.
As such, I also faced another issue with chromedriver location : so i put some comments in the protractor conf file to guide people.
I suggest this PR as fix for people who are still using this version of node.
There is actually no specific branch where i can PR, so i PR this on master.
Please let me know if you create a specific branch for me to PR.
Best regards,
Michel.

@mcha hi, of course last word is up to @gdi2290
but ng2 community using node 4+ and npm 3+

the Angular Team is advocating node 4+ and npm 3+ I can leave a note for people who are using older versions

I added a comment to faq
https://github.com/AngularClass/angular2-webpack-starter/commit/76d75aef7ee134b35ed0003a026fe2b5043c4713
we should be pushing for latest versions so I can't merge this

Hello,
that's fine.


Better messaging for cases when organization in "admin-only" mode

When organization is in admin-only mode the response we get is a little bit cryptic. I would expect some distinct message
Microsoft.PowerPlatform.Dataverse.Client.Utils.DataverseConnectionException: Failed to connect to Dataverse
System.AggregateException: One or more errors occurred. (The HTTP request was forbidden with client authentication scheme 'Anonymous'.)
System.ServiceModel.Security.MessageSecurityException: The HTTP request was forbidden with client authentication scheme 'Anonymous'.
at Microsoft.PowerPlatform.Dataverse.Client.ConnectionService.InitServiceAsync()

Yes, we have a backlog item with the API team to help provide a bit more context as to what is going on.
I will ask the team to check into where that is in the queue.
Once the API team adds in server side support for it, it should just appear as the exception explanation

Folks, we have a partial solution to this problem delivered onto our servers now and are bringing those updates into the Dataverse ServiceClient in the next update (post 1.0.26)
In the next Client release, I will show up as either a Dataverse connection exception or an Operation Exception with a message indicating admin mode,
This is a partial fix right now, does not show correctly during operation, IE after a connection the server is placed into admin mode.  The full fix has been identified and is being worked.
We will keep this open until we have the full fix delivered

This should now be fixed correctly in the platform all up.


Grocery Augmented app with Handwriting OCR

I finally got around to adding a text field to my app to be able to enter the API key on mobile
Already introduced the app on the forums: https://forum.espruino.com/conversations/373509/

Nice! The gif is very cool too - although I think maybe the URL could be relative (not https://fapeg.github.io/BangleApps/apps/groceryaug/groceryaug_preview.gif - but I'll fix that after merging).
Would it have made sense to add this to the original Grocery app rather than having a whole new app, or were there big differences in the Bangle.js app itself as well?

Thanks! I wanted to keep it simple and I don't have quantities so I created a separate app. But for the future I'd like to have one "ultimate" app as well haha

@gfwilliams just curious, when will the app appear on the official Apploader?

I kick the update off manually so it depends if there's other stuff in there I think could be problematic and it pays to wait on. I might do it this afternoon, but then if something breaks it'll be all weekend before I fix it
Changes will still be in the development app loader now


feat: adding pipeline-level parameters that can be referenced from tasks

Fixes #42 and fixes #43

Accidentally made PR to main!


⚠ ClamAV has degraded performance

In fcb9276, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 216 ms

Resolved: ClamAV performance has improved in 714a8f2.


is it possible to use slackin now ? (legacy tokens are not supported by Slack anymore)

Slack no longer support the use of legacy tokens and replaces them with Slack apps.
This was already mentioned in issue #412 :

It looks like you can still create legacy tokens until May 5th here: https://api.slack.com/legacy/custom-integrations/legacy-tokens

After legacy tokens are deprecated, it seems only Enterprise Slack teams will be able to use auto-invite flows/apps, because the admin.users.invite api method is restricted: https://api.slack.com/methods/admin.users.invite

is there a way to use slackin now ?

Invite links will expire due to security reasons. So you have I think 30 days and you need to recreate the invite link again.

where are you seeing that? Just wondering how you know that since the above does not mention that.

where are you seeing that? Just wondering how you know that since the above does not mention that.

where is this even from?

where is this even from? This tells me nothing. What I showed you was the actual slack workspace that said it's not going to expire!

This has changed:

And when you click share invite link:

So share invite links expire < 30 days.

Yea something's odd.  One of my workspaces shows it's not going to expire but a new workspace I just created, the shared link in that one does say it expires.  Now I'm really confused.

I'm attending the Slack call tomorrow where they talk about the roadmap.  If I can I'll ask about it.

I'm attending the Slack call tomorrow where they talk about the roadmap. If I can I'll ask about it.

It's possible ! I needed to deactive the link. Create a new one with a CUSTOM expire date and you can select never expire. So it's working with never expire.

ah ok that must be what I did different.  Interesting.

They should still provision for this to work via oauth bot scopes

They should still provision for this to work via oauth bot scopes

You say should. We can't make a legacy token any longer. So if someone knows how to setup a connection to the api that would be nice. Until then only not expiring invite links from within Slack itself are possilbe.

Yes that is the option I've gone for, archiving the fork of this repo

Long term will probably look for a chat software a bit more suited to needs

TBH, this is much easier (no offense to the creators) just using slack.  Slackin required a server for what I can just now do via native slack.

I don't know what Slack is doing.  Now it expires again in their latest build:

I was able to create a link that never expires today, not sure why the option exists for some and not others...

did you upgrade to the latest version of Slack? 4.8.0 took the option away

I opened basically a complaint on it here https://github.com/integrations/slack/issues/1063

did you upgrade to the latest version of Slack? 4.8.0 took the option away

I used the webapp and not the desktop app, maybe that's the difference. I'm guessing I'm using the latest version.

Most people use the desktop client...

It appears that paid organizations can create invitations that never expire; free orgs have a 30 day expiration.

Is invitation link generation as api not requires enterprise version?, if so we can alt this project to generate it with cron job, redirect them on the existing ui.


Support for nested Collections / SubCollections?

Are Subcollections supported with mock_cloud_firestore?
As an example, in Firestore, I have the following collection:
/maincollection/123/subcollection/456
Does mock_cloud_firestore work with such subcollections?
I tried to nest these in the source the following way but it does not work:
{
  "maincollection": {
      "1": {
         "abc": "xyz,
         "subcollection": {
            "999": {
               "example": "ex"
            }
         }
      }
   }
}

Also, how does mock_cloud_firestore support map fields of a document compared to subcollections?
How would they be represented in the JSON?

I will look into this in next week, in the meantime if you can write a
failing test, that will be helpful
Thanks.
On Wed, Jul 3, 2019, 9:51 AM sceee<EMAIL_ADDRESS>wrote:

Are Subcollections supported with mock_cloud_firestore?
As an example, in Firestore, I have the following collection:
/maincollection/123/subcollection/456
Does mock_cloud_firestore work with such subcollections?
I tried to nest these in the source the following way but it does not work:
{
"maincollection": {
"abc": "xyz,
"subcollection": {
"999": {
"example": "ex"
}
}
}
}
Also, how does mock_cloud_firestore support map fields of a document compared to subcollections?
How would they be represented in the JSON?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ozanturksever/mock_cloud_firestore/issues/10?email_source=notifications&email_token=AADK7T5HRJAWQNFLZFRENK3P5TKIXA5CNFSM4H5HYIS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5F4HLQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADK7T56TVWRINP74NGDGMTP5TKIXANCNFSM4H5HYISQ
.

@ozanturksever sorry, I did not find the time until now.
I could write a test - the question is how the data structure should look like.
Is the above data structure fine?
I don't think it can be used exactly like this because this would mean there is no way to differentiate between subcollections and map fields.
Do you have an idea how to solve this differentiation? We could just introduce a kind of annotation "type" field or something like this that describes the type of the field (=subcollection or map).

I was working on this very problem but don't have a pull request yet. Hope to be back on it this week.
Also, open to any discussion before I try to finalize it. In my version, if it reads it as a map, it'll try to pull it in both as a map field and a collection, per your point @sceee about not being able to tell the difference. This approach doesn't fail any existing tests and allows the new tests to pass but it does feel a little clumsy. For mocking purposes, I think it works because you will be testing for a collection processing correctly or a map field processing correctly, and the other will be ignored.
  test('get sub-collection from document', () {
    MockCollectionReference col = mcf.collection("projects");
    expect(col, isNotNull);
    MockDocumentReference doc = col.document("1");
    expect(doc, isNotNull);

    CollectionReference cr = doc.collection("tasks");
    expect(cr, isNotNull);
    Stream<QuerySnapshot> qs = cr.snapshots();
    expect(qs, isNotNull);
  });

for this data sample:
"projects": {
    "1": {
      "id": "1",
      "title": "test project 1",
      "tasks": {
        "101": {
          "id": "101",
          "taskId": "1",
          "projectPriority": true
        },
        "102": {
          "id": "102",
          "taskId": "2",
          "projectPriority": false
        }
      }
    },

sorry can't look into this quickly, i am on the road for a few days. will look as soon as got the time.

any update about this ?

merged https://github.com/ozanturksever/mock_cloud_firestore/pull/13
so the issue is, how to distinguish sub-collection from map.
do you guys prefer a prefix like ">tasks" or not?


ui: show 'owner' tag for real owner

As title
fix #13460

Codecov Report

Merging #13689 (2d43ef2) into master (24330f7) will decrease coverage by 0.11%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master   #13689      +/-   ##
==========================================
- Coverage   42.27%   42.16%   -0.12%
==========================================
  Files         697      697
  Lines       76616    76635      +19
==========================================
- Hits        32389    32312      -77
- Misses      38908    39020     +112
+ Partials     5319     5303      -16

Impacted Files
Coverage Δ

models/issue_comment.go
45.46% <ø> (-7.26%)
:arrow_down:

routers/repo/issue.go
38.01% <44.44%> (+0.02%)
:arrow_up:

models/repo_permission.go
77.06% <63.63%> (-0.72%)
:arrow_down:

modules/setting/setting.go
46.23% <100.00%> (+0.11%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/indexer/stats/queue.go
64.70% <0.00%> (-11.77%)
:arrow_down:

modules/indexer/stats/db.go
43.47% <0.00%> (-8.70%)
:arrow_down:

modules/notification/ui/ui.go
84.72% <0.00%> (-8.34%)
:arrow_down:

modules/notification/mail/mail.go
33.33% <0.00%> (-5.75%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24330f7...9b145dc. Read the comment docs.

Would suggest shortening it just to Administrator.

Would suggest shortening it just to Administrator.

It's not accurate enough,  the repo administrator is also  administrator :)

🚀

Please send backports


Update stdlib.zip URL to GitHub repo build

It's also an update... that I keep forgetting to test. It seems to work, at least with the tools I'm using... Should test the toolchain you get on debian/raspbian though (think that's the next most common one after the one in ubuntu)
(Other build there matches the current version)

Might have to dig a Pi out of a box somewhere for the latter.
Works for me on Mint, with presumably the same tools as Ubuntu:
arm-none-eabi-gcc --version
arm-none-eabi-gcc (15:9-2019-q4-0ubuntu1) 9.2.1 20191025 (release) [ARM/arm-9-branch revision 277599]

Yeah, that's the same one. Just did a build on my Pi 400 and it seems fine. (version is 7.3.1 20180622)
Did find a CMake issue though...


ensure save_state->opline is initialized

This resolves a warning against gcc10 which was stopping compilation with that compiler. Thanks to @mlocati for identifying the issue and proposing a fix, but this fix proposed by @agoallikmaa seems more portable.
Fixes: https://github.com/open-telemetry/opentelemetry-php/issues/1260
Replaces: https://github.com/open-telemetry/opentelemetry-php-instrumentation/pull/138

Any eta for a tagged release with this patch?


Lavalink

PR note: this is unfinished and is a draft. I still need to do more testing, but all of the functionality and documentation is there.
twilight-lavalink is a client for Lavalink as part of the twilight
ecosystem.
It includes support for managing multiple nodes, a player manager for
conveniently using players to send events and retrieve information for each
guild, and an HTTP module for creating requests using the http crate and
providing models to deserialize their responses.
Example
Create a client, add a node, and give events to the client to process
events:
use futures_util::stream::StreamExt;
use std::{
    convert::TryInto,
    env,
    error::Error,
    future::Future,
    net::SocketAddr,
    str::FromStr,
};
use twilight_gateway::{Event, Shard};
use twilight_http::Client as HttpClient;
use twilight_lavalink::{http::LoadedTracks, model::Play, Lavalink};
use twilight_model::{
    channel::Message,
    gateway::payload::MessageCreate,
};

async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
    let token = env::var("DISCORD_TOKEN")?;
    let lavalink_host = SocketAddr::from_str(&env::var("LAVALINK_HOST")?)?;
    let lavalink_auth = env::var("LAVALINK_AUTHORIZATION")?;
    let shard_count = 1u64;

    let http = HttpClient::new(&token);
    let user_id = http.current_user().await?.id;

    let lavalink = Lavalink::new(user_id, shard_count);
    lavalink.add(lavalink_host, lavalink_auth).await?;

    let shard = Shard::new(token).await?;

    let mut events = shard.events().await;

    while let Some(event) = events.next().await {
        lavalink.process(&event).await?;
    }

    Ok(())
}

Hey, this works now! It plays music, yay! Just gotta do more testing and documenting
Long story short, I ran into the same bug that a friend and I ran into 2 years ago that took us a couple months to fix, the inner event of VoiceUpdate events needs to have snake_case fields and not have the null channel_id.

This PR is ready


Can't subscribe to CompressedImage topic

Using Melodic on Linux
go version go1.14.2 linux/arm64
        imgStream := make(chan *sensor_msgs.CompressedImage, 100)
	subTopic, err = goroslib.NewSubscriber(goroslib.SubscriberConf{
		Node:  n,
		Topic: "/output/image_raw/CompressedImage",
		Callback: func(msg *sensor_msgs.CompressedImage) {
			imgStream <- msg
		},
	})
	if err != nil {
		panic(err)
	}
	fmt.Println("Connected to Subscriber Topic")
	defer subTopic.Close()

Connected to Subscriber Topic
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x6c52d4]

goroutine 30 [running]:
github.com/aler9/goroslib.(*subscriberPublisher).run.func4(0x400028e960, 0x400028a0d8, 0x4000210080, 0x400028c480)
	/home/jkim/go/src/github.com/aler9/goroslib/subscriber-pub.go:105 +0x4c
created by github.com/aler9/goroslib.(*subscriberPublisher).run
	/home/jkim/go/src/github.com/aler9/goroslib/subscriber-pub.go:103 +0x2a0
exit status 2

rqt_images shows the video frames rendering on that topic just fine.
Subscribing just to /output/image_raw does not panic, but nothing comes through on the topic

Hi, thanks for the report, to fix this i need two things:

can you try again with the latest version of the library ? the traceback reports an old version of subscriber_pub.go
can you provide a way to reproduce the issue, for instance by writing the commands or the program you used to generate the stream?

thanks

Looks like the update fixed it, I'm receiving events now.
Do you still want the original code that was used to publish? It was nothing special


Events

Does the model automatically convert images to events, or should we follow the relevant GitHub repo and turn them into events?

please follow the readme regarding TartanAir and vid2d


Maintenance

Change deprecated dockerStatusBuildItem.isDockerAvailable() to dockerStatusBuildItem.isContainerRuntimeAvailable()
Transform ArtemisHealthSupport to record
Resource Adapter integration tests:

Where possible, use constructor injection
Remove public modifier from all test classes and -method
Reformat code

Fix typos

I am missing this one:

Change DockerStatusBuildItem to ContainerRuntimeStatusBuildItem

Yeah, sorry about that. It was initial part of the commit, but was removed, since ContainerRuntimeStatusBuildItem is abstract and cannot be used on its own. I updated the PR description and the commit message.


When executing an .ipynb file in a subfolder, VS Code cannot recognize .py files in another subfolder

mydir1
--> myclass.py
mydir2
--> test.ipynb
import os
wd = os.path.normpath(os.getcwd() + '/..')
os.chdir(wd)
os.getcwd()
from mydir1.myclass import MyClass

When importing mydir1.myclass in test.ipynb with the following code, VS Code cannot recognize mydir1, even after changing the working directory to the current project folder (i.e., one step outside from mydir2). It also shows the warning message
Import "mydir1.myclass" could not be resolvedPylance(reportMissingImports)

and I cannot make use of autocomplete, even though the code is executed without an error.
I tested the above code using VS Code in another PC, and found that the VS Code catches mydir1 directory and myclass file (+ autocomplete) well.

/extPython


errors in html files

Review thoroughly the folder of Html_css and javascript and check all the tasks have been completed. And the tasks are done as defined, if you find any errors or bugs, resolve it.

I can do it sir, please assign me this with hactoberfest tag.

I have assigned this task to you.

Hi sir, I have already contributed to some extent and I intend to do the full project , so I request you to please assign this PR to me under the label of " HACKTOBERFEST-ACCEPTED " or "HACTOBERFEST" , You may review my work done as I have already commited some changes
Thank you!

I have assigned you a pull request and merged it.


community: Add tools calls to ChatEdenAI

Description
Add tools implementation to ChatEdenAI:

bind_tools()
with_structured_output()

Documentation
Updated docs/docs/integrations/chat/edenai.ipynb
Notes
We don´t support stream with tools as of yet. If stream is called with tools we directly yield the whole message from generate (implemented the same way as Anthropic did).

Preparing review...

Preparing review...

nice! if you add ChatEdenAI to the CHAT_MODEL_TABLE here https://github.com/langchain-ai/langchain/blob/master/docs/scripts/model_feat_table.py it'll get noted in this page https://python.langchain.com/v0.2/docs/integrations/chat/

nice! if you add ChatEdenAI to the CHAT_MODEL_TABLE here https://github.com/langchain-ai/langchain/blob/master/docs/scripts/model_feat_table.py it'll get noted in this page https://python.langchain.com/v0.2/docs/integrations/chat/

done!


Ignore the pip self check marker file in a Virtualenv.

The python package manager pip has started writing a state file, and in a virtualenv it gets put just inside the top level of the virtualenv folder (http://pydoc.net/Python/pip/6.0.6/pip.utils.outdated/) (look for pip-selfcheck.json). Here is a very short discussion of that feature. (https://github.com/pypa/virtualenv)

Thanks for the links!

@mbaltaks thanks for this!


Storybook issue "invariant expected app router to be mounted"

Context
What's your version of nuqs?
"next-usequerystate": "1.15.2"
Next.js information (obtained by running next info):
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020
Binaries:
  Node: 20.10.0
  npm: 10.2.3
  Yarn: 3.2.3
  pnpm: 8.6.12
Relevant Packages:
  next: 14.0.4
  eslint-config-next: N/A
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.2.2
Next.js Config:
  output: N/A

Are you using:

❌ The app router
✅ The pages router
❌ The basePath option in your Next.js config
❌ The experimental windowHistorySupport flag in your Next.js config

Description

When running components that uses useQueryState in Storybook this error is shown

Storybook version:
"storybook": "7.6.8"
"@storybook/nextjs": "7.6.8"
Docs: https://github.com/storybookjs/storybook/blob/next/code/frameworks/nextjs/README.md#nextjs-navigation
My project uses just pages folder so I don't have appDirectory set to true.
parameters: {
    nextjs: {
      appDirectory: true, // as we are using pages folder I don't have this flag in the story
    },
  },

If I enable it then I get this error

This is logical because we are using useRouter in our components.
From next issue https://nextjs.org/docs/messages/next-router-not-mounted

This can also happen when you try to use the useRouter hook from next/router inside the app directory, as the App Router's useRouter from next/navigation has different behavior to the useRouter hook in pages.

Reproduction
CodeSandbox Link

Thanks for the report. nuqs uses imports from next/navigation to be compatible with both routers under a unified API, but it seems like Storybook doesn't support importing the pages router from there.
This is a gray area of compatibility with Next.js, as the compat layer for the pages router from next/navigation is not feature-complete and downright buggy in some configuration combinations. We had to go around those issues by tapping into Next.js internals in such cases, see #454.
Unfortunately there's not much advice I can give you here but watch that thread in https://github.com/storybookjs/storybook/issues/24722 for potential solutions.

Thx @franky47 for the quick response.
I figured this would be the answer from the storybook issue. It seems they are working on the solution for v8 release.
As you can see, I opened issues on bot sides so it's more visible, and helpful to others with the same issue :D
Maybe it's safe to close this issue because there's nothing you can do form the lib perspective.

Sounds good. Feel free to ping back here if/when you find a suitable solution.

Here is the workaround until Storybook fix the issue.
import {
	AppRouterContext,
	type AppRouterInstance,
} from 'next/dist/shared/lib/app-router-context.shared-runtime';

const meta = {
	decorators: [
		(Story) => (
			<AppRouterContext.Provider value={{} as AppRouterInstance}>
				<Story />
			</AppRouterContext.Provider>
		),
	],
};

@franky47 do you maybe know the answer to this question?https://github.com/storybookjs/storybook/issues/24722#issuecomment-1923845582

That's not possible, you idiots.

 How on earth do you guys develop something that is worse than what I made with my feet?


dotnet not able to run even after following correct procedures from official MS document

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/run
Operating System: linux
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

How did you install dotnet? Did you use snap or some other method?


DOC: <Issue related to /v0.2/docs/tutorials/qa_chat_history/>

URL
https://python.langchain.com/v0.2/docs/tutorials/qa_chat_history/
Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
How do you limit the number of previous conversations for the checkpoint memory ? As it is shown in the documentation, The checkpoint just grows and grows which eventually exceeds the LLM input token limit.
https://python.langchain.com/v0.2/docs/tutorials/qa_chat_history/
Idea or request for content:
Please add a section on how to limit the the number of previopus conversations that go into a checkpoint.
https://python.langchain.com/v0.2/docs/tutorials/qa_chat_history/

I suspect it's not just an issue with documentation. The react agent is created by using
from langgraph.prebuilt import create_react_agent
and its implementation in langgraph keeps the message in AgentState and currently there is no implementation to provide some kind of buffer window memory to manage these messages like ConversationBufferWindowMemory

The workaround is to use place a create_react_agent with tools. Then place it in a LCEL chain with a prompt and then to wrap all of it with RunnableWithMessageHistory. See:- https://python.langchain.com/v0.2/docs/tutorials/chatbot/
The message list can be limited quite easily.

Thanks @amersheikh it does work as a workaround
`# create agent executor without checkpointer
agent_executor = chat_agent_executor.create_tool_calling_executor(
llm, tools
)
manage message history limit
from langchain_core.runnables import RunnablePassthrough
def filter_messages(messages, k=3):
return messages[-k:]
chain = (
RunnablePassthrough.assign(messages=lambda x: filter_messages(x["messages"]))
| agent_executor
)
manage message history using a store
store = {}
def get_session_history(session_id: str) -> BaseChatMessageHistory:
if session_id not in store:
store[session_id] = ChatMessageHistory()
return store[session_id]
with_message_history = RunnableWithMessageHistory(
chain,
get_session_history,
input_messages_key="messages",
)
config = {"configurable": {"session_id": "abc20"}}
1st run: tell AI my name
response = with_message_history.invoke(
{
"messages": [HumanMessage(content="hi, I'm Bob")],
},
config=config,
)
print(response)
2nd run: give AI some non-sense information
response = with_message_history.invoke(
{
"messages": [HumanMessage(content="what is 1+1?")],
},
config=config,
)
print(response)
3rd run: ask AI what's my name, it should have forgeten
response = with_message_history.invoke(
{
"messages": [HumanMessage(content="what's my name?")],
},
config=config,
)
print(response)`
However I'm not sure if it is a idiomatic way of using the StateGraph. It seems to be a desirable feature for it to provide a way of limiting message history


Consider Sending context to adapter Messages method

Consider sending context to adapter in order to correctly clean resources when the timeout is reached.
//Adapter defines an messages source
type Adapter interface {
	Open() error
	Close() error
	Messages(context.Context) (<-chan Message, error)//Modified method
	ResultHandler(jobResult *JobResult, message Message) error
}

Done


Inquiring about the rec_model for running on other datasets.

Dear Authors,
Thank you for sharing the code, checkpoints and datasets.
Could I inquire about how to generate the rec_model if I would like to run the code on datasets other than MovieLens, Steam, and FastFM?
Thank you and look forward to your reply.
Regards,
Wei-Wei

Thanks for your attention to our work. The code for generating the rec_model is adapted from the repo https://github.com/YangZhengyi98/DROS.


Provisioners race to provision (& delete)

Only one will succeed submitting PV. The rest will have done unnecessary work. Suggested to do some kind of basic sharding to prevent this, but not sure if/where that is possible

Summary so far:
One solution here: #27 . Race to lock the PVC. Then you're given x seconds to succeed/fail. If you succeed/fail/timeout another provisioner takes over. Main downside is, there's still a race...maybe one wins all the time.
Other solution: sharding. StatefulSet is not an option yet so can't use the 'ordinal index'. Instead, could label all provisioner pods and list them to get # of peers with index derived from something. This requires provisioners to be running in kube, the label to be passed in to each, health checks, etc. So this solution requires more to work, but there are no races, it's nicely parallel


Proto.Cluster.SingleRemoteInstance

I did some pretty nasty things on our stack to have some abstraction on Cluster/Remote/Local in order to start developpements in the same way/api in local without Consul, than on the expected target when going in production ... and it's a mess.
As I discussed that with my boss @Johnny-Bee said :

"We should always be in cluster mode !"

And then now bazzinga! Let's create a ClusterProvider that encapsulate Remote calls, then we are good to always code Cluster thing, and decide at runtime to run the single remote or the Consul one.
Anyone interested ? sounds good ? If good I plan to code that quick to have it in vNext.

@rogeralsing @cpx86 how you feel about this ?

I'm not quite sure I understand what is being suggested here.
There are quite different semantics between Local, Remote and Cluster.
Remote is similar to Local, you still control life cycle of actors, but with the potential risk of a node dying.
Cluster, uses the Virtual Actor model and identifies actors by name instead of PID (well that is used under the cover, but the surface API is for names)
Is your suggestion to build a cluster provider that allows you to start a single node, that thinks it is a cluster?
In that case, that should be completely fine. 👍

a cluster provider that allows you to start a single node, that thinks it is a cluster

This sounds interesting for sure. However in this scenario the term cluster is a bit misleading.
There have been ideas before about being able to use virtual actors even in local scenarios. Perhaps it could be possible to factor out the virtual actors into a VirtualActor package that's usable locally, and let Cluster be the glue between VirtualActor and Remote? Not sure if that solves @jrouaix's problem though.

@cpx86 theoretically, it should be completely possible to create a custom ClusterProvider that is a single node.
But cluster starts the remote subsystem, so I think you might be onto something about extracting the virtual actor part.
It is somewhat entangled right now. Cluster is bound to Remote via code and messages.

Is your suggestion to build a cluster provider that allows you to start a single node, that thinks it is a cluster?

Exactly !
@cpx86 for sure a virtual actor concept independent from location/communication concerns would be a plus I think
I'll publish a PR soon, comments are welcome

Closing as this has been merged


[GLUTEN-3779][CH] Fix core dump when executing sql with runtime filter

What changes were proposed in this pull request?
When there are empty input blocks in the final stage with the bloom_filter_agg, it will be core dump for the CH backend.

The RC is: when merging values in the final stage, the input data maybe a non-init AggregateFunctionGroupBloomFilterData, it will use the wrong filter size and filter_hashes values to init the first AggregateFunctionGroupBloomFilterData, which leads to set the wrong filter size when merging values.
Close #3779.
(Fixes: #3779)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_master_11_20_2023_time.csv
log/native_master_11_19_2023_5f5d18abe_time.csv
difference
percentage

q1
34.37
34.50
0.132
100.38%

q2
24.70
24.57
-0.135
99.45%

q3
35.40
37.14
1.738
104.91%

q4
36.40
36.74
0.343
100.94%

q5
68.86
70.93
2.070
103.01%

q6
7.01
7.09
0.075
101.07%

q7
85.39
83.62
-1.775
97.92%

q8
87.44
85.87
-1.566
98.21%

q9
124.93
126.22
1.288
101.03%

q10
46.83
46.75
-0.076
99.84%

q11
19.99
19.85
-0.146
99.27%

q12
24.57
25.57
0.999
104.06%

q13
44.85
45.26
0.411
100.92%

q14
18.77
18.39
-0.381
97.97%

q15
27.13
28.36
1.229
104.53%

q16
15.41
15.85
0.435
102.82%

q17
102.21
100.27
-1.936
98.11%

q18
149.83
147.67
-2.161
98.56%

q19
13.48
13.00
-0.480
96.44%

q20
28.10
26.75
-1.355
95.18%

q21
220.09
222.79
2.699
101.23%

q22
12.89
13.20
0.309
102.39%

total
1228.65
1230.37
1.717
100.14%


Mobile View Styling - Initiatives dashboard table

Description
Fix on Initiatives dashboard table mobile styling.
Previous

Fix

state and territory initiatives rows on mobile use the same styling

Related ticket(s)

CMDCT- https://jiraent.cms.gov/browse/CMDCT-3500

How to test

Login and go to a report
Create and view the Initiatives dashboard table mobile view using browser tools.
Compare styling to https://www.figma.com/file/oOJMUZerbafZefLQQ33GwI/MFP_Playground?type=design&node-id=0-1&mode=design&t=9zlFLH78hGZFJg6h-0

Notes

Pre-review checklist

[ ] I have performed a self-review of my code
[ ] I have added thorough tests, if necessary
[ ] I have updated relevant documentation, if necessary

Pre-merge checklist

Review

[ ] Design: This work has been reviewed and approved by design, if necessary
[ ] Product: This work has been reviewed and approved by product owner, if necessary

Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).

[ ] These changes are significant enough to require an update to the SIA.
[ ] These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

I was hoping we would be able to do this with fewer markup changes - ideally, none at all. Something like changing to flex-direction: column on the table rows, for @media (max-width: 720px)... or something along those lines. I haven't looked very closely at this code yet to see what the difficulties would be though. I'd be happy to dig in further :)

I was hoping we would be able to do this with fewer markup changes - ideally, none at all. Something like changing to flex-direction: column on the table rows, for @media (max-width: 720px)... or something along those lines. I haven't looked very closely at this code yet to see what the difficulties would be though. I'd be happy to dig in further :)

I refactored the code based on this. I tried to stick with the td structure from the desktop view but it wasn't that flexible. I put everything into one td which seemed to work better.