Caching

Just wondering if you have any plans on adding caching support to the handler?

Are you using the handler exclusively? I hadn't considered adding caching as it's usually only used in the debugging scenario, but I guess it's possible people are using it directly.

No, not exclusively,  it would be just nice to have some caching even if optimizations are disabled/debug mode, since it might take some time to compile bigger style-sheets (custom bootstrap theme in my case).

So, the biggest difficulty here would be knowing if the file was still good or not when you are using partials because unfortunately we don't know what's going into the output css file. I'm gonna say this probably isn't feasible at this time.

Well it doesn't have to depend on partial files, it could also be something like app.scss?v=UM624qf1uFt8. But I'm not sure if it's even something that can be done with System.Web.Optimization when EnableOptimizations is set to false

As of Beta-6 (not it nuget) the time needed to compile scss (foundation by zurb in my case) is up to 2-3 seconds. a huge slowdown occurs when the IIS process is restarted ( due to recompile or web.config change). When this happens an IIS app pool & site process restart is recommended. i'm still investigating as to why is this happening.

I would greatly appreciate caching feature as I'd like to use the handler in production.
My project should support dynamically adding and modifying scss files without restarting the server, so having static preprocessing is not not a good option. Bundles are also not the best solution, as modifying imported files does not trigger bundle update. I see caching in the handler as the only elegant solution, or would you suggest something else? Thanks!

I think caching could be implemented using built-in ASP.NET HTTP cache by providing System.Web.Caching.CacheDependency for all imported files, this way cache would be automatically reset if any of the files are modified. Similar approach is used in dotLess. The list of imported files can be retrieved through SassResult.IncludedFiles. What do you think?

@timkishkin this should have been fixed in latest versions of the library.

The slowdown you've mentioned above is apparently fixed, right. But the caching is still missing, I think. I've checked the performance on a bootstrap scss, and the handler takes about 270ms in average to serve the main file. That is good enough, but still way slower than serving static file. It certainly doesn't cache the output, and such handler cannot be used in production, where I would like to use it (see explanation above).

Are you using the handler directly, or are you using the bundling stuff? I think it's probably possible to add cache watching like that in general for development purposes. things get more complicated with doing something like that automatically for release builds as there can be issues when people run off a network share and exhausting unc resources from file watchers.

Yes, I was planning to use handler directly in production, for reasons I've explained above. The absence of caching prevents me from doing that.

there can be issues when people run off a network share

To be honest, I didn't think about it. Are you sure it would be an issue? I thought that ASP.NET bundling uses file watchers as well, as bundles are auto-updated after source file modifications (I might be mistaken, of course).
Anyway, I'm not planning to use network paths in my case. I think caching might be a good option for me and other people with the same use case.

In what kind of scenario do you want to use the caching?

generate once & cache until redeployment?
re-generate every X hours/days
cache until a file (.scss) changes

My ideas :

use bundling and minification
use bundling and minification
this can be quite tricky if you have lots of .scss files in different .css outputs and lots of nested imports , and best case would be to store the user's .scss somewhere in a db or a file and regenerate the output file manually when your system has detected/triggered change. Basically implement this yourself because that will suit your situation better than relying on a generic solution from us that won't quite work for you.

My scenario is the 3rd one. OK, I will consider implementing the cache by myself when I have more time. Thank you for the explanation!

there can be issues when people run off a network share

To be honest, I didn't think about it. Are you sure it would be an issue? I thought that ASP.NET bundling uses file watchers as well, as bundles are auto-updated after source file modifications (I might be mistaken, of course).

definitely an issue that i've run into before. in general with sass, you end up having a file watcher on maybe like 1 - 2 files (root level scss) which is less of an issue, but once you start adding multiple watchers for single files (referenced by many includes) etc things start getting dicey.
it's probably a non-issue right now though because i forgot that scss still doesn't work with windows network paths 😄


Multiple things I've noticed while using Slate

Describe the bugs

About Me title and body text are misaligned and lean too much to the border of the user popout.
The "x" symbol is displaced when you hover your cursor over editable roles in a server.  It appears in the middle of the role instead of the side, so it overlaps with the role name.
The Add to Server button in a bot's user popout overflows past the popout itself, though it doesn't appear in the background.  This is only a minor thing and it doesn't really cause any problems.  I just wanted to point it out in case the button wasn't intended to look like that.
Displaced status symbol when viewing your user profile and status.  Along with this, the shape of the View Profile button is still the same default circle even when you have the Slate theme on.
Do Not Disturb status info text doesn't have enough space, causing it to overlap with the text below it.  The status names also look a bit uncentered with what seem to be incomplete borders.
Same case as #66, but for me, it only affects the inbox popout.

To Reproduce
1.)

Click on someone’s profile through one of their messages or through a server’s member list to view their About Me.

2.)

Have a server that allows you to create and edit roles.
Make a new role and assign it to any member.
View the server profile of the member assigned with the new role.
Hover your cursor over the new role.

3.)

View the profile of any bot from any server.

4.)

Click on your avatar beside the file attachment button.
In the popup, hover your cursor over your profile picture to see the View Profile button.

5.)

Repeat the first step from 4.)
Hover your cursor over the text that displays your current status.

6.)

Open your inbox. 👍

Screenshots
1.)

2.) - 3.)

4.)

5.)

6.)

Information
Discord channel: Stable
OS: Windows 10
Mod: BetterDiscord
Discord language: English US
Additional context
I am not certain if any of the aforementioned issues above are present in any other devices beyond mine.

I've just submitted a pr to fix the about me section, will try my best to fix the others as well

I fixed all the issues except number 4 which was giving me a lot of trouble. I submitted a punch of PRs to fix all of those, no idea if they will get accepted, or if the maintainers are actually active. You can just paste this into the local CSS file for the plugin and it should fix most of the issues. Feel free to tweak it a little; I know it isn't perfect.
.userInfoSection-3her-v {
    margin-left: 10px;
}

.description-1Dd2kv {
    font-size: 0px;
}

.statusItem-38ArJn {
    padding: 1px 8px;
}

#app-mount .wrapper-30-Nkg.cozy-VmLDNB:not(.groupStart-3Mlgv1) {
    margin-top: -5px;
}

#app-mount .repliedMessage-3Z6XBG + .contents-2MsGLg .header-2jRmjb {
    margin-bottom: 34px;
}

#app-mount .repliedMessage-3Z6XBG {
    padding: 1px;
    padding-left: 3.5px;
    padding-right: 4px;
}

.roleRemoveIcon-387wKV {
    width: 10px;
    height: 100%;
    top: 5px;
    left: -5px;
    margin: -5px 0 0 -5px;
    background-color: var(--background-dark);
    border: 1px solid var(--background-dark);
    border-left: 11px solid var(--background-dark);
}

#app-mount .userPopout-2j1gM4 .member-perm, #app-mount .userPopout-2j1gM4 .role-2TIOKu {
    border-radius: 50px;
    padding-left: 17px;
}

#app-mount .userPopout-2j1gM4 .member-perm .perm-circle, #app-mount .userPopout-2j1gM4 .member-perm .roleCircle-3K9O3d, #app-mount .userPopout-2j1gM4 .role-2TIOKu .perm-circle, #app-mount .userPopout-2j1gM4 .role-2TIOKu .roleCircle-3K9O3d {
    left: 10px;
}

#app-mount .userPopout-2j1gM4 .actionButton-1YKTU0 {
    position: absolute!important;
    top: -34px;
    padding-left: 0px!important;
}

#app-mount .lookFilled-yCfaCM:not(.colorGrey-2DXtkV), #app-mount .bd-modal-wrapper .footer button, #app-mount .primaryButton-361sHl {
    width: 93.5%;
}

#app-mount .panels-3wFtMD button {
    padding-top: 3px;
}


Center Text with Bootstrap: don't mention  as it doesn't exist

Also change the wording of the preceding sentence to be singular, as
we only care about <h2>s.
Fixes #1361.

Rebased against the latest staging.

Nice catch, @issyl0!


[Feature]: 翻译 guides/ssr.md

What is the new or updated feature that you are suggesting?
增加中文版
Why should this feature be included?
增加中文版

我翻译guides/ssr.md，时间2021.12.29-2022.01.03


Neutronium - Info: Unable to convert javascript object

Hi @David-Desmaisons
i get these messages, but have no idea where those are created. Is it possible to include line number and file where this occurs?
Neutronium - Info: Unable to convert javascript object: Neutronium.WebBrowserEngine.ChromiumFx.V8Object.ChromiumFXJavascriptObject to C# session. Value will be default to null. Please check javascript bindings.
Neutronium - Error - Unable to update ViewModel from View, exception raised: Unable to convert javascript object: Neutronium.WebBrowserEngine.ChromiumFx.V8Object.ChromiumFXJavascriptObject to C# session. Value will be default to null. Please check javascript bindings.
thanks

and a few more weird messages:
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Info: Exception encountred during task dispatch: Object reference not set to an instance of an object.
Neutronium - Browser Log: Message: Neutronium: ViewModel injected, source: , line number: 11183, page: file:///D:/prod/tools/BuildTools/buildallextension/BuildDrop/vs17/farmi.html
would be nice here also to know a bit more context

Hello, regarding the first message: you are calling a command with an unexpected object and in return Neutronium will call Command with null parameter. This is due to a problem in the javascript side when calling a command. The behaviour was the same in the precedent version expect it was not logged. So this message can help improve the communication between JS and C# sending correct argument.
Reagrding the second message I never seen it. Could you give more context? From the stack, I would guess this happens during the loading of the HTML page, correct? I would guess that there are some javascript errors in the scripts on page load that may cause this problem. Try to debug stopping on exception to get more information.

@David-Desmaisons yes the second ones were related to some errors in javascript side, ive decided to use c# objects in most of my bindings and then i saw you have limit implementation for those (bad idea).
for the first warnings is still a bit weird i get the message
Neutronium - Info: Unable to convert javascript object: Neutronium.WebBrowserEngine.ChromiumFx.V8Object.ChromiumFXJavascriptObject to C# session. Value will be default to null. Please check javascript bindings.
Neutronium - Error - Unable to update ViewModel from View, exception raised: Unable to convert javascript object: Neutronium.WebBrowserEngine.ChromiumFx.V8Object.ChromiumFXJavascriptObject to C# session. Value will be default to null. Please check javascript bindings.
but the only command that is triggered:

contains non null value, so the warning should not be there.
from js side i have
this.ViewModel.RefreshConfigurations.Execute(this.ViewModel.SelectedEnvironment.BasePath);

@jmecosta , looking better at the exception it seems that you are adding an element to collection with a none-supported javascript object (none basic or object not mapped).

At the moment there are really a lot of observablecollections with some complex types inside. So not possible from your side to improve the logging to tell is what c# object is causing this? I mean from a functionality point of view the application works

well actually found the type that causes it.
    public class TSEnvironment
    {
        public string Name { get; set; }
        public string BasePath { get; set; }
    }

basically when changing its value in the multiselect component it get the warning. Supose this is a limitation of neutronium according to #46 ?
from what i see the observable collection is mapped properly into the view, however the select cannot set the object in the c# side.
my html
                        <div class="row">
                            <multiselect :disabled="LocalFarmiData.EditorDisabled" id="environmentBoxSelectId" v-model="ViewModel.SelectedFTCEnvironment" :options="ViewModel.OptionsEnv" placeholder="Choose Environment" :close-on-select="true" :custom-label="nameWithEnv"></multiselect>
                        </div>

nothing special in javascript, besides the initalization
            ViewModel: {
                SelectedFTCEnvironment: { Name: "", BasePath: ""},

or am i doing something weird with all this? thanks

You are correct regarding the limitation.
Regarding the initalization, well if you need it, you should do it in the C# side:
C#:
SelectedFTCEnvironment = new ObservableCollection<TSEnvironment>(){
 new TSEnvironment{Name ="", BasePath =""}
};

@David-Desmaisons thanks for the clarifiacation, i will wait for #46 it should help reducing the codebase quite a lot if this is supported. thanks


Pre-release task: analyze and fix Coverity defects

Analyze and if needed, fix defects reported by Coverity before the release.

Coverity reports 6 new issues:
4 uninitialised field in test_suite_rsa - false alarms
1 uninitialised field in test_suite_psa_crypto.function - false alarm
1 uninitialised field in programs/fuzz/fuzz_server.c - false alarm


add a script to (re)generate the peripheral::* modules

and regenerate them while we are at it

@homunkulus r+

:pushpin: Commit d905136 has been approved by japaric

:hourglass: Testing commit d905136 with merge d905136...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing d90513659afa5c88db684e0eb262201354183fe7 to master...


Disable MIOpen build from source for PyTorch wheels

Avoid rebuilding MIOpen from source for PyTorch wheels, and instead use the MIOpen .so that comes with the ROCm release. Bundle the .db files in the wheel instead of embedding them into the MIOpen .so.
BONUS: This should enable file I/O for the MIOpen .so, which can then read .kdb files if they're placed in the correct path (ie. ../share (wrt the location of the libMIOpen.so) by the user. Just to clarify, we will NOT bundle the .kdb files with the wheels due to their large size, so the user will need to manually install them and place them in the correct path above (we could provide the user a helper script for the same purpose).
FUTURE TODO:

Helper script to install the .kdb files in the correct location for the wheels.
Builder script to install miopen binaries from a non-standard location if needed.

Fixes: https://ontrack-internal.amd.com/browse/ROCMOPS-3381

This successfully produced PyTorch wheels: http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels/167/
However, micro benchmarking resnet50 runs 8% slower in the wheels using stock ROCm5.4 #23 MIOpen vs embedded MIOpen (http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels/164/). This could be because we use the release/rocm-rel-5.4-staging branch of MIOpen for the embedded MIOpen build, vs release/rocm-rel-5.4 branch for stock ROCm5.4 #23 MIOpen.

/cc @sunway513 @JehandadKhan


Add legend info to GetAnnotationObject functions.rst doc

Added info about legends to GetAnnotationObject section of functions.rst.
Regenerated MethodDoc.C
@markcmiller86 This is in response to our discussion on PR #5002
I verified that your visit_apropos script will print 'GetAnnotationObject' when 'legend' is the search key (as well as the others previsouly printed).
Resolves #5004.

I started wondering about how easily the whole of the quickrecipies.rst could be pulled into functions.rst and hit a

You're not suggesting we do away with quickrecipes are you?

You're not suggesting we do away with quickrecipes are you?

Yes. Absolutely. Why not?

Yes. Absolutely. Why not?

They are handy. We even have a ticket in our system to add more recipes (#4766).
Plus, trolling through the function list is clunky if I am looking for a quick way to learn how to do something that may involve multiple functions.  A function list isn't my first choice.  I'm thinking of the use-case of reading the manual, not trying to figure something out when I'm in the middle of a python/cli session.

I also personally like the quick recipes. I view them as really short targeted tutorials. I think someone can find something a lot quicker by looking for the right “how to” recipe than trying to find the correct function and then looking at that function description to provide a how to. I frequently have a hard time finding the right function because I try to apply logic to the naming patterns to figure out the name of the function and then I don’t find it and at some later time I discover that my logic misled me. This probably means our function names weren’t chosen well (or I’m like a 5 year old trying to learn English and getting frustrated when it doesn’t work logically to me), but that’s hard to fix now. The quick recipes sounds very intuitive to me, whereas looking for the right function seems like an easter egg hunt and I may not find what I am looking for quickly. I can see one benefit to it, in that if you have a good way to search the doc strings, you can potentially search for it in the Python interpreter. I do think we need to be careful not to add too many recipes or it may become large and unwieldy.


Ignoring the sequence of child nodes doesn't work

I am getting 4 differences in this piece of code. Although I hope to get that they are identical
var xml1 = "1<C>2</C>";
var xml2 = "<C>2</C>1";

var source1 = Input.FromString(xml1).Build();
var source2 = Input.FromString(xml2).Build();

var diff = DiffBuilder
	.Compare(source1)
	.WithTest(source2)
	.WithDifferenceEvaluator(DifferenceEvaluators.Chain(
		DifferenceEvaluators.Default,
		DifferenceEvaluators.DowngradeDifferencesToSimilar(ComparisonType.CHILD_NODELIST_SEQUENCE)))
	.CheckForSimilar()
	.Build();

you are telling XMLUnit to downgrade the sequence differences to similar, you want DowngradeDifferencesToEqual.

I tried to replace DowngradeDifferencesToSimilar with DowngradeDifferencesToEqual, but got the same result.
I also tried replacing CheckForSimilar with CheckForIdentical, but I still get differences in these cases.

The thing you are missing is an ElementSelector that ensures you match same-named elements to each other. See https://github.com/xmlunit/xmlunit.net/commit/0952ce92045a5b314aa14aa031eedeba56300490 for a passing testcase.


Animation example

Nice work on fonsp/Pluto.jl#17, design looks nice and works like a charm.
How would you recommend doing animations? One can now drive animations from javascript by doing something along the lines of:
@bind t html"""
<div id='time'>
	<input id='speed' type='range' min='-1' max='1'/>
	<label id='time' for='speed'/>
	<script>
		const time  = document.querySelector("div#time")
		const label = document.querySelector("label#time")
		const speed = document.querySelector("input#speed")
		let t = 0;
		setInterval(dt, 10);
		function dt()
		{
      	   t = t + speed.valueAsNumber * 0.01;
		   time.value = t;
		   label.innerHTML = t.toFixed(2);
		   time.dispatchEvent(new CustomEvent("input"))
		}
	</script>
</div>
"""

and then using t to animate other cells.
@fonsp is there a better / simpler way you'd recommend?
I also tried driving an animation from julia, using @async or @spawn to increment a global time variable in the background. The time variable does get updated, but the asynchronous updates do not trigger reactive evaluation of dependent cells. Is there is a way to trigger reactive eval from asynchronous blocks of code?

I have added PlutoUI.Timer, try it out!


Some Bugs about data.csv

There may be some bugs in ./data/data.csv. Some of the annotations(i.e. cz_world) may be out of range.

@fjssharpsword

Hello, have you solved this problem, I see that part of the uid of the dataset does not match

No, I think the dataset is terrible rather than reliable.

Hello, have you solved this problem, I see that part of the uid of the dataset does not match

No, I think the dataset is terrible rather than reliable.

您好，您解决了这个问题吗，我看到数据集的部分 uid 不匹配

不，我认为数据集很糟糕而不是可靠。

Ok, thank you very much for your reply


postgresql cache error

Describe the bug

Loading up the app on the public instance of augur, the issue staleness and issues over time graphs fail toload
The following error is generated on the backend

postgres-cache-1    | 2024-03-11 16:42:06.705 GMT [3630] STATEMENT:  INSERT INTO issues_query VALUES (25498,'grimoirelab',33978,350,648121323,'01000cb7-4800-0',NULL,'2020-06-30T12:11:08'::timestamp,NULL),(25498,'grimoirelab',33977,351,648126105,'01000cb7-4800-0',NULL,'2020-06-30T12:18:59'::timestamp,NULL),(25498,'grimoirelab',33976,352,648234326,'0100f374-8f00-0',NULL,'2020-06-30T14:41:32'::timestamp,'2020-07-13T12:25:57'::timestamp),(25481,'grimoirelab-elk',32773,907,649027087,'010025af-9700-0',NULL,'2020-07-01T14:26:53'::timestamp,'2023-10-11T16:09:01'::timestamp),(25507,'wg-risk',32689,102,649305848,'0100a0d0-b500-0',NULL,'2020-07-01T20:41:01'::timestamp,'2020-08-07T18:50:25'::timestamp),(25506,'wg-value',32616,104,650025557,'01008739-4500-0',NULL,'2020-07-02T15:31:14'::timestamp,'2020-09-10T15:07:41'::timestamp),(25528,'wg-ospo',32344,5,1654424765,

...

06054,'0102296d-9f00-0',NULL,'2024-03-08T08:08:12'::timestamp,NULL) ON CONFLICT DO NOTHING
worker-query-1      | [2024-03-11 16:42:06,708: CRITICAL/ForkPoolWorker-1] issues_query_POSTGRES ERROR: integer out of range
worker-query-1      |
worker-query-1      | [2024-03-11 16:42:06,711: ERROR/ForkPoolWorker-1] Task queries.issues_query.issues_query[17c290ac-7536-49fb-8d47-686021a763de] raised unexpected: Exception(NumericValueOutOfRange('integer out of range\n'))
worker-query-1      | Traceback (most recent call last):
worker-query-1      |   File "/opt/app-root/src/cache_manager/cache_facade.py", line 188, in caching_wrapper
worker-query-1      |     cache_query_results(
worker-query-1      |   File "/opt/app-root/src/cache_manager/cache_facade.py", line 91, in cache_query_results
worker-query-1      |     execute_values(
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/psycopg2/extras.py", line 1299, in execute_values
worker-query-1      |     cur.execute(b''.join(parts))
worker-query-1      | psycopg2.errors.NumericValueOutOfRange: integer out of range
worker-query-1      |
worker-query-1      |
worker-query-1      | During handling of the above exception, another exception occurred:
worker-query-1      |
worker-query-1      | Traceback (most recent call last):
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/celery/app/trace.py", line 451, in trace_task
worker-query-1      |     R = retval = fun(*args, **kwargs)
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/celery/app/trace.py", line 734, in __protected_call__
worker-query-1      |     return self.run(*args, **kwargs)
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/celery/app/autoretry.py", line 54, in run
worker-query-1      |     ret = task.retry(exc=exc, **retry_kwargs)
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/celery/app/task.py", line 717, in retry
worker-query-1      |     raise_with_context(exc)
worker-query-1      |   File "/opt/app-root/lib64/python3.9/site-packages/celery/app/autoretry.py", line 34, in run
worker-query-1      |     return task._orig_run(*args, **kwargs)
worker-query-1      |   File "/opt/app-root/src/queries/issues_query.py", line 62, in issues_query
worker-query-1      |     cf.caching_wrapper(
worker-query-1      |   File "/opt/app-root/src/cache_manager/cache_facade.py", line 199, in caching_wrapper
worker-query-1      |     raise Exception(e)
worker-query-1      | Exception: integer out of range
worker-query-1      |
worker-callback-3   | [2024-03-11 16:42:06,869: WARNING/ForkPoolWorker-1] ISSUES OVER TIME - WAITING ON DATA TO BECOME AVAILABLE
worker-callback-11  | [2024-03-11 16:42:06,869: WARNING/ForkPoolWorker-1] ISSUES STALENESS - WAITING ON DATA TO BECOME AVAILABLE
worker-callback-1   | [2024-03-11 16:42:07,321: WARNING/ForkPoolWorker-1] [('queries.issues_query.issues_query', 'FAILURE')]

To Reproduce
Steps to reproduce the behavior:

go to https://metrix.chaoss.io to see the frontend error
start 8Knot up against an app pointed to https://ai.chaoss.io to see the example backend errors.

fixed on dev


Calendar View does not open

Before Submitting: Double-check that you are running the latest version of the plugin. The bug might have already been fixed 😄

Describe the bug
After first installation, the calendar view does not appear on the sidebar and cannot be opened through the command palette.
I'm running on v1.0.3
Any help is appreciated
Steps to reproduce

Go to '...'
Click on '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment (please specify)
OS
[Windows]
Obsidian Version (e.g. v0.10.6)
v1.0.3
Theme (if applicable):
Blue Topaz

can be closed. I just had to drag out the side pane and then the icon appeared...

Glad it's not just me then! Thanks for the fix.


chore: add Vitest

Adds Vitest

RELEASE NOTES BEGIN
Add Vitest for frontend testing
RELEASE NOTES END

@mfocko

So the lockfile got removed in #473 just to be reintroduced here…

There I removed a duplicate, no longer used, file as we had one in two spots. Bit confusing for sure but we should only have the one modified in this PR

Saving the HTML generated by React sounds like something we do in ogr for git-forge responses for tests, but at the same time I wonder what's the point of testing here, when bumping a release might change the expected result. How are you even supposed to tell that something's broken when there's a constant flow of changes from the dependencies…

In most scenarios it should not change, and is an indicator that things render correctly. We can setup scenarios for how things should look like given specific inputs, such as if the API server is down, one request succeeded but the other one failed etc.
So for the snapshots that render React it is small enough that any changes should only happen when code itself is changed, and if it is changed on each dependency update, that should be addressed for sure so it doesn't happen again (if nothing visual is changing that is). But PatternFly tends to keep visual changes to a minimum.
We can also do image/pixel tests if we want to instead, but that takes up a bit more storage

There I removed a duplicate, no longer used, file as we had one in two spots. Bit confusing for sure but we should only have the one modified in this PR

OH! that's not a new file, that's 1k new lines in the existing one /o\


Update Base64Url dep to latest version to fix Out-of-bounds Read Security Issue

NPM gives off an audit warning because this library uses Base64Url ^2.0.0, which contains the Out-of-bounds read security issue. This issue seems to be patched in the ^3.0.0 version of the Base64Url library.
Source: https://nodesecurity.io/advisories/658

Thanks for letting us know @MichaelFedora -- will look into updating (or possibly eliminating the dependency) now.


Add Integration tests for kafka source TLS

Currently we use rust-rdkafka as our kafka driver in our integration tests, however it does not support TLS.
So if we want to integration test TLS support for the source we will need to either:

Abstract over drivers like we for cassandra, and introduce rskafka as a second driver - it supports TLS just fine https://docs.rs/rskafka/latest/rskafka/client/struct.ClientBuilder.html#method.tls_config
Implement TLS support for rust-rdkafka - https://github.com/fede1024/rust-rdkafka/issues/657

resolved by https://github.com/shotover/shotover-proxy/pull/1587


CAD-494 exact filter for message eliding

fixing the filter for eliding messages to be more specific.

bors r+


Start Spotify-Notifications on Spotify start

It would be great if Spotify-Notifications would be able to launch when Spotify starts in addition to the launch at start option.

Hey @Dalibor22x, have you tried using Automator to create a launcher that starts both Spotify and Spotify Notifications? See http://apple.stackexchange.com/a/153324 for an example.

Hey @robinnorth , haven't thought about that and I think I will use this solution, but it would be great if it would be a built-in option.

Is it necessary to have Spotify Notifications launch only when Spotify is launched vs launching at login? Seems there's very little difference – the app is pretty lightweight.
To have Spotify Notifications 'launch' (show in menubar) when Spotify launches would require a background process to check when Spotify is opened, meaning no matter whether you choose Launch At Login or Launch with Spotify, there'll be a process running.

Yep, I'd agree with @sebj and @robinnorth - using ControlPlane or an Automator application would probably be the way to go.
Another option - assuming you're comfortable scripting - would be to use HammerSpoon to watch for the launch of Spotify (using hs.application.watcher) and then launch Spotify Notifications (using hs.application).
Like @sebj said, any solution which is native to Spotify Notifications would require some sort of daemon which runs on launch, watching for the start of the Spotify application. It's extremely unlikely that a solution like that would be merged in.

@sebj @citruspi Ok I see, the best solution would be to use Automator as @robinnorth mentioned.


Feature: Switch / Pattern Matcher Hook

I'm finding it useful to have a useSwitch hook - it allows me to do things like authorization in the parent component rather than repeating it inside each route. It's like a useRoute for when you don't know which pattern to expect. I've thrown together my own hook but thought I would propose it as a feature in case you think others would find it useful.
const Page = () => {
    // if location = "/projects/123", useSwitch will return ["/projects/:id", { id: 123 }]
    const [pattern, params] = useSwitch(["/dashboard", "/projects/:id", "/user/:id"]);
    if (!hasPermissions(pattern, params)) {
        return <NotAuthorizedPage />
    }
    return getPage(pattern, params);
}

const useSwitch = (patterns = []) => {
	const [location] = useLocation();
	const { matcher } = useRouter();
	let matchedPattern = [];
	patterns.find((p) => {
		const [match, params] = matcher(p, location);
		if (match) {
			matchedPattern = [p, params];
		}
		return match;
	});
	return matchedPattern;
};

You mean built in wouter?

Yeah, the way I see it is <Router>, <Route>, <Link>, and <Redirect> all have hook equivalents -  but <Switch> does not. But I just saw molefrog wouldn't like to expand the feature set much (https://github.com/molefrog/wouter/issues/108) so maybe I'll close this one - not a big deal :)


add header to fieldboundary.msg

Resolves: #13
Signed-off-by: Kenji Brameld<EMAIL_ADDRESS>

But rolling is still on Ubuntu 20.04 right?

Some discussion about this is happening here
Essentially, ROS2 Humble has Ubuntu Jammy (22.04) as a Tier 1 and Ubuntu Focal (20.04) as a Tier 3, so I'd imagine rolling will get rid of focal support after releasing Ros2 Humble.


Add count and tag filter

:question: What
Add a new filter, called CountAndTag. This filter publishes a metric that simply counts all records that pass through, using one of the field as value for metric tag. By default, records having where the chosen field is empty are counted, but not tagged.
You can change that behavior by setting a default tag value for these records, with the DefaultTagValue configuration parameter.
TODO: measure performance of this filter with an actual metrics client, such as datadog, and conclude about the necessity or not to reduce allocations in the Process method.
:hammer: How to test

List all steps necessary;
To test this pull request.

:white_check_mark: Checklists
This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

[x] Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
[x] Have the changes in this PR been functionally tested?
[x] Have new components been added to the related all.go files?
[ ] Have new components been added to the documentation website?
[x] Has make gofmt-write been run on the code?
[x] Has make govet been run on the code? Has the code been fixed accordingly to the output?
[x] Have the changes been added to the CHANGELOG.md file?
[x] Have the steps in CONTRIBUTING.md been followed to update a Go module?

Codecov Report

Merging #201 (4196e00) into main (40a57bc) will increase coverage by 6.81%.
The diff coverage is 77.96%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   53.95%   60.77%   +6.81%
==========================================
  Files          60       65       +5
  Lines        4003     4877     +874
==========================================
+ Hits         2160     2964     +804
- Misses       1646     1681      +35
- Partials      197      232      +35

Impacted Files
Coverage Δ

api.go
100.00% <ø> (ø)

baker.go
0.00% <0.00%> (ø)

filter/clausefilter.go
73.50% <0.00%> (+1.18%)
:arrow_up:

filter/clear_fields.go
75.00% <0.00%> (+10.71%)
:arrow_up:

filter/concatenate.go
81.81% <0.00%> (+5.15%)
:arrow_up:

filter/dedup.go
90.32% <0.00%> (+1.86%)
:arrow_up:

filter/expand_json.go
96.61% <0.00%> (+0.45%)
:arrow_up:

filter/format_time.go
97.91% <0.00%> (+0.11%)
:arrow_up:

filter/hash.go
77.55% <0.00%> (+0.46%)
:arrow_up:

filter/metadata_lastmodified.go
89.47% <0.00%> (+0.58%)
:arrow_up:

... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e98ab...4196e00. Read the comment docs.


--help contains ambiguous documentation for the "version option"

$ packit --help
Usage: packit [OPTIONS] COMMAND [ARGS]...

  Integrate upstream open source projects into Fedora operating system.

Options:
  -d, --debug        Enable debug logs.
  --fas-user TEXT    Fedora Account System username.
  -k, --keytab TEXT  Path to FAS keytab file.
  --dry-run          Do not perform any remote changes (pull requests or
                     comments).
  -h, --help         Show this message and exit.

Commands:
  build                 Build selected upstream project in Fedora.
  create-update         Create a bodhi update for the selected upstream...
  listen-to-fedmsg      Listen to events on fedmsg and process them.
  propose-update        Release current upstream release into Fedora...
  srpm                  Create new SRPM (.src.rpm file) using content of
                        the...
  status                Display status.
  sync-from-downstream  Copy synced files from Fedora dist-git into
                        upstream...
  version               Display the version.

"Display the version." seem rather ambiguous to me, especially as packit version returns 0.4.1, which is obviously version number of packit, not my package.
I would suggest dropping the version sub-command and replacing it with a classical --version option, which is clearly related to the tool, not the package the tool should be managing.

Thanks for pointing it out.

If we are goint to change that, here is a part of click documentation how we can easily do it...


Update OrchardLog4netLogger.cs

Fix for "ValueFactory attempted to access the Value property of this instance".
Exception Details:
ValueFactory attempted to access the Value property of this instance.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.InvalidOperationException: ValueFactory attempted to access the Value property of this instance.
Source Error:
Line 61:         // Load the log4net thread with additional properties if they are available
Line 62:         protected internal void AddExtendedThreadInfo() {
Line 63:             if (_shellSettings.Value != null) {
Line 64:                 ThreadContext.Properties["Tenant"] = _shellSettings.Value.Name;
Line 65:             }
Source File: D:\Proj\Src\Orchard\Logging\OrchardLog4netLogger.cs    Line: 63

Can you explain why the issue and the solution? Maybe add a comment in the code?
Thanks.

At times, I get exception of  "ValueFactory attempted to access the Value property of this instance".
My guess here is, ShellSettings gets initialized from multiple threads. I do not think ShellSettings is threadsafe. My fix addresses the problem.
Here we can find more information about this https://msdn.microsoft.com/en-us/library/system.threading.lazythreadsafetymode(v=vs.110).aspx


added support for athrow and dup_x1 op codes and ginstance, only for object types

It's hard for me to see what changes you did. Can you close this pull request and open a new one (after  rebasing your fork)?


cant use interfaces

i get "pointer to incomplete class type is not allowed"
it used to work before

in gui.cpp

What does it say? What class?

#include SDK/Surface.h

fixed thanks
idk why but including this wasn't needed in the older versions|
https://github.com/effex1337/100--not-osiris/blob/master/Osiris/GUI.cpp


drivers: w1: Add DS2485 1-Wire master driver

This PR adds a driver for the DS2485 1-Wire master

Thanks for the first review.

Updated the called out properties to int and changed the initialization to to using DT_ENUM_IDX for all enums.
Additionally using select I2C instead of depends on I2C

Rebased on latest main.

Could you please have another look.

@galak @ycsin I have addressed your comments, could you please have another look.


database disk image is malformed

Code:
package main

import (
	"database/sql"
	"fmt"

	_ "github.com/cznic/sqlite"
)

func main() {
	c, err := sql.Open("sqlite", "/tmp/test.sqlite3")
	if err != nil {
		panic(err)
	}
	defer c.Close()

	_, err = c.Exec("CREATE TABLE t1 (t INT)")
	if err != nil {
		panic(err)
	}

	for i := 0;; i++ {
		_, err := c.Exec("INSERT INTO t1 (t) VALUES (?)", i)
		if err != nil {
			panic(err)
		}
		fmt.Println(i)
	}
}

Output:
...
6563
6564
6565
6566 # always fails here
panic: database disk image is malformed (11)

Bug in any of the cc, ccir or virtual packages :disappointed:

If I'm inserting strings instead of ints I get this (seem like a golang error):
unexpected fault address 0x0
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x80 addr=0x0 pc=0x4f7e00]

goroutine 1 [running]:
runtime.throw(0x58120f, 0x5)
        /usr/lib/go/src/runtime/panic.go:596 +0x95 fp=0xc4203e8960 sp=0xc4203e8940
runtime.sigpanic()
        /usr/lib/go/src/runtime/signal_unix.go:297 +0x28c fp=0xc4203e89b0 sp=0xc4203e8960
github.com/cznic/virtual.(*cpu).run(0xc4200800e0, 0x143bb, 0x0, 0x0, 0x0)
        /home/amenzhinsky/Development/go/src/github.com/cznic/virtual/cpu.go:1447 +0x41a0 fp=0xc4203e97b8 sp=0xc4203e89b0
github.com/cznic/virtual.(*Thread).FFI(0xc4200800e0, 0x143bb, 0xc4203e98f0, 0x1, 0x1, 0xc4203e9970, 0x1, 0x1, 0x549ae0, 0xc420236e98, ...)
        /home/amenzhinsky/Development/go/src/github.com/cznic/virtual/thread.go:158 +0x217 fp=0xc4203e9898 sp=0xc4203e97b8
github.com/cznic/virtual.(*Thread).FFI1(0xc4200800e0, 0x143bb, 0x6c56e0, 0xc420236e90, 0xc4203e9970, 0x1, 0x1, 0x540460, 0xc420236d00, 0x0)
        /home/amenzhinsky/Development/go/src/github.com/cznic/virtual/thread.go:110 +0xab fp=0xc4203e9910 sp=0xc4203e9898
github.com/cznic/sqlite.(*stmt).step(0xc4202358c0, 0x7fa91ee022d0, 0x1, 0xc420228990, 0x1)
        /home/amenzhinsky/Development/go/src/github.com/cznic/sqlite/sqlite.go:970 +0xe4 fp=0xc4203e9990 sp=0xc4203e9910
github.com/cznic/sqlite.(*stmt).exec(0xc4202358c0, 0x7fa91f2f9c80, 0xc42000e2e0, 0xc420228990, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0)
        /home/amenzhinsky/Development/go/src/github.com/cznic/sqlite/sqlite.go:651 +0x216 fp=0xc4203e9a00 sp=0xc4203e9990
github.com/cznic/sqlite.(*conn).exec(0xc42008e460, 0x7fa91f2f9c80, 0xc42000e2e0, 0x58643f, 0x1d, 0xc420228990, 0x1, 0x1, 0x0, 0x0, ...)
        /home/amenzhinsky/Development/go/src/github.com/cznic/sqlite/sqlite.go:1209 +0x180 fp=0xc4203e9a70 sp=0xc4203e9a00

(seem like a golang error)

The panic line cpu.go:1447 seems like the VM has entered a corrupted state. My guess is that it's not in Go, but only debugging will tell. This will be non-trivial to figure out. FYI: It's possible to insert debug C printf's in the sqlite3.c code and then enable the debugWriter using -tags sqlite.trace. (go generate must be invoked after changing the sqlite3.c source, of course.)

I'll give it a try this weekend 😄

Will be appreciated :+1:

Also, I suggest to uncomment these two lines.

That didn't help, I added added this code
fmt.Printf("--> %#v\n", c.sp)
fmt.Printf("==> %#v\n", readPtr(c.sp))

right before https://github.com/cznic/virtual/blob/master/cpu.go#L1447 where it panics
--> 0x7f6e76b94268
==> 0x7f6e78a3c8a0
--> 0x7f6e76b941f8
==> 0x7f6e76b94228
--> 0x7f6e76b941f8
==> 0x7f6e76b94228
--> 0x7f6e76b941f8
==> 0x7f6e76b94208
--> 0x7f6e76b941a8
==> 0x7f6e76b941b0
--> 0x7f6e76b941a8
==> 0x7f6e78a3cbd0
--> 0x7f6e76b941a8
==> 0x7f6e78a3cbc8
--> 0x7f6e76b941a8
==> 0x6007f6e789f74e8

And last address doesn't seem a valid memory address.

Another hint: It might be also worth trying to add -tags virtual.trace to the build, but the amount of generated output is prohibitive in non-trivial cases.

Adding the virtual.trace didn't help. It outputs too much information which is not very helpful because it looks like a backtrace.

@amenzhinsky Thanks again for the report, finally got time to look into it. FTR, if you wrap the writing loop in a transaction it runs orders of magnitude faster. Like here.

@cznic. thanks, good job!


Rust bindgen passing BINDGEN_EXTRA_CLANG_ARGS

Hi,
I'm trying to package a Rust binary that depends on some FFI bindings using bindgen, I would like to link against the zlib dependency I have from rattler's dependency which seems to insert the header and library in the correct place, the main issue I'm having at the moment is it seems to include/link against the system headers/libs. What I currently have for the build script section is something like so:
build:
  script:
    - export BINDGEN_EXTRA_CLANG_ARGS ='-I{BUILD_PREFIX}/include -L$BUILD_PREFIX/lib -lz'
    - BUILD_PREFIX/bin/cargo install --features mimalloc --locked --bins --root ${PREFIX} --path foo

requirements:
  build:
    - ${{ compiler('rust') }}
    - ${{ compiler('c') }}
    - zlib
  run:
    - zlib

I'm having issues where the build shows:
fatal error: zlib.h: No such file or directory, I do see the header is present within ${BUILD_PREFIX}/include when I follow the script failure path, is there anything I can do to remedy this?

I think you should write it like this:
build:
  script:
    - cargo install --features mimalloc --locked --bins --root ${PREFIX} --path foo --no-track

requirements:
  build:
    - ${{ compiler('rust') }}
    - ${{ compiler('c') }}
  host:
    - zlib

Interesting, thank you @wolfv. Unless I'm misunderstanding does this require that zlib is installed on the host, and as such I cannot install the package on hosts that do not come packaged with zlib (without root/ability to build from source)? Because I get the following warning:
 │ │ ⚠ warning Warnings:
 │ │ ⚠ warning Overlinking against "/usr/lib/libz.1.dylib" for "bin/foo"
 │ │ ⚠ warning Overdepending against libzlib

Hi @neeldugar - sorry for slow response. Indeed, it looks like this is linking against your system libz which is not great.
In rattler-build / conda recipes libraries that are linked - like libz here should be in the host section of the recipe. Compilers and things that need to be executed during build should be in the build section.
You could indeed add back the line you had and change it to use $PREFIX:
export BINDGEN_EXTRA_CLANG_ARGS ='-I${PREFIX}/include -L${PREFIX}/lib -lz'

I think then things should work!

Hi @wolfv , sorry for the slow response on my end. Okay, I think that makes sense for the most part, so included headers that are necessary during build are separate to executables at the build stage. I've tried your approach but still reach a similar issue here:
 │ ╭─ Packaging new files
 │ │ Copying done!
 │ │ builtin relink for "foo":
 │ │  - changing absolute rpath from "$PREFIX/lib" to<EMAIL_ADDRESS> │ │ codesigning "foo"
 │ │
 │ │ [bin/fst_writer] links against:
 │ │  ├─ /usr/lib/libz.1.dylib
 │ │  ├─ /usr/lib/libSystem.B.dylib (system)
 │ │  └─ /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (system)
 │ │ ⚠ warning Overdepending against libzlib

Which again seems to link against the system zlib.

Did you also check with otool? I am wondering if it's a mistake in rattler-build. But anyways, I can't really tell you what Rust library links against zlib and how they are finding the target to link against. If they are linking with an absolute path, there is little we can do beyond patching :/

Yep, definitely is linking against system zlib:
❯ otool -L foo
foo:
        /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.12)
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 3107.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1351.0.0)

As for the Rust library linkage, it is a standard bindgen dependency - fstapi, that wraps zlib, I had assumed I could modify the search paths to use conda rather than system in this case, but it seems like it overlinks to target system instead.

Can you try: export RUSTFLAGS="-L $PREFIX/lib"?

This is where the linkage comes from: https://github.com/MaxXSoft/fst-tools/blob/8fd01a524ca6f7f11c2db953183a5d90f8676220/fstapi/build.rs#L15-L16

Oh sweet, that does seem to have fixed the issue. Thank you for the clear explanation on this, good to know for FFI projects, this env var should practically always be set to fix the over dependency.

I opened an issue on the Rust feedstock, too: https://github.com/conda-forge/rust-activation-feedstock/issues/65


Using Uri.Builder instead of StringBuilder.

removed a noinspection lint warning
easier to add new parameters

@lmckenzie I always like to remove loc, :) have a great weekend!

👍 Approved
Thanks @moxi!


ipc

(open in new tab instead of new window)

I was looking for this funcion, but must ask on discord.
Not obvious from README.md...

The README is generated from manifest.json so that's the one that needs to be updated.
I think something like Adds inter-process communication support, single-instance mode and tab drag and drop between instances. would be more explanatory.


"https://registry.npmjs.org/react-native-ijkvideo: Not found".

I ran yarn add react-native-ijkvideo and got this in console.
Did it publish to npm yet?

its not published yet.

Can it support full screen mode on android?
Because react-native-video doesn't make it perfect on android.

It is supported

When this releases it will come with the release


Need to add security headers and CORS policies

As a service provider
I need my service to use security headers and CORS policies
So that my web site is not vulnerable to CORS attacks

Given the site is secured
When a REST API request is made
Then secure headers and a CORS policy should be returned


Allow multiple maximum_attempts to be configured on based of some condition

I was looking to solve a similar problem as this stackoverflow question.
I was wondering if devise can provide a feature to either set the attempts dynamically or different maximum_attempts on certain conditions(say user's type property is admin than maximum_attempts are different) can be set in configuration. Currently, as of my search this is not possible and only way seems to lock user manually after n attempts, while maximum_attempts is configured as config.maximum_attempts = x in devise.rb.

Hello @ziaulrehman40, thanks for your request.
We don't have plans to support this for now, so although I know it's not ideal you probably will have to override this code in order to add your custom behavior (like the answer on stack overflow).
If this became a popular feature request we can think about supporting in a next major version.
Thank you!

Add my name to the petition to include this (along with the same for minimum password length). Both seem like obvious functions someone who is setting up Admin > User security control functionality would expect.

Please add my name to the list as well. We are building a multi-tenant SaaS application, and as part of enterprise security requirements, each business customer's IT security typically has rules about what they want to see in terms of password complexity, failed login attempts, session timeout, etc. Rather than forcing everyone to the most strict requirements, we'd like to be able to delegate the configuration to the company level (which owns multiple users), rather than having the same value for all.

@rmorlok I'm wondering if you ended up by monkeypatching the gem or if you moved to some other option?

@rpbaltazar we ended up rolling our own capability. Our app is API based, so we were able to centralize the logic for tracking failed attempts in the controllers handling login and allowed them to delegate the restriction based on the user in question.


Mention sphinxnotes-strike in documentation

Hi
After experimenting a lot with your suggestions in the documentation about how to use strikethrough I was close to give up because nothing seemed to work.
Then I came across this sphinx extension: https://sphinx.silverrainz.me/strike/
Using this let me have strikethrough in html and confluence output.
Maybe you can mention this in your documentation.

Updated the documentation (https://github.com/sphinx-contrib/confluencebuilder/pull/1000) to have a dedicated strike-related section. Feel free to inspect the draft content and leave any comments.

With the v2.6 release, the stable document should provide additional information on the strike-related capabilities -- marking as closed.


Fix #57. Implement Worker API support.

Remove dead code
Fix javadoc warning

Signed-off-by: Kyle Moore<EMAIL_ADDRESS>

こちらこそ、お世話様です。よろしくお願いいたします。

This should also fix #11. Could the OP please try verifying once more?


Moves containerLXC and instance interface to instance package

@stgraber this is quite a bit larger than I had anticipated, as I had to move more parts of the main package than expected to avoid circular dependencies.
I've tried to split the commits between the actual new functions and removal of old ones and the updating of the usage of those functions and types.
I dont expect the tests to pass as when running locally the lint check was asking me to add comments to every exported symbol in containerLXC (as it was a new file).
However if the general direction of this PR is approved then I will go through and clean it up further, but didn't want to spend any more time on it if its going in the wrong direction.
Thanks

Rebased onto master.

Overall direction is good, though we'll definitely want this turned into a lot of smaller PRs that can be easier reviewed. This PR does have the issue of not being in order, so going from commits to commits I can't actually tell what's the impact of a particular piece of code being moved to its own package.
Just a few notes from the commits I briefly went through:

We'll want all those new packages to be golint clean and be added to the test suite
On the Response side, I believe @monstermunchkin was also looking at moving all of those to a separate package, probably worth prioritizing
CPU rebalancing would make more sense in a cgroup package I think. We were going to eventually need that anyway to properly handle cgroupv2 next cycle
I think we'll want to figure out the best way to split API endpoint logic between what's purely API (marshal/unmarshal, etag, ...), what belongs in the package itself and what belongs in the DB package. Then reuse that pattern for anything we're splitting out of main. Operations is the first such instance I'm seeing and the way it's done looks reasonable to me. We may want to reconsider Render() eventually as it's hardcoding URL paths which feel like belong more in the API layer, but close enough.
Any reason for instancetype package rather than instance/type sub-package?
I would stay as far way from Storage as possible for now as we have a separate branch moving it to a package already
Seccomp and AppArmor deserve their own packages
We probably want to wait for Storage to be sorted before digging too much into Migration

As for immediate next steps, I think we can attack:

response as its own package (check if @monstermunchkin doesn't have it ready to push already)
instance/type re-shuffle
seccomp and apparmor packages

If you have a bit of time tomorrow morning before we meet, take a look at #5717, sync with @monstermunchkin on the goal behind the storage API rework and we'll chat about it in our meeting.
I've been quite terrible at getting the storage side of things to move forward but I'm hoping that now that we have actual work blocked on it, we can move forward with it, updating some of it based on what we learned with the other package reshuffle we've done lately.

@stgraber thanks, have synced with @monstermunchkin on the response package and he's got a PR for response and operations, which is great.
I'll put a PR up for the instance/type re-shuffle, the reason I didn't go with instance/type is to avoid the reserved worked type and forcing users of the package to have to import it and then alias it to potentially different names each time. But happy to call it that and then alias it as instancetype during import.
The originally tried to move seccomp and apparmor into their own packages and the issues I hit were:

They both depend on the container type, which is defined in main so cannot be imported when moving to a different package. So it requires container (or as we are getting rid of container then changing it to accept ContainerLXC or Intstance) to be moved into their own package(s) first. And because ContainerLXC uses those functions, it cannot access them if they are defined in main (without manually linking each one, which is possible but time consuming and messy), so they effectively have to be moved together.

Even after I had done that, I then hit the circular dependency issue because the ContainerLXC struct needs to import the apparmor and seccomp package, which also needs to import the package where ContainerLXC is defined. Now from what I can see in apparmor it would probably get away with accepting an Instance rather than a ContainerLXC, so if we were able to define those 2 in separate packages then this could work. For seccomp however it uses some of the container's IDMAP functions and so will require a ContainerLXC so will hit the circular dependency issue.

As soon as seccomp is defined in Instance package then this prevents ContainerLXC being defined in its own package as you get a circular dependency on instance package.

@stgraber update on instancetype vs type, I had instinctively avoided calling it type, but trying it now Go prevents me from defining a package called type anyway, so will stick with instancetype.

@stgraber I've been thinking about the package splitting issue and I think that defining some smaller interfaces inside the split packages (such as seccomp and appamor) would allow them to be kept separate without relying on importing the large Instance interface or directly needing ContainerLXC. I'll give it a go.

@stgraber I got almost there with moving seccomp to its own package using a specialised non-exported instance interface. But I was foiled at the last minute by seccomp's use of findContainerForPid() which is defined in main and returns a container. Which stops me from linking the function from main into the seccomp package too due to the return signature.
I should be able to move that function to its own package though which can then import the instance package as seccomp wont need to import instance to use it. However that blocks me completing this until at least the instance interface has been moved to its own package.

Going to close this one for now in favor of the smaller branches we've been sending through to get this in cleanly.
Don't delete the branch though, we certainly still want to pull commits from it!


Fix clearRect coordinate mistake when reading GIF

In AnimatedGIF.ts
            patchCanvas.width = width;
            patchCanvas.height = height;
            patchContext.clearRect(0, 0, width, height);
            const patchData = patchContext.createImageData(width, height);

            patchData.data.set(patch);
            patchContext.putImageData(patchData, 0, 0);

            // draw image at (left, top, width, height)
            context.drawImage(patchCanvas, left, top);
            const imageData = context.getImageData(0, 0, canvas.width, canvas.height);

            if (disposalType === 2)
            {
                // but clear rect at (0, 0, width, height)
                context.clearRect(0, 0, width, height);
            }

When the image has transparent pixels, left and top are not always 0, which can cause clearRect range errors, and results in issue like #3

that's awesome, hope we can get it pulled in soon.

not sure about the specific mapping of disposalType, but after testing i found that clearRect also needs to be called when it is 3.

thank you, when can we expect this to be merged? tx again, Sean.

@bigtimebuddy could you have a look at this PR please? We are encountering the same issues and this seems to have solved it.

Sure. Could someone provide a GIF that demonstrates this problem?

This is one GIF that exhibits the problem for us. @born2net @maliut could you provide some additional GIFs too?

👆 This is the picture where I first found the problem

👆 And this is the picture have disposalType is 3

Published v1.0.3 with this fix.

thank you!


Correctly deleting mousetrap instances

I've just come across MouseTrap and think it's a fantastic framework. I'm attempting to wrap it with an Aurelia custom attribute but I wanted to be sure my chosen method for destroying the MouseTrap instance is correct and I'm therefore freeing memory and dropping any event listeners.
When the aurelia view model is bound to the interface I'm running the following code to create a specific MouseTrap for the current DOM element:
   this.mousetrap = new MouseTrap(this.element);
   this.bindKeyboard();

The bindKeyboard() method binds the current configuration of keys and callbacks.
When aurelia removes the view model the unbind is automatically called and I'm currently doing this:
    this.mousetrap.reset();
    delete this.mousetrap;

Is that enough to remove the instance?

I also was wondering about just this need, though for me using React.  I note that there are no removeEventListener() calls in Mousetrap, and there isn't any way indicated as to how to deregister DOM event listeners.  So whatever the callers do, wouldn't this leave the three event routines registered?
I guess this is a feature request... :-)

I'm checking through issues and PRs and saw pull request "Add Mousetrap.prototype.destroy" #264 , so we're not the first to want this.

As i see this is quite old, question is this relevant? Has been this addressed somewhere in different way ? @ccampbell can you please give us your stand for this?

Also just bumped into this when evaluating Mousetrap. Other than this omission, seems like a great lib. Why do we need to manually remove event listeners when cleaning up?


Please review New Blog Post - "Build your MicroProfile apps quickly with Boost"

https://microprofile.io/wp-admin/post.php?post=6197&action=edit
Sorry, first time posting on this blog plus not too familiar with WordPress, and I didn't do anything for steps 5, 6 here for Feature Image or Page Header Image, though I did link to the YouTube recording of the MP Hangouts demo.
Would be happy to incorporate any suggestions.
Thank you !

@scottkurz formidable turarond on blog introducing via writing Boost!:)
Recomemnded feedback:

After the Boost Vision, how about adding a 3rd paragrah that introduces the Boost demo presentation on 4/16 call (leaving that fact for the end of the blog under Learn More is not efficient)
The blog's value is not only to introduce Boost but actually tell us the steps that get to to explaining what Boost is first.

Maybe add the fun fact as to how the name can to be?  I think that was fun and part of Boost and the about you and the team.
Mind you, you-- the people that are braiding Boost are as important to be introduced as the extension itself.

Tell us under Lern More the steps the team behind it must own, as stated on the call:)

You will send a thread to the forum 2) a Repo sandbox will be created after that msg for the code to be moved to the MP repo and welcome the Contributors to participate in the prototaype
3... etc... :) Boost is not yet part of MP, stated that clearly in the blog. Stating it is a protoptype is not enough.

Looking forward to 2nd draft and wonderful first draft to start with. Impressed!

Thx Amelia, for the supportive words and the detailed suggestions.    I tried to incorporate each of them, including adding some personality at the end 🎉
One thing I wasn't sure of was what you meant exactly by:

adding a 3rd paragrah that introduces HOW the Boost your demo presentation on 4/16 call (leaving that fact for the end of the blog under Learn More is not efficient)....

I thought maybe you meant to link the demo video inline, which is what I did.
Would be happy to make other suggestions.
Thank you for reviewing !
Scott

I threw in my quick links to Twitter, GitHub , LinkedIn... if there's a better way to do this to fit in, like putting it on the Eclipse profile, I don't mind changing...just wanted to have something out there.  Thx again.

@scottkurz Boost blog is published, fantastic adjustments!
MP twitted too :)
Please push it via your channels 👍
If you feel like you want to do 2 things extra, not requirement per say yet still nice to add:

add a Post Header Imagine by maybe just taking a screen shot of your choosing from the demo. I am lazy, so I would do that if I were you. Easy, effective and exactly the point of the blog.

add your pic as the author

own your ticket by closing it! just fun

Thx @aeiras for the review, the publishing, and the other suggestions (of adding a pic and a Post Header image).
Sorry to have to ask, but how would I go about doing that?
Would I click the duplicate this link, to create a new draft, and then submit it for review?   (Assuming you have a way to publish over the original).
If it's not too much work for you, I'd give it a try.
Thanks

Happy Monday Scott @scottkurz,
As the author of the blog, you can adjut it as you see fit without having to duplicate. Once that is done, you can tell us via this issue and we can "refresh" the blog with the updates.


Fix byte-compile warning

cargo-mode.el:289:1:Warning: the function ‘string-trim-left’ is not known to be defined.

@syohex  thank you!


Duplicate source tree for build

Hi guys,
What do you think of adding an option in SConstruct to get it to make a copy of source files in the build folder before compiling?
As per this: http://www.scons.org/doc/2.1.0/HTML/scons-user/c3356.html
The issue I've been having is that I have one source tree on my (OSX) laptop, and both OSX and a Ubuntu VM accessing the same source tree. I can't run compiles on both at the same time as the .os files start conflicting with each other.
I'm happy to look at the changes myself - I'm thinking it would be off by default.

I guess you'd prefer that to just having 2 versions of the git repo around? Seems like you might want to be on different branches as well, no? You could have them each as a remote to the other to pull changes between the two easily.
But if you prefer this, I don't mind, as long as it defaults off

I'd generally only be working on one feature at once, just testing that it compiles and tests work on both OSs. I'd rather not be adding and committing to git every time I want to test a compile.

Cool - if that works then by all means go ahead...

Cool - will do. Cheers

Closing as stale. If anyone wants to take this on then please feel free to open a PR, but it's not something I feel the need for...


why openssl use ecb mode for CTR-Drbg?

Hi,
I am reading the DRBG code and I found drbg use ecb mode  for CTR-DRBG, why didn't use CTR mode or CBC mode for this?
https://github.com/openssl/openssl/blob/a47dd08d6cacc64536c2f57e0f0aee03dcfaab3d/crypto/rand/drbg_ctr.c#L429

Google Sp800-90

Closing since this has been answered.


[Feat]: Hover effects on the whole pages

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

Adding the hover effects to all these sections
Use Case
The features enhances the UI of the website
Benefits
Transitional effects
Priority
High
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[X] I'm a Hacktoberfest contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

Please assign this to me i can work on it I'm a GSSoC contributor


Update dependency @angular-devkit/build-angular to ~0.1102.0

This PR contains the following updates:

Package
Type
Update
Change

@angular-devkit/build-angular
devDependencies
minor
~0.1100.2 -> ~0.1102.0

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: samples/LiveChat/ClientApp/package-lock.json
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm notice
npm notice New patch version of npm available! 8.5.0 -> 8.5.1
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.1>
npm notice Run `npm install -g<EMAIL_ADDRESS>to update!
npm notice
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler-cli
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| ^11.2.0-next" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR!


Fix #7

Vim will only conceal things outside of a block context by default. To
change this I added the rule containedin=ALL so Vim replaces all
matches. This is pretty elegant because it's a more general solution to
the PHP issue a while back.

Great job :+1:


"Clear" button to be positioned at the left side of the bar

The current state of the top bar is:
URL bar clear button tabs menu
I think it's fair to think that some people may have an issue with the clear button being located at the right side of the bar, just near the tabs an issue because a misclick can screw all the open tabs without any warning. Including a warning message can be annoying for wanted clear clicks and the URL bar is huge so it's easier to press (I always press the middle of the bar, never the right side).
The only problem I see with this design is that the clear button is less accessible for one right hand usage of the phone but it can be very easily fixed by giving us the option to move the bar to the bottom of the screen as Firefox does (which I find very comfortable to use btw)

Eh. Pass. It's not possible to accidentally clear all your open tabs without warning, because, there is a confirmation box when you press that button, and that's fine.
If you move it elsewhere and remove that confirmation box, then it becomes easy to genuinely just wipe everything by accident. You can already clear without confirmation by setting it to automatically clear tabs and data on app exit. Then all you have to do is swipe away the app on app switcher whenever you're done, and you never really need to use the fire button.

You are right, sorry idk why I forgot about the confirmation box lol

Thanks for reaching us. We are currently only accepting Github Issues for bug reports. Additionally, as commented above, we already show a confirmation dialog to avoid clearing data if the user presses the fire button by mistake.
Please, use discussions to share feature requests. Only bug reports are expected to be accepted as issues. Thanks.
Contributing guidelines


ModuleNotFoundError: No module named 'isegm.inference.predictors'

hello,i try to run "demo.py",but hits the problem,how i resolve it?

Hi please check in the v1.0 branch and try again. The other branches are still in progress and may have bugs.


hostsfile: Copy the SELinux context to the temp file before overwrite

On SELinux-enabled systems, /etc/hosts has a different type net_conf_t than the other files in /etc, so the temporary file that overwrites it ends up with the wrong context, resulting in many system services becoming unable to access the file. To fix this, manually look up the context /etc/hosts has and copy it to the temporary file before the rename.
In order to avoid depending on libselinux on systems that don't use it, this support is gated behind the new "selinux" feature. It is installed and enabled in the Dockerfile, however, in order to ensure that it still builds.

hmm the CI failures seem unrelated?
[#] docker start 2bc1b0ae0db1e203e180da06a86cd383b8b76472feeead435e2cc35f216f8023
2bc1b0ae0db1e203e180da06a86cd3[83](https://github.com/tonarino/innernet/actions/runs/5361835266/jobs/9728189885?pr=273#step:4:84)b8b76472feeead435e2cc35f216f8023
 DEBUG wireguard_control::backends::kernel > get_by_name: got 1 response message(s) from netlink request
 DEBUG wireguard_control::backends::kernel > get_by_name: parsed wireguard device evilcorp with 1 peer(s)
- Creating a new CIDR from first peer.
[#] docker exec 2bc1b0ae0db1e203e180da06a[86](https://github.com/tonarino/innernet/actions/runs/5361835266/jobs/9728189885?pr=273#step:4:87)cd383b8b76472feeead435e2cc35f216f8023 innernet add-cidr evilcorp --name robots --cidr <IP_ADDRESS>/24 --parent evilcorp --yes
Error: No such container: 2bc1b0ae0db1e203e180da06a86cd383b8b76472feeead435e2cc35f216f8023

but I don't think I have perms to retry.

but I don't think I have perms to retry.

Just retried them, let's see.

Do you think it's worth the hassle to do this context copying compared to, say, only allowing overwriting /etc/hosts in-place if SELinux is detected?

IMO yes: SELinux-enabled is the default on a lot of systems, namely the RHEL variants & Fedora. Losing atomic updates on those systems in favor of potentially wiping the hosts file (learned the importance of atomic file updates the hard way before :upside_down_face:) would be pretty unfortunate :sweat_smile: .

whoops looks like this fell off my radar, all comments should be fixed now.

Clippy failure seems unrelated:
error: accessing first element with `responses.get(0)`
Error:   --> netlink-request/src/lib.rs:64:19
   |
64 |             match responses.get(0) {
   |                   ^^^^^^^^^^^^^^^^ help: try: `responses.first()`

@refi64 I'll take care of the clippy issues in main and then we can rebase this on top of those changes.

@refi64 done, if you rebase on main the clippy step should now pass.

@bschwind just rebased :crossed_fingers:

This is looking good, but one late request @refi64: could you please document the new feature (flag) in README.md? Also stating that it is currently disabled by default.

Since @refi64 hasn't responded, and I'd really like to see this merged (I use the code, works fine for me) I've added the docemntation; I'm including it here as a patch...
From 831d19d907e004e89dde797d9191b07700c78d77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=BCrgen=20Botz?=<EMAIL_ADDRESS>Date: Sun, 28 Apr 2024 17:02:13 +0200
Subject: [PATCH] Add info about selinux feature to README.md

---
 README.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/README.md b/README.md
index b6ee618..592afc1 100644
--- a/README.md
+++ b/README.md
@@ -232,6 +232,14 @@ Note that you'll be responsible for updating manually.
 - `libclang` (see more info at [https://crates.io/crates/clang-sys](https://crates.io/crates/clang-sys))
 - `libsqlite3`

+### Cargo build feature for SELinux
+
+If your target system uses SELinux, you will want to enable the
+'selinux' feature when building the innernet binary. This will ensure
+that innernet maintains the correct selinux context on the /etc/hosts
+file when adding hosts.  To do so add ```--features selinux``` to the
+```cargo build``` options.
+
 Build:

 ```sh
--
2.44.0

Thanks, @jebotz! Thankfully @refi64 has allowed (perhaps by default) project maintainers to push to fork branches which back a PR on the main repo, so I was able to update it and incorporate your change. I'll try to get this merged once I fix the CI errors.

oops sorry it looks like I completely missed the last comment :sweat_smile: thanks for pushing that update!

So, how about someone merge this?


create a kubernetes specific CNCI

create a CNCI optimized for kubernetes with load balancing and automatic routing between pod subnets.
Depends on #708

each image should contain a script to parse json config for k8s from cloud init

we changed our k8s strategy, so this is no longer relevant.


File size seems bigger than packr

Hello,
We chatted a little on Reddit. I wanted to use what you had so far and see how much smaller is the output.
I have a project called Dozzle. I compared the output with what I currently have with packr and the binary is actually bigger.
See below:

I have pushed my branch to broccoli.  Not sure what I am doing wrong. You can run yarn build to get a static folder that is the source.

It seems you didn't remove packr from binary dependencies. Try to fully rewrite your logic for broccoli. Actually I already tried some, take a look:

@demget I don't think I need to remove packr. My screenshot shows two files. assets.gen.go is generated by broccoli using go generate. It is embedding all files in ./static. The other file a_main-packr.go is generated using packr -d.
There are no binary dependencies. It's purely the assets being compiled to a go file. assets.gen.go should be smaller than a_main-packr.go.

After looking at the generated file, I believe Broccoli has a bug. Packr generates a string for each asset. For example, my favicon looks like the following in packr.
"\"H4sIAAAAAAAA/+x9eXhbxdX3kZdYlq3FsmJbul60WLEWJ17ifZO8SnECCQlxEuOQxQmBsHdjKYGQhkBZC4EkrC1taWkLBUpLoBTK0lKWFmhL2VPCEiCNXimhvM/TP97n6/fcTbq6d67uKssW+iWylrkz5/xmzpw5M3NHAtBAIZhM+LMWziwEmAAAu518f78W4OlCgGCQfO+pADjDALBzJ/V+GcCN9QBHjpDvVxwHeOwCAA8AmPBygPycgAagvIR84K/xx8DAQNIj0NMNgZ4eCPT2wkBfHwz0449+COCvB/...

However, in Broccoli, the generated file looks like...
[]byte("\xab\vY\t\r\xff\x83\x02\x01\x02\xff\x84\x00\x01\xff\x82\x00\x00=\xff\x81\x03\x01\x02\xff\x82\x00\x01\x05\x01\x04Data\x01\n\x00\x01\x05Fpath\x01\f\x00\x01\x05Fname\x01\f\x00\x01\x05Fsize\x01\x04\x00\x01\x05Ftime\x01\x04\x00\x00\x00\xfd\x02\xb1\xc8\xff\x84\x00\a\x02\x06static\x01\x06static\x01\xfe\x02\x00\x01\xfc\xbd1\x1e\xf1\x00\x01\xfe\x1a\xcc[\x05aQ¶\xa5ԃ\xf3@\x10\xed\xd2+\x8cH\xb6YG\x81\xa2\xaa^\x12\xb81\x04\xfd\xa7Ye\x882\xe2\xc6\xc0`\t\xa1\x8aZk4\xda$\x06ѥ\xaa\xa3-\xe2I\xde\xefHO\xb0\xc4&:\xd3Zcok\x8b\xb3\xef\xab^\xd9....

I am not sure what is going on but seems like Broccoli escapes the bytes.
Packr doesn't enable compression by default. You need to do packr -d.

@amir20 I'm wondering why do you care about the size of generated file? Broccoli's binary is still smaller than packr's one. We did some benchmarks, with packr -z compressed flag as well.

You may be right. After removing everything I have
.rwxr-xr-x   12Mi amirraminfar primarygroup 16 Apr 12:24   -N dozzle_broccoli
.rwxr-xr-x   13Mi amirraminfar primarygroup 16 Apr 12:25   -N dozzle_packr

But only 1MB different. However, it did take an additional 15 seconds for broccoli to process the files. Closing for now!
There might be an opportunity to save more by figuring out why the output of packr is smaller.


MODIS support

Resolves #2

Added the MODIS masking function
Added a new MODIS collection item

this branch does not address the collections.json file in #2  yet.


aligned_frames problem  between Color image and Depth image

Required Info

Camera Model
D435

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Language
{C/C#/labview/nodejs/opencv/pcl/python/unity }

Segment
{Robot/Smartphone/VR/AR/others }

Issue Description
color and depth frames are aligned but when i moved  object a bit faster then  they will not be aligned any more and specific points on color image will not be at the same pose in the depth image.
i appreciate your help

@RZz9 Could you please provide below information?

Firmware version
librealsense/SDK version
Operation system(Linux/Windows or anything else?)
What's the resolution and FPS setting for color and depth?

im working with python in windows.
using high resolution and (also i checked with 640*480) with 30 FPS.
pyrealsense2                       <IP_ADDRESS>1
firmware : <IP_ADDRESS>

@RZz96  The librealsense version you used is an old version. Please have a try with latest release such as v2.18.0 or v2.18.1 which supposed to fix this issue. Also please test with the Release build instead of Debug build.

@RZz96 One more question - are you using align-depth2color.py for the testing?

Thank you for the reply i upgraded the lib and still same problem
To align : yes im using depth2color

@RZz96 Now I also noticed the issue you mentioned for align-depth2color.py example. Then I tried rs-align in examples/align and found it's better. Could you please have a try with rs-align to see if it meets your expectation? For the issue of python example, will look into it further and update you later.

@RZz96 Now I also noticed the issue you mentioned for align-depth2color.py example. Then I tried rs-align in examples/align and found it's better. Could you please have a try with rs-align to see if it meets your expectation? For the issue of python example, will look into it further and update you

example

i already uisng rs-align


Bioconda Pacakge - Allow Python <3.6

Would it be possible to modify the bioconda package to allow for python versions <3.6? I've got a few pipelines that are stuck on 3.5, so I have to manually install mob_suite instead of just grabbing everything from conda the way I'd like to.
I've attached a version of the meta.yaml (as meta.yaml.txt, since apparently github won't allow .yaml file to be attached to issues) that would allow for python >= 3.4 to work, instead of only python >=3.6.
Thanks!
meta.yaml.txt

Hello, Andrew,
Yes, it is not a problem at all. MOB-Suite works with any python3 version. Sorry for this oversight. Will downgrade to python 3.4 and release a new package build in a couple of days. Thanks for reaching to us. We are always glad to help.
Kirill

Perfect, thanks!

Hi, Andrew. I've finally updated recipe on the bioconda repository as per your request. The build number is 1. The version number did not change and is still 1.4.9. In a couple of hours the bioconda should update repository with the new code version. Best wishes in your work!

If no-arch installation does not work from the bioconda repository. Try our personal repository by running. Thanks!
conda install -c kbessonov mob_suite


Added test_env class for more thorough testing of menu_launcher. Test…

…ed with some additional tests in menu_launcher.

[Current coverage][cc-pull] is 61.47%

Merging [#34][cc-pull] into [master][cc-base-branch] will decrease coverage by 16.37%

@@             master        #34   diff @@
==========================================
  Files            21         22     +1
  Lines          1991       1835   -156
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1550       1128   -422
- Misses          441        707   +266
  Partials          0          0

Powered by Codecov. Last updated by [94736b4...c46db13][cc-compare]
[cc-base-branch]: https://codecov.io/gh/CyberReboot/vent/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/CyberReboot/vent/compare/94736b4e5103b9b4276e1d6194329213bc01d396...c46db13b733b067eab0de6e002234972a4ff2890?src=pr
[cc-pull]: https://codecov.io/gh/CyberReboot/vent/pull/34?src=pr


Hugo 0.125.3 and .4

Is there anything I can do to help accelerate the release of 0.125.3 and .4? Thanks

Done, thanks @jakejarvis


PostCSS and autoprefixer plugin

Research and consider adding https://github.com/postcss/postcss-loader and https://github.com/postcss/autoprefixer

This would allow us to stop writing vendor prefixes in the few places we do and catch up with all necessary vendor prefixes in the potentially more cases that we don't.


In 3d Cube animation last slide image or first slide image dublicates.

In saphari when i go back from first slider to last slider with sliding left to right first image shows up instead of last image.
In other browsers there is not such a problem.
Here is the sample for the problem.
http://www.galepress.com/banners/service_view/683

i can second this
http://danian.website/photography/

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Stream disconnecting after 20-30 seconds

Stream is connecting fine on the same system (I am creating room in one chrome tab and joining in incognito tab). But when use different machine stream disconnect after 20-30 seconds.
Please let me know if you need any other information.

You probably need a TURN-Server like Coturn.

@Patrick-Vogt  I am using https://github.com/muaz-khan/RTCMultiConnection-Server

@vikaskumar-sourcemash  my frend if you need use rtc without problem you have to use ice server otherwise you cannot get performance.

Read about TURN for example here https://doc-kurento.readthedocs.io/en/6.11.0/user/faq.html
And here you can read about the installation coTURN server
https://www.webrtc-experiment.com/docs/TURN-server-installation-guide.html#coturn

I am facing similar problem, like connection working fine upto 7 or 8 users on differenct machines, then after increasing users, connections loses randomly. I am using coturn for relay and using only audio conferencing in rtcmulticonnection.

@adilfaiz001 the mojor problem is not related to rtc all problem realted to ice server if you bypass the peer to peer connection with ice server there will be no problem :)

@rtarta likewise I am having perfect connection for 7 to 8 users and stable connection, like audio conference for more than 40 minutes, but as soon as more than 10 users connected, room become unstable and connection start losing up like randomly, same problem exits in audio conference demo of mauz khan experiments. Can you tell me further about turn setup, I had have set this up but want to know configuration about it like how to perfectly setup this for about 25 users and if its necessary to buy paid turn providers, i can do that do.

@rtarta I am looking forward to implement icerestart in this rtcmulticonnection too, will it help to further stablizing connection on ice failed or closed. I have to make it for 20 users for production.

@adilfaiz001  my friend just need to make your network comunication stable with each connection so you need to use stable ice server, i recoment you to use twillo ice server this is working perectly and balancing client region connection. this is also paid service. just try it is startup is free 15 USD


Improve UI

@Mayank2808sharma  would like to add these features inside of some hoverable cards so that they have a border and look better in the light mode also
please assign this issue to me

@Mayank2808sharma could you tell the procedure and commands to set this up locally

@kairveeehh
First, install the packages using npm install
Then use npm run dev to run it on your local host

@kairveeehh First, install the packages using npm install Then use npm run dev to run it on your local host

ok thankyou :)

@Mayank2808sharm I have create PR's for both the issues taken by me and they are vercel-bot verified ,
please merge them

Hey @Mayank2808sharma I am very excited in contributing to this project under GSSOC'24. Can you please assign this to me


Add parameters to leverage module

Summary
Some initial governance parameters should be added to the umee/x/leverage keeper to support borrowing, and future interest rate calculations and liquidation checks.
These parameters do not include values that come from price oracles.
They should roughly cover:

Token whitelisting
Required overcollateralization levels (set for each token)
Base interest rate (set for each token; real interest rates are likely base+dynamic based on supply/demand later)

(Question: Is base interest rate per-token or global? Assumed to be per-token in the table below.)
Proposal
The leverage keeper should store the following values per whitelisted base asset type.

Value
Example
Used By
Updated When

name
uatom
all
On initial whitelist

uToken
u/uatom
all
On initial whitelist

uToken exchange rate
1.112 uatom = 1 u/uatom
Lend, Withdraw, Borrow, Repay
On initial whitelist (=1), EndBlock (increase only)

collateral weight
0.67 actual u/uatom value counts towards borrow limit
Borrow (determine borrowing limit), EndBlock (check if liquidate)
On initial whitelist, on governance action

base borrowing interest rate
uatom borrow interest rate is 10% annually plus a dynamic amount based on demand
EndBlock (calculate borrow interest)
On initial whitelist, on governance action

Note: the first two parameters - token denom and associated uToken denom - already exist in the keeper because of lending feature.
Also, we might consider ways to store and interpret these parameters as integers to avoid floating point shenanigans (e.g. nondeterministic math at least significant bit based on CPU type)

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

(Question: Is base interest rate per-token or global? Assumed to be per-token in the table below.)

Per token.


Call onBlur only when selector is open

Currently we're calling onBlur for every click on a page even when the selector isn't open. This can be bad for cases where we track whether a user closed a selector without choosing anything.
I tried running the tests and add my own but I'm getting an error on npm install See below.
14 errors generated.
make: *** [Release/obj.target/contextify/src/contextify.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/alurim/.nvm/versions/node/v4.2.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 15.0.0
gyp ERR! command "/Users/alurim/.nvm/versions/node/v4.2.1/bin/node" "/Users/alurim/.nvm/versions/node/v4.2.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/alurim/Code/react-selectize/node_modules/jsdom/node_modules/contextify
gyp ERR! node -v v4.2.1
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
npm ERR! Darwin 15.0.0
npm ERR! argv "/Users/alurim/.nvm/versions/node/v4.2.1/bin/node" "/Users/alurim/.nvm/versions/node/v4.2.1/bin/npm" "install"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the contextify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls contextify
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/alurim/Code/react-selectize/npm-debug.log

The error most likely has something to do with node version 4 (the unit tests probably fail on node 4.x)

Published v0.3.7 with the changes, Thanks @alurim

thanks @furqanZafar :v:


Update Config to use importlib for defaults

Hello team,
I've recenlty been trying to learn more about zipapps,
and so I bundled up one of my personal projects to test things out. My project uses
praw, and I kept running into configuration errors. I initially thought the problem
was that my praw.ini couldn't be found due to file indirection or security limits with
zipapp.
However, after setting some breakpoints and digging through the praw.config.Config
source, I realized that Config is looking for the default praw.ini on the filesystem
relative to the module source file. While this works on standard installs, in a zipapp,
the source files don't actually exist on disk. The default praw.ini isn't found, and
praw.config._config_boolean() errors out trying to call .lower() on _NotSet.
As of Python 3.7, the recommended way to handle "package data" like the default
praw.ini file is through the use of importlib.
This PR restructures praw.config.Config._load_config() a bit to use importlib and
still handle the rest of the config composition logic.
For an minimal reproducable example, the following bash script will create a minimal
zipapp, first installing praw from PyPi, and then installing from source (assuming
that this version of the code is checked out).
#!/usr/bin/bash
mkdir -p ./build

# Create basic app that uses praw
# Requires user to have a praw.ini that defines "testapp"
cat << EOF > __main__.py
import praw
rdt = praw.Reddit("testapp")
rdt.user.me()
print("Success!")
EOF

# Build zipapp with current version of praw
rm -rf ./build/*
cp __main__.py ./build/
python3 -m pip install --target build praw==7.8.1
python3 -m zipapp --output before.pyz build

# Build zipapp with patched version of praw
# This assumes you're running from a directory adjcent to praw source dir
rm -rf ./build/*
cp __main__.py ./build/
python3 -m pip install --target build ../praw
python3 -m zipapp --output after.pyz build

printf '\n\n\n\n'
echo "====================================================================================="
echo "Running zipapp with current version of praw - will fail ============================="
echo "====================================================================================="
python3 before.pyz

echo "====================================================================================="
echo "Running zipapp with patched version of praw - will succeed =========================="
echo "====================================================================================="
python3 after.pyz

This is great! Thank you for the contribution.


firebase_crashlytics errors not arriving at firebase

I am using the firebase_crashlytics lib in my Flutter app.
I am sending error reports, but only about 1 in 100 arrive.....and I can not discern the difference between the ones that arrive, and the ones that don't.
All the code pertaining to crashlytics is as follows....
static void asrt(bool condition)
{
    if (condition)
        return;

    Crashlytics.instance.enableInDevMode = true;
    StringBuffer sb = StringBuffer();

    for (var logLine in _getInstance()._logTailBuffer)
        sb.writeln(logLine);

    try {
        throw 0;
    }
    catch (error , stacktrace) {
        String tempIdentifier =  stacktrace.toString().substring(0,160);
        Crashlytics.instance.log(sb.toString());
        Crashlytics.instance.recordError(niceIdentifier , stacktrace);
    }
}

flutter logs shows the following lines when a report is sent..
I/flutter ( 8060): Error caught by Crashlytics plugin <recordError>:
I/flutter ( 8060): firebase_crashlytics: Error reported to Crashlytics.

In the firebase crashlytics console section change the event type to non-fatal as by default event type is crashes. In flutter app won't crash and just it just though error.

Hi @safield
Looks like duplicate of https://github.com/FirebaseExtended/flutterfire/issues/2644
Are you experiencing same issue?
Thank you

The issue was caused by a funny series of events. I just learned that the error report is not sent until the application is opened a second time after the crash. What was happening is that I would launch the app and trigger a crash, then observe that no crash report arrived. I would then try changing some code to see if I could change the results. This would result in a new apk being installed, and so the pending crash report was never sent.
I guess I was reliably always installing a new apk after each crash.
It would be nice if  it was sent immediately (like sentry does).


egui file tree / active file binding is broken

causes:

delete, deletes the open thing in workspace instead of the selected

#2413


[ITensors] [ENHANCMENT] Define inner(::ITensor, ::ITensor) and related

Define inner(x, y) = (dag(x) * y)[] and inner(x, A, y) = (dag(x)' * A * y)[].

Codecov Report

Merging #835 (60f5916) into main (9dd147f) will decrease coverage by 2.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
- Coverage   75.97%   72.98%   -3.00%
==========================================
  Files          67       67
  Lines        7546     6288    -1258
==========================================
- Hits         5733     4589    -1144
+ Misses       1813     1699     -114

Impacted Files
Coverage Δ

src/itensor.jl
84.12% <100.00%> (-1.56%)
:arrow_down:

src/broadcast.jl
60.16% <0.00%> (-26.73%)
:arrow_down:

src/qn/qnindexset.jl
86.66% <0.00%> (-13.34%)
:arrow_down:

src/physics/site_types/tj.jl
65.82% <0.00%> (-8.98%)
:arrow_down:

src/indexset.jl
76.95% <0.00%> (-7.21%)
:arrow_down:

src/lastval.jl
57.14% <0.00%> (-7.15%)
:arrow_down:

src/physics/sitetype.jl
86.89% <0.00%> (-6.60%)
:arrow_down:

src/global_variables.jl
85.29% <0.00%> (-5.82%)
:arrow_down:

src/LazyApply/LazyApply.jl
61.53% <0.00%> (-5.64%)
:arrow_down:

src/ITensors.jl
25.00% <0.00%> (-5.00%)
:arrow_down:

... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd147f...60f5916. Read the comment docs.


Reduce ram requirement

Hi, I'm very interested in your work of 3D human pose estimation. Just try to run your source, but my ram is not enough. Can you show me how to change/reduce the ram requirement to run this source.
I though 32G ram is used to load db.mat(~13G) into memory, then could you share a smaller normalized dataset.
Looking forward to hearing from you.
Best,
-Thanh

Hello Hetpin,
Actually, you can yourself reduce the size of the database. If you load db.mat, you will find 3D poses and their corresponding 2D projections. You can select a lesser number of 3D poses, and only keep the required projections.
Hope that helps!
Umar