Use query params instead of fragments for callback

Feature request
Is your feature request related to a problem? Please describe.
Using a Go backend (with supabase-go), I can't access the # fragment that holds the access token on successful authentication. The server can't access the fragment.
Describe the solution you'd like
Change the callback function back* to using query params, or allow the client to select which they'd like (likely unnecessary)
* This seems like this was changed in #16, could be worth reverting again.
Describe alternatives you've considered
There are no possible alternatives in my case, as I want to use little to no JavaScript for my authentication (and use cookies, etc)
Additional context
N/A

Hey @jackmerrill,
We originally switched to params but realised that it might not be as secure as # because params are sent to the server and can be modified in transit so we switched it back
We're looking into a stable and secure server side auth flow and will keep you posted this issue once out.
Thanks!

Hey @jackmerrill,
We originally switched to params but realised that it might not be as secure as # because params are sent to the server and can be modified in transit so we switched it back
We're looking into a stable and secure server side auth flow and will keep you posted this issue once out.
Thanks!

Yeah, I saw #279, hoping it gets fixed soon! Thanks though!

I think we can solve this by using the exact mechanism as webhooks; we verify the header with a signature and a key.
It would be very convenient not to send any unnecessary JavaScript to the client, even for JavaScript fullstack apps (like Remix).


fix: iOS crash occurring when navigating to a new app screen with a displaying modal

Summary:
Our app is using the react-native v0.74.2 with the react-navigation lib for screen navigation, we're facing an issue in the built iOS app that when we try to navigate to a new app screen with the react-navigation's reset or replace method and meanwhile there's a react native modal displaying, then the iOS app always crashes.
I saw there is already a relevant PR and discussion targeting this issue, but I still think it would be better if this kind of crash can be suppressed in the framework level, currently I guess it's common in the iOS apps based on react native.
Changelog:
[IOS] [FIXED] - app crash happening when navigate to a new app screen with a displaying modal
Test Plan:
More issue details and the reproduction steps can be found in this PR :)

@mojodna @jsierles @augustl could you help take a review? Thanks.

Anyone can help take a look or provide some insights about if this change is safe or not?

This issue is causing multiple crashes for us in production every day. Would appreciate if a fix like this could be merged. We use reset/replace actions when following deep links. No good way to know if the user has a modal open when we do so.

@mrand15 Glad to hear that it's working for you, I already applied this fix in our production app for a long while, seems that this issue has been resolved and this change didn't introduce other new issues.
@cortinico Could you help take a look please?

@cipolleschi Sorry that our app hasn't started to apply the new React native architecture, so I am not sure if it's suffering from this issue as well, but I took a look at the above RCTModalHostViewComponentView file that you posted, I guess it's no problem, because in this file, the  _shouldPresent variable replaces the _visible variable in the old architecture, and there is already such a process similar to what this fix PR does.

@cipolleschi Could you help take a look again? We're going to upgrade the react native in our project, if this fix makes sense,  then we may don't need the extra patch file for react native.

@zhouzh1 which version are you using? can you create a pick request for the versions that needs the fix?

@cipolleschi - My project has upgraded to react-native:0.73.7 3 months back.
Can I add this line  [self setVisible: NO]; below the code for a temporary fix?
We will upgrade my project to the latest react-native version once the client approves the newest version.

(void)dismissModalViewController
{
if (_isPresented) {
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
_isPresented = NO;

[self setVisible: NO]  // Add this line //
}
}

@cipolleschi  - My project has upgraded to react-native:0.73.7 3 months back.I raised this issue #44612 .
Can I add this line [self setVisible: NO]; below the code for a temporary fix or Can I pick a request to react-native:0.73.7 to fix this issue?
node_modules>react-native>React>Views>RCTModalHostView.m
We will upgrade my project to the latest react-native version once the client approves the newest version.
(void)dismissModalViewController
{
if (_isPresented) {
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
_isPresented = NO;
[self setVisible: NO] // Add this line //
}
}

yeah, 0.73 is still in the support window.
I created the cherry pick request: https://github.com/reactwg/react-native-releases/issues/531
We need the same pick for other versions too, let me create them.

@cipolleschi - Thanks for your update.
https://github.com/reactwg/react-native-releases/issues/531 release fix will resolve my issue #44612 ?

@gkasireddy202 I don't know... I understood you were asking to pick the fix because you tested it and it fixed it... 😅
Can you try to:

add that line in your project
try to trigger the crash
report back whether it worked or not

@cipolleschi - I added that line to my project and tested it. I triggered the crash.
This is the issue that I faced in react-native:0.73.7.
https://github.com/facebook/react-native/issues/44612#issuecomment-2360716821


watchOS framework target

Simulator verification failed." UserInfo=0x7fe68ab30480 {NSLocalizedFailureReason=A connection to the simulator verification service could not be established., NSLocalizedRecoverySuggestion=Ensure that Xcode.app is installed on a volume with ownership enabled., NSLocalizedDescription=Simulator verification failed.}

Is CI supposed to be working?

Not with Swift 2

@JaviSoto Thanks for this!

Thank you!


white screen in iOS device when deploying on staging and production

Is this a bug report?
yes

Have you read the Contributing Guidelines?
yes
Environment

Steps to Reproduce

(Write your steps here:)

launching iOS application from simulator or device in my machine works fine
2.when deploying on staging or production iam getting white screen at launch
iam not getting this issue in android

Expected Behavior

(Write what you thought would happen.)
Actual Behavior
white screen cam not understanding . trying to change appdelegate.m like this :
NSURL *jsCodeLocation;
//#ifdef DEBUG
//  jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle?platform=ios&dev=true"];
jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
//#else
// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
//#endif
//self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
//self.window.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];
//[[RCCManager sharedInstance] initBridgeWithBundleURL:jsCodeLocation launchOptions:launchOptions];
but now i am blocked in splashScreen .
help please
here is my Appdelegate.m:
#import "AppDelegate.h"
#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>
#import "RCCManager.h"
#import <Smooch/Smooch.h>
#import <FBSDKCoreKit/FBSDKCoreKit.h>
#import <React/RCTLinkingManager.h>
#import <React/RCTPushNotificationManager.h>
@implementation AppDelegate

(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
NSURL *jsCodeLocation;
//#ifdef DEBUG
//  jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/index.ios.bundle?platform=ios&dev=true"];
jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
//#else
// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
//#endif
//self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
//self.window.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];
//[[RCCManager sharedInstance] initBridgeWithBundleURL:jsCodeLocation launchOptions:launchOptions];
RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"homefriend"
initialProperties:nil
launchOptions:launchOptions];
rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];
self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
UIViewController *rootViewController = [UIViewController new];
rootViewController.view = rootView;
self.window.rootViewController = rootViewController;
[self.window makeKeyAndVisible];
[Smooch initWithSettings: [SKTSettings settingsWithAppToken:@"xxx"]];
[[FBSDKApplicationDelegate sharedInstance] application:application
didFinishLaunchingWithOptions:launchOptions];
return YES;
}

(void)applicationDidBecomeActive:(UIApplication *)application {
[FBSDKAppEvents activateApp];
}

(BOOL)application:(UIApplication *)application
openURL:(NSURL *)url
sourceApplication:(NSString *)sourceApplication
annotation:(id)annotation {
[[FBSDKApplicationDelegate sharedInstance] application:application
openURL:url
sourceApplication:sourceApplication
annotation:annotation];
[RCTLinkingManager application:application openURL:url
sourceApplication:sourceApplication annotation:annotation];
return YES;
}

// Required to register for notifications

(void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
{
[RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
}
// Required for the register event.
(void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
[RCTPushNotificationManager didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}
// Required for the registrationError event.
(void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
{
[RCTPushNotificationManager didFailToRegisterForRemoteNotificationsWithError:error];
}
// Required for the localNotification event.
(void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification
{
[RCTPushNotificationManager didReceiveLocalNotification:notification];
}

@end

(Write what happened. Add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

I have same problem.

i can build normally my iOS application in simulator or device in debug between deploying in staging or release my application freeze with white screen after passing the splash screen .
id ont have this problem in android .
"": "^3.1.0",
"assert": "^1.4.1",
"babel-preset-react-native-stage-0": "^1.0.1",
"bamlab-react-native-smooch": "^0.3.0",
"base-64": "^0.1.0",
"browserify-zlib": "^0.1.4",
"bytebuffer": "^5.0.1",
"console-browserify": "^1.1.0",
"constants-browserify": "^1.0.0",
"dns.js": "^1.0.1",
"domain-browser": "^1.1.7",
"events": "^1.1.1",
"https-browserify": "0.0.1",
"install": "^0.10.1",
"lodash": "^4.17.4",
"mockdate": "^2.0.2",
"moment": "^2.19.1",
"net": "^1.0.2",
"numeral": "^2.0.4",
"path-browserify": "0.0.0",
"process": "^0.11.10",
"prop-types": "^15.6.0",
"querystring": "^0.2.0",
"querystring-es3": "^0.2.1",
"react": "16.0.0",
"react-native": "0.49.3",
"react-native-crypto": "^2.1.1",
"react-native-datepicker": "^1.6.0",
"react-native-drawer-layout": "^1.3.2",
"react-native-fbsdk": "^0.6.3",
"react-native-fetch-blob": "^0.10.8",
"react-native-form-idable": "^1.0.2",
"react-native-gcm-android": "^0.2.0",
"react-native-google-analytics-bridge": "^5.0.1",
"react-native-http": "github:tradle/react-native-http#834492d",
"react-native-i18n": "^1.0.0",
"react-native-level-fs": "^3.0.0",
"react-native-linear-gradient": "^2.3.0",
"react-native-md5": "^1.0.0",
"react-native-navigation": "^1.1.260",
"react-native-os": "^1.1.0",
"react-native-push-notification": "^3.0.0",
"react-native-randombytes": "^3.0.0",
"react-native-root-siblings": "^1.2.1",
"react-native-root-toast": "^1.3.0",
"react-native-svg": "^5.4.2",
"react-native-swipeout": "^2.2.2",
"react-native-swiper": "^1.5.13",
"react-native-system-notification": "^0.2.1",
"react-native-tcp": "^3.3.0",
"react-native-udp": "^2.2.0",
"react-native-vector-icons": "^4.4.2",
"react-redux": "^5.0.6",
"react-static-container": "^1.0.1",
"readable-stream": "^1.0.33",
"redux": "^3.6.0",
"redux-enhancer-react-native-appstate": "^0.1.1",
"redux-logger": "^2.7.4",
"redux-persist": "^4.4.1",
"redux-saga": "^0.14.3",
"stream-browserify": "^1.0.0",
"superagent": "^3.3.2",
"timers-browserify": "^1.4.2",
"tty-browserify": "0.0.0",
"url": "^0.10.3",
"victory-native": "^0.15.0",
"vm-browserify": "0.0.4"
/**
Copyright (c) 2015-present, Facebook, Inc.
All rights reserved.
This source code is licensed under the BSD-style license found in the
LICENSE file in the root directory of this source tree. An additional grant
of patent rights can be found in the PATENTS file in the same directory.
*/
#import "AppDelegate.h"
#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>
#import <Smooch/Smooch.h>
#import <FBSDKCoreKit/FBSDKCoreKit.h>
#import <React/RCTLinkingManager.h>
#import <React/RCTPushNotificationManager.h>
@implementation AppDelegate
(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
NSURL *jsCodeLocation;
jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"x"
initialProperties:nil
launchOptions:launchOptions];
rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f green:1.0f blue:1.0f alpha:1];
self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
UIViewController *rootViewController = [UIViewController new];
rootViewController.view = rootView;
self.window.rootViewController = rootViewController;
[self.window makeKeyAndVisible];
[Smooch initWithSettings: [SKTSettings settingsWithAppToken:@"x"]];
[[FBSDKApplicationDelegate sharedInstance] application:application
didFinishLaunchingWithOptions:launchOptions];
return YES;
}
(void)applicationDidBecomeActive:(UIApplication *)application {
[FBSDKAppEvents activateApp];
}
(BOOL)application:(UIApplication *)application
openURL:(NSURL *)url
sourceApplication:(NSString *)sourceApplication
annotation:(id)annotation {
[[FBSDKApplicationDelegate sharedInstance] application:application
openURL:url
sourceApplication:sourceApplication
annotation:annotation];
[RCTLinkingManager application:application openURL:url
sourceApplication:sourceApplication annotation:annotation];
return YES;
}
// Required to register for notifications
(void)application:(UIApplication *)application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings
{
[RCTPushNotificationManager didRegisterUserNotificationSettings:notificationSettings];
}
// Required for the register event.
(void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
[RCTPushNotificationManager didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}
// Required for the registrationError event.
(void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
{
[RCTPushNotificationManager didFailToRegisterForRemoteNotificationsWithError:error];
}
// Required for the localNotification event.
(void)application:(UIApplication *)application didReceiveLocalNotification:(UILocalNotification *)notification
{
[RCTPushNotificationManager didReceiveLocalNotification:notification];
}
@EnD
thanks for your help

any help

i am applying the steps described in Facebook documentation :
in the project folder in Terminal run react-native bundle --platfrom ios --dev false --entry-file index.ios.js --bundle-output main.jsbundle Drag the reference to the main.jsbundle file into XCode under myapp folder In XCode, open AppDelegate.m and uncomment jsCodeLocation = [[NSBundle mainBundle]… Open Product > Scheme > Edit Scheme then change Build Configuration to Release Select myapp under the project navigator and then: under TARGETS: myappTests > Build Phases > Link Binary With Libraries press + select Workspace > libReact.a and Add compile in XCode with the ../node_modules/react-native/scripts/react-native-xcode.sh
always having white screen after passing the splash screen when deploying in release . it i really blocking me
thanks for your reply


Linking a policy to organisations

This adds the ability to tag policies to organisations.
The details for the available organisations are loaded from the Content Register. Any organisations associated with an organisation are included in the "links" for the policy.
Lots of duplication in the code for policy areas and policy programmes. An effort needs to be made to refactor these to reduce duplication and unify their behaviour. Suggesting that be done in a separate pull request.
Story: https://trello.com/c/cZ7P1VfR/51-add-ability-to-tag-policies-to-orgs-and-people

Good stuff, just a few questions and quibbles.  Lots of duplication as you say.


Figment bind on a cleric impetus clears upon chunk reload.

Seen on the hexxycraft server. The figment bind seems to work fine while the chunks are force-loaded, but if the force-load is removed then the impetus seems to completely unbind from the figment and requires a new figment bind to function again.

Not sure as to the cause, and with 1.20 changes around the corner I don't know if I will be fixing it.


Issue #7

Vector.ScalarProduct isn't fast enough
That's because it was calculated using cosine rule, now using easier method
Going to be fixed in 1.9.0

Fixed in 1.9.0


Include indigo without render module into ketcher-standalone build process

Background
Indigo implemented additional module without render part. It should be included in ketcher-standalone package.
Solution
Adjust ketcher-standalone build process to include indigo without render. Similar changes was introduced in https://github.com/epam/ketcher/issues/2654 for indigo with separated wasm file.
Provide an ability to load ketcher with indigo without render module, and then load full indigo in background.

Verified.

Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
Windows 10 Pro
Chrome Version 127.0.6533.100 (Official Build) (64-bit)


Version In CompositeEnvironmentRepositorys

Sets the versions when there is only a single EnvironmentRepository in a composite.  Fixes #718.

Codecov Report

Merging #719 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   74.21%   74.27%   +0.06%
==========================================
  Files          71       71
  Lines        2420     2426       +6
  Branches      349      350       +1
==========================================
+ Hits         1796     1802       +6
  Misses        469      469
  Partials      155      155

Impacted Files
Coverage Δ

...er/environment/CompositeEnvironmentRepository.java
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a334873...bb41683. Read the comment docs.

Should this PR be against 1.2.x so we can merge forward?

otherwise LGTM

@spencergibb CompositeEnvironmentRepository does not exist in 1.2.x.


remove dummy cert references to Nginx Proxy Manager

Based on this issue: https://github.com/jc21/nginx-proxy-manager/issues/1024

This is an automated message from CI:
Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1338
Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.


Animation bug

The thumbnail zoom out animation is sometimes applied to multiple images.
Animation bug:
https://user-images.githubusercontent.com/50382414/107398557-069c2300-6b00-11eb-8866-799afcd0449c.mp4

It should be fixed in the next release.


[Feature] Generate a static site and publish in Github Pages

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
We get some feedbacks from users and user feel the project lacks docs on the features and guidances.
Another motivation to have a separate site is for building brand.
I feel we can generate a user facing site to host those docs.
https://squidfunk.github.io/mkdocs-material/ is a very good candidate to publish a static site and it can render README.md directly so we can reuse all our existing docs.
Few things in mind.

docs versioning
site publish in CI
clear navigation
rich plugins like search, github link etc.

Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

This has been done and site is public now. https://ray-project.github.io/kuberay/ We can close the issue


S3 backup not working

Getting below error when creating new index.S3 config works fine.
FileSystem Backup also works fine. Ensured that permission are set up on Bucket as per
https://github.com/Netflix/exhibitor/wiki/Shared-Configuration. Also tried to gave full access to bucket.
Using 1.5.1 of exhibitor
exhibitor-configtype=s3
exhibitor-defaultconfig=/mnt/data/config.exhibitor
exhibitor-s3config=XXXXX:conf.exhibitor
exhibitor-s3configprefix="rec"
exhibitor-s3backup=true
zookeeper-data-directory=/mnt/data/tmp/zookeeper
zookeeper-install-directory=/opt/zookeeper/*
zookeeper-log-directory=/mnt/data/tmp/zookeeper
log-index-directory=/mnt/data/tmp/zookeeper_log_indexes
NFO  com.netflix.exhibitor.core.activity.ActivityLog  Starting index build [ActivityQueue-1]
ERROR com.netflix.exhibitor.core.activity.ActivityLog  Index Build: Getting available backups [ActivityQueue-1]
ERROR com.netflix.exhibitor.core.activity.ActivityLog  Building Index [ActivityQueue-1]
java.lang.IllegalArgumentException: The bucket name parameter must be specified when listing objects in a bucket
at com.amazonaws.services.s3.AmazonS3Client.assertParameterNotNull(AmazonS3Client.java:2338)
at com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:444)
at com.netflix.exhibitor.core.s3.S3ClientImpl.listObjects(S3ClientImpl.java:140)
at com.netflix.exhibitor.core.backup.s3.S3BackupProvider.getAvailableBackups(S3BackupProvider.java:335)
at com.netflix.exhibitor.core.backup.BackupManager.getAvailableBackups(BackupManager.java:149)
at com.netflix.exhibitor.core.index.IndexProcessor.addBackups(IndexProcessor.java:127)
at com.netflix.exhibitor.core.index.IndexProcessor.process(IndexProcessor.java:55)
at com.netflix.exhibitor.core.index.IndexProcessorActivity.call(IndexProcessorActivity.java:55)
at com.netflix.exhibitor.core.index.IndexProcessorActivity.call(IndexProcessorActivity.java:25)
at com.netflix.exhibitor.core.activity.ActivityQueue$1.run(ActivityQueue.java:126)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)

@swapnilborade I understand this is a very old thread but just curious what parameters do you have setup on the exhibitor UI and which section? I am facing the same issue and the documentation is not really very helpful. Appreciate any help on this.


Popping up boxes when trying to create dashboard?

So I have Home Assistant and Frigate running fine. I am using the 4.0.0 HACS integration for Frigate and so far only have one minor issue. I am trying to setup a dashboard with a card for each Camera in Frigate and it is working but I have one annoying bug I don't know how to stop it or tweak it to prevent it.
Here is the setting for one of my cards:
type: custom:frigate-card
cameras:
  - camera_entity: camera.driveway
    live_provider: webrtc-card
view:
  default: live
  timeout_seconds: 0
  update_seconds: 0

What is happening is when I go to the dashboard and right now I have three cameras of my six configured with each camera in its own card I get flashing pop-ups INSIDE of the card for each camera while the Home Assistant window is active. This image shows the pop-up I am speaking of in the lower right corner. It will come and go over and over again rapidly without stopping and I can't figure out how to stop it.

Any thoughts on how to stop this? Thanks!

First off, this is the wrong repo, you should be posting in the card repo.
Secondly, it is an option under live view settings in the card.

Thirdly, there was a bug in one version of the card that caused this "rapid popup" issue in certain circumstances. This should have been fixed in the latest release: https://github.com/dermotduffy/frigate-hass-card/releases/tag/v5.0.0-beta.1 .
Closing this issue here as it's in the wrong repo -- lets chat in a new issue in the above repo if the issue continues to occur.


PV stuck in terminating state

/kind bug
What happened?
Deleting a pv that is not in use - though the volume is actually deleted, the pv status is in terminating state and says volume not found when described. From the powervs-plugin container logs, it is seen that volume is deleted
% kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS        CLAIM                   STORAGECLASS   VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-4734800e-0af4-479d-ba5f-ff28aa45599f   4Gi        RWO            Delete           Terminating   default/powervs-claim   powervs-sc     <unset>                          99m
pvc-d1b41101-aad5-49ad-bb17-4e7287f4967b   4Gi        RWO            Delete           Terminating   default/powervs-claim   powervs-sc     <unset>                          3h15m

{"description":"deletion of volumeID '<volumeID>' is unknown or not allowed","error":"Bad Request: Volume not found"

I0924 08:17:21.902769       1 controller.go:215] DeleteVolume: called with args: {VolumeId:4080a577-6ece-4d8c-91b8-6d9eba7fc548 Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
GET /pcloud/v1/cloud-instances/08d3459f-41ca-4831-ad33-ce63adee8d1b/volumes/4080a577-6ece-4d8c-91b8-6d9eba7fc548 HTTP/1.1
Host: wdc.power-iaas.cloud.ibm.com
User-Agent: Go-http-client/1.1
Accept: application/json
Authorization: [PRIVATE DATA HIDDEN]
Crn: <crn>
Accept-Encoding: gzip

HTTP/2.0 200 OK

What you expected to happen?
PV shouldn't be listed
How to reproduce it (as minimally and precisely as possible)?
Follow dynamic provisioning in the in READme. And then delete the pod and pvc. PV will be seen in terminating state.
Anything else we need to know?:
Looks like, retry should not be done, once 200 OK response is received, and the same response should be published to the pv.
Environment

Kubernetes version (use kubectl version):
Driver version:

/assign


Pattern for where the crawler is allowed

Making a regex for which URL's to follow. Should be applied to fetched URL's.

Important for the URL crawler


@bushmanov 's GPU issue (crash on OpenCL kernel compile)

Reference: https://github.com/Microsoft/LightGBM/pull/584#issuecomment-306174083 (to declutter the thread)
@bushmanov @guolinke @huanzhang12

Successfully built with this instructions
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 137
[LightGBM] [Info] Number of data: 5211, number of used features: 116
[LightGBM] [Info] Using GPU Device: GeForce GTX 1080 Ti, Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 16 bins...

but crashed at the last line (even though as I said there are no problem with standard build instructions and Python interface). Any suggestions are greatly appreciated!

Does it work on CLI?

When I compare the @guolinke R build to "normal" explicit build via  cmake/make I see that in R build's  lightgbm is missing at the root. When I copy it from another build and execute:
$./lightgbm config=train.conf device=gpu
the command completes successfully:
[LightGBM] [Info] Finished loading parameters
[LightGBM] [Info] Loading weights...
[LightGBM] [Info] Loading weights...
[LightGBM] [Info] Finished loading data in 0.055578 seconds
[LightGBM] [Info] Number of positive: 3716, number of negative: 3284
[LightGBM] [Info] This is the GPU trainer!!
[LightGBM] [Info] Total Bins 6143
[LightGBM] [Info] Number of data: 7000, number of used features: 28
[LightGBM] [Info] Using GPU Device: GeForce GTX 1080 Ti, Vendor: NVIDIA Corporation
[LightGBM] [Info] Compiling OpenCL Kernel with 256 bins...
[LightGBM] [Info] GPU programs have been built
[LightGBM] [Info] Size of histogram bin entry: 12

and so on...

The issue has been resolved after restarting RStudio


Teams installation problem

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9a020c1-2f9f-26e7-5221-25b802bbc570
Version Independent ID: 199e13d2-1b21-0b57-325f-91121b8f104d
Content: Support information for Malaysia - Microsoft 365 admin
Content Source: microsoft-365/admin/support/malaysia.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@aldo-ipo If you're having trouble installing Teams, please see Troubleshoot Microsoft Teams installation and update issues on Windows. If you continue to have problems, please contact a support agent  using Support information for Malaysia


Update BUMP yamls

See https://github.com/JCSDA-internal/mpas-jedi/pull/822 and https://github.com/JCSDA-internal/saber/pull/424.

Working on this. I also need to re-generate the bumpcov files. No changes in the results, but there are changes in the group name convention.

Very minor changes...
R097    config/jedi/applications/3denvar-specific_multivariate.yaml     config/jedi/applications/3denvar-crossed.yaml
M       config/jedi/applications/3denvar.yaml
M       config/jedi/applications/3dhybrid.yaml
M       config/jedi/applications/3dvar.yaml

diff --git a/config/jedi/applications/3denvar-specific_multivariate.yaml b/config/jedi/applications/3denvar-crossed.yaml
similarity index 97%
rename from config/jedi/applications/3denvar-specific_multivariate.yaml
rename to config/jedi/applications/3denvar-crossed.yaml
index 4848d13..270efd6 100644
--- a/config/jedi/applications/3denvar-specific_multivariate.yaml
+++ b/config/jedi/applications/3denvar-crossed.yaml
@@ -55,7 +55,7 @@ cost function:
             data directory: {{bumpLocDir}}
             files prefix: {{bumpLocPrefix}}
           drivers:
-            multivariate strategy: specific_multivariate
+            multivariate strategy: crossed
             read local nicas: true
           model:
             level for 2d variables: last
diff --git a/config/jedi/applications/3denvar.yaml b/config/jedi/applications/3denvar.yaml
index 006a4ac..b9204cb 100644
--- a/config/jedi/applications/3denvar.yaml
+++ b/config/jedi/applications/3denvar.yaml
@@ -55,7 +55,7 @@ cost function:
             data directory: {{bumpLocDir}}
             files prefix: {{bumpLocPrefix}}
           drivers:
-            multivariate strategy: common
+            multivariate strategy: duplicated
             read local nicas: true
           model:
             level for 2d variables: last
diff --git a/config/jedi/applications/3dhybrid.yaml b/config/jedi/applications/3dhybrid.yaml
index 297bd8c..1e5d128 100644
--- a/config/jedi/applications/3dhybrid.yaml
+++ b/config/jedi/applications/3dhybrid.yaml
@@ -58,7 +58,7 @@ cost function:
               data directory: {{bumpCovDir}}
               files prefix: {{bumpCovPrefix}}
             drivers:
-              multivariate strategy: specific_univariate
+              multivariate strategy: univariate
               read local nicas: true
         saber outer blocks:
         - saber block name: StdDev
@@ -103,7 +103,7 @@ cost function:
                 data directory: {{bumpLocDir}}
                 files prefix: {{bumpLocPrefix}}
               drivers:
-                multivariate strategy: common
+                multivariate strategy: duplicated
                 read local nicas: true
               model:
                 level for 2d variables: last
diff --git a/config/jedi/applications/3dvar.yaml b/config/jedi/applications/3dvar.yaml
index f07f237..f9a0cb7 100644
--- a/config/jedi/applications/3dvar.yaml
+++ b/config/jedi/applications/3dvar.yaml
@@ -41,7 +41,7 @@ cost function:
           data directory: {{bumpCovDir}}
           files prefix: {{bumpCovPrefix}}
         drivers:
-          multivariate strategy: specific_univariate
+          multivariate strategy: univariate
           read local nicas: true
     saber outer blocks:
     - saber block name: StdDev

@byoung-joo, do you plan to submit a PR?  That would be helpful.  Let me know if you need permissions that you don't have.

@jjguerrette, actually I was wondering about that... because the mpas-bundle builds (both single and double precision) are usually prepared by you. I don't know what the best way proceed.
If you are planning to update the mpas-bundle build in MPAS-Workflow near future, I can include these changes there, which is simpler for me.
If this PR is a separate one, I need to build mpas-bundle myself and update the build directories, staticB locations, and bump-related yamls. FYI, I don't plan to do a cycling exp. with these yet.
Do you have any suggestion ?

Do you have a build already from running the tests?  We do not have to use a date-marked build.  Now that all PRs are merged, you could simply create the build the same way you normally would from develop branches.  As long as the build is located in work instead of scratch, that's fine.  Single-precision builds are created by setting MPAS_DOUBLE_PRECISION to "OFF" in the bundle CMakeLists.txt.

In the long run, we would like the build to be generated by the workflow.  In that case, we would want to store a CMakeLists.txt with tags in the workflow.  That will eliminate this housekeeping step.

That makes sense. I will open a PR soon.


Doxygen improvements to bilinearform

This is a small PR to add some improvements to the doxygen for bilinearform.hpp.

@mlstowell as another person putting effort into the doxygen quality, do you want to buddy up and review each other's documentation work?  I plan to do a few of these little updates whenever I get a little time and they should be pretty straightforward to review.

xref https://github.com/mfem/mfem/pull/3688/ here, because I think it has it has gone under a bit

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

I left some suggestions and comments since I am not sure about some points here.
I think the there is a problem on the docs for some functions, where internal details are documented rather than the actual functionality. But fixing this is rather future work than for this PR.

Thanks for reviewing this.  I liked all of your suggestions and pulled them in.  I'll merge master into it soon, and am hoping to get this pull request resolved soon.

Hi @termi-official, since #3688 is merged, could you take a quick look at this PR? Thanks!

How about adding the following small documentation correction to this PR while we're at it:
diff --git a/fem/lininteg.hpp b/fem/lininteg.hpp
index 02fde00c9..c9b6e6dba 100644
--- a/fem/lininteg.hpp
+++ b/fem/lininteg.hpp
@@ -317,7 +317,7 @@ public:
 };

 /** Class for boundary integration of L(v) := (g, v), where
-    f=(f1,...,fn) and v=(v1,...,vn). */
+    g=(g1,...,gn) and v=(v1,...,vn). */
 class VectorBoundaryLFIntegrator : public LinearFormIntegrator
 {
 private:

How about adding the following small documentation correction to this PR while we're at it:
diff --git a/fem/lininteg.hpp b/fem/lininteg.hpp
index 02fde00c9..c9b6e6dba 100644
--- a/fem/lininteg.hpp
+++ b/fem/lininteg.hpp
@@ -317,7 +317,7 @@ public:
 };

 /** Class for boundary integration of L(v) := (g, v), where
-    f=(f1,...,fn) and v=(v1,...,vn). */
+    g=(g1,...,gn) and v=(v1,...,vn). */
 class VectorBoundaryLFIntegrator : public LinearFormIntegrator
 {
 private:

Good catch I swept that change into this PR.

LGTM

Thanks for putting the time in to review and improve this PR.

@tzanio I believe this is ready to go into next.

Thanks!

Merged in next for testing...


Institution and Ministry Edit Institution details

Additional Context
Based on the outcome of #331
Review page layout
Acceptance Criteria
A ministry user can edit all institution details

[x] A ministry user can click "edit" on the "ministry views institution profile" page
[x] On click of edit display the institutionprofile form in editable format

Remove fields
[x] Remove Legal Authorized authority from institution details and institution creation forms as its now a role (institutionprofilecreation & institutionprofile)
[x] Clean up DB and API

An institution user edits institution information
NOTE: The following apply to edit only, initial setup remains as-is (FirstName & LastName & Institution Information readonly and remaning need to be completed by institution)

[x] Institution Details - An institution cannot edit the following fields
Legal Operating Name
Operating Name
Institution Type
Institution Regulatory Body
Established Date
Primary Email
Primary Phone Number
Institution Website
[x] Institution Details - An institution can edit the following fields
Primary Contact - Name
Primary Contact - Email
Primary Contact - Phone
Mailing Address (all fields)

Approved.


NoMethodError for mysql_service when converging

:ghost: Brief Description
I try to use the mysql_service method and get a NoMethodError.
This started happening from version 16.2 of chef infra client
and was fine up to version 16.1.
It's possibly related to this breaking change in chef infra client
https://docs.chef.io/release_notes/#whats-new-in-162
:pancakes: Cookbook version
8.5.1
:woman_cook:  Chef-Infra Version
16.2.44
:tophat: Platform details
ubuntu-1604
Steps To Reproduce
Steps to reproduce the behavior:
In .kitchen.yml
driver:
 name: docker
 memory:<PHONE_NUMBER>
 privileged: true
 use_sudo: false

provisioner:
 name: chef_zero
 always_update_cookbooks: true
 client_rb:
  chef_license: accept

verifier:
 name: inspec

platforms:
 - name: ubuntu-16.04
   driver_config:
     run_command: /lib/systemd/systemd
     pid_one_command: /lib/systemd/systemd

followed by a test suite.
Add this to a recipe and kitchen converge
mysql_service 'default_mysql' do
  port '3306'
  version '5.7'
  initial_root_password 'asdfadfa'
  action [:create, :start]
end

:police_car: Expected behavior
Converge successfully.
:heavy_plus_sign: Additional context
Log from trying to converge.
================================================================================
       Recipe Compile Error in /tmp/kitchen/cache/cookbooks/bl_mysql/recipes/default.rb
       ================================================================================

       NoMethodError
       -------------
       undefined method `mysql_service' for cookbook: bl_mysql, recipe: default :Chef::Recipe

       Cookbook Trace: (most recent call first)
       ----------------------------------------
         /tmp/kitchen/cache/cookbooks/bl_mysql/recipes/default.rb:27:in `from_file'

       Relevant File Content:
       ----------------------
       /tmp/kitchen/cache/cookbooks/bl_mysql/recipes/default.rb:

        20:      action :create
        21:      group 'mysql'
        22:      mode '0755'
        23:      owner 'mysql'
        24:    end
        25:  end
        26:
        27>> mysql_service 'default_mysql' do
...
        31:    port '3306'
        32:    version '5.7'
        33:    initial_root_password 'asdfadf'
        34:    action [:create, :start]
        35:  end
        36:

       System Info:
       ------------
       chef_version=16.2.44
       platform=ubuntu
       platform_version=16.04
       ruby=ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
       program_name=/opt/chef/bin/chef-client
       executable=/opt/chef/bin/chef-client

I can also confirm this as well.
I also get the same undefined method 'mysql_service' error running the latest version of chef on Ubuntu 18.04. I had to downgrade chef to get this to work.

I had to downgrade chef to get this to work.

@teliov to which version exactly? I've tried 16.4.41 and 15.13.8-1 and got no luck... and 14's reached EOL in April 2020.

@ryutaro-brainlabs @teliov can you please confirm that what @axl89 mentioned above?

@ryutaro-brainlabs @teliov can you please confirm that what @axl89 mentioned above?

I am covering Ryutaro while he's on sabbatical, unfortunately we are still seeing this error using chef 16.4.4

tell a lie, I was too impatient allowing the dependencies to update... all working now 👍


Package ng2-smart-table is not compatible with Angular v14

When installing as of this weekend, the following NPM error occurs during package resolution:
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error node_modules/ng2-smart-table
npm error<EMAIL_ADDRESS>from the root project

There are other more easily resolvable dependencies (tslint being one of them); but ng2-smart-table doesn't appear to support anything beyond Angular v10. Not quite sure how this previously worked with Angular v14 but I'm curious!

For additional context; a colleague of mine reached out to see if we could solve this issue on his machine. I actually cloned a fresh copy of the repo myself and received the same errors as him. My thoughts are that at least a few of the subdependencies have been updated since last release of the project, and the version restrictions in package.json aren't strict enough. But even with that, using the original package-lock.json from source control yields the following (in other words, if I clone a fresh copy, here's what we originally got before narrowing down to the ng2-smart-table issue we couldn't get overlapping versions for between A14 and NG2ST v1.7):
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/@angular/common
npm error<EMAIL_ADDRESS>from the root project
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@angular/forms
npm error<EMAIL_ADDRESS>from the root project
npm error     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@nebular/auth
npm error<EMAIL_ADDRESS>from the root project
npm error     2 more (@swimlane/ngx-charts, ng2-completer)
npm error   11 more (@angular/platform-browser, ...)
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>|| ^13.0.0-0" from<EMAIL_ADDRESS>npm error node_modules/@angular/cdk
npm error<EMAIL_ADDRESS>from the root project
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@swimlane/ngx-charts
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Conflicting peer dependency<EMAIL_ADDRESS>npm error node_modules/@angular/common
npm error   peer<EMAIL_ADDRESS>|| ^13.0.0-0" from<EMAIL_ADDRESS>npm error   node_modules/@angular/cdk
npm error<EMAIL_ADDRESS>from the root project
npm error     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@swimlane/ngx-charts
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.


[Jex-Generator] Jsonb Type generation

Adds the explicit Jsonb type generator we have for helidon/javalin to the jex generator

@rbygrave it seems the failing test is unrelated to my changes

So with the test in question we have an interesting overlap for routes:
    routing.get("/common/name/{name}", this::_name);
    routing.get("/common/{id}/{name}", this::_p2);

So perhaps with EA builds the ordering here is changed (compile order of methods is not preserved?) or ... perhaps the routes lose ordering in the internal RoutesBuilder which uses an EnumMap.
I'll change that EnumMap to a LinkedHashMap and see ...


Error when trying to enable static website on Azure storage account using CLI az storage blob service-properties update from git bash on windows

I was trying to enable static website for a storage account on Azure using the below command
az storage blob service-properties update --account-name myStorageAcc --static-website.
I was running this command from git bash on Windows 10. But it threw below error
az storage blob service-properties: 'update' is not in the 'az storage blob service-properties' command group. See 'az storage blob service-properties --help'.
Can you please let me know what is the issue here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a18ea7d6-e13f-2ce2-3646-8d5fd7108d20
Version Independent ID: 3af2621e-585c-11f4-d1ae-0cc9d3531c18
Content: az storage account blob-service-properties
Content Source: src/azure-cli/azure/cli/command_modules/storage/_help.py
Service: storage
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@satyajitmahapatra Thank you for sharing your feedback! Since this channel is for driving improvements towards MS Docs, could you provide us with a specific URL of the MS Doc that your feedback is most applicable to? That way, we're able to connect you with the right team that's best fit to address your feedback.

Hi Mike, Here is the link in MS Doc. https://docs.microsoft.com/en-us/cli/azure/storage/account/blob-service-properties?view=azure-cli-latest#az-storage-account-blob-service-properties-update

@satyajitmahapatra
I believe this is the correct document you are referring to. Can you please confirm the CLI version you are running by running "az --version"?

Hi Derek, I am using CLI version 2.0.44

I upgraded the CLI version and it is working now. Sorry for the trouble.


Enhancing buttons in navbar

The login and signup can have blue bg as all other website have to separate them from rest of the links.
The AI assistant button can be shifted to bottom right of screen at all times and opened right there and not link to a separate page.

Could you please assign this issue to me under VSoC'24

Great @Mehak-Mattoo Assigned to you!!


Release 0.12.0

New release for webpack-focus, featuring webpack 2, postcss, and a lots of new features.
Still have to take care of the conflicted files

@fconstantin Conflicts resolved, can be merged and published


Periodically dnscrypt-service does not start after Windows startup

Events 7000:

The DNSCrypt client proxy service failed to start due to the following error:
The service did not respond to the start or control request in a timely fashion.

and 7009:

Timeout (30000 milliseconds) waiting for the DNSCrypt client proxy service to connect.

are logged.
Windows 7 x64 Pro
dnscrypt proxy 2.06 final

Please tell me that you do not understand exactly.
I use dnscrypro proxy as Windows service. For some reason that service sometimes doesnot start with Windows. I have to start it manually.

nd I don't even know what application is displaying or logging this.
Its Windows event log obviously.

So, you're the expert here :)
If you can find out what is causing this and how to improve or fix it, I'd be more than happy to merge any required changes!
Sorry Iam not coder. I have just submitted issue. Is this section ("Issues") not created for this?
Or should I have a degree in software development to submit issue?
Please tell me I dont understand.

Unfortunately, I don't use Windows. Just today, you probably used it more than I did in my entire life :)
So this issue would stay open forever until you find a workaround.
Maybe you can try https://simplednscrypt.org ?

@userneu maybe you can play with the ServicesPipeTimout https://support.microsoft.com/en-us/help/922918/a-service-does-not-start-and-events-7000-and-7011-are-logged-in-window

@jedisct1
@bitbeans
Thanks.

I have the same issue as you @userneu
The solution is to update the timestamp on your public-resolvers.md.minisig in the dnscrypt folder, and then restart the windows service.
You can update the timestamp by using cygwin and running the command touch public-resolvers.md.minisig when in the dnscrypt folder.


set IV after the encryption key to actually use IV in AES-*-GCM algorithms

Hello,
a stack overflow user noticed a weird behavior when using attr_encrypted (see the SO question and discussion). The problem is that when encrypting with one of the aes-*-gcm algorithms while using initialization vector (IV), the encrypted result is the same for any IV, i.e. the init. vector is not taken into account at all. This seems to be an important security problem, especially considering that the aes-256-gcm is the default encryption algorithm in this gem.
Further investigation showed that the problem is only with the -gcm algorithms, other algorithms seem to be OK, which is btw also proved by the test_should_crypt_with_the_#{algorithm}_algorithm_with_iv test. Unfortunately this test does not verify the -gcm algorithms.
The problem can be fixed simply by setting the IV after setting the encryption key (current code sets IV before setting the key).
It is unclear to me where exactly this problem originates from, but the fact that it affects only the -gcm algorithms and not others suggests that it is a bug somewhere in the OpenSSL library code for AES-*-GCM algorithms. I could not find anything related to the order of setting IVs and keys in any documentation.
Anyway, this pull request moves setting the IV after setting the key and adds an accompanying test. This test fails in the current master branch but will run OK after merging.
It is very unfortunate that the default encryption algorithm is aes-256-gcm and thus the encryption is less secure for everybody who is not using random salt. A sad thing to note is also that this fix will probably make all these setups undecipherable as suddenly the IV would be taken into account after upgrading this gem.
Testing the issue:
Tested under ruby 2.3.0 compiled against OpenSSL version "1.0.1f 6 Jan 2014".
def base64_enc(bytes)
  [bytes].pack("m")
end

def test_aes_encr(n, cipher, data, key, iv, iv_before_key = true)
  cipher = OpenSSL::Cipher.new(cipher)
  cipher.encrypt

  if iv_before_key
    cipher.iv = iv
    cipher.key = key
  else
    cipher.key = key
    cipher.iv = iv
  end

  if cipher.name.downcase.end_with?("gcm")
    cipher.auth_data = ""
  end

  result = cipher.update(data)
  result << cipher.final

  puts "#{n} #{cipher.name}, iv #{iv_before_key ? "BEFORE" : "AFTER "} key: " +
           "iv=#{iv}, result=#{base64_enc(result)}"
end

def test_encryption
  data = "something private"
  key = "This is a key that is 256 bits!!"

  # control tests using AES-256-CBC
  test_aes_encr(1, "aes-256-cbc", data, key, "aaaabbbbccccdddd", true)
  test_aes_encr(2, "aes-256-cbc", data, key, "eeeeffffgggghhhh", true)
  test_aes_encr(3, "aes-256-cbc", data, key, "aaaabbbbccccdddd", false)
  test_aes_encr(4, "aes-256-cbc", data, key, "eeeeffffgggghhhh", false)

  # failing tests using AES-256-GCM
  test_aes_encr(5, "aes-256-gcm", data, key, "aaaabbbbcccc", true)
  test_aes_encr(6, "aes-256-gcm", data, key, "eeeeffffgggg", true)
  test_aes_encr(7, "aes-256-gcm", data, key, "aaaabbbbcccc", false)
  test_aes_encr(8, "aes-256-gcm", data, key, "eeeeffffgggg", false)
end

Running the test_encryption gives:
>> test_encryption
1 AES-256-CBC, iv BEFORE key: iv=aaaabbbbccccdddd, result=4IAGcazRmEUIRDE3ZpEgoS0Nmm1/+nrd5VT2/Xab0WM=
2 AES-256-CBC, iv BEFORE key: iv=eeeeffffgggghhhh, result=T7um2Wgb2vw1r4uryF3xnBeq+KozuetjKGItfNKurGE=
3 AES-256-CBC, iv AFTER  key: iv=aaaabbbbccccdddd, result=4IAGcazRmEUIRDE3ZpEgoS0Nmm1/+nrd5VT2/Xab0WM=
4 AES-256-CBC, iv AFTER  key: iv=eeeeffffgggghhhh, result=T7um2Wgb2vw1r4uryF3xnBeq+KozuetjKGItfNKurGE=

5 id-aes256-GCM, iv BEFORE key: iv=aaaabbbbcccc, result=Tl/HfkWpwoByeYRz6Mz4yIo=
6 id-aes256-GCM, iv BEFORE key: iv=eeeeffffgggg, result=Tl/HfkWpwoByeYRz6Mz4yIo=
7 id-aes256-GCM, iv AFTER  key: iv=aaaabbbbcccc, result=+4Iyn7RSDKimTQi0S3gn58E=
8 id-aes256-GCM, iv AFTER  key: iv=eeeeffffgggg, result=3m9uEDyb9eh1RD3CuOCmc50=

Test results 1-4 show that for CBC it is irrelevant if IV is set before or after the encryption key and that IV is always taken into account (the results differ for different IVs).
The results 5-8 on the other hand prove that the encrypted results are the same for two different IVs if IV set before the key, whereas the results are different when IV set after key.
If you need anything else from me regarding this issue, I'll be happy to help.

Just got bit by this as well; it's breaking attr_encrypted gem https://github.com/attr-encrypted/attr_encrypted/issues/203

@borama thank you for opening this issue. The intention of using aes-*-gcm was to improve security. It looks like this bug prevented that effort.
It looks like the only indication that the IV should be set after the key is in the example here: http://ruby-doc.org/stdlib-2.3.0/libdoc/openssl/rdoc/OpenSSL/Cipher.html#class-OpenSSL::Cipher-label-Authenticated+Encryption+and+Associated+Data+-28AEAD-29
However, it's not obvious that this ordering is required for the algorithm to work correctly.
I believe you are correct in your assessment regarding the breaking changes it will introduce. Do you have any recommendations on how to move forward with this?
I'm not sure if this requires another major version change, but since it will indeed break existing code using aes-*-gcm I'm leaning to the fact that yes it should.
There is a path forward for those that have been bitten by this bug, but it's not pretty. They can upgrade, and implement code to decrypt the old value and then re-encrypt using the new code that utilizes the IV. It's not pretty but it's a path forward.
Any suggestions that you have would be very much appreciated.

I would tend to agree with you about the major version change - a careless update could be catastrophic.
Perhaps the data manipulations required by the update could be automated in a rake task, or something, to help people do it correctly...

Hello guys, I came to about the same conclusions as you.
I was also thinking about a rake task that would help users to decrypt (without IVs) and reencrypt (with IVs) their data. There is a risk I see in the fact that there is no way to automatically recognize if an encrypted value was calculated using or not using IV (unless you know the plain text data), so I'd be worried that someone ran this task more than once, for example. Perhaps the task should be interactive, showing a sample decrypted data and forcing the user to confirm that the decrypted data is ok before actually running the process?
Another problem I see is that it would be advisable for attr_encrypted users to upgrade the gem and their data offline because otherwise the currently encrypted data could be immediately decrypted wrong (with IVs) after deployment of the upgraded gem. If somebody using the web "corrected" the decrypted value, it would be saved with the IV and this would lead to data corruption later when the above-mentioned rake task would be ran.
I think I'd also agree with a major update, with big warnings everywhere about the consequences of the upgrade...

I would tend to agree with you about the major version change

Agreed. But you want to make super sure this bug is really squashed; you don't want to have several major version releases in a single week.

with big warnings everywhere about the consequences of the upgrade

Seconded.

There is a path forward for those that have been bitten by this bug, but it's not pretty.

Suggestion for interim point version: leave the -gcm algorithms broken for backwards compatibility but (a) add a deprecation warning when they are invoked then (b) implement fixed versions suffixed like -gcm-fixed - yeah I know that's yucky but in order to migrate you need both version working so you can decrypt from the bad algorithm and encrypt with the good one.

I like the idea of a rake task, but I think there's too many variables to consider. Perhaps at the very least an example of how to do it is in order.
For users of attr_encrypted, the path forward is a bit easier, as you can pass in the encryption library to use. An affected app can copy the broken implementation and use that for decryption, and use the new version of encryptor for encrypting.
I agree with @borama's suggestion that this data migration should happen offline to prevent the different implementations from being used otherwise the migration becomes significantly more complex.
@trak3r I think the test that @borama provided is fairly conclusive, but point taken. Please feel free to review the tests and offer any suggestions.

I think this test proves that this is only a problem for the GCM algorithm. https://github.com/attr-encrypted/encryptor/blob/master/test/compatibility_test.rb#L44

I've pushed a new version of Encryptor. https://rubygems.org/gems/encryptor/versions/3.0.0 The bug that @borama pointed out is fixed. I've also added an option to allow the IV to be set in the way that it was in Encryptor v2.0.0, so that decryption of data encrypted using an AES-*-GCM algorithm is possible. This should facilitate migrating data that was incorrectly encrypted.

@saghaulor thanks for the speedy update, great work!

FYI, I made some further tests and came to believe this is either bug or an undocumented feature in the ruby-openssl code. I filed an issue there so you can track it if you like.

FYI, it was recently confirmed that this had actually been an issue in the underlying ruby-openssl library and the bug has been fixed today. So, in the future, it is possible that attr_encrypted gem version 2.x will actually work correctly when used with the new openssl-2.0.0 gem version which is now in beta.

@borama I saw that, thanks for the update. The problem is, if people use v2 and upgrade to the fix, they're going to have records encrypted with varying implementations. It will be a mess to sort out.

@saghaulor thanks, you are correct, this did not occur to me and I can see now that the fix may actually complicate things even more :(

Hopefully there won't be too much fallout. 🙏


fix: update links in JSDoc

missed a spot just now

preview: https://svelte-dev-git-preview-kit-12963-svelte.vercel.app/
this is an automated message


Remove unneeded dart:async import

Since Dart 2.1, Future and Stream have been exported by dart:core.
Alternatively, if this package has a reason it must continue to support
Dart 2.0, an exception can be made internally for this.

Oops! looks like that won't work completely. See travis

We need to bump the SDK that we use for testing

@MichaelRFairhurst - FYI in general we try to avoid using force pushes once a PR has comments. Consider using a merge instead of a rebase to sync from master when necessary, and create new commits to respond to comments. We use "Squash and merge" to commit it on master to keep a clean history.
https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#handling-pull-requests

Oh, this looks like a necessary import.
@MichaelRFairhurst - how did you find this one? If it was with an automated tool you might want to check for a bug.
I think we should close this PR?

Ah, seems like my g3 client was out of date. This import used to be unnecessary but now is required. Closed!


Allow serializing the iterators

I'd like to save the state of the iterator to a file, so that I can continue iterating at that exact point on next run. A few values are held via closure, so I can't just serialize the iterator itself. Any ideas?

You can save the seed array and its index then use .nth(index) to resume.

Thanks, setting cp.index to the previous value seems to do it for the cartesian product!


modifying cv show_progress to allow print-every-n behavior

This change allows you to set cv()'s show_progress to an integer n to print progress every n trees instead of for each tree, similar to the behavior of train()'s verbose_eval behavior.

@rcarneva Could you add some additional comments in docstring of cv() for show_progress? Thanks.

Also, you may want to make trial=None backward compatible.

Good call. Updated the docstrings and defaulted trial to 0 so it won't break in case someone's calling aggcv from somewhere else and had show_progress already set to an int.

I got an error ,
TypeError: cv() got an unexpected keyword argument 'show_progress'
so 'show_progress' is now not an argument of xgb.cv?

For some reason, it looks like https://github.com/dmlc/xgboost/commit/c17d0ef560aac4b583f830394025412aaef6301c bulk renamed show_progress to verbose_eval. Don't know the rationale for it, but I'd assume that the parameter should still work the same.


Hovering over an element should display a short description

I keep having to open up the reference to figure out what each menu item is supposed to do (e.g. dust). It would be helpful to provide a small popup on the mouse or otherwise that shows the description of each element as you hover over it in the menu.

Support


Feat: Auto Commenting feature for PR Merged

Describe the feature
This feature aims to solve the problem of inconsistent and delayed communication following the merging of PRs. By automating the commenting process, it ensures that contributors receive timely feedback and acknowledgments. It also reduces the administrative burden on maintainers, allowing them to focus more on code reviews and other critical tasks
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@subhadeeproy3902 please assign me this issue under gssoc'24

Go ahead @Asymtode712


Add MSI support

We need to add a support of installing tenv from MSI.
https://goreleaser.com/customization/msi/

Probably it could be a problem, because it requires premium go-releaser.
cc @Nmishin


undefined method fire

Hi,
I updated my project for laravel 5.8 and backpack 4.6.
But now, when i add a new entry which is translatable, i got this error :
Call to undefined method Illuminate\Events\Dispatcher::fire()
(vendor/backpack/crud/src/ModelTraits/SpatieTranslatable/SluggableObserver.php line 78).
Any idea ?
Regards

@tabacitu AFAIK the fire() method is deprecated since Laravel 5.4 and was removed in 5.8. It was replaced by dispatch().
This is a simple change. But I currently don't know if this is the only thing we have to fix.

Same  problem here. This is a bug in the Venturecraft/revisionable package (which doesn't look in very active development). There is  a bug issue opened there.

Thank you for reporting this guys! Apparently there was this bug in Backpack\CRUD too, I've just merged a PR that fixes it https://github.com/Laravel-Backpack/CRUD/pull/1830#issuecomment-471906981
Cheers!


Fix sorting of countries

Meta class for the Country model did not inherit from the base class's as per https://docs.djangoproject.com/en/1.11/topics/db/models/#meta-inheritance

Codecov Report

Merging #189 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #189   +/-   ##
========================================
  Coverage    95.49%   95.49%
========================================
  Files           37       37
  Lines         1244     1244
  Branches        77       77
========================================
  Hits          1188     1188
  Misses          45       45
  Partials        11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24efc3...d54e7c2. Read the comment docs.


feat: produce apsect specific event by default

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

I don't think that DataHub is ready for this in open source. Is LinkedIn ready for this internally?
If the latter is true, can we tick the semi major version and then, when this is submitted, can you go to the DataHub repo, bump GMA, and then ensure this flag is off there for the GMS?


[ENTSWM-566] update to Thorntail 2.4.0.Final-redhat

WIP, shouldn't be merged yet.

OK to merge now.


[Infra] Embed frameworks during quickstart testing

#no-changelog

My QS script changes didn't work so will have to I'll have to try again.

Merged https://github.com/firebase/quickstart-ios/pull/1576 and are now facing different errrors.

All green as of 034921d

[ ] Why does archive not get stripped out?
[ ] Move embedded frameworks from Resources/ to Frameworks/ location


Please define 'request charge'

This term 'request charge' seems to be specific to CosmosDB, but I can't find an official definition of it anywhere, doc or code. Although I can guess what it means, could we have an official definition in the doc? This page seems like a nice place to do so, and it was the top result from Google.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49b9cecf-c00d-821f-c5f4-06249c75bf55
Version Independent ID: 12ec16ac-97c7-e351-464c-93a23f67845d
Content: Find request unit (RU) charge for a SQL query in Azure Cosmos DB
Content Source: articles/cosmos-db/find-request-unit-charge.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @ThomasWeiss
Microsoft Alias: thweiss

@Efreeto Thank you for the feedback.
This is being assigned to the content author to evaluate and update the documentation as appropriate.

@Efreeto Request charge is the request units consumed by all your database operations. the second paragraph in the doc kind of says it. I made a minor tweak in the above PR for better clarification.
We will now close this issue.
#please-close

@SnehaGunda Which PR had your change?


Google_Service_Calendar_EventReminder doesn't work

Hello there, Google_Service_Calendar_EventReminder seems to be ignored. It looks like useDefault doesn't work. I also tried setting it to "false" (string), as suggested in some blogs, but it didn't help either... Any ideas? Thanks in advance! Release 2.2.0.
		$reminders = new Google_Service_Calendar_EventReminders();
		$reminder = new Google_Service_Calendar_EventReminder();
		$reminder->setMethod('popup');
		$reminder->setMinutes(60);
		$reminders->setUseDefault(false);
		$reminders->setOverrides(array($reminder));
		$event->setReminders($reminders);

Are you inserting an event or updating one?
Do you get an error response? If not, try including reminders in fields so they come back in the response and please include that.
More generally, please include as much as information as you can to help us reproduce your result.

@mattwhisenhunt It works neither for inserting nor for updating. No error response. The events get correctly inserted / updated but with no reminders added. What do you mean by fields? Thanks!

Thank you for filing this issue. We asked some clarifying questions or suggested a course of action a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to comment with more information and we will re-open this issue.


Clear resolved modules cache before runJest in watch mode

[x] set clearCache
[x] add immitation test

Summary
This patch fixes bug with watchAll mode.
https://github.com/facebook/jest/pull/8388#issuecomment-492086744
My solution:
I just clear checkedPaths before repeated run in watch mode to avoid situation when we have legacy path information.

Test plan
I added test to avoid this bug in a future.

It seems like a good place to clear it, yeah. Do you have a repro for a bug with this so that we can check that it is fixed?

I did not see a special issue. I have only comment with this bug after merge my previus PR.
https://github.com/facebook/jest/pull/8388#issuecomment-492086744
@jeysal

Ah okay, thanks a lot for following up to ensure quality here! :) Go ahead then, would be cool to have a test that simulates a change in what a file resolves to in order to test the cache invalidation, I don't think we have something like this yet :sweat_smile:

@jeysal i added real test.


1.13 optimizers function incorrectly with datasets with unbalanced labels

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.10 (16.04 has the same issue)
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): ('v1.13.1-0-g6612da8951', '1.13.1')
Python version: 2.7, 3.5, 3.6, 3.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: -
GPU model and memory: - (reproducable with GPU explicitly disabled)

Describe the current behavior

Faulty version: ('v1.13.1-0-g6612da8951', '1.13.1') (same behavior observed with custom-built 1.13.1)
Reference version: ('v1.10.0-0-g656e7a2b34', '1.10.0')

We are experiencing the issue on our models, that used to be trained using Tensorflow 1.10, where there was no issue, but since we upgraded to 1.13, it appeared.
I have constructed an artificial, as simple as possible example, showcasing the issue.
The example in the attached Zip file is using imports85 data. The "True" label is price < PRICE_CUTOFF, with PRICE_CUTOFF set so that the resulting label mean is 0.0146, making it significantly unbalanced.
The FTRL optimizer in the example code has bizarre coefficients set to demonstrate the issue more graphically. In our models we have them in reasonable range and still get the wrong behavior.
If the model is trained and evaluated using 1.10, the results (given all the constants as set in the code) are the following:
Resulting means:
  Label: 0.0146341463415
  Prediction (no optimizer): 0.023864556
  Prediction (optimizer): 0.026022965

Now, the results above are pretty bad, but it's due to really small dataset, used to train the model, but it's not significant from the standpoint of showcasing wrong behavior: in our models, the predictions, done with 1.10-trained model are pretty on-point.
When the model is trained and evaluated using 1.13, the model WITH optimizer applied starts to show unreasonably high predictions:
Resulting means:
  Label: 0.0146341463415
  Prediction (no optimizer): 0.02390607
  Prediction (optimizer): 0.044271074

These results above are consistent with what we see in our models, where predictions became overwhelmingly positive once 1.13 was used for the model training (since we do use optimizers).
This does not seem to be an issue with FTRL optimizer itself, since we have tried several of them, all showing significant skewing of predicted results towards one or other end, if the label in the dataset is not balanced.
The example code should allow easy reproduction of the issue. Zip file also contains two requirements files: requirements_1.10.txt and requirements_1.13.txt to streamline setting up the virtual environments to test the issue.
Code to reproduce the issue
See attached Zip
optimizers_unbalanced_label_bug.zip

I could test with the other TF versions to better identify, where stuff went south - and it seems to be 1.11 (I have tried ('v1.11.0-0-gc19e29306c', '1.11.0') specifically) version. For it, the results are much like for 1.13:
Resulting means:
  Label: 0.0146341463415
  Prediction (no optimizer): 0.023945015
  Prediction (optimizer): 0.044300616

Wasn't it a version, where some new graph optimization mechanisms were introduced?

...and the same in 1.12 (('v1.12.0-0-ga6d8ffae09', '1.12.0')):
Resulting means:
  Label: 0.0146341463415
  Prediction (no optimizer): 0.023909163
  Prediction (optimizer): 0.044271577

Apparently, something was introduced in 1.11 and broke stuff.

@VOvchinnikov I tried reproducing issue with the provided code ,but i am unable to reproduce .Will it be possible to provide minimal code snippet which can reproduce the reported issue.Thanks

Closing the issue, because the observed effect has been caused by this: https://github.com/tensorflow/tensorflow/issues/18317
The deviation of prediction mean, when using other optimizers, was caused by my mistake during setup of the experiment.


Test Newer TensorFlow Versions

Test newer TensorFlow versions

Based on the tagged release of TF=2.16.0-rc [here] (https://github.com/tensorflow/tensorflow/releases/tag/v2.16.0-rc0 ) we have two alternatives:

Proceeding with a pinned version for Keras underlying engine (as done in my latest commit)
Update our package to incorporate the changes in Keras 3. Possibly breaking compatibility with previous versions of TF. (needs investigation)


bug(form-field): matPrefix does not style SVG icons properly

Reproduction
Steps to reproduce:

Use SVG icons with <mat-icon>
Add an icon to a form field using matPrefix

Expected Behavior
The icon resizes appropriately to the form field, similar to what is done with <mat-icon-button>
Actual Behavior
The icon does not resize, particularly w.r.t. the width of the element, leaving it too close to the placeholder text in the input element.
This is because matPrefix has special styling for .mat-icon alone that works only for font-based icons, and styling for .mat-icon-button .mat-icon that works with both styles of icon, but it lacks styling for .mat-icon alone that works with SVG-style icons.
Perhaps the styles can be adjusted so that an explicit height and width is given to the <mat-icon>, similar to what is already being done with .mat-icon-button.
Environment

Angular: angular/angular@e039075a2837b0decf17cfbd5382d675c331bbeb
CDK/Material: ade09010454bd82e547522326a6fe6178c9a39f3
Browser(s): Firefox 88.0.1
Operating System (e.g. Windows, macOS, Ubuntu): gLinux

Can you post what your markup looks like? I looked into this, but SVG and font-based icons behaved similarly for me.

Closing since there hasn't been any feedback in a long time. It can be reopened if we get more information.


Tools: add UIO driver support to PAC N3000 ethernet tools

Upstream DFL VFIO MDEV driver patch was rejected by Linux, DFL driver supports UIO driver instead of VFIO MDEV.
UIO driver can used to access N3000 ethernet DFH.
eth_group_uio.sh: Enables / Disables PAC N3000 card ethernet group.
eth_group Module: this pybind11 module opens eth group DFH and reads/writes CSRs.
Updated common.py, fecmode.py, fpgamac.py, fpgastats.py, fvlbypass.py, mactest.py tools to support UIO Driver
Signed-off-by: anandaravuri<EMAIL_ADDRESS>

Coverage remained the same at 67.283% when pulling 9d2d03935435651afaee0cd08550dc98f104c1b5 on aravuri/uio_eth_group into 2d8296134b8e0f120dd6b79255e91bc216b48c81 on master.


add transaction name to error objects

also, move determination of transaction name in Django to earliest
possible moment.
Related issues
closes #1409

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

/test


No Texts Updating in Mac Build Version

Game is very frozen in the built .app file
No texts update
Nothing Works
Cause Unknown

Update Error Doesn't Occur when running project in editor
Must Be an issue with the build file

Bug Hasn't been reported by anyone other than me

Closing because Issue hasn't been reported at all

Still Occurs For Me


Create a scriptmodule for RetroPie-Extra

This is what I have so far @meleu :
#!/user/bin/env bash

rp_module_id="fun-facts-splashscreens"
rp_module_desc="Generate splashscreens with random video game related fun facts."
rp_module="Help"
rp_module="exp"

function depends_fun-facts-splashscreens() {
    getDepends ""imagemagick"
}

function sources_fun-facts-splashscreens() {
    gitPullOrClone "https://github.com/hiulit/es-fun-facts-splashscreens.git"
}

function install_fun-facts-splashscreens() {
    md_ret_files=(
        'es-fun-facts-splashscreens.sh'
        'fun_facts.txt'
        'fun_facts_settings.cfg'
        'retropie-default.png'
    )
}

It's super basic, but it works. It installs correctly the Fun Facts! folder.
Now, I guess we need a GUI? Or how is it supossed to be configured?
Also, it would be cool if we could to automate the Choose Own Splashscreen option for setting the splashscreen.

I created a GUI! :D

And I fixed the scriptmodule:
#!/usr/bin/env bash

rp_module_id="fun-facts-splashscreens"
rp_module_desc="Generate splashscreens with random video game related fun facts."
rp_module_help="Follow the instructions on the dialogs to set the splashscreen and the text color. Set \"Enable at boot\" to create a new Fun Fact! splashscreen automatically at each system boot."
rp_module_section="exp"

function depends_fun-facts_splashscreens() {
    getDepends "imagemagick"
}

function sources_fun-facts-splashscreens() {
    gitPullOrClone "$md_build" "https://github.com/hiulit/es-fun-facts-splashscreens.git"
}

function install_fun-facts-splashscreens() {
    md_ret_files=(
        'es-fun-facts-splashscreens.sh'
        'fun_facts.txt'
        'fun_facts_settings.cfg'
        'retropie-default.png'
    )
}

function gui_fun-facts-splashscreens() {
    bash "$md_inst/es-fun-facts-splashscreens.sh" --gui
}

Wow! I'm sorry for not being able to help that much! :pensive: But you're doing a really good job and I'm sure you're learning a lot! :wink:

Don't worry! I'm just tagging you to keep you updated, not to bother you nor ask any more of you! 😉
Thanks for the support!

The scriptmodule it's on RetroPie-Extra. Closing issue!


3js tutorial Added

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
It is valuable because 3js is trending these days.
How do we know it's really free?
It is available in youtube.
For book lists, is it a book? For course lists, is it a course? etc.
It is a youtube course/tutorial for 3js.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Be sure to check the free-programming-books-lint output for linter errors. Alphabetical order and spacing are the most common problems.
For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes
No shortened links.
Use this PR for changes. DO NOT spam us with additional PRs!!


Added a few LabStack APIs

Signed-off-by: Vishal Rana<EMAIL_ADDRESS>Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items

Hi @vishr , thanks for the PR. Can you please put the auth type values in backticks (`)? It appears our validator does not check for this, so I will make the changes to test against that in the future.

maintainer note: fixed the backtick build check issue in 21901ee2ac0884292cdc0cfb82d333409745dd6a

@davemachado Just did it, thanks.

Thanks!


Piss. Everywhere.

Help, whenever I open I get memory leeks where piss falls out of my RAM!

it's not a bug it's a feature

Ah, that makes sense, it is a good feature, I love how quickly it breaks your motherboard, I wanted to stop using my computer as much 😁


Configure automated release versioning and publishing

Specific Demand
As Dioxus grows in size and scope, it's time for the project to evolve its release management process. Ideally, a GitHub workflow can be configured to remove the complex manual steps required to tag, version, and publish new releases. This can also help with security as fewer Crates.io tokens need to be floating around between maintainers. Instead, a single copy can be uploaded to the organization and used by the pipeline for automated publishing.
Implement Suggestion
There are many tools available for automating versioning and publishing, the following seem the most promising. I'm still investigating this and will update this list with benefits and tradeoffs as I learn more.
release-plz
This is a rust-specific CI tool that automates the creation of release-PRs, which manage versioning and changelog generation for all changes between the last successful release and the current one. It is capable of automating versioning using either conventional commits schema or cargo-semver-checks, making it flexible to projects that don't have a well-established PR hygiene.
release-please
This is a Google-maintained project that was the original inspiration for release-plz, though it is compatible with many languages (Rust among them). This project enforces stronger PR hygiene by requiring all PRs to use the conventional commits schema. This project also seems to support additional workspace-specific tooling, though I am still looking into this.
cargo-workspaces
This is a workspaces-optimized CLI for managing crate versioning and publishing. It doesn't appear to have the best support for CI automation, though I'm still looking into this.
cargo-smart-release
This is a very opinionated toolset for managing and publishing releases, though the opinions appear to be pretty well-aligned to the current Dioxus workflow. Still looking into this and how it can be CI-automated.

Another thing that could be useful, though is more of a procedural improvement, is to establish milestone integration branches. We can build automation around git-semver-checks to confirm that there are no breaking changes in a new PR against master. This should allow bug fixes, security patches, and dependabot updates to still be developed against and directly committed to master. The automation would reject any breaking changes, requiring a maintainer to override the check if there's an issue that can only be addressed through a breaking change but doesn't qualify for a new minor bump. Otherwise, anything that requires a minor version bump (0.1.5 -> 0.2.0) would need to be committed first to a milestone branch (e.g. milestone-0.5). These PRs would be subject to additional scrutiny, such as multiple approvers instead of just one, and potentially additional checks.

Another thing that could be useful, though is more of a procedural improvement, is to establish milestone integration branches. We can build automation around git-semver-checks to confirm that there are no breaking changes in a new PR against master. This should allow bug fixes, security patches, and dependabot updates to still be developed against and directly committed to master. The automation would reject any breaking changes, requiring a maintainer to override the check if there's an issue that can only be addressed through a breaking change but doesn't qualify for a new minor bump. Otherwise, any breaking changes that require a minor version bump (0.1.5 -> 0.2.0) would need to be committed first to a milestone branch (e.g. milestone-0.5).
These milestone branches can be automatically created after each minor release (i.e. if 0.4.0 tag gets created by the release pipeline, a milestone-0.5 branch would be automatically created). These branches would be subject to the same validation checks and protection policies as master, ensuring they are kept in a stable state. When the maintainers are ready to release the next milestone, they can create a new PR to merge it into master. This will automatically bump the minor version according to the policy of whichever release automation tool we choose and then the cycle will start over, with the next milestone branch created.

For comparison the process we are following for this release is:

Only merge changes that are non-breaking to the published version most of the time (bug fixes or new features)
Merge breaking changes right before the release

Both of these process require additional work merging changes. With the new approach you proposed every time a bug fix is added it needs to be merged into the main branch and then the conflicts with the release branch need to be fixed. With the current approach all of the accumulated fixes must be merged into each breaking branch before the breaking branch is merged.
Switching feature development to a new branch could make releasing easier but it does raise some additional conserns:

Who handles fixing conflicts in bug PRs: the person who filed the PR or the maintainers?
It could make contributing to Dioxus more confusing
It makes it more difficult to test the new (non-breaking) features in the git version of Dioxus (you need to find a specific branch instead of just relying on the git version)

As a bonus, if we choose to exempt milestone branches from automatic deletion, we could retroactively patch and release older milestones if serious security fixes need to be applied. We don't currently have a long-term-support plan, but this could set us up for one in the future.

Right now I don't think a long term support plan makes sense for Dioxus. It would slow down development significantly because we need to fix merge conflicts several times for each release. It makes sense for some projects that are more stable but I don't think Dioxus is there yet. Most of the core API of Dioxus is stable externally which should make upgrading easy but the internals are changing more often

Who handles fixing conflicts in bug PRs: the person who filed the PR or the maintainers?

Do you mean conflicts that bug PRs introduce into new milestone branches? I was envisioning that we would set up an automation that would automatically open a chore PR to the milestone branch for every bug PR. I think at the least a maintainer would have to approve the PR, not sure about who would be responsible for resolving the conflicts. It's hard to enforce those things.

It could make contributing to Dioxus more confusing

This is certainly a trade-off. I think we could make this a little easier by setting up a Contributing guide and PR templates. We can also set up an automation that runs on PR creation to triage breaking changes and automatically change the PR target branch to the latest milestone if it is breaking and doesn't contain a category of bug. As projects grow in size, balancing ease of contribution against organization is a constant challenge 😕.

It makes it more difficult to test the new (non-breaking) features in the git version of Dioxus (you need to find a specific branch instead of just relying on the git version)

True, but it's not that smooth right now. Main is not stable so I've found I usually need to try a few different revs to find one that has the change I want but isn't broken.

Who handles fixing conflicts in bug PRs: the person who filed the PR or the maintainers?

Do you mean conflicts that bug PRs introduce into new milestone branches? I was envisioning that we would set up an automation that would automatically open a chore PR to the milestone branch for every bug PR. I think at the least a maintainer would have to approve the PR, not sure about who would be responsible for resolving the conflicts. It's hard to enforce those things. One option would be to create issues for each of them and tag them as good first contributions in some project table.

It could make contributing to Dioxus more confusing

This is certainly a trade-off. I think we could make this a little easier by setting up a Contributing guide and PR templates. We can also set up an automation that runs on PR creation to triage breaking changes and automatically change the PR target branch to the latest milestone if it is breaking and doesn't contain a category of bug. As projects grow in size, balancing ease of contribution against organization is a constant challenge 😕.

It makes it more difficult to test the new (non-breaking) features in the git version of Dioxus (you need to find a specific branch instead of just relying on the git version)

True, but it's not that smooth right now. Main is not stable so I've found I usually need to try a few different revs to find one that has the change I want but isn't broken. I suppose that could be classified as testing gaps, but I think it's also a case for just releasing patch versions more frequently.

Overall I think if the automation is good enough, the release branch approach is worth trying.
@jkelleyrtp I know you have looked into automatically tracking breaking changes before a release. What are your thoughts here?

We could incubate it in the dioxus-std repo to minimize impact to the primary project

We can try this on the main repo. A major flaw with not merging everything until before a release is there are a lot less people testing the new features.
We can use https://github.com/DioxusLabs/dioxus/tree/0.5 as our feature branch for the next release

Reviving this/adding my own 2¢.
I used cargo-workspaces for a the solution on dioxus-slides. Find the gha
The highights include;

A github action trigger that requires an argument any of "major/minor/patch".
Commits the new version back to github
Publishes all new versions to crates.io
Once versions are set up I never need to worry about them again

Things to note;

I've only tried this on a monorepo where all packages are the same version
This could mean a release every other PR as the cognitive load of releases is a lot smaller.

That could be part of the solution. The other half of the solution would be automatically detecting PRs that will require a major version bump. We also release a lot of packages with the same version at once, so something like that workflow would definitely be helpful

Yeah this sounds ideal, I am happy to hand this off, my life has been a bit too busy recently to do this issue justice. I'd been looking at cargo-semver-checks for detecting major version bumps, @alexanderjophus have you used this before?

@esimkowitz I haven't looked at it yet. Personally I'm not a huge fan of automating semver changes. Highlighting the differences so a maintainer can quickly parse "oh this needs to be a major/minor/patch release", sure. I'll check out cargo-semver-checks now :)

I use cargo-workspaces to do releases locally and even then process is quite finicky since we tend to have references to git repos as deps in the workspace on main.
We'll probably stick with automated local tools to do the releases but should lean into more automation for release posts, cli updates, etc.
We have autorelease workflows for the cli and extension now, thankfully, so it's easier to release those.


BoxView: Adds All Shipment Actions

PR includes the first iteration of BoxView with transfer capabilities, as well as major refactoring the component structure.
Implemented functionalities:

Assigning boxes to shipments
Removing the box from the shipment
Reassignment of the box to a different shipment

Missing:
Tests

 2.0 BoxView for all Shipment actions

 2.0 BoxView for all Shipment actions - write test case + tests + ui

@HaGuesto I wonder why you merged this PR although tests were failing? This means that later PR merges like the #806 are not deployed to staging.

@pylipp my logic was:
There are tests missing here. I'm touching tests again to also control other parts of the PRs that were merged, but that I did not review.
To not be a further bottleneck (so that Roanna can test) and to bring the code together (making it easier for me to get an overview), I merged the PRs that I was ok with from the code review side.
I see now that my plan was flawed since it does not deploy if tests are failing....
I'm sorry. I also should have made a note about this and not just merge last minute before I leave for the weekend.


Error message on install

Hi, I went to run npm install and I got the following:
UNMET PEER DEPENDENCY<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
Any thoughts why?
Thanks.

NM


Scrcpy crash if target device doesn't have clipboard service

Hi there!
I'm using scrcpy to control my Android based speaker which is without a screen.
It runs a deeply customized Android system and version is 5.1.1.
It was able to successfully connect and control it with the mouse and keyboard before scrcpy upgrade to version 1.14.
2020-07-02 20:28:36.255 scrcpy[20348:1741473] INFO: scrcpy 1.14 <https://github.com/Genymobile/scrcpy>
/usr/local/Cellar/scrcpy/1.14_1/share/scrcpy/scrcpy-server: 1 file pushed, 0 skipped. 24.8 MB/s (33142 bytes in 0.001s)
adb: error: more than one device and emulator
2020-07-02 20:28:36.412 scrcpy[20348:1741473] ERROR: "adb reverse" returned with value 1
2020-07-02 20:28:36.412 scrcpy[20348:1741473] WARN: 'adb reverse' failed, fallback to 'adb forward'
27183
[server] INFO: Device: phicomm rk322x-box (Android 5.1.1)
[server] ERROR: Exception on thread Thread[main,5,main]
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference
	at com.genymobile.scrcpy.wrappers.ClipboardManager.getAddPrimaryClipChangedListener(ClipboardManager.java:99)
	at com.genymobile.scrcpy.wrappers.ClipboardManager.addPrimaryClipChangedListener(ClipboardManager.java:111)
	at com.genymobile.scrcpy.Device.<init>(Device.java:83)
	at com.genymobile.scrcpy.Server.scrcpy(Server.java:23)
	at com.genymobile.scrcpy.Server.main(Server.java:225)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:249)
##@###noMacBook-Pro ~ % adb shell service call clipboard 1
service: Service clipboard does not exist

It's possible to connect the same device successfully using an older version of scrcpy.
##@####noMacBook-Pro ~ % scrcpy
2020-07-02 22:10:53.142 scrcpy[36828:1830562] INFO: scrcpy 1.13 <https://github.com/Genymobile/scrcpy>
/usr/local/Cellar/scrcpy/1.13/share/scrcpy/scrcpy-server: 1 file pushed, 0 skipped. 64.2 MB/s (27694 bytes in 0.000s)
adb: error: more than one device and emulator
2020-07-02 22:10:53.280 scrcpy[36828:1830562] ERROR: "adb reverse" returned with value 1
2020-07-02 22:10:53.280 scrcpy[36828:1830562] WARN: 'adb reverse' failed, fallback to 'adb forward'
27183
[server] INFO: Device: phicomm rk322x-box (Android 5.1.1)
2020-07-02 22:10:54.166 scrcpy[36828:1830562] INFO: Renderer: metal
2020-07-02 22:10:54.166 scrcpy[36828:1830562] WARN: Trilinear filtering disabled (not an OpenGL renderer)
2020-07-02 22:10:54.169 scrcpy[36828:1830562] INFO: Initial texture: 1440x960

Would it be a good idea to add an option to allow users to ignore this error? 😁

Réf: #1440

Yes, I'm experiencing a similar situation to #1440 .
I can't use the copy function, but I can still at least control my device using the mouse and keyboard by using older version but the latest version can't...
I know it's annoying, but would you consider adding an option to dodge this issue? (--ignore-errors or something like that)? Thank you!

Could you try the clipboard_manager branch, please?

Thank you very much! clipboard_manager branch works very well.
Also when I tried to bulid the server from source code myself I found the documentation to be a bit out of date, I'll submit a pr later to improve it.
Thanks for all you do!