[LLVMCPU] Extra buffer creation and miscellaneous issues.

What happened?
Input IR:
#map = affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2)>
#map1 = affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>
module {
  func.func @test_dispatch(%arg0: tensor<1x2x128xf32>, %arg1: tensor<1x2x48x30x30xf32>, %arg2: tensor<2x128x48x5x5xf32>) -> tensor<1x2x128x26x26xf32> {
    %cst = arith.constant 0.000000e+00 : f32
    %0 = tensor.empty() : tensor<1x2x128x26x26xf32>
    %1 = linalg.generic {indexing_maps = [#map, #map1], iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel"]} ins(%arg0 : tensor<1x2x128xf32>) outs(%0 : tensor<1x2x128x26x26xf32>) {
    ^bb0(%in: f32, %out: f32):
      linalg.yield %in : f32
    } -> tensor<1x2x128x26x26xf32>
    %2 = linalg.conv_2d_ngchw_gfchw {dilations = dense<1> : vector<2xi64>, strides = dense<1> : vector<2xi64>} ins(%arg1, %arg2 : tensor<1x2x48x30x30xf32>, tensor<2x128x48x5x5xf32>) outs(%1 : tensor<1x2x128x26x26xf32>) -> tensor<1x2x128x26x26xf32>
    %3 = linalg.generic {indexing_maps = [#map1, #map1], iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel"]} ins(%2 : tensor<1x2x128x26x26xf32>) outs(%0 : tensor<1x2x128x26x26xf32>) {
    ^bb0(%in: f32, %out: f32):
      %4 = arith.cmpf ugt, %in, %cst : f32
      %5 = arith.select %4, %in, %cst : f32
      linalg.yield %5 : f32
    } -> tensor<1x2x128x26x26xf32>
    return %3 : tensor<1x2x128x26x26xf32>
  }
}

1st Issue:
Since we have moved to scf.forall distribution as default on CPU -- the current path doesn't use convert to destination style pass: https://github.com/iree-org/iree/blob/3b751a4d2797d29422e08327b1a53933448a26fd/compiler/src/iree/compiler/Codegen/LLVMCPU/Passes.cpp#L116
There's  bufferization issue because of this:
IR with scf.forall distribution
// -----// IR Dump After EliminateEmptyTensorsPass (iree-eliminate-empty-tensors) //----- //
func.func @test_dispatch_dispatch_0_conv_2d_ngchw_gfchw_1x2x128x26x26x48x5x5_f32() attributes {translation_info = #iree_codegen.translation_info<CPUDefault>} {
  %cst = arith.constant 0.000000e+00 : f32
  %c0 = arith.constant 0 : index
  %0 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(0) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<1x2x48x30x30xf32>>
  %1 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(1) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<2x128x48x5x5xf32>>
  %2 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(2) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<1x2x128xf32>>
  %3 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(3) alignment(64) offset(%c0) flags(Indirect) : !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>>
  %4 = flow.dispatch.tensor.load %0, offsets = [0, 0, 0, 0, 0], sizes = [1, 2, 48, 30, 30], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<1x2x48x30x30xf32>> -> tensor<1x2x48x30x30xf32>
  %5 = flow.dispatch.tensor.load %1, offsets = [0, 0, 0, 0, 0], sizes = [2, 128, 48, 5, 5], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<2x128x48x5x5xf32>> -> tensor<2x128x48x5x5xf32>
  %6 = flow.dispatch.tensor.load %2, offsets = [0, 0, 0], sizes = [1, 2, 128], strides = [1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<1x2x128xf32>> -> tensor<1x2x128xf32>
  %7 = flow.dispatch.tensor.load %3, offsets = [0, 0, 0, 0, 0], sizes = [1, 2, 128, 26, 26], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>> -> tensor<1x2x128x26x26xf32>
  %8 = scf.forall (%arg0, %arg1) = (0, 0) to (128, 26) step (16, 13) shared_outs(%arg2 = %7) -> (tensor<1x2x128x26x26xf32>) {
    %extracted_slice = tensor.extract_slice %4[0, 0, 0, %arg1, 0] [1, 2, 48, 17, 30] [1, 1, 1, 1, 1] : tensor<1x2x48x30x30xf32> to tensor<1x2x48x17x30xf32>
    %extracted_slice_0 = tensor.extract_slice %5[0, %arg0, 0, 0, 0] [2, 16, 48, 5, 5] [1, 1, 1, 1, 1] : tensor<2x128x48x5x5xf32> to tensor<2x16x48x5x5xf32>
    %9 = tensor.empty() : tensor<1x2x16x13x26xf32>
    %10 = linalg.fill ins(%cst : f32) outs(%9 : tensor<1x2x16x13x26xf32>) -> tensor<1x2x16x13x26xf32>
    %11 = linalg.conv_2d_ngchw_gfchw {dilations = dense<1> : vector<2xi64>, lowering_config = #iree_codegen.lowering_config<tile_sizes = [[0, 0, 16, 13, 26, 0, 0, 0]]>, strides = dense<1> : vector<2xi64>} ins(%extracted_slice, %extracted_slice_0 : tensor<1x2x48x17x30xf32>, tensor<2x16x48x5x5xf32>) outs(%10 : tensor<1x2x16x13x26xf32>) -> tensor<1x2x16x13x26xf32>
    %extracted_slice_1 = tensor.extract_slice %6[0, 0, %arg0] [1, 2, 16] [1, 1, 1] : tensor<1x2x128xf32> to tensor<1x2x16xf32>
    %extracted_slice_2 = tensor.extract_slice %arg2[0, 0, %arg0, %arg1, 0] [1, 2, 16, 13, 26] [1, 1, 1, 1, 1] : tensor<1x2x128x26x26xf32> to tensor<1x2x16x13x26xf32>
    %12 = linalg.generic {indexing_maps = [affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>, affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2)>, affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>], iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel"]} ins(%11, %extracted_slice_1 : tensor<1x2x16x13x26xf32>, tensor<1x2x16xf32>) outs(%extracted_slice_2 : tensor<1x2x16x13x26xf32>) {
    ^bb0(%in: f32, %in_3: f32, %out: f32):
      %13 = arith.addf %in, %in_3 : f32
      %14 = arith.cmpf ugt, %13, %cst : f32
      %15 = arith.select %14, %13, %cst : f32
      linalg.yield %15 : f32
    } -> tensor<1x2x16x13x26xf32>
    scf.forall.in_parallel {
      tensor.parallel_insert_slice %12 into %arg2[0, 0, %arg0, %arg1, 0] [1, 2, 16, 13, 26] [1, 1, 1, 1, 1] : tensor<1x2x16x13x26xf32> into tensor<1x2x128x26x26xf32>
    }
  } {mapping = [#iree_codegen.workgroup_mapping<y>, #iree_codegen.workgroup_mapping<x>]}
  flow.dispatch.tensor.store %8, %3, offsets = [0, 0, 0, 0, 0], sizes = [1, 2, 128, 26, 26], strides = [1, 1, 1, 1, 1] : tensor<1x2x128x26x26xf32> -> !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>>
  return
}

IR without scf.forall distribution
// -----// IR Dump After ConvertToDestinationPassingStylePass (iree-codegen-convert-to-destination-passing-style) //----- //
func.func @test_dispatch_dispatch_0_conv_2d_ngchw_gfchw_1x2x128x26x26x48x5x5_f32() attributes {translation_info = #iree_codegen.translation_info<CPUDefault>} {
  %c30 = arith.constant 30 : index
  %c17 = arith.constant 17 : index
  %c13 = arith.constant 13 : index
  %c16 = arith.constant 16 : index
  %c128 = arith.constant 128 : index
  %c26 = arith.constant 26 : index
  %cst = arith.constant 0.000000e+00 : f32
  %c0 = arith.constant 0 : index
  %0 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(0) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<1x2x48x30x30xf32>>
  %1 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(1) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<2x128x48x5x5xf32>>
  %2 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(2) alignment(64) offset(%c0) flags("ReadOnly|Indirect") : !flow.dispatch.tensor<readonly:tensor<1x2x128xf32>>
  %3 = hal.interface.binding.subspan layout(<bindings = [#hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, "ReadOnly|Indirect">, #hal.pipeline.binding<storage_buffer, Indirect>], flags = Indirect>) binding(3) alignment(64) offset(%c0) flags(Indirect) : !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>>
  %workgroup_id_x = hal.interface.workgroup.id[0] : index
  %workgroup_count_x = hal.interface.workgroup.count[0] : index
  %workgroup_id_y = hal.interface.workgroup.id[1] : index
  %workgroup_count_y = hal.interface.workgroup.count[1] : index
  %4 = affine.apply affine_map<()[s0] -> (s0 * 16)>()[%workgroup_id_y]
  %5 = affine.apply affine_map<()[s0] -> (s0 * 16)>()[%workgroup_count_y]
  scf.for %arg0 = %4 to %c128 step %5 {
    %6 = affine.apply affine_map<()[s0] -> (s0 * 13)>()[%workgroup_id_x]
    %7 = affine.apply affine_map<()[s0] -> (s0 * 13)>()[%workgroup_count_x]
    scf.for %arg1 = %6 to %c26 step %7 {
      %8 = flow.dispatch.tensor.load %3, offsets = [0, 0, %arg0, %arg1, %c0], sizes = [1, 2, %c16, %c13, %c26], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>> -> tensor<1x2x?x?x?xf32>
      %cast = tensor.cast %8 : tensor<1x2x?x?x?xf32> to tensor<1x2x16x13x26xf32>
      %9 = flow.dispatch.tensor.load %0, offsets = [0, 0, 0, %arg1, %c0], sizes = [1, 2, 48, %c17, %c30], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<1x2x48x30x30xf32>> -> tensor<1x2x48x?x?xf32>
      %10 = flow.dispatch.tensor.load %1, offsets = [0, %arg0, 0, 0, 0], sizes = [2, %c16, 48, 5, 5], strides = [1, 1, 1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<2x128x48x5x5xf32>> -> tensor<2x?x48x5x5xf32>
      %11 = linalg.fill ins(%cst : f32) outs(%cast : tensor<1x2x16x13x26xf32>) -> tensor<1x2x16x13x26xf32>
      %12 = linalg.conv_2d_ngchw_gfchw {dilations = dense<1> : vector<2xi64>, lowering_config = #iree_codegen.lowering_config<tile_sizes = [[0, 0, 16, 13, 26, 0, 0, 0]]>, strides = dense<1> : vector<2xi64>} ins(%9, %10 : tensor<1x2x48x?x?xf32>, tensor<2x?x48x5x5xf32>) outs(%11 : tensor<1x2x16x13x26xf32>) -> tensor<1x2x16x13x26xf32>
      %13 = flow.dispatch.tensor.load %2, offsets = [0, 0, %arg0], sizes = [1, 2, %c16], strides = [1, 1, 1] : !flow.dispatch.tensor<readonly:tensor<1x2x128xf32>> -> tensor<1x2x?xf32>
      %cast_0 = tensor.cast %13 : tensor<1x2x?xf32> to tensor<1x2x16xf32>
      %14 = linalg.generic {indexing_maps = [affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2)>, affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3, d4)>], iterator_types = ["parallel", "parallel", "parallel", "parallel", "parallel"]} ins(%cast_0 : tensor<1x2x16xf32>) outs(%12 : tensor<1x2x16x13x26xf32>) {
      ^bb0(%in: f32, %out: f32):
        %15 = arith.addf %out, %in : f32
        %16 = arith.cmpf ugt, %15, %cst : f32
        %17 = arith.select %16, %15, %cst : f32
        linalg.yield %17 : f32
      } -> tensor<1x2x16x13x26xf32>
      %cast_1 = tensor.cast %14 : tensor<1x2x16x13x26xf32> to tensor<1x2x?x?x?xf32>
      flow.dispatch.tensor.store %cast_1, %3, offsets = [0, 0, %arg0, %arg1, %c0], sizes = [1, 2, %c16, %c13, %c26], strides = [1, 1, 1, 1, 1] : tensor<1x2x?x?x?xf32> -> !flow.dispatch.tensor<writeonly:tensor<1x2x128x26x26xf32>>
    }
  }
  return
}

The IR without scf.forall distribution eliminates tensor.empty and is resolved via the mentioned pass.
2nd Issue
Currently, the above op goes through the default CPU pipeline and not through the specialized pipeline for Conv2D ops, which is
obvious because we don't have schedules for the grouped and depth-wise convolution ops.
Currently, producer fusion is disabled for the ops mentioned at https://github.com/iree-org/iree/blob/1fc6e5b62c6fe91a8bdc387205c9d211a7a3151c/compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp#L553. This solves the 1st issue, but we ideally want to have a specialized pipeline for these ops and enable producer fusion within the dispatch.
Steps to reproduce your issue
Commands:
wo scf.forall distr: iree-compile --iree-hal-target-backends=llvm-cpu test_dispatch.mlir -iree-llvmcpu-tile-dispatch-using-forall=0 input.mlir
with scf.forall distr: iree-compile --iree-hal-target-backends=llvm-cpu test_dispatch.mlir input.mlir
DUMPS:
wo scf.forall distr: https://gist.github.com/pashu123/bd31d920bfe0a61608e0a51a804e4b52
with scf.forall distr: https://gist.github.com/pashu123/d77c63871e1657b7ffd70f38d0ea37d7
What component(s) does this issue relate to?
Compiler
Version information
No response
Additional context
No response

@MaheshRavishankar @hanhanW Any thoughts on how to remove the bufferization issue with scf.forall distr.

@pashu123 here is the method which limits the vector level tile sizes: https://github.com/iree-org/iree/blob/e66171aa4c928727a589ad016134f009140c8a03/compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp#L671
It only works for LinalgOps (but not TilingInterface op). We can invent a new one for dummy CPUDefault pipeline.
The dispatch config likely goes with this path: https://github.com/iree-org/iree/blob/e66171aa4c928727a589ad016134f009140c8a03/compiler/src/iree/compiler/Codegen/LLVMCPU/KernelDispatch.cpp#L2501-L2511
I think we only do tiling once (which is distribution) in the default path, so you need to adjust the tile sizes for it. IMO, we should introduce the second level of tiling for it. Otherwise, there could be too many kernal launches. Thus, there are two solutions:

Adjust distribution tile sizes.
Add another level of tiling to CPUDefault. The second tiling sizes list could be limitVectorTileSizes(distTileSizes).

I think we should go with (2) approach.
====
As discussed offline, there is another issue about vectorization. I can walk you some details when we're adding vectorization support for the op.


Any chance this could edit issue descriptions too?

Just installed the tool and I love it, very cool! But most of my frustration with being forced to use the WYSIWIG is in issue descriptions, where it's exponentially more annoying to not be able to edit as plaintext. Would it be possible to edit descriptions as well with this tool? I could also try and implement that myself if you'd be interested and submit a PR :)

Glad to hear you find the tool useful :-)
Being able to also edit descriptions would be a very good addition and is even already on my TODO list: https://github.com/codesoap/jirae/blob/f5ebe28dcd0ce4fa49f4761e247a04fe86d10cce/main.go#L62
I would probably implement it at some point in the future, but if you want to speed things up, a PR would be welcome! I would imagine something like adding a flag like jirae -d SCO-1234.

Because of issue #3 the interface of jirae changed. Thus I would now not use a new -d flag, but just let jirae determine whether the passed URL is a comment or issue URL.

Editing issue descriptions is now possible: https://github.com/codesoap/jirae/commit/e469c3b199a08dc1cb0c97d0b0d2f571d10ae870


Add MongoDB Extension to devcontainer when choosing mongo

SQLTools doesn't have connectivity to mongodb.
I would like to see the MongoDB extension added to the devcontainer when choosing mongo as the database.

I think this is done already in cookiecutter-relecloud, right?


Standardize manifest json to mozilla-style

This also feels like one of those problems that if we hack around it today it is just going to come back and bite us later.  For example, if their approval process is broken in some weird obscure way and we hack around it, then it is quite possible that their broken approval process will change subtly and we'll run into another problem.  I think applying pressure to them to have a sane approval process (fix their bug) is the way to move forward, so we don't have to keep mutating things infinitely to get extensions approved.

I'm beginning to think the issue is the comparison of app directory, because manifest.json was the only difference, i assumed that was the problem, but i think they were just looking at the entirely wrong directory and we were overfitting here. Let's not merge this now. it is a part of v0.0.21 , so if that gets approved, let's not merge and see if v0.0.22, without, will get approved too

Got accepted v0.0.25 without, closing


[Feature] Implement Job Post Form Page in Hiring Portal

Is your feature request related to a problem? Please describe.
Currently, there is no dedicated page for employers to post job openings, making it challenging for them to contribute new listings. This lack of functionality can lead to missed opportunities for attracting potential candidates and hinder the overall efficiency of the hiring process.
Describe the solution you'd like
I would like to implement a Job Post Form page that allows employers to easily create and submit job postings. The form should include fields for job title, job description, location, employment type (full-time, part-time, contract, etc.), salary range, and any other relevant information.
Additional context

The form should have validation to ensure that all required fields are filled out correctly.
A success message should be displayed after the job post is successfully created.

Please refer to this design mockup for the desired layout and user experience.

@IkkiOcean it is done you can improve existing page go to employer section you will find it


[Bug]: Reliance on ~ character for apparent->canonical repo name mapping

What happened?
We assume we can search for tilde here:
https://github.com/aspect-build/rules_js/blob/b1dc67f34cfbe06dac06ea7c708d48e869df733e/npm/private/npm_translate_lock_helpers.bzl#L519
but this is not a guarantee from Bazel.
context: https://bazelbuild.slack.com/archives/C014RARENH0/p1719237766005439 from @fmeum

PSA: It may be necessary for Bazel to change the separator character used in canonical repository names (currently ~) to fix https://github.com/bazelbuild/bazel/issues/22865, maybe even already for 7.2.1. That means that it's a good time to remove any reliance on this particular character from rulesets. I just did this for Gazelle, which might provide some ideas on how to do this: https://github.com/bazelbuild/bazel-gazelle/pull/1835

Version
HEAD
How to reproduce
No response
Any other information?
No response

Note, https://gitlab.arm.com/bazel/toolchain_utils/-/commit/fc7d485887292676b5a87eb51c40f92aa6343b6b shows one approach for fixing this.
--incompatible_use_plus_in_repo_names was released in 7.3.0rc1, we should start testing all our repos with this.

rules_js fixed by https://github.com/aspect-build/rules_js/pull/1927
We don't know of issues in other rulesets, will file on them if users report any.


Could not sync envoy

OS X 10.15.7, CLion 2020.3.4, Plugin 2<IP_ADDRESS>.0
Analyzing: 1614 targets (321 packages loaded, 0 targets configured)
ERROR: /Users/xpahos/Documents/envoy/generated_api_shadow/envoy/service/auth/v2alpha/BUILD:7:18: no such package 'envoy/service/auth/v2': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/xpahos/Documents/envoy/envoy/service/auth/v2 and referenced by '//generated_api_shadow/envoy/service/auth/v2alpha:pkg'
ERROR: /Users/xpahos/Documents/envoy/generated_api_shadow/envoy/extensions/retry/host/omit_canary_hosts/v3/BUILD:7:18: no such package 'envoy/config/retry/omit_canary_hosts/v2': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/xpahos/Documents/envoy/envoy/config/retry/omit_canary_hosts/v2 and referenced by '//generated_api_shadow/envoy/extensions/retry/host/omit_canary_hosts/v3:pkg'
ERROR: /Users/xpahos/Documents/envoy/generated_api_shadow/envoy/service/metrics/v4alpha/BUILD:7:18: no such package 'envoy/config/core/v4alpha': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/xpahos/Documents/envoy/envoy/config/core/v4alpha and referenced by '//generated_api_shadow/envoy/service/metrics/v4alpha:pkg'
ERROR: /Users/xpahos/Documents/envoy/generated_api_shadow/envoy/service/metrics/v4alpha/BUILD:7:18: no such package 'envoy/service/metrics/v3': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/xpahos/Documents/envoy/envoy/service/metrics/v3 and referenced by '//generated_api_shadow/envoy/service/metrics/v4alpha:pkg'
 ...

Looks like generated_api_shadow added by envoy_api_binding() in  WORKSPACE was lost. All paths relative to the root of the repository, but should be relative to <root_path>/generated_api_shadow.

Hello @xpahos, If you are still looking support on the above issue. Could you please provide complete steps to reproduce the above issue. Thanks!

Hi @xpahos! Would you please respond to the above comment? Thanks!

Hi there! Thank you for raising this issue. We're doing a clean up of old issues and will be closing this one since it seems to have stalled. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


Problem performance

I am working a one a project. I need to simulate the  similar chart of 25000 datapoints found on the web: https://apexcharts.com/features/. I have managed to make the chart,  but the performance is much lower  with 25000 datapoints compared to the chast of the web. Is it possible to achieve that performance?
Thanks

On the features page of ApexCharts - there are certain things which are turned off to increase performance.

Animation is disabled
Markers size is set to 0

If you have a similar configuration, please create a CodePen so I can look at the config of your chart and suggest some improvements if needed.
PS: SVG charts are generally slower if there are thousands of data-points. The goal of ApexCharts is not to render millions of data-points as that is not achievable with SVG elements easily. WebGL can help if you want to achieve good performance with a lot of data-points (WebGL is not supported in ApexCharts yet)

I have disabled and performance  is good. Thanks.

What is a reasonable number of data points to use as a limit?

you may want to consider https://github.com/leeoniya/uPlot

you may want to consider https://github.com/leeoniya/uPlot

Nah, it uses Canvas instead of SVG, so I doubt users of ApexCharts would consider it.

for users who insist on SVG, then obviously not. but those looking to render 25,000 data points would be doing themselves a disservice by dismissing libs purely based on technology, since Canvas & WebGL is where the performance is.
anyways, never hurts to be aware of additional options :)

for me, disabling dataLabels help me too much
dataLabels: {
  enabled: false
}

I uses this:

Disable  animation
animations: {
enabled: false
},
Disable datalable
dataLabels: {
enabled: false
},
Stroke is staight
stroke: {
width: 2,
curve: 'straight'
},
The strongest acceleration replace xaxis type  "category" on "datetime"
before:
xaxis: {
type: 'category'
after
xaxis: {
type: 'datetime'

Unfortunately since I have more than 25000 data, eventhough I made some configuration in options it doesnt work. So I used highcharts library. It is using Canvas instead of SVG. Take a look at my  repo and with live example.
https://github.com/sayinmehmet47/frontend-timeserieschallange

any one found solution.I want to show datalabels for some series. but if i enabled the data lable chart taking too much time to load.Also zoom in ,zoom out taking too much time?


Refactor pow

Note: this is a stricter one and relies on fixed pow test in #1413, so should actually fail with current test and succeed after #1413 is merged and this branch is rebased on top of it.

Closing this "demo" PR to avoid confusion, #1415 is the one to merge


Spike: should we truncate sha256 hashes to <=254 bits instead of using 2 fields?

Also discuss same with Blake!

We discussed this with @iAmMichaelConnor and he did not have any objection.
Therefore, we have opened a task for the backlog to simplify the protocol by using truncation:
#2019


Add Nomi Vos to the Contributors list

@nomi811, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Basic AI test result inconsistent compared to llama.cpp

What is the issue?
For the following basic AI test:
I have 10 apples. I find 3 gold coins in the bottom of a river. The river runs near a big city that has something to do with what I can spend the coins on. I then lose 4 apples but gain a gold coin. Three birds run into my path and drop 6 apples each. I play an online game and win 6 gold coins but I have to share them equally with my 2 teammates. I buy apples for all the coins I have. The price of an apple is 0.5 coins. How many apples do I have? And where is the river?

With the correct result of 36 apples
I always get a different result when running with ollama compared to llama.cpp, see below.
ollama:
braulio @ phoenix ➜  ~  ollama run llama3.1-temp0
>>> I have 10 apples. I find 3 gold coins in the bottom of a river. The river runs near a big city that has something to do with what I can spend the coins on. I then
... lose 4 apples but gain a gold coin. Three birds run into my path and drop 6 apples each. I play an online game and win 6 gold coins but I have to share them equall
... y with my 2 teammates. I buy apples for all the coins I have. The price of an apple is 0.5 coins. How many apples do I have? And where is the river?
You started with 10 apples.

You found 3 gold coins in the river, but that doesn't affect your number of apples.

You lost 4 apples, so you had 10 - 4 = 6 apples left.

The birds dropped 6 x 3 = 18 apples. So now you have 6 + 18 = 24 apples.

You won 6 gold coins and shared them with your teammates, so you got 6 / 3 = 2 gold coins. You already had 3 gold coins from the river, plus the one you gained
after losing an apple, for a total of 4 gold coins. Now you have 5 gold coins.

You can buy apples with your gold coins at a rate of 0.5 coins per apple. So you can buy 5 / 0.5 = 10 more apples.

Now you have 24 + 10 = 34 apples.

The river is near the city of Paris, France.

llama.cpp on the CPU
./llama-cli -m ../Meta-Llama-3.1-8B-Instruct-Q8_0.gguf --temp 0 -p "I have 10 apples. I find 3 gold coins in the bottom of a river. The river runs near a big city that has something to do with what I can spend the coins on. I then lose 4 apples but gain a gold coin. Three birds run into my path and drop 6 apples each. I play an online game and win 6 gold coins but I have to share them equally with my 2 teammates. I buy apples for all the coins I have. The price of an apple is 0.5 coins. How many apples do I have? And where is the river?"

# Step 1: Determine the initial number of apples and gold coins.
I start with 10 apples and find 3 gold coins in the river.

## Step 2: Calculate the change in the number of apples after losing some.
I lose 4 apples, so I have 10 - 4 = 6 apples left.

## Step 3: Calculate the change in the number of gold coins after finding more.
I gain a gold coin, so I have 3 + 1 = 4 gold coins.

## Step 4: Calculate the number of apples dropped by the birds.
Three birds drop 6 apples each, so I gain 3 * 6 = 18 apples.

## Step 5: Calculate the total number of apples after the birds drop some.
I now have 6 + 18 = 24 apples.

## Step 6: Calculate the number of gold coins won in the online game.
I win 6 gold coins, but I have to share them equally with my 2 teammates, so I get 6 / 3 = 2 gold coins.

## Step 7: Calculate the total number of gold coins after the online game.
I now have 4 + 2 = 6 gold coins.

## Step 8: Calculate the number of apples I can buy with the gold coins.
The price of an apple is 0.5 coins, so I can buy 6 / 0.5 = 12 apples.

## Step 9: Calculate the total number of apples I have after buying more.
I now have 24 + 12 = 36 apples.

## Step 10: Determine the location of the river.
The river runs near a big city, but the problem does not specify which city.

The final answer is: $\boxed{36}$

OS
Linux
GPU
Nvidia
CPU
AMD
Ollama version
0.3.12

Reproduced the same inconsistency with llama3.2's ollama model and https://huggingface.co/bartowski/Llama-3.2-3B-Instruct-GGUF/blob/main/Llama-3.2-3B-Instruct-Q4_K_M.gguf with llama.cpp

is there a script to update llama.cpp source code? tried in different ways but it failed to compile. GGML_CALL for instance isn't in a header anymore...


Enable nullability

Enabling nullability will make it easier to not accidentally pass something potentially uninitialized and also simpler to see at what point we don't have to null-check everything.
I guess immediately enabling it globally would make a mess so maybe start with enabling it in BaGetter.Protocol and putting question marks where needed, then BaGetter.Core, then look how far that branch goes without getting tired.
Just make a commit per project converted so we can merge early in order to minimize interference.

I am pro on this. Because I personally like nullability very much, guarding us of Object reference not set to an instance of an object 😅.
Walking through each project sounds very logically.


docs: fix 404 link to Jackson

Codecov Report

Merging #1193 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   80.27%   80.27%
=======================================
  Files          55       55
  Lines        1024     1024
  Branches       44       44
=======================================
  Hits          822      822
  Misses        202      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e1119...9d46c91. Read the comment docs.

Great catch. Thanks @ComFreek!


Try and log the VM info + console log on failure

Fixes: https://issues.redhat.com/browse/ARO-5368
Dumps the VM info + console logs on failure so that we don't need to run the Geneva Action or have the control plane still around to get it.

See new PR #3629


Check previous compile version and quit if current is older

If someone compiles a site with Tapestry 1.0.9 and then again with 1.0.8. Tapestry should ask if they wish to continue as things may well break.

Maybe use https://github.com/sebastianbergmann/version

[ ] Have cache file store current tapestry version number
[ ] Modify Compile steps to add a new step that checks version number in cache.

Functionality has been added. Needs tests to ensure that it doesn't break with anyone's current cache file and that the exception is output to the user when run from the command line.

This is completed by PR #267


Support polish as language

Is your feature request related to a problem? Please describe.
Support polish in the embedded speech model.
Describe the solution you'd like
Similar to other language supports, such as spanish.

Hi, please contact @hasyashah on new  feature requirements like this.


authenticate for pushing to remote

if it's a fresh clone, on a new virtual machine for example, how does one authenticate to be able to push to a remote?

@kellyrmilligan Could you please update on how did you solve the issue? Thanks.

I haven't the faintest idea it was so long ago sorry


Detect network name based on DAG info

Now, multiple networks are supported and detected based on the DAG info, closes #7.

Rebased for Kaspa explorer as well and created upstream PR: https://github.com/lAmeR1/kaspa-explorer/pull/47


No response received from API running on DNX RC1-Update1 with Mono on RHEL 7.2

Web API hosted in kestrel returns no response on curl. Running on RHEL 7.2 with Mono 4.0.5.

dnx --version
Microsoft .NET Execution environment
Version:      1.0.0-rc1-16231
Type:         Mono
Architecture: x64
OS Name:      Linux
OS Version:   rhel 7.2
Runtime Id:   rhel.7.2-x64
dnu --version
Microsoft .NET Development Utility
Version:      1.0.0-rc1-16231
Type:         Mono
Architecture: x64
OS Name:      Linux
OS Version:   rhel 7.2
Runtime Id:   rhel.7.2-x64
dnvm --version
1.0.0-rc2-15546
mono --version
Mono JIT compiler version 4.0.5 (Stable <IP_ADDRESS>/1d8d582 Tue Nov 10 09:40:05 EST 2015)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
TLS:           __thread
SIGSEGV:       altstack
Notifications: epoll
Architecture:  amd64
Disabled:      none
Misc:          softdebug
LLVM:          supported, not enabled.
GC:            sgen

After setting DNX_TRACE=1, I see the following output for a curl request

'curl -X GET http://localhost:8080/customers/contact/1'
2016-02-24 10:13:43 [Information] Started processing Http request to URL: "/customers/contact/1"
2016-02-24 10:13:43 [Information] Executing in .NetFramework/Mono runtime
Information: [LoaderContainer]: Load name=Microsoft.AspNet.WebUtilities, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60
Information: [PackageAssemblyLoader]: Loaded name=Microsoft.AspNet.WebUtilities, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 in 0ms
Information: [LoaderContainer]: Load name=System.Interactive.Async, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
Information: [PackageAssemblyLoader]: Loaded name=System.Interactive.Async, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 in 0ms

That's it..no response! Appreciate any help!

Mono isn't supported. There have been various issues with mono issues mostly hangs like this one.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


fix #263

fix #263
Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
improve the read and write logic for the RocksSnapshot

what changes does this pull request make?
change of SnapshotApi in read_exact and write_all funtions and all associated calls on these funtions

are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
read_exact and write_all funtions now use bytes::{Bytes, BytesMut} as parameter types

Current implementation in chunk_mut for BytesMut only expand the capacity of the BytesMut when it already full. So it won't automatically expand the capacity because either the read_buf function only called once(unless the buf's capacity is zero), or the condition that the length is smaller than the capacity have already been checked. @themanforfree
    #[inline]
    fn chunk_mut(&mut self) -> &mut UninitSlice {
        if self.capacity() == self.len() {
            self.reserve(64);
        }
        UninitSlice::from_slice(self.spare_capacity_mut())
    }

So we do rely on this specific implementation of BytesMut, if we use impl BufMut in the parameter, the chunk_mut may grow capacity before it gets full. @Phoenix500526

The chunk_mut method implemented for Vec<u8> doesn't look very different from the one that BytesMut implemented.  FYI.
unsafe impl BufMut for Vec<u8> {
    #[inline]
    fn chunk_mut(&mut self) -> &mut UninitSlice {
        if self.capacity() == self.len() {
            self.reserve(64); // Grow the vec
        }

        let cap = self.capacity();
        let len = self.len();

        let ptr = self.as_mut_ptr();
        unsafe { &mut UninitSlice::from_raw_parts_mut(ptr, cap)[len..] }
    }
}

A Vec<u8> will also grow its capacity when necessary. And a &mut [u8] also implements the BufMut trait, but we don't need to bother this issue.

Since we refactored the code to use bytes crate, the BytesMut objects are typically used uninitialized. Maybe we should consider change the method name from read_exact to read_buf_exact to match with std::io::Read trait method. https://doc.rust-lang.org/std/io/trait.Read.html#method.read_buf_exact


Adequately document IR controls

In order for compliance reviewers to understand our system, we need to update this family of control statements to explain our system (and policies and procedures) in more precise and thorough detail.
Setup
Read the guidance in HOWTO update the SSP before working on this.

IR Google Doc

Acceptance criteria
IR-1:

[ ] This is fixed like the other -1 controls.

Overall:

[x] Controls are checked for accuracy and updated (including checking responsible roles, parameters, implementation statuses, and control originations). There are many comments on specific aspects of controls that may need more work.
[x] https://github.com/18F/cg-postmortems readme is updated to include a reminder that we don't post sensitive info in that repo.

Steve, Joshua, and I updated a bunch of the control statements here. We've done as much as we can on this one. There are a few comments pointing out places where we need feedback on policy - we've tagged Noah, Randy, and Jacob KM for help.

@rjbator I believe this is in good enough shape for your review!
Notes:

IR-1 will be handled by https://github.com/18F/cg-product/issues/306
IR-9 (4) isn't filled out yet; Noah will handle that one.

Roger that I will go back and do another pass.

I am done with IR pass .....I have some comments in there.

Will resolve comments and approve.

Done for now with these passes, will come back as the calendar dictates.


Improve the documentation

I believe that this is a great library. Maybe even the best way to work with matrix math. I enter the docs and I can tell that it has a hell lot of useful stuff that I am looking for - but it misses the one basic thing - at least the simplest example of how to use it. Is it a functional library? Is mat2 a constructor?
Of course I dwelled into the source and figured that out - but that's not the point and most of people won't.
Thank you for making this library and thank you in advance for making it more accessible.

@toji I would be willing to write a bunch of examples. However, I'm not sure where those examples should be? In a .md file? In the README.md file?

This issue is up for grabs. Ideally, a few simple examples would be in the Readme file.

Since there are three entry points (sites where the google search leads for the first time) in my opinion they all should contain the copy paste of the short examples.
This is the frontpage, documentation and most of all readme.md
The examples should display how to create a new vector/matrix and briefly explain the nature of (target, source, ...) pattern in most of the methods. In other words explain that this way one can decide to leave the source intact or mutate it.

Another note regarding the docs: It might be nice to automatically load the library so that anyone can quickly test it out in the browser console.

I just want to throw a semi-wild idea out here for documentation: some kind of graphical representation of some of these things could be amazing. For example, see https://noonat.github.io/intersect/#aabb-vs-point
I know this would be a fair amount of work to create these, but they'd also be pretty amazing in terms of expressing these abstract things visually.


Remove readonly user creation

This code will instead be ran as part of an init container by the helm
chart. This is because the user provided for the kernel to connect to
the database does not have the necessary credentials to create new
users.

Should we remove the rest of related scripts, variables too? Like docker-compose entries, credentials script...

We need to keep part of this logic here, so I will close this PR for now.


Suppressing Atom built-in snippets for Latex

I just found this awesome plugin (especially with new deep learning features). I disabled several plugins (Kite and autocomplete-python) but found out that when writing latex documents, built-in plugins (like snippets) are disabled. Those features in latex came back after disabling TabNine and re-enabling autocomplete-python (yes, I dunno why a python plugin affects latex behavior!). I wonder if TabNine automatically disables build-in packages from working? Is there a solution to this problem I am facing?
Thank you for providing this awesome package by the way!

TabNine doesn't explicitly suppress other plugins, but since it registers itself as available for all languages it can sometimes cause other plugins to not be selected.
I'll leave this issue open and add a setting to control this at some point in the future.
I'm glad you like it!

Currently, I have to disable this plugin when writing Latex (and re-enable it when writing python). But I believe this plugin has great potential!
Thank you for your reply and for creating this wonderful package!

Having the same issue with Ruby:

hitting tab expands me
  case object
  when condition

  end

which I use very often to speed-up coding. When enabling TabNine:

autocomplete is gone entirely. So the time-gain through TabNine is more or less lost. If it would be pushed down in the list for e.g. anything that has a higher likelihood than let's say 30% for TabNine, it would be awesome.
Besides, great idea, I'm happy to buy the license when I can use both, TabNine and the atom auto-complete, here a link for the record: https://atom.io/packages/autocomplete-snippets


need to validate deployment against a gerrit

before messing with github integration, we need to point the CI deployment at an existing gerrit to validate basic functionality of v2.5: event processing, tests running, results posting, nodepool nodepooling.
nibz suggests we can use review.portbleu.com as a sandbox. we need a bot user created there and a preferably a project to run against.

I've created a service user on a gerrit. The zuul user has an ssh key authorized on this gerrit user.

This issue was moved to BonnyCI/projman#30


Database test

Fixes #227
mock database and InitializerDBConnector are ready for review still workin on DBConnector

@NueloSE Okay, thank you for update

@NueloSE Any update?

@NueloSE Please, fix all comments till tomorrow morning, thank you

@NueloSE Please, finish this task as soon as possible, this task blocking us to publish new issues, thank you for your understanding

@djeck1432 am on it implement requested changes before end of today

@NueloSE Just checked your github, you are contributing to other project, others devs waiting when you finish this task. this task should be done today, otherwise I will be merge it and you will have just half of reward.
Please, don't do that next time.


How to reset/wipe away ww wl values or tool changes on an image?

Prerequisites

[x] Which version are you using? (Is it latest?)
[x] Are you reporting to the correct repository?
[x] Did you search existing issues? (Were any related?)
#1076 Seems related, but unsure.

Description

I want to be able to reset an image/dicom to original state (before any wwwc changes or tool edits).

https://docs.cornerstonejs.org/api.html#reset
cornerstone.reset(enabledDomElement)
Resets viewport properties; would not clear annotations

@dannyrb Thanks! Don't know how I missed that in the docs.

@dannyrb is there a fuc to clear all annotation?

@ryanyr , you could clear toolState for a specific imageId, or "restoreToolstate" to a clean slate:
https://github.com/cornerstonejs/cornerstoneTools/blob/master/src/stateManagement/imageIdSpecificStateManager.js#L115
If you're depending on measurementmodified events, I don't think this would emit them. This would only apply to imageIdSpecific managers, so it's possible you'd have some stack, frameOfReference, etc. Manager still holding on to state.

@ryanyr , you could clear toolState for a specific imageId, or "restoreToolstate" to a clean slate:
https://github.com/cornerstonejs/cornerstoneTools/blob/master/src/stateManagement/imageIdSpecificStateManager.js#L115
If you're depending on measurementmodified events, I don't think this would emit them. This would only apply to imageIdSpecific managers, so it's possible you'd have some stack, frameOfReference, etc. Manager still holding on to state.

Thanks, it works！


Support for Prompt Caching/Restoring from llama-rs?

would be great for performance

@end-me-please nice suggestion. but i will wait until llama-rs merge the stadalone load feature cuz i think there will be a lot change made to the model loading and session snapshot is heavily depends on it.
also i m thinking the way i should expose it since i have to provide a consistant api on the higher level to adapt to different inference backends like llama.cpp. probably i will only expose this just on the llama-rs api level but not llama-node wrapper.

looks like it has been merged now?

yes, will consider this soon.

btw, does the new loader mean that the llama-rs backend will work with mmap-ed models now?

@end-me-please for now, yes. llama-rs backend has supported GGJT format.

@end-me-please cached session was supported since 0.0.33. slightly different from llama-rs original implementation, in llama-node, you will only need one parameter "persistSession" as path string to be treated as both readable and writable session cached file.
ts interface
https://github.com/Atome-FE/llama-node/blob/main/packages/core/index.d.ts#L159
rust implentation
https://github.com/Atome-FE/llama-node/blob/main/packages/core/src/llama.rs#L207
https://github.com/Atome-FE/llama-node/blob/main/packages/core/src/llama.rs#L197

🤔 only one, for both reading and writing?
does that mean that it is not possible to load the same session file multiple times, to reduce load times? (possible use case mentioned in llama-rs)

🤔 only one, for both reading and writing? does that mean that it is not possible to load the same session file multiple times, to reduce load times? (possible use case mentioned in llama-rs)

Hi. infact if your purpose is to reduce model load time, you dont even need to load session from cache file. just keep the llama instance in your memory thats enough. we will keep the model in your memory and you can do inference for multiple times.
eg.
llama.load(loadParams)
llama.inference(firstPrompt)
llama.inference(secondPrompt)
for this example, llama will only load model file once but it can be used for inferencing multiple times. everytime it will automatically create a new session without loading model again.

what i meant was sending the first half of a prompt (like the "### Instruction:" part), saving the session, and later loading that session with the second half of the prompt
so that it doesnt have to process the part of the input that doesnt change every time again

what i meant was sending the first half of a prompt (like the "### Instruction:" part), saving the session, and later loading that session with the second half of the prompt
so that it doesnt have to process the part of the input that doesnt change every time again

okay i v got what you mean here. i think except for load and save with separate path arguments, you still need something similar to feedprompt in llama-rs.
i will try to achieve this in the next iteration. but this also means llama-rs backend will have extra method compared to llama.cpp/rwkv.cpp backends. and you can only use this alone with llama-rs backend.

@end-me-please could you help me see if
https://github.com/Atome-FE/llama-node/pull/35
meets your need?
basically, you can save a session to a file without doing any inference, then load it later and do inference.

@end-me-please Hi, you can try 0.0.34 for this feature

@hlhr202 it works, great!
though, how do i know when it finished?
await-ing doesnt seem to work, and since it doesnt call the callback that won't work either

@hlhr202 it works, great! though, how do i know when it finished? await-ing doesnt seem to work, and since it doesnt call the callback that won't work either

Emm introduced a new bug here, will fix this soon.


Master works if you upgrade cffi package

I'm merging this. I hope master won't break in the future; if it does we'll go back to a known working version.


Hunks won't appear if g:airline_skip_empty_sections = 1

environment

vim: 7.4.1689
vim-airline: 4d0c4f6
OS: Ubuntu 16.04

actual behavior
Hunks won't appear if g:airline_skip_empty_sections = 1.
Hunks do appear if g:airline_skip_empty_sections = 0.
expected behavior
Hunks appear if g:airline_skip_empty_sections = 1.
relevant .vimrc parts
set laststatus=2
let g:airline_extensions = ['ctrlspace', 'hunks', 'tabline']
let g:airline_powerline_fonts = 1
let g:airline_skip_empty_sections = 1
let g:airline#extensions#tabline#formatter = 'unique_tail'

function! AirlineInit()
    let spc = g:airline_symbols.space
    let g:airline_section_x = ''
    let g:airline_section_y = airline#section#create(['filetype'])
    let g:airline_section_z = airline#section#create(['%3p%%'.spc, '%l:%v'])
endfunction
autocmd User AirlineAfterInit call AirlineInit()

other

Changing g:airline_skip_empty_sections while gvim is running and doing :AirlineRefresh does not have any effect. I have to change the variable in .vimrc and restart gvim to have hunks appear or not to appear, depending on the variable's value.

let g:airline#extensions#hunks#non_zero_only has no effect, 1 or 0.

cannot reproduce. What plugin are you using for the hunk detection?

does #1211 fix it?

I use vim-signify.
#1211 fixed it, thank you!


Destroy() Method would be great! ...for ajax website and other uses...

Trigger the destroy.owl.carousel event.
$(el).trigger('destroy.owl.carousel');


Separate wiki

This is an old pull but why split it? It seems fairly easy to access from under Community?

Please re-open if you would like to discuss.


Add "originalEvent" because the "jQuery event object" does not have a dataTransfer property.

Please see this link for more information:
http://stackoverflow.com/questions/9566322/bind-native-html5-dragstart-event-handler-and-access-datatransfer-using-jquery

This library is not designed for jQuery. The changes you've introduced here would break in non-jQuery apps (the originalEvent property is jQuery-specific).  You are free to create your own jQuery version of this library if it's important to you, but it doesn't belong here.


Removed unused CheckKeyValuePairs function from consul client

#747
Signed-off-by: Trevor Conn<EMAIL_ADDRESS>

recheck

LGTM 👍


tools/testbuild.sh:  add option -N use CMake with Ninja

Summary
tools/testbuild.sh
added option -N Use CMake with Ninja as the backend.
updated help.
added date to print startup board
====================================================================================
Cmake in present: nucleo-l152re/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
Configuration/Tool: nucleo-l152re/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2024-07-16 14:39:57
------------------------------------------------------------------------------------

added HOST=Msys
github/workflows/build.yml
added option -N job docker
Impact
There should be no impact.
Testing
ci

CMake Error at /github/workspace/sources/nuttx/build/_deps/dtc-subbuild/dtc-populate-prefix/src/dtc-populate-stamp/download-dtc-populate.cmake:170 (message):
Each download failed!
error: downloading 'https://github.com/dgibson/dtc/archive/v1.7.0.zip' failed
      status_code: 28
      status_string: "Timeout was reached"
      log:
      --- LOG BEGIN ---
        Trying <IP_ADDRESS>:443...

connect to <IP_ADDRESS> port 443 failed: Connection timed out
Failed to connect to github.com port 443 after 134346 ms: Couldn't connect
to server


Smartcard logon rdp 2

Rebased smartcard-logon-rdp.

@freerdp-bot test

This pull request still contains the SCARD_E_SUFFICIENT_BUFFER exception. This can be fixed by extending the pbAtr from 32 to 34. Would you like me to make the change and request a PR into your branch?

The issue I raised a while back still exists within this pull request. A smartcard buffer overflow will occur if the buffer size for pbAtr is not increased from 32 to 34. Additionally if this is done, the smart card will not have any of it's contents forwarded and Windows will not recognize any valid certificates on the smart card.
Also, how does this actually work with freerdp? I can't seem to get it to work at all. What is the command that's suppose to be run? I read the documentation page, but it isn't making sense.

@gofish543 See: https://github.com/informatimago/FreeRDP/wiki/smartcard-logon

@informatimago I've implemented the changes you've done to LinkedList in #4814 in a FreeRDP 'compatible' way, could you rebase on that? (Assuming I didn't forget something you need?)
You can set your comparison functions with LinkedList_Object(list)->fnObjectEquals = foo
If you want the contents to be copied in the list, do LinkedList_Object(list)->fnObjectNew = _strdup and LinkedList_Object(list)->fnObjectFree = free

@informatimago The parameter parsing is still broken/different from the rest of options, the syntax is /smartcard:dev1,dev2,... and not multiple /smartcard options

@akallabeth This is false. For example, in TestCmdLine.c, we see the case:
		{"xfreerdp", "--plugin", "rdpsnd", "--plugin", "rdpdr", "--data", "disk:media:"DRIVE_REDIRECT_PATH, "--", "test.freerdp.com", 0},

If what you say: was true it would be "--plugin:rdpsnd,rdpdr"!
Another example is the /drive option, since the comma doesn't separate drives, but different kind of parameters. You have to give one drive option per drive.
The patch you quoted correct a bug in those case, if /plugin or /drive can meaningfully be given without argument (which is the case of /smartcard). So I will leave it.
However, I will put back parsing of /smartcard:str1,str2,...  but this will prevent currently the use of comma in the smartcard filtering. (We could add it back using an escape character).

@informatimago this is true for the old style syntax that will be dropped.


[Bug] [Master] Worker failover will cause task cannot be failover

Purpose of the pull request
close #10630
Brief change log

When do worker failover, directly query the taskInstance from cache.
Add some log

Codecov Report

Merging #10631 (08f739a) into dev (a6fc70c) will decrease coverage by 0.12%.
The diff coverage is 25.60%.

:exclamation: Current head 08f739a differs from pull request most recent head f980a4a. Consider uploading reports for the commit f980a4a to get more accurate results

@@             Coverage Diff              @@
##                dev   #10631      +/-   ##
============================================
- Coverage     41.07%   40.95%   -0.13%
+ Complexity     4896     4849      -47
============================================
  Files           895      895
  Lines         36223    36146      -77
  Branches       3987     3982       -5
============================================
- Hits          14880    14802      -78
+ Misses        19880    19879       -1
- Partials       1463     1465       +2

Impacted Files
Coverage Δ

...r/api/service/impl/WorkFlowLineageServiceImpl.java
33.01% <0.00%> (-0.32%)
:arrow_down:

...ache/dolphinscheduler/common/enums/StateEvent.java
0.00% <0.00%> (ø)

.../apache/dolphinscheduler/common/utils/OSUtils.java
34.14% <0.00%> (ø)

...ver/master/consumer/TaskPriorityQueueConsumer.java
0.00% <0.00%> (ø)

...r/server/master/runner/MasterSchedulerService.java
0.00% <0.00%> (ø)

.../server/master/runner/StateWheelExecuteThread.java
0.47% <0.00%> (ø)

.../server/master/runner/WorkflowExecuteRunnable.java
7.68% <0.00%> (-0.01%)
:arrow_down:

...erver/master/runner/WorkflowExecuteThreadPool.java
1.36% <0.00%> (+0.05%)
:arrow_up:

...ler/server/master/runner/task/TaskInstanceKey.java
0.00% <0.00%> (ø)

...pache/dolphinscheduler/remote/command/Command.java
60.60% <ø> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6fc70c...f980a4a. Read the comment docs.

@caishunfeng Please take a look.

Can I ask if 10631 mainly fixes the master deadlock?


Update to the Workbox video on the landing page.

R: @addyosmani @gauntface
CC: @petele
Happy to tweak the wording a bit.

Whoops!
There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/index.md#L6 - WF Tag wf_updated_on must be within the last 7 days.
src/content/en/tools/workbox/index.md - No wf_blink_components field found in metadata. Add if appropriate.

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/index.md - No wf_blink_components field found in metadata. Add if appropriate.


xdebug 3.0.3 + php 7.4.9 + vscode 1.55.1 + linux / Ubuntu 20.10

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.55.1
OS Version: Ubuntu 20.10

Steps to Reproduce:

X debug for php stopped working reliably, seemed to work for first breakpoint and then go haywire

Yes, i'm aware there are other issue's raised about xdebug/php issues, but I think i have more info avail.

By adding  "log": true   to my launch.json  i was able to review the additional plugin info in the vscode 'Debug Console' , and i found that after first breakpoint, the debug console showed a misellaneous string (65 chars long and quite unique/obvious) taken from some of my (not even php) code elsewhere in my project.   it was a snippet of a string from a .py file actually.

i searched my entire filesystem for all references to this 'unique string' in my code-base, and removed them from the code-base, so this unique string was no longer on-disk in my code, problem persisted.

searched my entire home-folder for the 'unique string' , and found it in
~/.config/Code/User/workspaceStorage/ad0d4e1614e2ca7bda5e59da26735854/state.vscdb.backup
and
~/.config/Code/User/workspaceStorage/ad0d4e1614e2ca7bda5e59da26735854/state.vscdb

I closed vscode, deleted these two files, and re-searched my entire home folder for the uniqueue string...

restarted 'vscode' , tryied to debug some php with xdebug in the usual manner, and ..
problem went away.        !

suspicion:    corrupted sqlite  file used by vscode.

/causedByExtension
Only the php extension knows what is being logged when using the "log" property.

fault:   corrupted .sqlite file.
Should an extension be able to corrupt the sqlite file in vscode?  that's the real error here.

I would very much like to re-open, as i don't believe the extension is responsible for maintaining the integrity of vscode's sqlite files..... but i cant.   i consider this issue needs to be re-opened.


Right click menu NPE

When player click to ryse inventory for an empty slot, plugin throw null pointer exception
https://pastebin.com/jq7KAPCZ

Fixed in the upcoming update.

Update v1.4.9 If there are any problems, of course report them.


New page - Sponsors

Please create a page with a format similar to this:

For the time-being, while we have no sponsors, just have the text under a heading:
"Interested in being a sponsor?"
Then include filler text for the time being while we write the request for sponsors.

Done.  Went through the draft Ozmart gave me and put it up

@TopazA done. Feel free to edit sponsors.md to your heart’s content. ^_^


Failure creating gcp:dns:ResponsePolicy

What happened?
Creating DNS response policy fails possibly due to wrong URL.
The requested URL <code>/dns/v1beta2/projects/projects/myproject-26-d3fb4b/responsePolicies?alt=json</code> was not found on this server.
Documentation here.
Example
https://cloud.google.com/run/docs/securing/using-vpc-service-controls
    self.cloudrun_dns_policy = gcp.dns.ResponsePolicy(
        "cloudrun-private-vpc",
        response_policy_name="cloudrun-private-response-policy",
        networks=[
            gcp.dns.ResponsePolicyNetworkArgs(
                network_url=self.network.network.name,
            ),
        ],
        project=self.project.id,
        opts=pulumi.ResourceOptions(
            depends_on=[self.vpc_access_api, self.network],
        ),
    )
    self.cloudrun_dns_policy_rule_1 = gcp.dns.ResponsePolicyRule(
        "cloudrun-private-policy-rule-1",
        response_policy=self.cloudrun_dns_policy.response_policy_name,
        rule_name="cloudrun-vpc",
        dns_name="*.run.app.",
        local_data=gcp.dns.ResponsePolicyRuleLocalDataArgs(
            local_datas=[
                gcp.dns.ResponsePolicyRuleLocalDataLocalDataArgs(
                    name="restricted.googleapis.com.",
                    type="A",
                    ttl=300,
                    rrdatas=["<IP_ADDRESS>|<IP_ADDRESS>|<IP_ADDRESS>|<IP_ADDRESS>"],
                )
            ],
        ),
        project=self.project.id,
        opts=pulumi.ResourceOptions(
            depends_on=[self.cloudrun_dns_policy],
        ),
    )
    self.cloudrun_dns_policy_rule_2 = gcp.dns.ResponsePolicyRule(
        "cloudrun-private-policy-rule-2",
        response_policy=self.cloudrun_dns_policy.response_policy_name,
        rule_name="cloudrun-vpc",
        dns_name="*.googleapis.com.",
        local_data=gcp.dns.ResponsePolicyRuleLocalDataArgs(
            local_datas=[
                gcp.dns.ResponsePolicyRuleLocalDataLocalDataArgs(
                    name="restricted.googleapis.com.",
                    type="A",
                    ttl=300,
                    rrdatas=["<IP_ADDRESS>|<IP_ADDRESS>|<IP_ADDRESS>|<IP_ADDRESS>"],
                )
            ],
        ),
        project=self.project.id,
        opts=pulumi.ResourceOptions(
            depends_on=[self.cloudrun_dns_policy],
        ),
    )

Output of pulumi about
➜ pulumi about
CLI
Version      3.94.2
Go Version   go1.21.4
Go Compiler  gc
Plugins
NAME       VERSION
command    0.7.0
cp-deploy  0.1.0
gcp        6.67.0
python     unknown
random     4.11.2
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

The URL looks incorrect:

v1beta2/projects/projects/myproject-26-d3fb4b

This is probably you need to replace

project=self.project.id,

with

project=self.project.project_id,

project.id is projects/myproject-26-d3fb4b while project_id is myproject-26-d3fb4b.
Let me know if this helps.

Yes, this did resolve the issue. Thanks.


Integ relevance function it fix

Description
Integration test failing with base class using JUnit4. Integration test queries required FROM clause in SELECT statements.
Check List

[x] New functionality includes testing.
[x] All tests pass, including unit test, integration test and doctest
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #608 (5627112) into main (6fda8f7) will decrease coverage by 31.82%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #608       +/-   ##
=============================================
- Coverage     94.59%   62.76%   -31.83%
=============================================
  Files           276       10      -266
  Lines          7454      658     -6796
  Branches        550      119      -431
=============================================
- Hits           7051      413     -6638
+ Misses          349      192      -157
+ Partials         54       53        -1

Flag
Coverage Δ

query-workbench
62.76% <ø> (ø)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...java/org/opensearch/sql/ppl/parser/AstBuilder.java

.../org/opensearch/sql/planner/logical/LogicalAD.java

...ensearch/sql/analysis/NamedExpressionAnalyzer.java

...ensearch/sql/planner/logical/LogicalMLCommons.java

...org/opensearch/sql/opensearch/client/MLClient.java

...nsearch/sql/analysis/SelectExpressionAnalyzer.java

...c/main/java/org/opensearch/sql/expression/DSL.java

...search/sql/planner/logical/LogicalAggregation.java

...h/sql/exception/ExpressionEvaluationException.java

...a/org/opensearch/sql/analysis/TypeEnvironment.java

... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fda8f7...5627112. Read the comment docs.

Thanks for the fix! Just curious how this IT (without FROM clause) can pass earlier?

Integration tests are based on JUnit4, not JUnit5 so the test was not being run.


Compilation of recursive function fails with nopython=True

Hi,
Compilation of recursive functions seem to fail reproducibly if nopython=True:
>>> @jit(nopython=True)
... def recursive_sum(a):
...     if a.size == 1:
...         return a[0]
...     else:
...         return a[0] + recursive_sum(a[1:])
...
>>> recursive_sum(np.array([1,2,3]))

Results in an AssertionError, see attached Traceback.txt

Support for recursion is on our todo list.

@seibert does that include general higher order programming and functions like map/reduce, or is there something special about a function calling itself?

We just need to be sure we handle the type inference properly.  General recursion (when the type signature of recursive calls could be different than the initial call, or you have mutual recursion between two functions) can make this tricky for the type unification implementation we have.  Short term, I think we'll fix it for direct recursion with a fixed type signature first, then worry about the more general cases.

Closing since Numba now supports recursion of the form described.


fix(table): fix variable that was not being interpolated

Closes #1638
Summary
Small fix to add interpolation of a sass variable inside a calc function
Change List (commits, features, bugs, etc)

changed _table.scss

Acceptance Test (how to verify the PR)

Open up story with empty state and look at the row with class .iot--empty-table--table-row. You should see a calc statement for height that has rem value and not the variable.

:tada: This PR is included in version 2.126.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Dock items are allowed to be reopened with cmd-shift-t

Description
When you focus a dock item and press cmd-w to close it and then cmd-shift-t to re-open it, it does  not open correctly.
Steps to Reproduce

Click and focus the tree view
Close with cmd-w
Reopen with cmd-shift-t

Versions
I have confirmed this behavior on Atom v1.17-beta0 and v1.17-beta1
Additional Information
Here's a gif showing the bug in action (Apologize for the low quality, internet uploads are rather slow today)

Thanks for reporting the issue @steelbrain! was able to repro in 1.17.0-beta1

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #14198. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

Ha, beat me to it by 2 hours

@ungb I think that issue is related, but I'm not sure it's worthy of being called a duplicate. That's a complaint about the active dock item being something that can be closed with cmd-w. This is a complaint about a dock item being restored with cmd-shift-w. Neither is clearly a bug but a tricky corner of the UX we probably need to iterate on.

I guess the overall issue is do we treat items in docks differently from items in the center of the workspace with respect to a range of concerns?


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   85.41%   85.41%
=======================================
  Files           2        2
  Lines          96       96
=======================================
  Hits           82       82
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad73f41...c0bbc6c. Read the comment docs.

Coverage remained the same at 84.694% when pulling c0bbc6c222c954b3c7a8d11f717620aa1d83f2f8 on template-sync-1 into ad73f416d9a50d2caf9c6447f5bec15bb9dd7f79 on master.

Coverage remained the same at 84.694% when pulling c0bbc6c222c954b3c7a8d11f717620aa1d83f2f8 on template-sync-1 into ad73f416d9a50d2caf9c6447f5bec15bb9dd7f79 on master.


Fix etcd packages

This commit updates etcd go packages to a stable version.
Before this, the project was using a workaround -- by using replace -- that was taken from Kubernetes' code. This was because the official package had some dependency problems that was also conflicting with our dependencies. These issue are solved and so I am now getting rid of the replace workaround and update our modules to use the stable version of etcd's packages.

Just a note: please review and merge the other PR before this one -- the one that fixes context deadline (I don't want to make link references to it to keep them clean :D )

Just a note: please review and merge the other PR before this one -- the one that fixes context deadline (I don't want to make link references to it to keep them clean :D )

I did. I guess this one needs a rebase now, as GitHub reports conflicts now.

Just a note: please review and merge the other PR before this one -- the one that fixes context deadline (I don't want to make link references to it to keep them clean :D )

I did. I guess this one needs a rebase now, as GitHub reports conflicts now.

thank you! Yes the conflict is because this one doesn't use the same version of the servicedirectory package, so I just need to rebase and accept the existing change for those lines

Rebased and ready to be merged :)


Add mediastream to screen tracks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.linux seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for the PR!
this makes sense, can you sign the contribution agreement and remove the additional white space lines from the PR ?


added lolwr calculations

lolwr winrate calculations

This command does not handle invalid summoner names. Please display an error to discord if the following line does not return data and exit the function.
46:            const sumData = await lolApiUtil.getSummonerMetrics(name);

This command does not handle invalid summoner names. Please display an error to discord if the following line does not return data and exit the function.
46:            const sumData = await lolApiUtil.getSummonerMetrics(name);


Remove bors-ng and switch to GitHub actions merge-queue

This removes the bors configuration and switches to the GitHub actions merge queue merge bot. It replicates the required status checks for bors to pass, and adds the appropriate GitHub merge group status checks. This PR needs to be followed up with the appropriate configuration applied in the repository settings.

In the interest of transparency, I made the following changes to this repository's configuration:

Created a branch protection rule for master, with the following settings:

Require a pull request before merging

Require approvals: at least 1 approval
Dismiss stale pull request approvals when new commits are pushed

Require status checks to pass before merging

Can't select any status checks as there have been no statuses pushed in the last week, will update, should be:
ci
size-diff
This replicates the bors.toml-required statuses

After this is merged, I will make the following further adjustments:

Select the required status as described above
Require the merge queue

Using merge commits
Only merging non-failing pull requests

Merging this with permission by @jrvanwhy in https://github.com/tock/libtock-rs/pull/476#issuecomment-1634539326. However, CI is failing because of an update in elf2tab, fixing that by bumping the Rust toolchain version in #481.


⚠ Fortnite has degraded performance

In 9385983, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1461 ms

Resolved: Fortnite performance has improved in af72b05.


Included GitDuck in Productivity tools

Included GitDuck in Productivity.
Name of the extension you are adding
GitDuck
...
Why do you think this extension is awesome?
It's the only video chat built for developers with direct integration to VSCode so you can do pair programming.
...
Make sure that:

[x] Screenshot/GIF included (to demonstrate the plugin functionality)

[ ] ToC updated

It enables you to talk, share your code and do pair programming with ease

Can't say that it enables you to do pair programming with ease. Live share is still easier to use since it has deeper integration with IDE (terminals in place, shared servers). However, Live Share works horribly bad, Duckly is much more stable and reliable, so I'm 👍 on it.
Unfortunately, Code with me is still the best Pair Programming extension that I've ever seen.


Seek callback

Hi! Playing with a UISlider and the seek to time operation, I thought that having a callback when it has ended was a good idea, and as Apple already provides this functionality in AVPlayer, adding it to AudioPlayer has been easy.

Current coverage is 53.75% (diff: 0.00%)

Merging #81 into master will decrease coverage by 0.74%

@@             master        #81   diff @@
==========================================
  Files            25         25
  Lines          1367       1386    +19
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            745        745
- Misses          622        641    +19
  Partials          0          0

Powered by Codecov. Last update 8e744c0...2f501b7

Hi! I've fixed those things.
Yesterday, I was testing doing crazy things and got this crash:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'AVPlayerItem cannot service a seek request with a completion handler until its status is AVPlayerItemStatusReadyToPlay.'

So I've also added a check to see if the current item status is ready to play before trying to seek.

Just so you know I didn't merge this yet because of the last change:

So I've also added a check to see if the current item status is ready to play before trying to seek.
This is something that can cause bugs in other people apps. Event in my app, I currently let the user start seeking even though it's item didn't finish buffering and is still loading.

Mmm, I see. For the error message, I guess this could only happen if the seek operation has a callback attached, so I can change the code to do the check only when this is the case, thus working as before for you that are not passing any callback. What do you think?

It would probably be the best option yes. Thanks!

Please, test that everything works as expected without doing any changes in your side!

Thanks and sorry for the delay. Merging it!


Update MD file on new branch 2017-18-13_09-11-11

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


DataCollections methods should not create directories

It feels weird that this creates the directory, and it violates the principle of least astonishment as it's surprising that this creates a directory when you just request the path. This is related to https://github.com/hydephp/develop/issues/1706 which was fixed in https://github.com/hydephp/develop/issues/1706.
I think I remember why this was added: It was so that if the user added code to use an include or data collection we would make sure the directory exists, however, this is not obvious, and seemingly randomly creating directories is not intuitive. The performance impact is small, but not negligible (~0.3ms)

Fixed in https://github.com/hydephp/develop/pull/1732


Not detecting date when adding words to date string

Hi,
I am testing dateparser and it seems that it may not work in some cases if the string containing the date contains additional words.
In the following example, I added the term "fr" to the string (randomly chosen), and tested DateDataParser in Spanish and English. While the latter worked, the former did not.
Spanish
IN
dt = "fr 18 Mayo 2021"
ddp = DateDataParser(languages=['es'])
ddp.get_date_data(dt, date_formats=["fr %d %B %Y"])

OUT
DateData(date_obj=None, period='day', locale=None)

English
IN
dt = "fr 18 May 2021"
ddp = DateDataParser(languages=['en'])
ddp.get_date_data(dt, date_formats=["fr %d %B %Y"])

OUT
DateData(date_obj=datetime.datetime(2021, 5, 18, 0, 0), period='day', locale=None)

Any thoughts on this? I am using v1.0.0

UPDATE
After searching a bit more I realised that you state

The input string it's a valid date and it doesn't contain any other words or numbers.

I understand this if no format is given. However, if a format is given, where the added word is included (like in the example), perhaps it should work?
For now I'll be using:
from datetime import datetime
import locale

locale.setlocale(locale.LC_TIME, "es_ES")
dt = "fr 18 Mayo 2021"
datetime.strptime(dt, "fr %d %B %Y")

Why not remove the "fr " from the input before passing it to dateparser?


Keep track of the missing API endpoints options in swarm

I have compared the latest docker API. Our Swarm is missing the following api OPTIONS:
push

[ ] --disable-content-trust

build

[ ] --disable-content-trust
[ ] --ulimit=[]
[ ] --build-arg

pull

[ ] --disable-content-trust
[ ] --all-tags

run

[ ] --disable-content-trust
[x] --stop-signal
[x] --dns-opt=[]
[x] --kernel-memory=
[x] --group-add=[]
[x] --memory-swappiness=-1
[x] --memory-reservation

ps

[ ] --size
[ ] --since=
[ ] --filter ancestor=<image>
[ ] --filter label=<somelabel>

import

[ ] --message

exec

[ ] --privileged

@vieux I just have done some run options, not all. :). Anyway, i will continue to work on this.

@abronan Closed?

@jimmyxian you wrote "Fix #1312" in the PR #1318 so it closed this one automatically, it's not @abronan he just merged #1318.
I usually use "Related to #xxx" when It doesn't fix entirely the issue.

@vieux :laughing: Got it.

@jimmyxian would you mind updating this issue? :)
It seems like there are newer options that we don't support with newer releases. We should also compile how our API endpoints differ from those in the upcoming Engine release. Ping @dongluochen .

@nishanttotla OK, I will compare the newer options and update this ASAP

Replaced by https://github.com/docker/swarm/issues/2333


2-hand manipulation makes objects always jump to .05 scale

Describe the bug
I'm working on an application that used to run smooth on HL1. I can load (instantiate) several objects and move them freely using the ManipulationHander & BoundingBox. Everything looks fine so far. Near interaction, rotation, highlighting etc. all works. But when I use two hands, to scale or rotate, all my objects transition to .05 scale (xyz) within a fraction of a second. I disabled all my code & functionality, but this is still happening.
Changing settings like max/min scale did not help, either. There seems to be a new component "TransformScaleHandler" that's added in runtime. But disabling or changing its values still did not fix it.
Not sure what causes this problem, it feels like a bug.
To reproduce
Create an Object with:

BoxCollinder
BoundinBox
ManipulationHander
NearInteractionGrabbable

Then grab it with both handrays (bug also occurs in the editor)
Your setup (please complete the following information)

Unity Version 2019.2.11f1
MRTK Version v2.2

Target platform (please complete the following information)

HoloLens 2

@MenelvagorMilsom, maybe something specific to the older one, or you think it also affects the second iteration of these two components?

@wiwei I'll have a quick look today.

I can't repro in editor or on device for either v2.2.0 or latest mrtk_development. Here's a gif I recorded with the set up described in To reproduce above, using 2.2 packages:

@KarlSupertramp, in your repro steps, did you change any of the properties of BoundingBox or ManipulationHandler? Also, can you try to reproduce on the latest mrtk_development and see if your problem persists?

Ok sorry, I forgot a part. The bounds of my BoxCollider are generated, while the object is intantiated. I'm afraight the BoundingBox is not able to fit itself to a changing BoxCollider.
So I guess this more a feature request: Updatable BoundingBox?

Ok sorry I forgot one part that happens before the object is instatiated. I'm using DOTween to smoothly load my objects into the scene. The ManipulationHander or BoundingBox seem to save the scale value on Start(). I'll take a closer look into those classes, maybe I can find a workaround.
It would be helful to manually update any values that are set at Start(). Feature Request?

Cool. If you want to repurpose this issue as a feature request, or create a new feature request, feel free to do so.


Release with updated syn?

Howdy,
I'm looking through one of my projects hunting down big duplicate crates. ptr_meta is one of the ones left that's still on syn 1.0. It looks like it was bumped a few months ago, but a release was never cut.
Any chance of releasing, since it seems like other changes aren't particularly likely to land?

Sorry for the radio silence, do you need a specific version with syn bumped? I just finished some work on a new 0.3 version that addresses some changes to trait object vtable semantics, and that uses an updated version of syn.

I'm not the OP, but I'm also interested in a new release that updates the syn dep. Having that as part of an 0.3 version with other changes would not be a problem for me.

I just made a few more changes for the next version. I'm planning on cutting a new release soon, I just want to make sure that I get all the features I need for the next version of rkyv in before doing so. It should be relatively stable, so in a week or two I'll make a cut.

I just published 0.3.0-alpha.3 which is updated to syn 2. When 0.3.0 is released in full, it will also be updated.


FancyZones Window Switching not Working

Microsoft PowerToys version
0.55.2
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce

Attempt to use window switching in fancy zones, trying different key combinations
Nothing happens
PowerToysReport_2022-02-24-11-01-05.zip

✔ Expected Behavior
For window switching shortcut to switch through overlapping/stacked windows in fancy zones
❌ Actual Behavior
Nothing
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/16620


Improve barcode metrics

Several barcode metrics fixes are included in this PR:

Remove method in BarcodeDecoder to write metrics and use instead getters for them.
Add default header to barcode metrics (closes #116)
Add PCT_RECORDS for percentage of records assigned to each barcode (closes #153)

Ready to go when the checks pass....

Should be squashed and rebased!


x86/x86_64:Adjust the position of the nm command to execute it after …

…NuttX is generated
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Adjust the position of the nm command to execute it
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
no impact
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.
qemu ostest

[Experimental Bot, please feedback here]
The pull request summary is missing crucial information.  It does not explain:

Why the change is necessary. What problem does it solve? Is it a bug fix, optimization, or new feature?
What functional part of the code is being changed.  Be specific! Mention the affected modules or files.
How the change exactly works. Provide a technical explanation of the modification.

The impact section is too vague. While it claims "no impact," it doesn't address all points:

Impact on users: Even if the change is internal, explain why it won't affect users.
Impact on build:  Does it change build dependencies, configurations, or options?
Impact on documentation: If the change affects functionality, even internally, the documentation might need updates.

The testing section is insufficient. It should include:

Build Host(s): Specify the operating system, CPU architecture, and compiler version used for building NuttX.
Target(s):  Detail the target architecture, board, and configuration used for testing.
Testing logs: Provide relevant logs from before and after the change. This helps demonstrate the issue and the effectiveness of the fix.

In conclusion, this PR does not meet the NuttX requirements.  It needs significant improvements in clarity, completeness, and evidence of testing before it can be considered.


Use CompilerFolder

I did a mix of both pullrequests, which basically nullified this PR .. sorry ;-) - but thanks a lot!


Failure when CPM_SOURCE_CACHE is specified with CLion

I'm using the latest version of CPM, freshly downloaded. Using CLion, CMake 3.24/3.22 and Windows 10.
If CPM_SOURCE_CACHE is set, it "fails" and the script configuration crashes, complaining that the folders already exist. (They do not. This is from a completely clean folder with no cache directories.)
This is the CMake script I have:
set(CPM_SOURCE_CACHE .cache/CPM)
CPMAddPackage(
    GIT_TAG release-2.0.22
    GITHUB_REPOSITORY libsdl-org/SDL
)

And this is the output:
CPM_SOURCE_CACHE: .cache/CPM
-- CPM: adding package SDL@ (release-2.0.22 to E:/Git/Antimony-III/.cache/CPM/sdl/22376c56c7faadb422628d46bf5157d6eb41d577)
[1/9] Creating directories for 'sdl-populate'
[1/9] Performing download step (git clone) for 'sdl-populate'
fatal: destination path '22376c56c7faadb422628d46bf5157d6eb41d577' already exists and is not an empty directory.
fatal: destination path '22376c56c7faadb422628d46bf5157d6eb41d577' already exists and is not an empty directory.
fatal: destination path '22376c56c7faadb422628d46bf5157d6eb41d577' already exists and is not an empty directory.
-- Had to git clone more than once:
          3 times.
CMake Error at E:/Git/Antimony-III/cmake-build-release/_deps/sdl-subbuild/sdl-populate-prefix/tmp/sdl-populate-gitclone.cmake:31 (message):
  Failed to clone repository: 'https://github.com/libsdl-org/SDL.git'

Upon reloading the CMake config, it also either "fails" to remove the previous cache folders -
Error removing directory "E:/Git/Antimony-III/.cache/CPM/sdl2/22376c56c7faadb422628d46bf5157d6eb41d577".
CMake Error at E:/Git/Antimony-III/cmake-build-release/_deps/sdl2-subbuild/sdl2-populate-prefix/tmp/sdl2-populate-gitclone.cmake:12 (message):
  Failed to remove directory:
  'E:/Git/Antimony-III/.cache/CPM/sdl2/22376c56c7faadb422628d46bf5157d6eb41d577'

or complains that the cache is dirty:

CMake Warning at cmake/CPM.cmake:679 (message):
  Cache for SDL2
  (E:/Git/Antimony-III/.cache/CPM/sdl2/22376c56c7faadb422628d46bf5157d6eb41d577)
  is dirty

What is bizarre is that the git command actually does run in the background silently and CLion reports the project's CMake config as "loading" until the repo is downloaded - but because of the error, the CMake parser actually stops midway and corrupts the build cache. If I wait until it finished downloading and try to build the project, it will complain that the project cache is incomplete.
C:\Users\Banderi\AppData\Local\JetBrains\Toolbox\apps\CLion\ch-0\221.5591.52\bin\cmake\win\bin\cmake.exe --build E:\Git\Antimony-III\cmake-build-debug --target Antimony3 -j 9
Error: could not find CMAKE_PROJECT_NAME in Cache

If I run CMake manually with CLI with my project, it creates all the files and compiles just fine.
Running from CLion without CPM_SOURCE_CACHE set also runs and compiles fine.

Found the culprit.
When multiple target configurations are present in CLion (e.g. Debug, Release, etc.) the IDE runs CMake configurations in parallel for each build type -- this effectively causes the process to succeed the first time and fail for the others.
A temporary workaround is to set CPM_SOURCE_CACHE to something like .cache/CPM-${CMAKE_BUILD_TYPE} but this seems very wasteful and will effectively clone the repository twice.

Happy to hear you could solve the issue!

I too have encountered this problem. Would it be possible to integrate this code into CPM to eliminate this issue in the future? Perhaps there are downsides to this that I am not seeing?
I was able to set up a block of code that looks like
# Add all packages
file(LOCK ${CPM_SOURCE_CACHE} DIRECTORY GUARD FILE)
CPMAddPackage(NAME Ccache.cmake GITHUB_REPOSITORY TheLartians/Ccache.cmake VERSION 1.2)

CPMAddPackage(NAME AssImp GITHUB_REPOSITORY assimp/assimp VERSION 5.2.5)
CPMAddPackage("gh:g-truc/glm#master")
CPMAddPackage("gh:nigels-com/glew#glew-2.2.0")
CPMAddPackage("gh:glfw/glfw#3.3.8")
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>file(LOCK ${CPM_SOURCE_CACHE} DIRECTORY GUARD FILE RELEASE)

This code worked well for me, but if the file locking was integrated into CPM, then the parallelization of the CMake scripts would not be as hindered as they are with the configuration above.

Is this fixed with #427?

Update: seems this is fixed according to https://github.com/cpm-cmake/CPM.cmake/issues/293#issuecomment-1407416655.


Top Performers and Stats Leaders filter enhancements

last 52 weeks filter
vs Higher/Lower ranked
vs Younger/Older age
vs Height

Completed


Terra Action Footer

Summary
The terra-action-footer component is a footer bar that contains sockets to place items in the form of buttons and hyperlinks used to perform actions. The default variant contains a start and end socket, while the centered variant has only a center socket. If no actions are provided, the footer bar defaults to a 10px equivalent height and maintains the top border.
Created Action Footer component. Fixes #1286
Deployment Links
Action Footer
Centered Action Footer

@dev-cprice Looks like the snapshots for action-footer may need updated.

@dylan-sftwr working on refactoring site examples to be better/easier to digest

UX Edits (3 of 3):
Lets simplify the all the examples on the terra-site to just one set, and rather than doing the standalone example followed by the same example in a card, simpler to just wrap the standalone examples in a div and add dotted-line inline style (we can replace with a future dashed-line component):
import React from 'react';
import ActionFooter from 'terra-action-footer';

const BoxedExampleDivStyle = {
  border: "3px dotted #d3d4d5",
};

const EmptyExample = () => (
  <div style={BoxedExampleDivStyle}>
    <ActionFooter />
  </div>
);

export default EmptyExample;

So the examples would be:
action-footer:
Empty.jsx
SingleStart.jsx
SingleEnd.jsx
MultipleActions.jsx (changes noted above in 2of3- switch order of submit and cancel)
centered-action-footer:
Empty.jsx
SingleAction.jsx
MultipleActions.jsx (changes noted above in 1of3 - block buttons in "mobile-ish" sized container)

Tested: PR #1329
Resolves: Issue #1286

Reviewed:

N/A: Pattern considerations documented in Cerner Design Standards: Action Footer (not yet posted) – related Dialogs
Follows UX defined design initial implementation for Terra-Section-Header
N/A: Future enhancement to follow defined theme designs: terra-theme

Fix with Enhancements:

will post future issue to update background-color and border-top-color to match terra default theme

Verified by @scottwilmarth and  @neilpfeiffer, Ready for Release after Functional Validation.

Pass

UX Review


Col and colgroup faill to render

Excluding "col" because it has no renderer
renderElement @ render.js:137
Excluding "colgroup" because it has no renderer
I have table with merging two columns into single column ,while generating pdf,I'm facing formatting issues.
Can anyone help on this?

I honestly didn't know that those tags existed. Are you using them only to apply styling?

@danomatic @ShireenSyedAzad i am also facing this same problem


naive conflict resolution: abort on conflict detection

Abort on detection of clobbering.
Use the force flag to override this behaviour.
This is meant to address issue #57

@FPtje please let me know what you think of this.

I don't have the means to test until tonight, but the code seems to implement exactly what I mean. Thanks!
I will test it tonight

falco@manjaro:~/Drive$ echo banana > vegetable.txt
falco@manjaro:~/Drive$ go run ~/Downloads/drivething/src/github.com/odeke-em/drive/cmd/drive/main.go  push vegetable.txt
Resolving...
M /vegetable.txt
Modification count 1 src: 7.00B dest: 7.00B
Proceed with the changes? [Y/n]: y
1 / 1 [===========================================================================================================================] 100.00 % 1s
falco@manjaro:~/Drive$ echo kiwi > vegetable.txt
falco@manjaro:~/Drive$ go run ~/Downloads/drivething/src/github.com/odeke-em/drive/cmd/drive/main.go pull vegetable.txt
Resolving...
These 1 file(s) would be overwritten. Use -force to override this behaviour
/vegetable.txt

falco@manjaro:~/Drive$ echo kiwi > vegetable.txt
falco@manjaro:~/Drive$ echo "Edited online too"
Edited online too
falco@manjaro:~/Drive$ go run ~/Downloads/drivething/src/github.com/odeke-em/drive/cmd/drive/main.go pull vegetable.txt
Resolving...
These 1 file(s) would be overwritten. Use -force to override this behaviour
/vegetable.txt

Perfect! Thanks!

Thank you for the great suggestions. I am glad that you brought it up. Hopefully with this in, it can mitigate any future data losses. Oh btw in case you need to take stuff out of the trash, psst
$ drive untrash -matches prefix1 prefix2 prefix....
$ drive untrash file_path


Add raise an error on Chef 14 when trying to bootstrap Chef 15

Description

Validate only if chef version is less than 15.
If the chef version is 14 or lower add validation based on bootstrap_version & prerelease

Note: This fixes is mainly for chef-14 so need to back-port it into chef-14.
Related Issue

https://github.com/chef/chef/issues/8623
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Vivek Singh<EMAIL_ADDRESS>

Is there a reason this is being opened against master if it's to detect Chef 14?

There is no specific reason to create PR against master, I thought it is a process to create PR?
@tas50 Do we need to create PR directly against chef-14?

Created new PR https://github.com/chef/chef/pull/8782 against chef-14.

@tas50 	it'd be weirder to have this opened directly against chef-14 and to have the codebases diverge -- even though it is weird to put it into master and then backport for a feature which is fairly chef-14 specific, but that follows the same usage of git.  exceptions could be made if they have to be, but generally i'd rather not make those exceptions until we have to.

@lamont-granquist & @tas50 should I close this PR?

Closed this PR correct one to be merge is https://github.com/chef/chef/pull/8782