Link Purpose

Issue
Several links go to pdfs. Unfortunately, many of these have not been tagged or been made to be accessible. Although this is not within your control; it may be worth reaching out to some of the resources to ask for word or html versions.
Ensure other links describe the purpose (e.g opening new page or going to youtube).

Recommendations

Add details about the purpose and direction of links. This will support decision-making for people using assistive tech

Resources
Link Purpose

Yes, unfortunately, plenty of resources are not accessible. For example, I've asked the publisher of an article I wrote to make it accessible and he didn't know what I was talking about. So I just provide it via Word if asked. (Not ideal).
I'm not sure I can change this without more coding skills as this has to do with the Excel spreadsheet links.

Apologies; I combined two issues into one and didn't explain properly; pre-holiday brain! I've updated the original issue.
The main issue here is that links should indicate to users they open in new windows. Generally, links opening in new windows are a bit disorientating for screen-reader users. So a visual indication of opening in a new window and a means for assistive tech to perceive it is ideal.
For example:
Show Help (opens new window)
Source
Although this wouldn't fit the design very well, here's another:

 opens a new window

This is a fairly good explanation incase of interest.
But for ease I can submit a pull-request, then you can review for the design aspect :)


Notes:

option items spacing incorrect

the item spacing may be linked to a larger issue

in the multiselect, the option labels are misaligned because the container height seems to be larger than expected
although it doesn't appear to be misaligned in combobox or dropdown, examining the option elements shows that the same issue occur there as well

from what I can tell, this is due to the CSS reset not properly being applied and the box-sizing values being the default content-box rather than the expected border-box


Fix definition of --force flag of c5:database:charset:set CLI command

Thank you, morning person :wink:

👍


Colors ignored in flat menus

In Settings -> Flat menus, there is a field to specific color/text color for each menu item.
It does not have any effect.

Completed


[NT-1203] Lights On Editorial Collection

📲 What
Lights On Editorial Collection Feature. Includes the following PRs:
#1185, #1194, #1196
👀 See

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


[cxx-interop] Remove redundant [extern_c] in tests

[extern_c] module attribute has no effect in these tests.

@swift-ci please smoke test


Register services

Hi
With @dankraw we are working on registering tasks based on Marathon events. Basically this means merging functionality of mesos-consul to marathon-consul. Are you interested in this feature or we should make it stand-alone application. We are using lot of your code, and development takes place here

@janisz @dankraw as we've started to use traefik for our proxies, we don't have the time to devote to this project. Would you be interested in having your fork become the definitive version? We'd put a deprecation notice on ours and point to yours.

@stevendborrelli We decided to create a simple tool just for registering Marathon tasks as Consul services, so KV bridge functionality was removed. Final code is moved here.
Thanks


Crash when opening nf engine 1.1.6

Describe your bug here.
It just crashes,i putted assets and mod folder in,the nf engine just crashes,no intro,it just crashed
Crash Log or logcat logs (if existing)
No response
Are you modding a build from source or with Lua?
I am not modding
Have you open preload state?
No
What is your build target?
iOS
Did you edit anything in this build? If so, mention or summarize your changes.
No

Tell me your iOS version

18.1

I have a similar issue

fr? i actually hope it gets fixed soon

I don't recommend putting assets in here，you can try deleting the assets

Generally speaking, assets will be automatically moved by the engine

it cant automatically move the assets since uh nf engine 1.1.6 hotfix

Waiting for the fix or using the version you can use, we currently do not have an iOS device to test and cannot fix it for the time being.

#78

Please add a comma after line 136 of assets/shader/language/English/options.json

If there are still problems please report because most crash issues are because of this comma.


Able to delete a non-empty bucket

In the real S3, trying to delete a non-empty bucket results in an error.
➜ aws --endpoint-url http://s3-mock:9090 s3api put-object --key some-file --bucket my-bucket --body some-file.txt
{
    "ETag": "\"d41d8cd98f00b204e9800998ecf8427e\""
}

➜ aws --endpoint-url http://s3-mock:9090 s3 rb s3://my-bucket

Actual:
remove_bucket: my-bucket

Expected:
remove_bucket failed: s3://my-bucket An error occurred (BucketNotEmpty) when calling the DeleteBucket operation: The bucket you tried to delete is not empty

The only way you should be able to delete a non-empty bucket is passing the --force flag when using the CLI.

Fixed by @ChaithanyaGK


add voting

Coverage decreased (-5.9%) to 84.183% when pulling 53376e90d40352b1799279de8c667e0899096d19 on server-staging into 7011ad7569174cee49a8112a510ca8f971d6a759 on master.


x/build: update to<EMAIL_ADDRESS>(GO-2021-0113)

govulncheck reports GO-2021-0113 for golang.org/x/build@0a1fb72 (as of 2022/03/09)

$ govulncheck ./...
Findings for vulnerability: GO-2021-0113 (CVE-2021-38561):

Trace:
golang.org/x/text/language.MustParse (/Users/hakim/go/pkg/mod/golang.org/x/text@v0.3.6/cases/map.go:43:41)
golang.org/x/text/cases.init#1(...) (-)
golang.org/x/text/cases.init(...) (-)
golang.org/x/text/secure/precis.init(...) (-)
github.com/jackc/pgconn.init(...) (-)
golang.org/x/build/internal/relui/db.init(...) (-)

I don't think this vulnerability is actually affecting this specific code path picked by govulncheck
(The pgconn maintainer also said in https://github.com/jackc/pgconn/issues/103 this vulnerability doesn't affect the package.)
This vulnerability is not the type of vulnerability that can be analyzed with simple(?) callgraph analysis. We need data analysis to see what's fed into the vulnerable function. But with the lack of options to suppress the report, the easiest path forward is, I think, to update the dependency.
On the other hand, as seen in https://github.com/golang/go/issues/51216, the Go security team wants to avoid changes triggered by false positive reports. So, I am not sure what's the Go team's policy in cases like this.
If we decide to update the dependency, now the question is which dependency to upgrade:

update to<EMAIL_ADDRESS>as the GO-2021-0113 page implies.
update the direct dependency, too<EMAIL_ADDRESS>
cc @golang/security

I'm not sure what the policy should be. For this particular case, it's not a problem to update to the latest pgconn and x/text it in x/build, so I'll add NeedsFix for now.
(If we get more reports that are false positives, that might be a good time to think more, but this is the first one I'm seeing.)

I will close this issue - two followup issues were filed.
And, we updated the github.com/jackc/pgconn dependency, not only x/text dependency.


DEV-14986 - Service Access Rules for EMR 5.30+ support

https://datatamr.atlassian.net/browse/DEV-14986
Ran the static hbase example with the latest 5.x EMR release:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cannot get screen resolution under Win10 system

Cannot get screen resolution under Windows10 system
Version: github.com/go-vgo/robotgo v0.100.6
Image：

Use the robotgo.GetScaleSize().

The problem is still not solved

image:

I will test it.

The window10 have new API, I updated it. And the default value will be made scaled in tests is completed.


Download over https mendeley-desktop.rb

Downloading Mendeley cask over https

[*] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[*] The commit message includes the cask’s name and version.

Sorry if the commit is not formatted properly. In new to this.
Pull request is to change the download to use https.

Thank you for the submission. In the future, please use x in checklists (no spaces inside the brackets) and Github will make them clickable.


tests: add timeout using pytest-timeout

fixes #122

@rm-hull is there a script to re-generate the json files that are causing the tests to fail? How do you regenerate them? Would be good to document this and/or add a script?

As expected, if I pin pillow to a version prior to 8, then the tests pass.
I just added commit 2a764a7 to verify this is the cause, and will revert it from this PR.
Rather than doing that here, I think we should pin pillow in luma.core instead. WDYT?
Interestingly, the py35 build succeeds because pillow never released version 8 (presumably because py35 is sunsetted), so it is using pillow 7.2 (see https://travis-ci.org/github/rm-hull/luma.lcd/jobs/736531130#L552)

Pillow 8 is py36 or newer only, they dropped 3.5 support in Pillow 8. Pillow 8 generates better results (e.g. that oval shape we saw in all the test images I updated) so I would definitely not want to pin pillow to something < 8. All we need to do is update the json files for pillow 8 and the tests will pass. Why would you want to pin it to older versions?
This is why I asked:

is there a script to re-generate the json files that are causing the tests to fail? How do you regenerate them? Would be good to document this and/or add a script? I would like to do it in a separate PR so can you force merge this pull request (travis will fail regardless of this timeout change)?

Um .. im confused .. I thought the tests were failing because it hung travis for 10mins before being killed, and this pr was just about making it fail earlier. is it just the pytest diff algo that is making it hang rather than pillow?

All we need to do is update the json files for pillow 8 and the tests will pass.

Ok, that was not clear to me 😊

is it just the pytest diff algo that is making it hang rather than pillow?

I don't know what made it hang; but adding a timeout shows the actual errors: the json files are outdated.

i'll close the other PR in core ... as to regenerating JSON files, I think I ran something like tox -e py38 > temp.txt (with -vv in the tox.ini) and then for each failing test, pulled out the expected and reformatted into JSON. i.e. quite an arduous (and painful) manual task
I'll have a look to see if we can add a helper to make it more straightforward

i.e. quite an arduous (and painful) manual task

Yea! I see.

Pillow 8 generates better results (e.g. that oval shape we saw in all the test images I updated) so I would definitely not want to pin pillow to something < 8.

I wouldn't mind pinning Pillow to a minimum of 8.0 because it's much better.


Since Version 1.6.1 the connection to Git Client for IBM i does not work anymore

Describe the bug
Up to Version 1.6.0 the extension "Git Client for IBM i" worked well.
After installing Version 1.6.1 of "Code for IBM i" we receive the message "the directory is no git repository" while using VSCODE git view.
To Reproduce
see above
Expected behavior
Using the "git-view" in VSC you should see the git informations of the project located on IBM i.
Screenshots

Environment (please complete the following information):

Extension version: 1.6.0 > 1.6.1
IBM i OS version: 7.3

Additional context
The extension "Git Client for IBM i" is not listed in the VSCODE Marketplace anymore - why?

The git client extension is no longer maintained and is not available to install from the Marketplace.
You are able to build it and fix your issues manually from here: https://github.com/halcyon-tech/git-client-ibmi

is there any preferred alternative?
maybe: using command-line git in pase-terminal
or
mapping a drive in Windows with SSHFS-Win
or ??


Question about Grid

Hello,
First question:
Could someone point me out to a sample or an example what will explain me how to create Grid like below. I was looking for an hour and I must missing something
I have Table called Skills there is column SkillName (Loading,Picking,Receiving..) then there is table Skill Level with column SkillLevel (1,2,3..)  I have Table EmployeeSkill what relating  table Skill, SkillLevel and Employee
I'm looking for a grid what will be as fallow:
Employee Name | Loading | Picking | Reviving
John                   |     2       |     3      |       1
I know this looks like basic question but that will learn me a lot I don't look for a ready solution but just example / Sample how to handle scenarios like that.
Second question
Is there possibility to do more dynamic Columns for example with dates something like
Employee Name | 20/11/2017 | 21/11/2017 | 22/11/2017
John                            IN                OFF                IN
and when I set for example starting date 26/11/2017 in a filed that will  change the column 2 to that date and rest +1,+2,+3 ?
This question is not that impotent as i think if i understand how to resolve first I will be able to manage to do this logic on a class level
Thank You in Advance for any time spend on this it's really important to me
Regards

The simplest thing would be to setup a database view that you use as the source of your grid.  Depending upon your database system, the syntax should be something similar to this:
(First some sample data setup with the assumptions on table definitions)
create table Employee (
EmployeeId [INT] NOT NULL IDENTITY(1, 1) PRIMARY KEY,
EmployeeName [NVARCHAR] (255) NOT NULL
)
insert into Employee (employeename) values ('John'),('Jane'),('Harry')
Create Table SkillName (
SkillNameId [INT] NOT NULL IDENTITY(1, 1) PRIMARY KEY,
SkillName [NVARCHAR] (255) NOT NULL
)
Insert into SkillName (Skillname) VALUES ('Loading'),('Picking'),('Receiving')
Create Table SkillLevel (
SkillLevelId [INT] NOT NULL IDENTITY(1, 1) PRIMARY KEY,
SkillLevel [INT] NOT NULL
)
Insert into SkillLevel (SkillLevel) VALUES (1),(2),(3),(4),(5)
Create table EmployeeSkill (
EmployeeId [INT] NOT NULL CONSTRAINT FK_EmployeeSkill_Employee FOREIGN KEY REFERENCES Employee (EmployeeId),
SkillNameId [INT] NOT NULL CONSTRAINT FK_EmployeeSkill_SkillName FOREIGN KEY REFERENCES SkillName (SkillNameId),
SkillLevelid [INT] NOT NULL CONSTRAINT FK_EmployeeSkill_SkillLevel FOREIGN KEY REFERENCES SkillLevel (SkillLevelId)
)
insert into employeeskill (employeeid, skillnameid, skilllevelid)
select employeeid, employeeid, employeeid
from employee a
go
--Now the actual view
create view EmployeeSkillStats
AS
SELECT A.EmployeeName, MAX(CASE WHEN C.SkillName = 'Loading' THEN D.SkillLevel ELSE 0 END) as Loading,
MAX(CASE WHEN C.SkillName = 'Picking' THEN D.SkillLevel ELSE 0 END) AS Picking,
MAX(CASE WHEN C.SkillName = 'Receiving' THEN D.SkillLevel ELSE 0 END) AS Receiving
FROM Employee A
LEFT OUTER JOIN EmployeeSkill B
ON A.EmployeeId = B.EmployeeId
LEFT OUTER JOIN SkillName C
ON B.SkillNameId = C.SkillNameId
LEFT OUTER JOIN SkillLevel D
ON B.SkillLevelId = D.SkillLevelId
GROUP BY A.EmployeeName
GO
select * from EmployeeSkillStats

I will look into this solution and let you know how I get on with it.
I think it will be really great to see solution like this https://www.codeproject.com/Articles/25167/Simple-Advanced-Pivots-with-C-and-ASP-NET
Build in in the Serenity couse this will help with scenarios like my for reporting purposes or user view
My skill in programming is not on that level yet but I will work hard to get there :)
Thank you for your time spend on this topic Rodney.
Regards


Add Cloud Bigtable Change Stream integration tests

Add a basic set of integration tests for Cloud Bigtable Change Stream.
Add functionality

to customize the Bigtable instance name for integration tests.
to change the endpoint of Bigtable services under test.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jackdingilian to review the integration tests.

@Abacn Could you please take a look at the structure again. And if my responses make sense. Happy to make changes. Jack from Cloud Bigtable approved the test content.


feat(sandbox): Add an example of MFA authentication in sandbox

Description
Add an example of MFA authentication in sandbox
Fixes #1973
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

@arpit1503khanna  -- https://sonarcloud.io/project/issues?resolved=false&pullRequest=2002&id=sourcefuse_loopback4-microservice-catalog&open=AY3LsraK7m1cqhCYw4hH

Cant be merge it.
MFA strategy needs changes google and otp


Release new version?

Hi, since #100 has been merged (among other PRs), do you think to release an updated version of the adam-robotics conda package? :)
Thanks

Hi @xela-95! Sure ;) let's do it!

Done!


CLI to detect used ports

Describe the proposal
When using dapr run, the CLI should proactively detect the currently used ports and error out with a clear message. This should be true for every port the CLI will use: Dapr HTTP port, Dapr gRPC port, App port and metrics. This can reduce a lot of friction when getting started on Dapr or simply day to day troubleshooting. The App port should be checked ONLY if there is a command to be executed after dapr run -- since the app can be executed separately from the dapr run invocation.
Release Note

RELEASE NOTE: ADDED validation for currently used ports prior to executing dapr run

If dapr run -- is executed, we can check that the app-port is already in use (desired).
If there is a command provided, then we can ensure that the app-port is not already in use!

The option that I see here is to do something similar to what the FreePort method does, make a connection to an incoming port and see if it is free or not and then close connection if it is free ... That though would increase the delay for run IMO ... WDYT?

This is partially already available ie checking if a port is already being used for HTTP, gRPC and metrics port ...
# Run
dapr run -H 3500

in two different shells, you will get the error
WARNING: no application command found.
❌  invalid configuration for HTTPPort. Port 3500 is not available

The only enhancement needed here is when dapr run has an app command to run, then the app port must not be an existing app port and that should error out similar to what we see above.

@artursouza These checks are present already as far as I can see.

@artursouza These checks are present already as far as I can see.

Can we close this issue if that is the case please?


fix failing JUnit

Hard coded date so that test will be consistent

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage     19.39%   19.39%
  Complexity      331      331
=========================================
  Files           120      120
  Lines          4026     4026
  Branches        546      546
=========================================
  Hits            781      781
  Misses         3189     3189
  Partials         56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e61bb4...08c09ff. Read the comment docs.


how to click on the gridview  of the screen

From<EMAIL_ADDRESS>on May 26, 2011 21:38:08
there is a gridview which contains some view in the screen of  my project,i want't to write a test project to test it ,but i don't know how to use "solo" to click on the gridview.
i try "solo.clickOnButton","solo.clickOnView" and so on.but none of them is ok.
please tell me how to resolve this problem.
thanks!
Original issue: http://code.google.com/p/robotium/issues/detail?id=115

From<EMAIL_ADDRESS>on May 26, 2011 22:30:44
You need to use hierarchyviewer in order to know what elements are in the gridview. Then you know that you can use the proper command.
Status: Invalid


Artifact fragments can now stack.

About the PR

Title.
Why / Balance

Makes it easier to discern how many artifact fragments are in a given bag, and allows for easier handling.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

DNM until Storage PR is figured out


fix: Adds npm dependencies to right area MUMUP-3004

Tested out the build ignoring the dev dependencies.  Found out that 4 more dependencies are actually required for the build to succeed.  This fix adds them there.

Contributor License Agreement adherence:

[x] This Contribution is under the terms of Individual Contributor License Agreements (and also Corporate Contributor License Agreements to the extent applicable) appearing in the Apereo CLA roster.

Cool.  We're running into a problem with a dev dependency that is failing to install on our build server because our build server doesn't have a c compiler currently installed.  I'll look into a different way to solve that.  Thanks for the info!

@vertein optionalDependencies would be one option.
If the C/C++ code need to be built, let me know what the dependency is and I can look into updating Travis and AppVeyor to support native API builds.


Buttons are black on black and have dots

Firefox 68.0.2
GNOME 3.32.2 on X11
I just reinstalled arch today and have this issue.
It wasn't there on my previous install. I don't know which version of firefox i was using then.

For example, the new tab button is only visible when i hover over it

My spongey senses are telling me you may have missed an about:config step (search "SVG" in the readme) ;)

That was it, thanks!
On Sun 18 Aug, 2019, 14:24 Muck<EMAIL_ADDRESS>wrote:

My spongey senses are telling me you may have missed an about:config step
(search "SVG" in the readme) ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/muckSponge/MaterialFox/issues/142?email_source=notifications&email_token=AIWNSZ2COFBUKHZJH43X4O3QFEE2XA5CNFSM4IMRSFXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Q3SNY#issuecomment-522303799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIWNSZ77F44YQAXXAWTNEQ3QFEE2XANCNFSM4IMRSFXA
.


Cannot see metric on testing

🐛 Describe the bug
This script just outputs as below. But no metrics are displayed. Please help. How to get map@0.5:0.5
Test: 100%|██████████| 43/43 [00:09<00:00,  4.61it/s]
Test: 100%|██████████| 43/43 [00:09<00:00,  4.57it/s]
Test: 100%|██████████| 43/43 [00:09<00:00,  4.53it/s]
Test: 100%|██████████| 43/43 [00:09<00:00,  4.52it/s]
trainer.test(
    model=best_model,
    test_loader=test_data,
    test_metrics_list=DetectionMetrics_050_095(
        score_thres=0.1,
        top_k_predictions=300,
        num_cls=len(dataset_params['classes']),
        normalize_targets=True,
        post_prediction_callback=PPYoloEPostPredictionCallback(
            score_threshold=0.01,
            nms_top_k=1000,
            max_predictions=300,
            nms_threshold=0.7
        )
    )
)

Versions
ersions of relevant libraries:
[pip3] numpy==1.23.0
[pip3] torch==1.12.1
[pip3] torch-model-archiver==0.5.3b20220226
[pip3] torch-workflow-archiver==0.2.4b20220513
[pip3] torchaudio==0.12.1
[pip3] torchinfo==1.8.0
[pip3] torchmetrics==0.8.0
[pip3] torchserve==0.6.0b20220513
[pip3] torchtext==0.13.1
[pip3] torchvision==0.13.1
[conda] blas                      2.116                       mkl    conda-forge
[conda] blas-devel                3.9.0            16_linux64_mkl    conda-forge
[conda] captum                    0.5.0                         0    pytorch
[conda] cudatoolkit               11.6.0              hecad31d_10    conda-forge
[conda] libblas                   3.9.0            16_linux64_mkl    conda-forge
[conda] libcblas                  3.9.0            16_linux64_mkl    conda-forge
[conda] liblapack                 3.9.0            16_linux64_mkl    conda-forge
[conda] liblapacke                3.9.0            16_linux64_mkl    conda-forge
[conda] magma-cuda116             2.6.1                         1    pytorch
[conda] mkl                       2022.1.0           h84fe81f_915    conda-forge
[conda] mkl-devel                 2022.1.0           ha770c72_916    conda-forge
[conda] mkl-include               2022.1.0           h84fe81f_915    conda-forge
[conda] numpy                     1.23.0                   pypi_0    pypi
[conda] pytorch                   1.12.1          py3.9_cuda11.6_cudnn8.3.2_0    pytorch
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torch-model-archiver      0.5.3                    py39_0    pytorch
[conda] torch-workflow-archiver   0.2.4                    py39_0    pytorch
[conda] torchaudio                0.12.1               py39_cu116    pytorch
[conda] torchinfo                 1.8.0                    pypi_0    pypi
[conda] torchmetrics              0.8.0                    pypi_0    pypi
[conda] torchserve                0.6.0                    py39_0    pytorch
[conda] torchtext                 0.13.1                     py39    pytorch
[conda] torchvision               0.13.1               py39_cu116    pytorch

Hello @gsrujana, you can easily print the results dictionary returned by test:
results = trainer.test(...)
print(results)

Hi @gsrujana
Thanks for opening an issue for SG. I'm gathering some feedback on SuperGradients and YOLO-NAS.
Would you be down for a quick call to chat about your experience?
If a call doesn't work for you, no worries. I've got a short survey you could fill out: https://bit.ly/sgyn-feedback.
I know you’re super busy, but your input will help us shape the direction of SuperGradients and make it as useful as possible for you.
I appreciate your time and feedback. Let me know what works for you.
Cheers,
Harpreet


Charlyf/datadog/updateto5172

Upon releasing the version 5.17 of the Datadog agent, the Leader Election feature was added to the capabilities of the agent.
This PR aims at adding the feature to the chart so that users can enable it out of the box.
This PR also embeds the hostPort so that agents can receive Dogstatsd packets without any modifications.

@hkaj I updated the ClusterRole so that the required policy is applied only if the LeaderElection is set.
I tested locally, it works as expected.

Can a project member review and trigger the tests? 🙏

@CharlyF @hkaj CircleCI tests are currently failing. Can someone look at fixing those.

All good @mattfarina (cc: @hkaj do you validate the rebase ?)

@mattfarina could we test/merge this ?

/ok-to-test

@unguiculus interestingly the comment in the clusterrole.yaml was making the e2e check fail. The error was not very verbose though.
Anyways, could we get a retest and a ok to merge ?

/ok-to-test

/lgtm


[SPARK-44000][SQL] Add hint to disable broadcasting and replicating one side of join

What changes were proposed in this pull request?

This PR adds a new internal join hint to disable broadcasting and replicating one side of join.
Why are the changes needed?

These changes are needed to disable broadcasting and replicating one side of join when it is not permitted, such as the cardinality check in MERGE operations in PR #41448.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

This PR comes with tests. More tests are in #41448.

cc @dongjoon-hyun

Thank you, @aokolnychyi !

@dongjoon-hyun, I'll submit a follow-up PR with the comments.

Thank you, @viirya and @aokolnychyi . Now, pending CIs.

It seems that sql test pipeline is killed by receiving shutdown signal somehow.
...
2023-06-07T18:39:01.1867247Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
2023-06-07T18:39:01.5173829Z Session terminated, killing shell...
2023-06-07T18:39:01.7418237Z ##[error]The operation was canceled.

When you have a chance, could you re-trigger the failed test pipeline?

Triggered again: https://github.com/aokolnychyi/spark/actions/runs/5202190900

Thank you so much!

Unfortunately, master branch still has the issue on sql - other tests module and the last test of this PR seems to be running over 4h 40minutes as of now.

This PR passed catalyst and all hive modules. I verified JoinSuite (and new test cases) manually.
$ build/sbt "sql/testOnly *.JoinSuite"
...
[info] JoinSuite:
20:13:26.224 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
[info] - equi-join is hash-join (69 milliseconds)
[info] - NO_BROADCAST_AND_REPLICATION hint is respected in cross joins (19 milliseconds)
...
[info] Run completed in 25 seconds, 333 milliseconds.
[info] Total number of tests run: 50
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 50, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 60 s, completed Jun 7, 2023, 8:13:50 PM

Thank you, @aokolnychyi and @viirya .

Thank you, @dongjoon-hyun @viirya! I've created #41509 to add comments.


fix block reader should check column string offset

Proposed changes
there is some bug like cats will make data wrong, compaction will core when reading wrong data, so need to add a check on column string.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Feature: Add relative time (RT)

RT = Time from start observation +/- Time Offset

done

Found bug: Lost def Author for new empty line


Fixed return value from .end() and added tests

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Fixed the return value from .end() to include the version string instead of the version object
Added some more tests for existing and new features

Approved


Add FFT Op

1D FFT:
https://www.tensorflow.org/api_docs/python/tf/signal/fft
https://pytorch.org/docs/stable/generated/torch.fft.fft.html#torch.fft.fft
https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.fft.fft.html
We can similarly add 2D FFT ops. These ops will be useful for porting FNet (present in KerasNLP).
@fchollet - I wanted to know where these ops should reside. Should they be inside https://github.com/keras-team/keras-core/blob/main/keras_core/ops/numpy.py? Or should we create a separate file for all fft ops?
CC: @mattdangerw

Matt's solution sounds good, let's go with the tuple approach.


fix: rewrite named export default

fix #595
relvant pr: https://github.com/vuejs/vue-next/pull/1675

rewriteDefault in compiler-sfc needs to be fixed too 😂

The https://github.com/vuejs/vue-next/pull/1675/files pr already fixed this=.=


Understanding EtherChannel Technology

Proposed title of article
Understanding EtherChannel Technology
Introduction paragraph (2-3 paragraphs):
In most of the networks, network administrators use more bandwidth and redundancy. They achieve it by connecting multiple links between devices on the network. With this method, the redundant links get blocked by the Spanning Tree Protocol (STP) to prevent switching loops. A technology is needed to achieve the redundancy and increased bandwidth, by allowing redundant links between devices that STP will not block. The technology is the EtherChannel Technology.
To gain the understanding of this, this article will show us how to configure, troubleshoot and understand EtherChannel technology to achieve the more bandwidth and redundancy.
Key takeaways:
The reader should be able to:

Understand EtherChannel technology.
Configure the EtherChannel.
Troubleshoot the EtherChannel.

References:
N/A
Templates to use as guides
N/A

cc @hectorkambow

sounds like a good topic - approved 👍  @dentonya


Torstol scb

When trying to mix super combat I get message saying I don’t have enough torstol.

Figured it out


Add windsonsea to sig-docs-en-reviews

Open this PR after kubernetes/org#4465
It is truly an honor for me to be listed in the en-reviews. I greatly appreciate that Kubernetes has provided a fantastic team ladder, enabling my continuous growth. I am committed to doing my best to ensure the healthy growth of our website as a knowledge base of cloud native.
A special thanks to @sftim, @tengqm, @dipesh-rawat, and @mengjiao-liu for your contribution efforts and support.

/approve


Schema documentation and Client-side logic

This looks really awesome, especially with the new features coming in 3.0!
I'm currently using schema directives to enforce permissions based on Apollo's docs. I've added two features that really benefit my app:

The directive appends the field description with a markdown-rich explanation of the permissions rules so you can see the requirements right in GraphiQL/Playground.
It generates (hackishly, and only in dev environment) TS definitions and objects that contain information about permissions rules so the client can proactively exclude fields or disable queries/mutations it predicts may be unauthorized.

So, I have a couple questions. I'm also happy to contribute to any of these features if they seem possible and interesting.

I'm not sure how the introspection query works under the hood, but would it be possible for this library to append information to the descriptions of fields based on permissions rules?
Any thoughts on how to expose the permissions rules to client-side logic? Obviously some require data from the query itself, but at least simple access rules, like isAuthenticated and isAdmin etc. could be derived.

Hey, I thought I already replied to this, sorry for the delay. I love your idea! Unfortunately, we entirely rely on graphql-middleware. I think it would be possible to do some auto-generation which could turn out really cool, but I am not so sure about the description idea. It is possible, but I think we should find a bit more use cases to add such functionality to grpahql-middleware.

Hi, I'm curious if there's a simple way to determine if the user has permission for mutations from the client? Or would it require an introspection query?

@Victordmdb I am not sure I understand your question. From what I know, neither of the two would give you that information. One way I can imagine obtaining such information would be by forwarding a role in user's session information. That, however, would have to be determined by the business logic of your application, not the schema.

@maticzav I'm testing out CASL which fits well with graphql-shield to handle permissions at every level.

@Victordmdb Will you suggest to use CASL based on your testing?


Bug: not able to see respective apps in search bar when you have specific permission

📜 Description
not able to see respective apps in search bar when i have. specific permission on the cluster

👟 Reproduction steps
just access the search bar and your access should not be super-admin
👍 Expected behavior
it should be show the apps you have access

👎 Actual Behavior
showing nothing in case you have specific permission on cluster and show no apps which apps permission you have.
but it should not be in access thing it should have to see the apps which have acess to you but its showing nothing
☸ Kubernetes version
EKS
Cloud provider

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#2725

Fixed in https://github.com/devtron-labs/devtron/pull/3292


Can version control support add git tags

Please correct me if I am wrong. I think VSCode does not support add tag to git repository. As a result, I have to do it in command line. Can we have that capability in VSCode please.

Is the first option, Git: Create Tag, not what you're looking for?

Thanks, I completely forget about that.


Unable to save medusa_lm_head.pt file in default folder

Hello,
I am currently facing an issue while using the bash script train_vicuna_7b.sh in my training process. After the script execution, I noticed that the expected medusa_lm_head.pt file is not being saved in the default folder test_medusa_mlp_vicuna-7b-v1.3_medusa_3_lr_0.001_layers_1. However, only the config.json file is present in that folder.
The error message is shown below

Upon examining the code snippet ,it seems that the if and else logic is not executing correctly.https://github.com/FasterDecoding/Medusa/blob/b50cb412b859389ad7edcf91fa4bf9d412778b88/medusa/train/train.py#L389-L392
Could you please guide me on how to properly save the medusa_lm_head.pt file?
Thank you for your assistance.

Hi Caiyu,
Thanks for reporting! That's a bug due to our migration. I just fixed it, please check the new code :)

Thank you for your response. After updating the code, I successfully obtained the expected medusa_lm_head.pt file. However, I am experiencing some strange errors. Specifically, for the notebooks/medusa_inference_explained.ipynb file, when I run the cells after modifying the model_name(under the section Model Loading) to the path where the medusa_lm_head.pt file is located ,the section under Performing Inference displays the error message provided below.
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[8], line 3
      1 with torch.inference_mode():
      2     input_ids = tokenizer([prompt]).input_ids
----> 3     output_ids, new_token, idx, wall_time = medusa_forward(
      4                     torch.as_tensor(input_ids).cuda(),
      5                     model,
      6                     tokenizer,
      7                     medusa_buffers,
      8                     medusa_topk,
      9                     temperature,
     10                     posterior_threshold,
     11                     posterior_alpha,
     12                     past_key_values,
     13                     past_key_values_data, current_length_data
     14                 )
     15     output_ids = output_ids[0][len(input_ids[0]) :]
     16     print("Output length:", output_ids.size(-1))

Cell In[2], line 23, in medusa_forward(input_ids, model, tokenizer, medusa_buffers, medusa_topk, temperature, posterior_threshold, posterior_alpha, past_key_values, past_key_values_data, current_length_data, steps)
     21 for idx in range(steps):
     22     with timed(wall_times, 'medusa'):
---> 23         candidates, tree_candidates = generate_candidates(medusa_logits, logits, medusa_topk, medusa_buffers['tree_indices'], temperature)
     25     with timed(wall_times, 'tree'):
...
--> 215     candidate_i = torch.topk(medusa_logits[i, 0, -1], medusa_topk[i]).indices
    216     candidates.append(candidate_i)
    217 candidates_flat = torch.cat(candidates)

IndexError: index 2 is out of bounds for dimension 0 with size 2

However, if I keep the model_name in the Model Loading section as model_name = 'FasterDecoding/medusa-vicuna-7b-v1.3', there are no errors.

I can tell the problem from IndexError: index 2 is out of bounds for dimension 0 with size 2 is caused by the length of your medusa_choices > medusa_num_heads + 1.
Can you check the medusa_num_heads in your model and the medusa_choices in the notebook?
Thanks!

I can tell the problem from IndexError: index 2 is out of bounds for dimension 0 with size 2 is caused by the length of your medusa_choices > medusa_num_heads + 1.
Can you check the medusa_num_heads in your model and the medusa_choices in the notebook?
Thanks!

Hi there,
I am aware that there is a mismatch between the default settings in scripts/train_vicuna_7b.sh and the default value of medusa_choices in the notebook.
The default medusa_num_heads obtained from scripts/train_vicuna_7b.sh is 3, and the problem can be resolved by modifying the length of medusa_choices to 4.
https://github.com/FasterDecoding/Medusa/blob/0d4a166febf9a888c0598ffe8d9f2b0856a79bb0/scripts/train_vicuna_7b.sh#L19
Similarly, to address the error caused by the command python -m medusa.inference.cli --model test_medusa_mlp_vicuna-7b-v1.3_medusa_3_lr_0.001_layers_1, modifying the medusa_choices settings to a length of 4 resolves the problem.
https://github.com/FasterDecoding/Medusa/blob/0d4a166febf9a888c0598ffe8d9f2b0856a79bb0/medusa/model/medusa_model.py#L186-L198
Thank you for your contribution to the open-source community.


Add command to clear extension related storage

Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/151

@kimadeline,

On the first run of the command, only the values that will be rewritten after this code gets in will get cleared?

You're correct, only the values that will be rewritten, or that are read will be tracked.
There can be such key values which are used (written to/read) rarely, or atleast not automatically on startup unless user triggers something. For eg. every prompt which has a "Do not show again" option, like the new workspace env prompt:
https://github.com/microsoft/vscode-python/blob/2402acc5085653131cae7ce52172169a77cd6cfa/src/client/interpreter/virtualEnvs/virtualEnvPrompt.ts#L83-L86
But unless we track these individually, unfortunately there's no way to clear them (help VSCode!). We're assuming this is mainly for dev purposes, and we'll probably only want to clear the cache we're interacting with, in which case this command should be useful.


add safety pool draft document

Should we look into a general-purpose "reusable authority token" mechanism for Stakes in particular? The idea being that if we want to perform a proposal-voted action on all or some stakes, then we can't do that using the current GAT mechanism.