Display images using flex box

Add images to the food section of index and corresponding css to display in a flex grid. This made the total content in index greater than 100vh so I made the background and header not move on scroll (only the actual content will scroll).
Here's a look at that section

I just pulled master, should be fixed now!


[Feature]: Rework profile edit using remix-forms/zod

Contact Details
No response
What do you like to be improved?
👆

Fix Layout jumping issues (f.e. changing to /security or /delete, while editing the website url)

Needs more investigation.

[ ] Improve organization navigation for highlighting links see #215


Make tests fast by pinging port

Codecov Report
Patch coverage: 86.20% and project coverage change: -0.06 :warning:

Comparison is base (3153948) 73.43% compared to head (fa4040b) 73.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   73.43%   73.37%   -0.06%
==========================================
  Files          42       42
  Lines        4792     4782      -10
==========================================
- Hits         3519     3509      -10
  Misses       1021     1021
  Partials      252      252

Impacted Files
Coverage Δ

internal/acme/http_client.go
69.18% <50.00%> (ø)

internal/acme/acme.go
63.10% <81.25%> (-0.13%)
:arrow_down:

internal/acme/client.go
59.75% <100.00%> (-0.56%)
:arrow_down:

internal/acme/helpers.go
60.85% <100.00%> (-0.16%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Log the time the Ansible run completes.

I've found this to be useful to gauge how long the Ansible run takes at instance startup.

Thanks!


[minor error] ambiguous if condition

Expected Behavior
do not transfer any Pidgey when I set this to json
	"Pidgey": {
		"min_cp": 0,
		"min_iv": 0,
		"cp_iv_logic": "or"
	}

Actual Behavior
UnboundLocalError: local variable 'min_cp' referenced before assignment
Steps to Reproduce
Other Information
I believe this is caused by the ambiguous if condition: if release_config.get('min_cp'):, which should be replaced with if release_config.get('min_cp') != None:  because if 0 and if None will all returns false but they are different.

Code merged a few minutes ago solves this issue.

https://github.com/PokemonGoF/PokemonGo-Bot/commit/5cd992f7677e9e2c6f2a67c773d752d8469f54ad


Fix pip install URL

The URL in the README seems to have an outdated owner name. This PR updates it.

Totally missed this PR, sorry for that. Good catch, thanks for bringing this up.


tinygltf is not supported in a add_subdirectory context in cmake

Describe the issue
While tinygltf is a cmake project, I cannot currently use it in its default configuration as a project in a subdirectory.  This prohibits me from using tinygltf in a normal workflow with out modifying the CMake source.
To Reproduce

OS Any
Compiler, compiler version, compile options Any

Expected behaviour
I expected a Cmake INTERFACE target to be created because this is a header only library, which I can use directly after using add_subdirectory(path_to_tinygltf), rather than having only availible with an install which is not appropriate for my development environment, and with out a target, which isn't appropriate for any cmake project.   This is what other libraries like GLM do, and funnily enough, even what one of this projects dependencies which is header only, nlohmann json does,  and is standard procedure for header only CMake projects.
Additional context
I will provide what I personally did to get this project to work as a subproject (appended to the end of current CmakeList.txt), it's not extensively tested, and may rely on features newer than cmake 3.6.   This may not be the best solution for the project as whole.  This also includes an option for using a cpp provided by the library which I also created.
option(TINYGLTF_CREATE_CPP "generate a cpp for you" OFF)
if(TINYGLTF_CREATE_CPP)
  add_library(tinygltf)
  target_sources(tinygltf PRIVATE
          tiny_gltf.cpp)
  target_include_directories(tinygltf
          INTERFACE
          $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
          $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
          )
else()
  add_library(tinygltf INTERFACE)

  target_include_directories(tinygltf
          INTERFACE
          $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
          $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
  )

endif()

CPP file (tiny_gltf.cpp
#define TINYGLTF_IMPLEMENTATION
#define STB_IMAGE_IMPLEMENTATION
#define STB_IMAGE_WRITE_IMPLEMENTATION

#include "tiny_gltf.h"

@Cazadorro current cmake  file is not designed to be used with add_subdirectory.  Thanks you for the proposal and some information(glm, nlohmann json). Let me give some time to review what is the best way to add support of add_subdirectory feature

@Cazadorro I made a CMake script which is add_subdirectory friendly based on your comment. Please take a look:  https://github.com/syoyo/tinygltf/compare/cmake-add-subdirectory

@syoyo Sorry for the long wait, I hadn't had a reason to use GLTF for a while, I just tried this today, it appears to do the job,

@Cazadorro Good. PR will be created soon.

+1 for this feature

@bmahlbrand Oh, I forgot to create a PR... Now merged!


Recommend File.expand_path(__dir__) over File.expand_path('..', __FILE__)

Since Ruby 2.0 we've had __dir__ as well as __FILE__. Still, I think a very standard practice is write
File.expand_path('..', __FILE__)

even though now you can do
File.expand_path(__dir__)

Other corrections we could make like this:
File.expand_path('../..', __FILE__) == File.expand_path('..', __dir__)         # => true
Pathname.new(__FILE__).parent.expand_path == Pathname.new(__dir__).expand_path # =>true

This could probably be a separate cop but we could also then recommend replacing
File.expand_path(__dir__)

with
Dir.pwd

I'm fine with the idea. I think I planned to implement this myself years ago, but I never got to doing so.

@backus Dir.pwd is the current directory, which can be changed with Dir.chdir. __dir__ is always constant for a specific file.

@dabroz good point I'll adjust that

The message is Style/Dir: Use dir to get an absolute path to the current file's directory. [Style/Dir] but __dir__ alone gives us a relative path. The autofix from File.expand_path(File.dirname(__FILE__)) to __dir__ is therefore wrong.
This is with Ruby 2.3.1 and RuboCop 0.52.1.


[stable/redis] Add existingSecretPasswordKey setting for users

Allowing users to specify which key within the secret contains the
password

What this PR does / why we need it:
Which issue this PR fixes

fixes #16334

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @carrodher

I'm okay with the changes @twk3 but you'll need to update the PR (rebasing your branch from master) since the PR you did was already merged and it also modified the Chart.yaml (therefore the conflict)

@juan131 I've rebased master, and should be ready for another review

Oh.. it seems you need to rebase from master again. Sorry for that

@juan131 I've gone and rebased, so should be ready for a final look

/ok-to-test
/lgtm

Thanks @twk3 !!


Spark - clean tests logs

Some of the tests throw an exception, print stack trace and PASS as this is the expected behaviour.


Fixes [#276] Throw a nicer error when the routing services haven't been added to DI

:watch:

@dougbu updated

:watch: for small touch-ups and one open question.

@dougbu updated. @rynowak any comment?

:shipit: but definitely get input from @rynowak.

@rynowak Updated to include your suggestions

:shipit: for https://github.com/aspnet/Routing/commit/db34f85ea1ef69cf980a633db260ce7d889bf662


Startup error with renv when project is out of sync.

Languageserver errors when renv is out of sync.
[2023-12-06 10:47:10.203] workspace initialize error:  <callr_timeout_error/callr_error/rlib_error_3_0/rlib_error/error>
Error in `get_result(output = out, options)`:
! callr timed out
[2023-12-06 10:47:10.702] deliver:  ["Response", "Message", "R6"]
[Error - 10:47:10 AM] Client R Language Server: connection to server is erroring.
Header must provide a Content-Length property.
{"- the project is out-of-sync -- use `renv":":status()` for details.\nContent-Length: 871"}

Fixing the sync issues with eg. renv::snapshot() solves the error.

Pretty much at the same time I filed the issue for the same reason on the languageserver package repository /REditorSupport/languageserver/#645.
I found that you can disable renv status check with  renv::config$synchronized.check(FALSE) or using RENV_CONFIG_SYNCHRONIZED_CHECK = FALSE in your .Renviron.


Support extracting questions as well as answers

Currently it looks like the code can only extract answers, but it would be cool if it was also possible to capture questions in a similar way. This would make it easier to archive the full context of a StackOverflow post (eg. for making an offline backup of my questions/answers)

Gotcha, so a way to pass in a question URL and get just the question, or all of the answers?

I guess I would see them as 2 separate things, but being able to do either might be cool. At a minimum, just getting the question when entering a question URL would make sense (and then I could use the existing functionality to copy the answer URLs that I wanted)


Update README.md

remove grammatical mistakes

I am a GSSOC participant. Please check my pull request

Please check my pull request

Not required @KajalSinghBAGHEL.


代码优化

What this PR does / why we need it?
代码简化
Summary of your change
1.判断条件优化
2.for循环简化
Please indicate you've done the following:

[√] Made sure tests are passing and test coverage is added if needed.
[√] Made sure commit message follow the rule of Conventional Commits specification.
[√] Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Codecov Report
Patch coverage: 80.00% and project coverage change: -1.87 :warning:

Comparison is base (8876c08) 75.99% compared to head (6456420) 74.13%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1571      +/-   ##
============================================
- Coverage     75.99%   74.13%   -1.87%
+ Complexity    20575    19775     -800
============================================
  Files           631      619      -12
  Lines         81116    80603     -513
  Branches      17705    17590     -115
============================================
- Hits          61647    59752    -1895
- Misses        12225    13471    +1246
- Partials       7244     7380     +136

Impacted Files
Coverage Δ

...in/java/com/alibaba/fastjson2/JSONReaderUTF16.java
66.56% <50.00%> (-13.23%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
83.69% <100.00%> (-1.72%)
:arrow_down:

... and 61 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adding async support for reduce step in MapReduceDocumentsChain

Hey!
First things first, I just want to say thanks for this amazing project :)
In MapReduceDocumentsChain class, when you call it asynchronously, i.e. with acombine_docs, it still calls the same self.process_results method as it does when calling the regular combine_docs. I expected, that when you use async, it would do both map and reduce (self.process_results is basically the reduce step, if I understand correctly) steps async.
The relevant parts in map_reduce.py:
class MapReduceDocumentsChain(BaseCombineDocumentsChain, BaseModel):
    async def acombine_docs(
        self, docs: List[Document], **kwargs: Any
    ) -> Tuple[str, dict]:
        ...
        results = ...
        return self._process_results(results, docs, **kwargs)

    def _process_results(
        self,
        results: List[Dict],
        docs: List[Document],
        token_max: int = 3000,
        **kwargs: Any,
    ) -> Tuple[str, dict]:
    ....
    output, _ = self.combine_document_chain.combine_docs(result_docs, **kwargs) # this should be acombine_docs
    return output, extra_return_dict

This could be fixed by, for example, adding the async version for processing results _aprocess_results and using that instead when doing async calls.
I would be happy to write a fix for this, just wanted to confirm if it's indeed a problem and I'm not missing something (the reason I stumbled on this is because I am working on a task similar to summarization and was looking for ways to speed things up).

+1
seems that the part calling _collapse_chain in _process_results also has the same issue

Looking forward for this feature in future versions of Langchain


Abnormally Long Pod Deployment Time in 1.6

Describe the bug
Any operation that includes pod deployments takes a long amount of time. For example, in my case this operations take 15 minutes  (almost exactly) each:

Deploying Advantedge core
Creating a new sandbox
Deploying an scenario into the sandbox (Deploy the applications) : The delayed behavior here seems randomly occasional (Same scenario, same sandbox, some times will deploy quickly, some will take 15 minutes. Just for making this issue, the first 3 times was quick deployment and the 4th was 15 minute wait, no changes in the scenario)

Pods are stuck in an Init state for this time. This behavior is also reported by a fellow colleague working on a different virtual machine
To Reproduce
Steps to reproduce the behavior:

Deploy AdvantEDGE core
Run kubectl get pods --all-namespaces | grep meep to verify  that only after 15 minutes, pods are in Running state
Create a new sandbox
Run kubectl get pods --all-namespaces to verify that only after 15 minutes, sandbox pods are in Running state
Deploy a simple scenario with one client application (Running on a UE) and one edge aplication.
Run kubectl get pods --all-namespaces to verify only after 15 minutes, application pods are in Running state

Expected behavior
Waiting time, specially for deploying an scenario should not be this long every time.
Screenshots

Scenario
Behavior was observed with different scenarios but I can provide the YAML file of the scenario used for this screenshots
AdvantEDGE versions
{
  "name": "meepctl",
  "version": "1.6.0"
}
{
  "name": ".meepctl-repocfg.yaml",
  "version": "1.6.0"
}
{
  "name": "meep-cert-manager",
  "version": "NA"
}
{
  "name": "couchdb",
  "version": "couchdb:2.1.1",
  "id": "c467d1c2a172bf0c8172b2e1c760686d0c7656d786e6874a9de12f2d0a3a38e7"
}
{
  "name": "docker-registry",
  "version": "registry:2.7.1",
  "id": "5bb9b919833aa955dfe1d1121cc038330b025ec6506ce47066c9192927e3dc3d"
}
{
  "name": "grafana",
  "version": "grafana/grafana:6.5.2",
  "id": "33d78da1e5f3f74833de2ba9303ddcf995da551850cf431696efd271e7928f9e"
}
{
  "name": "meep-influxdb",
  "version": "influxdb:1.7.6-alpine",
  "id": "4ba363315807fc6e35e98bc9d4760f417a681e4d3a547a0b24b135c56af96376"
}
{
  "name": "nginx-ingress-controller",
  "version": "quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.30.0",
  "id": "b312c91d0de688a21075078982b5e3a48b13b46eda4df743317d3059fc3ca0d9"
}
{
  "name": "kube-state-metrics",
  "version": "quay.io/coreos/kube-state-metrics:v1.4.0",
  "id": "6685342bbd645754b1aabdd9b663691109ec680645af261288289e62571ac201"
}
{
  "name": "meep-open-map-tiles",
  "version": "NA"
}
{
  "name": "meep-postgis",
  "version": "postgis/postgis:12-3.0",
  "id": "71acda16357f2973034483a4a8363cc9499061120b592bcc3b7f2fbed82da621"
}
{
  "name": "meep-redis",
  "version": "redislabs/rejson:1.0.4",
  "id": "08f1d67dacae984c17aa9869b05415abd453cdd642623718301267455d3e2696"
}
{
  "name": "helm",
  "version": "v3.3.4",
  "id": "a61ce5633af99708171414353ed49547cf05013d"
}
{
  "name": "docker client",
  "version": "19.03.14",
  "id": "5eb3275d40"
}
{
  "name": "docker server",
  "version": "19.03.14",
  "id": "5eb3275d40"
}
{
  "name": "k8s client",
  "version": "v1.19.1",
  "id": "206bcadf021e76c27513500ca24182692aabd17e"
}
{
  "name": "k8s server",
  "version": "v1.19.9",
  "id": "9dd794e454ac32d97cde41ae10be801ae98f75df"
}
{
  "name": "weave",
  "version": "weaveworks/weave-kube:2.8.1",
  "id": "d797338e7beb17222e10757b71400d8471bdbd9be13b5da38ce2ebf597fb4e63"
}
{
  "name": "meep-ingress-certs",
  "version": "NA"
}
{
  "name": "meep-mon-engine",
  "version": "meep-docker-registry:30001/meep-mon-engine:latest",
  "id": "595f67feecca5d1dd0e17dbf2f04a4a3c62068ffaf1e2ac2df72f55d5e323328",
  "build": "3ef4b4c2be74ff0d2c31468d764f9761ff6e7265b278ffb0ca511f9bd2cc2981"
}
{
  "name": "meep-platform-ctrl",
  "version": "meep-docker-registry:30001/meep-platform-ctrl:latest",
  "id": "380a13176c3434ab1db4928b3a220e94bb76f23edbfe195e40a7c265c223ac15",
  "build": "932abe8f68a0021ed35b18d936d2c6399f3a51012ddff87a7560f17fcbd798dd"
}
{
  "name": "meep-virt-engine",
  "version": "meep-docker-registry:30001/meep-virt-engine:latest",
  "id": "f70dea83788e8523534a480c76065e9bf47b4ace620521081e584eb114d2be8c",
  "build": "9ff7401de52f14fc4dcef1914f5b4c48423580c1632a9a33d230cdb117f6cf44"
}
{
  "name": "meep-webhook",
  "version": "meep-docker-registry:30001/meep-webhook:latest",
  "id": "9b9c321751c640ba450bac3601530db330e3a50789df8e71e491fb643aeb8e41",
  "build": "d6af3ed55530d0d40b7f7e649db3ef87ffa2651dc5c1819a10cb5fe114394ceb"
}

AdvantEDGE node:
Information on the node where AdvantEDGE is running
Virtual Machine with the following characteristics

OS: Ubuntu <IP_ADDRESS> Desktop x64
CPUs: 22
Memory: 32GB
Storage: 64GB

Additional context
When using kubectl describe to look into the pods state, it seems to be stuck in PodInitializing all of the 15 minutes with Restart Count:  0.  Below, the events when looking into the sandbox control pod:
Events:
  Type    Reason     Age   From                                        Message
  ----    ------     ----  ----                                        -------
  Normal  Scheduled  16m   default-scheduler                           Successfully assigned sandbox-diag/meep-sandbox-ctrl-586cb9d6d4-n97j7 to juan-standard-pc-i440fx-piix-1996
  Normal  Pulled     16m   kubelet, juan-standard-pc-i440fx-piix-1996  Container image "busybox:1.28" already present on machine
  Normal  Created    16m   kubelet, juan-standard-pc-i440fx-piix-1996  Created container init-kube-dns
  Normal  Started    16m   kubelet, juan-standard-pc-i440fx-piix-1996  Started container init-kube-dns
  Normal  Pulling    97s   kubelet, juan-standard-pc-i440fx-piix-1996  Pulling image "meep-docker-registry:30001/meep-sandbox-ctrl:latest"
  Normal  Pulled     97s   kubelet, juan-standard-pc-i440fx-piix-1996  Successfully pulled image "meep-docker-registry:30001/meep-sandbox-ctrl:latest" in 28.280311ms
  Normal  Created    96s   kubelet, juan-standard-pc-i440fx-piix-1996  Created container meep-sandbox-ctrl
  Normal  Started    96s   kubelet, juan-standard-pc-i440fx-piix-1996  Started container meep-sandbox-ctrl

Below is the output of describe for the application pod (events) of the time it took the 15 minutes. This behavior is strange because deploying the same pod manually (With kubectl) is much faster.
Events:
  Type    Reason     Age   From                                        Message
  ----    ------     ----  ----                                        -------
  Normal  Scheduled  16m   default-scheduler                           Successfully assigned sandbox-diag/diagnostics-client-app-6c97686bbb-x7zhd to juan-standard-pc-i440fx-piix-1996
  Normal  Pulled     16m   kubelet, juan-standard-pc-i440fx-piix-1996  Container image "busybox:1.28" already present on machine
  Normal  Created    16m   kubelet, juan-standard-pc-i440fx-piix-1996  Created container init-kube-dns
  Normal  Started    16m   kubelet, juan-standard-pc-i440fx-piix-1996  Started container init-kube-dns
  Normal  Pulling    104s  kubelet, juan-standard-pc-i440fx-piix-1996  Pulling image "jpcr3108/diagnostics_client:v1.5"
  Normal  Pulled     103s  kubelet, juan-standard-pc-i440fx-piix-1996  Successfully pulled image "jpcr3108/diagnostics_client:v1.5" in 1.651923307s
  Normal  Created    102s  kubelet, juan-standard-pc-i440fx-piix-1996  Created container diagnostics-client-app
  Normal  Started    102s  kubelet, juan-standard-pc-i440fx-piix-1996  Started container diagnostics-client-app
  Normal  Pulling    102s  kubelet, juan-standard-pc-i440fx-piix-1996  Pulling image "meep-docker-registry:30001/meep-tc-sidecar:latest"
  Normal  Pulled     102s  kubelet, juan-standard-pc-i440fx-piix-1996  Successfully pulled image "meep-docker-registry:30001/meep-tc-sidecar:latest" in 16.461287ms
  Normal  Created    102s  kubelet, juan-standard-pc-i440fx-piix-1996  Created container meep-tc-sidecar
  Normal  Started    102s  kubelet, juan-standard-pc-i440fx-piix-1996  Started container meep-tc-sidecar

Hi @juan-castrillon,
After some more investigation I have determined that the issue seems to occur only with the latest version of containerd (installed during Docker installation). Running docker version on my working setup returns the following:
Client: Docker Engine - Community
 Version:           19.03.15
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        99e3ed8919
 Built:             Sat Jan 30 03:16:51 2021
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.15
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.15
  Git commit:       99e3ed8919
  Built:            Sat Jan 30 03:15:20 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.3.7
  GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
 runc:
  Version:          1.0.0-rc10
  GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Kubernetes states that they support docker version 19.03; however, they do not specify a supported containerd version. The Docker installation procedure for Ubuntu is described here:
https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository
This procedure installs the latest ubuntu package containerd.io (currently version 1.4.4). This containerd version seems to cause problems when used with Kubernetes (tested with v1.19 & v1.20) & weave CNI plugin (tested with v2.6.2 & v2.8.1). I observe a maximum pod count of ~52 pods instead of the maximum allocatable value of 110. After 52 pods the pods remain stuck in PodInitializing or Creating state.
If you have a containerd version more recent than v1.3.7 this could also explain the behavior you are observing.
To fix this issue on my setup I reinstalled Kubernetes (Kubeadm) & Docker, bolting down the Docker & containerd versions. To do so, you must follow these steps:

Uninstall Kubeadm:
https://github.com/InterDigitalInc/AdvantEDGE/wiki/env-runtime#step-3---install-kubeadm-kubelet--kubectl-details
Uninstall docker:
https://docs.docker.com/engine/install/ubuntu/#uninstall-docker-engine
Reboot machine
Install docker
NOTE: Use the following command to set specific docker & containerd versions:
sudo apt-get install docker-ce=5:19.03.15~3-0~ubuntu-bionic docker-ce-cli=5:19.03.15~3-0~ubuntu-bionic containerd.io=1.3.7-1
https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository
Make sure docker daemon is configured to use systemd cgoup driver:
https://github.com/InterDigitalInc/AdvantEDGE/wiki/env-runtime#step-2---setup-docker-daemon-details
Install Kubernetes
NOTE: You can use the latest stable 1.20 release by installing these package versions:
sudo apt-get install -y kubelet=1.20.6-00 kubeadm=1.20.6-00 kubectl=1.20.6-00 kubernetes-cni=0.8.7-00
https://github.com/InterDigitalInc/AdvantEDGE/wiki/env-runtime#step-3---install-kubeadm-kubelet--kubectl-details
Complete kubeadm installation steps (up to step 7)
https://github.com/InterDigitalInc/AdvantEDGE/wiki/env-runtime#step-4---initialize-master-details

Once installed you can deploy the AdvantEDGE platform dependencies (this may take some time to download the images you may have removed during docker uninstall) and the AdvantEDGE core microservices. At this point the platform should be up & running and in a good state.
Please give this a try and let me know if it fixes the issues you have observed.
Thanks!

Moved to this discussion


reset explore changes

Changes to reset exploration - we want to reset the map builder and reset the _is_done_exploring flag in slam.
Stack from ghstack:

#911
#909
#900
#861
#860
#859
-> #858
#857
#856
#855
#854

stack merged in #910


React.PropTypes warning

I'm getting the following error in my console:

My current version of React is ^15.1.0. Let me know if you need any more details.

Hmm... strangely, reading through your src/index.js I can't see where that would be coming from.

It's right here:
https://github.com/insin/react-maskedinput/blob/master/src/index.js#L62
PR #94 would fix it... but looks like the maintainer of this repo is MIA...

@insin I think we're all waiting for this one. 😕
Please merge #94! 🙂


Determine how long Docker images are kept

The CI system now builds and pushes two Docker images for each commit on a PR or to main. This is convenient, but this convenience should be balanced against cost of storage. We should determine how long these images are stored, and possibly revise when they are pushed to GHCR.

Our IT team has let me know that our monthly budget for package storage is only 2GB! Due to this low budget, we should only push Docker images on tags.


Add some more OS

Name)_INFO="Nice name|Based of||homepage|_Description"

[x] agarimos)
[x] aix)
[-] alma)             INFO="Alma Linux|Fedora,RedHat||https://almalinux.org/ |Community owned and governed, forever-free enterprise Linux distribution, focused on long-term stability, providing a robust production-grade platform. AlmaLinux OS is binary compatible with RHEL®."
[-] alpine)           INFO="Alpine Linux|Independent||https://alpinelinux.org/ |Security-oriented, lightweight Linux distribution based on musl libc and busybox."
[x] android)          INFO="Android x86|Independent||https://www.android-x86.org/ |Port Android Open Source Project to x86 platform."
[x] antix)            INFO="Antix|Debian||https://antixlinux.com/ |Fast, lightweight and easy to install systemd-free linux live CD distribution based on Debian Stable for Intel-AMD x86 compatible systems."
[-] artixlinux)       INFO="Artix Linux|Arch||https://artixlinux.org/ |The Art of Linux. Simple. Fast. Systemd-free."
[-] archlinux)        INFO="Arch Linux|Independent||https://archlinux.org/ |Lightweight and flexible Linux® distribution that tries to Keep It Simple."
[-] archcraft)        INFO="Archcraft|Arch||https://archcraft.io/ |Yet another minimal Linux distribution, based on Arch Linux."
[x] archbang)
[-] arcolinux)        INFO="Arco Linux|Arch||https://arcolinux.com/ |Is all about becoming an expert in linux."
[x] aryalinux)
[x] athenaos)         INFO="Athena OS|Arch||https://athenaos.org/ |Offer a different experience than the most used pentesting distributions by providing only tools that fit with the user needs and improving the access to hacking resources and learning materials."
[x] backbox)
[ ] batocera)         INFO="Batocera|Independent||https://batocera.org/ |Retro-gaming distribution with the aim of turning any computer/nano computer into a gaming console during a game or permanently."
[ ] bazzite)          INFO="bazzite|Fedora,SteamOS||https://github.com/ublue-os/bazzite/ |Container native gaming and a ready-to-game SteamOS like."
[x] biglinux)
[ ] blendos)          INFO="BlendOS|Arch||https://blendos.co/ |A seamless blend of all Linux distributions. Allows you to have an immutable, atomic and declarative Arch Linux system, with application support from several Linux distributions & Android."
[x] bodhi)            INFO="Bodhi|Debian,Ubuntu||https://www.bodhilinux.com/ |Lightweight distribution featuring the fast & fully customizable Moksha Desktop."
[x] bunsenlabs)       INFO="Bunsenlab|Debian||https://www.bunsenlabs.org/ |Light-weight and easily customizable Openbox desktop. The project is a community continuation of CrunchBang Linux."
[ ] cachyos)          INFO="CachyOS|Arch||https://cachyos.org/ |Designed to deliver lightning-fast speeds and stability, ensuring a smooth and enjoyable computing experience every time you use it."
[ ] centos-stream)    INFO="CentOS Stream|Fedora,RedHat||https://www.centos.org/centos-stream/ |Continuously delivered distro that tracks just ahead of Red Hat Enterprise Linux (RHEL) development, positioned as a midstream between Fedora Linux and RHEL."
[x] cereus)
[ ] chimeralinux)     INFO="Chimera Linux|Independent|anon:chimera root:chimera|https://chimera-linux.org/ |Modern, general-purpose non-GNU Linux distribution."
[ ] crunchbang++)     INFO="#!++|Debian||https://www.crunchbangplusplus.org/ |The classic minimal crunchbang feel, now with debian 12 bookworm."
[-] debian)           INFO="Debian|Independent||https://www.debian.org/ |Complete Free Operating System with perfect level of ease of use and stability."
[-] deepin)           INFO="Deepin|Debian||https://www.deepin.org/ |Beautiful UI design, intimate human-computer interaction, and friendly community environment make you feel at home."
[-] devuan)           INFO="Devuan|Debian||https://www.devuan.org/ |Fork of Debian without systemd that allows users to reclaim control over their system by avoiding unnecessary entanglements and ensuring Init Freedom."
[x] dietpi)
[ ] dragonflybsd)     INFO="DragonFlyBSD|FreeBSD||https://www.dragonflybsd.org/ |Provides an opportunity for the BSD base to grow in an entirely different direction from the one taken in the FreeBSD, NetBSD, and OpenBSD series."
[ ] easyos)           INFO="EasyOS|Independent||https://easyos.org/ |Experimental distribution designed from scratch to support containers."
[x] eos)
[ ] edubuntu)         INFO="Edubuntu|Ubuntu||https://www.edubuntu.org/ |Stable, secure and privacy concious option for schools."
[-] elementary)       INFO="elementary OS|Debian,Ubuntu||https://elementary.io/ |Thoughtful, capable, and ethical replacement for Windows and macOS."
[-] endeavouros)      INFO="EndeavourOS|Arch||https://endeavouros.com/ |Provides an Arch experience without the hassle of installing it manually for both x86_64 and ARM systems."
[ ] endless)          INFO="Endless OS|Debian||https://www.endlessos.org/os |Completely Free, User-Friendly Operating System Packed with Educational Tools, Games, and More."
[-] fedora)           INFO="Fedora|Independent||https://www.fedoraproject.org/ |Innovative platform for hardware, clouds, and containers, built with love by you."
[ ] freebsd)          INFO="FreeBSD|Independent||https://www.freebsd.org/ |Operating system used to power modern servers, desktops, and embedded platforms."
[x] freedos)          INFO="FreeDOS|Independent||https://freedos.org/ |DOS-compatible operating system that you can use to play classic DOS games, run legacy business software, or develop embedded systems."
[-] garuda)           INFO="Garuda Linux|Arch||https://garudalinux.org/ |Feature rich and easy to use Linux distribution."
[-] gentoo)           INFO="Gentoo|Independent||https://www.gentoo.org/ |Highly flexible, source-based Linux distribution."
[x] ghostbsd)         INFO="GhostBSD|FreeBSD||https://www.ghostbsd.org/ |Simple, elegant desktop BSD Operating System."
[x] haiku)            INFO="Haiku|Independent||https://www.haiku-os.org/ |Specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful."
[x] holoiso)          INFO="SteamOS HoloISO|Arch,SteamOS||https://github.com/HoloISO/holoiso |Bring the Steam Decks SteamOS Holo redistribution and provide a close-to-official SteamOS experience."
[-] kali)             INFO="Kali|Debian||https://www.kali.org/ |The most advanced Penetration Testing Distribution."
[-] kdeneon)          INFO="KDE Neon|Debian,Ubuntu||https://neon.kde.org/ |Latest and greatest of KDE community software packaged on a rock-solid base."
[ ] kolibrios)        INFO="KolibriOS|Independent||http://kolibrios.org/en/ |Tiny yet incredibly powerful and fast operating system."
[-] kubuntu)          INFO="Kubuntu|Ubuntu||https://kubuntu.org/ |Free, complete, and open-source alternative to Microsoft Windows and Mac OS X which contains everything you need to work, play, or share."
[x] linuxlite)        INFO="Linux Lite|Debian,Ubuntu||https://www.linuxliteos.com/ |Your first simple, fast and free stop in the world of Linux."
[x] linuxmint)        INFO="Linux Mint|Debian,Ubuntu||https://linuxmint.com/ |Designed to work out of the box and comes fully equipped with the apps most people need."
[x] lmde)             INFO="Linux Mint Debian Edition|Debian||https://www.linuxmint.com/download_lmde.php |Aims to be as similar as possible to Linux Mint, but without using Ubuntu. The package base is provided by Debian instead."
[x] lubuntu)          INFO="Lubuntu|Ubuntu||https://lubuntu.me/ |Complete Operating System that ships the essential apps and services for daily use: office applications, PDF reader,  image editor, music and video players, etc. Using lightwave lxde/lxqt."
[x] mabox)
[-] mageia)           INFO="Mageia|Independent||https://www.mageia.org/ |Stable, secure operating system for desktop & server."
[-] manjaro)          INFO="Manjaro|Arch||https://manjaro.org/ |Versatile, free, and open-source Linux operating system designed with a strong focus on safeguarding user privacy and offering extensive control over hardware."
[-] mxlinux)          INFO="MX Linux|Debian,Antix||https://mxlinux.org/ |Designed to combine elegant and efficient desktops with high stability and solid performance."
[x] netboot)          INFO="netboot.xyz|iPXE||https://netboot.xyz/ |Your favorite operating systems in one place."
[x] netbsd)           INFO="NetBSD|Independent||https://www.netbsd.org/ |Free, fast, secure, and highly portable Unix-like Open Source operating system. It is available for a wide range of platforms, from large-scale servers and powerful desktop systems to handheld and embedded devices."
[x] nitrux)
[-] nixos)            INFO="NixOS|Independent||https://nixos.org/ |Linux distribution based on Nix package manager, tool that takes a unique approach to package management and system configuration."
[x] nobara)
[x] macos)            INFO="macOS|proprietary||https://www.apple.com/macos/ |Work and play on your Mac are even more powerful. Elevate your presence on video calls. Access information in all-new ways. Boost gaming performance. And discover even more ways to personalize your Mac."
[x] mandriva)
[x] midnightbsd)
[-] openbsd)          INFO="OpenBSD|Independent||https://www.openbsd.org/ |FREE, multi-platform 4.4BSD-based UNIX-like operating system. Our efforts emphasize portability, standardization, correctness, proactive security and integrated cryptography."
[ ] openindiana)      INFO="OpenIndiana|Solaris,OpenSolaris||https://www.openindiana.org/ |Community supported illumos-based operating system."
[x] openmandriva)
[-] opensuse)         INFO="openSUSE|Independent||https://www.opensuse.org/ |The makers choice for sysadmins, developers and desktop users."
[ ] oraclelinux)      INFO="Oracle Linux|RedHat||https://www.oracle.com/linux/ |Linux with everything required to deploy, optimize, and manage applications on-premises, in the cloud, and at the edge."
[ ] parrotsec)        INFO="Parrot Security|Debian|parrot:parrot|https://www.parrotsec.org/ |Provides a huge arsenal of tools, utilities and libraries that IT and security professionals can use to test and assess the security of their assets in a reliable, compliant and reproducible way."
[x] pclinuxos)
[ ] peppermint)       INFO="PeppermintOS|Debian,Devuan||https://peppermintos.com/ |Provides a user with the opportunity to build the system that best fits their needs. While at the same time providing a functioning OS with minimum hassle out of the box."
[-] popos)            INFO="Pop!_OS|Ubuntu||https://pop.system76.com/ |Operating system for STEM and creative professionals who use their computer as a tool to discover and create."
[ ] porteus)          INFO="Porteus|Slackware||http://www.porteus.org/ |Complete linux operating system that is optimized to run from CD, USB flash drive, hard drive, or other bootable storage media."
[ ] primtux)          INFO="PrimTux|Ubuntu||https://primtux.fr/ |Upgrade for obsolete equipment and benefiting the school or educational environment in the spirit of education."
[x] pureos)
[x] q4os)
[ ] reactos)          INFO="ReactOS|Independent||https://reactos.org/ |Imagine running your favorite Windows applications and drivers in an open-source environment you can trust."
[x] rebornos)         INFO="RebornOS|Arch||https://rebornos.org/ |Aiming to make Arch Linux as user friendly as possible by providing interface solutions to things you normally have to do in a terminal."
[x] regolith)
[-] rockylinux)       INFO="Rocky Linux|RedHat||https://rockylinux.org/ |Open-source enterprise operating system designed to be 100% bug-for-bug compatible with Red Hat Enterprise Linux®."
[x] siduction)        INFO="Siduction|Debian||https://siduction.org/ |Operating system based on the Linux kernel and the GNU project. In addition, there are applications and libraries from Debian."
[-] slackware)        INFO="Slackware|Independent||http://www.slackware.com/ |Advanced Linux operating system, designed with the twin goals of ease of use and stability as top priorities."
[ ] slax)             INFO="Slax|Debian Slackware||https://www.slax.org/ |Compact, fast, and modern Linux operating system that combines sleek design with modular approach. With the ability to run directly from a USB flash drive without the need for installation, Slax is truly portable and fits easily in your pocket."
[ ] slint)            INFO="Slint|Slackware||https://slint.fr/ |Slint is an easy-to-use, versatile, blind-friendly Linux distribution for 64-bit computers. Slint is based on Slackware and borrows tools from Salix. Maintainer: Didier Spaier."
[x] slitaz)           INFO="SliTaz|Independent||https://www.slitaz.org/en/ |Simple, fast and low resource Linux OS for servers & desktops."
[x] smartos
[-] solus)            INFO="Solus|Independent||https://getsol.us/ |Designed for home computing. Every tweak enables us to deliver a cohesive computing experience."
[ ] sparkylinux)      INFO="SparkyLinux|Debian||https://sparkylinux.org/ |Fast, lightweight and fully customizable operating system which offers several versions for different use cases."
[ ] spirallinux)      INFO="Spiral Linux|Debian||https://spirallinux.github.io/ |Selection of Linux spins built from Debian GNU/Linux, with a focus on simplicity and out-of-the-box usability across all the major desktop environments."
[-] tails)            INFO="Tails|Debian||https://tails.net/ |Portable operating system that protects against surveillance and censorship."
[ ] tinycore)         INFO="Tiny Core Linux|Independent||http://www.tinycorelinux.net/ |Highly modular based system with community build extensions."
[ ] trisquel)         INFO="Trisquel|Debian,Ubuntu||https://trisquel.info/ |Fully free operating system for home users, small enterprises and educational centers."
[x] truenos)
[x] truenas-core)     INFO="TrueNAS Core|FreeBSD||https://www.truenas.com/truenas-core/ |World’s most popular storage OS because it gives you the power to build your own professional-grade storage system to use in a variety of data-intensive applications without any software costs."
[ ] truenas-scale)    INFO="TrueNAS Scale|Debian||https://www.truenas.com/truenas-scale/ |Open Source Hyperconverged Infrastructure (HCI) solution. In addition to powerful scale-out storage capabilities, SCALE adds Linux Containers and VMs (KVM) so apps run closer to data."
[x] tuxedoos)
[-] ubuntu)           INFO="Ubuntu|Debian||https://ubuntu.com/ |Complete desktop Linux operating system, freely available with both community and professional support."
[x] ubuntu-budgie)    INFO="Ubuntu Budgie|Ubuntu||https://ubuntubudgie.org/ |Community developed distribution, integrating the Budgie Desktop Environment with Ubuntu at its core."
[ ] ubuntucinnamon)   INFO="Ubuntu Cinnamon|Ubuntu||https://ubuntucinnamon.org/ |Community-driven, featuring Linux Mint’s Cinnamon Desktop with Ubuntu at the core, packed fast and full of features, here is the most traditionally modern desktop you will ever love."
[x] ubuntukylin)      INFO="Ubuntu Kylin|Ubuntu||https://ubuntukylin.com/ |Universal desktop operating system for personal computers, laptops, and embedded devices. It is dedicated to bringing a smarter user experience to users all over the world."
[x] ubuntu-mate)      INFO="Ubuntu MATE|Ubuntu||https://ubuntu-mate.org/ |Stable, easy-to-use operating system with a configurable desktop environment. It is ideal for those who want the most out of their computers and prefer a traditional desktop metaphor. Using Mate desktop."
[ ] ubuntu-server)    INFO="Ubuntu Server|Ubuntu||https://ubuntu.com/server |Brings economic and technical scalability to your datacentre, public or private. Whether you want to deploy an OpenStack cloud, a Kubernetes cluster or a 50,000-node render farm, Ubuntu Server delivers the best value scale-out performance available."
[x] ubuntustudio)     INFO="Ubuntu Studio|Ubuntu||https://ubuntustudio.org/ |Comes preinstalled with a selection of the most common free multimedia applications available, and is configured for best performance for various purposes: Audio, Graphics, Video, Photography and Publishing."
[ ] ubuntu-unity)     INFO="Ubuntu Unity|Ubuntu||https://ubuntuunity.org/ |Flavor of Ubuntu featuring the Unity7 desktop environment (the default desktop environment used by Ubuntu from 2010-2017)."
[x] ultimate-edition)
[x] ultramarine)
[-] vanillaos)        INFO="Vanilla OS|Debian,Ubuntu||https://vanillaos.org/ |Designed to be a reliable and productive operating system for your daily work."
[-] void)             INFO="Void Linux|Independent|anon:voidlinux|https://voidlinux.org/ |General purpose operating system. Its package system allows you to quickly install, update and remove software; software is provided in binary packages or can be built directly from sources."
[x] vxlinux)          INFO="VX Linux|Void||https://vxlinux.org/ |Pre-configured, secure systemd-free Plasma desktop with focus on convenience, performance and simplicity. Based on the excellent Void Linux."
[ ] whonix)           INFO="Whonix|Debian||https://www.whonix.org/ |Superior Internet Privacy with Whonix™ As handy as an app - delivering maximum anonymity and security."
[x] windows)          INFO="Windows|proprietary||https://www.microsoft.com/en-us/windows/ |Whether you’re gaming, studying, running a business, or running a household, Windows helps you get it done."
[ ] windows-server)   INFO="Windows Server|proprietary||https://www.microsoft.com/en-us/windows-server/ |Platform for building an infrastructure of connected applications, networks, and web services."
[-] xerolinux)        INFO="XeroLinux|Arch||https://xerolinux.xyz/ |Arch-Based Distro, that provides you with an easy way to install Arch and a well optimized, beautifully Customized Plasma Desktop, that you can later shape to suite your needs!"
[x] xubuntu)          INFO="Xubuntu|Ubuntu||https://xubuntu.org/ |Elegant and easy to use operating system. Xubuntu comes with Xfce, which is a stable, light and configurable desktop environment."
[-] zorin)            INFO="Zorin OS|Ubuntu||https://zorin.com/os/ |Alternative to Windows and macOS designed to make your computer faster, more powerful, secure, and privacy-respecting."

Sorry that is bit ugly but cuted from my PR to quickemu..

[x] Included in this PR
[-] Already in font-logos repo
[ ] TODO
All lines with INFO= are OS included in quickemu
just names are included in this PR but not in quickemu (some in my advanced fork)

PS: Missed info will be added later if needed...

I already forgot where was gathered..
But using mostly this logos

No description, no other info, too many on one PR, I'm not going to review this, sorry.

I will add info later..
Not sure what everything needs to be included.
icons.tsv will be filled accordingly
Not did it yet, because don't know if anything from me will be merged...
PS: I can split it, but less PRs, better for me.

My use case in terminal for most of included icons are my TUIs/GUIs for quickemu.
One currently using svg icons (in color) and nerd fonts together. So if everything will be included in nerd fonts... (Thanks to your project)

I don't really need to push it here anymore.
Since I builded, can patch nerd fonts easily..
Thanks for teach me about fonts in general and how to create them. ❤
In reward, I wanted help you a bit, but if you don't want...
Up to you
But thanks again for nice project anyway 💌

No description, no other info, too many on one PR, I'm not going to review this, sorry.

Is it enough description here, or I need add more? (Lines without any info will be added..)
Needed for quickemu anyway :wink:

It seems for now we have 118/256 occupied glyphs, about 46%. Merging it would go to about 65% +19%, it's quite a lot.
I think we need planning on how to use the unused codepoints. There are a lot of categories for different FOSS projects, the feedback from users can help to decide what goes in.
Also Android is already on NF, MacOS and Windows are not FOSS.

We can close this if you don't want merge all needed OSes
Operating Systems logos font (for quickemu UIs)
Just released


[ZEPPELIN-5116] Accessing zeppelin via knox after knox logout should be redirected to  knox login page

What is this PR for?
When zeppelin is running under kerberosRealm the logout doesn't work, it should be redirected to knox login page. With this PR, a fix for this is provided.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-5116
How should this be tested?

Created a cluster
Deploy the changes to the cluster
Added respective entries in shiro.ini
Performed logout and tested

@VipinRathor @prabhjyotsingh @zjffdu  can you please help in reviewing

@PrarthiJain  can you fix https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/components/navbar/navbar.controller.js#L110 as well, right now it only refreshes when API returns a non-20x response.

Looks good to me, @PrarthiJain can you paste you travis-build link as well?

Thanks, @prabhjyotsingh for reviewing. Here is the Travis-build link: https://travis-ci.com/github/PrarthiJain/zeppelin/builds/197124228


Update metrics config to global

What was changed

Per-service metrics config is deprecated. Use global config section instead.
Why?

Checklist

Closes

How was this tested:

manual helm template run

Any docs updates needed?

I'll close this pr for now. Will update after some more discussion.


look_at sometimes flips Y axis

Operating system or device - Godot version:
Linux, 53c23b02226968d27e6caadcb801343697ac4fe9
Issue description:
In my game I have enemies which are in each frame using model.look_at(target_direction, Vector3(0,1,0)). In recent build I noticed hose models are rarely for short period of time upside down:

I did bisection and I found that 53c23b02226968d27e6caadcb801343697ac4fe9 introduced this behavior to my games... But so far failed at providing reproduction project :(
Steps to reproduce:
Still working on it...
Link to minimal example project:

@tagcup do you have by any chance any idea what this might be about?

In the provided gif, they are upside down in those frames when target_look_direction.z is negative. Still haven't reproduced this yet...

I finally managed to nail down the this issue... applying scale to the object that looks in z positive direction results in a model that is turned upside down, don't seems like it has anything to do with look_at.  I think I will close this one and open new issue.

For the reference, new issue: https://github.com/godotengine/godot/issues/10352


Ripple reaches out of bounds

I'm building an app with React Toolbox and on the left-hand side I have a list with list items that have a "to" attribute so they are links. When you click them though, the ripple effects reaches outside the button, any ideas why?
You can try it here: http://reagent-toolbox-docs.dashman.tech/

refer #1205


react rule state-in-constructor

Rule react/state-in-constructor
#341

@aravind1078 thank you for your PR! You might want to run scripts/dev-rome check --apply and commit the changes!

@aravind1078 thank you for your PR! You might want to run scripts/dev-rome check --apply and commit the changes! This should fix some problems occurring in the CI

yup just noticed it...

@ematipico looks like there is one more problem with generated files check... can I do something to fix that ?

It looks good now! Great job!

Hey! Thanks for the PR! I'm not sure if it makes sense for us to have this rule. We haven't yet figured out what patterns we want to encourage and I think this one is too restrictive. Other core contributors may have some thoughts. Happy to defer.

Hey! Thanks for the PR! I'm not sure if it makes sense for us to have this rule. We haven't yet figured out what patterns we want to encourage and I think this one is too restrictive. Other core contributors may have some thoughts. Happy to defer.

Yeah it does seem but i think its good to have uniformity across the project it could be inside/outside the constructor. React-eslint does provide that flexibility to toggle between inside and outside the constructor but am not sure whether we can do that here. Would like to hear what others think. Thoughts ? @ematipico @bitpshr @VictorHom

Rome doesn’t have any lint options and I don’t think we intend on having them, which is why making these decisions is so difficult since well be forcing Rome users into these patterns.

Personally, I would like to have the choice. Forcing the definition of this.state inside the constructor would force to always implement super() even when it is not necessary.
Usually I define state inside the constructor only if I need to compute the state from the props. Otherwise, as a property of the class is fine. Does this lead to errors or is it just code style? If it is just the latter, I would not enforce this rule.

After thinking about this a bit more, I also feel that this may be too restrictive of a rule. Apologies for not calling this out sooner @aravind1078.
It's difficult to justify subjectively initializing state in the constructor when initial values are not computed and don't actually require initialization. In these cases, it feels like using class properties would be the preferred style choice. For example, the following feels less error-prone than overriding the constructor and remembering to properly call super:
class Foo extends React.Component {
    state = { open: true };
   // ...
}

Like @sebmck said, Rome has no configuration and can be thought of as an "all or nothing" code standardizer, so subjective rules should be limited to only those with wide community support. Unless there are objective reasons to encourage constructor-based initialization beyond consistency with other codebases, I feel that we should close this rule for now and revisit it in the future if there's ever community desire.

Sure no problem. Thanks for your inputs. I will close this pr for now then. Since react-rules are now paused. Please let me know if there is something open for contributions. Eager and Happy to contribute. Cheers!!


Update msal-browser README with sample links

This PR updates the sample links in the msal-browser README.md, as well as adding links to to the TypeScriptTestApp2.0 sample.
This PR addresses #1976

Coverage remained the same at 81.689% when pulling eecddb9b13c2928cfca234bdd868e0d7edf30344 on browser-sample-link-fix into f3cc6aa1814faf11155305adc1553a9ba91d8ae2 on dev.

@jhutchings1 Any insight into why the CodeQL step is failing? Thanks!

@jasonnutter Error #32 means that there was no source seen in a particular language. Looks like an issue with the Java analysis. The quick solution is to disable Java and focus on the JS instead. I'll send you a PR.


[Bug]: OS-dashboards Docker image 3.0.0 does not work "Cannot find module 'performance-now'"

Describe the bug
When trying to spin up a cluster with Docker, swapping all the images to image: opensearchstaging/opensearch:3.0.0 should work. Unfortunately, the dashboards image image: opensearchstaging/opensearch-dashboards:3.0.0 fails. See below for the log output. Looks, like a module is missing that was expected from observabability dashboards.
To reproduce
Take sample docker-compose from website then swap in image: opensearchstaging/opensearch:3.0.0 and image: opensearchstaging/opensearch-dashboards:3.0.0 for the node and dashboards images.
Expected behavior
The cluster should spin up when the version is valid.
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
This issue does not happen on 2.5.0 or 2.6.0, just when trying to use an image of main.
Relevant log output
{"type":"log","@timestamp":"2023-03-23T15:19:16Z","tags":["fatal","root"],"pid":1,"message":"Error: Cannot find module 'performance-now'\nRequire stack:\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/default_backend.js\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/index.js\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/notebooks/paraRouter.js\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/index.js\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/plugin.js\n- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/index.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/index.js\n- /usr/share/opensearch-dashboards/src/core/server/index.js\n- /usr/share/opensearch-dashboards/src/cli/serve/serve.js\n- /usr/share/opensearch-dashboards/src/cli/cli.js\n- /usr/share/opensearch-dashboards/src/cli/dist.js\n    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:61:29)\n    at require (internal/modules/cjs/helpers.js:101:18)\n    at Object.<anonymous> (/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/default_backend.ts:6:1)\n    at Module._compile (internal/modules/cjs/loader.js:1085:14)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)\n    at Module.load (internal/modules/cjs/loader.js:950:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:790:12)\n    at Module.require (internal/modules/cjs/loader.js:974:19)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39)\n    at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39)\n    at require (internal/modules/cjs/helpers.js:101:18)\n    at Object.<anonymous> (/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/index.ts:7:1) {\n  code: 'MODULE_NOT_FOUND',\n  requireStack: [\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/default_backend.js',\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/index.js',\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/notebooks/paraRouter.js',\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/index.js',\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/plugin.js',\n    '/usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/index.js',\n    '/usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js',\n    '/usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js',\n    '/usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js',\n    '/usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js',\n    '/usr/share/opensearch-dashboards/src/core/server/plugins/index.js',\n    '/usr/share/opensearch-dashboards/src/core/server/index.js',\n    '/usr/share/opensearch-dashboards/src/cli/serve/serve.js',\n    '/usr/share/opensearch-dashboards/src/cli/cli.js',\n    '/usr/share/opensearch-dashboards/src/cli/dist.js'\n  ]\n}"}

 FATAL  Error: Cannot find module 'performance-now'
Require stack:
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/default_backend.js
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/index.js
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/notebooks/paraRouter.js
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/index.js
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/plugin.js
- /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/index.js
- /usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js
- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js
- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js
- /usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js
- /usr/share/opensearch-dashboards/src/core/server/plugins/index.js
- /usr/share/opensearch-dashboards/src/core/server/index.js
- /usr/share/opensearch-dashboards/src/cli/serve/serve.js
- /usr/share/opensearch-dashboards/src/cli/cli.js
- /usr/share/opensearch-dashboards/src/cli/dist.js

Moving it to observability dashboards repo. Can someone from @opensearch-project/observability @anirudha take a look at this issue?

@scrawfor99  could you please test it now. we have merged the fix yesterday.
@bbarani  How can we know the timestamp of last published staging docker build?

Hi @vamsi-amazon, I just checked and this is the current output:
os-docker-opensearch-dashboards-1  |
os-docker-opensearch-dashboards-1  |  FATAL  Error: Cannot find module 'performance-now'
os-docker-opensearch-dashboards-1  | Require stack:
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/default_backend.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/adaptors/notebooks/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/notebooks/paraRouter.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/routes/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/plugin.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/plugins/observabilityDashboards/server/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/plugins/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/core/server/index.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/cli/serve/serve.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/cli/cli.js
os-docker-opensearch-dashboards-1  | - /usr/share/opensearch-dashboards/src/cli/dist.js
os-docker-opensearch-dashboards-1  |
os-docker-opensearch-dashboards-1 exited with code 1

Looks like there is still something missing from the distribution on staging. You can check this by using the default docker setup on the documentation page. You will just need to swap the plain docker-compose with one which reads opensearchstaging/opensearch:3.0.0 or opensearchstaging/opensearch-dashboards:3.0.0` where appropriate.

@scrawfor99 The staging docker image for opensearch-dashboards:3.0.0 seems to be an old one. It was published 2 months back.
Need some input from @bbarani here to see when will the next staging publish happen.

Done


Please post here if you can run Meow on a large dataset!

Hash tests are hard to come by, so testing Meow has been a mix of us testing our dataset for collisions and verifying that smhasher doesn't find anything suspicious.  But that's not really sufficient.  Anyone particularly interested in trying out Meow who has a large dataset test, please post here so I can coordinate with you as I try to finalize the finer points of the implementation.  It would be very nice to be able to verify that we don't break anything with changes!
Thanks,
- Casey
PS.  And I guess even if you don't have a large dataset, if you just have some useful hashing case that might find collisions we don't know about, that helps too!

Hello!
I wrote a (terrible) testing tool (which I'll not release due to the terrible code) and tested @elixire's image database (which contained 116275 unique images at the time of this test) with meow.
In the end I found 13 collisions. There's some relevant information here but overall it'll be useless without the files themselves (see bottom for more information about them):
512b collision found on /home/elixire/elixire/images/0/0344d20115f24ac00d6a13451b69725680cdf8fe4b09f50b15793d1cf6e500ec.a, prev on /home/elixire/elixire/images/0/020eb2406e841bb696fe7893ec7dd2e744228f133949fec7e835d490e879f0aa.png
    16085343-C5231457-C21CC8EF-A0FB6063 D0C7D198-AF1398A7-300DCDBE-4D12D370
    503B7AD3-9AF85B58-5D874BD6-D7399A16 F870D6D2-90BB54D1-67C0E2E6-19C12B83

512b collision found on /home/elixire/elixire/images/4/45091ded5e28408daeb05d97c9dee6f7188dd52278dfba3dbf01c7bf85f413eb, prev on /home/elixire/elixire/images/4/4e9b524fbae3c735c71f738d63362379f294930f2603d54dcf0a81cf908a8611.png
    6921AB42-2AC9DC20-18FD8C44-C4FB0CDF 2F43440E-3AA56D48-539BE78C-827A39E7
    30702F50-2C166578-19C59A34-A41B3AD6 42FC5EE7-C92FA010-48699D26-3B2DD1D6

512b collision found on /home/elixire/elixire/images/8/8333583c5a1b06a03ae2ffa562f6afc4f40e336d316b753f0e3e7c77f66bdf98, prev on /home/elixire/elixire/images/8/8dea60fec26a04d75af2d55bac78689b552c24e00b806c383268f6a1a84c9139.png
    C6F1E3B5-0E4B20E5-A4F982B6-E7AB5C7E BAF5E5F4-B2A0D3EC-2A4C57D8-BB762BC2
    276E27C6-E91CF118-D850A76D-E39B69EB 28217905-820BDA79-019ADADE-0EB0DA59

512b collision found on /home/elixire/elixire/images/5/594c41df3803343e1e68b554fc048faa7d0eef1b9bd01a088c30b6c6379bb555.a, prev on /home/elixire/elixire/images/5/58f4efcd23692e92cafdd0760d60c22555c6f53cf20e4fc6227308a6c91c66b7.png
    48B8DFCC-A17F7839-1D0B4234-B2D95373 ECDB27E2-8E16EA54-38853FBD-9C8D39C2
    56F7AB29-FC03B560-320AF1FC-EB21C7F7 23A29E62-99B766DC-302BEB6E-AE68BF7F

512b collision found on /home/elixire/elixire/images/a/a5ce1fc952617593233b4581de5c7fc787be9561ba268aa362ee6eeb5dbab4cd.a, prev on /home/elixire/elixire/images/a/abb2eab0eef9645973cdbd055d5cbface5e1646286fe7524f0bd3a784a171b45.png
    2DADB7EF-F1044DCB-7EEF651E-4C0F7937 089DAA95-AB2AE79A-48AC58FB-9A951577
    4026A0E4-D438C4A2-61C660E2-97FDCAB0 43438359-F8179CDA-323BC39D-87CB4594

512b collision found on /home/elixire/elixire/images/9/9aa8308660421b115d79a12f5b924da6df2f847c0e0999802b2d14ed0c0b68cc.mp4, prev on /home/elixire/elixire/images/9/97749f72e9d571c3cda0091eba6e4d16fe0c12c623c933ad008b42c11ba7009b.png
    5884B4F7-FDBDC14A-01276417-4FF0AEBE BFA621CA-F89CFCE8-257DD2BA-0C566587
    A0C68D7F-4A0C1938-40CDD295-B909BB7E C9F5B305-A9E8FBAE-09BEC8BF-AAFE55B7

512b collision found on /home/elixire/elixire/images/9/92b6244f6ea31f666ffa2e34836f29c8eef009c2d30770e8f90ba6ff29ecc34e, prev on /home/elixire/elixire/images/9/9d9413239486bcde407db8c4db288f69e824015f554152c34b738dff7fdedb4f.png
    0020EC7D-43A56393-AD572478-9073AB55 27573B94-65F10EDE-68DC4B73-20BE7702
    39BAE273-2CAB6136-D5DC2B10-1BA16DA6 ED85E19F-E3F1BAB3-F95BC2BD-C294654A

512b collision found on /home/elixire/elixire/images/6/61c2055bbded8bc6a5094a81c355b9db9e07e0a1646c14b6b811d98edbf4fa3d.a, prev on /home/elixire/elixire/images/6/693705033cff0c1ff465f56f5ee689c64deecea7890bffba6757be159642e747.png
    B33EBE1A-977CC27D-F6245928-5633B169 BB200935-8A39E282-E53613B6-0657AFCD
    9995C798-ECB8711B-7272A2DF-B8B80613 36F8A3FB-6BECF882-75719EC3-141D6A9E

512b collision found on /home/elixire/elixire/images/e/ea4773089bc133dc675b9e5d204ff892d3b492d730901362641213ce68324e8f.diff, prev on /home/elixire/elixire/images/e/e40e3f0296a232b3a4c3277c0f63674c046b928008c3c5a45b80d284ad2acefd.png
    F67884B4-60E3EE07-41F154D5-E013758B F13E763B-75189041-0B1BED4F-D153C74F
    84745696-DF172BE6-7E44AF7E-A0A5BB6A E1C29690-B2FFF1E8-8B79F967-D9FD3F24

512b collision found on /home/elixire/elixire/images/e/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, prev on /home/elixire/elixire/images/e/e2e277754e52134d949d632cc1c9f70696f893754cd2f5d45750405efcdb95e5.png
    1FE6423A-82F81B46-3147FFF8-9F3D3B34 1FE6423A-82F81B46-3147FFF8-9F3D3B34
    1FE6423A-82F81B46-3147FFF8-9F3D3B34 1FE6423A-82F81B46-3147FFF8-9F3D3B34

512b collision found on /home/elixire/elixire/images/3/39639c94587e4602695846b3f39895fa33ce54c9847174dfa0997eaca86d744f.jpg, prev on /home/elixire/elixire/images/3/3aedd8b209e0d887d60b91b2c07815dd935e819eebf795cd311ac25fcc26fd03.png
    EE66394D-19E4A2F9-ED775D18-581B504E A133E1EF-91EDA6AC-A56CFC1D-DAD7CF3D
    1CC710BD-2E0F167F-C8DEBAD7-5236DF47 6DEC75F5-DE20B5BE-531A823C-6F96CD73

512b collision found on /home/elixire/elixire/images/3/3867ace1999377aa2ae7596a09dc2d9dc56079b06ca81863d27961a9f1294723.a, prev on /home/elixire/elixire/images/3/3806faf92cbf32cb620c5356eb08c4c51312f3a9216bfcf450c9c4adb43c4fe8.png
    9719599C-7A8D21FA-9EA5469A-CE0BC8B5 DACF079C-58242403-28F64A70-EF23A9B0
    B6FB41A3-1D7C6CD8-DD5D60D4-465412FA AD6BA2B8-815DFDB1-9623D999-DE5CFACA

512b collision found on /home/elixire/elixire/images/7/776740f4c805bdff46ee3230513018ec52c26496add39d6c753d98bf686534b2, prev on /home/elixire/elixire/images/7/73a15c2e7d6f852c73c71812ed82f81f15b1d740377b1b6f239f4ce36a39ecbe.png
    D7B18DC8-648EA5FB-566FB7EF-A396029D 07C87AAC-CE1E12DD-FE97BA16-4ECA8652
    DB5807D6-EE794CF1-3B06E998-E3C360A3 0F0B1B9A-C1CE1A9E-8BDEDAF9-E888EEBF

I'll try to contact owners of those files to see if they're okay with the files being shared here for research purposes.

Stupid question @aveao but did you confirm the files were actually different? Is that what the following lines are?

@Qix- They are different, yes. The filenames are their SHA256 hashes.

@aveao That would be very helpful.  Although I suspect we do not actually need the files if you can't get them, because honestly we probably won't update the main loop of Meow hash, so it would only matter if the output of the main loop was different but the hash was not.
So maybe as a middle ground for now, could you send the complete values of S0123, S4567, S89AB, SCDEF as they are at the end of the function?  If they are the same for the collisions, they are probably unfixable collisions.  But if they are different, then it's our mixdown that is at fault and we can probably improve the mixdown to make them not collide, which would be very good to do!
Thanks,

Casey

PS. My e-mail address is<EMAIL_ADDRESS>if you'd like to send files.

I threw all of Battlefield 5's content at it.
Running into 14,371 collisions, over 338,760 files, about 29.6GB.
I'll email you the complete values of S0123, S4567, S89AB, SCDEF for all collision pairs.

This is wonderful!  Thank you very much!  I will look at these today.

Casey

Curious @tvandijck - any triple-pairs? As in, are there any three-or-more groups of files that all collide? Or are they all double pairs?

@qix I have 120 pairs, 17 triplets, 4 quadruplets, and 2 quintuplets...

Have to correct my stats.... my testing code was bugged :( crazy little typo and embarrassing stuff..
don't open and read binary files with fopen(filename, "r")
Anyway... with that corrected... 0 collisions for BF5. I'll see if I can throw Battlefront 2 at it later today.

Battlefront 2 + Battlefield 5 data together in one database....
92.2 GB over 946,378 files...
0 collisions with truncation down to 128-bit.

That sounds more like it :)  Thanks for testing!
So we are now down to only one person (@aveao) who has reported 13 collisions, but we have not heard anything more from them.  Can we verify that these are real collisions somehow, and if they are, get some repro cases?  I still have found zero collisions for Meow and so I really need more testing...

Casey

In @aveao collisions the first "letter" of the SHA256 of every conflict happens to be identical on the two files colliding. That seems very peculiar, definitely seems worth double checking that test code.

Is there some way to send a message to a GitHub user?  If we can't contact @aveao, then I'm going to call it a misreport for now, since it does seem awfully suspicious and we can't get the files to verify.
- Casey

I've got access to 140TB of audio data, with files ranging in size from 10MB to 2GB, which are all unique in terms of SHA256.  Would you be interested in me running meow_hash across it?

@atruskie That sounds fantastic.

@cmuratori I'm working on an official collision tester that I'll PR in by the way. Im also getting it to work on clang/MacOS.

@qix, I put mine in a gist here: https://gist.github.com/tvandijck/e8ac50f01b6c656f5599d50b83e35ca9
it's windows only though...

I'm debugging a few issues so it might be a little while. I'm using an mmap solution that I'll have to port to windows at some point (or just fall back to using regular streaming, but I wanted to avoid using buffers for the sake of I/O throughput).
It's almost done, I'm just working through a bit of a puddle of platform issues, most of which I'll submit as separate PRs.

Collision checker has been PR'd into #15. There are a number of dependency PR's and windows support needs to be tested (sorry).

Looking to use this as a block hash for a game deployment pipeline: ~400 builds of ~200-500MB each chunked into 1MB blocks. Total is ~40GB. Will test this sometime soon.

I've run meow hash on 2709214 files on Linux distribution build folder which has all the source code, build temporary files, output packages, compiler, dependencies, sysroot - a lot of stuff. Total size 131GB.
No collisions. Both for 512-bit hash output, or when truncated to first 128 bits.

Ran it on approximately 41,000 separate 1MB chunks of mostly LZMA compressed game bundles. 0 collisions.

Meow v0.2 is now available and includes a collision search utility called "meow_search".  It should build on both Windows/MSVC and Linux/CLANG, so you can search Windows machines or Linux machines for files that produce hash collisions.  Hopefully it is robust.  Please report any bugs!
It will report collisions for 128-bit, and also 64-bit and 32-bit truncations.  I have not found any 128-bit or 64-bit collisions.  32-bit collisions are expected on anything in the tens-of-thousands range, so I have found some but they were expected - however it is still useful to note them, just in case they show up in suspiciously large numbers!
The hashing function has been changed to be more efficient in this version, and may have been weakened, so if everyone who has a chance could re-run their datasets with v0.2, that would be very much appreciated!  Barring major revelations, this is basically the construction Meow will use, so I'd like to get it thoroughly vetted against as many datasets as possible.
Thanks,
- Casey

Just ran Meow v0.2 on parts of our Mercurial repository store.
The "regular versioned source files" part:
meow_search 0.2/Ragdoll results:
    Root: /Users/aras/unity/graphics/.hg/store
    Completed on: Sat Oct 27 08:41:34 2018
    Files: 285500
    Total size: 18gb
    Duplicate files: 12457
    Access failures: 0
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 13
    <list of collisions; expected for 32 bit>

The "large versioned binary files" part:
meow_search 0.2/Ragdoll results:
    Root: /Users/aras/unity/graphics/.hg/largefiles
    Completed on: Sat Oct 27 08:38:39 2018
    Files: 938
    Total size: 31gb
    Duplicate files: 0
    Access failures: 0
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 0

Well... I just ran meow_search and it did find 13 dupes.
Yes, dupes, not collisions. Sigh. But why did they get different SHA256 hashes? Why did they look different when I observed them? Well that's up to us to determine now I suppose.
It's good to know that I'm not going crazy, and that I can actually write acceptable C++.
But yes, there's 2 meow 32-bit 128-wide collisions:
meow_search 0.2/Ragdoll results:
    Root: /home/elixire/elixire/images
    Completed on: Sat Oct 27 08:31:16 2018
    Files: 120204
    Total size: 22gb
    Duplicate files: 13
    Access failures: 21
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 2
        00000000-00000000-00000000-6BFA518B:
            /home/elixire/elixire/images/3/3b352d0439009a4af1514db9ae466a0c1398075ef74fe99fb8746725a3727b09.png
            /home/elixire/elixire/images/f/fd645dcd303959facc4864a0ce48125ddbfbd55128402a8bbbf857ccff0096a1.png
        00000000-00000000-00000000-F748E353:
            /home/elixire/elixire/images/6/66d3f7a0eefd88a254d460e23aac31f9cb0e101919978a032e8a2b0d5fe13725.png
            /home/elixire/elixire/images/f/f21859d7210a4060c906b242a446e5e2207edd90e08110aee1387d9c1f22c5ff.png

Wouldn't it be better to have a Makefile instead of a build.sh btw?

Run again on my Linux build folder, no meow128 collisions:
    Files: 2758869
    Total size: 132gb
    Duplicate files: 1660001
    Access failures: 0
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 762

Large amount of duplicates is expected result.

@cmuratori they probably are, I doubt that we found 13 or even 1 sha256 collision.

@aveao But I thought you said they had different SHA256 hashes?  Is your SHA hashing code messed up, maybe?

Casey

If you're looking for collisions, I found a 128-bit collision in https://github.com/dvyukov/go-fuzz-corpus
[Meow128] Meow 128-bit AES-NI 128-wide collisions: 1
        D45A69A1-1ACC0AD1-9E7602B3-E1CE650F:
            dvyukov/go-fuzz-corpus/htmltemplate/corpus/88a5085c17659654909710074e536e95d2be3acc-18
            dvyukov/go-fuzz-corpus/url/values/corpus/f85d300aa6ced0edf61be35bc8d45c0c0adf961b

One consists of 65 %, the other 65 ;.

Yes!  That is very helpful.  I will download the corpus and try to repro it.
Which Meow hash was this?  (v0.1 or v0.2)
Thanks,
- Casey

This was at git sha1 67ac7f3a816aca42efb266b9fde8f23940fe3137, so currently HEAD.

There is a new candidate for v0.3 (see the v0.3 branch).  It does not collide on go-fuzz, but it has also not been tested on any of the large datasets that folks have tested prior, so we may have some regressions.  Any testing of the new function would be greatly appreciated, and if you can find any collisions please send them!
Thanks,
- Casey

Just ran Meow v0.3 on parts of our Mercurial repository store, similar to previous test on v0.2. TLDR: 32 bit hash has fewer collisions, yay!
The "regular versioned source files" part:
meow_search 0.3/snowshoe results:
    Root: /Users/aras/unity/graphics/.hg/store
    Completed on: Sat Nov  3 17:12:44 2018
    Files: 285501
    Total size: 17.63gb
    Duplicate files: 12457
    Files changed during search: 0
    Access failures: 0
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 7
    <list of collisions; expected for 32 bit>

The "large versioned binary files" part:
meow_search 0.3/snowshoe results:
    Root: /Users/aras/unity/graphics/.hg/largefiles
    Completed on: Sat Nov  3 17:10:30 2018
    Files: 939
    Total size: 30.52gb
    Duplicate files: 0
    Files changed during search: 0
    Access failures: 0
    Allocation failures: 0
    Read failures: 0
    [Meow128] Meow 128-bit AES-NI 128-wide collisions: 0
    [Meow64] Meow 64-bit AES-NI 128-wide collisions: 0
    [Meow32] Meow 32-bit AES-NI 128-wide collisions: 0

Excellent!
- Casey

We are now getting down to the nitty-gritty.  v0.4 has been posted, and should hopefully provide the same collision resistance as v0.3, while now being substantially faster on small inputs (we are now the fastest smhasher-passing hash we know of for all input sizes, period).  We will be doing a little more testing, but unless something new comes up, I will try to have a v0.5 branch up sometime before the end of the year that we can definitively test as the "final" Meow hash to be christened v1.0.
Thanks everyone for your testing help!
- Casey

Ran 0.4 on the same dataset as before. 128 & 64 bit hashes still zero collisions, 32 bit now has 9 collisions where 0.3 had 7. Not sure if that's worth worrying about at all; I think the amount of collisions is ballpark where I would expect with only 32 bits of hash.
If you really want to look at it, here's the files from that data set where 0.3 had collisions, and where 0.4 had collisions.
collisions-32bit-0.3.zip
collisions-32bit-0.4.zip

Hi @cmuratori,
Thanks for your brilliant work!
Ran HEAD (0.4) on the ImageNet dataset 2017 from computer vision setting. 32-bit collisions ONLY!
Data processed: 156GB
File Count: 2 025 710
Dupes: 8502
32-bit collisions: 511
With this, I can conclude that meowhash is reliable and ImageNet2017 is a high quality dataset!

Best fortunes,
Tjad

We have substantially updated the Meow Hash for v0.5.  We believe it now has significantly improved collision resistance.  If you would like to conduct testing, the v0.5 branch is now available here as a pull request for early access testing :)
- Casey

the v0.5 branch is now available here as a pull request for early access testing

A bunch of test executables (test, bench, search) do not compile with the provided scripts (on Mac/Linux at least) due to wrong paths, but also the test programs seem to want to include files that are removed (meow_intrinsics.h, meow_hash.h are gone but used from meow_test.h etc.).

  I admit I am not particularly good with the GitHub web client (or anything Git-related for that matter).  They should be updated now.
Keep in mind, though, we haven't posted a Mac/Linux build yet.  So the build.sh is actually old, and may not work.  This is Windows-only at the moment, although it probably isn't far off from working on Mac/Linux.
- Casey

@aras-p I pushed a new build.sh and meow_test.cpp today.  Those are the only two things that had issues on Linux.  Everything should be compiling now on Windows and Linux.  I don't test on Mac, so YMMV there, but IIRC the Linux and Mac builds were very similar so it shouldn't be hard to get it running.
- Casey

Paused some training to obtain results, appears to be consistency, and improvements :+1:

Best fortunes,
Tjad


html report to root for Pages to access

Uploading the .html of the report for that our git pages can access it for generating the report.

Looks consistent with the one in /src. Thanks!


Don't save new tabs or the extensions page

As a user , I would not want to save new tabs if any when I click on Export Tabs

Modified download_.js file to exclude exporting URL's of "New Tab" or "edge://" and "chrome://" pages.


[TA] More TA errors

Service had another deployment that made our test fail.

For PII, updated the entities
For analyze, I reported the error with service team and they added a bug to make sure they revert the change in preview.3. The fix I am doing is to make sure our tests pass and will address the fact that result will be empty in preview.4. I added more tests for this

/azp run net - textanalytics - tests


tests: net: buf: Fix cloning of zero-sized buffers

For zero sized buffers, instead of pointing to a buffer, net_buf->__buf
is NULL. For this reason, when cloning a buffer, the code needs to check
__buf before dereferencing it.

Rebased because of a conflict.

Nit: split into 2 commits?

Done

Nit: split into 2 commits?

Done

The first commit subject shouldn't start with tests: .


Add some more default HttpResponseMessages to the helper.

Changes
Adds MethodNotAllowed and Accepted default responses to the HttpMockHelper
For significant contributions please make sure you have completed the following items:

[ ] ReleaseHistory.md updated for non-trivial changes
[ ] Added unit tests

Closing for now, since we didn't find any other rule that would use those helpers.


XS_FUNCTIONS error

hello
i run the xenserver-admin-scripts failed. it prompt "XS_FUNCTIONS error"
i cant not find why
thanks

What Linux distribution and version are you using? Post the output of bash -x xs-vm-summary.

i sorry to run your script in Xenserver 6.2
it must be use in remote linux OS ?

You can use the scripts in a XenServer control domain (dom0) or from another host. You will probably need to set the XE_EXTRA_ARGS environment variable or the XE_SERVER, XE_USER, XE_PASSWORD environment variables (you can see the default assignments in xs-functions).

RhubarbSin
thank u , i often unable to visit github
i will try again


Replace Restify with other library for REST API features

Describe the bug
Restify doesn't play nice with Node 16, or at least uses deprecated features.
See this link
Candidates are Fastify, Express, KoaJS and others.
Fastify has a plugin that makes it trivial to set this up => Start off with Fastify.
This affects the existing Docker health check feature, as well as the work-in-progress Prometheus exporter feature

Fastify will be used instead of Restify going forward.
Reasons are better Prometheus support, better Node.js 16 support.

Released as part of v6.0.0


Do not check in_manifold when registering a manifold in geotorch

It also updates parametrize.py to its last version.

Codecov Report

Merging #16 (94e9fc0) into master (6cf490c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   89.54%   89.50%   -0.04%
==========================================
  Files          21       21
  Lines        1004     1010       +6
==========================================
+ Hits          899      904       +5
- Misses        105      106       +1

Impacted Files
Coverage Δ

geotorch/utils.py
90.69% <ø> (ø)

geotorch/constraints.py
92.72% <100.00%> (+0.89%)
:arrow_up:

geotorch/lowrank.py
83.03% <100.00%> (ø)

geotorch/product.py
100.00% <100.00%> (ø)

geotorch/reals.py
94.44% <100.00%> (ø)

geotorch/so.py
73.04% <100.00%> (ø)

geotorch/sphere.py
95.55% <100.00%> (ø)

geotorch/stiefel.py
96.07% <100.00%> (ø)

geotorch/symmetric.py
90.64% <100.00%> (-0.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf490c...94e9fc0. Read the comment docs.


documentation for install it

hello, do you have documentation to help me to install it please?

lack of response over a long period


Add the spark-daria and quinn general purpose libraries

As suggested here.
Also added quinn for the PySpark users ;)

@eliasah @oluies Any thoughts?


Unable to set the "REGISTRY_DATA_DIR"

Hi,
I have a machine hosting the running docker registry and it is working fine except for deleting. So, I downloaded your script and gave it the proper permission.
Based on the configuration of my registry inside the docker-compose.yaml file, the volume in my container is set as follow:
REGISTRY_STORAGE_FILESYSTEM_ROOTDIRECTORY: /data
After running the registry, the above volume corresponds to the following path in my local machine /var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories
which contains the following directories:

blobs
repositories

Then, following your instructions, I set the REGISTRY_DATA_DIR to the above local path. i.e.:
/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories
Now, when I run the following command:
delete_docker_registry_image --image project/ubuntu --dry-run
I get the following error:
No repositories directory found inside REGISTRY_DATA_DIR '/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories'
what am I doing wrong?
Thank you

it sounds like you may need REGISTRY_DATA_DIR=/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2 instead of REGISTRY_DATA_DIR=/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories.

it sounds like you may need REGISTRY_DATA_DIR=/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2 instead of REGISTRY_DATA_DIR=/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories.

@burnettk , thanks for your reply.
But I tried that path you stated and it doesn't work either. In fact, I tried the all these paths:

/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2/repositories (your suggestion)
/var/lib/docker/volumes/registry_registrydata/_data/docker/registry/v2 (my first try)
/volumes/registry_registrydata/_data/docker/registry/v2/repositories
/_data/docker/registry/v2/repositories/
/_data/docker/registry/v2/

But, non of them worked and I always get the error:
No repositories directory found inside REGISTRY_DATA_DIR '<path>'
It might helpful to explain in the READ-me what is this REGISTRY_DATA_DIR parameters refers to and how the code works to translate it

Why and how did I close this issue ?!
I am looking forward to any help please

i think you closed it. :) If you provide source code and steps to repro, someone might be able to figure out the issue.


Update upgrade.md for TLS setup

I agree @JeffSchering, rewriting the upgrade guides would be very nice

+1


Change bundler from rollup to vite

Objective
Change the main bundler tool from rollup implementation to vite.

Description
After several failed attempts to update rollup plugin dependencies and checking that there are no solutions nowadays, I decided to review actual alternatives that will avoid this kind of situation in future releases and maintenance rounds.
The option I will review in this ticket is vite.

Tasks

[x] Study Vite's bundler mode implementation.
[x] Remove rollup's implementation.
[x] Change build script to execute vite's.
[x] Check that the new build script is working.
[x] Check that the new lint script is working.
[x] Check that the new test script is working.
[x] Check that the new storybook build script is working.
[x] Send this renewed method to the next minor version (v4.1.0).

New findings to be added as gattered knowledge:

A specific issue regarding vite implementation on the current project failed due to a vite-plugin-dts build error.

I found the solution on a vite-plugin-dts issue.

Then, I had a problem with my storybook build script at the pipeline level (it worked locally).

The solution was to uninstall all storybook-related dependencies, run the npx storybook@latest init command on the project, and adjust its configurations to mine.

Last but not least, my linter configuration started to break after I initiated this ticket. Appears to be a common issue that is being solved as I am writing this explanation. I hope this could be solved during this week

To continue working, I commented on the linter step on my quality pipeline until a new version or configuration solves the issue.

Yes, I just tested it and this was because of --legacy-peer-deps which is also in your .npmrc. Do you still know why you need that?

Hi @receter, As you suggested, I deleted the .npmrc file and made a clean install on the repo, and it worked like a charm.
I will include this fix in my next version (around next week).
Thank you for the work and solution.


MissingMethodException in latest version

I get this error when running the replication app in Seq. (3.3.12-pre)
2016-08-24 22:01:28.480 +00:00 [Information] Updated "appinstance-232" 2016-08-24 22:01:28.841 +00:00 [Error] Failed to load "Big Red Box (preprod)" System.MissingMethodException: Method not found: 'Serilog.LoggerConfiguration Serilog.SeqLoggerConfigurationExtensions.Seq(Serilog.Configuration.LoggerSinkConfiguration, System.String, Serilog.Events.LogEventLevel, Int32, System.Nullable1<System.TimeSpan>, System.String, System.String, System.Nullable1<Int64>)'.    at Seq.App.Replication.Replicator.OnAttached()    at Seq.Server.Features.Runner.AppHost..ctor(ILogger logger, Func2 createReactorInstance, HostedApp hostedApp, AppInstance appInstance, AppHostSettings settings)
at Seq.Server.Features.Runner.AppHost..ctor(IInternalEventPublisher publisher, HostedApp hostedApp, AppInstance appInstance, AppHostSettings settings)
at Seq.Server.Features.Runner.SandboxedAppContainer.Initialize(IInternalEventPublisher publisher, String hostedApp, String appInstance, AppHostSettings settings)
at Seq.Server.Features.Runner.SandboxedAppContainer.Initialize(IInternalEventPublisher publisher, String hostedApp, String appInstance, AppHostSettings settings)
at Seq.Server.Features.Runner.RunningApp.LoadSandboxedAppContainer(AppDomain domain, HostedApp app)
at Seq.Server.Features.Runner.RunningApp.Run()`

Thanks for the report. The Replication app needs to be updated for Serilog 2.0/Serilog.Sinks.Seq 2.0, I've just tested this out locally and will push 2.0 versions of all of the app packages shortly.

This will be a breaking change for the File Archive and Replication packages, which depend on types that have moved or changed signature in Serilog 2.0. For these packages, earlier versions of Seq will need to use the 1.x series of releases.


How to use with Capistrano

What's the best way to use with something like capistrano? For now i have rake qc:work in my deploy.rb, but just wondering if i'm missing something?

Is there any way to do it without foreman?

@toydestroyer sure, you might need to write some wrapper code but all you need to do is start the worker process. You can use the provided rake task or write a script on your own.


Question: Address sanitizer?

Hey, was looking for this and didn't find it. Is there a way to enable Address Sanitizer (or Thread Sanitizer) on a Scheme?

Sorry for late. Currently sanitizer can be specified in .xcscheme file directly and it cannot be set from project.yml file

Ah, got it - I didn't realize that was an option, but in retrospect I should have. Thanks!


Allow confirmation of zero assets

Is your feature request related to a problem?
Currently, you are allowed to pass in assets to load the picker with pre-selected media. You can then select and deselect at will, except when you deselect all media. When the assets are 0, the confirm button is disabled.
Describe the solution you'd like
You should be able to select 0/x media, essentially deselecting all entries. Currently, there is no way to confirm a zero selection from the picker itself. The confirm button should work for any number of media selections, including zero.
Describe alternatives you've considered
There are essentially no other workarounds to this problem. You must remove the final asset outside of the picker.

I think making 0 assets available if there are selected assets previously would be a proper solution.


If this is such a big problem that they can't be included, i'm proposing the creation of a separate module with all the xxx stuff. People that want them, just need to install the extra module. Maybe named something like mov-cli-xxx, or more general mov-cli-offensive.

They were some porn providers, then they were removed.
If this is such a big problem that they can't be included, i'm proposing the creation of a separate module with all the xxx stuff. People that want them, just need to install the extra module. Maybe named something like mov-cli-xxx, or more general mov-cli-offensive.

it's already a separate package: https://github.com/mov-cli/porn-cli
please close this issue.


Improve text formatting on container stats charts

Currently there are two problems with the chart view:

The first is that on Firefox this seems to moosh together and make the time and data difficult to read. The second is that without the [Si suffixes](si suffixes), it's pretty hard to understand the data.

The form of the networking graph is excellent, but may be due to two data points.

I'd be game to do the grunt work to fix this. Can someone point me to where I should dive in and start?

The container stats view is planned to go under total overhaul in the next releases.
Meanwhile, if you'd like to propose a temporary fix for this, I recommend you to have a look at the following files:

The Angular controller for the stats view: https://github.com/portainer/portainer/blob/develop/app/components/stats/statsController.js
The HTML template for the stats view:
https://github.com/portainer/portainer/blob/develop/app/components/stats/stats.html

Also, have a look at our contributing guidelines before pushing some changes: https://github.com/portainer/portainer/blob/develop/CONTRIBUTING.md
Thanks !

Well, if it's going to get torn out soon that fizzles my motivation :stuck_out_tongue:
Did some quick Googling for chart.js custom tooltips, and it looks like they'll need to be defined when the chart objects are created. That means I'll have to start around line 77.
Any idea when this overhaul is going to happen? Are you going to throw out Chart.js?

Haha yeah overhaul is going to happen in the next two months I'd say. We'll keep Chart.js but we'll probably use the version 2.
Yes, you can start here.
I need to update our documentation to explain the local installation/build process.

@RandomInsano contribution documentation is available here: https://portainer.readthedocs.io/en/stable/contribute.html

Hmmmmm... Well, I'll keep watching. When I see the move over, I'll come around again and see about tackling this then. I'll close this for the time being!

I'll leave this issue open then, it will be taken into account during the overhaul :)

Related to #297

I'll close this issue, it's referenced in #297