Update to Keyboard Navigation

After creating the keyboard navigation code and testing it with the demo page provided I applied it to my application.  This revealed that I missed a use-case.
In my real application the zTree shown to the user is created and destroyed as the user selects different contexts but the zTree container element is not removed.  This meant the keyboard navigation code should also be destroyed and the re-applied to the new zTree nodes.  However, the original keyboard navigation code did not do this and, as a result, multiple keyboard events would be fired for each keystroke.  The number of events being the number of times the zTree is re-created.
The code in this PR addresses this omission.

In addition, I am suggesting an addition to the core,  The 'searchNodes' example shows how nodes containing specific characteristics, such as user entered characters, can be identified by modifying the CSS used to display the nodes.  While this is a very useful feature, it requires the CSS to be embedded in JavaScript code.  This is so the 'view' callback 'fontCSS' is able to return the CSS directive to be applied to selected nodes.
For me it will be better if selected nodes can be identified by applying CSS classes rather than directives.  Doing so provides more flexibility and allows designers to retain control of the styling without having to modify JS code.
The pull request implements a new core 'view' callback called 'nodeClasses'. It works in a similar way to fontCSS: the user implements a callback to return an object that defines classes to be added and removed.
The core 'searchNodes' demo page has also been updated to provide an extra checkbox so a viewer is able toggle between seeing selected nodes be identified by applying CSS directives (the fontCSS way) or identified by applying classes.  The image shows examples of the zTree from the updated demo page at different stages of node expansion.  Classes have been used to provide icons that not only mark selected nodes but to show when selected node exist within a collapsed node.

I am no designer and the choice of icons and colors could be better.  However, because the icons and colors are defined by classes, a designer is able to improve the look without changing the JS code.
The new 'view' callback called 'nodeClasses' expects the function to return an object with two properties called 'add' and 'remove'.  Both are an array of class names.  The 'add' array is a list of class names to be added to nodes that contain the required characteristic. The 'remove' property is a list of class names that will be removed from all other nodes.  If the complete set of classes that might be applied are 'highlight', 'hidden' and 'highlight_alt' then a class returned for a node might look like this:
{
    add: ['highlight', 'hidden'],
    remove: ['highlight', 'hidden', 'highlight_alt']
}

Thank you very much.
I'll merge your code.  I agree your idea to add node's class name.  But I will change your code for core.js.


Migrate room config outside of project.yaml

Storing the room configurations in project.yaml has several disadvantages:

The project.yaml contained in the templates is mostly useful for people in Oblong's LA office.
The number of room configs in project.yaml grows very large as we collaborate on projects in multiple locations and support more deployed rooms.
If a room configuration changes each project that knows about the room needs to be updated with the new configuration (think if a system's IP address or hostname changes).

A possible idea would be having rooms or roomsets as separate configuration files that are controlled in a git repo and having obi wrap pull them down like templates.  Something like:
room install  Install an obi room
room remove   Remove an installed obi room
room upgrade  Upgrade an installed obi room

# Used like
obi room install boston-wall
obi go boston-wall

obi room install warehouse
obi go wall

The only thing that's missing is some way to "package" or lock a room configuration for deployment.

This is great and :+1: to it overall, but the feature to control command line arguments and environment variables for a project on a per-room basis is crucial.  So the project.yaml file still needs to have some "knowledge" of rooms, but it doesn't need to "know" the specific details of a room's hosts (like their IPs, usernames, etc.)

On the other hand, the ability to ship a project's source to a client and let them run on a remote host without needing anything installed but obi is very nice.  The room install step is somewhat onerous.

The room install step is somewhat onerous.

Yeah, that's why we need someway to package the room configs with the project.  We wouldn't want to have to do an obi room command when installing at a customer site either.

I guess we could have obi check some magic directory in the project (like "rooms") for room configuration files.  Then we could have a git repo for Acme Corp rooms, and pull that in as a submodule to all the Acme Corp projects.

Hmm, I guess I still don't accept the initial problem statement as something that would motivate a big design change.  Real world project.yamls I have seen include 5-15 room settings; if this number were 50, I still don't see a grows very large problem yet.  For comparison, a not unreasonable .ssh/config might contain 50 or 100 entries.

@jshrake made a good point that the problem is "how to run" and "where to run" are intertwined in one place now, the project.yaml file.  If we specify "where to run" globally (somewhere in a user's ~, or maybe even in places like /usr/local/etc), you still need to specify per-project how to run the thing in each location.
We also have some room parameters that most projects running in a given location end up using: things like a DISPLAY=':0'environment variable, or build arguments like -j32 -l32, or command line arguments like paths to room/screen/feld proteins and the wands pool configuration.

Good feature for a future refactor.


make BigtableIO#Read#withRowFilter public

This is https://github.com/GoogleCloudPlatform/DataflowJavaSDK/pull/150 targeted against correct repo.
R: me since @nevillelyh is author.
Once tests pass, I'll merge.

LGTM, merging


Need 1 deb for arm64

Could you compile a deb package suitable for arm64 architecture?

@new985211 Hi
I am using GitHub actions for releasing the app, it only has x64 based runnersand it doesn't have arm64 support yet.
(to compile the app for arm64 its required to have an arm64 device)


filesController sporadically missing in FilesRouter

Env

ParseServer 2.2.9
AWS EC2 (Centos+Nginx)
Self-hosted MongoDB on AWS

Problem
error: Uncaught internal server error. [TypeError: Cannot read property 'getFileData' of undefined] TypeError: Cannot read property 'getFileData' of undefined
    at getHandler (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/lib/Routers/FilesRouter.js:69:22)
    at Layer.handle [as handle_request] (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/route.js:131:13)
    at Route.dispatch (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
    at /home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/index.js:277:22
    at param (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/index.js:349:14)
    at param (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
    at param (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
    at Function.process_params (/home/centos/apps/parse-server-dev/source/node_modules/parse-server/node_modules/express/lib/router/index.js:410:3)

This error appears randomly in the console and it makes the ParseServer crash, I still can't able to reproduce it
https://github.com/ParsePlatform/parse-server/blob/master/src/Routers/FilesRouter.js#L39

I don't see how this could happen. Please let me know if you are ever able to reproduce this, I haven't been able to reproduce it either.

reproduce
As fair as I tested it could be reproduced in this way but not all the time

point the app to api.parse.com
login to the app
switch the app to self-hosted-parse-server
open the app
the error appears in the console only that time

Closing due to lack of activity, please update to latest parse-server version and reopen if the issue persist.
Don't forget to include your current:

node version
npm version
parse-server version
any relevant logs (VERBOSE=1 will enable verbose logging)

I have had the same issue along with the exact error message. benishak are you still having this issue as well?

I have the same identical issue and I'm able to reproduce it. I'm using the parse-server-fs-adapter to store files. While storing succeeds, when I try to retrieve a file Parse crashes with that error log. I posted this issue here weeks ago https://github.com/parse-server-modules/parse-server-fs-adapter/issues/3.
This does not happen with the default GridStoreAdapter.

I'm getting the same error on migrated app. I uploaded a file through Parse Dasboard and then trying to access it, but getting this in error log:
 error: Uncaught internal server error. TypeError: Cannot read property 'getFileData' of undefined
 at getHandler (/usr/lib/node_modules/parse-server/lib/Routers/FilesRouter.js:69:22)
 at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
 at next (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:131:13)
 at Route.dispatch (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:112:3)
 at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
 at /usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:277:22
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:349:14)
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
 at Function.process_params (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:410:3) TypeError: Cannot read property 'getFileData' of undefined
 at getHandler (/usr/lib/node_modules/parse-server/lib/Routers/FilesRouter.js:69:22)
 at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
 at next (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:131:13)
 at Route.dispatch (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:112:3)
 at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)
 at /usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:277:22
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:349:14)
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
 at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)
 at Function.process_params (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:410:3)

The dashboard shows this:
{"code":1,"message":"Internal server error."}

Parse Server version is 2.2.15.
Parse Dashboard version is 1.0.15

@flovilmart Can you please reopen this issue, as I wouldn't like to open a new one?

Please update to latest version and reopen the issue if it persists

I'm using parse server version 2.2.25
Problem still exists
error: Uncaught internal server error. [TypeError: Cannot read property 'getFileData' of undefined] TypeError: Cannot read property 'getFileData' of undefined     at getHandler (/usr/lib/node_modules/parse-server/lib/Routers/FilesRouter.js:81:24)     at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)     at next (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:131:13)     at Route.dispatch (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:112:3)     at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)     at /usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:277:22     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:349:14)     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)     at Function.process_params (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:410:3) TypeError: Cannot read property 'getFileData' of undefined     at getHandler (/usr/lib/node_modules/parse-server/lib/Routers/FilesRouter.js:81:24)     at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)     at next (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:131:13)     at Route.dispatch (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/route.js:112:3)     at Layer.handle [as handle_request] (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/layer.js:95:5)     at /usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:277:22     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:349:14)     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)     at param (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:365:14)     at Function.process_params (/usr/lib/node_modules/parse-server/node_modules/express/lib/router/index.js:410:3)

Can you provide the logs when running with VERBOSE=1 when this occurs?

sure!, please give me a moment.

`verbose: REQUEST for [GET] /parse/classes/Posts?skip=1&include=celebrity_pointer&limit=5&order=-source_created_at: {} method=GET, url=/parse/classes/Posts?skip=1&include=celebrity_pointer&limit=5&order=-source_created_at, host=<my_host_name>, connection=close, content-length=0, accept-encoding=identity, x-parse-application-id=<my_app_id>, content-type=application/json, x-parse-master-key=<my_key>,
/usr/lib/node_modules/parse-server/lib/ParseServer.js:430
throw err;
^
Error: ENOENT: no such file or directory, open '/usr/lib/node_modules/parse-server/logs/parse-server.info.2016-11-29'
at Error (native)`

That isn't the same crash...

But odd nonetheless


Error "code": "CDN-0001", "message": "Invalid apiKey."

I installed version "homebridge-weather-plus v3.2.6" and get the error "code": "CDN-0001", "message": "Invalid apiKey during start. The config is:
{
"platform": "WeatherPlus",
"service": "weatherunderground",
"key": "ip9999999",
"stationId": "IGELXXX9",
"compatibility": "home"
}
I know that the apiKey and the stationId have correct values (not the value in the config here). What could be the clue for this problem?
Best regards

As reviewed via Google I had to generate a new apiKey via WU. Go to https://www.wunderground.com/member/settings, then select "API KEYS" and generate the new key. This key is only for your plugin. Copy it to your clipboard and paste it into your JSON plugin configuration. Restart your HomeBridge and everything will work. You will find your new values in the "Standard Room".


git:// doesn't work when cloning locally

I found this problem with git after copying the command from the docs:
$ git clone https://github.com/defunctzombie/localtunnel-server.git

Cloning into 'localtunnel-server'...
remote: Enumerating objects: 770, done.
remote: Total 770 (delta 0), reused 0 (delta 0), pack-reused 770
Receiving objects: 100% (770/770), 436.21 KiB | 2.78 MiB/s, done.
Resolving deltas: 100% (412/412), done.

I found out that the git:// protocol no longer works and only works with https:// or ssh://.
Could you update the docs and change this minor detail?
Thanks!

Hii Parker,
Which node version are you using?
On Wed, 12 Jul 2023 at 18:11 Parking Master @.***>
wrote:

I found this
https://stackoverflow.com/questions/72915782/fatal-unable-to-connect-to-github-com-github-com0-140-82-121-3-errno-opera
problem with git after copying the command from the docs:
$ git clone https://github.com/defunctzombie/localtunnel-server.git
Cloning into 'localtunnel-server'...
remote: Enumerating objects: 770, done.
remote: Total 770 (delta 0), reused 0 (delta 0), pack-reused 770
Receiving objects: 100% (770/770), 436.21 KiB | 2.78 MiB/s, done.
Resolving deltas: 100% (412/412), done.
I found out that the git:// protocol no longer works and only works with
https:// or ssh://.
Could you update the docs and change this minor detail?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/localtunnel/server/issues/201, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATONHPWKFQAHOMJZMNSVPULXP4HGRANCNFSM6AAAAAA2IBCEV4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It's not Node, it's git. And in the stackoverflow anwser I linked, they said that "git://" is no longer valid.

All rigth I got it.
Try it:
git clone https://github.com/localtunnel/server

Thanks! It does work, the issue was basically asking someone to change the docs because it's outdated

No problem :+1:
Yes! unfortunaly the repository is a bit old and maybe in that time it worked.
So, I have this repository and maybe it can help you:

https://github.com/tiagopazhs/localtunnelServer-raise

I recomend you to see this two commits:
Fix esm modules
It will help you to setup the project because there are some differences between node versions.

https://github.com/tiagopazhs/localtunnelServer-raise/commit/425c9733393a13dedd32a363c325a076d4006cbf
Run server in your machine

If you debug your application you will got this problem because localtunnel uses an especific lib that don't handle with local urls.

https://github.com/tiagopazhs/localtunnelServer-raise/commit/518214b9163b4cc80b50f2d9d36686904179f344
</pre

Let me know if you have new issues in the future.

Thank you!


[Feature]: Is there any way we can have sidecar container with PG container in same pod ?

Is there an existing issue already for this feature request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
We are trying to add one of the helper container for backup solution(this is standard backup solution across our organization). Now when we checked with backup vendor, this container needs to be added as sidecar container(within same pod where PG is running). I believe CloudNativePG does not support this. Do we have a way to perform this kind of configuration ?
If not, are we planning to get this kind of feature in future releases?
Describe the solution you'd like
Should have configuration in place to mention another helper image container. And it should run with Primary PG instance.
Describe alternatives you've considered
I havent tried any alternatives , as I believe CloudNativePG does not support this feature.
Additional context
No response
Backport?
Yes
Are you willing to actively contribute to this feature?
No
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I have the same question. I want to add a Yandex Odyssey connection pooler instead of the built-in pgbouncer and without Deployment+Service (it's not efficient because connections aren't reused), but I want to use sidecar containers instead (like in Stackgres).


Added parameter for alternative data_dir

We install our atlassian instances out of the users home dir. So I modified the code to be able to use /opt/atlassian/jira/data as path for the atlassian data. I added a new parameter called jira::data_dir, which is used in config.pp for creating config files.
Please merge if its ok. I think its also a benefit for other users.
Best regards
Taulant

Thank you for submitting this patch.
In order for us to move forward, could you please address the failing tests?

Hi @bbriggs,
thanks for your feedback. I checked the failed tests but could not identify the problem for short time. Next week I have more time for troubleshooting and will move forward.

Don't forget that you can always check the results of the TravisCI run to see what failed and why :)

@tgeci On quick glance here: jira::home_dir ;
You have home_dir rather than homedir (as instantiated in init.pp).

Sorry guys, I've a long time inactive.
Thanks @sacres for the hint.

Ok, tests are still failing. I think its because I did not write tests for my additional parameter. So there is still the homedir expected.

 Failure/Error:

    is_expected.to contain_file('/home/jira/dbconfig.xml').
      with_content(%r{<schema-name>public</schema-name>})

    expected that the catalogue would contain File[/home/jira/dbconfig.xml]

I will try to get tests working, but it will take a time. I am not so familar with rspec & beaker, just saw it on practitioner training and don't have practitional experience yet. First I need to get the tests executable on my local machine, so I don't have to wait for Travis.
If you want, you can close this pull request. When my tests are ready, I will merge master in my fork an create a new PR.
Best regards

Please take a look at https://github.com/voxpupuli/puppet-confluence/pull/90, because this will fail also for Jira. At least if I test with Beaker and Puppet 3.8.7.

See my last comment on https://github.com/voxpupuli/puppet-confluence/pull/90.

@juniorsysadmin Thanks for hints. Made my changes based on your comments.

please don't merge this until we did another release

https://github.com/voxpupuli/puppet-jira/pull/203

@tgeci can you please rebase after https://github.com/voxpupuli/puppet-jira/pull/204 got merged?

@sacres @bastelfreak What should we do with this old pull request ?

Hi @tgeci, I am fine merging this if somebody rebases it.


Jenkins JUnit

Hi @hooxSoftware ,

I can't install Jenkins correctly...
Can I only see these charts with Jenkins and JUnit?
Where are the xml files generated by the plc of the test results?

thanks you, Victor.

Hi,
the junit file is created after a testrun and saved in C:\TwinCAT\3.1\Boot\CurrentConfig\unittest.xml.
The coverage result must be created using the AutomateYourCode generator. The generator also
creates the testobject, download it to the runtime and start the test.
After running the test, the result file will be downloaded fro the runtime and the generator calculates
the coverage and creates the cobertura file.
I think these charts are special in the jenkins plugins.
As far as i know now gitlab, github and devops offer different views of the result files.

Hi @hooxSoftware ,
With what parameters can I configure the script AutomateYourCode.exe?

in C:\Hoox\Lib\Beckhoff\template you find a template xml to set the config file
in C:\Hoox\Generator\doc you can find a short documentation (maybe not perfect).
using attributes in xml (build, testobject, run, analyse) you can config the pipeline the generator should
work.
You can also add more steps

<\twincat>

<\twincat>
You do not need a license to try it.
Without license the codecoverage is limited to the first five files found.

Hi @hooxSoftware ,
Where is the result of the coverage?

The result of the coverage will be created in the folder of the testobject as coverage.xml
Mit freundlichen Grüßen
Patrick Dressel

Von: Runtimevic @.>
Gesendet: Sunday, November 5, 2023 6:05:20 PM
An: hooxSoftware/TcTestframework @.>
Cc: Patrick Dressel @.>; Mention @.>
Betreff: Re: [hooxSoftware/TcTestframework] Jenkins JUnit (Issue #1)
Hi @hooxSoftwarehttps://github.com/hooxSoftware ,
Where is the result of the coverage?
—
Reply to this email directly, view it on GitHubhttps://github.com/hooxSoftware/TcTestframework/issues/1#issuecomment-1793792446, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFMB4MCITHLQLM56KRA4KTYC7BNBAVCNFSM6AAAAAA66LT63CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTG44TENBUGY.
You are receiving this because you were mentioned.Message ID: @.***>

this doesn't work either..

see the examples in the documentation.
for testobject you have to define
 --> Sourceproject
 --> Testobject
I will add a Testrun example xml tomorrow
Mit freundlichen Grüßen
Patrick Dressel

Von: Runtimevic @.>
Gesendet: Sunday, November 5, 2023 6:33:09 PM
An: hooxSoftware/TcTestframework @.>
Cc: Patrick Dressel @.>; Mention @.>
Betreff: Re: [hooxSoftware/TcTestframework] Jenkins JUnit (Issue #1)
this doesn't work either..
[Hoox_cobertura4]https://user-images.githubusercontent.com/53791834/280543878-8ff097e1-f468-468c-a4a8-5876ee8dc621.PNG [Hoox_template_xml2] https://user-images.githubusercontent.com/53791834/280543889-bd13f4f6-356e-4a93-ad21-799489afe98c.PNG  [Hoox_TwinCAT_template] https://user-images.githubusercontent.com/53791834/280543900-14885942-833d-4fc0-a35f-cf48d08ae97f.PNG
—
Reply to this email directly, view it on GitHubhttps://github.com/hooxSoftware/TcTestframework/issues/1#issuecomment-1793798839, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFMB4I3I6EH4GAAHODSNNTYC7EVLAVCNFSM6AAAAAA66LT63CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTG44TQOBTHE.
You are receiving this because you were mentioned.Message ID: @.***>

So I wait until tomorrow, add a Testrun example xml...
thanks you, Víctor

first <IP_ADDRESS> will not work. The generator tries to open an ADS connection and needs the complete ADS adress or the first four values and add .1.1 to it.
Try config like this one

<Twincat testobject="1" >
    <Path>C:\\Hoox\\Lib\\Beckhoff\\Sample\\Testsample</Path>
    <Export>C:\\Hoox\Testobject</Export>
    <Version>TcXAE</Version>
</Twincat>

<Twincat build="0" run="1" analyse="1">
    <Path>C:\\Hoox\Testobject</Path>
    <Connection><IP_ADDRESS></Connection>
</Twincat>

Hi,

how is the ADS adress of the runtime? you must use the adress without .1.1. at the end.
The coming version will check if it is a complete ads-string.
The actual version does not support loopback adresses

Hi,

Hi, it has remained there is cmd...
Inside the Testobject folder there is the same project, where is the code coverage test?

Sorry : <IP_ADDRESS> will not work. The ADS API needs the correct ADS Adress of the runtime, and this can not be the loopback adress.
can you add a screenshot of you runtime info, like this one:

you have to change your config to this, to use your local runtime.

C:\\Hoox\Testobject
<IP_ADDRESS>

but it only works if the twincat project is configured to run there.
The generator does not autodetect and edit the runtime config (cores and licenses)

Hi:

Do you have imported the libraries : C:\Hoox\Lib\Beckhoff ?
can you open the Testsample solution and download it to the runtime manually ?

Hi, yes dowload project manually...

The original project is copied and gets some code injection to enable the measurement of the coverage.
The resulting testobject has to be compiled and downloaded to a runtime, started and wait for the end of
the testrun.
Maybe you should try to download the Testobject. Which version of Visual Studio do you have installed?
If Twincat is not available in alle versions you can add a  tag to the config to choose the visual studio
you want - example : tcxae or 2019

Hi,
I have installed TwinCAT XAE Shell, vs2017, vs2019..

Hello @hooxSoftware ,

this is crazy :) do you have any special settings on your computer ?
Language Setting in Visual Studio?

this is crazy :) do you have any special settings on your computer ?
Language Setting in Visual Studio?

Yes, Spanish.., I change it to English and try

👍  using the Beckhoff Automation interface you need to check the local Id. With the next Beta i will fix that. Seems that it uses English as default value.

there must be some issue with your runtime... "license missing" or something else.
Maybe you can type in powershell: Get-AdsState  -Force -Address "<IP_ADDRESS>.1.1"
The generator uses the powershell environment to request the ADS State of the configured runtime.

hi,

Very interesting. I must try that later at home.
Mit freundlichen Grüßen
Patrick Dressel

Von: Runtimevic @.>
Gesendet: Tuesday, November 7, 2023 11:41:33 AM
An: hooxSoftware/TcTestframework @.>
Cc: Patrick Dressel @.>; Mention @.>
Betreff: Re: [hooxSoftware/TcTestframework] Jenkins JUnit (Issue #1)
hi,
[Hoox_error12]https://user-images.githubusercontent.com/53791834/281010230-bec67b1a-f764-4afb-8743-79438fbc4121.JPG
—
Reply to this email directly, view it on GitHubhttps://github.com/hooxSoftware/TcTestframework/issues/1#issuecomment-1798250462, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANFMB4LGPLABKBCTBLHADKDYDIF53AVCNFSM6AAAAAA66LT63CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJYGI2TANBWGI.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @hooxSoftware ,
Have you been able to try it? Can you think of anything else?
thanks you.

sorry, i am at a customers site this week. Must have a look at it later

sorry, i am at a customers site this week. Must have a look at it later.
One question : is C:\TwinCAT\AdsApi\Powershell\TcXaeMgmt\TcXaeMgmt.dll available?

Hi @hooxSoftware , yes is available TcXaeMgmt.dll...
Can I do anything else that occurs to you?
thanks you, Víctor.


Support Consul ACL token

What are the steps to reproduce this issue?

deploy faas-nomad and gateway with consul acls on
deploy a function from the store (UI or faas-cli)

What happens?
If consul acls are on and the anonymous policy limits access to consul, functions cannot be invoked
What were you expecting to happen?
Functions can be invoked. However, this is to be expected when consul acl are on and faas-nomad doesn't provide the token to the consul resolver.
Any logs, error output, etc?
2018-10-03T19:12:57.843Z [INFO ] nomadd.reader_handler: List functions success
2018-10-03T19:12:59.454Z [INFO ] nomadd.consul_resolver: Got Address from cache: address="&consul.cacheItem{serviceQuery:(*dependency.CatalogServiceQuery)(0xc00009b4f0), addresses:[]string{}}"
2018-10-03T19:12:59.454Z [ERROR] nomadd.proxy_client: Function Not Found: figlet=<unknown>

Any other comments?
Adding this for tracking
What versions of software are you using?
Operating System: Ubuntu 1604 x64
OpenFaaS Version: 0.9.3
Nomad Version: 0.8.4

Hey @acornies , I have added this in the branch https://github.com/hashicorp/faas-nomad/tree/add_consul_ACL
I have built a beta image for you to try 0.3.2-beta to enable ACL add the flag --consul_acl=token to the startup command for the provider.

Confirmed working with consul ACLs enabled using 0.3.2-beta


Added ability to set multiple assertions and their condition for permissions

An update to V2 to allow set multiple assertions as well as their condition for permissions.

I like the idea. What about bringing a new "AssertionSet" class that would contain the two constants, and abstract the logic of checking all the assertions and returning a boolean, so the isGranted can stay simple?

That actually sounds good. I'll work on it within next few days.

This is a very good idea! It would help us keep things better organized.

@DavidHavl I like this idea! Now work on V3 is progressing it would be bring this feature there too.

Thanks @basz, I have been extremely busy with work past few months but I should have more time now for this.

Is there still progress on this?

Coverage decreased (-4.9%) to 87.96% when pulling 01e35bafabca0886ea030cd6e9a54a67f8f71d6f on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage decreased (-4.9%) to 87.96% when pulling 01e35bafabca0886ea030cd6e9a54a67f8f71d6f on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage decreased (-4.9%) to 87.96% when pulling b06275fb99e2366d0c6d61e345ca192483eeb4ab on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage decreased (-4.9%) to 87.96% when pulling b06275fb99e2366d0c6d61e345ca192483eeb4ab on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Also coverage decreased, can you add some more tests, please?

@basz that was my initial idea but it was not accepted.
I'll work on it.

Ok, remember why? Perhaps was fora good reason...

Op 25 okt. 2016 om 17:50 heeft David Havl<EMAIL_ADDRESS>het volgende geschreven:
@basz that was my initial idea but it was not accepted.
I'll work on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Coverage increased (+0.5%) to 93.361% when pulling d2a7e2703f9528d34bece163765e26fe01f35c1b on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling d2a7e2703f9528d34bece163765e26fe01f35c1b on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling 8c6a9c3c58c2b253b2f369499fe12e65a4173b06 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling 8c6a9c3c58c2b253b2f369499fe12e65a4173b06 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling 311b942f01a6c67922da1944bc2af98ad1f3af20 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling d9a86ad7646073b090ac7f1194fa4ef2647c90a6 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling 1a30f067de6538e126c9cceed988644f5060e4af on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.5%) to 93.361% when pulling 1a30f067de6538e126c9cceed988644f5060e4af on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.7%) to 93.535% when pulling c695e41d665dfecddd41ad8a262d7fcb57b9413a on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.7%) to 93.535% when pulling c695e41d665dfecddd41ad8a262d7fcb57b9413a on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.4%) to 93.258% when pulling 47e17f84d1c1543542218c325af5a86d51f7e051 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

Coverage increased (+0.4%) to 93.258% when pulling 47e17f84d1c1543542218c325af5a86d51f7e051 on DavidHavl:master into<PHONE_NUMBER>fe50c06ef596848c5813ed4a739ac3 on ZF-Commons:master.

@danizord the approach you describe is interesting, but I have a concern from usability point of view. I mean, I think it may be more confusing and less intuitive for people wanting to use the module to have yet another separate config for sets. Plus I am not sure about performance implications either.

First yes you moved AssertionSet creation to assert() but this still not optimal you still creating all assertions even if they are not required. Imagine you have 20 assertions with or condition so you have to create all 20 when in reality you should have created just first one and all others are not required.
I don't like that AssertionSet does not support assertions as string or callback while supported are string|callable|array|AssertionInterface and only allows AssertionInterface at the same time does not check if $assertion is AssertionInterface. Also do we really need names for assertions in config?
And I still would like to change AuthorizatrionService::assert() to something like:
protected function assert($assertion, $context = null)
{
    $assertion = new AssertionSet($assertion, $this->assertionPluginManager);
    return $assertion->assert($this, $context);
}

this is also AssertionSet and if I understand correctly should work no? haven't tested
return [
    'zfc_rbac' => [
        'assertion_map' => [
             // single assertion
            'myPermission'  => 'myAssertion',
            // assertion set with default condition `and`
            'myPermission2' => [
                'myAssertion',
                'myAssertion2',
            ]
        ]
    ]
];

or if you don't like adding AssertionPluginManager to AssertionSet then maybe introduce new method in AuthorizationService:
public function getAssertion(string $assertion)
{
    return $this->assertionPluginManager->get($assertion);
}

@svycka I see your point in case of OR condition where it is redundant to create rest of the assertions.
However, the simplified AuthorizatrionService::assert() method you propose has a flow. It would have to create an instance of AssertionSet every time even for single standalone assertions or callables or named assertion which is redundant.

It is not just or condition with and this also valid if first fail all
others does not mater and will not be created. Also if you have concerns
about creating this object then ok you can create it if assertion is array.
But if everyone agrees with you then ok let's leave it this way.
On Oct 31, 2016 02:32, "David Havl"<EMAIL_ADDRESS>wrote:

@svycka https://github.com/svycka I see your point in case of OR
condition where it is redundant to create rest of the assertions.
However, the simplified AuthorizatrionService::assert() method you
propose has a flow. It would have to create an instance of AssertionSet
every time even for single standalone assertions or callables or named
assertion which is redundant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ZF-Commons/zfc-rbac/pull/320#issuecomment-257191928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNj_p69g-dUeeEEuPfUqI0_BxKzQiosks5q5TcdgaJpZM4G-YHO
.

Hey guys, I don't think I will have enough time to do more changes on this in next few months (got an urgent project that doesn't use this), so feel free to do a pull
and then if you think it needs more refinements feel free to adjust it.

the author expressed he didn't have time to continue it. We now have this functionality in the develop branch and #379 could be backported to master if anyone needs it. (hence the label change)

Great, thanks for finishing it up @basz !


Radio-button behaviour when you set a custom host fee

If you go to host dashboard > hosted Collectives > set custom fee and click into the box and type in a custom fee, the radio button should automatically jump to the custom option, not stick on the global option. Right now even if you set a custom fee it can still be stuck on the global option and it's really easy to miss that. Alternatively, the box to put the fee in should be disabled until you select the custom fee radio button.

@alanna is this correct for this issue. Or this is not the right way to do this?

@terminator0309 document.getElementById is not a good react practice. Also onFocus might not be the right place to handle that, because navigating with the Tab key will then change the option.
I recommend making the switch in the onChange.

@Betree
i am getting this error when trying to open "My Collectives" through the drop down menu in nav bar.

@terminator0309 Try to npm install then restart the server

@Betree

what do you think about this! Disabling the input box until the radio button is checked.

@terminator0309 this won't match the expected behavior described above. What we want is to have the radio button selected whenever you click inside of the input.


Fix IE8 issue

Fixed issue https://github.com/sroze/ngInfiniteScroll/issues/239 that relates to HTMLElement in IE8

It's odd why it is failing. Just fails on timeout and that's it.

Hi @ykushch
I also ran into this problem on IE8.
Maybe the test will work with:
if(newContainer.nodeType && newContainer.nodeType === 1)
jQuery uses nodeType to check these kinds of things.

@matrei's PR is merged. Thank you @ykushch.


android onNavigationStateChange return unexpected canGoBack result

Bug description:
I'm using react-native-webview. The initial url is https://sushi.com, and then click enter App in the upper right corner of the webview. His url becomes https://sushi.com/swap but in Android's onNavigationStateChange The canGoBack of the returned information is false, try to call webview.current.goBack on the current page, but it does not work, use webview.current.injectJavascript(`
window.history.back();
true;
`) also does not work
All the above operations are working perfectly in the iOS environment
To Reproduce:
set initial url https://sushi.com then and then click enter App in the upper right corner of the webview.
Screenshots/Videos:
https://github.com/react-native-webview/react-native-webview/assets/58379214/c64090d8-925c-4bcf-8faf-337c3a900a36
Expected behavior:
android trigger event onNavigationStateChange and return canGoBack  true, and webview.current.goBack() can go back to previous website
Environment:

OS: Android
OS version: any version can reproduce it
react-native version: 0.71.8
react-native-webview version: 13.0.0

This doesn't look related to react-native-webview. Have you tested in a browser? I see the same behavior in Chrome on Android.

This doesn't look related to react-native-webview. Have you tested in a browser? I see the same behavior in Chrome on Android.
@TheAlmightyBob Thanks for replying me.  I found that the android chrome doesn't have back button for going back,but u can use hardwarebackpress to go back the previous website.Here comes the reaction in three main browser in android, I will appreciate it if u reply me again.
chrome:
https://github.com/react-native-webview/react-native-webview/assets/58379214/1c43dedf-524e-4041-9efb-dbb666c2ee5a
android firefox:
https://github.com/react-native-webview/react-native-webview/assets/58379214/955a0a55-ee4c-4e75-bb39-25cd7c1a00b8
android edge
https://github.com/react-native-webview/react-native-webview/assets/58379214/98760aac-6663-41a5-9959-56646fa1f057

@Stephen-Song Can you provide the code or all the props you are using with your Webview?

@Asad520  Thanks for replying me. Here comes the simple code i use in my webview, in the emulator the acting is more wired than in the real android phone, The former does not trigger onNavigationStateChange at all when switching urls.  u can try it in both ios simulator and android emulator. Please give me a hand, thank u again.
https://snack.expo.dev/@stephen_song/react-native-webview-android-bug?platform=android

I found that the android chrome doesn't have back button for going back, but u can use hardwarebackpress to go back the previous website

My apologies, you are correct. I could swear Android Chrome used to display a back button as well.... but a quick googling suggests I might be crazy and imagined it 😞

I found that the android chrome doesn't have back button for going back, but u can use hardwarebackpress to go back the previous website

My apologies, you are correct. I could swear Android Chrome used to display a back button as well.... but a quick googling suggests I might be crazy and imagined it 😞

Do you have any idea or suggestion on how to solve it😭？

@Stephen-Song I couldn't make it work with expo. It was giving weird behaviors. However, I tried with one of my react-native-cli projects on react-native: 0.71.7 and react-native-webview: 12.1.0 and it behaved as desired. It could be related to issue#2949 but I'm not sure. Let me know if it helps in any way
https://github.com/react-native-webview/react-native-webview/assets/47941595/c6fb12ad-4859-4c2f-be6b-5a83f66a12aa

@Stephen-Song I couldn't make it work with expo. It was giving weird behaviors. However, I tried with one of my react-native-cli projects on react-native: 0.71.7 and react-native-webview: 12.1.0 and it behaved as desired. It could be related to issue#2949 but I'm not sure. Let me know if it helps in any way
Screen.Recording.2023-08-17.at.12.25.05.PM.mov

@Stephen-Song I couldn't make it work with expo. It was giving weird behaviors. However, I tried with one of my react-native-cli projects on react-native: 0.71.7 and react-native-webview: 12.1.0 and it behaved as desired. It could be related to issue#2949 but I'm not sure. Let me know if it helps in any way
Screen.Recording.2023-08-17.at.12.25.05.PM.mov

@Asad520 Thank u for relating relative issue to me. it works when i remove useragent !
about the useagent issue, i think we set initial url about:blank would temporarily fix it, then use useEffect or componentDidMount to set the true url.
but it can go back at the initial true url, i think onNavigationStateChange={
webviewRef.current?.injectJavaScript(window.ReactNativeWebView.postMessage(JSON.stringify({data: window.history.length})))
}
then handleMessage from webview, if the history length === 2, just disable the go back button.
it is a transitional and temporary solutions, the real fix has to wait for the react-native-webview official to see how to fix it.

Hello, I think this PR will solve the problem.
I need your attention.
If the issue is urgent, you can use it as a patch-package. Let me know if you need an example.
https://github.com/react-native-webview/react-native-webview/pull/3106


Update broken variable names for Issue #40

What kind of change does this PR introduce?
Bugfix for Issue #40
What is the current behavior?
Crashes.
Please link any relevant issues here.
What is the new behavior?
Works. 😄
Additional context
Fixes some issues caused by a recent PR merge.
I didn't do any more digging into the code, just fixed what was failing until it works.
P.S. Thank you for all of the excellent work going on here, I do appreciate it!

Hmm... this is strange. Your changes to JWTBuilder and JWTDecoder were part of my PR #37, but it looks like it was only partially applied in those files.
The JWTBaseBuilder discrepancy is definitely my fault... I was using vscode refactoring and didn't notice that the abstract base was referencing variables it expects to find in the children.

Ah. I see the issue, PR #38 reverted some of the naming


transmitter devices: Add AirPlate Remote ID Pro

Added the AirPlate Remote ID Pro, with BT4, 5 and Wi-Fi Beacon.

@IkeJason I'm curious: Can you tell me what AirPlate's manufacturer ID is (i.e. the first four digits of the serial number)?

Hi @janusw, it's 2048.

Cool, thanks! 👍


[FEATURE] how can i control retry times, when i use StreamChatModel

Is your feature request related to a problem? Please describe.
if llm service sometimes connect failed, how can i control retry times, when i use StreamChatModel? thx.

Right now, you cannot. It would be helpful if you could provide a stack trace or even better: a way to reproduce this issue (if possible).


fix: Upgraded gRPC Java library

Codecov Report

Merging #87 (71b0c10) into main (2331158) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #87   +/-   ##
=========================================
  Coverage     75.26%   75.26%
  Complexity      400      400
=========================================
  Files            54       54
  Lines          1435     1435
  Branches        116      116
=========================================
  Hits           1080     1080
  Misses          329      329
  Partials         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2331158...71b0c10. Read the comment docs.


Get action fails when using docker image tag 0.7.0-rc.1

Hi,
The GET action fails when using the docker image tagged 0.7.0-rc.1, which is supposed to be the most recent if we trust the push date (19 days ago). Note that everything works when using the image tagged 0.7.0 (which semantically should be the most recent, although it has been pushed more than 4 months ago.
Having said that, the error that pops up when using 0.7.0-rc.1 is:
Output directory: /tmp/build/get
Try 1 of 3 to call function `download_version` from module `pypi_resource.in_`
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/pipio.py", line 54, in run
    platform=options.platform,
AttributeError: 'Values' object has no attribute 'platform'
List Versions returned 2
Try 2 of 3 to call function `download_version` from module `pypi_resource.in_`
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/pipio.py", line 54, in run
    platform=options.platform,
AttributeError: 'Values' object has no attribute 'platform'
List Versions returned 2
Try 3 of 3 to call function `download_version` from module `pypi_resource.in_`
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/pipio.py", line 54, in run
    platform=options.platform,
AttributeError: 'Values' object has no attribute 'platform'
List Versions returned 2
-- Failed retrying after 3 tries with a 5.000000 second delay
Traceback (most recent call last):
  File "/opt/resource/in", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/in_.py", line 107, in main
    response = in_(destdir, sys.stdin)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/in_.py", line 82, in in_
    response = download(resconfig, destdir)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/retry.py", line 21, in wrapper
    raise e
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/retry.py", line 15, in wrapper
    result = function(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/pypi_resource/in_.py", line 58, in download_version
    raise ValueError("No matching packages found.")
ValueError: No matching packages found.

After some debugging I believe that the option arguments are not correctly parsed by pip, possibly because pip got updated in the meanwhile, and the assumptions on the underlying parser used by Command in _internal/cli/base_command.py are no longer valid.

Thank you for your patience; I've blocked time tomorrow to investigate.


Storybook Deprecation Cleanup

Fixing a list of issues preventing any upgrade to Storybook 7.0.
This just reduces the warnings in the console as well as prepare all our stories to be built correctly.
See:

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated-controloptions
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#no-longer-inferring-default-values-of-args
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated-scoped-blocks-imports

@grshane those are because we had built those components prior to the icon component being built and so they were commented out until that was implemented. I think we can put in a follow up ticket to go in and connect those pieces

Yeah, that. And I just removed the "broken" story for now so it didn't show up.

Works for me
Gregg Shanefelt
Software Architect
...
c.<PHONE_NUMBER>
s. github | linkedin
Pittsburgh, Pennsylvania
On Dec 17, 2021, 2:16 PM -0500, Josh Mabry @.***>, wrote:

@grshane those are because we had built those components prior to the icon component being built and so they were commented out until that was implemented. I think we can put in a follow up ticket to go in and connect those pieces
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


[FIX] Clarify use of acq and task parameters in EEG, MEG, and iEEG

While @robertoostenveld and I went over #173, we noticed several minor inaccuracies with the entities that recording modalities can have.
This PR mainly targets a consistent and sensible use of the acq parameter, as also discussed in https://github.com/bids-standard/bids-specification/issues/194#issuecomment-480480719
Furthermore, one superfluous task label is deleted from EEG electrodes.
In Robert's words:

My confusion is only with task for headshape/photo/electrodes. Those are measurements which are task-independent. See https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/03-electroencephalography.html#electrodes-description-_electrodestsv which includes task as required. I think that is incorrect. Electrode data is not recorded while the subject performs a task (except for "sit still!")

Is the problem that a particular shape of electrodes cannot be task-dependent? (as opposed to session-dependent?

Fair point - I was assuming that electrodes are set up on the participant only once per session, because I never heard of another design. But of course that doesn't mean it does not exist ... what do you say @robertoostenveld ?

Also can you confirm that this is only updating the text to adhere to the current BIDS spec, and not changing the spec itself?

Given that iEEG electrodes don't have a task label either (see here), I have the impression that in EEG this task label was erroneously copy pasted.

Just to be clear, those points weren't pushing back on either of those assumptions (they seem reasonable to me), just wanted to clarify them!

Is the problem that a particular shape of electrodes cannot be task-dependent? (as opposed to session-dependent?

Fair point - I was assuming that electrodes are set up on the participant only once per session, because I never heard of another design. But of course that doesn't mean it does not exist ... what do you say @robertoostenveld ?

Agreed, I would be fine with the statement that an EEG "session" corresponds to a single application of electrodes on the subject. That does not cover all cases, but should (at this moment) cover >95%. Gel-based EEG electrodes usually require some cleanup. But an example that is not covered: using dry EEG electrodes, e.g. in a BCI experimental setup, and then reapplying the cap or using another cap.

if acq is optional for MEG/EEG/iEEG

The point of this PR is to remove acq for MEG/EEG/iEEG time series, because the parameter does not make sense for data that is not stable (as opposed to a picture of a face, or the T1 scan of a brain)
Thus I would argue that channels.tsv also does not need an acq parameter

task should not be required for eeg/ieeg electrodes (it is just like headshape and photo)

yep, I removed the task parameter for electrodes. see the changes

Example that is not covered: using dry EEG electrodes, e.g. in a BCI experimental setup, and then reapplying the cap or using another cap.

I think we can work with these issues when they pop up.


[CT-1469] init pr for short term python version issue fix

resolves #https://github.com/dbt-labs/dbt-core/issues/6203
Description
Upgrade actions/setup-python from v2 to v4.3.0 to bring in all the updates for deprecations
Defines Python Version to use when installing dependencies
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

@leahwicz this should now be good for review to start the snowflake changes and backports

@McKnight-42 do we want these backport labels like in https://github.com/dbt-labs/dbt-redshift/pull/211?

It doesn't look like https://github.com/dbt-labs/dbt-bigquery/pull/378 or https://github.com/dbt-labs/dbt-spark/pull/508 have the backport labels 🤷

@dbeatty10 they will have to be backported but our gha isn't working on 1.2.latest and 1.1.latest last I checked so have to do those manually

@McKnight-42 who will merge this PR? I am happy to do so if desired. I think our CI will continue to fail until this is merged, so I am waiting for this before merging https://github.com/dbt-labs/dbt-snowflake/pull/280.
Also: who will create the backports for 1.2.latest and 1.1.latest?


Improve table performance

This update brings some modifications on how the table is rendered on the page.
Why
Right now the table could be rendered numerous time without having any props change.
How
We introduce a couple of change on the structure of the table component. On the outside, nothing will change and the render UI will be the same.
Converting PureComponent to Component. Add a shouldComponentUpdate lifecycle method.
By doing this, we can do a deep-equal on the columns and the data, making sure that those two props really change before triggering a render. Since we are passing objects/array as props, PureComponent will re-render unless the object point to the same memory allocation, and as a generic component we can't force that.
Introducing a Head and Body sub-component
Those component wrap the .map function that render each cellHeader or each row. By creating a wrapper around those two loop, we can again add a shouldComponentUpdate and make sure the data or columns really change before triggering a render. That way, we can re-renderer the Head without touching the Body
Changing the isLoading UI state
Before, the isLoading state was fading out the whole table, triggering a browser redraw of each dom element. We added an overlay <div> on top of the table. That overlay will be toggle based on the isLoading prop value
Slicing the collapsed data is done in Body
Before, that slicing action was done in the Table render function causing a re-render on the children because slice will clone the array. Now, the slicing action is done in the Body state, an action that will be executed once when the component is initialize, or when the component will received a new list of items.

I hope those changes will slightly improve the table performance, especially the initial rendering time when there is a lot of state mutation from redux. If anybody has more or better suggestions on how to improve the rendering time (like with cell rendering, which could become a problem with multiple cell renderers + tons of rows), please reach out!

Pull Request Test Coverage Report for Build 2209

66 of 66 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 2206:
0.0%

Covered Lines:
10866

Relevant Lines:
10866

💛  - Coveralls

@plbabin Resolved the merge conflicts 🙌


Improve LoggerCLI log level strings

Add support to 'ALL' string inside the log levels strings
Add function to validate a log levels string
Add a constant explaining the possible values for log levels strings

Codecov Report

Merging #9 (7302ec0) into main (2c9009b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          328       328
=========================================
  Hits           328       328

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9009b...7302ec0. Read the comment docs.


revert field number change

Signed-off-by: Katrina Rogan<EMAIL_ADDRESS>TL;DR
Reverts field number that was accidentally changed in https://github.com/flyteorg/flyteidl/commit/e46cb9fd7163a2426e1db63dea6f7326cb86de6a#diff-724a7e8bb673471da21d8cb4a8ef634198bc10cc7b61965a920673c2b7408a54L238
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

closing in favor of https://github.com/flyteorg/flyteidl/pull/127


How to pass props to replaced by "as" polymorphic prop component

Let`s say there are 2 components, Button and Link:
const Button = styled.button`
  background: ${props => props.primary ? 'red' : 'none'};
`;

const StyledLink = styled.a`
  font-size: 13px;
  color: ${props.unstyled ? 'inherit' : 'yellow'};
`;

const Link = props  => (

);

How to create primary Button as unstyled Link (+some extra styles)?
I tried something like this, but unsuccessfully (Button styles are not considered)
const StyledButton = styled(Button)`width: 200px;`;
const LinkButton = (

);

As a result I want
Click me
// styles
background: red;
font-size: 13px;
color: inherit;

Is it even possible? I am confused. Please, help.

Link needs to consume the className prop
On Sat, Dec 8, 2018 at 3:35 AM Olexiy Letushev<EMAIL_ADDRESS>wrote:

Let`s say there are 2 components, Button and Link:
const Button = styled.button  background: ${props => props.primary ? 'red' : 'none'};;
const StyledLink = styled.a  font-size: 13px;   color: ${props.unstyled ? 'inherit' : 'yellow'};;
const Link = props  => (


Find if the content exceeds the textview height

Hi,
I have a textview that toggles trimming using a separate button placed outside instead of the read more link within the textview itself. Much like one in the project's example. It works fine when there is text longer than the height of the textview.
There is however a side effect. If the text is small, there is no need to toggle the trim button. I need to hide it if the content does not exceed the bounds of the textview.
Is there a way to find this out?
I tried getting the contentSize of the textview but it seems to be inaccurate. The content height and the textview frame height returns as equal.
Demo project

You can try to use boundingRectForCharacterRange(range:inTextContainer:) -> CGRect to get the size of the full text range and then compare it with the size of text view.

I'm not getting a value even less than what I got using contentSize. Below is my code.
let rect = textView.layoutManager.boundingRectForCharacterRange(range: NSRange(location: 0, length: textView.text.count), inTextContainer: textView.textContainer)
print("TEXT HEIGHT: \(rect.height)")

Am I using it correctly?

it might not respect text margins

There are no margins though. The textview's height is 128. I have two long paragraphs in it. But the boundingRectForCharacterRange method returns 100 as the value.

Try to ask on stackoverflow
On 28 Feb 2018 06:08, "Isuru Nanayakkara"<EMAIL_ADDRESS>wrote:

There are no margins though. The textview's height is 128. I have two long
paragraphs in it. But the boundingRectForCharacterRange method returns
100 as the value.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ilyapuchka/ReadMoreTextView/issues/40#issuecomment-369132721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABa1pejEFmhzott004u0mP5p4ikwrUuhks5tZO1ygaJpZM4SSM1e
.


Uniqueness requirement for UnsafeCell aliases violated in oneshot.rs

https://github.com/tweedegolf/async-heapless/blob/835ae89c5adec0c5183a63effc526ed8806e7ce1/src/oneshot.rs#L175-L177
It is claimed that put and take can be called concurrently. Both methods call UnsafeCell::get()

Ensure that the access is unique (no active references, mutable or not) when casting to &mut T

But put calls MaybeUninit::write() which casts it to &mut MaybeUninit<T>. You do not guarantee that the reference is unique, given that there could be a concurrent &MaybeUninit<T> in a concurrent call to take.

Nevermind, this is fine. The aliases should never exist at the same time.


fix monitor_job to not look at timeout

the timeout is for resizing pools not for task timeout, so we often get an error that the task failed to finish when it it still running fine in Azure

defaulting to 8 hours timeout


Add left/right arrow to navigate across columns in multi-column completion menu

Right now I have to press up/down arrow or use Tab key to cycle through the suggestions. But it will be more powerful if we let the user jump between columns using left/right arrow keys.

See also: https://github.com/jonathanslenders/ptpython/issues/46
This is ambiguous, because left/right already means: "move the cursor". What I guess I will do is support left/right, but only after down has been pressed at least once to select a completion. If no completion has been selected, it will still move the cursor.

Yes that would be ideal behavior.
While you're doing that I'm wondering if you can make the down/up arrows only work after the tab key is pressed? This will allow me to start typing a partial query and then press up arrow to navigate the history that match the partial query and not select something from the menu.

I'd like for it to work like zsh:

It probably sounds silly, but I use this so often that I'm actually sticking to zsh until this is available.

@jonathanslenders any chance you could point me to the spot(s) in the code that might need to change? If it looks straightforward (~1-3 hours) I'll see if I can write a PR. I saw PathCompleter and KeyPress and it looks like completer in interface.py gets created, but I'm not sure where the up/down keypresses go so I can forward & handle left right keypresses too.

Hi @ahundt,
Thank you for the offer, but unfortunately, it's not that obvious. It has to be implemented as a key binding, But the completions list is a one dimensional list of completions, while it's the CompletionsMenu that knows how many columns were displayed during the last rendering. From the key bindings it's not obvious to get access to the menu. Probably you'd have to traverse the whole layout recursively.
Probably, I'd also like this to be implemented as a prompt_toolkit 2.0 feature, where the  architecture is a bit more flexible to do these things.

Ah yes that does sound tricky. Well, thanks for the explanation!

This has been implemented for 2.0, so I'm closing this issue. Feel free to open again if it still doesn't work.

I gave this a try in 2.0 and it works well, thanks!


Replace AsyncTask in RemoteVerifyJob and SubmitSampleJob with Executor

Both files were using AsyncTask to execute their job. Now deprecated, AsyncTask needs to be replaced.
Executor is the choice in this case for issue  #72
The app compiles but I couldn't properly test a remote verification and submitting a sample.
In both files, the classe implements Runnable and execute a run method returning void.
The return from the old AsycTask's implementation are in comment.
Not sure about the implementation for stopping the job.

Can you rebase this? I'm confused by the series of commits.

It's going to need to be cleaned up in order to merge it. Maybe I can ask someone to help you figure that out. It should be either 1 commit or 2 commits (1 per class making this change) without the other stuff.


setup.py error message without format value

See https://github.com/rmorshea/idom/blob/master/setup.py#L61. This should insert the path to extras.txt in the error message.

Already fixed.


Client verification: FAIL.

i get the message [GameVerifier]: Client verification: FAIL.

Are you on the cracked version, or beta, or non steam version?

setting it up for a friend, he isn’t here . it might be the cracked version
On Mon, 2 Nov 2020 at 2:31 PM, CarbonNeuron<EMAIL_ADDRESS>wrote:

Are you on the cracked version, or beta, or non steam version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/denverquane/amonguscapture/issues/77#issuecomment-720473497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARTJVTILIUP7H7VO7435VSTSN2YETANCNFSM4THONNNQ
.

yea it’s the cracked version , does that matter ?
On Mon, 2 Nov 2020 at 2:32 PM, Toby<EMAIL_ADDRESS>wrote:

setting it up for a friend, he isn’t here . it might be the cracked
version
On Mon, 2 Nov 2020 at 2:31 PM, CarbonNeuron<EMAIL_ADDRESS>wrote:

Are you on the cracked version, or beta, or non steam version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/denverquane/amonguscapture/issues/77#issuecomment-720473497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARTJVTILIUP7H7VO7435VSTSN2YETANCNFSM4THONNNQ
.

Lol.
We don't support the cracked version.


[BUG] Accessing alt on ExternalImage throws error

Expected Behavior
The following code should not throw an error and crash the site:
$url = 'https://paulmh.xyz/art/get-out-of-your-head/get-out-of-your-head.jpg';
$context['cover_image'] = Timber::get_external_image($url);

<img src="{{ cover_image.src }}" alt="{{cover_image.alt}}" />

(I'm a little confused about how you would set the alt on an ExternalImage. My real-world use case is a twig template that accepts a Timber Image and can be used for external or local images. For external images I would expect to get an empty string back.)
Actual behavior
I get an error, and my site crashes
Fatal  error: Uncaught Error: Typed property Timber\ExternalImage::$alt_text  must not be accessed before initialization in  /Users/paulhebert/repos/cloudfour/app/public/vendor/timber/timber/src/ExternalImage.php  on line 476

Steps to reproduce behavior

Add an external image to your page context using Timber::get_external_image
In your twig template, access the alt property on the image.

Notes
No response
What version of Timber are you using?
v2.0.0 RC.1
What version of WordPress are you using?
6.3.2
What version of PHP are you using?
8.2.10
How did you install Timber?
Installed or updated Timber through Composer

Digging in the source a bit, I think the bug lies in how ExternalImage:build works. On line 150 there's the following code:
        if (!empty($args['alt'])) {
            $external_image->alt_text = (string) $args['alt'];
        }

This means if there's no alt, or alt is an empty string then the property is never initialized and it throws an error when you access it. I'd prefer the value to be set to an empty string in this scenario so that if I try to access it I don't get errors.
Something like this:
        if (!empty($args['alt'])) {
            $external_image->alt_text = (string) $args['alt'];
        } else {
            $external_image->alt_text = '';
        }

Would you be open to a PR with this change? Alternately, is there a way within my Twig template to check if the variable has been initialized or not?

Alternately, is there a way within my Twig template to check if the variable has been initialized or not?

Yes, there is, the default filter: {{ alt|default('') }}
See https://twig.symfony.com/doc/3.x/filters/default.html

Thanks @jrathert ! Unfortunately both of those options still throw the same error 🤔

Ooops. Yes, you are right. It seems this bug is actually caused by the fact, that the respective property of ExternalImage:
    protected string $alt_text;

is not initialized as it is a typed, non-nullable property and you are using PHP >=7.4. (This behavior - not initializing typed properties - was only introduced in PHP 7.4). We have the same problem with the caption property.
Your workaround is probably a good solution for now, but of course fixing the root cause (probably by initializing $alt_text and $caption to "", or by always setting the respective values in the build() function (see lines 150-156)) would be the better solution.

That makes sense

Your workaround is probably a good solution for now, but of course fixing the root cause (probably by initializing $alt_text and $caption to "", or by always setting the respective values in the build() function (see lines 150-156)) would be the better solution.

Yeah, this makes sense to me. Even initializing it to null might work while being more explicit?

Initializing to null will only work if we change the type to ?string, and also the signature of the respective methods. Do not know what side-effect that would have.
The whole code is a bit, let's say, interesting: The $args value gets set to default values (alt and caption in Timber::get_external_image(), but only alt in ExternalImage::build() - but these default values have no effect anyway as they are considered empty in lines 150-156 of ExternalImage.php. Why setting them at all, then? (And btw. removing the test for emptiness would also be a solution to the problem...)

@Paul-Hebert - I submitted a PR fixing this issue. I did not want to make it too difficult, so decided to use empty strings as default values for both, alt and caption. Let's see what the team says. Thanks for raising it!

Awesome, thanks @jrathert!

Resolved in #2818.


Cleaning up query param matching spec

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a small follow up to #631 that addresses some of the tiny nits that were leftover on that PR.
Does this PR introduce a user-facing change?:
NONE

/cc @bowei @hbagdi @youngnick

/lgtm
Perfect, thanks!


Upgrade or replace the yaml NPM package to fix the vulnerability

There is a Snyk security vulnerability in the yaml NPM package in OSS which first appeared in the release candidate PR.
Sample run:
https://github.com/weaveworks/weave-gitops/actions/runs/4789624382/jobs/8517929595?pr=3636
Run snyk test --org=product-engineering-ly9 --json --file=go.mod | snyk-delta
No new issues found !

New issue introduced !
Security Vulnerability:

  1/1: Uncaught Exception [High Severity]
    Via<EMAIL_ADDRESS>    Fixed in: yaml 2.2.2
    Fixable by upgrade<EMAIL_ADDRESS>
Vulnerability:
https://security.snyk.io/vuln/SNYK-JS-YAML-5458867
Upgrade or replace the yaml package to fix the vulnerability.

Initial research:

There is a reference error in Tilt, after upgrading the yaml package version to 2.2.2, attached the screenshot.
We already had this hard-to-debug issue with new versions of the yaml before, in version 2.1.1, and I rolled the package back to 1.10.2 to fix it. Here is the old PR, c. June 2022:
https://github.com/weaveworks/weave-gitops/pull/2306/files
So, if we update the package, the app does not run because of the ReferenceError, possibly because the yaml package is incompatible with parcel. if we don't upgrade the package, we have this vulnerability.
As far as I can see, we only use this package to stringify object as YAML in ui/lib/object.ts.
Maybe we can use an alternative package instead of yaml .

A similar parcel issue:
https://github.com/parcel-bundler/parcel/issues/8792


Element misalignment on landing page

There are a misalignment in the second section (visible) of the landing page.
I can see the first and second section correspond to a similar alignment according to the rest of elements.
I think the second section expands too much and looks bad visually since it expands the width of the video

In my POV there are another visual errors on the same landing page but probably is for my lack of context.

@mendozagioo Thanks for bringing this into a formal issue :D.
Indeed the alignment of the second section must be aligned.


Publishing large data sources in chunks throws error

I am trying to publish a data source as a .hyper extract to a tableau server (2018.1). When I create a new data source and try to publish it to the server, it throws an error when the file is large enough that it needs to be uploaded in chunks. When the file is small enough, it uploads to the server without any issue. Here is code I'm using to upload to the server:
data_source = TSC.DatasourceItem(project.id)
new_data_source = server.datasources.publish(data_source, file_path,
 TSC.Server.PublishMode.CreateNew)

And the error with a large .hyper extract is:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-36-013c7545ba56> in <module>()
----> 1 new_data_source = server.datasources.publish(data_source, file_path, TSC.Server.PublishMode.CreateNew)

/Users/aaron.wiegel/anaconda3/envs/Fathom/lib/python3.4/site-packages/tableauserverclient/server/endpoint/endpoint.py in wrapper(self, *args, **kwargs)
    112         def wrapper(self, *args, **kwargs):
    113             self.parent_srv.assert_at_least_version(version)
--> 114             return func(self, *args, **kwargs)
    115         return wrapper
    116     return _decorator

/Users/aaron.wiegel/anaconda3/envs/Fathom/lib/python3.4/site-packages/tableauserverclient/server/endpoint/endpoint.py in wrapper(self, *args, **kwargs)
    150                     error = "{!r} not available in {}, it will be ignored. Added in {}".format(p, server_ver, min_ver)
    151                     warnings.warn(error)
--> 152             return func(self, *args, **kwargs)
    153         return wrapper
    154     return _decorator

/Users/aaron.wiegel/anaconda3/envs/Fathom/lib/python3.4/site-packages/tableauserverclient/server/endpoint/endpoint.py in wrapper(self, *args, **kwargs)
    150                     error = "{!r} not available in {}, it will be ignored. Added in {}".format(p, server_ver, min_ver)
    151                     warnings.warn(error)
--> 152             return func(self, *args, **kwargs)
    153         return wrapper
    154     return _decorator

/Users/aaron.wiegel/anaconda3/envs/Fathom/lib/python3.4/site-packages/tableauserverclient/server/endpoint/datasources_endpoint.py in publish(self, datasource_item, file_path, mode, connection_credentials, connections, as_job)
    187             xml_request, content_type = RequestFactory.Datasource.publish_req_chunked(datasource_item,
    188                                                                                connection_credentials,
--> 189                                                                                connections)
    190         else:
    191             logger.info('Publishing {0} to server'.format(filename))

TypeError: publish_req_chunked() takes from 2 to 3 positional arguments but 4 were given

Thanks in advance and let me know if you need more information.

Realized that this was already addressed in this commit, any chance of that being merged into the master branch soon?

#422 Should have hte fix for this.


initial attempt to port to 7.0.1

Ok, I've made an attempt at porting.
However, there are still some issues.  Everything compiles, but an exception is thrown when starting the Example wizard.
There are 2 places I've made changes I'm not 100% sure about:
diff --git a/modules/gui/src/de/diedavids/cuba/wizard/gui/xml/layout/loaders/WizardStepLoader.java b/modules/gui/src/de/diedavids/cuba/wizard/gui/xml/layout/loaders/WizardStepLoader.java

-        resultComponent = (WizardStep) factory.createComponent(WizardStep.NAME);
+        resultComponent = (WizardStep) componentsFactory.createComponent(WizardStep.NAME);

I'm not sure where factory came from before (it wasn't compiling).  There were a few lines where I made this change.
diff --git a/modules/web/src/de/diedavids/cuba/wizard/web/gui/components/WebWizardStep.java b/modules/web/src/de/diedavids/cuba/wizard/web/gui/components/WebWizardStep.java

-public class WebWizardStep extends WebVBoxLayout implements WizardStep {
+public class WebWizardStep extends WebFragment implements WizardStep {
     private String name;
     private WizardStepAware stepComponent;
     private TabSheet.Tab tabComponent;
@@ -66,7 +66,7 @@ public class WebWizardStep extends WebVBoxLayout implements WizardStep {

     private WizardStepAware getWizardStepAware() {
         if (ownComponents.size() > 0) {
-            return (WizardStepAware) ownComponents.get(0);
+            return ((WebWizardStep)ownComponents.get(0)).stepComponent;
         }
         else {
             return stepComponent;

I'm really not sure about this.  Line 66 is where the exception is being thrown.  It is saying that it can't cast an instance of ....WebFragment to ...WizardStepAware.

hi,
thanks for reaching out! I will try to take a look at it.
What about this change here: https://github.com/mariodavid/cuba-component-wizard/pull/8/files#diff-e0c4ff239857dc7827ba4fe4ec3c1024R9
I'm actually not sure :)
Bye
Mario

Hi Mario,
I had also attempted to port to 7.x similarly to @typerlc 's port above,
I got the same errors from the attempts to cast from WebFragment to WebStepAware,
Looking into the causes it appears that the inheritance from parent classes shared between WebFragment to AbstractFrame have changed in versions 7.x,
I wasn't sure if it might have been possible to add a function to the WizardStepLoader to allow the WizardStep implementation to be cast to WizardStepAware at runtime etc, but (in terms of a simple port) I didn't manage to find any shared components that AbstractFrame has with other web components that WebWizardStep could extend to maintain the same logic,
I had hoped to be able to do a simple port and just update some of the classes to replicate the same behavior by using the newer API's in version 7.x but sadly it seems (at least from looking at it) that some important portions may need to be redesigned,
Anyway I thought it might be useful to you outline what I found from attempting to port it across to 7.x,
Cheers,
-T

hi,
thanks both of you for taking a try to update it.
I've looked at the PR and it seems that you are right @tcolemancas - it seems that there some not so easy to resolve changes. Actually I expected this to happen for this app component unfortunately.
I haven't made up my mind on how to solve this - but I would be more then happy if you come up with just some ideas on how to solve it. Even if this means breaking changes, it does not really matter at this stage of the app component.
Bye
Mario

Hi, I started on another upgrade attempt without even seeing this one.
I made a pull request for it. My version uses the v7 api though so it's not fully backwards compatible. More info in the forum discussion https://www.cuba-platform.com/discuss/t/cuba-component-wizard-preview/6617/4

@typerlc, @tcolemancas & @mariodavid can you have a look at my pull request. It's not using the old api, but at least for the included sample it seems to work with some changes for using the new api (eg. @Inject Notifications).
Not sure if more complex flows would also work. Would it be acceptable for you guys to to migrate or do you require full backwards compatiblity?
regards,
Tom

Hi,
i've taken this PR as a basis and fixed the class cast exception via some internal casting compatible to CUBA 7.0. See: https://github.com/mariodavid/cuba-component-wizard/pull/10

I'll close this PR as the other one contains the sources from here.
Thanks again @typerlc & @tcolemancas for the collaboration. Really appreciate it!


MolDraw2D should automatically set bond highlight color when atom colors are changed

Describe the bug
I noticed this while putting a tutorial notebook together.
Here's some code:
d2d = Draw.MolDraw2DSVG(250,200)
c1 = (.3,.3,1)
d2d.DrawMolecule(m,highlightAtoms=[0,1,2],highlightAtomColors={0:c1,1:c1,2:c1})
d2d.FinishDrawing()
SVG(d2d.GetDrawingText())

And the result:

Expected behavior
The bonds there should be the same color as the atoms. If the two end atoms are different colors, then it's fine to pick one of them.
Configuration (please complete the following information):

RDKit version: master
OS: all

Thanks Greg. I’ll take a look over the weekend.
Dave
On Fri, 28 Oct 2022 at 04:16, Greg Landrum @.***> wrote:

Describe the bug
I noticed this while putting a tutorial notebook together.
Here's some code:
d2d = Draw.MolDraw2DSVG(250,200)
c1 = (.3,.3,1)
d2d.DrawMolecule(m,highlightAtoms=[0,1,2],highlightAtomColors={0:c1,1:c1,2:c1})
d2d.FinishDrawing()
SVG(d2d.GetDrawingText())
And the result:
[image: image]
https://user-images.githubusercontent.com/540511/198493425-a9548a9f-e9de-47a1-b164-b7672fc722d2.png
Expected behavior
The bonds there should be the same color as the atoms. If the two end
atoms are different colors, then it's fine to pick one of them.
Configuration (please complete the following information):

RDKit version: master
OS: all

—
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/5704, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGF2FXIGMAWMNQE5CE74CDWFNAPZANCNFSM6AAAAAARQU2YOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
David Cosgrove
Freelance computational chemistry and chemoinformatics developer
http://cozchemix.co.uk

Thanks Greg. I’ll take a look over the weekend. Dave

I'll do this one Dave (that's why I assigned it to me)... I want some practice playing with the MolDraw2D code too.


Arrows disappear on some dataflows

Describe the bug
Arrows disappear on some dataflows
Expected behaviour
Arrows always should be present on  all dataflows
Environment

Version: 2.0
Platform: both Web App / Desktop App
OS: all of MacOS / Windows / Linux
Browser: any, chrome, firefox, safari

To Reproduce
Not yet reproducible
Any additional context, screenshots, etc
User reports "Arrows disappear on some dataflows"

unable to reproduce this, so closing


Improve ffmpeg exit logging

I'm setting up a new camera on a new system, and I got this error message:
[7/2/2020, 9:34:48 PM] [Camera-ffmpeg] [FFMPEG] ffmpeg exited with code: 1 and signal: null (error)
That is despite having debug enabled (cameras[].videoConfig.debug: true) . Clearly, there are not enough details to help me troubleshoot the issue.
I wish I could more easily see FFmpeg error output. Maybe include a path to a log file?

Install beta to see if this resolves it?
sudo npm install -g —unsafe-perm homebridge-camera-ffmpeg@beta

Beta still has poor FFmpeg exit logs. That can be seen by comments in #575

I was doing some research and found that back in the day (2018) this library used to have complete ffmpeg logs, check out issue  #229 . Having such complete log output would help users to troubleshoot issues listed in #575


add configuration processor to generate metadata json for auto complete

Description
Support auto complete for properties, but the List property in yaml is not supported well, the i.e. the spring.cloud.azure.config.stores here.

Codecov Report

Merging #420 into azure-config will not change coverage.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             azure-config     #420   +/-   ##
===============================================
  Coverage           53.44%   53.44%
  Complexity            615      615
===============================================
  Files                 152      152
  Lines                2730     2730
  Branches              152      152
===============================================
  Hits                 1459     1459
  Misses               1184     1184
  Partials               87       87

Impacted Files
Coverage Δ
Complexity Δ

...pring/cloud/config/AzureCloudConfigProperties.java
87.01% <100%> (ø)
22 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c32e56...b377c11. Read the comment docs.


flutter build or xcode archive get ipa,Flutter.framework size is different.

flutter build or xcode archive get ipa,Flutter.framework size is different.
build -release: 202.6M
build- debug: 33.4M
arichive: 7.7M

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, 1.24.0-7.0.pre, on Mac OS X 10.15.7 19H15 darwin-x64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] Connected device (4 available)
    ! Error: Walter的iPad is busy: Waiting for Device. Xcode will continue when Walter的iPad is finished. (code -10)

• No issues found!

Hi @len8657
Please check out https://flutter.dev/docs/perf/app-size, to read more app sizes
App sies could vary for various reasons between debug and relase, hope this helps
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @len8657
Please check out https://flutter.dev/docs/perf/app-size, to read more about app sizes
App sies could vary for various reasons between debug and relase, hope this helps
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

I have read this article. The information provided in the article cannot answer my doubts.
I had find some information in Xcode archive Packaging.log
2020-12-14 01:31:37 +0000          $ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip -r -o /var/folders/td/4819yvmx4md_xm0jj_m02p140000gn/T/ipatool20201214-85786-1waez9s/thinned-out/arm64/Payload/Runner.app/Frameworks/Flutter.framework/Flutter /var/folders/td/4819yvmx4md_xm0jj_m02p140000gn/T/ipatool20201214-85786-1waez9s/thinned-in/arm64/Payload/Runner.app/Frameworks/Flutter.framework/Flutter
I use '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/bitcode_strip -r -o ' bitcode_strip, Flutter.framework size from 202.6M to 7.7M.
flutter build -release, xcode arichive  ,two way is different.
I want to understand what happened in this process

@len8657
Please take a look at this issue https://github.com/flutter/flutter/issues/64626 and https://github.com/flutter/website/issues/4852


Unleash Edge does not reflect any custom hooks or logic added to the API

Describe the feature request
Unleash Edge should reflect any custom hooks used in the Unleash API
Background
I'm using the OSS version of the Node unleash-server and have been experimenting with Unleash Edge locally using the official docker image.
My API has the default API token middleware enabled (meaning that all requests require an API token), but includes a pre-router hook that allows for calls to be made to /api/client endpoints even if an API token is not included.
When using Unleash Edge, I'm able to connect and run everything just fine, but it disregards the custom hook and goes back to the default behaviour of requiring all requests to include an API token.
I'm unsure if this is a bug or intended behaviour (or user error on my part), but it effectively prevents any custom hooks from being executed when accessing the API through Edge.
Solution suggestions
Unsure of what the most effective solution would be for this, as I am unfamiliar with most of the Unleash/Edge operating logic.
One solution may be to let the API itself handle the authentication (either by default or just conditionally if a customAuthHandler, preHook  or preRouterHook is specified). Of course, this may impact the performance and resilience of Edge's design.
Happy to hear proposals others may have, if any.

Hey @00Chaotic!
If I'm understanding you correctly, it sounds like you're wanting to allow Edge to connect to Unleash but you don't want Edge to require an API token when a downstream SDK connects?
Unfortunately, I'm not sure that's easily possible with Edge and I don't think it's something we'd want to support directly (you're always welcome to fork and extend!) The tokens that Edge uses are pretty deeply entwined in the way it works and Edge is really meant for secure, large scale production setups. To give you a sense of why this would be hard:

Edge uses the incoming token to determine project and environment so that it can return the correct toggles for a request
Edge needs a valid token(s) to sync to the upstream instance for the correct projects and environments, in a lot of cases this is dynamically determined, based on which tokens it's seen in during its runtime
Frontend api calls require this to determine the matching toggles for the API request
Edge also uses the tokens to store the relevant toggles in it's internal memory cache by project/environment
Metrics for incoming SDKs are stored and sent on a per project and environment basis (based off the token)
Likewise for persistent caches like Redis

However, Unleash itself also needs this information in the api/client/features endpoint to work out the correct set of toggles to return for a request (for OSS this is typically the difference between returning toggles for your production environment and toggles for your development environment). I'm guessing you've done something smart to handle that in your prerouter hook? Without token auth you risk leaking a whole bunch of potentially sensitive information so I would be very careful about using that setup in prod. Is there an important reason why you need Unleash to ignore incoming token auth?
I'm not sure Edge is a good fit for what you're trying to doing here, most of what Edge can do for you is based on information encoded in the token itself. Could you tell me a bit more about what you're trying to achieve and maybe I can suggest an alternative?

@sighphyre Thanks for getting back to me.
In our case, we were already using Unleash v3 and migrated to v5, which has meant that all our existing (and possibly future) toggles are in the default project and environment, leaving the other two OSS environments unused. We also have separate instances of Unleash for each of our environments (from before environments were added to Unleash), so we only really use the default environment for the time being. We do have plans to consolidate this down to just once instance but those plans have not yet been implemented.
In terms of security, our Unleash API is behind our own SSO proxy (not sure of the exact terminology to best describe it) so that the server is actually not accessible unless you're authenticated. This will obviously also be the case for when we implement Edge. While there are some thoughts on additionally using Unleash's normal auth further down the line, for the time being we just use the demo auth to allow essentially an open login as long as the employee/service is authenticated via our own proxy.
In terms of why we need the ability to allow requests that don't use API tokens, that is because we already have numerous services using our Unleash API, so in order to minimise disruptions and prevent the need for batch changes, we've implemented middleware that accepts API tokens, but also allows services that haven't migrated yet to continue functioning while their teams work on implementing the changes.
I understand that this may be an uncommon or even unique case, and it seems API tokens are a fundamental block of the way Edge is designed, so I don't expect changes to be made to Edge. We may just need to wait till all our client services have migrated to using API tokens before we implement Edge.
I'm happy for this issue to be closed if there is no further action to take or discussion to be had.

Thanks for the detailed response @00Chaotic, I have a much better understanding of what you're doing and why. That makes a lot of sense

We may just need to wait till all our client services have migrated to using API tokens before we implement Edge.

This would be my gut feel as well. We probably could work a hack here here but I suspect that's just going to cause more pain. Unless you're in desperate need of better scaling systems then I would just wait it out.
I'm trying to keep Edge as focused as possible on it's primary use cases, so I'm going to close this one. But absolutely feel free to grab us on our Slack if you need to talk about scaling


[Flaky Test] PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithUpdate()

Failures:
PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithUpdate:106->validateJob:245 expected [0 */20 * ? * * *] but found [0 */10 * ? * * *]

Example run: https://github.com/apache/pinot/runs/6597477355?check_suite_focus=true

After some time thinking about this test and understanding how it works, I think the test was designed with this scenario in mind:

sequenceDiagram
    Test->>+Controller: update table config (0 */20 * ? * * *)
    Controller->>+Helix: update table config (0 */20 * ? * * *)
    Helix->>Helix: Change ideal state to (0 */20 * ? * * *)
    Helix->>-Controller: Ok
    Controller->>-Test: Ok

    Test->>+Controller: get job info
    Controller->>+Helix: get job info
    Helix->>-Controller: updated job info (0 */20 * ? * * *)
    Controller->>-Test: updated job info (0 */20 * ? * * *)

But I think Helix does not guaranteed that the sequence and sometimes, due to the lack of resources in GHA, we may find this scenario:

sequenceDiagram
    Test->>+Controller: update table config (0 */20 * ? * * *)
    Controller->>+Helix: update table config (0 */20 * ? * * *)
    Helix->>Controller: Ok
    Controller->>-Test: Ok

    Test->>+Controller: get job info
    Controller->>+Helix: get job info
    Helix->>-Controller: updated job info (0 */10 * ? * * *)

    Helix->>-Helix: Change ideal state (0 */20 * ? * * *)

    Controller->>-Test: updated job info (0 */10 * ? * * *)

If that is the case, the palliative solution is to retry the validation with some timeout.


Share JSON link

I have read the code, it is very neat and clean, and I would like to parse data from my own JSON, instead of using any third party API
Can you share sample JSON ? So I'll prepare same kind of JSON for me to work with your app.
Thanks

I need this too. @pabloazana